Cloud assembly schema version mismatch: Maximum schema version supported is 14.0.0, but found 15.0.0

I follow the instruction on https://catalog.us-east-1.prod.workshops.aws/v2/workshops/fc36cb5a-de1b-403f-84dd-cc824390c548/en-US/20-environment-setup/24-deploy-the-backend
If I am working with aws-cli v1, I will have the following error:

This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version.
(Cloud assembly schema version mismatch: Maximum schema version supported is 14.0.0, but found 15.0.0)

If I am working with aws-cli v2, I will have the following error:

The security token included in the request is invalid

Also if aws-cli v2 is used, the line 21 in update-upgrade-install.sh should be update
npm install -g<EMAIL_ADDRESS>

Sorry for the issue. As you noticed, I forgot to update update-upgrade-install.sh.
Fixed with the commit 776da4e.
If you have a running environment, just run source config.sh again, from the infrastructure folder, and it will fix your environment.
The config.sh script must be run again not only to update your CDK version, but also to upgrade the CDK bootstrap infrastructure within your AWS account/region.

Sorry for the issue. As you noticed, I forgot to update update-upgrade-install.sh.
Fixed with the commit 776da4e.
If you have a running environment, just run source config.sh again, from the infrastructure folder, and it will fix your environment.
The config.sh script must be run again not only to update your CDK version, but also to upgrade the CDK bootstrap infrastructure within your AWS account/region.


entities review doc0042

[ ] "AUGUST I968" -> like with the Weinheber poem(s), this is a particular version of the poem, thus it needs to be at the same hierarchical level as, say, the Weinheber poem version from 15 Mar 1965
[x] "we" -> Auden and Kallman
[x] "kitchen" -> empty placeholder entity (we don't know which restaurant yet)
[ ] "ELEGY" -> same as above; not THE poem "Elegy", but one version of that poem
[ ] "Emma Eiermann" -> as I already mentioned with regard to the Weinheber poem: we need to find a clear rule: either we tag ALL entities in poems or NONE - we should discuss this! I think we should markup all, but then a lot of entity markup is missing esp in the Weinheber poem ...
[x] "Frau E" -> include "Frau "

I think we should mark them all as well; let's solve this by end of next week


Update models for Backslot Item Scaling Enhancments

This updates all of the models that are affected by the changes I'm proposing for BackSlot & Addon more info here: https://github.com/Globox1997/BackSlot/pull/62

.json Updates
Version Bump

Thanks for contributing :)


Find anomalies in the prescribed medication or suggested care plans or procedures

Hi, I am planning to develop an anomaly detection system on Synthea dataset. The goal is to find any anomaly in either of the following-

Medication
Care plan
Procedure
But I am facing challenges while merging all the CSVs into one. Any kind of help in merging all the CSVs will be highly appreciated.

Well, the CSV files are relationally linked, so merging them into one giant table is possible, but weird. The biggest issue will be how you choose to handle time.
Please see the CSV File Data Dictionary, if you haven't already.
Here is the overview:

The central table is Patient.
Each patient has multiple Encounters, each with a different date.
The other tables are linked to Encounter. In other words, an encounter has (or contains) a variable number of conditions, procedures, medications, and so forth.

If you want "one CSV file to rule them all", you'll have to think about how you handle time... each time is a separate row, or each time is a separate column (in which case, you'll have a variable number of columns).
Hope that helps.

Thanks Jason. But I still have the confusion. Could you please explain how can I join just the Careplan and Medication csv?

Well, it is up to you to use whatever tools or techniques you want to join them.
That being said, the careplans file has links to encounters:
careplans.encounter == encounters.id

Similarly, the medications file has links to encounters:
medications.encounter == encounter.id

So, if you want to join the careplans and medications tables together you join them on encounter
careplans.encounters == medications.encounters

Of course, joining careplans and medications might not make any sense, because each encounter might have many things occurring that are unrelated. For example, in an encounter a doctor prescribes a patient medication for an ear infection, and also gives them a care plan to stop smoking and diet. Those things have nothing to do with each other.


is it possible to move common properties to base class

public class BaseModel {
@JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss.SSS")
private Timestamp createdAt;

@JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss.SSS")
private Timestamp updatedAt;

}
@Document(collection = "user", schemaVersion = "1.0")
public class User extends BaseModel {
}

I have simply tried by extending!!
Getting below exception!!
java.lang.NullPointerException
at java.util.TreeMap.getEntry(TreeMap.java:347)
at java.util.TreeMap.get(TreeMap.java:278)
at io.jsondb.CollectionMetaData.(CollectionMetaData.java:103)
at io.jsondb.CollectionMetaData.builder(CollectionMetaData.java:213)
at io.jsondb.JsonDBTemplate.initialize(JsonDBTemplate.java:122)
at io.jsondb.JsonDBTemplate.(JsonDBTemplate.java:102)
at io.jsondb.JsonDBTemplate.(JsonDBTemplate.java:82)

JsonDB does not implement its own restrictions, it expects every model class is valid Java Bean.
"Every object that you wish to save in JsonDB must be a POJO (Plain Old Java Object) that satisfies the JavaBean programming conventions. Each object must implement either Serializable or Externalizable, must have a no-arg(default) constructor, and each of its properties(attributes) must have public setter and getter methods. The names of these methods must be as per the JavaBean naming conventions."
So if your class implements the Java Bean conventions it should work perfectly fine. What you have posted above does not implement the Java Bean Convention for sure.


sha3.v wrong implementation

I was reading the code of sha3.v and noticed that the actual implementation in it is SHA2-512, you can read the end of file comment reporting sha512_core.v or read the implementation to see that is not containing the Keccak algorithm in it.
line 595 contains the implementation of the Ch function of SHA 512 as described in
https://en.wikipedia.org/wiki/SHA-2
this function is not part of the SHA3 algorithm

Sorry, we don't really care. We make no promises about these designs doing what's on the tin: just that OpenLane can harden them. We're not opposed to a PR to fix them but we are not going to dedicate time to this ourselves.


Proxy howto URL to new Github Pages versoin

@mbarrenechea I got rid of all the images and current howto related things, let me know if any of them are needed elsewhere


When converting json to text it is converting characters weirdly

When converting json data to a text or csv it is converting characters like ’ to â€™
I see that changing it to use UTF will supposedly fix it according to other documents, but I only see the use case when reading the file and not writing/creating the document.
In your documentation it says that 'txt' is UTF-16, but "string" is UTF8. How would I go about changing that, or can I?
        var workSheet = XLSX.utils.json_to_sheet(results);
        var workBook = XLSX.utils.book_new();

        XLSX.utils.book_append_sheet(workBook, workSheet);
        var content = XLSX.write(workBook, { bookType: 'txt', type: 'string' });

XLSX.write(workBook, {bookType: "csv", type: "string"});   // CSV as a JS string
XLSX.utils.sheet_to_csv(workSheet);                        // CSV from a worksheet (JS string)

binary will encode as binary strings.
When using writeFile, CSV will generate the binary output and add the UTF8 BOM.  TXT aligns with "UTF-16 Text" in Excel.  These choices optimize for the common case of generating files that will be read by Excel.

Ok, so I've tried sheet_to_txt and write{bookType:'txt'}) and both are rendering the same way.  Now I will say, that when I filter and convert one line, it is rendering the ’ character correctly. HOWEVER, when I return all 10,000 lines of data, it is then returning â€™. Is there a reason why a small subset of data renders correctly, but the full set of data replaces certain characters?

Does the same thing happen with CSV (using sheet_to_csv or write({bookType: "csv", type: "string"})?
In either case, can you share a sample?  JSON.stringify(results) should be sufficient to test.  If you can't share it publicly, email<EMAIL_ADDRESS>

Please test the following:
results = XLSX.utils.sheet_to_txt(workSheet, {type: "string"});

If this works, the issue can be resolved with a small patch to https://github.com/SheetJS/sheetjs/blob/master/bits/90_utils.js#L153 (feel free to submit a PR):
	if(typeof $cptable == 'undefined' || opts.type == 'string' || !opts.type) return s;

The result is a plain JS object, you can directly inspect it.  To get a specific cell, you can index with an Excel address:
var A1 = workSheet["A1"];

Please try using node_modules/xlsx/dist/xlsx.full.min.js or node_modules/xlsx/dist/xlsx.core.min.js (and be sure to pull the latest version from npm!). node_modules/xlsx/xlsx.js is designed for use in NodeJS.
Some small test https://jsfiddle.net/sheetjs/vmez8u1g/ shows the effect of the parameters.  FF FE 19 20 is a binary encoded version with the BOM while 2019 corresponds to "\u2019" (’)

Continuing with the weird, in sheet_to_csv I added this return out.slice(2, 265).join("") and it works, but with slice(0 or 1, 265) it didn't work.
Ok, I'll try that and see. When I tried importing it in requirejs it was causing some issues and I couldn't run it.

For whatever reason I cannot get it to load the xlsx.min.js nor xlsx.core.min.js to load using requirejs inside of Netsuite.

NetSuite support was verified working in 0.16.1 and there was no change to the RequireJS logic since then.  Is there some reported error?

It works unless I import one of the min files
On Mon, Mar 21, 2022, 4:33 PM SheetJSDev @.***> wrote:

NetSuite support was verified working in 0.16.1 and there was no change to
the RequireJS logic since then. Is there some reported error?
—
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/issues/2624#issuecomment-1074391934,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACNU32YLHJRLHGIWYWC7DLVBDMKVANCNFSM5RH7AMJQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yeah, I can get the xlsx one to work.  That said, it seems to be an issue when doing the out.join(""). Which is weird!

Ok, I have the xlsx.full.min.js working and I'm still getting the same issue.


Feat: Workflow for Closing Old Issues

What feature?
This feature aims to automate the process of managing old issues, ensuring that the repository remains organized and focused on relevant tasks. By automatically closing old issues, it reduces manual overhead for repository maintainers and helps keep the issue tracker tidy and up-to-date.
Add screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

@Sanchitbajaj02 please assign me this issue

Hi @Asymtode712
Explain me why do this project needs that? What if the issue that the action is closing is not fixed. Why would I need to close that is issue if it is unresolved?

@Sanchitbajaj02 So basically, what this workflow does is that if the repo maintainer or the issue author has not interacted with the issue over a time span of 30 days, then the workflow will identify such issues and close it. If you want to fix any issues then you will definately interact with it in minimum 5-6 days or max to max 20-25 days but beyond that if it is uninteracted and goes untracked then we might just close it.

If you notice clearly, issue #332 does the same job. So I think I can close this issue

@Sanchitbajaj02 #332 is for commenting, this workflow is for closing old issues


implement message formatter

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
✔

Tests pass?
✔

Fixed issues

Thanks.


Inet: ping: Improve the output of the ping function

The output of the net ping function is a bit terse.
Let's make it more Linux-like by reporting TTL, measuring round-trip-time and also display RSSI when available.
before:
uart:~$ net ping fe80::7b7a:342f:9d73:b482
Sent a ping to fe80::7b7a:342f:9d73:b482
Received echo reply from fe80::7b7a:342f:9d73:b482 to fe80::d07:d5e9:7c9:572d

after:
uart:~$ net ping fe80::7b7a:342f:9d73:b482
PING fe80::7b7a:342f:9d73:b482
8 bytes from fe80::7b7a:342f:9d73:b482 to fe80::7841:4946:59b8:3d9c: icmp_seq=0 ttl=64 rssi=-53 dBm time=6.65ms
8 bytes from fe80::7b7a:342f:9d73:b482 to fe80::7841:4946:59b8:3d9c: icmp_seq=1 ttl=64 rssi=-57 dBm time=6.59ms
8 bytes from fe80::7b7a:342f:9d73:b482 to fe80::7841:4946:59b8:3d9c: icmp_seq=2 ttl=64 rssi=-57 dBm time=6.56ms

Codecov Report

Merging #14024 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #14024      +/-   ##
==========================================
- Coverage   52.24%   52.23%   -0.01%
==========================================
  Files         307      307
  Lines       45467    45469       +2
  Branches    10525    10525
==========================================
  Hits        23752    23752
- Misses      16913    16915       +2
  Partials     4802     4802

Impacted Files
Coverage Δ

subsys/net/ip/icmpv4.c
26.17% <0%> (-0.18%)
:arrow_down:

subsys/net/ip/icmpv6.c
29.76% <0%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605ae10...20f745a. Read the comment docs.

@benpicco, Thanks for addressing the initial concerns raised.

I know, just thought it makes reviewing easier this way.
-> squashed.

@tbursztyka does this still need any changes?

Could you please add size parameter?
ping host -s 1470

@bublover Ok, added it.
I'm not so happy about the VLA use, but k_malloc is only available when CONFIG_HEAP_MEM_POOL_SIZE is set - and that defaults to 0.
I've only tested the IPv6 version, but IPv4 should work the same.

@benpicco could you rebase against latest master and re-submit without the size support, we can add that one later in separate PR.

@jukkar alright!

We have now another problem. When compiling samples/net/sockets/echo_server in qemu_x86, I get following fault:
uart:~$ net ping 2001:db8::2
PING 2001:db8::2
***** Floating point unit not enabled

Current thread ID = 0x004016f8
eax: 0x00403566, ebx: 0x00406558, ecx: 0x00000000, edx: 0x00000000
esi: 0x0040354e, edi: 0x0040357a, ebp: 0x00406a88, esp: 0x00406a50
eflags: 0x00000206 cs: 0x0008
call trace:
eip: 0x00015911
     0x000123ac (0x123ac)
     0x00012abc (0x406558)
     0x0000de38 (0x406558)
     0x0000de97 (0x1)
     0x0000479c (0x40655c)
     0x0000475a (0x4016e0)
Fatal fault in thread 0x004016f8! Aborting.

After enabling CONFIG_FLOAT, the output print looks like this
8 bytes from 2001:db8::2 to 2001:db8::1: icmp_seq=0 ttl=64 time=26113401 ms
8 bytes from 2001:db8::2 to 2001:db8::1: icmp_seq=1 ttl=64 time=-1608035756 ms
8 bytes from 2001:db8::2 to 2001:db8::1: icmp_seq=2 ttl=64 time=669327703 ms

You need to add () when dividing like this
diff --git a/subsys/net/ip/net_shell.c b/subsys/net/ip/net_shell.c
index bdb3e6ea4f..7a1836aef0 100644
--- a/subsys/net/ip/net_shell.c
+++ b/subsys/net/ip/net_shell.c
@@ -2696,7 +2696,7 @@ static enum net_verdict handle_ipv6_echo_reply(struct net_pkt *pkt,
 #ifndef CONFIG_NEWLIB_LIBC_FLOAT_PRINTF
                 (int)
 #endif
-                SYS_CLOCK_HW_CYCLES_TO_NS(cycles) / 1000000.f);
+                (SYS_CLOCK_HW_CYCLES_TO_NS(cycles) / 1000000.f));
        k_sem_give(&ping_timeout);

        net_pkt_unref(pkt);

For the float issue, add this change
index 7798d5a2f2..ca04d3e3c0 100644
--- a/subsys/net/ip/Kconfig
+++ b/subsys/net/ip/Kconfig
@@ -56,6 +56,7 @@ source "subsys/net/ip/Kconfig.ipv4"
 config NET_SHELL
        bool "Enable network shell utilities"
        select SHELL
+       select FLOAT
        help
          Activate shell module that provides network commands like
          ping to the console.

We have now another problem.
***** Floating point unit not enabled

So, I'd say we should keep avoiding floating point like we did before, and use fixed points calculations.

I've changed it so that it only uses float when CONFIG_FLOAT is set, otherwise it uses int and discards the sub-ms times.
@easonxiang does this also remedy the problem on uwp5661?

I've changed it so that it only uses float when CONFIG_FLOAT is set, otherwise it uses int and discards the sub-ms precision.
@easonxiang does this also remedy the problem on uwp5661?

@benpicco Yes, the int type works for me. I can not enable CONFIG_FLOAT as it depends on CPU_HAS_FPU, which is not available by uwp5661.
Thanks for your quickly response.


⚠ Bofrost.be has degraded performance

In 0cc2513, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1993 ms

Resolved: Bofrost.be performance has improved in ed84c15.


router cert auto-renew

this is pending release of 0.30.4 which has the fix for the router cert renewal race condition in edge v0.24.412


ERROR: Unrecognized option '5lUP6Zt4Pcg.mp4'. Error splitting the argument list: Option not found

thanks for adding what i suggested
i got this error when i tried to download a stream with the new option
Muxing files
16:28:29 ERROR: Unrecognized option '5lUP6Zt4Pcg.mp4'.
Error splitting the argument list: Option not found
also with --debug it says Attempting to retrieve a new download URL  after getting 403 errors is it suppose to do that
or does that just mean its using the next fragment url?

The message about attempting to retrieve a new URL is normal and just an oversight, I've just fixed that.
As for the unrecognized option, I may have gotten lucky when I just went to try that as the video I chose had a dash at the start of the ID. I am going to assume yours did as well. It made ffmpeg attempt to parse the output file as an arg.
I've put in a fix for that as well.

The message about attempting to retrieve a new URL is normal and just an oversight, I've just fixed that

i see thank you

As for the unrecognized option, I may have gotten lucky when I just went to try that as the video I chose had a dash at the start of the ID. I am going to assume yours did as well, or your output format had a dash before the ID and the other pieces didn't get filled in cause I make no attempt to retrieve them.

its probably because of the default output format %(title)s-%(id)s

Ah yes, I haven't used the default in so long I forgot that's what it was set to. I'm very good at this.


Fix for issue 13624 (Part 3)

Rounding out the changes to the overview page, I added in a section that covers the basic ideas of ranges with some examples and a links to more thorough introductions. I think this is enough to mark this issue as fixed.

Fun fact: with this change, the overview page is the only place in the entire website (outside of Phobos Docs) that describes what ranges are or what they are for. I don't know how the site went this long without a page on ranges.

BTW, I don't want to appear as a gatekeeper for these PRs. What I post here is my personal opinion and not really requirements for the PR to be merged. I can only guess that everyone else is either too busy or don't even know that this PR exists to add their opinions.

Added sentence before the example to clarify.

@CyberShadow fixed, and added small code section on how to get a range from a static array.

Test comment please ignore

No feedback from anyone else? Let's merge.

Thanks!


The cookbook has a `source_url' specified as part of its metadata.

Cookbook consumers should know where to look for the source code to take
a look at previous releases, pull-requests or unreleased changes.

I'd like the + to be higher here, but this is a huge one to check for :+1:

:+1: with a minor change to the pseudocode

@tas50 @johnbellone how much higher should the + be?  maybe 5 points total?

I am not sure what the scale is for points, but five points is better than one for sure.

:+1:


Tr/ignore

PR Type
enhancement, documentation

Description

Enhanced file ignore functionality to support multiple platforms (GitHub, Bitbucket, GitLab, Azure DevOps).
Fixed markdown formatting issues in utils.py.
Updated documentation to include examples for ignoring files using glob and regex patterns.
Logged filtered and invalid files in various git providers.

Changes walkthrough 📝
Relevant filesEnhancement
7 files

file_filter.pyEnhance file ignore functionality for multiple platforms

pr_agent/algo/file_filter.py
Added support for multiple platforms (GitHub, Bitbucket, GitLab, Azure DevOps) in file ignore functionality.  Enhanced the filter_ignored function to handle different file attribute structures.

+13/-2

language_handler.pyAdd type annotation to is_valid_file function

pr_agent/algo/language_handler.py

Added type annotation to is_valid_file function.

+1/-1

utils.pyFix markdown formatting and handle code tags

pr_agent/algo/utils.py
Fixed markdown formatting issues by removing extra newlines.  Added replace_code_tags function to handle code tags in markdown.

+8/-6

azuredevops_provider.pyIntegrate file ignore functionality and log filtered files

pr_agent/git_providers/azuredevops_provider.py
Integrated file ignore functionality.  Logged filtered and invalid files.

+15/-0

bitbucket_provider.pyIntegrate file ignore functionality and log filtered files

pr_agent/git_providers/bitbucket_provider.py
Integrated file ignore functionality.  Logged filtered and invalid files.

+23/-1

github_provider.pyIntegrate file ignore functionality and log filtered files

pr_agent/git_providers/github_provider.py
Integrated file ignore functionality.  Logged filtered and invalid files.

+25/-7

gitlab_provider.pyIntegrate file ignore functionality and log filtered files

pr_agent/git_providers/gitlab_provider.py
Integrated file ignore functionality.  Logged filtered and invalid files.

+60/-41

Documentation
2 files

additional_configurations.mdUpdate documentation for file ignore patterns

docs/docs/usage-guide/additional_configurations.md
Updated documentation to include examples for ignoring files using glob and regex patterns.

+6/-1

ignore.tomlAdd regex pattern example in ignore settings

pr_agent/settings/ignore.toml

Added example for regex pattern in ignore settings.

+1/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/improve

/review auto_approve

/review

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

/review

Preparing review...

Preparing review...

Incremental PR Reviewer Guide 🔍
⏮ Review for commits since previous PR-Agent review Starting from commit https://github.com/Codium-ai/pr-agent/pull/966/commits/1070f9583fe99b61ab687026f44135bfecb50120.

 ⏱ Estimated effort to review [1-5]
3

 🧪 Relevant tests
No

 🔒 Security concerns
No

 ⚡ Key issues to review

Possible Bug: The filter_ignored function in file_filter.py has been modified to include a platform parameter, but the default value is 'github'. This might not be clear or expected behavior for all use cases. Consider handling the default case more explicitly or documenting this behavior.

Refactoring Concern: The filter_ignored function now includes conditional logic for different platforms. This approach might lead to difficulties in maintaining and extending this function in the future as more platforms or special cases are added. Consider using a strategy pattern or similar design pattern to handle platform-specific differences more cleanly.

Incremental Review Skipped
No files were changed since the previous PR Review

Preparing review...

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/e083841d968098ded6349d2f6cac0b4273e0316c

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/e083841d968098ded6349d2f6cac0b4273e0316c


[SPARK-32680][SQL][3.0] Don't Preprocess V2 CTAS with Unresolved Query

What changes were proposed in this pull request?
The analyzer rule PreprocessTableCreation will preprocess table creation related logical plan. But for
CTAS, if the sub-query can't be resolved, preprocess it will cause "Invalid call to toAttribute on unresolved
object" (instead of a user-friendly error msg: "table or view not found").
This PR fixes this wrongly preprocess for CTAS using V2 catalog.
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
The error message for CTAS with a non-exists table changed from:
UnresolvedException: Invalid call to toAttribute on unresolved object, tree: xxx to
AnalysisException: Table or view not found: xxx
How was this patch tested?
added test

Test build #132374 has started for PR 30649 at commit 4d578e1.

Test build #132374 has finished for PR 30649 at commit 4d578e1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132374/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36972/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36972/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36972/

cc @cloud-fan

thanks, merging to 3.0!


Blog comments

Creating a blog post by Prose or middleman article 'Blog title' will generate a Disqus identifier. This also introduces the Disqus widget into the unstyled blog post.

LGTN :palm_tree:


Add .asm file breakpoint support.

VScodium, windows 10 x64, clang.
It goes correctly and successfully into asm file when 'stepping into' from main function, steps correctly and returns correctly back into main function but I can't set breakpoints in the asm file.
in main.cpp I added external asm(yasm) function "int my_asmz(int);"
in main function added:
int x = 50;
int y = my_asmz(x);
printf("%d", y);
asm file:
DEFAULT REL
section .data
section .text

global my_asmz

my_asmz:
    mov eax, ecx
    add eax, 6
    ret

CodeLLDB breakpoints are enabled for the asm language id.  However you may need to create a file extension association.  Or install some assembly syntax highlighter which will register it for you.  Or set debug.allowBreakpointsEverywhere=true


no bootable device

build on fedora 31 kvm
build directly out of the box but no bootable image

Hey @rhtyd , looks nice and easy, hope it is me that is flawed ;)

@DaanHoogland try builds from here: https://github.com/shapeblue/tiny-eddie/releases/tag/v0.1
(however, avoid these distractions if possible ;) )

:) :+1: but I need to wind down, at night @rhtyd


<IP_ADDRESS> don't install ?

Strange error
pip install manga-py --upgrade
Collecting manga-py
  Using cached https://files.pythonhosted.org/packages/68/38/f7701dd25fded5a4b87d547a398927c913d803a41f5012dc88a5aadd8f43/manga_py-<IP_ADDRESS>.tar.gz
No files/directories in /tmp/pip-install-uzojc1hc/manga-py/pip-egg-info (from PKG-INFO)

The same with
pip install manga-py --upgrade --no-cache-dir

Opps! My bad. Using pipenv in the wrong directory.


Remove keyword arguments from X_A_Xt and X_A_Xt! and add AbstractMatrix fallbacks

This will prevent some type piracy in ProbNumDiffEq.jl, as shown here: https://github.com/nathanaelbosch/ProbNumDiffEq.jl/issues/278#issuecomment-2217864515

Before merging I locally made sure that ProbNumDiffEq.jl tests pass, so next I will open a PR there that moves the package over to v0.5.0!


Use math.MaxInt32

Thanks.  This was a holdover before the float decoding required the math package as it seemed silly to import the entire math package for a single constant.  However, since it's needed elsewhere, this now makes sense.
OK


Add request for pet import

@oldben87  we forgot about this one.

Summary by CodeRabbit

New Feature: Introduced the PetImportRequest module which enables users to import pet data via a specific API endpoint. This feature enhances the application's functionality by allowing seamless integration and interaction with external pet data sources. The module includes robust type checking for input and output data, ensuring data integrity and reliability during the import process.

@oldben87 was this one was only half finished? or is it gtg?

This only handles the api request, there is no ui, nor is the api request used anywhere


Add RSS feed

There's an easy way to implement rss feed in jekyll websites.
We could then link this to Twitter -- which is what I really want: Manjaro's news in my Twitter feed.
If guys OK this, I can PR, but I hear there's a new website coming. Should I even bother?
Thank you all for this awesome piece of software. I love manjaro <3

Create a PR for this. We are updating our homepage but for now it would be good to use all given options. When the new homepage is there we will have a rss feed anyway.


Websocket closes itself after few minutes

core.js:1350 ERROR Error     at WebSocket.socket.onclose [as __zone_symbol__ON_PROPERTYclose] (index.js:38)     at WebSocket.wrapFn (zone.js:1166)     at ZoneDelegate.invokeTask (zone.js:425)     at Object.onInvokeTask (core.js:4617)     at ZoneDelegate.invokeTask (zone.js:424)     at Zone.runTask (zone.js:192)     at ZoneTask.invokeTask [as invoke] (zone.js:499)     at invokeTask (zone.js:1540)     at WebSocket.globalZoneAwareCallback (zone.js:1566)

Definitely nothing to do with this library.

@ohjames : I followed the Angular 4 example that you mentioned in docs. Could you please suggest the reconnect approach in case of connection error or closed connection due to network issues?

Search readme for reconnect.

rxjs operator retryWhen.


[make-indexes] NMOS Parameter Registers

Should we change the hard-coded list at https://github.com/AMWA-TV/nmos-doc-build-scripts/blob/d9396a3f4fe3fdcb9932e59e76c32a57412c4831/make-indexes.sh#L97 to just use the list of individual drectories (less the "common" and dot-dirs, ".github", ".render", ".lint")? At the moment even the capabilities branch doesn't list the capabilities register, and (update!) in fact doesn't seem to include the docs because and https://github.com/AMWA-TV/nmos-doc-build-scripts/blob/d9396a3f4fe3fdcb9932e59e76c32a57412c4831/extract-docs.sh#L84 also needs updating.
Bonus questions:
Should we move the common/*.md into the top-level, so that directories isn't a special case?
Should we move all of these under a "docs" directory?

The list of registers also appears in https://github.com/AMWA-TV/nmos-doc-layouts/blob/main/_layouts/default.html#L48-L58 :-/

I think now we have a lot more data-driven and templated parts of the render this can be closed. @garethsb  please reopen if you disagree :)


Publishing to IIS - needs link to •Installing ASP.NET 5 On Windows

Add https://docs.asp.net/en/latest/getting-started/installing-on-windows.html to the start of the instructions.

I actually create new issue to move installation part of Publishing to IIS to Installing ASP.NET 5 on Windows. That would be more consistent I'd say and also more convenient for system administrators, which are probably going to be the ones installing and preparing environments.

@OndrejValenta you don't need to install ASP.NET on the server to run asp.net app.

Oh, really? I didn't know that.. So because asp.net 5 is using DNX there is no need to install anything else on server than just DNVM, DNX and HttpPlatformHandler, right? I see your point now, but I also think there should be an article explaining the situation, because the system administrators I know are used to installing software through installers, to configure ASP.NET environment from IIS and especially to ask questions like "what are we doing?" and "why is it done this way?". The plain and simple installation guide won't be enough in my opinion.

All the server needs is Install the HTTP Platform Handler


Error: (plugins-manager) failed to load 'plugin.py'

I'm trying to install Plugin Manager, but the plugin does not load. I'm seeing the following errors in my logfile on starting Domoticz:
2021-01-21 19:20:49.365  Error: (plugins-manager) failed to load 'plugin.py', Python Path used was '/config/plugins/plugins-manager/:/usr/lib/python38.zip:/usr/lib/python3.8:/usr/lib/python3.8/lib-dynload:/usr/local/lib/python3.8/dist-packages:/usr/lib/python3/dist-packages:/usr/lib/python3.8/dist-packages'.
2021-01-21 19:20:49.365  Error: (Python Plugins Manager) Module Import failed, exception: 'FileNotFoundError'
2021-01-21 19:20:49.365  Error: (Python Plugins Manager) Import detail: File: ./plugins/plugins-manager/plugins.json, Line: -1

I'm running Domoticz 2020.2 as Docker using the amd64 image by LinuxServer.io: https://github.com/linuxserver/docker-domoticz . Python is available/installed in the Docker image (Python3.8 + Python3.9) and the Python Path in the error above is valid (exists + has files inside).
I don't get why it says 'FileNotFoundError', as both plugin.py as plugins.json are in the directory:
Freekers@Synology:/volume1/docker/domoticz/config/plugins/plugins-manager$ ls
api  CONTRIBUTING.md  frontend  LICENSE  manager.py  plugin.py  plugins.json  plugins.py  __pycache__  README.md

I'm already running 2 other plugins without problem (ShellyMQTT and IDetect). What am I missing here?
Thanks!

I have the same problem. No found no solution yet

I have the same problem. No found no solution yet

@stas-demydiuk Do you have any idea perhaps what this might be causing :) ? Thanks!

@stas-demydiuk Do you have any idea perhaps what this might be causing :) ? Thanks!

me too using the linuxserver/domoticz:latest docker image which has /config/plugins as the plugin directory
2021-01-31 18:13:06.633 Status: (Plugin manager) Started.
2021-01-31 18:13:06.902 Error: (plugins-manager) failed to load 'plugin.py', Python Path used was '/config/plugins/plugins-manager/:/usr/lib/python38.zip:/usr/lib/python3.8:/usr/lib/python3.8/lib-dynload:/usr/local/lib/python3.8/dist-packages:/usr/lib/python3/dist-packages:/usr/lib/python3.8/dist-packages'.
2021-01-31 18:13:06.902 Error: (Plugin manager) Module Import failed, exception: 'FileNotFoundError'
2021-01-31 18:13:06.902 Error: (Plugin manager) Import detail: File: ./plugins/plugins-manager/plugins.json, Line: -1
2021-01-31 18:13:06.902 Error: (Plugin manager) Error Line details not available.
2021-01-31 18:14:11.964 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:25.968 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:39.973 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:53.977 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:15:08.112 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:15:22.116 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly

me too using the linuxserver/domoticz:latest docker image which has /config/plugins as the plugin directory
2021-01-31 18:13:06.633 Status: (Plugin manager) Started.
2021-01-31 18:13:06.902 Error: (plugins-manager) failed to load 'plugin.py', Python Path used was '/config/plugins/plugins-manager/:/usr/lib/python38.zip:/usr/lib/python3.8:/usr/lib/python3.8/lib-dynload:/usr/local/lib/python3.8/dist-packages:/usr/lib/python3/dist-packages:/usr/lib/python3.8/dist-packages'.
2021-01-31 18:13:06.902 Error: (Plugin manager) Module Import failed, exception: 'FileNotFoundError'
2021-01-31 18:13:06.902 Error: (Plugin manager) Import detail: File: ./plugins/plugins-manager/plugins.json, Line: -1
2021-01-31 18:13:06.902 Error: (Plugin manager) Error Line details not available.
2021-01-31 18:14:11.964 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:25.968 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:39.973 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:14:53.977 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:15:08.112 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly
2021-01-31 18:15:22.116 Error: Plugin manager hardware (5) thread seems to have ended unexpectedly

I think plugins.json this line: https://github.com/stas-demydiuk/domoticz-plugins-manager/blob/95ec06edd2eaafc344f6c22042b203da1f1ab630/plugins.py#L4
does not resolve to /config/plugins/plugins-manager/plugins.json
I see other locations with hardcoded paths that probably won't work either eg. : https://github.com/stas-demydiuk/domoticz-plugins-manager/blob/95ec06edd2eaafc344f6c22042b203da1f1ab630/plugin.py#L60-L61

I think plugins.json this line: https://github.com/stas-demydiuk/domoticz-plugins-manager/blob/95ec06edd2eaafc344f6c22042b203da1f1ab630/plugins.py#L4
does not resolve to /config/plugins/plugins-manager/plugins.json
I see other locations with hardcoded paths that probably won't work either eg. : https://github.com/stas-demydiuk/domoticz-plugins-manager/blob/95ec06edd2eaafc344f6c22042b203da1f1ab630/plugin.py#L60-L61

The templates_path is indeed different for the LinuxServer.io Docker Image. The domoticz-zigbee2mqtt-plugin from stas-demydiuk has a similar issue, which is related to paths as well: https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/issues/556#issuecomment-770223571

The templates_path is indeed different for the LinuxServer.io Docker Image. The domoticz-zigbee2mqtt-plugin from stas-demydiuk has a similar issue, which is related to paths as well: https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/issues/556#issuecomment-770223571

With the official docker image (domoticz/domoticz), I'm facing the same issue.
Trying to fix it without success: I changed some path but doesn't work... I'm not a developer so hard to find where is the problem.

OK I managed the path problem but only for my system:
1- Create a symlink inside the docker : /opt/domoticz/plugins pointing to /opt/domoticz/userdata/plugins
2- In plugin.py replace source_path = os.path.dirname(os.path.abspath(file)) + '/frontend' with source_path = '/opt/domoticz/plugins/plugins-manager/frontend'
I'm not sure it will work on domoticz standard installation (outside a docker). This is a workaround as I used absolute path which is definitively not recommended (e.g. if you install domoticz in /home/domoticz it will not work).

Now should work fine with both setups. I wonder if someone could check

OK tested with domoticz official docker image (domoticz/domoticz), works well now.

I still have (this?) problem. I installed PPM on RPi 4b, running Domoticz, eclipse-mosquitto and zigbee2mqtt in Docker Compose.
I have your plugin 'zigbee2mqtt' installed without problem (it's the only plugin at this point).
My plugins are in /opt/docker/domoticz/plugins.
I cloned https://github.com/ycahome/pp-manager.git in that dir, gave permission and restarted domoticz in docker-compose.
Then:

I Added PPM in /hardware with plugin 'Idle'. No errors in log yet.
Selected plugin 'Dummy plugin' and click update (not 'Add', so I still have only 1 PPM hardware item).
BTW: the permissions/_ownership of the relevant files and directories:
drwxr-xr-x 4 domoticz domoticz 4096 Mar  8 09:37 pp-manager  (dir. /opt/docker/domoticz/plugins/pp-manager)
Files in dir. /opt/docker/domoticz/plugins/pp-manager:
-rw-r--r-- 1 domoticz domoticz    71 Mar  8 09:36 CONTRIBUTING.md
-rw-r--r-- 1 domoticz domoticz   756 Mar  8 09:36 exceptions.orig
-rw-r--r-- 1 domoticz domoticz 35147 Mar  8 09:36 LICENSE
-rwxr-xr-x 1 domoticz domoticz 41672 Mar  8 09:36 plugin.py
drwxr-xr-x 2 domoticz domoticz  4096 Mar  8 09:37 pycache
-rw-r--r-- 1 domoticz domoticz  2194 Mar  8 09:36 README.md
-rw-r--r-- 1 domoticz domoticz   247 Mar  8 09:36 secpoluser.orig


Production deploy - possible breaking changes ⚠

⚠ Possible breaking change: ⚠
When we switched over to service_at_locations we updated the indexes so when updating you will need to run
npm run prepare-indices
or
db.indexed_services.createIndex({ "service_at_locations.location.geometry": "2dsphere" })
You will also need to ensure that you have the latest version of Outpost running ⚠

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (8778b94) to head (78b6266).
Report is 3 commits behind head on production.

Files
Patch %
Lines

src/controllers/v1/services/routes/get-services.js
33.33%
7 Missing and 1 partial :warning:

src/db.js
0.00%
5 Missing and 1 partial :warning:

Additional details and impacted files
@@              Coverage Diff               @@
##           production      #53      +/-   ##
==============================================
+ Coverage       69.43%   72.39%   +2.96%
==============================================
  Files               8        8
  Lines             229      221       -8
  Branches           53       52       -1
==============================================
+ Hits              159      160       +1
+ Misses             63       54       -9
  Partials            7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(proposal) Release notes PRs: put month as string

To increase the chance of noticing that the release notes would go into the next month release notes (as in https://github.com/Azure/azure-sdk/pull/6621#issuecomment-1718656850), give the PRs a title like <language> release notes for the October 2023 release instead of <language> release notes for the 2023-10 release.
Better yet, between 1st and 15th of the month, maybe name the PRs as <language> release notes for the <current month> 2023 release, and after 15th, name them as <language> release notes for the <next month> 2023 OOB release, to emphasize the OOB, so there's more chance a person would notice that and take action if that is not what was intended.
cc @czubair

I would be Ok with changing to include the string month names but the OOB vs non-OOB are no different we simply collect all the notes for a given month from the last ship cycle.


Checking packages from PyPI appears to be broken

When attempting to check any package on PyPI with latest Pyroma (3.0.2), on both Windows and Linux on Python 3.7.x, an error results:
xmlrpc.client.Fault: <Fault -32500: 'HTTPTooManyRequests: The action could not be performed because there were too many requests by the client. Limit may reset in 1 seconds.'>

I've tested numerous times over the period of a day, with no luck. If I were to guess, this may be due to the domain and API changes involved in the transition to Warehouse/pypi.org from the old Cheeseshop/packages.pypi.org

$ pyroma -p black
------------------------------
Checking black
Found black version 20.8b1
Traceback (most recent call last):
  File "C:\Miniconda3\envs\cf-env\Scripts\pyroma-script.py", line 33, in <module>
    sys.exit(load_entry_point('pyroma', 'console_scripts', 'pyroma')())
  File "c:\users\c. a. m. gerlach\documents\dev\hypertool\pyroma\pyroma\__init__.py", line 101, in main
    rating = run(mode, argument)
  File "c:\users\c. a. m. gerlach\documents\dev\hypertool\pyroma\pyroma\__init__.py", line 120, in run
    data = pypidata.get_data(argument)
  File "c:\users\c. a. m. gerlach\documents\dev\hypertool\pyroma\pyroma\pypidata.py", line 37, in get_data
    data = client.release_data(project, release)
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 1112, in __call__
    return self.__send(self.__name, args)
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 1452, in __request
    verbose=self.__verbose
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 1154, in request
    return self.single_request(host, handler, request_body, verbose)
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 1170, in single_request
    return self.parse_response(resp)
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 1342, in parse_response
    return u.close()
  File "C:\Miniconda3\envs\cf-env\lib\xmlrpc\client.py", line 656, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault -32500: 'HTTPTooManyRequests: The action could not be performed because there were too many requests by the client. Limit may reset in 1 seconds.'>

In addition, a ResourcesWarning is generated due to the XMLRPC client not being opened in a context manager, thus leaking an unclosed socket
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=592, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('<IP_ADDRESS>', 64493), raddr=('<IP_ADDRESS>', 443)>

Unless its something simple, if this was due to the PyPI API changes it likely needs a full rewrite. If that's not feasible to do in the near-term, this feature should presumably be disabled with a friendlier and more informative error message, or removed.

Still? It's been four months? I guess the XMLRPC API will stay down, and it will then need a full rewrite indeed...

@regebro Actually, a bit of Googling suggests what's going on. Per the docs, the XML-RPC API still technically works, but is deprecated in favor of the modern JSON/REST API and is in the process of being removed. As part of that, it has a "very restrictive" rate limit, which based on the error above is very likely what you're running in to here. By either slowing your rate of requests or adding backoffs and retries, you could probably squeeze a bit more more use out of the old API before you'll have to port to the new one, though not sure whether it would be worthwhile over just biting the bullet since its not clear how much longer they'll keep it online.

Yeah. I stopped using the search API, and got most of the information from the JSON API, and that seems to solve it. I'll release this tomorrow, I think.

Fantastic news, thanks!

Just to be sure what I'm doing wrong using pyroma version 3.1 on Ubuntu 18.04 (Python 3.6) :
pip3 install pyroma
...
Successfully installed docutils-0.17 pygments-2.8.1 pyroma-3.1

#pyroma guardata
------------------------------
Checking guardata
Found guardata version 0.2.2
Traceback (most recent call last):
  File "/usr/local/bin/pyroma", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.6/dist-packages/pyroma/__init__.py", line 101, in main
    rating = run(mode, argument)
  File "/usr/local/lib/python3.6/dist-packages/pyroma/__init__.py", line 120, in run
    data = pypidata.get_data(argument)
  File "/usr/local/lib/python3.6/dist-packages/pyroma/pypidata.py", line 37, in get_data
    data = client.release_data(project, release)
  File "/usr/lib/python3.6/xmlrpc/client.py", line 1112, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python3.6/xmlrpc/client.py", line 1452, in __request
    verbose=self.__verbose
  File "/usr/lib/python3.6/xmlrpc/client.py", line 1154, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python3.6/xmlrpc/client.py", line 1170, in single_request
    return self.parse_response(resp)
  File "/usr/lib/python3.6/xmlrpc/client.py", line 1342, in parse_response
    return u.close()
  File "/usr/lib/python3.6/xmlrpc/client.py", line 656, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault -32500: 'HTTPTooManyRequests: The action could not be performed because there were too many requests by the client. Limit may reset in 1 seconds.'>

I guess a simple time.sleep(2) right before a request to the current API should fix this.
Or is is because the PyPi package is not updated from this source repository ? I can't find anything from v 3.1 related to this issue.

Correct me if I'm wrong, @regebro , but it appears that this issue was manually closed before the PR that implements the fix, #58 , was merged (instead of including a closes tag in that PR). Therefore, the fix is neither released nor even on master in this repo. However, @antonio-fr , if you'd like to text the fix, you can clone this repo and do hub pr checkout 58 and then pip install -e . in your current environment, which should work.

Yeah, I must have pressed the wrong button, not the first time....

@regebro No worries...I'm pretty sure every Github user has done it at least a few times, and anyone that hasn't just haven't been on the site long enough yet, haha.

Because of the significant changes I released this as 3.2b1.
Unless any major bugs shows up, I'll release 3.2 next week or so, if someone reminds me. :-)

OK, I assumed it was fixed because the issue was closed and there was a PR. But in fact, the package build was pending, so the error was still present. In a way, the real issue was the closed issue. ;)
I'll test it when the new release will be published in some days. Thanks.

Please test it with the 3.2b1 version I just released. That's what beta
versions is for. :-)
On Tue, Apr 27, 2021 at 7:46 PM antonio-fr @.***> wrote:

OK, I assumed it was fixed because the issue was closed and there was a
PR. But in fact, the package build was pending, so the error was still
present. In a way, the real issue was the closed issue. ;)
I'll test it when the new release will be published in some days. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/regebro/pyroma/issues/55#issuecomment-827792850, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGIK5AXHN3SFKNIACJZHUTTK3Z5TANCNFSM4YWSGXUA
.

I can confirm this works with version 3.2b1 (tested on Python3.8).
As a side note, I have mixed feelings about the requirements of having at least 3 owners for a package on PyPi. What about the package that are maintained by a single software editor company ?

As a side note, I have mixed feelings about the requirements of having at least 3 owners for a package on PyPi. What about the package that are maintained by a single software editor company ?

They should create a backup account for when they get locked out of the first one?
https://en.wikipedia.org/wiki/Bus_factor

Unless any major bugs shows up, I'll release 3.2 next week or so, if someone reminds me. :-)

@regebro It has been 43 days, I think the update is safe to publish.

3.2 released


Added support to 'sym' tags for waypoints

'sym' tags are used to display a custom icon. It is used in Viking software for example.

Hello ! Thanks for your contribution ! I cherry-picked your commit to avoid merge issues with my commits in your PR history !


[v1.48] Proxy modal window not working and application is stuck

Reporting the same issue reported for v1.45 in Proxy modal window not working and application is stuck #97719 appearing again. This issue was fixed, but it seems to have been reintroduced again in the latest version.
VSCode Version: 1.48 latest
OS Version: Mac OS Catalina
Steps to Reproduce:
Behind a proxy wall, open the application
VS Code automatically prompt the Proxy credentials entry modal
After entering the credentials, clicking on "OK" or
"Cancel" does not do anything
Does this issue occur when all extensions are disabled?: Yes/No: NA, Does not allow me to disable extensions. Proxy window opens immediately
One thing I noticed, in the 1.47.3 version, the proxy address would appear on top of the modal for reference. I don't see that in the new version.

/duplicate of #104603 and will be fixed in upcoming recovery release.


Cargo ingores branch in .gitmodules when fetching submodules of dependencies

Problem
Cargo ingores branch in .gitmodules when fetching git submodules of crate dependencies. The branch fetched is always master. I excepted cargo to fetch the branch I specified in .gitmodules.
Steps

mkdir tmp; cd tmp
mkdir sub; cd sub; git init; cd ..
cargo init test-dep --lib; cd test-dep
Create .gitmodules file and insert the following contents:

[submodule "sub"]
	path = sub
	url = file://<path to tmp>/sub
	fetchRecurseSubmodules = false
	branch = not-master

cd ..
cargo init test-leaf; echo "test-dep = { git=\"file://$($(realpath test-dep)\" }" >> test-leaf/Cargo.toml; cd test-leaf
cargo update
This should fail since there is no "not-master" branch in sub but instead this succeeds. Creating the "not-master" branch does not affect the result.

Possible Solution(s)
Check the branch property in .gitmodules.
Notes
Output of cargo version: cargo 1.49.0-nightly (79b397d72 2020-10-15)
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.7
BuildVersion:	19H2

does this happen with https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli set? If so it is a bug in libgit2.

Yes

does this happen with https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli set? If so it is a bug in libgit2.

Yes

This is a longstanding issue in Cargo and has basically always been how submodule fetching works, for better or for worse. Cargo currently fetches all branches/references (slow), rather than respecting the .gitmodules configuration. I think this would be pretty easy to fix, but it's unfortunately a breaking change as well and I'm not sure how many projects it will affect, so we'll need to tread carefully.

Is it possible that this will be fixed in the near feature? Seems like it's impossible to make cargo use the right branch even if I explicitly specify a commit from that branch that is not present in master for a submodule. The only workaround I could think of is creating a fork of both the dependency and the submodule using the required branch as master which isn't exactly the best way to handle that.

Oh hm I may be misunderstanding. I thought that Cargo's behavior today was that it fetched all branches of submodules, so the only "bad" behavior is that fetches may take longer. It sounds like you're saying though that we're not fetching a branch so the fetch is failing because the commit wasn't fetched? If so that's definitely a serious bug we should fix!

I'm also a bit confused what exactly the issue here is.
AFAIK, the branch field in .gitmodules is only used when running git submodule update.  It doesn't indicate which branch the submodule is actually pointing to.  The submodule points to an OID which is what cargo checks out.
The following example checks out the submodule for the given branch foo.
mkdir tmp
cd tmp
mkdir sub
cd sub
git init
git checkout -b foo
touch foo
git add foo
git commit -m test
cd ..
cargo new --lib test-dep
cd test-dep
git submodule add -b foo file://$(realpath $(pwd)/../sub) sub
git add Cargo.toml src
git commit -m test
cd ..
cargo new test-leaf
cd test-leaf
echo "test-dep = {git=\"file://$(realpath $(pwd)/../test-dep)\"}" >> Cargo.toml
cargo update

The problem somehow disappeared itself. Sorry for the inconvenience.


In Deployment mode Flags are not loading.

Yeah in Deployment mode 99% of Flags are not visible only placeholders are visible. In Development mode, this issue is not coming for any reason.
Please check the difference between both images of the deployment and development mode
The error I am getting in the deployment mode console: Refused to load the image 'https://flagcdn.com/w40/in.webp' because it violates the following Content Security Policy directive: "img-src 'self' data:".
Deployment mode:

Development mode

Can you please help me with that why it is coming like this?

Issue is Resolved


[fptplay] Improve extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fix bug get title, description and video info by episode.

Unnecessary escapes in regex
non-fatal fields are not handled correctly
indentations that don't make any sense

I have pushed the necessary changes for this PR because that is honestly easier than reviewing each issue. But don't expect me to do that for future PRs

@pukkandan Is my PR okay, Can we merge?


Image blending prompt

Hey, thanks so much for releasing your great paper and making the code and weights public. I am quite interested in playing around with the model for the task of image blending. Could you please provide the exact prompt used for the image blending results in Figure 1 of the paper?

No prompt is needed for image blending :). To blend two images, simply concatenate them into a sequence, and append an [IMG] token to denote the start of the image to be generated:
$$
\texttt{[IMG]image1[/IMG][IMG]image2[/IMG][IMG]}
$$
, then feed this sequence into pretrained Emu, which will auto-regressively generates 32 image embeddings that could be further decoded into realistic blended image.
Please note that we have not released the code for auto-regressive image generation and the weights of the image decoder. However, you can play with our demo now, which supports this function.
Thank you for your interest in our work.

Thanks for your amazing work! When will you release the code for auto-regressive image generation and the weights of the image decoder? Also, do you have a plan to release the training code? Thx!

We plan to release all of them, but it might take some time to do so. Thank you.


Parsing fails on certain dates and times.

Hello. It is a very useful library.
However, when I tried to use it, I got parseError in the following cases.
tellMeWhen('2001/10/10');.

It seems that 10/10 is not parsed correctly, since '2001/10/11' gives a normal result.
Also, the following cases also seem to result in parseError.
tellMeWhen('2000/1/1 21:00');

It seems that parsing after 20:00 fails because '2000/1/1 19:00' gives a normal result.

Thanks! You were quite right, my regexes for month and hour numbers were bad.  Fix should be released by CI in a moment!

:tada: This issue has been resolved in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@madogai it's ironic that you're my first stargazer, since this library is designed for US English right now and looks like you're in Japan.  If you have any interest in implementing Japanese Date/Time expression for this lib or a fork, I'm happy to help you understand how the parsing system works!

@jedwards1211 Thanks for fixing the bug!
In Japan, date and time expressions are not much different from those in English. Especially in programming.
Therefore, I think there is no problem for English.
However, since you might be interested, I also describe time expressions in Japanese.
'2024-12-28 10:20:30' is expressed as follows in Japanese. '2024年12月28日10時20分30秒'.
If I have time, I will also fork and create a pull request!

Okay, I do think it would be neat to support many different locales someday, but I think it would be better to get contributions from native speakers rather than attempting anything myself, since the goal is to support common expressions like "the day after tomorrow", "two hours ago" etc. in a given language/locale as well as absolute dates/times.

It's true that idiomatic expressions are better suited to native speakers.
For example, In Japanese, "tomorrow" is "明日" and "the day after tomorrow" is "明後日", so I think the rules are difficult to understand.
I'll try to find some time to use it, as it may be useful for my program. (But please don't expect too much.)


Graphics List Boxtops aren't clipped properly or framebuffered

This was fixed in 3.4.21 under performance work.


Debounce the ResizeObserver for automatic dialog resizing to resolve https://github.com/TeselaGen/tg-oss/issues/63

Debouncing the ResizeObserver seems to resolve the error "ResizeObserver loop completed with undelivered notifications." when "+ Add Note" is clicked in the New Feature dialog when the dialog doesn't have a scrollbar"
@tnrich

@ryan-stackwave looks like everything still works. I'll take it!


Made cosmetic edits to rocket SVG in the "Congrats" page.

Hi,
I noticed that the SVG code for the rocket that displays on the default_urlconf debug view had an extra <circle> that didn't need to be there (first commit in the PR), and that the circle that makes up the windo/porthole of the rocket could be made transparent, so it didn't have to redefine the rocket color (commit number two).
Since this is a minor change that should have no visual impact, I figured it was OK to just open a PR without a ticket, please let me know if you'd prefer otherwise.
Here's the before/after picture (zoomed in 300% to make it easier to see that there are no visual changes):
before:

after

@bmispelon Thanks :+1:


fix(show-me-button): fix scroll on button

:tada: This PR is included in version 1.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fixes 20230511

can't reliably use request.org to determine context org for devicectl port autocomplete, needs to be passed with request instead

Codecov Report

Merging #150 (5e3897f) into prep-release (522f3f3) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@               Coverage Diff                @@
##           prep-release     #150      +/-   ##
================================================
- Coverage         47.81%   47.74%   -0.07%
================================================
  Files               133      133
  Lines              4777     4784       +7
================================================
  Hits               2284     2284
- Misses             2493     2500       +7

Impacted Files
Coverage Δ

src/fullctl/django/autocomplete/devicectl.py
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Replace let _ = with .unwrap() in demo.

In lieu of more sophisticated error handling the function calls should panic rather fail silently.

Yeah sure, cheers


Title State Doesnt Works

Describe your bug here.
Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself.
Alright, i was working on a project and when i compiled the game for first time, the TitleState thing wasnt starting, the music wasnt even playing! And you will say, 'its an error from the music .ogg file', but it isnt, if i just use FlxG.sound.playMusic(Paths.music('freakyMenu'), 0); the music plays but the title stills not work. I tried to replace TitleState.hx code like... 5 times and it didnt work. What should i do?
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
Which branch of the engine are you using?
Latest (main)
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, i just compiled for first time

I think it should be 1 and not 0.
FlxG.sound.playMusic(Paths.music('freakyMenu'), 1);

I think it should be 1 and not 0. FlxG.sound.playMusic(Paths.music('freakyMenu'), 1);

it still doesnt works, the problem is not the music, is the title state creds stuff

The problem is literally the music. Even if you insist, it will be the music that is broken. Re-download 'freakymenu' because it's saying that it's corrupted. To not make more problems, you should just re-download main(The whole source code) again because some of the .ogg's or even the other files may be corrupted. Just do It

The problem is literally the music. Even if you insist, it will be the music that is broken. Re-download 'freakymenu' because it's saying that it's corrupted. To not make more problems, you should just re-download main(The whole source code) again because some of the .ogg's or even the other files may be corrupted. Just do It

ill try thanks


Consider interface to filling data into already allocated arrays

I'm considering using this library for Machine Learning purposes, as I need to speed up loading random samples from a large netcdf file, which in python is prohibitively slow. However, for the sake of speed, it would be nice if the array_at, values_at and all of the other interfaces have also methods to which you can provide an already preallocated memory array and it will fill in the values there, rather than allocating a new one.

closed by #21


History.md Homogeneity Project

Summary
I've wanted to get various informational documents consistent across our repos as there are pretty significant differences between them. Normalization will help messaging be consistent across the board allowing different users to be able to read all history files across Cucumber regardless of which language specific repo of which they're most familiar.
Current Implementations
Examples:

cucumber-ruby uses an update-history script to manage their HISTORY.md file
cucumber-js doesn't have a specific format to use for CHANGELOG.md but suggests using a specific git log.

Possible Solution
Aslak suggested Keep a Changelog for our history files. This uses a clear format and groups things by type, similar to what we're doing today.
Questions/Tuning

Naming: Should we use History.md or CHANGELOG.md across repos?
1a. Should what we decide on be in all caps?
Every repo (imo) should have some sort of history tracking file so we'll need to go through and add them to repos that don't currently have them.
2a. Should we create a day forward file or try to wrangle past commit history into the files we create?
Should we change our change 'types' to match KaC's guidance or continue to use our own?
KaC does not include a method for including issue numbers, shall we just continue with including them as links at the end with the text being just the issue number?
There are a lot of repos below that are listed as read-only, are mirrors, or are just stale overall. Should we be adding tracking files to these ones as well?
Guidance: We should include a link at the top of each tracking file pointing to the master contributing file.
Guidance: Similar to the Ruby repo, I would like each repo to have a local script that contributors run to update the tracking file with the issue tag. This way we can help keep formatting similar across repos and also enforce a 'newest first' ordering of issues.

List of Repos By Current Tracking Type
grouped case insensitive and listed alphabetically
History.md

aruba
cucumber-cpp
cucumber-jvm
cucumber-rails
cucumber-ruby
cucumber-ruby-core
multi_test

Changes

gherkin-perl

Changelog.md

cucumber-js

No history tracking file

aruba-contrib
aruba-getting-started
aruba-website
commitbit
cucumber (monorepo)
cucumber-eclipse
cucumber-electron
cucumber-expressions-java
cucumber-expressions-javascript
cucumber-expressions-ruby
cucumber-html
cucumber-java-skeleton
cucumber-jvm-deps
cucumber-lua
cucumber-pretty-formatter
cucumber-react
cucumber-ruby-dev
cucumber-ruby-http
cucumber-ruby-tcl
cucumber-ruby-wire
cucumber-tcl-wire
cucumber-website
docs.cucumber.io
gherkin
gherkin-c
gherkin-dotnet
gherkin-go
gherkin-java
gherkin-javascript
gherkin-jvm-deps
gherkin-lint-javascript
gherkin-objective-c
gherkin-python
gherkin-ruby
github-issue-stats
tag-expressions-java
tag-expressions-javascript
tag-expressions-ruby

Note: Some repos may be marked as read-only or may also be stale. I have listed all repos in the Cucumber project regardless of these points.

Great research @jaysonesmith. Some of the repos without a changelog file are read-only mirrors of the cucumber/cucumber monorepo:

gherkin-c
gherkin-dotnet
gherkin-go
gherkin-java
gherkin-javascript
gherkin-jvm-deps
gherkin-lint-javascript
gherkin-objective-c
cucumber-expressions-java
cucumber-expressions-javascript
cucumber-expressions-ruby
tag-expressions-java
tag-expressions-javascript
tag-expressions-ruby

These repos should not have a changelog - their changelog is in monorepo:

https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md
https://github.com/cucumber/cucumber/blob/master/cucumber-expressions/CHANGELOG.md
https://github.com/cucumber/cucumber/blob/master/tag-expressions/CHANGELOG.md

Some repos don't get tagged and released - they're just "ongoing":

cucumber (monorepo) - there are many changelogs here, just not at the root
cucumber-java-skeleton
aruba-getting-started
website
docs.cucumber.io

Some I just moved to the attic:

cucumber-pretty-formatter
gherkin
cucumber-ruby-http

And this one got deleted:

cucumber-ruby-dev

So I think the remaining ones need a changelog.
Now your questions:

Although most projects use History.md, I'd be happy to adopt CHANGELOG.md as the standard filename. All caps fits well with README.md and CONTRIBUTING.md.
Let's not worry about the past - new CHANGELOG.md files should only list what's happened after the file was added.
I think we should use a consistent style across all repos. I think the following info is important (see cucumber-expressions and gherkin for examples:

Change categories (New features, Added, Removed etc)
Links to issues/PRs
Attributions (links to contributors)
Links to a full diff between releases
Release date
Each entry is added manually, and it's a little bit tedious, but not too bad IMO. Maybe we can create a small bash script that adds a line with a simple command line.

See examples in 3
Explained above
Agree! The file is there - just needs updating with the process discussed recently on the mailing list.
Duplicated scripts are hard to maintain. I suggest adding a bash function to scripts/functions.sh in the monorepo

Thanks for the feedback @aslakhellesoy that is all incredibly useful info!

Naming: Should we use History.md or CHANGELOG.md across repos?
1a. Should what we decide on be in all caps?

Looking at CONTRIBUTING.md, LICENSE, README.md and TODO.md I reckon CHANGELOG.md should be the preferred naming. The capitals appear to indicate these are documentation.

KaC does not include a method for including issue numbers, shall we just continue with including them as links at the end with the text being just the issue number?

I'm happy with the [Module] Message ([Issue Link], [Issue Link] Contributor Name One, Contributor Name Two) format.
I have no strong preference on the other items.

Let's not worry about the past - new CHANGELOG.md files should only list what's happened after the file was added.

How should we name the old changelog files?

Ad 3/4: Wouldn't it be helpful to include one of the keywords to automatically close the related issue? https://help.github.com/articles/closing-issues-using-keywords/

@mlvandijk This wouldn't be touching the Issue/PR directly, only the changelog file so I'm not should (and I could be wrong) that would work?

I wrote a simple ruby script for automatically looking for issue numbers like [#123] and adds a full Github url. Save to a file and specify the repo you want it to insert at run time.
To run: ruby updater.rb [repo-name] [CHANGELOG.md]
output = ''
File.foreach(ARGV[1]) do |line|
  match = line.match(/\[#(\d{1,3})\]/)
  output += match ? line.gsub(/\[#\d{1,3}\]/, "#{match}(https://github.com/cucumber/#{ARGV[0]}/issues/#{match[1]})") : line
end
File.open("#{ARGV[1]}", "w") {|file| file.puts output }

Keep a Changelog says that Changelog is "a curated, chronologically ordered list". By their own example it also says the "curated" trumps "chronologically ordered". Using git blame on their own Changelog reviles that in
- New "Guiding Principles" sub-section to "How do I make a changelog?".
- Simplified and Traditional Chinese translations from @tianshuo.
- German translation from @mpbzh & @Art4.
- Italian translation from @azkidenz.
- Swedish translation from @magol.

the entries on German and Italian translations was added two months after the entry on new guiding principles. When reading the Changelog to find out what changes were made in a release, I can see that is makes sense to list all added translations together. My take on this is that scrips are handy, but it is still the person using the script to update the Changelog that is responsible that the result is appropriate.
As an example from one of our own project, I think that all "Fix Metrics/LineLength" PR:s (cucumber/cucumber-ruby#1174, cucumber/cucumber-ruby#1175, cucumber/cucumber-ruby#1176 - of which the first is not mentioned in the changelog at all), should rather be grouped into one entry:
* Fix Lint/DuplicateMethods (#1174, #1175, #1176 ...)

now they seems to take up an unnecessary amount of real estate in the changelog.

This wouldn't be touching the Issue/PR directly, only the changelog

@jaysonesmith @mlvandijk It would be great is the script could detect and add the issues closed by the pull request (which "can" be done by parsing the pull request description), otherwise (at least me that thinks that this information belongs in the changelog) that information needs to be manually added after the script has been executed.
In either case their is still the work of checking (and if necessary adding) that the pull request description closes the appropriate issues, before merging the pull request.

@js, for cucumber-jvm, I put: "Please see CONTRIBUTING.md on how to contribute to Cucumber." - Let me know if that's ok and it can be merged :)

@mlvandijk That works for me. I've put the same at the top of the file for Aruba.

@js You're right, Github won't auto-close from the CHANGELOG. Would it be good practice to include these keywords in commit messages? Or would we prefer to close issues manually?
@brasmusson I was thinking the "Message" part in the line entry format would be the commit message, although I also very much agree with the need for it to be "curated" as the whole point of the changelog is to provide information on notable changes in a way that is easily understandable. It shouldn't be just a chronological list of commits (you can get those from git). Therefore, sometimes it might also be useful to expand on the basic info provided in the line entry format, i.e. in case of breaking changes / wider implications of the change(?)

Would it be good practice to include these keywords in commit messages? Or would we prefer to close issues manually?

@mlvandijk I prefer to close issues with pull request descriptions. Yes, in case I would push a fix for an issue directly to master, then that commit would both fix the issue and update the changelog, and its commit message would close the issue. I would not close issues (using those keywords in the commit message) with commits pushed to pull request branches. In that case I think that closing the issues is for the pull request description to do (using those keywords). Closing issues manually is just extra manual work which is to easily to be forgotten, and you will anyway when closing the issue refer to the pull request or commit that did the fix to get that traceability on Github, so it is much better to let Github to create that traceability automatically.

Making good progress tonight though I've realized that I had been formatting the issue and credit section incorrectly, separating the issue/pr numbers and the names with a comma when it was just supposed to be a space. /sigh

now they seems to take up an unnecessary amount of real estate in the changelog.

I agree and have fixed it.

Since I'm getting into the repos that don't currently track in a CHANGELOG/history file, I'm looking to create a template to be used. In working on this, I grabbed the raw data from the Gherkin CHANGELOG and noticed the contributors section and the release sections sneakily hidden in comments down at the bottom of the file.
Questions:

Is there an easy way to generate a list of current contributors to add to this file upon creation?
How do we want to handle repos that don't seem to have blatantly obvious(to me) officially released version? (a-la aruba-contrib)
Seeing the Gherkin file also starts off with the CHANGE LOG section, I move that we update our standard CHANGELOG file template to be, to include this as well. (Which means updating the files that I've already updated. Yours too, @mlvandijk & @mpkorstanje) In this header info, we can also point the reader to the monorepo contributing file, 'for more info'.

Header template:
# CHANGE LOG

All notable changes to this project will be documented in this file.

This project adheres to [Semantic Versioning](http://semver.org).

This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).

For more info on how to contribute to Cucumber, please visit our centralized [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) file in the main Cucumber repository.

----

I'm not 100% on the wording of the redirect to the monorepo's file in the header template, so I'm looking for some feedback there, too.
Thanks all!

I'm thinking this would be better.
Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) for more info on how to contribute to Cucumber.

Though cucumber-jvm also has its CONTRIBUTING.md.

@aslakhellesoy How are we going to architect the monorepo's contributing file? Are we going to have sections for the various languages and their nuances/requirements or are we going to have more umbrella data there and let the various repos continue to dictate finer details there?

@brasmusson I agree the issue should be closed on merge to master. A PR might not be approved/merged; in that case the issue should remain open.
@js Personally, I think it would be best to have overall guidelines in a central file, and specifics per repo in that repo but also pointing to the central file. Assuming many contributors would contribute to one particular repo/language only.
@aslakhellesoy @plaindocs Related question: Working on https://github.com/cucumber/docs.cucumber.io/issues/15 I noticed that (almost) none of the CONTRIBUTING.md files mention documentation specifically. I did find a general file on contributing to documentation (https://github.com/cucumber/cucumber/blob/master/docs/contributing-to-documentation.md) and added a link there to the new documentation project. Otherwise the process described there sounds good; I would like to merge it with: https://github.com/cucumber/docs.cucumber.io/blob/sw-reorg/CONTRIBUTING.md (preferably on master asap) and then point there from the central (and individual?) CONTRIBUTING.md files.

@brasmusson I agree the issue should be closed on merge to master. A PR might not be approved/merged; in that case the issue should remain open.

that is how that usually works afaik
@mlvandijk that sounds totally reasonable to me.

@plaindocs I've added a contributing-to-documentation.md to docs.cucumber.io straight to master. It needs to be rebased into sw-reorg and possibly/probably merged with some other info in there, but this way we at least have a place to point to from the other repos...
In general, since we are focusing on cucumber "generic" documentation first, should we make a distinction between BDD/Gherkin/Cucumber documentation which goes here, and implementation specific documentation which would still go in the separate repos?

Got a bunch of the new changelogs done and this issue is almost done, at least initially. (I didn't merge any this time! ;) )

Disregarding my mention of this issue in the above 1194, could I get a review of the open PRs above, please? Just waiting for approval, basically. Thanks!

PRs look fine to me as far as the text & links, but I'm not a contributor on these projects so

cannot verify the contributors are correct/complete
do not want to take the liberty to merge
not all of the checks have completed / passed:

https://github.com/cucumber/cucumber-electron/pull/15
Some checks haven't completed yet.
https://github.com/cucumber/cucumber-react/pull/1
Some checks haven't completed yet.
https://github.com/cucumber/cucumber-ruby/pull/1194
Some checks were not successful
https://github.com/cucumber/cucumber-ruby-wire/pull/13
Some checks haven't completed yet.
https://github.com/cucumber/cucumber-tcl-wire/pull/1
Some checks haven't completed yet.

Thanks @mlvandijk! I appreciate the time! WRT contributors, the members listed were pulled directly from Github using the following command and then I added myself to them:
curl https://api.github.com/repos/cucumber/github-issue-stats/contributors | jq 'sort_by(.login) | [.[] | {user: .login, url: .html_url}]'
@mattwynne  / @aslakhellesoy Now that these have been approved how would you like me to move forward? Also, are the Ruby tests broken?

@js That answers my 1st question. Thnx!

Unless anyone has objections, I'm going to go through and merge things today. I've also got a request from @maxmeyer to add a changelog to aruba-getting-started which I'll do too.

Everything except for the new changelog added in the aruba-getting-started repo has been merged! Almost done with this!

I think we're all set here! Going to close this out, we should probably extract the template I wrote above to be a guide for any new repos created?

@jaysonesmith I'm currently updating the Aruba change log with new changes, and I'm finding adding all the links for issues and users is becoming quite a chore. Is there any way to automate this?

Oh, #255 looks useful!


Fixed mismatched framework directives for vectorized memory move

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

This came up code review, https://github.com/icsharpcode/SharpZipLib/pull/611#discussion_r623915992
Do you disagree?

Unity's build engine defines NET_STANDARD_2_0 rather than NETSTANDARD2_0 which causes the library to fail to compile. (https://docs.unity3d.com/Manual/PlatformDependentCompilation.html)
!NETSTANDARD2_0 && !NETFRAMEWORK resolves to true, and contains code requiring the definition of VectorSize.
NETSTANDARD2_1 resolves to false, causing VectorSize to remain undefined.

Unity's build engine defines NET_STANDARD_2_0 rather than NETSTANDARD2_0 which causes the library to fail to compile. (https://docs.unity3d.com/Manual/PlatformDependentCompilation.html)
!NETSTANDARD2_0 && !NETFRAMEWORK resolves to true, and contains code requiring the definition of VectorSize.
NETSTANDARD2_1 resolves to false, causing VectorSize to remain undefined.

Frankly speaking I didn't know that _OR_GREATER were available. In that case I agree that this is much better. Moreover, this will also work for .NET 5.


Pub/Sub: please add DLQ samples for Pub/Sub

Please add samples for

create a subscription with a dead letter policy: pubsub_dead_letter_create_subscription
update a subscription's dead letter policy: pubsub_dead_letter_update_subscription
remove a subscription's dead letter policy: pubsub_dead_letter_remove
show the delivery attempt field in received messages: pubsub_dead_letter_delivery_attempt

See existing Java, Go, Python, Node samples.

Is this work still being planned?

Thanks for the reminder, and sorry for the delay. This sorta fell off my radar. I'm working on it today.


Draft notes from AKS upgrade

On the fly changes

I created a core_node_pool variable to hold misc configuration on our core node pool
I configured the new user node pool to use ephemeral (aka. Temporary) disks instead of persistent disks (aka. OS) based on seeing an Azure portal recommendation combined with knowing that we use ephemeral disks for our nodes in GKE for example.

Misc observation
The default_node_pool is required, and its a system type of node pool, which makes it unable to scale to zero. Due to this we should make use of that specific node pool. We could upgrade it without re-creating the cluster it seems, but only with a new terraform provider for the cluster versioned v3+, but I failed to migrate to it from v2. A fixme note about this is added in terraform config files and discussion is tracked in https://github.com/2i2c-org/meta/issues/539.

The default_node_pool we use as a core node pool can only be upgraded one minor version at the time. I expected that I should be allowed to let it be behind 3 minor versions behind the control plane.

The following was observed to upgrade during k8s control plane upgrade, but not coredns.
daemonset/cloud-node-manager
daemonset/csi-azuredisk-node
daemonset/kube-proxy
deployment/konnectivity-agent
deployment/metrics-server

calico-typha forces three core nodes, and its deployment's configured replica's is controlled by a tigera-operator so it can't be edited directly but must be edited by the operator. I opened #3592 about this.

Closing this one now, thanks for reporting back!


Unnecessary pybind11 dependency?

https://github.com/cvxpy/cvxpy/pull/2125 (released in 1.4.0) added pybind11 as a dependency, but it seems like it is just a build dependency, not a run time dependency?
One piece of evidence is that the cvxpy conda-forge feedstock did not add pybind11 as a dependency here and has gotten no complaints. I noticed this because I maintain a downstream feedstock that runs pip check as a test and that fails for cvxpy 1.4 because pybind11 is not installed.

Hmm it may be only a build dependency. @akshayka @rileyjmurray is pybind11 needed as a runtime dependency? I'm not that familiar with it.

Definitely only for build-time.
On Thu, Jan 18, 2024 at 7:07 PM Steven Diamond @.***>
wrote:

Hmm it may be only a build dependency. @akshayka
https://github.com/akshayka @rileyjmurray
https://github.com/rileyjmurray is pybind11 needed as a runtime
dependency? I'm not that familiar with it.
—
Reply to this email directly, view it on GitHub
https://github.com/cvxpy/cvxpy/issues/2330#issuecomment-1899414285, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRLIFGKSXGMQKH46QO3NDLYPG2NVAVCNFSM6AAAAABCA47UW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQYTIMRYGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Removed remaining update_assets tests

These tests are failing our in our e2e suite, with AttributeError. I they should have been removed in 1051d3d as part of #234 - is that correct @mallok-s ? Thanks!

Yes, sorry I must have missed them. Thank you for dealing with them

This threw up some linting errors (which hadn't been noticed before, because of #263, so I fixed all of the flake8 linters as well.
Which threw up an interesting one:
Adding type hints for the decorator @capture_event, and adding the correct ones using generics, allowed mypy to find another type error that was previously hidden.
Putting it the other way, decorators erase types by default. If you have any decorators in a stack of decorators that doesn't explicitly preserve type annotations, like this, then type information on the function is lost and the checker reports no problems, even if a human would look at the type sig and see the problem immediately.
i.e. mypy reports no errors on the following:
from functools import wraps

def noisy(func):
    @wraps(func)
    def _wrapper(*args, **kwargs):
        print(f"You called {func} with {args}, {kwargs}")
        return func(*args, **kwargs)

    return _wrapper

@noisy
def plus_1(arg: int) -> int:
    return arg + 1

def caller() -> None:
    print(plus_1("a string"))

You have to instead define your decorator like this:

That is interesting - I was always frustrated that decorates would lose the inner/wrapper types. Glad to see there is a solution to pull out the inner type and apply it to the top-level (agree that not typing the decorator body itself is an ok tradeoff).


Hardcoding libonnxruntime.so.1 library name value

This is a quick fix to tritonserver container backend. which fix non-found libonnxruntime.so.1
$ docker run --rm -it  tritonserver:24.08-py3-base bash -c "ldd backends/onnxruntime/libtriton_onnxruntime.so" | grep found
        libtritonserver.so => not found
        libonnxruntime.so.1 => not found

Do we have a RCA? Is this a temporary fix to unblock QA for 24.08 testing?

Do we have a RCA? Is this a temporary fix to unblock QA for 24.08 testing?

We have to accept change and rebuild the image to provide image to QA

Approving the temporary fix to unblock QA for 24.08 testing. Please create a follow up ticket, if required, to investigate and adopt a permanent solution.


Cannot resolve links when folders have periods in the name

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
I'm trying to link to docs in my docset that have periods "." in the folder name. * Meadow.Foundation for example.
This doesn't work though and give me the error Module not found: Error: Can't resolve './../../Meadow.Foundation' in '/Users/adam/_/Documentation/docs/Meadow/Getting_Started/Getting_Started_Core-Compute_Module'
I've confirmed it's due to the period in the folder name. Is there a way we can keep periods in our folder names and get this to work?
Reproducible demo
https://github.com/WildernessLabs/Documentation/tree/docusaurus
Steps to reproduce

Have a folder that has a period in its name
Create a link to a document within that folder
npm start
You should see that it can't resolve that link

Expected behavior
Please resolve links to documents within folders that have periods in their names 🙏🏻
Actual behavior
Module not found: Error: Can't resolve './../../Meadow.Foundation' in '/Users/adam//Documentation/docs/Meadow/Getting_Started/Getting_Started_Core-Compute_Module'
Module not found: Error: Can't resolve './../../Meadow.Foundation' in '/Users/adam//Documentation/docs/Meadow/Getting_Started/Hello_World'
Module not found: Error: Can't resolve './Maple.Server' in '/Users/adam//Documentation/docs/Meadow/Meadow.Foundation/Libraries_and_Frameworks'
Module not found: Error: Can't resolve './../../Meadow.Foundation/Libraries_and_Frameworks/Maple.Server' in '/Users/adam//Documentation/docs/Meadow/Meadow.OS/Networking'
Module not found: Error: Can't resolve './../../Meadow.Foundation' in '/Users/adam//Documentation/docs/Meadow/Meadow_Basics/IO'
Module not found: Error: Can't resolve './../../Meadow.OS' in '/Users/adam//Documentation/docs/Meadow/Meadow_Basics/Meadow.OS'
Module not found: Error: Can't resolve './../Meadow.Foundation' in '/Users/adam//Documentation/docs/Meadow/Meadow_Basics'
Module not found: Error: Can't resolve './../../Meadow.Foundation/Libraries_and_Frameworks/Maple.Server' in '/Users/adam//Documentation/docs/Meadow/Meadow․Foundation/Libraries_and_Frameworks'
Module not found: Error: Can't resolve './../../Meadow.Foundation/Libraries_and_Frameworks/Maple.Server' in '/Users/adam//Documentation/docs/Meadow/Release_Notes/Beta4'
Module not found: Error: Can't resolve './Meadow.Foundation' in '/Users/adam//Documentation/docs/Meadow'
client (webpack 5.89.0) compiled with 10 errors
Your environment

Public source code:
Public site URL:
Docusaurus version used: 2, (pretty involved to upgrade to 3, but we plan on it)
Environment name and version (e.g. Chrome 89, Node.js 16.4): Node 18.15.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Mac OS Ventura 13.2.1, Ubuntu on the build server

Self-service

[ ] I'd be willing to fix this bug myself.

It appears that this only affects links when the final URL segment contains a period. So, while /something/something.something would faile, /something/something.something/another would work fine. It also still fails for all the variants on that URL that resolve to the same page.

/something/something.something -> fail
/something/something.something/ -> fail
/something/something.something/index -> fail
/something/something.something/index.md -> fail

I've also tried a backslash without any luck.

/something/something\.something/ -> fail

Workaround
It's not a great solution, but it appears you can work around this issue by encoding the final segment's URL using percent encoding, which isn't strictly necessary for URL encoding. By swapping the . to %2E, it seems that the routing system is appeased.

/something/something%2Esomething/ (or /Meadow%2EFoundation for the original example).


Add AUT NZ

Add OshSU

@razorRun Please provide us with a proof, which shows that the school recognizes the domain autuni.onmicrosoft.com that you are submitting as an official email domain for the students.
@mamazhanov Please create a separate pull request. If you don't know how to do it, please send an email to<EMAIL_ADDRESS>

@razorRun You might miss my previous comment. Please react.

@razorRun I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for the understanding!


added link to become a mentor

Ishika Mittal | https://github.com/ishikaamittal | https://www.linkedin.com/in/ishika-mittal-2a3242183/ | Python Developer

@ishikaamittal Please add these details to MENTORS.md

added

@ishikaamittal I don't see it in diff.  Can you please check once?

@ishikaamittal I don't see it in diff. Can you please che

@ishikaamittal I don't see it in diff. Can you please check once?

Hi @ishikaamittal you have been added into mentors.md file so I am closing this PR now.


Generate raw data field as readonly

Fixes https://github.com/microsoft/typespec/issues/4350

API change check
API changes are not detected in this pull request.


[Master Branch] TOMEE-2240 ManagedScheduledExecutorService doesn't allow setting max value

Fix https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2240

Isnt 5s too small?
Also, dont forget to add new params to service-jar.xml in openejb-core.
Otherwise looks good!

Actually I need to close this! I wrote this patch before I read the javadoc on the scheduled executor service thoroughly. The max setting is a little misleading. When you wrote the original code you left the max out because it doesn't have the intended effect

No issue, thanks for taking time to PR and recheck it.


E101 should ignore multiline strings

In the code below, the whitespace ahead of a and b contains tabs and spaces:
from pathlib import Path

def b():
    Path("my_data.txt").write_text("""
    	a
    		b
    """)

This raises "E101 Indentation contains mixed spaces and tabs", even though this is not indentation but the contents of a multiline string where the leading indentation is user data and not python code. We should ignore multiline strings for E101.

I believe this is a dupe of https://github.com/astral-sh/ruff/issues/7906 where I was asking for a situation in which this would be used in practice.


Enum

Support enum to cast to enum type
Functions that throw should reuse implementation, because it is just () -> Optional to () -> throws

This is pretty great, no actually... This is super great! @onmyway133 🚀


The ‘Yes’ button isn’t selected on acquire/break lease dialog for one blob container

Storage Explorer Version: 1.10.0
Build: 20190909.2
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release
Steps to reproduce:

Expand a storage account -> Blob Containers.
Seletct one blob container and try to acquire lease.
Observe the acquire lease dialog.

Expect Experience:
The 'Yes' button is selected.

Actual Experience:
The 'Yes' button isn't selected.

Fix checked into master


Signal handling and return status in Go

See go/apps/mixnet/mixnet_router/mixnet_router.go:90 for related TODO. To handle signals in Go, one creates a chan os.Signal and run a go routine that waits on that channel. So we free up any resources that need to be freed and call os.Exit(), which accepts as input a byte conveying the exit status to the OS.  We would like this status to reflect the type of signal that was captured, but the os.Signal interface provides no means for getting at the signal number. This is less a CloudProxy issue and more an issue of the os.Signal interface.

You can indeed access the signal number. os.Signal is the generic interface type used for the signal mechanism. We are always running on linux, where the concrete type will be syscall.Signal, which converts directly to int. So:
signum := int(sig.(syscall.Signal))
Or if you are paranoid:
signum := syscall.SIGINT; // some reasonable default?
if s, ok := sig.(syscall.Signal); ok {
signum = int(s)
}

Thanks, John, that's immensely helpful.