Requested: io.read() support

io.read() support is requested. If it is already supported then I have missed it in the wiki and you have my apologies.
Use case would be to create a console driven menu system that would operate on user input (feedback).

I do think it's already supported

t=io.read(); print(t);
I tried this as an example both at the command line and in a script ran using dofile(), in both cases there is no wait for user input; it's like io.read() is ignored.
If it is indeed supported, is there a particular syntax I should try other than what I am?

t=io.read(); print(t);
I tried this as an example both at the command line and in a script ran using dofile(), in both cases there is no wait for user input; it's like io.read() is ignored.
If it is indeed supported, is there a particular syntax I should try other than what I am?

I have tried a multitude of variations for gather user input, from io.read() to io.input(io.stdin) and am unable to capture anything from the user. I also attempted the 'read a number' script linked in the wiki (https://wiki.cybermods.net/cyber-engine-tweaks/console/usage -> lua and am getting the same behavior as I first reported.

I have tried a multitude of variations for gather user input, from io.read() to io.input(io.stdin) and am unable to capture anything from the user. I also attempted the 'read a number' script linked in the wiki (https://wiki.cybermods.net/cyber-engine-tweaks/console/usage -> lua and am getting the same behavior as I first reported.

I do think it's already supported

I have tried a multitude of variations for gather user input, from io.read() to io.input(io.stdin) and am unable to capture anything from the user. I also attempted the 'read a number' script linked in the wiki (https://wiki.cybermods.net/cyber-engine-tweaks/console/usage -> lua and am getting the same behavior as I first reported.

I do think it's already supported

I have tried a multitude of variations for gather user input, from io.read() to io.input(io.stdin) and am unable to capture anything from the user. I also attempted the 'read a number' script linked in the wiki (https://wiki.cybermods.net/cyber-engine-tweaks/console/usage -> lua and am getting the same behavior as I first reported.

But io.read is implemented it just wont work on stdin since there is no stdin in this case. I really dont see the expected usage here. Console commands are processed by the lua vm, you can expose a function taking a string as arg if you want to parse commands but I suggest you use the lua scripting method instead.

But io.read is implemented it just wont work on stdin since there is no stdin in this case. I really dont see the expected usage here. Console commands are processed by the lua vm, you can expose a function taking a string as arg if you want to parse commands but I suggest you use the lua scripting method instead.


Mark the option --dsym-dir as deprecated

We don't support showing symbolicated crashes.
The option --dsym-dir is deprecated and ignored.
The functionality with the ability to view and download raw (unsymbolicated) crash reports is available on appcenter.ms

We can not break command line API like this. appcenter-cli is public API for all intents and purposes and is as such set in stone IMHO. We should still allow the parameter, but log a warning that it is deprecated and ignored.

@jmoody @krukow - If we're def making this available again - maybe we could create a VSTS task for the work and link to this PR so the engineer assigned just has to undo the commit when it's ready to be reintroduced?
Looks good to me though.

dSYM parsing will probably not be available.

Why are crashes that occur during test runs not symbolicated? This is something that was available with Xamarin Test Cloud.


Update doc plantuml

Update the images to use plantuml.

I've tried these plantuml files and they all works.
But do we still need these two files ( cellular_HAL_API_implementation.png and cellular_HAL_URC_handler_implementation.png)? seems they are almost the same as cellular_API_implementation.png and cellular_URC_handler_implementation.png.

Remove these two files in new commit.


Allow documenting option deprecation

Proposal: deprecated doc key for options
Author: Brian Coca <@bcoca> IRC: bcoca
Date: 2017/06/-1

Status: New
Proposal type: doc fields
Targeted Release: 2.4
Estimated time to implement: 5mins

Motivation
There is no way to document the deprecation of an option in plugins.
Problems
Will allow authors to document deprecation of options.
Solution proposal
A deprecated key that is composed of the following:

deprecated_in: version in which this option was deprecated
removed_in: version in which this option will be/has been removed
description: text/list explaining the reason and possible alternatives

Dependencies (optional)
Doc validator needs to permit

Links to things that will need updating

https://github.com/ansible/ansible/blob/devel/test/sanity/validate-modules/schema.py
https://docs.ansible.com/ansible/dev_guide/developing_modules_documenting.html#documentation-block
ansible-doc to display https://github.com/ansible/ansible/blob/devel/lib/ansible/cli/doc.py
Online docs updated https://github.com/ansible/ansible/blob/devel/docs/templates/plugin.rst.j2

Discussed in Core meeting 1st June 2017

+1 from gundalow, sivel, shertel

The above also believe that the module level deprecations should move to using this
Docs also need updating to point out how to deprecate options in argspec

Once merged the the following modules will need updating to make use of it:

network/f5/bigip_pool.py

Feel free to edit this comment to add other modules to the list

Discussed in Core meeting *st June 2017
+1 from Core thaumos ryansb jctanner gundalow, sivel, shertel
+1 from community: dminca
RESULT: Agreed
bcoca may do this as part of the Ansible config project

released in 2.4: infrastructure to support it and started using in plugins and config definitions/entries, new module deprecation should use the new format.


nbdev_install_quarto doesn't work with Windows 10 system

Bug description
This is the error code that I received when I attempted nbdev_install_quarto:
User
PS C:\Users\RongFangLi\test> nbdev_new --lib_name test_repo
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\RongFangLi\anaconda3\Scripts\nbdev_new.exe_main.py", line
4, in
File "C:\Users\RongFangLi\anaconda3\Lib\site-packages\nbdev\cli.py", line 13
, in
from .quarto import nbdev_readme, refresh_quarto_yml
File "C:\Users\RongFangLi\anaconda3\Lib\site-packages\nbdev\quarto.py", line
6, in
from os import system, uname
ImportError: cannot import name 'uname' from 'os' (C:\Users\RongFangLi\anacond
a3\Lib\os.py)

Steps to reproduce
Follow this guide on a windows 10 system:
https://nbdev.fast.ai/getting_started.html
Expected behavior
No error
Actual behavior
Error code above
Your environment
Windows 10 system on a standard i7 Lenovo laptop
Quarto check output
There was no other output other than the error message above. I believe it is simply a issue because the package is produced with Linux and Mac system in mind.
Thanks

Hi @ronfan, you check the solution to this problem over here https://forums.fast.ai/t/strugling-to-install-nbdev/109852/4


Use WM_STATE_FULLSCREEN for fullscreen under X11

This adds a more functional full screen mode for X11 that doesn't block window manager shortcuts like alt-tab because it doesn't grab the input.
However it is not finished, one downside of this approach is that changing the video mode from the desktop seems to introduce some graphical issues with composition window managers, before it's merged that will either have to be fixed, or doing what games that use SDL seem to do and just upscale to the native desktop resolution (compare with how Half Life 2, Super Meat Boy and Battleblock Theatre all behave under Linux).

This became part of #825, as such I'm marking this PR as superseded.


NFC Permissions

How can we force android to ask user permissions to acess NFC module?
Am emulating a tag, and i only start the emulation process when user clicks on a button but if the user doesn't have the nfc turned on, the aplication doesn't ask for permissions.
I already looked up react native documentation but i didn't found a permission for NFC.

Just googled about Your problem and found a SO topic which could be some kind of clue:
https://stackoverflow.com/questions/7618657/how-to-check-whether-nfc-is-enabled-or-not-in-android


Iteration of Char with invalid range of surrogate codepoints

When iterating of values of Char via #succ, #pred or #step, all possible values are treated like a consecutive sequence from Char::ZERO to Char::MAX. But this is actually not true: There's a gap in between. The high surrogate and low surrogate codepoints U+D800 through U+DFFF are not valid Char values.
Currently, you get an error when iterating into (or through) this gap:
'\uD7FF'.succ # ArgumentError: 0xd800 out of char range

This should be fixed such that the gap between U+D7FF and U+E000 is transparently skipped:
'\uD7FF'.succ # => '\uE000`
'\uD7FF'.step(to: '\uE000').to_a # => ['\uD7FF', '\uE000`]

This means that '\uD7FF'.succ has different semantics than '\uD7FF' + 1. The latter must stay an error because arithmatic operations are defined on codepoints. But we can make sure to iterate only the valid ranges.

Apart from ranges I think it makes sense that "\uD7FF".succ should be "\uE000".

Yeah, that totally slipped my mind. This applies to String as well.

I have confirmed that this is also the behaviour in Ruby:
def succ(str)
  str.succ.codepoints.map { |x| "U+%04X" % x }.join(' ')
end

succ("\u{D7FF}") # => "U+E000"

If Steppable is defined in terms of self + step and Char#+ continues to raise, how do we solve that? Could we introduce a step parameter to #succ itself instead?


refactor: set config sync directory to live outside files/

Context

Does this issue have a Trello card?
https://trello.com/c/g7kGCSTL/1876-manage-drupal-config-as-code

Intent
Following advice in https://www.drupal.org/docs/configuration-management/changing-the-storage-location-of-the-sync-directory, this PR moves the config sync directory out of sites/default/files.
This also gets us around our .gitignore ignoring the files/ directory, and means when we do a config export it gets picked up straight away.
This is step one to get our config into code 🥳.
Considerations

Is there any additional information that would help when reviewing this PR?
We don't use config sync at the moment, so this change shouldn't affect anything

Are there any steps required when merging/deploying this PR?
Nope

Checklist

[x] This PR contains only changes related to the above card
[x] Tests have been added/updated to cover the change - N/A
[x] Documentation has been updated where appropriate - N/A, we'll update the docs as part of the config-as-code piece
[x] Tested locally

This can be merged by the reviewer if there are no questions, rather than waiting for me to return on Tuesday :).

This can be merged by the reviewer if there are no questions, rather than waiting for me to return on Tuesday :).

Leon pointed out this probably wants to live outside the docroot, so I'll do something better and raise another PR when I'm back next week

Leon pointed out this probably wants to live outside the docroot, so I'll do something better and raise another PR when I'm back next week


Add AI disclaimer fields to configuration.toml

Type
enhancement, configuration changes

Description

Introduced two new configuration fields in configuration.toml to support AI disclaimers in the application.
ai_disclaimer_title allows setting a title for the AI disclaimer, enhancing user awareness and compliance.
ai_disclaimer enables specifying the full disclaimer text, ensuring users are informed about the use of AI within the application.

Changes walkthrough
Relevant filesConfiguration changes

configuration.tomlAdd AI Disclaimer Configuration Fields

pr_agent/settings/configuration.toml
Added ai_disclaimer_title field for setting the title of the AI disclaimer.  Added ai_disclaimer field for setting the full text of the AI disclaimer.

+2/-0

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

/improve

/describe


one pix more between minimap and sidebar

VSCode Version: 1.23.0
OS Version: macOS 10.13.4
Display: 1920 x 1200

Steps to Reproduce:

input a long string more than one line(about 80 char)
between minimap and sidebar,there is one pix out like this:

@zjjott I cannot reproduce. Are you using window.zoomLevel perhaps ?

For pixel perfect rendering, please use "window.zoomLevel": 0.


promethus-operator pod consistently exceeding 200Mi memory limit

What did you do?
Deploy Prometheus Operator using the official Helm charts, including the recommended resource request/limits for the prometheus-operator deployment:
# override-values.yaml
prometheusOperator:
  resources:
    limits:
      cpu: 200m
      memory: 200Mi
    requests:
      cpu: 100m
      memory: 100Mi

What did you expect to see?
Prometheus Operator (prom op) pods don't exceed 200Mi of memory, and thus don't get OOMKilled.
What did you see instead? Under which circumstances?
prom op pods are OOMKilled due to exceeding memory limits over and over until a CrashLoopBackoff.
Environment

Prometheus Operator version:
v0.25.0

Kubernetes version information:

Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.5", GitCommit:"753b2dbc622f5cc417845f0ff8a77f539a4213ea", GitTreeState:"clean", BuildDate:"2018-11-26T14:31:35Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
Cluster deployed using kubeadm.

Manifests:
If needed, I can supply the entire output of helm template, but AFAIK only the resource limits are relevant...

Prometheus Operator Logs:
This is all prom op is able to log before getting OOMKilled. It seems to always happen right after the cache sync init step:

ts=2019-02-04T16:00:51.194629125Z caller=main.go:165 msg="Starting Prometheus Operator version '0.25.0'."
level=info ts=2019-02-04T16:00:51.301535654Z caller=operator.go:209 component=alertmanageroperator msg="connection established" cluster-version=v1.11.5
level=info ts=2019-02-04T16:00:51.30199202Z caller=operator.go:371 component=prometheusoperator msg="connection established" cluster-version=v1.11.5
level=info ts=2019-02-04T16:00:51.782901968Z caller=operator.go:627 component=alertmanageroperator msg="CRD updated" crd=Alertmanager
level=info ts=2019-02-04T16:00:51.785798441Z caller=operator.go:1417 component=prometheusoperator msg="CRD updated" crd=Prometheus
level=info ts=2019-02-04T16:00:51.882077317Z caller=operator.go:1417 component=prometheusoperator msg="CRD updated" crd=ServiceMonitor
level=info ts=2019-02-04T16:00:51.89419149Z caller=operator.go:1417 component=prometheusoperator msg="CRD updated" crd=PrometheusRule
level=info ts=2019-02-04T16:00:54.786198053Z caller=operator.go:225 component=alertmanageroperator msg="CRD API endpoints ready"
level=info ts=2019-02-04T16:00:54.986717522Z caller=operator.go:180 component=alertmanageroperator msg="successfully synced all caches"
level=info ts=2019-02-04T16:00:54.986936335Z caller=operator.go:448 component=alertmanageroperator msg="sync alertmanager" key=cluster-monitoring/prometheus-operator-alertmanager
level=info ts=2019-02-04T16:01:00.915679299Z caller=operator.go:387 component=prometheusoperator msg="CRD API endpoints ready"

Other info
If I bump the memory limit higher, the prom op pod is able to finish initializing and caps out at around 360Mi memory usage:

So I guess my real question is, is it expected that Prometheus Operator pods take more than 200Mi of memory?  The cluster I'm having this issue on has only been running for ~1 month, and I have 3 other clusters where Prometheus Operator is deployed the same exact way that have been running for much longer and don't have this issue :thinking:

Also worth mentioning, after ~7 minutes of running the prom op pod drops back down below 200Mi of memory:

Depending on how you are running the Prometheus Operator it may need that amount, as it watches all Prometheus, ServiceMonitor, PrometheusRule, ConfigMap, Secret, StatefulSet, and Namespace objects configured, which may need some amount of memory depending on the size of your environment. That said the drop looks a little odd. Could you take a pprof memory profile and share it with us, then we could analyze the situation. (also it would be useful to graph the go_memstats_heap_inuse_bytes{job="promteheus-operator"} metric as that shows the actual usage by the process without garbage, as this drop might just be garbage collection happening)

Any updates on this @chrisob?

@metalmatze Admittedly, since I bumped the memory resource limit, prom operator hasn't been getting OOM killed, so I haven't yet read up on how to take a memory profile as per @brancz's suggestion...
I'm hoping to do this next week. As for sending the profile, what's the preferred way to send it to you guys?

You should be able to just upload the profile as an attachment on a github comment :slightly_smiling_face: . That's what people usually do on Prometheus.

@brancz Apologies for the delay, I didn't realize you had already baked pprof into prom operator, and I thought I was going to have to recompile!
Anyways, attached is a profile taken with go tool pprof -inuse_space -pdf -symbolize=remote http://localhost:8080/debug/pprof/heap, let me know if there's some other format/params which has more useful info, as I'm not so familiar with go profiling.
profile006.pdf
And here is the go_memstats_heap_inuse_bytes metric of prom operator graphed:

Aaaand the "stock" Grafana memory graph (which now exceeds 700MB):

So, I guess this is something to do with go's GC?

FWIW, the total size of all of the resources in this cluster that prom operator watches (you mentioned Prometheus, ServiceMonitor, PrometheusRule, ConfigMap, Secret, StatefulSet, and Namespace objects) is 155 MB.

Agreed with @chrisob part of the problem seems to simply be the amount of objects in your cluster. The difference between the 700Mb and 200Mb is cached memory. The in use memory metric already includes non-gc'd memory.

@brancz Thanks for the point in the right direction, I think the "correct" fix for me is to reduce the number of revisions that Helm stores in configmaps, as other pods that also read all CMs are also hitting their memory limits... :man_facepalming:


Downloading of files is not restricted, everyone who knows the link to a file, can download it.

What happened?
My repositories are hidden, so they are only visible when someone is logged in. But when someone knows the Link/ http url to a file, he can download it also when he is not logged in. I think that's a bug or a mising feature.
You can check it with: https://reposilite.pkg.hochguertel.work/releases/work/hochguertel/docs/as/code/structurizer-spring-boot/1.1.1/structurizer-spring-boot-1.1.1.jar
Visiting shows that there are no repositories listed when you are not logged in: https://reposilite.pkg.hochguertel.work
Reposilite version
3.x
Relevant log output
No response

Reposilite has 3 levels of visibility:

PUBLIC - Everyone can download & index (browse) repository content
HIDDEN - Everyone can download content without auth, but they're not able to index content of this repository, so they have to provide valid link to existing resource
PRIVATE - Only authenticated users can access repository content

Looks like you're using HIDDEN visibility, you can change it to PRIVATE in the dashboard:

Thanks!


Remove the Multiple Images & Collection

Since we are handling 3D images natively (Issue #49) no need for collections of 2D images

Also must update jupyter notebooks to remove this.

Also must update jupyter notebooks to remove this.


The inference speed on Cityscapes

Nice work! I wonder how much time you speed to process the images of Cityscapes. Thus we can compare it with ICNet.

Thanks for your interest. The code to test running speed is in experiments/segmentation/test_speed.py.
I test speed with a single random tensor of size (1,3,512,512), repeat and average the running time. In this way, the running speed is related to the size of the image, but irrelevant to which dataset.
I did not re-implement ICNet in PyTorch and did not compare with it. But it can be tested with test_speed.py if the model is well defined in PyTorch.


Not Enough Arguments

Describe your problem here.
When compiling the game, I get this error:
source/PlayState.hx:166: characters 55-72 : Not enough arguments, expected waveSpeed:Float, waveFrequency:Float, waveAmplitude:Float
Do you guys know a fix to this?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Attempting to add eyesores, as well as a NPS counter in Playstate.hx

i think your trying to import wavy bgs, i think u have to stick to 0.4.2 to 0.5.1 (try 0.5.2/h)


Refactor Guava Ordering class usages to be Stream + Comparator instead

The Issue
Android allows Java 8 to be used and in cases where it was not possible the compiler will transform it so it will always work in any Android API Level version.
Guava library offers a sorting class which is implicitly deprecated for Java 8 programmers as it offers the same functionality but without using Java 8. That will be interesting if Android didn’t offer a way to do it but, as I said and Odysee Android is already using it, there is a simple way.
The way to do it is via Java Stream and then use a Comparator instance.
There is no need to import a library if the same can be done using native APIs.
The one I found was Ordering.explicit() while trying to fix another issue, but there could be other places with Ordering class being used.
Internal Use
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

What should Ordering.explicit be replaced with? If I'm not mistaken that's used for matching the order of claims from Lighthouse after running a resolve call.


DS-3865: HTML5 Upload Pause Button does not work

Make pause button work again
https://jira.duraspace.org/browse/DS-3865

This is a quick, easy change with no master port needed so I'm not going to wait for another +1, merging it to 6.3 now! Thanks @philip-muench !


"Inspiring User Feedback Drives Fleeting Notes Development"

Users have provided valuable feedback and insights, driving the development of Fleeting Notes forward.

Summarized feedback from<EMAIL_ADDRESS>
Users have provided valuable feedback and insights, driving the development of Fleeting Notes forward.


Devicons on tabs

I have this function that adds Devicons to filenames (and removes undesired filenames). I wanted to be able to use it with the tabs. How could I do it?

Implement a function which accepts tab number and returns icon string of the corresponding buffer.
Add the function to g:lightline.tab_component_function.
Add the tab component to g:lightline.tab.active and g:lightline.tab.inactive.


Isolated Apps / Dynamic Budgets followup tasks

From https://github.com/getAlby/hub/pull/226

[ ] mixing DB transactions with "payment transactions" is not so good
[ ] Enable Roman's cleanup task for old request and response events
[ ] isolated app possible follow-ups (in case we wish to spend more time on isolated apps)

internal payments should trigger NIP-47 notifications (this can be done by the transactions service publishing its own notifications rather than the notifier subscribing to LNClient notifications - this would simplify things too)
restrict isolated balance to not receive more than a certain budget (it's hard to do?)
prevent hub not spending balance that is set aside for other apps
prevent paying more than actual balance from main wallet into isolated wallets (you can send an infinite amount)
cashu isolated app payments does not work and causes money to be "lost" - disabled for now

[x] currently there are no DB indexes. I am not sure how this will perform when the number of payments grow
[ ] ListTransactions on LNClients that support notifications should actually just throw an error (they should never be used)
[ ] fee reserve calculation could be per-LNClient to completely match what the node sets
[ ] Extra nip-47 controller tests

[ ] multi_pay_keysend (partial success)
[ ] list_transactions (paging params)

[ ] onboard your friend/family flow with Dynamic Budgets and Alby Mobile
[ ] undo LDK database changes in Alby fork (probably by undoing changes and then deleting old payments in a migration as they will be unused after we have our own payment DB)
[ ] Blog post

prevent hub not spending balance that is set aside for other apps

this seems very important if you want to share your hub with friends and family

prevent hub not spending balance that is set aside for other apps

this seems very important if you want to share your hub with friends and family

Yes, I second that. Should be a more priority. At least it would be helpfull show it if this happens. Right now I have to watch this myself and that is tricky without the exact balances from each isolated / family wallets!


Port java.math tests

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2502/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3237/
Test FAILed.


Fixing missing semicolons which they cause warnings in the console.

thanks, @lihan but @inertum fixed this in last commits :)


Doc for audit-log-format

Add documentation for 'audit-log-format'

This change is

Closed in preference to #5300


Upgraded to gradle 6.5.1 + added gradlew scripts

Signed-off-by: Eugen Stan<EMAIL_ADDRESS>Description
Upgrade gradle and added the gradle scripts.
Motivation and Context
The normal way to build apps locally is to use the ./gradlew script that will get the exact version of gradle needed to build the project.
Adding the script makes it so that users don't require gradle installed locally.
It will be downloaded.
How Has This Been Tested?
Ran ./verify.sh locally.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users
I don't see negative impact.
Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I don't want to see the Gradle folders and scripts in the template, please can you remove those and just bump up the version and make any required changes to the Gradle build files? You said that "compile" is deprecated now?

Having the version files without the wrapper scripts provides little to no value.
They are designed to work together.
The wrapper will use the version files to get the exact version of gradle to build the project.
The gradle wrapper is meant to be added to version control.
Gradle developers expect the wrapper.
I always use the wrapper to build gradle apps.
I know many people avoid adding binaries to source control.
I avoid that too but sometimes it makes sense and it is ok.
This is IMO one of those cases.
https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:adding_wrapper

To make the Wrapper files available to other developers and execution environments you’ll need to check them into version control. All Wrapper files including the JAR file are very small in size. Adding the JAR file to version control is expected. Some organizations do not allow projects to submit binary files to version control. At the moment there are no alternative options to the approach.

I think the java8 template should be deprecated and removed, isn't Java 8 out of support now?

I think it's safe to do that sine openfaas is targeting new implementations and less so legacy apps.
Also, the fact that we build the mode/entrypoint code with Java 11 does not mean the functions can't run on any 11+ Java version.
I would very much like to have the functions available in many java versions.
I think we should allow this as an argument when we build the image ( I need to read more on the documentation to find out what I can and can't do OOTB in openfaas ).
Java is evolving at a steady 6 month pace and writing functions with some of the newer features is a big win IMO.
People can use new features in smaller (safer) code bases.


"space-before-combinator": 1 disturb indentation rule...

Hi I want to add a space before combinator, but I want reshape that new line first-letter is not space.
When line break is applied by csscomb, the setting "space-before-combinator: 1" is applied to the new line (first letter is combinator) as well, so the indentation does not become what I intended.
Is there a way to solve this issue?
Example:
Default
.foo {
> .foo {
prop: val;
}
}

After using CSSComb:
Actual result 1（bad）:
space-before-combinator：" ",

Actual result 2（bad）:
space-before-combinator："",

The result I am expecting to get（Good）:
space-before-combinator：" ",

A PR \o/

Fixed with #599.

Is this released already? I just updated to version 4.3 and I'm seeing exactly this behavior.

@lhtdesignde

Is this released already? I just updated to version 4.3 and I'm seeing exactly this behavior.

Yes. Would you please open a new issue with your repo.


Explore integrating LangChain tools

https://js.langchain.com/docs/integrations/tools

I can work on this.

@ighoshsubho, thanks again! I'd love to hear what your vision is for how tools could be integrated with Lumos. To be transparent, I haven't actually used the tools before, so I don't necessarily have a goal or vision yet. This issue was originally just a reminder for me to do some research 😄
Anyways, I'm open to hearing from you! There are constraints, considerations, and questions that I'm interested in. For example:

How are tools invoked?
How are tools configured?
How do the tools work offline?
Are the tools free ($)?
How do users "build and bring their own tools" outside of LangChainJS's tools?
How do users share their tools with others?


New package: RaptorTech.RaptorHardwareService version <IP_ADDRESS>

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Automatic Validation ended with:

[0C14:057C][2024-05-12T07:30:02]e000: Error 0x800700d8: Process returned error: 0xd8
[0C14:057C][2024-05-12T07:30:02]e000: Error 0x800700d8: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:02]e000: Error 0x800700d8: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:02]w350: Applied non-vital package: Redist2008_64, encountered error: 0x800700d8. Continuing...
[0C14:057C][2024-05-12T07:30:11]e000: Error 0x800713ec: Process returned error: 0x13ec
[0C14:057C][2024-05-12T07:30:11]e000: Error 0x800713ec: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:11]e000: Error 0x800713ec: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:11]w350: Applied non-vital package: Redist2010_64, encountered error: 0x800713ec. Continuing...
[0C14:057C][2024-05-12T07:30:14]e000: Error 0x81f40001: Process returned error: 0x81f40001
[0C14:057C][2024-05-12T07:30:14]e000: Error 0x81f40001: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:14]e000: Error 0x81f40001: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:14]w350: Applied non-vital package: Redist2012_64, encountered error: 0x81f40001. Continuing...
[0C14:057C][2024-05-12T07:30:18]e000: Error 0x80070001: Process returned error: 0x1
[0C14:057C][2024-05-12T07:30:18]e000: Error 0x80070001: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:18]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:18]w350: Applied non-vital package: Redist2013_64, encountered error: 0x80070001. Continuing...
[0C14:057C][2024-05-12T07:30:21]e000: Error 0x80070001: Process returned error: 0x1
[0C14:057C][2024-05-12T07:30:21]e000: Error 0x80070001: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:21]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:21]w350: Applied non-vital package: Redist2015_64, encountered error: 0x80070001. Continuing...
[0C14:057C][2024-05-12T07:30:27]e000: Error 0x80070001: Process returned error: 0x1
[0C14:057C][2024-05-12T07:30:27]e000: Error 0x80070001: Failed to execute EXE package.
[0F48:1064][2024-05-12T07:30:27]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[0F48:1064][2024-05-12T07:30:27]w350: Applied non-vital package: Redist2019_64, encountered error: 0x80070001. Continuing...

(Automated response - build 880.)

With the dependency installed, this package installs successfully, with exit code -1978335226 whic often means "Install successful but system restart may be required."
Verify:

This package also installs these other packages:

3M(TM)) Full Page Reader Device Drivers (thus)
Acuant SDK
Bonjour (Apple networking?)
DYMO Connect
DYMO Label v.8
VCRedist 2008, 2010, 2012, 2015, and 2015-2019 - both x86 and x64 of each.
Raptor Hardware Service Updater
ScanShell 800DX
ScanShell 800DX Driver

This package also installs these other packages:
* `3M(TM)) Full Page Reader Device Drivers` (thus)

* Acuant SDK

* Bonjour (Apple networking? AKA `Apple.Bonjour`)

* DYMO Connect (`SanfordLP.DYMOConnect`)

* DYMO Label v.8 (`SanfordLP.DYMOLabel`)

* `VCRedist` 2008, 2010, 2012, and 2015-2019 - both `x86` and `x64` of each. (`Microsoft.VCRedist.`Year.Arch)

* Raptor Hardware Service Updater

* ScanShell 800DX

* ScanShell 800DX Driver

That is expected. This software has dependencies on all those packages. Please let me know if I need to make any changes to allow for that.
I appreciate the help/patience. This is my first winget package.

This package also installs these other packages:
* `3M(TM)) Full Page Reader Device Drivers` (thus)

* Acuant SDK

* Bonjour (Apple networking? AKA `Apple.Bonjour`)

* DYMO Connect (`SanfordLP.DYMOConnect`)

* DYMO Label v.8 (`SanfordLP.DYMOLabel`)

* `VCRedist` 2008, 2010, 2012, and 2015-2019 - both `x86` and `x64` of each. (`Microsoft.VCRedist.`Year.Arch)

* Raptor Hardware Service Updater

* ScanShell 800DX

* ScanShell 800DX Driver

That is expected. This software has dependencies on all those packages. Please let me know if I need to make any changes to allow for that.
I appreciate the help/patience. This is my first winget package.

No worries here. To proceed, the .NET 3.5 Framework WindowsFeature mentioned above will need to be added, since the program depends on it to run. This will automatically install the .NET 3.5 Framework before running this package's installer, so the framework is available.

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-19 16:38:20.803 [CLI ] ShellExecute installer failed: 1
MSI (s) (AC:2C) [16:37:58:207]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
WixRemoveFoldersEx:  Error 0x80070057: Missing folder property: SUBINSTALLLOCATION for row: wrf726A0F9DBD80AD9854A373F3222ECCBF
CustomAction WixRemoveFoldersEx returned actual error code 1603 but will be translated to success due to continue marking
SchedSecureObjectsRollback:  Failed to store ACL rollback information with error 0x80070424 - continuing
MSI (s) (AC:2C) [16:38:01:145]: Executing op: ComponentRegister(ComponentId={8C5E0981-4C64-5E8E-99D0-6F1F8B756800},KeyPath=C:\Program Files\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0)
MSI (s) (AC:2C) [16:38:02:145]: Executing op: FileCopy(SourceName=mdpzc2t8.dll|ErrorHandlerDll.dll,SourceCabKey=fil075DCCE23C502655966A6DE9112B3DF8,DestName=ErrorHandlerDll.dll,Attributes=512,FileSize=80384,PerTick=65536,,VerifyMedia=1,,,,,CheckCRC=0,Version=<IP_ADDRESS>,Language=2057,InstallMode=58982400,,,,,,,)
MSI (s) (AC:2C) [16:38:02:145]: File: C:\Program Files\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll;	To be installed;	Won't patch;	No existing file
MSI (s) (AC:2C) [16:38:07:317]: Executing op: ServiceInstall(Name=RaptorHardwareService,DisplayName=Raptor Hardware Service,ImagePath="C:\Program Files\Raptor Technologies LLC\RaptorHardwareService\Raptorware.ClientService.Server.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to facilitate scanning and printing for the Raptor System,,)
MSI (s) (AC:08) [16:38:15:473]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
MSI (s) (AC:08) [16:38:17:004]: Executing op: ServiceInstall(Name=RaptorHardwareServiceUpdater,DisplayName=Raptor Hardware Service Updater,ImagePath="C:\Program Files\Raptor Technologies LLC\RaptorHardwareServiceUpdater\Raptor.Client.HardwareUpdaterService.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to update the Raptor System Hardware Service,,)
[0830:11D8][2024-05-19T16:32:52]e000: Error 0x800700d8: Process returned error: 0xd8
[0830:11D8][2024-05-19T16:32:52]e000: Error 0x800700d8: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:32:52]e000: Error 0x800700d8: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:32:52]w350: Applied non-vital package: Redist2008_64, encountered error: 0x800700d8. Continuing...
[0830:11D8][2024-05-19T16:33:01]e000: Error 0x800713ec: Process returned error: 0x13ec
[0830:11D8][2024-05-19T16:33:01]e000: Error 0x800713ec: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:33:01]e000: Error 0x800713ec: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:33:01]w350: Applied non-vital package: Redist2010_64, encountered error: 0x800713ec. Continuing...
[0830:11D8][2024-05-19T16:33:04]e000: Error 0x81f40001: Process returned error: 0x81f40001
[0830:11D8][2024-05-19T16:33:04]e000: Error 0x81f40001: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:33:04]e000: Error 0x81f40001: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:33:04]w350: Applied non-vital package: Redist2012_64, encountered error: 0x81f40001. Continuing...
[0830:11D8][2024-05-19T16:33:07]e000: Error 0x80070001: Process returned error: 0x1
[0830:11D8][2024-05-19T16:33:07]e000: Error 0x80070001: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:33:07]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:33:07]w350: Applied non-vital package: Redist2013_64, encountered error: 0x80070001. Continuing...
[0830:11D8][2024-05-19T16:33:11]e000: Error 0x80070001: Process returned error: 0x1
[0830:11D8][2024-05-19T16:33:11]e000: Error 0x80070001: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:33:11]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:33:11]w350: Applied non-vital package: Redist2015_64, encountered error: 0x80070001. Continuing...
[0830:11D8][2024-05-19T16:33:17]e000: Error 0x80070001: Process returned error: 0x1
[0830:11D8][2024-05-19T16:33:17]e000: Error 0x80070001: Failed to execute EXE package.
[1CD8:0D94][2024-05-19T16:33:17]e000: Error 0x80070001: Failed to configure per-machine EXE package.
[1CD8:0D94][2024-05-19T16:33:17]w350: Applied non-vital package: Redist2019_64, encountered error: 0x80070001. Continuing...

Automated error analysis suggests 0x80070001 may mean Windows cannot install required files.
Automated error analysis suggests 0x80070057 may mean The parameter is incorrect.
Automated error analysis suggests 1603 may mean Install successful but system restart may be required. Should this be add as an InstallerSuccessCode or similar?
Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.
(Automated response - build 881.)

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-22 13:18:09.660 [CLI ] ShellExecute installer failed: 1
MSI (s) (A8:7C) [13:17:45:854]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
WixRemoveFoldersEx:  Error 0x80070057: Missing folder property: SUBINSTALLLOCATION for row: wrf726A0F9DBD80AD9854A373F3222ECCBF
CustomAction WixRemoveFoldersEx returned actual error code 1603 but will be translated to success due to continue marking
SchedSecureObjectsRollback:  Failed to store ACL rollback information with error 0x80070424 - continuing
MSI (s) (A8:7C) [13:17:49:026]: Executing op: ComponentRegister(ComponentId={8C5E0981-4C64-5E8E-99D0-6F1F8B756800},KeyPath=C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0)
MSI (s) (A8:7C) [13:17:49:026]: WIN64DUALFOLDERS: Substitution in 'C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll' folder had been blocked by the 1 mask argument (the folder pair's iSwapAttrib member = 0).
MSI (s) (A8:7C) [13:17:50:120]: Executing op: FileCopy(SourceName=mdpzc2t8.dll|ErrorHandlerDll.dll,SourceCabKey=fil075DCCE23C502655966A6DE9112B3DF8,DestName=ErrorHandlerDll.dll,Attributes=512,FileSize=80384,PerTick=65536,,VerifyMedia=1,,,,,CheckCRC=0,Version=<IP_ADDRESS>,Language=2057,InstallMode=58982400,,,,,,,)
MSI (s) (A8:7C) [13:17:50:120]: File: C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll;	To be installed;	Won't patch;	No existing file
MSI (s) (A8:7C) [13:17:55:386]: Executing op: ServiceInstall(Name=RaptorHardwareService,DisplayName=Raptor Hardware Service,ImagePath="C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\Raptorware.ClientService.Server.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to facilitate scanning and printing for the Raptor System,,)
MSI (s) (A8:74) [13:18:03:073]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
MSI (s) (A8:74) [13:18:05:542]: Executing op: ServiceInstall(Name=RaptorHardwareServiceUpdater,DisplayName=Raptor Hardware Service Updater,ImagePath="C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareServiceUpdater\Raptor.Client.HardwareUpdaterService.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to update the Raptor System Hardware Service,,)

Automated error analysis suggests 0x80070057 may mean The parameter is incorrect.
Automated error analysis suggests 0x80070424 may mean The specified service does not exist as an installed service.
Automated error analysis suggests 1603 may mean Install successful but system restart may be required. Should this be add as an InstallerSuccessCode or similar?
Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.
(Automated response - build 881.)

This package installs and launches correctly, despite returning a non-zero exit code.

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-30 06:00:18.618 [CLI ] ShellExecute installer failed: 1
MSI (s) (D0:58) [05:59:55:121]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
WixRemoveFoldersEx:  Error 0x80070057: Missing folder property: SUBINSTALLLOCATION for row: wrf726A0F9DBD80AD9854A373F3222ECCBF
CustomAction WixRemoveFoldersEx returned actual error code 1603 but will be translated to success due to continue marking
SchedSecureObjectsRollback:  Failed to store ACL rollback information with error 0x80070424 - continuing
MSI (s) (D0:58) [05:59:58:356]: Executing op: ComponentRegister(ComponentId={8C5E0981-4C64-5E8E-99D0-6F1F8B756800},KeyPath=C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0)
MSI (s) (D0:58) [05:59:58:356]: WIN64DUALFOLDERS: Substitution in 'C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll' folder had been blocked by the 1 mask argument (the folder pair's iSwapAttrib member = 0).
MSI (s) (D0:58) [05:59:59:465]: Executing op: FileCopy(SourceName=mdpzc2t8.dll|ErrorHandlerDll.dll,SourceCabKey=fil075DCCE23C502655966A6DE9112B3DF8,DestName=ErrorHandlerDll.dll,Attributes=512,FileSize=80384,PerTick=65536,,VerifyMedia=1,,,,,CheckCRC=0,Version=<IP_ADDRESS>,Language=2057,InstallMode=58982400,,,,,,,)
MSI (s) (D0:58) [05:59:59:465]: File: C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\ErrorHandlerDll.dll;	To be installed;	Won't patch;	No existing file
MSI (s) (D0:58) [06:00:04:746]: Executing op: ServiceInstall(Name=RaptorHardwareService,DisplayName=Raptor Hardware Service,ImagePath="C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareService\Raptorware.ClientService.Server.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to facilitate scanning and printing for the Raptor System,,)
MSI (s) (D0:BC) [06:00:12:793]: APPCOMPAT: [DetectVersionLaunchCondition] Failed to initialize pRecErr.
MSI (s) (D0:BC) [06:00:14:762]: Executing op: ServiceInstall(Name=RaptorHardwareServiceUpdater,DisplayName=Raptor Hardware Service Updater,ImagePath="C:\Program Files (x86)\Raptor Technologies LLC\RaptorHardwareServiceUpdater\Raptor.Client.HardwareUpdaterService.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=[~],,,Password=,Description=Service to update the Raptor System Hardware Service,,)

Automated error analysis suggests 0x80070057 may mean The parameter is incorrect.
Automated error analysis suggests 0x80070424 may mean The specified service does not exist as an installed service.
Automated error analysis suggests 1603 may mean Install successful but system restart may be required. Should this be add as an InstallerSuccessCode or similar?
Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.
(Automated response - build 882.)


Support dynamic linking with Rust ABI and not C ABI

Now I know the rust team has shot down the idea of having stable ABI, and I am in favor of it, but there is a way to support dynamic linking with Rust ABI without defining a stable ABI. It is lot more cumbersome, but definitely possible. What I am proposing is that each crate creates a single shared library and exports a symbol like below.
RUSTC_1.49::<Crate>_<version>

This symbol will then be required by the executable linking to this shared library at runtime.
But to achieve this we will have to solve a few questions first

[ ] When including crate version, should we include full version (major.minor.build) or just major.minor?
[ ] Does Cargo currently pass crate versions to rustc, and if not we will have to define a way to do this.
[ ] Expose a mechanism in cargo to build a crate as dynamic library, or use a crate as dynamic library
[ ] Provide a way in cargo to pick a prebuilt shared library, in a way that the above symbol is verified before linking and not during linking

This advantage of supporting this form of shared libraries, is that as long as the rust compiler is same and the whole ecosystem is controlled (like in embedded linux world), we can leverage the use of shared libraries and reduce disk space and memory usage. Both memory and disk space can be a big issue in embedded linux systems.

You can already link to crate-type=dylib crates provided both the library and the artifact linking to were compiled with the same compiler. Hashes contained within symbols will also prevent linking to the wrong shared library at runtime.
Cargo also knows how to link to crate-type="dylib" crates, though much like for rlib crates it will compile its own copy.
Provided the crates are all reproducible, the shared objects cargo produces and links to should all be the same for every crate build and therefore it should be sufficient to just keep one of them.

@nagisa In that case would it possible to pick a crate-type=dylib crate as a binary crate. The reason I ask is at my company adopting Rust would become a major issue, since building everything you need every time will be very time consuming
(I am talking in hours) and also resource consuming. It would be better if crates could be pulled in binary form from a controlled centralized location in their binary forms and directly linked.
I know in case of generics, we would still have to compile the source at call site, but that is minor thing compared to compiling all dependent crates every time.

not that it fully fixes the issue, but as a temporary measure have you considered something like sccache?

It'll become interesting if build reproducibility plays some role here.  I've no objection since reproducible build becomes super important for many reasons, but it's clearly a dramatic step.  :)
As raised on internals, we need where Self: Sized bounds for associated consts and types, so they exist only in monomorpized code but disappear from trait objects.  In this way, we'd merge many type erased traits with their underlying trait, so then easy default type erased methods avoid orphan rules conflicts resulting from global impls of type erasing traits.  This should make dyn Trait more usable in practice, which serves some of the same goals.

It would be nice to be able to link against pre-compiled dylib, without having to use the C ABI.
This becomes very important on large projects, where compiling multiple crates can be time consuming.
For example, a game engine, where whoever uses it to build their games would have to recompile the entire engine, when it could just be precompiled, at least in debug mode.

cc https://github.com/rust-lang/rust/pull/105586

In theory, Rust could leverage ELF shared object symbol versioning and similar tricks to prevent version mismatches between binaries and libraries.
Unfortunately this mechanism is limited to 1) ELF targets and 2) Quite possibly GNU/Linux targets specifically.
Short of inventing a brand new Truly Unified Rusty Binary Format there's gonna be no way around establishing some kind of stable ABI for Rust before dylibs/dynamic linking before something that's seriously usable without going through the C ABI.
As for "crates should ship precompiled binaries" this has happened before (serde_derive) and was seen as extremely controversial and problematic due to multiple reasons. So it's unlikely that that's going to be a motivating use case for enabling "Rust-ABI" dylibs.

Would crABI (rust-lang/rust/111423) solve this?


Feature proposal: automatically populate config.json from AWS Organizations

It would be very handy to have a feature to automatically populate the config.json file from children accounts of an AWS organization. Something like:
cloudmapper.py configure discover-organization-accounts

Happy to submit a PR if you're sold on the idea!

done in #758


Redis caching ecosystems

Solves #488 by implementing redis caching for debian ecosystems. Other ecosystems have not yet been implemented.

Added a test in ecosystem_test to make sure cache is being called, should I also add a unit test for request_helpers?

Added a test in ecosystem_test to make sure cache is being called, should I also add a unit test for request_helpers?

Yes please! Let's add a test with a mock/in-memory cache to make sure that the cache is being used properly.

Looks like something broke with the worker tests (https://github.com/google/osv.dev/pull/490/checks?check_run_id=7209020773). Could you please take a look?

Looks like something broke with the worker tests (https://github.com/google/osv.dev/pull/490/checks?check_run_id=7209020773). Could you please take a look?

Maybe the issue is the name of the dependency being weird. Adding the dependency as:
osv = {editable = true, path = "./lib"}

or
[packages.osv]
path = "./lib"
editable = true

seem to solve it.

Looks like something broke with the worker tests (https://github.com/google/osv.dev/pull/490/checks?check_run_id=7209020773). Could you please take a look?

Maybe the issue is the name of the dependency being weird. Adding the dependency as:
osv = {editable = true, path = "./lib"}

or
[packages.osv]
path = "./lib"
editable = true

seem to solve it.

very nice!!


how to reload data?

hi, thx for this implementation and as title, how to reload data ?

hi, how about this issue now?
thanks.

in MyControllerIndex: RGPageViewController,RGPageViewControllerDataSource,RGPageViewControllerDelegate, ...
self.needsSetup=true
self.setupSelf()
self.currentTabIndex=0
self.selectTabAtIndex(self.currentTabIndex)

there is a reloadData Function


check if log2 or natural log(ln) should be used in limma manual/vignettes

adapt acordingly

https://www.researchgate.net/post/Why_do_we_usually_use_Log2_when_normalizing_the_expression_of_genes

log2, as implemented, is the way to go for bulk count data (e.g., for RNA-seq according to limma user guide)


Quickly set future due date using 1-9 as "days from today"

Hello again, @mgsloan.  I've put these as two different pull requests and you can choose to not use either, both, one or the other -- up to you!
This edit adds 1-9 as commands in the scheduler to allow for quick setting of a due date as "N days from today"
-- Adam

Thanks, this is awesome!!  Sorry for the review delay.
I made a few adjustments: https://github.com/mgsloan/todoist-shortcuts/compare/b4666f4...0b8dec3


Update to the latest version of Playwright/Chromium and release

To keep the Recorder up to date, upgrade to the latest version of Playwright/Chromium

@paulb-elastic it seems that Synthetics is using 1.35.0 version of Playwright, which is the same that the Recorder uses. Is this ticket preemptive of future changes to Synthetics?

++ this is a repetitive task that we do for every release. Check synthetics part https://github.com/elastic/synthetics/issues/807

Aha thanks for clarification @vigneshshanmugam.

@justinkambic did this in https://github.com/elastic/synthetics-recorder/pull/457

Reopening to get the release done

1.2.0 of the recorder published (no longer draft) and DOWNLOAD.MD updated to point to the new version


Ingress 1.2.0 chart not present in Helm repo

Ran 5mins ago:
hal@arch ~ took 2s
❯ helm repo update
Hang tight while we grab the latest from your chart repositories...
[...]
...Successfully got an update from the "livekit" chart repository
[...]
Update Complete. ⎈Happy Helming!⎈

hal@arch ~
❯ helm search repo livekit
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
livekit/livekit-recorder        0.3.13          v0.3.13         LiveKit recorder is used by LiveKit server to r...
livekit/livekit-server          1.5.0           v1.5.0          Open source WebRTC infrastructure. Host your ow...
livekit/egress                  1.8.0           v1.8.0          Egress is used by LiveKit to stream and record ...
livekit/ingress                 1.1.0           v1.1.0          Ingress is used by LiveKit to ingest streams pr...

The chart is updated in this repo but not in the chart repo shown in the README.md
This is probably not a bug but some miscommunication on how the release process is done. Perhaps a delay is completely intended.
This may cause confusion for some people

1.2.2 will be released tomorrow. closing this one.


Access blocked: Nest’s request is invalid

The problem
today i was asked to re-auth to generator a new token but received the error message in title. any ideas how to work around or a bug fix ? thanks,
What version of this integration (ha-nest-protect) has the issue?
0.3.12
What version of Home Assistant Core has the issue?
core-2024.7.4
Device / Model
No response
Diagnostics information
No response
Home Assistant log
Logs
Copy/paste any log here, between the starting and ending backticks (`)

Additional information
No response

Same issue here

This was also reported 2 years ago and is still an open issue. I'm not sure this is still being supported?

I have the same issue

See #105. TLDR: download latest beta / pre-release of this integration. Hopefully in the coming months we can fix some of the bugs and merge it back to the stable release..


Using a dashboard variable in Update Request Payload custom code

Is there a way to get the current variable for a dashboard when updating the request payload?

@RyIot3329 sure. You can get the variable value by the following example
console.log('variable value', '$var')

Where var is the variable name


New feature: "straight" as a pathFunc

I was interested in seeing what a "straight" pathFunc would look like, and while I don't have any experience using D3, I was able to cobble something together.
I like the end result, and it works nicely for one of my use cases.
Let me know what you think, and if there are any changes that I need to make. Thanks!

Fail. Looks like this has caused the test coverage threshold to drop below the acceptable level.

Coverage decreased (-0.5%) to 92.5% when pulling c6e1d9da42ada2a963f7c0d0b9ddda74777c5024 on justinsisley:feature/straight-links into e489e6cf9eac4fbb4db7077b275bcfcbb2c22a69 on bkrem:master.

I've added a test case for straightPath that was really an obvious miss on my part, but now that jest is happy, coveralls isn't. I'll see what else I can get coverage on.

Coverage increased (+0.5%) to 93.5% when pulling 68a8278995f024051406bb6e23c952622458b775 on justinsisley:feature/straight-links into e489e6cf9eac4fbb4db7077b275bcfcbb2c22a69 on bkrem:master.

I've converted the switch/case inside of the drawPath method to if conditions. This improves the code coverage, since the default case is considered a new potential execution branch.
I think if conditions are fine here, since there probably can't be too many (if any) more pathFunc's that could be implemented.
Let me know what you think.

This looks great @justinsisley, thanks for implementing this path function! 😄
I'm happy to reduce the branching threshold if a switch makes more sense here. The thresholds are primarily there to prevent regressions which doesn't apply to a simple default case.
Currently at work, so will check over this/merge this evening 👍

Published as v1.4.0 🚀
Thanks again for this awesome feature and the clean code! ✨


[ENH] Add Split step

Add Split step.
Also, update the classifier chain example to use it.

Codecov Report

Merging #9 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage    96.5%   96.56%   +0.06%
==========================================
  Files          13       13
  Lines         601      612      +11
  Branches      114      114
==========================================
+ Hits          580      591      +11
  Misses         14       14
  Partials        7        7

Impacted Files
Coverage Δ

baikal/steps/__init__.py
100% <100%> (ø)
:arrow_up:

baikal/steps/merge.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df710d1...1eae732. Read the comment docs.


Add suggestion to use env variables / runtime config for local dev in the Persisting Data with Redis Tutorial

@vdice made a good point that Spin users can use either environment variables and/or the runtime config to handle this Redis credentials when they're running their apps locally with spin up. The Persisting Data with Redis tutorial currently lives in Cloud TOC, but I think its worth adding a Note to let users know they can take advantage of these features if they're running their Spin apps locally 👍

This may have some cross over with https://github.com/fermyon/developer/issues/502

Added this PR but may have to wait for functionality to be available before publishing docs PR with dynamic config options
https://github.com/fermyon/developer/pull/503


Does it work in Vscode's WSL environment?

I've been using VSCode with the wonderful official WSL integration extension (that runs the core within WSL, the Windows Subsystem for Linux, while keeping the UI local.)
I'm getting a lot of incorrect warnings about --no-color flag not being supported so I checked #44 but the warnings are false. I do in fact have a recent version which has the flag:
> hadolint --version
Haskell Dockerfile Linter 2.3.0-no-git

When I check the Output console for the hadolint plugin, I see stuff like this:
[hadolint] hadolint: /home/alan/repos/myrepo copy/Dockerfile: openBinaryFile: does not exist (No such file or directory)

Is copy/Dockerfile supposed to be a path that the extension generates to temporarily lint?
What could the problem be? I'm on the latest extension version and latest stable VSCode release, if it helps.

@darkvertex
Would you provide all output from hadolint while having an opened Dockerfile in VS Code?
It should be something like this
[hadolint(3064) file:///Users/michael/Code/exiasr/hadolint-test] Started and initialize received
[hadolint(3064) file:///Users/michael/Code/exiasr/hadolint-test] Document is opened: file:///Users/michael/Code/exiasr/hadolint-test/dir2/Dockerfile
[hadolint(3064) file:///Users/michael/Code/exiasr/hadolint-test] Current settings: {"hadolintPath":"/usr/local/bin/hadolint","cliOptions":["--no-color"],"maxNumberOfProblems":100,"outputLevel":"warning"}
[hadolint] Running /usr/local/bin/hadolint /Users/michael/Code/exiasr/hadolint-test/dir2/Dockerfile --no-color in /Users/michael/Code/exiasr/hadolint-test

Sorry for not getting back to you but for one reason or another, I'm unable to reproduce the issue anymore in VSCode in WSL, so... yay?

To whoever have a similar problem. Even if you have it in your PATH, you have to add hadolint to the 'Hadolint Path` option in vscode,


Audio not working with IOS17 for AssetSource

Checklist

[X] I read the troubleshooting guide before raising this issue
[X] I made sure that the issue I am raising doesn't already exist

Current bug behaviour
Issue Description:
I have implemented a button in my Flutter app that is intended to trigger a sound play when pressed. However, when I press the button, I do not hear any sound, and an exception is thrown, as shown below:
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method getTemporaryDirectory on channel plugins.flutter.io/path_provider)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:308:7)

#1      getTemporaryDirectory (package:path_provider/path_provider.dart:55:24)

#2      AudioCache.fetchToMemory (package:audioplayers/src/audio_cache.dart:78:27)

#3      AudioCache.load (package:audioplayers/src/audio_cache.dart:101:31)

#4      AudioPlayer.setSourceAsset (package:audioplayers/src/audioplayer.dart:249:17)

#5      AudioPlayer.play (package:audioplayers/src/audioplayer.dart:131:5)

Expected behaviour
I expect to hear the sound when I press the play button.
Steps to reproduce

Execute flutter run on the code sample
2.Navigate to the screen with the play button.
3.Press the play button.

Code sample
`import 'package:english_words/english_words.dart';
import 'package:flutter/material.dart';
import 'package:audioplayers/audioplayers.dart';
void main() => runApp(XylophoneApp());
class XylophoneApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: SafeArea(
child: Center(
child: TextButton(
onPressed: () {
final player = AudioPlayer();
player.play(AssetSource('note1.wav'));
},
child: Text("Click Meee"),
),
),
),
),
);
}
}
`
Affected platforms
iOS
Platform details
IOS17
AudioPlayers Version
5.0.0
Build mode
debug
Audio Files/URLs/Sources
No response
Screenshots
No response
Logs

my relevant logs

Full Logs

my full logs or a link to a gist

Flutter doctor:
Output of: flutter doctor -v

Related issues / more information
No response
Working on PR
no way

Please read the other issues first. Also please use code blocks to wrap your code:


[ISSUE #6372] new scheduledExecutor clean consume queue

Make sure set the target branch to develop
What is the purpose of the change

fix #6372
Brief changelog
ew scheduledExecutor clean consume queue
Verifying this change
no
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6376 (77e0b4d) into develop (877f146) will decrease coverage by 0.03%.
The diff coverage is 63.63%.

@@              Coverage Diff              @@
##             develop    #6376      +/-   ##
=============================================
- Coverage      43.09%   43.07%   -0.03%
+ Complexity      8921     8913       -8
=============================================
  Files           1105     1105
  Lines          77922    77931       +9
  Branches       10140    10139       -1
=============================================
- Hits           33583    33571      -12
- Misses         40131    40150      +19
- Partials        4208     4210       +2

Impacted Files
Coverage Δ

...org/apache/rocketmq/store/DefaultMessageStore.java
46.75% <63.63%> (+0.14%)
:arrow_up:

... and 27 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Commitlog takes up more disk space than consumequeue, but consumequeue is slower to clean up, so extract it to avoid blocking the cleanup of commitlog files


More Human Like to avoid a Ban

I saw a comment on reddit that Niantic  should know the difference between a normal and an MITM apps . I also don't know how Niantic could find it out as there was no other information regarding that in the thread. But  i think it is important to understand and solve this before releasing the bot after upgrading to the new api
Ref Link :  https://www.reddit.com/r/pokemongodev/comments/4w1cvr/pokemongo_current_api_status/d65hrv5
I  c/p the comment from the thread below
"GMT +1, 18:30 - We would like to repeat that the API-cracking community does not support bots. We are here to crack the API, thats it. That said we would like to confirm that Niantic can detect any MITM apps, these are apps that somehow modify data sent to the server. For example an app that ensures a perfect pokeballthrow. If you used an app like that Niantic could know.
We do not know whether you'll get banned for using such an app, we merely confirmed that Niantic could (theoretically) detect it. And it is not our concern, our concern is cracking the API.?"

what?? haha. give reference, please.

It is true that the robot is not discreet
Maybe a random pokeball success rate and an altitude ?
And If we put their knees server , they will investigate.
(sorry for my english)

well, when i check the code (i dont know you check it) but there is algorithm for that like this.
reticle_size_parameter = normalized_reticle_size(self.config.catch_randomize_reticle_factor) spin_modifier_parameter = spin_modifier(self.config.catch_randomize_spin_factor)
but when I play the bot, most the time I get 210 EXP, means (100 EXP catch, 100EXP excellent, 10 EXP curve CMIIW). but sometimes I only get 110EXP (100 EXP catch and 10 EXP curve).
about Pokeball success rate, if you use greater Pokeball or razzberry, the success rate is raising. it depends on the response the server gives you know.*
*example: when there is Pokemon, and you use Greate Ball and razz berry, and then you throw the ball and get an excelent catch, you CAN still get "the Pokemon broke free".

Getting any sort of aim bonus will probably easy to flag you as a bot, considering its not possible to do so on the platforms (Niantic has confirmed it's a 'bug').

add_config(
parser,
load,
long_flag="--catch_randomize_reticle_factor",
help="Randomize factor for pokeball throwing accuracy (DEFAULT 1.0 means no randomize: always 'Excellent' throw. 0.0 randomizes between normal and 'Excellent' throw)",
type=float,
default=1.0
)
add_config(
parser,
load,
long_flag="--catch_randomize_spin_factor",
help="Randomize factor for pokeball curve throwing (DEFAULT 1.0 means no randomize: always perfect 'Super Spin' curve ball. 0.0 randomizes between normal and 'Super Spin' curve ball)",
type=float,
default=1.0

Altitude issue: #2762

We're aware of this, thanks for your input 👍


feat(highlights): Added some missed highlights primarily for markup languages

I have ported over most changes from #110 prior to the restructuring. Some were dropped because I found that they were redundant.
The rationale for this PR is I found that this theme does not have proper support for Neorg (and most other) markup files. I've selected formatting for highlight groups based on how Catppuccin and Tokyonight did it, though I've tried to keep it true to Nordic's flavour.
Here is a side by side comparison of the result:

It looks awesome!
Old:

New:

Can we make to top heading yellow instead of red?  We try to reserve red.
Other than that, this looks awesome, thanks!

It looks awesome!
Old:
New:

Nice.

And here is the old without headlines.nvim:

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

I am referring to the example that you attached.

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

I am referring to the example that you attached.

Neorg seems to link to arbitrary tags (like Macro, Delimiter, etc.) for its heading highlights. So I decided to specifically designate highlight groups for markdown headings and linked them to the corresponding Neorg highlight tags. The heading highlights for markdown and neorg will now be synchronised.
H1 to H3 are bold faced. H4 is regular faced. H5-H6 is italicised.

Also, (sorry to spam), but I've found that there are some buggy interactions with the highlights when also using folke/noice.nvim
The Heading highlights for .norg files seem to revert when you switch to command mode :. I don't know if I should debug this issue, or offload it as a noice.nvim issue?

Also, (sorry to spam), I've found that there are some buggy interactions with the highlights when also using folke/noice.nvim
The Heading highlights for .norg files seem to revert when you switch to command mode :. I don't know if I should debug this issue, or offload it as a noice.nvim issue?
When not using noice.nvim this issue doesn't occur, so I'm certain that it isn't a nordic.nvim issue. My guess is that noice.nvim seems to mess around with the markdown highlights in someway or remaps that highlight group which seems to be messing things up.
Before Command mode:

After Command mode:

Definitely seems like it is a noice issue.  You can open an issue there and link this PR.

Well, then that is not on us :) I will merge this this evening after I fixed our CI.

Thanks again!


EverlyAI integration with LlamaIndex through OpenAI library

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] New and existing unit tests pass locally with my changes

Thanks for your quick review.

I will send another PR to include the docs
I have update the util file to remove unnused imports to fix the errors.

Sure @david-huge -- will be on the lookout for the docs PR


Reintroduce engine get client version v1 with commit in manifest

Note: CHANGELOG.md may need to be updated if this is merged after the next release


Revisit use of 'call_in_bluesky_event_loop'

To instantiate ophyd_async devices and to do any necessary synchronous actions, we are using  'bluesky.run_engine.call_in_bluesky_event_loop' which will fail if there is no active RunEngine. This is an issue for testing, as we can't instantiate devices on their own, and means weird stuff like having to have test fixtures in the right order so that an RE exists before devices are created.
Acceptance Criteria

There exists some useful utility function which will use `bluesky.run_engine.call_in_bluesky_event_loop' if available, but not fail if it isn't

Related to https://github.com/DiamondLightSource/hyperion/issues/1263?

yes, when we know what the long-term solution for this will be in ophyd-async we can resolve both of these the same way


Replace rubygems key to new key with expiration date of 2024-08-22

Description
Update the rubygems key to new key which expires on 2024-08-22
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Divyaasm does the current key still work? We're in the middle of a deploy right now


Asset imports with ?url don't work in prodution

Hello,
in my vinxi project I have imported an svg using following code:
import linesFull from "~/assets/lines/linesFull.svg?url";

I need the ?url, because instead vite resolves this import with an inlined svg in a url(...) thingens. And this code works completely fine in development.
But when building using vinxi build and running the build using node .output/server/index.mjs the svg again gets inlined, what I don't want.
I think that this is a bug of vinxi, because in bare vite this works fine

Do need a repro, or when can we expect a bug fix for this. This is a quite essential feature of vite and the fact that it is not working in vinxi is very sad :(

Afaik ?url never worked for this scenario (the argument was that data: is a url too 🤷)
The suggested workaround in vite was setting assetsInlineLimit to 0. Unfortunately this doesn't work in vinxi.
Recently this vite pr was merged: feat(asset): add ?inline and ?no-inline queries to control inlining, but again this is not going to work in vinxi.
I tried to patch vinxi to make this work, but asset generation seems very broken. I'll try to understand the problem better, create a repro and open a new issue for this.

Yeah we do use query params in our systems, I would love a repro where the rules we have are a problem?

The suggested workaround in vite was setting assetsInlineLimit to 0. Unfortunately this doesn't work in vinxi.

This should work, we do probably pass that vite config through

'should', but it doesn't, I can't get any form of non-public-folder assets to correctly show 🤔
regardless of ?url or any other params (or lackthereof)

@datner Did you try with assetsInlineLimit: 0?
It certainly doesn't work in entry-server.tsx.
pnpm create solid@latest -s solid-start-assets
cd solid-start-assets

app.config.ts
import { defineConfig } from "@solidjs/start/config";

export default defineConfig({
  vite: {
    build: {
      assetsInlineLimit: 0,
    },
  },
});

mv public/favicon.ico src/

entry-server.tsx
// @refresh reload
import { createHandler, StartServer } from "@solidjs/start/server";

import Favicon from "./favicon.ico";

export default createHandler(() => (
  <StartServer
    document={({ assets, children, scripts }) => (

          <meta charset="utf-8" />
          <meta name="viewport" content="width=device-width, initial-scale=1" />
          <link rel="icon" href={Favicon} />
          {assets}

{children}

          {scripts}

    )}
  />
));

pnpm build
pnpm start

<link rel="icon" href="/_build/assets/favicon-BUcrYQBE.ico">

But /_build/assets/favicon-BUcrYQBE.ico is 404.
.output/public/
├── assets
│   ├── favicon-BUcrYQBE.ico
│   ├── index-BhCdQPVl.js.br
│   ├── index-BhCdQPVl.js.gz
│   ├── index-CWIoMshG.css
│   └── ssr-rN2XJZw8.css
├── _build
│   ├── assets
│   │   ├── _...404_-ZkgA-R4J.js
│   │   ├── about-BGQmv1RY.js
│   │   ├── client-BkW4TWd2.js
│   │   ├── client-BkW4TWd2.js.br
│   │   ├── client-BkW4TWd2.js.gz
│   │   ├── client-rN2XJZw8.css
│   │   ├── HttpStatusCode-DjTx85av.js
│   │   ├── index-CWIoMshG.css
│   │   ├── index-D5d1HS_d.js
│   │   ├── index-D5d1HS_d.js.br
│   │   ├── index-D5d1HS_d.js.gz
│   │   └── index-DqDRmUK0.js
│   └── server-functions-manifest.json
└── _server
    └── assets
        ├── app-rN2XJZw8.css
        └── index-CWIoMshG.css

@peterhirn I have not, though I'd like to avoid doing that if possible


Refactor wle

Codecov Report

Merging #425 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   83.38%   83.40%   +0.01%
==========================================
  Files         270      270
  Lines       13265    13262       -3
==========================================
  Hits        11061    11061
+ Misses       2204     2201       -3


Remove unnecessary blank lines.

Some of the blank lines in the man page cause excess blank lines to be rendered, which makes the man page a bit harder to read than necessary. This commit removes those blank lines that are not required by mandoc (but does leave some that are required!).

Thanks, I had not been aware of this issue. :+1:


How to install and use Microsoft.AspNetCore.SpaTemplates for dotnet core SDK < 2.0.0

Is there any way I can dotnet new --install Microsoft.AspNetCore.SpaTemplates::* without migrating to dotnet core 2.0? I am on MacOS 10.11 and hence can't install dotnet core SDK 2.0.
I currently have dotnet core SDK 1.0.4 installed in my setup. After I ran the above command, the commands seemed to complete successfully, but dotnet new --help does not show all SPA templates:
Templates                          Short Name      Language      Tags
-------------------------------------------------------------------------------
Console Application                console         [C#], F#      Common/Console
Class library                      classlib        [C#], F#      Common/Library
Unit Test Project                  mstest          [C#], F#      Test/MSTest
xUnit Test Project                 xunit           [C#], F#      Test/xUnit
ASP.NET Core Empty                 web             [C#]          Web/Empty
ASP.NET Core Web App               mvc             [C#], F#      Web/MVC
ASP.NET Core with Aurelia          aurelia         [C#]          Web/MVC/SPA
ASP.NET Core with Knockout.js      knockout        [C#]          Web/MVC/SPA
ASP.NET Core with Vue.js           vue             [C#]          Web/MVC/SPA
ASP.NET Core Web API               webapi          [C#]          Web/WebAPI
Solution File                      sln                           Solution

Notice that Angular, React, ReactRedux etc templates are missing.
Also, although templates like vue seem to be available, running dotnet new vue results in the following error:
Option variant - for canonical TargetFrameworkOverride was already defined for canonical skipRestore
   at Microsoft.TemplateEngine.Cli.ExtendedCommandParser.MapTemplateParamToCanonical(String variant, String canonical)
   at Microsoft.TemplateEngine.Cli.ExtendedCommandParser.SetupTemplateParameters(IParameterSet allParams, IReadOnlyDictionary`2 longNameOverrides, IReadOnlyDictionary`2 shortNameOverrides)
   at Microsoft.TemplateEngine.Cli.New3Command.ParseTemplateArgs(ITemplateInfo templateInfo)
   at Microsoft.TemplateEngine.Cli.New3Command.<EnterSingularTemplateManipulationFlowAsync>d__64.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.TemplateEngine.Cli.New3Command.<EnterTemplateManipulationFlowAsync>d__65.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.TemplateEngine.Cli.New3Command.<ExecuteAsync>d__66.MoveNext()

Is there any way I can installed and use these SPA templates in SDK 1.0.4?

Sorry, that's not supported. They rely on runtime features that are only present in the 2.0 libraries.


Delete duplicate files

Seems like mac os was having some problems with the duplicate names

seems to build on linux. good enough for me.


Why is the default.json moved to the build folder?

With the latest release I noticed that objectbox models folder and json file moved to the build artifacts folder, so I cannot check it into the VCS anymore as the entire build folder is ignored.
Does this mean we don't need to commit this model file into the VCS anymore ?
Thanks,
Dmitri

ah, yep, my project is with flavors too, this explains it.
With 0.9.15 it is back to normal location, thanks !


Suggestions delimited by empty lines in VS FSI

I don't think it's good. @forki any ideas?

I think we need to understand where errors are reported. There is already a
switch for one line option. But this looks like an issue with fsi
formatting new lines as 2 linebreaks
Am 10.03.2017 08:46 schrieb "Vasily Kirichenko"<EMAIL_ADDRESS>
[image: image]
https://cloud.githubusercontent.com/assets/873919/23786545/b9d5313c-057e-11e7-931e-803355145c31.png
I don't think it's good. @forki https://github.com/forki any ideas?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/2572, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AADgNDcluI9YisHjUrQagb6IJ-5At53oks5rkP_jgaJpZM4MZEkY
.


103

Closes #103

PR-Codex overview
This PR improves text formatting and readability in several components of the QA-Rest application.
Detailed summary

Added truncate class to h1 element in ChatHeader.tsx for better text overflow handling.
Added break-words class to div element in CategoryOption.tsx and TextInputForm.tsx for better text wrapping.
Added break-words class to h2 and div elements in QuestionView.tsx for better text wrapping.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Patch and project coverage have no change.

Comparison is base (e967378) 71.00% compared to head (115ddd4) 71.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     71.00%   71.00%
  Complexity      172      172
=========================================
  Files            78       78
  Lines          1221     1221
  Branches        104      104
=========================================
  Hits            867      867
  Misses          258      258
  Partials         96       96

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cloud Foundry uploading everything?

I have this defined in my manifest.yml:

path: .
memory: 500m
name: my-group-my-project-test
env:
FOO_BAR: test
buildpack: https://github.com/heroku/heroku-buildpack-java

When I run:
cf push my-group-my-project-test
In my root directory, where pom.xml resides, I expected the application files to be uploaded, and the dependencies to be pulled down by maven on the platform.
What is happening is that everything on local, including dependencies, is being uploaded (to the tune of 56 megs).  Am I missing the purpose of this buildpack?  I thought the point was to download and cache the dependencies on the platform to improve performance.

This buildpack is not aware of manifest.yml. That is a Cloud Foundry feature of cf push, which is independent of the buildpack. You'll have to reference the Cloud Foundry docs on manifest.yml.

Thanks for your reply, @jkutner .  I'm really driving at the buildpack behavior.  Is it true that this buildpack downloads the maven deps on the platform, or does it upload them from the client?

@MTyson it downloads the deps during the build (on the platform). It does not take them from the client. However, the cf push command (which is not related to this project) might be uploading your target/ directory based on some improper configuration.

@jkutner ah ok.  I actually did a mvn clean, so there's no /target dir after I saw your response, but I still see this:
Uploading 30.6M, 14532 files
when I do a cf push (not using manifest.yml).
Any thoughts where I should look into what is happening?

@MTyson I have no idea. I don't use Cloud Foundry. I would ask some folks at Pivotal

@jkutner Can I ask how you use the buildpack?  I am only familiar with the cloud foundry usage.

@MTyson https://devcenter.heroku.com/articles/getting-started-with-java#introduction


Weird command chat:user:set

What does it do?  --help is not very clear
chat:user:set     specify the current user for a channel

Changed to chat:user:update and modified arg flags. WIll push on the next release.


add some more temporary files to gitignore

pesky temp files. any emacs users out there?

e2e failed due to issue being fixed by #9744, sorry.

@k8s-bot ok to test

@nikhiljindal since you were the last to change hooks/ do you mind reviewing

LGTM


Fix Drop-down Facets being Cleared by other Drop-down Facets [BOOM-5484]

Workaround: Set MultipleSelectionAllowed to 'true' for drop down in 'ps_facetedsearch/src/Ps_FacetedsearchFiltersConverter.php' and  disable actual end-user Multi-Select on drop downs in 'themes/classic/templates/catalog/_partials/facet.tpl'
Fix Requires Pulls from Prestahop AND ps_facetedsearch development repos
This is my first Pull Request (suggested in [BOOM-5484]) and I was not able to combine the 2 PRs into 1 PR (if it is possible from 2 different repos).

This change is

Required Corresponding PR is: https://github.com/PrestaShop/PrestaShop/pull/9049

I created a new PR PrestaShop/ps_facetedsearch#53 with a fix for the bug.

Because of the latest refactoring we are not able to rebase / check this PR. If the problem still happened on the dev branch, please reopen this issue and we'll investigate together :wink:


Can I ignore some of drives on filesystem check?

Hi, thanks great service && ecosystems.
We have used mackerel agents for many hosts, and found that some drives always raises alerts of disk full.
$ LANG=C df -P
Filesystem              1024-blocks    Used Available Capacity Mounted on
/dev/mapper/centos-root    82929664 3794152  79135512       5% /
devtmpfs                    8125124       0   8125124       0% /dev
tmpfs                       8134412       0   8134412       0% /dev/shm
tmpfs                       8134412  164124   7970288       3% /run
tmpfs                       8134412       0   8134412       0% /sys/fs/cgroup
/dev/sr0                        422     422         0     100% /mnt/config-drive
/dev/vda1                    508588  165184    343404      33% /boot

/dev/sr0 is a CD-ROM drive, so it seems to be unreasonable to warn us of disk usage.
(Especially, OpenStack distributes its metadata to instances via CD-ROM drive according to its construction settings, then in some cases, there always exists /dev/sr0 and uses 100% drive.)
So we may feel happy if some of drives are able to be ignored by its filesystem type(e.g. ign iso9660), or by its name.
Thanks!
（もし詳細がよくわからなければ、twitter等で日本語で説明させていただきます...）

なるほど…

https://github.com/mackerelio/mackerel-agent/pull/186 will fix this