fix: bump otelsql to v0.11.1

The changes in the fork are merged and released in v0.11.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
62 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.07%) to 87.296%

Files with Coverage Reduction
New Missed Lines
%

pkg/worker/worker.go
3
95.61%

internal/store/postgres/postgres.go
16
62.79%

internal/workermanager/worker_manager.go
19
70.59%

pkg/worker/pgq/pgq_processor.go
24
80.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
6164

Relevant Lines:
7061

💛  - Coveralls


imagebuilder: create an image for k8s 1.4

Highlights:

4.4 kernel
More inodes

Merging as we're using this to build the AWS AMI for 1.4


InsertWaypoint

Added an insert-waypoint command for the config/management crate.
insert-waypoint --local BACKEND [--remote BACKEND] [--waypoint WAYPOINT_VALUE]
where one any only one of --remote and --waypoint must be provided.
Issue: #4378
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Modified the smoke_test in the management crate to test insert_waypoint.

Addressed the review comments! Please let me know if it looks okay. Thanks

Great! I just fixed them. Please also let me know which other task I should pick up next, thank you :-)

@bors-libra r+

:pushpin: Commit b6ce5f5 has been approved by davidiw

:hourglass: Testing commit b6ce5f582967aa435d430402c67149534dba25d1 with merge da0afa249fe4339a78e5b640f57dc3464514a805...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing da0afa249fe4339a78e5b640f57dc3464514a805 to master...


test for known example

may you please verify  how it works for
example from
http://srome.github.io/Leveraging-Factorization-Machines-for-Sparse-Data-and-Supervised-Visualization/
data size is
X_train.shape
(7580, 1048576)
y_train.shape
(7580,)
I send you customized code from this link
#S_May2_hashing_FM_sparse.py
#S_apr25_FM_sparse
#http://srome.github.io/Leveraging-Factorization-Machines-for-Sparse-Data-and-Supervised-Visualization/
import pickle
import pandas as pd
from sklearn.feature_extraction import FeatureHasher
#original from PyFactorizationMachines.src.pyfm import FactorizationMachineClassifier
from pyfms import Classifier
from sklearn.model_selection import train_test_split
if 1:
from sklearn.datasets import fetch_20newsgroups
twenty_train = fetch_20newsgroups(subset='train',
shuffle=True,
random_state=42)
filehandler = open(b"twenty_data.pkl","wb")
pickle.dump(twenty_train,filehandler)

else:
file_name = open("twenty_data.pkl",'rb')
twenty_train= pickle.load(file_name)

twenty_train.target_names
def define_label(x, target_names):
name = target_names[x]
return 1 if 'comp' in name else 0
target = pd.Series(twenty_train.target).apply(lambda x : define_label(x,twenty_train.target_names))
target.mean() # Prevalence of the label
def clean_text(text):
# Basic cleaning
text=text.replace('\n','').replace('\t','').replace('<','').replace('>','').replace('|','')
return [x for x in text.split(' ') if len(x) > 3]
X = [clean_text(x) for x in twenty_train.data]
Hash away!
fh = FeatureHasher(input_type='string',non_negative=True)
X_t = fh.transform(X)
Bin the inputs so that the "interaction" terms are more interpretable
X_bin = X_t.copy()
X_bin[X_bin >= 1] = 1
f = Classifier(X_t.shape[1] , k=2, X_format="csr")
X_train, X_test, y_train, y_test = train_test_split(X_bin, target, test_size=0.33, random_state=42)
f.fit(X_train, y_train,  verbosity=50, nb_epoch=200)
q=4

is initial program output correct?
it takes for ever to calculate, interesting how fast is it on your computer ?
Microsoft Windows [Version 10.0.16299.371]
(c) 2017 Microsoft Corporation. All rights reserved.
E:\PyFactorizationMachines_May2\PyFactorizationMachines>python S_May2_hashing_FM_sparse.py
WARNING (theano.configdefaults): g++ not available, if using conda: conda install m2w64-toolchain
C:\Users\sndr\Anaconda3\lib\site-packages\theano\configdefaults.py:560: UserWarning: DeprecationWarning: there is no c++ compiler.This is deprecated and with Theano 0.11 a c++ compiler will be mandatory
warnings.warn("DeprecationWarning: there is no c++ compiler."
WARNING (theano.configdefaults): g++ not detected ! Theano will be unable to execute optimized C-implementations (for both CPU and GPU) and will default to Python implementations. Performance will be severely degraded. To remove this warning, set Theano flags cxx to an empty string.
WARNING (theano.tensor.blas): Using NumPy C-API based implementation for BLAS functions.
C:\Users\sndr\Anaconda3\lib\site-packages\sklearn\feature_extraction\hashing.py:94: DeprecationWarning: the option non_negative=True has been deprecated in 0.19 and will be removed in version 0.21.
" in version 0.21.", DeprecationWarning)
C:\Users\sndr\Anaconda3\lib\site-packages\pandas\core\series.py:696: FutureWarning:
Passing list-likes to .loc or [] with any missing label will raise
KeyError in the future, you can use .reindex() as an alternative.
See the documentation here:
http://pandas.pydata.org/pandas-docs/stable/indexing.html#deprecate-loc-reindex-listlike
return self.loc[key]

@Sandy4321, if you are encountering and issue, please be sure to provide the simplest possible example that reproduces the issue, so I can figure out what's wrong. The issue posted above is too large for me to be able to understand what the problem is, or debug.
Regarding the speed, please see my comment here, regarding the installation of m2w64-toolchain.


build: spell parameter -fuse-ld= properly for Windows

We need to pass -fuse-ld= gold.exe on Windows when targeting
Android.  Given that we do not have a host toolchain for Linux on
Windows currently, do this unconditionally.  This is required for
cross-compiling from Windows to android.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test


Fix double entry in AUTHORS file

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM

Sometimes less really is more :crying_cat_face:


remove exception occurrence

it looks like catching this specific exception here is not relevant anymore?

is the license/cla check always this slow? it just seems bugged 🤷♂

for me this is not slow, it just does not work 😢 I will use my superpower and merge


Make sure MaybeUninit is part of generated code for Rust functions returning Result

The indirect_return functions checks if a function signature either throws or needs indirect ABI and decides if ::rust::MaybeUninit should be added to the generated C++ code. However the declaration for the ::rust::MaybeUninit was only generated if the function needed indirect ABI so I ended up with functions that returned a Result generated code that used ::rust::MaybeUninit but didn't have the declaration. This PR should make sure that the ::rust::MaybeUninit declaration is part of the generated code if a function returns a Result.

Published in 0.4.5.


CommonFixture.MatmulMultiCoreMultiDRAM fails on device 1 on N300

Remove the break in tests/tt_metal/tt_metal/unit_tests_common/compute/matmul/test_matmul_multi_core_X_dram.cpp:505
./build/test/tt_metal/unit_tests_fast_dispatch --gtest_filter=CommonFixture.MatmulMultiCoreMultiDRAM
Result is a hang: https://github.com/tenstorrent/tt-metal/actions/runs/8854442333/job/24317672563

CommonFixture.MatmulMultiTile also appears to hang in a similar manner

merged, and test re-enabled


⚠ SceneTime has degraded performance

In 9608d91, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 5322 ms

Resolved: SceneTime performance has improved in fd2e89a after 7 minutes.


Upload files to Github repos

With the latest update you can now edit files from Github repositories. You should then be able to upload these edited files again. This probably works best via API.

I pulled the latest revisions. Currently my project tab doesn't work at all. Can you clarify for me what it's supposed to show?

You should be able to register in the "File" menu when you go to the last button. That means linking your Github account.
If you then restart the app, your projects should also appear.
In the registration process, you will be forwarded to Github. If you appear any error here, open the URL with the corresponding port in the incognito tab.

Ok, I'll try to work on this. I'm not able to connect to my github repo at all, just get a 500 internal server error.

Yes, I sometimes see the internal server error too. But then try to open the link (localhost:5000) in the Icognitotab - the error no longer appears (for me).

See on #24

Ok, I'll try to work on this. I'm not able to connect to my github repo at all, just get a 500 internal server error.

@Telephos I solved the issue.
I changed the code directly without PR. The new code is:
    def start_webserver(self):
        def run_flask_app():
            app.run(host="<IP_ADDRESS>", port=5000)

        flask_thread = threading.Thread(target=run_flask_app)
        flask_thread.start()

        url = "http://<IP_ADDRESS>:5000"


Added fontOverrides

Fixes #97
Note: I wasn't sure how you'd prefer unit tests for this to look, so I didn't add them in the first commit. Could you please give me a little guidance here? 😊

Nice, I like the idea!
Small nitpick: I'd rather have it structured like
font: {
    weight: <···>,
    style: <···>,
    size: <···>,
    family: <···>
}

while keeping in the description that those can be used to override the computed font.
What do you think?

Regarding the unit tests:
You can add them to the in a client environment section and verify your changes with
const container = document.createElement('div');
const component = render(<Truncate font={<···>} />, container);

// Some assertions on component.cavasContext.font

Sounds great, thanks for the suggestions!
My computer is struggling with GTK for the canvas package so you'll have to forgive some force pushes after this comment as I use Travis to run the unit tests. 😉

So if the tests are updated, will this get merged?

Ah, I don't use this library anymore. Closing to clear my old PRs. You're welcome to make this change separately!


Update Clip Geometry Sample

Description
PR to add a reset button to the existing Clip Geometry sample. https://devtopia.esri.com/runtime/kotlin/issues/1625
What To Review
MainActivity.kt and the activity_main.xml file
How to Test
Run the sample using the branch.

@shubham7109 Thanks for the comments, based on our call, the reset function was updated to just clear the clipped area Graphics overlay and make the coloradoGraphic visible. Also, the graphicsOverlay and envelopesOverlay are now defined as lazy in global scope

Thanks for the review @fpearson1111 and @shubham7109 . Merging into v.next


Turkish keyboard support

Unshaky 0.5.4 - Macbook Pro 2016 touchbar
I can't assign some turkish keys. for example (Ü, Ö Ç). Will it be compatible with all keyboard types in the future ?
here is my keyboard

I guess I just add the layout one by one when someone request it.


URLRewrite filter not working with websockets

Hi. The URLRewrite filter on the HTTPRoute, which works fine with regular HTTP requests, seems not to be working with websockets respectively fails when the websocket protocol upgrade is performed. I am not sure if this is a problem with envoy itself or with envoy gateway. But what I did is using a simple HTTP/WS echo server and the following HTTPRoute:
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: websocket-echo
  namespace: default
spec:
  hostnames:
  - ws.example.com
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: envoy-gateway-https
    namespace: default
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: websocket-echo
      port: 8080
      weight: 1
    filters:
    - type: URLRewrite
      urlRewrite:
        path:
          replaceFullPath: /
          type: ReplaceFullPath
    matches:
    - path:
        type: Exact
        value: /echo

While regular HTTP requests are echoed back just fine, above config results in error: Unexpected server response: 403 on the client side when trying to establish a websocket connection to https://ws.example.com/echo with e.g. wscat.
On the envoy proxy you can see the following log:
{
  "start_time": "2024-03-20T12:26:30.465Z",
  "method": "GET",
  "x-envoy-origin-path": "/echo",
  "protocol": "HTTP/1.1",
  "response_code": "403",
  "response_flags": "-",
  "response_code_details": "upgrade_failed",
  "connection_termination_details": "-",
  "upstream_transport_failure_reason": "-",
  "bytes_received": "0",
  "bytes_sent": "0",
  "duration": "0",
  "x-envoy-upstream-service-time": "-",
  "x-forwarded-for": "<redacted>",
  "user-agent": "-",
  "x-request-id": "e6e15a68-c012-482f-9fd9-f71b873e9e68",
  ":authority": "ws.example.com",
  "upstream_host": "-",
  "upstream_cluster": "httproute/default/websocket-echo/rule/0",
  "upstream_local_address": "-",
  "downstream_local_address": "<redacted>",
  "downstream_remote_address": "<redacted>",
  "requested_server_name": "-",
  "route_name": "httproute/default/websocket-echo/rule/0/match/0/ws_example_com"
}

If I remove the filter from the HTTPRoute websocket connections can be established without any problems.

upgrade configs are applied only to default case in https://github.com/envoyproxy/gateway/blob/main/internal/xds/translator/route.go#L77-L81
not sure about these case https://github.com/envoyproxy/gateway/blob/main/internal/xds/translator/route.go#L52-L61 should it be applied or not.

thanks for raising this @jaynis
looks like a bug, we only add the websocket config when DirectResponse or Redirect or Rewrite is not set.
we need to also support websocket config when Rewrite is set
https://github.com/envoyproxy/gateway/blob/7f5cbe84a2332a9f6b194ff2c276a320354a55f7/internal/xds/translator/route.go#L56


Updating credit multipliers for MacOS under Velocity

Description
Adds missing multiplier for elite-xl MacOS machines (available over gen2 infrastructure)
Types of changes

[ ] House cleaning (change at project level, like tooling revamp, refactors, etc)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (non-breaking change which improves existing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (something that would cause existing functionality to not work as expected)
[ ] Documentation (self-explained)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@17d1263). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage        ?   86.72%
=======================================
  Files           ?       11
  Lines           ?      422
  Branches        ?        0
=======================================
  Hits            ?      366
  Misses          ?       56
  Partials        ?        0

Impacted Files
Coverage Δ

bitrise_reports/metrics.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d1263...75297e4. Read the comment docs.


Remove Python 2 from classifiers list in setup.py

Remove Python 2 from classifiers list in setup.py:
        'Programming Language :: Python :: 2',
        'Programming Language :: Python :: 2.7',

I'll take this one...


Upgrade: install intermediate pattern when needed

Why is this PR needed?
Do not install the intermediate pattern unless the upgrade of
Kubernetes is a major or minor one.

We seem to be running into LB pool quota:
1 error occurred:\n\t* openstack_lb_pool_v2.gangway_pool: Error creating pool: Expected HTTP response code [] when accessing [POST https://engcloud.prv.suse.net:9696/v2.0/lbaas/pools], but got 409 instead\n{"NeutronError": {"message": "Quota exceeded for resources: [\'pool\'].", "type": "OverQuota", "detail": ""}}\n

I am able to manually create loadbalancers in ECP though, so I'm not sure where this error is originating from.


Move create_subgraph_features to build_subgraph_runner

@incrypto32 Glad to see this wasn't too much rework. In terms of tests, you're right, there isn't a good way to unit test the subgraph runner. We have to resort to the integration tests. This might not warrant its own integration test, but perhaps you could add a check to an existing test that the features were written correctly.


feat(templates): add new asset template

Link to the Jira issue
IM-974 https://jira.commercetools.com/browse/IM-974
Add asset template

Hey @markkovari-commercetools you're correct! It looks like the prettier missed the index.html. I'll try to update the settings there!

@markkovari-commercetools @harm-meijer, I changed the configuration to a simpler one. I don't know if you want to review it again, please. Thanks


CLI to add new library

A CLI interface to automate library addition

Created as a private repo. https://github.com/theapache64/stackzy-dashboard-cli/


mqtt2prometheus: init at 0.1.7, nixos/mqtt2prometheus: init

Description of changes
https://github.com/hikhvar/mqtt2prometheus
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 284258 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

1 package built:

mqtt2prometheus

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2096

I'm dropping this PR. I replaced my usage of mqtt2prometheus with Vector (which I already use for other purposes) with a VRL transform stage processing the log entries of my Zigbee2MQTT instance.


Fix ASTNode#to_s to wrap with parenthesis as needed

Fixed #5219
Whether current ASTNode#to_s wrap Expressions with parenthesis (or begin/end) is depending on the parent of this. And default wrapping policy is no wrapping. It causes some problems, for example #5219 or see this:
macro foo(x)
  {{ x }}
  {% debug() %}
end

foo(if (true
        false)
      p true
    else
      p false
    end)

Expected output is false of course but this program prints true currently, because {% debug() %} output is:
if true
  false

  p(true)
else
  p(false)
end

So parenthesis is disappeared and program is broken.
I fixed ASTNode#to_s to wrap parenthesis in every time except this Expressions wants indent.

Thank you, but no more hacks please :-)
See #5226


Fix bad validatingwebhookconfiguration gen

Please provide a description of this PR:
Fixed #38599

The issue describes a very isolated case of Gateway only in config cluster, but doesn't this always use the MWH url in the VWH which is always wrong (currently)?

This should be tested in the istiodremote integration tests. Even though it's a bad webhook, the other installed one (which, unlike injection webhooks, is not deactivated) works. I think there may be more issues with this code, but this PR is just trying to just get it sortof correct but also disable generating it in the config cluster for now.

@howardjohn Actually, I see that we use injectionPath, not injectionURL, for the external control plane integration test, so this does not get tested. I noticed it when setting up an external control plane manually using the documented procedure, which does use the injectionURL (for a remote public DNS gateway). The doc test doesn't test validation, so it might not be working thanks to this bug?

@frankbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
a5f3ea0073d4c1b1cefc53bb4d2cef73b104d563
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

/cherry-pick release-1.14

@ericvn: #38600 failed to apply on top of branch "release-1.14":
Applying: Fix bad validatingwebhookconfiguration gen
Applying: unit test
Using index info to reconstruct a base tree...
M	istioctl/pkg/tag/generate.go
M	istioctl/pkg/tag/generate_test.go
Falling back to patching base and 3-way merge...
Auto-merging istioctl/pkg/tag/generate_test.go
CONFLICT (content): Merge conflict in istioctl/pkg/tag/generate_test.go
Auto-merging istioctl/pkg/tag/generate.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 unit test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn: new issue created for failed cherrypick: #38974

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Error: ContainerRegistryClientOptions.audience must be set to initialize ContainerRegistryClient

Not sure if this was just a problem with my local build of the extension or if it's a real problem. Got this error when deploying from an ACR.

Still getting it with the latest build from main I got from @fiveisprime.

Not getting much more info in the output:
3:20:40 PM: Error: ContainerRegistryClientOptions.audience must be set to initialize ContainerRegistryClient.


Profile UI redesign

Some notes here after [1]

Full name seems to be misaligned with the rest of the fields.

Favicon in settings page is not working (seems like a regression, master works fine for me)
Skills beautification seems broken as well

Email section needs some love
Issue in persona button rendering
Too much space left between primary and secondary emails
Mixed bold and plain titles

Except of these there are also some leftovers from [1] eg.

Location permissions UI
Contribution story

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1129848#c3

Also can you split the top commit to more atomic/smaller ones. There are massive changes and its not easily reviewed and maintained.

I am getting this error on new profile creation:
'location_privacy_field' is undefined
I cannot find a reference in your branch or master. Is that something you forgot to commit?

We also need to include this field in new user registration

Default delete email button looks like this.

We also need to fix the alignment in case we don't refactor the permission level UI.

After form submission (eg. in case of an error) privacy toggles are not getting the value that the hidden (real) input element has.

On mobile view location search field overflows map.

If you haven't fixed these yet please cherry-pick this [1]
These are minor fixes to make the branch work when I started working for the backend.
[1] https://github.com/johngian/mozillians/commit/c382cfd7d9b409270dda8ba88d8f4dfa86f3970c

I think Skills section should be moved away from the profile and go together with Groups and rename the menu to something like Groups & Skills. It's a better logical fit there and skills are not basic information.

Languages can also go there, since that's a skill as well.

The Profile section should have only one update button. All the fields there should be posted into one form and not in multiple ones

The same is true for all the sections. Since we are breaking the profile into sections there is no need to post multiple times per section

PR updated
Things fixed:

Break down to more commits
Fix favicon bug due to location.hash
Fix spacing, bold mixup on email settings
Wrong reference to non-existant privacy field
Add Privacy Opt-in for new users
Fix delete buttons opacity
Fix overflow on mobile location settings
Fix alignment on location fields

Things not fixed yet:

Group privacy settings on Location
Add placeholder to contribution story
Both of these can come later on a separate commit

Things that need some more work:

Mobile view needs some love with spacing and alignments
Make sure the 'Delete Profile' button is not clickable untill user ticks the checkbox
Privacy button not taking stored value on form submission (I need the backend to re-produce this)

Misaligned fields still exist (username is next to label, full name is below)

Functional areas in mobile view is broken

The same happens for groups

FYI I pushed here the rebased branch which combines both frontend and backend in case you needed it:
https://github.com/johngian/mozillians/commits/1191850-with-ui

This PR also breaks the groups UI:

City/region/country save button and name are misaligned in mobile view.

In mobile view we are providing a button to show all settings but while browsing I would expect to also have a button to get you back to the ``restricted`

We used to have a template to include for the photo form [1]. Please update it with the new UI and use it in both registration/basic information forms.
[1] mozillians/templates/phonebook/includes/photo_form.html

This [1] template looks like its not used. Please double check and remove it if orphaned.
mozillians/templates/phonebook/includes/photo.html

When I open a link directly in mobile view (not #profile) like:
http://<IP_ADDRESS>:8000/en-US/user/edit/#location
It shows this first:

And when I click "show all" I get an empty page:

We used to have a template to include for the photo form [1]. Please update it with the new UI and use it in both registration/basic information forms.
[1] mozillians/templates/phonebook/includes/photo_form.html
This [1] template looks like its not used. Please double check and remove it if orphaned.
[1] mozillians/templates/phonebook/includes/photo.html

It seems that these are not used on the current code either. Can you point me to the code that includes these two templates?

We are not including them at the moment but we should since photo form is rendered twice (both in registration and basic information form). In the previous comment I suggest to move the photo_form functionality to a different template and include it twice.
About photo.html we are not using so we can remove it.

@johngian PR updated

Fix Groups and Functional Areas grid
Fix Profile misalignment on Full Name
Fix 'Delete Profile' button to be inactive until checkbox is checked
I moved profile photo to another template
I made some code changes on privacy toggles based on your comments

I am not sure if this is commented somewhere, but when a new user registers a new profile, the privacy button needs to be set to a default value (I would go with Mozillians).

Closing this one after #1243


[Bug]: Entering or exiting split pane mode with query selected - query's title gets selected for renaming

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I open up or close out the split pane view with a query selected, the query's title gets selected for edit/renaming
Steps To Reproduce
https://github.com/appsmithorg/appsmith/assets/101863839/b1c7487f-045d-4522-854e-4217a2865cbc
Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Cloud

internal tracking: https://www.notion.so/appsmith/Test-party-New-IDE-457ce3d37cbc44c08f4a8b877de2f984?p=ed060833054f4e54890c1c8cc46640db&pm=s


Tyleryasaka/issue 336

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[x] Update any relevant READMEs and docs
[x] Submit to the develop branch instead of master

Description:

Reorganizes migrations
Removes obsolete contracts, resources, and tests

Hooray for deleting code 😳


e2e: v8.1 upgrade test

Description

closes: #5635

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6174822) 81.16% compared to head (c1c8955) 81.16%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5652   +/-   ##
=======================================
  Coverage   81.16%   81.16%
=======================================
  Files         198      199    +1
  Lines       15267    15278   +11
=======================================
+ Hits        12392    12401    +9
- Misses       2407     2408    +1
- Partials      468      469    +1

see 2 files with indirect coverage changes


Send (Switch Name in addition to switch DPID) and (Table name in addition to Table ID) to CouchDB

Today, when JSON object is received by CouchDB from Gauge, we get only Switch DPID.  Can we get the Switch name too?
Also, Faucet creates OF pipelines and pushes them into the switch.  When tables and flow info is sent to CouchDB, the JSON object contains Table numbers but not a friendly name.  Not having this means one has to look at the pipeline to derive the name.  Hence, request table name as programmed by the pipeline (VLAN_ACL, PORT_ACL, FLOOD, etc) be sent with TableID to CouchDB.
Another option here is that the table id-name mapping can be sent separately and stored in a different table which is refreshed if pipeline is changed.
In summary, both of the above features require name mapping for switch and table id be available in the Couch database so that applications have easy access to them for presentation to users.

The CouchDB connector doesn't have tests, but, we now have Prometheus support, and most applications will probably want to scrape Prometheus also to get FAUCET internal state data.


disregard, open by mistake

[Enter feedback here]
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a20453e6-5273-2119-69f7-85b5108a8f7d
Version Independent ID: 4ac93e53-6969-4c8d-5b5c-0db47a8976ce
Content: Setting up Pacemaker on SLES in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/workloads/sap/high-availability-guide-suse-pacemaker.md
Service: virtual-machines-sap
GitHub Login: @rdeltcheva
Microsoft Alias: radeltch

jocarv-fte,  Thanks for leveraging Azure docs feedback channel. No worries, much appreciate the follow-up and update on this.
-Just as a side note, this channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.

jocarv-fte, Thanks for leveraging Azure docs feedback channel. No worries, much appreciate the follow-up and update on this.
-Just as a side note, this channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.

Hi AjayKumer.. Yeah, I know. I usually report feeback here instead of trying to ping individual document authors. This time, I just opened an issue on the wrong document :)


Round running time to two decimal places

Running time will be rounded to two decimal places. Instead of getting Running time: 0.340104997158051, now we'll have Running time: 0.34 seconds.
It's cleaner. And better looking. 💄

Current coverage is 92.40%

Merging #33 into master will not affect coverage as of d74cd49

@@            master    #33   diff @@
=====================================
  Files           60     60
  Stmts         1606   1607     +1
  Branches         0      0
  Methods          0      0
=====================================
+ Hit           1484   1485     +1
  Partial          0      0
  Missed         122    122

Review entire Coverage Diff as of d74cd49

Powered by Codecov. Updated on successful CI builds.

Looks fine! Thanks! 🍻


Deadlock involving multiprocessing/pandas read_excel

I'm experiencing an apparent deadlock when attempting to read Excel files with Pandas, but only after attempting to load a CSV file in the main process.  I've reduced my code down to the following:
import multiprocessing
import pandas as pd

def read_file(path):
    print('Before read_excel')
    df = pd.read_excel(path)
    print('After read excel')
    return df

try:
    df = pd.read_csv('gs://<invalid_path_to_csv_file>')
except FileNotFoundError:
    pass
file = 'gs://<valid_path_to_xlsx_file>'
files = [file]
with multiprocessing.Pool(1) as pool:
    dfs = pool.map(read_file, files)

The subprocess will hang in the pd.read_excel() call.  If I attach to it with GDB, it seems to be stuck trying to acquire a lock in fsspec:
#20 0x000000000054b302 in PyEval_EvalFrameEx (throwflag=0,
    f=Frame 0x1bd4c80, for file <path_removed>/env/lib/python3.7/site-packages/fsspec/asyn.py, line 68, in sync (loop=<_UnixSelectorEventLoop(_timer_cancelled_count=0, _closed=False, _stopping=False, _ready=<collections.deque at remote 0x7f01fb966360>, _scheduled=[<TimerHandle at remote 0x7f01fa8b3150>], _default_executor=<ThreadPoolExecutor(_max_workers=20, _work_queue=<_queue.SimpleQueue at remote 0x7f01fb135fb0>, _threads={<Thread(_target=<function at remote 0x7f01fb1534d0>, _name='ThreadPoolExecutor-0_0', _args=(<weakref at remote 0x7f01fb152650>, <_queue.SimpleQueue at remote 0x7f01fb135fb0>, None, ()), _kwargs={}, _daemonic=True, _ident=139646475032320, _tstate_lock=None, _started=<Event(_cond=<Condition(_lock=<_thread.lock at remote 0x7f01fd11d300>, acquire=<built-in method acquire of _thread.lock object at remote 0x7f01fd11d300>, release=<built-in method release of _thread.lock object at remote 0x7f01fd11d300>, _waiters=<collections.deque at remote 0x7f01fb966520>) at remote 0x7f01f...(truncated)) at ../Python/ceval.c:547

My requirements:
aiohttp==3.7.3
async-timeout==3.0.1
attrs==20.3.0
cachetools==4.2.0
certifi==2020.12.5
cffi==1.14.4
chardet==3.0.4
decorator==4.4.2
et-xmlfile==1.0.1
fsspec==0.8.5
gcsfs==0.7.1
google-api-core==1.24.1
google-auth==1.24.0
google-auth-oauthlib==0.4.2
google-cloud-core==1.5.0
google-cloud-storage==1.35.0
google-crc32c==1.1.0
google-resumable-media==1.2.0
googleapis-common-protos==1.52.0
idna==2.10
jdcal==1.4.1
multidict==5.1.0
numpy==1.19.4
oauthlib==3.1.0
openpyxl==3.0.5
pandas==1.2.0
protobuf==3.14.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.20
python-dateutil==2.8.1
pytz==2020.5
requests==2.25.1
requests-oauthlib==1.3.0
rsa==4.6
six==1.15.0
typing-extensions==<IP_ADDRESS>
urllib3==1.26.2
yarl==1.6.3

Interestingly, doing pd.read_csv() in the subprocess doesn't seem to cause a problem, so it seems that something that read_excel() is doing is needed.  Seeking perhaps?

Interestingly, doing pd.read_csv() in the subprocess doesn't seem to cause a problem, so it seems that something that read_excel() is doing is needed.  Seeking perhaps?

Threads and asyncio sockets are not generally fork-safe. Would you mind trying with the multiprocessing context set to spawn or forkserver?
Alternatively, you might try:

invoking tasks in the pool which set up gcsfs before you have created an instance in the main process
clearing the cache of gcsfs instances with gcsfsGCSFileSystem.clear_instance_cache() in the read_file function before calling pandas.

Threads and asyncio sockets are not generally fork-safe. Would you mind trying with the multiprocessing context set to spawn or forkserver?
Alternatively, you might try:

invoking tasks in the pool which set up gcsfs before you have created an instance in the main process
clearing the cache of gcsfs instances with gcsfsGCSFileSystem.clear_instance_cache() in the read_file function before calling pandas.

Yes, I didn't think about the thread/fork interaction.  Thanks for that hint.  Switching the multiprocessing start_method to forkserver resolved the issue.  Thanks.

Yes, I didn't think about the thread/fork interaction.  Thanks for that hint.  Switching the multiprocessing start_method to forkserver resolved the issue.  Thanks.


Sorting Taxonomies

The query created when attempting sortable admin columns using automatic taxonomies doesn't work:
array (
    'order' => 'asc',
    'orderby' => 'meta_value',
    'posts_per_page' => 200,
    'post_type' => 'sm-item',
    'meta_key' => 'sm-item-section',
)

Wasn't clear from the docs that only meta values were supported.
Might be a workable solution here:
http://wordpress.stackexchange.com/questions/14306/using-wp-query-is-it-possible-to-orderby-taxonomy

Hey man...  Attempted to replace 'orderby' => 'meta_value' by 'orderby'    => 'meta_value_num'.

The class is generating the wrong query, it should be more along the lines of:
array(
    'order' => 'asc'
    'orderby' => 'sm-item-section'
    'post_type' => 'sm-item'
    'posts_per_page' => 200
)

Where orderby is the taxonomy name. I'll fix that in the class.
However, this wouldn't make taxonomies sortable on its own. To get it working you would need a post_clauses filter too.
After reading of the stackoverflow and in particular this answer I'm skeptical about adding the posts_clauses filter to the class.
Taxonomies aren't really meant to be sorted, they are used for grouping, not ordering. I can see that it might be possible and useful in some cases, but not all.
I'll need to look into it more.


Add unzip API

Add unzip API

I don't think this would be functionality that gets included in nx.js core.
Try searching the npm registry for a module that does this already, such as: https://www.npmjs.com/package/jszip


add HOME and fix link

Description

Changes proposed in this pull request:

add HOME to sidebar
fix link to blog post

Related Issues and Documents

Closes:
Related issues:
https://github.com/kyma-project/telemetry-manager/issues/322

Arrgh no, the link in the resource file should have been adjusted in the .go file and than populated with make manifests, right?

/retest

/retest

/retest

/retest

/retest

/retest-required


Automated Package Upgrade

:tada: This PR is included in version 28.4.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: need to wait until snapshot is ready before taking backup in system backup

ref: https://github.com/longhorn/longhorn/issues/8601
In system backup e2e tests
Some tests failed because the backup creation failed due to snapshot missing.
We should wait until snapshot is ready before create backup, cause backup creation is one time shot.
ref: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6979/console
in the support bundle, the backup creation failed because of snapshot missing
  spec:
    labels:
      longhorn.io/volume-access-mode: rwo
    snapshotName: system-backup-49d05cf04e624d85
    syncRequestedAt: null
  status:
    backupCreatedAt: "null"
    compressionMethod: "null"
    error: could not find snapshot 'system-backup-49d05cf04e624d85' to backup, engine
      'longhorn-testvol-jway75-e-0'
    labels: "null"

Hi @c3y1huang

@c3y1huang
May I know why "Having a blocker in the system backup controller" is not a good idea?
Cause we also wait for Volume to be backed up with a timer as well
We even return the error if the backup timeout

Oh I see your point we check if snapshot exists before invoking engineClientProxy.SnapshotBackup if snapshot doesn't exist, we then wait for the next round.
I think we can do it

Oh I see your point we check if snapshot exists before invoking engineClientProxy.SnapshotBackup if snapshot doesn't exist, we then wait for the next round.
I think we can do it

Exactly, I think it would make more sense for the backup controller to handle the missing snapshot rather than leaving the responsibility to the system backup controller.

@c3y1huang I am just not sure, if we have any test or code logic that assumes the backup should be failed in a period of time if snapshot is missing.
Because in this case, the backup CR will be hanging there without any status forever if snapshot is missing

@c3y1huang I am just not sure, if we have any test or code logic that assumes the backup should be failed in a period of time if snapshot is missing.
Because in this case, the backup CR will be hanging there without any status forever if snapshot is missing

Can we introduce a new state for the backup? Perhaps Pending?

It already have all the states from New->Pending->...->Completed
But those are syned from the backup state from the engine.
Maybe we can just assign Pending to the CR before it starts,
it will then be overridden by state from engine once it starts.
But it will be Pending forever, if the snapshot is never created.

It already have all the states from New->Pending->...->Completed But those are syned from the backup state from the engine.
Maybe we can just assign Pending to the CR before it starts, it will then be overridden by state from engine once it starts.
But it will be Pending forever, if the snapshot is never created.

It already have all the states from New->Pending->...->Completed But those are syned from the backup state from the engine.
Maybe we can just assign Pending to the CR before it starts, it will then be overridden by state from engine once it starts.
But it will be Pending forever, if the snapshot is never created.

I see. Any indication on the Snapshot CR if the actual snapshot never gets created?


error: expected identifier EV_ERROR ev.h

I've opened the issue at https://github.com/redis/hiredis/issues/602 but it might be related to redox.

This is a problem that occurs only on mac OS. We might want to include the workaround that was provided to me at https://github.com/redis/hiredis/issues/602. I can submit a PR.


Please replace  https://claim-tax-benefits.azurewebsites.net/personal/name

https://claim-tax-benefits.azurewebsites.net/personal/name
Please replace page with:
Heading: Check your name is correct
CRA doesn't need your middle name.
Full name:
Gabrielle Roy
Is this your name?
Yes
No
Continue Cancel

Closing as PR 181 has been merged


[EventRequest] OnBeforePostBudgetAsset on Codeunit 5632 "FA Jnl.-Post Line"

Hello, please consider adding the following event to Codeunit 5632 "FA Jnl.-Post Line"
[IntegrationEvent(false, false)]
local procedure OnBeforePostBudgetAsset(var FALedgEntry: Record "FA Ledger Entry"; BudgetNo: Code[20]; var IsHandled: Boolean)
begin
end;

and raise it accordingly:
    local procedure PostBudgetAsset()
    var
        FA2: Record "Fixed Asset";
        FAPostingType2: Enum "FA Ledger Entry FA Posting Type";
        IsHandled: Boolean;
    begin
        OnBeforePostBudgetAsset(FALedgEntry,BudgetNo,IsHandled);
        if IsHandled then
            exit;

        FA2.Get(BudgetNo);
        FA2.TestField(Blocked, false);
        FA2.TestField(Inactive, false);
        if FAPostingType = FAPostingType::Maintenance then begin
        ...
        ...

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


No Cursor and hangs after closing vim

The product looks great. Trying for first time, i tried to work with vim. The vim works great, except when I close it, the screen gets frozen! and i have to quit the program.
Let me know if you need more info!

Does it still happen with the latest master?

Seems the latest is even failing to run for me!! :(
Below is the output.
npm WARN engineStrict Per-package engineStrict (found in this package's package.json)
npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.
npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/Cellar/node/4.1.1/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.1.1
npm ERR! npm  v2.14.4
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! Please include the following file with any support request:
npm ERR!     /Users/tjoshi/black-screen/npm-debug.log
npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/Cellar/node/4.1.1/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v4.1.1
npm ERR! npm  v2.14.4
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prestart: npm install && npm run compile
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prestart script 'npm install && npm run compile'.
npm ERR! This is most likely a problem with the black-screen package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm install && npm run compile
npm ERR! You can get their info via:
npm ERR!     npm owner ls black-screen
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/tjoshi/black-screen/npm-debug.log
➜  black-screen git:(master)

Updating node to latest v6.2.0 seems to fix the problem


inure against windows.d changes by casting to LPCWSTR

I can't sign off on this.
What happens if you define FSChar as WCHAR instead?

@thewilsonator Are you OK with such noisy / intrusive changes being forced onto D code?

What happens if you define FSChar as WCHAR instead?

Then existing code won't compile, as wchar_t is becoming a different type from wchar.

Well, right, but it won't compile if you don't change anything either. What else would need to be changed if you change FSChar to WCHAR, is it possibly a smaller diff than this?

FSChar is not public and is not in any public functions' signatures.

Looks like you're right.

Are you OK with such noisy / intrusive changes being forced onto D code?

Ideally no, but this PR is a stop-gap until I can figure out why https://github.com/dlang/dmd/pull/8958 doesn't work and fix it, any help is much appriciated.

ok, we'll see how it fares

My guess is that it is not going to just work.
And that brings up a bigger problem, which I think is a conceptual blocker for this whole endeavor:
How is Phobos (std.algorithm etc.) supposed to treat this new wchar_t type?
Is it supposed to treat it like any D char (and wchar_t[] like any D character range)? Then, at least the definition of StringTypeOf will need to be updated to recognize it.
Or, is it supposed to be an alien C type that D-ish parts of Phobos won't touch? Then, that will make interop with C APIs that use wchar_t less smooth, and explicit casts will be required.

 D got it right.
Therefore, D users should avoid wchar_t as much as possible, and only use it when interfacing to C++ code that uses it. They can use a cast as the last step to get the type right. And in fact, the only reason to use it at all is to match the name mangling C++ uses for it.
So if wchar_t fails to work with some Phobos functions, don't use it. (My attitude about c_long and c_ulong is the same. Don't use them in normal D code.)
That leaves the Windows API, which Microsoft erred by using wchar_t. People should use WCHAR to interface to Windows, and only cast code to WCHAR at the last minute.

std\internal\cstring.d(178): Error: undefined identifier WCHAR

So did to!(WCHAR[]) work for you (with the compiler change)?


[Bug] Using a higher version of fury in dubbo-serialization-fury will result in an error 'Fail to decode request due to RpcInvocation'. Currently, it is known that fury versions 0.4.1 and above will experience this issue

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache Dubbo Component
Java SPI Extensions (apache/dubbo-spi-extensions)
Dubbo Version
Dubbo Java 3.2.9,OpenJDK 1.8
Steps to reproduce this issue
Reproduce with a simple RPC call
What you expected to happen
error:Fail to decode request due to: RpcInvocation
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Some time ago, we upgraded fury to version 0.6.0, does this kind of problem still happen? If so, can you describe it in more detail? If nothing else, I'll be tracking this issue.

Some time ago, we upgraded fury to version 0.6.0 in dubbo-spi-extensions, does this kind of problem still happen? If so, can you describe it in more detail? If nothing else, I'll be tracking this issue.

At first, I used the latest official version of Dubbo-serialization-fury, which is 3.3.0 and relies on the 0.2.0 version of Fury, which works properly. Later, I found out that you submitted the latest code to Dubbo-serialization-fury and updated the Fury version to 0.6.0, so I directly used your latest code and reported the above error.

Some time ago, we upgraded fury to version 0.6.0 in dubbo-spi-extensions, does this kind of problem still happen? If so, can you describe it in more detail? If nothing else, I'll be tracking this issue.

At first, I used the latest official version of Dubbo-serialization-fury, which is 3.3.0 and relies on the 0.2.0 version of Fury, which works properly. Later, I found out that you submitted the latest code to Dubbo-serialization-fury and updated the Fury version to 0.6.0, so I directly used your latest code and reported the above error.

Okay, I'll try to fix this and the bug in the next few days and upgrade the fury to the latest version 0.7.0

Some time ago, we upgraded fury to version 0.6.0 in dubbo-spi-extensions, does this kind of problem still happen? If so, can you describe it in more detail? If nothing else, I'll be tracking this issue.

At first, I used the latest official version of Dubbo-serialization-fury, which is 3.3.0 and relies on the 0.2.0 version of Fury, which works properly. Later, I found out that you submitted the latest code to Dubbo-serialization-fury and updated the Fury version to 0.6.0, so I directly used your latest code and reported the above error.

Okay, I'll try to fix this and the bug in the next few days and upgrade the fury to the latest version 0.7.0

Thank you, I will continue to pay attention.


[python] Add autoflake to auto rm unused import

Add a new commit hook to pre-commit, to auto
remove unused imports
Remove all unused pass statements
Add autoflake to tox and out CI

close: #8592

Codecov Report

Merging #8897 (b742faf) into dev (db64dca) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8897      +/-   ##
============================================
- Coverage     45.30%   45.27%   -0.03%
+ Complexity     4082     4081       -1
============================================
  Files           702      702
  Lines         27177    27186       +9
  Branches       2907     2908       +1
============================================
- Hits          12312    12309       -3
- Misses        13704    13715      +11
- Partials       1161     1162       +1

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...nscheduler/api/controller/ResourcesController.java
57.89% <0.00%> (-1.04%)
:arrow_down:

...heduler/api/service/impl/ResourcesServiceImpl.java
53.66% <0.00%> (-0.68%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db64dca...b742faf. Read the comment docs.

PTAL @devosend @jieguanzhou

Thanks for reviewing


Menu options are not responsive

The clock activity is displayed as expected on desktop version (Image 1) but the menu options do not adapt properly for the mobile version (Image 2, the stop option is not visible to the user).
Image 1

Image 2

An approach to solve the issue is to stack the menu options as viewport width decreases

I would like to work on this issue.

It's not an issue, Sugarizer is not adapter to smartphone in portrait mode. I suggest you to read more about that https://github.com/llaske/sugarizer/issues/106#issuecomment-466171717

Thanks for insights


Implement TouchPad improvements

Holding down contact buttons on idle state should change state to selected
Use orange to show selected state
Add a conference service button that creates an ad-hoc conference with all selected contacts

Support "im:", "xmpp:", "tel:" and "sip:" uris

TouchPad has been removed from version 2.0


High CPU usage

What steps did you take and what happened:
Trivy Operator is using near 100% of CPU all the time. In debug mode the logs are flooded with messages like this (not sure if the operator is supposed to check this often) but for the rest I do not see anything significant happening
2024-03-27T17:46:29Z    DEBUG    reconciler.ttlreport    RequeueAfter    {"report": {"name":"replicaset-external-secrets-webhook-cd4cbb65c","namespace":"external-secrets"}, "durationToTTLExpiration": "23h52m42.140754071s"}
2024-03-27T17:46:29Z    DEBUG    resourcecontroller    Checking whether configuration audit report exists    {"kind": "ReplicaSet", "name": {"name":"oauth2-proxy-5d9f94db5","namespace":"oauth2-proxy"}}
2024-03-27T17:46:30Z    DEBUG    reconciler.ttlreport    RequeueAfter    {"report": {"name":"daemonset-kured","namespace":"kured"}, "durationToTTLExpiration": "23h51m41.812625045s"}
2024-03-27T17:46:30Z    DEBUG    resourcecontroller    Checking whether configuration audit report exists    {"kind": "DaemonSet", "name": {"name":"prometheus-stack-prometheus-node-exporter","namespace":"prometheus-stack"}}
2024-03-27T17:46:31Z    DEBUG    reconciler.ttlreport    RequeueAfter    {"report": {"name":"replicaset-oauth2-proxy-5d9f94db5","namespace":"oauth2-proxy"}, "durationToTTLExpiration": "23h52m42.795478015s"}
2024-03-27T17:46:31Z    DEBUG    resourcecontroller    Checking whether configuration audit report exists    {"kind": "ReplicaSet", "name": {"name":"thanos-query-frontend-7bb9bfdfd","namespace":"prometheus-stack"}}
2024-03-27T17:46:31Z    DEBUG    reconciler.ttlreport    RequeueAfter    {"report": {"name":"daemonset-prometheus-stack-prometheus-node-exporter","namespace":"prometheus-stack"}, "durationToTTLExpiration": "23h51m36.746551987s"}
2024-03-27T17:46:31Z    DEBUG    resourcecontroller    Checking whether configuration audit report exists    {"kind": "DaemonSet", "name": {"name":"grafana-loki-promtail","namespace":"grafana-loki"}}
2024-03-27T17:46:32Z    DEBUG    reconciler.ttlreport    RequeueAfter    {"report": {"name":"daemonset-grafana-loki-promtail","namespace":"grafana-loki"}, "durationToTTLExpiration": "23h51m37.6956737s"}
2024-03-27T17:46:32Z    DEBUG    resourcecontroller    Checking whether configuration audit report exists    {"kind": "DaemonSet", "name": {"name":"kured","namespace":"kured"}}

The average workload is recurring every ~3/4 seconds
What did you expect to happen:
No high CPU usage in an idle situation
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Trivy-Operator version (use trivy-operator version): 0.19.1
Kubernetes version (use kubectl version): 1.28 AKS
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): Ubuntu

@Pionerd have you tried setting resources for operator

Yes, resources are set. CPU usage is constantly close to whatever limit I set, up to 4 CPUs. Memory does not seem a problem.
I don't mind if the app needs to use CPU (usually we don't set CPU limits at all) but from the logs, to me it is not clear what the Operator is doing that it needs so much.

I do observe all Clusterrbacassessmentreports being recreated constantly, none of them has an age of over 5 minutes

@Pionerd reports are created when resource is created/updated or reportTTL exceeded, any of it related to your case ?

@Pionerd the check for report is a part of processing, do you see report get generated e every few minutes ?

Yes

@Pionerd few of question:

are the generated reports same as existing ?
are reports get deleted while new one generated ?

Yes, they are exactly the same. The reports are deleted and then it takes up to a minute for them to reappear.

Yes, they are exactly the same. The reports are deleted and then it takes up to a minute for them to reappear.
it make sense, as deletion of cluster ClusterRbacAssessmentReport report deletion will trigger a new ClusterRole scan.
the only question is what is causing the deletion of the report.
it can't be TTL as TTL do not reconcile ClusterRbacAssessmentReport only RbacAssessmentReport could you think of on some outside process which delete the ClusterRbacAssessmentReport or the ClusterRole

@Pionerd  Thanks for this update.  I'll have a look regarding replicaset >0.
regarding infraassessment reports on AKS probably will not be supported as cloud provider do not allow access to api-server, controller-manager. scheduler and etc

@chen-keinan I think I found the culprit. Based on https://github.com/aquasecurity/trivy-operator/issues/1742 I wrote a pretty extensive exception set. Is it possible that the operator does not handle this in a very cpu friendly way? Any possibilities to improve this (or the exception definitions in general)?
I'd rather not share the whole exception definition here (it shows our full stack), but I can share it with you if it helps. It contains 26 policy.ksvXXX_exclude_resources.rego blocks, each with one or more exception[rules] blocks.

@chen-keinan I think I found the culprit. Based on #1742 I wrote a pretty extensive exception set. Is it possible that the operator does not handle this in a very cpu friendly way? Any possibilities to improve this (or the exception definitions in general)?
I'd rather not share the whole exception definition here (it shows our full stack), but I can share it with you if it helps. It contains 26 policy.ksvXXX_exclude_resources.rego blocks, each with one or more exception[rules] blocks.

sure, but you'll have to put here some real example so I could try to reproduce it

Please see you gmail.

Unfortunately the issue reappeared in an environment without those exclusions. Would be really nice if we could make some progress on this issue, please let me know if and how I may assist.

@Pionerd can you try disable scanner by scanner to isolate the problem and see which one cause performance issue ?

@Pionerd thanks for input, I'll have a look at it.

Hi @chen-keinan, I appreciate all your efforts for this project and suspect you got a lot on your plate. I'd be great if you could take a look at this issue, combined with the Rego exceptions I sent you ealier. In our experience this is the "best" way to document exceptions, so it's pretty vital to us (unless you have a better way to document exceptions, now or coming soon). TY!

@Pionerd the combine flag used to combine multi resource fo same policy, I'm not sure it can be achieved with operator pattern as it reconcile resource by resource and one is not aware to the other

The exceptions are working as intended, only at the cost of very high CPU usage. Do you suggest I should split them up?

@Pionerd I'll have to investigate it, it might take a while


Older versions of Windows (<6.2)

I was wondering if there was a possibility to support older versions of Windows, such as:
5.1 (Windows XP)
5.2 (Windows XP x64, Windows Server 2003, Windows Server 2003 R2)
6.0 (Windows Vista, Windows Server 2008)
6.1 (Windows 7, Windows Server 2008 R2)
If those are available to download.
P. S. Thank you for your work, much appreciated.

I confirm those are available:
PS C:\Users\Sergey\Desktop\New folder\Tools> .\ChromeDownloader.ps1 win 32 -os 5.2 -do info
Version: 49.0.2623.112
Url: http://dl.google.com/release2/14okehgrtfipvtyyd9pt7hf7ek7hhs7k47bc481jwgh8fz1ono51hw75dtgcm4j6kkei8h9clijoftygpga0q2kbey0o9n4ec6wd/49.0.2623.112_chrome_installer.exe
File: 49.0.2623.112_chrome_installer.exe
SHA256: 6557a26b9ff6185d2e215ccaf3d64d80a0e65c69ac23a091fc050612724908b8
Size: 45001120
Status: ok

Thank you for your feedback, @unwillinglyawesome
I'm surprised these are available since they're no longer supported. Nevertheless, I've added 32-bit support for Server 2003 (5.2) through 2008 (6.0) and 32/64-bit support for Server 2008 R2 (6.1)


Field(include={"all" ... exclude all attributes from parent entry

Checks
Hi, I found strange behaviour in v.1.9.1, pls see code example

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug

    from pydantic import BaseModel, Field

    class BaseUser(BaseModel):
        id: int
        first_name: str
        last_name: str

    class OrgUser(BaseUser):
        phone: str

    class Org(BaseModel):
        id: int
        users: list[OrgUser] = Field(include={"__all__": {"first_name", "phone"}})

    users = {"id": 1, "first_name": "test 1", "last_name": "test 2", "phone": "123123"}

    org = Org(id=1, users=[users])

My expectation for org.json() is
'{"id": 1, "users": [{"first_name": "test 1", "phone": "123123"}]}'
But in result
'{"users": [{"first_name": "test 1", "phone": "123123"}]}'
In result, I see only that fields which were configured with Field class

Confirmed that is weird. Thanks for reporting.
Could you try to fix it? Otherwise, I'll try to fix for V1.10, otherwise it'll definitely be fixed for V2.

I'll try to have a look, thanks.

I'm looking for an issue to contribute on, and took a look at this one
This behavior is actually not just related to "all" or parent\child models
consider the following example
class Model(BaseModel):
     arg1: int
     arg2: int = Field(include=True)

 m = Model(arg1=1, arg2=2)
 print(m.dict())

output is actually {'arg2': 2}
This behavior is actually equivalent to not defining the include in the field level and call print(m.dict(include={"arg2"}))
which makes it a bit more clear as to why this behavior occurs
once a Field is defined with an include, than while exporting it, it actually treats all other fields as not to include
more specifically, this happens due to this if https://github.com/samuelcolvin/pydantic/blob/master/pydantic/main.py#L814,
if not Field include was defined, then the if evaluates to False and everything is behaving as expected, but in case at least 1 Field include was defined, then if evaluates to True, and the result of the ValueItems.merge is in fact only that field
So, once the user field was defined with an include, then all other fields of that model are treated as not to include.
I'm not sure this is in fact a bug and what is the expected behavior

When call model.json or model.dict without include params, it using self.__include_fields__ and origin fields to calculate final export keys.
class Org(BaseModel):
        id: int
        users: list[OrgUser] = Field(include={"__all__": {"first_name", "phone"}})

the __include_fields__ of Org is {'users': {'__all__': {"first_name", "phone"}}}，the origin fields is dict_keys(['id', 'users']), so the final export keys are {'users'}
@samuelcolvin i think maybe is not a bug.
@artofhuman you can change code to
class Org(BaseModel):
        id: int = Field(include={'id': True})
        users: list[OrgUser] = Field(include={"__all__": {"first_name", "phone"}})

users = {"id": 1, "first_name": "test 1", "last_name": "test 2", "phone": "123123"}

org = Org(id=1, users=[users])
org.dict() # {'id': 1, 'users': [{'first_name': 'test 1'}]}

Thanks for providing the workaround.
I still don' think this is very intuitive.
I don't think setting Field(include= on users should alter whether id is included.
Hopefully this can be fixed in V2.

i suggest a little fix:  https://github.com/pydantic/pydantic/blob/1a5b56e1b2020fd74800064d038becf614d64a61/pydantic/main.py#L897
change
keys &= include.keys()

to
keys |= include.keys()

we're definitely not making changes like that in V1.10 since the potential impact could be very subtle and quite severe, we need to think about this whole thing again for V2. See #4456.

ok


Implement transform + schema for XSSH banner grabber

This PR:
• updates the SSH banner transform to work with the new XSSH banner grabber's output
• updates the schema to include various new
Items to note
The ZTag transform is fully backward-compatible with the legacy SSH banner grabber; so no ZTag usage changes are needed for tools which process SSH grabs with ztag -P ssh -p 22 -S banner — they'll just work when you pass in output from the XSSH grabber.
You'll notice that in the schema I've extracted the definitions for RSA and DSA params, and those are now shared between SSH banner records and zgrab_parsed_certificate. Please let me know if this looks acceptable. I did not make parsed_certificate reuse the ecdsa_public_key definition because this comment indicates a special case affects parsed_certificate's ECDSA public key schema.
Testing
This gist contains example ZGrab output you can pipe through ZTag (ztag -P ssh -p 22 -S banner) to see what the output looks like.
The gist also contains xssh_ztag_results_embedded_in_ipv4_record.json, which is a modified version of ZTag output for xssh_zgrab_results.json. This can be used to validate the schema, via zschema validate ztag/schema.py:ipv4host xssh_ztag_results_embedded_in_ipv4_record.json.
Running that command successfully requires a change in the ZSchema tool, submitted in https://github.com/zmap/zschema/pull/9.

It looks like this is failing due to a (transient) TravisCI issue, not @cdzombak. I think we're good to merge. @zakird?

It looks like this is failing due to a (transient) TravisCI issue, not @cdzombak.
That's my impression. I tried restarting the build once, but it failed the second time, too.

If it's transient, then we should get rebuild to fix. Otherwise we should figure out why it's not building... because it's just going to bite us again in the future. :)
I'd rather spend the time now to figure this out then set the precedent of merging things with failed builds.

I did a rebuild, and it still failed in a section that's clearly under the control of TravisCI (installing pypy). I can try again.

The Travis issues seem to have been caused by some recent change on Travis's end. https://github.com/travis-ci/travis-ci/issues/6865 is the relevant issue with community feedback and discussion.
Per @BanzaiMan in https://github.com/travis-ci/travis-ci/issues/6865#issuecomment-307187192,

pypy and pypy3 are not names we can support consistently going forward.
Please use pypy-x.y.

The Travis docs have not been updated to reflect this change, despite an 18-day-old comment indicating "We'll update the documentation shortly." (https://github.com/travis-ci/travis-ci/issues/6865#issuecomment-307187672). I sent Travis an annoyed tweet which probably will have no effect, but it made me feel slightly better.
There is no list of which pypy versions are actually available, so finding one which Travis can use is effectively guesswork. Travis tries to download from https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/pypy-X.Y.Z.tar.bz2.

I tried the latest (5.8 and 5.8.0) and Travis failed to download them.
The version we're using in prod (5.1.2) also failed to download.
Yelp is using 5.4.1 and that seems to work, so… I guess we should merge this ¯\_(ツ)_/¯

sgtm


can't open file 'tools/mmcls/mmcls/train_mmcls.py': [Errno 2] No such file or directory

Describe the bug
When I run 'CUDA_VISIBLE_DEVICES=1 tools/mmcls/dist_train.sh configs/distill/rkd/rkd_neck_resnet34_resnet18_8xb32_in1k.py 1' i get the error attached in the screenshot
and when I run 'python tools/mmcls/train_mmcls.py -h '
I get the error in the second screenshot

(mm) manu@manu-System-Product-Name:~/PycharmProjects/mmrazor$ python
Python 3.8.10 (default, Mar 13 2023, 10:26:41)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import torch
torch.version
'1.13.1+cu117'
import mmcv
mmcv.version
'2.0.0rc4'

Please help me to do Knowledge Distillation

Sorry for the delayed response. It seems that you executed the codes in master branch.  Currently, we recommend using the codes from the main branch as our preferred option, and we will gradually discontinue maintenance of the master branch.
In the master branch, the training script can be found in tools/mmcls/train_mmcls.py, rather than tools/mmcls/mmcls/train_mmcls.py. Hence, there might be an issue with the python path. If this problem persists even after switching to the main branch, please inform us so that we can assist you further.


[virtualbox] Add provisioning script for install VBoxGuestAdditions tools

Now we're using plugin vagrant-vbguest. Which install virtualbox guest tool.
If we prepare box installed VBoxGuestAdditions tools. We don't need install plugin vagrant-vbguest.
This also will increase to up peer.

Done in Master.

Done in Prod.


[stable/kanister-operator] Fix the failure links

Fix the failure links
[installation](#Installing the Chart) --> installation

/assign @seanknox

/ok-to-test

/assign

/lgtm


Spoor left and right half of stats indepently

I would like to be able to change only the left or right part of a stat while leaving the other as its default value
For instance, if I have 30 attack (30/30), I would like to be able to make it look like 30/1 or 1/30

(I've written code to do this and I'm in the process of making a PR for it)


[bug report]watermark not append to body when targetElement was not specified

targetElement: null
actually:
watermark: appeded bellow body
hope to:
append to body

fixed


When you zoom the Phylogenetic tree, the distance marker doesn't update

Probably a bug in Phylotree, may not be fixable on our end.

OK, we're going to replace the library with TidyTree.


[Tests] Validation needed for data fields in Theme

Describe the bug
It's possible to add an online Mapbox map for a community Theme in the Administrative back end. This requires both a Mapbox style url and a Mapbox access token.
Currently, it's possible to set one of these without the other. This will result in the  app not loading anything when going to the map view.
To Reproduce
Steps to reproduce the behavior:

Go to Theme in the administrative back end (with a username with admin privilege)
Edit the theme and add a Mapbox style url.
Don't add anything in Mapbox access token.
Update Theme.
Go to map view - it will be blank.

Expected behavior
We should make it so that if Mapbox style url field has content, then Mapbox access token is required to have content as well, and vice versa.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

cool I am already part of the slack, Right now I think I'll wait for my mentor (Ian Norris) to reply in the fellowship slack. If he's busy I'll put it up in ruby for good slack as well.


Add a bytes count/maximum to AsyncReader.read

Summary

AsyncReader.read should take a count/maximum argument that allows the consumption of part of the stream, instead of everything.
Problem

Currently, it's rather cumbersome to read the first bytes of a stream (for example, to make a guess about the MIME type).
Ideal implementation

For example,
async def read(self, maximum: typing.Optional[int]) -> bytes:
    """Read `maximum` bytes at max, or the whole stream if `None`, and return it in a `builtins.bytes` object."""
    buff = bytearray()
    c = 0
    async for chunk in self:
        if c == maximum:
            break
        buff.extend(chunk)
        c += 1
    return buff

The enumeration part could be refactored into its own little util, since the builtin enumerate wrapper does not work with async iterators.
Checklist

[x] I have searched the issue tracker and have made sure it's not a duplicate.
If it is a follow up of another issue, I have specified it.

I'm willing to implement this and open a PR if you guys think it's a good call.

This issue might've been put on ice for a bit due to the pretty complex implications it has and there being no clear sight on which method would be the best for implementing this but for reference it was discussed around here https://canary.discord.com/channels/574921006817476608/700378161526997003/856938643481690163

I understand your position. 👍
Thanks for your time considering this feature.


Re-export everything from consensus::encode

Most of the types and functions from consensus::encode are re-exported in consensus but not all of them, there is no obvious reason for not re-exporting all types and functions.

ACK cc585a8 though VarInt I thought we were planning to deprecate anyway

Oh, lets not do VarInt then since taking things away is annoying for people - will respin.

Note to self, needs Error as well.

Removed VarInt (its exported at crate root anyways) and added Error so users can do consensus::Error.

Is this ACK or NACK from you @Kixunil?

I'd prefer not this exact commit, but leave out CheckedData.


Performance Improvements

Fixed some glaring performance issues
Added support for controllers to recognize their related models

Added in those additional tweaks I mentioned to this PR.  Issue #60 should be resolved with this change.

@serpentblade thank you , great work


Chart subtitle "average" switched to "mean" when selecting "average"

the chart on the clients overview page: it says average on default but when the user selects "average data" it says "mean". I think its the same chart but 2 names.

this issue affects most charts in default view and their subtitle when selecting the corresponding view from the options drawer: Average -> Mean

@ZakMooney One for you

changed mean to average: e8eb819


Fix 'autoenv_check_authz_and_run:20: = not found' error on Ubuntu and zsh.

This is a fix for #94 issue.

Getting this issue on OS X as well.

+1

As I understand, this issue was closed in commit https://github.com/kennethreitz/autoenv/commit/fbad6f775988a1c857f2b4bc542d76bddc1d6246


Fix timeout support

The fix for #7 is flawed.  It implies (at least) 2 problematic things:

That all timeouts are specified when you create the client (and not individual requests).
Feign doesn't always try to establish per-request timeouts

The first isn't necessarily true, and the second definitely isn't true with current feign impl.  So basically, what this means is that for every MoccaHttpClient other than the JAXRS2 one, where we ignore feign's attempt to set its default timeouts, the user is forced into feign's timeout defaults.

Code changes to fix this issue are in this branch: https://github.com/paypal/mocca/commits/fix_for_issue_41
Those changes are incomplete though, since the usage of Mocca breaks after those changes were introduced (see error below).
These changes were originally already in develop branch. However, because they caused the error below, they were removed from develop branch and placed at branch fix_for_issue_41.
class com.paypal.mocca.client.MoccaOkHttpClient tried to access private method 'void com.paypal.mocca.client.MoccaHttpClient.<init>(feign.Client)' (com.paypal.mocca.client.MoccaOkHttpClient and com.paypal.mocca.client.MoccaHttpClient are in unnamed module of loader 'app')
java.lang.IllegalAccessError: class com.paypal.mocca.client.MoccaOkHttpClient tried to access private method 'void com.paypal.mocca.client.MoccaHttpClient.<init>(feign.Client)' (com.paypal.mocca.client.MoccaOkHttpClient and com.paypal.mocca.client.MoccaHttpClient are in unnamed module of loader 'app')
	at com.paypal.mocca.client.MoccaOkHttpClient.<init>(MoccaOkHttpClient.java:30)


fix: ignore tsconfig setting files

Astro should not be reading the tsconf settings file.  This causes issues  such as strict: true causing ts errors like:
JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
RE: https://discord.com/channels/830184174198718474/845451724738265138/895704312544653353
Closes #91.
Personal References:

Link #T-366
Closes #T-366

I'm submitting this, as its been a continued problem where people's tsconfig conflicts with Astro. So simply not using tsconfig in .astro files fixes the problem.


Deployment via Docker: Landscape download not possible

When deployment via Docker (https://github.com/ExplorViz/docker-configuration) a landscape download is not possible. May be caused by the employed reverse proxy configuration.

Issue seems to be fixed.


body: fingerprinting broken after setting separation time

@briskspirit is this fixed?

No, we still need to ship the body FW update.


Imporve the UI for the alert of Correct/Wrong ans

FindCSI
Problem:
The alert displayed on the website looks very ugly/old-fashioned
Solution:
A better user interface for informing the user if his answer was correct.

If you're using Chakra UI, there is a toast component to solve this issue.
It can also be done dynamically with JavaScript nd CSS.
Assigned it to me nd see what I have in my box🥰

Yes I am looking for something done with CSS and JS.
I have assigned it to you, All the best !

I'll make a push request very soon

I've made a pull request


Move less from public/ to web_src/ so that it will not be packed on binary

Extract from #8598

Codecov Report

Merging #8908 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8908      +/-   ##
==========================================
- Coverage    41.3%   41.29%   -0.01%
==========================================
  Files         545      545
  Lines       70398    70398
==========================================
- Hits        29080    29074       -6
- Misses      37618    37622       +4
- Partials     3700     3702       +2

Impacted Files
Coverage Δ

models/repo_mirror.go
2.27% <0%> (-11.37%)
:arrow_down:

modules/migrations/migrate.go
21.22% <0%> (-1.68%)
:arrow_down:

services/mirror/mirror.go
18.93% <0%> (-1.14%)
:arrow_down:

models/repo_list.go
73.3% <0%> (-0.98%)
:arrow_down:

modules/migrations/gitea.go
8.05% <0%> (-0.64%)
:arrow_down:

models/repo.go
48.96% <0%> (-0.06%)
:arrow_down:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

models/error.go
33.86% <0%> (+1.18%)
:arrow_up:

modules/task/migrate.go
28.94% <0%> (+3.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9e625...647b88d. Read the comment docs.


Added 2 nodes of 1 user

Added:

@skalablex:matrix.org 2 nodes of the user

@ironoa Element handle was verified


Colour-coding of districts

Districts are classified as red, orange and green zones on the basis of incidence of coronavirus cases. I wish to see the same color coding for distric in this website.
Read more at:
https://economictimes.indiatimes.com/news/politics-and-nation/colour-coding-of-districts-in-battle-against-covid-19/articleshow/75416339.cms
Describe the solution you'd like
Either backgroud color or font color shall describe the zone status of each district
Describe alternatives you've considered
None
Additional context
None

Duplicate https://github.com/covid19india/covid19india-react/issues/1040


[Event-Request] Table 36 "Sales Header" - OnBeforeLookupSellToCity

Hello,
We would like to request the addition of the event OnBeforeLookupSellToCity(Rec, PostCode) in procedure OnLookup() of field(83; "Sell-to City"; Text[30]) in Table 36 "Sales Header":
trigger OnLookup()
begin
++  OnBeforeLookupSellToCity(Rec, PostCode);
PostCode.LookupPostCode("Sell-to City", "Sell-to Post Code", "Sell-to County", "Sell-to Country/Region Code");
end;
[IntegrationEvent(false, false)]
local procedure OnBeforeLookupSellToCity(var SalesHeader: Record "Sales Header"; var PostCodeRec: Record "Post Code")
begin
end;

Note: some other fields already have this event, like "Ship-to City" and also have the "OnAfterLookupShipToCity" event present. Maybe this event can be added as well?
Note 2: Similar request for another field requested in https://github.com/microsoft/ALAppExtensions/issues/17875
Thanks in advance,
Jerry Tyssen
Cegeka

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


With CACHE_AND_NETWORK, don't provide network results if same as cache results

Is your feature request related to a problem? Please describe.
Yes, currently I get a callback with the data twice—once with the cache data, and once with network data, even when they're the same. Which means to avoid unnecessary rerenders, I have to do a check like this:
https://github.com/GraphQLGuide/guide-android/commit/09fbfec63a86f743399f986cac304918a04e1f96
Describe the solution you'd like
Perhaps the general solution is: when watching any query, if I've received certain data, I don't want to receive that same data again. (Regardless of whether identical data comes in from the NETWORK of a CACHE_AND_NETWORK, or another overlapping query elsewhere in the app, or even a mutation/cache edit that sets identical data.)

Hi! I think issues like deduplication and debounce are better addressed by frameworks like RxJava and/or coroutines who have specialised methods for this. For an example, with coroutines, it would be as easy as:
apolloCall.toFlow(). distinctUntilChanged().collect {
    // update UI here
}

Since the generated models are data classes, that would work out of the box.

@lorensr would that be ok with you? I'd really like to keep the apollo-android API as small and focused as possible. I'll close this issue if that's ok.

Sounds good! Thank you ☺


Make include paths start from include directory (no relative paths).

For example:
#include "SEL/Threads/Thread.hpp"

I also rearranged files in directories and added Maths.hpp and Utilities.hpp header files.

Small mistake: include paths in Vec.hpp were not updated.


Fix title for example 5

Fixed Example title. It was a duplicate of the previous example.

Docs Build status updates of commit e89670b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/Get-AzureADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Hi @bieberium
Per the read me file:
Please be aware that if you have any updates to automatically generated reference content, you should create an issue and not a PR.  The issue will then be created into a bug and triaged accordingly.  We do this because the reference content must mirror the *dll-help.xml file and subsequent updates to the reference content may overwrite any changes made through the repo.  Capturing it in the source code ensures that this does not occur.  Any PR with changes to automatically generated reference content will be closed.
Automatically generated reference content is any of the content under this Reference node, such as Get-AzureADUser
This only applies to reference content and not conceptual content.  Pull requests for changes to conceptual content are accepted and encouraged.  An example of the conceptual content is the Overview or a scenario such as importing data.
Thank you!
Bill


Filter formula

Adds support for filtering records on a table via a formula re https://github.com/nesquena/airtable-ruby/issues/4

As it is, this looks worthwhile to merge and we can build on top of it. Thanks @sbauch

@nesquena I'd love to maintain the gem. I don't have any immediate plans, but I'll likely start with complete feature-parity with Airtable.js. It'll be a while before it becomes officially-supported, but eventually it will be there and also included in our generated API docs. I'd appreciate if you transfer the repo to https://github.com/airtable org and ruby gem to alex-at-airtable.

@syrnick Doesn't look like I am allowed to transfer the repo to airtable, I get an error about persmissions. I am initiating a transfer to you directly so you can transfer into your org.  You are also an owner on rubygems as well.

I transitioned the repo. @nesquena thanks for writing it!

Great, thanks! Happy I could help get things started with the ruby client.


Could add support for Azure OpenAI or custom API endpoint?

Is your feature request related to a problem? Please describe.
Some people only have Azure OpenAI do not have offical api.
Describe the solution you'd like
Add enviorment variables or setting UI to support the Azure API or custom endpoint.
Describe alternatives you've considered
Provide a page with form that can custom the API type may be a cool solution.
Additional context
And I see the OPENAI_API_KEY env defiened in .env file, but don't use in anywhere, it's a mistake or it used with another way?
Thank you for your dedication and effort.

Hey, you just need to pass them as an environment variable in the env file and OpenAI package would automatically read it from the env file. Yes, I am changing how settings work and the UI will be released pretty soon.

Did you mean put this in config.toml?

Did you mean put this in config.toml?

You need to choose the custom OpenAI provider in the settings menu (from the UI) after which you'll be able to fill the details there. This is an old issue.


Vickel: Watch girthquake32(?:@gmail.com)?

Vickel requests the watch of the watch_keyword girthquake32(?:@gmail\.com)?. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

girthquake32(?:@gmail\.com)? has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Add Korean translations

This adds translations for Korean/South Korea ko_KR
Note: for some reasons the diff after running grunt is a mess. I guess some npm packages have been upgraded since last update.

Many thanks @mittsh for contributing. I have merged only the first change in your branch and run "grunt" myself. Now there is less confusion in the diff, as well as a new shiny v0.0.16 with Korean!


New major version

Changes

#11

Closes #10

I'll keep this one as a pre-release to test out v2.0.0 until next weekend

:tada: This PR is included in version 2.0.0-next.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-next.3 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-next.4 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


API: move to api-version=2 for faster streaming LLM responses

Previously, the Cody IDE client used api-version=1 for LLM chat responses, which sent the full LLM response on every streaming change. This was problematic because it meant we were sending a lot of redundant traffic between the IDE client and the remote Sourcegraph instance eventually resulting in a slower user experience.
Now, we use api-version=2, which only sends the delta between chunks. This significantly reduces the amount of characters we're sending over the wire. For example, for a chat response with 3k output tokens, we were previously processing up to 1.8m tokens(!!) while now we only process 3k tokens.
Don't merge until https://github.com/sourcegraph/sourcegraph/pull/293 goes live.
Test plan
Tested locally and confirmed that both api-version=1 and api-version=2 work as expected.
TODO:

Update all HTTP recordings to reflect the new API. This should give us good test coverage.
Manually confirm the web extension is still working.

Changelog

Cody now uses a new LLM API that offers faster performance, especially for long chat responses

@valerybugakov I think it's best to merge this for chat first and validate it works before migrating autocomplete. The performance wins are most noticeable for large outputs and most autocomplete requests have small outputs, although I expect it to be a nice win for multi-line

api-version=2 is now live on dotcom and s2 (not the 5.7 release) so I can resume working on this PR 💪🏻

Thank you for the reviews!
The api-version=2 PR got reverted due to a regression for Google/Mixtral models. I'm going to close this PR until we address the followups from here https://sourcegraph.slack.com/archives/C07LGD509S5/p1725611701937449?thread_ts=1725553823.408939&cid=C07LGD509S5

@valerybugakov I will not drive the migration to api-version=2 for autocomplete. For PLG users, my understanding is that we're already using fastpath which is using the delta encoding. For Enterprise users, it would only be a win for XXL multiline completions. I'm personally unsure how big of a performance win it would be, and autocomplete should IMO not be suggesting such large blocks in the first place.


iOS App Link Constraints

https://docs.walletconnect.com/mobile-linking#ios-app-link-constraints
Library suffers from this issue by design in that seaport-js can do a lot of nice work after the click and before requesting signatures from the user. This issue more or less completely breaks a dapp on iOS. Once you're bounced into the App Store instead of the crypto wallet, the UX is 💀  and in many cases it's not possible to complete the operation even if you know all about this bug constraint.
The best immediate solution seems to be to clean bounce users into the built-in MetaMask or Coinbase browsers from the start, where app linking isn't needed.  I'm not sure why OpenSea.io  (and many other sites) aren't doing that.
It's technically possible to make it work if all the Apple rules are followed. For an example of something that doesn't have this issue, check Uniswap on an iOS browser.

We could use sendUncheckedTransaction, which should help based on the document?

Sure, it would be cool if that's all that's requried. I'd be surprised though. It seems like iOS wants nothing happening between the user interaction and the app switch for it to work properly. Can't say I understand why it goes to the App Store when tripping over this "constraint" but apparently this has been the behavior for years.


Tilemap Fake Shadow Layer

Operating system or device, Godot version, GPU Model and driver (if graphics related):
PC, Win 7 x64, nVidia GTX 680
Issue description:
I created a TileMap to act as a 'shadow' layer. (I placed it below my 'walls' TileMap.)
I placed a bunch of black, tiles on the layer, some of the tiles have pixels that overlap.
I then set the shadow TileMap's opacity to 0.5.
The intent was to have all the tiles (even overlapping pieces) render at the same opacity. The effect I was hoping for was for all the black pixels to 'combine' across the shadow layer.
I'm guessing that I'll need a custom shader or something to achieve this but thought I'd ask here first.
So can this be achieved with Godot's built-in mechanism? If not, could someone point me in the right direction please.
Thanks for any help.
EDIT: link to image

david brevik implemented something like this in It Lurks Below. iirc, he said it was a shader

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Yqxu dev

What this PR does:
using tire to match url instead of avgtree

Codecov Report

Merging #111 (f7d84a4) into develop (7af047d) will increase coverage by 1.32%.
The diff coverage is 79.36%.

@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
+ Coverage    41.84%   43.16%   +1.32%
===========================================
  Files           33       35       +2
  Lines         1410     1559     +149
===========================================
+ Hits           590      673      +83
- Misses         736      795      +59
- Partials        84       91       +7

Impacted Files
Coverage Δ

pkg/router/route.go
88.88% <72.72%> (-8.13%)
:arrow_down:

pkg/utils/trie/trie.go
80.76% <80.76%> (ø)

pkg/filter/remote/call.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af047d...f7d84a4. Read the comment docs.

Codecov Report

Merging #111 (f7d84a4) into develop (7af047d) will increase coverage by 1.32%.
The diff coverage is 79.36%.

@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
+ Coverage    41.84%   43.16%   +1.32%
===========================================
  Files           33       35       +2
  Lines         1410     1559     +149
===========================================
+ Hits           590      673      +83
- Misses         736      795      +59
- Partials        84       91       +7

Impacted Files
Coverage Δ

pkg/router/route.go
88.88% <72.72%> (-8.13%)
:arrow_down:

pkg/utils/trie/trie.go
80.76% <80.76%> (ø)

pkg/filter/remote/call.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af047d...f7d84a4. Read the comment docs.

I plan this approve to 0.3 or 0.4 version, may be in 2020.03

I plan this approve to 0.3 or 0.4 version, may be in 2020.03


points 2D slice

get points output similar to ImageData but only for 2D slice

https://opensource.stackexchange.com/questions/9721/etiquette-for-incorporating-someone-elses-mit-code-in-my-gpl-project


ShortUrlHandler should redirect to correct app

Now is always redirects to rogerthat://

https://github.com/rogerthat-platform/rogerthat-backend/pull/112 fixes the issue for chrome on android


[Question] Load order of related data

Let‘s say I have a Shop context with a list_customers/1 function (takes as shop as argument). Now I want to test it:
shop = insert(:shop, customers: build_pair(:customer)

assert shop.customers == Shop.list_customers(shop)

The problem I have here is, that insert reverts the order of the customers I built using build_pair for some reason.
Is there a way to tell ExMachine in which order to return the associated data? If not, it would be great if there was a way to tell ExMachina which fields it should explicitly load and in which order (this is related to https://github.com/thoughtbot/ex_machina/issues/295)

Hi @zimt28 it's possible that insert is accidentally reverting the order of build_pair, though it seems strange that it would be doing that.
Could you confirm for me what build_pair(:customer) returns and what is it you're expecting out of Shop.list_customers(shop)? Does list_customers/1 do any kind of sorting?

I have a similar issue, though I'm not using build_pair but explicitly define multiple entries by hand:
%Project.Schema{
  objects: [build(:object) build(:object, amount: 100), build(:object, amount: 500)]
}

I'm testing a utility function that loads all Schema objects from Postgres with their objects – the objects are always returned in a reverse order by my utility function. At first I thought this might just be because the Query in the utility function doesn't specify a order_by for the relation_objects, but since this issue is having the same problem, maybe there is actually something going awkward here.


Create a configuration file for Sonatype Lift

Start off with a few things that should be configured for ORT. Probably
more tuning will be needed in the future.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

FYI: The list of analyzer included in Lift is documented at https://help.sonatype.com/lift/included-analyzers.