[Feature Request] Change Protagonist and your name

I'm afraid this might be outside of the scope of this fix but I'm going to ask.
Currently if you change language the game "resets" your's and the protagonist's name to "You" and "Will".
There does not seem to be a way to change them in the game so i searched a bit and found this giude on reddit to change the names stored in the save file.
I did the edit but i think that it might not work if you changed the game language and only works to make a "normal" change because i edited eache instance of "You" and "Will" from every save file but booting the game the names are not changed.

+1 i was thinking of making a small python script that does this for me, but it would nicer if Lyall had two new settings
name_override = false
name = Will

@blamesoft did you end up making that script?


libtins: 3.5 -> 4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libtins/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 4.0 with grep in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
found 4.0 in filename of file in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
directory tree listing: https://gist.github.com/26990576c9472ca38b4d21613157856b

cc @fdns for review

Failure on x86_64-darwin (full log)
Attempted: libtins
Partial log (click to expand)
         55 - dot11/reassoc_request (Child aborted)
         56 - dot11/reassoc_response (Child aborted)
         57 - dot11/rts (Child aborted)
         58 - radiotap (Child aborted)
         59 - wep_decrypt (Child aborted)
         60 - wpa2_decrypt (Child aborted)
Errors while running CTest
make: *** [Makefile:84: test] Error 8
builder for '/nix/store/cm763si1jigrw84my6lii72zmqvsx1qp-libtins-4.0.drv' failed with exit code 2
error: build of '/nix/store/cm763si1jigrw84my6lii72zmqvsx1qp-libtins-4.0.drv' failed

Success on x86_64-linux (full log)
Attempted: libtins
Partial log (click to expand)
-- Installing: /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/include/tins/sniffer.h
-- Installing: /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/include/tins/tcp_stream.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
shrinking /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/lib/libtins.so.4.0
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/lib
patching script interpreter paths in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
checking for references to /build in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0...
/nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0

Success on aarch64-linux (full log)
Attempted: libtins
Partial log (click to expand)
-- Installing: /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/include/tins/sniffer.h
-- Installing: /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/include/tins/tcp_stream.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0
shrinking /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/lib/libtins.so.4.0
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/lib
patching script interpreter paths in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0
checking for references to /build in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0...
/nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0

Updating libtins to v4.0 will be a major version change, and will break the package compactor. There is a branch working in the update, but I would prefer the change be merged in master before updating.

Failure on x86_64-linux (full log)
Attempted: compactor
Partial log (click to expand)
                 from src/baseoutputwriter.cpp:15:
src/dnsmessage.hpp: At global scope:
src/dnsmessage.hpp:174:16: error: cannot declare field 'DNSMessage::dns' to be of abstract type 'CaptureDNS'
     CaptureDNS dns;
                ^~~
make[1]: *** [Makefile:1436: src/compactor-baseoutputwriter.o] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:1059: all] Error 2
builder for '/nix/store/0r5brbfhm4dzk09nfzr5s97xjfjraipi-compactor-0.11.0.drv' failed with exit code 2
error: build of '/nix/store/0r5brbfhm4dzk09nfzr5s97xjfjraipi-compactor-0.11.0.drv' failed

Failure on aarch64-linux (full log)
Attempted: compactor
Partial log (click to expand)
                 from src/baseoutputwriter.cpp:15:
src/dnsmessage.hpp: At global scope:
src/dnsmessage.hpp:174:16: error: cannot declare field 'DNSMessage::dns' to be of abstract type 'CaptureDNS'
     CaptureDNS dns;
                ^~~
make[1]: *** [Makefile:1436: src/compactor-baseoutputwriter.o] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:1059: all] Error 2
builder for '/nix/store/ja8csig0f8ld515nn33a8ilnbd3d3061-compactor-0.11.0.drv' failed with exit code 2
error: build of '/nix/store/ja8csig0f8ld515nn33a8ilnbd3d3061-compactor-0.11.0.drv' failed

@fdns ping from triage: I read your answer as implying that you know some changes that would make this update work. Is this correct? If so, do you know how to move this forward?

@Ekleog Sorry for the delay, I submitted #47271 with the update to compator, which add support to libtins 4.0 (I tested it locally and should work without problems)

@fdns No problem, and thank you for actually doing it! :+1: So if I understand correctly, #47271 should be merged first, then this one? :)

@Ekleog Yes, as the previous compactor doesn't support libtins 4.0

Success on x86_64-linux (full log)
Attempted: compactor
Partial log (click to expand)
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1
shrinking /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin/inspector
shrinking /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin/compactor
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1
checking for references to /build in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1...
/nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1

Success on aarch64-linux (full log)
Attempted: compactor
Partial log (click to expand)
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1
shrinking /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin/inspector
shrinking /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin/compactor
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1
checking for references to /build in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1...
/nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1


Build multiarch render container (with buildx)

Although the GitHub Actions runners are amd64, I often do a manual render on M1 Mac -- which does work with the amd64-only container but is slow due to code translation -- so this is useful to me at least!
This uses the same workflow as nmos-testing

Looks good. Should we somehow be warning (our future selves) not to use the .deploy/Makefile that builds and uploads a single arch?

Yes I wondered about that.  Was tempted just to remove the .deploy dir but it's useful sometimes to build a local container on the local arch.  How about changing the Makefile so the default is to print a warning and run make-container.sh, and make upload prints a (different) warning?


cjxl 0.7 seems to produce bigger lossless pictures than 0.6.1

Describe the bug
I converted a few PNG screenshots to lossless JXL by using cjxl and noticed that the same screenshots turned into bigger JXL files when I used 0.7.0 compared to 0.6.1 no matter which options I used.
To Reproduce
Steps to reproduce the behavior:
(Example output files in block with file size in front of the names)
0.6.1 cjxl -q 100 -m -s 9 -E 3 -I 1 $PNG $JXL
652K Bildschirmfoto_2022-09-21_01-05-01.jxl
1,2M Bildschirmfoto_2022-09-21_01-05-08.jxl
705K Bildschirmfoto_2022-09-21_01-05-27.jxl

0.7.0 cjxl -q 100 -m 1 -e 9 -E 3 -I 1 $PNG $JXL
712K Bildschirmfoto_2022-09-21_01-05-01.jxl
1,3M Bildschirmfoto_2022-09-21_01-05-08.jxl
790K Bildschirmfoto_2022-09-21_01-05-27.jxl

0.7.0  cjxl -q 100 -e 9 --brotli_effort 11 -E 3 -I 10 $PNG $JXL
670K Bildschirmfoto_2022-09-21_01-05-01.jxl
1,2M Bildschirmfoto_2022-09-21_01-05-08.jxl
743K Bildschirmfoto_2022-09-21_01-05-27.jxl

I also tested dropping -q and -m or using -m 0, etc.
Expected behavior
cjxl -q 100 -m 1 -e 9 -E 3 -I 1 looks like it should create files as small as 0.6.1's cjxl -q 100 -m -s 9 -E 3 -I 1 since effort is the replacement for speed.
So I expect generated JXL files at least as small as in 0.6.1.
Screenshots
Not necessary.
Environment

OS: Arch Linux
Compiler version: clang 14.0.6 / gcc 12.2.0
CPU type: x86_64
cjxl/djxl version string: cjxl v0.7.0 f95da131 [AVX2,SSE4,SSSE3,Unknown]
cjxl/djxl version string (old): cjxl v0.6.1 a205468b [AVX2,SSE4,SSSE3,Scalar]

Additional context
I did not compile libjxl myself but used Arch Linux's libjxl package but also tested the static 0.7.0 cjxl from the Release page of this GitHub repo.

Thanks for the report!
I suspect there is a misunderstanding:
-s 9 would map to -e 1. Sorry for the confusion, but a lower effort translates to a faster, i.e. higher, speed.
Could you try if that solves the issues with size that you are observing?

Thanks for the report! I suspect there is a misunderstanding: -s 9 would map to -e 1. Sorry for the confusion, but a lower effort translates to a faster, i.e. higher, speed. Could you try if that solves the issues with size that you are observing?

I don't think that's true, the old --speed parameter had the same meaning as the current --effort (higher value is slower, like how it is in webp/brotli/gzip), which was confusing so we renamed it to --effort :)
So I suspect something else causes this.
Ah, it's probably the option -I 1. That one changed from having a range 0..1 to having range 0..100, so you have to multiply the value by 100 to make it do the same thing.


Make sure dependencies are transpiled to ES5

A number of our dependencies aren't compiled to ES5 - this is preventing blockstack.js from being used in javascript engines that don't support ES5 such as duktape.
@friedger is going to take a look at this since it's blocking us on Android

running dist/blockstack.js again through babel solved the issues I had.
@larrysalibra for duktape, there is still a dependency to the browser in FormData in networks.js (using window.FormData)

This is now fixed in latest version.


Soft-landing (And probably all accessory runes) missing invested trait

The rules on accessory runes make it so they turn the item they are on into an invested item, so for foundry bookkeeping, they should probably just get the invested trait themselves?   I noticed there's no way for soft-landing, and I assume it's probably the same for others.

Runes themselves aren't invested. This will be taken care of when accessory rune support is added.


CMSIS-NN LSTM issue fixes

Remove read of non-initialized buffer
Adds back integer unidirectional_sequence_lstm_test for CMSIS-NN
Adds back dtln example using CMSIS-NN
Reverts "Add intermediate tensors to LSTM unit test to enable CMSIS-NN (#1996)"

BUG=#2449

Trying again with #2492 to get around the bad synch-error + additional cleanup in tensorflow/lite/micro/kernels/cmsis_nn/unidirectional_sequence_lstm.cc


a few improvement for addr_adv path manager

this pull requests implements a few improvement for the addr_adv path manager:

mptcpd can specify non 0 flags for the created endpoint, allowing egress subflow creation and/or ADD_ADDR signaling
make address notification configurable, allow filtering link locak and loopback addresses and allowing processing addresses available at daemon startup
set suitable limits for the configured endpoints

I committed changes with the following updates:

documentation and coding style updates, including const correctness and placement
type correctness, i.e. strlen() returns size_t, not int
unit test build fixes related to the move of src/configuration.h to include/mptcpd/private/configuration.h

With the unit test build fixes in place, the test suite now shows that the network monitor test crashes with a seg fault:
#0  0x00007ffff7fb9291 in handle_rtm_getaddr () from .../addr_add/lib/.libs/libmptcpd.so.1
#1  0x00007ffff7f5b6e3 in process_multi (nlmsg=0x7fffffffcbcc, netlink=0x5555555597a0) at ell/netlink.c:221
#2  can_read_data (io=<optimized out>, user_data=0x5555555597a0) at ell/netlink.c:287
#3  0x00007ffff7f59610 in io_callback (fd=<optimized out>, events=1, user_data=0x555555559810) at ell/io.c:120
#4  0x00007ffff7f587ad in l_main_iterate (timeout=<optimized out>) at ell/main.c:478
#5  0x00007ffff7f5887c in l_main_run () at ell/main.c:525
#6  l_main_run () at ell/main.c:507
#7  0x00005555555553af in main ()

Valgrind shows an Invalid read of size 1.  I'll take a closer look in the morning.
The crash doesn't happen on the master branch.


fix(WRB): fix failing tests due to web3 update

Closes #130

Maybe rebase with the PR that removes node 8 support :)


created folder for python code with stub files. updated readme

Looks good! thanks for updating the readme


Remote program may not start

I'd like to start a certain application in browser (using link like https://server/Myrtille/?__EVENTTARGET=&__EVENTARGUMENT=&server=localhost&user=user&passwordHash=hash&program=application&connect=Connect! ) without any prompts and/or other stuff, and it works until it runs to one (but usually two) problems:

Myrtille does not open the application, it opens full desktop mode.
It shows session selection dialog

Problem occurs it became reoccuring and I have to manually log off from all session in RDS-server to reinstantiate seamless connections.
Are there any options that can be used to enforce seamless connection?

There are some limitations:
https://github.com/cedrozor/myrtille/blob/master/DOCUMENTATION.md#auto-connect--start-remote-application-from-url

The start remote application from url feature only works on Windows Servers editions (starting from Server 2012) and only if the program is allowed to run (remoteApp policy). See notes and limitations.
On Windows Home Editions, there are several workarounds to start an application automatically on start. You can for example set a Group Policy or define a startup program in registry (HKey_Current_User\Software\Microsoft\Windows\CurrentVersion\Run).

A session selection dialog can be shown if you have the same user account for all sessions and if there are disconnected sessions. 2 options :

Have different accounts per users
Prevent having disconnected sessions (see https://github.com/cedrozor/myrtille/issues/362)


Add support for flow annotations

Add a flag to add flow annotations which would enable flow at the top of the file and put in some default flow type annotations like so:
// @flow

type Props = {}

class SomeClass extends PureComponent {
  constructor(props: Props) {
     super(props)
  }
}

Hi @monsonjeremy,
thanks a lot for your support 👍🏻
Yeah, this will be a great enhancement in the config file.
Now we have a lot of questions on the CLI, so I think it is better to put this option only in the configuration.
What do you think about it ?
If you want contribute, for me it's a pleasure 🙂

Hi guys,
now you can create custom templates with this tool!
Here the docs: Link
And also, you can share it with the community!!!
Here the docs: Link
Thanks a lot for your support 🏆


Net charge is not zero due to rounding

Hi,
This error is actually discovered in either GROMACs or probably as well in APBS because for neutral molecules ligpargen will actually have slightly positive or negative charges in the *gmx.itp and *.pqr files due to rounding, i.e. total net charge for molecule is + or - (0.0001 to 0.0005).  Is  there a way we can correct this in ligpargen?
See:
https://gromacs.bioexcel.eu/t/ligpargen-parameterized-ligand-for-opls-aa-m-introduces-a-non-integer-charger/428/5
https://gromacs.bioexcel.eu/t/total-charge-error-in-itp-files/486
https://gromacs.bioexcel.eu/t/ligpargen-toluene-itp-file/4023

Hey BJ,
You could change it manually just by removing/adding the charge difference to one atom of your molecule. As we are talking about tiny charge difference values it should not affect the simulation. When I will have time, I will fix it.
Thank you for your feedback, I appreciate it.
Israel

Yes @Isra3l, tiny differences so manually adjusting as we go 😄.


Automated cherry pick of #9727: fix(region): rds list with secgorups info

Cherry pick of #9727 on release/3.7.
#9727: fix(region): rds list with secgorups info

Codecov Report

Merging #9728 (5e736e1) into release/3.7 (56d583e) will increase coverage by 9.92%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.7    #9728       +/-   ##
================================================
+ Coverage         6.00%   15.93%    +9.92%
================================================
  Files              845      124      -721
  Lines           131245    12773   -118472
================================================
- Hits              7879     2035     -5844
+ Misses          122665    10547   -112118
+ Partials           701      191      -510

Flag
Coverage Δ

aFlag
15.93% <0.00%> (+9.92%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/compute/guestdrivers/apsara.go
13.63% <0.00%> (-0.65%)
:arrow_down:

pkg/compute/guestdrivers/managedvirtual.go
0.00% <0.00%> (ø)

pkg/compute/guestdrivers/utils.go
0.00% <0.00%> (ø)

pkg/mcclient/options/devtooltemplate.go

pkg/multicloud/ucloud/instance.go

pkg/compute/models/policy_assignment.go

pkg/util/fileutils2/sparse.go

pkg/compute/models/routetableresource.go

... and 642 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3b6cd...5e736e1. Read the comment docs.


Sporadic SIGSEGV  in src/unix/stream.c

I can't provide a consistent repro case for this, but I've noticed that after some thousands of reads and writes to a TCP socket stream using libuv, I encounter a segmentation fault.  Here's the backtrace from gdb:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffc67fc700 (LWP 19000)]
uv__write (stream=0x7fffb0000a90) at src/unix/stream.c:841
841	      size_t len = buf->len;
(gdb) bt
#0  uv__write (stream=0x7fffb0000a90) at src/unix/stream.c:841
#1  0x00007ffff79ae239 in uv__stream_io (loop=<optimized out>, w=0x7fffb0000b18, events=<optimized out>)
    at src/unix/stream.c:1242
#2  0x00007ffff79a604b in uv__run_pending (loop=0x852f28) at src/unix/core.c:710
#3  uv_run (loop=0x852f28, mode=UV_RUN_DEFAULT) at src/unix/core.c:316
#4  0x0000000000535a75 in ReliablePipe::run (this=0x852f20) at Pipe/ReliablePipe.cpp:231
#5  0x000000000051b99e in BasePipe::loopInit (this=0x852f20) at Pipe/BasePipe.cpp:34
#6  0x000000000051b831 in BasePipe::WorkerThread::run (this=0x855280) at Pipe/BasePipe.cpp:116
#7  0x0000000000561bae in Thread::startThread (data=0x855280) at Threads/Thread.cpp:8
#8  0x00007ffff7bc4e9a in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#9  0x00007ffff58d238d in clone () from /lib/x86_64-linux-gnu/libc.so.6
#10 0x0000000000000000 in ?? ()

From what I can, the problem is in this line:
uv_buf_t* buf = &(req->bufs[req->write_index]);
It looks like bufs is already null:
(gdb) p req-> bufs
$34 = (uv_buf_t *) 0x0
Looking through the code, it looks like req->bufs is cleared or not cleared depending on whether write succeeds.  Is it possible I'm unintentionally ignoring some error status and causing this?
Thanks for any suggestions.

What version of libuv is that?  Going by the line numbers, it's not the most recent release.
Can you try a debug build and post the output of info locals at the crash site?  Can you include the output of print *req as well?  Thanks.

I believe we're running libuv 1.3 -- I'll investigate whether we can upgrade easily.
uv__write (stream=0x7fffb8000a90) at src/unix/stream.c:841
841	      size_t len = buf->len;
(gdb) info locals
buf = 0x10
len =
iov = 0x7fffc4000ee0
q = 0x7fffc4000eb8
req = 0x7fffc4000e60
iovcnt =
n =
PRETTY_FUNCTION = "uv__write"
(gdb) print req
$1 = {data = 0x852f20, type = UV_WRITE, active_queue = {0x852f48, 0x852f48}, reserved = {0x0, 0x0, 0x0, 0x0}, cb = 0x51bb30
<BasePipe::after_standalone_write(uv_write_s, int)>, send_handle = 0x0, handle = 0x7fffb8000a90, queue = {
0x7fffb8000b60, 0x7fffb8000b60}, write_index = 1, bufs = 0x0, nbufs = 1, error = 0, bufsml = {{
base = 0x7fffc4000d60 "\355\376a", len = 103}, {base = 0x0, len = 0}, {base = 0x0, len = 0}, {base = 0x0, len = 0}}}

Libuv follows semver so an upgrade should be a drop-in replacement.
req->write_index == req->nbufs == 1 might be indicative of a bug.  Is there anywhere in your application where you close one handle when another handle errors/eofs/etc.?  I wonder if the queue manipulation in uv__run_pending() is unsound.

I updated to libuv 1.6.1,  saw the crash again.  Looks like the same basic issue (bufs is NULL)
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffc77fe700 (LWP 29192)]
uv__write (stream=0x7fffb0000a90) at src/unix/stream.c:853
853	      size_t len = buf->len;
(gdb) bt
#0  uv__write (stream=0x7fffb0000a90) at src/unix/stream.c:853
#1  0x00007ffff79af22b in uv_write2 (req=0x7fffb8002d40, stream=0x7fffb0000a90, bufs=0x7fffb8002e00, nbufs=1,
send_handle=, cb=) at src/unix/stream.c:1388
#2  0x000000000053628a in ReliablePipe::SendBinaryMessage (this=0x852f20, msg=0x7fffb8002c60 "\220&", length=205)
at Pipe/ReliablePipe.cpp:298
(gdb) info locals
buf = 0x10
len =
iov = 0x7fffb8002dc0
q = 0x7fffb8002d98
req = 0x7fffb8002d40
iovcnt =
n =
PRETTY_FUNCTION = "uv__write"
(gdb) p req
$1 = {data = 0x852f20, type = UV_WRITE, active_queue = {0x852f48, 0x852f48}, reserved = {0x0, 0x0, 0x0, 0x0}, cb = 0x51bb30
<BasePipe::after_standalone_write(uv_write_s, int)>, send_handle = 0x0, handle = 0x7fffb0000a90, queue = {
0x7fffb0000b60, 0x7fffb0000b60}, write_index = 1, bufs = 0x0, nbufs = 1, error = 0, bufsml = {{
base = 0x7fffb8002c60 "\220&", len = 205}, {base = 0x0, len = 0}, {base = 0x0, len = 0}, {base = 0x0, len = 0}}}
Thanks for the handle close idea -- I'll investigate.

Quick sanity check: there is no chance you're reusing uv_write_t structures, is there?

it doesn't appear we're reusing write_t structures
doesn't appear the stream has been disconnected by the other side before the crash (and none of the EOF / disconnect handlers are invoked)
the crash typically appears 30-45 minutes after opening the stream and sending and receiving  about 10 small messages (<500 bytes ) per second; however it sometimes appears as soon as 30 seconds
this code is running in a multithreaded environment. All direct access to the stream is wrapped in a mutex (read_start, write, etc)-- however, uv_run is not, and we're using the default run mode

Ah, that's not right. None of the APIs are thread-safe unless stated
otherwise, so calling uv_write from outside the loop thread can lead to any
kind of failure.

it doesn't appear we're reusing write_t structures
doesn't appear the stream has been disconnected by the other side
before the crash (and none of the EOF / disconnect handlers are invoked)
the crash typically appears 30-45 minutes after opening the stream and
sending and receiving about 10 small messages (<500 bytes ) per second;
however it sometimes appears as soon as 30 seconds
this code is running in a multithreaded environment. All direct access
to the stream is wrapped in a mutex (read_start, write, etc)-- however,
uv_run is not, and we're using the default run mode

—
Reply to this email directly or view it on GitHub
https://github.com/libuv/libuv/issues/425#issuecomment-119190842.

Can you clarify this?
If you have one thread driving uv_run (which blocks in the default run mode), how should one then call uv_write?

On Jul 7, 2015, at 6:27 AM, Saúl Ibarra Corretgé<EMAIL_ADDRESS>wrote:
Ah, that's not right. None of the APIs are thread-safe unless stated
otherwise, so calling uv_write from outside the loop thread can lead to any
kind of failure.

it doesn't appear we're reusing write_t structures
doesn't appear the stream has been disconnected by the other side
before the crash (and none of the EOF / disconnect handlers are invoked)
the crash typically appears 30-45 minutes after opening the stream and
sending and receiving about 10 small messages (<500 bytes ) per second;
however it sometimes appears as soon as 30 seconds
this code is running in a multithreaded environment. All direct access
to the stream is wrapped in a mutex (read_start, write, etc)-- however,
uv_run is not, and we're using the default run mode

—
Reply to this email directly or view it on GitHub
https://github.com/libuv/libuv/issues/425#issuecomment-119190842.
—
Reply to this email directly or view it on GitHub.

As a result of any other operation, such as a connection was made, data was received, a timer kicked in, etc.
None of the loop or handle APIs are thread-safe, the only exception is uv_async_send, which is used to trigger a callback in the loop thread by another thread: http://docs.libuv.org/en/v1.x/async.html?highlight=uv_async_send#c.uv_async_send

Thanks for the clarification.

@saghul , as a developer coming from *nix select/epoll background, I like to get a bit more clarification on the "single threaded network I/O " nature of libuv.
Does it means if uv_run's loop monitoring/polling a socket for anything readable, another thread CAN NOT send/write to that socket ? With Linux select or epoll, I believe that is allowed. We tried the same way with libuv. Not sure it is correct.
Our app gets sporadic  Segmentation fault. And the stack is below,
#0  0x00007f8734756818 in uv__write (stream=0x7f873401b558) at src/unix/stream.c:863
#1  0x00007f87347577bb in uv__stream_io (loop=0x7f8734969b20 <default_loop_struct>, w=0x7f873401b5e0, events=4) at src/unix/stream.c:1264
#2  0x00007f873474a365 in uv__run_pending (loop=0x7f8734969b20 <default_loop_struct>) at src/unix/core.c:733
#3  0x00007f8734749a49 in uv_run (loop=0x7f8734969b20 <default_loop_struct>, mode=UV_RUN_DEFAULT) at src/unix/core.c:333
And the *req is :
(gdb) p req
$1 = (uv_write_t *) 0x162be30
(gdb) p req
$2 = {data = 0x162ba20, type = UV_WRITE, active_queue = {0x1632990, 0x1624530}, reserved = {0x0, 0x0, 0x0, 0x0},
cb = 0x7f87349d5fb3 <UV::g_on_write_end(uv_write_t, int)>, send_handle = 0x0, handle = 0x7f873401b558, queue = {0x16329d8, 0x1624578}, write_index = 1,
bufs = 0x0, nbufs = 1, error = 0, bufsml = {{base = 0x162ba20 "5", len = 55}, {base = 0x0, len = 0}, {base = 0x0, len = 0}, {base = 0x0, len = 0}}}
Thanks in advance,
Frank

@franknj You cannot call uv_write() or uv_read_start() from a different thread than the one that calls uv_run().

@bnoordhuis , thanks for clarification. That is a big difference from select/epoll based approach.

I run into this same problem for blindly reusing the uv_write_t object.
@saghul I think it would be useful to mention in the documentation that uv_write_t should not be reused without careful memory management.

@neevek mind submitting a documentation PR?

@saghul I will do it later.
But I am still confused because I changed my code and I reuse the uv_write_t object only after uv_write_cb is called, I assume that when the callback is called, the libuv internal is done with the uv_write_t object, but it seems not, the segfault still occurs. why?

After the callback fires it should be fine to reuse it, if not, there is a bug somewhere. A test case would definitely help.

@saghul Your are right, it was a bug in my code. And I just submitted a documentation PR~


License file is missing

This repo is very useful, code is much simpler and better than some other repos which abstract away window creation. The issue is it's missing a license, and so we cannot assume the code can be used.

@melak47 Bump 🙂

Sorry, I didn't see this!
Consider this public domain, I added the CC0 license (doesn't require attribution).
If that doesn't work for you, I'm also happy to license it under MIT or whatever.


Re-indexing from a certain event_id or date

Sometimes it is necessary to re-index the default views or composite views due to failed events, new resources, etc.  Instead of re-indexing from the beginning, it would be useful to be able to re-index from a certain point in time or event_id.
Date would be potentially more helpful as we don't always know the event_id's associated with resources.

A restart after a defined offset would be useful. I'm adding this to 1.6 milestone


onSubmit is required

Is there any reason why onSubmit is required? If I am going to do a custom submission by ValidatorForm methods, I will have console errors onSubmit is required

Why not to do custom submission by onSubmit function?

When you use form, it should be submitted, right? It's designed to be submitted so you must provide onSubmit
What's the problem?

My root problem is, it is not possible to have one form inside another because the child submit also sends the parent when they click the button, because both forms have onSubmit in the form. So the child form I'm using ref and using ValidatorForm's method.
`setRef = ref => {
this.refForm = ref;
};
validationForm = event => {
if (event) {
event.preventDefault();
event.persist();
}
this.refForm.errors = [];
new Promise(resolve => {
resolve(this.refForm.walk(this.refForm.childs));
}).then(result => {
if (this.refForm.errors.length) {
this.refForm.props.onError(this.refForm.errors);
}
if (result) {
this.submitForm();
}
return result;
});
};
submitForm = () =>
this.props.sendCommission(this.props.quoteId, [this.props.record]);`
<ValidatorForm ref={ref => this.setRef(ref)}>
 <Button                 variant="contained"                 color="primary"                 type="submit"                 onClick={e => {                   this.validationForm(e);                 }}               >                 Salvar               </Button>

Can you reproduce your issue at https://codesandbox.io/s/new ?

is it possible to use nested validator form ? Because when i put one form inside another so one form submit is working so do you have any solution ?

@DeepakM02 you should avoid nested forms

Hello @DeepakM02 I managed to do this as follows, I created a gist to make it easier.
https://gist.github.com/juliohenderson/664f0433e3e96f567ed2129e5aed3e10
You will be alerted on the console that "prop onSubmit is required on ValidatorForm" but you can handle this by entering "onSubmit = () => console.log ()" or something similar

Hey @juliohenderson this shows "warning.js: Warning: validateDOMNesting(...) cannot appear as a descendant of "

@DeepakM02 you should avoid nested forms

Hello @NewOldMax If we have this type of situation that if we have form inside form(nested) and their submit trigger btn is different so how it is possible to validate both form.

@DeepakM02 you should rethink your solution, it's a bad approach, even html5 says that you shouldn't use nested forms. Of course you can do whatever you want, but it's on your risk and it's not designed for that.

@NewOldMax is right, I had the same problem and solved as I could because refactoring in my case would be very laborious and would not have time for it. @DeepakM02  I did not get this error, it may be caused by something specific you are doing.
If your work to refactor is not great, do so.

As I did, your parent form looks like the ValidatorForm documentation says to do. And the child form will look the way I did in gist. If you want to put your code in a gist for us to look at, feel free to.


Latest version(v5.1.1) not bumping the version of a project if the changes made to the dependency.

In my workspace when I am making changes to the feature  libs of my app and committing changes after that when I run target to bump the version its not increasing the version of my app. It was working fine till 4.2.x.
I have reproduced the issue in the following repro repo:
https://github.com/ak274/semver
My App project.json for version target:
"version": {
      "executor": "@jscutlery/semver:version",
      "options": {
        "preset": "angular",
        "push": true,
        "commitMessageFormat": "chore({projectName}): release version ${version} [skip ci]",
        "baseBranch": "master",
        "noVerify": true,
        "releaseAs": "prerelease",
        "trackDeps": true,
        "preid": "beta"
      }
    },

Steps to reproduce:

Make some change in the libs/demo/feature-lib 2) commit the feature with angular commit convention 3) push commit to the origin master
run version target for the demo app
it will say no changes since last release.

Expected behavior:
As I have made changes to a feature lib which is a dependency of app, It should bump the version for my app.

+1 on this...we're experiencing the same issue. Would be great if this could be fixed

Maybe I can raise my question here: would this help? https://github.com/jscutlery/semver/pull/816

The issue still exists, although a possible solution exists with #816. We would also be interested in the PR being merged. That would really help us because since the update to NX 19 our pipeline often fails.

I'd prefer not adding an extra option for that and simply track deps with prerelease.


How to open a Dialog/Modal view for onCardClick

I know that onCardClick is expecting a function, so I, naïvely, did the following:
// React class render method:
render() {
  const cardClicked = (cardId, metadata, laneId) => {
    // this works:
    console.log(cardId, metadata, laneId);
    // this not:
    return (
      <SomeModalViewComponent>

Content

      </SomeModalViewComponent>
    );
  };

  return (
  <Board onCardClick={cardClicked} />
}

It’s probably because of my still limited React understanding, but maybe someone already tried something similar (btw. good to have a wiki #187 for some usage examples)
Thanks for any help on that!

check the docs you will find onCardClick function in the props table you can use to trigger a setState of modal open/close state;

onCardClick
function
Called when a card is clicked: onCardClick(cardId, metadata, laneId)

you can do it like so:
class foo extends React.Component{
state={isOpen: false}

onCardClick = (cardId, metadata, laneId) => {
this.setState((prevState) => {
     return {isOpen: !prevState.isOpen}
});
}
  render() {
     const {isOpen} = this.state;
      return(
        <Board>
          <Modal open={isOpen} />
       </Board>
        );
     }
}

@oflarcade's suggestion should work...


Check if items exists before find

Hi @NicholasAzar i'm facing this error TypeError: items.find is not a function     at NgSelectizeComponent.onSelectizeOptionAdd (ng-selectize.umd.js:106) on this new version of ng-selectize. Here's the possible fix.

I'm going back to 1.0.11 for now until you fix this...

Included in 1.1.1


[ShadowCustom] How do I reduce the heights of the player box?

https://i.imgur.com/jSYZT3d.png
As you can see there is a lot of space between the bottom of the window and the media controls. How do I reduce this?
Not really an issue, but more of a request

Since the media controls are centered in the player bar one obvious solution is to reduce the height of the bar (which you can find at the top of the user.css).
In general to test small (or in general any) modifications you can enable dev-tools by
spicetify backup apply enable-devtool

and then right click on the application and inspect the page


Chart: change HPA api version to v2. Add chart tests

The gatekeeper-policy-manager Helm chart use a HorizontalPodAutpscaler API version of v2beta1, which was removed in Kubernetes 1.25. This PR updates the API version to v2. The v2 version became GA in Kubernetes 1.23.
This PR also adds tests of the chart using GitHub actions and KIND. I realize this is a bit of a 'big' change for a small fix, but such tests may prove valuable for future additions. Testing is done using chart-testing https://github.com/helm/chart-testing and a few test values-files have been provided - one of which enables the HPA.

Sure. I have removed the CI parts.


What is the development status of this project?

Hi, Limited to nil activity. But happy to accept PRs. Thanks.


question, dsl with method_missing and self yield

i am trying to build dsl: http://play.crystal-lang.org/#/r/jzg
is it possible to make with self yield understand method_missing?
something like ruby instance_eval(block)

I think we could make this work. At least it makes sense to work that way, if methods are first looked up in the with scope. However, the ends_with?('=') condition in your example will never be true because doing a = 1 is a local variable assignment, and then if you do self.a = 1, self is not bound to the with scope. That is, with ... yield is not like Ruby's instance_eval.

in ruby the save a = 1, would local variable, but a 1 is method call

Yes, what I meant is that there's no way to invoke a method that ends_with?('=') if you use with ... yield.


Update imports docs RE timestamps

As discussed in https://github.com/pilosa/java-pilosa/issues/163, updates timestamps to be nanoseconds in docs and adds notes warning that Pilosa will ignore other formats.

Thanks for your contribution!


@sveltejs/adapter-cloudflare v2.2.0 always triggers hooks on build

Describe the bug
Took a while to track down the cause of this, but I recently updated to adapter-cloudflare 2.2.0 and my builds started to break.
It appears a change from 2.1.0 to 2.2.0 now always triggers hooks.server.js to run, even if there are no configured prerenderable routes, which then triggers my auth middleware which redirects the user to another domain if they have no authentication cookie set (see hooks.server.js in the repro repo).
v2.1.0 works fine and I can build without the hook getting triggered by the adapter, but now in 2.2.0 it always triggers and thus breaks the build. AFAIK this means that there is no way to build for CloudFlare anymore if you have such an auth hook in place.
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-g2rzrj?file=src/hooks.server.js
Run npm run build to see the issue. Downgrade to 2.1.0 to see it go away
Logs
> Using @sveltejs/adapter-cloudflare
file:///Users/my-app/node_modules/@sveltejs/kit/src/core/postbuild/fallback.js:53
        throw new Error(`Could not create a fallback page — failed with status ${response.status}`);
              ^

Error: Could not create a fallback page — failed with status 302
    at generate_fallback (file:///Users/my-app/node_modules/@sveltejs/kit/src/core/postbuild/fallback.js:53:8)
    at async process.<anonymous> (file:///Users/my-app/node_modules/@sveltejs/kit/src/utils/fork.js:25:17)
error during build:
Error: Failed with code 1
    at ChildProcess.<anonymous> (file:///Users/my-app/node_modules/@sveltejs/kit/src/utils/fork.js:68:13)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:489:12)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)

System Info
System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M2
    Memory: 740.67 MB / 24.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.19.0 - ~/Library/Caches/fnm_multishells/80853_1678404247439/bin/node
    npm: 8.19.3 - ~/Library/Caches/fnm_multishells/80853_1678404247439/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 111.0.5563.64
    Firefox: 103.0
    Safari: 16.3
  npmPackages:
    @sveltejs/adapter-auto: 2.0.0 => 2.0.0
    @sveltejs/adapter-cloudflare: 2.1.0 => 2.1.0
    @sveltejs/kit: 1.11.0 => 1.11.0
    svelte: 3.55.1 => 3.55.1
    vite: 4.1.4 => 4.1.4

Severity
breaks production builds, no work around except downgrading
Additional Information
No response

I'm guessing this is the result of #9294.
I'm not sure what it would make sense to do about this. Can you check building from $app/environment and not apply any auth middleware in that case?

Same issue here. I am now checking with the building value, but this is a weird work around...

@Conduitry yeah, I had a feeling it was from #9294 as well based on it being the main change from 2.1.0 to 2.2.0.
I could probably do that, but as @stefandevo says, it is a weird workaround/hack. I would assume that Kit would not run my hooks if I have no pre-rendering configured anywhere. For now I'll stay on 2.1.0 but if we decide to update I'll do the suggestion you offer, thanks 👍

I have also encountered this issue, with auth middleware as well.

Same issue here.

Can you check building from $app/environment and not apply any auth middleware in that case?

This seems like the best solution for now, unless an option is added to disable generation of a 404.html from the cloudflare adapter (which rich pushed back on before when I tried to add it so i'm not sure if that would happen. Although then neither of us could think of a case where it would make sense to be disabled, I wanted it "just in case")

Instead of always generating a fallback page, I suggest that the cloudflare adapter copies over a static 404.html to the /_app/ or / root directory. The <head> of this file should include <meta http-equiv="Refresh" content="0; url='/'" /> to redirect to the root page only if visited through a browser.
The benefits of this approach are:

avoids running hooks during build.
returns 404 when requesting missing assets in /_app/*
(the original issue was that it would return /index.html and a 200 status instead of 404).
redirects users to / when navigating to a non-existent route excluded in _routes.json (causing it to bypass the worker and only look for .html files).

Although this solution still doesn't really sit right with me, I feel that it is a good compromise.

Instead of always generating a fallback page, I suggest that the cloudflare adapter copies over a static 404.html to the /_app/ or / root directory. The <head> of this file should include <meta http-equiv="Refresh" content="0; url='/'" /> to redirect to the root page only if visited through a browser.
The benefits of this approach are:
* avoids running hooks during build.

* returns 404 when requesting missing assets in `/_app/*` or routes excluded by a wildcard.
  > the original issue was that it would return `/index.html` and a 200 status instead of 404.

* redirects users to `/` when navigating to these non-existent excluded routes.
  > excluded routes in `_routes.json` bypass the Cloudflare worker and returns the page html file or nearest `index.html` / `404.html`.

Although this solution still doesn't really sit right with me, I feel that it is a good compromise.

Just redirecting to the root doesn't seem like a good solution at all to me. Instead of getting a 404 page, users would just get redirected to the root page, which almost defeats the purpose of a 404 page at all.
I feel the standard that works for most people, and matches the functionality of other adapters is better than having a different behavior that doesn't make a ton of sense for most sites. It should either be an option, or just something that should be worked around (as the workaround is pretty simple. It should probably still be documented though)

I feel the standard that works for most sites, and matches the functionality of other adapters is better than having a different behavior that doesn't make a ton of sense for most sites.

Perhaps the fallback page should also be opt-in and print a warning if it's not configured?
Rather than having it automatically generated and confusing users why their build idea failing.
Or perhaps we should wash users about their hooks whenever the fallback page generator is being called (this would benefit the static adapter as well).
In the end, it's difficult to get a breaker consistent with other adapters until cloudflare removes the 100 rule limit for the _routes.json file.

I've had to revisit this issue a couple different times since this hasn't been fixed and I keep forgetting why my sveltekit apps won't build in Pages but will locally 😞 The answer isn't explicitly here in code yet, so sharing what worked for me based on the above suggestions:
src/hooks.server.ts
// other imports here
import { building } from '$app/environment'

export async function handle({ event, resolve }) {
  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

// rest of the complex server code down here that was causing 404 page not to build

Is there a temporary work around for this for Cloudflare Pages?  I've tried downgrading to<EMAIL_ADDRESS>and using @dbradleyfl method if (building) await resolve(event), but I get the same "Error: Could not create a fallback page — failed with status 303" when deploying to Cloudflare Pages.

Is there a temporary work around for this for Cloudflare Pages? I've tried downgrading to<EMAIL_ADDRESS>and using @dbradleyfl method if (building) await resolve(event), but I get the same "Error: Could not create a fallback page — failed with status 303" when deploying to Cloudflare Pages.

It sounds like your site is still processing the hooks during build. Make sure that if building stops execution if it is building

Yup sounds like you're not returning the result of await resolve(event). The return is the important part  @figuerom16

@ ajgeiss0702 @dbradleyfl Doh!  You're correct.  I forgot the return.  Works with the newest<EMAIL_ADDRESS> Thank you much!
if (building) return await resolve(event)

I've had to revisit this issue a couple different times since this hasn't been fixed and I keep forgetting why my sveltekit apps won't build in Pages but will locally 😞 The answer isn't explicitly here in code yet, so sharing what worked for me based on the above suggestions:
src/hooks.server.ts
// other imports here
import { building } from '$app/environment'

export async function handle({ event, resolve }) {
  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

// rest of the complex server code down here that was causing 404 page not to build

You're the GOAT, for anyone having this specific problem - this is the issue. Cloudflare Pages build failing due to auth redirect on base path.
Figured i'd write it so this ranks on Google! Saved me time by putting me on to building brother - thank you!

  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

How do you add this if you're using sequence along with SvelteKitAuth?
Doesn't seem to fix my error by adding resolve(event) in the handle that handles my routes in my sequence.

  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

How do you add this if you're using sequence along with SvelteKitAuth? Doesn't seem to fix my error by adding resolve(event) in the handle that handles my routes in my sequence.
Update #7899 Found a solution to conditionally render sequence depending if we're building or not.

Do you have your source code for this?

  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

How do you add this if you're using sequence along with SvelteKitAuth? Doesn't seem to fix my error by adding resolve(event) in the handle that handles my routes in my sequence.
Update #7899 Found a solution to conditionally render sequence depending if we're building or not.

Do you have your source code for this?

export const handle = building
    ? sequence()
    : sequence(...);

  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

How do you add this if you're using sequence along with SvelteKitAuth? Doesn't seem to fix my error by adding resolve(event) in the handle that handles my routes in my sequence.
Update #7899 Found a solution to conditionally render sequence depending if we're building or not.

Do you have your source code for this?

export const handle = building
    ? sequence()
    : sequence(...);

Yeah, nice one, I ended up doing:
import { sequence } from "@sveltejs/kit/hooks";

import { building } from '$app/environment'

function optional (fn) {
  if (building) {
    return ({ event, resolve }) => resolve(event)
  }

  return fn
}

export const handle = optional(sequence())

  if (building) {
    const response = await resolve(event)
    return response // bailing here allows the 404 page to build
  }

How do you add this if you're using sequence along with SvelteKitAuth? Doesn't seem to fix my error by adding resolve(event) in the handle that handles my routes in my sequence.
Update #7899 Found a solution to conditionally render sequence depending if we're building or not.

Do you have your source code for this?

export const handle = building
    ? sequence()
    : sequence(...);

Yeah, nice one, I ended up doing:
import { sequence } from "@sveltejs/kit/hooks";

import { building } from '$app/environment'

function optional (fn) {
  if (building) {
    return ({ event, resolve }) => resolve(event)
  }

  return fn
}

export const handle = optional(sequence())

Do you see any benefits from doing one to another?

Do you see any benefits from doing one to another?

No, just a bit more readable I suppose.

Can someone sanity check https://github.com/sveltejs/kit/pull/11596 and tell me if it seems like a good fix for this?

I wanted to add to this, I got the same issue, even though I was using adapter-static
I was getting an error relating to @inlang/paraglide-js since you add a handler in the hooks.server.ts that I presume redirects the user: i18n.handle()
I had to wrap adding this to my Handle sequence like so:
const sequences: Handle[] = [];

if (!building) {
	sequences.push(i18n.handle({ disableAsyncLocalStorage: true }));
}

sequences.push(customHandle);

export const handle: Handle = sequence(...sequences);

And now it works. what I don't understand is why wrangler is giving me issues when I'm using a different adapter
I've got this function that helps me determine the correct adapter during runtime:
function getAdapter() {
	console.log('process.env.VITE_ADAPTER', process.env.VITE_ADAPTER);
	switch (process.env.VITE_ADAPTER) {
		case 'capacitor':
			return staticAdapter({
				strict: false,
				pages: 'build/capacitor',
				assets: 'build/capacitor',
				fallback: 'index.html',
			});

		case 'cloudflare-workers':
			return cloudflareWorkersAdapter();

		default:
			return adapterAuto();
	}
}

if I comment out the cloudflare-workers case (and subsequently no longer import cloudflareWorkersAdapter, I get a different error:
node:internal/event_target:1096
  process.nextTick(() => { throw err; });
                           ^
Error: Could not create a fallback page — failed with status 302

This goes way above my head lol but i'm happy to help if there's any directions

I wanted to add to this, I got the same issue, even though I was using adapter-static
I was getting an error relating to @inlang/paraglide-js since you add a handler in the hooks.server.ts that I presume redirects the user: i18n.handle()
I had to wrap adding this to my Handle sequence like so:
const sequences: Handle[] = [];

if (!building) {
	sequences.push(i18n.handle({ disableAsyncLocalStorage: true }));
}

sequences.push(customHandle);

export const handle: Handle = sequence(...sequences);

And now it works. what I don't understand is why wrangler is giving me issues when I'm using a different adapter
I've got this function that helps me determine the correct adapter during runtime:
function getAdapter() {
	console.log('process.env.VITE_ADAPTER', process.env.VITE_ADAPTER);
	switch (process.env.VITE_ADAPTER) {
		case 'capacitor':
			return staticAdapter({
				strict: false,
				pages: 'build/capacitor',
				assets: 'build/capacitor',
				fallback: 'index.html',
			});

		case 'cloudflare-workers':
			return cloudflareWorkersAdapter();

		default:
			return adapterAuto();
	}
}

if I comment out the cloudflare-workers case (and subsequently no longer import cloudflareWorkersAdapter, I get a different error:
node:internal/event_target:1096
  process.nextTick(() => { throw err; });
                           ^
Error: Could not create a fallback page — failed with status 302

This goes way above my head lol but i'm happy to help if there's any directions

I recommend creating a new discussion (instead of an issue) with a minimal reproduction. It's difficult to diagnose the root cause of your problem from your current description.

Thanks @eltigerchino I'm not sure what the discussion would be about but I've created a minimal reproducable: https://github.com/SaintPepsi/paraglide-sveltekit-example


HADOOP-19197. S3A: Support AWS KMS Encryption Context

Add the property fs.s3a.encryption.context that allow users to specify the AWS KMS Encryption Context to be used in S3A.
The value of the encryption context is a key/value string that will be Base64 encoded and set in the parameter ssekmsEncryptionContext from the S3 client.
Contributed by Raphael Azzolini
Description of PR
This code change adds a new property to S3A: fs.s3a.encryption.context\
The property's value accepts a set of key/value attributes to be set on S3's encryption context. The value of the property will be base64 encoded and set in the parameter ssekmsEncryptionContext from the S3 client.
This change was merged to trunk by the pull request https://github.com/apache/hadoop/pull/6874. This request is to merge the code change to branch-3.4.
How was this patch tested?
Tested in us-west-1 with mvn -Dparallel-tests -DtestsThreadCount=16 clean verify
I added a new test ITestS3AEncryptionSSEKMSWithEncryptionContext.
I added this property to auth-keys.xml
<property>
  <name>fs.s3a.encryption.context</name>
  <value>
    project=hadoop,
    jira=HADOOP-19197,
    component=fs/s3
  </value>
</property>

Then I executed the following tests:
mvn clean verify -Dit.test=ITestS3AEncryption* -Dtest=none

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSWithEncryptionContext
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.058 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSWithEncryptionContext
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.47 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionAlgorithmValidation
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.001 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionAlgorithmValidation
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSDefaultKey
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.425 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSDefaultKey
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionWithDefaultS3Settings
[WARNING] Tests run: 5, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 2.028 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionWithDefaultS3Settings
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSUserDefinedKey
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.46 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSUserDefinedKey
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSES3
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.86 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSES3
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3AEncryptionDSSEKMSUserDefinedKey
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.634 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionDSSEKMSUserDefinedKey
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 34, Failures: 0, Errors: 0, Skipped: 6

mvn clean verify -Dit.test=TestMarshalledCredentials -Dtest=none

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.fs.s3a.auth.TestMarshalledCredentials
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.135 s - in org.apache.hadoop.fs.s3a.auth.TestMarshalledCredentials
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0

mvn clean verify -Dit.test=ITestS3AHugeFilesEncryption -Dtest=none

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesEncryption
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.657 s - in org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesEncryption
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

I also executed the test with the following statement in my KMS key:
{
     "Effect": "Deny",
     "Principal": {
         "AWS": "*"
     },
     "Action": "kms:Decrypt",
     "Resource": "*",
     "Condition": {
         "StringNotEquals": {
             "kms:EncryptionContext:project": "hadoop"
         }
     }
}

When using that statement, tests without encryption context fail, and the new test will pass only if the given key-pair is set in fs.s3a.encryption.context.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[-] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 8 new or modified test files.

_ branch-3.4 Compile Tests _

+0 :ok:
mvndep
4m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
39m 37s

branch-3.4 passed

+1 :green_heart:
compile
17m 45s

branch-3.4 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 52s

branch-3.4 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
5m  4s

branch-3.4 passed

+1 :green_heart:
mvnsite
2m 45s

branch-3.4 passed

+1 :green_heart:
javadoc
1m 57s

branch-3.4 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

branch-3.4 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
3m 59s

branch-3.4 passed

+1 :green_heart:
shadedclient
34m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
17m 31s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 31s

the patch passed

+1 :green_heart:
compile
16m 57s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
16m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 18s

the patch passed

+1 :green_heart:
mvnsite
2m 39s

the patch passed

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
4m 18s

the patch passed

+1 :green_heart:
shadedclient
34m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 43s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  4s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

254m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7193/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux 2bab37f2f2c0 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.4 / a89d77b4422f8efbcf013945936c39f2ff423bf5

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7193/1/testReport/

Max. process+thread count
1251 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7193/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran, I just finished running the integration tests and updated the description. The PR should be good to merge, and then we can close the JIRA.
Thank you!

did you have to make any changes for the backport? if so, what?
That's all I need to know before approval.


Fix dark/light mode problem with sponsor logos + thank Namespace

Namespace is providing free, buff CI runners for fluke, I want to have their logo in there.
The logos for Shopify & fly are transparent, but that doesn't work with GitHub's light mode.

Closed by #180


PyAudio installation instructions for OS X are out of date

As a prerequisite to installing PyAudio on OS X, the readme says to install PortAudio with the command brew install portaudio && sudo brew link portaudio. Homebrew >= 1.1.0 doesn't allow itself to run as root, and when I run brew link portaudio without sudo, Homebrew says that it's already linked, so I'm thinking the command can be changed to just brew install portaudio.

Thanks @jdanford - as I test mainly on Linux, bug reports about these sorts of issues are highly welcome!
This is now fixed in 1953884f33f1c72eaec2776333dc7771a9cfdb12, and a new release will be out pretty soon.


PAYGPrice meaning does not match reality and does not consider Spot VMs scenarios

The PAYGPrice column is said to be

the list price for a given product or service that is determined based on the customer agreement. For customers who have an Enterprise Agreement, the pay-as-you-go price represents the EA baseline price.

However, when querying the Cost Details API, the returned CSVs have 0 for PAYGPrice for all records but Spot VMs usage ones, i.e., all usage entries for which PricingModel column is Spot, PAYGPrice has a value greater than 0. For all the other pricing models, PAYGPrice is 0, even if the unit price is greater than 0. This does not match the definition in this document, as it creates the expectation that all the cost detail records with a unit price greater than 0 should have a PAYGPrice value greater than 0 as well.
Furthermore, does the definition of PAYGPrice consider the Spot VM usage scenario? In this case, shouldn't PAYG price be the price customers would pay if the VM was consumed as a Standard VM (instead of a Spot VM)? I am not sure my interpretation is correct and therefore the document should make it clear.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 20772777-f8e9-54de-0a6f-315566f91fe7
Version Independent ID: 71da316d-cdd9-9afe-99c7-fb54d9fe8dbd
Content: Ingest cost details data - Microsoft Cost Management
Content Source: articles/cost-management-billing/automate/automation-ingest-usage-details-overview.md
Service: cost-management-billing
Sub-service: cost-management
GitHub Login: @bandersmsft
Microsoft Alias: banders

@helderpinto
Thanks for your feedback! We will investigate and update as appropriate.

@bandersmsft, could you please share your thoughts on this issue. Thank you.

@AnuragSingh-MSFT @helderpinto I'm investigating this with the Cost Management API PM. When I have info to share, I'll reply here.

https://github.com/MicrosoftDocs/azure-docs-pr/pull/219798

@helderpinto
Hi there, sorry for the delay.
The Cost Details API was recently updated so that the PAYGPrice is now accurate (no longer be zero).

Keep in mind that PAYGPrice is populated only for 1st party Azure usage charges where Pricing Model is OnDemand. So for EA customers, PAYGprice won’t be populated when Pricing Model = Reservations, Spot, Marketplace, or SavingsPlan.

And yes, PAYG price is the price customers pay if the VM was consumed as a Standard VM, instead of a Spot VM.

To address your questions and add clarity for others, I’ve updated the article for the two points above.
#please-close


Addition of apocryphal books

Hello, first of all, have a happy new year and thank you for this beautiful project!
Man, it would be interesting if this project had apocryphal books along with the canonical books. That way it would be more inclusive and serve more Christian programmers.
This is just a suggestion...

Sorry I just don't have the motivation to do this. Closing for now.


Add support for request options for runQuery

As discussed in https://github.com/mikemintz/react-rethinkdb/issues/45 I want to support options for runQuery method, like we have for original run function from docs - https://rethinkdb.com/api/javascript/run/

Looks great, thanks for adding this!

@mikemintz Could you publish npm package again? Looks like this change is not in npm.

Done, it should be published as 0.6.1

Thanks


Editing builder pattern

I am noticing an overlap with how commands are structured for editing. It would be nice to have a builder pattern where we can tack on the different options in terms of edit configurations.
Desired functionality is to be able to tack onto the ffmpeg cmd as needed:

playback speed
overlay size
watermarks
etc.

instead of building entirely new functions for each individual optoins

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Calling enum's nonexisting method causes a crash

Godot version
v4.0.alpha8.official [cc3ed63af]
System information
Windows 10, OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
Trying to use enum name as something that has methods, crashes Godot:

Steps to reproduce
extends Node2D

enum Foo {abc, def}

func _ready():
	Foo.garbage()

Minimal reproduction project
No response

ERROR: Condition "!method" is true. Returning: false
   at: is_builtin_method_vararg (core/variant/variant_call.cpp:1165)
ERROR: Condition "!method" is true. Returning: 0
   at: get_builtin_method_argument_count (core/variant/variant_call.cpp:1091)
ERROR: Condition "!method" is true. Returning: Variant::NIL
   at: get_builtin_method_return_type (core/variant/variant_call.cpp:1144)
ERROR: Condition "!method" is true. Returning: nullptr
   at: get_validated_builtin_method (core/variant/variant_call.cpp:1077)

#0  0x0000000000000000 in ?? ()
#1  0x0000000003641558 in GDScriptFunction::call (this=0xdc5d030, p_instance=0xc737410, p_args=0x7fffffffd5e8, p_argcount=1, r_err=..., p_state=0x0) at modules/gdscript/gdscript_vm.cpp:1981
#2  0x0000000003531edf in GDScriptInstance::callp (this=0xc737410, p_method=..., p_args=0x7fffffffd5e8, p_argcount=1, r_error=...) at modules/gdscript/gdscript.cpp:1543
#3  0x0000000004de94bc in Node::_gdvirtual__process_call<false> (this=0xdc7ba90, arg1=0.14650733333333332) at scene/main/node.h:235
#4  0x0000000004dcc019 in Node::_notification (this=0xdc7ba90, p_notification=17) at scene/main/node.cpp:56
#5  0x00000000028a5112 in Node::_notificationv (this=0xdc7ba90, p_notification=17, p_reversed=false) at scene/main/node.h:45
#6  0x0000000006dcc28f in Object::notification (this=0xdc7ba90, p_notification=17, p_reversed=false) at core/object/object.cpp:847
#7  0x0000000004e0c0cb in SceneTree::_notify_group_pause (this=0xd9d6de0, p_group=..., p_notification=17) at scene/main/scene_tree.cpp:862
#8  0x0000000004e0a33c in SceneTree::process (this=0xd9d6de0, p_time=0.14650733333333332) at scene/main/scene_tree.cpp:453
#9  0x000000000245800f in Main::iteration () at main/main.cpp:2739
#10 0x000000000240c874 in OS_LinuxBSD::run (this=0x7fffffffda60) at platform/linuxbsd/os_linuxbsd.cpp:441
#11 0x0000000002407ab2 in main (argc=2, argv=0x7fffffffdf78) at platform/linuxbsd/godot_linuxbsd.cpp:68

==37239== Jump to the invalid address stated on the next line
==37239==    at 0x0: ???
==37239==    by 0x3531EDE: GDScriptInstance::callp(StringName const&, Variant const**, int, Callable::CallError&) (gdscript.cpp:1543)
==37239==    by 0x4DE94BB: bool Node::_gdvirtual__process_call<false>(double) (node.h:235)
==37239==    by 0x4DCC018: Node::_notification(int) (node.cpp:56)
==37239==    by 0x28A5111: Node::_notificationv(int, bool) (node.h:45)
==37239==    by 0x6DCC28E: Object::notification(int, bool) (object.cpp:847)
==37239==    by 0x4E0C0CA: SceneTree::_notify_group_pause(StringName const&, int) (scene_tree.cpp:862)
==37239==    by 0x4E0A33B: SceneTree::process(double) (scene_tree.cpp:453)
==37239==    by 0x245800E: Main::iteration() (main.cpp:2739)
==37239==    by 0x240C873: OS_LinuxBSD::run() (os_linuxbsd.cpp:441)
==37239==    by 0x2407AB1: main (godot_linuxbsd.cpp:68)
==37239==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

I think this is the same crash I was getting when i did a typo in Image.FORMAT_RGBAF.

Just added a fix for this one in #69590 :)


📎 Implement biome lint --summary

Description
See rome#4747 for some context.
biome lint --summary should print a summary which allows figuring out which rule raised diagnostics and how many.
$ biome lint --summary src

Rule name                          Diagnostics
nursery/useNamingConvention        2509
style/useSingleCaseStatement       2000
...

The summary should avoid unnecessary works (no need to call diagnostic and action on the rules).
We could suggest using --summary when the number of diagnostics exceeds max-diagnostics:
$ rome lint src
...
src/services/types.ts:1121:5 lint/nursery/useNamingConvention ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ This property name should be in camelCase.

  > 1121 │     InsertSpaceAfterConstructor?: boolean;
         │     ^^^^^^^^^^^^^^^^^^^^^^^^^^

  ℹ The name could be renamed to `insertSpaceAfterConstructor`.

The number of diagnostics exceeds the number allowed by Biome.
Diagnostics not shown: 7564.
Checked 657 file(s) in 3s
Skipped 2 file(s)

Run `biome lint --summary src` to print a summary of the rules that emitted diagnistics.

How would someone understand which diagnostics are errors and which ones are warnings?

The severity is set at the rule level? It could infer which one is an error using the rule name? We could also use a distinct color in the summary? For instance coloring the number f diagnostics in red for errors and orange for warnings.

The severity of the rules is set at configuration level.
I was trying to figure out if we can come up with a different output, because the proposed one doesn't distinguish between errors and warnings.
So, we should first be on the same page. Diagnostic is a generic term, while error/warning is a specific term.
Colours is a good suggestion, but it won't in terminals that don't support colors, and in cases where users might need to scrap the output of the CLI.

@Conaclos question:
Should --summary keep the log that says "Checked 11 file(s) is 4ms"?

Should --summary keep the log that says "Checked 11 file(s) is 4ms"?

I don't see any issue to keep it.

By the way, I wonder if we should propose a common feature for both the summary and the structured output proposals. Instead of providing a _--summary flag, we could have a --format suumary. In this case, we should omit the header and lines such as Checked 11 file(s) is 4ms. The output could be tab-or space- separated (this composes well with UNIX programs).

What do you think about --report instead?
In the future, I can see something like this:
biome check --report=summary,json

And Biome will emit:

a summary to stderr
json to stdout

And even
biome check --report=summary,json,junit --report-to-file

And Biome will:

a summary to stderr
json report to file
junit report to file

What do you think about --report instead?

I think it is a better name. --report or --reporter? Not sure.
Have you some use case for allowing several reporters at the same time?
I am not fond of the mix of behavior (reporting on stderr / stdout / file). I think we should choose between stderr or stdout?
For a first version, I think we can skip emitting a file. We could later add an option such as --report-file and guess the reporter type based on the file extension (this could not apply for summary, a user could be explicit using the --report option).

I am not fond of the mix of behavior (reporting on stderr / stdout / file). I think we should choose between stderr or stdout? Maybe stdout?

stderr for printing human readable messages, and stdout is used to print machine readable messages.
We can remove the file for now, it was just a future idea and not related to this issue. Although, reporting on both stream is actually a thing.

stderr is used for printing human readable messages, and stdout is used to printing machine readable messages.

You are right.
Even if summary is human-readable (at some extent), it should also be machine-readable.
So, I think we can stick for stdout :)

Saving the report would be a very cool feature! We could organize annotations in our repository, like we do now with the eslint report and this action https://github.com/ataylorme/eslint-annotate-action - it's very convenient

Is there a plan to eventually have HTML reporter?  (like https://eslint.org/docs/latest/use/formatters/#html) or supporting things like https://www.npmjs.com/package/eslint-formatter-gitlab (to be used on GitLab)

What do you think of this UI @Conaclos ?
     Running `target/debug/biome check<EMAIL_ADDRESS><EMAIL_ADDRESS>--reporter=summary --max-diagnostics=100`
Summarised report of diagnostics by file.

▶<EMAIL_ADDRESS>     The file isn't formatted.

     Some lint rules were triggered

     Rule Name                                                         Diagnostics
     lint/suspicious/noImplicitAnyLet                                  6
     lint/suspicious/noDoubleEquals                                    3
     lint/suspicious/noRedeclare                                       5
     lint/suspicious/noDebugger                                        11

▶<EMAIL_ADDRESS>     The file isn't formatted.

     Some lint rules were triggered

     Rule Name                                                         Diagnostics
     lint/suspicious/noImplicitAnyLet                                  6
     lint/suspicious/noDoubleEquals                                    3
     lint/suspicious/noRedeclare                                       5
     lint/suspicious/noDebugger                                        11

Checked 2 files in 25ms. No fixes needed.
Found 54 errors.
check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Some errors were emitted while running checks.

The word "Diagnostics" is dimmed, a bug in my code. I plan to rendering as "Rule Name"

Pretty nice :) Actually I was thinking of a general summary. However, I can see the interest for a file-based summary. Maybe we could add a general summary at the end?
Also:

I think we should remove Some lint rules were triggered because doesn't add so much value. We could rename Rule Name to Triggered lint rule.
I could remove the underline (this draws too much attention).
We could reduce a bit the spacing between the two columns
The file isn't formatted. and The file is formatted. are hard to distinguish. I am not sure how this can be improved.
Is it normal to get an error at the end?

Maybe we could add a general summary at the end?

Can you be more specific?

I am the author of eslint-interactive. It is a tool that assists in correcting a large number of errors in ESLint. I would like to share my knowledge with you to help you resolve this discussion.

https://github.com/mizdra/eslint-interactive

When eslint reports many errors, there are usually errors in many files. Therefore, if we summarize the errors by file, the output could be huge. It is not a good idea to summarize errors by file. Also, users often want to turn off rules that produce many errors. I think it would be nice to be able to display a summary for each rule to assist with this.
eslint-interactive also outputs the number of fixable problems. It would help users to identify rules that can be easily fixed with eslint --fix. In Biome, I think it would be good to output the number of safe fixes and unsafe fixes.

Can you be more specific?

▶<EMAIL_ADDRESS>  The file isn't formatted.

  Triggered lint rule                                   Diagnostics
  lint/suspicious/noImplicitAnyLet                      3

▶<EMAIL_ADDRESS>  The file isn't formatted.

  Triggered lint rule                                   Diagnostics
  lint/suspicious/noImplicitAnyLet                      2
  lint/suspicious/noDoubleEquals                        3

▶ General summary
  Some files arn't formatted.

  Triggered lint rule                                   Diagnostics
  lint/suspicious/noImplicitAnyLet                      5
  lint/suspicious/noDoubleEquals                        3

When eslint reports many errors, there are usually errors in many files. Therefore, if we summarize the errors by file, the output could be huge. It is not a good idea to summarize errors by file. Also, users often want to turn off rules that produce many errors. I think it would be nice to be able to display a summary for each rule to assist with this.

Yes this was my first intention for the summary reporter: displaying how much a rule is triggered to assist the dev in enabling/disabling rules.
However, Biome is not currently able to output a summary for every file, this is what ESlint is doing by default. Maybe we should provide two reporters? summary and file-summary?

I think something is missing here. The idea is to have --summary available for each command (check does linting too), so other than linting we should think about the other commands and how to report them.
I think there's too much focus on the "lint rule", but the focus should be on diagnostics.

OK, I believe I landed something nice to see and informative, and that makes sense.
Formatter and Organize imports report the files that require changes, while linting groups everything by diagnostic category. We also break down errors, warnings, and information (this is for the near future).


How can I use WebDriverManager in Docker?

QAF Version

3.1.0

Expected behavior
It should support WDM with Docker with the latest version of WDM.
Reference: https://bonigarcia.dev/webdrivermanager/

The provided information is not enough to understand problem. However below are the steps you can follow:

Disable default behavior by setting manage.driver.executable=false
Use driver listener to setup driver manager. Refer example form  https://github.com/qmetry/qaf/issues/370#issuecomment-891169671 and driver listener

WebDriverManager 5 is the ability to create browsers in Docker containers out of the box. The requirement to use this feature is to have installed a Docker Engine in the machine running the tests. To use it, we need to invoke the method browserInDocker() in conjunction with create() of a given manager. This way, WebDriverManager pulls the image from Docker Hub, starts the container, and instantiates the WebDriver object to use it. The following test shows a simple example using Chrome in Docker:
WebDriver driver;
WebDriverManager wdm = WebDriverManager.chromedriver().browserInDocker();

@BeforeEach
    void setupTest() {
        driver = wdm.create();
    }

    @AfterEach
    void teardown() {
        wdm.quit();
    }

Currently, there are two commands need to be executed,
docker run -d -p 4444:4444 --shm-size="2g" selenium/standalone-chrome:93.0
docker run -it --rm -v "$PWD":/usr/src/mymaven -v "$HOME/.m2":/root/.m2 -v "$PWD/target:/usr/src/mymaven/target" -w /usr/src/mymaven maven:3.8.2-openjdk-8 mvn test -Ddriver.name=chromeRemoteDriver -Dremote.server=<local_ip_address>
Here, you must have to pass <local_ip_address> and the driver will be RemoteWebDriver.


Mpu.exe(0.6.5) results in an error in the Mac environment

Mac environment:
OS X Yosemite(10.10.5)
Command:
mono ~/msgpack-cli/tools/mpu/bin/mpu.exe -h
Output of mpu.exe:
WARNING: The runtime version supported by this application is unavailable.
Using default runtime: v4.0.30319
MessagePack for Unity Utility ver. 0.6.5
....
Exit code:
0: success
1: help is shown
2: invalid arguments
0x57-0xFE: other errors
0xFF: other errors its hresult is gerator than 0xFE
What is runtime to be concrete?
I want to make the following command.
mono ~/msgpack-cli/tools/mpu/bin/mpu.exe -l -o <~/****>
**** is any hierarchy.
However, the output is following:
System.IO.FileNotFoundException: Could not load file or assembly 'MsgPack, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=a2625990d5dc0167' or one of its dependencies.
File name: 'MsgPack, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=a2625990d5dc0167'
at mpu.Program.Main (System.String[] args) [0x00000] in :0
Thanks,

Did you put MsgPack.dll in the ~/msgpack-cli/tools/mpu/bin/ directory? It looks that mono cannot prove the dll.

Thank you.
I understand.
But the next problem has occurred.
Output of mpu.exe:
System.IO.DirectoryNotFoundException: Could not find a part of the path "/Users/MyAccount/src/MsgPack.Unity3D/MsgPack.Unity3D.csproj".
at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean anonymous, FileOptions options) [0x00000] in :0
at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, System.String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost) [0x00000] in :0
at (wrapper remoting-invoke-with-check) System.IO.FileStream:.ctor (string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int,System.IO.FileOptions,string,bool,bool,bool)
at System.IO.StreamReader..ctor (System.String path, System.Text.Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean checkHost) [0x00000] in :0
at System.IO.StreamReader..ctor (System.String path, System.Text.Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize) [0x00000] in :0
at System.IO.StreamReader..ctor (System.String path, Boolean detectEncodingFromByteOrderMarks) [0x00000] in :0
at System.IO.StreamReader..ctor (System.String path) [0x00000] in :0
at (wrapper remoting-invoke-with-check) System.IO.StreamReader:.ctor (string)
at mpu.AssetFileImporter.ParseProjectFile (System.String filePath) [0x00000] in :0
at mpu.AssetFileImporter.AssembleAssetTree (System.String sourceProjectPath, System.String outputDirectoryPath) [0x00000] in :0
at mpu.Program.BuildAssetLibrary (System.String sourceProjectPath, System.String outputDirectoryPath, Boolean overwrite) [0x00000] in :0
at mpu.Program.Execute (IEnumerable`1 args) [0x00000] in :0
at mpu.Program.Main (System.String[] args) [0x00000] in :0
So I was run command in the src directory.
System.IO.FileNotFoundException: ./src/MsgPack.Unity3D/..\MsgPack.Unity3D.Full\CorLibOnlyHelper.cs does not exist
File name: './src/MsgPack.Unity3D/..\MsgPack.Unity3D.Full\CorLibOnlyHelper.cs'
at System.IO.File.Copy (System.String sourceFileName, System.String destFileName, Boolean overwrite) [0x00000] in :0
at mpu.AssetFileImporter.AssembleAssetTree (System.String sourceProjectPath, System.String outputDirectoryPath) [0x00000] in :0
at mpu.Program.BuildAssetLibrary (System.String sourceProjectPath, System.String outputDirectoryPath, Boolean overwrite) [0x00000] in :0
at mpu.Program.Execute (IEnumerable1 args) [0x00000] in <filename unknown>:0    at mpu.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0  PCA-250:msgpack-cli b06289$ mono ./tools/mpu/bin/mpu.exe -l -o ~/MsgTest WARNING: The runtime version supported by this application is unavailable. Using default runtime: v4.0.30319 System.IO.FileNotFoundException: ./src/MsgPack.Unity3D/..\MsgPack.Unity3D.Full\CorLibOnlyHelper.cs does not exist File name: './src/MsgPack.Unity3D/..\MsgPack.Unity3D.Full\CorLibOnlyHelper.cs'   at System.IO.File.Copy (System.String sourceFileName, System.String destFileName, Boolean overwrite) [0x00000] in <filename unknown>:0    at mpu.AssetFileImporter.AssembleAssetTree (System.String sourceProjectPath, System.String outputDirectoryPath) [0x00000] in <filename unknown>:0    at mpu.Program.BuildAssetLibrary (System.String sourceProjectPath, System.String outputDirectoryPath, Boolean overwrite) [0x00000] in <filename unknown>:0    at mpu.Program.Execute (IEnumerable1 args) [0x00000] in :0
at mpu.Program.Main (System.String[] args) [0x00000] in :0
Do you need "msgpack-cli root path" to mpu.exe?
Do you have that option?
Thanks,

Sorry, it is bug. I'll fix it soon.

Thank you.
It was confirmed Modify.
We have confirmed the success of the source of the Import and build.


lib.path.append: init

Description of changes
This function can be used to append strings to Nix path values in a safe way, it's like <path> + ("/" + <string>) but safer. Relates to other work in the path library effort.
This work is sponsored by Antithesis :sparkles:
Things done

[x] Wrote documentation
[x] Added and ran unit tests

Made some minor changes to the documentation. Using "path value type" when it could be ambiguous or being more precise is useful. And I'm not using any markdown syntax in the docs because it's not rendered at all. I looked into it a bit, but it's not very trivial to get it to render.

I'm not using any markdown syntax in the docs because it's not rendered at all.

I think it's fine to write markdown even if it's not rendered, but for now it really doesn't matter.

I'm not using any markdown syntax in the docs because it's not rendered at all.

I think it's fine to write markdown even if it's not rendered, but for now it really doesn't matter.

I guess a good policy for now is: "Use markdown syntax when it doesn't make it significantly harder to read without being rendered". I'm using that here now

Now consistently using isValid and newlines in errors for all path library functions now, also added argument documentation.

Now even more consistency with the other PRs. I think this is ready to be merged

@roberth Does it also look good to you? If so I'd appreciate a mergin :)


Use Opportunity ID in WordPress when making API calls to Laravel for job application

Describe the task
Right now, when someone applies on a job application, the API calls happens from WordPress to the Portal. The portal matches the job title in the API payload and based on that it creates job application entry for that candidate. There are some cases when there is no job title in the payload or when job title is changed/not-matched, then the job application doesn't get created.
Expected behavior

When a new opportunity is created in Portal, it should also be created in WordPress
There should be a hidden field in WordPress that will store the ID of the opportunity
The WordPress application must use this hidden ID when sending an application entry to Portal via API
The Portal should use the hidden ID to match the job title for the application when creating it

The  issue is not fixed

Accessed  https://uat.coloredcow.com/career/laravel-developer/

Applied for Laravel position
Refer  screenshot

Accessed https://uat.employee.coloredcow.com/hr/recruitment/opportunities

No application received on portal for laravel developer
Refer screenshot

In Portal 3.0, this should be a design input while working on the wireframes (https://www.figma.com/file/gJCPw8u34no6EACL3wrtCO/CC-Careers?type=design&node-id=531-567&mode=design&t=UYH3wfNS01lZTZlz-0)
@deepakbarmola


Server 2012 R2 Compatibility

The 'FriendlyName' parameter is not available for the 'New-SelfSignedCertificate' command in Windows Server 2012 R2. The workaround is to create the certificate without a FriendlyName and add it in a subsequent call.

Thanks!


Review how vizarr works as of recent switch from zarr.js to zarrita.js

The obvious question is whether a patch similar to https://github.com/gzuidhof/zarr.js/pull/151 would be needed for zarrita.js as well.

In #15 I've added the changes for using the newer vizarr version, that also switched from npm to pnpm. It looks that it is mandatory to use pnpm to build the package. I suggest to install it using npm install -g pnpm.
Moreover the vizarr output folder is now called dist and not out. I've updated the information on the README.

No further activity needed on this one, for the moment. We are aware that the error message may be suboptimal - as described above.


Bower

I know it's very minor, but in the readme.md installation paragraph the bower instruction is inaccurate.
"bower install scrollify"
instead of
"bower install Scrollify"
Sorry for troubling.

Saved me from spending time finding a solution haha +1

Thanks for spotting this @lisek1989 . Fixed now by @afrastgeek


Return version: 3 as string for Vercel preset

For the Vercel Build Output API v3, the config.json file "version" field needs to be a Number, not a String.

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Fixed in https://github.com/unjs/nitro/commit/f476cfc3e33d0b759e604ff6c0c61ea272e1379a for both presets and released. Sorry made change so fast :)


Flight booking error - My Bids

Flight booking error.
I double click to book a flight.
I check My Bids and the flight is booked twice.
There is no button to delete the booked flight.
https://subefotos.com/ver/?84b72d96e244eb66f92497bfe2f2d9feo.jpg

The link doesn't work
On Fri, Aug 9, 2019, 5:50 AM jftejeiro<EMAIL_ADDRESS>wrote:

Flight booking error.
I double click to book a flight.
I check My Bids and the flight is booked twice.
There is no button to delete the booked flight.
https://subefotos.com/ver/?84b72d96e244eb66f92497bfe2f2d9feo.jpg
http://url
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nabeelio/phpvms_v2/issues/141?email_source=notifications&email_token=AAAYLGFYVKJGSU55FY7VPNDQDU4YFA5CNFSM4IKSN4P2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HELOJZQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYLGCTLMCYD765HM6GVWLQDU4YFANCNFSM4IKSN4PQ
.


Closing MetaMask Popup Should Do Something

Currently the user has to know to look at their metamask icon on the top right if they accidentally close the popup. We can't tell if they close the popup; because ethereum.enable() doesn't return.
Instead what we can do is if we've waited a few seconds and they haven't clicked anything, we can show an icon that points to their metamask location in the top right. Or have some glowing effect coming from that corner.

Is this still an issue with the move to migration repo?

Subsumed under 200