pytrees in jax.experimental.loops.Scope

It would be nice to use pytrees in jax.experimental.loops.Scope as part of the loop state. Right now, I'm using jax.lax.fori_loop, which supports pytrees.
This would be helpful for complex recurrences such as autoregressive inference.
import jax
import jax.experimental.loops

# This works:
def fib_array(n):
  with jax.experimental.loops.Scope() as s:
    s.x, s.y = 0, 1
    for _ in s.range(n):
      s.x, s.y = s.y, s.x + s.y
    return s.x
assert fib_array(10) == 55

# This does not:
def fib_pytree(n):
  with jax.experimental.loops.Scope() as s:
    s.xy = 0, 1
    for _ in s.range(n):
      x, y = s.xy
      s.xy = y, x + y
    return s.fib[0]
assert fib_pytree(10) == 55

Yes, this seems worth doing. Most of the code in loops.py is compatible with pytrees, but start_tracing_body and end_tracing_body both assume that each value in the state is an array.
(cc @j-towns for "autoregressive inference" and @gnecula for experimental.loops)

jax.experimental.loops is long gone. Closing as stale.


Print messages that fail to parse in the intended channel.

Messages that fail to parse are silently lost (and end up in slack-debug). These should be printed with no formatting and the user informed that there was an error.

added here: https://github.com/rawdigits/wee-slack/commit/6bb94b8b4b602fcc63066a5887576fe204503d39


In character sheet, split special senses with semi-colon

Originally in GitLab by @CDeenen
On the attributes page of the character sheet you can add custom attributes with the 'special' field such as for languages, damage immunities, etc.
For pretty much all of these, you can split multiple attributes with a semi-colon, however, this does not work for 'Senses'. Could this be added?

Hey I can work on this issue.


how to add model persistance to this spam filter using pickle

can anyone please suggest me how to add pickling (model persistance) to this spam filter. thanks in advance :)

Hi @vanipolnedi ,
Thanks for the request, I think we should be able to add this.  Were you set on using pickle?  Pickle tends to be very very sensitive to python versions and pickle versions (and object versions).  I think it would be better to create some TensorFlow model objects for loading after training.  I can get started on that this weekend.  Are you set on pickle?  I think the TensorFlow saving operation is a bit better.

@nfmcclure thank you for the reply. it will be very useful for us if u add pickling to the spam filter ( which uses rnn)


[docs] use versionadded, versionchanged and deprecated directive

📚 Documentation
Use .. versionadded::, .. versionchanged:: and .. deprecated:: directive, so that user knows which features are added / changed / deprecated in which version and they can navigate the docs easily without changing the docs from version to version.
Ref: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded
One thing to aware is that Lightning releases every week and every week contains a bug fix. So after 2 minor releases, we can have at most 8 .. versionchanged:: which can bloat the docs.
What do you think?

Reopened


Feature Request: inverse function for resolve

Hey there 👋
first off, thanks for all the work you've done on this package, it's awesome!
I would like to request a feature: allow to verify if a given path, e.g. /api/foobar/123 matches a pathname from the OpenAPI specification, e.g. /api/foobar/{id}. It would be the inverse to resolve.
Does this make sense?

Hi @christian-bromann,

first off, thanks for all the work you've done on this package, it's awesome!

Thanks a lot mate!

I would like to request a feature: allow to verify if a given path, e.g. /api/foobar/123 matches a pathname from the OpenAPI specification, e.g. /api/foobar/{id}. It would be the inverse to resolve.

I think this has broader context and is might related to overall concrete URI Reference matching against the path templates. We need to design an API that would satisfy your simple usecase but would allow to do the more complex matching and handle ambiguities:
OpenAPI 3.1.0 spec reference:

From that we can extract following predicates:

isIdentical(pathTemplate1: string, pathTemplate2: string): boolean
isAmbiguous(pathTemplate1: string, pathTemplate2: string): boolean

Now these predicates still doesn't solve your request, we need additional match function for that:
match('/pets/mine', [
 '/pets/{petId}',
 '/pets/mine'
]); => '/pets/mine'

Your case can be specialized into:
match('/pets/mine', [
 '/pets/{petId}',
]); => '/pets/{petId}'

NOTE: the function will return null if no matches are found

I have to think about this a bit more, but feel about right.

Started to work on this - I've introduced isIdentical predicate in https://github.com/swaggerexpert/openapi-path-templating/pull/157. I'll work progressively on the matching topic and will introduce it in layers.


Duplicate {{release}}-test configmaps

This caused me an issue today when upgrading the install via helm, there are 2 grafana-agent-test configmap.  Unlucky for me the normal configmap overrode the one in the helm hook leaving the hook pod without a volume to mount:
https://github.com/grafana/k8s-monitoring-helm/blob/main/charts/k8s-monitoring/templates/hooks/grafana-agent-config-test.yaml#L47
https://github.com/grafana/k8s-monitoring-helm/blob/main/charts/k8s-monitoring/templates/tests/test.yaml#L122

Thanks for this. I just opened this PR, which should fix it: https://github.com/grafana/k8s-monitoring-helm/pull/208
It also actually cleans things up a bit, protecting against names that might get too long, as well as consolidating the config validator into a single hook job, rather than spawning two for metrics and logs.


Error in localrule MAGContigNames

Hi @dportik  ,
I have an issue concerning the MAGContigNames rule. It is the same one that the issue #84 , but the author solved it without any explanation..  And so, the 8-summary is empty. I have :
grep -h '>' /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/8-summary/asm/MAGs*.fa | cut -d'>' -f2 1> /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/2-bam/asm.MAG_contigs.txt 2> /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/logs/asm.MAGContigNames.log
[Thu Sep 26 10:03:15 2024]
Error in rule MAGContigNames:
    jobid: 29
    input: /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/8-summary/asm/asm.HiFi_MAG.summary.txt, /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/8-summary/asm/MAGs
    output: /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/2-bam/asm.MAG_contigs.txt
    log: /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/logs/asm.MAGContigNames.log (check log file(s) for error details)
    shell:
        grep -h '>' /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/8-summary/asm/MAGs*.fa | cut -d'>' -f2 1> /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/2-bam/asm.MAG_contigs.txt 2> /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/logs/asm.MAGContigNames.log
        (one of the commands exited with non-zero exit code; note that snakemake uses bash strict mode!)

The /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/8-summary/asm/MAGs*.fa does not exist, which explains why the grep command failed.
I suspect something wrong with the previous GTDBTk rules, but the logs/asm.GTDBTkAnalysis.log file is without error :
[2024-09-26 09:39:56] INFO: GTDB-Tk v2.1.1
[2024-09-26 09:39:56] INFO: gtdbtk classify_wf --batchfile /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/6-checkm2/asm/asm.GTDBTk_batch_file.txt --out_dir /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/ -x fa --prefix asm --cpus 8
[2024-09-26 09:39:56] INFO: Using GTDB-Tk reference data version r207: /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/release207_v2
[2024-09-26 09:39:56] INFO: Identifying markers in 7 genomes with 8 threads.
[2024-09-26 09:39:56] TASK: Running Prodigal V2.6.3 to identify genes.
                                                                             [2024-09-26 09:40:10] INFO: Completed 7 genomes in 13.95 seconds (1.99 seconds/genome).
[2024-09-26 09:40:10] TASK: Identifying TIGRFAM protein families.
                                                                             [2024-09-26 09:40:14] INFO: Completed 7 genomes in 3.88 seconds (1.80 genomes/second).
[2024-09-26 09:40:14] TASK: Identifying Pfam protein families.
                                                                             [2024-09-26 09:40:15] INFO: Completed 7 genomes in 0.24 seconds (29.07 genomes/second).
[2024-09-26 09:40:15] INFO: Annotations done using HMMER 3.1b2 (February 2015).
[2024-09-26 09:40:15] TASK: Summarising identified marker genes.
                                                                            [2024-09-26 09:40:15] INFO: Completed 7 genomes in 0.17 seconds (41.21 genomes/second).
[2024-09-26 09:40:15] INFO: Done.
[2024-09-26 09:40:15] INFO: Aligning markers in 7 genomes with 8 CPUs.
[2024-09-26 09:40:15] INFO: Processing 7 genomes identified as bacterial.
[2024-09-26 09:40:20] INFO: Read concatenated alignment for 62,291 GTDB genomes.
[2024-09-26 09:40:20] TASK: Generating concatenated alignment for each marker.
                                                                   [2024-09-26 09:40:20] INFO: Completed 7 genomes in 0.03 seconds (262.62 genomes/second).
[2024-09-26 09:40:21] TASK: Aligning 120 identified markers using hmmalign 3.1b2 (February 2015).
[2024-09-26 09:40:24] INFO: Completed 120 markers in 3.17 seconds (37.80 markers/second).
[2024-09-26 09:40:24] TASK: Masking columns of bacterial multiple sequence alignment using canonical mask.
                                                                                [2024-09-26 09:42:10] INFO: Completed 62,298 sequences in 1.75 minutes (35,515.07 sequences/minute).
[2024-09-26 09:42:10] INFO: Masked bacterial alignment from 41,084 to 5,036 AAs.
[2024-09-26 09:42:10] INFO: 0 bacterial user genomes have amino acids in <10.0% of columns in filtered MSA.
[2024-09-26 09:42:10] INFO: Creating concatenated alignment for 62,298 bacterial GTDB and user genomes.
[2024-09-26 09:42:28] INFO: Creating concatenated alignment for 7 bacterial user genomes.
[2024-09-26 09:42:29] INFO: Done.
[2024-09-26 09:42:29] TASK: Placing 7 bacterial genomes into backbone reference tree with pplacer using 8 CPUs (be patient).
[2024-09-26 09:42:29] INFO: pplacer version: v1.1.alpha19-0-g807f6f3
==> Running pplacer v1.1.alpha19-0-g807f6f3 analysis on /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/align/asm.bac120==> Step 2 of 9: Pre-masking sequences.                                                                                [2024-09-26 09:44:32] INFO: Calculating RED values based on reference tree.
[2024-09-26 09:44:33] INFO: 7 out of 7 have an class assignments. Those genomes will be reclassified.
[2024-09-26 09:44:33] TASK: Placing 2 bacterial genomes into class-level reference tree 3 (1/4) with pplacer using 8 CPUs (be patient).
==> Running pplacer v1.1.alpha19-0-g807f6f3 analysis on /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/classify/interme==> Step 2 of 9: Pre-masking sequences.                                                                                [2024-09-26 09:50:07] INFO: Calculating RED values based on reference tree.
[2024-09-26 09:50:09] TASK: Traversing tree to determine classification method.
                                                                   [2024-09-26 09:50:09] INFO: Completed 2 genomes in 0.00 seconds (7,423.55 genomes/second).
[2024-09-26 09:50:09] TASK: Calculating average nucleotide identity using FastANI (v1.3).
                                                                                [2024-09-26 09:50:11] INFO: Completed 26 comparisons in 1.75 seconds (14.82 comparisons/second).
[2024-09-26 09:50:11] INFO: 0 genome(s) have been classified using FastANI and pplacer.
[2024-09-26 09:50:11] TASK: Placing 2 bacterial genomes into class-level reference tree 7 (2/4) with pplacer using 8 CPUs (be patient).
==> Running pplacer v1.1.alpha19-0-g807f6f3 analysis on /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/classify/interme==> Step 2 of 9: Pre-masking sequences.                                                                                [2024-09-26 09:53:14] INFO: Calculating RED values based on reference tree.
[2024-09-26 09:53:15] TASK: Traversing tree to determine classification method.
                                                                   [2024-09-26 09:53:15] INFO: Completed 2 genomes in 0.00 seconds (4,978.40 genomes/second).
[2024-09-26 09:53:15] TASK: Calculating average nucleotide identity using FastANI (v1.3).
                                                                                [2024-09-26 09:53:22] INFO: Completed 58 comparisons in 6.80 seconds (8.53 comparisons/second).
[2024-09-26 09:53:22] INFO: 0 genome(s) have been classified using FastANI and pplacer.
[2024-09-26 09:53:22] TASK: Placing 2 bacterial genomes into class-level reference tree 4 (3/4) with pplacer using 8 CPUs (be patient).
==> Running pplacer v1.1.alpha19-0-g807f6f3 analysis on /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/classify/interme==> Step 2 of 9: Pre-masking sequences.                                                                                [2024-09-26 09:59:04] INFO: Calculating RED values based on reference tree.
[2024-09-26 09:59:06] TASK: Traversing tree to determine classification method.
                                                                   [2024-09-26 09:59:06] INFO: Completed 2 genomes in 0.00 seconds (2,211.60 genomes/second).
[2024-09-26 09:59:07] TASK: Calculating average nucleotide identity using FastANI (v1.3).
                                                                                [2024-09-26 09:59:18] INFO: Completed 124 comparisons in 11.10 seconds (11.17 comparisons/second).
[2024-09-26 09:59:18] INFO: 0 genome(s) have been classified using FastANI and pplacer.
[2024-09-26 09:59:18] TASK: Placing 1 bacterial genomes into class-level reference tree 1 (4/4) with pplacer using 8 CPUs (be patient).
==> Running pplacer v1.1.alpha19-0-g807f6f3 analysis on /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/7-gtdbtk/asm/classify/interme==> Step 2 of 9: Pre-masking sequences.                                                                                [2024-09-26 10:03:07] INFO: Calculating RED values based on reference tree.
[2024-09-26 10:03:09] TASK: Traversing tree to determine classification method.
                                                                   [2024-09-26 10:03:09] INFO: Completed 1 genome in 0.00 seconds (5,817.34 genomes/second).
[2024-09-26 10:03:10] TASK: Calculating average nucleotide identity using FastANI (v1.3).
                                                                                [2024-09-26 10:03:12] INFO: Completed 14 comparisons in 1.84 seconds (7.62 comparisons/second).
[2024-09-26 10:03:12] INFO: 0 genome(s) have been classified using FastANI and pplacer.
[2024-09-26 10:03:12] INFO: Note that Tk classification mode is insufficient for publication of new taxonomic designations. New designations should be based on one or more de novo trees, an example of which can be produced by Tk in de novo mode.
[2024-09-26 10:03:12] INFO: Done.
[2024-09-26 10:03:12] INFO: Removing intermediate files.
[2024-09-26 10:03:12] INFO: Intermediate files removed.
[2024-09-26 10:03:12] INFO: Done.

I have 218 bins after the dereplication step with ll 5-dereplicated-bins/asm | wc -l . The next filtering checkm2 step worked well , but at the end of the job, I only got 7 bins, which is quite low right ?
cat /home/vipailler/Scripts/Hifi-MAG/pb-metagenomics-tools/HiFi-MAG-Pipeline/logs/asm.AssessCheckm2Bins.log
make_checkm_df: Making checkm2 dataframe.
make_depth_dict: Making depth dictionary.
add_contig_numbers_and_status: Adding contig numbers and assessing Pass/Fail filtering status.
add_contig_numbers_and_status: Done.
get_passing_bins: Identifying bins passing filters.
write_gtdb_batch_file: Writing GTDB batch file.
write_gtdb_batch_file: 7 bins passed filtering.
write_fork_target_file: Writing fork target file.
write_updated_tsv_file: Writing updated tsv file.

Is that low nomber of bins that leads to an uncompleted taxonomic assignment by GTDB-Tk ? Would you have an explanation ?
Best

Hi @pailloufat-stack ,
I solved this issue by adding the backslash at line 558 in  Snakefile-hifimags.smk.
"grep -h '>' {input.mag_dir}.fa | cut -d'>' -f2 1> {output} 2> {log}"
"grep -h '>' {input.mag_dir}/.fa | cut -d'>' -f2 1> {output} 2> {log}"

Hi @bak1121 ,
Indeed, that solved the problem.
Thanks

This should be permanently fixed in v3.3.0.


Parallel compilation

What feature are you requesting?
When make debug, I observed sometimes only one single core to be busy via htop.
It would be nice if we could ensure parallel build at all targets via make -j$(nproc).
Let me know if I got it wrong.
It's not an urgent issue, I might take a look later when I have some time.
Why are you requesting this feature?
A fresh build with make debug takes me ~45 min on a 2-core and 8GiB github codespace.
What is your proposed implementation for this feature?
No response

make debug -j$(nproc) enables parallel compilation. However, two key parts are not parallelized:

DuckDB is not compiled in parallel: Compiling DuckDB in parallel within the Docker container leads to memory issues. This significantly impacts fresh builds since DuckDB compilation dominates the build time, though incremental builds during development are unaffected.
Static linking with libdelta.a: We use a small Rust module to write Delta Lake tables. This module is compiled into libdelta.a and statically linked into pg_mooncake. The static linkage adds approximately 1 minute to the build time, which is particularly frustrating for incremental builds during development. The underlying issue is that CXX does not natively support generating shared libraries. We are exploring potential solutions to address this limitation.

Any suggestions to address these issues would be greatly appreciated!

Compiling DuckDB in parallel within the Docker container leads to memory issues.

Curious, could you please relate more on that?
duckdb's official doc does illustruate parallel compilation: https://github.com/duckdb/duckdb/blob/main/CONTRIBUTING.md#building
I have a draft change, needs to be verified when I have more time.

We use a Rust module to write Delta Lake tables

Yes I'm aware of it. It doesn't contribute to compilation time, but only link time.
From my observation, the bottleneck still lies in third party dependency compilation.

Curious, could you please relate more on that?

My dev container has 12 cpus and 7.5 GB of memory
Compiling using all cpus led to OOM
Thanks for the reference! Setting CMAKE_BUILD_PARALLEL_LEVEL helped
I made a diff based on your draft, and it works: https://github.com/Mooncake-Labs/pg_mooncake/commit/4f1e61bcda294a2b199e6d3a7d9a418ddd3fc38b then make debug -j4

Yes I'm aware of it. It doesn't contribute to compilation time, but only link time.
From my observation, the bottleneck still lies in third party dependency compilation.

Correct, that only affects link time, not compilation time
What I meant is that third-party dependency compilation only occurs during a fresh build, not during incremental builds
The static linking with libdelta.a is the most time-consuming part of incremental builds during development


[For #4420] Add SetConfigParams() to determine nfs-ganesha log level

I add SetConfigParams() which is according to different case to replace parameter of defaultConfig.
For #4420, I replace Default_Log_Level value based on whether debug is turn on or not.
And it will only applied if configuration file is not exits.

I will focus on #38 and waiting more discussion to make the solution precisely.
So I will close this PR at first.


Create external AdmissionCheck controller for Kueue

In the doc and repo, there is an example for additional AdmissionCheck: ProvisioningRequest, but it's part of Kueue source code. It seems the implementation of admissin check controller has high dependencies with Kueue. Are there examples and documentations for a separate external AdmissionCheck controller that works with Kueue

Hi @leipanhz,
The dependencies ,I think, you are referring to are just built-time dependencies, meaning the admission check controllers are using some public packages of Kueue as utilities (e.g.   !workload.HasQuotaReservation(wl) to check if the given workload has quota reservation instead of checking the workload's status.conditions for the presence and Status of kueue.WorkloadQuotaReserved ), but there is no dependencies at runtime, the ACCs can run in a different controller-manager deployment with no functional differences.

/assign

@trasc I am new to Kubernetes, I have some detailed questions:

To perform checks, the admission check controller needs to exam workload created by Kueue during reconcile. This is done by setting up its controller in main() and pass client of kueue to the controller: https://github.com/kubernetes-sigs/kueue/blob/main/cmd/kueue/main.go#L238-L262. How can external admission check set up controller with Kueue?

I see both provisioningchecks and multikueue have indexer.go. I didn't find docs about it. How is it needed in admission check process

If you can explain steps needed for implementing  external admission check to integrate with Kueue, that will be very helpful. Thank you.

@leipanhz

The external controller-manager should start its own AdmissionCheckController from it's own main() with it's own controller-runtime manager.
Those indexes are specific to provisioning and multikueue AdmissionCheckControllers.

I am working a simplified demo-acc #3265, It's still work in progress but feel free to have an early look. (cmd/experimental/demo-acc/STEP-BY-STEP.md describes the steps I took to develop and test it).

@leipanhz

The external controller-manager should start its own AdmissionCheckController from it's own main() with it's own controller-runtime manager.
Those indexes are specific to provisioning and multikueue AdmissionCheckControllers.

I am working a simplified demo-acc #3265, It's still work in progress but feel free to have an early look. (cmd/experimental/demo-acc/STEP-BY-STEP.md describes the steps I took to develop and test it).

@trasc Thank you for providing example of demo-acc! I hit an error during compilation:
# sigs.k8s.io/kueue/pkg/features ../../../../go/pkg/mod/sigs.k8s.io/kueue@v0.8.1/pkg/features/kube_features.go:126:9: featuregatetesting.SetFeatureGateDuringTest(tb, utilfeature.DefaultFeatureGate, f, value) (no value) used as value make: *** [vet] Error 1
FYI, the controller is on a separate repo with different domain and group names.

featuregatetesting.SetFeatureGateDuringTest was changed lately in k8s.io/component-base, please try to use an older component-base or a newer kueue version

featuregatetesting.SetFeatureGateDuringTest was changed lately in k8s.io/component-base, please try to use an older component-base or a newer kueue version

The v0.8.1 version I used seems to be the latest stable release: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.8.1. I found v0.9.0-devel is a higher version than that. After trying, still seeing the same issue (with other errors):
sigs.k8s.io/kueue/pkg/features
../../../../go/pkg/mod/sigs.k8s.io/kueue@v0.9.0-devel/pkg/features/kube_features.go:126:9: featuregatetesting.SetFeatureGateDuringTest(tb, utilfeature.DefaultFeatureGate, f, value) (no value) used as value
sigs.k8s.io/controller-runtime/pkg/metrics
../../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/metrics/leaderelection.go:26:71: undefined: leaderelection.SwitchMetric
k8s.io/apiserver/pkg/cel/library
../../../../go/pkg/mod/k8s.io/apiserver@v0.29.6/pkg/cel/library/cost.go:182:28: args[1].Expr().GetConstExpr undefined (type "github.com/google/cel-go/common/ast".Expr has no field or method GetConstExpr)
../../../../go/pkg/mod/k8s.io/apiserver@v0.29.6/pkg/cel/library/cost.go:259:11: cannot use &itemsNode{…} (value of type *itemsNode) as checker.AstNode value in return statement: *itemsNode does not implement checker.AstNode (wrong type for method Expr)
have Expr() *expr.Expr
want Expr() "github.com/google/cel-go/common/ast".Expr
../../../../go/pkg/mod/k8s.io/apiserver@v0.29.6/pkg/cel/library/cost.go:262:11: cannot use &itemsNode{…} (value of type *itemsNode) as checker.AstNode value in return statement: *itemsNode does not implement checker.AstNode (wrong type for method Expr)
have Expr() *expr.Expr
want Expr() "github.com/google/cel-go/common/ast".Expr
If I need to downgrade k8s.io/component-base, can you please recommend a version number?

If I need to downgrade k8s.io/component-base, can you please recommend a version number?

Check the version kueue 0.8.1 is using (in kueue's go.mod)
You can also use kueue@main, temporarily, we will release v0.9.0 shortly.

If I need to downgrade k8s.io/component-base, can you please recommend a version number?

Check the version kueue 0.8.1 is using (in kueue's go.mod)
You can also use kueue@main, temporarily, we will release v0.9.0 shortly.

I downgraded versions of a few packages to be compatible with kueue 0.8.1. I am able to run makefile and build image. However, when I deployed the image, the controller-manager is crashing with the following error:
2024-10-21T04:47:10Z	ERROR	setup	unable to create controller	{"controller": "AdmissionCheck", "error": "no kind is registered for the type v1beta1.AdmissionCheck in scheme "pkg/runtime/scheme.go:100""}
main.main
/workspace/cmd/main.go:151
runtime.main
/usr/local/go/src/runtime/proc.go:271
The above error is from the external customer controller. I noticed the version of k8s.io/apimachinery where has scheme.go is older than the one in main, however, upgrading it triggers other compilation issues.
Then in the kueu repo, I pulled demo-acc, built and deployed for comparison. The kueue controller manager crashes too, but for a different error (I don't have this issue with mainline code before 9/6):
{"level":"error","ts":"2024-10-21T04:50:11.346596132Z","logger":"setup","caller":"kueue/main.go:208","msg":"Provisioning Requests are not supported, skipped admission check controller setup","stacktrace":"main.setupIndexes\n\t/workspace/cmd/kueue/main.go:208\nmain.main\n\t/workspace/cmd/kueue/main.go:169\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:272"}
{"level":"error","ts":"2024-10-21T04:50:11.347161923Z","logger":"setup","caller":"kueue/main.go:217","msg":"Could not setup multikueue indexer","error":"setting index on clusters using kubeconfig: no matches for kind "MultiKueueCluster" in version "kueue.x-k8s.io/v1beta1"","stacktrace":"main.setupIndexes\n\t/workspace/cmd/kueue/main.go:217\nmain.main\n\t/workspace/cmd/kueue/main.go:169\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:272"}
Do you have any suggestions for me to move forward? Happy to schedule an online troubleshooting session at your convenient time if that works for you. Btw, attached is the go.mod file used in my controller. Thank you for your time.
gomod.txt

Hi,
For the first part:

I downgraded versions of a few packages to be compatible with kueue 0.8.1. I am able to run makefile and build image. However, when.....................

I likely because the Kueue's API is not registered in the scheme, you'll need to do something like
@@ -34,6 +34,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
+	kueueapi "sigs.k8s.io/kueue/apis/kueue/v1beta1"

 	"sigs.k8s.io/kueue/cmd/experimental/demo-acc/internal/controller"
 	// +kubebuilder:scaffold:imports
@@ -46,6 +47,7 @@ var (

 func init() {
 	utilruntime.Must(clientgoscheme.AddToScheme(scheme))
+	utilruntime.Must(kueueapi.AddToScheme(scheme))

 	// +kubebuilder:scaffold:scheme
 }

I  your controller's main.go
The second part:

Then in the kueu repo, I pulled demo-acc, built and deployed for comparison. The kueue controller manager crashes too, but for a different error (I don't have this issue with mainline code before 9/6):.......

It's likely because the manifests in your cluster are out of sync with the kueue's controller-manager. Not long ago, we've moved the MultiKueue APIs from v1alpha1 to v1beta1. This should not happen if you run make install and make deploy, for Kueue, from the same source tree (and version).

@trasc, I followed your comments and was able to resolve most issues, thank you! For the multikueue issue: after removing some previously defined CRDs related to multikueue,  and recompile with all cache cleaned, the error is gone.
Note that, there are other errors related to webhook when running "make deploy", for example: failed calling webhook "mdeployment.kb.io"... the server could not find the requested resource. For now I deleted "mdeployment.kb.io" and "rdeployment.kb.io" in the webhook, that may not be desired actions.
For the first part (with my external controller), there is a mistakes in imports. After fixing that, the admission check registration issue was resolved. I encountered different errors, but that is probably related to my system setup and implementation. I am looking into them, and will reach out if this is related to Kueue integration. Appreciate your knowledge sharing.

@trasc I noticed there is always an error message when an Admissioncheck is created, from kueue/vendor/k8s.io/apiserver/pkg/registry/generic/registry/store.go, and the log information is not printed in the controller log,  although admissioncheck is up running:
2024-10-23T20:57:16Z	INFO	Starting Controller	{"controller": "admissioncheck", "controllerGroup": "kueue.x-k8s.io", "controllerKind": "AdmissionCheck"}
2024-10-23T20:57:17Z	INFO	Starting workers	{"controller": "workload", "controllerGroup": "kueue.x-k8s.io", "controllerKind": "Workload", "worker count": 1}
2024-10-23T20:57:17Z	INFO	Starting workers	{"controller": "admissioncheck", "controllerGroup": "kueue.x-k8s.io", "controllerKind": "AdmissionCheck", "worker count": 1}
2024-10-23T21:36:14Z	ERROR	Reconciler error	{"controller": "admissioncheck", "controllerGroup": "kueue.x-k8s.io", "controllerKind": "AdmissionCheck", "AdmissionCheck": {"name":"demo-ac"}, "namespace": "", "name": "demo-ac", "reconcileID": "fca955c2-a0d1-4675-a883-259ce9855c5b", "error": "Operation cannot be fulfilled on admissionchecks.kueue.x-k8s.io "demo-ac": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:224
Is this related to the package version or something else? I am using kueue v0.8.1 image.

No, this happens because there are two controllers trying to update the same  resource at the same time, one of them will get the conflict, however, when this happens controller-runtime will queue another reconcile request for that object and eventually will succeed.

No, this happens because there are two controllers trying to update the same resource at the same time, one of them will get the conflict, however, when this happens controller-runtime will queue another reconcile request for that object and eventually will succeed.

I don't see any logs from the other reconciler (the custom controller) after the error. Do you have any suggestions?

No, this happens because there are two controllers trying to update the same resource at the same time, one of them will get the conflict, however, when this happens controller-runtime will queue another reconcile request for that object and eventually will succeed.

I don't see any logs from the other reconciler (the custom controller) after the error. Do you have any suggestions?

No error is an indication that nothing went wrong :). In the demo-acc, the AC reconciler has only one job, to set the Active condition to true for the ACs managed by it.
The testing step:

It should get marked as Active
kubectl get admissionchecks.kueue.x-k8s.io demo-ac -o=jsonpath='{.status.conditions[?(@.type=="Active")].status}{" -> "}{.status.conditions[?(@.type=="Active")].message}{"\n"}'

Checks if that in fact happening.

No error is an indication that nothing went wrong :).
Sorry, I meant the info level logs added in the reconcile code. I tested on demo-ac and my controller (workload-controller in particular), in both cases there are no logs printed even though the reconcile requests seems working. Is there anything I missed?

Checks if that in fact happening.
Yes this works

No error is an indication that nothing went wrong :).
Sorry, I meant the info level logs added in the reconcile code. I tested on demo-ac and my controller (workload-controller in particular), in both cases there are no logs printed even though the reconcile requests seems working. Is there anything I missed?

Checks if that in fact happening.
Yes this works

Sorry, I meant the info level logs added in the reconcile code didn't show as expected, after the above error message was printed.

I realized this is related to log level setting. I thought V(2) would enable printing logs by default, but it isn't. Feel free to resolve the issue. Thanks!

You can add --zap-log-level=2 in the managers args, to increase its log level.

Thanks for your support @trasc


problem with using adetailer

adetailer = webuiapi.ADetailer(ad_model='face_yolov8n.pt', ad_denoising_strength=0.6)
res = api.txt2img(
    # enable_hr=enable_hr,
    prompt=prompt,
    negative_prompt=negative_prompt,
    width=width,
    height=height,
    controlnet_units=[ip_adapter, openpose] if use_ip_adapter else [openpose],
    adetailer=[adetailer]
).image

The logic for generating images seems different from webui, leading to strange results.

Hi @saltedfisssh , do you mean that using the same seed, cfscale, steps you get a different image when applying adetailer?

When using adetailer, only the facial part is recognized, but it attempts to generate more parts besides the face.  Use the same parameters as webui.

Sorry, during the process of reproducing, I found out that this is an issue with Adetailer. Thank you for your help!

Great! Good to know it is not a problem of this api wrapper. Bad to know that Adetailer has this behaviour.. thanks for letting me know!


Update _ClientInitResponse.mdx

🚀 Deployed on https://63d94cac42797e01f23d303d--cozy-fox-0defec.netlify.app


Announce to #deployer with each App deploy

Details
We're expanding our internal announcements to include our #deployer channel in addition to our existing #announce.
Fixed Issues
No existing issue. Discussion in Slack.
Tests
QA Steps
When this is deployed, ask in #qa whether the message

exists in the #deployer channel.
Tested On
N/A
Screenshots
N/A

@johnmlee101, Great job getting your first Expensify/App pull request over the finish line! :tada:
I know there's a lot of information in our contributing guidelines, so here are some points to take note of :memo::

Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
Once your PR is deployed to production, we start a 7-day timer :alarm_clock:. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. :moneybag:

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! :blush:

🚀 Deployed to staging by @Jag96 in version: 1.0.99-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Feature/Task: Updated select pub and mag for mobile and desktop/view

Feature/Task: Updated select pub and mag for mobile and desktop/view

@jasonwkf @tanhjk  Kindly review. Thanks

Hi Anubhav
Received!
Thanks
*Kevin Tan *
Lead Product Designer
Digital Media Products
Singapore Press Holdings Limited
1000 Toa Payoh North, News Centre, Singapore 318994
E: @.*** @.***>    |    D: +65-6319 1859
On Sun, 7 May 2023 at 20:33, Anubhav kumar @.***> wrote:

@jasonwkf https://github.com/jasonwkf @tanhjk
https://github.com/tanhjk Kindly review. Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/jasonwkf/eshop-test/pull/1#issuecomment-1537430556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALYDYC7BV2IYZLBEDTMIU7LXE6JBTANCNFSM6AAAAAAXY25ZDE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
NOTE: Privileged/Confidential Information may be contained in this
message. If you are not the addressee indicated in this message (or
responsible for delivery of the message to such person), you may not copy
or deliver this message to anyone. In such case, you should destroy this
message and kindly notify the sender by reply email. All opinions,
conclusions and other information expressed in this message not of an
official nature shall not be deemed as given or endorsed by SPH Media Trust
or any of its subsidiaries unless otherwise indicated by an authorised
representative independent of this message.
SPH Media Limited
Co Regn
No.: 202120748H


install-brew: fish support?

~ ❯❯❯ . /var/home/linuxbrew/.linuxbrew/bin/brew
/var/home/linuxbrew/.linuxbrew/bin/brew (Zeile 60): Unsupported use of '='. In fish, please use 'set BREW_FILE_DIRECTORY "$(quiet_cd "${0%/*}/" && pwd -P)"'.
BREW_FILE_DIRECTORY="$(quiet_cd "${0%/*}/" && pwd -P)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
aus der Quelldatei /var/home/linuxbrew/.linuxbrew/bin/brew
.: Error while reading file '/var/home/linuxbrew/.linuxbrew/bin/brew'

btw piping an install script to bash... I dont know

you should be sourcing that file. It is a bash script.

This is on the image now.


refactor: Use runtime arguments in Divan benchmarks

Description

This greatly reduces compile times and is not limited to arrays/slices.

coverage: 79.853% (+0.02%) from 79.837%
when pulling 7cb124c618a59f6e4e13b1b8e6c788c64ee17412 on nvzqz:patch-1
into 510bd92c7dd06fb91eee5184b4c8a56033308773 on pomsky-lang:main.

Thank you @nvzqz !


Share codeStyleSettings.xml

Provide .idea/codeStyleSettings.xml for easier contribution as there is non-default formatting.

We maintain code style rules for IDEA in a separate project https://github.com/stanfy/java-code-style
But we should make something like a contribution guideline pointing to that repo.

Sounds good.


Add force checkout for target branches

We're facing a CI issue related to go modules where the change cannot be
merged because the target branch has local changes:
https://storage.googleapis.com/origin-federated-results/pr-logs/pull/cri-o_cri-o/3005/test_pull_request_crio_e2e_fedora/8293/build-log.txt
We now use checkout -f to throw away the local changes before doing
the merge.

@haircommander @mrunalp please take a look. I think we do not have to rebuild the AMIs to apply these changes, right?

Relates to https://github.com/openshift/aos-cd-jobs/pull/2062/files

ahh shoot I missed them. LGTM

LGTM


How

How to create a game
/sw addmap doesn’t do anything

i think its still in beta

How to create a game /sw addmap doesn’t do anything

Read the file "ReadMe.md" look at commands

I'm sorry for not realizing these issues sooner, yeah the plugin is in development. I have some exams now so I cannot finish it rather than giving it a form to understand it later. I'm sorry for your inconvenient!

Of course! Take your time! All the features look really cool and I am excited to see the end product!
Make sure you study though! Get good grades on those exams! Good luck!


Re-Exporting Header Structs

I rely heavily on intellij Intellisense and spent the last hour searching for where the ContentType header was exported from only to find some sort of macro sorcery. I'm new to rust (~2months). What exactly is this macro doing? why wasn't the header structs exported the normal way ?
https://github.com/hyperium/hyper/blob/50fd4ab96daaadc10be9317dc0d365c7a5ebed5e/src/header/mod.rs#L350-L364
was it too much work? i'm happy to help out if it was.

@seanmonstar

@SeunLanLege The ContentType header is actually defined here:
https://github.com/hyperium/hyper/blob/9bb71b9bbfedc4b47c96dd83efd75f852abced6b/src/header/common/content_type.rs#L48
There is a documented header! macro it uses to define itself with here: https://docs.rs/hyper/0.11.2/hyper/header/index.html#defining-custom-headers

That bit of code you linked is internal-only (not exported) and used in the Extend impl which is when you take one set of headers and extend it with another one. I'm completely sure why its doing what it's doing but @seanmonstar can probably answer that.

Oh i see, but problem with that approach is that we lose intellisense. :disappointed:

what would it take to write them as structs?

The linked macro for literals is internal code. It's definitely unrelated.
The type you're looking for is a struct, and it is exported at hyper::header::ContentType. The macro used to define it just removes the need to write out some common pieces, only requiring to write the parts of the Header impl that are different from other headers. The macro expands to a pub struct ContentType(pub Mime);.
What is the actual issue here? Intellisense cannot understand macros in Rust?

What is the actual issue here? Intellisense cannot understand macros in Rust?

that would appear to be the case.


add license, docs, authors to manifest

Closes #579. @mikofski does this look ok to you? I wasn't sure about spa_c_files so I left it alone. Or maybe we can merge this and then you can make further updates in your PR if it's important.

LGTM!

switched to wholmgren/manifest branch

I created a new python3 virtualenv

installed the requirements

and ran python setup.py sdist

listed the contents of the source distribution
tar -t -f pvlib-0.6.0a2+6.g5b679c4.dirty.tar.gz > sdist.txt

The following files from the manifest are in the source:

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/AUTHORS.md

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/LICENSE

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/README.md

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/versioneer.py

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/_version.py

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/

pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/12839.tm2
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/703165TY.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/adr-library-2013-10-01.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/BIRD_08_16_2012.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/BIRD_08_16_2012_patm.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/bishop88_numerical_precision.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/detect_clearsky_data.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/LinkeTurbidities.h5
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-cec-inverters-2018-3-18.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-cec-modules-2017-6-5.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-sandia-modules-2015-6-30.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/variables_style_rules.csv

[ ] spa_c_files/*.h  <-- see my comments in review

[x] no __pycache__, *.pyc, or *.pyo

[x] pvlib-0.6.0a2+6.g5b679c4.dirty/docs/

pvlib-0.6.0a2+6.g5b679c4.dirty/docs/environment.yml
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/Makefile
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_images/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_images/clonebutton.png
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/.gitignore
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/no_scrollbars.css
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/api.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/clearsky.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/comparison_pvlib_matlab.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/conf.py
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/contributing.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/forecasts.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/index.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/installation.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/introexamples.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/modelchain.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/package_overview.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/pvsystem.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/singlediode.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/timetimezones.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/variables_style_rules.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.1.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.3.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.3.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.4.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.5.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.0.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.1.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.2.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.6.0.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew.rst

[x] no docs/tutorials, docs/sphinx/build, docs/sphinx/source/generated, or docs/sphinx/source/savefig

[x] no Jupyter .ipynb_checkpoints or macOS .DS_store files

here's the full contents of the source distribution:

pvlib-0.6.0a2+6.g5b679c4.dirty/
pvlib-0.6.0a2+6.g5b679c4.dirty/AUTHORS.md
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/environment.yml
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/Makefile
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_images/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_images/clonebutton.png
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/.gitignore
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/_static/no_scrollbars.css
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/api.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/clearsky.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/comparison_pvlib_matlab.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/conf.py
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/contributing.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/forecasts.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/index.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/installation.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/introexamples.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/modelchain.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/package_overview.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/pvsystem.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/singlediode.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/timetimezones.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/variables_style_rules.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.1.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.2.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.3.3.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.0.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.1.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.2.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.3.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.4.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.4.5.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.0.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.1.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.5.2.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew/v0.6.0.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/docs/sphinx/source/whatsnew.rst
pvlib-0.6.0a2+6.g5b679c4.dirty/LICENSE
pvlib-0.6.0a2+6.g5b679c4.dirty/MANIFEST.in
pvlib-0.6.0a2+6.g5b679c4.dirty/PKG-INFO
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/__init__.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/_deprecation.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/_version.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/atmosphere.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/clearsky.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/12839.tm2
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/703165TY.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/adr-library-2013-10-01.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/BIRD_08_16_2012.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/BIRD_08_16_2012_patm.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/bishop88_numerical_precision.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/detect_clearsky_data.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/LinkeTurbidities.h5
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-cec-inverters-2018-3-18.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-cec-modules-2017-6-5.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/sam-library-sandia-modules-2015-6-30.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/data/variables_style_rules.csv
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/forecast.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/irradiance.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/location.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/modelchain.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/pvsystem.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/singlediode.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/solarposition.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/spa.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/tmy.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/tools.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/tracking.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib/version.py
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/dependency_links.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/not-zip-safe
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/PKG-INFO
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/requires.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/SOURCES.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/pvlib.egg-info/top_level.txt
pvlib-0.6.0a2+6.g5b679c4.dirty/README.md
pvlib-0.6.0a2+6.g5b679c4.dirty/setup.cfg
pvlib-0.6.0a2+6.g5b679c4.dirty/setup.py
pvlib-0.6.0a2+6.g5b679c4.dirty/versioneer.py

I think the MANIFEST now properly handles the spa_c_files directory. With the NREL spa.c/h files present in the spa_c_files directory...
$ ls -1a pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
__init__.py
__init__.pyc
__pycache__
build
cspa_py.pxd
setup.py
spa.c
spa.h
spa_py.cpython-36m-darwin.so
spa_py.pyx
spa_py_example.py
$ python setup.py sdist
$ ls -1a dist/pvlib-0.6.0a2+10.g01e8c3e/pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
__init__.py
cspa_py.pxd
setup.py
spa_py.pyx
spa_py_example.py

Can you also manually exclude build/ and any *.so or *.pyd files from spa_c_files please? This should be explicitly a pure source distribution.
Sent from Yahoo Mail on Android
On Sun, Sep 16, 2018 at 10:49 AM, Will<EMAIL_ADDRESS>wrote:
I think the MANIFEST now properly handles the spa_c_files directory. With the NREL spa.c/h files present in the spa_c_files directory...
$ ls -1a pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
init.py
init.pyc
pycache
build
cspa_py.pxd
setup.py
spa.c
spa.h
spa_py.cpython-36m-darwin.so
spa_py.pyx
spa_py_example.py
$ python setup.py sdist
$ ls -1a dist/pvlib-0.6.0a2+10.g01e8c3e/pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
init.py
cspa_py.pxd
setup.py
spa_py.pyx
spa_py_example.py
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok I can specifically exclude them but note they are not in the dist.
On Sun, Sep 16, 2018 at 11:04 AM Mark Mikofski<EMAIL_ADDRESS>wrote:

Can you also manually exclude build/ and any *.so or *.pyd files
from spa_c_files please? This should be explicitly a pure source
distribution.
Sent from Yahoo Mail on Android
On Sun, Sep 16, 2018 at 10:49 AM, Will<EMAIL_ADDRESS>wrote:
I think the MANIFEST now properly handles the spa_c_files directory. With
the NREL spa.c/h files present in the spa_c_files directory...
$ ls -1a pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
init.py
init.pyc
pycache
build
cspa_py.pxd
setup.py
spa.c
spa.h
spa_py.cpython-36m-darwin.so
spa_py.pyx
spa_py_example.py
$ python setup.py sdist
$ ls -1a dist/pvlib-0.6.0a2+10.g01e8c3e/pvlib/spa_c_files
.
..
README.md
SPA_NOTICE.md
init.py
cspa_py.pxd
setup.py
spa_py.pyx
spa_py_example.py
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pvlib/pvlib-python/pull/580#issuecomment-421805598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELiRwoVtSCJ_Q1WiFysC75omH_X1xcTks5ubpK-gaJpZM4Wqm92
.

Oh ok sorry, my bad, either way. I'm not at a computer so I can't test

Reworked the manifest to use graft. The behavior now is to include everything under pvlib/ except for the specifically excluded items. This follows the prevailing attitude online of "better to include too much than not enough."
Contents of distributed spa_c_files is now:
README.md
SPA_NOTICE.md
__init__.py
cspa_py.pxd
setup.py
spa_py.pyx
spa_py_example.py

I like this a lot, I just tested, and it excludes a lot more cruft than previously (.git*, etc.)
maybe also global-exclude *.egg-info

Thanks @mikofski. The global-exclude *.egg-info and variants doesn't seem to work for some reason. Did it work for you?
I see that I've accidentally been including eggs in some of the previous source distributions.

something weird, dunno if/how you want to handle - I had put spa.h and spa.c in a subfolder of spa_c_files, and since they weren't explicitly excluded, they ended up in the tarball.
adding this seems to work:
global-exclude */spa.c
global-exclude */spa.h

Thanks @mikofski. The global-exclude *.egg-info and variants doesn't seem to work for some reason. Did it work for you?
I see that I've accidentally been including eggs in some of the previous source distributions.

no, didn't work for me either, frustrating

Good idea to make a more flexible spa exclusion.
I can't find much guidance online for how to exclude the egg. I'd say better to look the other way if it's not easy to exclude. Note that the egg is included in the v0.6.0a2 release that TravisCI pushed to PyPI last week.

SO Q/A say:

This directory is created intentionally as part of the build process for a source distribution. A little gander at the developer guide for setuptools gives you a hint as to why

But, be sure to ignore any part of the distutils documentation that deals with MANIFEST or how it's generated from MANIFEST.in; setuptools shields you from these issues and doesn't work the same way in any case. Unlike the distutils, setuptools regenerates the source distribution manifest file every time you build a source distribution, and it builds it inside the project's .egg-info directory, out of the way of your main project directory. You therefore need not worry about whether it is up-to-date or not.

None of the workarounds seem to work for me, I agree with your conclusion, AFAICT this folder was meant to be included in any distribution.

TL;DR: this is just for future info, I don't think you should change anything, IMO it just seems like too much work and too much of a hack, but ...


Use AbsGrad to get better results with less gaussians

I am following the parameter setting as recommended in https://arxiv.org/pdf/2404.10484
In order to experiment this PR, one need to install the customized gsplat library as in this PR https://github.com/nerfstudio-project/gsplat/pull/166
# uninstall previous gsplat and nerfstudio

pip install git+https://github.com/nerfstudio-project/gsplat.git@absgrad
pip install git+https://github.com/jb-ye/nerfstudio

I will follow up my experiments here. I recommend to experiment with one of the two settings (A, B) and use input image resolution higher than 1600 (e.g. 2k or 4k)
O splatfacto-big in latest main branch (--rasterize_mode antialiased)
A splatfacto-big of this PR (--rasterize_mode antialiased --densify_grad_thresh=0.0008)
B splatfacto-big of this PR (--rasterize_mode antialiased --densify_grad_thresh=0.0004)
O. baseline.
A. faster than B, high quality (expected to be better than O), smaller PLY asset.
B. slowest training, highest quality, largest PLY asset.

Does this implementation support classic rasterizer?

I got an error when opening viewer when it trains
ns-train splatfacto-big --logging.steps-per-log 200 --vis viewer+wandb --viewer.websocket-port 7007 \
    --pipeline.model.rasterize-mode antialiased --pipeline.model.densify_grad_thresh=0.0008 \
    nerfstudio-data \
    --data path/to/scene --downscale-factor 1

It runs smoothly and I keep it until about 6000 iters, then I open viewer localhost:7007. It is not suddenly fail. I rotate the gaussians, got pretty result, and boom.. The training is broken.
The error:
Exception in thread Thread-8:
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/workspace/NERFSTUDIO_ABSGS/nerfstudio/nerfstudio/viewer/render_state_machine.py", line 222, in run
    outputs = self._render_img(action.camera_state)
  File "/workspace/NERFSTUDIO_ABSGS/nerfstudio/nerfstudio/viewer/render_state_machine.py", line 182, in _render_img
    scale = min(desired_depth_pixels / current_depth_pixels, 1.0)
ZeroDivisionError: division by zero

The dataset : Waterfall_Kopu

@ichsan2895 The viewer crashes sometimes, but this is a separate issue: https://github.com/nerfstudio-project/nerfstudio/issues/3064

Does this implementation support classic rasterizer? @jb-ye

Yes

Some experiments done on bicycle dataset (It looks like our splatfacto-big is the new state-of-the-art!)
bicycle (downscale 2x):
main branch splatfacto-big
PSNR=24.62 SSIM=0.7256 LPIPS=0.2256
this PR splatfacto-big ( --rasterize_mode antialiased --densify_grad_thresh=0.0006)
PSNR=24.68 SSIM=0.7394 LPIPS=0.1861
bicycle (downscale 4x):
Zip-Nerf (according to https://jkulhanek.com/nerfbaselines/)
PSNR=25.867 SSIM=0.775 LPIPS=0.160
AbsGS (according to https://arxiv.org/pdf/2404.10484)
PSNR=25.373 SSIM=0.782 LPIPS=0.186
this PR splatfacto-big ( --rasterize_mode antialiased --densify_grad_thresh=0.0006)
PSNR=25.43 SSIM=0.7867 LPIPS=0.1451

Another mipnerf360 dataset
garden (downscale 4x):
Zip-Nerf (according to https://jkulhanek.com/nerfbaselines/)
PSNR=28.185 SSIM=0.863 LPIPS=0.085
AbsGS (according to https://arxiv.org/pdf/2404.10484)
PSNR=27.579 SSIM=0.870 LPIPS=0.104
main branch splatfacto-big
PSNR=27.4 SSIM=0.8645 LPIPS=0.083
this PR splatfacto-big ( --rasterize_mode antialiased --densify_grad_thresh=0.0006)
PSNR=27.57 SSIM=0.8702 LPIPS=0.078

Just need to bump the gsplat version to 0.1.11 then looks good!

I see that absgrad function has now been pushed to latest release. Do we have to enable it or is it configured by default when running ns-train splatfacto-big ? @jb-ye
Thank you!

@abrahamezzeddine it is used by default


elm_binary fails with confusing error message if it has no dependencies

Example BUILD:
load("@com_github_edschouten_rules_elm//elm:def.bzl", "elm_binary")

elm_binary(
  name = "Project",
  main = "src/Main.elm",
  visibility = ["//visibility:public"],
  deps = [],
)

Attempting to build this project results in the following error message:
Traceback (most recent call last):
  File "external/com_github_edschouten_rules_elm/elm/compile.py", line 44, in <module>
    with open(os.path.join(PACKAGES_DIR, "versions.dat"), "wb") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'elm-home/0.19.0/package/versions.dat'

This seems to be because the code that creates the versions.dat file (in this block) never actually gets to run if there aren't any dependency packages.
I'm aware that a workaround is to create a library that's used as a dependency for the binary. However, I'm unsure if it's intentional that a binary cannot be created without any dependencies. If it is intentional, better error handling to produce a clearer error message in this situation would probably be a good idea. If it's not intentional, it seems that perhaps this could be solved by having compile.py create a blank versions.dat if there are no dependency packages.

@sepiatonal
I added the test case for this issue, however I am probably not able to reproduce it. elm compiler claims you always have to depend on core. Can you either fix the test case or give more details howto reproduce this?

@kczulko
This was fixed a while ago (https://github.com/kczulko/rules_elm/pull/12), I just never closed the issue.


rails-app moved to examples folder

The rails-app is a bit out of place in the root directory. Moved it an examples folder.  Modified the demo script with /bin/bash

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@FourSigma could you resolve these conflicts, happy to merge this. I agree moving it to examples it a better idea that way we could add more examples if needed.

@FourSigma could you resolve these conflicts, happy to merge this. I agree moving it to examples it a better idea that way we could add more examples if needed.

Fixed the conflicts.  That was my thinking on the examples as well.  I might add a lighter weight example that requires only lifting super-graph (no other service).


cf-app-router needs to be updated or deleted

This should be done.

Deleted it...

deleted it


Make the SIGNAL JOB UI plugin generalized so that it can be any job ui plugin.

I guess the one we have today in the example/src/pages could be fairly general. Only thing to change required is to actually take in the addresses and such for the jobs.


URISyntaxException: Illegal character in path at index 10: C:/Program Files (x86)/Windows Kits/10/Lib/10.0.15063.0/um/x86/WS2_32.lib

Hi
On a Linux Ubuntu system, got the excetion below on a modified script from subprojects/docs/src/samples/native-binaries/prebuilt. See build.gradle attached.
fandre@ubuntu-trusty-64:~/gradle/subprojects/docs/src/samples/native-binaries/prebuilt$ gradle build
Parallel execution is an incubating feature.

FAILURE: Build failed with an exception.

* Where:
Build file '/home/fandre/gradle/subprojects/docs/src/samples/native-binaries/prebuilt/build.gradle' line: 13

* What went wrong:
Could not determine the dependencies of task ':linkMainDebugExecutable'.
> java.net.URISyntaxException: Illegal character in path at index 10: C:/Program Files (x86)/Windows Kits/10/Lib/10.0.15063.0/um/x86/WS2_32.lib

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

fandre@ubuntu-trusty-64:~/gradle/subprojects/docs/src/samples/native-binaries/prebuilt$ gradle -version

------------------------------------------------------------
Gradle 4.1
------------------------------------------------------------

Build time:   2017-08-07 14:38:48 UTC
Revision:     941559e020f6c357ebb08d5c67acdb858a3defc2

Groovy:       2.4.11
Ant:          Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM:          1.7.0_80 (Oracle Corporation 24.80-b11)
OS:           Linux 4.4.0-87-generic amd64

 uname -a
Linux ubuntu-trusty-64 4.4.0-87-generic #110~14.04.1-Ubuntu SMP Tue Jul 18 14:51:32 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

build.gradle.txt

@lacasseio can you add a comment here about a workaround?


end use of placeholder maximum integer value

should have default values for min and max args of adjustNumberToWithinRange() be Number.MIN_VALUE and Number.MAX_VALUE, respectively.

this isn't necessary since fields in index.html have maximum values of 999 (or 3 for milestones and 6 for greeneries adjacent to a city)


Unescape foreign characters on slugs

What
Fix display bug by decoding unusual characters encoded in slugs
https://trello.com/c/EHrM18LF/1548-bug-some-foreign-language-slugs-stretch-the-page-title-column-width-in-the-table-and-link-to-page-not-found
Why
Page currently stretches and slugs are incomprehensible
Screenshots
Before

After

Closing since it's not the ideal approach.

@maxgds @cbaines
I have tried to escape the characters before storing them, but there are some scenarios that are not playing very well (for example, when opening the base_paths and parsing it) I would rather exploring it in detail in other stories, and do a short term fix for this issue.
I am now keen to merge this PR, hopefully you both are also happy with it.

No complaints from me... but then it was my solution to the issue :)

@maxgds sorry for going in circles with this fix. I am merging it.


[nrf fromlist] boards: nrf5340: use nrf_reset_network_force_off

The function nrf_reset_network_force_off contains workaround for errata 161 for nRF5340 SoC. This function should be used instead of manual writing to NRF_RESET->NETWORK.FORCEOFF register.
Upstream PR: https://github.com/zephyrproject-rtos/zephyr/pull/58045

FYI: @mariuszpos @jciupis @ahasztag

Note: Full fix to correctly apply errata 161 or nrf5340 requires that nrf53_errata_161 returns true on the application core.
That code will be fixed later, as it's part of the MDK.
https://github.com/zephyrproject-rtos/hal_nordic/blob/a1c3e0fbaafda091139b8744becd4853ada2f747/nrfx/mdk/nrf53_erratas.h#L5876

What is the reason for this PR being into sdk-zephyr and not upstream zephyr?

@erikrobstad  Upstream zephyr PR https://github.com/zephyrproject-rtos/zephyr/pull/58045 was already created.
This is [fromlist] PR, as it was originally meant to go into 2.4.0. To effectively fix errata 161 for nRF5340, it also requires the fix in the MDK which is likely to not happen quickly enough as I originally assumed.
see https://github.com/nrfconnect/sdk-zephyr/pull/1185#issuecomment-1554095423
see nRF MDK channel on teams,


Changing CollionsShape3D.shape.radius will paused disconnect signals

Godot version:

3.2.1
3.2-beta6

OS/device including version:

Linux/Debian10
GLES3

Issue description:
I have a scene with an area2D/CollisionShape2D. Area2D  send signals "mouse_entered" and "mouse_exited" to a script on Node2D node.
When mouse enter the Area2D i enlarge the shape radius of CollisionShape2D and reduce the size when mouse exit.
When the tree is not paused, it's work as expected. when mouse enter the CollisionShape2D grow up and when mouse exit it goes to normal size.
But is I set the  pause (get_tree().paused = true), when mouse enter the script receive 'mouse_entered' signal folow by 'mouse_exited' right after. And after once trigger
there is not more signal send to the script.
Minimal reproduction project:
Here a minimal project reproducing the bug.
In the script change the value of variable generatebug to reproduce the bug.
shapeBug.zip

From documentation:

If true, the SceneTree is paused. Doing so will have the following behavior:

2D and 3D physics will be stopped.

Node._process(), Node._physics_process() and Node._input() will not be called anymore in nodes.

I don't know if this is an issue, because it seems you're using this in the wrong way. Even if you unpause Area2D, the physics engine is paused, so it makes those weird behaviours.

Continuing the quoted part from the docs:

This effectively stops the whole game. Calling this function from a script, by default, will result in an unrecoverable state (nothing will work anymore!).

Maybe this is what's happening.

yes maybe in don't understand well how paused must work but it seems to me that the behavior isn't consistent. I my example if i don't change the shape, events (mouse enter/exit) work fine, regardless of the paused_mode of the node. It is when my code change the radius of the shape  of CollisionShape2D while the game is paused that the bug appears.
I will continue to investigate, it seem that i have added "get_node('/root').pause_mode = PAUSE_MODE_PROCESS" and this can be part of the problem.

Hello @octopus-io , @Anutrix is right. You have set get_tree().paused , but to continue the game you should set false to get_tree().paused method. You have used it incorrectly. You can check the documentation to follow pause behavior better : https://docs.godotengine.org/en/stable/tutorials/misc/pausing_games.html. Because changing a radius of shape didn't affect the behavior in my case.

Hi, after some test and research, i finally understand pause system.
I think all my problems came from  "get_node('/root').pause_mode = PAUSE_MODE_PROCESS".
During my test i also found an other bug but already referenced as #37870.
I think we can close this issues.
Thx, all.


where are the logs?  service keeps crashing

where can I view and monitor the logs?  My service keeps crashing and I cant tell whats going on.

systemctl status wyoming-satellite


[AMBARI-24788] Fix async bug in installer config page initial load

What changes were proposed in this pull request?
Fixed a bug in the loading process of the installer wizard config page that was causing it to appear blank initially. This was simply an async timing issue.
How was this patch tested?
All unit tests passing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4299/
Test FAILed.
Test FAILured.


error 403

Hi,
I'm getting 403 error on URL https://api.imgur.com/3/image
Here a debug portion with the error:
`++ curl --compressed --connect-timeout 5 -m 120 --retry 1 -fsSL --stderr - -F title=imgur-2016_05_11-23:42:27 -F 'image=@"/home/huntz/Pictures/imgur-2016_05_11-23:42:27.png"' -H 'Authorization: Bearer c86c6d574d02f2c9935f7227d477535a5e79c219' https://api.imgur.com/3/image

response='curl: (22) The requested URL returned error: 403 Permission Denied'`

I'm using Version v1.7.4 on Linux (and last week imgur-screenshot.sh was working correctly).
Thank you!

Just realized this issue was a duplicate.
Sorry :-)


Hard to input spaced words in list widget

In the "list" widget it's hard to input multiple words that contains space in between, for example when i need to input a list of tags where the tags are composed by multiple words.
google_screen_recording_2023-12-23T17-10_25.859Z.webm

Thanks for the heads-up! I came up with a simple workaround. I’ll overhaul the simple list UX early next year.

The fix is in!

Awesome!


Timestamp all messages!

Need to timestamp all messages. Not clear what the optimal way to timestamp messages is for now I am going to call System.currentTimeMillis() as suggested here.

Using system time was a bad default implementation. Now just have to pass a Long into the message constructor.


Roll Engine from 4fef55db1031 to 7429ad755f4e (25 revisions)

https://github.com/flutter/engine/compare/4fef55db1031...7429ad755f4e
2021-08-09<EMAIL_ADDRESS>Roll Skia from 717ef9472b56 to ad5944cf8dbb (7 revisions) (flutter/engine#27962)
2021-08-09<EMAIL_ADDRESS>Roll Skia from fdf7b3c41f8e to 717ef9472b56 (1 revision) (flutter/engine#27960)
2021-08-09<EMAIL_ADDRESS>Roll Skia from d27a0d39cea2 to fdf7b3c41f8e (1 revision) (flutter/engine#27958)
2021-08-09<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from TK8mj-iQr... to D6VF_8x5s... (flutter/engine#27957)
2021-08-09<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from iVa6afHb7... to 0iDbdLRq3... (flutter/engine#27956)
2021-08-09<EMAIL_ADDRESS>Roll Skia from a28795fd64a4 to d27a0d39cea2 (1 revision) (flutter/engine#27955)
2021-08-08<EMAIL_ADDRESS>[ci.yaml] Remove deprecated builder field (flutter/engine#27940)
2021-08-08<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from GBIahjoek... to TK8mj-iQr... (flutter/engine#27954)
2021-08-08<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from aDswwwLbx... to iVa6afHb7... (flutter/engine#27952)
2021-08-08<EMAIL_ADDRESS>Roll Skia from 6bc126d24d1b to a28795fd64a4 (2 revisions) (flutter/engine#27951)
2021-08-08<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from yZ4KOzDE1... to GBIahjoek... (flutter/engine#27949)
2021-08-07<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 6XsAe3sPr... to aDswwwLbx... (flutter/engine#27948)
2021-08-07<EMAIL_ADDRESS>Do not call CoreWindow::Visible from raster thread (flutter/engine#27760)
2021-08-07<EMAIL_ADDRESS>Roll Skia from ca13a3acc4b2 to 6bc126d24d1b (1 revision) (flutter/engine#27947)
2021-08-07<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from wX-ifEGo5... to yZ4KOzDE1... (flutter/engine#27945)
2021-08-07<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from XuRmqkWX2... to 6XsAe3sPr... (flutter/engine#27944)
2021-08-07<EMAIL_ADDRESS>Roll Dart SDK from cf20a69c75cf to 749ee4e9e053 (1 revision) (flutter/engine#27943)
2021-08-07<EMAIL_ADDRESS>Fix sample analyzer errors in text.dart (flutter/engine#27941)
2021-08-06<EMAIL_ADDRESS>Roll Skia from 94fcb37e5b4f to ca13a3acc4b2 (10 revisions) (flutter/engine#27938)
2021-08-06<EMAIL_ADDRESS>Fix the SurfaceTexture related crash by Replacing the JNI weak global reference with a WeakReference (flutter/engine#27924)
2021-08-06<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from q6H_ZE5Bs... to wX-ifEGo5... (flutter/engine#27937)
2021-08-06<EMAIL_ADDRESS>Roll Dart SDK from 6d96e6063edc to cf20a69c75cf (2 revisions) (flutter/engine#27935)
2021-08-06<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from rQOi2N8BM... to XuRmqkWX2... (flutter/engine#27934)
2021-08-06<EMAIL_ADDRESS>Fix routerinformationupdate can take complex json (flutter/engine#27932)
2021-08-06<EMAIL_ADDRESS>Implementation of two or more threads merging for multiple platform views (flutter/engine#27662)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from q6H_ZE5BsiK1 to D6VF_8x5sjLl
fuchsia/sdk/core/mac-amd64 from rQOi2N8BMbLj to 0iDbdLRq3J8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Remove init.py to prevent setup.py from installing tests.

We should instead do this.
Want to do it on this PR?


Authentication and new API URLs; Resolves #18, #19

@RichardAtCT, I was able to make some updates to the code. I have done the following:

Updated the API URLs in both OracleSwap and TransactionHelper classes
Added authentication options to both OracleSwap and TransactionHelper classes
Updated readme.md to include the added api_key parameter
Added a bit more error details in OracleSwap
Added a bit better error checking for None in TransactionHelper

I have done some testing, but not too extensively, didn't run any live transactions. However, the API's themselves didn't seem to have changed only the end points and authentication, so I relied on that.
Looks like the gas oracle API is no longer there, I just added a comment but left the code is for a future update.
If some of the code is not up to par, don't hesitate to let me know. I hope these updates can be incorporated and be helpful to all.

Thanks for the great pull request. My only concern before merging is that the transaction helper won't work without a valid gas-oracle. I have asked on 1inch discord if they have a option, otherwise will need to find a new source of gas price data.

@RichardAtCT I had an inkling that would be the case. Decided to submit the work so far, so there is progress on the issue.
Let me know what the community says.
I'll look around for other oracle options as well.

@RichardAtCT I tested the code and it was functional. I then more carefully tested that API, and it seems to be up and functional. Apologies for an inaccurate test and information the first time around.
Ex: https://gas-price-api.1inch.io/v1.3/1/
I think we should be good to go now on that account.
While testing, I also ran into an issue with passing of the address instead of a token name to a method, so I fixed it. I hope my fix is correct and acceptable.
I also added a new chain that 1 Inch now supports as well. So the pull request is a bit bigger now, but I hope the improvements are welcome. But feel free to let me know if something needs to be revised.

Well done on sorting out the gas! I’ll review during the course of today
and push to PiPy.
On Mon, 14 Aug 2023 at 7:45 AM makbeta @.***> wrote:

@RichardAtCT https://github.com/RichardAtCT I tested the code and it
was functional. I then more carefully tested that API, and it seems to be
up and functional. Apologies for an inaccurate test and information the
first time around.
Ex: https://gas-price-api.1inch.io/v1.3/1/
I think we should be good to go now on that account.
While testing, I also ran into an issue with passing of the address
instead of a token name to a method, so I fixed it. I hope my fix is
correct and acceptable.
I also added a new chain that 1 Inch now supports as well. So the pull
request is a bit bigger now, but I hope the improvements are welcome. But
feel free to let me know if something needs to be revised.
—
Reply to this email directly, view it on GitHub
https://github.com/RichardAtCT/1inch_wrapper/pull/20#issuecomment-1676627840,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHDKB3ZCCHTEKQG63CWIRX3XVGNNTANCNFSM6AAAAAA3ON5L3A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Stop shipping Linux 5.19.12, may damage LCD displays

Describe the bug
Kernel 5.19.2 has potential to damage LCD displays
<EMAIL_ADDRESS>Please bump kernel 5.19 to use 5.19.13 or 5.19.14 and stop shipping 5.19.12 ASAP
Steps To Reproduce
Steps to reproduce the behavior:

...
...
...

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@Ma27

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

5.19.14 is already out on master and release-22.05.
In fact, even nixos-unstable contains the fix already: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/os-specific/linux/kernel/linux-5.19.nix
The channel bump with the kernel update for 22.05 is in progress and finished as soon as https://hydra.nixos.org/build/193816017 has passed.
If you're using 22.05 and having that issue please downgrade either your kernel or your system. Alternatively, you can use a newer kernelPackages for boot.kernelPackages by importing it from a newer nixpkgs rev (i.e. not a channel).
Nothing actionable to do for the maintainers (for the record, I'm not the only kernel maintainer!), hence closing.


[terra-toggle-section-header] Added isOpen Prop

Summary
Added isOpen prop for programmatic toggle of the component.
Closes #2905
Deployment Link

https://terra-core-deployed-pr-2925.herokuapp.com/components/terra-toggle-section-header/toggle-section-header/toggle-section-header
Testing
Updated Jest snapshots and added new wdio test page and cases.

Talked to @neilpfeiffer. He will be coming up with details on whether we need to go ahead with these changes for terra-toggle-section-header.

Following up with Emily's question. Is this PR ready for review or are waiting on feedback from UX?

@saket2403 Any updates?


Feed Tracking

One of the simplest option to track how many users actually have read your post on RSS is to embed an 1x1 transparent image in each post. See for example RSS tracking.
It should not be hard to do
<content type="html" xml:base="{{ post.url | absolute_url | xml_escape }}">{{ post.content | strip | xml_escape }}<img src="{{site.url | xml_escape}}/empty.gif?{{ post.url | uri_escape | xml_escape }}" width="0" height="0" /></content>

And just copy the empty.gif in the root folder of _site.
This can be disabled by default and enabled with
feed:
   empty_gif: true

Of course you need to have web logs to actually track how many views you get.
It is very specific request, but possible more than just me will want it. Curious if this is something which can be considered to be merged in this project - if yes I can make a PR.

I think this is outside the scope of this plugin.

@pathawks sure, understand.
But then my question will be - how I can do that with jekyll-feed plugin? My current option is to use my own feed.xml template.
Maybe we can add an option to specify custom content generator or embedded code in content?

Thinking creatively here what if atom:logo were implemented and provided to end users? Feed enhancement plus analytics, small design impact.

@jhabdas not sure that this will do it, considering that this is just one logo per whole feed. In my case I actually have an empty.gif per every post, so I can actually see if user opened this post or not.

Ah good point. What about that media RSS thumbnail at the bottom of the entries. Could you inline a tracking pixel into it with a data:uri?

@jhabdas Think you need the image to live on a server so you can track the request. A data:uri'd image wouldn't do that would it?

Ah, also a good point. Well I'm 0-2 here. 😸


Zero-out DAC values when powering off.

As per comments on https://github.com/kanflo/opendps/issues/36.

Thanks, I'll try this out when I'm back next week.

I can confirm that this solves issue #36 for me.
Leaving i_out floating did not cut power for me. It also left me in an endless loop trigering OCP if to low, and not giving me a chance to chang it. Recommends:
diff --git opendps/hw.c opendps/hw.c
index b49682a..14c87ba 100644
--- opendps/hw.c
+++ opendps/hw.c
@@ -262,7 +262,7 @@ void adc1_2_isr(void)
measure_i_out = false;
}
}

if (pwrctl_i_limit_raw) {

if (pwrctl_i_limit_raw && pwrctl_vout_enabled()) {
if (adc_counter >= STARTUP_SKIP_COUNT) {
i += adc_i_offset;
if (i > pwrctl_i_limit_raw) { /** OCP! */

To solv that.

@tzarc, could you please try the suggestion from @jimmyw?

My patch did unfortenally stop meassuring adc when hit OCP, better fix is:
diff --git opendps/hw.c opendps/hw.c
index b49682a..14c87ba 100644
--- opendps/hw.c
+++ opendps/hw.c
@@ -262,7 +262,7 @@ void adc1_2_isr(void)
             measure_i_out = false;
         }
     }

     if (pwrctl_i_limit_raw) {
         if (adc_counter >= STARTUP_SKIP_COUNT) {
             i += adc_i_offset;
-             if (i > pwrctl_i_limit_raw) { /** OCP! */
+             if (i > pwrctl_i_limit_raw && pwrctl_vout_enabled()) { /** OCP! */

I'd test it, but my "working" branch results in a black screen after updating.
I guess it's something to do with the compiler, will probably create a standardised docker build "instance" which eliminates versioning issues and the like.
Will see what I can do.

Serves me right for not pulling from upstream... you already have a docker build!
Built and tested, my master branch working fine, branch updated.


Ability to filter by 'last modified date' in Employee database

I know this variable contains date and time, but if possible the ability to filter by date (I don't care about the time in the filter). Reason: to see at a glance what might have occurred on a single day (or multiple days).

Working as expected


add new currency

What about if add those currencies ?

[ ] FKP - £
[ ] MTL - ₤
[ ] SVC - ₡
[ ] BTC - Ƀ

Yeah looks like the list is missing those... You can just add them to currencies.js.


Versioned API route_class

Hello! We would like to be able to create an APIRouter using the route_class similar to what fastapi-versioning supports with versioned_api_route: https://github.com/DeanWay/fastapi-versioning/blob/18d480f5bb067088f157f235a673cb4c65ec77d5/fastapi_versioning/routing.py For example:
router = APIRouter(
    prefix="/myroute",
    tags=["MyRoute"],
    route_class=versioned_api_route(1, 1)
)

app.include_router(router)
versionize(app, ...)

Our local testing shows that dropping in versioned_api_route works okay with fastapi-versionizer but wanted to open an issue to see if you would want an PR opened for something like this or if you intend to keep @api_version the primary interaction.

@bostrt Just added this for you here and pushed 0.1.6 to PyPI.
I also added an example file and accompanying tests.
Let me know if you see any problems with this.

@alexschimpf thanks! I just tested it and works great :smiley:


[feature] Shell completion

Can it provide completions for common shells? TIA!

I found https://github.com/molovo/revolver/blob/master/revolver.zsh-completion


Can't connect to mongo docker

okey, spend a day, but still can't make this work

.env

# Mongo DB
MONGO_INITDB_ROOT_USERNAME=admin-user
MONGO_INITDB_ROOT_PASSWORD=admin-password
MONGO_INITDB_DATABASE=container

docker-compose.yml

 mongo-db:
    image: mongo:4.2.3
    env_file:
      - .env
    ports:
      - 27017:27107
    volumes:
      - ./bin/mongo-init.js:/docker-entrypoint-initdb.d/mongo-init.js:ro
    #    restart: always add this production

  api:
    build:
      context: ./backend
      dockerfile: Dockerfile
    command: uvicorn app.main:app --host <IP_ADDRESS> --port 8006 --reload
    volumes:
      - ./backend:/app
    env_file:
      - .env
    depends_on:
      - mongo-db
    ports:
      - "8006:8006"

mongo-init.js

db.auth('admin-user', 'admin-password')

db = db.getSiblingDB('container')

db.createUser({
    user: 'test-user',
    pwd: 'test-password',
    roles: [
        {
            role: 'root',
            db: 'admin',
        },
    ],
});

using this as example - https://frankie567.github.io/fastapi-users/configuration/full_example/
changed few lines:
DATABASE_URL = "mongodb://test-user:test-password@mongo-db/container"
client = motor.motor_asyncio.AsyncIOMotorClient(DATABASE_URL)
db = client["container"]
collection = db["users"]
user_db = MongoDBUserDatabase(UserDB, collection)

so think Fatapi is linked to Mongo container

but when i try to register user using Fastapi docks section, i get
"Internal server error"
what I left unfinished?

Hi @galvakojis!
If you get an internal server error, you'll likely have some stacktrace in your api container. Could you provide it? Doing something like docker-compose logs -f api should output the logs.
Cheers!

Ok sorry, so it is working, but why? I will let you know tomorrow :D


Second Stab at fixing NgramModel

This is a response to #800. I foolishly merged in changes from the develop branch. For clarity, @stevenbird, could you pull the latest develop changes into the "model" branch, so that only my commits are visible? Sorry to ask, this situation's my fault.
The changes I'm proposing are as follows:

cleaned up FreqDist and it's attributes
ConditionalFreqDist now inherits from FreqDist, solving the issue of override_N mentioned #800; it is also designed in a way that most ProbDist classes can use either.
ConditionalProbDist is no longer used; NgramModel directly calls LidstoneProbDist or any other ProbDist class. This makes it conceptually clearer.

Thanks @Copper-Head!

It looks like this completely changes the API for ConditionalFreqDist and breaks all kinds of things (including the tests and all the documentation).  Now to get a count for a condition/sample you need cfd[(condition, sample)] rather than the old cfd[condition][sample].  Also, now there's no way to easily get a FreqDist given a condition or to initialize a CFD from a list of (condition, sample) pairs. Is this what was intended?  Am I missing something?

Oh dear, I didn't see that. There was no justification for changing the API in this way, and we'd never roll out such a pervasive change in a minor release.
@Copper-Head would you please leave ConditionalFreqDist as a dictionary of FreqDist?

@rmalouf, @Copper-Head – I've undone these changes, since they are too pervasive and were never agreed. I shouldn't have merged. I hope the work on fixing ngram model can continue, but without modifying existing APIs.

Gotcha. I'll put something up that's not as drastic a change!

Thanks @Copper-Head


Duplicate Object Key in VS Code Settings

Bug Report

TSLint version: 5.10.0
TypeScript version: 2.8.3
Running TSLint via: (pick one)  VSCode

There's no code being linted it's all working except there's 50 problems in the problem window and they are all Duplicate Object Key errors for TSLint settings. All I did was follow docs, npm install -g typescript tslint and then I installed the tslint extension for VSCode.
I did a search for an issue like this, nothing came up here. I did a search online and found stuff on the VSCode GitHub but no solution or description as to why. I did find another extension having this and they said that they were going to stop their extension from adding the settings. Idk if that helps or not.
Have I done something wrong in the install process? How could I fix this?
Thanks for all the work.

@DanJ210 can you share a screenshot of VSCode with the errors? i've never seen this before. i also refuse to install these tools globally, instead using the workspace versions.

Yes, here's a screenshot. I mean I'm a junior dev so I'm installing globally for now as I haven't had a problem. For now I'll keep doing it until I'm more comfortable with the process entirely.

@DanJ210 this looks like an error in jsonc, not in tslint (per the tags at the beginning of each error)

So what does that mean? This only started happening with tslint. I've had VS Code going for months.

@giladgray The screenshot is showing only a short list of the 50+ errors so saying that the error is [jsonc] from that small amount of evidence is inaccurate. Also [jsonc] is what's showing the error message that I have duplicate entries all from tslint so that has nothing to do with the problem, it's only finding and reporting that I have duplicate entries.
tslint are the only settings that have duplicates. What issue is that?
Do I need to make another issue since this was erroneously closed?


Rewrite test cases in TS

This PR:

Rewrite test cases in TypeScript for better intellisense and type check.  (*.test.js => *.test.ts)
Add a new tsconfig.test.json dedicated for compiling *.test.ts into *.test.js files. (tsconfig.json is responsible for buiding the project, and the common part is extracted into tsconfig.base.json)

comments addressed, I'm merging it now.


Add Github actions

Add Github Actions scripts for test and code coverage report
Add CodeClimate to the repository

Closed via #5


Iteration methods missing from ReadonlyMap and ReadonlySet.

TypeScript Version:  2.2.1
Code
const x: ReadonlyMap<number, string> = new Map([[1, "a"], [2, "b"]]);

for (const k of x.keys()) {
  console.log(k);
}

Expected behavior:
No error.
Actual behavior:
error TS2339: Property 'keys' does not exist on type 'ReadonlyMap<number, string>'.

ReadonlyMap and ReadonlySet both lack all the methods that return iterators. Map has this set:
interface Map<K, V> {
    [Symbol.iterator](): IterableIterator<[K,V]>;
    entries(): IterableIterator<[K, V]>;
    keys(): IterableIterator<K>;
    values(): IterableIterator<V>;
}

There's an similar set of declarations for Set. None of these should be modifying the Map or the Set so they should be available on the readonly versions too.

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.


Sorting with transition

How to sort the list with transition if the size of items are not the same?
here is my example:
http://jsbin.com/zixovaxowa/23/edit?html,css,js,output
Thank you very much!

Alas, no way.


Fix Preceiver creation in prometheusreceiver/factory.go to pass the logger

Change in https://github.com/open-telemetry/opentelemetry-service/pull/65 did not implement this.
Preceiver creation in prometheusreceiver/factory.go to pass the logger. That in turn will require CreateMetricsReceiver() to accept the logger as a parameter.

Also look into adding E2E test for Prometheus: https://github.com/open-telemetry/opentelemetry-service/issues/67

Understood - I'll put together a pr for it.

Looked into the issue - for clarification, factory.CreateMetricsReceiver(...) currently takes two standard parameters (i.e. cfg and consumer) - simply adding the parameter to my local CreateMetricReceiver doesn't compile (unsurprisingly)
To add the logger, it looks like I need to update the CreateMetricReceiver signature in https://github.com/open-telemetry/opentelemetry-service/blob/master/internal/factories/factories.go and update all uses - is that correct?

@dinooliva yes, that's correct.
@owais you also needed exactly this. Any chance your already started working on this?

For uniformity we also need to pass the logger to CreateTraceReceiver.
We already pass the logger in CreateTraceProcessor/CreateMetricsProcessor as the first parameter, so let's make it the first parameter everywhere.
We can also do the exact same thing for exporters, either in the same PR or as a separate PR.

@owais you also needed exactly this. Any chance your already started working on this?

No, not working on this specifically and would benefit from this greatly. Thanks.

Sounds good - I should be able to take care of it early next week.

Fixed. I've also created issue #75 for exporters - I'll try to fix that one later this week.


patch out scikit-build

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam @BastianZim @chrisburr this pr replaces the scikit-build build system with setuptools, which likely caused the issues described in https://github.com/conda-forge/rapidfuzz-feedstock/issues/112. Could you tests whether those issues still occur with the patch in this PR?

https://github.com/conda-forge/jarowinkler-feedstock/pull/22 is a better fix

Thanks. Sorry just saw it now. Happy to test anything else if you need?