[Feature Request] An option to disable items description

Hi.
I think it is good idea to have an option to disable item description, because it can increase readability while data displayed in desc is not essential. With this setting on space currently used by description can be used for clipboard text continuation.
Now it can be done on non-transparent terminal window by making desc color same as background, but transparent windows lacking this feature.

Hi @ArtemChandragupta :wave:
Thank you for the suggestion. I agree this would be worth implementing! I'll look into the best way of handling this for future releases. Also feel free to raise a PR if you would like in the meantime :smile:


Corrupted Hologram

Hi there,
I have a bit of a problem with your plugin. I am developing a server and wanted to add holograms to switch up the signs.
Therefore, I tried Holography to create a hologram, but I couldn't change the content or remove it.
Now I'm trying DecentHolograms (sorry), but I wish to remove the corrupted hologram.
What kind of entity is it?
I also tried /minecraft:kill @e[type=!minecraft:player, distance=2] near the hologram, but it didn't work. How can I remove it and move forward with my project?

Solution:
/minecraft:kill @e[type=minecraft:text_display]
(/minecraft:kill @e[type=!minecraft:player] wasn't safe and i'm not sure why didn't work with distance=2)


CSV executable names don't match cmake or build output

While attempting to run conformance tests with run_conformance.py I noticed that the executables named in test_conformance/opencl_conformance_tests_full.csv don't match the names in any of the test CMakeLists, so the script can't find the test executables to run. For example the first test listed is computeinfo/computeinfo, but the computeinfo CMakeLists starts with add_executable(conformance_test_computeinfo, so the path to the test after building it is actually
computeinfo/conformance_test_computeinfo. I have a fix ready locally that renames the tests in all of the csvs to reflect the CMake, but I wanted to raise the issue here before opening a PR in case I'm missing something about script usage or the purpose of the csvs included in the repo.

@aarongreig during the CTS build, while generating config files change the -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=./bin to -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=.
This will put the output binaries to the location where opencl_conformance_tests_full.csv is searching, eg : computeinfo/test_computeinfo
Complete command:
before
cmake -DCL_INCLUDE_DIR=${TOP}/OpenCL-Headers -DCL_LIB_DIR=${TOP}/OpenCL-ICD-Loader/build -DCL_LIBCLCXX_DIR=${TOP}/libclcxx -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=./bin -DOPENCL_LIBRARIES="-lOpenCL -lpthread"
after
cmake -DCL_INCLUDE_DIR=${TOP}/OpenCL-Headers -DCL_LIB_DIR=${TOP}/OpenCL-ICD-Loader/build -DCL_LIBCLCXX_DIR=${TOP}/libclcxx -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=. -DOPENCL_LIBRARIES="-lOpenCL -lpthread"

@aarongreig  I believe this has now been fixed by @kbenzie's https://github.com/KhronosGroup/OpenCL-CTS/pull/705. Please re-open the issue if there are still name mismatches.


Improved validation of input files

Description of new feature
Common problems with input files should be detected by the app, and the user should get clear feedback for how to resolve the issues in their data.
Motivation for new feature
There may be inconsistencies (lack of standardisation) in the data, and without proper guidance users will tend to just give up and leave.

25s end-to-end, or 25s just piping the data in express?

On Nov 23, 2022, at 14:18, Mike Kucera @.***> wrote:
What do you think should be the limit on the expression file upload size? I have an expression file with real data that is 25MB. When I increase the express payload limit to accept a file this big it runs in about 25s on my machine.
—
Reply to this email directly, view it on GitHub https://github.com/cytoscape/enrichment-map-webapp/issues/42#issuecomment-1325552830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHRO433UGFXTQWUXC3JU5DWJZUXFANCNFSM6AAAAAASJFQSQA.
You are receiving this because you authored the thread.

25s end-to-end, from clicking Submit to seeing a network

The majority of that is in the R service, calculating the ranks. Both the FGSEA part and the EM part are pretty fast. 25s seems pretty good to me, but of course that number is in a dev environment on my machine so maybe not applicable to a production environment.

Yeah, we’ll have to see what it’s like on a prod environment.  Do Ruth’s and Veronique’s files have a typical size?

On Nov 23, 2022, at 15:29, Mike Kucera @.***> wrote:
The majority of that is in the R service, calculating the ranks. Both the FGSEA part and the EM part are pretty fast. 25s seems pretty good to me, but of course that number is in a dev environment on my machine so maybe not applicable to a production environment.
—
Reply to this email directly, view it on GitHub https://github.com/cytoscape/enrichment-map-webapp/issues/42#issuecomment-1325623822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHRO42I6VZM2SOIKBYJWWDWJZ5EPANCNFSM6AAAAAASJFQSQA.
You are receiving this because you authored the thread.

Closing. Use new issues as particular problems come up


why is it throwing error even if correct user field is sent in the request

I have created a collection as follows:
field  type
title - text, content - text, imgurl - URL, user - usertype
My Request:
{"title":"test","content":"contents","imgurl":"https://images.freeimages.com/images/large-previews/256/spring-1376144.jpg","user":{"id":"7cfcsyq777bzv1d","created":"2022-10-09 16:23:04.149","updated":"2022-10-09 16:23:04.149","email":"hello@gmail.com","verified":false,"lastResetSentAt":"","lastVerificationSentAt":"","profile":{"id":"f17g1qtdan7nfgh","created":"2022-10-09 16:23:04.149","updated":"2022-10-09 16:23:04.149","@collectionId":"systemprofiles0","@collectionName":"profiles","avatar":"","name":"","userId":"7cfcsyq777bzv1d","@expand":{}}}}
Server Response:
{"code":400,"message":"Failed to create record.","data":{"user":{"code":"validation_required","message":"Missing required value."}}}
what is wrong with the user field?

You have to pass only the user id, not the whole object. Or in other words, your request body should be:
{
    "title": "test",
    "content": "contents",
    "imgurl": "https://images.freeimages.com/images/large-previews/256/spring-1376144.jpg",
    "user": "7cfcsyq777bzv1d"
}

I'll close the issue since I've tested it locally and it works as expected when the user id is provided (we also have integration and unit tests for each field types).


Configurable DB schema and table prefix

Added especially DB_SCHEMA and DB_TABLE_PREFIX as optional settings in order to be able to integrate the data in an existing DB and schema. This requires the migrations to be deleted from the alembic versions folder.
I think this folder can be removed/gitignored from the version control. Right now the data is anyway deleted when running a new merge.
Additional with DB_ALEMBIC_RESTRICT_TABLES there is the option to ignore all other tables in the DB except the specific eCharm model tables.

Currently adding new migrations doesn't work for me, have to check if this is due to the change here


get-metadata: missing 'LGTM' in comments

PR: https://github.com/nodejs/node/pull/18630
Command: winpty get-metadata.cmd 18630 --check-comments
Output:
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/18630
Reviewed-By: Colin Ihrig<EMAIL_ADDRESS>Reviewed-By: Ruben Bridgewater<EMAIL_ADDRESS>--------------------------------------------------------------------------------

Missing: https://github.com/nodejs/node/pull/18630#issuecomment-363920740

@vsemozhetbyt just want to confirm did the get-metadata output had something that said maclover7 approved via LGTM in comment or something along those lines? since this is all we do currently and it's not included in generated metadata.

@cPhost

Full output:
√  Done loading data for nodejs/node/pull/18630
----------------------------------- PR info ------------------------------------
Title      doc: fix link in https.md (#18630)
Author     Vse Mozhet Byt<EMAIL_ADDRESS>(@vsemozhetbyt)
Branch     vsemozhetbyt:doc-fix-link-2018-02-07 -> nodejs:master
Labels     doc, fast-track, https, ready
Commits    1
 - doc: fix link in https.md
Committers 1
 - Vse Mozhet Byt<EMAIL_ADDRESS>------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/18630
Reviewed-By: Colin Ihrig<EMAIL_ADDRESS>Reviewed-By: Ruben Bridgewater<EMAIL_ADDRESS>--------------------------------------------------------------------------------
√  Requested Changes: 0
√  Approvals: 2, 1 from TSC (cjihrig)
i  Last Full CI on 2018-02-07T21:39:06Z: https://ci.nodejs.org/job/node-test-pull-request-lite/159/
i  This PR is being fast-tracked
‼  This PR is closed

Ok thanks, this is a bug.

I think we have already discussed about this. This is by design - only comments that contain nothing but LGTM will get a warning, other types of comments don't get anything at all, because there will always be  "something LGTM but I am not the expert in other things", and other types of thing that don't make them legitimate sign-offs.

BTW in those cases, something like https://github.com/nodejs/node-core-utils/issues/140 would be more suitable because without NLP code, humans are better at deciding if a comment with "LGTM" is legitimate sign-off

I think we have already discussed about this. This is by design - only comments that contain nothing but LGTM will get a warning

Oh, okay it does make sense now, so this is not a bug. I glanced at the PR again quickly to get some idea all i got was we don't include in metadata which i already knew, and something that said <name>(<username>) approved via LGTM in comment) 😅.

Gonna close this one since it's pretty old and i don't think this is something there's wide interest in doing but please reopen if that's not the case!


Fix config directory (Fixes #337)

With a bit of troubleshooting on my end, I believe I was able to fix the error I experienced in #337. The texts seemed like they were passing based on the incorrect assumption of XDG_CONFIG_HOME being set to $HOME/.config/boilr

Don't know how I didn't get notified about this or didn't see it. Sorry for the wait, I will have a look!


Replace casting 0 to a pointer with nullptr.

Summary of the Pull Request
When I did my last PR that was merged, the PR #4960, there were two more cases I forgot to include, so I included them here, for the sake of consistency and completion

References
PR #4690

PR Checklist

[X] CLA signed. If not, go over here and sign the CLA
[X] Tests added/passed

Detailed Description of the Pull Request / Additional comments
Replacing pointer casts to 0 with nullptr in two tests.

Validation Steps Performed
Manual Testing
Automated Testing

100% sure


Scrum Update - Jul 06

Register user to the database, and an authentication process.
We are running an issue to use meteor to store product info.
We are going to improve our ui and product list page and validate the register and login form.

We are going to styling our UI, main product page, register form.
Authentication process.

Build the help page, and the product page.
re-write the Google Map to have more function useful.


Temperate Rainforest missing leaves

Thicket and Forested Hills are also leaf-less, a few others might also be afflicted.
They all seem to be the same basic tree type, so fixing it might fix the entire problem.

Those trees are not from my mod, so it has nothing to do with me.

Sorry about that!


bugdown: Fix type annotations.

In some functions the first parameter was wrongly annotated as markdown.Markdown. Change that to text_type.
I also checked that markdown.Markdown is not a subclass of str.
@showell git blame says you were the last person who edited or added annotations to the functions convert and do_convert. Was it you who annotated the first parameter as markdown.Markdown? If yes, was there a reason for that? Maybe I'm missing something.

Automated message from Dropbox CLA bot
@sharmaeklavya2, it looks like you've already signed the Dropbox CLA. Thanks!

@sharmaeklavya2 I touched those annotations, but only to add new parameters.
It was actually you that originally annotated these functions.  :)
See a485d639753e7c17f29a31d9f212366f4f8a8f28
In addition to your current change, I think it might make sense to rename that md variable, because it seems like it would refer to some kind of converter object instead of content.  I think the variable name was the initial source of confusion.

I have changed the parameter name from 'md' to 'content'.

I wasn't the one who originally annotated these functions. They were annotated in 2916fb3.

Oops!  I guess we both made a similar error interpreting git blame.  Sorry!
Your changes look good to me--thanks for fixing the variable name.
Here's an article that I just found on the web: http://blog.andrewray.me/a-better-git-blame/

Nice catch!  Merged, thanks @sharmaeklavya2!


Support Opsgenie's API version 2

As per the docs. This patch fixes #1471.

@Qmando , Have you had a chance to look at this?  I'm pushing ElastAlert in my company and we recently signed up with OpsGenie, only to find that ElastAlert doesn't work since this breaking API change.


update respone time formula proxy metrics

Updated the respone time calculation formula to segregate by status_code  onto numerator and denominator while calculating average.

/lgtm

/ok-to-test

/retest

@ranakan19 it looks like your rebase didn't work as planned. Please remove the extra commits.

I did the rebase in another PR as I could not update that one: https://github.com/redhat-appstudio/infra-deployments/pull/3232
closing this one


Migrate to Jakarta EE APIs

Hi there,
is there a roadmap to migrate rest-assured to Jakarta EE APIs? For example the Spring Framework is planning to migrate in the next year:

Spring Framework 6 and Spring Boot 3 are planned towards a high-end baseline for their general availability in Q4 2022:

Java 17+ (from Java 8-17 in the Spring Framework 5.3.x line)
Jakarta EE 9+ (from Java EE 7-8 in the Spring Framework 5.3.x line)

https://spring.io/blog/2021/09/02/a-java-17-and-jakarta-ee-9-baseline-for-spring-framework-6

More information from the Eclipse Foundation: https://www.eclipse.org/community/eclipse_newsletter/2020/november/1.php

As the issue has been opened some days ago now - it would be great to hear something about the teams plans upon this topic.
We are using restassured everywhere on our platform currently in conjunction with Spring Boot 2. We are really looking forward on using Spring Boot 3, especially because of JDK-17 and the native stuff coming.
We are very pleased with restassured so far and would really like to stick with it.
@wilkinsona What consequences will we face if we upgrade to Spring Boot 3 without having restassured supporting the given APIs?

That's really a question for the REST Assured team if you want a definitive answer. As far as I could tell, JAX-B is a required dependency and REST Assured fails fairly fundamentally if the javax.xml.bind classes from EE 8 aren't available.

I'll look into this and see if I can make any progress.

Can you still use Java 8 with the jakarta API?

@wilkinsona And do you think it'll be fine to use Jakarta EE 9 for rest assured for the time being? Maybe I should drop support for Java 8 in the future, but I'd like to wait a bit longer if possible.

Requiring Jakarta EE 9 at this point is a pretty big jump. We're heading in that direction for Spring but our releases that make the jump aren't due until the end of this year. Even once they're out, we'll continue to support EE 8 for quite some time as we're anticipating lots of users sticking with EE 8. In short – and I know this isn't going to be easy – I think supporting both EE 8 and EE 9 is going to be necessary across the ecosystem for the next 24-36 months.
To minimise that burden, I'd try to isolate yourself as much as possible from Jakarta EE and minimise your dependencies upon its APIs. Where you have to depend on it, try to make those dependencies optional. For example, if a REST API isn't doing anything with XML, perhaps REST Assured could avoid loading any JAX-B classes.

Easier to keep 4.x.x in a separate maintenance branch for JAVA EE 8 and use a different branch(preferably master) for Jakarta 9.x.x.

I'm not sure that doubling a project's maintenance burden is going to be easier, particularly when resources may be stretched pretty thin already.

@wilkinsona Thank you for your explaination. I think that I'll try to make the dependency to jaxb optional.

@wilkinsona Maybe you could clarify some more points and give me some additional tips if you don't mind? :) I'm in the process of making the JAXB dependency optional and I think that'll work. However, I have two questions:

Is the "removal" (making it optional) of JAXB what's actually required for Spring Boot to work with REST Assured again?
I'd like to add support for Jakarta EE 9 but, if I understand it correctly, Jakarta EE 8 and 9 have the same groupId and artifactId but different version numbers. Currently, in trunk, I have (optional) dependencies on version 2.3.x of jakarta.xml.bind:jakarta.xml.bind-api and org.glassfish.jaxb:jaxb-runtime (Jakarta EE 8). But I'd like to have version 3.x of these two libraries at the same time as an optional dependency in Maven. Is there a way to work around this that you're aware of?

Is the "removal" (making it optional) of JAXB what's actually required for Spring Boot to work with REST Assured again?

I can't say for certain without being able to try it, but I would expect that for a large percentage of users this will be absolutely fine as they'll be working with JSON-based APIs and won't care about XML

Is there a way to work around this that you're aware of?

Different projects have been approaching this in different ways:

Maintain one set of source code (typically using the javax.* APIs) and then use the Eclipse Transformer to generate classes that use the jakarta.* APIs automatically. Typically published as separate modules and users then need to select the right one. Hibernate has taken this approach.
Use an older version of the javax APIs alongside the jakarta APIs in the same module and take advantage of the different group IDs. For JAX-B that would be javax.xml.bind:jaxb-api:2.3.1 and jakarta.xml.bind:jakarta.xml.bind-api:3.0.1. Thymeleaf has taken this approach.
Maintain two separate source modules, one that uses the javax APIs and one that uses the jakarta APIs. Published as separate modules and users then need to select the right one.

I think 1 works well for a project, like Hibernate, that implements an EE API (JPA in this case). 2 seems to work well for a project that only consumes an EE API and may be a better fit for REST Assured, particularly if you can switch between javax JAX-B and Jakarta JAX-B at runtime depending on what's available on the classpath.

@wilkinsona Thanks a lot for the clarification, this is really invaluable to me!
When it comes to question number 1, I was mainly asking from a spring-boot perspective. Because I think Spring Boot has removed rest-assured in version 3 if I'm not mistaken. My goal is to get it back :) But I wonder what I need to do in order to get it back as a managed dependency by spring boot 3? Is it enough to remove the explicit JAXB dependency, or is jakarta ee required, or/and is it something else? If you don't know, do you know who I should talk to?

We removed REST Assured support due to the hard dependency on JAX-B from EE 8. Once REST Assured can be used in an EE 9 environment (even if that means there's no XML support), we'll be more than happy to reinstate support for it. The same goes for Spring REST Docs from which REST Assured support has also been temporarily removed for the same reasons.

There's plenty of time. While Spring Boot 3.0.0-M1 is scheduled for this Thursday, we're quite comfortable with releasing it without REST Assured support. We know that Jakarta EE 9 support across the ecosystem is going to take a while which is, in part, why we're having a longer development cycle for 3.0.0 (almost 12 months) and it won't GA until November 2022.
The dates for 3.0's milestones are on GitHub. They're every two months until M5 in September and then there's an RC in October before GA in November. That's the current plan anyway.

@wilkinsona Thanks again for all your feedback and for responding so fast.
Unfortunatley I ran into an issue with Intellij (https://youtrack.jetbrains.com/issue/IDEA-286871) and currently I can't even compile REST Assured so I have to use Sublime which is suboptimal. But regardless of EE 9 or not, I still want to make a new release as soon as I can, it's long overdue.

Spring Cloud contract has a hard dependency. We release a week after boot, if that could be possible, we would appreciate it

@spencergibb Thanks for letting me know! I'll try my very best to release a new version this friday!

@spencergibb Or do you mean I should try to create a release sooner (before Thursday?)

@johanhaleby I did not encounter this problem with Maven 3.8.4 and this change in the root pom.xml:
    <parent>
        <groupId>org.sonatype.oss</groupId>
        <artifactId>oss-parent</artifactId>
        <version>9</version>
    </parent>

I had to upgrade this version because the old one still used JCenter as repository. Now it fails due to a compilation error related to the JAXB migration:
[INFO] Reactor Summary for REST Assured Parent POM 4.4.1-SNAPSHOT:
[INFO]
[INFO] REST Assured Parent POM ............................ SUCCESS [  0.940 s]
[INFO] REST Assured Modules ............................... SUCCESS [  0.024 s]
[INFO] json-schema-validator .............................. SUCCESS [  6.073 s]
[INFO] rest-assured-common ................................ SUCCESS [  6.697 s]
[INFO] json-path .......................................... SUCCESS [  7.419 s]
[INFO] xml-path ........................................... SUCCESS [  7.257 s]
[INFO] REST Assured ....................................... FAILURE [ 10.094 s]
[INFO] spring-commons ..................................... SKIPPED
[INFO] spring-mock-mvc .................................... SKIPPED
[INFO] Scala Support ...................................... SKIPPED
[INFO] spring-web-test-client ............................. SKIPPED
[INFO] kotlin-extensions .................................. SKIPPED
[INFO] spring-mock-mvc-kotlin-extensions .................. SKIPPED
[INFO] rest-assured-all ................................... SKIPPED
[INFO] REST Assured Examples .............................. SKIPPED
[INFO] Scalatra Example ................................... SKIPPED
[INFO] Scalatra REST service example ...................... SKIPPED
[INFO] REST Assured Java integration tests ................ SKIPPED
[INFO] Spring MVC example ................................. SKIPPED
[INFO] Scala Example ...................................... SKIPPED
[INFO] Scala Spring Mock MVC Example ...................... SKIPPED
[INFO] Kotlin Example ..................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  40.829 s
[INFO] Finished at: 2022-01-18T13:33:51+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.gmaven:gmaven-plugin:1.5:compile (default) on project rest-assured: startup failed:
[ERROR] file:/C:/Users/broj/Downloads/rest-assured-master/rest-assured/src/main/groovy/io/restassured/internal/mapping/JaxbMapper.groovy: 43: unable to resolve class javax.xml.bind.JAXBContext
[ERROR]  @ line 43, column 36.
[ERROR]            javax.xml.bind.JAXBContext jaxbContext = factory.create(object.getClass(), charset)
[ERROR]                                       ^
[ERROR]
[ERROR] file:/C:/Users/broj/Downloads/rest-assured-master/rest-assured/src/main/groovy/io/restassured/internal/mapping/JaxbMapper.groovy: 44: unable to resolve class javax.xml.bind.Marshaller
[ERROR]  @ line 44, column 35.
[ERROR]            javax.xml.bind.Marshaller marshaller = jaxbContext.createMarshaller()
[ERROR]                                      ^
[ERROR]
[ERROR] 2 errors

Friday is fine

@thetric That works for me too! It's not optimal, but at least now I can work in Intellij. Thanks a lot!

Thanks very much for this, @johanhaleby. I've reinstated support for REST Assured in Spring REST Docs and Spring Boot. It's available in their 3.0.0-SNAPSHOTs and will be in their 3.0.0-M2 releases in March.

Just wanted to drop a note to thank you all for your efforts. Spring and REST Assured are both invaluable tools for us, and your efforts are greatly appreciated!


Commit some components conflict of the problem

The notes have been created
The scene has been restored
https://codepen.io/dreamcc/pen/mxbPGa

It's all form components.
Using dropdown and collapse components, this conflict is a problem in which input function labels are added.all will there are such the problem

2.It is recommended to add some color element styles to redio  and switch  and checkbox.
It should be too close to grey, so it's hard to see them.
3.The collapse component and the falling component feel like a function.

Should be some components in the form.
Lack of color matching function and solution.
so is why we found these problems.

@chongzia  Dear friend! Write the code in accordance with the documentation.
<button class="button dark p-0 small" style="width:120px;">
          <input type="radio" data-role="radio"
                 data-caption="test" name="storeid" value="">
</button>

In Metro 4 no such constructions. Use the components of Metro 4 as they are described in the documentation and do not come up with absurd designs.

I said my face was red.
awkward
Can I change it?

          <input type="radio" data-role="radio"
                 data-caption="test" name="storeid" value="">

Weak weak ask, such line not line
Use div to change the shell style of the component.
The point is not here,
The emphasis should be on single box, multiple marquee, switch,
they have no color scheme,
if I simply use color, can not change his color style.

Scheme builder in develop. In this time you must manually redefine styles for the required component.
How to change, you can see in
https://github.com/olton/Metro-UI-CSS/blob/master/less/schemes/builder/builder.less#L149

I'll keep an eye on it


chore(sensor_plus): remove unused file

Description
Running the command to find unused files showed, that the web_utils.dart file is not used and I didn't find any references in the code. So it looks like this file is indeed unused.
Related Issues
None.
Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I titled the PR using Conventional Commits.
[X] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[X] No, this is not a breaking change.

@vbuberen fyi


NIFI-5145 Fixed evaluateAttributeExpressions in mockpropertyvalue to …

…make it handle null flowfiles.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@joewitt can you review this commit?

@markap14 can you review? Since you brought this up on the dev list, here's the simple summary:
The test framework is too strict on processors where input is optional. In those cases, it's common to just call evaluateExpressionLanguage with a null flowfile, but the test framework won't allow that. So it reports false negatives on execution that would go through with live execution of the processors.

@alopresto can you review? See comment above.

@joewitt can you review?

@mattyb149 can we close this out?

What is the current state of this PR? The tests are passing but they were before that. Does ListFTP or some processor break without this fix? If not, one comment above implies something would be broken without another Jira/PR on its heels. I thought because of the issue between FTPTransfer and ListFTP's properties, the flow file attributes won't be honored?

@mattyb149 @alopresto I backed out the FTP-related changes and put a temporary fix in there that handles the edge case that was impacting the FTP processors. There are two cases that cause trouble right now:

You pass a null flowfile to the evaluateExpressionLanguage(FlowFile) method while it is set to use flowfile attributes.
You pass a null flowfile to that method when it is set to use the variable registry.

Since, for the time being, the execution framework doesn't care about these things, I think this should work as a solution until that changes.

@mattyb149 Regarding your question about what is blocked by this PR, there are some integration tests in the Mongo package that break without this because the Mongo processors have optional input. Anything with optional input would break without this because you have to have the test framework take a laissez faire attitude toward null flowfiles just like the execution framework does. When no connection is there, all flowfiles passed in will be null and I don't think forcing a null check in each processor is as clean as funneling that null check into the evaluateExpressionLanguage methods.

+1 LGTM, let's tackle the FTP stuff in a different Jira. Thanks for the improvement! Merging to master


Added members of Working Group (plus authors from SCS) to list of authors.

Added WG members to list of authors.
Description
Added WG members to list of authors.
Motivation and Context
Give credit to everyone contributing.
How Has This Been Tested?
Still valid MD that can be rendered.

Please let me know if I missed anyone or someone should NOT be on the list as she or he should be reviewer rather than author and can not be both.


Enhancement request: mnemonic seed phrase support

Allow the user to view a mnemonic seed phrase instead of adding the alpha numeric private key added to the clipboard.

Starting with v0.0.12 you can paste a private key OR enter your secret recovery phrase.


Error when pulling dependencies

I am getting the following error when pulling dependencies from the example project folder
go get -u ./...
# github.com/qor/qor-example/db/seeds
runtime.main_main·f: relocation target main.main not defined
runtime.main_main·f: undefined: "main.main"

seems like not a qor related question, maybe use $GOPATH/src/github.com/qor/qor/update_all_qor_repos.sh to update all qor libs first?


Allow to set duration instead of seconds for task wait configuration

I some cases, you want to have a high number of request from a small amount of users which is not possible with second as the time units. This allow you to set a waiting time in Duration.

Another very nice PR, thanks again! I'll merge once you address the minor feedback above to make the code a little more readable.


Fix very nonobvious check behavior for OrderableSlsVersion and NonOrderableSlsVersion

Before this PR

check is not overridden by OrderableSlsVersion or NonOrderableSlsVersion, which means it's the same as calling SlsVersion.check which has different expected behavior in a confusing and unexpected way.
Additionally, SlsVersion::check caught an IllegalArgumentException when what was actually being thrown was a SafeIllegalArgumentException in some cases.
I also cleaned up a couple of things the compiler was complaining about
After this PR
==COMMIT_MSG==
Implement check method for OrderableSlsVersion and NonOrderableSlsVersion with correct semantics. Also fixes a case where this method would throw a SafeIllegalArgumentException unexpectedly.
==COMMIT_MSG==
Possible downsides?

Released 0.11.0

thanks @iamdanfox !


As a home baker with multiple orders, I can add orders with delivery dates and remarks for each order

so that I can keep track of orders that i currently have and its details

Include testing

Can we close this issue?


Extend testing environments to include other python 3.x version

Add testing environments (CI) to automatically test python 3.x versions other than python 3.5.

@Benardi , could you please elaborate? Do you mean in tox.ini, if we change it to support python 3.5 & python 3.6 versions?


[Python] pyarrow.fs.copy_files hangs indefinitely

Describe the bug, including details regarding any error messages, version, and platform.
We are working on a python package that calls pyarrow's copy_files function to copy a local directory to S3. We notice that this seems to hang indefinitely for a directory, even though it works for individual files.
A simple reproducer seems to be:
from ray.air._internal.remote_storage import upload_to_uri
dir = "/some/directory/local"
uri = "s3://some/s3/bucket"
upload_to_uri(dir, uri)

Where ray just wraps pyarrow.fs.copy_files: https://github.com/ray-project/ray/blob/d7b2b49a962bf33dae7a50376f159ab15d80800f/python/ray/air/_internal/remote_storage.py#L195
This results in the following flamegraph.

And an strace of that process looks like
...
stat("/some/directory/local/result.json", {st_mode=S_IFREG|0664, st_size=2345, ...}) = 0
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
futex(0x5580a3b563e4, FUTEX_WAKE_PRIVATE, 1) = 1
getpid()                                = 1639901
getpid()                                = 1639901
getpid()                                = 1639901
futex(0x5580a3d374e8, FUTEX_WAIT_PRIVATE, 0, NULL) = ? ERESTARTSYS (To be restarted if SA_RESTART is set)
--- SIGTSTP {si_signo=SIGTSTP, si_code=SI_KERNEL} ---
--- stopped by SIGTSTP ---
+++ killed by SIGKILL +++

This is using
.venv ❯ pip show pyarrow                                                                                [23/01/6|17:08]
Name: pyarrow
Version: 8.0.0

On Python 3.10.9, on a machine running Ubuntu 20.04.5 LTS.
Given the flamegraph, it seemed to be an issue with pyarrow, not ray, which is why I opened the ticket here.
Component(s)
Python

I'm taking a look at this.  I have one debugging question for you in the meantime however.  When I look at _upload_to_uri_with_exclude it appears that it is a recursive copy.  Is there a possibility that you've included the current directory "." or parent directory ".." and that's why the operation never finishes?  One way of determining this would be to insert a log/print at https://github.com/ray-project/ray/blob/d7b2b49a962bf33dae7a50376f159ab15d80800f/python/ray/air/_internal/remote_storage.py#L238 to output the paths that are going to be copied from.

I'm taking a look at this. I have one debugging question for you in the meantime however. When I look at _upload_to_uri_with_exclude it appears that it is a recursive copy. Is there a possibility that you've included the current directory "." or parent directory ".." and that's why the operation never finishes?

In our case, exclude is None, so that code path to _upload_to_uri_with_exclude is actually never hit (and you'll notice it doesn't show in the flamegraph). So, it's essentially just the call to pyarrow.fs.copy_files.

I think this issue is a duplicate of #32372. I've added more details in that issue, but in a nutshell, pyarrow.fs.copy_files hangs for s3 buckets and with use_threads=True if more files are uploaded than CPU cores available:
mkdir -p /tmp/pa-s3
cd /tmp/pa-s3
for i in {1..7}; do touch $i.txt; done
# This works
python -c "import pyarrow.fs; pyarrow.fs.copy_files('/tmp/pa-s3', 's3://bucket/folder')"
for i in {1..8}; do touch $i.txt; done
# This hangs forever
python -c "import pyarrow.fs; pyarrow.fs.copy_files('/tmp/pa-s3', 's3://bucket/folder')"

This sounds very similar to nested parallelism deadlocks we have had in the past.
Outermost call: fork-join on a bunch of items (in this case it looks like we are doing fork-join on files)
Inner task: fork-join on something else (e.g. in parquet it would be parquet column decoding)
If the inner-task is blocking on a "join" then it is wasting a thread pool thread.  If enough of these thread pool threads get wasted then all thread pool threads are blocked waiting for other thread pool tasks and no thread is free to actually do the tasks.
The solution we adopted was to migrate to an async model so that "join" step becomes "return a future" instead of "block until done".  This yields roughly the following rules:

The user thread (the python top-level thread) should block on a top-level future
CPU threads should never block (outside of minor blocking on mutex guards to sequence a tiny critical section)
I/O threads should only block on OS calls.  They should never block waiting for other tasks.

It seems like the copy_files/s3 combination is violating one of the above rules.  There is an OptionalParallelFor in CopyFiles which blocks but I think that is called from the user thread and so that is ok.  @EpsilonPrime if you can reproduce I would grab a thread dump from gdb and check and see what the thread tasks are blocking on.  The fix will probably be to move copy files over to using async APIs (internally).

I have written a reproduction testcase that detects the thread contention issue (and is ready to check in once the fix is ready).  What is happening is that when copying a file (filesystem.cc:613) the CopyStream happens as expected and then is passed to the close routine to complete.  That delegates to CloseAsync which handles uploading parts (calling UploadPart).  To do this UploadPart then adds its work to the threadpool which overloads the executor.  For the case of an 8 thread pool with 8 tasks (each small enough to fit in a single part) this ends up being 16 busy threads in a size 8 executor.
The easy solution is to limit the number of tasks to the pool (merely leaving one extra thread appears to be enough for the pool to empty although this needs verification).  The second is to modify the close routine to take over the work of the existing thread (not be asynchronous).  This would require reworking of at least 5 functions and might require even more work for the case where there are multiple parts per file (which we do not have a test for yet).

We just discovered this problem and I'm quite keen to get it fixed. In our case we are using the AzureFileSystem, but it implements background_writes in a very similar way to the S3FileSystem, so it's not a surprise that it suffers from the same problem.
I think the problem is exactly what @westonpace was describing but to be precise about how it manifests in this case:

With a large number of files and use_threads=true, CopyFiles submits a large number of copy operations to the IO thread pool, enough to occupy all the IO threads. https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/filesystem.cc#L648-L650
With background_writes=true each Write https://github.com/apache/arrow/tree/main/cpp/src/arrow/filesystem/util_internal.cc#L56 to Azure or S3 actually just writes to an in memory buffer and submits a task on the IO thread pool, to do the actual upload.
After all the write calls the OutputStream is destructed, which calls Flush(). Flush() blocks, waiting for all the tasks, submitted by calls to Write to complete there actual uploads. Unfortunately, this is a deadlock because there are no free threads in the IO thread pool to actually do any of the uploads.

If we compare to @westonpace 's rules:

This yields roughly the following rules:

The user thread (the python top-level thread) should block on a top-level future
CPU threads should never block (outside of minor blocking on mutex guards to sequence a tiny critical section)
I/O threads should only block on OS calls. They should never block waiting for other tasks.

This third rule is violated because the IO threads spawned by copy are waiting on background write IO threads to complete.
A few vague ideas on solutions, but none of them seem particularly attractive:

OutputStream destructor does not synchronously Flush. Instead it returns a future for the Flush.

This is what @westonpace described
I fear this could require changes to the Filesystem interface particularly around the destructor calling Flush. Maybe there are other options though.

Try setting priorities when submitting tasks.

Copy files spawns tasks with lower priority so they can’t block threads that actually do the copies from running.
If it can preempt lower priority, then this seems like a perfect solution. If it cannot preempt there will still be rare race conditions when all the IO threads can get filled with copy operations and cause the deadlock.

Use a different thread pool e.g. the cpu thread pool for copy files

Sort of makes sense to call it CPU on uploads with background_writes=true because it's basically just writing to an in memory buffer, which is probably more CPU than IO.
Using the same thread pool at both levels is good for controlling concurrency.
For downloads its definitely wrong to use the CPU pool because it will run the blocking IO directly in the CPU pool.

Limit how many tasks copy files can run in parallel, to be slightly less than the io thread pool’s capacity.

There will still be lots of wasted threads.

Disable background writes if there are more files than IO threads.

If there is a really huge file, among lots of small ones the large file will be uploaded synchronously, which will be bad for performance.

I had a quick try at implementing idea 1: return futures and join in the main thread. This appears to be a lot easier than I feared.
fix_copy_files_deadlock.patch.txt seems to work fine so far.

I found a couple more related problems and I've ended up with https://github.com/Tom-Newton/arrow/pull/13. This includes 3 changes:

Use CloseAsync() inside copy_one_file so that it returns futures, instead of blocking while it waits for other tasks to complete. This avoids the deadlock.
Fix a segfault in FileInterface::CloseAsync() by using shared_from_this() to so that it doesn't get destructed prematurely. shared_from_this() is already used in the CloseAsync() implementation on several filesystems. After change 1 this is important when downloading to the local filesystem using CopyFiles.
Spawn copy_one_file less urgently than default, so that background_writes are done with higher priority. Otherwise copy_one_file will keep buffering more data in memory without giving the background_writes any chance to upload the data and drop it from memory. Therefore, without this large copies would cause OOMs.

The current Arrow thread pool implementation makes provision for spawning with a set priority but the priority numbers are just ignored.
I made a small change to use a std::priority_queue to implement the priority.
There is a property of the current implementation that tasks will be scheduled in the order of calls to Spawn. There are no tests to assert this behaviour, and I don't know if it is depended on by anything but currently my std::priority_queue version removes this property.
I think this has got to be the most contentious part of the change, with the broadest possible impact if I introduce a bug. I would appreciate some input on whether this seems like a reasonable change.

I've been testing copying between Azure and local filesystems using a directory of about 50,000 files of varying sizes totalling 160GiB. With all the described changes both upload and download work reliably, with reasonable memory usage. I'm also relatively happy with the performance - it fluctuates more than I would like, but at times it saturates the network interface on my Azure VM.

I opened a draft PR https://github.com/apache/arrow/pull/44897 but ideally I would like some high level thoughts from maintainers on implementing priority queuing before I mark it ready for review.


Add borders to table cells in Preview V2

Please Select if your Request is Either something new or an Enhancement

[X] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[ ] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[X] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
It is difficult to read data in tables in Preview V2.
Describe the solution you'd like
Add cell borders to tables in Preview V2.
Describe alternatives you've considered
Additional context
The type of or use of cell borders could be made configurable.

Thanks for the issue. Will have this slotted up for our upcoming crop issue


Page should have example queries

There are common things people need to do with the AZ Ad cli, this would be a good place to have some of those.
For instance, when people make a new service principal, they often need to get back the tenant id, etc.  Here's the command they should run.
 az ad sp create-for-rbac -n "<appName>" --query "{ clientid: appId, clientsecret: password, tenantid: tenant }"

Examples of common commands like this belong ont this page and would make it even better.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e99d25ff-03e2-e015-37f4-a29b59ec50d4
Version Independent ID: 1a8e88ed-72c7-fbe7-b0ad-68f23b3946cd
Content: az ad sp
Content Source: latest/docs-ref-autogen/ad/sp.yml
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@jiasli for awareness

Example result of az ad sp create-for-rbac:
> az ad sp create-for-rbac

{
  "appId": "fda28870-4bed-4473-9252-c7254d6653b2",
  "displayName": "azure-cli-2021-06-21-09-06-17",
  "name": "fda28870-4bed-4473-9252-c7254d6653b2",
  "password": "4u8n...",
  "tenant": "54826b22-38d6-4fb2-bad9-b7b93a3e9c5a"
}

There are indeed some naming inconsistencies (mapping) between Active Portal and Azure CLI.

Azure Portal
az ad sp create-for-rbac output
az login argument

Application (client) ID
appId
--username

Client secrets
password
--password

Directory (tenant) ID
tenant
--tenant

We tend not to change the key names for now to maintain backward compatibility.
We will consider writing some more detailed documents about the naming inconsistencies and also how to consume the output of az ad sp create-for-rbac by az login.


Fix invalid literals in generated rst docs

Before this change, API docs that look like this:
…adding [param character]s to the right of the string.

would turn into rst files that look like this:
…adding ``character``s to the right of the string.

That reStructuredText is invalid and causes warnings when the docs repo is built.

Would be worth adding a comment in there to explain why we do this. But also, doesn't this always add an extra empty space after the tag? And what about the linked references, does that not break them?
Btw, what doc is this quote from? It should be rephrased, because we shouldn't use code identifiers in text like that.

Would be worth adding a comment in there to explain why we do this.
[…]
This should also be fixed for the overall else case.

OK, so it turns out that there actually is something that’s supposed to fix this for the entire format_text_block function, and it even includes a comment that explains why it does what it does:
        # Properly escape things like `[Node]s`
        if escape_pre and pre_text and pre_text[-1] not in MARKUP_ALLOWED_PRECEDENT:
            pre_text += "\ "
        if escape_post and post_text and post_text[0] not in MARKUP_ALLOWED_SUBSEQUENT:
            post_text = "\ " + post_text

In fact, the first hunk in my commit was completely pointless. My first hunk was dealing with this if statement:
        if tag_text in state.classes:
            if tag_text == state.current_class:
                # Don't create a link to the same class, format it as inline code.
                tag_text = f"``{tag_text}``"
            else:
                tag_text = make_type(tag_text, state)
            escape_pre = True
            escape_post = True

Enabling escape_pre and escape_post at the end makes sure that escaped spaces are added if they’re needed.
In reality, the bug wasn’t that escaped spaces weren’t being added. The bug is the fact that they weren’t being added when a [param foo] tag is used. I just pushed a commit that fixes this bug properly.

But also, doesn't this always add an extra empty space after the tag?

It won’t add an an extra space. According to the reStructuredText Specification:

Escaped whitespace characters are removed from the output document together with the escaping backslash. This allows for character-level inline markup.

And what about the linked references, does that not break them?

I don’t think so. Could you give an example of some markup that might break?

Btw, what doc is this quote from? It should be rephrased, because we shouldn't use code identifiers in text like that.

Here’s a list of everything that I’m aware of that does something like this: ``foo``s

https://docs.godotengine.org/en/latest/classes/class_astar2d.html#class-astar2d-method-add-point
https://docs.godotengine.org/en/latest/classes/class_astar3d.html#class-astar3d-method-add-point
https://docs.godotengine.org/en/latest/classes/class_string.html#class-string-method-lpad
https://docs.godotengine.org/en/latest/classes/class_string.html#class-string-method-rpad
https://docs.godotengine.org/en/latest/classes/class_tree.html#class-tree-method-create-item

Thanks!


Pretrained models

Hey, thanks so much for making this! Do you have any pre-trained model weights available? I don't have the computational power to train one myself unfortunately.

Hi Eric, thank you. Actually I don't, because I trained it in a private dataset, not MIMIC-CXR yet. If I do that I share.

Hey, thanks so much for making this! Do you have any pre-trained model weights available? I don't have the computational power to train one myself unfortunately.

Hello, I want to ask, did you find the pre training model later? I sent an email to the author, but the author didn't reply..

Nope, didn’t get one

On May 20, 2021, at 10:11 PM, goodluck_dk @.***> wrote:

Hey, thanks so much for making this! Do you have any pre-trained model weights available? I don't have the computational power to train one myself unfortunately.
Hello, I want to ask, did you find the pre training model later? I sent an email to the author, but the author didn't reply..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remove self from maintainer-list.nix

It has been a while!  I'm sorry to say I do not expect to contribute in the immediate future, as I have not used Nix for several years.
I don't believe I have my name on any packages any longer.  I had contributed updates to one package: htmldoc, which has been adopted by michaelrsweet.  I was also the original author of the script in maintainers/scripts/nix-diff.sh, but it doesn't have an official owner.
Is there anything else I can fix other than removing my name from the list?

You're still listed in pkgs/tools/typesetting/htmldoc/default.nix. Can you also remove yourself from that?

We could ask some people that last worked on the package if they want to take over maintainership, e.g. @FliegendeWurst or @jiegec

At least remove yourself there so this can be merged if nobody responds. It causes an eval error now

Please rebase: remove the merge commit and order the commits so that you remove yourself from packages first, then remove yourself from the maintainers list. (Opposite order breaks eval for the intermediate commit / breaks git bisect.)


Add no script tag

Add no script tag in multiple languages so that when  javascript is not enabled/supported, this message is shown

done


Create generic header section

Overview
Currently the headers banners are inconsistent across multiple pages.  They should ideally use the same component
Action Items

[ ] Make generic header section component (teal background, yellow text, white breadcrumbs in the upper left).  Needs to be configurable to show text input field for those pages that require user input.

[ ] Apply generic header section component to relevant pages

Resources/Instructions
The figma has many different examples of header banners.

I would like to self assign for this task. I am planning to finish it by Sunday  5/30


Support setting the resource.request or resource.limit for kcert helm deployment

I tested on the GKE autopilot cluster, and it works fine with custom ingress controllers like Kong.
However, If I cannot set a resource limit, the GKE autopilot cluster will use default 0.5 vCPU and 2 GiB Memory, this is unacceptable.
This PR will support setting the resource like this:
How to Use:
--set resources.requests.cpu=200m,resources.requests.memory=256Mi,

--set resources.limits.cpu=512m,resources.limits.memory=512Mi

Thank you for this contribution! I took a quick peek and it looks great! I'll try to find some time soon to review it more carefully, merge and publish the update.


Scope of an "all deprecated" comment unclear

Hi, I saw a comment saying "all deprecated" here, but it's not clear where it's scope ends.
Could you be more specific on which fields exactly are deprecated, or add a statement to say where's the last deprecated field of the deprecated range?

It's only that section before the blank line. We should rename the fields.

Fixed in version 0.2


Bad italic correction with CJK characters

Current behaviour
Given:
漢字_f_漢字

Output:

Excepted behaviour
Given:
漢字_f_漢字

Output:

Detail
If you're writing with Latin script, the combination of normal characters and emph-ed characters looks almost fine:
latin _f_ latin

But with CJK characters, the kerning between emph-ed Latin characters and normal CJK characters looks ugly:
漢字_f_漢字

Emm. There should be a larger space between “f” and the last「漢字」。
I know that the reason of  the combination of normal Latin characters and emph-ed Latin characters looks nearly fine is, the typist have to add a space between the normal Latin characters and emph Latin characters, or Typst won't treat the texts you want to be emph-ed as emph-ed text, like the image below. So, with a manually-typed space, the kerning looks OK.
// Doesn't work.
latin_f_latin

But while typing Chinese and Japanese (or Vietnamese with Hán Nôm if someone willing to) texts, we cannot type a space between CJK characters and Latin characters, because these languages don't separate words with space like Korean or most of the language use Latin alphabets, and Typst will kern automatically between CJK characters and Latin characters. Type a space between CJK character will make a larger space. Like:
漢字Latin漢字(1)

漢字 Latin 漢字(2)

Typst has the behaviour to kern Latin characters and Chinese characters automatically, so I believe it should be correct to let Typst handle the kerning, instead of type spaces between every CJK characters and Latin words by the typist.
But without typing a space between CJK characters and emph-ed Latin characters manually, the kerning looks bad. This is the problem.

ps.: This is the result of doing the same thing with LaTeX and CTeX package:

Reproduction URL
https://typst.app/project/w6cekz9QgDnuiSvJQvzzL8
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

possiblely duplicate #1021 . this is not limited to cjk. it's a general thing: typst doesnt have italic correction now. so anything like this renders bad:
ff#emph[f]ff

於 週六，2024-01-13 於 06:24 -0800，Wenzhuo Liu 提到：

possiblely duplicate #1021 . this is not limited to cjk. it's a
general thing: typst doesnt have italic correction now. so anything
like this renders bad:
ff#emph[f]ff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
@.***>

Emm, you're right.


AI Assistant Backend Setup: Base Architecture and CoTeacher Implementation

AI Assistant Backend Setup: Base Architecture and CoTeacher Implementation
Overview
This issue focuses on establishing the foundational architecture for AI Assistants on the Marvel platform and implementing the first AI Assistant, CoTeacher. The CoTeacher assistant will serve as the prototype and showcase for future assistants to be built upon this base.
The CoTeacher will leverage our existing AI chat framework and incorporate tools, prompts, and actions tailored for classroom management, lesson planning, and administrative support.

Purpose
The maintainers will:

Setup the backend architecture to allow for seamless creation of new AI assistants in the /app/assistants directory.
Implement the CoTeacher assistant with tools, metadata, and APIs to demonstrate how future assistants can be structured and registered.

Deliverables
Backend Architecture

Define the folder structure for AI Assistants under /app/assistants.

Assistants will be grouped logically under categories, e.g., classroom_support.
Each assistant will have the following structure:

prompt/ - for prompt configurations.
core.py - to define the executor logic.
tools.py - to define AI tools.
metadata.json - to specify required inputs.

Register the assistant in /app/api_config/assistants_config.json.

Implement the /assistants URI endpoint to handle assistant-specific queries.

CoTeacher Assistant

Folder Creation:

Create the classroom_support/co_teacher folder under /app/assistants.

Files:

metadata.json: Define inputs for CoTeacher, excluding chat history.

Example:{
  "inputs": [
    {
      "label": "Action",
      "name": "action",
      "type": "text"
    }
  ]
}

tools.py:

Use LangGraph for CoTeacher tools.
Define tools such as translate, summarize, rewrite, and question_generation.

core.py:

Implement the executor for CoTeacher, reusing the current AI chat approach.

Prompt Folder:

Store the prompt file used for CoTeacher's responses.

Assistant Registration:

Add CoTeacher to /app/api_config/assistants_config.json:{
  "classroom_support": {
    "co_teacher": {
      "path": "assistants.classroom_support.co_teacher.core",
      "metadata_file": "metadata.json"
    }
  }
}

Endpoint:

/assistants: Ensure CoTeacher-specific queries return correct results.

Use Cases

Lesson Planning:

Suggest activities, strategies, and detailed lesson plans.

Classroom Management:

Provide methods to increase student engagement or manage group discussions.

Administrative Support:

Generate emails, student progress reports, and presentations.

Technical Details

Utilize LangChain/Smith for tools.
Reuse Kai Chat logic for the executor.
Maintain flexibility for adding new tools and metadata per assistant.

Acceptance Criteria

[ ] Folder structure for AI Assistants is established under /app/assistants.
[ ] CoTeacher assistant is implemented in the /app/assistants/classroom_support/co_teacher folder.
[ ] metadata.json defines CoTeacher-specific inputs.
[ ] tools.py includes the defined tools: translate, summarize, rewrite, question_generation.
[ ] core.py includes the CoTeacher executor using Kai Chat approach.
[ ] CoTeacher is registered in /app/api_config/assistants_config.json.
[ ] /assistants endpoint returns correct results for CoTeacher-specific queries.
[ ] Unit tests ensure the following:

[ ] Proper functionality of CoTeacher's executor.
[ ] Accuracy of tools implemented in tools.py.
[ ] API returns correct responses for CoTeacher queries.
[ ] Inputs defined in metadata.json are validated.

[ ] Code is reviewed and approved.

Resources

Figma Prototype

Please, check #137 in base of the acceptance criteria @Ahmedr275 @yunusj


CI: ImportError: cannot import name 'mock_s3' from 'moto'

moto made a backwards incompatible change. I dealt with this one recently here as well:

https://github.com/simonw/textract-cli/issues/1#issuecomment-2027578406

Looks like Moto doesn't support Python 3.7 any more:
ERROR: No matching distribution found for moto>=5.0.4; extra == "test"


Signing a transaction fails

Hello there!
Today connectedWallet.sign started failing for me without any changes to my code.

Is this due to a breaking change in the chrome extension? Any advice for how to resolve this?

@Ruborcalor Yes, it is said that the Station extension with breaking change has been published.
Sorry. We had to deal with breaking change more carefully.
<EMAIL_ADDRESS>contains many breaking changes. (You can think of it as major update because the API changes significantly)
As a result, wallet-provider, station extension, and station mobile, which depend on terra.js, are likely to have many breaking changes.
Please refer to the links below.

Please use terra.js 2.1.x npm install @terra-money/terra.js@beta
Please use wallet-provider 2.4.0-alpha.2 npm install @terra-money/wallet-provider@next

PR https://github.com/terra-money/wallet-provider/pull/39
sign() method sample https://github.com/terra-money/wallet-provider/blob/feature%2Fterrajs21/packages/src/components/SignSample.tsx#L52

Ignore that, I tried a different terra wallet and it seems to work now!

https://github.com/terra-money/station/pull/198 It's being solved.

I've tried signing message in CodeSandbox demo (the Next.js) one and there's still an error occurred. Here is the message that was prompted
Error
Unknown Error: Cannot read properties of undefined (reading 'chain_id')

Sign Message
{
  "fee": "{\"amount\":[{\"amount\":\"200000\",\"denom\":\"uusd\"}],\"gas\":\"1000000\"}",
  "msgs": [
    "{\"type\":\"bank/MsgSend\",\"value\":{\"amount\":[{\"amount\":\"1000000\",\"denom\":\"uusd\"}],\"from_address\":\"terra1n4gdmdqpwffkjm46h6edss6hq6l5eemtcqt95l\",\"to_address\":\"terra12hnhh5vtyg5juqnzm43970nh4fw42pt27nw9g9\"}}"
  ],
  "result": {
    "auth_info": {
      "fee": {
        "amount": [
          {
            "amount": "200000",
            "denom": "uusd"
          }
        ],
        "gas_limit": "1000000",
        "granter": "",
        "payer": ""
      },
      "signer_infos": [
        {
          "mode_info": {
            "single": {
              "mode": "SIGN_MODE_DIRECT"
            }
          },
          "public_key": {
            "@type": "/cosmos.crypto.secp256k1.PubKey",
            "key": "Apzo58HUJl8CJsFPt10eeYyWSb60CjUkcVYlfC/e7xtR"
          },
          "sequence": "7"
        }
      ]
    },
    "body": {
      "memo": "",
      "messages": [
        {
          "@type": "/cosmos.bank.v1beta1.MsgSend",
          "amount": [
            {
              "amount": "1000000",
              "denom": "uusd"
            }
          ],
          "from_address": "terra1n4gdmdqpwffkjm46h6edss6hq6l5eemtcqt95l",
          "to_address": "terra12hnhh5vtyg5juqnzm43970nh4fw42pt27nw9g9"
        }
      ],
      "timeout_height": "0"
    },
    "signatures": [
      "Hq5I913jMWbGFLb/UVJzXZDedMLhAgXnTx81BWsl74xCtukfsL15B8ZB6nkNDHPfIRxjIK5bfEc2nnVrm7mm0w=="
    ]
  },
  "success": true
}

@borbier Currently, Station extension uses terra.js 2.1.x. So, the result of the sign() returned by the station extension will not be processed by terra.js 2.0.
Terra.js 3.x will be updated soon. This problem will be solved by that time.
Refer to the link below for an example of the changed sign().
https://github.com/terra-money/wallet-provider/blob/feature%2Fterrajs21/packages/src/components/SignSample.tsx#L63

Do you have an example of how to verify a signed transaction?

I updated the sample code for this. You can use the result of sign() by referring to the code on this link.
https://github.com/terra-money/wallet-provider/blob/main/packages/src/components/SignSample.tsx#L67


⚠ PrivateHD has degraded performance

In f94360f, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2004 ms

Resolved: PrivateHD performance has improved in 32abac8.


move dependent crds to hack/crds dir

Moving crds that are not generated by cluster-backup and only needed for testing so it's obvious which crds are generated by us (and make targets that work on them should work more as intended as well)

/cherry-pick release-2.10


Animations Added

PR Description 📜
Added Animations in the heading, about and search bar.
Fixes #3398

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)

@kunjgit Please add the gssoc label on the issue
Add your screenshots(Optional) 📸
https://github.com/kunjgit/GameZone/assets/118285713/f776506b-10b2-4642-8f38-e72f50202a64

Thank you soo much for contributing to our repository 💗

Thank you @MHusain22 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@MHusain22 resolve merge  conflicts !

@kunjgit Now it has no conflict with main branch and please add label of gssoc and level

@kunjgit Now there is no conflict with the base branch you can merge it. Please add the labels of gssoc and level 2 above and my name in Assignees.

Thank you  @MHusain22 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


How to add load balancer?

Summary
Hi,all
I knew that kong based on 'serf'. So how can I add a load balancer between kong cluster and client requests? Do I need to tell LB the static ip in my kong cluster?
Thanks.

Generally a Kong infra looks like this:

In front of Kong there is a loadbalancer to distribute the incoming traffic over the Kong nodes
Kong will simply be configured with hostnames for upstream services
The upstream services are added to the DNS using discovery tools or similar (Consul is popular these days)
Based on the DNS the load will now be balanced to the upstream services (SRV records are not supported)

in 0.10 Kong will do internal balancing on dns records (including SRV), or by specifically creating a balancer (an 'upstream') and adding/removing 'targets' to/from it dynamically.

@Tieske
serf + haproxy + kong ?
This serf demo: web load balance.
When I join a kong node, loadbalancer could automatically fetch the new node?
Thanks.

@HenryChelsea Kong does not automatically update the loadbalancer in front of it. And the upcoming version will include support for loadbalancing from Kong to the upstreams.
Maybe @thefosk knows whether you can listen in on the Serf cluster (underlying to Kong) and automatically trigger an update of the haproxy when a Kong node is added/removed

@Tieske Thanks, I knew the new feature in upcoming version (loadbalancing from kong to upstreams).
`A Kong cluster allows you to scale the system horizontally by adding more machines to handle a bigger load of incoming requests, and they all share the same data since they point to the same datastore.` -- kong cluster info

I think if kong cluster support this, load balancer needs to know the new nodes or the failed nodes.
Thanks for your reply!

@thefosk Hope you can give some advice.
Thanks.

I wouldn't rely on Serf for doing LB.

@thefosk Thanks for your reply.
So how to make the LB automatically knew the nodes in cluster? Get all the static ip and register in LB (like ELB) by myself?
Thanks.

@HenryChelsea like you would do with other services: by using an Auto Scaling Group that automatically adds the nodes to the ELB, or by automating the process in your devops workflow.

@thefosk
Thanks! Got that.
I'll close this issue.


[Feature] .Net 8 support timeline?

Hi! I am developing a new project and was wondering what the timeline would be for .net 8 support for service fabric. I am delaying majority of the code migration until November (so I can use .net 8 and also use R9 which I believe should also support .net 8 shortly after it's out), but wasn't sure what .net 8 support timeline would look like for service fabric. Do you have any rough ideas on what the timeline would look like? This will help me plan out milestones immensely, would really appreciate any insight!

Assignees: /cc @microsoft/service-fabric-triage

Most likely this will be somewhere june 2024. Just like support for .NET 6 and .NET 7 came several months later.
But don't expect an official response here on github.

.Net 8 preview was announced on February 21st, 2023, 8 months ago
Why SF always have a half year delay? Make no sense, isn't it?

Actually, they'll announce they support it, then they'll announce that they found a bug and don't support it (after you've upgraded), fail to update their documentation to indicate they don't support it, and then randomly six months later, buried in a doc casually mention that they support it again.
The service fabric project managers are a joke.

I manually installed the .Net 8 runtime on the virtual machines and it works with a new Blazor .Net 8 RC2 project.
Would be great indeed to have the official support right after .Net 8 is released.

Service fabric isn't officially dead, but this sure looks like a replacement...
https://devblogs.microsoft.com/dotnet/introducing-dotnet-aspire-simplifying-cloud-native-development-with-dotnet-8

My thoughts as well. But on the other hand several other projects coming out of Redmond in the last couple of years seem to all try to be the new cloud native development framework. So wonder whether Aspire will be replaced a new pet project in a year or two…

Aspire looks great, but they left the deployment part of it to the developer, it's a local orchestrator for microservices (so far).
It will surely be enhanced with Kubernetes and Azure Container Apps deployment, plus App Service + Azure Functions for who does not use containers.
Service Fabric on the other hand has its own project service in Azure, has progressive deployment directly from Visual studio with no downtime and act as a layer on top of Virtual Machines scale sets exposing a fixed IP, essential for SaaS using custom domains for customers, that can't validate each single one of them as requested by Azure App Service and Container Apps.
Being on top of VMs it's also way more scalable compared to a managed service.
I scaled it to ~100 VM with billions of requests per hour, and it was very stable.
They overlap in many ways, but in my opinion we are not yet there for Aspire to be a 100% replacement.

@francescocristallo , just courious: what issue will you face if you use K8S? which is very scable too.

Aspire looks great, but they left the deployment part of it to the developer, it's a local orchestrator for microservices (so far). It will surely be enhanced with Kubernetes and Azure Container Apps deployment, plus App Service + Azure Functions for who does not use containers.
Service Fabric on the other hand has its own project service in Azure, has progressive deployment directly from Visual studio with no downtime and act as a layer on top of Virtual Machines scale sets exposing a fixed IP, essential for SaaS using custom domains for customers, that can't validate each single one of them as requested by Azure App Service and Container Apps. Being on top of VMs it's also way more scalable compared to a managed service. I scaled it to ~100 VM with billions of requests per hour, and it was very stable.
They overlap in many ways, but in my opinion we are not yet there for Aspire to be a 100% replacement.

I did not get this first but Aspire does not seem to be a product at all. Just a tool to help you to develop code within solutions with poor architecture.

@francescocristallo , just courious: what issue will you face if you use K8S? which is very scable too.

No issues apart complexity, I developed another project using Kubernetes, but I found it too complex to manage with too many parts to stitch together to make it work as I wanted to.
For a small team or a single developer, I found Service Fabric with its native Visual Studio an Azure integration easier to use.
I look forward for Aspire to evolve quickly into a full alternative.

also like the actual sfproj support, I feel left behind as a service fabric user... they are not paying enough attention anymore to their users of a system that runs very important software.

.NET 7 is EOL on 14th May 2024. Will Service Fabric support .NET 8 before this date? Or is the expectation that organisations will be required to downgrade their applications to .NET 6?
Even still, .NET 6 is EOL in Novemember 2024. It would be really helpful for the community if the Service Fabric team can publicize their roadmap for when .NET 8 will be supported on Service Fabric.
As a side note, I have updated one of our applications already to .NET 8, and it is already working successfully on a SF build of 10.0.1949.9590. However, deploying this to production would then invalidate our support until it is offically supported!

We're working on shipping .NET 8 support in April. Here is the feature on our internal backlog for reference by Microsoft employees.
https://dev.azure.com/msazure/One/_workitems/edit/17509673

Thank you for the update @olegsych. It's greatly appreciated

@olegsych Hi, are you sure it will be out in April?  We are already very excited :-)

Regardless of whether it ships in April, the complete and total lack of professionalism on the part of the Service Fabric management team is simply astounding. Giving Service Fabric customers less than six weeks to test / deploy updates to both dotnet and service fabric is a joke. It's not like the dotnet support schedule was a secret. This was blatant undeniable incompetence on the part of multiple managers, all of whom should be fired. And for anyone who thinks that's harsh, don't worry it's purely hypothetical. They've clearly already gutted the entire team and re-assigned all but one or two part time engineers. They're following the Silverlight roadmap of abandoning a project without officially announcing it.

@mezzo81 I can't guarantee it will be out in April. The SDK changes are well under way and I expect them to be ready for the release we already have scheduled for April. If everything goes as planned, it will be rolled out by the end of that month, including new versions of both the runtime and the SDK packages. However, stuff happens, and releases can slip despite our best efforts when something urgent comes up.
@jackbond I understand your frustration. For what it's worth, let me assure you that Service Fabric is a critical platform and an Azure backbone running on millions of cores. We have dozens of software engineers working from multiple continents and time zones. These engineers are also on-call to provide assistance to the many Microsoft teams and external customers during their live-site incidents. As most systems of its size and critical nature, Service Fabric changes are slow to make and require careful testing to reduce the risk of wide-spread Azure outages affecting dozens of resource types. We are improving our velocity, but this will take a while. Please be patient.

@olegsych thank you for your reply on this an your honest feedback. Great to hear this. I completely understand the precautions you need to consider with such a critical product. While the project obviously is not following normal open source product development, it is still super appreciated that you do the work on this. Thanks!

@olegsych indeed, thanks a bunch for that input it helps a lot!
Careful and slow changes to me is a feature, so to me "improving velocity" should not be the main priority, what we need is the ability to plan, which depends on transparency into your end of things (which your post above do provide, so again, a bit thanks for that). If there is any priority conflict between increasing velocity, and increasing transparency, please opt for the latter.

Giving Service Fabric customers less than six weeks to test / deploy updates...

@jackbond, for enterprise applications, you can avoid some of the "crunch" in the future if you can stick to releases of .NET that are advertised as having long-term support (LTS).  You will save time (and worry) by not adopting the Standard Term Support (STS) releases of .NET.
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

Even though the release notes do not specify it directly it look like .net 8 support is added to SF 10.1 CU2.
Am i correct and is it officially supported on SF 10.1 CU2?

No. The 10.1 CU2 release doesn't support .NET 8. What makes you think so? I don't see it in the release notes and the following page lists only .NET 7 and .NET6 https://learn.microsoft.com/en-us/azure/service-fabric/service-fabric-versions

I am also waiting for .Net 8 official support.
I was able to migrate to .Net 8 and deploy our application on our test Service Fabric cluster.
Applications seems to work properly, but I will wait for official support before pushing these on production.

@olegsych Yes, I have some dependencies on AspNetCore packages.

We're running Service Fabric, net80, and AspNetCore, along with actor and stateless services, and have not experienced so much as a hiccup. Is there something specific that the SF team knows doesn't work?

Thanks @jackbond! No, we think that AspNetCore should work on .NET 8 with net7 binaries as well but haven't tested it specifically. We already have internal builds with net8 binaries passing the full test suite, so that's what we'll officially support in the next SDK update, in particular because .NET 7 end of support is in May.

@olegsych Are there any news related to the release date of dotnet8 supporting Service Fabric SDK? I am glad to hear that is is passing the full test suite. In my ears it sounds like it could be near a public release.

@onerstam We're close, but still a couple of weeks out. We're addressing unrelated problems we've discovered in the SF runtime and as soon as they are resolved the new SDKs will be out too. You can start now by building your service with the latest SDK 7.1 version. It contains net7 binaries that should work. Other have already done this and we don't know of any specific problems with the older SF SDK versions, we just didn't run our full test suite. Then upgrade to the latest SDK build with the net8 binaries once it's out.

Hi @olegsych Any Update on this?

.NET 7 is now officially out of support and Microsoft folks are (rightfully) telling everyone to upgrade. If only we could actually do this 🤷

Great! Now we're forced to use outdated .NET version. More than half a year to update one of the main dependencies of this project and it has not been done. Just want to reiterate that this whole Service Fabric thing is a joke and MS better just kill it with this kind of """development""".

Hey @filipb-cariad, I'm sorry for the delay. The new ETA for the next Service Fabric public release is May 28.

Hey @filipb-cariad, I'm sorry for the delay. The new ETA for the next Service Fabric public release is May 28.

Thanks @olegsych!

Today it is May 28.... Any news yet?
What will be the new version, 10.2?

@olegsych any update, since we're passed the ETA date?

any news?

I'm sorry about the delay, everyone. We have discovered another, unrelated problem in the Service Fabric Runtime 10.1 CU3 release candidate and had to create another build with the fix. It has now been verified and we have resumed our pre-prod rollout and validation process. The ETA for the public release was pushed out to next Monday, June 10.

Is there any news ? ETA is today.

Can you provide instruction of how to maintain support for our applications? Is the .net team planning to extend .net 7 and .net 6 support? or what is suppose to happen with those users that have applications in .net 7 and those in .net 6?

This whole thing is getting really silly and no longer looks professional.
Is ServiceFabric now a hobby project?

The new ETA for public release of 10.1CU3 was pushed out to next Monday, June 17.
Here is the .NET support policy: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core. .NET 6 is supported through November 2024.

Do you guys realize how bad this makes the entire service fabric team look? If you weren't going to be ready with net80 the day net70 went out of support, then you never should have officially supported net70. And how the hell were you guys not prepared for this? The dotnet release schedule is not a secret, and it's like this took the team entirely by surprise. What's really sad was this was all predicted over six months ago. And why? I'm sorry to say, it's because the SF team is a joke. Will anyone be fired over this?

It's time to escalate this.
https://x.com/jackbond/status/1800586805051564066

.Net 7 was never promised as LTS.  .Net 5 similarly went out of support before 6 was supported by SF. If you want to stay in support, only select the LTS versions for your software.

Hi,
That's right what you write, but .net 6 also expires in November and if this continues and NET 8 support will take months (we already have mid-June), time is a bit short. All of our applications also run on NET 6, but we can't switch them all over to NET 8 in 1-2 months and then also test them...

.net 7 was supported by service fabric.
And now you tell me i was not suppose to upgrade to .net 7 because it was not LTS...

But when you do, you have a responsibility too.

 That assumes you've acted professionally.  ETA is today

any update ?

@olegsych
new ETA?

It would be nice to have a date, even if weeks away - as long as it actually gets released on that day :)
Even just a RC would be nice to have just to start testing with .net 8 support at this point...

.Net 7 was never promised as LTS. .Net 5 similarly went out of support before 6 was supported by SF. If you want to stay in support, only select the LTS versions for your software.

@SamHard , .Net 7 has expired on "May 28, 2024" and SF .Net 8 support is still not ready yet. What's your suggestion for the customer who's running on .Net7, (which SF did support since Version10) ???
Please don't tell us the solution is "Downgrade to .Net 6".

The new versions of the Service Fabric Runtime and SDK are now available at

https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabric.10.1.2175.9590.exe
https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabricSDK.7.1.2175.msi

The documentation changes and nuget packages will be published tomorrow.
Rollout of the new runtime version to Azure has started today and should be completed in ~3 weeks.

CAB file for offline update?

CAB file for offline update?

I guess is this https://download.microsoft.com/download/B/0/B/B0BCCAC5-65AA-4BE3-AB13-D5FF5890F4B5/10.1.2175.9590/MicrosoftAzureServiceFabric.10.1.2175.9590.cab
Just updated version 10.1.2175.9590 on the URL as per previous CAB file URLs

Trying to plan ahead for this upgrade. Can it be shared what is the directly upgrade from version "Can upgrade directly from"?
https://learn.microsoft.com/en-us/azure/service-fabric/service-fabric-versions

The new versions of the Service Fabric Runtime and SDK are now available at

https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabric.10.1.2175.9590.exe
https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabricSDK.7.1.2175.msi

The documentation changes and nuget packages will be published tomorrow.
Rollout of the new runtime version to the public Azure cloud has started today and should be completed in ~3 weeks.

Documentation has been updated, but no mention of .NET 8 support. Any reason for that?
https://github.com/MicrosoftDocs/azure-docs/commit/12729eeee3761faf078b5f676b71e9fb07b7dc40

Thanks for the heads-up. It's an oversight. I have already created a PR to fix that.

@olegsych
With the latest Service Fabric (10.1.2175.9590) installed on our cluster and the services updated to .Net 8.0 and SDK version (7.1.2175.9590) we are unable to deploy as the nodes do not have .net 8.0 installed. Is this not suppose to be part of the runtime that service fabric installs on the nodes? The nodes do not contain any other .net runtime version but can run .net 7.0 and .net 6.0 services without any issue.

@Morne-Jooste-Gendac we have been using a CustomScriptExtension to install the .net runtimes for a long time. Even for 5, 6 and 7. Just download the https://dot.net/v1/dotnet-install.ps1 file in the custom script and execute it with -Runtime dotnet -Channel 8.0 as parameters and the runtime will be installed on the VM's on creation of the VM.

@negberts @Morne-Jooste-Gendac Why not give a try on self contained binaries ?
Runtime will be packed with your service, so you don't have to take care about which version is installed.

@LoloActemium This will severely increase the size of your deployment artifacts (multiplied with the number of services/applications) which will lead to:

increased build times
increased artifact copy times
increased package deployment times
increased service upgrade times
increased disk space usage on the nodes

If you're not bothered with all of the above, then yes, building with contained framework is the easiest to do.

@Gabriel-Lacatus Yes, it's the prize you have to pay. It's up to you for choosing the right scenario that fits your needs.

@Morne-Jooste-Gendac Service Fabric doesn't install any .NET runtimes on Windows today. If you had services previously running on .NET 7, the runtime must have been installed similar to how @negberts described.

.NET Core 8.0 has a breaking change that SelfContained is $false. The default value was $true in previous .NET Core SDKs.

.NET Core 8.0 has a breaking change that SelfContained is $false. The default value was $true in previous .NET Core SDKs.

@simonwahub Adding true in the csproj of all the services fixed the issue without needed to install additional runtimes. The issue was the breaking change in the framework, previously we used to package them self-contained but now you have to manually specify that it should be self-contained.
Thank you for pointing out the change

Hi @olegsych Great with the .NET 8 support in SF. Looking ahead what are the plan for support .NET 9 in SF? Do the SF team plan to support it a few months after the .NET 9 GA release or will SF transition into only support .NET releases with LTS?
As you can see from this thread we are some that care about SF and want to use the latest stuff.

Thanks @rasmus-s! We already started working on .NET 9 support and should have it available with the .NET 9 GA. We are re-evaluating our support policies, so don't take this as a promise or a recommendation yet.

Service Fabric 10.1 CU3 is now available in all public regions of Azure. Thanks everyone for your feedback! It was reflected in the release notes. I hope we don't find any new surprises, but if we do, feel free to reactivate this.

Is .net 8 supposed to come installed on a service fabric cluster? I'm on Linux cluster with version 10.1.2306.1 and only dotnet 6 seems to be installed by default.

It doesn't. You have to install it as part of your init scripts. Here is an example with windows server:
https://github.com/Azure/Service-Fabric-Troubleshooting-Guides/blob/master/Scripts/install-dotnet-80.ps1


Move to gitflow

Merge in develop and remove branch to move repo to gitflow

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3d8c1a9). Click here to learn what that means.
The diff coverage is 80.39%.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   82.85%
=========================================
  Files             ?       14
  Lines             ?     1044
  Branches          ?        0
=========================================
  Hits              ?      865
  Misses            ?      179
  Partials          ?        0

Impacted Files
Coverage Δ

tests/test_transform.py
94.23% <ø> (ø)

tests/test_cora_transform.py
93.57% <ø> (ø)

transform/views/main.py
68.51% <100%> (ø)

transform/transformers/PDFTransformer.py
76.41% <76.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8c1a9...86f551e. Read the comment docs.


CI artifact names conflict

In the current CI/CD setup, the artifacts generated by arm-unknown-linux-gnueabihf and arm-unknown-linux-musleabihf have the same name, hexyl_0.14.0_armhf.deb. The default behavior from upload-artifact seems to be to fail in this case (which was probably a breaking change in v4).
This can be seen on this PR where no meaningful change was made (running against the latest version on my fork): PR 1
However, the CI/CD currently depends on upload-artifact@master, which is not the latest branch (main is).
I do not understand why the CI breaks now, but it would make sense to:

Change the artifact names for different architectures
Update the dependency to upload-artifact@main (or at least a more recent version)

Yes. Thank you. I did similar changes in my other projects (although I didn't notice the branch name change…)


Add page with aggregated links to all projects docs for release train current release

We currently have docs per project per release: https://spring.io/projects/spring-cloud-netflix#learn so actually it might be tricky for the user to find the right version of the docs for their release train straightaway; It would be better to aggregate it somewhere in one site with all doc links per release train

I am not 100% sure this would fit our purpose. Consider the use case where you want to link to a given section of the doc and all you have is the release train (which is what most users would have AFAIK):
Let's take an example: https://cloud.spring.io/spring-cloud-static/spring-cloud-netflix/2.0.2.RELEASE/single/spring-cloud-netflix.html#_eureka_s_health_checks
Concretely, I'd like to be able to specify somewhere in the URL the version of the release train, rather than having the version of the component. We've made a good job with the BOM to make that information not important to the user so it would be nice if we could get that done at doc level as well.
Having a centralized page is a very good step in the right direction but won't help us for the original use case of adding links to the initializr (as we'd still have to translate the release train to some module version).

We already have docs aggregated for the whole release train

https://cloud.spring.io/spring-cloud-static/Finchley.SR2/

Is there such initiative for Greenwich?

Hmmm looks like its not published, we can take care of that though next week

@snicoll i just published the docs https://cloud.spring.io/spring-cloud-static/Greenwich.M3/
Is that what you were looking for?

Thanks for the feedback. I am looking for the Google GCP documentation. Is that supposed to be there?

Thanks @snicoll , for raising this concern!
I also have such a concern in my back log to come back one to @ryanjbaxter to work out the solution to join Spring Cloud GCP docs to the standard Spring Cloud release train.
What should we do from the Spring Cloud GCP perspective to normalize its docs?
Another question is to rework Spring Cloud GCP project page to the Spring Cloud style: https://cloud.spring.io/spring-cloud-gcp/
Any insights on the matter?
Thanks

@snicoll you are right it is not included and it should be
@artembilan I took a quick look at the GCP docs.  It doesnt look like you are following all of our conventions when it comes to the documentation.  For example, the documentation module is usually just named docs in all of our projects.  Also the documentation is generated when the docs profile is activates where as in GCP its generated when full is activated.  I think we should address this and then we can get the GCP docs incorporated in the release train docs.  Do you want to create an issue in GCP to track this?
As far as the project page is concerned you should be able to transition that over to the new project page style by filling out the content here https://spring.io/admin/projects/spring-cloud-gcp.  Then editing index.html in your gh-pages branch to redirect to http://spring.io/projects/spring-cloud-gcp (see https://github.com/spring-cloud/spring-cloud-netflix/blob/gh-pages/index.html)
Anyone object to closing this issue then?

Sounds good, @ryanjbaxter !
Raising an issue in SC GCP project...

Already covered in #108

@ryanjbaxter , I think I did everything right for the Spring Cloud GCP project page: https://spring.io/projects/spring-cloud-gcp
And it also redirects well from the umbrella Spring Cloud project page.
Thank you for your guidance!
/CC @meltsufin


fix: nav select height for safari

Not a huge deal, but might be helpful for a small subset of users. I've been on safari lately so I noticed the text of the nav was blowing out of the select container.
BEFORE:

AFTER:

NOTE THIS DOESN'T AFFECT OTHER BROWSERS:
Chrome/Brave:

Firefox:

Excellent improvement, thank you!!


Fixed the footer style

Fixes #37
Screenshot

Looks good, thanks @vikasganiga05

It's my pleasure :slightly_smiling_face:


chore: code split for EE PR

Description
When a JS object is updated, it's information regarding the status of being a main js object gets lost since the server is not returning the information. This pr handles this issue and retains the flag when the update is done.
Main PR: https://github.com/appsmithorg/appsmith-ee/pull/3391
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test<EMAIL_ADDRESS>@tag.JS"

/ok-to-test<EMAIL_ADDRESS>@tag.JS"


Added Google Tag Manager support

Any news on this? Would be really useful

@mgonto can you merge this PR? What do you need?

I couldn't find the documentation, but how do I set this up with Google Tag Manager?