[BUG] Readthedoc build was successful but in the build there were some issues

Description
Some of the content in the readthedoc documentation is not rendered. For example, many of the dataset utilities are not presented. See below

I rerun the build on the readthedoc project, and the build can be successfully run. However, if we take a look at the details in the process there are some issues because of missing packages required for loading the utility functions. Note running the build of the html files in a local recommender conda environment does not have the issue.
In which platform does it happen?
N/A
How do we replicate the issue?
If we run the build on readthedoc, and take a look at the internal steps for the build, the following errors can be found.

Having read the documentation about readthedoc, it seems like we need to use a configuration file to specify the environment used by readthedoc to mitigate the problem. Reference can be found here https://docs.readthedocs.io/en/stable/config-file/v2.html
Expected behavior (i.e. solution)
The build on readthedoc should pass successfully and the html should be rendered properly on the website
Other Comments

I'll take this one

it looks that for being able to generate the conda file we need to add a process like this one: http://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx-core-events

Closing this since the related issue is closed as well.


(wip) TETP-208: Add support for mocked suomi.fi authentication

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #1113 (8eaae99) into develop (5805a0f) will increase coverage by 19.74%.
The diff coverage is 69.42%.

@@             Coverage Diff              @@
##           develop    #1113       +/-   ##
============================================
+ Coverage    63.01%   82.75%   +19.74%
============================================
  Files          981       68      -913
  Lines        26591     2262    -24329
  Branches      2769        0     -2769
============================================
- Hits         16757     1872    -14885
+ Misses        9392      390     -9002
+ Partials       442        0      -442

Impacted Files
Coverage Δ

backend/tet/tet/views.py
41.66% <ø> (ø)

backend/tet/events/api/v1/views.py
42.50% <33.33%> (ø)

backend/tet/events/utils.py
48.00% <48.00%> (ø)

backend/tet/events/services.py
75.00% <64.86%> (-2.64%)
:arrow_down:

backend/tet/events/api/v1/permissions.py
62.50% <66.66%> (-12.50%)
:arrow_down:

backend/tet/events/linkedevents.py
65.67% <66.66%> (-0.49%)
:arrow_down:

backend/tet/events/transformations.py
96.00% <92.85%> (-1.73%)
:arrow_down:

backend/tet/events/tests/test_services.py
98.41% <96.29%> (-1.59%)
:arrow_down:

backend/shared/shared/ytj/ytj_client.py
27.58% <0.00%> (-65.52%)
:arrow_down:

backend/shared/shared/common/decorators.py
37.93% <0.00%> (-58.63%)
:arrow_down:

... and 923 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5805a0f...8eaae99. Read the comment docs.


Pin k8s.io/api for good measure

I was comparing vendor/k8s.io with what we have replace directives for, and everything else was present or doesn't have a 0.18.8 tag (one had a release-1.18 branch, but no tag 😞 )

Alright, should be rfal 🤞


Completion performance for multitargeted projects is slow

With SDK-style projects, if you multi-target, the experience is subpar due to very slow completion. With #4889 this is alleviated for a time, but after a while it will still invalidate caches and rebuild chunks of the world. The language service itself needs to properly understand the additional context that multitargeting requires.
Although this is not a regression, it is still quite a bad experience for people who multitarget. We recommend sticking to a single target if you don't require multitargeting.

This should help it even more: https://github.com/Microsoft/visualfsharp/pull/4918
We will still type check multiple times, once per TFM, but that is what Roslyn does.
I tested this myself and now multi-targeting is much much better. Especially in Area51's case.

This is now resolved.


HE-AAC: strange duraction, same ms duration in ffmpeg with original .flac

So this will require this very recent (2 weeks ago) commit in ffmpeg that finally fixed two times longer than needed removal of priming (media time in editlist) in HE-AAC (and v2, but not simple AAC LC) in native decoder of ffmpeg.
https://github.com/FFmpeg/FFmpeg/commit/5114ce1e2a4c71ddf4971ad3cf9bd43ae16571c3
The duration of this file with removed priming and remainder is same as flac of this song: 3 m 58 s 800 ms. In fact mediainfo is completly right that remainder is 19 ms (though the name Duration_LastFrame is unfortunate), and in fact the size of wav decoded by ffmpeg with the commit above is 3 m 58 s 819 ms. But due to Mediainfo's duration being wrong (03:58:915), even if you subtract 19 ms you will not get to 800 ms.
Samples will be added in the next comment to avoid copyright issues with Tidal (will delete that comment when you will get the files).

https://user-images.githubusercontent.com/31514790/183337358-4c4266bc-02e4-4f81-8332-717ba6e6c186.mp4
FLAC is here: https://www.upload.ee/files/14397313/02_-Abba-_Don_t_Shut_Me_Down.flac.html

We currently don't handle well edit lists not starting at 0 (start offset is ignored), we need to rework this code... :(

Can you tell me how to you get duration? Because this file has some quite strange
mvhd 238800
tkhd 238800
mdhd 238914.
Yet after -c copy the file using ffmeg I do get
238915 for two first values.

Can you tell me how to you get duration?

tkhd duration is 238915 and mvhd time scale of 1000, and edit list is ignored (it should not), so 03:58:915.

tkhd 238800

tkhd duration is 238915 in the mp4 file you provided.

tkhd duration is 238915 in the mp4 file you provided.

Oh, it is the opposite! You get after -c copy
mvhd 238800
tkhd 238800
mdhd 238914
which is now correct since mvhd and tkhd present the post-editlist duration, while mdhd should have the pre-editlist duration. So really the file is buggy (Tidal produces such files). The problem is now there is still "source_" wrong duration coming from somewhere.

The problem is now there is still "source_" wrong duration coming from somewhere.

from the rewrapped file? I rewrapped and now I have mdhd 10536138/44100 = 238.915 (I don't know from where you get 238.914... Maybe integer truncation of 238914.7 ms?).
Source_ info comes from stts atom (sum of times. In your file rewrapped by FFmpeg it is equal to mdhd duration).
In practice, If I understand correctly the edit list:

media content is 238.915 s long (all frames but last one at 2048 samples, last one at 1226 samples, at least indicated at the stts level)
playback starts at offset 0.115 s (5058 samples)
duration is 238.800 s long

So we have 0.115 s discarded, 238.8000 s played = 238.915 s stored.

So really the file is buggy

Good to know for avoiding me headaches when I try to fix my code. But I should handle such kind of incoherencies if it is in the wild, and show a warning that the file is buggy and try to show the real value if available (here I guess that I should peak the edit list duration).

and in fact the size of wav decoded by ffmpeg with the commit above is 3 m 58 s 819 ms

Looks like that FFmpeg correctly discards the first 5058 samples indicated to be discarded but does not discard the last 2048 - 1226 = 822 samples ( = 0.019 s) indicated to be discarded (in both the edit list and stts).

Looks like that FFmpeg correctly discards the first 5058 samples indicated to be discarded but does not discard the last 2048 - 1226 = 822 samples

Yes, it still does not remove remainder, so is not truely gapless. Chromium's fork of ffmpeg fixed it though, and it is a known bug. https://trac.ffmpeg.org/ticket/7828

and stts

Where does -19 ms come from? Is it from stts?

Chromium's fork of ffmpeg fixed it though, and it is a known bug

Sad that FFmpeg team didn't merge the patch.

Where does -19 ms come from? Is it from stts?

Yes (last frame duration minus normal duration). I need to better show when the last frame does not have the same duration as others.

Sad that FFmpeg team didn't merge the patch.

This patch should be THE patch, can you resend it with fate fixed<EMAIL_ADDRESS>
Is it from stts?

What is the relationship with duration in editlist? Both should be noted?


[Discussion] Proposed changes to the CSS

I am proposing an update to the CSS of the website. I felt the current styling of the documentation could be improved:

Navigation: I want to see where I am in the docs as I navigate.
Placement of the table of contents: when the TOC is really long, it has a tendency to push the content down the page further than is desirable.
Search: I want to be able to search by title or keywords in a doc page.
General look and feel.

Proposed changes: http://wmarshall484.github.io/documentation-theme-jekyll/mydoc/home.html
Since the update touches many files, I'm holding off on a merge request for now. I think it goes a long way with the site's general look and feel. What are your thoughts?

Thank you for working on this, Will.  I do like the new navigation.  A few questions:

Can we have a link to the Javadoc in the navigation?

What will the Edit me button do.  Right now, for me, I get a page not found error, but what is the intent?  It would be great if there was an easy way to edit or create pull requests for doc changes.

The Github Repo button goes to the quarks project.  Should it go to the quarks.documentation project?  Maybe a pull down where you can choose which project you want?

We can't use Apache Quarks Incubating yet, so can you please update that?  The vote passed to accept us, but until we are set up there with code, etc., we can't reference Apache.  Activites are going on now to set those things up.

I like the search box!

I kind of like the old banner color at http://quarks-edge.github.io/quarks.documentation//.  It matches our github.io page.

Thank you so much for working on this to make the docs easier to navigate!

Glad you like the changes! The navbar helps a lot.

Can we have a link to the Javadoc in the navigation?
Yup. Can you post a link to the Javadoc? I couldn't find it.

What will the Edit me button do.
The edit button will send you to the markdown sourcecode in the github repository. If you have a github account, there will be a button to edit it.

Right now, for me, I get a page not found error
That will be fixed once it merges.

The Github Repo button goes to the quarks project. Should it go to the quarks.documentation project? Maybe a pull down where you can choose which project you want?
We can do a pulldown, although I think it's cleaner as a button.

We can't use Apache Quarks Incubating yet, so can you please update that?
Ah, gotcha. I'll update that.

I like the search box!
+1

I kind of like the old banner color
Should be able to update that as well.

Nice job @wmarshall484 - it looks cleaner and lighter.

I like it a lot! I agree with Kathy on the Javadoc. Here is the link: https://quarks-edge.github.io/quarks/docs/javadoc/index.html
Personally, I'm not a big fan of the icons next to the titles.

Overall, +1

Personally, I'm not a big fan of the icons next to the titles.
Okay, those anchors should be easy to remove.

Yup. Can you post a link to the Javadoc? I couldn't find it.
https://quarks-edge.github.io/quarks/docs/javadoc/index.html

The Github Repo button goes to the quarks project. Should it go to the quarks.documentation project? Maybe a pull down where you can choose which project you want?

We can do a pulldown, although I think it's cleaner as a button.

How about pointing to https://github.com/quarks-edge?.  I think we should do that or the quarks.documentation project as this is the documentation page.

I like the idea of it pointing to https://github.com/quarks-edge. We have a number of github repositories, so maybe the top-level project would work better.

I made the changes based on this feedback and merged the pull request. Github seems to be a bit slow refreshing the generated website, unfortunately.

+1 Looks Awesome...

@wmarshall484 I think you found the perfect balance for icon use. Looks great!

When the table of contents has a lot of things form the current page, you can no longer see the site directory without scrolling down. I think we should allow more space for the navigation on the side:

@wmarshall484 URLs seem to have changed with your CSS changes (or maybe it was something else...). Can we go back to the original URLs? For example, http://quarks-edge.github.io/quarks.documentation/docs/quarks/getinvolved/ became http://quarks-edge.github.io/quarks.documentation/mydoc/getinvolved.html


Add Timer for Groups

Need to add the same timer functionality for groups as implemented for sessions.

closed by e68b229


Feature Added: Logging strategy and tsLogClassLogger prop

Added:

strategy - Sets ts-log-class logging strategy. By default it logs only after function execution like it was before, but with this option a dev can pass 'before-after' and make it log before and after function execution.

Removed:

setDefault - it was not documented well and not tested. The same can be achieved with wrapping ts-log-class decorator (see below), so I do not see much value in it. I can bring it back if it's a deal breaker.

import LogDefault from 'ts-log-class'
export const Log = (...whateverPropsYouWantToPass: any[]) => {
   // transform whateverPropsYouWantToPass as you want
  return Log(...whateverPropsYouWantToPass)
}

Version is bumped to 2.0.0 since I removed setDefault, which is major change of the API

Coverage decreased (-8.0%) to 90.789% when pulling 76c1b06cdcff87a2c01e16734d5882c56a6e6032 on keenondrums:master into 009a2843437368e27904682afcf8131c5ce63896 on bakerstreet-industries:master.


Always generate up-to-date DDL when selecting Generate SQL->DDL

Is your feature request related to a problem? Please describe.
I use right-click->Generate SQL->DDL to get the definition of a view or materialized view, in order to do some changes.
The problem is that this definition is cached from the last time I connected to the database. If in the meantime the view has been updated, I get the old-code instead of the new one.
Describe the solution you'd like
When I press Generate SQL->DDL, DBeaver should always fetch the most up-to-date DDL, not the cached one.
Describe alternatives you've considered
I know that I can first refresh the views, but it's really aggravating to have to do those additional steps every time I need to do a change (and in my current workflow, that's very frequent).

Hello @pkExec
What database are you using?

@LonwoLonwo

Database: PostgreSQL 12.13 (Ubuntu 12.13-1.pgdg20.04+1) on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, 64-bit
Dbeaver:  Community Edition, Version <IP_ADDRESS>308201919

We want to add a button Refresh in generate SQL dialogue.

Yes, could you create a new issue then?


Does not prompt to install new downloaded update automatically

After it gave me pop up to Download the latest version, I clicked on Download and it Downloaded but instead of opening the new update for me to install it stuck at 100%.  The screenshot below;

I had to navigate to my \AppData\Roaming\eSteem Surfer directory for me to see the new update and installed it manually The screenshot below;

I noticed this on 1.0.6-1.0.7, 1.0.7-1.0.8 and now 1.0.8-1.0.9 hope it got fixed

after it has completed the update download, it should bring a new Toast/Popup if the user wants to install now or later. And if the user selects later, it should give tips about the directory to find the newly downloaded update to install because some casual users won't know where to find it later on.

also an option for users; delete installation file after install or not for free space

tips to ask users to delete previous downloaded update in their Appdata directory like 1.0.6,1.0.7 etc for free space, or if there could be an option to do that with Surfer automatically.

Occurred on  Windows 10

just tested on both win7 and win10. worked without problem @horpeyloaded

for next release i will add an error handler to update so we can figure out whats wrong if an upload error occur.

It works fine on my Windows 10 machine as well...

do you have antivirus or some software which can block applications on your pc? @horpeyloaded

no, I even disabled Windows Defender @talhasch beacuse of patches/cracks I use. Let me try to update to the latest version tonight if the update error occurs again.

We are praying for you, @horpeyloaded

My Surfer on Windows says there is an update, I press to Download it. After downloading Restart button appears and after I press it Surfer closes itself and starts the update process automatically (with no prompt or warnings). Then it restarts as a new version.
I don't really know where it saves the update. Maybe @talhasch will tell.

Yes! works perfect, I will try it out.
For the installer file, you can use this command in Run start+r, input %appdata% Enter, then click on eSteem Surfer Folder, the installer may be here. @dunsky

Yes, I have all the updates there!
C:\Users\myprecioususerfolderchangednameforparanoidsequrity\AppData\Roaming\eSteem Surfer where myprecioususerfolderchangednameforparanoidsequrity is current logged in user

I think it would be better to change the updates file save directory to Download folder, so users can delete the old updates to save spaces. if you check your eSteem surfer directory C:\Users\my-precious-user-folder-changed-name-for-paranoid-sequrity\AppData\Roaming\eSteem Surfer @dunsky you may have tons of old updated software file of Surfer!

@horpeyloaded stil having this issue with v2?

@talhasch No, it's fixed. It worked on v2.0.1 to v2.0.2 seamlessly on my PC. Thanks!


[getstorybook]TypeError: Cannot read property 'find' of undefined

I'm not sure if not I meet a bug.
╭─zhaozhe@zhaozhe ~/Demo/vue-skeleton ‹ruby-2.2.1› ‹master*›
╰─➤  getstorybook -f

 getstorybook - the simplest way to add a storybook to your project.

 • Detecting project type. ✓
 • Adding storybook support to your "Single File Components Vue" app
     TypeError: Cannot read property 'find' of undefined
    at _callee$ (/usr/local/lib/node_modules/@storybook/cli/generators/SFC_VUE/index.js:54:21)
    at tryCatch (/usr/local/lib/node_modules/@storybook/cli/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/usr/local/lib/node_modules/@storybook/cli/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.(anonymous function) [as next] (/usr/local/lib/node_modules/@storybook/cli/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/usr/local/lib/node_modules/@storybook/cli/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /usr/local/lib/node_modules/@storybook/cli/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:169:7)
╭─zhaozhe@zhaozhe ~/Demo/vue-skeleton ‹ruby-2.2.1› ‹master*›
╰─➤  getstorybook -V                                                                                1 ↵
3.4.6

If you need, I have more info. Such as package.json?

Hi @zhaozhe0831 I tried reproing this with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>but it works fine. The line it's erroring on is:
  const babelRc = getBabelRc() || {
    presets: [['env', { modules: false }]],
  };
  const hasPreset = babelRc.presets.find(
    preset =>
      (Array.isArray(preset) && preset[0] === 'vue') ||
      (typeof preset === 'string' && preset === 'vue')
  );
  if (!hasPreset) {
    babelRc.presets.push('vue');
  }

Which means that you have a babelrc but it doesn't have presets. It looks like it could be a bug in our code, but if you can tell me more about your babel setup that would help me understand a bit better. Thanks!

babelrc？Let me check it.

I create another issue.
https://github.com/storybooks/storybook/issues/3677


Setname function not working on props

So i tried making a code and that in itself works but using E:setname() (and E is defined at and input as E:entity but it doesnt wanna work loke that unless its the e2 itself doing it. When can this get fixed?

setname is to set the E2's name I think

There needs to be one for props and things like that it could be useful.
On Thu, Feb 16, 2023, 10:00 PM thegrb93 @.***> wrote:

setname is to set the E2's name I think
—
Reply to this email directly, view it on GitHub
https://github.com/wiremod/wire/issues/2541#issuecomment-1434103532, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5WDEBE2RFKGRBCQTQO2ETWX4AWFANCNFSM6AAAAAAU66PB24
.
You are receiving this because you authored the thread.Message ID:
@.***>

setname can set the name of the e2 entity itself, or other wiremod entities. This changes one of the labels that show up in the tooltip when you aim at the entity. Props don't even have tooltips in the first place so even if it could target props it wouldn't do anything, and adding a tooltip to every single prop would be extremely annoying.

My guess is they want it for the ents.FindByName function or for source engine i/o stuff. Having access to that would probably not be a good idea.

I understand it i do im just saying if you wanted to use it for some things
thats all lol
On Fri, Feb 17, 2023, 2:14 PM thegrb93 @.***> wrote:

My guess is they want it for the ents.FindByName function or for source
engine i/o stuff. Having access to that would probably not be a good idea.
—
Reply to this email directly, view it on GitHub
https://github.com/wiremod/wire/issues/2541#issuecomment-1435275294, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5WDEB6YLU6CAUCEUFKJYLWX7S5DANCNFSM6AAAAAAU66PB24
.
You are receiving this because you authored the thread.Message ID:
@.***>


Cannot get

Hi,
I'm using getopts_long inside a nested function contained in the script I launch but when executing getopts_long, it seems to not retrieve the #BASH_ARGV since ${#} equals 0
Do you have any easy solution to solve this ?

Hi @pilak, Could you provide a simplified example of how you use the function? Thanks!

@UrsaDK :  It is possible to use builtin getopts inside a function:
foo () {
  OPTIND=1
  while getopts ':ab:' OPT ; do
    case "$OPT" in
      a) a_stuff ;;
      b) b_stuff=$OPTARG ;;
      ...

However, with getopts_long, you can't do a similar loop, because, in the way you currently use OPTIND, you are looking through the arguments of the overall script, not the arguments of the function.
If you want to use getopts_long in a subcommand, for example passing the shifted arguments to foo using foo "$@", this is problematic.


Enable / set up Travis

@rvagg Mind flipping the switch on Travis?

👍 https://travis-ci.com/rvagg/ghutils
travis has got more complicated, no obvious toggle to set up projects anymore, I had to push a .travis.yml to figure out whether it was configured or not, and I don't even know what I did to make it be configured!


Memory leak in BLECharacteristic::notify()

The call to  m_value.getValue().length() to log the message length in BLECharacteristic::notify() is causing an 84 byte memory leak.
I've added extra log statements, logging the ESP.getFreeHeap() value before and after that call (and in the method calling notify() and this is the result:

[D][BLEObserver.cpp:35] notification(): Free memory Master before notify(): 66524
[D][BLECharacteristic.cpp:485] notify(): Free memory on notify()::Enter : 66524
[D][BLECharacteristic.cpp:486] notify(): >> notify: length: 10
[D][BLECharacteristic.cpp:487] notify(): Free memory on notify(), After LOGD  m_value.getValue().length(): 66440
[D][BLECharacteristic.cpp:495] notify(): << notify: No connected clients.
[D][BLEObserver.cpp:37] notification(): Free memory Master after notify(): 66440

This occurs with every call of notify, eventually draining all resources
I'm assuming that this has something to do with the way the std::string m_Value is returned by getValue() method. I tried replacing m_value.getValue().length() with m_value_getLength() but with the same results

Managed to reproduce the problem with your test script!
If you increase the MTU size to 256, memory will be drained
  BLEService *pService = pServer->createService(BLEUUID(SERVICE_UUID), 256);

Increasing the MTU to 256 and sending a long string, will reproduce the memory loss
setup() modification:
  // Create the BLE Service
  BLEService *pService = pServer->createService(BLEUUID(SERVICE_UUID), 256);

loop() modification:
    if (deviceConnected) {
        char buf[100];
        sprintf(buf, "This is a long string to test if that will lead to memory loss %d", value);
        pCharacteristic->setValue((uint8_t*)buf, strlen(buf));
        pCharacteristic->notify();
        Serial.print("Freeheap: ");
        Serial.println(ESP.getFreeHeap());
        value++;
        delay(3); // bluetooth stack will go into congestion, if too many packets are sent, in 6 hours test i was able to go as low as 3ms
    }

[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320333333, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[W][BLECharacteristic.cpp:515] notify(): - Truncating to 20 bytes (maximum notify size)
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
Freeheap: 128480
[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320333334, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[W][BLECharacteristic.cpp:515] notify(): - Truncating to 20 bytes (maximum notify size)
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
Freeheap: 128396
[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320333335, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[W][BLECharacteristic.cpp:515] notify(): - Truncating to 20 bytes (maximum notify size)
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
Freeheap: 128312

BLEService *pService = pServer->createService(BLEUUID(SERVICE_UUID), 256);
This call does not set MTU to 256, its setting 256 handles in service.

You are right, its the handles
In our system the client app sets the MTU to 255
But still i see the memory leak occuring now

I believe there is memory leak. I will try to recreate it and fix.
Your esp32 server code does not have MTU setup at all. Look at this line:
[W][BLECharacteristic.cpp:515] notify(): - Truncating to 20 bytes (maximum notify size)
This mean that esp32 or peer device mtu is 23.

No, in the test script the bluetooth is not connected to our system, but to nRFConnect
There the MTU is not set

I just discover you can set the MUT in nRFConnect. After setting it to 255 the logs shows as follows:

[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320363832, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLEServer.cpp:153] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
Freeheap: 98300
[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320363833, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLEServer.cpp:153] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
Freeheap: 98216
[D][BLEDevice.cpp:108] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... Unknown
[D][BLECharacteristic.cpp:631] setValue(): >> setValue: length=66, data=546869732069732061206c6f6e6720737472696e6720746f207465737420696620746861742077696c6c206c65616420746f206d656d6f7279206c6f737320363834, characteristic UUID=beb5483e-36e1-4688-b7f5-ea07361b26a8
[D][BLEServer.cpp:153] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:638] setValue(): << setValue
[D][BLECharacteristic.cpp:203] handleGATTServerEvent(): >> handleGATTServerEvent: Unknown
[D][BLECharacteristic.cpp:484] notify(): >> notify: length: 66
[D][BLECharacteristic.cpp:459] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:533] notify(): << notify
[D][BLEServer.cpp:280] handleGATTServerEvent(): << handleGATTServerEvent
Freeheap: 98132

Like i said, there is few bugfixes in latest PR in this repsoitory. I dont want to create arduino PR before i fix most bugs. Could you try to create library from this repository and perform test?
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/ArduinoBLE.md#replacing-the-version-that-comes-with-arduino-esp32

Im not sure what you are asking me here ...
I'm not using Arduin o IDE, but Eclipse with Sloeber 4.3 plugin, ESP32_BLE_Arduino repo  is cloned in its own folder, which is added as library to the test project

I remember now. There was small leak i found lately in BLECharacteristic.cpp. Im not sure it was the only reason.
In this function is missing delete p2902;:
https://github.com/nkolban/ESP32_BLE_Arduino/blob/master/src/BLECharacteristic.cpp#L483-L534
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLECharacteristic.cpp#L540

Ok, that might solve it
I do think you should also add the delete statement before the other return statements in that method btw

I have created a pull request with the fix of this memory leak, but actually i don't understand why you should delete the p2902 object, as this is a pointer to an object in a std::map.
I thought I read somewhere that std::map.first returns a copy of the object in the map-item, but trying to make this visible with some simple test code are not successful.
Do you know why the delete is necessary ?

You are correct, we cant delete p2902, because this will cause crash next time we will try to find it. My bad, sorry.

Ok, i'll revoke the pull request
That leaves the question why there is a memory leak

I am a little busy now, but i will try to find it. As you can see i could not recreate memory leak, but with your settings i will perform more tests.

I can confirm this as I'm experiencing the same thing, calling notify() causes a memory leak that eventually forces it to restart. If sending smaller sized values then its not that apparent, but when sending larger values (over 60 bytes) over and over again in a loop, then the heap gets consumed very quickly.
In my case I'm using a while loop that keeps sending out a large file chunked down into 180 bytes, every time notify is called (with a delay of 10ms) within that while loop, memory is leaked. Once we are out of the while loop, resources are freed. Sending out 150k bytes consumes over 25k of heap.

Any updates?

Can I ask why this issue is closed and/or what pull request closed it. I am seeing it on
platform = https://github.com/tasmota/platform-espressif32/releases/download/v2.0.3rc1/platform-espressif32-2.0.3.zip
platform_packages = framework-arduinoespressif32 @ https://github.com/Jason2866/esp32-arduino-lib-builder/releases/download/826/framework-arduinoespressif32-v4.4_work-b98c8476f2.tar.gz


Visual Studio Extensions

I think embedding the tool as an option in Visual Studio, I mean, creating extensions for VSWin and VSMac would be amazing. Have you think about it? If you need any information about it let me know.

I really like the idea of it being a VS extension!
It's given me some food for thought, such as if it's an extension then I guess if there is access to the debug data that is available to VS about the state of the objects; this could be used to build the tree instead of having to send it from the app itself. Removing the need for the hack for getting the IP of the host for using the iOS sim.


Milestone 0.0.25

Coverage increased (+0.9%) to 90.909% when pulling b06483309ee64df45a87a017cc9fff985fba3c18 on milestone-0.0.25 into 86d70e16d6783f5113c89cf13b51419f57b67918 on master.


Run Debian GNU/Hurd natively.

Currently, I do GNU/Hurd development under the Xen hypervisor, in a Debian WSL2 setup, but this presents some challenges, and is a hassle.
I'm not sure how feasible it would be, but having the ability to install and use mach in the same way that the linux kernel is used would be extremely convinent.

If it's a matter of determining if all the kernel config options are enabled for mach, I'd check mach's documentation for the required config entries, and then search the kernel config for WSL2 to determine if there's anything missing. You are free to use a custom kernel config, even a custom kernel if desired and simply map it in the .wslconfig file.

The Hurd kernel API is not compatible with the Linux kernel.  All WSL instances use the same kernel and even though a custom one can be specified in .wslconfig this is systemwide not per distro. It helps to think of WSL instances as containers and not vms.

I'm aware its incompatible, but where does that break WSL? Is the area that would need to be modified open source?


Update workitem creation examples in README

Some of the examples use the old format.

We have to revisit this now we have the space contextualization


Does it work with current SDK versions?

Hello! Thanks for being the only one around who cared to make an emulator for GCP Storage!
So, I've tried to use it with Docker and run the simple hello world from Google in .Net, and I'm getting "NotImplemented" response with this in the container logs:
2023-06-03 23:02:26 Starting server at <IP_ADDRESS>:9594
2023-06-03 23:02:26 [SERVER] All services started
2023-06-03 23:02:38 Method not implemented: POST - /b
2023-06-03 23:02:38 "POST /b?project=orleans-test HTTP/1.1" 501 -

This is happening with the call to create a bucket.
I'm setting the STORAGE_EMULATOR_HOST.
Also tried building the client explicitly with this:
var client = new StorageClientBuilder()
        {
            BaseUri = this.StorageEndpoint,
            UnauthenticatedAccess = true
        }.Build();

Same problem...
Any idea what may be wrong?
Thank you! I appreciate any help!

I had the same issue, this can be resolved by providing the full enpoint (in your case with PORT=9594)
STORAGE_EMULATOR_HOST=http://localhost:9594/storage/v1

Issue gardening.
@galvesribeiro Did it worked for you? Can the issue be closed?


Error: GWToolbox.dll was not loaded, unkown error

Originally reported by: Anonymous

Hey, I get this error message when I launch the toolbox while GW is running. I am on Windows 10. I downloaded and installed  vcredist_x86.exe and DirectX Redistributable. I don't have any .dmp file in the %LOCALAPPDATA%/GWToolbox folder. I don't know what to do now..

Bitbucket: https://bitbucket.org/ggori/gwtoolbox-plusplus/issue/6

Hi,
I had the same Problem on my new Win 10 Notebook, but it fixed itself when i downloaded and ran the DirectX End-User Runtime Web Installer from the ms page. Hope this helps if it hasn't been fixed yet!

See FAQ and use new launcher.


Cuda runtime error

Hello, Getting this error in the middle of the training. I have tried training several times but the same error comes at different steps. The issue starts at validation steps as I trace back the error.
@raganato
/opt/conda/conda-bld/pytorch_1524586445097/work/aten/src/THC/THCTensorIndex.cu:360: void indexSelectLargeIndex(TensorInfo<T, IndexType>, TensorInfo<T, IndexType>, TensorInfo<long, IndexType>, int, int, IndexType, IndexType, long) [with T = float, IndexType = unsigned int, DstDim = 2, SrcDim = 2, IdxDim = -2, IndexIsMajor = true]: block: [5,0,0], thread: [96,0,0] AssertionsrcIndex < srcSelectDimSizefailed. /opt/conda/conda-bld/pytorch_1524586445097/work/aten/src/THC/THCTensorIndex.cu:360: void indexSelectLargeIndex(TensorInfo<T, IndexType>, TensorInfo<T, IndexType>, TensorInfo<long, IndexType>, int, int, IndexType, IndexType, long) [with T = float, IndexType = unsigned int, DstDim = 2, SrcDim = 2, IdxDim = -2, IndexIsMajor = true]: block: [5,0,0], thread: [97,0,0] AssertionsrcIndex < srcSelectDimSize` failed.
.
.
.
Traceback (most recent call last):
File "train.py", line 40, in
main(opt)
File "train.py", line 27, in main
single_main(opt)
File "/home/aki/OpenNMT-py/onmt/train_single.py", line 262, in main
opt.valid_steps)
File "/home/aki/OpenNMT-py/onmt/trainer.py", line 223, in train
report_stats)
File "/home/aki/OpenNMT-py/onmt/trainer.py", line 384, in _gradient_accumulation
dec_state)
File "/home/aki/anaconda3/envs/zeroshot/lib/python3.6/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
File "/home/aki/OpenNMT-py/onmt/models/model.py", line 75, in forward
memory_lengths=lengths)
File "/home/aki/anaconda3/envs/zeroshot/lib/python3.6/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
File "/home/aki/OpenNMT-py/onmt/decoders/decoder.py", line 139, in forward
tgt, memory_bank, state, memory_lengths=memory_lengths)
File "/home/aki/OpenNMT-py/onmt/decoders/decoder.py", line 350, in _run_forward_pass
memory_lengths=memory_lengths)
File "/home/aki/anaconda3/envs/zeroshot/lib/python3.6/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
File "/home/aki/OpenNMT-py/onmt/modules/global_attention.py", line 181, in forward
mask = sequence_mask(memory_lengths, max_len=align.size(-1))
File "/home/aki/OpenNMT-py/onmt/utils/misc.py", line 23, in sequence_mask
.type_as(lengths)
RuntimeError: cuda runtime error (59) : device-side assert triggered at /opt/conda/conda-bld/pytorch_1535491974311/work/aten/src/THC/generic/THCTensorCopy.cpp:21
`

Running the training on cpu gives this error index out of range.
`Traceback (most recent call last):
File "train.py", line 40, in
main(opt)
File "train.py", line 27, in main
single_main(opt)
File "/home/gamut/OpenNMT-py/onmt/train_single.py", line 262, in main
opt.valid_steps)
File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 223, in train
report_stats)
File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 384, in _gradient_accumulation
dec_state)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/models/model.py", line 61, in forward
enc_final, memory_bank = encoder(src, lengths)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/encoders/rnn_encoder.py", line 57, in forward
emb = self.embeddings(src)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/modules/embeddings.py", line 205, in forward
source = self.make_embedding(source)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/container.py", line 91, in forward
input = module(input)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in forward
outputs = [f(x) for f, x in zip(self, inputs_)]
File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in
outputs = [f(x) for f, x in zip(self, inputs_)]
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/sparse.py", line 108, in forward
self.norm_type, self.scale_grad_by_freq, self.sparse)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/functional.py", line 1076, in embedding
return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: index out of range at /opt/conda/conda-bld/pytorch_1524586445097/work/aten/src/TH/generic/THTensorMath.c:343`

when running the training on cpu i got this index out of range error.
`Traceback (most recent call last):
File "train.py", line 40, in
main(opt)
File "train.py", line 27, in main
single_main(opt)
File "/home/gamut/OpenNMT-py/onmt/train_single.py", line 262, in main
opt.valid_steps)
File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 223, in train
report_stats)
File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 384, in _gradient_accumulation
dec_state)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/models/model.py", line 61, in forward
enc_final, memory_bank = encoder(src, lengths)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/encoders/rnn_encoder.py", line 57, in forward
emb = self.embeddings(src)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/modules/embeddings.py", line 205, in forward
source = self.make_embedding(source)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/container.py", line 91, in forward
input = module(input)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in forward
outputs = [f(x) for f, x in zip(self, inputs_)]
File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in
outputs = [f(x) for f, x in zip(self, inputs_)]
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/sparse.py", line 108, in forward
self.norm_type, self.scale_grad_by_freq, self.sparse)
File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/functional.py", line 1076, in embedding
return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: index out of range at /opt/conda/conda-bld/pytorch_1524586445097/work/aten/src/TH/generic/THTensorMath.c:343`

when running the training on cpu i got this index out of range error.
Traceback (most recent call last):

  File "train.py", line 40, in <module>

    main(opt)

  File "train.py", line 27, in main

    single_main(opt)

  File "/home/gamut/OpenNMT-py/onmt/train_single.py", line 262, in main

    opt.valid_steps)

  File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 223, in train

    report_stats)

  File "/home/gamut/OpenNMT-py/onmt/trainer.py", line 384, in _gradient_accumulation

    dec_state)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/OpenNMT-py/onmt/models/model.py", line 61, in forward

    enc_final, memory_bank = encoder(src, lengths)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/OpenNMT-py/onmt/encoders/rnn_encoder.py", line 57, in forward

    emb = self.embeddings(src)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/OpenNMT-py/onmt/modules/embeddings.py", line 205, in forward

    source = self.make_embedding(source)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/container.py", line 91, in forward

    input = module(input)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in forward

    outputs = [f(x) for f, x in zip(self, inputs_)]

  File "/home/gamut/OpenNMT-py/onmt/modules/util_class.py", line 43, in <listcomp>

    outputs = [f(x) for f, x in zip(self, inputs_)]

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__

    result = self.forward(*input, **kwargs)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/modules/sparse.py", line 108, in forward

    self.norm_type, self.scale_grad_by_freq, self.sparse)

  File "/home/gamut/anaconda3/envs/zeroshotpy/lib/python3.6/site-packages/torch/nn/functional.py", line 1076, in embedding

    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)

RuntimeError: index out of range at /opt/conda/conda-bld/pytorch_1524586445097/work/aten/src/TH/generic/THTensorMath.c:343

I checked the prepdata.sh file , in the last step we cannot build the vocab file.
`

/home/aki/OpenNMT-py/preprocess_build_vocab.py(131)main()
129     import ipdb
130     ipdb.set_trace(context=5)
--> 131     opt = parse_args()
132     init_logger(opt.log_file)
133     logger.info("Building & saving vocabulary...")

`


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
Fixed URLs
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

[ ] http://www.apache.org/licenses/ with 3 occurrences migrated to:
https://www.apache.org/licenses/ (https result 200).
[ ] http://www.apache.org/licenses/LICENSE-2.0 with 185 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 (https result 200).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: spring-operator sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


AnyIO 2.0 support and new release

I'd love to see this project reach a release stage. If you need help migrating it to the AnyIO 2.0 API, I can probably do that. Beyond that, how much more work do you suppose this needs until you're ready to release?

@tzickel Thanks for your work on this project. The async Redis situation is pretty dire at the moment, since both https://github.com/aio-libs/aioredis and https://github.com/NoneGG/aredis have gone 6 months without maintenance. It's also brilliant that you support AnyIO. Do you plan to continue working on this?

Fixed, the other stuff for release is documented in the README roadmap.


Support for unit testing surrounding code is missing or undocumented

BriteDatabase is final and therefore cannot be mocked.  For me, this means code that using SqlBrite's database functionality cannot be unit tested by graceful means.  Is there any existing mechanism or intention for this library to support unit testing?
If there is an existing mechanism to support unit testing, it maybe needs documentation and I'd be happy to contribute that documentation.
In the interim, putting a light wrapper around the database may be a viable workaround.  I'm working on proofing that out in sample code and can report my findings here... though QueryObservable is also final... potentially compounding the problem or making the potential workaround non-viable.

There is no need to mock BriteDatabase. If you're testing queries and mapping you can use an in-memory DB by supplying null as the filename. If you want to fake the mapped values (e.g., List<Foo>) then you should have a higher-level of abstraction like a "store" or "repository" that you can mock/fake.
BriteDatabase operates at a level of abstraction that is unsuitable for mocking, as your tests would become tied to the consuming code. Every change in how you query would require a change in how you mock which is a strong indicator that you're mocking something not meant to be mocked.

I missed the open helper feature for in-memory databases.  Thanks you.
I'm actually working on writing tests for my repository.  I typically prefer to pass in a mocked persistence layer to my repositories.  I will evaluate this pattern against your point about tying tests to query implementation.  It has cause some pain.  Thanks again.

Another option could be Robolectric, which will provide JVM-compatible
implementation of SQLiteOpenHelper with actual SQLite under the hood.
But, of course Robolectric is very questionable answer to "unit" testing.
// And of course it's possible to mock SQLiteOpenHelper and delegate calls
to manually JNI-linked SQLite if you don't want to use Robolectric.
On Fri, Dec 15, 2017 at 2:37 PM Randall Mitchell<EMAIL_ADDRESS>wrote:

I missed the open helper feature for in-memory databases. Thanks you.
I'm actually working on writing tests for my repository. I typically
prefer to pass in a mocked persistence layer to my repositories. I will
evaluate this pattern against your point about tying tests to query
implementation. It has cause some pain. Thanks again.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/sqlbrite/issues/228#issuecomment-351984962,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7B3PyBY79tnVZgWAqDGcFz2PLaJpFOks5tAln-gaJpZM4RCLbO
.

I have a hard time recommending Robolectric for anything serious as the
Sqlite it uses is built for the JVM and lacks the ICU support that Android
provides. This means if you're using anything like collation you'll get
different results. That being said, it's always better than mocking. You
should never mock queries against the DB.
On Fri, Dec 15, 2017 at 2:44 PM Artem Zinnatullin :slowpoke: <
<EMAIL_ADDRESS>wrote:

Another option could be Robolectric, which will provide JVM-compatible
implementation of SQLiteOpenHelper with actual SQLite under the hood.
But, of course Robolectric is very questionable answer to "unit" testing.
// And of course it's possible to mock SQLiteOpenHelper and delegate calls
to manually JNI-linked SQLite if you don't want to use Robolectric.
On Fri, Dec 15, 2017 at 2:37 PM Randall Mitchell<EMAIL_ADDRESS>
wrote:

I missed the open helper feature for in-memory databases. Thanks you.
I'm actually working on writing tests for my repository. I typically
prefer to pass in a mocked persistence layer to my repositories. I will
evaluate this pattern against your point about tying tests to query
implementation. It has cause some pain. Thanks again.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/sqlbrite/issues/228#issuecomment-351984962,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA7B3PyBY79tnVZgWAqDGcFz2PLaJpFOks5tAln-gaJpZM4RCLbO
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/square/sqlbrite/issues/228#issuecomment-352094755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEESoYKIKulF7jYHXEsmTv97kgIn5gks5tAswUgaJpZM4RCLbO
.


[usecase] Add tests for NormallizingDialogs

Fail BugID: XWALK-4480

Impacted TCs num(approved): New 3, Update 0, Delete 0
Unit test Platform: Android
Android test result summary: Pass 1, Fail 2, Block 0

LGTM

normalizing -> normalizing


final Uint8List? image = await (imageKey.currentState!.exportImage()); taking 15 seconds

Is this normal behavior for this function to take so long after painting on an image? Please help! 😅

It depends on the resolution of the image. High-quality images will take more time to export compared to low-quality ones. I suggest you utilize a compression library before editing the photo.

It depends on the resolution of the image. High-quality images will take more time to export compared to low-quality ones. I suggest you utilize a compression library before editing the photo.

Yes thank you I was able to fix this by lowering quality.


Checklist for Onboarding Amber to the BizOps team

New Team Member Onboarding Checklist
Special Notes

Do not create this issue until the System Owner has formally authorized and requested it.. You can get that OK by one of two ways:

A:

[ ] A: System Owner creates this issue.

B:

[x] B.1: System owner emails<EMAIL_ADDRESS>and<EMAIL_ADDRESS>with their authorization.
[x] B.2: An operator adds a link to the Google Group conversation that includes the authorizing email.

Please only use first names.

In order to get New Person (Amber) productively contributing to the cloud.gov team, Buddy should help New Person complete a prescribed set of tasks that will bring them up to speed and get them setup with cloud.gov.
Instructions

Try to go through the checklists in order.
If Buddy can’t complete any of the items on their checklist personally, they are responsible for ensuring that someone with the correct access completes that item.

Onboarding Checklist
Required items for all team members
These items help us fulfill security and compliance requirements (including for FedRAMP). If you get stuck, or if these requirements are confusing, ask for help from your buddy or in a cloud.gov channel.

[ ] Take judicious notes on what about this onboarding process or cloud.gov is confusing or frustrating. If you notice a problem (especially with things like documentation), you are more than welcome to fix it! At the very least, please share this information with your onboarding buddy (or someone) at some point so we can make the team/platform better. (You can also file issues and pull requests on the template Onboarding checklist.
[ ] Be sure to introduce yourself and follow up with your onboarding buddy (they should have reached out to you at this point; if they haven't, please let the team know) and make sure this issue is assigned to them in our Github Project Planning Board. We use this board to organize, prioritize, and track our work.

Pre-requisites

[ ] Complete GSA OLU GSA Mandatory Cyber Security and Privacy Training, including accepting the GSA IT Rules of Behavior, which is required before we can give you access to any cloud.gov systems. If you joined GSA more than two months ago, you've already completed this task and can just check the box.

Fulfill security and compliance requirements (including for FedRAMP) - Completed by onboarding buddy

[ ] Make sure they're in the list of people working on the project.
[ ] Add their name, whether they're Cloud Ops (Platform), and the date they joined the team to the training tracker. Copy the formulas for the due dates from an existing row (grab the "corner" of the cells and pull down).
[ ] As they complete training, fill out their completion dates in the training tracker.
[ ] Add them to the @cloud-gov-team in Slack’s Team Directory.
[ ] Review the recurring cloud.gov meetings that are relevant for them in the team calendar (they will get access to this when added to the cloud.gov Team Google Group).
[ ] Add them to the cloud-gov organization in GitHub, and the cloud-gov-team team.

Learn our policies and procedures
For the three trainings list at the top, your onboarding buddy will create a separate ticket to track the trainings once scheduling has been finished.  This will help consolidate trainings for multiple new members to the team and prevent them from blocking progress on this onboarding ticket.  Once the trainings are scheduled, they can be marked as complete here.

[ ] Coordinate with your onboarding buddy to go through Contingency Planning training within 60 days (and annually after that). This will cover the following document, which you should also review before or after training:

[ ] Read the Contingency Plan.

[ ] Coordinate with your onboarding buddy to go through Incident Response Training within 60 days of joining the team (and annually after that). This will cover the following document, which you should also review before or after training:

[ ] Read the Incident Response Guide.

[ ] Coordinate with your onboarding buddy to go through nonpublic information training within 60 days of joining the team (and annually after that). This will cover the following documents, which you should also review before or after training:

[ ] Review the cloud.gov open source policy guidance about protecting sensitive information.
[ ] Read our sharing secret keys policy.
[ ] Review the TTS requirements for password management.

[ ] Read the Continuous Monitoring Strategy, particularly the cloud.gov team responsibilities.
[ ] Read the Configuration Management Plan.
[ ] Read the cloud.gov Security Policies and Procedures. These documents explain the high-level policies and procedures we must comply with while running cloud.gov, sorted into security control "families" They explain that we follow GSA IT security policy, and they provide a summary of the procedures in our System Security Plan.
[ ] Review the System Security Plan (the latest version lives on Google Drive; look for "cloud.gov System Security Plan (SSP)" as a .docx file). Of particular note for onboarding: Section 9 (System Description) and Section 10 (System Environment)

Getting to know cloud.gov
These items will help you come up to speed on cloud.gov and what it is, how it works, why it exists, etc.  While you
should take the time to go through them, please do not try and tackle it all in one shot!  It can become overwhelming
very quickly, so your onboarding buddy will walk through this list with you at a high level with you to help manage the work.

[ ] Read the team onboarding document for more context about cloud.gov.
[ ] Bookmark the pertinent links listed here.
[ ] Read through the Overview section of our site for a broader understanding of cloud.gov, especially how we present it to potential customers and users.
[ ] Sign up for a cloud.gov sandbox using your GSA email address and start experimenting to get familiar with the basics of the PaaS from a user's perspective.

This is also required in order to make you a platform admin once you've completed the Cybersecurity and Privacy training.

[ ] Read the Delivery Process document to learn about how we work.
[ ] Read our service disruption guide to learn how we handle customer-facing service disruptions.
[ ] Add the cloud.gov Google Drive folder to your Google Drive -- that's where we put cloud.gov docs. If you create or move a doc there, it'll get the right access permissions for team members to be able to view and edit it.
[ ] Subscribe to the cloud.gov team calendar (click the + in the bottom right) so you know when assorted team meetings are happening in the various squads. Tip: When you plan Out of Office time, make a calendar event for that on the cloud.gov calendar so that your teammates know you'll be away

Slack channels
Your onboarding buddy will add you to these Slack channels:

[ ] #cloud-gov - bots post announcements here
[ ] #cg-billing - private business development channel (if applicable)
[ ] #cg-business - business development (if applicable)
[ ] #cg-compliance - compliance-related information and discussion
[ ] #cg-offtopic - off-topic team sharing
[ ] #cg-platform - platform operations
[ ] #cg-platform-news - bots post platform alerts
[ ] #cg-general - program-level information and discusion
[ ] #cg-support - support requests and assistance within TTS
[ ] #cg-incidents - private channel for incident response
[ ] #cg-priv-all - private channel for in-team discussion
[ ] #cg-priv-gov (Federal employees only) - may contain discussion of contracting-related or other private, federal-employee-only comms

Once you're added to these channels, you probably want to mute these channels until you're on support rotation:

[ ] #cg-support - support requests and assistance within TTS
[ ] #cg-platform-news - platform alerts

Ashley M authorized: https://groups.google.com/a/gsa.gov/g/cloud-gov-compliance/c/2vBVoU3BpDU


Adding method to plot network output

Left a couple of testing scripts and a commented line in policy.py. Can remove and squash after any changes.

There is a problem here. In order to avoid messier code... I flip the board vertically so that it looks the way most go software will display the game record. By flipping the axis when doing this... it also flips the labels on the y axis which is representative of the traditional labelling... not the western style.


Overall UI update

This branch should contain any commits regarding the updated models we're using for bills (see ACT and Federal parliaments as a guide).

@king-millez This is really good! I'm glad that the UI was able to be aligned and I can see all the effort you have put into it. This will make it very easy for users.
I especially like that you can get all the bills across the states. eg:
from ausbills.parliament import act, nsw
from pprint import pprint

pprint(act.get_bills_metadata())
print()
pprint(nsw.get_bills_metadata())

I do have some minor adjustments that I'd like to make:

some typing fixes
some module fixes

I'll put them in a branch and make a PR to this branch.


Rotate gov_uk_notify_api_key Credential

The secrets-rotation-reminder workflow has identified that the gov_uk_notify_api_key credential requires rotation as it is close to or exceeding the threshold of 180 days.
Consult this documentation which describes the process for rotation.

This was created to test the workflow and check whether the PAT token is working correctly.


remove Datastyles. upgrade enzyme. add toolbar styles support

When merged this should resolve #162

Coverage decreased (-0.09%) to 78.478% when pulling a5c812386957904caaa149e4f6ed6077d9a4c6a4 on bugfix/toolbar-styles into 34e9c886e4e43381838ff696178f303c20cddf50 on master.


Add default data for all rooms under ICS management

do work issue-154
https://drive.google.com/drive/folders/1kxTCM6NS047MBhVwKuL6LEVtqD9GHz9r
3rd-floor-rooms.txt has the list of ics rooms

I think I got all the rooms


update the color

refer https://issues.redhat.com/browse/ACM-5707

@clyang82 let me know if you have any comments


[Fail] [k8s.io] Security Context bucket [It] runtime should support that ReadOnlyRootfs is false

[k8s.io] Security Context bucket
  runtime should support that ReadOnlyRootfs is false
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:324
[BeforeEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:52
[It] runtime should support that ReadOnlyRootfs is false
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:324
STEP: create pod with log
STEP: create a PodSandbox with log directory
STEP: create container with ReadOnlyRootfs_false
STEP: create ReadOnlyRootfs container
STEP: Get image status for image: busybox:1.26
STEP: Create container.
Sep 29 00:25:57.986: INFO: Created container "2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933"

STEP: start container
STEP: Start container for containerID: 2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933
E0929 00:25:58.049758   23053 remote_runtime.go:209] StartContainer "2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933" from runtime service failed: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown
Sep 29 00:25:58.049: INFO: Unexpected error occurred: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown
[AfterEach] bucket
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:238
STEP: stop PodSandbox
STEP: delete PodSandbox
[AfterEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51

â€¢ Failure [1.531 seconds]
[k8s.io] Security Context
/home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:72
  bucket
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:406
    runtime should support that ReadOnlyRootfs is false [It]
    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:324

    failed to start container: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown
    Expected error:
        <*status.statusError | 0xc4202ea1e0>: {
            Code: 2,
            Message: "failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown",
            Details: nil,
        }
        rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown
    not to have occurred

    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/container.go:372

Seems like a containerd problem:
failed to create containerd task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v1.linux/k8s.io/2cc73cbeb1e706769018807c35ba56c7102d90a921359f8684d3974fae2ec933/log.json: no such file or directory): runc did not terminate sucessfully: unknown"

https://s3.amazonaws.com/archive.travis-ci.org/jobs/281093088/log.txt?X-Amz-Expires=30&X-Amz-Date=20170929T004940Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170929/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=92e2fab46ef60cc578fbfe3fa3355e33cd0beca2f806ce94e46cccd7dfcfa736

This is probably related to https://github.com/containerd/containerd/pull/1570

@crosbymichael Hm, but we are not using WithRootFSPath

Another occurrence:
[k8s.io] Security Context NamespaceOption
  runtime should support HostIpc is true
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:152
[BeforeEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:53
[It] runtime should support HostIpc is true
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:152
STEP: create shared memory segment on the host
STEP: create podSandbox for security context HostIPC is true
STEP: create NamespaceOption podSandbox
STEP: create a default container with namespace
STEP: create NamespaceOption container
STEP: Get image status for image: busybox:1.26
STEP: Create container.
Oct  4 01:41:09.477: INFO: Created container "09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550"
STEP: start container
STEP: Start container for containerID: 09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550
Oct  4 01:41:09.574: INFO: Started container "09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550"
STEP: Get container status for containerID: 09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550
STEP: check if the shared memory segment is included in the container
STEP: execSync for containerID: 09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550
E1004 01:41:09.611671   23158 remote_runtime.go:332] ExecSync 09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550 'ipcs -m' from runtime service failed: rpc error: code = Unknown desc = failed to exec in container: failed to start exec "9b8cdd80f7c0222be43cde046099c6e6b995209522961432e59662d1c75eeeb2": OCI runtime exec failed: runc did not terminate sucessfully: unknown
Oct  4 01:41:09.611: INFO: Unexpected error occurred: rpc error: code = Unknown desc = failed to exec in container: failed to start exec "9b8cdd80f7c0222be43cde046099c6e6b995209522961432e59662d1c75eeeb2": OCI runtime exec failed: runc did not terminate sucessfully: unknown
[AfterEach] NamespaceOption
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:65
STEP: stop PodSandbox
STEP: delete PodSandbox
[AfterEach] [k8s.io] Security Context
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
• Failure [2.064 seconds]
[k8s.io] Security Context
/home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:72
  NamespaceOption
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:228
    runtime should support HostIpc is true [It]
    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/security_context.go:152
    failed to execSync in container "09f99aaf3e7e9d75c9aaa6a2ebf3bc96266775c35e3dc878ecb9478da9618550"
    Expected error:
        <*status.statusError | 0xc421053bf0>: {
            Code: 2,
            Message: "failed to exec in container: failed to start exec \"9b8cdd80f7c0222be43cde046099c6e6b995209522961432e59662d1c75eeeb2\": OCI runtime exec failed: runc did not terminate sucessfully: unknown",
            Details: nil,
        }
        rpc error: code = Unknown desc = failed to exec in container: failed to start exec "9b8cdd80f7c0222be43cde046099c6e6b995209522961432e59662d1c75eeeb2": OCI runtime exec failed: runc did not terminate sucessfully: unknown
    not to have occurred
    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/container.go:454


Forward keyword args to initialize

This fixes an ArgumentError that would have been raised for classes including Dry::Configurable whose #initialize has required keyword parameters.
This is required to convert the base Hanami::Configuration class to dry-configurable, since that class has the following #initialize (whose params signature I'd like to retain):
def initialize(env:)

@solnic @flash-gordon lemme know if you're happy for this to go in :)

@solnic @flash-gordon Pushed another commit showing the simplified version working. If you're good with this I'll do a squash when I merge the PR.


Record commit hash of GlyphData?

In the review of https://github.com/googlei18n/glyphsLib/pull/92, @anthrotype asked if the glyphdata_generated.py file should record the commit hash of the schriftgestalt/GlyphsInfo repository from which the GlyphData.xml was downloaded. One option is to add schriftgestalt/GlyphsInfo repo as a git submodule of glyphsLib, and run the generate_glyphdata.py script from the local submodule checkout, instead of curl-ing the file from raw.githubusercontent.com as it does now.
Thoughts?

Another way, instead of the submodule, would be to use send a GET request to Github API and retrieve the commit hash of schriftgestalt/GlyphsInfo/master:
https://developer.github.com/v3/repos/commits/#list-commits-on-a-repository
A bit of curl and sed does the trick:
curl https://api.github.com/repos/schriftgestalt/GlyphsInfo/commits/master --stderr /dev/null | grep '"sha":' | head -n1 | sed -E 's/  "sha": "(.*)",/\1/'

I'm sure with urllib.request you can do the from Python:
https://docs.python.org/3/library/urllib.request.html#module-urllib.request


Add boolean renderSkybox in commons.Scene

This PR is for someone using the Mundus runtime, who does not want to render a skybox, or wants to disable/enable skybox rendering it whenever they want in their game.

If you move this variable into Skybox class like this:
public boolean visible = true;

And move the render logic also into Skybox class what use this logic then you can disable/enable skybox on a screen not just all screen. And later can create settings screen for it in Mundus editor.

I am open to moving the boolean to to the Skybox class, but not convinced that we should move the skybox render logic to it also.
Given that the rendering of the skybox happens in the Scene class, and you can only render one scene at a time (and therefore only 1 skybox at a time), it doesn't make sense to change the original intent of having the render logic for the entire scene in the Scene class.
It is just an opinion, I will let JTK chime in on what he thinks is best.  For me, I just need this functionality for a project I am working on.

Here is my thoughts. Keep render logic in the Scene for now. If we did move rendering logic out of Scene this is not the PR to do it with. Skybox doesn't derive from GameObject but the way you disable GameObjects is via an boolean active variable.
For consistency lets do the same thing for Skybox. Add public boolean active; to Skybox class then check if skybox is active in Scene.java when rendering it. This will make it easy to tap into via the UI settings later.
The Skybox is public in Scene so the runtime should be able to access scene.skybox.active variable. Will merge PR if you can make that change.

public boolean active;
added to Skybox.java and
this.active = true;
set in constructor.
In the future if you guys add a active/inactive checkbox in the editor, maybe we should change the Skybox's constructor() and set() methods in the Skybox class to allow you to pass this active boolean parameter to the methods.
Let me know if you would like me to make any other changes.

Thanks for approving this PR.  Disabling the skybox sets us free.   Link below:
https://imgur.com/eBJNIyO


Aggregate PyPI Metadata (Tags/Versions/Author Info)

An account's first commit is far more likely to contain malicious code than accounts that have a history of commits.
Conceptually, I would like to use this to manually audit new packages-- a list of packages published by new authors would allow us to potentially catch new packages that are not being flagged by our current ruleset.

Currently not possible without great effort. I'm going to close this as unplanned/unsupported for now, and re-approach this if API accommodations are made on PyPI's end to make that information accessible to us.


Please enable segmented synthesis

Currently SimpleEnunu does not enable segmented synthesis, and CUDA out of memory occurs when synthesize a long song. This PR will fix it

CUDA OoM is one of the most frequent troubles, thank you!


config prerelease does not take effect in pyproject.toml

uv: 0.4.29
adding the config:
[tool.uv.pip]
prerelease = "allow"

does not take any effect, but the following does:
[tool.uv]
prerelease = "allow"

Not sure which one is intended, but the documentation is not correct at the moment: Link

Please see https://docs.astral.sh/uv/configuration/files/#configuring-the-pip-interface

I see, my fault. Thank you


no view manager defined for class RNSVGPath

tried this basic example and getting this issue "No ViewManager defined for class RNSVGPath"
did the react-native link react-native-svg so many time,  and every time re build the app too.
import React from 'react'
import Svg, {
  Path
} from 'react-native-svg'

export default class SvgExample extends React.Component {
  render() {
    return (
      <Svg height="100" width="100">
        <Path d="M 40 60 A 10 10 0 0 0 60 60" stroke="black" />
      </Svg>
    )
  }
}

additional info
     "react": "16.0.0-alpha.12",
    "react-native": "0.47.0",
    "react-native-svg": "^6.0.0-rc1"

react-native-cli: 2.0.1

I'm gettomg the same errpr, using the following versions
"react": "16.0.0-beta.5",
"react-native": "0.49.3",
"react-native-svg": "^6.0.0-rc1",

Same here.

I resolved the same issue by using the version 5.4.2 of react-native-svg

This is failed linking issues, follow the manual linking instructions.


[Q] using tsswitch and remote control, not showing the selected input

I am using tsswitch to switch between various inputs and expecting that as soon as the first input completes, the next input will start. But thats not happening. Then I added the remote control and sending the input id, is not working either.
tsswitch command is as follows
tsswitch -v --remote 4444 --delayed-switch --cycle 2  \
-I file /home/lenovo/vandana/tvinabox/videomanagement/server/public/converted/clipcanvas_14348_offline.ts \
-I file /home/lenovo/vandana/tvinabox/videomanagement/server/public/converted/big_buck_bunny_720p_1mb.ts  \
-I fork `tsp -I ip -l  <IP_ADDRESS> :1234 -P until --seconds 20`  \
 -O  ip <IP_ADDRESS>:12345

Any suggestions?
If i take the output to a file and have switched to another input using echo 1 >/dev/udp/<IP_ADDRESS>/4444, and play the output file using mplayer, it gives me a TS_PARSE error after showing the 1st video for some time.
do the inputs to the tsswitch command, need to be similar in some properties?

expecting that as soon as the first input completes, the next input will start. But thats not happening.

Are you sure? How do you characterise that this is not happening?
Trying something similar works as expected:
$ tsp -I craft --pid 100 --count 1 -O file in1.ts
$ tsp -I craft --pid 200 --count 2 -O file in2.ts
$ tsswitch -v --remote 4444 --delayed-switch --cycle 2  \
    -I file in1.ts \
    -I file in2.ts \
    -I fork 'tsp -I craft --pid 300 --count 3' \
    | tsdump | grep PID:
  PID: 100 (0x0064), header size: 4, sync: 0x47
  PID: 200 (0x00C8), header size: 4, sync: 0x47
  PID: 200 (0x00C8), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47
  PID: 100 (0x0064), header size: 4, sync: 0x47
  PID: 200 (0x00C8), header size: 4, sync: 0x47
  PID: 200 (0x00C8), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47
  PID: 300 (0x012C), header size: 4, sync: 0x47

We can see two cycles of the three inputs in sequence.

play the output file using mplayer, it gives me a TS_PARSE error after showing the 1st video for some time.
do the inputs to the tsswitch command, need to be similar in some properties?

tsswitch does not make any assumption from input. It just routes TS packets. The problem is the consistency of the output. At the switch point, the content and structure of the output TS suddenly changes without prior notice. When a player reads this TS, it may be confused. Let's take one example: the two files have the same structure, same TS id and service id, same component PID's but different video encoding (AVC and HEVC for instance). At the switch point, the player is not notified of the change (why should it be?) and the AVC codec suddenly receives HEVC data. We may find many similar examples leading to inconsistencies.
When you switch from one input to another, you need to make sure that the change is either properly notified (distinct TS id, service ids, PAT and PMT version) or fully transparent (exact same TS structure, PAT, PMT, PID's and codecs).

Thanks @lelegard for answering and clarifying doubts.
The issue was with the disparate ts structured files. Once thats was fixed, tsswitch worked correctly for me, and kept showing the next input. Thanks

These did not work, but is this even possible? 2 ts files and 1 stream as input to tsswitch

All combinations of inputs are technically possible, this one included. You problem is likely not linked to the input switching but rather to the interpretation of an output stream which is in fact a sequence of distinct streams with similar although not identical structure.

Thanks for your reply @lelegard,  and wish you a very happy 2021.

Thanks for your reply @lelegard,  and wish you a very happy 2021.


[TypeError: null is not an object (evaluating 'MultipleImagePicker.openPicker')]  in ios

I configured already:
1 . NSCameraUsageDescription
1
NSLocationWhenInUseUsageDescription

NSPhotoLibraryAddUsageDescription
1
NSPhotoLibraryUsageDescription
1
2. change this "$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)" to "$(TOOLCHAIN_DIR)/usr/lib/swift-5.3/$(PLATFORM_NAME)"
still not work on ios ("react-native": "^0.64.0"). but android work as a charm. thanks)

add swift file and header configure as tutorial but react-native run-ios have no success. anyway this plugin is so cool. hope near the future will fix and work both ios and android

Have you tried to run pod install in the ios folder?
And then build the app via Xcode instead of run-ios in Terminal.

yes I did. but no success

I am also facing same issue @baronha

I am having same issue on android

I am having same issue on android

Are you upgrade to new version v1.1.2?


Remove enhanced delegation external feature

Enhanced delegation has been out and enabled by default for a long time now. Considering it's enabled in around 87% of Power Apps and there is confidence in the feature, we're getting rid of it as a setting and just making it the default behavior.

✅ No public API change.

✅ No public API change.


Added sorting mechanism

Added a file to sort the term in alphabetical order /bin/sort.js
Updated the package.json adding command to run the sort "sort": "cd bin && node sort.js"
Updated the Readme.md file for contributors to sort the file by running yarn run sort before making a PR

Will like to have hactoberfest or HACKTOBERFEST-ACCEPTED label on the PR if it's accepted

@Qudusayo Thanks for your contribution. I love this!
Kindly resolve conflict so I can merge this ASAP.

Thank you @Qudusayo


Support for alternate conda package dependency resolver

I wanted to open this as a possible feature/enhancement. Solving for the environment can take some time in running flows and was wondering if support for alternate dependency resolvers like https://github.com/mamba-org/mamba is planned
The Proposal
Support for alternate dependancy resolver like  https://github.com/mamba-org/mamba to be able to speed up the part of running flows that requires resolving dependencies
Why
Iterate through flows faster

@jamesbsilva Yes, indeed a very timely issue. I have been wanting to carve out some time and test swapping out conda with mamba.

Also, linking #24 here.

Mamba as a conda package resolver is now available - you can set the environment variable (or add it into your ~/.metaflowconfig) - METAFLOW_CONDA_DEPENDENCY_RESOLVER=mamba to use mamba instead of conda. The mamba executable needs to be in your $PATH.


feat: WFT-653 Added Whispir Verify APIs

Preview: https://whispirrestapi.stoplight.io/docs/api/branches/feat%2FWFT-653-added-verify-apis/pk6eca8bz1c3k-send-code

Updated verify description as discussed


Fixed open ai windows api key issue and related issue

Closes #59
Signed-off-by: titonova<EMAIL_ADDRESS>

Hey thanks for the fix, there was already a PR for this from another contributor - can you check the main branch if it works and add anything you think is missing?

@123vivekr They didn't fix the open ai key issue just the conflicting class names

@titonova try to rebase your PR

rebase your PR

@Israel-Laguan No point, I dont think it's going to be accepted regardless


Production php ini not copied to conf folder

It seems that the file prod-php.ini is never copied to the conf folder. Both base and dev has a COPY line, but not production.

 Thanks for reporting this, It's a regression from commit 6060e904, I just pushed a fix.


How to specify a directory (not a file)

Right now I have the following, with more to come.
require("file?name=[path][name].[ext]&context=./src!./img/logo.png");
require("file?name=[path][name].[ext]&context=./src!./img/bg.png");
require("file?name=[path][name].[ext]&context=./src!./img/envelope.png");
require("file?name=[path][name].[ext]&context=./src!./img/camera-black.png");

And this creates the img/ folder in the build folder as expected and populates it with the four files.
The reason we do this is, because the folder is shared buy a number of customers who develop their own custom modules and don't often use webPack - but do put their files / folders into the src/img folder for automated building.
So there are things like
 /img/cust1/*.*
 /img/cust2/*.*
 /img/cust3/*.*
 /img/cust4/*.*

What i was trying to do was bundle them in one go when we build the site / tenants rather than having to pipe all the directory listing into a file and then globally replace parts of the path with the requires section and run macros to fix the line endings. I have to do this every time a new file is added, so it just gets done manually as part of the build every time regardless - just in case there is another files or a file that been removed
I tried doing all of these but I get must be a 'file' or 'directory' errors.
require("file?name=[path][name].[ext]&context=./src!./img/**");
require("file?name=[path][name].[ext]&context=./src!./img/**/");
require("file?name=[path][name].[ext]&context=./src!./img/**/*.png");
require("file?name=[path][name].[ext]&context=./src!./img/");
require("file?name=[path][name].[ext]&context=./src!./img");
require("file?name=[path][name].[ext]&context=./src!./cust1/*.*");
require("file?name=[path][name].[ext]&context=./src!./cust1/");

How do you specify a "directory" like the error messages says you can ?

You shouldn't use webpack to (just) copy your files. require the images where they are used.

@sokra - OK sounds good,
So say that I'm using React.JS and I have this component definition that I would normal write as
module.exports = React.createClass({
  displayName: 'Notification',
  applyStyle: function() {
    this.props.style = {
      position: "absolute",
      width: 100,
      height: 60,
      minWidth: 100,
      top: 0,
      right: 200,
      background: "url(/img/envelope.png) 0 0 no-repeat",
      cursor:"pointer"
    };
  },
  render: function () {
    this.applyStyle();
    return React.createElement('section', this.props, badge);
  }
});

If I insert a line before the module.exports that goes something like?
var png = require("file?name=[path][name].[ext]&context=./src!../../img/envelope.png");

and then I can change the line referencing the png to:
background: "url("+png+") 0 0 no-repeat",

So I guess my question is, does it matter any more what the file is named and would a more general hash type requires just be a better idea?

It doesn't matter how it's named and the default is pretty good.
You shouldn't write loaders inline. Better put them in your config. http://webpack.github.io/docs/using-loaders.html#configuration
var png = require("../../img/envelope.png");

OK - that look seven better and much easier to write the requires like that anyway ...

OK I added a loader in the webpack.config.js
 { test: /\.jpe?g$|\.gif$|\.png$/i, loader: "file" },

and i get the following error messages on rebuilt: (webpack-dev-server)
ERROR in (desktop) ./src/img/envelope.png
Module parse failed: F:\Projects\Reactify\src\img\envelope.png Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
(Source code omitted for this binary file)
 @ ./src/js/components/Notification.react.js 12:10-43

but if I just do a command line
webpack

the file is written to the build folder (in this case as).
cc2b54823b17c401ae4933285c5454d2.png

webpack.config.js is only used for CLI. When you use the node.js API require("./webpack.config.js")

I'm not using node, I'm just building a JavaScript based browser app using react. The files, index.html , bundle.js and the few image files will just be put in a root folder of some web server at a later date. right now i just using "webpack-dev-server"
I just run a command line of  "webpack-dev-server --progress --colors"
And when it starts I just then edit the code and save, and the browser refreshes.
I'm sorry but I don't understand what you're trying to get me to do. I'm not even sure i understand what that means anyway.

Sorry for the confusion.. I missread your comment.
I'm I right that you get different results for webpack-dev-server and webpack?

yes i did - which confused me..
I've been playing around with the webpack.config.js and I just got it working
what I did was:
{ test: /\.jpe?g$|\.gif$|\.png$/i, loader: "file" },

(working for "webpack" only and failing in "webpack-dev-server")
but when I did this:
{ test: /\.jpe?g$|\.gif$|\.png$/i, loader: "file-loader" },

it works for both "webpack" and "webpack-dev-server"
it's now doing a great job pulling in all the images across various pages as I edit and save,
:+1:

huh... That's pretty weird. Are both webpack-dev-server and webpack installed locally in your project

"devDependencies": {
    "css-loader": "^0.9.1",
    "extract-text-webpack-plugin": "^0.3.8",
    "file-loader": "^0.8.1",
    "html-loader": "^0.2.3",
    "html-webpack-plugin": "^1.1.0",
    "json-loader": "^0.5.1",
    "minimist": "^1.1.0",
    "sass-loader": "^0.3.1",
    "style-loader": "^0.8.3",
    "typescript-loader": "^1.0.0",
    "url-loader": "^0.5.5"
    "webpack": "^1.5.3",
    "webpack-dev-server": "^1.7.0"
  }

I don't know...

no worries, like a said by adding the -loader it all work exceptionally well - nice product by the way.

You shouldn't use webpack to (just) copy your files. require the images where they are used.

@sokra We have the following use case: We use a 3rd-party npm module that is a React component used to display country flags. The component provides the 2,000 country flags alongside it and refers to them using a path (that can be overridden). Wouldn't that be a case where we want to "copy" the flags folder to the build using Webpack? It would be technically equivalent to "requiring" them one after one, but done automatically based on the current file structure.

@mathieumg Interesting use case. Did you find a solution within the webpack eco-system? My use case is somewhat similar.
@sokra
I've to refer to assets (images) from HTML pages webpack doesn't know about and can't load/parse so I can't "require" the images in those pages. Right now, I've to import those images inside a CSS or JS file so webpack copies them over. How would we fix that?

For now I'm doing it like this,
require("my-module/images/" + /^.*$/);

Is there a better way?

@owais No solution yet, I have the sideproject of writing a plugin.

Closing this since it is outside the scope of file-loader and this issue has been inactive for a very long time. Feel free to create a new issue with a more specific issue.

@owais
thx for the suggestion... but it doesn't work at my stack
Error: Cannot find module './/^.*$/'.


Fix Terrform Destroy Error on EKS Canary

Issue #, if available:
Although it's not causing functional problems, the terraform destroy step on the eks canary returns a failure due to having an invalid aws_region variable. Ex: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/7093413738
Description of changes:
Removed aws_region on the terraform provider description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (f5865f4) 35.97%.
Report is 164 commits behind head on main.

Files
Patch %
Lines

...ent/providers/AwsAppSignalsCustomizerProvider.java
24.00%
35 Missing and 3 partials :warning:

...gent/providers/AwsSpanMetricsProcessorBuilder.java
0.00%
20 Missing :warning:

...ders/AttributePropagatingSpanProcessorBuilder.java
0.00%
16 Missing :warning:

...viders/AwsMetricAttributesSpanExporterBuilder.java
0.00%
11 Missing :warning:

...try/javaagent/providers/AwsSpanProcessingUtil.java
90.16%
1 Missing and 5 partials :warning:

...vaagent/providers/AwsMetricAttributeGenerator.java
96.89%
2 Missing and 3 partials :warning:

...y/javaagent/providers/AwsSpanMetricsProcessor.java
91.48%
0 Missing and 4 partials :warning:

...t/providers/AttributePropagatingSpanProcessor.java
94.59%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #628       +/-   ##
=============================================
- Coverage     85.71%   35.97%   -49.75%
- Complexity       19      205      +186
=============================================
  Files             3       39       +36
  Lines            49     1301     +1252
  Branches          5      141      +136
=============================================
+ Hits             42      468      +426
- Misses            3      811      +808
- Partials          4       22       +18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for gz.msgs.EntityWrench

🎉 New feature
Closes #566
Summary

Adds the new ros_gz_interfaces/msg/EntityWrench, with structure compatible with gz.msgs.EntityWrench. This enables the user to apply wrenches to Gazebo entities using ROS topics.
Also implements the ros_gz_bridge mapping between ros_gz_interfaces/msg/EntityWrench and gz.msgs.EntityWrench.
Test it

Manual testing involves spawning any entity in Gazebo and loading the gz::sim::systems::ApplyLinkWrench plugin to the world SDF. Then, call the ros_gz_bridge to expose the entity wrench topic as follows (YAML syntax):
- topic_name: "/world/<world_name>/wrench"
  ros_type_name: "ros_gz_interfaces/msg/EntityWrench"
  gz_type_name: "gz.msgs.EntityWrench"

Wrenches are then applied to selected entities using the "/world/<world_name>/wrench" topic.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] Consider updating Python bindings (if the library has them)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Hi @ahcorde , sorry for my delay. While working on merging the PR with the base ros2 branch, I ended up forgetting to signoff a commit and things got messy. I opened another PR checking out directly from the ros2 branch which I believe is better now. Thanks for the support!


fix sustainability card view click

dod: tapping on the card to view the detailed info of the sustainability card, rather than tapping on the text/title of the card view.

@haythamodeh - please create and link a pull request to this card when you are moving the issue to "Done". It keeps things clearer for the team process, and the issue will be closed when the pull request is merged.