[BootstrapAdminUi] Add custom stimulus controller

Description
When using the BootstrapAdminUi bundle out of the box, it is a nice DX to not have to install and configure Symfony Stimulus Bundle and care that it exists at all.
At some point, when needed to add custom Stimulus controllers, we tried with what it seems a "standard Symfony way" by adding Symfony Stimulus Bundle.
For completeness, we chose AssetMapper to handle assets.
Consequences are there are two started Stimulus apps: one by BootstrapAdminUi  and the other is the custom one with Stimulus Bundle.
So all requests made by live components are made twice.
Additional context
By overriding the template of the sylius_admin.base#javascripts hook, we may avoid the load of the asset bundles/syliusbootstrapadminui/app.js.
It avoids the start of the Stimulus app by BootstrapAdminUi but other features like the ones provided by https://github.com/Sylius/Stack/tree/8fcb13f517662e7aa0cb24453dcd2e721a4af0eb/src/BootstrapAdminUi/assets/scripts are broken.
How to reproduce

Follow https://stack.sylius.com/getting-started.
Install Symfony Stimulus Bundle
Go on an admin page where there is a live component.
Trigger an action (either live action or update a model or emit an event etc..)
Check the number of AJAX requests with the profiler

Possible solutions
Before proposing a patch, I'd like to have feedback on how to address this.
Maybe I missed something somewhere 🤔

BootstrapAdminUi may stop starting a Stimulus app.
It will imply that users will have to do it themselves like with Stimulus Bundle.
It seems fairly simple for a user to do it. In another hand it increases the number of dependencies a user have to handle.

BootstrapAdminUi may propose a way to allow users to chose if it should start a Stimulus app or not.
It may increase the complexity of maintenance of BootstrapAdminUi.
It will keep the nice DX allowing people to not care about the Stimulus part if they don't need to.

BootstrapAdminUi may propose to reuse it's started Stimulus app in order to register custom controllers with it.
Users won't be able to use the default behavior of the Stimulus Bundle which register the controllers automagically.
Others "admin UI theme" may chose to do the same to ease life of users.

@brambaud we were discussing last week with @loic425, I tried exactly what you did and have my own components running.
@loic425 and I want to support Symfony asset mapper and Webpack to be able to switch from one to another and allow sylius/sylius to also get a migration path.
To complete your work around, here what I'm currently doing:
Disable the #javascripts Sylius Twig hook at the bottom, replace the #stylesheets in the <head> by importmap block and function:
# config/packages/sylius_twig_hooks.yaml
sylius_twig_hooks:
    hooks:
        'sylius_admin.base#stylesheets':
            styles:
                template: 'shared/layout/admin/importmap.html.twig'
        'sylius_admin.base#javascripts':
            javascripts:
                enabled: false

# templates/shared/layout/admin/importmap.html.twig
{% block importmap %}{{ importmap('app') }}{% endblock %}

Then to get bootstrap working :
bin/console importmap:require bootstrap
bin/console importmap:require tom-select/dist/css/tom-select.bootstrap5.css

Tell Symfony UX autocomplete to use bootstrap5 theme:
# assets/controllers.json
{
    "controllers": {
        "@symfony/ux-autocomplete": {
            "autocomplete": {
                "enabled": true,
                "fetch": "eager",
                "autoimport": {
                    "tom-select/dist/css/tom-select.default.css": false,
                    "tom-select/dist/css/tom-select.bootstrap4.css": false,
                    "tom-select/dist/css/tom-select.bootstrap5.css": true
                }
            }
        },

        [...]
    },
    "entrypoints": []
}

Update assets/app.js with the css and js from Sylius Bootstrap Admin UI.
First add a new asset mapper path to use scripts from the bundle:
# config/packages/asset_mapper.yaml
framework:
    asset_mapper:
        paths:
            'assets/': ''
            'vendor/sylius/bootstrap-admin-ui/assets/scripts/': 'bundles/syliusbootstrapadminui-scripts'

import './bootstrap.js';
import './styles/admin.css';

// @todo An other way is to use symfonycasts/sass-bundle to only add required CSS
import '../vendor/sylius/bootstrap-admin-ui/public/app.css';
import '../vendor/sylius/bootstrap-admin-ui/public/app.rtl.css';

// imported to initialize global plugins
// dropdown, collapse, tab
import * as bootstrap from 'bootstrap';
import '../vendor/sylius/bootstrap-admin-ui/assets/scripts/bulk-delete.js';
import '../vendor/sylius/bootstrap-admin-ui/assets/scripts/check-all.js';
import '../vendor/sylius/bootstrap-admin-ui/assets/scripts/menu-search.js';
import '../vendor/sylius/bootstrap-admin-ui/assets/scripts/bootstrap.js';


UnboundLocalError: local variable 'args' referenced before assignment

Bytecode can be found here if you want to test it:
Download
For some bytecodes when I try to extract the CFG using:
python3 main.py -f bb.bin -g
I get the following error:
Traceback (most recent call last):
  File "/Users/nader/Desktop/octo/octopus/octopus/platforms/ETH/cfg.py", line 9, in __new__
    return EvmCFG(bytecode, analysis=evm_analysis)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/cfg.py", line 160, in __init__
    self.run_dynamic_analysis()
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/cfg.py", line 173, in run_dynamic_analysis
    emul.emulate()
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 122, in emulate
    halt = self.emulate_one_instruction(instr, state, depth)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 168, in emulate_one_instruction
    halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 400, in ssa_stack_memory_storage_flow_instruction
    self.emulate(new_state, depth=depth + 1)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 122, in emulate
    halt = self.emulate_one_instruction(instr, state, depth)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 148, in emulate_one_instruction
    self.emul_comparaison_logic_instruction(instr, state)
  File "/Users/nader/Desktop/octo/octopus/octopus/arch/evm/emulator.py", line 261, in emul_comparaison_logic_instruction
    instr.name, args=args)
UnboundLocalError: local variable 'args' referenced before assignment

Anyone knows what might be the exact problem here?
I would gladly work on a fix for this if there is any guidance on how the emulator is working.

If this helps to anyone, in octopus/arch/evm/emulator.py, function emul_comparaison_logic_instruction(self, instr, state), you can put args=None at the start of the code and it will work. I faced the same issue.

Hello, I also have the same problem, but after you put args=None at the beginning of the function according to your answer. Do you have other problems?
I get the following error:
Traceback (most recent call last):
File "W:\pycharm\octopus-master\octopus_eth_evm.py", line 187, in
main()
File "W:\pycharm\octopus-master\octopus_eth_evm.py", line 164, in main
octo_cfg = EthereumCFG(octo_bytecode)
File "W:\pycharm\octopus-master\octopus\platforms\ETH\cfg.py", line 9, in new
return EvmCFG(bytecode, analysis=evm_analysis)
File "W:\pycharm\octopus-master\octopus\arch\evm\cfg.py", line 160, in init
self.run_dynamic_analysis()
File "W:\pycharm\octopus-master\octopus\arch\evm\cfg.py", line 173, in run_dynamic_analysis
emul.emulate()
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
halt = self.emulate_one_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 432, in ssa_stack_memory_storage_flow_instruction
self.emulate(new_state, depth=depth + 1)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
halt = self.emulate_one_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 399, in ssa_stack_memory_storage_flow_instruction
self.emulate(new_state, depth=depth + 1)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
halt = self.emulate_one_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
halt = self.emulate_one_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 352, in ssa_stack_memory_storage_flow_instruction
target = next(filter(lambda element: element.offset == jump_addr, self.instructions))
StopIteration

If this helps to anyone, in octopus/arch/evm/emulator.py, function emul_comparaison_logic_instruction(self, instr, state), you can put args=None at the start of the code and it will work. I faced the same issue.

Hello, I also have the same problem, but after you put args=None at the beginning of the function according to your answer, there are other problems. Do you have other problems?
I get the following error:
Traceback (most recent call last):
  File "W:\pycharm\octopus-master\octopus_eth_evm.py", line 187, in <module>
    main()
  File "W:\pycharm\octopus-master\octopus_eth_evm.py", line 164, in main
    octo_cfg = EthereumCFG(octo_bytecode)
  File "W:\pycharm\octopus-master\octopus\platforms\ETH\cfg.py", line 9, in __new__
    return EvmCFG(bytecode, analysis=evm_analysis)
  File "W:\pycharm\octopus-master\octopus\arch\evm\cfg.py", line 160, in __init__
    self.run_dynamic_analysis()
  File "W:\pycharm\octopus-master\octopus\arch\evm\cfg.py", line 173, in run_dynamic_analysis
    emul.emulate()
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
    halt = self.emulate_one_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
    halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 432, in ssa_stack_memory_storage_flow_instruction
    self.emulate(new_state, depth=depth + 1)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
    halt = self.emulate_one_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
    halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 399, in ssa_stack_memory_storage_flow_instruction
    self.emulate(new_state, depth=depth + 1)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 122, in emulate
    halt = self.emulate_one_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
    halt = self.emulate_one_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 168, in emulate_one_instruction
    halt = self.ssa_stack_memory_storage_flow_instruction(instr, state, depth)
  File "W:\pycharm\octopus-master\octopus\arch\evm\emulator.py", line 352, in ssa_stack_memory_storage_flow_instruction
    target = next(filter(lambda element: element.offset == jump_addr, self.instructions))
StopIteration


Fix the motorSpeed of the Wheel Joint always being set to a value of 1

Issue:
https://github.com/coronalabs/corona/assets/70838508/8b2cc0b4-dc26-49f5-b014-4bd296f5c313
Fixed:
https://github.com/coronalabs/corona/assets/70838508/e76b467e-bd65-404b-a840-6dcfa0e116b1
Code - Test:
local physics = require("physics")
physics.start()
physics.setContinuous(true)

local textWheel = display.newText("Wheel Joint", 100, 50, nil, 20)

local textPivot = display.newText("Pivot Joint", 300, 50, nil, 20)

local wheel1 = display.newRect(100, 220, 30, 30)
physics.addBody(wheel1, "dynamic", { bounce = 0, density = 1 })

local body = display.newRect(100, 150, 30, 30)
physics.addBody(body, "static", { bounce = 0, density = 1 })
body:setFillColor(1, 0, 1)

local ground = display.newRect(display.contentCenterX, display.actualContentHeight, display.actualContentWidth, 100)

physics.addBody(ground, "static", { bounce = 0 })

local wheel2 = display.newRect(300, 220, 30, 30)
physics.addBody(wheel2, "dynamic", { bounce = 0, density = 1 })

local body2 = display.newRect(300, 150, 30, 30)
physics.addBody(body2, "static", { bounce = 0, density = 1 })
body2:setFillColor(1, 0, 1)

local joint = physics.newJoint("wheel", body, wheel1, wheel1.x, wheel1.y, 0, 10)
joint.springFrequency = 15
joint.springDampingRatio = 0.5

joint.isMotorEnabled = true

joint.motorSpeed = 1000
joint.maxMotorTorque = 1000000

local joint2 = physics.newJoint("pivot", body2, wheel2, wheel2.x, wheel2.y)

joint2.isMotorEnabled = true
joint2.motorSpeed = 1000

joint2.maxMotorTorque = 1000000

I had some confusion about runtime.GetFPS.
It's similar to 1 / (physics.GetTimeStep() * physics.GetTimeScale()).
So I reverted the commit 0c869d3.

I think motorSpeed for Wheel Joint  should be radians per seconds, the same as the Revolute Joint.
if ( lua_isnumber( L, 3 ) )
{
	Rtt_Real valueRadians = Rtt_RealDegreesToRadians( luaL_toreal( L, 3 ) );
	joint->SetMotorSpeed( Rtt_RealToFloat( valueRadians ) );
}

Nice job on the fix! I had a PR (#641) suggesting a solution for the axis issue. You can find it here. Glad to see progress on this.

Nice job on the fix! I had a PR (#641) suggesting a solution for the axis issue. Glad to see progress on this.

OK, I'll do some tests on it.
And push a new commit.

Nice job on the fix! I had a PR (#641) suggesting a solution for the axis issue. Glad to see progress on this.

Your solution about the axis is correct when normalizing values to 1 or -1.
I'm also encountering an issue with the axis of the wheel joint; it seems more like a piston force along the axis.
However, this might necessitate changes to the previous project's attributes: springDampingRatio and springFrequency.
We need some opinions from @Shchvova , and it should be in a new pull request.

Nice job on the fix! I had a PR (#641) suggesting a solution for the axis issue. Glad to see progress on this.

Your solution about the axis is correct when normalizing values to 1 or -1.
I'm also encountering an issue with the axis of the wheel joint; it seems more like a piston force along the axis.
However, this might necessitate changes to the previous project's attributes: springDampingRatio and springFrequency.
We need some opinions from @Shchvova , and it should be in a new pull request.

I have added a parameter isNormalizeAxis at the end of the method for creating a wheel joint. This allows normalizing the axis range from -1 to 1 without affecting other projects.
local wheelJoint = physics.newJoint( "wheel", bodyA, bodyB, anchor_x, anchor_y, axisX, axisY, [isNormalizeAxis])


properly return the latest block facts from /explorer

This PR adds LatestBlockFacts(), which uses the explorer's internal block height to get the latest BlockFacts.  Previously, the consensus set's block height was used, which sometimes caused empty block facts to be returned because the explorer's block facts are not always up to date with the latest consensus set.

hmm. Did you observe this error in the wild? The consensus set will hold a lock until all of the modules have the most recent update. I guess it only holds a readlock though, which could cause problems.
Regardless, I have plans so that the consensus set will not block while all the modules process blocks, which should help with performance as you get much better parallelism around I/O bottlenecks and the like.

lol you are changing the PR as I'm writing comments

Latest commit addresses your comments re: one transaction and build.Critical, and updates TestImmediateBlockFacts to use LatestBlockFacts.


Add an option to the LibraryManager to enable caching

In an authoring environment, caching of libraries is undesirable since the content of those libraries is changing frequently. Add library caching as an option in the LibraryManager to allow authoring environments to disable the functionality.

One consideration here is that certain platforms may need to be able to expire the cache externally. For example, if there's a resident global LibraryManager in a HAPI FHIR server, updates to Library resources should expire the LibraryManager cache.
The cql-evaluator and HAPI fhir server implemented this behavior by providing a cache-aware wrapper for the LibraryManager.

Included in 1.5.6 release


[BUG] Small fix - hardcoded FORUM_LINK value points to the wrong URL

Describe the bug
https://github.com/opensearch-project/opensearch-benchmark/blob/main/osbenchmark/__init__.py#L38
FORUM_LINK = https://discuss.opendistrocommunity.dev/
There is a redirect in place for that address, sending users to https://forum.opensearch.org/
To Reproduce
N/A - this is a request to change a hard-coded value
Expected behavior
We should instead link to the correct forum address: https://forum.opensearch.org/
Logs
N/A
More Context (please complete the following information):
N/A
Additional context
N/A

Thanks for opening the issue.  Will follow up,

Looks like this has already been updated


Standard Protocol 0.5V Bug

@sarminh @kasraaskari
Done!
Please double check and if everything is OK then close this issue ;-)


Add mruby 1.4.0 and mruby 1.4.1

Release:

https://github.com/mruby/mruby/releases/tag/1.4.0
https://github.com/mruby/mruby/releases/tag/1.4.1

Announcements:

http://mruby.org/releases/2018/04/27/mruby-1.4.1-released.html

(I searched but there seems to be no release announcement for 1.4.0.)

Thanks!


Show proper errors in submit step of form

We need a proper error message, not what we currently have.

now that we have errors shown suddenly they are too much 😀 I think we have to do some string manipulation here as that red block shown is the actual error.message

I'm not saying that it's a problem with the font/color or whatever but with the fact that we are just dumping the error. It means nothing for the common user, and we need some text wrapping

Guys, any of you have any idea how to replicate this issue? I can't figure out if this has been fixed.

It was not fixed, you can just go in the publish form and change some params to mess it up, then you will get an error

found it. If shows up when you reject the first transaction, but accept the second one.

now, it gets weirder. I don't have 2 transactions anymore. On the "Create Tokens & Pricing" step at the end of publish, it used to make 2 transactions, now makes only one transaction. is that ok @mihaisc ?


UI Redesign

Complete redesign of the UI so it looks more appealing and professional.

To-do: Add a few more themes.

Resolved.


Enforcing proper formatting of descriptions and explanations

Following #330 adding a unit-test for enforcing some basic formatting expectations towards description and explanation of inspections.

Codecov Report

Merging #331 into master will not change coverage by %.
The diff coverage is 13.63%.

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   86.26%   86.26%
=======================================
  Files         135      135
  Lines        1478     1478
  Branches       27       27
=======================================
  Hits         1275     1275
  Misses        203      203

Impacted Files
Coverage Δ

...ons/collections/ExistsSimplifiableToContains.scala
100.00% <ø> (ø)

...pegoat/inspections/collections/FilterDotHead.scala
100.00% <ø> (ø)

.../inspections/collections/FilterDotHeadOption.scala
100.00% <ø> (ø)

...oat/inspections/collections/FilterDotIsEmpty.scala
100.00% <ø> (ø)

...pegoat/inspections/collections/FilterDotSize.scala
100.00% <ø> (ø)

...t/inspections/collections/FilterOptionAndGet.scala
100.00% <ø> (ø)

...ctions/FindAndNotEqualsNoneReplaceWithExists.scala
100.00% <ø> (ø)

...oat/inspections/collections/FindDotIsDefined.scala
100.00% <ø> (ø)

...capegoat/inspections/collections/ReverseFunc.scala
100.00% <ø> (ø)

...t/inspections/collections/ReverseTailReverse.scala
100.00% <ø> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bf324...ede858e. Read the comment docs.

That's a good idea 👍


Editing states for Data Table

Build out the Editing states for Data Table.
Design issues for reference: (internal)

Full edit mode
Inline editing

Hey! Could you add the design specs to the issues themselves?
Inline Editing: #489
Full edit mode: #498

@aagonzales ☝

Oh sorry, just realized that those links weren't box links. Are they just to map the public issues to internal issues?

Do you want me to re-document them here? @bsonefeld @joshblack

No sweat! I went ahead and added a spec link to both issues 😄 Closing as dup.


Support track_scores in Search

Search object currently doesn't have a way to enable tracking scores while sorting.
Ref: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html#_track_scores

This was fixed as part of commit 02e8ee2afd2214027f0542904da34c30e125ed9d pull request #507


UnsatisfiedLinkError without abifilters

When I use your lib as a gradle dependency, it crashes at runtime with UnsatisfiedLinkError:
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file ".../base.apk"],nativeLibraryDirectories=[.../lib/arm64, .../base.apk!/lib/arm64-v8a, /system/lib64, /vendor/lib64]]] couldn't find "librtmp-jni.so"
                                                         at java.lang.Runtime.loadLibrary0(Runtime.java:984)
                                                         at java.lang.System.loadLibrary(System.java:1530)
                                                         at net.butterflytv.rtmp_client.RtmpClient.<clinit>(RtmpClient.java:9)

It's here:
static {
    System.loadLibrary("rtmp-jni");
}

It works when I add abiFilters (tested od Nexus 5X which handles e.g. armeabi-v7a).
defaultConfig {
    ...
    ndk {
        abiFilters "armeabi-v7a", "x86", "armeabi", "mips"
    }
}

But it doesn't make sense to me. Why does adding abifilter change anything? If you understand it, maybe there should be some mention in readme about it.

I think, your app has both armeabi and armeabi-v7a folders or something like that.
All libraries should be under each directory. For instance think that a library has only compiled for armeabi but system is armeabi-v7a and there is an another library which is compiled for armeabi-v7a version. In this scenario there will be unsatisfiedlink error like above


Metadata currently cannot contain a number of characters

For example, commas currently don't work
meta/data/in color: Hello, it's me

This should be fixed for now?


Compiler: always mention the scope (and with ... yield scope, if any) on undefined method error

Fixes #7357
For the code in the issue:
def make_object
  "test"
  puts "This was my error"
end

def doit
	with make_object() yield
end

doit {
  size
}

You now get this error:
Error in baz.cr:11: instantiating 'doit()'

doit {
^~~~

in baz.cr:11: instantiating 'doit()'

doit {
^~~~

in baz.cr:12: undefined local variable or method 'size' for Nil (for `with ... yield`) and top-level (current scope)

  size
  ^~~~

The error now mentions both scopes (in order) where the method was searched.
Additionally, the scope is now always mentioned to make it easy to understand what went wrong. For example, for this code:
hello

Before: undefined local variable or method 'hello'
After: undefined local variable or method 'hello' for top-level
Similarly, for this code:
class Foo
  def foo
    hello
  end
end

Foo.new.foo

Before: undefined local variable or method 'hello'
After: undefined local variable or method 'hello' for Foo
Or...
class Foo
  def self.foo
    hello
  end
end

Foo.foo

Before: undefined local variable or method 'hello'
After: undefined local variable or method 'hello' for Foo.class ("Ooooh... I totally forgot I was in a class method!")

For: undefined local variable or method 'hello' for Foo
We should mention top-level too?

@bew I think at that point it will be too confusing... the top-level is always there. Plus if Foo inherited some other class or included some other modules, should we mention all the hierarchy?
Or maybe yes... but if we go that way, I'd actually like to change all error messages to be more friendly and comprehensive, kind of like what Elm does.

@bew I think at that point it will be too confusing... the top-level is always there. Plus if Foo inherited some other class or included some other modules, should we mention all the hierarchy?

Indeed, let's keep it that way for now.

@asterite is the Int32 in the initial comment an example from a different piece of code? I would expect the error here to reference nil (the result of make_object:
in baz.cr:12: undefined local variable or method 'size' for Nil (for `with ... yield`) and top-level (current scope)

@mpcjanssen Oops, you are right. It actually prints Nil instead of Int32. That was from some other example I had.

I added a second commit to not use colorize in compiler specs because it was making testing the messages a bit tedious and error-prone.


Connect to API & Add CRUD operation

In this milestone, I have completed the following changes:

According to the project requirements:

[ ]  used the Bookstore API as your backend.

[ ] Used axios with createAsyncThunk to make your HTTP requests to the backend

[ ] Fetched the books from the Bookstore API after the component has rendered

[ ] Refactored the add book and remove book features to persist the changes in the server

Hello @Shedrack-Sunday,
Thanks for the approval.
Happy coding🎉🎉🎉🎉


Replace jQuery $().toggleClass by vanilla js classList.toggle in sap.tnt library

Just replacing jQuery .toggleClass by vanilla js classList.toggle in sap.tnt library. Hopefully more people can help tackling other libraries, then other jQuery features, until we don't have jQuery in the code base anymore.
jQuery .toggleClass can be replaced by classList.toggle and it's supported by IE11, not just modern browsers.

https://github.com/SAP/openui5/pull/3442

Hello @,
Thank you for your pull request. I've created an internal record<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,

Thanks for your contribution! The pull request has been merged into the openui5 repository. The change will be included in the UI5 version 1.100.0


Unable to open popup. file not found error

I am trying to create an extension when i create a new project using tempalte and upload to chrome extension after publishing it shows this page

i am trying this from tomorrow but unable to make it work.
i am using manifest v3 and dotnet 7 preview version, In dotnet 6 project it's loading assemblies from framework folder but in dotnet 7 it's trying to load from _framework folder.
can you please upload a working example of extension with popup page. Thanks

I have just tried with the latest version of template, it works fine. Are you using the latest .Net 7 rc1 SDK? If yes, are you able to share a reproducible project with the build output?


pngquant misses the --strip option

pngquant does not always seem to have the --strip option. this breaks the configuration as suggested in the documentation. maybe it would be a good idea to make an annotation in the docs. after removing it from the config, pngquant works.
thanks for your tool!

Have made an extra note about this in the readme for the next release, thanks for letting me know.


can this be used in 2D seg ?

It should be (at least in theory) but I have not tested them.

ok,thanks


Adding aria role to hyperlink cell in slickgrid

Issue: #20632

What does it mean when they said it was previously announced as a "group"? Shouldn't it have been announced as a link?

What does it mean when they said it was previously announced as a "group"? Shouldn't it have been announced as a link?
For some reason, screen readers were reading those cells as group

The focus was not on the link but on the cell div and that's why it was reading it as a group.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.001%) to 41.899%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/table/plugins/hyperlinkColumn.plugin.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts
1
46.46%

extensions/machine-learning/src/common/processService.ts
2
81.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
28657

Relevant Lines:
63510

💛  - Coveralls

So how does this fix it then? Does the cell see the role for the hyperlink and use that then?


Add mention and hashtag classes to hashtag anchors

Related to #541

This fixes hashtag detection in Ivory and Mona.
Elk doesn't work yet because the regex fails to match due to the trailing slash of the URL
Semaphore doesn't use a regex, but checks the suffix of the URL, so fails as well due to the trailing slash

Yeah, I don't think we're going to be able to fix the other clients without gently encouraging them to not require a trailing slash.


part message ???

Not sure if there is a part message available as well as a join message and I'm simply overlooking it. But... if not, you might consider adding a part message as well.
Here's is how I'm thinking that would be useful. I have a voice channel that is listen only that has a bot that plays various content 24/7. The vc-notification bot seems like it would be useful to help members get a sense for who is actually listening to the content. So let's call the channel I post the vc-notifications into "the log channel". If a member looks at the log channel and sees someone comes in once, that tells them something. If they also see they come in every day, that tells them more (ie, the person is active), but a person could just enter and exist the VC every day quickly. But if the log channel shows the person enters, stays for 30 minutes and then parts, it indicates the person is probably sticking around to actually listen to the content. So, without a bot message indicating when someone parts, it's tough for members to tell the difference between the 2nd & 3rd type of person.
Enjoy life!
PS... the link to profile change was really helpful as you can see in the above scenario. Once a member sees someone in the log channel they might want to reach out to, they can now click on their Discord profile, and quickly see if that person also has their Twitter account attached to their Discord profile, and easily click on that, to view the type of tweets they make to decide if this is the type of person that shares their interests, and might be someone they want to reach out to, and can now easily do so.

I deliberately avoided sending notification when people leave, because the frequency of messages is a problem already.

Right on... I understand. Enjoy life!


Use actual config key if available in DSL

Fixes issue where config defined in brooklyn.parameters is resolved as null instead of using the default value, when used inside a transformer.

Failures look related, I can see the same problems as https://builds.apache.org/job/brooklyn-server-pull-requests/1283/org.apache.brooklyn$brooklyn-test-framework/testReport/ when running mvn clean install locally.

@grkvlt thanks for finding and fixing this!
See https://github.com/apache/brooklyn-server/pull/410 - I've extracted your fix for the problem from this PR, and added an additonal test. Happy to merge that as soon as jenkins confirms it works.
For the changes to isAbsentOrNull, see my comments. I believe that is what is making RelativeEntityTestCaseTest fail in jenkins (it fails for me locally as well with your branch, but does not fail with PR #410).

@aledsage your #410 looks good, so I will close this. I had not thought about the semantics of get() vs. getImmediately() and getRaw() etc. but the rationale for just checking for Maybe.absent() seems sound.


Jest Progress bar and live stats not showing up when running in band

🐛 Bug Report
When I run jest, I don't see the green progress bar or any of the live printout data in my terminal.
The Test Suites, Tests, Snapshots, and Time stats are only printed out after all my tests are complete. Until tests are complete, the only indicator I see is:
RUNS path/to/tests

There's no way for me to tell whether the tests have stalled or are still running until the entire suite is complete.
I am running jest with puppeteer for end to end testing.
To Reproduce

Clone the repo here: https://github.com/jeremygottfried/test-jest-cli
Run yarn install
Run yarn test (I set up jest global setup/teardown scripts to handle starting the server)

Test Code
import puppeteer from 'puppeteer';

describe('a basic react app that puppeteer can automate', () => {
  let browser;
  let page;

  beforeAll(async () => {
    browser = await puppeteer.launch({ slowMo: 250 });
    page = await browser.newPage();
  });

  afterAll(async () => {
    await browser.close();
  })

  it('opens the home page', async () => {
    await page.goto('http://localhost:3000');
    expect(await page.url()).toBe('http://localhost:3000/');
  })

  it('has app header', async () => {
    expect(await page.$('.App-header')).not.toBe(null);
  })

  it('has logo', async () => {
    expect(await page.$('img[src="/static/media/logo.5d5d9eef.svg"]')).not.toBe(null);
  })

  it('should have a Learn React link that opens a new page', async () => {
    await page.click('.App-link');
    expect(await page.url()).toBe('https://reactjs.org/')
  })
})

Global Setup Code
import spawnd from 'spawnd';
import cwd from 'cwd';
import http from 'http';

function serverReady() {
  return new Promise(function(resolve) {
    async function checkReady() {
      const req = http.get({
        hostname: 'localhost',
        port: 3000,
        path: '/',
      }, function (res) {
        if (res.statusCode === 200) {
          resolve();
        } else {
          return checkReady();
        }
      });
      req.on('error', function() {
        return checkReady();
      });
    }
    checkReady();
  });
}

export default async function setup() {
  console.log(`\nStarting up react server at port 3000...`);
  const server = spawnd('yarn', ['start'], { shell: true, cwd: cwd() });
  global.server = server;
  await serverReady();
  console.log('\nServer Ready');
}

Expected behavior
I expected my jest tests to show progress bar and live stats printouts like this:

Link to repl or repo (highly encouraged)
https://github.com/jeremygottfried/test-jest-cli
envinfo
  System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 13.6.0 - /usr/local/bin/node
    Yarn: 1.21.1 - /usr/local/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0

$ [[ $- == *i* ]] && echo 'Interactive' || echo 'Not interactive'
# => Interactive
shopt -q login_shell && echo 'Login shell' || echo 'Not login shell'
# => Login shell

@SimenB @jeremygottfried sorry, what and where exactly are you setting to true to see the green bar again? I tried creating a second dummy test suit, but it did not help. Also adding --runInBand didn't help as well, although my understanding is I need it disabled, not enabled.

@makar2 I think I just added a second test file, and --runInBand at the end of the command.

@jeremygottfried hmm, still doesn't work for me. Maybe something else as well?

Hi @makar2 , are you sure it's not a different issue, like a syntax error? Sometimes things fail silently.

@jeremygottfried I am positive, tests are otherwise fine

@SimenB any thoughts?

@jeremygottfried & @makar2 Did you find a solution for this? I also added a second file and the status showed up. My issue is now, that it doesn't count the tests of the file where I have all my async tests like @jeremygottfried.
Could this be caused by using TypeScript and therefore ts-jest and using playwright instead of puppeteer?

This issue still continues. My project is in TypeScript and therefore I use ts-jest preset. Not sure what can I do at this moment.
versions
"jest": "^28.1.0"
"ts-jest": "^28.0.4"
"typescript": "^4.7.2"
I run my tests like this:
jest --coverage --runInBand --config jest.config.js

jest.config.js
/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
module.exports = {
	preset: "ts-jest",
	verbose: true,
	testTimeout: 60000,
	detectOpenHandles: true,
	setupFiles: ["dotenv/config"],
	testMatch: ["**/*.e2e*.ts"],
	testEnvironment: "node",
	transform: {
		"^.+\\.(t|j)sx?$": "@swc/jest",
	},
};

Same here, I need --runInBand because the tests are very time sensitive and the parallel execution mess up things. Still unable to find a way to show the progress bar though (or any kind of progress output) 🙁

I'm having the same problem: #10646

I don't think this can be done without an unacceptable tradeoff I'm afraid. Running in band means there is only one process and no delegated worker processes. The Jest CLI output is controlled by the same Node VM that is also running your test. So even if we show a progress bar it would be very unreliable because the test might be running synchronous code for many seconds straight, during which we can't update the progress bar. The only way to avoid this issue would be... essentially not running in band, but with one worker. But this would destroy the whole point of running in band, which is to conserve resources (worker spawning CPU overhead, and runtime memory overhead), as well as other benefits it has, like easier debugging without subprocesses.

Because I don't see any new points that have come up since Simen's comment here, I'll close this as it's intended as a good tradeoff. But as mentioned we're open to a documentation PR that clarifies and explains this behavior.

 Sorry if this doesn't make sense –my understanding of the internals is still lacklustre after all these years and I get confused about the behaviours/limitations of --runInBand, maxWorkers, maxConcurrency, etc.


Update docs/monthly-meeting/2024-01.md

📚 Documentation preview 📚: https://docs-community--97.org.readthedocs.build/en/97/

@gvanrossum and Carol, I paraphrased a lot of your words for the notes. Would you mind grepping for your name to check I got the gist right?

Is there any other place that would be more appropriate to summarize/capture some of the things that have been discussed in various Discord/Discuss threads and meetings?

discuss.python.org is the best place. Any significant change should be discussed there, rather than only on Docs Discord or meetings.

Thank you!


Notification not receiving after app close

Hello
I am doing VOIP with twillo calling. Application is allow notification while app is background or foreground. we are not received notification while app is close. I have written code in AppDelegate..
But register with Push after socket is connected.

Hi @arvd
Don't worry, it's probably some small detail that we've missed here.

Are you able to get successful result when calling the TwilioVoice.register() method?
Are you able to get call notifications when the app is active?
Can you provide us Call SIDs when the app is unable to respond to the notification if it is terminated? you can find the Call SID from the TVOCall object (on the caller side) or the Call Logs in the Voice Dashboard.

Thanks,
-bobie

Hello Bobie
Yes I am getting successful register Twilio and also get token.
Yes I get notification while all is active and background.
Here is my SID: CR14a04681443dd5dfc564cad97e86cc3f
Thanks,
Arvind

and I am also see Call Logs in Twilio account.. Here I attached screenshot.when app close showing in call logs but notification doesn't appearer.

Hi @arvd
Thanks for providing the Push Credential. We've checked the database with it but things looks perfectly functioning. One more thing you can help us check - (assuming that your app is written with Xcode 9) does your app project have the background mode configured properly in the plist to support audio and voip? you can find more instruction in the quickstart README.
-bobie

Hello Bobie
Yes I am using Xcode 9.2 and my application source code is 2 years old but I am using Xcode 9.2 now.
and yes I have added background and voip setting in plist.

Hi @arvd
How does your app show the incoming call when it gets a call notification while it's in the background? do you use UILocalNotification or do you report the call to the CallKit framework?
If it is not too much trouble, could you also try using the quickstart and see if the same issue is happening? just want to first make sure your account credentials and the notifications settings are correctly configured.
Thanks
-bobie

Hello Bobie
I am using call kit framework.. it was difficult for me to integrating in quickstart demo. Yes credentials are correctly configured.. I received call when background and foreground..

Thanks and no worries @arvd, looks like your credentials are functioning correctly.
To try the (CallKit) quickstart, simply replace a couple of items in the project:

Bundle ID
Access Token URL
then launch the app and register. Closing the app and ensure call notification can still be received and incoming call alert is shown to the user is always one of the validation steps that we perform in every version.

Hi @arvd
Just want to touch base - have you found the root cause that your app is not getting call notification when it is terminated?
-bobie

Hello Bobies,
I am also facing same issue.
In my case i am using quick start demo app, now in this app i have just put single page interface ahead of 'Viewcontroller' for calling automatic to fix userid. i am able to call using that functionality.
But now when i close app and call to that user from another device, i am not getting incoming VOIP call from call-kit(APP is killed not active).
Once i open call and register with VOIP and perform fetch access token. i am able to get same call.
in both case app is in foreground/background.
And another finding, if i run raw quick start app it will works fine. Any quick suggestions so i can fix this.

Hi @ankitpatelka
One suggestion is to try using the quickstart and add the similar UI flow to it, then see at which step the app stops showing incoming calls when it's not in the foreground.

Thanks Bobie it was worked for me, that is issue related Configuration of Callkit (CXProviderConfiguration).

Awesome @ankitpatelka 👍

Hi @ankitpatelka
Can you share how you fixed the issue with the CallKit config? this might be helpful also for other SDK users.
Thanks!
-bobie


Added CalculatePulldownPhasePosteriors.

Also:
-Created AllelicCount package and added AllelicCountWithPhasePosteriors.
-Standardized CLI summaries, fixed Titan conversion, miscellaneous boy scout activities.
Closes #527.
Closes #559.

@mbabadi, can you review?  we agreed in standup that @davidbenjamin could use a break.

@mbabadi, can you review this before it gets too stale?  Looks like @davidbenjamin might have touched some overlapping code in #596.  If it's not too much trouble, would be great if he could rebase on this PR before I review his.

@samuelklee While rebasing my HMM PR off your branch I first rebased your branch off master.  I have pushed it as sl_pulldown_phase_posteriors_COPY if you wish to save a few minutes of rebasing.

@samuelklee Back to you.  You will make short work of these comments.

need to check that all tests still pass, but made most of the changes and commented on the rest.  thanks, @davidbenjamin, back to you!

@samuelklee You can squash and merge once tests pass.


_final isn't always called

Hello.
With this program :
class Foo
  fun _final() =>
    let out = "Foo\n"
    @fwrite[U64](out.cstring(), U64(1), out.size(), @os_stdout[Pointer[U8]]())

primitive Bar
  fun _final() =>
    let out = "Bar\n"
    @fwrite[U64](out.cstring(), U64(1), out.size(), @os_stdout[Pointer[U8]]())

actor Main
  new create(env: Env) =>
    let foo = Foo
    let bar = Bar

  fun _final() =>
    let out = "Main\n"
    @fwrite[U64](out.cstring(), U64(1), out.size(), @os_stdout[Pointer[U8]]())

The _final function is called about half of the time for the Main actor and the Foo class. However, it is always called for the Bar primitive.

Thanks for the report! Yup, this is definitely a bug.

After some more tests, I have observed two things:

The bug seems to occur in sequences. I get the normal behavior several times in a row, then the bug several times in a row.
If you call behaviors on the actor, the frequency of the bug is reduced. With the following program, _final is called almost all the time.

actor Main
  new create(env: Env) =>
    f()
    f()
    f()
    f()
    f()
    f()
    f()
    f()
    f()
    f()

  be f() => None

  fun _final() =>
    let out = "Main\n"
    @fwrite[U64](out.cstring(), U64(1), out.size(), @os_stdout[Pointer[U8]]())

More data regarding runtime options:

--ponythreads low => bug more frequent
It seems that with --ponythreads=1, the bug occurs all the time, unless behaviors are called on the actor.
--ponygcinitial low => bug less frequent
Interesting thing: with ponythreads=1 --ponygcinitial=0, the bug never occurs, unless behaviors are called on the actor.

Thanks @Praetonus , the extra data put me on to the core problem. It should be fixed now. If not, please reopen :)


Notebook for multiome cell type reannotation and streamlining of environment.yaml

looks good! could you please update readme accordingly as well?

I updated the README to include a short description of the multimodal notebook.
I also added mudata and muon to the environment.yaml and removed a bunch of unnecessary package installs. (I've confirmed that the remaining package are the only ones imported by any of the Python notebooks in the repo.)


Add missing dependency to run spec separately

Without this file, the following error has thrown:
$ bundle exec rspec spec/react_on_rails/generators/generator_messages_spec.rb
An error occurred while loading ./spec/react_on_rails/generators/generator_messages_spec.rb.
Failure/Error:
  describe GeneratorMessages do
    it "has an empty messages array" do
      expect(GeneratorMessages.messages).to be_empty
    end

    it "has a method that can add errors" do
      GeneratorMessages.add_error "Test error"
      expect(GeneratorMessages.messages)
        .to match_array([GeneratorMessages.format_error("Test error")])
    end

NameError:
  uninitialized constant GeneratorMessages
# ./spec/react_on_rails/generators/generator_messages_spec.rb:5:in `<top (required)>'
No examples found.

Finished in 0.00026 seconds (files took 0.12917 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

This change is

@robwise are you OK with this one? I really don't understand this change, given that tests were passing. Maybe without this fix, we can't run tests outside of the rake tasks. Any more info @tricknotes?

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

I think what this is, is if you run the test quoted above individually (as opposed to as part of a suite), it fails because it has a dependency that loads when run as part of a suite, but not when run individually. Then this PR makes that dependency explicit?

Thanks, @robwise !
It is completely what I want to say.

@tricknotes Can you please add an entry to the CHANGELOG.md and I'll merge.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Thanks for your review, @justin808
I added an entry to the CHANGELOG.md and updated this PR.

Thanks @tricknotes! Merged!


Error using python3 UVR.py

Someone help me please im going crazy i dont know what im doing its been hours someone has to save my sanity. Ive been trying to install UVR v5 on my chromebook using Linux ubuntu for like hours bur as soon as i run python3 UVR.py to launch it (i think?) i get this:
python3 UVR.py
playsound is relying on another python subprocess. Please use `pip install pygobject` if you want playsound to run more efficiently.
Traceback (most recent call last):
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/__init__.py", line 336, in __getattr__
    return getattr(self._module, name)
AttributeError: 'NoneType' object has no attribute 'add_file'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/domnickilana14/ultimatevocalremovergui-master/ultimatevocalremovergui-master/UVR.py", line 7257, in <module>
    root = MainWindow()
  File "/home/domnickilana14/ultimatevocalremovergui-master/ultimatevocalremovergui-master/UVR.py", line 1291, in __init__
    self.set_app_font()
  File "/home/domnickilana14/ultimatevocalremovergui-master/ultimatevocalremovergui-master/UVR.py", line 1559, in set_app_font
    pyglet_font.add_file(FONT_MAPPER[MAIN_FONT_NAME])
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/__init__.py", line 342, in __getattr__
    __import__(import_name)
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/font/__init__.py", line 80, in <module>
    from pyglet.font.freetype import FreeTypeFont
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/font/freetype.py", line 41, in <module>
    from pyglet.font import base
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/font/base.py", line 45, in <module>
    from pyglet.gl import *
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/gl/__init__.py", line 95, in <module>
    from pyglet.gl.gl import *
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/gl/gl.py", line 45, in <module>
    from pyglet.gl.lib import link_GL as _link_function
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/gl/lib.py", line 149, in <module>
    from pyglet.gl.lib_glx import link_GL, link_GLU, link_GLX
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/gl/lib_glx.py", line 46, in <module>
    glu_lib = pyglet.lib.load_library('GLU')
  File "/home/domnickilana14/.local/lib/python3.9/site-packages/pyglet/lib.py", line 164, in load_library
    raise ImportError('Library "%s" not found.' % names[0])
ImportError: Library "GLU" not found.

and ive been scrolling through issues for so long and googling and trying different stuff im about to give up but itd be a waste after using so much time on it SOMEONE PLS HELP ILL BE FOREVER GRATEFUL thx

Seems like you have Python 3.9 installed. AFAIK you'll need to upgrade to Python 3.11 for UVR5.
Have a look here: https://www.linuxcapable.com/how-to-install-python-3-11-on-ubuntu-linux/
HTH

thanks for the help, i tried around a bit but still get errors. ive made sure to install the required packages before trying to install python 3.11 and also ran sudo apt update afterwards but i still get this error
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)). gpg: no valid OpenPGP data found.

Seems like you have Python 3.9 installed. AFAIK you'll need to upgrade to Python 3.11 for UVR5. Have a look here: https://www.linuxcapable.com/how-to-install-python-3-11-on-ubuntu-linux/ HTH

i tried installing UVR with python 3.11 and no dice. somebody had a screenshot of it running in a VM on linux with 3.10.12
anyway, it's foolhardy to mess with the system python version since any number of programs may need different versions. the only way to do it properly is with a virtual environment. if UVR can't be run in a virtual environment then the dev needs to remove the word linux from the main page. at any rate it looks like the total number of linux users are vanishingly small. a lot of these new amazing a.i. things are already turning to vaporware and they just came out. that's how fast the tech is going, or how fickle it is. shudder to think what would happen if pypy/pip just wafted away like a fart, or if huggingface sold to adobe for subscribers only...


Update kustomize

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Description

Remove unused cdn and scheduler service in kustomize
Support containerd v1.5.0+ in kustomize

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #403 (30e012f) into main (5814497) will increase coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Current head 30e012f differs from pull request most recent head 3d35407. Consider uploading reports for the commit 3d35407 to get more accurate results

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   38.50%   38.58%   +0.08%
==========================================
  Files          81       80       -1
  Lines        6207     6204       -3
==========================================
+ Hits         2390     2394       +4
+ Misses       3481     3472       -9
- Partials      336      338       +2

Flag
Coverage Δ

unittests
38.58% <ø> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/util/net/iputils/ip_utils.go
61.22% <0.00%> (-4.09%)
:arrow_down:

client/daemon/peerhost_stub.go

client/daemon/peer/peertask_stream.go
58.11% <0.00%> (+2.26%)
:arrow_up:


Push Notifications Production iOS

Great Package! I have been throughly enjoying the capabilities that this package offers. Unfortunately I have been having problems getting push notifications to work since attempting to submit my iOS meteor-cordova app through TestFlight. I found out here http://stackoverflow.com/questions/24044298/why-push-notifications-is-not-working-on-testflight that I need production certificates in order to successfully use push notifications in test flight. Therefore I repeated the process with new production specific certificates. I checked the connection from the terminal with the new production  certificates and received:

I then set production:true and did the appropriate placing and labeling of files  under "apn".
 {
"apn": {
    "passphrase": "foo",
    "key": "ProductionKey.pem",
    "cert": "Profuction.pem"
},
"apn-dev": {
    "passphrase": "foo",
    "key": "PushChatKey.pem",
    "cert": "PushChatCert.pem"
},
"production": true

}
On launch of the app everything seems to go fine:

However when I attempt to send a push notification in production mode. I get  the following error:

Any idea why production mode won't be working. I have gotten push notification to work when production:false but I can't seem to make it work for production:true.

You need to use the matching provisioning profile - your server setup looks ok

So place the Distribution Provisioning Profile Certificate in the Private Folder as well?

@nspangler No, you need a provisioning profile for iOS production, and sign your package with that profile (not the bundle name one like you can use for testing).  Hope this makes sense.

@dennisharrison thanks for the response. I do have a provisioning profile for iOS production for my app but how do I sign my package with that profile?

@nspangler I'm not in front of a machine with xCode on it so I can't give you an exact screenshot.  But it's under build settings I believe: Provisioning Profile.  That needs to be set to the one that you have iOS Production for.

@dennisharrison thanks, I know how to do that. Why would that have any effect on the server crashing though?

@nspangler This is a provisioning profile issue I'm 90% sure.
I've had the same error before.  The certificate chain isn't correct for sending push from your app to the production APN gateways.  That's the error you're seeing.

@nspangler The problem is that the server tries to send to a test device via production certificates - so that's not normal behavior and should be prompted.
Maybe we should add a try/catch and present a nicer error message?
Eg.:
  try {
    // Sending an apn message
  } catch(err) {
    if (/wrong environment/.test(err.message) {
     console.warn('You may be using the .... ');
    } else {
      throw err;
    }
  }

@raix I think that would be helpful.
@dennisharrison I have tried creating new provisioning profiles with distribution capabilities and still no luck. Have you been able to successfully use this package with test-flight?

@raix and @dennisharrison still working on trying to figure out this problem. Is a Website Push Id needed to use to package? And if so how do I implement it into the package?

@raix and @dennisharrison thanks for all of the help. I re-created all of my certificates and pushed an new version to my server and everything works. The provisioning profile aspect was a big help as well.


Browser field should alias to a relative file.

This was breaking webpack builds because it was trying to load
a module called 'stream.js' instead of the file.

Released in 1.3.2

Thanks Mathias for merging it!
Il giorno gio 15 gen 2015 alle 02:30 Mathias Buus<EMAIL_ADDRESS>ha scritto:

Released in 1.3.2
—
Reply to this email directly or view it on GitHub
https://github.com/maxogden/websocket-stream/pull/59#issuecomment-70030857
.

Thanks Adrian for sending the PR! It was working fine in Browserify!
Il giorno gio 15 gen 2015 alle 08:03 Matteo Collina <
<EMAIL_ADDRESS>ha scritto:

Thanks Mathias for merging it!
Il giorno gio 15 gen 2015 alle 02:30 Mathias Buus <
<EMAIL_ADDRESS>ha scritto:
Released in 1.3.2

—
Reply to this email directly or view it on GitHub
https://github.com/maxogden/websocket-stream/pull/59#issuecomment-70030857
.


Fix some typos and redaction

Hello, I was going through your documentation and found some typos in the 101 section.

Thanks a lot !


Authorization token

(1) The website didn't tell us how to use authorization token. (Spoiler: add the following request header "authorization: Bearer <JWT>")
(2) When I am poking at authorization header, it returned the following error message

{"msg":"Bad Authorization header. Expected value 'Bearer <JWT>'"}

It just spits out the token needed to add an order, this is definitely a bug right?
(3) How am I suppose to do with the token generated by "/auth"? Looks like the token is useless.

The website is a swagger template generated. Though, It is a norm to use JWT as you stated.
You should go through the source files. The response is handled by the flask-jwt-extended package.
I think you did not go through the repository. The README.md file states that the token should be used while generating an order.

However, for clarity, I can update the README file.


Constantly crashing after pinning drive

Description
So I was trying out the app for the first time and was fiddling around and testing stuff.
Then when I tried pinning a network drive to the sidebar the app just crashed.
After this the app just crashes every time I try to launch it.
Steps To Reproduce

Try to pin a (network) drive to the sidebar.
App crashes.
From now on the app crashes whenever you try to open it.

Expected behavior
Does not crash, or at least not
Files Version
1.5
Windows Version
Windows 10 21H1 19043.1165
Relevant Assets
debug.txt
debug_fulltrust.txt

Thanks for the feedback. As a workaround, can you please try resetting the app (Windows settings -> apps -> Files -> reset) and see if that helps?

Yeah, resetting worked.

Glad the issue is solved. Closing as I cound not reproduce the issue in the preview  version of Files.


Add Gram baseline

Implementation of Gram baseline from "Detecting Out-of-Distribution Examples with Gram Matrices" link
While implementing this class, we added a new feature to the FeatureExtractor class, which is the ability to preprocess feature maps on the fly, batch-wise, and to directly return processed features as output of .predict_tensor(). This is crucial for this method since the computations performed on feature maps are quite intensive and would lead to OOM if not applied batch-wise.
This feature will be useful for other baselines, e.g. DKNN or mahalanobis (or the planned NMD) to be able to process internal feature maps. In that case, the postproc_fn could be some pooling + flatten.
Important Disclaimer: Taking the statistics of min/max deviation,
as in the paper raises some problems.
The method often yields a score of zero for some tasks. This is expected since the min/max among the samples of a random variable becomes more and more extreme with the sample size. As a result, computing the min/max over the training set is likely to produce min/max values that are so extreme that none of the in distribution correlations of
the validation set goes beyond these threshold. The worst is that a significant part of ood data does not exceed the thresholds either. This can be alleviated by computing the min/max over a limited number of sample. However, it is counter-intuitive and, in our opinion, not desirable: adding some more information should only improve a method.
Hence, we decided to replace the min/max by the q / 1-q quantile, with q a new parameter of the method. Specifically, instead of the deviation as defined in eq. 3 of the paper, we use the definition

With this new deviation, the more points we add, the more accurate the quantile becomes. In addition, the method can be made more or less discriminative by toggling the value of q.
Finally, we found that this approach improved the performance of the baseline in our experiments.

LGTM


[GOBBLIN-1516] Only schedule TaskMetricsUpdateder when metric-reporting is enabled by config

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
https://issues.apache.org/jira/browse/GOBBLIN-1516
Description
This PR contains two parts:

Rename Optional<ScheduledThreadPoolExecutor> writerMetricsUpdater to be writerMetricsUpdateExecutor which is more accurate. The original name collide with WriterMetricsUpdater class which is the actual Runnable to be scheduled.
Within registerNewTask, only schedule the TaskMetricsUpdater if metrics.enabled is true. The TaskMetricsUpdater holds a reference to Task object and TaskMetricsUpdater is only terminated/removed after commit. As a result, when there are a large number of tasks being executed, all of them will only be GC'ed after commit phase. This is particularly not friendly to AsyncDataWriter when there are data being buffer until commit. For such application, we might consider disable the writer metric reporting to exchange for more efficient heap usage.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@sv2000 @ZihanLi58   Can you take a look ? Thanks.

Codecov Report

Merging #3365 (da48069) into master (ba89b2b) will decrease coverage by 3.49%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #3365      +/-   ##
============================================
- Coverage     46.52%   43.02%   -3.50%
+ Complexity    10146     1945    -8201
============================================
  Files          2055      394    -1661
  Lines         79893    16900   -62993
  Branches       8910     2082    -6828
============================================
- Hits          37172     7272   -29900
+ Misses        39276     8824   -30452
+ Partials       3445      804    -2641

Impacted Files
Coverage Δ

.../gobblin/cluster/GobblinHelixTaskStateTracker.java
62.50% <50.00%> (-2.02%)
:arrow_down:

...a/org/apache/gobblin/cluster/GobblinHelixTask.java
60.21% <0.00%> (-2.16%)
:arrow_down:

...n/runtime/std/DefaultJobLifecycleListenerImpl.java

.../gobblin/util/limiter/RestClientRequestSender.java

...org/apache/gobblin/azkaban/AzkabanJobLauncher.java

...ement/copy/TimeAwareCopyableGlobDatasetFinder.java

...ache/gobblin/kafka/client/KafkaConsumerRecord.java

...pache/gobblin/configuration/ConfigurationKeys.java

...bblin/metrics/context/filter/AllContextFilter.java

...ment/retention/profile/SnapshotDatasetProfile.java

... and 1653 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba89b2b...da48069. Read the comment docs.


Actionable item height

slight modification to the actionable item for it to be the same height as SingleSelect and Button
also the dots were black and need to be blue

Codecov Report

Merging #939 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   99.76%   99.76%
=======================================
  Files         286      286
  Lines        7260     7260
  Branches     1772     1772
=======================================
  Hits         7243     7243
  Misses         17       17

Impacted Files
Coverage Δ

src/components/actionable-item/ActionableItem.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af32b3d...0360cf8. Read the comment docs.


Update pre-commit CI

Covered in #252. (https://github.com/seoklab/nurikit/commit/672c6bf809e7ad13afd40d5501788c7e30da25fb)


delete @tmp directory in workspace

Since 75ea3fe05 a @tmp directoy is created in the workspace but not cleaned up.
We need to clean this up for buildsystems hashing the workspace to find
binary artefacts.

Thanks for the pull request.  Can you further describe the problem you're seeing?
The code in 75ea3fe05650fc6ca09046a72493e2b3f066fb98 is intended to create the temporary directory in the same parent directory as the workspace.  It is not intended to create the temporary directory in the workspace itself.
Are you seeing a directory named '@Tmp' in the workspace directory?  If so, then the logic which is being used to create that temporary directory needs to be changed.  If the workspace directory name is '/var/lib/jenkins/workspace/my-job' then the temporary directory should be named
'/var/lib/jenkins/workspace/my-job@Tmp', not '/var/lib/jenkins/workspace/my-job/@Tmp'.
If the temporary directory is not placed in the correct parent directory, let's fix that problem, rather than attempting to delete a known temporary directory that is often used by other parts of the system.

We're using the Checkout to subdirectory option to checkout one ore more repo into the same workspace. So before 75ea3fe the workspace content was:
/var/lib/jenkins/workspace/my-job/foo
/var/lib/jenkins/workspace/my-job/bar

but now it's
/var/lib/jenkins/workspace/my-job/foo
/var/lib/jenkins/workspace/my-job/foo@tmp
/var/lib/jenkins/workspace/my-job/bar
/var/lib/jenkins/workspace/my-job/bar@tmp

Now our buildtool hashes the workspace to calculate a buildID which afterwards is used to download binary artifacts already build by jenkins. As we do not have the @tmp for local builds binary artifacts are not working any more.
If I got you right the @tmp  should be next to the workspace? So even with Checkout to subdirectory option the workspace should look like:
/var/lib/jenkins/workspace/my-job/foo
/var/lib/jenkins/workspace/my-job/bar
/var/lib/jenkins/workspace/my-job@tmp

? This would also work as we only hash /var/lib/jenkins/workspace/my-job/. I'll try to update the PR soon..

Thanks for the clarification.  Yes, that says that the temporary directory is being created inside the Jenkins workspace if checkout to subdirectory is used.
I suspect the same behavior happens if you use a Pipeline and perform the checkout inside a `dir('xxx') { }' block.  It is the incorrect behavior there as well.
I also suspect that there is a standard Jenkins function somewhere which should be called to get the temporary folder associated with the workspace of the current Jenkins job.

AFAICS the workspace used by the git-client-plugin is computed by the plugin using the git-client-plugin? So in the git-client-plugin it's not possible to know if the checkout is done using the job's workspace or a subdirectory?
The git-client-plugin itself has no possibility to get the jobs workspace using the JenkinsAPI as it do not have the AbstractBuild object. My only idea is to use the WORKSPACE environment variable. And I haven't found a Jenkins function to get a temporary folder.

I created an automated test case to verify the problem.  I believe the test case is correct.  The test case performs parallel checkouts of three repositories into subdirectories of the current workspace while a "monitor' is watching for the unexpected existence of the temporary directories inside the workspace.  It finds those temporary directories in most executions, even with the 131ms sleep between checks
When I install a build of the plugin with this proposed change, it still fails that test.
It could be that the automated test is wrong, or it could be that there is some reason that the changes you're proposing are not having the expected result in my environment.
Could you investigate further to see if you can duplicate the types of failures that I'm seeing in my job?

Closing for now, included in the "Later" milestone so that it can be reconsidered in the future.

Why this issues is closed? The problem still exists.

It was closed and assigned the label Later so that it can be reopened in the future when I have time to review the pull request.  You are welcome (and encouraged) to apply the changes to a private copy of the plugin and use it.  Then you can report the results of your use to this pull request so that I and the other maintainers are aware of your results.

I tried to reproduce the issues described in https://github.com/jenkinsci/git-client-plugin/pull/353#issuecomment-431596471 but were not able to run the Jenkinsfile on my jenkins. I don't know where the globalPipelineLibraryMarkEWaite came from and also other thinks like https://github.com/MarkEWaite/jenkins-bugs/blob/1b55bc67aae0925c921bfc0c8ddef8c46b4835c0/Jenkinsfile#L28 are looking somehow strange. That's why I gave up as it was working with my own copy of this plugin.
@MarkEWaite  Maybe you can bring in some light to this enabling me to reproduce the issues on my system and to follow up on this topic?

Sure!
My Jenkins test setup is composed of:

Public docker image lts-with-plugins branch that defines the Jenkins installation including plugins, pipeline shared libraries, folders, etc.  That image defines globalPipelineLibraryMarkEWaite.  The image can be built with the command ./docker_build.py from that repository.  It can be run with the command ./docker_run.py --clean
Private docker image lts-with-plugins-add-credentials-and-nodes branch that defines agents, credentials, more jobs, and other private information based on the contents of the public docker image and its lts-with-plugins branch
Public Jenkins bugs repository branch JENKINS-47874 that attempts to explore the problem.  It relies on the public Docker image contents to create a branch for each bug that the repository is testing

Tanks! The reason for the failing test after installing the git-client-plugin with the suggested fix is another plugin called durable-task-plugin. This gets involved when using pipelines which is the reason I have not seen this before. As there might be other plugins creating the same @tmp directory and I'm not motivated to fix them all we'll update our tool to just ignore them.


Provides a way to set the "stable" version manually

This issue comes from https://github.com/rtfd/readthedocs.org/issues/3268#issuecomment-345310676
I think it could be a good nice to have, so I'm opening this issue so we can discuss here if it would be better or it could be more confusing at the end.
Besides, how it should be implemented in the UI; I image it

in the "Admin -> Versions" page a stable title with an input and a description "Leave it blank to use the RTD default logic to determine the stable version")
as a setting somewhere in the yaml file

@humitos @ericholscher, I would like to take up this issue. For UI part we can give a ChoiceField, so that there is also no validation issue. What do you say?
And in yaml file, we can give a stable_version:version_name

+1 for this feature, my build is failing because stable is not able figure out the latest tagged release

Isn't the way to do this to just create your own branch named "stable" and use that?

@ericholscher I thought rtd will automatically pick up the latest release tag as stable version?

It should, but this ticket is about specifying it manually. If there is a bug in our version resolution, that is a separate issue.

@ericholscher that would be my #3714

RTD allow overriding the stable version by creating a branch or tag named stable (it's a little buggy right now #3913), isn't that what we want?

Not sure if this is something we can put on our yaml, per-version settings only. This looks like a project setting.

I feel like the answer here should be "If you want a custom stable version, create either a tag or branch in your project with that name." Do we want to apply the same logic to latest as well? If so, we should likely document this, and then make sure the code works that way :)

Currently, users can specify a custom latest on the web admin, I think the major feature here is that user's don't want to maintain 2 branches/tags, say they want my-stable be just stable.

This can be closed in favor of https://github.com/rtfd/readthedocs.org/issues/5319, but we could still document that people can create a version named latest or stable

Yes. The only actionable thing missing from this issue is the documentation part https://github.com/rtfd/readthedocs.org/issues/3279#issuecomment-435141663

I will work on it.


conda run not used in subsequent tox runs

Version 0.8 has introduced that commands are run with conda run which is a nice improvement. However, I realized that this only happens while the conda environment is created. On subsequent tox runs when the already created environment is used, this is not anymore the case.
I created a patch which uses the tox_runtest_pre hook. How can I present this patch for review? Do you work with forks or directly with feature branches in this repository?

This is not the expected behavior, all the commands shall run in a anaconda environment, this is tested here.
Could you please explain a bit more what happens?

Yes, the command execution is tested there but only while the conda environment is created and the hook for tox_testenv_create is executed which sets the CondaRunWrapper. However, when the conda environment is already created and tox reuses it in a subsequent run, tox_testenv_create is not executed and CondaRunWrapper is not set.
You can test this by executing tox twice in the linked test by adding the same lines again, namely
result = cmd("-v", "-e", env_name)
result.assert_success()

for filename in ("commands_pre", "commands_post", "commands"):
    assert open(filename).read().endswith(env_name)

The first assertion succeeds, the second one fails then.

@fknuth Thanks for letting us know, you may give a try to the version 0.8.1 which has a fix for this.

@AntoineD Thank you very much for the quick fix and release. It is working as expected now.


Create an use case to list all topics

hey @matheusmosca, can I take this issue?

https://github.com/matheusmosca/walrus/pull/23


eslint config: "@typescript-eslint/no-floating-promises": 2

Thoughts on adding this rule?

This rule forbids usage of Promise-like values in statements without handling their errors appropriately. Unhandled promises can cause several issues, such as improperly sequenced operations, ignored Promise rejections and more. Valid ways of handling a Promise-valued statement include awaiting, returning, and either calling .then() with two arguments or .catch() with one argument.

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

While you're updating the eslint rules you may want to take a look at the current warns and determine if any of those rules should be disabled or have options configured. For instance, I know the following code will fail:
// unused variable a
function log(a: unknown, b: string) {
  console.log(b);
}

In this case we might want this to fail, but it may also be implementing some interface but just doesn't care about the first argument?

Done in #1780 :slightly_smiling_face:


show warning at database change when doing pull

when columns are removed
when column data type is changed

in both cases it is possible to loose data from the table

One of the few occasions when a resumeable exception could really make sense

Pull request #458


dApp - extend end-to-end tests to verify service worker detects cache corruption

Description
Follow up of #2837
The issue in #2869 was that I wasn't able to do it. To not block the work, I decided to split it and wait for @taleldayekh his help. I'm not familiar enough with Cypress its asynchronous functionality which is quite awkward. Though I added the test instructions to the very end of the scenario, it run them right at start. This makes the whole tests not work as this manipulates the cache...
Acceptance criteria

Tasks

[ ]

I now understood how it works. 😬
I think a custom task should do the job here...


Filesize

Very large data return from GLTFLoader.
The model size is just 5-6Mb .... but the GLTFLoader loaded data is 324Mb.

Well, I was already in doubt if this is an good idea to parse the model at the backend and send it as json to the frontend. This might be ok for very small models.
Take the "LittlestTokyo.glb" example: the data is not only in gltf format, but also DRACO compressed, a highly efficient compression method for 3D models. The whole idea is to keep the data load as low as possible.
In your approach, you parse the model in the backend, turning the compressed data into uncompressed data, sending the uncompressed data to the client without any benefits of compressed data.
You can try to compress the json file, but it will reduce the size only a little, I guess.
If you don't want to expose the original glb file, another approach would be to load the glb file at the backend just as a buffer and send this buffer as base64 encoded string, at the frontend decode the base64 string and parse the model with GLTFLoader.

You are right. Uncompressed data is sometimes up to 1 GB, which may break the backend process.


[BUG] @Returns with non-200 status is not documented in swagger since 5.36.0

Information

Version: 5.60.2 although I believe it affects all versions above 5.36.0
Packages: @tsed/common @tsed/core @tsed/di @tsed/platform-express @tsed/swagger body-parser compression cookie-parser express method-override

A few sentences describing the overall goals of the issue.
I believe this affects all versions of tsed created after 5.36.0. I'm not sure what commit specifically broke it though.
Essentially, if you try to use @Returns or @ReturnType with a non-200 status code (or non-200/non-400 status code if you have required params), then the status codes are non documented in swagger.
Example
Pull each of these, run npm i then run tsc and node dist/index.js then visit /api-docs to see what I mean. The controller method is in controllers/Example.ts

Working: Here is an example of 5.36.0 where @Returns() works with non-200 status codes: https://github.com/Pokemonjpups/working-tsed
Broken: Here is an example of 5.60.2 where using non-200 status codes causes the statuses to not be documented in swagger: https://github.com/Pokemonjpups/broken-tsed

Acceptance criteria

[ ] All non-200 status codes should show up in swagger docs when documented with @Returns (from @tsed/swagger) or @ReturnType (from @tsed/common)

Hello @Pokemonjpups
Thanks for the detailed issue :) and my apologize for the regression :/
I added complementary integration test to not reproduce this problem in future!
The release is on going ;)
See you
Romain

:tada: This issue has been resolved in version 5.60.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

For anyone running into this (I was having the same issue on 5.60.2), upgrading to 5.60.4 doesn't actually build correctly. It
I skipped ahead to 5.60.7 and it worked 👍


Crash when exporting the DP app

I've followed the guide and i setted up steelminer, homebrews works as normal but this tool not it crashes whe i try to dump the Download Play app.

O3DS EUR 11.8

Issues aren't really for tech support. Feel free to join this discord and they'll be able to help you out
https://discordapp.com/invite/C29hYvh


Use git rev-list to resolve commit tag refers to

rev-parse will give you the hash of the tag object itself. This worked but all the following git commands we sent this commit to had to resolve the tag object reference hash to a commit hash each time.

I noticed that the hashes the script used didn't match up with the hashes I saw when looking at the release tags in github.
Googling led me to stackoverflow (I am not surprised )
https://stackoverflow.com/questions/1862423/how-to-tell-which-commit-a-tag-points-to-in-git


test: init1.go fails on windows

Windows builders fail http://build.golang.org/log/a9f9574733a3ffdfc038d4c65e56daf003b7a142 with
##### ..\test
# go run run.go -- init1.go
exit status 1
allocated 1000 chunks of 1048576 and used  636481536 memory
panic: init1

goroutine 1 [running]:
main.init·1()
	C:/workdir/go/test/init1.go:36 +0x311
main.init()
	C:/workdir/go/test/init1.go:45 +0x44
exit status 2

FAIL	init1.go	3.399s

I cannot reproduce this failure here.
Alex

These started happening regularly as of @randall77's 6dd31660b054 (don't put container symbols in functab) but if I scroll back in the builder history to the previous page, I do see one of the same failure (on the dev.cc branch) earlier.

test1.go is "Test that goroutines and garbage collection run during init" and the code is simply:
var x []byte

func init() {
        c := make(chan int)
        go send(c)
        <-c

        const chunk = 1 << 20
        memstats := new(runtime.MemStats)
        runtime.ReadMemStats(memstats)
        sys := memstats.Sys
        b := make([]byte, chunk)
        for i := range b {
                b[i] = byte(i%10 + '0')
        }
        s := string(b)
        for i := 0; i < 1000; i++ {
                x = []byte(s)
        }
        runtime.ReadMemStats(memstats)
        sys1 := memstats.Sys
        if sys1-sys > chunk*500 {
                println("allocated 1000 chunks of", chunk, "and used ", sys1-sys, "memory")
                panic("init1")
        }
}

func send(c chan int) {
        c <- 1
}

func main() {
}

If something changed with GC or ReadMemStats or 32-bit, I would expect to see other builders failing. And if it was Windows in general, I'd expect to see windows-amd64 also failing.
It's weird that this is only windows-386.

/cc @RLH @aclements for ideas.

windows-amd64 fails too http://build.golang.org/log/976ca6838b8f68e84e2aedfc6fe90d4d450f7f36 . Not as ofthen as windows-386.
Alex

Looks like the test is broken. If I allocate 1000 1Meg objects and use less
that 1 Gig then the GC ran.
On Thu, Feb 12, 2015 at 5:41 PM, alexbrainman<EMAIL_ADDRESS>wrote:

windows-amd64 fails too
http://build.golang.org/log/976ca6838b8f68e84e2aedfc6fe90d4d450f7f36 .
Not as ofthen as windows-386.
Alex
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9848#issuecomment-74169251.

True.
But at least on my laptop (OS X), I see this test at tip only retain up to 176 MB:
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  171728896 memory
[log] allocated 1000 chunks of 1048576 and used  167268352 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  182882304 memory
[log] allocated 1000 chunks of 1048576 and used  171728896 memory
[log] allocated 1000 chunks of 1048576 and used  177303552 memory
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  178421760 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  168382464 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  170614784 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  156119040 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  151658496 memory
[log] allocated 1000 chunks of 1048576 and used  173961216 memory
[log] allocated 1000 chunks of 1048576 and used  159461376 memory
[log] allocated 1000 chunks of 1048576 and used  166154240 memory
[log] allocated 1000 chunks of 1048576 and used  166154240 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  151658496 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  165040128 memory
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  168382464 memory
[log] allocated 1000 chunks of 1048576 and used  165040128 memory
[log] allocated 1000 chunks of 1048576 and used  157233152 memory
[log] allocated 1000 chunks of 1048576 and used  173961216 memory
[log] allocated 1000 chunks of 1048576 and used  169500672 memory

Why is Windows retaining so much more?  (636481536)
And why can't I make my laptop have a higher number with GOGC=1?
 As always we will be driven by usage cases but I'd be
(happily) surprised if this does not come up. It does however bring up the
issue of whether the test suite should be used for performance metrics or
if it is just for correctness. I actually don't know the answer to that
question or have an opinion.
On Thu, Feb 12, 2015 at 7:17 PM, Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

True.
But at least on my laptop (OS X), I see this test at tip only retain up to
176 MB:
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  171728896 memory
[log] allocated 1000 chunks of 1048576 and used  167268352 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  182882304 memory
[log] allocated 1000 chunks of 1048576 and used  171728896 memory
[log] allocated 1000 chunks of 1048576 and used  177303552 memory
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  178421760 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  168382464 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  170614784 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  156119040 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  151658496 memory
[log] allocated 1000 chunks of 1048576 and used  173961216 memory
[log] allocated 1000 chunks of 1048576 and used  159461376 memory
[log] allocated 1000 chunks of 1048576 and used  166154240 memory
[log] allocated 1000 chunks of 1048576 and used  166154240 memory
[log] allocated 1000 chunks of 1048576 and used  161693696 memory
[log] allocated 1000 chunks of 1048576 and used  151658496 memory
[log] allocated 1000 chunks of 1048576 and used  175075328 memory
[log] allocated 1000 chunks of 1048576 and used  172843008 memory
[log] allocated 1000 chunks of 1048576 and used  165040128 memory
[log] allocated 1000 chunks of 1048576 and used  176189440 memory
[log] allocated 1000 chunks of 1048576 and used  168382464 memory
[log] allocated 1000 chunks of 1048576 and used  165040128 memory
[log] allocated 1000 chunks of 1048576 and used  157233152 memory
[log] allocated 1000 chunks of 1048576 and used  173961216 memory
[log] allocated 1000 chunks of 1048576 and used  169500672 memory
Why is Windows retaining so much more? (636481536)
And why can't I make my laptop have a higher number with GOGC=1?

Yes, but why does this test exhibit different behavior on Windows vs elsewhere?
Anyway, I'll send a CL to tighten this test.


[CJS] #3 Replatformed client to use react. Added test suite, and production builds

Closes #3.
The whole site is now running off React (spun up with create-react-app, which isn't ejected yet), with Redux for data flows, fetch for http stuff, and styled components rather than css.
I've also added a test suite for the frontend and for the data served by the backend (both using Jest).

Closing as superseded by #11


⚠ Guya.moe Proxied has degraded performance

In cc66316, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 12962 ms

Resolved: Guya.moe Proxied performance has improved in 78de41c after 8 minutes.


Both distribute and setuptools listed in install_requires are not upgraded

I have an unusual situation where I want to require a more recent version of distribute and setuptools during the installation of my code. This is mostly for our own deployment via easy_install to our own servers.
In order to do that I've included entries in our setup.py file with install_requires as follows, but they aren't upgraded from the default versions.
setup(
    name='my-project',
    version='0.1',
    install_requires=[
        ...
        'distribute==0.7.3',
        ...
        'setuptools==20.3.1',
        ...
    ],
    ...
)

The default (because I'm on Ubuntu 12.04 LTS) is distribute-0.6.24 and this just gets copied into my virtualenv even though I have the requirements above.
As a note, running pip install --upgrade setuptools==20.3.1 seems to work, but we want to control which package repo these sources come from, so that isn't really an option.
Anybody have insights into why this wouldn't update the egg files in my virtualenv to be the right ones? Much appreciated.

It looks like I submitted this issue just when you guys were moving from bitbucket to github. Wow! @jaraco, welcome. I'm guessing you are incredibly busy right now with that move, but I would appreciate your expert eyes (or anyone else) when you have the cycles. There's probably something obvious I'm missing.

When I try to replicate your issue, I create a python2.7 env:
$ python -m virtualenv --python python2.7 --no-setuptools --no-pip issue525
# install distribute 0.6.24 into virtualenv
...
$ cat >> issue525/setup.py
from setuptools import setup
setup(
    name='my-project',
    version='0.1',
    install_requires=[
        'distribute==0.7.3',
        'setuptools==20.3.1',
    ],
)

$ cd issue525
$ bin/python setup.py install
...
Installed /Users/jaraco/issue525/lib/python2.7/site-packages/my_project-0.1-py2.7.egg
Processing dependencies for my-project==0.1
error: Installed distribution distribute 0.6.24dev conflicts with requirement distribute==0.7.3

I'm not sure why it's unable to upgrade setuptools from that requirement. Perhaps because distribute/setuptools has already been loaded, so it's considered un-upgradeable.
But what you can do is simply upgrade the setuptools version in the virtualenv before installing your package:
$ bin/easy_install -U distribute
Searching for distribute
...
Removing distribute 0.6.24dev from easy-install.pth file
Adding distribute 0.7.3 to easy-install.pth file

Installed /Users/jaraco/issue525/lib/python2.7/site-packages/distribute-0.7.3-py2.7.egg
Processing dependencies for distribute
Searching for setuptools>=0.7
...
Adding setuptools 20.4 to easy-install.pth file
Installing easy_install script to /Users/jaraco/issue525/bin
Installing easy_install-2.7 script to /Users/jaraco/issue525/bin

Installed /Users/jaraco/issue525/lib/python2.7/site-packages/setuptools-20.4-py2.7.egg
Finished processing dependencies for distribute

Thereafter, the demo package installs just fine.
I hope that works for you.

it might be sensible to make setuptools ignore all distribute requirements and print big red warnings when it is used in a setup.py


Staging: Dashboards breaking app navigation after user reloads

Current behavior
Dashboards breaking app navigation after user reloads the dashboard page

Expected behavior
Users can reload the dashboard page and still navigate the app without errors
Steps to reproduce the behavior

Navigate to Dashboards (/activity/dashboard/)
Reload the page
Notice Dashboard drop-down menu is gone
Navigate to WFL1
see error
Notice you can no longer navigate to the rest of the app/WFL1/2, Indicators,etc

Additional details

Frontend issue: closing and adding to other repo
https://app.zenhub.com/workspace/o/humanitec/toladatav2/issues/1048


Bugfix/test suite

Description
An additional attempt at getting closer to make the test suite pass.
Use case
Continuous integration.
Benefits
Once the test suite pass, we can more effectively monitor the effects of any atomic change.
Possible Drawbacks
Some tests have been relaxed, but we're aware we'll have to become more strict when the emergency's over.
Testing
Have you added/modified unit tests to test the changes?
Yes.
If so, do the tests pass/fail?
Yes.
Have you run the entire test suite and no regression was detected?
It's now down to the license test to be either changed or removed.

The changes to testdb.t and DB.pm will conflict with the changes in PR 59
The change to ChecksumMapper.pm seems to make sense, although I am puzzled why that method worked when the changes were initially submitted, as I could not see any changes in the module that would explain the change in behaviour.
Not sure about the change in checksum_mapper.t though, I assumed there was a reason to run that test, even if I don't understand  why it is now failing

OK, I tried to get ChecksumMapper to work and can't figure out what is wrong with it, or rather, how it could work to start with, so I'm OK with your fix for the time being to get this working.
Once I move on to the mapper modules, I'll spend more time on getting this working properly.
For the time being, happy to take those changes in as long as we revert the changes to DB.pm and testdb.t, as they conflict with master

Ok, I have resolved the conflicts and restablished Critic and POD compliance.

In terms of checksum mapper tests, I have removed that part as it's not technically a test, it was indirectly verifying that process method invocation works.

Fair enough. It seems wrong that it fails, but let's get everything else working first.
Waiting for Travis to finish running, but otherwise I think we will be good to go with this

Travis seems a bit lazy at the moment, but let's wait. I agree, it feels wrong.

Test suite passes. Strange though the apache test fails for me.


Wiremock tool not linking

Sorry for the lacking description, but i had an issue with a mac m2 where the wiremock extensions inspection wasn't running correctly as it couldn't find the wiremocks tool binary in my projects .net6/bin folder i fixed this by manually copying and pasting the file into the project bin but there might be an issue with the code
i also had issues with needing a manifest file even though i installed wiremock tool globally so i made a local manifest

Beside the nuget package with the extension methods, the WireMockInspector tool needs to be installed manually as a global dotnet tool. I don't have access to any MacOS machine so I can't help you with that. However, any contributions in this are are welcome.


Update to VSCode 1.90

@CGNonofr I tested it locally and everything seems fine, but you broke the demo build

I will give you a go once that is fixed.

@CGNonofr I just read this in the VSCode release notes:

Does it mean you can/should move to node 20 here as well?

@CGNonofr I just read this in the VSCode release notes:
Does it mean you can/should move to node 20 here as well?

AFAIK, They seem to be still using node 18 for building though, but I've switched to last versions and everything seems to work so... updated

@CGNonofr I just read this in the VSCode release notes:
Does it mean you can/should move to node 20 here as well?

AFAIK, They seem to be still using node 18 for building though, but I've switched to last versions and everything seems to work so... updated

Hum nop, doesn't work, rollbacked

Hum nop, doesn't work, rollbacked

ok, not aligning build and execution env sounds fishy. On the other hand the SW stack involved is deep and broad regarding dependencies.