[Feature Request] bot_required_permissions in poise::command

Summary
This would allow definition of the permissions the bot user must have for a command to execute, if not met, pass an error to on_error.
Usecase
In order to reduce 403s in the command body, or repeated code to handle checking permissions and displaying friendly errors, it would allow the user to centralize it in on_error. I personally use discord.py's @commands.bot_required_permissions extensively to define basic permissions such as send_messages, embed_links, or similar.

Implemented in 68b42d705045aec410191523522ff89afcffd7b1 (and a few subsequent commits)


DialogueRunner.VariableStorage changed to interface instead of MonoBehaviour class.

[X] Tests for the changes have been added (for bug fixes / features)

[X] Does it pass all existing unit tests without modification?

[X] Docs have been added / updated (for bug fixes / features)
[X] CHANGELOG.md has been updated to describe this change

What kind of change does this pull request introduce?

[X] Feature

What is the current behavior?

DialogueRunner.VariableStorage is a MonoBehaviour which doesn't allow users to setup their own implementation of the base class without having a MonoBehaviour as the intermediary.

What is the new behavior (if this is a feature change)?

DialogueRunner.VariableStorage is now an interface called IExtendedVariableStorage.

Does this pull request introduce a breaking change?

No.

Who will be affected?

Is this an internal change, or something meant to be consumed by the end user?
A: Meant for the end user.
If you add API changes, is it easily upgradable from the previous version?
A: Yes.

What do you think will be controversial, if any?
A: The implementation of the DialogueRunner.VariableStorage property.
How would you describe the cause of the problem and changes to non-technical users if at all possible?
A: Non-technical users won't be affected as the previous functionatily still works in the same manner.

This is a good PR and we'd like to merge it, but we feel the overhead of maintaining this split between interface and MonoBehaviour versions of variable storage is not worth it.
As Unity slowly advances into the modern era (hint hint, Unity!) we will move the storage to an interface. For now we will stick with the mono behaviour only.
Thanks again for the excellent PR, and we're sorry we can't merge it at the moment.


python3 set-reserve.py --read error

Greetings,
Version v0.7.7 Tesla Firmware 23.44.0
I just installed the latest version and I have the right set-reserve.auth and set-reserve.conf. However, when I tried to run the following command, it produces this:
python3 set-reserve.py --read
Traceback (most recent call last):
File "/home/pi/pypowerwall/tools/set-reserve.py", line 313, in
data = get_level()
File "/home/pi/pypowerwall/tools/set-reserve.py", line 264, in get_level
data = battery.get_site_info()
AttributeError: 'Battery' object has no attribute 'get_site_info'
I can get info out of the battery by using the example.py so it seems the local account is good. This used to work with an older version but I haven't tried recently.
Thanks
Stephen

I just made sure that the tesla info is recent as I had to enter my password to get the token so it wasn't using any cached version.

Hi @Stephen2615 can you check to see what version of TeslaPy you have?  You will need 2.8.0.
import teslapy
print(teslapy.__version__)

Hi @jasonacox TeslaPy is at 2.8.0.

Thanks! I found the bug. I'll submit the fix.

Hi @jasonacox, Thanks for your help. I used the set-reserve.py you offered and it didn't fix it. The error is the same.

Try running this script (or run interactively with  python3):
import teslapy

# Set variables
TAUTH="set-reserve.auth"
<EMAIL_ADDRESS># replace with your real email you use with Tesla

retry = teslapy.Retry(total=2, status_forcelist=(500, 502, 503, 504), backoff_factor=10)
tesla = teslapy.Tesla(email, retry=retry, cache_file=TAUTH)

# Get site info
battery=tesla.battery_list()[0]
config = battery.api("SITE_CONFIG")["response"]
site = battery.api("SITE_SUMMARY")["response"]
data = {**config, **site}
level = data["backup_reserve_percent"]
pw_count = data["battery_count"]

print(f"READ: Current Battery Reserve Setting: {level}% for {pw_count} Powerwalls")

Hi @jasonacox
It works.
READ: Current Battery Reserve Setting: 25% for 1 Powerwalls
Cheers
Stephen

That's great!  That's basically what is in set-reserve.py so I suspect you have a cached older version. In any case, you can use that one. :)

Updated to 0.8.1 and everything is working nicely. Thanks to all.

Thanks @Stephen2615 ! 🙏

@jasonacox.
A bit off topic but how does the cron.sh work? When I use cron, it runs at specific times but yours doesn't give an example. Eg, every 10 minutes of every hour? I haven't used it as we get a lot of fog here in Winter and "clouds" doesn't really give an indication of fog. I was trying to figure out some way of saying yes, we have fog. The Tesla algorithm won't charge the battery when it is foggy here as it doesn't recognise fog equals clouds. I don't want to force the battery to charge if it doesn't need it but its almost mandatory with fog.
Cheers
Stephen

Interesting use case!  I run the cron.sh every 5 minutes using this crontab entry:
*/5 * * * * /home/tesla/cron/cron-powerwall.sh > /dev/null 2>&1

You can edit your crontab with crontab -e.

@jasonacox
The vagaries of Bash has struck. Us plebs in the Southern Hemisphere means that we can't use the test in cron.sh:
if (( "${MONTH}" == "06" )) || ((  "${MONTH}" == "07")) || (( "${MONTH}" == "08" )); then
as "08" isn't read properly.
((: 04 == 08: value too great for base (error token is "08")
I had to change it to Jun or Jul or Aug with the MONTH being MONTH=date +%b
if (( "${MONTH}" == "Jun" )) || ((  "${MONTH}" == "Jul")) || (( "${MONTH}" == "Aug" )); then
Crazy eh?
Cheers
Stephen

Great fix @Stephen2615 !  I actually like your approach better in general. It is more readable. I don't know why I went with numerics.

@jasonacox Many years ago, I once did a IT contract and found someone had wrote a 25k line shell script to do scheduling. The only comment was the second line where he had his name. It wasn't working and someone told me to fix it. I think I quit at that stage.


Textarea Rows

I noticed that the textarea field type does not appear to support the rows attribute: is there a way to control its size?

like all the tags generated, one can use css to provide additional control.
the html textarea doc says
The size of a text area is specified by the cols and rows attributes (or with CSS).

Sounds good


refactor(core): split out tracking and logger

Description

What does the PR do?
Include a concise description of the PR contents
Testing
How was this PR tested?

close in favor of a work that Tima will be doing


Reddit blockage workaround to prod

Task/Issue URL: https://app.asana.com/0/488551667048375/1207360759125228/f
Description
Move the Reddit vpn workaround to prod users
Steps to test this PR

#4591  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Biber 2.18 failing to validate test-dev.bcf

Preparing for the 2.18 release, one of my two integration tests failed:
/ # /usr/local/bin/biber --validate-control test-dev.bcf
INFO - This is Biber 2.18
INFO - Logfile is 'test-dev.blg'
ERROR - 'test-dev.bcf' failed to validate against schema '/tmp/par-726f6f74/cache-c0c32362f47309c381de02334ee0e5b081733275/inc/lib/Biber/bcf.rng'
INFO - ERRORS: 1
/ # cat test-dev.blg
[0] Config.pm:306> INFO - This is Biber 2.18
[0] Config.pm:309> INFO - Logfile is 'test-dev.blg'
[112] biber:340> INFO - === Wed Jun 22, 2022, 18:54:33
[135] Utils.pm:410> ERROR - 'test-dev.bcf' failed to validate against schema '/tmp/par-726f6f74/cache-c0c32362f47309c381de02334ee0e5b081733275/inc/lib/Biber/bcf.rng'
[135] Biber.pm:135> INFO - ERRORS: 1

test-dev.bcf is dated 2022-03-17 and has sha256 of 99dee57a108ba5c030027ea7a6579efb37523e51ff38bff49abf76c2d2e34be9
Is that something we should be concerned about? The other test , /usr/local/bin/biber --convert-control test-dev.bcf, passes without failures.

You can now try test.bcf which is updated but if you've just build biber can you pull the v2.18 tag again? There was a rather unexpected XML schema issue I just had to correct and the master head and v2.18 tag have the fix. I will update test-dev.bcf when v2.19 dev version deviates from the current test.bcf.

Hmm, looks like you still have the old test.bcf - perhaps you got it before SF replicated it - the correct one should have at the top:
<bcf:controlfile version="3.9" bltxversion="3.18" xmlns:bcf="https://sourceforge.net/projects/biblatex">

Yes, my fault. Sorry for the confusion. Now that I've rebuilt my Docker image, all tests pass. I'll upload the archive to SF tomorrow morning.

(You might want to push an updated v2.18 tag, though)


where can I download the CloudnetAPI for the version 2.1.17?

Can anyone send me a link from the cloudnetapi where I can download the CloudnetAPI

You can get everything by either adding the relevant dependency to your Maven or Gradle build file, downloading it from our releases (https://github.com/CloudNetService/CloudNet/releases) or from our official website (https://cloudnetservice.eu/cloudnet/version/release/).


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1558

Questions ?
Please refer to the Backport tool documentation


CL:0009077 & CL:0002294 are duplicates?

CL:0002294 (type-1 epithelial cell of thymus)  has exactsynonym subcapsular thymic epithelial cell which is the rdfs:label of CL:0009077. I am guessing they should be merged? Also I thought there was suppose to be a QC check that prevents this @anitacaron or @gouttegd?

unassigning myself as this needs to be done by someone else per https://github.com/obophenotype/cell-ontology/pull/2110#issuecomment-1683673944

@shawntanzk, thank you for spotting this.
Here are some findings after a cursory investigation:

'subcapsular thymic epithelial cell' has text definition:
"A thymic epithelial cell located within the subcapsular region of the thymus." There is no logical definition.

'type-1 epithelial cell of thymus', a sibling class of 'subcapsular thymic epithelial cell', has text definition:
"An epithelial cell with a well defined Golgi apparatus that makes up the continuous layer of cells bordering the thymic tissue beneath the capsule." There is no logical definition.

The exact synonym "subcapsular thymic epithelial cell" on the 'type-1 epithelial cell of thymus' lacks a cross-reference.

The reference for the text definition of 'type-1 epithelial cell of thymus' is from 1997 and, assuming this class refers to the EC.1 subtype described in the paper (I did not see the term "type-1"), this type has designations to both subcapsular and perivascular (medulla) regions of the thymus (table 1, table 2, and accompanying text), with similar, but not exact descriptions of ultrastructural morphologies. The paper focuses on rat thymus.

The same reference also states:
"the subcapsular epithelium in particular may be a
dynamic structure, since transitional forms have been
observed between sheet-like EC, basket-like EC, and
[thymic nurse cells] depending on the type of cortical lympho-stromal
interaction (Van Ewijk, 1988, 1991)"

Another reference from 1989 states the following:
"Around the gland and in their course to the cortico-medullary junction they are delimited by a continuous layer of type-1 epithelial cells (subcapsular/perivascular cells) that rest on a basal lamina. They contain the major blood vessels to and from the medulla, and capillary loops that enter the cortex from the medulla are also ensheathed by the type-1 cells."

A reference found online, PMID:18194204, states the following with respect to normal mouse thymus:
"‘Subcapsular epithelial cells’ (type 1) were positioned against the capsule, septa and perivascular connective tissue, and always had a basal lamina. These cells were found to be irregular in shape and showed cellular prolongations that interconnected them with the adjacent epithelial cells by means of desmosomes. The nucleus was found to be mostly euchromatic and the cytoplasm had a very active appearance: the Golgi complex was well developed; smooth and coated vesicles, multivesicular bodies and elongated profiles of rough endoplasmic reticulum were abundant, whereas only a moderate number of mitochondria and polyribosomes were seen. Fine bundles of keratin tonofilaments were positioned around the nucleus and throughout the cytoplasm."

@addiehl, if you have more insight on thymic epithelial subtypes, please do advise.

Given the above, I propose the following to address the immediate issue:

[ ] 'subcapsular thymic epithelial cell' can remain to serve as a general class to group the heterogenous cells types in that region. No change.

[ ] The synonym "subcapsular thymic epithelial cell" of 'type-1 epithelial cell of thymus' can be changed from an exact to a related synonym with dbxrefs PMID:18194204 and PMID:2694455. In a separate issue, the text definition can be refined.

@shawntanzk, thank you again for spotting this issue.
It has been resolved in the associated PR.


Define mkldnn memory format to fixed range, so that it is friendly to…

… framework.
Framework can know the it is data format or weight format based on the format range. The index of each format should be fixed in each mkldnn release, so that it is binary compatible.

The solution is not scalable especially with the upcoming RNN stuff.
It also contradicts with #153 (when nchw == oihw).
Probably the best solution to preserve ABI would be just adding new formats to the end of the list.


Full release for 1.10?

Is release 1.10 going to get the full treatment? Currently on the release page it's still showing 1.9 as the "Latest release" and there's no download archives.
I tried the auto-tar.gz but it was missing contribs...

v1.10 is now fully released; note that contrib/ was removed from pugixml (see https://github.com/zeux/pugixml/commit/434c4a4d41bfc4cd3803a0af8525fc25a46a3668)

Thanks for the quick response! Did you mean to remove both README.md and LICENSE.md?

Neither README.md nor LICENSE.md have been present in any release archives - readme.txt contains the license information and brief summary.


Meta Package manifest

A metapackage could be made, to group the packages in moveo_ros

https://github.com/jesseweisberg/moveo_ros/pull/18


⌘Space does not 'Show Autocomplete'

Insomnia Version: Version 5.14.7 (<IP_ADDRESS>1)
Operating System: macOS High Sierra Version 10.13.3 (17D47)

Details
⌘Space does not 'Show Autocomplete' in Insomnia.
Usually I would use ⌘Space for the global shortcut 'Show Spotlight search'. I don’t know how to change Insomnia shortcuts so I disabled that macOS global shortcut. However, it still doesn’t work in Insomnia.

Solved.
The Insomnia shortcut for Show Autocomplete is ^Space and not ⌘Space. The shortcut listed in Insomnia Preferences / Keyboard is wrong.
^Space is the default global keyboard shortcut for Select the previous inout source. It would be nice if Insomnia keyboard shortcuts could be configurable. I’m not sure if that’s possible with Electron apps.


node like  < node />

begin a node,  right after '<' with a space.   just like <     node /> , it is  error.

Space after < is always an error; < node /> isn't valid XML.

yes, i know. thank you so much.
i use pugixml to analyzing xml for  a directui designer.  with a scintilla editor.
can you tell me some suggestions, how to reflect modified xml to pugixml immediately in my editor.
now, i always load_string to rebuild windowui, it's so stupid.

If the text changes, you need to reparse it by doing load_string or equivalent. If you want to, you could write a function that creates a new document, and then walks through both documents at the same time and only applies changes to the UI based on the difference in nodes,


nrnivmodl_core_makefile: fix SDKROOT

Description
Needed for neuronsimulator/nrn#1939
CI_BRANCHES:NEURON_BRANCH=fixmf

Codecov Report

Merging #845 (fd6d09a) into master (9523270) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   58.36%   58.36%
=======================================
  Files         102      102
  Lines        9410     9410
=======================================
  Hits         5492     5492
  Misses       3918     3918

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I guess the logic here is that the old code baked in an SDK path from CMake-time that might not be appropriate on a user machine at nrnivmodl-core-time?

Indeed. We were "lucky" the SDKs were there for testing :)


Ensure all temp files are deleted after the compatibility test

Why are these changes needed?

This PR ensures all temp files are removed after the compatibility tests are completed. In the current implementation, some temporary files will not be deleted after the process exits due to:
https://github.com/ray-project/kuberay/blob/683f0fa91928fda056027a6ccd6b564435898c72/tests/kuberay_utils/utils.py#L44
With the option delete=False, the temporary files will not be deleted after the process exits, and need to be deleted manually. See NamedTemporaryFile for more details. Check /tmp to see the temporary files after the tests are completed.
In this PR, temporary files will be deleted automatically once we close the files. See how NamedTemporaryFile works.
with tempfile.NamedTemporaryFile('w', suffix = '_ray_cluster_yaml') as ray_cluster_yaml:
        ray_cluster_yaml.write(yamlfile)
        ray_cluster_yaml.flush()

Note: We need to add a flush manually. Otherwise, the file will be empty when we try to read it because the flush normally does not happen until the file is closed.

This PR removes redundant try/catch. RayServiceAddCREvent and RayClusterAddCREvent already have the logic to raise and log errors.

Related issue number

Checks
Make sure the compatibility tests still work. This can be proven through the CI test.

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

The CI failure is due to #852.


Epic/product configuration

This is not for merging soon, but to leave comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: schuppell:white_check_mark: ChristophHi:white_check_mark: MichaelBoeser:white_check_mark: steinsebastian:white_check_mark: alepil:white_check_mark: schuppel:x: Larisa-StaroverovaYou have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.


Update how-to-manage-models-mlflow.md: Python fix

s/using mlflow/import mlflow/
The command to import a module is "import" not "using"

@santiagxf
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

LGTM!

#sign-off

Due to the upcoming conference, all merging and publishing are on hold until the morning of 5/23.
This PR is ready for merge on 5/23.
#label: "event-triaged-to-10AM"
#label: "missed-content-complete"


Goto definition does not work for functions

Hey everyone,
I just found this issue. It seems that the goto definition does not work for function imported in a library. I am importing the file thanks to the .vhdl_ls.toml file in the user directory, and despite the fact that the file is properly imported, the function can't be linked to it.
It is not written as "not imported" or "error", I simply can't go to the definition when clicking on the function.
Regards

Moved this question to rust_hdl


Timing violation for vta hardware implementation!

Hello there, I clone this repository and compile the hardware design "/tvm/vta/hardware/xilinx/". It successfully generate the bitstream but the timing closure is not satisfied. It reports WNS and TNS are -1.601,  -1198.534 respectively. My synthesis and implementation keep the default settings unchanged.

please open a new thread at http://discuss.tvm.ai/ :) and i think the community will be more than happy to answer the question


setJsonFeed does not use the signer passed in the constructor

Generally in the API the functions that expects a signer parameter expects it as an optional parameter and if it is not passed in the function they try to use the one that is passed in the constructor.
See makeSOCWriter, makeFeedWriter, getJsonFeed as examples, they all use the resolveSigner method of the Bee class to achieve the functionality described above. The only exception to this seems to be the setJsonFeed function. For the sake of consistency it would be better if it were doing the same.

Sorry, false alarm :)
I see that the setJsonFeed uses makeFeedWriter internally.


hostfxr.dll failure

Just trying this out..this is Win7 64 bit SP1, vc runtime 2015 update 3 is installed as well as .NET Core 2.2 runtime.  Here's what I get when I try and run:
Failed to load the dll from [C:\Users\Jonathan\Desktop\AsaCli-win-2.0.150\res\hostfxr.dll], HRESU
LT: 0x80070057
The library hostfxr.dll was found, but loading it from C:\Users\Jonathan\Desktop\AsaCli-win-2.0.1
50\res\hostfxr.dll failed
  - Installing .NET Core prerequisites might help resolve this problem.
     https://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

not sure how to process.  Thank you.

If you flow the URL in the error message you'll see there are two KBs you need to install to resolve the hostfxr issue.


IBESoftware.HelpNDoc version <IP_ADDRESS>9 Personal Edition

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run


Fedora 38 based container while run on Ubuntu 20.04 host has black screen (no desktop-ui)

Image: owncloudci/squish:fedora-38-6.7-20220106-1008-qt515x-linux64
:heavy_check_mark: Running container on Ubuntu 22.04 host - can see xfce desktop

:x: Running container on Ubuntu 20.04 host - black screen

Might be a similar problem to the issue https://github.com/owncloud-ci/squish/issues/34

CC @fmoc

We have moved on to using Fedora-39 as base image
https://github.com/owncloud-ci/squish/blob/ae54d4fc6e6d41c9e9d0c61dc11f0f6b5fdfdb88/fedora/Dockerfile.amd64#L2


vue-tsc's dependency version (0.27.7) is different to Extension version (0.27.27). Type-checking behavior maybe different.

Version: 1.61.0-insider (Universal)
Commit: c9e8266ee24f34107ff52d836a4e8f533afb93c5
Date: 2021-10-01T14:47:05.989Z
Electron: 13.5.0
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0
Volar: v0.27.27

Every time I restart vscode and open vue file, will alert this notification:
vue-tsc's dependency version (0.27.7) is different to Extension version (0.27.27). Type-checking behavior maybe different.

My vue-tsc version is 0.3.0.

You can click "Open package.json" to check the version, and see #402 to check how to update it.
If you don't want this prompt, click "Disable Checking" to disable it.


Add google analytics to the mkdocs pages

We decided we don't want this at the cost of adding annoying cookie popups.


Add test logger

Requires a little hoop jumping to work around https://github.com/java9-modularity/gradle-modules-plugin/issues/140
Reviewer checklist

[x] New Modules have module-info.java files.
[x] Public types are well-designed:

[x] no public constructors.
[x] prefer interface or impl.

[x] Ensure relevant issues are linked (description should include text like "Fixes #")
[x] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 100.0% when pulling 9badd3fea7a759fe244f5df7e9580811fb6974ef on test_logger into 5267826d2c8fe8a8242f2e530c0e85a55bb2c654 on main.


Update to readme

Updated README.md to give steps to install fping.

WIll add some modifications to the readme as we should add RPM query, and to add a way to bypass the fping check assuming it is installed by other means than RPM


web.xml is missing at osiam.war file

Hi Team,
I have downloaded the osiam.war file from https://dl.bintray.com/osiam/downloads/osiam/3.0/
and found that web.xml is missing..
Could you please let me know if I am missing anything here.
Thanks,
Tushar

Hi Tushar,
I think you want to start OSIAM in a servlet container like Tomcat?
If so, please have a look into the installation guide. Consider that you need a servlet container that support at least Servlet API 3.
Greetz,
David

Hi @tusharparate1,
I close this issue for now. If you have any problems, just re-open this issue.
Regards,
David


⚠ Bofrost.lu has degraded performance

In e145a66, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: Bofrost.lu performance has improved in dcc5a4e after 35 minutes.


Host type has IPv4 forwarding enabled

Hi
machines of type "host" have IPv4 forwarding enabled (IPv6 is off):
root@host1:~# cat /proc/sys/net/ipv4/ip_forward
1
root@host1:~# cat /proc/sys/net/ipv6/conf/all/forwarding
0

I'd prefer it "Off" by default. /etc/sysctl.conf also suggests it is off:
root@host1:~# grep forward /etc/sysctl.conf
# Uncomment the next line to enable packet forwarding for IPv4
#net.ipv4.ip_forward=1
# Uncomment the next line to enable packet forwarding for IPv6
#net.ipv6.conf.all.forwarding=1

I agree that IP forwarding should be disabled by default on hosts. The weird thing is that I can't seem to locate where this setting is actually enabled. So to tackle this I made https://github.com/Erik-Lamers1/vnet-manager/pull/12 to explicitly disable IP forwarding on hosts.


Add Language Switcher support

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[ x] ✨ New Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR enables a dropdown language switcher to support Javascript and Kotlin
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added code snippets?

[ ] 👍 yes
[ x] 🙅 no, because they aren't needed

Added tests?

[ ] 👍 yes
[ x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

No tests? Add a note
Just adding the functionality in for future PRs
Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 general documentation
[x ] 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1206364149951966

Ready for reviews again

could we make it a bit more obvious - I had to hunt around for it (scrolled right passed it!) somehow?

could we make it a bit more obvious - I had to hunt around for it (scrolled right passed it!) somehow?

agreed. needs some overall styling

Updated the switcher to be clearer per @angiejones and @michaelneale

@chris-tbd On our topic of "selecting the language", Stripe has a cool approach:
Selecting a new language in the tab is a global selection, and all other code blocks change to the language selected. Means they don't need a separate language selector in the navbar (real estate IMO we should be protective of :slightly_smiling_face: ) WDYT?

@chris-tbd On our topic of "selecting the language", Stripe has a cool approach: Selecting a new language in the tab is a global selection, and all other code blocks change to the language selected. Means they don't need a separate language selector in the navbar (real estate IMO we should be protective of 🙂 ) WDYT?

@ALRubinger Chris brought this up in the call and said that the content of the doc may change too dependeing on language (e.g. links to API Ref for more info)

Yup, and also the exceptional cases of "what if a language is selected globally but some blocks don't have that language implemented".

@angiejones I started working off of my own branch when I moved to Chris' branch I ran into a state issue I'll debug tomorrow. On my branch I only needed to change this line in languageContext.jsx:
const [language, setLanguage] = useState('js'); to get the snippets to render, but you'll see to get it to work I had to change the tabs to js instead of JavaScript as well.

I added the ability to hardcode within the Shnip component
To add the custom admonition we need to upgrade to v3.1 based on the docs, I'll test locally tomorrow to see if this v upgrade will break anything on the site if not implementing it will be straightforward.

@angiejones I started working off of my own branch when I moved to Chris' branch I ran into a state issue I'll debug tomorrow. On my branch I only needed to change this line in languageContext.jsx: const [language, setLanguage] = useState('js'); to get the snippets to render, but you'll see to get it to work I had to change the tabs to js instead of JavaScript as well.

I added the ability to hardcode within the Shnip component
To add the custom admonition we need to upgrade to v3.1 based on the docs, I'll test locally tomorrow to see if this v upgrade will break anything on the site if not implementing it will be straightforward.

@EbonyLouis ok sounds like a lot of work. If it looks like something that will take more than a day or 2, let's go with the  component you came up with

This is the test file that is utilizing the new Shnip component. Changing versions caused a lot of errors, this is something I can work through but I don't think we should let it hold us up.
Passed on the last issue to Chris to get a new pair of eyes on it I feel like its a super simple fix that I'm overlooking.

updated issue description with latest info

@angiejones all set


ENABLED_COLLECTORS parameter not accepted

I am re-installing wmi_exporter on our servers in order to enable more collectors.
First, I uninstalled:
msiexec /x C:\wmi-exporter.msi
when I run the command:
msiexec /i C:\wmi-exporter.msi ENABLED_COLLECTORS=ad,hyperv,iis,cs,dns,memory,process,tcp,system,net,logical_disk
I get the MSI information box pop up, rather than the msi installing with the required collectors. I know this same command installs fine on a server that wmi_exporter has never touched before.

I ran the same command in CMD rather than powershell and it worked.


some explanatory text

Can you elaborate

I think this can actually be closed now that there's a README. Though any ideas for improvement are welcomed....


METRON-2174: Grouped alerts total can differ from search alerts total

Contributor Comments
Link to ASF ticket here.
In the Alerts UI, when a user searches and then filters by a group or groups, the total amount of grouped alerts can differ from the total amount of alerts from the search.

As a simple solution, I've added a grouped alerts total whenever you filter by group.

Testing
Open the Alerts UI and perform a search that produces some results. Filter by group (I used enrichments:geo:ip_dst_addr:country). You should see the grouped alerts total displayed below the overall total.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

n/a ~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

n/a ~Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html~:
cd site-book
mvn site

[ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

+1 (non-binding) Works as it's expected. Thanks for fixing this!

+1


ISPN-4661 TreeNode putIfAbsent implementation is different from what …

…promised
Hi,
This PR resolves https://issues.jboss.org/browse/ISPN-4661
Bye,
Andrea

Can someone add the "ready for review" label?
Thanks.
Andrea

Integrated, thanks Andrea!


VisualReview generates invalid PNGs

I'm running VisualReview on a Mac (MacOS 10.13). I've send some screenshots to the screenshot endpoint, but it seems, VisualReview is generating invalid PNG files. When I search for them on my system, I can find, but not open them. On the localhost I see the the icon for a missing image:

The files on the system have sizes of about 1.8 MB, so they're not empty. Is there any way to fix this? What information do you need?
I seem to get a valid response from the server:
2019-05-17 10:06:20.285 INFO  com.xebia.visualreview.middleware - Response:
# headers:
Vary: Accept
Content-Type: application/json;charset=UTF-8
# body:
{"id":15,"size":1786783,"properties":{"browser":"android","resolution":"1080\u2006\u00d7\u20061920"},"meta":{"component":"login"},"screenshotName":"screenshot","imageId":43}
When I open http://localhost:7000/api/runs/60/screenshots, the file paths seem to be messed up though:

How are you sending the screenshots? The file size shouldn't be an issue and the double slash in the path is unrelated.
What happens if you visit: http://localhost:7000/api/image/43?

I send the screenshots synchronously as multipart objects (see code below).
When I visit http://localhost:7000/api/image/43 it says "the image ... can't be displayed, because it's faulty".
`private void sendToVisualReview(String fileName) {
Run run = new Run("joyce-ui-test", "test");
    // get file and create RequestBody from it
    File screenshotFile = FileUtils.getFile(fileName);
    RequestBody filePart = RequestBody.create(
            MediaType.parse("image/png"),
            screenshotFile
    );

    // create MultipartBody object
    RequestBody namePart = createPartFromString(screenshotFile.getName());
    RequestBody metaPart = createPartFromString("{}");
    RequestBody propertiesPart = createPartFromString("{}")
    MultipartBody.Part uploadFile = MultipartBody.Part.createFormData("file", screenshotFile.getName(), filePart);

    // get client
    VisualReviewClient client = ServiceGenerator.createService(VisualReviewClient.class);

    // start run (synchronous)
    Call<Run> runCall = client.createRun(run);
    try {
        run = runCall.execute().body();
        System.out.println("RESPONSE: " + run.toString());
        System.out.println("RUN-ID = " + run.getId());
    } catch (IOException e) {
        e.printStackTrace();
    }

    // execute request
    Call <ResponseBody> call = client.uploadScreenshot(
            namePart,
            uploadFile,
            metaPart,
            propertiesPart,
            run.getId()
    );

    try {
        ResponseBody responseBody = call.execute().body();
        System.out.println("RUN-ID = " + run.getId());
    } catch (IOException e) {
        System.out.println("ERROR uploading screenshot");
        e.printStackTrace();
    }
}`

My guess it something in the way the request is formed in the client. I'm not familiar with the client code used above. Do you have a minimal reproducible setup you can share?

Unfortunately not. What information do you need?

I used retrofit for the API requests.

I would look at the HTTP body to see how it's formed.
The following POST request using postman works fine for me. If it works for you as well, it's certainly something in the HTTP request.

Dear dmarjenburgh, thanks for your reply! When I use postman to send the same request, it still seems like I can't display the images:

I've tried different files to make sure there's nothing wrong with the PNG, but to no avail.
When I open the files that visualreview produces with finder, they seem to be invalid and can't be opened.

@dmarjenburgh, @nemue I have this behaviour too. It happens only when http-logging is enabled in config.

@aartikov, how do you disable that?

Open file config.edn and check that  :enable-http-logging is false. Actually it is the default value, so you probably have some other error.


Enable iter8-handler jobs to run in experiment namespaces

Is your feature request related to a problem? Please describe the problem.
Note: This goes back to an initial implementation of handler/jobs.
Iter8 architecture is currently a bit far from being multi-tenant.

User A has an application. User B has an application. A uses kubectl to promote their app in a task. B uses kubectl to promote their app in a task. Unfortunately, A can also use their experiment to mess with B's application in a task, since both of their jobs use iter8-handlers service account with common set of permissions!
A has a git secret. B has a git secret. Both their git secrets are readable using their respective handler jobs by each other (since the iter8-handlers service account has permissions for both)!

Describe the feature/solution you'd like
Enabling handler jobs to run in experiment namespaces, using the default service account of their respective namespaces eliminates this issue. In-cluster operations (such as manipulating k8s resources and reading secrets in jobs will now require RBACs which individual users can supply as per their need). This also assuages much of the criticism around imperative aspects of Iter8 (like the bash task). Tasks can be enable by individual users to do as much or as little as they want depending on RBAC permissions they provide. By default, handler jobs will not have permissions to manipulate any cluster resource (apart from the experiment used to create them).
Will this feature/solution bring new benefits for Iter8 users? What are they?
This is a step towards multi-tenancy of Iter8.
Will this feature/solution bring new benefits for Iter8 developers? What are they?
Simplifies Iter8 controller functions during experiment deletion. Experiment object can go back to being the owner of the job objects created by it.
Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
Yes, see above.
How will this feature be tested?

[ ] A checklist of behaviors that will be tested as part of this feature implementation.

How will this feature be documented?

[ ] Most new features require end-user documentation at https://iter8.tools. Describe the specific documentation that will be added.

Additional context
This still does not solve the problem of universal permissions for iter8-analytics for reading secrets. Perhaps this issue can be solved by write a handler task to fetch metrics instead of the analytics service fetching metrics.

Closing for now. To be reopened if this becomes a priority.


On signup, ask user their email and send a verification mail

Can we get some screenshots of modals for signup / passkey generation, so that @MaxSemenchuk has a reference how to modify for this feature? @kkatusic @b0rza

Can we get some screenshots of modals for signup / passkey generation, so that @MaxSemenchuk has a reference how to modify for this feature? @kkatusic @b0rza

I just recorded how it looks like. No need for screenshots. Let's add a modal that is shown after the passkey is created. @MaxSemenchuk


bug: Neo-tree errors

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.4
Operating system/version
MacOS 14.0
Describe the bug
   Warn  15:17:39 notify.warn [lspconfig] Cannot access configuration for lua_ls. Ensure this server is listed in `server_configurations.md` or added as a custom server.
   Error  15:17:39 msg_show.lua_error Error detected while processing FileType Autocommands for "*"..function <SNR>43_filetype_changed:
15:17:39 msg_show line    4:
15:17:39 msg_show E492: Not an editor command:             Semshi enable
   Error  15:17:48 notify.error [Neo-tree ERROR] Error opening file: vim/_editor.lua:0: nvim_exec2()..BufReadPost Autocommands for "*": Vim(append):Error executing lua callback: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: Error executing lua: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: nvim_exec2()..BufReadPost Autocommands for "*"..FileType Autocommands for "python"..FileType Autocommands for "*"..function <SNR>43_filetype_changed, line 4: Vim:E492: Not an editor command:             Semshi enable
stack traceback:
	[C]: in function 'nvim_cmd'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24>
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>
stack traceback:
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>
   Error  15:18:02 notify.error [Neo-tree ERROR] Error opening file: vim/_editor.lua:0: nvim_exec2()..BufReadPost Autocommands for "*": Vim(append):Error executing lua callback: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: Error executing lua: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: nvim_exec2()..BufReadPost Autocommands for "*"..FileType Autocommands for "*"..function <SNR>43_filetype_changed, line 4: Vim:E492: Not an editor command:             Semshi enable
stack traceback:
	[C]: in function 'nvim_cmd'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24>
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>
stack traceback:
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>
   Error  15:18:36 notify.error [Neo-tree ERROR] Error opening file: vim/_editor.lua:0: nvim_exec2()..BufReadPost Autocommands for "*": Vim(append):Error executing lua callback: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: Error executing lua: ...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: nvim_exec2()..BufReadPost Autocommands for "*"..FileType Autocommands for "*"..function <SNR>43_filetype_changed, line 4: Vim:E492: Not an editor command:             Semshi enable
stack traceback:
	[C]: in function 'nvim_cmd'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:25: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24>
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>
stack traceback:
	[C]: in function 'nvim_buf_call'
	...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:24: in function <...brew/Cellar/neovim/0.9.4/share/nvim/runtime/filetype.lua:10>
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function <vim/_editor.lua:0>
	[C]: in function 'pcall'
	...hare/nvim/lazy/neo-tree.nvim/lua/neo-tree/utils/init.lua:697: in function 'open_file'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:687: in function 'open'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:718: in function 'open_with_cmd'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:727: in function 'open'
	...o-tree.nvim/lua/neo-tree/sources/filesystem/commands.lua:184: in function 'func'
	...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:843: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:841>

Steps To Reproduce

install lang.python, lang.python-semshi extra packages.
sshfs to mount a remote folder containing python project.
run the nvim
open Neo-tree.

Expected Behavior
Neo-tree can be open normally.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

same here

ok, I'm not sure what a semshi is, lol, I'm not python guy. nor am I familiar with mac, so you know, take this with a grain of salt.
it sounds like a path issue to me. when you're simply in your terminal, and you type "semshi" does it error out for you?
if that works, I'm thinking it's not found in the Runtimepath .
if you go into neovim and run :set , do any of the paths include this semshi thing?
another thought is that it says "not an editor command" so it seems almost like it's trying to find some sort of usercommand called semshi, which I take it will mean that doesn't exist.
I don't know what semshi does or doesn't do, but you could make a usercommand like this:
if you search help for nvim_create_user_command you get this:
-- Creating user commands                           lua-guide-commands-create
-- User commands can be created through with |nvim_create_user_command()|. This
-- function takes three mandatory arguments:
-- • a string that is the name of the command (which must start with an uppercase
--   letter to distinguish it from builtin commands);
-- • a string containing Vim commands or a Lua function that is executed when the
--   command is invoked;
-- • a table with |command-attributes|; in addition, it can contain the keys
--   desc (a string describing the command); force (set to false to avoid
--   replacing an already existing command with the same name), and preview (a
--   Lua function that is used for |:command-preview|).
-- Example:
-- >lua
--     vim.api.nvim_create_user_command('Test', 'echo "It works!"', {})
--     vim.cmd.Test()
--     --> It works!
-- <
-- (Note that the third argument is mandatory even if no attributes are given.)
-- Lua functions are called with a single table argument containing arguments and
-- modifiers. The most important are:
-- • name: a string with the command name
-- • fargs: a table containing the command arguments split by whitespace (see ||)
-- • bang: true if the command was executed with a ! modifier (see ||)
-- • line1: the starting line number of the command range (see ||)
-- • line2: the final line number of the command range (see ||)
-- • range: the number of items in the command range: 0, 1, or 2 (see ||)
-- • count: any count supplied (see ||)
-- • smods: a table containing the command modifiers (see ||)
-- For example:
-- >lua
--     vim.api.nvim_create_user_command('Upper',
--       function(opts)
--         print(string.upper(opts.fargs[1]))
--       end,
--       { nargs = 1 })
--     vim.cmd.Upper('foo')
--     --> FOO
-- <
-- The complete attribute can take a Lua function in addition to the
-- attributes listed in |:command-complete|. >lua
--     vim.api.nvim_create_user_command('Upper',
--       function(opts)
--         print(string.upper(opts.fargs[1]))
--       end,
--       { nargs = 1,
--         complete = function(ArgLead, CmdLine, CursorPos)
--           -- return completion candidates as a list-like table
--           return { "foo", "bar", "baz" }
--         end,
--     })
-- <
So you could make a lua function called semshi, and then a  corresponding usercommand..
local function semshi(enabled)
-- do super duper semshi things
if enabled and enabled == true then
-- do enabled super duper semshi things
else
--do something else
end
end
vim.api.nvim_create_user_command("Semshi",
function(opts)
semshi(opts.fargs[1])
end, {
nargs = 1,
desc = "Activate for epic semshi times, which are so cool, you don't even know. I do, of course. but you don't. But you're gonna.. oh man are you gonna.. ",
})
if none of that helps, it's probably my unfamiliarity showing. lol.

you need pynvim installed and python -c 'import pynvim; print(pynvim)' should print the correct path, but I also tried out semshi w/ pynvim installed globally and couldn't get it to work either way so I just disabled it
Related https://github.com/numirias/semshi/issues/74

The extra is using this fork: https://github.com/wookayin/semshi
I never used semshi. Is that still useful? Doesn't pyright do semantic tokens?

Nope, pyright doesn't support semantic tokens, MS gated that behind their Pylance extension in vscode :^)

right

I'm going to close this, since this is 100% user config of the environment which is not under control of LazyVim.
Make sure that:

you did not set vim.g.loaded_python3_provider = 0
you did not disable rplugin in your lazy.nvim config
checkhealth shows your python3 provider is working

Once you fixed all of the above, open Neovim and run :UpdateRemotePlugins.
Apart from that I can't help, sorry

Thank you all solved with :UpdateRemotePlugins!

not disabling rplugin was it for me, thank you @folke :grin:!


Feature Request: Simpler C Like Compilation Model

At Google we have a build system (Bazel) that handles the incremental compilation and distributed execution.
It would be very advantageous if we had a compilation model that was more c like.
So giving sure a command like surelog ... a.v and getting a file a.o that we could link together in a final step.

Actually after giving it much thought, I think you can already achieve this result:
Given a list of files path1/file1.sv .... pathN/fileN.sv

Generate all the Post-processed files and parse the files in parallel
a) surelog path1/file1.sv -writepp -fileunit                                                (Generate the post-processed text file and its cache)
b) surelog  -fileunit  -parseonly  slpp_unit/work/<hash_path1>/file1.sv   (Parse the post-processed text file and its cache)
...
a) surelog pathN/fileN.sv -writepp -fileunit
b) surelog  -fileunit  -parseonly  slpp_unit/work/<hash_pathN>/fileN.sv

Link everything (reloads all the files from cache and elaborates):
surelog  -fileunit  path1/file1.sv .... pathN/fileN.sv -parse (-elabuhdm)

Having an option to write the files next to the source file would be very ideal. so if you have a file a/b/c/d.sv after running both commands you would have a/b/c/d.sv.slpp and a/b/c/d.sv.slpa. If surelog could read those file first in some alternate mode that would make things really easy.

First option where let's say you have two files a/b/c1/d1.sv   a/b/c2/d2.sv from different directories and have their cache saves in respective directories then reassemble the cache from these directories looks very hard in the surelog flow.
For the 2nd option:
The link (elaboration step) is expecting all the cache files rooted in the same location. I'll verify that we can get this to work, if I can get that to work, is that acceptable?
a) surelog path1/file1.sv -writepp -fileunit -o  /a/b/c/d/cache_path
b) surelog -fileunit -parseonly slpp_unit/work/<hash_path1>/file1.sv  -o  /a/b/c/d/cache_path
...
a) surelog pathN/fileN.sv -writepp -fileunit  -o  /a/b/c/d/cache_path
b) surelog -fileunit -parseonly slpp_unit/work/<hash_pathN>/fileN.sv  -o  /a/b/c/d/cache_path
surelog -fileunit path1/file1.sv .... pathN/fileN.sv -parse   -o  /a/b/c/d/cache_path

The -cache  option does not really help, it moves where the cache is located, but not where the post-processed files are and also mangles the file names.

Another solution:
surelog file1.v   -fileunit -parse -noelab -nouhdm -nobuiltin -nocomp  (-o optional_path)
...
surelog fileN.v -fileunit  -parse -noelab -nouhdm -nobuiltin -nocomp  (-o optional_path)
surelog  file1.v ...  fileN.v -parse  (-o optional_path)
If that works, I can create an option like -sepcomp (Separate compile) that does the same as : -fileunit -parse -noelab -nouhdm -nobuiltin -nocomp

It sounds like my proposal would be hard to do. Maybe a surelog option that would merge N cache directories would be easier, that would also work for me?

@QuantamHD I sent you a meeting invite, I'm missing some information why the latest proposal would not work as-is.

Use the -nohash  #2811, it removes the hash and treats the cache as golden.
You should use the sequence:
surelog file1.v -fileunit -parse -noelab -nouhdm -nobuiltin -nocomp -nohash
...
surelog fileN.v -fileunit -parse -noelab -nouhdm -nobuiltin -nocomp -nohash
Copy over the caches in central location
surelog file1.v ... fileN.v -parse -nohash

Actually you need #2821

@alaindargelas In bazel you always need to create the files you declare as outputs. When the preprocessor makes an entire file blank it doesn't emit an slpa file in the cache which causes an error. Can we make a zero byte slpa file that surelog ignores in this case?

@QuantamHD, please add the actual command line you are using, and the input file was an empty file?

It looks like the parse cache isn't writing to the write folder.

svFileName = svFileName.parent_path().filename() / baseFileName;

Specifically this line in the ParseCache.cpp file. It's not correct under a -nohash flag

Can you either propose a fix or a concrete testcase to reproduce ?
Exact command line, sample input file

That is not legal, the preprocessor fails, there is no condition for the ifdef
Error code 1 is FATAL/SYNTAX ERROR
[SNT:PP0106] tests/ScratchPad.sv:2:6: Syntax error: mismatched input '\n' expecting Spaces,
`ifdef
^-- tests/ScratchPad.sv:2:6:.

That file might have a syntax error, but it actually happens with any file:
touch foo.sv ; surelog -noelab -nouhdm -nobuiltin -nocomp -nohash -verbose -parse foo.sv ; echo "--- EXIT CODE: $?"
[INF:CM0023] Creating log file ./slpp_all/surelog.log.

[INF:PP0122] Preprocessing source file "foo.sv".

[INF:PA0201] Parsing source file "foo.sv".

[  FATAL] : 0
[ SYNTAX] : 0
[  ERROR] : 0
[WARNING] : 0
[   NOTE] : 0
--- EXIT CODE: 1

slpp_all also looks good
find slpp_all/
slpp_all/
slpp_all/work
slpp_all/work/foo.sv
slpp_all/cache
slpp_all/cache/work
slpp_all/cache/work/foo.sv.slpp
slpp_all/surelog.log
slpp_all/file.lst
slpp_all/file_map.lst

So processing works fine, no errors are reported but the exit code is 1 for some reason.

-nohash does not work for a file on the current dir.... bug

slpa file generate is dumping all the files into the slpp_all/work directory they need to be sent to a folder representing their path.
a/b/c/d.v should result in these files
slpp_all/cache/work/a/b/c/d.v.slpp
slpp_all/work/a/b/c/d.v.slpa
Right now it results in:
slpp_all/cache/work/a/b/c/d.v.slpp
slpp_all/work/d.v.slpa

@alaindargelas This is working as intended. The only question I have is it possible to avoid reading the preprocessor cache? We know that we don't plan to change any define options once in the linking phase. This would help reduce the memory pressure on the process.

Yes, with #2863 the slpp only reloads the error/warning messages and not the bulk of the data.

@QuantamHD, with https://github.com/chipsalliance/Surelog/pull/2956
You should be able to simply call:
surelog -init
surelog -sepcomp -nohash .... file set 1 ....             \  In parallel
surelog -sepcomp -nohash ...... file set n .....          /
surelog -link -nohash    (-elabuhdm)
See README, SEPARATE COMPILATION FLOW OPTIONS
And example:
https://github.com/chipsalliance/Surelog/blob/master/tests/TestSepCompNoHash/runsurelog.sh

I think the README needs an example like that.


Fix issue where AppInsights SDK doesn't load/configure correctly

Description
A bug report came in, where logs/telemetry wasn't being shipped to AppInsights.
Upon inspecting the IServiceCollection registrations after calling AddApplicationInsightsTelemetry, we discovered that everything until (and including) these lines of registrations succeeded:
https://github.com/microsoft/ApplicationInsights-dotnet/blob/4626e3632323b741a2bd56d3d529c283cf7626c9/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs#L134
However the TelemetryClient itself was never registered in DI. In the code linked above, if there is an exception, it is (relatively silently) swallowed and registered on the event source for AppInsights.
We traced the event source in a local test app:
dotnet trace collect --providers Microsoft-ApplicationInsights-AspNetCore -- ./bin/Debug/net8.0/Altinn.App

Which could be loaded into PerfView

We see this error:
HasStack="True" ThreadID="2,558,902" ProcessorNumber="0" errorMessage="System.InvalidOperationException: This service descriptor is keyed. Your service provider may not support keyed services. at Microsoft.Extensions.DependencyInjection.ServiceDescriptor.ThrowKeyedDescriptor()
at Microsoft.Extensions.DependencyInjection.ServiceDescriptor.get_ImplementationFactory()
at Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.<>c__28`2.<AddSingletonIfNotExists>b__28_0(ServiceDescriptor o)
at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
at Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddSingletonIfNotExists[TService,TImplementation](IServiceCollection services)
at Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddCommonTelemetryModules(IServiceCollection services) at Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(IServiceCollection services)" appDomainName="Altinn.App"

Which means that AppInsights thinks that our DI container (Scrutor) doesn't support keyed services. I think that's right? Since there is an open issue on that: https://github.com/khellang/Scrutor/pull/209
This PR replaces keyed services by just injecting multiple services, and introducing a second marker interface to distinguish between them instead.
Other options:

Use a different DI container (for example the built in one), which supports keyed services right now?
?

Related Issue(s)

N/A

Verification

[x] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[x] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

We can probably also just register AppInsights earlier in the DI container, since the issue is provoked when AppInsights scans the registry.. https://github.com/microsoft/ApplicationInsights-dotnet/blob/4626e3632323b741a2bd56d3d529c283cf7626c9/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs#L297
But that would feel less solid


BT-531-Lot is allowed in all forms, is it correct?

Please answer my question in the previous discussion. Seems BT-531-Lot has incorrect visibility information.
Discussed in https://github.com/OP-TED/eForms-SDK/discussions/257

Originally posted by eduardsmirnov December  2, 2022
All SDK versions, including the latest one (1.4.1) make the field BT-531-Part visible in all forms (missing forbidden condition).
Is it a bug or expected behavior? It leads to the duplicated field of "Additional nature of the contract". It is also the only field with a suffix "-PART" which is allowed in all forms.

It is not an expected behavior and shall get fixed with the next release.

This was resolved in SDK 1.6.0.
Sorry we forgot to update this issue.


SIP-74 sub-proposal: Create missing APIs : Roles/Users/ row level security

Originally added under "please consider" by @amitmiran137. See SIP-74.
I think that adding new API endpoints is generally not considered a breaking change, therefore this does not need to be included in the list of 2.0 breaking changes and could be implemented any time. Amit, do you agree? Or if it truly is a breaking change, would you expand more on the idea?

I agree that this is an independent task that don't involve any breaking changes and is more an enhancement

I believe this is a lingering task from the 2.0 release process, and doesn't comprise an immediate bug or body of work that anyone's signed up for. It also doesn't sound like a breaking change that'll be carried into 3.0, so I'll just close it. If we need an Issue for this, more context on exactly what needs to be carried out would be appreciated.


Fixing end-of-file issues found by the fuzzer

What's changed
I've introduced a new test file, test/yarp/fuzzer_test.rb to exercise the snippets. These snippets all caused invalid memory access that is caught by valgrind.
You can run these tests with:
bundle exec rake test:valgrind TESTOPTS=-n/fuzzer/

I've also enabled valgrind debugging for YARP.dump similar to what has been done in YARP.parse.
The fixes here are mostly small and should be uncontroversial.
Reviewers should pay attention to ...
The commit fixing "$" at the end of a file. I've introduced a label and some gotos to unify error handling in lex_global_variable. This may violate the informal style guide and/or your sensibilities, in which case let me know and I'll change it.

@kddnewton Removed the use of goto, and also added two more fixes/commits.


Fix 356

There's too many files in this commit. I'm going to see if I can remove the ones that I don't want to commit.

I can't see any way to fix this commit. I will start over. I think I need to do a rebase or something before I submit the pull request. Except I don't know how to do a rebase that doesn't just throw all the new stuff away.


How to switch to appsettings.json via UseNlog?

https://stackoverflow.com/questions/74016396/how-to-overwrite-nlog-config-when-using-nlogaspnetcoreoptions

Maybe this tutorial can help - https://github.com/NLog/NLog/wiki/Getting-started-with-ASP.NET-Core-6
Along with this guide for using appsettings.json for nlog-config - https://github.com/NLog/NLog.Extensions.Logging/wiki/NLog-configuration-with-appsettings.json

Closing issue as resolved, due to inactivity.


switch user regex to be twtxt compliant

So I gave this a go today. I'm not sure of a better way to do it. For now, I just grab everything between the @< and > and wrap the user span around it. I wanted to capture the user but having a @<test.test.com/test.txt> is a valid mention in twtxt land. Also, if people are using the same feed in the hallway as their twtxt feed, then they may mention people not in the hallway, meaning we have no way to know their user. Therefore, I just opted for this.
This will close #171

Hold off on reviewing this for a sec, I have something else to add to it.

Hmm, personally I would prefer seeing usernames only, I thought that was the plan, but I understand your arguments too.

Yea, @kodedninja I totally get what you mean. Let me work on this a bit more. I should be able to get it that if the mention is someone in the hallway it replaces it with @username, and if not, then it will display the entire mention.


KubernetesManifest Task - Kustomize bake action should allow image replacement

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Feature
Enter Task Name: KubernetesManifest@0
Environment

Server - Azure Pipelines
Agent - Hosted

Issue Description
Kustomize bake action should allow image replacement like the Helm bake action allows overrides.
I want to be able to use Kustomize's image substitution to update image tags without having to use a deploy action. Notation can be just like the deploy action, aka:
containers: |
      nginx: 1.7.9
      my-repo/image: some-new-tag

@strikeout We allow image substitution with Helm because it provides a --set flag that enables overriding values. However, there's no such flag with kustomize.
It would be a cleaner solution if the tool itself provided such an option. It makes sense to have artifact substitution in deploy action but I'm not sure if that feature should be ported here as well.
@azooinmyluggage @ds-ms What are your thoughts about this?

After discussing with @ds-ms and @azooinmyluggage, it looks like a better way of variable substitution for very specific use cases like these would be using another task in the pipeline, instead of adding the artifact substitution logic here.
@strikeout You can find tasks on Azure DevOps marketplace that can be used in the pipeline to replace the image. I found this task which may be helpful to you: https://marketplace.visualstudio.com/items?itemName=jakkaj.vsts-yaml-writer&ssr=false#overview

It would be a cleaner solution if the tool itself provided such an option. It makes sense to have artifact substitution in deploy action but I'm not sure if that feature should be ported here as well.

**Kustomize does infact support the mentioned option via kustomize edit set image. **
Quoting the manual:
Usage:
  kustomize edit set image [flags]

Examples:

The command
  set image postgres=eu.gcr.io/my-project/postgres:latest my-app=my-registry/my-app@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
will add

images:
- name: postgres
  newName: eu.gcr.io/my-project/postgres
  newTag: latest
- digest: sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
  name: my-app
  newName: my-registry/my-app

to the kustomization file if it doesn't exist,
and overwrite the previous ones if the image name exists.

The command
  set image node:8.15.0 mysql=mariadb alpine@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
will add

images:
- name: node
  newTag: 8.15.0
- name: mysql
  newName: mariadb
- digest: sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
  name: alpine

to the kustomization file if it doesn't exist,
and overwrite the previous ones if the image name exists.

@strikeout kustomize edit set image is a way to edit the kustomization file. It's purpose is not to override values the way --set does in helm, but to update the kustomization file with given values. This could be used a workaround though.
@ds-ms What do you think? One more problem with this approach is that we are using kubectl kustomize in our task which does not support this command. We'll need to modify the code so that kustomize is downloaded first and then this command is executed.

@strikeout Had a discussion with the team on this. It seems better to use a common solution of image substitution for all the methods of bake action, instead of using tool specific ways. So, we'll port the image substitution code for this use case.


Add Feature to Edit images

Add some features to edit the images like crop, rotate, filter etc.

I want to work on this issue under JWOC

I want to work on this issue under JWOC

I want to work on this issue under JWOC


Getting NULL pointer error while import

Getting NULL pointer error while i

mport

What plugins were selected?
Have you checked that you can open repositories listed inside, like
https://github.com/Enide/Eclipse-bootstrap-e4/blob/master/Eclipse-bootstrap-e4.p2f#L58

Sorry , perhaps due to proxy or Firewall my eclipse is not able to access the mentioned repository.

Closing the issue , but I would request you to add some sensible error message so that user can understand what is wrong .

This is Eclipse feature, this repo just holds .p2f file


rancher2 CLI - should support environment variable for cli2.json config file path

Currently the cli2.json file is hard-coded to the user home directory (see : https://github.com/rancher/cli/search?q=cli2.json&unscoped_q=cli2.json)
For our use case, we tend to have multiple environment we managed in v1.6 in different folders, with a bash script overwriting the required environment variables for login. This allows us to simultaneously interact with multiple environments without "logging in and out" of contexts.
A rather hackish work around that I do now with a bash script
export HOME="$WORKDIR";
./rancher "$@"

Where it will take the current configured WORKDIR/.rancher/cli2.json file instead.
Ideally it should be something like this instead
./rancher --config="./cli2.json" "$@"

This would be great. The fixed config location is a PITA for using the Rancher CLI in CI workflows.

Agreed with above statement. It would be good to provide an alternative using env or another json file.

This seems to have been addressed in https://github.com/rancher/cli/commit/5860516f5e866a41e45b49b50d1168a3c58b234d

This seems to have been addressed in https://github.com/rancher/cli/commit/5860516f5e866a41e45b49b50d1168a3c58b234d

@miraculixx can I confirm the syntax would be something like the following for version v2.4.11-rc2 onwards? (if so I can help close this issue)
./rancher --config="./cli2.json" <your command here>


Support for Jina Code model

What does this PR do?

We implement the modified architecture for Jina models found here
This allows us to run inference for jinaai/jina-embeddings-v2-base-code, a long context code embeddings model.
IMPORTANT CAVEAT
The way the models are currently loaded in the repo uses the model_type key found in the config.json for a given model. The way the Jina models are currently loaded is a bit hackish as we use Alibi position encoding to route to the JinaBertModel architecture rather than the BertModel architecture.
In the case where different models have the same model_type key (e.g. "model_type": "bert") and have "position_embedding_type": "alibi", they get routed to the JinaBertModel architecture at startup.
To get around this, I locally changed the model_type of the normal Jina models (e.g. jina-embeddings-v2-base-en) to jina_bert and the model_type of the Jina code models to jina_code_bert.
This enables me to properly load the models locally, but it is obviously not a clean solution that would enable someone to plug in the embedding models without changing the config files.
A more robust way of loading the different model architectures would be necessarily in order to properly support this new implementation
Fixes #270
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[x] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@OlivierDehaene

I'm not sure why we are dim3 in the flash implementation though. We should always be dim2 (concatenanted ids, hidden_dim). Can you check if there is an added dim somewhere for some reason?

I will merge this branch in a dev branch and modify the few nitpicks above to make this PR part of today's release.
I hope you don't mind. Of course you will be credited for the PR!
Thanks again for the hard work!

I will merge this branch in a dev branch and modify the few nitpicks above to make this PR part of today's release.
I hope you don't mind. Of course you will be credited for the PR!
Thanks again for the hard work!

Not a problem at all. Thanks for helping!


java.io.IOException: Connection reset by peer

My websocket server always receives an exception when I use spring cloud gateway
to proxy my websocket:  java.io.IOException : Connection reset by peer, and close my session.but without spring cloud gateway my server  works ok。
version:2.1.0
config:
- id: aaa-ws
            uri: lb:ws://aaa-ws
            predicates:
            - Path=/aaa/websocket/**
            filters:
            - StripPrefix=1

I might find the problem:
io.netty.handler.codec.CorruptedFrameException: Max frame length of 65536 has been exceeded.
I will try to lager the size.

Great! Please keep us updated.

I also want to be bigger than this size. What should I do

I solved it.


[bootstrap] Remove llbuild absolute rpath when installing

Also adds an option to add rpath to libSwiftPM during installation

@swift-ci please smoke test


Set priorityClassName to system-node-critical/system-cluster-critical for k3s guaranteed pods

Problem: CoreDNS getting preempted by other pods
Solution: Set priorityClassName to system-node-critical/system-cluster-critical of traefik, metrics-server, local storage and coredns deployment
Signed-off-by: transhapHigsn<EMAIL_ADDRESS>

Proposed Changes
Set priorityClassName to system-node-critical/system-cluster-critical of traefik, metrics-server, local storage and coredns deployment
Types of Changes
Bug fix.
Verification

Linked Issues
https://github.com/rancher/k3s/issues/2528
Further Comments

Talked this over with the team and we're all onboard. Thanks!


used in android

hello i have a question
i can use this library in android ?
Because the library that charlieAndroidDev designed the last update for 7 months ago, it has a lot of problems

i would like to know the same


Missing text value of comments

Description
Method GetComments() does not return text value of the comments. It returns only addresses of the cells that have comments
Steps to reproduce the issue:
// load spreadsheet from file
wb, err := excelize.OpenFile(filePath)
if err != nil {
    return result, errors.Wrapf(err, "cannot open spreadsheet %s", filePath)
}

// just printf available comments
fmt.Printf("%+v \n", wb.GetComments())

Example results:
map[
    Sheet1:[
        {Author: AuthorID:0 Ref:I3 Text:}
        {Author: AuthorID:0 Ref:K3 Text:}
        {Author: AuthorID:0 Ref:M3 Text:}
    ]
]

Example of results I expected:
map[
    Sheet1:[
        {Author: AuthorID:0 Ref:I3 Text: some comment text 1}
        {Author: AuthorID:0 Ref:K3 Text: some comment text 2}
        {Author: AuthorID:0 Ref:M3 Text: some comment text 3}
    ]
]

Output of go version:
go version go1.12 darwin/amd64

Excelize version or commit ID:
Behaves the same in
"github.com/360EntSecGroup-Skylar/excelize"

as in
"github.com/360EntSecGroup-Skylar/excelize/v2"

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Mac OSX
issue-example.xlsx

Hi @gitarte, thanks for your issue. I have fixed it. Please try to upgrade the library with the master branch code.


"no-unnecessary-type-assertion" flags necessary assertion Element as HTMLElement

Bug Report

TSLint version: ^5.8.0
TypeScript version: ^2.6.2
Running TSLint via: Package script: tslint --format stylish --project tsconfig.json

TypeScript code being linted
(ReactDOM.findDOMNode(this.toggle) as HTMLElement).focus()

with tslint.json configuration:
{
"no-unnecessary-type-assertion": true
}

Actual behavior

no-unnecessary-type-assertion  This assertion is unnecessary since it does not change the type of the expression.

Expected behavior
No error. findDOMNode() returns Element which has no focus() method, subclass HTMLElement does so assertion is necessary.
The findDOMNode() definition from @types/react-dom looks like this:
declare namespace ReactDOM {
    function findDOMNode<E extends Element>(instance: ReactInstance): E;
}

Element comes from lib.es6.d.ts.

This is a duplicate of #3540
The cause and the workaround are the same for this issue.

@ajafff Thanks for the fast response! That thread explains it all and the workaround worked nicely in my case.


Update azure-sdk-build-tools Repository Resource Refs in Yaml files

Update triggered by - https://dev.azure.com/azure-sdk//internal/_build/results?buildId=3681416

/check-enforcer override

Test release using these bits


HTTP/TLSAPN challenges are not disabled when --dns is set

Hi,
I've noticed that setting --dns exec does not disable the HTTP and TLSAPN challenges, in contraction to the help:
$ ./lego --help
[...]
   --dns value                 Solve a DNS challenge using the specified provider. Disables all other challenges. Run 'lego dnshelp' for help on usage.
[...]

It still tries to listen on Port 443:
$  EXEC_PATH=/bin/true ./lego --server https://acme-staging-v02.api.letsencrypt.org/directory --dns exec --domains www.example.com run
2018/12/19 13:40:34 [INFO] [www.example.com] acme: Obtaining bundled SAN certificate
2018/12/19 13:40:35 [INFO] [www.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/qQewSSaytugQTkVMUhKfPxMRoYvJksovMyPxcMxtR_I
2018/12/19 13:40:35 [INFO] [www.example.com] acme: use tls-alpn-01 solver
2018/12/19 13:40:35 [INFO] [www.example.com] acme: Trying to solve TLS-ALPN-01
2018/12/19 13:40:35 Could not obtain certificates:
        acme: Error -> One or more domains had a problem:
[www.example.com] [www.example.com] acme: error presenting token: could not start HTTPS server for challenge -> listen tcp :443: bind: permission denied

I've worked around this for now using --exclude manually.
I suspect this was accidentally dropped in #700 when cli_handlers.go was deleted, here: https://github.com/xenolf/lego/commit/42941ccea6b431ebff203d4cb520991fb7b47951#diff-a9a3538169a51ba12c04f42346b4b1a7L148
I'll prepare a PR in a few minutes.

duplicate of #730


Implement kubertas daemonset and service.

Implement kubertas daemonset and service.

cc @Karthik-K-N

/cc @Karthik-K-N

@Rajalakshmi-Girish can you please enable prow for this repo like web hook etc?

/meow

LGTM


RT10xx Power Management: Enable RT1060 Soft Off Mode and Fixup PM API

This PR adds a soft off mode to the RT10xx Power Management API.
Additionally, it corrects the PM API function in rt10xx_power.c to
use the correct function prototype to be properly overridden.
Signed-off-by: Nickolas Lapp<EMAIL_ADDRESS>

@danieldegrasse I added a sample of using the force-power off (modeled after the example you provided). I also added support for the RT1060EVK-B since that's the board I have available to test. Please take a look and let me know what you think.

@NickolasLapp Thank you for creating the demo app- tested on an EVKB and it works for me. Could you pull the changes enabling the EVKB into another commit, and update the title of this PR accordingly? Beyond that and the CI errors, this PR LGTM to me.

Hi @danieldegrasse, I split the PR into two commits (one for adding the EVKb). I also fixed some (hopefully most) of the CI issues. Will see what's remaining when everything runs through here.

@danieldegrasse I think #44961 has landed if you don't mind removing the DNM label here. I also fixed the nxp loopback property for the uart overlay for the evk-b

@dleach02 @danieldegrasse west.yml conflict resolved, sorry about the delay--just got back from PTO.

@NickolasLapp, you comment that this PR:

Additionally, it corrects the PM API function in rt10xx_power.c to use the correct function prototype to be properly overridden.

Please add a github issue for the problem being fixed. Then add a "Fixes #" to the description above to link this PR and establish traceability. This release cycle is in feature freeze mode.

@NickolasLapp, you comment that this PR:

Additionally, it corrects the PM API function in rt10xx_power.c to use the correct function prototype to be properly overridden.

Please add a github issue for the problem being fixed. Then add a "Fixes #" to the description above to link this PR and establish traceability. This release cycle is in feature freeze mode. Doing this will also not dismiss any positive reviews.

@dleach02 the mentioned issue was already resolved in https://github.com/zephyrproject-rtos/zephyr/commit/99be4358afcca4346acfa79fbf92286a6d934af0 (and is no longer in this PR as this PR was rebased on main). I've updated the description of this PR to indicate that it only adds support for the soft off mode for NXP parts, and adds a sample demonstrating this usage.


Ohh... so many bugs guys!

1 - if you try to change IKbone "BEND" to Positive, your animation will ignore a IKbone offset.
2 - Slots ordering don't works in animation.
Who did this plugin? Is anyone tested it before upload on github.

Well then, do a pr

I did it.


Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods

Fixes https://github.com/flutter/flutter/issues/144244.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman friendly ping


Suggest to use HttpClientFactory and about the design of HystrixCommand

HttpClientFactory is a great design in .NET Core 2.1, I see it is used in Discovery Sample but no in CircuitBreaker Sample (Fortune-Teller-UI).
Therefore, suggest to use it in CircuitBreaker Sample too because it can help us create and manage HttpClient well so we no need to care the lifecycle of HttpClient.
In CircuitBreaker Doc and Sample, I never see a HystrixCommand sample code on calling another API with parameter(s) like the dest API Uri like http://xxxx/api/values/1000, the 1000 is a parameter.  Is there any plan to override one method for ExecuteAsync with one parameter (eg.object userState) in HystrixCommand or HystrixCommand? And it is better to pass it to RunAsync and RunFallbackAsync method.
If no this design, we only can put the parameter in class level like below, and it might be possible that some multi-thread problems happens in some special scenario.

    public class ClientServiceCommand : HystrixCommand<string>
    {
        IClientService _clientService;
        ILogger<ClientServiceCommand> _logger;
        private int _clientId;

        public ClientServiceCommand(IHystrixCommandOptions options, IClientService clientService,
            ILogger<ClientServiceCommand> logger) : base(options)
        {
            _clientService = clientService;
            _logger = logger;
            IsFallbackUserDefined = true;
        }

        public async Task<string> GetClientName(int clientId)
        {
            _clientId = clientId;
            return await ExecuteAsync();
        }

        protected override async Task<string> RunAsync()
        {
            var result = await _clientService.GetClientName(_clientId);
            _logger.LogInformation("Run: {0}", result);
            return result;
        }

        protected override async Task<string> RunFallbackAsync()
        {
            _logger.LogInformation("RunFallback");
            return await Task.FromResult("Sorry, the service is unavaliable now. Please try again later.");
        }
}

Can you please help to advise?

Hi @EdisonChou,

You're right, HttpClientFactory is great and should generally be used - however, we didn't update all of our samples to use it in order to leave a working example of not using it
We have some circuit breakers in the Music Store that might help you out https://github.com/SteeltoeOSS/Samples/tree/dev/MusicStore/src/MusicStoreUI/Services/HystrixCommands

Can you define any specific examples that would demonstrate the multi-threading problem?

It looks like this issue has grown quite stale (sorry we didn't get back to you in a reasonable time) and Hystrix has entered maintenance mode. If there is any further discussion desired, it should probably happen in https://github.com/SteeltoeOSS/Steeltoe rather than the Samples repo


Find all conflicts in one round

Changes:

Find all dependency conflicts in one round by caching all NoCandidateFound until the end of the round

Contributor checklist

[x] Provided the tests for the changes.
[x] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[ ] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

The legacy resolver is deprecated and will be removed later. Which is why we accept only bug fixes. Thanks for the PR anyway!


Value not accepted, doesnt find the integration

Hello,
I tried to do everything like the instructions, I hope for your help what I did wrong.

I also installed it now via Hacs and tried the debugger, same result

Same issue here!

I also installed it now via Hacs and tried the debugger, same result

how have you installed it through HACS? I've searched for it there but couldn't find it

I also installed it now via Hacs and tried the debugger, same result

how have you installed it through HACS? I've searched for it there but couldn't find it

you can install custom-integrations through HACS

for completion, an image of my situation as well

@Untiring did you fixed it by now?

@Untiring did you fixed it by now?

sadly no. wouldn't know how - im pretty novice on the whole HA thing

@mpralle I've just discovered that the curtains are recognized, although the configuration still shows the errors.

I saw in the logs that it did get data from the curtains, so i seached for them in the entities tab and there they are:

just select both and enable them. now you can set their position by using the slider seen in the first screenshot

thank you for the quick help, as you written, the error is still there, but it works fine :D

it's missing a hacs.json like this or this
So accepting #11 would prevent this error.


GitLab screenshot and url update on repositories

type: update
status: pending
location: kubefirst/gitlab-repositories.md
Acceptance criteria:
AC1: there is a new introduction to what are the GitLab repositories
AC2: there is a screen shot of the 1.9 GitLab repositories
AC3: add screenshot of Metaphor frontend
AC4: file references matches

https://github.com/kubefirst/kubefirst/pull/391


[dps-nft-strategy-nova] Add dps nft stratey nova

Fixes # .
Changes proposed in this pull request:

add new strategy for nova network
created a pull request for adding nova network if you can take a look

yeah, the test cases are falling, because nova network is not in your supported networks list. I've added the network and I'm waiting for a reply for my PR


Cherrypick Keras DTensor related updates into keras 2.9

PiperOrigin-RevId: 438858608
PiperOrigin-RevId: 439676157

@fchollet and @mihaimaruseac for visibility

Note that the test failure was expected (since the job was configured to run with tf-nightly PIP), and the recent breakage of cl/439357690


Ignore whitespace when diffing

the second problem is format option (take off all spaces) that make this script difficult to use as it is making doubts about modifications made on unknown client's profile.
Example: I changed only one column but script let me know that 4 others column was changed. The only difference is format of columns and not data itself. Can we take off formatting of columns when cloning rows?
(Or format all columns for all clients once for all and keep the rule to have only one formatting: this seems better option but more ambitious as difficult to apply in practice for long term)

Above requested by @pfirsowicz


Update scraper for India

Location name
IN
Source URL
https://www.mohfw.gov.in/dashboard/index.php
Notes/comments
Now has a new site with some JSON embedded in it

I see the data passed to the visualization, but where is the JSON?

It's deep in the JS...

I see the data passed to the visualization, but where is the JSON?

https://www.mohfw.gov.in/dashboard/data/data.json

Is this still an issue? What is the diff vs prod?


Draft: Add "resolve_types" argument to define()

Fixes: #1286
Summary
Add resolve_types kwarg to define() to allow it to automatically resolve the class' fields types.
This is atm just a PoC to evaluate if this is going into the right direction. What do you think, @hynek ?
Pull Request Check List

[ ] Do not open pull requests from your main branch – use a separate branch!

There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
This is not a pre-requisite for your pull request to be accepted, but you have been warned.

[ ] Added tests for changed code.
Our CI fails if coverage is not 100%.
[ ] New features have been added to our Hypothesis testing strategy.
[ ] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[ ] ...and used in the stub test file tests/typing_example.py.
[ ] If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.

[ ] Updated documentation for changed code.

[ ] New functions/classes have to be added to docs/api.rst by hand.
[ ] Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.

[ ] If something changed that affects both attrs.define() and attr.s(), you have to add version directives to both.

[ ] Documentation in .rst and .md files is written using semantic newlines.
[ ] Changes (and possible deprecations) have news fragments in changelog.d.
[ ] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

typing is @Tinche territory ;)

What's the exact use case here?
A couple of notes:

On 3.14 we likely won't need resolve_types any more
If resolve_types can be called immediately (no forward refs), the consumer of the annotations can call it if they see a string annotation - the producer shouldn't need to worry about it

This is purely for convenience. I also implemented this in the Typed Settings' settings decorator (MR, fixup).
So I don't really require it for TS but I was wondering if this might improve convenience for other users / use cases as well.
Why won't this be needed on py314 anymore?  I thould that annotations would allways be "unresolved strings" in a future Python version and that thus, resolve_types() would be even more important?


React router vhost

Hello,
Currently i've creating a web app based on express js rest api and react js with react-router-dom.
And I wonder about creating vhost for user panels. My current routes:
- users
- users/:username

Its option to create routes like: username.myfancydomain.xom?
Regards!

React Router has nothing to do with domain settings.


docs: Update GHA workflow timeout to 35 days

[x] depends on https://github.com/iterative/cml/pull/1067

When I was reading up on this change, I noticed that GitHub lists a 6 hr limit for a job and a 35 hr limit for an entire workflow, I couldn't find any information for a job limit applying to self-hosted runners.
Should we include a link back to the GitHub docs for the limits?

What we've linked back to in the docs states the following:

Workflow run time - Each workflow run is limited to 35 days. If a workflow run reaches this limit, the workflow run is cancelled. This period includes execution duration, and time spent on waiting and approval.