RC2 Mvc not discovering controller in netcoreapp

I am having an issue where my controller is not being detected by Mvc in my barebones web app. The code for this problem can be found at https://github.com/awec/WeirdRC2Mvc. Also available at https://gist.github.com/awec/c4cb7be9dffdc5a0e29b813743628878 for easier reading.
I'm using VSCode (VS is not installed on this machine) and dotnet cli. I've installed RC2 and Preview 1 of the sdk (dotnet --version is 1.0.0-preview1-002702).
Other people who have looked at this issue report that it works in VS, however they also can repro the issue outside of VS (i.e. using the cli) on their machines (including non-Windows machines).
Repro steps:

dotnet restore -> no issues
dotnet run -> no issues
http://localhost:5000 -> 404
http://localhost:5000/Home/Index -> 404

Expected: exception to be thrown (exception purposefully thrown in controller constructor to demonstrate the controller isn't being initialized).
The trace logs show:

dbug: Microsoft.AspNetCore.Routing.RouteBase[1]
Request successfully matched the route with name 'default' and template '{controller=Home}/{action=Index}/{id?}'.
dbug: Microsoft.AspNetCore.Mvc.Internal.MvcRouteHandler[3]
No actions matched the current request

Things I have tried:

Adding an int id parameter to my action method to make sure the {id?} portion of the default route wasn't causing a problem
Renaming the controller from HomeController to Home
Moving the controller into a .Controllers namespace
Moving the controller class out of the Controllers folder
Explicitly adding the route in UseMvc instead of UseMvcWithDefaultRoute.

I definitely have the correct URL (localhost:5000) because I can get responses outside of MVC.
As far as I can tell my controller meets the requirements for discovery from https://github.com/aspnet/Announcements/issues/165

@awec you need to add "preserveCompilationContext": true to your buildOptions in your project.json. Without this we don't don't know what assemblies to consider as part of your application.
Example here: https://github.com/aspnet/Mvc/blob/dev/samples/MvcSandbox/project.json#L5

Also tried that, made no difference.

@rynowak  You don't need it unless your're compiling razor views

/cc @javiercn

Update: this works if I add a reference to     "Microsoft.AspNetCore.Mvc.Core": "1.0.0-rc2-final".
Is this expected? I don't see that package listed in the StarterWeb template for example at https://github.com/aspnet/Templates/blob/dev/src/BaseTemplates/StarterWeb/project.json

So um, this actually is caused by the lowercase in in Microsoft.Aspnet.Mvc (should be AspNet).
Surely dotnet restore should be complaining about this? And how did it build given I am using Mvc classes?

We're treating library names (nuget package \ project names) which are generally case insensitive as assembly names. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultAssemblyPartDiscoveryProvider.cs#L17 needs to change to be ordinal ignore case.

The weird thing is that this seems to work on the full .NET framework. I just changed the project.json to this and it worked:
{
  "version": "1.0.0-*",
  "buildOptions": {
    "emitEntryPoint": true
  },
  "dependencies": {
    "Microsoft.AspNetCore.Server.Kestrel" : "1.0.0-rc2-final",
    "Microsoft.AspnetCore.Mvc": "1.0.0-rc2-final",
    "Microsoft.Extensions.Logging": "1.0.0-rc2-final",
    "Microsoft.Extensions.Logging.Console": "1.0.0-rc2-final"
  },
  "frameworks": {
    "net46": { }
  }
}

Might be an issue with how the deps file is contructed. Regardless, NuGet treats package names (for most parts - https://github.com/NuGet/Home/issues/2522) as case insensitive and we should follow suit.

@pranavkm do we still need to do a fix in MVC then?

I'm trying to understand this cause I'm curious. In this case:

dotnet restore -> this is case insensitive (correctly) so my lowercase 'n' still results in the correct package being downloaded
dotnet build -> this is case insensitive (correctly) so my project builds and runs
mvc code -> at runtime it fails to detect the mvc dlls because the code for detecting the MVC packages is case sensitive

Have I understood this correctly?
In that case, should calling UseMvc and then have no Mvc packages being detected not result in some sort of exception? Or is silent failure of middleware the expected result (ignoring the whole case sensitivity thing for a moment) ?

@Eilon - we should. Restore from a feed is case insensitive. We're trying to match library names (which are case insensitive) and not assembly names (which are case sensitive).
@awec - at startup, Mvc attempts to look up assemblies \ components that reference any of the Mvc packages. The idea is to limit controller \ view component \ tag helper discovery to only those assemblies that have directly or transitively referenced Mvc. It might be useful to throw an exception later on (maybe when we're building the ApplicationModel) and cannot find any controllers. cc @rynowak \ @javiercn for throughts on this.

@pranavkm I don't understand very well the difference between Library vs Assembly names. I believe that the output in the .deps file should always have the correct casing, independently of whatever the user put in his project.json. The generated .deps file shouldn't change based on the casing the user uses on project.json

I've just been hit by the general issues of which assemblies are searched for controllers. The net effect was that by migrating to RC2, none of my API controllers was ever reached.
Most importantly: My assembly reference had the correct casing, so changing the HashSet's StringComparer in DefaultAssemblyPartDiscoveryProvider.ReferenceAssemblies wouldn't have fixed my issue.
I was actually bitten by the fact that assemblies that only transitively reference Mvc are not considered candidate libraries contrary to what @pranavkm mentioned. My main project with all the controllers itself didn't have a reference to Mvc, but a different referenced library had. So everything compiled correctly, but the RuntimeLibrary.Dependencies didn't include MVC and the check failed.
As a workaround, I added Mvc to my main project.json and the controllers were successfully discovered.


reduce binary size

Some not so important libraries are taking a rather large size.
Here are a list of the large ones.

avoid "github.com/hashicorp/raft", which depends on go-msgpack
storj.io/common/pb which seems coming from rclone
henrybear327 which seems coming from rclone

> goweight
   31 MB github.com/hashicorp/go-msgpack/codec
   23 MB github.com/go-redis/redis/v8
   16 MB github.com/aws/aws-sdk-go/service/s3
   15 MB github.com/aws/aws-sdk-go/service/iam
   14 MB github.com/Azure/azure-storage-blob-go/azblob
   12 MB runtime
   11 MB storj.io/common/pb
   11 MB github.com/Shopify/sarama
   11 MB github.com/colinmarc/hdfs/v2/internal/protocol/hadoop_hdfs
   10 MB github.com/henrybear327/go-proton-api
  9.8 MB go.etcd.io/etcd/api/v3/etcdserverpb
  8.4 MB net/http
  7.2 MB github.com/aws/aws-sdk-go/aws/endpoints
  7.1 MB go/types
  6.8 MB github.com/tsuna/gohbase/pb

One possible solution is to add build tags to avoid building with hashicorp/raft and rclone.

the binary size reduced from 95,571,392 bytes to 65,955,760 bytes with https://github.com/seaweedfs/seaweedfs/commit/7a50762b9ed05f1410a24f52571b49a25cd561eb

@chrislusf Hello, the big binary does not affect the latency of request processing?
What risks are there if I use a large binary with the full tag?

No effect.
None.

Avoid building with hashicorp/raft and rclone.

Does that mean that the rclone feature simply disappears for the end user (e.g. me)?
Only to save a few tens of megabytes (when uncompressed) on disk?
If that's the case, as a the contributor and user of this rclone feature, I strongly object to this choice.
Tons of other Go applications are well within the reach of 80-100 MB (uncompressed) on disk, and I don't think that bothers a lot of people, does it?

it looks like this full distribution is only available for linux/amd64; why is that so?
the Docker image that you maintain at https://hub.docker.com/r/chrislusf/seaweedfs/ relies on chrislusf/seaweedfs/releases/download/.*/linux_$ARCH.tar.gz" so rclone would also disappear from this image as well, and I would have to maintain my own.

which build you need?

I'm not sure what you mean by build, of if what I (as a specific individual) need is the determining factor here.
It's more like that, as a generic user of SeaweedFS (or any other software for that matter), I'd like to have consistency in the feature set that I can expect from SeaweedFS, independently of its build or distribution channel.
So should I download the, say, Linux/Mac, or x86/ARM version, I should be able to rely on the fact that SeaweedFS offers the same features. Including when it comes to "official" Docker images.
And it goes further than that, for example with Linux distributions. If package maintainers are faced with a choice of 4 flavours of SeaweedFS (combinations of large vs not large; full vs not full), what I can expect to get when I install it in my Linux distribution?
I don't know the technical details of why there already was this distinction between large vs not large builds.
But adding yet another dimension to this "build matrix" seems to lead to even more fragmentation in my opinion.


MULE Serial connection

[ ] Teensy-Teensy serial communication
[ ] Teensy-Teensy serial disconnect robustness
[ ] Remote programing

Created sample code for communication between the two teensies; haven't tested, so will try to go to Cypress and test it out early next week

Uploaded the code to each teensy separately, but when I wired them together, they "merge" their code and prints out whatever the teensy that was directly plugged into the computer is supposed to print

Teensy 1: initial sender
Teensy 2: initial receiver
Teensy 2 is able to read data from teensy 1 and print the message, but teensy 1 is currently not receiving the message back from teensy 2 after first sending it

-couldn't work on it much, but did fix message being sent multiple times
-message receiving teensy is still not sending back

-couldn't work on it much again
-still not sending back and forth


Sandboxed builds in Kubernetes

Our cluster is unprivileged for security reasons, when nix is run with --option sandbox true it creates a chroot, a cgroup and mounts some metadata from the host like /proc
In unprivileged Kubernetes I get this error:
error: while setting up the build environment: mounting /proc: Operation not permitted
let's add a feature flag for such unprivileged k8s compatibility, as giving privileges to the cluster is not an option as a security company

Now it works:
https://gitlab.com/fluidattacks/product/-/commit/c6ae3f328d22458f048cd87240cb916f65f9ca52
[OK] All nodes agree about slots configuration.
>>> Check for open slots...
>>> Check slots coverage...
[OK] All 16384 slots covered.
456:M 21 Sep 2021 17:01:30.380 # Cluster state changed: ok
[INFO] Nothing listening on port: 26379
[INFO] Done at localhost:26379


Schema awareness: can I avoid using it? How can I optimize schema.json? Can I code-split it?

Schema awareness is the most loved and hated thing for those who use URQL.
Story
As soon as the application becomes a little bigger than a simple "hello world" you need to use different queries for the same entities that you can first see as part of a list and then as a detail.
Some fields of these queries may be null but URQL cannot know this. He needs someone to "show him the way".
That someone is our GraphQL Schema.
One advantage of the awareness schema is that urql doesn't have to wait for new query data to fetch and can show the data it has already cached for that entity.
One "disadvantage" is that for some projects the schema is very large and this is a problem both for the final bundle size and for the browser's parsing time (TTI, time to interactive).
Use URQL CacheExchange without Schema awareness:

We started talking about this here

@kitten suggested a method that might work, but he also made it clear that it is not "sponsored" by the URQL team because quite rightly it is error-prone and may not make 100% sense:

See the suggested code
const maybePartial = (parent, args, cache, info) => {
  const fieldValue = cache.resolve(info.parentKey, info.fieldName, Object.keys(args).length ? args : undefined);
  if (fieldValue === null) {
    info.partial = true;
    return null;
  } else {
    return fieldValue;
  }
};

const resolvers = {
  Query: {
    todo: (parent, args, cache, info) => ({ __typename: "Todo", id: args.id })
  },
  Todo: {
    details: maybePartial
  }
};

You can see a demo here

the problem with this is that when backend server returns null values for some values Urql keeps fetching API

See the reproduction in this GIF

we are waiting for an answer to this

Document ways we can optimize Introspection Schema (if we must use it):

We talked about it here

The ideas suggested and that - if shared by the team - should be documented are:

@earksiinni proposed to remove fields like: defaultValue, isDeprecated, deprecationReason; I think it is wrong to remove them tout court; at most we could assume a default value in URQL for these fields and only then remove from the json those that are not our default. What do you think?

@kitten suggested to remove directives key from json; it works

@kitten needs to test if we can remove every type that starts with __ in schema.__types

@kitten:

There's also (if you're using an Apollo Server) some CacheControlScope and related types in your schema export, which are also superfluous

In case the internal GraphQLSchema object relies on some __* hints, which would actually be rather weird, we can likely add some code to patch it up

How to generate schema: from server or from files?

We can use the instructions here for server introspection query

or we can use this plugin for graphql-code-generator which use our *.graphql files, which is sometimes the only way you can use if you don't have the server started (and with introspection active) (maybe in CI/CD envs); today with the server way my schema.json is 30% lighter; I still have to understand why

How to load it the async way with code-splitting

I'm using Svelte, so my problem is with Svelte, but I think this is good for everyone to have it in the docs

I'm using the svelte example in your packages folder here except I'm creating a format: 'esm' in my rollup.config.js

my Rollup is already code-splitting my final bundle in chunks when I use import('./Component.svelte') in my code

What I'm having hard time doing is initializing urql asynchronously, like this:
import { initClient, dedupExchange, fetchExchange } from '@urql/svelte'
import { cacheExchange } from "@urql/exchange-graphcache";

const exchanges = [
  cacheExchange({
    resolvers: { /*... my resolvers*/ },
    schema // I need this async, something like: await import('./schema').then(result => result.default)
  }),
  fetchExchange
]

export function initURQL () {
  initClient({
    url: 'http://localhost/graphql',
    exchanges
  })
}

if I use something like
export async function initURQL () {
  const schema = await import('./schema.json').default

  const exchanges = [
  cacheExchange({
    resolvers: {},
    schema
  }),
  fetchExchange
  ]
  initClient({
    url: 'http://localhost/graphql',
    exchanges
  })
}`

and call it from App.svelte with ;(async () => await initURQL())() it gives me error:
Uncaught (in promise) Error: Function called outside component initialization

does it make sense to introduce a new async method in URQL to get schema in async way?

Thanks for your great work and your time!

I personally don't think it makes sense to async load the schema as it'd block all requests eliminating any TTI benefits. The reality is that your application with SSR will probably have a good TTFB and 10KB JSON is not going to impact this significantly.
We assume that schema awareness really pays off for larger apps with lots of interactivity, so skipping that shouldn't have a major impact apart from several loads having to happen before data is displayed, which is expected for low-interactive pages.
I think before making any assumptions we are planning to test the size of JSON schemas and how they zip. Parsing times are pretty irrelevant because JSON is extremely cheap to be parsed. Do we're mainly focusing on size here.
We can always consider the manual escape hatch as an alternative, but until then it'll go undocumented 😅

I updated the first post with a summary (from my perspective).
Here some ideas for introspection utilities:

I think we should have a utility to generate the schema from the *.graphql files and not just by calling the server (CI/CD environments).
I know we can already use codegen, but there are issues with it:

the "descriptions" are generated (I also opened this issue about it: https://github.com/dotansimha/graphql-code-generator/issues/4731 and I await)
we need to use an external tool (more dependencies, more chaos)

We can also handle (strip out) "descriptions" in our minifyIntrospectionQuery code (also useful for when you are other ways to retriev it - instead of codegen - and you can't prematurely remove descriptions from the .json file).

Everytime I use the script in docs the server gives me an answer (and therefore a file) always different from the previous call. I noticed that what changes is only the order of the information inside.
Can we sort alphabetically (or by another criterion) the final json in order to test the differences automatically (CI/CD environments)?

That's mainly other tools' responsibilities, but this is really easily accomplished (see the second helper in that package)
Agreed, PRs welcome, but for the current instructions it does work
Also not part of what we do 😅 But also possible to be added to the utility


Stacking multiple adapters in the pipeline results in confusing behavior

The reason for that is that many adapters are implemented in such a way that they learn the transformation from a source to a target domain, transform the source and pass it through the pipeline to fit the estimator (final step in the pipeline). Now, if we put multiple adapters in a row, every adapter after the first one won't see the target data.
Potential solution for this problem is to pass special flag into the selector when we create pipeline to mark if given transformation is "final" or not (i.e. it precedes the final estimator in the pipeline). Based on that, the selector can make a decision if targets should be propagated forward.

Make sure #29 is merged before working on this issue.


Consider a different glob (:_/:__) syntax

While aligning with glob (*/**) and NamedDims.jl (:_ wildcard dim) is nice, :_ and :__ are a bit hard to distinguish depending on the font setting in an editor or terminal. We might want to consider using a different symbol or maybe our keys should just be path strings reusing the glob syntax?

Path strings sound cool, although I'm wary of confusing users more by being too clever.
Either way, I think it would help to clarify the analogy to paths in the docs. A dimspath is not necessarily intuitive. So I mean, point out that a nested collection of namedtuples is analogous to a directory structure, and a dimspath is indexing that.

I wonder if one solution to :_ vs :__ is to just not use the more powerful :__ in most of our examples. I think most of our datasets could just use the :_, and we might want to make that the best practice as it minimize weird behaviours (ie: matching paths of different depths).

Path strings sound cool, although I'm wary of confusing users more by being too clever.

Yeah, that's why I liked the explicit Tuple syntax for this. I wonder if we should plan to make the Pattern code a separate package. Looks like python 3.10 might be including something similar, so it probably isn't specific to our problem.
https://www.python.org/dev/peps/pep-0622/

Either way, I think it would help to clarify the analogy to paths in the docs.

We do explicitly mention the similarity to glob pattern matching in the Pattern docstring.

Special symbols :_ and :__ are used as wildcards, similar to * and ** in glob pattern matching.

Maybe there's a better place for it, though? Or maybe we should lean harder into this idea of a TreeDict with globbing and a diagram?

We do explicitly mention the similarity to glob pattern matching in the Pattern docstring.

To me that doesn't provide the full understanding. I'm suggesting we also explain why there are these path-like objects in the first place - it's because there is this nested associative structure.


Issue 3885 document link

Fixes #{3885}
Changes proposed in this pull request:
Hi, I also encountered this problem and try to solve the problem according to my understanding. However, as I read the comments, I don't know if this problem is closed now. If it is closed, I'm sorry to waste your time to review and remind you that this problem should be closed.

This replaces #3885


Add an option to change chart tick mark type

Hello,
One of the feature which I saw was missing is to change the minor and major tick mark position for charts. For example: whether the tick marks should be inside, outside or cross axis.
Sadly, I am fairly new to development and Github in general, so I do not know how to update the documentation. Readme.md seemed only to have links to the "Adding Charts" page. So any tips or help on how to do that would be really helpful.
Regards,
Rokas

Thanks @RokasDie !
This has been added to the 3.0 codebase.


add syntaxhighlight to README

Make README more readable

Thanks for pull request. Will update other docs also.


Add specific example of a custom threat intel feed to the threat intel support documentation

Is your feature request related to a problem? Please describe.
Add specific example of a custom threat intel feed to the threat intel support documentation.
https://help.sumologic.com/docs/cse/rules/about-cse-rules/#threat-intel
Describe the solution you'd like:
Consider using the CISA feed for examples.
https://www.cisa.gov/topics/cyber-threats-and-advisories/information-sharing/automated-indicator-sharing-ais
Additional info:
This is a customer request.  GDIT is in the federal space and makes extensive use of threat intel feeds.
GDIT
Organization ID
0000000000015E9F

@kostuch-sumologic, I will make the update to this following article instead of "About CSE Rules", since it is the main article where we document threat intelligence:
https://help.sumologic.com/docs/cse/administration/create-custom-threat-intel-source/


Forms debug tool

Flake8 checked

Again mistake in commit [4279564]. Edit view func get_{app.name}

Add debug-toolbar in requirements [ce7cf82]


outputFormat is defined but never used

I noticed this when I tried to configure the stream to only produce one channel of audio, but then it kept streaming 2-channel audio.
The outputFormat is defined here:
https://github.com/noffle/mic-stream/blob/master/index.js#L22
But nothing in the micProcess function seems to derive settings from it.  In my case, being on macOS:
https://github.com/noffle/mic-stream/blob/master/index.js#L59-L66
I take it this just hasn't been implemented yet?

Aye, it was never implemented. I'd happily merge a fix if you can rig something up!


update to 2.6.0

Deployed the new code, ran the upgrade script from 2.5.12
On making a request I now get
Database migrations missing - When upgrading to a new NetBox release, the upgrade script must be run to apply any new database migrations. You can run migrations manually by executing python3 manage.py migrate from the command line.
Unsupported PostgreSQL version - Ensure that PostgreSQL version 9.4 or higher is in use. You can check this by connecting to the database using NetBox's credentials and issuing a query for SELECT VERSION().
The complete exception is provided below:
<class 'django.db.utils.ProgrammingError'>
column dcim_powerport.connected_endpoint_id does not exist
LINE 1: ...COUNT(*) AS "__count" FROM "dcim_powerport" WHERE "dcim_powe...
Checking the dcim_portport table shows no colume names connected_endpoint_id
That appears to have been from 0066_cables migration...
dcim/migrations/0066_cables.py:            termination_b_id=consoleport.connected_endpoint_id,
dcim/migrations/0066_cables.py:        ConsoleServerPort.objects.filter(pk=consoleport.connected_endpoint_id).update(
dcim/migrations/0066_cables.py:            termination_b_id=powerport.connected_endpoint_id,
dcim/migrations/0066_cables.py:        PowerOutlet.objects.filter(pk=powerport.connected_endpoint_id).update(
That migration does appear to have been applied, back when the upgrade to 2.5.12 was done I believe..
138 | dcim           | 0066_cables                                                                    | 2019-05-24 04:50:11.176777+00
Oh, and running postgresql 10.2
Any ideas?

dom ignore me, missed a step!

@benohara What step did you miss? I ran into this too and I swear I did everything this says:
https://netbox.readthedocs.io/en/stable/installation/upgrading/

Ha, found my problem too, but probably different from yours. That said, you should still put what you did wrong so others who do the same thing know what to check!
For me, I switched the install directory for this upgrade, but didn't update the gunicorn config files to reflect the new install path. Updating the referenced locations from the original install guide resolved my problem.

@benohara @JacksonWrath, I'm running into the same issue. Could you explain what you did to solve it?

You should go to the mailing list to discuss this


Image vulnerablities

The latest (4.3.9) docker image of graylog has 6 critical and 73 high vulnerabilities related to apache, minidev, fasterxml, netty, etc. Can we get these patched?

4.3.9 is also running an older version of openssl (3.0.2) affected by the recent advisory

The 4.3.9 images have package openssl @ 3.0.2-0ubuntu1.7, which has the fix.

https://ubuntu.com/security/CVE-2022-3602
https://launchpad.net/ubuntu/+source/openssl/3.0.2-0ubuntu1.7
https://changelogs.ubuntu.com/changelogs/pool/main/o/openssl/openssl_3.0.2-0ubuntu1.7/changelog

@coffee-squirrel are there plans to patch the other vulnerabilites i have shown?

@jin-ahn I'm not with Graylog, so I don't know.
It seems most/all of those are related to "Graylog the Java app" versus the container image, so you might get more traction by following the process mentioned at https://github.com/Graylog2/graylog2-server/blob/master/SECURITY.md.

Hi, just thought I'd give an update. I've checked the latest 5.0 rc2 image for vulnerabilities. and although there is an improvement the critical ones still remain. I understand that they don't necessarily apply to graylog, but if it's a low-hanging fruit, it would be great for our usage to have the libraries updated.

Hi @kroepke, just to confirm - are their still plans to patch the remaining vulnerabilites? Or are we leaving them alone?

Most recent update of 5.0.3 is vastly improved. Just 1 critical vulnerability remaining. Need to update json-smart to 2.4.1

New vulnerablities have come out that impact graylog image. I know the shiro-core doesn't apply but there are others

Hi, I notice there are updates to fix the vulnerablities, can someone also build a image and push to hub? Thanks.

@Jeffrey778 The fixed will be part of the next stable release (5.0.7) that ships beginning of May.

Hi. 5.0.6 also has new vulnerablities related to org.quartz-scheduler and org.yaml:snakeyaml
https://nvd.nist.gov/vuln/detail/CVE-2019-13990
https://nvd.nist.gov/vuln/detail/CVE-2022-1471

5.0.7 has 6 critical and 11 high vulnerabilities

5.1.0 has vulnerabilites that are high and critical

@bernd could you comment on whether or not there are plans to patch these?

5.1.1 still has same vulnerabilities

5.1.2 has more vulnerabilities

5.2.0 Vulnerabilites


Additional i18n support

Note: This PR is to accommodate requests that impact Marko components (i.e everything but the Leader's flyouts), Leaders fly outs will be modified separately as there will need to be additional considerations and support in order for translations to work within Vue components particularly in that package.

 Mundo EXPO PACK website CTAs not in Spanish


Time series data endpoint

Hello, I find your package to be pretty convenient. However, could you please add a time series endpoint?

You are better off checking the forks of this project. The last commit was in 2015.


Problems to run PyCall in WSL2

I'm running a Ubuntu 22.04.3 LTS in WSL2 and I am facing the very same issue in two different machines. When I run a ruby script to test if PyCall is working,
I've used the example provided in the README.
I recieve the same error bellow
<internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in require': cannot load such file -- fiddle (LoadError)
from internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:136:in require'         from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall/libpython/finder.rb:2:in <top (required)>'
from internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:136:in require'         from <internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in require'
from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall/libpython.rb:3:in <module:LibPython>'         from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall/libpython.rb:2:in module:PyCall'
from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall/libpython.rb:1:in <top (required)>'         from <internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in require'
from internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:136:in require'         from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall.rb:3:in module:PyCall'
from /home/rada/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/pycall-1.5.1/lib/pycall.rb:1:in <top (required)>'         from <internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:141:in require'
from internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:141:in rescue in require'         from <internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:135:in require'
from teste.rb:1:in <main>' <internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in require': cannot load such file -- pycall (LoadError)
from internal:/home/rada/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:136:in require'         from teste.rb:1:in '`
I've faced the same issue in a Ubuntu Mate 1.26.0.
Is there any specific way to run a script

Hmm, it's working for me on WSL2 ubuntu.  Care to share a sample script so I can see if it's something about what you're running?


My viewBinding not work

Hi, I've read your article about viewbinding and found it very useful. So I'm trying to write a version of mine. But it doesn't work.
This is view binding util code:
class ViewBinding<T : ViewBinding>(
    private val fragment: Fragment,
    private val vbClass: Class<T>
) : ReadOnlyProperty<Fragment, T> {

    private val message = "should never try get ViewBinding when it might not be available"
    private var _value: T? = null

    override fun getValue(thisRef: Fragment, property: KProperty<*>): T {
        _value?.let { return it }
        _value = createViewBinding(vbClass, fragment.layoutInflater)
        return _value ?: throw IllegalStateException(message)
    }

    @Suppress("UNCHECKED_CAST")
    private fun createViewBinding(clzz: Class<T>, inflater: LayoutInflater): T =
        Class.forName(clzz.canonicalName!!).getMethod("inflate", LayoutInflater::class.java)
            .invoke(null, inflater) as T

}

inline fun <reified T : ViewBinding> Fragment.mViewBinding() = ViewBinding(this, T::class.java)

And in fragment:

class LoginFragment : Fragment(R.layout.login_fragment) {

    private val binding: LoginFragmentBinding by mViewBinding()

//    private val binding : LoginFragmentBinding by viewBinding()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        with(binding) {
            message.text = "test"
            message.setOnClickListener {
                findNavController().navigate(R.id.action_loginFragment_to_mainActivity)
                activity?.supportFinishAfterTransition()
            }
        }
    }
}

Could you please help me figure it out?

not work means the message doesn't change to "test" and onClickListenner not triggered

It's because your ViewBinding delegate inflate new View and doesn't set assign to Fragment. Update of view is successful, but Fragment shows another View as content

Instead of call "inflate", true to use "bind" and get existed view from Fragment


Crash when SetString("")

If I set an empty string :
editor.SetString("");
And then I click into the Text Editor area I got an assert (aLine is wrong).

Fixed.


Tab close icon should be the same as the Chrome one

The tab close icon does not match the normal Chrome one - in particular when hovering it does not have a red circle background. Given the functionality matches that same piece of the Chrome interface, I suggest it should use the same UI style - which would remove all doubt about what the 'x' did (it wasn't particularly ambiguous, but there was a moment of hesitation).

Agree. Thanks for suggestion.


Split wrap_doc_comments out of wrap_comments

As has been mentioned a few times on #3347 it is useful to be able to treat doc-comments and normal comments differently.

@Nemo157 thanks for taking the time to put together a PR. I haven't had a chance to review this yet, but I noticed that a lot of tests needed the addition of wrap_doc_comments. I'm wondering if you considered allowing wrap_comments=true to imply wrap_doc_comments=true if wrap_doc_comments isn't explicitly set. That way the addition of wrap_doc_comments wouldn't impact users who're already used to the current wrap_comments behavior. We can technically change the behavior of unstable options like wrap_comments, but I think it would be better if we didn't.
@calebcartwright I'd also like your thoughts on this.

No, I hadn't considered that. I'm personally unsure of the usecase for wrap_comments itself, I've only ever thought the doc-comment variant was useful, so I'm not sure if that implication would be useful or annoying to people that have a usecase for it.

No, I hadn't considered that.

Got it.

I'm personally unsure of the usecase for wrap_comments itself, I've only ever thought the doc-comment variant was useful, so I'm not sure if that implication would be useful or annoying to people that have a usecase for it.

Without getting more feedback from users who already use wrap_comments=true to wrap both doc comments and regular comments I think the safest option would be to maintain the current behavior.
Still brainstorming here. I think we could alternative implement this by making wrap_comments an enum instead of a boolean option. Something like:
enum WrapComments {
    /// Don't wrap comments
    Off,
    /// Wrap all kinds of comments
    All,
    /// Only wrap doc comments
    Doc,
    /// Only wrap normal comments
    Normal
}

Then we could map true => All, and false => Off when parsing command line arguments.

Updated to use the last structure you mention, that does seem much nicer to me.

That's great! Thanks for making the change. I took a really quick look and I'm wondering if it would be possible to implement this without any proc macro changes? I know there might be a little more boilerplate, but I think it would be easier for me to review if the necessary traits were manually implemented. I hope that's not too big of an ask.
That being said, I also think the #[bool = true] and #[bool = false] attribute you're proposing could be useful in the future and I'd like to explore that idea in a follow up PR. If you're interested, could you open an issue where we could discuss what those proc macro changes might look like.

Switched to manual impls of the traits, I've pushed a commit built on top of this with the #[bool] attribute in the proc-macro to https://github.com/Nemo157/rustfmt/commit/d09761690a09a272cbcf87561b99db86146b09ec

What is this PR waiting on? It has been marked as ready to merge for several months at this point.


Update dependencies to work with Puppet v4.x, v5.x, & v6.x.

This updates the dependencies identified in issue #74 as well as obsoletes PR's #65 and #70.
Updated the Travis configuration to removed the EOL'd Ruby versions.
Added a place holder version to the change log for work currently in progress.

thank you for the PR. As you can see I don't have much time for this module anymore. Happy to give you access to the repo if you want to help out more actively.

thank you for the PR. As you can see I don't have much time for this module anymore. Happy to give you access to the repo if you want to help out more actively.

Maybe consider transferring this module to vox populi? https://voxpupuli.org

thank you for the PR. As you can see I don't have much time for this module anymore. Happy to give you access to the repo if you want to help out more actively.

Maybe consider transferring this module to vox populi? https://voxpupuli.org

I would love to see this moved into voxpupuli as well!


Something wrong with the container

Regarding an issue reported by @musicinmybrain in the Fedora-CI channel. rpminspect seems to fail inside the container, but if we manually install the packages in a fresh container the same issues do not occur:
$ podman run quay.io/fedoraci/rpminspect:43bc818 rpminspect-fedora python-pytest-freezer-0.4.8-1.fc42
emptyrpm:
---------
1) New package python3-pytest-freezer-0.4.8-1.fc42.noarch.rpm is empty (no payloads)

Result: VERIFY
Waiver Authorization: Anyone

Suggested Remedy:

$ podman run -ti fedora:latest
# dnf -y install 'dnf5-command(copr)'
# dnf -y copr enable dcantrell/rpminspect
# dnf -y copr enable @osci/fedora-license-data
# dnf -y install rpminspect-data-fedora
# rpminspect-fedora python-pytest-freezer-0.4.8-1.fc42
emptyrpm:
---------
Result: OK

I have run against fedoraci/rpminspect:43bc818 with dnf upgrade but got the same results

It seems to be related to the fedora:42 container. I've managed to reproduce it there
$ podman run -ti fedora:42
# dnf -y install 'dnf5-command(copr)'
# dnf -y copr enable dcantrell/rpminspect
# dnf -y copr enable @osci/fedora-license-data
# dnf -y install rpminspect-data-fedora
# rpminspect-fedora python-pytest-freezer-0.4.8-1.fc42
emptyrpm:
---------
1) New package python3-pytest-freezer-0.4.8-1.fc42.noarch.rpm is empty (no payloads)

Result: VERIFY
Waiver Authorization: Anyone

Suggested Remedy:


Routing is not working on clicking in Mobile view....

Is your feature request related to a problem? Please describe.
The link to different sections in navbar is not working in mobile view
Describe the solution you'd like
A clear and concise description of what you want to happen.

Additional context
Add any other context or screenshots about the feature request here.
I would love to contribute to this project

@Utsavladia this issue has been resolved now. Kindly raise some other issue.


Patient.communication.language sometimes contains invalid system

Per the FHIR R4 spec for the Patient resource, the Patient.communication.language element has a "preferred" binding with the Common Languages ValueSet, but a "required" binding with the All Languages ValueSet. Both ValueSets use the following system URI exclusively: urn:ietf:bcp:47.
However, there are 5 languages provided in Synthea's language lookup file which instead provide http://id.loc.gov/vocabulary/iso639-1 as the system URI. An example generated by Synthea:
"communication": [{
    "language": {
        "coding": [{
            "system": "http://id.loc.gov/vocabulary/iso639-1",
            "code": "vi",
            "display": "Vietnamese"
        }],
        "text": "Vietnamese"
    }
}]

Can these be changed to use the correct system URI (urn:ietf:bcp:47)?

Technically bcp47 is not a Code System, it is a ValueSet.
It does not define any of its own codes, instead it includes codes from other systems, e.g. iso639-1 which defines the "vi" code (among others).
I don't care if we update the language lookup file so that FHIR validates (assuming that it will actually fix FHIR validation), but the system in that example is technically correct (and if FHIR says it is invalid, then FHIR is wrong).
Feel free to submit a pull request with the changes, and steps to verify the changes are correct and validate properly.

@jawalonoski thanks for the quick response. After researching this a bit further, I see your point; BCP-47 doesn't define the actual meaning of the various language codes, just a best practice structure.
FHIR is definitely treating BCP-47 as a CodeSystem, though; it's provided as such in the HL7 Code System Registry.
I've asked for some clarity in the FHIR Zulip.

Well, given the resolution over at FHIR Zulip, I'm happy to take a pull request to fix this issue if you want to make a contribution.
If we don't get one in a few days we'll get around to correcting it.

Thank you for reporting the bug, investigating it, and fixing it!


Is there a way to handle "nested iFrames" in protractor.

I am using protractor to test non-angular application and in a scenario i had nested "iFrames", these iFrames are in div tag. Using protractor i was able to navigate to second iFrame, but could not read any elements on page. Let me know if you have any suggestions on this.

You have to ensure that the content of the outer is loaded before you navigate into the inner iframe. Could you provide a code example?

Hi there!
Because of it's usage/debugging nature, your question is a better fit for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


eDiscovery data location is mentioned without explanation

On the page there is a table explicitly listing 'eDiscovery data locations'
but the page does not explain what this is , notr refer to an explanation.
I suggest to add a link to a page such as the below , where this is explained :
https://docs.microsoft.com/en-us/microsoft-365/enterprise/multi-geo-ediscovery-configuration?view=o365-worldwide#:~:text=Table 1    Geo location , Europe datacenters  11 more rows

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f648e8f-a784-82d1-9495-f470330014ca
Version Independent ID: 01a84ed4-7193-093a-5926-1c91ca078693
Content: Plan for Microsoft 365 Multi-Geo - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/plan-for-multi-geo.md
Service: o365-solutions
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@Josverl Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/4380
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @Josverl Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Support more content types

From<EMAIL_ADDRESS>on January 12, 2011 14:55:50
Support verifying e.g. atom and rss as XML (e.g. when content type is application/rss+xml)
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=7

From<EMAIL_ADDRESS>on January 12, 2011 12:08:23
Status: Fixed


Doesn't compile

error[E0597]: desc_set does not live long enough
--> /home/kasia/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-core-0.9.0/src/device/mod.rs:1801:26
|
1801 |                     set: desc_set.raw_mut(),
|                          ^^^^^^^^^^^^^^^^^^ borrowed value does not live long enough
...
1822 |     }
|     -
|     |
|     desc_set dropped here while still borrowed
|     borrow might be used here, when write_map is dropped and runs the Drop code for type BTreeMap
|
= note: values in a scope are dropped in the opposite order they are defined
error: could not compile wgpu-core due to previous error
rustc 1.65.0 (897e37553 2022-11-02)

Hey. I just upgraded the dependencies, could be that dependabot borked it up and I didn't check after. It compiles now (Rust 1.68.2).

Hmm, maybe it's time to upgrade Rust? Because while it progresses past that, it still doesn't compile:
Compiling clap v4.2.1
error[E0432]: unresolved imports clap::AppSettings, clap::Clap
--> examples/swt.rs:1:12
|
1 | use clap::{AppSettings, Clap};
|            ^^^^^^^^^^^  ^^^^ no Clap in the root
|            |
|            no AppSettings in the root
error: cannot determine resolution for the derive macro Clap
--> examples/swt.rs:10:10
|
10 | #[derive(Clap)]
|          ^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error: cannot find attribute clap in this scope
--> examples/swt.rs:11:3
|
11 | #[clap(version = "0.1", author = "Markus Mayer widemeadows@gmail.com")]
|   ^^^^
|
= note: clap is in scope, but it is a crate, not an attribute
error: cannot find attribute clap in this scope
--> examples/swt.rs:12:3
|
12 | #[clap(setting = AppSettings::ColoredHelp)]
|   ^^^^
|
= note: clap is in scope, but it is a crate, not an attribute
error: cannot find attribute clap in this scope
--> examples/swt.rs:15:7
|
15 |     #[clap(short, long)]
|       ^^^^
|
= note: clap is in scope, but it is a crate, not an attribute
error: cannot find attribute clap in this scope
--> examples/swt.rs:19:7
|
19 |     #[clap(short, long)]
|       ^^^^
|
= note: clap is in scope, but it is a crate, not an attribute
error: cannot find attribute clap in this scope
--> examples/swt.rs:23:7
|
23 |     #[clap(validator(file_exists))]
|       ^^^^
|
= note: clap is in scope, but it is a crate, not an attribute
error[E0599]: no function or associated item named parse found for struct Opts in the current scope
--> examples/swt.rs:28:28
|
13 | struct Opts {
| ----------- function or associated item parse not found for this struct
...
28 |     let opts: Opts = Opts::parse();
|                            ^^^^^ function or associated item not found in Opts
|
= help: items from traits can only be used if the trait is implemented and in scope
= note: the following traits define an item parse, perhaps you need to implement one of them:
candidate #1: Parser
candidate #2: TypedValueParser
candidate #3: nom::internal::Parser
candidate #4: nom::sequence::Tuple
candidate #5: ttf_parser::parser::FromData
candidate #6: ttf_parser::parser::FromSlice
candidate #7: ttf_parser::ggg::lookup::LookupSubtable
candidate #8: ttf_parser::ggg::layout_table::RecordListItem
Some errors have detailed explanations: E0432, E0599.
For more information about an error, try rustc --explain E0432.
error: could not compile stroke-width-transform-rs due to 8 previous errors

Ah, no, you are absolutely right, I did not check on the example. Give me a bit, I'll look into it.


[FR]: Proxy settings

Description

Add the ability to proxy every request to api
Can't find how it can be done right now
Idially it should be something similar to the Android version
System.setProperty("https.proxyHost", "x.x.x.x"); System.setProperty("https.proxyPort", "nnnn"); System.setProperty("com.google.api.client.should_use_proxy", "true");

API Proposal
No response
Firebase Product(s)
Database

Partial duplicate of #11858.


Restore 'add to collection' functionality

On the ds_place.html page (published dataset), the righthand column of checkboxes is the 'add to collection' feature for place collections (this option also appears in Place Portal pages). The action can be viewed in v2 :

click a checkbox and a link text item fades in, and as the user clicks more the count increments and the record place id (Place.id) is added to a list, checked_rows[]:

when the user clicks the add to collection link, a popup appears, list their PlaceCollection objects
they can choose one of their collections, or create a new one on the fly (all that's needed is a title)
the added places now appear in their place collection builder, in the div #coll_placelist

All of the elements (JS, htm, cssl) seem to be still around, but not finding each other. I know how this used to work, but unable to efficiently navigate the new webpack config to restore it.
There is similar functionality in v2 on Place Portal pages, but in the redesign, the option (radio buttons in this case, not checkboxes) was not added to the attestation cards but is now stubbed in on staging as of 7 Jan.

Once the functionality is restored in ds_place.html, reassign to @kgeographer for place_portal.html

appears fixed, closing


docs: vite wasm configuration

I tried using pglite with vite and I hit a wasm error. After some research I found the solution here.
Since I think a lot of devs will use vite to try pglite, this PR adds info about the vite configuration necessary to run pglite.

Hey @SandroMaglione
Thanks for this PR and the nudge to add this to the docs. I've forked this PR to #283 and broken your addition into a separate page which we can extend with other bundler docs. We will get that merged later today (your in the history of the new PR and so will be marked as a contributor by GitHub)


Added support for plugin authentication using Github OAuth App.

Is your feature request related to a problem? Please describe.
Yes, I am currently using the gh cli for GitHub authentication, but it is difficult to authenticate because the Steampipe GitHub plugin does not support OAuth tokens (gho_xxx).
https://steampipe.io/changelog/turbot-github-plugin-v0-40-0
Describe the solution you'd like
I would like the GitHub plugin to support tokens (gho_xxx) generated by OAuth Apps. Specifically, this can be addressed by updating the token validation logic.
https://github.com/turbot/steampipe-plugin-github/blob/main/github/utils.go#L76-L80
Describe alternatives you've considered
I can use other auth methods. (GitHub App or PAT)
Additional context
Authentication via OAuth has been made possible as seen here, but it is currently unusable due to the existing token validation. The relevant code can be found here. The issue can be resolved with just an update to the validation, and I am willing to participate in the implementation.

Hi @HikaruEgashira,
We have raised a PR by addressing this issue.
We have added support for an OAuth access token for GitHub authentication.
It would be great if you would like to give it a try in the PR branch(issue-431) and share your feedback.
Testing Steps in the PR Branch(issue-431):

Clone the repository: git clone https://github.com/turbot/steampipe-plugin-github.git
Navigate to the directory: cd steampipe-plugin-github
Switch to the issue-431 branch: git checkout issue-431
Execute make
Run your query.

If you are running into any further issues, please feel free to let us know.
Thanks!

Thanks! Commented your PR.


Why texture changes frequently in GAN training?

Hi. Have you ever noticed that the detail or texture always changes frequently during training GAN? If yes, why???

Hi @BaiYu0120
In the beginning, the textures change frequently.
As the training goes, the results converge and the textures will be more stable among iterations (may also because of a smaller learning rate).

I also found that when the learning rate drops to a very small level, the textures will be stable. But what I worried about is the time when to decay learning rate. Due to texture changing frequently at beginning, sometimes it decay after a good texture, the texture will be stable on a good level. Sometimes it decay after a bad texture, the texture will be stable on a bad level...
How can I control it, do you have any suggestion?

Hi, @BaiYu0120
From my experiments, the network always produced good-looking textures (though there are artifacts sometimes, they are more likely from GAN training). Because when the learning rate decreases, the optimization updates will further "refine" the textures, even it falls into a "bad" point. There are not only two states - learning and maintaining the previous results. The model is learning all the time as the learning rate decreases.
You can imagine a general optimization example, where there are local optima and global optima. At the beginning when the learning rate is large, it jumps from here to there and the losses also shake a lot. You may worry what if the model loss is accidentally large at the moment when the learning rate decreases. I do not think the model will then maintain such a large loss with further training of a small learnig rate.

Thank you, @xinntao. I undersand.

@xinntao
Hello, I have a question to ask you, my dataset is not very dependent on textures. I want to reduce the effect of controlling texture in ESRGAN. How can I achieve this?


"0x8a15005e : The server certificate did not match any of the expected values." when trying to search on msstore with winget 1.4

Brief description of your issue
I'm trying to search for a software on msstore specifically with winget 1.4.10173 and I get this error message :
Failed when opening source(s); try the 'source reset' command if the problem persists.
An unexpected error occurred while executing the command:
0x8a15005e : The server certificate did not match any of the expected values.
Steps to reproduce

winget search 7zip -s msstore
winget source reset:
"The following sources will be reset if the --force option is given:
Name    Argument

msstore https://storeedgefd.dsx.mp.microsoft.com/v9.0
winget  https://cdn.winget.microsoft.com/cache"
3. I opened https://storeedgefd.dsx.mp.microsoft.com/v9.0 in Edge to check if URL was reachable and I got this:
"This XML file does not appear to have any style information associated with it. The document tree is shown below.

No HTTP resource was found that matches the request URI 'https://useast.storeedgefd-origin.xbetservices.akadns.net/v9.0'.
"
Expected behavior
I would expect to see the available software on the Microsoft Store listed
Actual behavior
Failed when opening source(s); try the 'source reset' command if the problem persists.
An unexpected error occurred while executing the command:
0x8a15005e : The server certificate did not match any of the expected values.
Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1105
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

@sgrienen thanks for reporting this.
If you call one of the defined endpoints you will get a more useful/meaningful response.
https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
Here is the applicable code for the REST API (latest Swagger document)
https://github.com/microsoft/winget-cli-restsource/blob/da3300c19eff2f5d7378bb8bfc47800d056af23d/documentation/WinGet-1.4.0.yaml#L548-L565
If you use https://editor.swagger.io/ and upload the contents of the API Document you will see a more user-friendly view of the API.

I encountered this same error this morning.  In my case, my traffic to both the winget and msstore sources was being decrypted/reencrypted by our Palo Alto firewall as part of its SSL inspection feature.  Our PKI is properly configured, so certificates issued by the firewall are valid and trusted on my machine itself, but it seems winget is sensitive to any tampering (legitimate or not) with the certificate from the msstore endpoint.  Adding a SSL inspection bypass for the msstore endpoint URL resolved this issue in my environment.
I'm not sure when this certificate sensitivity was introduced into winget as I have not encountered this error in the past.  Also of note, SSL inspection is currently running on the winget source's URL, and everything is working correctly, so this seems limited to just the msstore source.
Please let me know if any additional information would be useful.  I don't have a ton of experience contributing to projects like this, but I did want to leave a comment when I realized the same problem I was having was sitting in a day old issue.

@jadodd,
Thanks for the information! Yes, we recently introduced certificate pinning for the Microsoft Store source in the latest release. It was also present in some earlier preview releases, but this is the first report I've seen.

So, what would be a solution for networks with SSL inspection that replaces the certificate? Maybe an ignore-certificate flag?

Based on the pull request that added certificate pinning here: https://github.com/microsoft/winget-cli/pull/2347

An admin setting is added to disable pinning, both as an emergency measure in the event that there is a bug or rolled certificate that was not communicated, but also because there are test scenarios where the user actively wants to disable it (HTTPS redirection via something like Fiddler).
The configuration can be loaded from JSON for future dynamic configuration, but it is currently only as a test hook to enable configuration via Group Policy.

By poking around the commits from that PR, it looks like the overall goal is to have this configurable via group policy and JSON locally, but only the GPO option appears to be written.  I'm not sure exactly how  the group policy configuration is intended to work, but perhaps someone with some more insight into winget's workings and related group policies could shed some light.
On the more philosophical front, I believe the most user-friendly way to bypass pinning while maintaining at least some of the protection cert pinning is meant to achieve would be to add a flag such as --use-system-cas or --trusted-CA-file that would instruct winget to trust certificate chains from the system certificate store (how normal certificate validation is done) or to provide a specific CA certificate to trust.

I love it when I manage to answer my on question about a minute after typing a reply.  Changes to the ADMX to support disabling certificate pinning for the Microsoft Store were committed in https://github.com/microsoft/winget-cli/pull/2637  That commit was included in the 1.4.10173 release, I just missed seeing it in the release notes.
For the lazy and anyone who may end up here via Google:

You really should use the ADMX template and apply this setting via group policy if you need this to be done on more than one machine.  Group policy can be your friend if you let it.
If you just need this to work on your machine and would rather just sledgehammer it with regedit, then create a DWORD named EnableBypassCertificatePinningForMicrosoftStore with a value of 1 at the path HKLM\Software\Policies\Microsoft\Windows\AppInstaller  Note that this information is only current as of the PR linked above and may change at any time.  Always consult current documentation if possible.

Some additional information:
The certificate pinning for the "msstore" source was put in place as an additional security measure to ensure your machine is actually talking to the "msstore" source. Disabling this check increases the potential risk of a MITM attack.

I would expect an urgent fix to allow a list of trusted CAs for Winget.
On a side note, this SSL inspection feature is a pain. There's no standard configuration across applications and tools to configure trusted CAs. In my computer I have REQUESTS_CA_BUNDLE for Azure CLI, GIT_SSL_CAINFO for git, NODE_EXTRA_CA_CERTS for node and the multiple Java trust stores (one per JVM) for Java applications and tools like Maven and Gradle.
Now I need one for Winget. What will it be this time?

I would expect an urgent fix to allow a list of trusted CAs for Winget.
On a side note, this SSL inspection feature is a pain. There's no standard configuration across applications and tools to configure trusted CAs. In my computer I have REQUESTS_CA_BUNDLE for Azure CLI, GIT_SSL_CAINFO for git, NODE_EXTRA_CA_CERTS for node and the multiple Java trust stores (one per JVM) for Java applications and tools like Maven and Gradle.
Now I need one for Winget. What will it be this time?

I'm working on updating the documentation at Microsoft Learn to clearly explain the certificate pinning enhancement for the Microsoft Store "msstore" source.
The enhancement is designed to help reduce the risk of a site impersonating the Microsoft Store REST endpoint. WinGet was enlightened with the thumbprint for the certificate used by the Microsoft Store REST endpoint so WinGet will know it is communicating with the correct "source".
In the event described above, where networking infrastructure is modifying the connection, WinGet will return the error. The two options are to bypass these checks for the Microsoft Store REST endpoint in the networking infrastructure, or to disable this check in WinGet. This can be done by Group Policy, or by the administrative setting:
winget settings --enable BypassCertificatePinningForMicrosoftStore

winget settings export will export the administrator settings. This work was done as a part of building DSC Resources to manage WinGet.

I'm working on updating the documentation at Microsoft Learn to clearly explain the certificate pinning enhancement for the Microsoft Store "msstore" source.
The enhancement is designed to help reduce the risk of a site impersonating the Microsoft Store REST endpoint. WinGet was enlightened with the thumbprint for the certificate used by the Microsoft Store REST endpoint so WinGet will know it is communicating with the correct "source".
In the event described above, where networking infrastructure is modifying the connection, WinGet will return the error. The two options are to bypass these checks for the Microsoft Store REST endpoint in the networking infrastructure, or to disable this check in WinGet. This can be done by Group Policy, or by the administrative setting: winget settings --enable BypassCertificatePinningForMicrosoftStore

So the implementation is not actually validating the certificate chain like apt, git, npm, node, openssl, Java and others do. That's why it can't simply "trust" the proxy re-encryption certificate. The only alternative is to disable the feature and fallback to the same level of security we had before.

The certificate chain was previously, and continues to be, validated as trusted on the system; regardless of any configuration of settings applied.  That is not something we would change.
The pinning feature adds an additional check to ensure that the chain is not just any trusted chain, but is a fairly specific one.  Disabling the feature as described previously simply turns that check off and goes back to allowing any trusted chain.
The goal is to prevent supply chain attacks, securing the channel all the way up to the application level.  It is properly detecting tampering on the channel via this SSL inspection (aka man-in-the-middle).  If an exception for the Store DNS name is not acceptable for your organization, then disabling the feature is the correct action to take.

That settles it for me then, thank you very much for the clarification.

The two options are to bypass these checks for the Microsoft Store REST endpoint in the networking infrastructure, or to disable this check in WinGet. This can be done by Group Policy, or by the administrative setting:
winget settings --enable BypassCertificatePinningForMicrosoftStore.

You say there's two options the proposed solution here sounds like it's just disabling the check in winget? How about the bypassing of these checks? And is there a way to do this without involving an administrator?

I was saying the two options are:

Changes to the network device policies that prevent it from inspecting the traffic to the Microsoft Store REST service.
Disabling the certificate pinning in winget

While I don't know what access would be required to enact option 1, I suspect it is under the control of a very few IT admins for any given operation.
And option 2 requires one to be an administrator on the machine (or to be put in place by group policy).  There is no way around this requirement as it is in place to prevent an EoP chain attack on the user.

@JohnMcPMS in effect strongly discouraging the usage of the winget cli in secure corporate environments. Good to know.

@JohnMcPMS in effect strongly discouraging the usage of the winget cli in secure corporate environments. Good to know. Hard to see how either of those options is acceptable in secure corporate environments.
The first seems like the right approach but as you note likely under the control of a few IT people who are tricky to access and convince.
@jcrben

The IT people have probably already run into this because certificate pinning is heavily used by mobile apps.  They most likely work around it by issuing corporate mobile devices that are tightly controlled by an MDM solution.
It's also important to point out that certificate pinning is only coming up with the msstore as a source, and not with winget itself as a source.  The winget cache is not preventing HTTPS Inspection due to HTTPS inspection.
@denelon
I'm personally seeing two things related to this issue that are frustrating:

If I try to run winget upgrade against an app that the winget data shows was sourced from winget, and not msstore, I should not have to explicitly define the source switch to run the upgrade, especially when running winget upgrade --all
Something seems off with how certificate pinning is working with winget.  I have *.mp.microsoft.com excluded from DPI-SSL on my firewall.  The Microsoft Store app, which I assume is using the same endpoints, is working fine.  winget is continuing to throw the error regarding the server certificate.  What's different about winget that it's not working when the Microsoft Store app is?

@JohnMcPMS John McPherson FTE in effect strongly discouraging the usage of the winget cli in secure corporate environments. Good to know. Hard to see how either of those options is acceptable in secure corporate environments.
The first seems like the right approach but as you note likely under the control of a few IT people who are tricky to access and convince.

@jcrben it's just another layer of security. It's actually intended to improve security. If an enterprise has such a firewall, it would likely be an IT function to either disable the SSL inspection for the Microsoft Store source in their firewall, or to disable the check for the certificate pinning by the client.

@aydeisen if you run winget source export you can see the URL for the "msstore" REST source:
winget source export
{"Arg":"https://storeedgefd.dsx.mp.microsoft.com/v9.0","Data":"","Identifier":"StoreEdgeFD","Name":"msstore","Type":"Microsoft.Rest"}
{"Arg":"https://cdn.winget.microsoft.com/cache","Data":"Microsoft.Winget.Source_8wekyb3d8bbwe","Identifier":"Microsoft.Winget.Source_8wekyb3d8bbwe","Name":"winget","Type":"Microsoft.PreIndexed.Package"}

The URL we're pinning the certificate for is:
https://storeedgefd.dsx.mp.microsoft.com/v9.0

@aydeisen if you run winget source export you can see the URL for the "msstore" REST source:
winget source export
{"Arg":"https://storeedgefd.dsx.mp.microsoft.com/v9.0","Data":"","Identifier":"StoreEdgeFD","Name":"msstore","Type":"Microsoft.Rest"}
{"Arg":"https://cdn.winget.microsoft.com/cache","Data":"Microsoft.Winget.Source_8wekyb3d8bbwe","Identifier":"Microsoft.Winget.Source_8wekyb3d8bbwe","Name":"winget","Type":"Microsoft.PreIndexed.Package"}

The URL we're pinning the certificate for is: https://storeedgefd.dsx.mp.microsoft.com/v9.0

@denelon
I am fully aware of this.  Based on the URL, my exclusion for *.mp.microsoft.com from DPI-SSL inspection would encompass that URL.  I know that my exclusion works because I'm not receiving errors from the Microsoft Store app.
If both the Microsoft Store App (22212.1401.8.0) and winget (v1.4.10173) are executing from the same machine with the same firewall restrictions and looking in the msstore endpoint, I would assume consistent results between the two.  Instead, the Microsoft Store app is working whereas winget continues to state the server certificate doesn't match.
I can't find documentation that tells me how to identify the difference between the two or whether the issue is truly related to the app or DPI-SSL inspection

@adydeisen
If you enable the policy for "Bypass Certificate Pinning For Microsoft Store" on the machine, do you still get the error when you try to install packages?
Do you see different behavior if you specify the source in the command?

@denelon

Do you see different behavior if you specify the source in the command?

Yes, if I explicitly specify --source winget, I do not receive an error.  I object to being required to provide the parameter when winget already knows I installed a package from the winget source instead of the msstore source, but it does work.
The error does persist if I say --source msstore, so the issue is with the msstore source

If you enable the policy for "Bypass Certificate Pinning For Microsoft Store" on the machine, do you still get the error when you try to install packages?

no, enabling the setting prevents the error.  Given the choice, I would prefer not to bypass certificate pinning and allow winget to confirm its certificate chain is what is expected

When multiple sources are configured, there may be matches returned from any of those sources.
WinGet doesn't "know" if the current version of the package was installed from a specific source or by the user manually, or if the package upgraded itself. The source column is used to indicate a match with a manifest in one or more configured sources.
I don't intend for users to "have" to specify a source. I was asking as a troubleshooting mechanism.
WinGet still does check the root of trust for the "msstore" source as @JohnMcPMS stated above. The certificate pinning is simply another layer of validation intended to ensure the connection is with the expected endpoint.

WinGet doesn't "know" if the current version of the package was installed from a specific source or by the user manually, or if the package upgraded itself. The source column is used to indicate a match with a manifest in one or more configured sources.

I must be misunderstanding something then:
If I run winget list to view installed packages, I still get a source column that's populated for packages I installed from winget, and blank for packages I did not.
When referring to packages I already have installed, am I to understand that the source column is not telling that it's a winget package when the source column is populated?

List currently doesnt show msstore matches iirc due to some matching weirdness that is still being worked out

WinGet doesn't "know" if the current version of the package was installed from a specific source or by the user manually, or if the package upgraded itself. The source column is used to indicate a match with a manifest in one or more configured sources.

I must be misunderstanding something then:
If I run winget list to view installed packages, I still get a source column that's populated for packages I installed from winget, and blank for packages I did not.

There is a subtle distinction here. The source column is populated with "winget" when an installed package appears to match a manifest in the "winget" source. It doesn't matter how they were actually intsalled.

When referring to packages I already have installed, am I to understand that the source column is not telling that it's a winget installed package when the source column is populated?

There is a subtle distinction here. The source column is populated with "winget" when an installed package appears to match a manifest in the "winget" source. It doesn't matter how they were actually intsalled.

Got it; that was a failure on my part on how I understood what that column meant, and why my first question was nonsensical.
Thanks for the clarification

WinGet 1.4 originally had a certificate root for the "msstore" source that was deprecated.
We did have a 1.4 servicing release with the new certificate.
https://github.com/microsoft/winget-cli/releases/tag/v1.4.11071
WinGet 1.5 is now out and also has the correct certificate.
https://github.com/microsoft/winget-cli/releases/tag/v1.5.1572
We've updated the https://aka.ms/getwinget link to point to the latest stable release.

WinGet 1.5 is now out and also has the correct certificate.

This seemed to be the problem in my case and the new version solved it. I hope everyone else will have the same experience!

I still have this problem on my home desktop:
➜ winget --version
v1.5.1572

➜ winget upgrade --source msstore
Failed when opening source(s); try the 'source reset' command if the problem persists.
An unexpected error occurred while executing the command:
0x8a15005e : The server certificate did not match any of the expected values.

Enabling BypassCertificatePinningForMicrosoftStore just changes the error from 0x8a15005e : The server certificate did not match any of the expected values. to WinHttpReceiveResponse: 12152: The server returned an invalid or unrecognized response.

OMg.

2. create a DWORD named EnableBypassCertificatePinningForMicrosoftStore with a value of 1 at the path HKLM\Software\Policies\Microsoft\Windows\AppInstaller

MITM is what nearly every large organisation does now on all it's own user traffic...they decrypt everything and look at what you are browsing whilst you should be working ;)

Could you please update the Intune Network requirement documentation to state that storeedgefd.dsx.mp.microsoft.com doesn't support SSL inspection? Intune Extention leveraging Winget to install MS Store Apps is failing due to SSL inspection but there is no KB article that explicitly states that SSL inspection breaks Winget MSStore updates/Installs
https://learn.microsoft.com/en-us/mem/intune/fundamentals/intune-endpoints

I'm on v1.6.2771 and winget upgrade --all gives me:
Failed when searching source: msstore
An unexpected error occurred while executing the command:
WinHttpReceiveResponse: 12152: The server returned an invalid or unrecognized response

But there's nothing I can do change network rules.
A way to completely disable whatever this is to have the connection work would be great.

Just hit this where anti malware (I'm assuming it's doing TLS MITM) was at fault. Changed anti-malware software and it worked again.

I'm on a nearly stock Windows 11 within Parallels on a shared network. Internet works, but this tool does not. Windows Updates fail as well. The OS became incredibly bad. This VM is nearly untouched and was just stopped for a few months.

This issue is still present on Windows 11 fresh install (from ISO not from Refresh/Reset)
C:\Users\tolga>winget -v
v1.8.532-preview

Have this since today. Instead of spending hours on a temporary solution, I just uninstalled Winget and wait a few years until it gets (maybe) fixed.

This is a joke of a lifetime; problem from my side was, that winget was way outdated. After struggling using Microsoft Store, I finally found the direct download link: https://github.com/microsoft/winget-cli/releases/download/v1.7.10661/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
You have to manually update winget .. wtf?
https://github.com/microsoft/winget-cli/

This is a joke of a lifetime; problem from my side was, that winget was way outdated. After struggling using Microsoft Store, I finally found the direct download link: https://github.com/microsoft/winget-cli/releases/download/v1.7.10661/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
You have to manually update winget .. wtf?
https://github.com/microsoft/winget-cli/
FYI; my system is Windows 11 running on the latest updates (23H2), but still, you need to do these tweaks. Version prior to manual update: v1.5.2201.

Thanks for your response, you saved my time! I got the same errors, but when I updated winget, everything worked.
Can developers please introduce some kind of version control inside client? E.g. simple notification: "Your winget is not up to date, please update it, or even better - auto update mechanism build in winget, update is not simple because it was pulled from msstore...

https://aka.ms/getwinget works for me.

I don't understand. Is winget an official M$ thing? Why do I have this error in 2024 ? What is the solution? Why is this still open?

We are on the newest version of winget (1.8.x) and we are still getting this. We have Palo Alto but have filtered *.Microsoft.com to not do SSL inspection but still getting error.

We added the url source found from 'winget source list'  (storeedgefd.dsx.mp.microsoft.com) to our decryption exclusion url list
This seems to have resolved the issue for our site.

workaround : https://github.com/microsoft/winget-cli/issues/3984#issuecomment-2070850772


TP: fixes bug with delivery service requests when deleting a ds

What does this PR (Pull Request) do?

[x] This PR fixes #4192

The bug was never documented (obviously) so no documentation to fix.
DSRs are not under test.
No change log entry required.
Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Enable delivery service requests (dsRequests.enabled=true) in traffic_portal_properties.json and set overrideRole=admin
Launch TP
Login as an admin
delete a delivery service and select "fulfill immediately"

You will be directed back to the delivery services page and your delivery service will be gone. You can also verify that a delivery service request was created and closed/completed under https://tp.domain.com/#!/delivery-service-requests
If this is a bug fix, what versions of Traffic Control are affected?

master (0b02a3c)

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4926/


Keep history of changes to the database

Keep history of changes to the database
:recycle: Current situation & Problem
Some data is only stored temporarily - however, we want to make sure not to delete data unintentionally and keep a backup of everything that is going on in the database. There is no security rule in place for users to access and we should only ever create new items in this collection rather than deleting anything ever, just like an automatic backup system.
:gear: Release Notes
Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.
:books: Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
:white_check_mark: Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Open questions before merging:

Do we want to keep a history of EVERYTHING that is going on in Firestore or just a small part of it, e.g. the medication recommendations?
Do we need more information for each change, e.g. who made that change or just a delta of each change, etc?
Do we need read information, i.e. when a user read a certain record?
Do we have three-level or higher collections?

@pauljohanneskraft Let me know if you have any follow-up questions on the meeting today; think we resolved all the questions above 👍


[Improve][Connector-V2][Redis] RedisSource support scan operation

Scan command allow for incremental iteration, returning only a small number of elements per call,.
KEYS command may block the server for a long time when called against a lot of keys.
Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

It looks like a exciting feature. But it seems that has some problems in e2e test case. BTW, if you write a e2e test case to verify this feature is better. A tested PR will join the host branch more quickly. Thank you again for your contribution to SeaTunnel.

It looks like a exciting feature. But it seems that has some problems in e2e test case. BTW, if you write a e2e test case to verify this feature is better. A tested PR will join the host branch more quickly. Thank you again for your contribution to SeaTunnel.

I unit tested it locally, but I'm still learning e2e, so I'll fill in later.

Hi, @rhh777
You submitted a very good pr, but I found that it has not been changed for a long time, can you update this PR?

Please assign it to me

Please assign it to me

Ok.


Mypy regression - Missing named argument

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
pydantic version 1.10.6 + mypy 1.1.1 + mypy plugin causes error with previously ok code.
Note: mypy plugin is irrelevant, and does not affect the output in this usecase
Using Field with a description on an optional Field, without an explicit default=None, used to work
$ mypy sample.py
sample.py:10: error: Missing named argument "bar" for "Sample"  [call-arg]
Found 1 error in 1 file (checked 1 source file)

Error started happening with pydantic 1.10.4, version 1.10.2 does not have this issue
versions >1.10.2 now require the explicit default=None on Optional fields.
This seems like a bug, if not please advise.
Example Code
from typing import Optional
from pydantic import BaseModel, Field

class Sample(BaseModel):
    foo: str
    bar: Optional[str] = Field(description="optional")

Sample(foo="hello world")

Python, Pydantic & OS Version
pydantic version: 1.10.6
            pydantic compiled: True
                 install path: /home/hatem/projects/inventory_service/venv/lib/python3.8/site-packages/pydantic
               python version: 3.8.10 (default, Sep 28 2021, 16:10:42)  [GCC 9.3.0]
                     platform: Linux-5.11.0-37-generic-x86_64-with-glibc2.29
     optional deps. installed: ['dotenv', 'typing-extensions']

Affected Components

[X] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

This appears to have been introduced by using @dataclass_transform on the metaclass, and the reason that it works in 1.10.2 is because that version used the keyword argument field_descriptors instead of the correct field_specifiers.
I'm not sure how involved it will be to fix this properly while retaining the @dataclass_transform behavior; the good news is that in v2 this shouldn't be an issue because we no longer set an implicit default for Optional/Any fields.
Does anyone know why the keyword argument was field_descriptors before? Was that just a typo?

Seems there was some logic issues in the plugin that meant it wouldn't work correctly if you set a Field as the default but didn't specify default or default_factory. The dataclass_transform thing was just hiding the issue. I've got a fix coming shortly.


bug(chisel): code after assembly block which returns bytes breaks (stack|mem)dump

Component
Chisel
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (394f217 2023-03-21T00:04:24.143572Z)
What command(s) is the bug in?
chisel
Operating System
macOS (Intel)
Describe the bug
If an assembly block containing a return statement is followed by some code, !sd/!md break with the error "Run function is empty".
❯ chisel
Welcome to Chisel! Type `!help` to show available commands.
➜ uint test = 1;
  assembly {
      mstore(0x0, 0x1337)
      return(0x0, 0x20)
  }
➜ !md
[0x00:0x20]: 0x0000000000000000000000000000000000000000000000000000000000001337
[0x20:0x40]: 0x0000000000000000000000000000000000000000000000000000000000000000
[0x40:0x60]: 0x0000000000000000000000000000000000000000000000000000000000000080
➜ test = 2;
➜ !md
⚒ Chisel Error: Run function is empty.
➜ !source
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;

import {Cheats} from "forge-std/Vm.sol";

contract REPL {
    Cheats internal constant vm = Cheats(address(uint160(uint(keccak256("hevm cheat code")))));

    /// @notice REPL contract entry point
    function run() public {
        uint test = 1;
        assembly {
            mstore(0x0, 0x1337)
            return(0x0, 0x20)
        }
        test = 2;
    }
}

Separating this logic into its own function causes additional issues, resulting in the errors "Failed to inspect expression" and "Run function is empty".
❯ chisel
Welcome to Chisel! Type `!help` to show available commands.
➜ function testReturn() public returns(bytes memory) {
assembly {
            mstore(0x0, 0x1337)
            return(0x0, 0x20)
        }
}
➜ bytes memory test = testReturn();
➜ test
Traces:
  [149] 0xBd770416a3345F91E4B34576cb804a576fa48EB1::run()
    └─ ← 0x0000000000000000000000000000000000000000000000000000000000001337

⚒ Chisel Error: Failed to inspect expression
➜ !source
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;

import {Cheats} from "forge-std/Vm.sol";

contract REPL {
    Cheats internal constant vm = Cheats(address(uint160(uint(keccak256("hevm cheat code")))));

    function testReturn() public returns (bytes memory) {
        assembly {
            mstore(0x0, 0x1337)
            return(0x0, 0x20)
        }
    }

    /// @notice REPL contract entry point
    function run() public {
        bytes memory test = testReturn();
    }
}

➜ !md
⚒ Chisel Error: Run function is empty.

Taking this source for a simple Foundry test, we see that it should work without any issues.
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;

import "forge-std/Test.sol";

contract REPL is Test {

    function testReturn() public returns (bytes memory) {
        assembly {
            mstore(0x0, 0x1337)
            return(0x0, 0x20)
        }
    }

    /// @notice REPL contract entry point
    function run() public {
        bytes memory test = testReturn();
        emit log_named_bytes("test", test);
    }
}

contract ChiselTest is Test {
    REPL repl;

    function setUp() public {
        repl = new REPL();
    }

    function test_chiselMem() external {
        repl.run();
    }
}

Given that the code following the return statement represents an unreachable code path, chisel should deal with these cases such that the errors are avoided.

cc @clabby, can you check this one out?


Fix RemoveFinalizer methods in svcat cli

Description
Fix method for removing the service-catalog finalizer from the ServiceInstance and ServiceBinding.
Context:
In the previous approach (Aggregate API server) the UpdateStatus func allowed to update fields under metadata entry. When we switch to the native webhook concept, this hacky implementation was removed and now we should use the Update function as the UpdateStatus modifies only Status entry.
/kind bug

/retest

/lgtm

/approve

/retest

/retest

Hello @mszostok, I hit the same issue here. I only saw this PR after I created a patch of my own, but with tests added already. :)
If UpdateStatus is called then the actions' SubResource is "status". The following expression checks for that. Just add it at the end of the Finalizer tests RemoveFinalizerForBinding and RemoveFinalizerForInstance:
    Expect(actions[1].(testing.UpdateActionImpl).GetSubresource()).To(Equal(""))

/retest

/test pull-build-all-images-for-amd64

/test pull-build-all-images-for-ppc64le


Deleted augroup issue after vim upgrade

The plugins syml/rust-codefmt and rust-lang/rust.vim are not compatible anymore after I upgraded my vim (7.4 -> 8). Not sure which version of 7.4 I had, sorry.
syml/rust-codefmt are both rust language plugins with a rust ftdetect file containing:
au BufRead,BufNewFile *.rs set filetype=rust
When both plugins are used I now get:
W19: Deleting augroup that is still in use
Each plugin cannot assume another rust plugin is used to set the filetype. Is this a vim issue?

It's a warning, that doesn't mean the plugins are not compatible anymore. Also that warning helps to prevent error (before, it was not checked). You should discuss this issue with the plugin developers.

But it opens the message window every time I open a .rs file ...

If this is not a bug then vim shouldn't show the 'Press enter to continue' window when messages are warnings only.

If this is not a bug then vim shouldn't show the 'Press enter to continue'
window when messages are warnings only.

It is a bug, but my understanding is that it is a bug in the plugins, not in Vim.
W19 is a new warning, introduced in Vim-7.4.2117 (Jul 2016) which
detects invalid deletion of autocommands,


Shortcut for "Copy Relative Path (Alt + Ctrl + Shift + C)" is not Working

Issue Type: Bug
Hello there!
I can't copy the relative path from a file through shortcut "Alt + Ctrl + Shift + C", only through right click, then clicking in the menu option.
I looked at https://github.com/microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-generic-keybindings but I trust these cases is not appliable for me
If possible, I would appreciate to solve this problem :)
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:39:46.686Z)
OS version: Linux x64 5.13.0-30-generic
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2900)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 2

Memory (System)
15.53GB (1.03GB free)

Process Argv
. --crash-reporter-id c46fed50-e32c-4433-a003-bb223a23024c

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Could you share with us a gif of what you see?
And why was https://github.com/microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-generic-keybindings not helpful for you?
/gifPlease


Module is unable to bootstrap a new XtraDB cluster

The module is unable to bootstrap a new cluster if the data directory does not exist:
Notice: /Stage[main]/Galera::Repo/Yumrepo[galera_percona]/ensure: created
Notice: /Stage[main]/Galera::Repo/Yumrepo[galera_epel]/ensure: created
Notice: /Stage[main]/Galera::Repo/Package[Percona-XtraDB-Cluster-shared-compat-57]/ensure: created
Notice: /Stage[main]/Galera/Package[percona-xtrabackup-24]/ensure: created
Notice: /Stage[main]/Mysql::Server::Install/Package[mysql-server]/ensure: created
Notice: /Stage[main]/Mysql::Server::Config/File[mysql-config-file]/ensure: defined content as '{md5}63be06247231f5789304856324bcf3b4'
Notice: /Stage[main]/Mysql::Server::Installdb/Mysql_datadir[/var/lib/mysql]/ensure: created
Notice: /Stage[main]/Galera/Exec[bootstrap_galera_cluster]/returns: executed successfully
Info: /Stage[main]/Galera/Exec[bootstrap_galera_cluster]: Scheduling refresh of Exec[validate_connection]
Error: Systemd start for mysql failed!
Error: /Stage[main]/Mysql::Server::Service/Service[mysqld]/ensure: change from 'stopped' to 'running' failed: Systemd start for mysql failed!
Notice: /Stage[main]/Galera/Exec[create /root/.my.cnf]: Dependency Service[mysqld] has failures: true

In this case, mysql::server::installdb notifies Class['mysql::server::service']... as soon as Exec[bootstrap_galera_cluster] does it's thing, it breaks.

I see this happening now as well, what is the way to make this work ?

@Yamakasi Perform a manual bootstrap, according to the Percona XtraDB docs.

I just want to advise, this behaviour exists on Ubuntu 18.04 with percona 5.7, on the first node only you need to run
/etc/init.d/mysql bootstrap-pxc
then re-run puppet to ensure config items are finalised, then puppet will run on other nodes fine

@anthonysomerset you don't need a re-run.
Ubuntu is not ideal for this type of software because grabbing the password is far from ideal.

Working solution:
Hiera
### bootstrap command
galera::percona::57::bootstrap_command: 'systemctl start mysql'

Manifest
  ### bootstarp master via default service
  if ($fqdn == $master) {

    file {'/etc/systemd/system/mysql.service.d':
      ensure  =>  directory,
    }->
    file {'/etc/systemd/system/mysql.service.d/override.conf':
      ensure  =>  present,
      source  =>  'puppet:///modules/profile/galera/mysql.service.override',
      before  =>  Package['Percona-XtraDB-Cluster-57']
    }

    Exec<| title == 'bootstrap_galera_cluster' |> {
      require => File['/etc/systemd/system/mysql.service.d/override.conf']
    }

  }

Service override file
[Service]
ExecStart=
ExecStart=/usr/bin/mysqld_safe --basedir=/usr --wsrep-new-cluster

Please let me know what you think.
If it is okay, i will create a PR. @fraenki

I've addressed this issue in https://github.com/fraenki/puppet-galera/commit/243e7c34fde42b0764a8cc28e7f9226a9d3032b5:

Stop the mysql@bootstrap service after performing the bootstrap. This allows puppetlabs/mysql to properly startup the node (and it will be in primary state).
On RedHat-based systems ensure to configure the proper log file (override the MariaDB defaults).
Fix possible installation issues on RedHat-based systems by excluding Percona-Server packages.
Fix possible dependency isues by using the meta-package on RedHat-based systems.

I've verified that this works on CentOS 7 and also added a simple acceptance test (tests for Debian/Ubuntu are planned too).
The upcoming release 2.0.0 of this module will contain all fixes.

Thanks a lot @fraenki

The upcoming release 2.0.0 of this module will contain all fixes.

Version 2.0.0 has just been released. It includes acceptance tests for Galera, XtraDB and MariaDB on all supported operating systems:
https://travis-ci.org/github/fraenki/puppet-galera/builds/674627174
Please open a new issue if you find yet another bug :)


JuliaQuantum on social networks and media.

When the QuBase.jl project in a good shape, I will post ads among the ICIQ Google+ community, which was created by our members and has become the largest Google+ community on quantum and information science. Working on open-source projects, sharing blogs, news, study materials and giving free interactive online Google-hangout talks are the main targeted activities there. I open this issue to see if there are any other social network channels worth us posting some information to encourage people from Non-Julia community to join us. Maybe you want to spread the word somewhere? We can coordinate on the best time, form and place to do so under this thread. Thanks.

For the SQuInT meetup events, I have shot some posts online. Feel free to forward and re-post through social networks:

Julia Google+ community
ICIQ Google+ community
julia-users Google group

Those posts all linked back to the announcement at #15 .

On twitter, please use #JuliaQuantum as the key word. In fact, you can find a lot of tweets about us already there!

Close as we have achieved the major task in the past. Reopen or start a new post if needed in the future.


Dynamically set the category href within Header.astro

Currently, the category hrefs are hard coded within Header.astro.
Would setting the hrefs dynamically make more sense?
For example, starting here: https://github.com/isooosi/VisVrs/blob/502d1a6d721fff837081b7705c7bfb312c8a1844/src/components/Header.astro#L10-L12 they are hard coded.
I'm completely new to astro/JS and this is the first template i've used. Love the design!

I also noticed that https://github.com/isooosi/VisVrs/blob/502d1a6d721fff837081b7705c7bfb312c8a1844/src/components/Header.astro#L12C7-L12C65 is wrong anyway. Should be Two

The VisVrs has undergone a comprehensive upgrade. Please try the new version. v4.7.

Hi thanks I've just had a look. I see that you extracted the code to the consts.ts file, but i don't see how this is better?
It seems that you continue to hardcode the creation of HTML category links at top of page, but you've simply moved it to consts.ts 'HeaderLinks' variable?
With my solution, any category specified in the markdown front matter dynamically gets a category link created for it. No need to hardcode html for them. Done.
I don't understand why you dynamically create links everywhere else, but for arguably the most prominent and important links on the site you have them hard coded?
Am i missing something??