Does mdbx_strerror_r's return value require free-ing?

After something like:
// assume we define appropriate variables
const char * error_text = mdbx_strerror_r(errnum, buffer, 1024);

Do I need to call free on error_text?

You should manage the buffer (and free it in case it was allocated), but not the error_text (which cold be pointed to const string or to any byte inside the buffer).
Like the GNU-specific strerror_r(), the mdbx_strerror_r() returns either a pointer to a string that the function stores in given buffer, or a pointer to  some (immutable) static string (in which case buffer is unused).


[WIP] Update for new Lab Extension handling

cf https://github.com/jupyterlab/jupyterlab/pull/2038

@blink1073 Is this still relevant given https://github.com/jupyterlab/jupyterlab/issues/2011#issuecomment-293118232?
If so, I'm having trouble building the labextension:
TypeError: build is not a function
    at Object.<anonymous> (/Users/grant/Sites/jupyter/jupyterlab_geojson/labextension/build_extension.js:4:1)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:420:7)
    at startup (bootstrap_node.js:139:9)
    at bootstrap_node.js:535:3

I'm currently using this to test against https://github.com/jupyterlab/jupyterlab/pull/2038.

How do you test against these lerna packages? Normally, you would npm link [package-name], but this seems different... 🤔

The previous test I did was against the released versions of JupyterLab.  I just ran the test below and that worked as well.  Can you think of a good way to capture these commands?  Perhaps jupyterlab linkify that does all this linking, but only if they're not already symlinked?
cd jupyterlab_geojson/labextension
npm link <all the jupyterlab paths>
cd <virtualenv>/share/jupyter/lab
npm link <all the jupyterlab paths>
npm link <path to jupyterlab_geojson>

Could be jupyterlab linkify <jupyterlab_geojson path> or jupyterlab linkify from that directory.

cc @jasongrout

cc @ian-r-rose

Ok, so you are linking the extension into the jupyterlab directory 👌
The first thought that comes to mind is Atom's apm link which is run in the plugin directory and npm links it in the atom directory. It seems like this would work well for jupyterlab: Just run jupyterlab link in the extension directory.

@blink1073 I'm running into the "No provider for: jupyter.services.rendermime." error for rendermime, document-registry, and layout-restorerer when trying to install this branch:
Plugin 'jupyter.extensions.GeoJSON' failed to activate.    index.js:267
Error: No provider for: jupyter.services.rendermime.    index.js:268
    at JupyterLab.Application.resolveRequiredService
 (http://localhost:8888/lab/main.bundle.js:119907:35)
    at Array.map (native)
    at JupyterLab.Application.activatePlugin (http://localhost:8888/lab/main.bundle.js:119865:38)
    at http://localhost:8888/lab/main.bundle.js:119991:26
    at Array.map (native)
    at JupyterLab.Application.start (http://localhost:8888/lab/main.bundle.js:119990:33)
    at main (http://localhost:8888/lab/main.bundle.js:96397:9)

@gnestor, it looks like you haven't updated your dependencies to match JupyterLab. Can you make sure that your JupyterLab and Phosphor dependencies match the versions in JLab 0.20.2?

(i.e., these ones: https://github.com/jupyterlab/jupyterlab/blob/v0.20.2/jupyterlab/package.json)

I had tried updating the versions (in a different extension) but I didn't notice that the package names changed (e.g. @jupyterlab/rendermime to @jupyterlab/rendermime-extension)! It's working now :+1:

Both of those packages exist.  The main entry point file linked above only depends on the things it imports directly.


allow linking local files in markdown of jsdocs

Search Terms
https://github.com/Microsoft/TypeScript/issues?utf8=✓&q=is%3Aissue+link+markdown
Suggestion
make markdown links to the local files work
Use Cases
navigating to local files by clicking links displayed in jsdocs
Examples
/** [see also](./another-file.ts) */
class MyClass {
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. new expression-level syntax)

We don't control how editors do linking / clicking - you'd have to take this up with each individual editor.


Add Version to relationship aspects

As PO ,
I want to be compliant to the versioning initiative of CX ,
so that we will be downward compatible .
Link

child of  https://github.com/eclipse-tractusx/sig-release/issues/650

Hints / Details

example Value for a bomlifecycle element
it shall be possible, that two versions of the same aspect can exist in parallel of a bomlifecycle
introduce a list of concrete semantic urn's urn:samm:io.catenax.single_level_bom_as_built:3.0.0

Assumption
As the semantic models are using semantic versioning, the api and in this case the semantic model will not provide braking changes with minor or patch version updates.
Instead of supporting only a specific version for traversal aspects which cause sirs updates on each semantic model patch version update, IRS should be made resilience to support a major version of semantic models
Acceptance Criteria

[x] IRS supports the latest full major version range for each traversal aspect (3.0.0 - 3.10.0)
[x] All known versions of current major versions of traversal aspects SingleLevelAs (3.0.0) are covered with tests
[x] the API Documentation has been updated
[x] Tests have been updated
[ ] The API has been changed to accept only the urn's which are available
[ ] Add valid example values to API docu ( replace "string")
[x] Adjusting tests
[x] Adjusting mocks
[x] Adjusting API documentation
[x] Adjusting documentation

Specification
General

aspectType is provided (Trace-X)
linkedItem is still used

SingleLevelBomAsBuilt | 3.0.0 |

catenaXId (Trace-X)
childItems/catenaXId (Trace-X)
hasAlternatives
businessPartner (Trace-X)

SingleLevelBomAsPlanned | 3.0.0

catenaXId (Trace-X)
childItems/catenaXId (Trace-X)
businessPartner (Trace-X)

SingleLevelUsageAsBuilt | 3.0.0

catenaXId (Trace-X)
parentItems/catenaXId (Trace-X)
parentItems/isOnlyPotentialParent
businessPartner (Trace-X)

SingleLevelUsageAsPlanned | 2.0.0

catenaXId (Trace-X)
parentItems/catenaXId (Trace-X)
businessPartner (Trace-X)

SingleLevelBomAsSpecified | 2.0.0

assetId
childItems/childassetId

Out of Scope

...

Discussion
Idea is to use the major version similar to the approach of semantic models.
We keep this open as we want to reevaluate this idea with  @ds-jhartmann

Label was removed as there is a clear decision to support a full major version range for each traversal aspects. Currently, 3.0.0 - 3.x.x

Implemented in https://github.com/eclipse-tractusx/item-relationship-service/pull/671

Support for SingleLevelUsageAsPlanned.
Documentation to describe the delegate process.
Added Tests for previous supported SingleLevel* Versions
Added Tests for potential future minor/patch SingleLevel* Versions

As discussed wiht @mkanal, the AC "The API has been changed to accept only the urn's which are available" was not implemented, since the relationship aspects are not directly specified via API, only inferred by "bomLifecycle" and "direction".

This story will be tested by #529

AC: "The API has been changed to accept only the urn's which are available" Decision: AC was removed as the urn will not be published over the api.


Added new test cases

Codecov Report

Merging #52 (96d8b1f) into main (9c0a11e) will increase coverage by 3.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   57.84%   61.39%   +3.55%
==========================================
  Files          22       22
  Lines        1696     1733      +37
==========================================
+ Hits          981     1064      +83
+ Misses        715      669      -46

Impacted Files
Coverage Δ

test/test_bot.py
98.72% <100.00%> (+0.23%)
:arrow_up:

cogs/instructor.py
93.33% <0.00%> (+48.88%)
:arrow_up:

cogs/ta.py
97.77% <0.00%> (+53.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0a11e...96d8b1f. Read the comment docs.


questions.py

Hi, great thanks for your wonderful work.
May you please update the link for questions.py https://huggingface.co/datasets/shi-labs/COST/blob/main/vcoder_llava/questions.py as mentioned in https://huggingface.co/datasets/shi-labs/COST, since the link now leads to 404 error?
Great thanks in advance.

Hi @RussRobin, thanks for your interest and pointing this out. The path in the dataset card on HF was wrong. I have fixed the issue and it should be working now.

Thank you for your reply. I'll close this issue.


Fix listView opening when listViewDisplayed is false

listViewDisplayed is false, the listView should not show when text prop changes.  The listView was displayed itself when listViewDisplayed is false on re-renders.

Thanks for the PR and sorry for the delay.


pythonmatplotlib

Looks like the first line of requirements.txt should be "matplotlib" instead of "pythonmatplotlib".

Yes, thanks for the comment, should be fixed now.


fix issue: 'TypeError: cannot use a string pattern on a bytes-like object'

This has been handled with recent commit bc0a14b, hence closing the PR


save() always calls insert, never update

I created a pretty straight forward model and collection:
create table words ( user varchar(24), word varchar(128), count integer, primary key (user, word) );

 var Word = bookshelf.Model.extend({
   tableName: 'words'
 });
 var Words = bookshelf.Collection.extend({
   model: Word
 });

http://bookshelfjs.org/#Model-save
According the documentation .save() will call insert or update depending on the result of the function isNew(). However, I've noticed isNew() returns true regardless of whether or not the model exists.
http://bookshelfjs.org/#Model-isNew
   _.each( words_table, function(value, key) {
     console.log( Word.forge({user:from,word:key}).isNew() );
     console.log( World.forge({user:'turd',word:'JOISDFOIJJ'}).isNew() );
     Word.forge({ user: from, word: key })
       .save({ count: 1 })
       .then(function(model) { console.log(model); })
       .catch(function(error) { console.log(error); });
   });

As stated in the documentation I've already tried adding { patch: true } to always do an update, but that also uses insert.
{
  [Error: insert into `words` (`count`, `user`, `word`) values (1, '_bryan', 'testing') - ER_DUP_ENTRY: Duplicate entry '_bryan-testing' for key 'PRIMARY']
  code: 'ER_DUP_ENTRY',
  errno: 1062,
  sqlState: '23000',
  index: 0
}

As an alternative I've also tried set() but I receive the same errors.

I've gotten the database to update, though I've used where() instead with an option of method. Though, if I leave out the update it will try to insert the row instead
   _.each( words_table, function(value, key) {
     var word_model = Word.forge();
     word_model
       .where({ user: from, word: key })
       .save({ count: value }, { method: 'update' })
       .then(function(m) { console.log(m); });
   });

isNew just uses the primary key you tell Bookshelf about (idAttribute) which defaults to 'id'. If you don't tell Bookshelf what your primary key is it never knows that something isn't new and is therefore an update.

I just noticed this in the documentation, is it possible to have multiple idAttribute keys or does bookshelf only support 1? I've tried passing it as an array or an object, but I'm not having any lucky.

I think there are some open tickets about that. Pretty sure there are still serious issues around compound keys.

Ok, I'll just assume then that my issue has to do with compound keys. In either case, I've come up with this for now.
  _.each( words_table, function(value, key) {
     var word_model = Word.forge({user: from, word: key});
     word_model.fetch().then(function(m) {
       if ( m == null ) {
         word_model.save({count: value}).then(function(m) {});
       }
       else {
         var current_count = m.get('count');
         Word.forge().where({ user: from, word: key }).save({ count: current_count+value }, { method: 'update' });
       }
     });
   });

Composite keys is being tracked in issue #93.

Closing as a duplicate.


Search Button

The search button does not filter any articles, it only shows a loading icon but does not perform a search

I got same result, that search API return code 405.

same on Vercel

The issue lies in the library notion-client which is used by this repository. I created a pull request to fix the issue: https://github.com/NotionX/react-notion-x/pull/505 but in the meantime you can use patch-package to resolve it until the PR is (hopefully) merged

The issue lies in the library notion-client which is used by this repository. I created a pull request to fix the issue: NotionX/react-notion-x#505 but in the meantime you can use patch-package to resolve it until the PR is (hopefully) merged

Cool, buddy. I was trying to fix the problem today and pulled down the project, then I noticed your code. It's kind of annoying.
if someone wants to know how to patch the package, link is here. https://danni.cool/fixed-the-broken-search-in-nextjs-notion-starter-kit


No option to select the env variables when we are outside of the request

unable to run the collection without opening any request tab, since we do not have the option to select the env variables when the request tab is not open
in the below screenshot if I try to run the collection it's not running since the env is set to no env

Closing this issue as it has already been resolved. Thank you for taking the time to report this!
https://github.com/usebruno/bruno/assets/84461672/5dc199b7-8bf8-4843-a0c7-91d75f5dc4b8


return null instead of throwing exception if a class not injected when using [FromServices] or @Inject?

I'm new here of Dependency Injection, and there is something confusing me about DI.
For example, I want to get location of a user:

And it throws an exception about 'IIpLocationService is not registed', but I want the IIpLocationService to be optional.
In MVC, HttpContext.RequestServices solved my problem and it returns null, but what am I supposed to do when I'm not in MVC? Same thing happened when I use @inject in View.
why can't it just return null instead of throwing exception? Maybe something I missed, please help me figuring it out, thanks.

Have your tried adding a default null value (i.e. ipLocationService = nul)" value to the method definition?
I have a similar problem with TelemetryClient, which may/may not be registered in Startup.cs depending on configuration. What I do is to set it as default to null. When the controller constructor is called, it assumes the correct value if the class has been registered in DI, else it it set to null.

thanks for your answer, I tried it and it still throws InvalidOperationException: No service for type '***' has been registered.

@anobaka sorry I gave you the wrong info. I was using constructor injection so I didn't need the "FromServices" attribute. I didn't notice you are injecting into a method instead. My mistake.

[FromServices] aside from switching to constructor injection, you could use
public async Task<IActionResult> GetAddressByIp([FromServices] IEnumerable<IIpLocationService> ipLocationServices)
{
    // stuff
}

The ipLocationServices collection will be empty if the service isn't registered.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Cleveref prefix

The prefix which is automatically added to labels created by theorem environments is inconvenient. Could you please fix this? 🧐

Hi,
thanks for pointing this out. For the current version we will keep this feature in order to be consistent with older versions. But maybe we will fix it in future updates.
Best
Tim


Documentation ara new

Type of modification

[ ] Breaking change
[ ] New Feature
[ ] Bug Fix
[x] Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Changes description
Add some quick description about what your PullRequest change in
ARA's feature/behavior
Technical description
Add a quick description about what your PullRequest change in
ARA's code. (example: add a processor check in...)
PR CheckList
Please make sure your PullRequest respect all those items :

[ ] Your PR's title has the prefix : feat:, fix: or chore:
[ ] Unless your PR is related to a Hotfix (and approved by a ARA maintener), the targeted branch for it is the branch version/X.Y.Z and not master
[ ] You have asked a review from one of the ARA maintainer in your PR.
[ ] If your PR is related to an issue, add the issue's number in it.
[ ] All the code you added is documented.
[ ] All the code you added is tested and the  tests are in success.
[ ] You already signed the Contributor License Agreement and give us the document

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR is linked to this one: https://github.com/Decathlon/ara/pull/172 (now closed).


Ensure withJson returns a new Response

Fixes issue 1818. The withJson method now clones the Response, and
updates this with a new header, and a new Body.

Coverage remained the same at 97.18% when pulling 768306fea812f21301e0d7cff120fa0b5eaa8362 on robertprice:1818 into 1dedd2592c4f7e088ee3a87a7936f5df71cb7593 on slimphp:3.x.

Coverage decreased (-0.002%) to 97.178% when pulling 404321ff1c63b289ee93b2d0f8f947fed77a89ea on robertprice:1818 into 1dedd2592c4f7e088ee3a87a7936f5df71cb7593 on slimphp:3.x.

Merging #1978 will fix the php7 failing tests.

Thanks!


Compilation errors with dbt-core v1.5.0

Hello there! 👋
With the latest dbt version upgrade (v1.5.0), we've seen that the dbt-snowflake-query-tags package throws compilation errors:
Runtime Error
  Compilation Error in test dbt_utils_accepted_range_stg_budget_new_arr__0 (models/company_basics/staging/stg_company_basics.yml)
    Object of type Undefined is not JSON serializable

    > in macro get_query_comment (macros/query_comment.sql)
    > called by test dbt_utils_accepted_range_stg_budget_new_arr__0 (models/company_basics/staging/stg_company_basics.yml)

☝ this is just one example, and not the only node. This is happening on all nodes of the dbt project.
I assume this is indicating that there's a value in the comment_dict dictionary that is of type Undefined.
We've disabled the dbt-snowflake-monitoring from our packages.yml, and everything compiled correctly, so we are assuming that the problem is somewhere within the get_query_comment macro.

Thanks for raising @aleix-cd. We'll keep you posted once we find out what is happening and make a fix!

@aleix-cd how did you disable the package. For me, I can't just uninstall as there are still references to it in our codebase that I'd need to refactor since I'm getting a compilation error.

@aleix-cd this has been fixed in the latest release 4.1.1
https://github.com/get-select/dbt-snowflake-query-tags/pull/11/files

@aleix-cd this has been fixed in the latest release 4.1.1
https://github.com/get-select/dbt-snowflake-query-tags/pull/11/files

Thanks a lot for this, @ian-whitestone! 👍


Regex matches versionCode in comments

I was scratching my head why this action wasn't working for me. After some debugging I realized that it had managed to replace versionCode in a comment (e.g. // Here's a sentence with versionCode in it). The replacement mechanism needs to be a bit more robust. At the very least a regex that doesn't match on a comment line.

One idea would be to make sure the line start with whitespace:
const versionCodeRegexPattern = /^\s*(versionCode(?:\s|=)\s*)\d+(.*)/;

This doesn't match (single line) comments and only integer versionCodes (which they should be according to the docs).


No logs in OPENFIRE_LOG_DIR and error "No Log4j 2 configuration file found"

We are currently trying to debug a login/connection issue of an automated XMPP client (Jenkins) with our dockerized Openfire server running with your image "gizmotronic/openfire" and default folders.
The problem is there aren't any logs apart from docker [CONTAINER_NAME] logs, neither in the admin console

nor under /usr/share/openfire/logs or under /var/log/openfire/
And the docker logs of the instance contain the following error
ERROR StatusLogger No Log4j 2 configuration file found. Using default configuration (logging only errors to the console), or user programmatically provided configurations. Set system property 'log4j2.debug' to show Log4j 2 internal initialization logging. See https://logging.apache.org/log4j/2.x/manual/configuration.html for instructions on how to configure Log4j 2
Can this be a result of the function rewire_openfire() in entrypoint.sh?
Also, there are actually 2 log4j2.xml in the container
/usr/share/openfire/lib/log4j2.xml which symlinks to /etc/openfire/log4j2.xml
/var/lib/openfire/conf/log4j2.xml
Which config do we need to change to get the logs in the admin console?
Are there any other changes we can make to get more than the error-logs?
Which log4j2.xml is the correct one to change if we need more details?
Any help is really appreciated!

This is related to OF-1676. I've updated the entrypoint.sh script to account for the changes to Openfire 4.3 and later. Images should appear on Docker Hub shortly.
To configure log4j, you should include a log4j2.xml configuration file in the Openfire configuration volume that you've created for your container. Note that this is a change from Openfire 4.2.x and earlier, which used a log4j.xml file instead.

Thanks for the fast reply - by now I had found a workaround for the original problem (patched the Jenkins plugin to write some meaningful errors in its log) but once we need the openfire logs again, we'll update to version 4.4.0.


Support for testing

The following changes run fine w/ Jest:
...
   textStyle: PropTypes.string,
    disabledStyle: PropTypes.string,
...
   background: PropTypes.any

But the original does not:
 FAIL  src/components/__tests__/FormButton-test.js
Runtime Error
  - TypeError: Cannot read property 'style' of undefined
        at Object.<anonymous> (node_modules/apsl-react-native-button/Button.js:22:25)
        at Runtime._execModule (node_modules/jest-cli/src/Runtime/Runtime.js:261:17)
        at Object.<anonymous> (src/components/FormButton.js:22:12)
        at Object.<anonymous> (src/components/__tests__/FormButton-test.js:27:16)
        at jasmine2 (node_modules/jest-jasmine2/src/index.js:252:16)
        at process._tickCallback (internal/process/next_tick.js:103:7)
1 test suite failed, 0 tests passed (0 total in 1 test suite, run time 6.012s)

I think we've had this discussion before - see pull request #12 -  I don't know how to support older Forks in my Repo and update to the newest?  I've got this for backward compatibility: https://github.com/bartonhammond/react-native-button.
Is there a way to get this addressed so I don't have to fork it just for testing?

Please see comments here: https://github.com/facebook/jest/issues/651

The thing is that the code in the props is completely right, this is more a Jest or Jest config issue, not about this component. I'm jumping again into the Jest issue, let's see if we can finally fix this.

I got a reference to try from the Jest team.  I will try later today and
report back.
On Jul 22, 2016 10:30 AM, "Álvaro Medina Ballester" <
<EMAIL_ADDRESS>wrote:

The thing is that the code in the props is completely right, this is more
a Jest or Jest config issue, not about this component. I'm jumping again
into the Jest issue, let's see if we can finally fix this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/APSL/react-native-button/issues/46#issuecomment-234575674,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABORPNCIJBto1H6WqavwDC8Z6r8qkGy2ks5qYOIJgaJpZM4JSJDp
.

The component is tested with snapshot tests and it's working great so far, do you still have any trouble testing @bartonhammond ?

No problem - thanks!

Great!
Please let me know if something else pops up!


Make debugging unmatched requests easier

Hey, thanks for the great library! I added some print statements in my fork because I found it cumbersome to debug failing tests. I can hide this logic behind a flag or something if you're interested in merging this PR

Thanks for the review! I'm currently trying to make a deadline, but I'll give this a pass in a few weeks if that's ok :)

Yeah that's fine for sure, follow up on your discretion I am always open for review!

Ok, I've made an initial pass at implementing the suggestions! Some notes:

I changed the implementation of Middleware.handle to return a reqwest_middleware::Error::Middleware instead of panicking, because it seems hard to test for emitted logs after panicking. In particular, catch-unwind does not take async functions. This would also allow for usage of this library in non-test contexts.
Due to the above, I added anyhow as a crate dependency because request-middleware v0.1.6 depends on anyhow already, and reqwest_middleware::Error expects an anyhow::Error
While tracing_test::traced_test successfully prints out the entire debug output, it appears to only save the first line when it comes time to call logs_contain. As such, I split each line of output when emitting the trace, and recombine them at the end of the test.

Let me know what you think :)

Released 0.2.1 version with changes: https://crates.io/crates/rvcr/0.2.1

Nice, thank you!


    Installed Android SDK Platform-tools, revision 19.0.199%)
    Stopping ADB server succeeded.
    Starting ADB server succeeded.
  Done. 1 package installed.

I'm updating the library packages.

Traceback (most recent call last):
  File "android.py", line 66, in <module>
    main()
  File "android.py", line 40, in main
    install_sdk.install_sdk(iface)
  File "buildlib/install_sdk.py", line 225, in install_sdk
    get_packages(interface)
  File "buildlib/install_sdk.py", line 160, in get_packages
    with open("android-sdk/extras/google/play_apk_expansion/downloader_library/project.properties", "r") as f:
IOError: [Errno 2] No such file or directory: 'android-sdk/extras/google/play_apk_expansion/downloader_library/project.properties'

This appears to be due to the current Android SDK having a different file structure than the version PGS4A was written to handle.

psg4a is obsolete. please see https://github.com/renpytom/rapt-pygame-example for a supported solution.


Issue with slackclient 2.7.3

Still sorting out exactly what the heck is going on here and will submit a PR when I do if needed but it appears slack has done something to deprecate aiohttp < 3.6 connections
https://github.com/slackapi/python-slack-sdk/issues/912
popped up a few hours ago but wanted to throw this here to save anyone else time trying to debug.
EDIT: appears you can fix it by upgrading aiohttp = "3.7.3"
note: this does not appear to be a slack-machine issue itself but will effect users of it none the less

I'm using slack-machine in docker, based on the docker image python:3-slim. Once I pulled the latest of that docker image and updated my local slack-machine build to the latest (which includes slackclient==2.9.3 from the requirements.txt), it pulled in aiohttp 3.7.3.
With all of that, it's back up and running for me. Thanks for opening this - helped me track it down!

I'm using slack-machine in docker, based on the docker image python:3-slim. Once I pulled the latest of that docker image and updated my local slack-machine build to the latest (which includes slackclient==2.9.3 from the requirements.txt), it pulled in aiohttp 3.7.3.
With all of that, it's back up and running for me. Thanks for opening this - helped me track it down!

Hi
Same for me but running aiohttp - pip install -U aiohttp makes the job and it's now running

Hi
Same for me but running aiohttp - pip install -U aiohttp makes the job and it's now running

This seems to be fixed upstream now, going to close.

This seems to be fixed upstream now, going to close.


CalledProcessError: Command '['hostname -I']' died with <Signals.SIGSEGV: 11>.

Not sure the cause, but trying to run multi-node training (launching with mpich), I'm getting the following error:
  File "/lus/grand/projects/datascience/foremans/locations/polaris/projects/saforem2/Megatron-DeepSpeed/dist.py", line 106, in init_deepspeed
    deepspeed.init_distributed()
  File "/lus/grand/projects/datascience/foremans/locations/polaris/miniconda3/envs/2022-09-08-hvd-nccl/lib/python3.8/site-packages/deepspeed/comm/comm.py", line 646, in init_distributed
    mpi_discovery(distributed_port=distributed_port, verbose=verbose)
  File "/lus/grand/projects/datascience/foremans/locations/polaris/miniconda3/envs/2022-09-08-hvd-nccl/lib/python3.8/site-packages/deepspeed/comm/comm.py", line 674, in mpi_discovery
    result = subprocess.check_output(hostname_cmd, shell=True)
  File "/lus/grand/projects/datascience/foremans/locations/polaris/miniconda3/envs/2022-09-08-hvd-nccl/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/lus/grand/projects/datascience/foremans/locations/polaris/miniconda3/envs/2022-09-08-hvd-nccl/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['hostname -I']' died with <Signals.SIGSEGV: 11>.

The error is originating from deepspeed/comm/comm.py:
https://github.com/microsoft/DeepSpeed/blob/46784cb58edf7bbe9b6bbec95212de7b81e55b01/deepspeed/comm/comm.py#L676
An easy fix would be replacing the
hostname_cmd = ["hostname -I"]
result = subprocess.check_output(hostname_cmd, shell=True)
master_addr = result.decode('utf-8').split()[0]

with
import socket
master_addr = socket.gethostbyaddr(socket.gethostname())[0]

Hi @saforem2 - sorry for the late reply.  This looks to be because the permissions of the hostname -I command that is trying to be invoked by DeepSpeed is failing on your system.  Do you know what is causing that?
Also would you mind making a PR with the suggested change?

Yeah, no worries. Honestly this was actually a (seemingly?) intermittent issue (that I haven't seen in a while, come to think of it) so I never bothered to pin it down.
I guess they both achieve the same thing, though maybe the method using socket is simpler ?
but yeah, happy to submit a PR if you think this would be preferred

Actually, I'm seeing different results on my machine using the two approaches, hostname is retuning the IPv6 address, the socket method is returning my machine name it seems.  To avoid breaking other things, perhaps we leave it as it is if its not causing issues that you've not seen in a while?

yeah sounds good, happy to close this then

Thanks for reporting the bug, and hopefully whatever was causing it remains fixed!


chore: upgrade to node >=20

What does this PR do?
Upgrade to node >=20

Do we want to delete package-lock.json?

Do we want to delete package-lock.json?

@sfdctaka This repo does not use yarn so did you mean whether we want to delete package-lock.json and then run npm install to regenerate the file with updated dep versions? We now have dependabot for such things so I didn't do such update in this PR and tried to keep it as simple as possible.

I made a mistake. I thought github had package-lock.json as deleted. Instead, the file is too big it didn't show the diff by default.

Or...do you think we deleted it and that's the question? 😀 FWIW I don't see anything amiss with package-lock.json in this PR.


Remove less config

Since less isn't needed anymore since 0.8, this can be removed.

Thanks @CumpsD


Add EnumChoice parameter type

Added a new ability to be able to create a choice parameter type from enum class.
How does it differ from Choice? Enums are the way of python to allow only a finite number of values to be accepted in a given scenario. It seems logical to me that click should offer a Choice-like parameter type that gets its values from an enum and returns an enum.
Now, using click.EnumChoice, one can create a Choice-like parameter that returns an enum instead of a string.
Moreover, once you add a new value to your enum class, it will automatically update as a valid choice for the paramater type.

[X] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[X] Run pre-commit hooks and fix any issues.
[X] Run pytest and tox, no tests failed.

Hey @davidism .
I would love to hear your feedback on this PR.

Does this PR need any changes?
Is it click 8.2.0 material? 9.0.0?
I would love to know so I could work on it if any changes are necessary.
I think this feature could really help the users of click.

The PR itself seems fine, but I'm not sure I want to merge it yet. You'll know when I make a decision because I'll update it one way or another.

Related to #605.

Why wouldn't you want to merge that? (Serious question)
What's in favor:

Enums have been in the stdlib for a very long time now and lead to cleaner and more robust code for exactly these kind of "choice problems".
This PR looks quite clean.  It adds little new code and has many tests.
There seems to be a high demand for this feature since nearly 6 years.  People have been updating the example in the Issue if it stopped working after a click update.

Looking forward to hearing your objections, @davidism :-)

@saroad2 If David would consider merging this PR, you should add tests using EnumChoice with a default value (because you cannot use MyEnum.option have to use MyEnum.option.name.  And I assume you will also add documentation than? :-)

Hey @davidism, have you been able to make a decision? 😃 I think @saroad2 would love to move forward with the PR and get this available for all Click users.

This PR still waits for @davidism approval.
I know there are issues about testing and API in this PR, but I can't work on it until David do an initial review.
Would love to see it getting merged.

@davidism i'd love to see this land, after all i just shipped a broken release of a cli due to a mistake with removing a choice and missing a purely stringly usage on a default all the tests would pass in correctly
had i been able to use enum i wouldn't have missed that

Hey @mjpieters, thanks for the review.
Are you from the Pallets team? Until someone from them take the time and address this PR, I'm not going to spend time fixing issues here. This PR is sitting here for over a year. I thought it would get merged by now.

i'll try to bring it up again on the discord, i'd love to see it land but i dont call the shot

Click or Jinja is my next focus, as soon as the new Flask and Werkzeug releases settle down. I had been focused almost entirely on Flask and Werkzeug for the last year.

Hey @mjpieters, thanks for the review.
Are you from the Pallets team? Until someone from them take the time and address this PR, I'm not going to spend time fixing issues here. This PR is sitting here for over a year. I thought it would get merged by now.

I'm not a member of the pallets team, no, sorry.
I have been using this implementation in production code, and found aliases to be a great way to improve a CLI where the spelling of some of the choices could cause confusion. Aliases solved those issues very, very nicely, without cluttering up the UI further.
So, I'd really love to see this become part of core click package, but with some form of aliases support included.

Click or Jinja is my next focus, as soon as the new Flask and Werkzeug releases settle down. I had been focused almost entirely on Flask and Werkzeug for the last year.

Thanks @davidism , I appriciate you. I hope to see it merged soon.
Click is used by a lot of users, and personally I find myself use it in most of my projects. Maybe it's time to consider adding more maintainers to this project for more routinely checks of this project. If you open up a call, I would happily suggest myself. I'm sure many others would too.
As for this perticular PR, once you review it, I would gladly start fixing issues here.

@saroad2 (+@mjpieters)
It might also be nice to allow constructing enums from member values and not keys, i.e. by using Enum(x) as opposed to Enum[x]. Note that Enum(x) would also respond to the built-in _missing_() functionality allowing you to concoct whatever you want in terms of aliases etc whereas Enum[x] would not.
Using __getitem__ on the enum type itself is pretty restrictive since in order to override it you need to mess with metaclasses whereas __init__ allows for the _missing_() workaround.
E.g. in cases like
class MyEnum(Enum):
    SNAKE_CASE_NAME = 'first'
    TOO_MANY_UNDERSCORES = 'second'

    @classmethod
    def _missing_(cls, obj):
        if obj == '1':
            return cls('first')
        elif obj == '2':
            return cls('second')
        return None

you would probably want it to respond to 1, 2, first and second rather than SNAKE_CASE_NAME and TOO_MANY_UNDERSCORES in the CLI.
This might also partially solve the case-sensitivity question (in fact, that's the example for _missing_() in the official docs).

Hey everyone!
I'm glad to see so many changes to Click since I last logged in to this project!
I'd happily work on this PR and prepare it for the merge.
But first, I still need @davidism, as the primary maintainer of this project, to review it beforehand since this is a new feature.
Once that happens, I'll work on addressing everyone's comments.
Meanwhile, I merged the main branch into the PR to make it up-to-date.

Hi! Any progress on this? Some way I could help?

Sad to see that after 8 yrs since the initial issue was logged there's still no native support for enums and string enums as click choices :-(
What can we do to change this?

I was looking into what was needed to get this into 8.2.0. I think we should do the following:
Include @mjpieters's suggestion to use __members__ to make aliases possible. However, instead of working around the implementation of Choice, change the implementation so aliases don't need special handling. We can do this by not relying on the Enum to str conversion and storing the concrete Enum value. I've done this as part of #2796.
This by itself should remove the need for an EnumChoice wrapper and allow you to pass an Enum to Choice. See #2796 for more info.

Closing this in favour of #2796.


Enable molecule tests

See https://github.com/openmicroscopy/ome-ansible-molecule-dependencies/pull/3

Pushed & green, @manics

👍


Fix mj-spacer default height

Docs say mj-spacer should have a default height of 20px but no default is set.
https://mjml.io/documentation/#mjml-spacer

Oops, this was already fixed in #1313


[nit] Avoid @types/node usage in public dependencies

EDIT: This was edited to become a tracking issue, the problem specified below will be tracked per library.

Is your feature request related to a problem? Please describe.
It is not ideal to have public dependencies on @types/node. It can cause issues due to type conflicts across node versions. Additionally, if any code is used from the browser, it can cause issues with webpack/rollup/etc.
Describe the solution you'd like
Remove @types/node dependency anywhere we're exposing a node.js type on one of our types.
Where we do expose a node.js type on our types, we should consider an alternative more scoped type or our own interface which duplicates the required surface area.
Describe alternatives you've considered
Can keep the dependency and set the version to "*" to set the user have greater control (since we can use engine setting to signal to users on versions older than we support).
[enhancement]
Tracking Status
adaptive-expressions

[ ] PR
[ ] Merged

botbuilder

[ ] PR
[ ] Merged

botbuilder-ai

[ ] PR
[ ] Merged

botbuilder-applicationinsights

[ ] PR
[ ] Merged

botbuilder-azure

[ ] PR
[ ] Merged

botbuilder-core

[ ] PR
[ ] Merged

botbuilder-dialogs

[ ] PR
[ ] Merged

botbuilder-dialogs-adaptive

[ ] PR
[ ] Merged

botbuilder-dialogs-declarative

[ ] PR
[ ] Merged

botbuilder-lg

[ ] PR
[ ] Merged

botbuilder-testing

[ ] PR
[ ] Merged

botframework-config

[ ] PR
[ ] Merged

botframework-connector

[ ] PR
[ ] Merged

botframework-schema

[ ] PR
[ ] Merged

botframework-streaming

[ ] PR
[ ] Merged

Agreed – this is causing projects that have specific @types/node version dependencies from building since it's bundled into the package:
node_modules/botframework-connector/lib/connectorApi/models/index.d.ts:1:23 - error TS4090: Conflicting definitions for 'node' found at<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Consider installing a specific version of this library to resolve the conflict.

1 /// <reference types="node" />
                        ~~~~

npm ls @types/node produces:
<EMAIL_ADDRESS><redacted_root>
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>deduped

Closing in favor of https://github.com/microsoft/botbuilder-js/issues/2429 and https://github.com/microsoft/botbuilder-js/issues/2427.

Closing in favor of https://github.com/microsoft/botbuilder-js/issues/2429 and https://github.com/microsoft/botbuilder-js/issues/2427.


Backporting from Python 3 to Python 2.6

I am working on a cluster which only supports Python 2.6.6  and bandicoot is coded in python 3 .
I was wondering whether it is more efficient to change some parts and do backports or take the old bandicoot version (2.6) and add the new indicators I need for my model (present in the new bandicoot version, not the old one). Could you please tell me which option seems the most suitable ? I would really appreciate.

Please have a look at https://github.com/yvesalexandre/bandicoot/tree/backport26. Most of the tests are now passing (48 passing, 8 failing).
I used Python 2.6.9, numpy 1.10, scipy 0.12, and networkx 1.9. to run the tests.


Greenkeeper/typescript eslint parser 6.0.1

Coverage remained the same at 100.0% when pulling 7df235bcbfa71ae32f4a98b14331ea546ee6d149 on greenkeeper/typescript-eslint-parser-6.0.1 into ade74cb49fc493624421693028e98d0f2d14af4b on master.


issue 很多的时候没有分页

显示不全

issue list no pagination if too many issues

Hi @zileyuan , with new code in develop branch, this issue should be fix. You can also test on https;//try.gogs.io .

https://try.gogs.io/unknwon/gogs/issues

Closed as implemented. :octocat:


Changed language code

According to the List of ISO 639-1 codes on Wikipedia, I changed the language code of Czech from CZ to CS.

Why would you do that?! Because according to the docs this is about flags.. not languages! :)
https://github.com/lipis/flag-icon-css#usage

In an application I use the ISO 639-1 codes to manage translations. To get the correct flag I changed the name of the file.

Anything else you need to change to match your needs?!

No, not at the moment :)

Awesome.. any time you need anything.. just come here and do whatever you want!


util: add env var AZURE_FP_SERVICE_PRINCIPAL_ID

Which issue this PR addresses:

Fixes 10128055
What this PR does / why we need it:
FF-int fails when trying to list the service principals (permissions) to get the object ID.  This PR will query the object ID from the RP-Config and set the necessary parameters without having to use the sp app id to get the object id.

Test plan for issue:
Current unit test/e2e tests and deploying FF-int in a pipeline.

Is there any documentation that needs to be updated for this PR?
No

/azp run E2E

/azp run E2E

Tests are timing out, https://github.com/Azure/ARO-RP/pull/1547 to increase timeout.

/azp run e2e

Manually ran pipeline with env var AZURE_FP_SERVICE_PRINCIPAL_ID set to "int" and results are here.
E2E passed but want to make sure that plumbing is vetted for fpServicePrincipalId in code changes.  @jewzaam

/azp run E2E

@m1kola I'm dismissing your review as the comment is addressed.  If that is incorrect please let me know and we can address in a new PR.  We have time before we cut a new RP release and my understanding is we're good on this guy now but.. lmk!

All looks good to me. Thanks for the heads up!


How to Save instance from evaluation script

python main_instance_segmentation.py
general.project_name="s3dis_eval"
general.experiment_name="area1_pretrained_eps_0.6_topk_-1_q_100"
general.checkpoint="/home/jalam/mythili_wd/Mask3D/checkpoints/area1_scannet_pretrained.ckpt"
general.train_mode=false
data.batch_size=4
data/datasets=s3dis
general.num_targets=14
data.num_labels=13
general.area=1
model.num_queries=100
general.topk_per_image=-1
general.use_dbscan=true
general.save_visualizations=true
general.dbscan_eps=0.6
After running the above command my terminal looks like this, and one folder is created saved which have only logs , how can i save the instance from the network , can you please help me here

sorry my bad was passing path wrong


[Workers] Cross-link + remove dupe Python examples

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

[x]  /workers/languages/javascript/
[x]  /workers/languages/typescript/

Not applicable as the set URL continues to exist


#36614 [CUBRID] Fix incorrect script generation when creating a trigger using the UI

When creating a trigger using UI, the generated SQL script is incorrect. It doesn't have before trigger name which will lead to error.

Thanks for the contribution!


Laravel 8 support

Can you please update to support Laravel 8?
Thanks

@bruno9520 version 2.4 has been released with Laravel 8 and PHP 8 support. Please let me know if you are facing any issues

i got an error like this
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires nahid/talk ^2.4 -> satisfiable by nahid/talk[v2.4.0].
    - nahid/talk v2.4.0 requires pusher/pusher-php-server ^5.0 -> found pusher/pusher-php-server[dev-master, v5.0.0, ..., 5.0.x-dev (alias of dev-master)] but it conflicts with your root composer.json require (^7.2).

my laravel version is 8.83.2
php version is 8.1
how can i install talk to this laravel version ?


release 0.18.0 or 0.17.1

Release an new version including fixes for the buffer type
Since we still have a 0.. Version I guess we can ship 0.18.0.
@lnicola what do you think? Also are there other things we should include?
(I can do the release tomorrow morning. Not at home today, sorry)

I think we should release 0.17.1 now, and 0.18.0 with more changes (the bundling PR, at least).

v 0.17.1 is now at crates.io thanks to all involved in this release. Lets plan the next feature release :)


Domain activation is Failed - One or more of the CNAMEs ... already associated with a different resource

App Id: d16deb11qo7fw6
Region: us-east-1
Step: Domain activation
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
The system consistently does not activate my domain. I see it creating the records for the two CNAMEs I have. I do not know what more it's trying to do.
I attempted to delete the two records it seems are in conflict, (bare domain + www) but it continues to fail.
I used about the same procedure on several other domains, migrating them over to Amplify CD, and they all worked :\ can't figure out what the difference is here.
Error message
One or more of the CNAMEs you provided are already associated with a different resource.
Note: Be sure to check the message for sensitive information.
Additional information
No idea what would be relevant.

OK after more digging around, I found that I had those names assigned to a different cloudfront distribution. After removing that distribution, it activated OK.

OK after more digging around, I found that I had those names assigned to a different cloudfront distribution. After removing that distribution, it activated OK.


Create Tournament objects from the tabbycat API

For similiar reasons to #4.

I identify 2 main problems here.
Primarily that the API doesn't (as far as I am able to tell, both from prodding around and looking at the documentation) give acces to speaks and results on a per round basis. This alone probably already dooms this idea as the information that it would be able to fetch would be very limited.
Furthermore, even the data that is available varies greatly from tournament to tournament based on the privacy settings. This means that 1) the information available is even further limited and that 2) implementation seems quite painful.

Scraping seems like a decent workaround but the tabbycat T&C need to be checked first before that.

Seems to be possible as of https://github.com/TabbycatDebate/tabbycat/pull/2207.


Teku

Does Dirk work with Teku? Can you show how to use this tool with Teku and Prysm for Medella?

We have plans to talk to the client teams regarding use of Dirk directly with their validator clients, but there is no direct integration available today.

Vouch can talk to Teku via the now-standard REST API, and use Dirk as its signer.  Details on how to use Vouch withe Teku can be found in the link provided.

Vouch can talk to Teku via the now-standard REST API, and use Dirk as its signer.  Details on how to use Vouch withe Teku can be found in the link provided.


Segmentation fault (core dumped)

Running the network example I get the following error:
Total vertices : 7564	Total edges : 102372
Fitting model	Alpha: 0.989569 Progress: 1.043%Segmentation fault (core dumped)

Running it several times it manages to progress from around 1% to around 4% but never beyond. Any insights?

There are several reporting this issue. I think the problem is in visualize_thread. The line p=sample_an_edge(gsl_rng_uniform(gsl_r), gsl_rng_uniform(gsl_r)) is returning p >= n_edges.
Could you please run using gdb to confirm?
gdb --args ./largevis -input inputfile.txt ...


CodeHinter gets confused completing a pre-populated attribute

To my understanding, the hinter should completely replace the contents of the "" when doing a hint replacement. It's somewhat unreliable at the moment:

Dont forget cases when we have multiple statements inside ""
ex: class="class1 class2"
So maybe the delimiter should be spaces aswell?

I was able to repro it. The url hints are handled with the url code hints and those always replace the entire string, unlike other code hint providers. It looks like the issue occurs when deleting some chars, and not when just typing them.
CC: @redmunds

To my understanding, the hinter should completely replace the contents of the "" when doing a hint replacement.

In most cases, code hints will not completely replace the contents for the sake of being safe (and not removing desired content).
For URL hints, they should insert folder names and replace file names, so, yes, this looks like a bug.

This should be fixed now that #11284 was merged.

👍


login error when upgrading

I've been running an old version of bluestream for a while now (from commit #13) with no issues. I downloaded the latest code, copied the .env from the old directory to the new one, and am getting the following error:
Watcher Process started. error: Uncaught (in promise) Error: Invalid identifier or password     at ServiceClient.call (file:///home/jackie/.cache/deno/npm/registry.npmjs.org/@atproto/api/0.6.20/dist/index.js:15582:15)     at eventLoopTick (ext:core/01_core.js:168:7)     at async BskyAgent.login (file:///home/jackie/.cache/deno/npm/registry.npmjs.org/@atproto/api/0.6.20/dist/index.js:26483:19)     at async login (file:///usr/local/src/bluestream.git/login.ts:33:3)     at async file:///usr/local/src/bluestream.git/server.ts:21:15
I've recreated the deno cache (rm -fr /home/jackie/.cache/deno) and still no luck. I can go right back to the old version, and it works fine. Did something change about the .env file format? Was there some kind of bug introduced when the login was refactored? I'm stumped as to why the old version works, but the new one doesn't

I finally circled back to fix this: the password needs quotes around it with the newer code commit:
BLUESKY_IDENTIFIER=.bsky.social
BLUESKY_PASSWORD=""


tox.ini: Remove -x flag for unit tests

The -x makes py.test abort the test run after the first failure. While this makes the tests fail faster , it is inconvenient if there many tests that are failing, because you will only see 1 test failure and you will have to fix each failure one at a time.

Can one of the admins verify this patch?

This was added purposefully. High level reasoning is that the CI is supposed to be a check rather than a way to find out what tests are broken. And since the tests take so long to run, finding out there is a failure earlier is helpful. Lower level reasoning is that the tests expect a clean cluster, and (sadly) not all the tests clean up after themselves on failure. In practice, what happened in general without this is subsequent failures were due to the first failure, so it wasn't beneficial.
I know you've had trouble running the integration tests, I think time would be best spent getting that to work so you can have faster turnaround. Want to get on slack and get that to work? Or lmk what
problems you are having and see if we can figure it out?

Yeah that makes sense and I figured there was probably a reason for it.
I think it makes sense for me to invest a little time in getting the integration tests working for me locally on my machine. I don't think I tried that hard and especially not since discovering dcos-Docker.
Very much appreciate the offer to help me on Slack. I think I'll try to get it going on my own and if I run into troubles, I might take you up on that offer.


Update for latest ember inspector

This change and a patched ember inspector needs to happen first, so filing this PR to show what needs changed.
Presumably the best thing to do is wait until a new inspector release that includes emberjs/ember-inspector#505, then update this PR to point to that version in package.json

Anything blocking this? Looks like tests need to be restarted.


python3 cross compatibility and django=1.8

hi, i am experiencing some bug while using the DjangoLogstashFormatter with django 1.8 and python 3.4.
it seem that this lib is not compatible with either one by 2 at least two lines :

logstash_async/formatter.py:235  extra_fields['req_uri'] = request.get_raw_uri()

but django WSGIRequest object has no get_raw_uri() in version 1.8 (LTS). I propose to skip this extra_fields for later versions.

logstash_async/formatter.py:236: extra_fields['req_user'] = unicode(request.user) if request.user else ''

you use unicode, which is a 2.7 only string type. you can either import six or do a try: except ImportError for string types to be cross compatible.
this is the only 2 things a saw for now, but I will keep investigating.
it is a best practice to support from current LTS to current stable for your app. that's why I speak about 1.8...
https://www.djangoproject.com/download/#supported-versions
If you want to be python3 compatible and LTS compatible, I can eagerly do a PR to fix all thing a found and build some unittests to check it all.

A PR is very welcome. I usually just test and use against Python2 and Django 1.10, to be honest.
While properly supporting Python3 I fully support, I don't feel so strong about supporting Django 1.8 but since it is probably rather easy, why not.
Tests are on my TODO list but so far I didn't get it to yet.

request.user is now checked for existence before being accessed and I replaced unicode by text_type from the six library. So both issues should be fixed.
I still plan to add unittests at some point.


Incorrect f-string parsing

Originally reported as https://github.com/astral-sh/ruff/issues/5044:

Not the best string ever, but ruff doesn't handle it like Python
λ cat test.py
print(f"$N_{{img}}\in\{{0,1,2\}}$")
λ python test.py
$N_{img}\in\{0,1,2\}$
λ ruff check test.py --select F401
error: Failed to parse test.py:1:25: f-string: unterminated string

I'll look into StringParser.parse_fstring.


*: Many possible spelling mistakes.

Bug Report
What version of TiKV are you using?

N/A
What operating system and CPU are you using?

N/A
What did you do?

As the pic says, we could fix these spelling mistakes to make the code fresh.

Cool! Can you send a PR to fix these?


Hi ,please help me.

English: Hello, I have been using afterglow for a long time and I feel great and thank you!
I would like to know, is it possible to add in the player the keys "go forward 10 seconds and go back 10 seconds" like youtube?

Afterglow won't get this feature oob any time soon, but you can of course use the api to build the behaviour. Take a look at http://docs.afterglowplayer.com/docs/api - you should be able to get and set the current time. So get it, add 10 seconds and then set it to that.


WIP - Add file metadata ITs

This adds integration tests to verify stored ranges work correctly for file metadata.
There is more work to be done with adding more tests and also clean up as there is some copy/pasted stuff but wanted to push up what I have so far after merging in #3480

Example output from running the current splitsWithExistingRangesTest() where there are 3 existing ranges for a file and then we ingest data and add splits after:
Read in initial 1000,000 records and verify
100,000 records written |  225,225 records/sec |    3,900,000 bytes written | 8,783,783 bytes/sec |  0.444 secs
100,000 records read |  289,017 records/sec |    3,900,000 bytes read | 11,271,676 bytes/sec |  0.346 secs

Take table offline and manually updated to fence the RFile so only 75,000 records should be readable
Row: 1<; File Name: F0000001.rf; Range: [row_0000000000%00; : []<PHONE_NUMBER>854775807 false,row_0000025000%00; : []<PHONE_NUMBER>854775807 false); Entries: 25000, Size: 5013
Row: 1<; File Name: F0000001.rf; Range: [row_0000050000%00; : []<PHONE_NUMBER>854775807 false,row_0000075000%00; : []<PHONE_NUMBER>854775807 false); Entries: 25000, Size: 5013
Row: 1<; File Name: F0000001.rf; Range: [row_0000075000%00; : []<PHONE_NUMBER>854775807 false,row_0000100000%00; : []<PHONE_NUMBER>854775807 false); Entries: 25000, Size: 5013

Bring online and verify only 75,000 can be read
25,000 records read |  268,817 records/sec |      975,000 bytes read | 10,483,870 bytes/sec |  0.093 secs
2023-07-14T11:26:13,759 [test.VerifyIngest] WARN : Scan returned nothing, breaking...
50,000 records read |  342,465 records/sec |    1,950,000 bytes read | 13,356,164 bytes/sec |  0.146 secs

Add 10 splits, each of 10000 records
Row: 1;row_0000010000; File Name: F0000001.rf; Range: [row_0000000000%00; : []<PHONE_NUMBER>854775807 false,row_0000025000%00; : []<PHONE_NUMBER>854775807 false); Entries: 8333, Size: 1671
Row: 1;row_0000020000; File Name: F0000001.rf; Range: [row_0000000000%00; : []<PHONE_NUMBER>854775807 false,row_0000025000%00; : []<PHONE_NUMBER>854775807 false); Entries: 10000, Size: 2005
Row: 1;row_0000030000; File Name: F0000001.rf; Range: [row_0000000000%00; : []<PHONE_NUMBER>854775807 false,row_0000025000%00; : []<PHONE_NUMBER>854775807 false); Entries: 6667, Size: 1338
Row: 1;row_0000060000; File Name: F0000001.rf; Range: [row_0000050000%00; : []<PHONE_NUMBER>854775807 false,row_0000075000%00; : []<PHONE_NUMBER>854775807 false); Entries: 10937, Size: 2193
Row: 1;row_0000070000; File Name: F0000001.rf; Range: [row_0000050000%00; : []<PHONE_NUMBER>854775807 false,row_0000075000%00; : []<PHONE_NUMBER>854775807 false); Entries: 6027, Size: 1208
Row: 1;row_0000080000; File Name: F0000001.rf; Range: [row_0000050000%00; : []<PHONE_NUMBER>854775807 false,row_0000075000%00; : []<PHONE_NUMBER>854775807 false); Entries: 8036, Size: 1612
Row: 1;row_0000080000; File Name: F0000001.rf; Range: [row_0000075000%00; : []<PHONE_NUMBER>854775807 false,row_0000100000%00; : []<PHONE_NUMBER>854775807 false); Entries: 6000, Size: 1202
Row: 1;row_0000090000; File Name: F0000001.rf; Range: [row_0000075000%00; : []<PHONE_NUMBER>854775807 false,row_0000100000%00; : []<PHONE_NUMBER>854775807 false); Entries: 9000, Size: 1805
Row: 1;row_0000100000; File Name: F0000001.rf; Range: [row_0000075000%00; : []<PHONE_NUMBER>854775807 false,row_0000100000%00; : []<PHONE_NUMBER>854775807 false); Entries: 10000, Size: 2006

Re-verify only 75,000 can be read
25,000 records read |  112,107 records/sec |      975,000 bytes read | 4,372,197 bytes/sec |  0.223 secs
2023-07-14T11:26:20,456 [test.VerifyIngest] WARN : Scan returned nothing, breaking...
50,000 records read |  109,170 records/sec |    1,950,000 bytes read | 4,257,641 bytes/sec |  0.458 secs

Run a compaction and show output of files
Row: 1;row_0000010000; File Name: A000000e.rf; Range: (-inf,+inf); Entries: 10000, Size: 2190
Row: 1;row_0000020000; File Name: A000000f.rf; Range: (-inf,+inf); Entries: 10000, Size: 2204
Row: 1;row_0000030000; File Name: A000000l.rf; Range: (-inf,+inf); Entries: 5000, Size: 1191
Row: 1;row_0000060000; File Name: A000000j.rf; Range: (-inf,+inf); Entries: 10000, Size: 2201
Row: 1;row_0000070000; File Name: A000000k.rf; Range: (-inf,+inf); Entries: 10000, Size: 2201
Row: 1;row_0000080000; File Name: A000000g.rf; Range: (-inf,+inf); Entries: 10000, Size: 2202
Row: 1;row_0000090000; File Name: A000000i.rf; Range: (-inf,+inf); Entries: 10000, Size: 2202
Row: 1;row_0000100000; File Name: A000000h.rf; Range: (-inf,+inf); Entries: 10000, Size: 2222

Verify after compaction
25,000 records read |  112,107 records/sec |      975,000 bytes read | 4,372,197 bytes/sec |  0.223 secs
2023-07-14T11:26:20,456 [test.VerifyIngest] WARN : Scan returned nothing, breaking...
50,000 records read |  109,170 records/sec |    1,950,000 bytes read | 4,257,641 bytes/sec |  0.458 secs

This is just a new IT for checking if ranges are read correctly by scanners after ingesting and changing the files to fence so I'm going to ahead and merge it into the no-chop-merge branch now that I bought it up to date.


Testingthree db

-added +2 lives if level won.
-attempt to test collision.

Thanks for getting the game test set up. Also love the ability to increase lives if you pass a level :)


feat(jwt): add support for different date formats

A draft PR for #1501
Author should do the followings, if applicable

[ ] Add tests
[ ] Run tests
[ ] yarn denoify to generate files for Deno

Hi @NicoPlyley
Thanks for this PR. Looks good for me. But I want to know the opinion of @Code-Hex .
cc: @Code-Hex
What do you think about this? And if it's OK, could you review this?

Hi @NicoPlyley and @yusukebe
According to RFC 7519, it is stated that exp, nbf, and iat must always be NumericDate values.
NumericDate is the last definition in Section 2. Terminology, and is defined as the number of seconds (not milliseconds) since Epoch:

A JSON numeric value representing the number of seconds from 1970-01-01T00:00:00Z UTC until the specified UTC date/time, ignoring leap seconds.  This is equivalent to the IEEE Std 1003.1, 2013 Edition [POSIX.1] definition "Seconds Since the Epoch", in which each day is accounted for by exactly 86400 seconds, other than that non-integer values can be represented.  See RFC 3339 [RFC3339] for details regarding date/times in general and UTC in particular.

I think it is desirable for a widely adopted library that provides a JWT package to be strict in its specifications. This is because users sometimes prioritize strictness over convenience.

Thanks @Code-Hex
It is certainly important to follow the Spec and I agree with you.
@NicoPlyley :
What do you think about this?

I am okay with any decision you make. I got the idea from other popular packages like json-web-token and jose which do allow different types of input. But I understand if it's not in the realm.

Hi @NicoPlyley
Thank you for your understanding. We will not accept and close this PR at this time. Thank you and contribute again.


[EOSF-488] Add support for Spanish translation

Ticket
https://openscience.atlassian.net/browse/EOSF-488
Purpose
Continuation of https://github.com/CenterForOpenScience/ember-preprints/pull/240. With the addition of a test for this and future translations.
Side Effects
New items included in translation.js in english will need at least a placeholder translation on every other language.

Muchas gracias. ¡Esto es increíble!

💯

@brianjgeiger, if we do want this feature, the sooner it is merged the better, as tests will begin failing on develop when we merge any PR pointed to develop which includes new terms. This also means that this will require continual upkeep if it doesn't get merged.

@hmoco Only one thing missing. Let's get that fixed and then get this merged in.

I went through these kind of quickly and most look pretty good. There are couple that might not have the meaning exactly right and a couple of places where verbs were used when nouns should have been, but I'd say good enough for now.


3.3.19 Known UI bug - Create Foxx Service -> Mountpoint error

Hi @everyone,
we have just published ArangoDB 3.3.19 and noticed the following Foxx bug in the Web Interface.
When trying to create a Foxx service in the Web UI with a string containing only letters for Mountpoint:  the error message May not contain /APP is shown and it is not possible to click the "Install" button.

It is possible to work around this bug by adding a / at the beginning of your Mountpoint.

This issue will be addressed in the next release 3.3.20.

FYI this bug is affecting also 3.4.0_rc3

Both versions 3.3.20 and 3.4 GA, which include a fix for this issue, have been released.


ZPE should honor case sensitive actions and resources

Today, ZPE assumes all actions and resources are lower case, but with a recent feature addition, this assumption is not true anymore.
This feature requires ZPE to honor the case of action and resources and make authorization decision accordingly.
Expectations:

working code with corresponding unit tests with 100% code coverage

Hi @abvaidya I would like to work on this issue, please assign it to me

Hi @abvaidya.
When you say ZPE assumes all actions and resources are lowercase, what exactly are you referring to? Can you please provide some explaination?


Convert from HTML convenience function

The current slate component has an importFromHTML function that is called in a lot of the examples, but it is not really exposed via any API. So right now if I want to initialize an editable from an HTML String, I have to create my own State-JSON-object that has a cell with the slate plugin and whose state is just importFromHTML: "<div> ... </div>, which seems like a lot of hassle.
A convenience function that would be called with something like:
editor.trigger.editables.add(editor.utilities.convertFromHTML(HTMLString))
Would be a lot nicer

The issue here is that we can't really import layouts, which is why this isn't currently supported. One possibility would be to have a helper that simply creates one text cell and imports HTML.

Yeah, at least in my use-cases I am looking at simple text-markup in HTML. So that would be sufficient for me. Maybe we could name the function something that makes that limitation clear, maybe importHTMLTextMarkup() or something like that.

@arekkas Can you please elaborate: why can't we set up the editor to import layouts?
Is there any possibility of converting HTML to react and then importing the react components into the editor?

The problem is that no layout grid is the same across a number of websites. One html snippet could use bootstrap grid, another uses material ui grid, another one uses flexbox grid, and another one uses it's own mechanism. Additionally, HTML is primarily a language for displaying content so it's impossible to rely on developers doing sane things with their html. One developer might nest 3 divs in order to create a layout, another one uses a table.
As you see, it's very difficult to analyze layouts and create a sane and understandable model from it.

Thanks @arekkas !
I have a thought: what if we simplified the task by allowing conversion from a single grid type?
[The case is that we want to allow our users to create their own HTML documents and import them into the editor.  We could make any stipulations that we'd like.  For instance, we could say that you can import an HTML document using a bootstrap grid for layout.]

Then we would only serve one use case, which is using bootstrap for grid layout. We need to solve this generically or it's not really worth the work.
In your use case, if you know that people use only one way to write the mark up, you could easily process the html to a json object yourself and give that to the editor.

@arekkas any tips on how best to process the html to a json object?  (You mean programatically  or manually?)
BTW, I do see huge benefits to serving the one use case:
(1) you'd make the ORY editor directly accessible to a common format towards which people like me could steer users
(2) it would be a basis for a general solution, because we could use external converters if they exist or expand the solution slowly to accept other formats.
(3) indirectly you'd be supporting moving the world toward a standard for HTML layouts.  (As the Ory editor hopefully gets widely adopted, the supported format will come to be favored.)
In general, supporting input from HTML, no matter what constraints you demand, would vastly expand the usefulness of the editor!

@arekkas Any updates on this?

Sorry, not really. The same limitations apply.

this is now possible:

import slate from '@react-page/plugins-slate';

const mySlate = slate(/* customize slate, e.g. add custom plugins */)

const slateState = mySlate.htmlToSlate(htmlString);

it also honors all defined plugins properly


Why not expose all the parameters of the RandomForestRegressor?

Also, would using the ExtraTreesRegressor also in this framework? It seems simple to just add a base_estimator parameter, allowing the user to use whatever he/she wants?
I can submit a pull request if it makes sense to add these features.

I just added this also. I'm thinking of just permanently forking this problem and seeing how bad complete model generalizations would be.

This is really nice! I've been meaning to do this for awhile myself because it is generalizable like you propose. I wonder if we can just merge these into a single project.
I also have another idea make the fit() call look more like the fit calls of PyTorch and Keras where you pass a validation set as well. This is the right way to check if you've run enough iterations, etc.


feat(logger): support NO_COLOR

Related: https://github.com/honojs/hono/pull/2007
This PR adds utils/colors.ts.
We have to support NO_COLOR.
Author should do the followings, if applicable

[x] Add tests
[x] Run tests
[x] yarn denoify to generate files for Deno

@ryuapp
This is great. I'll review the details later. This will be introduced in the next "minor"  version.

Hi @ryuapp !
Thanks. I'll merge this into the "next" branch for the v4.1.0. It will be released maybe soon!

Can we please add this to the Hono docs at (https://hono.dev/docs/middleware/builtin/logger)?
# Tip

To disable _status code coloring_, you can set a "NO_COLOR" environment variable. This is described at (https://no-color.org/).

Hi @StuartMoncrieff
Adding this to the docs is a good idea. If so, we have to write the caution that it does not work on environments such as Cloudflare, which does not support NO_COLOR: related to #3752 #3751
@StuartMoncrieff Can you create a PR for it on honojs/website? That will be helpful.

Thanks @yusukebe! I have created a pull request: https://github.com/honojs/website/pull/553.


Data race when running scripts concurrently

When I run multiple scripts concurrently, I get a data race when the global variables Packages and PackageTypes are accessed here and here.
I add and remove packages from env.Packages and env.PackageTypes before a script is executed. That's why I get a data race because the access to those global variables is not synchronised. I was able to fix this issue by allowing packages to be defined on an environment level – see pull request below.
Might be related to #34

Thanks. Could you please add tests?

Done

@mattn Any chance to get this merged?


ripple-show="false" does not disable ripple

Confirmed on firefox, untested on other browsers.
The ripple shows up even when the ripple-show property is set to false.

we're also having the exact same issue and it doesn't seem to be working in firefox or chrome


Added guard for invalid cost

Related to #57
Thanks @mcdappdev

Not sure why there's no max #define macro (even if 31 isn't actually real)


fix: view all blocks and view all transactions incorrect redirect

To reproduce

Open Explorer, select Network -> Testnet
Under “Recent Blocks”, click “View all blocks”
Observe that the /blocks page is now showing Mainnet blocks instead of testnet

Same issue with "View all transactions"

:tada: This PR is included in version 1.52.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add missing license file

According to the extension listing on the Visual Studio Marketplace, this extension has an MIT license. But the link there is a 404: https://github.com/Microsoft/vscode-docs-authoring/blob/HEAD/LICENSE. This PR adds that missing license file with the MIT license content available on the Choose a License site.
Assumptions
When adding the new license file, a few assumptions were made. Any that are incorrect will require adjustments.

Assumes this extension was intending to use the MIT license. If not, the content of the license file can be swapped here, and the extension listing will need updating too.
Assumes the copyright start year should be "Copyright (c) 2018 - present". I based the dates on the date of the earliest commit to the repo via git rev-list --max-parents=0 HEAD. The "- present" was pulled from what they use on the Visual Studio Code repo](https://github.com/microsoft/vscode/blob/main/LICENSE.txt#L3).
Assumes the copyright entity should be identical to what is used on the Visual Studio Code repo: "Microsoft Corporation".

Possibly related
If I am reading issue #746 correctly, this may allow closing that issue.

Think the URL needs to be pointed at https://github.com/microsoft/vscode-docs-authoring/blob/main/packages/docs-authoring-pack/LICENSE instead

It's very possible, though I don't know where one sets the license URL on an extension yet. That would certainly be an easy fix, if it's possible.
That does explain where the MIT license came from in the marketplace listing, though.
https://github.com/microsoft/vscode-docs-authoring/blob/main/packages/docs-authoring-pack/package.json#L53


Add the ability to prevent a player from picking up experience.

There is currently no event to prevent a player from picking up experience.

PlayerExpChangeEvent should cover this.

@Deamon5550 As far as I can see, that's an event called when a player's experience changes. This issue is for a 'PlayerPickupExperience' event, to prevent a player from picking up experience orbs.

Like a player/entity event between the xp orb and player. There should also be a way to avoid the targetting of xp orbs (or other entities) for spectating / vanished players.

Well by checking if the difference in the player's experience is positive and cancelling you are preventing them from gaining experience, since the only source of a player gaining experience is via picking up experience orbs this is effectively the same thing. Perhaps an argument can be made for requiring finer contols over the player's interaction with experience orbs but I'm not really seeing a use case.
Other than hiding players that is, however, by what means are the player's hidden? if there was (is there?) some way to set a player as hidden from other players via api this would be better handled by that rather than with a seperate switch for whether a player interacts with experience orbs.
Perhaps you could explain better what it is you want this for.

@Deamon5550 Even if you negate the experience change, the orb would still disappear. I think this is a need to stop the entity from going into the player in the first place, not just the experience change. If experience orbs were used as FX or there was a game where they were only supposed to be picked up by one team (power ups maybe) you would want to stop the entity from disappearing or even navigating to the player.

@AlphaModder
That is a good point. We should probably add an event for that.

Something like
EntityPickupEntityEvent
Or
EntityAttractedByEntityEvent
Or more specific events for xp orbs only.

That is a good point. We should probably add an event for that.

Possibly, we could hook into the EntityXPOrb to use a TargettedEntityData manipulator.....

@bloodmc
Can you add in the ability to keep an exp orb from being attracted to you? Does it actually move towards you or is that an effect? Do our current events support this?

@Zidane It's totally possible to dictate to the xp orb where to go actually.

In order to prevent players picking up orbs you can listen to CollideEntityEvent and cancel the collision if it involves a Player and ExperienceOrb.
As for the orbs attraction to the player, maybe that could be represented in ExpOrbData as Value<Player> targetPlayer()

This is perfectly handled with TargetLivingData and contextualized data. Also, a few events that need to be verified for checking:
CollideEntityEvent, DataHolderChangeEvent, etc.


Support multiline strings in notebook file

Implements #6431, which we've been talking about doing for quite a long time now. This will make the edit perf improvements easier to do, as we won't need to translate a range from an editor into some offset for a source that is a single line.
Here's a sample serialized code cell, with the before and after:
Before:
{
"cell_type": "code",
"source": "p\nm",
"metadata": {},
"outputs": [],
"execution_count": 0
}
After:
{
"cell_type": "code",
"source": [
"p\n",
"m"
],
"metadata": {},
"outputs": [],
"execution_count": 0
}

Will send another PR after weird merge conflicts are resolved.


Remove flags from banner

The SVG on our landing page has been broken for some time now. The problematic files are this one and this one
Easiest way is to just remove all the flags, a creative solution (without specific country flags) would be nice too.

done

Fixed by pull request #29


[1.11.2] Food value tooltips incorrect with HCHunger

There's a couple of mods that add food value to the tooltip. When HCHunger is enabled, these tooltips don't match what the food actually restores when eaten. For example Steak and Potatoes has the value tooltips shown below, but when eaten only restore about 3 pips on the hunger bar.
AppleSkin - 1.0.6

Quark - r1.2-91

BWM Version: 1.2.7

That is due to the fact that hunger is entirely different in BWM. We scaled the hunger bar to have be 6 times as large, so that food can be more finely valued. So, divide what is shows by 6, and that is the proper value.

Should the affected mods update their tooltip rendering to account for max hunger then? Is that a value that can be taken easily or is it internal to BWM?

It's certainly possible for other mods to take into account if HCHunger is available and react accordingly, that would be up to them.

How exactly would one go about fixing this?

I have added an event into our API, FeatureEnabledEvent. Just subscribe to that and when "hchunger" is enabled, you would simple have to divide the food value by 6.

@Vazkii it looks like the method of including the event class is not currently working--the event listener never gets called (new Quark version doesn't do the hunger value scaling, and couldn't get it to work in AppleSkin).
@primetoxinz is it certain that the event is being fired?

The event is post definitely fired during preInit (here)[https://github.com/BeetoGuy/BetterWithMods/blob/1.11/src/main/java/betterwithmods/module/Module.java#L136]

Perhaps it's being fired before Quake/AppleSkin's handlers are registered?
I just stumbled on the fact that (I think) any mod that includes the BWM API package-info gets put in the load order after the dummy BWM API container, which is loaded after BWM, so it seems like it might not be possible for this event to be heard during preInit (I found it by creating an impossible load order by trying before: betterwithmods in AppleSkin).
Seems like the event will need to be delayed until after we can register our event handlers.

I can always fire it in init or post, which ever you'd prefer

Doesn't matter to me, whatever you think would be best. I'll be registering the listener in preInit.

Alright. This change to the event firing does in fact fix Quark's implementation. Although @Vazkii I did not take into account your existing division by 2, it should be actually be 6

Alright, cool, support added to AppleSkin via https://github.com/squeek502/AppleSkin/commit/3e45fe0c187a10320920dd079cbc695e84e0547d, will be in the next version.

Awesome, gonna close this unless something else comes up.


[Impeller] Bundling Vulkan support for Impeller on Android is expected to cause a size regression

I’m looking at linking Vulkan on Android builds by default, this will make it easier to switch between

Skia
Impeller + Vulkan
Impeller + GLES

This is as opposed to adding a new variant. Doing so does bring about a size increase:
Before (android_release_arm64):

flutter.jar - 5.2M
libflutter.so - 149M  (unstripped)

After (android_release_arm64 with Vulkan):

flutter.jar - 5.35M
libflutter.so - 151M (unstripped)

Capturing discussion:

Seems acceptable on first look.
Look at the CI for the tree-maps to see where the size increase is coming from.
Notify relevant parties and rollers.

In theory, SkiaPerf should flag the Engine -> Framework roll commit when this hits the framework. (If that doesn't happen, then we will need to adjust the filters there.)

Hmm, the ~150k increase is larger than we've observed from the other backends at ~100k. But, it's acceptable and likely attributed to VMA. I can't think of anything else that would cause this.
When we land this, can we pull and attach the engine size tree-maps to this issue for analysis. I do this using gsutil cp -R gs://flutter_infra_release/flutter/<ENGINE_SHA_GOES_HERE>/android-arm-release/sizes .. But its a public bucket and there is probably a web interface I don't know how to access.

I posted this on the PR, but the linked PR didn't seem to have much effect on the binary size overall. Is there more to come?

@dnfield Thanks for taking a look. I am not sure why there is a discrepancy between my local builds vs the ones on CI. But this is good news.  It might be that CI was building with a different set of flags. These were mine:
./flutter/tools/gn --android --android-cpu=arm64 --runtime-mode=release
I then took a look at the size of flutter.jar. Would appreciate if you could give it a shot locally to see if it's my setup issue.

I did a quick analysis of the difference in object file sizes when building an android_release engine with the AndroidSurfaceVulkanImpeller #ifdef in AndroidSurfaceFactoryImpl::CreateSurface enabled.
The increased size comes mostly from Vulkan-related code in the engine (flutter/vulkan, gpu_surface_vulkan, android_surface_vulkan_impeller, flutter_vma) and Skia (src/gpu/vk and src/gpu/ganesh/vk)

There's probably a Skia define to ask it not to build with Vulkan right? If we're not actually using Vulkan on Skia we shouldn't need to build any more of it.

yeah in flutter/tools/gn we should not set skia_use_vulkan to true

skia_use_vulkan=True is required by some of the flutter/vulkan sources (such as the dependency on GrVkBackendContext in https://github.com/flutter/engine/blob/main/vulkan/vulkan_window.cc)
But most of the Skia Vulkan code is stripped out of the final linked binary.
In the linked libflutter.so, it looks like most of the size increase is coming from impeller_entity_shaders_vk_data

| But most of the Skia Vulkan code is stripped out of the final linked binary.
Thanks for checking!
| it looks like most of the size increase is coming from impeller_entity_shaders_vk_data
Perfect. Thats expected.

Here is a link to the relevant benchmark in SkiaPerf: https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3Dlibflutter_compressed_bytes%26test%3Dhello_world_android__compile

Closing this as completed.


Thanks to the author's work, can the author provide the salient mask M used for training?

Hello, the salient mask is cropped and shared as part of the "finetune_data.h5" by google drive. See here on how it is loaded.

Hello, the salient mask is cropped and shared as part of the "finetune_data.h5" by google drive. See here on how it is loaded.

Firstly, thank you very much for your reply. I have downloaded the files you mentioned, but the .h files contain preprocessed image data with a fixed size of 64×64, which prevents me from changing the image size.
Additionally, when reproducing your code, I noticed that your paper mentions cropping 1410 image patches of size 64×64 from the source images during the training phase. However, the training.h5 file you provided contains 6016 image patches. Could you clarify how many image patches were used for training?
Lastly, and most importantly, when strictly following the requirements outlined in your paper to reproduce your code, the loss fails to converge. What could be causing this issue?
I look forward to your response!

Hello, the salient mask is cropped and shared as part of the "finetune_data.h5" by google drive. See here on how it is loaded.

Firstly, thank you very much for your reply. I have downloaded the files you mentioned, but the .h files contain preprocessed image data with a fixed size of 64×64, which prevents me from changing the image size.
Additionally, when reproducing your code, I noticed that your paper mentions cropping 1410 image patches of size 64×64 from the source images during the training phase. However, the training.h5 file you provided contains 6016 image patches. Could you clarify how many image patches were used for training?
Lastly, and most importantly, when strictly following the requirements outlined in your paper to reproduce your code, the loss fails to converge. What could be causing this issue?
I look forward to your response!

Hello, thanks for your feedback.

Unfortunately I don't have the complete masks at hand, since we want to make training easier by sharing the preprocessed data. You may use common saliency detection / semantic segmentation methods to generate these masks. In the paper we found different ways to generate the masks do not have a big difference. If you don't mind, please send an email, I will get back to you if I find the data.

the released model was trained as described in the paper, 1410 images, training with more patches should not have a big difference.

did the loss decrease during training, if so, how was the performance after 5 epochs? We also found the loss curve fluctuates after a huge decrease, you may need to manually check the fusion result to decide a timing for early stopping, usually before 10 epochs.

Let me know if you have more questions!

Hello, the salient mask is cropped and shared as part of the "finetune_data.h5" by google drive. See here on how it is loaded.

Firstly, thank you very much for your reply. I have downloaded the files you mentioned, but the .h files contain preprocessed image data with a fixed size of 64×64, which prevents me from changing the image size.
Additionally, when reproducing your code, I noticed that your paper mentions cropping 1410 image patches of size 64×64 from the source images during the training phase. However, the training.h5 file you provided contains 6016 image patches. Could you clarify how many image patches were used for training?
Lastly, and most importantly, when strictly following the requirements outlined in your paper to reproduce your code, the loss fails to converge. What could be causing this issue?
I look forward to your response!

Hello, thanks for your feedback.

Unfortunately I don't have the complete masks at hand, since we want to make training easier by sharing the preprocessed data. You may use common saliency detection / semantic segmentation methods to generate these masks. In the paper we found different ways to generate the masks do not have a big difference. If you don't mind, please send an email, I will get back to you if I find the data.
the released model was trained as described in the paper, 1410 images, training with more patches should not have a big difference.
did the loss decrease during training, if so, how was the performance after 5 epochs? We also found the loss curve fluctuates after a huge decrease, you may need to manually check the fusion result to decide a timing for early stopping, usually before 10 epochs.

Let me know if you have more questions!

Thank you very much for your detailed response. My email is<EMAIL_ADDRESS>and I look forward to your email.
1. Regarding the first point, I will address the mask issue later.

2.Regarding the second point, this question actually arises from the third point. Essentially, I was unable to successfully train your code, which led me to suspect if it could be due to the number of patches.

3.Regarding the third point, I only changed the data_path in the code provided on your GitHub, but the loss does not converge. It fluctuates between 4-5 in each epoch and continues this way until the end of 30 epochs.

Initially, I suspected that the issue might be with the loss function or that the gradient wasn't being reset, but after checking, I found no problems. Currently, I am still unable to identify the issue.
Whether it is the method of generating masks or the number of patches, if I could successfully run the code, I could try modifying these aspects to see the corresponding results. Unfortunately, I have not yet been able to debug it successfully.
I look forward to your response! Thank you very much!

I have meticulously reviewed your code and found no apparent issues. However, the loss value never converges, with the minimum value only reaching 4, and it fluctuates between 4 and 5.
I then modified your loss function by removing the adaptive weight update and setting the weights to [[0.8, 0.2], [0.8, 0.2]]. Even then, the loss still did not converge, with the minimum value being 2. Is this behavior normal?
Lastly, the loss function mentioned in your paper never converges in my code. How can I reproduce the weights you provided in your code?
I eagerly await your response.
Best regards.

Hello,
thanks for your feedback. The adaptive weight only controls the balance of the two modalities, it does not affect the loss curve. As I mentioned before, the loss did fluctuate after a huge descent, the problem exists in our training as well. Thus in our setting, it's okay if the loss fails to converge since the fusion result looks good. We manually checked the fusion performance to decide when to stop training.


Is it possible to read LAION-400M from LAION-5B tarfiles?

Say that now I have access to tarfiles of LAION-5B (in webdataset format) stored in aws s3, metadata files of LAION-400M, and have a small local SSD (~ 1T). Is it possible to read out LAION-400M data directly (stored in link files or read online) for training without re-downloading, or what is the suggested practice?

well you have 2 choices:

redownload laion400m. That will take a very short time so I recommend going that way
put in memory the text and url of laion400m (or a hash of them) and then read with webdataset directly from s3 all the laion5B dataset, and write samples in new tars (for example using webdataset tar writer) only if they are contained in laion400m. You will most likely need multiple machines to do this in a reasonable time

Thanks for your prompt reply!
It's a pity that I am currently short of storage, so the 1st choice is not applicable now, and I'll see if I can implement the 2nd choice with reasonable computing, thanks!

Well I would love to, but s3 is basically read-only for me haha...


add a New feature

let's review it.

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

good reviewo.

close

submit pr by mistake, sorry for this.


JWT length is too big

@prudhvir3ddy we are creating cert's size as 2048
the problem here is when we create the jwt, it's size is huge. Shall we decrease the cert size to 1024 or 512

Sample jwt
eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJUb2tlblVzZXJzIiwic3ViIjoiYXBpX0FjY2Vzc1Rva2VuIiwiaXNzIjoiRmF5YXoiLCJlbWFpbCI6ImZheWF6ZnowN0BnbWFpbC5jb20iLCJpYXQiOjE1OTc4MjczMTgsImV4cCI6MTU5NzkxMzcxOH0.vBmOeWiy2zWW92i_ZRCta_XXq1bzwU4ln62-7c9qU6FWKn7-nRyXkU5jHcLYyfdCEuS_K_-cJ-p8sD4P4pZ-JkyvLMMLhVw438AhifaPlRWqMgoF3agSnN6MEIi7Z7_KlClvgsusiqlp5gMtdtFBYa0C8dMEUzZtCxAB_6w-nBiM5RzTTsgJEhOgApm-OnvR3Mz_ELJXKAdf8ZJI4YqsfaiZVBZ2ko72ajyv8817T7l073Owsk3vx8moKRDWzuQphP9CAq45yrdLuB_oo07o35aatOvPExXIn38xGpYPgJjLWhvv70o0r9sIBG8fuq4jv-48fb9kpx3bH3MxMzd4AQ

When we use pem of size 2048
jwt size varies around 542
and for 1024 pem size, jwt size is around 380

512 should do

ok, we'll update the docs accordingly

closed by #20


Map to Skywater 130 DesignWare libraries

I talked to Dan about this. He thinks OSU or NCSU might have DesignWare libraries for Skywater.

BTW DesignWare is synopsys's term, it won't be called that. But similar idea.


[TROCR] Translation Invariant?

I'm using the TROCR transformer, and was wondering if the model is translation/orientation invariant? If the model isn't, has anyone tried out utilizing translation/orientation augmentations for model improvements?

The model is clearly not translation invariant. It'd be a nice fix, but that's for another year


Site down

curl: (28) Failed to connect to wttr.in port 80: Connection timed out
Couple others said the site works for them, and if I use a vpn then it works fine for me too. I was using a script to fetch the weather every 30 mins, which I don't think is unreasonable. Could it be that my IP got blacklisted due to that?

Working since today morning. Closing.