Streaming works locally but not when deployed using vercel edge functions

I got streaming to work using an older commit of this repo and everything works fine locally. However, when I deploy the app in vercel, it doesn't stream the responses anymore.
I believe I have to use edge functions in order to do that and followed this tutorial to convert the current chat.ts API route into an edge function but I'm getting the following error while initialising the pinecone client:
"error  [PineconeError: Failed getting project name. Error: A Node.js API is used (process.nextTick) which is not supported in the Edge Runtime.
Learn more: https://nextjs.org/docs/api-reference/edge-runtime] {
  name: 'PineconeError'
}
error - node_modules/next/dist/build/webpack/loaders/next-edge-function-loader.js?absolutePagePath=%2FUsers%2Fharishtirunahari%2FCode%2Fneuraltalk-chatbot-app%2Fpages%2Fapi%2Fchat-edge.ts&page=%2Fapi%2Fchat-edge&rootDir=%2FUsers%2Fharishtirunahari%2FCode%2Fneuraltalk-chatbot-app! (10:0) @ <unknown>"

Any ideas as to why this or happening? Or any other suggestions to deploy this code and make streaming work?
Here is my code:
chat.ts
import { OpenAIStream } from '@/utils/server/stream';

export const config = {
  runtime: 'edge',
};

const handler = async (req: Request): Promise<Response> => {
  try {
    const { question, chat_history } = (await req.json()) as {
      question: string;
      chat_history: string[][];
    };

    const stream = await OpenAIStream(question, chat_history);

    return new Response(stream);
  } catch (error) {
    console.error(error);
    return new Response('Error', { status: 500 });
  }
};

export default handler;

stream.ts
import {
  PINECONE_INDEX_NAME,
  PINECONE_NAME_SPACE,
  pinecone,
} from '../data/pinecone';
import { makeChain } from './makechain';

import { OpenAIEmbeddings } from 'langchain/embeddings/openai';
import { PineconeStore } from 'langchain/vectorstores/pinecone';

export const OpenAIStream = async (
  question: string,
  chat_history: string[][],
) => {
  const sanitizedQuestion = question.trim().replaceAll('\n', ' ');
  console.log('asking question...', sanitizedQuestion);

  const stream = new ReadableStream({
    async start(controller) {
      console.log('starting stream...');
      const index = pinecone.Index(PINECONE_INDEX_NAME);

      /* create vectorstore */
      const vectorStore = await PineconeStore.fromExistingIndex(
        new OpenAIEmbeddings({}),
        {
          pineconeIndex: index,
          textKey: 'text',
          namespace: PINECONE_NAME_SPACE,
        },
      );

      const encoder = new TextEncoder();

      const sendData = (data: string) => {
        controller.enqueue(encoder.encode(data));
      };

      sendData(' ');

      // create chain
      const chain = makeChain(vectorStore, (token: string) => {
        sendData(token);
      });

      try {
        // Ask a question
        const response = await chain.call({
          question: sanitizedQuestion,
          chat_history: chat_history || [],
        });

        console.log('response', response);
      } catch (error) {
        console.log('error', error);
        controller.error(error);
      } finally {
        controller.close();
      }
    },
  });

  return stream;
};

this feature is ideal, have tried many fixes to no avail on Vercel

I have this issue but with a different architecture.
I have FastAPI server setup with SSE hosted on Cloud Run. This is streaming to my edge function that then streams to the client. This is working fine locally and even when its hosted I can log the tokens being streamed into the edge function and view each token log in the vercel dashboard. However, the stream starts in the client for the first token and then stops... Super weird. This only happens when its being hosted.
I believe your issues is to do with the Edge Runtime not being compatible with the pinecone library. You may need to change the setup.

Hey @haritiruna ! Have you managed to solve you problem? Also, could you please share index.ts' s handleSubmit method?

@felipetodev - I don't think either the pinecone sdk nor the openai client works on edge functions. You can create a replacement client pretty easily though using their REST APIs. I verified this works in production on Vercel.
const searchEmbeddings = async (query: string, maxResponses = 2, minConfidence = 0.8) => {
  try {
    const embeddingResult = await openai.createEmbedding({
      model: 'text-embedding-ada-002',
      input: query,
    });

    const queryVector = embeddingResult.data[0].embedding;
    const res = await fetch(
      `https://${pineconeIndexName}-${pineconeProjectID}.svc.${pineconeEnvironment}.pinecone.io/query`,
      {
        method: 'POST',
        headers: {
          'Api-Key': `${pineconeAPIKey}`,
          Accept: 'application/json',
        },
        body: JSON.stringify({
          vector: queryVector,
          includeValues: false,
          includeMetadata: true,
          namespace: pineconeNamespace,
          topK: 2,
        }),
      }
    );

    const data = await res.json();

    return data.matches
      .filter(m => m.score > minConfidence)
      .map(m => {
        return {
          text: m.metadata.text,
          score: m.score,
        };
      });
  } catch (err) {
    //log an error
    return [];
  }
};

const createChatCompletion = async (options: {
  model: string;
  messages: Array<{ content: string; role: ChatCompletionRequestMessageRoleEnum; name: string }>;
  max_tokens: number;
  temperature: number;
  stream: boolean;
}) => {
  return fetch('https://api.openai.com/v1/chat/completions', {
    method: 'POST',
    headers: {
         'Content-Type': 'application/json',
         Authorization: `Bearer ${apiKey}`,
    },
    body: JSON.stringify(options),
  });
};

For anyone else coming in from google, I've been struggling with this problem with what seems for forever and none of the answers/responses from google, stack overflower (or even this thread) has worked.
I found success by adding the following headers to my response, if you want to understand why, just search up the X-Content-Type-Options: nosniff header.
return new Response(stream, {
	headers: {
		'Content-Type': 'text/event-stream',
		'X-Content-Type-Options': 'nosniff'
	}
});

For anyone else coming in from google, I've been struggling with this problem with what seems for forever and none of the answers/responses from google, stack overflower (or even this thread) has worked.
I found success by adding the following headers to my response, if you want to understand why, just search up the X-Content-Type-Options: nosniff header.
return new Response(stream, {
	headers: {
		'Content-Type': 'text/event-stream',
		'X-Content-Type-Options': 'nosniff'
	}
});

This didn't really work. I'm doing this right now, but no luck.
In my case, the edge-runtime functions works locally, but doesn't iterate over the res.
`// Enable edge runttime
export const runtime = "edge";
export async function POST(req: Request) {
const encoder = new TextEncoder();
const decoder = new TextDecoder();
const { messages, currentTerminal, user_id } = await req.json();
console.log("Current Terminal: ", currentTerminal);
const res = await fetch(URL_GOES_HERE_FOR_FASTAPI_SERVER, {
method: "POST",
headers: {
"Content-Type": "application/json",
"X-Content-Type-Options": "nosniff",
},
body: JSON.stringify({
// Body
}),
});
console.log("Fetching data");
const transformStream = new TransformStream({
async transform(chunk, controller) {
const content = decoder.decode(chunk);
  controller.enqueue(encoder.encode(content));
},

});
const readableStream = await new ReadableStream({
async start(controller) {
console.log("Starting streaming response")
 // It doesn't iterate over the body here.
  for await (const chunk of res.body as any) {
    console.log("Chunk: ", decoder.decode(chunk));
    controller.enqueue(chunk);
  }

  // controller.close();
},
async pull(controller) {
  controller.close();
},

});
return new Response(
readableStream.pipeThrough(transformStream),
{
headers: {
"Content-Type": "text/event-stream",
"X-Content-Type-Options": "nosniff",
},
}
);
}`

For anyone else coming in from google, I've been struggling with this problem with what seems for forever and none of the answers/responses from google, stack overflower (or even this thread) has worked.
I found success by adding the following headers to my response, if you want to understand why, just search up the X-Content-Type-Options: nosniff header.
return new Response(stream, {
	headers: {
		'Content-Type': 'text/event-stream',
		'X-Content-Type-Options': 'nosniff'
	}
});

Running Vercel Edge locally, adding this did indeed do the trick for me. Thank you sir.


add Network.framework support

Adds support for NIOTransportServices's event loop group and bootstrap. This makes PostgresConnection compatible with Network.framework which in turn makes it possible to use on iOS.
iOS platform was added to Package.swift as well as a CI to ensure tests pass on a simulated iOS device.


Update branding to 3.1.1

Update branding & add trigger for internal release/3 branches
@JunTaoLuo @mmitche PTAL

@wtgodbe Any reason this isn't merged yet? (We are waiting to check in 3.1.1 fixes.)

Any reason this isn't merged yet? (We are waiting to check in 3.1.1 fixes.)

Nope, this can be merged now.


A couple of typos

I'm enjoying your site very much and just politely letting you know of a couple of typos on the Email Templates page:

"if the files is saves" - should be "if the file is saved"
"was renames to" - should be "was renamed to"
"stand along content" - should be " stand alone content", or, better yet, "stand-alone content"

Hi @leac
Thanks so much for the feedback, I've just pushed a commit so those should all be fixed now.
Sorry for the delay, I missed the notification.


Tray Icon - Color palette exploration

Explore the possibility of having icons better suited to a dark colour palette, a la Windows 10 default.
Black icons on black, are not particularly useful.
See #2127 originally raised by @VictorZakharov for more details.

I second that. We can already assign icons to Devices via ico/exe files, however if the app contained several white speaker/headphones icons, that we could assign to devices that would be great.

A simple white background or a shadow that traces the outline of the icons would work.

@brianpeiris Not a bad idea!
It's something that could probably be done on the fly too. Rather than including a full set of icons.
I'll post an update here once I know more.

http://stackoverflow.com/questions/7364026/algorithm-for-fast-drop-shadow-in-gdi
Might be able to do a white drop shadow, using the technique described in that article.


[Question]: Internal server error: reduce() of empty iterable with no initial value

Describe your problem
解析文件时候报这个错，docx格式，大部分文件没问题，有几个文件报错，那里的问题？

同问

I fixed this issue, could you try that again.
If it still fails, could you attach the file?


[o11y] Backport metrics implementation to 1.9

Context
We need to make sure that all metrics implementation work in KF-5558 is backported to 1.9.
What needs to get done

All charms touch by KF-5558 needs to be backported to 1.9

Definition of Done

All changes related with KF-5558 are cherry-picked for 1.9.
All PR's are merged.

https://github.com/canonical/istio-operators/pull/537
https://github.com/canonical/knative-operators/pull/216
https://github.com/canonical/kserve-operators/pull/266
https://github.com/canonical/kubeflow-profiles-operator/pull/184
https://github.com/canonical/kubeflow-tensorboards-operator/pull/134


How to edit credits in the footer?

Directory Lister Version
latest
PHP Version
PHP 7.3 (ea-php73)

PHP Extensions
; cPanel-generated php ini directives, do not edit
; Manual editing of this file may result in unexpected behavior.
; To make changes to this file, use the cPanel MultiPHP INI Editor (Home >> Software >> MultiPHP INI Editor)
; For more information, read our documentation (https://go.cpanel.net/EA4ModifyINI)
extension=php_intl.dll
extension=php_mcrypt.dll
Web Server
Apache
Describe the Bug
I have edited footer.twig but it dosent take effects
And still the credits are there?  also edited .env

Hi, have you tried deleting the contents of the app/cache/views folder?
The views are getting cached by default, so it's very likely that what you are seeing is still a cached version of the footer, before you have made any changes.

@nobri is correct, you would need to clear the view cache for changes to be reflected.

tried clearing the cache 100000 times no effects :(
With cpanel
With Wp Rocket
With Cloudflare

pp/cache/views

Yes it worked thank you so much

Can you guys please help me with one more thing?, please I was using an old version of directory lister where there was a option in config.php to enable/disable download button can you please guide me for that?

Are you using the latest version now?

Set the ZIP_DOWNLOADS environment variables to false to disable zip downloads.

Are you using the latest version now?

1000%

Set the ZIP_DOWNLOADS environment variable to false to disable zip downloads.

Thanks Very Much


Implement requestJoinableCustomGameModes

Custom game hype \o/ @jimmydorry seemed to be asking for these, so I figured I'd start implementing some. I till need to find out what the custom game IDs correspond with, so if anyone has an ID -> name list lying around, that would be GREAT.

:+1:
Thanks. The proto I am most interested in is the top 10 and game of the day.
https://github.com/SteamDatabase/GameTracking/blob/f89c4ffeeb116ccbf26b5d45feffdbe691ba12a5/Protobufs/dota/dota_gcmessages_common.proto#L1605-L1608

Trouble with that one is that I can't find a matching request which triggers GC to send them :/

Ill nethook it tomorrow night, if i dont forget.
On Wed, 18 Nov 2015 at 10:22 pm Crazy-Duck<EMAIL_ADDRESS>wrote:

Trouble with that one is that I can't find a matching request which
triggers GC to send them :/
—
Reply to this email directly or view it on GitHub
https://github.com/RJacksonm1/node-dota2/pull/154#issuecomment-157694073
.


Rename custom tags to Components

This is a documentation change proposal.
After discussing the issue with @zaceno, I'd like to rename custom tags to stateless components or components for short.

They actually are stateless/functional components.. right?
At least by the common reference:

https://facebook.github.io/react/docs/components-and-props.html
http://vuejs.org/v2/guide/render-function.html#Functional-Components
https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0
https://hackernoon.com/react-stateless-functional-components-nine-wins-you-might-have-overlooked-997b0d933dbc
https://toddmotto.com/stateful-stateless-components
https://github.com/vuejs/vue/issues/4037

They kind of also depict Custom Elements (but with much nicer syntax)

https://developer.mozilla.org/en-US/docs/Web/Web_Components/Custom_Elements

Perhaps what is most important here is that there is some clear hierarchy. If these sateless components are the leaf nodes, let's say we call them components, then what are we going to call the stateful components (if they materialise) and are stateless always children of stateful? Then maybe these are Elements and containers of elements are called Components.
I'm asking myself why are we naming this thing, what is it meant to mean in the grand scheme of things.

They actually are stateless/functional components.. right?

Yes, so basically we're doing the right thing now.

So long as there is sufficient emphasis on the fact that these are stateless or functional or stateless functional components then I'd say so. At least, it would be inline with the common definition of the thing.
In the react guide it says quite clearly 😂

We call such components "functional" because they are literally JavaScript functions.

SGTM

+1 to calling them functions or functional components.

As per @jbucaran's request:
My argument against the use of "custom tags" for functions of the type (props, children) -> vnode, is that they are only similar to actual html-tags in the context of JXS, where such a function named Counter can be callled and embedded in a vtree like this:
<Counter />
.  If you're using hyperx, it looks like this
${Counter()}
.


Guest User Data Owner (amplify gen 2)

Environment information
System:
  OS: macOS 14.4.1
  CPU: (12) arm64 Apple M2 Pro
  Memory: 166.63 MB / 32.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
  Yarn: undefined - undefined
  npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: 0.13.0
  @aws-amplify/backend-cli: 0.12.0
  aws-amplify: 6.0.29
  aws-cdk: 2.138.0
  aws-cdk-lib: 2.138.0
  typescript: 5.4.5
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
Allow guest/unauthenticated users to own data that they create so that only they can see/update the resources that they have created (within the current session), specifically within dynamodb records. I've seen there are ways to do this in gen 1 but it's not clear how to do this in gen 2. I've tried with the following model auth for example with no luck, using both iam and userPool auth mode: .authorization(allow => [allow.owner(), allow.guest().to(['create'])]).

hi, any suggestions?
I've been trying to find a way to set a custom owner field value for unauthorized users so only they can see records they have created for the duration of their active session.
One approach I've looked into is using a lambda custom authorizer but have had no luck. I've been able to capture the identity pool session identityId in the browser client using fetchAuthSession e.g. {identityId=eu-west-2:200c02ef-a475-c65f-663f-c12345678xx} and pass this into a dynamodb table, so could feasibly pass this to a lambda custom authorizer. But its not clear if/how the custom authorizer might then output in a way which could be used to set a custom owner value. Is this possible?
From the docs it doesn't appear possible to set an owner that isn't using userPools or oidc auth. And userPools don't appear to support unauthorized auth (which requires iam auth to be set). Is it possible to set unauthorized auth using userPool auth?
Or is it perhaps possible to use oidc auth to configure a custom owner value without having to provide oidc details such as oidcIssuerUrl?

hi, any suggestions?
I've been trying to find a way to set a custom owner field value for unauthorized users so only they can see records they have created for the duration of their active session.
One approach I've looked into is using a lambda custom authorizer but have had no luck. I've been able to capture the identity pool session identityId in the browser client using fetchAuthSession e.g. {identityId=eu-west-2:200c02ef-a475-c65f-663f-c12345678xx} and pass this into a dynamodb table, so could feasibly pass this to a lambda custom authorizer. But its not clear if/how the custom authorizer might then output in a way which could be used to set a custom owner value. Is this possible?
From the docs it doesn't appear possible to set an owner that isn't using userPools or oidc auth. And userPools don't appear to support unauthorized auth (which requires iam auth to be set). Is it possible to set unauthorized auth using userPool auth?
Or is it perhaps possible to use oidc auth to configure a custom owner value without having to provide oidc details such as oidcIssuerUrl?

We are using "anonymous" accounts. We create for our user a<EMAIL_ADDRESS>account in the userpool.
And later when the user wants create an account, we just change the email of the account instead of create a new one, so that the username (sub) is still the same.

@biller-aivy thanks for the info. A similar thought had crossed my mind but I couldn't think of an easy way to do this in Amplify Gen 2. Do you have any pointers? Perhaps have an auth check determine if logged on, and if not invoke a custom lambda (over appsync) to create the user pool responding with the random id / pwd used to auto-sign-on?

👋  @domthomas1,

I've been trying to find a way to set a custom owner field value for unauthorized users

owner based auth means that the user is already signed-in via the provider. If you want to set the custom owner field for unauhorized users, you would want to use a custom authorizer for your use-case as suggested in comments above.

Hey 👋 , This issue is being closed due to inactivity. If you are still experiencing the same problem and need further assistance, please feel free to leave a comment. This will enable us to reopen the issue and provide you with the necessary support.


icons doesnt show

Hi,
first thx for your work,
i want  to figure out how does it work to enable the resources. Any help would be nice

Ok i find out it works only if  i build a package. Tahts ok for me thx :)


Missing localizable strings

Localizable string "Request failed: unacceptable content-type: %@" not found in strings table "AFNetworking"
Localizable string "Request failed: %@ (%ld)" not found in strings table "AFNetworking"

My apologies, I'm using the current POD for this, which seems to be 2.5.3

So you ignored this for five months, and then closed it with no fix and no message as to why you're closing it?

My apologies grosch. I guess I didn't hit submit on my response.
AFNetworking does not provide localization for networking errors that should be presented to the user. That is the responsibility of the developer. You can provide a AFNetworking strings table, which should allow your message to be localized.


[Task] upload plugin jar to admin, synchronize jar to bootstrap

Description
upload plugin jar to admin, synchronize jar to bootstrap
Task List

upload jar file api.
control jar file api.for example: add plugin jar, remove plugin jar, modify plugin jar.
syncronize jar file to bootstrap.
load jar file from bootstrap dynamically.

pls assign to me.

I don't think this is a good idea. This looks a lot like osgi, dynamic plugging and unplugging, but this function is not suitable for cloud native scenarios, each gateway node is an image instance.
it is not safe to do so

I don't think this is a good idea. This looks a lot like osgi, dynamic plugging and unplugging, but this function is not suitable for cloud native scenarios, each gateway node is an image instance.
it is not safe to do so

first, my idea from ShenyuLoaderService#loaderExtPlugins, ShenYu can load plugin from local file, why not load from remote file system.
second, it like bundle of osgi, but shenyu's plugin is jar, this is supported feature, not necessary feature.
third, I think ShenYu already supported load jar from local, why not think ShenYu Gateway safety?
this feature suit cluster mode, otherwise, if you upload plugin, you must upload jar to every gateway server manually in cluster enviroment，and about cloud native scenarios, it doesn't matter.

Personally, I think it looks good

@yu199195 @hutaishi @li-keguo
this is my preliminary idea.

in admin, when upload plugin jar, generate signature，it keep jar's safety.
in event, send event with signature by md5.
in bootstrap, load plugin and put this plugin to pluginList.

@yu199195 @hutaishi @li-keguo
this is my preliminary idea.

in admin, when upload plugin jar, generate signature，it keep jar's safety.
in event, send event with signature by md5.
in bootstrap, load plugin and put this plugin to pluginList.

The idea is great, but how do we ensure that the newly added jar will run stably? How to ensure that the gateway is stable but productive during the loading process? We know that the load bytecode is used but the heap memory is special, but how to dynamically expand it?

pls assign to me.


Memory error

Hi there!
Monorepos are becoming more and more popular and it seems that standard gets into issues with multiple packages in one repo.
This is the error I get when I try to lint our monorepo:
<--- Last few GCs --->

   70345 ms: Mark-sweep 1345.7 (1435.2) -> 1345.7 (1435.2) MB, 1763.1 / 1.3 ms [allocation failure] [GC in old space requested].
   72108 ms: Mark-sweep 1345.7 (1435.2) -> 1345.7 (1435.2) MB, 1762.5 / 1.4 ms [allocation failure] [GC in old space requested].
   73943 ms: Mark-sweep 1345.7 (1435.2) -> 1345.7 (1404.2) MB, 1834.7 / 1.3 ms [last resort gc].
   75735 ms: Mark-sweep 1345.7 (1404.2) -> 1345.7 (1404.2) MB, 1792.3 / 1.4 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x35f9d0cfb51 <JS Object>
    1: inflight [/Users/christianalfoni/Development/cerebral/node_modules/inflight/inflight.js:~7] [pc=0x3780a4557197] (this=0x35f9d0e6f19 <JS Global Object>,key=0x253882120d61 <String[166]\: lstat\x00/Users/christianalfoni/Development/cerebral/packages/cerebral-router/node_modules/@cerebral/monorepo/debugger/cerebral-debugger/node_modules/combined-stream/lib>,cb=0x253882122339 <JS Function lsta...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/usr/local/bin/node]
 2: node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/usr/local/bin/node]
 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/usr/local/bin/node]
 4: v8::internal::Factory::NewInternalizedStringImpl(v8::internal::Handle<v8::internal::String>, int, unsigned int) [/usr/local/bin/node]
 5: v8::internal::InternalizedStringKey::AsHandle(v8::internal::Isolate*) [/usr/local/bin/node]
 6: v8::internal::StringTable::LookupKey(v8::internal::Isolate*, v8::internal::HashTableKey*) [/usr/local/bin/node]
 7: v8::internal::StringTable::LookupString(v8::internal::Isolate*, v8::internal::Handle<v8::internal::String>) [/usr/local/bin/node]
 8: v8::internal::LookupIterator::LookupIterator(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>, v8::internal::LookupIterator::Configuration) [/usr/local/bin/node]
 9: v8::internal::LookupIterator::PropertyOrElement(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, bool*, v8::internal::LookupIterator::Configuration) [/usr/local/bin/node]
10: v8::internal::Runtime::GetObjectProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [/usr/local/bin/node]
11: v8::internal::Runtime_KeyedGetProperty(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/bin/node]
12: 0x3780a42092a7
13: 0x3780a4557197
npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>[1]    16597 abort      npm run lint

Now, I believe this is related to traversing, because if I delete the node_modules folders of all the packages in the repo the linter works fine.
By default "standard" ignores node_modules folder and we even added an extra config to be certain, from our package.json:
{
  "standard": {
    "parser": "babel-eslint",
    "ignore": [
      "**/node_modules/",
      "**/build/"
    ]
  }
}

Could it be that ignore is only related to actually linting, but it still traverses all files?
I have tried everything... installing latest Node, Npm, delete repo from my machine and clone again. Also tried upping the memory of Node. It just does not work. Funny thing is that it works on some computers. I have a pretty powerful Macbook Pro from 2015.
Any help would be great as this is blocking contributions to our project currently. The repo is: https://github.com/cerebral/cerebral
Run:
npm install
then
npm run setup
and
npm run lint

You have quite a unique situation. No other user has reported this error before. I took a look into what the glob package is doing and it's not filtering out node_modules right at the beginning of the search process, even though we passed that option.
I posted a comment here: https://github.com/isaacs/node-glob/issues/270#issuecomment-273949982
Right now, I'm treating this as a bug in glob.

Ahh, nevermind. This is not a glob bug. Everything is working correctly. The default standard ignore is node_modules/** which only ignores the root node_modules folders. This is why it's doing so much work in your repo.
Your attempt to ignore all them by adding an explicit ignore of **/node_modules/ was the right idea, but you got the syntax wrong. It's supposed to be **/node_modules/**.
If you put that in, standard runs extremely quickly given the gargantuan size of your repo.

@feross Ah man! Thanks a bunch :-D


STYLE:  Missed conversions for new macro name

Call ITK_DISALLOW_COPY_AND_MOVE, not ITK_DISALLOW_COPY_AND_ASSIGN
Some conversions were missed during initial update of macro name.

Python failure is unrelated.


rocAL - warning on TOT

-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0

MIVisionX/rocAL/rocAL/source/coco_meta_data_reader.cpp:246:34: warning: 'bbox[3]' may be used uninitialized in this function [-Wmaybe-uninitialized]
                 box.b = (bbox[1] + bbox[3]) / image_size.h;
                         ~~~~~~~~~^~~~~~~~~~
/home/ptcherni/kiriti/MIVisionX/rocAL/rocAL/source/coco_meta_data_reader.cpp:245:34: warning: 'bbox[2]' may be used uninitialized in this function [-Wmaybe-uninitialized]
                 box.r = (bbox[0] + bbox[2]) / image_size.w;
                         ~~~~~~~~~^~~~~~~~~~
/home/ptcherni/kiriti/MIVisionX/rocAL/rocAL/source/coco_meta_data_reader.cpp:246:34: warning: 'bbox[1]' may be used uninitialized in this function [-Wmaybe-uninitialized]
                 box.b = (bbox[1] + bbox[3]) / image_size.h;
                         ~~~~~~~~~^~~~~~~~~~
/home/ptcherni/kiriti/MIVisionX/rocAL/rocAL/source/coco_meta_data_reader.cpp:245:34: warning: 'bbox[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
                 box.r = (bbox[0] + bbox[2]) / image_size.w;

@kiritigowda These warnings should be fixed in #838


Android: compile ss-local for 64-bit architectures

The Play Store will require 64-bit binaries as of August 2019. Compiles shadowsocks-libev for x86_64 and arm64-v8a.
Passes the specified architectures to ndk-build.

Thanks for the review @trevj. Yes, these do add to the size of the APK. As discussed offline, we can look into building multiple release APKs for each architecture.

Do not merge until we switch to go-tun2socks; otherwise, we also have to compile badvpn-tun2socks for 64-bit. go-tun2socks already supports 64-bit architectures,

Verified that the built binaries work on all supported architectures.


Adding support for Podman

Via the new container_engine parameter in Cross.toml, the user can now
specify whether they want to use Podman or Docker.
Several changes to src/docker.rs to pass in different options based on whether
docker or podman is being used. This also mandates the use of --userns host
which does require bumping the minimum Docker version.
Updates to the code base based on rustfmt and clippy recommendations.

Please move the style changes to a separate PR. It's really hard to review the actual changes with them mixed in.

Sorry about that. I've reverted everything back save for the changes to add podman support.

bors r+

Thanks, @ostrosco, great work!

Thanks and you're welcome!


Trying to use pgmigrate to develop on a mature multi-schema DB without an initial DDL - Is this supported?

What we're trying to do:
We have a mature postgres database that we are in the process of revamping. Unfortunately thus far we don't have the capability to build the database schema from scratch. So we use a recent "gold" backup, and then use pgmigrate to deploy future migrations.
So far we are getting a smattering of issues that appear to be a limitation of the tool itself.
First was multi-schema support. I've tried disabling the schema check, but the DDL will only proceed past the schema error if I specify -m $schema. It is currently unknown if the next statement (that operates on a different schema) will function since now pgmigrate fails to run because it cannot find the view we wanted to drop in the first schema.
So here's the sql in question:
set schema 'schema1';
drop view schema1.some_view;

set schema 'schema2';
drop view schema2.some_other_view;

Right now as long as I specify -m schema1 I can get past the error:
psycopg2.errors.InvalidSchemaName: schema "schema1" does not exist

but now I'm getting:
psycopg2.errors.UndefinedTable: view "some_view" does not exist

I've confirmed that the user in question can see that view and perform a drop on it using PSQL and Dbeaver - even using the same environment variables. The only thing that makes sense is if it's checking for previous migrations on a table that this tool creates.
So my question is:

Does pgmigrate support "taking over" an already mature, multi-schema database? Or does the application require it create the full DDL in the first place in order to function?

I'm a dummy!
I was using environment variables to set the connection string but failed to pass an empty connection string on the command line to pick up the environment variables.
The result - it must have been connecting to my local SQL instance on localhost and sent me down the wrong path entirely.
To anyone experiencing similar weird schema issues when using environment variables ensure you are passing -c '' to pgmigrate otherwise it's not actually connecting properly.


Sync from ak 2.5 -> CCS 2.5 - June 2 2020

Was failing automatic merge due to a merge conflict in docs/upgrade.html. Everything else merged cleanly.
For conflict, kept the content from AK, except removed the line about scala 2.11 not being supported in CCS/CE as that wasn't done in CP 5.5 (only in AK).
https://github.com/confluentinc/kafka/blob/fe9f3312220d34a7220432930a28012777d873ed/docs/upgrade.html#L42-L45

The failing job here is the community builder (not yet sure why this is running on Confluent PR builds (we don't run it on non-PR builds).  We do have a passing build here - https://jenkins.confluent.io/job/confluentinc-pr/job/kafka/view/change-requests/job/PR-331/6/ for this chnage.


Update to new upcoming fax API

We've made some pretty big changes to fax which will break neos. We'll be updating pypi with a new release soon but I wanted to offer to help update to the new simpler api (assuming this project is still in development). I was going to go straight for a PR but I noticed that the neos.fit module has some issues that I don't think I can properly fix without a bit of help.
The current implementation in neos.fit never allows the adam optimizer to update its state. Specifically, it always uses freshly initialized internal parameters for its scaling and momentum terms. If someone can help me better understand what constrained_bestfit_minimized is doing, I can submit a PR to both fix the bug and update to the new API.

Hi @gehring thanks so much for the offer. Yes this project is very much still active. Is there a branch on which we can preview the new API?

Yes, you should be able to see the new api on the master branch.

Oh, I should have point out that we've also updated the readme with an example which includes using a non-differentiable solver.


hplip: 3.20.11 -> 3.21.12

The ImageProcessor component became a configure option, so we can drop
the patch.
Motivation for this change
Things done
ran hp-setup -i $ip to set up my printer.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This unfortunately doesn't fix the hp-setup gui, so https://github.com/NixOS/nixpkgs/issues/114051 still is an issue.


Dart2JS: List<Null> allows heap unsoundness?

Reproduce in -dev.63 in Dart2JS with --preview-dart-2:
void main() {
  var listOfNull = <Null>[];
  List<Object> listOfObject = listOfNull.toList();
  listOfObject.add(1);
  List<String> listOfString = listOfObject;
  listOfString.add('Hello World');
  // True
  print(listOfString is List<String>);
  // [1, 'Hello World']
  print(listOfString);
}

There are no static or runtime errors in this code snippet, but I end up having a statically typed List<String> that can be passed (and treated) as a List<String> but (a) has a reified type of <Null> not <String>, (b) passes the is List<String> test, and (c) contains an int.
Notably, if I add this line at the end:
  listOfString.map((v) => print(v)).toList();

I start getting runtime errors:
Uncaught exception:
TypeError: 1: type 'JSInt' is not a subtype of type 'String'

A few questions:

Why?
Why does .map with print() cause a TypeError but nothing else?

Here is the VM (running with Dart2):
dart /tmp/a.dart
Unhandled exception:
type 'int' is not a subtype of type 'Null' of 'value'
#0      List.add (dart:core/runtime/libgrowable_array.dart)
#1      main (file:///tmp/a.dart:4:16)
#2      _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:279:19)
#3      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:165:12)

... the VM catches listOfObject.add(1), in this case.

This is the same issue as https://github.com/dart-lang/sdk/issues/33500 which is fixed.
TypeError: 1: type 'JSInt' is not a subtype of type 'Null'
    at Object.wrapException (o1.js:606:17)
    at Object.assertSubtypeOfRuntimeType (o1.js:1271:17)
    at Interceptor.add$1 (o1.js:420:11)
    at Object.main (o1.js:1866:27)

Oh wow thanks!


Reworked Color Examples

[Work In Progress - Do Not Merge]
This is an initial pull request for my GSoC project, to get an idea of how the p5js website repo works.
This commit includes the following changes :
Reworked the following examples in the color category :

Hue
Saturation
Brightness
Lerp Color

New example for the color category :

Color Wheel: Color wheel is an organization of color hues around a circle, which shows the relationships between primary colors, secondary colors, tertiary colors etc. The example has 36 circles in a circular arrangement cycling through different hues.

@tyler-yin @limzykenneth This commit shows 26k additions because of the updated package-lock.json file. What should I do to fix this?

Changes to package-lock.json file should be reverted, unless there is a particular reason to include it?

Thanks @Malayvasa and @tyler-yin for working on it. Since @Malayvasa mentioned [Work In Progress - Do Not Merge], I'd like to check in with you about the status of this pull request. Is there a plan to get this merged at some point? Thanks.

Hi @Malayvasa and @tyler-yin, just to follow up on my previous comment. Is this PR ready to be merged?

Hi @Qianqianye, it looks like package-lock.json still needs to be reverted. @Malayvasa can you make this change before we merge the PR?

Thanks @tyler-yin and @Malayvasa. Just reverted package-lock.json from our end and merged the PR.
Thank you both for working on it!


Download annotations in annotation demo

Hi! Would it be possible to include an example of how to download the annotations from the webpage. It would be great to be see a clear example on how to access the annotations, and download as a json.
Thanks!

Hey @jordanhart,
If you hit "View Output" at the top you can see the output json. We can add download functionality. PRs welcome :)

Thanks!


import libcbor

Issue #, if available:
import libcbor as 3rd party dependency. https://github.com/PJK/libcbor
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Would it be wise to merge this into some cbor feature branch, instead of main as we iterate on this?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.10%. Comparing base (33c1bfb) to head (4d2e689).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   83.10%   83.10%
=======================================
  Files          56       56
  Lines        5766     5766
=======================================
  Hits         4792     4792
  Misses        974      974

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix minor grammar issues

RFC looks good to me, great work!

I force pushed since you made this without noticing, so I cherry-picked your commit and resolved it.
Since this PR had the old commit, GH didn't consider it merged.


Adding cronie as a dependency for oso-f22-host-monitoring

Crond is required by pmlogger. Fixes the following error from pmlogger.
Starting pmcd ...
Installing http_ping PMDA ...
/usr/share/pcp/lib/pmlogger: Warning: Performance Co-Pilot archive logger(s) not permanently enabled.
    To enable pmlogger, run the following as root:
    # /usr/bin/systemctl enable pmlogger.service
Starting pmlogger ...
/usr/share/pcp/lib/pmlogger: line 290: /usr/sbin/crond: No such file or directory

Needed fix for #110

:+1:


Support for Workflow Designer?

Could it be possible to add support for Workflow Designer in the WebAssembly projects?

@dburner would you have an example of this scenario ?

I was asking if it would be possible to run the Workflow Designer in the browser using Uno :)

It would be nice. But the workflow designer is a WPF component. It means it should be ported to Uwp first before using it with Uno.
I'm not sure if the sources are published, allowing this port to happend.

Ok, thank you.


[Modal] Firefox on Android gets problems rendering scrolling modals

Steps

Use Firefox (tested with 63.0.2 version) on Android
Navigate to https://semantic-ui.com/modules/modal.html#scrolling-modal
In section "Scrolling Modal" press "Run Code"
Scroll down

Expected Result
Normally looking content
Actual Result
Some "holes" in the modal, through which you can see the dimmer
https://image.ibb.co/gM2320/scr.jpg
Version
2.4.2
Testcase
https://semantic-ui.com/modules/modal.html#scrolling-modal - see above
P.S.
I have no transforms or opacity changes in my modals, so if I change .ui.modal replacing
will-change: top, left, margin, transform, opacity;
with
will-change: top, left, margin;
all starts working fine.

Fixed in https://github.com/fomantic/Fomantic-UI/pull/1491


How to actually use pkgs.irssi_otr?

So, pkgs.irssi_otr doesn't actually seem to install its module in any location readable by irssi.

Correct, it looks like we need something to wrap both irssi and the otr module to make things work.

The hack I'm using it to symlink .irssi/modules -> ~/.nix-profile/lib/irssi/modules. Would be nice to wrap it properly though, yes.

Are there any updates to this issue, please?

As far as I can see, OTR support is included in the normal irssi build:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/irc/irssi/default.nix#L19


How to specify the camera for Egui rendering?

Hello, bevy_egui is a great library! But may I ask, is there any way to specify the camera for Egui rendering? Or, how can I configure the viewport for Egui rendering?

Hi! Thank you for the kind words.
Atm, bevy_egui attaches its contexts either to windows or to textures. There are examples on how to render to a texture or to a different window:

https://github.com/mvlabat/bevy_egui/blob/main/examples/render_egui_to_texture.rs
https://github.com/mvlabat/bevy_egui/blob/main/examples/two_windows.rs

Is it something that could work for you?
If not, maybe there's a way we could get context attachable to cameras. But I'd like to hear more about your use-case first :)
I think the only thing that attaching to a camera would bring is limiting Egui to a certain viewport size (which we don't have a clean API for atm), but everything else should be possible already if I'm not missing anything.

Thank you very much for your reply. After careful consideration, I realized that my thoughts were indeed too complicated. My idea is that if bevy_egui can specify different cameras, then I can spawn a specific camera in certain scenarios and render the content of egui onto that specific camera. Now it seems that this scenario is too complex, perhaps I only need to display a widget at the specified location.


over writting Engine to support other formats

hi, i want to over write the PIL engine to support avif
if i adjust _get_raw_data(), will that be enough?

if anyone is interested, you also have to override the backend in base.py.


fix/improve_prevote

Improve the pre-voting phase with minimal code changes.
All test cases passed.

I have committed all the changes but still occur this strange error??
$ sh ./.middleware-common/check_format.sh
Please commit your change before run this shell, un commit files:
M jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
./.middleware-common/check_format.sh: 7: exit: Illegal number: -1
The command "sh ./.middleware-common/check_format.sh" exited with 2.

I fixed the issue in https://github.com/alipay/sofa-jraft/pull/26 ,thanks for your PR.


⚠ Itaca Gallery has degraded performance

In b8120e0, Itaca Gallery ($SITE_TCGLR) experienced degraded performance:

HTTP code: 200
Response time: 9760 ms

Resolved: Itaca Gallery performance has improved in c973602 after 5 minutes.


Swift Package Manager

Please add swift package manager. I converted all of my dependencies into SPM. But I could not remove my Cocoapods due to SwiftSpinner.

It's already available via SPM:

Your web link is not working.
Addiotanlay,
Its saying, no package available for this project.
[image: Screenshot 2024-01-03 at 7.37.54 PM.png]
*Sincerely, *
Shourob DattaEmail : @.** @.***>   *
On Wed, Jan 3, 2024 at 6:46 PM Andrea Mazzini @.***>
wrote:

It's already available via SPM:
Screenshot.2024-01-03.at.18.46.06.png (view on web)
https://github.com/icanzilb/SwiftSpinner/assets/570797/146481e8-ee50-481d-b0ae-471a1e077349
—
Reply to this email directly, view it on GitHub
https://github.com/icanzilb/SwiftSpinner/issues/149#issuecomment-1875742094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGCO43PPDRQQQ6YBMKBJRDYMWKQ7AVCNFSM6AAAAABBKUP626VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVG42DEMBZGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

You should be able to see the screen on the GitHub page.
Anyway, I just tried on a fresh project, enter https://github.com/icanzilb/SwiftSpinner in the SPM window and you should be able to add it to your packages.
If you're still having issues it might be something misconfigured on your end.
Cheers

Thanks for your reply. And thanks for your awesome library.
*Sincerely, *
Shourob DattaEmail : @.** @.***>   *
On Wed, Jan 3, 2024 at 7:46 PM Andrea Mazzini @.***>
wrote:

You should be able to see the screen on the GitHub page.
Anyway, I just tried on a fresh project, enter
https://github.com/icanzilb/SwiftSpinner in the SPM window and you should
be able to add it to your packages.
If you're still having issues it might be something misconfigured on your
end.
Cheers
—
Reply to this email directly, view it on GitHub
https://github.com/icanzilb/SwiftSpinner/issues/149#issuecomment-1875810285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGCO46P5DMKZX5PQDYG2ADYMWRPHAVCNFSM6AAAAABBKUP626VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVHAYTAMRYGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Broken in Slack v4.0.0

Slack version 4.0.0 no longer has a src directory in /usr/lib/slack/resources/app.asar.unpacked, only dist.
This change breaks the dark theme.

I can confirm this.  The workaround is to unpack app.asar (using Asar7z, for instance), update the file, and then re-pack it.
I tried it a few days ago but there's a lot that has changed.  While I was fiddling with it Slack auto-updated with a beta on top of 4.0.0 twice, so I decided to stay on 3.4.3 until the dust settles in a week or two.
According to the Slack team official 'dark mode' for the desktop client is imminent, if you can believe that after 4-5 years of getting the runaround about it.

I've got things working with 4.x but the modifications to Slack to get it to load the stylesheet are pretty tedious.  I'm working on a console application to automate this, and will update this issue when it's don.

Little more contrast than I'd prefer but I'm glad I don't have to maintain this anymore!


Add support for --exec-opt to docker daemon

Add support for --exec-opt to docker daemon.
This seems to be needed to workaround docker/docker#17653 on Centos 7.

LGTM


How to install powershell module?

I cannot find any instructions about the powershell module to install to have these commands. It would be easier to provide this configuration in the Azure Portal, and through the newer "az" command line interface.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02ff3d62-dc0e-ad0c-f5ae-418337cf31e4
Version Independent ID: d50952b5-6b98-c40d-d3a3-f9cbec58dd28
Content: Configurable token lifetimes in Azure Active Directory
Content Source: articles/active-directory/develop/active-directory-configurable-token-lifetimes.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@dluc  Thank you for your query. We will check and update the thread soon.

@dluc, Thanks for sharing the query. The module needed out here is AzureAD Powershell Module. You can install the latest version of the same from https://www.powershellgallery.com/packages/AzureAD/<IP_ADDRESS>
Hope this helps.

@dluc, Do let us know if there are any further queries around this. We are closing this thread for now, and feel free to re-open this if required.

The link is 404 invalid. @souravmishra-msft


Refactor container classes to its provider directory

Based on https://github.com/ManageIQ/manageiq-schema/pull/35#issuecomment-317247206,
these classes should be refactored.

ContainerBuild
ContainerBuildPod
ContainerDeployment
ContainerRoute
ContainerImage

@miq-bot assign moolitayer


Option --delimiter not available in v0.13.0 (mac)

I would like to use tab as delimiter, but xsv does not recognize option --delimiter. I use xsv v0.13.0 in MacOS Sierra v10.12.6.
mm:~$ xsv --version
0.13.0
mm:~$ xsv --help
Usage:
    xsv <command> [<args>...]
    xsv [options]

Options:
    --list        List all commands available.
    -h, --help    Display this message
    <command> -h  Display the command help message
    --version     Print version info and exit

Commands:
    cat         Concatenate by row or column
    count       Count records
    fixlengths  Makes all records have same length
    flatten     Show one field per line
    fmt         Format CSV output (change field delimiter)
    frequency   Show frequency tables
    headers     Show header names
    help        Show this usage message.
    index       Create CSV index for faster access
    input       Read CSV data with special quoting rules
    join        Join CSV files
    sample      Randomly sample CSV data
    search      Search CSV data with regexes
    select      Select columns from CSV
    slice       Slice records from CSV
    sort        Sort CSV data
    split       Split CSV data into many files
    stats       Compute basic statistics
    table       Align CSV data into columns
mm:~$ xsv -d
Unknown flag: '-d'

Usage:
    xsv <command> [<args>...]
    xsv [options]

What are you expecting xsv -d to do? That's not a valid command. The sub-command is what dictates which options are available. For example, if you're using xsv select, and you want to change the delimiter, then you'd use xsv select -d 2 foo.csv. Alternatively, if your file has a tsv extension, then a tab delimiter is used automatically.
In the future, please include more details about which commands you're trying to run. I asked you to do that in my last correspondence to you.


Improve Largest Contentful Paint (LCP)

LCP: https://web.dev/lcp/
how to check LCP on chrome devtools:

switch to Slow 3G network under Network tabs in chrome devtools
click reload button under Performance tabs
hover LCP in timings section to see the content

this is our LCP score on the homepage in the previous 21 days

thought it was going to be a problem, the svgs are quite large. Is there anything I can change?

hhmm 🤔 I guess nothing wrong with the svgs stuff, maybe we can tackle this from code. let's ask the other first
maybe it's possible with just CSS. unfortunately, I'm not really good with CSS cc @roiLeo @Jarsen136 @prachi00 is it possible to use CSS for that gradient stuff?

i think that would be the best approach, but it would have to match pretty closely :D svgs are generally not meant to be exported with effects on top. The effects should be applied in css afterwards

in the end its just this:

with applied blur on top.
filter: blur(200px);

thought it was going to be a problem, the svgs are quite large. Is there anything I can change?

we can try to:

reduce svg size or change file format (webp?)
async loading with nuxt-img

is it possible to use CSS for that gradient stuff?

not sure it's the best option

thought it was going to be a problem, the svgs are quite large. Is there anything I can change?

hhmm 🤔 I guess nothing wrong with the svgs stuff, maybe we can tackle this from code. let's ask the other first
maybe it's possible with just CSS. unfortunately, I'm not really good with CSS cc @roiLeo @Jarsen136 @prachi00 is it possible to use CSS for that gradient stuff?

IMO, we could try to inline the svg file to the js/html, to avoid fetch too many pic while open landing page. They cost a lot time at the network fetching.

is it possible to use CSS for that gradient stuff?

It may be not that easy to match the design with css.

👋
I would take it a try.

👋 I would take it a try.

nice, ping me if anything

I would close this PR #4780 (inline svg file) for two reasons:

Though inlining svg would reduce some image network request, it also increase the size of js bundle.
We have ServiceWorker which could cache the static file/image, so these svg images request have little impact if hit the cache.

in the end its just this:  with applied blur on top. filter: blur(200px);

and what about this? @Jarsen136, the only pain would be only with positioning

with applied blur on top. filter: blur(200px);
and what about this? @Jarsen136, the only pain would be only with positioning

In this way, we still need to request some smaller svg and make some transforms by CSS. I guess it would not make too much difference in the LCP time, because there is servicework to cache the file. Maybe someone would have other approaches to improve performerce from code.

with applied blur on top. filter: blur(200px);
and what about this? @Jarsen136, the only pain would be only with positioning

In this way, we still need to request some smaller svg and make some transforms by CSS. I guess it would not make too much difference in the LCP time, because there is servicework to cache the file. Maybe someone would have other approaches to improve performerce from code.

ah okay, dont understand this tbh :D


deleting the index

how to delete an indexes of a pdf file from Search Service. I can delete manually from Container in the Storage account but can not delete the index. Is there any way to delete?

Thanks for answering! Closing as that should resolve your issue. Do make sure you specify the name of the document, as specifying --remove with "data/*" will remove everything.


Allow valueless attributes in html tags

HTML allows attributes without values, in which case they're treated like so:
<input checked>

is interpreted as
<input checked="checked">

My change unfortunately breaks another test case, which wants to swallow attributes missing quotes. This will now interpret the example

as

I couldn't find a good solution using regex, maybe you have an idea? Browsers will permissively treat this as

but HTML parsing is hard :)
(as an aside, Earmark should treat input tags as void elements)

Pull Request Test Coverage Report for Build ebd74b3b769340c49533879279769b323ad58a3e-PR-106

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8ec13efa55c42e43e611a029db03d2f560952198:
0.0%

Covered Lines:
732

Relevant Lines:
732

💛  - Coveralls

@tomconroy thx looks promising will have a look when I have time.
This feature is definitely a plus, however my time is sooo limited right now, I am not sure when I can merge and release...
do you have an urgent need?

Not urgent. I have rolled back earmark to 1.2 because there are other regressions with the new parser (https://github.com/pragdave/earmark/issues/449)

#449 should go here though I guess

@tomconroy just looked at the code, great job, but we need to support Elixir 1.11 for ex_doc so you would need to fix the CI, if you want me to fix the CI I will provide a different branch to PR against which I will than merge and fix when I find the time.
Thank you for the PR again

Cool, my change actually breaks some tests. Please feel free to take over as I'm not sure how to best fix this with the regex parser..

@tomconroy ok then please PR against rel-1.4.26

Oh I could do that myself (why not BTW) 😄
https://github.com/RobertDober/earmark_parser/pull/107
So I close this one, thanx

Cool, my change actually breaks some tests. Please feel free to take over as I'm not sure how to best fix this with the regex parser..

which were incorrect by the way so I need to fix them anyway...

Pull Request Test Coverage Report for Build ebd74b3b769340c49533879279769b323ad58a3e-PR-106
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8ec13efa55c42e43e611a029db03d2f560952198:
0.0%

Covered Lines:
865

Relevant Lines:
865

💛  - Coveralls

Pull Request Test Coverage Report for Build ebd74b3b769340c49533879279769b323ad58a3e-PR-106
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8ec13efa55c42e43e611a029db03d2f560952198:
0.0%

Covered Lines:
865

Relevant Lines:
865

💛  - Coveralls


[SUGGESTION] Ability to copy component/all components into a clipboard/file

Title. For what I know there are no mods currently to handle that for 1.20.6 and sometimes you really want that stuff in a file for further inspection

Thanks for your feedback. I have already had this in mind at some point but ignored it since I didn't know how to implement such a feature well. But I will look into this. My current thoughts are that holding ALT will copy components to the clipboard. This will be tied to a config that specifies what action to do when copying. Either copy all, just the selected component or do nothing (disabled).


Modernize

This change updates some of our older tools

pylint -> ruff
yapf -> black
Update the ci pipeline to use release please

Thinking about this a little more, I'm not sold on the changes from pylint and yapf to ruff and black. Right now it feels like "chasing the new shiny" by you guys who (to me) seem to live mostly in the javascript world that would impact myself and others in the office that I'm trying to teach/convince to use this template.
I'd like to see a little more explanation and discussion before introducing a change that will either require updating a lot of existing projects or require juggling two different sets of build tools for new and old projects.

Why are we changing all the ' to "? is that a default in black that needs to be updated?

Black is opinionated. You can read the FAQ for some answers to those types of questions.

Right now it feels like "chasing the new shiny"

I'm sorry it feels like we are chasing new and shiny but I have to disagree with you. This would be the first python tool chain change you have experienced since working for UGRC. Communities evolve and so do tools and the support they are receiving. We like to choose tools that are well supported and adopted by the community.
Black has been around for ~5 years and the python community has adopted it with open arms. YAPF just started receiving updates again but was mostly abandoned for the last few years. Ruff is newer. But its performance numbers and the fact that it replaces isort should be enough reason for all of us to rejoice in the change. The shift from configurable formatting to opinionated/uncompromising has happened in multiple programming languages/communities and will be the path going forward for some time. It's in our best interest to follow these trends.

... you guys who (to me) seem to live mostly in the javascript world that would impact myself and others in the office that I'm trying to teach/convince to use this template.

Scott and I do not live only in the javascript world. We write code in all the languages and not that it matters but probably more so than most of the others in the office combined. The impact of this change affects us all and should be mostly transparent. It should not affect the adoption of this template in anyway. New project will have different tools that on the surface perform the same job. I would be surprised if anyone in the office is aware of or cares what is formatting or linting their code. The vscode extension suggestions and settings.json will configure their environment to just work™ no matter what project they are working on. People can choose to migrate their projects if they want to use the improved tooling. There is no mandate or requirement to migrate tools. Build tooling does not change. Black also has documentation how how to not ruin your git blame with a style change.

I feel your pain, Jake. I'm not one that likes to chase after the new shiny stuff. It's hard for me to wrap my head around new tools and sometimes I push back. I think that's a good thing. I've also learned that Steve does not get offended by these types of questions and neither do I.
This change seems to be a good one to me. I'm very high on more opinionated, less configurable tools. Especially when it comes to code formatting and linting. I learned long ago that it's not worth arguing over things like ' vs. " or where to add indents. I feel like JavaScript lost years of its life arguing over things like this years ago. Then prettier came along and everyone got back to actually building stuff. Life gets SO much easier when you just go with whatever the prevailing opinionated tool is and move forward.
I've tried black and it's really a painless switch especially if you take the time to apply the format commit the right way. Once I made the switch, I immediately noticed the performance improvement and then got back to not worrying about how my code was formatted.
I have less experience with ruff, but the fact that it seems to have huge momentum and replaces isort is enough of a reason for me to switch and see how it goes. I've never been able to get isort to work consistently between my machine and CI.
For others in the office using this template, I can't see how this would affect them much at all. The template makes it very easy to get a project going without having to worry about what tools it's using. Just bootstrap the project, install the dependencies, and get to work. Existing projects can be brought into alignment as you work on them. I don't feel like it's a huge push to upgrade everything right away.

See the first article in this newsletter for a much better (and more entertaining) overview than I gave of how prettier affected the JavaScript ecosystem.


Add #define for defaults that works with assignment to pointer

What should the feature do?
Currently, in the generated files only one #define is added for assigning defaults to the struct.
Something like:
#define MyMessage_init_default               {"", ""}
Which can be used as in:
MyMessage foo = MyMessage_init_default;
It would be nice to have another one for assigning via pointers:
#define MyMessage_init_default_ptr               (MyMessage){.fieldone="",.fieldtwo=""}
Which could then be used like:
MyMessage *foo = malloc(sizeof(MyMessage));
*foo = MyMessage_init_default_ptr;
In what situation would the feature be useful?
right now it is hard to get at the default values if you're allocating on the heap. When allocating to the stack, if you have large repeated fields with max_size and max_count set it is easy to segfault.
Right now I'm leaving off the max_count and using the callback interface for that field, but that's a rather heavy workaround. :)
MyMessage_init_zero probably isn't as needed because you can just use calloc or equivalent, though somebody might expect it to be there too.

Hmm, doesn't *foo = (MyMessage)MyMessage_init_default work the same as the proposed format?
Designated initializers are a C99-only feature, so I generally try to avoid them in nanopb code. For example, some users compile nanopb code using old embedded compilers, or e.g. C++11 compilers which do not support them.
Though do note that pb_decode() does apply default values itself also, so often just using calloc() would be enough.

It's a syntax error, unfortunately.
The C99 way is the only way to get it one line, AFAIK. I guess there are a bunch of ways to achieve the same thing with a function instead of a macro, and that could be more portable. But probably more work. And also, if you're on an old compiler you're probably less likely to want to use the heap, since that usually implies a really small micro.
My goal is to have an internal library that runs on both larger and smaller systems, where the smaller system might only be decoding the required, non-repeating fields. But I'd still like to be able to just dump the repeating fields into memory on the larger systems, especially during development. Then later I can write callbacks to make it more efficient, or to fit it into the smaller systems.
It would only be useful as an option, but probably gcc use is common.
I can look at the pb_decode() source to see how it is done there. For decode it doesn't really matter, but for encode it is sometimes nice to be able to check what data will get sent out before sending it out.


Drivers with Camera streaming from D435i for MacOS

Would it possible to release drivers that support only video feed for now (without motion sensor) for Mac OS and/or Android? This should be easier to do I guess (since d430 is already supported) and then add support for HID motion sensor later. I'm considering buying D435i but it's still not supported for Mac OS. I cannot dual boot because I'm using soft raid 0 which is not supported by bootcamp. I would be happy with video feed for now but don't want to buy d430 just to sell it couple of months later and then buying d435i. Some ETA of drivers supporting other system would be great anyway.

I'd like to second this. Since 2.17.0 the site has said "Windows 7 and Mac OS support is expected to be added in future releases." Please can Mac OS support be added? Like pzoltowski I could live with the 435 driver and add motion support later, but I'd really like to get the vision system running on my Mac.

I'd be glad to have it too.
As mentionned here, processing does have a library which works with a D435i. but only the color stream though, :/ ...
If you want to do some quick test...

Hi @pzoltowski @bobgates @pierrextardif
I cannot test it right now, but looking at the code, with latest version on Mac OS librealsense should detect D435i and provide depth and color information - https://github.com/IntelRealSense/librealsense/pull/3804
I apologise for the delay in motion support. Unlike other features that wait in the backlog to be prioritised, this feature was planned, is being worked on for many months now and getting delayed due to complications in implementation. Maybe we chose the wrong approach, but when it is ultimately complete we are going to have a cross-platform open-source user-space driver for HID sensor devices, which can bring significant value not just for RealSense but to open-source community in general (somewhat similar to what libuvc did for UVC devices)
HID sensor drivers are far from being ubiquitous, both Linux kernel module and Windows implementation have many issues in them, so we had to rebuild a lot of the protocol from scratch using only the Spec and USB analyser. Fortunately, it's getting close to finished.

Hi @dorodnic
Thanks, I have tried to test it, with no luck.
There is a step in the cmake which doesn't work, and isn't listed in the errors so far, but I'm not sure where it comes from.
However, the brew install librealsense as mentionned #2811 installed it for me. ( further steps did not work, either with the latest develop branch).
My goal was to use it with Openframeworks, so I updated my version of the repo from hiroMTB, and I works!
Essentially 2.2.22 works with D435i for me.
++

@pierrextardif So you got it through with SDK v2.22.0, right? Any other questions about this ticket? Thanks!

Yeah, I'm happy.

yes, that's fine thanks for the help.
Best,
P

@pierrextardif @bobgates  Great! Thanks for the update!


Serialization Error: Trying to read past end of buffer

I get this when I try to get too fancy and use a nested query, so forgive me if this is user error.  I have a two-state workaround that's fine, but I'm curious about the error.
I'm in love with DuckDB, thanks!
This fails:
copy (
    select
        f.id, f.type, f.subtype, f.class, ST_GeomFromWkb(f.geometry) AS geometry
    from
        (select
            ST_GeomFromWkb(geometry) AS geometry
        from
            read_parquet('s3://overturemaps-us-west-2/release/2024-06-13-beta.1/theme=divisions/type=division_area/*', hive_partitioning=1)
        where
            country = 'US' and
            region = 'US-OR' and
            subtype = 'region'
        limit 1) as r,
        read_parquet('s3://overturemaps-us-west-2/release/2024-06-13-beta.0/theme=base/type=water/*', hive_partitioning=1) as f
    where
        bbox.xmin >= -125.48978996503888 and
        bbox.xmax <= -115.8454962385643 and
        bbox.ymin >= 41.310142574181384 and
        bbox.ymax <= 46.75110084463407 and
        ST_Intersects(
            ST_GeomFromWkb(f.geometry),
            ST_GeomFromWkb(r.geometry))
) to 'broken.fgb'
with (format gdal, driver 'FlatGeobuf');

This succeeds (previously saved the output):
copy (
    select
        f.id, f.type, f.subtype, f.class, ST_GeomFromWkb(f.geometry) AS geometry
    from read_parquet('oregon_region.parquet') as r,
        read_parquet('s3://overturemaps-us-west-2/release/2024-06-13-beta.0/theme=base/type=water/*', hive_partitioning=1) as f
    where
        bbox.xmin >= -125.48978996503888 and
        bbox.xmax <= -115.8454962385643 and
        bbox.ymin >= 41.310142574181384 and
        bbox.ymax <= 46.75110084463407 and
        ST_Intersects(
            ST_GeomFromWkb(f.geometry),
            ST_GeomFromWkb(r.geometry))
) to 'intermediate.fgb'
with (format gdal, driver 'FlatGeobuf');

Both queries start with:
INSTALL spatial;
INSTALL httpfs;
LOAD spatial;
LOAD httpfs;
SET s3_region='us-west-2';

I think the issue is here
    select
        f.id, f.type, f.subtype, f.class, ST_GeomFromWkb(f.geometry) AS geometry
    from
        (select
            ST_GeomFromWkb(geometry) AS geometry

You're converting from WKB twice, as GEOMETRY is implicitly castable from BLOB. I think this has been changed in the latest dev build so that geometry won't implicitly cast to blobs anymore and this will thus result in a binder exception.

Ouch!  That did it, thank you for the quick response 🙏


Fixing squid  S1213 Members of classes and interfaces should appear in a predifend order part 3

"This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - “The members of an interface declaration or class should appear in a pre-defined order".
This PR will remove 90 min TD.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S106
Please let me know if you have any questions.
Fevzi Ozgul

Coverage remained the same at 39.925% when pulling 0fedcff91885f37f96d5c7fd3dfb6962db2ec855 on DevFactory:release/The_members_of_an_interface_declaration_or_class_should_appear_in_predefined_order_part_3 into 38449cef286c4c772ec13081ae1100542cca3527 on alexvoronov:master.

Hi Alex, I wonder if we could settle my pending PRs this week? As my
company DevFactory will end this Open Source optimization & cleaning
project by the end of this week it is important that I get my pending PRs
all settled within this week. Thank you very much for your cooperation.
Fevzi Ozgul
On Wed, Jun 15, 2016 at 4:31 PM, Alex Voronov<EMAIL_ADDRESS>wrote:

Merged #28 https://github.com/alexvoronov/geonetworking/pull/28.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexvoronov/geonetworking/pull/28#event-693239550,
or mute the thread
https://github.com/notifications/unsubscribe/AR09BAuz7RxUu6xhKDylZCd51K2V1Ax2ks5qL_6ogaJpZM4IyPYA
.


How to debug winafl with vs2017

How to debug winafl with vs2017

I want to debug winafl with source , how can i do it with vs2017 or other debugger?

By "debug WinAFL" I assume you mean the WinAFL DynamoRIO client (WinAFL.dll) since all other components are trivial to debug (cmake generates VS project/solution files and you can go from there).
When it comes to the DynamoRIO client, I'm afraid the answer is "no". You can see some tips on DynamoRIO debugging at https://github.com/DynamoRIO/dynamorio/wiki/Debugging. Most of the time though I find it more convenient to just dump stuff I'm interested in into the debug log such as in https://github.com/googleprojectzero/winafl/blob/master/winafl.c#L664.

when i debug alf-fuxx  with vs2017 , I get this error  "Source information is missing from debugging information for this module "，what  should i do ?

when i debug alf-fuxx with vs2017 , I get this error "Source information is missing from debugging information for this module "，what should i do ?

ok, I solved it,  add two  parameters to  our vs project:   /ZI   /JMC

Glad you solved it! I think the DR client project (winafl.dll) might be messing up the vs flags for other projects in the same directory, so possibly could also be resolved by running cmake without -DDynamoRIO_DIR (which doesn't generate the winafl.dll project). Though of course your solution is better if you want to have all projects ready to build.


ci: fix osx build

Risk Level: None
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

OSX passed. Merging.


cannot able to add custom proprtties / property,

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug
Feature request
Question

NLog version: (e.g. 4.2.3)
Platform: .Net 3.5 / .Net 4.0 / .Net 4.5 / Mono 4 / Silverlight 4 / Silverlight 5 / Xamarin Android / Xamarin iOs
Current NLog config (xml or C#, if relevant)
<nlog>
  <targets>
  </targets>
  <rules>
  </rules>
</nlog>

In case of a BUG:

What is the current result?
What is the expected result?
Did you checked the Internal log?
Please post full exception details (message, stacktrace, inner exceptions)
Are there any work arrounds? yes/no
Is there a version in which it did worked?
Can you help us by writing an unit test?

in case of a FEATURE REQUEST:

Why do we need it?
An example of the XML config, if relevant.

Please provide the requested info

If you post the needed info, I will re-open the ticket.


Implement Macro Does Not Allow Type Parameters

Consider the following example (from the test code):
#[implement(
    extend Windows::UI::Xaml::Application,
    override OnLaunched OnBackgroundActivated,
    Windows::Foundation::IStringable,
    Windows::Foundation::IClosable,
)]
struct AppWithOverrides<T> {}

#[allow(non_snake_case)]
impl <T: IntoIterator + 'static> AppWithOverrides<T> {
    fn ToString(&self) -> Result<HSTRING> {
        Ok("Stringable".into())
    }

    fn Close(&self) -> Result<()> {
        Ok(())
    }
}

This would be needed for implementing collections (like IVector).
When generating AppWithOverrides_box, it doesn't include the type parameters in the struct and impl.

Thanks, I'm aware of this limitation. I'm planning to support generics as part of #81.

I'm not yet sure whether to support generic structs or just generic instantiations or both. By generic struct I mean:
#[implement(Windows::Foundation::Collections::IVector<T>)]
struct Thing<T> {
    // ...
}

And by generic instantiation I mean:
#[implement(Windows::Foundation::Collections::IVector<i32>)]
struct Thing {
    // ...
}

I suspect we'll need both. I'm unsure whether we need generic structs that aren't used as WinRT type parameters.

I think it'd be good to support generic structs. When implementing a custom implementation for IVector for example, it's probably necessary.

Thanks for the feedback! I'll track this as a duplicate of #81

This should now be working. Let me know if you experience any issues.


Fix missing Makefile lines to re-enable multiple use= options

When implementing the CMake build system, I missed copying a couple of lines from the old Makefile that meant that you could only specify one use= option when doing make configure on Posix.  This change restores those lines, so you can specify multiple options for use, e.g. make configure use=memtrack_messages,address_sanitizer.

Hi @kulibali,
The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.
Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3637.md to match the number of this pull request.
The basic format of the release notes (using markdown) should be:
## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.


./src/zdemo_excel37.prog.abap[23, 59]              - Text element not found (check_text_elements)

./src/zdemo_excel37.prog.abap[23, 59]              - Text element not found (check_text_elements)
upper lower case problem?
https://github.com/sapmentors/abap2xlsx/blob/ac6ffe90f19763911c33a47c8f63a6ab8b33e78f/src/zdemo_excel37.prog.abap#L23

hmm, not sure why, lower case seems to work

in this example there is a text in I18N_TPOOL, but the original language TPOOL does not exist

so I'd say this error is a correct finding, closing


Fixed removed config condition

-
-

Issue
https://github.com/ripe-tech/ripe-sdk-components-vue/pull/32#discussion_r517258774

Dependencies
--

Decisions
Readded removed config

Animated GIF
--

@NFSS10 did you see https://github.com/ripe-tech/ripe-sdk-components-vue/pull/32#discussion_r517258774 ?

@NFSS10 did you see #32 (comment) ?

Yes.
Wasn't this what you meant?

@NFSS10 did you see #32 (comment) ?

Yes.
Wasn't this PR changes what you meant?

@NFSS10 all of this can now be backported right?

@NFSS10 all of this can now be backported right?

If the implementation is good, yes I will start the backport to components-react

@NFSS10 Let's back-port this


Added Climbing Stairs problem (Dynamic Programming)

Shown the implementation of climbing stairs porblem by using both top down and bottom up dynamic programming algorithms.
Issue : #38

@Jpduker LGTM , thank you for the contribution .


Consider refactoring plane types from OpticalElements to OpticalSystems

Promoted to its own issue from a comment on #151 :
Something to consider for eventual API larger overhaul.  In retrospect I don't think that I should have made planetype a property of an optic itself. Rather it is a property of the ordering of planes that makes up an optical system. The OpticalSystem should maintain the list of plane types along with the list of plane objects themselves. (And the list of distances between planes, in the case of the FresnelOpticalSystem.)
Back story:  When this was just a Fraunhofer domain code, there was a clear distinction between pupil plane optics specified with linear physical units (meters) and image plane optics with angular units (arcseconds). In the more general Fresnel domain, a given optic described in linear physical units can be located at any plane. It's not a property of the optic itself, it's a property of where it is in the optical system as a whole. (and Wavefronts do have a well defined plane type at each stage of propagation through that system).  It may be cleaner and more self-consistent to remove having plane type as a property of the optical element classes.

Not going to happen any time soon - seems to be limited return on investment for refactoring this. Removing the milestone tag.


ParserUtil: parseX(...) methods should not take in Optional #523

Fixes #523.

v1
@Zhiyuan-Amos submitted v1 for review.

[v1 1/1] ParserUtil: parseX(...) methods should not take in Optional

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/556/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v2
@Zhiyuan-Amos submitted v2 for review.

[v2 1/1] ParserUtil: parseX(...) methods should not take in Optional

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/556/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc would like to check if the architecture is fine :)

Remind me to discuss tomorrow.

As discussed, ParserUtil methods are like the middle-man, so it is okay to use Optional<?> as a parameter here even though it is not the correct Java convention (convention = only use in return type).

Superseded by #523


Arrays (at least created with split) seem to be creating garbage data.

Yet another problem with arrays, apparently even disabling the GC won't fix them. Oh well, time to look into it formally i guess...

Got it to work with the Garbage Collector disabled. Maybe this requires a little work with #23 to be fully fixed.


[master] MODCLUSTER-686 Change use of HTTP download locations to HTTPS

https://issues.jboss.org/browse/MODCLUSTER-686

There is no reason to have the repository here, we will just remove this completely.


Layering problem

When I create a plane, based on a ShapeFactory cube, and want to place other objects on top of it, I see lots of problems in regards of layering, where objects that are placed behind other objects suddenly cover objects in front of them. This happens based on the rotation of the phone.
Here is the effect in action:
https://photos.app.goo.gl/DA7gt1QZZMjLgQXf8
The code looks like this:
`          Texture.builder()
.setSource(getApplicationContext(), R.drawable.boardbackground)
.build()
.thenAccept(backtexture ->
MaterialFactory.makeTransparentWithTexture(getApplicationContext(), backtexture)
.thenAccept(backmaterial -> {
ModelRenderable backrenderable = ShapeFactory.makeCube(new Vector3(1f, 0.01f, 1f), Vector3.zero(), backmaterial);
                    Node background = new Node();
                    background.setLocalPosition(Vector3.up());
                    background.setParent(anchorNode);
                    background.setRenderable(backrenderable);

                    Texture.builder()
                        .setSource(getApplicationContext(), R.drawable.img_20180609_115300)
                        .build()
                        .thenAccept(texture ->
                            MaterialFactory.makeTransparentWithTexture(getApplicationContext(), texture)
                                .thenAccept(material -> {
                                  ModelRenderable renderable = ShapeFactory.makeCube(new Vector3(0.5f, 0.01f, 0.5f), Vector3.zero(), material);

                                  Node foreground = new Node();

(x)                                      foreground.setLocalPosition(new Vector3(0.2f, 0.1f, 0f));
foreground.setParent(background);
foreground.setRenderable(renderable);
})
);
                  })
          );

(x) This effect is for example triggered, when a value other than 0 for x or z is entered here. Keeping these values to 0 'fixes' this problem. The problem shows up when the top layer is a child of theanchorNodeorbackground`.
Any idea why this happens?

Any comment on this one? Am I doing something wrong, can you replicate it? Need to get rid of this problem quickly.

@romainguy
Yes, in the app there are 2 overlapping objects - an image in the background and a text partially covering it. I want the image to fade out below the text, and the text to be visible behind the text.
@malik-at-work
Thank you for your explanation.
So, what you are saying is, that the order in the scene graph isn't enough to ensure the correct object is drawn above?
I'll play around with the render priority and let you know how it turns out.

The order in the scene graph is usually enough but transparent close to each other can create issues, especially when they are plane-like objects.

Romain, thank you for your continued answers that help me to understand whats going on.
With center of the object, do you mean the center set here?
ModelRenderable renderable = ShapeFactory.makeCube(new Vector3(0.5f, 0.01f, 0.5f), Vector3.zero(), material);
It is set to zero in this case, but when I set it to the value set as localPosition, and set the localPosition to Vector3.zero() instead, the effect is the same.

It's the calculated center of the bounding box, transformed by the object's position/rotation/scale.

As the position of the centers is so 'far' away in this case, both horizontally and vertically, I think there should be a way to improve this calculation.

It's the distance of the centers to the camera plane. And like I said earlier the issue is that other ways of computing the distances break in other cases (I know some engines let you choose which distance algorithm you want precisely for that reason).

Obviously I don't know enough about the rendering process to understand the problem here. I just notice this as another weird behaviour of Sceneform I have to work around.
Good thing is, setting the render priority to 0 for the background seems to finally solve this problem.


Problem when opening a file originally in xls in csv format from Google Sheets - Discussion/Research?

Problem description
If you import a dataset in xls in Google Sheets with any kind of problem that the ODE would detect as an error and then you download the dataset in csv to open it in the ODE, the app will detect different issues depending on the format.
Steps to reproduce it

Download the third dataset listed here(xls format).
Import the dataset to Google Sheets.
Download the file in csv format.
Open the ODE.
Go to ADD--FILE--Select the file.

Comments
When exporting the file in xls, the ODE will only detect blank labels for columns.

When exporting the file in csv, the ODE will inform the user about problems in the type of data in columns.

Is there any explanation for this or is it a bug?

Hello, @romicolman
I can reproduce the issue more or less. This is what i get. The errors are the same in the report but I don't get those extra empty columns on the right like in your screenshot.

I know why the error is happening. Exactly this column is number separated with a comma, since the csv by definition uses the comma to separate the different columns, Google sheets exports the comma separated values as a string (you can see in the csv that the numbers in this column are wrapped with "", example "3,04" for the first column).
Frictionless is detecting a field with this format "number,number" as a geojson column type, when it should be detected as a string because the format in the csv is a string originally. Ideally this case should be detected and it should be imported as a number... or even better, i think at some point the user should be asked what type will the column be when importing these ambiguous types.
To make the error go away you should set the columns schema field value to string:

To think of a solution to this issue we need to know why it was designed like this. I think @roll can help us with that. :)

Hello, @romicolman I can reproduce the issue more or less. This is what i get. The errors are the same in the report but I don't get those extra empty columns on the right like in your screenshot.

I know why the error is happening. Exactly this column is a decimal number separated with a comma. Since the csv by definition uses the comma to separate the different columns, Google sheets exports the comma separated values as a string (you can see in the csv that the numbers in this column are wrapped with "", example "3,04" for the first column). Ideally we would have the data exported as value,value,3.04 with the decimal separated by a dot, but we can't control much how users set up formatting in google sheets so we have to find a solution to this exact issue.
Frictionless is detecting a field with this format "number,number" as a geojson column type for some reason, when it should be detected as a string because the format in the csv is a string originally. Ideally this case should be detected and imported as a number... or even better, i think at some point the user should be asked what the schema type of the column is when importing these ambiguous types.
To make the error go away for now you should set the columns schema field value to string, (at the start it is set to geojson):

But even this is not exactly what we want because this is exported as a string by google sheets but we should have the option to read it as a number and currently there is also an error in ODE if you change the schema type to number. You found a very particular case, lol.
I don't think the report message is particularly helpful for finding out what the problem is. Probably many non tech users wouldn't be able to figure out why the column is creating an error so I think this is a good opportunity as well to suggest more detailed error messages for type errors.
To think of a solution to this issue we need to know why it was designed like this. Why is this specific format imported as geojson? I think @roll can help us with that.
@pdelboca what are your suggestions for an issue like this?

Hi @guergana! I know why you are not able to see the extra columns errors. Do this: once you open the csv on the ODE, click on REPORT and within the report view, please select TYPE ERROR.
In addition, do not close this issue. I'll move it to sprint 6 so I can document it properly for the user guide.

@romicolman As suspected the data package standard format for geopoint is "lat, long" https://datapackage.org/standard/table-schema/#geopoint so this is not an issue per se with the app, we need to figure out how to make clear that there is this compatibility issue between google sheets when exporting csvs or find a way to mitigate it.

I managed to see the problem exporting in .xls now with the extra columns. I had not tested that part. My bad. 😬

Hi @guergana! I agree. This is something we would need to document properly for the user, but we won't work on this for the stable version. I'm moving this issue to the next sprint so to write about this for the user guide.

@guergana I will add a new section to the user guide called Key recommendations when uploading data to the ODE to incorporate this and other things users should keep in mind. Here is the suggested text:
_Before uploading a file to the ODE…

Make sure your file is well-organized: each column must contain a name, there should be no extra rows before the table, or additional elements (like borders or lines) next to the space where the tabular data is located, etc.

Check that the tabular data does not contain cells that are merged. Data producers from Governments, international organizations and internal reports usually add tiles,  descriptions, graphs within sheets, like in this case. If there are extra elements in your file, the ODE will ingest your file and show you multiple errors.

If you export a file from Google Sheets in csv and you have columns with numbers, please, make sure to use “.” for decimals, instead of  commas. Otherwise, Frictionless, the code working behind the ODE will interpret the content of your cells with numbers as text._

What do you think?

@guergana I will add a new section to the user guide called Key recommendations when uploading data to the ODE to incorporate this and other things users should keep in mind. Here is the suggested text:
_Before uploading a file to the ODE…
* Make sure your file is well-organized: each column must contain a name, there should be no extra rows before the table, or additional elements (like borders or lines) next to the space where the tabular data is located, etc.

* Check that the tabular data does not contain cells that are merged. Data producers from Governments, international organizations and internal reports usually add tiles,  descriptions, graphs within sheets, like in this [case](https://stat.link/vtenks). If there are extra elements in your file, the ODE will ingest your file and show you multiple errors.

* If you export a file from Google Sheets in csv and you have columns with numbers, please, make sure to use “.” for decimals, instead of  commas. Otherwise, Frictionless, the code working behind the ODE will interpret the content of your cells with numbers as text._

What do you think?

Hi, great work, I have some observations:

For the first point I would change a few words, though, instead of "well-organized" I would say "well-formatted", also I would remove the etc at the end. Etc adds ambiguity and I don't think it's a good idea to have this work in guidelines or docs. This lets the user assume what the etc can be, let's instead provide a complete list of badly formatted cases.

Make sure your file is well-formatted: each column must contain a name, there should be no extra rows before the table, or additional elements (like borders or lines) next to the space where the tabular data is located.

In the second point, I don't understand what is meant by "ingest" in "the ODE will ingest your file". Do we have maybe another word for this?

I find the third point too technical, it's giving too much explanations for a non technical user, I would just say that the format for decimal numbers needs to be separated by a dot "." instead of a comma. I would maybe add a link to somewhere else to explain the details of why this is an issue. Maybe a link to this issue or something.

Now what do you think about my observations @romicolman ? :stuck_out_tongue:

Perfect! I integrated your feedback, Guergana. Thanks a lot!


BQSR result size is too large

Bigger than spark.driver.maxResultSize:
WARNING:toil.leader:7337aec6-1c64-41ff-8684-46c35d624c08:       org.apache.spark.SparkException: Job aborted due to stage failure: Total size of serialized results of 247 tasks (1024.4 MB) is bigger than spark.driver.maxResultSize (1024.0 MB)

Almost all of the time it is by 5 damned MB.

Do we just have to bump spark.driver.maxResultSize here?
https://github.com/BD2KGenomics/toil-scripts/blob/master/src/toil_scripts/adam_pipeline/adam_preprocessing.py#L111

Yeah, that's what I was going to do. Simplest sol'n.


oneDNN ACL indirect conv patch

Adds a patch enabling indirect conv for lower core counts in oneDNN ACL builds. This reduces memory usage of computer vision models. Performance is also improved for these systems. Relative improvement after patch is shown here:

@penpornk


Placeholder fix & .gitignore added

On the demo-page, when you add a very large margin-top on the <div class="demo"> element and you scroll down you won't be able anymore to drag & drop an element to the top of the dragster-region.
Only if you put the scrollbar all the way to the top, this issue is resolved, but not when the scrollbar isn't at the top. This fix, solves this issue.

Done!

@webtrix can you run git rebase -i HEAD~4 in your terminal, please? It allow you to remove the commits with addition/removal of .gitignore file. You should have only 2 commits in the end :)

Hmm.. did something wrong, will create a new PR, sorry.

OK, this explains. I was using the latest tag (1.3.2) version of you code, and not the code of you master branch. The code in your master branch also fixes the problem.
Maybe create a new tag? :-)


Norm

New function to do Shapiro Wilk test for normality on 2-d data, spitting out a 1-d array of p-values. Also added Pandas to the requirements.
Some updates for PCA. 6 components is the recommended number. Some nice plots too!

I forgot to approve this. Good job, this will help do Shapiro Wilks on a subset of the 4d matrix. :)


Fixed: #261 - error response body needs to be rehydrated

Forgot to do this way back in the day, and somebody finally noticed. :)

Thanks @roblg.  Good fix.