Crash with carry on mod and cloud boots mod

when using carry function from carry on mod, extra sounds makes weird sound (kinda like air or something) and immidieatly crashes the game and with cloud boots if you have them equipped and you are in the air with them equipped the game will also crash i am sure that it's extra sounds that cause crash since these were the only mods i had in folder and previous versions of the mod didn't crash
i think it's because of asset mover since the version 1.2.0 doesn't crash at all and other mods that use asset mover have very simmilar issues with crashing but i am not 100% sure

No need for assumptions when you got actual crash reports!
Please upload them here and share the links.

Fixed in the upcoming release.


Use update-checkout to pull swift dependencies

Pull Request Description

Use update-checkout to reduce work related to keeping swift dependencies up to date for compiler builds

This will allow us to have 1 location to update when dependency updates are needed, eliminating the need for PR's such as #799 or #796

========================================
Failures:
  FAIL: swift-distributed-actors, 5.7, e024c1, Swift Package
========================================

This is unrelated, will open a PR for this xfail separately (https://github.com/apple/swift-distributed-actors/issues/1113)

Rather than xfailing this consistently can we fix the build runner to allow passing -enable-testing? This has been a consistent painpoint for projects that didn't adopt "SPI" style

Awesome, passed! Thank you @justice-adams-apple !

@ahoppen Wanted to run this by you before merging since it changes the run_sk_stress_test logic

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test


Added reference to GIT-aur version of hyprland

Describe your PR, what does it fix/add?
Adds reference to the AUR-git version of hyprland.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Does not need any work

thanks, improved the styling a bit and added more info.

thanks, improved the styling a bit and added more info.

PS. I am also the person maintaining the AUR package :)

thanks for the package!

I hope you tested it, in Hypr the package was broken at first because PKGBUILD sets some weird-ass flags that would produce a broken Hypr executable that wouldn't work.


[Beta] "Enable Color Mode?" dialog can be hidden, appears to "freeze" the editor

Describe the bug
Clicking on "Colorize" brings up the "Enable Color Mode?" dialog as expected. If you use Alt + Tab or click on the editor in the back, the dialog is temporarily hidden, but control is not fully restored to the editor. The editor is even able to keep track of all the requests to enable Colorize mode, resulting in a hilarious train of dialog boxes that keep popping up no matter how many times you accept/cancel the dialog.
To Reproduce
Steps to reproduce the behavior:

Create a project that does not have color mode enabled
Click on "Colorize"
Press Alt + Tab or click on the background window
Editor will appear to be frozen until the dialog is found again and resolved
The editor is also still receptive to further requests to enable colorize mode, stacks these requests and displays them after the current dialog is resolved

Expected behavior
Clicking the editor or attempting to do actions on the editor prevents me from hiding the dialog that's freezing the editor, making sure I take action on it before continuing. I expected something similar to the "Do you want to save the changes you made?" dialog when you try to close the editor with unsaved changes.
Platform (please complete the following information):

OS: Windows 10 64 bit
App version 2.0.0 Beta

Additional context
This is just an ease of use thing that will prevent headaches like I just experienced, when I was unsure if I wanted to enable color mode on my project. I hesitated to add color mode because I wasn't sure if adding it would kill compatibility with classic GB emulators/systems, which is a reassurance I'd appreciate also being added to the "Enable Color Mode?" dialogue if possible.

Thanks for spotting this @DeerTears it's weird because macOS was treating that window as a modal and not allowing the main window to gain focus or accept clicks but I've found a fix which I've implemented in #493
I also improved the wording a little, hopefully should be clearer now!


Are native libraries supported?

My Lua module makes use of xml, which in turns uses RapidXML for its library. Does starlight support such things or is it for pure Lua?

Starlight only translates pure Lua to JavaScript so, no, you won't be able to use RapidXML with it. Sorry.


DllImport System.DllNotFoundException on OSX when using PublishSingleFile=true

I wrap a native library using DllImport("native_dependency"). Both native_dependency.dll as well as native_dependency.dylib are located in the same folder as the executable. This works fine on both Windows and OSX, as long as I do not compile with /p:PublishSingleFile=true.  On Windows, there seems no problem with /p:PublishSingleFile=true but on OSX the native dependency cannot be found:
Unhandled exception. System.DllNotFoundException: Unable to load shared library 'native_dependency' or one of its dependencies.

As so many times. Right after creating an issue it seems there was something else going wrong.


[SPARK-7736] [core] Fix a race introduced in PythonRunner.

The fix for SPARK-7736 introduced a race where a port value of "-1"
could be passed down to the pyspark process, causing it to fail to
connect back to the JVM. This change adds code to fix that race.

Example of the error:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41051/artifact/yarn/target/unit-tests.log
File<EMAIL_ADDRESS>line 425, in startOverflowError: getsockaddrarg: port must be 0-65535.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41073/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #41074 has started for   PR 8258 at commit 30b0ee5.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41076/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #41077 has started for   PR 8258 at commit cfef35d.

@vanzin is this the right JIRA?

also, I've seen this non-determinism from the user list. It would definitely be good to fix it.

Yes; this bug was introduces by a change that I pushed this morning.

Test build #41074 has finished for   PR 8258 at commit 30b0ee5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41074/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #41089 has started for   PR 8258 at commit d8831a2.

Test build #41077 has finished for   PR 8258 at commit cfef35d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41077/
Test FAILed.

Test build #41089 timed out     for PR 8258 at commit d8831a2     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41089/
Test FAILed.

I'll try tests again but I'm inclined to merge this soon. retest this please

Merged build triggered.

Merged build started.

Test build #41137 has started for   PR 8258 at commit d8831a2.

Test build #41137 has finished for   PR 8258 at commit d8831a2.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41137/
Test FAILed.

pyspark fail is the same flaky test that has been failing on and off for a long time. I'm merging this.


max_calls/max_repeated_calls error

The bug
When I try to reuse a models.OpenAI object (because the tokenizer is very slow to load) I get an error about max_calls. It's unclear how
To Reproduce
from guidance import models, gen, user, system, assistant
import time

gpt = models.OpenAI("gpt-3.5-turbo")

def doit():
    with user():
        lm = gpt + "What is the capital of France?"

    with assistant():
        lm += gen("capital", temperature=0)

    return lm["capital"]

# no crashing but really slow
for i in range(0, 12):
    start = time.time()
    gpt = models.OpenAI("gpt-3.5-turbo")

    print(doit())
    print(time.time() - start)

# faster but crashes

for i in range(0, 12):
    start = time.time()
    print(doit())
    print(time.time() - start)

System info (please complete the following information):
MacOS

Guidance Version (guidance.__version__):
'0.1.5'

I thought this was a duplicate of #502 , but I have also verified it with 0.1.5

@prescod As per @tshu-w , this seems to be by design.  You can set the max_calls to override this behavior (see https://github.com/guidance-ai/guidance/issues/502#issuecomment-1840162301).

@prescod - The library authors felt it necessary to have this max_calls limit, probably because of the way they try to compensate for feature variance across platforms, see #502.
You can simply set it on your client after you've instantiated it:
gpt = models.OpenAI("gpt-3.5-turbo")
gpt.max_calls = 10**6

In my experience, OpenAI answer quality degrades after a large number of tokens. Depending on your usage, this may or may not matter.


nwjs: 0.85.0 -> 0.87.0, add libGL

Description of changes
Update to latest release
0.87.0 ships with Chromium 124 which has a bug with wayland which affects at least KDE where the window is blank upon launch. Workaround is to run applications with --enable-features=UseOzonePlatform --ozone-platform=wayland until nwjs ships with 125.
libGL fixes crashes related to the following errors:
[7368:7368:0503/071847.705461:ERROR:angle_platform_impl.cc(44)] Display.cpp:1052 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
ERR: Display.cpp:1052 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
[7368:7368:0503/071847.705523:ERROR:gl_display.cc(515)] EGL Driver message (Critical) eglInitialize: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
[7368:7368:0503/071847.705531:ERROR:gl_display.cc(786)] eglInitialize OpenGL failed with error EGL_NOT_INITIALIZED, trying next display type
[7368:7368:0503/071847.705586:ERROR:angle_platform_impl.cc(44)] Display.cpp:1052 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
ERR: Display.cpp:1052 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
[7368:7368:0503/071847.705598:ERROR:gl_display.cc(515)] EGL Driver message (Critical) eglInitialize: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
[7368:7368:0503/071847.705605:ERROR:gl_display.cc(786)] eglInitialize OpenGLES failed with error EGL_NOT_INITIALIZED
[7368:7368:0503/071847.705612:ERROR:gl_display.cc(820)] Initialization of all EGL display types failed.
[7368:7368:0503/071847.705622:ERROR:gl_ozone_egl.cc(26)] GLDisplayEGL::Initialize failed.

Fixes https://github.com/NixOS/nixpkgs/issues/308565

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 308942 run on x86_64-linux 1

10 packages built:

betaflight-configurator
emuflight-configurator
gridtracker
inav-configurator
nwjs
nwjs-sdk
onlykey
pinegrow
pinegrow6
popcorntime

Thank you!


okteta: 0.26.15 -> 0.26.18

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/okteta/versions.
meta.description for okteta is: Hex editor
meta.homepage for okteta is: https://apps.kde.org/okteta/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.26.18 with grep in /nix/store/623py203np8ma5z61kk0ix76rqh1bfcy-okteta-0.26.18
found 0.26.18 in filename of file in /nix/store/623py203np8ma5z61kk0ix76rqh1bfcy-okteta-0.26.18

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

okteta

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/623py203np8ma5z61kk0ix76rqh1bfcy-okteta-0.26.18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A okteta https://github.com/r-ryantm/nixpkgs/archive/a6bd9d55bda4ca912b2b0399ccd364fdff5d392f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a6bd9d55bda4ca912b2b0399ccd364fdff5d392f#okteta

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/623py203np8ma5z61kk0ix76rqh1bfcy-okteta-0.26.18
ls -la /nix/store/623py203np8ma5z61kk0ix76rqh1bfcy-okteta-0.26.18/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

okteta
okteta.dev

Maintainer pings
cc @peterhoeg @bkchr for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 348285

x86_64-linux

:white_check_mark: 2 packages built:

okteta
okteta.dev


Fix 403: no errors for misnamed fields in aggregate constructor expression

This issue turned up in #375 too, which started to fail when the solution for #403 was implemented.  That resulted in fixing the test case for #375 as well.

Aggregate constructors are no longer supported by the language. We removed them, and all expression things, because of the number of issues they were generating and because it became too much like implementation, not specification.


find_package(CUDAToolkit REQUIRED) even when TI_WITH_CUDA Off

This option doesn't seem to be referencing the top-level CMakeFiles:
https://github.com/taichi-dev/taichi-aot-demo/blob/a6c35b6a8b1cc17768bc66ed628c2b44cf889bf7/framework/CMakeLists.txt#L85
Resulting in:
CMake Error at /.miniconda3/envs/lib/python3.10/site-packages/cmake/data/share/cmake-3.26/Modules/FindCUDAToolkit.cmake:748 (message):
  Could not find nvcc, please set CUDAToolkit_ROOT.
Call Stack (most recent call first):
  framework/CMakeLists.txt:92 (find_package)

Even when:
https://github.com/taichi-dev/taichi-aot-demo/blob/a6c35b6a8b1cc17768bc66ed628c2b44cf889bf7/CMakeLists.txt#L13

Usually we disables entire LLVM backend without CUDA because the CPU backend has some issue with its allocator (memories doesn't dealloc). So I would recommend you to shift to the SPIR-V backends like Vulkan or Metal for deployment (if CUDA is unwanted). But please feel free to PR this change if you find it necessary.


Fountains are using 13% CPU Usage (just 1 fountain already)

I think this is because the fountain is too fast. Can you make blockparticle more optional? like adding interval for fountains & particles? I would like to put my fountain interval lower.
https://i.insanemc.net/brave_0TTRiaXSLC.png

Yes, this is an issue that I have been looking into. I'll see what I can do with this info thanks.

Added to project board.


SWARM-1404 - Added OpenTracing example

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jkandasa , if you have some time, would you test this? This requires wildfly-swarm/wildfly-swarm#546 , so, build that one locally (mvn clean install -DskipTests) and then follow the README instructions for the OpenTracing Servlet example.

None of the failures seem to be related to this PR:
org.wildfly.swarm.it.ribbon.RibbonIT.testIt and org.wildfly.swarm.it.vaadin.VaadinApplicationIT.testIt
As such, I think this is ready to be merged.


consider re-exporting Rng trait

This is a pretty minor papercut.
As it is an extra dependency (rand) is required to make functions which can use the rng passed by Strategy::prop_perturb
It would be nice to not require this dependency. This also protects against (rare) cases where someone depends on multiple versions of rand. They could specify proptest::Rng specifically if they needed to.

The problem had occurred to me when I wrote that code, but I didn't think there was such a simple solution.  Would you happen to have an example of another crate that takes this approach? I couldn't find anything on the topic after some brief searching, but I'd like to adhere to convention if any exists here. (If not, that's fine, I'll figure something out.)
In any case, thanks for the suggestion!

I've seen it before, but I'm not sure how common it is.

itertools rexports the Either type.
jsonrpc-core is where I first saw it, in that it rexports serde_json::Value. This proved to be very important when serde was moving to 1.0 since jsonrpc-core was slower than some other libraries and I had to convert between the two different serde types to use the library. I don't know how I would have done it had jsonrpc_core not rexported  Value,to_string and to_value.

A mark against is that neither serde_json or toml rexport the Serialize or Deserialize types.

This has been implemented in 0.3.3. The reexport is found in proptest::prelude.

I also opened this question ticket on serde-json to get their feedback. I'm interested in their input
serde-rs/json#400


Automatically detect whether input data has headers

i.e. If supplied with:
207Pb*/235U	±2σ (%)	206Pb*/238U	±2σ (%)	corr coef
29.165688743	1.519417676	0.712165893	1.395116767	0.918191745
29.031535970	1.799945600	0.714916493	1.647075269	0.915069472
Topsoil should be able to determine (or guess) that the top row is a header row, and apply it to the TableColumn names.

New enhancement to do: it should be possible to manage the import of files and contents with multiple lines of headers (zero, one or two), and skip the invalid lines of values (instead of displaying NaN in the table).


[FR] Ignore words by regex everywhere

I have a lot of formulas in my vault (and open note) which I don't want to be reccomended at all, so I would like to exclude them via a regex.
This is already possible for the custom dictionary, but it would be great if that was possible for everything.

Hi, @shnurks :)
That looks good👍 Do you use either 'Current file complements' or 'Current vault complements' ?

I use both of them and I would really enjoy it if it also was available in both.

@shnurks
Released in v10.0.0-beta2 🚀
If you use BRAT, I would appreciate it if you could check it out before the official release.

@shnurks
Released in v10.0.0 🚀


Add Logger adapter.

This can be useful when you don't want to send real emails but still
want the Mailer to return successfully.
This was triggered by https://github.com/swoosh/swoosh/pull/72/

Love it, depending on how you feel about the comments, get this merged in!


Backport "Port tailrec spec and adjustments to annotations section" to LTS

Backports #19978 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-19986.
Reference


How to add \noauthor for non existing author field

The Wiki link to https://github.com/retorquere/zotero-better-bibtex/wiki/Scripting-API
doesn't exist. So I don't know how to check for a non existing entry. I tried the following but it completely removes the entries with no author.
if ( Translator.BetterBibLaTex ) {
 if ( this.item.author == "" ) {
  this.add({ name: 'author', value: "\noauthor"});
 }
}

Oh, that page was out of date. What you want is
if ( Translator.BetterBibLaTex ) {
 if ( ! this.has.author ) {
  this.add({ name: 'author', bibtex: "\\noauthor"});
 }
}

value means "something the user could have typed in" which means it gets translated to LaTeX; bibtex means "what the user typed in, translated to LaTeX". By passing in bibtex, BBT assumes you know what you're doing and uses that. The double-backslash is required because the backslash is a javascript escape character, so \noauthor means <newline>oauthor in javascript. The double backslash means "no, actually a backslash".
No idea why your script would remove the entry entirely. The check for this.item.author == "" should fail because this.item (which is the zotero reference, not the bibtex reference) will never have the author field, thus it should be undefined, thus it should not match "". But perhaps it was not undefined but null, and null does for reasons wholly mysterious match "", so that would always try to set author, but if author happens to be set already, it will throw an error, as you can't have more than one. The translators are not allowed to speak to you, the user, so the only thing that can be done is log to the error log -- maybe there's something there. In any case, should you want to replace a field, you could do so by adding , replace: true to the .add call, but the script above will check whether author is present before trying to add the fallback.
@njbart, is \noauthor something I should just add when no author info is present?

I have to cite a certain abbreviation when no author is given. So i fund Biblatex abbrevation for no author/editor/year/etc. in alphabetic style. So I needed a convenient method of getting {\noauthor} in my bib file. So I found your zotero addon.
And by adding the curly brackets I've got what I wanted.
if ( Translator.BetterBibLaTex ) {
 if ( ! this.has.author ) {
  this.add({ name: 'author', bibtex: "{\\noauthor}"});
 }
}

Thanks
Andreas


How to use Views with this Router?

Hello,
I really like this Router so I used it in my project. Now I have one question:
Router::add('/login', function() {
    View::make('Login');
}, ['get','post']);

View is just a function to require a specific php file.
But how can I use the $_POST request in this file?
For example In the Login.php which is used in the /login Route, I want to process the Input made in the form.
How can I achieve this?
Greetings

the router does not provide such functionality but you can extend it by using an external templating engine like blade, refer to this repository for more info blade template

I would recommend pushing your data to your view. I have made a little PHP-only templating lib (maybe similar to your View class) named SimplePHPComponents. Just look at this example code:
Route::add('/user/([0-9]*)/edit', function($id) {
  Component::create('page/edit-user')->assign(['id' => $id, 'some_other_data' => $_POST['some_other_data']])->print();
}, 'get');

Or just look at https://github.com/steampixel/simplePHPPages
In this boilerplate I combined this router with simplePHPComponents

I tried this but it doesn't seems to work properly.
Used this as my Route.
Router::add('/login', function() {
    $user = $_POST['username'];
    View::make('Login', array($user));
}, ['get','post']);

And modified my View func to this:
public static function make($view, array $args = array()) {
           extract($args);
           require_once( 'views/'.$view.'.php' );
}

But on the Login.php file $args[0] doesn't return any value. Also this workaround doesn't seem very secure.

Please debug your route and see whats inside your $_POST
Router::add('/login', function() {
   print_r($_POST);
   exit();
   // $user = $_POST['username'];
   // View::make('Login', array($user));
}, ['get','post']);

Also the extract function needs an associative array! Try using View::make('Login', array('user' => $user)); instead.

This approach is secure as long as you sanitize your POST data properly.

Ok, I figured out the issue. I had a Input class that checks if any POST Data is send, which doesn't work in this system. So is there any way to check if any data is send with the View function so I can modify the Input class?
Thanks in advance for the help!

your route file should remain a route file only.
your input class should be called within your 'view' class or within the function() {}. that way $_POST is already defined and you can now test if $_POST['username'] exist and is valid or not.
Ideally, you should use a constructor before using your view::make() to cover the logic.
Good luck!


CI does not test documentations

Currently CI does not check any documentation error, e.g. syntax error or wrong reference link. It'd be nice to build documentation automatically on every PR.
As an example: Flask has a CI job to test the documentation in the .travis.yml, which refers to the TOXENV defined in its tox.ini.

This has been fixed at least since we moved to Azure Pipelines then GitHub Actions.


az upgrade loops continuously on MacOS

Describe the bug
Command Name
az upgrade
Errors:
Upgrade says it will update to 2.27.1, but keeps looping and never completes:
$ az upgrade
This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
Your current Azure CLI version is 2.27.0. Latest version available is 2.27.1.
Please check the release notes first: https://docs.microsoft.com/cli/azure/release-notes-azure-cli
Do you want to continue? (Y/n): Y
Already up-to-date.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
^C

To Reproduce:
Run an upgrade from MacOS terminal:
az upgrade

Expected Behavior
Environment Summary
macOS-10.15.7-x86_64-i386-64bit
Python 3.8.11
Installer: HOMEBREW

azure-cli 2.27.0 *

Extensions:
account 0.2.1

Brew version:
$ brew --version
Homebrew 3.2.6
Homebrew/homebrew-core (git revision 5ca8f7e4272; last commit 2021-08-11)
Homebrew/homebrew-cask (git revision 6fa2cf3682; last commit 2021-08-11)

Additional Context
Here is some debug output:
$ az upgrade --debug
cli.knack.cli: Command arguments: ['upgrade', '--debug']
cli.knack.cli: __init__ debug log:
Enable color in terminal.
cli.knack.cli: Event: Cli.PreExecute []
cli.knack.cli: Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x110b78700>, <function OutputProducer.on_global_arguments at 0x110be1940>, <function CLIQuery.on_global_arguments at 0x110c26160>]
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableCreate []
cli.azure.cli.core: Modules found from index for 'upgrade': ['azure.cli.command_modules.util']
cli.azure.cli.core: Loading command modules:
cli.azure.cli.core: Name                  Load Time    Groups  Commands
cli.azure.cli.core: util                      0.002         2         4
cli.azure.cli.core: Total (1)                 0.002         2         4
cli.azure.cli.core: These extensions are not installed and will be skipped: ['azext_ai_examples', 'azext_next']
cli.azure.cli.core: Loading extensions:
cli.azure.cli.core: Name                  Load Time    Groups  Commands  Directory
cli.azure.cli.core: Total (0)                 0.000         0         0
cli.azure.cli.core: Loaded 2 groups, 4 commands.
cli.azure.cli.core: Found a match in the command table.
cli.azure.cli.core: Raw command  : upgrade
cli.azure.cli.core: Command table: upgrade
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x1113aaca0>]
cli.azure.cli.core.azlogging: metadata file logging enabled - writing logs to '/Users/me/.azure/commands/2021-08-11.13-14-16.upgrade.90954.log'.
az_command_data_logger: command args: upgrade --debug
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument.<locals>.add_subscription_parameter at 0x1113cc160>, <function register_global_query_examples_argument.<locals>.register_query_examples at 0x111423c10>]
cli.knack.cli: Event: CommandInvoker.OnPostArgumentLoad []
cli.knack.cli: Event: CommandInvoker.OnPostCommandTableCreate [<function register_ids_argument.<locals>.add_ids_arguments at 0x111423ca0>, <function register_cache_arguments.<locals>.add_cache_arguments at 0x111423dc0>]
cli.knack.cli: Event: CommandInvoker.OnCommandTableLoaded []
cli.knack.cli: Event: CommandInvoker.OnPreParseArgs []
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x110be19d0>, <function CLIQuery.handle_query_parameter at 0x110c261f0>, <function register_global_query_examples_argument.<locals>.handle_example_parameter at 0x111423b80>, <function register_ids_argument.<locals>.parse_ids_arguments at 0x111423d30>]
This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
urllib3.connectionpool: Starting new HTTPS connection (1): raw.githubusercontent.com:443
urllib3.connectionpool: https://raw.githubusercontent.com:443 "GET /Azure/azure-cli/master/src/azure-cli/setup.py HTTP/1.1" 200 2296
cli.azure.cli.command_modules.util.custom: Your current Azure CLI version is 2.27.0. Latest version available is 2.27.1.
cli.azure.cli.command_modules.util.custom: Please check the release notes first: https://docs.microsoft.com/cli/azure/release-notes-azure-cli
Do you want to continue? (Y/n): Y
cli.azure.cli.command_modules.util.custom: Update homebrew formulae
Already up-to-date.
cli.azure.cli.command_modules.util.custom: Update azure cli with 'brew upgrade azure-cli'
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
Warning: azure-cli 2.27.0 already installed
WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.
WARNING: This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
WARNING: Your current Azure CLI version is 2.27.0. It will be updated to 2.27.1.
^C

Perhaps a Homebrew issue, but I'm not super familiar with troubleshooting brew, so if anything I can look into please let me know. Thanks

I previously enabled auto upgrade. For now I've disabled it again with the following so I can run az commands without being prompted to upgrade:
az config set auto-upgrade.enable=no

@jiasli for awareness

On a first glance, this is because 2.27.1 is available on GitHub:
https://github.com/Azure/azure-cli/blob/da3ff654f80f749525ee5c321c37dc041f1061d2/src/azure-cli-core/setup.py#L11
but not available on Homebrew yet because the PR has not been merged:

https://github.com/Homebrew/homebrew-core/pull/83088

Then a loop happens:

az upgrade finds from GitHub that there is a new version 2.27.1, but it can only upgrade to 2.27.0
When az upgrade is about to finish, the auto-upgrade kicks in
az upgrade is called by az upgrade: https://github.com/Azure/azure-cli/blob/a12f5762e02d6d41927280557046eb76241194f2/src/azure-cli/azure/cli/main.py#L92  -> An infinite loop ⚠

We have released 2.27.1 and this issue should be fixed. (Still, we need to solve the endless loop issue.)


KeyboardDatePicker renders incorrect date

Environment

Tech
Version

@material-ui/pickers

material-ui

React

Browser

Peer library

Steps to reproduce

Expected behavior
date value is parsed as ISO 8601

Actual behavior
date value is parsed as something else

Live example
https://codesandbox.io/s/blue-pond-1qll6

We are using date-fns as provider to create a date. So please follow their docs.
Actually just pass new Date object


Fixed download and threading errors

fixed the ffmpeg.exe and ffprobe.exe download, where it was using a non existing function
fixed an error where the threads variables were getting removed and they could not be accesed anymore

thanks for your effort, lets merge it.

Thanks for the fixes, completely forgot about this project of mine.


Native segwit account not synchronizing after RBF

Ledger Live Version and Operating System

tested on Ledger Live 1.3.0(20)
Phone version iPhone X ios 12.4.1

Expected behavior
When RBF option is executed the balance of the source account should be affected and the account should sync.
Actual behavior
Sent a Tx from bech32 address and didn’t notice that the app chose a very low fee. Using Electrum (as Ledger Live Desktop/Mobile don’t support the feature) I made fee replacement. The Tx went well. After this event the particular account is not synchronizing anymore in Ledger Live Mobile app, desktop version synchronizes fine (although only after a recent update but I don’t remember the version that corrected the issue, but definitely one of the August 2019 releases). The affected Tx doesn’t diminish the ballance of the source account and the app just keeps reporting synchronization error (only for the aforementioned account, other accounts sync ok).
Steps to reproduce the behavior
Send a low fee Tx from a bech32 account, then replace fee with a higher one with other software (Electrum). Check source account balance.

Version 1.4.0 solves the issue.


flight management c++ project

#3581 and flight management c++ project

Close #3581

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@TusharKesarwani @pranjay-poddar @MohitGupta121 level 2 if possible


Fixes #7396

Proposed changes
In Issue #7396, 404 Error was found. So I fixed the reason from docker/docker.github.io/reference.md

Related issues (optional)

Fixes #7396

Deploy preview for docsdocker ready!
Built with commit 45627b2299e98dc0fad0e69d9b3f02ee92805b58
https://deploy-preview-7461--docsdocker.netlify.com

@moreal The original link works in docs.docker.com: https://docs.docker.com/engine/reference/commandline/cli/

@bermudezmt oh, I see. but in docker.github.io, it doesn't work. I think their hosts are different with each other. I am hard to understard why this structure was designed like this

@moreal the site just grew over time and you are correct, some of the files/images are hosted in different locations. I honestly can't tell you where yet but the priority now is to make sure all links and images work on docs.docker.com.


Hide newly added fields from quick addition mode

Everything until (and including categories) is relevant. The rest below should be hidden from quick addition mode

@raphael0202 related one

Fixed in 8c939d5f9d4f3c34b2594eb490a6ceed39e71a14


Add support for Laravel 7

Based on the code in #73, I've created my own branch with some small fixes. This should be backwards compatible with the marking store config and also support a newer format.
Old:
'marking_store' => [
    'type' => 'single_state',
    'arguments' => ['currentPlace'],
],

New:
'marking_store' => [
    'arguments' => [true, 'currentPlace'],
],

You can use my fork by changing your composer.json and running composer update brexis/laravel-workflow:
"require": {
    "brexis/laravel-workflow": "dev-laravel-7-support"
},
"repositories": [
    {
        "type": "vcs",
        "url": "git@github.com:willemo/laravel-workflow.git"
    }
]

A slight warning for people wanting to update to this version: the subjects for the workflows need to have getters and setters for the marking. So if you have a model that has a state property you use to store the current place of the workflow, you need to add the getState() and setState($state) methods to that model.


Fixes compatibility HMR & Browser Sync with external clients and IE

Polyfills for IE (tested with IE10+):

Promise
EventSource

Fix:
When developing with external clients (192.168.xx.xx:3000), HMR could not replace styles because the URL would be replaced by localhost:3000, so the hot-update.json file returned a 404. Here's a simple workaround, that could certainly be enhanced (related to this issue).
Hope it helps!
PS. Related to this issue https://github.com/roots/sage/issues/1874

You should be able to make use of SAGE_DIST_PATH, as documented here: https://github.com/roots/sage/blob/master/resources/assets/build/config.js#L36-L44
SAGE_DIST_PATH=192.168.xx.xx:3000/app/themes/sage/dist yarn start

Something like that.
I'm closing this for the time being, but feel free to reopen it if you want to try to resubmit a PR that uses the existing solutions we've come up with for this issue (albeit our solutions did not have local development in mind at the time). In the meantime, I'll be looking into this as well.

Ok thanks, I'll try it. Would it be possible to use the .npmrc file to override this kind of configuration? DEVURL would be another example, it's pretty useful when working on multisites, but not really handy to write it every time before the command.

You could edit it in package.json
  "scripts": {
    ...
    "start": "SAGE_DIST_PATH=192.168.xx.xx:3000/app/themes/sage/dist webpack --hide-modules --watch --config resources/assets/build/webpack.config.js",
    ...
  },

But that's less than ideal because the IP could change. But that issue isn't alleviated by hard-coding it in .npmrc or anywhere else.
With the next version of Sage, we'll be supporting config-local.json, which will allow you to override config.json settings (the idea being that these are things each particular dev on your team might want to change depending on their development environment, such as proxy URL, dev URL, etc). In which case you could just use config.enabled.watcher to check if you're in watch mode, and if so, then set SAGE_DIST_PATH to the IP address you specify in config-local.json.
In the meantime, you can do all of this in config.js
If you need further help, please post on https://discourse.roots.io/

Thanks. +1 for local git-ignored file.
For now, anyone interested in storing DEVURL in a git-ignored file could just add this line to .npmrc at the root of your project: DEVURL=http://yoursite.dev and replace this one in webpack.config.watch.js: const target = process.env.npm_config_DEVURL || process.env.DEVURL || config.devUrl;


Add Match Selector

Is your feature request related to a problem? Please describe.
We need to implement the selector (AKA: when multiple match are possible, select in a way that in each run we maximise the total number or quality of matches).
Describe the solution you'd like
Describe alternatives you've considered
Additional context

Closed with #34


Prep for Hacktoberfest

If we can come up with a list of relatively easy features on the roadmap that first-time contributors could tackle successfully, and aren't just busy work, it would be nice to throw them up for Hacktoberfest this year.
Ideally we can get them written up (or just apply a little polish if they are already written) in mid-late September, then we'd be ready to slap on the label at beginning of October.  Free labor and exposure for sywac, useful and interesting work to do for OSS developers (and potentially new fans of sywac afterwards!).

@elliot-nelson Great idea!
Unfortunately, I don't know if any of the current issues (or anything on my original roadmap) would be good candidates for new-comers.
Here's a brief list:

Current issues

Help with documentation (related to #11)
Ability to customize "text wrapping" via style hook (#57)
Support functions (needs an interface) for synchronous config options (#62)
Top-level run handler (#65)
Ability to customize the "end of options" delimiter (#67)
Config option to support auto-conversion of kebab-case flags to camelCase (#68)
Ability to document and style exit codes in help text (#69)
TypeScript typings definition (#70)
Better support for implicit commands - simple commands kicked off via boolean flag (#71

Things from "The Roadmap"

Ability to read arguments from stdin
Ability to parse environment variables as arguments/options
Add --no- negation support to TypeBoolean
Interactive mode (!)

Maybe we could go down this list and assign t-shirt size labels (small, medium, large) to them based on the amount of effort (or familiarity with existing codebase) we think will be required?
Shooting from the hip, the potential candidates that stand out to me are #11, #67, and maybe #68, #69, and #70.
What do you think?

Great summary!
I agree that not everything is a good fit, but I'll make my case for a few:

"Adding --no negation for TypeBoolean".  I think this feature is low-complexity and relatively easy to test, and makes sense to anyone with any CLI experience (no sywac expertise required).  This could probably be a small t-shirt Hacktoberfest ticket.

"Customized extra args delimiter" (#67).  Agree on this one, also low-complexity and relatively easy to test, small t-shirt?

"Document exit codes in help text" (#69).  I'd call this a medium t-shirt because it will probably require a draft PR, some back and forth on exactly how it should be styled (and any new style names if required), and then some polishing up.  But easily doable within October if someone interested came along, even if they were unfamiliar with sywac.

TypeScript (#70).  Yeah this is a reality today for library authors and an open call during Hacktoberfest could make a lot of sense for attracting TS experts.  I think we would want to make some decisions about exactly what we want and write that up -- your usual options are: A. completely convert your library to TS; B. include TS bindings inside your own library and maintain them as you make JS changes; C. host types in DefinitelyTyped aka @types; D. do nothing, in order of dedication.  Depending on whether we're putting a call out for B. or C., and how much of Jose's existing work we can reuse, may affect whether this is a medium or large t-shirt.

Those are the ones that stick out to me!  Some of the others (like documentation) are nice to haves but it's tough to have someone who's never used a library write documentation for it.

I'm closing this feature (although it's still very useful as a reference).
Our "Hacktoberfest offering" for this year is several labeled issues under sywac and sywac-website, and a couple of pinned welcome issues.  I think that's a good starting point to see if there is any interest from the community.


 See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.

Same error here.
Can't request a new certificate

+1

I get this as well whenever I create a new redirection host.  Not sure why it can't delete the file as the process is run by root and the file is owned by root with the necessary permissions

Get the same error over and over again...

+1

I can no longer add any proxy hosts due to this issue.


Failed :  [Add Buster backports apt key.]

I have followed all the steps on the setup part of the README.md
I ran the ansible-playbook main.yml command and it worked, but my Pi was on a high IP address so I changed it to a low IP static which broke the service. Consequently I had to re-flash the SD card and start again.
I installed ansible and made config.yml and inventory.ini files which met my needs.
I run the ansible-playbook main.yml command again and I get a huge error when the [Add Buster backports apt key.] part of the playbook runs. This is the error:
failed: [<IP_ADDRESS>] (item=04EE7237B7D453EC) => {"ansible_loop_var": "item", "changed": false, "cmd": "/usr/bin/apt-key adv --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 04EE7237B7D453EC", "item": "04EE7237B7D453EC", "msg": "Error fetching key 04EE7237B7D453EC from keyserver: hkp://keyserver.ubuntu.com:80", "rc": 2, "stderr": "Warning: apt-key output should not be parsed (stdout is not a terminal)\ngpg: keyserver receive failed: Server indicated a failure\n", "stderr_lines": ["Warning: apt-key output should not be parsed (stdout is not a terminal)", "gpg: keyserver receive failed: Server indicated a failure"], "stdout": "Executing: /tmp/apt-key-gpghome.7buM0sxz8L/gpg.1.sh --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 04EE7237B7D453EC\n", "stdout_lines": ["Executing: /tmp/apt-key-gpghome.7buM0sxz8L/gpg.1.sh --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 04EE7237B7D453EC"]}
failed: [<IP_ADDRESS>] (item=648ACFD622F3D138) => {"ansible_loop_var": "item", "changed": false, "cmd": "/usr/bin/apt-key adv --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 648ACFD622F3D138", "item": "648ACFD622F3D138", "msg": "Error fetching key 648ACFD622F3D138 from keyserver: hkp://keyserver.ubuntu.com:80", "rc": 2, "stderr": "Warning: apt-key output should not be parsed (stdout is not a terminal)\ngpg: keyserver receive failed: Server indicated a failure\n", "stderr_lines": ["Warning: apt-key output should not be parsed (stdout is not a terminal)", "gpg: keyserver receive failed: Server indicated a failure"], "stdout": "Executing: /tmp/apt-key-gpghome.Lu6RQj6RSL/gpg.1.sh --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 648ACFD622F3D138\n", "stdout_lines": ["Executing: /tmp/apt-key-gpghome.Lu6RQj6RSL/gpg.1.sh --no-tty --keyserver hkp://keyserver.ubuntu.com:80 --recv 648ACFD622F3D138"]}

What have I done?
I've check that I all packages are up to date and installed
I've tried rebooting, nothing works
please help

The static IP was the issue, I have fixed the issue by keeping the IP assigned to it when it first boots.
It had a DNS which couldn't find the ubuntu server to make a request


Be resilient to errors during stack parsing

Issues like https://github.com/stacktracejs/stackframe/issues/11 shouldn’t kill the redbox. If the stack calculation throws, we should at least report the message.

Fwiw, I still can't get the examples to run on my machine and I have no idea why, but I honestly haven't tried too hard to find out.
Other than that (meaning pending approval from someone who can actually run the examples), is this what you had in mind @gaearon?

Yep!


Add ResNet-RS to keras.applications

Description
This PR adds ResNet-RS model architecture to keras.applications. refer #15780
Revisiting ResNets: Improved Training and Scaling Strategies
ResNet-RS models are updated versions of ResNet models - Arxiv Link
The models were rewritten using Keras functional API, The model's weights are converted from original repository.
Motiviation
Adding ResNetRS models to keras.applications has been discussed on Tensorflow's github:
#15780
It was mentioned that this family of models would be welcomed in keras.applications, hence this contribution.
Usage / Changes
The models could be used similarly to other models in keras.applications
from keras.applications import resnet_rs
model = resnet_rs.ResNetRS50()

Todos
Right now, weights are hosting on @sebastian-sz GitHub, need to move on keras-team gcs buckets.

@LukeWood

@qlzh727

Thanks for review @fchollet . I have updated code according to review comment, also added Colab link of this PR code evaluation.
https://colab.research.google.com/drive/1XoR18LoPhZ0Y1T3GXUdXvSmYlkJhSCS9?usp=sharing

I've almost got this ready to merge.  Thanks for your patience!

This has been merged in https://github.com/keras-team/keras/commit/a9b4cb6bba4608d44f41f2719ec50356710cadb5 and https://github.com/tensorflow/tensorflow/commit/e9c5ec2787e3dbba0cc13aed554025e4c1c4edf1 -- thanks a lot for the great contribution! 👍

This has been merged in a9b4cb6 and tensorflow/tensorflow@e9c5ec2 -- thanks a lot for the great contribution! +1

@fchollet should i open new PR to update keras-io docs for information about same?

@shkarupa-alex
Disclaimer: I am the author of the Keras port repository.
Good find, I agree there is no mention of momentum in the paper and the value has been simply copied from the config file you linked. I missed that they used moving average decay.
It could be beneficial to replace it with something more standard - e.g. maybe just leave the default batch norm momentum value?
I think you could open a separate issue regarding this problem. I don't think a closed PR will attract the needed attention.

@shkarupa-alex Disclaimer: I am the author of the Keras port repository.
Good find, I agree there is no mention of momentum in the paper and the value has been simply copied from the config file you linked. I missed that they used moving average decay.
It could be beneficial to replace it with something more standard - e.g. maybe just leave the default batch norm momentum value?
I think you could open a separate issue regarding this problem. I don't think a closed PR will attract the needed attention.

agreed, lets file an issue.  maybe we can fix this with the KerasCV.models refactor?

@LukeWood yes this is a minor change in code.
I think Resnet-RS models could be added to keras-cv with this fix. Do we also would like to modify keras.applications implementation?

If it is a minor change I see no harm in also fixing keras.applicatins - as long as it doesn't change the API (but I don't think it does)

Here is a PR https://github.com/keras-team/keras/pull/16726

will ResNet-RS merge into Keras V3?


Fix inline assembly support on CPU.

As title. Refcount pruning pass was failing because InlineAsm node
does not have a 'name' attr.

I assume we don't need to cherry pick this into 0.44?

I've not seen anyone using inline assembler for CPU targets, whilst it's broken in 0.44 (and probably all other releases) that it's only just been discovered possibly means the only users of InlineAsm classes are on the GPU targets which don't have the refcount pass.

CC @njwhite


Parse config value contains "abc$123" error with UseEnv

The Config value "abc$123" should not be regarded as env, it's reasonable only '${xxx}' regarded as env
err = conf.Load(file, &ret, conf.UseEnv())

Yes, you're right. But for now, if we change to ${xxx}, there will be a compatibility problem.
I suggest you to use env tag in config struct instead of UseEnv().


Ignore proc-macro attributes

Some proc-macro generated code is not ignored right now because it is not annotated with automatically_generated.

Related to #108

@W95Psp what's the state on this? I haven't seen this in a while.


core: Add support for all available output parsers in _load_output_parser()

In this PR, we are updating the _load_output_parser() function to dynamically get all available output parsers to be loaded.
I am not 100% comfortable with this solution, because I am accessing a protected property outside the class (_type) in line 81, so feel free to suggest changes. :)

@baskaryan

@baskaryan, @eyurtsev, @hwchase17

@efriis @eyurtsev can you review this PR?

@eyurtsev @baskaryan, @eyurtsev, @hwchase17 ping

this is using the old way of serializing object. there is a new serialization schema, if we want to support output parsers we should do it there, but it may be some work


Dependencies and configuration

Description
Backend environment setup and configuration.  Dependencies listing and installation.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added necessary inline code documentation
[ ] I have added tests that prove my fix is effective and that this feature works
[ ] New and existing unit tests pass locally with my changes

This looks good.


handels invalid country names

Codecov Report

Merging #11 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   92.66%   92.79%   +0.13%
==========================================
  Files           1        1
  Lines         109      111       +2
  Branches        3        3
==========================================
+ Hits          101      103       +2
  Misses          8        8

Flag
Coverage Δ

#backend
92.79% <100.00%> (+0.13%)
:arrow_up:

Impacted Files
Coverage Δ

covid/__init__.py
92.79% <100.00%> (+0.13%)
:arrow_up:


[SPARK-23459][SQL] Improve the error message when unknown column is specified in partition columns

What changes were proposed in this pull request?
This PR avoids to print schema internal information when unknown column is specified in partition columns. This PR prints column names in the schema with more readable format.
The following is an example.
Source code
test("save with an unknown partition column") {
  withTempDir { dir =>
    val path = dir.getCanonicalPath
      Seq(1L -> "a").toDF("i", "j").write
        .format("parquet")
        .partitionBy("unknownColumn")
        .save(path)
  }

Output without this PR
Partition column unknownColumn not found in schema StructType(StructField(i,LongType,false), StructField(j,StringType,true));

Output with this PR
Partition column unknownColumn not found in schema struct<i:bigint,j:string>;

How was this patch tested?
Manually tested

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/992/
Test PASSed.

Test build #87594 has started for PR 20653 at commit 772e672.

Test build #87594 has finished for PR 20653 at commit 772e672.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87594/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87612 has started for PR 20653 at commit b5c8d56.

Test build #87612 has finished for PR 20653 at commit b5c8d56.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87612/
Test FAILed.

retest this please

Test build #87614 has started for PR 20653 at commit b5c8d56.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1006/
Test PASSed.

Test build #87614 has finished for PR 20653 at commit b5c8d56.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87614/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1012/
Test PASSed.

Test build #87622 has started for PR 20653 at commit d6ac338.

Test build #87622 has finished for PR 20653 at commit d6ac338.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87622/
Test PASSed.

LGTM

LGTM
Thanks! Merged to master


⚠ Bofrost.be has degraded performance

In b655149, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1447 ms

Resolved: Bofrost.be performance has improved in 404672d.


V0.1.2

Todo

I newly added abs, sign function and corresponding specs.

Reference

ABS function
SIGN function

@kohei-miyazawa Thank you for create PR and I apologize for my preparing is not enough.
I created develop branch. Could you change this PR to the following?

Change the target branch to develop
Remove the commit changes version up  232f5d5

I will handle the release later.

@yiyenene
Thank you for chacking.
The following two points have been addressed.
・The target branch has been changed to develop.
・Deleted version up commit.
Please check the following.

@yiyenene Thank you for chacking.
I corrected for description. Could you check the following?


Strange issue with TimestampBehavior

UpdatedAt works well after any moficiation in row. But, I can't say the same for row creation.
After new row creation createdAt still 0000-...
public function behaviors()
  {
    return [
        [
            'class' => TimestampBehavior::className(),
            'createdAtAttribute' => 'createdAt',
            'updatedAtAttribute' => 'updatedAt',
            'value' => new Expression('NOW()')
        ],
      ];
  }

Here is database table: http://prntscr.com/79xt5n
And here is model: https://gist.github.com/turalsprofile/85eca5d307074b42a215
What am I doing wrong?

hi,
check datatype of createdAt

Timestamp. Both of datatypes

Check rules method, may be createdAt is not safe attribute.

please paste the CREATE TABLE statement. @progreg it must not be safe or validated as it does not receive user input.

http://prntscr.com/79xt5n

have you overridden beforeSave in your model?

nope.

so what can be issue?

maybe you can share your whole model code if it's not big

Yes of course: https://gist.github.com/turalsprofile/85eca5d307074b42a215

any suggestions?

can u share ur action code?

action is just saving model. nothing more. it doesnt change any of createdAt, updatedAt.

kindly check in ur controller that CV model is reference from common folder?

yes of course

please read carefully. I've already written that, updatedAt works well. problem only with createdAt

public function behaviors()
    {
       return [
            [
                'class' => TimestampBehavior::className(),
                'createdAtAttribute' => 'createdAt',
                'updatedAtAttribute' => 'updatedAt',
                'value' => function() {
                    return new Expression('NOW()');
                },
            ],
        ];
    }

just wrap it to closure

I have same issue at 2.0.4.
On 2.0.3 works well

@akaNightmare not working still

@mucha1306 I don't think we're having same problems

It works for me, I dont think it's a bug. Here is my test code https://gist.github.com/duynguyen0511/af8e859da308cf9699a5

@duynguyen0511 please paste the CREATE TABLE statement.

@duynguyen0511 Ah I just saw that you already pasted. But in this case what might be issue? I even restarted the mysql server

I tried to change createdAt -> created_at and updatedAt -> updated_at. And retried using following code snippet
public function behaviors()
{
    return [
        [
            'class' => TimestampBehavior::className()
        ],
    ];
}

same result. No success!

After Yii update to 2.0.4 Expression('now()') got broken it returns '0000-00-00 00:00:00'.
Rewrote all of these to (new DateTime())->format('c').

@maximal what's the SQL query generated?

Code:
$sql = \Yii::$app->db->createCommand()
	->insert(
		\app\models\Comment::tableName(),
		[
			'id' => 1,
			'userId' => 1,
			'type' => 'repo',
			'text' => 'text',
			'createdAt' => new \yii\db\Expression('now()')
		]
	)
	->sql;
var_dump($sql);

$sql = \Yii::$app->db->createCommand()
	->insert(
		\app\models\Comment::tableName(),
		[
			'id' => 1,
			'userId' => 1,
			'type' => 'repo',
			'text' => 'text',
			'createdAt' => new \yii\db\Expression('now()')
		]
	)
	->rawSql;
var_dump($sql);
die;

Output:
string(106) "INSERT INTO `comments` (`id`, `userId`, `type`, `text`, `createdAt`) VALUES (:qp0, :qp1, :qp2, :qp3, :qp4)"

string(108) "INSERT INTO `comments` (`id`, `userId`, `type`, `text`, `createdAt`) VALUES ('1', '1', 'repo', 'text', :qp4)"

As you can see, \yii\db\Expression was not expanded to raw SQL.

https://github.com/yiisoft/yii2/commit/6e48ed05c71128be5610377ec81e2fa0fa14ba9a is the culprit according to git bisect.

Yes, looks like this. Big mistake.

that commit is in 2.0.5-dev (#8034) @maximal , are you using 2.0.4 or the dev version?

On production I’m using “stable“ branch now, so I have 2.0.4.
Temporarily rewrote timestamps to be (new DateTime)->format('c').
Will wait until 2.0.5 is released.

Already fixed in master.

Yeah, I noticed. Thank you.

This fix does not seems to be in 2.0.6 - why?

It's in 2.0.6. https://github.com/yiisoft/yii2/commit/aa5887fec783ec82de193066299d11cbeed5aae4

May be late but great, Check your table structure and will show CURRENT time etc on update. So the bug is not in code mysql updates the timestamp field itself.
Also in migrations, timestamp() behaves strange without default so always use like:
$this->timestamp()->defaultValue(null),


Window is not defined in popper.js

I got this error when applying ElementUI to Evan You's vue-hackernews-2.0 repository.

webpack:bundle is now VALID.
error during render : /
ReferenceError: window is not defined
at D:\code\vue\bachelor-defense\node_modules\element-ui\lib\utils\popper.js:51:16
at root (D:\code\vue\bachelor-defense\node_modules\element-ui\lib\utils\popper.js:42:26)
at Object. (D:\code\vue\bachelor-defense\node_modules\element-ui\lib\utils\popper.js:47:3)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)

I use the recommended conf but can't figure out why.
{         test: /\.js$/,         loader: 'babel',         exclude: /node_modules/ }
I need explanation.

vue-hackernews-2.0 applied SSR, and window is undefined in a Node environment. See #333 for more information.

My God! @Leopoldthecoder, Thanks for your explanation! Maybe I have to use another UI framework...

Hi @Leopoldthecoder is there any way that Element supports server-side rendering?

Now Element doesn't support SSR, and we have no such plan in short term. Sorry.

No problem @Leopoldthecoder, it was for me to know if it will be compatible with nuxt.js

@Atnux save problem with nuxt.js when use http://element.eleme.io/#/en-US

@Atnux same problem with nuxt.js when i try to work with element-ui

@Atinux Hi, Element now supports SSR and can work with nuxt.js :)

You guys rock @Leopoldthecoder 👏

@Leopoldthecoder great!


Add 500px.com domain

I needed to call it fiveHundredsPx, since we are not allowed to use a number as first character for a function name. Using our JS SDK key, we are able to receive directly an access token, instead of a request token.

Awesome!
Thanks for contributing :-)


Model language selection is missing

Hi! In both Power BI Desktop for cloud and for Report Server the option for model language selection is missing in current versions
(Cloud version: 2.61.5192.601 64-bit; RS version 2.56.5023.1043 64-bit)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d01f4ea6-33ff-97ca-4a4e-8a1beb88f12f
Version Independent ID: e5224487-369d-23be-98cb-ebab58c75ac4
Content: Supported languages and countries/regions for Power BI - Power BI
Content Source: powerbi-docs/supported-languages-countries-regions.md
Service: powerbi
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks @chizhova, assigning to @maggiesMSFT to fix. She is on vacation but will address when she returns.

Hi, @chizhova -- hearing no reply, I'm going to close your comment. Feel free to reopen it later. Thanks!

Hi @maggiesMSFT, Options->Global->Regional Settings  this is missing in Microsoft Power BI Desktop (Optimized for Power BI Report Server), at least tested in last 2 releases, which means May 2019 as well as September 2019

Hi, @pmi777 -- interesting question! I'll check and get back to you.

Hi, @pmi777 -- got an answer for you!

Hi, @maggiesMSFT, first of all thanks for your attention. I think unified way of working in both versions would be more easy and beneficial, at least with common features that regional setting definitely is. Try to work with PBI desktop optimized which is installed in other language (e.g. Finnish) than you can understand where the only reason for that other language is the correct sorting requirement. Having there also Options->Global->Regional Settings we could set different language for the model and that way could avoid installation of localized PBI desktop optimized. Also for MSFT it would make life easier as it would not be needed to build and deploy language specific installers, but only one would be enough.

Hi, @pmi777 -- thanks for elaborating! This is more feedback for the product than for the docs, right? Can you enter this feedback on the Power BI Ideas site, https://ideas.powerbi.com/forums/265200-power-bi?
Thanks and good luck!

Hi, @maggiesMSFT, i consider this as a bug rather than something worth to propose as a brand new idea to have. Anyhow thanks for you attention, however seems a waste of or time.


Fixing typo

batch

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@sebdau : Thanks for your contribution to the Azure documentation! The author, @cynthn, has been notified to review your proposed change.

#sign-off @sebdau thank you for catching that!


Member updates

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and can not fetch: westwing. Can't resolve stock ticker WEW; please manually add a "stock_ticker" key to landscape.yml or set to null
No cached entry, and Synax (member) has issues with logo: synax.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/synax.svg'
No cached entry, and Infoblox (member) has issues with logo: infoblox.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/infoblox.svg'
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
Empty twitter for Dahua Technology (member): https://twitter.com/dahuasecurity
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Westwing (supporter) either has no crunchbase entry or it is invalid

Build failed because of:
No cached entry, and can not fetch: westwing. Can't resolve stock ticker WEW; please manually add a "stock_ticker" key to landscape.yml or set to null
No cached entry, and Synax (member) has issues with logo: synax.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/synax.svg'
No cached entry, and Infoblox (member) has issues with logo: infoblox.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/infoblox.svg'
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
Empty twitter for Dahua Technology (member): https://twitter.com/dahuasecurity
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Westwing (supporter) either has no crunchbase entry or it is invalid

Build failed because of:
No cached entry, and Synax (member) has issues with logo: synax-gmbh.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Infoblox (member) has issues with logo: infoblox.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/infoblox.svg'
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item Infoblox (member) has no image_data
Item Synax (member) has no image_data

Build failed because of:
No cached entry, and Infoblox (member) has issues with logo: infoblox.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/infoblox.svg'
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item Infoblox (member) has no image_data

Build failed because of:
No cached entry, and Infoblox (member) has issues with logo: infoblox.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/infoblox.svg'
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item Infoblox (member) has no image_data

LGTM (finally).  @caniszczyk please merge when you have a chance, thanks!


fix(APPL-220): Fix Newly Submitted Artwork Images Are Not Loaded

This PR resolves APPL-220
Description

Fixes missing Image in MyCollection list view following a submission of artwork.

Before
https://user-images.githubusercontent.com/18648835/207552243-1a3537f2-1100-4294-b81b-665605530c81.mp4
After
https://user-images.githubusercontent.com/18648835/207552326-77bd913f-b4f9-499b-9d9a-7773c9e0ed43.mov
PR Checklist

[x] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[x] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[ ] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Fix Newly Submitted Artwork Images Are Not Loaded - kizito

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

#squashongreen


Support exporting file urls

Can you add an option to automatically delete the copied files after 1 day of existence? or something that prevents the user from having to delete manually. That would be very useful.
thanks for the update @CodeingBoy ☕


Stream Auto Resume

Stream auto pauses when changing tab, but does not auto resume when coming back to original tab.

Yes. Do you know how to fix it? :)

I looked at it for a bit, but have not figured out a fix yet.


MON-3274: sync telemeter config with apiserver_list_watch_request_success_total:rate:sum

I just ran make whitelisted_metrics && make as described in Following https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md
This PR adds apiserver_list_watch_request_success_total:rate:sum to the telemeter configuration.
The metrics was added in https://github.com/openshift/cluster-monitoring-operator/pull/2044
Update: to pass git diff --exit-code I had to run make manifests (this could be reflected in the docs)

This also adds another telemetry metrics added in https://github.com/openshift/cluster-monitoring-operator/pull/2030
cc @rexagod
Just leaving this here for future us.


CNV-23485: Adding iso flow

📝 Description
Adding ISO flow for bootable volume modal
This includes rearranging the source options, adding this ISO checkbox, and labeling the DS once created.
The next pr will include using this kind of DS as a CDROM and adding a 30 GB blank disk.
🎥 Demo

/retest

/retest


Add tests

Currently different parts of autoheal are not tested. (rules_woker, config, files under pkg/ etc.), we should add tests for these.
cc: @jhernand

closing @jhernand ?


[Flaky Tests]: Link Form Submission

The test passes consistently locally, but fails consistently in CI:
1) [chrome] › form_submission_tests.ts:909:1 › test following a link with [data-turbo-method] and [data-turbo=true] set when html[data-turbo=false]

  AssertionError: does not navigate the full page: expected 'Hello' to equal 'Form'

    918 |   await link.click()

    919 |

  > 920 |   assert.equal(await page.textContent("h1"), "Form", "does not navigate the full page")

        |          ^

    921 |   assert.equal(await page.textContent("#hello h2"), "Hello from a frame", "drives the turbo-frame")

    922 | })

    923 |

      at /home/runner/work/turbo/turbo/src/tests/functional/form_submission_tests.ts:920:10

2) [chrome] › form_submission_tests.ts:924:1 › test following a link with [data-turbo-method] and [data-turbo=true] set when Turbo.session.drive = false

  AssertionError: does not navigate the full page: expected 'Hello' to equal 'Form'

    932 |   await link.click()

    933 |

  > 934 |   assert.equal(await page.textContent("h1"), "Form", "does not navigate the full page")

        |          ^

    935 |   assert.equal(await page.textContent("#hello h2"), "Hello from a frame", "drives the turbo-frame")

    936 | })

    937 |

      at /home/runner/work/turbo/turbo/src/tests/functional/form_submission_tests.ts:934:10

Since this passed and reported the summary, I'm closing and including the commit in https://github.com/hotwired/turbo/pull/479 and https://github.com/hotwired/turbo/pull/431.


MsQueue .pop() panics on Windows with "You can't return Response::done() from Machine::create() until new release of slab crate."

As the title says, this function seems to work fine on linux but panics on windows.
Project code for reference:
https://github.com/carbidegames/sapphire-hail/blob/745f4d9725dd519bd473a45676c205e575fe73eb/clockwork/src/clockwork.rs#L70

This is an issue that blocks any web development using my framework on windows.

I'm pretty sure the panic occurs here. Looks like right around this condition and the next will cause the error to be raised by returning a failed result. Crossbeam doesn't use the slab crate or have Response/Machine structs so the error isn't from the Crossbeam crate itself.
If you've tried this with a different queue and the result is different, that would be extremely interesting. Looking at what causes the issue, it appears that rotor to get along with Windows. Does it log the error from line 191 of rotor/src/response.rs?

I haven't had a chance to test this yet but it seems that it indeed is a hyper issue, not a crossbeam issue.


Logout, then continue as guest brings up a blank profile page

Since the logout button is on the profile page, if you logout, and then choose "continue as guest" you're brought to the login page. It says "guest_username" and there are no values. And there's a "logout" button at the bottom, even though you're logged out.
I guess it should just skip past this page and instead show the Location list.

This should do it:
https://github.com/scottwainstock/pbm-ios/commit/c4ab8cebb43ad11fcc5fd7b0ccd2107bda7dd5e7

For the issues where you say something like "this should do it" are you expecting me to verify that all is well (once the update has been pushed to the app) and then close the issue? Or are you keeping them open for another reason?

Keeping it open for verification.

On Nov 27, 2016, at 17:12, RyanTG<EMAIL_ADDRESS>wrote:
For the issues where you say something like "this should do it" are you expecting me to verify that all is well (once the update has been pushed to the app) and then close the issue? Or are you keeping them open for another reason?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Seems good!


fix(collections): fix log errors when trying to remove media from an …

…already empty collection

:tada: This PR is included in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Windows deadlock when copying text in Entry

Issue moved from dotnet/maui#12369

Please respond to @daltzctr.

From @daltzctr on Saturday, December 31, 2022 7:56:30 PM
Description
This issue occurs in Xamarin.Forms & MAUI. I've profiled this application using the Visual Studio profiler.
The highlighted section is where the "deadlock" occurs. It fixes itself after an unknown amount of time, which seems to scale based on the time dragging around the control.

Steps to Reproduce

Create new MAUI application based on default template in VS 2022
Add the following text to MainPage

            <Entry Text="Test text" />

Run application, click into textbox and click and drag rapidly outside the boundaries of the text box.
Observe deadlock

Attached is a video demonstrating the freeze. You can see the time "clicking & dragging" around the control. After the deadlock occurs, I attempt to click on the "Click" button and it does not update until the freeze has ended.
https://user-images.githubusercontent.com/105223895/210154476-98d93c4e-9a63-4f08-8b2e-a313fb91a6a2.mp4
Link to public reproduction project repository
https://github.com/daltzctr/MauiDeadlock
Version with bug
7.0 (current)
Last version that worked well
Unknown/Other
Affected platforms
Windows
Affected platform versions
Windows 11 22621.963
Did you find any workaround?
No. Seems to be a bug in WinRT.
Relevant log output
No response

Issue moved from dotnet/maui#12369

Please respond to @drasticactions.

From @drasticactions on Sunday, January 1, 2023 11:56:28 AM
You wrote that this happens in a non-MAUI app, correct? If this is a bug with WinUI and/or UWP itself, the issue should be filed there. I don't think there's much here that could be done about it.

Issue moved from dotnet/maui#12369

Please respond to @daltzctr.

From @daltzctr on Sunday, January 1, 2023 7:35:10 PM
This does happen in the Windows 11 settings app, but it's a bit less extreme. If you could point me to the relevant repo, I'd be happy to duplicate this issue there!

Issue moved from dotnet/maui#12369

Please respond to @PureWeen.

From @PureWeen on Tuesday, January 3, 2023 7:34:50 PM
@daltzctr Would it be possible to see if you can recreate this inside a WinUI platform app?

Issue moved from dotnet/maui#12369

Please respond to @msftbot[bot].

From @msftbot[bot] on Tuesday, January 3, 2023 7:35:04 PM
Hi @daltzctr. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

Issue moved from dotnet/maui#12369

Please respond to @daltzctr.

From @daltzctr on Wednesday, January 4, 2023 7:45:44 AM
@PureWeen this is reproduced in a blank WinUI platform app. A reproduction sample is available here


input field loses focus on first form input character

redux-form v6.0.0-rc.5 but your examples are working perfect. created a separate app with creact-react-app but still acted the same

I'm having the same issue here as well

@afaayerhan Actually I fixed it by following the fix here:
https://github.com/erikras/redux-form/issues/1557
Not sure if that's what you were doing but hopefully it's the same issue for you!

@jwyuen thanks bro, your reply got me discover the problem. would be closing this issue now. for those wondering what the problem is.
don't do this
import React from 'react';
import { reduxForm, Field } from 'redux-form';

const renderField = (props) => (

    {props.placeholder}

      <input className="form-control" {...props.input} type="text" />
      {props.meta.touched && props.meta.error && {props.meta.error}}

);
const Register = (props) => {
	return (
		<form>
	      <Field
            name="firstName"
            placeholder="First Name"
            component={props => renderField(props)}
          />
          <Field
            name="lastName"
            component={props => renderField(props)}
            type="text"
            placeholder="Last Name"
          />
		</form>
		)
}
export default reduxForm({
	form: 'register',
	pure: true

}) (Register);

instead dod like this
import React from 'react';
import { reduxForm, Field } from 'redux-form';

const renderField = (props) => (

    {props.placeholder}

      <input className="form-control" {...props.input} type="text" />
      {props.meta.touched && props.meta.error && {props.meta.error}}

);
const Register = (props) => {
	return (
		<form>
	      <Field
            name="firstName"
            placeholder="First Name"
            component={renderField)}
          />
          <Field
            name="lastName"
            component={renderField}
            type="text"
            placeholder="Last Name"
          />
		</form>
		)
}


[DNM] OpenFE 1.0 + Alchemiscale 0.5 compat

Developers certificate of origin

[x] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

@jthorton it looks like we'll have to regenerate the source files for tyk2_fec_network and tyk2_result_network fixtures, corresponding to tyk2_small_network.json and tyk2_result_network.json, respectively.
Can you point me to how you generated these files in the first place?

Awesome, thank you so much @jthorton! If you can commit the scripts and the new schema to this PR, I can take it from there I think!

We have a strange error in the CI from gufe when trying to create an atom mapper class.
args = ()
kwargs = {'allow_ring_breaking': True, 'coordinate_tolerance': 0.15, 'preserve_chirality': True, 'use_positions': True}

    def __call__(cls, *args, **kwargs):
>       instance = super().__call__(*args, **kwargs)
E       TypeError: Can't instantiate abstract class PersesAtomMapper with abstract methods _defaults, _from_dict, _to_dict

../../../micromamba/envs/asapdiscovery/lib/python3.10/site-packages/gufe/tokenization.py:66: TypeError

This error does not come up when making a fresh env locally with only openfe and gufe.

The CI error is picking up an issue in openfe see this PR https://github.com/OpenFreeEnergy/openfe/pull/929 for the fix.

Thanks for investigating this @jthorton! Great detective work. Given this is upstream, lets just XFAIL this on our end until we get a fix.

#1187 should fix unrelated errors.

@jthorton I saw you made creating Tasks a submit parameter in 79ce9a5. Thanks for this!
I think it may make sense to go further (in a separate PR) and make setting+actioning Tasks a separate CLI command. I'll make an issue for this.


Make OnDateChangedListener interface public

Making this interface public will make the DatePickerController and the public accessible Views more flexible. Now DatePickerController is a public interface, but can't be implemented outside the project (due to the fact that it contains the protected DatePickerDialog.ONDateChangedListener).
Proposition: The OnDateChangedListener could even be a seperate public interface instead of an interface inside DatePickerDialog

Making OnDateChangedListener protected was a deliberate choice. (see 10281117e9e9cfbd56d01ffae3eb5f231fafc37d)
I was getting a lot of issues from people who were trying to use this as the callback for the picker.
The fact that DatePickerController is public is also an accident of history. It really is just an implementation detail. I will probably make this protected in the next semver major release as well.
It should still be possible to change the internals by subclassing or forking the library.
Take a look through the closed issues to get a feel for why I want to minimize the amount of rope I give people.

Thank you for the fast reply!
Ok, I understand why you made 'OnDateChangedListener' protected. Maybe you could consider making the Views protected then as well (because now they are public and take 'DatePickerController' as a parameter, which makes it a bit confusing). Anyway not a big issue :)
I'll continue using the forked library. In case you are interested why I'm using the Views: In the project I'm working on, we're using both your DatePickerDialog and an input View (that's not in a dialog) for entering the date. We want the input view to have the same look and feel as the Dialog. That's why the Views being public was very convenient.

Good idea, I should probably make those views protected at some point.
I think what you want to do should be possible by subclassing the pickers rather than maintaining a full blown fork. It should make keeping in sync with upstream easier.
Anyway I'm happy my work is useful for you 😀


Implement message set wire format

Message set wire format is old and deprecated format used instead of extensions
in ancient protos.
This adds a new GeneratedMessage subclass $_MessageSet to override binary
serialization and deserialization methods for message sets. Message set
messages now extend $_MessageSet instead of GeneratedMessage.
The new class is prefixed as $_ to make the addition backwards compatible.

One concern here is binary sizes and runtime performance when the new class is not used.
For binary sizes I checked a large internal dart2js app that currently does not use message sets. The binary size increased 0.007% so that should be OK. I don't know yet why the size increased though. Because the difference is so small I suspect it may just be some non-determinism in compilation.
For runtime performance I checked the benchmarks in the repo. The binaries before and after this PR are identical, so it seems like at least for small apps that don't use the feature there will be no difference in generated code and runtime performance.


Support HSLA color swatches without using % for S and L

Describe the bug
If using HSL or HSLA for colour, the swatch does not display the colour - it just displays as white. It does however work perfectly in relation to Figma: the colour is shown in the Figma colour styles fine.
To Reproduce
Steps to reproduce the behavior:

Create a color token using HSL

Expected behavior
The colour should be shown in the swatch.
Screenshots or Screencasts

JSON (optional)
{
"color": {
"hslColor": {
"value": "hsla(230, 84, 55, 1)",
"type": "color"
}
}
}
Amazing plugin by the way - thanks so much!

The reason for this is that the token in the UI is giving it's raw value and letting the browser decide if it can display that. That means, CSS. In CSS, the S and L values need a % sign at the end for them to work.
If you write your hsla values like this: hsla(230, 84%, 55%, 1), however we should do something to streamline these and what Figma accepts.

Ah - thanks so much - user error sorry...! All is working great now - thanks again for such an amazing plugin!

While fixing this maybe it's also possible to put the hsla value in if the color picker is set to hsla

Suggesting we archive this one as its stale and covered elsewhere @six7


[WIP] Additional implementation of the single step invite and approve feature

Resolves #3432
Description
This is the work that I did to address issue #3432. I saw that the original contributor who was working on it came back and finished, so I'm submitting this just in case it can be useful in getting their solution to a production state. Please feel free to discard if the changes are unneeded!

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?
I added a test into partner_system_spec.rb to login as org admin, check the option box, and then check if the invite and approve partner button is there/works.

Hey @AlonzoBlackshear A belated thanks for your work on this!  We did end up going with the original contributor's work, but/and neglected to close this down earlier.


Mark certain bindings as experimental

From @yochay on December 15, 2016 0:8
Binding like Twilio and SandGrid needs to be marked as experimental.
Copied from original issue: projectkudu/AzureFunctionsPortal#847

From @mathewc on December 15, 2016 0:33
Why? These bindings are solid - what's the problem with them?

From @fabiocav on January 4, 2017 20:1
What bindings do we expect to break? Why would that be impacted by the extensibility work?

From @paulbatum on January 4, 2017 22:13
Once we support 3rd party binding extensibility, these bindings will not ship "in the box". You'll need to add them to your function app. In this world, the promises we make about core bindings vs 3rd party bindings are very different e.g. 3rd party bindings are as-is, we can't guarantee that they always work, you might need to accept a license agreement to use them, etc. There is a difference in customer expectations. I think @yochay wants to communicate that now, ahead of time, by moving these to the experimental category (please correct me if I'm wrong).

This is because we want to make breaking changes to the bindings once we create binding extensibility.

From @yochay on January 4, 2017 22:52
Marking these experimental allows us to handle future updates and not ship them 'in the box'. We also want the partners (eco-system) to start picking such bindings on their own. Furthermore, what happens if tomorrow either of  these providers release a security fix. Are we on the hook to take the updates and then when and how...

From @paulbatum on January 12, 2017 18:18
This issue was moved to Azure/azure-webjobs-sdk-templates#391

Duplicate