Limit the set characters allowed in measurement key names

Description of the issue
We allow measurement keys to contain any character. We had to break this a while back to disallow colons, due to path serialization. We may break this again to disallow braces so we can parse sympy expressions out of them. We'll probably also need to disallow brackets whenever we do the "allow multiple measurements" feature. And other things will probably come up later.
Rather than continuing to do these one at a time, should we preemptively make a breaking change that limits measurement keys to a reasonable set of characters like alphanumeric+underscore?

I'd prefer to treat measurement keys as opaque tokens. What kind of sympy expressions do you imaging having in them?

The other way around -- we want to be able to parse expressions containing measurement key names (delimited by braces) into sympy expressions. i.e. in op.with_classical_control('{A} > {B}'), op would only be executed if measurement A is greater than measurement B. We can work around the fact that the names themselves could have braces by using an escape sequence, but still it seems like we'd want to standardize on a more common set of characters for these names.

How about using actual sympy expressions?
A, B = sympy.Symbol(keyA), sympy.Symbol(keyB)
op.with_classical_control(A > B)

I'm not aware of any restrictions on characters that can be used in the names of sympy symbols, so this should work even if the strings for keyA and keyB have weird characters.

Yeah, we can work around it. The question really is should we have to? Is there a reason we want to allow any characters in the measurement key names, or might it be prudent to limit them?
I think of them as variable names, so it seems odd to support arbitrary characters. But maybe if users think of them as spreadsheet headings then it makes more sense. Anyway @95-martin-orion suggested I bring it up for discussion before 1.0. I'm less partial one way or the other since we've found some workarounds. Though one thing is I do think we should at least trim (or reject) surrounding spaces.

I mostly want to restrict measurement keys to [a-zA-Z0-9_-] because every time we want to do formatting or parsing of strings containing keys we're forced to put in all these extra safeguards to ensure arbitrary keys won't get broken. It's a strain on development that I doubt provides much benefit to users.

In what situations do we need to parse strings that contain keys? I will say that internally we use keys with characters outside the list you propose, such as brackets, commas, colons, etc. So restricting this would be a breaking change for us internally.

In what situations do we need to parse strings that contain keys? I will say that internally we use keys with characters outside the list you propose, such as brackets, commas, colons, etc. So restricting this would be a breaking change for us internally.

#4740 is the current PR of interest in this area. While it's not "parsing strings containing keys", the entire process of introducing MeasurementKey also fought against this issue; measurements in repeated circuits eventually received : as a special character, but other suggestions such as keyed CircuitOperations have also desired reserved characters.

To note, the current default key for measure(*cirq.LineQubit.range(3)) is '0,1,2'. So commas might be hard to remove.


feat: organization as context

Fix: https://github.com/casdoor/casdoor/issues/1781
When organization selected as context - it filter table by organization in any section and also create objects in it by default.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dplynsky seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

We are really looking forward to this feature will become part of Casdoor.
Thx.

@ISulimanov can you help test this PR, including all pages (apps, orgs, providers, etc.) and all roles (global admin, org admin, normal user)?

@ISulimanov can you help test this PR, including all pages (apps, orgs, providers, etc.) and all roles (global admin, org admin, normal user)?

Sure, will do.

@dplynskiy
I think the widget should show the current option text instead of an icon, it would be more informative.

Something like this: https://ant.design/components/select

Also this widget should be hidden to org admin and normal users, because they don't need to modify it.

@ISulimanov can you help test this PR, including all pages (apps, orgs, providers, etc.) and all roles (global admin, org admin, normal user)?

@dplynskiy
There is only one issue that i've found so far -
The organization menu, does't refresh when you create/remove/rename organization.

Except this -  works as expected.

current implementation works wrong (it's don't consider server pagination and filters only data on front), I will make new implementation with all fixes and review remarks.

I think now it works as it should and looks like this

@ISulimanov can you help test this PR, including all pages (apps, orgs, providers, etc.) and all roles (global admin, org admin, normal user)?

@dplynskiy
There is only one issue that i've found so far -
The organization menu, does't refresh when you create/remove/rename organization.

Except this - works as expected.

Now organization menu, does refresh when you create/rename organization, but still does not update when remove.

@ISulimanov can you help test this PR, including all pages (apps, orgs, providers, etc.) and all roles (global admin, org admin, normal user)?

@dplynskiy
There is only one issue that i've found so far -
The organization menu, does't refresh when you create/remove/rename organization.

Except this - works as expected.

Now organization menu, does refresh when you create/rename organization, but still does not update when remove.

ty for testing, fixed.

@hsluoyz I've done testing.

[ ] checked all pages and scenarios add / remove / change organization.
[ ] checked global admin / admin / normal user roles


Update configure-end-user-spam-notifications-in-eop.md

Tweaking to highlight that ESNs contain bulk, spam, and phishing messages.

@MSFTTracyP - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


Update Kusto to 0.5.4 for GA

Kusto extension 0.5.4 was built here:
https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=102717&view=results

@JustinMDotNet There's already a 0.5.4 uploaded from yesterday. If you need one that's different than that you need to bump up the version and use that instead. If that one is fine that's ok - I'm just making sure.

@JustinMDotNet There's already a 0.5.4 uploaded from yesterday. If you need one that's different than that you need to bump up the version and use that instead. If that one is fine that's ok - I'm just making sure.

That shouldn't be an issue. That may have happened because I originally generated the 0.5.4 build manually.

@JustinMDotNet 0.5.4 is there because I uploaded it, you create a PR to update the insider feed yesterday.

@JustinMDotNet just curious, what is going GA?

@JustinMDotNet gallery updated.


docs Capitalize Ecosystem Files Name and Titles

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Language button does not work

Language does not change when clicking this menu

@pillowfication Thank you for reporting. This issue has been fixed.


Add command to regenerate vote embed

Channels can get crowded with discussion. Would be nice if there was a command to delete the old embed and post a new one so it's visible below the chatter.

Bot auto-pins the vote message. Is that not enough?

I'm now wondering if it's possible to use Threads to solve this issue. Have the bot create a thread where people can only react to the vote embed, then delete the thread after the vote completes, posting the results in the main channel. I'm curious if discord-py has support for them.


[Enhancement] colocate join need consider column equivalent conduction

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

For sql select * from t1 join t3 on t1.id = t3.id join t2 on t3.id = t2.id,   wheter colocate join is available need consider column equivalent conduction t3.id = t1.id = t2.id.
What's more, for sql select * from t1 join t3 on t1.id = t3.age and t1.id = t3.id join t2 on t2.id = t3.age and t2.age = t3.age the order of equivalence predicates(shuffle columns are derived from them) is meaningless, hence it is correct to use a set to save these shuffle pairs. According to the distribution column information of the left and right children, we can build distribution pairs. We can use colocate join is judged by whether all the distribution pairs are exist in the equivalent predicates set.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run starrocks_fe_unittest

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 14 / 14 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/ChildOutputPropertyGuarantor.java
14
14
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test


Added extra check if pipeline has no jobs

Fixes #86

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   64.67%   64.67%
=======================================
  Files          22       22
  Lines        1911     1911
=======================================
  Hits         1236     1236
  Misses        539      539
  Partials      136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add96f7...e8d0030. Read the comment docs.


Possible socket starvation due to non-static HttpClient

I have a long running .NET core 2.2 application running in a container in AWS. It received a lot of requests and indexes stuff in elasticsearch via the Client.Index(...) method.
The container has rising memory usage and in the end, restarts because heartbeats from external services are not received.
After debugging this for days, I narrowed it down to the nest client, specifically the usage of HttpClient in HttpConnection.cs.
In HttpConnection.cs, the method GetClient(...) maintains a dictionary of HttpCliens which is reused. This is not as per Microsoft guidelines and is causing socket starvation. A few reads on the topic:

https://docs.microsoft.com/en-us/aspnet/web-api/overview/advanced/calling-a-web-api-from-a-net-client#create-and-initialize-httpclient
https://aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/

So I forked this repo, and did a simple test where I'm reusing a static HttpClient across all calls. This fixed the problem and the service is now completely stable.
What are your thoughts on this?

Firstly, thanks for opening @ThomasVestergaard.
Could you provide some more information about the .NET core application:

Runtime version
OS platform host - you mention container, so sounds like a Linux distro. Would you also be able to provide details about the container environment, version, etc. too?

The dictionary of HTTP clients should be caching HttpClient instances for the lifetime of the HttpConnection, which should be a singleton tied to a singleton ConnectionSettings and ElasticClient
https://github.com/elastic/elasticsearch-net/blob/01047d93faf31e2f31cca811999a8337ca368a93/src/Elasticsearch.Net/Connection/HttpConnection.cs#L130-L151
The key for the dictionary is determined from:
https://github.com/elastic/elasticsearch-net/blob/01047d93faf31e2f31cca811999a8337ca368a93/src/Elasticsearch.Net/Connection/HttpConnection.cs#L274-L286
A few initial thoughts come to mind:

Are you varying any of the components of RequestData with each request that would constitute multiple HttpClient instances to be created?
Are you using custom TCP Keep Alive values on ConnectionSettings.EnableTcpKeepAlive(...)?
Are you configuring a higher connection limit using ConnectionSettings.ConnectionLimit(...)? The default connection limit is set to the processor count when the underlying HttpClientHandler is System.Net.Http.CurlHandler, and 80 for all others. We have experienced System.Net.Http.CurlHandler not reusing TCP connections previously (#2784) so set a very conservative connection limit.

Any additional detail that you can provide will be super useful. If you have a repro that clearly replicates what you're seeing, that would be even more awesome!

Hi @russcam
Thanks for the rapid reply on this.
I will try to make a repo where I replicate the issue where all of your questions are answered. Will get back to that later.
Meanwhile, it seems a HttpClientFactory has been introduced in .net core 2.1 which is addressing this exact issue.
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests
I will try to do a test with the HttpClientFactory as well.

Thank you! We have full intentions of moving over to HttpClientFactory where possible 😃

I have the same issue it seems using ElasticClient within durable functions in Azure. I am getting SocketExceptions after a few successful requests. @ThomasVestergaard, please let me know the solution if you find one.

@russcam Sorry for the very late reply on this.
Today i experienced this with the fix from earlier:

So maybe my issue is not tied to elasticsearch after all.
I think it might be best to close this issue until I get to the bottom of this. Right now I can't rule out anything.

@ThomasVestergaard Did you send an email reply saying to close this for now?

@russcam Sorry for the very late reply. Yes I did - It was a comment on this thread which I deleted again. I have been debugging this on and off for a while and I'm getting inconsistent results, so no conclusion yet. I think it's best to close this for now. I'll reopen if I get something concrete to look at.

Thanks @ThomasVestergaard. Feel free to reopen if you get to something concrete 👍

Just a thought: could this be connected to https://github.com/dotnet/corefx/pull/32793? Socket starvation and a memory leak could perhaps be related. More information: https://github.com/dotnet/corefx/issues/37044#issuecomment-500660152 and https://github.com/dotnet/corefx/issues/31262 .


advection problem

I tried to formulate a diffusion-advection problem
-\Delta u + a\cdot u = f

(math rendered with Purple Pi) in skfem:
import meshzoo
from skfem import BilinearForm, LinearForm, MeshTri, InteriorBasis, ElementTriP1
from skfem.helpers import dot, grad

@BilinearForm
def laplace(u, v, _):
    return dot(grad(u), grad(v)) + dot([1.0, 1.0], u) * v

@LinearForm
def rhs(v, _):
    return 1.0 * v

points, cells = meshzoo.disk(6, 100)
m = MeshTri(points.T.copy(), cells.T.copy())
basis = InteriorBasis(m, ElementTriP1())
A = laplace.assemble(basis)
b = rhs.assemble(basis)
A, b = enforce(A, b, D=m.boundary_nodes())

This results in the cryptic error
ValueError: operands could not be broadcast together with remapped shapes [original->remapped]: (2,)->(2) (60000,3)->(3,60000)

Any hint on what's going wrong?

I think dot([1., 1.], u) causes it. I'm quite sure dot-helper has no special case for such constant vectors. I'll try to consider how it could work.

One question though. The test function u is scalar, right? So what do you mean by a dot u?

Above I meant "trial function u".
Trying to recover from wisdom teeth removal :0).

One question though. The test function u is scalar, right? So what do you mean by a dot u?

It should be
dot([1,1], grad(u))

and this works indeed. This one's on me, thanks for the quick reply!

See also ex 25 Forced convection. This is just pure Galerkin. Longer term, I'm looking to investigate more specialized discretizations : method of characteristics #600, streamwise upwind Petrov Galerkin, discontinuous Galerkin, ...


Error when compiling custom ops(CPU or GPU)

Hello,
When compiling the custom ops CPU as below:
g++ -std=c++14 -shared -o ${OP_NAME}.so ${OP_NAME}.cc ${OP_NAME}_kernel.cc \
  ${OP_NAME}_kernel.cu.o ${TF_CFLAGS[@]} -fPIC -lcudart ${TF_LFLAGS[@]}

I got the error with tensorflow::OkStatus():
deeplab2/tensorflow_ops/kernels/merge_semantic_and_instance_maps_op.cc:45:26: error: ‘OkStatus’ is not a member of ‘tensorflow’
       return tensorflow::OkStatus();
                          ^~~~~~~~
deeplab2/tensorflow_ops/kernels/merge_semantic_and_instance_maps_op.cc:45:26: note: suggested alternative: ‘Status’
       return tensorflow::OkStatus();
                          ^~~~~~~~
                          Status

And the ops GPU seems ok with just warnings.
My environment:
python3.7
tensorflow2.6.0
Then I found that tensorflow2.10.0 has the function tensorflow::OkStatus(), so I tried it on tensorflow2.10.0. The compiling for CPU seems ok, but compiling for GPU got lots of errors.
Btw, I install the tensorflow in a conda env.
Do you have any good suggestions?

Hi @xtXu
I also encounter this issue, do you have any solution ?

I change it based on the hint
return tensorflow::Status();

And everything works.

I change it based on the hint

return tensorflow::Status();

And everything works.

Thanks for answering！
I have tried this. The compiling problem is solved, but the test demo fails. Maybe there is sth else wrong with me.
Thanks again.


Adding more math functions

Hey,
Thank you for your work on this project. Are there any plans for adding more math functions (exp(t), sqrt, …)? If there are, would you be open for PRs regarding them? I'm interested in using this for a project of mine as a scripting language and would love to contribute.
Cheers

After looking a bit more at the code etc. I would also contribute more general QoL functions like list and hasmap

Hi, sorry for not seeing this, I've got exams at the moment.
I'm definitely open for PRs adding more functions.
I should note however you can add functions yourself when initialising lithia so more specialised functions should be implemented there rather than in the standard environment.
That said, lithia is currently missing some basic maths/lisp functions that do really need to be in the standard environment.


Internet Explorer issue with compatibility

Greetings,
I've been testing if my application works equally well on all browsers, and I've noticed the following issue on Internet Explorer 11. Google Chrome and Mozilla Firefox work extremely well and have no compatibility issues that I've noticed. Furthermore, I've checked on two different machines, and both had same issue.
The issue can be replicated by going to tabs demo page on IE 11, where tabs component is not rendered:

And that is likely related to the errors that are shown in console:

I know, IE is generally bad, but there might actually be someone that wants to use it.
Thanks!

Wow. That's bad. IE 11 is bad but is a Vue Material target. I will take a look at this. Thank you for reporting that!

@Sarpedion can you try the demo page with the polyfill from here?

The problem is with the Object.values functions. I will replace it with another method. :)

well it's allready a polyfill. maybe looking for an alternative rather then implementing your self is a safe bet.

@vuchl I must be honest, I do not know how to use polyfill. I've just included it as a script on index.html, and I haven't noticed any improvement. Thanks for the advice anyways, I am going to read docs a bit on how to implement it. :)

@Sarpedion that should be enough I believe.


Make the min width of the electron application window

On Windows 11 with a recommended display scale of 125% and a display resolution of 1920x1080, the client opens with a size of 1265x975


From #484 build(deps): bump google/osv-scanner-action from 1.7.4 to 1.8.2 (#484)

Bumps
google/osv-scanner-action from 1.7.4 to 1.8.2.

Release notes
Sourced from google/osv-scanner-action's releases.

v1.8.2
What's Changed

Now uses OSV-Scanner v1.8.2, see https://github.com/google/osv-scanner/blob/main/CHANGELOG.md for full changelog.
Call analysis is now done by default for golang.

Commits

7ac94f9 Merge pull request #32 from google/update-to-v1.8.2
da0991f Update unified workflow example to point to v1.8.2 reusable workflows
f1f90c4 Update reusable workflows to point to v1.8.2 actions f8af522 Update actions to use v1.8.2 osv-scanner image 4847de9 Merge pull request #31 from renovate-bot/renovate/workflows
b7d4e6e Update actions/upload-artifact action to v4.3.4 dfa8609 Merge pull request #26 from renovate-bot/renovate/workflows
7e2f071 Update workflows
3c399db Merge pull request #29 from google/update-to-v1.8.1
3ea235a Update unified workflow example to point to v1.8.1 reusable workflows
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot is not authorized to build images; I am double-checking it here instead.


Move Dev instance behind HTTPS

Dependent on getting a cloud-dev environment. Should be behind HTTPS.

Closing as too general.


Clojars

Would it be possible/advisable to get this library a little easier to use by getting it onto Clojars?

Possible, I haven't needed it myself so haven't gotten around to it.
For now you can use lein-git-down plugin to use from leiningen projects.

You don't need a project.clj if you use lein-git-down plugin in leiningen.
I have used xtdb-inspector (that depends on ripley) from a leiningen project.
You could try something like this:
(defproject foo ...
  :dependencies [[ripley "commit sha here"]]
  :git-down {ripley {:coordinates tatut/ripley}}
  :plugins [[reifyhealth/lein-git-down "0.4.0"]])

Ah, I read lein-git-deps instead of lein-git-down! My bad

Could not find artifact ripley:ripley:jar:bca327a in central (https://repo1.maven.org/maven2/) Could not find artifact ripley:ripley:jar:bca327a in clojars (https://repo.clojars.org/)
(Most likely I'm just dumb and can't figure out how to get github to tell me the full sha)


Missing declared license

Type: Missing
Summary:
Missing declared license
Details:
Missing license
Resolution:
BSD-3-Clause: https://github.com/avoidwork/filesize.js/blob/2.0.4/LICENSE
Affected definitions:

filesize 2.0.4

Duplicate - already Declared BSD-3


Configuration of PKTIO_READ_BUFFER_SIZE

Hi, I am using this cellular interface lib, but I faced an issue of below.
The log message showed No empty space from comm if to handle incoming data, reset all parameter for next incoming data.

After I changed PKTIO_READ_BUFFER_SIZE of definition value to 4096, it was solved.
https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface/blob/aff376d03a4483d7ecb41df6da8401a6ed7e6a38/source/include/private/cellular_common_internal.h#L51

Question

Is the size of PKTIO_READ_BUFFER_SIZE TCP window size?

It has comment of  This should be larger than TCP packet size., but I think it is window size of TCP. Is my understanding correct?

Request

Is it possible to add (#ifndef PKTIO_READ_BUFFER_SIZE)  to be possible the configuration by the config.h file?

@KeitaKashima
Thank you for reporting this issue.
You're correct in your understanding. The comment should describe the maximum AT command response size, which is typically the TCP socket receive command response packet size. This should be configurable according to the modem specification. We will create a PR to expose this configuration.

@KeitaKashima
We've created a PR to address this issue #173. It would be great if you can also help to test this PR.

@chinglee-iot
Thank you for fixing this portion.
I could redefine the PKTIO_READ_BUFFER_SIZE in my config.h.
And it is working fine!
＜cellular_config.h＞

The pketioReadBuf value is set correctly as I set 4096+1 .

Thank you for your verification. This issue will be closed. Feel free to reopen this issue or create another one if you have further question.


HDD SDA and SDB sensor no longer available since version 3.4.0

Checklist

[X] I have updated to the latest available Proxmox VE Custom Integration version, see the latest version here.

Describe the issue you are experiencing
since version 3.4.0 the Disk sensors: /dev/sda and /dev/sdb are all "unavailable". If I put back version 3.3.0, they are new ok
In which version of Home Assistant Core do you have the problem?
core - 2024.1.3
What version of Proxmox VE Custom Integration has the issue?
Custom Integration version 3.4.0
What version of Proxmox VE do you have the problem?
Proxmox VE 8.1.4
Diagnostics information
No response
Additional information
No response

Please attach the integration diagnostic file.

hello,
the diagnostic file
config_entry-proxmoxve-a3640033057355bf60f315f8169a4fc1.json.txt

Please do the following steps to generate a debug log file:

Enable debugging for integration
Reload the integration configuration entry.
Disable debugging and download the generated file

Send it here so you can get a clue about the problem.

home-assistant_proxmoxve_2024-01-20T16-13-48.653Z.log

Please download the main version of the integration and test if the issue is fixed.
If using HACS:

Click Redownload

Select the main version and click Download.

👍

not sure if this is connected, but
having below error on 2024.1.3-4-5 with integration v3.4 as well as with "main" version
Logger: custom_components.proxmoxve
Source: helpers/update_coordinator.py:332
Integration: Proxmox VE (documentation, issues)
First occurred: 00:36:13 (1 occurrences)
Last logged: 00:36:13
Error fetching proxmox_coordinator_disk_pmox01_/dev/sdb data:

not sure if this is connected, but
having below error on 2024.1.3-4-5 with integration v3.4 as well as with "main" version
Logger: custom_components.proxmoxve Source: helpers/update_coordinator.py:332 Integration: Proxmox VE (documentation, issues) First occurred: 00:36:13 (1 occurrences) Last logged: 00:36:13
Error fetching proxmox_coordinator_disk_pmox01_/dev/sdb data:

@to4ko, I need the diagnostic files and debug logs to evaluate.
Please open a new issue and attach the files.


Load and continue training NER model

I am training a BiGRU_CRF_Model model with BERT with  1million data points and saving it.
### Load bert embeddings
bert_embed = BERTEmbedding(bert_location, task=kashgari.LABELING, sequence_length=bert_sequence_len)

### Define model
model = BiGRU_CRF_Model(bert_embed)
tf_board_callback = keras.callbacks.TensorBoard(log_dir='./logs', update_freq=1000)
eval_callback = EvalCallBack(kash_model=model, valid_x=valid_x, valid_y=valid_y, step=steps)

### Fit model
model.fit(train_x, train_y, valid_x, valid_y, batch_size=batch_size, callbacks=[eval_callback, tf_board_callback])
model.save("./BiGRU_CRF_BERT.model")

Then I am loading the model again to train it on some more data as shown below -
from kashgari.utils import load_model
model = load_model('./BiGRU_CRF_BERT.model')
model.fit(train_x, train_y, valid_x, valid_y, batch_size=batch_size, callbacks=[eval_callback, tf_board_callback])

There is no issue in model load and testing.  But when I do model.fit() it gives me following error.
Traceback (most recent call last):
  File "BiLSTM_CRF_BERT.py", line 55, in <module>
    model.fit(train_x, train_y, valid_x, valid_y, epochs=epochs, batch_size=batch_size, callbacks=[eval_callback])
  File "/root/anaconda3/lib/python3.7/site-packages/kashgari/tasks/base_model.py", line 293, in fit
    **fit_kwargs)
  File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py", line 1433, in fit_generator
    steps_name='steps_per_epoch')
  File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/training_generator.py", line 264, in model_iteration
    batch_outs = batch_function(*batch_data)
  File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py", line 1142, in train_on_batch
    self._assert_compile_was_called()
  File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py", line 2934, in _assert_compile_was_called
    raise RuntimeError('You must compile your model before '
RuntimeError: You must compile your model before training/testing. Use `model.compile(optimizer, loss)`.

How can I get this info about optimizer and loss from saved model ??
Environment

OS : Ubuntu 16.04
Python Version: Conda 3.7.3

Added code for model saving/training as well

Just call model.compile_model() after loading the model.
from kashgari.utils import load_model
model = load_model('./BiGRU_CRF_BERT.model')
model.compile_model()

Now I am getting following error
Traceback (most recent call last):
  File "BiLSTM_CRF_BERT.py", line 51, in <module>
    model.compile_model()
  File "/root/anaconda3/lib/python3.7/site-packages/kashgari/tasks/labeling/models.py", line 224, in compile_model
    kwargs['loss'] = self.layer_crf.loss
AttributeError: 'BiGRU_CRF_Model' object has no attribute 'layer_crf'

layer_crf

It seems we have ignored some issue related to the CRF layer. Will fix ASAP.

Possibly!
I tried few more things in between
To get output_dim so that I can pass it to CRF()
print("output_dim = ", len(model.pre_processor.label2idx))

Tried manually passing loss and metrics
layer_crf = CRF(output_dim=3, name='layer_crf')
model.compile_model(loss=layer_crf.loss, metrics=[layer_crf.viterbi_accuracy])

But compile step throws error.
Let us know about the updates on this issue.
Thanks for reverting back fast.

Should this issue be marked as bug ??

Yep, this is a bug need to fix.

@BrikerMan Is there any update. Let us know.

This will fix in 0.5.4 version in several days. @allhelllooz


Remove json2mq

In the same vein as #88, the json2mq package should be removable in this project.

released in v0.5.0


A question about use the library

as the example in depository:
/////////////////////////////////////////////////////////////////////////////////////////////
std::vector splinePoints{
QVector2D( 0, 0),
QVector2D( 5, 0),
QVector2D( 8, 3),
QVector2D( 6, 1),
};
UniformCRSpline mySpline(splinePoints);
QVector2D interpolatedPosition = mySpline.getPosition(0.5f);
/////////////////////////////////////////////////////////////////////////////////////////////
I test it, and get the result, the interpolatedPosition is a point between second point "QVector2D( 5, 0)" and third point "QVector2D( 8, 3)", why?
In my mind, the result should be a point between first point "QVector2D( 0, 0)" and second point "QVector2D( 5, 0)", Am I wrong?
Hope for your reply, thank you.

@Izcchl, did you ever figure this out? I'm seeing the same on my end. It doesn't look like this library has been maintained in some time, but it's looking like this could be an error caused by this refactor? I'm just starting to poke around in the code-base, so this may be a red herring, but it really doesn't look like this segmentIndex should be getting incremented by 1.

thank you very very much.


Unable to resolve facebook/sapp-action

Hello,
I am reviewing python SAST tools for GitHub.
This action no longer seems to work in it's current version.
Please note that this tool is however still shown/advertised to people when tney go to GitHub "Code security and analysis" > "Code scanning" > "other tools" > "Explore workflows".
Running the proposed workflow results in:

pysa
Unable to resolve action. Repository not found: facebook/sapp-action

It seems that the action in question has moved to an archive repository.

Hi,
I wouldn't be surprised if the action didn't work, indeed. Unfortunately, maintaining this is lower priority compared to our other work.
Do you have another link to logs showing failures of the action? I tried the link in your comment but I get a 404, I guess the repository is either private or deleted.


[WIP]Permissions and User Invites

Purpose:  add user invitation functionality to django-admin
 To do

[x] Add base code for functionality, including views and admin.py
[ ] Add templates for emails
[ ] Basic code clean up - including merging updates from user_login branch

Create users/set permissions from django-admin:

Select + send email invitations:

Email:

Then:

Then redirect:

Notes:
User created inactive and is activated after reseting their password

@cwisecarver  Please review this; thank you!

@cwisecarver Please review this; thank you!

There aren't any migrations for common_auth. I ran makemigrations and migrated common_auth and everything worked.

Right now, I'm getting KeyError at /admin/auth/login/ u'app.min.js' on login.html around {% render_bundle 'app.min' %} I'm trying to figure out why it's erring but my webpack-fu is not that strong.

I changed {% render_bundle 'app.min' %} to {% render_bundle 'admin-base-page' %} in both login.html and base.html and it started working.

I'm done @zkraime. Back to you. Let me know if you have questions about anything.

Remembered this morning that django-extensions is in your installed apps but not in the requirements file.

@cwisecarver Thank you very much for the review,
everything should be addressed.
Let's maybe chat briefly Friday afternoon for a generate update

@zkraime You don't have any migrations for common_auth. Or at least you haven't committed any. I fixed this in order to test on the first pass but forgot to put a note in here. If you do have migrations on your local I would suggest blowing them all away and creating one from scratch just to make it simpler.

@zkraime Added a couple of more comments some things I missed on the first pass. Let me know if you have questions.


Error uninstalling extension (using menus inside VS IDE)

Although it could not be related to extension itself, as the problem reported by VS is "Could not find file 'C:\USERS<username>\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\16.0_5ABB3F2E\EXTENSIONS\LICENSE.md'", it prevents the extension from being uninstalled...

Does it happens with other versions of VS? Please, feedback!

Workaround: command line uninstall:
VSIXInstaller.exe /uninstall:VSConanPackage.4d0379e2-2698-4e66-89de-6ead71165e9f

(find VSIXInstaller.exe at "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE")

yeah, it happens for me as well, and I have to delete lines manually
the problem it installs for all versions (2015, 2017, 2019), but if I uninstall it from the single place (e.g. 2015), it's still visible in 2017 and 2019. once I try to uninstall from 2017 as well, the issue appears.

Closed via https://github.com/conan-io/conan-vs-extension/pull/82


[FRONTEND] using closure to create jit launcher

Hi,
I'm adding some features to triton.runtime.jit.JITFunction_make_launcher and found it is hard to debug it:

The inlined Python code is hard to inspect in my editor.
My debugger fails to step into these inlined codes.

In response, I've introduced some code to solve these issues. My modifications include:
1. Refactoring the launcher's inline Python code, ensuring it only relies on the "self" object.
2. Add a utility method that generates a temporary file to create a launcher when debugging kernel in main module
Using a closure to hold the launcher's body
Because this features might be good to others, I have initiated this Pull Request.
Tests are yet to be added; if this submission might be accepted, I will add it later.
Since this change is a refactor, no new test was added.

I've added a new commit, which uses closure to wrap the body of the launcher.
Because the inlined Python code was not checked by pre-commit before, moving them into closure introduced some pre-commit issues. To make the code diff more compact, I haven't solved this pre-commit issue yet.

seems like some tests are failing

seems like some tests are failing

ok, I thought  it was an easy one, the tutorial code runs fine for me.
I will try to run a full test locally and fix these.

Adding the import triton  back in the inlined code should fix the issue.
I've squashed all commit and rebased code to the master.


Xiaomi Human Body Movement Sensor

Added motion detector module.
Added a handler for the lumi motion sensor. This device always return value:true and won't update to reflect whether motion was detected. This issue was discussed in Issue #70.
Currently there are delays for motion detection (same as in HA), not sure how to solve it yet.

Is this something that is ready for merge or not as you closed and reopened the PR multiply times 😅

not ready yet, I found a bug and I thought I fixed it and then back and forth, haha 😅

ok 👍

Thanks for the update! That already looks much more cleaner.
BTW, the device also has the motion-detected event, and I guess that would be the most correct way to go. Unfortunately I did not manage to get that to work, do you maybe have any info about the events and how to get them to work?
I guess that would be the perfect way to make it work...

Thanks for the update! That already looks much more cleaner.
BTW, the device also has the motion-detected event, and I guess that would be the most correct way to go. Unfortunately I did not manage to get that to work, do you maybe have any info about the events and how to get them to work? I guess that would be the perfect way to make it work...

Sorry, I also have no clue how events work. But I am guessing they managed to make it work in HA, so I will try to explore that a bit more when I have time this weekend :satisfied:

I guess this is how events work in HA. A push server would be needed to get them to work:
https://github.com/rytilahti/python-miio/tree/master/miio/push_server

Hi, i have added the motion sensor module in the recent update, but i skipped the device implementation as that kind of does not satisfy me😅
I will try to keep investigate in the direction of events so that we can properly handle that. I tried with the push server above but it seems that only works for the old miio device and not for devices using the miot protocol.
I saw in some documentations that there is a miot sdk from xiaomi, i guess if we could get our hands on that then maybe that would be helpful.

Fair enough! I have been busy recently, I will revisit this PR whenever I have free time!


Fix docs/search.json.

only loop through html_pages
skip pages without a title
stop double escaping the title
remove date since we don't use it

/CC @cvrebert @mdo

Ths basically fixes

search for th; it returned the homepage's title double escaped
search results included all pages with/without a title like robots.txt and the redirected ones

Perhaps we should {{ page.title | replace:'"','\\"' }} for safety's sake? (It's a pity that Liquid doesn't have a JSON-string-escape filter.)

We don't have such case but I see your point.
How about using escape_once? It should do what we want and not escape already escaped characters.

Doesn't escape_once do HTML escaping, not JSON escaping?

Yes. I can't make a test case to trigger an invalid JSON. Can you share one?

https://docs.shopify.com/themes/liquid-documentation/filters/additional-filters#json

https://github.com/jekyll/jekyll/pull/1651

So we can use
"title" : {{ page.title | jsonify }},

for title and it should do what you want.

:+1:

Updated.


Added tolerance file to compare.py

This adds an option to read in a JSON file to provide per field tolerance values.

Makes sense

Should we add an example json file?

Maybe in the wiki?

There is no wiki for the moment

Example tolerance file:
tolerance_file.txt

It's not .json :-D

GitHub doesn't accept .json files :cry:

@phmarti fair enough


Doc Feedback: Depreacated Answer for adding authentication headers to messages going out of the api gateway to the backend

Location : https://apim.docs.wso2.com/en/latest/reference/faq/#how-can-i-add-authentication-headers-to-messages-going-out-of-the-api-gateway-to-the-backend
For version 3.1.0, we need to configure deployment.toml file like
[apim.oauth_config]
enable_outbound_auth_header = true

Please change the docs

Fixed in

https://github.com/wso2/docs-apim/pull/1462
master

https://github.com/wso2/docs-apim/pull/1464
3.1.0

https://github.com/wso2/docs-apim/pull/1465
3.0.0


Impl inp src for trbid

Supercedes #926 and https://github.com/AloeareV/zingolib/pull/44

For next steps, I think we need to port this integration test to a darkside test.   I am going to focus on learning about the darkside test framework now.

Is this superceded?

Is this superceded?

by #939
another version is coming up


Removed unnecessary condition and update docs.

Removed unnecessary if condition in doUnmount. Function already return if hooks is false.
Updated documentation. Renamed lifecycle hooks to match new v2 hook names.

🤘

Released in v2.2.2 😎


fix: Installer command line, Anchor to use channelUri

The anchor on the page is all lower case, in certain browsers the Anchoring seems to be case-sensitive.

Looks good. Thanks @Styxxy


Update copyright + removed FlexView

Codecov Report

Merging #6 into master will decrease coverage by 89.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage     100%   10.73%   -89.27%
===========================================
  Files           3        3
  Lines         177      177
===========================================
- Hits          177       19      -158
- Misses          0      158      +158

Impacted Files
Coverage Δ

FlexLayoutTests/FlexLayoutTests.swift
0% <ø> (-100%)
:arrow_down:

FlexLayoutTests/PaddingSpec.swift
0% <0%> (-100%)
:arrow_down:

FlexLayoutTests/MarginSpec.swift
21.83% <0%> (-78.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e32f9f...a0dbe0e. Read the comment docs.


feat(client): esm

Replaces https://github.com/prisma/prisma/pull/19184
Also reduces the edge client size by 20%.

@millsp what is the status of this PR? It's what one ends up finding if one follows the Prisma ESM situation, but it's missing details. Is it still ongoing or no?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

When will this finally be merged? This is going on for over 3 years now...

Any news about the task?

strangely enough that they are not even looking at this PR, especially you @millsp


IndexError: too many indices for array

When I try to train with my own dataset I get this error, does anyone have any idea what the problem might be?

https://github.com/YunYang1994/tensorflow-yolov3/issues/175

it happens when there is no annotation for image
double-check annotation file

is there any image file name with no annotation
is there any image file name with annotation but no space between file name and annotations

annotation == box coordinates

Thank you! I actually found some errors but now they are all fixed and I am getting a new error:

Progress bar states that there is only one batch in your dataset
what is the number of images in your dataset?
this error occurs in the following situations
1.if there is an error in reading annotations
2.annotation file path error

I'm using a few images just to see if I can make the training work, the entire dataset will only be used later. As for the paths and notes, I reviewed all and there is nothing wrong, all exist and are in the right place.

I had got this error due to this mistake "xmin,ymin,xmax,ymax class_id".Correct way to write is "xmin,ymin,xmax,ymax,class_id". Comma was missing before 'class_id'


Flutterbum Chat: No way to submit

On the Flutterbum Dashboard (http://www.flutterbum.com/dashboard), the InterChat seems to be populated by some messages, but when typing and hitting enter, does not submit the message. Additionally there is no "Send" button or other way to submit.

Added submit button, and verified enter/return key submit.


M2 VCF -> Oncotator -> MAF

@kcibul commented on Tue May 19 2015
Currently, there are some disconnects between how Oncotator handles VCFs.  These could be configuration problems or required new functionality.  However, the goal is to be able to create a pipeline (which will have to go into FH in a separate ticket) that takes as input an M2-VCF and outputs a MAF with the following characteristics:

M2 VCFs are single tumor-normal pair -> the MAF should have 1 row for each variant (the normal should not have it's own row)
The real test is to make sure the methods downstream of Oncotator (OxoG, MutSig) can run on these MAFs.

At a minimum, the following fields need to make it out:
AF (format) -> tumor_f
0 -> init_t_lod (we can forgo this and see what explodes if anything downstream)
TLOD -> t_lod_fstar
AD for tumor alt -> t_alt_count
AD for tumor ref -> t_ref_count
filter -> judgement
new OxoG related (see #991)
i_t_ALT_F1R2
i_t_ALT_F2R1
i_t_REF_F1R2
i_t_REF_F2R1

@kcibul commented on Wed Jul 01 2015
on the final step after OxoG (inferring ONPs from Oncotator)

@vdauwera commented on Mon Nov 14 2016
This belongs to GATK4 now.

Oncotator will be rewritten in GATK4.


Should we add intersect method to UnionType?

I found a multiple cases where i do
 const a = v.union(v.literal("started"));
 const b = v.union(v.literal("completed"));

 const schema = v.union(...a.options, ...b.options);

So, can we add intersect (or, maybe with better name), to UnionType, like we did it for ObjectType before (.extend)?

Sorry, misused term. I didn't know you could use it that way. That's great!


[Bug]: Is not updated when you move the order of the widgets

Product
Theta Studio
Bug
if I change the order of two texts it is done at the moment but if I reload the page they return to the initial position
Flutter Environment
No response
Device Information
macOs Ventura 13.4.1
Steps to reproduce

insert two texts in a column
change the order

Expected Behaviour
texts remain in the new order
Actual Behaviour
texts change order but as soon as you reload the page they return to the initial order
Logs
No response
Additional Context
No response
Possible Solution
No response
Screenshots
Uploading Registrazione schermo 2023-07-07 alle 11.55.19.mov…
Code of Conduct

[X] I agree to follow the Code of Conduct for this project.

fix-https://github.com/buildwiththeta/theta_studio/pull/135


[MLIR] Improve MLIR symbols

Currently, the mlir kernel symbols indicate whether a dot or a convolution. However, it would be good to see the dimensions and fusions in perf traces.
closes : https://github.com/ROCmSoftwarePlatform/llvm-project-private/issues/878

However, it would be good to see the dimensions and fusions in perf traces.

We already show the sizes in the perf report.

@manupak @pfultz2 Would y'all be open to narrowing the scope of the PR some so that, for example, a MLIR kernel that does a dot + add + relu becomes mlir_dot_add_relu by analogy to how pointwise modules work? This'll be helpful for, when I'm looking at the output of MIGraphX runs, knowing what operations got fused into which MLIR kernel.

Is this still needed   @manupak  ?

I thought I closed this... apologies.


How to use when missing files

Hi~Due to the missing file 'mimic-cxr-2.0.0-jpeg-txt.csv' , I intend to use the extracted HAIM embeddings you've posted on [https://physionet.org/content/haim-multimodal/1.0.1/] . When I use 'Sample_Multimodal_Patient_Files' in '2_Generate Embeddings from Pickle Files.ipynb', it reports an error : ModuleNotFoundError: No module named 'src' . have already downloaded all the files on this website, and I want to know how to use them in the repo.

In 3_Use Embedding for Prediction.ipynb , fname occurs in the second cell without defining or importing packages. So when I run this cell, it reports an error : NameError: name 'fname' is not defined. I wonder what fname means here.

If you look at the files updated in the Git, you will find there is no dependency on a "src" folder any longer.
Also fname is the name of the single embedding files .

Hi,
I also could not load your .pkl files nad I faced the error: ModuleNotFoundError: No module named 'src'. It seems that inside the pickle files there are some paths related to 'src' and it causes this problem.
For example when I opened one of the pickle files, it has a content like this:
'���������src.MIMIC_IV_HAIM_API��Patient_ICU���)��}�(�'
@xunmzii
Could you handle and open the pickle files at the end?
@lrsoenksen
Or can you generate the pickle files again with your updated code and project structure?
Thanks

Hi @AliRasekh , you have to download the Pickle files from our repo in Physionet, and then position them in the right folder to be loaded

@lrsoenksen
You mean the Sample_Multimodal_Patient_Files Folder in this repo: https://www.physionet.org/content/haim-multimodal/1.0.1/ ?

Yes, and there it is described how to load them and get the embeddings from them.

I have downloaded the same folder Sample_Multimodal_Patient_Files from this repo: https://www.physionet.org/content/haim-multimodal/1.0.1/
And when I want to load for example this file: 00000004.pkl
I get the mentioned error:
ModuleNotFoundError: No module named 'src'
And I am using the same method in your code and repo: load_patient_object
I have tried both of the code versions(the one in your git repo and the jupyter notebook in the Physionet). But they do not work and I see this error.

If you just put the pickle file in a repo and try to open it with your this method, you will get this error:

def load_patient_object(filepath):
    # Inputs:
    #   filepath -> Pickle file path to save object to
    #
    # Outputs:
    #   obj -> Loaded timebound ICU patient stay object

    # Overwrites any existing file.
    with open(filepath, 'rb') as input:
        return pickle.load(input)

And as you mentioned in the project there is not src folder or directory. But the error exists.

I ignore why this is happening, but probably you can fix it by putting a copy of the API (/MIMIC_IV_HAIM_API.py) into a new folder you create in your project called "src", so that you also have the API in the folder where the pickle is complaining src/MIMIC_IV_HAIM_API.py. That should not happen at the pickle file level but that maybe a quick fix.


Interface is broken on mobile.

This is going to require some major redesign work I think, since the hypothesis columns are set at a fixed width of 200px, and probably need to be responsive for it to work well on mobile.
There are also issues with the sliders which I think will be more manageable.

Fixed by https://github.com/adelelopez/bayes/pull/19
The width is still an issue, but the interface works reasonably well.


iOS - notificationReceivedBackground event triggered when app is in the foreground

Not entirely sure why this is happening but at the moment my app if the app is in the foreground and I send a push notification via VOIP the following three events are triggered
notificationReceivedForeground
notificationReceivedBackground
notificationOpened
If the app is in the foreground, I would have expected for the Foreground event to be the only event fired..
Can anyone help explain to me why?

+1

Created a PR to fix this. Works locally on my machine 320

Have tried on mine and it works like a charm. I am wondering when those PRs will be picked up from someone with merge rights?

@artald I guess this should have been included on the 1.4.0, no?

@rodrigofeijao doesn't seem to have been included.


[feat] support for customise inject order of appDelegateMethods

Description

support for customise inject order of appDelegateMethods

Breaking Changes

PRs should not introduce breaking changes to existing functionality
if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)

0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
0.[x+1].0 Remove deprecated functionality

I have tested my changes on:
ReNative project directly:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

New project:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

Existing Project created with previous version of renative:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

Codecov Report

Merging #751 (85803d1) into develop (9a1e40f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #751   +/-   ##
========================================
  Coverage    19.88%   19.88%
========================================
  Files           85       85
  Lines         5883     5883
  Branches      1332     1332
========================================
  Hits          1170     1170
  Misses        3515     3515
  Partials      1198     1198

Flag
Coverage Δ

rnvunittests
19.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1e40f...85803d1. Read the comment docs.


Error "Couldn't Read NPC_22"

So I just downloaded Terrafirma, and it's not finding Terraria through auto-detecting the directory.  And I thought I was setting it right to steam/steamapps/common/terraria but now I'm getting that error for every map I try to open.  And it goes away if I turn off textures. I'm running v3.0.19 of Terrafirma and v<IP_ADDRESS> of Terraria

Ok I got it working.  I had to set the file path to "/Steam/steamapps/common/Terraria/Content/Images"  Then it was finally able to load everything.


Merge with Size Limit

Let’s merge best parts from Size Limit and bundlesize!
Since bundlesize is better name, I move all Size Limit code to this project.
I tried to copy code style, but if I lost something, let’s fix it after merge :D.
@siddharthkp please, do not delay with answer. It requires a lot of energy to decide to merge projects. I had dramatically weekend, because I created Size Limit before bundlesize. But my mistake was to not promote it in the next day.
@Furizaa sorry, my PR could have conflicts with yours. I saw that yours is not ready yet, so I just copy tests from Size Limit.

Why I add webpack?

A lot of projects has no one build file. For example, PostCSS. We publish a lot of small files.
Many projects has own npm dependencies. Of course, they load this dependencies by require(). And we should count them as part of bundle too. In my opinion, dependencies with unexpected size are the main problem of libraries size.
Webpack inserts a lot of unexpected polyfills. And because library users will add libraries by webpack to own bundle, we should test it. For example, one wrong process usage could increase bundle size in few KB.

A lot of projects use Rollup. Do they need webpack?
With webpack we test not size of library bundle. We test how this library will increase app bundle, when user will add library to application.
I think this is better test, since it is main question, that users ask. And since checking just bundle size will not find many problems (like huge library dependencies or wrong process usage).
So it is OK to put Rollup bundle to webpack, since all library users will do the same.
Why you copy code and not improve existed bundlesize code
I really thought to just improve bundlesize code. But I found few very big problems:

No Node.js 4 support. A lot of projects runs Node.js 4 on Travis CI (PostCSS, for example). Node.js 4 still supported. So it is important, in my opinion, to support it too.
bundlesize uses sync method, which are bad for performance.

What features do this PR add to bundlesize

Webpack bundles files and UglifyJS minimize them. It is important because many projects (PostCSSfor example) has no bundle file in repo.
bundlesize FILE to see bundle size. It is important when you have no bundle file in repo. So you need to get size before write limit to package.json.
bundlesize will run only in first job on CI (if project is tested in difference Node.js versions, bundlesize will run only on first Node.js version). Gzip is expensive call. So we need to be respectful for common resources such as feee CI services. This is why it will be respectful to run bundlesize only on first CI job.

The PR https://github.com/siddharthkp/bundlesize/pull/20 is basically ready. It should work without breaking changes. The only thing missing are a few tests that can be added at a later date. I just waited to get a general feeling from @siddharthkp if I should continue with this path - or if the approach goes into the wrong direction before I could invest more time.
That said - I will not be able to update my PR after this has been merged and it had to be closed. Our approaches conflict deeply. But I also would be OK with that as it was a shot into the dark anyway. Just a little saddened because of the lost Sunday ;)

@Furizaa I understand your feelings about Sunday. I lost whole previous weekend because late promotion ;). But you did really great job.
I can try to backport your tests here if @siddharthkp will agree with merge plan. Anyway we need your great tests to check all GitHub build features.

@ai Sorry, but I don't think it makes sense to merge the 2 projects.
As you pointed out, they solve 2 different problems.
bundlesize solves for library sizes and hence is not opinionated on how you build and minify your library. This is intentional.
size-limit on the other hand focuses on application bundles, hence using webpack to bundle makes more sense.
I commend your effort here, but I do not want to change the premise of the tool itself.

I had dramatically weekend, because I created Size Limit before bundlesize. But my mistake was to not promote it in the next day.

I'm really sorry, I did not intend to steal your idea. If there's something I can do to help (while keeping the core idea of bundlesize the same), please let me know!

bundlesize solves for library sizes and hence is not opinionated on how you build and minify your library. This is intentional.
size-limit on the other hand focuses on application bundles, hence using webpack to bundle makes more sense.

Nope :D. Size Limit is focused on libraries. It is not focused on application bundles.
Size Limit use webpack, because webpack users will use webpack to add library to their projects.
So if dist/mylib.min.js is 100 KB, when user will add mylib to his application, it application size will not increase by 100 KB. mylib could use process in wrong way, so application will be increase by 110 KB because of this library.
Or mylib could have dependencies for 1 MB. And we need to calculate it too.

Oh, I completely missed your point. Now, I get it.
Doesn't the size of the application bundle depend on the other dependencies present in the application well? (minification + gzip depends on all of the code)
Related: What would you include for a library like styled-components or react-redux which has a peer dependency on react

How I assumed bundlesize would be used is:

Library authors use it for their dist version.

Application maintainers use it for their webpack/rollup/browserify outputs.

Related: What would you include for a library like styled-components or react-redux which has a peer dependency on react

Good question about peerDependencies. Maybe we should remove peer dependencies from bundle. I could try to update code. Great idea, I missed it.

Doesn't the size of the application bundle depend on the other dependencies present in the application well? (minification + gzip depends on all of the code)

Yeap, of course application bundle will not increase to exactly same number. So if bundlesize will show 10KB, application bundle could increase to 9KB, because of gzip tricks.
So I agree that this method is not 100% accurate. But my point, that using webpack will have better (not ideal, but better) result, that not using it.
Do I understand correctly that you share with me idea, that bundlesize should protect libraries to become very big? In my experience on Logux Client I found 2 most popular mistakes:

Unexpected bug dependency in library.
Wrong using of process, so webpack will add huge polyfill when I will add library to my app.

So using more accurate bundle size calculation will not be ideal, but it will be better and will prevent libraries from really bad mistakes.

Do I understand this correctly that webpack is used to pack the bundle on which the size is calculated? Our project I'm working on 9-to-5 is already bundled with webpack and the build takes almost 10 minutes. Using a webpack buid again just to determine the size would double that time.
This was the hook in this project. I can just point it to the bundles that are already there.

Library authors use it for their dist version.

This exactly what I assumed, when create Size Limit :D.
The only difference is that we can try to prevent more mistakes for same users. Library author could accidentally add 1MB dependency in small PR.
But “Application maintainers” is good thought. Yeap, they didn’t need extra webpack. Maybe we could add --no-pack option to them?

Also very important feature of using webpack is Webpack Bundle Analyzer. So you will be able to understand why your library has this size. It helps me a lot in Logux Client development (Size Limit was just a snippet for Logux Client).

This was the hook in this project. I can just point it to the bundles that are already there.

I completely agree with this. I think we should stick with this approach. bundlesize should be agnostic to their build mechanism

Library authors that want to go the extra mile, will test out a sample application with their library. @rauchg suggested doing the same for nextjs

I do see your point @ai, these are useful additional features but I think it's slightly outside the scope of bundlesize. bundlesize solves a small problem well, I would want to keep it that way. Sorry!

I get what you mean. But I believe that even most libraries will provide one or more minified umd packages (e.g. react.min.js) that are the single source of truth regarding bundle size - the bytes this libraries deliver to the userland end the end.

Do I understand this correctly that webpack is used to pack the bundle on which the size is calculated? Our project I'm working on 9-to-5 is already bundled with webpack and the build takes almost 10 minutes. Using a webpack buid again just to determine the size would double that time.

@Furizaa yeap, good case. What do you think about --no-webpack option for this case?
I agree that it is not good to increase compexity. But webpack is really useful for library authors. For example, without webpack I just can’t use this project in PostCSS. There is a lot of libraries without single bundle.
Also without webpack bundlesize will ignore many bad mistakes from library authors. Like wrong process usage or unexpected huge dependency.

@Furizaa

I get what you mean. But I believe that even most libraries will provide one or more minified umd packages (e.g. react.min.js) that are the single source of truth regarding bundle size - the bytes this libraries deliver to the userland end the end.

There is not such single bundle in PostCSS. Also without webpack library authors will not be able to see Webpack Bundle Analyzer.

There is not such single bundle in PostCSS

I see how bundlesize completely fails in the case of tools (works for libraries/applications). However, my suggested solution would be to keep the webpack build inside postcss and test that with bundlesize, instead of expecting bundlesize to build it.

Also without webpack library authors will not be able to see Webpack Bundle Analyzer.

Not in the scope of bundlesize.

outside the scope of bundlesize

And what do you suggest for small library authors? Only big libraries has bundles inside repo.

@siddharthkp

my suggested solution would be to keep the webpack build inside postcss and test that with bundlesize, instead of expecting bundlesize to build it.

It will be hard to have bundle script in every project. Especially, if it is many small projects.
Webpack config often is bigger than library itself :D.

Not in the scope of bundlesize.

Why Bundle Analyzer is not a scope? Does scope of bundlesize is to control libraries from become bigger. In this case you need not only warning, but also reasons why library become bigger.
Profiling is a key for optimization ;).

In this case you need not only warning, but also reasons why library become bigger.

This is an interesting take, but I'm not sure if I like the solution. Let me think about this problem a little more. I'll create an issue for this.

It will be hard to have bundle script in every project. Especially, if it is many small projects.

Here's how I see it: Right now bundlesize is lazer focused on solving one problem, I'm afraid of adding more features that only help a subset of users/use cases.
According to me, it makes more sense to create another package which is like a setup step for bundlesize that is useful for these users.

According to me, it makes more sense to create another package which is like a setup step for bundlesize that is useful for these users.

Haha, it is not how open source works.Everyone ignores Size Limit in Twitter :(.

@ai Sorry, I don't know how I can help 😢

This is an interesting take, but I'm not sure if I like the solution. Let me think about this problem a little more. I'll create an issue for this.

OK, I will wait for answer

Raised https://github.com/siddharthkp/bundlesize/issues/27, Closing this pull request.
If I am unable to come up with anything better, will use your approach 👍


Update tags on master repository

Reoccurring issue:  tags on master are not up-to-date
Last tag on master is set to v7.2.0-preview.1 that causes the local builds of up-to-date PowerShell repository to show wrong build number:

Steps to reproduce
git fetch --all --tags
git describe

Expected behavior
v7.2.0-preview.2

Actual behavior
v7.2.0-preview.1-144-g3f95fc491

/cc @rjmholt

Yeah this is because the release isn't quite finished yet

@rjmholt It seems that I jumped the gun, should I stop reporting tagging issues in the future?

@kborowinski Current workflow is - MSFT team creates a release branch internally, prepares new release, after the release they merge the release branch to master one. If after the merge you see any issues (tags, docs, links and so on) please report.

So I think git fetch --tags would solve the problem, but I've now merged the PR above so git fetch might also solve it now. I'm slightly concerned though since I omitted a bugfix commit that the release used (rather than add a reversion commit) and that might be an issue for this

Could you update the tags on master again? The v7.2.0-preview.5 is going to be released soon but the tag on master is still set to v7.2.0-preview.3 which causes my daily builds to end with following string:


New package: Taped v0.1.0

Registering package: Taped
Repository: https://github.com/withbayes/Taped.jl
Created by: @willtebbutt
Version: v0.1.0
Commit: e1f2ee1e505137730113c1c472d9b9530d440f39
Reviewed by: @willtebbutt
Reference: https://github.com/withbayes/Taped.jl/commit/e1f2ee1e505137730113c1c472d9b9530d440f39#commitcomment-140190687

[noblock]
Yay!

Time for Untaped.jl! 😄
[noblock]

This can be closed in favour of https://github.com/JuliaRegistries/General/pull/103582
I'm not entirely sure how to do this though

I appreciate wanting to rename from "Taped.jl" if it's no longer a purely tape-based AD, but I'm not sure Phi is doable. I do like the Untaped.jl suggestion! Or maybe you can come up with something else slightly longer than Phi. It doesn't necessarily have to be "descriptive", but there should be some kind of clever connection to AD, and just Phi could be absolutely anything.


HIGHEST RATING IS BEING SHOWED AS HIGHEST RANK

In the website it is showing highest rating as highest rank.Though this is a very small issue I would like to make changes as this could be confusing for others. As I am a beginner in the open source field I want to start from contributions from this.Can you please allow me to do the required changes?

What's the issue here?


Provider org.apache.cxf.jaxws.spi.ProviderImpl not found

Hi! Help, please with my question. I have project with plugin:
apply plugin: 'io.mateo.cxf-codegen'
with such dependencies for plugin:
dependencies {
    implementation 'javax.jws:javax.jws-api:1.1'
    cxfCodegen 'jakarta.xml.ws:jakarta.xml.ws-api:2.3.3'
    cxfCodegen 'jakarta.annotation:jakarta.annotation-api:1.3.5'
    cxfCodegen 'ch.qos.logback:logback-classic:1.2.10'
}

and project dependencies:
implementation group: 'javax.xml.ws', name: 'jaxws-api', version: '2.3.1'
implementation group: 'com.sun.xml.bind', name: 'jaxb-impl', version: '2.3.3'
implementation group: 'com.sun.xml.bind', name: 'jaxb-xjc', version: '2.3.3'
implementation group: 'jakarta.xml.bind', name: 'jakarta.xml.bind-api', version: '2.3.3'
implementation group: 'org.glassfish.jaxb', name: 'jaxb-runtime', version: '2.3.3'
implementation group: 'com.sun.xml.ws', name: 'jaxws-ri', version: '2.3.3'
implementation 'com.sun.xml.ws:jaxws-rt:3.0.0'
implementation 'jakarta.xml.ws:jakarta.xml.ws-api:2.3.3'
implementation "jakarta.annotation:jakarta.annotation-api:1.3.5"
implementation 'javax.jws:javax.jws-api:1.1'
implementation 'com.sun.xml.messaging.saaj:saaj-impl:1.5.3'
implementation('org.apache.cxf:cxf-rt-frontend-jaxws:3.5.0') {
    force = true
    exclude group: 'asm', module: 'asm'
}
implementation 'org.apache.cxf:cxf-rt-transports-http-hc:3.5.0'
implementation("org.apache.cxf:cxf-rt-features-logging:3.5.0")
implementation('org.apache.cxf:cxf-rt-ws-security:3.5.0') {
    force = true
    exclude group: 'org.apache.geronimo.specs', module: 'geronimo-javamail_1.4_spec'
}

 Soap service code is generated successfully but during sending SOA messages sometimes I have such exceptions:  javax.xml.ws.WebServiceException: Provider org.apache.cxf.jaxws.spi.ProviderImpl not found\n\tat javax.xml.ws.spi.FactoryFinder$1.createException(FactoryFinder.java:61)\n\tat javax.xml.ws.spi.FactoryFinder$1.createException(FactoryFinder.java:58)\n\tat javax.xml.ws.spi.ServiceLoaderUtil.newInstance(ServiceLoaderUtil.java:103)\n\tat javax.xml.ws.spi.FactoryFinder.fromSystemProperty(FactoryFinder.java:122)\n\tat javax.xml.ws.spi.FactoryFinder.find(FactoryFinder.java:99)\n\tat javax.xml.ws.spi.Provider.provider(Provider.java:96)\n\tat javax.xml.ws.Service.<init>(Service.java:112)
or
javax.xml.ws.WebServiceException: org.apache.cxf.binding.soap.SoapFault: Problem writing SAAJ model to stream: Unable to create message factory for SOAP: Unable to create SAAJ meta-factory: Provider com.sun.xml.messaging.saaj.soap.SAAJMetaFactoryImpl not found\n\tat org.apache.cxf.jaxws.JaxWsClientProxy.mapException(JaxWsClientProxy.java:193)
I try to take dependencies from https://github.com/ciscoo/cxf-blockhound-webflux
May be u have such situations when the SOAP providers did not found and you all suggest something. I tried to take path for this classes from arg variables but no result. Like the classloader works wrong

The project you linked was created specifically for investigating issue CXF-8410. It is no way meant to be used as a reference and is likely missing dependencies and/or configurations.
The issues you are facing are better suited to Stack Overflow. This issue tracker is primarily for bugs and enhancements for the io.mateo.cxf-codegen plugin, not application  issues.  Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug with the code generation from io.mateo.cxf-codegen plugin specifically.


is there a way to use this with busted directly?

I'm writing some busted tests for some lua scripts, is there a way to adapt this for busted?
Thanks!

This project is very heavily coupled with plenary's busted because it wasn't designed for extending. I haven't looked at busted but I'd imagine that it'd be better maintaining busted support in a separate adapter


Investigate Custom Event Triggering for Admin Actions in Mux Meetings and Other Providers

Currently, for events where an admin removes a participant from the room or mutes a participant, we are using a Mux meetings custom event to trigger our own events. However, we need to investigate whether this custom event triggering is possible in other providers as well.
The investigation should include:

Researching documentation and resources from other providers to see if custom event triggering is possible for admin actions such as removal or muting.
Documenting the findings and providing recommendations on how to implement custom event triggering for admin actions in other providers.

##Custom events
Twilio

Twilio does not have a built-in concept of "custom events" in the context of WebRTC calls. However, Twilio does provide a robust set of APIs and features for managing and controlling real-time communications.

####Here are the relevant events and methods you can use:

Remove Participant:
Event: participantDisconnected - Triggered when a participant is disconnected from a room.
Method: disconnect() - Allows you to programmatically disconnect a participant from a room.

Mute/Unmute Participant:
Event: trackEnabled and trackDisabled - Triggered when a track (audio or video) is enabled or disabled for a participant.
Method: enable(), disable() - Allow you to programmatically enable or disable a participant's tracks.

Janus

Janus, a flexible WebRTC server, you can create custom events by leveraging its plugin system and the Janus API. Janus allows you to build custom plugins that can emit and handle custom events specific to your application's needs.

The way to remove and mute participants in this case would be similar to the way we did in Mux.

###OpenTok

OpenTok provides a signaling mechanism that allows you to send and receive custom messages between participants in a video session. While these messages are not explicitly labeled as "custom events," you can utilize them to simulate custom event-like behavior in your application.

 You can utilize this method to send a custom signaling message to all participants or specific participants indicating the request for participant removal. On the client-side, you can listen for this custom signaling message and handle the participant removal logic accordingly.

Mute/Unmute Participant:
OpenTok offers methods to control the audio and video tracks of participants, enabling you to mute or unmute them during a video session. Here are the relevant methods:
To mute/unmute a participant's audio: You can use the subscriber.subscribeToAudio() method to mute or unmute the audio stream of a specific subscriber (participant). By setting the subscribeToAudio parameter to true or false, you can control the audio playback for that participant.
To mute/unmute a participant's video: You can use the subscriber.subscribeToVideo() method to mute or unmute the video stream of a specific subscriber (participant). Setting the subscribeToVideo parameter to true or false allows you to control the video display for that participant.

###Agora

Agora offers a rich set of APIs and features that allow you to build and customize real-time communication applications.
To achieve custom event-like behavior in Agora, you can leverage Agora's signaling mechanism, which allows you to send and receive messages between participants in a video call. While these signaling messages are not explicitly labeled as "custom events," you can use them to implement similar functionality.

####Here are the relevant events and methods you can use:

Remove Participant:
Agora does not have a specific built-in event for participant removal. However, you can implement your own logic using Agora's signaling mechanism to communicate between participants and trigger participant removal. When a participant wants to be removed from the call, they can send a custom signaling message to notify other participants, and those participants can then handle the removal accordingly.

Mute/Unmute Participant:
Agora provides methods to control the audio and video tracks of participants, allowing you to mute or unmute them during a video call. Here are the relevant methods:
To mute/unmute a participant's audio: You can use the muteLocalAudioStream() and unmuteLocalAudioStream() methods on the local participant's AgoraRTCClient object to mute or unmute their audio stream.
To mute/unmute a remote participant's audio: You can use the muteRemoteAudioStream() and unmuteRemoteAudioStream() methods on the remote participant's AgoraRTCClient object to mute or unmute their audio stream.

###Vonage

Vonage offers a comprehensive set of APIs and tools that allow you to build customized real-time communication applications.

To achieve custom event-like behavior in Vonage, you can leverage their APIs and combine them with your own application logic. You can use Vonage's APIs to send and receive messages or signals between participants, simulating the behavior of custom events.

####Here are the relevant events and methods you can use:

Remove Participant:
Vonage does not have a specific built-in event for participant removal. However, you can implement your own logic using Vonage's APIs and tools to communicate between participants and trigger participant removal. When a participant needs to be removed from the call, you can use Vonage's messaging or signaling capabilities to notify other participants, and they can handle the removal accordingly.

Mute/Unmute Participant:
Vonage provides methods to control the audio of participants, allowing you to mute or unmute them during a video call. Here are the relevant methods:
To mute/unmute a participant's audio: You can use Vonage's Voice API or Video API along with their conversation concept to mute or unmute a participant. By updating the conversation state or using the relevant API methods, you can modify a participant's audio status to achieve muting or unmuting.
It's important to note that muting/unmuting a participant's audio only affects the local playback of their audio. To notify other participants about the mute/unmute status and update their playback accordingly, you can use Vonage's messaging or signaling capabilities to send custom messages or signals between participants, indicating the mute/unmute status of a participant.


cigien: Watch beyooond.com

cigien requests the watch of the watch_keyword beyooond\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

beyooond\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected by Spevacus in Charcoal HQ. Reason: 'Per discussion in Charcoal HQ, this is not needed.'


X-Request-ID in response should not overwrite an existing X-Request-ID request header

Informations
Is your feature request related to a problem? Please describe.
See below.
Describe the solution you'd like
With the addition of the X-Request-ID header in 6.21.0, I would also like to propose that you use an existing X-Request-ID header from the request (if it exists) instead of always creating a new ID in the response header. It makes it easier to track requests through a microservice architecture that way and X-Request-ID is a standard header to use for this specific purpose.
Describe alternatives you've considered
Acceptance criteria

Hello @csnate
It's already possible by providing your own requestIdBuilder but we can do that in standard.
Here:
https://github.com/TypedProject/tsed/blob/production/packages/common/src/platform/utils/createContext.ts#L7
You can propose a small PR if you have a time :)
Romain

@Romakita I couldn't find any documentation on that, but would it look something like this:
@Configuration({
  logger: {
    reqIdBuilder(req: any): string {
        return req.get('x-request-id') || uuidv4().replace(/-/gi, "");
    }
  }
})
export class Server {}

Re: PR - sure thing! I'll try and get to it today.

#1287

Merged :)


Can't seem to use the baseURL defined in Axios default configuration

For context, I'm using TypeScript, React and Jest with Enzyme.
On my application I'm doing something like this:
import * as React from "react";

import Axios from "axios";

export default class Application extends React.Component<any, any> {

    public constructor() {
        super();

        Axios.defaults.baseURL = "https://hostname.herokuapp.com";
    }

    public componentWillMount(): void {
        Axios.get("/token")
            .then((response) => {
                console.log(response);
            });
    }

}

And I'm trying to stub the /token request like this:
import * as React from "react";
import * as Moxios from "moxios";

import { shallow } from "enzyme";

import Application from "components/Application";

describe("Application", () => {

    Moxios.install();

    test("something", () => {
        shallow(<Application />);

        Moxios.stubRequest("/token", {
            status: 200,
            response: {
                message: "Hello Axios"
            }
        });
    });

});

The console.log(response); should output my mocked response, but it's not. However, if I change the stubRequest call to:
Moxios.stubRequest("https://hostname.herokuapp.com/token", ...);

It works... But that kinda defeats the purpose of the baseURL property. Well, it works on the code so that's not too bad, but why is it not working on testing too?
I've tried I've also tried this:
Moxios.install(Axios.create({
    baseURL: "https://hostname.herokuapp.com"
}));

But it didn't work...
What am I missing?

I make the test works, but without moxios instead with sinon like this.
	it('should get posts on componentWillMount', () => { 		let posts = {data: [{id: 1}, {id: 2}, {id: 3}]}; 		const promise = Promise.resolve(posts); 		sinon.stub(axios, 'post', () => promise); 		let wrapper = mount(<Posts />); 		return promise.then(() => { 			expect(wrapper.state().posts).toEqual(posts.data); 		}); 	})

@developersoul I've been trying to do the same with Jest spies and mock functionality (after reading your post) and have successfully tested everything without Moxios. Thank you.


Add: feature that will create a readme automatically

At the time of creation of a new play it will create a readme automatically with a header file with the name of the play
Description

Added a new file in plop-templates (play-readme.hbs) folder to add name to each of the readme file at the time of play creation with a heading

Fixes #(https://github.com/atapas/react-play/issues/47)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
  yarn create-play
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

@hasnainmakada-99 Once you are done taking care of all the comments, please resolve them. Also, notify me for a re-review.


Fix issues #129

Description
Fix issues #129
Issue reference
#129
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation

Hi there,
This project still alive? @doddgu @capdiem @MayueCif @15168440402
Thanks


feat(#major); alpaca-finance-lending-protocol; Add Alpaca Finance Lending Protocol Subgraph

The subgraph link is https://thegraph.com/hosted-service/subgraph/corerouter/alpaca

Looks good to me! Very clean and well organised

Thank you very much for your review!


[PPMix No.10】  add minicpmv-2_6

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.luyao-cv seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Here's a PR we can review to see what changes Style-CI will have on the code base. If we get approvals we can move forward.

Resolved Conflicts, Merged fixes from StyeCI.
StyleCI has been configured to Automatically send and merge fix pull requests , you can see the result of that https://github.com/joindin/joindin-web2/pull/801/commits/956e7385856820fb172b7e1e8758a9eabb522b7a
Ready for review @joindin/leadership-team

Bump


Android studio floating windows are not visible

Steps to reproduce

Launch android studio (currently the latest is v2021..2.1.16-1 on Manjaro Linux)
Open any floating window for example click on Help > About or File > Exit
Floating window is not visible

Expected outcome
Floating windows should be visible
Noted outcome
I noticed that the size of all floating windows in Android studio is 1,1 (see json dump below). Perhaps that is cause.
{
    "address": "0x3d159800",
    "at": [0, 0],
    "size": [1, 1],
    "workspace": {
        "id": 1,
        "name": "1"
    },
    "floating": 1,
    "monitor": 0,
    "class": "jetbrains-studio",
    "title": "Confirm Exit",
    "pid": 115946,
    "xwayland": 1
}

If I add a windowrule like windowrule=size 100% 100%,jetbrains-studio, then I can see the floating windows, but it breaks other UI elements in Android studio.

This is the problem with XWayland and X11 in general. Everything is a window, and since there has been like 20 million band-aids applied to make apps even bearable to use, apps often use some weird-ass way to explain how they want to be.
 If I don't, some random apps that exploit how Xorg works will stop working.
Utter mess.

What you can do to fix this, is make a script and bind it to a key.
With the script, you can find 1x1 windows and resize them with something like focusWindow using an address and then resizeactive. You'd then have a magical keybind to resize all those tiny invisible windows.

Did not know there are so many problems with X11 and XWayland. Well lets hope android studio fixes it because I don't recall having this issue earlier. Unfortunately I upgraded both android studio and hyprwm at the same time, after which I started seeing this issue.

it's mostly because I make minor adjustments to the code that governs which windows should be displayed every now and then to try to get the right balance

Never mind. Actually after upgrading hyprwm to latest and rebooting, everything seems to be fixed. Not sure what the problem was. Could be a restart was all that was needed. Sorry for the false alarm.

amogus


Missing Evaluation Code for Reproducing Results

Great Repo, Only the evaluation code is not present, I want to reproduce the numbers from the paper.
Is it possible to have the evaluation code?

We refactored the whole project to improve the readability of the code, but haven't finished adapting the review code yet. However, we kept the old version of the evaluation code (gene_submission.py)


Video generator requests

Glad you added that in was just gonna write a tool to automate making them into videos after doing them manually with ffmpeg..
if you could add an option to have the last remaining image or finaly image hold for x seconds..   that would be good.. actually even an option to have the final image at the start hold before showing the step progress.. just some added options like that thanks

Could I make another suggestion aswel..
If you add the HiRes option.. the video generated only uses the intermediate imagers from the hires... would be nice if the original resoltuion generation of intermediate steps would be included from the first image, and then after the final image that the hires step images afterwards.. that way you get the whole process from start to finish... obviously the it would be better if the video resolution is at the hires size.. so the original 512x generated ones would be resized ?

 Please let me know, if it works as expected.
About HiRes: Yes, I'm also not happy with the current solution. I'll try to see, what can be done.

yes thanks that works great...
"About HiRes: Yes, I'm also not happy with the current solution. I'll try to see, what can be done."
The other option I'd be happy with is splitting the first 512x (or whatever res) generation and the video from that into one file, and then if hires is on another video file? with option to join or split?

Could you adjust it something like that...
Display last final image at the start for additional frames [checkbox to enable]
10
Display last final image for additional frames  [checkbox to enable]
50
Would be better like that imo.. mainly because I'd like to not have the start frame hold for as long as the ending frame...

Yes, it's more flexible like that. Should work in the latest commit.

I decided to completely remove the lores/hires distinction. This make things much easier and smoother I think.

well.. I think I like having the options.. just because I often play with having hires on and off.. and a bigger reason is that having the hires option on.. can often be completely different from the original low res one.. to the point rather just skip showing the lowres one or the hires one depending..... but sometimes only lowres one is interesting as an animation.... but if I have it on its nice to get the results from the usual 512image generation one and then the hires one to see both in animation.... ideally I'd like to be able to split the video and have a merged one of them both like it does currently now so 3 different videos, lowres, hires (if on), and combined lowres+hires (if on)..  basically the option to have it generate a low res video option, hires video only option and combined low & hires one?... failing that just a .bat file dumped in the image folder with the ffmpeg args for lowres,hires and both?... on windows it would be useful as its harder to use like '*' file name.. and there is no option in ffmpeg to set the filename to be part of the original filename.. ie is no default ffmpeg arg to output that.. without some external script supplying the output filename...
well anyway if you're bored and want to add some more options to it..

XeonG: And just another request.. could you support saving the last known settings chosen for everything in the script.. find myself often having to reclick and enter the same things for all the settings.. hopefully it can be supported.

And just another request.. could you support saving the last known settings chosen for everything in the script.. find myself often having to reclick and enter the same things for all the settings.. hopefully it can be supported.

Well, I think I got it to work. Oddly enough, while webui does save the components' values, it only does it the very first time it is created and then always only loads that.
So I worked around that... There's a save button now and to restore to your last saved settings you have to "Reload UI".

nice thanks!

ideally I'd like to be able to split the video and have a merged one of them both like it does currently now so 3 different videos, lowres, hires (if on), and combined lowres+hires (if on)

I just implemented part of that. For video you can now set lores-only, hires-only or lores+hires. If you want lores-only and hires-only in separate files, you'll have to run it twice.

" If you want lores-only and hires-only in separate files, you'll have to run it twice." yeah damn that is annoying.. only reason is batching it would be nice if it could do 3video encodes ie low only, high only and both.... would still be quicker than going through redoing the seed again with saving out the steps again ... or just a .bat/.sh file with the ffmpeg commands for low, high and both.. which would almost be better as I often go through them later and the video encoding done manually running a bat file would be in a way quicker and less time spending encoding batches that wouldnt' have been kept anyway..  but I dunno how the script works.. just my thinking is that if the steps are done for lo/hi then must be possible?

The challenge with this was, that ffmpeg only accepts a numbered series of images, if the number is increased by exactly one. Combined with the requirement for an option to repeat the first and last images, I came up with the idea of renaming (and in case of the repeats to copy) the files just before the ffmpeg and restore the previous state after.
However, if you don't care that you can't see the step number in the filename anymore, I could put in an option to skip the restoring part and write some batch files instead. Let me know...

Well the only thing I can say is that I do like the step number in the file name.. but so long as the final end result for low res and high res image is still there in the folder I could find them without the step number in the file name. Will the encoding videos still be a built in option to have on? but with the option for batch files scripts to be written aswel?

Yes, that would be in addition. Step number is also stored in the pnginfo btw.

Here the bat-files option:

Thanks will give it a go now 👍

ok.. checked it out.. so the plus side is that I can now run the 'lo' .bat and just get the video fo the lo res version while still having the option of the 'lohi' version and a bat file to just get the 'hi' res version
downsides seem to be .. if 'lo' or 'hi' aren't ticked then or make video.. then the .bat file isn't genereted.. meaning doesn't appear to be a way to get the lo, hi .bat files without it also encoding a video aswel?..  and probably the worst thing is that it generates duplicated frames for the options "Display last image for additional frames at the beginning" etc... which I guess is how you did it original and deleted them?
I was sure there was some options in ffmpeg to have it duplicate a frame for x time.. but having also looked at it once, the way of setting options in ffmpeg seems a like a complete mess and what I saw on stackoverflowing for acheiving it didn't look pretty.. so I dunno it kinda defeats the  option of not having the encoded video files if the duplicated .png images are taking up more space than the encoded videos..
I guess the option to just have it encode a lo res, hi res, and lo+hi res video would be better as an option and not have all the extra step files that are duplicated?

I put in an option to not encode the video, if you're doing bat-files:

The file copies take up zero disk space. Because they are not copies, they're links:

cool what is that link properties tool called?
also is there no way to get the 3rd bat option that encodes both lo and hi res.. much like the built in one does if lo and hi are ticked?

@XeonG

also is there no way to get the 3rd bat option that encodes both lo and hi res.. much like the built in one does if lo and hi are ticked?

I can't think of an easy way to do all versions at the same time. To have lo and hires separated you need a numbering scheme that sets these two apart. To do both you'd need one with an uninterrupted numbering scheme.

cool what is that link properties tool called?

Well, in python I use os.link. On windows you can use the mlink command with the /H parameter.
You can also install the Link Shell Extension, that one puts useful things into the context menu:
https://schinagl.priv.at/nt/hardlinkshellext/hardlinkshellext.html