Fix Ruby 2.4.0 Travis Failure. [Test]

Summary
Only Ruby 2.4.0 is failed on current master branch.
https://travis-ci.org/cucumber/cucumber-ruby-core
This PR is to investigate the reason.
Details
https://travis-ci.org/cucumber/cucumber-ruby-core/jobs/207769607
346 examples, 0 failures

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

Motivation and Context
I want to fix issue.
How Has This Been Tested?
Not yet.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

When I ran Travis for Ruby 2.4.0 with task default: ['spec', 'spec:slow'], it was success.
but there are warnings.
https://travis-ci.org/cucumber/cucumber-ruby-core/builds/210634740
/home/travis/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/configuration.rb:207: warning: constant ::Fixnum is deprecated
/home/travis/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/source_file.rb:29: warning: constant ::Fixnum is deprecated
/home/travis/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/source_file.rb:30: warning: constant ::Fixnum is deprecated

Add Ruby 2.4.0 as allow failures until coveralls supports Ruby 2.4.0.
https://github.com/lemurheavy/coveralls-ruby/pull/117


Erlang 22 support

Erlang 22 is out (and in my case, my linux distro has updated), and with it comes NIF version 2.15. This means that NIFs won't build even with the latest erlang_nif-sys.

What needs to be done to implement Erlang 22 support?

Since I am not so involved in the project any more, I've sketched out the update process here.

Any progress on this?  A server went down when it received its automatic update as it wasn't able to rebuild the NIF's and so had to manually roll it back, which was not at all fun...

Support is on rustler master. erlang_nif_sys was vendored in there as erl_nif_sys, in which the changes have been made.

@filmor Oh awesome, rustler is what I was needing, but any chance of PR'ing the changes back here for those that use this directly?  Or by vendored in do you mean you merged the PR that was here?

I don't think that would make much sense, seeing that further development will happen on the rustler repo. I'll have a look.
The PRs in question are https://github.com/rusterlium/rustler/pull/212 and https://github.com/rusterlium/rustler/pull/226.

See #39.


The problem with the displayed font

I use a Font Nerd Hack, the problem lies in the distance between the characters, I tried to edit the config and put different values on the X-axis, but it looks ugly because the distance between some of the characters still differ

The problem is only if I use Hack Bold, the problem is solved if you just use a configuration Hack for Bold and Italic
фщы - Maybe even have characters that can cause problems, x offset and I have not helped so the configuration looks like this

P.S. Project Nerd just uses a different name for the font Hack after adding symbols


Migrate from glide to dep for openebs/maya -

As noted, by the glide v 0.13.0, dep is being recommended as the preferred vendoring tool. openebs/maya, uses glide and needs to be migrated to using "dep".

Hi, i will grep this task unless somebody else is already working on this.

Thanks @fortrieb, will assign this task to you.

Pull Request https://github.com/openebs/maya/pull/96


examples/sqlite database in wrong folder and useless files

According to the examples/sqlite/src/main.rs file the database should be in the path sqlite/user_store.db, but it actually is in the examples root folder.
We also don't need the user_store.db-shm and user_store.db-wal files, as these are temporary files.

I propose fixing this issue by moving the user_store.dbfile into a sqlite folder and removing the user_store.db-shm and user_store.db-wal files.
I already made these changes on a fork. I you allow I will create a Pull Request.

Thanks for this--those files were not included intentionally. I'd be happy to merge your patch.

Merged via #99.


Add nodepool mysql host

We were statically setting this to localhost.

Hrm, I've just looked at the openstack.py dynamic inventory plugin, and it appears to be short-cutting the filesystem based variable loading by returning a _meta key. http://docs.ansible.com/ansible/dev_guide/developing_inventory.html#tuning-the-external-inventory-script
It's worth testing of course.


ModSecurity fails to parse request body with special characters when using JSON requestBodyProcessor

Hi,
ModSecurity (v3.0.2) fails the JSON requestBodyProcessor for a request when there are special characters such as '\r', '\n' etc in the body.
e.g. Following request results in 400 Bad Request where rule 200002 fails.
curl --request POST \
--header "Content-Type:application/json"  \
--data {"test":"Testing new line. \r\n Another line."} \
http://localhost:8080/some-resource

ModSecurity transaction log
{
	"transaction": {
		"client_ip": "<IP_ADDRESS>",
		"messages": [{
				"message": "Failed to parse request body.",
				"details": {
					"ver": "",
					"severity": "2",
					"reference": "v862,1",
					"ruleId": "200002",
					"tags": [],
					"rev": "",
					"maturity": "0",
					"file": "/etc/nginx/modsecurity/modsecurity.conf",
					"lineNumber": "44",
					"data": "JSON parsing error: lexical error: invalid string in json text.\n",
					"match": "Matched \"Operator `Eq' with parameter `0' against variable `REQBODY_ERROR' (Value: `1' )",
					"accuracy": "0"
				}
			}
		],
		"producer": {
			"connector": "ModSecurity-nginx v1.0.0",
			"components": ["OWASP_CRS/3.0.2\""],
			"modsecurity": "ModSecurity v3.0.2 (Linux)",
			"secrules_engine": "Enabled"
		},
		"host_port": 8080,
		"request": {
			"headers": {
				"Content-Length": "43",
				"Accept": "*/*",
				"User-Agent": "curl/7.51.0",
				"Host": "localhost:8080",
				"Content-Type": "application/json"
			},
			"http_version": 1.1,
			"method": "POST",
			"uri": "/some-resource"
		},
		"server_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
		"host_ip": "<IP_ADDRESS>",
		"client_port": 56170,
		"time_stamp": "Mon Aug 27 03:45:07 2018",
		"response": {
			"http_code": 400
		},
		"id": "15353415074.588818"
	}
}

Nginx access log escapes the request body properly.
{
	"time_local": "27/Aug/2018:03:45:07 +0000",
	"remote_addr": "<IP_ADDRESS>",
	"remote_port": "56170",
	"remote_user": "",
	"request": "POST /some-resource HTTP/1.1",
	"status": 400,
	"request_length": "854",
	"request_method": "POST",
	"content_length": "43",
	"content_type": "application/json",
	"bytes_sent": "589",
	"body_bytes_sent": "176",
	"request_body": "{test:Testing new line. \\r\\n Another line.}",
	"http_user_agent": "curl/7.51.0"
}

It seems that ModSecurity is not escaping the '\r', \n' etc which results in a failure when parsing into a JSON object.
Thanks.

thanks @victorhora for looking into this.
Yes, adding a single quote in curl gets it working, I purposely put it without quote in the cURL since the same scenario happens when sending request from a java client - haven't tried any other language. If the server side is Java again, it receives it properly i.e. takes care of escaping during parsing.
Nginx seems to be doing the similar thing i.e. taking care of escaping - at least during the access log.
{
	"request_body": "{test:Testing new line. \\r\\n Another line.}",
}

It will be nice if ModSecurity takes care of it when parsing. Your views?
Thanks.

@msamad, Afaik, the library that ModSecurity uses for parsing JSON (YAJL) should attempt to escape control chars such as \r which would explain why it gets parsed correctly when sending the request properly using HTTP clients. You can also test how YAJL parses data by using the json_verify tool that comes with YAJL
root@debian:~# echo {\"test\":\"Testing new line. \r\n Another line.\"} | json_verify
JSON is valid

I've triggered the requests again using cURL without quotes (') to the "--data" parameter and the bytes on the wire (PCAP) shows that this leads to the JSON data being sent without double quotes (") around the values:

While using cURL with quotes (') to the "--data" parameter leads to the JSON having double quotes (") around the values as per JSON standard (RFC-8259#section-7:

Note also how the HTTP dissector of Wireshark is also able to correctly parse the data from packet.
That being said, I believe that the behaviour of ModSecurity and YAJL is correct and no extra escaping is needed at least when using cURL to reproduce this.
Maybe your Java client/library is not wrapping the values in double quotes for some reason? You may try a using a similar approach to confirm.

Thanks @victorhora
I'll try the similar approach on my client and check how it sends the data.

Hi @victorhora,
I tried it with WireShark - sorry took me a while to get back to this one.
So I sent the request using a java client to ModSecurity (Nginx) and got back a 400 as ModSecurity failed to parse the request body. WireShark though sees it as a proper JSON object, image below.

I enabled request body logging in nginx access log '"request_body": "$request_body", ' and in ModSecurity SecAuditLogParts ABCIJDEHZ
Below is what I noticed when I tried calling the same using curl and java client.
curl - using the single quote - the request passes without any issue
curl --request PUT \
--header "Content-Type:application/json"  \
--data '{"test":"Testing new line. \r\n Another line."}' \
http://localhost:8443/some-resource

This is what I get in nginx access and modsecurity logs.
//nginx access log:
"request_body": "{\"test\":\"Testing new line. \\r\\n Another line.\"}"

As this request passes, I purposely added base64 keyword in the field value for modsecurity to reject it and produce log
//nginx access log
"request_body": "{\"test\":\"Testing new line. \\r\\n Another line.base64\"}"

//modsecurity log
"body": "{\"test\":\"Testing new line. \\r\\n Another line.base64\"}"

Now, without using the single quote - the gets rejected of coarse.
curl --request PUT \
--header "Content-Type:application/json"  \
--data {"test":"Testing new line. \r\n Another line."} \
http://localhost:8443/some-resource

I get this in nginx access and modsecurity logs.
//nginx access log
"request_body": "{test:Testing new line. \\r\\n Another line.}"

//modsecurity log
"body": "{test:Testing new line. \\r\\n Another line.}"

The above is bad because double quotes have been removed and even WireShark doesn't recognize it as valid json.
Now when I make the call using Java client. I get this in nginx access and modsecurity logs.
//nginx access log
"request_body": "{\"test\":\"Testing new line. \r\n Another line.\"}"

//modsecurity log
"body": "{\"test\":\"Testing new line. \r\n Another line.\"}"

The request gets rejected by modsecurity with failed to parse request body error but WireShark is able to recognize it as valid json. Notice that double quotes have not been removed and also no extra escape  \ for \r and \n.
I verified the curl (using single quote) result and java result using json_verify and all are valid.
# curl results
# without double quotes
bash-4.2$ echo {\"test\":\"Testing new line. \\r\\n Another line.base64\"} | json_verify
JSON is valid
# with double quotes
bash-4.2$ echo "{\"test\":\"Testing new line. \\r\\n Another line.base64\"}" | json_verify
JSON is valid

# java results
# without double quotes
bash-4.2$ echo {\"test\":\"Testing new line. \r\n Another line.\"} | json_verify
JSON is valid
# with double quotes
bash-4.2$ echo "{\"test\":\"Testing new line. \r\n Another line.\"}" | json_verify
JSON is valid

if json_verify is successfully validating these both results with or without double quotes around the same message in echo, then why would modsecurity work with one (curl) and not the other (java)?

Also tried it with Python script and got 400 because modsecurity failed to parse request body.
Script:
import requests
url = 'http://localhost:8443/some-resource'
data = '{"test":"Testing new line. \r\n Another line."}'
response = requests.post(url, data=data,headers={"Content-Type": "application/json"})
print(response)
print(response.text)

I get this in nginx access and modsecurity logs.
//nginx access log
"request_body": "{\"test\":\"Testing new line. \r\n Another line.\"}"

//modsecurity log
"body": "{\"test\":\"Testing new line. \r\n Another line.\"}"

This is same as what I get for java client.

Hi @victorhora,
Thank you very much for the details
Escaping the \r and \n gets it to pass their "raw" ASCII format (0x5c 0x72 0x5c 0x6e).
The following python script results in ASCII sequence instead of control character sequence.
import requests
url = 'http://localhost:8443/some-resource'
data = '{"test":"Testing new line. \\r\\n Another line."}'
response = requests.post(url, data=data,headers={"Content-Type": "application/json"})
print(response)
print(response.text)

Some good explanation on stackflow
https://stackoverflow.com/questions/42068/how-do-i-handle-newlines-in-json
As most of programming languages uses \ for quoting you should escape escape syntax (double-escape - once for language/platform, once for Json itself):

One more thing to mention that the following python script will be successful without escaping \r \n as the language parses the json properly and takes care of any escaping since the data is being passed json as object and not json as string.
import requests
url = 'http://localhost:8443/some-resource'
data = {"test":"Testing new line. \r\n Another line."}
response = requests.post(url, json=data,headers={"Content-Type": "application/json"})
print(response)
print(response.text)

Notice the json=data part which is different from data=data where we escape \r \n


XIVY-11447 adapt new openrpc based schema

https://github.com/axonivy/inscription-client/blob/alternativeGateway/packages/editor/src/components/editors/InscriptionEditor.tsx#L49
Add here a toLowerCase() to fix the test

https://github.com/axonivy/inscription-client/blob/alternativeGateway/packages/editor/src/components/editors/InscriptionEditor.tsx#L49 Add here a toLowerCase() to fix the test

thanks for feeling my struggle with these tests; unfortunately I can't run them anymore in the IDE :thinking:


Describe new constructor default payable behaviour

Before https://github.com/paritytech/ink/pull/1065 constructors in ink! were payable (that is, they accepted a value) by default. For reasons described in that PR this is no longer the default behaviour.
Now, constructors will need to opt into accepting a value through the use of the already existing #[ink(payable)] attribute.

Closing as outdated


Fixed typo in texture.py

Fixed 4 typo in texture.py for texture.filter example documentation - monderngl to moderngl

Thank you!


CI, BUG: modin-spreadsheets version needs to be bumped

We need to bump up the version of modin-spreadsheets and make sure that we handle examples/tutorial/jupyter/execution/pandas_on_*/requirements.txt since they will install a broken version of modin-spreadsheets.

Pending merge https://github.com/modin-project/modin/pull/6342

@mvashishtha let's continue here https://github.com/modin-project/modin/pull/6581#issuecomment-1724134292
After you make the release, I will be able to fix this bug


60_medical.imaging: Create Docments

Add docments to 60_medical.imaging.
See the style guide and contribution guide for more details (links will be added when created).
This requires familiarity with dicom imaging and fastai2.
Docments progress:

[ ] Patching
[ ] PILDicom
[ ] Dataset.show
[ ] DicomSegmentationDataLoaders

Hi! I am currently working on another issue, but after I finish it, I will be happy to give this one try. It is tagged "advanced" and I am definitely a beginner, but I do work with Dicom files so perhaps with closer guidance of a mentor I will succeed. Let me know what you think 😄


Created requirements file for audio and speech

Created requirements file for audio and speech for ASR,Audio effects

Hey, thanks for the contribution. In order to make these dependencies accessible you would need to add a entry in the extras dict in the setup.py.

/azp run

Hi Daniel,
I will add it now. Thanks a lot for the suggestion.
Thanks & Regards,
Kaustav
Technical Envagelist
Embedded & Distributed Systems
On Thu, Sep 16, 2021 at 5:55 AM Daniel Ciborowski @.***>
wrote:

Hey, thanks for the contribution. In order to make these dependencies
accessible you would need to add a entry in the extras dict in the setup.py.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/ai-python/pull/275#issuecomment-920481632,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE7YQAGPQBO2LSLVT4XWOI3UCE2QNANCNFSM5EDGC7IQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi Daniel,
I have added the entry.
Thanks & Regards,
Kaustav
Technical Envagelist
Embedded & Distributed Systems
On Thu, Sep 16, 2021 at 5:55 AM Daniel Ciborowski @.***>
wrote:

Hey, thanks for the contribution. In order to make these dependencies
accessible you would need to add a entry in the extras dict in the setup.py.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/ai-python/pull/275#issuecomment-920481632,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE7YQAGPQBO2LSLVT4XWOI3UCE2QNANCNFSM5EDGC7IQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


feat: Render error message condition as json/structured message

Fixes #3967

Release Note
NONE

@astefanutti I'm experiencing some issues as part of the ci build:
cd pkg/client/camel && go test ./...
# github.com/apache/camel-k/pkg/client/camel/applyconfiguration
Error: applyconfiguration/utils.go:82:19: undefined: v1.HealthCheckResponseApplyConfiguration
Error: applyconfiguration/utils.go:126:19: undefined: v1.PodConditionApplyConfiguration

What is the proper way to generate the client & apply config ?

@astefanutti I'm experiencing some issues as part of the ci build:
cd pkg/client/camel && go test ./...
# github.com/apache/camel-k/pkg/client/camel/applyconfiguration
Error: applyconfiguration/utils.go:82:19: undefined: v1.HealthCheckResponseApplyConfiguration
Error: applyconfiguration/utils.go:126:19: undefined: v1.PodConditionApplyConfiguration

What is the proper way to generate the client & apply config ?

Could you please try generating the client locally by replacing applyconfiguration-gen in the codegen-tools-install target of the Makefile with:
go install github.com/astefanutti/code-generator/cmd/applyconfiguration-gen@pr-144

That should generate the missing types.
This is a temporary "glitch" as a fix is required in code-generator, which will go away as soon as it lands upstream.

mh , looks like it did not help

mh , looks like it did not help

Hum, hasn't make generate created the new types in the pkg/client/camel/applyconfiguration Let me try on my side...

This is what I see:
➜ make generate
Installing k8s.io/code-generator tools with version v0.25.2
#go install<EMAIL_ADDRESS>go install github.com/astefanutti/code-generator/cmd/applyconfiguration-gen@pr-144
go: finding module for package k8s.io/code-generator/cmd/applyconfiguration-gen/generators
go: finding module for package k8s.io/code-generator/cmd/applyconfiguration-gen/args
go: found k8s.io/code-generator/cmd/applyconfiguration-gen/args in k8s.io/code-generator v0.26.0
go: found k8s.io/code-generator/cmd/applyconfiguration-gen/generators in k8s.io/code-generator v0.26.0
go install<EMAIL_ADDRESS>go install<EMAIL_ADDRESS>go install<EMAIL_ADDRESS>./script/gen_client.sh
Generating Go client code...
F0116 11:45:08.040686   39309 main.go:51] Error: Failed executing generator: some packages had errors:
template: /Users/luca-rh/.cache/go/pkg/mod/k8s.io/code-generator@v0.26.0/cmd/applyconfiguration-gen/generators/applyconfiguration.go:220:1:28: executing "/Users/luca-rh/.cache/go/pkg/mod/k8s.io/code-generator@v0.26.0/cmd/applyconfiguration-gen/generators/applyconfiguration.go:220" at <raw>: error calling raw: runtime error: invalid memory address or nil pointer dereference
template: /Users/luca-rh/.cache/go/pkg/mod/k8s.io/code-generator@v0.26.0/cmd/applyconfiguration-gen/generators/applyconfiguration.go:220:1:28: executing "/Users/luca-rh/.cache/go/pkg/mod/k8s.io/code-generator@v0.26.0/cmd/applyconfiguration-gen/generators/applyconfiguration.go:220" at <raw>: error calling raw: runtime error: invalid memory address or nil pointer dereference
./script/gen_crd.sh
./script/gen_doc.sh
Generating API documentation...
Generating CRD API documentation...
I0116 11:45:21.152511   39774 main.go:136] parsing go packages in directory github.com/apache/camel-k/pkg/apis/camel/v1
I0116 11:45:24.586035   39774 main.go:240] using package=github.com/apache/camel-k/pkg/apis/camel/v1
I0116 11:45:24.586054   39774 main.go:240] using package=github.com/apache/camel-k/pkg/apis/camel/v1/trait
W0116 11:45:24.612611   39774 main.go:469] not found external link source for type encoding/xml.Name
I0116 11:45:24.616375   39774 main.go:176] written to ./script/gen_crd/../../docs/modules/ROOT/partials/apis/camel-k-crds.adoc
I0116 11:45:25.044803   39872 main.go:136] parsing go packages in directory github.com/apache/camel-k/pkg/apis/camel/v1alpha1
I0116 11:45:28.453325   39872 main.go:240] using package=github.com/apache/camel-k/pkg/apis/camel/v1alpha1
W0116 11:45:28.462888   39872 main.go:469] not found external link source for type encoding/json.Number
W0116 11:45:28.462939   39872 main.go:469] not found external link source for type encoding/json.Number
W0116 11:45:28.463025   39872 main.go:469] not found external link source for type encoding/json.Number
I0116 11:45:28.464208   39872 main.go:176] written to ./script/gen_crd/../../docs/modules/ROOT/partials/apis/kamelets-crds.adoc
Generating CRD API documentation... Done.
Generating API documentation... done!
Generating traits documentation...

@lburgazzoli Could you please try with:
go install github.com/astefanutti/code-generator/cmd/applyconfiguration-gen@pr-144-install

I've done the required change in that new branch to overcome golang/go#50278, and tested it locally successfully.

Seems to break some other stuffs
go test ./...
# github.com/apache/camel-k/pkg/client/camel/applyconfiguration/camel/v1
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:45:11: cannot use &value (value of type *"k8s.io/api/core/v1".PodConditionType) as type "k8s.io/api/core/v1".PodConditionType in assignment
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:53:13: cannot use &value (value of type *"k8s.io/api/core/v1".ConditionStatus) as type "k8s.io/api/core/v1".ConditionStatus in assignment
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:61:20: cannot use &value (value of type *"k8s.io/apimachinery/pkg/apis/meta/v1".Time) as type "k8s.io/apimachinery/pkg/apis/meta/v1".Time in assignment
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:69:25: cannot use &value (value of type *"k8s.io/apimachinery/pkg/apis/meta/v1".Time) as type "k8s.io/apimachinery/pkg/apis/meta/v1".Time in assignment
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:77:13: cannot use &value (value of type *string) as type string in assignment
pkg/client/camel/applyconfiguration/camel/v1/podcondition.go:85:14: cannot use &value (value of type *string) as type string in assignment

And lints:
addons/master/master.go:98:65                                     typecheck      t.Client undefined (type *masterTrait has no field or method Client)
addons/master/master.go:232:45                                    typecheck      t.Client undefined (type *masterTrait has no field or method Client)
addons/resume/resume.go:88:75                                     typecheck      r.Client undefined (type *resumeTrait has no field or method Client)
pkg/controller/build/build_controller.go:165:5                    typecheck      a.InjectClient undefined (type Action has no field or method InjectClient)
pkg/controller/build/build_controller.go:167:5                    typecheck      a.InjectRecorder undefined (type Action has no field or method InjectRecorder)
pkg/controller/integrationkit/integrationkit_controller.go:263:5  typecheck      a.InjectClient undefined (type Action has no field or method InjectClient)
pkg/controller/kamelet/kamelet_controller.go:159:5                typecheck      a.InjectClient undefined (type Action has no field or method InjectClient)
addons/tracing/tracing.go:94:52                                   typecheck      t.Client undefined (type *tracingTrait has no field or method Client)
addons/tracing/tracing.go:99:8                                    typecheck      t.L undefined (type *tracingTrait has no field or method L)
pkg/cmd/root.go:231:24                                            typecheck      invalid operation: cannot compare command._client != nil (operator != not defined on untyped nil)
pkg/controller/integrationplatform/create_test.go:50:4            typecheck      h.InjectClient undefined (type Action has no field or method InjectClient)
pkg/controller/integrationplatform/initialize_test.go:50:4        typecheck      h.InjectClient undefined (type Action has no field or method InjectClient)
pkg/controller/integrationplatform/initialize_test.go:80:4        typecheck      h.InjectClient undefined (type Action has no field or method InjectClient)
pkg/metadata/metadata_capabilities_test.go:50:8                   typecheck      meta.Dependencies undefined (type IntegrationMetadata has no field or method Dependencies)
pkg/metadata/metadata_capabilities_test.go:57:8                   typecheck      meta.RequiredCapabilities undefined (type IntegrationMetadata has no field or method RequiredCapabilities)
pkg/metadata/metadata_dependencies_test.go:62:8                   typecheck      meta.Dependencies undefined (type IntegrationMetadata has no field or method Dependencies)
pkg/metadata/metadata_dependencies_test.go:95:8                   typecheck      meta.Dependencies undefined (type IntegrationMetadata has no field or method Dependencies)
pkg/metadata/metadata_dependencies_test.go:219:22                 typecheck      meta.RequiredCapabilities undefined (type IntegrationMetadata has no field or method RequiredCapabilities)
pkg/metadata/metadata_dependencies_test.go:376:22                 typecheck      meta.RequiredCapabilities undefined (type IntegrationMetadata has no field or method RequiredCapabilities)
pkg/metadata/metadata_http_test.go:48:22                          typecheck      meta.ExposesHTTPServices undefined (type IntegrationMetadata has no field or method ExposesHTTPServices)
pkg/metadata/metadata_http_test.go:49:23                          typecheck      meta.PassiveEndpoints undefined (type IntegrationMetadata has no field or method PassiveEndpoints)
pkg/metadata/metadata_http_test.go:73:22                          typecheck      meta.ExposesHTTPServices undefined (type IntegrationMetadata has no field or method ExposesHTTPServices)
pkg/metadata/metadata_http_test.go:74:22                          typecheck      meta.PassiveEndpoints undefined (type IntegrationMetadata has no field or method PassiveEndpoints)
pkg/metadata/metadata_http_test.go:95:22                          typecheck      meta.ExposesHTTPServices undefined (type IntegrationMetadata has no field or method ExposesHTTPServices)
pkg/metadata/metadata_http_test.go:96:22                          typecheck      meta.PassiveEndpoints undefined (type IntegrationMetadata has no field or method PassiveEndpoints)
pkg/metadata/metadata_uri_test.go:56:30                           typecheck      metadata.FromURIs undefined (type IntegrationMetadata has no field or method FromURIs)
pkg/metadata/metadata_uri_test.go:57:25                           typecheck      metadata.FromURIs undefined (type IntegrationMetadata has no field or method FromURIs)
pkg/metadata/metadata_uri_test.go:58:30                           typecheck      metadata.ToURIs undefined (type IntegrationMetadata has no field or method ToURIs)
pkg/metadata/metadata_uri_test.go:59:25                           typecheck      metadata.ToURIs undefined (type IntegrationMetadata has no field or method ToURIs)
pkg/metadata/metadata_uri_test.go:94:30                           typecheck      metadata.FromURIs undefined (type IntegrationMetadata has no field or method FromURIs)
pkg/metadata/metadata_uri_test.go:96:30                           typecheck      metadata.ToURIs undefined (type IntegrationMetadata has no field or method ToURIs)
pkg/trait/pull_secret.go:74:19                                    typecheck      invalid operation: cannot compare t.Client != nil (operator != not defined on untyped nil)
pkg/trait/trait_catalog.go:59:6                                   typecheck      t.InjectClient undefined (type Trait has no field or method InjectClient)

Could you add --input-dirs k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/api/core/v1 to the arguments passed to applyconfiguration-gen in gen_client.sh, as the changes to the Integration types import those packages, and regenerate the client packages?

@astefanutti @squakez @tadayosi @claudio4j it lacks a test for integration that are scaled > 1, let me know if the test should be part of this pr or can wait for a second iteration.

@astefanutti @squakez @tadayosi @claudio4j it lacks a test for integration that are scaled > 1, let me know if the test should be part of this pr or can wait for a second iteration.

Feel free to track it in a follow up issue and work it later.

@astefanutti @squakez @tadayosi @claudio4j it lacks a test for integration that are scaled > 1, let me know if the test should be part of this pr or can wait for a second iteration.

Feel free to track it in a follow up issue and work it later.

https://github.com/apache/camel-k/issues/3997

Note, a number of tests are failing because of:
  no matching manifest for linux/amd64 in the manifest list entries

@squakez @astefanutti anything missing or ok to merge ?

@squakez @astefanutti anything missing or ok to merge ?

I'd be inclined to have the change to temurin as default base image (131915bccd32b625adabc543be4b7298b5694b2a) done in a separate PR to make it more visible in the release note and ease backport. Other than that, it's good to go 👍🏼.

let see if I can work on something

@astefanutti opened https://github.com/apache/camel-k/pull/4003 (it is actually made by 3 commits, I can squash them if needed)

@astefanutti opened #4003 (it is actually made by 3 commits, I can squash them if needed)

Awesome! Let's wait CI to pass for #4003, so we can merge it and have that one rebased on top.


Add PHPStan to Travis CI

As suggested by @jmikola in #457, this PR adds PHPStan to Travis CI.
There is only 1 remain error to bump to level 1:
 ------ -----------------------------------------------
  Line   src/Operation/MapReduce.php
 ------ -----------------------------------------------
  158    Class MongoDB\Operation\Javascript not found.
 ------ -----------------------------------------------

@jmikola My I ask your help in this last PHPStan error?

@jmikola Thanks, I'll rebase and maybe PHPStan level 0 will pass :tada:
I'll require it as a dev dependency and use Build Stages :+1:

@jmikola Unfortunately, we can't ship with PHPStan as it requires PHP 7.0. I'll close this for now as we will need to rewrite .travis.yml :smile:


Mod not working with newest Lethal Update

When trying to play with more than four people, the mod does not work and the game says the lobby is full. The code shows an error that the mod that "failed to patch" upon loading and it seems to be related to the new entities/latest Lethal update as of 17Aug2024.

 Since this error would happen if you are trying to use the latest version of MoreCompany on v56

We completely blanked that we had the beta enabled still. Disabling the beta solved the issue. Thank you!

Having similar issue, mod is not working for v62

Having similar issue, mod is not working for v62

That'd be a conflict with another mod or your mods not loading at all

@1A3Dev. thank you, that was conflict with LC_API, seems like that package was removed, but for some reason game was working with LC_API on and moreCompany off. Removing LC_API fixed issue

can anyone guide on how to fix this? im on v55 and its not working

The latest version of morecompany only support v60+


[Type checker] Add a request for overridden declarations

This keeps growing. New PR up at https://github.com/apple/swift/pull/17976


[PE-D][Tester C] Student details window does not show updated data

For pie and bar commands, the user guide clearly states that the data has to be updated before running the command, but this is not stated for info. Hence, the reader may expect a real-time data update of the pop-up window. For example, after the info window is opened, commands that mutate the data like add, delete, edit, etc will not cause the changes to be automatically reflected.

Labels: type.FunctionalityBug severity.Medium
original: ZweZeya/ped#14

Resolved


feat(calicoctl): add calicoctl wrapper

This adds a wrapper for calicoctl what still needs to be done:

[x] add calicoctl download on build and bundle it with the plugin
[x] fix permission passing to calicoctl
[x] add probing
[ ] add tests
[x] add go routines and channels for the requests to improve performance of the calico command

to get this working you currently need to run
curl -L https://github.com/projectcalico/calicoctl/releases/download/v3.12.0/calicoctl-darwin-amd64 --output build/darwin/calico.zip && unzip build/darwin/plugin/bin/calicoctl && chmod +x build/darwin/plugin/bin/calicoctl

before  building the package.

Closing #446


could not find main in embassy_executor

Trying to get a simple example working with embassy.
On my esp32c3 I have the following main.rs
I want to get the sneak-peak section on the redme for embassy running.
error[E0433]: failed to resolve: could not find `main` in `embassy_executor`
  --> src/main.rs:12:21
   |
12 | #[embassy_executor::main]
   |                     ^^^^ could not find `main` in `embassy_executor`

main.rs
#![no_main]
#![feature(type_alias_impl_trait)]

use embassy_time::{Duration, Timer};
use embassy_executor::Spawner;

#[embassy_executor::main]
async fn main(spawner: Spawner) {
    // It is necessary to call this function once. Otherwise some patches to the runtime
    // implemented by esp-idf-sys might not link properly. See https://github.com/esp-rs/esp-idf-template/issues/71
    esp_idf_svc::sys::link_patches();

    // Bind the log crate to the ESP Logging facilities
    esp_idf_svc::log::EspLogger::initialize_default();

    spawner.spawn(run()).ok();
    log::info!("Hello, world!");
}

#[embassy_executor::task]
async fn run() {
    loop {
        log::info!("Hello world from embassy using esp-hal-async!");
        Timer::after(Duration::from_millis(1_000)).await;
    }
}

and cargo.toml
[package]
name = "stdtest"
version = "0.1.0"
authors = ["Bronson<EMAIL_ADDRESS>edition = "2021"
resolver = "2"
rust-version = "1.71"

[profile.release]
opt-level = "s"

[profile.dev]
debug = true    # Symbols are nice and they don't increase the size on Flash
opt-level = "z"

[features]
default = ["std", "embassy", "esp-idf-svc/native"]

pio = ["esp-idf-svc/pio"]
std = ["alloc", "esp-idf-svc/binstart", "esp-idf-svc/std"]
alloc = ["esp-idf-svc/alloc"]
nightly = ["esp-idf-svc/nightly"]
experimental = ["esp-idf-svc/experimental"]
embassy = ["esp-idf-svc/embassy-sync", "esp-idf-svc/critical-section", "esp-idf-svc/embassy-time-driver"]

[dependencies]
log = { version = "0.4", default-features = false }
esp-idf-svc = { version = "0.48", default-features = false }
embassy-time = "0.3.0"
embassy-executor = "0.5.0"

[build-dependencies]
embuild = "0.31.3"

you have to enable features executor-thread and arch-riscv in embassy-executor.

ok great thanks!


fix(upstream): Syncing with upstream ipfs-service-provider

:tada: This PR is included in version 1.4.0 :tada:
Your semantic-release bot :package::rocket:


About Us page content

The API Services Portal does not provide context or description of the value that APS' services provide. Users and potential clients trying to understand our services need information to help them navigate their use of the API Services Portal.
Questions to be answered:

Where will this content be shown on the API Services Portal
What initial content needs to be present and how will it be presented

Constraints: Content about APS needs to remain consistent with other documentation such as the 2-pager value proposition document (currently in draft) and the content in the CMS Lite page.
Out of scope: Content does not need to be consistent with developer.gov.bc.ca content about APS until after that platform has been refreshed. Work on that content will be drafted to align with the content created in this work.
Definition of Done: Initial content is provided about APS Services on the API Services Portal so that users can self-serve this information.

We'll be showing this content on the About Us page accessible through the footer
Content is consistent with the 2 pager value proposition doc

@JohnathanBrammall please review ticket. Thanks!

Looks great. Thanks @elisafw-ux

With respect to content, can we update the first sentence reference to APS to match our new definition in the glossary?

I've replaced the text to match our glossary.


Can you display the chip widget inside the textfield?

Hi sir,
Can you help me how to show list and display chip input inside the textfield.

Yeah sure, I will try it and let you know ASAP


Episode filtering not working correctly for specific show.

Describe the bug
When trying to download Darling in the Franxx using episode filtering its downloading episodes outside of the filter.
IE my filter should only download episodes 25 and up, but when I run the script it starts downloading episode 24
To Reproduce
Steps / command to reproduce the behavior:
$ crunchy-cli --etp-rt "xxxx" archive --skip-existing -a ja-JP -a en-US -r worst -o "{series_name}-_-{season_number}-_-{episode_number}-_-{title}.mkv" https://www.crunchyroll.com/series/GY8VEQ95Y/darling-in-the-franxx[S1E25-]

Expected behavior
To not download any show
Screenshots

Client (please complete the following information):

OS: Windows
Version: crunchy-cli 3.1.1

Additional context
Add any other context about the problem here.

Crunchyroll is internally mislabeling the episode number which crunchy-cli uses to filter the episodes. Crunchyroll has 3 different approaches to label episode numbers but no one has a 100% accuracy.
In your case, only the number which is intended to be shown to the user correctly says E24, all others, including the number crunchy-cli uses to filter episodes, are reporting that the episode is episode 25. I won't add a fix for this case, unless this happens for more series.


Upgrade dependencies (Express 4.0 is biggest one)

Update dependencies:

request 2.40.0 -> 2.51.0
underscore 1.6.0 -> 1.7.0
express 3 -> 4.11.0

Drop node 0.8 support
Bump version rendr to 1.0.0
Fixes #422
@spikebrehm

Coverage decreased (-0.23%) when pulling 81e5a1da8d137c78738c12e08e7ceca8aa75e5ff on upgrade-modules into ca77981f80cad4f7c2d266b70063f6dd81db89f4 on master.

Coverage decreased (-0.23%) when pulling 010b28aa3180957452a27606e5ec8e4b7b5016cb on upgrade-modules into ca77981f80cad4f7c2d266b70063f6dd81db89f4 on master.

Coverage decreased (-0.23%) when pulling 9020a9debde2d3ed2ea2748576fa195fd76cb38e on upgrade-modules into ca77981f80cad4f7c2d266b70063f6dd81db89f4 on master.

:+1:

exciting!


test(e2e): changed tests to work with e2e flow

Codecov Report

Merging #228 (3c3267f) into master (907739e) will decrease coverage by 0.72%.
The diff coverage is n/a.

:exclamation: Current head 3c3267f differs from pull request most recent head 6a8060e. Consider uploading reports for the commit 6a8060e to get more accurate results

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   50.06%   49.33%   -0.73%
==========================================
  Files          33       33
  Lines         825      825
  Branches       86       86
==========================================
- Hits          413      407       -6
- Misses        379      386       +7
+ Partials       33       32       -1

Impacted Files
Coverage Δ

src/app/devices/sol/sol.component.ts
51.96% <0.00%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907739e...6a8060e. Read the comment docs.


Make the go version simpler

The "simpler" interface seems to be deprecated.
https://stackoverflow.com/a/14680373/8384910

Where does it say in the official documentation it's deprecated?


Suggested command is not supported

In the "Table size queries" subsection, it is suggested to run the query "DBCC PDW_SHOWSPACEUSED" to measure distribution sizes. However, it seems that this command is not actually supported for Synapse.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 473726a0-19e3-a144-56ca-a66058f9ff67
Version Independent ID: 820466f5-2ec1-a3f8-51ae-8ab02fed9395
Content: Designing tables - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-tables-overview.md
Service: synapse-analytics
Sub-service: ****
GitHub Login: @XiaoyuMSFT
Microsoft Alias: xiaoyul

Sorry, I was using the command incorrectly. There is no issue :)

@jialinding No problem. Glad to know that you have self resolved the issue. Thanks for the update.


Prepend the IV to the encrypted data

Fixed a mistake in the encryption method.

Thanks a lot, there was code from the decryption left - that is why you should not do copy & paste ;)


Add github workflow to automatically update pixi lockfile

In this way, we do not risk forgetting to maintain the Pixi lock files.
The action comes from the official documentation: https://pixi.sh/dev/advanced/updates_github_actions/#how-to-use with some customizations done by @flferretti in https://github.com/ami-iit/jaxsim/pull/221
Remark: as specified in the documentation, the permission of the repo should be set as follows:

Triggered the action on my fork of the repository since the action is only available when on main: https://github.com/xela-95/gz-sim-yarp-plugins/actions/runs/10724133024

Triggered the action on my fork of the repository since the action is only available when on main: https://github.com/xela-95/gz-sim-yarp-plugins/actions/runs/10724133024

It executed successfully and it generated the PR: https://github.com/xela-95/gz-sim-yarp-plugins/pull/1

I am not enthusiastic of the idea of the automatic pixi-lock update (for the reasons described in https://github.com/robotology/whole-body-estimators/pull/191), but if it is happening only one a month that is ok for me.

I am not enthusiastic of the idea of the automatic pixi-lock update (for the reasons described in robotology/whole-body-estimators#191), but if it is happening only one a month that is ok for me.

Thanks for linking the discussion, I've not considered that side-effect, maybe we could put track the pixi lockfile with LFS or maybe only maintain the the manual worflow-dispatch way of running the action.

I think we can try the automatic update for some time and then monitor the size of the repo. If it increases too much, we can switch to manual sporadic updates.

Perfect! Merging 🚀


Turns out our CG context cairo doesn't support BGRX.

Turns out our CG context cairo doesn't support BGRX.  Use any other pixel format, in this case, XBGR.  Fixes #1335.
The issue can only be seen opaque layers. In my discussions with @jaredhms we will just have one code path in the near future when ux/uxe merges, so i might as well wait for that change to merge instead.

This change is

:shipit:

FWIW, this code is gone in ux/uxe, slated to merge into develop within the next ~day or so: https://github.com/Microsoft/WinObjC/blob/ux/uxe/Frameworks/QuartzCore/CALayer.mm#L491

:shipit:


Drop support for non-webpack

I see that running with or without webpack is supported, and some code at main.js is because of that.
I suggest dropping support for non-webpack methods entirely. Do you think there is a reason to not do it?

The main.js is mainly for measuring extension load time and easier for local development

webpack have the option --watch. --mode development can also help.
I'm just telling this because I felt confused when I started working with the repository first time, and reading the Vscode guides for bundling I felt that is not usual to have support non-bundling once bundling is there.
I can be wrong though.
https://code.visualstudio.com/api/working-with-extensions/bundling-extension

I'm just telling this because I felt confused when I started working with the repository first time, and reading the Vscode guides for bundling I felt that is not usual to have support for non-bundling once bundling is there.

Yeah, It's a bit confusing, I introduced this pattern just because vscode developers use it:

https://github.com/microsoft/vscode-docker/blob/master/main.js
https://github.com/microsoft/vscode-azurestorage/blob/master/main.js

https://github.com/vscode-shellcheck/vscode-shellcheck/pull/308


Spanish

Added new keys, reworked the original translation to be consistent with Core Foundry translation,

Thanks for this contribution!


Refresh button for Event history

Is your feature request related to a problem? Please describe.
Having frequently updating event history, an option to quickly update the screen.
Describe the solution you'd like
Might be a refresh button in event history page.
Describe alternatives you've considered
In the previous versions auto-refresh toggle used to be a workaround, but it seems to be removed. Currently refreshing the whole page does the trick.
Additional context
None.

This is automatically refreshed when new events come in. We now poll for the history.


Remove in-code timelocks

Because the _governance address of the hatVaults contract is now set to a timelock, there is no need anymore for the internally hardcoded timelock logic.
Specifically, we will remove the following functions:
setPendingGovernance(address _newGovernance)
transferGovernorship()

And replace these with a single new function:
transferGovernance(address _newGovernance)

closed in #85


Centre align labels

Hi,
Is there a way that I can automatically centre align labels in the SpineOMatic desktop app.
Currently everything is left aligned.
I want the label to look something like this;

370.
15
DEW
Instead of having everything aligned to the left like this;
370.
15
DEW
The first two call numbers in the image are examples of how I would like the text to align when printing.

Regards,

@wolf5050, the SpineOMatic Desktop application does not provide for automatically centering the lines of the label. If you are reviewing the labels before printing, you can manually adjust the label to align as you wish.

Thanks for the feedback.
On Fri, Jun 10, 2022 at 8:36 PM mgobat @.***> wrote:

@wolf5050 https://github.com/wolf5050, the SpineOMatic Desktop
application does not provide for automatically centering the lines of the
label. If you are reviewing the labels before printing, you can manually
adjust the label to align as you wish.
—
Reply to this email directly, view it on GitHub
https://github.com/ExLibrisGroup/SpineOMatic/issues/45#issuecomment-1152633009,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCYPFIXCM2TGRT43PBTV63VOODLNANCNFSM5YCTYD7Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Disclaimer - This e-mail is subject to UWC policies and e-mail disclaimer
published on our website at: https://www.uwc.ac.za/disclaimer
https://www.uwc.ac.za/disclaimer


linux compilation crash on master : drivers/unix/os_unix_global_settings_path.gen.cpp

Operating system or device, Godot version, GPU Model and driver (if graphics related):
linux mint 18.2
gcc (Ubuntu/Linaro 6.3.0-18ubuntu2~16.04) 6.3.0 20170519
Issue description:
compiling crash (was working one week ago)
...
[ 50%] Compiling ==> drivers/unix/os_unix_global_settings_path.gen.cpp
drivers/unix/os_unix_global_settings_path.gen.cpp:3:44: error: no 'String OS_Unix::get_global_settings_path() const' member function declared in class 'OS_Unix'
 String OS_Unix::get_global_settings_path() const {
                                            ^~~~~
scons: *** [drivers/unix/os_unix_global_settings_path.gen.x11.tools.64.o] Error 1
scons: building terminated because of errors.

That's not a crash, it's an error. You just need to delete drivers/unix/os_unix_global_settings_path.gen.*.
Duplicate of #13076.

ok thanks a lot !, confirmed, working,
(will go and look to find how to better search through github issues... ;) )


Add Select component

Fixes #1691
Hi @interactivellama  ! Feedback for the initial draft would be appreciated :)
Select:
const propTypes = {
	/**
	 * Shows red borders in the input element is there is an error
	 */
	hasError: PropTypes.bool,
	/**
	 * Shows the content of the Select component.
	 */
	children: PropTypes.node.isRequired,
};

SelectContainer:
const propTypes = {
	/**
	 * The `aria-describedby` attribute is used to indicate the IDs of the elements that describe the object. It is used to establish a relationship between widgets or groups and text that described them. This is very similar to aria-labelledby: a label describes the essence of an object, while a description provides more information that the user might need.
	 */
	'aria-describedby': PropTypes.string,
	/**
	 * Every select input must have a unique ID in order to support keyboard navigation and ARIA support.
	 */
	id: PropTypes.string,
	/**
	 * Highlights the select input as a required field (does not perform any validation).
	 */
	required: PropTypes.bool,
	/**
	 * Disables the select input and prevents editing the contents.
	 */
	disabled: PropTypes.bool,
	/**
	 * Displays options in a multiple selection narrow format.
	 */
	isMultipleSelection: PropTypes.boolean,
	/**
	 * Select options.
	 */
	options: PropTypes.arrayOf(PropTypes.string),
};

Error:
const propTypes = {
	/**
	 * Message to display when the input is in an error state. When this is present, also visually highlights the component as in error.
	 */
	errorText: PropTypes.oneOfType([PropTypes.node, PropTypes.string]) /**
	 * Every label must have a unique ID in order to support keyboard navigation and ARIA support.
	 */,
	id: PropTypes.string.isRequired,
};

Some screenshots for reference below.
Base:

Required:

Error:

Disabled:

Multiple Selection Narrow:

I'll add support for Multiple Selection once #1712 is fixed.
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Initial thoughts:
label should be prop, so we can require it (or assistiveText.label if it's not visible). Please review Input component https://react.lightningdesignsystem.com/components/inputs/ and consider merging these into one component called Select.

Based on LinkedIn message with @tanhengyeow I'm going to close this pull request. Feel free to pick it back up when you have time to complete it. Thanks!


Side margin issue and toolbar overlaps

There additional margin (or padding?) on left and toolbar overlaps the body on all layouts.
Sorry for my bad english .

Ramme 3.2.2
Electron 1.7.2
darwin x64 16.6.0
macOS 10.12.5

already fixed on master


Fix issues with Node.isOptional() typings

Currently, Node.isOptional is a function returning a boolean, but the typings show it as a property, not a method. Changing it to a method would help many TypeScript users, and I'm running into issues using this function myself.

I've just published v16.3.3 containing this fix.

Thank you!

I just tried to download the latest version (v16.3.3) and it doesn't have the fix. Can you double-check that you've uploaded it?

My bad. I forgot that this file is generated from index.d.ts.template — so as soon as I ran the release, it overwrote the changes.
I just landed a proper fix and did a new release (v16.3.4)

Oops. Sorry about that! Thanks for patching it properly and being so quick to respond.


[REF] Revert tensorflow req to 1.3.0 and remove tifffile requirement

As pointed out by @perone, tensorflow might behave differently for newer versions, so we might as well stick with 1.3.0 as originally intended (although before, we had a req of >= 1.3.0, so whatever was installed at any given time was the most up to date version). I had fixed it to 1.9.0 as it was the most up-to-date version at the time (thus, the one being installed anyways). Also, the CUDA libraries installed on Rosenberg at the moment (or at least, for me as a user) aren't compatible with tensorflow versions >= 1.5.0.
Also removing the tifffile requirement. That one was added recently because imageio shouts warnings for tiffiles that it's not optimized for speed without tifffile installed (see: https://github.com/imageio/imageio/issues/350). This worked fine for me on my local (MacOSX), and on Travis tests (Linux), however when I tried installing the pip requirement on Rosenberg, C-librarie errors were thrown:

Building wheels for collected packages: tifffile
  Running setup.py bdist_wheel for tifffile ... error
  Complete output from command /home/mabou_local/venv_ads2/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-_bumnz1q/tifffile/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-b2cvauy8 --python-tag cp36:
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.linux-x86_64-3.6
  creating build/lib.linux-x86_64-3.6/tifffile
  copying tifffile/__init__.py -> build/lib.linux-x86_64-3.6/tifffile
  copying tifffile/tifffile.py -> build/lib.linux-x86_64-3.6/tifffile
  running egg_info
  writing tifffile.egg-info/PKG-INFO
  writing dependency_links to tifffile.egg-info/dependency_links.txt
  writing requirements to tifffile.egg-info/requires.txt
  writing top-level names to tifffile.egg-info/top_level.txt
  reading manifest file 'tifffile.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  warning: no previously-included files matching '__pycache__' found under directory '*'
  warning: no previously-included files matching '*.py[co]' found under directory '*'
  writing manifest file 'tifffile.egg-info/SOURCES.txt'
  copying tifffile/_tifffile.c -> build/lib.linux-x86_64-3.6/tifffile
  running build_ext
  building 'tifffile._tifffile' extension
  creating build/temp.linux-x86_64-3.6
  creating build/temp.linux-x86_64-3.6/tifffile
  gcc -pthread -Wno-unused-result -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/home/mabou_local/venv_ads2/lib/python3.6/site-packages/numpy/core/include -I/usr/include/python3.6m -c tifffile/_tifffile.c -o build/temp.linux-x86_64-3.6/tifffile/_tifffile.o
  tifffile/_tifffile.c:73:20: erreur fatale: Python.h : Aucun fichier ou dossier de ce type
   #include "Python.h"
                      ^
  compilation terminée.
  error: command 'gcc' failed with exit status 1

  ----------------------------------------
  Failed building wheel for tifffile
  Running setup.py clean for tifffile
Failed to build tifffile
Installing collected packages: tensorflow, tifffile, AxonDeepSeg
  Found existing installation: tifffile 2018.10.18
    Uninstalling tifffile-2018.10.18:
      Successfully uninstalled tifffile-2018.10.18
  Running setup.py install for tifffile ... error
    Complete output from command /home/mabou_local/venv_ads2/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-_bumnz1q/tifffile/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-kh13odk8/install-record.txt --single-version-externally-managed --compile --install-headers /home/mabou_local/venv_ads2/include/site/python3.6/tifffile:
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.6
    creating build/lib.linux-x86_64-3.6/tifffile
    copying tifffile/__init__.py -> build/lib.linux-x86_64-3.6/tifffile
    copying tifffile/tifffile.py -> build/lib.linux-x86_64-3.6/tifffile
    running egg_info
    writing tifffile.egg-info/PKG-INFO
    writing dependency_links to tifffile.egg-info/dependency_links.txt
    writing requirements to tifffile.egg-info/requires.txt
    writing top-level names to tifffile.egg-info/top_level.txt
    reading manifest file 'tifffile.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    warning: no previously-included files matching '__pycache__' found under directory '*'
    warning: no previously-included files matching '*.py[co]' found under directory '*'
    writing manifest file 'tifffile.egg-info/SOURCES.txt'
    copying tifffile/_tifffile.c -> build/lib.linux-x86_64-3.6/tifffile
    running build_ext
    building 'tifffile._tifffile' extension
    creating build/temp.linux-x86_64-3.6
    creating build/temp.linux-x86_64-3.6/tifffile
    gcc -pthread -Wno-unused-result -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/home/mabou_local/venv_ads2/lib/python3.6/site-packages/numpy/core/include -I/usr/include/python3.6m -c tifffile/_tifffile.c -o build/temp.linux-x86_64-3.6/tifffile/_tifffile.o
    tifffile/_tifffile.c:73:20: erreur fatale: Python.h : Aucun fichier ou dossier de ce type
     #include "Python.h"
                        ^
    compilation terminée.
    error: command 'gcc' failed with exit status 1

    ----------------------------------------
  Rolling back uninstall of tifffile
Command "/home/mabou_local/venv_ads2/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-_bumnz1q/tifffile/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-kh13odk8/install-record.txt --single-version-externally-managed --compile --install-headers /home/mabou_local/venv_ads2/include/site/python3.6/tifffile" failed with error code 1 in /tmp/pip-install-_bumnz1q/tifffile/

We'll just have to bear with the warnings until imageio gets updated and this issue is resolved. Warnings are only shown to users for tiff files, ans since most of our files are png, this isn't too much of a nuissance (I hope).

This warning goes away if you use Anaconda and inside a conda environment ? I really recommend using Anaconda and the conda environments on Rosenberg, it usually solves all these issues with Python sources, virtual env binaries, etc.

Coverage increased (+0.04%) to 81.369% when pulling a37103847fd7a510c4d59d6268a9d434b66a51c5 on revert_reqs into 9e59f536da6c709d0341999ae2b11945de588cb2 on master.

@perone Re: Anaconda/Conda
I completely agree – I always prefer using Anaconda + conda's venv instead of the native python venv, that's what I use on my laptop. However, the I couldn't see Anaconda/conda in my path for the environment that was setup to my new user account on Rosenberg by @alexfoias . I tried installing miniconda and using conda to create my venv, however because of my privilege limitations, it would only allow me to install my venv using the --user flag, which caused some conflict with my default python packages, hence my issue I talked about in slack. If there's a way for me to use Anaconda/conda on Rosenberg, I'd much rather do so (and we should add those instructions to the Rosenberg SOP, as it only gives instructions to use the native virtualenv command).
Re: warnings
Without tifffile installed, but using Anaconda/conda (on my laptop), these warnings appear. I can install tifffile in my conda environment on my local computer without the error that is shown in the details above. I can't install tifffile on rosenberg, which appears to be either because of a gcc linking error and/or gcc can't find Python.h.

@jcohenadad & @mathieuboudreau  I granted him access as sudo

Just an extra note: you can use the environments from conda itself (https://conda.io/docs/user-guide/tasks/manage-environments.html) instead of using virtualenvs.

i would not venture in trying to get a py3 venv from a conda2 install. I think we should just install conda3.

@jcohenadad Ok! I just know that when Anaconda 3 is installed (for me at least), you can create a virtual environment in almost any Python version available. But then yes, we should have an Anaconda3 installation available on Rosenberg to create venvs for projects using Python 3+ (like ADS in its current state).

What I usually do is:

Install conda3 like in /home/user/anaconda3;
Make sure that this path is on the PATH and not the system anaconda or other anaconda conflicting with it;
Create environment using conda itself

The error you're getting seems to be because your're using system wide conda, I think the best approach is to install your own anaconda for your user, so you can uninstall/install any package you want and it will not be in conflict with anything.

@perone thanks! I tried installing miniconda last week for my user (instead of Anaconda3), and when I tried creating an environment with conda, it said I needed to use the --user flag, which I think gave me some problems. I'll give it another shot with the full Anaconda3 package soon.
Have you done the procedure above on Rosenberg?

Yes, I installed anaconda3 on my home user folder, you can use which later to check from where your conda is being executed:
[chper_local@rosenberg ~]$ which conda
~/anaconda3/bin/conda

See that in my case, the conda comes from my anaconda3 distribution.

Cool!
Might it be better to simply have a shared anaconda3 folder that's available to all users like we have for anaconda2, since we should be working on conda virtual environments anyways? It could save on space, and the installation step for new users. I'm indifferent personally though for my own use.

actually yes, that makes sense. Let's have a global anaconda3 install (and in the SOP, mention that each new student should work under venv)

@alexfoias No I haven't, I held off since you said there might be an issue with the Anaconda2 installation re: my slack message to you. If you can do it, thanks!


Exposed stats to watchdog actions.

Signed-off-by: Kevin Baichoo<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Exposed Stats to Watchdog Actions.
Additional Description: This will allow them to create their own counters to expose for monitoring
Risk Level: low
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A?

/retest


Add CycloneDX SBOM to ortelius-ms-dep-pkg-cud

As part of the Google Cloud Build we need to generate the SBOM/SPDX files and store them somewhere for reference.  https://github.com/opensbom-generator/spdx-sbom-generator

We need to update the cloudbuild.yaml to run https://github.com/anchore/syft after the docker build has been completed. Syft should scan the docker image and produce a cyclone-dx json file.  The cyclone-dx json file should be uploaded using the existing dh updatecomp command line call. This upload is done by adding the --deppkg<EMAIL_ADDRESS>to the dh updatecomp parameters.
Update need to microservice  - ortelius-ms-dep-pkg-cud

Hi @sbtaylor15,
I have committed the changes in deploy branch.
https://github.com/ortelius/ortelius-ms-dep-pkg-cud/commit/029a64aec80caaf3ad0cb4d5066815a8e1d293de


Laying Colors.black12 on top of Colors.black scaffold

I have been unable to lay the Colors.black12 (or any variation of black) on top of a scaffold that has background of Colors.black.. i.e, the Colors.black12 does not show up when layed on top..
also bottomNavigationBar is not able to have a color passed to it when the BottomType is BottomNavigationBarType.shifting,
however when I change it to BottomNavigationBarType.fixed, the color is able to be changed

Hi @samariotorres
Can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample?
Thank you

cc @shihaohong

This isn't a bug with the framework, but maybe a misunderstanding of how to use Colors.black12.  On the other hand, if you have a different colored background, Colors.black12 will appear as the darkened version of whatever color it is laid on top of.
Maybe what you're looking for is Colors.grey, which has 100% opacity and is a color value:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      backgroundColor: Colors.black,
      body: Center(
        child: SizedBox(
          height: 100,
          width: 100,
          child: ColoredBox(
            color: Colors.grey[300],
          ),
        ),
      ),
    );
  }
}

With regards to the BottomNavigationBar.shifting usage, it's because that's the intended behavior when that style is used. See the BottomNavigationBar docs:
BottomNavigationBarType.shifting, the default when there are four or more items. If selectedItemColor is null, all items are rendered in white. The navigation bar's background color is the same as the BottomNavigationBarItem.backgroundColor of the selected item. In this case it's assumed that each item will have a different background color and that background color will contrast well with white.

We can document both of these better, since it required me diving around the documentation and experimenting to figure out exactly where this confusion is coming from. I'll create a separate issue to request showcasing dartpad samples for the default and BottomNavigationBarType.shifting expected behaviors.


chore!: migrate to Node 14

BREAKING CHANGES:

Return types should be arrays when the return type is a tuple: https://github.com/googleapis/gax-nodejs/pull/1001
The linter and libraries are now on the latest version of typescript (5.1.3) and on the latest version of prettier (>3.0.0): https://github.com/google/gts/pull/773.
Auth no longer accepts .p12 certificates: https://github.com/googleapis/node-gtoken/pull/452
Gaxios requests require content-type to be specified: https://github.com/googleapis/gaxios/pull/535
Gaxios errors now specify status and code separately: https://github.com/googleapis/gaxios/pull/552
Gax-nodejs no longer compiles protos, a new dependency called gapic-tools does that: https://github.com/googleapis/gax-nodejs/pull/1439
All libraries were upgraded to a minimum version of Node 14.

Wait to merge until this is merged first: https://github.com/googleapis/google-cloud-node/pull/4462


Language chooser ?

As you know, the http://acnhapi.com/ can display any catalog item in the correct localisation.
Would it be possible to add on option to let user choose the database language ?

For items we use a local catalog dump, which for now is english only. In the mid/long I think we'll need to localize it fully. For villagers I'll display their name in your local language if available quite soon as we have the info from acnhapi yeah :)
And for the rest of the app, the UI, anyone is welcome to do a PR do make it available :)

should be relatively easy to generate a localization from this: https://pastebin.com/B8N5KKsh.
has strings for diff languages in relation to items.

What are the preferred plans for this?
Do you prefer translation relying on Localizable.strings or by patching the JSON-files?

I’ll take a look at that a bit later, but with 5000+ items we’ll use a translated data source, I’ll just pull another json.

Maybe imthe666st/ACNH can help you here. I also wrote a short playground script to generate a Localizable.strings file.

This is perfect! Thank you so much for the repo link. With those JSON we just have to match the internal id with our datasource and done. Crazy. I'll be able to do it in no time :)

Note: We'll not use localizable.string. I'll pull the Locale from the phone, and then load the appropriate translation JSON and replace the item name with the one pulled from the file.

You're code is a great help, I'm almost done :)

Great to hear and happy to help!
The localizable approach was just the quickest and easiest way to get a prototype working. I guess patching the dataset is better, too!
As a side note: in the current data set, the first letter is capitalized, whereas in the linked one most names are lowercased in English.

Yup fixed that too, commiting in 5 minutes. You'll see, I like the approach I did. We load current localization table in memory in just query it from the Item.

https://github.com/Dimillian/ACHNBrowserUI/commit/081c8469d9f8b4c04ae336a49565967ce9f6ec01 @vknabel It's basic but it works :) So happy we could have that nailed down in so little time!

You're welcome to do adjustment as you see fit :)

Thank you very much @Dimillian. I will take a look this evening in about 9-12 hours!

Awesome that was quick ! :)

It works very well! From my perspective, this is done.
I opened #111 for a small and rare edge case. But good and blazingly fast work!

Fo items localizations data for now we have:

English
French
Japanese
Chinese
German
Russian
Spanish
Italian

Would it be possible to add on option to let user choose the database language ?

That would be great indeed. I have my phone set to English but the game is set to French. Makes it quite hard to find items 😉

Hey @Arnoud-B, you already can do that. You can set App language to a different then device language. Go to iOS settings app, scroll down to app section, select AC Helper and set language to French.
(Screenshots are German, but I think you'll get what to do)

Thanks @TheVaan. That solves it indeed, but I think most users won't go to the Settings app to find this option but instead rely on the app settings (in the app itself). Why not expose it there?

We did this because of apples localization guide lines. There are ways to build in a translation Switcher inside an app but this is often buggy (for SwiftUi). We decided to use the Apple way (introduced in iOS 13) and not to implement a buggy way. I agree it's not that easy to find but it's the way Apple wants us to do.


Ability to override TargetPlatformVersion via config.xml

Feature Request
Motivation Behind Feature

The CordovaApp.Windows10.jsproj template file has a hard-coded TargetPlatformVersion, which currently seems to be set to 10.0.10240.0:
  <PropertyGroup>
    <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
    <TargetPlatformVersion>10.0.10240.0</TargetPlatformVersion>
    <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion>
    <MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
    <UapDefaultAssetScale>100</UapDefaultAssetScale>
  </PropertyGroup>

However, when I try to build my project, which should target 10.0.15063.0, I get build failures as the wrong platform version is targeted and the SDK for this version is not available to Visual Studio:
D:\MyApp>cordova build windows --arch=x86
ENV var VSINSTALLDIR is set C:\Program Files (x86)\Programming\Microsoft Visual Studio 2017
Building project: D:\MyApp\platforms\windows\CordovaApp.Windows10.jsproj
        Configuration : debug
        Platform      : x86
        Buildflags    : /p:AppxBundle=Never
        MSBuildTools  : C:\Program Files (x86)\Programming\Microsoft Visual Studio 2017\MSBuild\15.0\Bin
buildProject spawn: C:\Program Files (x86)\Programming\Microsoft Visual Studio 2017\MSBuild\15.0\Bin\msbuild [ 'D:\\MyApp\\platforms\\windows\\CordovaApp.Windows10.jsproj',
  '/clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal',
  '/nologo',
  '/p:Configuration=debug',
  '/p:Platform=x86',
  '/p:AppxBundle=Never' ] { stdio: 'inherit' }
C:\Program Files (x86)\Programming\Microsoft Visual Studio 2017\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3): error : "
10.0.10240.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [D:\MyApp\platforms\windows\CordovaApp.Windows10.jsproj]
No valid MSBuild was detected for the selected target: Error: C:\Program Files (x86)\Programming\Microsoft Visual Studio 2017\MSBuild\15.0\Bin\msbuild.exe: Command failed with
 exit code 1

I can fix this by manually editing platforms\windows\CordovaApp.Windows10.jsproj to change this line, but I was under the impression that anything in the 'platforms' folder shouldn't be touched, as it may get replaced when building/cleaning/updating.
Feature Description

There are various settings that can be added to config.xml that look like they should influence this, but none of them seem to resolve the issue:
        <preference name="windows-target-version" value="10.0" />
        <preference name="windows-appx-target" value="uap" />
        <preference name="windows-phone-target-version" value="10.0" />
        <preference name="windows-phone-target-platform-version" value="10.0.15063.0" />
        <preference name="Windows.Universal-MinVersion" value="10.0.15063.0" />
        <preference name="Windows.Mobile-MinVersion" value="10.0.15063.0" />

I would expect that using one of these settings, or a new setting for this specific purpose, would ensure the correct build is performed.
Alternatives or Workarounds

I have been able to fix this by manually editing the file, but this doesn't appear to be a sustainable solution for the reasons given.
Other notes
I have logged this as a feature request, but it might actually be considered a bug.
The basic issue is to provide a way to tell Visual Studio to build using the correct SDK, and as there appear to be settings to control this that aren't being applied in this instance.  If the existing settings are not working as intended, this is a bug.  If this is not currently intended to be configurable, then this is a feature request.
Or, if there is already some way to achieve this that I have been unable to find via the online documentation 1, 2, then perhaps this is a documentation bug.
Config details

Cordova 8.1.2
Cordova-Windows 6.0.1
Visual Studio 2017
OS: Windows 8.1

Sounds valid.
If you want and can investigate this yourself, searching the codebase for either TargetPlatformVersion to see if something might already exist or windows-target-version (and the others) to understand how the existing preferences work would be my first steps.
We would sure appreciate any support here, otherwise this issue will probably just sit here. Thanks!

I spent some time looking through code related to that, and I think you might be looking for uap-target-min-version and windows-target-version to influence these two values.

Ok, had some time to spend on investigating this:

The CordovaApp.Windows10.jsproj template file has a hard-coded TargetPlatformVersion, which currently seems to be set to 10.0.10240.0

This value is not hardcoded, but gets filled by the maximum SDK installed on your machine when cordova prepare is run (which cordova build and cordova run do in the background):
https://github.com/apache/cordova-windows/blob/c52b81c3f6daff69b57939fcf62451d3c2a602dd/template/cordova/lib/prepare.js#L497
This means that your machine probably only had 10.0.10240.0 or no Windows SDK at all, as 10.0.10240.0 is also the default, installed.
For me the value for example is set to <TargetPlatformVersion>10.0.18362.0</TargetPlatformVersion> when running cordova platform add windows.
So installed the 10.0.15063.0 SDK should automatically replace this value.

If you also want to influence TargetPlatformMinVersion in .jsproj, then you can use <preference name="uap-target-min-version" value="10.0.15063.0" /> in config.xml.

And related, you can also realize this diff:
-        <TargetDeviceFamily MaxVersionTested="10.0.10240.0" MinVersion="10.0.10240.0" Name="Windows.Universal" />
+        <TargetDeviceFamily MaxVersionTested="10.0.15063.0" MinVersion="10.0.15063.0" Name="Windows.Universal" />

by setting this in config.xml:
        <preference name="Windows.Universal-MinVersion" value="10.0.15063.0" />
        <preference name="Windows.Universal-MaxVersionTested" value="10.0.15063.0" />

Although I am not totally sure what this achieves to be honest.

Please let me know if this helped to fix the problem for your @MarkMaldaba.

Ping @MarkMaldaba

Thanks for the ping.  It's on my list to test this, but haven't got to it yet.

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.


Update Release note 0.0.1-M5

Description:
Update the release note for APK 0.0.1-M5

Content was reviewed and added in [1]
[1] https://github.com/wso2/apk/releases/tag/0.0.1-m5


added button on press debounce support

Issue: https://github.com/project-vagabond/covid-green-app/issues/492
The current PR fixes the mentioned issue, but there are some things to consider moving forward:

how can we prevent double navigation (even with debounce/throttle)
are there any other places with fire/forget that we need to handle (in most of the cases we use the spinner)

On a slow device pressing rapidly I could still get duplicates. Did it not work to have a disabled state or ref set on the first button press and a handlePress that only calls the action if this isn't true? If useState wasn't fast enough because it waits for a re-render, a boolean useRef in the view should be instant. Another approach would be having the check in function check the check isn't already checked in instead of relying on the button.


Add Tissue Type filter to Collections and Dataset

December 2023: This feature is pended based on changes in priorities for 2024. The mitigation is that the consumer may still continue to search for "organoids" or "cell culture" in the absence of a special filter.

Context
See single-cell-four
API Response Shape:
  'tissue': [{'label': 'lung', 'ontology_term_id': 'UBERON:0002048', 'tissue_type': 'tissue'},
             {'label': 'lung', 'ontology_term_id': 'UBERON:0002048', 'tissue_type': 'organoid'],
             {'label': 'T cell', 'ontology_term_id': 'CL:0000084', 'tissue_type': 'cell culture'],

Reference

tissue_type
tissue
tissue_ontology_term_id

Design
Figma

This feature is pended based on changes in priorities for 2024. The mitigation is that the consumer may still continue to search for "organoids" or "cell culture" in the absence of a special filter.

Closing as lower priority.


Remove TextSelectionDelegate from SelectableRegionState

SelectableRegionState currently mixes in TextSelectionDelegate in order to receive text selection toolbar functionality, however, this functionality is being remove from TextSelectionDelegate in https://github.com/flutter/flutter/pull/107193.  After the deprecations in that PR are removed, it should be possible to remove TextSelectionDelegate from SelectableRegionState altogether.
Why remove TextSelectionDelegate?
TextSelectionDelegate provides functionality that is related to editing text and which SelectableRegion doesn't use (example).  Text selection should be separate from text editing.
CC @chunhtai

This should be able to be fixed in https://github.com/flutter/flutter/pull/107193# now actually.

This shouldn't have been closed with https://github.com/flutter/flutter/pull/107193.


Invariant Violation: "main" has not been registered. This can happen if: * Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.

New Version
0.69.6
Old Version
0.63.2
Build Target(s)
iOS simulator in debug/release flavor
Output of react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.2.1
CPU: (10) arm64 Apple M1 Pro
Memory: 405.17 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.16.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.11.0 - /usr/local/bin/npm
Watchman: Not Found
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8609683
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: Not Found
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.6 => 0.69.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Issue and Reproduction Steps

yarn install
yarn upgrade --latest  // at that time latest is react-native V0.69.6
yarn start
Press a │ open Android
› Press i │ open iOS simulator // iOS iPhone 8

Do follow above steps you can face this error on mobile screen while launching app, also same error on server terminal(yarn start) can be observed.
Thanks.

yarn upgrade --latest // at that time latest is react-native V0.69.6\

As you're upgrading from 0.63 to 0.69, most likely you'll have to do some manual tweaking (as there are several versions in between). Usually this command will tell you if there are manual steps to do if the update failed.
Also having a reproducer would help here.

same error here as well.
 ERROR  Invariant Violation: "APPName" has not been registered. This can happen if:
* Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
* A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called., js engine: hermes


[WFLY-18563] Update the license info for Narayana components to ASL 2

https://issues.redhat.com/browse/WFLY-18563

@mmusgrov Please review.


Helper __awaitable concept doesn't correctly handle await_transform

The coroutine semantics are such that if there is any member of the promise type declared as await_transform then the co_await expression inside a coroutine with that promise type will first call promise.await_transform().
The current concept just checks that the particular type being queried is callable with promise.await_transform(<expr>) and if that is not well-formed then it falls back to just checking if <expr> has a valid operator co_await().
This could result in incorrectly reporting that a type satisfies __awaitable<Promise> when a co_await expression with an operand of that type would be ill-formed.
e.g. The current logic would indicate that std::suspend_always satisfies the __awaitable<std::generator<int>::promise_type> concept, despite co_await expressions being ill-formed inside std::generator coroutines.
Note that it's not currently possible to exactly match the behaviour of the compiler in library alone.
There would need to be some intrinsic for asking the compiler whether a given promise type has any member named 'await_transform' declared.

I think this is an issue in the reference implementation but not in the specification. The spec basically says, "do as the compiler does" and leaves it to implementors to figure it out.

Do we want to add to P2300 the helpers get_awaitable(x, promise) or get_awaiter(awaitable) so that other libraries can use them (and also reference them ourselves)?


fix: wrong channel or messages when switching between channels fast

301be74
Need testing for bugs then it's fully finished


Update UG intro

Pull Request Test Coverage Report for Build 936

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.122%

Totals

Change from base Build 934:
0.0%

Covered Lines:
2498

Relevant Lines:
2654

💛  - Coveralls


Tool Palette should be moveable

Draggable probably, but maybe just pin to left or right

Alternatively, you could add a margin to body/html to make the page appear as if it was on an artboard and leave the tool palette fixed to the left.
I'm not sure I like that better than what you've proposed, but it's a hack I'm using on my pages that have a lot of important UI underneath the palette.

that idea has been on my mind a lot lately, especially if it was combined with #127, we would literally be creating the illusion that the page has become an artboard. hold space bar, pan around, zoom, etc. would be so sweeeeet!

seems like it would need lots of testing though, and that certain sites may fight it pretty hard..

much of this feature request is pacified for me by the ability to hide it (see #202), but i empathize and want the full feature. just wanted to share that hiding it can get it out of the way while you work, and then just bring it back if you need to change to another tool visually (without the keyboard shortcut)


access api  from android emulator

ISSUE TYPE

How to accces my api(restApi) developped with php, and deployed with  devilbox at this url  myapi.loc .
When i try to acces this adresse from my android emulator the url is not recognized.
and i dont know how to fix this issue.

please help me i am new to drocker envirennement.

SUMMARY

Goal

The easiest way to access your devilbox virtual hosts from other devices is via ngrok.

thanks very much i will try this solution

ngrok work perfectly but internet connection must be active.
if there is another solution without internet I will be grateful for you.

 But you can try something similar: https://blog.oddbit.com/post/2014-08-11-four-ways-to-connect-a-docker/

thank you very much, i will try to implement those solutions


Update Contributors.md

Add Yash Sharma to Contributors list

Hi  @Yashs744, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hii,
Tutorial made the whole process really easy. Thank you for the tutorial

@Yashs744, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

Sir, I need to ask something.
I forked a GitHub repo and made some changes and created a pull request, it opened a new pull request. But I deleted the repo from my account and again forked the repo and made changes. Now, I want to merge it into that previously created pull request. How can I do that ??

Hi @Yashs744, please don't call me sir. You can call me Roshan.
In GitHub, each pull request is associated with a branch. So in your case, as you made a new fork, I think you can't merge it with previously created pull request.
So you'll have to make those changes again and open a new pull request.

Okay Okay, Thank you


Docs v1

I wrote some documentation for the frontend and backend code. Please read it and let me know if you find any unclear parts, typos, or want more documentation.

lgtm


Reopen issue #91 "Java resource files (src/main/resources) not found when running tests"

Hi,
Issue #91 should not be closed as it has not been fixed. Please reopen it.

This should be fixed with #129 since we rely on the Android Gradle plugin's support for Java resources.


Alternative way to get Huginn running for demo/development/testing using Vagrant

Use Vagrant to get Huginn running quickly to test it out. Can also be used to develop Huginn as well.

So I will change it to make more development friends. Not sure how to go about it though, do I close this pull request and make a new one?

@tdak Thanks! You can keep pushing new commits to this pull request and you (or we) squash them before we merge it.

Updated the Vagrant file and README with suggested changes

Made the changes @dsander

Nice, what do you think about the suggestions I made about the README and foreman?


Bookmark update with notes

Linkding introduced the concept of notes, on top of description.
I'd like to be able to update a bookmark with notes.
E.g.: linkding bookmarks update --note "My __*[Markdown](https://en.wikipedia.org/wiki/Markdown)* note__" 2

FYI, this was included in the 2023.08.0 release.


deal with storing instance state

Currently atlas-osb uses a MongoDB connection to store instance state info (mapping to groupID, etc).
This ticket tracks updating the design to use Atlas itself - Realm app to store this automatically.
Do not require any external state mgmt solution.
See example: https://realm.mongodb.com/groups/5ef0b62a50fafd73a7943df6/apps/5f0efdec9f85970772c97a47/services

New work started on the statestorage-dynoproj branch.
We can use a Realm Values to store things directly in the cloud without any need for another cluster.

In code review.


Error ./schemas in ./.nuxt/druxt-schema.js

Describe the bug
When running Druxt Site against a Drupal backend that has no content types, I receive the following build error:
 ERROR  Failed to compile with 1 errors                                                                                This relative module was not found:

* ./schemas in ./.nuxt/druxt-schema.js

To Reproduce
Steps to reproduce the behavior:

Go to https://gitpod.io/#https://github.com/druxt/quickstart-druxt-site
Wait
Install Drupal in Minimal profile: cd drupal && ddev drush si minimal -y
Enable the Druxt module and setup the Druxt permission on the anonymous role.
Start Nuxt: cd nuxt && npm run dev

or https://gitpod.io#snapshot/d5279e41-d76e-4f38-b6f9-47b52230651f
See error.
Expected behavior
If no content types are setup, Druxt Schema should not error. Druxt Site should run, and have some default or debug behaviour.
Media

Your Environment (please complete the following information):
N/A
Additional context
N/A

I opted to make the error more useful, as at the moment, if you have no content types the Druxt Schema module isn't overly useful.


Refactor IndexScanner

What changes were proposed in this pull request?
After this refactoring, it's easier to revisit our deciding polices (using index or not)
I changed from chaotic if-else based(policy based) decision -> clear policy based, and maybe future -> cost based
Refactoring:

Reduce unnecessary funcs, unused fields (tryAnalysis, multiple readBehaviors, canBeOptimzied... etc)
Rename ambiguous func names like readBehavior
Make code structure more clear, intuitive. Reduce logics
Comments
Remove some logInfo, logDebug, we can provide a debug patch for debugging need of customers instead of the current way

How was this patch tested?
N/A

lgtm, the policy looks much more clear now. thanks @gczsjdy

Thanks @linhong-intel @LuciferYang !


Handle 'latest' tag not as a version rather combine it like 1.2.3 (latest)'

Hi guys
I would like to see the 'latest' tag behind the actual version.
Right now it looks like latest is a custom version.

The tag shall be configureable in my opinion. For example, I want to tag certain versions as review, so I'd use the review tag and it should display it as such in the docs.


Updates to author, VSCode compatibility

Sniper-commit of two changed files. Updated README with link to profile, updated theme with minor edits to improve conversion to VSCode theme.

thank you


Implement RowMetadata.getColumnNames()

See r2dbc/r2dbc-spi#58

SELECT N AS L FROM TEST;

Please note that JDBC historically has two similar methods in ResultSetMetaData:

getColumnLabel() that should return an alias (L in the above sample), if any, or column name otherwise;
getColumnName() that should return a real column name (N) or some replacement for it.

Because many databases don't distinguish these names their JDBC drivers return aliases (L) from both methods. H2 follows the JDBC specification strictly in this area by default and returns different names from these methods, but it can return the alias from both methods if a compatibility mode or a separate compatibility flag was set. Many people unaware about getColumnLabel() and incorrectly use getColumnName() instead of it.
io.r2dbc.spi.ColumnMetadata, however, has only one getName() method that looks like a good idea, but I cannot find in its javadoc is it equivalent of getColumnName() or getColumnLabel(). Perhaps it should really work like getColumnLabel() but it's name can create an impression that it is an equivalent of getColumnName().
io.r2dbc.h2.H2ColumnMetadata.toColumnMetadata() uses ResultInterface.getColumnName() as a source for getName() method. ResultInterface.getColumnName() returns a real column name, I think that you should use ResultInterface.getAlias() instead.

Thanks for having a look. I wasn't even aware of the distinction between labels and names. We intend to expose columns as they are represented in the result and that would be always the alias. We also need to make sure that we consistently use labels/aliases with our H2 wrapper.
@katzyn can you leave a comment at r2dbc/r2dbc-spi#58 so we can improve Javadocs before merging the PR?
Real column names seem to me only useful if the consumer is going to analyze results to rewrite a query or to find the original column names.

Based on @katzyn 's feedback, I switched to using getAlias() as of https://github.com/r2dbc/r2dbc-h2/commit/de99a012a1433e5af06355d1fa9eb9dadcc29a63.

If we have need for BOTH name and alias, then we can offer that as an extension to H2 R2DBC types.

I updated Javadocs in SPI to reflect we’re using aliases/result labels and not real column names if columns are aliased.


Will not run on Windows 10

I just downloaded and ran gCaliper-Win-x64.exe.

gcaliper.exe - Entry Point Not Found
The procedure entry point hb_font_set_variations could not be located in the dynamic link library C:\Program Files\Arakis\gCaliper\bin\libpangoft2-1.0-0.dll.
OK

Works fine on my Windows 10 with v1.2.1.


NSMutableData: Restore missing initialisers

When aligning the init() methods with Darwin in PR #1287,
converting the NSData convenience methods to designated
initialisers stopped them from being inherited by NSMutableData
as it declared its own designed initialisers.

Add in all of the missing initialisers and add tests to ensure
their presence is checked at compile time.

Fix init(data: Data) to use the correct length of the data
argument when copying the bytes.

@swift-ci please test


Bug 1808426: Release 4 3 revert install config

Reverts #470 and applies the same fix that we did for release-4.2 to ignore most events from the kube-system namespace

/assign @dmage @adambkaplan

/bugzilla refresh

/bugzilla refresh

@coreydaley is this to address the conflict we got with the cherrypick-bot?
I worry that in our z-streams we have a delta in our bug fixes that have not been fully vetted by QE.

@adambkaplan No, this is to address an install of 4.1 that has been upgraded to 4.2 and then 4.3, the install config information would not have been migrated to the infrastructures config map.

/retest

/retest

That's weird that we have to keep migration hacks from 4.1->4.2 in 4.3.
@coreydaley are you sure that we might not have the right infrastructure object in 4.3?

@dmage per this comment from @wking https://github.com/openshift/cluster-image-registry-operator/pull/470#discussion_r392454218

@coreydaley please do the revert & fix PR against master first, then backport to release-4.3

/close