why is unsloth thinking I'm doing multi gpu optimization when I'm not?

code
'''
conda activate beyond_scale_2_unsloth
'''
import torch
from datasets import load_dataset
from trl import SFTConfig, SFTTrainer
from unsloth import FastLanguageModel
from transformers import TrainingArguments
from pathlib import Path

from pdb import set_trace as st

opt_args = {
    'batch_size': 8,
    'learning_rate': 5e-2,
    'epochs': 1,
    'adam_epsilon': 1e-8,
    'weight_decay': 1e-4,
    'num_workers': 0,
    'break_early': False
}
hf_args = {'max_seq_length': 256, 'dataset_text_field': "text"}

# Set data type and device
torch_dtype = torch.bfloat16 if torch.cuda.is_bf16_supported() else torch.float32
device = torch.device(f"cuda:{0}" if torch.cuda.is_available() else "cpu")

# Load model and tokenizer using Unsloth
model, tokenizer = FastLanguageModel.from_pretrained(
    # model_name="unsloth/Qwen2-1.5B",
    model_name="Qwen/Qwen2.5-Math-1.5B-Instruct",
    max_seq_length=hf_args['max_seq_length'],
    dtype=None,  # Auto-detection for Float16/BFloat16
    load_in_4bit=False,  # Set False if not using 4-bit precision
)

model = model.to(device)
tok = tokenizer
tok.pad_token = tok.eos_token if tok.pad_token_id is None else tok.pad_token

# Add LoRA adapters, targeting only `lm_head` for fine-tuning
st()
model = FastLanguageModel.get_peft_model(
    model=model,
    r=16,  # LoRA rank
    target_modules=["lm_head"],  # Only optimize `lm_head`
    lora_alpha=16,
    lora_dropout=0,
    bias="none",
    use_gradient_checkpointing="unsloth",
)

# Load dataset
dataset = load_dataset("stanfordnlp/imdb", split="train")

# Define training configuration
training_args = TrainingArguments(
    per_device_train_batch_size=opt_args['batch_size'],
    gradient_accumulation_steps=4,
    num_train_epochs=opt_args['epochs'],
    learning_rate=opt_args['learning_rate'],
    bf16=torch.cuda.is_bf16_supported(),
    logging_steps=1,
    optim="paged_adamw_32bit",
    weight_decay=opt_args['weight_decay'],
    output_dir="./tmp",
    report_to='none'
)

# Initialize the Trainer
trainer = SFTTrainer(
    model=model,
    tokenizer=tokenizer,
    train_dataset=dataset,
    dataset_text_field=hf_args['dataset_text_field'],
    max_seq_length=hf_args['max_seq_length'],
    args=training_args,
)

# Print norms before training to check only lm_head will change
print(f'{model.model.embed_tokens.weight.norm(2)=}')
print(f'{model.model.layers[14].self_attn.v_proj.weight.norm(2)=}')
print(f'{model.model.layers[14].mlp.down_proj.weight.norm(2)=}')
print(f'{model.lm_head.weight.norm(2)=}')

# Start training
trainer.train()

# Print norms after training to verify only lm_head changed
print(f'{model.model.embed_tokens.weight.norm(2)=}')
print(f'{model.model.layers[14].self_attn.v_proj.weight.norm(2)=}')
print(f'{model.model.layers[14].mlp.down_proj.weight.norm(2)=}')
print(f'{model.lm_head.weight.norm(2)=}')

print("Done!\a")

but I'm only doing 1 gpu a100...
(beyond_scale_2_unsloth) brando9@ampere1~/beyond-scale-2-alignment-coeff $ python /lfs/ampere1/0/brando9/beyond-scale-2-alignment-coeff/experiments/bm/2024/11_november/week_4_8/train_unsloth_head_qwen2.py
🦥 Unsloth: Will patch your computer to enable 2x faster free finetuning.
==((====))==  Unsloth 2024.10.7: Fast Qwen2 patching. Transformers = 4.46.1.
   \\   /|    GPU: NVIDIA A100-SXM4-80GB. Max memory: 79.138 GB. Platform = Linux.
O^O/ \_/ \    Pytorch: 2.5.1+cu124. CUDA = 8.0. CUDA Toolkit = 12.4.
\        /    Bfloat16 = TRUE. FA [Xformers = 0.0.28.post3. FA2 = True]
 "-____-"     Free Apache license: http://github.com/unslothai/unsloth
Traceback (most recent call last):
  File "/lfs/ampere1/0/brando9/beyond-scale-2-alignment-coeff/experiments/bm/2024/11_november/week_4_8/train_unsloth_head_qwen2.py", line 29, in <module>
    model, tokenizer = FastLanguageModel.from_pretrained(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lfs/ampere1/0/brando9/miniconda/envs/beyond_scale_2_unsloth/lib/python3.11/site-packages/unsloth/models/loader.py", line 332, in from_pretrained
    model, tokenizer = dispatch_model.from_pretrained(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lfs/ampere1/0/brando9/miniconda/envs/beyond_scale_2_unsloth/lib/python3.11/site-packages/unsloth/models/qwen2.py", line 87, in from_pretrained
    return FastLlamaModel.from_pretrained(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lfs/ampere1/0/brando9/miniconda/envs/beyond_scale_2_unsloth/lib/python3.11/site-packages/unsloth/models/llama.py", line 1645, in from_pretrained
    raise RuntimeError('Unsloth currently does not support multi GPU setups - but we are working on it!')
RuntimeError: Unsloth currently does not support multi GPU setups - but we are working on it!

Hm that is very weird - is this like a machine with multiple cards - could you try nvidia-smi

(beyond_scale_2) @.***~/beyond-scale-2-alignment-coeff $ nvidia-smi
Tue Nov  5 08:57:13 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.54.14              Driver Version: 550.54.14      CUDA Version: 12.4     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA A100-SXM4-80GB          On  |   00000000:07:00.0 Off |                    0 |
| N/A   54C    P0            223W /  400W |   75448MiB /  81920MiB |     97%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   1  NVIDIA A100-SXM4-80GB          On  |   00000000:0A:00.0 Off |                    0 |
| N/A   43C    P0             89W /  400W |   31490MiB /  81920MiB |     88%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   2  NVIDIA A100-SXM4-80GB          On  |   00000000:44:00.0 Off |                    0 |
| N/A   31C    P0             68W /  400W |    1031MiB /  81920MiB |      0%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   3  NVIDIA A100-SXM4-80GB          On  |   00000000:4A:00.0 Off |                    0 |
| N/A   60C    P0            297W /  400W |   31514MiB /  81920MiB |     84%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   4  NVIDIA A100-SXM4-80GB          On  |   00000000:84:00.0 Off |                    0 |
| N/A   38C    P0             97W /  400W |   23790MiB /  81920MiB |     31%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   5  NVIDIA A100-SXM4-80GB          On  |   00000000:8A:00.0 Off |                    0 |
| N/A   37C    P0            105W /  400W |   71724MiB /  81920MiB |     96%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   6  NVIDIA A100-SXM4-80GB          On  |   00000000:C0:00.0 Off |                    0 |
| N/A   52C    P0            269W /  400W |   31518MiB /  81920MiB |     85%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   7  NVIDIA A100-SXM4-80GB          On  |   00000000:C3:00.0 Off |                    0 |
| N/A   55C    P0            237W /  400W |   60673MiB /  81920MiB |     88%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|    0   N/A  N/A    412907      C   python                                       1018MiB |
|    0   N/A  N/A   2531149      C   python                                      74416MiB |
|    1   N/A  N/A      3611      C   ...nqduc/miniconda3/envs/lf/bin/python      30540MiB |
|    1   N/A  N/A   1534976      C   python                                        908MiB |
|    2   N/A  N/A   4165148      C   python                                       2482MiB |
|    3   N/A  N/A   2201035      C   python                                        848MiB |
|    3   N/A  N/A   4140397      C   ...nqduc/miniconda3/envs/lf/bin/python      30624MiB |
|    4   N/A  N/A   2174832      C   ...iconda3/envs/ampere1-env/bin/python       9328MiB |
|    4   N/A  N/A   2737509      C   python                                      14412MiB |
|    5   N/A  N/A    119688      C   python                                      43242MiB |
|    5   N/A  N/A    124733      C   python                                      28468MiB |
|    6   N/A  N/A    111759      C   ...nqduc/miniconda3/envs/lf/bin/python      30548MiB |
|    6   N/A  N/A   1488814      C   python                                        928MiB |
|    7   N/A  N/A   3185003      C   python                                      60650MiB |
+-----------------------------------------------------------------------------------------+
The error was also non-deterministic. I changed nothing of my code and then it went away (at least for 1 run). I didn't try again afterwards given lm_head wasn't lora-able but def non-deterministic. Let me know how I can help. I think I attached the code.

On Nov 5, 2024, at 2:03 AM, Daniel Han @.***> wrote:
Hm that is very weird - is this like a machine with multiple cards - could you try nvidia-smi
—
Reply to this email directly, view it on GitHub https://github.com/unslothai/unsloth/issues/1240#issuecomment-2456743639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOE6LRFOPKDPTBSJMSVXKDZ7CJYNAVCNFSM6AAAAABRFTUK7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWG42DGNRTHE.
You are receiving this because you authored the thread.

I encountered the same issue on a single machine with multiple GPUs. I used os.environ["CUDA_VISIBLE_DEVICES"] = "1" at the beginning of the code to set a single GPU, but sometimes it throws the following error:

RuntimeError: Unsloth currently does not support multi GPU setups - but we are working on it!

Without changing any code, rerunning it sometimes succeeds and sometimes fails.
I believe this issue is the same as #983, and I hope it can be fixed as soon as possible.


Roll engine to a4abfb

Manual engine roll for a4abfb2333afe16675db0709d18a6e918b0123da Text inline widget LibTxt/dart:ui implementation (#8207)

Autoroll merged. Closing!


sqlite wasm support?

I have a Chrome extension that uses PouchDB that I'd love to use Mycelite with instead. Are there any plans to support sqlite wasm for browsers?

https://sqlite.org/wasm/doc/trunk/index.md
SQLite can run in-browser with emscripten as it provides I/O emulation syscalls.
I don't know a lot about SQlite, it's extension system, or this codebase, but since this extension is written in rust and interacts with a file system I would bet getting it into web assembly would take some heavy work or waiting until wasix(https://wasmer.io/posts/announcing-wasix) is more polished and ready for the web.
I almost guarantee that it is in the plans, but I'll follow this issue to hear from someone more knowledgeable about what the plans may look like.
Thanks for your work on this project :)

@beaugunderson This is an area of interest for us, but we don't have active plans at this time.


Add login context with simple form page

related to #897

I'm converting this PR to draft, as it's not ready yet

Can you have a look plz @seraphinandrieux ?
I'll do the same when possible

@matthieuRioual : can it be closed in favor of https://github.com/jhipster/jhipster-lite/pull/1759 ?


correct rst to improve pypi documentation

The current (long description) documentation does not render correctly on pypi (or on warehouse). This change removes the elements in the restructured text that were causing the render to fail, and has the side effect of adding syntax coloring

Hard to argue with that =). Thanks!


another one for tags

Was trying to download and that seems to require including the tags now as well, see http://support.oneskyapp.com/discussions/problems/428-400-badrequest

Can I check on this one,
the error occurs if and only if you've specified a custom tag?
I'd assume that not specifying a tag would be equivalent to saying "all tags"

As I said, if you don't specify a tag, it's "Default". I don't know whether the same tag is used when downloading. It's not "all tags" unfortunately (as I assumed as well).
Anyway, when importing a .po file or so will tag the strings with the filename...

@mreinsch ok, sorry I misunderstood your link.
I thought it said "its a 400 because you didnt specify a tag".
But the i18n gem is already using this api call without this problem.
I think the patch is good.
I think I'll hold off on a release for a few days though
see if you find anything else
thanks for your time.


Replace color-picker and fix color selection issue.

Using this way, no need to set any default values as discussed.

Need to discuss this more with you.


[features] add pool crate feature

Related discussion: #187

Looks good, thanks for opening this PR 👍
Just to confirm: You are mostly interested in having access to the PoolableConnection trait for your third party connection type, right?

Thanks for the quick review and merge.
Yes the PoolableConnection trait is essential for both my connection type and my pooling type. With it my connection type can use pooling feature from diesel-async like bb8 and deadpool. And at the same time my pooling type can use connection type from diesel-async as AsyncPgConnection and AsyncMySqlConnection.
Other public types and trait from pooled_connection are good to have for keeping a consistent api setup but they are not must keeping as public.


feat: add support for svelte

Summary
Add out-of-box support for svelte framework.

[x] implement plugin @rsbuild/plugin-svelte
[x] add e2e tests
[x] document start up guide
[x] add svelte templates to create-rsbuild

Related Issue

close #26
Checklist

[ ] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

All set now, @chenjiahan please take a look ;)
Here are some TODOs left, I'll create separate issues to follow up:

Support to configure compilerOptions of svelte-loader through the options of @rsbuild/plugin-vue
Add more e2e test cases to cover different languages (typescript / less / scss) in .svelte file

A big step for the Rsbuild + Svelte community! 🎉🎉


remove conditions that are always true or false

Thanks.  The one in quickfix.c I'm not so sure about, I'll leave it out.

Hi,
On Tue, Mar 22, 2022 at 1:37 PM Bram Moolenaar @.***>
wrote:

Thanks. The one in quickfix.c I'm not so sure about, I'll leave it out.
The check for a valid qi->qf_curlist in quickfix.c is needed as the
quickfix list can be
modified when opening the buffer by an autocmd. So this change cannot be
applied.

Regards,
Yegappan

@yegappan I've stared at the quickfix code for 10 minutes and I don't get it. qi doesn't seem to be used in the function (except for comparisons), how can it change? Mind giving me a quick hint?

Hi,
On Wed, Mar 23, 2022 at 3:51 AM dundargoc @.***> wrote:

@yegappan https://github.com/yegappan I've stared at the quickfix code
for 10 minutes and I don't get it. qi doesn't seem to be used in the
function (except for comparisons), how can it change? Mind giving me a
quick hint?

The quickfix list can be changed from an autocmd. For example, the
following commands
will make the condition in that if statement false:
:cexpr ""
:autocmd BufEnter *.c colder
:vimgrep buf_T *.c
For other conditions in that if statement, you can replace 'colder' with
'call setqflist([], 'f')'
and 'call setqflist([], 'r').
Regards,
Yegappan

Dear lord, how do you even keep track of that?  O_O
Anyway, I understand now. Thanks for the help.

Hi,
On Wed, Mar 23, 2022 at 11:53 AM dundargoc @.***>
wrote:

Dear lord, how do you even keep track of that? O_O

Over a period of time, based on the bug reports (fuzzy tests) and the new
tests, several
mechanisms were added to detect these race conditions.

Use is_qf_entry_present() to make sure the current entry is still
present in
the quickfix list.
Use qf_changedtick to detect that the entries are not modified in the
quickfix list.
Use the quickfix list identifier to make sure the list is still present
and is present
at the correct index in the stack.
Use quickfix_busy to postpone the removal of location lists.
Use the qf_delq to queue all the location list delete requests and
process them
when it is safer.

Regards,
Yegappan

Anyway, I understand now. Thanks for the help.


Selector for @ContentChild/@ContentChildren

Hi!
It looks like @ContentChild/@ContentChildren doesn't support common selectors like .my-class my-element, [my-attribute]. And selector find only elements like this <my-element #selector></my-element>.
Is it OK, or will be fixed in future?

@ContentChild() and @ViewChild() are not supposed to allow querying for arbitrary elements.
It has to be statically known which one it queries for. Class and attribute selectors don't match this criteria.
Just add a template variable to the elements you want to query for, and query for that instead.

div1

div2

@ViewChild('myTmpl') QueryList<Element> divs;

To query for arbitrary elements, you can inject Element (Angular 4) or ElementRef (Older Angular versions) and use
Element hostElement;
MyComponent(this.Element);
hostElement.querySelector('.my-class');

Thanks! Now it's clear for me.
Do you have plans to add this info in documentation?

@ranquild @aeter @ilfa any comment what you don't like about my above comment?

It looks not good that <ng-content> and @ContentChildren use different mechanics for item selection.

@zoechi It seems to me that querySelector can introduce side effects and it is better to avoid it in SPA as much as possible.

@zoechi I think angular must move towards to dynamic api creation components wherever it could be happened. And not rely on render once component tree structure.

@Aetet sounds to me like you are looking for something different than Angular ;-)

@zoechi virtual dom now helps resolve all issue with dom representation. It optimize operation with large collections out of the box. Also it helps to use composition more often and bring new effectiveness to create community reusable components.

AngularDart has no plans to implement or use virtual-dom.


New APIs for Bastion

Latest improvements:
Included new APIs for BastionShareableLink and SessionManagement

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

@DarkKnightAnk, could you take a look at all the check errors?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@lirenhe I have fixed all the issues that were there. The build seems to have timed out. Is there a way to re run it?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk


Temporary credentials

You don't have to always use a specific user's AWS credentials to talk to AWS services.  Instead, you can use temporary credentials.  These come in a couple varieties.  I've found the ones made available as part of EC2 IAM roles to be the most useful.
I have code to extract the credentials and security token for a given role from the metadata page that's available to EC2 instances.  Because they're temporary, however, they do expire, and the obvious way to implement them allows for a race condition where a request to retrieve a new token happens after a request to a service with an expired token.  The correct implementation requires that AWSCredentials gain get_temporary_secret_key and get_temporary_security_token methods that return Deferreds that fire after a refresh request has completed.  This will require that callers use maybeDeferred.
It'll be a big change but it makes deploying code to EC2 instances much easier.

This will require that callers use maybeDeferred.

Where would this be?  It's typically possible to avoid forcing maybeDeferred on users by internally handling the synchronous case with succeed and/or fail.


Fix regression from chat messages referring to compendium items

As far as I know, they only print red in the console, but better not print that at all.

What's the regression?

Foundry complains that you can't use fromUUIDSync on compendium items. It was an issue introduced recently after uuid lookups became a feature (before it wouldn't return anything).


Revert "feat(cerst): Adds MRCResyncInterval (#5195)"

This reverts commit 6fc993bec81dc172f0c34763882f19780e8a4744.

Description:
Reverts: https://github.com/openservicemesh/osm/pull/5195 based on https://github.com/openservicemesh/osm/pull/5195#discussion_r999775665
This change ends up resulting in the log message the specified resyncPeriod 2m30s is invalid because this shared informer doesn't support resyncing.
I tested it out and the base informer needs to have a resync enabled (aka a value > 1s) otherwise it resync is disabled. https://github.com/kubernetes/client-go/blob/c81636cd4415f0858a99c2cc18023740df7aa15f/tools/cache/shared_informer.go#L516-L524
We've been running without resyncs in https://github.com/openservicemesh/osm/pull/5201 without resync and this was initially needed for time based changes, which is a different direction then we ended up with.
Can revisit later if required.

Testing done:

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

@jsturtevant you may need to re-push; looks like DCO didn't run and it's holding the status checks up

@keithmattix I think we are good to go now


DalliError: Response error 6: Incr/decr on a non-numeric value

Currently experiencing DalliError: Response error 6: Incr/decr on a non-numeric value error in the application.

Rails v - 3.2.18
Ruby - ruby-2.3.3
dalli - 2.7.2

@ParthivSavani4582 I'm not sure what you're passing in to the incr/decr.  Have you confirmed that it's actually a numeric value?
I need a lot more context here.  Thanks!

@ParthivSavani4582 I'm going to close this issue out. If you can confirm you got this error and the value was actually numeric, please open a new issue with more details. Thank you!


Support all upstream basic types

Verify through tests that all basic types upstream are supported. Feel free to make a list to keep track of the progress below

[ ] Basic type 1
[ ] Basic type 2
[ ] ...

Status:

[x] String
[x] Integer
[x] Number
[x] Bool
[x] Date
[ ] DateTime


DOC: Doc for mannwhitneyu in stats.py corrected

The old documentation was still for 0.16.1. I have updated it so that it now matches the changes in scipy 0.17.
No change was made to the code.

@@            master   #6034   diff @@
======================================
  Files          238     238
  Stmts        43829   43829
  Branches      8215    8215
  Methods          0       0
======================================
  Hit          34258   34258
  Partial       2603    2603
  Missed        6968    6968

Review entire Coverage Diff as of 1a176cf

Powered by Codecov. Updated on successful CI builds.

It'd be ideal to finish up gh-4933 and deprecate mannwhitneyu. In the meantime, LGTM. Thanks @thomas-haslwanter


labor versus labour

Related to #2691
Any MP term that contains the word labor in it should have a synonym that replaces labor with labour.
respiratory distress (labored breathing)
early parturition (preterm labor)

Done!


change capitalization of daemon name

Update NPD daemon name to sentence case (Node Problem Detector).

Related to #24772.

Related to #24772.

/assign

/assign

@karan , Would you have time to look over these changes?

@karan , Would you have time to look over these changes?

/lgtm
Thanks for the follow up

/lgtm
Thanks for the follow up

Great job! Verified that new updates are correct and render properly!
/lgtm
/approve

Great job! Verified that new updates are correct and render properly!
/lgtm
/approve


with-reasonml: use default exports

Here is a suggestion for the ReasonML example to remove the js files for pages, which basically just wrap a default export.
ReasonML enables ES6 default exports so that's done here, but this way we have to use the lib/js directory the bucklescript compiler targets. I think it's a very acceptable tradeoff in this example.

Looks good to me

Hi @rase- Thanks for working on improving the with-reasonml example over the past few days.  Some good stuff!
Quick question... with the new pattern from this PR are you able to call getInitialProps from ReasonML pages?  I was using the old pattern in the .js file like this:
import { jsComponent as About } from "./About.re";

About.getInitialProps = async (context) => {
  // code here
};

export default () => <About />

It is good to be able to avoid the extra .js file if possible with your change but not sure how to call getInitialProps in that case.

@tmepple Sure, you just have to do a little bit of hackery, similarly to how you'd have to do it with the separate JS file. Here's a quick example of how you could go about it (as a diff to the About page):
diff --git a/examples/with-reasonml/pages/about.re b/examples/with-reasonml/pages/about.re
index f104565..27c4db4 100644
--- a/examples/with-reasonml/pages/about.re
+++ b/examples/with-reasonml/pages/about.re
@@ -1,13 +1,24 @@
 let component = ReasonReact.statelessComponent("About");

-let make = (_children) => {
+let make = (~a, ~b, _children) => {
   ...component,
   render: (_self) =>
     <div>
       <Header />
       <p> (ReasonReact.stringToElement("This is the about page.")) </p>
+      <p> (ReasonReact.stringToElement(a)) </p>
+      <p> (ReasonReact.stringToElement(b)) </p>
       <Counter />
     </div>
 };

-let default = ReasonReact.wrapReasonForJs(~component, (_jsProps) => make([||]));
+let default = ReasonReact.wrapReasonForJs(~component, (jsProps) => make(~a=jsProps##a, ~b=jsProps##b, [||]));
+
+let getInitialProps = () => {
+  Js.Promise.make ((~resolve, ~reject as _) => {
+    resolve(.{"a": "test", "b": "b" });
+  })
+};
+
+let inject = [%bs.raw {| (cls, fn) => cls.getInitialProps = fn |}];
+inject(default, getInitialProps);

That said, I'm trying to explore some ways of doing this in a cleaner way as a wrapper on top of ReasonReact which I'll share when I get there. In the meantime, the above is a similar trick to injecting to the imported component class in the JS file.


Implement Default state when Projecter is without Power

When the Projector is powered off and I reset my HA Instance, the Integration fails to start.
And I cannot get it to work without powering on the PJ and resetting HA.
Maybe implement a ping if the IP is reachable, if not update with a "not connected" state and skip the rest.

`Log Details (ERROR)
Logger: homeassistant.components.remote
Source: custom_components/jvcprojector/remote.py:62
Integration: Remote (documentation, issues)
First occurred: 14:11:39 (1 occurrences)
Last logged: 14:11:39
Error while setting up jvcprojector platform for remote
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 79, in __connect
jvc_sock.connect((self.host, self.port))
OSError: [Errno 113] Host is unreachable
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 59, in init
self._send_command(Commands.nullcmd)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 149, in _send_command
jvc_sock: socket.socket = self.__handshake()
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 106, in __handshake
jvc_sock = self.__connect()
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 93, in __connect
jvc_sock = self.__connect(retry + 1)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 93, in __connect
jvc_sock = self.__connect(retry + 1)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 93, in __connect
jvc_sock = self.__connect(retry + 1)
[Previous line repeated 8 more times]
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 96, in __connect
raise JVCCannotConnectError(
jvc_projector_remote.jvccommands.JVCCannotConnectError: Could not establish connection to projector
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 250, in _async_setup_platform
await asyncio.shield(task)
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/jvcprojector/remote.py", line 36, in setup_platform
JVCRemote(name, host, password, port, delay, timeout, retries),
File "/config/custom_components/jvcprojector/remote.py", line 62, in init
self._jvc = JVCProjector(host, password, port, delay, timeout, retries)
File "/usr/local/lib/python3.10/site-packages/jvc_projector_remote/jvcprojector.py", line 61, in init
raise JVCConfigError(
jvc_projector_remote.jvccommands.JVCConfigError: Couldn't verify connection to projector at the specified address: <IP_ADDRESS>:20554. Make sure the host and port are set correctly and control4 is turned off in projector settings`

Correct, no Power at all, I use a APC PDU and control it with SNMP.
So If I don't watch something, the outlet is disabled and the PJ is not in Standby.
If the PJ is in Standby then everything works as expected.


Integrated terminal truncated

Hi,
Sorry if this has been already reported, but I haven't found it.
The lines inside the integrated terminal are truncated, as shown in the screenshot below :

It happens with the "terminal" tab, works for regular terminal or tasks (tsc --watch) :

I just passed to Kubuntu 18.04, before I was on 16.04 and there were no problems

VSCode Version: 1.26.1
OS Version: Kubuntu 18.04.1

Steps to Reproduce:

Open VSCode
Open "terminal" tab and write anything

Does this issue occur when all extensions are disabled?: No

I tried to change font / line size; it doesn't change anything to the problem

Duplicate https://github.com/Microsoft/vscode/issues/35901


Reading port from env

Since #374, the port number is no longer read from process.env.PORT (then fallback to 5000).
Any chance to bring it back? I guess should modify serve.js:133.

PR #434 is fixing this.

https://github.com/zeit/serve/pull/434


change win32 dependence from pypiwin32 to pywin32

Please consider changing the win32 dependency from pipywin32 to pywin32.
I was researching TUI libraries, especially asciimatics, after learning about it from local peer.  Part of that was looking at the dependencies.
The pypiwin32 dependency is declared here:  https://github.com/peterbrittain/asciimatics/blob/master/setup.py#L73.  This appears to date back to 2015.
Googling this dependency to learn about it, I think it may be preferable to change this to pywin32.  Googling showed:

pypi.org has Feb 26, 2018 as latest for pypiwin32.  pypi.org has Jun 13, 2020 as latest for pywin32.

Looks like circa 2016 pypiwin32 was an offered repackaging of pywin32 to use wheels.  [1]

Looking at pypi today for pywin32, it appears to use only wheels.  [2]

[1] https://mail.python.org/pipermail/python-win32/2016-October/013786.html
[2] https://pypi.org/project/pywin32/#files
I suspect pypiwin32 was a workaround for a problem that no longer exists.  If that is so, then replace the pypiwin32 dependency in setup.py with pywin32.
One workaround may be to wrangle pip to install asciimatics without installing pypiwin32.  (99% sure this can be done, but need to look it up in the pip documentation.)
Related but similarly dated # 111.
Thanks!

Seems like a reasonable change...  Want to do the honours?

Sure.  I can generate a pull request with the pypiwin32/pywin32 replacement in the 4 files it appears in:

setup.py
README.rst
doc/source/intro.rst
appveyor.yml

I'll try the pip wrangling workaround first per whatever the project has for test.

OK if I don't try appveyor first?  Seems safe to skip.
Also, looks like appveyor is pointing to a Dec 2014 version "python.exe -m pip install pypiwin32==219".  Latest is Feb 2018 per pypi.
Prefer to point to specific version of pywin32 in appveyor.yaml (228) or prefer to not specify (use latest)?

Thanks.
The pinning was to fix a build issue with pywin32.  Happy to remove the pinning if it now works on the latest version.

Did a bit of pre-implementation testing.  Far from thorough, but enough to give confidence.

Windows 10
cloned asciimatics --> 62a7c89
found that I couldn't selectively prevent installation of dependencies with pip
installed some (but probably not all) of the base/dev dependencies with pip:  nose, mock, future, pyfiglet, pillow
py -3 -m nose --> 132 tests skip 6 fail 1 --> "check that wait_for_input delays as requested when no input"
ran a few of the samples which looked OK

Looks good.  Thanks.


Utils test/calendar

Date: 3 feb, 2024

Developer Name: Tejas

Issue Ticket Number

#1097

Description
This PR consist of test cases written for three utils funtion of calendar that is getStartOfDay, getDatesInRange, processData.

Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[x] Yes
[ ] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[x] Yes
[] No

Screenshots
NA
Test Coverage

File
% Stmts
% Branch
% Funcs
% Lines
Uncovered Line #s

userStatusCalendar.ts
63.33
80
57.14
62.06
31, 52-69

Test Suite Summary

Test Suites: 1 failed, 100 passed, 101 total
Tests: 452 passed, 452 total
Snapshots: 0 total
Time: 59.632 s

getStartOfDay Tests

Valid Dates: Verifies if the function correctly returns the start of the day for valid dates.
Middle Time: Checks if the function handles dates with middle time correctly.
End of Day: Ensures the function works for dates with end-of-day time.
Invalid Dates: Validates that the function gracefully handles invalid dates.

getDatesInRange Tests

Date Range: Verifies if the function generates an array of Unix timestamps for each day within a given date range.
Single Day Range: Checks if the function handles a single-day range, resulting in one element in the array.
One Day Range: Ensures the function works for a day with a one-day range, having two Unix timestamps in the array.
Middle of the Time: Validates the function's behavior for dates with middle-of-the-time, including edge dates.
Invalid Range: Checks if the function handles an invalid date range, returning an empty array.

processData Tests

Null itemId: Tests if the function returns empty objects for a null itemId.
No Matching Log: Ensures the function returns empty objects when there is no matching log for the provided itemId.
Log with No Data: Validates the function's behavior when the log has no data.

Additional Notes

Can you add test coverage stats like branch and line coverage

Done adding the data you asked for, please check now.


Update mentionPrefixOnly.ts

Fix Property 'send' does not exist on type 'PartialGroupDMChannel', by casting as TextChannel.

I am not a maintainer or anything, so I don't want to like like I am. However, I have a PR for resolving these issues here: https://github.com/sapphiredev/examples/pull/228. It is a draft because we are awaiting new versions of Sapphire packages.

I am not a maintainer or anything, so I don't want to like like I am. However, I have a PR for resolving these issues here: #228. It is a draft because we are awaiting new versions of Sapphire packages.

Ah, did not see that before hand. Sorry about that, will close this one in that case.


Feature request: choose in which folder to open a terminal

in VS Code, when I have multiple projects open (meaning multiple top-level folders) and I open an integrated terminal, I get a dropdown menu (which here would be Juno.selector I guess) asking me on which of my top-level folder I want to open the terminal.
I find this feature useful as I switch pretty often from one project to another and I generally need to have the integrated terminal in the correct folder.
If this can be implemented in Juno as well, I think it'd be a nice addition.

Implemented on master (together with Terminals remembering their cwd after an Atom restart).


Add documentation of the LabelMaps in the README.md file

The LabelMap class should be documented in the README.md
Long term, I think we should revisit Issue #9 and move away from README documentation.

Long term, I think we should revisit Issue #9 and move away from README documentation.

Strongly agree! I can help outline the process if you or someone else has time to work on this.


Remove util patch

This dependency is used by both walletLink and torus, tried voting with both - works well with no error


Fix auto required

Looks like some forms automatically gives errors on page render, should be changed to either on post on or exit?

Beeing worked on in #1025


Verification Email

hi everyone is verification email already supported?
when i sign up i didn't received any email
thanks

As far as i know this is not supported by the open Parse server. You need a mail server connected to it in order to work, so i guess this has to be done manually.
my 2cents

thank you very much


QA| court staff_mark as sent not working for warrent .

https://jam.dev/c/c3bcc9e8-ffb4-4900-812d-e6f1940ff786

response:
{
"ResponseInfo": null,
"Errors": [
{
"id": null,
"parentId": null,
"code": "Error updating task",
"message": "Error occurred while updating task: null",
"description": null,
"params": null
}
]
}
curl:
curl 'https://dristi-kerala-qa.pucar.org/task/v1/update?tenantId=kl'
-H 'accept: application/json, text/plain, /'
-H 'accept-language: en-US,en;q=0.9'
-H 'content-type: application/json;charset=UTF-8'
-H 'origin: https://dristi-kerala-qa.pucar.org'
-H 'priority: u=1, i'
-H 'referer: https://dristi-kerala-qa.pucar.org/digit-ui/employee/orders/Summons&Notice'
-H 'sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "Google Chrome";v="128"'
-H 'sec-ch-ua-mobile: ?0'
-H 'sec-ch-ua-platform: "Linux"'
-H 'sec-fetch-dest: empty'
-H 'sec-fetch-mode: cors'
-H 'sec-fetch-site: same-origin'
-H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'
--data-raw '{"task":{"id":"bb9aaf48-51eb-43c4-980e-3f217bd8dd59","tenantId":"kl","orderId":"f109e4ee-4927-459f-8ef6-b9688f467ec4","filingNumber":"KL-000039-2024","taskNumber":"KLKM520000232024-TK8","cnrNumber":"KLKM520000232024","createdDate":1727966046550,"dateCloseBy":0,"dateClosed":0,"taskDescription":null,"taskType":"WARRANT","taskDetails":{"caseDetails":{"year":null,"courtId":"KLKM52","caseTitle":"Kashish lit vs First Name ","judgeName":"John Koshy","hearingDate":null},"warrantDetails":{"surety":1,"docType":"ARREST","issueDate":1727966046343,"docSubType":"BAILABLE","bailableamount":"67","caseFilingDate":1727963156178},"deliveryChannels":{"fees":"","name":"","email":"","phone":"","status":"","address":"","feesStatus":"","channelName":"Police","statusChangeDate":""},"respondentDetails":{"age":"","name":"First Name","email":"","phone":"","gender":"","address":{"city":"Inchoor","state":"Kerala","pincode":"686691","district":"Ernakulam","locality":"2JMR+8G","coordinates":{"latitude":"10.033359026066083","longitude":"76.64127119999999"}}}},"amount":{"id":"6c26430c-a4df-4420-b1a0-9e5ba872f8b3","amount":"0","type":"FINE","paymentRefNumber":null,"additionalDetails":null,"status":"DONE"},"status":"ISSUE_WARRANT","assignedTo":null,"isActive":false,"documents":[{"id":"b44ccb2d-bde4-4b3f-802d-472288159749","documentType":"SIGNED","fileStore":"27606be5-2372-498d-be96-6e4b63f6ec10","documentUid":"b44ccb2d-bde4-4b3f-802d-472288159749","additionalDetails":null}],"additionalDetails":null,"auditDetails":{"createdBy":"cc91d677-5ab2-4bea-96ff-a07a299f0d6b","lastModifiedBy":"bb6bbcca-b005-4264-915f-2e329c5c177b","createdTime":1727966046549,"lastModifiedTime":1727967012161},"workflow":{"action":"SEND","documents":[{}]}},"RequestInfo":{"apiId":"Rainmaker","authToken":"cc5722f2-9f44-440d-97c8-02e53db455f4","userInfo":{"id":96,"uuid":"bb6bbcca-b005-4264-915f-2e329c5c177b","userName":"bhuviCourtStaffQa","name":"super","mobileNumber":"1002335566","emailId":null,"locale":null,"type":"EMPLOYEE","roles":[{"name":"HEARING_VIEWER","code":"HEARING_VIEWER","tenantId":"kl"},{"name":"DEPOSITION_EDITOR","code":"DEPOSITION_EDITOR","tenantId":"kl"},{"name":"WORKFLOW_ABANDON","code":"WORKFLOW_ABANDON","tenantId":"kl"},{"name":"Workflow Admin","code":"WORKFLOW_ADMIN","tenantId":"kl"},{"name":"APPLICATION_CREATOR","code":"APPLICATION_CREATOR","tenantId":"kl"},{"name":"COURT_ROOM_MANAGER","code":"COURT_ROOM_MANAGER","tenantId":"kl"},{"name":"DEPOSITION_PUBLISHER","code":"DEPOSITION_PUBLISHER","tenantId":"kl"},{"name":"TASK_APPROVER","code":"TASK_APPROVER","tenantId":"kl"},{"name":"HEARING_START","code":"HEARING_START","tenantId":"kl"},{"name":"HEARING_APPROVER","code":"HEARING_APPROVER","tenantId":"kl"},{"name":"APPLICATION_RESPONDER","code":"APPLICATION_RESPONDER","tenantId":"kl"},{"name":"SUBMISSION_RESPONDER","code":"SUBMISSION_RESPONDER","tenantId":"kl"},{"name":"ORDER_VIEWER","code":"ORDER_VIEWER","tenantId":"kl"},{"name":"ORDER_REASSIGN","code":"ORDER_REASSIGN","tenantId":"kl"},{"name":"CASE_EDITOR","code":"CASE_EDITOR","tenantId":"kl"},{"name":"TASK_CREATOR","code":"TASK_CREATOR","tenantId":"kl"},{"name":"APPLICATION_APPROVER","code":"APPLICATION_APPROVER","tenantId":"kl"},{"name":"HEARING_DATE_REQUESTOR","code":"HEARING_DATE_REQUESTOR","tenantId":"kl"},{"name":"SUBMISSION_CREATOR","code":"SUBMISSION_CREATOR","tenantId":"kl"},{"name":"Employee","code":"EMPLOYEE","tenantId":"kl"},{"name":"COURT_ADMIN","code":"COURT_ADMIN","tenantId":"kl"},{"name":"CASE_VIEWER","code":"CASE_VIEWER","tenantId":"kl"},{"name":"TASK_EDITOR","code":"TASK_EDITOR","tenantId":"kl"},{"name":"APPLICATION_REJECTOR","code":"APPLICATION_REJECTOR","tenantId":"kl"},{"name":"ORDER_APPROVER","code":"ORDER_APPROVER","tenantId":"kl"},{"name":"HEARING_CLOSER","code":"HEARING_CLOSER","tenantId":"kl"},{"name":"HEARING_CREATOR","code":"HEARING_CREATOR","tenantId":"kl"},{"name":"ORDER_CREATOR","code":"ORDER_CREATOR","tenantId":"kl"},{"name":"CASE_APPROVER","code":"CASE_APPROVER","tenantId":"kl"},{"name":"DEPOSITION_CREATOR","code":"DEPOSITION_CREATOR","tenantId":"kl"},{"name":"SUBMISSION_APPROVER","code":"SUBMISSION_APPROVER","tenantId":"kl"},{"name":"TASK_UPDATOR","code":"TASK_UPDATOR","tenantId":"kl"},{"name":"TASK_VIEWER","code":"TASK_VIEWER","tenantId":"kl"},{"name":"HEARING_SCHEDULER","code":"HEARING_SCHEDULER","tenantId":"kl"}],"active":true,"tenantId":"kl","permanentCity":null},"msgId":"1727967063944|en_IN","plainAccessRequest":{}}}'

*verified in UAT env, its working fine.

Its working fine in UAT env.


Add partial support for multishop

Questions
Answers

Description?
The psgdpr module is missing some multishop support.Multishop support is pretty much implemented at database level, not in module configuration.This PR intend to add a partial support for multishop and allow BO users to customize consent messages per shop.Fixes:Avoid module duplicates in psgdpr_consent tableAllow per shop message customizationCaveats:Multishop enabled shops does require a module reset to clean the databaseActivation switch per module is not configurable per shop which is confusing and needs improvement

Type?
bug fix / improvement

BC breaks?
yesPublic methods signature changes:GDPRConsent::getConsentMessage($id_module, $id_lang) became GDPRConsent::getConsentMessage($id_module, $id_lang, $id_shop)GDPRConsent::checkIfExist($id_module, $id_lang) became GDPRConsent::checkIfExist($id_module)

Deprecations?
no

Fixed ticket?
https://github.com/PrestaShop/PrestaShop/issues/23314

How to test?
Version 1.3.0 will show module duplicates for each active shop and consent message customization won't be effective.

EDIT: as suggested by @matks , here is the linked feature request for better multishop support: https://github.com/PrestaShop/PrestaShop/issues/27352

Hello,
Thanks for your feedback,
I just fixed some indent, looks better indeed, other changes feels off the scope of this PR to me.
Beside the 2 alert boxes, I actually just added a condition, which required an indend but the code is unchanged.

Hi @gross-nvs

This PR is more a mitigation/hotfix for this version, I have a customer with a multishop site where the GDPR module is broken due to this problem, and I had to provide a solution to address the "emergency".

Thanks for sharing this hotfix ! this can be great to help other people needing it
However we just to only merge long-term code, no hotfixes ;) so if you consider this PR an hotfix maybe we should close it. But people will still be able to reach it and use if if they need it

Hi @matks
Then let just call it a fix, shall we?

@matks any news here? I received a feedback from a partner agency, you cannot use this module in a multistore environment 😊 There is something that I can do to help?

Apologies for very late answer. I will be honest: I have never looked at the code of PSGDPR module so I feel unable to review this contribution. If you can review it @marsaldev and tell us if it looks valid 😉 we could move on

Hi @gross-nvs,
The module has has been completely reworked on the PHP code side. You will probably need to rebase your work and check the compatibility of your code with the current code.

Hi @fox-john
Sorry, seeing how this request has been handled, I won't put more time on this.
Feels literally like a bad joke.

Hi @fox-john
Sorry, seeing how this request has been handled, I won't put more time on this. Feels literally like a bad joke.

Hello @gross-nvs,
I can understand your feeling. And we are sorry about it. The PrestaCrew were composed of a little team, not enough people to answer all the PR. The team is expanding and we try to be better :-)
Thanks for your understanding :-)

Hi @gross-nvs
I'm very sorry again. We could have done a better job with this PR. Still, I hope to see you around the project with more contributions so that we can work together. If you ever decide to do that, feel free to visit us on Slack or submit GitHub Discussion to check about the implementation details first so that we can push the subject from start to finish quicker.


Build on WSL 2 works well

I have successfully built fwup and fwup.*.nupkg. Some description should be added to the build steps.

Add Ubuntu20/WSL2 as the environment that works well to build
zip and xdelta3 are needed to pass the test-suite.
Setting $DISPLAY may be needed to avoid an error about Wine Mono is not installed. This error may appeared when we use Wine Mono on Linux at the first time.
Add some sections to make it easier to understand.

Coverage remained the same at 86.977% when pulling b6b3204c2de199874917fb55e171d878d6248d54 on takasehideki:build_wsl2 into d5c5ced4582dfebffe0a823d4d28843222c2979b on fhunleth:main.

Thank you for the updated WSL instructions!


Support loading XML datasets

CC: @davanstrien

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

CC: @davanstrien

I should have some time to look at this on Friday :)

@albertvillanova I've tried this with a few different XML datasets. One issue I've run into is getting a KeyError when the attributes of a field differ from the first parsed row. Unfortunately, this can come up in the ALTO XML format, for example, if you want to parse the 'string' field, which contains the text in the ALTO XML files.
When parsing a file, this instance has no 'STYLE' attribute:
<TextLine HEIGHT="39" WIDTH="295" VPOS="926" HPOS="247"><String WC="0.4600000083" CONTENT="jufqu’en" HEIGHT="39" WIDTH="117" VPOS="926" HPOS="247"/><SP WIDTH="14" VPOS="928" HPOS="365"/><String WC="0.6075000167" CONTENT="l’an" HEIGHT="26" WIDTH="50" VPOS="928" HPOS="380"/><SP WIDTH="24" VPOS="936" HPOS="431"/><String WC="0.4300000072" CONTENT="1" HEIGHT="16" WIDTH="9" VPOS="936" HPOS="456"/><String STYLE="italics" WC="0.5774999857" CONTENT="361." HEIGHT="25" WIDTH="68" VPOS="933" HPOS="474"/></TextLine>

Whereas this one which appears later in the file, does have this field:
<TextLine HEIGHT="39" WIDTH="712" VPOS="966" HPOS="297"><String STYLE="italics" WC="0.6999999881" CONTENT="I" HEIGHT="17" WIDTH="9" VPOS="977" HPOS="297"/><String WC="0.5" CONTENT="I." HEIGHT="18" WIDTH="25" VPOS="976" HPOS="318"/><SP WIDTH="24" VPOS="971" HPOS="344"/><String STYLE="italics" WC="0.3359999955" CONTENT="Crade" HEIGHT="26" WIDTH="91" VPOS="967" HPOS="369"/><SP WIDTH="31" VPOS="971" HPOS="461"/><String STYLE="italics" WC="0.6060000062" CONTENT="Pétri" HEIGHT="26" WIDTH="71" VPOS="968" HPOS="493"/><SP WIDTH="23" VPOS="968" HPOS="565"/><String STYLE="italics" WC="0.612857163" CONTENT="Candidi" HEIGHT="27" WIDTH="111" VPOS="967" HPOS="589"/><SP WIDTH="19" VPOS="967" HPOS="701"/><String STYLE="italics" WC="0.4088888764" CONTENT="Decembrii" HEIGHT="28" WIDTH="144" VPOS="966" HPOS="721"/><SP WIDTH="10" VPOS="968" HPOS="866"/><String STYLE="italics" WC="0.4600000083" CONTENT="in" HEIGHT="25" WIDTH="27" VPOS="968" HPOS="877"/><SP WIDTH="9" VPOS="967" HPOS="905"/><String STYLE="italics" WC="0.5099999905" CONTENT="funere" HEIGHT="38" WIDTH="94" VPOS="967" HPOS="915"/></TextLine>

Since the first-seen fields define what is passed to arrow_writer, this causes a KeyError when the version with the extra attributes is encountered because it doesn't expect this column.
Since it's important to support streaming, I'm not sure there is a nice way to detect attributes for the whole file easily in an automatic way. The two potential ways I can see of doing it.

Do an initial pass on a batch of data to have a higher chance of encountering variations in attributes before doing the arrow write.
Do a full pass on one file (and assume that this won't change across files)

I think the other way of doing this would be to allow users to define expected/wanted attributes as another loading argument. This could then be used to extract the described attributes (and make them None if not found). This requires a bit more work from the user but could be helpful. For example, in the XML above, likely, most users will only want the WC and CONTENT attributes. So they could specify this upfront and avoid loading extra data they don't need or want. I suspect this option would make more sense than making this operation automatic for the case where attributes might change. WDYT?


Wires not visible after ctrl-z

Current Behavior
I accidentally deleted a node. ctrl-z brought it back, but its wires were not visible. I just tested on dev, and the same issue.
Expected Behavior
No response
Steps To Reproduce
Using the flow below, delete the switch or the change node and then hit ctrl-z.
Example flow
[
    {
        "id": "99c5b2323d03eee7",
        "type": "inject",
        "z": "c1450f51c0ec534a",
        "name": "",
        "props": [
            {
                "p": "payload"
            },
            {
                "p": "topic",
                "vt": "str"
            }
        ],
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "topic": "",
        "payload": "",
        "payloadType": "date",
        "x": 260,
        "y": 220,
        "wires": [
            [
                "fe74fd80883884bd"
            ]
        ]
    },
    {
        "id": "702cffe2ebc230af",
        "type": "debug",
        "z": "c1450f51c0ec534a",
        "name": "",
        "active": true,
        "tosidebar": true,
        "console": false,
        "tostatus": false,
        "complete": "payload",
        "targetType": "msg",
        "statusVal": "",
        "statusType": "auto",
        "x": 990,
        "y": 220,
        "wires": []
    },
    {
        "id": "fe74fd80883884bd",
        "type": "change",
        "z": "c1450f51c0ec534a",
        "name": "",
        "rules": [
            {
                "t": "set",
                "p": "payload",
                "pt": "msg",
                "to": "",
                "tot": "str"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 480,
        "y": 240,
        "wires": [
            [
                "2d03b86eadc7c677"
            ]
        ]
    },
    {
        "id": "2d03b86eadc7c677",
        "type": "switch",
        "z": "c1450f51c0ec534a",
        "name": "",
        "property": "payload",
        "propertyType": "msg",
        "rules": [
            {
                "t": "eq",
                "v": "",
                "vt": "str"
            }
        ],
        "checkall": "true",
        "repair": false,
        "outputs": 1,
        "x": 730,
        "y": 200,
        "wires": [
            [
                "702cffe2ebc230af"
            ]
        ]
    }
]

Environment

Node-RED version: 2.2.2
Node.js version: v16.13.1
npm version: 8.1.2
Platform/OS: macOS/Linux
Browser: Google Chrome

I thought the wires were simply not visible. Actually, they're not being restored.


finetunes: add mapping for status events to be displayed to user

To match the fine-tuning UI, "finetuning" status needs to map to "training", and "deploying_api" needs to map to "deploying".

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Policy: use vpc-native clusters

Community Note

Please vote on this issue by adding a 👍 reaction
to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description
Create policy that checks if cluster is VPC-native as per our official best practices.
References

GKE Best Practices: Use VPC-native clusters.

Solved with PR #35


PoI skill should detect and warn with a specific exception that the AzureMaps key isn't provided (see main Bot startup)

Description
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

The skill catches it when you try to invoke it & returns with a trace error. Should it warn before invoking (on startup)?


How to display the chosen sticker by the user?

After I get notified in (onStickerSelected), I get the -sticker- object .. So How can I display this sticker in a UI element like imageView?

Thank you I used stringImg variable and displayed it using Glide library


[$1000] mWeb - Request money - There is No cursor in amount page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Click on the green plus button (FAB) -> Request Money
Enter an amount

Expected Result:
Cursor is present
Actual Result:
There is No cursor
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/233388714-96159742-38c4-4999-95fc-a000ada571a1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b32376b47d699980
Upwork Job ID:<PHONE_NUMBER>633018368
Last Price Increase: 2023-04-26

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Some talk about grouping this GH into a bigger auto-focus fix. I will review and update tomorrow

@sobitneupane do you think we should group this fix with others? It's a legit bug report - there should indeed be a cursor here.

Job added to Upwork: https://www.upwork.com/jobs/~01b32376b47d699980

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@michaelhaxhiu could you please add me to slack groups so that i can get instructions to setup for ios and android application for local development as of now i am able to run only web and desktop version, please help with the guidelines to setup for ios and android on mac m1, thanks.

@jasperhuangg i figured out issues and now i am able to run on both ios and android, thanks.

Hi I'm Nicolay from Callstack - expert contributor group - will start investigation in this area

📣 @narefyev91 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Assigning Nikolay to this as he has worked on this page previously, there are some consideration to have regarding the selection which is buggy on native and we are working on a bigger refactor of this. So maybe this could be on hold for that

Still waiting on @narefyev91's PR, not overdue!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Input component is not get focus when page is mounted
What is the root cause of that problem?
Well i think there are a lot of discussion around this issue https://github.com/Expensify/App/issues/10414 - which is the same as we facing here.
But i would like to also paste my findings.
I'm not quite sure that we will be able to fix it because of:

Safari on mobile does not support autoFocus

Safari prevent any manual on focus event - until user will make any interaction on the page https://bugs.webkit.org/show_bug.cgi?id=195884#c4

From Apple team:
We (Apple) like the current behaviour and do not want programmatic focus to bring up the keyboard when you do not have a hardware keyboard attached and the programmatic focus was not invoked in response to a user gesture. Why you may ask...because auto bringing up the software keyboard can be seen as annoying and a distraction to a user (not for your customers, but for everyone not using your app) given that:

We bring up the keyboard, which takes up valuable real estate on screen.
When we intent to bring up the software keyboard we zoom and scroll the page to give a pleasing input experience (or at least we hope it is pleasing; file bugs if not).

And i think even google was not able to make it working:

What changes do you think we should make in order to solve the problem?
The only potential fix here - which i think were already done before - when user click on numpad we add new value in input and focus a field.
    updateAmountNumberPad(key) {
        if (!this.textInput.isFocused()) {
            this.textInput.focus();
        }

The code already exists but it it not working as expected in safari ios - because when we mounted the page - this.textInput.isFocused() will be equal true - and that's why on safari ios - when you click on numpad - we see number - but not see cursor.
Possible solution here to create additional function same as above but with additional check something like this:
if (!this.textInput.isFocused() || isMobileSafari()) focus input
What alternative solutions did you explore?
cc @mananjadhav @michaelhaxhiu @jasperhuangg

Ohh I just saw the platform mentioned as iOS Safari, I thought it was native. I would recommend :donothing: here. This is the standard behavior by Apple, and I am sure that's the case across the app.

@mananjadhav @michaelhaxhiu @narefyev91 @jasperhuangg this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Ah I agree, I think it's a relatively minor quirk that we shouldn't really be focusing our time on, especially if this is true:

standard behavior by Apple, and I am sure that's the case across the app.

Closing, thanks everyone!


feat: remove usage of nohash_hasher in favor of ahash

Fixes:
https://github.com/pydantic/pydantic-core/issues/359
@samuelcolvin do you know off the top of your head if current benchmarks would catch the regression if this change introduced any? If not, I can add some.

Not sure, you'll need to check.

I'm pretty confident that benchmarks would catch regressions here, but probably still good to check.
@czotomo are you okay to resolve conflicts and I think this can be merged.

Codecov Report

Merging #360 (4793530) into main (82d071a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   96.51%   96.50%   -0.01%
==========================================
  Files          87       87
  Lines        9448     9453       +5
  Branches       53        4      -49
==========================================
+ Hits         9119     9123       +4
- Misses        329      330       +1

Impacted Files
Coverage Δ

src/serializers/extra.rs
97.69% <ø> (ø)

src/recursion_guard.rs
95.65% <100.00%> (ø)

src/serializers/filter.rs
95.48% <100.00%> (-0.06%)
:arrow_down:

src/validators/literal.rs
97.83% <100.00%> (ø)

src/input/input_python.rs
98.17% <0.00%> (-0.25%)
:arrow_down:

src/serializers/config.rs
92.94% <0.00%> (-0.09%)
:arrow_down:

src/lookup_key.rs
92.38% <0.00%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d071a...4793530. Read the comment docs.

great, thanks so much.


Fixed issue with non-SPS spectra

fixed issue with non-SPS spectra being treated as having multiple precursors, which disabled utilization of the monoisotopic m/z

@brendanx67 @nickshulman This should fix FAIMS. We really ought to run the perf tests nightly, except maybe TestPeakPerf.

We do run the perf tests nightly. Don't you get the emails with these test failures every morning?

Yes I get the emails. I mean having the perf tests run for PRs and reported to GitHub, so PRs get the benefit of perf testing before they are merged to master. This was a pretty serious bug (basically disabling monoisotopic m/z for non-SPS spectra from modern data that has that "SPS Masses" field left blank). The bug got through other testing because our Thermo unit test file has all monoisotopic m/z set to 0. And apparently all the other Skyline tests don't care about monoisotopic m/z being correct. :)

It does take a lot of disk space (and time) to run the perf tests, which is why we dedicate 12 hours to those runs nightly and only run on certain machines. Unlike the other tests, we also do not wipe the system clean of the test files, because it takes so long to download them. Might be challenging in a TeamCity AWS environment.


Settings update only after vscode reload

Bug report:

Change a setting - for example coverage-gutters.showLineCoverage
Line coverage visibility will not change, even after unwatching/rewatching coverage
Reload vscode using the Reload window command or restarting vscode
Line coverage visibility is updated

Other extensions don't seem to have this problem, perhaps we can try and compare our  approach to other open source extensions.

@Tadaboody this is a known one but I havent got around to fixing it. Essentially we just need to not cache the configStore and instead have it pull everytime.
#20


how i can disable next row when i change data from row

after change value from first row, position will go to next when i press enter or after i choose value from selected box, so i can not update value to another column at first row, it will change value to next row. May i disable next rows on change or any solution for my error.

I will add that feature so that users can turn it on/off in the next change.

hope i will see it in next update, i don't want to reload all table data after change 1 cell value. it not good idea

Check out version 0.1.19.
Added two options. Start the grid by changing the options in the configuration.
body: PlutoGrid(
  columns: columns,
  rows: rows,
  onChanged: (PlutoOnChangedEvent event) {
    print(event);
  },
  configuration: PlutoConfiguration(
    enableMoveDownAfterSelecting: false,
    enterKeyAction: PlutoEnterKeyAction.ToggleEditing,
  ),
),

thank you very much, it very helpful for me


Variant number is not increased when new rpms of the same build is published

Platform: CentOS 7 (but probably affects others)
Architecture: x86_64 (but probably affects others)
When changes are released to the rpm packages release branch (not nightly) without changing the version of the JRE or JDK, the variant number on the rpm package should be increased so that the fact that there have been changes is evident and each rpm in the release repo is an immutable artifact.

The necessary facilities are present but haven‘t been used yet. According to my knowledge, no re-release was performed since the initial announcement. However, we did multiple re-releases beforehand. Therefore I either need more information or there is no action to take here.

Should be in openjdk-installers but the transfer function iscurrently broken

My understanding from our slack conversation was that there was something to be done here and I should open an issue. Entirely possible I'm mistaken. :)


can i use in visual box for docker to run it?

It looks as if the startup was unsuccessful?

This interface has stayed for more than 30 minutes.

there is the vm config

I have not really an idea what could be wrong. But is there any reason to install this inside VirtualBox and not on the host? Because that is really weird

just for fun XD
i change another iso and it works


Take only viewport screenshot

Selenium currently takes the whole page picture:

Wasteful. Scrolling is implemented so no problem with capturing multiple screenshot by scrolling down.
One randomly changing spot on the page can destroy the screenshot.
Isn't coherent with the expectation of screenSize in Huxleyfile.

Selenium doesn't allow viewport screenshot. Will have to manually crop the picture. Do consider scrolling position.
The advantage of this method is that screenSize still works if it overflows smaller monitors , as the full page screenshot is taken first and cropped correctly anyways.

@chenglou How is this feature used?  When I take screenshots using FireFox now, the whole page is saved, not just the visible viewport.

Are you sure? I just tested this and it still works.


Support route redirects in Unpublishing to same degree as a redirect document type

Related Trello card.

@thomasleese do we need to migrate over existing unpublishings with alternative_path fields?

@kevindew No, both types work. Although new unpublishings will be stored with only the redirects field set.

Since we support both kinds of redirects, I was not intending on cleaning up the database (there are tests covering both scenarios, and we use the alternative_path field for gone unpublishings anyway). However, I could look at introducing another PR after this has been deployed if you think that's best.

Yeah I think it'd be best if our data was consistent, everything once this goes out will be in redirects. So if you were wanting to query for an Unpublishing that is to a particular destination you wouldn't want to have to do an or on the redirects hash and the alternative_path field.

Sure, I will prepare another PR once this one is deployed.

I've created two more PRs to support deployment in #787 and #788 .


[Feature] Created Additional Information Card + Update Review Information Modal

Notion ticket link

Additional Information Card

Implementation description

Added Card Form only for viewing (no editing)
NEW (as of March 24):
Dashed borders:

Guardian information section (fixed address format):

OLD:

Notes

Verify display states, what different fields should be showing on diff conditions. (i.e. usesAccessibleConvertedVan = false, should additional information even be visible)

Checklist

[X] My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
[X] I have run the appropriate linter(s)
[X] I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

Hello! Just wanted to confirm that an "Address" subhead got added to the review doctor's information section since it wasn't in the old screenshot

Also the below scenario shouldn't ever actually happen, this was just some test placeholder data right?

First Design Comment Fixed in PR #156
Second Design Comment Is from Old Process, No Longer Occurs with new logic


dynamically change menu side direction when change document direction

how to dynamically change menu side direction when change document direction?
i tried to change it manually by this code but  it doesn't  work
<ion-menu [content]="content" [side]="platform.isRTL()==true?'right':'left'">
also when use this code
<ion-menu [content]="content" [side]="direction" >
it doesn't work when change "direction" variable
thanks in advance.

the problem  related to to two files the first is  "/node_modules/ionic-angular/components/menu/menu.js"
in the function
Menu.prototype._getType = function () {
if (!this._type) {
this._type = MenuController.create(this.type, this, this._platform);
if (this._config.get('animate') === false) {
this._type.ani.duration(0);
}
}
return this._type;
};
we can comment “if condition” but it will create type every time so we can keep if condition and  reset  this._type  when change menu side direction  “i don’t know how do do this”
the second file is
“node_modules/ionic-angular/components/menu/menu.scss”
in this code
ion-menu[side=right] > .menu-inner {
right: 0;
left: auto;
}
we should mack it dynamic >>  disable it when change direction to “ltr”  and reenable it when change direction to “rtl”
hope to fix it in the next version

to solve css issue we can use this cod
this.menu.getMenus()[0].setElementAttribute("side","left")
or
this.menu.getMenus()[0].setElementAttribute("side","right")
note:
0 means the app have one menu

@brandyscarney I see you are tagged here. Is this in the visible future roadmap? (it's important adding the middle eastern locales)

Hello, thanks for using Ionic! We really appreciate this feedback on RTL support. This is not currently high priority for us at the moment, but we are tracking it in #5035. Because of this I am going to close this issue as a duplicate of that issue and ask that you put your feedback on that issue. Please know that by me closing this issue I am not saying that your feedback is not important, or that RTL support is not important, but I am simply closing this issue as we like to keep our issues as organized as possible so things do not get lost in the weeds (which is better said than done haha).


Support BTC balance regularly from Taproot addresses

and remove retrieve feature

Since we support rare sat storing on taproot addresses we'll have to be careful. Make sure to protect those rare sats when we enable support for uninscribed bitcoin on taproot addresses.
I think in most cases a simple measure could suffice that makes sure any amount below or equal to 10000 sats is ignored (inscribed or uninscribed) which should protect most deliberately stored (and hence split into a small UTXO) rare sats.


Can't create pipeline to execute notebook with custom environment

azureml-core:
1.55.1.post2:
Linux:
3.10:

Describe the bug
I'm trying to replicate this notebook https://github.com/balakreshnan/Samples2021/blob/main/AzureMLPipelineNotebook/notebookpipelineexec.md, but I can only use one curated environment. If I try to create an environment like in this code snipet (With USE_CURATED_ENV =False):
from azureml.core.runconfig import RunConfiguration
from azureml.core.conda_dependencies import CondaDependencies
from azureml.core import Environment

aml_run_config = RunConfiguration()
#compute_target as defined in "Azure Machine Learning compute" section above
aml_run_config.target = compute_target

USE_CURATED_ENV = True
if USE_CURATED_ENV :
    curated_environment = Environment.get(workspace=ws, name="AzureML-Tutorial")
    aml_run_config.environment = curated_environment
else:
    aml_run_config.environment.python.user_managed_dependencies = False
    #Add some packages relied on by data prep step
    aml_run_config.environment.python.conda_dependencies = CondaDependencies.create(
        conda_packages=['pandas','scikit-learn','seaborn','tqdm'],
        pip_packages=['azureml-sdk', 'azureml-dataprep[fuse,pandas]','seaborn','tqdm'],
        pin_sdk_version=False)

the pipeline won't run and will return the error:
"This pipeline didn't have the rawdeserializer policy can't deserialize"
It only works with one curated environment that stats with AzurML and it doesn't matter if I clone it, the clone fails too and no other curated environment works neither.
The only curated environment that works doesn't have the required libraries so in order to use them I tried adding them, but  adding libraries on it doesn't work neither, maybe because it doesn't have conda dependencies.
Something I noticed is the when I run:
Environment.list(worspace=ws)
The only printed envrionment is the one that works, all the other available environments are not printed.
Expected behavior
The pipeline should execute properly with every environment.
Screenshots

Additional context
The trial.py its only a Hello World print.

Hi @ hectordanielc
when I am using the USE_CURATED_ENV =False the default custom environment is created succesfully and the pipeline jobs gets succeeded.
and also please share the repro steps?

I'm exactly following the repo https://github.com/balakreshnan/Samples2021/blob/main/AzureMLPipelineNotebook/notebookpipelineexec.md and it works only with the Microsoft's curated environment "AzureML-ACPT-pytorch-1.13-py38-cuda11.7-gpu:10". All the others even the others curated environments aren't working.
I followed the error and here is the log:

Hi @hectordanielc
From the error message its saying that the Authentication error from the storage. Can you please check the permissions of the storage account whether storage account has the necessary permissions to access the workspace or not.


Enable Compilation on JDK21

The currently used lombok version is not compatible with JDK 21.
In addition, Its advised to switch from source/target to release (see https://openjdk.org/jeps/247 for details), introduced in Java 9.
The maven compiler plugin with translate this automatically to the old source/target/bootclasspath options for Java 8 compilers.

Hello.
Maybe it’s worth separating these (OHLC for Kraken, JDK 21) for two separate PR?

@rizer1980, sorry that was unintentional. I'll cleaned this up. In addition, I noticed that meanwhile the problematic lombok dependency was updated already. What remains are the more robust compilation settings.

How about changing the code level to 11? Since we're anyway building witth SDK 11. What do you think, @timmolter ?

@bigscoop ok, let's try it after the next release (coming this week). That way Java 11 will be present in the SNAPSHOT versions for a while before releasing it. We've tried several times in the past, but people reported issues with Android. Maybe it will work out this time around.


Remove elvish.kak

Its gone missing.

@notramo are you still around and willing to say where the file went? Can you post to a gist or something?

The repo is moved to https://git.tchncs.de/notramo/elvish.kak

thanks @notramo I've brought it back with the new url.


Uncaught SyntaxError: Unexpected token import

Hello,
Probably I do something wrong here, but I have this error:
smooth_scrollbar.js:6 - Uncaught SyntaxError: Unexpected token import
Someone can help me?

Source code (i.e. codes under src/) is written in es6, you may need proper tools (like babel) to translate it. Or you can simply use the compiled code in dist/ folder :)

Hi
I use this two:
<link rel="stylesheet" href="https://cdn.rawgit.com/idiotWu/smooth-scrollbar/master/dist/smooth-scrollbar.css">

<script src="https://cdn.rawgit.com/idiotWu/smooth-scrollbar/master/dist/smooth-scrollbar.js"></script>

Then, I call this on my JS file::
import Scrollbar from 'smooth-scrollbar';
Scrollbar.initAll();

Same problem :\

@tevez15 oh there's no need to import modules in browser environment. As Scrollbar is exported globally, all you need is to:
Scrollbar.initAll();

I do everything you said.
http://coredesignz.com/scrolltest/
Take a look, now execute scrollbar, but dont scroll.

@tevez15 like native scrollable areas, contents must have a height that is higher that containers. In your case you need to specify a height for the #main-scrollbar element like :
html, body {
  height: 100%; /* assuming you want a full-page scroller */
}

#main-scrollbar {
  max-height: 100%;
}

Cool, now its work..
Thank you very much! :D

Enjoy it!

hello friend's
Probably I do something wrong here, but I have this error:
Uncaught SyntaxError: Unexpected token '<'
Someone can help me?


Large increase in binary size after upgrading to v0.7.6

Recently, I ran a cargo update on my project, and the release binary size jumped ~0.13MB. Relevant CI builds are https://github.com/ravenclaw900/DietPi-Dashboard/actions/runs/5523750813 (old) and https://github.com/ravenclaw900/DietPi-Dashboard/actions/runs/5524904223 (new). I am aware that this was mentioned in https://github.com/toml-rs/toml/issues/340#issuecomment-1363560789 and is a known 'regression'. I also understand that the old toml crate was unmaintained, and didn't fully support TOML 1.0. All that to say, I am in favor of the new parser and what it does, but I'm wondering why the increase in binary size was so large and if there's anything that can be done on either end to reduce the size?

Happen to know if that was with or without debug symbols?
I ran cargo bloat on a toml example:
$ cargo bloat --crates --release --example decode
warning: skipping duplicate package `example` found at `/home/epage/.cargo/git/checkouts/libfuzzer-sys-e07fde05820d7bc
6/35ce7d7/example`
    Finished release [optimized + debuginfo] target(s) in 0.02s
    Analyzing target/release/examples/decode

File  .text     Size Crate
2.5%  52.4% 270.7KiB std
2.0%  41.6% 214.5KiB toml_edit
0.1%   1.7%   8.7KiB winnow
0.0%   0.8%   4.3KiB serde
0.0%   0.5%   2.3KiB libtest_mimic
0.0%   0.3%   1.8KiB toml_datetime
0.0%   0.3%   1.4KiB decode
0.0%   0.2%   1.0KiB regex
0.0%   0.1%     555B ignore
0.0%   0.1%     440B memchr
0.0%   0.0%     260B serde_spanned
0.0%   0.0%     133B toml
0.0%   0.0%     109B [Unknown]
0.0%   0.0%      95B hashbrown
0.0%   0.0%      83B indexmap
0.0%   0.0%      38B clap
0.0%   0.0%       5B libc
4.7% 100.0% 516.2KiB .text section size, the file size is 10.6MiB

Re-ran it with toml 0.5
$ cargo bloat --crates --release --example decode
warning: skipping duplicate package `example` found at `/home/epage/.cargo/git/checkouts/libfuzzer-sys-e07fde05820d7bc
6/35ce7d7/example`
   Compiling toml v0.5.10
   Compiling toml v0.7.6 (/home/epage/src/personal/toml/crates/toml)
    Finished release [optimized + debuginfo] target(s) in 2.51s
    Analyzing target/release/examples/decode

File  .text     Size Crate
4.1%  70.6% 270.8KiB std
1.3%  23.4%  89.6KiB toml
0.1%   2.5%   9.7KiB serde
0.0%   0.9%   3.3KiB libtest_mimic
0.0%   0.2%     761B decode
0.0%   0.2%     726B hashbrown
0.0%   0.1%     555B ignore
0.0%   0.1%     440B memchr
0.0%   0.0%     166B indexmap
0.0%   0.0%     109B [Unknown]
0.0%   0.0%       5B libc
5.7% 100.0% 383.4KiB .text section size, the file size is 6.5MiB

Note: numbers above are a result of guesswork. They are not 100% correct and never will be.

So

old toml: 383 KiB total
new toml: 516 KiB total
diff: 133 KiB

commit 6e63746862250c6bf35c030d04e1014b1d779b40
After a couple of tweaks (#585), I dropped a little of the size
$ cargo bloat --release --example decode --crates
warning: skipping duplicate package `example` found at `/home/epage/.cargo/git/checkouts/libfuzzer-sys-e07fde05820d7bc
6/35ce7d7/example`
   Compiling toml_edit v0.19.13 (/home/epage/src/personal/toml/crates/toml_edit)
   Compiling toml v0.7.6 (/home/epage/src/personal/toml/crates/toml)
    Finished release [optimized + debuginfo] target(s) in 3.31s
    Analyzing target/release/examples/decode

File  .text     Size Crate
2.5%  53.8% 269.4KiB std
1.9%  40.1% 200.8KiB toml_edit
0.1%   1.7%   8.7KiB winnow
0.0%   0.9%   4.3KiB serde
0.0%   0.5%   2.3KiB libtest_mimic
0.0%   0.4%   1.8KiB toml_datetime
0.0%   0.3%   1.4KiB decode
0.0%   0.2%   1.0KiB regex
0.0%   0.1%     555B ignore
0.0%   0.1%     440B memchr
0.0%   0.1%     260B serde_spanned
0.0%   0.0%     133B toml
0.0%   0.0%     109B [Unknown]
0.0%   0.0%      95B hashbrown
0.0%   0.0%      83B indexmap
0.0%   0.0%      38B clap
0.0%   0.0%       5B libc
4.7% 100.0% 501.0KiB .text section size, the file size is 10.5MiB

Note: numbers above are a result of guesswork. They are not 100% correct and never will be.

From looking at the function sizes, my best guesses as to where the size is going

Optimizations
Error reporting
Book keeping for format preserving
Lots of small overhead added up
Potentially there are multiple copies of functions in the deserialization code that could be reduced down

I should note that the example I was measuring only deserializes so all of the serialization code was optimized out.

All the debug symbols were stripped out in the builds I posted. I'll see if I can get a cargo bloat later, any specific settings that would be helpful?

Version 0.19.12:
cargo bloat --crates --release
    Finished release [optimized] target(s) in 0.05s
    Analyzing target/release/dietpi-dashboard

 File  .text     Size Crate
 7.3%  22.2% 455.0KiB std
 6.4%  19.4% 399.5KiB dietpi_dashboard
 2.1%   6.5% 132.7KiB toml_edit
 2.1%   6.4% 131.4KiB tokio
 2.1%   6.3% 128.7KiB rustls
 1.9%   5.9% 122.0KiB ring
 1.5%   4.6%  94.6KiB hyper
 1.2%   3.7%  75.2KiB figment
 1.2%   3.6%  74.8KiB [Unknown]
 0.6%   1.9%  39.8KiB psutil
 0.6%   1.9%  39.3KiB jsonwebtoken
 0.6%   1.8%  37.3KiB serde_json
 0.4%   1.3%  27.7KiB serde
 0.4%   1.3%  27.2KiB tracing_subscriber
 0.4%   1.2%  24.7KiB http
 0.3%   0.9%  17.9KiB anyhow
 0.3%   0.9%  17.7KiB zip
 0.3%   0.8%  16.2KiB data_encoding
 0.2%   0.7%  14.5KiB hashbrown
 0.2%   0.7%  14.2KiB futures_util
 2.3%   7.0% 144.5KiB And 52 more crates. Use -n N to show more.
32.7% 100.0%   2.0MiB .text section size, the file size is 6.1MiB

Version 0.19.14:
cargo bloat --crates --release
    Finished release [optimized] target(s) in 0.05s
    Analyzing target/release/dietpi-dashboard

 File  .text     Size Crate
 7.3%  22.5% 455.0KiB std
 6.4%  19.7% 399.5KiB dietpi_dashboard
 2.1%   6.5% 131.2KiB tokio
 2.1%   6.3% 128.4KiB rustls
 2.0%   6.0% 122.0KiB ring
 1.6%   4.8%  96.9KiB toml_edit
 1.5%   4.7%  94.4KiB hyper
 1.2%   3.7%  74.8KiB [Unknown]
 1.2%   3.7%  74.6KiB figment
 0.6%   2.0%  39.8KiB psutil
 0.6%   2.0%  39.7KiB jsonwebtoken
 0.6%   1.8%  37.2KiB serde_json
 0.4%   1.4%  27.7KiB serde
 0.4%   1.3%  27.2KiB tracing_subscriber
 0.4%   1.2%  24.5KiB http
 0.3%   0.9%  17.9KiB anyhow
 0.3%   0.9%  17.7KiB zip
 0.3%   0.8%  16.2KiB data_encoding
 0.2%   0.7%  14.5KiB hashbrown
 0.2%   0.7%  14.2KiB futures_util
 2.4%   7.5% 150.9KiB And 55 more crates. Use -n N to show more.
32.5% 100.0%   2.0MiB .text section size, the file size is 6.1MiB

Strangely, binary size increased slightly after updating to toml_edit 0.19.14, though it's likely this was due to another dependency.


feat(config): add new parameters for ZEN15 800LR

ZEN15 800LR revision add several new parameters, 36, 175, and 176.  Modified parameter 20
Details here:
https://www.support.getzooz.com/kb/article/309-zen15 power-switch-change-log/
https://www.support.getzooz.com/kb/article/616-zen15-power-switch-advanced-settings/

See also #7495 which likely includes these changes except the label, which I will add now...

See also #7495 which likely includes these changes except the label, which I will add now...

Funny how we coincidentally checked these in minutes apart. :D
Might I suggest the label to distinguish the 800LR variant from the older 500 series version?


myipaddress.ru

Domain name: myipaddress.ru
GTMetrix results: https://gtmetrix.com/reports/myipaddress.ru/vxhaZHCS/
Uncompressed page size: 1.1 KB

  1.1 KB
  myipaddress.ru

Need GTMetrix results

Need GTMetrix results

Done :)
Thanks in advance!


#10 Fix the check for changes that enables the apply button in settings

@yanislavm thanks for the fix. It looks good to me :+1:

thanks @Hazem-Ben-Khalfallah


Connecting 2-3 more clients to server

Hello, I haven’t tried this code yet but I’m eager to try it. I’m hoping to ask, is there anyway to set one ESP8266 chip as a server and have 2 clients connect to the server via local Network and display the same visualization from the server? I’ve been looking everywhere with no luck to this issue. If you can, can you help me with this project please. I’m not a programmer but I’m trying to do a house project with an audio visualizer for myself. Greatly appreciated!

Currently no, but some have implemented this in forks and side projects.

Closing for inactivity


Export Extras not working

The zip contains a blend file made with 9abcf56fa88 from windows from https://builder.blender.org/download/
It has a cube with a property named "Foo" containing a string "Bar"
Zip also has a sample of exported GLTF with the option Export Extras enabled
Cube.zip
However the generated file lacks the exported property.

I can confirm the latest version from github works! Thanks

Is now merged in Blender 2.8 repo


BDC extension shouldn't be built-in

Having it be built in makes it difficult to interact with other extensions - like the azdata extension. And features like this generally shouldn't be built into the core experience.
AB#3782

Closing until we decide we actually need to do this.


Adjust README to use stable chart repo

This PR adjusts the example statements in the README to use the stable helm chart repo.

/assign @prydonius

/ok-to-test

/lgtm


[tool_crash] StateError: Bad state: Existing VM service clients prevent DDS from taking control.

Command
flutter --no-color run --machine --track-widget-creation --device-id=32004423b8d27511 --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
StateError: Bad state: Existing VM service clients prevent DDS from taking control.
#0      DartDevelopmentService.startDartDevelopmentService (package:flutter_tools/src/base/dds.dart:83:11)
<asynchronous suspension>
#1      FlutterDevice.connect.<anonymous closure> (package:flutter_tools/src/resident_runner.dart:249:11)
<asynchronous suspension>

[✓] Flutter (Channel master, 1.26.0-2.0.pre.296, on Microsoft Windows [Version 10.0.19042.746], locale en-IN)
    • Flutter version 1.26.0-2.0.pre.296 at D:\flutter
    • Framework revision 737496e8db (2 weeks ago), 2021-01-12 02:54:03 -0500
    • Engine revision 10cee6abcb
    • Dart version 2.12.0 (build 2.12.0-214.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\Rajkumar\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] IntelliJ IDEA Community Edition (version 2020.2)
    • IntelliJ at D:\ideaIC-2020.2.2.win
    • Flutter plugin version 50.0
    • Dart plugin version 202.7319.5

[✓] Connected device (3 available)
    • SM J600G (mobile) • 32004423b8d27511 • android-arm    • Android 10 (API 29)
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 88.0.4324.104
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 87.0.664.75

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: master
Creation framework version: 876c313784b9e2cedb9069b908c85f68abceb5a1
Plugins
file_picker-2.1.5+1
flutter_plugin_android_lifecycle-1.0.11
fluttertoast-7.1.6
path_provider-1.6.27
path_provider_linux-0.0.1+2
path_provider_macos-0.0.4+8
path_provider_windows-0.0.4+3
sqflite-1.3.2+2
webview_flutter-1.0.7

This has been resolved in the next Flutter release. Thanks for reporting!

This has been resolved in the next Flutter release. Thanks for reporting!