Trusted Platform Details

We need to create a new top-level section that expounds upon the definition of Trusted Platform in the glossary and provide details on how the Trusted Platform is to be incorporated within CCiTC guidance.
Should probably be created somewhere after Shared Security Model and before Contributors Roles sections.

So the concept would be that we would provide a set of assumptions that would be satisfied by a 'trusted platform'. Similarly, to A.PHYSICAL_PROTECTION, there are some assumptions in the NDcPP around Isolation, trusted admin (of the platform), credential security, residual information, connectivity. that would be included. These would 'fill in' some of the gaps we are probably seeing in current PP's SPDs and as was done for MDM, we can determine whether these are satisfied by (for example) Fedramp. PP writers would then incoporate these into their own PP's for TOE's in the cloud.
An initial list of 'candidate' assumptions from PP's of note are:
A.PLATFORM generally talks about platform integrity and trust. A.MDM_SERVER_PLATFORM goes into more detail and looks interesting.
A. TRUSTED/PROPER-ADMIN. This was thought to be relevant, but we should probably separate activities at the TOE level and platform level (see A.TRUSTED-PLATFORM-ADMIN below).
A.PHYSICAL PROTECTION. Only seen in some PP’s – would seem important for Cloud platform since it obviously has to fulfil this.
A.LIMITED_FUNCTIONALITY/A.NO_GENERAL_PURPOSE. Found on NDCPP and DBCPP. Limits server to only one function and not have general compute available – could be platform configuration.
A.(VS)REGULAR_UPDATES. Found on GPCP and NDCPP. Makes sense to consider this as a rationale for regular cloud updates (at possibly every level).
A.ADMIN_CREDENTIALS_SECURE – Administrators credentials (private keys) are protected by the platform on which they reside. Makes sense for cloud.
A.RESIDUAL_INFORMATION. Found on NDCPP. How does the cloud infrastructure handle sensitive residual information on equipment when it is discarded or removed from operational environment – seems very relevant.
A_VS_TRUSTED_ADMINISTRATOR. From vND’s for NDCPP, around administration of the VS. We should probably have something equivalent A.TRUSTED-PLATFORM-ADMIN)
A.VS-ISOLATION. From vND’s for NDCPP. Concerning sufficient isolation between s/w running in VMs and that the VS itself is protected from the software running inside. This is probably a critical assumption that should be considered for our scenario (e.g A.PLATFORM_ISOLATION)
A.VS_CORRECT_CONFIGURATION. From vND’s for NDCPP. Seems we should have something similar (A.PLATFORM_CORRECT_CONFIGURATION) probably linked to guidance.
A.CONNECTIVITY/A.CONNECT: Found in NDCPP and DBCPP. While the meanings are a little different, it would seem that in addition to isolation, we are missing some assumptions on what the cloud platform provides in terms of network connectivity and the integrity/confidentiality of those. The DBCPP ‘A.CONNECT’ should be considered as a base.

https://www.cisco.com/c/en/us/about/trust-center/compliance/ccf.html#~what-is-the-cloud-controls-framework

Given the amount of assumptions on the cloud environment - for 'security' should we look at making an Assumption or assignment to the Operating Environment -
i.e. :
A.Cloud - cloud environment has been [vetted/certified/conforms] to a secure configuration
A.Cloud - cloud environment has matches a [vetted/certified/conforming] configuration
OE.Cloud - cloud environment has been evaluated and [complies with, certified as] security requirements.....

Tried downloading the file 3 times but the Captcha keeps failing. Anybody
have the file?
Regards
Greg
DISA Chief Mobility Eng., MEng
DoD APL Mobility Manager
SD5 Enterprise Mobility Div. / DISA
Phone<PHONE_NUMBER> tel:(301) 225-9501
Cell:<PHONE_NUMBER> tel:(571) 481-7514
DSN<PHONE_NUMBER> tel:(312) 375-9501
DMCC-S:<PHONE_NUMBER> tel:(302) 841-1412
ECVoIP:<PHONE_NUMBER> tel:(302) 375-0686
U: @.*** @.***>
S: @.***
@.***>
IC: @.*** @.***>
From: tstodart @.>
Sent: Wednesday, July 26, 2023 11:44 AM
To: CC-in-the-Cloud/General @.>
Cc: Subscribed @.***>
Subject: Re: [CC-in-the-Cloud/General] Trusted Platform Details (Issue #101)
https://www.cisco.com/c/en/us/about/trust-center/compliance/ccf.html#~what-i
s-the-cloud-controls-framework
<https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fwww.cisc
o.com%2Fc%2Fen%2Fus%2Fabout%2Ftrust-center%2Fcompliance%2Fccf.html%23~what-i
s-the-cloud-controls-framework&data=05%7C01%7Cgregory.f.youst.civ%40mail.mil
%7C218beed41997447bd84d08db8def3a90%7C102d0191eeae4761b1cb1a83e86ef445%7C0%7
C0%7C638259830850423696%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5ZmjF0K9od5bzYT
xGK4C1bWn4edz%2BHSt8bLhHN5d7Pc%3D&reserved=0>

Reply to this email directly, view it on GitHub
<https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.c
om%2FCC-in-the-Cloud%2FGeneral%2Fissues%2F101%23issuecomment-1652078022&data
=05%7C01%7Cgregory.f.youst.civ%40mail.mil%7C218beed41997447bd84d08db8def3a90
%7C102d0191eeae4761b1cb1a83e86ef445%7C0%7C0%7C638259830850423696%7CUnknown%7
CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
%3D%7C3000%7C%7C%7C&sdata=jCx1OvsyQxSM2NMQuiJwEMz15vcOI8ih%2Fh1gt9XOf5c%3D&r
eserved=0> , or unsubscribe
<https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.c
om%2Fnotifications%2Funsubscribe-auth%2FAU6AIDVO3QVSDOZNPTNF7U3XSE3NXANCNFSM
6AAAAAA2KRJR3A&data=05%7C01%7Cgregory.f.youst.civ%40mail.mil%7C218beed419974
47bd84d08db8def3a90%7C102d0191eeae4761b1cb1a83e86ef445%7C0%7C0%7C63825983085
0423696%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6
Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=F61Ky4u%2FKlw8F%2F0glQMok9vZ8pa
9Aso4T36ttZPUVd8%3D&reserved=0> .
You are receiving this because you are subscribed to this thread.
<https://github.com/notifications/beacon/AU6AIDV6VQ6BUHWRZBVHRGLXSE3NXA5CNFS
M6AAAAAA2KRJR3CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT
CPC24M.gif> Message ID:
@.***
@.***> >

Tried downloading the file 3 times but the Captcha keeps failing. Anybody have the file? Regards Greg DISA Chief Mobility Eng., MEng DoD APL Mobility Manager SD5 Enterprise Mobility Div. / DISA Phone<PHONE_NUMBER> tel:(301) 225-9501 Cell:<PHONE_NUMBER> tel:(571) 481-7514 DSN<PHONE_NUMBER> tel:(312) 375-9501 DMCC-S:<PHONE_NUMBER> tel:(302) 841-1412 ECVoIP:<PHONE_NUMBER> tel:(302) 375-0686 U: @.*** @.> S: @. @.> IC: @. @.> From: tstodart @.> Sent: Wednesday, July 26, 2023 11:44 AM To: CC-in-the-Cloud/General @.> Cc: Subscribed @.> Subject: Re: [CC-in-the-Cloud/General] Trusted Platform Details (Issue #101) https://www.cisco.com/c/en/us/about/trust-center/compliance/ccf.html#~what-i s-the-cloud-controls-framework <https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fwww.cisc o.com%2Fc%2Fen%2Fus%2Fabout%2Ftrust-center%2Fcompliance%2Fccf.html%23~what-i s-the-cloud-controls-framework&data=05%7C01%7Cgregory.f.youst.civ%40mail.mil %7C218beed41997447bd84d08db8def3a90%7C102d0191eeae4761b1cb1a83e86ef445%7C0%7 C0%7C638259830850423696%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5ZmjF0K9od5bzYT xGK4C1bWn4edz%2BHSt8bLhHN5d7Pc%3D&reserved=0> - Reply to this email directly, view it on GitHub <https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.c om%2FCC-in-the-Cloud%2FGeneral%2Fissues%2F101%23issuecomment-1652078022&data =05%7C01%7Cgregory.f.youst.civ%40mail.mil%7C218beed41997447bd84d08db8def3a90 %7C102d0191eeae4761b1cb1a83e86ef445%7C0%7C0%7C638259830850423696%7CUnknown%7 CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 %3D%7C3000%7C%7C%7C&sdata=jCx1OvsyQxSM2NMQuiJwEMz15vcOI8ih%2Fh1gt9XOf5c%3D&r eserved=0> , or unsubscribe <https://usg01.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.c om%2Fnotifications%2Funsubscribe-auth%2FAU6AIDVO3QVSDOZNPTNF7U3XSE3NXANCNFSM 6AAAAAA2KRJR3A&data=05%7C01%7Cgregory.f.youst.civ%40mail.mil%7C218beed419974 47bd84d08db8def3a90%7C102d0191eeae4761b1cb1a83e86ef445%7C0%7C0%7C63825983085 0423696%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=F61Ky4u%2FKlw8F%2F0glQMok9vZ8pa 9Aso4T36ttZPUVd8%3D&reserved=0> . You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AU6AIDV6VQ6BUHWRZBVHRGLXSE3NXA5CNFS M6AAAAAA2KRJR3CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT CPC24M.gif> Message ID: @.*** @.***> >

Resolved

Given the amount of assumptions on the cloud environment - for 'security' should we look at making an Assumption or assignment to the Operating Environment - i.e. : A.Cloud - cloud environment has been [vetted/certified/conforms] to a secure configuration A.Cloud - cloud environment has matches a [vetted/certified/conforming] configuration OE.Cloud - cloud environment has been evaluated and [complies with, certified as] security requirements.....

I like it a lot (as a cloud vendor) - effectively that clould is awesome and solves all. However, I think the Security Objectives Rationale will look weird for each PP since there will be multiple 'A.x/OE.x' for non-cloud but only the 'A.x/OE.x' for TOEs in the cloud - effectively saying all are merged into one. Might also be more difficult for PP writers to incorporate into their existing versions, vs. a set of assumptions that look very similar to what we already see in PP's. We'll also not be able to do the detailed mapping to (e.g.) Fedramp controls since A.Cloud/OE.Cloud becomes a 'catch-all' without any detail (e.g. physical/network/isolation, etc.). I am not sure schemes will necessarily be comfortable with that. It may also be harder for an evaluator if they need to resolve an SFR that is relying on something provided by the platform (e.g timestamp) if all the can do is point to 'A.Cloud/OE.Cloud'. Just my thoughts.

After previous discussions around threats I have added a para to the text. For the PP's used as inputs, threats are written without reference to the environment (as an adverse action performed by a threat agent on an asset per CC pt 1) and therefore don't map to assumptions or Security Objectives of the operating environment. But it may make sense for a PP author to review the threats in the context of the TOE running on a cloud platform.

Closed now integrated.


Response error handling fails when service returns 404

I experienced this error on the current master branch, while using bundle exec rake console to manually test a doc example for BigQuery.
irb(main):020:0> data = bigquery.query sql
NoMethodError: undefined method `[]' for nil:NilClass
	from /Users/quartzmo/code/google/codez/gcloud-ruby/lib/gcloud/bigquery/errors.rb:41:in `from_response'
	from /Users/quartzmo/code/google/codez/gcloud-ruby/lib/gcloud/bigquery/project.rb:230:in `query'
	from (irb):20
	from /Users/quartzmo/code/google/codez/gcloud-ruby/rakelib/console.rake:27:in `block in <top (required)>'

Because this error occurs while trying to initialize an ApiError from a non-success response from BigQuery, I modified my local bigquery/project.rb to raise the response object, then recreated the error with the following output (auth details removed):
#<Google::APIClient::Result:0x007fe2e27127e0 @request=#<Google::APIClient::Request:0x007fe2e274b018 @parameters={"projectId"=>nil}, @headers={"Content-Type"=>"application/json", "User-Agent"=>"gcloud-ruby/0.2.0 google-api-ruby-client/0.8.6 Mac OS X/10.10.5\n (gzip)", "Accept-Encoding"=>"gzip"}, @api_method=#<Google::APIClient::Method:0x3ff170e6b954 ID:bigquery.jobs.query>, @authenticated=nil, @authorization=#<Google::Auth::UserRefreshCredentials:0x007fe2e1995e78 [HIDDEN]>, @body="{\"kind\":\"bigquery#queryRequest\",\"query\":\"SELECT TOP(word, 50) as word, COUNT(*) as count FROM publicdata:samples.shakespeare\"}">, @response=#<Faraday::Response:0x007fe2e27137a8 @on_complete_callbacks=[], @env=#<Faraday::Env @method=:post @body="Not Found" @url=#<URI::HTTPS https://www.googleapis.com/bigquery/v2/projects//queries> @request=#<Faraday::RequestOptions params_encoder=Faraday::FlatParamsEncoder> @request_headers={"User-Agent"=>"gcloud-ruby/0.2.0 google-api-ruby-client/0.8.6 Mac OS X/10.10.5\n (gzip)", "Content-Type"=>"application/json", "Accept-Encoding"=>"gzip", "Authorization"=>"[HIDDEN]", "Cache-Control"=>"no-store"} @ssl=#<Faraday::SSLOptions verify=true, ca_file="/Users/quartzmo/.rbenv/versions/2.2.2/gemsets/gcloud-ruby/gems/google-api-client-0.8.6/lib/cacerts.pem"> @response_headers={"cache-control"=>"no-cache, no-store, max-age=0, must-revalidate", "pragma"=>"no-cache", "expires"=>"Fri, 01 Jan 1990 00:00:00 GMT", "date"=>"Wed, 19 Aug 2015 01:02:49 GMT", "vary"=>"Origin, X-Origin", "content-type"=>"text/html; charset=UTF-8", "x-content-type-options"=>"nosniff", "x-frame-options"=>"SAMEORIGIN", "x-xss-protection"=>"1; mode=block", "server"=>"GSE", "alternate-protocol"=>"443:quic,p=1", "alt-svc"=>"quic=\":443\"; p=\"1\"; ma=604800", "connection"=>"close", "transfer-encoding"=>"chunked"} @status=404>>>
	from /Users/quartzmo/code/google/codez/gcloud-ruby/lib/gcloud/bigquery/project.rb:230:in `query'

The relevant parts are: @env=#<Faraday::Env @method=:post @body="Not Found" @url=#<URI::HTTPS https://www.googleapis.com/bigquery/v2/projects//queries> and @status=404.
The else condition in this block should support all non-success responses.

I've seen this when my environment isn't set up correctly and I don't have a PROJECT_ID configured. I suspect that is what is going on here. So there may be multiple changes to address this, one to guard against a missing project, and another to guard against API calls not returning the expected JSON payload.

Agreed.

#225 is to guard against a missing project
This issue (#224) is to guard against API calls not returning the expected JSON payload

The commit above handles 404 response as shown in this example:
irb(main):005:0> data = bigquery.query sql
Gcloud::Bigquery::ApiError: Not Found: /bigquery/v2/projects//queries
	from /Users/quartzmo/code/google/codez/gcloud-ruby/lib/gcloud/bigquery/project.rb:230:in `query'
	from (irb):5

I guess maybe it would be nice if the ApiError message contained "404" as well, just to be clear. Calling ApiError#code will return 404. Should I prepend the code to the message?


Post course sam

Adding content for section I delivered
Removing tidyr.R 😢
Adding ggplot2 code @stephhazlitt did you want this?

@boshek Could it be confusing to have multiple what-we-did-on-the-day files per lesson?

@stephhazlitt it probably is. I'll just pitch it.


Config-file ignored when using release-pr command

TL;DR
The google-github-actions/release-please-action@v3 action ignores the specified config-file in the release-please YAML configuration when executing the "release-pr" command, resulting in the config-file not being utilized for the release process.
Expected behavior
The "google-github-actions/release-please-action@v3" action should recognize and utilize the specified config-file within the YAML configuration when executing the "release-pr" command. The action should adhere to the configurations defined in the config-file during the release process.
Observed behavior
The action does not consider the specified config-file and proceeds with the release process without adhering to the configurations defined in the config-file.
Action YAML
permissions:
  contents: write
  pull-requests: write

name: release-please

on: workflow_dispatch

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - name: Create Release
        uses: google-github-actions/release-please-action@v3
        with:
          release-type: node
          command: release-pr
          config-file: release-please-config.json

Log output
Run google-github-actions/release-please-action@v3
  with:
    release-type: node
    command: release-pr
    config-file: release-please-config.json
    token: ***
    fork: false
    clean: true
    bump-minor-pre-major: false
    bump-patch-for-minor-pre-major: false
    changelog-host: https://github.com
    github-api-url: https://api.github.com
    github-graphql-url: https://api.github.com/graphql
    monorepo-tags: false
❯ Fetching package.json from branch master
✔ Looking for latest release on branch: master with prefix: github-actions-playground
❯ Fetching merge commits on branch master with cursor: undefined
❯ Found latest release pull request: 1 version: 1.0.0
❯ Fetching releases with cursor undefined
❯ found release for github-actions-playground Version {
  major: 1,
  minor: 0,
  patch: 0,
  preRelease: undefined,
  build: undefined
}
❯ found 2 possible releases. [
  Version {
    major: 1,
    minor: 0,
    patch: 0,
    preRelease: undefined,
    build: undefined
  },
  Version {
    major: 1,
    minor: 0,
    patch: 0,
    preRelease: undefined,
    build: undefined
  }
]
✔ Building pull requests
✔ Building strategies by path
❯ .: node
✔ Collecting release commit SHAs
❯ release search depth: 400
❯ Fetching releases with cursor undefined
❯ Found release for path ., v1.0.0
❯ release for path: ., version: 1.0.0, sha: 57b873ad123bee380565dbf90a82c0efe8938031
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(1) { '57b873ad123bee380565dbf90a82c0efe8938031' }
❯ Fetching merge commits on branch master with cursor: undefined
❯ Backfilling file list for commit: e602ce5c0c64f39c26b4748be347ff77fb4eb4bf
❯ Found 2 files
❯ Backfilling file list for commit: 0161d9e36b4a90a4f013b19d657d64044c3a4795
❯ Found 1 files
❯ Backfilling file list for commit: 60e71c81cd0e46d11647159225af88dacb0d6798
❯ Found 1 files
❯ Backfilling file list for commit: b36d678de8bb171b6c0908022e9ed0c811650188
❯ Found 1 files
❯ Backfilling file list for commit: 302c623248f8deb3c27d38cd5c4395ae6e04b9c4
❯ Found 2 files
❯ Backfilling file list for commit: 8e2d7e017715e4f0570a6bf95951d28a338f1c2d
❯ Found 4 files
❯ Backfilling file list for commit: 7e4420139c329cc5c390eed3175ccb3fd0508d9f
❯ Found 1 files
✔ Splitting 1 commits by path
✔ Building candidate release pull request for path: .
❯ type: node
❯ targetBranch: master
❯ commits: 1
✔ Considering: 1 commits
❯ component:
❯ pull request title pattern: undefined
❯ Fetching package.json from branch master
✔ Looking for open release pull requests
✔ found 1 open release pull requests.
✔ Looking for snoozed release pull requests
✔ found 0 snoozed release pull requests.
❯ Fetching package-lock.json from branch master
✔ updating from 1.0.0 to 1.0.1
❯ Fetching npm-shrinkwrap.json from branch master
⚠ file npm-shrinkwrap.json did not exist
❯ Fetching samples/package.json from branch master
⚠ file samples/package.json did not exist
❯ Fetching CHANGELOG.md from branch master
❯ Fetching package.json from branch master
⚠ file changelog.json did not exist
✔ updating from 1.0.0 to 1.0.1
⚠ file .release-please-manifest.json did not exist
❯ Fetching changelog.json from branch master
❯ Fetching .release-please-manifest.json from branch master
✔ Starting GitHub PR workflow...
✔ Successfully found branch HEAD sha "e602ce5c0c64f39c26b4748be347ff77fb4eb4bf".
✔ Skipping branch creation step...
✔ Got the latest commit tree
✔ Successfully created a tree with the desired changes with SHA ba7a9345414aefbb1a51aefdca11477eaf3f1f7f
✔ Successfully created commit. See commit at https://api.github.com/repos/fire-cracker/github-actions-playground/git/commits/115711e5bc7b70e4a04ff9b1d3d1abdbc31ed740
✔ Updating reference heads/release-please--branches--master--components--github-actions-playground to 115711e5bc7b70e4a04ff9b1d3d1abdbc31ed740
✔ Successfully updated reference release-please--branches--master--components--github-actions-playground to 115711e5bc7b70e4a04ff9b1d3d1abdbc31ed740
✔ Found existing pull request for reference fire-cracker:release-please--branches--master--components--github-actions-playground. Skipping creating a new pull request.
✔ Successfully opened pull request: 4.

Additional information
When using command manifest or manifest-pr, the release-please-config.json is utilized however giving their proposed deprecation I am using release-pr instead.

@fire-cracker where you spot that manifest and manifest-pr is going to be deprecated?
But I'm facing the same issue. It was possible for me to move everything from release-please-config.json into workflow file. But it is a bit ugly when it comes to defining changelog-types.

In v3, the release-please-config.json file is only used for command: manifest or command: manifest-pr.
In v4, we default to using the manifest config unless you set the release-type option. We do highly recommend using the manifest config (it is not deprecated).


Company performance voting (See#568)

This is where the user selects the top 3 and bottom 3 companies in the TIKI DAO by subjective score.
The sequence for the selection is-

The user is presented with a list of all the current companies on the network and their scores for that voting period.
The user is asked to present their top 3
The user is asked to present their bottom 3
The user is presented with a dropdown list of all the companies, for all 3 selections. This will also work for the selection fo the bottom 3.
THe user is asked to rank the top three companies by NPS
The user is asked to rank the bottom 3 companies by NPS
The user is presented with their selection on a split page for top scores and bottom scores. This page will have a submit button at the bottom that will submit the user's votes.


Making PrintValues() and ToString() able to not print default elements

Related to #287
Summary
Now PrintValues() and ToString() will not output the elements that were added by default during parsing. There's also the option to call them with a boolean flag that will allow the caller to decide weather they want defaults int the output or not.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] Code check passed (In source directory, run sh tools/code_check.sh)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review

Note to maintainers: Remember to use Squash-Merge

I thought we got to that point, but maybe @azeey should confirm...

I thought we got to that point, but maybe @azeey should confirm...

I think #287 only needed #542, but I remember @marcoag mentioning there were still some issues when upconverting SDFormat files. If that's the case, we should probably keep it open until that's resolved.

Per VC, we should keep the default behavior (when printing via ign sdf -p or using sdf::Element::ToString() of printing values and elements added by default for libsdformat9-libsdformat11. For libsdformat12, we'll change the default behavior to print only user added content.

Now it's a bit of a weird behavior since it will print any default Element but not their default Attributes. Shall we add another flag to print or not attributes in a similar way to Element here?

I suggest we have two behaviors: (1) a default behavior that is consistent with what the code did before this PR, (2) a new behavior enabled by a flag that does not print default elements or attributes.

As agreed on our previous VC this has been added:

[x] kept behavior consistent with the code before this PR (print/toString default elements and not print/toString default attributes).
[x] Added two flags: one to print/toString default elements and another one to print/toString default attributes

As per VC we agreed to not consider default elements those added when the auto-conversion to the latest sdf version happens.


Tic Tac Toe with Computer

Thanks for BrunoDamacena.
I just add a new feature.

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

Your HTML file potentially has references to foul language.
These submissions must be checked manually because of the potential complexity of submissions, if you've reached this point in the process you're most likely a valid submission.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

44d6db2e3e059d096a843210c654adee5612c2f3

Your image is too large to be Base64. Upload it to imgur or some similar image service


"Max exported VST params" ctrlrMaxExportedVstParameters not working as intended

The parameter "Max exported VST params" ctrlrMaxExportedVstParameters is often useless.
If you export a panel as vst restricted instance, from the function getNumModulators() only the highest vstindex should set the limit. But it's not if the vstindex highest number is above 64. From what I can see, it falls back to the default settings from global Ctrlr preferences (64) because of JMAX comparator.
"Max exported VST params" ctrlrMaxExportedVstParameters should be removed/commented.
and CtrlrProcessor::getNumParameters() needs to be updated :
int CtrlrProcessor::getNumParameters()
{
    if (ctrlrManager)
        // return (jmax(ctrlrManager->getNumModulators(true), (int)overridesTree.getProperty (Ids::ctrlrMaxExportedVstParameters))); // Removed 5.6.31 because VST Host was returning 64 params most of the time since panels hardly have more than 64 parameters passed as vst controls
        return (ctrlrManager->getNumModulators(true)); // Updated v5.6.31.
    else
        return (CTRLR_DEFAULT_PARAMETER_COUNT);
}

The question is: why is this needed?
I mean, we have the Export property to decide what to export and we have the VSTindex to sort them according to what we want to see in the DAW (Oscillators together then Filters then... for example).
If a limit would work, it would prevent exporting parameters marked as "Export" and this would be confusing.
Never experienced the limit of 64 but watched it as it was needed to have some .overrides file at a certain moment (tried that but never saw a diff). I have many panels with 100-200 exported parameters

I tried and it's not working anyway because if you load a panel from the stock vst, the parameters won't pass to the host so you'll get 0 control from the host.
I'll probably leave it as is or add statement if panel is single use max vstindex else use the current formula.
Ca permet surtout de pas avoir une liste de 64 parametres affichés pour les automations dans cubase. si j'en ai que deux utiles, il me map quand même les 62 autres sur mon controlleur ou clavier ce qui est pas pratique.

FIXED
I got it working with the following statement :
int CtrlrProcessor::getNumParameters() // Updated 5.6.31
{
    if (ctrlrManager)
        if (ctrlrManager->isSingleInstance())
        {
            return (ctrlrManager->getNumModulators(true)); // Added v5.6.31.
        }
        else
        {
        return (jmax(ctrlrManager->getNumModulators(true), (int)overridesTree.getProperty (Ids::ctrlrMaxExportedVstParameters))); // Updated 5.6.31.
        }
    else
        return (CTRLR_DEFAULT_PARAMETER_COUNT);
}

When opening a panel in ctrlrx.vst we have 64 parameters ready to go as default :

When using a panel as vst instance we only have the max vstindex number of parameters passed to the host (here 4):

I don't have the 8 pages of useless parameters anymore on my MCU controller now, that's cool.


Update examples to use flink-kubernetes-operator 1.10.0-rc1

do not merge now, I need to fully test


New branch

I added an option to not display the divisions, an option to add or remove two boundaries on double tapping the slider, and an option to display a custom tooltip. Only thing I changed with the existing code is the default valueRangePainterCallback to (range) => range.index % 2 == 1. I needed those features for my own app, and I thought that someone might find them useful. I also changed the README to include those new features.

Great job, Adam!
Thanks for your improvements. I will review when I get some time.

@Adam-Mazur hey, I'm revisiting this repo and liked your changes. But they're made in a pretty old lib version.
Would you still want to add them to the package? Please consider merging the current main into your branch so I can review/test it again.

@Adam-Mazur thanks for your time. I'll add some of your changes later.
The ability to hide/show spacers is already in!


Error with List<> inside another List<>

When I have a List<> in my class, and I compare a list of this class I get a strange behavior.
The following code reproduces the problem (also available on Fiddle):
using System.Collections.Generic;
using FluentAssertions;

public class Program
{
	class MyClass
	{
		public string TableName { get; set; }
		public List<string> Columns { get; set; }
	}

	public static void Main()
	{
		List<MyClass> result = new List<MyClass>()
		{
			new MyClass() {TableName = "FIRST_TABLE" },

			new MyClass() {
				TableName = "SECOND_TABLE",
				Columns = new List<string>() {}
			}
		};

		List<MyClass> expected = new List<MyClass>()
		{
			new MyClass() {TableName = "FIRST_TABLE_WITH_DIFFERENT_NAME" },

			new MyClass() {
				TableName = "SECOND_TABLE",
				Columns = new List<string>() {}
			}
		};
		result.ShouldBeEquivalentTo(expected);
	}
}

If I run this code I get the following error:

Run-time exception (line 34): Expected item[0].TableName to be
"FIRST_TABLE_WITH_DIFFERENT_NAME" with a length of 31, but
"SECOND_TABLE" has a length of 12.
Expected item[0].TableName to be
"FIRST_TABLE_WITH_DIFFERENT_NAME", but
"SECOND_TABLE" differs near "SEC" (index 0).
Expected item[0].Columns to be , but found {empty}.

As you can see the collection is inverted, comparing the first item to the second and vice-versa.
If I remove the Columns from both collections then it works correctly:
using System.Collections.Generic;
using FluentAssertions;

public class Program
{
	class MyClass
	{
		public string TableName { get; set; }
		public List<string> Columns { get; set; }
	}

	public static void Main()
	{
		List<MyClass> result = new List<MyClass>()
		{
			new MyClass() {TableName = "FIRST_TABLE" },

			new MyClass() {
				TableName = "SECOND_TABLE",
				//Columns = new List<string>() {}
			}
		};

		List<MyClass> expected = new List<MyClass>()
		{
			new MyClass() {TableName = "FIRST_TABLE_WITH_DIFFERENT_NAME" },

			new MyClass() {
				TableName = "SECOND_TABLE",
				//Columns = new List<string>() {}
			}
		};
		result.ShouldBeEquivalentTo(expected);
	}
}

Run-time exception (line 34): Expected item[0].TableName to be
"FIRST_TABLE_WITH_DIFFERENT_NAME" with a length of 31, but
"FIRST_TABLE" has a length of 11.

By default, it compares collections without caring about the order because it tries to compare collections for equivalence. If you care about the order, you can use the UseStrictOrdering option on the 2nd argument of ShouldBeEquivalentTo.

Hello @dennisdoomen
I have tested the WithStrictOrdering option and it works as expected.
Thank you very much!


fix variable accessed before being defined

may happen in the 'catch' block

Closing as this was fixed in a separate PR. Thanks again!


In Win11 first beta and con-host set as terminal Preview, .bat scripts in Windows startup folder results in error

Windows Terminal version (or Windows build number)
10.0.22000.51
Other Software
No response
Steps to reproduce
First in a updated build, open cmd.exe and select  Terminal preview as a host,  than when reboot If you have some .bat files in the windows startup folder  the following error occur when you login: the application as unable to  start  (0xc0000142).
(Oh and the error box have the Ok button not rounded, but that is another bug).
The problem was not occurring when the cmd.exe was not changed.
Expected Behavior
No error occur and the .bat script is execute with no issues.
Actual Behavior
the following error occur when you login: the application as unable to to start  (0xc0000142).
(Oh and the error box have the Ok button not rounded, but that is another big).

Thanks! /dup #10453

Thanks! /dup #10453

You are welcome!


In OS X Terminal.app, cursor is same color as input text

This is a problem since by default the cursor is a block, so if I place the cursor on a character I can't see it.

This is my top search result for "terminal.app block cursor color" which I googled after having the same issue as others in this thread. Because I prefer the block cursor, I came up with a solution -- set the opacity of the cursor to 50% (or other reasonable value). This actually looks nice and reading what is under the cursor is easy.


If you try to create a PR before your branch is published you get a scary message

I think this occurs when you hit "Create" before the from-branch has updated in the webview (problem 1). Both the dialog and what it does are incorrect. We shouldn't be pushing the into-branch at all (problem 2).
Problem 2 is easily fixed. I don't know how to solve problem 1 because I don't think there's a way to tell the difference between a restore and a fresh launch of the webview. I've reached out for help.


Web Based Query UI - Parameters with a value of 0 are reset to empty each time the query is updated

My Environment

ArangoDB Version:        3.6.5
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   Manual Start
Configuration:               Single Server
Infrastructure:               Nutanex
Operating System:        Windows Server 2016
Total RAM in your machine:        n/a
Disks in use:        n/a
Used Package:              Windows

Component, Query & Data
Affected feature:
When using the Query UI in the ArangoDB Web UI, any parameters that have a value of 0 (zero) are reset to a blank value when any typing occurs in the query window.
Steps to reproduce
1 .Open the Query window in the ArangoDB UI:
2. Type this query:
FOR d IN 0..9
FILTER d == @my_param
RETURN d

Add a value of 0 (the number zero) in the value of the my_param key on the right of the screen.
Run the query and the proper result of [0] will appear
Now press any key in the Query window, and the value for my_param will be reset to a blank value.

If any value other than 0 is assigned to my_param then this bug doesn't happen. It seems as if a falsey test is happening and 0 is being read as a blank value.
Problem:
Parameters with a value of 0 are reset to blank values every type a key is pressed while editing an AQL query.
Expected result:
Parameters with a value of 0 will remain, even if keys are pressed in the Query window.

Hi,
I just noticed there is a second bug very closely related to this one, not sure if you want me to raise a second bug for it.
As you type your query, if you accidentally type @0 then the query param 0 gets added to the right side of the screen.
But if you then delete the @0 from the query screen, it doesn't remove the query param from the right side.
To fix it you have to click on the [JSON] button and delete "0": "" from the query params.
This is also a 0 (zero) based error, so I'm not sure if it's related to the original bug listed here.

hm, yes sounds like some places are treating 0 as False - so I think we can add that here.


sick_scan: 1.6.0-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository sick_scan to 1.6.0-1:

upstream repository: https://github.com/SICKAG/sick_scan.git
release repository: https://github.com/SICKAG/sick_scan-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.3
previous version for package: 1.4.2-1

sick_scan
* NAV 210+NAV245 support added code reformated
* NAV310 added
* Contributors: Michael Lehning

Holding for sync.


StatusRuntimeException - INTERNAL: error when publish to topic [...] the connection has been closed: Sender

In what area(s)?

/area runtime

/area operator
/area placement
/area docs
/area test-and-release

What version of Dapr?

1.1.0

0.2.x
Output of git describe --dirty

Expected Behavior

No "[...]connection has been closed: Sender[...]" errors in the logs
Actual Behavior

During a loadtest, we faced a high increase of errors, saying that connection to azure service bus has been closed by sender, causing messages not beeing published to its related topic.
Steps to Reproduce the Problem

Set up loadtest with following parameters
k8s service with 10 replicas

app container

Limits:
cpu 2500m
memory 600Mi
Requests
cpu 10m
memory 300Mi

sidecar

Limits:
cpu n.n.
memory 4000Mi
Requests
cpu 100m
memory 250Mi

The observed error occured in all pods
Event payload was ~70 Bytes
UseCase was, that one ActorType has ~1.000 Timer registered. All configured with the same dueTime. The business logic in timer callback method was to publish a message to a certain topic.
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:782)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at datadog.trace.bootstrap.instrumentation.java.concurrent.Wrapper.run(Wrapper.java:25)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
	Caused by: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: error when publish to topic [TOPIC_NAME] in pubsub messagebus: the connection has been closed: Sender
	... 16 common frames omitted
	Caused by: io.grpc.StatusRuntimeException: INTERNAL: error when publish to topic

Release Note

RELEASE NOTE:

Maybe there is a relation between this issue and #809 as can be seen in this diagram

During the above described loadtest, we can see the error situation decribed in #809 before the actual "connection has been closed" errors taking place

Hi, @javageek79! We are going to attempt to reproduce this. Would it be possible to share with us your testing code?

We have successfully reproduced this issue:
	debug_error_string = "{"created":"@1618344584.506892614","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"
	debug_error_string = "{"created":"@1618344584.506770514","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"
	debug_error_string = "{"created":"@1618344584.507209614","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"
	debug_error_string = "{"created":"@1618344584.506646213","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"
	debug_error_string = "{"created":"@1618344584.506798114","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"
	debug_error_string = "{"created":"@1618344584.507107114","description":"Error received from peer ipv4:<IP_ADDRESS>:50001","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"error when publish to topic A in pubsub pubsub: the connection has been closed: Sender","grpc_status":13}"

Key to reproduction appears to be a large amount of publisher concurrency with the Azure Service Bus component. We believe we have isolated the issue to pubsub and it does not appear to be related to actors. We're working with the upstream team to figure out if the fastest path will be retrying with the ASB component, or patching the upstream library.

So we were able to root cause our own reproduction of this issue to throttling by the upstream service. It seems we get a very generic error back from the upstream SDK and we are not properly retrying with backoff. The most immediate solution will be to add retry with backoff to the Azure Service Bus Dapr component. We hope to have a release candidate available by end of day PST.


QEMU support for LionsOS

This PR adds QEMU support for LionsOS. It is dependent on the following sDDF PR's: https://github.com/au-ts/sddf/pull/93 and https://github.com/au-ts/sddf/pull/92. It has been tested using the following sDDF branch: https://github.com/au-ts/sddf/tree/qemu.

We will also need to update the documentation for running on QEMU.

This is very close to being merged, but we've unfortunately been blocked on one remaining issue:
The window size is different to the Odroid-C4, and so the framebuffer has a different size. This means that our modfb.c code would to convert some generic window size to the framebuffer specific size. However, this isn't the proper solution.
The proper solution is to have a proper sDDF device class for graphics rather than a client program (in this case MicroPython) directly writing into the framebuffer. This is what @erichchan999 is working on now, once that is in a working state we can finish this off.

This is very close to being merged, but we've unfortunately been blocked on one remaining issue:

I've changed my mind. This is too useful to let it sit here. Everything works except for graphics, we can say that support is experimental on lionsos.org until we get that work.
This PR will unlock all the other example systems working on QEMU as well.
@Kswin01 when you have time, can you rebase this? I will make sure to get it merged quickly so there aren't any more conflicts.


Full UI working without form

Hello,
first of all to say "Thanks" to blueimp for this gr8 plugin.
I had installed the full UI version on my website, right now it is working like a charm.
The last several days I'm trying to make is an ordinary buttons, without a form.
Due to it is set up inside another form it is not going to work. I would like to keep the look , and just to change the form and input elements to escape any conflicts with the other form. Last couple of days I am trying to get it working but I am new to jquery and no solution for the moment. Please if anyone can help. Thanks

Anyone that had solved this?


Suspicious multiplication of ScheduledExecutorService in the method "bindTo" of class "KafkaBinderMetrics"

@Override
public void bindTo(MeterRegistry registry) {
	this.scheduler = Executors.newScheduledThreadPool(this.binder.getTopicsInUse().size());

...
}
As a result, during the initialization of the application at some point, we can observe a lot of threads (for 33 topics, for example, more than 550), the maintenance of which slows down the process and sometimes even results in OOM

@krocodl The thread pool, in this case, is upper bounded by the maximum number of topics. Therefore, you should only observe 33 threads at the most for 33 topics, I am not sure how you get to see 550. Did you do any further triaging to find out how it spawns that many threads?

First of all you created the pool with 1 thread. After you lost the reference on it and created the pool with 2 threads. But, the first pool is not yet collected by GC and now you have 3 threads together. And so on. Each thread does nothing, but it takes system memory and takes part in the scheduling process. After 30 topics, you potentially have (30+1)*15=465 threads. It is already the serious load on the switching contexts.
In my case, the concurrency of the consumer was 5 and cpu was bounded by K8 settings. As a result these pools were not collected by GC in time and the instance was crashed with OOM. In the dump I found more than 2000 threads and start my investigations about strange count of threads.
I think, that it is necessary to shutdown the existing pool before the new creation.

After that I started the service locally, waited for the end of the initialization and immediately made thread dump. In it I found all these threads.

@krocodl Thank you for this analysis. We will try to fix this asap. Pull requests are welcomed to address this issue. If you plan to fix it, please let us know. Otherwise, we will do it on our end.

My next work day is Tuesday. I will try to make a patch that will subscribe to the same event and keep track of the fact that the scheduler field has changed, causing a cleanup for the old version of the value. This will allow me to fix the problem quickly and finally test my hypothesis. In that case, I will make a patch for binder as well. Thanks for the quick response!

Sure, thanks for the update. We have a release scheduled for 3.1.3 next week. Hopefully, we can try to include it in the release.

Proof of the suspicions (the thread dump after start and how "pool-x-thread-y" like threads are created):

The possible fast fix:
@Component
public class KafkaBinderMetricsFinder implements ApplicationListener {
public static final String KAFKA_BINDER_METRICS_BEAN_NAME = "kafkaBinderMetrics";
private final List<ApplicationContext> childContexts = new ArrayList<>();

@Override
public void onApplicationEvent(ContextRefreshedEvent event) {
    childContexts.add((ApplicationContext) event.getSource());
}

public KafkaBinderMetrics getKafkaBinderMetrics() {
    return childContexts.stream()
            .filter(c -> c.containsBean(KAFKA_BINDER_METRICS_BEAN_NAME))
            .map(c -> (KafkaBinderMetrics) c.getBean(KAFKA_BINDER_METRICS_BEAN_NAME))
            .findAny().orElseThrow(() -> new IllegalStateException("Can't find any " + KAFKA_BINDER_METRICS_BEAN_NAME));
}

}
@Slf4j
@Component
@RequiredArgsConstructor
public class KafkaBinderMetricsFixer implements ApplicationListener {
private final KafkaBinderMetricsFinder finder;

private KafkaBinderMetrics kafkaBinderMetrics;
private ScheduledThreadPoolExecutor lastExecutor = null;

@Override
public void onApplicationEvent(BindingCreatedEvent event) {
    ScheduledThreadPoolExecutor current = getCurrentExecutor();
    if (lastExecutor == null) {
        lastExecutor = current;
    } else if (current.getPoolSize() > lastExecutor.getPoolSize()) {
        lastExecutor.shutdown();
        lastExecutor = current;
    }
}

private ScheduledThreadPoolExecutor getCurrentExecutor() {
    kafkaBinderMetrics = kafkaBinderMetrics == null ? finder.getKafkaBinderMetrics() : kafkaBinderMetrics;
    try {
        return (ScheduledThreadPoolExecutor) FieldUtils.readField(kafkaBinderMetrics, "scheduler", true);
    } catch (Exception ex) {
        throw new IllegalStateException("Can't extract ScheduledThreadPoolExecutor from KafkaBinderMetrics", ex);
    }
}

}


How are the methods implemented outside of the domain they are designed for?

For example, DeepSynergy and MatchMaker are requiring cell line information, and they are both implemented in the DrugBankDDI & TWOSIDES benchmarks where no cell line information is available at all (and TWOSIDES is even at the patient level), with DS reaching the highest performance among all methods.  What then was the "cell line gene expression" component in both methods replaced within those tasks?  Also, does this ensure a fair comparison?

I also noticed that all drug features are set to be Morgan FP by design.  However, a lot of those models rely on specific features, e.g. SSI-DDI, CASTER both leverage substructure features.  I am not so sure why features are all unified anyways...?


[Android] Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
Do you plan to fix it?

@lorenc-tomasz  any update?

Can is second this?


Change the way to install maven

Coverage remained the same at 90.842% when pulling 38f34f3166f69beb324c5836d53ab78ee0e0a8c6 on takahi-i:fix-appveyor into 3c0a6ea00e3f60c9058bc4ac751af1a5a668f9d9 on redpen-cc:master.


Not Found (404) Error with Service Discovery - Docker / Consul

Expected Behavior
Reroute to the downstream path.
Actual Behavior
Any request return a Not Found Error(404) with the following message in the VS output window:
warn: Ocelot.Responder.Middleware.ResponderMiddleware[0]  requestId: 0HM2E7R13PE70:00000001, previousRequestId: no previous request id, message: Error Code: ServicesAreEmptyError Message: services were empty for SharepointAPI errors found in ResponderMiddleware. Setting error response for request path:/File, request method: GET

Ocelot.Responder.Middleware.ResponderMiddleware: Warning: requestId: 0HM2E7R13PE70:00000001, previousRequestId: no previous request id, message: Error Code: ServicesAreEmptyError Message: services were empty for SharepointAPI errors found in ResponderMiddleware. Setting error response for request path:/File, request method: GET

Steps to Reproduce the Problem
I created two ASP Net Core Web API projects. The first one implement a API Gateway using Ocelot with Consul and the second one is a simple Web API Service with a endpoint routed to /api/v1/File. Both project are initialized by a docker composer project

Ocelot.json file:

"Routes": [
   {
     "DownstreamPathTemplate": "/api/v1/File",
     "DownstreamScheme": "http",
     "UpstreamPathTemplate": "/File",
     "UpstreamHttpMethod": [ "Get" ],
     "ServiceName": "SharepointAPI",
     "LoadBalancerOptions": {
       "Type": "LeastConnection"
     }
   }
 ],
 "GlobalConfiguration": {
   "ServiceDiscoveryProvider": {
     "Scheme": "http",
     "Host": "consul",
     "Port": 8500,
     "Type": "PollConsul"
   }
 }

Docker composer file

version: '3.4'

services:
    sharepoint.api:
       image: ${DOCKER_REGISTRY-}orderingapi
       hostname: sharepointapi
       build:
           context: .
           dockerfile: Sharepoint.API/Dockerfile
       ports:
           - "8002:80"

   private.gtw:
       image: ${DOCKER_REGISTRY-}privategtw
       build:
           context: .
           dockerfile: Private.Gtw/Dockerfile
      ports:
           - "7000:80"

   consul:
       image: consul:latest
       command: consul agent -dev -log-level=warn -ui -client=<IP_ADDRESS> -bind='{{ GetPrivateIP }}'
       hostname: consul
       ports:
           - "8500:8500"

Startup file

        public void ConfigureServices(IServiceCollection services)
        {
            services
                .AddOcelot()
                .AddConsul();
        }

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseRouting();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
            });

            //ocelot
            app.UseOcelot().Wait();
        }

Output from Consul Monitor

/ # consul monitor
2020-09-01T06:54:40.712Z [INFO]  agent: Deregistered service: service=SharepointAPI
2020-09-01T06:54:40.911Z [INFO]  agent: Synced service: service=SharepointAPI

Specifications
The service looks registered in the web client.
If I ping beetwen the consul container, the private gateway and the service container they can be reached each other.

Nuget Ocelot Version: 16.0.1
Nuget Ocelot.Provider.Consul Version: 16.0.1
Nuget Consul Version: <IP_ADDRESS>
Platform: Net Core 3.1
Subsystem: Windows 10

How can I solve this problem?

I have exactly the same problem. It's obvious that Ocelot does not resolve service routes properly with Consul when deployed to Docker.

Have you tried to repeat the request? I also receive the 404 status code the first time when I use PollConsul type, but subsequent requests are handled well. And it is not dependent on the use of containers.

Have you tried to repeat the request? I also receive the 404 status code the first time when I use PollConsul type, but subsequent requests are handled well. And it is not dependent on the use of containers.

I also have this issue, have you figured out how to fix it?

Nope :(
V sob., 7. nov. 2020 08:45 je oseba LeeStevens318<EMAIL_ADDRESS>napisala:

Have you tried to repeat the request? I also receive the 404 status code
the first time when I use PollConsul type, but subsequent requests are
handled well. And it is not dependent on the use of containers.
I also have this issue, have you figured out how to fix it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ThreeMammals/Ocelot/issues/1329#issuecomment-723413996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJUVCYOP5HQ67XRHZQENCLSOT3I7ANCNFSM4QRLQSCA
.

Hi @jlukawska , I found exactly what you suggest time ago. After clone the project and inspect what it does in the moment to request the collection of registered services in the first async call to the Consul API the result is null, but subsequent requests return a valid collection.
Then I tried to replicate a similar behavior in a simple project but only with Consul, and the first call to the Consul API everything was fine. So, I concluded that the problem isn't related to Consul and perform a double request at the first time isn't a solution to the issue.

Hi @jlukawska , I found exactly what you suggest time ago. After clone the project and inspect what it does in the moment to request the collection of registered services in the first async call to the Consul API the result is null, but subsequent requests return a valid collection.
Then I tried to replicate a similar behavior in a simple project but only with Consul, and the first call to the Consul API everything was fine. So, I concluded that the problem isn't related to Consul and perform a double request at the first time isn't a solution to the issue.

@johha86 , if I remember well the problem is that the first polling starts when application starts. And application starts with the first request and that's why there is no services information yet.

@johha86 , if I remember well the problem is that the first polling starts when application starts. And application starts with the first request and that's why there is no services information yet.

I have the same problem ...first call on every route get me a 404 ... second call is fine....
i cant find a solution to fix this issue... can anyone help me ?

Hi, I had found the reason of the problem and how to fixe it. When you configure Ocelot to use Service Discovery as PollConsul mode, an IServiceDiscoveryProvider is created with a timer in the Constructor. In the callback of the timer, happens the Poll of the available services in Consul into a collection. But the initialization of this timer happens at the first time you call Ocelot. So, the first time you call ocelot, such collection is empty and you receive a Not Found 404. The repository with this code is Archived so I can't do a PR with the Fix. What I did was do a Fork of the repository ,add the fix and use my forked project instead the Nuget Package.
This is how the constructor in my Forked project is:
public PollConsul(int pollingInterval, IOcelotLoggerFactory factory, IServiceDiscoveryProvider consulServiceDiscoveryProvider)
{
   _logger = factory.CreateLogger<PollConsul>();
   _consulServiceDiscoveryProvider = consulServiceDiscoveryProvider;
   _services = new List<Service>();

   //  Do a first Poll before the first Timer callback.
   Poll().Wait();

  _timer = new Timer(async x =>
   {
     if (_polling)
     {
        return;
     }

     _polling = true;
     await Poll();
     _polling = false;
   }, null, pollingInterval, pollingInterval);
}

Other option is implement an IHostedService that perform calls to an endpoint at the beginning of the execution of the application.
I will keep this issue open because the original code doesn't have a solution yet. Maybe I could maintain the original repository.

hmmmm i see your point...
But im not sure... your update is running on the first startup... then it collects the services and hold them...
but i have the 404 on every routes first call... not only initial

Yes, I know. The forked repo with solution is here. This contain the source code of Ocelot.Provider.Consul and I commited my changes into the branch issues-1329-not-found-error-with-consul.

@3dotsDev I'm experiencing the same issue. I'm currently reading the code and I'm trying to implement a suitable solution for me there.
We have the ConsulProviderFactory, it's a singleton. So I thought that carefully maintaining a list with the discovery providers (one discovery provider per service) would do the trick.
In the Polling class, I'm retrieving the clients the first time the Get method is called. The timer is also started there (using a semaphore slim to avoid race conditions).
I'm not sure it's a good solution (neverending debate about locks, concurrent dictionaries or semaphore slim).

@johha86 @3dotsDev
Hello
I'm wondering if this could be a solution...
The idea is the following:
Avoiding polling, retrieving the services until they are available for each request. As soon as the services are available, waiting until "polling interval" reached.
        public async Task<List<Service>> Get()
        {
            await _semaphore.WaitAsync();
            try
            {
                var refreshTime = _lastUpdateTime.AddMilliseconds(_pollingInterval);

                //checking elapsed time + if any service available
                if (refreshTime >= DateTime.UtcNow && _services.Any())
                {
                    return _services;
                }

                _logger.LogInformation($"Retrieving new client information for service: {ServiceName}");
                _services = await _consulServiceDiscoveryProvider.Get();
                _lastUpdateTime = DateTime.UtcNow;

                return _services;
            }
            finally
            {
                _semaphore.Release();
            }
        }

Hello @ggnaegi
If you want to "Avoid polling" I think that you only need to setup Ocelot following the instruction:
"ServiceDiscoveryProvider": {     "Scheme": "https",     "Host": "localhost",     "Port": 8500,     "Type": "Consul" }
The type Consul retrieve the services until they are available on every request. You can found more details here.
The problem that I faced in this issue is when the Type PollConsul is used in the service discovery configuration

@johha86 sure, but then it's for every request and I thought it would help if we wouldn't keep retrieving the services for every request. In my case, I can see quite a performance improvement

@johha86 @matjazbravc @LeeStevens318 @3dotsDev
I believe this bug will be fixed by PR #1670 from @ggnaegi

#1670

Could you review the code and/or verify the solution please?


variant struct

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #1065
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.84%. Comparing base (a0abd92) to head (8c78b93).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1172       +/-   ##
===========================================
- Coverage   68.23%   39.84%   -28.40%
===========================================
  Files         307      307
  Lines       32017    32235      +218
===========================================
- Hits        21847    12844     -9003
- Misses       9218    18969     +9751
+ Partials      952      422      -530

Flag
Coverage Δ

?

go-1.21.x
?

go-1.22.x
39.84% <100.00%> (-27.91%)
:arrow_down:

integration
?

macOS
?

ubuntu
39.84% <100.00%> (+0.66%)
:arrow_up:

unit
39.84% <100.00%> (+0.59%)
:arrow_up:

windows
?

ydb-23.3
?

ydb-24.1
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


transparent overlay only when the drawer is open

I'd like to have a semi transparent overlay over the content like the one on these pictures.

I've tried using styles but main and mainOverlay seem to be always there, even if the drawer is closed.
So how can I achieve this result?
Thanks!

@PierBover Look at the answer here: https://github.com/root-two/react-native-drawer/issues/162

Awesome @dsibiski


Can't build in Windows 10 with update 1903

See the following:
https://developercommunity.visualstudio.com/content/problem/446490/visual-studio-cant-see-winmetadatadirectory-in-cwi.html
This is what happens in Visual Studio:

This is what happens if you remove the references and add them again:

To confirm, the files do exist:

The fix in the link above suggests adding the references like so:
https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/desktop-to-uwp-enhance#to-add-the-required-references-manually
See the last post by Microsoft:
"This was a deliberate change made by Window.
Main gist is, “the WinMetadata directory was only intended for use by the OS.”

Additionally, I just tried all 3 solutions suggested, and none worked.

It seems the solution is to add the following to the project files:
<ItemGroup>
    <PackageReference Include="Microsoft.Windows.SDK.Contracts" Version="10.0.18362.2005" />
  </ItemGroup>

Do you want me to submit a PR?

Thanks for letting me know. However, regardless of whether you have the issue or not, MS are saying what you are doing is fundamentally wrong, and that you should reference the Microsoft.Windows.SDK.Contracts NuGet package instead. I have no doubt you'll be able to reproduce it, but to save you the effort of building out a new dev pc I can just submit a PR tonight if you want?

I had this issue and resolved it with a new VM. I'll try this fix on my old VM and see if it helps!

The references still don't seem to be resolved even when adding this NuGet package. If you're able to get it working, please submit a PR :)

I am targeting .NET Framework 4.6.1 too, I found unless I did this I had the same issue.

Ah, thanks, that does the trick! Unfortunately, it looks like 4.6.0 was the last release that supported Vista, so we will need to drop support for that OS. However, I think it is a worthwhile tradeoff.
Now to decide which version to target for the next release: I am inclined to actually target 4.7.1 while we're at it, but that means potentially any system running older than Windows 10 1709 will require a .NET update for Cairo to run.

This should be fully resolved now.


Next release date

When is next releasing ?

We don't have any ETA, we keep iterating on the branch.
The current plan is to publish alpha versions every week as components are improved.
Then start publishing beta releases once all the component are migrated, or we think enough have been migrated.
Then prereleases to address the blocking issues raised by users.

@oliviertassinari  I am currently using next version 1.0.0 - alpha.16 , can I know if there gonna be any major changes in the coming versions . I am using next version in my current application ( a lot of work is done using this version) and lately I am seeing some bugs ( which I know are expected in alpha version) .I would like to know if there gonna be major changes in the next releases ?Thanks

It depends on what you mean by major changes. I think that it's following the following model. The probability of major changes is inversely correlated to time. The more we move forward, the more likely we are to have found the right solution/tradeoff.

Quick question, we are using<EMAIL_ADDRESS>and have been holding-off on upgrades till the APIs get stable. As per the mui roadmap, prerelease is in progress, I hope the amount of breaking changes in the API for existing components will be few. @oliviertassinari what would you say?

@SukantGujar I would advise you to be up to date with material-ui@next. Holding off on the alpha won't make the upgrade process easier, the opposite actually (where you might have cross-dependency issues and outdated documentation). I only have the visibility for 2-4 breaking changes I want to introduce in the library in the near future. Then, it's about the issue users are raising, people surface problem that sometimes requires breaking changes to be introduced.

We had paused the upgrade because the churn was a little much to handle earlier (esp. with styles) and most of the requirements we had were fulfilled by alpha. Its a large project using several mui components. We wanted to resume the efforts once the waves'd have calmed a bit. We have been keeping an eye on the components we use and things seem to have stabilized now. Alright, will jump in, thanks @oliviertassinari!


Look into  Attempt to present UIAlertController which is already presenting warning

While presenting an alert to enter the password for client certificate, seeing warning related to `already presenting

2023-01-23 14:45:44.896226-0800 AuthenticationExample[28329:387920] [DocumentManager] The view service did terminate with error: Error Domain=_UIViewServiceErrorDomain Code=1 "(null)" UserInfo={Terminated=disconnect method}
2023-01-23 14:45:45.005242-0800 AuthenticationExample[28329:387920] [LayoutConstraints] Changing the translatesAutoresizingMaskIntoConstraints property of a UICollectionViewCell that is managed by a UICollectionView is not supported, and will result in incorrect self-sizing. View: <_UIAlertControllerTextFieldViewCollectionCell: 0x13f4083f0; frame = (0 0; 270 24); gestureRecognizers = <NSArray: 0x600001df2520>; layer = <CALayer: 0x6000013beca0>>
2023-01-23 14:45:45.434019-0800 AuthenticationExample[28329:387920] [Presentation] Attempt to present <UIAlertController: 0x149177400> on <_TtGC7SwiftUI19UIHostingControllerGVS_15ModifiedContentVS_7AnyViewVS_12RootModifier__: 0x149027800> (from <UIViewController: 0x13f228090>) which is already presenting <UIAlertController: 0x13d812800>.

Also, test showCertificateImportError which uses Task.sleep to avoid the already presenting warning. If see the warning then try using MainActor.

See https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/243#discussion_r1084518919 for details.


Marks do not move when buffer changes

Steps to reproduce:

In a file containing this text:

text in line 1
text in line 2
text in line 3

If a set a mark in "text in line 3" line
And then I modify the document in this way

text in line 1
text in line 2
text in line 2.1
text in line 3

then when I go to the mark I set it goes to "text in line 2.1" line instead of going to "text in line 3" as VIM does.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Cryptographic APIs misuses

I'm a PhD student interested in finding security vulnerabilities in open source projects.
We found a total of 10 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on Device Connect (or its library dependencies). We documented each one of these issues in private gists for the sake of confidentiality (non-disclosure).
Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve Device Connect's security, and the quality of the reports of static analysis tools.
(*) https://github.com/CROSSINGTUD/CryptoAnalysis

@misterAnderson90, thanks a lot. Of course, you can share these gists with this account.


For help! Something about LIID in your paper!

I saw the result of LIID reported in your paper, may I ask how to reconstruct it?  There was no body help me. I was too tired.

I just import the results in his paper, and have no idea about its reproducibility.


[Feature Request] Shutdown computer after work is done

I'm suprised that nobody else asked for this before. Sorry, if I missed such a thread or this option in Cupscale.
I think for people with a weak gpu who run the upscale process right before they go to bed, an option to shutdown the computer after finishing the upscale would be useful.

Unless if their computer has limited power usage/uptime, there's really no reason a guy would want to do that. I leave my computer up mining Litecoin all night every night, and, again, there's no real problem aside from power usage on idle and uptime. Overheating isn't a problem anymore these days with the fancy failsafes that computer part vendors are putting into their new chips/cards. FYI, my "computer" is a cheap MSI laptop made of mostly plastic even on the inside. No problems yet, I've had this thing for almost a year now (And ever since I got it, its GPU has been at full load either mining Litecoin by night or playing video games by day. It's average temps are 86C for GPU, 95C for CPU). Sometimes I set it to mine litecoin whenever possible to not have as much as a second of GPU idleness apart from shutting down/restarting/updating drivers.


Switch custom Rng implementation for rand dependency

This shortens the example. The original implementation used a custom rng
implementation to avoid rand dependency, however it's already used as a dev-dependency, so it shouldn't matter.

Nice, thanks!


Show compilation warnings/errors in Messages window

It's a little thing, but it would be nice if warnings and errors showed up in the Messages window, in the same way that compilation results from IntelliJ's built in Make does.  It provides a more compact view of the errors, and line wrapping doesn't seem to be as much of a problem.

Someone tried this on a fork.
https://github.com/omilani/idea-sbt-plugin/commit/11106d53e8c53f9e848c3acda9eb235ab2bed153
I don't have time to integrate this right now, but I agree it would be a big improvement.
In the meantime, do you know you can use ctrl-alt-up/down to navigate to the compile errors in the console output? You have to select the first one. This was broken in some builds of IntelliJ, but works again with Nika 11 EAP.

This would be very nice indeed.


[WIP][SMALLFIX]Remove the client's dependency on zookeeper

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/748/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/749/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/750/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/752/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/753/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/754/
Test PASSed.


Update httpclient Java test code to set port 0 and auto-assign port

With Akka HTTP 10.0.3 fixing https://github.com/akka/akka-http/issues/660, we can now resort to port 0 from hardcoded ports. This should be done when we upgrade to Akka HTTP latest before release.

I have submitted pr #384 for this.


feat: Create a Growthbook server side provider

This PR

adds a new OpenFeature GrowthBook server provider

How to test
Integrate OpenFeature into a test node server and set it up with this new GrowthBook provider. Ensure that GrowthBook flag evaluation works as expected using the OpenFeature API
How to set up OpenFeature with node
OpenFeature.setProvider(new GrowthbookProvider(gbContext, initOptions))

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

@beeme1mr I rebased on the main branch of my fork and it seems like there's still CI issues with the e2e and the lint-test-build. Should I be rebasing on open-feature:main instead?

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

@beeme1mr I rebased on the main branch of my fork and it seems like there's still CI issues with the e2e and the lint-test-build. Should I be rebasing on open-feature:main instead?

Yes, open-feature:main should be your branch to rebase on.


sync gsdevkit/Grease from SeasideSt/Grease

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


File System/Subclient

Is there a way to clear filter_content in a subclient? We have a complex application and are using the CVPySDK, great tool btw, to update the content and the filter_content then starting backup jobs and monitoring them. Seems filter content does not like an empty list or None.

This has been fixed with the latest change on the dev branch.
https://github.com/Commvault/cvpysdk/blob/dev/cvpysdk/subclients/fssubclient.py#L491

I looked at the changes and with holidays just getting around to updating our cvpysdk code. Seems to work as desired, passing an empty list instead of having to add "dummy" content.


Logo is leading to the Private Cloud products page even on the Public Cloud tab

Describe the bug/ Actual behaviour
Logo is leading to the Private Cloud products page even on the Public Cloud tab. - It would be nice to do before go-live. Priority: M. Size: S. Assignee: Oamar
Definition of done:
Bug is fixed and software behaves as expected.

Now we have a back button on the Product Page, Request Page and Edit Page. So the logo wouldn't be clicked that much and the task looses it's priority.

Now the logo leads to Private Cloud from any Private Cloud page and to Public Cloud from any Public Cloud page.


doc: Move deprecated driver socket documentation to v1.0.0

It doesn't make sense to be v0.8.1 doc since we haven't removed the compatible CSI plugin then.

Done


Smooth Package Overhaul

I worked with the smooth package quite a bit during my PhD. During that time I've noticed some things that I would like to update. At the end of the day, my goal is to add a new correlation model that I implemented as part of my PhD in the MITgcm, but I think it would be a good idea to clean up the current implementation first.
I have implemented all fixes/changes relevant to each item discussed below (except for good documentation and the proposed deprecated file removal), in my branch: https://github.com/timothyas/mitgcm/tree/rewrite-smooth
See also a verification setup for the smooth package here:
https://github.com/timothyas/verification_other/tree/feature/smooth_verification
I'm making this issue so that anyone else can add changes they would like to see, and so we can discuss what the best path forward is. For instance should I make one PR that completely overhauls all of the smooth package in one go? Or should we make it more fragmented? Note that a lot of the changes discussed below are breaking changes, because changing runtime parameters in data.smooth requires users to have new data.smooth files.
Documentation
This one is obvious, and I'm happy to add documentation for the smooth package including:

Brief, general description of what it does
Citations to relevant literature
Runtime/compile time options

Note: see my SMOOTH.h which documents the proposed (and existing) smooth parameters in a "bare minimum" way: https://github.com/timothyas/MITgcm/blob/rewrite-smooth/pkg/smooth/SMOOTH.h
Bugs

Right now, when smooth_filtervar[2/3]d are run, the random number generator on each processor is initialized with the same seed, so each process generates the same sequence of random numbers. As a result, there can be a repeating spatial pattern imprinted on the random numbers. For example:

Note that 1. I made this exaggerated by taking the tutorial_global_ocean_latlon and splitting it across 9 processes and 2) we really only clearly see this behavior in the first random sample in domains with any sort of interesting topography. That is because the port_rand_norm function is only called when mask>0, so after the first sample each processor is at a different RNG seed simply because it has been called a different number of times due to differing topography in each processor... this would be a huge problem for idealized models though!
One possible fix is to use each process's PID to initialize random seeds on each process. This is what I did for a purely MPI based setup, and we could probably extend this to threads (if necessary?) easily. I implemented this, and here we can see that things look random, as they should...

See code: https://github.com/timothyas/MITgcm/blob/dfa1ad4a0bd8bbdb1816a7194196399c8b191789/pkg/smooth/smooth_filtervar2d.F#L103-L104

Right now there is a code block that limits the vertical correlation length scale to be at maximum the vertical spacing at that vertical level: https://github.com/MITgcm/MITgcm/blob/c69ccc91fbb4499bfe63de69290b8572a14e2ae6/pkg/smooth/smooth_init3d.F#L78-L96
A comment above suggests that this is to limit excessive smoothing, but I am almost positive that many people do not know that this limit is being imposed. This may not be problematic for systems like ECCOv4, but as a specific example, this would be a problem for anyone modeling ice shelves and using a very small, constant, vertical grid spacing.
Proposed solution: Add a boolean flag smooth3DUseDRCMaxLz which is default set to FALSE. User can change this flag at runtime.

Confusing runtime parameters
In each of these I use ND to mean both 2D and 3D

smoothNDtype: integer value either 0, 1, 2. If 0, then don't compute the filter normalization. If 1, use a randomized method to compute filter normalization. If 2, use a hand coded "exact" approach to compute the normalization, except that (a) this method does not scale to large systems well and (b) this method requires an adjoint of smooth_diff2d.  See how it is currently handled (or not!): https://github.com/MITgcm/MITgcm/blob/c69ccc91fbb4499bfe63de69290b8572a14e2ae6/pkg/smooth/smooth_filtervar2d.F#L145-L151
Proposed change: I propose to change this to a LOGICAL smoothNDCalcNormFactor, where if TRUE then use the randomized method to calculate the normalization factor, otherwise don't (for instance, if it's already been computed and we are providing it as an input file). And, just get rid of the hand coded "exact", which fails right now anyway.

smoothNDsize: integer value that determines how the correlation length scale is set. If 2, then look for a file named smoothNDscales which has the length scales in each direction, as records. (For 3D it looks for files scalesH and scalesZ for horizontal and vertical ...). If not 2, then set length based on fixed values Lx/y/z_0 which can be set in data.smooth
Proposed changes: Use logicals smooth2DConstHorizontal , smooth3DConstHorizontal, smooth3DConstVertical. If True, use Lx_0 (or similar for y, z) to set a constant length scale, otherwise look for spatially varying field

Expected files: In the case of a spatially varying length scale, pkg/smooth expects, for 2D: a 2 record file with first record Lx and second record Ly. For 3D, it expects one file smooth3DscalesH like the 2D, and a separate smooth3DscalesZ for the vertical length scale. Then, it writes the elements of the diffusion operator with records K11 and K22 for 2D case, using the notation Kij referring to the location in a 2D tensor. Then for the 3D case it writes out a single file with records (in this order): K31, K32, K33 ,K11, K22, K13, K23, K12, K21 ... this order only makes sense if we start to think about nonzero entries in a GMRedi-like tensor, but I'd say it's still ... unique. In any case, based on my own experience, this is pretty error prone.
Proposed changes: Read and write separate, clearly named files in all of these cases.

Overlap with pkg/ctrl: When a user wants to apply a smoothing operator to a control field, they specify in data.ctrl whether or not they want to use the full operator from Weaver and Courtier, 2001 or just the diffusion operator part of it (i.e., apply normalization or not). Right now these options are passed to xx_gen*_preproc as wc01 or smooth for the full operator or just diffusion, and xx_gen*_preproc_i takes the corresponding operator number.
Proposed changes: Deprecate / remove the xx_gen*preproc specification of wc01 etc, but still provide the operator number to xx_gen*_preproc_i. Then, make a new runtime parameter in the smooth package smoothNdApplyNorm for whether or not to apply the normalization (True => WC01, False => smooth).

Proposed file deprecation/removal

smooth2d.f and smooth3d.f:

These are essentially calling smooth_diffnd
They are only called from

ctrl_map_ini_gen[2,3]d, called from ctrl_map_ini_ecco, which is deprecated
ctrl_get_gen, but I think this code block (and lines 157-165) should be removed too for the following reasons. First, the smoothing is now done at initialization time, called from ctrl_map_ini_gentim2d. If smooth2d is called again from this routine, I am pretty sure the user will get smoothing/correlation that they are not expecting (and requires the lesser known CPP Macro ALLOW_SMOOTH_CTRL2D). Secondly, this is not general, and does not allow the user to use any other correlation model other than running a simple diffusion operator (i.e., not even WC01).

smooth_basic2d and smooth_hetero2d: these provide really small tweaks to the more general smooth_diff2d. Specifically, they specify constant length scale and number of iterations (basic) or length scales based on file (hetero), which should instead be handled by making different operators in data.smooth. These two subroutines are used in pkg/ecco/cost_gencost_bpv4 and pkg/ecco/cost_gencost_sshv4. In the second one, there is a similar overlap between ecco and smooth packages in a similar way to the ctrl package as described above.

Other small things

It would be nice to have a different number of 2D and 3D operators, whereas right now we have the same maximum number for both: smoothNbMax.
It would be nice to specify the number of random samples taken to form the filter normalization smoothOpNbRand
In #445 I added the smoothMaskName variable to allow for different masks other than maskC. This is a 5 character variable where we only check for the last character (e.g. C, W, S,...). It would probably be more straightforward to make this a single character variable.
It might be nice to write out the samples used to compute the randomized filter normalization factor. This would not be the default, because it would usually involve writing out thousands of random fields, but my proposed change is to add a LOGICAL smoothNDWriteSamples which the user can toggle (per operator) to write out the samples.

Thanks for working on this. Will try to read through asap


doesn't play well with standard es modules

This script doesn't play well with ES modules.
Also, should definitely be ported to vanilla JS.

Duplicate of https://github.com/select2/select2/issues/6196


Pod priority based graceful node shutdown docs placeholder

Placeholder PR for
Enhancement: https://github.com/kubernetes/enhancements/issues/2712

/assign @jlbutler

/sig node

/retitle [WIP] Document pod priority based graceful node shutdown

@mrunalp Reminder that tomorrow Nov 23rd is the deadline for 1.23 Docs Ready for Review. Please push your docs content for this enhancement and remove the work-in-progress label when ready for review.
We have a tight turnaround to getting docs reviewed and approved for the release, and we're hoping to have all docs in for review by EOB tomorrow. Thank you!

We have a PR here for docs for this feature: https://github.com/kubernetes/website/pull/30611


[FLINK-36573][cdc-connector][mysql] Add table information of binlog offsets when checkpointing

Seems that the CI  test of 2024-10-30T13:03:29.2042562Z [ERROR] TransformE2eITCase.testHeteroSchemaTransform  Time elapsed: 74.649 s  <<< ERROR! 2024-10-30T13:03:29.2049354Z java.util.concurrent.TimeoutException:  2024-10-30T13:03:29.2060983Z failed to get specific event: CreateTableEvent{tableId=transform_test_1n9c6jg.terminus, schema=columns={ID INT NOT NULL,VERSION` VARCHAR(17)}, primaryKeys=ID, options=()} from stdout: Starting Task Manager

Seems that the CI test of 2024-10-30T13:03:29.2042562Z [ERROR] TransformE2eITCase.testHeteroSchemaTransform Time elapsed: 74.649 s <<< ERROR! 2024-10-30T13:03:29.2049354Z java.util.concurrent.TimeoutException: 2024-10-30T13:03:29.2060983Z failed to get specific event: CreateTableEvent{tableId=transform_test_1n9c6jg.terminus, schema=columns={ID INT NOT NULL,VERSION` VARCHAR(17)}, primaryKeys=ID, options=()} from stdout: Starting Task Manager

I remember it's caused by a known bug in parallelised schema evolution processes and could be safely ignored.
The questionable exception messages are something like this:
3> Schema Registry is busy now, waiting for next request...
[Repeated lines]

@leonardBang @yuxiqian Could you help to retrigger the CI?

@leonardBang @yuxiqian Would you like to review again since the CI is passed? Thanks a lot.

@leonardBang @lvyanquan @yuxiqian Thanks for the review. All comments resolved, would you like to help review again?


hip-config only adds compile and link options to C++

Previous to these any target that has mixed languages ( C++ && Fortran )
would break as the HIP specific flags such as '-x hip' would be past
to the Fortran compiler.

Thanks this is affecting my AMD GPU port of the GENE fusion code, which is mixed Fortran and C++.

@yxsamliu is there any progress on this? This also affects the ECP AMReX and ECP WarpX projects.


Mapping CRD silently fails validation with invalid config

When invalid configuration is provided in retry_policy for example per_try_timeout: "1,2,4,8,16" Ambassador silently fails when applying the CRD.
Steps to reproduce the behavior:

Apply the configuration below
No errors are returned
Inspect the mappings configured in Ambassador kubectl get mappings
The applied configuration will not be present in the system

---
apiVersion: getambassador.io/v1
kind: Mapping
metadata:
  name: consul-api-mapping
  namespace: default
spec:
  prefix: /api/
  timeout_ms: 20000
  idle_timeout_ms: 600000
  connect_timeout_ms: 1000
  retry_policy:
    retry_on: "5xx"
    num_retries: 10
    per_try_timeout: "1,2,4,8,16"
  host: emojify.today
  service: emojify-api-sidecar-proxy
  resolver: consul-dc1
  tls: ambassador-consul
  load_balancer:
    policy: round_robin

I would expect a validation error to be returned when applying the invalid configuration
Versions (please complete the following information):

Ambassador: [e.g. 0.70.1]
Kubernetes environment [Digital Ocean]
Version [1.12.3]

@nicholasjackson I've also been experiencing issues with the per_try_timeout setting. (Ambassador v0.73 currently).
I was only ever able to get it to validate successfully by specifying it like this:
per_try_timeout: "2s"
Even thought I thought it's supposed to be a duration, setting it to per_try_timeout: "2000ms" did not work

As mentioned by @neufeldtech per_try_timeout field in retry policy doesnt seem to work. Only values that seems to work in 1s, 2s etc. But 1500ms as mentioned in documentation fails the mapping


5E SRD: Add 7th-Level Spells to Spell List

The following 7th Level Spells from the 5th Edition System Reference Document (5e SRD) need to be added in Markdown format to the site under the _posts/spells/seventh-level/ directory. There will be a template-spell.md file in the spells folder for use as needed.
Specifications

Post should be titled YYYY-MM-DD-spells-7-<spell_name>.md

EXAMPLE: 2020-10-10-spells-0-kaboom.md

Follow template-spell.md format for inputting spell information. Info should include:

Spell Name (Druid Splash)
School (i.e. Evocation, Necromancy)
Casting Time (i.e. 1 Bonus Action)
Range (i.e. Self / 60 Feet)
Duration (i.e. Instantaneous)
Components (i.e. V, S, M)

Pull requests should include completed spell post in the proper directory: _posts/spells/cantrips/YYYY-MM-DD-spells-7-<spell_name>.md

Spells Needed

[ ] Conjure Celestial

[ ] Conjure Hezrou (UA)

[ ] Crown of Stars

[ ] Delayed Blast Fireball

[ ] Divine Word

[ ] Etherealness

[ ] Finger of Death

[ ] Fire Storm

[ ] Forcecage

[ ] Mirage Arcane

[ ] Mordenkainen's Magnificent Mansion

[ ] Mordenkainen's Sword

[ ] Plane Shift

[ ] Power Word: Pain

[ ] Prismatic Spray

[ ] Project Image

[ ] Regenerate

[ ] Resurrection

[ ] Reverse Gravity

[ ] Sequester

[ ] Simulacrum

[ ] Symbol

[ ] Teleport

[ ] Tether Essence

[ ] Whirlwind

PR includes:

Conjure Celestial
Delayed Blast Fireball
Divine Word
Etherealness
Fire Storm
Forcecage
Mirage Arcane
Plane Shift
Prismatic Spray
Project Image
Regenerate
Resurrection
Reverse Gravity
Sequester
Simulacrum
Symbol
Teleport

Finished this out with most recent commit, closing this issue out


[dsx] deal with the metadata being out of sync with the market name for bitcoin cash

do we solve this problem on the library level?
BitBay also uses BCC for Bitcoin Cash instead of BCH and I see not correction of this type in its code

No it's just a thing for DSX.  They are mid way through renaming their bitcoin cash symbol from bcc to bch


[CLIENT] Client parses commands corresponding to the client endpoints on the server

What needs to be done?
The server endspoints for the client can be consumed through the CLI tool
Acceptance criteria
(Copy of #14 )

[ ] Listing servers and their health
[ ] Listing labs and their locations
[ ] CRD actions for labs

[ ] Create
[ ] READ
[ ] DELETE

Perhaps to make the client CLI tool more efficient, maybe it should be a long running program that uses some TUI library to keep running and show results + take inputs.
Idea: https://github.com/charmbracelet/bubbletea


Fix flaky TestListPaymentRequestWithSortOrder server test

Description
This PR attempts to fix a flaky server test that has been randomly failing the last couple of days.  The two subtests that are failing attempt to check whether the sort order being returned by the database matches the expected sort order.  The problem appears to be a difference in sort collation between sorting in Postgres and sorting in Go.  This difference causes a potential failure when two duty station names are generated where one starts with an upper case letter and the other starts with a lower case letter (note that we generate a random duty station name when creating a duty station if one is not provided via an assertion).
Looking at the test setup, I don’t think the intention was to have randomly generated duty station names.  There are some names attempting to be set, but they weren't actually being set based on how the assertions propagate down through the testdatagen makers (e.g., there's an OriginDutyStation and a DutyStation in the assertions, each used in different places).  So, we were getting the random duty station names.  I just adjusted the test setup to explicitly create a couple of duty stations first, use them in the assertions, and now the origin duty stations are set as expected.  Both explicitly set duty station names use capital letters, so this hopefully bypasses any collation concerns and fixes the flaky test.
Setup
Run make server_test and ensure there are no test failures.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against a27439aee4d5439afa09f9306f357ccd3863ac78


Add extended buildinfo to metadata

Extensions for re-recreatable builds as per: adoptium/temurin-build#2594 (comment)
Signed-off-by: Andrew Leonard<EMAIL_ADDRESS>

run tests


feat(svc): add dynamic server create op

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#756  👈
#755
#750
#751
#747
#740
#743
#754
#741
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AngelOnFira and the rest of your teammates on  Graphite


test db_to_df batching

Exact same change as in #271, just cleaning up the already-merged commits.

(turns out Travis doesn't like it when you merge a PR while its trying to pull it, but as expected from tests passing in #271, the merged build passes despite the complaint above: https://app.travis-ci.com/github/IQuOD/AutoQC/builds/231839834)


SSL/HTTPS setup?

Hi Folks,
What is the best way to use rest-util (schema service, kafka-rest, etc) with HTTPS?
Is it better to make it native with Jetty? Or better to use a proxy that terminates HTTPS? Is there any example solution documentation?
Thanks a lot!
-Yushu

Replying to myself. I have created a patch to enable SSL with Jetty ( with minimal modifications to the rest-util). It adds several configuration settings


Online updater

An online updater that checks qb64.org/inform for an updated version, downloads the new source files and recompiles the editor and the preview.

Added with 2289deb14ddcd3330cbc4db79d06c26d297e12fc


[Node.js] Add functionality of showing fps to examples

@halton This enables QA to check fps during pnp test, PTAL, thanks.

@halton I have updated, PTAL, thanks.


SDMolSupplier with removeHs=False throws an error

Using removeHs changes whether an SDF file can actually be parsed. A little surprising that would affect whether an SDF could be parsed, wasn't expecting removeHs to work at the parser level. While a wacky molecule, the file looks legitimate to me.
In [18]: m = Chem.MolFromMolFile('results.sdf', removeHs=False)

In [19]: supp = Chem.ForwardSDMolSupplier('results.sdf')

In [20]: supp.next()
Out[20]: <rdkit.Chem.rdchem.Mol at 0x10e118f30>

In [21]: supp = Chem.ForwardSDMolSupplier('results.sdf', removeHs=False)

In [22]: supp.next()
[21:24:36] Unexpected error hit on line 510
[21:24:36] ERROR: moving to the begining of the next molecule

In [23]: supp = Chem.SDMolSupplier('results.sdf', removeHs=False)

In [24]: supp.next()
[21:25:01] Unexpected error hit on line 510
[21:25:01] ERROR: moving to the begining of the next molecule

In [25]: supp = Chem.SDMolSupplier('results.sdf')

In [26]: supp.next()
Out[26]: <rdkit.Chem.rdchem.Mol at 0x10de759f0>

In [32]: Chem.MolFromMolFile('results.sdf') is None
Out[32]: False

In [33]: Chem.MolFromMolFile('results.sdf', removeHs=False) is None
Out[33]: True

In [34]: import rdkit

In [35]: rdkit.__version__
Out[35]: '2018.03.1'

I've attached the offending .sdf file.
results.sdf.txt

@coleb I can duplicate this and think I know the problem.  I'll keep you posted.

@coleb @greglandrum It looks like it is fixed in the current master.

Should I add a regression test?  Can I use this file?

You’re free to use that file in a test, it was a completely randomly invented molecule.
Thanks for the fix and the test!
-Brian

On Feb 27, 2019, at 2:20 PM, Brian Kelley<EMAIL_ADDRESS>wrote:
Should I add a regression test? Can I use this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Castbar/Auras update inline with latest oUF.

https://www.wowinterface.com/forums/showthread.php?t=55422

Thanks! 😀


plugin crashes when not embedded in CODAP

My approach was going to be to wrap the calls to initPhone below in a try/catch and render some kind of error if it fails, but this seems tricky because initPhone is asynchronous and I'm not sure how to make the App component async or if that's even the best solution here.
https://github.com/P-bibs/CODAP-flow/blob/0a84be141ad4ef65c48326deb331ea42e62adb6c/src/App.tsx#L7-L24
Thoughts? @P-bibs @stardust66

Since async/await is just sugar around promises, you could also do initPhone(...).catch(err => ...), and maybe set state there that triggers an error display?


[Bug]: Unable to select dates from calender when default date field is configured in js

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we configure anything on Default date property of JSONForm datepicker field type, the dates other than default are not getting selected from calender
Steps To Reproduce

Drag & Drop a JSONForm
Configure setting for Datepicker field type
Enable js editor for Default date property
Bind the field. for eg: use `moment()'
Now click on datepicker field to select a date
Observe that other than default dates are not getting selected

Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/df47bd1df14b457ba37dc827a8573ab8?sid=4f80bf46-fe8c-4abd-92bb-56a83d418219
Version
Cloud/Production

Hi @chandannkumar,
Thank you for raising this issue. The behavior you're observing—where the value of the DatePicker input resets when the default value changes—is expected. This happens because your default value is dynamic (moment()).
A more robust approach would be to define your dynamic value in a JS Object and then reference it in the defaultValue field of the DatePicker. For example:
JSObject1.currentTime
I've attached a link to a public app demonstrating this behaviour for your reference. Please feel free to check it out and let us know if you have further questions.
Thanks!


Adding a side Navbar.

Issue Type:

[ ] Bug Report
[x] Feature Request
[ ] Documentaion

Describe the bug
-It is difficult to scroll a lot and find the desired template. To minimize the time and enhance accessibility, I want to add a side navbar.
Possible solution

The side navbar will make it easier for the user to access any template by name from the index shown on the left side.
The sample side navbar's screenshot is shown below.

Screenshots

@arpit456jain I'm the participant of GSSoC'22, kindly assign this issue to me.


⚠ Cioos Atlantic CKAN has degraded performance

In b03bb85, Cioos Atlantic CKAN (https://catalogue.cioosatlantic.ca/) experienced degraded performance:

HTTP code: 503
Response time: 18325 ms

Resolved: Cioos Atlantic CKAN performance has improved in e79fd5c.


Add changelog

#725  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.