Build failed on Cygwin when C++03 specified

As the target DSP compiler only supports C++03, I am forced to build CppUTest using mentioned standard. The compilation fails on \Gcc\UtestPlatform.cpp, PlatformSpecificVSNprintf(). The functions snprintf/vsnprintf are not supported in this standard.

Oh, they aren't? How would they implement it then?

Yes, the safe version of mentioned functions are only available when C99 or C++11 is specified.
Because this function needs special treatment on many platforms, maybe it can be implemented independently? In my project I am using small snrprintf() from AVR library, with a few modifications, supporting I think 90% of full sprintf library features. What do you think about this?

On the long run, the vsnprintf functionality is on the list of implementing ourselves... so that we have less platform dependencies. On the short run, I suggest to fix it with a #ifdef in the PlatformSpecific file (checking on C version) and call the non-secure versions?

@mmidor it's been a while....
I presume  snrprintf() is available in source? Are any copyright restrictions attached to it? We copied a lot of the C string functions that are now in SimpleString from various sources, because most of these are very well-known algorithms, where copyright isn't really an issue, because it has been done like that for decades...
If the copyright issue can be sorted out, then I would think snrprintf() might be a good starting point for our own implementation of this functionality and taking it out of the platform-specific file entirely.
What do you think @basvodde ?

I'd prefer to write it and test-drive it than to copy an existing version. We can use an existing version as guide, but not just copy it.

That's basically more or less what I meant. Test-drive-write-along-the-lines-of-the-existing-code-a-piece-at-a-time ;-). I suppose since that essentially means a re-write, then copyright would be a non-issue?
I think this type of stuff is fairly involved and having a good 'prototype' might make the difference.


Past releases page - many links are broken

Many of the links on the past releases page:
https://dubbo.apache.org/en/blog/2020/05/18/past-releases/
are broken
Also the Dubbo Admin section does not link to the release:
https://dubbo.apache.org/en/blog/2020/05/18/past-releases/#dubbo-admin

I tested it, and now this link can be opened.

Sorry, I was unclear.
The link to the Admin section works, but the section does not contain the correct information.
There should be a link to the source/binary packages (using the mirror system) and links for sigs and hashes.
i.e. there are no proper release links.


There is no point in receiving a string as context.

Instead of passing two strings, the user can just as well join them

@pixelhandler @rwjblue What do you think about this?
find(selector, context) only allows HTMLElements as context, but findAll(selector, context) did allow the context to be an HTMLElement or a string.
I believe that there is no point in the second, as if the users wants to call findAll(string, string), they can just as well call findAll(string + ' ' + string). @chriskrycho this would also make the typescript contextual help nicer.


Imou Cell Go camera supported

Hello
Once the camera modelo Imou Cell Go as improved in this release:

But I'm still not able to view or access to the live stream, I'm question If I need to perform any further actions in order to get this?
Once there are some people that have this feature working https://github.com/user2684/imou_life/issues/55
Thank you

Hi, the improvement of that version #55 was more on controlling the camera, not the video stream so it has no impact on it.
Video stream issues are reported by different users across different models unfortunately, especially on shared devices. Not much I can do unfortunately since it is the remote API throwing an error and Imou is no more releasing updated documentation which can allow me to understand if they have changed something on their side :-(

Hi all, does anyone know how to access the HTTP stream for the Cell Go? I mean you can access it in the Imou app with the lan tool, so surely it's available. I just can't seem to find the right connection string.

@user2684 may I request additional sensors and controls to the Cell Go camera. How about a Charging sensor to show if the camera is plugged in and a control to change the Performance Mode.

Hi @mcceeq for the HTTP stream, I wonder if RTSP would work best, I've seen users using it but not myself so I do not have instructions to share. As for the Charging sensor, I couldn't find it among the sensors made available via the API unfortunately


Bug with list_direct_messages

Hi,
I'm trying to use the list_direct_messages api but any time I try to iterate through the items it returns I get this error
Traceback (most recent call last):
File "reply_dm.py", line 41, in
main()
File "reply_dm.py", line 36, in main
check_messages(api)
File "reply_dm.py", line 29, in check_messages
for message in tweepy.Cursor(api.list_direct_messages).items():
File "C:\Python27\bot\twitter\lib\site-packages\tweepy\cursor.py", line 195, in next
self.current_page = self.page_iterator.next()
File "C:\Python27\bot\twitter\lib\site-packages\tweepy\cursor.py", line 73, in next
**self.kargs)
File "C:\Python27\bot\twitter\lib\site-packages\tweepy\binder.py", line 250, in _call
return method.execute()
File "C:\Python27\bot\twitter\lib\site-packages\tweepy\binder.py", line 233, in execute
raise TweepError(error_msg, resp, api_code=api_error_code)
tweepy.error.TweepError: [{u'message': u'invalid cursor', u'code': 214}]
Now, I may be doing something wrong, but I tested a few other API methods such as followers and others and those worked (so I think I'm using cursors properly).
Can anyone confirm this is working in their version of Python?

I've made a branch and pull request to fix this. See #1262 for more details.
I'd have liked to release the fix in a v3.8.1 patch release, but I think the change requiring parsers to handle a new return_cursors kwarg warrants waiting until a v3.9 minor version update.
For code block usage, see https://help.github.com/articles/creating-and-highlighting-code-blocks/.


The BufferedReader implementation does not close its underlying Reader

The implementation of close() on the java.io.BufferedReader port is violating its contract.
On close() the BufferedReader implementation  should also close the underlying reader.

The JavaDoc of BufferedReader.close() is actually not very clear about this point. But experimentation suggests that it indeed closes the underlying reader:
Welcome to Scala version 2.11.1 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_60).
Type in expressions to have them evaluated.
Type :help for more information.

scala> class MyReader(s: String) extends java.io.StringReader(s) {
     |   override def close(): Unit = {
     |     println("closing")
     |     super.close()
     |   }
     | }
defined class MyReader

scala> val bf = new java.io.BufferedReader(new MyReader("hello\nthere\n"))
bf: java.io.BufferedReader = java.io.BufferedReader@6692b6c6

scala> bf.readLine()
res0: String = hello

scala> bf.close()
closing

scala> bf.close()

scala>

@sjrd sorry for not providing a test yet, have been busy.
The thing is, no matter what the JavaDoc says or doesn't say, it does not make sense for Reader implementations that wrap other readers, such as BufferedReader to not close their resources. Because we have subtyping and people are accustomed to do stuff like ...
new BufferedReader(new InputStreamReader(new FileInputStream(file), "UTF-8"))

And then work with the resulting reference, passing it around, relying on it to chain the close all the way up to the FileInputStream. These classes would be horrible if they wouldn't close the used resources.

It doesn't matter what the JavaDoc says ... almost, I agree.
But also your reasoning does not really matter either. You might want for some good reason that a Java API does this or that, but if it doesn't on the JVM, we're not going to do it in Scala.js.
The only thing that truly matters is what the JVM does in practice, which, as my snippet above demonstrates, is indeed to close the underlying resource in this case.
So yes, our current implementation is a bug and we must fix it. But not because the new behavior is desirable; simply because that's what the JVM does.
It has happened in the past that we specifically did not do the desirable behavior of some API, because experimentation on the JVM showed that the JVM also did not do the "right" thing.


Use new taplo

also we need to use taplo compiled using release mode

I've published the LSP as a separate package on NPM so you don't have to build it manually, and should be easier to use.
I added proper typescript typings as well so that you more or less know what to expect, an example usage is here, in the VSCode extension (unpublished).
I'm planning to write some additional docs about it on the site, but I'm not quite there yet.

here it is, I've tested it in the VSCode extension, the next published version of it will use this library as well.

@tamasfe thank you for your advice, I have little time to write code but will use npm's one and refactor the structure of this repo next year

Solved at v1.0.3

Solved at v1.0.3


SDK is not managing any rate limiting / retry based on Aftership ratelimit headers.

Hello,
I am currently trying to replace our home made Aftership http client by this SDK but the feature of rate limiting based on the status 429 and the headers is missing. Is that something you are planning to implement?
I've seen in the code some private variables already set about it, not really used though.
    private static final String RATE_LIMIT_RESET = "x-ratelimit-reset";
    private static final String RATE_LIMIT_LIMIT = "x-ratelimit-limit";
    private static final String RATE_LIMIT_REMAINING = "x-ratelimit-remaining";

Thanks :-)

We do not implement the auto-retry feature within the SDK itself as we encourage the user to actually control the request throughput, rather than keep hammering our servers. Also, in the distributed system (more than 1 instance making the request), the auto-retry cannot provide a meaningful retrying mechanism until the user handle the request through adjustment.

We do not implement the auto-retry feature within the SDK itself as we encourage the user to actually control the request throughput, rather than keep hammering our servers. Also, in the distributed system (more than 1 instance making the request), the auto-retry cannot provide a meaningful retrying mechanism until the user handle the request throughput adjustment.

You are correct, but as of today, we have no way to manage the rate limit headers using your SDK without manually overriding your HTTP client, for example.
Additionally, the 429 status code is not handled specifically by the SDK, which means that retrying by default may lead to further strain on the API.
I would appreciate having more informative details in the ApiException, such as when the rate limit will be reset or the rate limit headers, so I can calculate it myself.
Thank you for your time.

Hello @CharlyRien,
we released a new version (7.1.0) and now the header values could be accessed via the ApiException object, for example:
try {
    // making API request
} catch (ApiException e) {
    for (Header header : e.getHeaders()) {
        System.out.println(header.getName() + ": " + header.getValue());
    }
} catch (Exception e) {
    e.printStackTrace();
}

And hence the headers could be accessed without overriding the HTTP client, please check and see if you need more fields / values, thank you very much

Thanks. We will check that :-)

Thanks, we will check that :)


⚠ Bofrost.at has degraded performance

In acdff5e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2507 ms

Resolved: Bofrost.at performance has improved in defee41 after 6 minutes.


[Feat]: Support for Progressive Uploads .

Hi,
I suppose you closed the issue because it is already implemented.
See https://github.com/apivideo/api.video-flutter-uploader/blob/a10f51b7e2e8d8d65664fb4607952f13f6d81bb5/lib/video_uploader.dart#L149


invalid byte sequence in US-ASCI, have no idea with google many times.

22:02:09 - ERROR - Guard::Jasmine failed to achieve its <run_on_modifications>, exception was:

[#] ArgumentError: invalid byte sequence in US-ASCII
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:180:in block in suite_from_first_describe' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:179:inforeach'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:179:in suite_from_first_describe' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:140:inquery_string_for_suite'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:118:in jasmine_suite' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:92:inrun_jasmine_spec'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:57:in block in run' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:55:ineach'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:55:in each_with_object' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine/runner.rb:55:inrun'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-jasmine-2.0.6/lib/guard/jasmine.rb:166:in run_on_modifications' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:82:inblock in _supervise'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:79:in catch' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:79:in_supervise'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:61:in block (3 levels) in run_on_changes' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:56:ineach'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:56:in block (2 levels) in run_on_changes' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:119:inblock (2 levels) in _run_group_plugins'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:117:in each' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:117:inblock in _run_group_plugins'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:116:in catch' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:116:in_run_group_plugins'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:54:in block in run_on_changes' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:53:ineach'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/runner.rb:53:in run_on_changes' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/internals/queue.rb:23:inprocess'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/commander.rb:43:in start' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/cli/environments/valid.rb:16:instart_guard'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/cli.rb:122:in start' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/thor-0.19.1/lib/thor/command.rb:27:inrun'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/thor-0.19.1/lib/thor/invocation.rb:126:in invoke_command' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/thor-0.19.1/lib/thor.rb:359:indispatch'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/thor-0.19.1/lib/thor/base.rb:440:in start' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/aruba_adapter.rb:32:inexecute'
[#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/lib/guard/aruba_adapter.rb:19:in execute!' [#] /Users/ok/.rvm/gems/ruby-2.1.9/gems/guard-2.13.0/bin/_guard-core:11:in'
22:02:09 - INFO - Guard::Jasmine has just been fired

    guard (2.13.0)
      formatador (>= 0.2.4)
      listen (>= 2.7, <= 4.0)
      lumberjack (~> 1.0)
      nenv (~> 0.1)
      notiffany (~> 0.0)
      pry (>= 0.9.12)
      shellany (~> 0.0)
      thor (>= 0.18.1)
    guard-compat (1.2.1)
    guard-jasmine (2.0.6)
      childprocess (~> 0.5)
      guard (~> 2.8)
      guard-compat (~> 1.2)
      jasmine (~> 2.2)
      multi_json (~> 1.1)
      thor (~> 0.19)
      tilt

Thanks for the report @qx  It looks to me like it's probably something in the spec that is outputting strings that aren't valid US-ASCII  However I'm not sure why Ruby's encoding is set to  US-ASCII,  is there something else in your code that's setting that encoding?  For  Ruby 2.x, you can change the encoding via: http://ruby-doc.org/core-2.2.0/Encoding.html#method-c-default_external

@nathanstitt  I don't set encoding.But after I set iterm2's Environment -> set Locale variables automatically, it works ,

on Terminal is the same problem, It seems system problem not jasmine.

Closing since it seems the issue is probably related to system encodings somewhere, sorry it took so long to circle back to this


Docs: Fix made by community twitter/linkedin links

What were you searching in the docs?
The links to my twitter and linkedin handler were broken.
Is this related to an existing documentation section?
We Made This (Community)
How can we improve?
-

Got a suggestion in mind?
No response
Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

Apologies Ran for the incorrect Twitter handler (despite the review).
I'll rebuild the latest docs tomorrow morning

@heitorlessa  no worries! thank you for sharing my work. I really appreciate it.

Now corrected in the latest version: https://awslabs.github.io/aws-lambda-powertools-python/2.0.0/we_made_this/


[SPARK-25635][SQL][BUILD] Support selective direct encoding in native ORC write

What changes were proposed in this pull request?
Before ORC 1.5.3, orc.dictionary.key.threshold and hive.exec.orc.dictionary.key.size.threshold are applied for all columns. This has been a big huddle to enable dictionary encoding. From ORC 1.5.3, orc.column.encoding.direct is added to enforce direct encoding selectively in a column-wise manner. This PR aims to add that feature by upgrading ORC from 1.5.2 to 1.5.3.
The followings are the patches in ORC 1.5.3 and this feature is the only one related to Spark directly.
ORC-406: ORC: Char(n) and Varchar(n) writers truncate to n bytes & corrupts multi-byte data (gopalv)
ORC-403: [C++] Add checks to avoid invalid offsets in InputStream
ORC-405: Remove calcite as a dependency from the benchmarks.
ORC-375: Fix libhdfs on gcc7 by adding #include <functional> two places.
ORC-383: Parallel builds fails with ConcurrentModificationException
ORC-382: Apache rat exclusions + add rat check to travis
ORC-401: Fix incorrect quoting in specification.
ORC-385: Change RecordReader to extend Closeable.
ORC-384: [C++] fix memory leak when loading non-ORC files
ORC-391: [c++] parseType does not accept underscore in the field name
ORC-397: Allow selective disabling of dictionary encoding. Original patch was by Mithun Radhakrishnan.
ORC-389: Add ability to not decode Acid metadata columns

How was this patch tested?
Pass the Jenkins with newly added test cases.

Test build #96907 has started for PR 22622 at commit 39b7fd6.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3662/
Test PASSed.

Merged build finished. Test PASSed.

Test build #96907 has finished for PR 22622 at commit 39b7fd6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96907/
Test PASSed.

Thank you for review, @HyukjinKwon . Sure, I'll update like that.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3685/
Test PASSed.

Test build #96949 has finished for PR 22622 at commit 65ac786.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96949/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3688/
Test PASSed.

Test build #96957 has started for PR 22622 at commit 65ac786.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3695/
Test PASSed.

Merged build finished. Test PASSed.

Test build #96963 has started for PR 22622 at commit 70016e4.

Test build #96963 has finished for PR 22622 at commit 70016e4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96963/
Test FAILed.

Build failure is irrelevant to this PR.
[error] (hive-thriftserver/compile:compileIncremental) javac returned nonzero exit code
[error] Total time: 587 s, completed Oct 4, 2018 8:11:23 PM

retest this please

Which looks now fixed in https://github.com/apache/spark/commit/5ae20cf1a96a33f5de4435fcfb55914d64466525

Test build #96957 has finished for PR 22622 at commit 65ac786.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96957/
Test PASSed.

Test build #96964 has finished for PR 22622 at commit 70016e4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96964/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3701/
Test PASSed.

Test build #96977 has started for PR 22622 at commit 70016e4.

Test build #96977 has finished for PR 22622 at commit 70016e4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96977/
Test PASSed.

@gatorsmile . Could you review this again? For your comment, I added SPARK-25656 Add an example section about how to use Parquet/ORC library options.

Thanks! Merged to master.

Thank you, @gatorsmile, @HyukjinKwon , @viirya , @dilipbiswal !


Added Italian high school

The presentation page of the IT course (in Italian): https://www.isradice.edu.it/index.php/didattica/indirizzi-di-studio/informatica-e-telecomunicazioni

@ganona First stage of verification passed, official domain is isradice.edu.it as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Is the verification process still in progress?

@ganona Thank you for your patience while waiting for a review and processing your request. Pull request merged.


helm create template: split image repository to registry and repository

Output of helm version:
Output of kubectl version:
Cloud Provider/Platform (AKS, GKE, Minikube etc.):

issue content is empty. assuming created in error.


Separate custom filter for each field.

Hello. Is it possible to apply separate custom filter for each field? To have as many filterFn functions as I want.

+1 I'm looking for a suggestion on this as well.


custom $fetch plugin loses typescript

Environment

Operating System: Windows_NT
Node Version:     v20.12.2
Nuxt Version:     3.13.0
CLI Version:      3.12.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
Runtime Modules:  -
Build Modules:    -

Reproduction
Happens in the official docs for custom fetch composable.
Describe the bug
Plugin $customFetch loses the $fetch request typing as $fetch.create returns $Fetch<unknown, NitroFetchRequest>.
This means that using the $customFetch plugin directly (as shown below), loses type safety on the response and produces a ts error:

'$customFetch' is of type 'unknown'

const data = await $customFetch<{date: string, value: number}[]>('/api/path', { method: 'GET' })
// data: type any at this point

Additional context
No response
Logs
No response
Edit: renamed $customFetch plugin to match source

Sorry, I assumed the link that I included was enough for reproduction, but I've simplified the code and placed an example in the useCustomFetch composable: https://stackblitz.com/edit/github-nwhpny?file=composables%2FuseCustomFetch.ts

I have the same Issue


chore: link PRs to linear issues

Closes #3157

Summary

Huge shoutout to @maschad who kindly solved my browser testing problems!

This PR adds a workflow which automatically links PRs to the corresponding linear issues by updating the body of the PR with markdown comments that contain linear-related magic words. The implementation supports all the GitHub magic words (closes, fixes, etc.). If one wants to relate a PR to an issue without setting it as closing for that issue, they can add a "relates to", "related to", or "part of" like this:

Relates to #ISSUE1
Related to #ISSUE2
Part of #ISSUE3

Besides linking issues, I also implemented unlinking issues for cases where somebody erroneously links the wrong issue in GitHub (e.g. wanted to close #ISSUE2 but wrote that it closes #ISSUE1). This isn't automatically handled by linear when the referenced linear issue's identifier is removed from the body of the PR, so I had to call the linearClient.deleteAttachment endpoint directly in these cases.
I initially wanted to implement both linking and unlinking not by modifying the body of the PR but rather by using the API provided by the linear client, but then I realized that doing it like that doesn't add the metadata that gets added when using linear magic words.
Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

Superseded by https://github.com/FuelLabs/github-actions/pull/40.


Add documentation

This improves the documentation for this gem by removing outdated and irrelevant things and adding docs for the public API.

I've removed the commit that moves the template specification.


Extraction fails on SharePoint Server 2013 with SharePointDSC Module Version 4.2.0

SharePointDSC.Reverse VERSION <IP_ADDRESS>

I also have this same exact issue but I am trying to extract from 2016 farm

This issue is caused by the Read-SPFarm function and can be rolved by adding
$params.Remove('ApplicationCredentialKey')

at this place:
https://github.com/microsoft/SharePointDSC.Reverse/blob/5de8a810285f6be40cc3f12bf20f21ced198459e/SharePointDSC.Reverse.ps1#L1109
To really fix this issue, there are some more modifications needed. This should only be done, if the Farm is not a SP2019 or SE one.


Properly capitalize GitHub.

It's a pet peeve of mine to see words like GitHub not capitalized correctly. I've fixed occurrences of Github to GitHub everywhere that isn't code.

Hello @felicianotech,
thank you for submitting this corrections :+1:
Cheers,
Digitalcraftsman
/cc @rdwatters (in case this isn't already reflected in your revamped docs)


Add support for filtering hosts by primary user

Here's how I did it: https://github.com/farmersbusinessnetwork/upvote/commit/4c87e9b59d67215f7430463f68b1984f4ff13cf9

btw, another thing missing for all of these search pages is wildcard support

That whole search widget is definitely less that ideal, and is something that we hope to replace if we overhaul the admin UI.

ok going to add another feature request: sorting by column :)

closing this in favor of https://github.com/google/upvote/issues/24


[WIP] Import and use the CNCF Code of Conduct

This uses a generated import of the CNCF CoC

Approach seems good to me.

I'd expect to see 2 or more commits, one of which actually does the import.

Want to put a Markdown file in source control but not have that render to its own web page? See https://github.com/kubernetes/website/pull/41793/files#diff-6837431359d119c18686bd0377481bf69921b81f4a221801d31e7fbe57aaa642 for an example of a way to do that:
_build:
  list: never
  render: false

@sftim This should be ready for review. Thanks!

Want to put a Markdown file in source control but not have that render to its own web page? See https://github.com/kubernetes/website/pull/41793/files#diff-6837431359d119c18686bd0377481bf69921b81f4a221801d31e7fbe57aaa642 for an example of a way to do that:

Nice! I didn't know about that feature.
Looks like a good method to pull this in and better than keeping a manual copy in repo 👍
/approve

https://deploy-preview-421--kubernetes-contributor.netlify.app/includes/cncf-code-of-conduct/ still renders. Not the end of the world IMO.
/lgtm
/hold
This is an improvement and I'm OK to live with the snag that remains.

/hold cancel


Timepicker or Datetimepicker

[x] I have searched the Issues to see if this bug has already been reported

[feature request]
Summary
The new flowbite-react datepicker is great! I would love a corresponding timepicker or datetimepicker.
Some reference / comparable components for reference:

https://mui.com/x/react-date-pickers/date-time-picker/
https://tailwind-elements.com/docs/standard/forms/timepicker/

Additionally, if the datetime field allows one to type such as "-1 days ago" that'd be even better!

I like this idea, but it isn't available in the main Flowbite library right now. We are really supposed to be following their spec completely, so until that changes, we shouldn't be trying to take this on.

Timepicker is now availbale https://flowbite.com/docs/forms/timepicker/ can we please get a react component of this?


[iOS] 'NSInternalInconsistencyException' while using carouselview plugin

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Don't know about flushed view <Xamarin_Forms_Platform_iOS_Platform_DefaultRenderer: 0x115623d00; frame = (0 0; 414 559.339); autoresize = LM+W+RM+TM+H+BM; layer = <CALayer: 0x1c603c0a0>>'

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'No view controller managing revealed view <Xamarin_Forms_Platform_iOS_Platform_DefaultRenderer: 0x11d37a240; frame = (0 0; 414 559.339); autoresize = LM+W+RM+TM+H+BM; layer = <CALayer: 0x1c242ca20>>'

Getting this exception while using carsoule plugin @alexrainman  can you provide any resolution , if it is known bug

Can you provide a demo reproducing the issue?

I am getting close to release date. Please submit a demo reproducing the issue if you want a fix to be included. Thanks

We were seeing the same error in our application, however it is looking like it has nothing to do with the CarouselView. Our problem was that we were removing an item from a ListView (each item had a CarouselView of scrollable images), but we were doing it in such a way that the CarouselView could still be scrolling to an image after the item was removed. The user would tap say a delete icon overlaying the CarouselView to remove the item from the list, but they would keep scrolling the images while the code was removing the item from the list. This caused the app to crash on iOS. On android it seemed to handle the use case without a crash.
Not sure if this is the same issue others are having, but its worth looking into.

@alexrainman We've experienced this issue where I work.
The issue happens when the child view controllers are disposed of (Lines 919 - 923 of iOS CarouselViewImplementation.cs) during a scrolling/animation event. This can happen if carousel items are updated via some sort of background task and the user is scrolling through the carousel.
I've implemented a fix locally in my work project -- I keep track of when animation and scrolling events are happening as well as when the native view is getting updated. Using these, I disallow scrolling or updating temporarily depending on if the other is going.
I didn't create a pull request for your repo because I've changed the code significantly and I may have broken pieces that aren't specific to our project. If you would like to see the changes I've made, let me know.

Will try to reproduce this.

This will be fixed in the next release.

Facing same problem 😕


Fix Travis so failing tests fail the build

Right now Travis seems to be passing even though in the logs you can see tests are failing. It should fail if the tests are failing.

Fixed in #137


integrate SQ-analysis

Closes #40

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.951%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
304

Relevant Lines:
436

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

19 of 21 (90.48%)  changed or added relevant lines in 5 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.5%) to 74.486%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/TypealizR/StringLocalizer/SourceGenerator.Options.cs
0
1
0.0%

src/TypealizR/StringLocalizer/SourceGenerator.cs
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/TypealizR/StringLocalizer/ClassBuilder.cs
1
97.56%

src/TypealizR/StringLocalizer/SourceGenerator.cs
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
316

Relevant Lines:
448

💛  - Coveralls


Make Mungo work with Apache2/mod_perl2

Reported by jesus on 1 Jan 1970 00:19 UTC
Mungo is only Apache1/mod_perl1 accessible now.  Fix this.

Comment by jesus on 1 Jan 1970 00:19 UTC
(In [17]) first whack at resolving mod_perl2 support. refs #8

Comment by jesus on 1 Jan 1970 00:19 UTC
Looks to work okay.  Only individual tickets for bugs on a case-by-case basis.

Modified by clinton on 1 Jan 1970 00:20 UTC


Remove WIP header and add feedback to README

Removes WIP header from README and adds directions for maintainers and researchers to use GitHub Issues for feedback

LGTM but we should probably keep the WIP header until we're for-real finished, and I'm probably not the one to say whether we are :)


Upgrade Calico CNI to 3.21.3

Issue Description:
The latest RKE1 K8s versions of 1.22.x in KDM include Calico 3.21.1 which has a known regression in client-go, which can cause Canal to lose connectivity on larger clusters (50+ nodes) with a lot of resources/objects (500+) This was fixed in Calico 3.21.3. Typha can disconnect from the datastore when a resync is required such as after an etcd compaction.
More info here -
[https://github.com/projectcalico/calico/issues/5173]
[https://github.com/projectcalico/calico/pull/5332]
Bugfix listed in changelog -
[https://projectcalico.docs.tigera.io/archive/v3.21/release-notes/#v3213]
Business impact:
CNI disruption during an upgrade from 1.21 to 1.22, possible random CNI disruptions.
Troubleshooting steps:
Customer redeployed canal ds after an upgrade from 1.21.10 to 1.22.9.
Noticed a pattern of errors from the calico-node_canal pods as below
{{2022-08-11T02:39:04.747280720Z 2022-08-11 02:39:04.746 [INFO][55] status-reporter/watchercache.go 97: Watch channel closed by remote - recreate watcher ListRoot="/calico/resources/v3/projectcalico.org/caliconodestatuses"}}
{{2022-08-11T02:39:04.844155723Z W0811 02:39:04.843903      51 warnings.go:70] discovery.k8s.io/v1beta1 EndpointSlice is deprecated in v1.21+, unavailable in v1.25+; use discovery.k8s.io/v1 EndpointSlice}}
{{2022-08-11T02:39:04.961869532Z 2022-08-11 02:39:04.961 [INFO][55] status-reporter/watchercache.go 122: Watch error received from Upstream ListRoot="/calico/resources/v3/projectcalico.org/caliconodestatuses" error=too old resource version:<PHONE_NUMBER><PHONE_NUMBER>)}}
{{2022-08-11T02:39:04.961893361Z 2022-08-11 02:39:04.961 [INFO][55] status-reporter/watchercache.go 175: Full resync is required ListRoot="/calico/resources/v3/projectcalico.org/caliconodestatuses"}}
Changing images for Calico to reflect 3.21.3 makes the errors and messages disappear.
Repro steps:

Create a large RKE1 cluster with k8s 1.21.10 & 50+ nodes, canal as CNI
Create a large amount of resources, pods/configmaps/secrets/services etc, 500+
upgrade to 1.22.9, updating calico from 3.17.2 to 3.21.1

Additional context
Other versions are fine as they are using either Calico 3.19.x or Calico 3.22.0 which respectively don't have the regression or have it fixed (https://projectcalico.docs.tigera.io/archive/v3.22/release-notes#v3220).
SURE-5117

@samkulkarni20 Please validate

on 2.6.7, KDM pointing to dev-v2.6, provision a1.22.13 RKE1 cluster and Verify the Calico CNI version is 3.21.3
Run network checks on the above cluster ^^
Upgrade usecase

- - on 2.6.7, KDM pointing to release, provision a `v1.21.14-rancher1-1` RKE1 cluster.
- - Run pre upgrade checks.
- - Upgrade KDM to dev-v2.6
- - Upgrade k8s version to `1.22.13`
- - Verify cluster finishes updating and comes back up Active
- - Run post upgrade checks and verify they pass

Validated upgrade usecase for Calico CNI.

on 2.6.7, KDM pointing to release, provision a v1.21.14-rancher1-1 RKE1 cluster.
Run pre upgrade checks.
Upgrade KDM to dev-v2.6
Upgrade k8s version to 1.22.13
Verify cluster finishes updating and comes back up Active
Verifies the Calico CNI version is 3.21.3
Run post upgrade checks and verify they pass

Validated fresh install checks.

On 2.6.7, KDM pointing to dev-v2.6, provisioned a 1.22.13 RKE1 cluster.
Verified the Calico CNI version is 3.21.3.
Run network checks on the above cluster.
Network checks passed.


Upload multiple files with a glob pattern?

Is it possible to upload multiple files to a gist using a glob pattern?
Something like this?
- uses: actions/checkout@v2
- name: Deploy
  uses: exuanbo/actions-deploy-gist@v1
  with:
    token: ${{ secrets.TOKEN }}
    gist_id: from_your_gist_url
    gist_description: "foos and bars"
    folder_path: ./dist/
    file_path:
    - foo.txt   # relative to folder_path = ./dist/foo.txt
    - bar/*.txt # relative to folder_path = ./dist/bar/*.txt

Thanks for your suggestion, I will implement this in the next minor version.

Any news on this front?


Increased the frame wait timer to account for Holographic Remoting latency

Overview
Latency when connecting via holographic remoting is not standard, and on the 2.8.0 version of the windows XR plugin, the time it takes to register the Hololens is a bit longer, causing the scene content system to mistakenly place the scene content in a different area. This PR increases the wait time before setting the scene content's position, giving Unity a bit more time to initialize the camera in the proper place
Changes

Fixes: #9867

/azp run

should we make this configurable with a default of 15?

It's a very editor specific workaround so I wouldn't want to expose it and make it public if possible.

It might be good to have build in a "transition" when loading in MRTK scene content so we can mask any weirdness with the initialization step in the future (like what hololens and WMR apps do when you first boot them up). I think we can expose this variable when we hit a point where we have a feature like that, but for now it feels a bit obtuse/likely to confuse developers.

/azp run

/azp run


Output redirection using &> not working correctly

The following code has a different behavior between bash and pash
func() {
    echo hi
}

func &> log.txt

In bash, the output would be written to log.txt while using pash the output is written to stdout

It doesn't redirect correctly indeed. I will work on it, however, for now you could use > instead of &>.

Dash seems to behave the same way as PaSh so it must have to do with parsing!
$ rm -f log.txt; bash test.sh; echo "---"; cat log.txt
---
hi
$ rm -f log.txt; sh test.sh; echo "---"; cat log.txt
hi
---
$ rm -f log.txt; ./pa.sh test.sh; echo "---"; cat log.txt
hi
---


Quadratic slowdown on LSTM models in tflite

System information
This reproduces on both colab and my local machine. I assume colab is more standard and thus more interesting, but my local info for completeness:

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, a bit!
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.4.1 (also reproduces on nightly)
Python version: 3.8.5
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
LSTM models experience quadratic slowdown when converted to tflite.
The attached notebook shows the behaviour clearly: when using a standard keras model for predictions, the prediction latency is linear in the length of the sequence provided, as expected. When the same model is converted to tflite, the performance is initially good but scales up quadratically with the input size, and becomes effectively unusable for large sequences.
Describe the expected behavior
I would expect performance to scale linearly with sequence length in tflite, as it does in keras, and as you'd expect from the underlying maths.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1APyFWSL3ln5gZFEotw_5wwUDpaSJrzD-
Other info / logs
The notebook shows the context pretty clearly, but I'm happy to provide more info if needed!

@renjie-liu could you take a look at this performance experiments?

Can you try set fixed input shapes as shown in here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/examples/experimental_new_converter/Keras_LSTM_fusion_Codelab.ipynb
Thanks!

@renjie-liu - I've updated the notebook, and can confirm that with fixed input shapes it is now linear, and quite a bit faster in absolute terms.
First: thanks very much for the pointer! I believe this unblocks my application.
Is the quadratic behaviour of the unoptimized case expected / is that something that could be fixed?

That one seems to be the unfused case.
Haoliang may help take a look? thanks!

The quadratic time was coming from the underlying tensorlist I believe. Currently a TensorListSetItem is written to two concatenation op, it will have O(n) complexity for one single operation (where n is the sequence length). This will be a problem when the sequence length becomes very long in general. And great that fused LSTM is working in this case!

Would it make sense to keep this open to track the quadratic complexity in the unfused case, or should I let the butler close it?

Hi, we currently don't have plans to optimize the unfused quadratic complexity issue. Are you able to use fused LSTM in tflite instead?
https://groups.google.com/a/tensorflow.org/g/tflite/c/Ub4apUvblN8

Yeah, I'm personally unblocked for now.
I still think this would be good to fix or document -- the quadratic complexity for this operation is quite surprising, given both the vanilla tf and theoretical behaviour, and it took a while to figure out what was going on -- but I understand that time is limited, and if you don't think you'll get to it it seems fine to close. (And thanks again for the help!)

Hrm, actually, turns out I am not able to use the fused LSTM... it causes an unacceptable accuracy loss for my problem. (In the example I'm testing out now, the error rate goes from ~0.13 to ~0.30 when I fix the input shape.)
Is that a known issue? If not, happy to open another issue... seems unrelated to the quadratic complexity.

You can try flex tensor list op instead with the recent tf nightly version.
converter._experimental_lower_tensor_list_ops = False

TFLite fused LSTM is stateful, so you will need to call reset_all_variables: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/python/interpreter.py#L847-L848
between each innovation.

TFLite fused LSTM is stateful, so you will need to call reset_all_variables: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/python/interpreter.py#L847-L848
between each innovation.

Yes, can confirm I'm doing this correctly. (Error rate is closer to 0.7-0.8 without it.)

You can try flex tensor list op instead with the recent tf nightly version.

I have not tried this! Will report back.

Ah, apologies, I misunderstood... thanks! Performance is improved in that case but still quadratic. I've updated the notebook:
https://colab.research.google.com/drive/1APyFWSL3ln5gZFEotw_5wwUDpaSJrzD-

The new performance graph looks like a linear graph.

Closing this issue since the performance improvements has been achieved through the Flex tensor list ops.


Throw when advancing writable buffer that has no memory.

Happens when you do
buffer = _pipe.Writer.Alloc();
buffer.Advance(10);

Right now only Debug.Assert is fired

@pakrym might have already fixed this. He'll verify and close.

Fixed via https://github.com/dotnet/corefxlab/pull/1347


Build nextpnr with ECP5 support

Fixed in https://github.com/litex-hub/litex-conda/commit/e818a57b3166de911faa4c811d4429693239f26a


Create a Docker Compose file to create database instance

To make it easier for newcomers, create a simple command to create a database with persistent data running locally.

I'll take it as I've been working offline on this with @NiallJoeMaher

Closed with #80
Thanks!


Can ctrl-c be captured?

Hello,
I'm using readline in a terminal emulation setting - in this context, it would be nice to capture ctrl-c and send a remote reset instead of quitting the application (ctrl-d can be used for that). Is this possible? Can a custome Listener be used for this?
With many thanks for creating such a nice utility,
-jcw

Doh - of course it can - see:
https://github.com/chzyer/readline/blob/master/example/readline-demo/readline-demo.go#L89
Closed.


daysAfterDate and daysBeforeDate don't take into account daylight savings changes

A day doesn't aways have 24 hours, so the following methods are prone to errors for date ranges spanning a clock change. The interval calculations should be done using NSCalendar.
This is particularly problematic since add does take into account the user's timezone, so with this library you can add 1 day with add and get 0 days back when using daysBeforeDate or daysAfterDate.

Thank you


[BUG] tsduck.pc contains libedit dependency even when building with NOEDITLINE=true

Bug description:
If I build with NOEDITLINE=true, the libedit dependency is not removed from the tsduck.pc pkgconfig file.
How to reproduce:
make install DESTDIR=/mybuildinstallroot INSTALL="/usr/bin/install -p" install-devel NOTEST=true NODEKTEC=true NOCURL=true NOEDITLINE=true NOPCSC=true NORIST=true NOSRT=true SYSPREFIX=/usr ETCDIR=/etc USRLIBDIR=/usr/lib64 UDEVDIR=/usr/lib/udev/rules.d SYSROOT=/mybuildinstallroot

Expected behavior:
No libedit in Libs.private
Errors and logs:
libedit is still in there in /mybuildinstallroot/usr/lib64/pkgconfig/tsduck.pc
prefix=/usr
libdir=/usr/lib64

Name: TSDuck
Description: MPEG Transport Stream Toolkit
URL: https://tsduck.io/
Version: 3.29.2651
Requires:
Requires.private: libedit
Libs: -L${libdir} -ltsduck
Libs.private: -lpthread -lrt -ldl -lm -lstdc++
Cflags: -I${prefix}/include/tsduck --std=c++11

Environment:

OS: Linux
OS version: Fedora 35 x86_64
TSDuck full version: 3.29-2651
Installation type: I'm building from source, obviously

Additional information:
The Makefile for tsduck.pc requires an sed removal rule such as the other dependencies have.

Fixed in commit a0ad9310bfd346515aef1aef6e96758e3bdf2a5c

And BTW, building the .rpm and .deb packages with NOEDITLINE=1 was also incorrect. Just fixed it in commit 3105f5736519061dffa08f32b58bb692e0f47ca8. The use of libedit was recently added and I must admit I was not thorough enough with all the implications.

Ah, good catch, I was exclusively looking at tsduck.pc.
BTW, the sed line removing librist has no effect, as librist hasn't made it into tsduck.pcm which is probably an incorrect omission.

BTW, the sed line removing librist has no effect, as librist hasn't made it into tsduck.pc, which is probably an incorrect omission.

Ah, ah, good catch, your turn 😄 There is a librist.pc file indeed. Added in  commit beac7078ad4ad0c43b56d0989987df3217339b28.


Readonly access and no-token mode

Awesome project!
I would like to use it in read-only mode for few projects.
Main use case: I want to get some code on CI system, like DscResource.Tests here https://github.com/PowerShell/xExchange/blob/dev/appveyor.yml . If I can mount particular GitHub repo, instead of cloning it, it would be much nicer. For read-only mode I should not need a token.

Hm, I guess without a token, I would hit 'Unauthorized API requests' limit pretty soon...
So, it's more about a 'demo mode' to provide people a sneak peek without asking for creating a token.

I don't check permissions on my side, so simply providing an empty string in the GITHUB_TOKEN environment variable aught to work? I don't actually know, I've never actually tried. I did try changing the permissions on the token though, they works pretty okay if I recall correctly. The API error should happily propagate all the way up to the shell.

Without setting up $env:GITHUB_TOKEN or with empty string, you get this error
PS GH:\> ls
ls : Value cannot be null.
Parameter name: token
At line:1 char:1
+ ls
+ ~~
    + CategoryInfo          : NotSpecified: (:) [Get-ChildItem], ArgumentNullE
   xception
    + FullyQualifiedErrorId : System.ArgumentNullException,Microsoft.PowerShel
   l.Commands.GetChildItemCommand

The problem is not only in creating a more actionable error message. Token carries information about user identity, so you can start query GitHub API with something meanful for ls: user orgs. Without user name, the only reasonable thing to do would be query GitHub for all users / orgs, which is not the best expirience. On the other hand, if I know for sure that I want to browse GH:\PowerShell I can just cd there. So maybe ls can print out warning, when it expects tons of info and actually query it, if called with -Force:
GH:\> ls
WARNING: you are in the anonymous mode, Get-Item cannot identify relevant users and organizations for you.
Get-Item -Force will print all users and organizations on GitHub.
GH:\> ls -Force
...

Hm, adding a more useful error message would certainly be helpful. I'll look into it.

Querying all users/orgs for the root without auth doesn't make too much sense (there's too many, you'd hit the API limit trying to get them all, since they're paginated). I think a more sensible/instructive error is probably the best case.

Agree. Btw, just found that I can cd GH:\GitHub. :+1:

The provider now supports operation without a token - however you'll find that you run into your rate limit very quickly.


bug: Floating terminal is now static at bottom!

Did you check docs and existing issues?

[x] I have read all the LazyVim docs
[x] I have updated the plugin to the latest version before submitting this issue
[x] I have searched the existing issues of LazyVim
[x] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
Arch linux
Describe the bug
after updating lazyvim, ctrl+/ supposed to opned flaot terminal, but the terminal showed at the bottom.

Steps To Reproduce

deleted lazyvim and all settings from ~/config/nvim also removed nvim folders from .cache and .local/share/nvim
reinstall lazyvim following docs
open neovim
press ctrl+/ to open floating-term
terminal is static at bottom of neovim

Expected Behavior
opening floating term as usual.
Repro

This is not a bug. That's how Snacks opens terminals. If you want to change that behavior you can put in your Snacks config the following
  {
    "folke/snacks.nvim",
    -- dev = true,
    opts = {
       terminal = {
         win = {
           position = "float",
         },
       },
    },
  },

Or just call the directly the command :lua Snacks.terminal(nil, { win = {position = "float"}}).

Thank you @dpetka2001


[FEA] Update CudfUnsafeRow to include size estimates for strings and implementation for getUTF8String

Is your feature request related to a problem? Please describe.
Update CudfUnsafeRow to include:

size estimates for Strings (does not have to be perfect) Spark uses 20 bytes as an estimate for the size of the String itself.
Add in an implementation for getUTF8String to read the offset and size. I think the code that is commented out is close, but needs to be modified because we don't guarantee 64-bit alignment for this.

Ref: https://github.com/rapidsai/cudf/issues/10033#issuecomment-1132121915

reopened by https://github.com/NVIDIA/spark-rapids/pull/6367


Question about scraping parts

Is there a way to search / scrape by the type of product? Like for example just scrape all CPU parts. Thanks. Awesome app :)

Got it. If I get some free time I'll try to make a PR.


Make xrefs between Ensembl IDs and Uniprot IDs in STRING ingest

To partially address #235
This PR:

downloads mapping between Ensembl IDs and Uniprot IDs
makes an xref edge between equivalent Ensembl IDs and Uniprot IDs in STRING edges.tsv
makes a node for the Uniprot ID in STRING nodes.tsv
also adds a bunch new unit tests to increase test coverage

@deepakunni3 please have a look - I think these last few commits give us what we want.
Note that we have both alias (which contains NCBIGenes ids for genes) and xrefs (which contain UniprotKB ids for proteins) - this is what we want right?
id	name	category	description	alias	xrefs	provided_by
ENSEMBL:ENSG00000004059	ARF5	biolink:Gene	ADP ribosylation factor 5	NCBIGene:381		STRING
ENSEMBL:ENSP00000000233		biolink:Protein			UniprotKB:P84085	STRING


Release notes for v5

Hi, @ljharb and thank you for maintaining tape.
Could you perhaps provide some release notes for the v5 release?

Like every release of tape, they're part of the tagged release commit, and annotated on the tag: https://github.com/substack/tape/releases/tag/v5.0.0
You can also see expand each commit on the "releases" page: https://github.com/substack/tape/releases


Microsoft Edge WebDriver 115+ fails to launch browser with "cannot find msedge binary" on Linux

Summary
Microsoft Edge WebDriver 115 itself successfully starts, but when I start a session with it, it cannot launch Microsoft Edge browser and stops at the error like
{"error": "unknown error", "message": "unknown error: cannot find msedge binary"}

Environment

Browser (Microsoft Edge) Version: 115.0.1901.188
Driver Version: 115.0.1901.188
OS: Ubuntu 20.04

I confirmed that the problem doesn't happen on Windows and macOS.
Also, it doesn't happen on Ubuntu with Driver Version 114.0.1823.82.
How to reproduce
I was able to reproduce the problem on a Docker container with image ubuntu:20.04.
apt update
apt install software-properties-common apt-transport-https wget curl git unzip -y
wget -q https://packages.microsoft.com/keys/microsoft.asc -O- | apt-key add -
sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/repos/edge stable main" > /etc/apt/sources.list.d/microsoft-edge-stable.list'
apt update
apt install microsoft-edge-stable -y
microsoft-edge --version
wget https://msedgedriver.azureedge.net/115.0.1901.188/edgedriver_linux64.zip
unzip edgedriver_linux64.zip
./msedgedriver &
curl http://localhost:9515/status
curl -X POST http://localhost:9515/session -d '{"capabilities": {"browserName": "MicrosoftEdge"}}'

Here, I've got the error message described above.
I've confirmed the browser is surely installed by the following command (I've got Microsoft Edge 115.0.1901.188).
microsoft-edge --version

Next, I've checked the behavior of Driver Version 114.0.1823.82.
mv msedgedriver msedgedriver-115
wget https://msedgedriver.azureedge.net/114.0.1823.82/edgedriver_linux64.zip
unzip edgedriver_linux64.zip
./msedgedriver &
curl -X POST http://localhost:9515/session -d '{"capabilities": {"browserName": "MicrosoftEdge"}}'

I've got another error message, but this is because I've not set up the other required components like Xvfb. At least, the browser tried to launch once. So the problem is limited within version 115.
{"error": "unknown error", "message": "unknown error: MicroSoft Edge failed to start: exited abnormally. (omitted)"}

Other
I guess this issue is similar to https://bugs.chromium.org/p/chromium/issues/detail?id=1466427 where ChromeDriver couldn't find Chrome binary (the issue was limited to macOS, though).
When we tried Microsoft Edge WebDriver 115 where both MicroSoft Edge and Chrome exist, we've got a different error message.
{"error": "unknown error", "message": "unknown error: unknown error: unrecognized Microsoft Edge version: Chrome/115.0.5790.110"}

AB#45872325

I faced the same issue with Edge Version 115.
The behavior is explained here .  https://github.com/SeleniumHQ/docker-selenium/issues/1910

Same issue with Edge 115, downgrade to 114 mitigates for now.

Thank you for reporting this. I've added it to our internal backlog for investigation.

I noticed that msedgedriver 115.0.1901.203 on Linux actually launches /opt/google/chrome/chrome instead of /opt/microsoft/msedge/msedge.  The same is true of 116.0.1938.51 and 117.0.2033.0, but not 114.0.1823.82.
I hope that helps!

For now, all our automation will have to use msedgedriver 114 for any Edge version 115+.  (See https://github.com/shaka-project/webdriver-installer/pull/32)  I suspect this will not be a viable workaround forever, since newer Edge releases might not be able to communicate with older drivers if something in the protocol changes.  Please let us know if we can expect a fix before that happens.  Thanks!

@joeyparrish Thank you for your additional information. Also, thanks to https://github.com/actions/runner-images/issues/8046 I learned that the previous version 115.0.1901.183 works well for Edge 115. It can be another workaround.
But as for Edge 116+, I have the same concern with https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1684245931. I hope it will be fixed soon.

@bwalderman Is there any update? I've confirmed that the latest version 116.0.1938.69 still has the same problem.
Now we cannot upgrade Edge in our test environment...

Edge 116 is out on GitHub VMs, and the workaround of using driver version 114 no longer works:
session not created: This version of Microsoft Edge WebDriver only supports Microsoft Edge version 114
Current browser version is 116.0.1938.69 with binary path /usr/bin/microsoft-edge

Feeling good about my prediction 3 weeks ago that 116 could break things...
Any comment from Microsoft on the observation that msedgedriver wants to run /opt/google/chrome/chrome?  It seems like if there's a mistaken path in msedgedriver, that should be relatively easy to fix, right?
Another workaround that still works:  In your capabilities request, specify "ms:edgeOptions": { "binary": "/usr/bin/microsoft-edge" }

Edge 116 is out on GitHub VMs, and the workaround of using driver version 114 no longer works:
session not created: This version of Microsoft Edge WebDriver only supports Microsoft Edge version 114
Current browser version is 116.0.1938.69 with binary path /usr/bin/microsoft-edge

Feeling good about my prediction 3 weeks ago that 116 could break things...
Any comment from Microsoft on the observation that msedgedriver wants to run /opt/google/chrome/chrome? It seems like if there's a mistaken path in msedgedriver, that should be relatively easy to fix, right?
Another workaround that still works: In your capabilities request, specify "ms:edgeOptions": { "binary": "/usr/bin/microsoft-edge" }

Just to highlight that this combination still works:
Browser version: 116.0.1938.69
Edgedriver version: 115.0.1901.183 (db29db5e66a28f9f889ff1962ead6e0c377200e0)

...but probably only until Edge 117. It seems that whatever was changed in driver version 115.0.1901.188 caused this. Any chance of reviewing those changes and maybe reverting the one that is causing this?

facing same issue for edge driver version 117.0.2045.35
ERROR webdriver: Request failed with status 500 due to unknown error: unknown error: unrecognized Microsoft Edge version: HeadlessChrome/117.0.5938.88 ERROR webdriver: unknown error: unknown error: unrecognized Microsoft Edge version: HeadlessChrome/117.0.5938.88

Hi folks. Sorry for the delays in addressing this. We've fixed the issue in msedgedriver and the fix will be available on the Edge Canary channel within a day or two. We're also working to backport this change to the Beta and Stable channels, which will take an additional few days.
Until the fix lands, you can work around this issue on Linux by setting the browser binary location in your EdgeOptions to /usr/bin/microsoft-edge explicitly.

Good day!
Still getting the same error:
Platform: Linux AMD64 (Ubuntu Jammy)
MS Edge: 119.0.2109.1-1 (microsoft-edge-dev)
Driver: 119.0.2109.1 (https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/119.0.2109.1/edgedriver_linux64.zip)
Error when starting the driver: 500. Message: unknown error: cannot find msedge binary

Any updates on this? This issue really blocks us from using Edge > 114 version

Hi folks. Sorry for the delays in addressing this. We've fixed the issue in msedgedriver and the fix will be available on the Edge Canary channel within a day or two. We're also working to backport this change to the Beta and Stable channels, which will take an additional few days.
Until the fix lands, you can work around this issue on Linux by setting the browser binary location in your EdgeOptions to /usr/bin/microsoft-edge explicitly.

hi Brandon,
Will the fix automatically find it's way to https://hub.docker.com/r/selenium/node-edge/ (dev -> beta -> latest)?

Any updates on this guys? It's being broke for more than a month already. @jayhome I tried to pull selenium node edge, integrate in a CI/CD environment, it didn't fix the error 'E       selenium.common.exceptions.WebDriverException: Message: unknown error: unrecognized Microsoft Edge version: Chrome/117.0.5938.0'.

"unknown error: cannot find msedge binary"
I was only able to use and run dev version 119 (not 117 latest) without getting the error as mentioned in the issue summary: "unknown error: cannot find msedge binary". But ran into stability issues rendering the dev build useless for my testing purpose.
You seem to have a different error/problem, possibly unrelated to the forementioned root cause: incorrect browser binary location.


Adding some tests to the wrong branch

Coverage remained the same at 90.0% when pulling ee75ac2eca83883a16ba053b9cb446fa178ff66f on namingEvents into 9af098f4327d9fa1f76f70cb4cbb0b5900c21932 on master.


Added ui enhancement to the search bar in search

I have redesigned the search bar in the search page for the frontend.  I have also added a small focus animation on the search bar.

Yes I thought of getting a approval for this and later change those as well, I will be doing it now


Build Fails on Debian

Cloned the master version commit 610c8cbbc4c25fc4df242e6e4e6c7e2551a6c682.
steps taken
git clone cpp-netlib
git submodule init
git submodule update
cmake ../cpp-netlib
started building
/home/zglozman/cpp-netlib/deps/uri/src/detail/uri_normalize.cpp:24:6:   required from here
/home/zglozman/cpp-netlib/deps/uri/src/boost/function/function_template.hpp:572:11: error: placement new constructing an object of type ‘network_boost::algorithm::detail::token_finderF<network::detail::normalize_path_segments(network::string_view)::<lambda(char)> >’ and size ‘8’ in a region of type ‘char’ and size ‘1’ [-Werror=placement-new=]
new (reinterpret_cast<void*>(&functor.data)) FunctionObj(f);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

What compiler and version are you using?

same problem here, Fedora 25 using g++ (GCC) 7.2.1 20170915.

Try building branch 0.13-release.


GH-2959 use junit4 rule for temporary dirs

Signed-off-by:Bart Hanssens<EMAIL_ADDRESS>GitHub issue resolved: #2959
Briefly describe the changes proposed in this PR:

use a junit4 rule to create temp dirs (instead of relying on custom ways to achieve the same thing) that should be removed after the test

(not yet using junit5, because it looks like some tests inherit from other junit4 tests outside this package)

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Nativestore should be ok, next is checking ES store

Yeah, still somewhat working on it :-/
The reason I've removed this is that the test will indeed create nativestore dir (not a randomized one with this prefix, just "nativestore"), just like other test with nativestore. So if at one point these tests are performed in parallel, they will all use the same subdir...
Alternative would be to use "name-of-test/nativestore", but this may or may not be necessary when we switch to junit5 TempDir (which is still marked "experimental" in Junit 5.7)

Alternative would be to use "name-of-test/nativestore", but this may or may not be necessary when we switch to junit5 TempDir (which is still marked "experimental" in Junit 5.7)

I'd be fine with that as a fix, even if in a later Junit 5 migration it's no longer necessary, it won't break anything either. But if you want to explore other possibilities first I have no objection.

Should fix a few 'leaking' tests, there are still some temp directories left after running the tests:

some directories starting with elasticsearch (probably fixed when upgrading to a new ES - or more precise: using the ES test runner in the PR containing the ES upgrade)
and some temp dirs created by SHACL tests: these tests may benefit from Junit5 TempDir, since the SHACL tests already use Junit5 (no need to go back to Junit4 Rule)


hot reloading callbacks

Are there any callbacks for hot reloading present in CRA? I really hate ejecting, because 99.99999% of the things I do can be customized through avenues other than ejecting. HOWEVER, I want to use my own service worker file built on Workbox. to do that, I created sw.js  in the src/ folder and pointed serviceWorker.js to PUBLIC_URL/sw.js after adding in the proper scripts in package.json. this setup works fantastically in production, but I have no way to automagically recompile the service worker on hot reload, without a way for HMR to call my own scripts.
Any easy solutions I've managed to overlook?

Nevermind. I didn't think this issue through all the way. Since Webpack-dev-server keeps all files in memory, I have no way of actually using my service worker in development with hot reloading, since injectManifest needs access to the list of files from the build dir


Visual glitch

To repro go to: eed93b940f260e87ae59d5d05dd57daa81ca9563/following
Click on "All types" and select it. Notice an extraneous gray line:

Can't reproduce. Please reopen if you see the bug again.

@drwasho: Please don't do this. I don't have reopen rights.

Is the bug still there?

I can't reproduce this error so I'm going to leave it closed.


Update showcase integration

This updates integration of d3fc-showcase as a module, now that it has landed in the main repo: https://github.com/ScottLogic/d3fc-showcase/pull/537
Changes in d3fc-showcase:

Bug fixes (see the commit history for more info)
No longer fetch Coinbase products by default
Navigator extent gradient! :rainbow: (May need to override some of our Less variables to get the correct colours)
Fixes the indicator close label positioning (thanks for raising the issue :smiley:)
Added a method to the showcase API to set the Quandl API key (#193)

Proposed changes to OpenFinD3FC (in this PR):

Rather than using my branch, the dependency is linked to commit in the showcase's develop branch. When the next release lands, I'd suggest that this dependency is updated to the release.
Updated d3fc from 5.1.0 -> 5.2.0 (the showcase needs this version)
Showcase depends on Bootstrap's dropdown JS, so I've added this back in (it's used for the series and indicator dropdowns)
Set Quandl API key for the showcase through its API

Let me know what you think.
If you think anything is missing or needs to be changed, just let me know and I'll see what we can do.

Cheers! This makes our lives quite a bit easier.


Allow uploader route to be root

This will allow the uploader.route config to be set to /. When this is set, files with an extension will be matched by regex and made available directly on the root path.

Could you update your PR to include the changes from the trunk branch? (It will fix the build error happening here)


Single-feature methods are not added dynamically.

The Vision API does not add single-feature methods dynamically the way we intended it to do.
Instead, the structure is in place, but due to documentation restrictions, we still manually define each method. This means that when the enum is expanded, new methods will not be defined.
We should write a JSDoc plugin so appropriate documentation is automatically generated, then iterate over the enum.

@JustinBeckwith do you think this is something that would ever happen? :)

Probably not 🙃


[Event Request] Page 1133 - Cost Bdgt. per Object Matrix - OnAfterUpdateAmount

Dear ALAppExtensions team,
through this issue we would like to request adding event publisher OnAfterUpdateAmount in Page 1133 Cost Bdgt. per Object Matrix with the following signature:
[IntegrationEvent(false, false)]
local procedure OnAfterUpdateAmount(var CostType: Record "Cost Type"; var MATRIX_CellData: array[12] of Decimal; ColumnID: Integer)
begin
end;

which would be called as follows in UpdateAmount:
local procedure UpdateAmount(ColumnID: Integer)
begin
    SetFilters(ColumnID);
    if GetRangeMin("Date Filter") = 0D then
        Error(Text000);
    CalcFields("Budget Amount");
    Validate("Budget Amount", MATRIX_CellData[ColumnID]);
    // >>>> New >>>>>>>>>>>>>>>>
    OnAfterUpdateAmount(Rec, MATRIX_CellData, ColumnID);
    // <<<< New <<<<<<<<<<<<<<<<
end;

Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 48068.


Prevent people from connecting from same port

Currently if people are training on the same port, you end up seeing the same thing.
Ideally you would have some way (e.g. send a key or something) to make sure that is the intended connection point.
Otherwise, prompt them to enter in new port.

Warning now provided to user


Initialize registers and page table after allocating them

I pulled this in but then polished the code a bit.


Error message doesn't disappear after correcting action

I changed the password of one class member after importing it but entered my password to authorize the action incorrectly. Red error message show on top of the form, so I redo the action which is now valid but the form still shows the red error message. I have to refresh the page for it to go away.

You can close the error box using the little x on the right top corner....


Update example

The Example file contains some out of date and community dependent modules which need to be updated (cManageCertificates). A key part of the example depends on this module so that part will need to be re-worked. In addition, there are some old functions that have been brought into the PowerShell gallery and thus the names need to be updated, such as cAzurePackSetup which is now xAzurePackSetup. In the future I think we're going to enforce that all dependencies within the PS gallery modules only depend on other modules in the gallery.

I will take a look at this issue soon, and will replace the community certificate in the example with the now available xCertificate (xPfxImport)

@mbreakey3 This issue should be resolved in PR #11

Great, thanks! Looks good.


feat(utils): Update extraction of hostname from X-Forwarded-Host to favour AEM hostname

Fixes: #255

@bosschaert Can we please add a test case for this url "author-p12334-e56789.adobeaemcloud.net" and check that it matches?

Thanks @cziegeler I expanded the matching list to include adobeaemcloud and added the test.

:tada: This PR is included in version 2.7.0 :tada:
The release is available on:

v2.7.0
v2.7.0
GitHub release

Your semantic-release bot :package::rocket:


Bump coursier to 2.1.15

https://github.com/coursier/coursier/releases/tag/v2.1.15

Resolution failed for 1 modules:
--------------------------------------------
  io.get-coursier:coursier-cli_2.12:2.1.15
	not found: /root/.ivy2/local/io.get-coursier/coursier-cli_2.12/2.1.15/ivys/ivy.xml
	not found: https://repo1.maven.org/maven2/io/get-coursier/coursier-cli_2.12/2.1.15/coursier-cli_2.12-2.1.15.pom

🤔

Ach, we publish only using 2.12, do we actually need to continue publishing the image? Should we not move it to coursier?

I guess we have two options:

switch to 2.13 here
add M1 publish to coursier

@alexarchambault is it time to move arm publishing to coursier?

We can remove the macos jobs though next https://github.com/coursier/coursier/pull/3148

java.lang.UnsupportedClassVersionError: coursier/bootstrap/launcher/Launcher has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

We need to switch to JDK 17 (or wait for next release, though it's native image so it's not necessary to publish on JDK 8)

And here also https://github.com/VirtusLab/coursier-m1/blob/main/.github/scripts/build-linux-aarch64-from-docker.sh#L9


Fixed the rss import to ignore the sub-category

Summary
This fixes the rss import for covid publications to ignore the hierarchy of a taxonomy and keep everything on the top level. No update hooks are necessary since this module has not yet been installed on the production site.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

Documentation reflects changes?
no

CHANGELOG reflects changes?
yes

Unit/Functional tests reflect changes?
no

Did you perform browser testing?
yes

Risk level
Low

Relevant links
RIG-141

Looks good!
/approved


TrajectoryExecutor interface

This PR contains:

TrajectoryExecutor
TrajectoryResult
KinematicSimulationTrajectoryExecutor
Tests for KinematicSimulationTrajectoryExecutor.

This change is

Coverage increased (+0.2%) to 89.815% when pulling a3a2389b2eb86582afba406bf085f3cd245ad8a8 on feature/traj_executor into e0edcadc7006693ff33cd2f3d1833b74a54c8772 on master.

This is a good start. I have a few high-level comments:

There are some concurrency issues in KinematicSimulationTrajectoryExecutor.
I am no longer sure whether the empty TrajectoryResult base class is the best way of achieving the extensibility that we're looking for.
We need to have a bigger discussion on how to interpret getStartTime on Trajectorys. I suggest punting on this for now to avoid putting this pull request in limbo. I'm sure @psigen and @cdellin will have thoughts on this.

Reviewed 9 of 10 files at r2.
Review status: all files reviewed at latest revision, 17 unresolved discussions.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 13 [r2] (raw file):
Don't virtually inherit unless you need to.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 17 [r2] (raw file):
Take _skeleton by value and std::move it internally into a member variable.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r2] (raw file):
You should specifically document why return TrajectoryResultPtr, a std::shared_ptr to an empty type, instead of void. This is not obvious - I had to think about it for a few minutes to recall the reasoning behind this.
I'm also beginning to question whether this is the right decision. It would be simpler to make this return a std::future<void> and add additional execute overloads on sub-classes of TrajectoryExecutor that provide additional functionality. For example, the ros_control executor could have a executeWithFeedback function that uses the actionlib feedback messages to reconstruct an Aikido Trajectory from the path actually followed by the robot.
@ClintLiddick @lgw903: Thoughts?

aikido/src/CMakeLists.txt, line 10 [r2] (raw file):
We don't generally list external dependencies (e.g. dart) here. These comments are mostly intended to make sure that an add_subdirectory call occurs after the add_subdirectory calls for the components that it depends on.
Also, python should be last, since it depends on everything.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 67 [r2] (raw file):
Include the DOF name in the error message for debugging purposes.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 68 [r2] (raw file):
We lock and unlock mMutex a few times here. This could lead to concurrency problems. For example, the following could happen if the user calls execute in two threads:

Thread 1: checks mTraj
Thread 2: checks mTraj
Thread 1: starts executing traj1
Thread 2: starts executing traj2

I suggest doing all error checking on _traj before locking mMutex, then modifying all member variables (e.g. mTraj and mPromise) under the same lock.
Also, you should lock mSkeleton->getMutex() before accessing any attributes on mSkeleton (e.g. getDof).

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 87 [r2] (raw file):
Make this a parameter.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 93 [r2] (raw file):
You can remove this local variable by simply moving the if(!mRunning) break; check here.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 100 [r2] (raw file):
It's unsafe to access mTraj unless the lock is acquired.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 104 [r2] (raw file):
This is essentially a spinlock. This is generally a bad idea because it can waste a lot of CPU time. I suggest making one of two changes:

use a std::condition_variable to trigger this event
sleep for the usual period even if no trajectory is executing

I slightly prefer (1), but (2) would also be acceptable.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 116 [r2] (raw file):
I am nervous about putting this in a second nested loop. This makes it impossible to interrupt a running trajectory, even if this class is destructed. Instead, I would prefer to have one loop that runs at a fixed period and processes the currently-running trajectory. Alternatively, you could also check mRunning in the inner loop as well.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 122 [r2] (raw file):
It's not clear what getStartTime() is relative to, so I don't think this is the correct behavior. I suggest ignoring getStartTime() entirely for the sake of this pull request and treating trajectories as if they run from 0.0 to traj->getDuration().
We should have a separate discussion about how to handle non-zero start times. Could you create a Github issue for that?

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 146 [r2] (raw file):
We should set_exception on mPromise if execution terminates while a trajectory is running.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 94 [r2] (raw file):
Add a test that tries to execute a trajectory that does not have a MetaSkeletonStateSpace.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 96 [r2] (raw file):
Give this test a more descriptive name. Maybe something like this: execute_GetOnFuture_TrajectoryWasExecuted.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 111 [r2] (raw file):
A better name would be: execute_TrajectoryIsAlreadyRunning_Throws.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 130 [r2] (raw file):
A better name would be execute_TrajectoryFinished_DoesNotThrow.

Comments from Reviewable

Coverage increased (+0.2%) to 89.965% when pulling 0b7ff4e7017b13cf6d931da4e0867b0e607b8b9e on feature/traj_executor into 02b50b7b3bc0b256059ccc88b37c2e0f0c17ead5 on master.

@mkoval
Thanks for the feedback!
Comments addressed in the following way:

constructor takes mPeriod
uses condition_variable to wait on mRunning and mTraj.
cleaned up lock usage.
added more tests, changed names

Review status: 3 of 9 files reviewed at latest revision, 17 unresolved discussions.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 13 [r2] (raw file):
Done.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 17 [r2] (raw file):
Done.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r2] (raw file):
I like that idea. That would reduce having to return a std::shared_ptr to an empty type in many instances, and we may not use the feedback function in many cases. I will go ahead and make that change, unless @ClintLiddick has other thoughts?

aikido/src/CMakeLists.txt, line 10 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 67 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 93 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 100 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 104 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 116 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 122 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 146 [r2] (raw file):
Done.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 94 [r2] (raw file):
Done.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 96 [r2] (raw file):
Done.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 111 [r2] (raw file):
Done.

Comments from Reviewable

Review status: 3 of 9 files reviewed at latest revision, 17 unresolved discussions.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 68 [r2] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 87 [r2] (raw file):
Done.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 130 [r2] (raw file):
Done.

Comments from Reviewable

Coverage increased (+0.1%) to 89.888% when pulling da391df5ade80215b6959aea13418bc743a36658 on feature/traj_executor into 02b50b7b3bc0b256059ccc88b37c2e0f0c17ead5 on master.

Coverage increased (+0.2%) to 89.923% when pulling da391df5ade80215b6959aea13418bc743a36658 on feature/traj_executor into 02b50b7b3bc0b256059ccc88b37c2e0f0c17ead5 on master.

Reviewed 6 of 6 files at r4.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 31 [r4] (raw file):
Either add documentation to execute or add "Documentation inherited."

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 39 [r4] (raw file):
Nit: There's no harm in making the private members use Doxygen-style (///) comments.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 47 [r4] (raw file):
Nit: the name mSpinLock is misleading because std::mutex is not a spinlock on most architectures.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r4] (raw file):
Missing docstring.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 31 [r4] (raw file):
I believe an std::duration can be negative, so you should also check for that case. You can check for that by testing mPeriod.counts() > 0.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 61 [r4] (raw file):
Missing a space between "Executor's" and "MetaSkeletonStateSpace" in this message.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 71 [r4] (raw file):
You should acquire this lock once, outside of the loop. This is slow (we must acquire the lock many times) and dangerous (the Joints and DegreeOfFreedoms in the Skeleton could change as we're iterating over it).

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 134 [r4] (raw file):
lockSpin will automatically be unlocked (by RAII) when you exit the loop.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 139 [r4] (raw file):
We already know that getStateSpace() is a MetaSkeletonStateSpace from the check in execute. I suggest replacing the dynamic_pointer_cast with a static_pointer_cast for efficiency. It's also pointless to use dynamic_pointer_cast without checking the return value, because we'll just SEGFAULT on the next line. :smile:

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 88 [r4] (raw file):
Also test for a negative period.

Comments from Reviewable

Coverage increased (+0.2%) to 89.923% when pulling f7f69b12962541e633664ab154d6acc13dc3a94d on feature/traj_executor into 45ffdc164394d86dd0b032e0a6e73be3fe65c5d6 on master.

Review status: 5 of 9 files reviewed at latest revision, 10 unresolved discussions.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 31 [r4] (raw file):
Done.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 39 [r4] (raw file):
Done.

aikido/include/aikido/control/KinematicSimulationTrajectoryExecutor.hpp, line 47 [r4] (raw file):
Done.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 31 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 61 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 71 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 134 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 139 [r4] (raw file):
Can't do this because MetaSkeletonStateSpace inherits CartesianProduct which virtually inherits StateSpace.

aikido/tests/control/test_KinematicSimulationTrajectoryExecutor.cpp, line 88 [r4] (raw file):
Done.

Comments from Reviewable

Reviewed 4 of 4 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r4] (raw file):
Missing a \return statement.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 31 [r4] (raw file):
This should be <= 0, not < 0.

Comments from Reviewable

Review status: 6 of 9 files reviewed at latest revision, 2 unresolved discussions.

aikido/include/aikido/control/TrajectoryExecutor.hpp, line 17 [r4] (raw file):
Done.

aikido/src/control/KinematicSimulationTrajectoryExecutor.cpp, line 31 [r4] (raw file):
Done.

Comments from Reviewable

Reviewed 3 of 3 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage increased (+0.2%) to 89.916% when pulling 9b5561d7839582b3cae55dec9eae612f55c7864e on feature/traj_executor into 45ffdc164394d86dd0b032e0a6e73be3fe65c5d6 on master.

Coverage increased (+0.2%) to 89.951% when pulling 9b5561d7839582b3cae55dec9eae612f55c7864e on feature/traj_executor into 45ffdc164394d86dd0b032e0a6e73be3fe65c5d6 on master.


Add cmake for library, ut, gtest, and benchmark

Orest's heavy lifting work to get the overall structure and cmake files in place, extended for the additional test executables. Includes the earlier introduce-cmake-ut-bench branch.

At this point we can have a clean python build, using python v3.9... type syntax in the cmake file to find python. Or we can have a clean native build, which needs the exact 3.9.9 syntax in that same file. Monday will no doubt be an exercise in replacing our version of the find script with what scikit-build comes with - that may work.

This was merged into master via a later pull request.


Handle uncaught error for warnIfSlow

Description
_warnIfSlow creates a new future that resolves after a timeout duration.
https://github.com/flutter/flutter/blob/8568eda15b2527afd48622257cee3811e0d9da04/packages/flutter_driver/lib/src/driver/vmservice_driver.dart#L636
This is a new future that is separate from the returned future. If the original future resolves with an error, future.timeout will also complete with an error that cannot be handled by callers of _warnIfSlow.
This fixes the breakage of the recovery flow for health checks at https://github.com/flutter/flutter/blob/8568eda15b2527afd48622257cee3811e0d9da04/packages/flutter_driver/lib/src/driver/vmservice_driver.dart#L220.
Related Issues
None
Tests
I added the following tests:
Add a test to simulate a rpc failure.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

No problem :)


DukeMTMC-videoreid dataset

Dear author,
thank you very much for the code you provided. Now I want to run the dukemtmc-videoreid dataset, but I find it impossible to download the dataset. Can you send me a copy of this dataset?Thank you very<EMAIL_ADDRESS>

Maybe you can send an e-mail to the author of that dataset. I found that they remove the dataset because of some privacy issues.


Feature Request: rename Macos Login entry item to be more Aerial Specific

Required information
In order to help us sort your issue, we ask that you provide the following information:

[x] Mac model: M1
[x] macOS version: Ventura 13.1
[x] Monitor setup: Retina

Description of issue / Feature request
Hi,
A tiny, but confusing detail after installation. If you go to macos Settings -> General -> Login items, there's entry listed as below:

By googling I arrived at the previous repo of the project, so I'm guessing it's coming from Aerial?
It would be nice if it was renamed correctly, as I was this close to simply deleting it :)

Hey @LukaszSolo
So Apple is doing something weird for applications signed by individual developpers and shows their name, instead of the app name for apps coming from the App Store, or signed using company certificates.
I still haven't found a workaround, you can look at this thread here, there's a beta that removes some of the pain, but not that specific one : https://github.com/AerialScreensaver/AerialCompanion/issues/51
Other software have the issue and I'm not entirely sure how to fix this yet, more here too : https://github.com/AerialScreensaver/AerialCompanion/issues/47#issuecomment-1368242312

Ah! I didn't think to search in Aerial Companion. Since you're aware of the issue and it's not on your plate to fix it :), I'll close the ticket. Thank you for quick reply!


1.3 RSP images request

I'd like to get some 1.3 session images to start testing the preview builds against. Let me know if I can get set up to do this myself so I don't have to bug anyone. :)

We have CI set up on this repo, so we can follow the release process to make a new version of the images available on Docker Hub for testing.
The latest RSP preview build is 1.3.820-1, do you want me to kick off the creation of images for that version?

Thanks! We were actually close to promoting 1.3.842-1 as a new preview so let's update to that.
I saw this job failure. https://travis-ci.org/rstudio/docker-r-session-complete/jobs/652824526?utm_medium=notification&utm_source=github_status
I forgot we are no longer building trusty so we need to switch to xenial. https://github.com/rstudio/rstudio-pro/pull/983

Looks like I don't have access to commit. Do you mind giving me access and I can give it a try? :)

Do you mind giving me access and I can give it a try?

Added!
I opened a PR here, feel free to work on that PR/branch.
And good to know about the xenial build for the session components. 👍

Closed by #21, and the preview images are up on Docker Hub.
We can repeat this process for any new preview builds. Happy testing! 😄


DaggerLocationProviderFactoryComponent

this importation is not working how can i find the library or how could i resolve the issue

Make sure you have Dagger v2 installed: https://google.github.io/dagger/


Create simple "CFM" bot

The aim is to create a simple CFM bot that will place volume according to the $xy=k$ formula.
The logic should be the following:

work out the volume at each tick between one tick from last traded price to min / max implied by the lpPriceRange parameter.
at each time step it should cancel all it's old volume and dump new volume on the book.
Use $xy = k_b$ for incoming buy orders and $xy = k_s$ for incoming sell orders with $k_b$ and $k_s$ adjusted based on position size, so that "if I am already short buy orders get a bad price from me but sell orders get a good price from me".

Context: we want to get a feeling for how this: https://github.com/vegaprotocol/specs/issues/1990 would work.
Follow up: once this is done we'll do a ticket for a Uniswap v3 type curve. One step at a time.

https://docs.google.com/spreadsheets/d/1sb-oS9V5qcMDLy2YVoUrXmZZpJqZLBYzR8B2mi68Tas/edit?usp=sharing

Section 2 here has some of the background blah-blah.