Issue with uploading the SARIF report to GitHub

Hello,
We're facing issues with the Using Trivy to scan your Git repo setup, the action is working fine and creates a SARIF report, however that report is not accepted by GithHub in the Upload Trivy scan results to GitHub Security tab step. Here's our workflow.yaml config:
  - name: Run Trivy vulnerability scanner in repo mode
    uses: aquasecurity/trivy-action@master
    env:
      TRIVY_USERNAME: ${{ secrets.TRIVY_USERNAME }}
      TRIVY_PASSWORD: ${{ secrets.TRIVY_PASSWORD }}
      TRIVY_DB_REPOSITORY: ${{ secrets.TRIVY_REPOSITORY }}
    with:
      scan-type: 'fs'
      ignore-unfixed: true
      format: 'sarif'
      output: 'trivy-results.sarif'
      timeout: '10m'
      severity: 'CRITICAL,HIGH'
      scanners: "vuln,misconfig"
      limit-severities-for-sarif: true

  - name: Upload Trivy scan results to GitHub Security tab
    uses: github/codeql-action/upload-sarif@v3
    with:
      sarif_file: 'trivy-results.sarif'

The error from the Upload Trivy scan results to GitHub Security tab is:
Error: Code Scanning could not process the submitted SARIF file: locationFromSarifResult: expected artifact location, locationFromSarifResult: expected artifact location
We're using the latest version supported in the trivy-action.

@uRhos that's interesting. I tested this earlier as you can see here and it was fine.
Is it possible for you run the same scan locally with the Trivy CLI to see what output you get? It might be a bug with the SARIF output being generated incorrectly.
Were the reports correctly being generated and uploaded in prior versions of Trivy action?

I had similar issue since yesterday, had to revert to 0.25.0.
Our problem was that result was generated in table format (not sarif).
From the looks of it the action isnt picking up the correct config (from trivy.yaml).

@uRhos that's interesting. I tested this earlier as you can see here and it was fine.
Is it possible for you run the same scan locally with the Trivy CLI to see what output you get? It might be a bug with the SARIF output being generated incorrectly.
Were the reports correctly being generated and uploaded in prior versions of Trivy action?

Yes, after setting version: 'v0.55.0' the workflow is completed correctly, but I agree with @richardrobarth the trivy.yaml config is not being picked up, so we had to change from using it to using the inputs and env vars

Also hitting this in multiple repos, pinning to 0.24.0 fixes it for us

@uRhos could you try with the latest release https://github.com/aquasecurity/trivy-action/releases/tag/0.27.0 we had an issue where env var were not getting set and it should be addressed hopefully in this release. Let us know how it goes.

Also having issues with SARIF upload. Confirmed the SARIF is there after the trivy scan, but didn't confirm its contents. Errors from the upload-sarif action attached. I changed no working directory settings or anything like that.
git call failed. Continuing with commit SHA from user input or environment. Error: The checkout path provided to the action does not appear to be a git repository.   git call failed. Will calculate the base branch SHA on the server. Error: The checkout path provided to the action does not appear to be a git repository.

Hi @uRhos !  Can you give me an example of your workflow?

Hi @uRhos ! Can you give me an example of your workflow?

The workflow we use is pretty much in the description, we just have one more step to checkout the code first

@uRhos Ah, I accidentally mentioned you

@uRhos could you try with the latest release https://github.com/aquasecurity/trivy-action/releases/tag/0.27.0 we had an issue where env var were not getting set and it should be addressed hopefully in this release. Let us know how it goes.

so we tried it with the 0.27.0 version of trivy-action and 0.56.2 version of trivy and got the same error, after setting the trivy version to 0.55.2 it works, so it's probably a bug in the latest trivy release

@nikpivkin Here you go!

@nikpivkin any thoughts? The action appears to be completely broken by this.

We are also running into this issue using<EMAIL_ADDRESS>Here is our GitHub Action:
  - name: Run Trivy vulnerability scanner in IaC mode and publish to Secuirty Tab
    uses<EMAIL_ADDRESS>    with:
      scan-type: 'fs'
      scan-ref: '.'
      scanners: 'vuln,misconfig'
      hide-progress: true
      format: 'sarif'
      output: 'trivy-results.sarif'
      ignore-unfixed: true
      severity: 'CRITICAL,HIGH,MEDIUM,LOW'

  - name: Upload Trivy scan results to GitHub Security tab
    uses<EMAIL_ADDRESS>    if: failure()  || success()
    with:
      sarif_file: 'trivy-results.sarif'

Hi, we are also facing the same issue.
Github action:
jobs:
  security:
    name: security
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v4

      - name: Run Trivy vulnerability scanner in IaC mode
        uses: aquasecurity/trivy-action@master
        with:
          scan-type: 'config'
          severity: 'CRITICAL,HIGH'
          hide-progress: false
          format: 'sarif'
          output: 'trivy-results.sarif'

      - name: Upload Trivy scan results to GitHub Security tab
        uses: github/codeql-action/upload-sarif@v3
        with:
          sarif_file: 'trivy-results.sarif'

It seems that we are not have issues with our AWS Terraform repositories, however, it is failing with our GCP mono-repo repository.

@simar7, @nikpivkin  I have noticed that some uri fields are missing from the SARIF file, could this be the cause of the upload problem?  Example bellow :
       {
          "ruleId": "AVD-GCP-0061",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: \nType: terraform\nVulnerability AVD-GCP-0061\nSeverity: HIGH\nMessage: Cluster does not have master authorized networks enabled.\nLink: [AVD-GCP-0061](https://avd.aquasec.com/misconfig/avd-gcp-0061)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": ""
              }
            }
          ]
        },

@simar7, @nikpivkin I have noticed that some uri fields are missing from the SARIF file, could this be the cause of the upload problem? Example bellow :
       {
          "ruleId": "AVD-GCP-0061",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: \nType: terraform\nVulnerability AVD-GCP-0061\nSeverity: HIGH\nMessage: Cluster does not have master authorized networks enabled.\nLink: [AVD-GCP-0061](https://avd.aquasec.com/misconfig/avd-gcp-0061)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": ""
              }
            }
          ]
        },

Any update on this? I think it is more of a Trivy issue than a Trivy-Action.

I've just upgrade to Trivy v0.58.0 (I was waiting for another issue to be fixed) and getting the same error when uploading to codeql.
I can see an empty URI parameter too.
It is for a different finding:
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: \nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": ""
              }
            }
          ]
        },

Hi @ZsoltPath !
Does trivy load checks-bundle by itself or do you override the repository with the checks-bundle-repository flag?

Hi @ZsoltPath !
Does trivy load checks bundle by itself or do you override the repository with the checks-bundle-repository flag?

It does on it's own.
2024-12-04T10:28:16Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-12-04T10:28:16Z	INFO	[misconfig] Need to update the built-in checks
2024-12-04T10:28:16Z	INFO	[misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-12-04T10:28:21Z	INFO	[terraform scanner] Scanning root module	file_path="."

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

I have 15 aws_lambda_functions in the codebase. All of them through the same module.
And none of them has tracing enabled.
It's hard to tell which one is the offending without any more information.

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

I have 15 aws_lambda_functions in the codebase. All of them through the same module. And none of them has tracing enabled. It's hard to tell which one is the offending without any more information.

Are you using this module or a custom one?

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

I have 15 aws_lambda_functions in the codebase. All of them through the same module. And none of them has tracing enabled. It's hard to tell which one is the offending without any more information.

Are you using this module or a custom one?

No, it's our custom one

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

I have 15 aws_lambda_functions in the codebase. All of them through the same module. And none of them has tracing enabled. It's hard to tell which one is the offending without any more information.

Are you using this module or a custom one?

No, it's our custom one

How did you run Trivy, can you show an example of the action?

@ZsoltPath Do you have a sample aws_lambda_function configuration?
I scanned the config with Trivy v0.58 but did not reproduce the problem:
❯ cat main.tf
resource "aws_lambda_function" "test_lambda" {
  function_name = "lambda_function_name"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.test"
}%

❯ trivy conf main.tf -f sarif
...
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: main.tf\nType: terraform\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 5,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "main.tf"
              }
            }
          ]
        }
      ],
...

I have 15 aws_lambda_functions in the codebase. All of them through the same module. And none of them has tracing enabled. It's hard to tell which one is the offending without any more information.

Are you using this module or a custom one?

No, it's our custom one

How did you run Trivy, can you show an example of the step?

I run it in Github Workflow and manually on my Mac too.
      - name: Run Trivy vulnerability scanner in IaC mode
        uses<EMAIL_ADDRESS>        with:
          version: "v0.58.0"
          scan-type: "config"
          tf-vars: "environments/${{ env.TF_ENVIRONMENT }}.tfvars"
          # hide-progress: true
          format: "sarif"
          output: "trivy-results.sarif"
          severity: "CRITICAL,HIGH"
      - name: Upload Trivy scan results to GitHub Security tab
        uses: github/codeql-action/upload-sarif@v3
        with:
          sarif_file: "trivy-results.sarif"

or
trivy config --tf-vars environments/dev.tfvars  .


[Impeller] Screen flickers when frame is canceled during hybrid composition thread merging with AHB swapchains.

To reproduce, run flutter with impeller enabled on a device that supports AHB swapchains. For this I'm using the wonderous app configured to use HC platform views with the following diff:
diff --git a/lib/main.dart b/lib/main.dart
index 67105669..572c8196 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -11,6 +11,9 @@ import 'package:wonders/logic/timeline_logic.dart';
 import 'package:wonders/logic/unsplash_logic.dart';
 import 'package:wonders/logic/wonders_logic.dart';
 import 'package:wonders/ui/common/app_shortcuts.dart';
+import 'package:google_maps_flutter_android/google_maps_flutter_android.dart';
+import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';
+

 void main() async {
   WidgetsBinding widgetsBinding = WidgetsFlutterBinding.ensureInitialized();
@@ -21,6 +24,14 @@ void main() async {
   // Start app
   registerSingletons();

+  // Require Hybrid Composition mode on Android.
+  final GoogleMapsFlutterPlatform mapsImplementation =
+      GoogleMapsFlutterPlatform.instance;
+  if (mapsImplementation is GoogleMapsFlutterAndroid) {
+    // Force Hybrid Composition mode.
+    mapsImplementation.useAndroidViewSurface = true;
+  }
+
   runApp(WondersApp());
   await appLogic.bootstrap();

As you scroll from the carosel to the view that has the platform view, the screen with flash black. I believe this is because the first frame after merging the threads gets canceled, so we are letting a SurfaceFrame handle die without presenting it.
https://github.com/flutter/engine/blob/main/shell/platform/android/external_view_embedder/external_view_embedder.cc#L94-L103

Maybe its not that the frame is canceled but the surface control is removed earlier?

To work around this, the following manifest key can be added to the application:
<meta-data
    android:name="io.flutter.embedding.android.DisableSurfaceControl"
    android:value="true" />

Thank you @jonahwilliams! I’ve checked this out and ran some tests on our app with different versions of Flutter:
Tested on Xiaomi mi lite 5g, Vulcan backend:

3.24.3: The Hybrid Composition (HC) widget performs smoothly, causing no flicker, nor janks during screen animation.
3.27.0-1.0.pre.148 + DisableSurfaceControl: for us the flicker still occurs, you can check it with https://github.com/flutter/flutter/issues/157286
3.26.0-0.1.pre: The screen animation is not as smooth as 3.24.3. Occasionally, there’s also a flicker, but this time it occurs when leaving the screen (HC gets disposed).
3.25.0-0.1.pre: Similar to 3.26.0-0.1.pre, but we also encounter this error at times:
E/flutter (26346): [ERROR:flutter/impeller/renderer/backend/vulkan/command_queue_vk.cc(68)] Break on 'ImpellerValidationBreak' to inspect point of failure: Failed to submit queue: ErrorDeviceLost

I also noticed that HC causes slow video playback when the VideoPlayer and HC widgets are in the same scene (we are currently getting around this with TLHC). Thought that this might be relevant—whatever is causing the flickering could also be contributing to the slow video performance (?)

Hello, I'm attaching a screen recording. This UI includes a menu with options and a PlatformView (a native wrapper of android TextEdit placed under the menu). Each time the user selects a different menu item, the TextField is rebuilt, causing the entire screen to flicker. Could you please investigate and help resolve this issue? It's significantly impairing the user experience for us.
https://github.com/user-attachments/assets/502d9be0-8329-4482-8bb1-3a6e315e15cd

To work around this, the following manifest key can be added to the application:
<meta-data
    android:name="io.flutter.embedding.android.DisableSurfaceControl"
    android:value="true" />

As mentioned, we tried this but it is not a fix for us.

We are unable to upgrade to version 3.27 due to this issue. Additionally, since disabling surface control is not a viable workaround for us, could the flickering reported in flutter/flutter#157286 and flutter/flutter#152263 be maybe unrelated to this issue?


Add meters for ZooKeeper operations

Currently there are only gauges for outstanding ZooKeeper
operations. Add meters to see the rate of various types of
ZooKeeper operations. We can sum these meters to get the rate of all
operations.

A Timer combines a Histogram and a Meter, so the call to metrics.updateTimer(..) and registry.timer(..).update(...) should already be recording the rate of those events.


Xpath validation on Requests is not working

Describe the bug
X
To Reproduce
Steps to reproduce the behavior:

Set up SOAP Project with WSDL
Add more than 1 responses for the same end point with different Xpaths
Send Request to end point

Expected behavior
Response matching the Xpath should be shown.
Screenshots
If applicable, add screenshots to help explain your problem.
Castle Mock

Version 1.64
Java Version 17

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 114.0.2 (64-bit

Additional context:
I have 3 responses configured matching the KvkNumber value in request. But when I am sending the request responses are going in Cyclic Order. On First hit its showing 1st Response on 2nd hit its showing second hit and on 3rd hit the 3rd response for the same Request.
WSDL files or other resource attachments: Please read our FAQ before submitting or reference any WSDL files or other resources: FAQ

duplicate


Unable to import assets

I'm trying to import assets from basyx.aas, using basyx-python-sdk v 1.0.0 (latest). This is to create a HSEBoM model, which uses this.
Has the import changed or moved?

Version 3.0 of the metamodel does not have an Asset-object anymore - there's only AssetInformation: Link to Spec
You can use AssetInformation like so:
from basyx.aas import model

asset_information = model.AssetInformation(...)

Could it be that the HSEBoM Submodel Template uses version 2.0.1 of the metamodel? In that case, you would need to use v.0.2.2 of our SDK.

I'm closing this issue for now. Feel free to reopen if this didn't answer your question.


NIFI-1833 - Adding Azure Storage processors

A little progress on a quick patch to add storage processors. Still requires some unit and integration testing. May need a little more on the documentation as well. Better supporting for Azure batching commands would be a good next step, but probably lives as a further enhancement. Comments gratefully received.

This needs a little bit more work. The goal here is to use a common pattern from standard processors, however, while tests work fine, loading into NiFi causes a duplicate of the standard processor nar and therefore unpredicatable ordering. One solution to this would be to factor the base AbstractListProcessor classes out of standard processors into processor-utils. However, they have a legacy dependency on the distributed cache service which would cause a circular dependency for this refactoring.
Short term solution would be to reimplement the trigger and state logic direct in the Azure processors, which violates DRY.
Longer term it would be great to have clean Abstracts for some of these common custom patterns in processor-utils, but that's for another issue and another PR.
In the meantime I'll re-implement and update the PR, so please don't worry about reviews right now.

Hi Simon  - are you still working on this?    Not sure if it's related to the duplicate nar issue you mentioned but I've found an issue after a restart of NIFI where the processor stops working.  i.e. implement a workflow with a putAzureBlob call.  Stop and restart NIFI and the processor no longer responds to data in the queue.

I'm still working on this, yes. Apologies, I've not had the time I'd like to finish it off, but will be doing so very soon. The issue is very much the duplicate nar dependencies, which requires some refactoring to avoid the dependency this PR has on standard-processors.

Latest commit should remove some of the duplicate nar circular dependency issues. It's not the cleanest way to implement this, but that really wants a common cloud util library around the way cases like listing are handles. That feels like the scope for a much greater refactoring.

Quick question: is there overlap with NIFI-1922?

@slachterman I would say so

@simonellistonball can you consider closing this in favor of the approach outlined in NIFI-1922 which takes advantage of a new runtime classpath manipulation option which has been proven to work.

Example for Azure Data Lake Storage using additional classpath functionality: https://community.hortonworks.com/articles/58793/hdf-20-use-ambari-to-enable-kerberos-for-hdf-clust.html

@slachterman - thank you for the handy link

@simonellistonball - Seems like your PR has been adopted by @jtstorck and @aperepel so closing this PR as we currently have 3 PRs for the same JIRA.

@simonellistonball Hi. Was the work on Azure Storage Table dropped? I tried to find it in the current (1.8) version but only Storage Blob seems to be there. Thx


Document client addRelay vs connectRelay

Using the @rust-nostr/nostr-sdk npm package, I have an already connected client, and I want to send a DM to a NIP19 "nprofile" identifier (which encodes both a public-key and a list of hint-relays).
I want to add/connect to those relays before sending the direct-message.
Should I use client.addRelays(...) or client.connectRelay(...)?
Should I call the connect() function again?
Thanks!

You can do either client.addRelays and then client.connectRelay or client.addRelays and then client.connect.
In general, before call any connect method, you have to add the relay/s with client.addRelay or client.addRelays. The connect method try to establish connection with all previously added relays with status set to disconnected. The connectRelay try to establish connection only with the specified one.


not clear statement

Challenge http://www.freecodecamp.com/challenges/waypoint-create-bootstrap-wells has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
1- not clear statement "Add two div elements inside your div class="well"> element both with the class col-xs-6"
2 - the code checker works also if i put 2 <divs class=well" inside the first

duplicate of https://github.com/FreeCodeCamp/FreeCodeCamp/issues/1968


Inventory support for IAM Custom Roles

Please add support for IAM Custom Roles in Inventory module. Custom roles can be defined on org or project level, so Forseti should scan all those resources.
We would like to know where and which custom roles were created for audit/backup purposes.

Issue Review: Mostly code complete and awaiting testing + release @ahoying

Included in 2.0-dev branch, will be part of the 2.0 release, added in #801.


Problem activating delegated harvesting where all keys aren't linked.

Steps to reproduce.

I fund an account.
Age in funds for a day that are over 10,000 but under 50m.
I go to harvesting to link keys and initiate transaction
Play around with wallet and start harvesting on another account
Come back to the first account and see the following message

The first problem is that harvesting was activated on this device (using a Ledger just a few minutes ago).
The second problem is that seemingly not all the keys are linked?

Not sure if that is part of the problem or not, but after manually entering in the node I used last time into the node box, I'm then given the only option to unlink my keys and then to later relink them.

Unlinking and relinking works.

@jabo38 would you provide proper steps to reproduce?

I did pretty much write the steps to reproduce.

@jabo38 Did you activate your harvesting on a different account or is it the same account in a different profile?

All the screen shots are for the same account in the same profile on the same computer and same desktop app.

I can reproduce problem with saving keys in this way:

go to harvesting page (for account that have > 10000 XYM and importance > 0)
click "Link keys" (transaction will be sent)
do some interruption, like: change node, logout. After transaction will be confirmed you will end up with not saved private keys.

@AnthonyLaw not sure if it should be seperate issue or belongs to this one. But it's very similar (this time wrong node is selected instead missing keys). If it should be reported as seperated one please let me know.
Steps:

Create empty profile
Import account with balance for which we will start harvesting.
Go to harvesting page (by default will be selected current node - X)
Switch harvesting node to Y
Start harvesting, before transaction will be confirmed switch to other profile and switch current node to Z
Wait for harvesting transaction confirmation
After confirmation done switch to harvesting view and selected node will be current node (Z) instead correct node (Y)

Expected result:
Harvesting node should be node Y
Video: https://share.getcloudapp.com/P8u9nAqv

After latest fix seems all works now :+1:

harvesting for single account - starting
harvesting for single account - change harvested node
harvesting for multisig account - starting
harvesting for multisig account - change harvested node
choosing node for account that already harvesting (in other wallet)
choosing node for account that already harvesting on node (node operator account)

Checked in dev. Works fine :+1:


chore(Exp): Add AWS EC2 terminate experiment

Signed-off-by: Udit Gaurav<EMAIL_ADDRESS>

Logs:
W1028 08:22:36.604731       1 client_config.go:541] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
time="2020-10-28T08:22:36Z" level=info msg="Experiment Name: ec2-terminate"
time="2020-10-28T08:22:36Z" level=info msg="[PreReq]: Getting the ENV for the  experiment"
time="2020-10-28T08:22:36Z" level=info msg="[PreReq]: Updating the chaos result of disk-loss experiment (SOT)"
time="2020-10-28T08:22:36Z" level=info msg="The application information is as follows" Namespace=default Label="run=nginx" Chaos Duration=60 Ramp Time=0
time="2020-10-28T08:22:36Z" level=info msg="[Status]: Verify that the AUT (Application Under Test) is running (pre-chaos)"
time="2020-10-28T08:22:36Z" level=info msg="[Status]: Checking whether application containers are in running state"
time="2020-10-28T08:22:36Z" level=info msg="[Status]: The running status of container are as follows" container=nginx Pod=nginx-7bb7cd8db5-mtnrp Status=Running
time="2020-10-28T08:22:38Z" level=info msg="[Status]: Checking whether application pods are in running state"
time="2020-10-28T08:22:38Z" level=info msg="[Status]: The running status of Pods are as follows" Status=Running Pod=nginx-7bb7cd8db5-mtnrp
time="2020-10-28T08:22:40Z" level=info msg="[Authentication]: Creates directory for aws configuration"
time="2020-10-28T08:22:40Z" level=info msg="[Authentication]: Creating credential file in aws directory"
time="2020-10-28T08:22:40Z" level=info msg="[Authentication]: Copying aws credentials from cloud_config secret"
time="2020-10-28T08:22:40Z" level=info msg="[Status]: EC2 instance is in running state (pre chaos)"
time="2020-10-28T08:22:40Z" level=info msg="[Chaos]: Stoping the desired EC2 instance"
time="2020-10-28T08:22:41Z" level=info msg="Stopping an ec2 instance:" InstanceId=i-087f1f9dd5b45d5be CurrentState=stopping PreviousState=running
time="2020-10-28T08:22:41Z" level=info msg="[Wait]: Wait for EC2 instance to get in stopped state"
time="2020-10-28T08:22:41Z" level=info msg="[Status]: Checking EC2 instance status"
time="2020-10-28T08:22:41Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:43Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:45Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:47Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:49Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:52Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:54Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:56Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:22:58Z" level=info msg="The instance state is stopping"
time="2020-10-28T08:23:00Z" level=info msg="The instance state is stopped"
time="2020-10-28T08:23:02Z" level=info msg="[Wait]: Waiting for chaos duration of 60s before starting the instance"
time="2020-10-28T08:24:02Z" level=info msg="[Chaos]: Starting back the EC2 instance"
time="2020-10-28T08:24:02Z" level=info msg="Starting ec2 instance:" InstanceId=i-087f1f9dd5b45d5be CurrentState=pending PreviousState=stopped
time="2020-10-28T08:24:02Z" level=info msg="[Wait]: Wait for EC2 instance to get in running state"
time="2020-10-28T08:24:02Z" level=info msg="[Status]: Checking EC2 instance status"
time="2020-10-28T08:24:03Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:05Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:07Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:09Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:11Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:13Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:15Z" level=info msg="The instance state is pending"
time="2020-10-28T08:24:17Z" level=info msg="The instance state is running"
time="2020-10-28T08:24:19Z" level=info msg="[Confirmation]: EC2 terminate chaos has been injected successfully"
time="2020-10-28T08:24:19Z" level=info msg="[Status]: EC2 instance is in running state (post chaos)"
time="2020-10-28T08:24:19Z" level=info msg="[Status]: Verify that the AUT (Application Under Test) is running (post-chaos)"
time="2020-10-28T08:24:19Z" level=info msg="[Status]: Checking whether application containers are in running state"
time="2020-10-28T08:24:19Z" level=info msg="[Status]: The running status of container are as follows" Status=Running container=nginx Pod=nginx-7bb7cd8db5-mtnrp
time="2020-10-28T08:24:21Z" level=info msg="[Status]: Checking whether application pods are in running state"
time="2020-10-28T08:24:21Z" level=info msg="[Status]: The running status of Pods are as follows" Pod=nginx-7bb7cd8db5-mtnrp Status=Running
time="2020-10-28T08:24:23Z" level=info msg="[The End]: Updating the chaos result of ec2 terminate experiment (EOT)"


fix: replace funding section with Allocation to fix large number bug [JB-202]

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3391

PR #3392   👈

This comment was auto-generated by Graphite.

@wraeth-eth queued this pull request to merge with Graphite.

@wraeth-eth merged this pull request with Graphite.


Migrate eth-json-rpc-provider into core monorepo (1/2)

Explanation

This is the first of two PRs that will migrate eth-json-rpc-provider into the core monorepo by following these steps: https://github.com/MetaMask/core/issues/1079#issuecomment-1700126302.

This PR focuses on migrating the git history of the original package.

eth-json-rpc-provider is moved into a temporary directory in core (merged-packages/) with git history fully intact.
This PR will be merged without squashing to preserve the git history.

The second PR will focus on integrating eth-json-rpc-provider into the packages/ directory, and resolving any issues arising from applying core monorepo linter/compiler/build settings.

References

Partially implements https://github.com/MetaMask/core/issues/1551
See https://github.com/MetaMask/eth-json-rpc-provider/pull/28 for preparatory steps taken in original repo.

Changelog

N/A since @metamask/eth-json-rpc-provider isn't usable from the monorepo.
Checklist

[x] I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@SocketSecurity ignore-all
All packages versions are current with core main branch.


Feature Request: post command: add option to specify separate reply root and reply parent

Proposal
Currently, bsky post --reply only allows specification of one URI, which serves as both the parent and root. This means one cannot create threads longer than two posts.
The proposal is to add ability to specify a reply root separately.

Hi @michaelmhoffman, thanks for your feedback!
Yes this feature of bluesky_cli is indeed incomplete and has much room for improvement. I plan to make more radical improvements including this


Refactor to reduce use of clone

Current dependencies on/for this PR:

main

PR #332   👈

This comment was auto-generated by Graphite.


fix unknown property 'publicPath' when build prod bundle

mini-css-extract-plugin have a options { publicPath: '../../' }, when pass it to  style-loader, style-loader  will throw error with
ValidationError: Invalid options object. Style Loader has been initialized using an options object that does not match the API schema.
 - options has an unknown property 'publicPath'. These properties are valid:
   object { injectType?, attributes?, insert?, base?, esModule?, modules? }

thanks for the PR. but its strange that I never got this exception. Do you know the reason? maybe we have different versions of style-loader?

assignment-ui on  micro [$!+?] via ⬢ v12.20.0
❯ yarn why style-loader
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "style-loader"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#@ace#shared-ui#react-scripts" depends on it
   - Hoisted from "_project_#@ace#shared-ui#react-scripts#style-loader"
   - Hoisted from "_project_#@ace#ding-talk-shared#@storybook#addon-docs#@storybook#core#style-loader"
info Disk size without dependencies: "1.57MB"
info Disk size with unique dependencies: "3.13MB"
info Disk size with transitive dependencies: "5.88MB"
info Number of shared dependencies: 14
✨  Done in 2.73s.

assignment-ui on  micro [$!+?] via ⬢ v12.20.0 took 3s
❯ yarn why react-scripts
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "react-scripts"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#@ace#shared-ui" depends on it
   - Hoisted from "_project_#@ace#shared-ui#react-scripts"
   - Hoisted from "_project_#dd-card-homework#react-scripts"
   - Hoisted from "_project_#dd-oral-homework#react-scripts"
   - Hoisted from "_project_#dd-publicity#react-scripts"
   - Hoisted from "_project_#dd-rhino-ng-homework#react-scripts"
   - Hoisted from "_project_#homework-pro#react-scripts"
   - Hoisted from "_project_#assignment-ui#react-scripts"
info Disk size without dependencies: "9.06MB"
info Disk size with unique dependencies: "9.06MB"
info Disk size with transitive dependencies: "9.06MB"
info Number of shared dependencies: 629
✨  Done in 3.79s.

assignment-ui on  micro [$!+?] via ⬢ v12.20.0 took 4s
❯ yarn why webpack
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "webpack"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#@ace#shared-ui#react-scripts" depends on it
   - Hoisted from "_project_#@ace#shared-ui#react-scripts#webpack"
   - Hoisted from "_project_#@ace#ding-talk-shared#@storybook#react#webpack"
   - Hoisted from "_project_#@ace#ding-talk-shared#@storybook#addon-docs#@storybook#core#webpack"
info Disk size without dependencies: "4.4MB"
info Disk size with unique dependencies: "15.7MB"
info Disk size with transitive dependencies: "33.05MB"
info Number of shared dependencies: 142
✨  Done in 3.27s.

I didn't specify the style-loader version in my package . the react-scripts i used (latest version)  include<EMAIL_ADDRESS>  and i have try to install<EMAIL_ADDRESS>the error still exist.  any my webpack version is<EMAIL_ADDRESS>


Try to reduce number of overloads in receiver methods.

From our Java API review, there is an overload explosion of settlement operations. Can we clean this up by passing some into an options class? For example, settlement options that takes a transaction context. For example, the abandon operation has 6 overloads, which is a lot. This makes the receiver client hard to figure out.
https://apiview.dev/Assemblies/Review/64f40be9988242c9a8facc8a20c5e9e7

From offline discussions with @conniey:
Based on https://github.com/Azure/azure-sdk-for-net/issues/10852#issuecomment-679859788, we need to update the settlement methods to take the message instead of the lock token.
Once we have the message, we don't need the overloads that take the sessionId as the message would contain the messageId
That leaves us with the overloads that take the propertiesToModify and the transaction context which can go into an options bag.
This leaves  us with the below
abandon(ReceivedMessage)
abandon(ReceivedMessage, SettlementOptions)

But what about the dead letter method that already takes a DeadLetterOptions?
And the complete method that does not take propertiesToModify
Should we have AbandonOptions, CompleteOptions and DeferOptions separately?
cc @hemanttanwar, @YijunXieMS, @JonathanGiles


How to run compiled model on GPU?

Recently I'm trying to run the onnx-mlir-compiled model on GPU.
Here is my idea:
krnl/affine/std -> memref/affine/std -> GPU Dialect ->LLVM IR -> NNVM -> PTX
I have no idea whether it will work. If not, could you please share me some of your points? Thank you very much.

Two thoughts:

One approach uses calls to an optimized library. That is the approach we have used internally (and we are in the process of externalizing, see current PRs). So we go ONNX to KRNL (for CPU running ops) or ZHigh (dialect that eventually turns into calls into the optimized library for our Z AI accelerator). There is a lot of work on the accelerator side because it uses a special data format. You could use a similar approach to transform ONNX operations into library calls to a GPU opt library.
wait until we lower to Affine and then go your/MLIR way to GPUs.

Note that there is an effort lead by Arm/Google to use ONNX to TOSA. There is apparently a prototype but no PR yet in the code.

Thanks for information!


Preflight "tags: always" conflicts with --tags option

Hi hi!
I have a playbook that configures a full Prometheus + Grafana stack on a node via task dependencies, with each dependency tagged, e.g. tags: prometheus, tags: grafana.
The problem here is that if I just want to run Prometheus reconfiguration (--tags=prometheus), bits and pieces of Grafana stuff still gets run, since tags: always overrides command line --tags.
This is compounded by the fact that I have, as best practices dictate, the Grafana password stored as an Ansible vaulted variable. This means "Fail when grafana admin password isn't set" fails even if I don't want to touch the Grafana configuration at all, if I haven't somehow entered the vault password.

Somewhat simular issue here. Is there any reason why preflight is set as always run?

There is no reason. It is a bug and needs to be fixed.

I created PR #109 which shoul solve this issue, it passed checks (finally - needed to find, that pytest 3.10.0 is broken). @paulfantom could you take a look on it?

Closing since #109 should solve this issue


Bluetooth headset

Anyone tried to use Bluetooth headset including speaker and microphone?
On my side only the speakers (work with A2DP), the microphone doesn't appear with arecord -l
It seems that HFP/HSP support is not fully working at any side (ALSA, PulseAudio, Bluez...)

I had the same results. Speaker worked, microphone did not. There's a new version of Jessie out and that makes me want to try again.

I want to add a note here. The lastest (May 2016) Jessie makes it much much easier to connect to bluetooth devices. Everything needed is installed by default. To set up bluetooth speakers involves clicking the Bluetooth manager button at the top of the screen and selecting and pairing the device and then clicking the audio button to choose the default speaker. But I still can't get the mic on the headset to work. I believe the issue is needing the proper file in /lib/firmware/brcm because dmesg complains the file is missing. The Plugable site says this firmware file is needed to get HFP/HSP. I've downloaded and put files in there, but they break the IOGear bluetooth adapter I have.

I got this response yesterday from Plugable:
"As you have discovered, Jessie in the Pi does not support headset profiles at the moment--at least we have not been able to get it to work here either. HSP/HFP has changed in recent kernel versions, and I think that is the reason. I have been planning to figure out how to do it (if possible) and write a blog post on it, but haven't been able to do it yet."
When I suggested the built in bluetooth on the Pi3 might be the answer, Plugable said, "Actually, I'm pretty sure HSP/HFP (the headset profile) doesn't work with the built-in chip either. If the Pi had support for the headset profile, it should be able to work with any adapter, including ours. I think the problem is that the Pi doesn't have support, and this I think is because support is complicated right now, and their team probably hasn't gotten around to including it."

I spent again several days trying all possible packages and tricks, but I couldn't make the Bluetooth microphone appear in the arecord -l devices.
By the way, if someone can explain us how the oFono stack works, I found no documentation...
@chilinski Thanks for Plugable feedback, it makes it more clear that HFP/HSP are not at all supported for the moment. So I give up and wait for an official re-support of those profiles.

I close the issue since it is now not directly linked to @AlexaPi.

I close the issue since it is now not directly linked to AlexaPi.


pyDAPAccess improvements

Implemented setLed() API.
Support for missing target identify keys:

CAPABILITIES
SWO_BUFFER_SIZE
MAX_PACKET_SIZE
MAX_PACKET_COUNT

TransferFaultError records the fault address, with help from MEM_AP.
Support for CMSIS-DAP packets larger than 64 bytes (tested with 1024 byte packets).
Support for DAP_Transfer_Block command.
 I haven't done much testing for performance on 64-byte packets, so I'm not sure if there is a difference. If so, it's probably quite small.
I tested 1024 byte packets with the K26F DAPLink HIC support that I'm working on, for a new OpenSDA circuit with high-speed USB. This is actually what pushed me to make these changes. pyDAPAccess would crash when I tried to use >64 byte packets without changing the _Command class logic.
I'm actually seeing some unexpected speed test results (below), where writing RAM is faster than reading. Looking into that right now.
------ TEST RAM READ / WRITE SPEED ------
Writing 131072 byte took 0.834380149841 seconds:<PHONE_NUMBER>85 B/s
Reading 131072 byte took 1.2075419426 seconds:<PHONE_NUMBER>66 B/s
TEST PASSED

------ TEST ROM READ SPEED ------
Reading 524288 byte took 2.30498480797 seconds:<PHONE_NUMBER>28 B/s
TEST PASSED

(This is testing with a K22FX512Axxx12 target that I'm using on a project I'm working on.)

The failures are not surprising. There are a few bugs I found last night that I'm about to push fixes for.

@mbed-bot: TEST

Everything look good here @flit. I'm just waiting on the change to 'raise'.

Sorry, I forgot about that… will take care of it shortly.

@mbed-bot: TEST


NIFI-10667 Add Private Key Service interface and implementation

Summary
NIFI-10667 Adds a new PrivateKeyService Controller Service interface and StandardPrivateKeyService implementation capable of reading encrypted or unencrypted Private Keys.
The service interface is defined in a new nifi-key-service-api module under nifi-standard-services. The standard implementation uses the Bouncy Castle library and PEMParser class to handle decoding and decrypting Private Keys. The initial implementation supports PEM encoding and PKCS 8, which can be used for several standard key algorithms including RSA and DSA.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Will review

+1 looks good to me


Add google.auth.credentials - the public interfaces for credentials

@nathanielmanistaatgoogle this is the section you indicated you wanted to give input on. PTAL.

I am unsure if I should leave the scopes property as is (completely private) or make it a public read-only property.

I vote for public read-only. I'm holding off a review here until you tell me to look @jonparrott

Sgtm, gonna let Nathaniel chime in first.
On Tue, Oct 4, 2016, 3:08 PM Danny Hermes<EMAIL_ADDRESS>wrote:

I vote for public read-only. I'm holding off a review here until you tell
me to look @jonparrott https://github.com/jonparrott
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-auth-library-python/pull/8#issuecomment-251528239,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc-0omIhmwrF0HlyVl8t7Mu8-MKApks5qws5igaJpZM4KOMdL
.

@nathanielmanistaatgoogle ping, this is now blocking.

@jonparrott rebase?

@dhermes doing it now.

Rebased.

@nathanielmanistaatgoogle after discussing with @dhermes offline, I'm gonna go ahead and merge this so we can unblock reviewing some concrete classes.
We can still continue to discuss here and I'll send follow-up PRs to make changes. This is all fluid until 1.0. Unless there is a very significant change I don't anticipate the impact on concrete classes to be large.


In the logbook view, show a row with totals

In the logbook view, show a row with total for the following columns:

Total Time
Landings Day/Night
Operational Condition Time Night/IFR
Pilot Function Time PIC/COP/Dual/Instr
FSTD Session Time

Total values for each column are updated when modify the filters

will release it soon


Raise filament version to 1.9.25

Hi!
First of all, thanks for this library, it has saved me lots of time and headaches.
I'm not sure if this sort of PR are accepted here, if not, I'm sorry, but I've noticed that the library is using an older version of filament, which has been recently updated. There were some OpenGL memory leak fixes in the last couple of version so I figured It would be nice to include thos here too.
From my testing, all of the samples apps worked (apart from augmented images - I'm not sure how that one is supposed to work).
I've also did some profiling tests and it seems to be a bit better. I've looked at the source code, but (I might be wrong here) it seems like all the materials and textures should be cleaned up by native filament implementation, so I guess there might still be some leaks in there.

Hi,
Thanks for your share. Every PR are welcome here.
Updating to the last Filament version was in the pipe but for that we need to generate material resource files with the latest version of the Filament Tool = .mat files in resources folder must be compiled to . filamat files and added to assets folders.
Can you do it in your PR?
Thanks

Sure, I can do that
I've compiled them with the default flags as i was not sure what config should be used.
Let me know if I should compile them again with different config

That's perfect.
I don't remember the exact parameters but the defaults ones on the Filament github pages with -mobile should be the good ones.
I gave you contributor access so you can PR from this repo branches instead of having to fork it.(You do everything from Android Studio or the GitHub desktop app)
Concerning the Augmented Image sample, just display the images from the res/drawable folder on your computer or put it in the emulator settings.
If everything is ok, we will release after this commit.
Thanks a lot.

Thanks. I've recompiled the materials with -p mobile this time. All the examples worked so I think everything is ok now.

Thanks a lot @fvito. The latest version of Filament seems awesome !!!!
I didn't see any issue displaying a quite important number of assets at the same time.
@grassydragon also made a great PR for the plane detection rendering.
I think we only have a little issue with the camera stream rendering which seems a little laggy.
Maybe some code treated in the wrong thread. I'll try to have a look.
I you see something about it, it will be great for this release (Optimisation)
Thanks to both of you.

Hmm, I haven't noticed any lag on my device (OnePlus 7T) although I did only have a simple scene.
I did notice that colors from camera look a bit weird, specially the blues, If I'll have some time in the weekened, I'll take a look at what is going on with the camera colors.

Hi, @fvito!
Yes, there is actually the same problem as here: https://github.com/ThomasGorisse/sceneform-android-sdk/issues/60

With the glTF sample, don't you see any lags after about 5 tigers on the Scene and moving to a different place.
The camera become a very little laggy on my tests.
I know it's quite minor and even more since I can mostly see it when the camera makes quick movements but since this is probably happening in the FrameCallback, it can have a very bad impact for the rest of Sceneform.
If anyone see something to much consuming from the SceneView.doFrame(), it will be very helpful before releasing.
I have checked all the Filament Swapchain and model rendering part and everything looks goods with the latest Filament version.
@grassydragon Can you have a look to check if there is no issue on the plane detection/controller PlaneVisualizer?
@fvito Can you have a look at the CameraStream ?
@imbrig, @VojtaMaiwald Any idea ? Can you test the latest version ?
Thanks

Hi, @fvito!
Yes, there is actually the same problem as here: #60

That's right.
Can you make a PR with the @romainguy answer ?

The release is online. I made some little improvements concerning the rendering.
There is still some little more optimisations that could be done but I think that they mostly must done on the entities transformations update on the FrameCallback.

Hi, @fvito!
Yes, there is actually the same problem as here: #60

In my case it was the actual camera feed that was showing this color errors. But I have noticed the same with another SDK that also uses Filament so I guess since camera feed is rendered as a texture, filament is applying the tonemapping to it aswell, causing this issues?

I'm just afraid that the new tone mapping will look differently in existing Sceneform applications and I hope that the problem will be fixed soon.

What if we introduce a property on the SceneView for changing the tone mapping? From what I currently see, the ToneMapper class is not exposed - or I've missed it. That would make it opt it, so existing implementations can still use the tone mapper, but it would give us an option to change/disable it in certain cases
But yeah, lets hope the fix it soon, they seem to be quite active with the development, a new version was already released :smiley:

In my case it was the actual camera feed that was showing this color errors. But I have noticed the same with another SDK that also uses Filament so I guess since camera feed is rendered as a texture, filament is applying the tonemapping to it aswell, causing this issues?

Actually, the problem is not in the tone mapping. Filament uses the tone mapping to render the scene in HDR and it can be disabled using the LINEAR tone mapper. Another feature of Filament is that it uses colors in the linear space in all calculations and converts them to the sRGB space before showing them on the screen. Filament expects colors to be in the linear space and colors in the sRGB space can be converted as described in the Filament manual. However, Filament doesn't have a function for converting colors but has the inverseTonemapSRGB function that can be used for quickly converting colors while canceling the tone mapping as a side effect. The problem is in the inverse tone mapping function and we can avoid it by converting colors manually as suggested in the Filament manual.

What if we introduce a property on the SceneView for changing the tone mapping?

I think that since the Filament engine instance can be acquired from Sceneform it is possible to change the tone mapping to FILMIC in your application code.

The problem is in the inverse tone mapping function and we can avoid it by converting colors manually as suggested in the Filament manual.

It depends on what you are doing. If the tone mapper is set to LINEAR then all you need indeed is to apply the EOTF to go from sRGB to "linear sRGB". If your tone mapping is not LINEAR then you'll also want to apply the inverse tone mapping function to preserve the camera stream as-is.
In general I believe it would be useful to give applications a way to access the ColorGrading API, which includes tone-mapping. This API belongs to View so accessing the Engine is not enough.

Thank you for correcting me!
I actually wasn't looking at the Filament API reference so we will need to check if access to View is provided.

Correct me if I wrongly understood but to summarize we have to:

Give access to the Filament View.colorGrading which is currently defined in the Renderer class
Wait for the Out-of-gamut colors produced by inverse tone mapping cause hue shifts fix
Workaround the problem for now maybe at the samples level since it should be fixed for the default ACES_LEGACY on future Filament versions by forcing the FILMIC tone mapping like this:

view.setColorGrading(new ColorGrading.Builder()
            .toneMapping(ColorGrading.ToneMapping.FILMIC)
            .build(EngineInstance.getEngine().getFilamentEngine()));

@grassydragon If it seems OK for you, can you make the PR ?
Thanks

Yes, I think it is the best solution right now.


Do not resolve DNS in Observable Address Response

We currently accept any MultiAddress as in the observable address response. Using DNS4/6 this might lead to leaking information about our DNS configuration, thus it is not common practice to use DNS in these cases. If we receive a DNS response, we should simply discard and not resolve it.

Adding P7-nicetohave label. See original w3f issue for details.

What's the "observable address response"?

Note keeping: an "observable address response" is one of the addresses reported by the identify protocol.

cc @twittner Since you already did https://github.com/paritytech/substrate/pull/5735, would you mind looking into this?

Closing as "won't fix"


[Suggestion] Chapter/Volume/Special Sorting for Paperback doesn't reflect standard reading experience

Describe the bug
Kavita currently separates media files into either:

Volumes
Specials
Chapters

We're also making two assumptions:

Most people have sorting set to 'Descending', also known as Most-Recent
Ongoing media with regular releases do not have volume assignments to each chapter/release at the time of release

Currently, Paperback sorts these with Specials at the top, Volumes behind them, and Chapters w/o volumes at the very bottom, when sorting in descending order.
However, this does not reflect a regular reading experience. I am proposing that it be changed to Chapters w/o volumes are at the top as they are assumed to be more recent than those with volumes assignments.
EDIT: Following Kavita's sorting by Storyline would work as well - in fact, that would be the suggested improvement

I made some changes to reflect some of the suggestions:
The below changes the sort order
const sortHelper = (a, b) => {
	// If volume is 0, consider it greater than any other number
	if (a.volume === 0 && b.volume !== 0) return 1;
	if (a.volume !== 0 && b.volume === 0) return -1;

	// If volume is the same, compare chapter numbers and _index
	if (a.volume === b.volume) {
	  return a.chapNum === b.chapNum ? a._index - b._index : a.chapNum - b.chapNum;
	}

	// If volume is different, compare volumes
	return a.volume - b.volume;
  };

I also suggest removing the chapter.isSpecial ? j++  from how Specials are assigned a chapter number for aesthetics - Specials are typically labeled as ONESHOT or SP02, which are directly pulled into the title by Kavita at the moment.

Thanks for your suggestion.
I'll check out and try to reflect it soon.

First of all, I apologize for the delay in responding.
I've been thinking a lot about your suggestions, and I'd like to talk about them briefly.

I think it would be more intuitive from a file management perspective to have users assign a volume number to a relatively new chapter that hasn't been assigned a volume number. However, I also think your suggestion is reasonable, and adjusted it so that the case where no volume is assigned is higher up than the case where it is assigned.
the currently implemented paperback structure only allows the extension to return a numeric chapter number, which makes it impossible to arbitrarily represent a chapter number such as SP01. So, I chose to categorize the specials separately and put them at the top, and this hasn't changed in new version - this takes into account that since they are specials, they will be read after.

I've updated Kavya 1.3.2 with these fixes. If you have any other suggestions or issues, please feel free to file an issue here.


When 'npm install' > "ENOENT: no such file or directory, rename ..."

Still got this issue #866
sqlite3 version 3.16.0
npm version 5.5.1
node version 8.4.0
npm ERR! path /Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates' -> '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/.delegates.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR!      /Users/jesse/.npm/_logs/2017-10-23T12_04_19_469Z-debug.log

debug.log
706 verbose stack Error: ENOENT: no such file or directory, rename '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates' -> '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/.delegates.DELETE'
707 verbose cwd /Users/jesse
708 verbose Darwin 16.6.0
709 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "png-js"
710 verbose node v8.4.0
711 verbose npm  v5.5.1
712 error path /Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates
713 error code ENOENT
714 error errno -2
715 error syscall rename
716 error enoent ENOENT: no such file or directory, rename '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates' -> '/Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/.delegates.DELETE'
717 error enoent This is related to npm not being able to find a file.
718 verbose exit [ -2, true ]

Can't install or even uninstall packages

have kind of the same but with sqllite3  and minimist
npm ERR! path /home/runner/amon-backend/node_modules/sequelize-mocking/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/mkdirp/node_modules/minimist
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/home/runner/amon-backend/node_modules/sequelize-mocking/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/mkdirp/node_modules/minimist' -> '/home/runner/amon-backend/node_modules/sequelize-mocking/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/mkdirp/node_modules/.minimist.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2017-12-03T21_17_30_066Z-debug.log

I fixed it by uninstalling node, npm and everything with it (and reinstalled everything afterwards of course).

@anandmahajan267 I owe that fixing an error to you : )

@anandmahajan267 thank you! it works!

Besides deleting package-lock.json the other workaround here is to upgrade to<EMAIL_ADDRESS>

It works great !

use yarn instead of npm install 👍

I just deleted the node_modules folder and npm i again. Worked for me.

In my case I had tsc -w running in the background as well as a watch node app.js.  Stopping those processes allowed npm to install this module.

I also found I had processes running depending on node_modules. In my case it was webpack and a node app. Killing them before running npm install fixed my issue.

I just deleted the node_modules folder and npm i again. Worked for me.

when first I deleted the package-lock.json，it couldn't works.Then, I delted the node_modules. Worked well

This also can happen if VSC is not run with privileges (as administrator). Closing VSC and starting it again as administrator could solve the problem. Will also fix problems regarding angular serve running in background preventing folder and file access.

This also can happen if VSC is not run with privileges (as administrator). Closing VSC and starting it again as administrator could solve the problem. Will also fix problems regarding angular serve running in background preventing folder and file access.

Worked for me

What fixed me was changing the version of nodejs to latest in Jenkins under Global Tool Configuration.

v@v-Latitude-3480:~/Desktop/vajorcases/test-robo/Test-Console$ npm i yargs
npm ERR! code EACCES
npm ERR! syscall open
npm ERR! path /home/v/.npm/_cacache/tmp/0106781f
npm ERR! errno -13
npm ERR!
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR!
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1000:1000 "/home/v/.npm"
v@v-Latitude-3480:~/Desktop/vajorcases/test-robo/Test-Console$

~/Desktop/vajorcases/test-robo/Test-Console$ npm i yargs
npm ERR! code EACCES
npm ERR! syscall open
npm ERR! path /home/v/.npm/_cacache/tmp/0106781f
npm ERR! errno -13
npm ERR!
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR!
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1000:1000 "/home/v/.npm"

Hi, Getting this error.
$ docker run 4f5926440b94
internal/modules/cjs/loader.js:979
throw err;
^
Error: Cannot find module '/app/nmp'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:976:15)
at Function.Module._load (internal/modules/cjs/loader.js:859:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}

I deleted node-modules and package-lock.json. And run npm i, still it shows following error
npm WARN saveError ENOENT: no such file or directory, open '/Users/anita/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/anita/package.json'
npm WARN anita No description
npm WARN anita No repository field.
npm WARN anita No README data
npm WARN anita No license field.

Hi, while installing server-lite getting these error
npm ERR! code ENOENT
npm ERR! syscall rename
npm ERR! path C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules\lite-server
npm ERR! dest C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules.lite-server.DELETE
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, rename 'C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules\lite-server' -> 'C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules.lite-server.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! A complete log of this run can be found in:

still not fixed guys

You'd have to add that path to VirtualBox's shared folders if using Docker Toolbox or share that specific directory in Docker Desktop's file sharing settings.

Hi, while installing server-lite getting these error
npm ERR! code ENOENT
npm ERR! syscall rename
npm ERR! path C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules\lite-server
npm ERR! dest C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules.lite-server.DELETE
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, rename 'C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules\lite-server' -> 'C:\Users\risha\Desktop\Front End Web UI Frameworks and Tools Bootstrap 4\git-test\node_modules.lite-server.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!

Hey Deleting package-lock.json file and then installing package, fixed my problem

Make sure your npm server is stopped before firing the npm install comand.

npm cannot rename this folder because it not real. You need create folder and try again!
Create folder "delegates" in your path: /Users/jesse/node_modules/sqlite3/node_modules/node-pre-gyp/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates

Hey,
delete package-lock.json from Project and in command Line write "npm install" or make package-lock.json as Custom

re create new react project.
and old source copy & paste. I did, solved it.

delete package-lock.json worked,tks

hi, while npm install getting these error. I try deleted package-lock.json and node-modules cant work
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno ENOENT
npm ERR! enoent Error while executing:
npm ERR! enoent C:\Program Files\Git\cmd\git.EXE ls-remote -h -t<EMAIL_ADDRESS>npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users\Miskah\AppData\Roaming\npm-cache_logs\2021-02-09T06_37_02_915Z-debug.log

I just deleted the node_modules folder and npm i again. Worked for me.

Of course it did not work, 30% of your project was removed, your answer is incorrect and does not help anything or anyone, if you remove this folder you will have to reinstall everything starting with the expo cli.

Hi all,
just delete package-lock.json file and then install package what you want all will works :-)

Thanks, I tried reinstalling node and many different ways but this worked for me.

any of this suggestion doesn't work for me. I'm really depressed WTF fsjakldfjaslfghashfsa

Hi together
I had this error in a little bit a different context, but in my case I had some broken symbolic links under node_modules/.bin and could figure this out with ls -lah in there where it shows them in red (in my bash).
I think I messed up something up when trying to get my project up and running.
The .bin folder is hidden so maybe this is why you cant see them when deleting and reinstalling stuff. Hope this helps (to some degree).
I did remove the .bin folder, but offcouse the stuff that was broken I had to reinstall but It was mainly typescript and some linting stuff. So maybe search for broken links inside the node_modules or where ever the errors are pointing you too.
I already fixed it and can not verify if this works:
https://unix.stackexchange.com/questions/34248/how-can-i-find-broken-symlinks
This is a generic way of finding broken symlinks.
greetings

us npm ci to clean and install all packages. and then install the package you want.
it works for me this way

I just deleted the node_modules folder and npm i again. Worked for me.

when first I deleted the package-lock.json，it couldn't works.Then, I delted the node_modules. Worked well
The same worked for me , thanks

I got this error because I had uninstalled the Visual Studio Build Tools, necessary
to compile Node.js native modules. I fixed it by reinstalling Nodejs

I don't know how it works currectly but, sometimes, exclusion of node_modules or package-lock.json works, sometimes not. I've to switch between windows cmd or linux kernel to run it good. I hope that npm team coud remove this error on next releases.

ah it heppens to me when i have a virtual usb using google drive i was trying to install express

I had to uninstall and install the npm again in order to fix this issue.

Del yarn.lock
Del Moduels
remove esllint from ur devDependencies
run yarn again

After many many trys this works fine for me.

I fix that just removing ".npm" folder in home directory


java.net.SocketTimeoutException: Read timed out

Hello Guys,
i have an issue:
I get this Error:
"java.net.SocketTimeoutException: Read timed out"
From Post request to:
/uploadSingleFile/dbname
in the OrientDB Studio..
Version is 2.1.0.
Can any help me?

Could you please provide more information?

Hi!
In the OrientDB Studio i try to upload a image file for a binary field. Over the OrientDB i got a 500 Response from the Database with this Error:
"java.net.SocketTimeoutException: Read timed out"
DB Version is: Version is 2.1.0
It is not possible to upload binary files over the OrientDB Studio and over the REST API.
If you like you can call me over the Skype. Username is: deacix
Thank you!

@maggiolo00
hi Enrico, any news about this case ? I seem to encounter the same while using the REST API of ODB, sending a simple (but rather long duration) UPDATE statement. I get a timeout back in the client program.
Is there anything configurable on the server side, regarding the REST API timeouts ?

@rdelangh
this was due file uploading that is not supported in Rest API.
How can i reproduce your issue?

@maggiolo00
hi Enrico, I seem to have found that it is possible to set the client-side timeout for the REST calls, did some tests with that, and could set the timeout to substantially longer as before. Got no more errors from timeouts anymore.
Thanks for your feedback, this issue can be closed.
brgds
Rob

Thanks, closing then.


glTF Model (.glb) loaded has no colour

The way I loaded the .glb file is:
const model = gltf.scene.children[0] || gltf.scene || gltf.scenes[0]
scene.current.add(model)

Is this the problem with the way it is loaded or with the model itself? Am I missing textures? But I had loaded Littlest Tokyo model perfectly, this way.
Also, I had seen models loaded as JSX (children/objects in a scene). But how is it possible to construct a huge dynamic scene again with JSX.
Thanks.
Extended:
import model from '../../resources/gltf/sample.glb'

function Model(props) {
  const scene = useRef()
  const gltf = useLoader(GLTFLoader, model, (loader) => {
    const dracoLoader = new DRACOLoader()
    dracoLoader.decoderPath = '/draco-gltf/'
    loader.setDRACOLoader(dracoLoader)
  })
  useEffect(() => {
    const model = gltf.scene.children[0] || gltf.scene || gltf.scenes[0]
    scene.current.add(model)
  }, [gltf])

  return (
    <group ref={group} {...props}>
      <scene name="AuxScene" ref={scene} />
    </group>
  )
}

function Model(props) {
  const { scene } = useLoader(GLTFLoader, model, ...)
  return <primitive object={scene} dispose={null} />
}

that's all you need. useloader uses suspense, by the time you fetch the result it's guaranteed to be there. how your gltf looks has to do with materials, this is not related to r3f or the gltfloader (useloader is a simple wrap for new GLTFLoader().load(url, ...).
looks like your lights are too bright.

btw check out https://github.com/react-spring/gltfjsx it lets you lay out gltfs declaratively


RDF expectations from a given RT

what RDF is expected from a given RT (and its Property Templates)?

assuming the Resource Templates Sinopia:RT:Fixture:SampleResource and Sinopia:RT:Fixture:Suppl found in the attached Profile
Sinopia:Profile:Fixture, and the following data entered/selected by the cataloger in the following Linked Data Editor fields:
Example 2: cataloger enters 2010
Example 10: cataloger searches coffee and selects "Coffee in Literature" from the results
Example 17: cataloger opens the referenced template (Sinopia:RT:Fixture:Suppl) and fills in its two fields:
Supplementary Content: this is supplemental
URI for Supplementary Content: http://www.supplement.com
Then the RDF output should be the following (where xyz is the suffix of the minted Sinopia URI).
<http://sinopia.io/group/xyz> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Work> .

<http://sinopia.io/group/xyz> <http://id.loc.gov/ontologies/bibframe/copyrightDate> "2010" .

<http://sinopia.io/group/xyz> <http://id.loc.gov/ontologies/bibframe/subject> <http://id.loc.gov/authorities/subjects/sh85027716> .

<http://sinopia.io/group/xyz> <http://id.loc.gov/ontologies/bibframe/supplementaryContent> _:b1 .

_:b1 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/SupplementaryContent> .

_:b1 <http://www.w3.org/2000/01/rdf-schema#label> "this is supplemental" .

_:b1 <http://id.loc.gov/ontologies/bflc/target> "http://www.supplement.com" .

if we wanted to mint a URI for the Supplementary Content node... then replace _:b1 with that minted URI
NOTES:
-haven't included RDF expectations for defaults yet. the logic is: if user doesn't do anything to the default value, output the default value. If user changes default value, only output the changed value.
-also have not included RDF expectations for repeatable fields.
-Also did not include any admin metadata that we plan to output automatically, like date the info was saved

@jermnelson can you check this to see if this meets the team's need for specification of RDF output expectations from Editor?

NOTE: I didn't include what happens to the field "Value Data Type: URI" in the Profile Editor. Need to look into this...

Hi @michelleif, can upload FixtureProfileWithTwoRTs.json.txt again? The current link is to Waffle and no longer exists.
Thanks!

Hi, fixed the link in above comment (and also I added it to PRD)

I'm not sure I understand the completion criteria here.  Is this actionable?

this is in response to devs saying "how do we know what RDF is supposed to be produced from a given template"

As discussed during stand-up, this RT and expected RDF should be turned into either a unit test, or could be incorporated into #421

I've added a more complete example of template + input = RDF output. All described in https://github.com/LD4P/sinopia_sample_profiles/blob/master/configuration_demo/readme.md
The template: https://github.com/LD4P/sinopia_sample_profiles/blob/master/configuration_demo/ConfigurationDemoFuller.json
List of user-entered values in "User Entry" column of:
https://docs.google.com/spreadsheets/d/1V0yNUMBV5W4Hv1KU455tq4-APW190hUWuqBbyrZYVls/
Expected output: https://github.com/LD4P/sinopia_sample_profiles/blob/master/configuration_demo/ConfigWithEnteredExpectations.txt
NOTE: awaiting cataloger review of the output to make sure it's correct, will update here when review is done

UPDATE: RDF reviewed by cataloger, looks good after a few tweaks.

Blocked by #619

This should be a separate integration test (independent of #421) that tests for the expected RDF given a set of input values.

include default lang and specified lang in literal tests


fix: now using capx alpha.2 release

Now using capx alpha.2 release
Tests done: Create/Delete capx cluster

recreated in new branch here https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/499


Add limit on loaded proposals on instrument scientist table

Description
When using the instrument scientist role  the Proposals page fails to load all proposals because we are loading too many proposals.

Motivation and Context
We would like to limit the amount of proposals loaded and allow the user to select is the need more proposals.

How Has This Been Tested
Manual

Fixes
closes: https://github.com/UserOfficeProject/user-office-project-issue-tracker/issues/872

Changes
Files changed:

apps/user-office-frontend/src/components/proposal/ProposalTableInstrumentScientist.tsx
apps/user-office-frontend/src/hooks/proposal/useProposalsCoreData.ts

Depends on

Tests included/Docs Updated?

[ ] I have added tests to cover my changes.
[x] All relevant doc has been updated

This looks good. How would one test this on local? I don't really feel like creating thousands of proposals.

This looks good. How would one test this on local? I don't really feel like creating thousands of proposals.

I used lower numbers like 2,3, 10 to see if it is limiting the proposals for frontend. To test the backend l used graphql playground with dev and prod the query is in the issue.


Mismatch between code samples and information.

https://docs.microsoft.com/en-us/aspnet/mvc/overview/older-versions/getting-started-with-ef-5-using-mvc-4/implementing-the-repository-and-unit-of-work-patterns-in-an-asp-net-mvc-application#implement-a-generic-repository-and-a-unit-of-work-class
The unit of work class has this code:
 public GenericRepository<Department> DepartmentRepository
        {
            get
            {
                return this.departmentRepository ?? new GenericRepository<Department>(context);
            }
        }

and a bit lower in the code there is this information:

Each repository property checks whether the repository already exists. If not, it instantiates the repository, passing in the context instance. As a result, all repositories share the same context instance.

public GenericRepository<Department> DepartmentRepository
{
    get
    {
        if (this.departmentRepository == null)
        {
            this.departmentRepository = new GenericRepository<Department>(context);
        }
        return departmentRepository;
    }
}

Actually this line of code is wrong:
get { eturn this.departmentRepository ?? new GenericRepository<Department>(context); }
as this returns always a new instance of GenericRepository in case the field is null!

@wstaelens  thanks for the information. Unfortunately, we don't have the resources to update this document.

so it is just closed? oh boy.
Next time I think I will not report another issue if this is how it is handled.

Is there a reason you can't review the ASP.NET Core version at https://docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/advanced ? Even that is scheduled to be removed. Advanced EF topics will all be documented at https://docs.microsoft.com/en-us/ef/core/
The RP version stops at step 8 for that reason.

I just reported an issue with the code in some documentation so that other users don't use the same mistake. I don't know how you are internally organizing and planning things at Microsoft. All I did is just reporting a code issue, hoping it would be fixed and it would help others as these websites are linked and used in a lot of places and forums (some teachers even print it out or copy/paste it in slides).
But if that is just closed, then I don't know what I'm doing here anymore.
It feels like reporting issues in the past in Microsoft Connect where the team just closes it as "not important enough".
I need a coffee ☕ 😞

cc @tdykstra

@wstaelens I don't follow what is wrong here:

Actually this line of code is wrong:
get { eturn this.departmentRepository ?? new GenericRepository<Department>(context); }
as this returns always a new instance of GenericRepository in case the field is null!

What is shared is the context, and that is passed in to the new instance, as described above:

Each repository property checks whether the repository already exists. If not, it instantiates the repository, passing in the context instance. As a result, all repositories share the same context instance.

get { return this.departmentRepository ?? new GenericRepository<Department>(context); }.
in case departmentRepository is null, it returns a new instance of Department. The deparmentRepository field stays null. So the next time it will do the same code "new GenericRepository<..." again returning a new instance. the next time again, and again. because the "this.departmentRepository" is never set.
This code does set the departmentRepository field when null.
```
get
{
if (this.departmentRepository == null)
{
this.departmentRepository = new GenericRepository(context);
}
return departmentRepository;

The information shows a code sample with the ?? part but explains in detail with another code part (if .. == null)...
both codes have similar result but don't act the same.

I understand now.  I investigated and discovered that the code you're talking about was the result of a commit by @rayden84 last October.  I will undo the commit.  Thanks for pointing that out. (Rick is right about lack of resources -- I don't currently work on ASP.NET docs anymore but am squeezing it into my schedule anyway.)

@tdykstra Thanks for taking care of this, Tom!


New default directory for credential files for kpod login?

Currently the default location for credential files for 'kpod login' is /etc/docker/certs.d/{registryname}.  It would be nice to be able to change that to '/etc/oci/certs.d/{registryname}' or some other location that @rhatdan thinks is appropriate.  The one caveat is we need to make sure that a private registry will run OK with this location in play.

/etc/containers/certs.d/...
Works for me.

I would like to work on this issue if nobody else is?

@umohnani8 Did you pick this one up yet?  If not, then it's all yours @surajssd Thanks!

@surajssd Assign your self and go for it.

Is this the same as issue #38? The description looks very alike.

@umohnani8 #38 and #39 are closely related but different.  This one is meant to set a default directory for certificates that kpod and in specific 'kpod login' will use.  #38 is to add a --certs-dir parameter to kpod login so a non-default directory could be specified if so desired.

@umohnani8 @TomSweeneyRedHat Is this fixed now?

Not yet, @umohnani8 has a WIP for the docs and a few code tweaks in Buildah.

Will be fixed when #303 is in.

@rhatdan @TomSweeneyRedHat please close this issue.

Fixed by #303


feat(notification): Added notification block

Description
This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. See EPIC for more detail (MERATIVE-765)
Block > Notification
Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.
New

Added notification block

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Figma Link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1641%3A13366&mode=design&t=leAsxbNftxoq6gTd-1

Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/
After (Changes from this PR): https://786-notification-block--merative2--sahmad-merative.hlx.page/block-library/templates/notification

Testing Instruction

Notification block can be added to the page as shown in the sharepoint link below.

https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc={07BBC79A-1D9E-4B72-B1BF-BAE1AAAB22D7}&file=notification.docx&action=default&mobileredirect=true

All bugs fixed. Thank you.
@proeung @sahmad-merative


Add some debug logging during mac address retrieval.

@dlorenc Thanks!
It's strange successful if reboot... I will continue to debug to vmnet.
LGTM.

passes CI. TravisCI is very slow...
merged, thanks :)

@dlorenc ah! I do not yet merge! sorry, could you re-open it?

Ah whoops :)

@dlorenc 🙇


Segfault fix for CentOS 7

@musl Git er done.

This comments out a particular storage module so that the dataeng service starts. IIRC, the commented entry loads NVMe storage support.

This has also been tested on a couple of different models of server in production.


[AutoPR signalr/resource-manager] remove locale from link

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7723

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/6282


CartoonGan compressing code

Hi, thanks for sharing the code.
Can you make available the compression code for the CartoonGan model?

also looking forward to sharing the compression code for the CartoonGan model :)


Support towncrier >= 19.9.0

Fixes #44

Fixed.

Should be ready for another review.

Should be ready for another review.

Looks like the linter is still unhappy :(
Oh, that's because of the FIXME. I guess we could ignore that line then.

Fixed.


"RuntimeError: CUDA out of memory" while running default train() for Connect4 on 4GB GPU

Hi, just trying the code out. Selecting [2] Connect4, then [0] train, it logs this error in the terminal after a few seconds
Any ideas on how to avoid this error? Reduce batch size? Tensorboard seems to continue to run the error though, although terminal output is stuck on Last test reward: 10.00. Training step: 0/100000. Played games: 27. Loss: 0.00, with only the played games number changing.
2020-07-13 18:07:45,104.ERROR worker.py:987 -- Possible unhandled error from worker: ray::Trainer.continuous_update_weights() (pid=100153, ip=<IP_ADDRESS>)
  File "python/ray/_raylet.pyx", line 446, in ray._raylet.execute_task
  File "python/ray/_raylet.pyx", line 400, in ray._raylet.execute_task.function_executor
  File "/home/user/muzero-general/trainer.py", line 66, in continuous_update_weights
    ) = self.update_weights(batch)
  File "/home/user/muzero-general/trainer.py", line 138, in update_weights
    observation_batch
  File "/home/user/muzero-general/models.py", line 541, in initial_inference
    policy_logits, value = self.prediction(encoded_state)
  File "/home/user/muzero-general/models.py", line 461, in prediction
    policy, value = self.prediction_network(encoded_state)
  File "/home/user/anaconda3/envs/muzero/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/user/muzero-general/models.py", line 370, in forward
    out = block(out)
  File "/home/user/anaconda3/envs/muzero/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/user/muzero-general/models.py", line 204, in forward
    out = self.conv1(x)
  File "/home/user/anaconda3/envs/muzero/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/user/anaconda3/envs/muzero/lib/python3.7/site-packages/torch/nn/modules/conv.py", line 353, in forward
    return self._conv_forward(input, self.weight)
  File "/home/user/anaconda3/envs/muzero/lib/python3.7/site-packages/torch/nn/modules/conv.py", line 350, in _conv_forward
    self.padding, self.dilation, self.groups)
RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB (GPU 0; 3.82 GiB total capacity; 191.73 MiB already allocated; 19.31 MiB free; 210.00 MiB reserved in total by PyTorch)

Hi,
This error probably means that the network you are trying to train is too large. To resolve this, you can try to reduce the batch size as you suggested or lower the other parameters that will have an influence on the allocated memory and if it is not enough you will have to reduce the size of the network.
If you are using the configuration of the repository, you should be aware that this will require a lot of computational resources as Connect4 is a quite difficult environment to solve.
Also, the code of this repository is parallelized which explains that only the number of played games changed during your experiments.
Hope this will help !

Thanks!


[rom_ext_e2e] Sketch bootstrap test plan in rom_ext/e2e/README.md

Hey @alphan, I figured the next step for ROM_EXT bootstrap is to get started on e2e tests. I sketched out an informal test plan. PTAL!

Resolved a few silly mistakes. This PR is just a Markdown file, so I'll merge it without CI checks.


Build manifest to include JOB_NAME

Is your feature request related to a problem? Please describe
Origin: https://github.com/opensearch-project/opensearch-build/pull/1653#discussion_r815728318
The name of the job that triggers integ-test pipeline along with the build ID is used to figure out which distribution to download and run tests against. This requires hardcoding that value.
Describe the solution you'd like
I propose we include the job name with the build manifest. For example:
---
schema-version: '1.2'
build:
  name: OpenSearch Dashboards
  version: 2.0.0
  platform: linux
  architecture: x64
  distribution: tar
  id: '1417'
  job_name: 'distribution-build-opensearch-dashboards'
components:
  - name: OpenSearch-Dashboards
    repository: https://github.com/opensearch-project/OpenSearch-Dashboards.git
    ref: main
    commit_id: 7cb8297622788b7c074cea1f92e4c2ca9f8f5f5d
    artifacts:
      dist:
        - dist/opensearch-dashboards-min-2.0.0-linux-x64.tar.gz
    version: <IP_ADDRESS>
  - name: functionalTestDashboards
    repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git
    ref: main
    commit_id: 24fba9c0cf413db6c16ae4117d0502aae283a019
    version: <IP_ADDRESS>

That way when passing the URL of the build manifest to the test job and downloading the manifest. I can get the value of build.job_name and pass that to run runIntegTestScript.
Describe alternatives you've considered
An assumption could be that the URL passed is the same format https://ci.opensearch.org/ci/dbc/**JOB_NAME**/1.3.0/latest/linux/arm64/builds/opensearch/manifest.yml, and we can do the logic but we have access to the job name while building the build manifest and I think there are no guarantees that the format of this URL will stay the same.
Can also just pass another input in the jenkins params that takes the build job name.
Additional context
I believe adding the job name to the build manifest could provide insight in the future if we have ever change the URLs or if a job was triggered and end up dumping the artifacts to another bucket that does not equal the expect name. Not sure if possible in the current system but if someone hard codes in the Playground it could happen.

[triage] We don't want to add the job_name in the build manifest, since the manifest should only be responsible for building the artifact. We can add job-name as a part of Jenkins pipeline/pipeline.
@kavilla

@kavilla @tianleh Can you please review the triage comments and update this issue accordingly?

@kavilla Can we close the issue if the PR was already merged and tested?

@kavilla @seanneumann Any updates on this issue?

Closing this issue. Please reopen if issue still persists.