Unable to build the http-server example

Hi,
I was trying to build the example you provide in the repo by running tyrian build ./src/main.ts from within the http-server folder. But I got following error
Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/parser/index.js:26
const antlr4_1 = __importDefault(require("antlr4"));
                                 ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/node_modules/antlr4/src/antlr4/index.js from /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/parser/index.js not supported.
Instead change the require of /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/node_modules/antlr4/src/antlr4/index.js in /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/parser/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/parser/index.js:26:34)
    at Object.<anonymous> (/Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/commands/install.js:44:29)
    at Object.<anonymous> (/Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/commands/index.js:8:35)
    at Object.<anonymous> (/Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/dist/main.js:29:36)
    at Object.<anonymous> (/Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/bin/tyrian:3:1) {
  code: 'ERR_REQUIRE_ESM'
}

My environment is as such
java --version
openjdk <IP_ADDRESS> 2022-04-22
OpenJDK Runtime Environment (build <IP_ADDRESS>+2-6)
OpenJDK 64-Bit Server VM (build <IP_ADDRESS>+2-6, mixed mode, sharing)

gradle --version

------------------------------------------------------------
Gradle 7.1.1
------------------------------------------------------------

Build time:   2021-07-02 12:16:43 UTC
Revision:     774525a055494e0ece39f522ac7ad17498ce032c

Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          16.0.1 (Homebrew 16.0.1+0)
OS:           Mac OS X 12.4 x86_64

node --version
v18.2.0

I also run in to the same error whenever i try to "tyrian init" in command line
java --version
openjdk 11.0.16 2022-07-19
OpenJDK Runtime Environment (build 11.0.16+8-post-Ubuntu-0ubuntu122.04)
OpenJDK 64-Bit Server VM (build 11.0.16+8-post-Ubuntu-0ubuntu122.04, mixed mode, sharing)

gradle --version
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/usr/share/java/groovy-all.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

------------------------------------------------------------
Gradle 4.4.1
------------------------------------------------------------

Build time:   2012-12-21 00:00:00 UTC
Revision:     none

Groovy:       2.4.21
Ant:          Apache Ant(TM) version 1.10.12 compiled on January 17 1970
JVM:          11.0.16 (Ubuntu 11.0.16+8-post-Ubuntu-0ubuntu122.04)
OS:           Linux 5.15.0-25-generic amd64

 node -v
v16.16.0

Please try version 9.3.0, which antlr4 is the latest version.

Hi @wizawu,
I did the update and tried again. Unfornuttaly I can not confirm a fix. I still get the same error. I made sure to have installed the correct versions of tyrian and antlr4 by looking into their package.json.
// /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/package.json
{
  "name": "tyrian",
  "version": "9.3.0",
  "repository": "github:wizawu/tyrian",
  "license": "MIT",
  "bin": "bin/tyrian",
  "scripts": {
    "antlr": "cd src/parser/javap && antlr4 -Dlanguage=JavaScript -visitor Javap.g4",
    "build": "tsc -p .",
    "watch": "tsc -p . -w",
    "types": "test $JAVAP && node src/jdk/allclasses.js",
    "test": "cd test && mocha --timeout 5000 unit/*.js unit/**/*.js",
    "lint": "eslint --ignore-pattern '/src/parser/javap/*' --fix src test/unit",
    "lint:types": "eslint --ext .ts --fix @types"
  },
  "dependencies": {
    "antlr4": "4.10.*",
    "chalk": "^4.1.0",
    "commander": "^6.2.0",
    "dotenv": "^10.0.0",
    "glob": "^7.1.6",
    "jszip": "^3.7.0",
    "prompts": "^2.4.0",
    "redent": "^3.0.0",
    "ts-loader": "^8.0.17",
    "typescript": "4.7.*",
    "webpack": "^5.24.2",
    "which": "^2.0.2"
  },
  "devDependencies": {
    "@types/antlr4": "^4.7.2",
    "@types/glob": "^7.1.3",
    "@types/node": "^12.19.9",
    "@typescript-eslint/eslint-plugin": "^4.9.1",
    "@typescript-eslint/parser": "^4.9.1",
    "eslint": "^7.15.0",
    "mocha": "^9.2.0",
    "node-html-parser": "^2.0.2"
  }
}

// /Users/abaykal/.nvm/versions/node/v18.2.0/lib/node_modules/tyrian/node_modules/antlr4/package.json
{
  "name": "antlr4",
  "version": "4.10.1",
  "type": "module",
  "description": "JavaScript runtime for ANTLR4",
  "main": "src/antlr4/index.js",
  "repository": "antlr/antlr4.git",
  "keywords": [
    "lexer",
    "parser",
    "antlr",
    "antlr4",
    "grammar"
  ],
  "license": "BSD-3-Clause",
  "bugs": {
    "url": "https://github.com/antlr/antlr4/issues"
  },
  "homepage": "https://github.com/antlr/antlr4",
  "devDependencies": {
    "@babel/preset-env": "^7.16.11",
    "babel-loader": "^8.2.4",
    "eslint-plugin-es5": "^1.5.0",
    "eslint-webpack-plugin": "^3.1.1",
    "glob-parent": "^6.0.2",
    "jasmine": "^4.0.2",
    "jasmine-spec-reporter": "^7.0.0",
    "minimist": "^1.2.6",
    "webpack": "^5.66.0",
    "webpack-cli": "^4.9.1"
  },
  "scripts": {
    "build": "webpack",
    "test": "jasmine"
  },
  "engines": {
    "node": ">=14"
  },
  "browser": {
    "fs": false,
    "net": false,
    "module": false
  }
}

The previous dist is built by Node 12. The errors were caused by running tyrian on newer version of Node.
Please install<EMAIL_ADDRESS>and have Node.js >= 14.x installed


isInt and isFloat now accept options (min, max).

isInt and isFloat can now optionally accept an options argument which can have either min and/or max to test the value is within boundaries.
Updated minified version.
Updated README.md.
Added test suites in test/validators.js.

Coverage increased (+0.01%) to 98.94% when pulling d6e44533638234a1c7dd667428a1cfe6f394e898 on freak4pc:minmax into 443ed44dae746439b075ac8bc446c7754933de3a on chriso:master.

Looks good, thanks.


Added more helper functions to ImplicitTileCoordinates

While reviewing https://github.com/CesiumGS/cesium/pull/9517 I started to integrate the implicit tiling code into another feature I'm working on. The transition went really smoothly except I wanted more capability out of ImplicitTileCoordinates. So this PR is mainly about that, as well as some little fixes I found along the way.

Thanks for the pull request @IanLilleyT!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@ptrgags I believe I've addressed all of the feedback, both big and small.
The API for ImplicitTileCoordinates is now:
getDescendantCoordinates(offsetCoordinates)
getAncestorCoordinates(offsetLevel)
getOffsetCoordinates(descendantCoordinates)
getChildCoordinates(mortonIndex) - a special case of getDescendantCoordinates
getSubtreeCoordinates() - a special case of getAncestorCoordinates
getParentSubtreeCoordinates() - a special case of getAncestorCoordinates
isAncestor(descendantCoordinates)
isEqual(otherCoordinates)
isImplicitTilesetRoot()
isSubtreeRoot()
isBottomOfSubtree()
fromMortonIndex(level, mortonIndex) / .mortonIndex
fromTileIndex(tileIndex) / .tileIndex
.childIndex - equivalent to getAncestorCoordinates(1).getOffsetCoordinates(this).mortonIndex
I called it offset instead of relative because relative is perhaps too familial. But I'm ok with changing the name to something else for this or any of the other functions.
Also, there are now unit tests and coverage for all new functions in ImplicitTileCoordinates and ImplicitSubtree

@ptrgags this is ready for another review

Travis is being difficult today. The only issue was a build timed out, but Travis is having issues with the GH API so I can't log in to restart it

After talking with @lilleyse, we're just going to merge this into the staging branch.


[CENT-392] write README for MINT p0

The file doc/masterminter.md is a README file explaining the usage and functionality of the MasterMinter contract.

Fixed all typos detected by @o-a-hudson


fix router inconsistencies on firefox/edge

update:

working as intended for all browsers when hosted
local files: edge: works, chrome: works without back button, firefox: error message "operation is unsafe"


unable to connect the npm downloads

I'm unable to connect the npm downloads to a project.
Debug
npm Downloads by Google Data Studio Developer Relations

Cannot set aggregation type for field: downloads since it is not reaggregatable.

getSchema:110

Thanks for the bug report! I'll try to fix this soon.

This is a hugely spread issue. You need to ditch the .setAggregation(aggregations.SUM) call and then select SUM in the fields config wizard step.
Anxiously waiting for this fix as well.

I have addressed this bug and the fix should be rolling out in the next few days. For the time being, to fix in connector code, just add .setIsReaggregatable(true) to all fields that have a  call to .setAggregation(...)

I was working on the codelab "Get Started with Community Connectors" and could not complete the step "Configure the connector", adding the .setIsReaggregatable(true) under the filed listed below fixed the issue.
Thanks!
fields.newMetric()     .setId('downloads')     .setType(types.NUMBER)     .setAggregation(aggregations.SUM)

learn

This bug has been fixed. The DataStudioApp builder for fields should have defaulted to setting isReaggregatable to true (as our legacy docs detail), but it was defaulting to false. This coupled with new validation to make sure you don't accidentally set a defaultAggregationType for a field that can't be aggregated caused the issue. Thanks everyone for their patience.


Einsum support via Decomposition

I'm considering implementing EinSum support at the ONNX decomposition stage.
More specifically breaking it into a series of matrix multiplications, reduceSums, and other operators depending on the input string.
Would you guys accept such a contribution?

That would be perfectly acceptable for a reference implementation.
If you implement EinSum in a series of ONNX ops, please add a lit test to verify that it works as advertised.
I just found that we have backend tests for Einsum that are currently not enabled, please look in the subdirectory onnx-mlir/third_party/onnx/onnx/backend/test/case/node to locate the Einsum specific tests to be added in test/backend/inference_backend.py.
Feel free to proceed with small PRs that might be easier to review than one large one.


Eltako FCO2TS (EEP A5-09-04)

Eltako:
FCO2TS
Link to product:
Can't find this devise. Any chance to add it? Basically its Temp and Hum. like others but with CO2 in addition.
If helpful i can extract the raw telegram. Does your adapter support such function? Otherwise is will connect other Monitor temporary.
Thanks.

Yes it is possible to add it. I am actual on a bigger rework, so it takes some time until the next release will come.


Overrides should work with lintText()

Currently it's only used for lintFiles(). Editor plugins use lintText(), so we need to support it there too. They use the filename option to indicate the source filename.

Fixed by https://github.com/sindresorhus/xo/commit/040d8be1467d824ec1ca64d2c80a9173c303b73f.


Duplicate StyleCop warnings in tooltips.

This is just one example, but every StyleCop warning is displayed three times on tooltips.
Offending code:
private void Main_FormClosing(object sender, FormClosingEventArgs e)

Mouse Over tooltip:

VS 2013, R# Ultimate 10.0.1
Only two extensions installed:

Enhanced Tooltip <IP_ADDRESS>,
StyleCop by JetBrains 4.8.0

I've tested the issue with enhanced tooltip installed/uninstalled - same problem.

Same for VS 2015 Community, only StyleCop by JetBrains 4.8.0 installed

Is there anything special going on with the solution? Is it shared projects? Can you share the project?

No. Maybe its helpful to point out thet this didn't happen when I was using VS 2013 and Resharper 8...

I have only one extension StyleCop by JetBrains 4.8.0, and have the same issue. It is clean system. R# <IP_ADDRESS>. And every stylecop issue is displayed 3 times.

I can't reproduce this - I only get one tooltip. I'm about to push a new version for ReSharper 2016.1, which is only showing one tooltip. Could you check with the new version when it's available, please? (Hopefully in a couple of hours)
The errors shown by the installer are benign - it's trying to load the plugin to look for custom build steps (there aren't any) and the layout of the plugin on disk means it can't load the Rules assembly. It still installs correctly.

Aha. Found a repro. It's due to a file that depends on another file, e.g. .xaml and .xaml.cs. Unfortunately, the ReSharper plugin is passing in the single file multiple times, rather than all of the dependent files.


Admin section isn't documented

I'm not sure whether this is intentionally or not, but http://<ip>/admin.html is undocumented.
Considering extended functionalities such as Self Test or various Reset options, I believe that such page should be part of documentation and/or link should be part of http://<ip>/settings.html.

This is intentionally not documented, as the average user does not take any advantage of this page. It would only cause questions. I use this page (or API) internally for testing and preparing delivery.


Multiple tag search

Multiple tag search should be available in the future, I'm afraid that the current data structure can't support it.

Pretty sure it can be implemented. Nothing wrong with the data structure.


Remove trailing spaces and add UglifyJS url link

Unfortunately trailing spaces in markdown make some sense (for line breaks)
http://daringfireball.net/projects/markdown/syntax#p

@faergeek Thanks for letting me know.


Also get coverage for pyx file

See theochem/cellcutoff#4 for an example. Also use && to concatenate bash commands in .travis.yml, to get the right return code.

The approach coverage xml -i doesn't work with arbitrary Cython (it probably works here only because the Cython file contains code that is valid Python). See coverage.py #601.

We have the following in our .coveraverc file, which is supposed to make it work:
[run]
plugins = Cython.Coverage

Thanks a lot for making this observation. I had these lines in my .coveragerc under the directory tests/ (where I run tests of the installed--not in-place built--package). But when trying to collect coverage statistics for Cython files only in-place building works, so I was working outside the tests directory, which didn't contain any .coveragerc.
Copying the .coveragerc to where I run nosetests resolved the issue, and coverage xml worked without errors.


finesse.inspection.alpha.canada.ca displaying wrong page title

Bookmarks display as
Vite + React + TS (canada.ca)
Should have an appropriate title such as:
CFIA AI Lab Finesse Semantic Search

@nmeraihi mentioned this has an impact with our public image; quick win to fix.


Adopt Function

I have created an adoption function that you could add to you API.
public function adopt_ap($site_id, $mac) {
if (!$this->is_loggedin) return FALSE;
$mac             = strtolower($mac);
$return          = FALSE;
$json            = json_encode(array('mac' => $mac, 'cmd' => 'adopt'));
$content_decoded = json_decode($this->exec_curl($this->baseurl.'/api/s/'.$this->site.'/cmd/devmgr','json='.$json));
if (isset($content_decoded->meta->rc)) {
if ($content_decoded->meta->rc == 'ok') {
$return = TRUE;
}
}
return $return;
}

Thanks for this!
I'll add it to the next release but I'm thinking of dropping $site_id as a parameter. Since we always are operating within the scope of a specific site within the class instance, adoption of an AP to the current site ($this->site) make most sense. Also, you don't appear to be using it within the function/method.
Do you agree?

I have another php script that I use to call this function to run it. That's also why I have the $site_id parameter.

Ah, I see, would not be necessary in the public version then. Thanks again for the contribution!

published with API client class version 1.0.13


How to get the RT Matrix?

From the C++ code, I don’t seem to see how to get the rotation and translation matrix. How can I get this correspondence ?
Thank you so much！

Hi @dongyu728, once CLIPPER provides the correspondences, you are free to use any method for estimation the transformation. Typically, this will be a least squares method. For example, in C++ you could use Eigen::umeyama or in python you could implement Arun's method, like so:
def arun(q, p):
    """Arun's Method
    Minimizes ||q - (Rp + t)||^2
    in:
        q   dxn np.array (d is 2D or 3D)
        p   dxn np.array
    out:
        (R, t)  SE(d) rigid body transformation
    """
    assert q.shape[0] == p.shape[0]
    assert q.shape[1] == p.shape[1]
    assert q.shape[1] > 0

    d, n = q.shape

    # shift point clouds by centroids
    mu_q = q.mean(1)
    mu_p = p.mean(1)
    Q = q - np.tile(mu_q, (n, 1)).T
    P = p - np.tile(mu_p, (n, 1)).T

    # construct H matrix (dxd)
    H = np.matmul(Q, P.T)

    # perform SVD of H
    U, _, Vt = np.linalg.svd(H, full_matrices=True, compute_uv=True)
    D = np.eye(d)
    D[d-1,d-1] = np.linalg.det(np.matmul(U, Vt))

    # solve rotation-only problem
    R = np.matmul(np.matmul(U, D), Vt)

    # solve translation
    t = mu_q - np.matmul(R, mu_p)

    return R, t

(from aclswarm)


smartAccount.deploy()

How could we improve the Biconomy documentation site?
Document smartAccount.deploy() for upcoming release

@joepegler let me know once these methods are added.


updated with HTTPS support and new xml format

The Beacon only supports HTTPS, and the XML format changed. It now works for me.

Resolves #3 and #4.


Animations are not smooth

Animations aren't smooth it delete letters while typing , and shaking
https://user-images.githubusercontent.com/26079832/185244076-34c1f115-cb3c-4c44-bfab-0cce712fb161.mp4

Hey,
which version are you on? This is a typical development-only bug that happens when you save changes in your code, as certain technologies (create-react-app, nextjs, etc.) try to hot-reload your page on changes while maintaining previous state which may cause the animation to be applied multiple times to the same element since the animation is just an async function that is not stored in React state.
You need to hard-reload your page (refresh button at the top left of the browser) whenever you make changes to the component to reset the DOM and call-stack. If it also bugs out when you save changes that are not related to the TypeAnimation component, you probably have an older version installed as the component is now memoized permanently, which prevents any re-renders that cause this bug.
I think I could make the animation use React's state which would eliminate this bug, but it would cause a very high amount of re-renders of the component as the sequence would get pushed sequentially (and potentially infintely) to the state-array.

I used latest version of this package yesterday (can't remember the ver number) , I'm using Next.js 12.2.4 react": "18.2.0", I don't think it's a hard reload issue bcz I always did it to test as in doc, but I didn't tried it in production env, just dev mode

I used latest version of this package yesterday (can't remember the ver number) , I'm using Next.js 12.2.4 react": "18.2.0", I don't think it's a hard reload issue bcz I always did it to test as in doc, but I didn't tried it in production env, just dev mode

next 12.2.4 is also used in  /example and I just updated react to 18.2.0 (deployed on https://react-type-animation.vercel.app/) and the bug never appears, because it only happens when the component re-renders, but because the component is memoized permanently, it never does so until a hard-refresh

I used latest version of this package yesterday (can't remember the ver number) , I'm using Next.js 12.2.4 react": "18.2.0", I don't think it's a hard reload issue bcz I always did it to test as in doc, but I didn't tried it in production env, just dev mode

next 12.2.4 is also used in /example and I just updated react to 18.2.0 (deployed on https://react-type-animation.vercel.app/) and the bug never appears, because it only happens when the component re-renders, but because the component is memoized permanently, it never does so until a hard-refresh

Hmm ... I'll give a another try in prod env

I used latest version of this package yesterday (can't remember the ver number) , I'm using Next.js 12.2.4 react": "18.2.0", I don't think it's a hard reload issue bcz I always did it to test as in doc, but I didn't tried it in production env, just dev mode

next 12.2.4 is also used in /example and I just updated react to 18.2.0 (deployed on https://react-type-animation.vercel.app/) and the bug never appears, because it only happens when the component re-renders, but because the component is memoized permanently, it never does so until a hard-refresh

Hmm ... I'll give a another try in prod env By the way package is awesome 💖

If it's really bugging out during dev on the latest version with hard-reloads it will most likely also bug in production, but I just tried all possible ways to re-render the component but because of this usage of memo:
export default memo(TypeAnimation, (_, __) => {
  return true; // immutable, never re-renders
});

It doesn't re-render in any scenario, so I can't really reproduce it anymore. This bug used to happen often with older versions without the memo, as next's _app or page-level state sometimes caused the component to re-render. You could try using React Dev Tools to see if the component re-renders at any given time.

I have this bug. This does not happen in production it only happens in dev mode with React.StrictMode enabled. React-StrictMode causes 2 renders to detect bad hook usage.

This bug will be because 2 typing animations are happening concurrently, you will be a unmount function for useEffect

I added a tested useEffectOnce hook now in v2.1.0 which also fixed the issue. It's just a tiny overhead but I guess it's worth it for the developing experience


React16/update dygraphs

This PR drops our fork of dygraphs library to use the upstream. They've resolved their package main entry point issue and we don't need the fork anymore. I copied some relevant styles to keep labels rotated.
Has to be tested in conjunction with EE PR https://github.com/mesosphere/dcos-ui-plugins-private/pull/931
Testing
outlined it https://github.com/mesosphere/dcos-ui-plugins-private/pull/931
Dependencies
https://github.com/mesosphere/dcos-ui-plugins-private/pull/931

Package-lock conflict as we merged the react 16.8 PR.

just slightly related: can we remove src/js/vendor/dygraph-combined.js?

oh, good catch, thanks! I think we should be able to. I will remove it
On Thu, Feb 21, 2019 at 12:31 PM Pierre Beitz<EMAIL_ADDRESS>wrote:

@pierrebeitz approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dcos/dcos-ui/pull/3609#pullrequestreview-206254978,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALXb7eOaqZmiwSyanz-GvW5966i1owLks5vPoOCgaJpZM4bDiqJ
.

--
Dmitrii Rozhkov
Software Engineer Frontend, Mesosphere

@GeorgiSTodorov @pierrebeitz please give it another look 🙇

@nLight , do we want to merge?

\o/ thanks!

:tada: This PR is included in version 2.55.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setting buildMachines without distributedBuilds = true should throw an error

Issue description
This surprised me when I set buildMachines to some local machines but no builders were being detected. This was very weird because /etc/nix/machines was generated correctly. Apparently, you also need to set distributedBuilds = true otherwise Nix won't pick up on /etc/nix/machines. Even if this is expected behavior, it should at least throw an error when you set buildMachines but not distributedBuilds = true.
/cc @edolstra
Steps to reproduce
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

Correct me if I am misunderstanding.
Doesn't it make sense to have a simple on/off switch for using the builders?
(e.g. if something goes wrong, you don't have to comment out all the builders)

If that change is made we lose the ability to use the module to specify build machines but only enable them when wished by setting the builders parameter to.


title generation

when running the conditional sample and trying to generate a title i get the folowing error:
tensorflow.python.framework.errors_impl.InvalidArgumentError: assertion failed: [] [Condition x <= y did not hold element-wise:x (sample_sequence/newslm/embeddings/strided_slice:0) = ] [1089] [y (sample_sequence/newslm/embeddings/assert_less_equal_1/y:0) = ] [1024] 	 [[{{node sample_sequence/newslm/embeddings/assert_less_equal_1/Assert/Assert}}]] 	 [[{{node sample_sequence/while/Exit_3}}]]
so with my limited understanding of the code, it seems that the title tokens dont get fit to the max seqence size when generating a title
is this a correct observation ? and if so is there a fix available ?

Hmm, I think the issue is that the context tokens weren't being truncated correctly. If you can pinpoint the issue (and it's with the repo) I'd be happy to accept a PR fixing it :)

Hi @rowanz , this is the same error I ran into and e-mailed you about. I run into the error when adding the -target title argument, like below:
python3 sample/contextual_generate.py -model_config_fn lm/configs/base.json -model_ckpt models/base/model.ckpt -metadata_fn sample/april2019_set_mini.jsonl -target title -out_fn april2019_set_mini_out.jsonl
One title is generated in the output file and this error message pops up:
tensorflow.python.framework.errors_impl.InvalidArgumentError: assertion failed: [] [Condition x <= y did not hold element-wise:x (sample_sequence/newslm/embeddings/strided_slice:0) = ] [1073] [y (sample_sequence/newslm/embeddings/assert_less_equal_1/y:0) = ] [1024]
	 [[{{node sample_sequence/newslm/embeddings/assert_less_equal_1/Assert/Assert}}]]

Has there been any advances with this issue yet?

thanks @onikula for the reminder! this should fix it https://github.com/rowanz/grover/commit/f59a206a8722357c351eae9e937b9f7a53bfda61 - let me know if it doesn't 😄


[Feat] Allow reuse of an existing db connection when creating a MySQL storage driver

Support for passing an existing db connection was requested in this thread: https://github.com/gofiber/storage/issues/147
This pull request implements support for this feature in the MySQL storage driver, allowing the developer to optionally reuse their existing db connection to Get/Set session data.
It also updates the README removing references to postgres.

[ ] please add a test case for your adjustment

Hi Rene
There were no test cases for the existing functionality of the 'New' method so I wasn't sure what would be the best way to test this.
This test case creates the 3 different ways of returning a db connection in the interface (through authentication values or ConnectionURI or by passing an existing connection).


Unable to Start Quest

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1664
Describe the bug
When I try to launch a mission using the script, it will tap start quest but the mission will not start. If I proceed to stop the script and try to manually start the mission I am unable to interact with the game at all.
Video
I tried for over an hour to get a recording to work but I cannot get it take take video and run the script at the same time no matter what settings I adjust.
Device model
S22 Ultra
Android version
12
Screen size
No response
RAM
No response

Duplicate of #1100


allow overriding handle_errors after using Sentry.Plug

mention this in docs, as well as a fact that using Sentry.Plug does not retain Plug.ErrorHandler default behaviour of sending "Something went wrong" as a response (because Sentry.Plug does not call super() in it's handle_errors/2 implementation)

Thanks for opening this, I’ll take a look soon!

Thanks! 💖


BMW changed authentication method (?)

Seems that BMW has changed their login mechanism and adapter can't authenticate anymore:
bmw.0 | 2024-11-20 21:21:25.929 | error | undefined
bmw.0 | 2024-11-20 21:21:25.928 | error | Start relogin in 5min
bmw.0 | 2024-11-20 21:21:25.927 | error | Please check username and password or too many logins in 5 minutes
bmw.0 | 2024-11-20 21:21:25.926 | error | {"error":"invalid_client","error_description":"Client authentication failed (e.g., login failure, unknown client, no client authentication included or unsupported authentication method)"}
bmw.0 | 2024-11-20 21:21:25.925 | error | AxiosError: Request failed with status code 401
bmw.0 | 2024-11-20 21:21:25.923 | error | Login failed
To reproduce, just restart your instance

I have upgraded to 2.8.3 and the result was:
bmw.0 2024-11-21 19:26:39.536	error	{"error":"invalid_request","error_description":"The request is missing a required parameter, includes an unsupported parameter value (other than grant type), repeats a parameter, includes multiple credentials, utilizes more than one mechanism for authenticating the client, or is otherwise malformed"}
bmw.0 2024-11-21 19:26:39.535	error	AxiosError: Request failed with status code 400
bmw.0 2024-11-21 19:26:39.533	error	refresh token failed
There seams to be a major problem in the authentification process

2.8.3: Please generate a captcha in the instance settings.
I've do this and now it works.....
Is this a possible Solution for you too?

I've done this several times but it does not work

Solved: I have deleted and generated the instance again.

Works fine.
Perfect Job !
Solved.

It's not working for me yet.
I updated to 2.8.4 and also deleted and reinstalled the instance.
My problem: I can klick in "I'm a human", the box is working but stays unchecked. I can do this several times, but nothing changed.
More down at the line of Captcha, just "[object Object]" is entered.
BR, Bender275

Thank you very much, Mr. Developer!
2.8.4 works fine for me.
Will this be one-time re-authentication or it will require re-captcha login every month or so?

captcha is need only after firstadapter installation
@Bender275 Please check the login in the app

I don't know I assume around 10min
But captcha is only needed after adapter installation or after deletion of the auth.session

I don't know I assume around 10min But captcha is only needed after adapter installation or after deletion of the auth.session Which 401 error exactly

2024-11-24 04:21:08.164 - error: bmw.0 (82140) refresh token failed
2024-11-24 04:21:08.164 - error: bmw.0 (82140) AxiosError: Request failed with status code 403
2024-11-24 04:21:08.164 - error: bmw.0 (82140) "403 Forbidden"
2024-11-24 04:21:08.164 - error: bmw.0 (82140) Start relogin in 1min
2024-11-24 04:22:08.282 - error: bmw.0 (82140) Login failed
2024-11-24 04:22:08.282 - error: bmw.0 (82140) AxiosError: Request failed with status code 401
2024-11-24 04:22:08.282 - error: bmw.0 (82140) {"error":"invalid_client","error_description":"Client authentication failed (e.g., login failure, unknown client, no client authentication included or unsupported authentication method)"}
2024-11-24 04:22:08.282 - error: bmw.0 (82140) Please check username and password or generate a new captcha in the instance settings
2024-11-24 04:22:08.282 - error: bmw.0 (82140) Please wait 5 minutes before trying again
2024-11-24 04:22:08.282 - error: bmw.0 (82140) Start relogin in 5min
2024-11-24 04:22:08.282 - error: bmw.0 (82140) undefined

I had to manually delete auth.session and generate a new captcha in order to get it back operational.

I don't get it working... :-(
I installed the app on a third device and get no Captcha, also after reinstalling the app.
Also in the browsers, no matter which browser, no matter which device - no captcha, login is always working with user and passwort.
I click on the cpatcha generation, but nothing happens.
Error in the log:

bmw.0 | 2024-11-24 20:03:17.968 | error | Please check username and password or generate a new captcha in the instance settings
-- | -- | -- | --
bmw.0 | 2024-11-24 20:03:17.968 | error | {"error":"invalid_client","error_description":"Client authentication failed (e.g., login failure, unknown client, no client authentication included or unsupported authentication method)"}
bmw.0 | 2024-11-24 20:03:17.966 | error | AxiosError: Request failed with status code 401
bmw.0 | 2024-11-24 20:03:17.964 | error | Login failed

I also deleted the instance and the adapter and reinstalled it again a few minutes ago - no success.
Where is the auth.session?

Where is the auth.session?

This the object:

The ident works here not with Safari but it works with chrome.

I tried Firefox and Edge at 3 different Windows clients with and without private mode - I even created new user profiles.
I installed four different browsers at my smartphone.
I even tried it with the browser app of the TV.
I reinstalled the app at my tabled several times.
Of course, I disabled pihole every time - I even bypassed it by changing the DNS-server.
All without success - I don't get a captcha.

You will not see a captcha. You check the checkbox and then click on submit and a long text string will appear then you press save

That's my problem: My checkbox remains empty, the string is [object Object] - I just don't get it :-(

Please test the GitHub version and check the browser console with Developer Console via F12

Seems that BMW has changed their login mechanism and adapter can't authenticate anymore:
bmw.0 | 2024-11-20 21:21:25.929 | error | undefined bmw.0 | 2024-11-20 21:21:25.928 | error | Start relogin in 5min bmw.0 | 2024-11-20 21:21:25.927 | error | Please check username and password or too many logins in 5 minutes bmw.0 | 2024-11-20 21:21:25.926 | error | {"error":"invalid_client","error_description":"Client authentication failed (e.g., login failure, unknown client, no client authentication included or unsupported authentication method)"} bmw.0 | 2024-11-20 21:21:25.925 | error | AxiosError: Request failed with status code 401 bmw.0 | 2024-11-20 21:21:25.923 | error | Login failed
To reproduce, just restart your instance

Same here

to install the adapter 2.8.4 via NPN and do the Captcha Auth solved this problem for me.

Same problem here. I tried multiple cases. With or Without Chapta.
Delete and create new Instance solved the problem.

what is the captcha text input showing in the settings

what is the captcha text input showing in the settings

There is also a Button.  Press it.

Correct. Mark the checkbox, Press the button below. A new Key will appear below.
This will be used for authentication.
works for me.

Please test the GitHub version and check the browser console with Developer Console via F12

I get the following message, when I click in the captcha:
XHRPOST
https://hcaptcha.com/getcaptcha/7244955f-8f30-4445-adff-4fefe059f815
[HTTP/3 403  121ms]
Das Cookie "__cflb" wurde abgelehnt, weil es sich in einem seitenübergreifenden Kontext befindet und sein "SameSite" auf "Lax" oder "Strict" gesetzt ist.
I don't know, what else I can configure in Firefox - everything is allowed or disabled.
The error also comes in all the other browsers, so I don't think of a configuration issue.

I installed Chrome on my laptop and mande the settings

allow 3rd party cookies
safe browsing: no security

How the url looks like?

Yes, this url and tha captcha behind it works for me.
And your hint was the solution!!!!!!
Usually, I connect to iobroker via tha NAME of the Raspi, not the IP.
So, I tested it via IP - and the captcha works!
Thank you very much for your patience and support!


[SPARK-47515][SPARK-47406][SQL][FOLLOWUP] Add legacy config spark.sql.legacy.mysql.timestampNTZMapping.enabled

What changes were proposed in this pull request?
This PR adds a legacy config spark.sql.legacy.mysql.timestampNTZMapping.enabled to make user available to restore the old type mapping between timestamp_ntz and MySQL TIMESTAMP/DATETIME
Why are the changes needed?
Avoid unrecoverable breaking changes, following the principles of https://lists.apache.org/thread/6bb1crw9dqgntp2p4dk67b7313mo5frz
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no

cc @cloud-fan

Thank you @dongjoon-hyun @HyukjinKwon
Merged to master

late LGTM


Add googleapis-common-protos and protobuf dependencies

Having those dependencies should workaround the problem described in the referenced issue below.
Fixes: https://github.com/AlmaLinux/build-system/issues/232

Thank you for your work @javihernandez !!
It looks OK for me.


How to add local script file?

I want to use aspire to orchestrate one service including local PowerShell executable script. However, the error is observed.

The snippet code just shows my usage:
var builder = DistributedApplication.CreateBuilder(args); var test = builder.AddExecutable("test", "one.ps1", "./");
So, how can I add local script file to the executable resource?

The executable would be powershell, the argument would be the ps1 file.

The executable would be powershell, the argument would be the ps1 file.
var test = builder.AddExecutable("test", "powershell",  ".", "one.ps1");

Thanks, I can execute the local powershell script like this way:
var test = builder.AddExecutable("test", "powershell", ".", "one.ps1", "-ExecutionPolicy", "Bypass");


Can not open the video and style image in the example folder.

Can not open the video and style image in the example folder. It says style not match

Hello, @AlexCHENSiyu! It seems like you're encountering issues with opening video and style images in an example folder. This issue could be related to how the files are stored in the repository, likely with Git Large File Storage (LFS). Git LFS is used for managing large files separately from the main Git repository, allowing for more efficient handling of binary files such as images and videos.
To address this issue, please ensure that you have Git LFS installed on your system. If it's not installed, you can follow these steps to install Git LFS and subsequently access the files:

Install Git LFS: You can download Git LFS from the official site (https://git-lfs.github.com/) or use a package manager to install it on your system. For example, if you're using Homebrew on macOS, you can install it by running brew install git-lfs in your terminal.

Initialize Git LFS: After installing, you need to set up Git LFS on your machine. Open a terminal or command prompt and run git lfs install. This command needs to be run once per user account.

Pull LFS Files: Navigate to your local clone of the repository where you're trying to access the files. If you've already cloned the repository before installing Git LFS, you'll need to fetch the LFS files with git lfs pull. This command downloads the actual content of the large files that were previously placeholders in your clone.

I hope these steps help you resolve the issue with opening video and style images in your example folder. If you have any more questions or need further assistance, feel free to ask!

Thank you for your help and sharing of the project.


Task :prepareKotlinBuildScriptModel is failing with HTTP 407 while trying to download gradle sources

In SourceDistributionProvider class there is a hardcoded url to https://services.gradle.org  which is, of course, blocked in our company and while refreshing a project, task :prepareKotlinBuildScriptModel is failing with HTTP 407.  And looks like this error happening when env GRADLE_HOME is set.
Think this url need to be taken from distributionUrl property
Expected Behavior
Task :prepareKotlinBuildScriptModel is finished successfully
Current Behavior
Task :prepareKotlinBuildScriptModel is failing with HTTP 407
Steps to Reproduce
Create any simple project ether with gradle init or https://start.spring.io/
set env GRADLE_HOME=[path to gradle]
block services.gradle.org
Import a project to IntelliJ
Your Environment
Gradle 7.2

Duplicate of #18249


[BUG] - makeTransactionBodyAutoBalance underestimates execution units when the change has native tokens

Internal/External
External
Area
Other cardano-cli transaction build
This issue involves makeTransactionBodyAutoBalance found in cardano-api which is why I am opening the issue here.
Summary
This is a duplicate of this bug submitted to the cardano-node repo. The TLDR is that whenever plutus scripts are used in a transaction where the change output contains native tokens, the makeTransactionBodyAutoBalance function will underestimate the execution units for the scripts present.
I believe the issue is that when makeTransactionBodyAutoBalance creates the first intermediate transaction here to submit for execution unit estimations, it only includes a dummy value of lovelace for the change output in the temporary transaction. The native tokens that will ultimately be present in the change output are simply missing from this intermediate transaction - they are not present anywhere in the outputs. This results in a transaction that is smaller in size than it ultimately will be once the native tokens are added to the change output. Currently, makeTransactionBodyAutoBalance only adds the native tokens for the second intermediate transaction here. This has now changed the overall size of the transaction which means the previously calculated script execution budgets are inaccurate. The first intermediate transaction also needs to include any native tokens that will go to the change output in order to better reflect the ultimate size of the transaction.
Steps to reproduce
Steps to reproduce the behavior:

Create a UTxO with native assets locked at a plutus script address.
Spend the above UTxO and have cardano-cli transaction build automatically calculate the change output which should contain the native asset.

Expected behavior
cardano-cli transaction build should properly balance the transaction and properly estimate the necessary script execution budgets.
System info (please complete the following information):

OS Name: Ubuntu
OS Version 22.04

$ cardano-cli --version
cardano-cli 8.1.2 - linux-x86_64 - ghc-8.10
git rev d2d90b48c5577b4412d5c9c9968b55f8ab4b9767

Appears to be fixed by

https://github.com/IntersectMBO/cardano-api/pull/622
Let us know if this issue if this needs reopening.


Fixed code-gen error. Optimized number of Patterns.

Towards #1108

Current coverage is 95.09%

Merging #1109 into master will not affect coverage as of 00f5ead

@@            master   #1109   diff @@
======================================
  Files           77      77
  Stmts         9312    9312
  Branches      1729    1729
  Methods          0       0
======================================
  Hit           8855    8855
  Partial         91      91
  Missed         366     366

Review entire Coverage Diff as of 00f5ead

Powered by Codecov. Updated on successful CI builds.


Make defense less vulnerable to lures / mines

Too stringent and we risk getting a run-around and the CPU killed. We can probably clear if either condition is satisfied:

<= 3 spaces away with sensors on
<= 1 space away with no sensors on

Also, bots should not follow enemies more than halfway across the map (just delete enemy target location). This will both cause them to be less sensitive to mines, and get back to the CPU faster in case of lures. Because it will return and not just sit at the edge, it won't be vulnerable to artillery micro.

Closed as a subset of #53.


Add coverage test

Fix #21

A few considerations:

sometimes macos test fails, like windows did. Maybe should we fix it together with #31 ?
the coverage test shows that we don't use yarp::dev::IAnalogSensor interface and its methods that we implemented taking inspiration from gazebo-yarp-plugins. Indeed we use only yarp::dev::ISixAxisForceTorqueSensors . Should we remove or keep it?
there are other lines of code that are not covered, such as the error handling ones. We don't know if we should try to cover also them

Good job! I really like that you did not modified anything in the CMake files to add coverage support. For what regards IAnalogSensor methods, feel free to remove them, those interfaces are deprecated. For the rest, I think that for this software there is no strict need for 100% line coverage.

Cool, it seems to work! Probably the error "❗ No coverage uploaded for pull request base (main@f498935). Click here to learn what that means." it is due to the fact that at the moment the base branch does not have coverage information, but that should be solved once we merge this PR.

@lucapa17 @GiacomoBisio please remember either to cleanup the history of PRs before merging or (easier) merging PRs as squash, otherwise the history of the repo will become really difficult to navigate, thanks!

@lucapa17 @GiacomoBisio please remember either to cleanup the history of PRs before merging or (easier) merging PRs as squash, otherwise the history of the repo will become really difficult to navigate, thanks!

To prevent errors, at the moment I forced "Squash and merge", if you want to allow merge commits let me know!


LMB+RMB stops working in scene view with this asset

I found with Unity 2022.3.f14 and above, that the presence of ReorderableArrayInspector.cs in the project will stop the LMB+RMB from working in the scene view.
This might be related to this fix in f14
I have also reported the bug to Unity.

Unity responded to my bug with the following, in case it is useful for fixing it.

we have found this specific code area in the script to cause the bug:
protected static bool FORCE_INIT = false; [DidReloadScripts] private static void HandleScriptReload() { FORCE_INIT = true; EditorApplication.delayCall = () => { EditorApplication.delayCall = () => { FORCE_INIT = false; }; }; }
Specifically, the bug disappears when commenting out this line:
EditorApplication.delayCall = () => { EditorApplication.delayCall = () => { FORCE_INIT = false; }; };


My reservations link

When the user clicks the "My reservations" link in the navigation panel
they can see a list of their reservations.
Add new js files in components to control functionality of my reservation links.
add new actions to my reservations rb.

Hi @AlyAtalla  👋,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


OWLS-91213: Shutdown servers using REST operations prior to deleting pods

When the operator is going to shutdown a pod then it will first connect to the server instance and try to shutdown the server using REST shutdown request prior to deleting the pod.  This is a best effort attempt by the operator to gracefully shutdown the managed server before forcefully deleting the pod. The changes:

Issues a synchronous REST shutdown request to the managed server instance.
Added 'waitForAllSessions' parameter to Shutdown configuration.
Added FINE level logging messages for responses.

Holding off approval until review with @rjeberhard in light of the original goal of this pull. The main goal seems to be preventing K8S from destroying the pod prematurely and, my guess, is thereby abandoning NFS v3 locks because the "NFS lock manager" is destroyed before it can clean up any locks held by destroyed processes that own locks.
Using REST, IMO, doesn't quite address the goal - it just changes the timing.  If the REST call fails to return within X seconds, then the pod is deleted as it was before, which in turn waits up to X before pod destruction.  In effect, we've moved the goal-posts from X to 2X, and CAGBU can thereby get a similar benefit to the current version of this pull simply by doubling their shutdown timeout. This is a rough approximation:  a side benefit of using REST is that it doesn't rely on WLST, which should give us a few extra seconds within X (the cost of spinning up WLST is no longer included in X).
If we are trying to avoid abandoned locks, I think pod delete needs extra logic. For example, shutdown script could start an 'time bomb' script that does a kill -9 of teh NM and WLS at X-5seconds or some-such...  This would give the normal shutdown a chance to finish, but, if it takes to long, would have the affect of removing any left behind locks (the kill -9 kills the process which causes the NFS lock manager to remove any locks it hold).

All of our interactions with Kubernetes are via REST calls (that's what underlies CallBuilder). Why is this different?

The CallBuilder is used for calling the K8s API server. Here, the operator is calling shutdown directly on the managed server using WebLogic Management REST API, similar to reading the managed servers health state.

Still waiting for results from integration tests run on kind cluster:  https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/8138/
Results from previous run had some failures but did not look related as there were issues in test setup/initialization.


Cocoapods running version 96.0

Greetings,
Installing the through cocoapods using simply " pod 'RealmSwift' ", was installing version 0.96.0 which was giving me some trouble with nullable strings, after adding '~> 0.96.2' to specify the version it all worked out fine. Is this an exception or something related to the pod spec?

It might be related to bugfixes, which happened since the release of 0.96.0.

Could you explain what kind of troubles you had with nullable strings?

I was getting the exception "Terminating app due to uncaught exception 'RLMException', reason: 'Only 'object' properties can be made optional, and property 'type' is of type 'string'"

Was that your initial installation of Realm or did you updated to 0.96? If the latter should apply, then the framework might be still cached in your build products directory. Did you cleaned your installation in between?

Closing as it seems likely that this was a CocoaPods cache issue, where Realm Swift was updated but not Realm Objective-C.

Indeed that seems to be the case, as we had updated from the previous version. Thanks for the fast replies.


fix black linter: in case psf/black stable branch was removed from repo

Codecov Report

Merging #307 (2c260d4) into master (6970d18) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   58.61%   58.61%
=======================================
  Files          35       35
  Lines        1829     1829
  Branches      117      117
=======================================
  Hits         1072     1072
  Misses        726      726
  Partials       31       31

Flag
Coverage Δ

unittests
58.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6970d18...2c260d4. Read the comment docs.


Add_Environment-Specific_Actions_for_Deployment_and_Testing

Tasks:
Real-Time Deployment Previews:

Implement actions to automatically create preview URLs for each pull request. This will allow reviewers to test the deployed version of the code without manually setting up the local environment.
Suggested tools: Netlify
Action: Netlify/netlify-action

Multi-Environment Testing:

Set up actions to test the application across different environments, such as multiple versions of Node.js or browsers.
Ensure compatibility for various setups (e.g., Node.js 14, 16, 18) and testing in different environments (e.g., Chrome, Firefox).
Action: actions/setup-node for Node.js versions, actions/setup-chrome for browser testing

Benefits:

Real-time feedback on how the code works in a deployed environment.
Automated testing in multiple environments ensures compatibility and reduces bugs related to environment-specific issues.
Faster review cycles and easier collaboration with non-technical stakeholders through preview deployments.

@Harshdev098

@Harshdev098 i can add this!
But every time a new PR is commited i should update the deploy!
which you can add to the repo discription!
i would be happy to maintain deployment for this repo!!

@Harshdev098 can i get you'r discord?
or some social?
i need to give you the api key!!

https://research-nexas.netlify.app/public

@Harshdev098 reply bro??
i'm helping to really improve you'r repo! But you are not even replying!
i feel bad bro! 😞

I was busy in reviewing the PRs
Just give me time

Will see it don't worry

Have you deployed the whole project?

whats you'r discord?? @Harshdev098

We can connect on LinkedIn

https://linkedin.com/in/smogshashank
once text me on linkedin!

just now update the repo!

i have sent you a connect request!!


app.get('token') doesn't work after a browser refresh.

On the client, I am storing my authentication token to local storage and using websockets on the client to connect.  If I use app.get('token') it works fine until I refresh the browser then it returns undefined.  If I get the jwt token directly with localStorage.getItem() it works fine even after a browser refresh.
Doesn't work:
// doesn't work after you refresh browser
function requireAuth (to, from, next) {
  console.log('via feathers method: '+services.app.get('token'));
  console.log('via localstorage method: '+localStorage.getItem("feathers-jwt"));
if (services.app.get('token') === null) {
    next({
      path: '/login',
      query: { redirect: to.fullPath }
    })
  } else {
    next()
  }
}

Works:
//This works fine after browser refresh
function requireAuth (to, from, next) {
  console.log('via feathers method: '+services.app.get('token'));
  console.log('via localstorage method: '+localStorage.getItem("feathers-jwt"));
  if (localStorage.getItem("feathers-jwt") === null) {
    next({
      path: '/login',
      query: { redirect: to.fullPath }
    })
  } else {
    next()
  }
}

Is this a bug or do I not have a proper understanding of how app.get('token') should work?

token and user will only be set after a successful call to app.authenticate().then() (with no parameters) which will try to authenticate the token currently in localStorage.

Ok I understand that you can't really know if a token is valid or not until you run app.authenticate().then() but once I have a token (stored to local storage) supplied by app.authenticate().then() if I try to use app.get('token') it works fine until I hit refresh on the browser, then it becomes undefined however I still have a valid token in local storage.
I would think app.get('token') should still return a token even after refreshing a browser provided the token still exists in local storage.

@delay, this is already fixed in the 0.8.0 version, which is in beta.  It's still a bit rough around the edges, so I recommend steering clear of it unless you have some time to help debug.

Ahh ok...  glad you already got it fixed for the next version.


Alerts: Callback is getting delayed for event capabilityAgents::alerts::AlertObserverInterface::State::STOPPED

Hello AVS Team,
I have implemented the callback for Alerts in UIManager.cpp.
void UIManager::onAlertStateChange(const std::string& alertToken, capabilityAgents::alerts::AlertObserverInterface::State state, const std::string& reason);
For the event capabilityAgents::alerts::AlertObserverInterface::State::STOPPED
When I say "Alexa Stop", the timer sound stops immediately but I am getting this callback delayed for 8 to 10 seconds
Can you please let me know the reason of getting this callback delayed ?
I have also debugged the avs-device-sdk code where it also delayed.
avs-device-sdk version - 1.9
Platform - Ubuntu

@sumit3817, thanks for opening this issue.  Would you be able to attach the DEBUG9 logs for this issue so that we can investigate further the reasons for the delay.  Thanks!

Hi,
I have tested in 1.12.1 and found fixed.
You can close this issue.
Thanks for the support


Response and Request classes are missing the clone() method

Both classes are based on the WHATWG specs as written at the top of their reference pages (Request - Response) but they are lacking the clone() method.
Would it be possible to add it or is it done on purpose ?
Thanks ! :)

Thank you for filing this—that would indeed be possible, yes. There are
some more urgent things to work through right now (including breaking
changes to get out of the way, such as #8), but we should be able to get to
this before too long.

Hi, any updates on this?

@bjrn yes, we do have a meaningful update to share: while Request/Response clone didn't make the cut for the new release, we now have the foundations in place to properly implement them. #64 contains significant changes to how Request/Response bodies are handled, after which clone is fairly straightforward to implement (and before which it was close to impossible to do so in a spec-compliant way.)
We'll have another release out in a few weeks containing clone and a few other nice additions.

That's really good news, thanks for getting back!

As of 5debe806a4a40e0d3b07bdd6b71489aa7d739cff, Request#clone should be working properly.


Updated to support the jekyll 3 upgrade

As announced by Github, as of 1st of May Jekyll 3 will be the engine being
used, instead of Jekyll 2. There are some small changes, for end users, but
it's not affecting too much to us:

I've set the github-pages gem version to be sure about the changes.
I've explicitely set some of the options that will be the default ones on
github pages, like the markdown renderer and highlighter.
They have changed from pygments to Rouge. This means that backticks are now
available to mark highlighted regions.
I had to update the solarized theme, so it didn't overlap with the proper
background color. For some reason this didn't happen before.

Signe-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

LGTM


release 20.2.0

Release Notes

fix: re-introduce retry loop (#772)
fix: update indexer-selection

fix: zero_allocation penalty on multiple indexers (https://github.com/edgeandnode/candidate-selection/commit/cf5d1790ecb7784f7adec51477c7a3033fb99989)
increase zero allocation penalty multiplier to 0.9 (https://github.com/edgeandnode/candidate-selection/commit/4c4e08f95a9fe31fda037ca68125418d249f8e62)
add floor to latency score (https://github.com/edgeandnode/candidate-selection/commit/373e70269ff38d78ade629bb35ea45199f2f1b45)

feat: add indexer label to indexer_query metrics (#775)
remove SQL constraints (#768)
remove subscriptions contract auth (#782)

notes:

remove unused items from configs


Visualizing saved reconstruction.

Hi. Thank you for the amazing work.
I am running the code on remote server in  --disable_vis mode. I have the saved reconstruction results in .npy format. I am not sure how to reconstruct the scene in Open3d using these .npy files.
Before that I was using visualization mode and directly saving .ply files and I was able to visualize them in open3d. But I don't want to do that anymore and want to use the default .npy files.
Thank you~

Can we please get some guide on this?

I do not know how famailer you are with Open3D, but you can use RGBD interation to construct .ply files from data produced in .npy files.
You can check this for more info.

@bkhanal-11 Hi. I wrote the following code.
import glob
import open3d as o3d
import numpy as np
import matplotlib.pyplot as plt

class CameraPose:
    def __init__(self, meta, mat):
        self.metadata = meta
        self.pose = mat

    def __str__(self):
        return (
            "Metadata : "
            + " ".join(map(str, self.metadata))
            + "\n"
            + "Pose : "
            + "\n"
            + np.array_str(self.pose)
        )

def read_trajectory(filename):
    traj = []
    with open(filename, "r", encoding="utf-8") as f:
        metastr = f.readline()
        while metastr:
            metadata = list(map(int, metastr.split()))
            mat = np.zeros(shape=(4, 4))
            for i in range(4):
                matstr = f.readline()
                mat[i, :] = np.fromstring(matstr, dtype=float, sep=" \t")
            traj.append(CameraPose(metadata, mat))
            metastr = f.readline()
    return traj

volume = o3d.pipelines.integration.ScalableTSDFVolume(
    voxel_length=4.0 / 512.0,
    sdf_trunc=0.04,
    color_type=o3d.pipelines.integration.TSDFVolumeColorType.RGB8,
)

intrinsics = np.load("./results/intrinsics.npy")

fx = intrinsics[0][0]
fy = intrinsics[0][1]
cx = intrinsics[0][2]
cy = intrinsics[0][3]

color_images = np.load("./results/images.npy")
depth_images = np.load("./results/disps.npy")
camera_poses = read_trajectory("./results/log.txt")
camera_intrinsic = o3d.camera.PinholeCameraIntrinsic(
    width=576, height=336, fx=fx, fy=fy, cx=cx, cy=cy
)

for i in range(len(color_images)):
    print(f"Integrate {i}-th image into the volume.")
    color = color_images[i]
    color = np.ascontiguousarray(color.transpose(1, 2, 0))
    color = o3d.geometry.Image((color).astype(np.uint8))
    depth = depth_images[i]
    depth = np.ascontiguousarray(depth.transpose(0, 1))
    depth = o3d.geometry.Image((depth * 255))
    rgbd = o3d.geometry.RGBDImage.create_from_color_and_depth(
        color, depth, depth_trunc=4.0, convert_rgb_to_intensity=False
    )

    volume.integrate(rgbd, camera_intrinsic, np.linalg.inv(camera_poses[i].pose))

print("Extract a triangle mesh from the volume and visualize it.")
mesh = volume.extract_triangle_mesh()
mesh.compute_vertex_normals()
o3d.visualization.draw_geometries([mesh])

However, the resulting map is not correct. I am missing something but not sure what it is. Here is the result.

@bkhanal-11 This is how my log.txt looks like.
0 0 1
-1.0 0.0 0.0 0.0
0.0 -1.0 0.0 0.0
0.0 0.0 1.0 0.0
0.0 0.0 0.0 1.0
1 1 2
-0.9988476022589705 -0.02794569745350285 0.039019295936009724 -0.017698440700769424
0.02813569752382185 -0.9995947404348644 0.004328674139191881 -0.010660745203495026
0.03888251517523815 0.005421520892940287 0.9992290814046871 -0.010660745203495026
0.0 0.0 0.0 1.0
2 2 3
-0.9921915766540266 -0.07212852491360724 0.10175141822394249 -0.15529966354370117
0.0741547246722205 -0.9971140443786379 0.016268353071603008 -0.02430793270468712
0.10028435583670908 0.02368667128708258 0.9946768267018962 -0.02430793270468712
0.0 0.0 0.0 1.0
3 3 4
-0.9858344461233062 -0.09958461872798406 0.1349568395804975 -0.229265496134758
0.10741816380243378 -0.9928507594990048 0.05204524423578825 -0.11546353995800018
0.1288090948732565 0.06580481042485715 0.9894836754605307 -0.11546353995800018
0.0 0.0 0.0 1.0
4 4 5
-0.9800208043395229 -0.11316477936030064 0.16356330815329656 -0.30861613154411316
0.12554535795960764 -0.9897944798567042 0.06741847476761405 -0.17945930361747742
0.1542646626953489 0.08660612194026414 0.9842264950131948 -0.17945930361747742
0.0 0.0 0.0 1.0

@pytholic Hi, I also tried to write script for visualization and end up with similar result as yours. It may be due to either intrinsic or disparity (depth). I am also stuck on same problem now.

@pytholic Did you ever figure out why this was happening?

@kelvinyankey6 My workaround was to save points and poses in .ply file on the fly.
https://github.com/pytholic/ml_cv_scripts_guides/blob/main/droid_slam/vis_headless.py

Ah @pytholic I did the same to save the points. My environment doesn't have access to an x server. But I didn't know I could do the same for the camera poses. This is really helpful. Thank you very much for getting back to me

@kelvinyankey6 My workaround was to save points and poses in .ply file on the fly. https://github.com/pytholic/ml_cv_scripts_guides/blob/main/droid_slam/vis_headless.py

Hello, thanks for your code! I can't save the '.ply' in that way. Because I running this on a remote server, this means it won't go into 'droid_visualization' function.
I had a similar problem when I used open3d to visualize the saved reconstruction in sfm_bench dataset.

My approach is to use pose, intrinsics and depth to directly recover the 3D coordinates of the point.
def visual(disp, K, T, image):

    depth = 1.0 / disp.squeeze()    # h, w
    height, width = depth.shape
    img = cv2.resize(cv2.cvtColor(image, cv2.COLOR_BGR2RGB), dsize=(width, height), interpolation=cv2.INTER_LINEAR)
    fx, fy, cx, cy = K
    intrinsics_matrix = np.array([[fx, 0, cx],
                                  [0, fy, cy],
                                  [0, 0, 1]])
    intrinsics_matrix_homo = np.zeros((3, 4), dtype=np.float32)
    intrinsics_matrix_homo[:3, :3] = intrinsics_matrix
    intrinsics_matrix_homo[2,3] = 1

    pose = pose_quaternion_to_matrix(T)

    points = []
    rgbs = []
    for v in range(height):
        for u in range(width):
            d = depth[v, u]

            if d==0: continue

            x_cam = (u - cx) / fx * d
            y_cam = (v - cy) / fy * d
            z_cam = d
            points.append([x_cam, y_cam, z_cam])
            rgbs.append(img[v, u, :])

    rgbs = np.array(rgbs)
    points = np.array(points)
    ones = np.ones((points.shape[0], 1))
    points = np.hstack((points, ones))  # homo

    pc_world = (pose @ points.T).T

    return points, pc_world, intrinsics_matrix_homo, pose, rgbs

  points, pc_world, intrinsics_matrix_homo, pose, rgbs = visual(disp, K, T, image)
  pcd = o3d.geometry.PointCloud()
  pcd.points = o3d.utility.Vector3dVector(pc_world[:, 3])
  pcd.colors = o3d.utility.Vector3dVector(rgbs / 255.0)
  o3d.visualization.draw_geometries([pcd])

@kelvinyankey6 My workaround was to save points and poses in .ply file on the fly. https://github.com/pytholic/ml_cv_scripts_guides/blob/main/droid_slam/vis_headless.py

Hello, thanks for your code! I can't save the '.ply' in that way. Because I running this on a remote server, this means it won't go into 'droid_visualization' function.
I had a similar problem when I used open3d to visualize the saved reconstruction in sfm_bench dataset.

My approach is to use pose, intrinsics and depth to directly recover the 3D coordinates of the point.

def visual(disp, K, T, image):

    depth = 1.0 / disp.squeeze()    # h, w

    height, width = depth.shape

    img = cv2.resize(cv2.cvtColor(image, cv2.COLOR_BGR2RGB), dsize=(width, height), interpolation=cv2.INTER_LINEAR)

    fx, fy, cx, cy = K

    intrinsics_matrix = np.array([[fx, 0, cx],

                                  [0, fy, cy],

                                  [0, 0, 1]])

    intrinsics_matrix_homo = np.zeros((3, 4), dtype=np.float32)

    intrinsics_matrix_homo[:3, :3] = intrinsics_matrix

    intrinsics_matrix_homo[2,3] = 1

    pose = pose_quaternion_to_matrix(T)

    points = []

    rgbs = []

    for v in range(height):

        for u in range(width):

            d = depth[v, u]

            if d==0: continue

            x_cam = (u - cx) / fx * d

            y_cam = (v - cy) / fy * d

            z_cam = d

            points.append([x_cam, y_cam, z_cam])

            rgbs.append(img[v, u, :])

    rgbs = np.array(rgbs)

    points = np.array(points)

    ones = np.ones((points.shape[0], 1))

    points = np.hstack((points, ones))  # homo

    pc_world = (pose @ points.T).T

    return points, pc_world, intrinsics_matrix_homo, pose, rgbs

  points, pc_world, intrinsics_matrix_homo, pose, rgbs = visual(disp, K, T, image)

  pcd = o3d.geometry.PointCloud()

  pcd.points = o3d.utility.Vector3dVector(pc_world[:, 3])

  pcd.colors = o3d.utility.Vector3dVector(rgbs / 255.0)

  o3d.visualization.draw_geometries([pcd])

Use open3d headless rendering and it works.

@kelvinyankey6 cool!
@NOTGOOOOD please try it with headless rendering, will work hopefully!

@kelvinyankey6 cool! @NOTGOOOOD please try it with headless rendering, will work hopefully!

Hi thanks for sharing your vis_headless.py code, I can do visualization on my device so I would like to ask how to use your code? like shall I download ml_cv_scripts_guides/droid_slam/ folder and place the files under the original DROIDSLAM project under and then just run python demo.py --imagedir= data/exampledata --calib=calib/exampledata.txt --reconstruction_path=exampledata?
Or is there any other special step to use your vis_headless.py to get ply?

@kelvinyankey6 cool! @NOTGOOOOD please try it with headless rendering, will work hopefully!

Thank you so much for sharing your code, I was able to get the point cloud ply file I want.
For those may have same question with me: I used https://github.com/pytholic/ml_cv_scripts_guides/blob/main/droid_slam/demo.py to replace the original Droidslam demo.py and vis_ to replace the original code visuallization.py. and changed line 38 in droid.py to set the save path:             self.visualizer = Process(target=droid_visualization, args=(self.video,"mysaveplypath")).

HI, thanks for your work and explanations. I'm running the code in a docker container and the headless script is not working there, I get the error:
Traceback (most recent call last):
File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/DROID-SLAM/vis_headless.py", line 175, in droid_visualization
vis.get_render_option().load_from_json("misc/renderoption.json")
AttributeError: 'NoneType' object has no attribute 'load_from_json'
So it seems it cannot create the open3d visualizer. Is th code supposed to able to run in docker or am I missing something?
Thanks

@Zunhammer Not sure. I think I have used it with docker in the past but that was my custom docker.
Here is my docker for Droid Slam:
https://github.com/princeton-vl/DROID-SLAM/pull/98
You can check this:
http://www.open3d.org/docs/0.16.0/docker.html

@pytholic @Zunhammer , Hi, i am also using the docker provided by @pytholic and trying to generate ply files from the docker container. However, I am having the same problem as @Zunhammer. Is there anyway to solve this problem?

First, thanks to @pytholic for the response and the hints. I tried with my own docker but had no luck, didn't have time to test the one from pytholic yet. I'll probably do this after christmas. So in short, I don't have a solution yet.

@Zunhammer , I solved this issue already so may be it would be helpful to you too. @pytholic's Dockerfile works great. But to use it in a headless environment and still to be able to save ply files, you also need to use open3d headless. After building the Docker image with @pytholic's Dockerfile, remove the open3d from the container and recompile the open3d headless and install it as described - http://www.open3d.org/docs/latest/tutorial/Advanced/headless_rendering.html. And use https://github.com/princeton-vl/DROID-SLAM/issues/75#issuecomment-1788157019 this method and it worked out well.

As mentioned by @HtutLynn , if you are using my headless script, you need to install open3D-headless in your container. I did it because I was working on a remote server without any visualization.
If you want to use it without a headless, then you might have to pick some parts from my script (parts that save .ply files) and add them to the original script. Also, in that case, you should use normal open3d, and you might also have to use X11 forwarding for the container.

@pytholic I am trying to use your implementation of visualization code, but the demo.py does not generate any log.txt camera trajectory for pose.  Do you know how to get the log.txt ?

@jmunshi1990 Hi. It has been a long time since I used this. I don't remember how I was saving the final point cloud but maybe you can take a look at this part from the official demo for camera pose.
https://github.com/pytholic/DROID-SLAM/blob/f68a25fa230730e3eaaaa6ab03a818ca5da6954f/demo.py#L59

@pytholic I am using the highlighted part of the demo script to generate the reconstructions, but the only problem is that I am not able to generate the log txt file which has the trajectory needed to reproduce your below code which you have posted earlier. I am trying to find the read_trajectory input file out of the saved files which I am not getting. Any suggestion how to do that?
import glob
import open3d as o3d
import numpy as np
import matplotlib.pyplot as plt

class CameraPose:
    def __init__(self, meta, mat):
        self.metadata = meta
        self.pose = mat

    def __str__(self):
        return (
            "Metadata : "
            + " ".join(map(str, self.metadata))
            + "\n"
            + "Pose : "
            + "\n"
            + np.array_str(self.pose)
        )

def read_trajectory(filename):
    traj = []
    with open(filename, "r", encoding="utf-8") as f:
        metastr = f.readline()
        while metastr:
            metadata = list(map(int, metastr.split()))
            mat = np.zeros(shape=(4, 4))
            for i in range(4):
                matstr = f.readline()
                mat[i, :] = np.fromstring(matstr, dtype=float, sep=" \t")
            traj.append(CameraPose(metadata, mat))
            metastr = f.readline()
    return traj

volume = o3d.pipelines.integration.ScalableTSDFVolume(
    voxel_length=4.0 / 512.0,
    sdf_trunc=0.04,
    color_type=o3d.pipelines.integration.TSDFVolumeColorType.RGB8,
)

intrinsics = np.load("./results/intrinsics.npy")

fx = intrinsics[0][0]
fy = intrinsics[0][1]
cx = intrinsics[0][2]
cy = intrinsics[0][3]

color_images = np.load("./results/images.npy")
depth_images = np.load("./results/disps.npy")
camera_poses = read_trajectory("./results/log.txt")
camera_intrinsic = o3d.camera.PinholeCameraIntrinsic(
    width=576, height=336, fx=fx, fy=fy, cx=cx, cy=cy
)

for i in range(len(color_images)):
    print(f"Integrate {i}-th image into the volume.")
    color = color_images[i]
    color = np.ascontiguousarray(color.transpose(1, 2, 0))
    color = o3d.geometry.Image((color).astype(np.uint8))
    depth = depth_images[i]
    depth = np.ascontiguousarray(depth.transpose(0, 1))
    depth = o3d.geometry.Image((depth * 255))
    rgbd = o3d.geometry.RGBDImage.create_from_color_and_depth(
        color, depth, depth_trunc=4.0, convert_rgb_to_intensity=False
    )

    volume.integrate(rgbd, camera_intrinsic, np.linalg.inv(camera_poses[i].pose))

print("Extract a triangle mesh from the volume and visualize it.")
mesh = volume.extract_triangle_mesh()
mesh.compute_vertex_normals()
o3d.visualization.draw_geometries([mesh])

Here is the function I use to output point clouds and camera poses. You can add it to the top of demo.py and append the line generate_and_save_point_cloud_and_camera(droid.video, args.reconstruction_path) at the end. Doing so will likely make you feel happy.
`import os
import torch
import numpy as np
import open3d as o3d
import json
from pathlib import Path
from droid_backends import iproj, depth_filter
from droid_core import SE3
def generate_and_save_point_cloud_and_camera(video, save_directory):
"""
Generates and saves point cloud and camera data based on input video frames.
Args:
    video: Video object containing frame data, poses, disparities, and intrinsics.
    save_directory: Path to save the generated point cloud and camera data.
    device: Device to use for computation, default is 'cuda:0'.
"""
# Create the save directory if it doesn't exist
save_dir = Path(save_directory)
save_dir.mkdir(parents=True, exist_ok=True)

# Set the device for CUDA computations
torch.cuda.set_device(0)

# Dictionary to store camera poses indexed by frame ID
camera_poses = {}

# Disable gradient computation for performance
with torch.no_grad():
    # Lock video data and fetch the current frame index
    with video.get_lock():
        t = video.counter.value
        dirty_index, = torch.where(video.dirty.clone())  # Frames flagged for processing

    # If no new frames to process, exit the function
    if len(dirty_index) == 0:
        return

    # Get the list of frame numbers used so far
    used_frame_number_list = video.tstamp[:t].cpu().numpy()

    # Mark the processed frames as clean
    video.dirty[dirty_index] = False

    # Fetch the camera poses and disparities for dirty frames
    poses = torch.index_select(video.poses, 0, dirty_index)
    disps = torch.index_select(video.disps, 0, dirty_index)

    # Compute inverse poses and convert to 4x4 matrices
    Ps = SE3(poses).inv().matrix().cpu().numpy()

    # Downsample images and reorder channels from BGR to RGB
    images = torch.index_select(video.images, 0, dirty_index)
    images = images.cpu()[:, [2, 1, 0], 3::8, 3::8].permute(0, 2, 3, 1) / 255.0

    # Project 3D points from disparity maps
    points = iproj(SE3(poses).inv().data, disps, video.intrinsics[0]).cpu()

    # Define a threshold for depth filtering
    thresh = 0.3 * torch.ones_like(disps.mean(dim=[1, 2]))
    count = depth_filter(video.poses, video.disps, video.intrinsics[0], dirty_index, thresh)
    count = count.cpu()

    # Convert disparities to CPU for further processing
    disps = disps.cpu()

    # Create masks to filter valid points
    masks = (
        (count >= 2)  # At least two valid observations
        & (disps > 0.5 * disps.mean(dim=[1, 2], keepdim=True))  # Significant disparity
    )

    # Initialize containers for points and colors
    all_points = []
    all_colors = []

    # Process each dirty frame
    for i, idx in enumerate(dirty_index):
        mask = masks[i].reshape(-1)
        pts = points[i].reshape(-1, 3)[mask].cpu().numpy()  # Valid 3D points
        clr = images[i].reshape(-1, 3)[mask].cpu().numpy()  # Corresponding colors

        all_points.append(pts)
        all_colors.append(clr)

        # Map frame ID to camera pose
        camera_id = int(used_frame_number_list[idx.item()])
        camera_poses[camera_id] = Ps[i].tolist()

    # Concatenate all points and colors
    all_points = np.concatenate(all_points, axis=0)
    all_colors = np.concatenate(all_colors, axis=0)

    # Save point cloud as a PLY file
    pcd_points = o3d.geometry.PointCloud()
    pcd_points.points = o3d.utility.Vector3dVector(all_points)
    pcd_points.colors = o3d.utility.Vector3dVector(all_colors)
    o3d.io.write_point_cloud(str(save_dir / "points.ply"), pcd_points, write_ascii=False)

    # Save camera poses as a JSON file
    with open(save_dir / "camera_poses.json", "w") as json_file:
        json.dump(camera_poses, json_file, indent=4)

`


Conflicts not Appearing

Issue Type: Bug
Hi,
I'm running posh-git in addition to visual studio code.
When i do git merge  I get the following
"Automatic merge failed; fix conflicts and then commit the result."
That's okay. And in the source control panel, i get one conflict under "Merge changes".

However when I open the file, no conflicts appear. I have the code lens setting turned on. In addition if i try to do "Merge Conflict: Next Conflict", I get the error "No merge conflicts found in this file". When clearly there is a conflict showing in the merge changes window.
If i open the folder in Visual Studio 2019, it has no problems finding the merge conflict. This has now happened on different VSCode editions and on different machines. The one I have trouble with now is a newly provisioned VM.
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:35:15.005Z)
OS version: Windows_NT x64 6.3.9600

System Info

Item
Value

CPUs
Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz (4 x 2594)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
16.00GB (7.28GB free)

Process Argv

Screen Reader
no

VM
100%

Extensions (3)

Extension
Author (truncated)
Version

gitlens
eam
10.0.1

vscode-guid
hea
1.4.18

powershell
ms-
2019.9.0

(1 theme extensions excluded)

What's the text of the merge conflict? Maybe you have a variation we don't match yet.


Example on How to use this Plugin to Obtain a Refresh Token

I ran across this plugin when trying to set up DRF JWT to have a long lasting refresh token and short lived access tokens.
The documentation is clear on the setup and usage of this plugin. But it is not clear on how to use this plugin to obtain/create a refresh token.
Can anyone help me understand how I'm supposed to use this plugin to obtain/create a refresh token?
Thanks!

Hi @sethwhite2,
Sorry for the late reply I was away.
To answer your question there is no one  obvious way to create the refresh token, it is entirely up to you you and your business logic.
To give you an example it is simple as this.
user.refresh_tokens.create(app=name_of_your_app)

Where you call it ? is up to you.

Should this be added to the documentation then?
@sethwhite2
Do you feel like creating a PR for it?

@blueyed sure. I'll create a PR for this.


Possible flaw in the model

These days, most publishers add a note to each PDF file upon downloading. For example,
Downloaded by [University of X] at 12:17 01 January 2021
This content downloaded from IP on Thu, 05 Mar 2021 21:52:22 UTC

These texts are normally printed vertically on every page.
On many occasions, I noticed GROBID add these texts within the contents. So much the worse, these are usually included within the sentences extracted by GROBID.
This is a matter of training of the model to clarify these are not intended contents. I believe paying particular attention to this matter can improve the model of the next version of GROBID.

Hello @keto33 !
Yes these annotations are actually pretty old practices... this is indeed a matter of training, training data of the segmentation model, but it has always been a problem of IP: these articles have these annotations because they are under strict copyrights and cannot be redistributed, so I cannot add them in the training data of Grobid.
Maybe one way to capture this would be to "mimic" these annotations on Open Access papers and then add them in the training data.

Since these annotations are dynamically added to the PDF files upon downloading, the correct way of using them in the training data is the way you mentioned (rather than using the copyrighted materials directly).
I believe the model will be quickly trained to recognise them because of their simple patterns:

They appear on every page (like page footer and header). In fact, I wonder why doesn't GROBID recognise them as a header/footer element like the journal title appearing on every page.
They are placed far from the main content (whether vertically on the left, at the bottom of the page).
They always have the format of DOWNLOADED by/from IP/INSTITUTION on/at TIME.

I believe we can use a PDF manipulation tool to add annotations to some of the PDFs already used in the training dataset.
These are simple objects, which are inserted into the PDF files without altering the rest of the document. For example,
1 0 obj
<<
/Subtype /Form
/Type /XObject
/Matrix [1 0 0 1 0 0]
/FormType 1
/Resources
<<
/ProcSet [/PDF /Text /ImageB /ImageC /ImageI]
/Font
<<
/F1 2 0 R
>>
>>
/BBox [0 0 393.84 632.16]
/Length 123
>>
stream
BT
/F1 10 Tf
0 1 -1 0 10 179.15 Tm
(Downloaded by [University of X] at 12:17 01 January 2021 )Tj
1 0 0 1 0 0 Tm
ET

endstream
endobj


Playground: Add keyboard shortcut to run playground code

CTRL/CMD + Enter will run the current code in the playground editor.

Thank you! :heart:


Feature/multiple selection

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


scriv: 1.4.0 -> 1.5.0

Description of changes
https://github.com/nedbat/scriv/releases/tag/1.5.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2935

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3064

Result of nixpkgs-review pr 266502 run on x86_64-linux 1

2 packages built:

scriv
scriv.dist


[Blog] You want better OpenSearch documentation?

Description
A blog with a recap of Eric and Charlie's presentation at OpenSearch EU for the unconference.
Issues Resolved
Closes https://github.com/opensearch-project/project-website/issues/2854
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Closed in favor of https://github.com/opensearch-project/project-website/pull/2911


aggregate_item_by_item does not handle as_index=False in GroupBy

This turned out to be a red herring related to the bug brought up by in PR #313


Update README

https://github.com/manufac-analytics/reactjs-calendar-heatmap#properties section should be updated after studying the props interface in type definition file

Closed via #16


Fix/146- history home page

Describe the bug
The information of history it is not complete
Expected behavior
The info of their web page should be include and it is not
Screenshots
Not applicable
Additional context
user their actual webpage to see the information to include

Story Points: 2
See the discussion in Frontend S3
Powered by Parabol


Use new session when querying db from separate process

When querying the db from a subprocess of the api a separate session must be used. This PR adds code to create this session in the function to revalidate all tags

Thanks @sweng66 !


[NETBEANS-54] Module Review c.googlecode.javaewah.JavaEWAH

external library JavaEWAH-0.7.9.jar: Maven coordinates added.
checked Rat report: everything has been relicensed to Apache, included in 'central problems' list above, or excluded via Rat
skimmed through the module, did not notice additional problems

Looks good.


Tool icons on the top-right

Description of new feature

[x] Two icons should always be visible: shift/box select and download.  The rest can just go in the hamburger menu all the time.
[ ] New list of icons / tools in the hamburger:

[x] Undo
[x] Delete -- removed (also see #262)
[x] Restore
[x] Zoom in
[x] Zoom out
[x] Fit
[x] Shift-Select (see #265)
[x] Download -- moved outside
[ ] Share by email: Open email dialog (related to #261)

[x] Download icon should be a line with an arrow
[x] Same icon for download gene list
[x] It needs to be clear in the tooltip for the main download what you get: Download
[x] The one download option downloads everything -- the enrichment files and the images in one ZIP

Motivation for new feature

There are a lot of icons, and it's difficult to find the important ones, like download.

This is how the toolbar looks now when shift-select and download are visible but the other ones are in the overflow menu:

(*) Notice that I'm suggesting we use the more standard vertical ellipsis icon in this scenario, instead of the hamburger one, which is more associated with a mobile device's menu and usually contains all the other menu/toolbar options. I just find that the hamburger icon would not stand out as much here.

This is how it look on small screens (mobile):

(*) I suggest we hide all the toolbar icons in this scenario--the screen is just too small--and that we use the hamburger icon.

The mobile/overflow menu now renders toggleable items properly:


Add API endpoint to query storage limits

mclo.gs truncates logs to a configurable size, but does not currently have a simple way of querying those limits.
Adding an API endpoint to retrieve storage limits (maxLines, maxLength, maybe storageTime) would allow applications to do some pre-processing on their end, such as truncating in a way that keeps lines near the end or simply pre-truncating logs to save bandwidth.

Thanks for the suggestion, the endpoint is now available here: https://api.mclo.gs/1/limits


Setting SMS Destination Parameters

Hi,
I'm attempting to use your library to send SMS messages using the "Request with custom Key-Value replacements in message per destination" feature as defined here: https://www.fortytwo.com/apis/sms-gateway-rest-api/samples/#CustomKeyValueReplacements.
I'm a bit puzzled how to set the key=>value parameters using the library, as looking at the code it's expecting the parameters to be of type string.
$destination->setParams($parameters);
Am I missing something, or is this a bug in the library?
I'll dynamically replace the message content per SMS destination on my end as a workaround, but would be awesome to be able to use this feature.

Hi,
It's definitely a bug. I'm working on it and and push an update later today.
Regards,
Sebastien.

I just published a new Release Candidate (RC5). You can pass parameters as a key/value array now.

Thanks Sebastien—Changes look good and it's now working great with parameters set as an array. Great library btw, looks really well written 😄.


Show Immersive Engineering Multiblock Machines Info

I don't know if this is something IE should implement or you can do it from TOP.
IE multiblock machines don't display fluid information at all, unlike EnderIO machines that do:
Fine:

No fluid info:

Also, pickaxe can be used on IE multiblocks.
Minecraft 1.10.2
theoneprobe-1.1x-1.4.6
ImmersiveEngineering-0.10-57

That's on IE's side to implement


XPath attribute filter results in TypeError

Describe the bug
Attempting to extract an attribute through XPath, e.g. the href url from a link on a webpage, causes a TypeError failure on check.
Version
v<IP_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

Create new Watch entry
Add XPath attribute filter (e.g. //a/@href)
Save
Observe TypeError: q.getBoundingClientRect is not a function at eval on check.

Example share-link: https://changedetection.io/share/8FUjB4_WiEQa
Expected behavior
XPath filter successfully finds and extracts attribute from given path, if it exists.
Screenshots

Desktop:

OS: Windows
Browser: Firefox
Version: 107.0.1

Server:

OS: Linux/Docker
Image: dgtlmoon/changedetection.io

Please try our docker image :dev when https://github.com/dgtlmoon/changedetection.io/actions/runs/3697507946 is finished

Please try our docker image :dev when https://github.com/dgtlmoon/changedetection.io/actions/runs/3697507946 is finished

I can confirm that this new dev image works!


Are custom font installs in scope?

I am not sure if the custom font installs are in scope bc they do not provide any security functionality

Just to be clear, this project is based on ublue, which itself doesn't add security functionality on top of regular silverblue and kinoite images. So already we are pulling in ublue addons for usability improvements via packages (codecs, ffmpeg, nvidia drivers) that can't otherwise be included in the regular silverblue and kinoite images for legal reasons. Do these packages improve security? Nope. Do they degrade security? Nope. Do they dramatically improve usability? Yep. The only difference with the fonts is that they're provided via ublue's bling instead of being baked into the images.
So as a general rule, as long as something isn't causing a security degradation, it's not necessarily excluded from this repo.
However, in this case I think the fonts can be removed because they are simply too opinionated, not because of their lack of security value. Feel free to remove them.


Slider doc says direction prop has a default parameter

Please see: https://material-ui.com/api/slide/
The docs say the direction prop has a default value of "down", but if you omit it from real code, the type information will complain saying you didn't specify the direction prop.
Either the doc or the type info is wrong.

[ x] The issue is present in the latest release.
[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Your Environment 🌎

Tech
Version

Material-UI
v4.9.5

React

Browser

TypeScript

etc.

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Looking at the source, it seems about right
https://github.com/mui-org/material-ui/blob/7102777b6d248e9b23740a629781726f725019c7/packages/material-ui/src/Slide/Slide.d.ts#L6
Do you want to take care of the problem? :)

@wmitsuda I believe the fix would look like this:
diff --git a/packages/material-ui/src/Slide/Slide.d.ts b/packages/material-ui/src/Slide/Slide.d.ts
index 77efeeb8d..6132d95e1 100644
--- a/packages/material-ui/src/Slide/Slide.d.ts
+++ b/packages/material-ui/src/Slide/Slide.d.ts
@@ -3,7 +3,7 @@ import { Theme } from '../styles/createMuiTheme';
 import { TransitionProps } from '../transitions/transition';

 export interface SlideProps extends TransitionProps {
-  direction: 'left' | 'right' | 'up' | 'down';
+  direction?: 'left' | 'right' | 'up' | 'down';
   ref?: React.Ref<unknown>;
   theme?: Theme;
 }

@oliviertassinari were you able to reproduce this problem? I'm willing to take care of that, but I have not been able to reproduce it.

I haven't tried to reproduce it. I have only looked at the source that looked wrong.

:thinking: @wmitsuda could you provide more details?

@belgamo if you go to this slide example at Material-UI doc and remove
direction="up", Typescript will throw an error. look here at codesandbox
What @oliviertassinari said solves the problem.

@wmitsuda I believe the fix would look like this:

@olegberman I can create a PR for this issue

PR for the issue:
https://github.com/mui-org/material-ui/pull/20338


toxvpn: use default libtoxcore

Builds and works fine with it.

Success on x86_64-linux (full log)
Attempted: toxvpn
Partial log (click to expand)
-h              print this help
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17
shrinking /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17/bin/toxvpn
shrinking /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17/bin/toxvpn-remote
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17/bin
patching script interpreter paths in /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17
checking for references to /build in /nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17...
/nix/store/mmx6w6yr10qxvzd732fac3nrryyy7mis-toxvpn-2018-04-17

Success on aarch64-linux (full log)
Attempted: toxvpn
Partial log (click to expand)
-h              print this help
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17
shrinking /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17/bin/toxvpn-remote
shrinking /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17/bin/toxvpn
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17/bin
patching script interpreter paths in /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17
checking for references to /build in /nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17...
/nix/store/x5a3mazqk58yxvyg6a6j0rira6g2lih8-toxvpn-2018-04-17