Remove dependency injection functions

How to categorize this PR?

/area open-source dev-productivity
/kind enhancement
What this PR does / why we need it:
The package controller-runtime/pkg/runtime/inject  has been removed in controller-runtime v0.15. This package contained long deprecated injection functions (like InjectScheme, InjectLogger, InjectConfig, InjectClient, InjectCache, etc.).
The runtime injection functionality has been deprecated since Controller Runtime 0.10; all of the above fields can be passed from the Manager to structs or interfaces that need them.
https://github.com/kubernetes-sigs/controller-runtime/pull/2134
https://github.com/kubernetes-sigs/controller-runtime/pull/2120
Which issue(s) this PR fixes:
Part of #7991
Special notes for your reviewer:
Release note:

The package sigs.k8s.io/controller-runtime/pkg/runtime/inject is removed. Injection functions (like InjectScheme, InjectLogger, InjectConfig, InjectClient, InjectCache etc are now passed from the Manager.

All extensions needs to be adapted.

/test all

/retest

/assign


Make it easier to dynamically load snapshot data

We should be able to let users more easily dynamically load vm_snapshot_data and isolate_snapshot_data to avoid including it in the base distribution.  This can reduce base distribution size, but would also require the user to host their own infra to supply it.  We would also have to come up with some idea about when to do this and how much it impacts startup latency.

There's already the --aot-shared-library-name which can be passed to the embedder. Just set vm_snapshot_data and isolate_snapshot_data to NULL in FlutterProjectArgs.

This bug is also to explore making that easier for people using the Flutter tool to package these things up.  I should probably tag it for tool as well.

Going off flutter-rs user reports, there might be problems with this approach on macos/windows and I assume if it doesn't work on macos it won't work on ios, but I haven't looked into it.

did you are able to solve this issue?


LoopDetectors should be able to present themselves as a Table

LoopDetectors can produce output files, and it makes sense to also use the Table features from DJUTILS for this. Detectors can present two types of tables:

Periodic data: detector id, time, flow, {additional measurements...}
Mesoscopic data: detector id, measurement id, measurement data

Value 'measurement data' can be a huge string as it covers the whole of the simulation. Because this depends on the measurement type, no further formatting or sub-columns can be derived. Examples of this data are:

Vehicle passage times
Platoon sizes

Note that these tables represent all LoopDetectors in a network.

It would also make sense to add a third type of table:

Detector positions: detector id, lane id, link id, position on lane

LoopDetector now has the following methods:

asTablePosition for: detector id, lane id, link id, position on the lane.
asTablePeriodicData for: detector id, flow, speed, etc. per aggregation period.
asTableNonPeriodicData for: detector id, measurement, value (such as arrays of vehicle passage times, platoon size)

Interface LoopDetectorMeasurement and sub-classes have been changed. The formatting is removed (that is done by djutils) and certain column information was added.


Upgrading the Transport layer

Is it possible to upgrade from HTTP to SPDY / HTTP 2 for transport  of BID Requests between exchanges.

I'm not aware of anyone in the industry doing SPDY / HTTP2 for BidRequests...

OpenRTB requires HTTP support minimally, but does not preclude exchanges
and their bidders from using other transports.  This is similar to
requiring JSON for representation minimally, but allowing any other
protocols (e.g., Avro, protobufs, etc.) that the parties wish to support.
:JB
On Tue, Jun 2, 2015 at 1:49 PM, Louis-Philippe Gauthier <
<EMAIL_ADDRESS>wrote:

I'm not aware of anyone in the industry doing SPDY / HTTP2 for
BidRequests...
—
Reply to this email directly or view it on GitHub
https://github.com/openrtb/OpenRTB/issues/18#issuecomment-108029133.

--
James M. Butler, Ph.D.* | *SVP Technology
millennial media
Mobile:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>Web: www.millennialmedia.com
Twitter: @millennialmedia
Facebook: Facebook/millennialmedia

From the OpenRTB2.3 spec, one of the ways indicated to improve connection performance is to use connection Keep-Alive. However it's not clear whether this avoids HOL blocking, is there any evidence of that happening in practice ?

@jpathak
Connection Keep-Alive is only used to keep the TCP connection itself from closing after every request. This greatly reduces the overhead and is pretty much on by default (or should be) these days.
This has nothing to do with the actual requests themselves and multiple requests can travel over the same connection, however HTTP/1.1 has no capabilities to overcome head-of-line blocking. There is HTTP pipelining which allows for sending several requests without waiting for each response immediately but this has varying support but tends to cause more problems than it solves and doesn't overcome HOL blocking either.
SPDY and HTTP/2 solve the HOL blocking issue by creating multiple streams within each connection that can support requests in parallel.

Thanks @manigandham!


Question about training category-specific

Hello,
Great work and thanks for releasing the code!
I'm a bit confused about the training process, in the paper it is mentioned as "A single model is trained for each object class with 50 random views per object instance, randomly sampling either one or two of the training views to encode", I understand this as you firstly use 50 views per object instance to train the general categorical representation, and for the actual training scene, you use only 1-2 views? I think I didn't quite get this process, some further elaboration will be very helpful.
Many thanks.

As I understand it, they use 50 target views and 1-2 source views which they encode and feed to the network

Do you mind elabrating more on this? What is target view and source view in this case?
Thanks in advance.

Yes 50 views per instance are used in total. 1-2 views are encoded each time, while all 50 views are used for supervision

Yes 50 views per instance are used in total. 1-2 views are encoded each time, while all 50 views are used for supervision

Hello, I have a question about training views. In this paper, you mentioned that you can train this model with only 3 views. But in the source code,  you choice 3 views randomly. This means that the whole views of a scene are applied for training. I can't understand this, would you like to provide me some details?

I have the same question with @dwangxxx


Trigger condition of  Collector "component removed" in ReactiveSystem

Hi,
I have a ReactiveSystem which collect entities with ComponentA removed, This system will be triggered when I call Entity.Destroy on the entity who has a ComponentA, the collected entity is fully empty (has no component), Is this the proper behaviour of Entitas? In my original thought, destoryed entity would not be conllected any way. If So What should I do to prevent the destroyed
entity to be collected
Cheers

I recommend marking an entity which you want to destory as ‘isDestroy’ = true instead of calling Entity.Destroy() immediately while ExecuteSystem or ReactiveSystem is running.
After all system execution completes, you can call Entity.Destroy() to destroy the entity which is marked ‘isDestroy’ from CleanupSystem.

I recommend marking an entity which you want to destory as ‘isDestroy’ = true instead of calling Entity.Destroy() immediately while ExecuteSystem or ReactiveSystem is running.
After all system execution completes, you can call Entity.Destroy() to destroy the entity which is marked ‘isDestroy’ from CleanupSystem.

Hi, It's not the same situation , I do real Destroy in a CleanupSystem.  What I means is “Entity.Destroy()” which internally call “Entity.RemoveAllComponents()” would trigger xxxcomponent.removed() and the related reactiveSystem would excute. I think it's should not be a right behaviour? Nobody want to process a really destroyed entity, Am I right?

Reactive system uses collector which collects entities, but not removes them until processed. Filter method can be used to check if entity still has relevant component.

This is intended behaviour.
You can filter for e.isEnabled to check if the entity is not destroyed yet.


[5.6] Support indexing within the SwiftPM plugin sandbox

Rationale: Allows for docc to emit an index when generating documentation within a SwiftPM plugin.
Risk: Low.
Risk Detail: This is an isolated change that touches very little existing DocC code. We had no need for LMDBs locking functionality so disabling it has no consequence for docc.
Reward: High
Reward Details: Enables docc to be used within SwiftPM plugins.
Original PR: #66
Issue: rdar://86786641
Code Reviewed By: @bontoJR
Testing Details: Existing tests continue to pass. An integration test that confirms DocC is able to build a DocC archive that includes an index when run as part of a SwiftPM plugin will be included in the Swift-DocC-Plugin project and run as part of CI when the plugin is published.

@swift-ci please test


Fix inconsistencies in fiona.Collection() iteration

Not ready
Closes #301

[ ] Add test for keys() method
[ ] Add test for items() method
[ ] Add test for filter() method

/ cc @cjthomas730

Need to work out some features in https://github.com/Toblerity/Fiona/issues/301, so I'm closing this.


[FEATURE REQUEST] Wattpad Premium Stories

Wattpad Premium Stories
Is your feature request related to a problem? Please describe.

Is there any way we can get premium stories for free?
Describe the solution you'd like

Describe alternatives you've considered

Additional context

Premium content requires an account where you have unlocked it.


[SPARK-34995] Port/integrate Koalas remaining codes into PySpark

What changes were proposed in this pull request?
There are some more changes in Koalas such as databricks/koalas#2141, databricks/koalas#2143 after the main code porting, this PR is to synchronize those changes with the pyspark.pandas.
Why are the changes needed?
We should port the whole Koalas codes into PySpark and synchronize them.
Does this PR introduce any user-facing change?
Fixed some incompatible behavior with pandas 1.2.0 and added more to the to_markdown docstring.
How was this patch tested?
Manually tested in local.

Test build #137314 has started for PR 32154 at commit ab531e1.

Test build #137314 has finished for PR 32154 at commit ab531e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41894/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137314/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41894/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41894/

Test build #137377 has started for PR 32154 at commit 98b6d9d.

Test build #137377 has finished for PR 32154 at commit 98b6d9d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class VectorizedBLAS extends F2jBLAS
trait AnalysisOnlyCommand extends Command
 implicit class MetadataColumnHelper(attr: Attribute)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137377/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41955/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41955/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41955/

cc @ueshin @xinrong-databricks
Would you please take a look at this when you find some time? :-)

Are they all changes to port? Might be good to confirm with @ueshin

Yeah, it includes the all changes after the porting in the main code.

Merged to master.

Seems like it broke the tests:

======================================================================
ERROR [4.255s]: test_frame_iloc_setitem (pyspark.pandas.tests.test_indexing.IndexingTest)
----------------------------------------------------------------------
ValueError: setting an array element with a sequence.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_indexing.py", line 1093, in test_frame_iloc_setitem
    kdf.iloc[0, 0] = -kdf.max_speed
AssertionError: "Incompatible indexer with Series" does not match "setting an array element with a sequence."

======================================================================
ERROR [13.432s]: test_series_iloc_setitem (pyspark.pandas.tests.test_indexing.IndexingTest)
----------------------------------------------------------------------
ValueError: setting an array element with a sequence.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_indexing.py", line 1238, in test_series_iloc_setitem
    kser.iloc[1] = kdf[["b"]]
AssertionError: "Incompatible indexer with DataFrame" does not match "setting an array element with a sequence."

----------------------------------------------------------------------
Ran 39 tests in 221.061s

FAILED (errors=2, skipped=5)

I am going to revert this. @itholic can you take a look please?

Oh, interesting. The test seems to passGitHub Action and Jenkins before merging. And, it fails at master branch.

@dongjoon-hyun Yeah, this PR was created before https://github.com/apache/spark/pull/32152 merged, which include test_indexing.py that causes test failure at master branch.
I should have better to checked that PR and apply the changes to this PR.  😅
Thanks for pointing it out!


I'm a customer using Home Assistant, how can I get a Home Pro?

Hi, I already test the Home Mini but would like the expanded functionality of Home Pro, as I use Home Assistant with many energy-based automations. How can I arrange to receive one and be part of your beta to test and provide feedback?

Me too 👍🏻


[office] Add 365

https://learn.microsoft.com/lifecycle/products/office-365-enterprise-government-education

Note: https://learn.microsoft.com/en-us/lifecycle/products/microsoft-365-apps says:

Microsoft 365 Apps for enterprise was previously named Office 365 ProPlus. Microsoft 365 Apps for business was previously named Office 365 Business.

Since the dates and status for both is same, this is fine for now.
But the "Office 365 Business Edition" (now called Microsoft 365 Apps for business) is separate from the Enterprise/Govt/Education edition (which we're tracking).


Image Mosaic of photos.devoxx.be is showing the oldest photos only

The reason is that https://github.com/TweetWallFX/TweetwallFX-Devoxx-2024-BE/blob/main/conference-impl/src/main/java/org/tweetwallfx/conference/impl/DevoxxPhotoSharingDataProvider.java#L50-L52
uses natural sorting of timestamp sorting from oldest to newest.
In effect once a newer entry is added and the cache is full it is removed immediately


Actually use absolute paths for crates.io crates

Turns out path_relative_from returns Some even if they're not ancestors of one
another!


install fails on 1.9.3-p0

Install doesn't work on 1.9.3:
 $ rip install rack-protection
 /Users/bozo/code/fork/rip/lib/rip/helpers.rb:33:in `read': can't convert Fixnum into String (TypeError)
    from /Users/bozo/code/fork/rip/lib/rip/helpers.rb:33:in `read'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:154:in `parse'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:154:in `parse_stream'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:125:in `parse'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/psych.rb:112:in `load'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/config_file.rb:239:in `load_file'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/config_file.rb:179:in `initialize'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems.rb:361:in `new'
    from /Users/bozo/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems.rb:361:in `configuration'
    from /Users/bozo/code/fork/rip/bin/rip-package-handle-gem:19:in `find_gem'
    from /Users/bozo/code/fork/rip/bin/rip-package-handle-gem:34:in `<main>'

Fyi, this happens with rubygems 1.8.10. I also get this on 1.9.2 with rubygems 1.6.2. However ruby 1.8.7 seems to work


Some problematic results calculated from libxc

Hi PySCF devs, I used the following density in a specific grid, when using BLYP functional deriv=2 or deriv=1 will give different results.
rho_a = numpy.array([ [1.96813585e-11], [-5.27011775e-11],  [1.56257568e-26],  [4.13823869e-14]])
rho_b = numpy.array([ [2.05739056e-11], [-5.50911693e-11],  [4.51859527e-27],  [1.81623010e-12]])

ni.eval_xc('blyp', (rho_a, rho_b), spin=1,relativity=0, deriv=2,verbose=0)[:2]
ni.eval_xc('blyp', (rho_a, rho_b), spin=1,relativity=0, deriv=1,verbose=0)[:2]

Exc, Vxc will all be zero if deriv=2. I was puzzled about that.
Thanks a lot!!!

Hi PySCF devs, I've read the code in libxc.py, in line 1317 which seems that those functionals may have singularity in those rho conditions. But is this cutoff right to set exc and vxc both 0? And Why xcfun will give non-zero results?
Thanks a lot!

Hi PySCF devs, I've read the code in libxc.py, in line 1317 which seems that those functionals may have singularity in those rho conditions. But is this cutoff right to set exc and vxc both 0? And Why xcfun will give non-zero results?
Thanks a lot!

In certain versions of libxc, some high order derivatives of LYP functional are
numerically instable. It gives inf or nan.  libxc.py filters these points. At
these points the value of exc and all high order derivatives (vxc, fxc, kxc) are
set to zero.
xcfun uses different techniques to compute derivatives. I'm not sure whether
xcfun actually produces more accurate results. As it does not break the
calculation, no density or densities are filtered.
On Sat, Jan 16, 2021 at 06:42:14PM -0800, hoshishin wrote:

Hi PySCF devs, I've read the code in libxc.py, in line 1317 which seems that those functionals may have singularity in those rho conditions. But is this cutoff right to set exc and vxc both 0? And Why xcfun will give non-zero results?
Thanks a lot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pyscf/pyscf/issues/797#issuecomment-761719901

--

In certain versions of libxc, some high order derivatives of LYP functional are
numerically instable. It gives inf or nan.  libxc.py filters these points. At
these points the value of exc and all high order derivatives (vxc, fxc, kxc) are
set to zero.
xcfun uses different techniques to compute derivatives. I'm not sure whether
xcfun actually produces more accurate results. As it does not break the
calculation, no density or densities are filtered.
On Sat, Jan 16, 2021 at 06:42:14PM -0800, hoshishin wrote:

Hi PySCF devs, I've read the code in libxc.py, in line 1317 which seems that those functionals may have singularity in those rho conditions. But is this cutoff right to set exc and vxc both 0? And Why xcfun will give non-zero results?
Thanks a lot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pyscf/pyscf/issues/797#issuecomment-761719901

--

Thank you a lot. I'm not sure whether both exc and vxc should be set to zeros.

Thank you a lot. I'm not sure whether both exc and vxc should be set to zeros.

Generally when the density is 0, you want exc and vxc to be 0, the
analytical forms of the functionals satisfy this constraint.
On Sun, Jan 17, 2021 at 4:08 PM hoshishin<EMAIL_ADDRESS>wrote:

Thank you a lot. I'm not sure whether both exc and vxc should be set to
zeros.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/797#issuecomment-761905294, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRC4UJZKV57RIYDH6ZDS2N3WPANCNFSM4WFBZNQA
.

Generally when the density is 0, you want exc and vxc to be 0, the
analytical forms of the functionals satisfy this constraint.
On Sun, Jan 17, 2021 at 4:08 PM hoshishin<EMAIL_ADDRESS>wrote:

Thank you a lot. I'm not sure whether both exc and vxc should be set to
zeros.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/797#issuecomment-761905294, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRC4UJZKV57RIYDH6ZDS2N3WPANCNFSM4WFBZNQA
.

Thank you, gkc! Is that mean when rho is small, both xcfun and libxc should set the exc and vxc to 0?

Thank you, gkc! Is that mean when rho is small, both xcfun and libxc should set the exc and vxc to 0?

If they worked in infinite numerical precision, there would be no problem.
Otherwise, the numerical library is typically computing something like
eps1/eps2 * eps3 ... eg. rho^(4/3) * (|grad rho| / rho^(4/3)); in this
latter case clearly the rho^(4/3) factors should cancel, but they will not
precisely cancel if the expression is parenthesized as above, because |grad
rho|/rho^(4/3) diverges as r->infinity for a typically small molecular
density of the form exp(-lambda r).
So the numerical stability is implementation dependent, it is possible to
implement things in a more stable way. PySCF does the practical thing and
simply sets inf/Nan when it sees them to 0. However, I believe there may
still be large numerical errors in xcfun (even if it does not give NaN) for
certain near zero densities and gradients. This what Qiming means by he
does not know if xcfun results are more accurate, they are just not inf or
NaN.
On Sun, Jan 17, 2021 at 4:16 PM hoshishin<EMAIL_ADDRESS>wrote:

Thank you, gkc! Is that mean when rho is small, both xcfun and libxc
should set the exc and vxc to 0?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/797#issuecomment-761906597, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRB4DJG6CJK4JYSM4BLS2N4WXANCNFSM4WFBZNQA
.

If they worked in infinite numerical precision, there would be no problem.
Otherwise, the numerical library is typically computing something like
eps1/eps2 * eps3 ... eg. rho^(4/3) * (|grad rho| / rho^(4/3)); in this
latter case clearly the rho^(4/3) factors should cancel, but they will not
precisely cancel if the expression is parenthesized as above, because |grad
rho|/rho^(4/3) diverges as r->infinity for a typically small molecular
density of the form exp(-lambda r).
So the numerical stability is implementation dependent, it is possible to
implement things in a more stable way. PySCF does the practical thing and
simply sets inf/Nan when it sees them to 0. However, I believe there may
still be large numerical errors in xcfun (even if it does not give NaN) for
certain near zero densities and gradients. This what Qiming means by he
does not know if xcfun results are more accurate, they are just not inf or
NaN.
On Sun, Jan 17, 2021 at 4:16 PM hoshishin<EMAIL_ADDRESS>wrote:

Thank you, gkc! Is that mean when rho is small, both xcfun and libxc
should set the exc and vxc to 0?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/797#issuecomment-761906597, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRB4DJG6CJK4JYSM4BLS2N4WXANCNFSM4WFBZNQA
.

Thank you, gkc! I see the point. If only some high order derivatives of LYP functional are numerically instable, when I set deriv=2 or deriv=1, what I expect to see is that the exc and vxc calculated from those two parameters should be the same. If deriv=2, exc = 0 and vxc = 0, but for deriv = 1 exc != 0 and vxc != 0, does that mean exc and vxc calculated from deriv = 1 are numerical unstable? Thank you very much!

Thank you, gkc! I see the point. If only some high order derivatives of LYP functional are numerically instable, when I set deriv=2 or deriv=1, what I expect to see is that the exc and vxc calculated from those two parameters should be the same. If deriv=2, exc = 0 and vxc = 0, but for deriv = 1 exc != 0 and vxc != 0, does that mean exc and vxc calculated from deriv = 1 are numerical unstable? Thank you very much!

You should retry the calculations with the 2.0 prerelease that uses Libxc 5.1.x where the numerical stability of a large number of functionals has undergone serious improvements.

Thank you, susilehtola! I'll try it.

Fixed in libxc 5.1


Add KyberAdapter

@Top-Kraken
the smart contract is good.
Please just update the readme for function description.
Some function description is missing.


Hide fields in taxonomy that don't belong there post migration

As part of the migration of fields that Dawn, Andrew, and Jeremy are doing, we'll need to hide the following fields in the taxonomy editor:

Data Use:legal_basis
Data Use:recipients
Data Use:special_category
Data Use: legitimate_interest
Data Use: legitimate_interest_impact_assessment

@Kelsey-Ethyca , @pattisdr as FYI

@pattisdr Are the above fields going to be made optional and or completely removed after the migration is done? I have the form fields removed but I can't submit the form due to failing the schema validation check from the BE.

Good callout @TheAndrewJackson.  I am not removing anything yet to reduce risk, just adding all new fields.  I will mark these as optional in fideslang (I think there was only one of these that wasn't?)

Thanks, I'll try making a small change locally while developing to get around the schema issue.
That's correct. The field that is failing  is legitimate_interest_impact_assessment

moving to. done


AVC FEI DSO: fixed high CPU usage of std::copy

Moved to structure-wise copy instead of byte-wise

@mgonchar, quite strange that struct wise copy gives u improvement. In case of byte-wise copying we should fall into builtin memmove wile for struct-wise we'll fall into explicit loop w/ per-struct member-wise copying through compiler's generated assignment operator of mfxFeiDecStreamOutMBCtrl. The latter is because std::is_trivially_copyable gives false for that type.

@mgonchar

std::is_trivially_copyable gives false for that type

double check this - it returns true for mfxFeiDecStreamOutMBCtrl, so std::copy for it should also fall into memcpy. So, there should not be differences w/ byte-wise copying.

@dmitry-gurulev well, from my understanding, std::copy should be not less efficient than memcpy. Also from my understanding the more you know about types you are copying the more efficient this copy should be. Since memcpy doesn't actually know size of blocks and it's actual alignment (since memcpy accepts void*) and std::copy knows everything about type it could apply more aggressive optimizations. But let's focus on background of this fix. Initial problem found in validation described in ticket MDP-53044. CPU usage increased from 26% to 31% after memcpy to std::copy change. After current fix it returned to previous 26% (this is confirmed by our validation). I don't really know the source of such behavior, my assumption that it is because char* pointers is a special case for compiler (but using non-standardized restrict key-word which is supported by gcc didn't help). I examined the assembly produced by gcc 6.3.1 and in case of byte-wise std::copy it produces tons of instructions and for struct-wise only a few. Neither of variants with std::copy had fallen to memmove or memcpy.

@dmitry-gurulev of course I was talking about trivially copyable types. POD structs without user defined constructors should be trivially copyable.

@mgonchar

Neither of variants with std::copy had fallen to memmove or memcpy.

Looks like we see inlined memcpy version. Just a version - in case of inlined memcpy compiler knows certain type anyway and it is able to generate more optimal code for struct-wise.

For those who still interested why we had high CPU usage with initial variant.
After investigation I found an answer.
Initial type of src is const mfxU8* which is const unsigned char* but dst type is char*. Now looking at stl realization by gcc we see following https://github.com/gcc-mirror/gcc/blob/866cd688d1b72b0700a7e001428bdf2fe73fbf64/libstdc%2B%2B-v3/include/bits/stl_algobase.h#L397
and
https://github.com/gcc-mirror/gcc/blob/866cd688d1b72b0700a7e001428bdf2fe73fbf64/libstdc%2B%2B-v3/include/bits/stl_algobase.h#L329
Now its clear why compiler fallback to loop assignment, while simple change of one pointer type (char => uchar) forces to fallback to memmove. Performance of byte-wise (with same pointers type) and structure-wise is on par.


'EnvHelper' object has no attribute 'AZURE_KEY_VAULT_ENDPOINT'

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Launch accelerator from devcontainer.
Upload document in "Ingest Data" tab from Admin page.

Any log messages given by the failure

Traceback (most recent call last): File "/tmp/8dc3e97a2013125/pages/01_Ingest_Data.py", line 204, in  upload_file(bytes_data, up.name) File "/tmp/8dc3e97a2013125/pages/01_Ingest_Data.py", line 146, in upload_file env_helper.AZURE_KEY_VAULT_ENDPOINT, credential ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'EnvHelper' object has no attribute 'AZURE_KEY_VAULT_ENDPOINT'

Expected/desired behavior

Upload document to Azure Blob Storage successfully and create embeddings.

OS and Version?

Windows 10 Pro 22H2

Versions

Latest version of accelerator.

Mention any other details that might be useful
EnvHelper class does not seem to have defined the AZURE_KEY_VAULT_ENDPOINT attribute rather than using the environment variable to create self.secret_client attribute (line 90-92), not self.AZURE_KEY_VAULT_ENDPOINT.
However, 01_Ingest_data.py (line 145-147) tries to define again both credential and secret_client using env_helper.AZURE_KEY_VAULT_ENDPOINT (not existing) instead of directly defining secret_client = env_helper.secret_client.

Proposal update:
Instead of just changing that single line, I think it is needed to completely change lines 143-152 to just account_key=env_helper.AZURE_BLOB_ACCOUNT_KEY as the rest of the process is already performed during env_helper creation. I did it and the document was uploaded to Azure Blob Storage successfully.

Hi @leonavevor I am also facing the same issue, does this issue resolved, if yes please help me the changes you made it to resolve. thank you.

Hi @ross-p-smith @leonavevor , if we wanted to ingest the CSV or excel file, where we have to change in the code base. Please suggest me. Thank you.


UI Elements don't scale with display scale

UI elements like line width and text size don't follow the display's scale.

Feature added in #26


Resolving dependencies and inheritance

I've think I've encountered somewhat unusual bug/design consequence in Dip:
code

class BaseModel: Resolvable {
    var baseService: BaseService!

	func didResolveDependencies() {
    }
}

class ChatModel : BaseModel {
    var chatService: ChatServiceProtocol!
}

container:

container = DependencyContainer { container in
	let baseService = BaseService()
	container.register(.Singleton) { baseService as BaseService }

	let chatService = ChatService()
	container.register(.Singleton) { chatService as ChatServiceProtocol }

	let baseModel = BaseModel()
	container.register(.Singleton) { baseModel }.resolveDependencies { container, entity in
		entity.baseService = try! container.resolve() as BaseService
	}

	let chatModel = ChatModel()
	container.register(.Singleton) { chatModel }.resolveDependencies { container, entity in
		entity.chatService = try! container.resolve() as ChatServiceProtocol
	}
}

When I initialize ChatModel somewhere, its baseService is not injected, even though it inherits from BaseModel.
let chatModel:ChatModel = ChatModel()
chatModel.chatService // ok
chatModel.baseService // nil

So it would seem that if objects inherit from other objects, then the properties from inherited object aren't resolved properly, because container doesn't trigger it's process in this case. My goal, was, obviously, to have a ChatModel, that would have both baseService and chatService injected, but I wanted to keep baseService in BaseModel. Did I do something wrong? Is it a bug?
I do realize, that I could initialize chatModel like so:
let chatModel = ChatModel()
container.register(.Singleton) { chatModel }.resolveDependencies { container, entity in
	entity.baseService = try! container.resolve() as BaseService
	entity.chatService = try! container.resolve() as ChatServiceProtocol
}

But that's (overall) not the point of having inheritance in the first place.

Also, looking at this, I'm not exactly sure if I should register BaseService as singleton, especially if there are other objects that clearly inherit from it (so there will be multiple instances after all). But, even if, the code never reaches the creation of BaseModel

The problem is that container does not know anything about inheritance of your classes. Even more if you register components as implementations of abstractions it will not even know what concrete implementation you register, because 'as' effectively erase type information.
To do what you ask for we will need to introduce something like inheritance for definitions, so that you can create base definition and create another one based on it, but that will, probably, return another instance, and for such definitions we will need to call resolve dependencies block of it's parent definitions... Looks like complicated and error prone feature that needs a good design. Typhoon btw has this feature.
If you want to remove code duplication you can achieve that by other means, like adding method resolveServices(container: DependencyContainer) on BaseModel and override it in ChatModel. Just put it in extension in the same file where you register all components to isolate dependency on Dip. Not the ideal solution, but that's all I can suggest for now.
Anyway thanks for reporting such things cause it really helps to see what functionality is missing.
We can keep this issue opened to discuss how/should it be implemented in Dip.

Yes, I understand that this is not an easy one to solve. But if Typhoon were able to do it, then it means you can too :) For now, I accept this as a limitation of the framework, although if this is ever implemented, it would be great.

Looks like the only thing that makes sense to inherit from other definitions is a resolveDependencies block, right?
Then maybe it would be easier just to do it like this?
let baseModel = BaseModel()
let baseModelDef = container.register(.Singleton) { baseModel }
  .resolveDependencies { container, entity in
     entity.baseService = try! container.resolve() as BaseService
}

let chatModel = ChatModel()
container.register(.Singleton) { chatModel }.resolveDependencies { container, entity in
    try baseModelDef.resolveDependenciesOf(entity, withContainer: container)
    //entity.baseService = try! container.resolve() as BaseService
    entity.chatService = try! container.resolve() as ChatServiceProtocol
}

That method resolveDependenciesOf of definition is already defined, but as internal. We can just add it in public scope and constrain it with generic type of the instance.
With that approach user will need to make sure the correct base definition is used cause container will not store any relationships between definitions.
Another option is to add optional parent parameter in each register method:
let chatModel = ChatModel()
container.register(.Singleton, parent: baseModelDef) { chatModel }
  .resolveDependencies { container, entity in
    entity.chatService = try! container.resolve() as ChatServiceProtocol
}

The drawback is that it complicates register method that has already several parameters and overloads.
Alternative option is to use mutating method in chain:
let chatModel = ChatModel()
container.register(.Singleton) { chatModel }
  .parentDefinition(baseModelDef)
  .resolveDependencies { container, entity in
    entity.chatService = try! container.resolve() as ChatServiceProtocol
}

None of these solutions is particularly appealing, ideally I would like to have just regular inheritance working as it always works and slap injection on top of that. If I would have to pick, though, the one with providing "parent" property is the cleanest and most in-line with inheritance.

Don't think that is currently possible without changing API design.
The problem is that even if we can get superclass type when instance of superclass is resolved we can not do anything with it, because we can not know if superclass implementation was ever registered in container. We could do that if while registering component we get type information about both registered abstraction (protocol) and concrete implementation (class). But we get only abstraction type (type of factory result) and personally I don't want to change that.

Also I'm not even sure if automatically calling resolveDependencies on superclass definition is a desired default behaviour.

Understood. My main gripe is that you have to now keep references to registrations and reuse them later in other registrations, which is just not neat. But I'll take it anyway, if that, together with the "parent" option would allow me to keep consistent and controllable dependencies in inherited objects. Better this, than nothing, obviously ;)

@sebastian-zarzycki-es
Few things that we should consider to properly implement that:

does it make sense to inherit anything else, like factory and scope? If yes then register method with parent parameter should have all other parameters as optional
what should happen when parent definition is removed from the container? should childs keep weak reference to their parents or strong and keep calling parents' resolveDependencies?
we should probably make sure that when user registers child definition parent definition is registered in the same container?
some other edge cases you can think of?

Not sure what you're asking about here. If that's about internals, I don't feel competent enough to answer. I would imagine that this is something you would know better how to organize. I'm not sure how big of a change, internally, is supporting inheritance in DI.
Is that a viable scenario? Why would you define anything in container, just to remove it later? As we've agreed on, once you call the bootstrap method, it's all sealed.
Of course.
Not really. In my mind, this should be a simple usecase, that would follow the standard inheritance rules in language. If someone tries to something silly, like removing definitions from container, then just throw an Error.

Looks like neither of the implementations I've proposed previously provides satisfying solution. Passing another definition as base definition in parameters does not let to ensure type-safety because of how generic works in Swift atm. Letting user to call some method on definition itself also does not provide any safety and makes api confusing.
Looks like the best way to reuse dependencies resolution from base classes is to move that responsibility from definition to class itself. We already have Resolvable protocol with didResolveDependencies method. We can add resolveDependencies(container: DependencyContainer) method and call it right after instance is created by container. Then base class dependencies should be resolved in this method. At the same time subclasses can override it to resolve any additional properties and simply call super.
The only drawback of that solution is that resolving dependencies may happen in different places.
Switching to other patterns, like constructor injection or auto-injection may solve that. #116 also contains  patch that fixes resolving inherited auto-injected properties.

Also addressed inheritance in #116 when using properties auto-injection


[fastlane] Version bump

Improved handling of new lines in increment_build_number (#4837)
Fix bug in OneSignal action (#4892)
Escape Gradle properties (#4897)
slather fix --decimals flag type
Output changelog in changelog_from_git_commits (#4860)
Verify rest-client dependency for sentry (#4871)
Removed appium development dependency and therefore nokogiri (#4852)

💎  ✨


WIP: Add the ability to remap EsModule imports at link time

WIP is a rather kind description. A cry for help, perhaps.
This attempts to follow up on https://github.com/VirtusLab/scala-js-cli/pull/47, and close https://github.com/VirtusLab/scala-cli/issues/2698 - i.e. introduce a using directive and / or command line option, to enable the work done in scala-js-cli.
This introduces a failing test, which I can run with;
./mill -i 'integration.test' 'scala.cli.integration.RunTests213.remap imports'
My current headscratcher, is that I don't seem to be able to modify the behaviour of scala-cli itself though. I've liberally put some printlns everywhere - which aren't printed. So I think I'm suffering from some sort of new contributor syndrome.
Would anyone have a hint, on why the intregration test, could be ignoring my attempts to introspect it?

One thing this made me realise is that we never bumped scala-js-cli to <IP_ADDRESS>, so I'm doing it in #2738... (I know you're overriding the version in the test, just mentioning, still need to look into your code)

My current headscratcher, is that I don't seem to be able to modify the behaviour of scala-cli itself though. I've liberally put some printlns everywhere - which aren't printed. So I think I'm suffering from some sort of new contributor syndrome.

Can you point me at where you're trying to introspect, which prints don't show?

Would anyone have a hint, on why the intregration test, could be ignoring my attempts to introspect it?

a wild guess is that you are printing on stdout, while stdout is being piped in the test...
https://github.com/com-lihaoyi/os-lib/blob/6603eb0e7434c86721806f2c1922452d9d9e49fc/os/src-jvm/ProcessOps.scala#L63-L65
If you want to print the logs when running the integration test (as opposed to when you call a freshly built launcher directly), then you need
os.proc(...).call(cwd = root, stdout = os.Inherit)

as stdout defaults to os.Pipe.
alternatively, you can print on stderr, which defaults to os.Inherit.
No idea if this was the question 😅

beyond the above, I'd recommend debugging the launcher directly, instead of printing stuff in the integration tests.
./mill -i integration.test.jvm 'scala.cli.integration.RunTests213.remap imports' --debug
# (...)
# --debug option has been passed. Listening for transport dt_socket at address: 5005

Another Q:
I built a launcher with;
./mill -i show cli.nativeImage

But it doesn't like the arguments I'm giving it. However, the integration test runs through, and it tests, exactly that flag? I'm not totally sure how that can happen?

Would you have a hint on how to fix this?

Yes.
https://github.com/VirtusLab/scala-cli/blob/main/CONTRIBUTING.md#rules-for-a-well-formed-pr
You need to regenerate the reference docs, among other things.
./mill -i generate-reference-doc.run

Also, you may want to rebase on top of main, rather than cherry picking individual commits.

@Gedochao @armanbilge  This actually ... works ... to my satisfaction.
The happy path works well.
I have a question on error messaging, which is that if I (deliberately) break it, for example by entering a bad file path to my importmap, it produces the error message I'd expect, but it's hidden at the top of the error stack, above scala-cli help. My eyeballs are where the green line is, but the message I need, is where the red line is.
Given that I'm naively throwing an exception, could I be engaging with scala-cli's error handling the wrong way?

Given that I'm naively throwing an exception, could I be engaging with scala-cli's error handling the wrong way?

@Quafadas Rather than throwing an exception, you need to return a Left[BuildException].
You'll need to define your own exception type extending BuildException (refer to the existing errors that are returned).

[x] Tighten error messages
[x] Tests for error conditions
[x] Tests for happy path
[x] Manual testing
[ ] Squash
[ ] Docs
[ ] CI green

./mill -i __.fix

you need this to satisfy the checks CI job.


Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas

Hi, we are a research group on programming languages and software engineering. We recently have conducted a systematic study about Solidity event usage, evolution, and impact, and we are attempting to build a tool to improve the practice of Solidity event use based on our findings. We have tried our prototype tool on some of the most popular GitHub Solidity repositories, and for your repository, we find a potential optimization of gas consumption arisen from event use.
The point is that when we use emit operation to store the value of a certain variable, local memory type variable would be preferable to storage type (state) variable if they hold the same value. The reason is that an extra SLOAD operation would be needed to access the variable if it is storage type, and the SLOAD operation costs 800 gas.
For your repository, we find that several event uses can be improved.

Hi @HighBe , we are aware of the issue. we might implement it next time we upgrade the DAO. however right now it doesn't bring us immediate benefit.


Fix unsafe call in Studioforty9_Recaptcha_Helper_Redirect

I was testing a custom route for this module using CLI curl and stumbled upon this error:
Call to a member function hasLastUrl() on null in app/code/community/Studioforty9/Recaptcha/Helper/Redirect.php on line 67.

Oh, someone else seems to have fixed this as well.. https://github.com/StudioForty9/Recaptcha/pull/38


Freshrss - addon vs standalone?

Hi,
Thanks for the add-ons. are there any drawbacks using the Freshrss add-on vs a standalone (docker etc) version?

Hi @quartzbear
In terms of core functionality, not much difference, if at all.
The only difference i could think of are custom plugins and themes, which you may want to add. It is easier with the original docker, as i have not integrated any config possibility yet. Having that said, there was also no request or requirement yet, as i am using freshrss for the provided API.

I don't currently use any plugins with my current Freshrss, so i'd say this would work for me.
Thanks


How i can get full_name of a Message?

For example protobuf.dev/reference/cpp/api-docs/google.protobuf.descriptor/#Descriptor.full_name.details

I'm not sure if you still need it, but for anyone searching for this, this features is available in crate prost-build. tonic-build uses it under the hood and allows to supply Config from prost-build with compile_with_config.
e.g.
// in build.rs
fn main() {
    let mut config = prost_build::Config::new();
    config.enable_type_names();
    tonic_build::configure()
        .compile_with_config(
            config,
            &["./proto/Foo.proto"],
            &[]
        ).expect("proto compiles")
}

// then in appliaction code
use prost::Name;

let full_name_foo = Foo::full_name();

This was written when tonic-build was in version "0.12.1", so this might be different on a future version.


Re-initialize the database after every test

Re-initialize the database after every test by implementing a dispose method. In that way we wouldn't worry in future about the state of our data and what is changed and we remove the complexity of re-initializing the database from our test methods.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Dermendzhiev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

OOF for the :gift: holidays :snowman: and will return on January 6.
If you need support, we recommend contacting devs on support channels and chat:

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at aspnet/AspNetCore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.
:dancer::man_dancing: Happy New Year! See you in 2020! :balloon::champagne:

Thanks @Dermendzhiev, but we're not going to recommend this approach. See :point_right: https://github.com/aspnet/AspNetCore.Docs/issues/16339#issuecomment-571296052


fix(browser): duplicate sub funnel ids renders incorrect step.

#94
I suggest showing console error messages to prevent duplicate sub funnel ids, and clearing the window.history.state after the sub funnel component unmounts.

This issue is solved<EMAIL_ADDRESS>version at #97.
Based on what you posted, I've listed you as a co-author on that PR.
Thanks to contribute!


MIDI input device and event is lost after first closing the InputConfigWizard MF <IP_ADDRESS>

I think I may have found a config bug in MF <IP_ADDRESS>
My nanoKontrol2 is detected, and button events and rotary event can be logged. Auto-input Scan worked for channel 1 Solo button, assigned to letter A. MobiFlight responds and issues the letter press. All good stuff, with great potential. I have 8 channels of [1 rotary axis, 1 slider axis, 3 buttons each with an LED] which can do a lot of useful functions.
First scan it is like this:

However, the device input is lost immediately after closing the form and then opening it:

The input config continues to run ok, but it cannot be viewed or edited.
On a positive note I'm quite excited how the nanoKontrol2 can perform in a cockpit.

hi,
this is not how it is supposed to be. That is the default behavior if no configuration for the specific midi board is loaded. If the correct configuration is loaded you should get all possible devices in the device combo box. And there is a specific configuration for nanoKontrol2.
Maybe your nanoKontrol2 identifies differently then expected. Please add a log file to the issue.
To create the log file:

In Mobiflight: Extras->Settings->Logging enabled
Restart mobiflight
Get the log.txt from the mobiflight directory and add the file to the issue.

Thanks!

Koseng,
I didn't know I had to load a nanoKontrol2 configuration. Nor do I know what a MIDI configuration is or where it should be.
I had spotted 5 .json files for MIDI devices in the install; I thought that indicated that MIDI support was included.
Please advise.
Regards
Paul

Hi Paul,
you do not need to load a nanoKontrol2 configuration. This should happen automatically. For some reason it does not happen and we do need to find out why.
Therefore I need the log-File. Please activate logging in mobiflight and attach the log.txt file to the github issue. Then I can diagnose. Also set log level to debug.

In Mobiflight: Extras->Settings->Logging enabled. Log Level to debug
Restart mobiflight
Get the log.txt from the mobiflight directory and add the file to the issue.

Thanks.

Koseng,
Attached is my log file set to debug.
I'm a retired C++ developer - back in 1993 I created MusicSoft and wrote and sold a guitar music program called "Band-it". It could read MIDI files and convert them to guitar tab and standard notation, which could be played or printed. Users could also enter notes to build up songs. Half my customers were guitar teachers - there was nothing else affordable on the market for printing guitar music, which they found invaluable for their business.
Back on Mobiflight I can see the nanoKontrol2 has been loaded. The good news is that MIDI events are getting though - over to you now!
I started MB, I created an input event, pressed "Scan for input", on the nanoKontrol2 I pressed one button then moved a slider. Then shutdown.
Looks like you might need one or two extra debug messages.
Cheers
log_nanoKontrol2.txt
Paul

As I suspected your nanoKontrol2 Board identifies differently as the board we had before. Please extract the additional config file from the attached zip and copy it to the Mobiflight/MidiBoards folder. Then restart Mobiflight and you should see all devices in the combobox.
Also please read https://github.com/MobiFlight/MobiFlight-Connector/wiki/Midi-Boards.
nanokontrol22.midiboard.json.zip

Mobiflight now shows the device correctly, and all the controls are visible:

Scanning for inputs captures potentiometers, buttons and sliders.
However:

Scanning sometimes requires two button clicks. I suspect there is a timing issue.
Channel 1 slider is scanned as "CC 1_12".
3 With log file and Run mode, half of all button events are lost.

Press: nothing logged
Release: Release is logged
Press : nothing logged
Release: Press is logged
Press: nothing logged
Release: Release is logged
Press nothing is logged
...this repeats forever
Log file will not help, it looks ok but the missing events are not listed. You have to trust me and verify yourself.

hi,
since the device identifies differently, maybe the default configuration is also different.
Can you post a screenshot of your midi board configuration with the KORG KONTROL Editor. Link you can find here:
https://github.com/MobiFlight/MobiFlight-Connector/wiki/Midi-Boards
Thank you.

Koseng,
Here ii is:

-Paul

Hi Paul,
sorry now I had time to come back to this. I cannot fully test by myself, because I don't own a nanoKONTROL2.
I looked at the possible Korg Kontrol Editor configurations and I suppose the buttons are configured to "Toggle-Mode" and not to "Momentary-Mode".
Please check that all your buttons are configured as shown in the screenshot. Behvior must be "Momentary" and Off value must be 0.  Does it work then?

If it still does not work, please write down which buttons you pressed exactly and attach the log file.
Thanks a lot!

Koseng,
I discussed MF OnPress/OnRelease on Discord. As you know MF can be programmed for toggle events, states and actions. Hardware wise a push button can be toggle e.g. toggle Gear up or down, but it can also be "action" so that each push does the same thing e.g. push to talk.
For Korg Kontrol 2, the ideal button behaviour depends on the intended design; there is no right or wrong. Until now I never knew each of the 34 Korg buttons can be momentary or toggle.
The confusing behaviour is "Scan for Input" only responds to an OnPress event, it will not respond to an OnRelease event.
So that sort of wraps things up. What should be done about commiting the .json files? The file starting with
"$schema": "./mfmidiboard.schema.json",
"InstanceName": "nanoKONTROL2",
is the one that works and it looks suitably generic. The ID in the default file does not make sense to me.
Many thanks.

Hi Paul,
Mobiflight expects one specific configuration of the midi board so that everything will work as intended. And this configuration must be set with the Control Editor. Probably we should provide ready to load files for the midi editors.
Could you please answer:

In the korg kontrol editor, have button behaviors been set to "Toggle"?
If you put the "Button Behavior"  to "Momentary", does it work then in Mobiflight?

Thanks.

The Korg default is:
Transport like Pause, Play, Record, Forward, Backward are Momentary. OnPress then OnRelease.
Channel buttons like Solo, Mute, Record are Toggle
That makes sense to me. LEDs show each channel's Solo, Mute and Record states, which persist in time.  Transport controls are immediate, timing could be synced to OnPress or OnRelease as per application or a timing track, aka click track.
Horses for courses. For a cockpit, one would set buttons as momentary or toggle depending on the sim function.
For Squawk, the 8 R buttons could be each digit 0 to 7, press 4 buttons in squawk sequence. Momentary.
For MCP/AP Speed, LNav, VNav, Loc, Alt Hold buttons at top would be Toggle, the sim may cancel certain LEDs
So 24 channel buttons, 11 control buttons, most have LEDs, 8 pots 0 to 1023, 8 sliders 0 to 1023.
I reckon the pots could do Baro, Mins or ND zoom.
S button on left could arm spoiler, the slider 0 to full spoiler. Cessna flaps using 3 buttons or right.
Quite a neat package.
Paul

Device now shows and original issue was solved. PR was merged.


TF 2.16.1 and Apple Silicon GPU support not working.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
v2.16.1-0-g5bc9d26649c 2.16.1
Custom code
Yes
OS platform and distribution
Mac OS 14.3.1 Apple M3 Pro
Mobile device
No response
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I can not get the basic example showing use of GPU to work on MacOS w/ TF 2.16.1.
However, It performs as expected in TF2.15.0
Standalone code to reproduce the issue
I have prepared 2 notebooks to show the behavior clearly, each using their own virtual environments.

GPU working TensorFlow215.ipynb
Unexpected TensorFlow216.ipynb

Relevant log output
No response

You will have to install tensorlfow-metal to add support for GPU on Apple silicons. More info

I did. Please look at the notebooks where I show exactly what was installed.

Hi @msusol ,
As a temporary fix you can use Keras2 backend. Since TF2.16 defaults to Keras3 backend it uses Keras3 by default with tf.keras. You can switch to Keras2 backend by installing tf_keras package and setting os.environ['TF_USE_LEGACY_KERAS'] = '1'. Meanwhile team will look into the issue with Keras3 vs Mac compatibility.

Hi @msusol ,
As a temporary fix you can use Keras2 backend. Since TF2.16 defaults to Keras3 backend it uses Keras3 by default with tf.keras. You can switch to Keras2 backend by installing tf_keras package and setting os.environ['TF_USE_LEGACY_KERAS'] = '1'. Meanwhile team will look into the issue with Keras3 vs Mac compatibility.

Verified that this change does restore GPU access to the kernel:
https://github.com/msusol/jupyter-notebook-on-macos/commit/7688a9fd2494807e5bb161c4f721ac82bada5c80
Waiting for the resolution to remove the legacy flag.


Implement #[ruma_api(raw_body)]

This PR implements a new ruma_api attribute, raw_body, which bypasses (de)serialization for Vec<u8> fields that represent the body of an HTTP request / response verbatim. It is a prerequisite for fixing https://github.com/ruma/ruma-client-api/issues/81.
I'm not very satisfied with the implementation, however. It doesn't complicate things that much, but partially reverts past simplifications (always having a RequestBody and ResponseBody type) and showed me just how different the request and response macro code are (and not because the input or output is that different).

@Nauxuron You're the only other person who has recently worked on the macro code, do you have time to do a review?

Thanks for reviewing @Nauxuron :)


Test EE WakeupThread and updated ReferThreadStatus test.

Added a test for WakeupThread system call. I've also updated the ReferThreadStatus test to display the waitType field.

Cool.  I guess we could check if there's a max for wakeupCount or something, though I doubt there is.  Might be interesting to try setting the wakeupCount negative and see if it's treated as signed or unsigned when something sleeps/wakes, but hopefully no game does that.
This doesn't really test that sleep decrements the counter, but that's more of a sleep-specific test anyway.
-[Unknown]

Indeed, testing for max and signedness of wakeupCount would be interesting. Not quite sure how it would be possible to set wakeupCount of a thread without finding out where the thread's status information is located in the kernel's memory area.

-[Unknown]

Well, I was hoping for a better way to do that, but yeah, I guess there's no other choice. The disassembly of the BIOS I've got states that the thread status information begins at 0x80017400, so, I'll have to give that a try to see if the info's actually there.


Add JavaScript syntax to environment variable access examples

I'm looking into scripting release pipelines with Gulp.js and found the following section:
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#access-variables-through-the-environment
I know that the correct syntax for environment variable access is process.env.VARIABLE_NAME but thought it would be helpful to have for those that are new to JS and to show that Azure Pipelines supports the language.
Thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Define variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

Thanks @mtakemoto! We'll be sure to add that to the docs.


ST-227 Refactor lmc-base-classes CI pipeline according to standards

Main work
The main work done here was to add a separate stage for the linting process in the CI and to extract the linting information in an XML with JUnit format.

The release was updated to the latest version (there was a bug).
Pylint standards were updated to sensible choices on par on what is used on other big open source projects (i.e. Microsoft).
Makefile has been added a new functionality: lint

Major outstanding issues
There are a number of outstanding issues with this repository there were not part of this PI feature but should be addressed in the near future. Below I list the two ones that seem the most urgent.

Linting process reports several warnings and some errors. These must be actually fixed in the source code and not by adding an exception not to check for the error under .pylintrc
The namespace of the lmc-base-classes needs to be fixed.

@adityadangeska , @apurvapatkar , @kalyanithigale can someone have a look at this? We really want to merge this one.


[Enhancement] push down predicate when computeHMSTableScanNode

a soultion for https://github.com/StarRocks/starrocks/issues/49911

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


https://lodestar-lightclient.chainsafe.io is not using updated latest proof endpoint

Describe the bug
Currently our browser light client is not able to fetch state because of it using the old proof endpoint.
Expected behavior
Should be able to fetch latest proof.
Screenshots

@philknows  Is this still relevant? I can't reproduce this.

Doesn't look applicable anymore, thanks for the ping. Closing.


Review and fix the Hungarian translation of _articles/legal.md

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

LGTM


Plug-In Throwing Errors

@iklein99, Thank you! So far your plug-in is working wonderfully for getting all of my SmartThings inside Homebridge Without using the Groovy IDE - Great work!
The plug-in is throwing some errors - not sure why - it does not appear to be impacting the working of the plug-in but they do appear very frequently in the logs.
Logs:
[16/10/2022, 11:58:31] [homebridge-smartthings-ik] This plugin threw an error from the characteristic 'Lock Target State': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'lock'). See https://homebridge.io/w/JtMGR for more info.
[16/10/2022, 11:58:31] [homebridge-smartthings-ik] This plugin threw an error from the characteristic 'Lock Target State': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'lock'). See https://homebridge.io/w/JtMGR for more info.
[16/10/2022, 11:58:31] [homebridge-smartthings-ik] This plugin threw an error from the characteristic 'Lock Target State': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'lock'). See https://homebridge.io/w/JtMGR for more info.
[16/10/2022, 11:58:31] [homebridge-smartthings-ik] This plugin threw an error from the characteristic 'Lock Target State': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'lock'). See https://homebridge.io/w/JtMGR for more info.
Plugin Config:
        {
            "name": "Smartthings Plug (IK)",
            "BaseURL": "https://api.smartthings.com/v1/",
            "AccessToken": “XXXXXXXXXXXXXX”,
            "GarageDoorMaxPoll": 40,
            "PollLocksSeconds": 10,
            "PollDoorsSeconds": 10,
            "PollSensorsSeconds": 5,
            "PollSwitchesAndLightsSeconds": 10,
            "platform": "HomeBridgeSmartThings"
        }

Is the lock in question working properly in Home Kit?

No response.  Closing


crust_node example output and usage comments are unhelpful.

The comments in crust_node.rs state e.g.

// starting second node : cargo run --example crust_node -- 5883 -b <IP_ADDRESS>:5983

The output from running a crust_node in server mode by doing
target\debug\examples\crust_node.exe -o 6666

yields the following output:

Connection manager now listening on TCP socket <IP_ADDRESS>:6666

However, when connecting another node, we need to use the server's actual IP address, not <IP_ADDRESS>.

Using <IP_ADDRESS> doesn't seem to be an issue on OS X, and probably isn't a problem on Linux either.

This means all IP addresses, I think with beacon on a LAN we will be OK, but the node should find it's own IP address for those who connect to it as well. We perhaps require the sniffing logic from rudp and the IANA addresses for checking external IP.

using <IP_ADDRESS> or <IP_ADDRESS> or the actually ip address depends on what has been printed out in "add new node ", which might be OS dependent.


Not support remap source from Intermediary name to mojang name when using forge platform

Projects built with the arch loom output source jars that use the Intermediary name, but the loom will only map the Intermediary to the srg name, not the named.
eg:

This problem does not exist when using yarn or quilt mapping, only when using mojang mapping (or derived mapping).


Fixed Issue #49 Redmine 3.0.3 higher

Redmine 3.0.3 higher.
Fixed an issue where the progress of the project is always 100%.

@jp-yendo thank you for the contribution. Did you took this code from the Redmine or this is your personal update?

reference url
https://github.com/redmine/redmine/blob/master/app/models/issue_query.rb
When you study the mysql log "status" join not is of "where" even I was corrected for, which has not been specified.

Details I've found.
This problem was caused by a version of ActiveRecord.
http://apidock.com/rails/ActiveRecord/Calculations/ClassMethods/sum

Thanks, this is working for me :+1:
@stgeneral, will You merge this pull request?

@jp-yendo thanks for the contribution!
@Marqin thank you for confirming the fix!
Fixes #58, #49, #46.


Mention FOSSLight as integrated tool

Summary of changes

mention FOSSLight as tool which integrates with OpossumUI

Context and reason for change

FOSSLight supports export to OpossumUI (https://fosslight.org/fosslight-guide-en/scanner/2_source.html?highlight=opossumui#1-fosslight_source)

@nicarl
It was very nice. Thank you! 😄


Unable to Clone another private repo from the same GitHub Organization

I am currently running into an issue where I am able to pull from one private GitHub source in the checkout stage but unable to pull another private GitHub source from a script later in the pipeline due to lack of access rights. Note: Both Repos are a part of the same organization. And I've already connected the Azure App to GitHub with access to all Repos
Within my checkout stage I've explicitly set persistCredentials: true This, as I understand it, should allow the following scripts in the pipeline to use the GitHub credentials that were used in the checkout for "Get Sources".
Here is an example of the script that fails:
- script: |
git clone --branch=username --single-branch https://github.com/username/myRepo.git $(Agent.BuildDirectory)/myRepo
displayName: 'clone myRepo'

And the output:
Generating script.
[command]/bin/bash --noprofile --norc /Users/vsts/agent/2.140.2/work/_temp/cb2622cc-28e0-435a-bb98-154bdabf9641.sh
Cloning into '/Users/vsts/agent/2.140.2/work/1/myRepo'...
fatal: could not read Username for 'https://github.com': Device not configured
##[error]Bash exited with code '128'

I'm having a similar issue but it results in a different message.
I'm having a pipeline for SOME_PRIVATE_REPO that uses code from OTHER_PRIVATE_REPO within the same organization ORG. Azure Pipelines is enabled and is aware of both repositories (in settings in github).
Here's a snippet of the azure-pipelines.yml:
- script: |
      cd some_dir
      git clone https://github.com/ORG/OTHER_PRIVATE_REPO.git
      cd OTHER_PRIVATE_REPO
      git checkout v1
      pip install -e .
    displayName: 'Install OTHER_PRIVATE_REPO from tagged commit'

So, the job just hangs at the stage of  Cloning into 'OTHER_PRIVATE_REPO'..., and after some time gets automatically cancelled due to timeout.
I tried googling but couldn't find how to access other private github repo inside a pipeline for a private github repo. Does anybody know?

I've found a solution that I don't like but it works.
In the pipelines editor on azure devops, go to variables section, and create a secret variable with a github access token in it. Then, refer to it in the git clone command in the azure-pipelines.yml file.
Resulting snippet from my yml file:
- script: |
      cd some_dir
      git clone<EMAIL_ADDRESS>      cd OTHER_PRIVATE_REPO
      git checkout v1
      pip install -e .
    displayName: 'Install OTHER_PRIVATE_REPO from tagged commit'

The x-access-token part was found here.

Having the exact same issue. I agree with @astafan8 - I don't like the solution with the secret and the access token. Ideally it should support multiple the build pipeline should support checkout tasks. I think it relates to this User Voice request

Moved into Developer Community: https://developercommunity.visualstudio.com/content/problem/1007491/unable-to-clone-another-private-repo-from-the-same.html
Please use "Follow" button on the right to track it

@DominicCabral:
Please go to this link and answer Microsoft team: https://developercommunity.visualstudio.com/content/problem/1007491/unable-to-clone-another-private-repo-from-the-same.html


Double requirement error if build-backend missing

I have the following pyproject.toml:
[build-system]
requires = ["wheel", "setuptools>=42", "setuptools_scm[toml]>=3.4"]

Build fails with:
Looking in links: /tmp/tmpu9cyr1oc
Processing /tmp/tmpu9cyr1oc/setuptools-47.1.0-py3-none-any.whl
Processing /tmp/tmpu9cyr1oc/pip-20.1.1-py2.py3-none-any.whl
Installing collected packages: setuptools, pip
Successfully installed pip setuptools
ERROR: Double requirement given: setuptools>=42 (from -r /tmp/build-reqs-akrau6fv.txt (line 2)) (already in setuptools>=40.8.0 (from -r /tmp/build-reqs-akrau6fv.txt (line 1)), name='setuptools')
WARNING: You are using pip version 20.1.1; however, version 20.2.3 is available.
You should consider upgrading via the '/opt/hostedtoolcache/Python/3.8.5/x64/bin/python -m pip install --upgrade pip' command.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/build/__main__.py", line 176, in <module>
    main(sys.argv[1:], 'python -m build')
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/build/__main__.py", line 168, in main
    build(args.srcdir, args.outdir, distributions, config_settings, not args.no_isolation, args.skip_dependencies)
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/build/__main__.py", line 80, in build
    _build_in_isolated_env(builder, outdir, distributions)
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/build/__main__.py", line 45, in _build_in_isolated_env
    env.install(builder.build_dependencies)
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/build/env.py", line 176, in install
    subprocess.check_call(cmd)
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.8.5/x64/bin/python', '-m', 'pip', 'install', '--prefix', '/tmp/build-env-6o04yjl_', '-r', '/tmp/build-reqs-akrau6fv.txt']' returned non-zero exit status 1.

However, there is a missing line - and adding it fixed the problem:
build-backend = "setuptools.build_meta"

a) Is it possible to improve the error message and b) should this error be happening anyway? It seems to be trying to recursively produce all the requirements manually and put then into a requirements.txt-like file, which then collide?

This happens because pip can't resolve multiple dependencies right now, that will change in the next release. For now, you can set PIP_USE_FEATURE=2020-resolver to force pip to use the new dependency resolver.
I deliberately choose to not implement a dependency resolver as it is not trivial and pip is getting one anyway.

Hum sorry, seems like the pip version you are using is 20.1 and PIP_USE_FEATURE=2020-resolver is only available in 20.2.
Perhaps ensurepip, which is what we use to get pip into the environment, copies the system pip. Try upgrading it.

But I would definitely recommend to explicitly set the build backend, otherwise setuptools.build_meta:__legacy__ will be used, you probably want setuptools.build_meta.

Regardless of resolving, I think the issue here is this, we inject the requirements for the default build-backend into requires if build-backend is not specified.
I think we should probably do one of the following things here:

Don't inject the requirements for the default backend into requires if requires is specified, since people are probably not expecting their requires to get messed with in the first place. I assume that this is not a requirement of PEP 518.
Do extremely minimal resolving for the trivial case by checking if each of the default backend requirements are in the existing requires, and taking a union of the bounds — we can explicitly throw an error in the case of a null set or anything that's too complicated to resolve properly.

I'm in favor of option 1 here, because I definitely don't expect build to be injecting requirements for the default backend on top of my existing requirements. Option 2 will make more stuff work "out of the box", but I don't know how much that matters to me, since it doesn't seem like a big deal to ask people to get their build metadata right given that they've already added it.

As a data point, pip's current behavior is to treat build-system.requires as complete even when the build-system.build-backend key is missing.
A project with the following setup.cfg:
[metadata]
name = project
version = 0.0.1

And the following pyproject.toml:
[build-system]
requires = []

Will fail when you do pip install ., but will succeed if you do python -m build. We should probably fail as well (particularly since this could easily lead to a situation where python -m build is generating source distributions that pip cannot install).

Don't inject the requirements for the default backend into requires if requires is specified, since people are probably not expecting their requires to get messed with in the first place. I assume that this is not a requirement of PEP 518.

Right. We should probably also add a message saying that we defaulted to setuptools.build_meta.__legacy__ if no backend is specified, to make things easier to debug for people who have not read the whole PEP 517.
If we choose not to inject requirements I think it would be better to just disallow specifying requires when build-backend is not set.
Having duplicated requirements still is possible, and that will only be fixed with pip 20.3.

I think it would be better to just disallow specifying

Personally, I would prefer consistency with pip. requires = ["wheel", "setuptools>=42", "setuptools_scm[toml]>=3.4"] builds with pip since no extra requirements are injected, so you don't have the setuptools clash.
A message saying "please specify a backend" would be not a bad idea, though, I think. :) (I rather wish the PEP had enforced that)

If we choose not to inject requirements I think it would be better to just disallow specifying requires when build-backend is not set.

I disagree with this — there are a lot of packages out there that started specifying PEP 518 requirements before adding build-backend, partially because PEP 518 was implemented in pip first and partially because PEP 518 gives immediate added value if you have a build-time dependency like Cython. A lot of people didn't want to specify build-backend = 'setuptools.build_meta' because it opts them into a slightly different build setup, so they just leave it blank.
As much as I'd like to force people to specify their build backend, we'll have a lot of packages out there without build-backend explicitly specified, and distros will need to carry patches to pyproject.toml if they want to use build as their canonical way to build distro packages.
I think the best thing to do would be to do what pip is doing:

If requires is specified, it is always used unmodified.
If requires is unspecified and build-backend is unspecified, use the defaults.
If build-system is present without a requires, throw an error (it is mandatory in PEP 518).

Having duplicated requirements still is possible, and that will only be fixed with pip 20.3.

I don't really understand this point. The duplicated requirement here is being injected by us. If the end user specifies duplicated requirements, that is their problem. pip will handle duplicated transitive dependencies gracefully, just not direct dependencies.

I disagree with this — there are a lot of packages out there that started specifying PEP 518 requirements before adding build-backend, partially because PEP 518 was implemented in pip first and partially because PEP 518 gives immediate added value if you have a build-time dependency like Cython. A lot of people didn't want to specify build-backend = 'setuptools.build_meta' because it opts them into a slightly different build setup, so they just leave it blank.

Okay, I undertand.

As much as I'd like to force people to specify their build backend, we'll have a lot of packages out there without build-backend explicitly specified, and distros will need to carry patches to pyproject.toml if they want to use build as their canonical way to build distro packages.

Well, distributions could still use setup.py in those cases. When the project drops setup.py they will likely have to use python-build anyway and would fix ths. But the points you made above make sense.

I don't really understand this point. The duplicated requirement here is being injected by us. If the end user specifies duplicated requirements, that is their problem. pip will handle duplicated transitive dependencies gracefully, just not direct dependencies.

Nor PEP 518 or 517 makes restrictions regarding the requirements. Although for build-system.requires it might not really be a problem, since it is directly specified by a user and can be easily fixed, get_requires_for_build_{sdist,wheel} could potentially be problematic as a build systems could for eg. generate this list automatically. Since duplicated requirements are not forbidden, I think they should be something to keep in mind.

Nor PEP 518 or 517 makes restrictions regarding the requirements.

You mean neither of them restricts whether you can specify the same thing twice?
That's true, but again it's not really our problem. The minimum we can do is to not exacerbate the situation by injecting requirements that the user never specified. I think it's reasonable to specify defaults, but not to modify explicitly specified fields.

Eh, we still need to install them, so we need to make sure that works. I was just pointing out that the core issue here, pip not being able to install duplicated requirements, is still there. It was not an argument in favor of keeping injecting requirements.

This cropped up for me today with a very similar pyproject.toml to the OP. There is no doubt that the error message is fairly obscure and could be improved if the existing behaviour is planned to remain in this way.
However, IMO, if python-build wants to inject requirements into a build it should do so with a little care for what has already been defined in the build requirements. The basic tools to do this are already in packaging (already a dependency) with a little creativity (which should perhaps belong in packaging in the first place):
import typing

from packaging.requirements import Requirement
from packaging.utils import canonicalize_name

def join_requirement(req1: Requirement, req2: Requirement) -> Requirement:
    """
    Join together two requirement specifications for the same package name by
    evaluating the markers (if they exist) against the current Python process.

    """
    if req2.marker and not req2.marker.evaluate():
        # No matter what req2 says, it evaluates false, so it doesn't influence
        # the final spec. Note it is entirely possible that req1 doesn't
        # evaluate true either, but we let downstream tools deal with the
        # marker handling.
        return req1
    elif req1.marker and not req1.marker.evaluate():
        return req2
    else:
        spec = r1.specifier & r2.specifier
        extras = ','.join(f'"{name}"' for name in r1.extras | r2.extras)
        return Requirement(f"{req1.name}[{extras}]{spec}")

def join_requirements(
        requirements1: typing.Iterable[Requirement],
        requirements2: typing.Iterable[Requirement]
) -> typing.List[Requirement]:
    """
    Given two iterables of Requirements, merge together those which overlap.

    """
    r1_lookup = {canonicalize_name(req.name): req for req in requirements1}
    r2_lookup = {canonicalize_name(req.name): req for req in requirements2}

    result = []
    for name, req in r1_lookup.items():
        if name in r2_lookup:
            req = join_requirement(req, r2_lookup.pop(name))
        result.append(req)
    # We've been mutating r2_lookup, so anything that's left doesn't collide
    # with req1 and should just be be added.
    result.extend(r2_lookup)
    return result

For example:
>>> requirements = ['setuptools>=42.2 ; python_version<"3.0"', 'wheel']
>>> other = ['setuptools>=41.2', 'another']
>>> join_requirements(
...     [Requirement(req) for req in requirements],
...     [Requirement(req) for req in other]
... )
[<Requirement('setuptools>=41.2')>, <Requirement('wheel')>, 'another']

To summarise, I think there are a number of options for addressing this issue:

Do nothing (i.e. await pip to handle duplicate requirements properly)
Improve the error message. Likely by catching the fact that the user has already set some build requirements but not defined the backend.
Safely inject the requirements of the default build-backend (e.g. the code above) if the user has specified requirements but not the backend.

There is advice in pypa repositories (e.g. https://github.com/pypa/setuptools_scm#pyprojecttoml-usage) which provide examples which are missing the build backend in pyproject.toml and as a result there will be many examples in the wild which see the same message as the OP when invoking python-build. Personally I find it a shame that people's first impression of python-build would be that, particularly when considering that pip wheel --no-deps will build a project with such a pyproject.toml.
If any help is needed implementing it I'd be happy to contribute in any way I can.

@FFY00 Did you mean to assign this wontfix? I thought we were going to just drop the requirements injection thing, since it's the cause of the bug, unnecessary, not in keeping with the spec and inconsistent with what pip does.


BAU: remove environment variables which are no longer used by accepta…

…nce tests config
Solo: @hugh-emerson

closed due to age


Create extra workers taking into account number of executors on node

I've already signed the CLA.
That PR fix issue with too many instances being created when number of executors per node is set to > 1

@evandbrown Thats rather obvious bug, and code behind fix is also simple..
Should I fix that PR or just close it cause it will never be merged?

Looks pretty good.
I've gone through your code changes and pulled down the code and ran everything. I had to edit the integration test, but it now passes. One of my teammates will need to review my/your changes.
I'd like to merge this after I merge https://github.com/jenkinsci/google-compute-engine-plugin/pull/3. Should happen in the next few days.


Step not clear - Fiori App ABAP

Hello,
Scenario URL: https://developers.sap.com/tutorials/abap-environment-data-model.html
Step 1.5 & 1.6:
"Define root view for ZI_TRAVEL_M_XXX and database table as source" & "Your result should look like this. Replace your code with following" ->
Step is confusing: First we are asking define root view.. but not asking to write anything in the code, and then next step first we are saying your result should look like this and asking to replace the code!.. where actually we need to replace the code only.
Please update the tutorial.
SAME FOR STEP 2.5 & 2.6:
Steps are not clear. Just mention replace your code with following would do.
Labels to be added:
Sprint Label: SCPTest-2011A
Landscape label: trail1, trail2
Scenario label: SCPTest-fabap
Prio: High-prio
Thanks,
Shubham

Hi @i353590 ,
I created following pull request: #6347 for this issue.
@MichaelCzcz  we can close this ticket.
Best regards,
Merve


Release Process for v6.2.0

Release Process for v6.2.0

[x] Verify that PowerShell-Native has been updated/released as needed.
[ ] Check for PowerShellGet and PackageManagement release plans.
[x] Start process to sync Azure DevOps artifacts feed such as modules and NuGet packages.
[x] Create a private branch named release/v6.x.x in Azure DevOps repository.
All release related changes should happen in this branch.
[ ] Prepare packages

[x] Kick off coordinated build.
[x] Sign the RPM package.
[ ] Install and verify the packages.
[x] Trigger the docker staging builds (signing must be done).

[ ] Run tests on all supported Linux distributions and publish results.
[ ] Update documentation, and scripts.

[ ] Update CHANGELOG.md with the finalized change log draft.
[ ] Stage a PR to master to update other documents and
scripts to use the new package names, links, and metadata.json.

[ ] Kick off Release pipeline.
[ ] Create the release tag and push the tag to PowerShell/PowerShell repository.
[ ] For preview releases,
merge the release branch to GitHub master with a merge commit.
[ ] For non-preview releases,
make sure all changes are either already in master or have a PR open.
[ ] Delete the release branch.
[ ] Trigger the docker image release.
[ ] Retain builds.

Linux test results
PS> $r | ft OS,Total,Pass,Fail,Pending,Skipped
OS                           Total Pass Fail Pending Skipped
--                           ----- ---- ---- ------- -------
CentOS Linux 7 (Core)         9996 8183    1     338    1474
Debian GNU/Linux 9 (stretch)  9996 8182    1     338    1475
Fedora 28 (Twenty Eight)      9996 8183    1     338    1474
openSUSE Leap 42.3            9996 8183    1     338    1474
Ubuntu 14.04.6 LTS            9996 8182    1     338    1475
Ubuntu 16.04.6 LTS            9996 8169    1     338    1488
Ubuntu 18.04.2 LTS            9996 8169    1     338    1488

expected failure in containers - Test-Connection.Ping.Force IPv4 with explicit PingOptions

It seems that it can be released in advance, congratulations in advance by me.
A kind reminder:
Note that the file name  in packages.microsoft.com.
At the time of the release of 6.1, the 6.1.0 GA version was version old than the rc version because of the file name problem, which prevented yum from updating the powershell. Eventually I had to remove the preview package on packages.microsoft.com.
This problem may never appear, it is better.

The problem with preview has been fixed since early in 6.1 preview.  The later previews did not have to be removed.  See https://packages.microsoft.com/rhel/7.3/prod/

Why ChangeLog is so short for 6.2 release? It seems we skipped most of changes.

The changelog we publish here is incremental from the RC release.  I don't think we should put all changes twice in the change log.


use cleaner way of using matplotlib so that the 'Agg' background doesn't need to be set

Currently if someone import matplotlib.pyplot before neurom is used, and the DISPLAY variable isn't set, it tries to set the 'Agg' background, so that figures aren't rendered to the current user.  Instead, it should create figures without pyplot, so that does happen.

Why not just remove it? This part is a library, not an application, so it doesn't need a specific backend. The choice of backend should be left to the user.

Going to fold this into #607
Thanks for the feedback


VeedSol

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address: FRzcv4hbKxQty2N22sxGB4hLELRYzGF1GQX8FQ8peRXS
Token Name: VeedSol
Token Symbol: VES
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

ok now, I disabled mint token limit.
my greetings.
Dan

I can help refer this https://github.com/zakimzf/profile/pull/1
PS: if you don't need my help.. please ignore this!


Having issues with registering on Freeswitch

Hello there, hopefully someone could help out a bit with this
I'm trying out the dart sip ua client demo, with a mostly default configured Freeswitch, running everything in my lan.
The issue is, that I'm getting 200 on registering to an extension e.g<EMAIL_ADDRESS>but I can't make any calls.
If I try and make a call from another client to the dart ua demo client, I'm just getting "Answered" which is rather weird. Also when I try to create a call from dart demo client to another client, I'm getting the next error "Level.error sip_ua_helper.dart:76 ::: Not connected, you will need to register"
Besides that, on my Freeswitch, I can see that I get registered with the demo app, and at the right extension, but with this weird contact e.g.
sofia/internal/sip:8y275sq0@8863bs810j58.invalid;fs_nat=yes;fs_path=sip%3A8y275sq0%40<IP_ADDRESS>%3A59518

Is this weird? Am I missing something?

Hi,
I’m presuming you’ve correctly setup websockets etc as you’re registered.
What do the invites look like?
Thanks.
Kind Regards,
Gavin Henry.
Managing Director.
T +44 (0) 330 44 50 000
D +44 (0) 330 44 55 007
M +44 (0) 7930 323266
F +44 (0) 1224 824887
E<EMAIL_ADDRESS>Open Source. Open Solutions(tm).
http://www.suretecsystems.com/
Suretec Systems is a limited company registered in Scotland. Registered
number: SC258005. Registered office: 24 Cormack Park, Rothienorman,
Inverurie, Aberdeenshire, AB51 8GL.
Subject to disclaimer at http://www.suretecgroup.com/disclaimer.html

Hi;
Thank you for your reply. I actually figured it the issue was on flutter side with permissions, but still having the issue with the Contact header.
Thanks

That's good! What's wrong with the Contact header?

Thanks ghenry
I guessed something is off with it, but it's fine though?
Also after testing out - I'm able to call from the dart demo to other clients, but can't receive calls on dart demo.
Any tips what should I look into, what could I be missing?

Is the FreeSWITCH sending webrtc SDP data? If you're registering directly
it will know it's webrtc. Are you using wss?

I find that there is no "transport=ws;" in your Contact header,  just comment the code in
   // Custom Contact URI params for REGISTER and un-REGISTER.
    //setExtraContactUriParams(
       // ua.configuration.register_extra_contact_uri_params);

here
can fix it.  and you may ask @ghenry why to add the lines, the git log is " extraContactUriParams now working and tested against OpenSIPS 3.1 that has RFC8599 support. Refs #89 - https://github.com/cloudwebrtc/dart-sip-ua/issues/89
" with this commit "SHA-1: f3394d9d950201ddb8ca8cfa156f2c2a18930547"

Hi @ZZXUN233
That setting is used to do this where you add params to the Contact header:
https://tools.ietf.org/html/rfc8599#page-12
     REGISTER<EMAIL_ADDRESS>SIP/2.0
     Via: SIP/2.0/TCP alicemobile.example.com:5060;branch=z9hG4bKnashds7
     Max-Forwards: 70
     To: Alice<EMAIL_ADDRESS>     From: Alice <sip:alice@example.com>;tag=456248
     Call-ID:<PHONE_NUMBER>84230@998sdasdh09
     CSeq: 1826 REGISTER
     Contact<EMAIL_ADDRESS>       pn-provider=acme;
       pn-param=acme-param;
       pn-prid=ZTY4ZDJlMzODE1NmUgKi0K>;
       +sip.pnsreg
     Expires: 7200
     Content-Length: 0

e.g.
    UaSettings settings = UaSettings();

....

    if (GetPlatform.isAndroid || GetPlatform.isWeb) {
      settings.registerParams.extraContactUriParams = <String, String>{
        'pn-provider': 'fcm',
        'pn-param': FCM_PROJECT_ID,
        'pn-prid': _fcmToken
      };
    }

Are you saying without anything set in settings.registerParams.extraContactUriParams then transport=ws doesn't get added? If so, why haven't you reported this?
Thanks.


Remove right style from dropdown

Pull Request Test Coverage Report for Build 450631644

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.423%

Totals

Change from base Build 450573099:
0.0%

Covered Lines:
1888

Relevant Lines:
1955

💛  - Coveralls