Cant get it to work on Raspberry Pi 2

I installed npm without problem.
After running npm install and npm run webpack I get the following error:
The node_modules dir was empty.
ERROR in ./~/css-loader!./~/less-loader!./src/browser/components/main.less Module build failed: ReferenceError: Promise is not defined     at LazyResult.async (/home/pi/Apps/fb-sleep-stats/node_modules/postcss/lib/lazy-result.js:157:31)     at LazyResult.then (/home/pi/Apps/fb-sleep-stats/node_modules/postcss/lib/lazy-result.js:79:21)     at processCss (/home/pi/Apps/fb-sleep-stats/node_modules/css-loader/lib/processCss.js:198:5)     at Object.module.exports (/home/pi/Apps/fb-sleep-stats/node_modules/css-loader/lib/loader.js:24:2)  @ ./src/browser/components/main.less 4:14-127
Here is the full console log:
http://pastebin.com/raw/pSFg4fMv
I decided to ignore the error and run scrape anyway, but all I got was:
Polling every 600 seconds Tue Mar 15 2016 00:08:06 GMT+0100 (CET)  - Active users:  63 / 258 Tue Mar 15 2016 00:08:06 GMT+0100 (CET) An error occured while scraping. Please check to make sure your development.json config is correct [ReferenceError: Promise is not defined]
This is my development.json (not real values ofc..)
{     "fbCookie": {         "c_user": "2431254960",         "xs": "539%3A2b6ALG3g4H1nWQ%3A2%3A1657993299%3A1012"     },     "pollingInterval": 600,     "appId":<PHONE_NUMBER>61821,     "server": {         "port": 3000     } }
BTW I am running pi-hole to block ads, hope that wont be an issue.

This seems to be a duplicate of https://github.com/sqren/fb-sleep-stats/issues/75. Updating Node to the latest version should fix it.

take a look at #98


Add Docker major/minor version upgrade guide

Description
This PR captures the details required for a minor version upgrade of OpenSearch running on Docker.
Issues Resolved
Relates to #745
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing this out because I had moved to a new PR due to rebasing issues.


Bug/v2/upload

Codecov Report
Patch and project coverage have no change.

Comparison is base (96576b6) 0.00% compared to head (142543d) 0.00%.

:exclamation: Current head 142543d differs from pull request most recent head 2a31d6a. Consider uploading reports for the commit 2a31d6a to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@    Coverage Diff     @@
##   2.x   #967   +/-   ##
==========================
==========================

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fixes graph calculations changing values of client

I  cloned this bugs branch onto my machine to test the graph changing the client object. This PR creates a new client object which fixed this bug for me.

To clarify the purpose of the pull request, to make the graph work, the code now creates a new object containing the values of the current client object, and then only the new object's values get changed.


Clustering method

Is your feature request related to a problem? Please describe.
KeplerMapper does not work in combination with sklearn.clustering.AgglomerativeClustering (using distance_threshold). It seems that KeplerMapper relies on the parameter "min_clusters/n_clusters/min_samples" to be available (kmapper.py, line 506).
Describe the solution you'd like
The documentation should be more clear about what is expected from the clustering method to work in KeplerMapper.

That code block has a final fallback of 2 if none of the previous are available: https://github.com/scikit-tda/kepler-mapper/blob/56dbd6642b69830f329d272bf9f6c5e877386cb8/kmapper/kmapper.py#L506-L511

Also, here's an example of someone using AgglomerativeClustering https://github.com/scikit-tda/kepler-mapper/issues/185#issuecomment-571255773 , what error message are you getting? Full stack trace please?

I tried this clustering method:
cluster_method=sklearn.cluster.AgglomerativeClustering(n_clusters=None,distance_threshold=0.2,compute_full_tree=True,linkage='single')
Traceback (most recent call last):
File "mapper_cat.py", line 32, in
cover=my_cover,
File "/home/mkerber/.local/lib/python3.7/site-packages/kmapper/kmapper.py", line 529, in map
if hypercube.shape[0] >= min_cluster_samples:
TypeError: '>=' not supported between instances of 'int' and 'NoneType'
I think the error makes sense, since n_clusters is set, just not to an integer. The documentation  of AgglomerativeClustering says that n_clusters has to be set to None if distance_threshold is set.
Perhaps you can check whether the parameter is an integer and if not, set it to 2 instead?

Indeed! Thanks for the bug report.I remember now that @torlarse had hard-coded kmapper to use min_cluster_samples = 2 when they posted the code in that comment. Maybe you can try that until a patch is released?


Add C# data provider support for macOS

To decide:

Which macOS versions to support?  Paratext Lite supports Monterey and Ventura. We will need dev/test machines available for each.
How do we want to handle Unicode support? ParatextData requires ICU.NET now which relies on icu4c libraries.  If we don't change ParatextData, then we need to figure out how to get icu4c onto macOS.  Microsoft builds some for Windows and Linux, but not macOS. Homebrew has prebuilt icu4c binaries for some macOS versions. Also, ICU.NET will require some updates.

Regarding how Paratext Lite handles this:

Paratext Lite doesn't use icu.net.  Paratext Lite has its own really basic LdmlAdapter.  Paratext Lite on MacOS shares a lot of the code with the Android version and currently uses the same approach.

Additional resources of interest:

https://learn.microsoft.com/en-us/dotnet/core/extensions/globalization-icu#macos-behavior
https://sil-language-software.slack.com/archives/C805N00N8/p1687190320705099
https://unicode-org.github.io/icu/userguide/icu4c/build#how-to-build-and-install-on-unix
https://formulae.brew.sh/formula/icu4c

Here is some Q&A from Marc Durdin: (Q's from me, A's from him)

How important is it to develop on and target each OS release?  Is it reasonable to target specific ones that generally would cover others?  Is it most important just to target the newest one?  If there are tips/suggestions for where to find market share and usage for different countries and demographics, that would be helpful.

It is difficult to support older versions of iOS and macOS -- Apple deprecate their tools very rapidly, so after a few releases, it becomes nearly impossible to build for the older versions (unless you maintain old build agents with older versions of operating systems to run the older versions of the development tools -- and have separate builds for the various versions). Thus, older iOS/macOS devices are not very useful because they cannot run most software. Generally, we aim to support the latest few releases, and do best-effort for older ones on macOS, where we are not on the App Store. On iOS, we only support the versions supported by App Store deployment (v12+ right now for example). We don't have any good data on market share and usage.

Are there reasonable shortcuts that work for macOS development?  For example, if we have a Linux version of software that works, is there anything that would easily run a Linux VM similar to WSL on Windows?

Not really. VMs on macOS are not a great user experience. You'd be better running Parallels and Windows than attempting a Linux VM. We do Linux VMs as developers, and they're a pain to manage. And, you'll alienate a majority of macOS users who prefer to use vanilla macOS. You can target Java or some other cross-platform framework, but it makes for an ugly macOS experience, which is difficult because the users of macOS demand the greatest level of consistency with the platform look and feel. tl;dr: you need a native macOS version.

If we're working with C# and Typescript generally, is VSCode sufficient for development, or are we going to find it hard to work without Xcode?

You will find it hard to work without Xcode -- I personally do all my coding in VSCode when doing macOS work, but anything that involves UI or project management / deployment, etc, kinda requires breaking out Xcode. There are whole industries developed around not using Xcode (e.g. fastlane tools) but they constantly require maintenance because a lot of the infrastructure they work with is undocumented.

How hard is it to publish to the Mac App Store?  Is it better to just assume we will side load apps?

Keyman can't be published to Mac App Store because it uses keyboard hooks, which are not permitted. We sideload, and frankly it's probably an easier experience to have your own installer. Most significant apps are available as standalone. So it's probably not a big blocker for users.
My perspective on the App Stores is that they are great for Apple, and offer some benefit for end users in terms of safety, but they are an opaque experience for developers -- we have wasted huge amounts of time dealing with App Store infrastructure issues.

How have you worked with ICU libraries on macOS?  It seems that Apple doesn't provide all the icu4c libraries by default, but I see some builds available from Homebrew.

We haven't used the ICU libraries on macOS.
Note: although iOS and macOS are our two smallest platforms in terms of userbase, they are the most work for maintenance for us:

Apple keep us on the upgrade treadmill on their timetable -- e.g. regular requirements to update to latest xcode to continue publishing to app store, which requires upgrade to macOS to install, which forces us to stop supporting old versions of iOS, macOS. (This also means we can't publish updates to old versions of our apps because we can't build with newer xcode without lots of work!)
Apple's App Store, code signing, and notarization servers regularly fail, without warning, and break builds.
Apple's documentation is generally poor quality and inconsistent.
App Store review processes are fairly arbitrary and every now and then we get a build which fails review (despite not changing anything!) and we have to stop our regular work to address the issue.

I must say that all of that is not encouraging. 😖

For what it's worth I publish the electron app lameta for macs using only vscode, but that's typescript only. I don't publish to the store, but I do have to sign and get the notarization. Apple completely changed this last month, and I found getting the electron app notarized in the new system to be quite a puzzle for lack of documentation. Eventually got it working, so that github action yml may be of use as a reference: https://github.com/onset/lameta

Also, Marc was talking about an app with native UI. If you're doing electron, in my experience,

Once everything was running on mac, it just kept running.  Now I just run some automated UI tests before release.
Newer versions of electron have a minimum supported mac OS version, so you have to watch that.
I don't recall ever running xcode.

Unit testing will look like reenabling unit tests that didn't work on mac before.

Discovered a bug in the icu4c library causing test failures. We need to try rolling back to an older icu4c build on macOS if they are available to avoid these errors.

Turns out that wasn't a bug in icu4c but a bug in icu-dotnet's handling of UnicodeSet data.

https://github.com/sillsdev/libpalaso/pull/1327

https://github.com/sillsdev/icu-dotnet/pull/198

@lyonsil I'd be interested to know where you settle on getting the mac native icu4c library from for Paratext, I just ran into the Microsoft nuget package that has windows an linux binaries, but wasn't sure what to do about mac.

@hahn-kev We haven't sorted it out yet, but as a first cut I'm assuming we will lean on MacPorts (which is what we are using in the macOS builds for icu-dotnet's GitHub build actions). MacPorts has both binary and build from source options available. Presumably we can bundle a universal build of icu4c libs into the platform installer for macOS.


bump webassemblyjs

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, link to documentation update:

Summary

Does this PR introduce a breaking change?

Other information
Closes https://github.com/webpack/webpack/issues/7258

Thanks


Project separated into different layers

Description
Project separated into different layers
Changes
Changes proposed in this pull request:

added class libraries

Pull request status

[X] Implementation
[X] Unit tests
[X] Exception Handling

Коментарче!

Power is only given to those who are prepared to lower themselves to pick it up


Windows issue

Hola o/
tl;dr; python-binexport does not work on Windows.
It requires python-magic, which is not working on Windows without an auxiliary package named python-magic-bin, embedding some native code in a DLL. This package seems to be un-maintained from years, but, well, anyway, it still works with recent Python version 🤷♂
But when adding this auxiliary package, there is another bug, in the way magic is used (see https://github.com/quarkslab/python-binexport/blob/main/bin/binexporter#L42) :
def recursive_file_iter(p: Path) -> Generator[Path, None, None]:
    if p.is_file():
        mime_type = magic.from_file(p, mime=True)

The argument passed to magic.from_file is a Path object, not a string. On Linux, when calling the native code from https://github.com/ahupp/python-magic/blob/master/magic/init.py#L321-L322, the coerce_function will return a string from the Path object, But on Windows, the original Path object will be returned ... so the call to the native code will receive an object instead of the expected string (see https://github.com/ahupp/python-magic/blob/master/magic/init.py#L317) , which results in an ctypes.ArgumentError: argument 2: TypeError: wrong type
A quick fix could be to ""cast"" the Path object to a string when calling  magic.from_file.
Maybe another option could be to replace the usage of python-magic by LIEF and the various utilities functions lief.is_elf(), lief.is_pe(), lief.is_macho()  ?

This should have been solved with #9 in version 0.3.0

Confirmed to be working after #18 in version 0.3.1


NIFI-12066 a series of minor version bumps for key dependencies

Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

I pushed up a couple more minor changes/squashed and forced.  I will create a specific PR for the support branch which doesnt change aspectj or caffeine shortly.

I pushed up a couple more minor changes/squashed and forced. I will create a specific PR for the support branch which doesnt change aspectj or caffeine shortly.

Thanks @joewitt, the additional changes look good. Putting together a separate PR for the support branch sounds like a good solution, and we can move this one forward for the main branch pending successful builds.


Implement REST api for healthcheck

This includes providing information about:

amount of active bidders for a given round
amount and ID of provisioners
current step the node's consensus algorithm is at (this information is handled by the Coordinator)
status of the EventQueue

Closed via #579


DropdownButtonFormField arrow icon is misaligned vertically

Steps to reproduce

Run sample
Observe dropdown icon is aligned to where the content would be instead of the field as a whole

Expected results
The dropdown icon should be vertically centered within the form field.
Actual results
The dropdown icon is centered vertically relative to the selected content.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Center(
              child: SizedBox(
                width: 200,
                child: DropdownButtonFormField<String>(
                  onChanged: (_) {},
                  decoration: InputDecoration(
                    labelText: 'Label text',
                  ),
                  items: [
                    DropdownMenuItem(
                      value: 'selected',
                      child: Text('Selected item'),
                    ),
                  ],
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Flutter:

M3 Design:

Logs
N/A
Flutter Doctor output
Doctor output
[!] Flutter (Channel [user-branch], 3.27.0-1.0.pre.87, on Microsoft Windows [Version 10.0.22631.4317], locale en-US)
    ! Flutter version 3.27.0-1.0.pre.87 on channel [user-branch] at C:\Users\bscho\.puro\envs\master\flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup.
    ! Warning: `flutter` on your path resolves to C:\Users\bscho\.puro\envs\stable\flutter\bin\flutter, which is not inside your current Flutter SDK checkout at C:\Users\bscho\.puro\envs\master\flutter. Consider adding
      C:\Users\bscho\.puro\envs\master\flutter\bin to the front of your path.
    ! Warning: `dart` on your path resolves to C:\Users\bscho\.puro\envs\stable\flutter\bin\dart, which is not inside your current Flutter SDK checkout at C:\Users\bscho\.puro\envs\master\flutter. Consider adding
      C:\Users\bscho\.puro\envs\master\flutter\bin to the front of your path.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision 9bb056822e (62 minutes ago), 2024-10-16 22:52:18 -0400
    • Engine revision e2188ee9ab
    • Dart version 3.6.0 (build 3.6.0-334.2.beta)
    • DevTools version 2.40.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at C:\Users\bscho\AppData\Local\Android\sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.11.35312.102
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2023.2)
    • Android Studio at C:\Program Files\Android\Android Studio1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] VS Code (version 1.94.2)
    • VS Code at C:\Users\bscho\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.98.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22631.4317]
    • Chrome (web)      • chrome  • web-javascript • unknown
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 129.0.2792.89

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Center(
child: SizedBox(
width: 200,
child: DropdownButtonFormField(
onChanged: (_) {},
decoration: InputDecoration(
hintText: 'Label text',
),
items: [
DropdownMenuItem(
value: 'selected',
child: Text('Selected item'),
),
],
),
),
),
],
),
),
);
}
} try this its bcz of label text change to hint text

@Reprevise import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Center(
child: SizedBox(
width: 200,
child: DropdownButtonFormField(
onChanged: (_) {},
decoration: InputDecoration(
hintText: 'Label text',
),
items: [
DropdownMenuItem(
value: 'selected',
child: Text('Selected item'),
),
],
),
),
),
],
),
),
);
}
} try this its bcz of label text change to hint text

When I also provide hintText, it looks right:

But in this issue, hintText is not provided. And per M3 design shared above, I think we still need to fix this.

I think the issue is from the use of InputDecorator in line 1589 of dropdown.dart. InputDecorator reserves a small space at the top of the widget for the floating label and pushes it's children down including the dropdown icon.
When no items are chosen in the DropdownButtonFormField and the labelText is not floating, InputDecorator centers the labelText vertically while the dropdown icon is being pushed down. This is the cause of the misalignment, imo.
if (widget._inputDecoration != null) {       result = InputDecorator(         decoration: widget._inputDecoration!,         isEmpty: widget._isEmpty,         isFocused: widget._isFocused,         child: result,       );     }

the following fix worked for me:
icon: Transform.translate(
  offset: const Offset(0, -7),
  child: const Icon(Icons.arrow_drop_down),
),


File Dropzone: Add accept property

Description

Added accept property to accept certain file types

References
Fixes #2003
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Quick few thoughts on this:

The property is labeled accept which I don't think is descriptive enough. Perhaps accept-file-types would be better?
In the docs/canvas demo it would be helpful to have an example of how exactly a file type to be added. What format does it accept them? would accept=".doc,.docx" work like input type=file does?

.doc,.docx

Quick few thoughts on this:

The property is labeled accept which I don't think is descriptive enough. Perhaps accept-file-types would be better?
In the docs/canvas demo it would be helpful to have an example of how exactly a file type to be added. What format does it accept them? would accept=".doc,.docx" work like input type=file does?

Renamed the prop to acceptFileTypes and added formats doc to the story book
While adding more than one format it accepts files in this way

For doc alone its accepts files in this way


Auto Pairs cannot be disabled

I have added UnBundle 'jiangmiao/auto-pairs' and the bundle is removed during PluginClean.
But the imap setting like AutoPairsDelete() still effective when a file is loaded.
It causes E117:Unkown function: AutoPairsDelete() whenever I type <BS>.

did you  clear your ~/.vimviews folder?

clean ~/.vimviews fixed this issue. thanks


feat(EditServiceModal): only show framework edit if hook true

This hook is added because the API is EE for now. The cosmos/service/update API is not yet migrated.
Closes DCOS-19784.
Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

Hold merge till I fix these tests.

@ahoskins let's disable the tests so that it's easy to reinstate them again when we remove this hook.

@orlandohohmeier I've added a link to a Jira ticket for us to renable this.


EIP-6780: SELFDESTRUCT only in same transaction

More info here: https://eips.ethereum.org/EIPS/eip-6780

Add it after account state: https://github.com/bluealloy/revm/pull/499

Hey @rakita, can I take this?

Hi! I tried to take a look at this EIP and issue. I was wondering if I could try to tackle it or if it 'reserved' (sorry for the lack of a better term) to the more experienced/main contributors of this project. If this is the case it's fine I have no problems with it and I understand.
I'd be happy to work at it with some support here and there, since it is my first EIP I'll try to do. Thanks a lot!

Hi! I tried to take a look at this EIP and issue. I was wondering if I could try to tackle it or if it is 'reserved' (sorry for the lack of a better term) to the more experienced/main contributors of this project. If this is the case it's fine I have no problems with it and I understand.
I'd be happy to work at it with some support here and there, since it is my first EIP I'll try to do. Thanks a lot!

You can try it, this should be a small change. There is already a crated flag inside the Journal that should help with this.

Where can I find the appropriate tests for this EIP? Looking at https://github.com/ethereum/tests I've found something here https://github.com/ethereum/tests/tree/develop/EIPTests/Pyspecs/cancun, however they fail to run with this error: Error: Statetest(SerdeDeserialize(Error("missing field `env`", line: 165, column: 5)))
I don't understand if I should fix something here or if the tests inside such folder are not really compatible with the existing revm code. Thanks for the support!

Where can I find the appropriate tests for this EIP? Looking at https://github.com/ethereum/tests I've found something here https://github.com/ethereum/tests/tree/develop/EIPTests/Pyspecs/cancun, however they fail to run with this error: Error: Statetest(SerdeDeserialize(Error("missing field `env`", line: 165, column: 5))) I don't understand if I should fix something here or if the tests inside such folder are not really compatible with the existing revm code. Thanks for the support!

Not that I know for state tests, they are probably going to be added afterwards. Those jsons are blockchain tests that can be run inside reth: https://github.com/paradigmxyz/reth/tree/main/testing/ef-tests, it seems the usage explanation is here: https://github.com/paradigmxyz/reth/pull/2847
Can you push the PR so I can check it out?


ValueError: The passed save_path is not a valid checkpoint:

Hello, Thank you for sharing. I implimented the code, I want to train on HMDB datasets with 51 classes. I followed exactly what you stated in your readme. when I run train_c3d_ucf101.py i get
ValueError: The passed save_path is not a valid checkpoint:
I need help with the fine tuning and training on custom data aside from UCF101

@babdulhakim2
Can you post the whole terminal output?
And you need change the layer by yourself for the fine tune.(I'm just learning it also,so I can't help you to do that.Sry)

Here is a screenshot of what I got. Like I said changing the output layer is still my biggest challenge so if you have any useful guide, please share. Thanks

@babdulhakim2 You should check here:   https://github.com/highway007/C3D-tensorflow-py3/blob/fdc056b30c7d303d6f1f51b44b26858b6ed6d7a5/train_c3d_ucf101.py#L204 and set to False.
I am looking for the method of fine tune also,I will @you or send email when I find something good.

Ok will be expecting you, thank you for responding


dhcpcd:  fails to acquire an IPv4 address

Describe the bug
This is already tracked upstream: https://github.com/NetworkConfiguration/dhcpcd/issues/281
The client fails to acquire the DHCP-server-supplied IP address, which looks in the logs as follows, repeated ad infinitum:
Jan 25 03:23:02 host dhcpcd[14323]: eth0: dh:cp:se:rv:er:mc(dh:cp:se:rv:er:mc) claims <IP_ADDRESS>
Jan 25 03:23:02 host dhcpcd[14323]: eth0: dh:cp:se:rv:er:mc(dh:cp:se:rv:er:mc) claims <IP_ADDRESS>
Jan 25 03:23:02 host dhcpcd[14323]: eth0: 10 second defence failed for <IP_ADDRESS>
Jan 25 03:23:02 host dhcpcd[14323]: eth0: deleting route to <IP_ADDRESS>/8
Jan 25 03:23:02 host dhcpcd[14323]: eth0: deleting default route via <IP_ADDRESS>
Jan 25 03:23:02 host dhcpcd[14323]: eth0: rebinding lease of <IP_ADDRESS>
Jan 25 03:23:02 host dhcpcd[14323]: eth0: probing address <IP_ADDRESS>/8
Jan 25 03:23:07 host dhcpcd[14323]: eth0: leased <IP_ADDRESS> for infinity
Jan 25 03:23:07 host dhcpcd[14323]: eth0: adding route to <IP_ADDRESS>/8
Jan 25 03:23:07 host dhcpcd[14323]: eth0: adding default route via <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: dh:cp:se:rv:er:mc(dh:cp:se:rv:er:mc) claims <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: dh:cp:se:rv:er:mc(dh:cp:se:rv:er:mc) claims <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: 10 second defence failed for <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: deleting route to <IP_ADDRESS>/8
Jan 25 03:23:08 host dhcpcd[14323]: eth0: deleting default route via <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: rebinding lease of <IP_ADDRESS>
Jan 25 03:23:08 host dhcpcd[14323]: eth0: probing address <IP_ADDRESS>/8
Jan 25 03:23:14 host dhcpcd[14323]: eth0: leased <IP_ADDRESS> for infinity
Jan 25 03:23:14 host dhcpcd[14323]: eth0: adding route to <IP_ADDRESS>/8
Jan 25 03:23:14 host dhcpcd[14323]: eth0: adding default route via <IP_ADDRESS>

Meanwhile, on the wire we see the following:
02:52:41.370524 IP <IP_ADDRESS>.bootpc > <IP_ADDRESS>.bootps: BOOTP/DHCP, Request from cl:ie:nt:ma:ca:dr (oui Unknown), length 337
02:52:41.371083 IP server.bootps > <IP_ADDRESS>.bootpc: BOOTP/DHCP, Reply, length 308
02:52:47.583527 IP <IP_ADDRESS>.bootpc > <IP_ADDRESS>.bootps: BOOTP/DHCP, Request from cl:ie:nt:ma:ca:dr (oui Unknown), length 337
02:52:47.584122 IP server.bootps > <IP_ADDRESS>.bootpc: BOOTP/DHCP, Reply, length 308
02:52:53.508164 IP <IP_ADDRESS>.bootpc > <IP_ADDRESS>.bootps: BOOTP/DHCP, Request from cl:ie:nt:ma:ca:dr (oui Unknown), length 337
02:52:53.508768 IP server.bootps > <IP_ADDRESS>.bootpc: BOOTP/DHCP, Reply, length 308
02:52:58.902490 IP <IP_ADDRESS>.bootpc > <IP_ADDRESS>.bootps: BOOTP/DHCP, Request from cl:ie:nt:ma:ca:dr (oui Unknown), length 337

..which, upon close inspection is:
02:55:26.811461 IP (tos 0x0, ttl 64, id 8452, offset 0, flags [none], proto UDP (17), length 365)
    <IP_ADDRESS>.bootpc > <IP_ADDRESS>.bootps: BOOTP/DHCP, Request from cl:ie:nt:ma:ca:dr (oui Unknown), length 337, xid 0x87654321, Flags [none]
	  Client-Ethernet-Address cl:ie:nt:ma:ca:dr (oui Unknown)
	  Vendor-rfc1048 Extensions
	    Magic Cookie 0x12345678
	    Requested-IP (50), length 4: <IP_ADDRESS>
	    DHCP-Message (53), length 1: Request
	    Parameter-Request (55), length 14:
	      Subnet-Mask (1), Classless-Static-Route (121), Default-Gateway (3), Domain-Name-Server (6)
	      Hostname (12), Domain-Name (15), MTU (26), BR (28)
	      Static-Route (33), NTP (42), Lease-Time (51), RN (58)
	      RB (59), Unknown (119)
	    MSZ (57), length 2: 1472
	    Hostname (12), length 4: "client"
02:55:26.812047 IP (tos 0xc0, ttl 64, id 57327, offset 0, flags [none], proto UDP (17), length 336)
    server.bootps > <IP_ADDRESS>.bootpc: BOOTP/DHCP, Reply, length 308, xid 0x87654321, Flags [none]
	  Your-IP <IP_ADDRESS>
	  Server-IP server
	  Client-Ethernet-Address cl:ie:nt:ma:ca:dr (oui Unknown)
	  Vendor-rfc1048 Extensions
	    Magic Cookie 0x12345678
	    DHCP-Message (53), length 1: ACK
	    Server-ID (54), length 4: server
	    Lease-Time (51), length 4: 131072
	    Subnet-Mask (1), length 4: <IP_ADDRESS>
	    BR (28), length 4: <IP_ADDRESS>
	    Default-Gateway (3), length 4: server
	    Domain-Name-Server (6), length 4: server
	    Domain-Name (15), length 5: "domain"
	    Hostname (12), length 4: "client"

..i.e., completely legitimate.
IOW, dhcpcd 10.0.3, as per Nixpkgs master is completely broken in this use case.
Steps To Reproduce
Steps to reproduce the behavior:

networking.interfaces.enp1s0.useDHCP = true;

Expected behavior
dhcpcd should acquire the DHCP lease from the server.
Notify maintainers
@edolstra
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.11-hardened1, NixOS, 24.05 (Uakari), 24.05.git.2a7d0d9fe220`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

cc @jiegec

Could you test if the latest release of dhcpcd works?

Turned out, the issue I have originally referred was unrelated -- filed a new one: https://github.com/NetworkConfiguration/dhcpcd/issues/291

Trying out https://github.com/NixOS/nixpkgs/pull/284123 as a fix.

Hitting this on 24.05

https://github.com/NixOS/nixpkgs/pull/284123 fixes this, through a bump to the latest release.
The fix is only halfway, though -- the dhcpcd bump allows the address to be acquired, but it's not necessarily what the server initially offers (go figure).
cc @yorickvP @jiegec


Gleam 0.26+: Deno support

Once Gleam 0.26 hits Glacier should also handle JavaScript src and test modules for Deno, via https://deno.land/api@v1.29.1?s=Deno.watchFs.

This should be done.


Add pure python platform-agnostic wheel

Fixes #973
Release workflow can be found: https://github.com/pytorch/data/actions/runs/4108506783/jobs/7089283333

Will this be the default installation going forward?

Like I said in the issue. This wheel would be the backup package when none of platform specific wheels fit into users' machine. If pip finds any suitable wheel for the specific platform, it should install the platform-specific one.

2. Do we need to update the installation instructions in README?

No thing needs to be updated IMO.


fatal error: 'EGL/egl.h' file not found

System information

OS Platform and Distribution : macOS Catalina (v 10.15.7)
Target : Desktop GPU
Bazel version: 3.7.2
Python version: 3.9.2
GCC/G++ version: 12.0.0
Unity version: ~
Android NDK version (if building for Android): ~
Xcode version (if building for iOS): ~

Describe the problem
Facing error 'EGL/egl.h' file not found on running the build command for Desktop GPU.
Steps to reproduce the issue

Clone the repository
Install all the prerequisites
Run command python build.py build --desktop gpu -v

Full logs
Admins-iMac:MediaPipeUnityPlugin Administrator$ python build.py build --desktop gpu -v
INFO (build.py): Building protobuf sources...
DEBUG (build.py): Running `bazel build -c opt //mediapipe_api:mediapipe_proto_srcs`
Starting local Bazel server and connecting to it...
INFO: Analyzed target //mediapipe_api:mediapipe_proto_srcs (42 packages loaded, 807 targets configured).
INFO: Found 1 target...
Target //mediapipe_api:mediapipe_proto_srcs up-to-date:
  bazel-bin/mediapipe_api/mediapipe_proto_srcs.zip
INFO: Elapsed time: 50.593s, Critical Path: 2.14s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
DEBUG (build.py): Unarchiving 'bazel-bin/mediapipe_api/mediapipe_proto_srcs.zip' to 'build/Scripts/Protobuf'...
INFO (build.py): Built protobuf sources
INFO (build.py): Downloading protobuf dlls...
DEBUG (build.py): Running `nuget install -o .nuget`
Feeds used:
  /Users/Administrator/.nuget/packages/
  https://api.nuget.org/v3/index.json

Restoring NuGet package Google.Protobuf.3.15.6.
Adding package 'Google.Protobuf.3.15.6' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Added package 'Google.Protobuf.3.15.6' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Restoring NuGet package System.Buffers.4.4.0.
Adding package 'System.Buffers.4.4.0' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Added package 'System.Buffers.4.4.0' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Restoring NuGet package System.Memory.4.5.3.
Adding package 'System.Memory.4.5.3' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Added package 'System.Memory.4.5.3' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Restoring NuGet package System.Runtime.CompilerServices.Unsafe.4.5.2.
Adding package 'System.Runtime.CompilerServices.Unsafe.4.5.2' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
Added package 'System.Runtime.CompilerServices.Unsafe.4.5.2' to folder '/Users/Administrator/Documents/MediaPipeSizeReduction/MediaPipeUnityPlugin/.nuget'
DEBUG (build.py): Copying '.nuget/System.Buffers.4.4.0/lib/netstandard2.0/System.Buffers.dll' to 'build/Plugins/Protobuf/System.Buffers.dll'...
DEBUG (build.py): Creating 'build/Plugins/Protobuf'...
DEBUG (build.py): Changing the mode of 'build/Plugins/Protobuf/System.Buffers.dll'...
DEBUG (build.py): Copying '.nuget/Google.Protobuf.3.15.6/lib/netstandard2.0/Google.Protobuf.dll' to 'build/Plugins/Protobuf/Google.Protobuf.dll'...
DEBUG (build.py): Changing the mode of 'build/Plugins/Protobuf/Google.Protobuf.dll'...
DEBUG (build.py): Copying '.nuget/System.Runtime.CompilerServices.Unsafe.4.5.2/lib/netstandard2.0/System.Runtime.CompilerServices.Unsafe.dll' to 'build/Plugins/Protobuf/System.Runtime.CompilerServices.Unsafe.dll'...
DEBUG (build.py): Changing the mode of 'build/Plugins/Protobuf/System.Runtime.CompilerServices.Unsafe.dll'...
DEBUG (build.py): Copying '.nuget/System.Memory.4.5.3/lib/netstandard2.0/System.Memory.dll' to 'build/Plugins/Protobuf/System.Memory.dll'...
DEBUG (build.py): Changing the mode of 'build/Plugins/Protobuf/System.Memory.dll'...
INFO (build.py): Downloaded protobuf dlls
INFO (build.py): Building resource files
DEBUG (build.py): Running `bazel build -c opt //mediapipe_api:mediapipe_assets`
INFO: Analyzed target //mediapipe_api:mediapipe_assets (18 packages loaded, 46 targets configured).
INFO: Found 1 target...
Target //mediapipe_api:mediapipe_assets up-to-date:
  bazel-bin/mediapipe_api/mediapipe_assets.zip
INFO: Elapsed time: 8.669s, Critical Path: 7.58s
INFO: 38 processes: 1 internal, 37 darwin-sandbox.
INFO: Build completed successfully, 38 total actions
DEBUG (build.py): Unarchiving 'bazel-bin/mediapipe_api/mediapipe_assets.zip' to 'build/Resources'...
INFO (build.py): Built resource files
INFO (build.py): Building native libraries for Desktop...
DEBUG (build.py): Running `bazel build -c opt --copt -DMESA_EGL_NO_X11_HEADERS --copt -DEGL_NO_X11 //mediapipe_api:mediapipe_desktop`
INFO: Build option --copt has changed, discarding analysis cache.
INFO: Analyzed target //mediapipe_api:mediapipe_desktop (129 packages loaded, 9128 targets configured).
INFO: Found 1 target...
INFO: From ProtoCompile external/com_google_mediapipe/mediapipe/calculators/image/set_alpha_calculator.pb.h:
bazel-out/darwin-opt/bin/external/com_google_protobuf/src: warning: directory does not exist.
INFO: From ProtoCompile external/com_google_mediapipe/mediapipe/calculators/image/recolor_calculator.pb.h:
bazel-out/darwin-opt/bin/external/com_google_protobuf/src: warning: directory does not exist.
INFO: From ProtoCompile external/com_google_mediapipe/mediapipe/calculators/tflite/tflite_tensors_to_segmentation_calculator.pb.h:
bazel-out/darwin-opt/bin/external/com_google_protobuf/src: warning: directory does not exist.
INFO: From ProtoCompile external/com_google_mediapipe/mediapipe/graphs/object_detection_3d/calculators/model_matrix.pb.h:
bazel-out/darwin-opt/bin/external/com_google_protobuf/src: warning: directory does not exist.
INFO: From ProtoCompile external/com_google_mediapipe/mediapipe/framework/tool/switch_container.pb.h:
bazel-out/darwin-opt/bin/external/com_google_protobuf/src: warning: directory does not exist.
ERROR: /private/var/tmp/_bazel_Administrator/a8e4317fcddf583bd86af9908b886390/external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/converters/BUILD:23:11: C++ compilation of rule '@org_tensorflow//tensorflow/lite/delegates/gpu/gl/converters:bhwc_to_phwc4' failed (Exit 1): wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 41 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 41 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
In file included from external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/converters/bhwc_to_phwc4.cc:16:
In file included from external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/converters/bhwc_to_phwc4.h:22:
In file included from external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/command_queue.h:24:
In file included from external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/gl_program.h:24:
In file included from external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/gl_shader.h:23:
external/org_tensorflow/tensorflow/lite/delegates/gpu/gl/portable_gl31.h:21:10: fatal error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
         ^~~~~~~~~~~
1 error generated.
Target //mediapipe_api:mediapipe_desktop failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 28.600s, Critical Path: 19.21s
INFO: 170 processes: 133 internal, 37 darwin-sandbox.

Admins-iMac:MediaPipeUnityPlugin Administrator$

You cannot build native libraries with GPU enabled on macOS.
https://github.com/homuler/MediaPipeUnityPlugin#platforms
Please run python build.py build --desktop cpu -v instead.

@homuler
Ran the command for CPU and it worked perfectly. Thanks.
Closing this issue.


Add params to nb-tester

Effectively allows the nb-tester script to be run against any backend. Also allows you to pass authentication and configuration directly to QiskitRuntimeService (if preferred).
Here's an example of how you can use the new changes to run a set of notebooks against test_eagle using qiskit_ibm_runtime:
test-docs-notebooks --config-path scripts/config/notebook-testing.toml --provider "qiskit_ibm_runtime" --backend "test_eagle2"

By default, --provider is set to qiskit_fake_provider, which runs the same provider code that was present in nb_tester before. By changing the provider, you can also specify "runtime_fake_provider" to use the fake_providers in qiskit_ibm_runtime.fake_provider, or "qiskit_ibm_runtime" to rely on real backends, and the credentials provided.
This shouldn't require changes in CI yet - it seems like notebook testing CI is able to complete the same number of tests as in main, although it does carry over some errors that I ran into on main too.

PR migrated to #2350 to run full CI process


Remove default use of the LowerTriangular transform, for speed reasons

Need to add a test before merge.

Actually, @alexggmatthews, what kind of test did you mention earlier? The LowerTriangular transform is automatically tested by the batch transform tester. It's also run by a specific tester that checks whether it raises the correct errors. Did you think it was important just to see if it works in combination with SVGP?

Current coverage is 99.08% (diff: 100%)

Merging #182 into master will decrease coverage by 0.19%

@@             master       #182   diff @@
==========================================
  Files            20         20
  Lines          1527       1527
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1516       1513     -3
- Misses           11         14     +3
  Partials          0          0

Powered by Codecov. Last update 23b47f5...8295cef

@markvdw  I think that should do in terms of test coverage.

@markvdw  thanks for your PR.


Cann't load the nodes

Download the zip and unzip to comfyui's custom nodes. But cann't load it when ComfyUI strated. And show nodes is missing.

This means your torch version is old, 2.4.1 at minimum should be used, 2.5.0 is recommended.

这意味着你的 torch 版本太旧，至少应该使用 2.4.1，建议使用 2.5.0。

Thx.I will upgrade the torch and try again.

This means your torch version is old, 2.4.1 at minimum should be used, 2.5.0 is recommended.

i upgrade torch 2.42. Have another problem.cann't not running.

You have old GPU? It doesn't seem compatible with this.

You have old GPU? It doesn't seem compatible with this.

2080 TI 22g.

It worked when i changed attention mode to comfy in the load model node

On 2.5.1 torch. Installed nodes and restarted still red and missing.


Partial Entity idea

Hello, I'm currently trying to create a little project based on async-graphql and while doing so, I stubbled uppon an old issue I had: how could we create PartialEntity ?
What is a Partial Entity?
Sometimes, you have an Entity, let's say you have an Article.
pub struct Article {
  pub id: Uuid,
  pub project_id: Uuid,
  pub title: String,
  pub subtitle: Option<String>,
  pub extra_data: Option<String>,
}

And you have way to get these articles, but at some point, you have a to do a call, where you have only part of the Articles data, for instance, when you do a call to get a Page, you'll be able to get some data from an Article: id, project_id, title, subtitle, but not the extra_data (they exists, but this call cannot give them to you). So in async-graphql, you re-do a call to get the actual Article entity with a dataloader for instance event if these extra_data where not requested, or you put a logic to check the Selection, and create another behaviour if there is no extra_data in the query.
What I imagine as a PartialEntity is an Entity which could have partial data, but the same methods as the Entity, in this example, if we do request the project_id from the PartialArticle fine, you get it, but when you request extra_data from this PartialArticle, it'll fetch the whole Article and hydrate the PartialArticle with the Article data.
I was wondering how to do that, I do not know how I could create a behavior which would run depending of the fields requested.
I think it could benefit async-graphql to have these kind of struct, but it's more like an open question on how we could create a structure like that.
Right now, my idea was to create something like this (but I don't like it right now):
enum PartialState<T> {
  Partial(T),
  Nothing,
}

pub struct PartialArticle {
  pub id: Uuid,
  pub project_id: PartialState<Uuid>,
  pub title: PartialState<String>,
  pub subtitle: PartialState<Option<String>>,
  pub extra_data: PartialState<Option<String>>,
  partial: bool,
}

impl PartialArticle {
  async fn get_article(&self) -> () {
    if self.partial == false {
      fetch_article_and_hydrate_self().await; // With interior mutability of the struct mb, idk yet
      self.partial = true;
    }
  }

  pub async fn project_id(&self) -> anyhow::Result<Uuid> {
    // If partial state -> unwrap or get_article & unwrap.
    ...
  }

  pub async fn entity(&self) -> Article {
    // get_article -> transform to Article
  }
}

Three questions
What do you think about it?
Do you have an idea/suggestion for it or a better way to do what I want?
Would it be a nice struct to use in async-graphql?
Thx for reading!

Sorry for the late reply.
I have encountered similar problems, so I fully understand what you want to do.
I used LookAHead to solve this problem, but I had to make an object's members all Option, which does not seem elegant enough.
PartialState looks great, and I look forward to your further attempts.🙂

I'm stuck on exactly the same problem right know. Setting all fields Option<T> was my thought too, but as you said, that's pretty ugly.

I've been thinking, could we provide the LookAHead to Dataloaders @sunli829 ? This would open way more possibilities.

Maybe we can design some API to do this better, but I still don't have a good idea how to do it.

Well if we could pass the requested fields to the dataloader, the dataloader could get only the fields that are needed and could implement caching on a field basis. That was my idea. A implementation could then check which fields are needed, look up the cache and if needed, fetch them.

I think I have a good approach which we can work out to be a solution. I'll explain and maybe create a PR tomorrow. It would require the Context in the loader function or at least the requested fields.
The basic idea is to have the fields selected in the database query based on the required fields. With postgres, this works just fine:
SELECT
            CASE WHEN $1 = true THEN email ELSE NULL END email,
            CASE WHEN $2 = true THEN first_name ELSE NULL END first_name,
            CASE WHEN $3 = true THEN last_name ELSE NULL END last_name
 FROM users
 WHERE user_id IN ($4)

with sqlx, you can then set $1-3 to true if the field is requested or to false if not. You could also check if each field is in the cache and only query for it if needed.
If you understand what I mean, you're welcome to tell me your opinion. Of course, a struct too keep track of the fields available e.g. Option or @Miaxos  idea is still needed. But at least you can implement a sexy dataloader with this. I'll provide actual code tomorrow. good night

Well, you should try to create a PR with your idea, it might be a little different of what I think of, I think I see what you want to do, and it would solved a lot of issues, some of them linked to what I want to do.
In my idea, this structure shouldn't be really tied to any async-graphql stuff and so it wouldn't be tied to a dataloader too, it's a structure which store data, and only some of it is available, and when we request some which aren't, a function to hydrate it and to transform it into the sub-structure behind it is executed.
What I would love is that if we have a function:
fn something(data: DataType) -> () {
  let a = data.a_field();
}

We could create an associated PartialType for DataType to have a PartialDataType which could be used with this function something and when this PartialDataType doesn't the A field, it would execute the function to hydrate PartialDataType and pseudo-cast it into a DataType.
I have the idea, but I didn't have any time to try implementations of this idea and I am going to vacations for two weeks, I will work on it when I return.

The main difference we have is that your idea is field based e.g.
pub struct Article {
  pub id: Uuid,
  pub project_id: Uuid,
  pub title: String,
  pub subtitle: PartialDataType<String>, // thats only a single field
  pub extra_data: PartialDataType<String>, // that too
}

This would probably needs two functions (a function for each field) to fetch the data which could be only resolved with two DataLoaders afaik. Except if there's a DataLoader for Article which keeps track of all fields requested. E.g. if a GraphQL query had subtitle and extra_data, it would request both fields in one query for all articles, selected.
So imagine a query where a user wants to list all articles they can read (e.g. they have a subscription):
Schema:
Article {
    id: ID!,
    project_id: ID!,
    title: String!,
    subtitle: String!,
    extra_data: String!
    wrtier: User!,
}

"
An object to recieve information about the current user.
"
User {
    available_articles: [Article!]!
    id: ID!,
    first_name: String!,
    last_name: String!,
    email: String!,
}

type Query {
    self: User
}

The query would look something like this:
self {
    available_articles {
        id
        title
        subtitle
        extra_data
    }
}

In a naive approach, extra_data and subtitle each had a PartialData struct with a function (your something(data: Data) function) so the resulting SQL would look something like (if you use DataLoaders like you can right know)
SELECT extra_data FROM articles WHERE id IN ($1)
SELECT subtitle FROM articles WHERE id IN ($2)

For all articles, that's two SQL queries where it could be only one.
Imagine a PartialData object that would use a DataLoader which keeps track of all fields that are requested and at the end, combines all required instances of a object along with it's PartialData fields. In the example above, the sql would only be one query no matter how many fields or articles there are (with DataLoader, including fetching the other fields of Article):
SELECT title, subtitle, extra_data FROM articles WHERE id in ($1)

In the user resolver for available_articles, you would get a user and then call loader.load_one(id) which returns a list of all Articles for the user.
A word about the query I sent yesterday
If you do this, the sql query needs to be flexible. You could achieve this by using something like the format! macro but that's a bad idea because it could lead to sql injections and if you use sqlx, you would also lose the compile time checks.
So yesterday we figured out a way to select fields only then they are needed without changing the sql query. The result is something like I sent:
SELECT
            CASE WHEN $1 = true THEN email ELSE NULL END email,
            CASE WHEN $2 = true THEN first_name ELSE NULL END first_name,
            CASE WHEN $3 = true THEN last_name ELSE NULL END last_name
 FROM users
 WHERE user_id IN ($4)

This is great, because at run time, you only provide a bool for each field to specify if you want it or not. Postgres at least will do exactly the same as if you generated a query at run time. We tested indexes which will only be used if specific fields are select and that works too.

@sunli829

I have encountered similar problems, so I fully understand what you want to do. I used LookAHead to solve this problem, but I had to make an object's members all Option, which does not seem elegant enough.

If i do this way i get no exclamation point at the end of a field in a schema. Is there a solution to mark optional-field as a  non nullable?

If i do this way i get no exclamation point at the end of a field in a schema. Is there a solution to mark optional-field as a non nullable?

Is it the same as this use case that I can't figure out how to do?
CREATE TABLE public.users (
    id integer NOT NULL,
    name text NOT NULL,
    pet_name text
);

query GetUsers {
  users {
    id
    name
  }
}

query GetUsersWithPets {
  users {
    id
    name
    pet_name
  }
}

when I query GetUsers I want a reply with this type:
    pub struct GetUsersUsers {
        pub id: Int,
        pub name: String,
    }

and when I query GetUsersWithPets I want a reply with this type:
    pub struct GetUsersWithPetsUsers {
        pub id: Int,
        pub name: String,
        pub pet_name: Option<String>,
    }

@bbigras i am not sure that i understood you correctly...
a solution for my case is to define resolves by my own
struct Struct {
  field1: Option<String>,
  field2: Option<String>,
}
[#Object]
impl Struct {
  async fn field(&self, _ctx: Context) -> String {
    // i am sure that field1 is not None
    self.field.unwrap()
  }
}

What the case are you trying to figure out?


Fix link to "why arent pipelineresources in beta"

Changes
These are the criteria that every PR should meet, please check them off as you
review them:

[n/a] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[n/a] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

/kind documentation

/lgtm
the following link is broken as well 🤪
To ease migration away from `PipelineResources`
[some types have an equivalent `Task` in the Catalog](#pipelineresource-equivalent-catalog-tasks).


Added Templates for Issues and Pull Request

Fixes #226
All the details of  this PR can be found in above linked Issue
Thank you

@taalexander would you take a look as well?


Check failed: override Global PackedFunc __tvm_set_device is already registered

I'm using tvm on Mac OSX.
It builds successfully with the latest tvm source code for libtvm_runtime.dylib.
But when running with the executable binary, the binary aborted abnormally, which says
tvm/src/runtime/registry.cc:57: Check failed: override Global PackedFunc __tvm_set_device is already registered
Stack trace returned 10 entries:
[bt] (0) 0   libtvm.dylib                        0x00000001162da176 dmlc::StackTrace() + 246
[bt] (1) 1   libtvm.dylib                        0x00000001162d9ffe dmlc::LogMessageFatal::~LogMessageFatal() + 46
[bt] (2) 2   libtvm.dylib                        0x00000001167e6bca tvm::runtime::Registry::Register(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, bool) + 250
[bt] (3) 3   libtvm.dylib                        0x00000001167daf09 _GLOBAL__sub_I_c_runtime_api.cc + 89
[bt] (4) 4   ???                                 0x0000000100164cc8 0x0 +<PHONE_NUMBER>
[bt] (5) 5   ???                                 0x0000000100164ec6 0x0 +<PHONE_NUMBER>
[bt] (6) 6   ???                                 0x00000001001600da 0x0 +<PHONE_NUMBER>
[bt] (7) 7   ???                                 0x000000010016006d 0x0 +<PHONE_NUMBER>
[bt] (8) 8   ???                                 0x000000010016006d 0x0 +<PHONE_NUMBER>
[bt] (9) 9   ???                                 0x000000010016006d 0x0 +<PHONE_NUMBER>
I've no idea why this kind of error occurs, is there anything wrong when using the tvm shared libraries?

Would you please move to https://discuss.tvm.ai/ and provide the script you were trying to run, as well as how you created the binary?

@sunstarchan hi, i meet same error, have you solved it ?

When trying to run  c++ api deploy(jni) on android with audio studio3, I am seeing three errors as listed below:
--------- beginning of crash
2019-06-25 19:54:56.505 13683-13683/com.xxxx A/libc: /usr/local/google/buildbot/src/android/ndk-r15-release/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:74: void abort_message(const char *, ...): assertion "terminating with uncaught exception of type dmlc::Error: [19:54:56] /workspace/src/runtime/registry.cc:79: Check failed: override: Global PackedFunc __tvm_set_device is already registered" failed
2019-06-25 19:54:56.505 13683-13683/com.xxxx A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 13683 (com.xxxx)
2019-06-25 19:54:56.569 13703-13703/?  A/DEBUG: Build fingerprint: 'Android/rk3288/rk3288:7.1.2/NHG47K/eric03211536:userdebug/test-keys'
2019-06-25 19:54:56.569 13703-13703/? A/DEBUG: Revision: '0'
2019-06-25 19:54:56.569 13703-13703/? A/DEBUG: ABI: 'arm'
2019-06-25 19:54:56.569 13703-13703/? A/DEBUG: pid: 13683, tid: 13683, name: com.xxxx  >>> com.xxxx <<<
2019-06-25 19:54:56.569 13703-13703/? A/DEBUG: signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
2019-06-25 19:54:56.573 13703-13703/? A/DEBUG: Abort message: '/usr/local/google/buildbot/src/android/ndk-r15-release/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:74: void abort_message(const char *, ...): assertion "terminating with uncaught exception of type dmlc::Error: [19:54:56] /workspace/src/runtime/registry.cc:79: Check failed: override: Global PackedFunc __tvm_set_device is already registered" failed'
2019-06-25 19:54:56.574 13703-13703/? A/DEBUG:     r0 00000000  r1 00003573  r2 00000006  r3 00000008
2019-06-25 19:54:56.574 13703-13703/? A/DEBUG:     r4 ab0f658c  r5 00000006  r6 ab0f6534  r7 0000010c
2019-06-25 19:54:56.574 13703-13703/? A/DEBUG:     r8 8efc0c19  r9 ab0f35f0  sl ab0e3a7b  fp bea28950
2019-06-25 19:54:56.574 13703-13703/? A/DEBUG:     ip 00000058  sp bea28440  lr aaa15857  pc aaa180c0  cpsr 60030010

@sunstarchan @yzhliu @xizi hi, have you solved it ?

As I remember, this kind of issue is caused by linking libtvm_runtime twice in the project. So please check the configuration for the project to make sure libtvm_runtime is only linked once in a place.
@dragonview @xizi

Thanks @sunstarchan . We have the similar issue when linking the libtvm_runtime in our dynamic library and try to import tvm which occurs the errors. It can be fixed by not linking libtvm_runtime when compiling our projects.

This my set TVM_LIBS = "-ltvm_topi -ltvm_runtime -ltvm -ltvm_topi -lvta_fsim -lvta_tsim"
Then I changed it to "-ltvm_topi -ltvm -ltvm_topi -lvta_fsim -lvta_tsim"
Remove "libtvm_runtime" then I can compile.

I have the same problem after building tvm from source. Where can I change the TVM_LIBS?
@ryansoq


Detox bugs reporting repro (skeletal) demo app

Describe
Quite often, we find that it is hard for us to get to the bottom of reported issues, just by relying on logs and general info. When this happens, we usually resort to explicitly asking for a light demo app, where the issue is reproduced.
While legitimate, this request is not trivial to pursue, and hence is not always fulfilled (or is addressed after a long delay). In an attempt to take measures that would make it easier for reporters to follow our request through, we can work out a mini-repo containing a light RN app capable of running tests both on Android and iOS, and with that - replace our request for a full app setup, with a far more trivial request to simply fork that mini-repo and have bug-related things bundled in.

As per implementation, I think we could reuse previously submitted demo apps: Take the original code, have it strip down to the bare minimum (1 landing screen + 1 test running on both platforms) and submit. We could definitely throw in prebaked npm scripts, etc.

I'm happy to sat that a repo for DetoxTemplate was created. We still need to add it to the doc in Detox, but everyone can fork it and add an example for his/her problem to speed the debug process


How to combine localized strings with e2e testing in Protractor?

Suppose I have
(index.html)
<h1 translate>Hello, world!</h1>

and
(scenarios.js)
describe('index', function() {
    it('should say hello', function() {
        expect($('h1').getText()).toBe('Hello, world!');
    });
});

How do I ensure that this scenario is going to succeed for every developer, regardless of whether the locale of their browser is Dutch, French, Korean or English? Is there some kind of provision for this in angular-gettext?

@jgonggrijp angular-gettext by itself does not do language detection. Which language it uses purely depends on how you initialise it with gettextCatalog.setCurrentLanguage().


repo builder: add more logging when pull-local and static-delta cmd fails

Description
The feature using OldCommits is disabled now, but we are trying to make the code working, errors are raising, and we need to know the nature. As manually I have no access to repos tar files as they have private ACL and cannot be even shared.
FIXES: THEEDGE-3009
Type of change
Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 52.29% // Head: 52.31% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (88e274d) compared to base (26ad0c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
+ Coverage   52.29%   52.31%   +0.01%
==========================================
  Files          70       70
  Lines        9857     9861       +4
==========================================
+ Hits         5155     5159       +4
  Misses       4230     4230
  Partials      472      472

Impacted Files
Coverage Δ

pkg/services/repobuilder.go
81.21% <100.00%> (+0.24%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/retest

/retest

/retest

/retest

/retest


[nice-2-have] Reference to test case if testcase has failed due to command timeout

Hi,
In case if goss.json is huge and complex it is very hard to determine which testcase failed on timeout, like:
Failures:
curl -L https://<IP_ADDRESS>/api/: exit-status:
Error: Command execution timed out (10s)
curl -L https://<IP_ADDRESS>:443/api/: stdout:
Error: Command execution timed out (10s)

Total Duration: 10.015s
Count: 219, Failed: 2

In this case it is very hard to determinate which testcase should disabled or tuned to increase timeout until the API performance is improved here, etc. It would be very helpful to show some information here: line number OE expected output OR at least the testcase number in json file, etc.
P.S. we are using template toolkit which generates goss.json for us, so we do not have IP in tt2 hard-coded to use it as reference. Also the same IP is being tested several time using different credentials, transport, ports, etc...
Feel free to resolve it if consider as unnecessary.
Tnx!

So, not 100% sure if the Golang JSON or YAML parsers allow for this to be easily done, that said.. I wonder if "title" and "meta" (arbitrary k/v)  satisfy your needs. doc
Example:
command:
  sh -c 'echo "dynamic command"; sleep 10':
    title: Ensuring that backend DB is reachable
    meta:
      test-id: 15
    exit-status: 0
    timeout: 500

Output:
$ goss validate
F

Failures:

Title: Ensuring that backend DB is reachable
Meta:
    test-id: 15
sh -c 'echo "dynamic command"; sleep 10': exit-status: Error: Command execution timed out (500ms)

Total Duration: 0.501s
Count: 1, Failed: 1

Yes, "title" and "meta" should help here. I will try them.
Consider as resolved here, I will reopen if necessary, tnx!

FYI, new goss version supports http now, you can try that instead of curl.
Example:
goss a http https://www.google.com
Adding HTTP to './goss.yaml':

https://www.google.com:
  status: 200
  allow-insecure: false
  timeout: 5000
  body: []

Fixed in v0.1.10


404 at /develop-images/build_enhancements/

I found a broken link : https://docs.docker.com/develop-images/build_enhancements/
I arrived on this page through: https://docs.docker.com/language/

@mgesreha Link Resolved. Thank you for reporting!
https://docs.docker.com/develop/develop-images/build_enhancements/


Round half even and odd

It would be nice to have the same round modes than round() PHP function:
http://php.net/manual/en/function.round.php

Buenas @josecelano ,
yep, it's an interesting idea :) . I'm working on a big refactoring of this library (currently I'm on the design phase) and I haven't many time for this feature, but if you know how to implement it, I invite you to make a pull request.
Thanks for the idea.

I do not know how to do it (I have not thougth about it). I am using this library to implement a BigMoney class:
https://github.com/mathiasverraes/money/issues/7
I am going to finish my implementation and I will try to find a solution.

I have found this library:
https://github.com/keiosweb/moneyright/blob/master/src/Math.php

@josecelano thx, I'll take a look.


Refactor/show utxos

In the show Utxos file, Instead of passing a single parameter isFrozen to toggle function, passing whole utxo data is better. As utxo's other data is need in fidelity bond section.
I am not able to review the changes due to some backend issue :(

Would also be okay if  utxo is the only argument in the callback (removing utxoIndex). But can be done in #802.. what do you think @barrytra ?

This PR is superseded by #815 and can be closed, right @barrytra ?


Some timestamps stop updating

activity.timestamp is correct. Looks like some UI stopped from updating itself (thru setInterval or setTimeout). And there are no JavaScript errors.

And after awhile, the timestamp still looks the same.

I'm wondering if there's a time frame for this fix?

Hi @galenguilbert, currently there is no time frame. Thank you for commenting, however! Customers adding their desire for these kinds of fixes puts them on our radar as something customers are looking for. I will add this to our discussion list for now. :)

Still seeing the bug as of today. Need to fix it in 4.5.


No static field fragment_container

I am getting this error suddenly
here is the log
java.lang.NoSuchFieldError: No static field fragment_contain of type I in class Lcom/android/example/cameraxbasic/R$id; or its superclasses (declaration of 'com.android.example.cameraxbasic.R$id' appears in /data/app/com.virtusync.scanningtool-BeCKdrMVet4imgvHfjLaeg==/base.apk!classes2.dex)         at com.android.example.cameraxbasic.MainWarrantActivity.onCreate(MainWarrantActivity.kt:52)

There is no MainWarrantActivity.kt and that probably should be R.id.fragment_container.

@Ezugworie I'm guessing this is for the CameraXBasic sample, correct? Are you modifying the sample in any way? Can you please provide reproduction steps for this error?

Closing due to inactivity.


Is there a way to programatically close the drawer?

This is needed for example after a server action runs, and needs to close the interaction that happened in the drawer

Yes, you can use the open prop on the Root.
https://github.com/emilkowalski/vaul?tab=readme-ov-file#root

Can be controlled with the value and onOpenChange props. Can be opened by default via the open prop.

That means that the only supported use case would be the fully controlled version, if I understand correctly?

Yeah something like this probably works best - https://www.radix-ui.com/primitives/docs/components/dialog#close-after-asynchronous-form-submission

Thanks for your help @kevinmitch14


Add Config Wizard banner image

The design just has a placeholder rectangle for a "data map". I'm guessing this meant to be a screenshot from the datamap? Or is there a design from that feature that could work instead?

Duplicate


cherry-pick: pilot: GlobalUnicastIP of a model.Proxy should be set to the 1st applicable IP address in the list (#28260)

Signed-off-by: Yaroslav Skopets<EMAIL_ADDRESS>Summary

cherry-picking https://github.com/istio/istio/pull/28260 into release-1.8

@yskopets: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.8
2a7198b64caf0bebd382eb8fcf908aff5602567f
link
/test gencheck_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio_release-1.8

@yskopets: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
2a7198b64caf0bebd382eb8fcf908aff5602567f
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio_release-1.8

@yskopets: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
2a7198b64caf0bebd382eb8fcf908aff5602567f
link
/test integ-telemetry-k8s-tests_istio_release-1.8

integ-security-k8s-tests_istio_release-1.8
2a7198b64caf0bebd382eb8fcf908aff5602567f
link
/test integ-security-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio_release-1.8


⚠ Bofrost.de has degraded performance

In 2302561, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1779 ms

Resolved: Bofrost.de performance has improved in b703ea0 after 2 hours, 29 minutes.


API v2 HEAD requests cause 500

Issue Summary
Sending a HEAD request to the wagtail v2 API results in a 500 error:
Expected view PagesAPIEndpoint to be called with a URL keyword argument named "pk". Fix your URL conf, or set the .lookup_field attribute on the view correctly.
Steps to Reproduce

Start a wagtail project with the API v2 registered.
curl -I yourserver/api/pages/ (or wherever you set the url)

Typically one wouldn't do this. I found this because the service uptimerobot sends HEAD requests by default. It's a low impact issue but still a bug.
Technical details

Python version: 3.7
Django version: 2.1
Wagtail version: 2.4
Browser version: curl 7.61.0 (x86_64-pc-linux-gnu)

Testing this quite a few years later – on Wagtial 6.3 / Django 5.1, HEAD requests seem to be working just fine. I’ll close this now, but if there is still an issue we can reopen. Tested with the bakerydemo and wagtail.org:
curl --head http://localhost:8000/api/v2/pages/
curl --verbose --head https://wagtail.org/api/v2/pages/


Battery percentage reporting

@starkillerOG ,
Can you have a look at this one ?
https://github.com/home-assistant/core/issues/76527
It was closed due to no activity, but I was wondering if there was any progress ?

Also interested on an update on this one. Sounds like there's maybe nothing that can be done but on my Dooya blinds (DM25LEU/S-1.1/28) I'm seeing ~88% on fully charged blinds and ~-25% when they are dead.

The battery percentages have already been adjusted.


programs.zsh.syntaxHighlighting: Fix default value for patterns

Motivation for this change
Commit 0925f79d561b077c40c53e3fb213df461bdf2b06 changes programs.zsh.syntaxHighlighting.patterns to use attrsets instead of lists of lists. However, the default value was not changed to match the new schema.  Building a configuration which uses the default value currently results in an error.
@Ma27 @Mic92
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thank you


Type narrowing does not work with maps and inside lambda functions

Description:
function f1() returns boolean {
    decimal sa = 10d;
    map<decimal?> m = {x: 10d};
    return m["x"] == () || m["x"] < sa;
}

function bar(decimal? num) {
    var foo = function () {
        io:println(num == () || num > 0d);
    };
}

Steps to reproduce:
Affected Versions:
2201.1.0
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Type narrowing happens only for local variables and parameters (see https://ballerina.io/spec/lang/master/#conditional_variable_type_narrowing).
In both of these cases, we can't guarantee the variable to be of the narrowed type when we get to the second expression. So type is not narrowed.


Fix generic default

BTW, the generic invocation is not supported by the Triple. Is it supported by the Triple at present? @LaurenceLiZhixin

BTW, the generic invocation is not supported by the Triple. Is it supported by the Triple at present? @LaurenceLiZhixin

Triple support generic invocation for  non-pb serialization.


integration with ionic Auth, Analytics, Deploy and Push

Hi,
I just wanted to confirm if there are any plans to adding examples of Auth, Analytics, Deploy and Push in this project?
cheers and Thank you for creating this awesome project, great resource to learn from.

Thanks for the issue. :) We've decided that we aren't going to add these services to this app at this time. The conference app has really been our way of showing off the different framework components in a "real world" app and testing how they interact. We don't want to overload this app with too much going on. We do plan on creating an Ionic 2 app in the future that showcases these services, and will revisit adding them here at a later time.


Fix for parsing AgentResourceId from JSON string

I discovered an issue when using !Sub | syntax, which results in a string of JSON instead of standard JSON. This logic to parse out the AgentResourceId from the request only worked when the Args is standard JSON and not a string of JSON.
With this update, it uses the agent_kwargs which has already been properly parsed from either the JSON or string of JSON at the beginning of the function call.
This was the issue I was going to open earlier, but I ended up figuring it out.

Btw, with this update I'm able to manage Secured SSM Parameters which aren't available directly through CFN
  ParameterClientSecret:
    Type: 'Custom::SsmParameter'
    Properties:
      ServiceToken: !ImportValue cloudformation-custom-resources-CustomResourceLambdaArn
      AgentService: ssm
      AgentType: client
      # https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ssm.html#SSM.Client.put_parameter
      AgentCreateMethod: put_parameter
      AgentUpdateMethod: put_parameter
      AgentDeleteMethod: delete_parameter
      AgentResourceId: Name
      AgentCreateArgs:
        !Sub |
          {
            "Name": "/cognito/${ServiceName}/clientsecret",
            "Value": "${UserPoolClient.ClientSecret}",
            "Type": "SecureString",
            "Overwrite": false
          }
      AgentUpdateArgs:
        !Sub |
          {
            "Name": "/cognito/${ServiceName}/clientsecret",
            "Value": "${UserPoolClient.ClientSecret}",
            "Type": "SecureString",
            "Overwrite": true
          }
      AgentDeleteArgs:
        Name: !Sub "/cognito/${ServiceName}/clientsecret"

Thank you, I've added your example as well.

ah, ty for the link. I hadn't found that project before. I'll take a look.


drain incoming data channel and socket queues before terminating SOCKS sessions

This addresses the following issue:

https://github.com/uProxy/uproxy/issues/1033

Two main changes:

wait for send() callbacks to fulfill before calling close() (this is not important for data channels, whose close() method is essentially synchronous, but is important for TCP sockets)
once a socket or data channel has closed, wait for its incoming data queue to be fully processed before terminating the session

I think the first change is clearly important. I want to describe the second change in more detail... Currently, both SocksToRtc and RtcToNet closes a SOCKS session when either:

the data channel closes
the socket closes

The problem is when there is still data remaining to be processed on either the channel's or socket's incoming queue. Now, SOCKS sessions will close when:

the data channel closes and there is no (incoming) data on the channel's queue
the socket closes and there is no (incoming) data on the socket's queue

Tested primarily against the following URL:
curl -x socks5h://localhost:9999 http://www.armoryonpark.org/css/screen.css

Currently, this fails; curl will report 10-20k of unread data. With this change, the URL loads just fine. Though I didn't dig too deeply into the server's behaviour, I suspect this applies to any server which terminates its connection to the proxy as soon as it has sent all its data (most HTTP servers seem to wait for the client to terminate their connection first).

I also filed this issue:
https://github.com/uProxy/uproxy-networking/pull/212/files

The issue you 'filed' ( https://github.com/uProxy/uproxy-networking/pull/212/files ) is not the link I think you're thinking of... :)

But I think you filed this issue: https://github.com/uProxy/uproxy/issues/1075 w.r.t. this pull request.

Oops, yes, that's the issue I was talking about :-)

Comments from the review on Reviewable.io

Fantastic!
A couple of suggestions for more tests (can be done in a followup as I'd love to see this land ASAP).
and a couple of type-tweak improvements I trust you to do.
:+1:

src/rtc-to-net/rtc-to-net.spec.ts, line 217 [r1] (raw file):
Do we also want the test for data channel queue drains before termination?

src/rtc-to-net/rtc-to-net.spec.ts, line 232 [r1] (raw file):
I'm not sure about this test... if close cleared the data queue, then it would also pass. I think it would be better to check that the promise form mockTcpConnection.dataFromSocketQueue.handle(buffer) has resolved. If the queue is cleared those promises would be rejected. Also maybe check the bytes sent?

src/rtc-to-net/rtc-to-net.ts, line 267 [r1] (raw file):
add TODO: https://github.com/uProxy/uproxy/issues/1075

src/rtc-to-net/rtc-to-net.ts, line 557 [r1] (raw file):
replace any with  { errcode :string; }

src/socks-to-rtc/socks-to-rtc.spec.ts, line 258 [r1] (raw file):
do we also want the test for tcp connection drains before termination of socks-rtc too?

src/socks-to-rtc/socks-to-rtc.ts, line 550 [r1] (raw file):
any would be better as { errcode :string; }

Comments from the review on Reviewable.io

src/rtc-to-net/rtc-to-net.spec.ts, line 217 [r1] (raw file):
I was just testing the "most important one" for each of SocksToRtc and RtcToNet since there's a bit of work adapting the test to each class, and they're in need a pretty dramatic refactoring which would make testing easier but, sure, done.

src/rtc-to-net/rtc-to-net.spec.ts, line 232 [r1] (raw file):
I'm not worried about bytes sent because we have tests for those counter(s) but, sure, we can test that the queue wasn't just cleared (since this is a white box test I was fine omitting it -- testing that the messages were handled is still no guarantee that they were sent).

src/rtc-to-net/rtc-to-net.ts, line 267 [r1] (raw file):
Done.

src/rtc-to-net/rtc-to-net.ts, line 557 [r1] (raw file):
Done.

src/socks-to-rtc/socks-to-rtc.spec.ts, line 258 [r1] (raw file):
Done.

src/socks-to-rtc/socks-to-rtc.ts, line 550 [r1] (raw file):
Done.


Size per page dropdown not working

Greetings,
I'm using version 2.5.3 and for some reason, the size per page dropdown doesn't respond; the list is there but it does nothing. One thing is that I've noticed is that on my version, the data-reactid attribute hasn't been generated but it seems that only has to do with React's version. The only thing I'm doing differently from the example is that I render the columns through a map funciton. What could be wrong?
Thank you very much

@Gothbag, sorry for lately reply...  check https://github.com/AllenFang/react-bootstrap-table/issues/710, if the problem still there, feel free to ask me anything :)


[Question] Possible to continue to see console output with playwright-azure-reporter enabled?

Hi, thank you for a great package!
When enabling playwright-azure-reporter in playwright.config.ts, the normal console output seems to be hidden/overwritten by the reporter.
Without playwright-azure-reporter configured:

With playwright-azure-reporter configured:

Is there a way to disable this behavior? Setting logging: true in the config didnt do it.

@awha86
as you can see in readme config logging is disabled by default

logging [true/false] - Enabled debug logging from reporter or not. Default: false.

And when you setup logging: true on the contrary, you enable this configuration

@alexneo2003
Thank you for the quick reply.
My point is that just having the reporter configured, even if I have enable logging or not, I don't see console output anymore:
logging disabled:

logging enabled:

playwright-azure-reporter commented out (removed) of playwright.config.ts:

what are you use as logger?

Just the basic stdout for console.log().
I am not sure if its relevant, but I have the playwright html reporter & a junit reporter configured in the project aswell:

I'm so sorry but really I don't know why it's happens.
For logs in reporter we use debug package and, mayby, it has conflict with console.log, I don't know.
I try to reproduce this issue in my own project but it doesn't reproduced

Thanks for investigating. Its not a major issue, just an annoyance.
Should I close this or keep it open?


fix compressed_page_size has the same meaning in page v1 and v2

backport #26783

Parquet with page v2 is parsed error when using other codec except snappy. Because compressed_page_size has the same meaning in page v1 and v2, it always contains the bytes of definition level, repetition level and compressed data.
Add regression test for fix_length_byte_array stored decimal type, and dictionary encoded date/datetime type.

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Switch to Yarn v3 as the package manager default

Yarn v3 has some nice innovations. I am proposing to use Yarn over NPM as the default for this repository and am sending this PR as an example of what we have implemented as a standard at our company.  We perform yarn set version berry then yarn set version 3.x because there is a bug in the stable version.

Related issues in nx which look like they should be fixed before this one can be merged: nrwl/nx#7504 and nrwl/nx#7918.
With the other changes in the recent 13.2.3 release, I couldn't figure out the spawnSync issue and related issues that occur when running the e2e tasks using affected. For now, I will be running all of the e2e jobs in sequence and not using affected for the e2e test runs.
When running the E2E with this branch, I was getting errors on the package manager install saying that the yarn command failed.

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.
/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty
Command failed: touch yarn.lock && yarn

@srleecode affected is working now that I upgraded to @nrwl/nx-cloud@next which is v13

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.
/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty Command failed: touch yarn.lock && yarn

try now... I an using yarn dlx now and touch from node

I checked out your branch, ran yarn then the affected e2e and I get this error. I get the same error running yarn e2e.
/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty Command failed: touch yarn.lock && yarn

try now... I an using yarn dlx now and touch from node

Locally it is working. However, on the CI job it failed: https://github.com/srleecode/domain/runs/4353924313?check_suite_focus=true
Command failed: node<EMAIL_ADDRESS>new proj --nx-workspace-root=/home/runner/work/domain/domain/tmp/nx-e2e --no-interactive --skip-install --collection=@nrwl/workspace --npmScope=proj --packageManager=yarn --preset=empty
Command failed: yarn dlx touch yarn.lock && yarn

closing as https://github.com/nrwl/nx/pull/7918 was closed


Document Javascript Coding Guidelines

Problem Description 🗣

Lack of Javascript Coding Guidelines

reduces efficiency of communication and pull requests
sets new contributors up to fail
increases cognitive work of working across multiple repositories

Lack of .editorconfig and browserlist
Lack of proper test Cases (in the main directory)

Laying down a test folder consisting of both e2e and unit

Moving from stylelint to prettier.

Prettier not only integrates itself not only with css but also with less,graphql,js,ts,yaml etc.
Stylelint integrates itself with styleint and jsfiddle.

Setting up dependabot to keep a track of the latest version of the dependencies.

@irmerk These are seperate issues. This issue has to be implemented into several bits and can make the repository code much organized and maintainable.

I think it would be great to create individual Issues for each of these then. It looks like 1, 2, 4, 5, and 6 should be in the TSC.

@irmerk Shall I close this issue now since they have been discussed in the TSC.


screen 4.5.0

@BrewTestBot test this please

Sorry for the delay on this one.  Merged as 450c7af7891ec5ec7672d2cd0b064c2e040cd04e.


[T2A4][F10-A2]Shi Xiyue

Ready for review

Great Effort @shixiyue in changing to inline methods to make the smelliest code ever! (Though it can be even smellier!)
Your commit message for "Refactor the code to make it worse!" could be improved to mentioning something about making the methods inline and be broken down further :) Remember, one commit per significant change!
Close PR after reading my review :)


typo: teh -> the

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nschonni thanks for the contribution! While this PR has merit, the documentation you are editing is auto-generated, therefore we can't merge this change in due to the fact that it will be overwritten the next time the build runs.
@christopheranderson - can you please take a look at this change, and see where in the Cosmos DB NPM source code the change needs to be made?

@dend not problem, I figured that would probably be the case here. It might be more a general feedback thing, but the autgenerated repos should probably have a PULL_REQUEST_TEMPLATE.md that explains that they are generated and can't be PR'd


[graphql/rpc][easy] fix min_validator_count from system parameters

Description
This PR fixes a bug where the min_validator_count was assigned the value from max_validator_count, leading to both min and max validator count fields to show the same value.
Test Plan

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

This can be probably fixed when JSON RPC is deprecated. Leaving it open for now.


Legacy removal

Description of the pull request:
Bring-your-own-polyfill is the name of the game. Removes built-in polyfills and shims. 😄
Is breaking:
API: yes

Ractive.Promise removed.

Browser support: yes.

ES5 polyfills removed.
requestAnimationFrame polyfill removed.
Promise polyfill removed.

Recommended IE version: 10
Shims/polyfills required if on a totally old browser:

ES5 shim
ES6 shim (or at least a Promise shim)
rAF polyfill

Fixes

https://github.com/ractivejs/ractive/issues/1636

Reviewers:
If you're reading this, I encourage you to do so. 😅

Big :+1: for 0.9. :clap:

So what will happen to Ractive.Promise? Will it continue to work or do we have to change code that refers to Ractive.Promise with something else?

At the moment, the PR removes Ractive.Promise in favor of (and encourage the use of) the native Promise. You will have to switch to using the native Promise, shim when necessary.

This looks like it's done and ready to merged?

Yup. It's ready. Waiting on your signal. 😄

@evs-chris When will this be applied? Dying for this speed improvement and size decrease babe.

Now. :smile:
It might not be an awful idea to put together a ractive-polyfills project that makes it easier for those stuck supporting ie9 and friends, bless 'em. We have the code sitting around, though it's now only in history.

@evs-chris They are traitors to the cause I'd say.


BUG: HOME , ABOUT, CONTACT LINKS ARE NOT WORKING IN FOOTER

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

DIRECTLY CREATE PR ... IT WILL BE ASSIGNED IN THIS ISSUE LATER
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[ ] I want to work on this issue

assign me

assign me

Bro you solve the issue and raise a PR . While raising a PR mention the issue no. and then she will merge it if no problems are occurred.


Request for comment on NoMSVC

@mcgoo Hi, which kind of error is represented by NotMVC and why exactly does it exist? Was it a workaround for a bug or limitation of vcpkg? If so, can you link the issue?
EDIT: corrected from NoMSVC to NotMSVC

NoMSVC is, as far as I can tell, a left over from the fact that this crate originally only supported building with MSVC.  Later platforms such as Linux and iOS were added later, but the code still reports "NotMSVC" if the compiler triplet setup isn't recognized.  This should probably be cleaned up to be NotYetSupportedCompiler or something similar.

It appears on line 1346 in the body of msvc_target function, which is used in the impl block of Config, on line 863 of the body of get_target_triplet function.
My concern is that I can't compile for arm64-android target of vcpkg while using x86_64-pc-windows-msvc. Issue in Rust-SDL2.

Output of vcpkg help triplet
Available architecture triplets:
vcpkg built-in triplets:
arm-uwp
arm64-windows
x64-linux
x64-osx
x64-uwp
x64-windows-static
x64-windows
x86-windows
VCPKG community triplets:
arm-android
arm-ios
arm-linux
arm-mingw-dynamic
arm-mingw-static
arm-neon-android
arm-windows-static
arm-windows
arm64-android
arm64-ios
arm64-linux
arm64-mingw-dynamic
arm64-mingw-static
arm64-osx-dynamic
arm64-osx
arm64-uwp
arm64-windows-static-md
arm64-windows-static
armv6-android
ppc64le-linux
s390x-linux
wasm32-emscripten
x64-android
x64-freebsd
x64-ios
x64-linux-dynamic
x64-linux-release
x64-mingw-dynamic
x64-mingw-static
x64-openbsd
x64-osx-dynamic
x64-osx-release
x64-windows-release
x64-windows-static-md
x86-android
x86-freebsd
x86-ios
x86-mingw-dynamic
x86-mingw-static
x86-uwp
x86-windows-static-md
x86-windows-static
x86-windows-v120

Output of rustc -Vv
rustc 1.64.0 (a55dd71d5 2022-09-19)
binary: rustc
commit-hash: a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52
commit-date: 2022-09-19
host: x86_64-pc-windows-msvc
release: 1.64.0
LLVM version: 14.0.6

I'm not sure I know vcpkg well enough to solve the problem properly. Can you assist me with it, please? What would it take to solve the issue?
@waych

I bogged down in the rewriting of TargetTriple part of the code. Making it right is difficult as hell. Kudos to the person who made it work good 'nuff.

@JohnScience yeah.. I took a try at trying to clean that code up in the past but didn't get very far before giving up myself.
As for how to compile and link arm64-android vcpkg code using x86_64-pc-windows-msvc rustup target, that doesn't seem right to me.  Wouldn't you have to be compiling with one of the targets output from rustup target list | grep android?  Something like aarch64-linux-android maybe I'm guessing would pair with arm64-android?
For what it is worth, vcpkg does not seem to offer all triplets working on all hosts.  For instance, many Windows libraries are just not possible from Linux afaict (maybe with some wine tooling and using shoehorning in MSFTs tools?), with many of even the mingw builds also just broken. I've hit this a few times where the vcpkg port really wants e.g. Powershell as a dev dependency when targeting Windows, failing on Linux hosts. YMMV.

Clarification: x86_64-pc-windows-msvc was not the rustup target but the host.