All ScrollDown and ScrollDownTo functions are broken for iOS in Xamarin.UITest version 3.2.4 - 3.2.6

When updating to Xamarin.UITest version 3.2.4 - 3.2.6 the ScrollDown and ScrollDownTo functions are not working for iOS. When using
app.ScrollDown("{element}") or app.ScrollDownTo("{element}") Xamarin.UITest will display the foilowing error:
System.Exception : Error while performing ScrollDown(Marked("{element}"), Gesture, 0.67, 500, True)
  ----> System.Exception : GestureBasedScroll: Unable to swipe in direction Down

This issue only happens on iOS and ScrollDown is working just fine for Android. Also, the version of iOS device that this was tested on to see the issue, was iOS version  14.8.
When downgrading the Xamarin.UITest version to 3.2.3 the issue no longer occurs, that I have already tested on my end.
Thank you in advance for looking into this issue.

@Moshex, hello! Have you experienced this issue with Xamarin.UITest 3.2.5?

Not sure, just saw the update. I will test and find out

Looks like this might still be an issue. I got the same system exception with UITest 3.2.5.

iOS test running Xamarin.UITest version: 3.2.5
Using TEST_CLOUD configuration override
Running in Test Cloud, on device with iOS8 or higher.
Test server version: 0.21.8........
......Scrolling down
Error while performing ScrollDown(null, Gesture, 1, 500, True)
Exception: System.Exception: GestureBasedScroll: Unable to swipe in direction Down
at Xamarin.UITest.iOS.iOSGestures.GestureBasedScroll (Xamarin.UITest.Queries.AppQuery withinQuery, Xamarin.UITest.ScrollDirection scrollDirection, System.Double swipePercentage, System.Int32 swipeSpeed, System.Boolean withInertia) [0x0012e] in <5b03a2e60ad4475bb53699724c965d8e>:0
at Xamarin.UITest.iOS.iOSGestures.Scroll (Xamarin.UITest.Queries.AppQuery withQuery, Xamarin.UITest.ScrollDirection direction, Xamarin.UITest.ScrollStrategy strategy, System.Double swipePercentage, System.Int32 swipeSpeed, System.Boolean withInertia) [0x0000a] in <5b03a2e60ad4475bb53699724c965d8e>:0
at Xamarin.UITest.SharedApp.ScrollDown (System.Double swipePercentage, System.Int32 swipeSpeed, System.Func`2[T,TResult] withinQuery, Xamarin.UITest.ScrollStrategy strategy, System.Boolean withInertia) [0x00019] in <5b03a2e60ad4475bb53699724c965d8e>:0
at Xamarin.UITest.iOS.iOSApp+<>c__DisplayClass93_0.b__0 () [0x00000] in <5b03a2e60ad4475bb53699724c965d8e>:0
at Xamarin.UITest.Utils.ErrorReporting.With (System.Action func, System.Object[] args, System.String memberName) [0x00006] in <5b03a2e60ad4475bb53699724c965d8e>:0

Can anyone else verify?

@Dmbandit @konstantin-bobkov
after my testing, yes, version 3.2.5 still has the same bug and it's not a usable version.

I found this as well.  Updated to 3.2.6 today and experimented with Android vs iOS running in App Center.  It appears the behavior of the scrolling is broken across both platforms depending on which you use, if you use string vs query, and I have not found a cross-section of where both work using the same call.
A couple examples:
app.ScrollTo("");
Android - Works
iOS - Doesn't Work
app.ScrollDownTo(c => c.Marked(""));
Android - Doesn't Work
iOS - Works
app.ScrollDown(c => c.Marked(""));
Android - Doesn't Work
iOS - Works
I'm going to play with maybe using a common function that switches depending on platform but it seems the behavior should be consistent no matter which you use.  Or, at least have one that works on both platforms.

I found this as well. Updated to 3.2.6 today and experimented with Android vs iOS running in App Center. It appears the behavior of the scrolling is broken across both platforms depending on which you use, if you use string vs query, and I have not found a cross-section of where both work using the same call. A couple examples: app.ScrollTo(""); Android - Works iOS - Doesn't Work
app.ScrollDownTo(c => c.Marked("")); Android - Doesn't Work iOS - Works
app.ScrollDown(c => c.Marked("")); Android - Doesn't Work iOS - Works
I'm going to play with maybe using a common function that switches depending on platform but it seems the behavior should be consistent no matter which you use. Or, at least have one that works on both platforms.

Thanks for that info

Threw a quick thing together this morning so I could move on if you want to use something similar.  Just going to use this temporarily until the bugs in UITest are fixed.  This is working in my tests now on Android and iOS.
public static void DoScroll(IApp app, string element)
{
if (Global.Platform == Platform.Android)
{
app.ScrollTo(element);
}
else if (Global.Platform == Platform.iOS)
{
app.ScrollDownTo(c => c.Marked(element));
}
else
{
throw new Exception("No Platform Defined");
}
}

Threw a quick thing together this morning so I could move on if you want to use something similar. Just going to use this temporarily until the bugs in UITest are fixed. This is working in my tests now on Android and iOS.
public static void DoScroll(IApp app, string element) { if (Global.Platform == Platform.Android) { app.ScrollTo(element); } else if (Global.Platform == Platform.iOS) { app.ScrollDownTo(c => c.Marked(element)); } else { throw new Exception("No Platform Defined"); } }

I was going to do something similar but now you have done the thinking on my behalf. I appreciate you!

@wakeboardfit I am not sure that is a working solution since:
app.ScrollDownTo(c => c.Marked(""));
app.ScrollDown(c => c.Marked(""));
work diffrently when scolling, both methods should work for both platforms as intended.
right now the latest usable version of the Xamrian UI test is version 3.2.3 where all the scroll-down methods work as intended.
I hope to see a fix for this issue very soon.

@Moshex Hello. I saw this line in your logs
Test server version: 0.21.8
For now the current stable version is 0.23.1.
Could you try to update it and then to use scroll methods again?

@AlexeyBudynkov in this thread what logs do you see that I posted my "Test server version: 0.21.8"? The exceptions are across the board with no relevance to the test server. also, the issue happens locally not just in app-center @AlexeyBudynkov are you saying that on version 3.2.6 all scroll down functions are working for you as intended for all ios versions?

It's not just Xamarin.UITest is responsible for some gestures.
Did you include calabash.framework in your project when you started to use Xamarin.UITest?

@Moshex Hello. I saw this line in your logs Test server version: 0.21.8 For now the current stable version is 0.23.1. Could you try to update it and then to use scroll methods again?
If you use Xamarin.Forms for your application, then you should update Test Cloud Agent nuget package. If you use a native application, then you should update calabash framework.

I can confirm this makes no difference. Still broken after updating.

I was still having some issues with iOS but I managed to get things working (on UI Test version 3.2.5) after some REPLing.
If you give the actual ListView/ScrollView that you are trying to scroll inside an AutomationId then the following works on iOS:
app.ScrollDownTo("MarkedElement", "WithinElement");
Where MarkedElement is the item you are scrolling to and WithinElement is the AutomationId of the ScrollView or ListView. I didn't know about this overload in the past and it seems to work well on iOS, even just using the item Label Text + Automation Id as strings. Maybe it will help someone.
ScrollDownTo("ScrollTargetLabel") does not work.
ScrollDownTo("ScrollTargetLabel", "ListViewAutomationId") works for me.
On Android the regular ScrollTo("ScrollTargetLabel") method seems to works fine.

@Moshex Hello. I saw this line in your logs Test server version: 0.21.8 For now the current stable version is 0.23.1. Could you try to update it and then to use scroll methods again?
If you use Xamarin.Forms for your application, then you should update Test Cloud Agent nuget package. If you use a native application, then you should update calabash framework.

I can confirm this makes no difference. Still broken after updating.

You mean, that you have updated calabash.framework in your iOS project AND Xamarin.UITest version for your test project?

@Moshex Hello. I saw this line in your logs Test server version: 0.21.8 For now the current stable version is 0.23.1. Could you try to update it and then to use scroll methods again?
If you use Xamarin.Forms for your application, then you should update Test Cloud Agent nuget package. If you use a native application, then you should update calabash framework.

I can confirm this makes no difference. Still broken after updating.

You mean, that you have updated calabash.framework in your iOS project AND Xamarin.UITest version for your test project?

Correct. ScrollDownTo is still broken as reported by this issue.

I was still having some issues with iOS but I managed to get things working (on UI Test version 3.2.5) after some REPLing. If you give the actual ListView/ScrollView that you are trying to scroll inside an AutomationId then the following works on iOS:
app.ScrollDownTo("MarkedElement", "WithinElement");
Where MarkedElement is the item you are scrolling to and WithinElement is the AutomationId of the ScrollView or ListView. I didn't know about this overload in the past and it seems to work well on iOS, even just using the item Label Text + Automation Id as strings. Maybe it will help someone.
ScrollDownTo("ScrollTargetLabel") does not work. ScrollDownTo("ScrollTargetLabel", "ListViewAutomationId") works for me.
On Android the regular ScrollTo("ScrollTargetLabel") method seems to works fine.

Actually it looks like upgrading to the latest Test Cloud Agent has broken the above also. I downgraded back to the version I was on 0.22.1 and ScrollDownTo("ScrollTargetLabel", "ListViewAutomationId") started working again.

I was still having some issues with iOS but I managed to get things working (on UI Test version 3.2.5) after some REPLing. If you give the actual ListView/ScrollView that you are trying to scroll inside an AutomationId then the following works on iOS:
app.ScrollDownTo("MarkedElement", "WithinElement");
Where MarkedElement is the item you are scrolling to and WithinElement is the AutomationId of the ScrollView or ListView. I didn't know about this overload in the past and it seems to work well on iOS, even just using the item Label Text + Automation Id as strings. Maybe it will help someone.
ScrollDownTo("ScrollTargetLabel") does not work. ScrollDownTo("ScrollTargetLabel", "ListViewAutomationId") works for me.
On Android the regular ScrollTo("ScrollTargetLabel") method seems to works fine.

Actually it looks like upgrading to the latest Test Cloud Agent has broken the above also. I downgraded back to the version I was on 0.22.1 and ScrollDownTo("ScrollTargetLabel", "ListViewAutomationId") started working again.

Thanks for your investigation, it will help to fix it

Still reproducible with the newest version.

@joshardt does version 3.2.7 still have the same issue?

@joshardt does version 3.2.7 still have the same issue?

It seemed to me like scrolling was fixed in 3.2.7.

I've tested with version 3.2.6.
For a real test I need to run the UI test on AppCenter. I for my colleague @ARomoth will do the test and let you know.

I've tested with version 3.2.6. For a real test I need to run the UI test on AppCenter. I or my colleague @ARomoth will do the test and let you know.

Tested with version 3.2.7.
The ScrollDownTo method works as expected locally and in AppCenter.

I have tested version 3.2.7, and it is working as expected on that version for me as well.

I will test on 3.2.7 as well as I was still having to use the helper method posted above depending on OS.

Hi, All. ScrollDown issue was fixed in 3.2.7 version. Please consider upgrading to this version.

Tested with version 3.2.8 and app.ScrollDown()  does not work. Nothing changes on the mobile app when method is executed.

Tested with version 3.2.8 and app.ScrollDown() works on Android when strategy is Gesture, not Auto:
app.ScrollDown(strategy:ScrollStrategy.Gesture)
have not tried the remaining strategies.

@generator87, could you please confirm that initial issue is gone?

Unfortunately I don't have any iOS device at the moment. I hope that someone else will be able to confirm that initial issue is gone.

I checked 3.2.8 and was able to remove my custom handling of scrolling between iOS and Android.  ScrollDownTo seems to be working better now.

Thanks for the suggestion.  I found, if I swap ScrollDownTo with ScrollTo, that it works on Android correctly.  So, it seems it may be a difference in how those two behave where it's either how far it scrolls or the speed or how it recognizes when something appears.  I have an issue on iOS but it seems to be a visible vs clickable on screen size.

In this case, the field is on the screen so it doesn't try to scroll but it's not on the screen enough to click it evidently: ----> System.TimeoutException : Timed out waiting for keyboard.

I have seen 2 similar issues as well in iOS. Some ideas below. With the rate the issues are being addressed, some workarounds may be in order.
With the "object present but half off the screen" issue, you may try to tap a corner or side of the control (default is to tap dead center, I believe).
"Timed out waiting for keyboard" -- MIGHT not be a scroll issue. I see this regularly and I'm still not sure how to workaround: Sometimes a textbox control will suddenly be unresponsive, the keyboard will not appear when tapping the textbox. This seems to be random as a subsequent run will most likely pass. Others have seen this too, but not sure it's logged solitarily [the following item addressed it briefly but is closed: https://github.com/microsoft/appcenter/issues/2295].

@wakeboardfit , I had an issue like the one you are experiencing however I have been seeing this issue for 2 to 3 years, and not much of a resolution. This may be an issue that does not have to do with version 3.2.8.
here is the issue I reported:
https://github.com/microsoft/appcenter/issues/2201

Yeah, def seems like there are some shortcomings in behavior.  Specifically around iOS handling of things.

Figured I'd share if anyone else needs it.  To get scrolling to work the same on Android and iOS, I'm doing the following.  This handles the different behavior in the ScrollXYZ functions as well as when the field is on screen but not actually clickable by moving the field to be fully displayed.
`public static void DoScroll(IApp app, string element, string scrollPane="")
{
if (Global.Platform == Platform.Android)
{
app.ScrollTo(element, timeout: new TimeSpan(0, 1, 0));
}
else if (Global.Platform == Platform.iOS)
{
app.ScrollDownTo(c => c.Marked(element), timeout: new TimeSpan(0, 1, 0));
}
        var content = app.Query(element).First();
        var bottomLeftYCoordinateContent = content.Rect.Y + content.Rect.Height;

        var window = app.Query(scrollPane).First();
        var bottomLeftYCoordinate = window.Rect.Y + window.Rect.Height;

        if (bottomLeftYCoordinateContent > bottomLeftYCoordinate)
        {
            app.ScrollDown();
            DoScroll(app, element, scrollPane);
        }
    }`

I don't think this issue has been resolved nor has the issue of correct scroll behavior in iOS as linked in this thread.  I still am running custom handlers for improved behavior to solve these issues.

I'm not sure if this is what you want:
appcenter version 2.10.10
I see no other agent version on the AppCenter site.

Bot bad. Issue not fixed

@MrAusnadian TestCloudAgent is the NuGet package you should be using to run the Xamarin.UITest. It should be included in your main app project. What version do you use?

Running UITest 3.2.9 and have now seen that I used to use ScrollTo in Android and that worked, now I need to use ScrollDownTo.

ScrollDown, ScrollTo, ScrollDownTo, .... and DragAndDrop, DragCoordinates .... Nothing works on iOS with Xamarin UITest 4.3.3, only Taps. Is there any solution for this?
I've tried everything and still nothing. Even simulate scrolling with Drag. All my solutions work on Android, but not on iOS in AppCenter.

Hi @rafageist,
Thank you for reporting the issue.
What iOS version do you use for testing?

@rafageist
I am not sure about version 4.3.3 since I have written up a whole report on how that version is very unstable and does not work as expected. Do you have scroll issues on version 4.3.2? if yes I am not seeing the same issue on my end. However, since it does not work on a physical device I have only tested it on an iOS simulator.

I've conducted extensive testing on AppCenter, specifically focusing on automation features, using the following iOS devices:
Apple iPhone 8 Plus
iOS Version: 16.7.4
Release Date: September 2017
Apple iPhone X
iOS Version: 16.7.4
Release Date: October 2017
Regrettably, none of the automation features—ScrollDown, ScrollTo, ScrollDownTo, DragAndDrop, DragCoordinates—seem to be functioning as expected on these iOS devices with Xamarin UITest version 4.3.3. It's noteworthy that all these features work seamlessly on Android devices.
Additionally, I have tested with various versions of Xamarin UITest, including both the 4.x.x and 3.x.x series, but unfortunately, the issue persists on iOS.
In my exploration for solutions, I also came across a note in the official documentation that mentions a bug in the iOS simulator: "Because of a bug in the iOS simulator, flick/swipe doesn't work in scroll views such as UITableView or UIScrollView." (I still wonder if AppCenter uses physical devices)
If there are any known issues or specific configurations for iOS that I might be overlooking, your guidance would be immensely appreciated. Thank you for your continued assistance.


Bug: Contributor chart not loading

Describe the bug
When I look at the 30day view for gatsby, the contributors aren't there.

Steps to reproduce

Go to https://app.opensauced.pizza/s/gatsbyjs/gatsby?range=30
See an empty chart.

Are there any errors in the browser devtools console, or any network errors in the network panel?

yes, load resource: the server responded with a status of 429 Too Many Requests

@nickytonline Happening with Reactotron today. I'm not getting any errors. My suspicion was that once the number falls below a certain point, the graph isn't generated. Once I go to 90 days, it works. However, when I looked at our intro repo, we had 10 contributors -- the same as reactotron -- and it generates.


Onem 22659 firebolt deinitialization flow sprint 2201

[ONEM-20942] notification locking separated from main lock
[ONEM-22659] Firebolt Media Player deinitialization flow and bugfixes
(1) New deinitialization flow - similar to the one that was proposed for OCDM
(2) Bugfixes - issues on plugin deinitialization/create stream/release stream

FireboltMediaPlayer::MediaStreamProxy::Release() invokes Unregister and then relase
explict Release for MediaStream in FireboltMediaPlayer::Deinitialize
FireboltMediaPlayer::create do not AddRef if create is invoked second time for the equal stream id
delete mediaStream object after Release in FireboltMediaPlayer::release
double Release() removed in AampMediaStream::Unregister

and ONEM-20942 previous cherry-pick reformating

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-2861

Hi @mikolaj-staworzynski-red ,
Can you please provide the detailed test procedure for this PR?

Hi @pradeeptakdas not 100% sure what you are asking for. For me test procedure could be the following verification - using build with aamp/FireboltMediaPlayer plugin:
(1) Activate FireboltMediaPlayer plugin in cotroller
(2) Do playback session (wscat, example for clear content):
`wscat -c <IP_ADDRESS>:9998/jsonrpc -s 'notification'
Connected (press CTRL+C to quit)

{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.create", "params": { "id": "MyIpPlayer"  }}
< {"jsonrpc":"2.0","id":1,"result":{"success":true}}
{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.register", "params": { "event": "playbackStarted"  }}
< {"jsonrpc":"2.0","id":1,"result":0}
{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.register", "params": { "event": "playbackStateChanged"  }}
< {"jsonrpc":"2.0","id":1,"result":0}
{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.register", "params": { "event": "playbackProgressUpdate"  }}
< {"jsonrpc":"2.0","id":1,"result":0}
{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.register", "params": { "event": "bufferingChanged"  }}
< {"jsonrpc":"2.0","id":1,"result":0}
{"jsonrpc": "2.0", "id": 1,  "method": "org.rdk.FireboltMediaPlayer.1.register", "params": { "event": "playbackSpeedChanged"  }}
< {"jsonrpc":"2.0","id":1,"result":0}
{"jsonrpc": "2.0", "id": 3,  "method": "org.rdk.FireboltMediaPlayer.1.load", "params": { "id": "MyIpPlayer", "url":"http://download.tsi.telecom-paristech.fr/gpac/DASH_CONFORMANCE/TelecomParisTech/mp4-live/mp4-live-mpd-AV-NBS.mpd"  }}
< {"jsonrpc":"2.0","id":3,"result":{"success":true}}
< {"jsonrpc":"2.0","method":"playbackStateChanged","params":{"MyIpPlayer":{"state":1}}}
< {"jsonrpc":"2.0","method":"playbackStateChanged","params":{"MyIpPlayer":{"state":2}}}
< {"jsonrpc":"2.0","method":"playbackStateChanged","params":{"MyIpPlayer":{"state":3}}}
< {"jsonrpc":"2.0","method":"playbackStateChanged","params":{"MyIpPlayer":{"state":4}}}
< {"jsonrpc":"2.0","method":"playbackStateChanged","params":{"MyIpPlayer":{"state":8}}}
< {"jsonrpc":"2.0","method":"playbackStarted","params":{"MyIpPlayer":{}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":0,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":1040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":2040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":3040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":4040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":5040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
< {"jsonrpc":"2.0","method":"playbackProgressUpdate","params":{"MyIpPlayer":{"durationMiliseconds":600000,"positionMiliseconds":6040,"playbackSpeed":1,"startMiliseconds":0,"endMiliseconds":600000}}}
`


'update' action not modifying 'id' of cloned elements.

In the initial setup, Clone ids have '-clone' appended to them, but when you run an 'update' on the responsive table, any Id's are duplicated.

You cells in tbody and tfoot have ids? I'll push a fix :)


Remove workaround of weight 0 test for Istio

Istio had an issue for weight 0 handling as https://github.com/istio/istio/issues/31745
but it was fixed now.
This patch drops the workaround.
/cc @ZhiminXiang

/cc @markusthoemmes @ZhiminXiang
Could you please take a look?


Raven runs Raven on a cluster

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #683
What are the significant changes in functionality due to this change request?

Changes the default library activation scripts
Increases comment and library environment verbosity
Changed directory behavior of cluster runs to mirror local runs
Added test to confirm RrR with conversion module works on cluster runs

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

Job Test linux on 6ce1346 : invalidated by @PaulTalbot-INL
unexpected "make" fail

All jobs on 6ce1346 : invalidated by @PaulTalbot-INL
CIVET updates via #668

Job Test mac on 1cd38d2 : invalidated by @PaulTalbot-INL
unusual build error

Job Test mac on 1cd38d2 : invalidated by @PaulTalbot-INL
two instances of civet were running in same environment

Check list passed...
Issue closure list passed...
Merging...


Enhancement request for Line-Peity

I played a bit around with the line-charts to be able to show incoming- and outgoing traffic in one chart. This could easily be done by visualizing the 2nd data list in a 2nd line-chart and multiplying it by -1.

Unfortunately, the scalings of the line-charts are independent from each other - as you can see in the little picture. Does anyone see a way to get around this issue?

There's a min/max option http://benpickles.github.io/peity/#line-charts, would this fix things?

I fiddled around with min/max for some time but the independent change of scaling in the 2 graphs didn't disappear. Next week I will take sometime to dive deeper into this. Thanks for your reply anyway and thanks for this small but cool tool!!

@JuergenWeber in case it helps, I've recently done something very similar to this by setting the height of the two charts to be different (then messing with the alignment and position as needed). The relative height of each series is it's maximum value divided by the the sum of the maximum values of both series.
In case it's not clear what I mean, here's a contrived example:
line_a_data = [1,2,3,4,5,6]
line_b_data = [1,2,2,3,3,4]
max_a = 6
max_b = 4
height_a = max_a/(max_a+maxb) = 8/(6+4) = 60%
height_b = max_b/(max_a+maxb) = 4/(6+4) = 40%

Here's an example of the result as I'm using it:

Alternatively, I think you can use the min and max options for a similar result, with the difference that the graphs will be the same height so some vertical space is unused by the one with the smaller values (which is why this didn't fit my needs - I wanted all available vertical space filling). Do this by finding the maximum single value across both data sets (6 in the example above, and I'm calling this biggestvalue in the below) then do the following:

positive graph:

max = biggestvalue
min = 0

negative graph

max = 0
min= -biggestvalue


PointSetDist rendering is wrong in some cases

On the left bottom, there's a curve for some reason. It should be flat.

I'm pretty sure this is a numeric bug, but am not sure.

It's returning a reasonable result now.
a = pow(normal(5,2),1)
a


Add custom chain id in --chain custom file

Describe the feature
Trying to run localnet node with --chain ./mainnet.json
Got mainnet.json from https://github.com/paradigmxyz/reth/blob/main/crates/primitives/res/genesis/mainnet.json
Added my own wallet with some balance to alloc section
Got error: Genesis hash mismatch: expected 0x1d47…8d90, got 0xd4e5…8fa3
Suppose there is some hardcoded hash for mainnet.
Please add ability to describe custom chain id in mainnet.json file to spin up own localnet
Additional context
No response

@manylov This is not because of the chain ID, it is because the state root no longer matches. The state root for mainnet.json can be found here:
https://github.com/paradigmxyz/reth/blob/7cc69d52c6017eeb4348c824a9f5369400e331d1/crates/primitives/res/genesis/mainnet.json#L9
In order for a custom version to work, you would have to recalculate the state root and update it in the file you are passing in.

@onbjerg how should Maksim generate the state root himself? Should we do the state root calculation for the user for any json file they load? I thought we already do that for the known genesis files.

Upon an extra look, it seems like we do generate state roots on the fly, so it is just that there was an existing database for another chain present.


Export needs to use single Relativizer for all parts of the archive

Rationale
Fixes exports of samples and protocol applications with material inputs which are saved by separated savers.
Related Pull Requests

Changes

Is it OK to always use LSIDRelativizer.FOLDER_RELATIVE?

This looks good. Did you make changes to LSIDRelativizer or just move it? I'm assuming the latter but I can't easily tell in the diff.

Just moved it to make it visible to FolderaExportContext.

I tested this locally, but ran into the same issue that was reported, so I'm not sure what is going wrong here.


Fix containment Y-position when contain is true and pan-zoom is scaled in or out

We noticed an issue when we used this great library, where if contain: true, the containment dimensions are invalid in case of zoom in/out.
We found a similar issue opened with an excellent example.
Also, the issue is visible in your "Containment within the parent element" demo.

Thanks for the PR! 😃
However, I'm concerned that the X-position code isn't getting the same changes. Why does this only affect the Y-position?

@timmywil I think X-Position has some issues as well. Unfortunately I didn't take a look at it yet but from general testing I can see a bunch of issues.
I just pushed another fix:

Add a handle to invert, and automatic containment.
Handle container border.

@timmywil updated the source code to support x-axis position. Please take a look.
I think the code handles this but I don't know the actual cases that this code was written for:
if (this.$parent.css('textAlign') !== 'center' || $.css(this.elem, 'display') !== 'inline') ...

Also, what's the issue with Node 6 (travis-ci failed because of that)?

I'm using this patch now. Latest version had this bug, so I was using an older one (that had another bug), so now I've got everything working at once. Please pull :man_dancing:

@timmywil if the test fixed, will you merge this?


markdown special symbols in commit description should be escaped

The commit messages are initially in text, so rendering them as Markdown can cause errors.
To reproduce, in node, do:
$ changelog-maker --start-ref=9eddaebb --end-ref=9eddaebb
* [[`9eddaebb79`](https://github.com/nodejs/node/commit/9eddaebb79)] - **assert**: remove unnecessary use of __proto__ (Nathan Rajlich)

If a changelog includes __proto__, we don't want it to render as «proto», we want to render it as «__proto__» or «__proto__». Without knowing more if that is code block or not, it would make sense to just escape some symbols like `_*~\, prefixing those with \.
Refs: nodejs/node#a58b48bc3bc, https://github.com/nodejs/node/pull/7637, https://github.com/nodejs/node/pull/12756#discussion_r114107415.

Hi folks! 👋
Shameless plug, but maybe remark can help here, as it automatically deals with escapes and stuff! Here’s an example of how it could look, where a readme is generated from a package.json in a monorepo.
Let me know if that’s of interest!

BUMP to this
This actually broke CI today as it broke the markdown linter
https://github.com/nodejs/node/pull/18767

fixed in #52, pls :+1:


Add build and deploy mechanism

It would be nice to have a Chocolatey package for Windows. 😉
(I've moved back to Visual Studio 2019 from Visual Studio Code, so I'm more often in Windows than WSL.)

@gitfool moving the chocolatey ask to another issue to track it separately!


Control Nav / ItemIconOnly not work

ItemIconOnly - Do not show the text label—only the icon
I try to use boolean value and string value, but Text show permanently.

Having same issue as described. Has there been any movement on resolution?

Same here. Using the Fluent Icon 1.022 and I cannot display the Text within the Action Button.

Same here... Any ETA on the fix?
Thx


GBT TOAs for CHIME-observed pulsars

I've added a batch of pulsars for which we have archival TOAs. The majority of these are data that were included under the AGBT13B-290 project code.

At @swiggumj's suggestion, i added the 820 MHz standard profiles for some of the pulsars. Eventually I'll get them all in - these are just the ones that i had made previously.

I know CHIME conventions are a bit different, but can you use 4-digit Dec names for files added here? Otherwise looks good, I think.

I know CHIME conventions are a bit different, but can you use 4-digit Dec names for files added here? Otherwise looks good, I think.

sure, I can do that. i think some of the RAs will be slightly different than those in the CHIME repo as well, though I did update my par file PSRJ lines to reflect their timing positions.


Please document the enums

Some of the enum types are not clear. Like, what is the difference between Circular, Reflect, and Replicate?
If the repo is stable, I'd just apply the following macros to it and document it fully.
#![warn(missing_docs)]
#![warn(clippy::missing_docs_in_private_items)]

Thank you for your attention to this project, I'm working hard on a new version with incompatible interface.
Therefore, if you wish, you can add these macros to this repo after a version update.
Best wishes!

The new version(0.3.0) has done, feel free to document it if you still have interest.
And these enums are aligned with PyTorch's conv2d:https://pytorch.org/docs/stable/generated/torch.nn.Conv2d.html

The differences between Circular, Reflect and Replicate are, if I understood correctly:
Let's assume 12345 as the signal to convolute (5 elements: 1,2,3,4,5)

Circular:  12345[12345]12345
Reflect: 5432[12345]4321
Replicate: 1111[12345]5555

For this, you need to imagine that you're accessing an idx that goes from -kernel_half_len to signal_len + kernel_half_len. So for a signal of size 10 and a kernel of 5, you'll be accessing the signal from -2..11; so the problem is, what values do you put there.
Circular assumes the signal is circular, that follows idx % len, so when it ends, it starts over.
Reflect makes a mirror reflection after the end and before the beginning. So for idx<0 it will read -idx. For idx>=len, it will access len-idx%len-1 (more or less, my math here is lacking)
Replicate just takes the closest value: idx.clamp(0, len-1)

I have read your email. If possible, you can directly submit a PR regarding the documentation, and I would be happy to merge it into the master branch.

Done. See https://github.com/TYPEmber/ndarray-conv/pull/4

I will make some more modifications and release a new version. Thank you for your contribution to the documentation.


jsonpickle returns a  object without error or warning when a class is not instantiable because a module it uses is not found.

Greetings!
I use jsonpickle to persist a class to be transported for a Spark job.  In that environment, I have tried to keep in parity with modules used vs modules needing to be transported and added to the PYTHONPATH vs modules available within the spark environment on the executors/workers.
It works! Nice! But ...
As I was testing this flow - I found that one of my test cases was failing with a strange error:
The pickled class' JSON looks like this:
{'py/object': 'smoke.test.PersistSampleToLake', '_extra_kwargs': {'rows': '10'}}

And when attempting to read the jsonpickle -- it didn't complain or error out:
2020-06-22,17:31:08.195 INFO {spark_driver} [<module>] Spark-Driver read pickled class <class 'dict'>

However it wasn't the class I thought it was:
2020-06-22,17:31:08.195 INFO {spark_driver} [<module>] Executing dict.execute_in_spark()
Traceback (most recent call last):
  File "spark_driver.py", line 32, in <module>
    runner.execute_in_spark()
AttributeError: 'dict' object has no attribute 'execute_in_spark'

Note that the class it loaded was returned as a <dict> - not my class "smoke.test.PersistSampleToLake" which DOES have an "execute_in_spark()" function.
In triaging this - I found that there was a module "sklearn" which was being utilized by the author in this case, that wasn't present on the executor / worker machines.  Seems fair that it can't decode a class that is referencing something the pickler can't see.  Quite fair.
What I expected:
XXXXXError - attempting to decode a class using a module we can't find "sklearn"
What I received:
No Warning
No Error
a  object containing my pickle.
Can we enhance the error reporting portion of this tool to be a little more vocal about actual ERRORS which will stop the parsing and just hand you a dict?
I spent hours trying to find this one - where a single 1 line logging.warn() would have helped immensely.  If this warning / logging IS supposed to be happening, and I just don't see them - can you illuminate me what the appropriate debugging strategy is when you receive a <dict> instead of your expected class?
Thanks!
P

I agree and was similarly confused for awhile when this happened.  I've taken the approach now of asserting that the result is never a dictionary

Adding an errors='ignore' parameter to decode(...) seems like it would help this use case out.  It seems like it'd be relatively straightforward, too.  I can imagine supporting three values for the errors parameter: {ignore,strict,warn}.  ignore is what it does today, and can be the default.
Right now _restore_object() and _restore_type() both notice that loadclass(...) returns None and they throw theirs hands up and return the original dict when that happens.
When in the errors='warn' mode they can keep the same behavior and issue a warning.  When in the errors='strict' mode they could raise a ValueError exception instead.
I am suggesting {ignore,warn,strict} since the ignore and strict values are similar to string.decode(..., errors='strict') string API.
Not being able to load a class probably catches most of the use cases where this comes up, so the initial implementation could focus on that aspect, but it'd also leave the door open to expand it to other code paths as they come up.
What do you think?

Duplicate of #190


Could we get a var to go with val please?

Migrated from Google Code (issue 599)

I would like to, kindly, ask you guy to give another chance to var. All arguments pointed here was pretty valid. Even though reinierz has pointed many caveats and issues regarding this, var would be a nice improvement that Lombok could introduce to their users.

I'm pretty sure that 'var' instead of 'val' is going to result in mischaracterising the types of your expressions when glancing at code, where 'val' mostly avoids it.

I'm also sure that the same problem could happen on Scala, Kotlin and Groovy (def). Who have designed a code that uses var should keep in mind that it could happen. But, whom those a have good designed code would be greatly benefited with features. When people talk about var, the first think that comes up to me is capability to write a code like this:
// this is just an exemple
public Item chooseBetweenThings() {
    var item = Defaults.ITEM;
    if ( somethingComesUp ){
        item = new Item();
    }
    return item;
}

But most of time, we could avoid the verbosity that the Java Generics imposes on code design:
// the bellow code
List<Something<Generic>> list = new ArrayList<>();
// could be turned into
var list = new ArrayList<Something<Generic>>();

It starts to make more sense when you have something like this:
public DTO convertToDTO( VO vo ){
    List<VOItem<B>> originalItems = vo.subItems();
    List<DTOItemB> items = new ArrayList<>;

    for ( VOItem<B> originalItem : originalItems ){
        DTOItemB item = DTOItemB.from( originalItem );
        items.add( item );
    }

   return new DTO( items );
}

The above code become more clear if it would be something like this
public DTO convertToDTO( VO vo ){
    var originalItems = vo.subItems();
    val items = new ArrayList<DTOItemB>;

    for ( val originalItem : originalItems ){
        var item = DTOItemB.from( originalItem );
        items.add( item );
    }

   return new DTO( items );
}

Is there any chances that var could be reconsidered?
Note that I'm arguing that the issues that was pointed out by you guys does not make sense. But arguing that, besides the issues that it could led, we still have benefits  by using var.


Add a dialect option and introduce asciidoc

Add the ability to generate changelog with other dialect than markdown and introduce asciidoc dialect.

Closing for a more generic solution #22

Please checkout the rewrite on the master branch and see if the problem still exists. Thanks.


Make Zulip's open graph preview implementation production-ready

There are a few things we need to do here:

We should write some tooling to make it really easy to test a new URL in a reliable way.  Right now, the caching-in-database strategy we have (which is great for production) makes life difficult for re-testing one's work in development.  Options include moving to an in-memory cache or something in development (so that each code change flushes the cache) and/or building a bit of a special-purpose tool (management command or something) that one can paste a URL into and get back out what headers/data we extracted from the target page.
The core logic in get_link_embed_data and the things it calls is poorly designed.  If we got all the data we needed from get_oembed_data, we should declare victory, rather than querying the other lower-quality sources (since it's a waste of time).
We might end up downloading a target file multiple times

Once those are done, we should do some testing (e.g. sending 1000 URLs into the tool)

@zulipbot claim

@zulipbot claim

Yes, I am. See #12250

I think a bulk of the work for this has been done, and we can close this issue. Any follow up things can come in new issues. #4645 has some good ideas for follow-up things to do.
@timabbott Please re-open if you think shouldn't be closed yet.

Sounds good!


Compactor: Add tracing support

Fixes #4832

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Added tracing support for the various compaction steps(similar to Querier).
Verification
Tested locally using Jaeger.

lgtm! restarting failed jobs and we can merge :))

Thanks for the reviews @matej-g @squat !


Implement a retry policy when deploying site

Is your feature request related to a problem? Please describe.
When deploying a site using the CLI (netlify deploy), I got the following error:
Deploy path: /home/vsts/work/1/netlify/netlify
Deploying to main site URL...
- Hashing files...
✔ Finished hashing 3953 files
- CDN diffing files...
✔ CDN requesting 31 files
- Uploading 31 files
✔ Finished uploading 31 assets
- Waiting for deploy to go live...
 ›   Warning:
 ›   {
 ›     "message": "request to https://api.netlify.com/api/v1/sites/xxx
 ›   xxx/deploys/xxx failed, reason:
 ›   Client network socket disconnected before secure TLS connection was
 ›   established",
 ›     "type": "system",
 ›     "errno": "ECONNRESET",
 ›     "code": "ECONNRESET",
 ›     "name": "FetchError",
 ›     "url": "https://api.netlify.com/api/v1/sites/xxx/deploys/xxx",
 ›     "data": {
 ›       "method": "GET",
 ›       "headers": {
 ›         "User-agent": "netlify/js-client",
 ›         "accept": "application/json",
 ›         "Authorization": "Bearer ***"
 ›       }
 ›     }

FetchError: request to https://api.netlify.com/api/v1/sites/xxx/deploys/xxx failed, reason:
    Client network socket disconnected before secure TLS connection was
    established
    Code: ECONNRESET

Describe the solution you'd like
I think the client should retry the call when this looks like a transient error, and actually raise an error only after a few attempts.
Describe alternatives you've considered
Handling the exit code and retry manually. However, this would re-execute the previous steps (hashing + uploading), so not great.
Can you submit a pull request?
No.

Thanks @meziantou, adding some context to this - it should be implemented in the js-client:
https://github.com/netlify/js-client/blob/960089a289288233bd2a17fcbd8ab4730ca49135/src/deploy/index.js#L101
or be a part of https://github.com/netlify/js-client/issues/157

The links seems specific to the deploy command. I think this behavior should be implemented for any http calls as long as it is a transient error.

think this behavior should be implemented for any http calls as long as it is a transient error.

Do you mind updating the title of the issue to reflect that?


window.onhashchange is not being raised by navigating through hash links

Version
4.2.0
Test Case
<Link to="/#top" />
Steps to reproduce

Attach a handler to the browser window's "hashchange" event
Click on the link

Expected Behavior
The "hashchange" event should fire.
Actual Behavior
The "hashchange" event is not fired.

These aren't hash change events. This is using history.pushState under the hood. If you need to change the hash, just use a normal <a> tag.


[WIP] Add smoke tests for events

Working towards adding smoke tests that will check for an index being created in ElasticSearch.

 Create test for events in smoketest


Parameters: [sceneId, region, projectName, url] must have values

Note: If your issue/bug is regarding the AWS Amplify Console service, please log it in the
Amplify Console GitHub Issue Tracker

Describe the bug
When trying to remove an XR resource. Failed, and the CLI error message is
Parameters: [sceneId, region, projectName, url] must have values

Amplify CLI Version
4.10.0
To Reproduce
amplify init
amplify add auth
amplify push
# add two xr
amplify add xr
amplify add xr
# remove one xr resource
amplify remove xr

Expected behavior
Expected the resource XR can be removed.
Screenshots

Desktop (please complete the following information):

OS: MAC
Node Version. v12.13.1

@JoeShi can you check your <project-path>/amplify/.config/local-env-info.json and check your projectPath key and see if it's correct?


double-beep: Watch websitedesignstudio.com

double-beep requests the watch of the watch_keyword websitedesignstudio\.com. See the MS search here and the Stack Exchange search here.

websitedesignstudio\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Suraj Rao in Charcoal HQ


MotorcycleFlagEncoder: Copy&Paste Issue in defineWayBits()

Hi,
I just found a minor Copy Paste Issue (https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/routing/util/MotorcycleFlagEncoder.java#L131)
Should be probably: shift += priorityWayEncoder.getBits();
This changed the priorities for motorcycle routes and therefore the defined prefer/avoid sets were probably not calculated correctly.

Thanks a lot, already merged! There should be only a problem before IF speedBits<3, so the default should be fine. Or do you have a failing unit test or real life scenario found which runs fine now?

I changed several things, including the copy&paste issue and afterwards my route was way better. I just checked and it seems that it had to do something with my weighting and not with the priorities itself.


OPCT-192: Automatically create changelog by release

https://issues.redhat.com/browse/OPCT-192
This PR introduces the action plugin to generate the changelog for each release.

ready for review after our meeting today. ptal?
/assign @rvanderp3 @faermanj

/lgtm
/approve


New glue vernacular command

CertiCoq Generate Glue -file "filename" [nat, list, bool].

creates filename.c and filename.h with the glue code for the types listed above. It also works with programs if the user wants to use it that way:
CertiCoq Generate Glue -file "filename" [negb].

This command creates files that have glue code for the bool type.
The CertiCoq Compile command still creates glue.*.{c,h} files automatically for compiled programs, I'm assuming @zoep doesn't want that, but I wanted to check before I delete that and fix the tests accordingly, hence I didn't push into clean automatically and created a PR instead.
(sorry about the trailing whitespace changes, my editor changed that automatically)

Awesome, thanks!


Need to add content for StateMod code example

Content Suggestion
Need to add section for StateMod code.

Add initial content for StateMod code example.


Added remaining events.

Fixes #506
Added remaining past events in this fix!

LGTM, thanks for the fixes!


WIP: Add area/metering label.

Signed-off-by: Rao Yunkun<EMAIL_ADDRESS>

/cc LinuxSuRen

Currently metering related repos are as follows in my opinion:

kubesphere/kubesphere
kubesphere/console
kubesphere/ks-installer
kubesphere/community
kubesphere/website

@LinuxSuRen can we add metering labels for above repos currently, and add more  repos when it's needed? If it's ok, I will update this pr.

I prefer adding them to this PR.

got it

Not only this repository kubesphere/kubesphere needs this label. For example: console, ks-installer, website.
And I'm wondering if you can post a screenshot to show the color of this label.

Yeah, got it.

/cc zryfish

/approve


add offset feature to img object

@kisvegabor Please review.

Thank you @ali-rostami!
It looks good!
Just two things:

void lv_img_set_offset(lv_obj_t *img, lv_coord_t x_offset, , lv_coord_t y_offset) would be easier to use or the user.
Please add lv_img_set_offset_x and lv_img_set_offset_y functions too.

so how is it now?

Thanks for the update!

Please add lv_img_get_offset_x and lv_img_get_offset_y functions too.

So please add these functions too.

I added.

I don't see new commits? Have you pushed it?

I didn't push them with a separate commit. they are added with the last commit.
these 2 functions are defined below lv_img_set_offset.
Am I missed anything?

Please add lv_img_get_offset_x and lv_img_get_offset_y functions too.

I didn't push them with a separate commit. they are added with the last commit.
these 2 functions are defined below lv_img_set_offset.

I meant the GET functions :)
I've pushed a minor fix to invalidate the image when the offset changes.

Oops, my mistake.
OK, I will add them soon.

Added.
So Is there anything more?

Merged, thank you very much! :+1:
I've tested like this:

@kisvegabor @ali-rostami Looks good!

I meant the GET functions :)

Wow, even I didn't notice that you said get instead of set.

Very good effect :clap:

Wow, even I didn't notice that you said get instead of set.

I really should emphasize it more. I'll next time!


ESPNOW stops receiving when ESP32-S3 in STA mode connects to WiFi AP  (AEGHB-94)

I created a minimalist code to show the issue. Yes I disabled power saving and it is not about setting the channel on the sender. I took the new channel that was set by the AP of my router and put it in the sender. Then the espnow stops arriving once the esp is connected to AP. I even made a sender that keeps sending over all WiFi channels. You can use your sender example and then my code on the receiver to witness the issue.
IDF 5.0 and 5.0.1
/*
   This example shows how to use ESPNOW.
   Prepare two device, one for sending ESPNOW data and another for receiving
   ESPNOW data.
*/
#include <stdlib.h>
#include "nvs_flash.h"
#include "esp_random.h"
#include "esp_event.h"
#include "esp_netif.h"
#include "esp_wifi.h"
#include "esp_log.h"
#include "esp_mac.h"
#include "esp_now.h"

static const char *TAG = "espnow_example";

static void wifi_event_handler(void* arg, esp_event_base_t event_base,int32_t event_id, void* event_data){
    if (event_base == WIFI_EVENT && event_id == WIFI_EVENT_STA_START) {
      esp_wifi_connect(); // <------ 2- comment this line to get ESPNOW to work, uncomment to break ESPNOW. ( Sender is using the new channel yes)
    }
}
static void example_wifi_init(void)
{
    ESP_ERROR_CHECK(esp_netif_init());
    ESP_ERROR_CHECK(esp_event_loop_create_default());
    wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
    ESP_ERROR_CHECK( esp_wifi_init(&cfg) );
    ESP_ERROR_CHECK(esp_event_handler_instance_register(WIFI_EVENT,ESP_EVENT_ANY_ID, &wifi_event_handler, NULL, NULL));
    ESP_ERROR_CHECK( esp_wifi_set_storage(WIFI_STORAGE_RAM) );
    esp_wifi_set_ps(WIFI_PS_NONE);// <------ it is set
    ESP_ERROR_CHECK( esp_wifi_set_mode(WIFI_MODE_STA) );

    wifi_config_t wifi_config = {
      .sta = {
          .ssid = "", // <------ 1- set your AP so esp can connect to
            .password = "",
          .sae_pwe_h2e = WPA3_SAE_PWE_UNSPECIFIED,
      },
    };

    ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &wifi_config));
    ESP_ERROR_CHECK( esp_wifi_start());

}

static void example_espnow_send_cb(const uint8_t *mac_addr, esp_now_send_status_t status)
{

}

static void example_espnow_recv_cb(const esp_now_recv_info_t *info, const uint8_t *data, int len)
{
    ESP_LOGE(TAG, "Got ESPNOW msg");

}

static esp_err_t example_espnow_init(void)
{
    ESP_ERROR_CHECK( esp_now_init() );
    ESP_ERROR_CHECK( esp_now_register_send_cb(example_espnow_send_cb) );
    ESP_ERROR_CHECK( esp_now_register_recv_cb(example_espnow_recv_cb) );
    /* Set primary master key. Disable in sender for simplicity, even though it does not matter for this bug */
    //ESP_ERROR_CHECK( esp_now_set_pmk((uint8_t *)CONFIG_ESPNOW_PMK) );

    return ESP_OK;
}

void app_main(void)
{
    esp_err_t ret = nvs_flash_init();
    if (ret == ESP_ERR_NVS_NO_FREE_PAGES || ret == ESP_ERR_NVS_NEW_VERSION_FOUND) {
        ESP_ERROR_CHECK( nvs_flash_erase() );
        ret = nvs_flash_init();
    }
    ESP_ERROR_CHECK( ret );

    example_wifi_init();
    example_espnow_init();

}

@ramiws Did you check the receiver's channel when it connected with the AP, Is it the same with the sender?

@ramiws Did you check the receiver's channel when it connected with the AP, Is it the same with the sender?

Yes of course. I tried the following:
1- I look at what channel the receiver is now on after connecting to the AP, I copy it to the sender. Nothing comes.
2- I made a sender that try over all the WiFi channels so no matter what receiver is on, something should arrive. It works and it does arrive, until connected to WiFi. It stops.
3- I forced the AP to be on channel 1 and everything on channel 1.  Messages come normally, till it connects to WiFi and still the channel is 1.
So please try code on IDF 5.0 or 5.0.1
Use this for sender and receiver
https://github.com/espressif/esp-idf/tree/v5.0.1/examples/wifi/espnow
On receiver paste my code.
Can you confirm bug?

@ramiws I checkout your code use ESP32-S3 on 5.0.1, it works fine:
Receiver on ESP32-S3 LOG:
I (634) wifi:mode : sta (84:f7:03:80:09:50)
I (634) wifi:enable tsf
I (634) ESPNOW: espnow [version: 1.0] init
I (704) wifi:new:<1,0>, old:<1,0>, ap:<255,255>, sta:<1,0>, prof:1
I (1664) wifi:state: init -> auth (b0)
E (1674) espnow_example: Got ESPNOW msg
I (1714) wifi:state: auth -> assoc (0)
I (1754) wifi:state: assoc -> run (10)
E (1774) espnow_example: Got ESPNOW msg
I (1994) wifi:connected with Redmi_9BDB_2.4G, aid = 1, channel 1, BW20, bssid = 5c:02:14:71:d3:93
I (1994) wifi:security: WPA2-PSK, phy: bgn, rssi: -34
I (2004) wifi:pm start, type: 0

I (2004) wifi:set rx beacon pti, rx_bcn_pti: 0, bcn_timeout: 0, mt_pti: 25000, mt_time: 10000
I (2174) wifi:AP's beacon interval = 102400 us, DTIM period = 1
E (2814) espnow_example: Got ESPNOW msg
E (3844) espnow_example: Got ESPNOW msg
E (4834) espnow_example: Got ESPNOW msg
E (5874) espnow_example: Got ESPNOW msg
E (6914) espnow_example: Got ESPNOW msg
E (7914) espnow_example: Got ESPNOW msg
E (8914) espnow_example: Got ESPNOW msg
E (9914) espnow_example: Got ESPNOW msg
E (10924) espnow_example: Got ESPNOW msg

Sender on ESP32 LOG:
I (615) wifi_init: rx ba win: 6
I (615) wifi_init: tcpip mbox: 32
I (625) wifi_init: udp mbox: 6
I (625) wifi_init: tcp mbox: 6
I (625) wifi_init: tcp tx win: 5744
I (635) wifi_init: tcp rx win: 5744
I (635) wifi_init: tcp mss: 1440
I (645) wifi_init: WiFi IRAM OP enabled
I (645) wifi_init: WiFi RX IRAM OP enabled
I (655) phy_init: phy_version 4670,719f9f6,Feb 18 2021,17:07:07
I (775) wifi:mode : sta (c8:f0:9e:35:93:70)
I (775) wifi:enable tsf
I (775) ESPNOW: espnow [version: 1.0] init
I (5775) espnow_example: Start sending broadcast data
I (6795) espnow_example: send data to ff:ff:ff:ff:ff:ff
I (7795) espnow_example: send data to ff:ff:ff:ff:ff:ff
I (8805) espnow_example: send data to ff:ff:ff:ff:ff:ff
I (9815) espnow_example: send data to ff:ff:ff:ff:ff:ff

you can also replace the firmware and sdkconfig file confirm again:
TestBin.zip

@ramiws If the receiver's wifi channel isn't 1 after connected with the AP, please call
ESP_ERROR_CHECK(esp_wifi_set_channel(CONFIG_ESPNOW_CHANNEL, WIFI_SECOND_CHAN_NONE));

before https://github.com/espressif/esp-idf/blob/v5.0.1/examples/wifi/espnow/main/espnow_example_main.c#L320 on the sender.

@lhespress Thank you very much. I can see the problem is about the mac address used in the sender. When I use FF:FF:FF:FF:FF the messages arrive. But in my case I need to hardcode the mac address of the receiver in the sender. So when I use the STA mac, it does not work. I used the mac that I see when uploading to flash
Connecting.... Chip is ESP32-S3 (revision v0.1) Features: WiFi, BLE Crystal is 40MHz MAC: f4:12:fa:50:39:40 Uploading stub... Running stub...
Is this the correct mac to use?

@ramiws It's right, did you change it https://github.com/espressif/esp-idf/blob/v5.0.1/examples/wifi/espnow/main/espnow_example_main.c#L39?

AAAAH, I am losing it. Please be patience. I was trying different senders such as S3 and ESP8266 because I thought it cannot be related to sender chip as it is the same protocol. Now I can pin point that the issue is that when I am using ESP8266 sender the messages arrive if the S3 is not connected to WiFi. But when S3 connects to AP, then it messages do not come.
So here is the summary of my testing:
Sender S3->S3 works with or without wifi connected.
Sender 8266-> S3 wifi not connected ( espnow works)
Sender 8266-> S3 wifi connected ( espnow does not work) ( yes I updated the channel on the 8266 sender)
@lhespress  Could you please test with esp8266 as sender? I simply use  esp_now_send  to the receiver mac and wifi_set_channel to set the wifi channel. It works till the S3 connects to wifi. I also tried to kill the hotspot AP from my phone to get the S3 to disconnect and then the espnow messages starts to arrive and work again.

@lhespress  does espressif have commercial support? Are you employee there? I tried to reach out to espressif with no luck.

@ramiws ra I witness the issue on the ESP8266, The protocol on unicast has a litter difference between ESP8266 and ESP32 . BTW, could you describe the application scenario? The ESP32-C2 will be a better select. Of course, we will also fix it on ESP8266 ASAP.

@lhespress Okay that is surprising because the espnow packet that esp8266 is sending is arriving. I was expecting the issue is on the esp32 side when it connects to wifi the issue appears. The esp8266 sends out the same packet regardless of esp32 wifi status. It cannot be that I am the first one trying to use espnow  with esp8266 and esp32. While having esp32 connected to wifi ap. It is all over the internet that it works, was there some recent change that broke it?
I already have 100s of pcbs with esp8266. I cannot simply through them away. C2 are not as widely available. The product is commercial and was using esp8266 to collect data and send it to the esp8266 that is acting as a gateway that collects espnow data and send it to server using wifi/internet. I migrated the gateway from esp8266 to esp32 then I hit this issue.
The production of the commercial product is not stopped due to this issue. Please provide an estimate for the fix. What is the time frame you mean by ASAP. Can you give me a hotpatch binary of espnow that I can use?

@ramiws We'll update a patch on this week.

@ramiws Right

@lhespress what framework and version are you using for the esp8266?
I am using arduino core for esp8266 which is based on NonOS if I remember correctly
I replaced the lib files and got build errors. I guess it is not compatible with the rest of the libraries
build_errors.txt

@ramiws The library is for master branch of ESP8266_RTOS_SDK.

@lhespress Yes now it works with the RTOS_sdk! Thanks!  Could you port the fix to NonOS too? Majority of users still use Arduino/NonOS and plarformio to develop on esp8266. It is also big task for me to port the code to RTOS_sdk, I might face new issues or non-matching APIs. Then there would be more work to power profile the new firmware, as the old one went through that testing already. All those delays in production will have really bad impact on our company.

Any updates on porting this hotfix to NonOS?

@AmirHmZz The fix is under the internal reviewing, you can replace the library and check again.
libnet80211.a.zip

@AmirHmZz @ramiws The fix is under the internal reviewing, you can replace the library and check again.
libnet80211.a.zip

I wasted so much time to rewrite the firmware using rtos esp8266 sdk :(
So yea I'm happy to spend more time testing

@ramiws The fix has release on master branch.


Feature: Subscribe to devy development

In order to not flood users with notifications from the devy development channels, the channels can now only be accessed by people with the "devy developer" role. Have a way we can allow people to subscribe to devy development.
How it would work:

We have a channel with instructions on how to subscribe.
The bot gives them the roll to allow them to see the channels on discord
Then the bot sends them an invite to be a collaborator on the repo.
Maybe if they are inactive in the repo for a certain amount of time then they are removed.

Check if user has role to toggle the role when command is run
https://discord.com/channels/118456055842734083/155361364909621248/565596468879163407


[Fix #5757] Add option to allow parentheses around multiline conditions

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Updated

👍


Set secret ownership to the konk CR

The secrets we bootstrap need to be owned by the KONK CR resource. When the CR is deleted, it will garbage collect the secrets.

Resolved in https://github.com/infobloxopen/konk/pull/18 and https://github.com/infobloxopen/konk/pull/20. Closing the issue.


Share generation script/code

Thanks a lot for the theme, I like it a lot! Are you generating the theme with a script or so? If so, could you share that code? I'd like to modify it for myself just slightly to make the foreground shades a bit more bright.

Unfortunately, there isn't a generator script for monochrome, it was built long before the release with tweaks on-the-go.

Alright, thanks anyway!

I'm currently working on it.

It's on the master.


⚠ Bofrost.at has degraded performance

In 4d778b1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1140 ms

Resolved: Bofrost.at performance has improved in ec38c2e after 13 minutes.


Move metrics generation code to MQTT library

Move Metrics generation code to MQTT library
Description

Metrics generation code moved from demo code to mqtt library
Added padding to md5 code, added tests to verify matches with RFC.
Run time generation using atomic locks
Updated CMakefile and tested on windows sim, will modify the project files for all other boards.

Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merged in PR 839


Implement workaround for voltage drop at high currents

There is an issue with the DPS5005s (at least the three I tested so far) resulting in output voltage drops at high currents. If outputting 6V (according to UI settings and UI feedback) and drawing 1.2A, a multimeter will show a 340mV drop on the output voltage compared to the UI. The value on DAC1 needs to be increased to maintain 6A @ 1.2A which also increases the displayed voltage ADC measurement.
More measurements here under the 'Voltage drop at high current draw' tab
The following table shows DAC1 values maintaining an output voltage of 6V under different current draw:
I [mA]   DAC1
-------------
   16    430
  133    432
  416    436
 1263    456
 2494    468

This is not OpenDPS related as the stock firmware has the same "feature". Fixing it would be a nice OpenDPS addition.

Might be due to the voltage drop in the shunt resistor, for Iout sense, which is supposed to be low side (between PSU ground and Vout-). Which mean the ADC1_in9  is reading Vout + Vshunt, because the ADC sense a value relative to the PSU ground and not Vout-. Can't test this at this moment, I have no dpsxxxx at hand but I have 3 on the way.
According to the voltage drop of<EMAIL_ADDRESS>Rshunt should be 0.28ohms.
A fix would be to substract Vshunt to the value read by ADC1_in9, and this will be Vout.

I forget about the DAC, a fix would be to add the current Vshunt to the requested Vout, hopefully this would be stable, but this may need more thoughts, and surely a verification of the transients when the charge change rapidly. This might be tricky.

Thanks for the description @lumostor. For some reason I reraly get Github notification emails on my own repos, even though I receive tons of them each day for other repose I watch.

@lumostor did you get a chance to look into this? I think as we know the current through the shunt resistor we should be able to account for this quite easily. It does require us to know what that resistance is of course


Added my name(Junior) on ReadMe file

Description
Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.
All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.
Screenshots (if applicable, else remove this line / section)
Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added necessary inline code documentation
[ ] I have added tests that prove my fix is effective and that this feature works
[ ] New and existing unit tests pass locally with my changes

Thanks..
On Tue, 5 May 2020 14:01 Labious Phetoane<EMAIL_ADDRESS>wrote:

@labious approved this pull request.
Looks good to me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BuildForSDG/team-276/pull/13#pullrequestreview-405720530,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMD45TZ4KQXMOGRJRUSNQBDRP753NANCNFSM4MZPW5YA
.


Update translations

Task/Issue URL: https://app.asana.com/0/1205648422731273/1207939590473328/f

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4825  👈
#4822
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on  Graphite


Add option to specify apks in device section of flank.yml

If I understand correctly, currently you can specify different devices in one flank.yml, however, all of those will be associated with the same apks defined in the (global) "app:" and "test:" sections.
While we do test across multiple devices, we also push our arm and X86 builds onto different devices for testing.  It seems like it would be more flexible to be able to override the global values specified above by specifying alternate apks directly in the device section.
Something like:
device:
   - model: Nexus6P
     version: 23
     app: ./app/build/outpus/apk/demoX86/debug/app-demo-x86-debug.apk
     test: ./app/build/outpus/apk/androidTest/demoX86/debug/app-demo-x86-debug-androidTest.apk
   - model: Pixel2
     version: 26
     app: ./app/build/outpus/apk/demoarm/debug/app-demo-arm-debug.apk
     test: ./app/build/outpus/apk/androidTest/demoX86/debug/app-demo-arm-debug-androidTest.apk

how would that work with gcloud? https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run
Flank is tracking the gcloud yaml format, you can run flank.yml with both the official gcloud CLI and Flank.

for larger features like this, you'd want to open a feature request on Firebase:
https://issuetracker.google.com/issues?q=status:open componentid:334091
then if gcloud adds support flank will follow.

how would that work with gcloud? https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run
Flank is tracking the gcloud yaml format, you can run flank.yml with both the official gcloud CLI and Flank.
oh that's right.  well since we don't yet use flank, we simply run 1 build against 1 device then do the next one in serial fashion. our help is to parallelize everything.

i'll submit a feature request to firebase then.  thx!

oh that's right. well since we don't yet use flank, we simply run 1 build against 1 device then do the next one in serial fashion. our help is to parallelize everything.

for custom requirements outside the scope of gcloud's yaml format, v5 will offer an API:

https://github.com/TestArmada/flank/issues/286

that will enable your use case by providing flexibility in how the runs are scheduled


Make the @yamada-ui/popover component headless

script: make-component-headless
package: @yamada-ui/popover
Description
Currently, the @yamada-ui/popover component has minimal styles set within the component's source code.
We want to make this style transferable to the theme and make the component headless, enabling more flexible UI customization.
Problem Statement/Justification
By making the @yamada-ui/popover component headless, we can achieve more flexible styling tailored to the project.
Proposed Solution or API
The styles within the component are mostly defined by css: CSSUIObject and set to a prop named __css. We will transfer these styles to the packages/theme/src/components.
The code below is just an example and not the actual code.
packages/components/input/src/input-group.tsx
const css: CSSUIObject = {
- width: "100%",
- display: "flex",
- position: "relative",
  ...styles.container,
}

packages/theme/src/components/input.ts
baseStyle: {
  container: {
+   width: "100%",
+   display: "flex",
+   position: "relative",
  },
  field: {
    width: "100%",
    minWidth: 0,
    outline: 0,
    position: "relative",
    appearance: "none",
    transitionProperty: "common",
    transitionDuration: "normal",
    _disabled: {
      opacity: 0.4,
      cursor: "not-allowed",
    },
  },
  element: {
    color: ["blackAlpha.600", "whiteAlpha.700"],
  },
},

[!TIP]
In cases where the styles within the component are dynamically changed, there may be instances where it is not possible to transfer the styles to the theme.
In such cases, it needs to be discussed in this issue. Please feel free to send comments to this issue.

Additional Information
The @yamada-ui/popover component exists in packages/components/popover/src. You need to check all the components in this folder and if they contain styles internally, you need to modify them.
This change could have a significant impact on projects using Yamada UI, so we will work on it within the scope of v2.0.
Please create the branch for working on this issue from the remote branch v2.0, and direct your pull requests to the v2.0 branch as well.
Please select major for the changeset and create a pull request.

@balckowl
Hi, thanks for the comment!
Yes, pls.

Fixed #2012


MacOS onboarding status seems not matching between local machine and dashboard

https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-antivirus/microsoft-defender-atp-mac-install-with-jamf
says onboarding can be checked by a command mdatp --health healthy, and when the output is 1, then it's not yet in the status of onboard.
However, my machine seems to be on board as it detects a detection test curl -o ~/Downloads/eicar.com.txt http://www.eicar.org/download/eicar.com.txt.

@officedocsbot assign @jvsam

Hi @ken5scal, to confirm the onboarding status, kindly check via the onboarding section of the Microsoft Defender Security Center. If it says onboarding is completed, then yes, you're good to go. If no machine is appearing in the machines list and there was no error in the onboarding process, this might indicate an onboarding or connectivity problem. I would suggest reviewing the events and errors using Event Viewer. More troubleshooting steps for onboarding issues are available here.
The Microsoft Defender ATP for Mac is now in public preview and if you have feedback regarding the product, you can submit it by opening Microsoft Defender ATP for Mac on your device or submit feedback via Microsoft Defender Security Center.
Note: This Github site is used as a feedback system to help improve the quality of the technical documentation of Microsoft Docs through user contributions and feedback. If you have suggestions related to this documentation or ideas to make it better for users, please let us know here and we will submit them for review. Thank you.

Hi again @ken5scal I, just wanted to follow up if you were able to successfully onboard your machine? If  you are having problems, please check the links that I've provided. I will now close this issue, however, feel free to re-open if you have suggestions or ideas to improve the quality of this documentation. Thanks for being part of the Microsoft Docs community!

@officedocsbot close


Change "more" Text in Month View?

Summary
How do you change the "more" text in month view?
Screenshots
"more" - Can it be changed/localized?

Version
1.15.3

@gismofx
You can modify the monthGridHeaderExceed template.
Check out this example.
https://nhn.github.io/tui.calendar/latest/tutorial-example14-template-for-month


WARNING - llmtuner.model.patcher - FlashAttention2 is not installed.

Doesnt LLama-Factory install flashattention package by default?
Normally pretraining will be with large corpus of data so flashattention will be beneficial.
I see below warning during pretraining with Lora:
WARNING - llmtuner.model.patcher - FlashAttention2 is not installed.

we do not install flashattn at installation, please manually install it: https://github.com/Dao-AILab/flash-attention

Thank you @hiyouga


vox-segment-data

Divide the master data into segments, saving the segments for later use. Generate 4, 6 and 10 sec segments as mp3 files.

The approach was to use webrtcvad which had marginal results. Note that full databases were created. I intend to retry segmentation using pyAudioAnalysis. See issue 4.


Add import quick action doesn't list the expected value

I had some code like so:
from typing_extensions import Union

class Options:
   mode: Union[str, None] = None
   address: Union[Tuple[str, int], None] = None <-- Quick action here for `Tuple`

The quick action list showed this:

Notice how it doesn't include an action to add to my already existing typing_extensions.

There are two issues with the fix in my pull request:

The typing_extensions is not an actual python standard library; it's a third-party library that requires user installation. Pyright treats it as part of the stdlib because it's included in the typeshed's stdlib folder. As a result, pyright won't report a reportMissingModuleSource error if a user imports typing_extensions but have no corresponding source file. Adding this option to the quick fix or auto imports might potentially cause runtime errors in users' code.
As Erik mentioned, we wouldn't want to display both suggestions.  @bschnurr  is currently working on implementing a pylance create all std indices command that users can run to match their python version. This solution seems more appropriate for the long term, so just closed my PR.

Relevant issues that Bill's working on:

https://github.com/microsoft/pylance-release/issues/4993
https://github.com/microsoft/pylance-release/issues/3785

This issue is actually a dupe of https://github.com/microsoft/pylance-release/issues/3785, so maybe I should close this one.


[WFCORE-5828] WildFly-Common 1.6 depends on java.xml

Fixes https://issues.redhat.com/browse/WFCORE-5828

Thanks, @boris-unckel


Vending machine interface needs a scroll bar

Currently, if a vending machine has too many items in it, you can't get to all the items in windowed mode (and may not even be able to in fullscreen, depending on what your resolution is). Scroll bars would fix this.

you should be able to scroll already? either way it shouldn't open that large by default so I'll fix that

This has been fixed. Vending machines have scrollbars


add rest config into SyncerConfiguration

The purpose of this PR is to make the syncer framework more generic so it can be reused by users that need to support their own CRDs. This change passes rest config of super master in SyncerConfiguration struct. So users can construct/handle their CRD client to perform the DWS/UWS sync.

@weiling61 Can you elaborate how this change helps to achieve your goal described in the change description?
"So users can construct/handle their CRD client to perform the DWS/UWS sync"  I don't quite understand this part.

@Fei-Guo thanks for the question. System level CRDs exist in super cluster. Tenant in Virtual cluster or Syncer inevitably needs to deal with these CRDs, for example, 1) syncer needs to check status of a security CRD in super cluster, or 2) some environment CRDs needs to be synced between tenant cluster and super cluster.  A separate customized syncer is required to handle these CRD cases.
When I tried to build the customized syncer, I found that 80% of current syncer code can be reused, but still missing some pieces that cannot be directly imported. One critical piece is the super cluster restful config, which is used to construct CRD client for the customized syncer. If the rest config can be passed to /resources as this PR does, packages, such as 'app', 'options', and 'syncer' in current syncer can be directly imported in the customized syncer, which reduces quite a lot maintenance efforts.

/ok-to-test

Thanks for the explanation.
/lgtm
/approve


New Home Assistant podcast 📻😍

I have an automation that notifies me when there is a new Home Assistant podcast. Normally this coincides with tweets from Phil and Rohan. I really love this podcast and most if not all episodes I take something away. To do a full circle on this I want to extend my automation to create a new issue here where I can capture notes and link these to other issues which might have been sparked because of the show.

[x] Share automation #191
[ ] Update the automation so it triggers only when the podcast feed is updated
[ ] Integrate it with GitHub issues #103
[ ] Create another automation to handle the other feeds

Other ideas

An actionable alert that asks you if you want to play it now.

https://www.home-assistant.io/integrations/feedreader/


create module feature to enroll users randomly to given arms.

Development done. Changes are present in the pull request.


404 error on browser version

The browser version linked in the Installation section from the homepage ( https://keybase.io/triplesec/ ) leads to a 404 page not found. Link is:
https://keybase.io/triplesec/rel/triplesec-3.0.0-min.js
This is also causing the page's "In-Browser Magical Demo" to not work (since it requires the file above)

Ahh, thanks, this should be fixed tomorrow. The latest version is 3.0.14, FYI:
https://github.com/keybase/triplesec/tree/master/rel

The demo on the page is working again.  And thanks for the link to my C# version.  If you guys make a V4 or do drastic code changes, just open an issue on my repository and I'll address it.  :)
If you need C# examples for that page as well, for the code snippets, let me know and I can get those to you.

This has also been fixed for a year. @maxtaco - sorry if I am annoying you tagging you in these things, is there someone else I should tag to to clean up these issues?


Additional FireFox and No One's games

@revvv I'm going to create nested catalogues like these:
/caves/No_One/
/caves/No_One/Delight/
/caves/No_One/Prima_Boulderdash/
/caves/Scserbin_Zoltan/
/caves/Scserbin_Zoltan/Atlantis/
/caves/Scserbin_Zoltan/Auto Dash/
/caves/Scserbin_Zoltan/Batman/
/caves/Scserbin_Zoltan/Dig_Dug_Dash/
/caves/Scserbin_Zoltan/Ninja_Dash/
etc.
What do you think about this idea?

Zoltan's makefile did not support subdirs, so I had to update caves/create_makefile.sh which generates the makefile.


Remove option "disable" in NAT Traversal in IPSEC Phase 1 settings

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
OPNSense offers options "Disable", "Enable" and "Force" in IPSEC Phase 1 NAT Traversal settings.
In fact strongswan seems not allow to disable NAT-T anymore since release 5.0.0, see https://wiki.strongswan.org/projects/strongswan/wiki/NatTraversal.
Took me quite a while to find out, why disabling NAT-T did not work :)
The option value "Disable" is therefore pointless and maybe the Dropdown-Field should be replaced by a tickmark "Force NAT-T".
A hint "To disable NAT-T make shure that MOBIKE is disabled" when clicking the "i" icon might be helpful as well, as this seems to be the only way to disable NAT-T
Environment
OPNsense 21.1.3_3 (amd64, OpenSSL).

off influences automatic firewall rules:
https://github.com/opnsense/core/blob/81fa4ec53df1dfd5319573852817a3bf9b457ce4/src/etc/inc/plugins.inc.d/ipsec.inc#L294-L307
force sets forceencaps, on leaves nat-t in it's default state.
https://github.com/opnsense/core/blob/81fa4ec53df1dfd5319573852817a3bf9b457ce4/src/etc/inc/plugins.inc.d/ipsec.inc#L1641-L1644

Thanks for clarifying ! I overlooked this, in my testing automatic firewall rules were turned off.


Progress Reports workflow history

This PR adds the date, time, and the user who made a status change to the bottom StatusStepper.
https://seed-company-squad.monday.com/boards/3451697530/pulses/3921175869

This is awesome!  Thanks Carson!


Require max-attempts to be at least 1

See https://github.com/quarkiverse/quarkus-langchain4j/issues/482 for the related discussion

Hi @jmartisk thanks a lot!
There is https://github.com/langchain4j/langchain4j/pull/981 already

As #981 was merged, should this be closed?

yeah


Update validations.py python script.

Fixed the behavior of validate_user function in validations.py.
Closes: #1

@googlebot I signed it!


Linux dependency change (crytography) breaks compatibility with AWS Lambda

Hello,
This issue is to report that v1.13.0 does not work anymore with AWS Lambda. If you create a lambda package, using this method - during runtime you will receive an error about not finding libffi libraries. Since we cannot change the lambda operating environment, we must specify a version below 1.13.0. Another workaround will be to move to another implementation (like go)

There's a project from Zappa which helps you compile these dependencies: https://github.com/Miserlou/lambda-packages

Thanks for the pointer. If I can't use fugue/credstash natively, I would rather just switch to another implementation since I have to re-tool my pipeline anyway.


NTR: decoy receptor complex

A complex term to go with GO:0140319 receptor decoy activity
Name: decoy receptor complex
Def: A receptor complex that recognizes, binds and sequesters a specific receptor ligand to prevent it from binding to its regular receptor. May be soluble or membrane bound.
Relationships:
is_a GO:0043235 receptor complex
capable_of GO:0140319 receptor decoy activity
Reference:
PMID:9168977
PMID:30621730
GOCID:bhm
Synonyms:
Osteoprotegerin complex [NARROW]
Osteoclastogenesis inhibitory factor [NARROW]
Editor, please ignore.
Note to self: EBI-21990873

Or should this be an annotation (GO-CAM?) that combines binding and negative regulation, analogous to the ligand trap annotation in our BMP signaling pathway (R-HSA-201451 - particularly reactions R-HSA-201457 and R-HSA-201443?

This is to link the CP entry to a GO complex term. If you feel that decoy receptor is not valid I'll have to link it to "receptor complex"...

hi @deustp01 ,
It hink we still require "receptor decoy activity" for GOCAM modellig
As I understand it @pgaudet  is trying to establish MF terms to cover binding annotations when the mechanism is known..
We would use MF part of Process to connect a molecular function   to a biological process in GOCAM syntax, but not a MF term + BP term to capture a molecular function.

The activity is fine; do we need a complex ?

Does that mean 'decoy receptor complex' is outside the scope of GO?


Player crashes when given a link to a playlist

Hello,
I don't know if this is voluntary or not, but when feeding the player an url in the form:
https://soundcloud.com/*/sets/*
it fails to load.

Try this patch https://github.com/ToneDen/toneden-sdk/pull/51

I have the same issue. Can't get a 'set' to load, but the url should be 'SETS' https://soundcloud.com/nonbeliever/SETS/a-model-of-modern-influence not 'set' or 'playlist'.
Unless the SDK thinks playlists are sets, I'm not sure: https://github.com/dreamdt/toneden-sdk/commit/ea65a634d21625e30f00e191689ceacb2a254818

@thathurtabit

the url should be 'SETS'

You are right,
but this code is not about url, it's about response:

@dreamdt Ah. I see. So your solution seems to fix the problem then? Is there a way I can link to your updated version, or do we need to wait until it's merged into https://github.com/ToneDen/toneden-sdk ?
Apologies for my cluelessness.

Yes, it works for me, but you should use "/sets/" inside url (not /SETS/)
Inside toneden.loader.js, you should replace "//sd.toneden.io/production/v2/" with your own domain and path. I think it will be enough (if not, it would be better to wait until merge)
https://github.com/dreamdt/toneden-sdk/releases/download/v2.0/toneden-sdk.zip

Huzzah @dreamdt! It works! Thank you for your help. Hopefully your fix should get merged soon.

Thanks for fixing this. I just merged the PR by @dreamdt and deployed it to our CDN.


ConsulAutoRegistration change the instance-id

when use spring-cloud-consul, it(class ConsulAutoRegistration) change the instance-id when register to consul. forexample, change task-a.b to task-a-b.
why do like this? consul support DNS format instance-id, we can register with task-a.b directly.
if we provide a DiscoveryHealthIndicator to check if the service on consul by instance-id, but we cannot find the instance by origin instance-id, unless we change the instance-id in the same way.

From the exception:

"Consul service ids must not be empty, must start with a letter, end with a letter or digit, and have as interior characters only letters, digits, and hyphen

https://github.com/hashicorp/consul/blob/f36d77ee4a2fce61db88bdd2feda8f57a05a5d38/agent/agent.go#L2173-L2178

From the exception:

"Consul service ids must not be empty, must start with a letter, end with a letter or digit, and have as interior characters only letters, digits, and hyphen

https://github.com/hashicorp/consul/blob/f36d77ee4a2fce61db88bdd2feda8f57a05a5d38/agent/agent.go#L2173-L2178


Make tell under multiple listens faster.

I was reading the code and had a hunch that this should work, but I'm no expert!
This change depends on the Monoid laws to hold.

Thanks for your contribution! This is indeed one optimization I've thought about, however this means that tells under two concurrent listens will no longer be real-time, as the result is appended in batch, which can be kind of unintuitive.
It would be nice to introduce another interpreter for Writer and document this difference in behavior. You can do this by yourself if you want to, or else I'll do that. 😉

I'm not sure how to implement that - can you come up with a minimal working example?

I just added runWriterBatch (b7b101f) as a solution - feel free to reopen this when you find out a better way to do this!