React native 0.59.x crashes on Android without any error message

🐛 Bug Report
RN 0.59 isn't stable on Android. if you spend 20 seconds wandering around in your app, it will crash and stop working with no error message whatsoever.
I have to add I didn't face this issue on Expo SDK 32 or RN v0.58.6.
To Reproduce
 react-native init
react-native run-android
and use the Code Example as your App class.
now just type a few words in TextInput and then remove some letters and again type something...; it takes less than 5 seconds to crash without any error message.
Expected Behavior
just to work in a stable manner.
Code Example
export default class App extends Component {
  state = { text: "" };

  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>Welcome to React Native!</Text>
        <Text style={styles.instructions}>To get started, edit App.js</Text>
        <Text style={styles.instructions}>{instructions}</Text>
        <TextInput
          onChangeText={text => {
            this.setState({ text });
          }}
          value={this.state.text}
          placeholder="please don't crash!"
        />
      </View>
    );
  }
}

Environment
React Native Environment Info:
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i7-4702MQ CPU @ 2.20GHz
Memory: 913.58 MB / 5.76 GB
Binaries:
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338
Android 7.0 (real device: Samsung S7)
React Native v0.59.3

@MahdiGhajary - if you look into the output of logcat you'll most probably see the exact reason for the crash. There is no such thing "no error message". We have our app running on .59 and it works fine. If you want someone to help you - please provide the output of the crash report in logcat.

@compojoom actually I did look at output of logcat but I couldn't find anything useful there.
here is a screeenshot:

Try without the filters

@zaguiini What do you mean? (if you mean I should have run just log-android , I did and the output was exactly similar to the screenshot provided in my previous comment)

Run adb logcat instead, give it a try

@zaguiini  Hundreds of lines of text were logged but there wasn't anything useful or special. could you reproduce this issue on your own machine or it's something that I'm just facing on my device?

I'm not getting this error, unfortunately...

@compojoom I am also experiencing this issue in android after I have migration to RN 0.59 and added abi filters to support for 64bit android support   arm64-v8a and x86_64.
When I remove them and work with armeabi-v7a and x86 the android app works fine.
My app crashes as soon as I start going into react-navigation and crashing in Samsung galaxy S7 having Android Version 6.0.1 while working fine in most of the devices I have.
Logcat Response:

@compojoom I am also experiencing this issue in android after I have migrated to RN 0.59 and added abi filters to support for 64bit android support arm64-v8a and x86_64.
When I remove them and work with armeabi-v7a and x86 the android app works fine.
My app crashes as soon as I start going into react-navigation and crashing in Samsung galaxy S7 having Android Version 6.0.1(it has both 64 bit OS and CPU) while working fine in most of the devices I have.
Logcat Response:

Same issue is coming after I try it with a fresh RN project with v0.59

Looks like there's a yoga issue there?

Can you guys try with a clean rn project? Is it working there? If it is, then it is a misconfiguration with the project you have. We are running with rn .59 for a week now and have 0 crash reports.

Please note this issue tracker is not a help forum (as stated in issue template).
We recommend using StackOverflow where there are community incentives to help others or our Discord channel for questions. We can reopen this once there is a concrete bug report and this is a real issue, or even better: please send us a PR with a fix!

@compojoom as I said, it's reproducible just by creating a fresh RN project. maybe it's just reproducible on Windows machines or android 7.0 or maybe just physical Galaxy S7. all I know is that I didn't have this issue on 0.58.6 or Expo SDK 32.
@cpojer I'm not seeking help for a special feature or implementation of something! there is clearly something wrong with the RN itself that it crashes without any error (or logs) whatsoever!

@MahdiGhajary - then do rn init, create the project, push it to github, give us a link and we'll try to run your project to confirm. RN init works fine on my end and the produced app doesn't crash.

@compojoom @cpojer @MahdiGhajary
Git Repo: https://github.com/ishantsagar/RN59-AwesomProject
Crash Video: https://www.dropbox.com/s/opc1vwgusi4ck88/samsung_crash.mp4?dl=0
Device Details: https://www.dropbox.com/s/b39yvmobhjsx2be/Screenshot_20190406-140655.png?dl=0
https://www.dropbox.com/s/p201120ov4xeb7v/Screenshot_20190406-140633.png?dl=0
https://www.dropbox.com/s/xlz7n0xmu894uoi/Screenshot_20190406-140644.png?dl=0
The crash is occurring when I open the app and long press on the text for 2-3 seconds, sometimes the app hangs up but doesn't crash.
As mentioned earlier as well, the app is not crashing in other android devices as I noticed till now, that is why it could be related to some specific device architecture configuration.Crash log is the same as attached previously.

mine does not crash....tested with latest version

Crashes on physical galaxy s7.

Crashes on physical galaxy s7.

Yes

Found a similar issue here: https://github.com/facebook/react-native/issues/17671

#24261

@hramos @mkonicek As of now we can conclude that this seems to be an issue with latest RN 0.59 release, affecting android builds running on Samsung S7, S7 Edge after we provided support for arm64-v8a, x86_64, removing them from build.gradle does not crash the app, which could potentially affect apps going live after 1 August 2019 as per Google Play 64 bit support policy. We would like you  guys to draw some attention to it, please?

This is still happening on RN 59.4, Galaxy S7, Android 6.0.
Removing arm64-v8a and x86_64 from build.gradle doesn't change anything.

It seems all they care is closing issues and keeping them below 400 even though lots of them are still relevant. @Fouppy

@Fouppy That still mentions arm64 throughout the stack trace. Did you fully rebuild the app after removing those ABIs from build.gradle?
The 64 bit build appears to be causing all sorts of issues for us. From segfaults to seemingly random NullPointerExceptions that never occurred before and cannot be reproduced, specifically on Galaxy S7 and Galaxy Tab S2. Both device variants run on Cortex-A53 (Exynos) CPUs.

@wbercx This logcat was extracted before, but the crash still occured

Important note: As described on this StackOverflow solution, just removing "arm64-v8a", "x86_64" is not enough, you also have to do this in your ndk filters:
android {
    defaultConfig {

        ndk {
            // Specifies the ABI configurations of your native
            // libraries Gradle should build and package with your APK.
            abiFilters "armeabi-v7a", "x86"
        }
       ...
    }
}

@ahanriat Yep, that's what I did :) To no avail.

Got the same crash using latest react-native, and fresco version 1.13.0. Downgrading Fresco to 1.9.0 resolved the issue to me, and it doesn't crash anymore.

Got the same crash using latest react-native, and fresco version 1.13.0. Downgrading Fresco to 1.9.0 resolved the issue to me, and it doesn't crash anymore.

How did you downgrade fresco version ? what file should I change ?

This is an issue for me too.

Yup, been frustratingly debugging this (trying to upgrade to 0.59 for a production release). iOS works great, it works fine in dev, but we encounter this crash in production pretty sporadically across multiple devices on Android (Samsung Galaxy 7, Essential phone, etc.). We have an LG Nexus where we can't reproduce this error though.
We have already filtered out the 64-bit builds, which we confirm through trawling around the apk just to make sure. Without that, we were actually encountering freezing where it looked like JavaScript was dead, even though the native app kept running.

On my end, tried moving around Fresco to 1.9.0 (crashed immediately with 0.59.5 the moment an image came up), 1.10.0 (which is the default version for 0.59.X) and unsurprisingly it acts the same as not forcing the version to be 1.10.0. I finally upgraded to 1.13.0, which doesn't seem to crash when I hit an image, but as far as I can tell also behaves the same as 1.10.0, with the same crash which this issue is about.

Same problem here with two totally different apps running RN 0.59, and the problem just happens on a specific devices (Samsung S7 with Android 6.0.1).
Unfortunately, I still have not been able to get these devices to debug.

Same problem here with two totally different apps running RN 0.59, and the problem just happens on a specific devices (Samsung S7 with Android 6.0.1).
Unfortunately, I still have not been able to get these devices to debug.
Please everyone, upvote this issue to get RN team attention.

@cpojer  Repo with source (RN 0.59.8 react-native clean init project with no edits) and APK file (inside /apk folder) is here: https://github.com/quietbits/react-native-apk-crash
Could you (and anyone else) please try it on your device(s) and see if you can successfully launch it? There is a list of devices we've tried in the readme. Much appreciated!

What, why is this closed ? is this resolved ?

I found this issue #24261 with Hi-Pri tag.

In my case the application loads when the phone is connected to the metro-builder, but once the phone is disconnect from the Metro-builder the application crashes.

Hi All, my release signed android APK is crashed immediately after clicked on app icon on the physical device, though my signed app builds successful, below are logcat error :
2019-05-30 10:16:56.003 1150-1263/? E/View: focusableViewAvailable: current thread is android.anim, return!
2019-05-30 10:16:56.023 2852-6156/? E/[HwRecSys]HwRecSysService: getIsRportDirectService is false!
2019-05-30 10:16:56.084 1150-7764/? E/ReportTools: This is not beta user build
2019-05-30 10:16:56.153 2852-6156/? E/[HwRecSys]HwRecSysService: getIsRportDirectService is false!
2019-05-30 10:16:56.260 1771-5525/? E/HsmCoreServiceImpl: onTransact in code is: 103
2019-05-30 10:16:56.321 1150-1263/? E/WindowManager: win=Window{aab7e30 u0 Splash Screen com.wtitool EXITING} destroySurfaces: appStopped=false win.mWindowRemovalAllowed=true win.mRemoveOnExit=true
Please help me

@syedammar, @douglasjunior cited this above, but take a look at #24261.
I don't think those logs are actually showing the crash. I have a comment a bit further up (same issue) about tombstones in Android that you can use to extract the actual crash.
https://github.com/facebook/react-native/issues/24261#issuecomment-490239902

I'm also getting this issue on Android. Any update on this?

@hramos @mkonicek As of now we can conclude that this seems to be an issue with latest RN 0.59 release, affecting android builds running on Samsung S7, S7 Edge after we provided support for arm64-v8a, x86_64, removing them from build.gradle does not crash the app, which could potentially affect apps going live after 1 August 2019 as per Google Play 64 bit support policy. We would like you guys to draw some attention to it, please?

I agree with @ishantsagar , I have just faced this issue, only happens on REAL DEVICE, LENOVO, RUNNING ANDROID 6.
deleting "arm64-v8a", "x86_64" from
ndk {
            abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
 }

solved the issue.
So it must be something to do with this latest config's way of building "arm64-v8a", "x86_64" builds.
Not sure if it's entirely RN's fault, but maybe the team could help investigate and educate instead of just closing the case for the sake of closing it

Any help on this issue would be seriously appreciated!

I'm pretty sure this is a duplicate of this issue https://github.com/facebook/react-native/issues/24261
TLDR; Javascript Core Jit on Android 64bits is not stable 🐛 But thanks to some awesome people ❤  a fix is coming

Hi All, my release signed android APK is crashed immediately after clicked on app icon on the physical device, though my signed app builds successful, below are logcat error :
2019-05-30 10:16:56.003 1150-1263/? E/View: focusableViewAvailable: current thread is android.anim, return!
2019-05-30 10:16:56.023 2852-6156/? E/[HwRecSys]HwRecSysService: getIsRportDirectService is false!
2019-05-30 10:16:56.084 1150-7764/? E/ReportTools: This is not beta user build
2019-05-30 10:16:56.153 2852-6156/? E/[HwRecSys]HwRecSysService: getIsRportDirectService is false!
2019-05-30 10:16:56.260 1771-5525/? E/HsmCoreServiceImpl: onTransact in code is: 103
2019-05-30 10:16:56.321 1150-1263/? E/WindowManager: win=Window{aab7e30 u0 Splash Screen com.wtitool EXITING} destroySurfaces: appStopped=false win.mWindowRemovalAllowed=true win.mRemoveOnExit=true
Please help me

The issue was solved when I change my entry point in the file 'android/app/build.gradle' from
project.ext.react = [
entryFile: "index.js"
]
to
project.ext.react = [
entryFile: "index.android.js"
]
Regards,

i have same issues with note 9 and galaxy A7 :(

Please, update to 0.59.10, see #24261.

if i use below app crashes and accepted by google play store
ndk { abiFilters "armeabi-v7a","arm64-v8a","x86","x86_64" }
if i use below app is working but not accepted by google play store
ndk { abiFilters "armeabi-v7a", "x86" }
please any one help me solving

@hramos @mkonicek As of now we can conclude that this seems to be an issue with latest RN 0.59 release, affecting android builds running on Samsung S7, S7 Edge after we provided support for arm64-v8a, x86_64, removing them from build.gradle does not crash the app, which could potentially affect apps going live after 1 August 2019 as per Google Play 64 bit support policy. We would like you guys to draw some attention to it, please?

I agree with @ishantsagar , I have just faced this issue, only happens on REAL DEVICE, LENOVO A701a48, RUNNING ANDROID 6.
deleting "arm64-v8a", "x86_64" from
ndk {
            abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
 }

solved the issue.
So it must be something to do with this latest config's way of building "arm64-v8a", "x86_64" builds.
Not sure if it's entirely RN's fault, but maybe the team could help investigate and educate instead of just closing the case for the sake of closing it

it fixed the crash only but as google has upgrade 64-bit policy on 1 August 2019, we can not submit our application on the play store
when we upload .apk file on the play store, it give the error below

I already update to 0.59.10 and still facing the problem on Samsung S7, S7 Edge.

I have the same issue, release bundle, here is the stack:
com.facebook.react.common.JavascriptException null is not an object (evaluatingv.getViewManagerConfig(AndroidDrawerLayout).Constants), stack: /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js Constants@23:3 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native-gesture-handler/GestureHandler.js DrawerLayoutAndroid@422:55 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native-gesture-handler/Swipeable.js d@10:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6<EMAIL_ADDRESS>WrappedSectionList@74:15 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/app/biz/globalView/globalChat/view/ChatItemView.tsx d@11:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/app/biz/globalView/globalChat/GlobalChatView.tsx d@28:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/app/biz/globalView/globalChat/GlobalChatViewProvider.tsx d@12:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/app/navigation.js d@8:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/app/App.js d@26:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/index.js d@4:0 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js global@331:6 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/metro/src/lib/polyfills/require.js moduleId@197:45 global code@1267:4 mqt_native_modules com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:54) com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:38) java.lang.reflect.Method.invoke(Method.java:-2) com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372) com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158) com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java:-2) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29) android.os.Looper.loop(Looper.java:154) com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:232) java.lang.Thread.run(Thread.java:761)

I hame the same issue, RN version 0.59.5, release bundle, here is the stack:
calling runApplication)(value@28:3170 com.facebook.react.common.JavascriptException Module AppRegistry is not a registered callable module (calling runApplication), stack: value@28:3170 <unknown>@28:822 value@28:2565 value@28:794 value@-1 com.facebook.react.common.JavascriptException Module AppRegistry is not a registered callable module (calling runApplication), stack: /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js invariant@354:4 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js module@106:26 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js fn@314:8 /var/jenkins_home/workspace/MyProject/MyProject/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js value@105:17 value@-1 mqt_native_modules com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:54) com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:38) java.lang.reflect.Method.invoke(Method.java:-2) com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372) com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158) com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java:-2) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29) android.os.Looper.loop(Looper.java:154) com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:232) java.lang.Thread.run(Thread.java:761)

@sultan-arshi yep, removing "arm64-v8a", "x86_64" in the ndk definitly fixed the issue for me. The only important areas that need to be updated are:
splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
        }
    }

and
applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
            def versionCodes = ["armeabi-v7a":1, "x86":2, "arm64-v8a": 3, "x86_64": 4]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }

It is now accepted by google playstore, no more compatibility issue when you upload the apk.

abiFilters

I applied this and the app is still crashing.

@hramos @mkonicek As of now we can conclude that this seems to be an issue with latest RN 0.59 release, affecting android builds running on Samsung S7, S7 Edge after we provided support for arm64-v8a, x86_64, removing them from build.gradle does not crash the app, which could potentially affect apps going live after 1 August 2019 as per Google Play 64 bit support policy. We would like you guys to draw some attention to it, please?

I agree with @ishantsagar , I have just faced this issue, only happens on REAL DEVICE, LENOVO A701a48, RUNNING ANDROID 6.
deleting "arm64-v8a", "x86_64" from
ndk {
            abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
 }

solved the issue.
So it must be something to do with this latest config's way of building "arm64-v8a", "x86_64" builds.
Not sure if it's entirely RN's fault, but maybe the team could help investigate and educate instead of just closing the case for the sake of closing it

it fixed the crash only but as google has upgrade 64-bit policy on 1 August 2019, we can not submit our application on the play store
when we upload .apk file on the play store, it give the error below

I did that but the app is still crashing.

For anyone reading this, the summary is there is no fix for 0.59x. You will have to upgrade to 0.60x, switch on hermes, and then if there are any other issues after this you will have to create a new issue with the repo

Hermes is still in experiment, so today is not an option for most existing apps.

I actually went through the trouble of bumping 0.60.5 and enabling Hermes + 64-bit (which was a pain, as upgrading react-native always is) and I'm still having these issues on several Android phones (including HUAWEI MYA-L41).
I've tried just about everything I've found in other threads without much luck, so I can tell you bumping react-native and using Hermes doesn't fix all of these issues.
The updated react-native + Hermes and 64-bit is amazing on other Android devices I've ran it on and our app has never felt smoother.
However, whenever I test on the specific device I mentioned (Huawei) it crashes instantly or after the app is open for 1-2 seconds without a specific crash message, I don't have any other devices besides that one and a newer Huawei (which works perfectly) so I can't give you more info on other phones.
If anyone has made any progress with this issue or has any ideas for more specifically logging my issues, advice is always welcome and I'm willing to share any information in this topic.
Thanks to the people in this thread for offering solutions, but no luck so far. 🙂

In my case, the problem was redux-logger and Gradle version.

I removed redux-logger from my code
In build.gradle at the android folder:

    dependencies {
        classpath 'com.android.tools.build:gradle:3.3.2' // <-- This version did the trick too, I had 4.X.X
        classpath 'com.google.gms:google-services:3.2.1'
    }

And now I can work in release mode without any problem.

Can anybody confirm that this worked?

I followed the following things and it solved my problems
well we need to upgrade react-native version at least to 0.59.1
some time react-native upgrade 0.59.1-rc.0 do not works
and we do not get upgraded
so you need to change "react-native": "0.59.10" or higher version in the package.json file manually
and then nom install
you may need to remove node_modules and package-lock.json file as well
after this you may need to update some libraries if you get some error
and finally don't forget to

ndk {
abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
}
and then also

splits {
abi {
reset()
enable enableSeparateBuildPerCPUArchitecture
universalApk false  // If true, also generate a universal APK
include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
}
}

Probably a long shot, but I didn't see any specific error either and debugging Android didn't yield much.
After searching for a while our issue was that we sometimes passed null to the source variable in the react-native Image component when there is no given image. This only seems to give issues on a specific architecture + 64-bit.
As I said, probably a long shot for other people here, but it might help someone.

any solutions ???

In my case app (0.59.9 version) was crashing just after opening it.
react-native bundle --dev false --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res
This created a bundle and it worked perfectly fine.

@azharuddinkhan8898 its not working

I will refer again to https://github.com/facebook/react-native/issues/25494. It is almost certainly the cause of most of these crashes (if you have 64-bit enabled).
It would even explain why some of these solutions (temporarily, for some Android phones) work—it's a JSC getting-garbage-collected issue. Moving certain libraries around, changing certain settings, can delay—even sometimes for a long time—when the crash occurs. It sometimes even solves it on certain phone models. But it will not for all of them. And most times, it doesn't actually fix it for the long term. I've also personally been fooled before that I fixed it because I tested on a different phone or emulators (which are 32-bit).
If so, you will never solve it by tweaking around the edges, because the issue is in the runtime, in the literal JavaScript engine you're using. You can't take out any libraries, change any build settings, or do anything that will permanently solve it outside of upgrading to 0.60+ and replacing JSC with v8 or Hermes.

any solution?

My current version 0.57.5. I create new project 0.60.5 and copy js files and working

Same issue with react-native 59.9 Android 8.1

someone can confirm that for react native version 0.60.5 it's working? I don't want to upgrade my react native for no reason

@tal987 No, it will 100% not work in 0.60.5, as tested by myself and at least 10 other people spread across different issues. Again, this is a nondeterministic crash, so it's really hard to tell for certain without a long runtime across thousands of devices. But that's what we've done.
You will need to upgrade AND switch out your JavaScript engine to v8 or Hermes, as referenced in the other issue.

Damn! It's so embarrassing

@j-wang - It's possible to switch to v8 without upgrading to rn 0.60

@chilugen - just upgrading doesn't work for all Android devices.

@jacquesdev  what error ?

@chilugen React native 0.59.x crashes on Android

use this link ? https://react-native-community.github.io/upgrade-helper/?from=0.55.4&to=0.59.10 @jacquesdev

I am on that version, see the comment above, https://github.com/facebook/react-native/issues/24260#issuecomment-526319471, it's not even fixed yet in 0.60.5.
For sure upgrading to 0.59.10 will fix it on some Android phones, but not all of them.

@chilugen can you please share the logcat.
You can check logcat hitting adb logcat this in terminal.
[https://developer.android.com/studio/command-line/logcat](read about logcat)

@jacquesdev Yup, since the comment, I've seen some folks do that with v8, and it looks like it's working for them too. I can't speak from personal experience since I used Hermes (which does require an upgrade).

@j-wang I’m using Hermes too but it seems that the performance is very slow compare to without it. Anyway I upgraded to 0.60.5 and I have noticed that the performance is slower than before. Did you fix this issue?

Hmm, it likely depends on your exact application and what you're doing. For ours, it's actually marginally faster. Well, on production at least. On development, it's now almost unusably slow for certain phones (including higher-end ones).

I have two apps, one at react native 0.59.10 and the other at 0.60.5. I can't use Hermes or v8 cause there is a lib (realm in this case) that only uses JavaScript Core. The problem for me is that I can't go back cause of Google 64 bits mandatory. Waiting for the lib owners to integrate Hermes or V8, and hoping that this will solve those crashes.
I already tried so many things, and change this lib will affect the whole project, at a level that will the worth for me to create a new one instead.

@RenanSanguinete You can build for 64-bit on 0.59.x

@wkoutre The app still crashes on 64-bits on 0.59.x in some devices as Galaxy Samsung S7

Well, it didn't for the app I'm currently working on, but there are obviously many complexities to consider regarding this on a per-app basis.

still the error persists in samsung s7 with RN 0.59?

I'm on RN 0.60 and still having the issue.

I am also facing the same issue across for all android 6.0 version. not for lower ones and higher ones

I was able to fix for my app using kind of a workaround. used
android:hardwareAccelerated="true"
in the AndroidManifest.xml for Application tag.

We had this exact issue and were able to fix it by doing the following:

⛄ These directions are not the same as on the jsc-android README. We've modified version numbers and some signifiers. The canary version of jsc does not fix the issue. It's the version after jsc-android@canary that's needed, see: This Patch for the original fix that was merged into the react-native repo. Thanks to @ravali121 for helping solve this.

Add jsc-android to the "dependencies" section in your package.json:

dependencies {
+  "jsc-android": "^245459.0.0",

then run npm install or yarn (depending on which npm client you use) in order for the new dependency to be installed in node_modules

Modify android/build.gradle file to add the new local maven repository packaged in the jsc-android package to the search path:

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
+       maven {
+           // Local Maven repo containing AARs with JSC library built for Android
+           url "$rootDir/../node_modules/jsc-android/dist"
+       }
    }
}

Update your app's build.gradle file located in android/app/build.gradle to add the JSC dependency.  Please make sure the dependency is before the React Native dependency.

dependencies {
+   // Make sure to put android-jsc at the top
+   implementation 'org.webkit:android-jsc:+'
    compile fileTree(dir: "libs", include: ["*.jar"])
    implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
    implementation "com.facebook.react:react-native:+"  // From node_modules
}

Update your app's build.gradle file located in android/app/build.gradle to use first matched JSC library.

android {
    // ...
+   packagingOptions {
+       pickFirst '**/armeabi-v7a/libc++_shared.so'
+       pickFirst '**/x86/libc++_shared.so'
+       pickFirst '**/x86_64/libc++_shared.so'
+       pickFirst '**/arm64-v8a/libc++_shared.so'
+       pickFirst '**/libjsc.so'
+    }
}

Here's a fix if your issues are related to JSC on React 0.59 (https://github.com/facebook/react-native/issues/24261#issuecomment-548149232)

the reason for the crash maybe def enableProguardInReleaseBuilds = true. make it false

Update the react version to react 61.5 ..then it will work fine

I have an error using
gradlew bundleRelease with react native 61.5

Task :app:bundleReleaseJsAndAssets
warning: the transform cache was reset.
Loading dependency graph, done.
error Unable to resolve module ../components/AppStateListener from screens\WebScreen.js:

seems that the bundle is not able to read the component ?
The error is the same  using:
react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res
Please help.

I'm in 61.5 still crashing.

i faced the same issue
i try to check the begining of crash log: adb logcat -d
then i saw this error message:
AndroidRuntime: java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/swiperefreshlayout/widget/SwipeRefreshLayout;
i solved it using this link
https://stackoverflow.com/questions/56901873/swiperefreshlayout-error-on-a-react-native-app-after-androidx-migration

This problem may be related to react-native-screens. Please try. It worked for me.
Add the following two lines to dependencies section in android/app/build.gradle.
implementation 'androidx.appcompat:appcompat:1.1.0-rc01'
implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0-alpha02'

@compojoom I am also experiencing this issue in android after I have migrated to RN 0.59 and added abi filters to support for 64bit android support arm64-v8a and x86_64.
When I remove them and work with armeabi-v7a and x86 the android app works fine.
My app crashes as soon as I start going into react-navigation and crashing in Samsung galaxy S7 having Android Version 6.0.1(it has both 64 bit OS and CPU) while working fine in most of the devices I have.
Logcat Response:

Same issue is coming after I try it with a fresh RN project with v0.59

Thanks. It worked in my case

two easy steps solved my problem...
open android studio and remove offline bundle from src/main/assest..(** if any)
open MainApplication.java and remove the following import..
import com.facebook.react.BuildConfig


[ko] cs-229-supervised-learning

WIP :)

Thank you a lot for your work @rickiepark! One small comment: could you please just keep the supervised learning file in the PR? That way, merging will not cause any conflict.

Hi @shervinea,
Sorry, I'm lots of thing to do these days.
I don't mind someone continue my work.
Thanks.

Ok that works, thank you for your prompt feedback @rickiepark!

Seems like no one has taken over his work yet. Can I take an honor to continue @rickiepark 's translation?
What would be the best way that I can continue working on top of his work while keeping his contribution intact?

That would be great, thank you for your help @kimdanny! You could create a new pull request and start from the current progress. We'll have to make sure to not forget to include @rickiepark in the CONTRIBUTORS file as well.

Continuation of this work at #214.


rewrite the entire bot for slash commands

hopefully it works :trollface:

im a cat has been readded

insane. great job


WIP: [Release Preparation] Improve workflow

Description:
We need to rework the run-tests stage and provide the ability to launch test runs.
Changelog:
Launch test run:

Add test-run input to launch test run;
Update branch name generation script to to respect test-run input;
Update merge-for-release stage definition to respect test-run input;
Update get-release-sha stage definition to respect test-run input;

Running tests:

Rename run-tests to run-unit-tests;
Update commands to run unit tests;
Add run-integration-tests stage.

Testing report
Expected behavior

Basic run: Bump version, Generate changelog, Merge changes to target branch, Remove target branch
Test run: Bump version, Generate changelog, Don't merge changes to target branch, Use temp branch for subsequence stages
Partial execution: If the version is bumped up or a changelog is generated (or both conditions are met), the flow should skip subsequent steps.

Testing result (Summary)

Case
dbt-core-release-test
dbt-snowflake-release-test

Basic run
✅

Test run
✅

Partial execution
✅

Detailed report - dbt-core-release-test
Case №1
Description:
Basic run:

Bump version;
Generate changelog;
Merge changes to target branch;
Remove target branch.

Details
Pre-requirements:

Commit: fee78852651b56f992078c78d4b0aa04bdc3bbc6
Target branch: users/alexander-smolyakov/test-release-prep-workflow

Workflow inputs:
The last commit sha in the release:   fee78852651b56f992078c78d4b0aa04bdc3bbc6
The release version number:           1.4.0b1
The branch that we will release from: users/alexander-smolyakov/test-release-prep-workflow
Test run:                             false
Python target version:                3.8
Notification prefix:                  [Release Preparation]

Workflow output:
Final SHA:      faf63a4a71b0b4919b3e6a68178e7ba12ce6af4c
Changelog path: .changes/1.4.0-b1.md

Link to workflow run(s):

https://github.com/dbt-labs/dbt-core-release-test/actions/runs/3740602850

Outcome:

Created temp branch prep-release/1.4.0b1_3740602850;
Version bumped from 1.4.0a1 to 1.4.0b1 in ae8285ea8734ef3f6528f15d887fee342bc17032;
Generated changelog for 1.4.0b1 in ae8285ea8734ef3f6528f15d887fee342bc17032;
Unit tests are passed;
Changes from prep-release/1.4.0b1_3740602850 merged to users/alexander-smolyakov/test-release-prep-workflow in faf63a4a71b0b4919b3e6a68178e7ba12ce6af4c;
Temp branch prep-release/1.4.0b1_3740602850 removed;

Result: Test passed - ✅

Case №2
Description:
Test run:

Bump version;
Generate changelog;
Don't merge changes to target branch;
Use temp branch for subsequence stages.

Details
Pre-requirements:

Commit: fee78852651b56f992078c78d4b0aa04bdc3bbc6
Target branch: users/alexander-smolyakov/test-release-prep-workflow

Workflow inputs:
The last commit sha in the release:   fee78852651b56f992078c78d4b0aa04bdc3bbc6
The release version number:           1.4.0b1
The branch that we will release from: users/alexander-smolyakov/test-release-prep-workflow
Test run:                             false
Python target version:                3.8
Notification prefix:                  [Release Preparation]

Workflow output:
Final SHA:      665e5f5fdffd3848743611e098ad81b84326fcba
Changelog path: .changes/1.4.0-b1.md

Link to workflow run(s):

https://github.com/dbt-labs/dbt-core-release-test/actions/runs/3740676459

Outcome:

Created temp branch prep-release/test-run/1.4.0b1_3740676459;
Version bumped from 1.4.0a1 to 1.4.0b1 in 665e5f5fdffd3848743611e098ad81b84326fcba;
Generated changelog for 1.4.0b1 in 665e5f5fdffd3848743611e098ad81b84326fcba;
Unit tests are passed;
Changes from prep-release/test-run/1.4.0b1_3740676459 were not merged into the target branch;
Temp branch prep-release/test-run/1.4.0b1_3740676459 not removed;
The final commit SHA is from temp branch prep-release/test-run/1.4.0b1_3740676459.

Result: Test passed - ✅

Case №3
Description:

Partial execution: If the version is bumped up or a changelog is generated (or both conditions are met), the flow should skip subsequent steps.

Details
Pre-requirements:

Commit where version bumped and changelog generated: faf63a4a71b0b4919b3e6a68178e7ba12ce6af4c
Target branch: users/alexander-smolyakov/test-release-prep-workflow

Workflow inputs:
The last commit sha in the release:   faf63a4a71b0b4919b3e6a68178e7ba12ce6af4c
The release version number:           1.4.0b1
The branch that we will release from: users/alexander-smolyakov/test-release-prep-workflow
Test run:                             false
Python target version:                3.8
Notification prefix:                  [Release Preparation]

Workflow output:
Final SHA:      faf63a4a71b0b4919b3e6a68178e7ba12ce6af4c
Changelog path: .changes/1.4.0-b1.md

Link to workflow run(s):

https://github.com/dbt-labs/dbt-core-release-test/actions/runs/3740784065

Outcome:

The workflow determined that the version was bumped, and a changelog was generated for provided commit. The subsequent steps were skipped.
The final SHA is set to commit SHA, provided via workflow inputs.

Result: Test passed - ✅


Lazy loading plugs

Currently all plug code is loaded upon boot, whether it is invoked or not. To speed up boot time, it would be more efficient to only spin up a plug’s worker when the first function is invoked. This would be fast and save memory as well.
The challenge to overcome here is that the manifest (specifying where plugs hook into the system) is embedded in the worker JS file, and currently it needs to be loaded to extract it. A potential solution here could be to embed the manifest as a JSON string in the plug bundle file, which can be extracted through a simple regex code scan without actually having to execute the code. This may require recompiling all plug code, however with some extra effort a failed manifest code scan could just result in loading the plug by default.

Implemented


multiple awsnodetemplate security groups via awsIds broken between 0.30.0 and 0.31.3

Description
Observed Behavior:
In a spec with multiple awsIds for security group selector:
  ...
  Security Group Selector:
    Aws - Ids:  sg-0000000000000001, sg-0000000000000002, sg-0000000000000003
  ...

the resulting awsnodetemplate is only assigned the first security group when karpenter controller = v0.31.3 :
Status:
 ...
  Security Groups:
    Id:    sg-0000000000000001
    Name:  eks-cluster-sg-example-0000000001

Expected Behavior:
the awsnodetemplate should be assigned all security groups, working as expected in v0.30.0 :
Status:
  ...
  Security Groups:
    Id:    sg-0000000000000001
    Name:  eks-cluster-sg-example-0000000001
    Id:    sg-0000000000000002
    Name:  atmos-sg-examplesg-0000000001
    Id:    sg-0000000000000003
    Name:  atmos-sg-otherexamplesg-0000000001

Reproduction Steps (Please include YAML):
where ${awsIds} is a comma separated list of valid security group IDs, kubectl apply the following to a cluster running v0.30.0 ( may require some editing based on your environment, ex: subnet names  :
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  name: default
spec:
  amiFamily: AL2
  amiSelector:
    aws::name: amazon-eks*-node-*
    aws::owners: amazon
  blockDeviceMappings:
    - deviceName: /dev/xvda
      ebs:
        volumeSize: 100Gi
        volumeType: gp3
        encrypted: true
  subnetSelector:
    Name: private*
  securityGroupSelector:
    aws-ids: ${awsIds}

  userData: |
    MIME-Version: 1.0
    Content-Type: multipart/mixed; boundary="BOUNDARY"

    --BOUNDARY
    Content-Type: text/x-shellscript; charset="us-ascii"

    #!/bin/sh
    set -e
    --BOUNDARY--
---

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  providerRef:
    name: default
  requirements:
    - key: karpenter.k8s.aws/instance-category
      operator: In
      values: [ c ]
    - key: karpenter.k8s.aws/instance-size
      operator: In
      values: [ large, xlarge, 2xlarge ]
    - key: karpenter.sh/capacity-type
      operator: In
      values: [ on-demand ]
    - key: kubernetes.io/arch
      operator: In
      values: [ amd64 ]
    - key: kubernetes.io/os
      operator: In
      values: [ linux ]

confirm awsnodetemplate includes all ${awsIds} security groups
update karpenter controller to 0.31.3
confirm awsnodetemplate includes only first ${awsIds} security group
( if drift is enabled nodes will start to drain/replace with incorrect SGs )
Versions:

Chart Version: 0.31.3
Kubernetes Version (kubectl version): 1.25.16 / 1.24.17

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

This bug was caught and fixed here: https://github.com/aws/karpenter-provider-aws/pull/5128 and was ported into v0.32.2. I'd recommend upgrading to that version to fix this issue. Though that version contains support for beta apis, installation and behavior in that version should continue to work the same.

Closing this since the bug is resolved in v0.32.x


CUJ Testing for Beta v2 - Creator can Apply or Save Text Style from/to Their Preset Library

Feature Description
In preparation for the Beta 2 release we would like to have validation and confirmation of the CUJ functionality detailed in
https://github.com/google/web-stories-wp/issues/1630

[ ] Click to apply a style to a text element
[ ]  Save text style to preset
[ ]  Delete text style

Not in scope for Beta 2 release


[TickTick] ...

Extension
https://www.raycast.com/appest/ticktick
Description
Allow marking tasks as 'done' in raycast itself instead of having to open the app
Who will benefit from this feature?
No response
Anything else?
No response

@sky02x Thanks for your feedback, we are consider to develop this feature and we will notify you when it is launched.

@sky02x  Hi, the complete task feature has been published to the store. (Require TickTick macOS app version 5.4.61 and the latest TickTick Raycast extension)

@raycastbot close this issue


frost-select: popup display location needs to be smarter

Currently when you open up a select or multi-select box the list is always below the entry. Furthermore, there is no logic to prevent the box from getting cut off on the bottom of the screen.
There are a few different schemes that can ensure the contents are always visible. A simple one is to just  move the window up so the bottom never goes past the end of the screen. A good example I noticed is the window that comes up in gmail giving you different actions you can take on a message. Even though the window scrolls the display avoids cutting the window off. If it is possible that someone would want the window location fixed below we could add a property for that.
Also is there any logic for the window height to stop growing and switch to scrollbars for larger numbers of items? I want that too.

Resolved in version 0.28.3


SHT31 I2C communication fails after SNTP gets time (IDFGH-12993)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
ESP-IDF v5.2.1-dirty
Espressif SoC revision.
ESP32 v3.0
Operating System used.
Windows
How did you build your project?
Eclipse IDE
If you are using Windows, please specify command line type.
CMD
Development Kit.
ESP32 LoLin
Power Supply used.
USB
What is the expected behavior?
SHT31 and SNTP work together without any issue.
What is the actual behavior?
SHT31 measure the temperature and humidity perfectly but when the SNTP time synchronization is finished the I2C communication  will be broken and ESP can't communicate with the sensor anymore. The strange thing is that on the same pins there is a OLED display which continoues working.
Steps to reproduce.
Connect SHT31 to ESP32 board.
Connect WiFi.
Synchronize time.
Debug Logs.
-

More Information.

@paduc77 If an OLED display is connected to the very same pins as the SHT31, isn't it possible that these two devices interact with each other and cause the issue?

@0xjakob Thanks for the hints, but without SNTP or when the SNTP is not synchronized the OLED and SHT31 work together without any issue.

@paduc77 Does  https://github.com/espressif/esp-idf/issues/12860#issuecomment-2413975957 work for you?


Update certificate rotation documentation to match k8s cluster install guide

If developers follow the "Orchestrate Cockroachdb with K8s" documentation (https://www.cockroachlabs.com/docs/v20.1/orchestrate-cockroachdb-with-kubernetes.html) [1], they're using the official cockroachdb/cockroach Docker images in their pods (https://hub.docker.com/r/cockroachdb/cockroach/) [2]. This becomes problematic when attempting to rotate node certs following the "Rotate Certificates" documentation (https://www.cockroachlabs.com/docs/stable/rotate-certificates.html) [3], as the documentation contains commands that are not included in the base cockroach container (such as sudo or pkill). Additionally, when the reader is instructed to run scp certs/node.crt certs/node.key <username>@<node address>:~/certs, there is no consideration given to where the k8s guide (1) actually puts the certs in the nodes (/cockroach/cockroach-certs), or to the networking realities. If a developer is running the cluster in k8s, this command will never work without port-forwarding or using kubectl cp. Finally, this does not provide any insight into what "username" is expected (I made the assumption that root wasn't going to work; if the username expected for a vanilla cluster is "root" then there should be some doc around using the root cert).
I think updating this document (3) to walkthrough rotating certs after implementing a cluster using the k8s guide (1) would make it more useful to developers, as the little idiosyncrasies in the existing doc makes it hard to successful accomplish the walkthrough.
(related to: https://github.com/cockroachdb/cockroach/issues/51487 . Apologies if that's not the preferred way of linking these together)

cc @thtruo


When under load registry returns 500's

I've noticed a few times that when the registry is under heavy "write" load that sometimes it will start returning 500's on requsts until the writes have finished.
The error I'm seeing in the logs is:
s3aws: RequestError: send request failed
caused by: Get https://s3.amazonaws.com/bucketname/docker/registry/v2/repositories/namespace/name/_manifests/tags/tag_name/current/link: dial tcp: lookup s3.amazonaws.com on <IP_ADDRESS>:53: dial udp <IP_ADDRESS>:53: socket: too many open files

I'm not sure if this is a result of a socket leak issues or if there's a setting I can change to alter the number of open files. etc..

I'm not sure how many openfiles the registry is expected to use or needs to use but for reference:
$ ulimit -n
1024

$ lsof | wc -l
959


FR: Search Function for Tags

I use hundreds of tags, the lack of a search function makes it quite tedious to find the right tag 😅
SO a search function would indeed be very useful

Yes, this looks wonderfully promising, like a graph view for tags, but it's hopeless for me with so many tags that run off the screen.

Yes, this looks wonderfully promising, like a graph view for tags, but it's hopeless for me with so many tags that run off the screen.

If you combine tags into groups, it works fine


[Feat]: Add New Project

Is your feature request related to a problem? Please describe.
It is a new project in python .
Describe the solution you'd like.
It is a classic game like "Snake" using Python's Pygame library
Describe alternatives you've considered.
It provides a window, a controllable snake, food to eat, and basic collision detection
Show us the magic with screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@avinashkranjan Please assign me this issue

/assign


change lifecircle hook, OnInitialized is too early

Fixing error with redirect.

@microsoft-github-policy-service agree


[MOD] Hover Indicator

The hover indicator mod adds an outline to almost every element when it is hovered on. This can help with accessibility.
Features:

Able to change outline color
Able to change outline thickness

By the way, could you check out my little project too?
https://github.com/aclist/kbin-kes/raw/tests/omnibar/tests/omni.user.js
It's a standalone test at the moment, but this will be hooked up to KES logic so that it can be summoned at will rather than on page load.
Use arrow up/down to navigate, or type in the field to filter search results. Hit enter to jump to the desired mag. You can also use the mouse and click. If you hit Tab or click off the list it'll remove it.
Should look good and work well on mobile, too.
There are a few cosmetic bugs with mouse hover, but otherwise should be working. One thing to test is how it looks on other themes :roll_eyes:  (Looks like garbage on the purple theme, I know.) Hopefully you can help with that...

I just tested it, appears to be working good. What is it's purpose?

It's called an omnibar. Fast jump to one of your subscribed mags.

Tap some key to summon omnibar
Find your mag
Fast jump to it

Maybe that wasn't obvious enough?

o yea i see that now. i didn't realize bc it doesnt yet display all the subscriptions. looks like it is working well tho

i didn't realize bc it doesnt yet display all the subscriptions

Hmm, can you elaborate? I only have a few subscriptions tested. If you have a ton, it should be scrollable. But the point is you type to filter down the list.
I'm wondering if you're describing a bug or something else.

oh, yea i do have quite a bit of subscriptions, upon reloading a few times I can scroll it as it shows more mags. it shows mags i am not subscribed to, and my actual subscriptions aren't in there as can be seen when i type to find a few. also, how do i spawn this without reloading page, if i can atm?
https://github.com/aclist/kbin-kes/assets/137783738/360d41d9-f837-4fdf-b98c-0656c88ed6c6

Oh hahaha, I am so dumb, I hardcoded it to my subscriptions list and was just randomly adding and deleting magazines lol.
OK, so I need to check the user's actual name and handle the scrolling better.
As for opening it on demand, I didn't add that yet, will probably be the last thing I do. Just a test now.

Alright, I've fixed it a bit (v 0.2) thanks to your astute observations lol. It should fetch your actual subs list now, be more compact, and have a scrollbar. It won't load immediately on the page. Hit Tab (using that as a test key for the time being) to summon it, then Tab again to close it. It takes a second right now because it fetches the list each time, but will change it to cache the results to make loading faster.

working good now, all my subs are there! tab working as well

Thanks! I'll just add a few more things and eventually integrate it into KES. Does Tab seem problematic? We can basically hijack any key, but never sure what kinds of keys people expect to have access to for other purposes.
Is this hover indicator mod ready to go, or are you still working?

hover indicator is ready, i worked out the conflict. now i am onto another accessibility script :D one for adjusting the sites color, warmth, hue, contrast, saturation, etc etc
i dont ever use my keyboard for navigation, so i am honestly unsure if it would be an issue for others. for me, it isn't an issue. i would be using tab for text areas if i could, but kbin doesn't support that for some reason, so it's no issue. i don't use it. perhaps the user should be able to set their own shortcut?

hover indicator is ready, i worked out the conflict.

OK, cool, will review and merge. Released 2.1.0 earlier today, so this will go into the next release.

now i am onto another accessibility script :D one for adjusting the sites color, warmth, hue, contrast, saturation, etc etc

Sounds good!

as for the tab key, i am honestly unsure if it would be an issue for others. for me, it isn't an issue. i would be using tab for text areas if i could, but kbin doesn't support that for some reason, so it's no issue. i don't use it. perhaps the user should be able to set their own shortcut?

Yeah, I just thought of that. We should be leaning towards letting you choose what you want rather than enforcing anything. I'll just offer an assortment of meta key options and let them choose, I think. I don't want to set up a whole "input any key combo" feature, though, as it'll introduce problems. You definitely raise  a good point that tab should be used for navigation.
You stealth edited that post like 5 times, I saw it change before my eyes :P
You're the exact opposite of me, I don't use the mouse for anything.

You stealth edited that post like 5 times, I saw it change before my eyes :P

LMFAO you saw that 😭 yea i realized too late i didn't word what i meant right several times in a row apparently hahahah

I don't use the mouse for anything.

i use my trackpad on my laptop for everything 😭😭

@aclist can the range input increment by 0.1? cant seem to get it to work like that

Should be, yeah; <input type="range" min="1" max="100" step="0.1">. Not working?

Looks like step support wasn't added when somebody created the range function, will add it now.

o okay nice :D ty ty

Haven't tested this yet but will do so today.

Just merged this so I could test it a bit more quickly, everything seems essentially fine, but did you check out some of the links on the navbar (e.g. KES icon, notipanel bell) or below post comments (e.g. reply, boost, more)? When there are links within outer link elements, it creates a kind of nested box. Notably on the KES icon, which is an outer element, an inner holder element, then a wrench icon, then the "updates available" notifier, so it's a total of four boxes:

Any thoughts on that? This also seems to happen on upvote/downvote buttons, though to a lesser degree, because the "number" count and the "arrow" icon are sub-elements of the outer vote box, even though only the vote box registers as a click here. It seems like ignoring icons () might be worthwhile?
It's also somewhat noticeable on avatar icons in thread replies.

By the way, the manifest generator should have all basic JSON functionality for generating the different field types now. The visual preview isn't working yet, but the content copied to clipboard should be correct and ready to drop in to any manifest.

but did you check out some of the links on the navbar (e.g. KES icon, notipanel bell) or below post comments (e.g. reply, boost, more)?

i noticed some nested boxes but it didnt seem to look that bad to me.

maybe it could be that it only puts the outline on the outermost parent? not sure how well that would work. not sure how easy or hard it would be to select the correct parent of something since everything is nested.

It seems like ignoring icons () might be worthwhile?

yea thats fine. i added it for cases such as this, and really any time that you are needing to click anything represented as an icon:

the manifest generator should have all basic JSON functionality for generating the different field types now

awesome

Yeah, that is a good point. You don't want to ban all icons altogether. It doesn't seem like an issue on too many elements, mostly things where there is a span tag wrapping a link or an icon, so maybe just adding specific exclusions for those would be better than trying to have some abstracted logic that might potentially fail on other stuff?
For example:

if navbar, only hover the outer elements
if thread comment buttons, same thing?
if vote buttons, only the outer container?

On post headers, the header is actually a header box, plus the thread link itself, and optionally the metadata showing that URL it originated from, and you would potentially want to click either the thread link or the metadata, but is the outer hover on the h2 element needed? Hope this description makes sense.
If I understood correctly, the hovering should aid targeting clickable elements, right? If that's the case, it seems reasonable to reduce it to the "minimum clickable element" rather than all elements. And if the hover is meant to just highlight the focused element for tracking purposes, it still seems like too much nesting might actually make it hard to see what you are hovered on.

One other area to think about:
If you have a list of items with links within them, the links are the only clickable part:

For example, in the kbin footer, if you highlight the li, it's not actually a clickable link until you hover the a itself. So should the li actually be highlighted here, or only the inner a?
It depends on whether the answer is "hover for clickability" or "hover for visibility." Seems like it might be one or the other, or both, depending on certain situations.

If I understood correctly, the hovering should aid targeting clickable elements, right?

actually i didnt make it with that in mind, i just made it with the idea that no matter what you're hovering over, it will indicate the element you're on (thats why you can hover over the comments and more), but it would make more sense to do it for just clickable things

Not necessarily, maybe we can find more accessibility information about these kinds of needs. I just assumed that targeting something means you want to click on it, but maybe it's more of a navigational aid? By the same token, I'm not sure when would be a situation where you need to know that you are hovering an icon within a button, but maybe there is something to this if we think about it?

navigational aid

thats the purpose i intended it to have yea.

I'm not sure when would be a situation where you need to know that you are hovering an icon within a button

i agree i dont think this is necessary, i just didnt get super complex with it and rule out those situations when i should have, and for some things i didnt know how

That is fine, I don't want to change it. I will just tweak some of the more heavily nested areas, if that is OK?

oh im just saying what i originally was thinking. i dont care at all what is done to it, do whatever

OK, cool. I didn't see your message until now for some reason.

OK, I added a few exclusions to the hover conditions on testing if you wanna check it out.

looking good


k_uptime_get() is not accurate on NXP platform in zephyr 3.2.0

I've observed time difference between k_uptime_get() and real time. After 24h there is -55min of difference, so it's not acceptable. gpt_hw_timer is used as tick source for the kernel and by default TICKLESS KERNEL is enabled. External 32.768kHz quartz accuracy is 6ppm and gpt timer use that quartz. Tested on custom hardware with RT1062CVJ5B.
Workaround is to not use TICKLESS KERNEL.
After that change time difference after 24h is almost 0s.
IMO there can be some BUG in nxp_gpt_hw_timer driver.
To Reproduce:
Steps to reproduce the behavior:

Enable gpt_hw_timer:

&gpt_hw_timer {
	status = "okay";
};

Be sure that CONFIG_TICKLESS_KERNEL=y
Check time difference using k_uptime_get() after 24h

Expected behavior:
Time difference should be exactly accuracy of the 32k quartz.
Impact:
Kernel uptime is not precise and it has affect for the functions like k_sleep() etc.
Environment:

OS: Debian 11
Toolchain Zephyr SDK 0.15.0
Zephyr 3.2.0

I was able to reproduce this BUG on MIMXRT1020-EVK but time difference is much smaller -156s/day. Probably system load can have impact to it. I've modify sample code blinky and add three task with continuously changing sleep time of each task.
#include <zephyr/kernel.h>
#include <zephyr/drivers/gpio.h>

static void task1_loop(void *par1, void *par2, void *par3);
static void task2_loop(void *par1, void *par2, void *par3);
static void task3_loop(void *par1, void *par2, void *par3);

K_THREAD_DEFINE(task1_thread, 256,  task1_loop, NULL, NULL, NULL, 7, 0, 0);
K_THREAD_DEFINE(task2_thread, 256,  task2_loop, NULL, NULL, NULL, 7, 0, 0);
K_THREAD_DEFINE(task3_thread, 256,  task3_loop, NULL, NULL, NULL, 7, 0, 0);

#define SLEEP_TIME_MAX_MS 100
#define LED0_NODE DT_ALIAS(led0)

static const struct gpio_dt_spec led = GPIO_DT_SPEC_GET(LED0_NODE, gpios);

static void task1_loop(void *par1, void *par2, void *par3)
{
	uint32_t delay = 25;

	printk("Started %s\n", __func__ );
	while (1) {
		gpio_pin_toggle_dt(&led);
		k_msleep((int32_t)(delay % SLEEP_TIME_MAX_MS));
		delay++;
	}
}

static void task2_loop(void *par1, void *par2, void *par3)
{
	uint32_t delay = 50;

	printk("Started %s\n", __func__ );
	while (1) {
		gpio_pin_toggle_dt(&led);
		k_msleep((int32_t)(delay % SLEEP_TIME_MAX_MS));
		delay++;
	}
}

static void task3_loop(void *par1, void *par2, void *par3)
{
	uint32_t delay = 75;

	printk("Started %s\n", __func__ );
	while (1) {
		gpio_pin_toggle_dt(&led);
		k_msleep((int32_t)(delay % SLEEP_TIME_MAX_MS));
		delay++;
	}
}

void main(void)
{
	int ret;

	if (!device_is_ready(led.port)) {
		return;
	}

	ret = gpio_pin_configure_dt(&led, GPIO_OUTPUT_ACTIVE);
	if (ret < 0) {
		return;
	}

	printk("Initialized %s\n", __func__ );
}

Device was started at 16:05:00. Next day at 8:46:00 I've checked elapsed ms:
uart:~$ *** Booting Zephyr OS build zephyr-v3.2.0  ***
Initialized main
Started task1_loop
Started task2_loop
Started task3_loop

uart:~$ kernel uptime
Uptime: 59950882 ms

Time difference is -109s. Approximately -156s/day

I've noticed that the time difference gets bigger with more system load. When I changed #define SLEEP_TIME_MAX_MS 5 then the time difference is -1610 s/day. For #define SLEEP_TIME_MAX_MS 2 the time difference is -3550 s/day.

Hi @awojak, just an initial question- does your application require the GPT hardware timer? Since Zephyr 3.3 we have switched RT boards to use the Systick timer by default (due to issues like the one you have encountered here): https://github.com/zephyrproject-rtos/zephyr/pull/53028 If you do not need to utilize low power features in your application, using the systick timer may be a good short term solution.

Hi @danieldegrasse, I utilize low power feature in my application, so systick is not the solution. Temporary gpt2 CNT register could be used for counting time, but finally, a correct solution should be found.

@danieldegrasse is it possible to fix this ? It is quite important in our project.

@awojak A fix should be possible, yes. It will take some time to verify it though, given the way that you have reproduced the problem

@awojak I've created https://github.com/zephyrproject-rtos/zephyr/pull/56251. I would like to run additional regression tests against this PR before it is merged, but from my testing it seems that the time difference has improved. I ran your uptime test over the weekend, with the following results:
RT time difference checker started at 06:28:00 PM CDT 3/24/23

Time difference checker checked at 02:29:11 PM CDT 3/25/23 (346ms difference, 0 s/day)

Time difference checker stopped at 09:07:00 AM CDT 3/27/23 (Time difference is 1133 ms, 0 s/day)

This test was run with CONFIG_TICKLESS_KERNEL=y

@awojak, did @danieldegrasse PR #56251 address your problem? I would like to close this issue report if it did.

@dleach02 Problem is resolved, issue can be closed.


Added LGA field to referral as_tbody method. Improved test coverage.

This change is

Changes Unknown when pulling 475b8841d5d8d33b3f692e8d4ebaf33526c6de8a on ropable:master into ** on parksandwildlife:master**.


add preview GIF to assets and docs

Added preview GIF to assets folder on root repo
updated the documentation to include the Preview GIF for users

@tuhamworld I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: https://github.com/origranot/reduced.to/pull/454#pullrequestreview-1642702420

@tuhamworld Nice!
I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: https://github.com/origranot/reduced.to/pull/454#pullrequestreview-1642702420

Thank you for the feedback. Will make changes on that, and submit new PR
P.S: I noticed the expiration drop down isn't showing on my browser. Is that intentional?

@tuhamworld Nice!
I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: #454 (review)

Thank you for the feedback. Will make changes on that, and submit new PR
P.S: I noticed the expiration drop down isn't showing on my browser. Is that intentional?

Great 👍
About your question, yes it's on purpose.
The expiration dropdown is only available when you are logged in with a verified account.

@tuhamworld Nice!
I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: #454 (review)

Thank you for the feedback. Will make changes on that, and submit new PR
P.S: I noticed the expiration drop down isn't showing on my browser. Is that intentional?

Great 👍
About your question, yes it's on purpose.
The expiration dropdown is only available when you are logged in with a verified account.

Oh I didn't know about that.
Thank you for pointing it out.
Would you like the prefer to showcase the expiration too, or a simple URL shortening without delay is fine?

@tuhamworld Nice!
I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: #454 (review)

Thank you for the feedback. Will make changes on that, and submit new PR
P.S: I noticed the expiration drop down isn't showing on my browser. Is that intentional?

Great 👍
About your question, yes it's on purpose.
The expiration dropdown is only available when you are logged in with a verified account.

Oh I didn't know about that. Thank you for pointing it out.
Would you like the prefer to showcase the expiration too, or a simple URL shortening without delay is fine?

I think it will be better to make it as simple as possible.
I believe most of the users won't register and just use the url shortener as it it.

@tuhamworld Nice!
I think it will be better to show how it works without any delays / selecting the text and etc.
Look at my comment on the other PR: #454 (review)

Thank you for the feedback. Will make changes on that, and submit new PR
P.S: I noticed the expiration drop down isn't showing on my browser. Is that intentional?

Great 👍
About your question, yes it's on purpose.
The expiration dropdown is only available when you are logged in with a verified account.

Oh I didn't know about that. Thank you for pointing it out.
Would you like the prefer to showcase the expiration too, or a simple URL shortening without delay is fine?

I think it will be better to make it as simple as possible.
I believe most of the users won't register and just use the url shortener as it it.

That's quite true.
Less is better. Would work on the feedback

@tuhamworld I would prefer to see the full flow.
The gif you did is at great speed, can you just change the short url to this repository?
Also I think it will be great to click the button and let it redirect you to this repo.

@tuhamworld I would prefer to see the full flow.
The gif you did is at great speed, can you just change the short url to this repository?
Also I think it will be great to click the button and let it redirect you to this repo.

All right. Will work on that

I am unable to shorten the repository url.
It's saying invalid url

I am unable to shorten the repository url.
It's saying invalid url

Oh that's issue happens because we restrict urls that contains reduced.to (prevent recursion when redirecting)
That's another issue we can open to address this problem. Might need to strict the regex a bit.
I think you can reduce my gh profile, I pinned the repo 👏

@tuhamworld Also I think it better to import the gif from the file system itself (assets/usage.gif) instead of the gh link

I am unable to shorten the repository url.
It's saying invalid url

Oh this issue happens because we restrict urls that contains reduced.to (prevent recursion)
That's another issue we can open to address this problem. Might need to strict the regex a bit.
I think you can reduce my gh profile, I pinned the repo 👏

Oh I see.
You're right about preventing the recursion. With the new issue, you can make minor modification to allow the Github repo in the future

@tuhamworld Also I think it better to import the gif from the file system itself (assets/usage.gif) instead of the gh link

Will work on this

@tuhamworld Thank you for you contribution!
Merged!
Closes #451


Build/Push Snapcraft image on release

http://snapcraft.io/docs/build-snaps/ci-integration

Now, things should be a lot easier than that. You can just go to https://build.snapcraft.com and automate the continuous delivery with a few clicks.
I would like now to take a look at the client app, hopefully I'll have some time over the weekend to package it.


[Macos] add Android NDK 27 version to images.

Description
This PR consists of below changes
Add Android NDK 27 version to images.
makes default version to NDK 27.
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

Part of the changes shouldn't be done without announcement. Example:

https://github.com/actions/runner-images/issues/5595

Part of the changes shouldn't be done without announcement. Example:

[all OSs] Android NDK 22 will be replaced in favor of 24, version 23 will be set as the default one on June, 6 #5595

Please find below announcement:
[Macos] Android NDK 24 will be removed and 27 will be added , version 27 will be set as the default one on September,09 #10530


SAMP 0.3 DL ( build version windows && linux )

hello friend, if you can upgrade this plugin to be normal with 0.3 DL version
problems:
SA-MP Dedicated Server
v0.3.DL-R1, (C)2005-2018 SA-MP Team
[13:36:58]
[13:36:58] Server Plugins
[13:36:58] --------------
[13:36:58]  Loading plugin: sscanf
[13:36:58]
[13:36:58]  ===============================
[13:36:58]       sscanf plugin loaded.
[13:36:58]          Version:  2.8.1
[13:36:58]    (c) 2012 Alex "Y_Less" Cole
[13:36:58]  ===============================
[13:36:58]   Loaded.
[13:36:58]  Loading plugin: streamer
[13:36:58]
*** Streamer Plugin v2.9.2 by Incognito loaded ***
[13:36:58]   Loaded.
[13:36:58]  Loading plugin: FCNPC
[13:36:58]
[13:36:58] -------------------------------------------------
[13:36:58]      FCNPC - Fully Controllable NPC v1.8.2
[13:36:58]          Windows SA-MP Unknown
[13:36:58]           Jan  8 2018 at 01:14:48
[13:36:58]
[13:36:58]   Author:       OrMisicL (2013 - 2015)
[13:36:58]   Continued by: ziggi (2016 - present)
[13:36:58]   Contributors: kurta999, Neutralneu
[13:36:58] -------------------------------------------------
[13:36:58]
[13:36:58] Loading...
[13:36:58]   Loaded.
[13:36:58]  Loaded 3 plugins.
[13:36:58]
[13:36:58] Filterscripts
[13:36:58] ---------------
[13:36:58]   Loading filterscript 'animals.amx'...
[13:36:59]
[13:36:59]
[13:36:59]
[13:36:59]  =======================================
[13:36:59]  |                                     |
[13:36:59]  |        YSI version 4.00.0001        |
[13:36:59]  |        By Alex "Y_Less" Cole        |
[13:36:59]  |                                     |
[13:36:59]  =======================================
[13:36:59]
[13:36:59] [artwork:crc] blackpit.dff CRC = 0x223072E5
[13:36:59] [artwork:crc] blackpit.txd CRC = 0x918C9CD0
[13:36:59] [artwork:crc] bpitbull.dff CRC = 0x223072E5
[13:36:59] [artwork:crc] bpitbull.txd CRC = 0x996C19A1
[13:36:59] [npc:join] npc_0 has joined the server (499:<IP_ADDRESS>)
[13:36:59] [npc:part] npc_0 has left the server (499:0)
[13:36:59] [FCNPC] Error: NPC 'npc_0' not created. Name 'npc_0' is invalid or the maxnpc limit in server.cfg has been reached.
[13:36:59]   Loaded 1 filterscripts.
//
I really can not build it for myself through visual studio because I do not have that much time these days and I'm working on a good system that might be realized soon
you can see that system in the filter scripts haha

Have a look at #125


Enable notification upon file open

Description:
The notification is disabled here because of this issue https://github.com/ballerina-platform/ballerina-lang/pull/28053
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Fixed with https://github.com/prabushi/plugin-vscode/commit/1175d29dd25761f4b92617790ad0f9866d8adc85

This notification was removed with https://github.com/ballerina-platform/plugin-vscode/pull/279/commits/144e1c59e74dc17381b65a05ccea750612e3dd98 as it confuses the user.


[easy] Allow both m5 and r5 instances for running jobs on the aspen batch queue

Description
ingest and transform are both very single threaded, and require r5 instances.  align requires both cpu and memory, and m5 instances are more suitable.
Test plan
test in prod.

This may not be necessary, as align with 96 cores is only marginally faster than 16 (1h vs 1h40m).  It may make more sense to stick with r5.12xlarge (the smallest machine that can fit the dataset in memory).

Investigation suggests that there is a long single threaded portion with a short multi threaded portion.


initial page shows blank

When I force an initial page to something other than the first page it is rendering blank. Scrolling to other tabs will render data and then going back to that initial forced page renders the data correctly.
Using:
"react": "16.0.0-alpha.12",
"react-native": "https://github.com/expo/react-native/archive/sdk-21.0.2.tar.gz",
Any insights into fixing this would be great.

I have this problem too after updating my app to react-native 48.4
on react-native 49.3 also this problem exists.

Any luck on getting this fixed or an ETA? Seems like a big issue and is causing a lot of loading problems.

I'm about to release my app and this is a blocker. appreciate fast response

Same situation here

See here:
https://github.com/skv-headless/react-native-scrollable-tab-view/issues/762
I think it’s time to replace the library...

close for #750

You closed this and I downloaded the latest commit, but the issue is still happening.  Does this mean the updates you made have not been committed yet?

No, It is just duplication of #750

This https://github.com/skv-headless/react-native-scrollable-tab-view/issues/750#issuecomment-335413285 should work I think maybe I will make temporary solution with this patch

I followed that, but I'm using 0.8.0 version. There is no componentDidMount in that version to update what that person had said.

FYI - By putting in the componentDidMount code that was suggested that was missing from 0.8.0 version did the trick to get it back to functioning better.

delay load render scrollable-tab-view can resolve this question,you can set state,when open this page ,show an activityIndicator,after 500ms,change state,then render scrollable-tab-view,this is an temporary method,maybe ,wo can wait plaugs refresh
eg:if(this.state.delayShowScrollableTabView)
{
return(
<View style={{flex:1,backgroundColor:'#fff'}}>
<View style={{marginTop:screenHeight*0.4+99,alignSelf:'center',flexDirection:'row'}}>
<ActivityIndicator size={'small'}/>
Loading...
);
}else{
return (
<TouchableOpacity activeOpacity={0.95} style={newsNavRow.searchWrapper} onPress={()=> {this.props.navigation.navigate("NewsSearch_V2",{searchContent:"News"})}}>
<View style={{backgroundColor:'#204B7D',flex:1,alignItems:'center',justifyContent:'center',height:Platform.OS=="ios"?44:55,width:44}}>
<Image source={require("../images/searchNews.png")} style={{height:20,width:20}}/>
<View style={{flex:1,width:30,height:Platform.OS=="ios"?44:55,zIndex:11,position:"absolute",top:0,right:44}}>
<Image source={require("./../images/overlayGradient.png")} style={{width:30,height:Platform.OS=="ios"?44:55}} resizeMode={Image.resizeMode.stretch}/>
{newsListView}
{this.getUserVerifiedModal()}
);
}


Div doesn't resize to small amount of rows (see image)

There is a lot of whitespace left if the rows displayed are less than ~10 rows. See the screenshot below.

I'm posting this as an issue to seek any feedback prior to a PR.

Yeah, it would be great if this was fixed. I know that react-data-grid has a lot of constraints when it comes to sizing as it doesn't render all cells at once, only those in the viewport.
I recommend looking through the react-data-grid repo for similar issues. For example, https://github.com/adazzle/react-data-grid/issues/207 and https://github.com/adazzle/react-data-grid/issues/736
Let me know if you need any help getting started!

See PR27

Fixed in #27


⚠ Bofrost.fr has degraded performance

In 599e4ae, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 903 ms

Resolved: Bofrost.fr performance has improved in 021dd2e after 6 minutes.


fix: Update create did method

Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
Base: 90.27% // Head: 90.27% // No change to project coverage :thumbsup:

Coverage data is based on head (85aa4a3) compared to base (f51873e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   90.27%   90.27%
=======================================
  Files           4        4
  Lines          72       72
=======================================
  Hits           65       65
  Misses          5        5
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix for issue 27, "Allow externally-provided *http.Client"

This is a very straightforward implementation, and I'm open to doing it differently if you prefer.
In particular, it might be a bit simpler just to pass the entire api *Client reference straight to all the *Request() functions, rather than passing httpClient and debug separately.
Also, it might be easier (though a bit more subtle) to allow nil as the *http.Client parameter to New(), so that people don't have to know to grab http.DefaultClient. It would be nicer with optional function parameters, but I'd also be fine with separating that into a second NewWithClient() or similar function.

Sorry, just got back to this.
Thanks for all the work you put in this.
Everything looks good. I have a preference for something like:
    api := slack.New("YOUR_TOKEN_HERE") # this would set the httpClient to the default of course
    api.SetHttpClient(yourHttpClient)
    channels, err := api.GetChannels(false)

versus
    api := slack.New("YOUR_TOKEN_HERE", http.DefaultClient)
    channels, err := api.GetChannels(false)

The reason is to keep backwards compatibility. passing the client to .New makes sense but would break all the clients out there.
What do you think?

Oh, right, of course. Don't know why I didn't think about the compatibility issue. I'd be fine with either your suggestion of adding a mutator for the http.Client, or adding a second NewWithClient() or similar function. I have a very slight allergy to the mutator, in that generally you'll want to set it only once -- I don't see anything in the current code that would break if you re-set the client multiple times, but it could become a bit of a constraint on future changes.
Let me know which you prefer, and I'll update the PR.

A good solution for this would be to implement functional options. That way the default could work as you want it, and you could add whatever options you want as functions that modify the config.
See http://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis :-)

@flexd Good point, and that would be source-compatible with the existing API. @nlopes That work for you?

Indeed. Good shout.

There's now an HTTPClient package level variable, which can be changed so that it can use a custom http.Client fixed in #73. I'll close this for now.


fix: sparkle error log (forwardRef)

This is kind of a headless UI bug IMO (or at the very least, a footgun), because the stock Menu.Button doesn't forward the ref. Using as="div" allows to actually forward it.
Quite a long fight to fix: https://github.com/orgs/dust-tt/projects/3?pane=issue&itemId=39805682

Nice solution. The weird thing is that it’s unrelated to the ref we use I removed it entirely and still has the bug. Maybe the Transition but?
Anyway if this fixes that’s great

Nice solution. The weird thing is that it’s unrelated to the ref we use I removed it entirely and still has the bug. Maybe the Transition?

Anyway if this fixes that’s great

I know I tried too. I tried to remove everything. I don't really get it. But I'm happy the error log is gone.


vaultwarden.webvault: 2022.10.0 -> 2022.12.0

Description of changes
https://github.com/dani-garcia/bw_web_builds/releases/tag/v2022.12.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

to be included in https://github.com/NixOS/nixpkgs/pull/207595


L2-373: Spawn Neuron

Motivation
Method to spawn a neuron from maturity.
Changes

New method in governance service "spawnNeuron".

Tests

Test for new method "spawnNeuron".

@peterpeterparker @mstrasinskis please review


Add chartmuseum2oci tool

Hello,
As discussed in the last Harbor Community Meeting, I developed a script in golang to migrate Helm charts from Chartmuseum to OCI.
I developed it for our customers, I think it may be useful to others Harbor users.
The main difference with the existing tool is that you don't need to setup a local Harbor with replication.
The script does everything, it pulls Helm charts from Chartmuseum and push it to OCI.
A progress bar is displayed during the migration to see the progression and having an estimated ETA:
$ docker run -ti --rm goharbor/chartmuseum2oci --url $HARBOR_URL --username $HARBOR_USER --password $HARBOR_PASSWORD
2023/06/28 16:17:32 416 Helm charts to migrate from Chartmuseum to OCI
   4% |█████                                                                                | (19/416, 20 it/min) [56s:19m36s]

PS: This PR is a follow-up of https://github.com/goharbor/harbor/pull/18866
Thomas

@Vad1mo is it ok for you ?

Thank you.

Hurray :)

I got the above error, even though I exported the password

@cuonghqRose, error message is quite clear:
Missing required - -password flag --password
So use --password instead of -p

@cuonghqRose, error message is quite clear:
Missing required - -password flag --password
So use --password instead of -p

thanks for your answer, but I still get the same error despite fixing the --password  flag. I still don't understand where I went wrong, hope you can reply soon. Thank you very much

Sorry, can't reproduce your error. make sure you quote correctly the password env var. Maybe this is the case.
docker run -ti --rm goharbor/chartmuseum2oci --url 'https://demo.goharbor.io'  --username admin  --password 'Harbor12345'
2023/08/29 15:24:35 fail to retrieve helm charts to migrate: fail to migrate charts from project dhorse: fail to list harbor projects: response status code does not match any response statuses defined for this endpoint in the swagger spec (status 404): {}


unwrap error on 16x16 tiles

Description
When I open SMWE, create a new project, open Tools -> 16x16 tiles, click + on level number until it's 0060 and click + again, it creates a panic like this:
thread 'main' panicked at smwe-rom\src\graphics\mod.rs:110:82:
called `Result::unwrap()` on an `Err` value: TileFromWramError(AddrSnes(0x7EB440))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\smw-editor.exe` (exit code: 101)

Screen recording

Hi, the 16x16 tiles window won't end up in the final editor, it was only supposed to help me see if I was decoding the graphics data correctly and it will not be worked on any further.
Ongoing development currently happens on the level branch where we use a different rendering method (using an SNES emulator) anyway.


Cannot close a toilet on a certain day (opening hours)

The toggle switch to turn a toilet from 'closed' to 'opening hours' on a certain day, does not turn off again.
I've tried deleting the numbers in the opening hours field, and clicking 'update toilet' to try to close a toilet on that day. This doesn't load a new page to confirm that the toilet has been updated - it stays on the edit page.
Though the toggle button looks squished on Safari, this happens on both Safari and Chrome.
e.g. https://www.toiletmap.org.uk/loos/3d96d12c38bf7edb22624957/edit
This cafe at Westminster Central Hall is closed on Sat & Sun. I 'opened' it on Saturdays to test the opening hours, and now I cannot close it again!

hey Gail, will take a look!


Installation in documentation

The installation instructions flow like:

pip install
we recommend creating a Conda env
hello world

For those that aren't familiar with Conda, they may think that creating the Conda env (with a name that mentions sbi might perform the installation. It might be worth switching Conda and pip install, or to point to the environment file for the sbi env you have here:
https://github.com/mackelab/sbi/blob/main/environment.yml

Yes, good point @cranmer . We will change it accordingly.


Handle cases where SPICE pointing information is not available

Add try catch around rotation matrix calculation and if not available set roll, yaw and pitch to nans.

Test fails seem unrelated.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (6dd8193) 76.99% compared to head (fb4d4dd) 77.01%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   76.99%   77.01%   +0.01%
==========================================
  Files          63       63
  Lines        6599     6604       +5
==========================================
+ Hits         5081     5086       +5
  Misses       1518     1518

Files Changed
Coverage Δ

stixcore/ephemeris/manager.py
91.32% <100.00%> (+0.20%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Around this line
https://github.com/i4Ds/STIXCore/blob/6dd81930999b971ae4606fa9226deaefbe3361e1/stixcore/products/level2/housekeepingL2.py#L289 or in general? We don't really handle other kinds of missing spice information so I'm not sure.

no the for each "file" loop here: https://github.com/i4Ds/STIXCore/blob/6dd81930999b971ae4606fa9226deaefbe3361e1/stixcore/products/level2/housekeepingL2.py#L256
but this is more general failure handle. so i can do it also in a dedicated PR


HARVESTER: Add the insufficient resource to vm annotation

Summary
PR Checklist
~- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:~
~- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:~

Are backend engineers aware of UI changes?

[ ] Yes, the backend owner is: @chrisho

Add the insufficient resource to vm annotation

Occurred changes and/or fixed issues

https://github.com/harvester/harvester/issues/3944

Technical notes summary

Areas or cases that should be tested

Verify Steps:

Set over-commit CPU and memory to 100%
Create a project with 2000m cpu
Create a namespace with 2000m cpu
Create 10 VMs with 2cpu and 4Gi
Check the error message in VM list

Areas which could experience regressions

Screenshot/Video

@mergify backport release-harvester-v1.2


Using snp_topLayoutGuideBottom causes views to disappear on Swift 2.0 branch

I'm setting up a view and trying to pin a subview (it happens to be a UISwitch) to the bottom of the topLayoutGuide, like so:
make.top.equalTo(self.snp_topLayoutGuideBottom).offset(20)
However, when I do this, the view doesn't appear on the screen, nor when I look in the Debug View Heirarchy view.
If I switch that line to be:
make.top.equalTo(self.snp_topLayoutGuideTop).offset(20)
or
make.top.equalTo(100)
Then the view appears on the screen as expected.
My only other theory is that it's something to do with the fact that it's a UISwitch but that seems unlikely.
(Edit: confirmed that even changing it to a regular UIView doesn't change the behavior)

@andrewpbrett are you using Swift 2.0 branch or are you using the latest release 0.15.0 that now includes Swift 2.0?

Ahhhh that could be it - I was on the Swift 2.0 branch. I'll try the 0.15.0 release later tonight.

Confirmed that switching to 0.15.0 works like a charm, thanks Robert.


Adds link to Labels in Space response

fixes #1628

@DhritiShikhar snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1631-1

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3b47a3d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1631   +/-   ##
=========================================
  Coverage          ?   54.01%
=========================================
  Files             ?      129
  Lines             ?    16448
  Branches          ?        0
=========================================
  Hits              ?     8884
  Misses            ?     6871
  Partials          ?      693

Impacted Files
Coverage Δ

controller/space.go
72.02% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b47a3d...1f88ba6. Read the comment docs.


Clicking on a product in the Cart Page of Checkout redirects to the legacy/IO website.

Describe the bug
When you are in the cart page in checkout and click a product, you get redirected to the legacy/IO product page instead of the faststore page.
Expected behavior
When you are in the cart page in checkout and click a product, you should get redirected to the faststore product page.
Steps to reproduce
A step-by-step on how to reproduce the bug behavior.

Add a product to the cart
Go to cart page in checkout
Click on a product image

Workspace
All workspaces
Additional context
This behavior happens with the checkout already integrated with faststore

Hey @fabsantandrea thanks for your report.
This behavior is expected, check this documentation that you'd fix it.


[AutoPR datafactory/resource-manager] [Datafactory] Add SecureInput property to Activity. Add recursive option to cancel API

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3917

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2293


Alignment and Snap Problem in RulerPicker Component

I'm facing an alignment issue and snap problem with the RulerPicker component in the react-native-ruler-picker library. The teeth of the ruler picker are not aligned properly, and the snapping behavior is not accurate.
Steps to reproduce
1:) Include the RulerPicker component in your React Native project.
2:) <RulerPicker
min={100}
max={5000}
step={100}
fractionDigits={0}
unit="ML"
indicatorHeight={52}
textAlign="bottom"
gapBetweenSteps={5}
indicatorColor="#D1FF70"
shortStepColor="#D1FF70"
longStepColor="#D1FF70"
valueTextStyle={/* your value text style /}
unitTextStyle={/ your unit text style */}
/>
3:) Observe the misalignment of the teeth and the snapping behavior.
Expected Behavior:
The teeth of the ruler picker should align perfectly with the bottom teeth.
When scrolling, the snapping behavior should accurately snap to the teeth positions.

as you can seen in the image the teeth is not aligned vertically
React Native version: 0.72
Operating System: Windows 11
Device: Android 13

same issue in my project

@abhay-rana @hazimal only happening on Android, cannot reproduce on iOS

Tested only with android

@Skipperlla @enestatli Is this being addressed? I can confirm I am experiencing this issue on android as well, iOS is fine

Yes I'm also facing the same issue, @rnheroes

same issue in my project

how do you solve this?

I'm having the same problem.  Did you come up with a solution?
Only on Android, it doesn't align and doesn't even scroll.

@abhay-rana @hazimal only happening on Android?

I'm having the same problem. Did you come up with a solution?
Only on Android, it doesn't align and doesn't even scroll.

This is an issue with how FlashList calculate layout on Android. On a similar list in our project, I have to use getLayoutManager to get the correct pixel distance for that specific index.

This is an issue with how FlashList calculate layout on Android. On a similar list in our project, I have to use getLayoutManager to get the correct pixel distance for that specific index.

This library currently uses AnimatedFlashList, not FlashList. I don't think AnimatedFlashList has a getLayoutManager option.

This is an issue with how FlashList calculate layout on Android. On a similar list in our project, I have to use getLayoutManager to get the correct pixel distance for that specific index.

This library currently uses AnimatedFlashList, not FlashList. I don't think AnimatedFlashList has a getLayoutManager option.

Ofc AnimatedFlashList doesn't have this prop,it comes from recyclerlistview, the inner list rendering engine. Anyway, here is the magic code that fixed my issue on Android, it does look very weird though.
listRef.current?.scrollToOffset({
    offset: listRef?.current?.state?.layoutProvider
        ?.getLayoutManager()
        ?.getOffsetForIndex(index)?.x ?? index * ITEM_WIDTH,
    animated: true,
});

I'm getting when I'm creating the releaseAPK after the install of apk , the slider is not working but it was working in when i'm running the project. How to solve this?

Did anyone get this to work on Android?


SHELL-1528

Coverage remained the same at 90.146% when pulling<PHONE_NUMBER>a7818a375f794ab20a24f626b6d95b on SHELL-1528 into db7ef482871d942d20154b6f008052874bbc3a99 on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: