BIT-197 remove legacy dependencies from requirements file

Looks great @ndubuisx , but as heads up for branch names you don't need to put your username down, simply name the branch :) it ties automatically to your username using Jira.


(windows) LlamaCpp model keeps running without returning nothing

Hello. I'm using LlamaCpp in Windows 10 and I'm having the following problem.
Whenever I try to prompt a model (no mather if I do it throughout langchain or directly, with the generate method), although the model seems to load correctly, it stays running without returning nothing, not even an error (and I'm forced to restart the kernel). This happens when running the code on a Jupyter Notebook and also on a py file.
from langchain.llms import LlamaCpp
llm = LlamaCpp(model_path="models/ggml-model-q4_1.bin")
# output:
# AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | VSX = 0 |

from langchain import PromptTemplate, LLMChain
template = """Question: {question}

Answer: Let's think step by step."""

prompt = PromptTemplate(template=template, input_variables=["question"])
llm_chain = LLMChain(prompt=prompt, llm=llm)
question = "What NFL team won the Super Bowl in the year Justin Bieber was born?"

llm_chain.run(question)
# nothing happens

I tried with several models and it is the same. Also setting f16_kv to True.
Any ideas?

Llama has a tiny buffer (2048 I think) so it pretty rapidly runs out of space.


fix: use location.assign instead of href

What kind of change does this PR introduce?
Feature (and a bug fix kinda; fixes #155).
What is the current behavior?
See #155.
What is the new behavior?
Nothing different; Supabase simply uses location.assign(url) instead of location.href = url.

@awalias @kiwicopple

Actually JK, window.location.assign is a non-configurable property as well. 😞


drawing a direction route/navigation from one of coordinates to another

New Feature
I am requesting the addition of a new feature to RNMapbox that allows users to draw a direction route/navigation from one coordinates to another, i am using rnmapbox in my application and i am unable to draw a route/navigation direction, when i used the linelayer, it was just drawing a straight line from the a point to another which is not a good experience, i should be able to direct user to any point on the map.
Description
This feature will enable users to plot a course between two or more points on the map using the shortest and most efficient path. Users can specify their starting point and destination, and the feature will calculate the best possible route between the two. It will provide turn-by-turn directions, travel time estimates, and distance calculations.
This feature will be useful for users who want to navigate to a particular location using the shortest route possible, whether it's for personal or business purposes. For example, users can use this feature to plan their commute to work, navigate to a new restaurant, or explore a new city.
Why
The addition of this feature will enhance the functionality of RNMapbox, making it more versatile and useful for a wide range of applications. It will also increase the competitiveness of the library, as other popular mapping libraries such as Google Maps already have this feature.
In addition, this feature will improve the user experience by providing more accurate and efficient navigation. Users will be able to save time and avoid unnecessary detours and traffic jams.
Overall, the addition of this feature will provide significant value to users of RNMapbox, making it a more powerful and reliable mapping library.

@Emmybritt thanks for the request, this is a bit out of scope of this project. We could wrap mapbox navigation libs, but that would be another library.

Ok but please can you suggest any library i can along side with rnmapbox to draw a route line that direct user from one coordinates to another showing the direction, because google map as this feature, or can you advise me on implementation wise, cause i am trying to do that on rnmapbox, but i am not seeing any thing like that.

@Emmybritt thanks for the request, this is a bit out of scope of this project. We could wrap mapbox navigation libs, but that would be another library.

I am looking for the same.

I am looking for the same.

how i was able to solve this was that i used this api https://api.mapbox.com/directions/v5/mapbox/driving to get routes directions
here is the function
const getRouteDirection = async (     startPoint: PointProp,     endPoint: PointProp,   ) => {     const mapCoordinates = [...userCurrentMapCoordinates];     if (endPoint.lat || endPoint.lng) {       mapCoordinates[1] = {         latitude: endPoint.lat,         longitude: endPoint.lng,       };       setUserCurrentMapCordinates(mapCoordinates);     }     setFollowUserLocation(true);     const url = 'https://api.mapbox.com/directions/v5/mapbox/driving';     try {       const directionResponse = await axios.get(        ${url}/${startPoint.lng},${startPoint.lat};${endPoint.lng},${endPoint.lat}?alternatives=false&geometries=geojson&overview=simplified&steps=false&access_token=${MAPBOX_PK}`,
);
if (directionResponse.data?.code === 'Ok') {
setDirectionCoordinate(
directionResponse.data?.routes[0].geometry.coordinates,
);
// console.log(directionResponse.data?.routes[0].geometry.coordinates);
} else {
}
} catch (error) {}
};
it will return some response to navigate user, and then i set the data into the shapeSource
<MapboxGL.ShapeSource
id={'routeSource'}
lineMetrics={true}
shape={{
properties: {},
type: 'Feature',
geometry: {
type: 'LineString',
coordinates: routeDirectionCoords,
// coordinates: [
//   [3.371018, 6.509449],
//   [3.372146, 6.508393],
//   [3.372301, 6.508194],
//   [3.376102, 6.509765],
//   [3.375794, 6.510529],
//   [3.377471, 6.511185],
//   [3.375178, 6.516149],
//   [3.371407, 6.517713],
//   [3.36906, 6.516874],
//   [3.367807, 6.519059],
//   [3.367704, 6.522934],
//   [3.36685, 6.562292],
//   [3.366959, 6.567846],
//   [3.367904, 6.571613],
//   [3.362641, 6.57397],
//   [3.358708, 6.583552],
//   [3.361905, 6.584674],
//   [3.363964, 6.586197],
//   [3.361347, 6.589335],
//   [3.361978, 6.589869],
//   [3.362162, 6.589668],
// ],
},
}}>
<MapboxGL.LineLayer
id="exampleLineLayer"
style={{
lineColor: '#42A2D9',
lineCap: 'round',
lineJoin: 'round',
lineWidth: 7,
}}
/>
</MapboxGL.ShapeSource>


QuadratureSpace support for element faces?

Folks, I think we may be missing QuadratureSpace support for element face quadrature rules. Could we introduce a QuadratureFaceSpace?

Just to add more detail, my use-case for the volumetric terms is as follows:
QuadratureSpace qspace(pmesh,order)
QuadratureFunction q_fun(qspace, dim);
VectorQuadratureFunctionCoefficient q_coefficient(q_fun);

At the moment qspace will intialize a quadrature rule with quad_1D^{mesh_dim} values, but for the face terms we need it to be mesh_dim -1, and I don't see how this can be done with the current MFEM tools.

@pazner did this in the libCEED integration to avoid this limitation:
   // The x-coordinates of the first `nqpts` points of the integration rule are
   // the points of the corresponding 1D rule. We also scale the weights
   // accordingly.
   double w_sum = 0.0;
   for (int i = 0; i < nqpts; i++)
   {
      const mfem::IntegrationPoint &ip = ir.IntPoint(i);
      qX(i) = ip.x;
      qW(i) = ip.weight;
      w_sum += ip.weight;
   }
   qW *= 1.0/w_sum;

But I agree that we should find a convenient way to access this for users.

We should try to address this as part of #1656. It may be more convenient to allow the same class, QuadratureSpace, to support both volume and face quadrature spaces -- that way evaluation of coefficients on volume and face quadrature spaces can use the same interface.

I looked into what it would take to implement this feature. I think we need to make a design decision, there are two main possibilities. What are everyone's thoughts regarding options 1⃣ and 2⃣ below?
1⃣ Separate classes for face and element spaces and functions
Pros:

Better use of type system to ensure correctness at compile-time
More consistent and clearer interface
Much less risk of writing code that e.g. assumes that a QuadratureFunction is defined on elements, and then crashes because it's really defined on faces.

Cons:

Might result in more duplication (will we need a FaceQuadratureFunctionCoefficient in addition to a QuadratureFunctionCoefficient?)

2⃣  Reuse QuadratureSpace and QuadratureFunction for faces
Pros:

May result in less code duplication

Cons:

Weaker use of type system for compile-time correctness checks
Some of the member functions don't make sense for faces (e.g. will QuadratureFunction::GetElementValues actually get face values, or will it just give a run-time error?)

Thanks @pazner. I vote for 1⃣.

looks good to me too

I think 1⃣  is the safest and cleanest path.

This issue will be addressed as part of the unification of #1656 and #2891, so I'll close it.


DOC specify strategy in fill_null

The example in the docs is
shape: (3, 2)
┌──────┬─────────┐
│ col1 ┆ col2    │
│ ---  ┆ ---     │
│ i64  ┆ str     │
╞══════╪═════════╡
│ 1    ┆ 1       │
├╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌┤
│ 2    ┆ forward │
├╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌┤
│ 3    ┆ 3       │
└──────┴─────────┘

which looks a bit odd - I guess this was meant to be strategy="forward"?

Thanks, yep that's odd. :D


Added ui blocking to infopane while meeting creation is happening

Ticket: https://kanbanflow.com/t/5a7e8bd042bc161bd85acde29d38d0bf/7-as-a-user-i-want-to-be-notified-if-my
Note:  Awaiting a better ajax spinner from L

Coverage decreased (-0.7%) to 45.53% when pulling 9d27d3ebe819353e676bfda3e24b0e65fb172aab on ui-blocking into 29f7614aed6ebf1a9d6a98ebc587a90d26615c72 on master.

Coverage increased (+0.5%) to 46.689% when pulling c06226e001beb3b8df304e39d4f8e0ec35fc5314 on ui-blocking into 29f7614aed6ebf1a9d6a98ebc587a90d26615c72 on master.

It seems to not handle the case when the network is down. To reproduce:

Set the network to "offline" in browser dev tools
Create a meeting
Look at the Redux dev tools. MEETING_CREATE_SUCCEEDED is dispatched.

This is an issue. But should we fix it in this PR? I'm not sure.

It seems that standardErrorResponseTrap traps the error, so the meeting creation is considered to be successful. Hm...


Remove hard coded username

PGEventEndpoint.java is failing SAST tests because of a hard coded username.     From my reading of the code, setting the user to postgres (9 years ago) predates the defaultValue of the URIParam for user, and I think it can be removed because of the default value being set in the URIParam annotation for user.

The UriParam does NOT magically set any kind of default value. You need to set. that in the code

I don't think this PR is valid. This way we won't have a valid default defined.

I don't think this PR is valid. This way we won't have a valid default defined.

I agree with @oscerd. I think SAST tests are wrong here: it's not Camel's fault (or job) to policy the default usernames used by other applications. IMHO, the fact that some tool uses an specific hard-coded user name is a problem of that application.

Ah okay so is there some CLI tool that uses posgres as default value. But real world databases would surely not use posgtres as username and no password? So I wonder if maybe we can remove the default value all together in Camel. And if username/password is the only way to authenticate, we can mark these options as required = true

Also I is the pasword option really named pass in posgress, or should it not be renamed to password

I'll try to find an alternative way of setting the username initially / solving the SAST test.    Loading credentials from a properties file and then setting it seems to solve it, but that seems a little bit clunky in this case.


fakeServer.create accepts configuration settings

This allows fakeServer to be created with a whitelisted set of settings and adds a configure method which allows the server to be configured from an object literal. Fixes #784

Thank you for your pull request!


Issue with multiple instances with different widgets

Describe the bug
Multiple instances of the editor on the page, each with distinct widgetRules results in widget instance mismatches.
To Reproduce
Steps to reproduce the behavior:
Save the following code snippet to a file index.html and open it in any web browser.
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/toastui-editor.min.css" />

Each editor should be detecting its own set of hex values when we call insertText but both editors are detecting the widget0 from the second editor instance that we created.

Expected behavior
Each editor on the page should have its own set of hex values that it is capable of recognizing. For both lines of text in both editors, the same colors should be recognized and highlighted.
Instead, both editors only recognize the Black color when we insert additional hex values by calling insertText. This is because there is only one instance of widget0 at any given time, when in this case there should be 2.
Screenshots
This is what we see:

But the first editor should instead look like this... and does if you take the second editor off of the page:

Desktop (please complete the following information):

OS: n/a
Browser n/a
Version n/a

Smartphone (please complete the following information):

Device: any
OS: n/a
Browser n/a
Version n/a

Additional context
Add any other context about the problem here.
Note that the first line of text, from the initialValue config works correctly and honors the correct widgetRule logic that we configured for that instance of the editor. It is only after we have instantiated both editors and called insertText that the bug comes to light–both editors are now using the same widgetRule when they should maintain references to their own distinct widgets!
The root of the issue: At present, widgetRuleMap is declared as a singleton within the toastui editor package, and every time new Editor gets called, the values are overwritten with new values for the latest editor that we instantiate.
A few suggestions/ways I believe this could be fixed:

introduce a notion of editorId that we use to disambiguate between different editors in widgetRuleMap
put widgetRuleMap as a class instance member on the Editor rather than a global singleton
allow widgetRules to have an identifier so that instead of keying using widget${index} we use widget${rule.identifier}

@lzilioli-prism Thank you for the issue. I just reproduced the problem what you've been through. I guess your suggestion could be one way. But unfortunately, we are working on the TOAST UI at the same time as other projects, so we can't handle this right away. I'll check it later.


Move middleware.ClientIPstrategy to config.ClientIPstrategy

Codecov Report
Patch coverage: 66.66% and project coverage change: -0.12% :warning:

Comparison is base (cccd396) 73.77% compared to head (dcd58c1) 73.66%.
Report is 1 commits behind head on main.

:exclamation: Current head dcd58c1 differs from pull request most recent head 5b4e887. Consider uploading reports for the commit 5b4e887 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   73.77%   73.66%   -0.12%
==========================================
  Files          48       48
  Lines        5651     5669      +18
==========================================
+ Hits         4169     4176       +7
- Misses       1194     1201       +7
- Partials      288      292       +4

Files Changed
Coverage Δ

middleware/cors.go
92.30% <40.00%> (-2.70%)
:arrow_down:

config/config.go
64.70% <70.00%> (+0.12%)
:arrow_up:

middleware/client_ip.go
100.00% <100.00%> (ø)

middleware/middleware.go
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Documents folder brings up error but works anyway

Explain the bug
When i go to documents via the sidebar it will bring up a can't locate error but when it close it show content in documents.
Expected behaviour
There should be no popup.
Logfile
debug.log
debug_fulltrust.log
Screenshots

System Information

OS Version: Windows 10 20H2 19042.928
App version: v<IP_ADDRESS>

Turns out it was OneDrive adding a document folder to library and didn't remove it when I deleted it,


Register multiple checks with service

Consul 0.5.0 supports a new (poorly documented) Checks field, which can be used to associate multiple checks with a service at registration. The new field is an array, with each element a check. See https://github.com/hashicorp/consul/pull/591 for full implementation details.
Can you expose this in the consul.agent.service.register() call?

In version 0.18.0


Fix provider crashing when some options are set in .psqlrc

In some cases, like setting \x auto or trying to \echo anything in .psqlrc will make provider crash:
Warning: /Stage[main]/Main/Node[some-server]/Postgresql::Server::Role[backup]/Postgresql_psql[ALTER ROLE "backup" NOCREATEROLE]: Skipping because of failed dependencies
Error: Error executing SQL; psql returned pid 16230 exit 1: 'Expanded display is used automatically.
server: some-server.example.com
ERROR:  role "somerole" already exists

passing option to ignore .psqlrc fixes this, and any other changes that might be set up from this file.
We used puppet to change prompt (red on production servers, green on devs) and add hostname to psql to eliminate mistakes and it turned out that this module depends on CLI behaviour of psql.
Removing loading the .psqlrc file should make that behaviour more consistent.

@XANi Your pr is currently failing against both the spec test and the syntax check.
The spec test's it is failing are:
Failed examples:
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:14 # Puppet::Type::Postgresql_psql::ProviderRuby#run_sql_command with default attributes executes with the given psql_path on the given DB
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:33 # Puppet::Type::Postgresql_psql::ProviderRuby#run_sql_command with psql_path and db executes with the given psql_path on the given DB
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:49 # Puppet::Type::Postgresql_psql::ProviderRuby#run_sql_command with search_path string executes with the given search_path
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:64 # Puppet::Type::Postgresql_psql::ProviderRuby#run_sql_command with search_path array executes with the given search_path
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:77 # Puppet::Type::Postgresql_psql::ProviderRuby with port string executes with the given port
rspec ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:89 # Puppet::Type::Postgresql_psql::ProviderRuby with connect_settings executes with the given host

While the syntax errors are:
Offenses:
lib/puppet/provider/postgresql_psql/ruby.rb:14:18: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
    command.push("--no-psqlrc")
                 ^^^^^^^^^^^^^

@david22swan fixed. But I have question about those tests:

why in some cases just psql is used and in other it is attributes[:psql_path] ? Seems like it passes those tests just fine even tho it should fail if psql is not in default path
what's the point of testing if "just" commandline looks the same. Or testing for order of it ? Shouldn't it just test if connection actually succeeded ?

@david22swan never mind, it was fixed in 58e8f051953edd15b52e539f4d12fec2066382d5


Issue--ValueError: Depict error: Substructure match with reference not found.

from rdkit.Chem import Draw
from rdkit.Chem import AllChem
import matplotlib.pyplot as plt
smi=[
'COC1=C(C=CC(=C1)N5(=O)(=O)C)C2=CN=CN3C2=CC=C3',
'C1=CC2=C(C(=C1)C3=CN=CN4C3=CC=C4)ON=C2C5=CC=C(C=C5)F',
'COC(=O)C1=CC2=CC=CN2C=N1',
'C1=C2C=C(N=CN2C(=C1)Cl)C(=O)O'
]
template = Chem.MolFromSmiles('c1nccc2n1ccc2')
AllChem.Compute2DCoords(template)
mols=[]
for smi in smis:
mol = Chem.MolFromSmiles(smi)
AllChem.GenerateDepictionMatching2DStructure(mol,template)
mols.append(mol)
img=Draw.MolsToGridImage(mols,molsPerRow=4,subImgSize=(200,200),legends=['' for x in mols])
plt.imshow(img)
plt.show()
Raise ValueError: Depict error: Substructure match with reference not found.
I am a beginner at this, and I am not very familiar with the module.
Does that error means the substructure is not in molecule? How shall I solve it? thx!

Firstly, this is a question, not a bug, so should be in the Discussions tab rather than the Issues.
Secondly, can you please repost the code within three backticks so the formatting is preserved.  See
a comment at the bottom of https://github.com/rdkit/rdkit/discussions/6691 for a picture of what that means.
Thirdly, I expect you’re correct that the error message means the problem is at the generate depiction from 2D step.

已收到。小邮会以最快的速度用紧箍咒艾特主人。

Hi, I faced the same problem. Have you fixed it?

已收到。小邮会以最快的速度用紧箍咒艾特主人。


instructions to install a syncer on a pcluster

Part of #418

FYI I removed Fixes #418 from the description because that is an epic and there are more things needed before we can close it

This is mostly done, blocked now in the following error
kubectl -n kcp-system logs syncer-77f85dfd7c-shnln
I0316 15:11:29.836320       1 syncer.go:66] Syncing the following resource types: [deployments.apps ingresses.networking.k8s services]
I0316 15:11:29.837723       1 specsyncer.go:73] Creating spec syncer for clusterName default:my-workspace--1 to pcluster WORKLOAD_CLUSTER_NAME, resources [deployments.apps ingresses.networking.k8s services]
E0316 15:11:29.841411       1 run.go:74] "command failed" err="Get \"https://<IP_ADDRESS>:6443/clusters/default:my-workspace--1/api?timeout=32s\": x509: certificate signed by unknown authority"

Verify return code: 19 (self signed certificate in certificate chain)
:thinking:

cool, communication is working, blocked now in
kubectl -n kcp-system logs syncer-7f854c985c-dl8np
I0316 16:07:10.912009       1 syncer.go:66] Syncing the following resource types: [deployments.apps]
I0316 16:07:10.912689       1 specsyncer.go:73] Creating spec syncer for clusterName default:my-workspace--1 to pcluster WORKLOAD_CLUSTER_NAME, resources [deployments.apps]
E0316 16:07:10.929702       1 run.go:74] "command failed" err="The following resource types were requested to be synced, but were not found in the KCP logical cluster: [deployments.apps]"

Approved. Good as a first step. We will iterate.


📝 README

Description
According to GitHub Actions document, we need to define output in jobs even step did write something to GITHUB_OUTPUT to make it accessible to next job.

@all-contributors add @ShiriNmi1520 for doc

@all-contributors please add @ShiriNmi1520 for docs


[e2e-tests]Use nodeAffinity instead of labeling nodes

This will make tests more readable and prevent
modifying nodes.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test pull-kubevirt-e2e-k8s-1.23-swap-enabled

/test pull-kubevirt-e2e-k8s-1.24-swap-enabled

/test pull-kubevirt-e2e-k8s-1.26-swap-enabled

/test pull-kubevirt-e2e-k8s-1.26-swap-enabled

Looks much better, thanks!
/lgtm


Disappearing Dog

I originally had three dogs - one died (#2).  I rode on a horse away from "home" with the remaining two dogs (#1 and #3) and when I arrived at where I was going, one of the two dogs was nowhere to be found (#1).  It showed in my inventory but /md comehere did not surface a dog.  I back tracked my path but still could not locate the dog.  I ended up running /md free to get it out of my inventory but no clue where the dog went.

Hi there, thanks for opening an issue!
I don't have much information to go on though - the dogs try and teleport to you, and their locations get updated every time they are interacted with and when they get teleported. This location gets saved by MyDog, and can be viewed by running /md info.
Of course, the dog might not be where the plugin says it last saw the dog, but I don't know what else to do right now, seeing as I don't have enough information to try and reproduce the bug myself.
If you figure out a way to reproduce the issue, feel free to reopen the issue!


First QC results indicate reduced quantitative accuracy of directLFQ vs MaxLFQ

Thanks for this very interesting and easily accessible work!
Unfortunately my first attempt to reprocess a mixed proteome standard (Human/Ecoli -> 1:1 vs1:3) processed via DIA-NN only with default options resulted in clearly reduced quantitative accuracy for directLFQ.
Is this actually to be expected?
Kind regards
Michael

Seems to me that DirectLFQ extracts all reported fragment ion intensities from the DIA-NN report.
However - according to Vadims publication - the DIA-NN default precursor quantification algorithm uses only 3 fragments per precursor (those with highest correlation score (measure for goodness of fit of actual fragment elution profile vs reference profile)) to compute precursor intensities. Maybe this explains the observed discrepancy? Anyhow, this does actually not fit to data shown in the preprint..

Hi Michael,
thanks a lot for checking out directLFQ and providing this helpful feedback! These differences look quite strong indeed. The ratio-comparison data shown in the paper was processed with Spectronaut and they furthermore come from a Thermo platform.
Attached are some ratio comparison checks for DIA-NN on the paper dataset

using DIA-NN fragment.intensities

and

using the DIA-NN calculated precursors for the for protein intensity estimation:

to me version 1) looks a bit better on this data,. So my guess would be that it depends on the platform on which the data was acquired. In case you can share: which platform was your data acquired on?
I have now released a new directLFQ version 0.2.5 , where I set 2) to be the default option, as I guess this will be more stable for different types of data. I also added more options in the GUI (see image below). It would be really interesting to see your results with the new default (or also non-defaults if you have the time to check this)

It is diaPASEF data. Already have checked your algorithm on this platform?

Hi Constantin.
Indeed from 1st glimpse the platform seems to have a big impact on resulting quantities...
Having a look into the DIA-NN paper I took note that actually only Top3 fragment ions showing highest correlation score are used for default precursor quan calculation. Quickly scripted a solution to filter report.tsv for top3 fragment ions and re-ran directLFQ GUI (previous version). Did not check in much detail, but doesn't look that bad form 1st glimpse...
Note: diaPASEF data from timsTOFpro 2

This is very interesting, thanks a lot for checking it out! So your filtering script went through the Fragment.Quant.Corrected column and did a transformation like below (assuming they are sorted by correlation)?
379251;227167;504371;756432;0;854488;955054 -> 379251;227167;504371
The standard deviations look quite good, a reason could be that directLFQ also uses the MS1 information in this case, which is quite valuable for timsTOF data in my experience.
I have added this approach to the feature list and will look more into it. Hope it also looks ok with the new version

In principle I did exactly this, but computed sum of scores across all Runs as I wanted underlying fragments to be same across considered runs. Also happy to check a samplewise top3

Thanks a lot for explaining, I think it should definitely be stable over all samples, as you implemented it.

Hi Michael, I have now tried 4 different processing types on data from the original diaPASEF paper, including the top3 method you suggested. There are only subtle differences between the processing types. The differences are considerably smaller as compared to the data that you show, which is strange.

Could you maybe check how the default in the new version performs for you?


Update Grant-SPOHubSiteRights.md

-Identity is required parameter.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Grant-SPOHubSiteRights.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Aaron, appreciated.


RuntimeError: Error(s) in loading state_dict for FrozenCLIPEmbedder

Hi! Thanks for your great work!
when I run this command
python guide_gligen.py --ckpt weights/gligen/diffusion_pytorch_model.bin                        --type counting --box_pickle data_evaluate_LLM/gpt_generated_box/counting.p
it throws the below error:
Traceback (most recent call last):
File "/mnt/nas/share/home/zmz/code/attention-refocusing/guide_gligen.py", line 539, in
models = load_ckpt(meta_list[0]["ckpt"])
File "/mnt/nas/share/home/zmz/code/attention-refocusing/guide_gligen.py", line 88, in load_ckpt
text_encoder.load_state_dict( saved_ckpt["text_encoder"]  )
File "/home/zmz/miniconda3/envs/fsdet110/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1482, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for FrozenCLIPEmbedder:
Unexpected key(s) in state_dict: "transformer.text_model.embeddings.position_ids".
Do you know how to fix this?

After I reconfigured the environment following the official steps, the above bug seems to have been fixed. However, a new bug has emerged.
Traceback (most recent call last):
File "guide_gligen.py", line 587, in
run(meta, models, info_files, args, starting_noise, k,i)
File "guide_gligen.py", line 449, in run
output_folder1 = os.path.join( args.folder,  meta["save_folder_name"]+'_img')
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Hi,
you should include --file_save in the script to run guide_gligen.py


Arf 632 refactor application controller

Fixes #632 Refactor ApplicationController

Codecov Report

Merging #639 into master will increase coverage by 0.33%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage    35.3%   35.64%   +0.33%
==========================================
  Files          40       40
  Lines         946      937       -9
  Branches       18       20       +2
==========================================
  Hits          334      334
+ Misses        612      603       -9

Impacted Files
Coverage Δ

...scalaexercises/exercises/controllers/package.scala
0% <ø> (ø)
:arrow_up:

...exercises/services/interpreters/interpreters.scala
0% <0%> (ø)
:arrow_up:

...ercises/exercises/controllers/UserController.scala
0% <0%> (ø)
:arrow_up:

.../exercises/controllers/ApplicationController.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead144d...64f1b57. Read the comment docs.


Sample Project Request: Multisig

Use the solidity code from: https://solidity-by-example.org/app/multi-sig-wallet/
We have such a branch already (https://github.com/austintgriffith/scaffold-eth/tree/multi-sig-wallet) but it's very very outdated and doesn't have a custom UI either.

This is the most up-to-date branch of a multi-sig, but it's signature based: https://github.com/austintgriffith/scaffold-eth/tree/meta-multi-sig
Building a multi-sig-wallet in 🏗 scaffold-eth is a fantastic place for anyone wanting to build idea!

moved to scaffold-eth-challenges branch


Support for ul, buttons, icons?

I'm new to this library, but would like to explore it alongside React Sketchapp for my designs & React web applications.
After playing w/ the examples in Sketch App, it looks like we have support for the following via primitives:
View -> renders div
Image -> renders img
Text -> renders span
Is there a suggested practice for rendering other web element types? I guess a few that come to mind immediately are some already mentioned I believe...
ul for lists
button for buttons
i for icons
input for inputs
It would be nice to have a doc detailing what the recommended primitives are for each element type...
Thanks so much for all your hard work on this. This is amazing!!!

The docs for react-native-web explain how to use the React Native accessibility props to render specific Dom elements

ok - this is good to know that you'll be following that project's conventions. I'll stay tuned there as well. ;)
Closing this issue...


kpod finished time is incorrect

Using kpod inspect, the finished time always reports:
"finished": "0001-01-01T00:00:00Z"

@nalind Is this a storage issue?  Or is this field provided as part of container shutdown?
@mrunalp @runcom WDYT?

In cri-o it is set here https://github.com/kubernetes-incubator/cri-o/blob/master/oci/oci.go#L588
You can get it from the creation time of the exit file for kpod to get an accurate time.

@baude Did you fix this?

nope

@rhatdan I'll do this in libpod for kpod as we move over the container support.  Can you assign it to me ?

Done

This has been fixed - don't know when. Just tested inspect with a container and got the actual exit time.

@baude @rhatdan issue can be closed.


Error in UserOperator form when mailing address the same as physical address

Describe the Bug: In cases where an operator's mailing address is the same as its physical address, the physical address data is not being propagated to the mailing address fields in the DB
Probability (how likely the bug is to happen, scored from 1-5): 4
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Effect (how bad the bug is when it does happen, scored from 1-5): 3
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")
Steps to reproduce the behaviour: (assuming you're running the app locally with user-operator fixtures already in your db)

in browser, go to dashboard/select-operator/user-operator/1
if it isn't already, click the "Yes" radio button to indicate that the operator's mailing address is the same as its physical address
ensure that all other required fields are filled in
click "Submit"

Screenshots:
UI:
Private Zenhub Image
Backend server logs:
Private Zenhub Image
Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional context

I wasn't able to reproduce this

No longer valid!


Importing image from css global

Hello everyone.
I have the follow nuxt.config.js:
head: {
  ...
  /**
   * Global CSS
   */
  css: [
<EMAIL_ADDRESS>  ]
}

In my main.css I have the follow statement:
.bg-1 {
    background: url(~assets/images/bg/1.jpg);
}

But don't works,
 ERROR  Failed to compile with 19 errors                                                                  friendly-errors 16:03:02

This dependency was not found:                                                                            friendly-errors 16:03:02
                                                                                friendly-errors 16:03:02
* assets/images/bg/1.jpg in ./node_modules/css-loader??ref--3-oneOf-1-1!./node_modules/postcss-loader/src??ref--3-oneOf-1-2!./assets/css/main.css

Obs: I try with '/' too.

This question is available on Nuxt community (#c8335)

@clarkdo

Can re-open this issue ?

The issue was closed since it’s not followed template, could you please raise the issue via cmty?

Okay, is there. Thanks

@RafaelGSS please try with: ~@
Example:
background-image: url('~@/assets/image.png');

Hello @rendergraf , thanks for your answer.
So... This thread was opened in 2018, I already fixed it. (I don't remember how)
For now... can be close this issue @clarkdo
Thanks all.


#25 store and view a query: storing and viewing list of queries

What does this PR do?

store and view a query

Description of Task to be completed

add both view and store query
add controllers for the endpoints of storing and viewing a query

How should this be manually tested?

git clone the application URL(https://github.com/nraufu/portofolio.git)
run npm install then run npm start
open postman and post on localhost:3000/queries a query with the name, email and query fields
open postman and access localhost:3000/queries and fetch the queries

What are the relevant Trello stories?

https://trello.com/c/ckzQanFp/25-store-a-query-api-endpoint

Screenshots (if appropriate)

 store a query API endpoint

Hey @nraufu ,
All input fields have to be validated.
Refer to this article: https://mongoosejs.com/docs/validation.html

nice work @nraufu.


Output Format

Hi,
How to set the output format using the java code. I am getting the output as RDF triples now. I would like to get the output as JSON-LD. I would like to do this from the code. Do we need to define it somewhere with executor object ? Could you please help me on this ?

Hi,
The executor.execute-command returns a QuadStore, which has a write method that takes the format as one of the parameters. For example, the snippet below writes the output as jsonld to stdout.
QuadStore result = executor.execute(triplesMaps, checkOptionPresence(removeduplicatesOption, lineArgs, configFile), metadataGenerator);
BufferedWriter out = new BufferedWriter(new OutputStreamWriter(System.out));
result.write(out, "jsonld");

Does this help?

Thanks for the response.
Yeah that's what I am looking for. But its not working
It throws Serialization jsonld not supported when I try to write the output as jsonld.

Ah, could it be that you are using a SimpleQuadStore instead of a RDF4JStore when creating the Executor?
Executor executor = new Executor(rmlStore, factory, functionLoader, outputStore, Utils.getBaseDirectiveTurtle(is));

The outputStore of this line should be an RDF4JStore.

I am using below code snippet. I am using RDF4JStore only.
`InputStream mappingStream = new FileInputStream(chromatographyMappingFile);
Model model = Rio.parse(mappingStream, "", RDFFormat.TURTLE);
		RDF4JStore outputStore = new RDF4JStore(model);

		Executor executor = new Executor(outputStore, new RecordsFactory(new DataFetcher(cwd, outputStore)));
		QuadStore chromResult = executor.execute(executor.getTriplesMaps());
		chromResult.removeDuplicates();

		BufferedWriter out = new BufferedWriter(new OutputStreamWriter(System.out));
		chromResult.write(out, "jsonld");`

Ah, yes, there's a bit of confusion here: you need QuadStore for your RML mapping, and a second QuadStore for your output data. You can check https://github.com/RMLio/rmlmapper-java/blob/master/src/main/java/be/ugent/rml/cli/Main.java for more details, but I guess you need something along the lines of
// Read mapping file
InputStream mappingStream = new FileInputStream(mappingFile);
Model model = Rio.parse(mappingStream, "", RDFFormat.TURTLE);
RDF4JStore rmlStore= new RDF4JStore(model);
// Load functions
FunctionLoader functionLoader = new FunctionLoader(null, null, new HashMap<>());
// Prepare output store
RDF4JStore outputStore = new RDF4JStore();
// Create executor
Executor executor = new Executor(rmlStore, new RecordsFactory(new DataFetcher(cwd, rmlStore)),functionLoader, outputStore, Utils.getBaseDirectiveTurtle(mappingStream ));
// Execute
QuadStore chromResult = executor.execute(executor.getTriplesMaps());
chromResult.removeDuplicates();
// Write result
BufferedWriter out = new BufferedWriter(new OutputStreamWriter(System.out));
chromResult.write(out, "jsonld");`

I am facing new problem with this code. Utils.getBaseDirectiveTurtle is not available method in Utils class. Is this from be.ugent.rml.Utils class ?

Indeed, please see https://github.com/RMLio/rmlmapper-java/blob/master/src/main/java/be/ugent/rml/cli/Main.java for the imports

Thanks, It worked, the problem is, I was using older jar. Thanks for helping out :)


[Storage] STG88 Release Prep

This PR achieves the following:

Adds release date for STG88 preview
Changes PyPi classifier tag to Beta since this is a preview

As a side goal, changed all instances of "" to '' for consistency sake

/azp run python - storage - tests

/check-enforcer override


Add new property to TruncatedList component

Release Type: Non-Breaking Feature

Fixes https://x-team-internal.atlassian.net/browse/XP-2653
Description

Add new property option showAll to TruncatedList component. this property going to remove the read more button and show all the items.

Checklist
Before submitting a pull request, please make sure the following is done:

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] check cleanup tasks (https://github.com/x-team/auto/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage.
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the component by running it in the browser and checked nothing is broken and operates as expected!

Related PRs

branch
PR

XP-2653-keep-truncated-skills
Auto

Steps to Test or Reproduce
N/A

Impacted Areas in Application

TruncatedList component

Screenshots

We applied a new approach to fix the bug of this ticket: https://x-team-internal.atlassian.net/browse/XP-2653, so we don't need to modify the UI component. This bug was addressed on this PR: https://github.com/x-team/auto/pull/1722


spirv-fuzz: Use unique pointer to FactManager in TransformationContext

TransformationContext now holds a std::unique_ptr to a FactManager,
rather than a plain pointer.  This makes it easier for clients of
TransformationContext to work with heap-allocated instances of
TransformationContext, which is needed in some upcoming work.

Closing in favour of a fresh PR.


Rewrite ES6 specific code

Some ES6 code was added to this code base here(.startsWith), and that causes an error when the library is being used in old versions of the CLI.
This currently causes this build to fail.

@LEQADA I just discovered that there are more ES6 codes written, this code currently breaks some of our legacy code.
Kindly refactor


Fix some minor issues regarding latest setInterestFilter changes

This changes should fix #57

I just added one more commit that removes the Pub/Sub prefix from the example application. I think the previous comment should be addressed by that. Please confirm.


Better usage of AMS::Model

Nothing particularly intereting, just, if we're using AMS::Model,
might as well use it as designed.
This also seems to break two of the benchmarks on my machine, making AMS
not quite only 22-24x slower.
I'm not sure whether the benchmark is intended more for regression testing than for a goal.
I could also add benchmarks for the other two major AMS releases (:facepalm:).
Note: I am an AMS maintainer, though it isn't much being developed these days.

I changed the pull request to dev as there are many changes there that we havent merged into master yet.
The performance tests are mostly to catch performance regressions. Here is an example of how they help with design decisions. https://github.com/Netflix/fast_jsonapi/pull/49

Thanks. Rebased. I also added a commit to correct the rubygems.org url.  Wasn't sure if you'd want that as a separate PR.

Thank you for rebasing. Merging it in.

wow, quick merge!  Working late!
re:

The performance tests are mostly to catch performance regressions.

Well, in that case, AMS isn't under particularly active development, so I guess could be a stable benchmark. I've been interested in your benchmarking code, as I wrote some fancy stuff for AMS, but didn't end up using it much.  I like how it's integrated and doesn't take too long.


remove redundant code in Exercise 12.4.3

Sorry, I haven't noticed that the code I deleted is different from the above code.


bug: Deleting a deployment under a workspace do not delete the pod within the physical clusters

Describe the bug
A scenario where 1 workspace can publish a deployment on 2 physical clusters is working fine (see steps  to reproduce hereafter) but the deployment fails as ultimately the pods are still running within the physical clusters
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k kcp ws .
Current workspace is "root:my-org".
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k delete deployment quarkus
deployment.apps "quarkus" deleted
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k get deployment -A
No resources found

kubectl ctx kind-cluster1
Switched to context "kind-cluster1".
k get po -lapp=quarkus -A
NAMESPACE          NAME                       READY   STATUS    RESTARTS      AGE
kcp-3fynjp160g9e   quarkus-5db7cffbbf-zbdbm   1/1     Running   1 (12m ago)   22m

kubectl ctx kind-cluster2
Switched to context "kind-cluster2".
k get po -lapp=quarkus -A
NAMESPACE          NAME                       READY   STATUS    RESTARTS      AGE
kcp-1zbrc5wdht1i   quarkus-5db7cffbbf-lqdll   1/1     Running   1 (13m ago)   22m

Steps To Reproduce

Execute the following scenario2.sh script to create the pclusters, 2 placements, 2 locations and 2 synctargets
Check if the quarkus pods have been well created within the physical clusters

KUBECONFIG=_tmp/.kcp/admin.kubeconfig k get deployments -A
NAMESPACE   NAME      READY   UP-TO-DATE   AVAILABLE   AGE
default     quarkus   1/1     1            1           5m12s # ONE DEPLOYMENT TOOK PLACE HERE BUT WE DONT KNOW HOW MUCH APPS FINALLY HAVE BEEN DEPLOYED ON pCLUSTERS ?

kubectl ctx kind-cluster1
Switched to context "kind-cluster1".
k get po -lapp=quarkus -A
NAMESPACE          NAME                       READY   STATUS    RESTARTS   AGE
kcp-3fynjp160g9e   quarkus-5db7cffbbf-zbdbm   1/1     Running   0          5m9s # A Quarkus APP has been deployed on cluster 1

kubectl ctx kind-cluster2
Switched to context "kind-cluster2".
k get po -lapp=quarkus -A
NAMESPACE          NAME                       READY   STATUS    RESTARTS   AGE
kcp-1zbrc5wdht1i   quarkus-5db7cffbbf-lqdll   1/1     Running   0          5m23s # A Quarkus APP has been deployed on cluster 2

KUBECONFIG=_tmp/.kcp/admin.kubeconfig k delete deployment quarkus
check within the physical clusters that the pods are still alive k get po -lapp=quarkus -A

Expected Behaviour
The Quarkus pods should be deleted on the physical clusters when the command KUBECONFIG=_tmp/.kcp/admin.kubeconfig k delete deployment quarkus is executed.
Additional Context
Version used: 0.8.2
Clusters created using kind

What about the downstream deployment? Is that deleted?

I did some investigations and I discovered that the deployment has been well deleted on the target/physical cluster but not the owned resources
Example:
apiVersion: v1
  kind: Pod
  metadata:
    creationTimestamp: "2022-09-12T10:55:20Z"
    generateName: quarkus-5d498879f8-
    labels:
      app: quarkus
      pod-template-hash: 5d498879f8
    name: quarkus-5d498879f8-s558h
    namespace: kcp-2ut1mmh6pvas
    ownerReferences:
    - apiVersion: apps/v1
      blockOwnerDeletion: true
      controller: true
      kind: ReplicaSet
      name: quarkus-5d498879f8
      uid: f0d54480-0035-4414-8d3e-e4b2f166608b
    resourceVersion: "4045"
...
kind: ReplicaSet
  metadata:
    annotations:
      deletion.internal.workload.kcp.dev/avTnBxIoP0D1fCNe4xa2zfOntsCxrrdIcuFfLG: "2022-09-12T10:55:17Z"
      deployment.kubernetes.io/desired-replicas: "1"
      deployment.kubernetes.io/max-replicas: "2"
      deployment.kubernetes.io/revision: "1"
    creationTimestamp: "2022-09-12T10:55:20Z"
    generation: 1
    labels:
      app: quarkus
      pod-template-hash: 5d498879f8
    name: quarkus-5d498879f8
    namespace: kcp-2ut1mmh6pvas
    ownerReferences:
    - apiVersion: apps/v1
      blockOwnerDeletion: true
      controller: true
      kind: Deployment
      name: quarkus
      uid: 7cd524b6-d5ce-451f-a44a-3e5d3c5f702b

BUT No deployment around Quarkus App are still there

k get Deployment -A
NAMESPACE                      NAME                           READY   UP-TO-DATE   AVAILABLE   AGE
kcp-syncer-cluster2-1zpd7aji   kcp-syncer-cluster2-1zpd7aji   1/1     1            1           3h6m
kube-system                    coredns                        2/2     2            2           3h7m
local-path-storage             local-path-provisioner         1/1     1            1           3h7m

I did a new test right now and the pod/replicaset and deployment are well deleted within the target clusters after executing
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k kcp ws .
Current workspace is "root:my-org".
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k get deployment -A
NAMESPACE   NAME      READY   UP-TO-DATE   AVAILABLE   AGE
default     quarkus   1/1     1            1           11m
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k delete deployment quarkus
deployment.apps "quarkus" deleted
KUBECONFIG=_tmp/.kcp/admin.kubeconfig k get deployment -A
No resources found

I didn't observe this since a while. Can we close it ?


Add config option for the maximum number of credentials

See https://github.com/Nitrokey/nitrokey-3-firmware/issues/207

Fixed in https://github.com/Nitrokey/trussed-secrets-app/pull/73


feat: add support for "take" operation to balanced storage

Closes #3030

Leaving in draft until #3064 merges

Codecov Report
Attention: Patch coverage is 26.18182% with 203 lines in your changes missing coverage. Please review.

Project coverage is 77.16%. Comparing base (ceaf49c) to head (0c75cc9).

Files with missing lines
Patch %
Lines

rust/lance/src/dataset.rs
5.83%
128 Missing and 1 partial :warning:

rust/lance/src/dataset/take.rs
23.61%
51 Missing and 4 partials :warning:

rust/lance/src/index/vector/ivf/builder.rs
0.00%
6 Missing :warning:

rust/lance-core/src/datatypes/schema.rs
72.22%
5 Missing :warning:

rust/lance-core/src/utils/address.rs
60.00%
4 Missing :warning:

rust/lance/src/dataset/optimize.rs
0.00%
2 Missing :warning:

rust/lance-datafusion/src/projection.rs
95.00%
0 Missing and 1 partial :warning:

rust/lance-index/src/scalar/flat.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   77.31%   77.16%   -0.15%
==========================================
  Files         240      240
  Lines       79322    79561     +239
  Branches    79322    79561     +239
==========================================
+ Hits        61326    61393      +67
- Misses      14821    15014     +193
+ Partials     3175     3154      -21

Flag
Coverage Δ

unittests
77.16% <26.18%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rate Limiting for POSTs

Context and Motivation
We need rate limiting to ensure untrusted users don't spam requests (e.g. new comments over and over).
We currently use echo on front_api; https://echo.labstack.com/docs/middleware/rate-limiter is a promising option, but we primarily want to limit POST requests, not GET requests. Cloudflare should handle GET request concerns.
Prerequisites
I'd recommend learning about the following topics before approaching this:

Golang (going through A Tour of Go is sufficient)
Echo (read some of the docs)
(optional unless reimplementing from scratch): https://en.wikipedia.org/wiki/Token_bucket

Goals

Rate limit POST requests, maybe by user privilege

@Sanket-Arekar  sure, are you in the Discord?

although, I think https://github.com/ravihidayat wanted this as well (can't seem to ping him)


[minor] mix version changed

new version

Coverage decreased (-0.8%) to 77.778% when pulling 32d418952028aa1bd94e43244527fb3bc8239746 on imax-iva:replace_poison_with_jason into c9cc7eda9a55101a996113fa31adbf809f801648 on Nebo15:master.


CURLOPT_SSL_CTX_DATA | CURLOPT_SSL_CTX_FUNCTION

When read curl documentation, i can see callback to treat ssl file from memory, some devel explain me how or why php don't support this options ?
What i need, send curl with ssl from memory block, not file, if i have some executions or concurrency executions, i have problem with files...
Please, help me with this. Thankful to work, great Job!

Please, before open this issue i search around internet and issues here, not found any solution to this problem.

i searching by curl extension php, sorry.


.git-blame-ignore-revs: Add commits from #241, #289

e2e test failure is just docker rate limit, merging anyways.


acceptance test hg workdir versioning

Bitbucket: https://bitbucket.org/pypa/setuptools_scm/issue/4
Originally reported by: Ronny Pfannschmidt
Originally created at: 2010-05-26T02:24:32.272

acceptance test hg workdir usage, fixes #4
→ <<cset 7ff2d11a15b8>>

Original comment by: Ronny Pfannschmidt


Add retry method for iTunes API requests

Hi! It's me again 😅
This PR just adds an enhancement to my last one. This will attempt to hit the iTunes API up to 3 times if it fails before falling back to MusicBrainz for artwork.
I'm still trying to get to the bottom of why the iTunes API will sometimes return "Service Unavailable", but after some tests it does seem to go through on the second attempt each time it happens.
Apologies for all of the commits, I had a hard time getting my fork up to date. 😓

Is it something that happens often, or is the iTunes API just struggling from time to time?

Is it something that happens often, or is the iTunes API just struggling from time to time?

I use this at work (listening 6-8 hours a day) and it happens ~5-10 times. The immediate fallback to MB works fine, but it's always nice to have the actual data from iTunes. I've been testing this for a few days now, and every time it's successfully grabbed the data from the API on the second attempt.
I'm still trying to get to the bottom of what's causing the error on the API side of things when I have time.

Oops, sorry I messed up my push, I wanted to rebase your branch
Can you apply this patch on your fork to reopen this pr? Thanks
0001-Add-retry-method-to-iTunes-API-request.patch
(curl -L https://github.com/user-attachments/files/16820569/0001-Add-retry-method-to-iTunes-API-request.pat ch | git am)

https://github.com/NextFire/apple-music-discord-rpc/commit/609179fdf28611facceb6b58a245a9b51ef1456d

Thank you! 😄


Make the dashboard page private

as far as I know, we do not have a choice for making that analytics endpoints part of a middle ware to limit public users get access to that. if would be great to include this setting in the config or somewhere to provide a wrapper middleware.

Hey @edrisranjbar 👋
You can publish the config via the command:
php artisan vendor:publish --provider="AndreasElia\Analytics\AnalyticsServiceProvider"

After publishing the config you can update the middleware array to include authentication middleware or any other kind of middleware if that's what you'd like to do.
https://github.com/andreaselia/laravel-analytics/blob/master/config/analytics.php#L14-L16

I did changed the config:
    'prefix' => 'admin/analytics',

    'middleware' => [
        'admin',
    ],

but it keeps getting redirected to main dashboard!

@edrisranjbar what does your middleware look like? All we do in the package is assign the middleware in the config to the routes group, so don't think there is an issue there, so I think it must be coming from your middleware. Ensure your routes aren't cached either.

The authentication middleware and configs works fine for the entire admin and user panel and public website.
    public function handle(Request $request, Closure $next): Response|RedirectResponse
    {
        if (!Auth::guard('admin')->check()) {
            return redirect()->route('admin.login');
        }

        return $next($request);
    }

the guard name is admin and here's the config:
<?php

return [

    'enabled' => env('ANALYTICS_ENABLED', true),

    /**
     * Analytics Dashboard.
     *
     * The prefix and middleware for the analytics dashboard.
     */
    'prefix' => 'analytics',

    'middleware' => [
        'admin',
    ],

    /**
     * Exclude.
     *
     * The routes excluded from page view tracking.
     */
    'exclude' => [
        '/analytics',
        '/analytics/*',
    ],

    /**
     * Determine if traffic from robots should be tracked.
     */
    'ignoreRobots' => true,

    /**
     * Ignored IP addresses.
     *
     * The IP addresses excluded from page view tracking.
     */
    'ignoredIPs' => [
        // '<IP_ADDRESS>',
    ],

    /**
     * Mask.
     *
     * Mask routes so they are tracked together.
     */
    'mask' => [
        // '/users/*',
    ],

    /**
     * Ignore methods.
     *
     * The HTTP verbs/methods that should be excluded from page view tracking.
     */
    'ignoreMethods' => [
         'OPTIONS', 'POST',
    ],

    'session' => [
        'provider' => \AndreasElia\Analytics\RequestSessionProvider::class,
    ],

];

will be appreciated if you can help here

Could it be a cache issue? Maybe check php artisan route:list and see what middleware is registered to each route?
cc: @tomirons

Yeah i checked but it looks fine.

Could you show me the route list export please?


fix: upgrade set-function-name to v2.0.1

There is a bug in set-function-name v2.0.0 and we should not use that version.
https://github.com/ljharb/set-function-name/commit/db2eda8da4c8aecfad01739000bbd63d04a8e8cf

This isn't required; we use ^, so you can just update your lockfile.

We're not currently using a lock file, and we're using an internal npm mirror, which can cause the app to fail to start once the version in the mirror is not the latest (version 2.0.0).

If you're not using a lockfile, then npm install $foo (where $foo is the direct dependency at the top of the chain that brings in set-function-name, should pull the latest version. Your npm mirror presumably automatically proxies to the public registry, so it should have v2.0.1 already.

This isn't required; we use ^, so you can just update your lockfile.

Maybe, but having an invalid requisite it's not optimal.
Basically, your package.json says  Regexp.prototype.flags can work with set-function-name 2.0.0 but it's not true.
Imho fixing it is not optional

In general, I would expect that these packages should require better CI testing, and that npm publish would be automatically blocked until the CI test passes.
For example, here's a case of a missing dependency in set-function-name v2.0.0.
Or is there another better way?

@yisibl A missing explicit dependency doesn't necesasrily make tests fail, because dev deps, and transitive dev deps, are present in tests. The only way to check this is with eslint or a tool like depcheck, neither of which are yet in my standard toolkit since I've only made this mistake a handful of times out of tens of thousands of publishes going back a decade.
@alar77 it can, indeed, work with v2.0.0, so it is optional.

I am experiencing issues with this as well. I just installed a new package that was dependent on this, and it installed v2.0.0, causing me to deep dive to find the obscure issue. I believe this should be merged to fix the problem for future uers.

I'm using npm. I have no idea why it's not installing the latest version. I
had to manually modify the package-lock.json file to get it working.
On Wed, Oct 4, 2023, 6:11 AM Jordan Harband @.***>
wrote:

@TrevinAvery https://github.com/TrevinAvery you must be using "not
npm"? a working npm client installs the latest in-range version of
transitive deps, not the lowest.
—
Reply to this email directly, view it on GitHub
https://github.com/es-shims/RegExp.prototype.flags/pull/29#issuecomment-1746850184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGBCSFTE4JZZRWYKUJJN45TX5VN7DAVCNFSM6AAAAAA4XNZVROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWHA2TAMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Use better regexp for replacement

& add debugging to try & work out why it sometimes doesn't replace.

Yeah, TIL about the 's' mode which is like multiline++ where the '.' also matches newlines


How can I delete the default error page - but it does not exist in the backend

Hello Developers,
I have decided again for the GRAV CMS and see that in the frontend at https://cmsblogger.de a default error page is linked in the navigation.
This page does not exist. In which template I have to remove it because it does not look nice and I do not need this page.
Thanks in advance.

Hi, the error page is provided by the Error plugin: https://github.com/getgrav/grav-plugin-error
You can override it with an empty template in your theme: https://github.com/getgrav/grav-plugin-error#template


"Add Configuration..." to add a debug configuration uses type: "node" while debug provider uses type: "node-terminal"

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.67.1
OS Version: macOS 12.3.1 arm64

Steps to Reproduce:

Open some Node.js project.

Add a launch configuration by using the "Add configuration..." floating button when launch.json is opened.

Add a launch configuration by opening the quick pick (Ctrl/Cmd+P), typing "debug", selecting "Node.js...", and clicking with the mouse on the cogwheel in one of the suggested configurations.

The configuration added by "Add configuration..." uses "type": "node", while the one added by the debug quick pick uses "type": "node-terminal".
I couldn't find clear docs showing the difference between them or when you should use one or the other, and I find it weird that those two flows produce inconsistent results.
There is also the "pwa-node" (And possibly "pwa-node-terminal"?) debug/launch types which I'm also not sure if should be used or not, and I couldn't find any docs for them either.

node-terminal is used when running a program in a "javascript debug terminal" that automatically attaches to any node program. node is what you would use in a launch.json. pwa- prefixed types are sort of a historical leftover from the old node debugger implementation that we had a few years ago. pwa-node is now the same as node by default.

@roblourens Might want to add this to the main VS Code documentation. Including a recommendation for what users should use.


Add BetterIDEa IDE to explore apps tab

Added BetterIDEa IDE to explore apps tab
Dev build screenshot:

Hey @ankushKun, Thank you for the PR! I apologize for any confusion—it wasn't mentioned, but PRs should be based off the development branch. Could you please create a new PR based off of the development branch? Thanks for your understanding!

Hi @pawanpaudel93, thank you for the info
I have created a PR for the development branch https://github.com/arconnectio/ArConnect/pull/456
Thank you!


Ready for React 16

This code now works with React 15 and React 16 (library and example). Tests will have to wait that enzyme is made compatible with React 16 to work.
3 versions of the library are now available: cjs, umd & esm.

:tada: a lot of great updates @diligiant, thanks. One comment for now: can we not include dist? I'd like to avoid the need to update this file during development. Let's only include this on releases...

@rxaviers ok, will do. So basically, I leave you to include "dist" ? Ok boss ;)

Even if I switched to a safe flatMap, it might be nice to explain as it wasn’t done “just because” !! WDYT?
On 2 Sep 2017 at 20:03 +0200, Rafael Xavier de Souza<EMAIL_ADDRESS>wrote:

@rxaviers commented on this pull request.
In src/message.js:

           if (typeof str !== "string") {

               return; // continue;

       for (let i = 0; i < nodes.length; i += 1) {

Ignore my message asking to include a comment... This code has been modified anyway in subsequent commits.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Let's give some time in case @necolas and @kborchers have any input... Otherwise, let's merge.

Even if I switched to a safe flatMap, it might be nice to explain as it wasn’t done “just because” !! WDYT?

:+1:, a brief explanation as an internal comment is definitely welcome. Also, it would be wise to include a test case to assert this doesn't regress in the future.

@rxaviers the test case is there (line 81 of test/formatMessage.spec.js)
[strong][/strong] [br/] [strong][/strong]
with br first in the elements parameter)

We should also move the default message approach into globalize itself. globalizejs/globalize#575

Do you want to handle this or may I?
May you also take a look at https://github.com/globalizejs/react-globalize/pull/75 as it's the same area ; the purpose is to have a more predictable and logical behavior (and consistent with "normal" globalize).

Which part of this patch is addressing React 16 compatibility? Can that be broken out into a separate PR so we can merge the React upgrade fix?

@necolas all of it unless I'm mistaken!

In this PR, along with React 16 upgrades (e.g., React.DOM.span -> React.createElement), there are its needed test upgrades (Enzyme 3), plus tooling and code modernization too. @diligiant can correct me if needed...

Can that be broken out into a separate PR so we can merge the React upgrade fix?

@necolas please are you looking for safety (prevent regressions) or speed (get this PR merged quickly)? I think at this point it will be hard to cherry-pick parts without having to deal with lots of conflicts, but it should be straightforward to merge this work into an upcoming 1.0.0 release according to #77 option (a).
What do you think?

are you looking for safety or speed

Both. This PR has been open for a while and has a lot of unrelated changed.

I opened #78 to handle only changes to make React 16 work and avoid all of the syntax and build system changes

@paularmstrong thanks for creating #78. I also obviously prefer atomic PRs.
Having said, we need to (a) assert if #78 is sufficient and (b) I don't think @diligiant work should be lost. The code and build improvements are welcome. @diligiant can you try to rebase your changes on top of #78? How much does it conflict?

merge #78 and I’ll follow-up.


Need a new feature of getting subscriber list for a particular event

In one of the I am requiring subscribers object in order to call some methods written inside the subscriber. Can you please create a function that can return me list of subscribers for particular event.

You are going to have to explain your use case much better.
It sounds like what you are after violates the core principle of loose coupling that an EventBus provides.

No response. Closing. -ut


feat: resolver for<EMAIL_ADDRESS>

Description

Resolver for<EMAIL_ADDRESS><EMAIL_ADDRESS>is written in vue@2, it is outdated, and it is unlikely that the official will provide a resolver for it.
Linked Issues
Additional context

Thank you for bringing this up, but I am afraid that we can't take this complexity, especially for an outdated library. Feel free to implement it in your userland, or release a separate package.


Put the payload in public/migration_analytics

Allow the tgz to be downloaded from the webserver by placing it in the
public/ directory.
Depends on: ~~https://github.com/RedHatCloudForms/cfme-cloud_services/pull/42~~

cc @abellotti @Fryguy
This puts the payload files in /var/www/miq/vmdb/public/migration_analytics, I'm open to other locations though if there is someplace better.  This has the downside (compared to /tmp) of not being automatically cleaned up, but the upside that it doesn't have to use the API to download the file.

@abellotti I see that we have the full path of the file in task.context_data.payload_path. Once we get the file placed in public/migration_analytics, is that payload_path going to be sufficient for the UI to determine the full download URL it should use? It would be nice if we can also put a payload_url property into context_data that the UI can just display directly to eliminate any issues with constructing that URL.

Cleanup is the one thing to consider longer term.  We don't plan to GA this feature until CF 5.1 so we will have some time to work on that.  This also really only applies to the disconnected use case and we don't expect a large number of these payload files to be generated if that helps in the discussion.

Once we take the disconnected feature on for CFME proper we'll add a scheduled task to cleanup these types of files.

Once we take the disconnected feature on for CFME proper we'll add a scheduled task to cleanup these types of files.

Sounds great!

@mturley from the full path, you can just extract "/migration_analytics/." as the path part for now for the public_url, i.e. https://appliance/migration_analytics/.

Ok @abellotti that works. If you guys think this implementation is good for now, I think I can get everything ready to go end-to-end if we merge it today.

Based on the assumption from https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/16#issuecomment-521773111, I implemented the rest of the UI changes: https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/17

Since the UI itself is rendered at http://appliance/migration_analytics, I wonder if that will be a conflict. My PR assumes it won't... but that can be changed here: https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/17/files#diff-6da6f9aebb506ed7a5b23b946dc7fa61R3

@abellotti are we going to have a conflict on the path name? I'm not able to test with an appliance right now

@agrare yea, looks like with the ui controller.  let's pick another name, and kick the tire on an appliance  before this goes in.

@agrare @abellotti Strictly speaking, things are going to work fine this way (i.e. there won't be any conflict in the sense that download & the ui controller won't work). It just looks funny.

Okay I was able to download a payload from https://dhcp-8-99-239.cloudforms.lab.eng.rdu2.redhat.com/migration_analytics/cfme_inventory20190819-1109-1yfmzzu.tar.gz after manually changing the file permissions to 0644 (it was created with 0600).
I'll push a commit to generate the file with the proper permissions then this should be ready to go.

Okay done, now depends on https://github.com/RedHatCloudForms/cfme-cloud_services/pull/42

Okay @mzazrivec @abellotti this is ready for review

@agrare I can confirm that things are working fine here. The only concern I have are potential security implications of making a file, which contains all kinds of provider information, possible to download by anybody (i.e. without authentication of any kind).

Yeah Alberto brought up the same concern, the file path cannot be guessed because it is created by tmpname and the directory can't be browsed so it can't be discovered.  I'd love if we could add some type of auth in front of it but I don't know if it is feasible to get Apache to share the same auth as miq.

Yeah Alberto brought up the same concern, the file path cannot be guessed because it is created by tmpname and the directory can't be browsed so it can't be discovered.

We definitely should add some auth there. Relying on obscurity of the file name is not right.

I'd love if we could add some type of auth in front of it but I don't know if it is feasible to get Apache to share the same auth as miq.

That should be doable. Apache comes with a bunch of modules with many different ways of configuring the password backend.

@martinpovolny sounds good to me, that's well out of my area of expertise and will take some appliance config changes I assume so I'll leave that to you

Not that I do not have a long backlog ;-)
I can imagine using basic auth with custom password backend.

db backend
external auth backend

DB backend
Searching the first shows me:
https://httpd.apache.org/docs/2.4/mod/mod_authn_dbd.html
but that would require plain passwords. I assume there will be other solutions that would use hashed passwords but it would need to support the same password hashing we have in ManageIQ. @agrare : do you know how we hash passwords?
External auth backend
using external auth and connecting it to a Ruby script that would connect to our DB using Active Record (and whatever else is needed from Rails).
This seems relevant: libapache2-mod-authnz-external
So we need more inputs:

what hashing do we use?
what apache modules for custom auth are available on the appliance. RHEL 7, righ, @agrare?

do you know how we hash passwords?

I'm seeing $2a$10$... in user.password_digest, so we're using a slightly old version of bcrypt, with 2^10 rounds.

Thinking...
If this is to be consumed from the browser where the user is already logged in then

the external auth can be done in such a way that it would accept our cookies (and do the auth).
... and it can be mapped (using Apache) under the UI URL prefix on the appliance so that the browser would send the cookie.
... and the external auth process could verify the session if it's present and only fall back to basic auth (or just fail).

@agrare checking in on merge status.  Is security the generated file the hurdle?

I have one more question on this piece:

the API created a directory
the API queues a task with a path where to store results
some worker fullfills the task
user via browser is supposed to download the data

How does it work across appliances?

API role does that on it's appliance -- creates the directory.
On a potentially different appliance there's the role that picks up the task. If it's a different appliance the directory will not be there.
On a yet another appliance the UI worker that serves the UI will offer a download from an URL on the appliance where it is running.

Where is the mechanism that ensures that all these 3 things happen on the same appliance?
Is there some special limitation enforced by the V2V usecase that everything runs on the same one?
Am I missing something?

@bthurber yes appears so
@martinpovolny  we are going to use the server guid option to MiqQueue to ensure that the work is picked up by the API server.

we are going to use the server guid option to MiqQueue to ensure that the work is picked up by the API server.

@agrare So, this can't be mapped under /migration_analytics because that's UiWorker, and has to be mounted somewhere /api, right?

@himdel it is mapped to /car/www/miq/vmdb/public/migration_analytics and is served by Apache not the API server.  I'm open to renaming it if it is confusing

we are going to use the server guid option to MiqQueue to ensure that the work is picked up by the API server.

and the API is going to be the same one as the UI?

and the API is going to be the same one as the UI?

No but I assume that the UI will be able to download a file from the API server.

No but I assume that the UI will be able to download a file from the API server.

That's exactly the problem I think :) It won't.
The only way the UI can access anything physically on the API appliances is via the API.
Or via anything mounted under the API endpoints on the webserver.
The point is, the url has to be /api/foo, because just /foo is on the wrong server.

So you're saying if the UI is being served by <IP_ADDRESS>/migration_analytics and the API is being served by <IP_ADDRESS>/api, the UI won't be able to build a URL and present it to the user to download something being served up by <IP_ADDRESS>/downloads which is served by apache?

https://github.com/ManageIQ/manageiq-appliance/blob/master/COPY/etc/httpd/conf.d/manageiq-redirects-api#L1
Apache redirects the API to the right place.

I'll defer to you @himdel @martinpovolny and @abellotti on this, I tested it on an appliance and it worked, but if what you're saying is true then this needs to be redesigned.
In this case I'm going to tap out on this.  Was just trying to help move this along by implementing a design that @abellotti @mturley and I agreed on.  If it won't work then someone on the UI/API side will need to design it.

the UI is being served by <IP_ADDRESS>/migration_analytics
the API is being served by <IP_ADDRESS>/api
the UI won't be able to build a URL and present it to the user to download something being served up by <IP_ADDRESS>/downloads which is served by apache?

I'm saying apache will redirect UI requests (not under /api) to the UI appliance,
and API request to the API appliance.
If the request is to <IP_ADDRESS>/downloads, it will land on <IP_ADDRESS>/downloads, which is not the machine with the data.
If the request is to <IP_ADDRESS>/api, it will land on <IP_ADDRESS>/api, which is the right machine.

IMO the best solution would be to store this on the API appliance, and add an proper, authenticated API endpoint that will serve the file from there.
Anything else involves writing separate authentication code, or moving files between appliances.

IMO the best solution would be to store this on the API appliance, and add an proper, authenticated API endpoint that will serve the file from there.

I agree that the cleanest way is to serve it through the API. Because as @himdel wrote anything else requires writing authentication code which is best to avoid (tough to do right).
A note on the idea of not authenticating access to the file: I do not know what is going to be there. Maybe it's not "secret" at this point. But I can imagine that more stuff would be added and we might get into problems.
If all one needs to get some data is the (secret/random) URL then the data should be considered public. URLs can be loggen in in a proxy for example...

For moving this to the API, a couple of questions/points here:

What kind of file sizes can we expect here ? don't want to block the API too long.
If we're moving this data in the DB (for access from any API server instance), we might need to do the periodic recycling now so the DB does not grow crazy fast. Heck if it's accessed via the API, one option is zapping after the one access (if that fits the use-case).
How would this new API be authenticated ?  Don't think we want to embed any creds in the URL. Also, kinda' awkward to provide them a curl for them to run and provide credentials on a CLI.  So maybe this can provided behind a UI page (user logged into UI then access to the resource via API via the browser's api token). This would work with all current ext-auth methods too (including Kerb SSO, SAML, etc).

Oh, good point, there can be multiple API appliances.
So, yeah, we may need to put this in the db (eww), or implement static file synchronization accross appliances.
Or we could require the user to provide an endpoint to upload the file to, instead of trying to provide a download link.
(If the db solution wins, yeah, agreed this would need a simple UI landing page that will give you a Download button, to prevent API authentication issues with random links.)

On another note here, for IMS we download log files from the UI and implemented an RBAC function for this.  https://github.com/oVirt/v2v-conversion-host/blob/master/kubevirt-conversion/Dockerfile#L1
The discussion seems to have turned into a bit of boil the ocean.  For the purposes of Migration Analytics we don't require file sync across appliances.
Finally, the size of the payload files are not statically set.  It depends on the size of the VMware environment and if Smart State Analysis has been run (larger data set captured) or not.  We have Basic and Detailed options for the payload generation.

A couple takeaways from the above discussion -

Giving public download access to a payload file on an appliance is a NO
saving the payload in /tmp is preferable, but would require an API to download the file
We do need the API or some sort of authentication mechanism, otherwise it's a free public download
The approach used here https://github.com/ManageIQ/manageiqv2v/blob/master/app/controllers/migration_log_controller.rb would be considered acceptable

One possible approach would be to keep the payload in /tmp and use send_file in an API or a controller route, whatever is generally preferred..
Below is an example of how to implement the above using a controller route /migration_analytics/download_tar
Backend code -
def download_tar
  assert_privileges('migration')
  send_file params[:payload]
  #params[:payload] is a file in the /tmp folder e.g. /tmp/cfme_inventory-20190821-3380-1l1d18q.tar.gz
end

JS code -
const downloadPayload = `/migration_analytics/download_tar?payload=${payloadPath}`;
...
...
<Button bsStyle="primary" href={downloadPayload} disabled={!payloadUrl}>

@agrare What do you think of this approach?

def download_tar
  assert_privileges('migration')
  send_file params[:payload]
  #params[:payload] is a file in the /tmp folder e.g. /tmp/cfme_inventory-20190821-3380-1l1d18q.tar.gz
end

I don't think so. This would create even a bigger security problem, since you're in fact exposing the whole filesystem for download here.

I think that the most important question is what @abellotti asked:

What kind of file sizes can we expect here ? don't want to block the API too long.

Do we have some range? Who can tell?

I think that the most important question is what @abellotti asked:

What kind of file sizes can we expect here ? don't want to block the API too long.

Do we have some range? Who can tell?
Because that will tell us if we can download through the API or we need just the authentication piece and download via Apache w/o Ruby being in the loop.
Then we can discuss if it needs to live with the API or the UI.

A large VMware env with 10K VM's, payload is less than 1MB in .tgz format.

A large VMware env with 10K VM's, payload is less than 1MB in .tgz format.

@abellotti : do you think that if the size is limited to let's say 5MB is't ok to go through the API?

I don't think so. This would create even a bigger security problem, since you're in fact exposing the whole filesystem for download here.

Funny, I knew somebody would say that :)
... precisely why I also posted the other send_file code above
# or the approach below where we retrieve the filename via the task_id

def download_tar
  assert_privileges('migration')
  task = MiqTask.find(params[:task_id])
  file = task.context_data[:payload_path]
  send_file file
end

This is a roundabout way of downloading the payload file via the task_id
The location for the payload would be acquired via the task_id, which is a good deterrent for any malicious user.
Also a user who has access to 'migration' (via assert_privileges('migration') RBAC) cannot be technically considered malicious.
send_file/send_data can be used responsibly as shown above, and would get the job done.
As a matter of fact, it has been extensively used in other areas of the UI for downloading CSVs, TXT, PDF files.

@AparnaKarve, I think that @mzazrivec was commenting about the send_file params[:payload] (the important being the argument coming from unsafe source) and I am sure that the example can be safeguarded to do right/safely. And yes, we have places in the code where we do such things.
But that is rather orthogonal to the issues we have here. I do not think we have a problem sending a file.

We need to deal with the concern that sending a big file may potentially block the API (or the UI).

And we need to make sure that the file is placed and located on the appliance that is running the worker (API or UI) that would be actually sending the file.

I think that @mzazrivec was commenting about the send_file params[:payload] (the important being the argument coming from unsafe source) and I am sure that the example can be safeguarded to do right/safely.

@martinpovolny
Agreed about the pitfalls of using  params[:payload] -- hence the second option, which does not have  params[:payload]  was also mentioned above.
I would assume that send_file is a threaded operation to prevent it from blocking the API/UI -- because it's really the Ruby/Rails solution to download files in general.
IMO send_file should work without issues.
Anyway, I leave it to you to come up with the right solution.
Thanks.


Fix #22 by allowing Symbol instances in the query

Add MSSymbolInstance to the query when type is not defined. This allows to work with instances #22.

thanks @lessthanzero !


Add docs on PM interview process

Questions about our hiring process keep coming up, wrote up the process as a result, please review

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Queued for 1-1 with Lindsay on Monday

Reviewed with Lindsay - this is ready for another editor review.
@amyblais As a note, I'm confirming the above note with HR and will either keep or remove after hearing back. So added 'do not merge' label for now until I got the confirmation


How to specify linker binary?

I have multiple toolchains installed and looks like cbuild uses the default /usr/bin/ld which does not know the option --cpu=Cortex-M3 which makes sense, because it's not armlink.
How do I set the linker binary path, similarly to AC6 and GCC paths in ./etc/AC<IP_ADDRESS>.cmake? There seems to be no template for the linker.
Thanks!

Which build engine are you using? Ninja? Gnu Make?
I do agree that despite the fact that the ./etc/AC<IP_ADDRESS>.cmake does not contain any explicit variable setting for the linker binary, still in the rules.ninja on Windows I see the correct path set.
in line 16 of the AC<IP_ADDRESS>.cmake you could add:
set(LD ${TOOLCHAIN_BIN_DIR}/armlink.${EXT})

and in line 471 you could add:
set(CMAKE_LINKER "${LD}")

Does that make any difference?

Hi, I'm on Ubuntu 22.04 + Cmake v3.22.1 + ninja v1.11.0.
I could fix the wrong default linker by using set(CMAKE_LINKER "/home/dev/.../armlink"). This line was added directly on top of AC<IP_ADDRESS>.cmake.
In you solution, is $TOOLCHAIN_BIN_DIR set by cmake automatically? Couldn't find the variable in AC<IP_ADDRESS>.cmake. I guess it should work, too since my "solution" is simply hard coding which is sufficient for me currently.
How does cmake detect the linker if no $CMAKE_LINKER is defined?

I am not a CMake expert so cannot tell. @brondani  can you shed some light on $CMAKE_LINKER ?
In your solution, is $TOOLCHAIN_BIN_DIR set by cmake automatically? Couldn't find the variable in AC<IP_ADDRESS>.cmake. I guess it should work, too since my "solution" is simply hard coding which is sufficient for me currently.
Sorry for the confusion, it should read TOOLCHAIN_ROOT instead and is defined in line 7.

In our boiler plate it is CMake itself that finds the suitable linker according to the chosen compiler and language (see https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/CMakeFindBinUtils.cmake).
CMake being able to compile but wrongly trying to use the default linker /usr/bin/ld is a symptom of a dirty CMake cache, for example because the toolchain was not correctly configured previously.
@jankap Does cleaning the CMake cache (for example by running cbuild <project>.cprj --clear make any difference?
If not, I would appreciate to have more info to reproduce the issue.
A way to help CMake finding the linker is to set the LD variable, for example:
set(LD ${TOOLCHAIN_ROOT}/armlink${EXT})

@jankap  are you happy to close this issue?

Can I get this reopened when there's time to reproduce?
Currently, set(CMAKE_LINKER "/home/dev/.../armlink") does the trick as a workaround for me.

If you need to reopen it you can always create a new one and reference to this issue ID.


access violation at address 04DB31CD ACCESSING ADRESS 00000000

Hello Mr  Zeus64  please help.
I am using Alcinoe's video player on delphi 12  it compile with no error but when app is run it show error
access violation at address 04DB31CD ACCESSING ADRESS 00000000
I added all the exoplayer .jar files.

hello, can you try the ALFMXControls demo and say me if you encounter the same error in the demo ?

Thank's for replay ,Yes I test ALFMXControls demo and error with ALFmxTabControl.pas Method 'ChildrenMouseDown' not found in base class  I remove all things related with allayout and build app when run it hung  and not show main form maybe the problem is in the manifest add some thing like package i don't knew  this is my project
4.zip
in delphi 12 archi

You must add in your project options -> delphi compiller - Search Path correct path to alcinoe. Something like this
D:\Alcinoe-master\Embarcadero\Athens\fmx
D:\Alcinoe-master\Embarcadero\Athens\rtl\android
D:\Alcinoe-master\Source
(this is for Android)

Hello, everything has been fixed in the latest committed version.


Support specifying airport and runway elevations

@erikquinn, @Fechulo, here's an implementation for having an airport at some elevation other than 0.  If a runway doesn't specify an elevation then the elevation of the airport itself will be used.

Thanks!! The conflict detection code has to be changed as well; aircraft in the ground at SAME show a conflict, because they're "not on the ground"

@Fechulo, thanks it should be fixed now, can you try again?

Yeah, it works perfectly now! Ready to merge?

@tedrek This seems a solid solution, though I feel like I'd be remiss not to bring this up:
Especially if an enroute mode comes along, there will be many, many different ways we'll need to measure both "altitude" and "speed". What I was thinking (I may have mentioned it recently, not sure) was that the best way to deal with it would be to:

make aircraft.altitude into aircraft.alt, which has properties .msl, .agl, .fl (for altimeter-adjusted altitude, radar altitude above terrain, and non-adjusted std-altimeter-settings altitude)

makes easy to access altitude for assignments and crossing restrictions, terrain/obstruction clearance, and would natively recognize separation losses when attempting to utilize an unusable flight level (eg FL180@A2988)

make aircraft.speed into aircraft.spd, which has properties .ias, .gs, .mach (for indicated airspeed, aka the unit we speak to each other about, groundspeed aka speed the dot moves across the ground, mach aka speed relative to sound)

makes easy to get indicated speed, and mach speed, which don't have a linear relationship, which will become important if aircraft are to be simulated at altitudes around FL300 or higher

So this pull seems to work as written, but the necessity of remembering to repeatedly add/subtract the field elevation makes it harder in the long run I would think, so I figured I'd bring that idea up. Of course, this all isn't to say we shouldn't just merge this and do the rest later, it's just something to chew on! haha :smile:

@Fechulo, yes I am going to merge.
@erikquinn, the add/subtracts are definitely an issue.  My preference would be to implement most of it as methods: altitudeAGL(), altitudeMSL(), etc.. Probably altitude() should be the same as altitudeMSL().  My reasoning is that would allow changing which ones are calculated on demand and which ones are cached without breaking other parts of the program.  The same principle applies for the speed values.
As an aside, my strong preference is to use whole words for variables/properties/methods.  I definitely read the code many more times than I write and it is much easier for me when full words are used.

@tedrek makes sense, sounds like a fine plan to me!


Automatically update the time of conferences through crawlers

Some conferences seem to have not been updated for a long time because no one cares about them. Do you consider adding crawlers and regularization to automate this process?

Thank you for kindly suggesting this. We have indeed considered adding crawlers to our website serveal months ago. However, due to the format of each conference differ every year, developing the crawlers can be time-consuming for maintainers. We appreciate your feedback and welcome any form of contributions.

Hey, I am maintaining another fork of ai-deadlines, and hacked a little Python script that uses LLMs through the OpenAI API to "crawl" conference websites and keep the YAML files up-to-date semi-automatically. https://github.com/blockchain-deadlines/blockchain-deadlines.github.io/blob/main/chatgpt-updater.py I do double-check its output before committing, but it works pretty reliably despite the calls-for-papers varying widely across venues and time. Maybe it's of use for you!


⚙ Dev Stack

Frameworks

Middleman
Bulma

Preprocessors

Haml
Sass
TypeScript

CI / CD

Use GitHub Actions to push Middleman build folder to a production branch
Use Porkbun GitHub app to automatically deploy changes from that production branch

Deploy FTP

Configure Middleman to deploy through FTP
Store host, user, and pass in a .gitignored file

Frameworks

Research JavaScript testing frameworks and add one
Review existing codebase and write tests if needed

Frameworks

Middleman needs js files in certain directories
Use webpack to manage package dependencies more easily


Move open Hyperion PRs to mx_bluesky

There are a number of open PRs in Hyperion (https://github.com/DiamondLightSource/hyperion/pulls), we should move them to mx_bluesky.
Note: If we think they are stale (https://github.com/DiamondLightSource/hyperion/pull/942 maybe) then no need to move them
Acceptance Criteria

There are no more open PRs on hyperion, they are all on mx_bluesky

All non-stale ones are now moved


ASK: Could suggest mode become the default?

This would make the new table structure the default when implementing 63.
https://github.com/AppThreat/dep-scan/issues/63
I would like to slowly transform this tool to offer actionable ideas rather than merely displaying CVE output.

Suggest is not the default.


video.position = value doesnt work (kivy.uix.video) and seek works only with percentage, not actual position

Versions

Python: 3
OS: windows 10
Kivy: latest
Kivy installation method: pip

Description
Trying to set the video widget's streaming position value does not actually set the video stream's position.
I can get position, but cannot set position
The only way to set the video to a position from within the python file is via the seek() method of the widget. However seek only takes 0-1 % value. In my use case I need to set precise position in a value that is compatible with duration.
How do we do that?
A workaround that comes to mind is converting the position value (which I can get) to a percentage value of duration - but thats kind of hacky, isn't it?

A workaround that comes to mind is converting the position value [...]

I don't have any better suggestions, if you want it to work with current releases this is probably what it boils down to... Looking at kivy/core/video/__init__.py  seems a bit weird to me, setting the position property actually calls seek with the value, source link. That doesn't seem right, position is in seconds, seek wants a percentage (at least according to its signature).

@bionoid you are right. We should have another function to seek in seconds when position is set

I agree with this proposed change, allowing setting position makes more sense.


Use merge_qkv to replace fused_qkv for llama2

Description
1. Why the change?

Use merge_qkv to replace fused_qkv for llama2 to improve batch performance

update to use new rope

[x] validate Llama-2-7b-chat-hf when transformers 4.36.0 with IPEX_LLM_QUANTIZE_KV_CACHE=0

[x] validate Llama-2-7b-chat-hf when transformers 4.36.0 with IPEX_LLM_QUANTIZE_KV_CACHE=1

[x] validate Llama-2-7b-chat-hf when transformers 4.31.0 with IPEX_LLM_QUANTIZE_KV_CACHE=0

[x] validate Llama-2-7b-chat-hf when transformers 4.31.0 with IPEX_LLM_QUANTIZE_KV_CACHE=1

[x] validate Llama-2-7b-chat-hf when transformers 4.41.0 with IPEX_LLM_QUANTIZE_KV_CACHE=0

[x] validate Llama-2-7b-chat-hf when transformers 4.41.0 with IPEX_LLM_QUANTIZE_KV_CACHE=1

2. User API changes
No change.
3. Summary of the change

4. How to test?

[ ] Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.

PR validation: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/10265377508/job/28401561843

PR validation is passed: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/10276986872


Unable to install GOAT on Debian 12

I attempted to install GOAT using both methods listed in the README.MD. Both end with the same error:
$ go install github.com/bluesky-social/indigo/cmd/goat@latest
go: downloading github.com/bluesky-social/indigo v0.0.0-20241122170530-feceb364ee49
go/pkg/mod/github.com/bluesky-social/indigo@v0.0.0-20241122170530-feceb364ee49/atproto/crypto/p256.go:4:2: package crypto/ecdh is not in GOROOT (/usr/lib/go-1.19/src/crypto/ecdh)
go/pkg/mod/github.com/bluesky-social/indigo@v0.0.0-20241122170530-feceb364ee49/util/http.go:5:2: package log/slog is not in GOROOT (/usr/lib/go-1.19/src/log/slog)

It looks like you are running Go v1.19 (maybe the distro version?). As mentioned in the README:

We develop using the latest stable version of the language

we are currently a bit behind, targeting go v1.22

i'm getting
build github.com/bluesky-social/indigo/cmd/gosky: cannot load crypto/ecdh: malformed module path "crypto/ecdh": missing dot in first path element

on
go version go1.13.8 linux/amd64

then i found a handy version manager and switched to 1.23.4, and got this error:

downgraded to 1.22.4 just in case, same error, then ran the suggest go mod tiny, then tried again and voilà.
happy to open a readme PR if it would help other goofballs like me?