Bug Report: Application Crash on Image Capture Failure in gphoto2 Backend

Description
The application crashes when attempting to capture an image using the gphoto2 backend, specifically when the image is black, and the maximum retry limit of 3 is reached. This issue typically occurs when the camera, such as the Canon EOS 2000D, is unable to find focus and fails to take a picture, likely leading to a timeout. An HTTP Exception is raised with the error message: 'NoneType' object has no attribute 'create_fileset_unprocessed' (originating from application.py). Subsequently, the application requires a restart to resume functionality.
Steps to Reproduce

Configure the application with a Canon EOS 2000D camera using the gphoto2 backend.
Attempt to capture an image in conditions where the camera cannot find focus, leading to a black image output.
Observe the behavior of the application as it retries image capture up to the maximum limit (3 attempts).

Expected Behavior
The application should handle the failure gracefully, logging the error without crashing. It should then just end the cycle.
Actual Behavior
The application crashes after failing to capture an image within 3 attempts, raising an HTTP Exception related to a 'NoneType' object and necessitating a restart.
Error Messages
2023-12-12 12:32:54,086 [CRITICAL] finally failed after 3 attempts to capture image! (processingservice.py:182)
2023-12-12 12:32:54,086 [   ERROR] finally failed after 3 attempts to capture image! (processingservice.py:310)
Traceback (most recent call last):
  File "/home/fotobox/.local/lib/python3.10/site-packages/photobooth/services/processingservice.py", line 308, in start_job_1pic
    self.start(JobModel.Typ.image, 1)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/event.py", line 54, in trigger_event
    return event_instance.trigger(self, *args, **kwargs)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/event.py", line 29, in trigger
    return machine._process(trigger_wrapper)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/statemachine.py", line 288, in _process
    return self._processing_loop()
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/statemachine.py", line 303, in _processing_loop
    result = trigger()
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/event.py", line 27, in trigger_wrapper
    return self._trigger(trigger_data)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/event.py", line 39, in _trigger
    if transition.execute(event_data):
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/transition.py", line 140, in execute
    result = machine._activate(event_data)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/statemachine.py", line 336, in _activate
    self._callbacks_registry[target.enter].call(
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/callbacks.py", line 228, in call
    return [
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/callbacks.py", line 229, in <listcomp>
    callback(*args, **kwargs)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/callbacks.py", line 29, in __call__
    result = self._callback(*args, **kwargs)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/dispatcher.py", line 48, in __call__
    return self._cache(*args, **kwds)
  File "/home/fotobox/.local/lib/python3.10/site-packages/statemachine/signature.py", line 56, in method_wrapper
    return method(*ba.args, **ba.kwargs)
  File "/home/fotobox/.local/lib/python3.10/site-packages/photobooth/services/processingservice.py", line 183, in on_enter_capture
    raise RuntimeError(f"finally failed after {MAX_ATTEMPTS} attempts to capture image!")
RuntimeError: finally failed after 3 attempts to capture image!
2023-12-12 12:32:54,088 [    INFO] start postprocessing phase 1 (processingservice.py:196)
2023-12-12 12:32:54,088 [    INFO] postprocessing last capture: mediaitem=None (processingservice.py:200)
2023-12-12 12:32:54,088 [CRITICAL] 'NoneType' object has no attribute 'create_fileset_unprocessed' (processing.py:31)
2023-12-12 12:32:54,088 [   ERROR] HTTPException: HTTPException(status_code=500, detail="something went wrong, Exception: 'NoneType' object has no attribute 'create_fileset_unprocessed'") (application.py:91)
2023-12-12 12:32:54,089 [    INFO] <IP_ADDRESS>:46652 - "GET /processing/chose/1pic HTTP/1.1" 500 (h11_impl.py:478)
2023-12-12 12:32:54,153 [   ERROR] error capture lores image for stream. timeout expired attempt=3/3, retrying (abstractbackend.py:141)
2023-12-12 12:32:54,153 [CRITICAL] critical error getting stream. failed to get lores image after 3 attempts. giving up! (abstractbackend.py:149)
2023-12-12 12:32:54,766 [    INFO] (gp_camera_capture [gphoto2-camera.c:1339]) 'camera->functions->capture (camera, type, path, context)' failed: -110 (port_log.py:20)
2023-12-12 12:32:54,768 [CRITICAL] error capture! check logs for errors. [-110] I/O in progress (gphoto2.py:285)

Additional Information

This issue has been consistently reproducible under specific conditions with the Canon EOS 2000D.

I will try with my Canon ESO 1000D later. Please standby.

I see your point, it's same with my Canon.
Two things going on:

trying to get a high quality image. due to no focus after 3 times it fails finally.

in the background the lores stream tries to continue but because blocked by high quality image processing no preview image can be sent. finally the stream fails.

I changed logging to look a bit less drastic and removed the exception. There are many errors still coming up, but we cannot say it's from autofocus failing because the camera does not provide that information.

I changed the timeout handling for stream generation slightly (timeout 2 times than high quality capture timeout). This way the stream recovers after the image failed.

In future one can add a notification about the failed image on the screen.
Will release a new version in a few minutes.
Please test and let me know if it solves your issue.

Released: https://github.com/photobooth-app/photobooth-app/releases/tag/v0.21.0

Hi,
I tried out your new fix, works flawlessly for this case, thanks for this
lighting fast update :).
Still, wouldn't it be better to fully retry eg forever? And reopen gphoto2
as eg this also then fixes the case when the camera gets disconnected and
reconnected (or turned off and on, eg on power outage).
Lg
michael @.***> schrieb am Di., 12. Dez. 2023, 19:58:

Released:
https://github.com/photobooth-app/photobooth-app/releases/tag/v0.21.0
—
Reply to this email directly, view it on GitHub
https://github.com/photobooth-app/photobooth-app/issues/133#issuecomment-1852632184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANU6NJ3WBALPQV5DTLK7HTYJCSNFAVCNFSM6AAAAABARKLXCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGYZTEMJYGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I understand what you mean.
When you mean to retry forever, you probably mean to check permanently in the background if the camera is unavailable and reconnect?
Thats different from trying to finish the capture job in a limited number of times.
Background check is implemented already. When you turn off the camera, check the logs - it will go to a failsafe mode and notices the camera is not available. It checks regularly to reconnect. Turn on the camera again and wait little time until it reconnects.
Whats missing unfortunately is to inform the frontend, that the stream is available again. Press F5 in the browser and the live-preview is back again :)
I leave this open, so it can be fixed one day properly.

So the one thing missing is just the websocket (fastapi + vue)?
eg. workflow would then be:

on start, frontend subscribes to the backend websocket
frontend listens to this endpoint for changes
if some major changes happen, the websocket informs the frontend with a message (eg. refresh page)
frontend reacts to this message and refreshes page

I could implement the serverside part. Sadly I'm not familiar with vuejs, so I will have to look into how to implement this.

I tried to fix it but ran into issues.
It would be sufficient to hide the preview and show again on main screen. That would work, but unfortunately the browser (here chrome) keeps the old stream active and starts another stream. Thats not intended, did not find a way around this yet.

Actual issue is solved, followup created #137


APT whitelist request for wine1.7

There is already wine, but I need upgraded version of it, so I'm not sure if there is any workaround?
See my log build.
It is in: ppa:ubuntu-wine/ppa:
sudo add-apt-repository -y ppa:ubuntu-wine/ppa

Deb source line:
deb http://ppa.launchpad.net/ubuntu-wine/ppa/ubuntu vivid main
deb-src http://ppa.launchpad.net/ubuntu-wine/ppa/ubuntu vivid main

It's in:
ppa:ubuntu-wine/ppa

@travisbot Any update?


version 8.0.2

Requirements

Update to newest version of jira as of may 31th 2019.

Description of the Change

Updated version number.

Verification Process

Test-installation works fine.

Applicable Issues

None

This was closed with #128


Scientific Calculator

Calculator Functions
Description : This calculator contains
Addition, substraction , multiplication, division , log,ln, square, x^y , square root, factorial, reciprocal, sin, cos, tan ,sin inverse , tan inverse , cos inverse, pi, deg ,rad.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign @1ananya3

/assign

/assign


Loop in UI without any obvious exit

A piece of code that I am trying to debug goes into an endless loop, most probably due to some bug on my side. Pressing Command-. opens the following debugger window:

But there seems to be nothing I can do from there. MacOS shows its colored spinning wheel, and no UI element reacts to anything. Even closing the debugger window is not possible. I can do another Command-. and get another window s shown above, but that's it.
The situation is completely reproducible from my image, but I haven't been able to provoke it starting from a fresh image.

could it be that the print string causes the problem?

In the meantime I found the bug in my code: I had a method calling itself due to a typo. Once that was fixed, everything worked fine, including the display of the print string, so I suspect that was not part of the problem.

I am glad it worked out.

Wait a minute... I am no longer immediately concerned by this problem, but it's still there! Any endless loop that you try to interrupt with Primary-. will cause the same problem. Example:

Tight loops can become uninterruptible.


Add Bahasa Indonesia Translation

I translated clean-code-javascript in Indonesian Language 🎉
thank you

I'm sorry, my branch is not correct for this pull request


It is better to use the repository field in Cargo.toml

To allow Crates.io , lib.rs and the Rust Digger to link to it. See the manifest for the explanation.

Thanks! And thanks for making the PR


Update test_synth_slt_arctic_full.conf

Reference to old SPTK-version.

These files are just for reference -- not meant for usage. The config files to be used for training will be generated. Even the whole path is changed from what has been used previously.

Ok is the same true for the file https://github.com/CSTR-Edinburgh/merlin/blob/master/misc/recipes/dnn/feed_forward_dnn.conf ?

yeah, all of them -- none of those files are updated as per the current configuration. However, one can look at the architecture and other important parameters from those files to take clues.


Initialize list

Hello,
I am using your dual list and have gotten it working.  I have a simple question about datasets that are already defined. ( ie: the 'confirmed' array already has elements).
What do I pass as the source and destination/confirmed?
Say my 'universe' of all available items are the numbers 1 - 10
[1,2,3,4,5,6,7,8,9,10]
But I want to pre-initialize the destination with the numbers 1-3
[1,2,3]
I assume I would take this into account when passing the arrays as follows:
source:   [4,5,6,7,8,9,10]
destination:  [1,2,3]
Is this correct? ( It doesn't appear to be working is why I am asking)

The source should be: [1,2,3,4,5,6,7,8,9,10]
The destination should be: [1,2,3]
The source is the universe set of all possibilities. The destination is just the confirmed or chosen.
The demo shows an example of this with 'Eureka' station.


Taxonomy menu name isn't using the "has_many" value.

When registering a custom taxonomy, the text used in the menu simply adds an "s" to the end of the singular name. It should use the "has_many" value for this, like the post type.
  "labels": {
    "has_one": "Industry",
    "has_many": "Industries",
    "text_domain": "sage"
  },

The example yields "Industrys" as the menu name.

Me too, any solution?

@budimanfajarf @stevebrinston I will look into this!
If you happen to be using Intervention, I would recommend upgrading to 2.0.0-RC (which is due for an official release any day now) and register custom post types using that. It will likely be more heavily supported going forward.

Not a fix, but a workaround. Overrides -> menu_name was missing from taxonomy-all.json. While it should be using the has_many label for the menu name like the custom post type, we can define the menu_name the same.
  "labels": {
    "has_one": "Industry",
    "has_many": "Industries",
    "text_domain": "sage",
    "overrides": {
      "menu_name": "Industries"
    }
  },


textual changes

Checklist

[ ] Tests have been written/updated (if necessary)

[ ] All tests are passing

[ ] Docs have been updated (if necessary)
[ ] Updated Linear issue to In Review

Description
The workind of "adding a device" is changed; in order to accomodate the use of these buttons for Wi-Fi reset as well.
Various other minor textual items were changed.
Linked Issues
Additional context
The icons associated with the two buttons should change as well, but I did not have the time to find/change these.
Suggestions:

apps\expo\src\screens\home\HomeScreen\AuthenticatedHomeScreen.tsx : change icon from camera-outline to an icon for a QR-code.
apps\expo\src\screens\home\AddDeviceScreen.tsx: in the button that used to say "Add", change the title to common.connect and use an icon that clearly indicates a Wi-Fi network.

@henriterhofte as requested in your comment
I changed the icon on the AuthenticatedHomeScreen:

And I added icons to the connect and cancel buttons on the AddDeviceScreen:


stop() not working

I am running Visibility on Angular 1.5
It starts ok, but when i try to stop it, it just won't work.
   if ($rootScope.hdRTimerId != undefined)          Visibility.stop($rootScope.hdRTimerId);
This is how i am trying to stop it.
I am saving the id in the root scope so i don't lose it with page transitions, i won't have a problem because i am only using Visibility on 1 page, when i get back to the page, i try to run stop if the Id is set.
But it wont work and the callback is fired anyway :-(

How did you started it?

Sorry i forgot to add that.
$rootScope.hdLTimerId = Visibility.every(5 * 1000, $scope.UpdateLeft);

Sorry, have no idea. This project is not really alive :D. If you will send PR, I will release it. But spend most of my open source investigation time on other projects.

Oh i had no idea D: why is it not alive?

Mostly because PostCSS and Autoprefixer are more popular. Logux and Size Limit could make Web better.

Also, we don’t need polyfill right now, so using so big library just for every sugar is overkill.

This is the only timer component i have ever used. :-\ I am a user for years hahaha
First time i am having an issue

you think i should rollback to setTimeOut?

Or just try to implement by yourself, it is very simple stuff

I am a user for years hahaha

Thanks :D

I think the first time i used this was back in 2014, i made a huge graphic screen with this. The visibility thing is very important for me, since i am used to digest huge amounts of data from the network, and i need to do that only when needed, when people switch screens to use another "report" i want to stop the previous one and all that jazz.
Not the main reason why i am using it now, but back then, it was a very important thing.
This time i am really just using it because i trust it :)

First time i am using it with Angular tho, so i am guessing the $scope thing have something to do with my issue. I will try to figure it out :)

Ohhh i think i know what's going on.
It is probably reloading the JS when i am switching pages, making all counters go back to zero.
So it has nothing to stop.
But the SetInterval is still alive in the LIMBO :-(


PATH SUM

Hey @ayu8 i want to add this solution in Binary tree folder, pls assign me this and add this under hacktoberfest label

Are you going to work on https://leetcode.com/problems/minimum-path-sum/ ?
This has been already assigned

Go ahead !
Make sure to go through CONTRIBUTING.md once

I have solution to this problem. Can i contribute ?? Plz assign me this under hacktober fest 22
Plz @ayu8
@Sohanlalkush Bro Can I help you with the code ??


Make sure we attribute and credit correctly

Need to go through datasets we are using and packages and check the requirements on their use with respect to licences - we may need to attribute, and at minimum, I think we should add an attributions section to the main README

Piano-midi reqs are here: http://www.piano-midi.de/copy.htm. The standard is as a url footnote in the paper.

The paper cites pandas, pretty_midi, and mir_eval.

The paper includes a footnote link for PPDD, and cites LMD (where it draws data from).

I'll make sure these are all added to the relevant README.md


Reduce title length

Request Beni Altmann (CRAN): Please reduce the length of the title to less than 65 characters.

@gabriellesimoneau On request of CRAN, I simplified the package title to "Precision Medicine". The abstract now reads as follows:
A doubly robust precision medicine Approach to fit, cross-validate and visualize the outputs of different models, including doubly-robust and machine learning methods, for the conditional average treatment effect based on count or survival outcomes.


Vulkan textures from previous frames are black

While debugging my vulkan renderer, I noticed that under certain circumstances, most textures start being displayed as black (0, 0, 0, 0) color. "Certain circumstances" seem to be somehow related to me trying to access textures that persist from previous frames. These textures are used as storage images in compute shaders across multiple frames (fluid simulation) and sometimes I can see their contents if I entirely overwrite it within one frame, but if I'm using data that's already there from previous frames, then they are displayed as black.
Here's one of those black captures: https://drive.google.com/file/d/1py7hx2EwDaTTDZQVRMCq4gctF0l9xroG/view?usp=sharing
Textures in question are for example in Compute Pass #1. All textured are displayed as black, but I know from behavior of the renderer that they are not.
Another clue: in that pass, all textures are actually derived from 3D Image 209 (that persists from previous frame) and if was black, then everything else would be as well. So probably that texture got screwed and everything else was a consequence of it.
I'm running GTX1060 laptop GPU.

I was running 1.4 in my tests. The problem does not reproduce in a nightly build.


[MT-5231] Change table layout to auto

MT-5231

@aspirisen for some reason visual testing fails on Github, even though I've updated the snapshots locally. :man_shrugging:


With WinHttp make the send timeout configurable

Confirm by changing [ ] to [x] below to ensure that it's a bug:

[x] I've gone though Developer Guide and API reference
[x] I've searched for previous similar issues and didn't find any solution

Describe the bug
When communicating with a S3 compatible storage location with the AWS SDK we have observed a issue whereby when sending the data neither side has timed out when the data transfer is going extremely slow (8MB in one hour and 43 minutes) other requests running parallel went really quick so it probably a networking issue causing the slow connection. The client side AWS SDK didn't timeout because the AWS SDK sets the send timeout to be -1 or infinite in the WinHttpSyncHttpClient.
if (!WinHttpSetTimeouts(GetOpenHandle(), config.connectTimeoutMs, config.connectTimeoutMs, -1, config.requestTimeoutMs))
SDK version number
1.6.25
Platform/OS/Hardware/Device
Windows 10
Expected behavior
It would be useful if the send timeout could be configured via the client configuration the default can continue to be infinite however clients would be able to change the timeout if they require.

Hi @sbailey476 ,
Hmmm, I can see what you mean but I'm not sure if I consider this a bug, more like a feature request right?

Yeh I can see this is more of a new feature to the SDK rather than a bug


sensor: composite monitor - FAN failed to start running

Expected Behavior
slim build/profile completes without error.

Actual Behavior
slim build --target repro:latest

cmd=build info=param.http.probe message='using default probe'
cmd=build state=started
cmd=build info=params target.image='repro' continue.mode='probe' rt.as.user='true' keep.perms='true' tags='' image-build-engine='internal' target.type='image'
cmd=build state=image.inspection.start
cmd=build info=image id='sha256:ee301c921b8aadc002973b2e0c3da17d701dcd994b606769a7e6eaa100b81d44' size.bytes='9136' size.human='9.1 kB'
cmd=build info=image.stack index='0' name='hello-world:latest' id='sha256:ee301c921b8aadc002973b2e0c3da17d701dcd994b606769a7e6eaa100b81d44'
cmd=build state=image.inspection.done
cmd=build state=container.inspection.start
cmd=build info=container status='created' name='slimk_22109_20240304164609' id='87eb41d1a7fb3be5f8c93221d3945d943868ec3210d3102045a2124308bfad40'
cmd=build info=container id='87eb41d1a7fb3be5f8c93221d3945d943868ec3210d3102045a2124308bfad40' status='running' name='slimk_22109_20240304164609'
cmd=build info=container message='obtained IP address' ip='<IP_ADDRESS>'
cmd=build info=cmd.startmonitor status='sent'
cmd=build info=event.startmonitor.done status='received.unexpected' data='{"name":"event.monitor.start.failed","data":{"component":"monitor.runner","state":"/","errors":["SensorError{Op:sensor.fanotify.Run/fanapi.Initialize,Kind:call.error,Wrapped:{Type=syscall.Errno,Info=function not implemented,Line:120,File:github.com/slimtoolkit/slim/pkg/app/sensor/monitor/fanotify/monitor.go}}"]}}
'
slim: container stdout:
slim: container stderr:
time="2024-03-04T16:46:14Z" level=error msg="sensor: composite monitor - FAN failed to start running"
time="2024-03-04T16:46:14Z" level=error msg="sensor: failed to start composite monitor" error="SensorError{Op:sensor.fanotify.Run/fanapi.Initialize,Kind:call.error,Wrapped:{Type=syscall.Errno,Info=function not implemented,Line:120,File:github.com/slimtoolkit/slim/pkg/app/sensor/monitor/fanotify/monitor.go}}"
time="2024-03-04T16:46:14Z" level=error msg="sensor: run finished with error" error="run sensor without monitor failed: SensorError{Op:sensor.fanotify.Run/fanapi.Initialize,Kind:call.error,Wrapped:{Type=syscall.Errno,Info=function not implemented,Line:120,File:github.com/slimtoolkit/slim/pkg/app/sensor/monitor/fanotify/monitor.go}}"
slim: end of container logs =============
cmd=build info=report file='slim.report.json'
time="2024-03-04T11:46:15-05:00" level=error msg=terminating error="unexpected event type" stack="goroutine 1 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x5e\ngithub.com/slimtoolkit/slim/pkg/app.(*ExecutionContext).FailOn(0xc000324ce0, {0x2f28180, 0x3f915f0})\n\tgithub.com/slimtoolkit/slim/pkg/app/execontext.go:58 +0x58\ngithub.com/slimtoolkit/slim/pkg/app/master/command/build.OnCommand(_, _, {_, _}, _, {_, _}, {_, _}, {0x0, ...}, ...)\n\tgithub.com/slimtoolkit/slim/pkg/app/master/command/build/handler.go:1136 +0x4a45\ngithub.com/slimtoolkit/slim/pkg/app/master/command/build.glob..func1(0xc0001afe00)\n\tgithub.com/slimtoolkit/slim/pkg/app/master/command/build/cli.go:760 +0x5d51\ngithub.com/urfave/cli/v2.(*Command).Run(0x3fa9340, 0xc0001afe00, {0xc00049a540, 0x3, 0x3})\n\tgithub.com/urfave/cli/v2@v2.27.1/command.go:279 +0x9dd\ngithub.com/urfave/cli/v2.(*Command).Run(0xc0004a2160, 0xc0001af880, {0xc0001ae040, 0x4, 0x4})\n\tgithub.com/urfave/cli/v2@v2.27.1/command.go:272 +0xc2e\ngithub.com/urfave/cli/v2.(*App).RunContext(0xc000496200, {0x2f46348?, 0x401fcc0}, {0xc0001ae040, 0x4, 0x4})\n\tgithub.com/urfave/cli/v2@v2.27.1/app.go:337 +0x5db\ngithub.com/urfave/cli/v2.(*App).Run(...)\n\tgithub.com/urfave/cli/v2@v2.27.1/app.go:311\ngithub.com/slimtoolkit/slim/pkg/app/master.Run()\n\tgithub.com/slimtoolkit/slim/pkg/app/master/app.go:15 +0x45\nmain.main()\n\tgithub.com/slimtoolkit/slim/cmd/slim/main.go:15 +0x187\n"
cmd=build info=fail.on version='darwin/amd64|Transformer|1.40.11|1b271555882eacdfb4e6598d6d0552e9b9b1449b|2024-02-02_01:36:22PM'
cmd=build info=exit location='/usr/local/bin' code='-1' version='darwin/amd64|Transformer|1.40.11|1b271555882eacdfb4e6598d6d0552e9b9b1449b|2024-02-02_01:36:22PM'
app='slim' message='GitHub Discussions' info='https://github.com/slimtoolkit/slim/discussions'
app='slim' message='Join the CNCF Slack channel to ask questions or to share your feedback' info='https://cloud-native.slack.com/archives/C059QP1RH1S'
app='slim' message='Join the Discord server to ask questions or to share your feedback' info='https://discord.gg/9tDyxYS'
app='slim' message='Join the Gitter channel to ask questions or to share your feedback' info='https://gitter.im/docker-slim/community'

Steps to Reproduce the Problem

Create basic Dockerfile

 # Dockerfile
 from hello-world

Build image
docker build -t repro .
Run slim commands
slim build --target repro:latest

Specifications

Version:

slim version darwin/amd64|Transformer|1.40.11|1b271555882eacdfb4e6598d6d0552e9b9b1449b|2024-02-02_01:36:22PM
Docker version 25.0.3, build 4debf41

Platform: macOS Ventura 13.6.4

Realizing the install instructions for Macs seems to have installed the amd64 version. Will try again with an alternate installation option.

User error on my end. I went back through the installation process and just copied the wrong URL.

@nickpassarella it happens :) let me know when you decide to go beyond the hello-world :)


don't allow call on zero arity preds

we only use this in testing, so it wasn't too bad, i just tried to create a goal with a zero-arity pred and it got treated as a LiftedAtom, so it crashed


QUESTION - what does the Campaign ContentId relate to?

Are you a Fivetran customer?
Yes, Chistoph, Sustain.life
Your Question
I'm seeing content_id in the campaign
- name: content_id
description: The ID of the content.
What is this referring to?  I would have expected a table with contents which i don't see.  My hope is to see the email body somewhere?
Additional context
see above
Please indicate the level of urgency and business impact of this request
medium...  I'd like to avoid our dev team building a custom call into hubspot just to get the email body.

Hi @leinemann you are correct that the content_id relates to the body of the email. However, after chatting with our internal team it seems we do not bring the content object into our existing schema for the HubSpot connector.
I see you are looking at possibly building out a custom call to HubSpot for this object. Does it seem this information would be useful? It could work to possibly open a feature request ticket within the Fivetran Support portal to ask for this feature to be included in a future version of the HubSpot connector.

Ok, great, thanks for looking into this @fivetran-joemarkiewicz.  I've raised this feature request: https://support.fivetran.com/hc/en-us/community/posts/4405935477015-Connector-Improvement-Bring-in-Content-object-from-hubspot-to-be-able-to-resolve-the-content-id

Of course! Thanks for opening the feature request. I will close this issue as you have now opened the new ticket on our support portal. Please feel free to reopen this ticket or open a new one if you have any future questions.
Thanks 😄


feat(s3): Add new check s3_bucket_cross_account_access

Context
Ensuring secure access management is crucial for protecting cloud resources and mitigating security risks. For Amazon S3 buckets, it’s important that bucket policies restrict sensitive actions from external AWS accounts. Implementing least privilege access helps reduce risks from unauthorized access and malicious changes.
Description
An Amazon S3 bucket policy should block sensitive actions, such as modifying bucket policies or access control lists, from external AWS accounts. Allowing these actions from external principals could lead to unauthorized access or data breaches. To maintain robust security, bucket policies need to be reviewed and updated to ensure that these sensitive actions are not permitted from external accounts. That's why we add this new check.
Checklist

Are there new checks included in this PR? Yes.

If so, do we need to update permissions for the provider? No.

[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[x] Review if backport is needed.

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Blocked by #5067, so we need that logic to be applied in this PR.


Edit browser set page broken

When viewing the edit browser set page, new filters are added by themselves in this chaotic fashion:

Thanks for reporting! Bug should be fixed now. If you go back to the editor as it is, hit Save and re-edit it it should appear without all the duplicate entries.

Thank you!!!


Support for edge

Hey there,
I really like your idea and think about using the boilerplate for one of my projects. What is about supporting edge browser. It is based on web extensions as well. Just a few little changes compared to chrome.
Thanks
Jan

I think submitting an extension to the Windows store is currently restricted.

Submitting a Microsoft Edge extension to the Windows Store is currently a restricted capability. Reach out to us with your requests to be a part of the Windows Store, and we’ll consider you for a future update.

Soure
I am currently working on adding support for Safari. I will move on to Edge after that.

Hey, thanks for sharing your work !
Any idea concerning the release date of safari support ?


GH786: Fix return values from handle_info

The incorrect stop message was causing log spam.
See #786

+1


Twitter redesign to move the component to it's separate project.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ @pabloem ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Looks good to me. I'll mrge after the one question.


AttributeError: 'HQQLinear' object has no attribute 'weight'

Thank you for creating this amazing package. It looks very promising. But i am facing some issue on installation on Linux Mint (Ubuntu) desktop. Where i have a NVIDIA RTX 3060 GPU with 12GB  VRAM.  I am just trying the same code as provided in the reference readme.
It can download the YouTube video and convert to MP3, also model is downloaded. It loaded the model into memory (not sure) but then i am stuck. Below the error. If need any trace log i can share.
2024-05-10 16:10:34,324 - INFO - We will use 90% of the memory on device 0 for storing the model, and 10% for the buffer to avoid OOM. You can set `max_memory` in to a higher value to use more memory (at your own risk).
Traceback (most recent call last):
  File "/home/ml/whisperplus/demo-test.py", line 24, in <module>
    pipeline = SpeechToTextPipeline(
  File "/home/ml/.local/lib/python3.10/site-packages/whisperplus/pipelines/whisper.py", line 26, in __init__
    self.load_model(model_id, quant_config)
  File "/home/ml/.local/lib/python3.10/site-packages/whisperplus/pipelines/whisper.py", line 43, in load_model
    model = AutoModelForSpeechSeq2Seq.from_pretrained(
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 563, in from_pretrained
    return model_class.from_pretrained(
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3689, in from_pretrained
    ) = cls._load_pretrained_model(
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/modeling_utils.py", line 4123, in _load_pretrained_model
    new_error_msgs, offload_index, state_dict_index = _load_state_dict_into_meta_model(
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/modeling_utils.py", line 847, in _load_state_dict_into_meta_model
    old_param = getattr(old_param, split)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1695, in __getattr__
    raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
**AttributeError: 'HQQLinear' object has no attribute 'weight'**

It's a problem with the Transformers library.
https://github.com/huggingface/transformers/issues/30727
Would you try this?
pip install git+https://github.com/huggingface/transformers.git@d0c72c15c25e100860b6af692d084f06546a0b7a

@kadirnar  Thank you for your quick response. But I am still facing same issue. 😔

Transformers library solved the error. Can you try deleting the Transformers library and reinstalling it?
pip install git+https://github.com/huggingface/transformers

I think the issue from transformers has been solved. But further there is something else :
2024-05-11 14:51:45,554 - INFO - We will use 90% of the memory on device 0 for storing the model, and 10% for the buffer to avoid OOM. You can set `max_memory` in to a higher value to use more memory (at your own risk).
2024-05-11 14:51:55,127 - INFO - Model loaded successfully.
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
2024-05-11 14:51:56,829 - INFO - Transcribing audio...
Traceback (most recent call last):
  File "/home/ml/whisperplus/demo-test.py", line 31, in <module>
    transcript = pipeline(
  File "/home/ml/.local/lib/python3.10/site-packages/whisperplus/pipelines/whisper.py", line 92, in __call__
    result = pipe(audio_path)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/automatic_speech_recognition.py", line 285, in __call__
    return super().__call__(inputs, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/base.py", line 1234, in __call__
    return next(
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/pt_utils.py", line 124, in __next__
    item = next(self.iterator)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/pt_utils.py", line 269, in __next__
    processed = self.infer(next(self.iterator), **self.params)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/base.py", line 1149, in forward
    model_outputs = self._forward(model_inputs, **forward_params)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/pipelines/automatic_speech_recognition.py", line 506, in _forward
    generate_kwargs["encoder_outputs"] = encoder(inputs, attention_mask=attention_mask)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/models/whisper/modeling_whisper.py", line 1209, in forward
    layer_outputs = encoder_layer(
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/models/whisper/modeling_whisper.py", line 765, in forward
    hidden_states, attn_weights, _ = self.self_attn(
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/transformers/models/whisper/modeling_whisper.py", line 435, in forward
    query_states = self._reshape(self.q_proj(hidden_states), -1, bsz)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/ml/.local/lib/python3.10/site-packages/hqq/core/quantize.py", line 790, in forward_aten_backprop
    return HQQMatmulNoCacheDeq.apply(x, self.dequantize_aten, self.bias)
  File "/home/ml/.local/lib/python3.10/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/ml/.local/lib/python3.10/site-packages/hqq/core/quantize.py", line 257, in forward
    out = torch.matmul(x, dequantize().t())
  File "/home/ml/.local/lib/python3.10/site-packages/hqq/core/quantize.py", line 713, in dequantize_aten
    W_est = self.dequantize_Wq_aten(W_q, meta)
  File "/home/ml/.local/lib/python3.10/site-packages/hqq/core/quantize.py", line 661, in dequantize_Wq_aten
    return hqq_aten.dequantize(
AttributeError: 'NoneType' object has no attribute 'dequantize'

Tested and working with RTX 3090. Did you do this?
pip uninstall transformers
pip install git+https://github.com/huggingface/transformers

i am trying it on RTX 3060. Still, i am facing the same issue. I will try it on Colab or somewhere else. Then update you!

Tomorrow I will update colab notebook and test it.


Option to disable chatbox gradient

Default behaviour:

Behaviour when gradient toggled off:

fixes #9432

can be done using the chatbox opacity external plugin


Merge <IP_ADDRESS> to master

This PR merges the changes from the release_<IP_ADDRESS>_experimental branch to master. It includes the following:

SharedStrings to reduce memory utilization
StorageManager to start moving the code for managing Asset storage to one place
Extra logging when calculating overlap between resources
Switching to C++11 for-each loops in several places
Remove expensive QString::latin calls in a few places
Allow invalid options in the XMLparams file (to handle the obsolete DEALLOCATE_ALL option)
Release notes for the above

All commits are either by me or were previously included in this repo, so there are no issues with author consent.

Reviewed and ran unit tests on both Ubuntu 16 and CentOS 7 platforms.


feat(FeeCollector): add configurable partyDaoFeeBps per Party

Fee defaults to 0 and has to be set manually for each position? Doesn't seem ideal.


Travis fixes

Codecov Report

Merging #797 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #797   +/-   ##
=========================================
  Coverage     99.43%   99.43%
  Complexity     1917     1917
=========================================
  Files           288      288
  Lines          5700     5700
  Branches        289      289
=========================================
  Hits           5668     5668
  Misses            5        5
  Partials         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f8ca4...120a87c. Read the comment docs.


[BUG] Mac users not able to generate file using ng generate ng-ag-grid-schematics:nags

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Expected Behavior
File generation failure
Steps To Reproduce
1 - npm install ng-ag-grid-schematics
2 - ng add ng-ag-grid-schematics
3 - ng generate ng-ag-grid-schematics:nags

Provide Name
Provide Path
Provide Project

4 - Styling and State Management

Choose Style
State management

Error :
Fro more info follow instructions provided in the README
https://www.npmjs.com/package/ng-ag-grid-schematics?activeTab=readme
Anything else?
No response
What browsers are you seeing the problem on?
No response

I've identified a documentation flaw and an uncaught exception in cases where the project name is not specified. Your feedback is highly valuable, and I've taken the necessary steps to address these issues. The following commits have been merged to implement the fixes:
b1b8032742d97f11f32af107e181e929bcf7128f
e61d200c6b8a69ff02f4185ef2b9aeee821d0016
8cee95e8555dc65d540b05423daba589ad714fcd
Furthermore, it's worth noting that the schematics are designed to be operating system-agnostic, ensuring compatibility across different platforms. You can confidently run them anywhere without concerns.
I've also added screenshots with inputs for the prompt and highlighted where to locate the project name information. This should provide clearer guidance for users.
Thank you for bringing this to my attention, and please feel free to reach out if you have any additional feedback or concerns.


IOS Unable to copy asset information

When running SpeechSynthesisUtterance() on IOS 9.1 I get the following error:
|AXSpeechAssetDownloader|error| ASAssetQuery error fetching results (for com.apple.MobileAsset.MacinTalkVoiceAssets) Error Domain=ASError Code=21 "Unable to copy asset information" UserInfo={NSDescription=Unable to copy asset information}
My code is as follows:
var u = new SpeechSynthesisUtterance();
u.text = wmessage;
u.lang = 'en-US';
u.rate = 1.0;
u.onend = function(event) {
Help is appreciated!!!
Thanks!!!
Howard

This plugin is about speech recognition, SpeechSynthesisUtterance is about text to speech, and it's handled by the webview, not by the code. You can send the bug report to apple
https://developer.apple.com/bug-reporting/using-bug-reporter/
BTW, I tested the code and it's working on my device with iOS 9.2.


Official Anthropic function calling support?

Anthropic announced GA support for tools today (5/30): https://www.anthropic.com/news/tool-use-ga
Is this meant to be supported? I saw some PRs mentioned related to tool use, but the following code returns an empty list:
from langchain_aws import ChatBedrock  # langchain-aws v0.1.4 (latest)
from langchain_core.messages import HumanMessage
from langchain_community.tools import DuckDuckGoSearchRun

llm = ChatBedrock(
    model_id="anthropic.claude-3-sonnet-20240229-v1:0",
    region_name="us-east-1",
)

search = DuckDuckGoSearchRun()

tools = [search]

# llm with tools
llm_with_tools = llm.bind_tools(tools)

messages = [
    ("system", "You are a helpful assistant."),
    ("human", "What is LangChain Tool Calling?")
]

llm_with_tools.invoke(messages).tool_calls

Output:
[]

https://docs.aws.amazon.com/bedrock/latest/userguide/tool-use.html#tool-use-examples

@3coins what are your thoughts on adding Converse API support? Would we want a different class like ConverseBedrock maybe?

Ideally the implementation would allow for traditional LangChain tools to be passed, and they could be translated to toolSpec's. For example, I hope this will work in the future implementation:
from langchain_core.tools import tool

@tool
def calculator(a: int, b: int) -> int:
    """Perform multiplication."""
    return a * b

llm = ChatBedrock(
    model_id="anthropic.claude-3-sonnet-20240229-v1:0",
    region_name="us-east-1",
)

tools = [calculator]

# Bind tools to the LLM
llm_with_tools = llm.bind_tools(tools)

messages = [
    HumanMessage(content="What is the result of 42 multiplied by 3? Use the calculator tool."),
]

result = llm_with_tools.invoke(messages)

Function calling works with the invoke_model method too. At least for claude.

Quote from https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-bedrock-new-converse-api/

The Converse API provides a consistent experience that works with Amazon Bedrock models, removing the need for developers to manage any model-specific implementation. With this API, you can write a code once and use it seamlessly with different models on Amazon Bedrock.

Since the new Converse API provides the long-waited unified interface for all bedrock models and official tool use support, it makes sense to switch from invoke API to converse API as soon as possible.

In the new implementation on top of Converse API, we should also expose the complete response payload, including metadata like "stop_reason", such info becomes crucial now when working with function calling and agents.

@3coins what are your thoughts on adding Converse API support? Would we want a different class like ConverseBedrock maybe?

Given that there is a on going pull request implementing function calling via invoke_model, I also think that it is a good idea to have  a separate class for the converse method.

I found this issue as we want to use Bedrock models for our langchain work for robotics, so switching to converse API would be perfect. Right now it is more convenient to work with OpenAI.

#70 is still based on the legacy tool use of Claude, which is not recommended by Anthropic and does not work well with Claude 3.

@austinmw @yingzwang Correct me if I'm wrong. This code snippet should be using the official function calling from claude. If it is not claude 3 then it will use the old XML parsing way.
https://github.com/langchain-ai/langchain-aws/blob/c873bb2203ca357a2c565aebf7585fe0a67f5138/libs/aws/langchain_aws/chat_models/bedrock.py#L615-L633


Unable to quit ranger, not updating dir on opening a directory

nvim --version:

NVIM v0.6.1
Build type: Release
LuaJIT 2.0.5
přeložil  builduser

Features: +acl +iconv +tui

Operating system/version: Archlinux 1.0
nvim +'checkhealth rnvimr':

rnvimr: health#rnvimr#check
========================================================================
## OS
  - OK: Name: Linux

## Ranger
  - OK: Version: ranger 1.9.3

## Python
  - OK: Version: 3.10.1 (main, Dec 18 2021, 23:53:45) [GCC 11.1.0]

## Pynvim
  - OK: Version: 0.4.3

## Ueberzug (optional)
  - OK: Ueberzug is ready

## RPC
  - OK: RPC echo: Neovim send "Give me five!" and receive "Give me five!"

Describe the bug
A clear and concise description of what the bug is.
rnvimr doesn't update to current file after being launcher for the first time
Steps to reproduce the behavior:

literally, open with it a file
go elsewhere - like dir, or just select some file
open ranger again

Expected behavior
A clear and concise description of what you expected to happen.
open at the currently viewed file
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
This bug started happening after an update on 2. or 3.1.2022

Thanks, fixed now.


Add example of a simple fade in plan

Following our objective-c library conventions, create an examples/ directory with various view controllers.

Closed by c5e9e467aa712fb71990fa187fb471eefb7d30da.


Stacks using queues

Description
We are given queue data structure, the task is to implement stack using only given queue data structure.
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


removed nodejs v4 and v6 from travis due to EOL

Coverage remained the same at 100.0% when pulling 7e74879adbc1d993b0f62f80a7948ab87d8d7ad6 on adityapatadia:master into e445d08800d3764c60ae849731335b75511f0d93 on lukechilds:master.


Webpack: "The keyword 'static' is reserved"

ERROR in ./node_modules/vue-static/index.js 13:18
Module parse failed: The keyword 'static' is reserved (13:18)
You may need an appropriate loader to handle this file type.
|     Vue.mixin({
|         beforeCreate: function () {
>             const static = this.$options.static;
|             const destination = this.$static || this;
|             if (static && typeof(static) === 'function') {

=> rename to const static to something else.

Renamed the variable. Would love to hear your feedback to verify that it works for your setup now.

Thanks, works!


Localization PR from upstream

Backporting https://github.com/badlogic/heissepreise/pull/149 from https://github.com/Darkyenus

Sorry! I opened this in wrong repository.

No worries.
On Tue, Sep 19, 2023, 10:25 PM Jan Hutař @.***> wrote:

Sorry! I opened this in wrong repository.
—
Reply to this email directly, view it on GitHub
https://github.com/badlogic/heissepreise/pull/155#issuecomment-1726419448,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBBOZO3ORIKGW4ETAW3X3H5U3ANCNFSM6AAAAAA463LJOQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Add ls-lint with GitHub Actions

closes #6400

https://github.com/mruby/mruby/actions/runs/11816863161/job/32921070607?pr=6418
Some files that don't match our style:
2024/11/13 12:04:54 mrbgems/mruby-bin-strip/bintest/mruby-strip.rb failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-bin-strip/tools/mruby-strip/mruby-strip.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-exit/src/mruby-exit.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-hash-ext/src/hash-ext.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-object-ext/test/object-ext.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-proc-binding/src/proc-binding.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-proc-binding/test/proc-binding.c failed for rules: snakecase
2024/11/13 12:04:54 mrbgems/mruby-proc-binding/test/proc-binding.rb failed for rules: snakecase


Formatters need to throw for formats that are not supported

For example, the Guid formatter just accepts any format. We need to change it because otherwise we won't be able to add formats in the future.

This is being done as part of productizing. No need to track it here in corefxlab since it will no longer be the home for that package.


Add plumbing to set Verbose flag in ClientConfiguration

Closes #98

cc @liliC

Coverage decreased (-0.2%) to 91.772% when pulling 84bc74a2f219897f03f047e09c754ac1622535aa on verbose-config into 4c53612134f3e9dc633016a9dfe556fe915119d7 on master.


Init analysis c2r role

[x] Update README and replace leapp mentions with convert2rhel
[x] Add parse_c2r_report role
[x] Update content of analysis role folder

[x] handler
[x] vars
[x] tasks

[ ] Still need to test everything :)

missing line at the end of files
roles/parse_c2r_report/defaults/main.yml
roles/analysis/handlers/main.yml
roles/analysis/tasks/main.yml

Fixed as many linting issues as I could, there is few that I think could wait for future tasks (like changelog), not sure what is the problem with the parse_c2r_report command :thinking:

@matejbuocik I have no problem changing it but I had put there redhat-cop on purpose because from my understanding the repository will be moved to same org as https://github.com/redhat-cop/infra.leapp :)

Then it is all right :)

oamg instead of redhat-cop

It will be moved to redhat-cop in the future, so... I think we are just skipping one step and renaming to redhat-cop right away instead of doing it again in the future, right, @andywaltlova?

oamg instead of redhat-cop

It will be moved to redhat-cop in the future, so... I think we are just skipping one step and renaming to redhat-cop right away instead of doing it again in the future.

Yes


Naming conversion for the VS code in this doc

[Enter feedback here]
https://twitter.com/runtcpip/status/1381010132520337408

Looks like the naming conventions for the static web app in VS code on this doc did not match the user experience.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59b3b161-b559-f90b-1566-f18776a5f7da
Version Independent ID: 3e536234-16ad-2ed3-fb58-c128ba2faab2
Content: Quickstart: Building your first static site with the Azure Static Web Apps
Content Source: articles/static-web-apps/getting-started.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@jennyxchengsea Thank you for your feedback, our team will review it and get back to you at the earliest.


Add option to review the connector properties

Either a next step, or modal dialogue with a table to review all those options which have been entered.

Right, my takeaway from the discussion was to add a modal dialog on the last page.  Since the last 3 steps of the wizard are optional, we might want to consider putting it on the earlier steps as well...

Ah yes, good point. That makes sense probably.

After discussion with UX, added a final Review page (very simple for now).  Also, the 3 optional property steps were re-organized to be sub-steps.  Pending PR #167

PR merged - closing


Evaluate a migration to different framework

I want to evaluate a switch to one of these frameworks:

echo
iris

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38034492-evaluate-a-migration-to-different-framework?utm_campaign=plugin&utm_content=tracker%2F32209314&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F32209314&utm_medium=issues&utm_source=github).

Since I'm also part of the Gin maintainers team I will stick with it!


Installation of Google colab

How I can permanently install greykite on google colab?

Hi,
We have not tried Google Colabs in this context. That is probably a question for Google Colab team about the possibility to add a python library to Colab permanently etc.
Thanks
Reza

Follow this set of instructions. Should allow for a permanent install
https://ayoolafelix.hashnode.dev/how-to-permanently-install-a-module-on-google-colab-ckixqrvs40su044s187y274tc


Add NNXToLinen wrapper to nnx.bridge

Introducing the NNXToLinen wrapper, turning an NNX module into Linen.

Supports RNG overrides on apply() calls
Converts NNX variable types into different collections, and avoid collection inheritance issue (subclasses of another Variable class are handled correctly)
Supports mutable argument - since Linen is stateless by default, this flag is needed if you rely on the statefulness of NNX module
State structure is close to that of the original

Feature also requested in #4088.

Codecov Report
Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (31adb00) to head (ce854b1).
Report is 122 commits behind head on main.

Files
Patch %
Lines

flax/nnx/nnx/bridge/wrappers.py
0.00%
35 Missing :warning:

flax/nnx/nnx/variables.py
0.00%
20 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4126    +/-   ##
======================================
  Coverage   0.00%   0.00%
======================================
  Files        106     109     +3
  Lines      13582   14263   +681
======================================
- Misses     13582   14263   +681

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks Ivy! Looks good, left some comments.


Fix incorrect separators and introduce assert_output_matches()

#1006

Codecov Report

Merging #1027 (284093e) into master (795627f) will increase coverage by 0.19%.
The diff coverage is 99.01%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   95.35%   95.54%   +0.19%
==========================================
  Files          57       61       +4
  Lines        3766     3931     +165
==========================================
+ Hits         3591     3756     +165
  Misses        175      175

Impacted Files
Coverage Δ

tests/utils/__init__.py
88.60% <85.71%> (ø)

httpie/core.py
92.19% <100.00%> (+0.22%)
:arrow_up:

httpie/output/writer.py
75.43% <100.00%> (+0.89%)
:arrow_up:

tests/test_regressions.py
100.00% <100.00%> (+11.76%)
:arrow_up:

tests/test_tokens.py
100.00% <100.00%> (ø)

tests/utils/matching/__init__.py
100.00% <100.00%> (ø)

tests/utils/matching/parsing.py
100.00% <100.00%> (ø)

tests/utils/matching/test_matching.py
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795627f...284093e. Read the comment docs.

Codecov Report

Merging #1027 (284093e) into master (795627f) will increase coverage by 0.19%.
The diff coverage is 99.01%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   95.35%   95.54%   +0.19%
==========================================
  Files          57       61       +4
  Lines        3766     3931     +165
==========================================
+ Hits         3591     3756     +165
  Misses        175      175

Impacted Files
Coverage Δ

tests/utils/__init__.py
88.60% <85.71%> (ø)

httpie/core.py
92.19% <100.00%> (+0.22%)
:arrow_up:

httpie/output/writer.py
75.43% <100.00%> (+0.89%)
:arrow_up:

tests/test_regressions.py
100.00% <100.00%> (+11.76%)
:arrow_up:

tests/test_tokens.py
100.00% <100.00%> (ø)

tests/utils/matching/__init__.py
100.00% <100.00%> (ø)

tests/utils/matching/parsing.py
100.00% <100.00%> (ø)

tests/utils/matching/test_matching.py
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795627f...284093e. Read the comment docs.


Readme code doesn't work: "xenserver_vdi.vdi: Unable to parse XenAPI response"

The readme example code fails for me:
provider "xenserver" {
    url = "${var.xenserver_url}"
    username = "${var.xenserver_username}"
    password = "${var.xenserver_password}"
}

resource "xenserver_vdi" "vdi" {
  sr_uuid = "<my_sr_uuid>"
  name_label = "test vdi"
  size =<PHONE_NUMBER> # 1GB
}

resource "xenserver_network" "net" {
  name_label = "vm only network"
  bridge = "xapi1"
  description = "this will create VM-only network"
}

resource "xenserver_vm" "web" {
    name_label = "web"
    base_template_name = "<my_template_name>"
    static_mem_min =<PHONE_NUMBER> # 2GB
    static_mem_max =<PHONE_NUMBER>
    dynamic_mem_min =<PHONE_NUMBER>
    dynamic_mem_max =<PHONE_NUMBER>
    boot_order = "cdn"
    network_interface {
        network_uuid = "${xenserver_network.net.id}
        mac = "12:34:45:67:89:12"
        mtu = 1500
        device = 0
    }
    vcpus = 2
    cdrom {
      vdi_uuid = "<my_iso_uuid>"
    }
    hard_drive {
      vdi_uuid = "${xenserver_vdi.vdi.id}"
    }
}

I assumed that the two network_interfaces defined in the xenserver_vm block was unintentional.  I'm running XenServer v7.1
Error is:

Error applying plan:
1 error(s) occurred:

xenserver_vdi.vdi: 1 error(s) occurred:

xenserver_vdi.vdi: Unable to parse XenAPI response: got value "vdi_mirror" for enum StorageOperations at SR.get_record -> .allowed_operations[9], but this is not any of the known values

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

Hi,
XenServer 7.2 introduced new possible StorageOperations. Fix is submitted to ringods/go-xen-api-client#6

I tried updated to the latest master with https://github.com/ringods/terraform-provider-xenserver/pull/14 merged in, but this seems to still be happening. I did have the previous version installed, is there something I'm missing?

@ajagnanan can you show output of terraform with TF_LOG=DEBUG?

Thanks for that option, it was locked to the previous version still. Works now 👍

@ajagnanan then I'm going to close this issue. If you encounter other problems, please file a new issue.


No auto-completion provided when using overloaded __new__ definitions

Environment data

Language Server version: 2024.2.3
OS and version: Ubuntu 22
Python version (& distribution if applicable, e.g. Anaconda): 3.10

Issue
The following works fine with auto-completion:
class A:
    def __new__(cls, a: int) -> Self: ...

But no suggestion is provided when using overloads:
class A:
    @overload
    def __new__(cls, a: int) -> Self: ...

    @overload
    def __new__(cls, a: str) -> Self: ...

Opening this as a Pylance issue as it works with other pyright LSP implementations (e.g. sublime-lsp).

looks like a bug. normal method include __init__ overload work as expected.

I'll add that hovering on A() actually shows the overloads:

No longer an issue in the latest version(s).


Improve display of target labels on status page.

Instead of a "{...}"-style list, show key/value pairs as Bootstrap
labels.

Sweet :+1:

:+1:


カバレッジ測定ツールの導入

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@226f0bf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   99.61%
=======================================
  Files           ?       10
  Lines           ?      517
  Branches        ?       17
=======================================
  Hits            ?      515
  Misses          ?        1
  Partials        ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226f0bf...c2aa30b. Read the comment docs.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3730

Questions ?
Please refer to the Backport tool documentation


Support drafts 4/6/7 ?

Improve documentation
Describe the problem
How to specify draft version ? Is draft supported ?
I got an error when submit a form with format time
Format time is supported in draft v7 and also in crate jsonschema v0.17.1 (in used currently by pg_jsonschema)
Describe the improvement
Add options to support drafts 4,6,7 in lib.rs

My bad everyone. The culprit is my time picker component that use time format without timezone.
20:20:39+00:00 👌
20:20:39 👎


Problems with the processing of the rename instruction in the MRGT

When using the MRGT on the tev2-specifications repo the result is this:

When generating mrg.tev2.documentation.yaml, the first instruction selects the term action from the essif-lab scope.
Then, the subsequent rename instruction tells it to rename the term, modifying fields id and term to become act, and modifying the formphrases field to become act{ss}.
However, when I check the resulting mrg-file, I cannot find an entry for the renamed thing.
Note that the following termselection instruction again imports action from essif-lab. This should not overwrite the (renamed) act entry, but seems to do so.

The check for duplicates, which determines if an entry overwrites another entry within a provisional MRG, currently happens according to the termid property of an entry. I believe this issue stems from that, because the rename action doesn't alter the termid. I suppose this could be remedied by re-triggering the termid creation after a rename of the term or termType.

yes, please!

@Ca5e : This is (still) not fixed.
The SAF says this:

The log I just generated says this:

I didn't expect to see (line 61) that a term got overwritten. And if the rename instruction worked, then indeed the mrg-entry 'action' got overwritten.

I hadn't published the newest versions yet. I have just done so, the rerun on tev2-specifications seems to have fixed this.


Push canonical to hub

This PR sets up a workflow to push all modules to the hub:

make metrics spaces-ready:

add metadata to README.md
add app.py
add requirements.txt

setup action to push evaluation modules to the hub on merge to main

Closes #24.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Great! Looking forward to seeing all of these on the Hub :hugs: :rocket:


Update Docs

Moved a lot of stuff out of the README and into the "docs/" folder.
Want to clearly communicate the idea of "running openpilot in a car" and "running openpilot on a pc"

Very nice.  I love the clean reorganization. :+1:


Hi, Zep team, there is a scenario for discussion

hi, Zep team:
Thanks for the project!
Here is the scenario:
I am building an AI assistant APP, AI will be told something in the conversation.
Currently, the session_id is a must for query, but for my case, I need to query all the related chat history.
For example, the user could told AI something in one conversation, and need to extract memory in another conversation.
Is there a way to do this or is it in the future plan?
Thanks.

session_id is analogous to a user ID. You should associate the session_id with your user and use it in subsequent conversations.


Create update-devel

This example script is based on aur-sync changes proposed in #283.
It is a simple reuse of aurutils components, similar to the examples in aur(1). As such it is part of a new examples directory. This directory could include other scripts such as aur-remove (#305) and aur-gc (#317).
To use a script from the examples directory, it may be either copied to or symlinked in a directory in PATH. A symlink should be preferable unless local changes to the file are prefered.
$ cp -s /usr/share/aurutils/examples/aur-update-devel /usr/local/bin
$ aur update-devel

I have an idea, with this script I would need to run update twice (first aur sync -u, then aur update-devel), should we maybe make this script update everything? Or rename to update and have a --devel flag? What do you think?

I thought it was simpler to run aur sync -u instead of adding a flag:  64955449d12313b4987289632738f55f3ff1c1af

The Makefile should also be updated

I wanted to avoid two calls to aur sync, so that I can review everything once, and then let it proceed...

I'm also getting some weird jq parsing errors:
jq: error: syntax error, unexpected INVALID_CHARACTER (Unix shell quoting issues?) at <top-level>, line 1:
.[] | [.pkgname, .pkgver] | @ tsv
jq: 1 compile error

Yeah, aur-sync --upgrades --no-ver should suffice. You just won't get pretty-printed versions.
Regarding jq, I feel about that software like some people feel about tar. I guess there's a very slight benefit in having aur sync --list output to JSON because repo names can contain arbitrary characters, but meh.

I've thought on adding $@, yeah

Hm, the question is whether to add "$@" to aur-sync --list as well, e.g. to specify --repo. I guess something like aur sync --list -sc --provides would be the same as aur sync --list...

Yeah, I guess it's safe - I checked and aur sync --list -sc --provides works fine, and --list is always the first action that is being executed, so it should be safe to add "$@" to both places.

Done. Left a code comment just in case


valid_certificate?: use OpenSSL::X509::Store for checking certificates

Instead of OpenSSL::X509::Certificate, as Store allows for validation
against CA bundle, which is required when you roll new CA certificate.
I am not sure if this is wanted behaviour, but it seems to work when you have multiple certificates in ca.pem file.

Neat. Mind opening a ticket for this etc as per the contribution guides?

Neat. Mind opening a ticket for this etc as per the contribution guides?

Done. Sorry, I rushed a little bit with a PR :)

thank you!


Add 10.0.x to tests

Adds a 10.0.x test run.

🙌
Lock file operations: 0 installs, 5 updates, 2 removals
  - Removing behat/mink-goutte-driver (v1.3.0)
  - Removing fabpot/goutte (v3.3.1)
  - Upgrading drupal/core (9.3.0-rc1 => 10.0.x-dev 6fbde48)
  - Upgrading drupal/core-dev (9.2.10 => 10.0.x-dev 8702058)
  - Upgrading drupal/core-recommended (9.3.0-rc1 => 10.0.x-dev fbc41dd)
  - Upgrading symfony/mime (v5.4.0-RC1 => v5.4.0)
  - Upgrading symfony/var-dumper (v5.4.0-RC1 => v5.4.0)


Add termux support please

Feature Description
https://stackoverflow.com/q/38959067/7361270
Solution you would like
https://stackoverflow.com/q/38959067/7361270
Alternatives you have considered
NA
Additional context
NA

Hi!
Thank you for the solution. There was the exact same problem with termux #57
Unfortunately, I don’t have an android nor vm for it, so I can’t test it. If someone wish to do it, I would appreciate that

@metafates you can use Android IDE

https://developer.android.com/studio/run/managing-avds

https://github.com/termux/termux-packages/pull/9721

OK, I'll try, but not sure when. I'll let you know as soon as there is any progress

Update: I was able to get mangal working under Termux! + I've adapted install script to automatically setup everything to get it working. Expect to see it soon 🐳

Oh yeah

@metafates Please don't use proot see this patch https://github.com/termux/termux-packages/pull/9721

@metafates Please don't use proot see this patch termux/termux-packages#9721

I'll look into it, thanks

okay, so it appears that it needs a specific variation of GO compiler which is very hard to configure with GitHub actions (mangal uses them for automatic release builds). As a workaround, install script will build mangal from source each time, as there aren't any better way to do it. Will be fixes as soon as mangal will be released as a termux package https://github.com/termux/termux-packages/pull/11935


Subdivision of Peer Struct

After reviewing the Peer struct it may be possible to subdivide the Peer struct into smaller structs in order to organize code better and make it easier to read it. We could build different packages like Host, Connections, Messages... This way we could divide corresponding methods into the different structs.
Please let me know what you think about it :)
Maybe this could be a good division?

closing this, as it is solved in #52 -> even though the new version only supports the ethereum cl network, the crawler is modular enough to make it compatible with other networks


Added Docker Support for PolarDNS

Created a Dockerfile to containerize the PolarDNS application.
Updated documentation for Docker build and run instructions.

Building and Running PolarDNS Docker Image
To build the Docker image for PolarDNS:
docker build -t polar_dns .

To run the PolarDNS container:
docker run -d --name polar_dns_container -p 53:53/tcp -p 53:53/udp polar_dns

Thank you @redoracle and @stakelovelace !


State of C++ translation?

I see the website says

You’ll see a lot of C++ code get generated, but it’s only partially baked at this point, so don’t expect it to work.

so maybe I'm trying this too early. I build a "hello world" app from Java to C++, then tried to compile that using clang, but I get errors in the support headers,
clang: warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated
In file included from hello.h:4:
In file included from ../juniversal/cpp-archive/cpplib/src/juniversal.h:7:
../juniversal/cpp-archive/cpplib/src/juniversal_defs.h:28:33: error: reinterpret_cast from 'char' to 'unsigned char' is not allowed
        return reinterpret_cast<char>( reinterpret_cast<unsigned char>(value) >> bits );
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../juniversal/cpp-archive/cpplib/src/juniversal_defs.h:32:34: error: reinterpret_cast from 'short' to 'unsigned short' is not allowed
        return reinterpret_cast<short>( reinterpret_cast<unsigned short>(value) >> bits );
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../juniversal/cpp-archive/cpplib/src/juniversal_defs.h:36:32: error: reinterpret_cast from 'int' to 'unsigned int' is not allowed
        return reinterpret_cast<int>( reinterpret_cast<unsigned int>(value) >> bits );
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../juniversal/cpp-archive/cpplib/src/juniversal_defs.h:40:35: error: reinterpret_cast from 'long64' (aka 'long long') to 'ulong64' (aka 'unsigned long long') is not allowed
        return reinterpret_cast<long64>( reinterpret_cast<ulong64>(value) >> bits );
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Turning those into static casts, it gets past those and into some other errors. (I see the same error on gcc, so it doesn't look like a clang bug.)
I can submit a pull request with those fixes, if that would be helpful?
Overall, what is the state of C++ support? Is it too early to test and file bugs/submit pull requests?

Yeah, it's still kind of early to try the C++ support.  No need to submit a pull request here--I'll fix it up.


Feedback goes here

Suggestions?

From @dbox: Add simpler real-world examples to the README.

Self: Consider adding a param to automate grid creation instead of depending on a preprocessor loop for this functionality. Could also be a separate postcss plugin, but bleh.

@kfrost89 wants docs to be more clear about gutter needing to be synced with margin-right.

Add in the ability to do markup-based grids as well. Will probably need a 3rd param to ant() like markup-based or something.
This will allow for masonry friendly grids.


Partitions by value in web console

Just a quick feature suggestion:
It could be useful if the partitions which are shown in the tables view of the admin web console showed the value of the partition. For example instead of the Ident string '043j2d1g6go3g' which is used internally by Crate if it displayed the value of that partition (and be able to sort by value/ident) that would be useful.
At the moment I have a good idea of which a partition is because you can already sort by Ident but it's not particularly easy to identify a partition in the middle of the table where you have a partition for each day in time series data.
Other than this suggestion I just want to say that it's really great to see the visibility of each partition as it allows you to see the data growth per day for a particular table (if partitioned by day of course).
Thanks,
Alex

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3936015-partitions-by-value-in-web-console?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github).

this feature is being implemented since version 0.50.0
see: https://github.com/crate/crate/blob/master/CHANGES.txt#L479-L480


Cutting a Signal in a range of samples

Hello, I have a signal (edf format) of 503700 samples and I want to cut that signal in order to obtain just a portion of it from sample 600 to sample 501000. How can I do this in python?

This appears to be a question about usage, not a bug report or a new feature request. Please use the MNE mailing list or the gitter channel for usage questions.


QR code address.

QR code address.
https://github.com/soldair/node-qrcode
https://larsjung.de/kjua/

commit: https://github.com/sc0Vu/vuethexplore/commit/5b409b31762dcab44f9ad79b04a8eba268ba20eb
issue: https://github.com/soldair/node-qrcode/issues/123


Remove entry-point call and add chalice call test

Close #1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


HARVESTER: fix harvester version prerelease compare

Summary
Fixes #

https://github.com/harvester/harvester/issues/3506

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Hi, @mantis-toboggan-md. There have a PR that needs you to review, Thx! cc @richard-cox


Add url attribute to Identifier interface in BioSimulators API

This needs to be added to fix the citations -- related to #1299

The current data model is actually fine for citations.

Articles with DOIs or ISBNs can use namespace: {'doi' | 'isbn'}, id: {doi}. The code can compute a URL.
Articles with PubMed ids can use namespace: pubmed, id: {pubmed-id}. The URL can be resolved with identifiers.org
Articles without DOIs or PubMed ids can use namespace: url, id: {url}

In general, it would be good to separate the id attribute from the url attribute. This will allow us to keep track of identifiers in namespaces that we don't know how to resolve URLs for, and store their URLs.

Could you clarify what the needed change is?  Is this just a database update?

Its not clear which classes define the data model for the API. It looks like a url attribute is missing from this Identifier interface
biosimulations/libs/shared/datamodel/src/lib/common/ontology.ts. It look like a url attribute needs to be added here.
I have added url fields to the properties.json files in the simulator repos for citations which don't have DOIs (e.g., books, journals which don't register DOIs, white papers that can only be referenced with URLs).

url attribute still needs to be added to the Identifier interface

url attribute still needs to be added to the Identifier interface.
api.biosimulators.org shows
Identifier{
  namespace*	string
  id*	string
}

url is missing.

This looks to be done.


Feat(errors): Add control if the errors are displayed

@martndemus I run into a problem with ember-cp-validations showing the errors before any user interactions. I looked at the example code and figured that you have to control the display of errors by yourself.
This PR enables to do so. It is backwards compatible but allows to overwrite showErrors.
An example would be:
// app/components/form-field.js
import FormField from 'ember-form-for/components/form-field';

const {
  computed: {
    and,
    notEmpty,
    or
  }
} = Ember;

export default FormField.extend({
  hasContent: notEmpty('value').readOnly(),
  shouldDisplayValidations: or(
    'showValidations',
    'object.didValidate',
    'hasContent'
  ).readOnly(),

  showErrors: and('hasErrors', 'shouldDisplayValidations'),

  focusOut() {
    this._super(...arguments);
    this.set('showValidations', true);
  }
});

If you like the idea I'll add a section to the readme to explain it and add this example for ember-cp-validations.
/cc @offirgolan

Haha CI says it's not backwards compatible. I'll have a look.

I updated the example to fully cover ember-cp-validations example.

The PR would resolve #122 only that it doesn't bypasses the update and instead hides the error messages.

I run into a problem with ember-cp-validations showing the errors before any user interactions.

Clearly this is a bug in ember-cp-validations. This fix would be a hack around a bug, that it isn't causing itself. If you don't want to display errors, the object passed to form-for should not contain errors.

I consider it a bug in ember-cp-validations as well but I don't think that the ability to control whether the errors are displayed or not is a hack.
In the end the PR is just a cleanup of the templates and introduces a new property. Let me know what your concerns are to merge this.

Clearly this is a bug in ember-cp-validations

I dont believe this to be a bug. All validations are CP dependent meaning they are lazy by nature. The only time a validator will be executed is if there is something observing the validation CP. Just because a property is invalid, doesnt mean you should be displaying that error message.
Other libraries including the demo app use the focusOut event to trigger when to actually show the validations. The issue of when/how to display an error message lies in the land of UX and is not something that is nor will be supported by the library. Ember-cp-validations simply provides everything you need to make that task much easier 😄.

As I have just recently discussed this issue with @fsmanuel at our local meetup let me also jump into this briefly...
As e-cp-v is not restricted to be used with forms (could as well be just used to validate a model before saving), it should not contain any logic regarding the use of forms. After all when being asked if an empty model which has some required fields (presence validator) is valid, the only correct answer of any validations library would be no! But that does not mean the form should display that error immediately. That should only happen when it is clear that the user has finished entering his data (like when focusing out or submitting the form). So when to show errors should be a concern of the form, not the validation library.
You can see this very logic baked into the form components of ember-bootstrap (e.g. here https://github.com/kaliber5/ember-bootstrap/blob/master/addon/components/bs-form-element.js#L621-L623), where me and @offirgolan have worked together to make the form components be agnostic of the actual validation library, but still support this use case as described above out of the box...

:umbrella: The latest upstream changes (presumably f33f1dd) made this pull request unmergeable. Please resolve the merge conflicts.

What's the hold up here?

I have the following experience with cp-validations:

The same problem exists in ember-changeset-validations as well.

@martndemus I merged master. Are you still against the changes?

@martndemus if we can change the classNameBindings from hasErrors to showErrors I can move the code into a mixin and add documentation how to use it with ember-cp-validations. Does that sound good?


Docker build stucks at "Sending build context to Docker daemon 556.1kb"

This bug-tracker is monitored by developers and other technical types.  We like detail!  So please use this form and tell us, concisely but precisely, what's up.  Please fill out ALL THE FIELDS!
If you have a feature request, please post to the UserVoice.  If you're reporting a BSOD, don't post here!  Instead, e-mail<EMAIL_ADDRESS>and if possible attach the minidump from "C:\Windows\minidump".

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.14393]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)
``` docker build -f .docker/client.dev.dockerfile . ````

What's wrong / what should be happening instead:
It stucks at "Sending build context to Docker daemon 556.1kb" all the time.

Strace of the failing command, if applicable:  (If <cmd> is failing, then run strace -o strace.txt -ff <cmd>, and post the strace.txt output here)
Somehow when I try
 strace -o strace.txt -ff docker build -f .docker/client.dev.dockerfile .
it starts to build correctly after spitting out "ERRO[0001] Can't add file /home/xxx/xxxx/xxxxx/trace.txt.311 to tar: archive/tar: write too long"

See our contributing instructions for assistance.
What is happening?

@JasonShin - Thanks for your post. This looks like #610, #616 et. al. Your are running Anniversary Update (build 14393). There have been significant improvements since and these issues should be fixed in Creators Update. Updating to that should resolve your issues. Let us know if it doesn't.

I am closing this out. If this repro's for you in Creators Update, please comment and we can reopen.

hey, how do I get creators update and how do you check if I am already on it?

@JasonShin - https://support.microsoft.com/en-us/help/4028685/windows-get-the-windows-10-creators-update

Cheers, thanks


Copy matching type-specific fields

This is part of work to convert any format to any format in publisher.
Until now, type-specific fields were copied into the whole_body. Now,
if the target class has the same type-specific field, it will be
copied over.
Trello

Just my teeny stylistic comment. Looks good otherwise.


Increase wait times and parallel runs

Increase training job wait time from 15 mins to 30 mins
Increase processing job wait time from 15 mins to 30 mins
Increase parallel runs from 10 to 15

/approve

/lgtm


Use ruby 2.3 syntax and clean some stuff.

Coverage increased (+0.07%) to 83.706% when pulling 06dff1a2fb6133f0b0bf40d6f27a581e197ec804 on fwininger:ruby_2.3 into 188ee0b1af905160b70790a21da0f4df3b68c2a2 on Cyberwatch:master.

Coverage increased (+0.002%) to 83.636% when pulling af729317e7fe473dead7f33153322975343ef694 on fwininger:ruby_2.3 into 188ee0b1af905160b70790a21da0f4df3b68c2a2 on Cyberwatch:master.

Coverage increased (+0.002%) to 83.636% when pulling af729317e7fe473dead7f33153322975343ef694 on fwininger:ruby_2.3 into 188ee0b1af905160b70790a21da0f4df3b68c2a2 on Cyberwatch:master.


No preview on Github links

If link to a github page, no preview.
Anyone knows why?
Thank you!

it is because of the
https:// protocol?


Query of type "whereKey matchesKey inQuery" returns 'improper usage of $select' error

Hi.
I've been using a query in a iOS app, that worked fine with parse hosted services,
but after trying with a local parse server it returns the error improper usage of $select error.
For NDA reasons, I had to change the names of the classes, attributes, tokens and keys in this ticket.
This is the query I'm using:
override func queryForTable() -> PFQuery {
    let query = PFQuery(className: "C1");
    let auxQuery = PFQuery(className: "C1");
    query.whereKey("A1", matchesKey: "A2", inQuery: auxQuery);
    query.includeKey("A3");
    query.includeKey("A2");
    query.orderByDescending("createdAt");

    return query;
}

A1 and A2 are pointers to objects of the same type. I tried the same query with simple types,
but the error still happens. If I comment the whereKey line, the query works perfectly and I get my results.
I ran the parse server with VERBOSE=1 and this is what I got:
GET /parse/classes/C1 { host: 'localhost:1337',
  'x-parse-client-version': 'i1.12.0',
  accept: '*/*',
  'x-parse-session-token': 'a-valid-session-token',
  'x-parse-application-id': 'my-application-id',
  'x-parse-client-key': 'my-client-key',
  'x-parse-installation-id': 'my-installation-id',
  'x-parse-os-version': '9.2 (15D21)',
  'accept-language': 'en-us',
  'accept-encoding': 'gzip, deflate',
  'content-type': 'application/json; charset=utf-8',
  'content-length': '169',
  'user-agent': 'projname/1 CFNetwork/758.2.8 Darwin/15.3.0',
  connection: 'keep-alive',
  'x-parse-app-build-version': '1',
  'x-parse-app-display-version': '1.0' } {
  "where": {
    "A1": {
      "$select": {
        "query": {
          "className": "C1"
        },
        "key": "A2"
      }
    }
  },
  "include": "A3,A2",
  "order": "-createdAt",
  "limit": "3"
}
error: ParseError { code: 102, message: 'improper usage of $select' }

After this, I tried running the queries manually with curl requests. I tried querying
my local parse server and the hosted service. This is the result:
> curl -X GET -H "X-Parse-Application-Id: my-application-id"  -H "X-Parse-REST-API-Key: my-rest-api-key"  -G  --data-urlencode 'where={"A1": {"$select": {"query": {"className": "C1"},"key": "A2"}}}' --data-urlencode 'include=A3,A2'  --data-urlencode 'limit=3' --data-urlencode 'order=-createdAt'  http://localhost:1337/parse/classes/C1
{"code":102,"error":"improper usage of $select"}

> curl -X GET -H "X-Parse-Application-Id: my-application-id"  -H "X-Parse-REST-API-Key: my-rest-api-key"  -G  --data-urlencode 'where={"A1": {"$select": {"query": {"className": "C1"},"key": "A2"}}}' --data-urlencode 'include=A3,A2'  --data-urlencode 'limit=3' --data-urlencode 'order=-createdAt'  https://api.parse.com/1/classes/C1
{"results":[{"createdAt":"2016-02-10T22:36:04.828Z","A4":10,"objectId":"sgFcN9g3d5", ...]}}

(This last result is cut short, again to avoid NDA issues, but it's the right result.)
Do you have any idea of what is wrong here?
Thanks in advance.

This definitely looks like a bug, sorry for the late review... Any chance you can confirm this still occurs with 2.1.3 @haparicio ?

Just updated and confirmed that it is still happening. If I can provide any further data that may help you, please let me know.

hi @haparicio is it still occurring with the master branch?

I was using your parse-server-example to test this, which, from what I saw, already points to the 2.1.3 version of parse-server. I just cloned the parse-server master branch, and ran it as a standalone parse server, pointing to my migrated database.
The problem still seems to be happening. I tried the problematic query, which still returns the same error, and I tried a simpler query (without a where clause), just to make sure I get a result, and it worked fine.
Again, if I can provide any further information, please let me know.

hey @haparicio
I just ran that query:
var query = new Parse.Query("C1");
    var auxQuery = new Parse.Query("C2");
    query.matchesKeyInQuery("A1", "A2", auxQuery);
    query.include("A3");
    query.include("A2");
    query.find().then((result) => {
      done();
    }, (err) => {
      console.error(err);
      done();
    })```

that translated to:
```
{
    "A1": {
        "$select": {
            "key": "A2",
            "query": {
                "where": {},
                "className": "C2"
            }
        }
    }
}

and it seems to be fine (running master)

Your code translates into a different query than the one I mentioned in my original post. I tried your query with curl, and it does seem to be working. However, my swift code (that uses the objective-c parse lib) still translates to the query that I mentioned in my original post. That query works with hosted parse, but not with local parse.

Can you post the swift code?

The query code is the one I mentioned in the original post:
    override func queryForTable() -> PFQuery {
        print("Querying");
        let query = PFQuery(className: "C1");
        let auxQuery = PFQuery(className: "C1");
        query.whereKey("A1", matchesKey: "A2", inQuery: auxQuery);
        query.includeKey("A3");
        query.includeKey("A2");
        query.orderByDescending("createdAt");

        return query;
    }

Other than this, I can add the functions that are required by the PFQueryTableViewController:
    func configureTable() {
        // Configure the PFQueryTableView
        self.parseClassName = "C1";

        self.textKey = "createdAt";
        self.pullToRefreshEnabled = true;
        self.paginationEnabled = true;
        self.objectsPerPage = 3;
    }

    override func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath, object: PFObject?) -> PFTableViewCell? {

        var cell = tableView.dequeueReusableCellWithIdentifier("MyCell") as? ParseCell;
        if(cell == nil) {
            let nib = NSBundle.mainBundle().loadNibNamed("MyCell", owner: self, options: nil)
            cell = nib.first as? ParseCell
        }

        cell?.setupCell(indexPath.row, parseObject: object)

        return cell;
    }

The function setupCell just sets the values of the items in my PFTableViewCell.
I also have a query that counts some items:
    func fillC1ItemCount(parseObject: PFObject?) {
        let query = PFQuery(className: "C1");
        let A2Obj = parseObject!["A2"] as! PFObject;
        let C2Obj = parseObject!["A3"] as! PFObject;

        query.whereKey("A3", equalTo: C2Obj);
        query.whereKey("A2", notEqualTo: A2Obj);
        query.countObjectsInBackgroundWithBlock { (count: Int32, error: NSError?) -> Void in
            if(error == nil) {
                // Make sure it's still the same object (user might have scrolled)
                if(parseObject?.objectId != self.cellObjectId) {
                    return;
                }
                self.C1ItemCount.text = String(count);
            }
            else {
                print("Error counting C1 Items: \(error)");
            }
        }
    }

This query runs after the first query I mentioned, and when the problem occurs, I'm almost sure we don't even reach it, so I think it's not relevant. Just posting it here in case I'm wrong.
Is there any other code that you think could be relevant?

so this :
// JS code
var query = new Parse.Query("C1");
var auxQuery = new Parse.Query("C1");
query.matchesKeyInQuery("A1", "A2", auxQuery);
query.include("A3");
query.include("A2");```

is the exact equivalent of your code.

What version of parse-server are you using?

I'm using a freshly cloned parse-server from the master branch, which is 2.1.3. I also used your parse-server-example which points to the 2.1.3 version. Both have the same result.
The fact that your JS code is equivalent to my swift code, and they translate to different queries, seems to indicate that the objective-c library is doing the wrong translation, and the problem is not in the parse-server. But the strange thing is that the same query that returns the improper usage of $selecterror with the local parse-server, does work with the hosted parse.
I'm not very comfortable with this query language, so I'm not sure if your translation result is supposed to be the same as my translation result, but if it is, I would say the bug (if it's actually a bug) only happens with my translation result.

what point do you see is different? the where clause look the same

With just the where clause, my query translates into this:
  "where": {
    "A1": {
      "$select": {
        "query": {
          "className": "C1"
        },
        "key": "A2"
      }
    }
  }

While yours, from what you said, translates into this:
"where": {
    "A1": {
        "$select": {
            "key": "A2",
            "query": {
                "where": {},
                "className": "C1"
            }
        }
    }
}

They're exactly the same except for that "where": {} inside the querypart. As i said, this query works for me, but if I just remove this "where": {} part, it returns the error.
Again, I don't know much about this query language, so I'm not sure if that "where": {} part being there or not is the same thing.

Oh alright! Thanks for the troubleshooting! I belive this has an error because parse-server interprets the missing where as an error :)

Glad to help.  :)
If I can help anymore, please let me know.

Just had to remove 1 line :)

Those are the best fixes.  :)
Thanks for everything!


MWPW-147267: Mini Compare Chart Card UX Feedback

Changes the condition in merch card slots, so that when there is no content for the slot, we do not insert empty  tags.
Resolves: MWPW-147267
Test URLs:

Before: https://www.stage.adobe.com/acrobat/features.html
After: https://mwpw-147267-space-under-the-price--milo--mirafedas.hlx.page/drafts/mirafedas/mini-compare-charts/3-cards?martech=off

@mirafedas @yesil I still see the same gap between the price and CTAs as it was before on the 'after' link.

I have synced with @yesil, might be other slots are also causing the issue? (highlighted offers one?)

@Axelcureno thank you for looking into this.
The pages you compare are not quite right, because my code has not been merged to the stage branch yet, so the page you check does not contain my changes, I mean this one: https://stage--milo--mirafedas.hlx.page/drafts/mirafedas/mini-compare-charts/3-cards?martech=off .
This PR goes in combination with the PR for tacocat:
https://git.corp.adobe.com/wcms/tacocat.js/pull/596/files
Basically what I want to achieve is:
When the merch card variation is mini-compare-chart, and there is no content for the slot, we should not append a slot with an empty <p> tag inside, because it creates a space. And in the tacocat PR I removed the bottom margin for the price, leaving only 16px top padding in the footer, to make sure the distance between the price and the footer is 16px (as required on the XD).
The CTA alignment on page that contains my changes look good both on desktop and on smaller screens:
https://mwpw-147267-space-under-the-price--milo--mirafedas.hlx.page/drafts/mirafedas/mini-compare-charts/3-cards?martech=off
(I'm sure you know it, but just a reminder that after every screen resize there's a need to reload the page, otherwise alignment gets off).
We can huddle on this if needed, please let me know.

There is a use case where one or more cards have a slot and another one doesn't. Have we tested this use case? We need to ensure alignment doesn't break in this scenario

@Axelcureno I added quantity selector and promo text to one of the cards, alignment works ok:
https://mwpw-147267-space-under-the-price--milo--mirafedas.hlx.page/drafts/mirafedas/mini-compare-charts/3-cards?martech=off

@Axelcureno I added quantity selector and promo text to one of the cards, alignment works ok: https://mwpw-147267-space-under-the-price--milo--mirafedas.hlx.page/drafts/mirafedas/mini-compare-charts/3-cards?martech=off

Thank you @mirafedas !! :D

Nala failures are not related to the PR changes. Video block tests are failing on all PRs from forks due to additional console error coming from the martech.