extraStructuredConfig seems to be ignored when using linuxManualConfig

Describe the bug
Defining kernelPatches in linuxManualConfig applies the patch but not extraStructuredConfig nor extraConfig
Steps To Reproduce
Steps to reproduce the behavior:
config:
custom = let
    baseKernel = pkgs.linux;
    suffix = "-bore";
  in (pkgs.linuxManualConfig {
    inherit (baseKernel) src;
    modDirVersion = "${baseKernel.modDirVersion}${suffix}";
    version = "${baseKernel.version}${suffix}";
    allowImportFromDerivation = true;

    # generated using modprobed-db and
    # make LSMOD=$HOME/.config/modprobed.db localmodconfig
    configfile = ./config;

    kernelPatches = [
      {
        name = "BORE CPU scheduler";
        patch = pkgs.fetchurl {
          url =
            "https://raw.githubusercontent.com"
            + "/firelzrd/bore-scheduler"
            + "/main/patches/stable"
            + "/linux-6.6-bore/0001-linux6.6.y-bore5.1.0.patch";
          hash = "sha256-iLydPGZZSkEQhSj6Ah0Xq0zf7YUPwcpyKt8t0BeHYz8=";
        };
      }
      {
        name = "Native CPU optimizations";
        patch = pkgs.fetchurl {
          url =
            "https://raw.githubusercontent.com"
            + "/graysky2/kernel_compiler_patch"
            + "/master/more-uarches-for-kernel-6.1.79-6.8-rc3.patch";
          hash = "sha256-Gjglt5BBPQmAbJohFfZ5vijkNM/MacAdwGm2NNHoAHo=";
        };
        extraStructuredConfig = with lib.kernel; {
          GENERIC_CPU = mkForce no;
          MZEN3 = mkForce yes;
        };
      }
    ];
  });

steps:

build and reboot
cat /proc/config.gz | zgrep MZEN3 outputs CONFIG_MZEN3 is not set

Expected behavior
Output should be: CONFIG_MZEN3=y
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.28-bore, NixOS, 24.05 (Uakari), 24.05.20240425.7bb2ccd`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/370qy3d3wg9zhbn5a3dcv6k1q1iigfh4-source`

Add a :+1: reaction to issues you find important.

Temporal workaround:
configfile =
      builtins.toPath
      (builtins.toFile "config" (
        lib.strings.concatLines [
          (builtins.readFile ./config)
          "CONFIG_MZEN3=y"
        ]
      ));

Can confirm this is indeed ignored.

Any updates?


Using float instead of double for FHOG computations

I found that FHOG module mixes doubles and floats in many places. This makes compiler harder to optimize the code. And we do not use more than 4-5 significant digits in float values
I think, we can use float instead of double here. All result HOG features were already float
My measurements (based on my previous PR measurement method):
MSVC 2013, Windows 7, 64bit, i7/2.5Ghz:

Release, x64 /O2 /arch:AVX : 1482 msec - this is master branch, if added AVX
Release, x64 /O2 : 1624 msec - master branch as-is
Release, x64 /O2 (without my recent PR#91 and without /DDLIB_HAVE_SSE2) : 6782 msec (much slower than 2)
Release, x64 /O2 (with PR#91 and without /DDLIB_HAVE_SSE2) : 1624 msec (same as 2)
Release, x64 /O2 (with PR#91 fhog-float branch): 1517 msec (6.6% faster than 2)
Release, x64 /O2 /arch:AVX  (fhog-float branch) : 1256 msec  (15% faster than 1)

GCC 5.2.1 (Ubuntu), x64 (same PC as Windows)

Release, x64, -O3 -mavx : 1227 msec
Release, x64, -O3 -mavx (fhog-float branch) : 1136 msec (8.8% faster than 7)

I tried other samples - they still compile and run well on Windows and Ubuntu

Cool.  Did you run the unit tests for the fhog feature extraction?  It's important that the output fhog features not change by any significant amount since there is a lot of code out there using trained models based on the existing dlib code.  So we need to make sure the outputs are still the same.

I just ran all the tests and it looks like it's all good.  Thanks for the PR :)


Refactor API to be more consistent with other lang-helper libs

I like the idea of helper libs for different languages to ease use of the Platform environment, but now that we have 2 of them I'm think we should strive to keep the APIs as consistent between them all as possible.  The PHP lib has a pretty sensible API, how about rewriting this gem to be more in line with that one?
@config = Platformsh.new

if @config.is_available do
  puts @config.project
  puts @config.application_name
  puts @config.relationships['database'][0]['host']
end

Consistent APIs enable less mental friction when coming to a new tool.  It would also make it easier for polyglot programmers to get around Platform.

Ok, let's go over all three current libs (btw we need to make a python one) and align the API (there is also the NPM one).


Rewrite GET stats_summary from Perl to Golang

What does this PR (Pull Request) do?

[x] This PR fixes #3832

Which Traffic Control components are affected by this PR?

Documentation
Traffic Control Golang Client
Traffic Ops
Traffic Stats

What is the best way to verify this PR?

Run API tests (once added to PR) or pull down and manually test to ensure stats summary matches parity with perl implementation
If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4795/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4851/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4852/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4856/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4858/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4876/

I tried testing this out with ciab but only got an empty response for the call to GET /api/1.4/stats_summary. Since @ocket8888 has done the review, I'll leave it to him to test it as maybe he knows a better way than me.

@mitchell852 yeah the stats_summary is done daily from TS so you would either have to POST to /stats_summary/create or have TS up for a day.

@ocket8888  fixed


Standalone evaluation

Hi,
thanks for sharing the codebase!
Request: do you have standalone evaluation code, that is not part of the PyTorch lightining way of implemeting the evals? I.e., if I  have predictions dumped on file, right now it is quite tedious to get evaluation numbers (f1 etc) for them - the eval code and the modeling code are very tightly combined in your codebase. Do you have any standable evaluation script that can take in dumped predicted parses, match against GT, and give the CORD test evaluation numbers? This will make comparisons with your method much easier.
thank you,
Aruni

Hi @AruniRC
Good point. Unfortunately, not. However, you may use cal_f1_score (see below).
https://github.com/clovaai/spade/blob/a85574ceaa00f1878a23754f283aa66bc2daf082/spade/model/model_utils.py#L694-L699
Wonseok

Hi @whwang299 ,  thanks for the pointer to your code. This is indeed sufficient to use your eval protocol on other methods for apples to apples comparison.


Activation scales for bloomz 7.1b

The article at https://huggingface.co/blog/generative-ai-models-on-intel-cpu mentions that smoothquant was applied on bloomz 7b1 model also. But in https://huggingface.co/mit-han-lab/smoothquant-scales only smoothquant-scales for the 176b model is provided. Please add the smoothquant-scales for the 7b1 model also because many (like me) do not have the resources to run the 176b model

you can usegenerate_act_scales.py to generate scales for bloom-7b1


Use multitaper instead mtspec + Use ARIMA instead ARMA

Hi @gbrookshire
Here a small proposal to adpapt the code :

multitaperinstead of mtspec (no maintened anymore)
statsmodels ARIMA instead of ARMA

Hi Samuel, Thanks for submitting this PR!
Let's migrate these changes over to the more portable repo here: https://github.com/gbrookshire/oscina
That'll make sure that the "simulated_rhythmic_sampling" repo continues to hold the exact code that was used to create all the analyses used in the published paper.
I created a PR in that repo with your code: https://github.com/gbrookshire/oscina/pull/1


don't use runMocha() for what we're using it for

runMocha() in module test/integration/helpers is suited to testing raw reporter output, but unfortunately it's being used in a couple places to check failures, passes, errors, etc.
Use runMochaJSON() instead if we're not testing raw reporter output.

This issue should be closed.

Thanks.


Verify the expanded KG with the new mentions

We need to verify the mentions and QIDs.

This is completed


Make "no resources" error configurable for autoscaling platforms

When I resume a session and there are not enough resources available I immediately get an error in the UI.
That makes sense in our current infra since if the resources aren't there they won't be (at least for a while), however on platforms where autoscaling is enabled (like the AWS PoC I'm carrying out), that's not necessarily true, as some resources might be coming up in a short while.
The error itself does not prevent the session to start in the background, but it might be misleading for a user.
Can we control this time interval before showing an error?

Is there some indication from k8s that a resource is being provisioned to satisfy the (currently unschedulable) request?

Shortly after the pod is scheduled I see this event:
apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2024-04-19T08:05:16Z"
involvedObject:
  apiVersion: v1
  kind: Pod
  name: foo-40bar--an-2daws-2dproject-57f05e85-0
  namespace: renku
  resourceVersion: "21922912"
  uid: 467b94d8-e56a-432c-8ca1-108843aab5ec
kind: Event
lastTimestamp: "2024-04-19T08:05:16Z"
message: 'Pod should schedule on: nodeclaim/core-services-lrkls'
metadata:
  creationTimestamp: "2024-04-19T08:05:16Z"
  name: foo-40bar--an-2daws-2dproject-57f05e85-0.17c79fd3fcc0e889
  namespace: renku
  resourceVersion: "21922946"
  uid: 072773f3-e2b0-4f73-bd9f-4baca5511b66
reason: Nominated
reportingComponent: karpenter
reportingInstance: ""
source:
  component: karpenter
type: Normal

There are certainly more information from Karpenter, but that might be a bit too specific/platform-dependent...


docs: Add command to release.md

Thanks for doing this but I did #2521 at the same time and it includes this change.


chore: 🔖 release 2.0.0

:robot: I have created a release beep boop
2.0.0 (2024-02-05)
⚠ BREAKING CHANGES

Python 3.7 is no longer supported. The minimum supported version is now Python 3.8.

Features

🧑💻 Implement __str__ for TokenEndpointError to provide more info in tracebacks. (#83) (7317215), closes #81

Build System

💥 remove support for Python 3.7 (6d1dfce)

Continuous Integration

👷 extend testing matrix of the httpx dependency (#80) (bd11cbf)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/h2oai/authn-py/releases/tag/v2.0.0 :sunflower:


Fix environment variable setting

https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions\#environment-files

Thanks @Hi-Fi !


RFC: unify the syntax of rw and unfold

Currently unfold is:
unfold List.map at hl

Currently rw is:
rw [List.map_cons] at hl

It would be nice to have both without [] if possible.
If not, I'd prefer to have both with [] for consistency.

@nomeata There are annoying ambiguities when you don't have the square braces, like in (a, by rw b, c). I think it would make sense having square braces for unfold too, though I wouldn't mind if the special case unfold ident were allowed.
With the new configuration syntax, there's another ambiguity where rw (some_identifier then_maybe_arguments) will put an "expected :=" error after some_identifier. We could fix that at the cost of tab completion of configurations not working as well (unless Marc can figure out some magic).

I general, tactics taking terms usually use brackets while tactics taking idents don't

With the exception of induction, which doesn’t have brackets per se, but induction and end-of-line (or the using or generalizing keyword) serve as brackets.

Anyways, as much as I would like to be able to use rw without […], change this is not worth the churn.


First Japanese l10n work for release-1.15.

First Japanese l10n work for release-1.15.

Change List

translate /docs/concepts/architecture/_index.md into Japanese (#15456)
Translate /docs/concepts/extend-kubernetes/_index.md in Japanese (#15458)
Follow the dir structure of en in setup (#15590)
translate /ja/docs/reference/_index.md (#15624)
Translate concepts/architecture/nodes.md into Japanese (#15625)
Translate docs/concepts/configuration/overview.md in Japanese  (#15627)
Translate concepts/architecture/master-node-communication.md into Japanese (#15638)
Translate /docs/tutorials/configuration/configure-redis-using-configmap.md in Japanese  (#15639)
Translate /docs/setup/turnkey/aws.md in Japanese (#15640)
Translate docs/tutorials/stateless-application/expose-external-ip-address.md in Japanese (#15672)
Translate /docs/tasks/tools/install-kubectl.md in Japanese (#15678)
Translate tasks/run-application/force-delete-stateful-set-pod/ in Japanese (#15835)
Translate tasks/debug-application-cluster/debug-pod-replication-contr… (#15883)
Fix terminology in Japanese translation (#15889)
Translate text of docs/setup/release/version-skew-policy.md in Japanese (#15903)
Translate sitemap and search to Japanese (#15927)
Translate concept and related glossaries to Japanese (#16034)
Fix missing curly bracket in content/ja/docs/tasks/debug-application-cluster/debug-pod-replication-controller.md (#16044)
Translate contribute / _index.md to Japanese (#16050)
Translate tasks/configure-pod-container/assign-memory-resource/ in Japanese (#16055)
ja: replace "kubernetes" with "Kubernetes" at main_kubeweekly_baseline (#16057)
Translate tasks/configure-pod-container/configure-volume-storage/ in Japanese (#16058)
Translate docs/tasks/administer-cluster/developing-cloud-controller-manager in ja (#16088)
Translate concepts/architecture/cloud-controller/ into Japanese (#16099)
ja: replace "Kubenretes" with "Kubernetes" (#16121)
ja: fix some wording on home (#16127)
Translate tasks/access-application-cluster/communicate-containers-same-pod-shared-volume/ in Japanese (#16183)
Translate tasks/configure-pod-container/share-process-namespace/ into Japanese (#16220)
Translate concepts/configuration/assign-pod-node/ in Japanese (#16221)
Translate tasks/access-application-cluster/connecting-frontend-backend/ into Japanese (#16270)
ja-trans:Translate concepts/services-networking/service/ into Japanese (#14917) (#16319)
Translate content/ja/docs/concepts/cluster-administration/controller-… (#16351)
Translate concepts/overview/working-with-objects/object-management/ into Japanese (#16400)
Translate concepts/extend-kubernetes/operator/ into Japanese (#16455)
Translate reference/command-line-tools-reference/feature-gates in Japanese (#16554)
Translate concepts/extend-kubernetes/extend-cluster/ and related glossaries into Japanese (#16636)
Translate concepts/extend-kubernetes/api-extension/apiserver-aggregation/ into Japanese (#16662)
Translate concepts/storage/volume-pvc-datasource in Japanese (#16775)
ja-trans: content/ja/case-studies/nordstrom (#16953)
ja-trans: content/ja/case-studies/sos (#17338)
Translate docs/reference/glossary/selector.md in Japanese (#17375)
backport assign inductor as sig-docs-ja approver (#17412) to dev-1.15-ja.1 (#17517)
ja-trans: Translate concepts/scheduling/kube-scheduler/ in Japanese #17118 (#17586)
Translate docs/reference/glossary/control-plane.md into Japanese (#17679)
Translate docs/reference/glossary/node.md into Japanese (#17680)

Co-authored-by: @yoshiki-nishikimi
Co-authored-by: @mhorioka
Co-authored-by: @fujipi270
Co-authored-by: @kakts
Co-authored-by: @oke-py
Co-authored-by: @craftone
Co-authored-by: @wakazooo
Co-authored-by: @SatoruItaya
Co-authored-by: @Go-Iwamoto
Co-authored-by: @af12066
Co-authored-by: @bells17
Co-authored-by: @sotoiwa
Co-authored-by: @inductor
Co-authored-by: @hasebe

/assign @steveperry-53

/lgtm

/approve

/approve

/cla-check

/check-cla

/approve

It's only Japanese changes. Why can't I just merge it 😂
@zacharysarah Can you help me? 🙇

@inductor 👋

It's only Japanese changes. Why can't I just merge it 😂

This PR also includes changes to i18n/ja.toml, that's why you're unable to approve. We'd love to put an OWNERS file in the i18n/ directory, but the inability to do so is a known Hugo bug. 😭
/lgtm
/approve

Oh shoot I didn't notice that. Thank you so much!


EarTrumpet manifest incorrectly modified without our knowledge

While preparing for an update to our EarTrumpet manifest, I discovered our manifest had been incorrectly altered (https://github.com/microsoft/winget-pkgs/pull/5759) and signed off by @KevinLaMS without any involvement on our part. This resulted in the distribution of ⚠ development binaries to all our winget users between December 29, 2020 and February 17, 2021.
Some questions:

How do we identify affected users?
How many times was EarTrumpet downloaded in this period?
Can you clarify policy regarding manifest ownership, manifest updates, and describe how external contributions are vetted/approved?

cc: @aclinick
New PR: https://github.com/microsoft/winget-pkgs/pull/7533

@riverar does it look like #100 would address your concern here?

@denelon Yep, looks like it'll work for our needs. Are there any updates to the proposal? It's pretty old.

@riverar We're going to take a deeper dive over the next few weeks. I'll share progress/changes when we're about to start working on it. I'm sure there will be some questions, and we're happy to hear any feedback. I'll ping back here so we can get EarTrumpet locked down.

@riverar  I am sorry for the troubles you have now.
It was/is currently not clear who "owns" a manifest and since this is opensource ppl contribute and try to keep the system up to date.
I created #5759 because the manifest you provided did not work anymore. #5757 requested the problem and I tried to solve it (since nobody else did). In my opinion, if an "owner" of a manifest changes the update url she also has to change the manifests with the old urls.
Sorry again, hopefully we can do better next time.

@pbrandstetter @denelon
Hi, I'm one of the developers for ModernFlyouts, while preparing to release an updated manifest for 0.9.1, happened to notice commit c0a527438060d7ad96c3920588ec059ffd49b938 and discovered that someone altered the link to the home page to a website that is not ours. (Redirecting users to a 3rd part site not affiliated to ModernFlyouts)
I hope this issue is taken seriously and some solution can be found to prevent this.
@riverar sorry for hijacking this this issue but i thought they both stemmed from the same issue.

 Kidding. Microsoft's proposal is promising, do check that out.
@pbrandstetter Appreciate you reaching out, sounds like we're on the right path now.

@riverar Thank you for your answer. I will be more carefully next time. Hope msft will find a solution for manifests with owners so such problems won't occur again.

@pbrandstetter have you already updated the manifest to point to the proper site? The feature to specify owners for packages should help prevent others from making changes to manifests in the future.

@denelon riverar already submitted #7533 with the most current version. This pr also points to the correct address.

The proposal is almost a year old now, are there any updates? Is it going to be executed on? Timeline?

It's next up for one of our engineers. After we review the plan and adjust, they will get assigned and we'll update the specification. It's going to be the first of several features that we would like to link to publicly visible meta-data. Part of the solution will involve how we can properly identify package owners. I'd like to get the initial implementation done this month if possible.

@riverar is your GitHub alias the only one you want approved to submit PRs for https://github.com/microsoft/winget-pkgs/tree/master/manifests/f/File-New-Project/EarTrumpet/<IP_ADDRESS>?
Would you like this restricted to the package manifests/f/File-New-Project/EarTrumpet/*
-or-
Would you like this to apply for any package published by manifests/f/File-New-Project

We still have the "business process" work to build out for identifying the proper owners for a package, and therefore the manifests. As that work completes, we will share the results with the community.

@denelon Would prefer to take over the whole org (option 2) but both options look good.

@riverar we've completed the technical implementation. We're working on the business process portion of the verified developer feature. Can you send me an e-mail so I can get permission to use EarTrumpet as a first implementation?

@denelon Will do.

Any updates on this?

Any updates on this?

https://github.com/microsoft/winget-pkgs/issues/100


Do not cast model expression to object value if the constraint is allowing the type

fix #3576

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/compiler

Show changes

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3824/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3824/


Update how-to-use-the-sharepoint-migration-tool.md

@killerewok2000 - sorry for delay on this. I think the article was updated in the meantime. Really appreciate your time making the docs better!


Implements module list generator

Resolves #64

Can you add in a checkbox to opt-out of attaching this generated list to the FormApplication?


Linkage select old value not persisting

Laravel Version: 5.5.40
PHP Version: 7.0.30
Laravel-admin: 1.5.*

Description:
The linkage select breaks when the form encounters validation errors.
Steps To Reproduce:
On live version of demo, on the user add form::

jump to address tab
select the linkage options
submit without filling any other fields
validation error occurs and the linkage field breaks.

The linked field doesn't show old value neither we get options from api.
@z-song, can we fix this ?

@pkkandel1 Did you come by any workaround. I need to fix this too. Another favor if possible, any suggestions for adding empty option in linked field. first option gets selected and looks pretty odd.


stm32h7:Proper clocking on Version V silicon  ADC backports

Summary
Impact
Testing

Rebased on current px4_firmware_nuttx-10.3.0+


Bulk Action: Open all

Is your feature request related to a problem? Please describe.
If I want to open all the bookmarks in a category or tag, I have to open each one.
Describe the solution you'd like
Some button to open up all the bookmarks
maybe under some bulk actions menu that also includes other options? for example like archive, add tag, remove tag, delete, mark as read, mark as unread (linkding does this but doesn't have open all)
Describe alternatives you've considered
Additional context
Also in the browser extension, a way to bookmark all open tabs? this might be a separate feature request..

Hello @Amithab! Bulk actions are something I want to introduce first with the bookmark import feature. For now, it'll be used to choose which bookmarks you don't want to import, or change their assigned category. But when this mechanism takes shape, I plan to introduce it in some other places.


feature request: multilingual slugs in engine page

Now for blog, news, contact is supported by default only url '/contact, /news ( i.e /sk/contact /sk/news),
but slovak visitors wants   '/sk/kontakt' , '/sk/novinky'.

Yep and I'm using same way as @thomasmaas to do this.

@parndt when would it be due? I'm very limited in time until january 2012 @simi How about you?

I know how to do this. But I'm not sure how to implement this into Refinery.
Should I write a guide about this or implement it into the engine generator ?

I think maybe a guide would be fine.
What do you think?

it seems the i18n_routing gem still has quite some issues. I didn't run into them because i used subdomains instead of folders for the different languages. @simi didn't you run into https://github.com/kwi/i18n_routing/issues/30 ?


Replace link to gitter with Discord

Coverage remained the same at 35.607% when pulling c050364d70ad9f7ff12d29752a2f93817f7a879b on rchl:patch-2 into f9c68aa98266e23f61b1254c3f41ee0af8c00f64 on tomv564:master.

I can confirm that people have to join ST's server first...

I'd also like to keep the link to gitter somewhere, perhaps in the Getting Help section? Of course, with the mention that it's no longer in use.

I can provide you with an invite link directly into the #lsp channel, if that's all you want. I disabled this feature for normal users, because default invite links expire after 1 day, people click them accidentally at times and I wouldn't want so many dead links around.

Well, here's a non-temporary invite link that never expires, unless removed manually: https://discord.gg/RMkk5MR
I clean up users who haven't logged in in 30 days every now and then, since we don't assign roles automatically.

We've merged without taking jrappen's suggestions into account. Should we add those also?

I'll push the changes now including a small change to the gitter link!

I did some follow-up PR also. Do what you please with it :)
#782


Operation refactor in core

This PR implements part of the suggestion in #1419, removing MapOperation and merging Operation and ElementOperation.
It doesn't do anything to TreeOperation just yet which results in the duplication of classmethods. I would like to see this PR merged before I continue reviewing the new operations tutorial.

@philippjfr Tests are finally passing.
Ready to review. If you want me to handle TreeOperation right away, just tell me what you recommend and I can add those changes to this PR.

Let's get to that later once I've figured out whether there's something general there we can keep in HoloViews. Merging this now so you can continue with the Operations tutorial refactor.

Thanks!


Updated file with new D0wn's DNS server in Spain

Added new d0wn's DNS server in Spain.

Great! This has been merged.
Thanks for your contribution!


enable_cache_go_rule

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @SanaaYousaf - thanks for the PR. Do you think there is a demonstrable security impact of leaving the cache disabled? If so could you add a bit more info about this to the rule metadata under "explanation/impact"?

Can you also generate the avd docs for this? Run make docs and commit the generated docs with this PR.


List bugfixes on master not on releases/1.4

456af52b3aa39b31930e7d031d5ce1639694cdb7 Hide Pod and AppRepository - Group owns them (#4824).
6c0149d0d1592bb0bc5509a1b5e4770605f87905 Disallow usage of Command Checks on Pods until mesos supports them (#4872)
c8924aa8d3a21346a7728c881d6378dc969e320c Inform the rate limiter for pods and apps (#4863)
eeb2fb94433b3e8b976b1876816fd87d50a8f71b Fixes #4902 by removing maxInstances from the Raml spec and all usages of this property.
40d19f4ad0e2871adff0132365d836de4438c0a6 Apply NetworkInfo changes introduced in 1.4
14177b0119c91c8687296893a9755ad71ee79b3a Fixes #4932 | GET on empty apps list result 500 exception (#4940)
cbb1df7f49ebc751643c323b9cf522997a0f47d3 Fixes #4948 | Lazy event parsing (#4986)
a8a8bc140de11e08de41ca5feab17517d14d1336 fixing recovery errors for groups.  adding metadata resource file
f441c571beb445271be6b00fa097ed2f4c6ad7f3 ForceExpunge for missing task is a no-op, rather than a failure
94efcee727612559ca227af4adce3a458281ee2c Initial stab at making deployment plans cheaper.
f924d81cc1756c11d1b778700081616f820035a5 Fixes #4901 by removing the short circuit for root group changes.
c3be7e07d16f791abe0aa4cd8abbdd41911ab28b Use the latest stable Marathon UI build (#5181)

All commits subject to discuss if they should be picked to 1.4

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2312. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


e-hentai ripper unnecessary delays

The ripper has delays to prevent the website from blocking downloads on a timeout. However, when re-ripping an album, images which have already been downloaded should not trigger this delay. For re-ripping a couple of images which were perhaps deleted by mistake or corrupted, or to resume a stopped rip, this will help a lot in speeding up the productive part of the download.

I think the e-hentai ripper is one of those rippers that needs to download each image from a specific page.

Fetch the main gallery (e.g. gallery.html)

We have a list of "images" in the gallery (but these are just links to more .html pages)

Fetch first "image page" at image1.html

Now we can extract the actual image (*.jpg) from the page

Download image (or skip if it's a duplicate)
Repeat Step 2 for next image.

The ripper does not know if it's a duplicate until Step 3, when we have the image URL & are about to download it. At that point, we're already fetching the image's HTML page and likely need to throttle those requests.
But I think there could be extra logic to detect duplicates before Step 2.


mjpeg instead of rtsp ?

hi
can i use as „source“ also the mjpeg stream instead of rtsp ?
and what are the parameters -re -i ?
regards, richard

-re -f mjpeg -i [http://...]

Hi, I have a similar problem. I have surveillance camera (on synology – AirCam OD-2060HD). Camera hasn't show in homekit... Is everythings all right, please?
Thank you very much:)
{
"platform": "Camera-ffmpeg",
"cameras": [
{
"name": "OKO",
"videoConfig": {
"source": "-re -f mjpeg -i http://<IP_ADDRESS>:5033/webapi/entry.cgi?api=SYNO.SurveillanceStation.Stream.VideoStreaming&version=1&method=Stream&format=mjpeg&cameraId=7&StmKey=050a302be0d5f6a827d90f2c95fc0834",
"stillImageSource": "-i http://faster_still_image_grab_url/this_is_optional.jpg",
"maxStreams": 2,
"maxWidth": 1920,
"maxHeight": 1080,
"maxFPS": 30
}
}
]
},


Message schemas: form validation+generation, typing from server to client, ...

Currently, message types are mostly defined in TypeScript. Messages are used as raw dict on the Python side, which means error handling is a bit... let's say, bad. Messages send from the Python API to the client are duplicated in the server code. Even on client-side, there is no further validation, which means you can enter nonsense data and only get a (rather unhelpful) message after submitting the form.
Ideally, there should be a canonical description of all messages in a suitable format. This description may include metadata for generating forms, which may not be a simple 1-to-1 mapping to messages. Note that not all messages need to have form representation, but we could validate all messages before sending them to the server.
From this description, TypeScript types should be generated; incompatible changes to any message type should be caught by the type system for the client code. We may even use mypy to check types on the Python side.
Also, validation logic for both the Python API and the forms in the GUI should be generated. Client-side validation logic could use JSON schema, if this is sufficient; this needs to be evaluated (regarding expressiveness and error messages).
Ideally, the outcome would be well-behaved, automatically generated forms just by defining a schema in a single place, which would go a long way to adding UDFs to the GUI more easily.
See also:

Related discussion in #233 about the "open dataset" dialog
related project: https://github.com/bcherny/json-schema-to-typescript
related project: https://github.com/encode/typesystem (supports generating json schema); this looks very good, even though it is a young project!
some old example code in https://github.com/LiberTEM/LiberTEM/tree/master/prototypes/schemastuff

For a subset of messages (open dataset), we are now using json schema for validation. This covers most of the current cases of free user input. There is no generation of TypeScript interfaces from json schema yet, so still some duplication. Let's see how well this works and maybe we can adapt this for all messages on HTTP/websocket.

Oh, and no form auto-generation yet, either - but that's not really a pain point right now.

I want to work on it as my GSOC 2020 project.

Another related project: https://github.com/sinclairzx81/typebox

Related blog post: https://vriad.com/blog/zod/

So which framework should we use for this issue and validation purposes?

So which framework should we use for this issue and for validation purposes? zod or io-ts ?

... or maybe something different? The point is, we don't know, and figuring our what to use is a large part of the project itself. Important is that we reach the goals outlined in the issue description.
I'm mostly posting the links to the related project so that we have an overview for different approaches for parts of the solution, not necessarily so we can directly use one of these packages.

Even more links:
https://shahmeer.co/blog/end-to-api-typing.html
https://github.com/rawrmaan/restyped
https://instagram-engineering.com/types-for-python-http-apis-an-instagram-story-d3c3a207fdb7
https://docs.apistar.com/ and https://www.starlette.io/schemas/

Messages send from the Python API to the client are duplicated in the server code.

I think I did not understand it as I was going through it again. If possible can you explain it to me?

Messages send from the Python API to the client are duplicated in the server code.

I think I did not understand it as I was going through it again. If possible can you explain it to me?

This means that there are structural definitions of some kind for each message that is sent from the server to the client, and they are present both on the server and the client. On the server, these definitions are often only very rough, as they are not typed, so the structure is just "whatever dict this method returns".
To understand this more deeply, pick a message type, for example FINISH_JOB. Try to read the code (both server and client) and figure out how/where a message of that type is generated on the server, sent to the client, arrives at the client, and how it is then handled on the client. Compare how the messages are created on the server with how they are then interpreted on the client. If you don't see it at the beginning, try to repeat this for a few different message types.
You can also have a look at the opposite direction, how the client calls the HTTP API and handles the structure of the data it sends as payload, and then how the server interprets this, and what assumptions it makes about the data it gets.

Additional related project: https://github.com/asyncapi/asyncapi

Additional related project: https://github.com/asyncapi/asyncapi

I had come across it while I was researching, But it does not have code gen support for typescript and python. So I never mentioned about it.

Related: https://github.com/sinclairzx81/typebox


Updating brush #152

@mijar @katush Addressing numerical brushing with window and rendering the values in histogram

The color in supportview and table view might be different since I have to update the same color in phovea vis  heatmap representation.


Field support for @AndroidResources with parameterizable xml path and resource type

Hi,
I provided MutableField support for @AndroidResources with parameterizable xml path and resource type.
I left the original @AndroidResources logic well alone. I saw the hardcoded paths etc.
Please review.
Thanks

Awesome, thanks!


[17.10] Fallback to use naive diff driver if enable CONFIG_OVERLAY_FS_REDIREC…

To bring in fix:

https://github.com/moby/moby/pull/34342 Fallback to use naive diff driver if enable CONFIG_OVERLAY_FS_REDIRECT_DIR

Cherry-picked git commit https://github.com/moby/moby/pull/34342/commits/49c3a7c:
$ git cherry-pick -s -x -Xsubtree=components/engine 49c3a7c

went in clean

Just one flakey test failure:
01:49:31.877 FAIL: docker_cli_restart_test.go:265: DockerSuite.TestRestartContainerwithRestartPolicy
01:49:31.877
01:49:31.877 docker_cli_restart_test.go:282:
01:49:31.877     // Make sure we can stop/start (regression test from a705e166cf3bcca62543150c2b3f9bfeae45ecfa)
01:49:31.877     dockerCmd(c, "stop", id1)
01:49:31.877 c:/gopath/src/github.com/docker/docker/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
01:49:31.878     t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
01:49:31.878 ...


Do not freeze file-based Poetry dependency version

Fixes #4333. This was modeled after #2361 with the same type of tests.
I also renamed the test files to differentiate between directory-based and file-based dependencies, both of which can be specified by a path.

Do you think we need to do anything about the url dependencies or do you think those will be covered?

Tbh, I am not sure! Maybe we can add a test for it?

What's the process/timeline for this fix being included in the official GitHub Dependabot?

Once it's merged I can cut a release fairly quickly and can roll it out usually the same or next day.

There's a couple of failing python tests on CI @phillipuniverse, would you mind taking a look at those?

ok! @jurre I feel pretty good about this now, sorry again for how long this whole thing has taken.
New updates:

URL dependencies had the same problem and were incorrectly adding a version attribute, I added a test and whitelisted it
Added more positive assertions for directory and file dependencies -- essentially make sure the dependency is actually there but the dependency + version is not

Thanks for your help getting this over the line! We should probably squash merge this when it's all done.

@jurre last thing here - I have 1 failing test locally and I'm not sure why:

But even with my change in python/lib/dependabot/python/file_updater/pyproject_preparer.rb commented out it still fails. And I even checked out main and ran it and still fails so... 🤷 hopefully it won't fail in CI!

I have 1 failing test

I am currently working on upgrading pipenv so I think I can tackle that failure, it doesn't seem related to these changes


NeoDemo consumes up to 3GB of ram

Is it normal that running the NeoDemo app takes up to 3GB of Ram?
I tried taking a memory snapshot and understand where it was all going towards, but couldn't make heads nor tails from it. What steps can I take to find out the cause or improve it?
I couldn't find any other issues mentioning anything related, so maybe it's just my configuration somehow?

There seems to be a big discrepancy between what VS diagnostics window reports as Process Memory and what Task manager reports. I will look into that. Thanks for the quick reply.


SPI DMA: use State for both blocking and async operations

Also removes the async version of SpiDmaBus in favour of being generic over the mode
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝

[x] I have updated existing examples or added new ones (if applicable).
[x] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
[x] My changes were added to the CHANGELOG.md in the proper section.
[x] My changes are in accordance to the esp-rs API guidelines

Extra:

[x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖
Description
I found the State enum much easier to understand the flow of the SpiDmaBusAsync instead of the option based impl on the blocking SpiDmaBus. Therefore I started looking at sharing the state enum for both, before quickly realizing we can actually remove the Async variant in favour of being generic over the mode (not sure how I missed that in my review :sweat_smile:).
I think using State everywhere possible is a good idea, especially if we want to add more wrappers, for things like double buffering.
Testing
I ran the HIL suite locally.
TODO

[ ] Document the new public methods
[x] Add Half duplex support to SpiDmaBus

cc: @Dominaezzz (I hope I didn't step on your toes with your ongoing work :sweat_smile:)

Hmm, it seems that SpiDma, at least in half duplex isn't capable of sending MAX_DMA_SIZE. It just hangs in my project. MAX_DMA_SIZE / 2 seems to work though, not sure what's causing that.

Curious, that's on an S3 right? With the move API and not the wrapper?

Curious, that's on an S3 right? With the move API and not the wrapper?

On an S3 and yeah with the wrapper (Don't judge, this is just test firmware but here is the snippet: https://github.com/MabezDev/mkey/blob/6fdb013e90af50b13117d523855ec0e37b717979/firmware/src/main.rs#L454-L467).

On an S3 and yeah with the wrapper (Don't judge, this is just test firmware but here is the snippet: MabezDev/mkey@6fdb013/firmware/src/main.rs#L454-L467).

Seems like this was some stack overflow issue, I don't think the code gen for fill is that nice, but I reduced my framebuffer size and the SPI device managed to send frames at the full DMA_MAX_TRANSFER size.
This PR is ready for review.


BannerView.cs error

Assets/GoogleMobileAds/Api/BannerView.cs(22,20): error CS1502: The best overloaded method match for `GoogleMobileAds.Common.IGoogleMobileAdsBannerClient.CreateBannerView(string, AdSize, GoogleMobileAds.Api.AdPosition)' has some invalid arguments
Assets/GoogleMobileAds/Api/BannerView.cs(22,20): error CS1503: Argument #2' cannot convert GoogleMobileAds.Api.AdSize' expression to type `AdSize'
I have no idea how to fix it

This issue is being closed due to its age. For bugs in the plugin open a new issue or reach out on our support group at https://groups.google.com/forum/#!forum/google-admob-ads-sdk.

Ram


Calling queryClient.setDefaultOptions does not trigger re-render

Describe the bug
Changing defaultOptions in queryClient instance is not triggering re-render of React tree.
In my case, I'm trying to change default option of enabled from false to true in useEffect.
Unfortunately, queries remain idle until something else triggers a re-render of a component.
To Reproduce
Steps to reproduce the behavior:

Go to CodeSandbox
Observe that Example component does not re-render after default options change - query remains idle

Expected behavior
Components that have useQuery are re-rendered after options change
Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: 92

I’m not sure if setDefaultOptions should trigger a re-render. An easy workaround would be to keep the enabled boolean in react local state, which would trigger a re-render of the whole subtree.

@TkDodo Yes, that's what I'm currently doing to resolve this issue, thanks :)
If that is an intended behavior - feel free to close this issue.
Maybe it;s worth mentioning this behavior in the docs

Not sure if it’s intended or not, I think we could technically inform observers about that change. @tannerlinsley ?

Thought about this, and I don't think that setting defaultOptions should inform observers. I think it would lead to unnecessary renders in many situations, e.g. if I have a certain config, like staleTime, explicitly set on my query, and we update the defaultOptions. The query wouldn't care that the default options change because it uses its own option.
I think the solution to keep those options in state and trigger a re-render with it is the better one.


Is there a way to login into a Google App using SSO?

Hey All!
I just discovered Nativefier and it is amazing! I was able to use Evernote on Linux with it and so far it is much better than in browser! Yay!
Though I am struggling to use Google apps like calendar or Gmail: In order to do so I need to login using Single Sign On (SSO) - basically what it means - google redirects me to my company's login screen where I enter my credentials and then redirects back to Google.
The problem is when I am using Nativefier the SSO login screen is being opened in a Chrome, as opposed to in my generated app. So Once I login in browser - I am good but I am logged in in browser, while the generated app shows google login screen in awaiting state.
Does anyone has any suggestions?
Thanks!

Check out the --internal-urls option
https://github.com/jiahaog/nativefier/blob/master/docs/api.md#internal-urls

I tried this using the --internal-urls options and it still says "couldn't sign you in". Has anyone else gotten Google Calendar to work?

Only way I found around this right now is to use an alternate User Agent string that specifies Windows and no Chrome at all, e.g.:
-u "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/73.0"
If the string has "Chrome" in it it will work but it will use the old HTML-only version of Gmail. If it has version information, e.g. "Chrome/80.x.y" then it will give the above error.

@mclamb this worked for me. Thank you so much.

No problem. Next up is to figure out how to get links to open in Gmail.app without having to context-click open link. Direct-clicking doesn't work, regardless of my --internal-urls settings.

Thanks @mclamb . Closing, letting discussion go on at https://github.com/jiahaog/nativefier/issues/831 .


Uninstalling - Installing Questions (formerly update)

Do you recommend to remove all the packages when uninstalling for install it later?
Which ones do you recommend to remove completely?
Thanks

You can just hit y on everything.
On May 1, 2016 1:37 PM, "planetahuevo"<EMAIL_ADDRESS>wrote:

Do you recommend to remove all the packages when uninstalling for install
it later?
Which ones do you recommend to remove completely?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/pivpn/pivpn/issues/22

Yes, I know that. But why uninstall git (for example, the only one i know) to install it again in 5 minutes?
Is there any other package that has nothing to do with the server (like the git package) and we can skip the uninstall?
I suppose you just recommend to uninstall everything.

No reason.  It really doesn't matter.


[Bug] < int_zendesk__schedule_spine > may be missing rows after DT ends

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
I have spent a good deal of time trying to figure out why the table sla_policy only has rows as recent as Oct 30 2022.
After digging, I found the intermediate table called int_zendesk__schedule_spine, which only has rows with values for "valid until" up to Oct 30 2022 as well.  All other tables have seemingly valid data such as "sla policty applied" and "time zones".
Anyone else experiencing this issue?
Relevant error log or model output
No response
Expected behavior
I expect the model to give rows for all recently applied SLAs in the transformed table zendesk__sla_policies.
dbt Project configurations
vars:
    #Shopify Vars
    shopify_union_schemas: ['shopify_tbv','shopify_tel','shopify_tna']

    #Zendesk Vars
    #using_schedules:            False         #Disable if you are not using schedules
    #using_domain_names:         False         #Disable if you are not using domain names
    using_user_tags:            False         #Disable if you are not using user tags
    #using_ticket_form_history:  False         #Disable if you are not using ticket form history
    #using_organization_tags:    False         #Disable if you are not using organization tags

Package versions
packages:

package: fivetran/shopify
version: [">=0.6.0", "<0.7.0"]
package: fivetran/netsuite
version: [">=0.6.0", "<0.7.0"]
package: fivetran/zendesk
version: [">=0.9.0", "<0.10.0"]

What database are you using dbt with?
bigquery
dbt Version
version: '1.0.0'
Additional Context
No response
Are you willing to open a PR to help address this issue?

[ ] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[X] No.

correction:
dbt Version
version: '1.3.0'

I think I do need to use the daylight_time component as we run SLAs based on business hours.
I am not sure that the daylight_time source table (as synced by Fivetran) should have rows for the period between DT, such as Oct 30 - March 27.  Here is a sample of recent rows in the raw data table:
{
"time_zone": "London",
"year": "2022",
"_fivetran_synced": "2022-10-27 12:57:07.645000 UTC",
"daylight_end_utc": "2022-10-30T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2022-03-27T01:00:00"
}, {
"time_zone": "London",
"year": "2021",
"_fivetran_synced": "2022-10-27 12:57:07.644000 UTC",
"daylight_end_utc": "2021-10-31T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2021-03-28T01:00:00"
}, {
"time_zone": "London",
"year": "2020",
"_fivetran_synced": "2022-10-27 12:57:07.643000 UTC",
"daylight_end_utc": "2020-10-25T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2020-03-29T01:00:00"
}
If you meant the dbt produced stg_zendesk__daylight_time table the results are similar:
{
"daylight_end_utc": "2022-10-30T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2022-03-27T01:00:00",
"time_zone": "London",
"year": "2022",
"daylight_offset_minutes": "60"
}, {
"daylight_end_utc": "2021-10-31T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2021-03-28T01:00:00",
"time_zone": "London",
"year": "2021",
"daylight_offset_minutes": "60"
}, {
"daylight_end_utc": "2020-10-25T02:00:00",
"daylight_offset": "1",
"daylight_start_utc": "2020-03-29T01:00:00",
"time_zone": "London",
"year": "2020",
"daylight_offset_minutes": "60"
}
Either way it does not look like there are ever rows which cover the period between DT periods.
It looks like the int_zendesk__schedule_spine model was introduced in the package's February 2022 release (.80? maybe). Totally possible that this change created the issue as this is the first "end of DT period" since release.
Jacob

Hey @jflatter thanks for sharing this detail. The int_zendesk__schedule_spine should create records for these non DT periods even though the source table does not provide them. I am curious what the most recent records of the materialized int_zendesk__schedule_spine model look like. Would you be able to materialize this model as a table and see if this is creating records for the in-between periods. I suspect it may be stopping for some reason following this period, but I am unsure why that may be exactly.
The introduction of the int_zendesk__schedule_spine model was required in order for us to properly account for daylight savings across schedules. With that you are correct that this first end of DT period may have a factor of the code that is not fully functioning as expected.
Unfortunately, it is hard to troubleshoot on my end as our own internal data doesn't leverage schedules or take into account the daylight savings offsets. Would you be chance be open to meeting with me live to debug this issue and investigate what may be happening within the package or the source?

@jflatter I noticed you scheduled some time to discuss during our office hours, but you were not able to attend. The office hours are always open if you would like to schedule another call with our team.
Additionally, I was able to loop up with our engineering team and discovered that they released an update to the connector to adjust the daylight_time source table to account for the recent daylight time change. Would you be able to run the package again and see if you are seeing the issue still? I am curious if the fix on the connector end rectified the initial bug you identified in this issue.

Marking as blocked for the time being. @jflatter feel free to add more context if you are still experiencing this issue.

Closing this issue as I believe the update on the connector end addressed the core issue detailed here.
Please feel free to reopen if you are still experiencing this issue or you wish to discuss this further.


[Program]: Write a PHP program to find the determinant of a matrix

Description
Write a PHP program to find the determinant of a matrix
The determinant of a square matrix is a scalar value that can be computed from the elements of the matrix. The determinant of a matrix A is denoted as det(A) or |A|.
Input  :
1 2 3
4 5 6
7 8 9

Output :
0

How to contribute

Save the solution in program/program/find-the-determinant-of-a-matrix/program/find_the_determinant_of_a_matrix.php file

!assign


Added removeExtension helper

Added a helper function removeExtension that removes an extension from the glTF. Added to index.js as well since there are a few other projects that could use this helper.

For some reason this PR wasn't including the latest commits in the branch, maybe a side effect of the github outage? I opened https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/398 instead which is up to date and ready to look at.


Umple gets into infinite loop with key in a subclass with infinite cycle error

The following crashes the compiler. Likely the key check is looking through the infinite superclass chain before the chain itself is detected
class Watershed
{
  Integer id;

}

class District
{
  isA District;
  Integer id;
  key{id}
}

This bug may also occur if non-direct cycles are present
There may be similar bugs in other cases where we search the inheritance hierarchy. The solution is either to put the cyclical check first before walking the hierarchy, or detecting loops during other walks. Please search for possible other cases. I have noticed Umple getting into an infinite loop and crashing once in a while; this is the first time I have actually identified a failing case.
I want one of this terms UCOSP students to prioritize this please.

One more thought: The ideal solution is still to put the cycle check first.
However, if the above is hard to do, or even if it is not hard, for extra protection in all searches when doing analysis, I suggest limiting them with a counter at some reasonable maximum. For example you would never have an inheritance hierarchy of 25 levels, so this would be a very conservative maximum. When starting to search set a variable to 25 and count down at each iteration. If you reach zero, then stop the search. That will prevent infinite loops.
The depth of most inheritance hierarchies is zero or one. Occasionally a hierarchy of 4 or 5 is found. Legitimate hierarchies higher than 12 are almost unheard of. Double that to 25 to get a safe search limit.

This is probably related to the issue #449.
Check the method private void analyzeKey(Token keyToken, UmpleClass aClass) in class UmpleInternalParser, file UmpleInternalParser_CodeClass.ump.
Look for the comment //Issue #449 and investigate the while loop.

I notice you say in your log that you check for cycles every time a token is parsed. I trust that you have taken account of efficiency and that this will not have a large impact on that aspect.
Also I notice you say that now this error is perhaps appearing instead of some other errors as this is being detected first. Make sure the other errors still have some way of being tested.

I ran 3 builds each using the old code and my new code (2 first/quick, 1 first/quick) and noticed no significant changes in run-times. They all averaged out to be roughly the same time. My tests were not very scientific, but they at least didn't show any immediate increase in compile time.
I had two tests that were failing

The first was from:

class Student
{
  isA Proffesor;
}

class Proffesor
{
  isA Student;
}

The original code detected the cycle at the first class, but mine detects it in the second class. I changed this to pass since it has no impact to the user either way (both show that there was a cycle detected).

The second is from:

class A{isA A;}trait A{}
I ran this input on the current  version of UmpleOnline and noticed that only the duplicated name is thrown as an error, and the dependency cycle is left out. My implementation does the inverse. I'm not sure if this is okay, but I don't feel as if the user is really losing out on any functionality.


Let Hosts default to redirecting on port 8080

This restores the de facto behavior of 1.0 and 1.1 -- a Host resource using TLS would default to supporting redirection from 8080 to 8443. You can now disable that behavior by setting insecure.addtionalPort to -1, and the KAT tests do a better job of testing for it.
This is probably best reviewed commit-by-commit. I tested with KAT under OSS and Edge Stack, and by running the migration scenario by hand.

Oh, also: This needs a doc change.


[TODO]: var name with namespace rule

Like these mod1::fn1, mod1::fn2

If find main, no mangling to the variable, else use dir as module mangling name.


Question on unused functions

I am reading over the code and trying to understand it.
If I come across an unused function, do you want an issue submitted about it?
I realize that the unused function might be for future use; or, it might be something left over when it was formerly being used and is no longer needed. In the latter case, it probably should be deleted.
Here is the example that I came across. In ReactDOMRe.res file, the function "external createElement:" seems to be unused. A global search didn't find it and if I comment it out then there is no compile error.
I may not understand why it is there. Or, it may be being used in a dynamic way. If you can shed some light on this, it may help me in my reading over your code.

ReactDOMRe.res is not a project file, it is a part of the library<EMAIL_ADDRESS>If you are interested in how this function may be used, you may read about it in the ReScript documentation https://rescript-lang.org/docs/react/latest/elements-and-jsx#creating-elements-from-component-functions  This page describes not exactly that function, but it is very close - it allows to create a react element by passing the name of a component, props and children. This function is in "legacy" directory, so probably it is deprecated.

If I come across an unused function, do you want an issue submitted about it?

That's a good idea to remove unused forgotten code. I think no need to create a new issue for each such case. Please post your findings in this issue.

I am closing this issue. If you find any unused functions please feel free to re-open this issue and post your findings here.


WIP add verbose OOM logging

DO NOT MERGE - PR opened just for auxiliary testing purposes.

/close


Play non-steam game AND normal games?

Hi
I can show I am playing a non-steam game by passing that long game id into games_played and adding the game_extra_info key with the non-steam game name to the array....
However, Is it possible to have that non-steam game displayed and play normal games as well? I've tried all manor of combinations in the gamesPlayed function but I can't seem to get it working.
Is it possible and if so, what format does the data need to be?
Thank you
Edit: Is this repo still supported?

Hello?

games_played is an array, so technically it should be possible.
steamUser.gamesPlayed({
  games_played: [
    { game_id: '15444025664222527488', game_extra_info: 'Non-steam game' },
    { game_id: '440' } // TF2
  ]
});

If the Steam client can do that, then you can use NetHook to see what it sends. Otherwise only Valve knows if it's possible or not.


Feature request: color gradient controller

It would be great to have a color gradient controller. I think this may be a common requirement, and few gui libraries can easily implement it.
Like this:

That would be a useful controller, but it should probably be a user extension. I'm working on an example that demonstrates the process of making a custom controller and hope to have it done soon!


Add Shuffle Functionality and read BGM list from Google Drive

Hi both,
This PR aims to add shuffle functionality to Orchestrator and also deprecates usage of the CSV file by reading directly from Google Drive.
Shuffle:

Adds a 'Shuffle' button to the right of the 'Stop' button.
When clicked it will randomly choose a song based on the ids provided from the Google Drive CSV.
Some FFXIV songs repeat endlessly while some do not and only loop once (i.e. 'Victory!').
For songs that only loop once I found an address that I believe represents the games music buffer. I have added logic that skips to the next song when the buffer is no longer being written to i.e. when the first song loop ends.
For songs that repeat endlessly I have simply added logic to change song after 3 minutes. Future work would be trying to find in-memory where the flag to repeat a song is stored.
Shuffle can be toggled off by either clicking 'Stop' or 'Play'.

Google Drive reading:

Simply retrieves from Google Drive the CSV file for the song list and then parses it into memory.


Can you explain how the workflow is found?

I see some operations around workflow created_at and request created time. Is it just by time check?

Yes, it is kind of messy, but find_workflow is trying to check if the latest workflow returned by the cURL request was triggered within the last 10 seconds. It often takes a few seconds for a recently triggered workflow to appear on the repository dispatch page, so that step was to guarantee that the workflow that is monitored is the one that was just triggered. This assumes that workflows are triggered at least 10 seconds apart, which is fine for the project I was working on, but might not be true in general.
zigiai's fork has a cleaner and more reliable method that gets the expected workflow id before triggering the new workflow. I can try to add something similar, but I've been quite busy lately so I may not get to it any time soon.

Copied that. I read the github actions workflow APIs. I didn't find a good way to sync with triggered workflows.
I guess for now we just check the workflow within the last 10 secs.
Thank you for the confirmation.

Yes, it is kind of messy, but find_workflow is trying to check if the latest workflow returned by the cURL request was triggered within the last 10 seconds. It often takes a few seconds for a recently triggered workflow to appear on the repository dispatch page, so that step was to guarantee that the workflow that is monitored is the one that was just triggered. This assumes that workflows are triggered at least 10 seconds apart, which is fine for the project I was working on, but might not be true in general.
zigiai's fork has a cleaner and more reliable method that gets the expected workflow id before triggering the new workflow. I can try to add something similar, but I've been quite busy lately so I may not get to it any time soon.

@felixp8 everything would be easy if when we dispatch the event, the API would return the RUN_ID instead of having a 204 NO CONTENT.  I can't believe something simple and useful can not be added quickly from GH developers.

@felixp8 everything would be easy if when we dispatch the event, the API would return the RUN_ID instead of having a 204 NO CONTENT. I can't believe something simple and useful can not be added quickly from GH developers.

I found a way by API. when you invoke a workflow,  pass anything unique as a parameter and show it and show it on the title. When you check the downstream workflow from uptream, search by that parameter on the tile.

@chenghuang-mdsol
Do you mean here?
POST
https://api.github.com/repos/owner/repo/actions/workflows/ci.yml/dispatches
{
    "ref": "main",
    "inputs": {
        "something": "my-random-id-xxxxx"
    }
}

but that parameter doesn't appear the response when I got all runs as a title
GET
https://api.github.com/repos/owner/repo/actions/runs

What endpoints do you mean specifically?

@chenghuang-mdsol
Do you mean here?
POST
https://api.github.com/repos/owner/repo/actions/workflows/ci.yml/dispatches
{
    "ref": "main",
    "inputs": {
        "something": "my-random-id-xxxxx"
    }
}

but that parameter doesn't appear the response when I got all runs as a title
GET
https://api.github.com/repos/owner/repo/actions/runs

What endpoints do you mean specifically?

In your ci.yml, do something like:
jobs:
  job1:
    name: Your job name - ${{ github.event.inputs.something}}

Then you can search "my-random-id-xxxxx" from jobs.name, from your API response https://api.github.com/repos/owner/repo/actions/runs
I would suggest you do
https://api.github.com/repos/owner/actions/runs?branch={branch_name}&event=workflow_dispatch
Then you filter by trigger time and search key word "my-random-id-xxxxx"

@chenghuang-mdsol I got it. I will try that tomorrow. Thank you!

@chenghuang-mdsol I can't parameterize the name of the workflow (that would be ideal), but as you said I can parameterize the name of the job. After that, I can use this endpoint to check the name of the job inside the workflow:
https://api.github.com/repos/owner/repo/actions/runs/WORKFLOW_ID/jobs
Thank you for your help!

@chenghuang-mdsol Very neat, thanks for the tip! I'll need to try that myself


MongoDB deleteMany seems to send 2 identical read queries first before triggering the actual delete

As seen in https://github.com/prisma/prisma/issues/15084, a MongoDB deleteMany seems to send 2 identical read queries first before triggering the actual delete. One of those is probably not necessary:
$ ts-node ./script.ts
deleteMany
prisma:query db.User.aggregate([ { $match: { $expr: { }, }, }, { $project: { _id: 1, }, }, ])
prisma:query db.User.aggregate([ { $match: { $expr: { }, }, }, { $project: { _id: 1, }, }, ])
prisma:query db.User.deleteMany({ _id: { $in: [ ObjectId("6d795f757365725f69643030"), ], }, })

4.3.0-dev.84

Can reproduce the 2 identical queries
deleteMany
prisma:query db.User.aggregate([ { $match: { $expr: { }, }, }, { $project: { _id: 1, }, }, ])
prisma:query db.User.aggregate([ { $match: { $expr: { }, }, }, { $project: { _id: 1, }, }, ])
prisma:query db.User.deleteMany({ _id: { $in: [ ObjectId("6d795f757365725f69643030"), ], }, })
...

Note: I only see db.User.deleteMany line on a second run

Hello, I'm using
'@prisma/engines-version': 4.17.0-26.6b0aef69b7cdfc787f822ecd7cdc76d5f1991584
prisma: 5.6.0
and I'm executing a deleteMany over a 500K documents set (i.e., the where clause selects 500K documents).
Prisma is performing indeed 2 reads before each deletion; moreover, it seems that it is chunking the deletion into several parts and after a couple of parts the transaction fails with:
"WriteConflict error: this operation conflicted with another operation. Please retry your operation or multi-document transaction" and I am 100% sure that I have 1 process running, so no other "explicit" operation is writing the same ids.
Is this fix already available in my version? Do I have to change version?
Thanks

No, this was merged in 5.4.0 and per your comment you are somehow still using the engines from 4.17.0. You will have to completely upgrade to 5.4.0 or newer.


Using a function as a fallback route doesn't work

Describe the bug
Functions should be able to be used as navigation fallback like configured here but it doesn't work.
To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/anthonychu/test-swa-ssr.git
cd test-swa-ssr
swa start public --api api
Navigate to http://localhost:4280/foo returns the 404 page

Expected behavior
Navigating to http://localhost:4280/foo should return the function response. This works when deployed to Azure.

Fixed with #314


Incorrect output

Got from http://9ol.es/TheEmperorsNewClothes.html
#!/bin/bash
. ticktick.sh

``
  people = {
    "Writers": [
      "Rod Serling",
      "Charles Beaumont",
      "Richard Matheson"
    ],
    "Cast": {
      "Rod Serling": { "Episodes": 156 },
      "Martin Landau": { "Episodes": 2 },
      "William Shatner": { "Episodes": 2 }
    }
  }
``

function printDirectors() {
  echo "  The ``people.Directors.length()`` Directors are:"

  for director in ``people.Directors.items()``; do
    printf "    - %s\n" ${!director}
  done
}

`` people.Directors = [ "John Brahm", "Douglas Heyes" ] ``
printDirectors

newDirector="Lamont Johnson"
`` people.Directors.push($newDirector) ``
printDirectors

echo "Shifted: "``people.Directors.shift()``
printDirectors

echo "Popped: "``people.Directors.pop()``
printDirectors

Generates:
  The 2 Directors are:
    - John
    - Brahm
    - Douglas
    - Heyes
  The 3 Directors are:
    - John
    - Brahm
    - Douglas
    - Heyes
    - Lamont
    - Johnson
Shifted: John Brahm
  The 2 Directors are:
    - Douglas
    - Heyes
    - Lamont
    - Johnson
Popped: Lamont Johnson
  The 1 Directors are:
    - Douglas
    - Heyes

GNU bash, version 4.4.23(1)-release

This is not really a problem with TickTick. It is a problem with the script that is invoking it, and with the TickTick README. Specifically, the for loop in the printDirectors function (which is printEmployees in the README).
In this example, which is clearly derived from the README (meaning the original error is actually there), the printf line in the for loop says:
    printf "    - %s\n" ${!director}
This line is missing quotes around the variable, which makes printf see it as two separate %s candidates. It should be written like this:
    printf "    - %s\n" "${!director}"
Interestingly, this is done correctly in the example.sh file, though not so in the README.md file. (@kristopolous might want to fix that, if this project is still being maintained).


fix(verifybundle): ignore name-check for dashboard_widget

See https://jira.dhis2.org/browse/HUB-123
The check might look a bit weird, but I did not want to introduce a requirement for manifest.appType, even though it should be in the manifest. It's either that or a check like if (manifest.name !== appName) && !manifest.appType || (manifest.appType && manifest.appType !== 'DASHBOARD_WIDGET'). If you have a better solution please give feedback.

Having the check as a nested if is fine with me 👍
However isn't manifest.appType && manifest.appType === 'DASHBOARD_WIDGET' equivalent to manifest.appType === 'DASHBOARD_WIDGET'?

Yes, of course. I wrote the condition as !== first, so that just remained. Thanks!


Update tests with expected_dict

It seems that pyflakes has problem with last expected_dict for link css, where the dict has 4000 lines because of file turret-road-Regular.tff

I've reseted last two commits.


videocontext manager with tests

Motivation
This is a PR isolating the creation of a Context Manager for video files and its corresponding tests.
This would then be integrated with MovieDataInterface in a separate pr #372

@Saksham20 For the tests/CI, I recommend using lazy import/skip for the cv2 dependency

@Saksham20 For the tests/CI, I recommend using lazy import/skip for the cv2 dependency

I prefer to add cv2 installation in the tests' workflows

Its better to add cv2 installation in the tests' workflows then

No; those are built fundamentally to mimic the environment of fellow developers to avoid issues with the minimal install. Note that the cv2 is already in the full requirements: https://github.com/catalystneuro/nwb-conversion-tools/blob/main/requirements-full.txt#L12
So this is purely a minimal install issue; I'd remove those lines you changed to the workflows, and add the lazy type of import that the existing movie tests have so that these tests are only triggered in the second half of the workflow. I'd recommend utilizing @pytest.mark.skip(logical_triggger, reason="OpenCV is not installed!") for this.

PR is really starting to take shape... still To-Do

@Saksham20 You can and should also reference the full coverage report for this class to identify gaps in coverage: https://app.codecov.io/gh/catalystneuro/nwb-conversion-tools/blob/add_context_class_pre_pr/nwb_conversion_tools/datainterfaces/behavior/movie/movie_utils.py

[ ] There are a lot of lines that would be hard to cover due to opencv versions; what you can do for all those lines that work on non-v3, you can add a comment # pragma: no cover which will manually exclude them from coverage reports

[ ] Variable names and other references using no to mean number, would be much more verbose to replace all these with the full English number.

There are a lot of lines that would be hard to cover due to opencv versions; what you can do for all those lines that work on non-v3, you can add a comment # pragma: no cover which will manually exclude them from coverage reports

It might be neater to include a configuration file, so we don't have to write anything in the code https://github.com/catalystneuro/nwb-conversion-tools/pull/392/commits/e1aa9f61e6419f550d1dba62501a0d7c46f02f5b.
I think

There are a lot of lines that would be hard to cover due to opencv versions; what you can do for all those lines that work on non-v3, you can add a comment # pragma: no cover which will manually exclude them from coverage reports

@CodyCBakerPhD It might be neater to include a configuration file, so we don't have to write anything in the code https://github.com/catalystneuro/nwb-conversion-tools/commit/e1aa9f61e6419f550d1dba62501a0d7c46f02f5b.

Discussed with ben and made a few changes https://github.com/catalystneuro/nwb-conversion-tools/pull/392/commits/1fc8322754474fbdf3a5cb554d108f0a0e3cf85c
# pragma: no cover is needed only on one line instead of three.
I think, for now it does not make sense to have a separate config file just to tweak the codecov report for this file.
@CodyCBakerPhD do you see other places we may need to change to codecov report?

@CodyCBakerPhD do you see other places we may need to change to codecov report?

There's a couple but they are pretty minor so they can be added later. The static method for general attribute retrieval was a good idea.
Last two things to do with this PR are

[ ] Investigate timestamp value return to figure out the correct method; also with multiple different video formats (I'm working on this as well)
[ ] Investigate how the frame 'seeking' method performs on various formats; the original idea was that for difference-based codecs (that base their compression/decompression off of differenced value of consecutive frames) seeking might require them to "un-difference" the frames up to the seek point, thus leading to sub-optimal performance. Would just be good for us to know when recommending or utilizing this feature. Could you work on that while I dig further into the timestamps?

@Saksham20 Also, this is at a good enough point to where you can update #372 to rely on this. You can also develop a PR branching from this that introduces the movie data chink iterator as a stand-alone feature (again with unit tests) prior to integration with the data interface.

@Saksham20 Also, this is at a good enough point to where you can update #372 to rely on this. You can also develop a PR branching from this that introduces the movie data chink iterator as a stand-alone feature (again with unit tests) prior to integration with the data interface.

I have updated #372 to be a PR to this branch instead. Merged this into that and the tests of MovieDataInterface pass.

@Saksham20 Thanks for working hard on this - I'm being extra particular about having this kind of stuff polished because it's likely to be used not just for writing to NWB but also, in conjunction with the new external link capability on DANDI, for all side-by-side video management.


Error in xcode 12.5

I am getting the following error since upgrading xcode to 12.5
"Failed to build module 'PayUCheckoutProKit' from its module interface; the compiler that produced it, 'Apple Swift version 5.2.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)'"

Can you try this?


[AIRFLOW-3434] Allows creating intermediate folders in SFTPOperator

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3434

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
This PR adds the feature to create the intermediate directories when copying to/from the remote host.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
test_file_transfer_no_intermediate_dir_error_put
test_file_transfer_with_intermediate_dir_error_put
test_file_transfer_no_intermediate_dir_error_get
test_file_transfer_with_intermediate_dir_error_get

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes flake8

Codecov Report

Merging #4270 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4270   +/-   ##
=======================================
  Coverage   78.08%   78.08%
=======================================
  Files         201      201
  Lines       16458    16458
=======================================
  Hits        12851    12851
  Misses       3607     3607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bd7c6...57a6624. Read the comment docs.


NNBD: Dart allows named function argument of non-nullable type without default value

Dart VM version: 2.8.0-edge.aadcb4418b1a7ccbb74a7cc925ad55020ce4a924 (Thu Feb 6 02:00:49 2020 +0000) on "linux_x64"
The following source code throws a compile error with analyzer and passes with dart:
class B {
  void test_nondefault({int i})     {}
}

main() {}

Seems like compile error should be thrown with dart too.
Sample output is:

$  dartanalyzer --enable-experiment=non-nullable test.dart
Analyzing test.dart...
error • The parameter 'i' can't have a value of 'null' because of its type, so it must either be a required parameter or have a default value. • test.dart:2:29 • missing_default_value_for_parameter
1 error found.
$  dart --enable-experiment=non-nullable test.dart
$

The CFE currently only produces nnbd-specific warnings and error behind a special `--force-nnbd-checks' flag.
To check foo.dart in weak mode run:
dart pkg/front_end/tool/fasta.dart compile --enable-experiment=non-nullable --force-nnbd-checks foo.dart

and to check foo.dart in strong mode run:
dart pkg/front_end/tool/fasta.dart compile --enable-experiment=non-nullable --force-nnbd-checks --nnbd-strong foo.dart

where pkg/front_end/tool/fasta.dart is in the Dart repo.
This generates a foo.dart.dill file next to foo.dart which can be run with the VM using
dart foo.dart.dill

The flag will be removed once it is not blocking development on the nnbd sdk due to false positives.

Closing the issue, as the check is implemented under --force-nnbd-checks flag.


V2 update request

Can I please request an update on this plugin to support V2 - this has become one of most favourite plugins so would be a shame to loose it - kudos to original developer!

See https://github.com/Snakey42069/homebridge-actronair/pull/6 and associated comments


(48,5) compilation fails

Thank you for implementing the missing bits for the 48,5 version!
Unfortunately, make eq485 throws the following errors:
g++ -march=native -m64 -std=c++11 -Wall -Wno-deprecated-declarations -D_POSIX_C_SOURCE=200112L -O3 -pthread  -DATOMIC -DWN=48 -DWK=5 -DRESTBITS=0 equi_miner.cpp blake/blake2b.cpp -o eq485
In file included from equi_miner.cpp:4:0:
equi_miner.h: In member function ‘void htalloc::alloctrees()’:
equi_miner.h:304:5: error: static assertion failed: needed to ensure hashes shorten by 1 unit every 2 digits
     static_assert(DIGITBITS >= 16, "needed to ensure hashes shorten by 1 unit every 2 digits");
     ^~~~~~~~~~~~~
equi_miner.h: In member function ‘void equi::digit0(u32)’:
equi_miner.h:652:11: error: expected ‘,’ or ‘;’ before ‘const’
           const u32 slot = getslot0(bucketid);
           ^~~~~
equi_miner.h:653:15: error: ‘slot’ was not declared in this scope
           if (slot >= NSLOTS) {
               ^~~~
equi_miner.h:658:43: error: ‘slot’ was not declared in this scope
           htunit *s = hta.heap0[bucketid][slot] + htl.nexthtunits;
                                           ^~~~
equi_miner.h: In member function ‘void equi::digitodd(u32, u32)’:
equi_miner.h:707:11: error: expected ‘;’ before ‘const’
           const u32 xorslot = getslot1(xorbucketid);
           ^~~~~
equi_miner.h:708:15: error: ‘xorslot’ was not declared in this scope
           if (xorslot >= NSLOTS) {
               ^~~~~~~
equi_miner.h:713:51: error: ‘xorslot’ was not declared in this scope
           htunit *xs = htl.hta.heap1[xorbucketid][xorslot];
                                                   ^~~~~~~
equi_miner.h:687:24: warning: unused variable ‘bytes0’ [-Wunused-variable]
           const uchar *bytes0 = slot0->bytes, *bytes1 = slot1->bytes;
                        ^~~~~~
equi_miner.h:687:48: warning: unused variable ‘bytes1’ [-Wunused-variable]
           const uchar *bytes0 = slot0->bytes, *bytes1 = slot1->bytes;
                                                ^~~~~~
equi_miner.h: In member function ‘void equi::digiteven(u32, u32)’:
equi_miner.h:761:11: error: expected ‘;’ before ‘const’
           const u32 xorslot = getslot0(xorbucketid);
           ^~~~~
equi_miner.h:762:15: error: ‘xorslot’ was not declared in this scope
           if (xorslot >= NSLOTS) {
               ^~~~~~~
equi_miner.h:766:51: error: ‘xorslot’ was not declared in this scope
           htunit *xs = htl.hta.heap0[xorbucketid][xorslot];
                                                   ^~~~~~~
equi_miner.h:742:24: warning: unused variable ‘bytes0’ [-Wunused-variable]
           const uchar *bytes0 = slot0->bytes, *bytes1 = slot1->bytes;
                        ^~~~~~
equi_miner.h:742:48: warning: unused variable ‘bytes1’ [-Wunused-variable]
           const uchar *bytes0 = slot0->bytes, *bytes1 = slot1->bytes;
                                                ^~~~~~
make: *** [Makefile:26: eq485] Error 1

make all compiles without a problem.
I use Arch Linux with gcc version  6.3.1 20170306

dear Sebastian ,

Thank you for implementing the missing bits for the 48,5 version!
Unfortunately, make eq485 throws the following errors:
g++ -march=native -m64 -std=c++11 -Wall -Wno-deprecated-declarations -D_POSIX_C_SOURCE=200112L -O3 -pthread  -DATOMIC -DWN=48 -DWK=5 -DRESTBITS=0 equi_miner.cpp blake/blake2b.cpp -o eq485
In file included from equi_miner.cpp:4:0:
equi_miner.h: In member function ‘void htalloc::alloctrees()’:
equi_miner.h:304:5: error: static assertion failed: needed to ensure hashes shorten by 1 unit every 2 digits

I got mine working with RESTBITS=4 rather than 0,
which I believe is a much better choice.
Can you grab the latest version from my github and try again?
regards,
-John

It works now, thank you! I checked out the wrong branch I guess...


[Augmentations] No error in the analyzer if introductory and augmenting constructors have super initializers

Feature specification

It is a compile-time error if:
...

The introductory constructor has a super initializer (super constructor invocation at the end of the initializer list) and the augmenting constructor does too.

Expected error below are not reported.
class A {
  int x;
  A(this.x);
}

class C extends A {
  int y;
  int z = 0;
  C(int x, int y): this.y = y, super(x);
}

augment class C {
  augment C(int x, int y): z = 1, super(x);
//                                ^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}

Duplicate of #59631


K.gradients return None over a layer.output or layer.input (except model input)

Hello,
I am trying to get activations and their gradient for each trainable layer output.
However, the function returns me a None tensor.
model.optimizer.get_gradients(model.total_loss, layer.output)
or
K.gradients(model.total_loss, layer.output)
Can you help me please ?

It works also with the dense layer
[<tf.Tensor 'gradients_44/vgg16_1/block1_conv1/convolution_grad/Conv2DBackpropInput:0' shape=(?, ?, ?, 3) dtype=float32>, None, None, None, None, None, None, None, None, None, None, None, None, <tf.Tensor 'gradients_44/dense_1_1/MatMul_grad/MatMul:0' shape=(?, 512) dtype=float32>]
But every from the CNN gets a None tensor

Ok I was able to access the gradients but this error should be corrected.
Here is my solution
I have two models with the same layers but one as some wrapped into a model.
First, ['input_2', 'vgg16', 'dense_2']
Two, ['input_1',
'block1_conv1',
'block1_conv2',
'block1_pool',
'block2_conv1',
'block2_conv2',
'block2_pool',
'block3_conv1',
'block3_conv2',
'block3_conv3',
'block3_pool',
'block4_conv1',
'block4_conv2',
'block4_conv3',
'block4_pool',
'block5_conv1',
'block5_conv2',
'block5_conv3',
'block5_pool',
'global_average_pooling2d_2',
'dense_2']
I train with the wrapped, save the weight then put them into the linear one using the followings functions
from keras.models import Model
def get_layer_rec(model, layer_name):
out_layer = None
for layer in model.layers: #order_layers(model.layers):
if isinstance(layer, Model):
out_layer = get_layer_rec(layer, layer_name)
else:
if layer.name == layer_name:
out_layer = layer
return out_layer
def insertSymbolic(model, modelSymbo):
layers_errors = []
for layer in modelSymbo.layers[1:]:
try:
name = layer.name
layer_ref = get_layer_rec(model, name)
layer.set_weights(layer_ref.get_weights())
except:
layers_errors.append(name)
return modelSymbo, layers_errors

This seems to be the same thing
https://github.com/rstudio/keras/issues/472#issuecomment-405234380
would anyone have any news regarding this issue?


Planner should support color keywords, not just hex

Example
Assigning a CSS color keyword like black instead of #000000 to color throws error:

Expected Behavior

If color's value doesn't begin with a #, compare it to a dictionary of CSS colors.
If not in the dictionary, either throw error or use "transparent" (your choice).
If in the dictionary, use that keyword for the color.

Totally understand why this would be a nice  convenience feature- but it’s a hard limitation currently because of how my color highlighting (on hover) and contrast (foreground vs background color determination) works. I’d like to avoid having to hardcode a long list of CSS color names. (I think there are well over 100 of them?)

The browser itself could confirm whether or not the keyword is a valid
color like so:
https://stackoverflow.com/questions/48484767/javascript-check-if-string-is-valid-css-color

Message ID: @.***>

It’s not about confirmation- but rather, how to covert a color name to an rgb value (so I can calculate contrast).

What about getComputedStyle()?
https://stackoverflow.com/questions/1573053/javascript-function-to-convert-color-names-to-hex-codes/24390910

Oh, nice! That looks like it could work then as a fallback for non-hex colors.


[token-2022] Vulnerable dependencies (TOK-STK-3)

Description
The result from the cargo audit command shows there is one crate (time) with a known vulnerability.
❯ cargo audit
Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 458 security advisories (from /Users/andershelsing/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (651 crate dependencies)
Crate:     time
Version:   0.1.44
Title:     Potential segfault in the time crate
Date:      2020-11-18
ID:        RUSTSEC-2020-0071
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
Solution:  Upgrade to >=0.2.23

Recommendations
Short term, triage the use of the vulnerability in the time crate, and upgrade to a version where it is patched.

Looks like this was actually fixed awhile back! But I can't find the PR that did it. It was definitely before we removed the audit ignore with #7113


Part 5 (arm9loaderhax & Luma3DS)

Small typo in Section I - Preparatory work; line 15

In the /luma/payloads folder, rename arm9loaderhax.bin to x_Uncart.bin

What typo are you talking about...?

Shouldn't Uncart.bin be renamed to x_Uncart.bin and arm9loaderhax.bin be placed as is to the root of the SD card?

Seeing it, too, now... Should arm9loaderhax.bin be renamed to x_Uncart.bin? If this is correct, I missed something.

It's fine as-is. The arm9loaderhax.bin file from the Uncart zip should be renamed and placed in the payloads folder.


Add a 'task must be present' rule for pipelines

This was added quickly as a potential demo for how pipeline
validation could work.
I'm not sure if matching the taskRef name is a secure approach in
the long term, but it might be a good starting point.

I tidied it up, gave it some extra tests, and removed "configure-build" from the list since it seems like it didn't belong.

I'll stop tweaking it..


MOVED ERROR when  increasing shards in existing redis cluster

We call below function
redisClusterAppendCommand which calls lua script and sets and gets stuff from redis.
and then call redisClusterGetReply(cntxt, &reply).
Our code continously executes both functions... Now during above process, we increased number of shards in our existing redis cluster. Then we observed during scaling, we saw below error on printing reply:
reply->type and reply->str came out to be REDIS_REPLY_ERROR and MOVED IP Address:port respectively.
Since clients dont need to care about internal nodes/shards, should the hirendis-vip handle it like retrying to moved node? Need help on this.
NOTE: We are using hirendis-vip
If above issue is fixed in hiredis-cluster, let me know.

Hi!

Since clients dont need to care about internal nodes/shards, should the hirendis-vip handle it like retrying to moved node? Need help on this.

Yes, hiredis-cluster handles the MOVED redirects, updates the slot-to-node mapping and retries the command automatically. The user doesn't need to care about this and should not see the MOVED redirect.

NOTE: We are using hirendis-vip
If above issue is fixed in hiredis-cluster, let me know.

I don't know all the problems of hiredis-vip but we have improved many things. It's better that you try the latest version of hiredis-cluster and check if the problem is still there. If there is still a problem in hiredis-cluster, we can try to fix it.

We checked and it is problem with the latest client also. Exactly Same MOVED error.

Interesting.
How do you call the EVAL command with arguments? Hiredis-cluster is using the first key in the EVAL command to send the command to the right node.
What is the contents of the Lua script?

"EVAL %s 1 %s %b %d %d %s %d" (first %s is uuid)
Above is what we are evaulating
Below is lua script
"local status = redis.call('SET', KEYS[1], ARGV[1] .. '&%#' .. ARGV[2] .. '&%#' .. ARGV[3] .. '&%#' ..  I think there is no problem in the Lua script. I can see you call EVAL with one key and KEYS[1] is used for the key in the script. That's good.
I found out now that redisClusterAppendCommand + redisClusterGetReply does not follow MOVED-redirects. I'm sorry I didn't find out before.
The workaround is to use redisClusterCommand. It follows MOVED-redirects automatically. Another possibility is to use the async API.
We can to look at how we can implement redirect handling for redisClusterGetReply in the future, but there is no plan right now.

ok ok got it... Hoping to see it some day in future.
Just two questions:

We are calling redisClusterAppendCommand for 100 messages, 100 times and then calling redisClusterGetReply and listening for 100 messages. So let us suppose we shift to redisClusterCommand. We will be calling redisClusterCommand for each of the 100 messages one by one. So question is, that might increase total run time right? if no, then other drawback of redisClusterCommand?

cluster_update_route is not exposed right? how to use it?

Yes, redisClusterCommand is slower because it waits for each reply before you can send the next command. Pipelining is faster.
If you do 100 redisAppendCommand and 100 redisClusterGetReply, you can keep track of which commands failed and retry only those commands after update route. It is more complicated but it will be faster.

cluster_update_route is internal but it is exposed in the .h file. You can call it with the cluster context cc as cluster_update_route(cc) and the return value is REDIS_OK or REDIS_ERR.

We tried doing cluster_update_route(cc) but seems like it didn't work. Errors were still there. What exactly it does cluster_update_route?

Implementing redirects for the pipeline API seems like it's not strait-forward. Currently it is not planned.
Have you considered using the async API? It is very efficient and it handles redirects and updates slot mapping in the background.


Implement safe int counter vec as IntCounterVec<const N:usize>

Description
Per title.
How was this PR tested?
The compiler is doing all the work :)

Ah cool. This will save us time and trouble.


NO-JIRA: Add net policy to allow ingress from sharedingress namespace

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm

/retest


Introduce galley/pkg/server

galley/pkg/server implements logic performs both CRD synchronization, along with resource synchronization operations. The resource synchronizers are started/stopped as CRDs (of interest) are added/deleted.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: xiaolanz
Assign the PR to them by writing /assign @xiaolanz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c0bbdad4727be27ab8b620065de7ac38f05b6bd0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
c92b94886630765acf8538f421253610aacc4271
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xiaolanz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [xiaolanz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Not sure why racetest failed with these. Might be flaky.
=== RUN   TestValidatorCacheDoubleEdits/put-put-1
2018-04-18T17:27:03.400455Z	info	Publishing 1 events
=== RUN   TestValidatorCacheDoubleEdits/put-put-2
2018-04-18T17:27:03.438553Z	info	Publishing 1 events
2018-04-18T17:27:03.448653Z	info	Publishing 1 events
=== RUN   TestValidatorCacheDoubleEdits/put-put-3
2018-04-18T17:27:03.463805Z	info	Publishing 4 events
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x1768fa7]
goroutine 95 [running]:
istio.io/istio/mixer/pkg/runtime/validator.(*validatorCache).applyChanges(0xc420ca4340, 0xc420f46000, 0x4, 0x32)
/go/src/istio.io/istio/mixer/pkg/runtime/validator/validatorcache.go:46 +0x147
istio.io/istio/mixer/pkg/runtime/validator.(*validatorCacheTestController).applyChanges(0xc4205fe7e0, 0xc420f46000, 0x4, 0x32)
/go/src/istio.io/istio/mixer/pkg/runtime/validator/validatorcache_test.go:74 +0x6c
istio.io/istio/mixer/pkg/runtime/validator.(*validatorCacheTestController).(istio.io/istio/mixer/pkg/runtime/validator.applyChanges)-fm(0xc420f46000, 0x4, 0x32)
/go/src/istio.io/istio/mixer/pkg/runtime/validator/validatorcache_test.go:64 +0x60
istio.io/istio/mixer/pkg/config/store.WatchChanges(0xc42056e000, 0xc420698300, 0xf4240, 0xc420c2e0e0)
/go/src/istio.io/istio/mixer/pkg/config/store/listener.go:67 +0x2a5
created by istio.io/istio/mixer/pkg/runtime/validator.newValidatorCacheForTest
/go/src/istio.io/istio/mixer/pkg/runtime/validator/validatorcache_test.go:64

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
bb9b8ebb02c3cbc8d2f25382cd28b697ddcee938
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.