proposal: Go 2: remove bare return

(I couldn't find an existing issue for this, so please close if this is a duplicate and I missed it.)
I propose getting rid of bare returns. Named return values are great, keep those. Bare returns are more trouble than they are worth, eliminate them.

I would be against this change, for a few reasons.

It's a relatively significant syntactic change. This could cause confusion with developers and contribute to leading Go into the same mess that Python went through.

Simplicity beats verbosity. A bunch of return nil are a lot easier to understand than a bunch of return where one has to chase the latest value of the variable and make darn sure it hasn't been shadowed (intentionally or by mistake.)

Note that naked returns allow you to do one thing you cannot otherwise accomplish: Change a return value in a defer. Quoting the code review comments wiki:

Finally, in some cases you need to name a result parameter in order to change it in a deferred closure. That is always OK.

A complete proposal to eliminate naked returns should explain how such uses should be written instead and why the alternative form is preferable (or at least acceptable). The obvious rewrites tend to involve lots of boilerplate and repetition, and while they usually involve error handling, the mechanism is general.

I don't think this
func oops() (string, *int, string, error) {
    return "", nil, "", &SomeError{err}
}

is more readable than
func oops() (rs1 string, ri *int, rs2 string, e error) {

    e = &SomeError{err}
    return
}

,sorry.

 I would not make sense to outlaw it outright (generated code comes to mind), but I would gladly vote for at least prohibition of return values names shadowing. Oh, and make compiler generate some diagnostic in all other cases would be nice too :)

@josharian I was assuming that deferred functions could still modify the return variables. That semantic seems more or less orthogonal to the syntax of the return statement.

@josharian You need named return parameters to be able to modify them in a deferred function. You do not need to use a naked return for that. return with explicit values will copy the values into the named return values before the deferred functions run.

@bcmills @dominikh right, silly me. Mental lapse; thanks for setting me straight.

A func without return values should still be able to a "bare" return:
func noReturn() {
    if !someCondition() {
        return // bail out
    }
    // Happy path
}

I spent 1.5 minutes staring at the following Go code in Go standard library, in disbelief, thinking there might be a bad bug:
https://github.com/golang/go/blob/2d69e9e259ec0f5d5fbeb3498fbd9fed135fe869/src/net/http/server.go#L3158-L3166
Specifically, this part:
tc, err := ln.AcceptTCP()
if err != nil {
	return
}

At first glance, it looked to me that on the first line there, new variables tc and err were being declared using short variable declaration syntax, distinct from the named err error return variable. Then, it looked to me that the bare return was effectively returning nil, nil rather than than nil, err as it should've been.
After about 90 seconds of thinking very hard about it, I realized that it's actually correct code. Because the named err error return value is in the same block as the function body, the short variable declaration tc, err := ... only declares tc as a new variable but does not declare a new err variable, so the named err error return variable is being set by the call to ln.AcceptTCP(), so the bare return actually returns a non-nil error as it should.
(Had it been in a new block, it would actually be a compile error "err is shadowed during return", see here).
I think this would've been much more clear and readable code:
tc, err := ln.AcceptTCP()
if err != nil {
	return nil, err
}

I wanted to share this story because I think it's a good example of bare returns wasting programmer time. In my opinion, bare returns are marginally easier to write (just saving a few keystrokes), but often lead to code that's harder to read compared to equivalent code that uses full returns (non-bare). Go usually does the right thing of optimizing for reading, since that's done much more often (by more people) than writing. It seems to me that the bare returns feature tends to lower readability, so it might be the case that removing it in Go 2 would make the language better.

Bare returns works great for defer calls, due of their nature to reflect changes in variables after declaring the defer call

@shurcooL, interesting example that also threw me off. For me it was the fact that there're two connection variables tc and c. I thought you made a mistake when copy-pasting the code and instead of c there should be tc. It took me about the same time to realize what that code does.

This is probably relevant:
https://blog.minio.io/golang-internals-part-2-nice-benefits-of-named-return-values-1e95305c8687
And the associated discussion:
https://news.ycombinator.com/item?id=14668323

From the article:

Note that if you don’t like or prefer the naked return that Golang offers, you can use return oi while still getting the same benefit, like so:

Named return values are great! Bare return of named return values are the problem. :-)

@awnumar, that is not relevant. See my comment on Hacker News: https://news.ycombinator.com/item?id=14668595

I wish to see some examples to demonstrate how bad bared return could be.

@kelwang Did you see my example about ln.AcceptTCP() from 7 comments above?

Hi, @shurcooL, thx
Yeah, I think you made a great point.
But like you said, it's been 4 years. I have a feeling maybe you already get used to it.
I think it's not really an issue for bared return. But a confusion in multiple vars initialization.
For me, the shadow vet tool usually works very well. I never really worry about that.
Maybe we should fill a ticket in go linter to avoid those kind of confusion. whether rename the err, or declare tc on top first. I feel a linter suggestion should be good enough.

@kelwang In my opinion, if a function has multiple returns to the point where the return statements are getting ugly, a struct should be returned instead over a bare return.

Since #377 has been mentioned, I would argue that the source of confusion in the ln.AcceptTCP example is more about the magic behind := rather than the bare return itself.
I think the ln.AcceptTCP case wouldn't be so bad with a more explicit form of short declaration:
func (ln tcpKeepAliveListener) Accept() (c net.Conn, err error) {
    :tc, err = ln.AcceptTCP()
    if err != nil {
        return
    }
    // ...
}

By just looking at a multi-variable := you can't tell which variables are being declared: you need to take into account all the preceding part of the block to know that.
An oversight about where the block boundary is, and you may end up with an hard to find bug.
Also you can't fix a multi-variable := to make it declare exactly what you want; you are forced to give up the short declaration or reorganize the code.
I've seen many proposal trying to address specific consequences of this, but I think the root of the problem is just the lack of explicitness of := (I would also argue that, whenever shadowing is considered a pitfall, it is really just multi-variable :='s fault).
I'm not saying that bare returns are necessarily worth it, I'm just saying that what we are seeing is a compound problem.

Regardless of the readability arguments, I think the bare return is less logically consistent and elegant. It's somehow a shaky standpoint. Although, obviously I'm not the only one being subjective here.

@tandr I think returning a small struct object is much more clear than having more than three return values.

Alternative to a purely bare return:
func f() (e error) {
   return ... // elipsis symbol
}

While I'm in favor of removing it in Go2, I made #28160 to (essentially) remove it in Go1 via gofmt.  Folks comments there would be appreciated! 😄

I have found naked returns to be surprisingly helpful in DB layer.
This is a real redacted production code -
func (p *PostgresStore) GetSt() (st St, err error) {
	var tx *sql.Tx
	var rows *sql.Rows
	tx, err = p.handle.Begin()
	if err != nil {
		return
	}
	defer func() {
		if err != nil {
			tx.Rollback()
		} else {
			tx.Commit()
		}
		rows.Close()
	}()

	rows, err = tx.Query(`...`)
	if err != nil {
		return
	}
	// handle rows
	for rows.Next() {
		var all Call
		err = rows.Scan(&all.Email, &all.Count)
		if err != nil {
			return
		}
		st.Today = append(st.Today, &all)
	}

	rows.Close()
	rows, err = tx.Query(`...`)
	if err != nil {
		return
	}
	// handle rows
	for rows.Next() {
		var all Call
		err = rows.Scan(&all.Email, &all.Count)
		if err != nil {
			return
		}
		st.Books = append(st.Books, &all)
	}
	return
}

There are 6 return statements here. (Actually there are 2 more, I just shortened the code for brevity). But my point is when an error occurs, the caller will only inspect the err variable. If I just had to write return err, I would still be okay, but to match the return signature, I have to write return st, err over and over again. And this grows linearly if you have more variables to return; your return statement keeps growing bigger and bigger.
Whereas, if there are named return params, I just call return, knowing that it will also return any other variables in whatever state they were. This makes me happy and I consider it to be a great feature.

@agnivade not sure if this is because its redacted but it looks like your code production code would panic in the defer if rows is nil which would occur if the query failed.

@agnivade five of your six returns should evaporate under the forthcoming Go2 error handling scheme :-)
More on the feedback wiki.

@nhooyr - Oh dear .. looks like we are doing a prod push today .. :man_facepalming: :sweat_smile:
@networkimprov -  That's true. I hadn't thought of the new error handling. Personally, I would be okay with this when the new error handling lands. But even then I think this is a pretty major change which is bound to break a lot of codebases. Arguably, we can fix this with automated tooling. But I wonder how many of these major changes should be make for Go 2.

Go2 is given license to not be backward compatible with Go1, is it not?
I agree that tooling could be made to upgrade existing Go1 go to be compatible with this change in Go2.

Go2 is given license to not be backward compatible with Go1, is it not?

It's almost certain we won't use said license. Breaking backwards compatibility is incredibly difficult and risky ecosystem-wise.

If breaking changes aren't currently planned, I'd agree this proposal isn't worth causing a break.  I hope we consider the proposal if/when breaking changes are planned.  Updating go fix to accommodate this proposal should be trivial.

New keywords are on the table for Go2 error handling, and that would break some code.

For Go 2 we can break code when it is worth it, but it carries a heavy cost.  The cost of a new keyword is less than the code of removing a language feature, in that it is straightforward to diagnose and fix.  It's possible to imagine that the benefit of the new keyword would exceed the cost of having to slightly rewrite code that uses an identifier that is the same as the keyword.
This case is harder to rewrite than a new keyword, but it's feasible.  I think the most important question is: do people misunderstand what it means when they write a naked return?  Are there real bugs in programs due to the use of a naked return?  Even if there aren't real bugs, when people are writing code, do they make mistakes by using a naked return incorrectly?

I get paranoid about shadowed err working in an unexpected way

I just found out recently that you actually don't need to worry about the shadowing as much as I thought. It's actually a compile-time error to use a bare return if any of the return variables are shadowed at the point that the return happens.

#28160 has been closed, which seems to me to close the door on fixing this in Go1.

Well, this kind of change was never going to happen in Go 1 anyhow, no matter how one approached it.

Maybe, maybe, the problem is in :=, and we should have proposal to remove it.

This isn't just about shadowing.  It's about making the reader carry more context than necessary.
Using the code example here: https://github.com/golang/go/issues/21291#issuecomment-320120637
In the first example, the reader knows exactly what's returned with only having to trace the value of err.
In the second example, the reader would need to trace the values of three additional variables.
Put another way
if err != nil {
	return err
}
...
return err

vs
if err != nil {
	return err
}
...
return nil

(returning a variable with a value nil vs returning nil)
Which do you prefer?
I prefer the latter because it's explicit and easier to understand at first glance.  Removing bare returns would encourage explicit return values instead of encouraging return values that must be deduced.

This is my exact thought when start reading a Go code base.
The short version should be nice for hackers who want to code fast, do trick with the syntax here and there and poison the victim computer.
But in term of enterprise application, few keystrokes saving may cost you millions to detect

I love bare returns because they save me a lot of typing and initialization of empties. With appropriate syntax highlighting it's super easy to spot what's a new variable and what's coming from the signature (in "pink"):

So I encountered some sample code with no return at all from 2017.  With go 1.12.5 (windows/amd64), this is flagged on go build as a missing return.  Is this the same issue? Were implicit returns allowed in the past and now invalid?  I couldn't fix it with a bare return.  The type was uintptr so I returned 0 (nill would not lint).

@datatribe, I can't think of any change that would change that. It has ways been an error to miss a return. File a new bug with the details?

@datatribe, I can't think of any change that would change that. It has ways been an error to miss a return. File a new bug with the details?

It's entirely possible the example code was no good.  Thanks @bradfitz

I'm not sure if it causes production bugs, but for me, when I see naked return, it usually makes me pause to try to figure out what's happening. I get paranoid about shadowed err working in an unexpected way because I'm not 100% confident in my understanding of how they interact. It makes reading the code much slower.

I agree with you on that. It makes me pause to try to figure out what values are assigned to the named parameter variables. My discomfort reading (especially long) functions with naked returns is that I can't follow easily what are actually returned. Each naked return actually means return p1, p2, ..., pn for named parameters, but sometimes the values of some parameters are obviously literal like return nil, nil, return nil, err, return "", err and return p, nil rather than return p, err. If I write return nil, err, err still might be nil value, but it's clear that the first return value is nil. If naked return is disallowed, the writer would more likely to write literal values in return statement if that's possible. Actually they all did use literal values, when I asked them to avoid naked returns during the code reviews.
When writers write in naked returns, they tend not to think about what are returned. When I asked them to avoid naked returns, now they think about the actual value they want to return and notice that they were returning wrong values like partially constructed values. Isn't being explicit better than implicit?
I know it's recommended to indent error flows but not everyone follows this pattern in reality, especially folks who like to write long functions with lots of naked returns. Sometimes, it's hard to know if it's in an error flow or not by looking many naked returns. I read the code carefully decode it and convert naked returns to non-naked with some literal values, then it's much easier to read. (sometimes it's not possible to figure out the literal values if the code is complex)
I know the documentation comment block mentions what it returns for some meaningful conditions, but not everyone does that. With return statement with some literal values, I can follow that easily by looking at the code.
I know we can use named parameters and non-naked returns together, but not everyone knows that. I often see something like the following, and I think return io.EOF is better.
err = io.EOF
return

That said, I think #28160 is probably a better fix since it's backward compatible and gofmt has already had several minor changes.

I disagree on the other proposal that gofmt should put them back, even if that's gofmt's job. That's because just putting bunch of return p1, ..., pn mechanically won't make the code more understandable.
It's possible that lint tools can check it (nakedret does that), but IMO, naked return has more harm than benefits. I also agree that the benefit of removing naked return may be smaller than the harm breaking the compatibility. But I guess it's easy to fix with go fix even if mechanical go fix won't make the code readable.
Go is very clear and readable language in my opinion. And naked return is a small part of the language that makes me hard to understand the code.

I may be in the minority, but I'd actually like to propose the opposite. Functions with named returns should always use bare return. Otherwise, it just looks like the code is lying. You assign values and then potentially silently overwrite them upon return. Here is a bad piece of code to illustrate what I mean,
func hello() (n, m int) {
    n = 2
    m = 3
    return m, n
}

If you'd just use a bare return there, the code makes sense again.

@millerlogic I think that would be far too agressive. For example, there's nothing wrong with code like:
func documentedReturns() (foo, bar string, _ error) {
    [...]
    if err != nil {
        return "", "", fmt.Errorf(...)
    }
}

I also think your point might fit best as a separate counter-proposal, since you're suggesting the opposite of what the current proposal brings forward.

@mvdan Good point, I think there is a middle ground which doesn't involve demonizing them. I think I read an idea similar to: not explicitly returning a value if you previously assigned to the return variable. It might even be implemented somewhere, but I never hit it. So that would mean my hello example would error without a naked return, and your example would succeed because foo or bar weren't assigned to.

I think these should be removed from the tour of go, that way newer go developers aren't encouraged to use these. In practice they're just a cognitive tax. The few I've seen always required my brain to say "wait what?!...oh yeah, naked returns and named return values"

This is an example from "The Forgotten Art of Structured Programming". Of course, there are better ways to implement such a function but I find the argument for structured programming compelling.
func IsLeapYear(year int) (result bool) {
	if year%400 == 0 {
		result = true
	} else if year%100 == 0 {
		result = false
	} else if year%4 == 0 {
		result = true
	} else {
		result = false
	}
	return
}

This is an example from "The Forgotten Art of Structured Programming". Of course, there are better ways to implement such a function but I find the argument for structured programming compelling.
func IsLeapYear(year int) (result bool) {
	if year%400 == 0 {
		result = true
	} else if year%100 == 0 {
		result = false
	} else if year%4 == 0 {
		result = true
	} else {
		result = false
	}
	return
}

From some viewpoint the naked return can be considered as an alternative implementation of  out variables in other languages. On callee side they used in a very similar way as out variables. And on caller side, it even better than in other languages, cause leverage Go capability to return multiple values to the caller.  So, if think about them in this way it can help to adjust to it. I think the confusion introduced by the term naked return. I don't think it is good name for this conception. I personally don't like overall situation as for this feature in Go language. It need force something :) My personal opinion that it has sense to force explicit assignment to the named return variables in the function body to avoid unexplicit nil values for them.

so.. variable shadowing is the problem, but named return values + naked return got to blame..

This is actually the one situation where shadowing is rarely a problem. The variables aren't shadowed in the top-level scope of the function, and if they're shadowed and there's a naked return in a sub-scope, it's a compile-time error. The main issue is if the variable is referenced from somewhere else, such as a closure, and then is accidentally shadowed somewhere, but that problem is not at all unique to named returns.

why not just add a special return syntax for naked returns? That way there is no cognitive overhead of checking named returns since the special return syntax implies that
Something like
return !
naked return
Bikeshedding ensues. The goal here is to differentiate naked returns from void returns.
Also this can be opt-in to keep working code working and eventually turned into a lint or error.

Removing an existing language feature requires a clear consensus that it is harmful in some way.  For example, the feature might be widely misunderstood, and might lead to many bugs in existing code.  I don't see that here.  I understand that people don't like bare returns--I'm not especially fond of them myself--but I don't see people reporting bugs due to bare returns.  So this is not a change that we are going to make, and I'm going to close this issue.  Thanks.


HIIT mode: defined cycles of work and rest

Preferences would have a screen to define cycles of work and rest time.
During work time only the current work would be measured.
During rest countdown could be applied unlike the generic rest when it's incremental timer

For better support we'd need something like #119


Customize and deploy block explorer

Summary
We have a MVP block explorer for devnet running on http://celestia.observer:3080/
It would be neat to a) use a more recent block explorer and b) customize it a tiny bit.
Problem Definition
https://github.com/forbole/big-dipper is not maintained anymore.
https://github.com/forbole/big-dipper-2.0-cosmos is its successor that we should be using.
Also, a custom theme, branding, and logos would be neat.
Proposal
Start experimenting with https://github.com/forbole/big-dipper-2.0-cosmos before launching testnet.
Customize it to our needs (before launching testnet too).
Start here: http://docs.bigdipper.live/cosmos-based/parser/custom-chains
Let's track the changes necessary here: https://github.com/celestiaorg/big-dipper-2.0-cosmos/issues
Example: https://explorer.evmos.org/
Hopefully this can be somewhat re-used for rollups:
ref: https://github.com/celestiaorg/optimint/issues/213
ref: https://github.com/celestiaorg/evmos/issues/3

I think we can close this, but pls reopen if this is still needed


About the baseline training

Thank you for the open source code, but I didn't find a script to train the baseline in the repo. I used the contrastive learning script to run it, but the results are not good, about 10 points lower than the results in the paper. I think it might be a problem with the script I run it. Could you provide a script for training the baseline? Or how do I make changes to the other training scripts to train the baseline model with them? Thanks again~

Hi, thanks for your interest in our paper. I have added the missing 'utils.py' file for the baseline model. You could train the baseline model similarly to the contrastive model script by replacing the main python file to train_graph_gen.py Let me know if you are not able to reproduce the results. I can share my trained model.


@afterMethod, @afterGroup should be called if @beforeMethod throws exception with configfailurepolicy as continue.

Fixes  #1426
Did you remember to?

[x] Add test case(s)
[x] Update CHANGES.txt

Not an issue. See #1426


fix tests to not need environment variables so that circle can run successfully on forks

For PRs from forks, circle builds will fail with KeyError: key not found: "TWITTER_CONSUMER_KEY".
Example build: https://circleci.com/gh/minifast/conference-opportunities/131
Apparently environment variables are not available on forks for security reasons:
https://circleci.com/docs/fork-pr-builds/
The test suite needs to not depend on environment variables so that circle builds will be possible for PRs from forks.

Hi @meara!
This is an awesome observation, and @cczona told me all about what happened here.  Is this still happening for you?

@meara After https://github.com/conference-opportunities/conference-opportunities/pull/10 by @sarahmei, I think this might be resolved. Sound good? 😄

Closing for now!


Rename column names for automl.rankings

Hi,
It seems to me that the score in the table below is the mean cross-validated score? If yes, It will be good to rename it to mean_cv_score.
Also, in addition to showing the high_variance_cv check, it will be a good idea to expose the standard deviation of fold scores as a new column.

Great suggestion, agreed!

Also, in addition to showing the high_variance_cv check, it will be a good idea to expose the standard deviation of fold scores as a new column.
Filed separately as #2072


If node started with --inspect, error trying to start inspector

Attempt to detect inspector is running and try to use existing inspect and don't close it.
ERROR [1654566852064] (******************************):
    message: "Inspector is already activated. Close it with inspector.close() before activating it again."
    err: {
      "type": "NodeError",
      "message": "Inspector is already activated. Close it with inspector.close() before activating it again.",
      "stack":
          Error [ERR_INSPECTOR_ALREADY_ACTIVATED]: Inspector is already activated. Close it with inspector.close() before activating it again.
              at new NodeError (internal/errors.js:322:7)
              at Proxy.inspectorOpen (inspector.js:137:11)

Resolved.


Fixed manifest size in reported total filesize

Signed-off-by: zed-rishabh<EMAIL_ADDRESS>

Will this work? I foresee an issue. For example if you pull alpine:3.10, the results could be different since img refers to the index, but the raw manifest is resolved to what actually is the image downloaded for your arch/os.

Will this work? I foresee an issue. For example if you pull alpine:3.10, the results could be different since img refers to the index, but the raw manifest is resolved to what actually is the image downloaded for your arch/os.

It is working fine with alpine:3.10 also. I verified it.

I’m not complaining then. 😃
Can you check that the actual manifest fits with what is in the file? If you want to do a simple download using the underlying library, I’ve got a simple utility that can pull any image at https://github.com/deitch/ocidist

I’m not complaining then. 😃
Can you check that the actual manifest fits with what is in the file? If you want to do a simple download using the underlying library, I’ve got a simple utility that can pull any image at https://github.com/deitch/ocidist

Yes, both are identical.


Better autogenerated index file

Related issue #3351

In this commit 0fcbe84 is the change, the other changes are from pre-commit command.

This looks like a good start. We should probably link to some resources that might help folks along, if we really want to make this better. Perhaps our getting started doc guide (http://docs.readthedocs.io/en/latest/getting_started.html)?


Restore start/stop Unit Test

In local environment, the test pass.While in Travis-ci, test Node10 can pass, but the node 9 is error.
The reason is:
TAP version 13
PuppetMock restart without problem
09:12:24 ERR TypeError: task.finally is not a function
not ok 1 Error: cache not exist
operator: fail
at: Object.<anonymous> (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/src/puppet-ioscat.spec.ts:23:7)
stack: |-
  Error: Error: cache not exist
      at Test.assert [as _assert] (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/node_modules/tape/lib/test.js:224:54)
      at Test.bound [as _assert] (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/node_modules/tape/lib/test.js:76:32)
      at Test.fail (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/node_modules/tape/lib/test.js:317:10)
      at Test.bound [as fail] (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/node_modules/tape/lib/test.js:76:32)
      at Object.<anonymous> (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/src/puppet-ioscat.spec.ts:23:7)
      at Generator.throw (<anonymous>)
      at rejected (/home/travis/build/linyimin-bupt/wechaty-puppet-ioscat/src/puppet-ioscat.spec.ts:6:65)
      at <anonymous>

...
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

OK


Rewrite Flutter runner in Dart

For kicks... https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/app/windows.tmpl

Started some primitive work here in the runner branch: https://github.com/timsneath/win32/tree/runner

This work is now taking place in a separate repo: https://github.com/timsneath/win32_runner.


Impossible to update a dynamic Text

Hello,
I have a progress bar so i use MaskedView for change the color of my text following the progress bar.
It work well on iOS, but on Android my text dont change.
This issue is quit the same as this one : #19
It says that the issue is closed because 'this issue has been resolved in the newest release' but i still have this problem so do you have any solution ?
Thank you

Hey how did you solve this?


Unit Test GameWorldAnchor

Unit Test everything testable in this class.
Cover all edge cases.

Class no longer exists


Incorrect results for pix2pix model

It looks like the pix2pix model doesn't give me any meaningful results. Whatever I prompt, I get a result that isn't even close to what I asked for. Look at the below:

I tried different seeds, a number of steps and strengths.
@eaidova Is this expected? It doesn't look like depicted in README.

@adrianboguszewski  do you mean 231 or image2image in 225?
jugging mention of strengths, it is stable diffusion. in image2image feature prompt used as additional detalization of image. It can not replace some particular details because it does not know image semantic,image used only for skping first step with random generation. Probably, problem in prompt what you provide, as it does not know image content, it can not change or turn something. Instead instruction what it should to do, it expects description how final image should looks like e.g.
Turn him to cyborg -> a photo of cyborg.
but your prompt is valid for 231:

@eaidova Oh yeah, you're right. I mixed up 2 notebooks. I was using 225, thinking that it was 231. When I tried the same prompt with 231, it worked.

This is nightmare inducing...


Fix two png images that were corrupted

These images cause errors when going through image processing tools, so I've created new ones. For future reference, I just took screenshots of the existing images on Github and uploaded them.
This seems to be the same fix that @patrickarlt made in https://github.com/Esri/arcgis-runtime-samples-qt/commit/78f7b7f9626f3ee0d67e09f6566d18b57d4ffbc6
You can see that the images are still the same when viewed in Github:

https://github.com/noahmulfinger/arcgis-runtime-samples-qt/blob/master/ArcGISRuntimeSDKQt_CppSamples/Scenes/Animate3DSymbols/screenshot.png
https://github.com/noahmulfinger/arcgis-runtime-samples-qt/blob/master/ArcGISRuntimeSDKQt_QMLSamples/Scenes/Animate3DSymbols/screenshot.png

@tanneryould Thanks! I don't have write access, so someone else will have to merge.


Interpoint Constraints

As discussed here, this adds the first interpoint constraint data model to BoFire.
From my perspective, a call method on interpoint constraints is somehow ill defined and not needed. What do you think about the jacobian method?
The integration in the Constraints data model is not yet complete, as the return value of the is_fulfilled method is now a bool and not a series of bools as in the case of the intrapoints. Will fix this later.
@Osburg @dlinzner-bcs  @KappatC

I think without a call method we also do not need a jacobian, right? :D but a call method for BatchConstraints / Interpoint constraints would not be less well-defined than for the NChooseK constraint (and there we also have a call method). In fact I think there is a relatively natural way to define a call and jacobian method for batch constraints (have not thought about other types of interpoint constraints): For each batch we evaluate all batch_size - 1 linear constraints assigned to the batch. Per batch we compute some norm (or other suitable function) of these linear constraint evaluations. The call function then returns this number for each batch. The jacobian could be defined as the derivative of the function i just described with respect to each variable of each experiment which is contained in the batch.
An implementation (jacobian still missing) could look like this (does not yet respect changes from this pr, wrote this piece of code down before you opened the pr, sry):
class BatchConstraint(Constraint):
    """Batch constraint which is fulfilled iff batch_size subsequent
    experiments have the same value for all features specified in features.

    Attributes:
        feature : feature key (str) the constraint operates on.
        batch_size (int): size of the batch
    """

    type: Literal["BatchConstraint"] = "BatchConstraint"

    feature: str
    batch_size: int

    @root_validator(pre=False, skip_on_failure=True)
    def validate_batch_size(cls, values):
        """Validate that batch_size is larger than 1."""
        if values["batch_size"] < 2:
            raise ValueError("batch_size must be larger than 1")
        return values

    def is_fulfilled(
        self, experiments: pd.DataFrame, tol: float = 1e-6
    ) -> pd.Series:

        values = self(experiments)
        return pd.Series(
            np.isclose(values, 0, atol=tol), index=values.index
        )

    def __call__(self, experiments: pd.DataFrame) -> pd.Series:
        """Numerically evaluates the constraint. Returns the distance to the constraint fulfillment
        for each batch of size batch_size.

        Args:
            experiments (pd.DataFrame): Dataframe to evaluate the constraint on.

        Returns:
            pd.Series: Distance to reach constraint fulfillment.
        """
        n_batches = (experiments.shape[0] + self.batch_size - 1) // self.batch_size
        feature_values = np.zeros(n_batches * self.batch_size)
        feature_values[:experiments.shape[0]] = experiments[self.feature].values
        feature_values[experiments.shape[0]:] = feature_values[-self.batch_size]
        feature_values = feature_values.reshape(n_batches, self.batch_size).T

        batchwise_constraint_matrix = np.zeros(shape=(self.batch_size-1, self.batch_size))
        batchwise_constraint_matrix[:,0] = 1.
        batchwise_constraint_matrix[:,1:] = -np.eye(self.batch_size-1)

        return pd.Series(np.linalg.norm(batchwise_constraint_matrix @ feature_values, axis=0, ord=2)**2, index=[f"batch_{i}" for i in range(n_batches)])

@Osburg : thanks, I do not think that we acutally need it, but as you have it here already, let us add it or? I would finalize this PR here without the implmentation and just raising NotImplementedError for __call__ and jacobian, and then you add your implementation in a seperate PR, ok for you?

Sure, this is fine! :)

@dlinzner-bcs: should be fine now from my side and ready for review.


Check out also git flying rules

Check out https://github.com/k88hudson/git-flight-rules :)

I've added this into links. It is a very useful resource. Thx!


$translateProvider.useStaticFilesLoader with external source

I was trying to use useStaticFilesLoader with external source.
$translateProvider.useStaticFilesLoader({   prefix: 'http://localhost:3001/i18n/',   suffix: '.json' });
Source json is downloading correctly from location Ex- http://localhost:3001/i18n/sw.json. But language translation is not working.
Here is how I am using it.

Are you sure the request is done? Because you must be aware of CORS.

yes. It showing result on network tab as expected.

Hello,
as we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.
Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.

Well, the thing is: This works, this is definitely a non angular-translate specific issue. I would say, it is even non related to AngularJS.
Do you have tried translate instead of data-translate?
But we need more information.

Hello,
as we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.
Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.

Hello,
I'm closing this issue due inactivity. We have asked for additional details, but you could not helped us. Therefore we close this issue as not reproducible.
If you still have an issue, please create a new issue because we cannot be sure to track closed issues.


add name as arra

I am not sure it works, and I wonder how to make it compatible with instance where the whole name is given.
see ```. It is at the publisher’s discretion whether to use  or  to capture an author’s name, though note that  is not allowed in  in JATS Blue. However, if a name is not easily broken down into a surname and given names (e.g., names such as “Prince” or “Prince Charles”), then if the publisher is using JATS Green, they should contain the entire string of the name in  to facilitate retrieval, per the JATS tag library guidelines.

wanted to move the discussion from #4 here: what is the best way to get this into the standard

#8 is better I think


Add Geist Typeface to Project

Description
Integrated the Geist typeface into the project to enhance readability and design consistency. This addition aims to improve the visual experience for both developers and users.

Related Issue
#196

Changes Made

Added Geist Sans variant for versatile design use.
Included Geist monospace variant for improved code readability.
Updated Tailwind config and CSS files to apply the new typeface across the project.

Screenshots
Now -

Before -

Checklist

[x] I have tagged the issue in this PR.
[x] I have attached necessary screenshots.
[x] I have provided a short description of the PR.
[x] I ran yarn build and build is successful
[x] My code follows the style guidelines of this project.
[x] I have added necessary documentation (if applicable)

This font truly goes with the story of the company. While images might not fully capture the impact of this change, the improved readability and design consistency will surely enhance the user experience.
It’ll blend seamlessly with all the future changes and fit perfectly with other elements.

minor change

bad mistake. Corrected it


[Bug] Editing an archive person in the archive list will show the unarchive list

Same with findcommand: listarchive -> find redirects to unarchive list


Pretrained model

Hi @tadax ,
Can you please let me know if you can share any pretrained model of yours.
If you can share the pretrained weights. it would be really helpful if you can explain briefly how to use it during inference time.
I can then just feed in a corrupted image and get the completed image.

@avisekiit  I shared the trained model file: https://drive.google.com/open?id=1jvP2czv_gX8Q1l0tUPNWLV8HLacK6n_Q
It was trained with face images.

does your model give a good result if trained with more complex structure images like the one in the original paper?


Error when parsing email without attachment info

I get this error when trying to parse an email without attachment info:
Example email: https://gist.github.com/fabiokr/13639921d958d3949cfb
** (exit) an exception was raised:
    ** (ArgumentError) argument error
        lib/mailman/parsing.ex:58: Mailman.Parsing.filename_from_raw/1
        lib/mailman/parsing.ex:74: Mailman.Parsing.is_raw_attachement/1
        (elixir) lib/enum.ex:704: anonymous fn/3 in Enum.filter/2
        (elixir) lib/enum.ex:1387: Enum."-reduce/3-lists^foldl/2-0-"/3
        (elixir) lib/enum.ex:704: Enum.filter/2
        lib/mailman/parsing.ex:89: Mailman.Parsing.get_attachments/1
        lib/mailman/parsing.ex:17: Mailman.Parsing.parse/1
        lib/mailman/parsing.ex:5: Mailman.Parsing.parse/1
        lib/mailman/parsing.ex:26: Mailman.Parsing.parse!/1

I have to add mime type in my case

Interested to see the answer here as well.


Face detection appears to be returning face attributes for only the first few minutes of video

I'm running a 25 minute clip with faces throughout the video, but face detection is only showing face data for the first 3 minutes of the video.  The FaceDetection operation completed successfully in the state machine.

Elasticsearch only contains the first page of redo's face_detection results. I see the DynamoDB Stream consumer is not getting paged data.


Replace broken paper link with doi link

Addresses #1273
cc @jGaboardi

Thanks for the PR @jackjgo!


ImageMountFailed

Why did I always have such an error prompt for opening the software for the first time? My device installs the system of Jitterbug's iPhone running ios 14.6, and uses Jit permission ipad os14.6.

jitterbug version is 1.1.0

Please read the readme. This exact issue is listed under troubleshooting.


Connection edges are drawn incorrectly on M57/M58.

All the ports are placed in the left-top corner of the node rect.

I don't think this is our bug though. Something must have been changed in SVG or Canvas.

Resolving this issue because bda0b5a24d88e4dc9f9503cc4fed84256ae51a16 removed the patch.


Add SystemDirectories

Name
Linux
Windows

Path
array of paths from PATH variable
array of paths from PATH variable

Config
array of paths from XDG_CONFIG_DIRS variable
exception?

Data
array of paths from XDG_DATA_DIRS variable
exception?

Path can be useful for finding binaries in apps that depend on external programs (fpcalc, ffmpeg).
Data can be useful for finding specific files that we could place there (gresource is already there, we could try to place gettext files there maybe).

https://github.com/NickvisionApps/Aura/releases/tag/2023.9.4


MEMBERS.csv: Sort by company, then primary contact, then first name

@anajsana -- I was finding the members list a little hard to read through (especially when trying to understand who was the primary contact for a particular company).
This PR sorts the member list by:

company, then:
primary contact, then:
first name

Hope that's okay! :)
Signed-off-by: Stephen Augustus<EMAIL_ADDRESS>

Thanks for the edit @justaugustus ! LGTM
FYI, once elections are over, we are planning to move sensitive info (emails and GH usernames to a private governance repo). But this list will remain with names, company and primary contact in the order you provided 🙂

Sounds great. Thanks Ana! :)


Explore page doesn't apply filters to the chart

I'm running queries on Chicago crime:
Query
The points on the map are filtered, but the chart is not - it shows 5+ million records no matter what filters I apply to the data. It does update when I change the time period.

Huge oversight on my part. For the aggregation endpoints (like /detail-aggregate and /grid) I construct the column filters but fail to pass them on to the database along with the rest of the aggregation. Should be a quick fix. Thanks so much for bringing it to my attention.

Hi Will,
I mentioned about this wrt to downloads. I never got around checking it.
If you apply a filter, I think the download dataset does not correspond to the filter.
Tanu
On Feb 5, 2016, at 3:31 PM, Will Engler<EMAIL_ADDRESS>wrote:

Huge oversight on my part. For the aggregation endpoints (like /detail-aggregate and /grid) I construct the column filters but fail to pass them on to the database along with the rest of the aggregation. Should be a quick fix. Thanks so much for bringing it to my attention.
—
Reply to this email directly or view it on GitHub.

Thanks, @WillEngler . On the same subject, are there plans to allow query parameters for the polygon_filter endpoint? For instance, to pull crimes with IUCR=0110 (homicide) by Chicago community area. Would really help with a project I'm working on, and would be great for blobs.

@lucaluca Yeah, that's in the works right now. I'll drop you a line when it's live (probably next week, along with public shape submission). The point/shape endpoints are pretty unstable at the moment, but my policy is to push up our experiments so that people can play with them.

Looks like that bug was limited to /detail-aggregate. Fix is live. The awkward map zoom we're seeing on @lucaluca's example deserves a separate issue though. And @TanuMalik, could you specify reproduction steps for for the download bug you saw in a new issue so that I can diagnose it?

Looking into the zoom, that grid query turns up a little cluster of 5 homicides southeast of West Plains, Missouri. Looking at Chicago's crime dataset, there actually are ~230 records geocoded to Southern Missouri. ¯_(ツ)_/¯

The map zoom isn't really an issue - it's caused by five crimes that were mis-geocoded to southern Missouri:

We see this every so often because of issues with the raw data. One solution we discussed a while ago was determining the bounding box that would cover 99%, rather than 100%, of the data, but this is computationally expensive and not really essential anyway. It's better to let DoIT know of the issue and let them fix it.


Type-clustered layouts

A new layout to plot the whole graph can be arranged by clustering per-type of vertices, like:

fixed：https://github.com/GraphScope/portal/pull/455


chore: use patient input as pointer

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6824

Relevant Lines:
8327

💛  - Coveralls


Reverse order of loot tracker grouped view

This puts monsters that were recently killed near the top of the list, instead of having to scroll down to find loot from your current session. Thought a config was superfluous, can add if it's wanted.

Never make pull requests from master

At some point between now and this PR's creation, functionality was added that does exactly this.


KSWE txt file added

Institution/School Name
Kantonsschule Wettingen
Instiution/School Website
www.kswe.ch
(English description: https://www.kanti-wettingen.ch/2-uncategorised/270-welcome-to-our-english-speaking-visitors?responsive=disabled)
Email Users
Please place an x between the square brackets if yes

[X] Students
[X] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[X] High School or equivalent
[ ] Elementary School or equivalent

Thank you!

@pro-kswe Pull request merged. Thank you!


Updated all tests and added a test to check if all DSC resource Modules are in the RequiredModules.ps1

Pull Request
Pull Request (PR) description
Added

Tests to check if all DSC resource Modules used in configurations are in the RequiredModules.ps1

Changed

Improved ConfigData and Acceptance test

Task list

[x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Closing this, all changes also in #137.


Release 1.8.0

Update setup.cfg, docs/conf.py and CHANGELOG.rst with the changes pertaining to release 1.8.0

@rajaths010494 and I just debugged through this. The root problem of the CI failure is databricks-sql-python does not support Python 3.10, this means that pip install astronomer-providers[databricks] cannot succeed on 3.10. There are a couple of solutions here:

Just ignore the CI failure, merge this PR and release 1.8.0 as-is. This means the package will be installable in most scenarios, except specifically with the databricks extra on 3.10, where pip will emit an error like the CI curerntly does (not possible to find dependency resolution).
Remove 3.10 support until databricks adds 3.10 support. This ensures that no users will see any dependency error, but the downside is the release will not be installable on 3.10, even if the user is not using databricks.

Personally I’m leaning toward the first solution, but it does need to involve some human judgement (not fully automated). So I would definitely understand if y’all decide to go with the second solution instead.

We should keep an eye out on https://github.com/databricks/databricks-sql-python/pull/32 and https://github.com/databricks/databricks-sql-python/pull/31 that might tackle it 🤷

Looks like they are going to release a new version supporting python 3.10 in a few hours 🎉
https://github.com/databricks/databricks-sql-python/pull/33#issuecomment-1218375892
We can just wait for a day for that :)

They have released 2.0.4 🎉 and I have added the changes to this PR, we are good to go

Tests are failing. Please resolve it
Include the details on the PR #589 in the CHANGELOG.rst

Added the details of PR #589 in  CHANGELOG.rst


Run all cookie tests and fix check for sdist tarball

Relates to #112
Changes made in this Pull Request:
PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG.md updated?
[ ] AUTHORS.md updated?
[ ] Issue raised/referenced?

Again confused why some tests register as "cancelled" sometimes.


[stable/mssql-linux] Add support to individually enable PVCs (data, translog, master, backup)

The current stable/mssql-linux chart only has a provision for all PVCs to be "enabled" or not.
We have a case where we were limited on our volume slots on our nodes and did not need the "backups" PVC for our developers.
We modified the helm chart to support the additional yaml tags of persistence.persistentBackup (and the same for Data, TransactionLog, and Master, for completeness).  These tags were used in templates/deployment.yaml and templates/pvc-*.yaml as necessary to enable only the PVCs we were interested in.
Is your feature request related to a problem? Please describe.
We have a pretty small limit of volume connections on the nodes in our individual development clusters, so needing all 4 PVCs generally means the mssql-linux service can never get scheduled.  The enhancement to the templates was not too involved to allow individual enable/disable of the PVCs.
Describe the solution you'd like
We have the code done if anyone is interested, however, we are not set up to create a PR and all the signing and all that jazz yet.
Describe alternatives you've considered
Use bigger, more expensive Azure nodes (ick).
Additional context
Just trying to add flexibility to the Helm chart.  We also have a beta version of the chart that mounts the backups from an AzureFile share instead of a PVC, however, that's necessarily AKS/Azure vendor specific (yuck).  There's a long and disgusting reason why we are currently doing that -- feel free to ask, but be afraid!  :)

No questions or comments yet?


Exe file missing /No offline use?

There was is no exe. file on W10 not on my Smartphone. I opened the rar. and tz on my phone and it's not there. I went several version down and it's not there either.
Can you please fix this or tell me how to do this I can not use the online one

This is a web-based editor; there is no executable. Just open the index file and you're good to go.


ICMP Support

Hello,
I came across this wonderful tool a few days ago, and I noticed the ICMP support has been removed.
I tried adding ICMP support via commit<PHONE_NUMBER>820865307a3bfe6f3ec8c9f2485660 but after editing files in my 3.2 version I get an error related to node module:
BasePoller = require ('./base');
Error: Cannot find module './base'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/home/uptime/lib/pollers/icmp/icmpPoller.js:9:18)
What is this module ?
Tried to do npm install base but didn t help
Thanks

var BasePoller = require ('../basePoller');
It should be basePoller


Update documentation for inline sourcemaps, or optional config for babel

For my needs, I was able to accomplish inline source maps passing options directly to babel.
The use case is transpiling server side node.
gulp.task('babel', function () {
  return gulp.src('server/**/*.js')
    .pipe(babel({
      sourceMaps: 'inline'
    }))
    .pipe(gulp.dest(DEST));
});

The blessed source map way is this: https://github.com/babel/gulp-babel#source-maps
You can do inline source map with it too.


preferences.json

I am adding this file to brackets fold in MAC (/Users/joao/Library/Application Support/Brackets/extensions/user/brackets-emmet), but anything that i put inside of it works am I doing something whrong?
preferences.json has this code:
{     "css.autoInsertVendorPrefixes": false,     "css.color.case": "lower" }

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6890357-preferences-json?utm_campaign=plugin&utm_content=tracker%2F311111&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F311111&utm_medium=issues&utm_source=github).

If you haven't already, you have to tell Emmet where to find the file - go to Emmet then Preferences and paste the path in there.

Hello,
I have the same problem. Even if I specify the extension folder /Users/raphael/Documents/brackets/ or the complete path /Users/raphael/Documents/brackets/preferences.json
with this code :
{
  "css.autoInsertVendorPrefixes": false
}

Hi! I have the same problem. You solved this problem?


Add total download stats

Seems like the database does not get dropped between each smoke test run :/

Turns out I don't understand python


Can't find Functions v2 runtime domain. error : POST https://undefined/create-new-task net::ERR_NAME_NOT_RESOLVED

When I try to call in dialpad, I see that the flex can't find the path of the function 'create-new-task'.
Is it a settings somewhere to be added?

Deploy the respective functions from here: https://github.com/lehel-twilio/plugin-dialpad-functions/


Lots of errors since 29-10

Did you read the instructions?

[X] I have read the README, including the known-limitations section.

The problem
I have lots of errors (~2500) in my log file (2x 1220) since 29 October:

knmi.txt.zip
Sample:
2023-10-29 12:18:16.974 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
2023-10-29 12:18:46.972 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>
2023-10-29 12:18:46.973 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
ValueError: Sensor sensor.knmi_thuis_dauwpunt has device class 'temperature', state class 'measurement' unit '°C' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: 'onb.' (<class 'str'>)
2023-10-29 12:19:16.974 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>
2023-10-29 12:19:16.975 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
2023-10-29 12:19:46.974 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>

Integration version
1.6.1
Home Assistant version
core-2023.10.5
Python version
3.11.5
Home Assistant log
2023-10-29 12:18:16.974 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
2023-10-29 12:18:46.972 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>
2023-10-29 12:18:46.973 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
ValueError: Sensor sensor.knmi_thuis_dauwpunt has device class 'temperature', state class 'measurement' unit '°C' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: 'onb.' (<class 'str'>)
2023-10-29 12:19:16.974 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>
2023-10-29 12:19:16.975 WARNING (MainThread) [custom_components.knmi] Value lv is empty in API response
2023-10-29 12:19:46.974 WARNING (MainThread) [custom_components.knmi] Value dauwp can't be converted to <class 'float'>

Diagnostics
{
  "home_assistant": {
    "installation_type": "Home Assistant OS",
    "version": "2023.10.5",
    "dev": false,
    "hassio": true,
    "virtualenv": false,
    "python_version": "3.11.5",
    "docker": true,
    "arch": "aarch64",
    "timezone": "Europe/Amsterdam",
    "os_name": "Linux",
    "os_version": "6.1.59",
    "supervisor": "2023.10.1",
    "host_os": "Home Assistant OS 11.1",
    "docker_version": "24.0.6",
    "chassis": "embedded",
    "run_as_root": true
  },
  "custom_components": {
    "car_wash": {
      "version": "1.5.5",
      "requirements": []
    },
    "syncthru": {
      "version": "0.2.0",
      "requirements": [
        "pysyncthru==0.7.10",
        "url-normalize==1.4.3"
      ]
    },
    "knmi": {
      "version": "1.6.1",
      "requirements": []
    },
    "ventoptimization": {
      "version": "0.5",
      "requirements": []
    },
    "worlds_air_quality_index": {
      "version": "1.0.2",
      "requirements": []
    },
    "feedparser": {
      "version": "0.1.11",
      "requirements": [
        "feedparser==6.0.10"
      ]
    },
    "places": {
      "version": "v<IP_ADDRESS>",
      "requirements": []
    },
    "luchtmeetnet": {
      "version": "0.0.3",
      "requirements": [
        "luchtmeetnet==0.0.2"
      ]
    },
    "sun2": {
      "version": "2.4.0",
      "requirements": []
    },
    "blitzortung": {
      "version": "1.0.1",
      "requirements": [
        "paho-mqtt>=1.5.0"
      ]
    },
    "hacs": {
      "version": "1.33.0",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "ics_calendar": {
      "version": "4.0.1",
      "requirements": [
        "ics>=0.7.2",
        "recurring_ical_events>=2.0.2",
        "icalendar>=5.0.4"
      ]
    },
    "met_next_6_hours_forecast": {
      "version": "v1.1.0",
      "requirements": []
    },
    "buienalarm": {
      "version": "1.9",
      "requirements": [
        "pybuienalarm==0.1.1"
      ]
    },
    "neerslag": {
      "version": "2<IP_ADDRESS>",
      "requirements": []
    },
    "chime_tts": {
      "version": "v0.7.5",
      "requirements": [
        "pydub"
      ]
    },
    "powercalc": {
      "version": "v1.9.6",
      "requirements": [
        "numpy>=1.21.1"
      ]
    },
    "p2000": {
      "version": "1.0.23",
      "requirements": [
        "feedparser"
      ]
    },
    "holidays": {
      "version": "1.9.6",
      "requirements": [
        "python-dateutil>=2.8.2",
        "holidays>=0.14.2"
      ]
    },
    "better_thermostat": {
      "version": "1.3.0",
      "requirements": []
    },
    "multiscrape": {
      "version": "6.5.0",
      "requirements": [
        "lxml==4.9.1",
        "beautifulsoup4==4.11.1"
      ]
    },
    "brandstofprijzen": {
      "version": "0.3.0",
      "requirements": [
        "beautifulsoup4==4.10.0"
      ]
    }
  },
  "integration_manifest": {
    "domain": "knmi",
    "name": "KNMI",
    "codeowners": [
      "@golles"
    ],
    "config_flow": true,
    "documentation": "https://github.com/golles/ha-knmi/blob/main/README.md",
    "iot_class": "cloud_polling",
    "issue_tracker": "https://github.com/golles/ha-knmi/issues",
    "version": "1.6.1",
    "is_built_in": false
  },
  "data": {
    "config_entry": {
      "entry_id": "df214dc5dd9e14a203c1c3c68634919e",
      "version": 1,
      "domain": "knmi",
      "title": "Thuis",
      "data": {
        "name": "Thuis",
        "latitude": "**REDACTED**",
        "longitude": "**REDACTED**",
        "api_key": "**REDACTED**"
      },
      "options": {},
      "pref_disable_new_entities": false,
      "pref_disable_polling": false,
      "source": "user",
      "unique_id": null,
      "disabled_by": null
    },
    "data": {
      "plaats": "Capelle aan den IJssel",
      "timestamp": "1698691997",
      "time": "30-10-2023 19:53",
      "temp": "10.5",
      "gtemp": "10.5",
      "samenv": "Lichte motregen",
      "lv": "93",
      "windr": "NNO",
      "windrgr": "22",
      "windms": "1",
      "winds": "1",
      "windk": "1.9",
      "windkmh": "3.6",
      "luchtd": "995.7",
      "ldmmhg": "747",
      "dauwp": "9",
      "zicht": "11",
      "verw": "Op steeds meer plaatsen regen",
      "sup": "07:31",
      "sunder": "17:20",
      "image": "buien",
      "d0weer": "bewolkt",
      "d0tmax": "14",
      "d0tmin": "9",
      "d0windk": "3",
      "d0windknp": "8",
      "d0windms": "4",
      "d0windkmh": "15",
      "d0windr": "ZO",
      "d0windrgr": "135",
      "d0neerslag": "8",
      "d0zon": "11",
      "d1weer": "halfbewolkt_regen",
      "d1tmax": "13",
      "d1tmin": "8",
      "d1windk": "2",
      "d1windknp": "6",
      "d1windms": "3",
      "d1windkmh": "11",
      "d1windr": "ZW",
      "d1windrgr": "225",
      "d1neerslag": "70",
      "d1zon": "30",
      "d2weer": "halfbewolkt_regen",
      "d2tmax": "15",
      "d2tmin": "8",
      "d2windk": "3",
      "d2windknp": "8",
      "d2windms": "4",
      "d2windkmh": "15",
      "d2windr": "Z",
      "d2windrgr": "180",
      "d2neerslag": "70",
      "d2zon": "10",
      "alarm": "0",
      "alarmtxt": ""
    }
  }
}

Additional information
No response

Hi, what you're seeing is that data is missing from the API, that's why you get these messages, so you are aware of inconsistent data.
Duplicate of #99
Also, what you're seeing are warnings, not errors.

Looking at your diagnostics, it should've resolved, since lv and dauwp both have a value


SSH passthrough to Docker doesn't work

Description
Hello,
I'm having issues with the SSH passthrough to my gitea docker instance. I'm having a lot of issues with this, and I really don't know how to fix this.
Long story short, I tried to implement SSH passthrough for my installation, by following the guide at https://docs.gitea.com/installation/install-with-docker (specifically using the SSHing Shim methodology) and every time I try this, I come up empty handed.
I've already set up my SSH keys from the gitea website for my account, so authentication is not an issue.
What is an issue is that, whenever I try to do something like a "git clone git@transistor.one:Alex/python-scripts.git", it fails with an "Gitea: Invalid repo name" error, even though the repo name is correct. Moreover, whenever I do "git clone git@transistor.one:2200/Alex/python-scripts.git" instead (note the added port number), then everything works correctly.
Obviously the SSH passthrough isn't working correctly, but I checked and double checked and triple checked everything for the past two days, but I simply can't figure out what's wrong.
Can you please help?
Gitea Version
1.22.1
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
Ubuntu server
How are you running Gitea?
I'm running gitea from docker, using the following docker-compose.yml:
version: '2'
networks:
gitea:
external: false
services:
web:
image: gitea/gitea:latest
environment:
- USER_UID=1002
- USER_GID=1002
volumes:
- ./data:/data
- /home/git/.ssh/:/data/git/.ssh
ports:
- "3000:3000"
- "2200:22"
depends_on:
- db
restart: always
networks:
- gitea
db:
image: mariadb
restart: always
environment:
- MYSQL_ROOT_PASSWORD=
- MYSQL_DATABASE=gitea
- MYSQL_USER=gitea
- MYSQL_PASSWORD=
volumes:
- ./db/:/var/lib/mysql
networks:
- gitea
Database
MySQL/MariaDB

Hello,
I just wanted to say that I figured it out, myself.
The issue was that I added the git user's public key through the gitea website (which means that it created a standard "command=" entry for it in the authorized_keys file) rather than doing it properly, as shown in the guide that I just linked.
The most important part that made me realize about this was the:

Important: The pubkey from the git user needs to be added "as is" while all other pubkeys added via the Gitea web interface will be prefixed with command="/usr [...].

That part made me realize my mistake. The issue can be closed now


build: add additional case of special handling for exherbo

The file system layout on exherbo is different from most other Linux
distributions.  Add an additional ignored case for the include paths for
when cross-compiling the stdlib to additional targets.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please clean test Linux platform


Library should be strongly signed

This would be beneficial for projects that are strongly signed and would like to utilize this library.
In case of projects for tests, they need to be signed when testing signed library with [InternalsVisibleTo] attribute set.

See #37


Dispatch Refresh working Locally on Windows10 but not on Windows Server 2016

Tool
name: dispatch
version: 4.6.1 (both OSes)
OSes: Windows 10, Windows Server 2016
Issue Description:
I have a bot utilizing both QnA and LUIS models with a dispatcher. I am able to run a dispatch refresh command on Windows 10 successfully.  It Exports all models, then updates, imports, and trains all models including the new Dispatch model.
I am attempting to set up a scheduled refresh (Using Task Scheduler) on a production server (the Windows Server 2016) however no matter what I do the refresh fails.
Commands Example:
There are slight differences of course between the two environments.
local (win10)dispatch refresh --dataFolder <folder>
prod(winserver2016) is a scheduled Task to start a program with the following params

Program/script: C:\Users\autoadmin\AppData\Roaming\npm\dispatch.cmd
Arguments: refresh --dataFolder  > dispatch-logs.log 2>&1
Start in: folder containing Dispatch Model directories

Reproduction Steps:

Kick off the Task Scheduled task in the WinServer2016 UI
Wait to finish
Review logs files for the following error

Exporting services for dispatch...
Exporting ConnectionSkills-PROD-Model LUIS application...
Exporting Utilities-PROD-Model LUIS application...
Exporting SearchSkills-PROD-Model LUIS application...
Exporting Smalltalk-PROD-QnA QnA kb...
Exporting MicroSkills-PROD-QnA QnA kb...
Exporting ITKB-Public-PROD-QnA QnA kb...
Exporting ITKB-Internal-PROD-QnA QnA kb...
Creating dispatch LUIS model json...
Creating training data...
WARNING: Number of samples in '\data_experiments\model_008\train.txt' that were used by multiple categories: 18
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold000\train.txt' that were used by multiple categories: 11
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold001\train.txt' that were used by multiple categories: 11
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold001\test.txt' that were used by multiple categories: 2
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold002\train.txt' that were used by multiple categories: 13
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold003\train.txt' that were used by multiple categories: 10
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold003\test.txt' that were used by multiple categories: 1
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold004\train.txt' that were used by multiple categories: 10
WARNING: Number of samples in '\data_experiments\model_008\cv5\fold004\test.txt' that were used by multiple categories: 2
Updating Dispatch-PROD-Model model...
Importing Dispatch-PROD-Model model...
ERROR
Failed importing latest version of Dispatch-PROD-Model app

REFRESH
Usage: dispatch refresh [options]
Retrain and republish existing LUIS dispatch application after modifications. Dispatch application id will be unchanged.
Options:
-v, --version           [Optional] Dispatch LUIS app version. A new version will be created if param value is different than previously created version.
-b, --bot               [Optional] Path to .bot file or bot services json file
-s, --secret            [Optional] Secret used to encrypt/decrypt .bot file
--dispatch              [Optional] Path to .dispatch file
--publishToStaging      [Optional] Default to false.
--dataFolder            [Optional] Dispatch working directory
Debug Attempts

If I take the .dispatch file and move it locally it works fine.
If i take the .dispatch file and import it using LUIS UI it works fine

@Stikemanley, what's in dispatch.cmd script?  Could you make sure that it has the "--dataFolder {dispatchWorkingFolder}" for all the commands?
Alternatively, if you only need to refresh previously create Dispatch in the Win Server 2016, you could put the .dispatch file in the same folder as dispatch.cmd script (where the only thing in it is the "dispatch refresh" command) and it should work.    I assume the scheduled task is to there to pick up changes from the Dispatch sources (other LUIS apps or QnA kbs).
Will close this issue as this doesn't sound like a Dispatch related issue but let us if you are still having problem with it.

Hi Tien!
Nothing in the dispatch.cmd script. That’s just the path to the dispatch executable. We haven’t installed the dispatch globally on the windows 2016 server. It behaves the same with the same path and just /dispatch as it does /dispatch.cmd
Another note, we manually imported the .dispatch file into LUIS and it worked perfectly, therefore I don’t believe it’s a conflict of entities etc... between models.
Thanks,
Mike

On May 15, 2019, at 4:02 PM, Tien Suwandy<EMAIL_ADDRESS>wrote:
Closed #1138.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks Mike.  .dispatch file is a dispatch configuration file, not LUIS json file.  Did you meant importing {DispatchName}.json file to LUIS?
Back to the "refresh" issue, did you try copying the {DispatchName}.dispatch file to where the dispatch executable is and run the command "dispatch.cmd refresh"?  This should work.  The refresh command needs existing .dispatch file since it needs to figure out the app id to refresh, the source apps/kbs, authoring key, etc.
Let me know if this is not clear.  Thanks!

Hello Tien,
Thank you for getting back to me. I've tried moving the .dispatch file to
the same directory as dispatch.cmd. I receive the same error message:
[image: image.png]
I didn't expect this to be the issue as it was able to export all the
necessary services previously as well.
Any other thoughts?
I know its not an issue with the different models themselves as I was able
to manually import and train this dispatcher using the {dispatch name}.json
file.
Thanks,
Mike
On Wed, May 15, 2019 at 10:10 PM Tien Suwandy<EMAIL_ADDRESS>wrote:

Thanks Mike. .dispatch file is a dispatch configuration file, not LUIS
json file. Did you meant importing {DispatchName}.json file to LUIS?
Back to the "refresh" issue, did you try copying the
{DispatchName}.dispatch file to where the dispatch executable is and run
the command "dispatch.cmd refresh"? This should work. The refresh command
needs existing .dispatch file since it needs to figure out the app id to
refresh, the source apps/kbs, authoring key, etc.
Let me know if this is not clear. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/botbuilder-tools/issues/1138?email_source=notifications&email_token=AFSCPUVELM6KZ66ZOFDARNDPVS7CNA5CNFSM4HMTO5ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQOJLQ#issuecomment-492889262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSCPUTMNXWDUC3UG7NCYR3PVS7CNANCNFSM4HMTO5ZA
.

Hi Tien,
What was happening was I was using an older .json file to import. When I
found the latest version inside the data folder created by dispatch.cmd It
gave me another message which was in essense "You don't have entities with
the same name". What had happened was we used datetimeV2 in patterns in two
different models.
This seems like something that should absolutely be covered. We should be
able to use the same prebuilt entities in all of our models. Additionally,
the lack of debug provided by the dispatch CLI tool made this very hard to
figure out the root problem.
Thank you,
Mike
On Mon, May 20, 2019 at 2:28 PM Michael Stanley <
<EMAIL_ADDRESS>wrote:

Hello Tien,
Thank you for getting back to me. I've tried moving the .dispatch file to
the same directory as dispatch.cmd. I receive the same error message:
[image: image.png]
I didn't expect this to be the issue as it was able to export all the
necessary services previously as well.
Any other thoughts?
I know its not an issue with the different models themselves as I was able
to manually import and train this dispatcher using the {dispatch name}.json
file.
Thanks,
Mike
On Wed, May 15, 2019 at 10:10 PM Tien Suwandy<EMAIL_ADDRESS>wrote:

Thanks Mike. .dispatch file is a dispatch configuration file, not LUIS
json file. Did you meant importing {DispatchName}.json file to LUIS?
Back to the "refresh" issue, did you try copying the
{DispatchName}.dispatch file to where the dispatch executable is and run
the command "dispatch.cmd refresh"? This should work. The refresh command
needs existing .dispatch file since it needs to figure out the app id to
refresh, the source apps/kbs, authoring key, etc.
Let me know if this is not clear. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/botbuilder-tools/issues/1138?email_source=notifications&email_token=AFSCPUVELM6KZ66ZOFDARNDPVS7CNA5CNFSM4HMTO5ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQOJLQ#issuecomment-492889262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSCPUTMNXWDUC3UG7NCYR3PVS7CNANCNFSM4HMTO5ZA
.

@Stikemanley I can't see the [image: image.png], I think it's not linked?
Where were the errors?  Could you copy and paste the errors instead?  I'm not sure what the issue is as you shouldn't need to import the json file yourself (cli will do it).


Fix Inversify Error in Theia Diagram Extension

An error occurs when trying to run an updated version of Theia. The error is already known and described in the Sprotty main repository https://github.com/eclipse/sprotty/issues/201.
Full console log:
https://pastebin.com/0KF4vjDm
Possible Solution: Update to Sprotty 0.10.0

Updated sprotty in b0e45484b254260fbf7315fede11aa4baa124905
see /schubmat/Custom-MADE/tree/feature-integrate-visual-editing
However, some compile errors remain. As soon as I have more time, I could have a loot at it. May be @rrcomtech or @pcprinz could have a look at it before that?

First error messages showing the error
error TS2322: Type 'Element' is not assignable to type 'VNode'.

eliminated by ``f2dd1033`. New errors remaining.

The error stated that modules are not present anymore in Sprotty-Theia 0.10.0. It looked like this (for multiple modules):
src/browser/diagram/diagram-configuration.ts(3,10): error TS2305: Module '"sprotty-theia"' has no exported member 'CodeActionPalettePopupProvider'.

It was done, because many LSP-related modules were moved to eclipse/sprotty-vscode. This topic is discussed in these issues:

eclipse/sprotty-theia/issues/82
eclipse/sprotty-theia/issues/67

To put it short: Theia does not support LSP-related modules anymore. The new approach is to implement a VSCode extension, which still does support LSP-related modules.
An example for a reimplementation of a VSCode Sprotty extension is given in eclipse/sprotty-vscode. The reimplementation should be the new main focus, which resolves this issue.


IOS - Frame rendering times increasing time by time caused the app is slowly

Describe the bug
Run the Agora Video on IOS (as Host), app is too slowly in the time by time.
To Reproduce
Steps to reproduce the behavior:

Go to example
Run Join Channel Video
Let the app run about 15-30 minutes
The app is very slowly

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Device: Iphone 7
OS: 15.5

Agora version: 5.0.1

@littleGnAl Could you please help to take a look on this issue? Thank you.

I think maybe you can try agora_rtc_engine: ^6.0.0.

The v6.0.0 is changed a lot with v5.x, so i will upgrade later when releasing the app with current V5.x. Could i have another option but upgrade to v6.x?

@littleGnAl just tried with 5.x but the result is the same, can not action anything when run long time.

I think the issue may be not caused by the agora_rtc_engine, you can track the memory usage by following the https://docs.flutter.dev/development/tools/devtools/memory guide to see what caused the memory increase.

@littleGnAl I run the example, only the Agora Video view is displayed at the moment.

This is logs, maybe it is related to Agora
Exhausted heap space, trying to allocate 268435472 bytes. flutter: #0      List._allocateData (dart:core-patch/growable_array.dart) #1      List._grow (dart:core-patch/growable_array.dart) #2      List.addAll (dart:core-patch/growable_array.dart) #3      _HttpProfileData.appendResponseData (dart:_http/http_impl.dart) #4      _HttpClientResponse.listen.<anonymous closure> (dart:_http/http_impl.dart) #5      _MapStream._handleData (dart:async/stream_pipe.dart) #6      _ForwardingStreamSubscription._handleData (dart:async/stream_pipe.dart) #7      _rootRunUnary (dart:async/zone.dart) #8      _CustomZone.runUnary (dart:async/zone.dart) #9      _CustomZone.runUnaryGuarded (dart:async/zone.dart) #10     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart) #11     _BufferingStreamSubscription._add (dart:async/stream_impl.dart) #12     _ForwardingStreamSubscription._add (dart:async/stream_pipe.dart) #13     _ForwardingStreamSubscription._handleData (dart:async/stream_pipe.dart) #14     _rootRunUnary (dart:async/zone.dart) #15     _CustomZone.runUnary (dart:async/zone.dart) #16     _CustomZone.runUnaryGuarded (dart:async/zone.dart) #17     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart) #18     _BufferingStreamSubscription._add (dart:async/stream_impl.dart) #19     _StreamController._add (dart:async/stream_controller.dart) #20     _HttpParser._doParse (dart:_http/http_parser.dart) #21     _HttpParser._parse (dart:_http/http_parser.dart) #22     _HttpParser._onData (dart:_http/http_parser.dart) #23     _rootRunUnary (dart:async/zone.dart) #24     _CustomZone.runUnary (dart:async/zone.dart) #25     _CustomZone.runUnaryGuarded (dart:async/zone.dart) #26     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart) #27     _BufferingStreamSubscription._add (dart:async/stream_impl.dart) #28     _StreamController._add (dart:async/stream_controller.dart) #29     _StreamController.add (dart:async/stream_controller.dart) #30     _Socket._onData (dart:io-patch/socket_patch.dart) #31     _rootRunUnary (dart:async/zone.dart) #32     _CustomZone.runUnary (dart:async/zone.dart) #33     _CustomZone.runUnaryGuarded (dart:async/zone.dart) #34     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart) #35     _BufferingStreamSubscription._add (dart:async/stream_impl.dart) #36     _StreamController._add (dart:async/stream_controller.dart) #37     _StreamController.add (dart:async/stream_controller.dart) #38     _RawSecureSocket._sendReadEvent (dart:io/secure_socket.dart) #39     _rootRun (dart:async/zone.dart) #40     _CustomZone.run (dart:async/zone.dart) #41     _CustomZone.runGuarded (dart:async/zone.dart) #42     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart) #43     _rootRun (dart:async/zone.dart) #44     _CustomZone.run (dart:async/zone.dart) #45     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart) #46     Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart) #47     _Timer._runTimers (dart:isolate-patch/timer_impl.dart) #48     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart) #49     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart)

@littleGnAl I run the example, only the Agora Video view is displayed at the moment.

This screenshot is not relative to the agora, do you load a very large image in your app causing the memory to increase?

@littleGnAl I run with example, no others loading. You can see in the image and recording below. The UI can NOT action due to the Frame rendering times are too high with on Raster(GPU)

https://user-images.githubusercontent.com/7744981/195794815-9c1ecfe3-4ab9-4b2c-8990-60d531ee6083.mp4

I think it's better to submit a new ticket to agora support for further investigation, it seems most likely your network issue, since there's a log of the warning "LoopupChannelTimeout".


OIDC authentication not supported through MS Edge

Ollie Freeman looked into this and confirmed it is not an API issue so he believes it is in the UI.
Details of testing completed:
Tests conducted using ID supplied by Nicholas on his domain “oughtibridge.com”.
Test 1:
Scenario: Log onto Mauro using the Google Chrome browser.
Outcome: Successful log on
Test 2:
Scenario: Log onto Mauro using the Firefox browser.
Outcome: Successful log on
Test 3:
Scenario: Log onto Mauro using the MS Edge browser (version 94.0.992.38 - 64-bit)
Outcome: Fail. Did not present opportunity to enter password. Error message “Unfortunately there was a problem authorizing your login via an external provider. Details: Invalid username or password! Please try again, or contact your administrator for further support."
Test 4:
Scenario: Log onto Mauro using Edge in a private browser
Outcome: Successful log on
Test 5:
Scenario: Amend MS Edge settings to set "cookies and other site data" to clear on exit and restart Edge before logging on to Mauro
Outcome: Successful log on
Test 6:
Scenario: unset the Test 5 setting but run a one-time deletion of "cookies and other site data" before logging onto Mauro.
Outcome: Fail. (Same as test 3), i.e., Did not present opportunity to enter password. Error message “Unfortunately there was a problem authorizing your login via an external provider. Details: Invalid username or password! Please try again, or contact your administrator for further support."

I believe this issue is fixed and can now be closed?  @PaulChapmanPM @olliefreeman

This issue is indeed fixed. Thank you @olliefreeman and @jamesrwelch for your help.


ModelButton is missing

Hello, I see that the ModelButton is missing, obviously he is useful for the PopoverMenu. The gtk documentation says it's a v3_16 feature, are there plans for the integration?
GtkModelButton

As GtkModelButton don't contains any methods and properties still unfinished, we don't generate wrapper for this class.
IMHO this can't stop you from using class in .glade and use it as normal Button in program.


Remove Google analytics code

Liying,
We are not using google analytics anymore. Let us remove the google analytics references.

Sure, I will create a branch to remove google analytics.
Liying

From: Mashfiqui<EMAIL_ADDRESS>Sent: Wednesday, April 22, 2020 2:18 PM
To: StatisticalReinforcementLearningLab/SARAv2<EMAIL_ADDRESS>Cc: Huang, Liying<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: [StatisticalReinforcementLearningLab/SARAv2] Remove Google analytics code (#81)
Liying,
We are not using google analytics anymore. Let us remove the google analytics references.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStatisticalReinforcementLearningLab%2FSARAv2%2Fissues%2F81&data=02|01|lxh37%40psu.edu|a9e5f8004ed142f1104308d7e6e995a3|7cf48d453ddb4389a9c1c115526eb52e|0|0|637231763218275638&sdata=OlZXBske5LejPU9yXBXldSVBJpNhWkVmVANzGe%2Bw6Rk%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADXW5ZNFX45BIO3LRB7OBBTRN4YIBANCNFSM4MOMULAQ&data=02|01|lxh37%40psu.edu|a9e5f8004ed142f1104308d7e6e995a3|7cf48d453ddb4389a9c1c115526eb52e|0|0|637231763218285630&sdata=%2BZc8gfpNGU5U0XQq9Vw8%2BD4S7nS49RZ5auOjVCXYjn8%3D&reserved=0.


[Communication] - Phone Numbers - Address API View comments

Addressing some of the comments from API View reviews:

https://apiview.dev/Assemblies/Review/f5795186f9864e7aa21ea10b1bc670ee
https://apiview.dev/Assemblies/Review/300aa54ba60742b4890c4a0a0853fad9

Update change log for breaking changes, please


Support passing Accelerator objects to the accelerator flag with devices=x

🐛 Bug
Expected behavior

As we are walking down the path to support #10410, it is important to support this behavior.
trainer = Trainer(accelerator=GPUAccelerator(CustomStrategy()), devices=4)

# should be equivalent to

trainer = Trainer(accelerator="gpu", devices=4, strategy=CustomStrategy())

Environment

PyTorch Lightning Version (e.g., 1.3.0):
PyTorch Version (e.g., 1.8)
Python version:
OS (e.g., Linux):
CUDA/cuDNN version:
GPU models and configuration:
How you installed PyTorch (conda, pip, source):
If compiling from source, the output of torch.__config__.show():
Any other relevant information:

Additional context

cc @tchaton @justusschock @kaushikb11 @awaelchli @borda

@ananthsub Noted! The example was considering the current state.
The core part, it needs to support is
trainer = Trainer(accelerator=GPUAccelerator(), devices=4)

# should be equivalent to

trainer = Trainer(accelerator="gpu", devices=4)

Also, this will be a small step towards supporting pluggable custom accelerators (which is not possible right now). Will write a RFC for it tomorrow.
trainer = Trainer(accelerator=NewSOTAAccelerator(), devices=4)

I agree this is a bug. This works today:
trainer = Trainer(accelerator=NewSOTAAccelerator(), gpus=4)

Whether gpus or devices are supplied should not matter.

@kaushikb11 what remains to be done here following https://github.com/PyTorchLightning/pytorch-lightning/pull/12030 ?

Yup, this issue has been resolved.


Support for AGP Version >= 8.X.X

Hello there,
Currently I'm updating a Flutter project to the newest state possible.
When updating Gradle I get a Namespace not specified. error from airplane_mode_checker.
Since AGP 8 and newer a namespace value is needed in app/build.gradle file and removed from AndroidManifest.xml
android {
...
    namespace 'com.u14h4i.airplane_mode_checker'
...
}

Please have a look at this StackOverflow thread.
Maybe you consider this part in the next update. :D
Thank you very much!

@arconsis-micha Thanks for letting me know. I added namespace to the plugin in the PR.
And it's available in version 3.0.0


admin.barriers.* APIs

A new set of admin APIs are publicly available now.

https://api.slack.com/methods/admin.barriers.create
https://api.slack.com/methods/admin.barriers.delete
https://api.slack.com/methods/admin.barriers.list
https://api.slack.com/methods/admin.barriers.update

Category (place an x in each of the [ ])

[ ] bolt (Bolt for Java)
[ ] bolt-{sub modules} (Bolt for Java - optional modules)
[x] slack-api-client (Slack API Clients)
[ ] slack-api-model (Slack API Data Models)
[ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
[ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements
Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

I need more time to test this feature. Let me postpone adding this to v1.4.1.


WIP: Add ButtonTheme textColor

Description
Add a ButtonTheme textColor which allows setting a theme wide text color for all kinds of buttons like FlatButton, RaisedButton, etc. Currently, all those buttons calculate their text color from the ButtonTheme's textTheme or by the textColor given to them directly. Setting a theme wide text color is currently not easily possible. The addition of a textColor property solves this issue.
The textColor is used when the Button itself has to textColor specified. If textColor is not given everything works as before.
Related Issues

Fixes https://github.com/flutter/flutter/issues/54343
Fixes https://github.com/flutter/flutter/issues/19623

Tests
I added the following tests: /
I should probably add tests but I am currently not sure where. I could add a test that assures that the getTextColor function works as expected or I could add a test that tests that all kinds of buttons are using the textColor if specified.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@HansMuller I need some help with the tests:

I should probably add tests but I am currently not sure where. I could add a test that assures that the getTextColor function works as expected or I could add a test that tests that all kinds of buttons are using the textColor if specified.

You're correct that this PR woudl provide a way to bypass the ButtonTheme's convoluted, but backwards-compatible, approach for computing the text color.
On the other hand, many apps have more complex requirements for specifying the text and other colors. For example there are dependent colors, like the highlight colors for splash/focus/hover/pressed, that are based on the one color used for text and icons. Some apps would prefer to have all of those colors computed automatically, others would like to be able to override the defaults for just some of them, and still others want to override defaults based on the button's state. I've written a proposal that addresses the well-known problems with buttons and their themes, but doesn't attempt to do so by evolving the old APIs: https://flutter.dev/go/material-button-system-updates. I hope you'll take a look, I'd appreciate your feedback.

Sounds reasonable but for the short term, this PR would fix at least one shortcoming. I agree with you that building a new API makes more sense for the long term. I will take a look at you proposal tomorrow.

@christian-muertz - I've added a GitHub issue that covers where I think we should be taking ButtonTheme et al.  It's #54776 and it points back to  https://flutter.dev/go/material-button-system-updates.
As I said in https://github.com/flutter/flutter/pull/54345#issuecomment-611822871, I do not want to continue patching ButtonTheme or the existing Button classes.

I'm going to close this PR, because we've proposed a different direction for ButtonTheme et al. If you have time,  we'd appreciate your feedback on #54776 and and https://flutter.dev/go/material-button-system-updates.


Adding keys via apt-key deprecated in Debian 11

For Debian installation, in particular for Debian 11, the way the keys are added generates a warning:
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fc3da20-7ab2-d20f-4d29-4664d3183b57
Version Independent ID: 986d25d9-5d2e-5154-39ea-3b683faf2264
Content: Install the Microsoft ODBC driver for SQL Server (Linux) - ODBC Driver for SQL Server
Content Source: docs/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server.md
Product: sql
Technology: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-davidengel

@lgonzalezsa -- Luis, thank you for your feedback.
@David-Engel -- David, please look into this issue.

This is what I did:
sudo su
key=/usr/share/keyrings/microsoft.gpg
debianVer=$(sed -r 's|^Debian GNU/Linux ([[:digit:]]+) .*|\1|' /etc/issue | head -n1)
echo "Debian verison = '$debianVer'"
curl -fsSL https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor -o "$key"
curl -fsSL https://packages.microsoft.com/config/debian/${debianVer}/prod.list | sed 's|]| signed-by='"$key"']|' > /etc/apt/sources.list.d/mssql-release.list
apt-get update && ACCEPT_EULA=Y apt-get install -y msodbcsql18

Closing as duplicate of #6706
#please-close


add florence blakely nomination to job page?

putting this on the job page just makes it look empty. why the award and not other projects, etc.?


fix: bail out of drag mode on simple click

Hi @williamngan,
This is hopefully the last of my series of PRs on UIs. Basically this rights the wrong I introduced with the combination of #67 and #81. Since we wanted to avoid emitting up on uidrop, we tracked drag and drop instead of down and up. But that created the sticky issue, so i reverted to starting dragging on down instead of drag. As a consequence, in the current state if you click a UIDrag, it goes in dragging mode and drop never happens so it's stuck there. With this PR, we're now tracking both drop and up to end drag. drop is your original solution, and up lets us bail out of dragging on simple click. We have to track up since up is not emitted on drop anymore.
Long story short, I think this is finally the god implementation taking all use-cases into account 😅. It's taken a while to discover all these but hopefully we're covered this time.

Hi @tibotiber - Thank you! I know UI states are often super tricky - thanks for your fixes on all the edge cases.
And apologies for the late response. I was really busy lately! :)

No worries! Happy to fix these, and thanks for your time as well. :)