fmt: printing of types inconsistent for byte and uint8 with %#v

go1.4, go1.6, tip
( note that with the recent changes i made to fmt i was careful to not change the behavior but leave the issue open)
https://play.golang.org/p/TrmwckEwqu
          %T | reflect Type | %#V
       uint8 |        uint8 | 0x0
       uint8 |        uint8 | 0x0
     []uint8 |      []uint8 | []byte{}
     []uint8 |      []uint8 | []byte{}
      main.S |       main.S | main.S{in:[]uint8{}}
      main.S |       main.S | main.S{in:[]uint8{}}
    [3]uint8 |     [3]uint8 | [3]uint8{0x0, 0x0, 0x0}
    [3]uint8 |     [3]uint8 | [3]uint8{0x0, 0x0, 0x0}

i would expect uint8 to be consistent everywhere in agreement with %T  and especially for []uint8.
i would argue it should and could be changed to always print uint8 because:

there are no issues that reflect package treats byte as uint8 in type strings (its only an alias anyway)
there is no way i know of to differentiate byte from uint8 with the reflect package or at all during runtime so a fix to differentiate the cases seems impossible
most cases already print uint8 types even if its specified as []byte inside e.g. a struct
%T and %#v are inconsistent for the type specification currently
there will be no extra code needed for %v,%d,%b bytes formatting vs normal array,slice formatting so it also automatically agrees e.g. what to print for nil slices.
if the behavior is changed to print []byte as []uint8 no test in std lib besides fmt_test breaks (those were mostly only added after go1.6)
there is precedent for fixes after go1 that made %T and %v consistent and not print byte type #4685 but uint8 is still shown as byte
the language spec defines "byte alias for uint8" not uint8 as alias for byte

Closing since we do not want to break existing code changing this.


Line number margin does not get adjusted properly

Hi,
I found an issue with line-number area left margin. When I have a large document with many lines (probably over 10000), I start to notice the line-number gutter width being automatically adjusted, but the left-margin is shrinking to 0.
I have tried on both VScode and VScode web and the problem does not seem to exist. This only show up in monaco-editor
This is what I see in VSCode (web and app)

This is what I see in the playground

If I missed some settings, could you let me know?
Thank you so much!

Looks to me like this can be solved by using lineNumbersMinChars:
    const currentValue = editor.getValue();
    editor.updateOptions({
      lineNumbersMinChars: Math.max(Math.floor(Math.log10(currentValue.split(/\r\n|\r|\n/g).length)) + 3, 5),
    });

Closing this issue now


JMS: Add support for multiple "business" objects in one JMS message

Hi.
I came across a use case where application sends multiple "business-objects" in one JMS message and also gets batched response back. That is, a response can contain multiple business objects, but there is no guarantee that all business objects from request will be inside one response. Actually it's rather unlikely to happen.
Each business object has unique id that is also send back in response.
I tried to use Gatling for performance testing of this application, but it looks like the assumption is that one JMS message can only contain one id.
I hacked around and modified the code and made it work, but this is breaking change as the JmsMessageMatcher interface changed as it's returning Seq[String] now instead of single String.
Can someone have a look and perhaps suggest how to add support for such feature in a backward compatible manner?
I was thinking perhaps to create new "batched" interface of matcher and provide some implicit conversion from the current Interface to the new "batched" interface. Any better ideas?
PR with the hacky solution: #4539

One thing I noticed now is that even though the solution works, that is, the tests complete, they report not the total number of the "business objects" but rather a total number of JMS messages.
That is. if there was X JMS messages with Y business objects inside, I would like to see the X * Y count reported and the times should be measured from the time a "business object" is sent to the time when there's response for that same "business object" coming back.

I don't think your suggested solution works. It think what you would need would be a way to preprocess the JMS messages so you can split them before they get handed over to the checks.

I don't think your suggested solution works. It think what you would need would be a way to preprocess the JMS messages so you can split them before they get handed over to the checks.

I guess it "works" for me because I don't do any checks. Just fire all those messages, wait for their return and measure the time.
If you can guide me which parts of the code where would be a good place to do the splitting then I will have a look

Closing for now due to lack of activity and interest.


Context is incorrect when using real asnyc middleware.

The execute function resolves before all middleware has finished updating the context, when the the middleware includes real-world asnyc behaviour.
Taking your example script:
import { pipeline } from "@digibear/middleware";

const engine = pipeline((ctx, next) => {
  ctx.foobar="baz";
  setTimeout(() => next, 1000) // Mock a real-world async function
})

engine.use((ctx, next) => {
  ctx.another = 123;
  setTimeout(() => next, 1000) // Mock a real-world async function
});

const context = {};

(async () => {
  const context = {};
  await engine.execute(context);
  console.log(context);
})();

// => { foobar: "baz" }

Notice that ctx.another is not present in the context object. That's because the execute function finishes before the middleware stack has completed its' run through. I feel like being able to defer the call of next and still retrieve the results of the finished stack is quite an important part of a middleware engine?

Oh hey! Thanks for your feedback!  I'll keep looking into this one.

Modified your test to simulate dealing with async/await with real-world functions:
test("Context is correct when using async middleware", async () => {
  type TestContext = { [key: string]: any };

  const engine = pipeline<TestContext>(async (ctx, next) => {
    ctx.foobar = "baz";
    await new Promise((res) => setTimeout(res, 2000)); // Mock a real-world async function
    next();
  });

  engine.use(async (ctx, next) => {
    ctx.another = 123;
    await new Promise((res) => setTimeout(res, 2000)); // Mock a real-world async function
    next();
  });

  const context: TestContext = {};
  await engine.execute(context);
  console.log(context);
  expect(context.another).toEqual(123);
});


Enhancement: SQL Fuzz testing with SQLancer

REMEMBER, BE SMART!
S: Specific
M: Measurable
A: Achievable
R: Relevant
T: Time-Bound
Goal-State/What/Result
Spice has SQL "fuzz" testing and automation using SQLancer (or datafusion-sqlancer) to find issues with SQL query logic covering both federated and accelerated scenarios.
Why/Purpose
As Spice approaches release, we need to have a comprehensive suite of SQL tests to validate the capability of Spice.
By When
A target date for done-done completion of the entire enhancement.
Issue/Spec written and reviewed:
Done-Done:
Done-Done

[ ] First Principles Driven
[ ] The Algorithm
[ ] PM/Design Review
[ ] UX Review
[ ] Threat Model / Security Review
[ ] Tests
[ ] Documentation
[ ] Samples/Quickstarts/Tutorials
[ ] Release Notes

The Algorithm

[ ] Every requirement questioned?
[ ] Delete (Scope) any part you can.
[ ] Simplify.
[ ] Break down into smaller iterations/milestones.
[ ] Opportunities for automation.

Spec
Basic specification of the enhancement.
How/MAP
A clear and concise plan of how this should be implemented.
Implementation (issues)

QA

@y-f-u to fill out the template and send for PM review.


added file for domain central.towerhamlets.sch.uk for CFGS

the university official website URL, if it is different from the domain you are submitting
https://www.cfgs.co.uk/index.asp

a URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university
https://www.cfgs.co.uk/Computer-Science/

a URL of a page or some other proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students.

@abelmo First stage of verification passed, official domain is cfgs.co.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.cfgs.co.uk/

@abelmo First stage of verification passed, official domain is cfgs.co.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.cfgs.co.uk/

Thank you for the update. Just to confirm, the school's website is indeed cfgs.co.uk but the email domain used for staff and students is @central.towerhamlets.sch.uk
Let me know if you require any further info and thanks for you help!

@abelmo Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Clean up README content.

I edited the README when I re-read it this morning.

Typo in the copy edit. Lovely!

@barelyknown that is awesome that you proofread and corrected the typos in the Readme file, and grammar too :)
The Readme was mostly a rant I pounded out on the keyboard yesterday. It's nice to have these corrections, thanks!

:+1:


Support client RPC operation level timeout

Client RPC calls like get and put, if can support configurable timeouts, will be helpful in enforcing SLAs.

Version 1.1 support synchronous timeouts (i.e. block a thread to wait for an RPC to complete for a certain amount of time, and give up waiting if the RPC is taking too long).  Asynchronous timeouts need to be implemented.
For synchronous timeouts, just call join(timeout) on the Deferred of the RPC.

Asynchronous timeouts need to be implemented.
Can you give me a brain dump on this? I wish to work on it.

Sure.  For asynchronous timeouts, we need a timer thread that takes care of all the timeouts.  This should be implemented with Netty's HashedWheelTimer.  Every single RPC that is sent out would schedule a new TimerTask and save the Timeout for this RPC, probably along with its Deferred.  Then for each response that arrives from the network, we'd take the Timeout object and cancel() it.  If a timeout occurs, we'd callback the Deferred with an exception, say a RpcTimeoutException (that would inherit from RecoverableException).
There are a couple subtleties involved, such as properly handling the cases where the RPC times out and then immediately after that you get the response back from the network.  In this case the response should just be silently ignored as no processing / handling of it can occur, because we already gave a RpcTimeoutException to the Deferred.
The HBase RPC protocol doesn't support timeouts and doesn't support canceling RPCs, so once something has been sent to the wire, we can't take it back.

This is helpful. Let me see where I can get with this.


WIP - Remove update_event as a single event loop for the system

Builds on #159
TODO:

[x] Move major components into their own timer loops (task/job in one, etc)
[ ] Update Task timer loop to pull from the task heartbeat queue (requires Heartbeat updates)
[ ] Update Node timer loop to pull from the node heartbeat queue (requires Heartbeat updates)
[x] Merge pool resize & scaleset timer loops into a single loop
[x] Ensure tasks stop after their duration
[x] Ensure jobs stop after their duration
[x] Ensure repro stop after their duration

The remaining todo items will be done in a separate PR once #164 is finished.


Add dummy comment

Description
[Describe the change that was made in this PR]
Todos

[ ] Tested and working locally
[ ] Code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] Code changes documented
[ ] Requested review from >= 2 devs on the team (one frontend and one backend recommended)

How to test
[Add detailed steps to test the changes that have been made]
Screenshots and/or Gifs
[Insert screenshots and/or gifs showing the graphic representation of the change]
Associated MS Planner Tasks

Task Title
Task Title

Known Issues
[Describe any known issue with this change]

Closing as this was intended for a test.


Fix hourglass icon not displayed instead of Next Steps

Details

Display the hourglass icon instead of "Next Steps", when it's available in the MoneyReportHeaderStatusBarProps.

The logic for this property (icon) to exists or not in the Next Steps is already done by https://github.com/Expensify/Web-Expensify/pull/42641.
See https://github.com/Expensify/Web-Expensify/pull/42641#issuecomment-2229035139
Fixed Issues
Related to https://github.com/Expensify/App/issues/44785
Tests

[x] Verify that no errors appear in the JS console

Prerequisite: user A has created a Workspace and invited user B as employee

Log in to OldDot as user B
Create a report on the workspace, but do not add any expenses to it
Log in to NewDot ad user A
Go to the workspace chat with user B, click on the report with no expenses

QA Steps

[x] Verify that no errors appear in the JS console
Same as in tests

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Closing the PR as it's already done by C+ here.


Video uploads but doesnt play

after uploading, the video doesnt play but the audio does

is something wrong with your origin video?
maybe you can try upload by website,make sure the video is ok

yeah i uploaded manually with the same file and it works but when I use this to upload the video freeze but the audio still plays

can you send the video to me ?


Removed unnecessary max-width css property

Description
[Describe what this change achieves]
It removes the CSS that restricts the content width to 1400px.
Issues Resolved
[List any issues this PR will resolve]

#1038

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

thanks @Leigh-Ola!  @nateynateynate - can you review this one?

@nateynateynate can you review?

Closing as we've made another decision on max width to remain consistent with the Docs site.


Backport "HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_regions property … (#5403)" to branch-3

Authored-by: Rahul Kumar<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
branch-3 passed

+1 :green_heart:
compile
2m 54s
branch-3 passed

+1 :green_heart:
checkstyle
0m 46s
branch-3 passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 55s
branch-3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

+1 :green_heart:
javac
2m 57s
the patch passed

+1 :green_heart:
checkstyle
0m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 32s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

35m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5419

Optional Tests
dupname asflicense javac spotless xml spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 100dddfdf8d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / d74583c8eb

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
branch-3 passed

+1 :green_heart:
compile
0m 57s
branch-3 passed

+1 :green_heart:
shadedjars
5m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
branch-3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 14s
hbase-common in the patch passed.

+1 :green_heart:
unit
214m 55s
hbase-server in the patch passed.

241m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5419

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c590a451cbe3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / d74583c8eb

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/testReport/

Max. process+thread count
4686 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 30s
branch-3 passed

+1 :green_heart:
compile
0m 49s
branch-3 passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
branch-3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 52s
hbase-common in the patch passed.

+1 :green_heart:
unit
219m 30s
hbase-server in the patch passed.

244m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5419

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1db12c391007 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / d74583c8eb

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/testReport/

Max. process+thread count
4627 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5419/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


fix!(argon2): respect the salt provided in hash options

Close https://github.com/napi-rs/node-rs/issues/893

#899  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on  Graphite

@Brooooooklyn you sir are a gentleman and a scholar 🙏 was debating putting in a PR myself but I saw there wasn't much activity here in a while other than dep bots. Then I was watching a recent Nx update vid and you got a personal shoutout for helping them with some wasi... I was like, wait... where have I heard that name before. Then it all made sense haha. Busy guy.
Appreciate you getting that sorted promptly, PR looks good. Was just thinking if it would need updated benchmarks, but I guess the salt doesn't effect the speed of the hash computation so shouldn't be necessary.
Thanks again


Migration to Identity: Issues in the code snippets

This PR fixes two issues in the code snippets:

We passed the tokenAudience to the ClientSecretCredential as a parameter when ClientSecretCredential does not receive such parameter.
We were not calling the getToken method of the credential used in the sample for the Regarding scopes section. We were instead passing it to a credential.
In the Regarding scopes code snippet, we were also moving from interactiveLogin to AzureCliCredential, which is confusing. Using InteractiveBrowserCredential instead.

I’ll follow up tomorrow!


Can't install portainer - docker compose

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
I moved my portainer folder from /volume1/docker/portainer to /volume2/docker/portainer, and when I tried to recreate it I got the errors below. I've looked this up, nothing exists. I manually added the docker compose plugin to it's path, that didn't fix it. I've deleted and re-pulled the images for both latest and 2.21.0 (the version I had when I did this) but it still does the same thing.
Expected Behavior
It runs with the existing config files it has there. Nothing was touched or changed.
Actual Behavior
Instantly fails to start
Steps to Reproduce
Not Applicable
Portainer logs or screenshots
2024/09/16 19:54:42 | stdout | 2024/09/17 02:54AM FTL github.com/portainer/portainer-ee/api/cmd/portainer/main.go:617 > failed initializing compose deployer \| error="docker-compose plugin is missing from config path" stack_trace=[{"func":"init","line":"18","source":"composeplugin.go"},{"func":"doInit1","line":"6735","source":"proc.go"},{"func":"doInit","line":"6702","source":"proc.go"},{"func":"main","line":"249","source":"proc.go"},{"func":"goexit","line":"1650","source":"asm_amd64.s"}]
-- | -- | --
2024/09/16 19:54:42 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cloud/cluster_setup.go:95 > starting cloud cluster setup service \|
2024/09/16 19:54:42 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/database/boltdb/db.go:125 > loading PortainerDB \| filename=portainer.db
2024/09/16 19:54:42 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:493 > proceeding without encryption key \|
2024/09/16 19:54:42 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:459 > encryption key file not present \| filename=portainer
2024/09/16 19:54:40 | stdout | 2024/09/17 02:54AM FTL github.com/portainer/portainer-ee/api/cmd/portainer/main.go:617 > failed initializing compose deployer \| error="docker-compose plugin is missing from config path" stack_trace=[{"func":"init","line":"18","source":"composeplugin.go"},{"func":"doInit1","line":"6735","source":"proc.go"},{"func":"doInit","line":"6702","source":"proc.go"},{"func":"main","line":"249","source":"proc.go"},{"func":"goexit","line":"1650","source":"asm_amd64.s"}]
2024/09/16 19:54:40 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cloud/cluster_setup.go:95 > starting cloud cluster setup service \|
2024/09/16 19:54:40 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/database/boltdb/db.go:125 > loading PortainerDB \| filename=portainer.db
2024/09/16 19:54:40 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:493 > proceeding without encryption key \|
2024/09/16 19:54:40 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:459 > encryption key file not present \| filename=portainer
2024/09/16 19:54:39 | stdout | 2024/09/17 02:54AM FTL github.com/portainer/portainer-ee/api/cmd/portainer/main.go:617 > failed initializing compose deployer \| error="docker-compose plugin is missing from config path" stack_trace=[{"func":"init","line":"18","source":"composeplugin.go"},{"func":"doInit1","line":"6735","source":"proc.go"},{"func":"doInit","line":"6702","source":"proc.go"},{"func":"main","line":"249","source":"proc.go"},{"func":"goexit","line":"1650","source":"asm_amd64.s"}]
2024/09/16 19:54:39 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cloud/cluster_setup.go:95 > starting cloud cluster setup service \|
2024/09/16 19:54:39 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/database/boltdb/db.go:125 > loading PortainerDB \| filename=portainer.db
2024/09/16 19:54:39 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:493 > proceeding without encryption key \|
2024/09/16 19:54:39 | stdout | 2024/09/17 02:54AM INF github.com/portainer/portainer-ee/api/cmd/portainer/main.go:459 > encryption key file not present \| filename=portainer

Portainer version
2.21.0
Portainer Edition
Business Edition (BE/EE) with 5NF / 3NF license
Platform and Version
Docker 24.0.2
OS and Architecture
Synology NAS - DSM 7.2 - Container Manager Beta 24.0.2-1525
Browser
No response
What command did you use to deploy Portainer?
sudo docker run -d \
  --name=portainer-workplz \
  -p 8000:8000 \
  -p 9000:9000 \
  --privileged \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v /volume2/docker/portainer:/data \
  -v /usr/local/lib/docker/cli-plugins/docker-compose:/usr/lib/docker/cli-plugins/docker-compose:ro \
  -v /usr/local/bin/docker-compose:/usr/local/bin/docker-compose:ro \
  --restart=always \
  portainer/portainer-ee

Additional Information
No response

Hi @nathangur, could you clarify what you're trying to achieve here?
You mentioned you had Portainer running, deployed via Docker Compose. In your Compose file, you were using a bind mount for the Portainer volume instead of a named volume, which is what we recommend. The bind mount worked on  /volume1/..., but after changing it to  /volume2/..., it no longer functions as expected?
Could you share the Compose file you're currently using? The command provided above is a Docker run command and appears to follow some outdated steps. I recommend referring to our official documentation for the latest guidance: https://docs.portainer.io/start/install/server/docker/linux.
Here’s an example of a Docker Compose file based on our official Docker run command:
version: '3.9'
services:
  portainer-ee:
    image: 'portainer/portainer-ee:2.21.1'
    volumes:
      - 'portainer_data:/data'
      - '/var/run/docker.sock:/var/run/docker.sock'
    restart: always
    container_name: portainer
    ports:
      - '9443:9443'
      - '8000:8000'

Hi @nathangur, could you clarify what you're trying to achieve here?
You mentioned you had Portainer running, deployed via Docker Compose. In your Compose file, you were using a bind mount for the Portainer volume instead of a named volume, which is what we recommend. The bind mount worked on  /volume1/..., but after changing it to  /volume2/..., it no longer functions as expected?
Could you share the Compose file you're currently using? The command provided above is a Docker run command and appears to follow some outdated steps. I recommend referring to our official documentation for the latest guidance: https://docs.portainer.io/start/install/server/docker/linux.
Here’s an example of a Docker Compose file based on our official Docker run command:
version: '3.9'
services:
  portainer-ee:
    image: 'portainer/portainer-ee:2.21.1'
    volumes:
      - 'portainer_data:/data'
      - '/var/run/docker.sock:/var/run/docker.sock'
    restart: always
    container_name: portainer
    ports:
      - '9443:9443'
      - '8000:8000'

I tried again using the following commands but I got the same error.
docker volume create --driver local \
    --opt type=none \
    --opt device=/volume2/docker/portainer \
    --opt o=bind \
    portainer_data

version: '3.9'
services:
  portainer-ee:
    image: 'portainer/portainer-ee:2.21.1'
    volumes:
      - 'portainer_data:/data'
      - '/var/run/docker.sock:/var/run/docker.sock'
    restart: always
    container_name: portainer-workplz
    ports:
      - '9443:9443'
      - '8000:8000'

volumes:
  portainer_data:

@nathangur Does the deployment work the same way if you switch the volume path back to volume1? If so, what are the permissions on volume1 and volume2?”

@nathangur Does the deployment work the same way if you switch the volume path back to volume1? If so, what are the permissions on volume1 and volume2?”

This is on a  Synology Nas shared folder.
The permissions are exactly the same as before.

@nathangur Can you please confirm if the deployment does actually work on volume1, or do both paths fail? I'm just wanting to confirm as you mentioned.

It runs with the existing config files it has there. Nothing was touched or changed.

Unfortunately I can't test if it works on volume1, but opening up the portainer database (just in vs code since I'm not sure what database this is) I can see 61 references to volume1.

So, what I can gather is you are running this deployment from your Synology NAS. I have one so I tested the above steps as you.
I made sure I had a volume1 path, and SSH'd into my NAS.
I created the volume.
Nick@Nebula:~$ sudo docker volume create --driver local \
>     --opt type=none \
>     --opt device=/volume2/docker/portainer \
>     --opt o=bind \
>     portainer_data
Password:
portainer_data

And deployed the compose you pasted above.
 I did find some more info around how Synology treats volumes though.
Each volume on your Synology NAS (e.g., Volume 1 and Volume 2) has its own separate filesystem, meaning they operate independently of each other in terms of data storage and application configuration. When you first set up Docker and Portainer, they were configured to run from Volume 1, and Docker was storing all relevant data, images, and containers in the paths associated with that volume.
Here’s what happens when you move Docker-related files from Volume 1 to Volume 2:
Separate Filesystems: Volume 2 doesn’t automatically inherit the configurations or settings from Volume 1. Docker and Portainer were initially set up to work with paths and settings related to Volume 1, and simply moving files to Volume 2 doesn’t update these internal references.
Docker Root Path: By default, Docker uses /volume1/@docker to store important data (like images, container files, and volumes). Moving Portainer to Volume 2 means that Docker may still be looking for critical data in Volume 1, which would cause it to fail when trying to recreate containers.
File Permissions: Each volume may also have different file permissions. Moving files between volumes can sometimes alter the permissions, preventing Docker from accessing the necessary files on Volume 2.
So this seems related to how Synology is working with Docker and if you want to move to Volume2 you will need to configuire your NAS to support this.

I have setup all of my other containers on volume2 successfully by deleting their images and recreating them. Portainer is the only one with a problem. I've cleared it's image, and I copied over the @docker folder from volume1 or volume2.

@nathangur Have you tried taking a backup of Portainer, and redeploying fresh on Volume 2 then restoring the backup?

At this point I'm just going to create a new clean portianer install.

@nathangur Yes, this seems very specific to how Synology manages Docker. If you are going to re-deploy Portainer and if it's running on Volume 1, you can backup that instance and restore it on your fresh deployment


JSON parse errors

https://bitsharestalk.org/index.php?topic=10713.msg141069#msg141069

I have same issue with linux debian and bitshares 0.9.2 : Not connected, and same error messages.
I have try to delete all data-dir including wallet, but I have still same problem.
When I open file logs/default/default.log I get these precisions :
Utilities.cpp:36
2015-07-10T01:06:04        th_a:?unnamed?          log_message ] Message from GUI: rpc error: JSON Parse error: Property name must be a string literal (undefined)
Utilities.cpp:36
2015-07-10T01:06:06        th_a:?unnamed?          log_message ] Message from GUI: js error: JSON Parse error: Property name must be a string literal

○ onload@http://localhost/js/app.js:6:27018                    Utilities.cpp:36
2015-07-10T01:06:04        th_a:?unnamed?          log_message ] Message from GUI: rpc error: JSON Parse error: Property name must be a string literal (undefined)
Utilities.cpp:36
2015-07-10T01:06:06        th_a:?unnamed?          log_message ] Message from GUI: js error: JSON Parse error: Property name must be a string literal
parse@[native code]
○ S@http://localhost/js/app.js:5:1994
○ eb@http://localhost/js/app.js:6:4543
○ http://localhost/js/app.js:6:4970
○ f@http://localhost/js/app.js:4:59539
○ ib@http://localhost/js/app.js:6:4952
○ e@http://localhost/js/app.js:6:10592
○ i@http://localhost/js/app.js:6:46623
○ http://localhost/js/app.js:6:46795
○ $eval@http://localhost/js/app.js:6:83467
○ $digest@http://localhost/js/app.js:6:81981
○ $apply@http://localhost/js/app.js:6:83741
○ f@http://localhost/js/app.js:6:17681
○ r@http://localhost/js/app.js:6:26478
○ onload@http://localhost/js/app.js:6:27018                    Utilities.cpp:36
2015-07-10T01:06:06        th_a:?unnamed?          log_message ] Message from GUI: rpc error: JSON Parse error: Property name must be a string literal (undefined)
Utilities.cpp:36
2015-07-10T01:06:07        th_a:?unnamed?          log_message ] Message from GUI: js error: JSON Parse error: Property name must be a string literal

SOLVED :
I found that I need to execute this command line :
export LC_ALL="en_US.UTF-8"
after each reboot and before I launch Bitshares. And the bug disappears.

Using export LC_ALL="en_US.UTF-8" solved me the problem too.


feat: concoctions for kiwi purchases

it's not a coinmaster because the kiwitini takes two currencies. There was discussion on #2341.


Separate bridge code from the core API

So far, the Crux core was fused together with the serialisation code supporting the FFI. This PR makes changes to separate the serialisation code into a self-contained Bridge, which will handle

Serialising and deserialising data for the FFI
Parking the effects emitted by the app under a UUID so they can be resolved later once the Shell is done.

The key changes in this are in how Effects, Steps,  and Operations stack up. Previously, Steps contained Effects, which contained Operations. That meant that Steps did not have access to Operation type information and had to work on serialised bytes. By swapping the order, Steps are now generic over Operations and Effect bundle them into an enum for the purposed of dispatch. Each of the types has a specific job:

Effect allows a type-checked dispatch in the Shell to the right capability implementation
Step (now an enum too) captures the semantics of the interaction - is it a notification, a request with a single response, or a subscription with a stream of responses
Operation captures the data needed to fulfil the interaction, and with the Operation::Output type, also the type of the result

There are a few consequences:

Rust clients get a strongly typed API for the core with no serialisation in site 🎉
Capability context construction had to change because of the assymetry between a Context of Effect and Contex of Step (not a big deal, just no introduce a different type for the initial construction and updated the macro)
Sadly, this changes the Shell API once more. It now needs to be aware of steps.
This should, however, allow us to build foreign language interfaces to the core which hide the serialisation entirely, making Crux look native to them, and that API can now be the stable managed interface. This means that type generation and serialisation changes should no longer impact Shells. Or at least not as often.
Not sure if AppTester is still necessary, it might be entirely possible to simply work with the core directly now

@obmarg I'd love to get your feedback on the work so far. I'm fairly confident this will work, but I may have missed something major.
To do

[x] re-stack Effect and Step
[x] remove serialisation code
[x] revisit construction of CapabilityContext
[ ] implement Bridge and StepRegistry for the new world
[ ] update all Rust clients in examples, which now need to be step aware
[ ] revisit AppTester and see if it's still needed

Current dependencies on/for this PR:

master

PR #87   👈

This comment was auto-generated by Graphite.

@charypar thanks for the details. I won't say I have it 100% clearly yet, but your explanation helps a lot. This bit seems like the "crux" of the library—the tricky part—passing work to capabilities and back in a way that works across any platform.


improved inferred type when using $Call

https://flow.org/try/#0C4TwDgpgBAsiDyAjAVlAvFA3gKClAhgFxQDOwATgJYB2A5gDS5SLHUCuAtohOYwL7YAxgHtqZKLQjAAguigAKYcThJkASnQA+LE3JS25alGEA6fAG5sA7BAAeYYeWBRQkKAFFbFfIOAAlfUMAHgAxam0MABIAYXwAGzigoIAVTXl5E0yASWAefEQ4iCD8ahBNDTRtZIqq+igwzUtsV2g-OU9vXwDgA2ogluEAMwkpaU0mbHkARgAGYj8NKCA
when using $Call flow won't show the inferred type
it show type R = ExtractReturn<(o: MyObj) => string>
instead of saying that R is a string
how can we improve this?

This now works.


Error: Cannot find module 'react-dev-utils/getPublicUrlOrPath'

npm start is currently broken because react-dev-utils is missing from package dependencies
Steps to reproduce:

Fresh clone of repository
npm install to install all dependencies
npm run start to run examples
I'd expect this to work but the process instead gets interrupted with "Error: Cannot find module 'react-dev-utils/getPublicUrlOrPath'"

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


Use the diff variable

Use the diff variable instead of target - num.
https://github.com/neetcode-gh/leetcode/blob/1f7b2f33a5a3bac535284f6f1b10c442f0c508ca/java/1-Two-Sum.java#L14

Fixed here #727


Automated Blob Saving (Aaron shut the other ideas down ;( )

Automated Blob Saving
Describe the feature you'd like
Add a option in the settings that pulls our nonce and saves blobs automatically. Maybe make it manually, or automated during Jailbreaking Process..
Additional context
Despite there being things such as TSS-Saver, most people are too technologically illiterate and/or have the memory of no memory. We forget to save or blobs, or people don't know how to. This is an "Ease of Access" feature in which would enhance the usage of u0-dark.
TAKEN INTO CONSIDERATION ^

Looked into the issue, unfortunately it's not really feasible.


Use fast D: drive if available

Some Azure VM types have a temporary disk which is local to the VM and therefore provides much faster disk IO than the OS Disk (or any other attached disk).
Hosted GitHub Actions runners also leverage this disk and do their work in D:/a/_work, so let's use it too if we can. It leads to a ~25% speed increase when doing heavy IO operations.
Ref: https://learn.microsoft.com/en-us/azure/virtual-machines/managed-disks-overview#temporary-disk

It's now available as v1.7.0 of this Action.


Add NetBSD support

This depends on the PR I sent yesterday (dcuddeback/ioctl-rs#5). With these two, the tests pass.

@bsiegert Thanks. Could you update the README to add NetBSD and any architectures that you've been able to verify? https://github.com/dcuddeback/serial-rs/tree/master/serial-unix#compatibility

@bsiegert Thanks. Could you update the README to add NetBSD and any architectures that you've been able to verify? https://github.com/dcuddeback/serial-rs/tree/master/serial-unix#compatibility

@bsiegert Compatibility needs to be updated in two READMEs, actually. The one I linked earlier (serial-unix) as well as the one for serial (https://github.com/dcuddeback/serial-rs/tree/master/serial#compatibility).

@bsiegert Compatibility needs to be updated in two READMEs, actually. The one I linked earlier (serial-unix) as well as the one for serial (https://github.com/dcuddeback/serial-rs/tree/master/serial#compatibility).

Done, thanks.

We would need this to be merged as well.
https://github.com/arxanas/git-branchless/issues/1047


Add dtype argument to channel and pixel norm functions

What is the purpose of this PR?
Closes #612. The dtype argument currently isn't propagated through to the channel and pixel normalization functions, causing the load_imgs_from_tree calls to attempt to load the images using the default int16 type. This will throw a warning if the images were of type float32 regardless of if the user passed float32 to create_pixel_matrix.
How did you implement your changes
Add dtype with a default argument of int16 to both calculate_channel_percentiles and calculate_pixel_intensity_percentile. Explicitly pass the dtype argument received by create_pixel_matrix to these functions.

Did you run the notebook to confirm there aren't any other load_imgs functions that also need to be passed the dtype parameter?

Good point, smooth_channels was the remaining function that was missing an explicit dtype arg.

Will you also default it to 'float32' since that's what rosetta produces

Will you also default it to 'float32' since that's what rosetta produces

Should we also change the default argument of create_pixel_matrix to float32?

Yeah definitely


Identity ask: Support navigation properties that target an un-mapped base type (incl generics)

This has been fixed. You can use a cast in the Fluent API to specify the mapped entity type:
 builder.Entity<TUser>().HasMany(u => (IEnumerable<TUserClaim>)u.Claims).WithOne();


Merge settings and keys as done in Django, the system we're using this from

I know this is debated, but after having to work on it, I really don't see the point. Having all of these files open and trying to find witch one is the one you should be messing with for what value is really annoying, especially since a lot of the time, like with database stuff, you'll be messing with values from both. We also already have support for local.py, so we don't even need anything else to make sure we don't push the keys.


AppxPackagePayload in vcxproj not working when building for Store

Steps to reproduce
Adding AppxPackagePayload files will build locally, but won't make their way into the final .appx package.
Project file
      <AppxPackagePayload Include="$(ProjectDir)..\DatabaseGen\CorePackage.dat">
        <TargetPath>CorePackage.dat</TargetPath>
      </AppxPackagePayload>

Please, file a VS Feedback item for this through Visual Studio and your issue will be triaged to the appropriate team.
The logic for this does not leave on this repo. Filling the VS feedback item will make the team responsible for this aware of your issue quicker.


feat(oxc_linter): implement eslint(use-isnan)

Gave the rule generator a try and implemented eslint(use-isnan)

Awesome work! Thank you!


Test Suite

Overview
Currently, this library doesn't have a running test suite yet. It seems that @vue/test-utils still breaks on TS + Vue 3 project.
Mitigation
Setup a working test suite AND a runnable, passing sample test file.

Hi,
Please assign this issue to me

@anatdagan
I'm sorry, but I think my explanation for this issue is not clear enough.
The contribution I'm looking for is implementing test suite for testing vue 3 SFC component, NOT for testing normal JS and TS files.
Just a simple, passing mount and shallowMount will do

@Namchee
Hi,
I've been making experiments adding a test suite to your project and reached the conclusion that for vue 3 we need to use https://github.com/vuejs/vue-test-utils-next/, as mentioned in the test-utils documentation:
Vue Test Utils 1 targets Vue 2.
Vue Test Utils 2 (the link above) targets Vue 3.
The issue is that test utils next does not yet support shallowMount.
Implement it never the less, and just do mount test for now?
Thanks

@anatdagan
Thank you for your efforts!
I'm aware that we need the next version for @vue/test-utils, that's why this project uses 2.0.0-beta-5 as its dependency.
I didn't know about lack of shallowMount support though.
Yeah, just do a simple mount test and verify that it contains something.

Hi @Namchee ,
Where is the CSS object defined?
Thanks

@anatdagan
This project doesn't have any CSS on it. Users must style the component by themselves for now.

I mean in the component there is a line
if (
CSS.supports('-moz-transform-style', 'preserve-3d') ||
CSS.supports('-ms-transform-style', 'preserve-3d') ||
CSS.supports('-webkit-transform-style', 'preserve-3d') ||
CSS.supports('transform-style', 'preserve-3d')
) {
and jest throws an error that CSS is not defined

I see that this is browser native code. I'll mock it.

Oh, I missed your point sorry.
Yeah, that's a browser only variable.

Closed by #2


Add a raw (Buffer::Instance) gRPC interface (for use by WASM).

Add a raw (Buffer::Instance) gRPC interface (for use by WASM).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This is being upstreamed.  A version is already included in the gRPC PR as well.


[Bug] When the user converts from the Form Modal to Alert Modal the button gets missing

https://www.notion.so/When-the-user-converts-from-the-Form-Modal-to-Alert-Modal-the-button-gets-missing-0cad2f9df86944f591bd79ab39201686

Closing this issue, as this feature doesn't exist.


add --annotationSetName param. Reduce annotation batch size

LGTM

Paul, you are quite right. The documentation has been updated. Thanks!

Always happy to help :)
Thanks,
~p


Extended undo functionality

This has been sitting around in a branch since, oh, 2015 or so...
Adds support for two new opcodes:
@hasundo S1: Test whether a VM state is available in temporary storage. S1 is set to 0 if a state is available, 1 if not. If this returns 0, then restoreundo is expected to succeed.
@discardundo: Discard a VM state (the most recently saved) from temporary storage. If none is available, this does nothing.
This is the equivalent Glulx change: https://github.com/erkyrath/glulxe/compare/8d3bee4..c2362481ce2e13deddb845d62dc29ffba81ce274

Test for the new opcodes:
https://github.com/erkyrath/glk-dev/blob/double/unittests/discardundotest.inf
https://github.com/erkyrath/glk-dev/blob/double/unittests/discardundotest.ulx


[BugFix] Fix null flag comparison for intra-chunks

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #22437
Problem Summary(Required) ：

When the previous chunk and the current chunk have some same keys, we compare the nullable previous column with the current data column, _first_column->compare_at(column.data_column, 1).
If the value of this key is null, _first_column->compare_at(column.data_column, 1) will return false, which causes the new column is considers as a new key.
[...., null, null] [null, 1, ....]

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


There should be a system for whitelisted roles

[x] https://github.com/space-wizards/space-station-14/pull/28085
[ ] Whitelist CO
[ ] Whitelist SEA

https://github.com/space-wizards/space-station-14/pull/28085

Done in https://github.com/CM-14/CM-14/commit/858a030fef71874e9fe39336962097b99e43c83f


Style guide

To reduce fragmentation in our CLI and to improve some of the interactions we use, we are going to produce a style guide.
This issue will act as a central hub for all things style guide, which will start with discussion around each major area of input/output.

Tables and lists
Success, failure, and error states
Whitespace and layout
Input prompts
Rich formatting

We can use this issue to talk a bit about our philosophy and approach to general layout of the tool.
Talking points

Args vs options vs flag
Hierarchy of commands (nested vs top level)
Naming

Tense, plurality, etc

Some inspiration and resources:

Our own @jeffandersen's Designing for CLI post
Heroku CLI Style Guide
Angular style guide has an interesting format with notes for Do, Consider, Avoid etc
IEEE Standars guide

We had a good discussion about this IRL last week. Didn't get into specifics as much as general philosophy but a good kick off for discussion.
To start the discussion here, I'll make some reaches as to how I think the points above should be addressed and go from there:
Args vs options vs flag
Arguments are passed into options so that doesn't really warrant much discussion, I'll just talk about options for the time being.
These are currently being referred to in the documentation as both options and flags. In the code they're referred to as flags (for the most part). To keep it consistent and for simplicity's sake, we should call them options when referring to both global/command options.
Options should be in the format of two dashes with one phrase after: --option. In the case of a multi word phrase, words should be separated by a dash: --multi-word. Each option should contain a sensible shortcut version like -O for --option.

Command Naming/Describing
The general guide to naming a command should be to make it as simple and relevant as possible. When writing a description of the command for help, or in a hint (!), I think we add to the style guide that being concise is key. We have documentation where you can expand and explain more verbosely.
Tense
Should consistently be in Future I Simple – basically will without actually saying will. torus profile will Manage your Torus account. Don't restate the command. Example:
Correct

torus profile: Manage your Torus account
torus send: Send an invitation to join an organization to an email address

Incorrect

torus profile: Profile manages your Torus account (restates and wrong tense)
torus send: Sent and invite to join (wrong tense)

Plurals
I don't think we can assign too many rules to plurality. As long as you are consistent, plurality will change on a case by case basis.
For example, it makes sense for torus invites to be plural because invite would infer a verb, like torus invite <user>. However, the help for invites mixes the words invites with invitations when describing invitations. Using invitations in the descriptive text and only using invites when referring to the command would help make the help more clear.


Article for Power Automate and Logic Apps

Category

[ ] Content fix
[X] New article
[] Example checked item (delete this line)

Related issues

mentioned in #285

Contents of the Pull Request
Article and Screenshots.
Feedback welcomed.

Docs Build status updates of commit d6650b2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Community/power-automate-vs-logic-apps.md
:warning:Warning
View
Details

Community/media/power-automate-vs-logic-apps/azure-logic-app-example-error-checking.png
:white_check_mark:Succeeded
View

Community/media/power-automate-vs-logic-apps/azure-logic-app-example.png
:white_check_mark:Succeeded
View

Community/media/power-automate-vs-logic-apps/example-visual-studio-code.png
:white_check_mark:Succeeded
View

Community/media/power-automate-vs-logic-apps/mobile.jpeg
:white_check_mark:Succeeded

Community/media/power-automate-vs-logic-apps/power-automate-example-error-checking.png
:white_check_mark:Succeeded
View

Community/media/power-automate-vs-logic-apps/power-automate-example.png
:white_check_mark:Succeeded
View

Community/power-automate-vs-logic-apps.md

Line 2, Column 1: [Warning-ms-author-missing] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 2, Column 1: [Warning-ms-prod-or-service-missing] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 33, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/power-platform/admin/wp-data-loss-prevention' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 33, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/logic-apps/block-connections-connectors' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 39, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/azure-functions/functions-compare-logic-apps-ms-flow-webjobs#compare-microsoft-power-automate-and-azure-logic-apps' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 63, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/logic-apps/export-from-microsoft-flow-logic-app-template' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 77, Column 1: [Warning-link-out-of-scope] File 'media/power-automate-vs-logic-apps/mobile.jpeg' referenced by link 'media\power-automate-vs-logic-apps\mobile.jpeg' will not be built because it is not included in build scope.
Line 86, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/logic-apps/manage-logic-apps-with-visual-studio' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 112, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/learn/browse/?terms=Automate&products=power-platform' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 116, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/learn/browse/?products=azure&terms=Logic%20Apps' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 61, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Mobile view of Power Automate' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 77, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Mobile view of Power Automate' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Thanks, @pkbullock! I'll take a look and fix those warnings.


Help with websocket client

Describe what you would like to know or do
I'm trying to implement a Java websocket client using this library, and connecting/communicating with a Node.js websocket server using this library. This server uses mkcert to generate valid SSL certificates for localhost and <IP_ADDRESS> addresses.
I've written something like the following within some method in some object that gets run:
WebSocketClient client = new WebSocketClient(URI.create("wss://localhost")){
      @Override
      public void onOpen(ServerHandshake handshake){
        System.out.println("Websockets connected");
      }

      @Override
      public void onMessage(String message){
        System.out.println(message);
      }

      @Override
      public void onClose(int code, String reason, boolean remote){

      }

      @Override
      public void onError(Exception e){

      }
};
client.connect();

and on the server side a little message would log whenever a new websocket connection comes through. Issue is, when I run this Java client, the server does not output anything (no connection), and the onOpen method doesn't run either.
Is there something obvious I am missing here?
The server should have no fault as I am able to connect using a web browser WebSocket client.
Describe the solution you'd considered
Checks to make sure client connect() actually is called.

A few moments after I posted this, I realized that I didn't implement onError so I did and the stack trace shows an SSLException which probably means the SSL certificate I used for localhost isn't being certified by Java.
I took a look at mkcert and reinstalled the trust store for Java and it works now.
It looks like ultimately this issue was unrelated to the library; sorry about this. I will close the issue now.


Allow to work with raw Json payload for document API

The current implementation expects the developers to provide BEAN to be populated.
As the unmarshalling / deserialization could be customize allow to work with Raw Json or provide options to implement external mapper.

Released part of 0.2.4


WIP: Use tiff ifd Value enum from tiff crate

Refactor to use tiff::decoder::ifd::Value instead of the in-house crate::lowlevel::TagValue enum.
Part of #7.

Big refactor at #17 means the vec_to_tag_value method is not used anymore, so closing.


underline in markdown

Hi, can it add for an underline?

Hi,
MarkdownUI is fully compliant with the CommonMark Spec, which doesn't support underlined text.


HADOOP-16859: ABFS: Add unbuffer support to ABFS connector

Added two unit tests: ITestAbfsUnbuffer and ITestS3AContractUnbuffer
Ran ABFS tests against "East US 2"; the following tests failed:
ITestGetNameSpaceEnabled.testNonXNSAccount
ITestAbfsRestOperationException.testRequestRetryConfig
ITestAzureBlobFileSystemAuthorization.testSetOwnerAuthorized
ITestAzureBlobFilesystemAcl.testEnsureAclOperationWorksForRoot

I've seen most of these failures before and they all seem to be account related issues. I haven't seen ITestAbfsRestOperationException#testRequestRetryConfig before, but it looks like it was recently added and uses a custom token provider, so my guess is the failure is account related as well.

just realised ... that contract test doesn't ever verify that the data read back on an unbuffer/resume actually matches what should be there at the given offset.
I think you should cache the dataset and validate the reads, so that if the reconnect got confused, it would surface.
Similarly, do we need tests for unbuffer followed by positioned readable reads?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  4s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 14s
trunk passed

+1 :green_heart:
compile
18m 57s
trunk passed

+1 :green_heart:
checkstyle
3m  5s
trunk passed

+1 :green_heart:
mvnsite
2m 19s
trunk passed

+1 :green_heart:
shadedclient
22m  7s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 26s
trunk passed

+0 :ok:
spotbugs
0m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  0s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 17s
the patch passed

+1 :green_heart:
compile
17m  7s
the patch passed

+1 :green_heart:
javac
17m  7s
the patch passed

-0 :warning:
checkstyle
2m 46s
root: The patch generated 8 new + 1 unchanged - 1 fixed = 9 total (was 2)

+1 :green_heart:
mvnsite
2m  2s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 28s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s
the patch passed

-1 :x:
findbugs
1m  6s
hadoop-tools/hadoop-azure generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m 11s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 29s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

130m 49s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.bCursor; locked 81% of time  Unsynchronized access at AbfsInputStream.java:81% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.fCursor; locked 85% of time  Unsynchronized access at AbfsInputStream.java:85% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.limit; locked 81% of time  Unsynchronized access at AbfsInputStream.java:81% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1847

JIRA Issue
HADOOP-16859

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 4a826a51c27a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / da99ac7

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/1/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/1/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/1/testReport/

Max. process+thread count
1375 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  8s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m  2s
trunk passed

+1 :green_heart:
compile
16m 58s
trunk passed

+1 :green_heart:
checkstyle
2m 38s
trunk passed

+1 :green_heart:
mvnsite
2m 14s
trunk passed

+1 :green_heart:
shadedclient
20m 20s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 43s
trunk passed

+0 :ok:
spotbugs
1m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  5s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 18s
the patch passed

+1 :green_heart:
compile
16m 15s
the patch passed

+1 :green_heart:
javac
16m 15s
the patch passed

-0 :warning:
checkstyle
2m 34s
root: The patch generated 7 new + 1 unchanged - 1 fixed = 8 total (was 2)

+1 :green_heart:
mvnsite
2m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
13m 59s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 42s
the patch passed

-1 :x:
findbugs
1m 12s
hadoop-tools/hadoop-azure generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
9m 14s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 38s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

121m 43s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.bCursor; locked 81% of time  Unsynchronized access at AbfsInputStream.java:81% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.fCursor; locked 85% of time  Unsynchronized access at AbfsInputStream.java:85% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.limit; locked 81% of time  Unsynchronized access at AbfsInputStream.java:81% of time  Unsynchronized access at AbfsInputStream.java:[line 406]

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1847

JIRA Issue
HADOOP-16859

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 0bb125c3fde1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c75756f

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/2/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/2/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/2/testReport/

Max. process+thread count
1736 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractUnbufferTest.java:36:  protected Path file;:18: Variable 'file' must be private and have accessor methods. [VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractUnbufferTest.java:129:  protected void validateFileContents(FSDataInputStream stream) throws IOException {: Line is longer than 80 characters (found 84). [LineLength]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47:    byte[] data = ContractTestUtils.dataset(16, 'a', 26);:45: '16' is a magic number. [MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47:    byte[] data = ContractTestUtils.dataset(16, 'a', 26);:54: '26' is a magic number. [MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:49:            16, true);:13: '16' is a magic number. [MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:56:      assertTrue("unexpected stream type " +:44: '+' should be on a new line. [OperatorWrap]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:81:    assertEquals("S3AInputStream#read did not read the correct number of " +:76: '+' should be on a new line. [OperatorWrap]

LGTM; little bit of tuning left

Had to make a few more fixes to the tests to get them to pass, but I re-ran ITestAbfsUnbuffer and ITestAbfsContractUnbuffer on ABFS and confirmed they pass.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 50s
trunk passed

+1 :green_heart:
compile
22m 49s
trunk passed

+1 :green_heart:
checkstyle
3m 26s
trunk passed

+1 :green_heart:
mvnsite
2m 42s
trunk passed

+1 :green_heart:
shadedclient
25m 58s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m  2s
trunk passed

+0 :ok:
spotbugs
1m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 51s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 58s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 44s
the patch passed

+1 :green_heart:
compile
18m 21s
the patch passed

+1 :green_heart:
javac
18m 21s
the patch passed

-0 :warning:
checkstyle
2m 50s
root: The patch generated 5 new + 1 unchanged - 1 fixed = 6 total (was 2)

+1 :green_heart:
mvnsite
2m  3s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 53s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed

+1 :green_heart:
findbugs
3m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m  1s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 39s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

149m 57s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1847

JIRA Issue
HADOOP-16859

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 948bcebd37d2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0cfff16

Default Java
1.8.0_232

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/3/artifact/out/diff-checkstyle-root.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/3/testReport/

Max. process+thread count
1343 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Fixed all the checkstyle issues besides the following:
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47:    byte[] data = ContractTestUtils.dataset(16, 'a', 26);:45: '16' is a magic number. [MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:47:    byte[] data = ContractTestUtils.dataset(16, 'a', 26);:54: '26' is a magic number. [MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsUnbuffer.java:49:            16, true);:13: '16' is a magic number. [MagicNumber]

It's complaining that the parameters to ContractTestUtils.dataset should be static final int but I'm not sure thats worth it, we don't do there with the other uses of ContractTestUtils.dataset anyway.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 58s
trunk passed

+1 :green_heart:
compile
23m 16s
trunk passed

+1 :green_heart:
checkstyle
3m 17s
trunk passed

+1 :green_heart:
mvnsite
2m 39s
trunk passed

+1 :green_heart:
shadedclient
26m 10s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 47s
trunk passed

+0 :ok:
spotbugs
1m 13s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 54s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s
the patch passed

+1 :green_heart:
compile
20m  7s
the patch passed

+1 :green_heart:
javac
20m  7s
the patch passed

-0 :warning:
checkstyle
2m 49s
root: The patch generated 3 new + 1 unchanged - 1 fixed = 4 total (was 2)

+1 :green_heart:
mvnsite
2m  1s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 28s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s
the patch passed

+1 :green_heart:
findbugs
3m 18s
the patch passed

_ Other Tests _

-1 :x:
unit
10m  0s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 37s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

147m 46s

Reason
Tests

Failed junit tests
hadoop.security.TestFixKerberosTicketOrder

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1847

JIRA Issue
HADOOP-16859

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 1935d8e6f77b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ac4b556

Default Java
1.8.0_232

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/4/artifact/out/diff-checkstyle-root.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/4/testReport/

Max. process+thread count
3257 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1847/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

+1
don't worry about magic numbers in tests; I don't

merged to trunk, thanks!


[Docs] Added callback signatures to AppBar doc.

#3191 and #3096
I'll continue working through the rest on the list if these look OK.

Thanks for picking this up, it's really appreciated! :+1:
Unless I'm mistaken you can use markdown, so in general, when referring to a another prop or or component, you can wrap it in backticks IconMenu. When referring to the design element, it's normal text: Icon Menu.
Otherwise, looks great!

Ok, I'll make those changes. Thanks!

Thanks a lot @theosherry


Colmap Instructions and Scripts

Readme with instructions and shortcomings, scripts for trying to do fancier things that I wasn't able to get fully working in time.

Ah, one more general comment is that pylint is really helpful. I find some of its warnings silly and don't bother to fix everything it reports, but it's usually worth running anyway. I'm pretty sure it would have caught several of the things I commented on.


fix: Added raw functionality in update schedule (fix #518)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description
On schedule update the raw content is not considered initially, updated the code accordingly to consider the raw content also.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Can one of the admins verify this patch?

ok to test


tips for faster dev on macs

Maybe this should go in the wiki instead of README. This seems like the best workaround that lets me edit code natively and build/test in docker.

Yeah - the wiki is a better spot - we have Mac build instructions there: https://github.com/istio/istio/wiki/Preparing-for-Development-Mac
...but they are oudated now and don't cover ARM Mac quirks. I don't have edit perms - @linsun does.

I do as well. Just going to throw them there. Almost nothing in the wiki has any info about ztunnel (yet).


How do I redirect the user to the HomePage if he was logged in before, using Flutter Redux?

I want to implement user authentication using redux.
My Steps:

check if the user info was stored locally or not using shared preferences. till then keep him at FlashScreenPage.
If the info is found, Redirect him to the HomePage()
If the info is not found, redirect him to LoginPage().

This is my root widget (main.dart)
import 'package:flutter/material.dart';
import 'package:flutter_ecommerce/pages/flash.dart';
import 'package:flutter_ecommerce/pages/login.dart';
import 'package:flutter_ecommerce/pages/register.dart';
import 'package:flutter_ecommerce/redux/actions.dart';
import 'package:flutter_ecommerce/redux/reducers.dart';
import 'package:flutter_redux/flutter_redux.dart';
import 'package:redux_thunk/redux_thunk.dart';
import 'package:redux/redux.dart';
import 'package:shared_preferences/shared_preferences.dart';

import 'models/app_state.dart';

//enum LogMode {loggedout, login, flashscreen}

void main() {
  final store = Store<AppState>(
    appReducer,
    initialState: AppState.initial(),
    middleware: [thunkMiddleware],
  );

  runApp(MyApp(store: store));
}

class MyApp extends StatefulWidget {
  final Store<AppState> store;

  const MyApp({Key key, this.store}) : super(key: key);
  @override
  State<StatefulWidget> createState() {
    return MyAppState();
  }
}

class MyAppState extends State<MyApp> {
  LogMode mode = LogMode.flash;

  @override
  void initState() {
    super.initState();
  }

 // void checkForUser() async {
  //   final prefs = await SharedPreferences.getInstance();
  //   var storedUser = prefs.getString('user');
  //   if (storedUser == null) {
  //     setState(() {
  //       mode = LogMode.logout;
  //     });
  //   } else {
  //     setState(() {
  //       mode = LogMode.loggedin;
  //     });
  //   }
  // }

  @override
  Widget build(BuildContext context) {
    return StoreProvider(
      store: widget.store,
      child: MaterialApp(
        title: 'Flutter Redux',

        routes: {
          '/': (BuildContext context) => mode == LogMode.flashscreen ? FlashscreenPage() : mode == LogMode.loggedout ? LoginPage() : HomePage();       //here lies the problem
          '/register': (BuildContext context) => RegisterPage(),
          '/home': (BuildContext context) => ProductsPage(),
        },
      ),
    );
  }
}

this is my store:
import 'dart:convert';
import 'package:flutter_ecommerce/models/user.dart';
import 'package:meta/meta.dart';

enum LogMode {loggedout, login, flashscreen}

@immutable
//you cant change the below class or its sub classes
class AppState {
  final User user;
  final LogMode mode;
  AppState({@required this.user, @required this.mode});

  factory AppState.initial(){
    return AppState(user: null, mode: LogMode.flashscreen);
  }
}

This is what I want to do.
As soon as the app restarts, the code should check if the user was logged in before or not using shared preferences. Since this task is an async process. I want to redirect the user to FlashScreenPage() which is a statelessWidget. After that async process gets completed, if the user had his info stored in the memory then I want him to be redirected to the HomePage else to LoginPage.
I achieved this using the checkForUser() method in my main.dart just by simple setState method.
But the problem is that I was unable to update the App Store (or state) of the App. i.e the user was logged in.
For doing that I would have to dispatch another action in the initState of the HomePage() to set the User info.
But that would cause another problem: Every time I will redirect to the HomePage(), the initState will  keep on changing the AppState unnecessarily. (running HomePage multiple times => means running its initState multiple times => means dispatching action to update Store multiple times)
How do I solve this?
my flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.18.0-10.0.pre, on Linux, locale en_IN)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.32.3)
[✓] Connected device (1 available)

• No issues found!

The Github issue tracker is for bugs and features requests for the Flutter SDK. Help and support questions like these are better suited for Q&A sites like StackOverflow or on one of the flutter community sites at https://flutter.dev/community .


Replace RemovedComponents with a Removed query filter

What problem does this solve or what need does it fill?
The existing RemovedComponent API is somewhat unclear and cumbersome. It also commonly requires a manual query filtering step to make use of, which is both slow and full of boilerplate.
What solution would you like?
I want to be able to add Removed<T> to my queries as a filter to only include entities that have had the component removed since the system last ran using reliable change detection.
What alternative(s) have you considered?
We could also store the values of the removed components, but that won't be feasible with reliable change detection.
Additional context
With the addition of subworlds / multiple worlds (https://github.com/bevyengine/rfcs/pull/16), we could move removed components to a parallel purgatory subworld for two frames using a double-buffer pattern, allowing us the ability to access removed data.

Could this be implemented prior to subworlds just as a filter, in such a way that Query<&MyComponent, Removed<MyComponent>> would be empty? I think that such an implementation would be useful - as you said, Query<Entity, (Removed<MyComponent>, OtherFilter)> is a lot nicer than RemovedComponents<MyComponent> and manual filtering. However, it could be confusing to later totally change the semantics of the query using subworldsso that Query<&MyComponent, Removed<MyComponent>> does return data.

Yep, this should be totally feasible before subworlds. I think that only allowing it in the filter position for now is just fine; we're always going to want that ability.
Once we can access the removed data I think that the correct approach is to do something like Query<MyData, (), Purgatory> with the third type parameter representing the world it's drawing from rather than trying to implicitly overload the Removed type with different durations based on which position it's in.

From my draft of the relevant section of the book:

While Added and Changed operate on the basis of "since the last time this system ran", removal detection only works for the last frame. This distinction is very important if your system does not run every frame due to states or run criteria.
RemovedComponents does not return the value of the component that was removed, due to performance concerns. If you need this, you will need to include your own change-detecting system to cache the values before they are removed.
RemovedComponents is a system parameter, not a query filter. As a result, you will have to manually compare it to the results of a query if you only need to handle some subset of component removal events.


Cannot find module 'react-popper'

In my React-Meteor app after upgrading the materiali ui to the latest version today I have noticed weird behaviour:

After downgrading to beta-41 everything goes back to normal.

I get same error for 1.0.0-beta.44 and 1.0.0-beta.40

react-popper has just cut a release after #11196

I confirm, it's just broken.

Use<EMAIL_ADDRESS>for now.

This should be ok with<EMAIL_ADDRESS>

Just to clarify: the solution is to install react-popper as well as material ui?

@timothyallan No, it's to make sure the yarn/npm resolution of this transitive dependency is OK.

cool, installing react-popper as well as material ui fixes it for us on b44 ;)

I installed react-popper as well as material-ui and I still get the message about missing react-popper... it happens only in watch mode and only on alternate compilations!! yarn 1.6.

I'm using react-popper 0.10.4 also :(

Same here, happened only on alternate compilations for
<EMAIL_ADDRESS>(2,30): Cannot find module 'react-popper'.

@MkbCtrl
Thanks for the comment. Which version of material-ui do you use now?

For the time being none, I have to pause developemnt, I was using beta's
On 13 Jun 2018, 15:43 +0200, Kazuya Gosho<EMAIL_ADDRESS>wrote:

@MkbCtrl
Thanks for the comment. Which version of material-ui do you use now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay, thanks!

Any progress with it?

@akazakou react-popper is on it's way out of Material-UI. It should be solved with next release.

@oliviertassinari thank you! But it anyway, maybe it helps you resolve the problem https://github.com/mui-org/material-ui/issues/11266#issuecomment-399409660

I ran into a variation of this. It seems somewhere in the code is says javascript import warning from "warning";  instead of ```javascript
import warning from "./warning";

But this seems react-popper related and not material-ui. Checking there also.

@richtera We do no longer use react-popper in v4.


Remove unnecessary reallocation

Reuse input/output buffer and prevent unnecessary reallocation when encrypting/decrypting stream synchronously.

Thanks. Merged. I will do a new nuget release a bit later.

Thanks. Merged. I will do a new nuget release a bit later.


Added role based security to the PolicyRestrictor

Currently the default acces restrictor, which is based on an XMl policy file, doesn't have any restriction on the currently connected Principal (i.e. the restrictions apply to every connected user).
Therefor the access restriction format should be extended to provide a possibility to define certain roles (and associated users with roles).
E.g.
<restrict>

  <!-- User to role mapping -->
  <users>
    <user name="joe" role="admin"/>
    <user name="nagios" role="monitor"/>
  </users>

  <!-- Role to restrict-set mapping  -->
  <role name="admin">
    <restrict ref="monitor"/>
    <restrict ref="management"/>
  </role>

  <role name="user">
    <restrict ref="monitor"/>
  </role>

  <!--  Dedicated "restrict sets" reference by a role definition  -->
  <restrict name="monitor">
    <allow>....</allow>
  </restrict>

  <restrict name="management">
    <allow>....</allow>
  </restrict>

  <!-- ================================================================= -->
  <!-- Default applying to all users which are not explicitly configured -->
  <allow>....</allow>

</restrict>

With this scheme several indirections are configured: user-to-role, role-to-restrictset. Also, an extension like this would be backwards compatible to the current scheme.
While we are on it, a XSD schema would be nice, too.

Sorry for the super late response, just sorting things and found this issue again.
I started to work on 2.0 again (since I now can put more efforts into Jolokia) and role based security is definitely something I consider to add for 2.0 (but probably not for 1.x anymore).


Godot v3.0 GUI doesn't work well

OS: Archlinux amd64
Godot v3.0 Build: 2017-12-16.13:03:24.9079be9e8 from http://godot3builds.digitecnology.com
Issue description:
When you use Godot v3.0 focus disappears randomly in the entire GUI and things are no more selectable using the mouse and you can't click anything. Only Alt+F4 works to exit and keys.
Steps to reproduce:

Open Godot v3.0 (using build with commit id 9079be9e8 from Digitecnology Godot 3 Unofficial Builds server.
Open a Project, add a gltf model, add nodes, etc
The GUI selection/focus fails.

I think that commit got reverted, try a more recent build

I assume this was fixed in a more recent build. Comment if it's not the case.

Yes, It was fixed in a recent build. It works well now.