perf: let's try parallel xz and gz

This is more of an experiment, then a real thing. This may or may not give a little speedup.
pixz has been a parallel alternative to xz for some time before xz finally implemented -T flag for compression. And it has parallel decompression, while xz -d, ignores this flag until very recent versions (and we use a pretty old Debian distro, so probably not our case).
pigz is a parallel gzip from the author of the algorithm himself. Definitely faster, but we only use gz on smaller files, will not necessarily be noticeable, but why not squeeze it anyways.
Both pixz and pigz are compatible with their respective "default" tool, in both directions.

Thank you both for the compression exploration! Should we close this since we've already moved and mergedzstd?

Agreed re: closing this. We do still produce xz-compressed and gzip-compressed files paralleling the new zstd-compressed files, right?, so there may still be gains to be had with parallel compression/decompression of xz and gzip. But it's not a big deal to revisit this down the road if we need to.


Issues can be closed via API (#3170)

Adds support to change an Issues status via the REST-API. (Fixes #3170)
Depends on gogits/go-gogs-client#41
(Edit: builds failing because of dependency)

@Unknwon done :)

Thanks!


Deleted user stores are listed in management console/console app in tenant mode

Describe the issue:
Deleted user stores are listed in management console/console app in tenant mode
How to reproduce:

Create two user stores through console app
Delete one of the user store xml file.
check user store list in MC/CA
Still deleted user store listed

Expected behavior:
delete user store shouldn't be listed
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [IS-5.11.0-beta2-anashot]
OS: [Linux]
Database: [POSTGRE]
Userstore: [JDBC]

Cannot reproduce in wso2is-5.11.0-beta3-SNAPSHOT


python3.pkgs.bitarray: mark broken on aarch64

Some tests fail.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

no need to: https://github.com/NixOS/nixpkgs/pull/120323


Self-query with generic query constructor

Alternate implementation of #3452 that relies on a generic query constructor chain and language and then has vector store-specific translation layer. Still refactoring and updating examples but general structure is there and seems to work s well as #3452 on exampels

HOT HOT HOT :fire: :fire: :fire:

:upside_down_face: :upside_down_face: :upside_down_face: :upside_down_face:

I am also noticing that in the case NO_FILTER is returned, the query output by the LLM is often a single phrase. When this phrase is then searched on the vector store, the matches are worse than if I had taken the original query and searched it directly on the vector store.
In other words, while the self query is supposed to be a superset of the standard querying (structured + unstructured), the unstructured querying seems inferior to using the vector store directly.
docsearch = ....
retriever = docsearch.as_retriever()
sq_retriever = SelfQueryRetriever.from_llm(
  llm, docsearch, document_content_description, metadata_field_info, verbose=True
)

# this uses the entire phrase for similarity match
retriever.get_relevant_documents("What is the capital city of Vermont?")

# whereas assuming there is no structured operator here, the phrase sent to the vector store might just be "Vermont"
sq_retriever.get_relevant_documents("What is the capital city of Vermont?")


Cannot install: src/vcdiff.h has a syntax error

Hello,
Trying to install this using NPM on a system with G++ 4.9 I get the following error during compilation:
  CXX(target) Release/obj.target/vcdiff/src/vcd_decoder.o
In file included from ../src/vcd_decoder.h:14:0,
                 from ../src/vcd_decoder.cc:7:
../src/vcdiff.h:20:40: error: expected class-name before ‘{’ token
 class VcdCtx : public node::ObjectWrap {
                                        ^
../src/vcdiff.h:51:46: error: ‘Arguments’ in namespace ‘v8’ does not name a type
   static v8::Handle<v8::Value> New(const v8::Arguments& args);
                                              ^

...etc.  My guess is that this is perhaps not compatible with Node.JS version 5?

I successfully compiled the binaries on Node v6.2.0 after installing g++ v4.8 (it recommended this in .travis.yml).


New Content Update Request: Latinx Therapy

Address the following:
"Hello- We are redoing our site and have come across the link above. We noticed that our logo is being used but with the wrong URL. Can you please either adjust the URL and title to Latinx Therapy, as we do provide online and in-person services in individual and group format, pro bono work as well, or please replace the logo to reflect Therapy for Latinx? I understand this may have been an oversight as the names are similar."
correct org name: Latinx Therapy
correct link: www.latinxtherapy.com

Removing them in #701 - they can be added back


Date picker label flickering when changing dates

When changing between dates, date picker label flickers changing its size briefly.

http://materialapex.com/pls/apex/f?p=12192:25:::NO:::

I tried reducing the flicker but the way we display the header section is by appending it manually. I think for now it is inevitable.


#1334 Match versionPattern when explicitly set blank

Fixes #1334

Hi @hetzijzo,
Thanks for submitting this issue and pull request.
We are in the process of re-working maven resolution and will get to this once that work is complete.

Thanks for your patience @hetzijzo. This will be released shortly with 7.18.0


Cukes not passing when...

Running on Ruby 1.9.2,
Related to Cucumber 1.1.5.  Please see: http://stackoverflow.com/questions/3232856/cucumber-errors-suppressed-not-displayed-fully
It seems that cucumber made a breaking change, and either moving back to 1.1.4 or tracking their master would get around this issue.  May be related to the travis-ci issue.
Note: I did not have this issue on Ruby 1.9.3 which I've been developing on most of the day.

Fixed in #1045.


Support --insecure-skip-tls-verify for package and dependency update

When working with an OCI registry and self signed certificates I'm unable to package an umbrella chart that has references to dependencies in the OCI registry.
Both helm dependency update and helm package -u fail with the error tls: failed to verify certificate: x509: certificate signed by unknown authority
Ideally these commands would support --insecure-skip-tls-verify like push and pull.

That isn't the case for the reason mentioned in the comment at https://github.com/helm/helm/pull/12128#issuecomment-1644817792
Package and dependency update also don't support --plain-http - that should probably be a separate issue as I'd imagine you'd run into a similar problem.

I don't have an insecure registry offhand to test against. But #12128 I believe supported this already

#8868  Helm dep build/update inherit --insecure-skip-tls-verify from helm repo add.
This means we need to first run helm add repo and then helm dependency build/update.
But 'repo' and 'dependency' are two distinct operations, and there is no direct correlation between them.
If we could directly execute helm dependency build/update --insecure-skip-tls-verify add a configuration option in the Chart.yaml .
...
dependencies:
- name: postgresql
  repository: https://xx.com
  insecure_skip_tls_verify: true
  tags:
  - postgresql
  version: 13.2.x

it would feel even better.

Can confirm this.
We are migrating from deprecated Harbor's ChartMuseum to oci registry (so we can update Harbor itself) in our dev (self-signed) enviroment.
Only way how can run helm dependency update, while using oci dependency, is add ca cert to system trusted, because there is no --insecure (as in registry login) / --insecure-skip-tls-verify (as in push/pull/show) nor --ca-file flags.

reopening this item to confirm that the issue either continues to exist or has been resolved

I can confirm that this issue is still present

Issue still present with PR pending


delay10Seconds timer not set/reset when entering background

Hi
I am trying to user your code in my app, and found our few problems:

I changed the main timer from 1 minute to 5 mintes,  delay timer stays at 10s. When you start app, it update locations and finish after 10 seconds. Then put app to background, you it will start updating location again - and will update them in background for more than 4 minutes, when main timer reset again. I think you should not call [locationManager startUpdatingLocation] in -applicationEnterBackground. Is this a bug or you wanted it this way for some reason? Maybe it was just not that obvious with 1 minute timer, but with longer timer it is a problem. If I set timer for 1 hour, it would constantly update location for one hour after going to background.

Wouldn't it be better if instead of creating separate timer for updateToServer, just put call to [self updateToServer] in -stopLocationDelayBy10Seconds  ? At this point you always has the most current user location.

Hi ,voyage11, thanks for sharing !   I want to upload my locations every 200 meters to server. no matter the app is active or in background or is killed ,I can do that  . but when I run your project ,and kill the app ,it could not upload the location to server ,how can I do that?thanks !


Suddenly began appears: "Class "PDO" not found" .. and PDO is activated..

Describe the bug
Instance ID: 172d6f1a-8182-448d-9555-4c6388b3a605 Error Code: #0 Component: Generic
How to reproduce
In the front and backend appears the same error and nothing loads
Expected behavior
The login screen
Screenshots

FOSSBilling version
0.6.22
FOSSBilling instance ID
172d6f1a-8182-448d-9555-4c6388b3a605
Module version
No response
Device
No response
Information
No response
Additional context
No response

It's very unlikely this is an issue with FOSSBilling and most likely is related to your server setup.
Could you please share what PHP version you are using, the host OS software, and what control panel (if any?).
Thank you!

First, rename your sample-congig.php to config.php and delete the install directory. Change 'debug' => false, to 'debug' => true, in config.php so that you can see the real things behind the error. You can then upload that screenshot here and error info here.
I think this is mostly a problem with di.php. You can find the Class PDO on line 93.
The most possible reason for this problem is your webserver configuration. Try reinstalling it (if possible). If on shared hosting, try contacting your web hosting manager for help.
I had this error with Cpanel LightSpeed Server Running PHP 8.2.5 . I then reinstalled my server with Ubuntu apache and Hestia Control Panel  PHP 8.2.5 and everything worked well.


How to use custom SQL in metric field in chart?

Can someone kindly tell how to use custom sql feature in metric field in charts? Is is similar to writing sql queries in SQL editor in superset? Can this feature work with postgresql?

The custom SQL allows you to define a metric using any valid expression for the DB you're targeting. For example, if you're using Postgres with the GIS extension you could define a metric that is the area of a given geometry by using the following expression in the custom SQL tab:
ST_Area(geom)

When clicking "Run Query" Superset will compose a query that would look like:
SELECT ST_Area(geom) AS `ST_Area(geom)`
...

You can inspect the query generated by going into the hamburger menu in the top right and clicking "View query":

Thanks for the detailed explanation.

How to display columns with alias names in raw records and also how to write a custom SQL query.  I


Move CI from Travis to Github Actions

We should move CI to Github Actions.
If possible we should seperate compile/testing from bench-marking so we can visually verify which once broke. i.e. like in case such as bumping Arrow to 0.10.3

The last part is already done in travis but yes I agreed. I suppose it's time for Hood-Actions


Update deployment.md: fix format error

Signed-off-by: Minjie Huang<EMAIL_ADDRESS>

Signed-off-by: jarhmj<EMAIL_ADDRESS>


Including Alpine JS after Livewire script

Question
Answer

Issue or Enhancement
Issue

Laravel Version
8.12

Project Version
3.5

Current Behavior

Livewire is complaining alpine should be initialized after Livewire

Expected Behavior
Position the alpine.js script after the livewire script
Steps to Reproduce
Activate livewire in adminlte.php config file then add the following code to the plugins section of the config
...
'Alpine' => [
            'active' => true,
            'files' => [
                [
                    'type' => 'js',
                    'asset' => true,
                    'location' => 'vendor/alpine/alpine.min.js',
                ]
            ]
        ],
...

Possible Solutions
I know that we can publish the main views and then modify the page layout, but i want to know if this is possible without publishing

I don't think you can, and publishing the main views will help you a lot when enabling laravel mix.

@pieter-stephanus right, i'll do the publishing method. Thank you for answering.


Support for macOS Monterey

Support for macOS Monterey
Description
Adding support for macOS Monterey M1 local build.
Brief Description of the PR:
Adding changes to bazel configuration and scripts to enable building from source for macOS Monterey M1.
Fixes # (issue)
Type of change

[x] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[x] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
Locally
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Next Steps:

Drop bazel version increase (already done)
Increment the minimum build version in make_wheel_macOS_arm64 to 12
Increase the plat-name (as is done in this PR)

@kulinseth we're looking to publish macos ARM64 wheels for TFA, but have heard that the package will not resolve for Monterey users since it's plat-name is for macos-11.  Given that M1 chips have better performance on macos-12 (I think?) we wanted to make sure that majority of users will be able to resolve a TFA for macos-12 built for ARM.
However, I noticed tensorflow-macos is still publishing macos-11 plat-names:
https://pypi.org/project/tensorflow-macos/2.7.0/#files

Is there a plan to increase the OS of the tensorflow-macos build?
Also is it true that macos 12 users will not be able to resolve/install an earlier tensorflow-macos if it's labeled in pypi with a prior macos version? Thinking about this a bit more I'm confused since we publish our TFA x86_64 wheels for macos-10 and haven't heard this complaint.

@seanpmorgan , thanks for the issue:

@kulinseth we're looking to publish macos ARM64 wheels for TFA, but have heard that the package will not resolve for Monterey users since it's plat-name is for macos-11. Given that M1 chips have better performance on macos-12 (I think?) we wanted to make sure that majority of users will be able to resolve a TFA for macos-12 built for ARM.

These wheels should work on MacOS 12 as well. To make sure macos-11 users don't regress, we were releasing with plat-name macos-11.

However, I noticed tensorflow-macos is still publishing macos-11 plat-names: https://pypi.org/project/tensorflow-macos/2.7.0/#files

Is there a plan to increase the OS of the tensorflow-macos build?

https://pypi.org/project/tensorflow-macos/2.11.0/#files
I think this has been addressed.

Also is it true that macos 12 users will not be able to resolve/install an earlier tensorflow-macos if it's labeled in pypi with a prior macos version? Thinking about this a bit more I'm confused since we publish our TFA x86_64 wheels for macos-10 and haven't heard this complaint.

These should work for macos-12 users. When releasing your wheels you want to release for the minimum deployment target for MacOS which is supported. The arm64 support has been added since macos-11, and some users had requested support on Macos-11, so we were releasing with that plat-name. But since then macos-12 and macos-13 stable versions have been released, so we have bumped it up to macos-12.  Please let me know if there are any concerns.


fix: avolid duplicate secgroup name error when create secgroup

这个 PR 实现什么功能/修复什么问题:
避免因名称重复导致创建安全组失败问题
是否需要 backport 到之前的 release 分支:

release/2.12
release/2.13

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3569 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3569      +/-   ##
=========================================
- Coverage    6.96%   6.94%   -0.02%
=========================================
  Files         498     498
  Lines       83492   83499       +7
=========================================
- Hits         5813    5802      -11
- Misses      77185   77204      +19
+ Partials      494     493       -1

Flag
Coverage Δ

#aFlag
6.94% <0%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/multicloud/ucloud/securitygroup.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/region.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/securitygroup.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/ucloud/region.go
0% <0%> (ø)
:arrow_up:

pkg/cloudprovider/fakeregion.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/ucloud/instance.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/vpc.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/ucloud/vpc.go
0% <0%> (ø)
:arrow_up:

pkg/cloudcommon/cronman/cronman.go
49.51% <0%> (-5.34%)
:arrow_down:

pkg/compute/models/cloudsync.go
0% <0%> (ø)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eceb9a8...bad8132. Read the comment docs.

/lgtm

/approve

/approve


Update sbt to 1.3.6

Updates org.scala-sbt:sbt from 1.3.5 to 1.3.6.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #1351 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1351      +/-   ##
=========================================
+ Coverage   85.66%   85.8%   +0.13%
=========================================
  Files          59      59
  Lines        2198    2198
  Branches      103     103
=========================================
+ Hits         1883    1886       +3
+ Misses        315     312       -3

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/JsonNumber.scala
93.97% <0%> (-2.41%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.25% <0%> (+0.26%)
:arrow_up:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
84.79% <0%> (+0.58%)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
80% <0%> (+1.21%)
:arrow_up:

...d/src/main/scala/io/circe/cursor/ArrayCursor.scala
69.23% <0%> (+7.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d7d98...e3e7cf0. Read the comment docs.


( Songselect V1 ) Added UI For beatmaps infomation display

New Songselect UI Display infomation ( WIP )
This is for Songselect V1 only
New songselect design has not supported due already create by. arflyte

done but i fix later


Introduce 'interval' to control the scheduler interval

Fixes #165
Hey!  So I'm extremely noob here, but this seems to be passing npm test for me locally..  Is it right?  Help very welcome!

View rendered README.md

Thanks for the speedy review, @hiimbex!  Hopefully we can figure out how to test this and verify it works, meanwhile I've pushed changes for the easy parts.

Any thoughts, @bkeepers?  I'd love to be able to tweak this behaviour in stale bot!

@hiimbex How do you feel about accepting this as is, and forward-fixing any issues if they crop up?
I'd be happy to submit a follow-up PR with a test for this, once we have some idea how to test it.

@dwijnand I still this needs updating since as I mentioned, the schema isn't actually used in the index.js, only from stale, so the changes to the schema and it's test should be removed since they're never used.

Done!  Despite it not being used, I thought it would be good to have for consistency.  But I don't mind dropping it.


onActivityResult calling before result back from the captureactivity.

Description of the problem:
I am calling   new IntentIntegrator(this).initiateScan();  from activity. It's work fine on 5.0 and above Android os version but on old version 4.2 onactivityresult callback immediately when initiate scan.
Which library version are you using? E.g. 3.2.0.
compile 'com.journeyapps:zxing-android-embedded:3.3.0'
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Android 4.2
Does the same happen on other devices or an emulator?
Device
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

I face this on Android 7.0 and Android 5.1. So camera activity isn't closed after result is provided

Some bugs around this has been fixed since this issue was opened. Please create a new issue with a stack trace if the issue persists in 3.5.0.


it is best to solve the configuration of domestic image acceleration.

After Sealer deploys K8S, it is best to solve the configuration of domestic image acceleration. This is common and practical, and also ensures that the sealer cluster is clean, avoiding users from setting it up themselves, and it is also prone to errors.

@fi-ecavc , sealer has built-in registry which contains all needed container images. for domestic image acceleration, do you mean pull another image after the cluster is up?


networking: fix segfault when slirp4netns is missing

fixes a segfault when slirp4netns is not installed and the slirp sync pipe is not created.
Closes: https://github.com/containers/libpod/issues/4113
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

code lgtm

added another patch that fixes a different segfault when trying to refresh CNI plugins in rootless mode.
I think we should get this in for the release

/lgtm
/hold
hold cancel when tests pass.

Little late for 1.6.0, tag is made. We'll probably need a 1.6.1.
On Tue, Oct 1, 2019, 08:51 Daniel J Walsh<EMAIL_ADDRESS>wrote:

/lgtm
/hold
hold cancel when tests pass.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/4139?email_source=notifications&email_token=AB3AOCCK4YIVOM5DPSHVKGTQMNBWHA5CNFSM4I3XP5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABEZRY#issuecomment-537021639,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3AOCDBNIUS7YRNVI35AITQMNBWHANCNFSM4I3XP5SA
.

/hold cancel


Update test for changed core HTTP header handling

What it says on the tin.

Once #3368 is addressed this would need to change back. Maybe the test shouldn't be 'fixed'...?

Sorry for this hanging out idle for so long when it could easily have gone in. Merging now.


Fixed bug with setDate and triggerChange = false

If  triggerChange in setDate is false - and date value is empty - "Change" event triggers whatever.

Coverage remained the same at 87.848% when pulling b332c9e2fce54b137646d3fe5ec200e5ae722098 on zerkalica:patch-1 into d15f4ca15baf471e8783b797970e80c367b8608c on chmln:master.


Workflows API rate limited in CI/CD?

Context
I think we are hitting some kind of rate limit in CI/CD. Every now and then the following error message appears.

Although, one would expect that if it were a rate limiting issue, simply waiting an amount of time and rerunning the workflow should resolve it; however, that is not the case. Often pushing a new commit resolves it.
We mostly use the inbuilt GITHUB_TOKEN with workflow-appropriately scoped permissions via the permissions block. Except where a workflow would open a PR (e.g., the bump image tags workflow), which instead swaps GITHUB_TOKEN for a token generated by a GitHub App. (This is because we went tests to run on the opened PR, but this doesn't happen if it was opened by GITHUB_TOKEN.)
Checkpoints

[x] The immediate problem is gone because time passed and our limit was reset
[x] Wait until https://github.com/2i2c-org/meta/issues/417 is resolved
[ ] Re-ping github if we don't hear by 2022/11/21

Found this in the docs:

When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

https://docs.github.com/en/rest/overview/resources-in-the-rest-api#requests-from-github-actions

We may need to update all our workflows so that they swap out GITHUB_TOKEN for a PAT from our GitHub App: https://github.com/organizations/2i2c-org/settings/apps/2i2c-token-generator-bot
This code already implements this: https://github.com/2i2c-org/infrastructure/blob/72ae1c824b9c6021fc3cd3597c187c549a5f90c5/.github/workflows/bump-helm-versions.yaml#L39-L50
docs: https://docs.github.com/en/developers/apps/building-github-apps/rate-limits-for-github-apps

Note: Chris requested a free non-profit plan for us which would increase the number of requests per hour per repository we can make with GITHUB_TOKEN

We could also refactor the validation workflow so that the step that inspects changed files (and hence uses GITHUB_TOKEN) is extracted from the matrix and only executed once, we then dynamically generate a matrix of clusters to validate, similar to the deploy-hubs workflow.

Work proposed in the above comment has been completed I propose we wait and see if:

Chris's request for a gitHub non-profit plan is accepted
When we next hit this issue (frequency may drop if it doesn't disappear completetly?)

before we decide if further action needs to be taken and if so, what

We are still seeing this issue. I opened a ticket with GitHub Support: https://support.github.com/ticket/personal/0/1904943
I might be the only one able to see that link, so here is what I asked:

Hello,
We are regularly seeing failed GitHub Actions runs with messages such as: "API rate limit exceeded for installation ID 10159873." I'm wondering if there's a way we can track our API usage of the GITHUB_TOKEN per workflow over time so we can identify where in our pipeline is causing this issue?
Many thanks,
Sarah

Response from GitHub support was unhelpful. It was basically to have a step at the start of every workflow that was use GITHUB_TOKEN to request information on how many calls it had left from the API. That wasn't helpful as I wanted aggregate data over time, maybe differentiated by workflow, to understand where the token was being used. So I feel we are edging into "build your own dashboard" territory here and that is not a useful application of our time, IMO.

Quick question, @sgibson91. How frequent the failure is after the improvements/changes landed?

maybe we should have an issue where people can comment "bump" or something whenever they see this message as a poor proxy?

Maybe this one is the issue to bump it (since it has already the context so it is probably more findable by search).

@sgibson91 I see the failure on dorny-filter to see if files has changed etc, and I see that we have @actions/checkout that doesn't download repo history.
I wonder if the action may avoid making as many github api requests if we would have the full git history locally available.
Do you have a guess if fetching all of the git repo's history could help us?

I frequently hit spurious failures due to this on pull requests and would like to advocate for it to be considered to be fixed in an upcoming sprint, we rely on CI/CD for deployments and they are currently brittle due to this issue - cc @damianavila

I would love for it to be fixed too, the problem is we don't exactly know what the cause is

Nod - so the story to be put in would need to include that investigation component

Response from GitHub support was unhelpful.

Here was the response for context:

Hi Sarah,
Thank you for reaching out to GitHub Support!
You could add a step in your workflow file to check the GITHUB_TOKEN rate limit through out API.
Something like this:
steps:
    - name: Get our GITHUB_TOKEN API limit usage
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       run: |
         curl -H "Accept: application/vnd.github.v3+json" -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/rate_limit

https://docs.github.com/en/rest/rate-limit?apiVersion=2022-11-28
We hope this helps! If you have any other questions about using GitHub Actions, we recommend asking in our GitHub Community Forum:
https://github.com/orgs/community/discussions/categories/actions-and-packages
Cheers,
GitHub Support

The scope for the current 2023_10 sprint is to have a discussion about possible avenues to investigate this problem given the uncertainties that we currently have.
I will call a specific meeting for @sgibson91 @consideRatio and me as required and the rest of the engs as optional to start digging into this one. I will send the invites soon.

Since I've recently invested time into investigating this, can I please also join this meeting and efforts? Thanks!

OK, invitations were sent for a 50 min slot that was free for @sgibson91, @GeorgianaElena, and @consideRatio.
I might not be available at that time slot but it was a good sport for the 3 of you (and I am pretty sure I am not required for this conversation to move it forward). So, please carry on with the meeting if I do not show myself at the scheduled time.

Rate limiting
Some context about how the rate limit applies:

When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

There are also different rate limits depending on: if you're using a token or an app, whether the endpoint you call generates notifications (e.g., creating comments).
ref: https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting
Debugging ideas

Request and print the remaining API quota at the start and end of workflow executions, such as the code in https://github.com/2i2c-org/infrastructure/issues/1686#issuecomment-1589512820
Inspect multiple workflows and search for failure patterns using a script
Inspect a recent failure, e.g., https://docs.google.com/document/d/1QwdEyJZI6866NjOoFYW8IQmKhSc0xouJHMHaCfQSRP4/edit
Print information about API quota contained in the headers of all API responses

Resolution strategies
In some workflows, we exchange the default GITHUB_TOKEN for a token from a GitHub App, which has a higher rate limit and does not experience the same restrictions that the default token does. We could implement this in all workflows and see if that helps.
Action items

[ ] Sarah to write a script that will pull all failed runs that mention rate limiting in the logs to see which workflows are failing and how often. We should only pull workflow runs that occur after the merge of this PR to de-bias against it's effects https://github.com/2i2c-org/infrastructure/pull/2627#event-9499058419 but that (at time of writing) only leaves us with 2 days worth of data. So should maybe wait a month also to allow data to accumulate.
[ ] Create some way of visualising how often each of our workflows are executed over time
[ ] Investigate some other quicker investigative methods while waiting for data to accumulate

I'm a little bit suspicious of the paged function in ghapi which we use in a couple of places in our workflows. Sometimes I've seen it loop almost indefinitely (and it makes an API call to a new page on each iteration) when if you inspect the total count of results in the response, all the results fit on a single page and paged wouldn't need to loop at all.
I'm opening a PR to replace ghapi with straight forward requests and we can look for the Link variable in the response headers to determine whether pagination needs to happen or not.

I have compiled some analysis plots as well. Firstly, how many times per month are each of our workflows triggered, and then looking at how many times workflows failed with the API rate limit error in the logs.

Source code (everything is on a branch at the minute): https://github.com/sgibson91/github-workflow-run-analysis/tree/adding-basic-scripts
View the visualisation notebook on mybinder: https://mybinder.org/v2/gh/sgibson91/github-workflow-run-analysis/adding-basic-scripts?urlpath=lab%2Ftree%2Fworkflow_run_vis.ipynb

So far, we have only had one failure related to the API rate limit since the merge of #2627, and the script that caused it has since been updated to use a more trusted method of making API calls.

#2667

In the interim, I also fixed a few other bugs that were causing failures in various CI workflows (usually related to missing permissions):

https://github.com/2i2c-org/infrastructure/pull/2722
https://github.com/2i2c-org/infrastructure/pull/2698

waiting for data to accumulate

How much time do we want to wait for data collection?

So far, we have only had one failure related to the API rate limit since the merge of https://github.com/2i2c-org/infrastructure/pull/2627

1 failure in 3 weeks is less than I was expecting, do you think the refactor helped a little bit?

How much time do we want to wait for data collection?

Next Monday will be 28 days since the merge of the PR and I think that is ample time to detect any trends.

1 failure in 3 weeks is less than I was expecting, do you think the refactor helped a little bit?

I think #2627 helped a lot

This is awesome, thanks for working on this one @sgibson91!!


Improve Warning on propertyschema Normalization

If the propertyschema ("key") did not change during normalization, do not emit a warning about it being replaced.
Closes #222

This change is

if it works, it lgtm.
i'd used a generator comprehension, but i think i'm compulsive concerning comprehensions.

Indeed, it's easy to throw generators everywhere. Actually I'm surprised I didn't in this scenario...
Anyways, I locally ran a few of my projects with my updated fork and the warnings have now disappeared.

Thanks!


mount via different authorization example needed

[
it would be nice to have an example of mounting the disk with account storage key (authorization approach), below example did not work as it has this exception "java.lang.NullPointerException: authEndpoint"
https://docs.databricks.com/_static/notebooks/data-sources/mount-azure-blob-storage.html
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61440a4c-46d2-2450-c2f8-144b237d2d6e
Version Independent ID: 61440a4c-46d2-2450-c2f8-144b237d2d6e
Content: Mounting cloud object storage on Azure Databricks - Azure Databricks
Content Source: databricks/data/mounts.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

#please-close

Current documentation says one can do something, but it has exceptions. So why not fix it?

Databricks recommends migrating away from using mounts and managing data governance with Unity Catalog. For more information, see https://learn.microsoft.com/en-us/azure/databricks/dbfs/mounts.


Add support for loading modules from user-specified paths

Add support for loading modules from user-specified paths, via '--osp:modulepaths' command line arguments or the OSPRAY_MODULEPATHS environment variable.
In either case, the set of paths to try when loading modules is specified as a semi-colon separated list of  paths, e.g.:
--osp:modulepaths "/home/cgribble/modules;/usr/local/modules"

Hi Christiaan,
We will politely decline this PR as we would like to favor the approach of using LD_LIBRARY_PATH (Linux) or PATH (Windows) to direct ospLoadModule() to the right library. This is currently broken, but we intend to fix it as a part of our upcoming v1.0.1 release.
Cheers,
Jeff


Map attribution

Currently no attribution is visible on the map. The tiles are coming from carto, so presumably we should have some OSM attribution on the map, right?

This may even need to be dynamic depending on what layers are selected (Places is licensed differently)

Added an initial set of attributions for Carto/OSM: https://github.com/OvertureMaps/io-site/pull/53.
+1 to bdon's point on long term needing more complex logic.

see our attribution information here: https://docs.overturemaps.org/attribution/


Using json alternative in [Page] endpoints.

Describe the problem
The results of endpoints are transformed to and interpreted as JSON. But JSON does not deserialize some data types properly, like dates or maps.
Describe the proposed solution
Allow other de/serializers like superjson or cbor. It might be a simple configuration option that sets a serializer and deserializer function to be used alternatively.
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

I'm... a little confused.
export const get = () => {
  const myComplicatedObject = getMyComplicatedObject();

  return: {
    headers: {
      'Content-Type': 'application/json'
    },
    body: myCustomSerializer(myComplicatedObject)
  }
}

Does that not work?

The manual serialization might work in the endpoints, and you might manually deserialize your fetch result in the frontend. But as far as I understand, the fetching mechanism of page endpoints is not interruptable...

I'm trying to understand why it needs to be interruptable -- it seems like the worst case for using a custom serializer/deserializer is, what, three or four extra lines of code?:
// index.ts
export const get = () => {
  const myComplicatedObject = getMyComplicatedObject();

  return: {
    headers: {
      'Content-Type': 'application/json'
    },
    body: {
      content: myCustomSerializer(myComplicatedObject)
    }
  }
}

// index.svelte
<script lang="ts>
  export let content: string;
  let deserializedContent = customDeserializer(content);
</script>

Is there a more complex usecase that makes this harder?

It's not the worst case, you're right. But it's boilerplate code on every page that I don't consider good style. Allowing the user to set a custom de/serializer to access the own backend seems more elegant to me. It's just my opinion...

One gotcha this could help avoid is when the data changes between server and client. i.e. the content contains Date objects, but then ISO format strings on the client and ... errors (not a good experience, unclear why for new users).

According to https://github.com/sveltejs/kit/issues/5960#issuecomment-1217964620 and https://github.com/sveltejs/kit/issues/5960#issuecomment-1218494704 it seems likely that Svelte-Kit will end up using https://github.com/rich-harris/devalue for sending data from the server to the client (e.g., in +page.server.ts load functions.

That's only a solution if access to that server data is always through the matching SK front-end.
Maybe you have other apps or components that would like to fetch data in standard JSON format.

If you're doing that, it sounds to me like it should be your responsibility for just deserializing it yourself.  That sounds an awful lot simpler than telling SvelteKit how it should be automatically interpreting certain JSON responses. If you have an endpoint (either internal to the app or external to it) that returns data in a certain format, you just need to interpret it correctly.

I would, if SvelteKit provided the hooks to enable it. But you get one kind of data on the server and different data (because it's been JSON serialized) on the client. If I could override the deserialization or set a reviver function to be used, it wouldn't be a problem. But the only way right now AFAIK is to do double serializing which is horrible.

I was just about to open an issue about that. We have no way of passing a replacer function to JSON.stringify() on the server or a reviver function to JSON.parse() on the client because there are no hooks for that in Svelte Kit. I consider the ability to transform responses a very basic and important feature.

Does #6008 address this? I'd be interested to hear if there are cases that devalue wouldn't cover (especially once we add BigInt support).

That's only a solution if access to that server data is always through the matching SK front-end.
Maybe you have other apps or components that would like to fetch data in standard JSON format.

If you want to be able to return data in a different format than SvelteKit expects for consumption by other types of users, then that sounds like a different endpoint. The endpoints that SvelteKit uses to retrieve data from +page.server.js files aren't a public API anyway, and are subject to change at any time. There's no reason to be stingy about endpoints and only provide data in some other serialized format and then expect to be able to tell SvelteKit how to read that format.

I take it page endpoints are considered "framework" and liable to change at any time / shouldn't be depended on as an external API (is it worth setting headers to prevent external requests so people don't accidentally do so?)
But what about when a page loads data from a server / standalone endpoint? I thought those were also direct (with no serialization) on the server?
That's where the custom reviver would be wanted, but not the non-standard JSON serialization that the page endpoints might use.

If a page loads data from +server.js, it does so with fetch, in which case it would be quite mad for SvelteKit to intercede — we can't mess with await request.json() etc.

I thought those were also direct (with no serialization) on the server?

There's no intermediate HTTP request — our fetch wrapper creates a Request object from your fetch call and passes it back to the SvelteKit server to handle directly — but beyond that, it's a standard Request-Response process. We don't have any privileged access to the response body (which could be expressed as a string or a Uint8Array or a ReadableStream etc), and nor should we.

Does #6008 address this? I'd be interested to hear if there are cases that devalue wouldn't cover (especially once we add BigInt support).

You will find users with special needs at all time. Someone might want to use a binary format to reduce bandwidth or some special coding to increase performance, maybe some freak wants zod to intercept and check all the values ... ;-) I still suggest to way to customize - with a well chosen global default...

our fetch wrapper creates a Request object from your fetch call and passes it back to the SvelteKit server to handle directly

That's where the server / client inconsistency may originate. Maybe it could be be JSON serialized so they are always the same?

You will find users with special needs at all time. Someone might want to use a binary format to reduce bandwidth

Sounds like a great reason to use fetch with a +server.js file

That's where the server / client inconsistency may originate

What inconsistency?

What inconsistency?

That you get JavaScript Date Objects during SSR but ISO 8601 format date strings after client navigation.

But you don't, because we check that values are serializable and throw an error otherwise.
Since we now use devalue to serialize data (#6008) and since we're not going to interfere with people's Response objects, I don't think there's anything to do here - closing


Reduce layout shift on the audio control elements

The audio control elements for reading the page aloud still have a slight amount of layout shift that we should remove.

When we fix this we should make sure it happens only when read aloud element is turned on. Writing this here just in case!

Just fyi, as I said in #311, I'm currently not sure how we can change this. This element can't be pre-loaded because this is javascript manipulation that happens after the page has already been loaded. Maybe adding a width and height on our custom element will work, but I'm doubtful.
For whoever comes at this next, another possible experiment to try/discuss is defining a hard-coded height on the element containing the audio controls. First try adding a class to the container that our css can use, then hard-code a height for it.
If that doesn't work, then this can't be done with normal css if we want to be able to turn it off sometimes, as described by @nonprofittechy. In css, you can't affect a parent element based on its children. We might be able to do it with scss, I'm not sure. If not, we have to do it by setting an inline style in the javascript. In that case avoid using !important or it will be very hard for anyone else to override that style.
Regardless, solutions to this are fragile - we'll have to remember to adjust the hard-coded dimensions separately if we change the height of other elements. If it's not in the css file with the other elements, it'll be even more fragile. Also, developers customizing their interview styling for their brand will have a tough time discovering how to fix it if problems arise. Anything done in the js file, like an inline style, and especially width and height, would be even harder for them to troubleshoot.

Another thought to consider is moving this content into an area of the screen where no layout shift would take place. Right now it's very prominent and it's probably not necessary for it to be. Thoughts:

Right
Top navbar
Footer element

This should probably be done with an upstream change.


JCK10 build can't find OpenJDK10-OpenJ9 SDK to download

daily_openjdk10_j9_jcktest_x86-64_linux build has failed due to the fact that it can't find the SDK to download from where it looks for it.
Same with daily_openjdk10_j9_jcktest_s390x_linux:
Error
00:02:29.163 [daily_openjdk10_j9_jcktest_x86-64_linux] Running shell script
00:02:29.458 + /home/j9build/workspace/daily_openjdk10_j9_jcktest_x86-64_linux/openjdk-tests/get.sh -s /home/j9build/workspace/daily_openjdk10_j9_jcktest_x86-64_linux -t /home/j9build/workspace/daily_openjdk10_j9_jcktest_x86-64_linux/openjdk-tests -p x64_linux -v openjdk10-openj9 -r upstream -c https://api.adoptopenjdk.net/openjdk10-openj9/nightly/x64_linux/latest/binary --openj9_repo https://github.com/eclipse/openj9.git
00:02:29.458 git clone  https://github.com/eclipse/openj9.git
00:03:51.524 binary
00:03:51.525
00:03:51.525 gzip: binary: not in gzip format
00:03:51.525 tar: This does not look like a tar archive
00:03:51.525 tar: Exiting with failure status due to previous errors
00:03:51.525 ls: cannot access */: No such file or directory
00:03:51.525 mv: missing destination file operand after ‘j2sdk-image’
00:03:51.525 Try 'mv --help' for more information.

Has anything changed in the way builds are published at api.adoptopenjdk.net/openjdk10-openj9/nightly/ ?
Note:
The API links for OpenJDK8-OpenJ9 and OpenJDK9-OpenJ9 are working, but OpenJDK10-Openj9 is not.
OpenJDK8-OpenJ9: https://api.adoptopenjdk.net/openjdk8-openj9/nightly/x64_linux/latest/ (works)
OpenJDK9-OpenJ9: https://api.adoptopenjdk.net/openjdk9-openj9/nightly/x64_linux/latest/ (works)
OpenJDK10-OpenJ9: https://api.adoptopenjdk.net/openjdk10-openj9/nightly/x64_linux/latest/ (doesn't work)

@gdams is leading the charge to replace those.

refer to https://github.com/AdoptOpenJDK/openjdk-tests/issues/380

also see #366

@Mesbah-Alam Where are the jobs you're referring to? They're not anything on the adoptopenjdk jenkins instances as far as I'm aware ...

I was referring to jck builds in the internal urv-jenkins (e.g. https://urv-jenkins.canlab.ibm.com:9095/view/JCK_Tests/) @sxa555

@Mesbah-Alam Please don't post non-external URLs here. Is this still a problem that needs to be addressed? I'm assuming it's been resolved one way or another since no-one's been shouting at me for it :-)

Yes, it has been resolved.


Unity SpeechSDK VisionOS compatibility

Is there a chance that the SpeechSDK will be compiled for Apple VisionOS?
Tried to enable the iOS library for VisionOS, but that did not work.

Hi, this has been asked before in https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/1990
We have a work item on the backlog but there is no plan for it at the moment.


Instance selector

Good morning.  Great work, the visual is perfect for me 👍.
I just have one problem, I have a myjdownloader account which runs 3 instances.  These are 3 instances with different names.
In the map configuration, instances selection displays 3 times the same.  I can't get the 3 names.
If I make 3 cards, I have the 3 names that are recognized.
Can you help me?  THANKS
I apologize for the English, I use a translator

Hi,
thanks for your report. As you said, there are a couple of bugs on instances selector.
I'm working on it
Pd. If you feel comfortable writing in Spanish, feel free to use it, is my native language

Fixed! Please, update to v1.3.0

Problem solved !  🥳
For Spanish, it would be worse, I'm French.
If ever, I will take this opportunity to add some feedback.  The map configuration window is rather unstable.  Nothing serious, you just have to remember to save the modifications one by one.  The instability may be caused by my installation, I don't know.
Another point, the 'latest release' link on the hacs page is dead.
Thank you again for your work and your responsiveness.  Best wishes

Thank you for your comments, it is greatly appreciated.
I don't know what you mean by map settings, can you provide more information or a screenshot? If so, do so by creating another ticket.
About the broken link, you mean the link to download the latest version with the manual method, without using hacs, right? I don't see any other broken links. If that's what you mean, thanks for noticing, I'm fixing it right now (#55), if not, please let me know what the link is.


Unable to pass CLI_ARGS to a stack using --tf-env-var-override or --env-var-override

Currently I'm unable to pass a different TF_CLI_ARGS=-var-file=mytfvars/dev.tfvars using local preview.
This appears to be because the string is using the = as the split of the passed argument where the CLI_ARGS can have this included so it's not a valid option to use.
Running command
spacectl stack local-preview --id <STACKID>  --env-var-override 'TF_CLI_ARGS=-var-file=mytfvars/dev.tfvars'

Outcome
2023/12/11 11:54:22 invalid environment variable "CLI_ARGS=-var-file=damint/dev.tfvars", must be in the form of KEY=VALUE

https://github.com/spacelift-io/spacectl/blob/44d279be302ca318ee0f141410186ca8419073e2/internal/cmd/stack/local_preview.go#L151

Should be fixed by: https://github.com/spacelift-io/spacectl/pull/208 and will be included in the next release.


fix Decorators page, parameter part code can't run

Fixes # Decorators page, Parameter Decorators
run invoke Reflect.defineMetadata(requiredMetadataKey, true, target, parameterIndex); and Reflect.getOwnMetadata(requiredMetadataKey, method, parameterIndex)

@xsilen can you sync with master?

updated

same to #174 , my pull request use map which is included in es6. #174 is more better.

:+1:

@xsilen, can you update with merge conflicts resolved.

closed


fix(focus): ensure elm can be focused/blurred

Coverage increased (+0.02%) to 97.414% when pulling 05670973d0d967a4633cc28de8cf73877fad0147 on fix/focus-blur into be73d986701579c804a0409d00039dce0fd71ad5 on master.


Difficult to debug Union types

Because the jsonReadsXXX implicit method waterfalls through the union type options using orElse, it essentially "matches" on the first successful parsing. Conversely, when it fails, it will show the failure of the last class in the waterfall - not the one called out by the classname in the json. This makes debugging difficult, since you will have no idea which json properties are missing (unless the class you care about is the last one in the waterfall).
MReed is thinking the fold method here (https://www.playframework.com/documentation/2.3.x/api/scala/index.html#play.api.libs.json.JsResult) could be a solution here.

Actually, an even better approach is probably to look for each key in turn, and commit to parsing the appropriate class if one of the known keys is present. If none of the known keys is there, then a validation error indicating this should be returned.
What I was thinking with the fold solution was to collect the errors as each alternative was tried, but I think the above is much more straightforward.

I agree with the above.

This issue has been raise here


Check openmpi

Unfortunately, I only get a generic error message:
======================================================================
[102](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:103)
ERROR: test_pool_serial (test_pool.TestPool)
[103](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:104)
----------------------------------------------------------------------
[104](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:105)
Traceback (most recent call last):
[105](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:106)
  File "/home/runner/work/pympipool/pympipool/tests/test_pool.py", line 20, in test_pool_serial
[106](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:107)
    with Pool(cores=1) as p:
[107](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:108)
  File "/home/runner/work/pympipool/pympipool/pympipool/__init__.py", line 52, in __enter__
[108](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:109)
    if self._receive():
[109](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:110)
  File "/home/runner/work/pympipool/pympipool/pympipool/__init__.py", line 96, in _receive
[110](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:111)
    output = cloudpickle.load(self._process.stdout)
[111](https://github.com/pyiron/pympipool/actions/runs/4273426859/jobs/7439332908#step:4:112)
EOFError: Ran out of input


adding pixi.js on the libs topic

Hi, I hope this lib help to build the list

Thanks @lucasmaiaesilva !


Wait for elasticsearch/opensearch to be ready before running the integration tests

Signed-off-by: Ashmita Bohara<EMAIL_ADDRESS>
Which problem is this PR solving?

Resolves https://github.com/jaegertracing/jaeger/issues/3411

Short description of the changes

We are waiting for elasticsearch/opensearch to be ready before running the integration tests
Bumping opensearch container version to 1.2.0.

Hi Yuri, sorry for the huge delay on my side.


feat: add comments abilities to require.context

Fixes #9184 by adding the special comments feature from import() to require.context()

[x] Tests

Failure is a random fail in all pipelines:
https://dev.azure.com/webpack/webpack/_pipeline/analytics/stageawareoutcome?definitionId=3

Would love if this could be backported to Webpack 4...

First somebody needs to review this PR for webpack 5 :sweat_smile:

What is use case?

@alexander-akait Described in #9184  To be able to specify chunk names (and all other comment features) when using require.context() in the same way you use the async import(), it's currently not possible to give a chunk name to files required with require.context

Why do not use import()? We are trying to reduce non JS abilities due incompatibility with ECMA modules

Well, you can't match by regex with import, so this for instance:
  const locales = require.context('@/locales', false, /[A-Za-z0-9-_,\s]+\.json$/i);
  const vuetify = require.context('vuetify/lib/locale', false, /[A-Za-z0-9-_,\s]+\.js$/i);

@alexander-akait , @Tofandel  are there any updates on it ?
There are quite a few use cases when you may need to dynamically load files by specific regex or with the dynamic value, like:
const importTheme = require.context(
    'codemirror/theme/',
    false,
    /\.css$/,
    'lazy',
);

// ... some-where later in you code
await importTheme(/* webpackChunkName: 'CodeEditor-theme' */ `./${theme}.css`);
// theme is ready;

please use import.meta.webpackContext https://github.com/webpack/webpack/pull/15446


Start using the ci-scripts submodule

Coverage decreased (-0.4%) to 90.744% when pulling df65e876eb42d4a14e046e290e238564f21f4cb9 on prateek/ci-scripts-refactor into 584be5b02266c47e7f510782f36f340b131e84c6 on master.

LGTM


Ci/support multiple platforms

Description
Please include a summary of the proposed changes.
Fixes #(issue)
Checklist

[ ] Tests covering the new functionality have been added
[ ] Code builds clean without any errors or warnings
[ ] Documentation has been updated
[ ] Changes have been added to the CHANGELOG.md
[ ] You added yourself to the CONTRIBUTORS.md

Pull Request Test Coverage Report for Build 501912422

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.848%

Totals

Change from base Build 501627689:
0.0%

Covered Lines:
74

Relevant Lines:
83

💛  - Coveralls

Pull Request Test Coverage Report for Build 501912422

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.848%

Totals

Change from base Build 501627689:
0.0%

Covered Lines:
74

Relevant Lines:
83

💛  - Coveralls


Curators can start a revision from the Collection page

Need
Is your feature request related to a problem? Please describe.
I'm always frustrated when I am looking at a Collection, identify an update to make in the Title, Description, Links or Contacts (non-dataset information). To make the update, I need to copy the title, go to My Collections, then search for the title, then Start Revision.
Approach
Describe the solution you'd like
I would like to be able to click a button on the Collection page to Start Revision. I could be redirected to the new Revision page, or a new tab could open to the Revision page - either would be OK.
Design
Start revision from Collection Detail page
Public collection, pending revision banner
Private revision, public collection banner

@metakuni @NoopDog - I'm assuming that this epic is complete, but the on-call failed to close its Ready for Prod issues?


Support halo2curves

May I ask your guys if sppark plans to support halo2curves (github)[https://github.com/privacy-scaling-explorations/halo2curves]

One has to keep in mind that this project is very much focused on providing a foundation for applications we build (or help building) rather than on general why-not-this-n-that coverage. With this in mind. As far as MSM goes, Pasta curves are supported through pasta-msm, grumpkin can be put together by swapping fr_t and fp_t from alt_bn128 when instantiating MSM. As for NTT, there are parameters for Pasta curves, and NTT is not applicable to grumpkin. As for secp256* curves. While it's possible to instantiate secp256k1, there would be room for performance improvement left, both on GPU and CPU sides, hence no. As for secp256r1, it won't work as is, because for the moment of this writing sppark supports only y^2=x^3+b curves. Maybe some day...

Thank you very much for your answer. I understand your point very well, and thank you for your contribution to sparkpark, which is very beneficial to me and my team.
My recent work is trying to implement the interface of the bn256 curve in sppark (maybe that is, the bn254 curve on ark) to the halo2 algorithm to achieve GPU acceleration of the halo2 algorithm. Regarding this work, I would like to ask if there are any risks in this work in sppark? Or is there something wrong with my statement?
By the way, I noticed that you mentioned "sppark supports only y^2=x^3+b curves." above, but in the actual sppark code, bn254 curves are supported. I am a little confused about this.
Looking forward to your answer very much. Thanks again :)👍

I don't quite follow which "risks" you're referring to. bn254 (a.k.a. alt_bn128) was verified to work in production, if this is what you're wondering about... Just in case, "bn254" is an ambiguous term, because it can refer to a different curve. Additional reference to alt_bn128 removes the ambiguity.
As for the y^2=x^3+b formula. All mentioned curves except for secp256r1 are described by it. secp256r1 on the other hand is described by y^2=x^3+ax+b, it's that extra ax term that is not currently supported by sppark. And I brought it up, because the curve was mentioned on the url you've provided.


Add support for action_args and action_kwargs

This PR allows users to pass optional args and kwargs to their action function. It combines args that may have been received from privileged_action() and updates the documentation to clarify that.
Also makes a few very minor improvements.

Hi, Mike!
Why is this approach better than using functools.partial?

Completely spaced out on functools.partial before writing this. Don't think there'd be any clear advantage to using what I have here compared to partial, closing out.


Consider creating a TUI

It would be really nice to have a TUI, using Ratatui.
For reference, see the calendar widget: https://docs.rs/ratatui/latest/ratatui/widgets/calendar/index.html
And calendar demo: https://github.com/ratatui/ratatui/pull/1571

The only usecase imaginable for the calendar widget?


application export should have -k like script export and journey export

Is your feature request related to a problem? Please describe.
frodo application export does not have -k (--insecure) so it won't work behind our corporate SSL Interceptor.
Describe the solution you'd like
Add -k option like "script export" and "journey export" have
Describe alternatives you've considered
No other alternatives
Additional context
No additional context

Duplicate of #280 and was fixed in 0.7.0 back in July.
Can you please check which version of Frodo you are running and possibly update to the latest version?

frodo -v shows 0.6.1 [v16.14.2]
How do I get up to v7?
On Mon, Aug 8, 2022, 07:15 Volker Scheuber @.***> wrote:

Duplicate of #280 https://github.com/rockcarver/frodo/issues/280 and
was fixed in 0.7.0 back in July.
Can you please check which version of Frodo you are running and possibly
update to the latest version?
—
Reply to this email directly, view it on GitHub
https://github.com/rockcarver/frodo/issues/361#issuecomment-1208114832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBIWJLFB54QID2MIBPG73VYEB6BANCNFSM55WL4TFA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Easiest is to just go to the Release Page and download the latest version.


Add better error handling when no repo is entered

Reproduce: Press Launch without entering a repo. There is no error indication to the user that a repo hasn't been entered.

This should be a simple HTML / JS change. Anyone else up for making it? :)
On Wed, Jul 19, 2017 at 1:59 PM, Chris Holdgraf<EMAIL_ADDRESS>wrote:

could we make launch un-clickable and greyed out until there's text in the
user/repo box? Then change the text from
Github repository name or link
to
Enter a Github repository name or link to get started
so that it's a bit more suggestive of action?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/77#issuecomment-316515539,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23g9MUhkWXutIQbE3YupWfQsnrRrAks5sPm4kgaJpZM4OdNqh
.

--
Yuvi Panda T
http://yuvi.in/blog

I'm happy to give it a stab but wanna make sure folks are OK with my proposed change :-)

jdi, we can discuss more specifics / bikeshed on the PR :) It's clear
current lack-of-implementation is a problem :)
On Wed, Jul 19, 2017 at 2:09 PM, Chris Holdgraf<EMAIL_ADDRESS>wrote:

I'm happy to give it a stab but wanna make sure folks are OK with my
proposed change :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/77#issuecomment-316518213,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23gBnOK7FhSj2P-DcCXi2jmgbag7wks5sPnCSgaJpZM4OdNqh
.

--
Yuvi Panda T
http://yuvi.in/blog

Even a check after launch that pops up an error would be fine. Go for it @choldgraf.

+1 go for it!
On Wed, Jul 19, 2017 at 2:45 PM, Carol Willing<EMAIL_ADDRESS>wrote:

Even a check after launch that pops up an error would be fine. Go for it
@choldgraf https://github.com/choldgraf.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/77#issuecomment-316527448,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23npasH4JrGyCad8o1MxmMp26cFVLks5sPnkKgaJpZM4OdNqh
.

--
Yuvi Panda T
http://yuvi.in/blog

I'm trying to look into this now but could use a bit of context for what the code is doing. (as a pre-warning, I have very little javascript experience so apologies if I sound like a dummy here).
It looks like this section is defining how the progress bar shows up etc:
https://github.com/jupyterhub/binderhub/blob/master/binderhub/static/index.js#L124
And it's receiving information about the stages of building from...somewhere. Where's that information coming from? I assume that's where we'd essentially need to add code that defines a new state transition from "looking up" to "failed".

Looks like this is where it fetches the repo information:
https://github.com/jupyterhub/binderhub/blob/master/binderhub/static/index.js#L31
and it's using this under the hood:
https://github.com/jupyterhub/binderhub/blob/master/binderhub/builder.py#L20
So that's where we should look look for an error?

@choldgraf You are on the right track. This is where the state is being looked up https://github.com/jupyterhub/binderhub/blob/master/binderhub/builder.py#L153
Probably easiest to check when the launch button is pressed that there is a repo name (valid inputs).

Ahh yep - that makes sense. I need to spend some time on other to-do items since this (as well as trying to get minikube running on my computer) has already sucked away a lot of my sunday :-) but I'll get back to it soon

binder now throws an error when a repository hasn't been correctly specified. That's different from explicitly checking for empty fields / throwing that error, but perhaps this is enough. Will close this in a bit unless someone prefers to keep it open.

Agreed.


Allow users to customize the patterns to check for

Users should be able to specify patterns_to_include or patterns_to_exclude.

thanks this will be great feature indeed.


Consider pulling full credscan out of service directory pipelines

Since credscan requires a full clone, it can take a long time. I'm not sure if there is any compelling reason to run credscan for each service pipeline, rather than having one repository global pipeline that runs on commit batches to main (e.g. run on each merge, and group together multiple merges that happen before the next run) or on every commit to main.
For PRs, we would still need credscan runs, but it could be done against the directories of changed files with a sparse checkout, which would be faster.
One potential downside would be replacing credscan checks that run for feature branch merges.

Nvm. Closing because I realized we still need PR checks.

CC @scbedd

Since this was opened, we've since optimized credscan in PR validation to only scan edited files.  The nightly runs still scan the full service folder, but that doesn't add much time to the nightly runs anyway.


replacing and disabling modules with new api

In the docs there is a:

You can also pull modules from other channels. All modules have access to the modulesPath for each channel as ModulesPath. And you can use disabledModules to remove modules from the current channel.
Pulling the zsh module from the latest channel:
{ latestModulesPath }: {
  modules = [ "${latestModulesPath}/programs/zsh/zsh.nix" ];
  disabledModules = [ "programs/zsh/zsh.nix" ];
}

but it's unclear where it is supposed to be put/used
I'm filing it as a bug, since it's an issue with docs, but i would appreciate the advice, and willing to fix the docs

my personal issue is that i want to add a module from a specific channel to a specific host(exclusively that host)

turns out it's a regular nix code
{ latestModulesPath }: {
  import = [ "${latestModulesPath}/programs/zsh/zsh.nix" ];
  disabledModules = [ "programs/zsh/zsh.nix" ];
}

this kind of code works, not sure if it's the right way, and if the docs should be updated to make it more clear for newcomers

Agreed thanks for opening this. The first issue is the docs should use imports, I messed that up. And the next issue is that the docs need to be more explicit that module overriding can happen in any module, whether its your host file, a profile, or a module in ./modules.


Unable to resize disk

I'm trying to resize the CRC disk via guestfish, however I'm getting the error libguestfs: error: luks_open:
This is running on CentOS Linux release 8.1.1911 (Core).
Do you have any suggestions?

You are hitting https://bugzilla.redhat.com/show_bug.cgi?id=1791353
Since you filed this against snc, you can see how this was worked around https://github.com/code-ready/snc/commit/a25fc4bd7cd904e4903df4041c84c89cf3c18d12

@cfergeau Thanks, but we are using that workaround and still hitting the error

Please provide the full log of what you are doing.


Replace frame template Frame<T> with concrete types

Main goal of this PR is to replace the frame template Frame<T> with distinct, concrete types. This is undertaken because Frame<T> and the associated traits make it difficult to get good data locality, and error handling can be somewhat verbose (for little benefit).
Related Issues

#9
#6
#12

Unfortunately, these are much more "blanket" issues, existing well beyond just the frame types. So while this attempts to solve this in a limited fashion for frame types, more work is needed to complete these issues.
Error handling
Let's start with error handling. Most everything in the existing API returns a Result<T>, where Result is a type alias for std::result::Result<T, crate::Error>. The error type that is contained within this crate is unitary, i.e. we use the same type for every possible error. In addition, it tries to distinguish errors by string matching against the error message generated by the lower level librealsense2 code. Aesthetically, checking result types everywhere is a huge pain, especially if we look at the actual code in librealsense2. Most of the possible error states are simply due to a null check on the input pointers!
Tangent to error types, but somewhat related: it is not ideal in most cases to return a Result<f32> or some equivalent. An example is the distance function in the existing DepthFrameEx trait. With this as the only accessor to the underlying depth data, users will be encouraged to loop through every row / column and grab a Result<f32>. However, this means that for every pixel, we're returning a new, owned f32, which means if one is to iterate through every pixel you're doing a full copy of the frame. This is expensive and somewhat bad for caching reasons, so we should guide users to avoid it where possible. This is more or less a consequence of the rs2_depth_frame_get_distance API, but is exacerbated by the lack of a general API to get the underlying raw data (so that users can choose when to do this for themselves).
Similarly, in order to get the underlying data, this crate by default converts the raw buffers into image types from the image crate. This isn't inherently a problem, but users who do not include that crate by default have no means to access the underlying buffer.
Goals
Here's roughly what we aim to do with this branch (updating as I go):
New frame types

[x] Create distinct, concrete implementations for CompositeFrame, DepthFrame, VideoFrame, and PoseFrame
[x] For depth and video frames, ensure that appropriate lifetimes are enabled so that a reference to the underlying data (e.g. &'a [u8]) can be held.
[x] Provide accessors to the underlying data (by reference) that incorporates the relevant pixel formats.
[x] Provide iterators for the underlying data where necessary.
[x] Represent underlying data in terms of standard Rust types (no external crates).
[ ] Cache frame metadata where possible, to remove frequent error checking

Integrating this into pipeline, context, etc

[ ] Switch pipeline over to returning new composite frame type
[ ] Ensure API correspondence between existing traits and new concrete types
[ ] Document new types
[ ] Add tests for new types

Moving most of this work to gitlab where this will be mirrored


Drop Pug, serve static HTML file.

Pug is not that fast, and has tons of dependencies. While we almost do not use Pug, it seems to be easy to replace it with statically built HTML file.

As I suggested in #7, using pure HTML5 is possible with inlining CSS and JS in result HTML. Then we do not need to worry about relpath problem and the result will be much simpler(we do not need build.js and build.css). It must be possible with webpack, mustn't it?

I'm planning to use html-webpack-inline-source-plugin. It'll bring a big change to this project, so I'll do some basic code organization before I start the change.
Previous discussions

https://github.com/noraesae/pen/issues/7
https://github.com/noraesae/pen/issues/6#issuecomment-270959433

TODOs

[x] Misc code cleanup
[x] Replace React.createClass with React.Component
[ ] Question: Using babel to unit testing
[ ] Introduce html-webpack-plugin and html-webpack-inline-source-plugin
[ ] Drop Pug
[ ] Static file serving

WIP in simnalamburt/pen

It's somewhat hard to use brand new feature of ECMAScript in current structure since current test codes does not run under babel. It's because Mocha was invented before the babel and JSX era.
Have you ever tried Facebook Jest? Looks like it's much more babel-friendly. It also have built-in coverage reporter unlike mocha. (Yes it is possible to check coverage with mocha but it's not that comfortable).
Do do not have tried Jest yet but I think maybe this is good change to try the new technology. Since I think now I have good understanding of how this package work, I'm confident in replacing mocha with Jest. Also it'll be a good experiment before using Jest in production. How do you think?

I do not think the brand new ES features are specifically necessary for this small project, especially for testing. What kind of ES features would you like to use? If it's not really essential, I may just stick to the current state.
Also, IMHO the reason Mocha does not support Babel has something to do with decision, not era. Mocha decides to remain simple, and I also would like to do the same.
About test frameworks, I have personally never tried Jest, but heard that it is for React testing. Surely Jest says that it's for general testing, but many people found it difficult and sometimes disappointing to use Jest for usual Node.js behaviour testing. If you just want built-in Babel support for testing, AVA will be a better option.

I come up with another simple solution to use new ES features with Mocha. Install babel-register and add --require babel-register to the Mocha command. I may prefer this solution if new ES features are really needed.

OK that sounds good enough

I also just checked https://github.com/simnalamburt/pen/commit/4932f5f4ad6514ac3199993ac5ce15515abca50b. I am afraid that I am not really a big fan of JSX, and would like to avoid using it if possible. Could you please revert JSX part?
Other changes look wonderful. Great works!

@noraesae I separated JSX changes from the PR and made #11 without it. But may I ask why you want to avoid using JSX?
See https://github.com/simnalamburt/pen/commit/d7e5ecbcb413daca5948674f08837f7902098c9d for the separated JSX changes.

It's personal preference, but there are still some reasons.
The following content are rather subjective, so please ignore it if anyone disagree.
I do not think implementing JSX was a right decision. It has worked, kind of, but I think it has also added tons of problems in JS ecosystem. First, it surely adds its own JSX compiler. Second, it adds compiler plugins for literally every bundler (or other compiler like Babel). Third, it adds parser plugins for literally every linter and tools. Fourth, it adds plugins for literally every editor. Furthermore, it even forced TypeScript to implement TSX, which was really hard because <...> syntax had already been used in TS. In short, it adds something in literally every layer of JS ecosystem.
Some people argue it makes rendering code easy to read. But really? I personally do not understand why React does not just use function syntax.
// for example...
div({ className: 'hello' },
  h1_('i am header 1'),
  h2_('i am header 2')
)

Looking exactly same as HTML is great, but I doubt it is really worth the effort and time of tons of people.
Subjective content finishes...
About Pen's usage, it does not really include complex rendering logic. It does not even have nested component. To render a single element, there is no problem with React.createElement. Adding a dependency is actually a management cost, and I would like to avoid adding one when possible.
I would like to make it clear that I am not arguing that everybody should think the same. It is my personal stand for the time being, and also, thus, of Pen.
I am really sorry again that I cannot accept every request of you, despite your great work and effort.

I am thinking of trying implementing the last parts today. Is there any implementation you are working on?

No recently I've become busy and looks like I won't able to do this for a while. Go ahead.

There's a small issue with Node 4.x support but looks like it's not major problem. This issue was just closed by 397a1a4045cee6deba6aed39f2d7aff8ec43f31b

Thanks. I really appreciate your great works.


Fixes #599 - inlined source maps.

Enables ingestion of inline, data-uri source maps.

Sorry for the delayed response.  Thanks for putting this together.
I added some more tests for different forms of data URIs: with and without base64, with and without a charset specified, charset utf-8 and charset us-ascii, and without a content-type at all.  The current code fails in some of those situations.
They're in cspotcode/clean-css#inline-source-maps
https://github.com/cspotcode/clean-css/commit/dc7df0ac406f1b29360501882f7af58a2bbd70d6

@cspotcode Thanks for additional test cases, much appreciated! I've updated the code so all tests pass now.

I'm gonna merge it now. Thanks @cspotcode!


stream example

Hi, I was wondering if someone could help me with a simple stream example? I've tried the following, which appears to be as simple as it gets, but my output file doesn't contain any data:
    const stringifier = Stringify();
    Knex.select('*').from('business')
        .stream()
        .pipe(stringifier)
        .pipe(Fs.createWriteStream('out.csv'));

stringifier uses the node-csv-stringify package.
I'm sure I'm probably missing something here, but can't seem to get this to work.
I'm using Knex 0.13, Node 7.8.0 and Postgres 9.5
Thanks!

Having the similar issue.
knex
  .select('*')
  .from('data')
  .stream((stream) => stream.pipe(strinigifier).pipe(file))

I get no output and my program hangs indefinitely.
knex
  .select('*')
  .from('data')
  .stream((stream) => stream.pipe(strinigifier).pipe(file))
  .then(() => { console.log('done!'); });

This works, but the "done!" message is output BEFORE all the data in the stream has been pushed down the pipe (this only happens where there are a lot of rows). As my next step is to proceed to another table, I get data written out in the wrong order.
If it matters: using the 'pg' client and KnexJS 0.12.9.

For anyone wandering around here, the package is now part of the 'pg' module, installing "pg-query-stream": "^3.0.4", made the stream work for me.

@mlarcher what about mysql?

there

For anyone wandering around here, the package is now part of the 'pg' module, installing "pg-query-stream": "^3.0.4", made the stream work for me.

This is what made it work for me! Thanks

Is it support MICROSOFT SQL SERVER?


Release 2.1.2

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   88.85%   88.85%
=======================================
  Files          22       22
  Lines         700      700
  Branches       98       98
=======================================
  Hits          622      622
  Misses         48       48
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c01594...3235f94. Read the comment docs.

Should it be 2.2.0?
So that >2.2 is compatible with NodeJS instead of >2.1.2? :P

🤷♂  Sure ;)


Tests fail consisnently when using golang-migrate/migate

We have some other PRs up for review that attempt to add integration tests for the database. One of the tools these tests use is golang-migrate/migrate.
The go-specific CI runs are failing with errors similar to:
 Status: Downloaded newer image for postgres:latest
bb8e9bb204c8722103e672ff7f8523392f3437f8dc40c07c2dff1de73a140d08
go: downloading github.com/golang-migrate/migrate/v4 v4.15.2
go: downloading github.com/golang-migrate/migrate v3.5.4+incompatible
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading go.uber.org/atomic v1.7.0
go: downloading github.com/hashicorp/errwrap v1.1.0
# github.com/rhmdnd/compserv/tests/integration
FAIL	github.com/rhmdnd/compserv/tests/integration [setup failed]
Error: tests/integration/integration_test.go:8:2: cannot find package "." in:
	/home/runner/work/compserv/compserv/vendor/github.com/golang-migrate/migrate/v4

It seems clear the issue stems from a dependency problem with migrate.

I introduced this issue when I added the first database migration.
https://github.com/rhmdnd/compserv/commit/3b2d322b536975cbbfea7de3b966b87fd36242d8
This is because I was using the migrate CLI tool, before we decided to put that in the tools/ directory. As a result, non of the vendor changes for migrate were getting pulled into source control.
We should remove that line in the .gitignore file since it's no long necessary and we need to use migrate.


Console: prefixes in query should override built-ins

The sparql command in the console can run a query from a file (INFILE=".."), but the PREFIX used in the file may clash with the built-ins / prefixes set in the console itself.
Error is:
Malformed query: Multiple prefix declarations for prefix
Console should not add built-in prefixes when running a query from a file (or at least not fail when the prefixes are referring to the exact same namespace...)
The same goes for a query entered by the user: in that case it is more likely that the user does not set any namespace prefixes in the query at all (which saves time and frustration), but when the user does, it should take precedence over the built-in/overall console namespace settings.

Actually it is a bug in the Sparql console command, where the uppercase query string is checked for lowercase prefix ...

Quick fix: namespaces from the console will not be added if the file or query already contains any prefix.
This assumes that a user has

to add a namespace prefix using the console setting, so it will indirectly become available to all queries launched in the console
specify all the namespaces in the query (multi-line input or file) itself

IMHO this follows the principle of least surprise, otherwise copying queries/sharing queries containing prefixes with other users (or re-using queries when the console settings are changed) may lead to surprising malfunctions, due to some prefixes explicitly set in a query and some implicitly set in the console.


Too many matches for given filters

Any reason why this is a thing?
Kinda wanted to take a look at every review and then manually filter by courses I am familiar with :P
https://github.com/OSDG-IIITH/Review-IIIT/blob/794da2bebfebb3bc3ec1237c2177f5649d68404e/frontend/src/pages/Courses.jsx#L173

The only reason its a thing is because trying to view too many courses at once would spam the backend with fetch requests and there are concerns of the backend being unable to handle the increased load due to it, especially with multiple users trying it at around the same time.
It is just a band-aid solution, more-long term solutions I can think of are:

pagination of the reviews to limit the reviews per page, and therefore limit the number of simultaneous backend fetches
collapsible review boxes (that are collapsed by default) that require user interaction to fetch reviews.

2nd seems fine, users fetch the metadata when filtering and then open up the relevant reviews individually. maybe cache reviews + metadata, personally love react query, almost always a drop in replacement.

The collapsible reviews feature has been implemented, and the too many matches restriction has been lifted. I believe this issue is now resolved, so I am closing this issue.
Feel free to re-open if you have anything to add.


[BUG] CreateDocument exception

Describe the bug
SampleProgram throws an exception on latest affinda-dotnet version (updated to use CreateDocument instead of CreateResume). File is successfully uploaded to Affinda despite the exception, though this prevents us from getting data back from the parse.
To Reproduce
Steps to reproduce the behavior:

Update Affinda to latest version (5.1.0)
In SampleProgram/Program.cs:

Set credential and documentPath variables
Change CreateResume to CreateDocument

Run sample program

Expected behavior
CreateDocument should successfully upload the file to Affinda AND return an instance of Affinda.API.Models.Document
Stacktrace / Screenshts
Unhandled exception. System.InvalidOperationException: The requested operation requires an element of type 'Object', but the target element has type 'String'.
   at System.Text.Json.JsonElement.EnumerateObject()
   at Affinda.API.Models.ComponentsEyyf0ZSchemasResumedataAdditionalproperties.DeserializeComponentsEyyf0ZSchemasResumedataAdditionalproperties(JsonElement element) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\Models\ComponentsEyyf0ZSchemasResumedataAdditionalproperties.Serialization.cs:line 23
   at Affinda.API.Models.ResumeData.DeserializeResumeData(JsonElement element) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\Models\ResumeData.Serialization.cs:line 509
   at Affinda.API.Models.Resume.DeserializeResume(JsonElement element) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\Models\Resume.Serialization.cs:line 57
   at Affinda.API.Models.Document.DeserializeDocument(JsonElement element) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\Models\Document.Serialization.cs:line 38
   at Affinda.API.AffindaAPIRestClient.CreateDocument(Stream file, String url, String collection, String workspace, String wait, String identifier, String fileName, String expiryTime, String language, String rejectDuplicates, CancellationToken cancellationToken) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\AffindaAPIRestClient.cs:line 1334
   at Affinda.API.AffindaAPIClient.CreateDocument(Stream file, String url, String collection, String workspace, String wait, String identifier, String fileName, String expiryTime, String language, String rejectDuplicates, CancellationToken cancellationToken) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\AffindaAPI\AffindaAPI\AffindaAPIClient.cs:line 714
   at AffindaAPISample.Program.Main(String[] args) in F:\Home\Projects\Resume-Raise\test\affinda-dotnet-master\SampleProgram\Program.cs:line 17

Environment

Client version: 5.1.0
.NET version 5.0.0

Additional context
Looking to implement this as a critical part of our application, and had issues with both affinda-dotnet 4.x.x versions and 5.x.x versions. The original CreateResume method and new CreateDocument method both did not work from our testing. Seems that this has been an issue for a while.

@cfculhane

Thanks @andrewyunt - looking into now

Yes this is fixed, thank you!


WebSocket Sampler doesn't pass cookies from HTTP Cookie Manager

Already using HTTP Request sampler and HTTP Cookie Manager together.  Works well. JSESSIONID cookie is sent for all HTTP Requests.
After some debugging, it seems like the server side websocket is returning a 401 when WebSocket Sampler tries to connect to it.  Thus It doesn't appear WebSocket Sampler uses the JSESSIONID from the HTTP Cookie Manager.  Are there plans to support that?  Is there a workaround?
Note that I've successfully used WebSocket Sampler to drive load before we enabled authentication. It's only since I need to pass the cookie that it is failing.

I see that issue #28 covers this.  (I searched the repository for cookies earlier, but got no results for some reason.)  Apologizes.
Curious, though:  since a websocket begins with an HTTP GET and is then upgraded, it would make sense to support HTTP Cookie Manager by default. Thoughts?

Actually, still no luck. First a quick background:
So part of my jMeter script uses Cookie Manager and several HTTP Samplers to drive load to our REST apis.  This works well.  If I disable Cookie Manager, they fail, as expected. So good so far.
I also need to drive websocket load. As suggested in issue #28, I git cloned the code, then added code to add cookies from the cookie manager. As I loop over the cookies and print the name, I correctly see JSESSIONID and others. I also tried adding the headers using the same sample code in issue #28.
It still wasn't working, so I added an OnError handler to the code to simply print the status code:
@OnWebSocketError
public void methodName(Session session, Throwable error) {
UpgradeException ue = (UpgradeException) error;
System.out.println("uri was " +  ue.getRequestURI());
System.out.println("status code was " + ue.getResponseStatusCode());
}
The status code is 401, thus the server thinks I'm unauthenticated.  (Remember, the other HTTP Samplers work just fine)
Using Chrome Developer tools, I've inspected all headers and cookies that get passed when the web browser communicates with the socket, and I've tried to pass the same ones with code in issue #28.
Nearly at my wits end. It's as if the web socket sampler doesn't have the same context as the HTTP samplers.
Can you think of anything I've missed, or do you have other suggestions for debugging?
Websocket Sampler is quite nice and I'd really like to get this last part working.
OSX with
java version "1.8.0_51"
Java(TM) SE Runtime Environment (build 1.8.0_51-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.51-b03, mixed mode)

I missed it earlier, but happened to stumble across @tradingscreen 's solution here  https://github.com/tradingscreen/JMeter-WebSocketSampler , which was almost identical to the code I had tried, but I had missed one part.  :-) So it's working.
I noticed that @tradingscreen submitted a pull request #22 to add this to websocketsampler back in April. I hope we can get it in there, as it's needed for any websocket that needs cookies.
Again, thanks for this cool and useful extension to jMeter and thanks to @tradingscreen for implementing the cookie support.

@SamAlexand
I am working on Signalr, This is my project requirement hence downloaded websocket version websocket-9.1.1.v20140108, I dont have a good knowledge on JAVA. I am using maciejzaleski websocket sampler in JMeter First time. After a lot of r&d I success to communicate with Signalr via your Websocket sampler. Now my project build got upgraded & they are passing a Cookie Data:
.ASPXAUTH=0AE3BF3FE55AAADC5FFEAFE1120F1E45B84AC2C7D227BC8F8E1585E74D14852798F5D27B688D4AFC2C1E494263077178ECBAFC126F4D7D258A21F258779B4B9749BE9D819C51FCBE7D116691F2020FC8EABE622396AA80201872F5C671009EBB in each (Http & WS) request. Via Jmeter cookie manager in each http request cookie handled correctly & requests were passing but my Websocket requests were failing because its not passing the Cookie data.
I have gone through all above comments. As I told I can rate myself 1 outof 10 in JVAV.
Could you please let me know or send me the required websocket JAR file which handles cookies<EMAIL_ADDRESS>Or any guide line also help me...Please
Thanks In Advance.


feat(eslint-config): add import extensions linting rule

BREAKING CHANGE: imports other than bare module specifiers now require their extensions to be explicitly set in the import, eg: import foo from './bar.js';

I would suggest the following commit message
BREAKING CHANGE: imports now require a file extension
Every import that is not a "pure" bare import requires a file extension
\```js
// before
import '../my-el';
import '@open-wc/testing/index-no-side-effects';
import '@open-wc/testing';
// after
import '../my-el.js';
import<EMAIL_ADDRESS>import '@open-wc/testing';
\```

also in a separate commit you will probably need to fix all those imports now 🙈

uh can we also update the readme for it 🙏

imho if we do a breaking change the we should also update to the latest Airbnb and see if we want to "break" more stuff as well...
potentially every change is breaking here 😭

Is this good to go?

@daKmoR was thinking about any other breaking changes we may want to do while we're at it, he said he recalled wanting to change something else, but couldnt remember what :p
So if we don't have any other breaking changes we want to do, this should be good to go.


Would be nice if Compiled also included the compilation cache key

Would allow for associating an AOT compiled binary with its cache artifact.

cc @froystig @skye

Closing in favor of #9250, which we believe would subsume this.


Add Brazilian Portuguese translation

About pull request

This pull request adds Brazilian Portuguese translation as an option to the theme.

What's changed to accomplish [problem / feature] described in issue
This pull request doesn't change any previews code, except adding pt (portuguese) as an option to the main.conf file.
All the translation is nested in pt folder.
I have not translated the William Shakespeare quotes and other examples because those will end up being replaced by other users when using this theme, so I left those in place.
I also translated the README file and named it _README-pt.md (as the same as the Japanese one) and this can be added to the main project page by the main author of the theme. Because this is the author's choice, I have not added a link to the brazilian portuguese README.md file since those are linked directly to the author's of this theme github page.
Please, considere this as a gratitude for your work since I'm using your jekyll theme on my personal blog since yesterday (https://fandangos.github.io) but with only English and Portuguese language options as I don't  speak Japanese.

I can't tell you how I feel right now. I'm so happy. Please give me a little bit time to review.

I forgot to translate 2 titles in the README, I'm sorry for that.
I've added a new commit and now it should be fully translated.

Thanks to you, when I was checking the PR, I found a bug,  #120 will fix your website month translation.
There are small things needs to change. Still checking.

I make some changes, Could you please take a look to this commit d85467ea

I made some small changes to improve the translation.
In portuguese, you can use some words in English and those will be left in the phrase like the original.
If you translate Theme to Tema, it would be spoken before the title of the theme: Tema Mr. Green.
That's why I changed it.
Everything looks really good and I really appreciate the credits.
I'll write about this colaboration on my blog that is powered by Mr Green :))

Everything is look good. Forgive me for my poor translations. I will update demo page too. I appreciate your time. Thank you.