Add CentOS7-compatible target for aarch64

Add Dockerfile.aarch64-unknown-linux-gnu.centos for centos7, using glibc-2.17

bors try --target aarch64-unknown-linux-gnu.centos

bors try --target aarch64-unknown-linux-gnu.centos

bors try --target aarch64-unknown-linux-gnu.centos

try
Build failed:
* [conclusion](https://github.com/cross-rs/cross/runs/8140730277?check_suite_focus=true)

Seems like all that's left is to specify the QEMU_LD_PREFIX to the location of the aarch64 lib directory.

seems like gcc etc is missing? https://github.com/cross-rs/cross/runs/8140508679?check_suite_focus=true
You can run the tests yourself with
# env variables
CROSS_TARGET_AARCH64_UNKNOWN_LINUX_GNU_IMAGE=ghcr.io/cross-rs/aarch64-unknown-linux-gnu:trying-centos
TARGET=aarch64-unknown-linux-gnu
CPP=1
DYLIB=1
STD=1
RUN= 1
RUNNERS="qemu-user qemu-system"

./ci/test.sh

Interestingly, it seems this is failing even with the correct LD prefix. A quick check shows the binary is the correct format and linked to the right libraries:
$ file target/tmp/target/aarch64-unknown-linux-gnu/debug/hello
target/tmp/target/aarch64-unknown-linux-gnu/debug/hello: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, BuildID[sha1]=7d1ccfd17eb7f619e6d62ba5a0769b0900319f6a, with debug_info, not stripped
$ objdump -x target/tmp/target/aarch64-unknown-linux-gnu/debug/hello | grep NEEDED
  NEEDED               libgcc_s.so.1
  NEEDED               libpthread.so.0
  NEEDED               libdl.so.2
  NEEDED               libc.so.6

Checking inside the container, we get:
$ echo $QEMU_LD_PREFIX
/usr/aarch64-linux-gnu/
$ ls $QEMU_LD_PREFIX/lib
Mcrt1.o     ld-linux-aarch64.so.1    libanl.so.1       libcidn-2.17.so   libdl.so                      libm.so                libnss_compat.so      libnss_files.so         libnss_nisplus.so       libresolv.a          libthread_db.so
Scrt1.o     libBrokenLocale-2.17.so  libbsd-compat.a   libcidn.so        libdl.so.2                    libm.so.6              libnss_compat.so.2    libnss_files.so.2       libnss_nisplus.so.2     libresolv.so         libthread_db.so.1
audit       libBrokenLocale.a        libbsd.a          libcidn.so.1      libg.a                        libmcheck.a            libnss_db-2.17.so     libnss_hesiod-2.17.so   libpcprofile.so         libresolv.so.2       libutil-2.17.so
crt1.o      libBrokenLocale.so       libc-2.17.so      libcrypt-2.17.so  libgcc_s-4.8.5-20150702.so.1  libmemusage.so         libnss_db.so          libnss_hesiod.so        libpthread-2.17.so      librpcsvc.a          libutil.a
crti.o      libBrokenLocale.so.1     libc.a            libcrypt.a        libgcc_s.so                   libnsl-2.17.so         libnss_db.so.2        libnss_hesiod.so.2      libpthread.a            librt-2.17.so        libutil.so
crtn.o      libSegFault.so           libc.so           libcrypt.so       libgcc_s.so.1                 libnsl.a               libnss_dns-2.17.so    libnss_nis-2.17.so      libpthread.so           librt.a              libutil.so.1
gconv       libanl-2.17.so           libc.so.6         libcrypt.so.1     libieee.a                     libnsl.so              libnss_dns.so         libnss_nis.so           libpthread.so.0         librt.so
gcrt1.o     libanl.a                 libc_nonshared.a  libdl-2.17.so     libm-2.17.so                  libnsl.so.1            libnss_dns.so.2       libnss_nis.so.2         libpthread_nonshared.a  librt.so.1
ld-2.17.so  libanl.so                libc_stubs.a      libdl.a           libm.a                        libnss_compat-2.17.so  libnss_files-2.17.so  libnss_nisplus-2.17.so  libresolv-2.17.so       libthread_db-1.0.so
$ file $QEMU_LD_PREFIX/lib/libgcc_s-4.8.5-20150702.so.1
/usr/aarch64-linux-gnu/lib/libgcc_s-4.8.5-20150702.so.1: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=bac73cd7e6e5506903a605911dc0dc935c94bbc0, stripped

So I'll try to debug what's failing. This is failing with qemu-user, so it isn't an issue when building the Linux image.

The actual binary runs fine with Qemu if I prove it as:
qemu-aarch64 $QEMU_LD_PREFIX/lib/ld-2.17.so --library-path $QEMU_LD_PREFIX/lib target/tmp/target/aarch64-unknown-linux-gnu/debug/hello

We might be able to specify additional arguments to pass to linux-runner/qemu-runner? This would solve the problem above. I have no idea why the dynamic library loader isn't working otherwise.

The actual binary runs fine with Qemu if I prove it as:
qemu-aarch64 $QEMU_LD_PREFIX/lib/ld-2.17.so --library-path $QEMU_LD_PREFIX/lib target/tmp/target/aarch64-unknown-linux-gnu/debug/hello

We might be able to specify additional arguments to pass to linux-runner/qemu-runner? This would solve the problem above. I have no idea why the dynamic library loader isn't working otherwise. Using QEMU_LD_PREFIX also doesn't work if I create a symbolic link for ld-linux-aarch64.so.1 in /lib.
EDIT: This could probably work reliably with --library-path "$QEMU_LD_PREFIX/lib:$LD_LIBRARY_PATH".

I extracted those dynamic libraries from official rpm packages, so I guess it's the link error in the ld-2.17.so.
I have rebuilt those dynamic libraries from glibc source. And I have test it myself. It should be ok now.

Seems like a CI issue: the error is:
throw new Error(`Artifact name is not valid: ${name}. Contains the following character: ${errorMessageForCharacter}
2022-09-02T12:58:15.8032086Z added 19 packages, and audited 20 packages in 1s

I don't believe thats the error. Should be this, failing on
2022-09-02T12:58:11.3417390Z  > [stage-1 15/15] RUN /aarch64-linux-gnu-glibc.sh:
2022-09-02T12:58:11.3417854Z #27 94.63       -e 's/ /,/g' -e 's/^/# define __ABI_TAG_VERSION /'; \
2022-09-02T12:58:11.3418172Z #27 94.63     echo "#endif" ) > /tmp/tmp.XZUfwAbYGl/build/csu/abi-tag.h.new; \
2022-09-02T12:58:11.3418256Z #27 94.63 done
2022-09-02T12:58:11.3418599Z #27 94.63 /bin/sh ../scripts/move-if-change /tmp/tmp.XZUfwAbYGl/build/gnu/lib-names.T /tmp/tmp.XZUfwAbYGl/build/gnu/lib-names.h
2022-09-02T12:58:11.3418805Z #27 94.63 touch /tmp/tmp.XZUfwAbYGl/build/gnu/lib-names.stmp
2022-09-02T12:58:11.3419204Z #27 94.63 if test -r /tmp/tmp.XZUfwAbYGl/build/csu/abi-tag.h.new; then mv -f /tmp/tmp.XZUfwAbYGl/build/csu/abi-tag.h.new /tmp/tmp.XZUfwAbYGl/build/csu/abi-tag.h; \
2022-09-02T12:58:11.3419433Z #27 94.63 else echo >&2 'This configuration not matched in ../abi-tags'; exit 1; fi
2022-09-02T12:58:11.3419736Z #27 94.63 mv -f /tmp/tmp.XZUfwAbYGl/build/csu/version-info.hT /tmp/tmp.XZUfwAbYGl/build/csu/version-info.h
2022-09-02T12:58:11.3420054Z #27 94.63 make[2]: Leaving directory `/tmp/tmp.XZUfwAbYGl/glibc-2.17/csu'
2022-09-02T12:58:11.3420456Z #27 94.63 make[1]: Leaving directory `/tmp/tmp.XZUfwAbYGl/glibc-2.17'
2022-09-02T12:58:11.3420550Z ------
2022-09-02T12:58:11.3420753Z Dockerfile.aarch64-unknown-linux-gnu.centos:31
2022-09-02T12:58:11.3420868Z --------------------
2022-09-02T12:58:11.3420934Z   29 |
2022-09-02T12:58:11.3421104Z   30 |     COPY aarch64-linux-gnu-glibc.sh /
2022-09-02T12:58:11.3421261Z   31 | >>> RUN /aarch64-linux-gnu-glibc.sh
2022-09-02T12:58:11.3421325Z   32 |
2022-09-02T12:58:11.3421391Z   33 |
2022-09-02T12:58:11.3421504Z --------------------
2022-09-02T12:58:11.3421809Z ERROR: failed to solve: process "/bin/sh -c /aarch64-linux-gnu-glibc.sh" did not complete successfully: exit code: 1
2022-09-02T12:58:11.3421879Z Error:
2022-09-02T12:58:11.3424762Z    0: `/usr/bin/docker buildx build --platform linux/amd64 --load --pull --cache-from 'type=registry,ref=ghcr.io/cross-rs/aarch64-unknown-linux-gnu:main-centos' --tag ghcr.io/cross-rs/aarch64-unknown-linux-gnu:staging-centos --tag ghcr.io/cross-rs/aarch64-unknown-linux-gnu:edge-centos --label 'org.opencontainers.image.title=cross' --label 'org.opencontainers.image.description=“Zero setup” cross compilation and “cross testing” of Rust crates' --label 'org.opencontainers.image.url=https://github.com/cross-rs/cross' --label 'org.opencontainers.image.source=https://github.com/cross-rs/cross' --label 'org.opencontainers.image.version=staging' --label 'org.opencontainers.image.created=2022-09-02T12:45:25.859Z' --label 'org.opencontainers.image.revision=ad436393ef52832e7b7d8136183cbe76c6577df9' --label 'org.opencontainers.image.licenses=Apache-2.0' --label 'org.opencontainers.image.title=cross (for aarch64-unknown-linux-gnu)' --label 'org.opencontainers.image.licenses=MIT OR Apache-2.0' --label 'org.opencontainers.image.created=2022-09-02T12:45:21.435Z' --label 'org.cross-rs.for-cross-target=aarch64-unknown-linux-gnu' --label 'org.cross-rs.runs-with=x86_64-unknown-linux-gnu' -f /home/runner/work/cross/cross/docker/Dockerfile.aarch64-unknown-linux-gnu.centos --progress plain .` failed with exit status: 1
2022-09-02T12:58:11.3424794Z
2022-09-02T12:58:11.3424870Z Location:
2022-09-02T12:58:11.3425165Z    /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/convert/mod.rs:550
2022-09-02T12:58:11.3425172Z
2022-09-02T12:58:11.3425337Z Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
2022-09-02T12:58:11.3425467Z Run with RUST_BACKTRACE=full to include source snippets.
2022-09-02T12:58:11.3441225Z ##[error]Process completed with exit code 1.
2022-09-02T12:58:11.3554532Z Post job cleanup.
2022-09-02T12:58:11.3579712Z Post job cleanup.

it's failing in the build

I don't believe thats the error. Should be this, failing on

Ah we need a mkdir -p  /usr/aarch64-linux-gnu/lib. Probably also bin and include as well.

+ git clone --depth 1 https://github.com/cross-rs/rust-cpp-hello-word /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ
Cloning into '/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ'...
+ pushd /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ
~/work/cross/cross/target/tmp/tmp.28W7DrHQRZ ~/work/cross/cross
+ retry cargo fetch
+ local tries=5
+ local timeout=1
+ local try=0
+ local exit_code=0
+ ((  try < tries  ))
+ cargo fetch
    Updating crates.io index
+ return 0
+ ((  1  ))
+ cross_run --target aarch64-unknown-linux-gnu
+ [[ -z qemu-user qemu-system ]]
+ for runner in ${RUNNERS}
+ echo -e '[target.aarch64-unknown-linux-gnu]\nrunner = "qemu-user"'
+ /home/runner/work/cross/cross/target/debug/cross run --target aarch64-unknown-linux-gnu -v
+ cargo metadata --format-version 1 --filter-platform aarch64-unknown-linux-gnu
+ rustc --print sysroot
+ /usr/bin/docker
+ /usr/bin/docker version -f '{{ .Server.Os }},,,{{ .Server.Arch }}'
+ rustup toolchain list
+ rustup target list --toolchain stable-x86_64-unknown-linux-gnu
+ rustup component list --toolchain stable-x86_64-unknown-linux-gnu
+ /usr/bin/docker run --userns host -e 'PKG_CONFIG_ALLOW_CROSS=1' -e 'XARGO_HOME=/home/runner/.xargo' -e 'CARGO_HOME=/home/runner/.cargo' -e 'CARGO_TARGET_DIR=/target' -e 'CROSS_RUNNER=qemu-user' -e CARGO_HTTP_CHECK_REVOKE -e CARGO_TMP_DIR -e RUSTFLAGS -e CARGO_NET_RETRY -e CARGO_INCREMENTAL -e 'USER=runner' -e 'QEMU_STRACE=1' --rm --user 1001:121 -v /home/runner/.xargo:/home/runner/.xargo:z -v /home/runner/.cargo:/home/runner/.cargo:z -v /home/runner/.cargo/bin -v /home/runner/work/cross/cross/target/tmp:/home/runner/work/cross/cross/target/tmp:z -v /home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu:/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu:z,ro -v /home/runner/work/cross/cross/target/tmp/target:/target:z -w /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ ghcr.io/cross-rs/aarch64-unknown-linux-gnu:staging-centos sh -c 'PATH="$PATH":"/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin" cargo run --target aarch64-unknown-linux-gnu -v'
       Fresh cc v1.0.73
   Compiling hellopp v0.1.0 (/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ)
     Running `rustc --crate-name build_script_build tmp.28W7DrHQRZ/build.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 -C metadata=0dcd7ebb55ff7026 -C extra-filename=-0dcd7ebb55ff7026 --out-dir /target/debug/build/hellopp-0dcd7ebb55ff7026 -L dependency=/target/debug/deps --extern cc=/target/debug/deps/libcc-a23a0e4ab5ac45ce.rlib`
     Running `/target/debug/build/hellopp-0dcd7ebb55ff7026/build-script-build`
The following warnings were emitted during compilation:

warning: hellopp.cc:1:20: fatal error: iostream: No such file or directory
warning:  #include <iostream>
warning:                     ^
warning: compilation terminated.

error: failed to run custom build command for `hellopp v0.1.0 (/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ)`

Caused by:
  process didn't exit successfully: `/target/debug/build/hellopp-0dcd7ebb55ff7026/build-script-build` (exit status: 1)
  --- stdout
  TARGET = Some("aarch64-unknown-linux-gnu")
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-linux-gnu")
  CXX_aarch64-unknown-linux-gnu = None
  CXX_aarch64_unknown_linux_gnu = Some("aarch64-linux-gnu-g++")
  CXXFLAGS_aarch64-unknown-linux-gnu = None
  CXXFLAGS_aarch64_unknown_linux_gnu = None
  TARGET_CXXFLAGS = None
  CXXFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("neon,pmuv3")
  running: "aarch64-linux-gnu-g++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-Wall" "-Wextra" "-o" "/target/aarch64-unknown-linux-gnu/debug/build/hellopp-62f2f1122f51c2f8/out/hellopp.o" "-c" "hellopp.cc"
  cargo:warning=hellopp.cc:1:20: fatal error: iostream: No such file or directory
  cargo:warning= #include <iostream>
  cargo:warning=                    ^
  cargo:warning=compilation terminated.
  exit status: 1

  --- stderr

  error occurred: Command "aarch64-linux-gnu-g++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-Wall" "-Wextra" "-o" "/target/aarch64-unknown-linux-gnu/debug/build/hellopp-62f2f1122f51c2f8/out/hellopp.o" "-c" "hellopp.cc" with args "aarch64-linux-gnu-g++" did not execute successfully (status code exit status: 1).

+ git clone --depth 1 https://github.com/cross-rs/rust-cpp-hello-word /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ
Cloning into '/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ'...
+ pushd /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ
~/work/cross/cross/target/tmp/tmp.28W7DrHQRZ ~/work/cross/cross
+ retry cargo fetch
+ local tries=5
+ local timeout=1
+ local try=0
+ local exit_code=0
+ ((  try < tries  ))
+ cargo fetch
    Updating crates.io index
+ return 0
+ ((  1  ))
+ cross_run --target aarch64-unknown-linux-gnu
+ [[ -z qemu-user qemu-system ]]
+ for runner in ${RUNNERS}
+ echo -e '[target.aarch64-unknown-linux-gnu]\nrunner = "qemu-user"'
+ /home/runner/work/cross/cross/target/debug/cross run --target aarch64-unknown-linux-gnu -v
+ cargo metadata --format-version 1 --filter-platform aarch64-unknown-linux-gnu
+ rustc --print sysroot
+ /usr/bin/docker
+ /usr/bin/docker version -f '{{ .Server.Os }},,,{{ .Server.Arch }}'
+ rustup toolchain list
+ rustup target list --toolchain stable-x86_64-unknown-linux-gnu
+ rustup component list --toolchain stable-x86_64-unknown-linux-gnu
+ /usr/bin/docker run --userns host -e 'PKG_CONFIG_ALLOW_CROSS=1' -e 'XARGO_HOME=/home/runner/.xargo' -e 'CARGO_HOME=/home/runner/.cargo' -e 'CARGO_TARGET_DIR=/target' -e 'CROSS_RUNNER=qemu-user' -e CARGO_HTTP_CHECK_REVOKE -e CARGO_TMP_DIR -e RUSTFLAGS -e CARGO_NET_RETRY -e CARGO_INCREMENTAL -e 'USER=runner' -e 'QEMU_STRACE=1' --rm --user 1001:121 -v /home/runner/.xargo:/home/runner/.xargo:z -v /home/runner/.cargo:/home/runner/.cargo:z -v /home/runner/.cargo/bin -v /home/runner/work/cross/cross/target/tmp:/home/runner/work/cross/cross/target/tmp:z -v /home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu:/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu:z,ro -v /home/runner/work/cross/cross/target/tmp/target:/target:z -w /home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ ghcr.io/cross-rs/aarch64-unknown-linux-gnu:staging-centos sh -c 'PATH="$PATH":"/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin" cargo run --target aarch64-unknown-linux-gnu -v'
       Fresh cc v1.0.73
   Compiling hellopp v0.1.0 (/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ)
     Running `rustc --crate-name build_script_build tmp.28W7DrHQRZ/build.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 -C metadata=0dcd7ebb55ff7026 -C extra-filename=-0dcd7ebb55ff7026 --out-dir /target/debug/build/hellopp-0dcd7ebb55ff7026 -L dependency=/target/debug/deps --extern cc=/target/debug/deps/libcc-a23a0e4ab5ac45ce.rlib`
     Running `/target/debug/build/hellopp-0dcd7ebb55ff7026/build-script-build`
The following warnings were emitted during compilation:

warning: hellopp.cc:1:20: fatal error: iostream: No such file or directory
warning:  #include <iostream>
warning:                     ^
warning: compilation terminated.

error: failed to run custom build command for `hellopp v0.1.0 (/home/runner/work/cross/cross/target/tmp/tmp.28W7DrHQRZ)`

Caused by:
  process didn't exit successfully: `/target/debug/build/hellopp-0dcd7ebb55ff7026/build-script-build` (exit status: 1)
  --- stdout
  TARGET = Some("aarch64-unknown-linux-gnu")
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-linux-gnu")
  CXX_aarch64-unknown-linux-gnu = None
  CXX_aarch64_unknown_linux_gnu = Some("aarch64-linux-gnu-g++")
  CXXFLAGS_aarch64-unknown-linux-gnu = None
  CXXFLAGS_aarch64_unknown_linux_gnu = None
  TARGET_CXXFLAGS = None
  CXXFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("neon,pmuv3")
  running: "aarch64-linux-gnu-g++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-Wall" "-Wextra" "-o" "/target/aarch64-unknown-linux-gnu/debug/build/hellopp-62f2f1122f51c2f8/out/hellopp.o" "-c" "hellopp.cc"
  cargo:warning=hellopp.cc:1:20: fatal error: iostream: No such file or directory
  cargo:warning= #include <iostream>
  cargo:warning=                    ^
  cargo:warning=compilation terminated.
  exit status: 1

  --- stderr

  error occurred: Command "aarch64-linux-gnu-g++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-Wall" "-Wextra" "-o" "/target/aarch64-unknown-linux-gnu/debug/build/hellopp-62f2f1122f51c2f8/out/hellopp.o" "-c" "hellopp.cc" with args "aarch64-linux-gnu-g++" did not execute successfully (status code exit status: 1).

It seems missing c++ library, which should be added in the future.

It seems missing c++ library, which should be added in the future.
Could you just skip c++ checks in CI for the time being?

you can skip the cpp tests by removing cpp: 1.
What do you mean with which should be added in the future, is it not possible to do that now? Why?

It seems missing c++ library, which should be added in the future.
Could you just skip c++ checks in CI for the time being?

you can skip the cpp tests by removing cpp: 1.
What do you mean with which should be added in the future, is it not possible to do that now? Why?

Because I don't know how to do it right. Hope some could help.

I think I have everything working. Going to finish the testing, but I have it supporting C++ right now, including both dynamic and static libs. I can commit directly to the branch.

bors try --target aarch64-unknown-linux-gnu.centos
I've fixed the C++ issues, it should be good to merge.    But it's weird it cannot find libgcc_s and libstdc++.so libraries if I do not mv  its directory from lib64 to lib mv /usr/aarch64-linux-gnu/lib64/* /usr/aarch64-linux-gnu/lib`
if it is a test script issue?

FYI: for multi-line code blocks, you need to use 3 backticks, like:
\`\`\`bash
#!/usr/bin/env bash
...
\`\`\`

As for the fix, it was changing libgcc_s.so to libgcc.so (both are symlinked to libgcc_s.so.1. It wasn't a test script issue: I was testing using g++ directly with a sample C++ project using iostreams.

It now passes, lgtm. Do you know how to squash the commit history?

I have squashed the commit history.

It now passes, lgtm. Do you know how to squash the commit history?

I have squashed the commit history.

It now shows 5 commits and too many files changed. I can squash the commit history if you want. It seems that you rebased all 5 commits off of the current main I believe?

It now passes, lgtm. Do you know how to squash the commit history?

I have squashed the commit history.

It now shows 5 commits and too many files changed. I can squash the commit history if you want. It seems that you rebased all 5 commits off of the current main I believe or merged them in? It's doing something unusual.

OK. you can just help me to squash the commit history.

bors r=Emilgardis,Alexhuszagh


internal compiler error for generic function on embedded struct

What version of Go are you using (go version)?

$ go version
go version go1.19 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
https://go.dev/play/p/k1QHUywARe8
What did you expect to see?
It compile just fine on go 1.18
What did you see instead?
Compile error unless I uncomment line 47-51

Seem duplicated of https://github.com/golang/go/issues/54058

Confirm this is duplicated, and https://go-review.googlesource.com/c/go/+/428356 will fix this.

@cuonglm Just to clarify, you confirmed this is a duplicate of #54225? (That's the issue fixed by the linked CL, but earlier you said it seemed like a duplicate of #54058.)

Ops, sorry, it's my typo. It's duplicated of #54225.

@mdempsky Hmm, it's actually my operation error. Without CL 428356, the program is built ok in non-unified at tip, so there must be other fix. I'm bisecting to find exact one.

@mdempsky https://go-review.googlesource.com/c/go/+/422274 fixes this, so it's duplicated of #54348


Small typo in one of the diagrams

[Enter feedback here]
The diagram in the section "Peered virtual network workloads without Azure Private Resolver" has a small typo in step 4 of the DNS resolution flow.
The FQDN is spelled "sql-serve-privatelink.database.windows.net" when it should be "sql-server-privatelink.database.windows.net". Note the missing 'r' in the word 'server'.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b7dad0c2-4f8c-f3c4-425c-cd8d1bc044b6
Version Independent ID: 429b56a1-c11b-4589-7f54-d229855a5b4d
Content: Azure Private Endpoint DNS integration
Content Source: articles/private-link/private-endpoint-dns-integration.md
Service: private-link
GitHub Login: @abell
Microsoft Alias: abell

@mjrich19
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.

Hello @mjrich19, I appreciate your contribution to the docs! I am working to resolve this issue. Thank you! #please-close


use pyupgrade to update syntax

add pyupgrade pre-commit hook
run pyupgrade (pre-commit run -a)
ruff --fix
remove pyupgrade hook
reverted changes to third_party/ directory
made manual type fixes (removing from typing import DefaultDict, Deque, Optional, Union...) - I'm not sure why pyupgrade didn't get these, maybe because some were nested

Nice, I think this is a good improvement. Some thoughts while reading this:

This almost makes me want to enable implicit optional, might make the types even more readable
Is there a way to enforce this in CI?
Want to make a script that runs pyupgrade? I'd be curious to run that once in a while - I didn't know about capture_output=True

I agree it would be more readable.. It doesn't work for assignments, only function default args.

Made a branch: https://github.com/commaai/openpilot/compare/master...incognitojam:openpilot:implicit-optional

I'd merge the implicit optional PR if you wanna make it. Looks pretty good!


Snowflake - "Bind Parameter(s)" menu inappropriately appears when running query that includes JSON parsing

Description
I'm using Snowflake, and I'm trying to access data that must be parsed as JSON using the Snowflake try_parse_json() function.
my query looks like:
select
try_parse_json(my_json_column):my_nested_subcolumn::string as my_nested_subcolumn
from my_table;

When I run a query like this in DBeaver, the "Bind Parameter(s)" menu appears, with "my_nested_subcolumn" in the "Name" column, and the "Value" column empty, as if asking me to input text.
But I'm not trying to bind a parameter, I'm trying to query nested data in a JSON column!
If I hit "ignore" the query runs correctly, but this behavior is annoying and confusing. I feel like the "Bind Parameter(s)" menu should not appear in this case.
DBeaver Version
Version <IP_ADDRESS>303250535
Operating System
macOS Monterey 12.6.3
Database and driver
Snowflake 7.10.1
snowflake-jdbc 3.13.29
Steps to reproduce

attempt to run query containing JSON parsing like:

select
try_parse_json(my_json_column):my_nested_subcolumn::string as my_nested_subcolumn
from my_table;

"Bind Parameter(s)" menu appears when it should not.

Additional context
No response

Thank you for bug report. As a workaround you can change Named parameter prefix or disable SQL parameters if you don't use them here

It also impacts XML parsing in Snowflake - see below sample:
SELECT XMLGET(PARSE_XML(column1),'description'):"$"::STRING AS DESC
FROM VALUES ('"This is a sample description"')

Is there a session-level setting that could be invoked in the script to remove parameter binding?

SELECT XMLGET(PARSE_XML(column1),'description'):"$"::STRING AS DESC
FROM VALUES ('"This is a sample description"')

@rene-medina I believe unchecking Enable SQL parameters setting for the current script will help

Thank you Elizabeth - that will do it for all my sessions to Snowflake - Is there a command that can be called to enable/disable it in one query only?

Unfortunately, there is no way to disable it only for one or several queries. If you open this settings from script, this setting will work in scope of this script only. So, probably, if it's possible for your case, you can move only this issued query to a separate script with such settings.

Understood - thank you Elizabeth...


Add Context support

I'm not really sure what this would look like... would the irc.Message have a context as well?

at the very least, it would be great if the client.Run could take a context in order to support exiting the main loop.

This has (finally) been fixed with the addition of RunContext.


Fix travis CI

I didn't find the cause of the problems for 1.8.1 x 20.3 and didn't feel like it was worth the time to spend a lot of time investigating. I added an Erlang 22 to make the matrix more current.
I'll do a similar thing on Ace

As I mentioned in the other PR I think I'd be in favour of removing the dialyzer check in all but the most recent versions of Erlang/Elixir, so that we don't have to fight behaviours that have been since fixed.

That would make sense to me. The fact that tests start failing on dialyzer has never really given much useful insight.
certainly not compared to the value of the tests


haskell generic-builder: Fix setup depends

Motivation for this change
I was referring to the wrong package db in a few places. Thanks @ElvishJerricco for catching.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Made https://hydra.nixos.org/jobset/nixpkgs/ericson2314-haskell-updates to test


Add support for full Graph RBAC

based on the future of AD Graph vis a vis MS Graph, we will only expose a limited subset of AD Graph, not the whole thing -- just Service Principal support.
@jianghaolu assigning to you, since you're working on it.

Close via #1655


Added more SpriteKit extensions

Helping out with Issue #303.

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 487 tests, with 0 failures (0 unexpected) in 3.528 (4.277) seconds

:book:
tvOS: Executed 457 tests, with 0 failures (0 unexpected) in 1.879 (2.396) seconds

:book:
macOS: Executed 331 tests, with 0 failures (0 unexpected) in 1.293 (1.550) seconds

SwiftLint found issues
Warnings

File
Line
Reason

SKPhysicsBodyExtensions.swift
14
Lines should not have trailing whitespace.

SKPhysicsBodyExtensions.swift
28
Lines should not have trailing whitespace.

SKPhysicsContactExtensions.swift
14
Lines should not have trailing whitespace.

SKSpriteNodeExtensions.swift
47
Lines should not have trailing whitespace.

SKSpriteNodeExtensions.swift
49
Lines should not have trailing whitespace.

SKSpriteNodeExtensions.swift
53
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

@guykogus Any ideas for how to unit test this SpriteKit stuff?

I guess you'll need to create a few SKPhysicsBody objects and place them in such a way that some should be touching while others are not and test your functions to see that they work.
As far as the animation function goes, maybe add an atlas with just a few frames (keep it as small as possible so as to not bloat the repo), run a test that runs the animation and then check it's state.
E.g.
var isFinished = false
let timePerFrame = TimeInterval(1.0 / 30.0)
let spriteNode = SKSpriteNode()
spriteNode.animate(withAtlasNamed: "atlasName",
                   timePerFrame: timePerFrame,
                   resize: false,
                   restore: false,
                   completion: {
                    isFinished = true
})

XCTAssertFalse(isFinished)
Thread.sleep(forTimeInterval: timePerFrame)
XCTAssertFalse(isFinished)
Thread.sleep(forTimeInterval: timePerFrame)
XCTAssertTrue(isFinished)

@guykogus Any idea why those tests fail on macOS but pass on iOS and tvOS?

No idea. The only thing I can think of is the timeout of the expectation being short, but that would surprise me. Have you tried running the macOS tests locally?

@guykogus Yep, it's saying:

Asynchronous wait failed: Exceeded timeout

However, the expectation should be fulfilled immediately when the scene is presented, as it is in iOS and tvOS.

So I have no experience with SpriteKit, I'm kind of useless on this one

It's been a long time since I used SpriteKit, and never used it on macOS, so can't really help you. Maybe try increase the timeout, but there may be something that it's expecting to happen...

@guykogus So i just came to the realization that the SKSpriteNode animation method I added is probably useless, as the texture assets would be in a different Bundle from SwifterSwift. I think I should probably remove that one.
Still not sure about the macOS unit tests failing.

Closing this due inactivity.
Feel free to reopen it anytime :))


[patch] JavaScript regex parsing fails for regexen ending with newline

(Original issue 383 created by None on 2009-01-15T20:01:42+00:00)
The problem is demonstrated in some code from jQuery 1.3.0:
http://gist.github.com/47566 (this uses pygments for highlighting)
The patterns for finding regexen do not allow for an ending newline. This patch adds that to the 2nd Regex pattern.
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 383 last updated on 2009-01-18T10:53:30+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2009-01-18T10:53:30+00:00)
Thanks, fixed in [23e8b33b1e4f].


Mac OS memory fixes

Howdy!
I don't think you will likely want to just take this PR, but you might want to look at how I fixed some of the bits here. Some things I found while trying to implement my app that renders directly to the window (no OpenGL, etc).

The way it was using NSImage and NSRepresentation was causing gigabyte of allocations that were not being cleaned up. If you want to check run the app for about 10 minutes with activity monitor on. This changes the swapBuffer code to make that a bit more streamlined - seems to behave better now.
Similar situation with the NSEvents - I created some autorelease pools around the window and the checkEvents code to try to handle the memory a bit nicer. Because of the way this works (MacOS sends messages to objects like smalltalk not like calling functions) I had to make use of the close window call back to fire a custom message so it can be handled in the checkEvent loop.
The way data was being taken from the pasteboard was corrupting memory - the new way seems to not crash / corrupt, but uses the NSEvent system more.

Because of the redraw changes, the code for window setup is slightly different for Mac vs Linux and Windows. I can't share the code I am working on, but if you are using RAW renderer you'd need to do something like:
 562      RGFW_window *win =
 563          RGFW_createWindow("SPIKE", RGFW_RECT(0, 0, 272, 376), RGFW_NO_RESIZE | RGFW_ALLOW_DND | RGFW_NO_GPU_RENDER);

643  #ifndef __APPLE__
644      Context ctx = {win, RGFW_getScreenSize()};
645  #else
646      Context ctx = {win, {272, 376}};
647  #endif

If you wanted a window of 272, 376 because Mac will try to create a draw surface that is the size of the whole screen instead of just the small area. Anyway, that works.
Again, I don't think you should just take this PR as is, but hopefully this provides some hints around some things that might need fixing. With this PR my app now behaves nicely memory wise and can do Drag and Drop consistently without pooping the bed :D

@robrohan Make sure your PR is synced with the current version of RGFW, it seems to have overwritten some of the last few commits I made.
Many of the changes look great, although I want to do a review before doing a pull.

Your fork doesn't seem to compile with all the warnings enabled. I'm not sure how it passed the checks.
Also, the clipboard + Drag and Drop still seems to cause a leak.

Hi @EimaMei - I completely agree with you in principle about memory management. That was what originally led me to this library in the first place, but while trying to fix the number of allocations that were happening and doing some research into it, I just don't see how it can work that way on current Mac OS. I mean, please keep trying I'd love to be wrong, but I can't see how it's possible.
@ColleagueRiley I'll take one quick look, but this works fine on my project and that's kind of all I am after. I just did this PR to better explain some changes I made. As I mentioned, I don't think you want to take this as is, but can use it as a reference if you dig into some of these bugs.
For reference, my project is compiling fine with these flags:
Linux
gcc  -Wall -Wextra -Wpedantic -Wformat=2 -Wno-unused-parameter -Wshadow -Wwrite-strings -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -Wnested-externs -Wmissing-include-dirs -Wno-unused  -ggdb -std=c99 \
	-DNDEBUG \
	-DVERSION="\"6e935af\"" \
	src/main.c \
	-isystem ./vendor/ \
	-o build/XXXXX \
	-lXrandr -lX11 -lm -lGL -ldl -lpthread -D_POSIX_C_SOURCE=200112L -mshstk

Mac
clang  -Wall -Wextra -Wpedantic -Wformat=2 -Wno-unused-parameter -Wshadow -Wwrite-strings -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -Wnested-externs -Wmissing-include-dirs -Wno-unused  -ggdb -std=c99 \
	-DNDEBUG \
	-DVERSION="\"6e935af\"" \
	src/main.c \
	-isystem ./vendor/ \
	-o build/XXXX \
	-lm -framework Foundation -framework AppKit -framework CoreVideo -mshstk

Windows
gcc  -Wall -Wextra -Wpedantic -Wformat=2 -Wno-unused-parameter -Wshadow -Wwrite-strings -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -Wnested-externs -Wmissing-include-dirs -Wno-unused  -ggdb -std=c99 \
	-DNDEBUG \
	-DVERSION="\"6e935af\"" \
	src/main.c \
	-isystem ./vendor/ \
	-o build/XXXXX \
	-lshell32 -lwinmm -lgdi32 -lopengl32 -mwindows -mshstk

@EimaMei one last bit re: " it should be noted that at the time I thought that the 'release' method would actually release the memory of the specified object, but it seems it doesn't judging by your comments" If you use mac's instruments.app and watch the allocations, you'll see it'll create a heap of ColorSync and other supporting objects when creating the NSRepresentation (or maybe NSImage). It seems that even if the NSRep and NSImage are relelased it doesn't release the supporting objects (or maybe, on the os they are in some kind of pool so they hang around for a long while - who can say). But from what I could find NSImage is very heavy and shouldn't be called in a loop.
While trying to fix it I did do a thing with a dirty flag and would only redraw when the screen changed - and that helped a bit, but not enough. But might be something to check.

Thank you for the information

I completely agree with you in principle about memory management. That was what originally led me to this library in the first place, but while trying to fix the number of allocations that were happening and doing some research into it, I just don't see how it can work that way on current Mac OS. I mean, please keep trying I'd love to be wrong, but I can't see how it's possible.

I might look into it one day (not soon, because I'm working on other stuff), but that would be quite a strange design choice for a "low-level" system API if that turned out to be true. If it's using some ARC system, then surely at some point release as a method does work, though considering how black box-ish Cocoa is compared to other system APIs, I can only speculate. My conspiracy is that Apple want programmers to utilize Cocoa and Obj-C in a way they seem fit (for example, their push for callback functions, @autoreleasepool, etc and how the default templates for XCode projects always ONLY utilize these features), so not only manually managing your events and/or memory is discouraged due to this, but this also means less people have working examples of applying such techniques that other people can learn from. But that's just my opinion.

@EimaMei one last bit re: " it should be noted that at the time I thought that the 'release' method would actually release the memory of the specified object, but it seems it doesn't judging by your comments" If you use mac's instruments.app and watch the allocations, you'll see it'll create a heap of ColorSync and other supporting objects when creating the NSRepresentation (or maybe NSImage). It seems that even if the NSRep and NSImage are relelased it doesn't release the supporting objects (or maybe, on the os they are in some kind of pool so they hang around for a long while - who can say). But from what I could find NSImage is very heavy and shouldn't be called in a loop.

As I said, I'm very skeptical that the release just does absolutely nothing because at that point why even have a release method? I don't know, maybe my original code used NSImage in a funny way (though it makes me somewhat confused as to how CGImageRef works better than NSImage for this, but whatever).

@robrohan
How would you like me to handle your PR? Tomorrow I plan on merging stuff by hand, leaving credits via comments then fixing any remaining memory issues on the macOS version and closing this PR.

I don't need any credit - all good.

I implemented many of the features of this PR into Rgfw. I didn't implement the quit system because it seemed to be superfluous.

Cool. I wasn’t super keen on that part anyway. However I found that when the window was closed via clicking the X, the close event was handled by the OS and setting the win->type RGFW_quit would never make it to the event loop. Meaning the parent application would never get the message to actually exit (hitting escape works because that’s a key press event and that get dequeued before the window closing.)The underlying issue with most of this is Mac has that underlying event stream which is running in a different thread, but the game loop in the C code is checking for events per frame. That work around was the only way I could ensure that clicking the windows X would get on the event queue and make it to the parent. However I did try several things and may have painted myself into a corner somehow so if clicking the windows X makes it back to your C code… good times!Sent from the futureOn Jul 13, 2024, at 8:37 AM, Colleague Riley @.***> wrote:
I implemented many of the features of this PR into Rgfw. I didn't implement the quit system because it seemed to be superfluous.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


fix: antd notificationProvider bug

IMPORTANT: Please do not create a Pull Request without creating an issue first.
notificationProvider cannot access the theme context when the static notification method is used. So used the App component's notification instance to access the theme context.
Passed the App component as a child of ConfigProvider to access the theme context.
Test plan (required)
Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues
Closes #4654
Self Check before Merge
Please check all items below before review.

[ ] Corresponding issues are created/updated or not needed
[ ] Docs are updated/provided or not needed
[ ] Examples are updated/provided or not needed
[ ] TypeScript definitions are updated/provided or not needed
[ ] Tests are updated/provided or not needed
[ ] Changesets are provided or not needed

It's absolutely my pleasure @aliemir.
Absolutely, having different viewpoints will make it resistant to further issues.
Hopefully, there won't be any issues as the 'mui' 'notificationProvider' is also exported as a function.

Hi @aliemir,no worries. I can take care of it and if I need help, I'll text you on Discord.😃

I know it's been a long run 😄 But this is the final change, then we are good to go!
Thanks for the great contribution and follow-ups 🎖

No problem at all. I'm glad I could help. 😃
I was able to connect with amazing people like you, @omeraplak, and @aliemir because of this. So it's totally worth the wait. 🙌


Continuous failure to produce attestations

I'm testing teku behavior on prater testnet
Steps to Reproduce (Bug)

Import 10 validators to teku. First 5 validators need to be already-validating. Import slashing protection from another client
The other 5 validators need to be activating in some short time
Wait until activation.

Expected behavior: The new validators will produce attestations as expected
Actual behavior: all attestations will be missed. The attestations start missing 5 hours before the activation, even for existing validators
Versions (Add all that apply)

Software version: teku/v21.10.1/linux-x86_64/-debian-openjdk64bitservervm-java-17
Java version: java 17
OS Name & Version: debian 11
Kernel Version: 5.10.0

Additional Information
This seems like very bad bug, especially one week before altair launch. I have stopped testing this after 2+ hours, because nothing was produced. Switched to a different client, and all is fine.
The performance log is here: https://gist.github.com/paulmillr/da16133f9d010c866ddc1fd0fd4639ec
No errors, only lots of SlashableConditionException after attestations started dropping.

SlashableConditionException indicates that the node has refused to sign something because it would be potentially slash able. You definitely do NOT want teku to proceed to produce attestations in that case.
My guess is that the slashing protection file you imported includes attestations that are in the future.  Since Teku uses the minimal approach to slashing protection (which is much simpler, thus reliable and doesn't not consume an ever growing amount of disk space)  it will refuse to produce attestations until that future slot is passed.
It would be worth reviewing the attestations in the slashing protection file you imported to check if any are in the future - if so, teku is correctly preventing you from getting slashed.  You can also review the slashing protection records to see what Teku did import - they're simple YAML files under <data-path>/validators/slashprotection/.  Given this is the prater testnet if you're able to provide the slashing import file and resulting .yml files from that slashprotection directory we can review.
Also worth noting that Altair launched on the Prater testnet some time back.

My guess is that the slashing protection file you imported includes attestations that are in the future. Since Teku uses the minimal approach to slashing protection (which is much simpler, thus reliable and doesn't not consume an ever growing amount of disk space) it will refuse to produce attestations until that future slot is passed.

I see stuff like that:
lastSignedBlockSlot: 1256396
lastSignedAttestationSourceEpoch: 47811
lastSignedAttestationTargetEpoch: 47812
---
lastSignedBlockSlot: 0
lastSignedAttestationSourceEpoch: 47811
lastSignedAttestationTargetEpoch: 47812
---
lastSignedBlockSlot: 1126761
lastSignedAttestationSourceEpoch: 47805
lastSignedAttestationTargetEpoch: 47810
---
lastSignedBlockSlot: 1201568
lastSignedAttestationSourceEpoch: 47811
lastSignedAttestationTargetEpoch: 47812

Seems fine. There are just 4 epochs there in sourceEpoch: 47805, 47807, 47810, 47811. After that i've switched to a different client.

My guess is that the slashing protection file you imported includes attestations that are in the future

If it was, why did it validate fine for 5+ hours after import? It started missing attestations after that.

Ok, interesting. I think I'd need to see the full teku logs to dig in further.

No problem. How do I pass them to you?

You can email me at<EMAIL_ADDRESS>is probably easiest.

Sent.


[Event Hubs Client] Preserve AMQP Exceptions

Summary
The focus of these changes is to preserve AMQP exceptions as inner exceptions after translating, to allow for deeper insight of service behavior and assist in debugging efforts.
Last Upstream Rebase
Monday, January 19, 11:25am (EST)

/azp run net - eventhub - tests

/azp run net - eventhub - tests


Markdown code blocks without a command should be skipped

minimal reproducible example:
# README.md
```
```

output of cargo test:
running 1 test
Testing README.md:setup ... failed
Failed: Expected `$` on line 3, got ````
`

Update snapshots with `TRYCMD=overwrite`
Debug output with `TRYCMD=dump`
test cli ... FAILED

failures:

---- cli stdout ----
thread 'cli' panicked at '1 of 1 tests failed', /home/figsoda/.cargo/registry/src/github.com-1ecc6299db9ec823/trycmd-0.14.6/src/runner.rs:93:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    cli

non-empty code block without a command should also be skipped IMO

I feel like at that point a tag should be put on the code fence, either a ignore or a relevant lang.
Now, another topic maybe worth discussing is whether we should assume code blocks without a trycmd or console lang are for trycmd.


Add green panel on thank you page

What is the context of this PR?
Describe what you have changed and why, link to other PRs or Issues as appropriate.
How to review
Describe the steps required to test the changes (include screenshots if appropriate).
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Green panel on thank you page (2 SP)


Internal Server Error on [POST] /api/v1/events/slack/action

Describe the bug
Got response code 500 (Internal Server Error) on API /api/v1/events/slack/action.
To Reproduce
curl -v -X POST https://dispatch.happyfresh.net/api/v1/events/slack/action

Error message from Sentry:
Exception in ASGI application
the JSON object must be str, bytes or bytearray.

Expected behavior
Get success response and be able to integrate with Slack.
Screenshots

Additional context
I am hosting Dispatch on AWS ECS

Sorry, I put the endpoint in the wrong Slack configuration. It should be using slack/event endpoint

Sorry, I put the endpoint in the wrong Slack configuration. It should be using slack/event endpoint


[W5][W09-4] Xue Chenyang

@Xue-Chenyang
Some comments added. Please take note and close the pull request.


Cannot find host interface on "Zabbix server" for item key "LoadMinute".

I imported the template but when I try adding it to the host I keep getting an "Error updating host" Cannot find host interface on "Zabbix server" for item key "LoadMinute".

Hi @krepelcleefton,
Which Zabbix version are you using this template on? Based on the issue description it seems you are putting this template on the Zabbix server, is that correct?

I imported the template but when I try adding it to the host I keep getting an "Error updating host" Cannot find host interface on "Zabbix server" for item key "LoadMinute".

Under Configuration/Hosts/youredgerouter, on Interfaces you have to change from agent to SNMP to get it to work. If you still have Agent you will receive that error message.

I imported the template but when I try adding it to the host I keep getting an "Error updating host" Cannot find host interface on "Zabbix server" for item key "LoadMinute".

Under Configuration/Hosts/youredgerouter, on Interfaces you have to change from agent to SNMP to get it to work. If you still have Agent you will receive that error message.


docker daemon causing error with registry v2

Description of problem:
I have a registry:2.0.1 running on a docker-machine host (provider=virtualbox with port forwarding).
On a remote host, When I run docker pull <remote_host>:5000/<my_image> I got the following output:
latest: Pulling from <remote_host>:5000/<my_image>
8ebbde154a62: Pulling fs layer
c12da83ee7c1: Pulling fs layer
a16207605ac6: Pulling fs layer
ea994adb8f5e: Pulling fs layer
b9a671861279: Pulling fs layer
a58de78a6a7f: Pulling fs layer
12724ce38086: Pulling fs layer
6bafb24bd6c1: Pulling fs layer
4d217892bcfe: Pulling fs layer
b741ec2037b8: Pulling fs layer
983765c3d97c: Pulling fs layer
96f8e8f069ed: Pulling fs layer
Pulling repository <remote_host>:5000/<my_image>
FATA[0000] Error: image <my_image> not found.

Initially I though that it was an error on registry and for that reason I raised an issue at https://github.com/docker/distribution/issues/639
After some debug sessions and instructed by @stevvooe I'm reporting this bug at https://github.com/docker/docker
More information (docker dameon's log) about the issue can be found at https://gist.github.com/rafabene/64296e23cfd8ab572587 or at https://github.com/docker/distribution/issues/639
docker version:
Client version: 1.7.0
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 0baf609
OS/Arch (client): linux/amd64
Server version: 1.7.0
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 0baf609
OS/Arch (server): linux/amd64

docker info:
Containers: 0
Images: 0
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 0
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.0.5-boot2docker
Operating System: Boot2Docker 1.7.0 (TCL 6.3); master : 7960f90 - Thu Jun 18 18:31:45 UTC 2015
CPUs: 1
Total Memory: 996.2 MiB
Name: lab
ID: PDZY:FACX:O67C:VT5B:TULR:F6O5:BAHV:WB3T:YFVK:VAWH:GCMI:IJRP
Debug mode (server): true
File Descriptors: 10
Goroutines: 15
System Time: 2015-06-22T15:06:20.507139071Z
EventsListeners: 0
Init SHA1:
Init Path: /usr/local/bin/docker
Docker Root Dir: /mnt/sda1/var/lib/docker
Labels:
 provider=virtualbox

uname -a:
Linux Colosus 4.0.4-303.fc22.x86_64 #1 SMP Thu May 28 12:37:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Environment details:
Running VirtualBox 4.3.26r98988  created by docker-machine version 0.3.0 (0a251fe)

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I've removed this issue from 1.7.1 release since it looks like it was already present in 1.6.2. It can still be released in 1.7.1 if we find the root cause and we can fix it, but otherwise, this should not block the release.

I think I'm seeing a similar issue. It was reported over at docker/distribution issue #468 and stevvooe recommended this be posted here.

I am seeing this same issue with
registry:2 (b4ad0b763f11)
Docker version 1.6.2, build 7c8fca2-dirty
I am backing the registry with S3 and have isolated down to 1 machine.
The symptoms are the same, starts downloading, then finishes with image not found.
I am more than happy to debug as this is somewhat persistent in my setup.

This is a little tenuous, but this might be related to a fix we have in #15040.
@mpchlets @rafabene The fix should be in the next docker 1.8 release candidate. Would you mind giving it a try when this is available? If you can't wait and you're capable of building docker, you can checkout that PR branch and give the fix a try.
Reasoning: problems that kicked off #15040 were characterized by several successful v2 fetches followed by an EOF then fallback to v1. From the logs in the original complaint:
time="2015-06-20T00:14:58.318469285Z" level=error msg="Error from V2 registry: Get http://classroom.example.com:5000/v2/mysql/blobs/sha256:fdd04e6fcc43523cb5d1f8f09467d7b30925b7a2c06e86956fe0ba85a9dced6b: EOF"
time="2015-06-20T00:14:58.318497762Z" level=debug msg="image does not exist on v2 registry, falling back to v1"
time="2015-06-20T00:14:58.318508996Z" level=debug msg="pulling v1 repository with local name \"classroom.example.com:5000/mysql\""

The issue is a "double decompress" wipes out a reader, which then returns EOF on a later read.

ping @rafabene @mpchlets could you try if you are still able to reproduce this on the current release candidate? You can find 1.8.0-rc3 here; https://github.com/docker/docker/releases/tag/v1.8.0-rc3 thanks!

I just tried with the v1.8.1 release and I am still experiencing an issue but perhaps different or just manifesting differently, it unable to write the btrfs layer - could this just now be a slow disk?

getting a similar issue (see below) at AWS with Docker 1.8.1 and Distribution 2.1.1
however, it is interesting (and may or may not be helpful) that this issue does NOT occur when a pulling instance has a public IP that is exposed to the internet.
getting:
511136ea3c5a: Pulling fs layer b6718650e87e: Pulling fs layer 3d3c8202a574: Pulling fs layer 0114405f9ff1: Pulling fs layer 909b4f6c24a3: Pulling fs layer ad4d06fcc614: Pulling fs layer 48099a110ee0: Pulling fs layer f923b4c4b0f7: Pulling fs layer b69305eac730: Pulling fs layer 155bbe8ea690: Pulling fs layer 7bc0d465ab2f: Pulling fs layer bfb6c1a40c0d: Pulling fs layer e6b65ddbabe2: Pulling fs layer ea6f683b3a1f: Pulling fs layer 247b7849fd43: Pulling fs layer a4bfb897963c: Pulling fs layer e4b0e138b197: Pulling fs layer 706ebd5d0f05: Pulling fs layer ffd6164bcb29: Pulling fs layer a5831dcb25a9: Pulling fs layer 6b92501ef474: Layer already being pulled by another client. Waiting.
and seeing 404 for v1 in the logs.

I'm going to close this issue as the original issue was resolved in 1.8, and subsequent comments were over a year old. If you're having this issue on the current version of docker, please open a new issue instead


⚠ Bofrost.de has degraded performance

In 6bcb1b7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 837 ms

Resolved: Bofrost.de performance has improved in 8e07e08 after 6 minutes.


⚠ Bofrost.fr has degraded performance

In c6be3a3, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1053 ms

Resolved: Bofrost.fr performance has improved in 3c24349 after 10 minutes.


Add chart

resolve #291
Add Chart with market and pair selection
Use React TS

hey @Hjklvfr I opened your pr in a codespace and the widget doesn't fully render there. Inspect also shows a lot of errors. So we can't approve it at this point


How to clear "scanResults"

HI,
Is there any way to clear "scanResults" ?
It require when we disconnect device & goto connect screen again ,where we call  'FindDevicesScreen' then it shows old devices as snapshot.data of FlutterBlue.instance.scanResults stream gives the last result.
Note that while calling "scan" scanResults list get clears because it internally calls _scanResults.add([]);

Maybe we can add a clearList method to the class FlutterBlue. Or change the scan method:
Change
if (timeout != null) {
    killStreams.add(Observable.timer(null, timeout));
}

to
if (timeout != null) {
    killStreams.add(Observable.timer(clearList, timeout).listen(
        (clearList) {
            if (clearList)
            {
                _scanResults = BehaviorSubject.seeded([]);
            }
        }));
}

clearList being a boolean you can pass to the scan method.

Or at least add a 'lastScanDate' timestamp to the device to be able to filter devices.

Thanks for the reply .
But is there any way to clear scan results without editing package internal code ? as it is difficult to maintain if package version updates....

So is there an easy way to get the latest available device list?
From my usage, when I keep scanning all the device, if I turn off my ble device and turn on it again, since it is not a new device, the listen callback function doesn't get invoked immediately, it looks wired.

I know this is an old issue but any chance there is now a way to do this?? When I call repeatedly call startScan(timeout:X) I'm still using the listener from my original scan and it doesn't clear the results. I can't turn bluetooth off and on because I'm trying to maintain multiple connections. Any wizdom appreciated.


Add support for SQL Server 2000 and piping to Restore-DbaDatabase

Previously, it kept saying "No backups passed through". This ignores the check which doesn't work only on sql2000 and I also saw sql2000 had some dupes so I added a Sort-Object -Unique to ensure there were no dupes.
Code used to test: Get-DbaDatabase -SqlInstance sql2000 -Database pubs32 |Backup-DbaDatabase -Path C:\temp |Restore-DbaDatabase -SqlInstance sql2000 -WithReplace

didnt work, maybe i changed too much


change type from documentId in document model

Description
Please describe your pull request:

Why is it necessary?
alphanumeric document number (column "docID" in database has type varchar)
What does it improve?
flexible document number
Does it have side effects?
nope

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?

How to test?

Hi @chrisko5,
thanks for your PR :+1:
As the document ID is based on the values of the number ranges, these IDs have to be integers.
If you want to change this behavior, you will have to do much more, then just changing the PHPdoc in the doctrine models. For example a migration SQL is missing, for changing the column in the database.
Beside that, you should know, that the Shopware DB is not created on base of the doctrine models.
So we decided to close this PR because the change is incomplete and does not fix the underlying issue. If this change is still important to you, feel free to create a new pull request or create an issue on https://issues.shopware.com.
Best Regards


Save warning displayed when no changes made to Design settings

Issue Summary
When clicking on a label or link path in the navigation, even if no changes are made, you are still presented with an alert asking if you are sure you want to leave when clicking to other areas of Ghost admin.
To Reproduce

Go to the Design settings in Ghost admin
Click inside the label of an existing navigation item
Make no changes to the field, and click on "Posts" or any other location within the admin
See warning notification

Technical details:
Version 3.5.2
Environment production
Database mysql
Browser/OS: Any

Thank you, @frantzypants for writing this up. This occurs for both the primary and secondary navigation. The warning does not show if we click or type into the final empty "Label" box, but it does show if we click or type into the final corresponding link.


search highlight is not clear after hitting enter

I am on the current 2.0 branch. When I use ctrl+r or ctrl+s to search history, the matching highlight is not clear after hitting enter. Moreover, it persists if I navigate through history.
See the following screencast.

it turns out it is caused by my own code. sorry for the noise.

No problem, @randy3k!


Support querying and updating UniFi Networks

Added INetwork.ts to provide a contract for the Network entity Added Network.ts to represent a network in UniFi
Added Networks.ts to allow for querying all existing networks Updated Controller.ts to provide API to getNetworks
Add "networks" API to the IController interface
:memo: Description
This adds functionality to query a list of UniFi Networks as listed under the UnFi Settings > Networks console.  The desire was to utilize this library to build a Homebridge plugin that allows one to surface the UDM gateway and the networks in HomeKit. This then allows one to enable or disable the entire Network via HomeKit and control it via automations.  This fulfilled a need of mine as I have a certain member of my family entirely relegated to a separate VLAN network due to the propensity to click on just about anything.  I am able to easily enable and disable their internet connectivity when it's time to turn off.
:dart: Relevant issues
None that I'm aware of
:gem: Type of change

[x ] New feature (non-breaking change which adds functionality)

:scroll: Example code
await controller.login();
const [site] = await controller.sites.list();
const networks = await site.networks.list();
const [network] = networks.filter(
    (network) => network.name === "Brandon IoT",
);
network.enabled = true;
await network.save();

:vertical_traffic_light: How Has This Been Tested?
Manual testing was performed in the fashion listed in the example above as well as using it within the Homebridge plugin.  I was unable to get the existing integration tests to run successfully so I was not able to add to the test suite.
I did verify that the Network object returned was equivalent to the returned in the browser while monitoring traffic of the UniFi Network console.
I also based this code off the Site and Device implementations.
:checkered_flag: Checklist:

[ x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ x] I have commented my code, particularly in hard-to-understand areas

@thib3113 any direction you can point me in for addressing these errors?  Some of the errors are:
'snyk' requires an authenticated account. Please run 'snyk auth' and try again.
This seems to indicate either I or the integration needs an account configured?
Error: Resource not accessible by integration
It looks like everything succeeded but it wasn't able to reach 'https://api.github.com/repos/thib3113/unifi-client/check-runs'.
Happy to dig in but I'm new to some of these integrations!
Kind regards,
Kyle

@KyleBrandon It's a right problem :) . You don't have access to the repositories secrets . That's why :) .
I need to dig on it :) .
About the jest automated, you can see just before the http error :
Check payload: {"owner":"thib3113","repo":"unifi-client","head_sha":"23240b14c2c1011fdde0c38e1532467c5dae872c","name":"jest-github-action","status":"completed","conclusion":"success","output":{"title":"Jest tests passed","summary":"594 tests passing in 28 suites.","annotations":[]}}

( this json is the important part . all the tests succeeds ) .
About the tests, I need to dig on them too ... Sometimes, they are crashing on my side too (and some time with an unreadable erorr that I always failed to reproduce) ... I need to spend some time on this  (but didn't have the time now)

Ahh that makes sense. Would it help if I sent the error output from my test run?  KyleSent from my iPhoneOn Jul 25, 2023, at 4:40 AM, Thibaut SEVERAC @.***> wrote:
@KyleBrandon It's a right problem :) . You don't have access to the repositories secrets . That's why :) .
I need to dig on it :) .
About the jest automated, you can see just before the http error :
Check payload: {"owner":"thib3113","repo":"unifi-client","head_sha":"23240b14c2c1011fdde0c38e1532467c5dae872c","name":"jest-github-action","status":"completed","conclusion":"success","output":{"title":"Jest tests passed","summary":"594 tests passing in 28 suites.","annotations":[]}}
( this json is the important part . all the tests succeeds ) .
About the tests, I need to dig on them too ... Sometimes, they are crashing on my side too (and some time with an unreadable erorr that I always failed to reproduce) ... I need to spend some time on this  (but didn't have the time now)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

( think about editing your messages if you answer by mail to make it more readable . And I didn't recommend answering with mail, because it can expose private informations )
yes, the message can maybe help ... but I'm not sure I can't do it this week / week end ...

@KyleBrandon if I correctly remember, "tests scenario" need a real machine . or the mocks from nock ... I know there is a way to update the nock mocks, but I don't remember exactly how ...
So, I think the tests failed because the mock doesn't exists, or doesn't match the mock .

I thought that might be the case.  I tried configuring the TEST_* environment variables defined in src/test.js, however that didn't work.  I'm not certain if it excepted my UDM to be configured in a certain way.  I've also tried running the npm "generate" scripts but that didn't help either.
I'll keep playing with it but at this point, I'm at a loss as far as getting the other tests passing.  I'll move this PR out of draft, and if there's anything else you need, please let me know.
Kyle

@KyleBrandon Can you try to write only unit tests ? ( pretty sure you can run them ... or by passing a path to jest ) .
I didn't know when I can generate the datas (lot of work now) ...

Yes, I'll get those in and resubmit.
Kyle


Bump to latest version of Phaser

update-08082021.md
Here's the updated MD file with the change in version - thankfully that's the only change!


Proxy tunnel forward hook

New tunnel_forward hooking mechanism allowing modules to handle Upgrade(d) protocols data.

Merged in r1893603 (3d2842e915d26a226a1524db8a718c9c9e2a57bc).


Infinite loop when rest framework authentication

When use axes with rest framework, using basic authentication. app crash with "maximum recursion depth exceeded while calling a Python object".
here is the debug report
response_1544513443445.txt
from
File "/usr/local/lib/python3.6/site-packages/rest_framework/views.py" in initial
  400.         self.perform_authentication(request)

File "/usr/local/lib/python3.6/site-packages/rest_framework/views.py" in perform_authentication
  326.         request.user

to
File "/usr/local/lib/python3.6/site-packages/axes/attempts.py" in is_user_lockable
  159.     if hasattr(request.user, 'nolockout'):

pip info
1.txt

@rayer4u What version of DRF are you using and are what method of  authentication? There is a case where the request DRF passed to authenticate() is actually DRF's Request() class which itself calls authenicate and not WSGIRequest causing an infinite loop. If this is the case you have I know a workaround but the bigger fix involves a bigger change to axes to not rely on request.

Thanks for reply. I use djangorestframework=3.90, django-axes=4.43, base authentication. I follow the code, DRF now use request wrapper and override request.user as you say. Maybe writing a auth backend is different between DRF and django. @@

Here is a workaround I've been using:
https://gist.github.com/markddavidoff/4156b8072e587b77e639269fbfac3b0f

I think this is a bug in DRF that needs to be fixed but would also be fixed if we stopped relying on request. There is a workaround, but I'd like to keep the issue open for visibility.


Tests/stocklocation and partcategory

This PR adds the missed tests from #3451.
@SchrodingersGat Sorry, I didn't thought you're already awake, as you normally act like 3am to my time (UTC+2 or CEST).

@luwol03 CEST is a good timezone to be in 😉


Update vert.x dependency.

In module vertxtgbot update version dependency.

Upgrade version vertx and delete WebHook bot.


airbyte_connection missing Transformation block

cloud airbyte Connection UI has a Transformation tab with these options:

Raw data (JSON)
Normalized tabular data

There is not way to change transformation in airbyte_connection terraform resource

Any updates?

hello, any update on that issue? the provider is pretty useless without this setting

hello, any update on that issue? the provider is pretty useless without this setting

Also the fact that you can't configure which fields get imported and which don't also made me drop the provider.
Quite misleading that the official tutorials for Airbyte tell you to use the provider instead of the now-unmaintained (?) octavia-cli, yet there're several unimplemented features:

Note: This tutorial leverages Octavia CLI, which is an alpha unofficial CLI that won't be maintained. Since the publication of this tutorial, Airbyte has released an official Terraform Provider, which we would advise to use instead of the CLI.


Allow users to change the name of an app via UI

Is your feature request related to a problem? Please describe.
Currently once an app name is set, there doesn't seem to be a way to change it.
Describe the solution you'd like
Adding an edit icon on the app management page that allows users to change the app name and save it.

Describe alternatives you've considered
I don't have any other solutions but I'm open to suggestions.

I'll like to jump on this when the endpoint is ready

I would like to work on this endpoint in case, it's not already picked up.

I would like to work on this, in case it's not already picked up by anyone. :smile:

Done


Fixes #446, enable usage of pg_search with multithreaded servers like puma

This reverts commit 7ff41966026d990db95cda8ad4414f33264e734d.
Fixes #446. Users were reporting problems after this PR using multithreaded servers like puma. I decided to revert the whole commit because except for the trailing whitespace that was removed, all that rubocop-thread_safety would achieve is that we'd have to add ignore comments.
Sadly I was unable to write a failing test for this in our own system, even with system tests that use puma as their webserver. I'd have to check if puma settings are somehow different in development and test and in which way. Others have also reported that this was the case
For reproduction steps to reproduce the error with even simple setups, see https://github.com/Casecommons/pg_search/issues/446#issuecomment-701550610.
All credit goes to the people in #446 however, especially @connorshea who found the commit that needed to be reverted.

Should a patch be releases?


Inline code blocks

There doesn't seems to be any configuration done for inline code blocks either on highlighting or fonts.

Hi,
Take a look at this post: https://sylhare.github.io/Type-on-Strap/2014/08/08/Markup-Syntax-Highlighting.html
And here is the markdown version, so you can start testing the highlighting: https://github.com/Sylhare/Type-on-Strap/blob/master/_posts/2014-08-08-Markup- Syntax Highlighting.md
If you would like something more, I would be interested to have a visual example of what it could be ;)
Thanks


'cout' output multiplied with multiple clicks of 'Run'.

Problem Description
This might be related to https://github.com/spyder-ide/spyder/issues/9759
I sent an email to the list, but nobody had any insights there:  https://groups.google.com/g/spyderlib/c/2BUb4dVGpaM/m/3ATuq_9oAwAJ
Basically, the problem is that our library will send warning messages to cout via the poco library.  In a console, we get the same behavior whether typing in the Spyder console, in a Jupyter console, or just running 'python' from the command line.  Namely:  the first time we run something that reports a warning, we see it, and after that we don't see anything.
But when we hit 'Run', we see it the first time, and then the next time, we see two copies of it, then three, etc.
What steps reproduce the problem?
pip install tellurium
Create the following program:
import tellurium as te
te.loada("species a")
Hit 'Run'
Hit 'Run'
Hit 'Run'
What is the expected output? What do you see instead?
Expected output:  The first 'Run':
Warning: species 'a' has neither initial amount nor concentration set.  Setting initial concentration to 0.0

Subsequent 'Run's should either produce that one line again or nothing at all--nothing at all is what we see when typing the program in at the prompts directly.
Observed output:
The expected output on the first 'Run', but by the third 'Run':
Warning: species 'a' has neither initial amount nor concentration set.  Setting initial concentration to 0.0
Warning: species 'a' has neither initial amount nor concentration set.  Setting initial concentration to 0.0
Warning: species 'a' has neither initial amount nor concentration set.  Setting initial concentration to 0.0

For what it's worth, I see the next prompt (i.e. 'In [3]') before the warnings are added above the prompt.
 So we should:

Do the same with cout, because something could be written there
Fix this issue by only printing the new lines, not the entire file

Oh, that sounds promising.  I should say that I could be wrong about what Poco pipes these messages to--it could already be cerr.  If the whole cerr file is being printed every time, that would certainly explain the phenomenon I'm seeing.  Thank you!

(If the only point of the cerr/cout file is to display to the user, you could always delete it after displaying it.  Is there anyone who needs 'all the cerr output' for something if it's been printed to the screen already?)


Typing indicator

It would be really handy to see when the other party is typing.
As the site owner, it might also be nice to see what the user is typing so that I can provide a faster reply.

I've seen this implemented in two ways

Temporary chat bubble with typing animation (Messenger, Intercom)
Static "Daniel is typing" text (Slack, Whatsapp)

I prefer the aesthetics of 2. because the transition between the typing indicator and the new message never looks good, especially when the user sends a message and keeps typing.
2 is also much easier to implement.

2 sounds good! just need to figure out the best place to put it -- maybe right above the message input area? 🤔

Slack puts theirs under the input area, but you don't have any space there right now.
Precursor puts it on the line that separates the chat box and I think it works pretty well:

nice! yup i think that would work :)


Create readme with Minimal Examples

Add a brief description with some examples added to the top level of this repo, and if we can pull any of the tests out and add them in here for a short term example set that would be fantastic.

[ ] header image/gif
[ ] badges
[ ] description of project

@jordan-pieces I have worked on this but the changes are part of my last PR, so once you merge it, you will the changes. Please take a look at the README and let me what I need to add if needed.

@Sophyia7 connected the two here 👍


Can we return our own response?

Is there a way to return or set a response? I'm specifically looking at passing along a DurableObject's response.
router.get('/do', ({ request, response, env }) => {
  const id = env.DURABLE_OBJECT.newUniqueId();
  // return, or use response.? or something else?
  return env.DURABLE_OBJECT.get(id).fetch(request.url);
});

Found it.
https://github.com/SunderJS/sunder/blob/43ac956781c2bd51f80404ffbd9376ddaf8342be/lib/util/response.ts#L116


Blog posts points to invalid release notes

Visit blog posts using any web browser at: http://www.opengee.org/blog.html
Click on any of the release posts (ex. http://www.opengee.org/2019/08/05/531-release.html for 5.3.1). At bottom of the post there is a url for release notes. Click on it
--> Result: 404 error (page not found)
--> Expected behavior: release notes html page should be displayed with it's correct content

Closed via PR #1466


ADT - Azure Digital Twin Icon Outdated

The icon for the Azure Digital Twin (ADT) is not up to date!
IS:

SHOULD:

In my code for the diagram I used this code snipped to include the icon
!define AzurePuml https://raw.githubusercontent.com/plantuml-stdlib/Azure-PlantUML/master/dist/
!includeurl AzurePuml/AzureCommon.puml
!includeurl AzurePuml/InternetOfThings/AzureDigitalTwins.puml

Would be super cool if you update the Azure Icons!

@tux2323 Thank you for bringing this to our attention! I've taken the liberty of moving this issue from C4-PlantUML to Azure-PlantUML, as this is where this will need to be addressed.
Activity on this repo is low so, to manage expectation, do not expect it to be resolved soon. That said, activity is expected to pick up soon-ish, so this should be resolved eventuallly.

Closed in favor of #29


Annotated arrow function with optional breaks highlighting of keywords

The highlighter seems to not work after an arrow function is annotated with an optional return type. In the attached screenshot, you can see that const/let/return in the same scope as the arrow function are highlighted incorrectly.

VSCode Version:  Version 1.10.2
OS Version: Ubuntu 16.10

Steps to reproduce:
/* @flow */
(function () {
    const b = (): ?Number => {
        const c = 1;
        return c;
    };
    const a = 1;
    let inner = b;
    return function () { return b; };
})();

Another case that triggers similar behaviour is annotated static properties:
// @flow
class Foo {
	static prop: Object = {

	}
	method() {
		const a= 3;
	}
}

const fn = () => {
	let a = 1;
};

I'm unable to reproduce this. Do you have any grammar extensions installed that could be causing this? Does it reproduce if you run VSCode with --disable-extensions?

Thanks, I forgot to check that. It turns out to be an issue with vscode-babel, I've reported there.


DFI Wallet is blocked / does not execute transactions

Actual behavior:
Expected behavior:
How to reproduce it (as minimally and precisely as possible):

What are your environment parameters?

DeFi Wallet Version:
Operating System (OS):
– Current free storage capacity:

Anything else we need to know?

defichainlogs.zip
these are the logfiles


Pc/sacred integration

@Blaizzy Could you add a screenshot of neptune dashboard that showcases what was logged (as we discussed with fastai)?

@Blaizzy you haven't addressed some comments (neptune_run vs run).
There is no screenshot of that dashboard you are linking to.
Remember that some people will not run it, just take a look at what will they get from it first.
Also, I think that instead of linking to the single Run UI home page, which is not super appealing, we could create a dashboard (custom dashboard) that shows that different metadata in one place (learning curves, hardware, parameters) so that people immediately see the value of it.

Thank you for pointing out but I took all the comments into account from the start, just had to move back and forth between:

Docs
Neptune UI
and PR comments

Both fastai and sacred. I decided to fix fastai first.
And in regards to sacred, I gave priority to the docs first and the PR would come as last.
Issues raised:

Dashboard and link -> DONE
run vs neptune_run -> Not possible as sacred has run too so it will overload our neptune run..
Unfreeze neptune versiom -> DONE


Kliment Kostadinov | Week 4 | Task15

1MI0600502

The code is working but try to separate the logic into functions like: calcLen, countDigitOccurances. This would make it more readable and easy to reuse.


can't scroll the labeller page if bio is too long

Describe the bug
This seems to be the same bug that was fixed on user profiles, but I guess this is a different view?
To Reproduce
Steps to reproduce the behavior:

Open https://bsky.app/profile/yardcrow.com in the iOS app
Try to scroll the page

Expected behavior
It should scroll if I grab somewhere in the bio area
Screenshots
I can't scroll down literally anywhere on this screen:

Details

Platform: iOS 17
App version: 1.82.0
Device: iPhone SE 3

Same issue.
Details

Platform: iOS 16.7.7
App version: <IP_ADDRESS> (prod)
Device: iPhone 8 Plus

Thanks I'll fix this soon.


[Bug]: Failed to modify view structure before executing new view

ODC version
odc433
OB version

What happened?

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?
Check multiple tables when creating a view, modify the view structure, and execute
Anything else we need to know?
No response

Fixed In Commit 6898939a34e04c5ab70575388768e92eaee535bf
------
畅晚
Wed Dec 18 18:18:35 2024 +0800

pass


[docs] HOOK codesandbox edit broken

https://material-ui.com/demos/cards/#complex-interaction

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Complex interaction demo should work
Current Behavior 😯
It's broken.
Steps to Reproduce 🕹
https://codesandbox.io/s/6jk2q6yppz

@Abbo44 Thank you for reporting the problem. The variable used is not correct:
https://github.com/mui-org/material-ui/blob/ba4332d00a5f951cfc33dcffa5924cc7999b8f05/docs/src/modules/utils/getDemoConfig.js#L80
It's a recent regression, introduced with the TypeScript demo support. I would propose the following fix:
--- a/docs/src/modules/utils/getDemoConfig.js
+++ b/docs/src/modules/utils/getDemoConfig.js
@@ -19,24 +19,24 @@ ReactDOM.render(<Demo />, document.querySelector('#root'));

 function hooksDemo(demoData) {
   return {
-    dependencies: getDependencies(demoData.rawHooks, { reactVersion: 'next' }),
+    dependencies: getDependencies(demoData.raw),
     files: {
       'index.js': `
-      import React from 'react';
-      import ReactDOM from 'react-dom';
-      import Demo from './demo';
-      import { createMuiTheme } from "@material-ui/core/styles";
-      import { ThemeProvider } from "@material-ui/styles";
-
-      const theme = createMuiTheme({ typography: { useNextVariants: true } });
-
-      ReactDOM.render(
-        <ThemeProvider theme={theme}>
-          <Demo />
-        </ThemeProvider>,
-        document.querySelector("#root")
-      );
-          `,
+import React from 'react';
+import ReactDOM from 'react-dom';
+import Demo from './demo';
+import { createMuiTheme } from "@material-ui/core/styles";
+import { ThemeProvider } from "@material-ui/styles";
+
+const theme = createMuiTheme({ typography: { useNextVariants: true } });
+
+ReactDOM.render(
+  <ThemeProvider theme={theme}>
+    <Demo />
+  </ThemeProvider>,
+  document.querySelector("#root")
+);
+    `,
       'demo.js': demoData.raw,
     },
   };
@@ -44,7 +44,7 @@ function hooksDemo(demoData) {

 function tsDemo(demoData) {
   return {
-    dependencies: getDependencies(demoData.raw, { codeLanguage: 'TS' }),
+    dependencies: getDependencies(demoData.raw, { codeLanguage: CODE_VARIANTS.TS }),
     files: {
       'demo.tsx': demoData.raw,
       'index.tsx': `
@@ -77,10 +77,12 @@ function getLanguageConfig(demoData) {
   switch (demoData.codeVariant) {
     case CODE_VARIANTS.TS:
       return tsDemo(demoData);
-    case CODE_VARIANTS.HOOKS:
+    case CODE_VARIANTS.HOOK:
       return hooksDemo(demoData);
-    default:
+    case CODE_VARIANTS.JS:
       return jsDemo(demoData);
+    default:
+      throw new Error(`Unsupported codeVariant: ${demoData.codeVariant}`);
   }
 }

diff --git a/docs/src/modules/utils/helpers.js b/docs/src/modules/utils/helpers.js
index 254cf8f3c..241e4ff06 100644
--- a/docs/src/modules/utils/helpers.js
+++ b/docs/src/modules/utils/helpers.js
@@ -1,6 +1,7 @@
 import warning from 'warning';
 import upperFirst from 'lodash/upperFirst';
 import camelCase from 'lodash/camelCase';
+import { CODE_VARIANTS } from 'docs/src/modules/constants';

 export function titleize(string) {
   warning(
@@ -72,7 +73,7 @@ function addTypeDeps(deps) {
  * @returns {Record<string, 'latest'>} map of packages with their required version
  */
 export function getDependencies(raw, options = {}) {
-  const { codeLanguage = 'JS', reactVersion = 'latest' } = options;
+  const { codeLanguage = CODE_VARIANTS.JS, reactVersion = 'latest' } = options;
   const deps = {
     'react-dom': reactVersion,
     react: reactVersion,
@@ -99,7 +100,7 @@ export function getDependencies(raw, options = {}) {
     }
   }

-  if (codeLanguage === 'TS') {
+  if (codeLanguage === CODE_VARIANTS.TS) {
     addTypeDeps(deps);
   }

Do you want to work on the problem? :)

https://codesandbox.io/s/0ymml7420l

Do you want to work on the problem? :)

Ok I'm on it !

@Abbo44 Did you find some time? :)

-const { codeLanguage = 'JS', reactVersion = 'latest' } = options;
+const { codeLanguage = CODE_VARIANTS.JS, reactVersion = 'latest' } = options;

That reminds me - what's the purpose of this? It seems like an unnecessary abstraction. We're looking up the value 'JS' in an imported object using the key 'JS' . If we already know it's 'JS' that we want, we don't need to look it up. 😆
If it's more than once in an iterator, the global could simply be an array.

I like creating constants, it's easier to grep, so it's easier to change. But it's a personnal preference.

And what might you change 'CODE_VARIANTS.JS' to? 😆
I think we need a new eslint rule: no-unnecessary-globals 😜

@Abbo44 Did you find some time? :)

I make a PR this week-end, very busy this week


import error

import error
libtorch_cuda.so:%20undefined%20symbol:%20ncclCommRegister
please suggest

Check that the ExLlamaV2 version you have installed matches your Torch version.


Send receipt transaction

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3294   👈

This comment was auto-generated by Graphite.


Is this still in active development?

TL;DR: I want to help, is this still in active development?
I'm by no means a Rust expert or have ever messed with lunar magic, but I do have a lot of programming knowledge and passing experience in Rust. I'd like to contribute to the project if possible, but it seems from the commits on main that there hasn't been any updates in over a year.

It kind of is. Most of the effort has mostly been spent on the assembly code so far, and I'm kind of in need of someone to help me get the UI portion going.
If you have any experience in UI design, it will be very appreciated.

Sorry, I have absolutely no idea of UI design. Or of assembly. The only way I could help would be with Rust.
Actually I do know a friend who is a UX designer by trade... I assume this would be free labor right? I could ask her if she's interested, but it sounds like a lot of work, I wouldn't keep my hopes up.

I'd be happy to help in terms of UI design!


Manual optimization strategy does not have new_vms_tmpls_and_flavor

I, [2015-01-08T12:45:12.947823 #26651]  INFO -- :   Parameters: {"appliance"=>{"configuration_template_id"=>"214", "appliance_set_id"=>"536", "params"=>{}, "name"=>nil, "user_key_id"=>"39", "dev_mode_property_set"=>{"preference_cpu"=>"0", "preference_memory"=>"0", "preference_disk"=>"0"}, "compute_site_ids"=>nil}}
I, [2015-01-08T12:45:13.040284 #26651]  INFO -- : Completed 500 Internal Server Error in 92ms
F, [2015-01-08T12:45:13.897698 #26651] FATAL -- :
NoMethodError (undefined method `[]' for nil:NilClass):
  vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-3dee9558043d/app/providers/atmosphere/optimization_strategy/manual.rb:21:in `new_vms_tmpls_and_flavors'

It it even worse - manual optimization policy assume that there are optimization_policy_params available in appliance
@tbartynski can you explain why it was implemented in such a way and how we can use manual policy to start new appliance (not given in start new appliance_set request).
/cc @bwilk

@tbartynski any deadline for this issue? It is quite important for ISMOP, what is more it blocks https://redmine.dev.cyfronet.pl/issues/3328

@tbartynski any news here?

This issue seems outdated. This code is already in master. See
https://github.com/dice-cyfronet/atmosphere/blob/master/app/providers/atmosphere/optimization_strategy/manual.rb#L18
@mkasztelnik, @nowakowski please confirm it.

It is not outdated. The scenario is as follow:
create new appliance set with e.g. type development and optimization policy set to true, next try to create new appliance with following params:
{
  "appliance":  {
    "configuration_template_id": "REAL_ID",
    "appliance_set_id": "REAL_ID",
    "params": {},
    "name": nil,
    "user_key_id": "REAL_ID",
    "dev_mode_property_set": {
      "preference_cpu": 0,
      "preference_memory": 0,
      "preference_disk": 0
    }
  }
}

The issue described in the issue description occurs.

Closed via #246


The install.sh script can hang when installing packages from apt

Hello hello!!
The install.sh script can hang during the install_apt() function when apt-get expects user interaction, even though the -y argument is provided.
To reproduce, execute the install.sh script in a fresh docker image of Ubuntu 20.04. The script will hang when installing tzdata, a dependency of chromium-browser.
Thanks! 🙌

Thanks for the issue and the PR! Already merged on dev https://github.com/six2dez/reconftw/pull/292/commits/eadfcb86ee6c4d3a607cd82429eed151e28c3ebb


[BUG]: quick_start.py  does not work

Describe the bug
I have downloaded the source code of current OS-Copilot, and when I ran the command python quick_start.py, I got some info about how to execute the steps but there's no agents file generated. Here is an output example:
Task:
Your task is: Copy any text file located in the `working_dir/document` directory that contains the word 'agent' to a new folder named 'agents'
Operating System Version: Ubuntu 22.04.3 LTS
**Subtask 1:** Copy any text file located in the `working_dir/document` directory that contains the word 'agent' to a new folder named 'agents'

**Step 1:** Create a new folder named 'agents' inside the current working directory `/home/lunyu/github/OS-Copilot/working_dir`

```bash
mkdir agents
```

**Step 2:** Navigate into the `document` directory and search for any text file that contains the word 'agent'

```bash
cd document
find . -type f -name "*.txt" | xargs grep -i "agent"
```

This command will list all text files (`*.txt`) in the current directory and its subdirectories, then pipe the output to `grep` with the `-i` flag (case-insensitive) to search for the word 'agent' within each file.

**Step 3:** Copy the identified text files from Step 2 into the newly created 'agents' folder

```bash
cp -v $(find . -type f -name "*.txt" | xargs grep -i "agent") /home/lunyu/github/OS-Copilot/working_dir/agents/
```

The `cp` command with `-v` flag will print the name of each file before copying it, ensuring that we're aware of what's being copied.

**Output:**

 Files copied successfully into the 'agents' folder:

* `document/file1.txt`
* `document/file2.txt`

Note: The actual files and their contents are not provided here as they depend on your specific directory structure and file names.
No JSON data found in the string.

I tried many times but this mission still didn't work. Every time I found No JSON data found in the string. at the end of these output texts.
Is this a normal result, or No JSON data found in the string. is an error tip.
To Reproduce Errors
The main altering is in step 3.

Clone the GitHub Repository:
git clone https://github.com/OS-Copilot/OS-Copilot.git

Set Up Python Environment and Install Dependencies:
conda create -n oscopilot_env python=3.10 -y
conda activate oscopilot_env

cd OS-Copilot
pip install -e .

Set OpenAI API Key: Configure your OpenAI API key in [.env](.env).
cp .env_template .env

Here I use ollama LLAMA3.1 local model :
#MODEL_NAME="gpt-3.5-turbo-0125"
#MODEL_TYPE="OpenAI" # if use the gpt series (OpenAI), lamma series (LLAMA)
#OPENAI_API_KEY=""
#OPENAI_ORGANIZATION=""
# API_BASE_URL="http://<IP_ADDRESS>:8079" # turn it on if using a VPN
# OPENAI_BASE_URL=""
# BING_SUBSCRIPTION_KEY=""
# BING_SEARCH_URL="https://api.bing.microsoft.com/v7.0/search"
# WOLFRAMALPHA_APP_ID=""

# LLAMA in local server
# open llama3 at local server
# curl -fsSL https://ollama.com/install.sh | sh
# ollama run llama3
# export NO_PROXY=localhost,<IP_ADDRESS>
 MODEL_NAME="llama3.1"
 MODEL_TYPE="OLLAMA"
 EMBED_MODEL_TYPE="OLLAMA"
 EMBED_MODEL_NAME="nomic-embed-text"
 MODEL_SERVER="http://localhost:11434" # only for local model

I also set NO_PROXY=localhost,<IP_ADDRESS> into .bashrc file and sourced the file.

Now you are ready to have fun:
python quick_start.py

Screenshots and Logs
Additional context
Add any other context about the problem here.

OS:
WSL2 Ubuntu 22.04.3 LTS

OS-Copilot
current source code.

Python Version
3.10.4

The llama3.1 model has limited ability to follow instructions, so I recommend using GPT-4o to achieve your goals. Alternatively, you could try modifying the prompt to output the desired format and extract the relevant content for FRIDAY to execute.

@heroding77 Yes. It works when I use GTP-4o. Thank you.


support Scala 2.13.0-M5

ping?

(@TomasMikula?)

Just released 0.9.8 with support for 2.13.0-M5.

thank you Erik!

scala/make-release-notes@c40f05940c7cd226a35b0e4f5749ba4e421ccdbc


Passing StepResults between Steps

This PR adds the capability for passing Step Results between Steps using $(steps.stepName.results.resultName...) like syntax.
Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Passing StepResults between Steps in a Task

/kind feature

/hold wait for some initial feedback on the approach before adding tests.

/hold cancel

Do we validate that steps.<stepName>.results.<resultName> can only be used in those (command, args, scripts and env) ?

Great catch. I don't think we validate that. We allow it in any field. The substitution would not be made there. Though I think that would result in silent errors. I can add the validation that it can only be used in the four fields. Thanks!

Do we validate that steps.<stepName>.results.<resultName> can only be used in those (command, args, scripts and env) ?

Great catch. I don't think we validate that. We allow it in any field. The substitution would not be made there. Though I think that would result in silent errors. I can add the validation that it can only be used in the four fields. Thanks!

Done! PTAL.

ping @wlynch @vdemeester whenever you have a chance. This is ready for review. I have removed the ability to perform step-result substitutions directly in steps. Users need to now go to it via env.

/lgtm