release: Automate the release process.

I would like to propose you to add 2 dev dependencies to automate the release process and ease respository changes communication.
These tools are:

commitizen : https://github.com/commitizen/cz-cli
semantic-release: https://github.com/semantic-release/semantic-release

Commitizen will ensure we are using convention whilre writing commit so that we can auto generate changelog later. more info https://www.conventionalcommits.org . It would be trivial to install it because you are already using husky hooks mechanism
semantic release helps deploying npm packages by automating multiples things.
By using it, we would be able to automate the release process if in addition we use Github Actions.
@semantice-release/changelog is a semantic-release plugin and can generate a changelog based on the commit history of a repository. This auto generated changelog would eases the changes communication
What do you think?

Yeah this sounds great! If you want to open a PR adding this, that'd be awesome!

I'm also setting up a CircleCI pipeline, definitely want to make everything automated.

#8 add commitlint

I have access to github actions beta, I think I can setup it here but I guess I need to be a collaborator ^^

For now I'm going to keep doing this manually - may automate it in the future if it makes sense. Thanks for the idea though!


Retrigger getRowClass on setSort/FilterModel

I'm using getRowClass() to add the class ag-row-child-last to the last child of a group. Works fine as long as no calls to api.setSortModel() or api.setFilterModel() are called. But if I call either one of those and the last child position changes, getRowClass() is never called again. This means the wrong row has the ag-row-child-last class added. This is easy enough to fix with api.refreshView(), but I was wondering if changing the sort or filter model should trigger getRowClass()
Or perhaps I can just use cellClassRules as indicated in #1264

it wouldn't work, as getRowClass adds classes only, it doesn't remove classes. so in your case, once the class is assigned, it is always assigned.
if you must do this, you could use processRowPostCreate and add the class yourself directly.
add a listener to the model (eg modelUpdated) and recheck things yourself. but if adding a listener for each row, you should remove the listeners as the rows are removed as follows:
params.addRenderedRowListener('renderedRowRemoved', function() {........cleanup here.....} )
so that you are not constantly adding listeners to rows


Crashes with new version

Do you use Java 8?
Yes
What version of Minecraft do you use?
1.12.2
What version of MinecraftForge do you use?
<IP_ADDRESS>54
What version of SanLib do you use?
1.6.2
What version of Turret Mod Rebirth do you use?
Beta 4.3
What is the issue/bug you have encountered? Give us a short description.
Crash when entering world previously made wolrd and crash when making a new one
How can it be reproduced?
No clue
Please post your log file (either in /logs/fml-client-latest.log or /logs/latest.log) on https://gist.github.com and provide the link:
crash with previously made world: https://gist.github.com/mxnmnm/1fa3ab7565775b597f94369351497bfd
crash with new world:https://gist.github.com/mxnmnm/2574bda32b4965cc1797d05fe7bdf834

Can you try the new Beta 4.4 and see if it works? If not, i'll just remove the ItemRemapper entirely.

So far it seems ok although seeing how the crash happened randomly I can't be 100% sure that it is fixed

Alright, I'll close this issue for now, then. If you encounter another crash, just reply and I'll reopen this again.

Yay more issues
https://gist.github.com/mxnmnm/edade188d25d3ad0a18e0dd024438448
https://gist.github.com/mxnmnm/e43e69b8108a14e5450c24213e159e02
https://gist.github.com/mxnmnm/d34bc0fd91be409ef0368bfbaa72c117

I have opened a new issue for you, as this is a different kind of crash than the previous one.


a typo fix on the surplus quotation mark

Brief description of the changes [REQUIRED]
a typo fix on the surplus quotation mark
What browsers and operating systems have you tested these changes on? [REQUIRED]
chrome on windows10
Are all automated tests passing? [REQUIRED]
no, manual tested.
Is this pull request against develop or some other non-master branch? [REQUIRED]
no

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: rnicholus:x: RayCLin

While you are targeting master, it appears that your branch is based off of develop. So, I adjusted the target branch to point to develop. I'll merge into develop and then cherry-pick your commit into master.
Thanks for catching and fixing these documentation errors. Much appreciated.


The backlight of the case of Asus Aura as on the video.

Hello. I wanted to know. I have an Asus Aura backlight in my computer case. I downloaded the latest version of the Aurora program, but I didn’t find how to enable Asus Aura support in it so that the backlight of the case works like a video. Tell me please.
https://www.youtube.com/watch?v=x-y0u19HmKI

The support is still experimental. You can use the version in development if you ask in the discord here.


Prints error message on scene load failure

Prints error messages properly
I confirm I have signed the Contributor License Agreement.

Hi,
Thanks for the PR. There was actually a very similar PR for the hierarchy resource handler a few days ago. Could you please have a look at src/resources/hierarchy.js and do the same for the error handling as that file? Or we can do it if you want. Thank you

I've take a look your changes,
It seems does not solve the problem.
Please check out my attachment, it's a very simple project which just throws something on iniaitlize method.
The error is still not visible.

errtest.zip

They have different behavior between editor and published project.
I can see the error message on the editor.
However, the stacktrace is totally mess. I can't recognize the error was thrown by test.js.

What I was saying was to change the scene handler to have the same error handler as the hierarchy handler.

Oh, got it.  I was still sleepy,
I've committed the changes. Please take a look.


Math.Random() only uses the max value

Describe your problem here.
I've been trying to code a little randomized event but when I try using math.random(min, max); it only gives me its max number
The codeline :
function onStepHit()
next_block = math.random(1, 3);
end
The value "next_block" only returns as whatever the max for math.random is, what am I doing wrong?
More information to help :
Psych Version : 0.6.2 (Modified only on the stuff listed in the "Did you edit anything in this build?" part)
I also tried changing it to getRandomInt(min, max) but that one had the same issue
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
healthloss by misses is higher, winning icons are a thing, and discord rich pressence is now themed on the mod.

Use getRandomInt(min, max)

Update, nvm I found a fix, just needed to add math.randomseed(os.time())
I'll just close the issue 👍


HADOOP-17191. ABFS: Run the tests with various combinations of configurations and publish a consolidated results

ADLS Gen 2 supports accounts with and without hierarchical namespace support. ABFS driver supports various authorization mechanisms like OAuth, haredKey, Shared Access Signature. The integration tests need to be executed against accounts with and without hierarchical namespace support using various authorization mechanisms.
Currently the developer has to manually run the tests with different combinations of configurations.
The expectation is to automate these runs with different combinations.
The PR introduces a shell script with which the developer can specify the configuration variants and get different combinations of tests executed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
33m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
16m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 14s

The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 29s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

103m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2417

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs markdownlint xml

uname
Linux 98e08ebb010d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae74407ac43

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/1/testReport/

Max. process+thread count
310 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
16m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 14s

The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 33s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

71m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2417

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs markdownlint xml

uname
Linux cc410d793fce 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8ee6bc2518b

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/2/testReport/

Max. process+thread count
359 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
shadedclient
16m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 15s

The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 30s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

74m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2417

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs markdownlint xml

uname
Linux f8583c3523b7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e580280a8b0

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/3/testReport/

Max. process+thread count
308 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/3/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
28m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
4m 37s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
mvnsite
2m 22s

trunk passed

+1 :green_heart:
shadedclient
17m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 16s

There were no new shelldocs issues.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 34s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

72m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2417

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs markdownlint xml

uname
Linux af63183c3787 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3067a25fa12

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/4/testReport/

Max. process+thread count
423 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/4/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
shadedclient
15m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 18s

The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 33s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

69m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2417

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs markdownlint xml

uname
Linux b742b1883cfc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7e52c0975f7

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/5/testReport/

Max. process+thread count
404 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2417/5/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


file-icons not dimming properly

file-icons icons of files are not dimming properly in distraction-free mode, they stay fully visible even though the file they are representing is not open.

I don't really see this happening. Is this still a problem (I see that it's almost a year old now)?

No it seems to be fixed, but the issue was not closed.


Unknown attribute log messages

Describe the bug
Got a lot of warning messages
Logs
2022-02-16 13:57:01 WARNING (SyncWorker_5) [weconnect] /vehicles/WVGZZZE2ZMP053387/domains/charging/chargingStatus: Unknown attribute chargeType with value invalid
2022-02-16 13:57:01 WARNING (SyncWorker_5) [weconnect] /vehicles/WVGZZZE2ZMP053387/domains/charging/chargingStatus: Unknown attribute chargingSettings with value default

Yes, VW extended the interface again. Will add this as soon as I understood what possible values there are.

Any idea when you can add these attributes? I've tried the beta/alpha version, the new attributes are added but other things stopped working.

In theory I can release 0.37.0 tonight. But what kind of thing stopped working? That would be a reason not to release.

Traceback (most recent call last):
  File "/workspaces/core/homeassistant/helpers/update_coordinator.py", line 187, in _async_refresh
    self.data = await self._async_update_data()
  File "/workspaces/core/homeassistant/helpers/update_coordinator.py", line 147, in _async_update_data
    return await self.update_method()
  File "/workspaces/core/homeassistant/components/volkswagen_we_connect_id/__init__.py", line 46, in async_update_data
    await hass.async_add_executor_job(_we_connect.update)
  File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.9/site-packages/weconnect/weconnect.py", line 175, in update
    self.updateVehicles(updateCapabilities=updateCapabilities, updatePictures=updatePictures, force=force, selective=selective)
  File "/usr/local/lib/python3.9/site-packages/weconnect/weconnect.py", line 198, in updateVehicles
    self.__vehicles[vin].update(fromDict=vehicleDict, updateCapabilities=updateCapabilities, updatePictures=updatePictures,
  File "/usr/local/lib/python3.9/site-packages/weconnect/elements/vehicle.py", line 197, in update
    self.updateStatus(updateCapabilities=updateCapabilities, force=force, selective=selective)
  File "/usr/local/lib/python3.9/site-packages/weconnect/elements/vehicle.py", line 288, in updateStatus
    self.domains[domain.value][key].update(fromDict=data[domain.value][key])
  File "/usr/local/lib/python3.9/site-packages/weconnect/elements/climatization_settings.py", line 75, in update
    self.targetTemperature_C.fromDict(fromDict['value'], 'targetTemperature_C')
AttributeError: 'float' object has no attribute 'fromDict'```

After setting the target temperature

hmmm, can you show the code where you set the temperature?

 try:
    vehicle.domains["climatisation"][
        "climatisationSettings"
    ].targetTemperature_C = target_temperature
    _LOGGER.info("Sended target temperature call to the car")
except Exception as exc:
    _LOGGER.error("Failed to send request to car - %s", exc)
    return False

you have to change
targetTemperature_C = target_temperature to
targetTemperature_C.value = target_temperature

Then i got
Failed to send request to car - 'type' object is not iterable

that is a bug!

You can try 0.37.0.dev5

That's a fast bugfix, will try it right now ;)

Hmm i don't think it sets the value right now

Can you see what the request status is? When I open the ID app I see an error message and when I try to set the value I get the request status Request: start operation, status polling_timeout  information: Your vehicle is not reachable at the moment. Please try again later. Request Id: e654a0b5-24b1-4907-b8d7-f3e080e6e5a7 after a while.

hmm yea i got issues with the app as well today. So maby Volkswagen is doing stuff again...

Maybe a good idea to delay the release to tomorrow and check if its works again :)

Yeah wil check tomorrow! Thanks for you time ;)

0.37.0 was just released


Error when trying to login: FUNCTION_INVOCATION_FAILED

🐞 Describe the bug
Trying to login to my account and this is displayed:
A server error has occurred

FUNCTION_INVOCATION_FAILED

Error: A server error has occurred

FUNCTION_INVOCATION_FAILED

    at Md (https://an.shortnim.me/index.js:83:13349)
    at async https://an.shortnim.me/index.js:83:13926

📚 To Reproduce
Deploy latest version to verce, wait a few days and this error showed
💡 Expected behavior
To login without any issue
⚙ Environment

Installation: Vercel
Ackee version: v3.0.6

Can you find anything in the Vercel serverless function logs?

I was going to check it but now it's working without touching anything. I'll close this issue and re-open again if it happens again and will be posting the serverless logs.
Thanks

Here we go again...
[POST] /api
19:13:47:48
2021-06-23T17:13:51.565Z	ba9ccd58-3aa6-4e62-a631-0b9d25ded96c	ERROR	Unhandled Promise Rejection 	{"errorType":"Runtime.UnhandledPromiseRejection","errorMessage":"MongoError: Authentication failed.","reason":{"errorType":"MongoError","errorMessage":"Authentication failed.","code":8000,"ok":0,"codeName":"AtlasError","name":"MongoError","stack":["MongoError: Authentication failed.","    at MessageStream.messageHandler (/var/task/node_modules/mongodb/lib/cmap/connection.js:268:20)","    at MessageStream.emit (events.js:376:20)","    at processIncomingData (/var/task/node_modules/mongodb/lib/cmap/message_stream.js:144:12)","    at MessageStream._write (/var/task/node_modules/mongodb/lib/cmap/message_stream.js:42:5)","    at writeOrBuffer (internal/streams/writable.js:358:12)","    at MessageStream.Writable.write (internal/streams/writable.js:303:10)","    at TLSSocket.ondata (internal/streams/readable.js:745:22)","    at TLSSocket.emit (events.js:376:20)","    at addChunk (internal/streams/readable.js:309:12)","    at readableAddChunk (internal/streams/readable.js:284:9)","    at TLSSocket.Readable.push (internal/streams/readable.js:223:10)","    at TLSWrap.onStreamRead (internal/stream_base_commons.js:188:23)"]},"promise":{},"stack":["Runtime.UnhandledPromiseRejection: MongoError: Authentication failed.","    at process.<anonymous> (/var/runtime/index.js:35:15)","    at process.emit (events.js:376:20)","    at processPromiseRejections (internal/process/promises.js:245:33)","    at processTicksAndRejections (internal/process/task_queues.js:96:32)"]}
Unknown application error occurred

I'm using MongoDB Atlas and I have been using it for a long time for other apps, and this is the first time I see this error :/

Hmm, hard to say if this is a problem of Ackee or MongoDB Atlas. I've never had this error on my installation and Ackee shouldn't have any problems to connect to a MongoDB. Does it happen all the time or just sometimes? Is there a connection limit or something when using MongoDB Atlas?

There was no problem with connection limit or anything at Atlas side.
I redeployed it manually instead of using the Deploy to Vercel button, also changed the MongoDB password to something without especial characters, I think this could be the problem but it was only happening sometimes so I have no idea why.
So far it's been working flawlessly, closing this issue until it happens again.

Having the same issue.
Should I open a new ticket?
It's a vanilla setup. Nothing has been touched. I just followed the guide.
A server error has occurred

FUNCTION_INVOCATION_FAILED

Error: A server error has occurred

FUNCTION_INVOCATION_FAILED

    at Md (https://ackee-roan.vercel.app/index.js:83:13349)
    at async https://ackee-roan.vercel.app/index.js:83:13926

[POST] /api
17:12:42:38
2021-07-24T15:12:42.450Z	7dd9dca6-c2dd-4959-9316-8d865e8a3e83	ERROR	Unhandled Promise Rejection 	{"errorType":"Runtime.UnhandledPromiseRejection","errorMessage":"MongooseServerSelectionError: connect ECONNREFUSED <IP_ADDRESS>:27017","reason":{"errorType":"MongooseServerSelectionError","errorMessage":"connect ECONNREFUSED <IP_ADDRESS>:27017","message":"connect ECONNREFUSED <IP_ADDRESS>:27017","reason":{"type":"Single","setName":null,"maxSetVersion":null,"maxElectionId":null,"servers":{},"stale":false,"compatible":true,"compatibilityError":null,"logicalSessionTimeoutMinutes":null,"heartbeatFrequencyMS":10000,"localThresholdMS":15,"commonWireVersion":null},"stack":["MongooseServerSelectionError: connect ECONNREFUSED <IP_ADDRESS>:27017","    at NativeConnection.Connection.openUri (/var/task/node_modules/mongoose/lib/connection.js:839:32)","    at /var/task/node_modules/mongoose/lib/index.js:348:10","    at /var/task/node_modules/mongoose/lib/helpers/promiseOrCallback.js:31:5","    at new Promise (<anonymous>)","    at promiseOrCallback (/var/task/node_modules/mongoose/lib/helpers/promiseOrCallback.js:30:10)","    at Mongoose._promiseOrCallback (/var/task/node_modules/mongoose/lib/index.js:1149:10)","    at Mongoose.connect (/var/task/node_modules/mongoose/lib/index.js:347:20)","    at module.exports (/var/task/src/utils/connect.js:5:38)","    at Object.<anonymous> (/var/task/src/serverless.js:14:1)","    at Module._compile (internal/modules/cjs/loader.js:1085:14)","    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)","    at Module.load (internal/modules/cjs/loader.js:950:32)","    at Function.Module._load (internal/modules/cjs/loader.js:790:14)","    at Module.require (internal/modules/cjs/loader.js:974:19)","    at require (internal/modules/cjs/helpers.js:92:18)","    at Object.<anonymous> (/var/task/api/index.js:12:19)"]},"promise":{},"stack":["Runtime.UnhandledPromiseRejection: MongooseServerSelectionError: connect ECONNREFUSED <IP_ADDRESS>:27017","    at process.<anonymous> (/var/runtime/index.js:35:15)","    at process.emit (events.js:375:28)","    at processPromiseRejections (internal/process/promises.js:245:33)","    at processTicksAndRejections (internal/process/task_queues.js:96:32)","    at runNextTicks (internal/process/task_queues.js:64:3)","    at processTimers (internal/timers.js:497:9)"]}
[ERROR] [1627139562452] LAMBDA_RUNTIME Failed to post handler success response. Http response code: 400.
RequestId: 24c3d488-330b-494f-93a5-620ff1f85fba Error: Runtime exited with error: exit status 128
Runtime.ExitError

@pixelass Thanks for letting me know. I'm not sure why this happens. I would like to help, but Vercel sometimes fails to run the function for no obvious reason. The function itself is fine and run in all my tests.


How to  manually add the paths to the folders containing these files in your environment's variables.

I am a novice in using the ubuntu operating system, I do not know how to use the "setenv" command, and
What are the parameters of the "setenv" command?
Thanks.

Excuse me for the brevity, but I can't explain this in detail here.
Using setenv you ll need to add the paths to the necessary cuda folders and files, as commenting in the documentation.
Try to google: "unix setenv command", "unix environment variables" and cuda-related information to find what exactly you ll need to add to your path and how.
You should google this info regardless the use of deepmedic, you should learn how to set-up your unix environment. This is basic and super-important stuff.
K


Avoid references to released bytes when taking a snapshot of an encoder

cc @kobolog @xichen2020
This is to avoid the known case of Stream() taking a reference to a bytes slice that is returned to the pool from ostream.go when appending bytes with pool.AppendByte(..., bytesPool).
In the future we can build a dependency graph here using contexts to avoid copying, for now this will workaround the current free after use issues.

Coverage decreased (-0.1%) to 77.226% when pulling 41c1ccdfe4ba2e6ae8d84152d7b38e7994c31e7e on copy-on-stream into 0ef731e3e2b9459f5ae422603ea10ae8104e3ec8 on master.


Issue with chimera_layout mistaking single tile for multiple tiles.

Description
The chimera_layout function uses the networkx function diameter, which can be > 2 for some configurations of our chimera graphs.
To Reproduce
The example on the demo page is working:
https://docs.ocean.dwavesys.com/projects/dwave-networkx/en/latest/reference/drawing.html
However the following modification will cause an error in which the code mistakes the connected graph for being from two connected tiles:
`import networkx as nx
import dwave_networkx as dnx
import matplotlib.pyplot as plt
H = nx.Graph()
H.add_nodes_from([0, 1, 4, 5, 6, 7])
H.add_edges_from([(0, 4), (0, 5), (0, 6), (0, 7)])
H.add_edges_from([(1, 4)])
pos = dnx.chimera_layout(H)
G = dnx.chimera_graph(1,1,4)
ind = dnx.find_chimera_indices(G)
dnx.draw_chimera(G)
dnx.draw_chimera(H, node_color='b', node_shape='*', style='dashed', edge_color='b', width=3)
dnx.chimera_layout(H, scale=1., center=None, dim=2)
plt.show()`
There are a few similar issues, so it might be a good idea to check a few different cases.
This one draws as if 2 is 1.
H.add_nodes_from([0, 2, 4, 5, 6, 7]) H.add_edges_from([(0, 4), (0, 5), (0, 6), (0, 7)]) H.add_edges_from([(2, 4), (2, 5), (2, 6), (2, 7)])
Expected behavior
Partial chimera graphs should draw correctly.
The first example should draw an extra dashed line from node 1 to node 4.
The second example should produce a chimera graph tile with the 0 node and the 2 node fully connected.
Environment:

OS: Windows 10 Pro
Python version: 3.7.1

Additional context
This issue showed up from a user trying to run the example in drawing chimera graph functions:
https://github.com/dwavesystems/dwave_networkx/issues/90

I think this and #90 are non-issues.
I found these while trying to do something similar, i.e. create a chimera graph by adding custom nodes and edges.
But I don't expect it to work in the way that is exemplified here because (1) the H graph isn't created as a chimera_graph to begin with. (2) even if it is, adding nodes would need to be done in a way that modifies the corresponding graph dictionary, or invalidates it.
So... either nothing is done, or there needs to be ~a Chimera graph class~ (Not the way NetworkX is supposed to be used) or interfaces to incrementally construct Chimera/Pegasus graphs e.g. dnx.add_chimera_nodes_from(H, <nodes>) dnx.add_chimera_edges_from(H, <edges>) dnx.add_pegasus_...
Or... a way to "Chimerify" (?) or "Pegasify" (?) graphs.

The way I would do it right now is:
node_list = [0, 1, 4, 5, 6, 7]
edge_list = [(0, 4), (0, 5), (0, 6), (0, 7), (1, 4)]
H = dnx.chimera_graph(1,1,node_list=node_list,edge_list=edge_list)
...
dnx.draw_chimera(H, node_color='b', node_shape='*', style='dashed', edge_color='b', width=3)


NaN values and Scikit-Learn RFECV

I couldn't find the issue associated with this XGBoost forum topic, so I assume none was created. I can confirm this problem persists with the latest nightly of xgboost (a38e7bd19c461e0bed7bd96ec72d56132157d4af) and scikit-learn (018c6dc57d21c89c7d1278c686c7d5d62f32ee48).
I agree with Mike Creeth's statement in the previously mentioned forum post:

I believe this is because RFECV does some checking based on the tags that it gets from the estimator. It uses the tag ‘allow_nan’ to determine whether or not to check X for NaN values. It seems that currently XGBoost simply inherits the default “allow_nan” tag value from the scikit-learn estimator class, which is False. As XGB does in fact handle null values in X, I believe this behavior is incorrect.

from xgboost import XGBClassifier
from sklearn.feature_selection import RFECV

estimator = XGBClassifier()
selector = RFECV(estimator, cv=3)
selector = selector.fit(X, y)

with X having one or more np.nan values, raises the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-35-6d04ec0892c9> in <module>
     18
     19 selector = RFECV(model, cv=3)#, scoring=neg_rmse)
---> 20 selector = selector.fit(X_train.values, y_train.values)

/local/burghbvander/miniconda3/envs/fastai/lib/python3.7/site-packages/sklearn/feature_selection/_rfe.py in fit(self, X, y, groups)
    498             X, y, accept_sparse="csr", ensure_min_features=2,
    499             force_all_finite=not tags.get('allow_nan', True),
--> 500             multi_output=True
    501         )
    502

/local/burghbvander/miniconda3/envs/fastai/lib/python3.7/site-packages/sklearn/base.py in _validate_data(self, X, y, reset, **check_params)
    404             out = X
    405         else:
--> 406             X, y = check_X_y(X, y, **check_params)
    407             out = X, y
    408

/local/burghbvander/miniconda3/envs/fastai/lib/python3.7/site-packages/sklearn/utils/validation.py in check_X_y(X, y, accept_sparse, accept_large_sparse, dtype, order, copy, force_all_finite, ensure_2d, allow_nd, multi_output, ensure_min_samples, ensure_min_features, y_numeric, estimator)
    724                     ensure_min_samples=ensure_min_samples,
    725                     ensure_min_features=ensure_min_features,
--> 726                     estimator=estimator)
    727     if multi_output:
    728         y = check_array(y, 'csr', force_all_finite=True, ensure_2d=False,

/local/burghbvander/miniconda3/envs/fastai/lib/python3.7/site-packages/sklearn/utils/validation.py in check_array(array, accept_sparse, accept_large_sparse, dtype, order, copy, force_all_finite, ensure_2d, allow_nd, ensure_min_samples, ensure_min_features, estimator)
    571         if force_all_finite:
    572             _assert_all_finite(array,
--> 573                                allow_nan=force_all_finite == 'allow-nan')
    574
    575     if ensure_min_samples > 0:

/local/burghbvander/miniconda3/envs/fastai/lib/python3.7/site-packages/sklearn/utils/validation.py in _assert_all_finite(X, allow_nan, msg_dtype)
     60                     msg_err.format
     61                     (type_err,
---> 62                      msg_dtype if msg_dtype is not None else X.dtype)
     63             )
     64     # for object dtype data, we only check for NaNs (GH-13254)

ValueError: Input contains NaN, infinity or a value too large for dtype('float64').

The allow_nan tag should probably be set to True in XGBClassifier.

Em ... so there's a tag ...  That's new to me.

Yes. Tags can be added by implementing a _more_tags method. For an example within scikit-learn, see here.
I'm not sure whether adding the tag would automatically fix the compatibility issue with sklearn.feature_selection.RFECV. Let me know if I can be of any help.

No, adding allow_nan tag to the XGBoost classifier does not help.

Hi, I am unsure if this issue has been fixed. I am having similar issues using RFE ins scikit-learn

It's fixed in #5538. Are you using latest XGBoost version (1.1.0)?

Just updated and works now. Thank you for the help!


Cordova 9 support

What
Cordova 9 support! Fixes #132
Verification Steps

npm install cordova@latest
ionic cordova platform rm android
Add this plugin (from forked repo to test)
ionic cordova platform add android@latest

The build succeed!
Checklist:

[X] Code has been tested locally by PR requester
[X] Changes have been successfully verified by another team member

Progress

[x] Finished task

I have tested if using 9.0.0<EMAIL_ADDRESS>and it works like a charm. Thanks for the contribution @pcsantana I really appreciate that!


Make ZeroPadding2D optionally asymmetric

I propose to implement an asymmetric padding as an option in the ZeroPadding2D.
Reasons:

From my experience it could be definitely useful when using convolutional layers for the time series data. At some degree it's covered in #531.
Probably it could also be useful for the image processing, but I cannot offer an example.

Open questions:

May be it's better to add a separate layer for asymmetric zero padding instead of changing the existing ZeroPadding2D?
There's a possible confusion in the existing ZeroPadding2D (see https://github.com/fchollet/keras/blob/master/keras/layers/convolutional.py#L1345-L1346) - dimensions are called width and height, respectively, but in all convolutional layers respective dimensions are rows, cols (vice versa). Should I leave the as is or change?
May be it makes sense to do the same thing for ZeroPadding1D simultaneously? The reason why I've started with 2D is that 1D convolution is a kind of not 1st class citizen - e.g. it lacks Deconvolution, AtrousConvolution implementations, etc.

Probably it could also be useful for the image processing, but I cannot offer an example.

I've wanted it before for making the output of Deconvolution2D layers the right size.

Travis failed at the test of the model saving in Python 2.7 again, that looks to have nothing in common with the changes made.

Faced some issues after the default image dimensions changed to the 'tf', will try to resolve.

OK, looks like I've fixed a bug, remaining errors are in the other tests.
So, paddings for the asymmetric padding are to be passed as a separate arguments (top_pad, bottom_pad, left_pad, right_pad).
Option to pass the symmetric 'padding' as a tuple of 2 is kept for the compatibility. If 'padding' has value different from (1, 1) it overrides other arguments.
If it's OK in general, I'll do some cleanup and that's it.

Ah, wait, I'll do the asymmetric ZeroPadding1D too, as soon as now we have a dilated convolution 1D, thanks to #3763

@fchollet Would you be so kind to provide a feedback?

@lukovkin it looks like this PR includes a lot of changes that shouldn't be included. Sync to master and update the PR.

@fchollet OK

@fchollet Done syncing and cleanup.

@fchollet Would you be so kind to provide a feedback?

Hi @fchollet, just came up with the same need for asymmetric padding (for time series analysis as well)
Could you please take a look into it?
P.S
I know that i'm stating the obvious, the Keras is awesome, thanks for it!

Sorry for the delay in reviewing.

Hi, @fchollet @lukovkin
I've made the requested changes, and i want to push for reviewing, but i get push error with access denied message at my GitKraken.
Could you guys please guide me of what should I do? I'm new to the open source community :)
Thanks!

Also added test for the ZeroPadding1D to the test_convolutional.py.

Thanks, LGTM


Define setup_default_test_properties.

This allows a set of tests to share a common set of properties without
having to pass all the tests the same options.

Out of interest, do you have an example of a test where you used this?

Sure, https://bugs.webkit.org/attachment.cgi?id=250787&action=prettypatch

So {timeout:foo} is really deprecated since it just tends to add instability compared to running the test to the full harness timeout. I think I should really just remove support. Do you have some reason for using it here?

Yes. Every WebKit test file has its own timeout and we have several testharness tests in each file. If for example the first testharness test times out, it can mean (and it happens in some cases) that the whole test file is marked as timeout, when what we want is to have the granularity of the testharness timing out (or not).

Sorry, I still don't understand the issue.
If you don't specify a timeout, that test will get marked as TIMEOUT when the overall page times out (or, if a step function is never called, as NOT RUN). The only thing that adding a per-test timeout can do is to reduce this timeout which just has the effect of adding more instability (which is bad). You can still tell which subtests timed out. If you are taking a status of TIMEOUT for the overall page to be more problematic than a status of OK but with subtests timed out, it sounds like your integration with testharness.js has the wrong semantics.

Oh, maybe the case you are worried about is when you try to sequence the tests, even though they are async, but some time out. If you really need to do that (do you?) your scheduler can implement a fixed timeout for each test and call test.force_timeout() Then you only need to specify the timeout in one place. But it's a rather worrying thing to do (because, for example, some of the hardware Mozilla run tests on is quite slow and it is very possible to miss 150ms timeouts, so the test that you linked before would likely get disabled or edited due to instability in any case).

Yes, I know that reducing the timeout can lead to a bit more of instability, which shouldn't be a big trouble at least in the case that I am dealing with. Even the slowest bots can cope with 150ms, at least most of the times and even if you get small degree of flakyness, it is better than having a whole test file which several tests timing out with no information of which test caused the problem, which is my real issue. In the WebKit environment, when a test file times out, you don't get information of what happened inside the test, just that it timed out so you don't get the granularity of testnarness timeouts.
About your second comment, yes, I can do that, but my intention is trying to avoid per test configuration. I don't care if I have to specify per test timeout or per test timeout, it is a problem.
Our intention is to reduce the general testharness timeout and if there is any problem with a certain test set, we can increase it for those cases.
Besides, this pull request has only to do with timeouts in a collateral way, as I posting a way of customize all tests parameters at once, which in our special case, it is the timeout which we discussed above.

If you're not interested in the PR and do not want to discuss it any further, please close it or let me know to do it myself.


Support for rich text (bold, italic, etc)

Apologies if this is a duplicate, but I'd love support for italics and bold and such in Yakyak. I know that the mobile Hangouts client doesn't support it, but the browser does, so I suspect it's doable.
Thanks for a wonderful app!

+1 for this as well. Really miss the ability to Bold / Italicize when sending messages


Option to skip packaging

Currently when we run wildfly:run, it runs packaging and then starts the application server to deploy the package. If you've multi-module project where ear/war is already built and you just want to deploy that.  In that case, Its a redundant packaging step.
It would be better, if we have some option in maven-wildfly-plugin to skip the packaging phase for  wildlfy:run or wildfly:deploy goals.

In general, I see two ways to use the maven-wildfly-plugin during the development:

Start the wildfly server separately and deploy the application using maven-wildfly-plugin
Start & deploy using the maven-wildfly-plugin.

I prefer the second approach, since i don't want to download & manage wildfly separately. In that case, each time i've to build the entire project and then run the 'wildlfly:run' goal to deploy the application. I see a redundancy in the packaging process. Is it possible to avoid this? Or is there a better way to do with the second option? Please correct me, if I'm wrong.

How do you run the goal? From the command line or from an IDE?
In general though you could just cd ear && mvn wildfly:run. Yes it would rebuild the EAR, but that's probably not a huge deal.

I usually run from the command-line as you mentioned. Yeah, May not be a huge deal. but its good to have such option, so that we can save few minutes (since its a big enterprise project) in the deployment.

I really think the run goal really needs to fork the package lifecycle. Otherwise as a user the package phase would have to be explicitly run each time.


offline message

Whether the system supports offline messaging？

no

Private messages don't work offline, group messages work offline, right? Are there plans to support private messages offline? Also, are there plans to support video and audio messaging?

I dont know but i think a IM application can not work offline.


Design patterns

Hello @gustavooquinteiro! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/InterFace.py:

Line 46:80: E501 line too long (82 > 79 characters)


[FLINK-20769][python] Support minibatch to optimize Python UDAF

What is the purpose of the change
This pull request will Support minibatch to optimize Python UDAF
Brief change log

Support minibatch to optimize Python UDAF

Verifying this change
This change added tests and can be verified as follows:

original tests

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

class MeanAggregateFunction(AggregateFunction):
def get_value(self, accumulator: ACC) -> T:
    if accumulator[1] == 0:
        return None
    else:
        return accumulator[0] / accumulator[1]

def create_accumulator(self) -> ACC:
    return [0, 0]

def accumulate(self, accumulator: ACC, *args):
    accumulator[0] += args[0]
    accumulator[1] += 1

def retract(self, accumulator: ACC, *args):
    accumulator[0] -= args[0]
    accumulator[1] -= 1

def merge(self, accumulator: ACC, accumulators):
    for other_acc in accumulators:
        accumulator[0] += other_acc[0]
        accumulator[1] += other_acc[1]

def get_accumulator_type(self) -> DataType:
    return DataTypes.ARRAY(DataTypes.BIGINT())

def get_result_type(self) -> DataType:
    return DataTypes.FLOAT()

Test Code
env = StreamExecutionEnvironment.get_execution_environment()
env.set_parallelism(1)
env.set_stream_time_characteristic(TimeCharacteristic.EventTime)
environment_settings = EnvironmentSettings.new_instance().use_blink_planner().build()
t_env = StreamTableEnvironment.create(env, environment_settings=environment_settings)
t_env.get_config().get_configuration().set_integer("python.fn-execution.bundle.time", 1000)
 t_env.get_config().get_configuration().set_boolean("pipeline.object-reuse", True)

t_env.create_temporary_function("python_avg", MeanAggregateFunction())
t_env.create_java_temporary_system_function("java_avg", "com.alibaba.flink.function.JavaAvg")

num_rows = 10000000

t_env.execute_sql(f"""
    CREATE TABLE source (
        id INT,
        num INT,
        rowtime TIMESTAMP(3),
        WATERMARK FOR rowtime AS rowtime - INTERVAL '60' MINUTE
    ) WITH (
      'connector' = 'Range',
      'start' = '1',
      'end' = '{num_rows}',
      'step' = '1',
      'partition' = '200'
    )
""")
t_env.register_table_sink(
    "sink",
    PrintTableSink(
        ["value"],
        [DataTypes.FLOAT(False)], 1000000))
result = t_env.from_path("source") \
    .select("python_avg(id)")
result.insert_into("sink")
beg_time = time.time()
t_env.execute("Python UDF")
print("PyFlink stream group agg consume time: " + str(time.time() - beg_time))

Test Results
num rows, num colums |  Consume Time(Before) | Consume Time(After)
1000w,3                      |     95.40s                         |    54.85s

@WeiZhong94 Thanks a lot for the review. I have addressed the comment at the latest commit.

Thanks @HuangXingBo for this great work and thanks @WeiZhong94 for the review. Have merged the PR.


chore: update deps

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.639%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
294

💛  - Coveralls


SPAG and expansion pass organise/before

General SPAG and formatting pass of the marked section, includes some page expansion to Side Events and aims to improve judging with reference to HHEU/wiki#104.  Bundled due to the minor changes to most pages.

Thanks @robzwolf the joys of having done this with no spell check. All the notes seem solid and I'll bring them in when I'm back at a keyboard tomorrow.

Updated with those changes @robzwolf


Request to add Jurassic

Jurassic is A Straightforward API Server for Deno. Read README for details.

Sorry to bother you, why it is keep failing @ry?

@ry would you review? 🙏


Update create-self-hosted-integration-runtime.md

Based on my most recent experience (2023-02-20) it looks Like JAVA 11 is the currently supported JRE / JDK Now (it is unclear if 8 is still supported or not. I had numerous JNI erros with 8 that seemed to go away after moving to 11). Also depending on the distro the bin folder may not get automatically added to the system path with the JRE install. I have added this as another thing to check. if the bin folder is not in the system path the SHIR will be unable to find the java.exe   Please verify this for technical accuracy thanks

@lrtoyou1223

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Cargo.lock: do you want to commit or .gitignore it?

Currently, neither is done and the file keeps appearing in git status. That's very annoying.

added to gitignore


Error

HTTPError [FetchError]: request to https://discord.com/api/v7/gateway/bot failed, reason: unable to get local issuer certificate
at RequestHandler.execute (C:\Users\teacher\Downloads\PossumBot-master\PossumBot-master\node_modules\discord.js\src\rest\RequestHandler.js:93:15)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async RequestHandler.push (C:\Users\teacher\Downloads\PossumBot-master\PossumBot-master\node_modules\discord.js\src\rest\RequestHandler.js:39:14)
at async WebSocketManager.connect (C:\Users\teacher\Downloads\PossumBot-master\PossumBot-master\node_modules\discord.js\src\client\websocket\WebSocketManager.js:138:9)
at async Client.login (C:\Users\teacher\Downloads\PossumBot-master\PossumBot-master\node_modules\discord.js\src\client\Client.js:222:7) {
code: 500,
method: 'get',
path: '/gateway/bot'

When I put node bot.js, this pops up


Remove Documenter from dependencies of package

Also, remove package from dependencies of documentation.
@rkurchin after merging this, you can trigger registration again without
changing the version number,
https://github.com/JuliaRegistries/General/pull/32382 will be automatically
updated and it should pass AutoMerge checks.

Oh oops, that must have been a compat bot tripup, thanks!


Configuration cache could store more versions of task graph for the same command, not just the latest one

Expected Behavior
Please change the behavior of configuration cache so instead of recalculating the graph after each change in configuration, if the task graph of the new configuration was already computed in past, it is reused.
It would behave like configuration cache has its own build cache.
Current Behavior (optional)
Currently, the configuration cache for each input stores only last state. If I for instance make change in libs.versions.toml (I might change "version_androidmaterial" from "1.5" to "1.6"), and I launch gradlew tasks, I see message in concole:
_Calculating task graph as configuration cache cannot be reused because file 'gradle\libs.versions.toml' has changed.
At the end new task graph rewrites the previous one in configuration cahe. Which means that if I revert the change (I change "version_androidmaterial" back to 1.5), the task graph will be calculated again, instead of reusing older version.
Context
We are a team of developers working on android project. We are using bitbucket for managing pull requests. Each change of any pull request launches series of CI jobs to validate the build of project, running various kind of tests etc. We would like to incorporate the use of configuration cache on our CI server to speed builds a little.
It is quite often we make some change into our gradle configuration in project. We change some dependency version, or create new module and so on.
Build of pull request with will on our CI cause the task graph being replaced with new one. Subsequent build of other open pull request does not contain the changed configuration, so task graph will again not be up-to date and again will be recomputed.
Moreover, the pull request with configuration change will be eventually merged into repository. After that, our bitbucket few days will be in state when some of current open pull requests already contain the configuration change, while others not.
This also increases number of task graph recalculations, sometimes to the point there is little or no reuse at all.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team and is prioritized by them.

The progress can be tracked here in https://github.com/gradle/gradle/pull/31086


Add missing ignore to a decode

Proposed change

Add missing 'ignore' to a decode
Add/update tests

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR is related to issue: n/a

Codecov Report

Merging #301 (9641de2) into 0.3.0 (3059754) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##            0.3.0     #301      +/-   ##
==========================================
- Coverage   95.41%   95.36%   -0.06%
==========================================
  Files           3        3
  Lines         741      733       -8
==========================================
- Hits          707      699       -8
  Misses         34       34

Impacted Files
Coverage Δ

custom_components/mail_and_packages/helpers.py
94.04% <50.00%> (+0.01%)
:arrow_up:

custom_components/mail_and_packages/sensor.py
98.21% <0.00%> (-0.23%)
:arrow_down:

custom_components/mail_and_packages/config_flow.py
100.00% <0.00%> (ø)


ca in nmprc -> TypeError: Cannot create property '' on string

I have a private registry and had up till now used the ca field for the certificate in the .npmrc.
Running a script with yarn in each package wasn't a problem but trying to run the scripts in parallel with wsrun resulted in the following error:
TypeError: Cannot create property '' on string '"-----BEGIN CERTIFICATE-----\n...-----END CERTIFICATE-----"'

I moved the certificate to its own file and used cafile instead of ca in .npmrc and now it works.

Do you have the rest of the stack trace preferably with line numbers included?

this should be the relevant info from the yarn-error.log
Yarn version:
  1.21.0

Node version:
  12.13.0

Platform:
  win32 x64

Trace:
  TypeError: Cannot create property '' on string '-----BEGIN CERTIFICATE-----\n...-----END CERTIFICATE-----'
      at set (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:53902:28)
      at set (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:53906:14)
      at set (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:53886:16)
      at Function.objectPath.set (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:53939:14)
      at NpmRegistry.mergeEnv (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:96009:18)
      at NpmRegistry.<anonymous> (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:31899:12)
      at Generator.next (<anonymous>)
      at step (C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:304:30)
      at C:\Users\taocu\AppData\Roaming\nvm\v12.13.0\node_modules\yarn\lib\cli.js:322:14
      at new Promise (<anonymous>)

Seems to be a crash type error in yarn, not wsrun


Restic restore include-file/exclude-file switches

Output of restic version
restic 0.16.4 compiled with go1.21.6 on darwin/amd64
What should restic do differently? Which functionality do you think we should add?
It would be helpful if the include-file, --iinclude-file, --exclude-file, and --iexclude-file switches existed for the "restore" function.
What are you trying to do? What problem would this solve?
I recently needed to restore a bunch of different files that got deleted.  About 1600 of them, in random places.  When I did "restic diff" I could easily get a list of all the files that were deleted - but I don't have an easy way to feed that into Restic to restore just those files.
My options are to restore a large swath of files to get a few, or to run restic restore on each file individually - which seems impractical with that many files.
Did restic help you today? Did it make you happy in any way?
Restic rules!  ✌

Thanks for the suggestion. I agree that restore should offer those options in a way similar to the backup command. Anyone up for a PR?

@akrabu the changes have been merged. You can test :)

@konidev20 paths of files with brackets don't work
file.txt:
/E/data/Design development/3d maps/Elgabaly 3d max library/1-Exterior/2-Elevations/3-Materials/3-MARBLE CLADDING & STONE/marble/marbel/waterget/WR-7200o[.jpg
restic restore --include-file "/share/file.txt"
Fatal: --include-file: invalid pattern(s) provided
I had to edit the file and add a \ before the [
so now it's
/E/data/Design development/3d maps/Elgabaly 3d max library/1-Exterior/2-Elevations/3-Materials/3-MARBLE CLADDING & STONE/marble/marbel/waterget/WR-7200o[.jpg
and restore worked fine after editing:
Summary: Restored 13 / 1 files/dirs (146.035 KiB / 146.035 KiB) in 0:01
but it's not very practical to edit files to manually skip characters in paths listed and saved by restic ls command itself

@MichaelEischer Is there a way to give restic a list of plain file names instead of patterns?

@MichaelEischer Is there a way to give restic a list of plain file names to restore instead of patterns?

You can try something like an awk script or a sed expression to escape the special characters.
restic ls | sed 's/[]\/$*.^[]/\\&/g' > includePatterns.txt

Is there a way to give restic a list of plain file names to restore instead of patterns?

Not at the moment, feel free to open a feature request.


accessibility setting based select database dropdown

workaround for the accessibility defect

@alanrenmsft I'll merge now to pick-up in a new test build.


[Feature Request]: Golang SDK SpannerIO

What would you like to happen?
I would like to propose a naive SpannerIO implementation for the Golang SDK.
See implementation here: https://github.com/christogav/beam/tree/master/sdks/go/pkg/beam/io/spannerio.
Issue Priority
Priority: 2
Issue Component
Component: io-go-gcp

.take-issue

Completed


HibernateProxy object unproxy in WorkbenchProjections

Description
HibernateProxy object unproxy in WorkbenchProjections.
Proxy object error due to hibernate version up.
To solve this problem, HibernateProxy Object unproxy.
Related Issue :
How Has This Been Tested?

create workbench
go into workbench withour error.

Need additional checks?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 6


collapseAll and extendAll are disabled

https://github.com/vipzhicheng/logseq-plugin-vim-shortcuts/blob/014fc60495f7479756abe376031d8e61254b2f7f/src/main.ts#L119-L120

Logseq has a related bug before v0.6.7 so I disabled it. But after v0.6.7 the bug is fixed, I will release this feature asap.

It's released.


Allow to pass Asciidoctor converter templates

Asciidoctor allows to customize its output by passing it so called converter templates. It is done by passing it as argument the path to a folder containing these templates.
I’d need this feature to customize the rendering of AsciiDoc admonitions so that they better integrate in the theme I’m using.
I’m wondering if this is something you would be accepting a PR for? If so, how do you see this implemented:

I can add a new config option for the template folders to pass to Asciidoctor during rendering,
or we can agree on a folder convention where the users would put their templates (like for the shortcodes folder for example) and always pass this folder to Asciidoctor.

What do you think?

Converter templates are the AsciiDoc equivalent of Hugo's Markdown render hooks. Maybe a fixed location such as:
layouts/
└── _default/
    ├── _asciidoc/
    │   └── inline-image.html.erb
    └── _markup/
        └── render-link.html

Or maybe all in one directory:
layouts/
└── _default/
    └── _markup/
        ├── inline-image.html.erb
        └── render-link.html

I'm not sure if the _markup directory is for Markdown only, or if it is for all forms of markup, including AsciiDoc.

Thanks for your answer @jmooring!
I really like your idea of treating converter templates as render hooks and I don’t have a strong opinion on whether they should be put together in the same folder or not. Maybe there’s a risk of conflict and the best would be to have something like this?
layouts/
└── _default/
    └── _markup/
        ├── asciidoc
        |   ├── inline-anchor.html.slim
        |   └── inline-image.html.erb
        └── markdown
            ├── render-image.html
            └── render-link.html

However this is a breaking change.
Regarding your objection on AsciiDoc oriented features, I mostly agree with you. On the other hand, this feature would “just” be a matter of passing an extra argument (--template-dir) when invoking Asciidoctor. I don’t think there will be a lot of maintenance to do on it, since the rest of the mechanism, the virtual filesystem (I don’t know if this is the right name for the feature which allows different levels of overriding for files in the layouts folder), is common to every supported markup language.

Reading further...
Directories should (not must) be nested by backend...

We also recommend creating a nested folder named html5 to organize the templates by backend.

Instructing Asciidoctor to apply your templates is the easiest part. You only need to tell Asciidoctor where the templates are located and which template engine you’re using. (Technically, you don’t need to specify the template engine. But, by doing so, it makes the scan more efficient and deterministic.)

So while we can hardcode the top level path, we'd need a config option for templateEngine with a default value for ERB. Or do there need to be different engines depending on the backend?
And I presume toc.html.erb should be ignored if preserveTOC is false. I'm not sure how that would behave out-of-the-box; need to dig into the details.
And there may be other details to consider... like what should happen if the templateEngine option is set to slim but the necessary gems are not installed. Presumably asciidoctor throws an error that we can pass through, but I'm not sure about that either.

@yann-soubeyrand Comments regarding the above?

Wow, thanks a lot for all the work done so far! I planned to have a look this weekend at the questions you had, I haven’t seen that you already answered most of them!
The first remark that comes to my mind is that there are several implementations of Asciidoctor other than the Ruby one, for example Asciidoctor.js, which a lot easier to work with in my opinion (just npm init -y && npm install asciidoctor --save-dev && cat package.json | jq '.scripts |= { "hugo": "hugo" }' | tee package.json and then you can exec npm run hugo -- serve), but comes with different template engines: https://docs.asciidoctor.org/asciidoctor.js/latest/extend/converter/template-converter/. May I ask you why you prefer to limit the possible values for the templateEngine config?
Second, it’s more a question on the feasibility than a remark, because I’m not aware enough of the inner working of Hugo: could we imagine building a temporary union folder for the templates (in a temporary directory)? This could of course be done in a second time.
Other than that, it seems pretty appealing to me!

several implementations of Asciidoctor

If we pursue this, we should focus on the most common implementation (gem) first. If it works with Node.js, great. If it doesn't, that's a separate proposal.

a temporary union folder for the templates

I don't see that happening. We would need to do this every time we build (and maybe rebuild) the site, probably stuffing them  somewhere in the cache directory. Keep it simple.

limit the possible values for the templateEngine config

One of my concerns about this proposal is the potential for arbitrary code execution. I have no idea which, if any, of the available template engines provide this capability. For all I know, you might be able to do with that the erb, haml, and/or slim. If we cannot prevent arbitrary code execution, this proposal is DOA.

Regarding arbitrary code execution...
Arbitrary code execution
Testing an erb template:
<% File.delete("/home/jmooring/temp/test-a.txt") %>

Testing a slim template:
- File.delete("/home/jmooring/temp/test-b.txt")

Testing a haml template:
- File.delete("/home/jmooring/temp/test-c.txt")

All three deleted the file. This is scary, and makes this proposal DOA unless there's a template engine that prevents code execution.

Closing based on the thread above. This is insecure.

From the doc:

You can compose templates in any template language that’s supported by Tilt.

Maybe Handlebars could be a candidate, right?

OK, I can make handlebars work, and it is certainly more secure than erb, haml, or slim. The required stack is:
sudo apt install ruby ruby-dev
gem install --user-install asciidoctor concurrent-ruby tilt tilt-handlebars

Unfortunately, tilt throws this warning for every page processed, despite having installed the tilt-handlebars gem:

WARN  _index.adoc: /home/jmooring/.local/share/gem/ruby/3.0.0/gems/tilt-2.3.0/lib/tilt/mapping.rb:333: warning: Lazy loading of handlebars templates is deprecated and will be removed in Tilt 3.  Require tilt/handlebars manually.

Isn’t it that you need something like this in your Hugo config?
asciidocExt:
  extensions:
    - 'tilt-handlebars'

Regarding union filesystem, couldn’t we pass several template dirs, that is, the theme templates first, then the user supplied templates? From Asciidoctor documentation and a basic test I did, this should work as intended: https://docs.asciidoctor.org/asciidoctor/latest/convert/templates/#use-multiple-template-directories.

The remaining question is: are we certain that the handlebars template engine doesn't allow arbitrary code execution?

Sadly, no… Asciidoctor supports a helper file (https://docs.asciidoctor.org/asciidoctor.js/latest/extend/converter/template-converter/#helpers-js-file) and I just tested that I can read a file anywhere in my home directory… We’d need to check that no template directory contains a helpers.js file, else arbitrary code execution is possible.

We could (potentially) disable the converter templates feature when running Asciidoctor via Node.

@yann-soubeyrand If you can build from source, please test https://github.com/gohugoio/hugo/pull/12318.

@jmooring good job, it works as expected!
Regarding the two challenges to handle union file system:

Couldn’t we put the templates in a layout directory which we’d instruct Hugo not to parse?
To avoid vendoring, couldn’t we use the path where Hugo caches the module?

Couldn’t we put the templates in a layout directory which we’d instruct Hugo not to parse?

If you want this proposal and draft PR to have a chance of being accepted by the project lead, the changes must be isolated to the markup/asciidocext package. Keep it simple and be happy if either or both are accepted.

To avoid vendoring, couldn’t we use the path where Hugo caches the module?

Sure, but the path will vary by OS, user, environment variables, etc., and the path will typically be external to the project directory (we don't want that). With a shared project, the only stable module path is _vendor/something.

it works as expected

I want you to break it, find holes, etc.

Couldn’t we put the templates in a layout directory which we’d instruct Hugo not to parse?

You can add add ignore/include regexps to the layouts mount(s):
https://gohugo.io/hugo-modules/configuration/#module-configuration-mounts

@yann-soubeyrand
Regarding https://github.com/asciidoctor/asciidoctor.js/issues/1727, an asciidoctor CLI flag would be useful only in conjunction with version checking (i.e., that flag will have no effect with current and previous versions).
@jmooring

@yann-soubeyrand What's your current opinion on this proposal? Do the restrictions (e.g., handlebars only, no access to virtual file system) limit its usefulness to the degree that we should not pursue this?

Hello @jmooring, sorry for the late reply… My opinion is that the restriction on handlebars only is not a problem (after all, better a single template engine than none), but the lack of access to the virtual filesystem limit the usefulness.
To elaborate, my initial use case was to enhance AsciiDoc support with Docsy theme: I wanted to adapt how AsciiDoc blocks (like code blocks, admonitions, etc) were rendered so that the theme CSS doesn’t have to be modified. However, my goal for these AsciiDoc converter templates was that they be shareable in a Docsy derived theme or even upstreamed. If it’s not possible, I’ll end up modifying the theme CSS (which can be distributed in a derived theme and/or upstreamed).

If it’s not possible

It's not possible out-of-the-box as discussed in previous comments in this issue. Given that limitation, I'm inclined to close this proposal. I've pinged a few other AsciiDoctor site authors, and the response has been tepid.

Yes, I think we can close this for the moment. Thanks a lot for the PoC!


Req python

Add python wrapper and tests for new req sketch.
Also discovered that kll had no get_k() method, so added that and included it in the python wrapper.

Pull Request Test Coverage Report for Build 557421947

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.347%

Totals

Change from base Build 556164680:
0.0%

Covered Lines:
4473

Relevant Lines:
4741

💛  - Coveralls


Documentation not wide enough

When looking at the options in the documentation it's quite hard to read because it's only utilizing a small part of the screen.
If instead of using a container class on the parent div we would use a container-fluid class. And a col-md-12 on the actual column, it would even fit on half a 1920x1200 screen properly without any need for scrolling.

Thanks for the report. I have keep the existing formatting but move the line that was generating the scrolling from pre to code tag and remove codè tag every where else. I also use col-md-12instead ofcol-md-12`. Looks better for me.

Amazing, thank you. It looks much better now :)


Add a6 page size

Adds the a6 format, perhaps not as useful for website pdf's, but useful for ticket/barcode generation etc.

Hey @barryvdh, thanks for the PR! Could you please update docs/api.md to include a6 page format?

Yes, done :)

Not sure if all format (eg. up to a10?) should be included though.


Jenkins Generator: Allow lightweight checkout option

Currently, the test job generator uses non-lightweight checkout because of a Jenkins issue when using variables for SCM Repo & Branch fields. This causes the full repo to be cloned to the Controller for each test job, which ends up consuming a great deal of disk space.
This has been partially(?) resolved in JENKINS-42971. As far as I can tell, the solution only works for Branch, not Repo. I have asked for clarification in the issue.
What this means is we can switch to lightweight checkout for all the jobs that don't need a parameterized repo value. I am thinking all generated automatic jobs. Ie. everything except for Grinders etc.
Not sure if it would be beneficial to add a bool to the generator job to toggle lightweight and/or toggle hardcoded repo vs parameter.

Yes, I got the same result. The solution only works for the branch, not the repo.
stderr: fatal: '${ADOPTOPENJDK_REPO}' does not appear to be a git repository
fatal: Could not read from remote repository.

As for the solution, instead of having another bool parameter, we will set Branch Specifier as a parameter regardless. Only set Repository URL explicitly if LIGHT_WEIGHT_CHECKOUT=true. Otherwise, set Repository URL as a parameter. Once https://issues.jenkins.io/browse/JENKINS-42971 is fully resolved, we should remove LIGHT_WEIGHT_CHECKOUT parameter as LIGHT_WEIGHT_CHECKOUT=true should always be set. And both Repository URL Branch Specifier should be set as parameters.


Add inadyn as third DNS Client option

I'm not sure about adding another plugin which is more or less the same as the ddclient one, if we would like to support additional backends, it might be a better idea to add "backend" as an option in the ddclient, knowing that comes with challenges of its own.
ddclient is far from perfect, but given all the noise we have seen about the future removal of os-dyndns makes me think we should be careful offering too much options without thinking about support in the long run.

I would appreciate inadyn because if DynDNS will be removed and there needs to be a successor then there should be more than one, especially if ddclient cannot nearly compete with the current feature set of DynDNS.

ddclient is far from perfect but given all the noise we have seen about the future removal of os-dyndns makes me think we should be careful offering too many options without thinking about support in the long run.

I also think this is a valid concern, but maybe there is no "one to rule them all solution" and inadyn seems way more mature in terms of flexibility and its feature set compared to ddclient.

My thinking was that an additional option might make the switch to ddclient more palatable (also it was fun to explore the OPNsense UI).

As mentioned earlier it might be an option to support different backends in the existing  os-ddclient  plugin, more or less a copy of the existing plugin isn't going to make the bar at this time....
The amount of support provided on os-ddclient over the last months has been staggering, maintainability in the long run is one of my main concerns at this time.  I am willing to spend some time on reviews and testing, but limited. Commercial interest in dynamic dns is very low, which is likely the cause of most of the issues seen so-far.


QA-13722: definition of endsWith for IE11

JIRA

https://jira.jahia.org/browse/QA-13722
Description

Tests
The following are included in this PR

[ ] Unit Tests (Most changes should have unit tests)
[ ] Integration Tests

Checklist

I have considered the following implications of my change:

[x] Security (in particular for changes to authentication, authorization, data fetching, ...)
[x] Performance
[x] Migration
[x] Code maintainability

Documentation

[ ] Inline documentation
[ ] Internal Documentation (wiki)
[ ] User-facing Documentation

Not sure if this Polyfill from mozilla is good:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith#polyfill

Not sure to understand, it's what I'm using. Have you another suggestion? If so, feel free to modify directly the PR.

There is already an endsWith function here that I suggest we can use instead: https://github.com/Jahia/jahia-csrf-guard/blob/376f3b910f3852a554ab22a503dc81c0398f2a96/src/main/resources/META-INF/csrfguard.template.js#L87. If anything, maybe we can add a bit more checks in that function such as s as undefined or null and is a string.
There is already an instance of polyfilling that had negative impacts on other modules (mostly because it apparently wasn't done very well): https://github.com/Jahia/jahia-csrf-guard/pull/26 so we should probably try to contain these and avoid the polyfill approach for now.
Source for this js btw is coming from this repo: https://github.com/aramrami/OWASP-CSRFGuard/blob/master/csrfguard/src/main/resources/csrfguard.js

Yep, I hesitated to use this function but as it was not used before, I thought it was for a good reason :) I will update the PR but won't modify the function as it's not related to this ticket.


RxJS v6 docs are in repo but not released?

I was just about to create a PR that updates the Installation page at http://reactivex.io/rxjs/manual/installation.html, which is still describing RxJS 5, only to find out that it has been updated already 2 months ago in GitHub!
Why is it that these and all other v6 changes in the doc/ folder have not been released to the http://reactivex.io/rxjs site? Right now, the published docs are really misleading.

The docs are in flux right now. We have a brand new documentation site, and we're in the process of getting it published. Sorry for the confusion.

Okay, so for now, I have reactivex.io/rxjs redirecting to the newer docs (with an HTML redirect unfortunately, until we have the new domain setup)

Note that the OP was concerned about instructions in the installation page and the new docs site also have the same outdated instructions in the installation page: https://beta-rxjsdocs.firebaseapp.com/guide/installation
Another concern is: how does one access the old site, now? In case they want, e.g., to read the long-form tutorial or use the operator selection widget.

As @staltz mentioned, the new site seems to have the same outdated state of the docs as the old one when it comes to the guides. Perhaps just redeploy the old ESDoc-based page so that the guides are up-to-date?
By the way, is there a particular reason that there is a new custom-written docs page in the works? Are there any limitations of ESDoc that caused you to make that decision?

The new documentation offers additional opportunities for accessibility for example. Also the old docs were kinda complicated to edit. The new ones should be easier to understand


Empty ssptool.yaml file causes error

If I create an empty ssptool.yaml, I get the following error:
$ > ssptool.yaml
$ node main.js server
Loading data...
Cannot set property '_errors' of undefined
$ rm ssptool.yaml
$ node main.js server
Loading data...
Initializing...
Listening on http://localhost:3000
Ready.

If an ssptool.yaml must have contents, it would be nice to get a better error message.
(side note: it would be nice to know what can go into that file)

Should be fixed now.

(side note: it would be nice to know what can go into that file)

Mainly it's the command-line options (datadir: and docdir:), plus document definitions. Updated the wiki to try to make this more apparent.
The authoritative definition of config file contents is the json-schema in lib/config.js; ssptool validate also checks the configuration file.


PR: Add argument for the background color of the FigureCanvas

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)
[x] Included a screenshot (if affecting the UI)

Add a argument to set the background color of the FigureCanvas of the Plots plugin
A preview:

Issue(s) Resolved

Fixes #8443
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

Hello @dalthviz! Thanks for submitting the PR.

There are no PEP8 issues in the file spyder/plugins/plots/widgets/figurebrowser.py !


Add archive command

Added the archive feature into Tracey, including test cases, UG and DG.
This feature is implemented by getting the archived file path using the address book directory as the base directory. It will create a directory in this directory called archive. In this archive directory, subdirectories are also created which is named after the local pc's date for easier indexing. The archived file is named in this format DDMMYY_hhmmss where hhmmss is in 24 hours format. This is to ensure that each archived file name is unique.
After the archived file path is obtained, a dummy file is created at this path using FileUtil#createIfMissing(), and the contents of the address book file is copied over using Files#copy().
This PR is to ask for feedback for the initial implementation, which can then be merged thereafter.
This PR is not part of a greater set of changes and is not dependent on any concurrent PR.
Also created two test case to test for success and unsuccess archiving of a test address book file.

Codecov Report

Merging #112 (551d809) into master (52a56c9) will decrease coverage by 0.08%.
The diff coverage is 65.51%.

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
- Coverage     70.66%   70.57%   -0.09%
- Complexity      504      511       +7
============================================
  Files            81       82       +1
  Lines          1718     1747      +29
  Branches        182      184       +2
============================================
+ Hits           1214     1233      +19
- Misses          454      463       +9
- Partials         50       51       +1

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

...a/seedu/address/logic/commands/ArchiveCommand.java
67.85% <67.85%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Same file name handling

Upload multiple files, with different contents but the same name.  The interface makes it ook likt his is totally fine, with the "Add your files" showing different entries, with the correct file sizes, etc..  However, the files are then later rejected during resource creation.
Two things which would seemingly really improve UX here:

Let users know about the duplication issue when they are uploading files.  The error arising after all the uploads are done could be annoying to users - particularly if they do a lot of file uploading work.
Enable file renaming in the upload interface.  It seems likely that users may be uploading the same named file (e.g. results.csv) from multiple project directories.  Enabling on renaming while uploading would circumvent the need for users to modify their own file system to accomodate HydroShare application upload needs.

005.zip

@martinseul I think this can be closed after a second opinion.

@ndebuhr. This seems to be fixed or NA as the implementation has changed. Closing, please reopen if still needed

@ndebuhr. This seems to be fixed or NA as the implementation has changed. Closing, please reopen if still needed


Utterance with numbers like 2/3 as second entity does not work correctly with prebuilt entity - number

Describe the bug
If numbers such as 2/3 are used as part of utterance, it does not work correctly for number.
To Reproduce
Steps to reproduce the behavior:

Go to LUIS portal, add prebuilt entity - number, train and test.
Type '30 1/2'
See issue

Expected behavior
For the input "30 1/2"
Output:
30 - number
1/2 - number
Sample input/output
Input: "30 1/2"
Output:
"30 1/2" - number
Platform (please complete the following information):

LUIS, portal

Additional context
The below works correctly:

This behaviour is by design. "30 1/2" is the regular notation for 30 + 1/2 = 30.5, so it's only one entity.
The second case is different, as there is no notation that takes a fraction first. So the output has two separate entities.
I'll close this issue. Feel free to add comments for discussion and we can create another issue if necessary).

Hi @tellarin the behavior changes if the input is: 3/1 2/3
It won't recognized as number entity


test csvtojson.ts

the script src/data/csvtojson.ts is untested.  It really should be, since it is essential to adding new routes easily.  Just verifying that it runs without errors would be nice.

Dup of https://github.com/OpenBeta/sandbag/issues/120


fix docs on how to run tests

What does this PR do? (please provide any background)
updates documentation on how to run tests, as it is broken.
Also removes ref to yeoman generator as it is out of date.
What tests does this PR have?
none
How can this be tested?
read the readme, then npm run docs
Screenshots / Screencast
What gif best describes how you feel about this work?

Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):

[x] I have checked the contributing document and I'm happy for this to be reviewed.

Software Engineer or Developer review:

[ ] I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
[ ] I’ve checked for coding anti-patterns.
[ ] I’ve checked for appropriate test coverage.
[ ] I’ve checked all the tests are passing.

Software Engineer or project guru review:

[x] I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
[x] I’ve checked for coding anti-patterns.
[x] I’ve checked for appropriate test coverage.
[x] I’ve checked all the tests are passing.

Looks good :shipit:
Sooo happy we are removing the generator!

Taking DEV

I have a feeling that we will introduce the generator again, but better.

Looks good to me :+1:


update elixir ver to 1.10.0

Good point, the github action fixes came separately. We need to update the docs and specify what Elixir ver is considered compatible too.


SPARK-23685 : Fix for the Spark Structured Streaming Kafka 0.10 Consu…

…mer Can't Handle Non-consecutive Offsets
What changes were proposed in this pull request?
 In the fetchData , Instead of throwing an exception on failOnDataLoss, I am saying return the record

if its offset falls in the user requested offset range
How this patch was tested :
  manually tested, added a unit test and ran  in a real deployment

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I don't see the problem. You see an exception which tells exactly what can be done:

If you don't want your streaming query to fail on such cases, set the source option "failOnDataLoss" to "false". "

Why do you want this change at all?


Cannot connect to Microsoft Service Bus with v3.4.23

I cannot connect to an on premise Windows Service Bus instance with version 3.4.23 (or 3.4.18). I reverted to v2.1 and it works fine with the same connection string.
The connection string looks a bit like this:
Endpoint=sb://xxx/abc,sb://yyy/abc,sb://zzz/abc;StsEndpoint=https://xxx:9355/abc,https://yyy:9355/abc,https://zzz:9355/abc;RuntimePort=9354;ManagementPort=9355;WindowsUsername=user;WindowsDomain=domain;WindowsPassword=password
[Redacted]
Note that I am impersonating another user when connecting.
The service bus instances have self signed certificates, but I have trusted all of them on my local machine.
As I say, it works fine in 2.1, but not in 3.4+ Could this be because the impersonation does not work in these versions?

Hi Ferguson
any version of the Service Bus Explorer tool that is higher than 2.1.3 does not work with the on-premises version of the Service Bus by definition. This is not due to the tool, but to the Microsoft.ServiceBus.dll used by the tool as the latter is not compatible with the on-premises version of the Service Bus. This is clearly mentioned in the main page here on GitHub. :)
Ciao
Paolo


Safari 13 is not supported

Hello 👋
Browserstack supports Safari 13 on OSX Catalina. However, when I provide a browserslist query to browserslist-browserstack equal to this: safari 13, it returns an empty list of browsers.
Minimal script to reproduce
const getCapabilities = require('browserslist-browserstack').default;

(async function() {

    const browsers = await getCapabilities({
        browserslist: {
            queries: [
                'safari 13'
            ]
        }
    });

    browsers.forEach(b =>
        console.log(`${b.os} ${b.os_version}, ${b.browser} ${b.browser_version}`)
    );

})();

Expected result
The script should print OS X Catalina, safari 13.1.
Current result
The script does not print anything, no browser is selected.

Hi @martindzejky
Thanks for raising the issue. I believe this is because BrowserStack only supports 13.1 and not 13.0, and the browserslist query safari 13 only returns safari 13. To fix this you will likely need to do 2 things:

Use the query safari >= 13 perhaps even safari >= 13 && safari < 14.
Make sure the browserslist stats are up-to-date by running npx browserslist@latest --update-db

Thanks for the quick response! Running npx browserslist@latest --update-db helped.


1.10: Pre-fill fields for IDIR users

User Story
As a complainant with IDIR access I want to have my basic information prefilled, so that I can save time by not having to fill everything myself.
Fields to be prefilled -

Legal first name
Legal last name
Your ministry
Your position title
Your work location
Your immediate supervisor
Your telephone number
Your government email address:

Acceptance Criteria

[ ] The fields mentioned above are prefilled for IDIR users when they log in
[ ] The fields should be editable

Notes
https://github.com/bcgov/digital-journeys/blob/main/docs/forms.md#how-to-auto-populate-form-fields-with-the-user-data
@MissionT

Legal first name  - done
Legal last name - done
ministry -  populated - user must select  manually, (this is because the field is not connected to source of truth)
Your position title - done.
Your work location - done. Note: only the street pulls (no other info such as city, prov, postal code)

I can only see this form in DEV so leaving in TEST/QA to confirm its' ok in TEST as well, could you check for me on Monday @fazil-ey ask Iman about the access and let home know if you still can't see the 1.10 complaint in TEST either

I asked the devs to provide access to Fazil on Monday. Hoping he will be granted access by this afternoon.

The API property field officePhone has been added. My own phone doesn't populate.  I'll ask Iman if this does not work for UC#s.

Tested, fields are pre-filled as expected


Prepare updated container images for upload to Fix Central

This task follows up on https://github.com/IBM/bamoe-issues/issues/194 with additional requirements to make the artifacts ready to be uploaded to Fix Central:

Renaming: Use fourth number to indicate this release is a Fixpack to address CVEs, eg: bamoe-9.0.0.IF001-<IMAGE_NAME>.tar.gz (where IF stands for Interim Fix)
Readme: there should be a readme with some basic details, ie. contents of the fix, what it is fixing, and how to apply, and revert if that's possible... or simply pointing to some existing fix application instructions from the readme should be sufficient too

@martinweiler @eduardocerqueira I'd double check this is what we want:
Renaming: Use fourth number to indicate this release is a Fixpack to address CVEs, eg: bamoe-9.0.0.IF001-<IMAGE_NAME>.tar.gz (where IF stands for Interim Fix)
<== this is a versioning convention for VRMF (IBM 99% products, and DBA products use the fourth digit for interim fixes (a concious decision no longer to release a full fix pack due to monthly cadence).
However, we claimed BAMOE follows semantic versioning principal (effectively VMF), so is it more of bamoe-9.0.IF001 ? Or we treat this as an one-off CVE patch to roll up to 9.0.1 cumulatively? Thanks.
BAMOE 9.0 Support Policy: https://www.ibm.com/support/pages/node/7007883

Thanks for your input @YajieY - we are using bamoe-9.0.IF001-<IMAGE_NAME>.tar.gz now.

Readme file (draft):
Status:                    Fix

Product:                   IBM Business Automation Open Editions

Release:                   9.0.0

Operating System:          All operating systems

Date:                      2023-08-10

Abstract:                  This interim fix includes fixes for these libraries to address:
                           RHSA-2023:4347, RHSA-2023:4349, RHSA-2023:4354, RHSA-2023:4569

Interim fix installation instructions
=====================================

Refer to the BAMOE Canvas installation guide:
https://ibmdocs-test.dcs.ibm.com/docs/en/ibamoe/9.0.0?topic=installation-bamoe-canvas

BAMOE Canvas Images - Interim Fix details
=========================================

File: IBM Business Automation Manager Open Editions 9.0.IF001 – BAMOE Canvas Image
- File Name:         bamoe-9.0.IF001-canvas-image.tar.gz
- File Size (bytes): 112950760
- SHA:               ecbf3689163630041a2cd62e161be2d0a5185227
- Description:       BAMOE Canvas is a web application that provides authoring tools for Decisions and Workflows, directly in the browser.

Fixed issues in BAMOE Canvas Image:
- RHSA-2023:4349: libxml2 security update
- RHSA-2023:4347: libeconf security update
- RHSA-2023:4569: dbus security update
- RHSA-2023:4354: curl security update

File: IBM Business Automation Manager Open Editions 9.0.IF001 – BAMOE Canvas Extended Services Image
- File Name:         bamoe-9.0.IF001-extended-services-image.tar.gz
- File Size (bytes): 68701840
- SHA:               d0baaf9dee61b4694d64720d6d7baf19f92aff98
- Description:       This image provides features like DMN Runner, static validation of DMN, BPMN models, and also provides a proxy to communicate with OpenShift and Kubernetes clusters.

Fixed issues in BAMOE Canvas Extended Services Image:
- RHSA-2023:4349: libxml2 security update
- RHSA-2023:4354: curl security update

File: IBM Business Automation Manager Open Editions 9.0.IF001 – BAMOE Canvas Git CORS Proxy Image
- File Name:         bamoe-9.0.IF001-git-cors-proxy-image.tar.gz
- File Size (bytes): 137046009
- SHA:               07321eb2a757ca7ca06b23d2cf2c825cb0784139
- Description:       This image provides a proxy to allow BAMOE Canvas web app to communicate with Git providers, like github.com and bitbucket.org.

Fixed issues in BAMOE Canvas Git CORS Proxy Image:
- RHSA-2023:4349: libxml2 security update
- RHSA-2023:4354: curl security update

Renamed the files and added the readme file to the image-updates folder

Hi @martinweiler the install guide link in the readme is our internal testing doc env, please replace it with the public one: https://www.ibm.com/docs/en/ibamoe/9.0.0?topic=installation-bamoe-canvas
Thanks!
Refer to the BAMOE Canvas installation guide:
https://ibmdocs-test.dcs.ibm.com/docs/en/ibamoe/9.0.0?topic=installation-bamoe-canvas

Good catch @YajieY