[CSL-1542] Try to restore iphlpapi for DNS code on Win only

@rockbmb Let's start from here in debugging what's going on 😉
Hopefully the CI will give us some insight!

As predicted by @rockbmb the build on Win fails with:
C:\s\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_<IP_ADDRESS>_ghc-8.0.2.exe --builddir=.w\dist\ca59d0ab configure --with-ghc=C:\Users\appveyor\AppData\Local\Programs\stack\x86_64-windows\ghc-8.0.2\bin\ghc.EXE --with-ghc-pkg=C:\Users\appveyor\AppData\Local\Programs\stack\x86_64-windows\ghc-8.0.2\bin\ghc-pkg.EXE --user --package-db=clear --package-db=global --package-db=C:\s\snapshots\6dde1a60\pkgdb --package-db=C:\w\.w\install\5600629f\pkgdb --libdir=C:\w\.w\install\5600629f\lib --bindir=C:\w\.w\install\5600629f\bin --datadir=C:\w\.w\install\5600629f\share --libexecdir=C:\w\.w\install\5600629f\libexec --sysconfdir=C:\w\.w\install\5600629f\etc --docdir=C:\w\.w\install\5600629f\doc\cardano-sl-infra-0.5.1 --htmldir=C:\w\.w\install\5600629f\doc\cardano-sl-infra-0.5.1 --haddockdir=C:\w\.w\install\5600629f\doc\cardano-sl-infra-0.5.1 --dependency=QuickCheck=QuickCheck-2.9.2-LvlomhGMxrFBkX1zwiWpQu --dependency=aeson=aeson-<IP_ADDRESS>-bvg0hqcciCGZuD2wrCkaE --dependency=base=base-<IP_ADDRESS> --dependency=base64-bytestring=base64-bytestring-<IP_ADDRESS>-4O9TExPPz6eI82Yj7L4SIj --dependency=binary=binary-<IP_ADDRESS> --dependency=bytestring=bytestring-<IP_ADDRESS> --dependency=cardano-report-server=cardano-report-server-0.2.1-8vzNOD1flKgISdU7x5q1rz --dependency=cardano-sl-core=cardano-sl-core-0.5.1-KShiPpIE76jJSCFjHYe3yN --dependency=cardano-sl-db=cardano-sl-db-0.5.1-bff1ALxj923KMbka9WuHv --dependency=containers=containers-<IP_ADDRESS> --dependency=data-default=data-default-<IP_ADDRESS>-Atv1ZD6t1rI1MrH9qSGaQC --dependency=directory=directory-<IP_ADDRESS>-GjCsKrj9z3QCjDkUZfYR6V --dependency=dns=dns-2.0.12-EXkcbyPkz3tHIwXv0AbpKN --dependency=either=either-<IP_ADDRESS>-6PiwKYkn4v6B4KO2R2Fu1b --dependency=ekg-core=ekg-core-<IP_ADDRESS>-G1KRQAgpWXyCIS5PiHAudz --dependency=ether=ether-<IP_ADDRESS>-DQr71rwEgvNAXgHaobJvfV --dependency=exceptions=exceptions-0.8.3-ADEDRATtUrMK1JW4zMQ9U --dependency=filepath=filepath-<IP_ADDRESS> --dependency=formatting=formatting-6.2.4-99Nwhnkkgy8Ff6qEBpTZer --dependency=generic-arbitrary=generic-arbitrary-0.1.0-4wdGlh95V1850BmN1AoxEe --dependency=hashable=hashable-<IP_ADDRESS>-2ZLNuHq395GGIHwEHuqZol --dependency=http-client=http-client-<IP_ADDRESS>-8ZNq6YJy5WC5GRhAya7J2c --dependency=http-client-tls=http-client-tls-<IP_ADDRESS>-FqbkarcvLviKyPVSs9N8PK --dependency=iproute=iproute-1.7.1-9BRunn4fZ2LJijFUX0wAoi --dependency=kademlia=kademlia-<IP_ADDRESS>-6w95LQQ6WrUEXRVRX5h4L3 --dependency=lens=lens-4.15.4-3P7PSyaTsWRLQnkSsAPtwp --dependency=list-t=list-t-<IP_ADDRESS>-5hQv0wfkuYf598er1kAI66 --dependency=log-warper=log-warper-1.1.2-Clrlrl9lV8zGLj0U6HjaHt --dependency=mmorph=mmorph-1.0.9-5bASEvmIkr5CpdAYXwPsn0 --dependency=monad-control=monad-control-<IP_ADDRESS>-1Ci8dYJ8Tb7E3HTcTqOb8l --dependency=mtl=mtl-2.2.1-BLKBelFsPB3BoFeSWSOYj6 --dependency=network-info=network-info-<IP_ADDRESS>-3CNHbSDxkB04OXdr5Q0x5c --dependency=network-transport=network-transport-0.5.2-C5qvioPDY0j34GsMszZ4XS --dependency=network-transport-tcp=network-transport-tcp-0.5.1-FlqVomLmHW7CB3XyTH9Qnm --dependency=node-sketch=node-sketch-<IP_ADDRESS>-8Xxhb4kDyXLDZM617eMDiX --dependency=optparse-applicative=optparse-applicative-<IP_ADDRESS>-bmydd61wXl1i03BWH5vZ --dependency=parsec=parsec-3.1.11-1aqiimsgq2dCv7eoaC8WuX --dependency=reflection=reflection-2.1.2-Bem12O1xFGSHr4C2Hyu1c4 --dependency=serokell-util=serokell-util-0.4.0-II7w27nVBoCHVZshBAYV1 --dependency=stm=stm-<IP_ADDRESS>-JQn4hNPyYjP5m9AcbI88Ve --dependency=tagged=tagged-0.8.5-1mTloBSoUxv8dqUr8XBGBt --dependency=template-haskell=template-haskell-<IP_ADDRESS> --dependency=text=text-<IP_ADDRESS>-9UQZjEJZQFSGMffj1Z5g00 --dependency=text-format=text-format-<IP_ADDRESS>-3cyN5zsAtZ9A1Nt0xXDPiM --dependency=time=time-<IP_ADDRESS> --dependency=time-units=time-units-1.0.0-LG1KGQdbetIIh4DlrSxGpy --dependency=transformers=transformers-<IP_ADDRESS> --dependency=transformers-base=transformers-base-0.4.4-GKSs0LKukAL8ymq2naFmrH --dependency=transformers-lift=transformers-lift-<IP_ADDRESS>-CVMYJkCDI9QHJ8IjqDaT9i --dependency=universum=universum-0.4.3-8wlDcsohrXPLnujkMONGcY --dependency=unordered-containers=unordered-containers-<IP_ADDRESS>-Bp9XgxjuHxcI4tFehVMDGC --dependency=yaml=yaml-<IP_ADDRESS>-6GQCSkhKSH0HFzuN6hAQD7 --ghc-options -Werror --ghc-options -DCONFIG=qanet_tns_wallet --ghc-options -DGITREV=76b30c8fe97b57e81197df25a2f55a5d9b62022b --extra-include-dirs=C:\OpenSSL-Win64-v102\include --extra-include-dirs=C:\Users\appveyor\AppData\Local\Programs\stack\x86_64-windows\msys2-20150512\mingw64\include --extra-include-dirs=c:\w\rocksdb\include --extra-lib-dirs=C:\OpenSSL-Win64-v102 --extra-lib-dirs=C:\Users\appveyor\AppData\Local\Programs\stack\x86_64-windows\msys2-20150512\mingw64\bin --extra-lib-dirs=C:\Users\appveyor\AppData\Local\Programs\stack\x86_64-windows\msys2-20150512\mingw64\lib --extra-lib-dirs=c:\w --enable-tests --enable-benchmarks
    Process exited with code: ExitFailure 1
    Logs have been written to: C:\w\.w\logs\cardano-sl-infra-0.5.1.log
    Configuring cardano-sl-infra-0.5.1...
    Cabal-simple_Z6RU0evB_<IP_ADDRESS>_ghc-8.0.2.exe: Missing dependency on a foreign
    library:
    * Missing C library: iphlpapi
    This problem can usually be solved by installing the system package that
    provides this library (you may need the "-dev" version). If the library is
    already installed but in a non-standard location then you can use the flags
    --extra-include-dirs= and --extra-lib-dirs= to specify where it is.
Sorry, we tried running command for 5 times and all attempts were unsuccessful!

Next step would be trying to isolate the differences between the very simple appveyor.yaml we have committed in the standalone example vs the one currently in use to see if anything obvious come up.

Oh dear, this is weird -- I was fiddling with Appveyor in my standalone app (to test the platform thing) and now the tests fails randomly with a timeout error, even if I haven't changed the code! 😱
https://ci.appveyor.com/project/adinapoli-iohk/dns-resolver-windows/history

@adinapoli-iohk Can you tell me what's going on? DId the code I wrote for CSL-1481 stop working all of a sudden?

@rockbmb Absolutely (sorry for keeping you out of the loop in the first place).
In a nutshell, @fersel reported the DNS code was not working on Windows and @dcoutts asked to find out more. Unfortunately I don't have the exact details about the breakage (aka I lack reproduction steps, or a windows machine to begin with). Duncan suggested to create a standalone example which would demonstrate the DNS code was working in a "simplified" environment, and so I did:
https://github.com/input-output-hk/dns-resolver-windows
Such app comes with 2 tests, one testing specifically your C code, the other testing a multi-value lookup. Both used to work just fine but today I'm having random issues with Appveyor and the multi-lookup value is failing with a TimeoutException (but the C code is working just fine).
What I am trying now to understand is how so we can build things correctly in the standalone example (i.e. passing the extra-library) whereas for cardano-sl-infra this is not the case.
I hope this clarifies the state of affairs a little bit better, sorry!

@adinapoli-iohk Thanks!
In Slack you mentioned the commit for cardano-sl' for which I tested the DNS lookup, there is none (should've left it there..). I tested it locally by adding several calls to getDefaultWindowsDnsServerinside/node/src/node/Main.hs's main` function and started up the node while checking the console for IP addresses. It worked.

@adinapoli-iohk Also, I can tell you straight away - the standalone repo won't work on Windows unless you copy C:\Windows\System32\IPHLPAPI.dll _project's_directory_

Also, I can tell you straight away - the standalone repo won't work on Windows unless you copy C:\Windows\System32\IPHLPAPI.dll project's_directory

But this is the crazy part! It used to work! Look here:
https://ci.appveyor.com/project/adinapoli-iohk/dns-resolver-windows/build/1.0.14

@adinapoli-iohk that's a good idea, although when I was using procmon to check where cabal was looking for the libraries, it searched in C:\Windows\System32 without the --extra-lib-dirs flag.
Also, there's something else I noticed - the tests fail. For them to fail, they must be run; for them to run, they must have been compiled; for them to have been compiled, that means the whole project was built. As such, there was no issue with finding iphlpapi. Perhaps the cause of failure is completely unrelated to CSL-1542

As such, there was no issue with finding iphlpapi

Yes exactly, this is why I'm puzzled to observe this difference in behaviour between the two environments (simplified vs cardano)

that's a good idea, although when I was using procmon to check where cabal was looking for the libraries, it searched in C:\Windows\System32 without the --extra-lib-dirs flag.

Interesting. I guess it won't make any harm adding such explicit --extra-lib-dirs (although this won't explain why is not necessary for the standalone app). More invasive solutions would be to extend the appveyor script to print out all the DLL registered in the system or the content of System32, to be sure such DLL is really there to begin with.

@adinapoli-iohk Hm, it's quite unfortunate that CI isn't as deterministic as we'd like.
This failure in the latest commit of the standalone project is most likely a problem with AppVeyor itself, unless changing google.it to google.co.uk had some adverse effect.
What do you think of reverting that change just to make sure? If it still doesn't work, something's wrong with i.e. AppVeyor's cache.

This failure in the latest commit of the standalone project is most likely a problem with AppVeyor itself, unless changing google.it to google.co.uk had some adverse effect.

Totally agree -- I was getting desperate and I thought about some twisted plot whether traffic to that DNS would get blocked by Appveyor or stuff like that, but it's unrealistic. Let me try to revert the changes first, and wipe the cache (which I think I've never done before AND we are not even using it, now that I think about it) and see if I can observe any changes.

@adinapoli-iohk I added a small AppVeyor-only test to CI (and removed the extra-library: iphlpapi section temporarily to make it work), and it seems to work. Maybe we can build, on top of this module, progressively more elaborate tests to try and weed out the source of the error.
What do you think?

Maybe we can build, on top of this module, progressively more elaborate tests to try and weed out the source of the error. What do you think?

That's a very good start, although I'm still flabbergasted that not only isn't the extra-library required, but that adding it throws an error. We'll try to shed some light on that later, if needed.
I think what you have there is solid, but to be sure to be in a strong position this isn't quite enough. We need to include tests for multi-value lookup, as @fersel is reporting the following:

Everything's working with raw ip addresses, e.g. if my topology looks like the following:

  relays: [[{"addr": "<IP_ADDRESS>", "port": 3000}, {"addr": "<IP_ADDRESS>", "port": 3000}]]

But if I change it to the dns corresponding to those ip addresses (also addr is changed to host as stated in the topology doc):

  relays: [[{"host": "cardano-node-0.aws.iohkdev.io", "port": 3000}, {"host": "cardano-node-1.aws.iohkdev.io", "port": 3000}]]

node doesn't find relays anymore (I don't recall the exact problem, will check it a bit later)

This suggests indeed that DNSes are not resolving correctly. Mind, this might not have anything to do with the code you wrote, but we a bug in the dns library itself (which doesn't seem to be thoroughly tested on Windows), so we might need to put our Sherlock Holmes' hat and dig deeper 😉
Let me add some more tests and let's see what the CI has to say about them!

I've managed to nag Mr @fersel to run the standalone app (which I have enriched with debug info), and this is the report:
*** DEBUG INFO ***

DEFAULT DNS: Just "<IP_ADDRESS>"
www.google.it resolved to: Right [<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>]
cardano-node-0.aws.iohkdev.io resolved to: Left TimeoutExpired
cardano-node-1.aws.iohkdev.io resolved to: Left TimeoutExpired

*** END OF DEBUG INFO ***

Tests
  Unit tests
    getDefaultDnsServer works: OK
    multi-value lookups work:  FAIL
      Exception: user error (TimeoutExpired)
    resolving IOHK DNS works:  FAIL
      Exception: user error (TimeoutExpired)

2 out of 3 tests failed (0.36s)

Completed 2 action(s).
Test suite failure for package dns-resolver-windows-<IP_ADDRESS>
    dns-resolver-windows-test:  exited with: ExitFailure 1
Logs printed to console

So, report from the trenches:

The code @rockbmb wrote definitely works; we have seen in his tests plus the fact the standalone app reports <IP_ADDRESS>.

Failures seems to be non-deterministic: You can see how the first call to lookup for "www.google.it" works but all the other do not. In case you are wondering, here is how the tests are defined in the standalone examples:

main :: IO ()
main = do
  seed <- newResolvConf >>= makeResolvSeed
  -- Print some debug info
  putStrLn $ "\n*** DEBUG INFO ***\n"
  defaultDNS <- getDefaultDnsServer
  putStrLn $ "DEFAULT DNS: " <> show defaultDNS
  googIP <- withResolver seed $ \resolver -> DNS.lookup resolver "www.google.it" A
  c1     <- withResolver seed $ \resolver -> DNS.lookup resolver "cardano-node-0.aws.iohkdev.io" A
  c2     <- withResolver seed $ \resolver -> DNS.lookup resolver "cardano-node-1.aws.iohkdev.io" A
  putStrLn $ "www.google.it resolved to: " <> show googIP
  putStrLn $ "cardano-node-0.aws.iohkdev.io resolved to: " <> show c1
  putStrLn $ "cardano-node-1.aws.iohkdev.io resolved to: " <> show c2

  putStrLn $ "\n*** END OF DEBUG INFO ***\n"
  -- Run the tests
  defaultMain tests

tests :: TestTree
tests = testGroup "Tests" [unitTests]

unitTests :: TestTree
unitTests = testGroup "Unit tests"
  [ testCase "getDefaultDnsServer works" testGetDefaultDnsServer
  , testCase "multi-value lookups work"  testLookups
  , testCase "resolving IOHK DNS works"  testLookupsIOHK
  ]
[...] -- Rest

So we effectively try to resolve "www.google.it" twice: once in the debug info section, once in the tests. Why we are getting failures? In case you are wondering, I'm using very generous timeouts in the standalone app:
https://github.com/input-output-hk/dns-resolver-windows/blob/master/src/Network/DNS/Domains.hs#L51-L58

@rockbmb Bingo!

I have forked the dns package and I have started hacking on it to improve the Windows situation. I was successfully able to replicate failures:
https://ci.appveyor.com/project/adinapoli-iohk/dns/build/1.0.2
You will see the error is now different and that's because I have added a more-specific exception.

Ok! I think I have fixed it! See here:
https://ci.appveyor.com/project/adinapoli-iohk/dns/build/1.0.4
Apart from the doctest failures, you will notice now that the DNS lookup works correctly (at least in this iteration of the build). The culprit seemed to be the custom version of sendAll, which I have now removed. I'm caution to declare victory yet, but this looks promising..

Yay!
https://ci.appveyor.com/project/adinapoli-iohk/dns-resolver-windows/branch/master

@adinapoli-iohk I wasn't here when you fixed this, but excellent work! I wouldn't have found this error by myself.


Display error message on setup if origin doesn't match config.js url

refs #6106

add error handler for authentication step of blog setup
move setup acceptance test out of 'settings' folder

I have triple-checked this as I'm a bit jet-lagged, but it seems to me the setup screen is still spinning  endlessly when starting in production mode with the default my-ghost-blog.com.

FYI - all I'm doing is npm install --production with the default/example production config

Stange, I'm doing the same thing here but I'm seeing the error message on this branch...

config = {
    // ### Production
    // When running Ghost in the wild, use the production environment.
    // Configure your URL and mail settings here
    production: {
        url: 'http://my-ghost-blog.com',
        mail: {},
        database: {
            client: 'sqlite3',
            connection: {
                filename: path.join(__dirname, '/content/data/ghost.db')
            },
            debug: false
        },

        server: {
            host: '<IP_ADDRESS>',
            port: '2368'
        }
    },

    ...

I had caching turned on. Sorry.


knctl build create - blocks/never exits with standalone Knative Build

I tried installing Knative Build without Knative Serving/Istio, and knctl build create blocks at the end. From the kail -n knative-build logs, I think it might be blocking because no deploying is waiting for it:
{"level":"error","logger":"controller","caller":"cluster/builder.go:278","msg":"Saw \"default/2-lgrln\" update, but nothing was watching for it!"

Reproduction steps at https://starkandwayne.com/blog/p/4884e933-6a0a-43a5-b794-2afaa140c8bc/

interesting, what does knctl build show -b xxx output?

@cppforlife the show output says Succeeded at the end.

looks like in later versions of knative, following
  conditions:
  - lastTransitionTime: 2018-11-06T01:02:26Z
    status: "True"
    type: Succeeded

cannot be parsed via
// BuildCondition defines a readiness condition for a Build.
// See: https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#typical-status-properties
type BuildCondition struct {
	Type BuildConditionType `json:"state"`

	Status corev1.ConditionStatus `json:"status" description:"status of the condition, one of True, False, Unknown"`

	// +optional
	Reason string `json:"reason,omitempty" description:"one-word CamelCase reason for the condition's last transition"`
	// +optional
	Message string `json:"message,omitempty" description:"human-readable message indicating details about last transition"`
}

once knative 0.2.0 is release, knctl will be updated to use new apis. since upstream knative will not fix this issue, i m going to close this here. future version of knative will be more careful about changing apis.

decided to fix it as im updating knctl to knative 0.2.x: https://github.com/cppforlife/knctl/commit/c1a73dae7148ee2429a98040a7313d517188ec5d


Add a message to inform the user about more filters when one media type is chosen

Problem
The list of features in the mixed media results page is very small and there is no indication that more filters are available when you select only one media type.
Description

Add a message in the filters panel (something along the lines of "more filters are available if you select a certain media type") so that people can know that there are more filters and also how to access them.
Additional context
This will need design input and also the i18n-ified message text.

@dhruvkb, this issue seems to be the same as #509. This was opened earlier, but 509 seems to have more detail (it has a possible design image :) ). Can we close one of these issues?

Sure @obulat, let's only have the one with more details.

Closing in favor of #509


Baseline

Cleaned up patches so that they will now apply, albeit with warnings about spaces being wrong.
Also have a 'baseline' of failures in failures.txt (quite a few!)

@igortodorovskiibm please review once you accept the invitation


different results from iglue

Hello, I notice that the average result of zero-shot. in   marvl-code mUNITER 54.0, xUNITER.  56.1  is higher than your recent work iglue  mUNITER  53.72  xUNITER   54.59 . Especially for xUNITER ( 54.59  is about 1.5 points lower that  56.1)
I  reproduced your experiment with marvl-code Repository and the results are close to iglue . Can you give me some advice to imporve the results ? Or I should regard the iglue as baseline ?

Hi, I thought the lower scores in IGLUE were due to a longer max sequence length and random seed variance.
But you got similar ones using this repository.
Maybe you can try lower casing the text? Let me know if this helps!


Roll Flutter Engine from c838a1b05924 to 7168c1195afe (1 revision)

https://github.com/flutter/engine/compare/c838a1b05924...7168c1195afe
2023-06-03<EMAIL_ADDRESS>Manual roll Dart SDK from d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix that some input-elements are not reachable when a virtual keyboard is displayed

When a virtual keyboard is displayed (especially relevant to mobile platforms) all elements should be still reachable.

Also on Android, when trying to enter numbers in the numbers field (or when focusing the number field) it always removes all characters.

Hello, we tried to solve the issue.
This is what we did:
Modified the scrollToInput.js file to include a more robust solution for handling virtual keyboard display. Updated the EditCharacter.razor file to use the new JavaScript function and adjust the layout when inputs are focused.
You can review changes in this commit: https://github.com/mnmnk43434/YeGaSoft-DnDCharCtor-15/commit/843db0ecb3157ab63b859a9a62101fcef7df43bd.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

The problem is only in the MAUI-App-Version but not in the PWA.
So we could use the Workaround for Blazor Hybrid.
See: https://github.com/dotnet/maui/issues/14197


encoding/json: add the full path to the field in UnmarshalTypeError

go1.9.1 linux/amd64
I parse some JSON with nested objects on the server, and I cannot find the actual path to a nested field in UnmarshalTypeError. An example below.
Body payload:
{
	"Child": {
		"Field": "string" <--- here's the  invalid type
	}
}

type ParentStruct struct {
  Child ChildStruct
}

type ChildStruct struct {
  Field int
}

d := Parent{}

decoder := json.NewDecoder(r.Body)
err := decoder.Decode(&d)

What I expect to see

What I see instead

Such field like Path may be used to render detailed errors for some REST API.

@mvdan Can you take a look at newest change?

@mvdan - Is this same as https://github.com/golang/go/issues/27464 or different ?

Different - #27464 was about a regression where an input's error no longer had the struct context. This is about improving the context to also include the full path to the field.


[Qt] allow setting listen via GUI

add DEFAULT_LISTEN in net.h and use in the code (shared
setting between core and GUI)

Important: This makes it obvious, that we need to re-think the
settings/options handling, as GUI settings are processed before
any parameter-interaction (which is mostly important for network
stuff) in AppInit2()!

Works as advertised


docs/Analytics: update with post-4.0.0 info

The info here was outdated for InfluxDB.

Review period will end on 2023-02-17 at 18:20:10 UTC.

Review period skipped due to critical label.


Filter by Product Groups Limit?

I just tried to add a couple of Product Groups (aka Attributes) to my products, the first one added fine, and the second one which put the number to 13 seemed to as well. However it does not appear when you go and modify the block to filter by it. I tried changing the name, removing the underscore, deleting it, nothing. So, is the filter limited to 12 items?

Can you post a couple of code snippets of the filtering, just so I can test the same code?

I left the added attributes in place and here are the new pages:
This works attribute handle ("natural") #12
http://www.lincolnmfg-usa.com/preservatives/personal-care/natural
This doesn't attribute handle ("value_added") #13
http://www.lincolnmfg-usa.com/preservatives/personal-care/value-added
Is that enough?

I'm not seeing a limit to the number of groups.
I just put in 31 items, a-z, then aa-ae.
In the product group filter I can see all of them, as well as in the group list in the dashboard

Is this what you are referring to, or have I misunderstood the way you are filtering? Where I may be confused is your use of the word attributes - attributes and product groups aren't related

Ryan,
Apologies, you can remove this bug report. I was confusing the attributes with the product categories. Silly me. Carry on.
Sincerely,
David Zizza, TeKno Ziz
(617) 543-3971 cell<PHONE_NUMBER> home office
<EMAIL_ADDRESS><EMAIL_ADDRESS>teknoziz.com http://teknoziz.com/

On Jul 14, 2017, at 2:46 AM, Ryan Hewitt<EMAIL_ADDRESS>wrote:
I'm not seeing a limit to the number of groups.
I just put in 31 items, a-z, then aa-ae.
In the product group filter I can see all of them, as well as in the group list in the dashboard
https://user-images.githubusercontent.com/1079600/28201233-4d650056-68af-11e7-8a7f-0defa9c0cc6f.png
Is this what you are referring to, or have I misunderstood the way you are filtering? Where I may be confused is your use of the word attributes - attributes and product groups aren't related
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/concrete5-community-store/community_store/issues/250#issuecomment-315284474, or mute the thread https://github.com/notifications/unsubscribe-auth/AGyiUnLUUbabmhvQsaXi4xyIu3vgo2i_ks5sNw7LgaJpZM4OXUhK.

No worries!


Multi argument function definition formatting with refmt

Can refmt adopt the Facebook style for multi argument function definitions. It currently formats such functions as:
let withLatestFrom =
    (~selector: ('a, 'b) => 'c, other: Observable.t('b))
    : Operator.t('a, 'c) =>

In most Facebook codebases (both Hack and JS) you would see this formatted as:
let withLatestFrom =(
  ~selector: ('a, 'b) => 'c,
   other: Observable.t('b),
): Operator.t('a, 'c) =>

related to https://github.com/facebook/reason/issues/1626

yeah I think this is reasonable. cc @IwanKaramazow too

I can take care of this, have started a year ago on this, non trivial to do this good.


Plug 'enabled' option

I'm using vim for different tasks with different sets of plugins.
For example for development I start it with VIMDEV=1 vim with this in my .vimrc:
if $VIMDEV == 1
  Plug 'vim-scripts/Conque-GDB'
  Plug 'davidhalter/jedi-vim'
  Plug 'artur-shaik/vim-javacomplete2'
  Plug 'OmniSharp/omnisharp-vim'
endif

This works fine except that the PlugUpdate/PlugClean commands don't know about these plugins if I just run vim.
Would it be possible to add an optional enabled option like this?
  Plug 'vim-scripts/Conque-GDB', { 'enabled': $VIMDEV == 1 }

The plugin wouldn't get loaded if enabled is set to false but the Plug* commands would handle it correctly.

You can find the answer here: https://github.com/junegunn/vim-plug/wiki/faq#conditional-activation


Editing text formatting issue

When editing a text field, if you click on a button that disabled it like in the mute example it doesn't correctly format the text

This has been fixed.


Fixed #29324 -- Validate SECRET_KEY lazily (on access).

Requires #13239 to be merged first
ticket-29324

@carltongibson May I ask you to write the release notes (If we need some at all?). In theory you can merge just this PR instead of #13239 and this one, or merge the other first and then rebase.

No problem @apollo13. I'll look at it this week. Thanks.

@apollo13: With this patch:
>>> from django.conf import settings
>>> settings.configure()
>>> settings.SECRET_KEY
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/carlton/Documents/Django-Stack/django/django/conf/__init__.py", line 85, in __getattr__
    raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.

Which is the desired behaviour, I think.

@kezabelle Don't know if you want to glance at this? 🙂

@apollo13: With this patch:
>>> from django.conf import settings
>>> settings.configure()
>>> settings.SECRET_KEY
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/carlton/Documents/Django-Stack/django/django/conf/__init__.py", line 85, in __getattr__
    raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.

This is good to see. That means that this patch makes the behaviour actually "more" correct. Because master currently lets you access settings.SECRET_KEY after settings.configure() even though it is an empty string.

late to the party, but I have had a glance at it. Made sense for all the scenarios I can think of.

Thanks @kezabelle


can i have your expert opinion regarding \r\n vs custom \n just to save 1 byte

can i have your expert opinion regarding \r\n vs custom \n just to save 1 byte for high speed redis transmission
how can i make it even faster? (with redis)
is it advisable for me to change \r\n to just \n on both client and server side?
what's ur opinion on this? thx in advance.

Hi @ultperf,
I guess you are talking about the inline commands protocol, right? https://redis.io/docs/reference/protocol-spec/#inline-commands
The inline commands protocol is only useful when you are talking to redis with your hand and keyboard.
The binary-safe way to send commands is using RESP array https://redis.io/docs/reference/protocol-spec/#resp-arrays. There is no \r\n or \n at all.

yes u are right but isnt CRLF 2 bytes? we can shave it to 1 byte with LF '\n' right? just LF.
if i replace all CRLF with LF, will that save 1 byte in wire transmission?

Yes, it will. But if you use binary-safe protocol, there will be no LF at all.

ok thx! pls help with the last area i've asked. i cant seem to get the pipe / rueidis modification to work
 interface conversion: rueidis.Client is nil, not *rueidis.clusterClient:


When I make transfer I got the below issue

TypeError: unencodedPubKey.x.toArrayLike is not a function
at Transaction._serializePubKey (/var/www/html/node_modules/@binance-chain/javascript-sdk/lib/tx/index.js:203:84)
at Transaction.addSignature (/var/www/html/node_modules/@binance-chain/javascript-sdk/lib/tx/index.js:137:21)
at Transaction.sign (/var/www/html/node_modules/@binance-chain/javascript-sdk/lib/tx/index.js:160:12)
Could you please help me to resolve this?

Did you set the private key on the client?

how to set it? Where to get private key if we only have keystore.txt file? Salt does not work as intended. You do not mention anything about it in wiki.

A keystore file isn’t a private key, but it contains one. You can load the private key from a keystore file using the function made for that purpose:
https://github.com/binance-chain/javascript-sdk/wiki/API-Documentation#module_crypto.getPrivateKeyFromKeyStore


Upgrade/mern v2.4.0

See change.md for all changes

Doesn't show here but all tests have passed on Travis: https://travis-ci.org/Hashnode/mern-starter

Just removed my needs-approval. @mannyhenri would you like to review my changes?


object properties displayed incorrectly

Object properties are displayed incorrectly in the debugger, namely in the "print object command". For example, in Zork I, at the start of the game, printing object 2:
> PO02
prints properties
12, 0e, 09, 11, 0a, 04,
These are obviously incorrect since properties should always appear in descending order.
According to infodump, the starting properties should be 18, 17.
However, the emulator seems to iterate through object properties fine, so it seems to be a bug in the debugger object property printing routine.

Fixed in commit 483d2cc..e1676b8


feat(restdsl): Add openapi-restdsl generator REST endpoint

Fixes: #709
Draft. verified it works for happy path in command line(curl), now adding tests
Cc: @lordrip @Delawen
Open API spec in JSON
[tomo@p1 resources]$ curl -v -d @petstore.json -H "Content-Type: application/json" http://localhost:8081/rest/openapiToRest
*   Trying <IP_ADDRESS>:8081...
* Connected to localhost (<IP_ADDRESS>) port 8081 (#0)
> POST /rest/openapiToRest HTTP/1.1
> Host: localhost:8081
> User-Agent: curl/8.0.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 3841
>
< HTTP/1.1 200 OK
< content-length: 711
< Content-Type: text/yaml;charset=UTF-8
<
- rest:
    path: "/v1"
    get:
    - id: "listPets"
      path: "/pets"
      produces: "application/json"
      param:
      - dataType: "integer"
        description: "How many items to return at one time (max 100)"
        name: "limit"
        required: false
        type: "query"
      to: "direct:listPets"
    - id: "showPetById"
      path: "/pets/{petId}"
      produces: "application/json"
      param:
      - dataType: "string"
        description: "The id of the pet to retrieve"
        name: "petId"
        required: true
        type: "path"
      to: "direct:showPetById"
    post:
    - id: "createPets"
      path: "/pets"
      produces: "application/json"
      to: "direct:createPets"
* Connection #0 to host localhost left intact

Open API spec in YAML
[tomo@p1 resources]$ curl -v --data-binary @petstore.yaml -H "Content-Type: text/yaml" http://localhost:8081/rest/openapiToRest?inputFormat=yaml
*   Trying <IP_ADDRESS>:8081...
* Connected to localhost (<IP_ADDRESS>) port 8081 (#0)
> POST /rest/openapiToRest?inputFormat=yaml HTTP/1.1
> Host: localhost:8081
> User-Agent: curl/8.0.1
> Accept: */*
> Content-Type: text/yaml
> Content-Length: 2618
>
< HTTP/1.1 200 OK
< content-length: 711
< Content-Type: text/yaml;charset=UTF-8
<
- rest:
    path: "/v1"
    get:
    - id: "listPets"
      path: "/pets"
      produces: "application/json"
      param:
      - dataType: "integer"
        description: "How many items to return at one time (max 100)"
        name: "limit"
        required: false
        type: "query"
      to: "direct:listPets"
    - id: "showPetById"
      path: "/pets/{petId}"
      produces: "application/json"
      param:
      - dataType: "string"
        description: "The id of the pet to retrieve"
        name: "petId"
        required: true
        type: "path"
      to: "direct:showPetById"
    post:
    - id: "createPets"
      path: "/pets"
      produces: "application/json"
      to: "direct:createPets"
* Connection #0 to host localhost left intact

Bonus - Generate XML REST DSL
[tomo@p1 resources]$ curl -v --data-binary @petstore.yaml -H "Content-Type: text/yaml" http://localhost:8081/rest/openapiToRest?inputFormat=yaml\&outputFormat=xml
*   Trying <IP_ADDRESS>:8081...
* Connected to localhost (<IP_ADDRESS>) port 8081 (#0)
> POST /rest/openapiToRest?inputFormat=yaml&outputFormat=xml HTTP/1.1
> Host: localhost:8081
> User-Agent: curl/8.0.1
> Accept: */*
> Content-Type: text/yaml
> Content-Length: 2618
>
< HTTP/1.1 200 OK
< content-length: 810
< Content-Type: text/yaml;charset=UTF-8
<
<?xml version="1.0" encoding="UTF-8" standalone="no"?><rests xmlns="http://camel.apache.org/schema/spring">
    <rest path="/v1">
        <get id="listPets" path="/pets" produces="application/json">
            <param dataType="integer" description="How many items to return at one time (max 100)" name="limit" required="false" type="query"/>
            <to uri="direct:listPets"/>
        </get>
        <post id="createPets" path="/pets" produces="application/json">
            <to uri="direct:createPets"/>
        </post>
        <get id="showPetById" path="/pets/{petId}" produces="application/json">
            <param dataType="string" description="The id of the pet to retrieve" name="petId" required="true" type="path"/>
            <to uri="direct:showPetById"/>
        </get>
    </rest>
* Connection #0 to host localhost left intact

It might be even possible to directly invoke IntegrationsResource#integration() and get the Kaoto JSON, if it's possible to inject IntegrationResource instance.

Open questions:

Could the roundtrip be achieved as well?
What would happen if I have a rest section and send it to Kaoto will this work fine as well?
For the input: could we remove this parameter and inspect this value at the backend side? the reason why I'm asking it's to support files as well, like uploading a local JSON to be parsed.
For the output: could we have a single word parameter like output and if not provided, by default it's YAML?

We'll discuss 1. and 2. more since it involves frontend workflow.

For the input: could we remove this parameter and inspect this value at the backend side? the reason why I'm asking it's to support files as well, like uploading a local JSON to be parsed.

Quick search suggests that The only fool-proof way to know if something is valid YAML and not valid JSON, is to try to parse it as both.
https://www.google.com/search?q=test+if+json+or+yaml&oq=test+if+json+or+yaml&aqs=chrome..69i57j69i64.3293j0j7&sourceid=chrome&ie=UTF-8
We can do that parse-and-see-if-fail for sure, but if we were to add file/external URL support, I think it's gonna be a quick way like just check the extension. We can do that when we support URL. Or do we need it already?
BTW the inputFormat is assumend JSON if not specified.
https://github.com/KaotoIO/kaoto-backend/pull/710/files#diff-f7c72520204d03d2c60431e35934262c60aafeda5bda465f5092a9a7d4649aa6R65

For the output: could we have a single word parameter like output and if not provided, by default it's YAML?

Yes output sounds fine and it already assumes YAML if not specified
https://github.com/KaotoIO/kaoto-backend/pull/710/files#diff-f7c72520204d03d2c60431e35934262c60aafeda5bda465f5092a9a7d4649aa6R67

I think it's gonna be a quick way like just check the extension

Maybe not. I'll add that fool-proof way anyway, then it also handles the case URL has a wrong extension.

The interaction between kaoto-ui-rest
In order to avoid circlular dependency or polluting api module with DSL dependent code, it's better to separate into 2 actions

Post Open API specification and generate Camel Rest DSL in YAML
Generate Kaoto JSON (Integration) object from YAML

When user requests to import Open API spec, following is the expected workflow

kaoto-ui-rest posts the Open API spec to this openApiToRest endpoint and receive a rest portion of Camel YAML DSL
kaoto-ui-rest then posts previously received rest portion of Camel YAML DSL to the existing YAML>Kaoto-JSON endpoint, and receive a rest portion of Kaoto-JSON (Integration/FlowsWrapper)
kaoto-ui-rest then merges previously received rest portion of Kaoto-JSON into existing FlowsWrapper model object

Since kaoto-backend is stateless, it should be safe to do 2) YAML>Kaoto-JSON request separately from other routes/rests/etc.

JVM tests passed locally, stuck on native tests...


Add support for checking source in should_be_installed

I was on a ✈. I got bored. This got written. EOS

Sweeeeet, thanks. @homu r+

:pushpin: Commit efab507 has been approved by indirect

:zap: Test exempted - status


Bump helm from v3.10.1 to latest version

Bumps helm.sh/helm/v3 from 3.10.1 to 3.10.3.
Signed-off-by: Rashmi Gottipati<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 89.498%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0%

Covered Lines:
1713

Relevant Lines:
1914

💛  - Coveralls


.dao domains search instead of resolve

When I try to open a .dao domain I get a web search instead of resolving it...maybe it happens also with other domains tlds, I don't know any domain connected to a website to test.

@rebelcode-xr Thanks for reaching out! Unfortunately, I couldn't reproduce the issue. Could you share the domain that you are using?
There is also a page with test domains for browser resolution in our documentation, you can try some of them
https://docs.unstoppabledomains.com/developer-toolkit/resolve-domains-browser/test-domains/
And the extension provides a list of domains where you can find some more domains to test

I found out the problem: I must put http(s):// before the domain! Unfortunately that's not very intuitive/user-friendly from an user perspective... 🤔
Proposal:
Could you allow the extension to recognise the domains even without http(s):// ?

It should work with protocol prefix and without for the latest extension version. Thanks!


Implement data collection countdown:

This PR implements the countdown to collect data on the data page:

It also implements the recording bar:

In the design, the progress bar also has the cancel recording button present just above it.


Command Line CTRL+Z: Hot reload & restart not work

if i pressed CTRL+Z by error  in the command line
if i try to press r to make Hot reload or hot restart it will not work and i should re run my app again ...
VS Code windows 10 flutter 1.22.4

@imeDevelopers
tested on linux with a fairly recent master, ctrl+Z extits the program as expected
[✓] Flutter (Channel master, 1.24.0-8.0.pre.344, on Linux, locale en_US.UTF-8)
    • Flutter version 1.24.0-8.0.pre.344 at
      /home/francesco/snap/flutter/common/flutter
    • Framework revision de56c6ad72 (2 days ago), 2020-11-23 05:28:06 +0900
    • Engine revision 23a8e027db
    • Dart version 2.12.0 (build 2.12.0-62.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/francesco/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /snap/android-studio/current/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[✓] Android Studio
    • Android Studio at /snap/android-studio/current/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /snap/android-studio/current/android-studio
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (3 available)
    • Linux (desktop)  • linux      • linux-x64      • Linux
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      87.0.4280.66

• No issues found!

@imeDevelopers
Is it only happening with VSCode or with Android Studio too ?

@darshankawar
i dont work with android studio , so i not sure ..
my channel is stable on this flutter version ..
also the analyser take too long time to analyze any code
the reason why i use this version of flutter is because the latest version stops the hot reload or hot restart and gives me stopped message because of 0 isolates founded or something like this ..
i had opened an case for this problem but dont know latest results and fixed or not ..
i will try to mention the issue here for you ..
i need to use latest flutter version but it has problems..

@darshankawar
here it is
https://github.com/flutter/flutter/issues/68990

@iapicca
it should not exit from the terminal or do anything because this is not a vommand for the command line ...
of course the app still running, i mean the debug session i should rerun it again

@imeDevelopers
I don't use VScode so I can't replicate this issue. The issue you referred above was opened exactly a month ago which had earlier version of Stable, that indicates the issue is not with latest stable version (1.22.4). Is it possible for you to downgrade to previous stable version (ex : 1.20) and see if you still see the issue ?
Or you may also switch to latest master and confirm if issue persists.
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

El mié., 16 dic. 2020 10:32, Pedro Massango<EMAIL_ADDRESS>escribió:

Without additional information, we are unfortunately not sure how to
resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more
information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the
exact description of what happens, logs, and the output of flutter doctor
-v.
All system setups can be slightly different, so it's always better to open
new issues and reference related issues.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/71115#issuecomment-745985889,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADSPMGVUQGIPYHN5ORCQ7LSVB5EJANCNFSM4UAE75QA
.


Not an issue Actually :-)

This is what I am trying to achieve.
im using Your DMA implementation  and trying to use it as Ws2811Octo library(mostly the Live Video streaming, The SD card Video loading and using multiple controller part)
there is a lot of work to be done!!!!

uint8_t frameBuffer2[320];
I have not used this code for years. 320 bytes seems weird because it is not dividible by three (RGB per pixel). Not sure if it works because of luck, or because I forgot why I choosed that number.
uint8_t frameBuffer[360];
360 bytes / 3 = 120 LEDs seems fine
If you still have issues, send me your project. I don't have F103 but the code can show something, or I reflash some of Discovery kits ST-link MCUs.

ws2812b.item[0].channel = 0; what is this?
this relates to
#define WS2812B_PORT GPIOC
#define WS2812B_PINS (GPIO_PIN_0 | GPIO_PIN_1 | GPIO_PIN_2 | GPIO_PIN_3)
and defines that first WS2812B driver channel is mapped to GPIOC and port0 - PC0

And there were some commented section in ws2812b.c
Should I un-comment  it?

void DMA1_Channel2_IRQHandler(void)
void DMA1_Channel5_IRQHandler(void)
This section is commented out .
I should un-comment it right?


Update readme yaml file

what

updated README.yaml file
add tags and categories
rebuild README.md file

why

need to add categories and tags so we can pull them into the documentation

@osterman review plz)


MInutes are not selectable when using both min-time and max-time on 12h setting

Describe the bug
A clear and concise description of what the bug is.
Using this props
:min-time="{ hours: 5, minutes: 0 }"
:max-time="{ hours: 6, minutes:55 }"
:is-24="false"
minutes-increment="30"
partial-flow
:flow="['calendar', 'time']"
does not let me choose minutes, all selections are disabled.
As it seems to work for AM time,  I wonder how to set it for PM times. Docs have no indication of that.
To Reproduce
Steps to reproduce the behaviour:

Set those props
try to open the datepicker
select the date
click on minutes.
all of them are disabled

Expected behaviour
A clear and concise description of what you expected to happen.
I would assume that I should be able to pick time in the specified interval.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop & mobile (please complete the following information):

Browser [e.g. chrome, safari] Firefox, MacOs Ventura 13.3.1
Library version [e.g. 3.0.0] 5.0.1

You have set the value to PM. Where if you set the value to 6 PM for example, the code sees it like 18:00. I can add an event for button click and you can then adjust the time validation from 6 to 18


fix: use callback refs instead of useRef and fallback to offsetLeft: 0 when first child element ref no longer exists

Description

Switches to use callback refs with useOverflowScroll instead of useRef per the guidance of the following documentation:

https://reactjs.org/docs/refs-and-the-dom.html#callback-refs
https://stackoverflow.com/questions/64668211/how-to-listen-to-ref-object-changes

Resolves a couple outstanding bugs

Deploy Preview
TBD
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

:tada: This PR is included in version 20.26.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 21.0.0-alpha.12 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


added skills section

@hectorkambow , this is the pull request to add skills section to my profile

🚀
👏


🔨 Moving towards MVP Milestone 1

I feel like we are close to having a decent MVP version with a (close to) zero-config parse-anything mode with predictable behaviours, and a strict mode that detects many common user errors so the author does not have to.
We are at risk of stalling though. @darcyclarke who did the initial proposal in this repo is currently doing his own thing in https://github.com/darcyclarke/minargs (taking into account some discussions here), and I think @bcoe is taking a break from trying to coax some consensus (he did mention threads with "4 people with 8 opinions in them" as annoying, but good!). I suspect also the wider tooling group who are behind this initiative have been busy elsewhere.
I have been leaving it up to common agreement, or Benjamin to move things forward. We have covered a lot of good ground in discussions, but there are multiple viewpoints and goals and desires. I am going to try being more active to push towards a first milestone with key functionality implemented while we have people engaged here. Potentially with some approach rather than a universally agreed approach. It doesn't mean it is ready for Node.js consideration, or everything it could be, but I would like to try for something reasonably solid and implemented and usable.
I'll put 🔨 in any comments where I am pushing for a way forward. Speak up if I am out of order on a decision or process, and I'll cease and desist. 🙊
(Disclaimer: I am a maintainer of Commander. When issues come up I often research what other libraries are doing and what the POSIX and GNU guidelines say. I believe I have solid knowledge and experience of how command line parsing works in practice. I don't have experience with building a parser on top of a parser as such, which although not one of the stated goals of this repo is definitely of interest to people!)

https://github.com/pkgjs/parseargs/issues/11#issuecomment-1082664767

Restructure result conventions (again)
https://github.com/pkgjs/parseargs/issues/70#issuecomment-1082688095

Reporting indexes (maybe post-MVP)
https://github.com/pkgjs/parseargs/issues/84#issuecomment-1082694686

Can we add https://github.com/pkgjs/parseargs/issues/85 to the MVP also? That's not one which can be left for later; if positionals are opt-out in the MVP it will be hard to change.

I have not added #85 because I wasn't happy enough with it to block MVP working it out. But it has now been mentioned so some visibility, and opportunity for feedback from a wider group than the fairly hard-core strict people. 😄

We have landed the ones that I identified as ready for MVP!


Compatibility error with Laravel 5.4

Laravel 5.4 changed the method name for Session::store to Session::put.

This PR addresses the change https://github.com/comocode/laravel-ab/pull/15


"dribbblish-dynamic.js not installed" message showing up

Describe the bug
dribbblish-dynamic.js not installed randomly showing up
To Reproduce
Steps to reproduce the behavior:

Three dots in the top left
Help
Third-party software
Wait 3 seconds

Screenshots
https://gyazo.com/e5a029dc1b98f7bc9240300d14e745dd
Desktop Setup

Operating System: Windows 10
Spotify: <IP_ADDRESS>9
Spicetify: 2.8.3
Dribbblish: 4.1.1

Logs
spicetifyWrapper.js:879 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
Spicetify._cloneSidebarItem @ spicetifyWrapper.js:879
vendor~xpui.js:29 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 change listeners added. Use emitter.setMaxListeners() to increase limit
    at c (https://xpui.app.spotify.com/vendor~xpui.js:29:2621881)
    at t.o.addListener (https://xpui.app.spotify.com/vendor~xpui.js:29:2624465)
    at https://xpui.app.spotify.com/vendor~xpui.js:29:2254849
    at Pa (https://xpui.app.spotify.com/vendor~xpui.js:29:2859683)
    at Is (https://xpui.app.spotify.com/vendor~xpui.js:29:2883415)
    at t.unstable_runWithPriority (https://xpui.app.spotify.com/vendor~xpui.js:29:3096998)
    at gr (https://xpui.app.spotify.com/vendor~xpui.js:29:2829219)
    at ks (https://xpui.app.spotify.com/vendor~xpui.js:29:2883194)
    at Os (https://xpui.app.spotify.com/vendor~xpui.js:29:2868073)
    at vs (https://xpui.app.spotify.com/vendor~xpui.js:29:2866995)
c @ vendor~xpui.js:29
xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
guc3-spclient.spotify.com/remote-config-resolver/v2/configs/platforms/web/clients/desktop-ui/property-sets/edacff50be2653d4?installation-id=7a460e52-f88e-4877-b29c-7a365110c2f1&fetch-type=delayed:1 Failed to load resource: the server responded with a status of 404 ()
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/vendor~xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/696.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-routes-homepage-takeover-ad.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/566.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-modals.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-routes-home.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
licenses.html:11 GET https://xpui.app.spotify.com/bundle.js net::ERR_NAME_NOT_RESOLVED

Shows up on MacOS also however checking extensions and the config file both contain the dribbblish-dynamic.js file and after reloading the app it still works as intended so I think this is one of those false errors.

Shows up on MacOS also however checking extensions and the config file both contain the dribbblish-dynamic.js file and after reloading the app it still works as intended so I think this is one of those false errors.

yeah, dribbblish itself has no issues it's just a weird false error

Yeah I just checked, this is because the Third-party software popup is displaying an iframe, and the css is applied to it, but not the js. I have to see if there is any way to check for an iframe or url inside the css.


Pickle error

Hi!
I could load the provided resnet image features without problem. However, I get the following error when trying load the Oscar features.
    pickle.load(open(img_feat_path, "rb"))
_pickle.UnpicklingError: A load persistent id instruction was encountered,
but no persistent_load function was specified.

Do I need to specify a loading function?
My goal is to reproduce your results in the paper (table 3). Are you using Oscar features for line image only?
Best,
Max

Hi Max,
If memory serves, I believe the files shall be loaded via torch.load() instead of pickle (yes, the file name ends in .pkl which is a bit confusing.
Best,
David.

Thanks that works!


Cow: Watch ehunar.org

Cow requests the watch of the watch_keyword ehunar\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ehunar\.org has been seen in 1 true positive, 0 false positives, and 1 NAA.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'I think this was an incidental URL in an otherwise NAA'


The process takes too much memory during legacy tests execution

I'm working on this

The issue occurs because testcafe-hammerhead takes memory during large scripts processing (creating ast etc..)


[OSF-6273] Fix last update timestamp on draft registrations to not update for al…

Purpose
Fix so that the only the draft registration being updated will have a new time stamp.
Changes
Added a boolean check before the meta schema gets saved.
Side effects
None.
Ticket
https://openscience.atlassian.net/browse/OSF-6273

Added a minor edit to the Draft Registration editor so that the user knows that what he/she is editing is being auto-saved without clicking on "Save Draft"

Code seems good, but I haven't tried it out. Make an arrangement to demo this with @nicipfeiffer and/or @saradbowman. I will drop into the Product Demo column of Jira.

Looks great. 🎉 🐧 🎉


creating index...     index created!      Killed

when i run the order : python main.py -- prepare_masks
long time after i get some datas in file '/masks_overlayed_eroded_0_dilated_2/train'  include 'distance', 'masks', 'sizes'  about 6492  files,  but about 20 minutes after  it shows  'killed'
Output directory: /home/open-solution-mapping-challenge/oridata/masks_overlayed_eroded_0_dilated_2
loading annotations into memory...
Done (t=31.55s)
creating index...
index created!
Killed
how to  deal with this problem? thanks a lot!

I find the reason. The  data is too much ,so if your computer configuraton is not so good， i recommend you use the data of 'annotation-small.json' included. when you tain the net you only should change the file name as 'annotation.json'

Great thanks for finding the reason.
Do you think I can close this issue then?

@jakubczakon  no problem!


Update aws-auth-guide.md

Edited the content based on comments in https://github.com/demisto/etc/issues/27179

Status
Ready
Related Issues
fixes: link to the issue
Description
See comments in https://github.com/demisto/etc/issues/27179
Screenshots
Paste here any images that will help the reviewer

@ShirleyDenkberg when you get a chance could you please handle the change Guy suggested, so we can merge it? thanks in advance!

@ShirleyDenkberg what's the status here?


Delete error when cover art not present

also check for audio file. Once links are supported, audio file may not exist when deleting song.

closed by pull request #26


add license header in HostMetricsResponseTest.java

Description
This PR fixes jenkins build failures due to missing license header.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[x] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@rhtyd @nvazquez @DaanHoogland
please review.

Doc only change - no tests needed.


[i2c, rtl] Fixed Lint warnings

Signed-off-by: Igor Kouznetsov<EMAIL_ADDRESS>

I've rebased the branch, but CI failures didn't go away.

Yeah it looks like master is broken - I saw the same failure on other PRs as well. Will look into it.

@igk8 it looks like the failure has been fixed in the meantime. Another rebase should do it.

Another rebase fixed the CI issues.

Thanks @igk8, merging in.


More logger migration

Move more drivers/subsystems to the new logger.

Codecov Report

Merging #10638 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10638      +/-   ##
==========================================
- Coverage   53.34%   53.19%   -0.16%
==========================================
  Files         211      211
  Lines       25828    25828
  Branches     5686     5686
==========================================
- Hits        13779    13738      -41
- Misses       9734     9781      +47
+ Partials     2315     2309       -6

Impacted Files
Coverage Δ

include/posix/posix_sched.h
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_barrier.c
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_cond.c
62.5% <0%> (-20.84%)
:arrow_down:

lib/posix/pthread.c
68.03% <0%> (-12.33%)
:arrow_down:

lib/posix/pthread_mutex.c
76.38% <0%> (-1.39%)
:arrow_down:

lib/posix/pthread_sched.c
62.5% <0%> (+20.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6122e...572be1e. Read the comment docs.

Changes in the USBD driver look fine, not sure why you changed all the tabbing there at the same time though, but it looks fine anyway.

ah, I thought I had this in its own commit, I ran it through uncrustify.


White text on white background when using dark themes: Missing CSS property

Describe the bug
Text inputs and text areas use white fonts on a white background which make them impossible to use.
The reason is somewhere hidden behind my following setup:
Firefox configured to use the Dark Theme.
Latest KDE/Plasma/GTK/Qt using a Dark Theme (Breeze Dark)
By default text areas have a black background an white font.
Issue: In the CSS-File the background color gets defined to be white, but the font color is left to default.
Workaround
Edit index.html:
    <!-- 47 --> <link rel="stylesheet" href="styles.css">
    <!-- 48 --> <link rel="stylesheet" href="user.css"></head>

Add user.css:
input
{
    color: #080808;
}
textarea
{
    color: #080808;
}

There are more control elements that have very low contrast (bright gray on white).
But with this workaround the taskboard becomes usable.
Please complete the following information:

OS: Arch Linux (Host & Client)
Browser Firefox
Version 78.0.2 (64-Bit)

Technically this is an issue with scss-base, but since that's mine too I'll just track it here. :)


Apply Import Validation Checks (DTO) for Method Data  to Import API

METHOD Data Format Checks

The value for BeginDate must be formatted as a date yyyy-mm-dd
The value for BeginHour must be numeric, within the range of 0 to 23 (no decimals)
The value for EndDate must be formatted as a date yyyy-mm-dd
The value for EndHour must be numeric, within the range of 0 to 23 (no decimals)
If any of these fields do not contain valid values, it's an error. Error Message:
[METHOD-FATAL-A] The value for [fieldname] in the Monitoring Method record #[index of record] is not formatted properly

METHOD Data Value Checks

The value for ParameterCode must be string and limited to the results from (SELECT distinct parameter_code FROM camdecmpsmd.vw_methods_master_data_relationships)
The value for MonitoringMethodCode must be string and limited to the results from (SELECT distinct method_code FROM camdecmpsmd.vw_methods_master_data_relationships)
The value for SubstituteDataCode must be string and limited to the results from (SELECT distinct substitute_data_code FROM camdecmpsmd.vw_methods_master_data_relationships)
The value for BypassApproachCod must be string and limited to the results from (SELECT distinct bypass_approach_code FROM camdecmpsmd.vw_methods_master_data_relationships)
If any of these fields do not contain valid values, it's an error. Error Message:
[METHOD-FATAL-B] The value for [fieldname] in the Monitoring Method record #[index of record] is invalid

Testing
Test Case: TC660
Tester @mosesdeeCVP
Clean Monitoring Plan

Test Passed


Handle Ruby Symbols in nested Hashes/Arrays when testing Puppet params

When testing defines and passing nested hashes to params while using Symbols for keys, rspec-puppet leaves the ':' character in place when setting up the example. This causes puppet to complain about syntax errors on line 3, expecting '}' instead of ':'. This PR converts symbols to strings before substituting them as well as handles arrays just like hashes are already handled.
specs for RSpec::Puppet::Support#str_from_value also added.

Coverage increased (+0.08%) to 91.79% when pulling a20b8fc01f776e72ef49bf51402e5d7542177bc1 on trzejos:master into 13c3ffe10b1c6172c6d26b81ac8b72454a71f320 on rodjek:master.

Coverage increased (+0.04%) to 91.751% when pulling a5c35b1e8cc323f2ec19766bb27465803a9ba537 on trzejos:master into 13c3ffe10b1c6172c6d26b81ac8b72454a71f320 on rodjek:master.

Coverage increased (+0.08%) to 91.794% when pulling 9713ef957abc527a0fe8509cf523c0c7308bd83f on trzejos:master into 13c3ffe10b1c6172c6d26b81ac8b72454a71f320 on rodjek:master.

Coverage increased (+0.08%) to 91.787% when pulling a3108275cdb0d860671f19be89563d2c10014d2d on trzejos:master into 13c3ffe10b1c6172c6d26b81ac8b72454a71f320 on rodjek:master.


Refresh the first page of the event signup wizard

Trello card
https://trello.com/c/lbTnxf5u/1769-design-improve-visual-appearance-of-train-to-teach-event-transaction-flow-startpage
Context
The first page of the mailing list wizard recently had a refresh that had a slight uptick in performance. This makes similar changes to the mailing list one but with a single big photo at the top of the form and the 'event info' box slightly overhanging it.
Changes proposed in this pull request

Rename attractive layout to 'with side images'
Add layout for first page of event wizard
Add custom styles for first page of event wizard
Add styles for the first page of the event signup
Add dates and times to mobile signup component

Things that might need addressing

fix the heading style so we don't have <h1> and <h2> alongside each other?
improve the wizard step headings so they're more descriptive about what we're asking for on the page?

Preview

Mobile
Desktop

Looks good @peteryates!
Some comments/suggestions:

Is 'Registering for' overkill? Having said that, I think it actually works well on mobile in the reduced summary box, so maybe leave as is

I'm not sure we need 'Your attendance will be added to a register and an email will be sent.'? Sounds a bit too formal and bureaucratic - I'll check with Gary as to the rationale behind this

I actually quite like the summary box overhanging the photo but not the form (on desktop) rather than the form as well - the latter feels a bit boxy to me

I agree that we need to review the headings next - the current h2 is superfluous here

I know you haven't looked at markup yet but just to note that we have a skipped heading level at the moment (h3) which will get picked up as an accessibility issue

I'd like to run it past the Events team before we deploy, to increase their involvement

Additional note:
If we are changing headings etc., could we also change button labels to be sentence case, as per GDS guidelines?
(https://design-system.service.gov.uk/components/button/)? Or should I create a new PR for this as we have other instances eg mailing list signup (is it a common component in the form wizard?)?

Is 'Registering for' overkill? Having said that, I think it actually works well on mobile in the reduced summary box, so maybe leave as is

I'm not sure we need 'Your attendance will be added to a register and an email will be sent.'? Sounds a bit too formal and bureaucratic - I'll check with Gary as to the rationale behind this

I think it's worth getting @Tomcowan1 to cast his eye over these. I copied them word-for-word form the design but don't think either bit of text really provides the user with any useful information at this point.

I agree that we need to review the headings next - the current h2 is superfluous here
I know you haven't looked at markup yet but just to note that we have a skipped heading level at the moment (h3) which will get picked up as an accessibility issue

Agree with both of these, will address them in a separate PR as it'll affect the other pages of the wizard too.

I've reduced some of the duplication and split out the first page form so we can adjust it without affecting the others.
Now it looks like this:

I put the event name as the title for the time being, I don't really know what we should be using for it here. We're asking for personal details below so it feels like it should be something descriptive.

Hi @peteryates and @gemmadallmandfe - just taking a look at this (apols for the delay), I would:

Change the heading to an action. Either Sign up for Train to teach question time Bristol, or just Sign up for this event.
I'd change 'Registering for' to 'Event details'.
I think the grey box should just have the name, the date, the time and whether it's happening in person or online. Maybe we could just remove "Train to teach event" and the "Your attendance will be..." from below the first purple line and show either the laptop/online icon and "Online event" or the people icon and the address?

Took another crack at this. Followed Tom's suggestions but made the 'Event details' look more like the GOV.UK caption pattern. The 'Event details' is still inside the <h4> so a screen reader should read it out in one sentence.

Not sure we can change the text next to the checkboxes without doing it across the other event pages/components too.
We could make this better if the title wasn't three bits of information concatenated.

This looks better - thanks @Tomcowan1 and @peteryates!
Only comments are:

In the latest version, the grey box changes from 'Event details' on desktop to 'Sign up for' on mobile - is this necessary, particularly if we have 'Sign up for...' in the h1 as well?

I still think the heading levels are an issue @peteryates - we are skipping levels as we only have an h1 and an h4 on the page (and the h4 come first in the source?)

Do we now need to review the headings for the other steps?

Agree that doubling up on "Sign up for" is superfluous, here's how it looks with the text above removed:

On mobile, there is no heading above the <h1>, that's just strong text. Not really sure what's best when it comes to content above the main heading, never done it before.
I think the other pages of the wizard should be reviewed. If this was a regular GOV.UK service the page headings would be descriptive of the content and we'd be telling the user why we're asking for certain bits of information.
For example.

GIT
School Experience

Agree it looks a lot better, and agree to get rid of "sign up for" on the mobile banner. I don't think it looks bad in the grey box (h level heading conversation not withstanding).
Happy to take a look at the other headings. I think they're always the same "Sign up for this event: Train to teach London", but that should be in line with the Gov.uk style guides. Is that something to look at in this piece of work, or separately?

Demoed to the Events team - one minor update needed to text as per suggestion
FROM: We'll only use this to let you know about any last-minute cancellations.
TO: We'll use this to send you a reminder and let you know about any last-minute cancellations.
Once this is done, we can put live.

Looks good to me - happy for this to be merged!


Create a document with instructions on how to integrate with vimspector

This is a self-contained set of instructions to get people up and
running with vimspector using puppet-debugserver.
This was discussed in https://github.com/puppetlabs/puppet-vscode/issues/719#issuecomment-770245856

FYI while writing this I tested my setup again to make sure that the instructions are working and I had to correct some details in the vimspector wiki. But I'm still unable to get a connection up and running with puppet-debugserver. I'll have to figure out why and make corrections to the instructions so that they will work from start to finish.

Great work so far! We can iterate as you fine tune the installation steps. Look forward to getting this in


npm wrong name of node_modules folder

Describe your problem and how to reproduce it:
In this chalange the said node_modules folder name  is nodemodules and next node module  the correct folder name locally and globally is node_modules
Add a Link to the page with the problem:
https://learn.freecodecamp.org/apis-and-microservices/managing-packages-with-npm

@malbarmawi this issue has been fixed but the corrected file hasn’t been pushed to production yet, until then this issue will show up in the site.


refactor class names from camel case to kebab case

I am a criminal for mixing up cases especially with classes. The task here is to change all class names that are camel case to kebab case.

Just to confirm are we are you wanting css classes or javascript classes?

Just to confirm thats css classes?

I am a criminal for mixing up cases especially with classes. The task here is to change all class names that are camel case to kebab case.

Am curious... Why to kebab case?

It is common convention used and matches with the CSS properties e.g font-weight, background-color
Here is a link with more info: https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/

thanks @sourcediz  that is correct. I've gone through your PR. Thanks for your contribution!

It is common convention used and matches with the CSS properties e.g font-weight, background-color
Here is a link with more info: https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/

I see, yeah, for CSS it makes perfect sense, in my mind I was thinking class name as for objects in OOP. Good move 👍


bug(sbb-datepicker): language change not reflected in weekdays

When changing document language, the weekdays translations should change too

Fixed by #1925


Lookout migration init

Codecov Report
Base: 70.22% // Head: 67.22% // Decreases project coverage by -3.01% :warning:

Coverage data is based on head (99b61bd) compared to base (63ced7d).
Patch coverage: 60.74% of modified lines in pull request are covered.

:exclamation: Current head 99b61bd differs from pull request most recent head a43a230. Consider uploading reports for the commit a43a230 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   70.22%   67.22%   -3.01%
==========================================
  Files          11       12       +1
  Lines        1518     1681     +163
==========================================
+ Hits         1066     1130      +64
- Misses        354      456     +102
+ Partials       98       95       -3

Impacted Files
Coverage Δ

controllers/install/eventingester_controller.go
78.66% <40.00%> (-0.11%)
:arrow_down:

controllers/install/lookout_controller.go
42.32% <57.00%> (-36.78%)
:arrow_down:

controllers/install/binoculars_controller.go
80.27% <70.00%> (+18.83%)
:arrow_up:

controllers/builders/generate_config.go
100.00% <100.00%> (ø)

controllers/builders/service_account.go
100.00% <100.00%> (ø)

controllers/install/armadaserver_controller.go
52.15% <100.00%> (-1.97%)
:arrow_down:

controllers/install/executor_controller.go
74.71% <100.00%> (+0.69%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Can this technique be reliably used against Components?

Really interested in the technique being used here, and I am curious if this could also be extended for use against Components. I wrote a HOC to experiment with the idea, using the same demo code as the README, using Components instead of functions:
import React, { Component, cloneElement } from 'react';
import immutagen from 'immutagen';

const compose = ({ value, next }) => next
  ? cloneElement(value, null, values => compose(next(values)))
  : value;

export default UnyieldableComponent => {
  const generator = immutagen(UnyieldableComponent.prototype.render);

  UnyieldableComponent.prototype.render = function() {
    return compose(generator(this.props));
  };

  return class YieldableComponent extends Component {
    render() {
      return <UnyieldableComponent {...this.props} />;
    }
  };
};

// used as legacy decorator, but can use as HOC as well
@withGeneration
export default class App extends Component {
  * render() {
    console.log('Rendering again!');
    const { loading, data } = yield <Query />;
    const { time } = yield <Time/>;

    if (loading) {
      return
Loading
;
    }

    const {
      values,
      touched,
      errors,
      handleChange,
      handleBlur,
      handleSubmit,
      isSubmitting,
    } = yield (
      <WrapFormik
        initialValues={{
          // Use data from other HOCs!
          email: data.user.email,
          password: '',
        }}
        validate={values => {
          // same as above, but feel free to move this into a class method now.
          let errors = {};

          if (!values.email) {
            errors.email = 'Required'
          } else if (
            !/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.test(values.email)
          ) {
            errors.email = 'Invalid email address';
          }

          return errors;
        }}
      />
    );

    return (

{`Hello, ${data.user.name}`}

The time is {time.toLocaleString()}!

        <form onSubmit={handleSubmit}>
          <input
            type="email"
            name="email"
            onChange={handleChange}
            onBlur={handleBlur}
            value={values.email}
          />
          {touched.email && errors.email &&
{errors.email}
}
          <input
            type="password"
            name="password"
            onChange={handleChange}
            onBlur={handleBlur}
            value={values.password}
          />
          {touched.password && errors.password &&
{errors.password}
}
          <button type="submit" disabled={isSubmitting}>
            Submit
          </button>
        </form>

    );
  }
}

It seemed to work pretty well; do you see any concerns with this approach?

One thing that needs to be ironed out is accessing this within render. I'm sure a call(this needs to happen somewhere, but not sure where. :smile:

Yeah, this is one of the reasons I always prefer to use functional components.
I fear that it can add more margin for errors for beginners too 🤔

One thing that needs to be ironed out is accessing this within render.

I have solved this and updated the original post by caching the generator at first render with a binding.


How do i make a pulse like the one on the readme with multiple pulses?

Hey @Hsanka6 sorry for the late reply! Currently it's not implemented in this branch, feel free to add the feature.
Otherwise a workaround would be triggering the same pulse multiple times with a small delay I guess.


Validate and force short hostname if one has fqdn in the inventory file

Validate

Adding this will make the whole play fail if there is an error.

This makes the population work if one has full hostnames like below in the inventory file.

There will be errors if the nodes are not using a "shortened name" - if in the inventory one has like this:

[grid]
io-grid.fgci.csc.fi int_ip_addr=<IP_ADDRESS> ext_ip_addr=<IP_ADDRESS>

command output:

$ nodeattr --parse-check -f /etc/genders ; echo $?
Line 1: node not a shortened hostname
Line 3: node not a shortened hostname
Line 7: node not a shortened hostname
Line 8: node not a shortened hostname
Line 9: node not a shortened hostname
Line 10: node not a shortened hostname
Line 11: node not a shortened hostname
nodeattr: 7 parse errors discovered
7

ansible output:

TASK [ansible-role-pdsh-genders : populate genders file] ***********************
fatal: [io-install.fgci.csc.fi]: FAILED! => {"changed": true, "exit_status": 7, "failed": true, "msg": "failed to validate", "stderr": "Line 1: node not a shortened hostname\nLine 3: node not a shortened hostname\nLine 7: node not a shortened hostname\nLine 8: node not a shortened hostname\nLine 9: node not a shortened hostname\nLine 10: node not a shortened hostname\nLine 11: node not a shortened hostname\nnodeattr: 7 parse errors discovered\n", "stdout": "", "stdout_lines": []}

Thanks for the patch!
Shortening the hostnames is of course potentially problematic, although I guess in practice it'll work out just fine.

Np!
Maybe one could contact the maintainers, seems the source code has moved around so not sure where is best.
For being sure one could use the ansible_hostname or the hostvar which has the short version, but I think one has to grab the facts then, which is slow.

I think genders currently lives at https://github.com/chaos/genders .
I filed https://github.com/chaos/genders/issues/15 , lets see what they say..


Padlock pipeline

I have integrated into the code the refactoring, however, the tests still need to be adjusted.
Please check if the code is running smoothly also for you

Looks good to me.


Error: Resource is not in the state tasksStopped

I'm always receiving the following error:
Error: Resource is not in the state tasksStopped
The task manages to launch properly and execute, but the action fails instantaneously.
This is the task definition that I'm using:
{
    "taskDefinition": {
        "taskDefinitionArn": "arn:aws:ecs:****:***:task-definition/migration:1",
        "containerDefinitions": [
            {
                "name": "migration",
                "image": "**************",
                "cpu": 1024,
                "memory": 2048,
                "portMappings": [
                    {
                        "containerPort": ****,
                        "hostPort": ****,
                        "protocol": "tcp"
                    }
                ],
                "essential": true,
                "command": [
                    "/start"
                ],
                "environment": [
                    ********
                ],
                "mountPoints": [
                    {
                        "sourceVolume": "******",
                        "containerPath": "/app/media"
                    }
                ],
                "volumesFrom": [],
                "secrets": [
                    ***
                ],
                "logConfiguration": {
                    "logDriver": "awslogs",
                    "options": {
                        "awslogs-create-group": "true",
                        "awslogs-group": "**********",
                        "awslogs-region": "**********",
                        "awslogs-stream-prefix": "*************"
                    }
                }
            }
        ],
        "family": "migration",
        "taskRoleArn": "arn:aws:iam::***:role/***********",
        "executionRoleArn": "arn:aws:iam::***:role/**********",
        "networkMode": "awsvpc",
        "revision": 1,
        "volumes": [
            {
                "name": "******",
                "efsVolumeConfiguration": {
                    "fileSystemId": "fs-********",
                    "rootDirectory": "/",
                    "transitEncryption": "ENABLED",
                    "authorizationConfig": {
                        "accessPointId": "fsap-*******",
                        "iam": "ENABLED"
                    }
                }
            }
        ],
        "status": "ACTIVE",
        "requiresAttributes": [
            {
                "name": "ecs.capability.execution-role-awslogs"
            },
            {
                "name": "com.amazonaws.ecs.capability.ecr-auth"
            },
            {
                "name": "com.amazonaws.ecs.capability.task-iam-role"
            },
            {
                "name": "ecs.capability.execution-role-ecr-pull"
            },
            {
                "name": "ecs.capability.secrets.ssm.environment-variables"
            },
            {
                "name": "com.amazonaws.ecs.capability.docker-remote-api.1.18"
            },
            {
                "name": "ecs.capability.task-eni"
            },
            {
                "name": "com.amazonaws.ecs.capability.docker-remote-api.1.29"
            },
            {
                "name": "com.amazonaws.ecs.capability.logging-driver.awslogs"
            },
            {
                "name": "ecs.capability.efsAuth"
            },
            {
                "name": "com.amazonaws.ecs.capability.docker-remote-api.1.19"
            },
            {
                "name": "ecs.capability.efs"
            },
            {
                "name": "com.amazonaws.ecs.capability.docker-remote-api.1.25"
            }
        ],
        "placementConstraints": [],
        "compatibilities": [
            "EC2",
            "FARGATE"
        ],
        "requiresCompatibilities": [
            "FARGATE"
        ],
        "cpu": "1024",
        "memory": "2048",
        "registeredAt": "2021-**-**T20:**:**.***000+00:00",
        "registeredBy": "arn:aws:iam::***:user/**********"
    }
}

this could likely mean that ecs has some issue running your task.

@noelzubin Actually the problem is that the action runs the ECS task successfully, but the action fails just after that.
This would mean that it runs line 65 but fails after that.

Perhaps could you check what the task status is for task that has finished in the ECS Console ?
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/stopped-task-errors.html

@noelzubin I managed to fix it, I was missing the ecs:DescribeTask permission.
It would be a nice addition to the README.

@noelzubin I managed to fix it, I was missing the ecs:DescribeTask permission.

Same here, thanks for posting. This was a huge timesaver! One note for those stumbling upon this -- I believe the correct permission is ecs:DescribeTasks (plural).


Properly address units in PintPulsar position

This fixes #363
By using astropy.units to convert to units.rad, it doesn't matter what units PINT returns, the position is read in radians.

Also note that the designmatrix and model parameter units are not addressed by this PR. That is a separate issue that should be addressed in a more comprehensive PR

This one depends on #382 for the added test to pass. So @tcromartie, this last test I added was missing (uncovered lines). If it had been there from the start, your PR #382 would have never been happening.
Other than that, this PR is ready


Alternate headings for plotDimReduceFeature?

In plotDimReduceFeature, the headings for each of the little plots matches the names of the features that you give it. A lot of times this is the ensembl gene ID, which isn't all that useful to look at.
Is it possible to also give the function a list of headings that correspond to the features? It would be nice to be able to easily make the plots with the gene symbol as the headings rather then the ensembl id.

#182


Use languageclient for CallHierarchy

The call hierarchy implementation has moved to atom-languageclient. (https://github.com/atom-community/atom-languageclient/pull/172)


Phase 1d: Shaka Lab Node on macOS

Just this PR and one more to merge before we all leave for the holidays.


Potential error in llff data loading weights/reprojection_error

In your updated code, you are reading the reprojection error. But the dataloader is not updated for the same.

Thanks for pointing that out! You can use the dataset here


As a reporter I want to click "View Details" in the action column to view a read-only version of a submitted report

Description:
This card was split out of #229. Please refer to the contents of that card for further context.
This card is pending a decision on how to display a read-only version of the report to the user (UX).
blocked by #249
Acceptance Criteria:
Given I am on my operator's operation table
When I have submitted a report for that operation
And I click on "View Details" in the Action column
Then I am directed to a read-only version of that report
Development Checklist:

[ ] View Details link in the Action column of the operation table
[ ] Read-only version of the report (details on this TBD)
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Given that for the "Final Review" page, the decision is to do a read-only version page by page (instead of 1 very long page) Figma then to be consistent, that display should be applied here as well.
Does this resolve the "This card is pending a decision on how to display a read-only version of the report to the user (UX)." or do we have more design decisions to make?


ivy +fuzzy search is slow on large project

Hello! When using SPC SPC file search with (ivy +fuzzy) on a repo with 200K files (my work's corporate monorepo), the file filtering chugs to a halt as you type for about 15 seconds.
I have ripgrep and fd installed and on my PATH.
fzf.vim handles the same repo like a dream. Is there something I need to do to get usable file finding?

Hello,
As you seem to have fzf in path you can bind SPC SPC to counsel-fzf it might help, but unsure.
The reason ivy is slow here is that counsel has to gather the whole list to start filtering. It seems that fzf is able to stream the file list so that you get immediate results as soon as some filenames are coming. FZF was not initially built to be integrated in anything other than fzf, I don't know how far integration went.
But worst case scenario, you can install fzf.el and use this instead, it basically spawns a shell in a terminal that launches fzf just to select a file. You get the same speed as anything else with it, at the cost of not being integrated with the complete ivy/counsel experience.

+fuzzy is very slow on large projects - this is an issue w/ the module (flx) that is used. I suggest using +prescient instead which provides similar functionality and is much faster.

Tried suggestions:

counsel-fzf still takes 10 seconds between each input update
+prescient is still extremely slow and not usable
fzf.el seems to work well, I'll try to get it to open in a split with ctrl + x and ctrl + v like fzf.vim

counsel-fzf still spawns a new fzf process at each input yeah, so it's going to be slow... You can play with fzf/args variable to set these behaviour maybe ?

counsel-fzf still spawns a new fzf process at each input

Yeah that's not going to work unfortunately. It needs to be an interactive filter or bust.

+prescient is still extremely slow and not usable

That's really strange! In my experience, on giant repos (16-30k files) prescient is fine, being nearly instantaneous. While flx is very slow. Maybe something else is going wrong with your setup.

+prescient is still extremely slow and not usable

Okay, I see you're at 200k files. It is instant for me but the largest repo I have is around 30k files.
It might be worth opening an issue w/ the counsel repo to see if counsel-fzf can be sped up.
This would be a great improvement to have in doom I think.