Cannot read command line arguments

Created a new Azure Function with .NET 8 Isolated Worker.
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <AzureFunctionsVersion>v4</AzureFunctionsVersion>
    <OutputType>Exe</OutputType>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.20.1" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" Version="1.1.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.1.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="1.16.4" />
  </ItemGroup>
  <ItemGroup>
    <None Update="host.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </None>
    <None Update="local.settings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <CopyToPublishDirectory>Never</CopyToPublishDirectory>
    </None>
  </ItemGroup>
  <ItemGroup>
    <Using Include="System.Threading.ExecutionContext" Alias="ExecutionContext" />
  </ItemGroup>
</Project>

launchSettings.json
{
  "profiles": {
    "FunctionApp1": {
      "commandName": "Project",
      "commandLineArgs": "--port 7106 --key1 10000"
    }
  }
}

Note the key1.
Program.cs
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Hosting;

var host = new HostBuilder()
	.ConfigureFunctionsWorkerDefaults()

	/* This doesn't work */
	//.ConfigureAppConfiguration(builder =>
	//{
	//	builder
	//		.AddCommandLine(Environment.GetCommandLineArgs())
	//		.AddEnvironmentVariables();
	//})

	/* This works, but it has to be read from command line, not hard-coded */
	//.ConfigureAppConfiguration(builder =>
	//{
	//	builder
	//		.AddCommandLine(x =>
	//		{
	//			x.Args = new[] { "--key1", "value1", "--key2", "value2" };
	//		})
	//		.AddEnvironmentVariables();
	//})

	.ConfigureServices((context, services) =>
	{
		int? x = context.Configuration.GetValue<int?>("key1"); // This should not be null

                IConfiguration configuration = services.BuildServiceProvider().GetRequiredService<IConfiguration>();
		int? y = configuration.GetValue<int?>("key1"); // This should not be null
	})
	.Build();

host.Run();

Here the key1 is null, but it should be not null.

Don't think we even need to AddCommandLine explicitly (through ConfigureAppConfiguration), because ConfigureFunctionsWorkerDefaults is documented to be doing so. I checked the code, it does that.

Verbose Logging
[2024-01-24T16:06:56.003Z] Found C:\Users\Jaliya\Desktop\FunctionApp1\FunctionApp1\FunctionApp1.csproj. Using for user secrets file configuration.
[2024-01-24T16:06:56.286Z] Building host: version spec: , startup suppressed: 'False', configuration suppressed: 'False', startup operation id: '7d114379-c764-44ce-81e0-573a1c3bc416'
[2024-01-24T16:06:56.293Z] Reading host configuration file 'C:\Users\Jaliya\Desktop\FunctionApp1\FunctionApp1\bin\Debug\net8.0\host.json'
[2024-01-24T16:06:56.295Z] Host configuration file read:
[2024-01-24T16:06:56.296Z] {
[2024-01-24T16:06:56.296Z]   "version": "2.0",
[2024-01-24T16:06:56.297Z]   "logging": {
[2024-01-24T16:06:56.298Z]     "applicationInsights": {
[2024-01-24T16:06:56.298Z]       "samplingSettings": {
[2024-01-24T16:06:56.299Z]         "isEnabled": true,
[2024-01-24T16:06:56.299Z]         "excludedTypes": "Request"
[2024-01-24T16:06:56.300Z]       },
[2024-01-24T16:06:56.301Z]       "enableLiveMetricsFilters": true
[2024-01-24T16:06:56.302Z]     }
[2024-01-24T16:06:56.303Z]   }
[2024-01-24T16:06:56.311Z] }
[2024-01-24T16:06:56.326Z] Extension Bundle not loaded. Loading extensions from C:\Users\Jaliya\Desktop\FunctionApp1\FunctionApp1\bin\Debug\net8.0. BundleConfigured: False, PrecompiledFunctionApp: False, LegacyBundle: False, DotnetIsolatedApp: False, isLogicApp: False
[2024-01-24T16:06:56.328Z] Script Startup resetting load context with base path: 'C:\Users\Jaliya\Desktop\FunctionApp1\FunctionApp1\bin\Debug\net8.0\.azurefunctions'.
[2024-01-24T16:06:56.344Z] Loading startup extension 'DurableTask'
[2024-01-24T16:06:56.389Z] Loaded extension 'DurableTask' (<IP_ADDRESS>)
[2024-01-24T16:06:56.399Z] Loading startup extension 'Startup'
[2024-01-24T16:06:56.401Z] Loaded extension 'Startup' (<IP_ADDRESS>)
[2024-01-24T16:06:56.411Z] Reading host configuration file 'C:\Users\Jaliya\Desktop\FunctionApp1\FunctionApp1\bin\Debug\net8.0\host.json'
[2024-01-24T16:06:56.416Z] Host configuration file read:
[2024-01-24T16:06:56.417Z] {
[2024-01-24T16:06:56.417Z]   "version": "2.0",
[2024-01-24T16:06:56.418Z]   "logging": {
[2024-01-24T16:06:56.419Z]     "applicationInsights": {
[2024-01-24T16:06:56.420Z]       "samplingSettings": {
[2024-01-24T16:06:56.421Z]         "isEnabled": true,
[2024-01-24T16:06:56.422Z]         "excludedTypes": "Request"
[2024-01-24T16:06:56.422Z]       },
[2024-01-24T16:06:56.424Z]       "enableLiveMetricsFilters": true
[2024-01-24T16:06:56.424Z]     }
[2024-01-24T16:06:56.425Z]   }
[2024-01-24T16:06:56.426Z] }
[2024-01-24T16:06:56.796Z] Using the default storage provider: AzureStorage.
[2024-01-24T16:06:57.338Z] Initializing Warmup Extension.
[2024-01-24T16:06:57.346Z] Resolved secret storage provider BlobStorageSecretsRepository
[2024-01-24T16:06:57.472Z] Durable extension configuration loaded: {"httpSettings":{"defaultAsyncRequestSleepTimeMilliseconds":30000},"hubName":"TestHubName","storageProvider":{"connectionName":null,"connectionStringName":null,"controlQueueBatchSize":32,"partitionCount":4,"controlQueueBufferThreshold":256,"controlQueueVisibilityTimeout":"00:05:00","workItemQueueVisibilityTimeout":"00:05:00","trackingStoreConnectionName":null,"trackingStoreConnectionStringName":null,"trackingStoreNamePrefix":null,"fetchLargeMessagesAutomatically":true,"maxQueuePollingInterval":"00:00:30","useLegacyPartitionManagement":false},"tracing":{"traceInputsAndOutputs":false,"allowVerboseLinuxTelemetry":false,"traceReplayEvents":false,"distributedTracingEnabled":false,"distributedTracingProtocol":"HttpCorrelationProtocol"},"notifications":{"eventGrid":null},"maxConcurrentActivityFunctions":160,"maxConcurrentOrchestratorFunctions":160,"localRpcEndpointEnabled":null,"maxEntityOperationBatchSize":5000,"extendedSessionsEnabled":false,"extendedSessionIdleTimeoutInSeconds":30,"maxOrchestrationActions":100000,"overridableExistingInstanceStates":"NonRunningStates","entityMessageReorderWindowInMinutes":30,"useGracefulShutdown":false,"rollbackEntityOperationsOnExceptions":true,"useAppLease":true,"storeInputsInOrchestrationHistory":false,"appLeaseOptions":{"renewInterval":"00:00:25","acquireInterval":"00:05:00","leaseInterval":"00:01:00"}}. HubName: TestHubName. AppName: . SlotName: . ExtensionVersion: 2.9.6.
[2024-01-24T16:06:57.536Z] Opened local gRPC endpoint: http://localhost:4001. InstanceId: . Function: . HubName: TestHubName. AppName: . SlotName: . ExtensionVersion: 2.9.6. SequenceNumber: 0.
[2024-01-24T16:06:57.575Z] Initializing Host. OperationId: '7d114379-c764-44ce-81e0-573a1c3bc416'.
[2024-01-24T16:06:57.585Z] Host initialization: ConsecutiveErrors=0, StartupCount=1, OperationId=7d114379-c764-44ce-81e0-573a1c3bc416
[2024-01-24T16:06:57.628Z] Loading functions metadata
[2024-01-24T16:06:57.631Z] Worker indexing is enabled
[2024-01-24T16:06:57.636Z] Fetching metadata for workerRuntime: dotnet-isolated
[2024-01-24T16:06:57.637Z] Reading functions metadata (Worker)
[2024-01-24T16:07:23.366Z] {
[2024-01-24T16:07:23.368Z]   "ProcessId": 36208,
[2024-01-24T16:07:23.371Z]   "RuntimeIdentifier": "win-x64",
[2024-01-24T16:07:23.372Z]   "WorkerVersion": "<IP_ADDRESS>",
[2024-01-24T16:07:23.373Z]   "ProductVersion": "1.16.0\u002Bbef360980a5f26c2ec6b2bd2977c3ca4a715d066",
[2024-01-24T16:07:23.375Z]   "FrameworkDescription": ".NET 8.0.1",
[2024-01-24T16:07:23.376Z]   "OSDescription": "Microsoft Windows 10.0.22621",
[2024-01-24T16:07:23.377Z]   "OSArchitecture": "X64",
[2024-01-24T16:07:23.379Z]   "CommandLine": "C:\\Users\\Jaliya\\Desktop\\FunctionApp1\\FunctionApp1\\bin\\Debug\\net8.0\\FunctionApp1.dll --host <IP_ADDRESS> --port 34427 --workerId c36f71db-ee12-4423-9dd3-286655a287b0 --requestId 852778f8-75d5-40f8-9c5f-04c181f3e590 --grpcMaxMessageLength<PHONE_NUMBER> --functions-uri http://<IP_ADDRESS>:34427/ --functions-worker-id c36f71db-ee12-4423-9dd3-286655a287b0 --functions-request-id 852778f8-75d5-40f8-9c5f-04c181f3e590 --functions-grpc-max-message-length<PHONE_NUMBER>
[2024-01-24T16:07:23.380Z] }

The command line args from your launchsettings will be used for starting the functions host. The functions host process is the one starts your app dll (FunctionApp1.dll), Host will not flow all the commnad line args for func process to the function app(language worker) process.
I am curious to know your use case where you want to pass additional command line arguments to FunctionApp1. Can you elaborate and we can figure out a way to make that happen.

@kshyju,
Thanks for the reply.
We are in the process of migrating .NET 6 In-Process Durable Function App to .NET 8 Isolated. We have a suite of integration tests where we spin up the application using process start: func start. And there we are passing some arguments, so the app uses the correct services when starting up (using a test database etc).

And shouldn't we be able to pass command line arguments? This is a breaking change, isn't it?

Not a breaking change, as this was never exposed before with this model, but as far as this being a gap between isolated and the in-proc model, this is not something that works end-to-end with in-proc today.
While you'd be able to define command line arguments for local runs, there's no mechanism that enables you to do the same for deployed code, so if code is written to directly depend on command line arguments being passed, it wouldn't work once the app is deployed.
Are you able to flow that configuration using different mechanisms/configuration sources (e.g., environment variables or appsettings/JSON configuration) ?

Thanks @fabiocav,

Not a breaking change, as this was never exposed before with this model, but as far as this being a gap between isolated and the in-proc model, this is not something that works end-to-end with in-proc today.

I agree, it's a gap between in-process and isolated.

While you'd be able to define command line arguments for local runs, there's no mechanism that enables you to do the same for deployed code, so if code is written to directly depend on command line arguments being passed, it wouldn't work once the app is deployed.

Currently, the integration tests are run locally only.

Are you able to flow that configuration using different mechanisms/configuration sources (e.g., environment variables or appsettings/JSON configuration)?

Yes, for the time being, in the project I have changed to pass environment variables through Process Start.
var appInfo = new ProcessStartInfo("func", $"start --port {port}")
{
	UseShellExecute = false,
	CreateNoWindow = true,
	WorkingDirectory = projectDirectory.FullName,
	EnvironmentVariables =
	{
		["IsRunningIntegrationTests"] = "true" // This works
	}
};

Thanks for the confirmation guys.
However, I'd think this is misleading. May be we want to update the documentation, it's only for In-Process.


Can't change text to white

Video: https://www.loom.com/share/9b21c56bf0d44467abc0666803a0adef?sid=d79f6d43-5c88-402b-bd59-b0a5d04bb2c9
Description
Expected Behavior: Can select text and then change color to white
Bug: Can choose white, dialog disappears but white color is not applied. Happens with other colors
Reproducible: Yes (Tried 8 times).

Hi, there has been some regression lately, which should be fixed with #8012 soon.
For a workaround, just select an element and change a colour (single click - no double-click nor enter, which enters the text editing mode).

Duplicate of #8249.


Adding support to read only properties, inheritance attributes and IgnorePrimaryConstructorAttribute

Adding support to read only properties and inheritance attributes
Implementing IgnorePrimaryConstructorAttribute and adding Namespace to Attributes

Super cool thank you

Can you publish a new version on NuGet please?

publish v1.3, I did some modification

I still remove namespace from Attribute (avoid breaking changes & attributes for source generator in many packages also not have namespace)
Generate based type injection will be done only when based type annotate with [PrimaryConstructor] only


gcsfs 2022.8.2 does not work with pyarrow.fs.copy_files (earlier versions work)

When using gcsfs 2022.8.2 with pyarrow.fs.copy_files, we run into the following error:
Traceback (most recent call last):
  File "scratch2.py", line 6, in <module>
    pyarrow.fs.copy_files("gs://bucket/subdir", "/tmp/somewhere", source_filesystem=fs)
  File "/Users/kai/.pyenv/versions/3.7.7/lib/python3.7/site-packages/pyarrow/fs.py", line 246, in copy_files
    chunk_size, use_threads)
  File "pyarrow/_fs.pyx", line 1229, in pyarrow._fs._copy_files_selector
  File "pyarrow/error.pxi", line 99, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: GetFileInfo() yielded path 'bucket/nested', which is outside base dir 'gs://bucket/nested/subdir'

Reproduction script:
import pyarrow.fs

from gcsfs import GCSFileSystem

fs = pyarrow.fs.PyFileSystem(pyarrow.fs.FSSpecHandler(GCSFileSystem()))
pyarrow.fs.copy_files(
    "bucket/nested/subdir",
    "/tmp/somewhere",
    source_filesystem=fs)

The same code works fine with gcsfs 2022.7.1 and earlier.
Confirmed this does not work with pyarrow 6, 7, 8, and 9.

While I agree that this ought to work and we should fix it, I wonder why you don't do:
gcs = GCSFileSystem()
gcs.get("gs://bucket/subdir", "/tmp/somewhere", recursive=True)

Also, the error message, which is not too clear, suggests that removing "gs://" from the input URL might fix this.

Probably a moot point, but fsspec.generics is also designed to have a single API entrypoint for working with multiple filesystems by URL. It only currently has cat, not get, though (would be super simple to add).

Ah I've just checked and we're actually not using the gs:// prefix in our implementation. It works with one subdir, but it fails with nested subdirs:
import pyarrow.fs

from gcsfs import GCSFileSystem

fs = pyarrow.fs.PyFileSystem(pyarrow.fs.FSSpecHandler(GCSFileSystem()))
pyarrow.fs.copy_files(
    "bucket/nested/subdir",
    "/tmp/somewhere",
    source_filesystem=fs)

I've updated the original issue.
For the fsspec.generics, I believe the pyarrow standardization is too ubiquitous in Ray so we will probably stick with it for now, but thanks for letting me know!

Ah, so specifically, it looks like it is trying to get the info on the directory prior to trying to copy it? I am puzzled that the exception refers to "gs://bucket/nested/subdir", even though that was not in the invocation. I wonder whether this is just a string manipulation thing on their side.
Could you please turn on logger "gcsfs" to see if there is any additional information
fsspec.utils.setup_logging(logger_name="gcsfs")

Output (replaced actual bucket name with bucket):
2022-09-26 17:27:43,601 - gcsfs.credentials - DEBUG - connect -- Connected with method google_default
2022-09-26 17:27:43,609 - gcsfs - DEBUG - _call -- GET: b/{}/o/{}, ('bucket', 'nested/subdir'), None
2022-09-26 17:27:43,609 - gcsfs.credentials - DEBUG - maybe_refresh -- GCS refresh
2022-09-26 17:27:43,901 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), None
2022-09-26 17:27:44,269 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), None
Traceback (most recent call last):
  File "scratch2.py", line 12, in <module>
    source_filesystem=fs)
  File "/Users/kai/.pyenv/versions/3.7.7/lib/python3.7/site-packages/pyarrow/fs.py", line 247, in copy_files
    chunk_size, use_threads)
  File "pyarrow/_fs.pyx", line 1258, in pyarrow._fs._copy_files_selector
  File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: GetFileInfo() yielded path 'bucket/nested', which is outside base dir 'bucket/nested/subdir'

This is a different and more puzzling message!
Would you mind changing the logging line below as follows:
-         logger.debug(f"{method.upper()}: {path}, {args}, {kwargs.get('headers')}")
+         logger.debug(f"{method.upper()}: {path}, {args}, {kwargs}")

and trying again? That should tell us the specific prefixes that are being passed.

Sure:
In 2022.8.2 (not working)
2022-09-27 10:35:44,270 - gcsfs.credentials - DEBUG - connect -- Connected with method google_default
2022-09-27 10:35:44,273 - gcsfs - DEBUG - _call -- GET: b/{}/o/{}, ('bucket', 'nested/subdir'), None
2022-09-27 10:35:44,274 - gcsfs.credentials - DEBUG - maybe_refresh -- GCS refresh
2022-09-27 10:35:44,587 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), None
2022-09-27 10:35:44,708 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), None

In 2022.7.1 (working)
2022-09-27 10:34:24,349 - gcsfs.credentials - DEBUG - connect -- Connected with method google_default
2022-09-27 10:34:24,356 - gcsfs - DEBUG - _call -- GET: b/{}/o/{}, ('bucket', 'nested/subdir'), {}
2022-09-27 10:34:24,357 - gcsfs.credentials - DEBUG - maybe_refresh -- GCS refresh
2022-09-27 10:34:24,782 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), {'delimiter': '/', 'prefix': 'nested/subdir/', 'maxResults': None}
2022-09-27 10:34:24,958 - gcsfs - DEBUG - _call -- GET: b/{}/o, ('bucket',), {'delimiter': None, 'prefix': 'nested/subdir/', 'maxResults': None}


Wrong publish path

Hi,
I noticed that the command php artisan vendor:publish --tag=wire-extender published the wire-extender.js to the wrong folder.
According to your documentation it should be in public/vendor/wire-elements/js, but the command publishes it in public/vendor/wire-elements.
Changing WireExtenderServiceProvider.php fixed it for me:
// Line 29
// From:
__DIR__.'/../js' => public_path('vendor/wire-elements'),
// To
__DIR__.'/../js' => public_path('vendor/wire-elements/js'),

Thanks! I've updated the docs instead so it can remain to be vendor/wire-elements.


[data types] Bloqs which work for multiple types

As part of #446 we will need to update the signatures of several arithmetic bloqs to allow for some generic behavour.
One way to do this is
class Add(bloq):
    dtype: QDType

    @dtype.validator(self):
        assert isinstance(dtype, (QInt, QUInt, ...))

This will happen after the migration work. We should initially only sort generic type variables for bloqs which actually test them for different types. We would also need to handle classical simulation #607 #606

I think I asked during the design review whether we'd need abstract qdtypes. Specifically: a named-but-not-instantiatable type to replace (QInt, QUint, ...) in the isinstance check (and appropriate for the attrs type annotation)

right, that is the plan once we sort of land on what bloqs work on which types.


Status query endpoint for Known

I'd like to help Known improve their Bridgy Connect UX (parallel issues here). The first step was easy: add query params for {"result": "success", "user": user-id} to the callback.
I need a little guidance on the second step: how can they check in the future if the user is still connected in Bridgy. Thinking a couple of options:

Add microformats classes to the user pages. The user page could reasonably be an h-card but basically all of the properties would be p-bridgy-something. Stuff like, p-bridgy-last-polled, p-bridgy-listen-status, p-bridgy-publish-status, p-bridgy-warning-message...

Support ?format=json on the user page endpoint, and return a json message. This seems easiest, but I really don't want to accidentally create a crappy piecemeal Bridgy REST API.

huh. interesting!
i honestly don't know which i prefer, and i don't feel too strongly. i also think they're both about the same difficulty/effort. feel free to propose something!

oh btw you can use github's native comment linking across projects with eg idno/Known#843.

I'm leaning microformats now. less because I have drunk the mf2 koolaid, and more because I think it will be a less invasive change to the code.

sgtm! btw there's a prefix for nonstandard mf2 extension classes. I've forgotten it but i know @aaronpk uses it.

thanks! and hehe, you can use -x- if you want to research/document your experimental use, or -appSpecificPrefix- if you don't. Aaron uses p-p3k- on e.g. http://aaronparecki.com/metrics

Closing now, thanks for your help!


Update section "Creating an annotation task" in User Guide

Motivation and context

Resolved #3164
This PR add section "task details"  for reduce section "creating an annotation task"
Fix pointers on image131_detrac.jpg
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@TOsmanov , could you please fix linter errors?

@TOsmanov , could you please resolve conflicts? Roman fixed a lot of spell errors.


FR: OSGI Metadata Support

Is it possible to make the Firebase Admin SDK compatible with OSGI ?
The minimal requirements would be to add OSGI metadata to the manifest.
To go further, you could rely on the OSGI service model, here is a project example :

In this project the API was redefined to not expose internal classes to consumers, the implementation is based on the version 5.2.0 of firebase and can be configured in an OSGI way.
The avantage of this will be firstly to support a new runtime environment, and secondly, if you go further, to minimize the impact on the consumer bundles.

Here is the project : https://github.com/cdecode/org.cdecode.firebase

We can add the required OSGi bundle headers  to the build artifact (perhaps you can help us with that by providing a patch).

Some of the dependencies are not bundles. They will have to be included in the firebase artifact or they can be converted to bundles in another module and released together with firebase.
Also, note that all packages will be exported (public) and so must be consistently versionned.


1.19.2 Backport

Really small changes, most notably the bucket is now at the end of the Misc item group

Thank you for the PR!


Fix permissions for liqo-gateway

Description
This PR adds the watch verb to the liqo-gateway component for the service resources.

/rebase

/merge


[FLINK-10842][E2E tests] fix broken waiting loops in common.sh

What is the purpose of the change
There are 3 loops in flink-end-to-end-tests/test-scripts/common.sh where the script waits for some event to happen (for i in {1..10}; do):
wait_dispatcher_running
start_and_wait_for_tm
wait_job_running
This PR changes them to fail if the expected event has not happened and to return from the loop if happened.
Brief change log

change waiting loops in common.sh

Verifying this change
Run any relevant e2e tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @zentol

Thanks for the update @azagrebin. I will merge this...


Cleanup for release

This PR performs some minor refactors to improve type-safety and adds missing docs. The four refactors are:

Make the fields of LeafWithHash private to ensure that leaves with invalid hashes cannot be constructed.
Remove the "EMPTY_ROOT" constant from NamespacedHash, since the empty root depends on the hasher. This type is moved into the Hasher.
Actually use the saved hasher in the simple merkle tree, rather (incorrectly) instantiating a new hasher for each operation. This ensures correct behavior for non-default hashers.
Remove the requirement that all MerkleHashers impement the Default trait

Closes https://github.com/Sovereign-Labs/nmt-rs/issues/17.


Running App

Hey, Just a quick question how do we run this application. Any special IDE, Library, etc. That we would need to get this work. We are looking to make integration tests for this repo.

Hi,
to run it locally, you need to clone the project, install the requirements in the requirements.txt file, and then type streamlit run app.py.
You can also go to the web app created on Streamlit. Here is the link.

What is stream lit?

A library in Python. Please do a Google search to learn more.


print stylesheet

The design is not printer-friendly as just a single page is printed (the mobile design is applied to the whole page).
I might try to create a appropriate print CSS and will create a PR, but it might take a couple of days...

@jampy , you are right. the issue is still on the to-do, I almost forgot about it.
Sure, your PR will be welcome, take your time.

Currently, I am able print correctly by adding react-to-print, it is quite easy.
But i think @greglobinski is working on it, i think i better wait for it at the moment.

Print styleshets are fixed now for post screens in ver 1.1.1


New Forge gradio 4 support?

The extension is no longer working with the new updated Forge. I would be very much grateful if it could be fixed.
I actually don't think https://github.com/hako-mikan/sd-webui-lora-block-weight is working at all, but it doesn't have any new updates in 4 months =(

@diodiogod
Thank you for the report.
I’ve been away from Forge after hearing about the upcoming update. I’ll check the issue right away and fix it.
I’ll push an update by tomorrow.

Even if Lora Block weights are not working, I got so used to the pop up menu to adjust weight that, as I stated before, can't live without it 🤣
I was about to post the error, but forgot
---
*** Error executing callback app_started_callback for J:\stablediffusion1111s2\Data\Packages\forge2\extensions\sd-webui-weight-helper\scripts\weight_helper.py
    Traceback (most recent call last):
      File "J:\stablediffusion1111s2\Data\Packages\forge2\modules\script_callbacks.py", line 256, in app_started_callback
        c.callback(demo, app)
      File "J:\stablediffusion1111s2\Data\Packages\forge2\extensions\sd-webui-weight-helper\scripts\weight_helper.py", line 22, in init_endpoints
        WeightHelperAPI.instance = WeightHelperAPI()
      File "J:\stablediffusion1111s2\Data\Packages\forge2\extensions\sd-webui-weight-helper\scripts\weight_helper.py", line 41, in __init__
        self.network = importlib.import_module("extensions-builtin.Lora.network")
      File "importlib\__init__.py", line 126, in import_module
      File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
      File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
      File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
    ModuleNotFoundError: No module named 'extensions-builtin.Lora.network'

@diodiogod
I used Lora Block-weight a lot myself, so I’m also very sad that it hasn’t been updated...
Thank you so much for loving this extension. Your support really motivates me!
For now, I’ve fixed this extension to work with the New Forge. Please update to the latest version and give it a try.

Thanks! It's working now!! Let's hope block-weight gets updated in the future as well. But having the popup back is great!

do I have to download the hako mikan extension? Or will it work without it?

@Krek12
Yes, you will need the hako mikan Lora Block Weight extension to use this extension. This is because it’s a tool for visually setting the Lora weights that can be configured with Lora Block Weight.
https://github.com/hako-mikan/sd-webui-lora-block-weight

@Krek12 Да, вам понадобится расширение Hako Mikan Lora Block Weight для использования этого расширения. Это потому, что это инструмент для визуальной настройки весов Lora, который можно настроить с помощью Lora Block Weight.
https://github.com/hako-mikan/sd-webui-lora-block-weight

then I don't know what's wrong with me. For the last couple of weeks I have been trying everything I have tried. I've even used different browsers. I still don't understand what's wrong.

@Krek12 Да, вам понадобится расширение Hako Mikan Lora Block Weight для использования этого расширения. Это потому, что это инструмент для визуальной настройки весов Lora, который можно настроить с помощью Lora Block Weight.
https://github.com/hako-mikan/sd-webui-lora-block-weight

then I don't know what's wrong with me. For the last couple of weeks I have been trying everything I have tried. I've even used different browsers. I still don't understand what's wrong.

What UI are you using? If it's Auto1111 is should still work, If its OLD forge (not the updated one) it should still work, But the new Forge don't work with block weights anymore. The extension is broken.

@Krek12
As @diodiogod mentioned, it seems that the behavior varies depending on the UI. I’ve fixed it so that it should work with Auto1111 and the New Forge. If it still doesn’t work, please create a new issue with details about the UI you’re using and any error logs. I’ll do my best to address the issue.
Thank you!


Update v4.1.0

Fixes https://github.com/SoRadGaming/Simple-HUD-Enhanced/issues/11
Fixed Equipment Memory Leak
Fixed EquipmentInfoStack Memory Leak
Fixed Movement Memory Leak

TODO:

[x] 1.20 - 1.20.2
[ ] 1.19.4
[ ] 1.18.2
[ ] 1.17.1

Added Config Equipment:

Chose Percent or value
Chose Enable or Disable Colour
Select Slots to Show Durability
Select Slots to Show Items
Fixes https://github.com/SoRadGaming/Simple-HUD-Enhanced/issues/13

simple-hud-enhanced+1.20-1.20.2-v4.1.0.zip
Preview jar


AQCU-1049 Add check to value in threshold so that NULL's are changed to NA

For AQCU-1049. @zmoore-usgs Not sure if this is the best way to do this, this seem right to you?

Coverage remained the same at 99.055% when pulling dc304c9c7c7625b32248d44dc0c3c2b4a3a9b590 on dpattermann-usgs:master into 81f0238a6e961b75734b1a54101bbe9212cb61d9 on USGS-R:master.

Coverage remained the same at 99.055% when pulling dc304c9c7c7625b32248d44dc0c3c2b4a3a9b590 on dpattermann-usgs:master into 81f0238a6e961b75734b1a54101bbe9212cb61d9 on USGS-R:master.

Coverage decreased (-0.03%) to 99.029% when pulling ca5b9e7e2bf1ee425143ca48f9dc67b491029bfd on dpattermann-usgs:master into 81f0238a6e961b75734b1a54101bbe9212cb61d9 on USGS-R:master.


karma-browserify + aliasify + proxquireify result in Cannot find module

As the title suggests, I'm not able to get karma-browserify, aliasify and proxquireify to work together. I opened the bug here, because it works if I just use browserify with aliasify & proxquireify to build the bundle, but not if I do it with karma-browserify.
I created a demo repo to reproduce the behaviour:
https://github.com/ds82/karma-proxyquire-aliasify-test
Clone and npm install. Then you can build two test bundles with
node browserify.build.js
-> bundles are in build/{bundle,test}.js
The file spec/main.spec.js loads a dependency some-dep which does not really exist, but is aliased via aliasify to src/dep.js.  If you look at build/test.js the aliased file src/dep.js got included
-> all fine :thumbsup:
Now run karma:
karma start karma.conf.js
that results in:
Chrome 47.0.2526 (Mac OS X 10.10.5) ERROR
  Uncaught Error: Cannot find module 'some-dep'
  at /var/folders/0p/b7pdm54d26q8db2qsxtxb3z80000gn/T/19a162a46249643aa983a2c5f2ad3356.browserify:54 <- /Users/dsaenger/code/karma-proxyquire-aliasify-test/node_modules/proxyquireify/lib/prelude.js:54:0

If I'm not missing something, I use the same config for karma-browserify in karma.conf.js as I do for browserify in browserify.build.js.
I'm thankful for any guidance here ..

Try to use the browserify configuration instead of bundle.transform as shown in the project readme.

The reason you might run into trouble is that prebundle is called with every bundle, registering your transform + plugin repeatedly.


[UI] [Create user][Password] Should add the input description.

For replay this improvement you need:
Test case

Go to SS and login under admin account.
Go to User management page and click on 'Add user'.
Fill out 'Create user' fields and put in the password 'secret' and click 'Save user'.

Result: You can observe Error message.
Improvement: Should add option to check symbols which helps user create password.

Tested.


[Backport - mitaka-13.1] Tighten Sphinx constraint

The latest version of Sphinx(1.6) introduced some problems with our
current tox tests for release notes. This commit tightens the constraint
so that version 1.6 is not installed.
(cherry picked from commit 9aeb628208387299cdd1c6ed618e6371ba4367dc)

recheck_cit_upgrade

FYI it looks like all of OpenStack experienced an issue with v1.6.1 and have blocked it.

good to know.


Colorize git

Details
Adds a better way to see differences between action diffs.
Fixed Issues
https://github.com/Expensify/Expensify.cash/issues/1665
Changes
Adds a temporary Library to the GitHub workflow that reflect better the changes in files

Also @FredericoGauz, when you update this PR could you please include screenshots as well?

Sure!

@FredericoGauz Can you please retest this by:

Make some changes to the Github Actions scripts
commit and push those changes
Link to the VerifyGithubActionsBuilds workflows that show the character-level diff
Revert the changes, commit and push.

Hi @roryabraham and @bondydaa, sorry for the late reply. I did the changes requested (it was quite clever to save the whole output in a variable!) and also run the tests you required.

The link for the failing action is: https://github.com/Expensify/Expensify.cash/pull/1726/checks?check_run_id=2184601524
I hope that this is what is need, but let me know if I can help with anything else!


Security Whitepaper is missing details on Private Link details

The Power BI Security Whitepaper does not refer to the new feature of Private Link and blocking public internet access.
As these are also security features, I guess the whitepaper should be updated accordingly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b0a5167-9181-bcb4-091c-9e603d2cf296
Version Independent ID: a8cbde60-5bb8-875f-3b8c-75dac8a2525f
Content: Power BI security whitepaper - Power BI
Content Source: powerbi-docs/guidance/whitepaper-powerbi-security.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for the feedback, @Johannes-Vink! Good call - I'll assign this to a writer so that they can add the private links reference.

Hi @Johannes-Vink, an updated version of the security white paper was published this morning. It includes some mention of Private Link.
https://docs.microsoft.com/en-us/power-bi/guidance/whitepaper-powerbi-security


Fix adjust loan bug

Yep, Jan built a good start to a test suite a while ago: https://github.com/AcalaNetwork/predeploy-contracts/pull/62
I can get that back up to speed and add tests for new contracts


test: allow running Bitcoin tests on live networks (tentative)

Description
Closes: https://github.com/zeta-chain/node/issues/2298

@zeta-chain/protocol-engineering opening it for reviews
An issue in infrastructure prevents for completely testing if Bitcoin deposits work, we can test it once on develop. In any case, this PR does some fixes for the Bitcoin zetae2e package


Add StructureViewFactory

@AlecStrong PTAL, I should've covered everything + added tests for new elements. I also rearranged the order to match the one in the file, I think that makes more sense.


Update troubleshoot-dns-failure-from-pod-but-not-from-worker-node.md

Doc reviewed on 08/25/2024 with no changes needed.
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

#sign-off


Sigstore language integrations

Add Sigstore language integration
Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~10 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

The deploy failed I believe due to a bad svg - I uploaded a new one but not sure how to kick off the netlify again @AndreyKozlov1984

That works now, latest preview LGTM


Italic comments like in VIM version?

This theme never cease to amaze me, and I'm getting getting back to it again and again after each of my quest for perfect theme.
But one thing bothers me a bit. vim version of exactly the same theme has italic comments while vscode one doesn't. Do you think we should sync theme visuals among different versions?

Thanks for the idea. I'll change the comment to italic tonight.

@shytikov  All changes are made. You can install the theme manually with code --install-extension. Anyways I'll publish the extension tomorrow.


Can't run with llama model

demo.ipynb fails to run with model="llama" since model "meta-llama/Llama-2-13b-chat-hf" is not in DOWNLOADABLE_MODELS.

Hi,
we didn't try with any of the chat models. But, if you want to work with new models try adding them to the DOWNLOADABLE_MODELS here.
Or, download hf version of your model and put it in the default models directory. Change this variable to where you store the models.


[5.2] [WIP] Chunk should require orderBy

This is in reference to #11302
This change makes sure that before chunking the results an orderBy has been set. If nothing was set by the user then the function will default to setting it to id. This can cause issues if a table doesn't have an id field.
The alternative would be to throw an exception if no orderBy has been set, but that would possibly be a huge breaking change.
I've added some tests to make sure that an order by statement is added to the SQL that's generated, but I'm not sure if the tests cover enough (there currently aren't any tests at all for the chunk method).
I'm open to all suggestions as to better/different ways to fix this.

If this is a bug, then it must go to 5.1 please.

If this is a breaking feature, then it must go to 5.3.

As it currently stands, I'd say that there is a bug in chunk, if it's breaking or not depends on how it should be fixed. Silently trying to use ìdfor the sort shouldn't break anything. If you'd rather throw an exception though and make people include an orderBybeforechunk`ing then it would be a breaking change.


feat(graph): allow edge names to be objects

Can you provide some description of why this change is needed? Are there other ways like using a map to get the same result?


Null coalescing operator: type mismatch

The following code does not cause any warning:
String test = 100 ?? 'another string';

I think that the plugin should be alerted and print the following error:
[error] A value of type 'int' cannot be assigned to a variable of type 'String'

Does it if you have explicit types?
int myInt = 100;
String myString = 'another string';
...
And just FYI, issues like this are probably better filed against dart-lang/sdk.

No, it still doesn't throw any warning:
int myInt = 100;
String myString = 'another string';
String test = myInt ?? myString; // no warnings, no errors, no anything

I'll publish this issue in the dart-lang/sdk repository.


[Backport 2.x] search_after query optimization with shard/segment level short cuttin…

Backport of #7453

@reta thanks for approving !
Need one more help on re-triggering ./gradlew check. I opened issue for flaky test #7729


can i go to another screen by taping the + button?

First thing you have done an amazing job - thank you very much! Secondly, I wanted to know if we can add a transition between screens when you press the button (+) not on Google and Twitter. I know that the class is NSObject and not UIButton, and that can create problems with the method "touchesBegan: withEvent:" and with "Prepareforsegue"
In simple terms, I want to press the button and it will take me to another screen
tnx :+1:

Hi @yonidaniel! Thanks for your comment :)
If you're attaching the button to a UIViewController's view you can just call 'self.performSegueWithIdentifier' from your view controller, inside the button's actions.
I hope that helps


⚠ Spryr has degraded performance

In 458b350, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3564 ms

Resolved: Spryr performance has improved in 50cf9aa after 7 minutes.


Init page transitions after navigation direction

pageflow.navigationDirection needs to be defined, before
pageflow.pageTransitions can be initialized.

Coverage remained the same at 99.202% when pulling c3fc6025b38028bd6391f746ddd8ba20a0ced211 on tf:page-transitions-init into fa7af0ad7dfe2a3d30e9eefd69790ede6d0a6c25 on codevise:master.


Take company from user default company

Just a thought for now, instead of bringing from web.config

If you don't specify the company on CallContext it will use the user default company instead. The web.config parameter is a good idea to force a specific company instead of doing that on code level.


Dash Core qt crash

Win 7 64bit - v<IP_ADDRESS>-025f090
Dash Core qt crash every time when you switch on 'Show Masternodes Tab' option
in the middle of syncing masternodes process.
To replicate this bug:
Make sure you have switched off 'Show Masternodes Tab, then close wallet.
Start wallet, switch on 'Show Masternodes Tab' in wallet options, do not close options yet,
wait when synchronizin masternodes start then close options window with ok,
and close also wallet, crash occur.

Likely related to #897 as well - i broke the Debug Window

This is related to masternodes tab, and crashing was occuring in the earlier versions also,
but now i figured out why and when crash occurs.
@UdjinM6 should find this fast, its his code :)

Gotcha, so i am not the bad boy here :)

Yep, reproduced, will provide a fix (and probably slight refactoring).
Thanks!


Integrate with code climate

Code Climate now accepts JS, and has free support for open source projects. Add this add-on to code climate and put the badge in the readme.

Done.


LPC15XX Serial::TxIrq Disables USBDevice (Tx/Rx IRQ clearing flags)

Attaching Serial::TxIrq callbacks on the LPC1549 appears to disable the USB peripheral, as is evidenced by the following code:
#include "mbed.h"
#include "USBHID.h"

USBHID hid(8, 8, 0x1234, 0x0006, 0x0001, false);
Serial pc(USBTX, USBRX);
DigitalOut led1(LED1);
DigitalOut led2(LED2);
HID_REPORT report;

void onTxIrq()
{
    led2 = !led2;
}

int main(void)
{
    //Attach a serial Tx callback (breaks USBDevice!)
    pc.attach(onTxIrq, Serial::TxIrq);

    //Connect to the host (doesn't work!)
    hid.connect(false);

    while (1) {
        //Try to read a report
        if(hid.readNB(&report)) {
            led1 = !led1;
        }
    }
}

After calling pc.attach(onTxIrq, Serial::TxIrq), the device will no longer connect to the host. However, if pc.attach(onTxIrq, Serial::TxIrq) is removed, or changed to a Serial::RxIrq type, connecting to the host works fine.

@toyowata is right, this isn't a bug. The TXRDY interrupt is firing repeatedly when no data is being sent since the transmit register is always ready. The only solution is to disable the interrupt after the last byte is sent.


Bz2031649 vm migration is marked as succeeded when vm resource is deleted during image conversion stage

For MTV 2.2
https://bugzilla.redhat.com/show_bug.cgi?id=2031649
Direct link to doc preview:
https://deploy-preview-274--forklift-documentation.netlify.app/documentation/doc-release_notes/master/#known-issues-22_forklift

@apinnick  Please merge this PR.

@apinnick  Merge?


Invalidate script module cache when the underlying module file is changed

PR Summary
Fix the cache invalidation issue from #2505.
Currently, importing a module for the second time will always import from the cache, even if the underlying file has been changed.
This change makes the cache check the last write time on the underlying file first before proceeding, and if it is different, updates the cache and returns the new module file.
I have also changed the analysis cache dictionaries to use ConcurrentDictionary rather than needing to manually use a locking object.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[x] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[x] Add [feature] if the change is significant or affects feature tests

This code should enable a developer scenario, where I have the following script in editor:
using module F:\tmp\test.psm1

class Zoo { [Foo]$Param }

F:\tmp\test.psm1 has the following content:
class Foo { [string]$Name }

Then I add another class to test.psm1 as follows:
class Foo { [string]$Name }
class Bar { [string]$Path }

And then I modify Zoo in the editor to add a property [Bar]$bar:
using module F:\tmp\test.psm1

class Zoo { [Foo]$Param; [Bar]$bar }

The [Bar] should be resolved in this scenario, which means the new content in test.psm1 should be picked up by the parser.
Be noted, no module is loaded in this scenario.

@daxian-dbw I'm going to write another test in line with the example you give above

That test failure seems to be Linux-specific, and only occurs about 10% of the time.

I don't think this should be forgotten. Is a comment enough to keep it alive?

@powercode I promise I haven't forgotten about this PR... Just had to cut it short and haven't had a good reason to return to it. I'm about to get back to it - it looks like the failure is consistent on Linux, so I'm hoping to be able to get to the bottom of it,

Going to close this and continue working on it in an updated branch


GH-2251 Fix Jetty Metrics Recording

Hopefully this uncooks the jetty metrics
Also bumps the version for prometheus metrics.

Hopefully

Did you try to run this? :sweat_smile:

Hopefully

Did you try to run this? 😅

you never know, some magic issue might pop up later

actually I think I did something dumb, is there an easy way to take an arbitrary string and normalize it as a url path?
eg.
//metrics/// -> /metrics?
I couldn't find any from a quick look earlier

You could try with our Location class I think, it's intended to clean up messed paths (in general)

Thanks, let's see how it'll work :shipit:


Using dat as a background process

I am reporting:

feature request

Operating system: Ubuntu 20.04
Dat Version: 14.02

Hello, I've testing "dat " on Linux. I've installed it using "dat-14.0.2-linux-x64.zip" It works only when the login screen is open. When I exit, it stops serving the files.
I've tried to use "nohup dat  &", but it exits.  Is any way to serve the files in background even after I logout from the Linux session?

Try seeting it up as a systemd service.
There's docs on running a persistent service using something like dat-store Do note that dat-store is using newer networking and storage APIs, so if you want it to be compatible with the dat cli, you'll need to downgrade to dat-store@4 rather than dat-store@6


feature: add diagnostic virtual text toggle

Add a function to toggle virtual text
make it clean

Hey @cinuor, I was about to do this 😆 no way. GG

Hey @tami5 I've simplify the code, It looks better maybe

Nice, thanks @cinuor


Rename update to handle_event to make it less confusion with HA naming

fixed but fails testing as I updated here: https://github.com/thecode/ha-rpi_gpio/pull/281


posix.mak: convert CRLF back to LF

https://github.com/D-Programming-Language/druntime/pull/1222 inadvertedly translated line endings in posix.mak. This reverts this change.

thx!

Use the tool:
https://github.com/D-Programming-Language/tools/blob/master/tolf.d
as part of your checking switch, and no more problems.


Disable browser validation for images and docs

Django 1.10 adds browser validation to all required fields by default. We don't need this behaviour for images and docs.
Note: there is other possible solutions. We can add a new form for an edit view that will define file field as not required.
Fixes #2897

Probably we also need to add tests to check html representation of forms.

It sounds to me like this might be a core Django bug. Django implements 'edit mode' on file fields using logic outside of the <input type="file"> tag (because browsers won't let you pre-populate the element). This is logically a required field at the Django level (because you can't have an Image or Document without a file), but it's incorrect for Django to add the client-side validation (because the client doesn't know about the Django-side logic). I'll investigate this further.

Makes sense.
Django adds required attribute for all fields which were defined as not hidden and required on BoundField level (see this method for details).

Should we use @m1kola's solution while we wait for a fix in Django?

I'm not very keen on the fix in its current form, because A) client-side validation is a nice feature (or will be, when Django fixes it!) and it's a shame to disable it completely for these forms; and B) it's apparently quite common for people to use FileFields on other forms throughout Wagtail (pages, snippets, modeladmin, settings, custom user models...) so we ought to have a fix that covers those too.
It's entirely possible that Django 1.10.1 will come out (with this fix in place - it's currently tagged as a release blocker) before our release date for Wagtail 1.6 - if so, I think we should just rely on Django's fix and not try to fix it at our end.
It's worth noting that django.contrib.admin disables client-side validation by adding a novalidate attribute to the <form> element (source). That might be a cleaner way to deal with this, since the relevant forms also need to output enctype="multipart/form-data" at that point. Something like:
<form action="..." method="..."
    {% if form.is_multipart %}
        enctype="multipart/form-data"
        {% if django_1_10_0 %}novalidate{% endif %}
    {% endif %}
>

Fixed in Django 1.10.1.


show targettype+target on jobs panel and jobs page

The jobs panel shows target+command+date, and not targettype. When zooming in on a job, the target is no longer shown. It is true that the list of minions is shown, but the information on how these were selected is no longer shown.
This PR shows the targettype+target in both the jobs panel (on pages "minions" and "keys"; and on the "job" page, which is reached after clicking on a job.
For simplicity, the words "glob" (the default) and "list" are suppressed.
Due to a bug in 2018.3, many jobs are stored as of type "list" while they were not. So that would have been the second reason not to show the indicator for targettype "list".

Noticed the use of != in the reviewed code. Updated that to !==.


Issues with renaming folders/notes while in preview mode

When I try to rename a folder in preview mode, the text that I'm typing is added to the note instead of the folder/note name.
Steps to reproduce:

Open a note in preview mode
Right click a folder or a note and click "Rename"
Start typing

The active note will switch to the "edit" mode and text will be added to the note.
It's only possible to rename a folder/note when the active note is in edit mode, but it's quite tricky, since it switches to preview within 2 seconds.

I'm pretty sure I fixed this issue in an update, try checking for updates and seeing if there are any.

Are you renaming with the bar on the top of the file or by right clicking in the file view?

Right clicking in the file view.
Renaming in the bar on top works fine indeed.

Alright yeah I guess I forgot to check that way of renaming.

Fixed in 1.0.5


Feature: Eraser tool

Cool project!
I'm not sure how open project is to feature requests as issues, but I noticed there didn't seem to be an eraser tool at the moment (or at least I couldn't find it). I think it would be really nice to have this.

If you're using the latest development version at https://dev.graphite.rs, the Brush tool has an erase mode. This can be used on the brush strokes you've already drawn, or it can be used on a bitmap image if you make the node setup like this:

That's pretty clunky right now because we haven't built the tooling surrounding the automated management of the node graph to be very robust or systematic. But it's a start.
I'm going to close this since it's technically implemented in a basic way, but if you want to point out other use cases not covered by this and explain what those are, I can reopen it to make this issue refer to those cases specifically. Thanks for the issue, and indeed we're always excited to have issues filed for problems and feature requests.


alloptimizers.py :add command line args,  collect results into table

took a crack at adding some command line args for alloptimizers.py
cleaned up output a little
collect results into a logfile CSV
on further review probably just as well to let individual algos be multithreaded or not
no worries if this is not the preferred way but maybe this helps as a start
usage: alloptimizers.py [-h] [-d NDIMS [NDIMS ...]] [-t NTRIALS [NTRIALS ...]] [-v] [-o LOGFILE]
Run all optimizers on input size ndim (default 2) requesting ntrials (default 20) iterations and save results (default log.csv
optional arguments:
-h, --help            show this help message and exit
-d NDIMS [NDIMS ...], --ndims NDIMS [NDIMS ...]
Number of input dimensions to objective function (default 2)
-t NTRIALS [NTRIALS ...], --ntrials NTRIALS [NTRIALS ...]
Number of trial iterations in optimization (default 20)
-v, --verbose         Increase output verbosity
-o LOGFILE, --logfile LOGFILE
Specify outputfile (default log.csv)

You'll like this too.  https://github.com/microprediction/timemachines-testing/tree/main/optimizer_elo_ratings/leaderboards/overall


nano-wallet: 19.0 -> 20.0

Motivation for this change
Upgrade Nano cryptocurrency wallet.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

This looks good to me. I accidentally opened a similar PR earlier today, but closed it in favor of this one.

@volth I see you've touched this file at some point in history, so would you like to review or do you have any suggestions who I should ask to review/merge?


Adding Google Analytics code

Coverage remained the same at 71.088% when pulling 8c9e9fbd7a7d864e2d302918fe8f7a1034a53f49 on ga-mkdocs into 169bbadd6f941c2bb702f0530b5991ab2bcf07b8 on develop.

Coverage remained the same at 71.088% when pulling 0dfce73555bd0df4c5ed280d74a8565e2e94c76f on ga-mkdocs into 169bbadd6f941c2bb702f0530b5991ab2bcf07b8 on develop.


Host Config and CSS for Viva Connections

Description
This PR introduces the Host Config JSON and CSS for Viva Connections in Adapative Cards
Microsoft Reviewers: Open in CodeFlow

If you want to show them in designer, you need to update source/nodejs/adaptivecards-designer/src/adaptivecards-designer.ts too.
This is an example to see the new config #6530. and you can see the new change on : designer for PR 6530


Include (or link to) deployment examples in Cartography documentation

Feature request template
Title: Include (or link to) deployment examples in Cartography documentation
Description:

Describe your idea.  Please be detailed.  If a feature request, please
describe the desired behavior, what scenario it enables, and how it
would be used.

See discussion at https://github.com/lyft/cartography/issues/230#issuecomment-586897785
We want to be clear in these docs that these are not the only ways to deploy it, and we also want to provide useful examples.  @marco-lancini's blog post could be a good starting point.

Hi @achantavy, as I was mentioning: if needed, I'm also happy to extract the Kubernetes deployment itself from the blog post and add some examples to the Cartography repo

@marco-lancini Awesome!
I was thinking we could make a docs/setup/deployment folder and put a kubernetes.md in there, and then we'd adapt docs/setup/install.md to link to it.

No stale bot, this is not stale :D


feat: throw error when does not find file

reasons here
important points:

I tried to follow the same pattern error (which is treated directly on the function, that's why I passed silent to the copyAll). Another alternative I thought was to return an array of failed results and use outputCopyLog to show them, then I would not need to pass the silent flag.
I used silent as it looks for this purpose. I don't think make sense to create another flag

Evidence:
build
silent=false

silent=true

server
silent=false

silent=true (the server keeps running, but there is a logger.error)

@sapphi-red, any news here? :sweat_smile:


Update to latest version of OpenSlides to make it work again

Just fetched from origin/stable/3.4.x

Mal eben gemacht.


Change multibox_loss to Focal Loss

Hello @toandaominh1997! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file data/__init__.py:

Line 8:13: W291 trailing whitespace
Line 30:1: W293 blank line contains whitespace
Line 32:9: E303 too many blank lines (2)
Line 36:80: E501 line too long (122 > 79 characters)

In the file data/voc0712.py:

Line 73:47: E261 at least two spaces before inline comment
Line 73:80: E501 line too long (92 > 79 characters)
Line 166:66: W292 no newline at end of file

In the file datasets/__init__.py:

Line 1:28: W292 no newline at end of file

In the file datasets/augmentation.py:

Line 2:13: W291 trailing whitespace
Line 9:1: E302 expected 2 blank lines, found 0
Line 14:1: W293 blank line contains whitespace
Line 29:1: W293 blank line contains whitespace
Line 36:17: E265 block comment should start with '# '
Line 43:5: E303 too many blank lines (2)
Line 47:1: E302 expected 2 blank lines, found 1
Line 60:80: E501 line too long (82 > 79 characters)
Line 68:80: E501 line too long (99 > 79 characters)
Line 71:26: E228 missing whitespace around modulo operator
Line 72:26: E228 missing whitespace around modulo operator
Line 74:80: E501 line too long (82 > 79 characters)
Line 78:80: E501 line too long (102 > 79 characters)
Line 94:1: W293 blank line contains whitespace
Line 115:22: E231 missing whitespace after ':'
Line 115:80: E501 line too long (87 > 79 characters)
Line 117:1: E302 expected 2 blank lines, found 1
Line 119:17: E711 comparison to None should be 'if cond is None:'
Line 123:16: E711 comparison to None should be 'if cond is None:'
Line 157:80: E501 line too long (83 > 79 characters)
Line 165:127: W292 no newline at end of file

In the file models/efficientdet.py:

Line 18:33: E127 continuation line over-indented for visual indent
Line 21:80: E501 line too long (84 > 79 characters)
Line 26:80: E501 line too long (94 > 79 characters)
Line 27:80: E501 line too long (102 > 79 characters)
Line 29:51: W291 trailing whitespace

In the file models/losses.py:

Line 5:1: E302 expected 2 blank lines, found 1
Line 8:80: E501 line too long (110 > 79 characters)
Line 9:80: E501 line too long (110 > 79 characters)
Line 14:80: E501 line too long (91 > 79 characters)
Line 24:1: E302 expected 2 blank lines, found 1
Line 25:5: E265 block comment should start with '# '
Line 36:22: E221 multiple spaces before operator
Line 38:21: E221 multiple spaces before operator
Line 39:21: E221 multiple spaces before operator
Line 57:69: E261 at least two spaces before inline comment
Line 57:80: E501 line too long (100 > 79 characters)
Line 59:56: E261 at least two spaces before inline comment
Line 61:13: E265 block comment should start with '# '
Line 62:13: E265 block comment should start with '# '
Line 77:80: E501 line too long (91 > 79 characters)
Line 81:80: E501 line too long (94 > 79 characters)
Line 82:80: E501 line too long (98 > 79 characters)
Line 85:80: E501 line too long (108 > 79 characters)
Line 90:80: E501 line too long (105 > 79 characters)
Line 92:80: E501 line too long (107 > 79 characters)
Line 97:80: E501 line too long (80 > 79 characters)
Line 104:26: E221 multiple spaces before operator
Line 104:80: E501 line too long (84 > 79 characters)
Line 105:80: E501 line too long (84 > 79 characters)
Line 106:25: E221 multiple spaces before operator
Line 107:25: E221 multiple spaces before operator
Line 110:26: E221 multiple spaces before operator
Line 118:80: E501 line too long (87 > 79 characters)
Line 124:17: E303 too many blank lines (2)
Line 126:80: E501 line too long (86 > 79 characters)
Line 137:134: W292 no newline at end of file

In the file models/module.py:

Line 10:1: W293 blank line contains whitespace
Line 11:80: E501 line too long (87 > 79 characters)
Line 13:80: E501 line too long (84 > 79 characters)
Line 15:80: E501 line too long (84 > 79 characters)
Line 17:80: E501 line too long (84 > 79 characters)
Line 19:80: E501 line too long (86 > 79 characters)
Line 20:5: E301 expected 1 blank line, found 0
Line 36:80: E501 line too long (101 > 79 characters)
Line 40:1: W293 blank line contains whitespace
Line 41:80: E501 line too long (87 > 79 characters)
Line 43:80: E501 line too long (84 > 79 characters)
Line 45:80: E501 line too long (84 > 79 characters)
Line 47:80: E501 line too long (84 > 79 characters)
Line 49:80: E501 line too long (96 > 79 characters)
Line 51:5: E301 expected 1 blank line, found 0
Line 65:80: E501 line too long (87 > 79 characters)
Line 69:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file
Line 71:1: E402 module level import not at top of file
Line 75:80: E501 line too long (96 > 79 characters)
Line 87:80: E501 line too long (80 > 79 characters)
Line 90:1: W293 blank line contains whitespace
Line 93:80: E501 line too long (92 > 79 characters)
Line 99:20: E221 multiple spaces before operator
Line 99:80: E501 line too long (113 > 79 characters)
Line 100:80: E501 line too long (82 > 79 characters)
Line 101:24: E221 multiple spaces before operator
Line 107:1: E302 expected 2 blank lines, found 1
Line 140:1: E302 expected 2 blank lines, found 1
Line 147:80: E501 line too long (83 > 79 characters)
Line 166:16: E221 multiple spaces before operator
Line 166:80: E501 line too long (94 > 79 characters)
Line 168:20: E221 multiple spaces before operator
Line 190:80: E501 line too long (95 > 79 characters)
Line 193:23: W292 no newline at end of file

In the file modules/multibox.py:

Line 3:1: W391 blank line at end of file

In the file train.py:

Line 77:32: E127 continuation line over-indented for visual indent
Line 87:5: E303 too many blank lines (3)
Line 88:1: W293 blank line contains whitespace
Line 91:1: W293 blank line contains whitespace
Line 94:1: W293 blank line contains whitespace
Line 101:80: E501 line too long (114 > 79 characters)
Line 114:25: E228 missing whitespace around modulo operator
Line 114:29: E225 missing whitespace around operator
Line 115:80: E501 line too long (197 > 79 characters)
Line 116:22: E225 missing whitespace around operator

In the file train_pytoan.py:

Line 1:10: W291 trailing whitespace
Line 2:16: W291 trailing whitespace
Line 6:12: W291 trailing whitespace
Line 11:20: W291 trailing whitespace
Line 21:1: E303 too many blank lines (3)
Line 24:80: E501 line too long (108 > 79 characters)
Line 25:80: E501 line too long (112 > 79 characters)
Line 30:1: E302 expected 2 blank lines, found 1
Line 36:5: E306 expected 1 blank line before a nested definition, found 0
Line 39:5: E306 expected 1 blank line before a nested definition, found 0
Line 53:31: E203 whitespace before ':'
Line 53:80: E501 line too long (92 > 79 characters)
Line 58:1: W293 blank line contains whitespace
Line 60:1: W293 blank line contains whitespace
Line 63:1: E303 too many blank lines (3)
Line 65:80: E501 line too long (116 > 79 characters)
Line 66:80: E501 line too long (114 > 79 characters)
Line 67:80: E501 line too long (115 > 79 characters)
Line 71:80: E501 line too long (87 > 79 characters)
Line 72:80: E501 line too long (129 > 79 characters)
Line 77:32: E128 continuation line under-indented for visual indent
Line 79:1: W293 blank line contains whitespace
Line 80:43: E251 unexpected spaces around keyword / parameter equals
Line 80:45: E251 unexpected spaces around keyword / parameter equals
Line 80:66: E251 unexpected spaces around keyword / parameter equals
Line 80:68: E251 unexpected spaces around keyword / parameter equals
Line 80:80: E501 line too long (142 > 79 characters)
Line 80:96: E251 unexpected spaces around keyword / parameter equals
Line 80:98: E251 unexpected spaces around keyword / parameter equals
Line 81:80: E501 line too long (114 > 79 characters)
Line 82:32: E251 unexpected spaces around keyword / parameter equals
Line 82:34: E251 unexpected spaces around keyword / parameter equals
Line 82:55: E251 unexpected spaces around keyword / parameter equals
Line 82:57: E251 unexpected spaces around keyword / parameter equals
Line 83:36: E251 unexpected spaces around keyword / parameter equals
Line 83:38: E251 unexpected spaces around keyword / parameter equals
Line 83:59: E251 unexpected spaces around keyword / parameter equals
Line 83:61: E251 unexpected spaces around keyword / parameter equals
Line 84:36: E251 unexpected spaces around keyword / parameter equals
Line 84:38: E251 unexpected spaces around keyword / parameter equals
Line 84:60: E251 unexpected spaces around keyword / parameter equals
Line 84:80: E251 unexpected spaces around keyword / parameter equals
Line 84:80: E501 line too long (101 > 79 characters)
Line 84:82: E251 unexpected spaces around keyword / parameter equals
Line 85:36: E251 unexpected spaces around keyword / parameter equals
Line 85:38: E251 unexpected spaces around keyword / parameter equals
Line 85:59: E251 unexpected spaces around keyword / parameter equals
Line 85:61: E251 unexpected spaces around keyword / parameter equals
Line 85:80: E501 line too long (96 > 79 characters)
Line 85:84: E251 unexpected spaces around keyword / parameter equals
Line 85:86: E251 unexpected spaces around keyword / parameter equals
Line 100:34: E251 unexpected spaces around keyword / parameter equals
Line 100:36: E251 unexpected spaces around keyword / parameter equals
Line 104:38: E251 unexpected spaces around keyword / parameter equals
Line 104:40: E251 unexpected spaces around keyword / parameter equals
Line 105:48: E251 unexpected spaces around keyword / parameter equals
Line 105:50: E251 unexpected spaces around keyword / parameter equals
Line 106:39: E251 unexpected spaces around keyword / parameter equals
Line 106:41: E251 unexpected spaces around keyword / parameter equals
Line 107:45: E251 unexpected spaces around keyword / parameter equals
Line 107:47: E251 unexpected spaces around keyword / parameter equals
Line 108:36: E251 unexpected spaces around keyword / parameter equals
Line 108:38: E251 unexpected spaces around keyword / parameter equals
Line 109:39: E251 unexpected spaces around keyword / parameter equals
Line 109:41: E251 unexpected spaces around keyword / parameter equals
Line 111:1: W293 blank line contains whitespace
Line 114:1: E305 expected 2 blank lines after class or function definition, found 1

In the file train_test.py:

Line 150:1: W293 blank line contains whitespace
Line 152:5: E303 too many blank lines (2)
Line 157:80: E501 line too long (80 > 79 characters)
Line 171:80: E501 line too long (82 > 79 characters)
Line 190:80: E501 line too long (146 > 79 characters)
Line 190:115: E225 missing whitespace around operator
Line 199:25: E128 continuation line under-indented for visual indent
Line 200:22: E225 missing whitespace around operator
Line 202:13: E128 continuation line under-indented for visual indent
Line 224:80: E501 line too long (80 > 79 characters)
Line 243:80: E501 line too long (93 > 79 characters)
Line 295:80: E501 line too long (80 > 79 characters)
Line 310:12: W292 no newline at end of file

In the file utils/augmentations.py:

Line 399:1: E302 expected 2 blank lines, found 1
Line 406:1: W293 blank line contains whitespace
Line 409:80: E501 line too long (99 > 79 characters)
Line 414:80: E501 line too long (82 > 79 characters)
Line 417:80: E501 line too long (102 > 79 characters)
Line 419:1: E302 expected 2 blank lines, found 1
Line 432:1: W293 blank line contains whitespace
Line 453:22: E231 missing whitespace after ':'
Line 453:80: E501 line too long (87 > 79 characters)


Improve mapping coverage analysis algo to support analysis for binding queries

What type of PR is this?

Improvement
What does this PR do / why is it needed ?

Improve mapping coverage analysis algo to support analysis for binding queries
after:
https://github.com/finos/legend-engine/assets/73408381/6b9a59b0-e595-4fb8-b565-987cace85440
Which issue(s) this PR fixes:

Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?

Found an ongoing issue:  forget to handle the case where there might be a cycle in the model


Checkout mlops-project-template@cindy-test to s/mlops-project-template

Describe the bug or the issue that you are facing
Is it correct to use a branch different to main?
Starting: Checkout mlops-project-template@cindy-test to s/mlops-project-template
Steps/Code to Reproduce
Same as https://github.com/Azure/mlops-v2/blob/main/documentation/deployguides/deployguide_ado.md
Section: Set up source repository with Azure DevOps
Expected Output
I dont have an error per see, but its weird to me that its using a named branch (cindy-test) instead of main.
Versions
I am using: initialise-project.yml
from mlops-v2 repo
Which platform are you using for deploying your infrastrucutre?
Azure DevOps (ADO)
If you mentioned Others, please mention which platformm are you using?
No response
What are you using for deploying your infrastrucutre?
Pre-Deployed
Are you using Azure ML CLI v2 or Azure ML Python SDK v2
Azure ML Python SDK v2
Describe the example that you are trying to run?
I am just following the section:
Setup MLOps V2 and a New MLOps Project in Azure DevOps
from:
https://github.com/Azure/mlops-v2/blob/main/documentation/deployguides/deployguide_ado.md
We use ADO not GHA

looks like when I imported the repos, the default branches are not the main ones

Same for mlops-v2 repo here on next run, which shows branch feathr as default (and main as failed, with further beautifully named main_xxx branches)


Could not find method coreLibraryDesugaring() for arguments

Hi,
I create an application in flutter and can run the application for ios, but when try to run it on android problem arise;
`1: Task failed with an exception.

Where:
Build file '/Users/rezash/Sites/flutter/.pub-cache/hosted/pub.dartlang.org/ably_flutter-1.2.0-preview.2/android/build.gradle' line: 26

What went wrong:
A problem occurred evaluating project ':ably_flutter'.

Could not find method coreLibraryDesugaring() for arguments [com.android.tools:desugar_jdk_libs:1.1.1] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
`

I have tried to update my flutter to version Flutter 2.2.2 , but the problem still there.

Attached, my flutter doctor result.
Please help,
Thanks.

It might be related to your gradle version. Did you upgrade?

i might do that earlier.

this from android/.gradle

what gradle version should be used then?

For those with similar problem;
load the android visual studio code from the android folder of your flutter ;
From this information (https://developer.android.com/studio/releases/gradle-plugin?hl=id):

Locate the file build.gradle , and make sure version gradle being use is matched

From my machine, using the com.android.tools.build:gradle:4.2.1 with distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip and then click Sync Project with Gradle Files will make the problem go away and you can run/debug the application.
thanks.

Hey @rezashamdani, it's great you fixed it. I guess you had used an older version gradle/ Android gradle plugin in your project, and updating it fixed it.
Can you say what versions you were using previously?


Unclear error when running in a git repo without "origin" remote

doc-gen4 prints only
error: stderr:
uncaught exception: git exited with code 128

without any indication what's wrong. It's not clear to me it should require a git repo to build at all, but if it does, it should handle issues with its expectations more gracefully.

Fixed.
The reason it requires a git repo right now is for the source linking, I thought it was a reasonable assumption to make at the time that in general Lean code ends up on Github. That said I guess as the community grows different use cases will pop up that will need more handling in the source linker.


Represent 0/0 trust threshold as None

I am still not quite sure that this is an improvement over the current version. What do you think?

I think an Option works better at least from a semantic perspective. Seeing a value of 0/0 is always a little bit alarming. I don't think None is amazing either though, since a None trust threshold value is not empty in the usual sense; it carries a particular meaning in a particular situation. Perhaps in this case it would make sense to define a bespoke enum like:
enum TrustThreshold {
    Ratio(Ratio<u64>),
    ClientStateReset,
}

Yeah, it's basically an Option, but it's a slight semantic improvement, which, in my opinion is the main thing to capture here. What do you think?

Closing this as it doesn't provide much of an improvement over the current logic.


Current release of PyFluent (0.21) is incompatible with released version of pyfluent-parametric

Pinging @ansys/pyfluent-admins for visibility.
Current PyFluent release is not compatible with the released versions of this package.

@RobPasMue @ansys/pyfluent-admins We are planning to retire this package eventually as all of its functionality is now provided by the PyFluent package. The parametric functionality exposed in PyFluent is more intuitive and uniform with other PyFluent-level APIs. We are OK if this package is no longer included in Ansys metapackage (assuming that's the original issue here).

Oh okay! Sounds good - I will retire from 24R2 in that case


onExit: The intro is exiting by itself

Describe the bug
The application starts and just triggers the onExit function in the functional component. I have added a callback too but its still having the same issue.
To Reproduce
I can provide you the code
Expected behavior
onExit should be triggered when the callback is called. When the state is updated on the hard reload the intro works fine. I have removed and added callbacks to check the behavior.
How often does this bug happen?
Every time
System Info
No response
Additional Context
No response

I can provide you the code

It would indeed be pretty neat to have a repro, if you could provide one on codesandbox.io for example as I'm not sure I really understand the issue.

https://javascript.plainenglish.io/react-js-onboarding-using-intro-js-4b03aa2f584e
Following this link. Whenever the app runs the tour gets closed by itself.

javascript.plainenglish.io/react-js-onboarding-using-intro-js-4b03aa2f584e

I don't see any sandbox where I can see your code with the bug you are describing and play with it in this article, am I missing something?
If you don't know where to setup your repro and share your code, you can use codesandbox.io for example.

Okay I will attach the link by tomorrow

Closing due to lack of activity.


Random token invalid issue.

Issue
I have been getting a random issue with users trying to reset their passwords in our production and test environments.
The main problem is that we recently moved about 10k users from a legacy login system over to the identity server.   When we did this their login page changed so everyone who had their password saved in their browser and now cant remember it has had to reset their password.   A small percentage of those users has not been able to reset their password.   They always get an invalid token error.     (Support says some of the email verification tokens for new users is also invalid but i have not seen this personally I need to have them send me these as well for debugging.)
I have not been able to recreate this on my local machine.    I tried copying their concurrencyStamp and secrutystamp to my own account hoping that would force it to generate an invalid token.   That did not work either.    I have about 700 test users on my local machine i went though about 50 of them before i started to loose my mind and gave up trying to recreate it that way.
The error in question is

VerifyUserTokenAsync() failed with purpose: ResetPassword for user 289512042.

This didnt give me much information so i added my own debuging and added this issue request which i will be posting a pull request for later this morning Show errors in the log from VerifyUserTokenAsync

User reset password failed [user.Id: 289512042] Invalid code

So i know that the error is that the code is not valid.

I can verify that the code is not to old.   I have seen the the logs the user requesting it and then getting the email and clicking on the link within minutes.   It does not work.
I also have a supporter who swears she watched the user do it over team viewer they event tried using an incognito window.

About the application

.net core 2.0
Identity server 4.
Entity framework with Asp .net users.
one Redis server running in test and production.
Production and test running in a docker swarm.
Identity server # of instances Test running two instances  production running one.   We are still trying to fix bug with this user move so didnt want to make matters worse by running multiple instances in production yet.   I had it running two instances last week for a day or so just to test it.

Start up
_logger.LogInformation(LoggingEvents.StartupRedis,
$"Data protection enabled with with redis: {Configuration["Redis:ApplicationName"]}", Configuration["Redis:ApplicationName"]);

services.ConfigureApplicationCookie(opts =>
                    opts.SessionStore = new RedisCacheTicketStore(new RedisCacheOptions()
                    {
                        Configuration = Configuration["Redis:HostPort"]
                    }, _logger, Configuration)
                );
 var redis = ConnectionMultiplexer.Connect(Configuration["Redis:HostPort"]);
services.AddDataProtection(config => config.ApplicationDiscriminator = Configuration["Redis:ApplicationName"])
                    .SetApplicationName(Configuration["Redis:ApplicationName"])
                    .PersistKeysToRedis(redis, "DataProtection-Keys");

Application name is based upon environment "ApplicationName": "XXXXIdentityserver-v2-Production-Key"
We currently only have one redis server which is serving both production and test.
Background Info
This identity server has been running for around two years.   I recently added asp.net users and imported about 10k users into it from a legacy system, so that it now manages the users.   When i did the import of the users I neglected to create them a concurrencyStamp and securitystamp.    This lead to an issue where legacy users were creating a reset password token that would never validate.  (It may be an idea to test that the stamps are not null before creating the token in the library itself. )  I have added a check in my code before creating the token to ensure that a user has the tokens before creating the reset password token.
if (user.SecurityStamp == null) await _userManager.UpdateSecurityStampAsync(user);
This random invalid token is happening on new users as well as legacy users who have already reset their password once.     So it is IMO unrelated to the fact that these are legacy users as opposed to newly created users.
Reset password
[HttpPost]
[AllowAnonymous]
[ValidateAntiForgeryToken]
public async Task<IActionResult> ForgotPassword([FromForm] ForgotPasswordViewModel model)
{

    {removed}

     var passwordResetCode = await _userManager.GeneratePasswordResetTokenAsync(user);
     var passwordResetCallbackUrl = Url.ResetPasswordCallbackLink(user, model.ReturnUrl, passwordResetCode, Request.Scheme);

      {removed}
      return RedirectToAction(nameof(ForgotPasswordConfirmation));
}

Helper method
public static string ResetPasswordCallbackLink(this IUrlHelper urlHelper, ApplicationUser user , string returnUrl, string code, string scheme)
       {
           return urlHelper.Action(
               action: nameof(AccountController.ResetPassword),
               controller: "Account",
               values: new { userid = user.Id, code = Uri.EscapeDataString(code), returnUrl },
               protocol: scheme);
       }

EscapeDataString
I have recently started using EscapeDataString i read this very old question on stackAsp.NET Identity 2 giving “Invalid Token” error and figured it was worth a try.       I cant verify that it works yet.   Its fall vacation this year the number of users trying to reset their password this week isnt enough to verify that its working.
An Example
If it helps this was an invalid code that had been requested last week.      But i am running out of ideas.  I sent out a call on Twitter and Barry Dorrans responded and suggested i post this here.    Any help would be greatly appreciated.
Our UserId is a long not the standard GUID.  This was due to the legacy system.  Changing that to support GUID would have been to big of a job.
My current idea
Ok after digging around in the library.  I think I have an idea.   What if i create a custom IUserTwoFactorTokenProvider basically copy DataProtectorTokenProvider.   My idea is to create a validation method then call that from ValidateAsync.   I want to use the exact same one thats used in DataProtectorTokenProvider.   By having one that i can call that will return the error rather than just a true and false i can call that if the validate fails and then log why it failed.

@LindaLawton do these users have valid security stamps?

You should be able to test users by just calling Generate and Validate right away, see if any of the users fail when doing that...
   var token = await _userManager.GeneratePasswordResetTokenAsync(user);
   var result = await VerifyUserTokenAsync(user, _userManger.Options.Tokens.PasswordResetTokenProvider, _userManager.ResetPasswordTokenPurpose, token))

Otherwise if i were to guess what's going on, maybe the security stamp for those users has changed after the token was generated, that would cause the tokens to be invalid.

It looks like when a key is created it's not getting stored in the Redis cache. Can you try dumping the cache and see what's in it?

@blowdart  I am in the process of getting access to the cluster so i can see this information.   How soon after i see the error do you need me to dump the cache?
Just got another intersting error from my logging

System.FormatException: Invalid length for a Base-64 char array or string.
   at System.Convert.FromBase64_Decode(Char* startInputPtr, Int32 inputLength, Byte* startDestPtr, Int32 destLength)
   at System.Convert.FromBase64CharPtr(Char* inputPtr, Int32 inputLength)
   at System.Convert.FromBase64String(String s)
   at Xena.IdentityServer.Services.CustomDataProtectorTokenProvider`1.<ValidateAsync>d__13.MoveNext() in /var/lib/jenkins/_xena-identityserver_master-GOXBVJ5FZB6XR4BFBDEOFNCAVTISFMJUP3YCSGLXO77AA655HWSQ/src/Xena.IdentityServer/Services/CustomDataProtectorTokenProvider.cs:line 113

As that's identity server I have no insight as it's not us

Xena.IdentityServer.Services.CustomDataProtectorTokenProvider

That looks more like custom code in IdentityServer.

@brockallen if you are following the thread.  I have created a CustomDataProtectorTokenProvider which is a pure copy of DataProtectionTokenProvider.cs simply adding some logging since the default version does not contain any logging.
There is no custom code in this.  Its just logging so that we can try and track down what the issue is.


Update README to include details on MFA watchers

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Fixed Point Value

[ ] Implement a FixedPointValue class to represent signed, fixed point numbers following Q notation

@desmonddak , is this in the right direction?

If you do a pull, you could try my new 'vecString' routine as it may help you in debug (for me it is important because of alignment issues).
import 'package:rohd_hcl/src/arithmetic/arithmetic_utils.dart';
extension FixedPointVector on FixedPointValue {
  String vecString(String name,
          {int prefix = 10,
          int? align,
          bool header = false,
          String sepChar = '*',
          int lowLimit = 0,
          bool markDown = false}) =>
      value.vecString(name,
          prefix: prefix,
          align: align,
          sep: fraction.width,
          header: header,
          sepChar: sepChar,
          lowLimit: lowLimit,
          markDown: markDown);
}

@desmonddak and @mkorbel1 can we do a final review and merge this PR? I want to start fixed to float in a new PR to ease review.

i don't know what happened with the force-push.  I don't know if this is going to create conflicts with stuff I've checked in already.
Did you do a pull before you pushed?
I'll try to merge today, but I haven't seen a force-push before and not sure what to look for...

I think GitHub can handle the diff no matter how it got there


[Onchain Squad] Docs Request: Contract to Contract Exercise

What is the issue you are encountering with the docs?
This is a very advanced issue.  Please do not start without first discussing with @briandoyle81CB!  Tag me here if you are interested, and we can discuss on Discord
The Contract to Contract lessons are missing an exercise with a smart contract graded unit test awarding an NFT.  This exercise should match the others in terms of scope and complexity, and require the learner to demonstrate mastery of the learning objectives for this section.
It should inherit from the Cafe smart contract and contain tests written in the same format as the others.
Links to Impacted Docs
https://docs.base.org/base-camp/docs/interfaces/contract-to-contract-interaction
Describe the solution you'd like to see.
A focused exercise testing against the learning objectives for this section.
Additional context
Example of a unit test: https://sepolia.basescan.org/address/0x15534ed3d1dba55148695b2ba4164f147e47a10c#code#F18#L1

Closing issue with conclusion of 30 Days of Web3.


is it possible to remove an item from a yaml file, or only create/update?

Delete is not possible but you can use the method to decide if you only want to update/create


Add x-pack features to XPackUsage and XPackInfo responses

Relates: #4001
This commit adds features to XPackUsage and XPackInfo responses

ported to master


For java and objective-c binding, ensure the cluster object is be freed when the session is released

Problem
The cluster object is ephemeral, but in Java implementation, its lifespan is managed by GC. It must guarantee that the cluster object is be freed when the session is released.
Proposed Solution
The Java and objective-c binding should implement OnSessionReleased callback, null-out the cluster, and deny all future operations to the cluster.

@bzbarsky-apple Should we separate the darwin and android changes here?

The Darwin part of this was fixed in https://github.com/project-chip/connectedhomeip/pull/21504: we no longer hold on to CHIPCluster objects anywhere on the heap; we just stack-allocate them.  So this is a pure Android issue now.


Debug Level 0 still too spammy

Fabric Version : 0.53.4+1.18.2
Minecraft Version: 1.18.2
WorldSeed: -4349325659081433721
Describe the bug
With the debugLevel option set to 0, Regrowth still fills the log with an endless stream of messages. One random selection of ten seconds worth of logging contained about 60 lines of just Regrowth warning about "minecraft:forest wall improvement".
To Reproduce
Steps to reproduce the behavior:

Launch a Minecraft server.
Log in with a client.
Watch the log fill up.

Expected behavior
debugLevel=0 should log initialisation messages, errors, and little, if anything, else. Information about improvements and villager actions should be reserved for higher debug levels.
Log
https://pastebin.com/UedJ6FaT
Additional context
I do have some things installed on the server that may increase the number and/or size of villages (ChoiceTheorem's Village Overhaul datapack is the most likely candidate), which would exacerbate the severity of this issue.

There should be only one or two messages total from regrowth on startup at level 0.   I must have left in a development message.   Sorry about that.   I'll put out a fix asap.  Probably by tomorrow morning.

I've located the debugging statement.  I had temporarily lowered it to 0 to verify the functionality was being executed and missed it.  I did a check for any other debugging statements at 0 in the main event loop and found one for villagers on a wall perimeter.  I set it to level 1 as well.
Building version 30d for fabric now.  Will upload after testing.

Okay, I verified this was not an issue with 1.16.5 for fabric.  I guess I fixed those messages when I made the 1.16.5 from the 1.18.2 version.
You should be good to go!  I'll close this when I hear from you or next wednesday.

Awesome! Thanks for digging into it.

You are welcome.  I appreciated feedback on my mods.  Problems, suggestions, etc.
Cheers!
Two Guys
MacTso


ACK runtime upgrade v0.17.2 => v0.18.0

Description of changes:

ACK runtime upgrade v0.17.2 => v0.18.0
ACK runtime v0.18.0 release notes

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

/lgtm


Phase 0: MVP

Description
Final components of the original MVP work on Homestar.

Children:

[ ] https://github.com/ipvm-wg/homestar/issues/61
[x] https://github.com/ipvm-wg/homestar/issues/276

Note: This roadmap is subject to change as priorities and circumstances evolve.
Starmap Link ⭐🗺
ETA: 2023-10-20

Moving the last item over to Phase 1 and closing this out.


fix: remove multi invitation example

Well the question is if we want to kill the example or add the proper response example: https://github.com/owncloud/libre-graph-api/pull/154

Well the question is if we want to kill the example or add the proper response example: #154

i'm fine with both


[Company Cards] Card number is not visible in the cards table

Coming from here
When connecting a direct feed connection, we are missing the last 4 pan number in the company cards feed table.

The issue will be fixed in this PR: https://github.com/Expensify/App/pull/52893#issuecomment-2491312432

@VickyStash, does this mean we can close this issue because it will be fixed when the other issue is fixed?

Yes we can let this open until the pr is deployed to production and then we can close it as we will handle the regression tests addition with Joe for the project altogether

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production
[ ] 2b. Reported on staging (deploy blocker)
[ ] 2c. Reported on both staging and production
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎

Noone to pay here now and no need for regression testing


CSV Export broken in Development

Error Message
Exporting f65297df-31f4-4375-9504-e6280aeb575b counter history to CSV
(node:69874) UnhandledPromiseRejectionWarning: TypeError: res.csv is not a function
    at /Users/vsaw/Documents/Development/opendatacam/server.js:910:13
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:69874) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)

Most likely this was introduced with the eslint fixes.

Fixed in #362.

Fixed in #362.


Update SDK version in the header to 2.2

Splitting https://github.com/Azure/azure-mobile-services/pull/742 into 2 separate PRs. One for the header changes and one for the readme changes. We can continue to use https://github.com/Azure/azure-mobile-services/pull/742 for the readme changes.


Add Security Samples (IWA)

IWA and PKI samples are in the following pull request:
https://github.com/Esri/arcgis-runtime-samples-dotnet/pull/111