PhantomJS 2.1.1 port to ppc64le - pagesize changes.

I am planning to upstream following fix in webkit 5.5.1 to support ppc64le.  I would like to know if PhantomJS 2.1.1 will pull it automatically once it is approved and merged by the webkit community (basically, will it also be available in vitallium/qtwebkit.git as well). Thanks!

Which version of PhantomJS are you using? Tip: run phantomjs --version.
PhantomJS 2.1.1

What steps will reproduce the problem?
Nothing in particular.

Which operating system are you using?
Ubuntu 16.04LTS on ppc64le (Power8/LE)

Did you use binary PhantomJS or did you compile it from source?
Compiled PhantomJS from source cloned from GitHub.

Please provide any additional information below.
For using PhantomJS on ppc64le, a change in pagesize value is required. On x86_64, pagesize value is 32KB. On ppc64le, default pagesize is 64KB. Webkit submodule needs to be updated for this.

@asowani I saw your messages in WebKit mailing list ;-) We plan to use revived fork of QtWebKit (https://github.com/annulen/webkit) I suggest to send your patches there.

Thanks @Vitallium I will send my patches to the said fork.

@asowani It would be even better if you got your patches merged to trunk, then I would cherry-pick them

https://github.com/annulen/webkit/wiki/How-to-submit-patches-to-webkit.org


Fix minor documentation issues

Description
Fix minor documentation issues and reorganize home page
Checklist

[ ] I have run cargo make pr-flow
[ ] I have reviewed my own code
[ ] I have added tests

Tried in the preview website, if you have closed the sidebar by clicking the logo on the upper left. There is no apparent way of bringing back the side menu. I tried a bit and found that clicking on the version button and the docs button actually brings out the sidebar. But they make the current page jump...

(say if you are on "using trunk" page, clicking on "Docs" jumps you to introduction, and clicking on the version selector jumps you to "Build a sample app")

In comparison, https://docusaurus.io/docs has buttons to exand and close the side bar

Also the bot now needs to append /next/getting-started/project-setup/introduction to the preview url?

@Madoshakalaka, I fixed the next redirect issue. Also, the docs button properly highlights now.
The issue you're describing with not being able to show sidebar is different. The home page is now an actual page now instead of a docs redirect. You can navigate to docs page by clicking the docs button in the navbar. I think the issue here is that you're used to the old design and new one feels "wrong"

@hamza1311 alright, sounds good

Sure, I can add that but changing docs after that is gonna be inconvenient

Sure, I can add that but changing docs after that is gonna be inconvenient

Why? I believe its possible to just add a version without copying all files, right?

The command will create a copy of all the files and add a new version

The command will create a copy of all the files and add a new version

Hmm i guess we have no other option, we want to serve 0.19 as default when people come to the page

But probably thats a diffrent PR then

Well, I did it now. We can just roll with it. Instead of changing anything else, let's release now

@hamza1311 Change the PR header then aswell

@voidpumpkin done


Content negotiation and correct redirections for croissant specification

According to https://github.com/mlcommons/croissant/blob/main/docs/croissant.ttl, The croissant namespace is <http://mlcommons.org/croissant/>
However, http://mlcommons.org/croissant/ redirects to https://mlcommons.org/working-groups/data/croissant/ instead of https://mlcommons.github.io/croissant/docs/croissant-spec.html.
In addition, there is no content negotiation on JSON-LD / TTL, making it tricky to import in other vocabularies. Is there a plan to support JSON-LD content negotiation? I.e., when doing:
curl -H "Accept:application/json+ld" -L http://mlcommons.org/croissant/

Obtain a json-ld context with the full specification.
I think this would help clarify which concepts are defined within croissant without having to read the specification to detail. Other namespaces like <http://mlcommons.org/croissant/RAI/> lead to a 404.

Btw, if there is a need to generate an open community maintained persistent id for croissant like https://w3id.org/croissant/ with content negotiation support (resources can be stored in the mlcommons.org, github or elsewhere), I can help setting it up in https://github.com/perma-id/w3id.org?tab=readme-ov-file#permanent-identifiers-for-the-web.


Uninstall page feedback

After a user uninstalls the extension, a page on the Toggl website will be opened in their browser **to provide feedback (via web extension).
This page will anonymously ask for:

The reason(s) the user uninstalled, selected from a short list

Things like "It didn't work with services I use", "I didn't want to sign up", "Too complicated", "I had to use the web app as well" etc.

Optionally, a text feedback message can be entered.

Plans:

Add paged based off 'contact' page to Firefly.
Adjust to include only radio options and a message field.
Create cloud-function endpoint in Firebase project

Support CORS for toggl.com
Validate payload - accept message and array of reasons - fallback to a default message in case of unexpected problems.
Sanitizes input a bit
Save to Firestore record

Send form to endpoint, handle outcomes (If there is unhandled server error, let's show the success state anyway?)
Create a "success/thank you" state
Include important button links that may help the user etc.
Set up uninstall hook in the extension to open the uninstall page in a new tab.

ZenHub's uninstall page

https://www.zenhub.com/goodbye

Closed via #1392


feat: refactor plugin to us SfCommand

Same as #63, but hoping this will actually run the Circle CI tests?

This should not be a breaking change. Main changes are related to the base command class (SfCommand). The changes due to the adoption of a new base class for commands are minor. The core libraries used are the same so no risk there.
The refactor of unit tests to remove fancy test is something we are trying to do across the board. The tests in this project required only minimal changes and the test results for the PR are all green.


Fog depth mode None in Desert Area bugging out

Similar issue to
https://github.com/RS117/RLHD/issues/5
setting it to static/dynamic seems to fix issue

This is the same issue as #5, I already have my PR up for it. You may close this one.

My bad; I didn't see your diff and thought that the issue is present when the static fog depth is at 0 so thought it was different issue. Thanks for the fix! will I have to update the plugin or is that automatic for runelite?

It will update automatically after relaunching Runelite whenever 117 pushes a new version to the plugin hub.


interactive mode results in an empty refresh_token

As described here in https://github.com/Azure/kubelogin/issues/311 it looks like interactive login mode is not getting a refresh token, so reauth is required every ~70 minutes (validity of AAD access token). It looks like all the upstream issues mentioned in the original issue https://github.com/Azure/kubelogin/issues/311 in azure go sdk are closed/implemented.
Using interactive is IMO more user-friendly and should support caching of the refresh token in a similar way to how devicecode works.

Token caching is only supported in v1.8.0-beta
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/TOKEN_CACHING.MD?plain=1#L21

I think azidentity sdk 1.8.0 was released yesterday:
https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazidentity%2Fv1.8.0
And there is already a dependabot pull request :-)
https://github.com/Azure/kubelogin/pull/534

cool. I will take a look next week. I actually re-wrote almost everything in https://github.com/weinong/kubelogin/tree/feat/token-cache with preview sdk. If you want to test, go for it! I need to add tests.


Build fail on dependancies

Since few days, the build is failing on dependancies in my docker dev container:
g++   -shared -pthread -L. -Wl,-whole-archive librandomx.a -Wl,-no-whole-archive -o librandomarq.so  -lstdc++ -lgcc -lc
/workspace/miningcore/src/Miningcore/Miningcore.csproj(123,9): error MSB3073: The command "(cd /workspace/miningcore/src/Miningcore/ && sh build-libs-linux.sh bin/Debug/net6.0/)" exited with code -1.
Build FAILED.
crypto/oaes_lib.c(514,2): warning GAB0B5702: 'ftime' is deprecated [-Wdeprecated-declarations] [/workspace/miningcore/src/Miningcore/Miningcore.csproj]
/usr/lib/gcc/x86_64-linux-gnu/10/include/wmmintrin.h(87,1): error GA9D18FE8: inlining failed in call to 'always_inline' '_mm_aeskeygenassist_si128': target specific option mismatch [/workspace/miningcore/src/Miningcore/Miningcore.csproj]
/usr/lib/gcc/x86_64-linux-gnu/10/include/avxintrin.h(454,1): error GA9D18FE8: inlining failed in call to 'always_inline' '__m256 _mm256_cvtepi32_ps(__m256i)': target specific option mismatch [/workspace/miningcore/src/Miningcore/Miningcore.csproj]
/usr/lib/gcc/x86_64-linux-gnu/10/include/avxintrin.h(908,1): error GA9D18FE8: inlining failed in call to 'always_inline' '__m256i _mm256_load_si256(const __m256i*)': target specific option mismatch [/workspace/miningcore/src/Miningcore/Miningcore.csproj]
/workspace/miningcore/src/Miningcore/Miningcore.csproj(123,9): error MSB3073: The command "(cd /workspace/miningcore/src/Miningcore/ && sh build-libs-linux.sh bin/Debug/net6.0/)" exited with code -1.
1 Warning(s)
4 Error(s)
Time Elapsed 00:02:15.39
I tried with  'dotnet publish -c Debug --framework net6.0' and 'dotnet build', same result.
But the weird thing is that my builder image for production is not failing. I'm not sure of what's wrong in my dev container, as it is the exact same docker image with same packages.

Im facing the same issue when I tried to set up by docker on MacOS

Im facing the same issue when I tried to set up by docker on MacOS

Are u using binding mount volume on your host file system for the sources?

Exact same problem here.
Miningcore.csproj(123,9): error MSB3073: The command "(cd /workspace/miningcore/src/Miningcore/ && sh build-libs-linux.sh bin/Debug/net6.0/)
I can not compile it. Running LXD virtual-machine "images:ubuntu/20.04/cloud".
Thanks.

I've just tried to build Mining core using the release package  v72 (https://github.com/oliverw/miningcore/archive/refs/tags/v72.tar.gz) instead of git cloning this repo and got this error when building it:
(cut)
Building into ../../build
MSBuild version 17.3.0+92e077650 for .NET
Determining projects to restore...
All projects are up-to-date for restore.
Cannot find the .git directory
/root/.nuget/packages/gitversion.msbuild/5.10.3/tools/GitVersion.MsBuild.targets(9,9): error MSB3073: The command "dotnet --roll-forward Major "/root/.nuget/packages/gitversion.msbuild/5.10.3/tools/netcoreapp3.1/gitversion.dll" "/root/miningcore-72/src/Miningcore" -output file -outputfile obj/gitversion.json" exited with code 1. [/root/miningcore-72/src/Miningcore/Miningcore.csproj]
alien@mars:~/miningcore-72#

Try this and see if it works.
https://github.com/lurchinms/kriptokyng_miningcore

Try this and see if it works. https://github.com/lurchinms/kriptokyng_miningcore

Same problem. Tried ./build-ubuntu-20.04.sh on a a new virtual machine Ubuntu 20.04 LTS, totally updated.

@lurchinms I am using the image "images:ubuntu/20.04/cloud" on a LXD virtual machine. Maybe some packages are missing on this Ubuntu image, but I have no clue which ones.

@lurchinms I am running on a Xeon E5-2650L v2

@lurchinms Trying again on the same virtual machine but this time I increased the numbers of CPUs to 8 and the memory to 8GB. It worked!!

Compiled @lurchinms fork of miningcore without problem running ./build-ubuntu-20.04.sh on a virtual machine with Ubuntu 20.04, 8 cpus and 8GB of RAM.
On the other hand the original Miningcore did not build in this same virtual machine. I am attaching the full log of the build process.
build-ubuntu-20.04-log.txt
I hope this helps.

Oddly enough, if I run the command ``(cd /root/miningcore/src/Miningcore/ && sh build-libs-linux.sh bin/Release/net6.0/)` directly it works without any problem. It only crashes when called from the dotnet publish,  inside the ./build-ubuntu-20.04.sh.

Try this and see if it works. https://github.com/lurchinms/kriptokyng_miningcore

@lurchinms
I ended up switching to your repo. I was able to build it without any problem, kept my previous pool config files and all my pools are working fine and as a bonus I now also have Monero working. Thank you very much. 🙏

[SOLVED] #1350

Cannot reproduce anymore on dev branch.


(URGENT) Broken "NIST SP 800-nn{part}r{x}" when {part} exists

PubID
Original

NIST SP 800-53A
NIST SP 800-53Ar4

NIST SP 800-56A
NIST SP 800-56a

NIST SP 800-56A
NIST SP 800-56ar

NIST SP 800-56A
NIST SP 800-56Ar2

NIST SP 800-56A
NIST SP 800-56Ar3

NIST SP 800-56B
NIST SP 800-56b

NIST SP 800-56B
NIST SP 800-56Br1

NIST SP 800-56B
NIST SP 800-56Br2

NIST SP 800-56C
NIST SP 800-56c

NIST SP 800-56C
NIST SP 800-56Cr1

NIST SP 800-56C
NIST SP 800-56Cr2

i.e. "NIST SP 800-53Ar4" is correct, it should not be changed into "NIST SP 800-53A".

It was fixed before, check it again please

Confirmed. Thanks!


chore(package): update local-repository-provider to version 6.4.55

Coverage remained the same at 34.082% when pulling ff52623e29aa1355a8483f9ef109ddf690e3404b on greenkeeper/local-repository-provider-6.4.55 into 3526d898d46dda75e620f021885818f9f8121e55 on master.


Cat1 fixes

This all looks good to me. I haven't read through this STIG but the role as is looks like it will really only work for PG on Red Hat or CentOS?

Yes, that's the case for now. One of the Cat 1 checks is "must be running on RHEL"

Ok that is a strange requirement for DISA to put in the STIG but what do I know haha.


boards: arm: nucleo_f746zg: Created a new stm32 nucleo board.

Added a basic board for the nucleo_f746zg. Tested with hello_world
sample using the UART provided via the onboard STLINK.
Signed-off-by: AJ Palmer<EMAIL_ADDRESS>

Codecov Report

Merging #10419 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10419   +/-   ##
=======================================
  Coverage   53.14%   53.14%
=======================================
  Files         210      210
  Lines       25745    25745
  Branches     5673     5673
=======================================
  Hits        13681    13681
  Misses       9754     9754
  Partials     2310     2310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e98fa...865b902. Read the comment docs.

@ajpcode Any reason why you're only bringing in a small subset of the peripherals? Ethernet works just fine on this board and would allow to use many of the networking samples as well. I do have a complete set of patches (sans the documentation, hence I haven't done a PR yet) and I'd be happy to share them with you if you'd like to work them in.

@therealprof Hi, this is my first attempt at a contribution so I'm a bit new to the process (didn't want to commit too much on my first attempt). I've also had Ethernet, SPI and I2C working albeit on v1.10 but if I can figure out how this contribution thing works I'd be happy to try and integrate your more up-to-date work.

@ajpcode It's okay then, I don't want to overload you here. Let's hear back from the friendly Zephyr folks about your contribution and follow up with the additional stuff later.

@erwango - Thank you for your feedback.
There isn't an awful lot of peripheral support for the F7 in Zephyr at the moment (ref: soc/arm/st_stm32/stm32f7/soc.h and boards/arm/stm32f746g_disco/doc/stm32f746g_disco.rst) - I was hoping to add some of it once I had a board to work from.
I could maybe add I2C pinmux (sample/sensor/bme280 test) and maybe add GPIO definitions for LEDs/user buttons on the board (and test with samples/basic/blinky)?
I feel the device driver addition is probably worthy of it's own PR - at which point I can add the respective feature to the board. I suppose I'm trying not to over-extend this request into too many areas - how would you feel about this?
Kind regards.

@ajpcode I've pushed my current draft version here: https://github.com/therealprof/zephyr/tree/preliminary-nucleo-f746zg-support
Feel free to pick up whatever pieces you see fit. I've been testing networking with this extensively, which is one of the key features of this board.

@therealprof I'm just having a look now. Ethernet seems a good place to start then I'll pull the pinmux and DT definitions for the LEDs and PB. Were you testing anything specific with the PWM (ref: pinmux.c)?

Nope, haven't used PWM on this board. Most of the peripherals are equivalent to the similarly sized Nucleo-F429ZI, though, so if it works there chances are good it'll work here, too.

Nope, haven't used PWM on this board. Most of the peripherals are equivalent to the similarly sized Nucleo-F429ZI, though, so if it works there chances are good it'll work here, too.

I agree that it will likely work (although I am unable to test right now) but as PWM appears to be broken out to CN7 (PD9, PD8) and is not hardwired to a device on the board it seems like something a user would specify for their individual projects rather than something the board might specify for them - that would be my interpretation although I am open to alternative thoughts.
Can you think of any other changes from your preliminary work that I've overlooked @therealprof ?

@erwango - Would this be an acceptable initial feature set for this board (pinmux, gpio, uart, i2c, ethernet, usb + led and sw definitions) ?

@erwango After reordering my commits... I've just found the following:
arduino_i2c: &i2c1 {};
arduino_spi: &spi1 {};
arduino_serial: &usart6 {};
... is this what you meant by ... ?

Last, as every nucleo board, the bard should feature arduino connector.
So please add available arduino connectors (uart and i2c), cf nucleo_f429zi as ref.

@ajpcode

... is this what you meant by ... ?

Yes

recheck

@erwango Are the changes I've made acceptable, do you feel I've missed anything?
@dbkinder I believe I've corrected the documentation in line with your feedback - was there anything else you would like to see?

@ajpcode , this is fine, thanks! Approved

Updated documentation in line with @dbkinder 's comment in my other pull request.
Rebased and added SPI support (tested).


feat: Add new outputs mapping subnet IDs to AZs

Description
This adds outputs mapping subnet IDs to AZs. This allows comparing AZs with a remote PrivateLink Endpoint Service to find out in what subnet we can create an endpoint locally, as PrivateLink requires both ends use the same AZs.
Breaking Changes
No, these are only new outputs.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s) - Not sure its relevant for outputs

[X] I have tested and validated these changes using one or more of the provided examples/* projects - I applied it directly to a module of mine that, among other things, locates matching AZs on both ends of a PrivateLink VPC Endpoint

[X] I have executed pre-commit run -a on my pull request

LGTM! 👍

Could a maintainer pls take a look at this? I'm happy to keep working on it if its not currently adequate. Thanks!


feat: add tests for add data using File DOM api

depends on:
https://github.com/hugomrdias/js-ipfs-utils

The code for these three PRs LGTM 👍
I wonder if it would make sense to put the shared util code into this repo (interface-js-ipfs-core) instead of having another repo (js-ipfs-utils), so that there is less overhead in terms of releases etc when there are changes made to the utils code?

Yeah I also thought of that, and discussed a bit with Alan and because this repo is only tests a new repo seemed appropriate. Release overhead is a strong point I can revert utils into this repo if we all agree.
Please take a look at the ipfs-utils tests and give feedback, I introduced there the concept of self skipping tests, so we don't need to skip multiple times in the interface-core implementations.

ping @hugomrdias


Add common footer with a Github icon and link to this repo

What problem does your feature solve?
Better visibility to code and a way for users to provide feedback, log bugs, and submit changes themselves.
What would you like to see?
A footer added to the mainpage with the Github icon and link to the Issues or Main page of this repo
What alternatives are there?
We can keep the announcement banner at the top of the page for a bit but other than that there isn't an easy way to discover this repo.

Text on the footer: "Check out our Github repo more information and to log issues"
That may be too wordy @lydiat

@shanzzam @lydiat We could show a longer description on hover.

P.S. I will add the GitHub icon once we've finalized the link text.

More links added in https://github.com/stellar/stellar-demo-wallet/pull/171

@quietbits looks good! I've reviewed and will close this as complete.


Add a new fuzz input data for FuzzParse in github.com/shogo82148/fowa…

…rded-header.
fuzzing failed with the following output:
--- FAIL: FuzzParse (27.11s)
    --- FAIL: FuzzParse (0.00s)
        fowarded_test.go:309: "for=\"[::%]]\"": ParseAddr("::%"): zone must be a non-empty string
        fowarded_test.go:314: Parse() mismatch (-want +got):
              []*fowardedheader.Forwarded(
            - 	{s`for="[::%]]"`},
            + 	nil,
              )

    Failing input written to testdata/fuzz/FuzzParse/e5d1d4cde8dae165
    To re-run:
    go test -run=FuzzParse/e5d1d4cde8dae165
FAIL
exit status 1
FAIL	github.com/shogo82148/fowarded-header	27.110s

The result of go test -run=FuzzParse/e5d1d4cde8dae165 github.com/shogo82148/fowarded-header is:
--- FAIL: FuzzParse (0.00s)
    --- FAIL: FuzzParse/e5d1d4cde8dae165 (0.00s)
        fowarded_test.go:309: "for=\"[::%]]\"": ParseAddr("::%"): zone must be a non-empty string
        fowarded_test.go:314: Parse() mismatch (-want +got):
              []*fowardedheader.Forwarded(
            - 	{s`for="[::%]]"`},
            + 	nil,
              )
FAIL
FAIL	github.com/shogo82148/fowarded-header	0.002s
FAIL

This fuzz data is generated by actions-go-fuzz.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (83685a5) 72.92% compared to head (1b8422b) 74.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   72.92%   74.84%   +1.91%
==========================================
  Files           1        1
  Lines         314      314
==========================================
+ Hits          229      235       +6
+ Misses         59       55       -4
+ Partials       26       24       -2

Flag
Coverage Δ

Go-1.18
74.84% <ø> (+1.91%)
:arrow_up:

Go-1.19
74.84% <ø> (+1.91%)
:arrow_up:

Go-1.20
74.84% <ø> (+1.91%)
:arrow_up:

Go-1.21
74.84% <ø> (+1.91%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: Automatic cache updates

Description
This PR introduces cache update helpers to manage maintaining the cache for your application.

Checklist

[x] npm test passes
[x] npm run build works
[x] tests are included
[ ] documentation is changed or added

No need for documentation now. Great work


Edit mode won't load in all browsers (SOLVED)

URL
https://www.openstreetmap.org/edit#map=19/-6.92823/107.77545
How to reproduce the issue?
Simply clicking the edit button with in-browser editor
Screenshot(s) or anything else?
There has been frequent update logs from users claiming to be with the "Apple team". Wonder if this causes an overload - likely the issue
What version numbers does this issue effect?
SOLVED, I can't see version number in viewing mode, only editing - 2.28.1
Which browsers are you seeing this problem on?
Chrome, Microsoft Edge

I am closing this given the update to the title to be "SOLVED"


bump dependencies

Applied mkpr on undefined
/tmp/mkpr.sh

:tada: This PR is included in version 1.10.92 :tada:
The release is available on:

v1.10.92
GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


windows package installation failed due to MS VC 14 is required

Hello,
I am using windows images and my work stoped at installation with my requirements.txt.
The error msg says the packages bcrypt and cryptograpy, but they actually are dependencies of the paramiko.
It suggested that "Microsoft Visual C++ 14.0 or greater is required.". Is it possible to have MS VC in the image or there is any alternatives for it ?
Building wheels for collected packages: bcrypt, cryptography
  Building wheel for bcrypt (PEP 517): started
  Building wheel for bcrypt (PEP 517): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: 'c:\Python37\python.exe' 'c:\Python37\lib\site-packages\pip\_vendor\pep517\_in_process.py' build_wheel 'C:\users\root\Temp\tmpsbmal0ym'
       cwd: C:\users\root\Temp\pip-install-mbq2n6lm\bcrypt
  Complete output (15 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.7
  creating build\lib.win-amd64-3.7\bcrypt
  copying src\bcrypt\__about__.py -> build\lib.win-amd64-3.7\bcrypt
  copying src\bcrypt\__init__.py -> build\lib.win-amd64-3.7\bcrypt
  copying src\bcrypt\py.typed -> build\lib.win-amd64-3.7\bcrypt
  running build_ext
  generating cffi module 'build\\temp.win-amd64-3.7\\Release\\_bcrypt.c'
  creating build\temp.win-amd64-3.7
  creating build\temp.win-amd64-3.7\Release
  building '_bcrypt' extension
  error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
  ----------------------------------------
  ERROR: Failed building wheel for bcrypt
  Running setup.py clean for bcrypt
  Building wheel for cryptography (PEP 517): started
  Building wheel for cryptography (PEP 517): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: 'c:\Python37\python.exe' 'c:\Python37\lib\site-packages\pip\_vendor\pep517\_in_process.py' build_wheel 'C:\users\root\Temp\tmpz6g2fb2u'
       cwd: C:\users\root\Temp\pip-install-mbq2n6lm\cryptography
  Complete output (141 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.7
  creating build\lib.win-amd64-3.7\cryptography
  copying src\cryptography\exceptions.py -> build\lib.win-amd64-3.7\cryptography
  copying src\cryptography\fernet.py -> build\lib.win-amd64-3.7\cryptography
  copying src\cryptography\utils.py -> build\lib.win-amd64-3.7\cryptography
  copying src\cryptography\__about__.py -> build\lib.win-amd64-3.7\cryptography
  copying src\cryptography\__init__.py -> build\lib.win-amd64-3.7\cryptography
  creating build\lib.win-amd64-3.7\cryptography\hazmat
  copying src\cryptography\hazmat\_der.py -> build\lib.win-amd64-3.7\cryptography\hazmat
  copying src\cryptography\hazmat\_oid.py -> build\lib.win-amd64-3.7\cryptography\hazmat
  copying src\cryptography\hazmat\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat
  creating build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\base.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\certificate_transparency.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\extensions.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\general_name.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\name.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\ocsp.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\oid.py -> build\lib.win-amd64-3.7\cryptography\x509
  copying src\cryptography\x509\__init__.py -> build\lib.win-amd64-3.7\cryptography\x509
  creating build\lib.win-amd64-3.7\cryptography\hazmat\backends
  copying src\cryptography\hazmat\backends\interfaces.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends
  copying src\cryptography\hazmat\backends\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends
  creating build\lib.win-amd64-3.7\cryptography\hazmat\bindings
  copying src\cryptography\hazmat\bindings\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\bindings
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\cmac.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\constant_time.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\hashes.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\hmac.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\keywrap.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\padding.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\poly1305.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  copying src\cryptography\hazmat\primitives\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives
  creating build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\aead.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\backend.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\ciphers.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\cmac.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\decode_asn1.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\dh.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\dsa.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\ec.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\ed25519.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\ed448.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\encode_asn1.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\hashes.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\hmac.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\ocsp.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\poly1305.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\rsa.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\utils.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\x25519.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\x448.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\x509.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  copying src\cryptography\hazmat\backends\openssl\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\backends\openssl
  creating build\lib.win-amd64-3.7\cryptography\hazmat\bindings\openssl
  copying src\cryptography\hazmat\bindings\openssl\binding.py -> build\lib.win-amd64-3.7\cryptography\hazmat\bindings\openssl
  copying src\cryptography\hazmat\bindings\openssl\_conditional.py -> build\lib.win-amd64-3.7\cryptography\hazmat\bindings\openssl
  copying src\cryptography\hazmat\bindings\openssl\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\bindings\openssl
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\dh.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\dsa.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\ec.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\ed25519.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\ed448.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\padding.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\rsa.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\utils.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\x25519.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\x448.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  copying src\cryptography\hazmat\primitives\asymmetric\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\asymmetric
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  copying src\cryptography\hazmat\primitives\ciphers\aead.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  copying src\cryptography\hazmat\primitives\ciphers\algorithms.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  copying src\cryptography\hazmat\primitives\ciphers\base.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  copying src\cryptography\hazmat\primitives\ciphers\modes.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  copying src\cryptography\hazmat\primitives\ciphers\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\ciphers
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\concatkdf.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\hkdf.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\kbkdf.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\pbkdf2.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\scrypt.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\x963kdf.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  copying src\cryptography\hazmat\primitives\kdf\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\kdf
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  copying src\cryptography\hazmat\primitives\serialization\base.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  copying src\cryptography\hazmat\primitives\serialization\pkcs12.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  copying src\cryptography\hazmat\primitives\serialization\pkcs7.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  copying src\cryptography\hazmat\primitives\serialization\ssh.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  copying src\cryptography\hazmat\primitives\serialization\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\serialization
  creating build\lib.win-amd64-3.7\cryptography\hazmat\primitives\twofactor
  copying src\cryptography\hazmat\primitives\twofactor\hotp.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\twofactor
  copying src\cryptography\hazmat\primitives\twofactor\totp.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\twofactor
  copying src\cryptography\hazmat\primitives\twofactor\utils.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\twofactor
  copying src\cryptography\hazmat\primitives\twofactor\__init__.py -> build\lib.win-amd64-3.7\cryptography\hazmat\primitives\twofactor
  running egg_info
  writing src\cryptography.egg-info\PKG-INFO
  writing dependency_links to src\cryptography.egg-info\dependency_links.txt
  writing requirements to src\cryptography.egg-info\requires.txt
  writing top-level names to src\cryptography.egg-info\top_level.txt
  reading manifest file 'src\cryptography.egg-info\SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  no previously-included directories found matching 'docs\_build'
  warning: no previously-included files found matching 'vectors'
  warning: no previously-included files matching '*' found under directory 'vectors'
  warning: no previously-included files matching '*' found under directory '.github'
  warning: no previously-included files found matching 'release.py'
  warning: no previously-included files found matching '.coveragerc'
  warning: no previously-included files found matching 'codecov.yml'
  warning: no previously-included files found matching '.readthedocs.yml'
  warning: no previously-included files found matching 'dev-requirements.txt'
  warning: no previously-included files found matching 'rtd-requirements.txt'
  warning: no previously-included files found matching 'tox.ini'
  warning: no previously-included files matching '*' found under directory '.zuul.d'
  warning: no previously-included files matching '*' found under directory '.zuul.playbooks'
  writing manifest file 'src\cryptography.egg-info\SOURCES.txt'
  running build_ext
  generating cffi module 'build\\temp.win-amd64-3.7\\Release\\_padding.c'
  creating build\temp.win-amd64-3.7
  creating build\temp.win-amd64-3.7\Release
  generating cffi module 'build\\temp.win-amd64-3.7\\Release\\_openssl.c'
  building '_openssl' extension

      =============================DEBUG ASSISTANCE=============================
      If you are seeing a compilation error please try the following steps to
      successfully install cryptography:
      1) Upgrade to the latest pip and try again. This will fix errors for most
         users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
      2) Read https://cryptography.io/en/latest/installation.html for specific
         instructions for your platform.
      3) Check our frequently asked questions for more information:
         https://cryptography.io/en/latest/faq.html
      =============================DEBUG ASSISTANCE=============================

  error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
  ----------------------------------------
  ERROR: Failed building wheel for cryptography
  Running setup.py clean for cryptography
Failed to build bcrypt cryptography
ERROR: Could not build wheels for bcrypt, cryptography which use PEP 517 and cannot be installed directly
WARNING: You are using pip version 19.3.1; however, version 21.0.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

Having the exact same issue. Anyone know how to fix this?


Workflow fixes

Change k8s Activation Custom resource

stagehistory -> stageHistory
remove unneeded errorMessage field

Change activation status to Paused if latest stage status is paused

Change redis state provider separator to "*" since ":" can be used by reference

Merged this PR as higher priority since this affects the bugbash builds.


Add sdk build to CI pipeline and publish in releases

We want to provide a SDK on regular basis, therefore add SDK build of https://github.com/jhnc-oss/meta-protos/blob/main/recipes-core/images/protos-core-image-dev.bb to CI pipeline.

The SDK has been moved to: https://github.com/jhnc-oss/meta-protos/blob/main/recipes-core/images/protos-core-sdk.bb


Hardware used, and configuration changes for less powerfull hardware

What hardware did you use?
Also, with my puny card (GTX 970) I get "ResourceExhaustedError". What would be an easy way to scale down the memory requirements of the model?

Please see #24.


[CT-1384] temp_relation is not dropped from incremental materialization

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
temp_relation is not removed in incremental model after dbt has finished OK.
below code should be added to the materialization somewhere?
{% do to_drop.append(temp_relation) %}
Expected Behavior
temp_relation should be removed if no errors occur.
Steps To Reproduce
N/A
Relevant log output
No response
Environment
- OS: Mac
- Python: 3.9.14
- dbt: 1.3.0

Which database adapter are you using with dbt?
other (mention it in "Additional Context")
Additional Context
Adapter: dbt-ibmdb2

@aurany I see you're using dbt-ibmdb2, and that you're also the maintainer! (https://github.com/aurany/dbt-ibmdb2)
Relevant spots in the adapter code:

incremental.sql#L40-43
adapters.sql#L85

On most databases, temp tables are automatically (implicitly) dropped at the end of the session/transaction. So get_create_table_as_sql(True, temp_relation, sql) →  create temp table {{ temp_relation }} as {{ sql }} → the temp relation will be dropped implicitly, and doesn't need to be dropped explicitly.
It looks like DB2 supports temporary tables (https://www.ibm.com/docs/en/db2-for-zos/12?topic=tables-creation-temporary), but not create temporary table ... as (https://www.ibm.com/docs/en/i/7.1?topic=language-creating-table-using-as). In which case, the most expedient approach is to add some drop calls within the materialization code — and I see that's exactly what you've done!
In the meantime, I think it's reasonable for the default implementation in dbt-core to presume the existence of temporary tables, which live for the duration of the materialization, and are implicitly dropped as soon as it finishes. I'm going to close this issue.


clarify cri-o support statement

update release note statement for cri-o

@mrunalp - please confirm

:+1:


thread 'main' panicked after cargo bool

After executing cargo bool I get the following error:
thread 'main' panicked at 'Either iters or workload is required.', /home/mypath/ruler/src/lib.rs:823:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I am not fluent in Rust so I do not understand the error above. What could be causing it?
Here are the steps I followed during installation:

installed libz3 (sudo apt install libz3-dev)
cargo build --release (this took a few seconds instead of a few minutes)

My os is Pop!_OS 22.04 LTS.

Hi @DanieleMarchei , you need to provide --iters <n> as an argument on the command line. Or --workload <file> where  is just a text file containing boolean expressions, say
(-> true ?a) ==> ?a
?a ==> (or ?a ?a)
(or ?a ?a) ==> ?a
?a ==> (and ?a ?a)
(and ?a ?a) ==> ?a
(~ ?a) ==> (^ true ?a)
(^ true ?a) ==> (~ ?a)
(~ ?a) ==> (-> ?a false)
(-> ?a false) ==> (~ ?a)
(xor ?a ?a) ==> 0
?a ==> (or ?a 0)
(or ?a 0) ==> ?a
?a ==> (xor ?a 0)
(xor ?a 0) ==> ?a

We definitely need to write more documentation. I hope this helps!

It's worth mentioning that if you want to run the version of Ruler described in the OOPSLA 2021 paper, you should use the oopsla21-aec branch. The tool is currently under active development.

Thank you, I managed to run the bool example. I will close the issue.
About what @amyjzhu  said, should I be using Ruler on the oopsla21-aec branch or is it ok to just work on the master branch? Also, is there an example somewhere on how to saturate conditional rewriting rules?

Thank you, I managed to run the bool example. I will close the issue.
About what @amyjzhu said, should I be using Ruler on the oopsla21-aec branch or is it ok to just work on the master branch? Also, is there an example somewhere on how to saturate conditional rewriting rules?

If you want a stable version, you should use the oopsla21-aec branch.
What do you mean by saturate conditional rewriting rules? Ruler currently does not infer that many conditional rules. It is something we are working on though and are very excited about!

What do you mean by saturate conditional rewriting rules?

I am trying to find a terminating confluent TRS for a particular monoid that has conditional axioms. Since the Knuth Bendix procedure cannot deal with conditional equations I was wondering if Ruler can work with them. From issue #3 I got the sense that it might but I don't know how.

What do you mean by saturate conditional rewriting rules?

I am trying to find a terminating confluent TRS for a particular monoid that has conditional axioms. Since the Knuth Bendix procedure cannot deal with conditional equations I was wondering if Ruler could work with them. From issue #3 I got the sense that it might but I don't know how.

So if you are interesting in applying conditional rewrites, you should look into the egg equality saturation engine which has support for conditional appliers.
Ruler at the moment infers mainly axioms over total functions with some basic support for operators like division. We are working on extending that though!
If you want to apply conditional axioms, I think egg's conditional applier is what you want.


NEM monitor: Options needed

We need options for the NEM monitor.

turn on/off baloon popups.
auto start NIS at monitor start on/off
show client version

I can add that to the config
Already configurable
Where do you want to show the client version?

I meant optiones in the context menu from the tray symbol, so people dont have to mess with the config file...

The version should go to an "About" item in the context menu of the monitor tray symbol.


xenvm: drivers: add Xen grant tables driver

This patch series adds to Zephyr another Xen feature - grant tables. This is one of the way of memory sharing (page-based) and is used for data exchange between different Xen domains (e.g. for sharing ring buffer with driver data).
Driver was taken from Unikraft repository and ported for Zephyr environment. Originally driver (in Unikraft) was based on Mini-OS implementation with some improvements. Unikraft driver was also improve and now Zephyr version supports mapping of foreign grants (both original Mini-OS and Unikraft drivers can only share own gref). Current implementation supports granting access for own grant table reference (allocated or statically defined) and for mapping/unmapping foreign gref. This functionality is widely used and needed for implementing PV backend/frontend drivers in Zephyr.
(Please note, that I'll be on vacation for a week and will not be able to review and fix comments - I will process all of them after December 16, thank you.)

@jgrall could you take another look?

Found redundant xen_remove_from_physmap definition in public/memory.h (it is not used it current PR). Removed by last force push.

If this is just one possible way out of potentially multiple ways, then should this be an optional feature ?

Grant tables - is one of the base Xen-related functionalities and I think it should not be turned off separately. All of the memory sharing methods (mapping via adding to physmap etc.) are supported by hypervisor and can be used together in different situation, but grant tables require separate driver.
All Xen-related features are already can be configured by CONFIG_BOARD_XENVM (removes drivers/xen directory) and this approach looks pretty similar to Xen part in for example Linux kernel (such base functionality is configured by single CONFIG_XEN parameter). So, in my opinion, this driver should not have separate config.

@jgrall could you take another look?

Sorry I was mostly away since Christmas and still catching up with my emails. I will try to have a look as soon as possible.

@jgrall can you please take another look?

Changes were rebased. Conflicts, which appeared after include catalog refactoring (include/ -> include/zephyr/) were fixed.

In last force-pushes semaphore limit value and commit message for docs commit were fixed. Also changes were rebased on the top of main branch.

Can someone suggest a maintainer that should be the assignee for this PR? I can't find anything in MAINTAINERS that looks appropriate from a quick look.
Whoever that ends up being may need to take this to the TSC given that it's failing the license check.

Can someone suggest a maintainer that should be the assignee for this PR? I can't find anything in MAINTAINERS that looks appropriate from a quick look.
Whoever that ends up being may need to take this to the TSC given that it's failing the license check.

Hmmm, this PR has been pending for so long. If there is no one, I may be the volunteer to maintain this area. Not sure whether there are any special requirements? And we definitely need the maintainers and also the code owner's opinion @firscity

@povergoing previously I followed Zephyr upstream guide for non-Apache code and created issues for this. As I remember, you also helped me with this. So, I will be very grateful if you help me this time too.
Also, before submitting this I want to get answer from @tejlmand about staled requested changes and final approve from @jgrall (he is Arm maintainer in Xen).

If there is no one, I may be the volunteer to maintain this area. Not sure whether there are any special requirements?

Thank you for volunteering! Please read here for the requirements and responsibilities: https://docs.zephyrproject.org/latest/project/project_roles.html
Then you can open a PR adding yourself to MAINTAINERS.yml for this area.

@povergoing previously I followed Zephyr upstream guide for non-Apache code and created issues for this. As I remember, you also helped me with this. So, I will be very grateful if you help me this time too.
Thanks:)

Hi all, I created a PR https://github.com/zephyrproject-rtos/zephyr/pull/46371 to volunteer to maintain this Xen area. Anyone would like to help with being the collaborators?

Hi @povergoing, sorry, missed it here, already replied in your PR.

If this is just one possible way out of potentially multiple ways, then should this be an optional feature ?

Grant tables - is one of the base Xen-related functionalities and I think it should not be turned off separately. All of the memory sharing methods (mapping via adding to physmap etc.) are supported by hypervisor and can be used together in different situation, but grant tables require separate driver.
All Xen-related features are already can be configured by CONFIG_BOARD_XENVM (removes drivers/xen directory) and this approach looks pretty similar to Xen part in for example Linux kernel (such base functionality is configured by single CONFIG_XEN parameter). So, in my opinion, this driver should not have separate config.

IIUC, @tejlmand's idea may be that if the xenvm could work without this grant_table, you should add a CONFIG for it? Actually, the initial goal of the xenvm is running Zephyr as the simplest domU(guest) and no dependency for any of the xen drivers right? From this view, I think tejlmand is right.
But, @firscity I think your goal is making Zephyr as dom0 and thus those 'advanced' features should be supported by Zephyr?
So, I think, if there is a way to make the whole 'dom0' (advanced) feature to be an optional choice (or it's ok if you would like to add more detailed CONFIGs for each feature like grant_table, evt channel .etc), both your requirements and @tejlmand's idea can be satisfied? Any suggestions?

@carlocaione I may ask a silly question, how can I help solve this license issue? Tagging TSC?

Uhm, not exactly sure. For sure this can be discussed during TSC. Add a TSC label and this should be picked up for discussion during the next TSC meeting.

IIUC, @tejlmand's idea may be that if the xenvm could work without this grant_table
Dear @povergoing, let me explain. Grant tables are essential base Xen functionality, previously Zephyr worked without this only because it was not implemented and it now looks incomplete. Without such basic functionality it can not be called Xen PV guest.
Usually, operating systems (Linux, Mini-OS, Unikraft etc.) initialize this when found Xen support without any options (Xenbus too). Also, this driver will be used in both domU and dom0 modes because it is used by frontend and backend PV drivers.
So I don't think that it should be turned off.

Dear @povergoing, let me explain. Grant tables are essential base Xen functionality, previously Zephyr worked without this only because it was not implemented and it now looks incomplete. Without such basic functionality it can not be called Xen PV guest.

Xen PV guest refers to OS that was modifying to run on top of Xen without HW virtualisation support. This mode doesn't exist on Arm.

Usually, operating systems (Linux, Mini-OS, Unikraft etc.) initialize this when found Xen support without any options (Xenbus too). Also, this driver will be used in both domU and dom0 modes because it is used by frontend and backend PV drivers. So I don't think that it should be turned off.

The grant-table is only necessary if you want to use Xen para-virtualized driver. There are some setup where a user may not need it if they decide to assign all the devices and/or use virtio.
If Zephyr wants to target such setup, then I think it would be good to provide an option to disable the grant-table driver. This would allow to remove any unused "drivers". The same could be said for the event channel driver and the xenbus one.

If Zephyr wants to target such setup, then I think it would be good to provide an option to disable the grant-table driver.

@jgrall, probably I have a lot of thing to learn :), thanks for clarification. Will add it soon to this PR.

The grant-table is only necessary if you want to use Xen para-virtualized driver. There are some setup where a user may not need it if they decide to assign all the devices and/or use virtio.
If Zephyr wants to target such setup, then I think it would be good to provide an option to disable the grant-table driver. This would allow to remove any unused "drivers". The same could be said for the event channel driver and the xenbus one.

@jgrall Thanks for your clarification.

Will add it soon to this PR.
@firscity Wish it will be very simple to add. Actually, my first thought is at least Zephyr could be run as an FV guest (plus some passthrough devices?), in this case, Zephyr sounds should not be aware of the existence of Xen. And indeed I know someone really has this kind of requirement, especially Zephyr is a RTOS with a lot of customized things, and moreover, v8R64 with MPU platform will also support Xen and thus have more special customized features~. Anyway, not a big deal, it's totally acceptable for me to use a "change it only if necessary" strategy :)

Last force push adds possibility to disable this driver via CONFIG_XEN_GRANT_TABLE=n.
Some functional changes to previous version were made - initcall for gnttab driver will be called on POST_KERNEL stage. It is needed after introducing gnttab_get_page/gnttab_put_page interface. It uses only dynamic memory allocation (no static defined pages), that becomes available on POST_KERNEL stage.
Also, these patches were rebased at the top of main branch and files copyrighting were updated with "2022".

Last force push adds possibility to disable this driver via CONFIG_XEN_GRANT_TABLE=n. Some functional changes to previous version were made - initcall for gnttab driver will be called on POST_KERNEL stage. It is needed after introducing gnttab_get_page/gnttab_put_page interface. It uses only dynamic memory allocation (no static defined pages), that becomes available on POST_KERNEL stage.
Also, these patches were rebased at the top of main branch and files copyrighting were updated with "2022".

Cool, I think we could wait for @tejlmand for a couple of days, if he doesn't come up, we may kindly dismiss his requested changes.
Also, thanks to @luca-fancellu tagging TSC(I forgot), we need to solve the Licenses issues.

Dear @povergoing, almost a week has passed since adding of requested changes by @tejlmand, so think we can dismiss this and move to TSC approval. Also it will be good to mention about #44969 on TSC meeting, it has approval but stills waiting for merge.

I think we should be able to merge this if we get enough approvals.

Hi @carlescufi, we have already gotten enough approvals, would you like to take a look at this one again :)?

The following compliance error looks real:
Missing newline at end of 'drivers/xen/Kconfig'. Check your text editor settings.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.

The rest of them look like they can be ignored.
The following scancode error looks real as well:
Error: * scan/drivers/xen/gnttab.c has invalid license: mit
* scan/include/zephyr/xen/public/grant_table.h has invalid license: mit

Error: * scan/drivers/xen/gnttab.c has invalid license: mit
* scan/include/zephyr/xen/public/grant_table.h has invalid license: mit

I checked include/zephyr/xen/public/grant_table.h has no license identifier, not sure if this is the real problem.
but for drivers/xen/gnttab.c, it has an SPDX-License-Identifier: MIT I have no idea how to fix it.  Do you have any suggestions? @mbolivar-nordic

Last force push contains following changes:

rebase on top of the main branch;
adding newline at the end of the driver/xen/Kconfig;
adding /* SPDX-License-Identifier: MIT */ on top of grant_table.h public header to keep it same with other Xen headers;

As I know, CI marks all non-Apache files with invalid license, so there no surprise for new MIT files. According to Zephyr submit guide, TSC should approve such non-Apache files every time.

As I know, CI marks all non-Apache files with invalid license, so there no surprise for new MIT files. According to Zephyr submit guide, TSC should approve such non-Apache files every time.

Yes indeed, and TSC approved it already, so I guess we should not worry about this error

@carlescufi @mbolivar-nordic Gentle ping for this, I think it is ready to go :)


Bump golang version to 1.9.2

I have a nascent FreeBSD port in the works. Is there something specific that agent requires from 1.9.2
or can I continue to build against 1.9.0?

Just updated the description, this was motivated by https://github.com/buildkite/agent/issues/291.

Should be fine to keep building against 1.9.0 for BSD @dch!


support pushing attestations to multiple destinations

Currently witness can only push attestations to one destination besides writing it to disk, which is Archivista.
It would be useful to expand this to be able to push the location to wherever the user decided it to be most worthwhile (e.g., OCI Registry). On top of this, it would be useful for the user to be able to specify multiple destinations for a witness run command to push the attestation collections that it generates to.

We have discussed the ability for multiple backends, i.e. Rekor entry, S3, OCI, etc.

One comment on Rekor. As far as I remember there is a size limit on Rekor which makes it less feasible for witness sizeble attestations. 😅


[MM-22806] Make search hints interactive

Summary
Improving the UI of our search bar and making the search hint interactive. Used the design specs from figma, but since there wasn't a sidebar right design I improvised. UX and PM can advise on behaviour and styles. Also fix version is not specified, is this for v.5.23.0?
Ticket Link
https://mattermost.atlassian.net/browse/MM-22806
Screenshots

Creating a new SpinWick test server using Mattermost Cloud.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server creation failed. See the logs for more information.

Adding @matthewbirtch for UX review since it's his design

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit aa940b964a50081e02330c8d2d5e98beb943127b.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

Though I just noticed its failing i18n-check

/update-branch

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit bab8859d90f08bd006648483a0fc246ed654114d.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 563a3fc892de90f21c9e0d67878881f34555390e.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

/update-branch

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 4a271facda25c345ef4846d27a175fb8b6e5b1e7.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

Thank you @nevyangelova
Adding few observations for UX input:

Exclude search term option posts as "dash space" -  if user doesn't backspace to clear the space and enters the term, text is not excluded.
Is it possible to place the blinking cursor right after dash automatically?
Similarly for "",  blinking cursor is placed after the double quotes, so to include the search term user has to manually move it inside the quotes
Can we place the blinking cursor inside the double quotes automatically when selecting this option from the dropdown?
Clearing the text box using x leaves the search box with cursor, but otherwise looking unfocused with missing box border highlight and no visible hint menu

@matthewbirtch thanks for the suggestions. I only have a question regarding the space between tag and text. The spacing is 16px at a 2560 x 1600 resolution like it is in the figma design. Unfortunately the figma file didn't show the popover for larger resolutions like the one you are showing in the screenshot. The popover expands with the viewport and its based on the search bar width, however if we keep the space 16px I think it looks weird as the side padding becomes too large and all the text is crammed in the middle. My suggestion is to keep the spaces expanding with the popover width. Also based on the position of the tags, baseline left, the space on each row will be different than 16px since the tags have different length. If they are all spaces between 16 px they wouldn't be aligned left, so which tag do we take as a target?

Thanks for the response @nevyangelova. Here are my thoughts:

I think it's more important that the descriptive text feels connected to the tag it relates to. We would just use the longest tag as the reference point for the 16px distance I mentioned (which would be the BEFORE: tag). So it would look like this...

This extra space was intentionally added in the design because the first and last list items need extra room from the edges. I'm totally fine with it looking this way on the hover state - it's more important that it looks right in the default state. This is how the autocomplete are designed as well so we need to be consistent with those (see screenshot below)

Not sure what I was seeing before....it seems to be fine now.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit ff05d4c4de149e02cf9d00bf34b5df7797755012.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Mattermost test server updated with git commit e074aca585631d69793e108083c8809b378f0ddd.
Access here: https://mattermost-webapp-pr-5341.test.mattermost.cloud

PR Updated and ready for second review @matthewbirtch @bradjcoughlin @hmhealey @esethna @jgilliam17

Thanks @nevyangelova
Few more issues

Unable to keep focus on Search field, it dismisses if you click on Members first followed by click on Search
I've experienced No hint popover when clicking on Pinned or Flagged icon first with RHS open, but can't reproduce reliably
Unable to dismiss hint popover, Search box styled as focused, but missing the cursor.
Steps:

Click on Mentions @
Clear mention text by clicking on the x in Search field
Click outside of the hint popover, you can even place the focus in main channel text box at his point and post text -> hint popover remains visible, Search box styled as focused, missing cursor

Mobile view - hint list that opens does not follow the same behavior. This may be related/mentioned in the previous comment (point 7). Also, popover appeared once or twice layered over the existing hint list, but this I am not able to repro consistently

PR updated. There might still be some issues with focusing/refocusing as the code for that is a bit all over the place and there might be uncaught cases. Help with testing is much appreciated 🙏

FYI in order to not conflict with the mention search since they use the same input and focus functions, the only way I can avoid that is by not showing the popover at all when mention search is present in the search bar or RHS. In order to see it again you need to navigate away from mentions. Maybe devs can advice.

Do you mean that when the from: autocomplete is visible, the search hint is disabled? That's what I'd expect, since I think only having 1 popover visible at once is ideal.

A few things I noticed: @nevyangelova @matthewbirtch

After using two search modifiers the pop-over no longer appears after hitting space. Example:

Can we lower case the modifiers in the search box? ie "Before" > "before", "In" > "in"

If you you play with it for a bit I can sometimes get it into a state where the pop-over doesn't appear anymore, even if I fully clear the search input box. See image, I don't have clear repro steps though

Can we have the pop-over disappear immediately when the user clicks outside of it? Compared to @-autocomplete in the post text box, this pop-over takes a lot longer to close after clicking out of it. If we have a transition on it I'd propose we cut it, it's making the app feel laggy.

https://i.gyazo.com/23599e67660b4ea665f1d2a7e188edba.gif

Thank you all for the great feedback! I have taken into account and implemented all steps, apart from the point regarding showing the popup 4 times. In my search experience as a user, seems like twice is optimal, if I get the popup displayed more than that it seems annoying because most of the time I wouldn't need all the search criteria for every single search. My suggestion is that we keep it at two (or max 3) times per search. I am curious about your reasoning however and will implement as many as needed. So far while testing I didn't get any issues with focusing, let me know if there is anything else I can do! @matthewbirtch @esethna @jgilliam17 @hmhealey

+1 so awesome! Adding PM approval, @matthewbirtch please help rereview and approve if you're happy with it. We can probably start getting some dev review eyes on it.

@bradjcoughlin probably worth doing a re-review given the changes since you last reviewed. @devinbinnie feel free to review now

@nevyangelova I can take a look at the i18n issue tomorrow.

Looks great @nevyangelova
few issues

When "" is used as a second hint, cursor is outside the quotes

Mobile web view search only allows one hint to be used at a time e.g. search for from: sysadmin when adding second hint it replaces first

Mobile web view search is stuck on loading, without the hint list (same when selecting recent mentions and flagged posts) I am able to add search terms, prompt calendar modal to show up and from: user list etc. but not able to get out of Searching spinner

@hmhealey should we unassigned you from this PR a reassign to another dev?

@jgilliam17 fixed the cursor issue. For the mobile view we decided to keep the functionality to only work on one click (as observed) for now.

/update-branch

Thank you @nevyangelova
Looks great! 1 issue (+ one for later investigation)

When the hints are part of the RHS it doesn't follow the same behavior as the popover, hints are capitalized and focus is missing in the text box when you select any hint.

Popover is missing all together in some instances. Per discussion with Eric, I am going to create a follow up ticket for this. I've seen that a few times, but have not been able to narrow down the steps to repro. For now refresh gets me out of that weird state when it happens, and it is occurring rarely so that's good.

Thanks @jgilliam17 yeah exactly that weird issue you are seeing is related to the regression that happened on master with the search in RHS. Alejandro is working on a fix so I think we can merge this and the fix will be applied in his PR. I will keep a close track of this to make sure its working flawlessly. FYI @esethna


Add visionOS platform support for NSUbiquitousKeyValueStore

Simply added os(visionOS) for NSUbiquitousKeyValueStore implementation, as it is available on visionOS.
I can confirm that it is working in the simulator and syncs the data between devices.

Thanks, and sorry for the delay!


docs(zh-cn): Reviewed 61_data-processing-for-summarization.srt

docs(zh-cn): Reviewed 61_data-processing-for-summarization.srt #390

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Make Thump a chat multiplexer

Ideas:

IRC becomes a module
ForgeCraft also uses Discord and @Pahimar is interested in a Curse Voice bridge

Ties in to module API - interfaces to and from modules need defining first
Thump itself fires events on modules via interface and gets fed events from modules

Done in 4.0 with service plugins.


Collection spacer with component

Summary
Sample implementation looking for very rough 👍 or 👎 on direction before I start polishing.
Syntax for usage is the collection_spacer on with_collection:
    render_inline(ProductComponent.with_collection(products, notice: "On sale", collection_spacer: CollectionSpacerComponent))

@BlakeWilliams  -- I'm a little confused about the failing checks. Is it a specific code coverage number not being met?

@BlakeWilliams -- I'm a little confused about the failing checks. Is it a specific code coverage number not being met?

I think the output is misleading, it looks like if there's a failure code coverage is still being run, and checked. We should probably fix that. :)
The actual error looks like: File does not exist: pry

Closing this out, it's age old and I haven't touched dotcom UI in months and months D:

@boardfish would you be interested in picking this one up? I feel like @brphelps got it pretty close.

Sure thing. I don't know how much time I'll have to start on it before the end of the year, but I'll try and get to grips with the wider context.
I'll open a fresh PR based off the existing work so as not to ping @brphelps too regularly @brphelps, if this feature is something you'd potentially still make use of in working with ViewComponent, I'd appreciate it if you could drop a little more context about how you'd like it to work so I can do it full justice.


Remove default animations for custom animations

Hello I was wondering if there's a way to properly disable the default animations. I've been using this component as a base for our Drawer component and I absolutely love it since it fits most our needs. I've added the ability to position the components on different parts of the screen "top" | "right" | "bottom" | "left" and have added the styles for it, however i would like to also add the corresponding sliding animations. (when positioned at top, it should slide in from the top etc...)
The problem is that the [vaul-drawer] and [vaul-drawer][data-state="closed"] css classes are taking priority over my own styles, and if i try to set "animation: none" on the component, that rule is always taking priority and no new animations are being applied. However, if I try to add my own animations without removing the default vaul animations using "animation: none", some of the vaul-animation settings like duration or transform, which my animation styles may not override are still being applied.
I know in the future you might add the positioning as a feature yourself but is there a way to remove the default animations instead of manually overriding all the css properties set by [vaul-drawer] and [vaul-drawer][data-state="open"] classes? any advice is appreciated.

This was my solution. I added a class to increase the css specificity of my animations and reset and not it works. Please let me know if you have cleaner approach, otherwise feel free to close this issue 👍
cn(
    `
    !duration-200
	// add custom class to increase specificity
	remove-vaul-animation
	// appen custom classe to desired animations
    [&.remove-vaul-animation[data-state="closed"]]:animate-out
    [&.remove-vaul-animation[data-state="closed"]]:fade-out-0
    [&.remove-vaul-animation[data-state="open"]]:animate-in
    [&.remove-vaul-animation[data-state="open"]]:fade-in-0
	// remove vaul animation
    [&.remove-vaul-animation]:animate-none
    [&.remove-vaul-animation[data-state="closed"]]:animate-none
`);

I haven't thought about this, but this seems like a nice solution!

Hi @JeffreyJoumjian I'd like to implement this, but I'm not familiar with this cn syntax in your reply - is there a pure CSS equivalent you could share of what's being achieved here?

@Southclaws cn joins your classnames, see this https://www.npmjs.com/package/classnames

@Southclaws I did try doing it with css at one point. Basically I had one class that I applied and added the styles i wanted there so:
.drawer {
	all: unset;
	/* if you're using tailwind, you can still use the @apply directive to apply tailwind classess */
	/* it also supports breakpoints but creates lots of weird styles and classes so i would avoid it */
	@apply data-[state=open]:animate-in data-[state=closed]:animate-out

	/* or write simple plain css, i don't know if you can refer to animate classes in there however */
	animation-duration: 200ms
}

Although I didn't this issue as it was already closed, when i packed the drawer with these styles into an npm package and used it in another repo, the compiled styles were different and some vaul default styles were being applied. I was short on time so I ultimately decided to use shadcn's Sheet component as it was just a lot simpler and already supports our needs, although not as smooth or mobile first as Emil's which is why I was drawn to it at first... Also I didn't know shadcn had a drawer because it was weird to name it Sheet 😭

I wouldn't recommend using this component for anything else than bottom to top animation considering dragging works on y-axis only, so I don't think it'd be useful to allow people to adjust the animation, not for now at least. Thank you for posting this tho!

Awesome thanks! I wasn't sure about the [&. parts either and wondered if it was part of some other CSS processor. Been out of plain CSS for a while but using it more now!
My use-case for removing animations was essentially to use Vaul's container as a modal for desktop too - that way if a user resizes their viewport while filling in a form, it won't need to re-render and can just use pure CSS media queries - thus using the same element with my content. On larger devices where my drawer becomes a modal, I wanted to prevent the downward movement animation entirely.


API server SLO recording rules produce too many metrics

What happened?
When applying status_class:apiserver_request_total:rate3d rule, I'm getting the following error from Prometheus:
query processing would load too many samples into memory in query execution

Did you expect to see some different?
Yes, didn't expect an error
How to reproduce it (as minimally and precisely as possible):
Run kube-prometheus and try to apply the default rules.
As a work-around, I removed the rule:
$_config+: {
      prometheus+:: {
        rules+: {
          groups:
            std.map(
              function(group)
                if group.name == 'kube-apiserver-error' then
                  group {
                    rules: std.filter(function(rule)
                        std.objectHas(rule, 'record') && (rule.record != "status_class:apiserver_request_total:rate3d" || rule.record != "status_class_5xx:apiserver_request_total:ratio_rate3d"),
                        group.rules
                      )
                  }
                else
                  group,
              super.groups
            ),
        },
      },
    },
}

But I think it will be better to set the requested range on the SLO lib which generate this rule.

@metalmatze maybe we can have some intermediate aggregation so these errors don’t happen?

The underlying query is:
sum by(status_class) (label_replace(rate(apiserver_request_total{job="apiserver"}[3d]), "status_class", "${1}xx", "code", "([0-9]).."))
Not really sure how we can improve that. We could first get the rate then label_replace?

We could do one query per status class as opposed to doing all of them at once, just to make the query load a bit less heavy on each of them. That should be a breeze with jsonnet :wink: .

Have same issue. Any workarounds?

I'm working on replacing the current SLO implementation entirely with a more custom and better suited one for the apiserver.
See #382

Applied helm chart 8.13.8 but the issue still persist.

This issue actually has become obsolete, because the underlying recording rules changed.
A similar problem still exists though it's with slightly different recording rules.
As this problem was never about the Prometheus Operator itself, I'm going to close this here. Please check in the future: https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/411


sphinx-jinja: 0.2.1 -> 1.1.0, Python 3 support

Motivation for this change
Updates sphinx-jinja to the latest version, and enables Python 3 support.
Things done
The main issues with Python 3 support were that the tests were run with pytest when they were designed to be run with nose (pytest tried to inject fixtures into function arguments). Also there is an issue where a UTF-8 file is read in the tests without specifying a codec, which requires the locale to be set to UTF-8.
I also removed the blockdiag dependency, because I could not see how it was required. @nand0p why was blockdiag necessary?

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Also there is an issue where a UTF-8 file is read in the tests without specifying a codec, which requires the locale to be set to UTF-8.

That's described in the Nixpkgs manual.

@GrahamcOfBorg build sphinx-jinja

Superseded by #45890


Cannot connect AzureDataStudio from macOS 10.14.1 with SQLServer 2017 Windows 10

Azure Data Studio Version: Version 1.2.4 (1.2.4)

Steps to Reproduce:

Use Windows 10 Pro x64, IP <IP_ADDRESS> (via wifi)

Install Microsoft SQL Server 2017 (RTM) - 14.0.1000.169 (X64)   Aug 22 2017 17:04:49   Copyright (C) 2017 Microsoft Corporation  Enterprise Evaluation Edition (64-bit) on Windows 10 Pro 10.0  (Build 16299: )

From macOS 10.14.1 Mojave, connect to instance via WIFI.

Error
A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 40 - Could not open a connection to SQL Server)

@donhuvy the error message typically indicates that there is a network connectivity issue between the client and server machines (the error comes from the SQL Client driver component in .Net Core framework).
Have you verified that the server is accessible from other tools running on the macOS client (such as sqlcmd, etc.)?  You may verify that the server's firewall rules are configured to allow 1443 incoming requests and that the TCP endpoint is enabled, for example.

I use two computers. 1 computer (slow, old computer run Windows 10 pro) and 1 computer (macOS 10.14).
Because the old computer is quite slow, I cannot program on it, I must program on macOS computer. I try to connect from macOS to Windows PC.
I think it is not a bug, I am confusing, because I don't allow remote connection to SQL Server on Windows PC.


Creating shortcuts to open workspaces

When working on multiple projects, people tend to have multiple workspaces. Opening VSCode opens the last opened workspace. Would it be possible to make a shortcut desktop icon for desired workspaces so that we can open a workspace without having to shift from the previously opened workspace?

@infixint943 have you tried File>Open Recent for switching between workspaces? Notice pressing CTRL will open the workspace in another window.
On windows you can create an alias yourself for a particular workspace use the code workspacepath as the alias command.


Rasterdraw

Added the rasterDraw() and a recording for the flowDraw() in order to compare  the error signal from the eye encoders with the mean optical flow
The changes in the decodeEvents and vTrack.h are not mine

Yeah, I can take care of it with the help of @DennisZemela for the rasterDrawer. I will have a better look at the code asap.

there is a fair amount of changes to be made in both the Pull Request and the Rasterdrawer itself. If you want I can find time to have a look at how it could be done with you @marco-monforte - if you are still working on the VOR project, otherwise we can do it with whoever is next working on VOR.

Well, yes, it would be much better. I'm still on the project and probably Ander is going to help me with it. We could plan some time in the next week to work on this the three of us.


Auto import does not import Disposable or Emitter from VS Code's codebase

Related to https://github.com/microsoft/vscode/issues/116375
This issue has been around for years, I think I've mentioned it in DMs but not sure if there's an issue. Regardless, here's a detailed description of it. I'm assuming this is an upstream issue but please keep this issue open to track as it's a papercut.
This does impact my productivity; instead of auto import just working like it's supposed to, I instead have to:

Import one of the other symbols
Scroll to the top of the file
Find the import
Change the import
Go back
Change the symbol I entered in step 1

AsyncEmitter and EmitterOptions shows up:
https://github.com/microsoft/vscode/blob/85de2f21c63608e8bbc5c2347fe927b00c8300bf/src/vs/base/common/event.ts#L1184
https://github.com/microsoft/vscode/blob/85de2f21c63608e8bbc5c2347fe927b00c8300bf/src/vs/base/common/event.ts#L695
But not Emitter:
https://github.com/microsoft/vscode/blob/85de2f21c63608e8bbc5c2347fe927b00c8300bf/src/vs/base/common/event.ts#L897

DisposableStore and DisposableMap shows up:
https://github.com/microsoft/vscode/blob/85de2f21c63608e8bbc5c2347fe927b00c8300bf/src/vs/base/common/lifecycle.ts#L210
https://github.com/microsoft/vscode/blob/85de2f21c63608e8bbc5c2347fe927b00c8300bf/src/vs/base/common/lifecycle.ts#L503
But not Disposable:

@andrewbranch Any ideas why Event would be found from a bunch of files in our codebase but not the main definition we typically want: vs/base/common/event

I see EventBufferer gets picked up from there so the file is known but something must be filtering out Event

It’s because the Event declared at vs/base/common/event.ts is re-exported via vs/workbench/workbench.web.main.ts. Completions only shows you a single location for each exported symbol, and the most-reexported one is assumed to be the “most public.” This is designed to avoid duplicates from cascading barrel files. Suppose Dropdown is subsequently re-exported by the following files:

/foo/shared/components/dropdown/Dropdown.ts
/foo/shared/components/dropdown/index.ts
/foo/shared/components/index.ts
/foo/shared/index.ts
/foo/index.ts

We only show a completion for the last one because it had the longest chain. Note that at this point in the filtering, we don’t know what the module specifier is going to be yet, but this often (but not always) results in us picking a file that will generate a shorter module specifier than the others.
This heuristic is becoming increasingly suspect. Many users are beginning to realize that barrel files are terrible for tree-shaking their apps and will try to go out of their way to avoid importing from one in their dependencies, but TS always prioritizes it. But it doesn’t seem like there’s a universally better heursitic for choosing a location, and the alternative is exploding the size of the completions list with lots of duplicates. Including all symbol export locations or switching to another heuristic that operates on the final module specifier (as opposed to the file name or position in the re-export chain) would increase the number of items we have to generate a module specifier for, which is a relatively expensive operation within completions.

@andrewbranch any recommendation for how we can solve this on our end? I don't think we ever want to import these functions from workbench.web.main.ts while working in the core repo as that's just the public API for embedders like vscode.dev.

@Tyriar I had thought this setting would do the trick? But maybe it broke?
"typescript.preferences.autoImportFileExcludePatterns": [
    "xterm",
    "xterm-headless",
    "node-pty",
    "vscode-notebook-renderer",
    "src/vs/workbench/workbench.web.main.ts",
    "src/vs/workbench/api/common/extHostTypes.ts"
]

@bpasero I don't see that in our settings.json, is that the problem?

@mjbvz for me this setting never fixed Event. I think it only helped for Disposable. Here is a recording of what I see:

The issue for Event seems to be that the name duplicates the DOM Event, so no import is suggested, not even when I add generics.

@mjbvz still not working for me after pulling the settings change and restarting ts server

@Tyriar It's working for me:

Are you on windows? Wonder if there's something happening with \ paths

That's it! Could we make that setting work regardless of separator since we don't have https://github.com/microsoft/vscode/issues/5595 yet?

@mjbvz yes I'm on Windows. I thought I saw it working just now after changing the separator but it's broken again. Using this doesn't seem to work 😕
		"src/vs/workbench/workbench.web.main.ts",
		"src/vs/workbench/api/common/extHostTypes.ts",
		"src\\vs\\workbench\\workbench.web.main.ts",
		"src\\vs\\workbench\\api\\common\\extHostTypes.ts"

The slashes should be normalized by TS, but maybe there’s something else Windows-specific going on 🤔

The Windows problem should be related to the drive letter. The src/vs/workbench/workbench.web.main.ts pattern is normalized to /**/src/vs/workbench/workbench.web.main.ts in the client, and the regex pattern for that is /^((\/.+?)?\/src\/vs\/workbench\/workbench\.web\.main\.ts)($|\/)/i which doesn't match the drive letter in the start c:/path/to/vscode/src/vs/workbench/workbench.web.main.ts.
#56415 also uses Windows, so it should be related.

Just came back from a break and noticed this was fixed, thanks so much!


chore(main): release 0.3.0

:robot: I have created a release beep boop
0.3.0 (2023-01-31)
Features

home: NavigationBar instead of SalomonBottomBar (5559503)
log (51db36f)
logging system (fcf5a3c)
mine: SettingsView (19f1263)
model test (fa8dc7c)
use material 3 UI design (5ac628f)

Bug Fixes

deps: update dependency com.android.tools.build:gradle to v7.4.0 (f65a9cc)

Miscellaneous Chores

add debug assets (e4e6508)
add model as asset (fc4d37a)
add model as submodule (0980ecf)
update android gitignore (58d38c4)
update submodule (98e6a6b)
update submodule (7642272)
update submodule (a0daaf7)

Code Refactoring

analytics: rename analysis to analytics (c29cc4e)
home: inline pages (7c3fc33)
implement forward (f1118ba)
load model (a7e299b)

Styles

{super.key} (167d84b)

Build System

build cpp for android (ed1f0e1)
disable sanitizer (8bbf5fd)
fix linker error (80cf641)
flutter pub add ffi (5f51a5e)
flutter pub add go_router (4ae2ca2)
flutter pub add logger logger_flutter_plus (fc69e95)
flutter pub add path (cd0a08a)
flutter pub add path_provider (a6c295a)
flutter pub add settings_ui (7249517)
flutter pub remove logger (7722084)
flutter pub remove salomon_bottom_bar (4c472e0)
flutter pub upgrade (5cf4050)
hpp to cpp (1916e7b)
no Werror (01b7d9e)
set(CMAKE_CXX_STANDARD 20) (1480961)
upgrade flutter (92585dd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/ecg_monitor/releases/tag/v0.3.0 :sunflower:


[YUNIKORN-468]: Node resource updates should trigger cleanup

@wilfred-s WIP patch with lot of "todo" comments to confirm the overall idea/direction. Can you please take a quick look?

I think we need to first sort out how and what we are going to do here.
Lets start the discussion on the jira so we can figure out:

what we want the behaviour to be
how does this relate to occupied resources of the node (non yunikorn scheduled ones)
what we want to make configurable
how that interacts with apps and queues and the rest of preemption

At the moment this is not a high priority as K8s can not change a node's size as far as I know (i.e. nodes are not fixed in mem etc after creation). Before we thus dive in lets figure out what we want/need.

Closing as abandoned.


Proper integrade swagger-ui

fix the swagger-ui integration at /swagger just not has styles for now

done


Live

Docs Build status updates of commit 5a10340:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/develop-your-app/AppInstaller.md
:white_check_mark:Succeeded

windows-iotcore/windows-iot.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Horizontal navigation pattern

Implement the horizontal navigation pattern as specified in patternfly.org:
http://www.patternfly.org/pattern-library/navigation/horizontal-navigation/

Closing due to inactivity.


class="js-tablist__link" may cause bloating

Hello again Nicolas,
This is not an issue per se, but here's something for you to think about. This is more from an HTML and CSS standpoints rather than JS.
Having all
s have the class class="js-tablist__link" may bloat the HTML unnecessarily. I also say this because seems that having the class in the
s is required, which I think having a class in them should be optional.
This:

A

B

C

D

…

Can be turned into this:

A

B

C

D

…

And if we need to target the
s or links, we do:
.js-tablist > li { … }
.js-tablist > li > a { … }

Just a thought, I do not know what the JS implications of this would be :)

Hello again,
Yes, or we could generate classes on the fly, also a possibility (which would avoid me redevelopping everything).
I keep the idea, and I will ask other users what they think of your idea.
Thanks a lot,
Nicolas

No problem, glad to help.


Is it possible to start the service without displaying a notification?

@gabriel1lima, sadly it is not possible to start the service without having the notification on Android. Taken from the Android Developer Docs:

A foreground service is a service that the user is actively aware of and isn't a candidate for the system to kill when low on memory. A foreground service must provide a notification for the status bar, which is placed under the Ongoing heading. This means that the notification cannot be dismissed unless the service is either stopped or removed from the foreground.

The service is not auto start after reboot

The service is not auto start after reboot

Did you figure out how to do it?


Additions to Tree view API

#50662 : Add onDidChangeSelection event
#48198 : Add visible property and listener
#49311 : Add focus property to reveal API
#39601 : Add doubleClickCommand property to TreeItem

@jrieken Updated the PR with requested changes and removed double click command


Made Style Changes to the SignUp Form

Signed-off-by: Yash Kamboj<EMAIL_ADDRESS>Description
Made Style Changes to the SignUp Form with @Abhijay007
This PR fixes #
Notes for Reviewers
https://user-images.githubusercontent.com/75125203/164746297-46863998-9c1e-4f9b-bc8c-422c65c9e284.mp4
Signed commits

[ ] Yes, I signed my commits.

@Abhijay007 Review??

@Abhijay007 Done!!

@leecalcote Review??

@Nikhil-Ladha Made the changes, just the box shadow in the meshery-login image isn't applied with css, it is inside the image 😅

@Nikhil-Ladha couldn't find the solution for it do you have any suggestions??

@Nikhil-Ladha couldn't find the solution for it ,do you have any suggestions??

Try using the Select component of formik. That should do the trick


request: Dark Mode

A dark mode would be greatly appreciated as its much easier on the eyes.

Just the editor or the whole Hue? In case it's just the editor, there's a hidden setting you can change from the browser console:
$.totalStorage("hue.ace.theme", ThemeName)
where ThemeName is any valid Ace editor theme names (ie: "ace/theme/tomorrow_night"). Refresh the browser and voila, you have a dark theme!

Thanks for the tip that definitely helps!
However, I still feel like the rest of the interface would be nice to have dark as well. (especially as the white box around the dark theme is quite loud)

for reference github: through stylish

Unfortunately we cannot fit this in the roadmap, but feel free to create a stylish theme for it, it shouldn't be that complicated imho!

只是编辑还是整个色相？如果只是编辑器，可以在浏览器控制台中更改一个隐藏设置：
$ .totalStorage（“ hue.ace.theme”，ThemeName）
，其中ThemeName是任何有效的Ace编辑器主题名称（即：“ ace / theme /明天晚上”）。刷新浏览器，瞧，您的主题很暗！

$.totalStorage("hue.ace.theme", "ace/theme/tomorrow_night")

Refresh the browser  no effect

How about the bottom section of http://gethue.com/additional-sql-improvements-in-hue-4-3/? (only for editor indeed so far)


Review: Go To Data Page Bar graph

Overview
Please work on reviewing the Go To Saving Pages.
Review Branch
Files to review

DatapageBargraph.jsx

Checklists
(Please edit the following list if necessary to indicate the actual checklists to be used.)

Architecture
Design
JS
Meteor
React
Testing

Due date
Please work on this before class on Tuesday.
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

Design-04: Eliminate large comment blocks.
Is it possible to condense the comments from line 33 to 35
Design-03: Eliminate dead code.
On the top can you remove the import CalculateCO2 since it is not being used?

Design-05: Ensure comments are appropriate.
Line 9 uses /** but should consider using /*
ESLINT-01: No errors, avoid warnings.
Line 6 is it possible to not use disable eslint comment?

-Design-05: Ensure comments are appropriate. <- Eliminate the "how comments"
Lines 24-26 is too detailed. Unnecessary to explain the how.
-Other than that, I didn't find anything wrong with the jsx file.

Design-04: Line 24 - Line 26, Can we shorten the comment and make it more concise.
ESLINT-01: Line 6 - Maybe find a way to remove the eslint disable.
Lines 27:30, 56:36, 77:27, change from double quotes to single quotes.
Minor changes that the user might pick up:
Line 15:47 - Cummulative -> Cumulative,
Line 82:102 - todays -> today's.
Not too much wrong with this file.

JS-08: Use JSDoc comments appropriately.

remove the comment on line 7 or edit it to make it appropriate for the file
Arch-03: Are new directories consistent with existing directories?
Fix the file name to be more descriptive of what kind of info/data the directory holds
Design-05: Ensure comments are appropriate.
-After these problems have been addressed please remove these comments

Design-04: The comments lines 22-25 should be reduced
Design-01: Code repeats for all bar graphs

Design-04: Eliminate large comment blocks.
Shorten the comment section from lines 22-25
Design-05: Ensure comments are appropriate.
Line 7 should use /* instead of /**
Other comments:
Check for spelling, like in line 13 "Cummulative" should be "Cumulative"
Use consistent capitalization in lines 21, 29, 33

Design-04: Eliminate Large Comment blocks
Short the amount of comments in lines 22-25
Design-05: Ensure comments are appropriate.
Use /** instead of /* on line 7
Arch-01: Obey file name conventions:
Name of the file should be in camelcase (i.e. dataPageBarGraph.jsx instead of DatapageBargraph.jsx)
Not a whole lot of things wrong with this file. There are some minor typos, but they don't impede on the design reviews