Update calendar_languages.md

Deleted Starting in :  in Property Value section.

@Karl-Bridge-Microsoft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks for pointing this out, @iPhilip! Turns out that it's a problem in quite a few other topics. I'm investigating the need for a qualification like this any more and what that would be. Many topics will need to have some formatting updates vs just deleting the string.
Once I've got that private PR merged, I'll come back to this pr and update.

Thank you, @Karl-Bridge-Microsoft. I figured that deleting the string wasn't the final solution. Thank you for looking into it.

Hi @iPhilip, I've updated approx 27 topics with similar issues across the globalization reference. Hopefully i caught them all.


Add API to use FileSystem to get local file stream in node env

Let's up the priority on this one since it's on the critical path for users that will use tfjs-data in node.


Deprecation and merging into concurrent-ruby

When this gem was moved under the ruby-concurrency organization the plan was to merge it into concurrent-ruby and eventually deprecate this gem. We've begun this discussion in the concurrent-ruby repo here.

This gem has now been merged into concurrent-ruby and will go live with the 1.0.0.pre1 release. We will deprecate this gem once concurrent-ruby 1.0.0 has been released.

concurrent-ruby 1.0 was released in November of 2015 and is now a dependency of Rails 5. Since Rails 4 uses thread_safe we're going to continue supporting this gem for a while. We'll formally deprecate it in the future once Rails 5 becomes the norm.


fs: preadv failing on armv7

This is a strange issue. When running on the Node.js armv7 build bots, the preadv tests are failing. In fact preadv returns EINVAL even though the arguments are correct. I was adding some debug statements to the uv__preadv_or_pwritev() method when suddenly with this specific modifications it started working. At the moment I cannot add more info as I cannot run strace nor a debugger in that specific environment
diff --git a/deps/uv/src/unix/fs.c b/deps/uv/src/unix/fs.c
index 4a4e2e3ad85..2fa80733293 100644
--- a/deps/uv/src/unix/fs.c
+++ b/deps/uv/src/unix/fs.c
@@ -477,13 +477,17 @@ static ssize_t uv__preadv_or_pwritev(int fd,
     p = dlsym(RTLD_DEFAULT, is_pread ? "preadv" : "pwritev");
     dlerror();  /* Clear errors. */
 #endif  /* RTLD_DEFAULT */
+    fprintf(stderr, "p: %p\n", p);
     if (p == NULL)
       p = is_pread ? uv__preadv_emul : uv__pwritev_emul;
     atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
   }

   f = p;
-  return f(fd, bufs, nbufs, off);
+  ssize_t r = f(fd, bufs, nbufs, off);
+  fprintf(stderr, "fd: %d. r: %d\n", fd, r);
+  return r;
+  //return f(fd, bufs, nbufs, off);
 }

It looks like a compiler optimization going wrong but I don't know what to look at next. Any ideas? /cc @bnoordhuis

Perhaps one thing to try is change memory_order_relaxed to memory_order_seq_cst and see if that makes a difference, i.e.:
diff --git a/src/unix/fs.c b/src/unix/fs.c
index 4a4e2e3a..b3d371b4 100644
--- a/src/unix/fs.c
+++ b/src/unix/fs.c
@@ -471,7 +471,7 @@ static ssize_t uv__preadv_or_pwritev(int fd,
   ssize_t (*f)(int, const struct iovec*, uv__iovcnt, off_t);
   void* p;

-  p = (void*) atomic_load_explicit(cache, memory_order_relaxed);
+  p = (void*) atomic_load_explicit(cache, memory_order_seq_cst);
   if (p == NULL) {
 #ifdef RTLD_DEFAULT
     p = dlsym(RTLD_DEFAULT, is_pread ? "preadv" : "pwritev");
@@ -479,7 +479,7 @@ static ssize_t uv__preadv_or_pwritev(int fd,
 #endif  /* RTLD_DEFAULT */
     if (p == NULL)
       p = is_pread ? uv__preadv_emul : uv__pwritev_emul;
-    atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
+    atomic_store_explicit(cache, (uintptr_t) p, memory_order_seq_cst);
   }

   f = p;

Unfortunately, it didn't work.

Would it be possible to get a disassembly of that function (the original one, unpatched)? I think you should be able to download the build artifacts somewhere but I don't remember where and I can't find it :see_no_evil:

So I've using objdump (it's the first time I'm doing this so bear with me):
$ objdump -S --disassemble=uv__preadv_or_pwritev ./out/Release/obj.target/deps/uv/libuv.a

And interestingly it looks like when my changes are applied the disassembled code is found, but not with the original code. It seems the compiler doesn't inline the code with my additional changes. That doesn't explain the failures though.
Here's the assembled code:

uv__preadv_or_pwritev
0000014c <uv__preadv_or_pwritev>:
static ssize_t uv__preadv_or_pwritev(int fd,
                                     const struct iovec* bufs,
                                     size_t nbufs,
                                     off_t off,
                                     _Atomic uintptr_t* cache,
                                     int is_pread) {
     14c:	e92d 4ff0 	stmdb	sp!, {r4, r5, r6, r7, r8, r9, sl, fp, lr}
     150:	4605      	mov	r5, r0
     152:	f8df a0c0 	ldr.w	sl, [pc, #192]	; 214 <uv__preadv_or_pwritev+0xc8>
     156:	b083      	sub	sp, #12
     158:	af02      	add	r7, sp, #8
     15a:	460e      	mov	r6, r1
     15c:	4690      	mov	r8, r2
     15e:	44fa      	add	sl, pc
     160:	f8d7 9030 	ldr.w	r9, [r7, #48]	; 0x30
  ssize_t (*f)(int, const struct iovec*, uv__iovcnt, off_t);
  void* p;

  p = (void*) atomic_load_explicit(cache, memory_order_relaxed);
     164:	f8d9 0000 	ldr.w	r0, [r9]
  if (p == NULL) {
     168:	b1d0      	cbz	r0, 1a0 <uv__preadv_or_pwritev+0x54>
     16a:	4b2b      	ldr	r3, [pc, #172]	; (218 <uv__preadv_or_pwritev+0xcc>)
    if (p == NULL)
      p = is_pread ? uv__preadv_emul : uv__pwritev_emul;
    atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
  }

  f = p;
     16c:	4604      	mov	r4, r0
     16e:	f85a a003 	ldr.w	sl, [sl, r3]
  ssize_t r = f(fd, bufs, nbufs, off);
     172:	e9d7 230a 	ldrd	r2, r3, [r7, #40]	; 0x28
     176:	e9cd 2300 	strd	r2, r3, [sp]
     17a:	4631      	mov	r1, r6
     17c:	4642      	mov	r2, r8
     17e:	4628      	mov	r0, r5
     180:	47a0      	blx	r4

# ifdef __va_arg_pack
__fortify_function int
fprintf (FILE *__restrict __stream, const char *__restrict __fmt, ...)
{
  return __fprintf_chk (__stream, __USE_FORTIFY_LEVEL - 1, __fmt,
     182:	4a26      	ldr	r2, [pc, #152]	; (21c <uv__preadv_or_pwritev+0xd0>)
     184:	4604      	mov	r4, r0
     186:	462b      	mov	r3, r5
     188:	f8da 0000 	ldr.w	r0, [sl]
     18c:	447a      	add	r2, pc
     18e:	2101      	movs	r1, #1
     190:	9400      	str	r4, [sp, #0]
     192:	f7ff fffe 	bl	0 <__fprintf_chk>
  fprintf(stderr, "fd: %d. r: %d\n", fd, r);
  return r;
  //return f(fd, bufs, nbufs, off);
}
     196:	4620      	mov	r0, r4
     198:	3704      	adds	r7, #4
     19a:	46bd      	mov	sp, r7
     19c:	e8bd 8ff0 	ldmia.w	sp!, {r4, r5, r6, r7, r8, r9, sl, fp, pc}
    p = dlsym(RTLD_DEFAULT, is_pread ? "preadv" : "pwritev");
     1a0:	6b7b      	ldr	r3, [r7, #52]	; 0x34
     1a2:	b1c3      	cbz	r3, 1d6 <uv__preadv_or_pwritev+0x8a>
     1a4:	491e      	ldr	r1, [pc, #120]	; (220 <uv__preadv_or_pwritev+0xd4>)
     1a6:	4479      	add	r1, pc
     1a8:	f7ff fffe 	bl	0 <dlsym>
     1ac:	4683      	mov	fp, r0
    dlerror();  /* Clear errors. */
     1ae:	f7ff fffe 	bl	0 <dlerror>
    fprintf(stderr, "p: %p\n", p);
     1b2:	4b19      	ldr	r3, [pc, #100]	; (218 <uv__preadv_or_pwritev+0xcc>)
     1b4:	4a1b      	ldr	r2, [pc, #108]	; (224 <uv__preadv_or_pwritev+0xd8>)
     1b6:	2101      	movs	r1, #1
     1b8:	447a      	add	r2, pc
     1ba:	f85a a003 	ldr.w	sl, [sl, r3]
     1be:	465b      	mov	r3, fp
     1c0:	f8da 0000 	ldr.w	r0, [sl]
     1c4:	f7ff fffe 	bl	0 <__fprintf_chk>
    if (p == NULL)
     1c8:	f1bb 0f00 	cmp.w	fp, #0
     1cc:	d01d      	beq.n	20a <uv__preadv_or_pwritev+0xbe>
  f = p;
     1ce:	465c      	mov	r4, fp
    atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
     1d0:	f8c9 b000 	str.w	fp, [r9]
     1d4:	e7cd      	b.n	172 <uv__preadv_or_pwritev+0x26>
    p = dlsym(RTLD_DEFAULT, is_pread ? "preadv" : "pwritev");
     1d6:	4914      	ldr	r1, [pc, #80]	; (228 <uv__preadv_or_pwritev+0xdc>)
     1d8:	4618      	mov	r0, r3
     1da:	4479      	add	r1, pc
     1dc:	f7ff fffe 	bl	0 <dlsym>
     1e0:	4683      	mov	fp, r0
    dlerror();  /* Clear errors. */
     1e2:	f7ff fffe 	bl	0 <dlerror>
    fprintf(stderr, "p: %p\n", p);
     1e6:	4b0c      	ldr	r3, [pc, #48]	; (218 <uv__preadv_or_pwritev+0xcc>)
     1e8:	4a10      	ldr	r2, [pc, #64]	; (22c <uv__preadv_or_pwritev+0xe0>)
     1ea:	2101      	movs	r1, #1
     1ec:	447a      	add	r2, pc
     1ee:	f85a a003 	ldr.w	sl, [sl, r3]
     1f2:	465b      	mov	r3, fp
     1f4:	f8da 0000 	ldr.w	r0, [sl]
     1f8:	f7ff fffe 	bl	0 <__fprintf_chk>
    if (p == NULL)
     1fc:	f1bb 0f00 	cmp.w	fp, #0
     200:	d1e5      	bne.n	1ce <uv__preadv_or_pwritev+0x82>
     202:	4c0b      	ldr	r4, [pc, #44]	; (230 <uv__preadv_or_pwritev+0xe4>)
     204:	447c      	add	r4, pc
      p = is_pread ? uv__preadv_emul : uv__pwritev_emul;
     206:	46a3      	mov	fp, r4
     208:	e7e2      	b.n	1d0 <uv__preadv_or_pwritev+0x84>
    if (p == NULL)
     20a:	4c0a      	ldr	r4, [pc, #40]	; (234 <uv__preadv_or_pwritev+0xe8>)
     20c:	447c      	add	r4, pc
      p = is_pread ? uv__preadv_emul : uv__pwritev_emul;
     20e:	46a3      	mov	fp, r4
     210:	e7de      	b.n	1d0 <uv__preadv_or_pwritev+0x84>
     212:	bf00      	nop
     214:	000000b2 	.word	0x000000b2
     218:	00000000 	.word	0x00000000
     21c:	0000008c 	.word	0x0000008c
     220:	00000076 	.word	0x00000076
     224:	00000068 	.word	0x00000068
     228:	0000004a 	.word	0x0000004a
     22c:	0000003c 	.word	0x0000003c
     230:	00000028 	.word	0x00000028
     234:	00000024 	.word	0x00000024

With the original code, the code in the function seems to be inlined for copyfile ,  writev and readv though I'm not sure how to extract it. I'll try to provide the full dump for both cases.

These are the objdumps.
libuv_objdump_fail.txt
libuv_objdump_ok.txt

I've looked at both asm listings for some time now and I still have no idea why one works and the other doesn't :shrug:

So now that gdb has been installed in the instance (thanks @richardlau ) I've been able to see what's going on though I don't understand why.
See the assembly code that calls preadv():

failing asm
Thread 1 "node" hit Breakpoint 1, uv__preadv_or_pwritev (is_pread=1, cache=0x5c1da20 <cache>, off=0, nbufs=<optimized out>, bufs=0xffe14d2c, fd=19) at ../deps/uv/src/unix/fs.c:486
486	  ssize_t r = f(fd, bufs, nbufs, off);
=> 0x0204f120 <uv__fs_work+3520>:	49 46	mov	r1, r9
   0x0204f122 <uv__fs_work+3522>:	cd e9 00 56	strd	r5, r6, [sp]
   0x0204f126 <uv__fs_work+3526>:	58 46	mov	r0, r11
   0x0204f128 <uv__fs_work+3528>:	ba 63	str	r2, [r7, #56]	; 0x38
   0x0204f12a <uv__fs_work+3530>:	98 47	blx	r3
(gdb) info registers
r0             0x0                 0
r1             0x5c1da10           96590352
r2             0x2                 2
r3             0xf75ac2d9<PHONE_NUMBER>
r4             0xf75ac2d9<PHONE_NUMBER>
r5             0x0                 0
r6             0x0                 0
r7             0xffe14a28<PHONE_NUMBER>
r8             0xf786f64c<PHONE_NUMBER>
r9             0xffe14d2c<PHONE_NUMBER>
r10            0x1                 1
r11            0x13                19
r12            0x5be66cc           96364236
sp             0xffe14a10          0xffe14a10
lr             0x204f113           33878291
pc             0x204f120           0x204f120 <uv__fs_work+3520>
cpsr           0xa00b0030          -1609891792
fpscr          0x80000011          -2147483631
(gdb) step
__GI_preadv (fd=19, vector=0xffe14d2c, count=2, offset=-145046823) at ../sysdeps/unix/sysv/linux/preadv.c:27

succeeding asm
Thread 1 "node" hit Breakpoint 1, uv__preadv_or_pwritev (fd=fd@entry=19, bufs=bufs@entry=0xff89ecac, nbufs=2, off=<optimized out>, cache=<optimized out>, is_pread=<optimized out>, is_pread@entry=1) at ../deps/uv/src/unix/fs.c:487
487	  ssize_t r = f(fd, bufs, nbufs, off);
=> 0x02145aea <uv__preadv_or_pwritev+46>:	42 46	mov	r2, r8
   0x02145aec <uv__preadv_or_pwritev+48>:	31 46	mov	r1, r6
   0x02145aee <uv__preadv_or_pwritev+50>:	28 46	mov	r0, r5
   0x02145af0 <uv__preadv_or_pwritev+52>:	8d ed 00 8b	vstr	d8, [sp]
   0x02145af4 <uv__preadv_or_pwritev+56>:	a0 47	blx	r4
(gdb) info registers
r0             0xe                 14
r1             0xff89e944<PHONE_NUMBER>
r2             0x0                 0
r3             0x0                 0
r4             0xf78ec2d9<PHONE_NUMBER>
r5             0x13                19
r6             0xff89ecac<PHONE_NUMBER>
r7             0xff89e990<PHONE_NUMBER>
r8             0x2                 2
r9             0x5d15a20           97606176
r10            0xf795edf0<PHONE_NUMBER>
r11            0xf78ec2d9<PHONE_NUMBER>
r12            0x4                 4
sp             0xff89e978          0xff89e978
lr             0x2145b49           34888521
pc             0x2145aea           0x2145aea <uv__preadv_or_pwritev+46>
cpsr           0xa00b0030          -1609891792
fpscr          0x80000011          -2147483631

When it's failing, we can see that the 4th argument (off_t off) is not correctly set. Instead it looks like r3 is used to store the address of the preadv() function.
Thoughts? Ideas how to continue debugging this?

The calling convention for that argument has likely changed several times over various recent gcc versions (due to alignment and other concerns). Are we definitely using the same compiler everywhere, including for libc?

This is an armhf container running on an arm host. The container runs an Ubuntu 22.04 which defaults to gcc-11 but we're building Node.js with gcc-12. Might that be the problem?

The arm calling convention uses r0-r3 for the first four arguments, other arguments go on the stack.
off_t is 64 bits and it's the 4th argument so I think one half goes on the stack and the other in r3.
I checked with arm-linux-gnueabihf-gcc-11 and arm-linux-gnueabihf-gcc-12 and they produce functionally identical code except with different offsets for uv__preadv_or_pwritev - and it indeed branches on blx r3.
I get the feeling that's a compiler bug because with the sample below, at any optimization level, it correctly uses r0-r3 for arguments and emits blx r4 for the function pointer call.
#define _FILE_OFFSET_BITS 64
#define _LARGEFILE_SOURCE
#include <sys/uio.h>
__attribute__((noinline)) ssize_t g(ssize_t (*f)(int, const struct iovec *, int, off_t)) {
        static char b[64];
        return f(0, &(struct iovec){&b,sizeof(b)}, 1, (off_t)0x1122334455667788ll);
}
int main(void) {
        return g(preadv);
}

Using memcpy makes it emit blx r4 though:
diff --git a/src/unix/fs.c b/src/unix/fs.c
index 4a4e2e3a..f5d5d476 100644
--- a/src/unix/fs.c
+++ b/src/unix/fs.c
@@ -482,7 +482,7 @@ static ssize_t uv__preadv_or_pwritev(int fd,
     atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
   }

-  f = p;
+  memcpy(&f, &p, sizeof(p));
   return f(fd, bufs, nbufs, off);
 }

I suspect the compiler's alias analysis pass gets confused somehow, even though we definitely compile with -fno-strict-aliasing. I'll open a pull request.

So #4537 didn't fix the issue. Sorry I approved the PR without testing  but didn't have time to do it until today. This is the assembly output I get (still branches on blx r3):
Thread 1 "node" hit Breakpoint 1, uv__preadv_or_pwritev (is_pread=1, cache=0x5fa2a20 <cache>, off=0, nbufs=2, bufs=0xffe6824c, fd=19) at ../deps/uv/src/unix/fs.c:486
486	  return f(fd, bufs, nbufs, off);
=> 0x023d4094 <uv__fs_work+3380>:	22 46	mov	r2, r4
   0x023d4096 <uv__fs_work+3382>:	29 46	mov	r1, r5
   0x023d4098 <uv__fs_work+3384>:	40 46	mov	r0, r8
   0x023d409a <uv__fs_work+3386>:	cd e9 00 6a	strd	r6, r10, [sp]
   0x023d409e <uv__fs_work+3390>:	98 47	blx	r3
   0x023d40a0 <uv__fs_work+3392>:	04 46	mov	r4, r0

With what gcc version is that? I've tested with these two:

gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
gcc version 12.3.0 (Ubuntu 12.3.0-1ubuntu1~22.04)

Both first produced the wrong code and now produce the right code.

gcc version 12.3.0 (Ubuntu 12.3.0-1ubuntu1~22.04)

Huh, the exact same compiler? How did you build: standalone or as part of node? If the latter, can you try the former?

Can you try if this works?
diff --git a/src/unix/fs.c b/src/unix/fs.c
index 6d810deb..669b2f4a 100644
--- a/src/unix/fs.c
+++ b/src/unix/fs.c
@@ -468,7 +468,10 @@ static ssize_t uv__preadv_or_pwritev(int fd,
                                      off_t off,
                                      _Atomic uintptr_t* cache,
                                      int is_pread) {
-  ssize_t (*f)(int, const struct iovec*, uv__iovcnt, off_t);
+  /* Volatile to work around a compiler bug,
+   * see https://github.com/libuv/libuv/issues/4532
+   */
+  ssize_t (*volatile f)(int, const struct iovec*, uv__iovcnt, off_t);
   void* p;

   p = (void*) atomic_load_explicit(cache, memory_order_relaxed);
@@ -482,10 +485,7 @@ static ssize_t uv__preadv_or_pwritev(int fd,
     atomic_store_explicit(cache, (uintptr_t) p, memory_order_relaxed);
   }

-  /* Use memcpy instead of `f = p` to work around a compiler bug,
-   * see https://github.com/libuv/libuv/issues/4532
-   */
-  memcpy(&f, &p, sizeof(p));
+  f = p;
   return f(fd, bufs, nbufs, off);
 }

former

As part of node. I'll try standalone.

I think I already tried the volatile thing, but I'll do it again

Unfortunately, using volatile doesn't fix it either:
Thread 1 "node" hit Breakpoint 1, uv__preadv_or_pwritev (is_pread=1, cache=0x61f7a20 <cache>, off=0, nbufs=2, bufs=0xffe4fd4c, fd=19) at ../deps/uv/src/unix/fs.c:486
486	  f = p;
=> 0x02629006 <uv__fs_work+3238>:	38 63	str	r0, [r7, #48]	; 0x30
(gdb) n
487	  return f(fd, bufs, nbufs, off);
=> 0x02629008 <uv__fs_work+3240>:	22 46	mov	r2, r4
   0x0262900a <uv__fs_work+3242>:	cd e9 00 89	strd	r8, r9, [sp]
   0x0262900e <uv__fs_work+3246>:	29 46	mov	r1, r5
   0x02629010 <uv__fs_work+3248>:	30 46	mov	r0, r6
   0x02629012 <uv__fs_work+3250>:	3b 6b	ldr	r3, [r7, #48]	; 0x30
   0x02629014 <uv__fs_work+3252>:	98 47	blx	r3
   0x02629016 <uv__fs_work+3254>:	04 46	mov	r4, r0

Compiler bugs are gonna bug, what can you do? Node's CI being green again (metaphorically speaking - it's never completely green) is good enough for me. We could perhaps also add a warning to the README.

Added the warning in the README: https://github.com/libuv/libuv/pull/4541


how to rename a function/method?

i need to feature to rename function like runkit? is it support?

You can "delete" method and then add it with new name. However it won't always work.

You can do the same with functions and it should work fine


Invite users button

From #5523 and #4882. Since "invite users" is now global and not only ldap-only, "create user" and "invite user" is no longer alternative but complimentary: we need both. Original design doesn't cover this, it has one only "Create user" button that opens one modal or another depending on authentication type. But since we need both, we need to combine forms or two buttons for the two different actions an owner can do: inviting and creating new.
cc @xavijam

@josecruz, all yours, should be easy, but be sure you contemplate all the different cases (LDAP vs NON-LDAP and so on...). I'd make this :top: priority (ie done during monday) since @juanignaciosl is about to be able to release this,

Correct me if I'm wrong: Do do you need it in this screen?

@josecruz yes, that's it.

Q: So could we merge both forms on this modal?

I don't think so, but @xavijam should say something here. For example, I really doubt "Create user" would fit the modal without an inner scroll.

Okay so I would fit everything on the next step of clicking "create or invite new user":

ping @saleiva

Can you draft the other tab as well?

Yep!

I don't know if we could make a list of the groups you've already created, or show a dropdown with current groups.

groups should be a dropdown when writting. I don't thing we are using those long fields anywhere else, right? Not for single things like the groups one. Remember that more than one user can be invited at a time and that Invite should be the default option when clicking on that button

@xavijam you can branch 4882-Invite_users_to_your_organization in order to change the form design if needed. I added a second "Invite user" button that opens the modal for development purposes. Everything else at #4882 is done, when you finish this and it gets merged into 4882-Invite_users_to_your_organization I'll request the CR and do the staging testing.

@saleiva FYI group field was delayed to #5504 because this development begun before Groups were available. I'd release this first but if @xavijam can do the group picker I'll add group support right now at 4882-Invite_users_to_your_organization branch.

After talk with @saleiva we made this button with a dropdown

Create User would link to the current screen
Invite User would link to the modal.

Great, thanks for making it easier for us :heart: @saleiva @josecruz.

Implemented, should I close this issue?


Revert "Bump fs-extra from 3.0.1 to 4.0.1 in /helpers/javascript"

Reverts dependabot/dependabot-core#25

Oops, shouldn't have merged this!


Fill halo regions for diffusivity

This fixes a bug in which halo regions were not filled for subgrid-scale LES diffusivities.
To do this robustly for various diffusivity structures with different nesting hierarchies, a recursive halo region filling functionality is implemented that dispatches on bcs::NamedTuple{(:x, :y:, :z)}, corresponding to a FieldBoundaryCondition. Thus, when fill_halo_regions!(fields, bcs, grid) is called with matching tuples for both fields and bcs, a simultaneous loop is done over the members of the two tuples. However, when fill_halo_regions!(fields, bcs, grid) is called and bcs is a FieldBoundaryCondition, a loop is performed over the members of fields only, and bcs is reused for every member of fields. Thus halo regions for fields embedded in nested structures (like diffusivities in AnisotropicMinimumDissipation) are all filled with a single call to fill_halo_regions!.
For now, the code uses temperature boundary conditions to determine the diffusivity boundary conditions. This will work until we implement the changes proposed in #371.

Looks good to me! Should make it into v0.10.0.


Can I edit a custom map?

like this
https://leafletjs.com/examples/crs-simple/crs-simple.html

Do you mean editing a map with a different projection?

yes, like starmap

Currently this editor is only for editing OpenStreetMap, or a fork of OpenStreetMap.  We're hoping to generalize the code to make it much more widely useful though!
see #6483 for more info
Also we recently talked about this at SOTM-US!   here's a link to the talk and video


Create About section

Description
For understanding of UI/UX check here
Make sure the page is responsive in MOBILE , TAB . DESKTOP , LAPTOP
Add screenshots for the same.
Screenshots

Additional information
Guidelines ⚠
I will follow the Setup Guidelines
I will follow the Contributing Guidelines
I will follow the Code of Conduct

Notice ⛔
You will make PRs only to itsroy69-main branch.
Commit message / PR title--> fix: bla bla bla
Please make sure in the .css files you are making/using , the styles should be applied to Unique Class names

Completed / Doubts ? 🚀
Once you are done with the code , please tag me in #milan with the Screenshot of whatever you made so that we can review that there together.
If you have any doubts, queries please tag me in #vesttech so that we can discuss the issue there together.
Cheers 🥂

hi, you put that is allowed to go font google for the font but that font is not available there (the font in Figma is Microsoft YaHei UI) . Can you provide a link to the font or should i use other one?

You can use any font you want.

Hi @ItsRoy69 I have created about section
as I am new to open source I have directly cloned and updated code
I will fork and make pull request tommorow if this output is fine and let me know if there's some changes

Since @Imagine96 didn't ask for assigning him so @KiranBendkoli1 you can fork and push it
This looks cool to me.


Prototype of merging 'blog' -> 'docs'

[edited:fixed bad netlify links]
Hi guys, here is a prototype of my work merging 'blog' into 'docs'.
Ideally start viewing on 'large (lg)' display, cause I need help on top-nav on sm/md.
I know you guys are busy, so here is a build:
http://<IP_ADDRESS>/
There is one blog page I didn't integrate into the navigation:  blog orphan
So, I have two questions for you guys:

Do you think you guys might/maybe be interested in having this become a Tighten template? It may be less work than maintaining two templates, also, it could (with-work) possibly be configurable for: blog+docs, docs-only, blog-only.
I totally understand it may not work for your needs, if that is the case, we don't have to work through the PR and you guys don't have to review it, etc, etc... If you think: maybe, possibly, it might be interesting for us, then let me know any PR changes you would like to see...

There is one thing I would humbly like to ask for suggestions, or even a little coding help with if you feel generous. :smile: (please say no if too busy)
My ask: right now the top-nav ("Blog About Contact") only shows up on lg:+, and disappears on sm,md,etc...   I tried to merge the techniques used for small-responsive top-nav used in 'blog' into 'docs', but I didn't like how the top-nav elements (blog,about,contact) blend-into the docs-nav elements on 'docs' pages when I tried doing so.

I would like to see if you guys can suggest what flex/tailwind classes are needed for the divs containing the top-nav elements, so that it will grow from a single-row (current) to two-rows, or maybe even more than two-rows as the view port contracts.
I may take a stab at this, but I am learning tailwind/flexbox in the process.
Thanks to @mattstauffer for his promptness, patience and advice, thanks @anthonyterrell for merging the upgrade and reviewing, and thanks to all of you for creating and maintaining these wonderful works. :tada: :taco:
@damiani

PS, Algolia is broken but forced to show on purpose for the reason of showing you the search box in your review.

PPS the written copy for readme and other articles in this repo will need someone's (mine?) review and fixing if this template is to get up to git-sharable / publishable condition. But I wanted to share the code prototype and get feedback before investing time in that. I suppose the Jigsaw written copy would need work also.
I suppose a lot depends on whether you think this is an alternative to the current blog/docs (as an offering from the Tighten repo)
You may want to look at Docusaurus to see how another docs package uses a blog+documentation.
Docusaurus
(simply to see another view on things)

I just hope I am not creating too much work for you guys, I know how much work even reviewing a PR can be.  Please let me know what works best for you guys, even if you are too busy to deal with this.
Much thanks in advance, Cameron.

Hey you guys, I put this up here, not as a full "here it is, please merge",
but as "Hi guys, here is a prototype, what do you think?" as I said at first.
I posted this to generate a conversation to see if it is of any interest to the Tighten team, that is all.
Any feedback, good, bad, indifferent, "go-away-please" is totally appreciated.
I am sure you guys are very busy, so I understand this is not a priority,
honestly, I am trying to do too many other things, so I really probably don't actually have
much time to get this super clean and tight either....
But mostly I wanted to see if you guys had any thoughts about the value of a single merged docs/blog template.
Well, I am sorry to bother you guys again, but I was surprised nobody had any thoughts.
Nonetheless, thanks all of you for your great open source contributions.

I mentioned this in an email, but we're very interested, just very busy, and the bigger the PR is, the longer we have to set aside to review it. Thanks for your hard work!

@cameron-elliott I'm going to take a look at this today ... my instinct is to treat this as a separate third template, but let me think through it and get back to you. Thanks for working so hard on this! 👍

@damiani FWIW, that's 100% my instinct as well.

Hey guys, I feel bad for pinging you now, sorry, I really just wondered if I had committed a faux pas and said something wrong. Please take all the time in the world.... Anyway, really love your guys stuff. Thanks for making it.

FYI @cameron-elliott It's been a full month--this is almost at the top of my todo list as of yesterday. Thanks for your work--I saw you push up a commit, so you're thinking about it, too. Hopefully this week!

No worries, it's all good, I understand you all probably have 1e6 other things to be looking at also.
I do!
I didn't really intend for that article to go into the PR, so I need to see how to fix that. Lol.

@cameron-elliott I've set up a new repo that we can use to make this a new, third combined template, separate from blog and docs ones, so we can keep those simple. Can you PR your code over there, and then we can continue discussing/modifying in that repo?
https://github.com/tightenco/jigsaw-combined-template

I tried cloning the repo and just changing the origin primary remote, which was probably a little optimistic.

Any suggestions on how to move those commits of mine over in the simplest way from here:
https://github.com/cameron-elliott/jigsaw-docs-blog-template-master
to here:
https://github.com/cameron-elliott/jigsaw-combined-template
I could just use a diff tool to edit all the commits back into a clean 'combined' checkout, but then
I would need to re-commit each commit or commit it as a big single poor-named commit.
Ideas?


Watch for schema{.json,.graphql} changes

If changes are made to the schema while the service is running, they are not taken into account since the schema gets cached on first load (_schemaMap).
For our use case, we emit a schema.json as part of our server compilation. This would help with newly added fields showing up in the autocomplete, validation, etc. without having to reload the entire window.

Watchman should notify us on schema changes and then reload the schema accordingly. This would be my ideal case.
Does the LSP protocol offer any way to restart the server maybe?

Does the LSP protocol offer any way to restart the server maybe?

It is certainly possible to do this from the integration side. I had a poc locally where I would restart the server on changes to the schema file, and this worked fine. However, I feel like we could do it will less overhead by instead just invalidated the relevant caches.


OSM: Parameters for pedestrian and transportation infrastructure

I am wondering how to check parameters for pedestrian or transportation infrastructure in OSM. For now, I search for Wiki https://wiki.openstreetmap.org/wiki/Highways for the related tag. Not sure if that's an efficient way to do, any other suggestions will be appreciated.
For the pedestrian network, they use that for the previous project:
pedestrian = (
             '["area"!~"yes"]'
             '["highway"!~"motor|proposed|construction|abandoned|platform|raceway"]'
             '["foot"!~"no"]'
             '["service"!~"private"]'
             '["access"!~"private"]'
             )

Just wondering how it compared to network_type={'walk' , 'cycle'}.
I try to retain transportation infrastructure, for example infrastructure='way["public_transport"~"platform"], but the result turns out strange. I would like to know what other kinds of transportation infrastructure parameters available there in OSM, what is the best way to quick search about this?
Maybe we could discuss further with this? It is part of the proposed indicators to consider, like public transport access, ratios of roads to cycle lanes, distance to transit etc.  Also, may need to overlay with related administrative spatial data (if available) to compare how OSM reflects the reality.

You can see OSMnx's various network_type filters here: https://github.com/gboeing/osmnx/blob/eb39dff4aaf726d33b6b7aa9f71c50f3e9b9f012/osmnx/core.py#L560
In general, you'll want to use the OSMnx pre-built filters unless there's clear evidence that they're insufficient (in which case, we might want to update them).
Here's a good place to get started with OSM tags: https://wiki.openstreetmap.org/wiki/Tags
You can test queries interactively here: https://overpass-turbo.eu/

The pedestrian custom filter I created was really done for our Melbourne context, where due to many shared bike/cycle paths we found exclusion of cycleways seemed problematic for pedestrian path representation; walkble cut throughs through parks, and some bridge crossing weren't included due to being flagged as cyclepaths.  From memory, my custom filter is basically like the OSMnx 'walk' with the cycling exclusion removed. Basically, we felt that in Australia, anywhere a bike can go, a pedestrian can go too; hence combined approach; in Melbourne it appeared to provide a more valid network for our purposes.
Geoff makes a good point that, while this might make sense in Melbourne or Australia it may not be appropriate in global context.

Thank you for the clarification! So maybe setting the network_type = walk is a more conservative approach to define pedestrian in a global context. At least in the US, some of the bike lanes are in the middle of the road and not designed for walking. But we could always add cycle as another option for comparison. Good to know the context!


Introduce gosec for Static Application Security Testing (SAST)

What would you like to be added:
Please, ensure that gosec is enabled, a new release is created, and deployed.
You can use this PR from g/g for reference.
Why is this needed:
Security & Compliance

Hello @JordanJordanov a review would be greatly appreciated

Completed in https://github.com/gardener/gardener-extension-shoot-falco-service/pull/87


Upgrade rust dependencies and replace failure with anyhow

No CI tests are running here... I guess I need to test manually before merge

This PR also fixes #37.

Tested locally, looks good. Thanks.

Tagged a v0.6.4 release and pushed a 0.6.4 crate for you to import.


batched inference generating inaccurate segments

there seems to be significant difference between segment detection when using plain whisper vs batched inference
batched seems to perform way worse on most of the files I've tested, is this a known side effect of batching?
would it be possible to generate segments for the individual batches?

what exactly do you mean by segment detection?

I think he meant chunking.
Btw, I see difference in chunking the current vs r194 is it because something changed in the padding?

There were many subtle changes since that commit (VAD, features padding, different PyAV versions) that should not affect the transcription quality, although it might be difficult to reproduce something as chunking.
The encoder padding should not affect any usecase where chunk_length is 30s

segments return with batched

without batched

the returned segments for the same file when using the batched model seems to give way chunkier segments

use without_timestamps=False, but the transcription quality may be worse and it will be slower

that did it, thanks for pointing me in right direction

@MahmoudAshraf97
Why should we set without_timestamps=False to fix this, and why might the transcription quality be worse?

First of all, this is not an issue so that we can fix it, this is an option that the user can control, without_timestamps=False generates approximate timestamp tokens that are used to split the transcription of a 30s window, this is not needed in batched transcription and hence turned off by default so that we don't generate unnecessary tokens, turning it on will lead to worse result due to a bug in CT2 https://github.com/OpenNMT/CTranslate2/issues/1783 or is it from the model itself, I haven't tested extensively

The quality decrease without_timestamps=True introduces, would that be more significant when using batched inference in comparison assuming we already were using without_timestamps=True previously?

using without_timestamps=True previously produced even worse results because the longform transcription algorithm depends on the timestamps, that's why the degradation wasn't noticeable, but when we use an algorithm that did not depend on timestamps, we can objectively compare the results with and without the timestamps


[topgen] Add support for alternative port types

This is similar to #15050 but uses the topgen template to insert the analog simulation types and macros.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

@sha-ron @Jacob-Levy I absorbed this into the chiplevel template so that no separate post-processing is required anymore. Let me know if this does not work.

@msfschaffner What you did is not what the post-processing did...
The post-procesing replace  the ports with MACROs to enable noormal and ANALOGSIM modes.
You have to use the MACROS, else it wil mot work.

Thanks for the note regarding the real port type, I overlooked the fact that it cannot be inout.
I have adapted the PR accordingly.
Note that declaring different port types for FPGA would not be so straightforward to do with the current templating mechanism, hence the change ripples through into the FPGA chip-level.
This should be ok, though, since we do not intend to define ANALOGSIM in the FPGA build.

@msfschaffner  Just to remind you that the ANALOGSIM mode is not synthesizable, hence the 310 platform for FPGA
will not work. All the ANALOGSIM mode is for  ASIC simulation only.
My post-processing worked on the ASIC platform only.

@msfschaffner Just to remind you that the ANALOGSIM mode is not synthesizable, hence the 310 platform for FPGA will not work. All the ANALOGSIM mode is for ASIC simulation only. My post-processing worked on the ASIC platform only.
Otherwise, LGTM.

That is ok - we do not plan to pass the ANALOGSIM define to any synthesis flows.


connecting to mac address

Is there any documentation on connection to a specific mac address via react-discovery?
Sorry if I missed something when poking around. Thanks

@joelwass you're not actually connecting to the other devices. You're just observing them, kind of just to see who's around.

Ok, is react support for ble connection still young?

Not sure but it's out of the scope of this library... :)


Step 8 is missing in APIM 3.0.0 IS as KM doc

Description:
In step 8, the user should be pointed to relevant docs on deploying an all in one single, active-active and distributed deployment.
https://apim.docs.wso2.com/en/3.0.0/install-and-setup/deploying-wso2-api-manager/distributed-deployment/configuring-wso2-identity-server-as-a-key-manager/#step-8-configure-the-other-api-m-components

@ruthryi , can you please work on this issue. It is applicable to the 3.0.0, 3.1.0 and 3.2.0 docs.


how to?

You write "On the Additional security verification page", but how can I find this page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4fc7dec3-d354-6e40-8662-0e8175e3cb09
Version Independent ID: 49976ef5-2893-8f73-3a64-94c2f3753d04
Content: Set up an authenticator app as your two-factor verification method - Azure Active Directory
Content Source: articles/active-directory/user-help/multi-factor-authentication-setup-auth-app.md
Service: active-directory
Sub-service: user-help
GitHub Login: @curtand
Microsoft Alias: curtand

@nischl
Thanks for your feedback! We will investigate and update as appropriate.

Hi @nischl , this happens after MFA has been set up for the tenant.

To access the "Additional security verification" page, select next from the "More information required" prompt. Then the additional security verification page will appear.
You can test this by adding a new user and setting up two-factor verification.
https://docs.microsoft.com/en-us/azure/active-directory/user-help/multi-factor-authentication-end-user-first-time

Hope this helps! If you have further questions please post to Microsoft Q&A and I will gladly continue the discussion. https://docs.microsoft.com/answers/topics/azure-active-directory.html?filter=unanswered


Variable becomes undefined

Type: Bug
Facing this issue after upgrading VS code to latest version.  If a variable is having some data for example const _data = "some data" then in the next line of code the same variable becomes undefined. That variable looses all data it contains.
VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 x 3000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
7.83GB (1.36GB free)

Process Argv
--file-uri file:///e%3A/ShubhamB/projects/Node-Pojects/dpauls-worspace.code-workspace --crash-reporter-id 5c106cc6-f691-4980-a497-54bd34c3c026

Screen Reader
no

VM
0%

Extensions (49)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

icons-carbon
ant
0.2.6

vscode-apollo
apo
1.19.11

color-info
bie
0.7.2

blackbox
Bla
0.10.34

npm-intellisense
chr
1.4.4

path-intellisense
chr
2.8.4

githistory
don
0.6.19

xml
Dot
2.5.1

gitlens
eam
13.3.1

LogFileHighlighter
emi
2.16.0

prettier-vscode
esb
9.10.4

cshtml
fir
0.1.3

auto-close-tag
for
0.5.14

auto-rename-tag
for
0.1.10

vscode-env
Iro
0.1.0

vscode-peacock
joh
4.2.2

graphql-for-vscode
kum
1.15.3

git-graph
mhu
1.30.0

dotenv
mik
1.0.1

mongodb-vscode
mon
0.10.0

graphql
mqu
0.1.2

vscode-azureresourcegroups
ms-
0.6.0

vscode-cosmosdb
ms-
0.19.3

csharp
ms-
1.25.4

remote-ssh
ms-
0.96.0

remote-ssh-edit
ms-
0.84.0

remote-ssh-explorer
ms-
0.55.0

remote-wsl
ms-
0.75.3

azure-account
ms-
0.11.3

remote-explorer
ms-
0.2.0

vsliveshare
ms-
1.0.5832

debugger-for-chrome
msj
4.13.0

vetur
oct
0.37.3

docthis
oou
0.8.2

material-icon-theme
PKi
4.24.0

vscode-css-peek
pra
4.2.0

vscode-thunder-client
ran
2.4.3

LiveServer
rit
5.7.9

vscode-standard
sta
2.1.3

autoimport
ste
1.5.4

code-spell-checker
str
2.17.1

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

vscode-icons
vsc
12.2.0

volar
Vue
1.2.0

vscode-import-cost
wix
3.3.0

material-theme
zhu
3.15.6

html-css-class-completion
Zig
1.20.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30669237
azure-dev_surveyone:30548225
pyindex848:30662994
nodejswelcome1cf:30587006
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
vsctsb:30662444
vscodeenable:30660116
pythonb192cf:30669361

/needsMoreInfo
Please provide full code samples that demonstrates the problem and screenshots if needed.
Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


fix: add underlining for HyperlinkButton on WinUI

GitHub Issue: #1483
PR Type
What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes, no api changes)
Build or CI related changes
Documentation content changes
Other... Please describe:

Description

PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[ ] Tested the changes where applicable:

[ ] UWP
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[ ] material-controls-styles.md
[ ] cupertino-controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[ ] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

@Mergifyio backport release/stable/5.4

@Mergifyio backport release/stable/5.5

As recommended by @ramezgerges, making backports to all current versions since 5.3

@Mergifyio backport release/stable/5.4


Switching between normal and bold text leads to text break

Current behaviour
When you have tabs where the default text is not regular and the active tab is bold, you can get unnecessary line breaks. I assume that this has to do with box width calculation. If the box width is  fixed and calculated on the non bold version, making it bold will lead to the box being too small.
**Start bold and set to regular when not active numerOfLines **

const styles = StyleSheet.create({
	label: {
		textAlign: 'center',
		fontSize: 14,
		fontWeight: '700',
		margin: 0,
		backgroundColor: 'transparent',
	},
});
[...]
renderLabel={({ route, focused, color }) => {
    const weight =
        focused && props.hideIcon
            ? {}
            : {
                fontWeight: '400',
                };
    return (
        <Text
            style={[
                styles.label,
                {
                    color,
                    textTransform: props.hideIcon ? 'uppercase' : undefined,
                    ...weight,
                },
            ]}
            numberOfLines={1}
            allowFontScaling
        >
            {route.options.tabBarLabel}
        </Text>
    );
}}

**Start bold and set to regular when not active **

const styles = StyleSheet.create({
	label: {
		textAlign: 'center',
		fontSize: 14,
		fontWeight: '700',
		margin: 0,
		backgroundColor: 'transparent',
	},
});
[...]
renderLabel={({ route, focused, color }) => {
    const weight =
        focused && props.hideIcon
            ? {}
            : {
                fontWeight: '400',
                };
    return (
        <Text
            style={[
                styles.label,
                {
                    color,
                    textTransform: props.hideIcon ? 'uppercase' : undefined,
                    ...weight,
                },
            ]}
            allowFontScaling
        >
            {route.options.tabBarLabel}
        </Text>
    );
}}

** Make everything bold **

const styles = StyleSheet.create({
	label: {
		textAlign: 'center',
		fontSize: 14,
		fontWeight: '700',
		margin: 0,
		backgroundColor: 'transparent',
	},
});
[...]
renderLabel={({ route, focused, color }) => {
    return (
        <Text
            style={[
                styles.label,
                {
                    color,
                    textTransform: props.hideIcon ? 'uppercase' : undefined,
                },
            ]}
            allowFontScaling
        >
            {route.options.tabBarLabel}
        </Text>
    );
}}

Expected behaviour
There should be normal display if there is enough space
Code sample
See above.
Screenshots (if applicable)
See above
What have you tried

start regular and go bold
start bold and go regular
wrap with view

Your Environment

software
version

ios or android
Android

react-native
61.4

react-native-tab-view
2.13.0, 2.14.0

react-native-gesture-handler
1.6.1

react-native-reanimated
1.8.0

node
12.16.4

npm or yarn
yarn

I faced the same, anybody has solution for that?

Also facing the same behavior.

The dumb solution to this problem is to put a space after the text. 💩
Original: {key: 'home', title: 'Home'}
Solution: {key: 'home', title: 'Home '}
Not the best thing, but here it worked 👌

The dumb solution to this problem is to put a space after the text. 💩
Original: {key: 'home', title: 'Home'}
Solution: {key: 'home', title: 'Home '}
Not the best thing, but here it worked 👌

seems it depends on text length sometime you have to add 2 space LOL

Can you tell me when it can be solved? Thanks.

This solution I posted earlier works on some devices, on others it doesn't.
So I found a better solution, leaving the bold text rendered on the screen from the start, along with the main text, however transparent and with a small size.
The problem I see is that the lib does not render again when changing the font size, which causes a mismatch with the layout, some memoization or pure components.
My solution:
renderLabel={({route, focused}) => {
  return (
    <View>
      <Text style={{fontWeight: focused ? 'bold' : 'normal'}}>
        {route.title}
      </Text>
      <View style={{height: 1}}>
        <Text
          style={{
            fontWeight: 'bold',
            color: 'transparent',
          }}>
          {route.title}
        </Text>
      </View>
    </View>
  );
}}

Duplicate of #996 992


Packaged builds with BLUI on 4.12, 4.13 and 4.14 hang for over 60 seconds when run

I'm using the latest BLUI release 'BLUI.3.1.Windows.Linux.CX.-.VS2015.zip' (dated 2.6.2016) on a Blank Project in UE 4.13.2 (though I've also tried this on 4.12.5 and 4.14.1).  The project will compile without issue and run correctly in the editor.  When I package the project (either for Development or Shipping), running the executable will cause a hang for around 60 seconds before the application launches.  It appears the application fails to launch, but does appear around a minute later.  This happens both on Windows 10 and Windows 8 machines.  This issue does not happen for me on UE 4.11.2.
Looking at the task manager - I see 3 Unreal processes start.  Eventually one of the processes goes away before the application launches.  Using the Launch button in the Unreal Editor, I've reproduced the issue and captured the following logging:
LogPlayLevel: Project.Run: ********** RUN COMMAND STARTED **********
LogPlayLevel: Project.RunInternal: Starting Client....
LogPlayLevel: CommandUtils.Run: Run: D:\Data\Documents\Unreal Projects\Test_4_13\Saved\StagedBuilds\WindowsNoEditor\Test_4_13\Binaries\Win64\Test_4_13.exe ../../../Test_4_13/Test_4_13.uproject /Game/StarterContent/Maps/Minimal_Default -stdout -abslog="C:\Users\dcoll\AppData\Roaming\Unreal Engine\AutomationTool\Logs\D+Applications+Epic+Games+4.13\Client.log"
-Messaging -nomcp -Windowed -CrashForUAT -SessionId=6B3E1358408D650C80F114891C5BFD7B -SessionOwner="dcoll" -SessionName="Launch On Device"
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: LogCore:Error: Found 5 threads running, expected: -1073742360.
LogPlayLevel: Test_4_13: LogCore:Display: Dumping all worker threads to log.
LogPlayLevel: Test_4_13: LogCore:Display: Stack for thread 11740:
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Display:   KERNELBASE.dll
LogPlayLevel: Test_4_13: LogCore:Display:   Test_4_13.exe!FCrashReportingThread::Run()
LogPlayLevel: Test_4_13: LogCore:Display:   KERNEL32.DLL
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Warning: A thread may have been injected but no culprit was found!
LogPlayLevel: Test_4_13: LogInit:Display: RandInit(231645113) SRandInit(231645114).LogModuleManager:Warning: ModuleManager: Module 'XMPP' not found - its StaticallyLinkedModuleInitializers function is null.
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: [1108/133517:ERROR:tcp_socket_win.cc(361)] bind() returned an error: Only one usage of each socket address (protocol/network address/port) is normally permitted. (0x2740)
LogPlayLevel: Test_4_13: [1108/133517:ERROR:devtools_http_handler_impl.cc(307)] Cannot start http server for devtools. Stop devtools.
LogPlayLevel: Test_4_13: LogModuleManager:Warning: ModuleManager: Module 'XMPP' not found - its StaticallyLinkedModuleInitializers function is null.LogInit:Display: Game Engine Initialized.
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: [2016.11.08-18.35.18:310][  0]LogInit:Display: Game Engine Initialized.LogInit:Display: Starting Game.
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: [2016.11.08-18.35.18:318][  0]LogInit:Display: Starting Game.LogGameMode:Display: Match State Changed from EnteringMap to WaitingToStart
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: [2016.11.08-18.35.20:693][  0]LogGameMode:Display: Match State Changed from EnteringMap to WaitingToStartLogGameMode:Display: Match State Changed from WaitingToStart to InProgress
LogPlayLevel: Test_4_13:
LogPlayLevel: Test_4_13: [2016.11.08-18.35.20:693][  0]LogGameMode:Display: Match State Changed from WaitingToStart to InProgressLogWindowsTextInputMethodSystem:Display: IME system now deactivated.
 Time: 130.147942

One ammendment to the original description - I did use the later source code with the 'GetModuleFilenames' fix to allow compilation in the build.  Comparing the log with 4.11.2 logs, the major issue seems to be the apparent crash reported with the rather unhelpful core logging:
LogPlayLevel: Test_4_13: LogCore:Error: Found 5 threads running, expected: -1073742360.
LogPlayLevel: Test_4_13: LogCore:Display: Dumping all worker threads to log.
LogPlayLevel: Test_4_13: LogCore:Display: Stack for thread 11740:
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Display:   KERNELBASE.dll
LogPlayLevel: Test_4_13: LogCore:Display:   Test_4_13.exe!FCrashReportingThread::Run()
LogPlayLevel: Test_4_13: LogCore:Display:   KERNEL32.DLL
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Display:   ntdll.dll
LogPlayLevel: Test_4_13: LogCore:Warning: A thread may have been injected but no culprit was found!

Hi there!
I just want to confirm the issue, I'm experiencing it too. It appeared when we switched from 4.11 to 4.12 version.
Any further clue that you find might be helpful. I'll try to investigate the cause as well.

I have found at least a temporary workaround for this problem - though not one that necessarily points to the root cause.
If I build the UE4 Engine (in this case 4.13.2) myself from source instead of using Epic's pre-built engine, this hang/crash does not happen on package releases.  I've only tried this for the 4.13.2 build thus far, so I don't know if it helps for others, but it may be worth a try.

Good to know, I'll give a try with 4.12 version. Maybe we should point it directly to Epic, although I don't know how to put the problem .

Let me know if it works for you with the 4.12 build.  If so, then it might be worth bringing up with Epic.
Since their release appears to work with most other plugins, and since the actual BLUI source looks fairly innocuous, I'd guess it was some sort of mismatch between the Unreal Engine and the CEF used by BLUI.
But who knows, maybe this is some sort of obscure build issue with UE that doesn't happen when built locally?

You might be right about some mismatch in the dll, I think it could be related to allocators.
I also tried with another CEF, the one shipped with unreal, that you can find here:
C:\Program Files (x86)\Epic Games\4.12\Engine\Binaries\ThirdParty\CEF3\Win64
If you merely replace the dlls you see the exact same behaviour. Maybe they have the same problem.
When I pause my debugger during the hang, I see it is stuck here:
IDelegateInstance* DelegateInstanceInterface = Super::GetDelegateInstanceProtectedHelper(DelegateBase);
in the file
C:\Program Files (x86)\Epic Games\4.12\Engine\Source\Runtime\Core\Public\Delegates\DelegateSignatureImpl_Variadics.inl
Is it the same for you?

FIXED!
I think I found a code solution that does not require building unreal engine from source code.
I'll make a pull request in the following days.
If you want to fix it try this:
in BluManager.h, replace the static variables
static CefSettings settings;
static CefMainArgs main_args;
with local variables, and modify Blu.cpp to use them accordingly,
for example like this:
`
      CefString realExePath = *ExecutablePath;

	// Make a new manager instance
	CefRefPtr<BluManager> BluApp = new BluManager();

	// Set the sub-process path
	CefString(&BluApp->settings.browser_subprocess_path).FromString(realExePath);

	// Set the cache path
	CefString(&BluApp->settings.cache_path).FromString(GameDirCef);

	//CefExecuteProcess(BluManager::main_args, BluApp, NULL);
	CefInitialize(BluApp->main_args, BluApp->settings, BluApp, NULL);

	UE_LOG(LogBlu, Log, TEXT(" STATUS: Loaded"));`

I hope that it helps.

Brilliant - great job!  I'll try that in my code.

Tried it in my build and it fixed my issue as well.

As a real c++ dummy.  I've tried this and failed, probably due to not understanding how to make the local variables.  I tried just removing the 'static' from the start of the variables but it's just not compiling.  I'd love a nudge in the right direction!

Here is my StartupModule() function:
	/** IModuleInterface implementation */
	virtual void StartupModule() override
	{
		CefString GameDirCef = *FPaths::ConvertRelativePathToFull(FPaths::GameDir() + "BluCache");
		FString ExecutablePath = FPaths::ConvertRelativePathToFull(FPaths::GameDir() + "Plugins/BLUI/ThirdParty/cef/");
		// Make the CefSettings and CefMainArgs local as they only need to be used in this function
		CefSettings settings;
		CefMainArgs main_args;

		// Setup the default settings for BluManager
		settings.windowless_rendering_enabled = true;
		settings.no_sandbox = true;
		settings.remote_debugging_port = 7777;

	#if PLATFORM_LINUX
		ExecutablePath = "./blu_ue4_process";
	#endif
	#if PLATFORM_MAC
		ExecutablePath += "Mac/shipping/blu_ue4_process.app/Contents/MacOS/blu_ue4_process";
	#endif
	#if PLATFORM_WINDOWS
		ExecutablePath += "Win/shipping/blu_ue4_process.exe";
	#endif

		CefString realExePath = *ExecutablePath;

		// Set the sub-process path
		CefString(&settings.browser_subprocess_path).FromString(realExePath);

		// Set the cache path
		CefString(&settings.cache_path).FromString(GameDirCef);

		// Make a new manager instance
		CefRefPtr<BluManager> BluApp = new BluManager();

		//CefExecuteProcess(BluManager::main_args, BluApp, NULL);
		CefInitialize(main_args, settings, BluApp, NULL);

		UE_LOG(LogBlu, Log, TEXT(" STATUS: Loaded"));
	}

The only real change is that the settings and main_args variables and now declared in this function, as opposed to statically outside of it.  Getting rid of the originals in BluManager.h and using these instead should work.  I can't remember if there were other changes I needed to make (I don't think so) - but let me know if it's not working.

Hi David, thanks so much for that - I only had to comment out a couple of references to those static variables at the bottom of BluManager.cpp
I can't tell you how much I appreciate the help with that!  The reference in the code to the remote debugging port is interesting - have you used it?  I've tried going to localhost:7777 in my chrome browser but it doesn't seem to connect.
Cheers!

Thanks a lot for the work to keep alive blui, I think this plugin deserves
an epic grant.
2017-02-26 20:56 GMT+01:00 Dannington<EMAIL_ADDRESS>
Hi David, thanks so much for that - I only had to comment out a couple of
references to those static variables at the bottom of BluManager.cpp
I can't tell you how much I appreciate the help with that! The reference
in the code to the remote debugging port is interesting - have you used it?
I've tried going to localhost:7777 in my chrome browser but it doesn't seem
to connect.
Cheers!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AaronShea/BLUI/issues/89#issuecomment-282582195, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFSPonEkHMpp_bzS_y5-7qB0hqbkB4-gks5rgdjhgaJpZM4KsyWH
.

So relieving to get this workaround (if that is what it is), good job there! I have kind of suspected that there is a clash between UE4 using port 7777 and CEF using the same port for debugging, but I'm just guessing.
But when changing the settings.remote_debugging_port = 7777 to another port the remote debugger seems to be working fine, so perhaps that is for the same reason?


Create one correlationId across a flow

When the request is not initialized with a correlationId, this PR ensures that the msal js generates only one correlationId across the flow and the perf events around the flow.

Codecov Report

Merging #6650 (7d49ff6) into dev (81d34b4) will decrease coverage by 4.20%.
Report is 374 commits behind head on dev.
The diff coverage is n/a.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.73% <ø> (+0.22%)
:arrow_up:
Carriedforward from 8628444

msal-browser
79.04% <ø> (-7.43%)
:arrow_down:
Carriedforward from 8628444

msal-common
?

msal-core
?

msal-node
?

msal-node-extensions
?

msal-react
94.24% <ø> (-0.45%)
:arrow_down:

node-token-validation
?

*This pull request uses carry forward flags. Click here to find out more.

Files
Coverage Δ

lib/msal-angular/src/constants.ts
100.00% <ø> (ø)

lib/msal-angular/src/msal.broadcast.service.ts
100.00% <ø> (ø)

lib/msal-angular/src/msal.guard.ts
90.78% <ø> (+0.64%)
:arrow_up:

lib/msal-angular/src/msal.interceptor.ts
100.00% <ø> (ø)

lib/msal-angular/src/msal.module.ts
100.00% <ø> (ø)

lib/msal-angular/src/msal.navigation.client.ts
93.33% <ø> (+0.47%)
:arrow_up:

lib/msal-angular/src/msal.redirect.component.ts
100.00% <ø> (ø)

lib/msal-angular/src/msal.service.ts
100.00% <ø> (ø)

lib/msal-angular/src/packageMetadata.ts
100.00% <ø> (ø)

...b/msal-browser/src/app/IPublicClientApplication.ts
41.17% <ø> (-2.58%)
:arrow_down:

... and 50 more

... and 184 files with indirect coverage changes


performance support parallel memtable flush for unique key tables

Proposed changes
Assign a segment_id to MemTable early before submit flush task, and exec the flush tasks in parallel.
In this way, we can improve the stream load peformance of 1 tablet unique key tables by around 100%.


No improvement of model after 5 epochs

Trained using:

2 GPUS
batch size=2
number audio/video files=50k
epochs=5

I infer on a video that the model has not seen.
The output contains 2 audio files that sound very similar to each other. I cannot distinguish voices between each audio file.
Has anyone got a working model that seems to be doing better than mine?

Hi @nanometer34688 , Have you resolve the problem you reported? if yes, could you share me what you have done, thanks a lot


Fix CVE-2022-27204 / SECURITY-1350

https://www.jenkins.io/security/advisory/2022-03-15/#SECURITY-1350
Implement suggestion from https://www.jenkins.io/doc/developer/security/form-validation/

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira: SECURITY-1350
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fix CVE from title by applying suggestions from https://www.jenkins.io/doc/developer/security/form-validation/.

Locally, GET does not work anymore:
C:\Users\A613952>curl.exe -v -u admin:<snip> "http://localhost:8080/job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile?propertyFile=https%3A%2F%2Fssrf.example.com"
*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
* Server auth using Basic with user 'admin'
> GET /job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile?propertyFile=https%3A%2F%2Fssrf.example.com HTTP/1.1
> Host: localhost:8080
> Authorization: Basic <snip>
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< X-Content-Type-Options: nosniff
< Cache-Control: must-revalidate,no-cache,no-store
< Content-Type: text/html;charset=iso-8859-1
< Content-Length: 576
< Server: Jetty(9.4.43.v20210629)
<

<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 404 Not Found</title>

HTTP ERROR 404 Not Found

URI:	/job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile

STATUS:	404

MESSAGE:	Not Found

SERVLET:	Stapler

Powered by Jetty:// 9.4.43.v20210629

* Connection #0 to host localhost left intact

And POST is CSRF protected:
C:\Users\A613952>curl.exe -X POST -v -u admin:<snip> "http://localhost:8080/job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile?propertyFile=https%3A%2F%2Fssrf.example.com"
*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
* Server auth using Basic with user 'admin'
> POST /job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile?propertyFile=https%3A%2F%2Fssrf.example.com HTTP/1.1
> Host: localhost:8080
> Authorization: Basic <snip>
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 403 Forbidden
< X-Content-Type-Options: nosniff
< Cache-Control: must-revalidate,no-cache,no-store
< Content-Type: text/html;charset=iso-8859-1
< Content-Length: 675
< Server: Jetty(9.4.43.v20210629)
<

<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 403 No valid crumb was included in the request</title>

HTTP ERROR 403 No valid crumb was included in the request

URI:	/job/test/descriptorByName/com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition/checkPropertyFile

STATUS:	403

MESSAGE:	No valid crumb was included in the request

SERVLET:	Stapler

Powered by Jetty:// 9.4.43.v20210629

* Connection #0 to host localhost left intact

@vimil Hi! What do you think about this pr?

@vimil any progress here, it would be great if this fix is merged

Pinging more members who could have write access
@Vlatombe @oleg-nenashev @cjo9900 @olivergondza @mat1e

Pretty please? What can we do to move this along?

+1

Note: You can download my fixed version from CI:
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fextended-choice-parameter-plugin/detail/PR-39/1/artifacts
https://ci.jenkins.io/job/Plugins/job/extended-choice-parameter-plugin/job/PR-39/1/artifact/org/jenkins-ci/plugins/extended-choice-parameter/347.va_2f0c3b_f1849/extended-choice-parameter-347.va_2f0c3b_f1849.hpi

@ciis0 Hi, I am using your fixed version and the warning keeps to pop up.  So, I would like to know when you can merge the new version? Does we need waiting more time? It is important because, I am using it in some workflows....

Hi @seam33,
ciis0 does not have the permission to merge the PR, that needs to be done by an official Jenkins maintainer, but we could not get the attention of one yet.
As such we'll need more patience.

This fix looks incomplete, it only addresses the CSRF issue, not the missing permission checks.
Regarding getting a new release with security issues being fixed when maintainers are unresponsive, see https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

For CVE-2022-27204 the fix is complete (perm check is 05), only for SECURITY-1350 it is incomplete.
I consider the CSRF more severe and easy to fix, while the perm check is not as severe and not as easy to fix.
I will have a look at adopting the plugin.

For https://github.com/advisories/GHSA-fqpx-xfjr-2qr9 the fix is complete (perm check is 05)

Good point. We'd still leave the security warning up even if this is addressed, because there's only one advisory entry and warning for both CVEs.

… more severe … not as severe …

Depends on your setup, if you were an admin of ci.jenkins.io you'd see this differently :)


add typings key

Assists with module resolution.
See here for example: https://github.com/bradmartin/nativescript-cardview/blob/master/package.json#L6

Added some new ignores to npm file to reduce module dl weight


Why isn't .HasMaxLength(X) being generated for nvarchar(X) in my model?

Description
I'm getting a runtime error because of the model/scaffold/context (not sure which term is correct here) that's being generated. I haven't gotten out of the sandbox yet. I'm trying to build a DB-first model from SQL Server 2012 database.
If the length of a field is specified in the db table, and a max length is required to avoid runtime errors, then why doesn't EF Core include .HasMaxLength(X) in the generated model? Having to go back to the context--or anywhere--and manually add lines of code defeats the purpose of generated code. Is there a DataAnnotation, other switch, or a configuration I can use? Is "max" instead of "4000" getting in the way? (the table script below was generated by SQL Server.)
###Exception message:
System.ArgumentException: 'Data type 'nvarchar' is not supported in this form. Either specify the length explicitly in the type name, for example as 'nvarchar(16)', or remove the data type and use APIs such as HasMaxLength to allow EF choose the data type.'
Stack trace:
 	[External Code]		Annotated Frame
>	ConsoleApp_EFCore.dll!ConsoleApp_EFCore.MainProgram.Main(string[] args) Line 16	C#	Symbols loaded.

Steps to reproduce
I started with a database that includes this table:
CREATE TABLE [reference].[ActionTaken](
[unqID] [uniqueidentifier] ROWGUIDCOL  NOT NULL,
[txtCode] nvarchar NULL,
[txtName] nvarchar NULL,
[txtDescription] nvarchar NULL,
[intMask] [int] NULL,
[bolActive] [bit] NOT NULL,
[datCreated] [datetime] NULL,
[datModified] [datetime] NULL,
[txtSignatureModifiedBy] nvarchar NULL,
[txtSignatureCreatedBy] nvarchar NULL,
[rwvVersion] [timestamp] NOT NULL,
CONSTRAINT [PK_ActionTaken_unqID] PRIMARY KEY CLUSTERED ([unqID] ASC)
WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]
GO
ALTER TABLE [reference].[ActionTaken] ADD  CONSTRAINT [DF_ActionTaken_unqID]  DEFAULT (newsequentialid()) FOR [unqID]
GO
ALTER TABLE [reference].[ActionTaken] ADD  CONSTRAINT [DF_ActionTaken_bolActive]  DEFAULT ((0)) FOR [bolActive]
GO
In the Package Manager Console, I ran:
PM> Scaffold-DbContext "data source=[my server name]\SQLSERVER2012;initial catalog=[my database name];persist security info=True;user id=sa;password=[the password];MultipleActiveResultSets=True;" Microsoft.EntityFrameworkCore.SqlServer -OutputDir Models
...which created my class.cs and [db]Context.cs files in ConsoleApp_EFCore\Models folder.
In dbContext.OnModelCreating(), the following was created:
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
modelBuilder.Entity(entity =>
{
entity.HasKey(e => e.UnqId);
            entity.ToTable("ActionTaken", "reference");

            entity.Property(e => e.UnqId)
                .HasColumnName("unqID")
                .HasDefaultValueSql("(newsequentialid())");

            entity.Property(e => e.BolActive)
                .HasColumnName("bolActive")
                .HasDefaultValueSql("((0))");

            entity.Property(e => e.DatCreated)
                .HasColumnName("datCreated")
                .HasColumnType("datetime");

            entity.Property(e => e.DatModified)
                .HasColumnName("datModified")
                .HasColumnType("datetime");

            entity.Property(e => e.IntMask).HasColumnName("intMask");

            entity.Property(e => e.RwvVersion)
                .IsRequired()
                .HasColumnName("rwvVersion")
                .IsRowVersion();

            entity.Property(e => e.TxtCode)
                .HasColumnName("txtCode")
                .HasMaxLength(50);

            entity.Property(e => e.TxtDescription).HasColumnName("txtDescription");

            entity.Property(e => e.TxtName)
                .HasColumnName("txtName")
                .HasMaxLength(100);

            entity.Property(e => e.TxtSignatureCreatedBy)
                .HasColumnName("txtSignatureCreatedBy")
                .HasMaxLength(256);

            entity.Property(e => e.TxtSignatureModifiedBy)
                .HasColumnName("txtSignatureModifiedBy")
                .HasMaxLength(256);
        });
    //...
    }

The runtime error occurs in the following C# code:
namespace ConsoleApp_EFCore
{
class MainProgram
{
static void Main(string[] args)
{
Console.WriteLine("Hello World!");
        using (dbContext mycontext = new dbContext())
        {
            var v = mycontext.ActionTaken.ToList(); // <--ERROR HERE
            foreach (ActionTaken a in v)
            { Console.WriteLine("name='" + a.TxtName + "'; desc = '" + a.TxtDescription + "'; code = '" + a.TxtCode + "';"); }
        }
    }
}

}
Further technical details
EF Core version: 2.0
Database Provider: (e.g. Microsoft.EntityFrameworkCore.SqlServer)
Operating system: Windows 8
IDE: VS2017

duplicate of #9188

I see I'm wrong about the .HasMaxLength not being generated--it's there. I don't why I'm getting the error then, and I don't know the best place to ask about it.

@averyoo7 - Just change nvarchar to nvarchar(4000) and it will start working.

Hi @averyoo7. We are gathering information on the use of EF Core pre-release builds. You reported this issue shortly after the release of 2.0.0 RTM. It would be really helpful if you could let us know:

Did you consider testing your code against the pre-release builds?
Was there anything blocking you from using pre-release builds?
What do you think could make it easier for you to use pre-release builds in the future?

Thanks in advance for any feedback. Hopefully this will help us to increase the value of pre-release builds going forward.


Vue MDC Doesn't support Select values of non-string type

I have an  component I am trying to use that I want to bind using non-string values, but it seems the mdc-select component only allows String values:
<mdc-select v-bind:model="currentLocation" label="Location">
       	<mdc-option v-for="location in locations" :key="location.id" v-bind:value="location">@{{ location.name }}</mdc-option>
</mdc-select>

@coogle
yes, as of today, value must be a string because it may be stored in a real html value attribute <option value="">.
I guess I could change that by with some value map, but that's complex. Need to think about it ...
In the mean time, could you set value to the key or index so the v-model would return the id and allow to retrieve the location?  would that work for you ?

Unfortunately I can't get a default value to work at all... I have as data:
		currentLocationId : {{ $locations[0]['id'] }},
		currentLocation : @json($locations[0]),
		locations : @json($locations),

(where 'id' is an integer)
The goal is to have the select default to the "current" location object, then update the currentLocation data value any time a new one is selected and I can't get it to work at all. locations is an array of location objects with an integer key id.

Can you send me a json dump of your locations object. I'll have a look ...

[{"id":1,"portal_id":"internal","name":"Office One","address_1":"22731 Kirsten Drives","address_2":"Suite 874","city":"West Jerrold","state":"KS","zipcode":"09672-5406","phone_number":"14353463554","fax_number":"3475021169","notes":"Voluptate nulla est nihil ea. Dolorem tempora et vitae dolorum voluptatem vel. A officia pariatur aut saepe consequatur.","created_at":"2017-12-13 08:12:16 UTC","updated_at":"2017-12-13 08:12:16 UTC","deleted_at":null,"pretty_phone_number":"+1<PHONE_NUMBER>","pretty_fax_number":"+1<PHONE_NUMBER>","hours":[{"day_of_week":"mon","opens_at":{"date":"2018-02-21 06:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 18:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"tue","opens_at":{"date":"2018-02-21 05:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 18:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"wed","opens_at":{"date":"2018-02-21 09:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 18:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"thu","opens_at":{"date":"2018-02-21 08:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 17:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"fri","opens_at":{"date":"2018-02-21 09:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 17:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"sat","opens_at":{"date":"2018-02-21 06:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 18:00:00.000000","timezone_type":3,"timezone":"UTC"}},{"day_of_week":"sun","opens_at":{"date":"2018-02-21 06:00:00.000000","timezone_type":3,"timezone":"UTC"},"closes_at":{"date":"2018-02-21 18:00:00.000000","timezone_type":3,"timezone":"UTC"}}]}]

for now, what about this: compute a location map using id as key
<template>
  <mdc-select
    :model="currentId"
    label="Location">
    <mdc-option
      v-for="location in locations"
      :key="location.id"
      :value="location.id"
    >@{{ location.name }}</mdc-option>
  </mdc-select>
</template>

<script>
export default {
  data() {
    return {
      locations: [],
      currentId: undefined
    };
  },
  computed: {
    locationMap() {
      return this.locationMap.reduce((map, location) => {
        return (map[location.id] = location);
      }, {});
    },
    curentValue() {
      return this.currentId ? this.locationMap[this.currentId] : {};
    }
  }
};
</script>

didn't test it, but think it should work. perf should be ok provided the locations do not change too often and table is not too big.

I thinking the only issue with removing the String constraints on value is if you render a native select (ios or android case), it does not play well with <option> attribute. but if you do not care about native rendering, I could remove the constraint... I'll see what i can do ...

I have the same problem at the moment.
id is a number but option value needs to be string.
is it possible to set
value: [String, Number] on mdc-options prop?

Found a Hack to get [Number, String, Object]
we'll release it soon ...

Unfortunately the hack is not working. it's buggy, had to revert :(

Bummer! I'm still in need of this for sure -- our entire project uses integer-based keys and having to mess around just trying to get something simple like this working is a major negative! For now I'm going to try to move on to another thing and hope you can find a fix to make this work for real soon!

something simple like this

not simple to find a valid implementation... I'll try to figure out something...
waiting for that you can always wrap the select

I could use WeakMap to track the value but need a polyfill for IE11

outdated


wrap option handling in a function

I considered using Val but it doesn't really work since it's also
required to invoke the fuction with Val{value}, instead of just
passing value (unless I misunderstood how this works).
So I essentially factored out the logic to a regular function, and
wrote tests to cover all behaviours.
Thoughts?

Looks like I misunderstood how to use Val :-p


Buffer scrolling commands do not extend visual selection

shift + v
ctrl + f/b/d/u (scrolls in vscode but not in nvim buffer)
j (cursor jumps back to the initial position)

vscode-neovim.mouseSelectionStartVisualMode has no effect.

dupe #293


Interactive window- don't leave space for insert toolbar

Interactive window is more compact than Notebook now, by not leaving space for the insert cell toolbar(which has no items anyway in the interactive window)
However, you need to apply
    "notebook.cellToolbarLocation": {
        "default": "hidden" // non default setting
    },

to see this. With the default setting, the space is reserved anyway for the notebook cell toolbar.
Note, readonly notebooks (other than interactive window) are still leaving space for the insert cell toolbar even though it has no items.

I have rebased to #181949


Nullable annotations for Markup.Xaml

Adds nullable annotations for Avalonia.Markup.Xaml.
Notes:

Extensions.ResolveType now throws. It's used as the Binding.TypeResolver, and existing usages either didn't expect null to be returned (potential NRE), or explicitly threw on null return.
Extensions.GetService usages sometimes assumed that the returned service was registered, without checking for null. A GetRequiredService has been added to handle this case.
ITemplate.Build could return null: there's even a test that checks that <DataTemplate /> produces a null content. A similar test has been added for ControlTemplate.

The commit was already ready when I noticed the request to pause community contributions. Imho getting nullability right (especially for public members) is important, but I completely understand if you prefer to close this PR for now :)

You can test this PR using the following package version. 11.0.999-cibuild0031758-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0032075-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0032254-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Easing function:  linearEaseInOut

When working with longer animations (60s and above), default easing functions tend to result in a very slow start, very fast speeds in the middle and again a very slow stop. The easing function linearEaseInOut results in a steady zoom speed, while also easing in and easing out.

Good observation and idea to add a more delicate easing function, but I find the proposed one to be a bit difficult to describe adequately and not that natural. I think the better idea is to have a general family of power-based, easing functions. I've added it in 5c6dd310c90ca0c358764f5565879d13ef63ec11. By using -e easeIn/Out/InOutPow --easing-power X with values X between 1 (gives linear easing) and 2 (gives quad easing), one can get more delicate easing. What do you think? Does it solves the problem or do you think that it's a good idea to also include yours?

I think the addition of a custom power easing function is definitely a good idea and add some nice flexibility. The default easing function (and other power-based ones) will still result in the nicest effect for shorter animations (and thus the most use-cases)
But, i don't believe it would achieve the effect I was going for. I'd like a long (e.g. 100s) zoom animation with a linear speed, but still accelerate in the beginning (from speed 0 to a constant speed) and decelerate at the end. You can see the effect here: https://www.instagram.com/p/Cu1CNOzt8QN/
The problem with the power-based easing is that it will either:

result in a very slow speed in the beginning for a long time -  e.g. ^1.5
result in a abrupt start (no noticeable easing) - e.g. ^1.1

More visually: https://www.desmos.com/calculator/mdat9lpd9u, when looking at the range [0 - 0.01].

(green is the power-based easing, red (ease in) + blue (linear) is the effect I am going for)
So, I do think there is a reason for the linearEaseInOut, but I also agree that it is a bit clumsy in the readme, a confusting name and hard to describe / explain.

Ok, you are right that, for very long animations, power-based easing might not give you such a smooth start. Let's merge it, but could you first adjust it to the design that it's used in the main branch now?
Not sure about it, but maybe it would be better to name it linearWithInOutEase or in a similar fashion?
I will write a short note on easing functions later.

linearWithInOutEase is a lot clearer!
I'm about to leave on Holidays. I will pick this up when we're back in a few weeks...

Ok, then I will do it this weekend and merge it :) Enjoy your holidays/vacations!

Done. Thank you for the PR and idea @sambernaerdt!

Super! Thanks a lot!!


Make outputs modified outside of the build system considered dirty

This pull request is a fix for #1946.
Today if an output of the build is modified from outside of the build system (manually or by another process) ninja will not consider it to be dirty.
I think if an output state is different from the state it would have if the rule command was executed again, then it should be considered dirty.
Situation where it is a problem:

You have an action registered as order-only dependency which generate some C++ header.
You include one of generated file for the time to one of your .cpp, so ninja does not consider it yet as implicit dependency.
You open the generated file with your favorite text editor, and by mistyping on your keyboard you modify the generated header to an invalid C++ state.
As consequence, ninja will not try to re-generate the header, because it is not yet a dependency of the build, and ninja will fail the build because the header is not valid C++.

My modification considered an output is dirty if its mtime is more recent than the one in the build log. The mtime of the output can be older than the one on the build log in the case its build edge is mark with 'restat = 1'. In that case if the rule command did not modified the output, its build log entry will inherit the mtime of its most recent inputs or depfile.

I have updated the commit to fix the test, improve comments and commit description.

This becomes annoying when the output is newer, because you actually reran the edge's command outside of ninja. Or let's say you don't mistype on your keyboard, but want to test something quick and dirty.

@jhasse I understand the situation you are pointing out.
I think both situations are valid:

You may not want to re-run some edges because you consciously override their output. Example: you modified some outputs for quick and dirty test
After running ninja you want the build output state to match the state the would have if their edge has be executed. Example: after your quick and dirty test, you want to revert the build to its correct state without having to rebuild everything from scratch.

We could use a command line option to select between the two behavior. Let me implement that...

I have updated my implementation to add a '-m' option which enabled the behavior of ninja considering modified output as dirty.


Nested input field caret gets stuck and can't be repositioned

Describe the bug
If you have a nested input element inside a draggable element, your cursor gets to the first or last character on focus, and can't be repositioned.
Reproduction
firefox (tested on versions 60.0.2 and 73.0 both win10/linux mint )
Steps to reproduce the behavior:
https://react-dnd.github.io/react-dnd/examples/sortable/simple
you can change Card components text render and you can already get the stucked focus
Code
<div ref={ref} style={{ ...style, opacity }}>
      <input defaultValue={text}/>
</div>

Expected behavior
Cursor shouldn't be stucked.
Works on chrome and new chromium based edge (doesnt work on old Edge either)
Desktop:
firefox (tested on versions 60.0.2 and 73.0 both win10/linux mint )

Have you managed to solve it?

sadly no :(
my only luck was, that it was "only" the pilot of the project so we told that chrome and edge are the supported browsers while they tested the webapp.
But it's something that i should solve in the future :'(

I can reproduce the problem, the following hack fix works for me:
https://github.com/react-dnd/react-dnd/issues/178#issuecomment-611974376

I can reproduce the problem, the following hack fix works for me:
https://github.com/react-dnd/react-dnd/issues/178#issuecomment-611974376


Add brotli support to grunt-contrib-compress using MayhemYDG/iltorb.

This pull request closes #176.

So, it seems the are build failures. Any idea how to fix those?

Just check the CI files in the upstream projects. I remember I had
submitted some fixes for AppVeyor. And then you will need to skip
overwriting the files in the project.
On Oct 12, 2016 19:59, "Dirk Weigenand"<EMAIL_ADDRESS>wrote:

@weigo commented on this pull request.
In tasks/lib/compress.js
https://github.com/gruntjs/grunt-contrib-compress/pull/187:

@@ -54,6 +55,12 @@ module.exports = function(grunt) {
+ grunt.util.pluralize(files.length, 'file/files.'));
};

exports.brotli = function(files, done) {

 exports.singleFile(files, iltorb.compressStream, 'br', done);

 grunt.log.ok('Compressed ' + chalk.cyan(files.length) + ' '

     + grunt.util.pluralize(files.length, 'file/files.'));

The build failures are due to C++ compiler support missing in the build
infrastructure.
iltorb is a wrapper around the native brotli library.
I can build that support just fine on Debian (stretch/sid).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gruntjs/grunt-contrib-compress/pull/187, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAVVtTOXofkvtyVuTSXUkfuqYdYwyx7bks5qzRINgaJpZM4KUJbG
.

https://github.com/MayhemYDG/iltorb/blob/master/.travis.yml
https://github.com/MayhemYDG/iltorb/blob/master/appveyor.yml

This would mean removing .travis.yml from grunt-contrib-compress and use the upstream one from iltorb.

iltorb .travis.yml doesn't have the

sudo and
cache
directives. What is your advice wrt. those?

Nope, just adapt our files. Also please allow contributors pushing to your
PR so I can have a try later.
On Oct 12, 2016 22:55, "Dirk Weigenand"<EMAIL_ADDRESS>wrote:

This would mean removing .travis.yml from grunt-contrib-compress and use
the upstream one from iltorb.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gruntjs/grunt-contrib-compress/pull/187#issuecomment-253320349,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtWNW6hNoNgtLqC2NxdC2FBbad8B_ks5qzTtPgaJpZM4KUJbG
.

 I added you to the contributors list.

It seems that on node 0.10.0 iltorb can be built, but not on 0.12.0.
This is consistent with https://github.com/MayhemYDG/iltorb/issues/17.
The Problem is with win_dely_load_hook.c in %NODE_INST_FOLDER%\node_modules\npm\node_modules\node-gyp\src where NODE_INST_FOLDER is the path to your NodeJS installation on Windows.
On line 43 a variable is declared and initialized:
PfnDliHook __pfnDliNotifyHook2 = load_exe_hook;
This variable is also declared (const) in <delayimp.h> when the macro DELAYIMP_INSECURE_WRITABLE_HOOKS is undefined. This has been introduced in Visual Studio 2015 Update 3.
Adding #define DELAYIMP_INSECURE_WRITABLE_HOOKS prior to #include <delayimp.h> makes the compile error vanish.

The __pfnDliNotifyHook2 error is an issue with node-gyp: https://github.com/nodejs/node-gyp/issues/972
Try updating npm in appveyor before building, somehow.

@weigo: I think the PR is almost done. Only the Windows issue is left.
@MayhemYDG: this PR installs npm @3.0 for node.js 0.10. You mean we need to do the same for 0.12 too?

@weigo: can you try this in appveyor.yml:
if ($env:nodejs_version -lt "4") {

The __pfnDliNotifyHook2 issue got fixed in node-gyp 3.4.0 which is bundled in npm 3.10.5 at least.
I don't know which previous versions of npm/node-gyp have this particular bug or not.
So, uh, npm i -g npm!

@MayhemYDG: yeah, so my suggestion should fix this. If not we can tweak it more.

All right, I pushed the changes myself to your fork. I'm gonna wait until AppVeyor updates to the latest node versions (see https://github.com/appveyor/ci/issues/1075) to see if we really need to upgrade npm. Then I'll merge the PR.

Hmm, ok so it seems AppVeyor is using the latest node versions. Also, it seems we need to update npm for all versions except for v4.

If we require npm@3, perhaps we should set it explicitly in package.json. Thoughts?

Thanks for your review and fixes!
Wrt. indentation and operator placement i'd like to suggest to add those rules to jshint. This way a contributor can spot problems more easily.
Thanks for the suggestions wrt. to markdown syntax! Didn't know those.
And thanks to @MayhemYDG and the grunt-contrib-compress team to provider the shoulders to stand on (giants and all that ;-)!
I hope the pull request can be merged and released soon.

Wrt. to npm@3: I just used nodejs 6.8 on Windows 10 to build a fresh checkout of grunt-contrib-compress with brotli support. The install went without a hitch.
So we should probably require<EMAIL_ADDRESS>The npm version bundled with nodejs 6.7 exhibited the same problem as did the build machines of AppVeyor (this was a fresh install i did yesterday to verify the build problems on Windows 10 using Visual C++ build tools 2015.3).
This change will probably break quite a lot of builds?

@weigo: I kept only the LTS versions and v7 and everything seems to work.
Now, before merging this I want to know what is our plan for the minimum supported node.js version, because this PR requires >=4.

It seems there are some deprecation issues with node.js 7. They must come from archiver.

That's ok with me.

What is the required process of signing the CLA? I did sign it already but here it shows as unsigned nonetheless.

The grunt test target passes without problems on Windows 10 using NodeJS 7.3. I added versions 7.0 -- 7.3 to appveyor.xml.

Not needed. Just 7 is enough.
I'll have a look at this in the next days
On Dec 26, 2016 00:05, "Dirk Weigenand"<EMAIL_ADDRESS>wrote:

The grunt test target passes without problems on Windows 10 using NodeJS
7.3. I added versions 7.0 -- 7.3 to appveyor.xml.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gruntjs/grunt-contrib-compress/pull/187#issuecomment-269139124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtcfjGQppXMqUGqXvuFO7UPy7GgpOks5rLuikgaJpZM4KUJbG
.

Ok. Reverted to 7 only and re-triggered build. Now the CLA is the only obstacle ;-)
Merry Christmas!


(try to) fix flaky integration test

It seems that marathon.updateApp(...) on CI is a little bit too slow to be captured by marathon.listDeploymentsForBaseGroup(), therefore the flaky test should wait until the related event should be published.

retest this please

retest this please

retest this please

retest this please

retest this please