Extensions suddenly take several seconds to open AND opens two tabs when middle clicking.

OS version: Windows 10 64-bit
Chrome version:  55.0.2883.75 m (64-bit)
I've been using this extension for months.  It's awesome.
But today, all of a sudden, it's started messing up.
First of all, when I click to open it, it takes several seconds to open. This has never happened before, it's always been instant. Strange.
Secondly, now when I middle-click a bookmark to open in a new background tab, it opens TWO TABS. This is crazy, I have NO idea why this would happen all of a sudden.
There was a new Chrome update last night, but I swear the extension was working fine after the update. I'm also sure I used the extension earlier today and it was working fine. But now as of about an hour ago when I got home and woke my PC back up, these two errors have started happening.
If it wasn't caused by the Chrome update and it wasn't caused by the extension updating (it hasn't been updated in 2 years*) then I have NO idea what the hell could have possibly caused this. Is anybody else experiencing this behavior??
Please let me know guys. Thanks

Is it safe to say this project is completely abandoned by the developer now? Any word @evanshultz ?? I really hope this extension didn't just break, never to be fixed again. This is one of my most used and absolutely necessary extensions and I can't find anything else like it...

i have the same issue with the double tabs. didn't knew the dev abandoned the project, what a waste.

First, while I haven't updated the extension in quite some time I wouldn't consider it abandoned. There are a number of updates which I plan to do but won't be able to work on for a couple months yet. Notice how your speculation has turned into fact above.
Taking a long time to open must be a Chrome or PC issue. I don't see it on Win 10 on a few PCs I have on hand. Providing more info, like other extensions doing it, have you restarted Chrome or the PC, does it happen on multiple PCs, etc., would be the best way to troubleshoot.
With regards to multiple tabs, this is a Chrome issue. Google has broken this and then fixed it a couple times in the past, so my advice right now is to hold on and forgive Google for this issue. I can't say if this "bug" will be reverted, but if not I'll find a way to fix it once I get back to working on this extension. For what it's worth, this is still happening on Version 56.0.2924.3 dev (64-bit).

Hi there, just to add to this issue, the extension button only began acting sluggishly on updating from chrome 54 to 55, reverting to 54 fixes the issue, so something in the upgrade to 55 has changed something. I have done the usual stuff, reinstalling the extension, chrome, restarting the PC, all nada, the one and only thing that appears to cause the issue is chrome 55 itself, all other extensions have their usual behaviours, only NB has started acting delayed on button press to bring up the bookmarks list.
Just for clarity, system specs:
Windows 10 Home 64-bit
GTX 980 GPU
Intel i7 3770K @ 3.6Ghz
16GB RAM
Intel 520 240GB SSD

First, while I haven't updated the extension in quite some time I wouldn't consider it abandoned. There are a number of updates which I plan to do but won't be able to work on for a couple months yet. Notice how your speculation has turned into fact above.

I'm sorry @evanshultz I really didn't mean to imply that it was in fact abandoned. I was just guessing based on the fact that the extension hadn't been updated in a while (not that it needed to be) and the fact that I didn't see any recent comments from you on this Github. I'm really glad to hear that you're still around! Even more excited to hear that there are updates down the road! =D

Taking a long time to open must be a Chrome or PC issue. I don't see it on Win 10 on a few PCs I have on hand. Providing more info, like other extensions doing it, have you restarted Chrome or the PC, does it happen on multiple PCs, etc., would be the best way to troubleshoot.

Yes, I realize now that this is happening for everybody on Chrome 55 and it happens on every extension icon, not just Neater Bookmarks. Kind of a bummer, but not related to this extension. And also not the biggest deal. The double-tab opening is the biggest issue for me, personally.

With regards to multiple tabs, this is a Chrome issue. Google has broken this and then fixed it a couple times in the past, so my advice right now is to hold on and forgive Google for this issue. I can't say if this "bug" will be reverted, but if not I'll find a way to fix it once I get back to working on this extension. For what it's worth, this is still happening on Version 56.0.2924.14 dev (64-bit).

Darn, that's a bummer. I'm not sure how easy this would be for you, but do you think it would be feasible to offer a quick fix? I think an easy way to fix this feature would be to offer a new variation of two of the current settings in the extension.
Left-clicking opens a bookmark in a new tab, which is great, but if you offered a setting that would allow left-clicked bookmarks to open in a background tab, instead of foreground, I think that would be a pretty good fix. That would enable the same function as middle-clicking but it wouldn't need to involve the middle-click button at all. As it stands now, when I left-click a bookmark it opens in a new foreground tab, moving you away from the tab you were in before. The "Popup stays open when opening (left-clicking) bookmarks" setting doesn't seem to work any more.
Do you think this would be possible to do in the meantime until Google fixes the issue or until you get back to working on the extension?
I'm just so persistent because like I said, I use this extension constantly.
I just thought I'd offer the idea of allowing middle-clicks to open in background tabs.
Thanks again, a TON, for making this great extension and also for responding here to let us know that you're still around and this extension isn't abandoned!

Thanks for the awesome extension and the plans ahead, @evanshultz! :)

I am not chrome-ext dev but this issue was irritating me enough to get my hands dirty. I have found in Opera changelog interesting thing:

As mentioned above, the click event is no longer fired for non-primary mouse buttons. In most cases this is desirable; click event handlers are most often intended to handle primary clicks. But if you need to handle non-primary clicks (e.g., middle mouse button), the auxclick event can be used. The contextmenu event can also be used to handle clicks that would open a context menu (typically right-click).

And that lead me to: https://developers.google.com/web/updates/2016/10/auxclick
Thanks to that info, I was able to prepare a patch. Nevertheless, I have not tested it with any other browser than Opera 42! https://github.com/r2r2r2o/neater-bookmarks/commit/e8f5f5439b12ecac13976aeb48890a126ddaa6b1
Can anybody test it (especially, with the older version of chrome/opera)? Should I make pull request?

我也有使用鼠标中键后台打开时，同时打开两个相同的标签页。希望开发者能够解决，在此感谢您的付出。

@r2r2r2o i would love to, but i don't have any idea how to apply it.

@vespertinee, Here is info you are looking for:
https://blog.hunter.io/install-chrome-extension-manually/
You can download fixed code from;
https://github.com/r2r2r2o/neater-bookmarks/archive/master.zip

@r2r2r2o it works great, thanks so much! using the version 55 of chrome in win10

@r2r2r2o 谢谢你，很棒

@r2r2r2o Thanks a lot for the fix.

This is so infuriating. Having the fix above but Chrome won't let me use it without annoying popups everytime Chrome loads warning me about developer mode or out right disabling the extension every time.

@evanshultz it's been a year, Chrome hasn't fixed it. Any chance you can implement the fix from @r2r2r2o?

I replaced it with https://chrome.google.com/webstore/detail/popup-my-bookmarks/mppflflkbbafeopeoeigkbbdjdbeifni

Coming up on 2 years since Vismund-Cygnus commented on Dec 2, 2016.
Nudge nudge.
Confirming middle click currently creates two tabs.
Slimjet on Linux:
"Slimjet
Version <IP_ADDRESS> (based on Chromium 66.0.3359.117) (Official Build) (64-bit)"


Update our state upon broadcasting a transaction

Fixes https://github.com/wizardsardine/liana/issues/887.
This takes a couple commits from #909 but takes the approach from there in another direction: we don't externalize the poller, since only a single instance must be ran. Instead we properly keep track of the (up to) two threads we manage in the DaemonHandle and provide a way for a user of the library to check for errors in any of the threads.
This approach allows us to 1) communicate with the poller thread from inside the Liana library/daemon (here we leverage this to tell it to poll) 2) eventually (#909) expose all internal errors from the library to the user instead of panic'ing internally.
See the commit messages for details.

ACK 58c71c794a050a2df460aec241c90efe89cf9ae0 -- did another pass and Edouard tested this in the GUI.


Upload compressed disks

Workflow is:

compile product
create OS disk VHD
upload VHD to azure
possibly expand drive size to final much larger size
create image
create VM for testing
publish image.

It would be nice if I could upload a COMPRESSED image. The basic OS disk is 40G in size but compressed it is only 600k as it is nearly all empty to start with.

@JasonRShaver, I assume that you are really referring to something like the functionality provided by Azure VHD Utilities, correct?

Those will provide the right functionality, but I don't know how a customer would find that (and in this case, they did not), but is it possible to have a CLI command to acquire this, such as we do with Kuberneties


Support Django 3

Django 3 is to be released next week.
django-fsm does not yet support Django 3, but there's not that large changes needed, and there is a working fork, so support in django-fsm-log is useful even if django-fsm isn't updated.
To get django-fsm-log working with Django 3 is mostly a matter of stop using Django's private Python 2 compat APIs, https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis, e.g. django.utils.six.

Django 3 is now out and django-fsm 2.7.0 has been released with Django 3 support.

This line with django.utils.encoding.python_2_unicode_compatible is also breaking with Django 3:
https://github.com/gizmag/django-fsm-log/blob/355cb226534cd31c7cdbf76fb7b25526d922c42c/django_fsm_log/models.py#L7

BUMP. Was this released? I cannot find the next version on pip: https://pypi.org/project/django-fsm-log/#history

With the merge of #99, this can be closed.


connection error: unexpected end of file

export DENO_TLS_CA_STORE=system

~/labs
❯ deno --version
deno 1.43.5 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.4.5

~/labs
❯ deno run -A -r https://fresh.deno.dev
error: error sending request for url (https://deno.land/std@0.208.0/fs/_util.ts): connection error: unexpected end of file
    at https://deno.land/std@0.208.0/fs/ensure_dir.ts:2:33

Am I missing something here?

I'm unable to reproduce that on my end.

Closing as we haven't heard back and I'm not able to reproduce it.

https://github.com/denoland/fresh/assets/18315/a25bbd2e-bc8c-451e-a751-231b2dddc2b0
@marvinhagemeister still seeing ^


The UWP pivot is experiencing performance issues while using the DataGrid inside the pivot item.

Describe the bug
We have used the UWP DataGrid control inside the UWP PivotItem. While switching between pivot items, a performance delay occurs due to the number of columns and rows. Even with only 23 columns and 33 rows displayed, we are still experiencing performance delays.
Can you suggest a solution?
Steps to reproduce the bug
Step 1: Run the sample.
Step 2: Click Sheet2 pivot item.
Expected behavior: The performance delay should not occur while switching pivot items.
Observed behavior: A performance delay occurs while switching pivot items.
Sample
Pivot_PerformanceIssue.zip
Expected behavior
The performance delay should not occur while switching pivot items.
Screenshots
https://github.com/user-attachments/assets/e33d04ea-41d6-4ce4-8756-690d0c8ccc34
NuGet package version
None
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

Hi Team, - Any update on this?.


Bot is not going to accept/decline an tradeoffer.

Hey,
my Bot is not going to accept/decline an tradeoffer. it reconize it in the TestBot.log:
[BOT 2015-10-26 00:12:42] INFO: TradeOffer notification.
but that is everything.
my bot is logged in sucessfully. and all tradebans are gone.
i hope someone could help me.

solved.
https://github.com/TheAnthonyNL
helped me!
thx btw.


Check schema

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-747

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Set the property of gobblin.copy.expectedSchema when creating the workunit to enable schema check in distcp.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@ibuenros @autumnust Can you take a look at this?


Fix an occasional CI failure due to unaligned access [3.0]

This happens rarely, but only because very few CI runs use the exotic CPU type that is necessary to execute anything within rsaz_exp_x2.c and enable UBSAN at the same time.
crypto/bn/rsaz_exp_x2.c:562:20: runtime error: load of misaligned address 0x612000022cc6 for type 'uint64_t' (aka 'unsigned long'), which requires 8 byte alignment 0x612000022cc6: note: pointer points here
84 a3 78 e0 8e 8d  4a a5 51 9c 57 d0 d6 41  f3 26 d1 4e e1 98 42 b5  3a 9f 04 f1 73 d2 1d bf  73 44
^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior crypto/bn/rsaz_exp_x2.c:562:20 in ../../util/wrap.pl ../../fuzz/server-test ../../fuzz/corpora/server => 1 not ok 2 - Fuzzing server
This is for 3.0

Shouldn't this go to master too?

Shouldn't this go to master too?

in master it is already, but it did not cherry-pick.

This pull request is ready to merge

Merged to openssl-3.0 as 5b5ab6e.  Thanks!


Deprecate native Android app in favor of Flutter app

Since we will deprecate the Android app located in android folder sometime in the future. I am going to make a checklist of things to consider:

The Flutter app shouldn't have any dependencies on the Android app. Any shared code used by Flutter app, but located in android directory, should be copied to other places outside android.
Check if we can build the Android app successfully, then tag that commit and add a note to android/README.md that it is the last supported commit for Android app.
android folder should be marked / renamed to android_deprecated
Disable any CI steps for Android app
(to be updated)

This is a good list, but we shouldn't do any of this work before we start the deprecation process (likely after the 2.0 release).

We now have the Android app maintained in the android-v2 branch, and Flutter app maintained in the master branch.


Misspelled font-families type parameter in render function

First off — thanks for posting this repo. Awesome way to think about handling a design system's config single source of truth for settings.
I did some digging into the code since there isn't any documentation on the types of categories you can add. I noticed on line 321 of lib/formats/html.js that:
${this.renderSection('font-families', 'Font Families')}
...should actually be:
${this.renderSection('font-family', 'Font Families')}
Just a simple spelling change is needed here. Happy to do a pull request if needed.
PS — Any existing way to output kebab case values in the app.html file instead of camel case?

If you don't mind making a PR, that would be great! As far as the html template, you'd probably need to register your own format, but you can use lib/formats/html.js as a starting point.


More specific instructions: how to use?

Hello!
I need some help setting the extension up. I did this:

Installed the extension from the Marketplace,
Built the daScript compiler,

Specifically:
git clone https://github.com/GaijinEntertainment/daScript
cd daScript && cmake -B build && cd build && make -j8

And now I have the binary /home/andrew/daScript/bin/daScript, it passes all tests.

Now I enter the above path in the settings. However, the lsp doesn't seem to work

Highlighting works, but that seems to be it. No goto-definition or autocomplete.
I tried it on several projects: the das compiler itself and the samples provided in this repo to no avail.
LSP log:
language server (ls): starting server...  And so on

Any suggestions?

It's a known issue, but I am not sure hot to fix it correctly. Shortly, increase value in this setting dascript.server.connectTimeout , till 8, maybe 10, if you use debug build maybe 20.

I see, thanks!


Hang while switching between tabs

Dump was sent to
<EMAIL_ADDRESS>Environment
Windows 10 pro 1903 (x64)
Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version 0.2.1715.0

Any other software? chrome

Steps to reproduce
frequently switching between two tabs by alt+NUMBER
Expected behavior
Hang not occur
Actual behavior
Hang occurs (and does not end)

I'm not able to reproduce this issue and we don't seem to have the dump on the back-end.
Can you share it with me another way? Or if it's an actual crash, can you get the Windows Error Reporting information from the Event Viewer so I can try to find it on the backend?

You might also be able to use Feedback Hub to submit the dump that way and it would come to us...


Create CAPI machines under the EKSA's Cluster's namesapce

What would you like to be added:
Currently, CAPI machines (k get machines -A) are created under eksa-system namespace. I want them to be under the namespace specified in the EKSA Cluster.
For example,
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: Cluster
metadata:
  name: a-cluster
  namespace: cluster-ns

In this case, CAPI machines are created uder cluster-ns instead of eksa-system
Why is this needed:
I want to partition the clusters in the long-lived management cluster.

Adding to this - in a scenario where a management cluster has hundreds of thousands of workload clusters, we may run into scaling issues if all these capi/capc resources are in the eksa-system namespace. However, it sounds like breaking cluster resources into separate namespaces may have its own tradeoffs as well, since many operations in eks-a rely on the hardcoded eksa-system namespace and can add complexity, like clusterctl move


Client takes very long to callback when connection is lost

Running the following code in the console
var redis = require('redis');
var client = redis.createClient();
var i = 0;
var setValue = function (key, value, cb) {
	client.set(key, value, cb);
};

client.on('error', function (err) {
	//console.error('redis error', err);
});

setInterval(function () {
	i ++;
	(function(r) {
		console.time('set' + r);
		setValue('test-redis-foo', 'bar', function (err) {
			//if (err) { console.log('set error', err); }
			console.timeEnd('set' + r);
		});
	})(i);
}, 1000);

returns the following response
set1: 0ms
set2: 0ms
set3: 0ms
set4: 300ms
set5: 37ms
set6: 289ms
set7: 1416ms
set8: 415ms
set9: 3029ms
set10: 2028ms
set11: 1027ms
set12: 27ms
set13: 0ms
set14: 1ms
set15: 0ms
set16: 1ms
set17: 0ms

At set4, the client lost connection to the redis server since I manually shut down the server. I turned it back ON at set13.
If I am unable to reach my cache at any point, I want my server to behave as though the cache item did not exist. However, this introduces unnecessary delay.
Is there a way around this?
A simple fix was to modify my setValue as follows
var setValue = function (key, value, cb) {
	if (client.connected) {
		client.set(key, value, cb);
	} else {
		cb({msg: 'No connection'});
	}
};

In order to better support this project and its new group of collaborators under a new org we are trying to clean up and close issues older than 6 months. Your issue may have been fixed since the issue was open, however, if you are still experiencing a problem please re-open this issue and we will label it accordingly.


Make sudo optional

I've been using this action with both act and self-hosted runners and have been getting this error:
Run<EMAIL_ADDRESS>/usr/local/bin/docker exec  30f4d4181ed419ce585ceeca253e5434d4c1540cb5e02a7bd8cd0202584379b9 sh -c "cat /etc/*release | grep ^ID"
No etcdVersion specified. Going to use the default one.
No kubernetesVersion specified. Going to use the latest one.
Going to install kubebuilder 3.0.0 for linux-amd64
/bin/bash: line 1: sudo: command not found
Error: Command failed: sudo mkdir -p /usr/local/kubebuilder/bin
/bin/bash: line 1: sudo: command not found

Can we have a useSudo option that toggles the use of sudo for containers that do not contain a sudo binary?

No problem at all.
I will be busy this weekend so possibly can start working on it next week.
On Wed, 19 Apr 2023 at 12:07 PM Mahmoud Hanafy @.***>
wrote:

I've been using this action with both act https://github.com/nektos/act
and self-hosted runners and have been getting this error:
Run @.***
/usr/local/bin/docker exec  30f4d4181ed419ce585ceeca253e5434d4c1540cb5e02a7bd8cd0202584379b9 sh -c "cat /etc/*release | grep ^ID"
No etcdVersion specified. Going to use the default one.
No kubernetesVersion specified. Going to use the latest one.
Going to install kubebuilder 3.0.0 for linux-amd64
/bin/bash: line 1: sudo: command not found
Error: Command failed: sudo mkdir -p /usr/local/kubebuilder/bin
/bin/bash: line 1: sudo: command not found
Can we have a useSudo option that toggles the use of sudo for containers
that do not contain a sudo binary?
—
Reply to this email directly, view it on GitHub
https://github.com/RyanSiu1995/kubebuilder-action/issues/16, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5JC476GZSDAD6VDWZKGY3XCAEUVANCNFSM6AAAAAAXEJLEZQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Regards,
Ryan

Hi @mahmoudhossam, could you please check if 1.3.1 version fixes your issue?

@RyanSiu1995 sorry to bump this again, but I tried this again with 1.3.1 and it still seems to include sudo in the command even with useSudo set to false. Does it work for you?


Revert "Use cudf to compute exact hash join output row sizes (#3288)"

This reverts commit 25bad3d95ab3c464eb04df46e8a9300f81e75de3.
Fixes #3640.  When we switched to building the hash table explicitly, we lost the ability to be dynamic with which table is used as the build-side table for an inner join.  It's definitely something we can do ourselves, but it will be tricky to do properly given how the join code assumes the table designated as the build-side will be used for a hash and the stream side is the only one that is splittable.
Since we're in the process of finishing up 21.10, I think it's prudent to revert #3288 and tackle this in a future release.
#2354 tracks solving the real root issue which is requiring everything on an arbitrarily-chosen build side of an inner join to be pulled in at once.  Ideally this should try to examine both sides to choose the best build side and have a fallback if we cannot pull in either table completely to build the final hash table.

build


Add some simple test cases

I designed a few simple test cases based on the new derivation mechanism we discussed.

Can we write these as proper xfail tests in PyTest?

OK, I will modify it.

Thanks, @sangyx!


The player doesn't actually move.

When walking, the animation plays and moves for a bit but the player doesn't actually move.

I don't remember the original context for this report.


[T4A3][W13-B4]Liu ZhenDong

Ready to view

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


[BUG] [upgrade] Configuration in elasticsearch.yml is overwritten

Describe the bug
Settings from /etc/elasticsearch/elasticsearch.yml are overwritten by the defaults during epicli upgrade.
How to reproduce
Steps to reproduce the behavior:

Deploy Epiphany cluster with logging component enabled.
Change the default configuration (for example specification.cluster_name)
Run epicli upgrade

Expected behavior
Custom settings should be preserve after upgrade.
Environment

Cloud provider: All
OS: All

epicli version: develop
Additional context
n/a

DoD checklist

[ ] Changelog updated (if affected version was released)
[ ] COMPONENTS.md updated / doesn't need to be updated
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade

[ ] Case covered by automated test (if possible)
[ ] Idempotency tested
[ ] Documentation updated / doesn't need to be updated
[ ] All conversations in PR resolved

✅Fixed in #1844 [PR #1994].


Added few text editors

Added:

Notion
Overleaf
MacDown

to the list of Word processors.

Thanks. Overleaf would be a fine candidate for "Awesome Latex" list, so I would not include it here... As for the rest, I will wait until someone else can vote (:+1: or :-1:) on this PR.

It's already in the awesome-LaTeX list, the reason it was added here because it is used for scientific writing.

Added:

Notion
MacDown

to the list of Word processors.

Do you personally use these tools?

Good Additions

Do you personally use these tools?

Yes. I personally use these tools. Is your next question going to be asking me to provide a screenshot of installation and how I use them?
Are you adding only those tools that are often used by you? I highly doubt that you have used all the tools mentioned in your list.
There are etiquettes on how you should respond when someone, out of kindness, contributes to your repository. But, apparently, not everyone on Github follows them.

We have a Code of Conduct, which I hope you read:

Demonstrating empathy and kindness toward other people
Being respectful of differing opinions, viewpoints, and experiences
Giving and gracefully accepting constructive feedback
Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
Focusing on what is best not just for us as individuals, but for the overall community

It applies to maintainers and contributors both. Please understand, we are trying to work with you to provide constructive feedback.
If you do not want to discuss this any further, let us know. However, that also means we might edit your contributions without notifying you.

Yes. I personally use these tools. Is your next question going to be asking me to provide a screenshot of installation and how I use them?
Are you adding only those tools that are often used by you? I highly doubt that you have used all the tools mentioned in your list.
There are etiquettes on how you should respond when someone, out of kindness, contributes to your repository. But, apparently, not everyone on Github follows them.

Hi @Nazeeefa
@ashwinvis and I have only added tools to the list that we actually use. (Cf. https://moritzmaehr.ch/macos-10-15-basic-configuration/ for example) But that is not the point. The idea behind awesome lists is not to gather all possible tools, but the best ones. Therefore I am honestly interested in how you use the suggested tools in your everyday research.
PS: We are also always grateful when people participate in public domain projects. We act on your suggestion and develop Contribution Guidelines.

We have a Code of Conduct, which I hope you read:

Demonstrating empathy and kindness toward other people
Being respectful of differing opinions, viewpoints, and experiences
Giving and gracefully accepting constructive feedback
Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
Focusing on what is best not just for us as individuals, but for the overall community

It applies to maintainers and contributors both. Please understand, we are trying to work with you to provide constructive feedback.
If you do not want to discuss this any further, let us know. However, that also means we might edit your contributions without notifying you.

Yes, I did and it is very disrespectful to see that you have time to remind me of it but failed to follow it yourself.
There was no attempt from your side to provide constructive feedback. You seem to be unaware of what is in awesome-LaTeX list and, most importantly, you seem to be unaware of this repo's contribution guidelines; guidelines that I followed and made a polite attempt to contribute to your repository with an intention to help.
I know it's a small PR but I am very hurt by this interaction that I have not experienced on Github before.
You can edit my contributions without notifying me if that's your definition of handling PR with positive manners and feel free to add them to the list even though you have not personally used them.

Yes. I personally use these tools. Is your next question going to be asking me to provide a screenshot of installation and how I use them?
Are you adding only those tools that are often used by you? I highly doubt that you have used all the tools mentioned in your list.
There are etiquettes on how you should respond when someone, out of kindness, contributes to your repository. But, apparently, not everyone on Github follows them.

Hi @Nazeeefa
@ashwinvis and I have only added tools to the list that we actually use. (Cf. https://moritzmaehr.ch/macos-10-15-basic-configuration/ for example) But that is not the point. The idea behind awesome lists is not to gather all possible tools, but the best ones. Therefore I am honestly interested in how you use the suggested tools in your everyday research.
PS: We are also always grateful when people participate in public domain projects. We act on your suggestion and develop Contribution Guidelines.

Hi @maehr Kindly make this clear in your contribution guidelines with this link that you mentioned https://moritzmaehr.ch/macos-10-15-basic-configuration/ even if if you think it's not important. I don't want anyone else to go through same negative experience as I just did.
I use Notion for project organisation including to-do list, and note-taking. I use MacDown for writing and sometimes for web content. As I wrote to your colleague, you can edit my contributions and feel free to add them to the list even though you have not personally used them.
I will be closing this pull request because, I found this interaction disrespectful and this is not a healthy space to engage.

Yes, I did and it is very disrespectful to see that you have time to remind me of it but failed to follow it yourself.

I brought it up as a reminder because the tone of the discussion was becoming aggressive - even for a simple one line question.

There was no attempt from your side to provide constructive feedback.

That was what @maehr was trying to do. And he did explain the reason for the question in the first place. Empathize, and stand in others shoes before throwing wild accusations.

I know it's a small PR but I am very hurt by this interaction that I have not experienced on Github before.
I found this interaction disrespectful and this is not a healthy space to engage.

I do not know what to say. Maybe some other day you can tell us how we should have interacted with you.

You can edit my contributions without notifying me if that's your definition of handling PR with positive manners and feel free to add them to the list even though you have not personally used them.

We will not add Notion as it is not open-source. I will leave Macdown as a reminder.


Install error

When following notes.txt I get
(env)jeff@firebrick:/code/geoapp/env (master) $ pip install -r ../requirements.txt
Traceback (most recent call last):
  File "/code/geoapp/env/bin/pip", line 7, in <module>
    from pip import main
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/__init__.py", line 13, in <module>
    from pip.commands import commands, get_summaries, get_similar_commands
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/commands/__init__.py", line 6, in <module>
    from pip.commands.bundle import BundleCommand
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/commands/bundle.py", line 6, in <module>
    from pip.commands.install import InstallCommand
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/commands/install.py", line 5, in <module>
    from pip.req import InstallRequirement, RequirementSet, parse_requirements
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/req/__init__.py", line 3, in <module>
    from .req_install import InstallRequirement
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/req/req_install.py", line 31, in <module>
    from pip.utils import (
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/utils/__init__.py", line 59, in <module>
    def rmtree(dir, ignore_errors=False):
  File "/code/geoapp/env/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 47, in wrap
    @six.wraps(f)
AttributeError: 'module' object has no attribute 'wraps'

Was a conflict with an older virtualenv setup on my machine.


Double Free in Commit 72f812d

Hi!
It appears that xHTTP contains a double free vulnerability in close_connection at xhttp.c, line 595.
https://github.com/cozis/xHTTP/blob/72f812dcb77629c55fba1fd1ed91d13a4b380f90/xhttp.c#L595
The double free can be triggered with a malformed HTTP request method. For example, the following python3 script will make a request to the server with a malformed HTTP request method to trigger the double free:
#!/usr/bin/env python3

import socket

sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)

sock.connect(('localhost', 8080))

http_headers = (
    #Request - http_headers
    b'MALFORMEDMETHOD'*1000  +  # HTTP Method (POST Request).  Sending malformed HTTP Methods invokes a double free in xHTTP
    b' '
    b'/'
    b' HTTP/1.0'
    b'\r\n'
    b'Host: '
    b'localhost'
    b':'
    b'8080'
    b'\r\n'
    b'Accept-Encoding: '
    b'identity'
    b'\r\n'
    b'Content-Type: '  #Content type
    b'application/json'  #JSON content type
    b'\r\n'

    b'Connection: close\r\n'
    b'User-Agent: '
    b'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.246'
    b'\r\n'

    b'Content-Length: '
    b'152'  #Size - Content-Length_size
    b'\r\n'
    b'\r\n'  #Delim - crlf_headers_body
        #Block - post_body
        b'data=Somepostdata'

)

sock.send(http_headers)
sock.recv(65535)

sock.close()

To confirm the issue, I first compiled the example server with debug symbols and address sanitizer:
gcc example.c  xhttp.c -o main -fsanitize=address -g

Once the server was compiled, I executed the server on port 8080
xHTTP Server
$ ./main

After the server was up and running I saved the python3 script I created from above and executed it, triggering a double free.
Python3 script
$ python3 poc.py

Address Sanitizer Output
=================================================================
==460363==ERROR: AddressSanitizer: attempting double-free on 0x611000000040 in thread T0:
    #0 0x7f7cfaab76a8 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    #1 0x562a5c0a1727 in close_connection /home/kali/projects/fuzzing/xHTTP/xhttp.c:595
    #2 0x562a5c0a9406 in xhttp /home/kali/projects/fuzzing/xHTTP/xhttp.c:1749
    #3 0x562a5c09f693 in main /home/kali/projects/fuzzing/xHTTP/example.c:37
    #4 0x7f7cfa846189 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #5 0x7f7cfa846244 in __libc_start_main_impl ../csu/libc-start.c:381
    #6 0x562a5c09f420 in _start (/home/kali/projects/fuzzing/xHTTP/main+0x5420)

0x611000000040 is located 0 bytes inside of 256-byte region [0x611000000040,0x611000000140)
freed by thread T0 here:
    #0 0x7f7cfaab76a8 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    #1 0x562a5c0a3a4b in parse /home/kali/projects/fuzzing/xHTTP/xhttp.c:868
    #2 0x562a5c0a7371 in when_data_is_ready_to_be_read /home/kali/projects/fuzzing/xHTTP/xhttp.c:1459
    #3 0x562a5c0a92e0 in xhttp /home/kali/projects/fuzzing/xHTTP/xhttp.c:1735
    #4 0x562a5c09f693 in main /home/kali/projects/fuzzing/xHTTP/example.c:37
    #5 0x7f7cfa846189 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

previously allocated by thread T0 here:
    #0 0x7f7cfaab78d5 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:85
    #1 0x562a5c0a2dca in parse /home/kali/projects/fuzzing/xHTTP/xhttp.c:813
    #2 0x562a5c0a7371 in when_data_is_ready_to_be_read /home/kali/projects/fuzzing/xHTTP/xhttp.c:1459
    #3 0x562a5c0a92e0 in xhttp /home/kali/projects/fuzzing/xHTTP/xhttp.c:1735
    #4 0x562a5c09f693 in main /home/kali/projects/fuzzing/xHTTP/example.c:37
    #5 0x7f7cfa846189 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: double-free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52 in __interceptor_free

A possible fix could be implementing a check to ensure ' conn->request.public.headers.list ' is only freed once.
Thanks!

Hello, Good catch. I fixed this in #72f812d
Thank you very much! Oh, and sorry for the late reply!


Sensitivity analysis doc string and example

Create an example for tyson that uses sensitivity analysis and add more documentation.

Added Tyson example in examples folder as well as inside docstring


Can I use deep_translator offline?

Is there any way to cache translation models so I can use deep_translate offline without any Internet connection?
Do any of the supported translator services have a way to cache their models locally for this purpose?

To my knowledge, argos-translate supports offline translation.

Deep is not "a translator program"  It is a management program for other actual translator systems.
These systems are all online, eg: Google, ChatGPT.   The online translation systems all have vast libraries (petabytes) of english and other languages and large code bases to carry out the actual translation.
So no.

Hi, short answer is no, you cannot use it offline (at least for now)


Supportive - iteration 1

closing this -- forgot to refactor comments_allowed method

@jcurlee Please only submit Supportive exercise work and resubmit.


Accessibility fixes for environment window

Make the 2 buttons for enable IPython mode into a real checkbox.
404495 Accessibility : MAS40B : INSPECT : Python+ Python Environments : Control type is incorrect for the checkbox in Python Environments window
403510 Accessibility : MAS05 : Keyboard : Python + Python Environment : Focus order improper in Python Environment Window

👍


How to insert text to rich editor

It works like an EditText. Make sure when you implement it in XML, that the height and width is not 0.


Added icon images, removed unnecessary images and fixed bugs with overlapping statusbar

Please have a look if I destroyed anything for android
Received new images by @jannikbmc
Signed-off-by: Interperle<EMAIL_ADDRESS>

And I just triggered a run of our CI pipelin on this branch: the unit tests fail:
https://github.com/amosproj/amos2022ss05-find-my-hearing-aid/actions/runs/2673415471

And I just triggered a run of our CI pipelin on this branch: the unit tests fail:
https://github.com/amosproj/amos2022ss05-find-my-hearing-aid/actions/runs/2673415471

The Pipeline already fails for ui-rework2: https://github.com/amosproj/amos2022ss05-find-my-hearing-aid/runs/7354274909?check_suite_focus=true#step:5:147
The errors which occur have nothing todo with my changes.


Add 'Knowledge Cutoff' column to model library table

resolves #3412

Hi there! Thanks for the PR. As much as it's good to know this, the table might start get too wide in the README.md. Would it be possible to host this in a different repo or Gist etc?

Hi! Thank you for your feedback. I understand your concern about the width of the table in the README.md file. In the next PR, I will move the table to a Gist and link it in the README.md file. This should help maintain the readability of the README.md file while still providing the necessary information. Thanks again for your suggestion!

I think having everything in one place will make the cutoffs dates easier to maintain and verify.

@jmorganca If the cutoff dates are in a separate repository or gist, it's easier for them to be outdated or incorrect, especially if that repository or gist isn't owned by ollama.
If the cutoff dates aren't in README.md directly, maybe they can go in a KnowledgeCutoffs.md file linked from README.md?

@jmorganca If the cutoff dates are in a separate repository or gist, it's easier for them to be outdated or incorrect, especially if that repository or gist isn't owned by ollama.
If the cutoff dates aren't in README.md directly, maybe they can go in a KnowledgeCutoffs.md file linked from README.md?

yes, I do believe the same we can link it here as well or the gist, whereas I have created a separate gist as well #3428


fix a nasty memory leak on ios

Hi, I still have a memory problem with 2.0.1 version. Each time I call the find() function, memory is acumulating the results, after calling the find method 1500 times, my IPhone crash because the APP is using more than 1GB of ram memory.

@shazron was the dealloc ever implemented? I am also having this issue, and https://github.com/apache/cordova-plugin-contacts/pull/35/commits/d28ba9013cae21abc6826a1d6dbd06d841874c1d fixes it, but from your comment I understand this is not the proper way to do it.

@lboekhorst see #132


Looking for some concrete information on improving performance

There's a few things scattered around the docs, and I've read through all the issues here. I'm trying to figure out what else I can do to improve the performance of my API.
Currently, I am building a (very large) schema using the Schema object. I'm using a type registry that I built.
I have dynamic resolvers in all my types to handle relation resolution using a custom data loader. Most of the time consumed is building up ObjectType objects. I can't cache/serialize these easily due to the closures for resolution.
Is there a recommended course of action I can take here to improve the perf? I don't mind if it's laborious, but all the testing I've done in changing things around have not made a big difference.

Some details would be useful.
How many types do you have?
How many fields per type on average?
Which process consumes most of the time - new schema instance creation, query parsing or execution?
How deep is the query which is slow?
How many fields and types it affects?
Slow means how many milliseconds?
Also, try the following:

Define all fields and interfaces of your types as closures
Define typeLoader (e.g. use your type registry for this)
Keep in mind that overblog/dataloader-php has a perf issue (described it here). Make sure it doesn't affect you
Also experimental executor

Hey vladar, thanks a lot for the quick response! I'll try to answer your questions below.

How many types do you have?

Well over 1K.

How many fields per type on average?

I'm not sure the average is useful, some are large (10+) some are pretty small (1-2.) There's a pretty wide range, it depends on the object, but there's a good amount of large ones.

Which process consumes most of the time - new schema instance creation, query parsing, validation or execution?

That I am not 100% sure on yet - I'm still going through and profiling. I'll post up the Blackfire once I have it cleaned up.

How deep is the query which is slow?

Roughly three relations, it gets worse the bigger it is, but not by that much to be honest.

How many fields and types it affects?

Lots.. the query is very large, and dynamically generated by our internal tools so it's pretty ugly to look at.

Slow means how many milliseconds?

It's not awful, honestly - I've been able to get it down to 500-600ms from request to response which, considering how large the schema is, I don't think is awful. That being said, I'm just looking to see if there's anything I can do better (as obviously, the faster the better!)

I will give this a try!
Done this already.
Not using this, I built my own (we use ElasticSearch so I needed something pretty custom.)
Tried this, did not really help at all (and broke introspection for me.)

And by the way, do you have any logic in your ObjectType constructors (other than just defining the type config)?

Nothing super complex, but it does new up the models and convert them to the type definition. There's some slowdown there. I was investigating perhaps defining them using type language instead, but I'd still need to pass in the resolvers which I'd then need to define somewhere, and I don't know if that would make a big difference or not. Do you think it would?

For anyone coming across this in future, I spent most of today working through this without a ton of luck. Then I tried out running this library on top of a Swoole server - API responses that were previously taking 250-300ms dropped to 30ms. It basically supercharges your type registry since you don't have to keep instantiating new objects on every request.
Not necessarily a plug in fix but definitely something worth trying if you're hunting for performance.

ObjectType constructors should be as lightweight as possible. If you can - move most of your model-wiring logic into the fields closure.
It is really hard to provide any further help without code examples/profiling results. But I suspect that 200-300ms for 1k+ schema and default PHP execution model is a quite expected result.
The execution model of Swoole (and other similar tools) obviously works better for GraphQL, but it requires you to be much more careful in your code: in PHP we are used to the fact that server frees-up resources for us, so it is much easier to introduce memory leaks in such environments which would lead to crashes.
So everything has pros and cons. But if you are aware of them - I would definitely recommend Swoole for the GraphQL API server.

Yeah, I am very happy with the performance and quality of this library overall - didn't want to make it sound like it was bad! I was just wondering if there was anything else I should be doing to improve the performance even further. I figured 300ms for resolution wasn't awful, just wanted to see how much better I could do.
Definitely not a 'plug and play' solution by using Swoole, but it's definitely helped a lot in my use case! Thanks for your help and feedback.


WIP: NIFI-6752 Add ASN.1 RecordReader

TODOs:

[ ] support more types
[ ] documentation
[ ] L&N

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
This PR adds new JASN1Reader RecordReader.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Great contribution, I had to make a processor that decodes asn1 in the company where I work. This feature would have solved many problems. Great job.

I tested the controller service with different configs (base case, record field, record field containing list, custom iterator) and it looks good to me.
I think the class loading logic could be simplified in either of the following ways:
option 1)

set dynamicallyModifiesClasspath(true) on MODEL_CLASS_PATHS
specify @RequiresInstanceClassLoading on JASN1Reader
call Class.forName(rootClassName) in JASN1RecordReader to load the model class (and similarly the iterator class)

option 2)

set dynamicallyModifiesClasspath(true) on MODEL_CLASS_PATHS
call Thread.currentThread().getContextClassLoader().loadClass(rootClassName) to load the model class (and similarly the iterator class)

I tried out both versions with the test cases mentioned above and they worked fine.


replacing words with api

This should close #36.

I should split out the database upgrade changes to a different PR.

Tested pr-44 images and they work.


Updated docs.

This PR updates docs dependencies and actually closes https://github.com/taskiq-python/taskiq/issues/311.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (7f75e7a) to head (2034031).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #315   +/-   ##
========================================
  Coverage    77.88%   77.88%
========================================
  Files           61       61
  Lines         1800     1800
========================================
  Hits          1402     1402
  Misses         398      398

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is it possible to use the hotkeys (ctrl-c, ctr-v) with a non-Latin layout?

Discussed in https://github.com/emilk/egui/discussions/4369

Originally posted by g-codx April 16, 2024
Hi. Is it possible to use the hotkeys (ctrl-c, ctr-v) with a non-Latin layout? For example, my keyboard has both Latin and Cyrillic layouts. When I use the non-Latin layout, I usually use the shortcut (ctrl-'C', ctrl-'М') and it doesn't work. Is there a way to get egui to copy and paste text regardless of keyboard layout?
*where C is the Cyrillic character next to C(Latin)
*where М is the Cyrillic character next to V

It was also discussed here
*the problem is relevant for all shortcuts

Might be a duplicate of #4081.


Add PriorityClass setting to recurring jobs

longhorn/longhorn#2444

Sorry. Longhorn may need to update tolerations or priority classes in the setting controller.

Do you mean updating tolerations or priority classes for cronjob? If so, we don't need to do it setting controller because volume controller will update the cronjob when it is not in desired state https://github.com/longhorn/longhorn-manager/blob/1fbd2bf21fdcac5dbc063644c48e66acbdc633d6/controller/volume_controller.go#L2255-L2261

Sorry. Longhorn may need to update tolerations or priority classes in the setting controller.

Do you mean updating tolerations or priority classes for cronjob? If so, we don't need to do it setting controller because volume controller will update the cronjob when it is not in desired state
https://github.com/longhorn/longhorn-manager/blob/1fbd2bf21fdcac5dbc063644c48e66acbdc633d6/controller/volume_controller.go#L2255-L2261

OK. I forgot this part. Then this PR LGTM


Icon request: ecloud (/e/ cloud)

URL of the site or app
https://e.foundation/ecloud/ & https://ecloud.global/
Logo resources for the icon
https://doc.e.foundation/images/e_logo.svg
Anything else?
Links which may help:
https://e.foundation/
https://simpleicons.org/icons/e.svg

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/ecloud.svg

❓ How to add icon(s) to Aegis?
⭐ Support this project by giving a star! Just adding like to this comment is also appreciated.


Pluck Scan called without calling Next

	var username string
	db.Model(&model.User{}).
		Where("id = @id", sql.Named("id", 10000)).
		Limit(1).
		Pluck("username", username)

need & before username
	var username string
	db.Model(&model.User{}).
		Where("id = @id", sql.Named("id", 10000)).
		Limit(1).
		Pluck("username", &username)

GORM version is v1.25.0.
I encountered the same error when I use the Pluck to get single column value. My code as follow:
func GetModelStatus(id uint64) (status constants.ModelStatus, err error) {
	err = Db.Model(&model.Model{}).Where("id = ?", id).Pluck("status", &status).Error
	return
}

The type constants.ModelStatus defined as follow:
type ModelStatus int

Can anyone help me, thx.

I found taht in the low version, such as 1.24.1, the Pluck no problem.
In desperation, I use Scan indtead of Pluck to get single column value and succeeded.


Yarn Package missing /dist

When I add Swup through Yarn (yarn add swup), the package I get is missing the /dist folder. The folder tree I get is like:
swup
|- .idea
|- lib
|- plugins

And there is no swup.js present. Wierd one! Am I downloading the wrong package or is this an error?

I'm going to explain some concepts that are used in swup file structure, so we're on the same page.
When getting the package through Yarn or NPM, you get a package published on NPM.
The package.json file includes a line "main": "lib/index.js",, which tells NPM that this is the root file, so when you do import Swup from 'swup', this is the file you're getting. Actually, this is only a root file of swup which imports all other parts it needs from lib folder, so basically what you are loading is the whole lib folder. lib folder is a copy of src folder and is transpiled by babel, so people can load it from NPM and doesn't have to transpile it again.
Plugins folder is in the root so the plugins can be loaded like this swup/plugins/pluginName. This folder is in the root only because NPM does not allow to define root folder, which in this case, would be lib and loading plugins as swup/lib/plugins/pluginName just seems too ugly.
dist folder is already bundled code ready for browser, that's why it can be included in a script tag.
NPM similarly to GIT has a .npmignore file which, in this case, includes dist folder, so it is not published in NPM, as it is not necessary because all you need is in lib folder which is accessed when you do the import Swup from 'swup'.

Now, when people use a package manager like Yarn or NPM to get packages, I assume they are using some bundler to bundle it all together, and not include the bundled file in script tag from node_modules folder (or at least I never met anyone who does). That's why it's not included in the NPM package and only present here on Github where people can download it if needed. Do you load scripts from node_modules folder via script tag? There is no problem to add it. I just always thought it's unnecessary and wouldn't be used.
PS:
.idea is folder used by my IDE and shouldn't be in the package. I have deleted it. Thank you for pointing it out.

Hi,
Thanks for taking the time to explain, I appreciate it :)
Perhaps my workflow is a little odd! I have my node_modules folder, and use Yarn to add / upgrade / delete packages within it.
I use Codekit for my build process, which has the facility to import javascript files into one source file, which is then minified on build. So I pull any node_module files I want into that, add my own javascript and then build. This is why I could do with the dist file being available, to be used for importing. More about how that Codekit bit works here: https://codekitapp.com/help/javascript/
I can of course download it from github (which is what I will do for this project), but then I miss out on the easy upgrade of the package when changes are made.

No worries. Kind of used it as an opportunity to describe it for future reference.
I see... I have added the dist folder to npm, as it's few extra files (relatively small) but will allow better management for people with similar workflow to yours.


[WIP][18.03 backport] use a custom grpc dialer when managers are joining

backport of https://github.com/docker/swarmkit/pull/2802 for 18.03
Minor conflict in import statements, due to https://github.com/docker/swarmkit/pull/2750 not being in the 18.03 branch
diff --cc manager/state/raft/util.go
index da44dca6,1a49f76c..00000000
--- a/manager/state/raft/util.go
+++ b/manager/state/raft/util.go
@@@ -1,10 -1,10 +1,15 @@@
  package raft

  import (
++<<<<<<< HEAD
++=======
+       "context"
+       "net"
++>>>>>>> 3a531f45... use a custom grpc dialer when managers are joining
        "time"

 +      "golang.org/x/net/context"
 +
        "github.com/docker/swarmkit/api"
        "github.com/docker/swarmkit/manager/state"
        "github.com/docker/swarmkit/manager/state/store"

marking this "WIP" because there's some comments on the original PR, and we should have it merged in master first

LGTM once the original PR is merged


Good job

I would like to tell you how brillant is this package. Thank you for this amazing job.

Thank you for this lovely words :heart:


Support for Linux

Hello Authors,
Is there any support of this tool for Linux drivers too?

Thanks for your interest. Unfortunately, there is no support for Linux drivers right now.
FYI, you may find DIFUZE useful.


Fix AppThemeBinding when changing between dark and light modes

Fix AppThemeBinding when changing between dark and light modes. Replaced TabHostView border with a frame which allows the AppThemeBinding to properly update the underlying properties.

Unfortunately I can't do that since .net 9 is just around the corner...
But you should open a bug in the maui repo linked to the issue


[MC-1563] File downloading

Added class CTFileDownloadManager and CTFileDownloader to handle file downloading, their callback and expiry handling for all file types together.

Addressed the requested changes above and added more unit tests.
Save files to a directory inside documents (CleverTap_Files)
File name is changed to be _. This ensures URLs with equal last components will be written to different files ie. https://site.com/image.png and https://site-1.com/image.png. File name example:<PHONE_NUMBER>138815486_ct_test_url_0.png
Clear all files method removes all files inside the directory and does not rely on the URLs expiry cache.
Added unit tests that mock NSFileManager operations and ensure correct behaviour of download and delete disk operations.


examples(allocation): free memory after unmarshalling a result from the guest

Signed-off-by: Luca Burgazzoli<EMAIL_ADDRESS>

This is the benchamrks result I get by comparing main vs this PR:
➜ benchstat old.txt new.txt
goos: linux
goarch: amd64
pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/compiler
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
                          │   old.txt    │                new.txt                 │
                          │    sec/op    │    sec/op      vs base                 │
Allocation/Compile-12       12.00m ± 15%    12.16m ±  2%          ~ (p=0.699 n=6)
Allocation/Instantiate-12   598.9µ ±  1%    622.0µ ±  3%     +3.85% (p=0.009 n=6)
Allocation/Call-12          2.031µ ±  6%   28.617µ ± 24%  +1308.99% (p=0.002 n=6)
geomean                     244.4µ          600.5µ         +145.71%

                          │   old.txt    │                new.txt                 │
                          │     B/op     │     B/op       vs base                 │
Allocation/Compile-12       2.553Mi ± 0%   2.553Mi ±  0%          ~ (p=0.818 n=6)
Allocation/Instantiate-12   348.0Ki ± 0%   348.0Ki ±  0%          ~ (p=0.626 n=6)
Allocation/Call-12            48.00 ± 0%    586.00 ± 10%  +1120.83% (p=0.002 n=6)
geomean                     34.94Ki        80.45Ki         +130.26%

                          │   old.txt   │              new.txt               │
                          │  allocs/op  │  allocs/op   vs base               │
Allocation/Compile-12       2.023k ± 0%   2.023k ± 0%        ~ (p=1.000 n=6)
Allocation/Instantiate-12    841.5 ± 0%    841.5 ± 0%        ~ (p=1.000 n=6)
Allocation/Call-12           5.000 ± 0%    6.000 ± 0%  +20.00% (p=0.002 n=6)
geomean                      204.2         217.0        +6.27%

pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/interpreter
                          │   old.txt    │               new.txt                │
                          │    sec/op    │    sec/op      vs base               │
Allocation/Compile-12       2.761m ±  8%    3.238m ± 14%  +17.27% (p=0.009 n=6)
Allocation/Instantiate-12   168.9µ ± 30%    152.4µ ± 82%        ~ (p=0.589 n=6)
Allocation/Call-12          53.99µ ± 11%   107.08µ ±  9%  +98.33% (p=0.002 n=6)
geomean                     293.1µ          375.2µ        +28.01%

                          │   old.txt    │               new.txt                │
                          │     B/op     │     B/op      vs base                │
Allocation/Compile-12       1.449Mi ± 0%   1.449Mi ± 0%         ~ (p=0.589 n=6)
Allocation/Instantiate-12   222.8Ki ± 0%   222.8Ki ± 0%         ~ (p=0.186 n=6)
Allocation/Call-12          2.241Ki ± 0%   6.569Ki ± 0%  +193.18% (p=0.002 n=6)
geomean                     90.49Ki        129.5Ki        +43.13%

                          │   old.txt   │                new.txt                │
                          │  allocs/op  │  allocs/op   vs base                  │
Allocation/Compile-12       1.076k ± 0%   1.077k ± 0%         ~ (p=0.061 n=6)
Allocation/Instantiate-12    747.0 ± 0%    747.0 ± 0%         ~ (p=1.000 n=6) ¹
Allocation/Call-12           98.00 ± 0%   264.00 ± 0%  +169.39% (p=0.002 n=6)
geomean                      428.7         596.6        +39.19%
¹ all samples are equal

I'm not sure if I did everything correct but it looks like there is still a large difference

The memory increase seems negligible (it's 1000%+, but just 500 bytes). My previous analysis is totally invalidated because I read Mi in the first line and assumed 500 megabytes below. So please disregard that.
The CPU increase I don't know how to evaluate. Is a 20µs increase a problem?
If so, I would test a couple of things, to test the assumption that TinyGo using cgo might be the issue.
One is "caller allocates" convention: host calls malloc with a (perhaps oversized) buffer, passes the pointer and length in, guest returns the length.
The other is a global variable for the result. In the guest:
// Use this global variable to keep the return value from an external function from being GCed.
var lastResult any

// Call this function to allow GCing the return value from an external function.
func ClearLastResult() { lastResult = nil }

I would chime in on 20us being a problem. I think it is because for example a web handler can return in less than a microsecond and tinygo is used to implement file handlers.
@dmvolod seemed to have a regression fix around tinygo recently and you can tell in these benchmarks that even using things like protobuf, the whole round trip is less than the additional overhead added here. https://github.com/knqyf263/go-plugin/pull/48
TL;DR; something's wrong and we shouldn't advocate (merge) this unless the overhead becomes more a percentage than a factor ;)

@codefromthecrypt, the second commit here, uses the patter suggested here https://github.com/tinygo-org/tinygo/issues/2787#issuecomment-1103780412
Results are:
➜ benchstat old.txt new.txt
goos: linux
goarch: amd64
pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/compiler
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
panic:
                          │   old.txt   │               new.txt               │
                          │   sec/op    │   sec/op     vs base                │
Allocation/Compile-12       11.93m ± 6%   12.01m ± 6%       ~ (p=0.937 n=6)
Allocation/Instantiate-12   608.9µ ± 2%   610.2µ ± 1%       ~ (p=0.937 n=6)
Allocation/Call-12          2.016µ ± 2%
geomean                     244.7µ        2.707m       +0.42%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                          │   old.txt    │               new.txt                │
                          │     B/op     │     B/op      vs base                │
Allocation/Compile-12       2.553Mi ± 0%   2.554Mi ± 0%  +0.02% (p=0.030 n=6)
Allocation/Instantiate-12   348.0Ki ± 0%   348.0Ki ± 0%       ~ (p=0.697 n=6)
Allocation/Call-12            48.00 ± 0%
geomean                     34.94Ki        953.9Ki       +0.01%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                          │   old.txt   │               new.txt               │
                          │  allocs/op  │  allocs/op   vs base                │
Allocation/Compile-12       2.023k ± 0%   2.034k ± 0%  +0.54% (p=0.002 n=6)
Allocation/Instantiate-12    841.0 ± 0%    841.0 ± 0%       ~ (p=1.000 n=6)
Allocation/Call-12           5.000 ± 0%
geomean                      204.1        1.308k       +0.27%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/interpreter
                          │   old.txt    │
                          │    sec/op    │
Allocation/Compile-12       3.017m ± 19%
Allocation/Instantiate-12   154.9µ ± 14%
Allocation/Call-12          58.87µ ± 10%
geomean                     301.9µ

                          │   old.txt    │
                          │     B/op     │
Allocation/Compile-12       1.449Mi ± 0%
Allocation/Instantiate-12   222.8Ki ± 0%
Allocation/Call-12          2.239Ki ± 0%
geomean                     90.46Ki

                          │   old.txt   │
                          │  allocs/op  │
Allocation/Compile-12       1.077k ± 0%
Allocation/Instantiate-12    747.0 ± 0%
Allocation/Call-12           98.00 ± 0%
geomean                      428.8

panic: runtime error: invalid memory address or nil pointer dereference
                          │   new.txt    │
                          │    sec/op    │
Allocation/Compile-12       2.902m ± 13%
Allocation/Instantiate-12   150.6µ ±  4%
geomean                     661.2µ

                          │   new.txt    │
                          │     B/op     │
Allocation/Compile-12       1.458Mi ± 0%
Allocation/Instantiate-12   222.8Ki ± 0%
geomean                     576.7Ki

                          │   new.txt   │
                          │  allocs/op  │
Allocation/Compile-12       1.087k ± 0%
Allocation/Instantiate-12    747.0 ± 0%
geomean                      901.1

hmm panic: runtime error: invalid memory address or nil pointer dereference so I think something is busted, but luckily doesn't need the benchmark to find it. Can you have a look at TestAllocation?.

@codefromthecrypt  with the latest commit which implements the suggestion in https://github.com/tinygo-org/tinygo/issues/2787#issuecomment-1103780412, the results are:
➜ benchstat old.txt new.txt
goos: linux
goarch: amd64
pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/compiler
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
                          │   old.txt   │              new.txt               │
                          │   sec/op    │   sec/op     vs base               │
Allocation/Compile-12       11.93m ± 6%   11.96m ± 4%        ~ (p=1.000 n=6)
Allocation/Instantiate-12   608.9µ ± 2%   624.0µ ± 2%   +2.47% (p=0.041 n=6)
Allocation/Call-12          2.016µ ± 2%   2.488µ ± 4%  +23.41% (p=0.002 n=6)
geomean                     244.7µ        264.8µ        +8.23%

                          │   old.txt    │               new.txt               │
                          │     B/op     │     B/op      vs base               │
Allocation/Compile-12       2.553Mi ± 0%   2.554Mi ± 0%   +0.03% (p=0.041 n=6)
Allocation/Instantiate-12   348.0Ki ± 0%   352.2Ki ± 0%   +1.22% (p=0.002 n=6)
Allocation/Call-12            48.00 ± 0%     56.00 ± 0%  +16.67% (p=0.002 n=6)
geomean                     34.94Ki        36.93Ki        +5.71%

                          │   old.txt   │              new.txt               │
                          │  allocs/op  │  allocs/op   vs base               │
Allocation/Compile-12       2.023k ± 0%   2.033k ± 0%   +0.49% (p=0.002 n=6)
Allocation/Instantiate-12    841.0 ± 0%    843.0 ± 0%   +0.24% (p=0.002 n=6)
Allocation/Call-12           5.000 ± 0%    6.000 ± 0%  +20.00% (p=0.002 n=6)
geomean                      204.1         217.5        +6.52%

pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/interpreter
                          │   old.txt    │               new.txt               │
                          │    sec/op    │    sec/op     vs base               │
Allocation/Compile-12       3.017m ± 19%   2.978m ± 10%        ~ (p=1.000 n=6)
Allocation/Instantiate-12   154.9µ ± 14%   151.1µ ±  1%        ~ (p=0.310 n=6)
Allocation/Call-12          58.87µ ± 10%   65.98µ ±  3%  +12.08% (p=0.004 n=6)
geomean                     301.9µ         309.6µ         +2.55%

                          │   old.txt    │              new.txt               │
                          │     B/op     │     B/op      vs base              │
Allocation/Compile-12       1.449Mi ± 0%   1.458Mi ± 0%  +0.57% (p=0.002 n=6)
Allocation/Instantiate-12   222.8Ki ± 0%   223.0Ki ± 0%  +0.06% (p=0.002 n=6)
Allocation/Call-12          2.239Ki ± 0%   2.330Ki ± 0%  +4.06% (p=0.002 n=6)
geomean                     90.46Ki        91.86Ki       +1.55%

                          │   old.txt   │              new.txt              │
                          │  allocs/op  │  allocs/op   vs base              │
Allocation/Compile-12       1.077k ± 0%   1.087k ± 0%  +0.93% (p=0.002 n=6)
Allocation/Instantiate-12    747.0 ± 0%    748.0 ± 0%  +0.13% (p=0.002 n=6)
Allocation/Call-12           98.00 ± 0%   103.00 ± 1%  +5.10% (p=0.002 n=6)
geomean                      428.8         437.5       +2.03%

in some ways it looks like we are doing the same thing as tinymem now.
However, mixing and matching the built-in "malloc" and "free" with an explicit version (similar to tinygo) is a little confusing I think, especially in an example.
I prefer the example either use the built-in functions like it did before or manually manage, but not both.
So if you think that we shouldn't use malloc/free exported by tinygo then I think we just inline the latest version of the code in tinymem into the example/benchmark, then refer to tinymem as a repo that does this for you.
https://github.com/tetratelabs/tinymem/blob/main/example/greeting.go

so to the point of @ncruces here https://github.com/tetratelabs/wazero/pull/1390#issuecomment-1517755372

One is a "caller allocates" convention: host calls malloc with a (perhaps oversized) buffer, passes the pointer and length in, guest returns the length.

this is what was going on before, and kindof is still. Similar to rust, this was using the underlying malloc/free built-in imports.

The other is a global variable for the result. In the guest:

This is kindof happening now, except using a map instead of a single field. IMHO if doing something more complicated (like using a map), I think the code that is almost like tinymem should be exactly like that, since that code was reviewed etc, no need to inline something almost the same. In other words, not copy/paste from my old comment, rather the latest version of it.
OTOH, I don't know that the special malloc/free exports are going away any time, except possibly not exported by default. Frankly, I have lost track of the real motivation to change anything, but I also don't mind changing as long as it is coherent!

@codefromthecrypt this whole exercise is an attempt to add some clarification about how host/guest memory should be handled for future devs that like me where looking for an example as it looks like this topic is not much clear, yet.
And this PR seems to be a confirmation :)
I don't have any preference about using timymem (which I discovered only today) or the builtin free/malloc and CGO so I would love to have some guidance about which one you'd like to be part of the examples. Also, should add a dedicated example and related benchmark ?

I guess if tinymem's goal is to encode best practices in terms of allocations across the host-guest boundary, it's only natural that an example either uses it or reimplements it.
My suggestions were more with the goal of root causing the benchmark regression. From the data @lburgazzoli collected it seems using CGo from TinyGo might be the culprit?
And if that's so, that probably confirms that tinymem's approach is the best one, for a TinyGo guest.

Surprisingly or not I think I am on the same page with both! Maybe took a bit for my brain to catch up.
Conflicting advice is basically the opposite of clear, so that's why I think our example should not mix both in the same code. When they are mixed it is really difficult to figure out what advice is and even more unclear is the perf impacts.
So, let's recap our entrypoints: We have the example which shows new users how to do allocation, and we also have a safeguard Allocation benchmark which both serves to compare more realistic interaction performance (vs wasmtime etc), and also acts in some ways as a soak test. For example, it was through the benchmark we found things breaking functionally or performance. That is a surprising helpful thing.
Along the way, though, we changed the example to something it wasn't before. Specifically "greeting" vs "greet", so we can't really compare performance of the two based on the prior commit. Until the exact use case is run, both ways I don't think we can say for sure an outcome.
Here's an idea, if folks have patience for it. Note: this is temporary to achieve an outcome of knowing if both approaches work or have dramatically different outcomes when compared exactly.
Change the tinygo allocation source to use a CLI arg to determine the style to use. Include in the source both approaches to implement greeting. both pure CGO including go imports and also the tinymem approach. For tinymem, literally copy/paste the code from tinymem so it isn't subtly different.
For example export "greeting_cgo" and "greeting_tinymem" then in the host side do both approaches switched on an arg. So, for example the cgo style would use "malloc" and tinymem style "_malloc". Another way is to make another directory, like tinygo-malloc, if it helps.
Then, run the benchmark against each. You can make a manual benchmark or modify BenchmarkAllocation to allow choosing which. The main idea is benchmarking exactly the same use case, both to see the results and also that they complete without error.

I also want to clarify from my personal POV, I didn't help make tinymem because I thought it was a better idea. This project was made defensively because tinygo were considering removing the CGO imports (those in use by go-plugin, trivy and others). I don't personally want folks to have to do memory things manually, as wasm is hard enough as it is!

Here's an idea, if folks have patience for it. Note: this is temporary to achieve an outcome of knowing if both approaches work or have dramatically different outcomes when compared exactly.
Change the go allocation source that calls tinygo's wasm to use a CLI arg to determine the style to use. Change the tinygo source to implement both approaches to "greeting": pure CGO including go imports and also the tinymem approach. For tinymem, literally copy/paste the code from tinymem so it isn't subtly different.
For example export "greeting_cgo" and "greeting_tinymem" then in the host side do both approaches switched on an arg. So, for example the cgo style would use "malloc" and tinymem style "_malloc". Another way is to make another directory, like tinygo-malloc, if it helps.
Then, run the benchmark against each. You can make a manual benchmark or modify BenchmarkAllocation to allow choosing which. The main idea is benchmarking exactly the same use case, both to see the results and also that they complete without error.

If there is not urgency, I would like to take this task

In my latest commit, I added a POC for what has been described by @codefromthecrypt in the latest comments.
Some names must probably be changed for something better but here I just want to have some feedback

Thanks for progressing this! can you paste output of bench results for these two?
Please revert examples/allocation/tinygo changes and run again. We can argue that even if you "should" free after use, most code in practice doesn't. Let's separate the topics, so people can know what sort of overhead if any a change here will cost vs what they do now.

 So we were pinged about our docs on the site which suggest something "out of date" by tinygo folks, whatever the current recommendation is (CGO) can you verify which with them and also update the site?
I'm fine with either approach, and think you did the right diligence to show the leaking way isn't saving anything. Between the two others (use tinygo's CGO or don't (use tinymem)) I'm fine.
I'm re-pinging @ncruces and adding @inkeliz for a final say on this

thanks tons @lburgazzoli looks excellent. So we were pinged about our docs on the site which suggest something "out of date" by tinygo folks, whatever the current recommendation is (CGO) can you verify which with them and also update the site?

I will

@codefromthecrypt should I squash the commits to remove some noise form the review ?

so if the recommendation is to use either CGO or tinymem, what I would do is delete the old allocation tinymem and keep your two. If the recommendation is one or the other, I'd suggest replace it. So, you can squash for now, then when a decision is made on that topic, adjust accordingly!

so I'm guessing from lack of info contrary, that the preferred approach is the CGO one. feel free to remove the other approaches and squash for review!

so I'm guessing from lack of info contrary, that the preferred approach is the CGO one. feel free to remove the other approaches and squash for review!

to be clear, should the original allocation example/bench be kept ?

to be clear, should the original allocation example/bench be kept ?

right any tests or bench there before should stay, just the tinygo impl should change to match CGO approach. Thanks!

@codefromthecrypt I've adapted the allocation example to use CGO for the greeting function and squashed the commits.
I kept the BenchmarkAllocationCGO so there is one bench that runs against greet and one against greeting:
➜ go test -run='^$' -bench '^BenchmarkAllocation.*' ./internal/integration_test/vs/compiler -count=6
goos: linux
goarch: amd64
pkg: github.com/tetratelabs/wazero/internal/integration_test/vs/compiler
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz

BenchmarkAllocation/Compile-12                73          32071839 ns/op         2958373 B/op       2027 allocs/op
BenchmarkAllocation/Compile-12                73          14590089 ns/op         2953361 B/op       2022 allocs/op
BenchmarkAllocation/Compile-12                81          15130377 ns/op         2953334 B/op       2022 allocs/op
BenchmarkAllocation/Compile-12                80          14616454 ns/op         2953033 B/op       2022 allocs/op
BenchmarkAllocation/Compile-12                84          14875860 ns/op         2952820 B/op       2021 allocs/op
BenchmarkAllocation/Compile-12                79          15151539 ns/op         2952698 B/op       2021 allocs/op
BenchmarkAllocation/Instantiate-12          3987            338833 ns/op          359861 B/op        852 allocs/op
BenchmarkAllocation/Instantiate-12          3866            347517 ns/op          359903 B/op        852 allocs/op
BenchmarkAllocation/Instantiate-12          3709            362471 ns/op          359768 B/op        852 allocs/op
BenchmarkAllocation/Instantiate-12          3744            357544 ns/op          359742 B/op        852 allocs/op
BenchmarkAllocation/Instantiate-12          3633            362594 ns/op          359736 B/op        852 allocs/op
BenchmarkAllocation/Instantiate-12          3699            368921 ns/op          359766 B/op        852 allocs/op
BenchmarkAllocation/Call-12               342232              3376 ns/op              48 B/op          5 allocs/op
BenchmarkAllocation/Call-12               362686              3294 ns/op              48 B/op          5 allocs/op
BenchmarkAllocation/Call-12               366472              3247 ns/op              48 B/op          5 allocs/op
BenchmarkAllocation/Call-12               348795              3282 ns/op              48 B/op          5 allocs/op
BenchmarkAllocation/Call-12               367167              3263 ns/op              48 B/op          5 allocs/op
BenchmarkAllocation/Call-12               343881              3523 ns/op              48 B/op          5 allocs/op

BenchmarkAllocationCGO/Compile-12             79          14663107 ns/op         2952708 B/op       2022 allocs/op
BenchmarkAllocationCGO/Compile-12             80          15036263 ns/op         2952842 B/op       2021 allocs/op
BenchmarkAllocationCGO/Compile-12             81          14828323 ns/op         2952739 B/op       2022 allocs/op
BenchmarkAllocationCGO/Compile-12             81          14646740 ns/op         2952697 B/op       2021 allocs/op
BenchmarkAllocationCGO/Compile-12             80          14670556 ns/op         2952770 B/op       2022 allocs/op
BenchmarkAllocationCGO/Compile-12             81          14636888 ns/op         2952636 B/op       2021 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3385            417383 ns/op          360447 B/op        852 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3056            377058 ns/op          359731 B/op        852 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3600            368788 ns/op          359733 B/op        852 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3544            376303 ns/op          359736 B/op        852 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3094            362826 ns/op          359752 B/op        852 allocs/op
BenchmarkAllocationCGO/Instantiate-12       3470            362647 ns/op          359761 B/op        852 allocs/op
BenchmarkAllocationCGO/Call-12            413808              2770 ns/op              64 B/op          7 allocs/op
BenchmarkAllocationCGO/Call-12            436496              2749 ns/op              64 B/op          7 allocs/op
BenchmarkAllocationCGO/Call-12            427888              2754 ns/op              64 B/op          7 allocs/op
BenchmarkAllocationCGO/Call-12            426919              2745 ns/op              64 B/op          7 allocs/op
BenchmarkAllocationCGO/Call-12            435013              2769 ns/op              64 B/op          7 allocs/op
BenchmarkAllocationCGO/Call-12            436152              2771 ns/op              64 B/op          7 allocs/op

PASS
ok      github.com/tetratelabs/wazero/internal/integration_test/vs/compiler     68.776s

Let me know if this matches what you had in mind.

ps if you feel like benchmarking "greeting" is better than "greet", feel free to switch. What I mean is let's keep only one for the allocation example. I don't care strongly which.

ps if you feel like benchmarking "greeting" is better than "greet", feel free to switch. What I mean is let's keep only one for the allocation example. I don't care strongly which.

I don't have any strong opinion, so let's keep the benchmark as it is, it wont be too complex to add a new one when/if it would become a need.

I can try to update the docs before EOW if you want me to.

Epic effort for something that started out with improving example code.
Thanks, and really sorry if I kinda lost track along the way!

@lburgazzoli I raised https://github.com/tetratelabs/wazero/pull/1429 as I think we should get this sorted to avoid a confusing comment chain over a week again. This sort of stuff is cognitively deep and best way I can find is to contain it by time to shortest as possible, as this avoids things like having to cross when people are out for holidays etc.
In general, personally I try to complete everything PR of any kind within a couple days for the same reason, even if not cognitively high. Even small things can get difficult to load back into the brain if drug out over several days, much less weeks, with several people.

@lburgazzoli sorry for just spotting this, I guess I only grasped it when looking at committed code in whole.
But I might be missing something obvious and I'd like to get your understanding before filing an issue/PR.
What keeps message alive (i.e. not available for GC) after stringToPtr returns?
https://github.com/tetratelabs/wazero/blob/9dd8b1b9b3bd9267502440fea1fb2bacc577c58c/examples/allocation/tinygo/testdata/greet.go#L20-L24
I'm wondering if we need to add runtime.KeepAlive(message) after _log.

I'll update tinymem once above is resolved. We do tend to see things like this in syscall code, after the call like https://github.com/golang/go/blob/0d347544cbca0f42b160424f6bc2458ebcc7b3fc/src/syscall/fs_wasip1.go#L824-L829 cc @Pryz @achille-roussel

@lburgazzoli sorry for just spotting this, I guess I only grasped it when looking at committed code in whole. But I might be missing something obvious and I'd like to get your understanding before filing an issue/PR.
What keeps message alive (i.e. not available for GC) after stringToPtr returns?

I completely missed that usage to be honest.

https://github.com/tetratelabs/wazero/blob/9dd8b1b9b3bd9267502440fea1fb2bacc577c58c/examples/allocation/tinygo/testdata/greet.go#L20-L24
I'm wondering if we need to add runtime.KeepAlive(message) after _log.

I think the usage of message is safe, however the implementation of stringToPtr is not as it performs a copy of the string's data but that slice goes out of scope hence the address returned by the function may become invalid if a GC is triggered.
I think the only safest option would be to use stringToLeakedPtr ad free up memory with defer, similar to what it is done in the host code.

KeepAlive

A more unsafe way would be to runtime.KeepAlive the message and return the actual data that backs the string with unsafe.StringData, but there will be dragons :)

Yes, that too. The only additional unsafety to that it's supposed to be read-only, and the host can change it, but the host can always change it, so…

The only additional unsafety to that it's supposed to be read-only, and the host can change it, but the host can always change it, so…

agree the host can always change anything. Doing anything in the guest that makes it seem like it cannot is probably not a good idea. Like adding racing stripes to a Honda, doesn't make it faster. We should make the guest code concise, cheap as possible and most importantly relevant. If the current code isn't really leaking it, or it is more complicated than an alternative to do the same. PR welcome, especially before we communicate widely a change.


Generate modern and legacy bundle with Rollup

Alaska Airlines Pull Request
Closes #43
Closes #41
Summary:
This replaces the current Webpack bundling setup with Rollup. To prevent modern browsers from incurring the cost of legacy polyfills, we generate a modern and a legacy bundle. The modern bundle supports the last two versions of evergreen browsers and the legacy bundle includes polyfills necessary to support IE11. We recommend loading these bundles using differential serving so that a modern browser only downloads the bundle it needs without polyfills.
Instead of attempting to share polyfills between multiple components, we now generate a bundle with all dependencies for each component. For instance, if a consumer wants to use the bundled versions of auro-button and auro-input, each bundle will include its own Lit Element instead referring to a shared file. Consumers who want to optimize their bundle size should bundle the components they use themselves. The baseline size of the modern bundle is 28KB minified, 8KB compressed and the baseline size of the legacy bundle is 241KB minified, 75KB compressed. These sizes reflect the result when bundling a newly-generated component.
The browserslist has also been updated to support these changes.
Type of change:
Please delete options that are not relevant.

[x] New capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Sorry, bolting on a small update request. please update the following (branch is in your fork, can't edit code in review, outside of scope)
In ./bin/generate.js
Line 90: versions['designTokens'] = await latestVersion('@alaskaairux/design-tokens');
Line 21: versions['wcss'] = await latestVersion('@alaskaairux/webcorestylesheets');
In ./template/src/[namespace]-[name].js
Line 12: // import AuroElement from '@alaskaairux/webcorestylesheets/dist/auroElement/auroElement';
/template/src/style.scss
Lines 7-14:
@import "./node_modules/@alaskaairux/design-tokens/dist/tokens/SCSSVariables";
@import "./node_modules/@alaskaairux/design-tokens/dist/tokens/SassCustomProperties";

@import "./node_modules/@alaskaairux/webcorestylesheets/dist/breakpoints";
@import "./node_modules/@alaskaairux/webcorestylesheets/dist/core";

// Support for auroElement styles
// @import "./node_modules/@alaskaairux/webcorestylesheets/dist/auroElement/auroElement";

I successfully updated the tokens and stylesheets, but I'm now having an issue with npm run serve. It's unrelated to the token updates, but I'm investigating that now.

Replaced Polymer CLI with web-dev-server and everything works now (and is blazing fast 😮 )

:tada: This PR is included in version 2.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add missing IDs for Twitter handles

This PR adds missing Twitter IDs only for legislators who already have
a Twitter handle present in the data. I don't know if these are campaign
accounts or not; these are just the IDs for accounts that are already
there.

Thank you merging!


Navbar style

I fix the navbar to be consistent
Fixes #1251

@akshitagupta15june I need a reveiw on this.

@akshitagupta15june is there any reason this repo was closed without a merge?


Trim collection name

Trim the collection name before creating it

Codecov Report

Merging #306 into 2.x will decrease coverage by 2.5%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #306      +/-   ##
==========================================
- Coverage   75.84%   73.34%   -2.51%
==========================================
  Files          39       39
  Lines         770      844      +74
==========================================
+ Hits          584      619      +35
- Misses        186      225      +39

Impacted Files
Coverage Δ

src/services/kuzzleWrapper.js
50.46% <0%> (-1.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7002a...9e11645. Read the comment docs.


NOT annotation filtering behaviour

Re:
If a gene is annotated with a quite general
term (like enzyme), but we also have a more specific annotation (like
ADH) on the same gene that has the NOT qualifier, my code is going to
delete the "enzyme" annotation if it is an IEA, IEP etc.
Solution:
Add a warning to the log files when a NOT annotation results in the filter of another external annotation
Original comment by: ValWood

consider with
https://github.com/pombase/pombase-chado/issues/397

consider with
https://github.com/pombase/pombase-chado/issues/35

We need to rethink this...one for a call I think

What was the rethink?  Do we need to chat about it?

that's a comment from 2014.
I think this will be covered by the website filtering we discussed?

I can't find the active ticket about filtering NOTs on website tracker?

I can't find the active ticket about filtering NOTs on website tracker?

I don't remember discusses NOT filtering on the website.

It was this ticket
which I closed with the instruction
"migrate to chado tracker"
because I think we decided to
Ignore NOTs for slimming purposes
https://github.com/pombase/website/issues/617
I did not open a ticket it seems...
anyway I think I need to rake another look but I'm not  aware with an issue with NOT filtering behaviour on the gene pages....

Ignore NOTs when filtering. Filtering code should not consider NOT annotations.

Ignore NOTs when filtering.

I've made the change to the GO filtering to ignore NOT annotation.  The results will be available on Tuesday morning.


NTP status/widget long IPv6 address. Issue #10307

[ ] Redmine Issue: https://redmine.pfsense.org/issues/10307
[ ] Ready for review

if I have a) an IPv6 NTP server, and b) the NTP status widget on the dashboard, the widget doesn't display the stratum correctly:
NTP Status
Server Time    10:08:58 CST
Sync Source    2620:19:4000:100::86 (stratum )

Also NTP status page shows truncated IPv6 address
from ntpq(1):

 -w, --wide
         Display the full 'remote' value.

         Display the full value of the 'remote' value.
         If this requires more than 15 characters, display the full value, emit
         a newline, and continue the data display properly indented on the next line.

This PR fixes both issues

Applying the patch as-is didn't work, the lines with a long hostname (like pool placeholders) had an empty ref column and other values were shifted over. See my review comment for a much simpler alternative fix.

Testing /usr/local/sbin/ntpq -pnw ' . $inet_version . ' | /usr/bin/tail +3 | /usr/bin/sed \'N;s/\n\s*//;P;D\' I found that it returns only 'oversized', but not 'normal' peer string

Hmm, I saw both. But I did find another system where it failed in a different way. Try this instead:
exec('/usr/local/sbin/ntpq -pnw ' . $inet_version . ' | /usr/bin/tail +3 | /usr/bin/sed -E \'N;s/\n[[:blank:]]+/ /;P;D\'', $ntpq_output);

This solution is still not quite right.  I'm losing the last peer which happens to be the active one.
for example:

results in:

the -pnw full results are something like:


stages/users: accept identical uid for existing users

Accept a uid option for an existing user if it is the existing one. This allows to have the same options for existing as well as new users, which in turn allows for the same blueprint in Composer for new and upgrade OSTree commits. In the latter we pre-fill the password database from a previous commit, which is needed to make sure that uids do not change. Since Composer can't know which of the specified users in the blueprint are new ones or existing ones it cannot easily omit the corresponding stage options. Thus the stage options have to be the same for new and existing users.

That's why you posted links to getpwnam() oddities...

Yea, I was tempted to write a small parser to get the individual fields into a proper struct, but for now this should be fine, I think.

I amended this PR to 1) actually test this in the users stage test and 2) to also ensure a home directory is created in the case when a user without home dir exists and is then modified to have one.


expose dat-doctor

Right now the most frustrating part of Dat is the protocol errors; having a way to debug our protocol from the desktop would be useful.

discussed in the team call on 03/01/2016

https://github.com/joehand/dat-doctor/pull/2

Published the JS API as dat-doctor 1.2.0.

I think for the UI we should perhaps make use of a lil modal that displays the info. Near-black background; something like that?

We could use https://gist.github.com/maxogden/5953535 for a fancy thing; devtools for an MVP (:

check out https://github.com/datproject/dat-desktop/pull/128 for a devtools MVP

shall we consider this done and open an issue on a future milestone for a nicer UI version?

Sounds good!


new results

I changed the figures in the devito part to more recent and pretty ones.
RTM is changed to FWI (actually ran with Julia but can redo it with pure devito)
Dual shot is nicer.

YES

Awesome, yes! Merging...


me.minidigger.voxelgameslib.exception.UserException in NormalResolver.java:22

Error in VoxelGamesLib
me.minidigger.voxelgameslib.exception.UserException in NormalResolver.java:22
Unknown user MiniDigger
View on Bugsnag
Stacktrace
NormalResolver.java:22 - me.minidigger.voxelgameslib.NormalResolver.lambda$getContext$0

View full stacktrace

An error linked to this issue has been marked as fixed in Bugsnag
me.minidigger.voxelgameslib.exception.UserException in NormalResolver.java:22