Universal sshkey and password manager script

Description
This PR adds a bash script file that manages sshkey and password from userdata server and configdrive sources

At first, the script tries to find a configdrive CD, if it is found, it will mount the CD and search for ssh key and password.
If both ssh key and password were found, the script will try to set ssh key and password, else it will search for the userdata server.
Finding a userdata server (DHCP server) is a little bit tricky.
First of all the script tries to find the default gateway, so it can determine the default nic. It is important to find default nic because CloudStack only provides passwords from default nic.
Script test existence of different commands to figure out default gateway: ip, netstat, route (GNU & BSD)
If not default gateway was found, the script will fall back to the "data-server" DNS record.
After finding the default gateway and default nic, the script will try to find the latest DHCP server IP for that nic by using available commands or analyzing lease files.
If OS is using netplan, the script can directly ask for the DHCP server address.
If OS is using nmcli, the script can use the "next_server" field for the DHCP server address.
If OS is using wicked, the script can find the DHCP server address from the lease file.
Otherwise, the script will search in a list of possible directories that lease files may exist. Then aggregate all lease records files and histories and filters records that have "option routers" (Only default nics has this parameter)
Then the script will create a list consist of lease expiration time, interface, and DHCP server address.
The script will filter only records from default nic and pick the one which has the greatest timestamp.
So the DHCP server address will be found this way. If the script was not able to find the DHCP server address, it will fall back to the "data-server" DNS record.
Then the script will ask for ssh key and password from the userdata server, then it will set ssh key and password.
To prevent setting password from configdrive each time that script runs, we will store the md5 hash of the password in the user home directory (with appropriate permissions) and examine if it is changed or not.
This script is a bash script (so bash must be installed) and using curl (instead of wget) to communicate with the userdata server.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

How Has This Been Tested?

Tested on these operating systems:
CentOS 7
CentOS 8
Ubuntu 20.04
Ubuntu 18.04
Ubuntu 14.04
FreeBSD 12.2
openSuse 15.2
Tested for Userdata server and ConfigDrive separately and simultaneously
Tested for multihomed VM with DHCP enabled networks
Tested with cloud-init as a per-boot script

thanks for this @aleskxyz . looks ok.
Have you no non-linux clients to test? ;)
And can you please add an Issue or add more functional description to the PR?

thanks for this @aleskxyz . looks ok.
Have you no non-linux clients to test? ;)
And can you please add an Issue or add more functional description to the PR?

@DaanHoogland
I don't get your point about non-linux client, but it is tested on FreeBSD
I have updated the description about functionality of the script.
Regards

Thanks, we need some manual test/confirmation and a doc PR to https://github.com/apache/cloudstack-documentation explaining how to use this.

Thanks, we need some manual test/confirmation and a doc PR to https://github.com/apache/cloudstack-documentation explaining how to use this.

@rhtyd
I'm working on it.

Hi @aleskxyz is this PR ready for review/test?

Hi @aleskxyz is this PR ready for review/test?

Hi @nvazquez
Yes it is ready for test/review.
Support for getting userdata address from Alpine needs a script in hook directory of udhcpc.
I put the commands here but I'll open a PR in documentation repository.
# Create DHCP post-bound hooks directory
mkdir -p /etc/udhcpc/post-bound

# DHCP hook to export DHCP server IP
echo 'echo $serverid > /run/dhcp-server-ip.$interface' > /etc/udhcpc/post-bound/dhcp-server-ip
chmod +x /etc/udhcpc/post-bound/dhcp-server-ip

I think we can remove these files because the script can be replaced with them:
cloud-set-guest-password-configdrive.in
cloud-set-guest-password.in
cloud-set-guest-sshkey-configdrive.in
cloud-set-guest-sshkey.in

If you are agree, I can remove them in the next commit on this PR

Thanks @aleskxyz sorry for the delayed response. I think the new script could only replace the '-configdrive' scripts but would like @weizhouapache's opinion as well. @weizhouapache can you please manually test this PR?

Thanks @aleskxyz sorry for the delayed response. I think the new script could only replace the '-configdrive' scripts but would like @weizhouapache's opinion as well. @weizhouapache can you please manually test this PR?

@nvazquez
If you investigate the userdata scripts you can see that they are not complete.
The cloud-set-guest-sshkey.in script only supports distributions that using dhcp lease file.
The cloud-set-guest-password.in script don't care about default network so you may don't get password in case of multi homed VM configuration.
Also they are using wget for getting data from userdata server which is not available by default in many distros.
I have addressed all of these problems in this PR

@aleskxyz @nvazquez
I have tested the scripts, it works well in most test cases.
@aleskxyz I left two comments, please have a look.

Ping @aleskxyz

@rhtyd @weizhouapache
Sorry for late reply and thank you for reviewing.
I have committed new changes.
Regards

@aleskxyz If you're going to remove it, please check and fix the docs too https://github.com/apache/cloudstack-documentation

@aleskxyz If you're going to remove it, please check and fix the docs too https://github.com/apache/cloudstack-documentation

@rhtyd Ok but I think it is better to merge this PR first. I may need to change it.
https://github.com/apache/cloudstack-documentation/pull/215


Extend any field - Maybe

I don't know if it's possible, but extend every field by blueprint:
type: reveal
extend: select

class revealField extends {$extend} {
}

Will not be implemented


Put cells into windows, add tabs

There should actually be a set of tabs in between the top-bar and the current file, with different open file names inside.

Cells are now in windows, still need to add tabs :)


More work towards a serenity application in jakt

Continuation of #1472.

This is good enough to get the toolchain in https://github.com/SerenityOS/serenity/pull/20765 working, so let's call it ready for review.

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

YOLO, let's just merge it.


Suggestion | Change folder name

It would be nice if parts of the folder structure would be redesigned. So "res" renamed in "images" and the parts of the images for the ui could be putted in a new folder called "images\ui". All for a better usabilty.

In the current codebase there won't be a change in the structure.
Reason is, that I'm already working on a rewrite of the whole code of the mission beside of the normal work on Liberation.
It's currently not on a repo on GitHub, but here is the part from the readme, which fit to your suggestion:
Goal

Modular and therefore much cleaner structure
More streamlined code
Performance improvements due to code optimizations
Easier ways to debug
Easier ways to add additional gameplay aspects due to the modular framework
There should be no need to do any additions in any mission.sqm (removing would be ok)
Personally: Using this project to get more familiar with SQF and the Liberation mission itself than before

Conventions

Global variable naming: KPLIB_moduleName_variableName

moduleName: The name of the module like init or if it is kind of a global category like preset or param
variableName: Name of the specific variable like heavySquad or adaptiveEnemy
Only some very rare variables have no moduleName, as they are not directly connected to a module. Example KPLIB_milAlphabet

Function naming: KPLIB_fnc_moduleName_functionName (same rules like for the variables)
CfgFunctions Framework

KPLIB_functions.hpp in missionroot as central fetching file
Each module has an own functions.hpp which is included by the KPLIB_functions.hpp

Modular structure

Naming for modules: loadOrderNumber_moduleName like 0_init or 1_core
Each module will handle one aspect of the game. For example the initialization, core mechanics, enemy spawn, civil reputation, etc.
General structure:

fnc folder for functions and one-time-procedures
scripts folder for the scripts (so basically everything which runs a loop through the whole session)

Seperation (if even needed) with a server, client, shared folder

ui folder for all dialogs or ui defines which are brought or needed by that module
functions.hpp to define the functions of this module
globals.sqf to define all global variables which are brought or needed by that module and aren't defined before
initModule.sqf which is called by all machines and where possible seperation for clients/HCs/Server will happen
ui.hpp to define the ui elements and dialogs from this module (will be included by the KPLIB_ui.hpp in the mission root)

OK. Sounds nice.


Instructions for recent versions of gradle

If you are using gradle plugin version > 3.0 (which requires gradle v. > 4.0 (?)), then the following line from the readme will not work:
compile 'org.greenrobot:eventbus:3.1.1'
Instead, you must use api
api 'org.greenrobot:eventbus:3.1.1'
If you use compile or implementation, your project will compile but gradle will not be able to load event bus from the classpath during runtime. api tells gradle to keep the lib on the classpath.

Is this an issue with documentation? Would you like to see the docs to include info for each version of gradle?

Using implementation should work just fine. Doing that in various projects.
Updated the README file.
-ut


bug: shapeshift imports fast-deep-equal wrong breaking it

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
when you use type module in package.json
shapeshift imports fast-deep-equal as
import fastDeepEqual from "fast-deep-equal/es6";
breaking it
changing the code to
import fastDeepEqual from "fast-deep-equal";
fixes it.
Steps To Reproduce
set the type to module
Expected behavior
it shouldnt crash
Screenshots

Additional context
No response

#155 will fix it


ion-slides missing lazyLoading, lazyLoadingInPrevNext and grabCursor options of swiperjs

Ionic version:  (check one with "x")
[ ] 1.x
[X] 2.x
I'm submitting a ...  (check one with "x")
[X] bug report
[ ] feature request
[ ] support request
Current behavior:
ion-slides removed the options input in RC-5 without exposing alternative attributes for lazyLoading, lazyLoadingInPrevNext and grabCursor
Expected behavior:
expose lazyLoading , lazyLoadingInPrevNext and grabCursor attributes
Cordova CLI: 6.5.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: macOS Sierra
Node Version: v6.10.0
Xcode version: Xcode 8.2.1 Build version 8C1002

Hello, thanks for using Ionic. I am going to close this issue as a duplicate of https://github.com/driftyco/ionic/issues/10199.

@jgw96 it's not a duplicate as these options are not (yet) exposed by the new ion-slides implementation, #10199 is closed but the issue persists


Test lab SOPs

As a Webb group team member (e.g working in October)
I want to be able to use the SOPs without any changes or questions
so that everyone does the same protocol safely

Validation run will be on 19th/20th September @KirstyCooper @conorg150


INotebook.getMatchingInterpreter is returning the wrong interpreter

The method getMatchingInterpreter returns the wrong interpreter information.
Can easily repro this issue, just turn off auto start and debug the code.
Could contribute to other issues as well, basically we're not using the right interpreter associated with a kernel/notebook.
E.g. modules not found (ipykernel, pandas), etc

Validated


How to handle cyclic case?

I want to inject DepTwo with DepOne, and DepOne with DepTwo, what should I do instead?
use std::sync::Arc;

use nject::{injectable, provider};

#[injectable]
#[derive(Debug)]
struct DepOne {
    dep: Arc<DepTwo>,
}

#[injectable]
#[derive(Debug)]
struct DepTwo {
    dep: Arc<DepOne>,
}

#[injectable]
#[derive(Debug)]
struct Facade {
    dep: Arc<DepTwo>,
}

#[provider]
#[provide(Arc<DepOne>, |two: Arc<DepTwo>| Arc::new(DepOne { dep: two }))]
#[provide(Arc<DepTwo>, |one: Arc<DepOne>| Arc::new(DepTwo { dep: one }))]
#[derive(Debug)]
struct Provider {}

fn main() {
    let _facade: Facade = Provider {}.provide();
    println!("{:?}", _facade.dep.dep.dep);
}

Currently overflows the stack.

Hi @stevefan1999-personal,
If you had to manually inject the Facade, how would you do it?


test new TOCs

testing new TOC architecture

Deploy preview for calico ready!
Built with commit b0272677022de2280930504d96bf49cd30c668ba
https://deploy-preview-3005--calico.netlify.com


fix all inlay hint command

Thanks for the report. Unfortunately, this is not enough information for us to investigate this issue.
If this continues to be a problem, would you please reopen the issue and add the information described in the troubleshooting guide?


Add support F field

Please add after: case "M": return DbfColumnType.Memo;
case "F": return DbfColumnType.Number;

This seems to have been added in https://github.com/SocialExplorer/FastDBF/commit/b32ed0781d3fc88388146fe7ed2b6267aba89d01

I dont know where to post this, i used a old version and i updated today, but i cannot dind how to get a memo field, i used the function GetMemField, is another new function or other method?
Best regards.


vNext Boundray Visualization Profile should not hide materials if a setting is disabled

Overview
Boundary visualization components can be shown or hidden at any time during the lifespan of an application. Currently, the boundary visualization profile hides settings from the developer when a component is not configured to be shown, though the data is persisted regardless of the setting for "Show".
This results in the user having to check, configure and uncheck any visualization that MAY be desired by the application.... a tedious at best process.
The fix is to ignore the state of "Show" and always display visualization settings.

Agreed, we shouldn't be hiding the materials in the boudnary viz profile.

As part of this change, I will be adding tooltips to the profile as well.


Remove ImportHintKind::Reference

The only place in the Clang Importer that needs to deal with anything
related to C++, and it doesn't actually do anything.  Remove the
import hint and the last place where the importer creates InOutTypes
as well.

@swift-ci please test

@rjmccall The blame shows you were the last one to touch this codepath, but even then it was just shuffling some code around.  Can you remember what this is for?

@swift-ci please test source compatibility

Source compatibility failures are unrelated.
:boat:


better Readme

Describe the feature
"A faster, secure and convenient alternative for JSON.parse.".
It will be interesting versus other JsonParser ...
I dont want to search all tool (maybe twenty) who suggests the same thing (and the latest lol) ...
I have no interest by this package because already 20 or more package do the "same" things and i dont know wich is the best :o .... and why this package is so special ?
Additional information

[ ] Would you be willing to help implement this feature?

Hi. You can yourself check the benchmarks and also feature parity for comparative. I guess non of them (at least by the time of making this package focuses on supporting edge case handling in addition to security and performance part nor supported ESM build. If you found something to improve docs, PR is more than welcome 👍🏼

When I saw "faster" than JSON.parse in repo description I expected to see in sources string parsing implementation (that should beat default JSON.parse)... but when I opened it I saw JSON.parse in it :D
Then I thought how it can be faster than if it does JSON.parse + additional logic. I think it is a bit not clear. Most likely "faster" means for cases when data is from a set of short known dictionary values

Yes, we kinda mentioned this in each section with numbers also here:

In the other words, destr is better when input is not always a json string or from untrusted source like request body.

Still feel free to make a PR to improve working from readme :)

Closing for maintenance (pr always welcome!)


chore(docz-core): copy .eslintignore from project

Description
Gatsby has an Eslint plugin by default. It is run when we start the project. However, the cwd is at that time the .docz folder. Hence, if we add an .eslintignore in our project, it is not picked up. This add a build step to copy the file into the .docz folder if it exists.
Side note, I didn't understand what is the purpose of the function above, writeEslintRc, as it has an effect only in the Docz repository..

Looks good !
I think writeEslintRc is because of the previous docz development setup that required the cli to behave differently when in the docz codebase.


Use all surrogates in bench_ml.py

Codecov Report

Merging #345 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   84.97%   85.05%   +0.07%
==========================================
  Files          22       22
  Lines        1338     1338
==========================================
+ Hits         1137     1138       +1
+ Misses        201      200       -1

Impacted Files
Coverage Δ

skopt/acquisition.py
97.36% <0%> (+1.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddc574...f1d1d97. Read the comment docs.

Thanks! Could you also add the results if you have the time.
Could you also provide a random state parameter to MLBench and use that random state to do things:

The train test split.
And also fix the random state if the model has a random state parameter in the constructor over here (https://github.com/scikit-optimize/scikit-optimize/blob/master/benchmarks/bench_ml.py#L214)

(It was my mistake that I removed the random state, and it might be better to assume that the black-box function is non-noisy for reproducible results)

Yup, will fix.
As for the benchmark results, somehow http://archive.ics.uci.edu/ml/ is down. I will see where else I could get the data.

I removed
from urllib.parse import quote
from urllib.request import urlopen

as the imports are not used. Let me know if this breaks anything (seems to work fine without them).

Benchmark seems to work fine now. I will update this pull request with results as soon as I will have them.

First results with GP are there. However, I cannot use GradientBoostingQuantileRegressor and ExtraTreesRegressor for default values of the parameters of Optimizer, as it throws an exception (that predict does not have return_mean_grad parameter). I will set  acq_optimizer='sampling' for now, I assume that is what Optimizer is intended to do anyway.

Currently I have results for GaussianProcessRegressor and ExtraTreesRegressor. I do not have results for GradientBoostingQuantileRegressor due to #348 . Maybe we just start with these results, and add results for the missing surrogate later.
I also have logs of the optimization procedure, from which one can extract performance for some particular configurations of the dataset / model / surrogate. I currently have them in the repository, but plan to move the data to my own storage until it is needed, unless you have a better idea.

Suggestion: instead of passing the surrogate models, would it be possible instead to iterate over the functions gp_minimize, forest_minimize, gbrt_minimize, etc? The advantage is that these functions have been configured internally with good defaults for the surrogate models. Using instead the Optimizer class with its current interface leads to having to reproduce the logics of putting good defaults, which we should try to avoid.
This connects to #338
What do you think?

@glouppe Yeah should be doable. Especially if you say that the parameters are optimized for these functions, then of course it makes a lot of sense.
Personally I like "ask-tell" interface more because it is in my experience more flexible. Maybe it would be a good idea to have something like GPOptimizer class, where one does not need to configure the surrogate models, yet retaining the flexibility of Optimizer class.

Or maybe just transfer the parameters from the gp_minimize to default parameters of corresponding surrogate, in case this is sufficient.

Results are coming today or latest tomorrow. I will commit all the changes to the code together with new results (using cross entropy and using x_minimize methods).

I updated the readme with new results. Maybe I also calculate f_calls metrics; While I agree that the results rather represent average over many benchmarks rather than one benchmark, it might still be useful for comparison of algorithms.

Hmm I realized that I run the benchmark with n_calls = 50, while it should be 200. I will re - run the benchmark.

50 calls are okay. I am fine with merging this as is.

Do we need the jsoin files?

Looks fine. Thanks for your work. Bit surprised GBRT minimize beats the others for regression!

I am happy if you merge this as is. I will make PR if the results that I get with 200 calls are drastically different.
Thank you for reviewing my code!
Indeed it is surprising that GBRT beats everything else.

🌳  for lyfe! Thanks for the contribution and reviewing!


rootless: detect user namespace configuration changes

detect if the current user namespace doesn't match the configuration
in the /etc/subuid and /etc/subgid files.
If there is a mismatch, raise a warning and suggest the user to
recreate the user namespace with "system migrate", that also restarts
the containers.
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

LGTM assuming happy tests.

Code LGTM

/lgtm


help: Document default language for new users setting.

As discussed in this CZO thread, this PR adds a link to the Configure organization language page since this org setting doubles as the default language for new users.
Screenshots and screen captures:

https://chat.zulip.org/help/configure-default-new-user-settings

The placement of this in the doc implies that default language can be configured via "default user settings" -- except it's in a different place entirely.  We should call out new user default language as a setting which is not set via that location, and link to how to set it.

Closing in favor of #27192.


LIFX services result in 'LIFXColor' object has no attribute 'device'

Home Assistant release with the issue:

0.77.1
Last working Home Assistant release (if known):
0.76.2
Operating environment (Hass.io/Docker/Windows/etc.):

Hass on Docker
Component/platform:

https://www.home-assistant.io/components/light.lifx/
Description of problem:
Executing any LIFX service results in error that I've included in Additional Information. I have tested all three services on multiple bulbs (lifx_color_loop, lifx_effect_pulse, lifx_effect_stop)
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
light:
  - platform: lifx

Traceback (if applicable):

Additional information:
2018-08-29 19:16:50 ERROR (MainThread) [homeassistant.core] Error executing service <ServiceCall light.lifx_effect_colorloop (c:c7a0b98181894b25b47e1b3b271c596a): entity_id=['light.bathroom_1'], power_on=True>
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/core.py", line 1117, in _event_to_service_call
    await service_handler.func(service_call)
  File "/usr/src/app/homeassistant/components/light/lifx.py", line 243, in service_handler
    entities, service.service, **service.data)
  File "/usr/src/app/homeassistant/components/light/lifx.py", line 259, in start_effect
    devices = [light.device for light in entities]
  File "/usr/src/app/homeassistant/components/light/lifx.py", line 259, in <listcomp>
    devices = [light.device for light in entities]
AttributeError: 'LIFXColor' object has no attribute 'device'

Thanks, acknowledged. This seems to be the result of a bad search/replace reorganization job.

Thanks @amelchio! I'll roll back to 6.2 in the meantime


Does mkdocs-monorepo-plugin still work with mkdocstrings?

I recently had mkdocstring and mkdocs-monorepo-plugin working on a monorepo that was using both sphinx and google style docstrings but now the google style docstring are not rendering properly and only the sphinx docstrings render correctly with the tables.
I can't pinpoint which commit broke this yet.
Has anyone run into any bugs using mkdocs-monorepo-plugin and mkdocstrings? Specifically, using two types of docstring styles in one codebase (e.g. google style and sphinx).

Hey @jgarte I am working on mkdocs mono repo plugin and mkdocstrings do you have any references for me so that both can work together. I am trying to integrate them but the docstrings are not loaded when we check then in the parent/centralised repo.
It shows like ::: scripts.apps


Create a rewrite_between() function

(fixes #2)

@paul-nelson-baker, what are your thoughts on this?
I've just sketched out an idea for how I'd approach the "rewrite everything between X and Y" problem, but haven't tested that it actually works yet.

It works PERFECTLY!
My prototype needs to be refactored, badly, but here I was able to get this to work exactly as I was hoping for!
I was able to write a closure that operates on the opening and closing codeblock fences and then parse and rewrite the contents of the actual codeblock.


HW1: Added project and contribution descriptions in markdown files. Updated proposal markdown file accordingly.

Finished HW1!

Did not yet come up for a name for my personal project or create a repo for it.

Unsure if I or you are the one who should resolve the conversations after the commit that addresses requested changes. Please let me know!

lgtm


Authentication Token Error

I have upgraded to the latest GAM release from https://git.io/gamreleases and I still have this issue.
I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki
Full steps to reproduce the issue:

Open Powershell
Type "C:\gam\gam user sadmin signature "hallo"" or  "C:\gam\gam user sadmin vacation on subject "hallo" message "hallo""
Error Message: "ERROR: Authentication Token Error - unauthorized_client: Client is unauthorized to retrieve access tokens using this method."

Expected outcome: I wanted to change the signature
Actual outcome: ERROR: Authentication Token Error - unauthorized_client: Client is unauthorized to retrieve access tokens using this method.
Some more background: I'm using GAM on a regular basis, and, until yesterday, it worked fine. Now, yesterday we tried to set up GAM for a customer, with reduced rights to just be able to access the mail API's. Here, I first saw this error message.
Now today I tried to use my usual GAM Account (all API Accesses granted), wich I used to create signatures and thelikes countless times, and got the same error message, when I tried to write a script to create signatures.
gam version shows the following:
GAM 4.02 - http://git.io/gam
Jay Lee<EMAIL_ADDRESS>Python 2.7.12 64-bit final
google-api-python-client 1.5.2
Windows-8.1-6.3.9600 AMD64
I then head to the release page, and downloaded the up to date version of gam, so version is now showing this:
PS X:> C:\gam\gam version
GAM 4.12 - http://git.io/gam
Jay Lee<EMAIL_ADDRESS>Python 2.7.12 64-bit final
google-api-python-client 1.6.1
Windows-8.1-6.3.9600 AMD64
Path: C:\gam
And I still get the same error message.
Any ideas?

What does
gam user  check serviceaccount
Show?

Sorry:
gam user (email) check serviceaccount

Ok, that did it, I somehow missed that change, thanks!


Meson

Ditch the hacky Makefile for meson.

@eddiejames

I've been making a lot of use of this while I've been hacking on devicetree support, so merging (hopefully a better effort than the --quiet patch).


HSVA and RGB textboxes are not visible in default style

a certain someone hardcoded a color

lel what are you doing at 2am


Use case tutorial: Read from remote WorldIDManager

Hey team! Please add your planning poker estimate with Zenhub @aesedepece @gabaldon @guidiaz @aeweda


[Bug] Running the test runner against a Storybook server using self-signed SSL certs fails

Describe the bug
When using SSL with a self-signed certificate to run the development server, the test runner (with at least the Chromium browser) will reject the SSL connection, probably because it fails to validate the CA signing the certificate (that's my educated guess).
The test runner needs an option to either inject the root CA into the running instance of the browser, or disable verifying SSL certificates when connecting through HTTPS.
Steps to reproduce the behavior
To test this, generate a CA cert and a corresponding domain certificate. For convenience, I've added two bash scripts to generate the CA and domain wildcard self-signed certs to enable SSL. Not that you will need to add the root.pem certificate to your trusted root CA store in order to be able to use certificates generated by this CA.
generate-ca
#!/bin/bash

set -eu

ROOT_DIR=$(dirname $0)
BUILD_DIR="$ROOT_DIR/build"

mkdir -p "$BUILD_DIR"

openssl genrsa -out "$BUILD_DIR/root.key" 2048
openssl req -x509 -new -nodes -key "$BUILD_DIR/root.key" -sha256 -days 365 -out "$BUILD_DIR/root.pem"
openssl x509 -text -noout -in "$BUILD_DIR/root.pem"

generate-domain-cert
#!/bin/bash

set -e

ROOT_DIR=$(dirname $0)
BUILD_DIR="$ROOT_DIR/build"

ROOT_CERT="$BUILD_DIR/root.pem"
ROOT_KEY="$BUILD_DIR/root.key"

if [ ! -f "$ROOT_CERT" ]
then
  echo "Root certificate not found! Use generate-ca to generate a root CA certificate"
  exit 1
elif [ ! -f "$ROOT_KEY" ]
then
  echo "Root certificate key not found! Use generate-ca to generate a root CA certificate"
  exit 1
fi

if [ "$1" = "" ]
then
  echo "You must provide a FQDN name, e.g. ./generate-domain-name domain.name"
  exit 2
fi

DOMAIN_NAME="$1"
DOMAIN_DIR="$BUILD_DIR/$DOMAIN_NAME"

mkdir -p "$DOMAIN_DIR"

DOMAIN_KEY="$DOMAIN_DIR/wildcard.key"
DOMAIN_CERT="$DOMAIN_DIR/wildcard.crt"
DOMAIN_CSR="$DOMAIN_DIR/wildcard.csr"
DOMAIN_CONFIG_NAME="$DOMAIN_DIR/config.cnf"

openssl genrsa -out "$DOMAIN_KEY" 2048

cat <<EOF > "$DOMAIN_CONFIG_NAME"
[req]
distinguished_name = req_distinguished_name
req_extensions = v3_req
prompt = no
[req_distinguished_name]
CN = $DOMAIN_NAME
[v3_req]
keyUsage = nonRepudiation, digitalSignature, keyEncipherment
extendedKeyUsage = serverAuth
subjectAltName = @alt_names
[alt_names]
IP.1 = <IP_ADDRESS>
DNS.1 = localhost
DNS.2 = *.localhost
DNS.3 = $DOMAIN_NAME
DNS.4 = *.$DOMAIN_NAME
EOF

openssl req -new -out "$DOMAIN_CSR" -key "$DOMAIN_KEY" -config "$DOMAIN_CONFIG_NAME"

openssl x509 -req -in "$DOMAIN_CSR" \
-CA "$ROOT_CERT" \
-CAkey "$ROOT_KEY" \
-CAcreateserial \
-out "$DOMAIN_CERT" \
-days 365 \
-sha256 \
-extensions v3_req \
-extfile "$DOMAIN_CONFIG_NAME"

openssl verify -CAfile "$ROOT_CERT" "$DOMAIN_CERT"

openssl x509 -text -noout -in "$DOMAIN_CERT"

Run the scripts:
./generate-ca
./generate-domain-cert mydomain.com

Make sure that mydomain.com resolves to the IP of the machine running the Storybook server.
Then run the Storybook dev server together with the test runner:
concurrently -k -s first \
  "start-storybook -p 6006 -h mydomain.com --https --ssl-ca ./build/root.pem --ssl-cert ./build/mydomain.com/wildcard.crt --ssl-key ./build/mydomain.com/wildcard.key" \
  "wait-on tcp:6006 && STORYBOOK_URL=https://mydomain.com:6006 yarn test-storybook"

Verify that the Storybook is reachable by issuing CURL or by opening the URL in a browser (this verifies your system trusts the root CA cert you've generated):
curl https://mydomain:6006/

The test runner fails when trying to run tests:
$ yarn run test-storybook
yarn run v1.22.17
$ test-storybook --url "${STORYBOOK_URL:-https://mydomain.com:6006}"
[test-storybook] It seems that your Storybook instance is not running at: https://mydomain.com:6006/. Are you sure it's running?

If you're not running Storybook on the default 6006 port or want to run the tests against any custom URL, you can pass the --url flag like so:

yarn test-storybook --url http://localhost:9009

More info at https://github.com/storybookjs/test-runner#getting-started
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Expected behavior
The CURL should respond with HTML (as a sanity check) and the test runner should be able to run the tests.
Environment

OS: Debian
Node.js version: v16.13.0
NPM version: 8.1.3
Browser (if applicable): Chromium

Thanks to your excellent reproduction instructions above, I was able to dig in a bit and I think I found a solution.  It turns out it wasn't playwright causing the error, but node itself.
FetchError: request to https://mydomain.com:6006/ failed, reason: self signed certificate in certificate chain
    at ClientRequest.<anonymous> (/Users/ianvs/code/experiments/https-test-runner/node_modules/node-fetch/lib/index.js:1491:11)
    at ClientRequest.emit (node:events:394:28)
    at TLSSocket.socketErrorListener (node:_http_client:447:9)
    at TLSSocket.emit (node:events:394:28)
    at emitErrorNT (node:internal/streams/destroy:193:8)
    at emitErrorCloseNT (node:internal/streams/destroy:158:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  type: 'system',
  errno: 'SELF_SIGNED_CERT_IN_CHAIN',
  code: 'SELF_SIGNED_CERT_IN_CHAIN'
}

From the small bit of research I did, it seems like the best solution (based on https://stackoverflow.com/a/45088585/1435658) is to run:
NODE_TLS_REJECT_UNAUTHORIZED=0 npm test

This keeps tls protection enabled in general, and disables it only for that one command.  If anyone knows of a better solution, I'd love to hear it.

That sounded promising, but as I tried this, it doesn't work, same error. This makes sense, since I've added the generated root CA certificate to my system's trusted certificate store, but the browsers and Node don't automatically pick them up when initialising.
I've gotten Node to correctly pick up the trusted root CAs by passing in --use-openssl-ca as an argument, but the Playwright browser requests fail, as expected:
node --use-openssl-ca ./node_modules/.bin/test-storybook --url https://mydomain.com:6006

I would really like to find a way to pass on the trusted CAs on to the rest of the browsers, but I would settle for a fallback that ignores SSL errors. It seems that the test runner should expose a setting to disable that:

https://github.com/microsoft/playwright/issues/4785

We need to forward the IgnoreHTTPSErrors in the BrowserNewContextOptions constructor, but I couldn't find the injection point in this codebase for it. Also, since this tool doesn't use @playwright/test, these docs are a bit moot:
https://playwright.dev/docs/api/class-testoptions#test-options-ignore-https-errors
I couldn't find any related function in the current Playwright preset, though, so maybe migrating to the recommended test runner would be better?

I'm trying to run this on Debian where according to some sources Playwright-spawned browsers have their own certificate store separate from the OS', including Node, hence the use of --use-openssl-ca. Maybe the behaviour is different on Mac? Haven't tried that yet, as it's not my primary dev environment.


Reland: Migrate examples to the Android embedding v2

Once https://github.com/flutter/cocoon/pull/509 is merged and rolled out, then this change can be relanded.

LGTM! Fingers crossed

@godofredoc Let me know when it's safe to merge.

Thanks @godofredoc!

\o/

Seems like we're safe here. Thanks for all the debugging @godofredoc and @blasten

This broke building of flutter_gallery with local engine:
$FH/flutter/bin/flutter run -v --local-engine android_debug_unopt
...
[  +99 ms] > Task :app:compileDebugJavaWithJavac FAILED
[        ] $FH/flutter/examples/flutter_gallery/android/app/src/main/java/io/flutter/demo/gallery/MainActivity.java:7: error: cannot find symbol
[        ] import androidx.annotation.NonNull;
[        ]                           ^
[        ]   symbol:   class NonNull
...
[   +1 ms] The built failed likely due to AndroidX incompatibilities in a plugin. The tool is about to try using Jetfier to solve the incompatibility.
[   +4 ms] ✏  Creating `android/settings_aar.gradle`...
...
                     FAILURE: Build failed with an exception.

                     * Where:
                     Initialization script '$FH/flutter/packages/flutter_tools/gradle/aar_init_script.gradle' line: 50

                     * What went wrong:
                     Local engine isn't supported when building the plugins as AAR. See: https://github.com/flutter/flutter/issues/40866

...

Is it safe to revert while the failures being investigated?

@blasten adding gradle dependencies temporarily to the gallery and pointing to it as manual instructions for other projects while we wire this up with POMs seems reasonable.


add stdeb and publish-python configuration files

Add configuration files for stdeb and publish-python in order to publish colcon-meson as a Debian package. This is required to eventually build meson packages on the ROS build farm.

ping @nuclearsandwich

I put a ✔ on. @cottsay and myself both have access to the colcon apt repository but we don't have the ability to add any other maintainers right now. I think I mentioned previously that he and I can assist with pushing debs to the apt repository in order to keep things unblocked while we sort out getting you direct access.
As an independent matter, if you would like the colcon core team to be able to make releases to PyPI, you can invite nuclearsandwich and cottsay as additional maintainers. This isn't something we expect to use with frequency but is something to do at your discretion if you'd like the colcon core team to be able to push maintenance releases into new distributions or a significant breaking change in colcon-core or another colcon package requires changes in colcon extensions while the primary maintainers are unreachable for an extended period of time.

Thanks, @nuclearsandwich. I squashed your commits into one that makes meson a hard dependency for Ubuntu 22.04.

As an independent matter, if you would like the colcon core team to be able to make releases to PyPI, you can invite nuclearsandwich and cottsay as additional maintainers.

Done. I invited both of you.


add support for emoticons in dialogs

now you can add images to dialog, but it requires to give path to image very time.
So it should be easier way to do that.
I think add new type emoticon and new markup for it in text passer.
Example:
Rakugo.emoticon("smile", "res://path/to/smile.png")
# then in dialog:
[:smile:]

done in #127 https://youtu.be/0pd6tZNppK4


Add Web Assembly support

While the CLI would not be able to be moved to Web Assembly, we could easily move the library to web assembly which would allow us to utilize haml-rs in the browser.

This has been put in its own repo: https://github.com/Haml-rs/hamlrs-wasm


Node upgrade to version 23.10.2 is out of sync

Show logs:
2023-12-20 09:49:08.309+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:13.309+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:18.310+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:23.310+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:28.310+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:33.311+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:38.311+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:43.312+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:48.312+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:53.313+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:49:58.313+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:03.314+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:08.314+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:13.315+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:18.315+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:23.315+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:28.316+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:33.316+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:38.317+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:43.317+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:48.318+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:53.318+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:50:58.318+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:03.319+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:08.319+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:13.320+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:18.320+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:23.321+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
2023-12-20 09:51:28.321+00:00 | EthScheduler-Timer-0 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 0 peers for usefulness
Where can I get peer node information?

Hi there - thanks for the report. can you share your besu configuration or command line parameters with me?

Hi there - thanks for the report. can you share your besu configuration or command line parameters with me?

#!/bin/bash
if [ ! -f /cnx/genesis.json ];then
cat << EOF > /cnx/genesis.json
{
"config" : {
"chainId" : 1338,
"berlinBlock" : 0,
"qbft" : {
"blockperiodseconds" : 15,
"epochlength" : 30000,
"requesttimeoutseconds" : 30
}
},
"nonce" : "0x0",
"timestamp" : "0x58ee40ba",
"gasLimit" : "0x47b760",
"difficulty" : "0x1",
"mixHash" : "0x63746963616c2062797a616e74696e65206661756c7420746f6c6572616e6365",
"coinbase" : "0x0000000000000000000000000000000000000000",
"alloc" : {
"4141a85CF08F47dE4fEf04d4b35dB42a6e35c7cc" : {
"balance" : "500000000000000000000000000"
}
},
"extraData" : "0xf87aa00000000000000000000000000000000000000000000000000000000000000000f8549435cb9f213251fb182bf0b0252b31b5c36d3fe12594577e9b3bc4f35753e5d9bb69ded0e0aaefb4093294481864112157343e1947020ad6ec7f6352c2d38d94243660ea76cac209a4d08ee32c4cdbd42805dc76c080c0"
}
EOF
fi
cd /usr/local/besu-$VERSION/bin
./besu --data-path=/cnx --genesis-file=/cnx/genesis.json --host-allowlist="*" --rpc-http-cors-origins="all" --rpc-http-host=<IP_ADDRESS> --bootnodes=enode://391b430b502e3a2306c69618535ee55d5915fbf9a32fc7d2284c710010b46e2aa555265e72a106641504a37ab8e2c0893ccd75ef7df5405fdcd8b82226bc963e@<IP_ADDRESS>:30303 --p2p-host=<IP_ADDRESS> --max-peers=420 --rpc-http-enabled=true --rpc-http-max-active-connections=400 --rpc-ws-max-active-connections=400 --api-gas-price-max=100 --revert-reason-enabled=true --metrics-enabled=true --sync-mode=FULL --rpc-http-api=ADMIN,ETH,MINER,WEB3,NET --p2p-port=30304

There's some helpful info for peering in the besu docs https://besu.hyperledger.org/public-networks/how-to/troubleshoot/peering
Also maybe useful - if you enable the ADMIN RPC api, you can use this call to view detailed peer info
https://besu.hyperledger.org/public-networks/reference/api#admin_peers


consul has multiple dc's when started up

consul lists two datancenters when only one configured

doesnt appear to be happening anymore, so closing issue.


Update gosec.yml

Description
My original gosec PR did not use the informal systems gosec.

For contributor use:

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #623 (1c0b6e1) into main (17f3de3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   18.44%   18.44%
=======================================
  Files         172      172
  Lines       24233    24233
=======================================
  Hits         4470     4470
  Misses      18998    18998
  Partials      765      765

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f3de3...1c0b6e1. Read the comment docs.


Doesn't always unmute after an ad.

I use this app with both Spotify and Spotify Stations. It works on both.
HOWEVER, sometimes, on Bluetooth, it doesn't unmute. I think that the Bluetooth device is lagging the volume up rocker.
A potential fix is to make an option for slowly fading the music track in. Maybe a 'FX' option list would work, where I could set how fast the fade happened. Right now, I have my phone set to maximum volume, and my speaker is adjusted accordingly. I'm going to mess with the developer options and see if changing the absolute volume function fixes it.

Disabling absolute volume fixed it. I have an umidigi A3 pro, unmodified stock.

fixed in version #52


Disable 'sessionDataUpdated' trigger if window is active for IE

According to the spec the storage-event should only be fired for other tabs and windows, see https://html.spec.whatwg.org/multipage/webstorage.html#the-localstorage-attribute.
However, IE does fail to do so: https://connect.microsoft.com/IE/feedback/details/798684/ie-localstorage-event-misfired. To bring this behaviour to IE we can emulate it by using the document.visibilityState. Pity enough this works only for IE10 en IE11, so older versions of Internet Explorer still suffer the extra unneeded session-data update.

What does this fix specifically?

No need to call the restore data function for open tab (because it did initiate the storage change)
I got a custom keycloak adaption. Things go weird in IE if restore is called upon when logging in

I got a custom keycloak adaption. Things go weird in IE if restore is called upon when logging in

Can you provide more precise info on this please, it's a bit vague actually ;)

In the end it was more an implementation problem then a bug within Ember Simple Auth. So closed this pull.
Explanation
it was a combination of things:

Keycloak restore: do a reload
After reload, set _bindToStorageEvents
IE always executed the storage-event function, even if it's the setter is within the same window
4.. I saved an Ember Data model in the session, so the if-statement !objectsAreEqual(data, this._lastData) in the storage-event was always true (serialized model against 'real' model).
Trigger the sessionDataUpdated flag.
If  sessionDataUpdated is triggerd, call restore
Go to step 1...

To fix this endless loop, I added the document.hidden check. But this does not fix the problem for multiple tabs. So I choose to save the id of the model in the session only, to prevent this loop from happening.
P.S. If you wonder why other browers do not have the same problem if multiple tabs are used, it's because the storage-event is not fired when the localstorage is updated but the localstorage data is not changed at all.


Qe work michael kolodner

Critical Changes
Creates objects (QALookupParent and QALookupChild) for use in QA work only.
Adds QA App, page layouts, and lightning pages to make working in a QA scratch org in the UI easier for users.
Updates mapping and sample data files in QA folder to bring in those objects and several standard objects.
Adds data to the QA dataset.
Changes
Issues Closed

@Szandor72 Making this PR to capture the work I've done so far. I still have more work to do on metadata, but would like to at least get this part approved to show some progress!

Closed due to wrong branch name. Followed up in #1372


[Bug]: YAML-Keys trimmed in Reading mode and yaml-tags no longer visually separated from rest of frontmatter

Bug Description
I just went on to update the theme once again - I don't recall which version I was on previously, maybe .080 minus, or something? idk - and suddenly the frontmatter block is rendered differently. I checked the style settings for a relevant setting, but could not find anything related.

Completely unrelated things, some of which are definitely not supposed to be in this issue:

The link to the changelog-file in the Checklist below is broken. Just fyi.
Even less related, if you could tell me if your academic knowledge management vault mentioned in Danny's Obsidian October Winners 2022 is publicly available/where to find it, I would be very happy. I've been unable to locate it.

Relevant Screenshot
Input in live preview:

Resulting Image in Reading Mode:

Only partial snapshot of how it looked previously, unfortunately in a file without a tag-yaml-field:

Keys were colored as well, if I am not completely crazy. The above snapshot is from 09.09.2022.
No other theme, including the default one, exhibits this behaviour.
To Reproduce

Use an unknown theme version published in the recent past (I'd assume). (I am running 3.256 right now, but I do not recall which version I ran beforehand unfortunately.)
Open a note containing metadata
set up style settings

Obsidian Version
1.1.8
Installer Version
1.0.3
In which mode(s) does the problem occur? (if applicable)

[ ] Source (Edit)
[X] Reading (Preview)
[ ] Live Preview

Which operating system?

[ ] macOS
[ ] Linux
[X] Windows
[ ] iOS
[ ] Android

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] When using the Obsidian Insider release, I have already checked out the insider-branch and the issue still occurs there.
[X] If the bug occurred after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] My issue concerns Obsidian version 1.0+ and I am not using the Legacy Editor (CM5). (Older Obsidian versions and the Lecacy Editor are not supported by this theme anymore.)

The link to the changelog-file in the Checklist below is broken. Just fyi.

thanks, is fixed.

Even less related, if you could tell me if your academic knowledge management vault mentioned in Danny's Obsidian October Winners 2022 is publicly available/where to find it, I would be very happy. I've been unable to locate it.

well, that's cause I have never published any such vault? I think Danny mixed up something there, I never submitted a vault for Obsidian October 😅

I am sorry, from your report I cannot really tell what the issue is. I tested the metadata on the latest theme and Obsidian version and everything looks like it's supposed to.
in the latest Obsidian version, one of the two frontmatter block has been in reading mode has been removed, namely the one which rendered yaml in colors. I assume that is the issue?
If not, please attach screenshots comparing the default theme and shimmering focus so I can better tell what the issue is you have.

well, that's cause I have never published any such vault? I think Danny mixed up something there, I never submitted a vault for Obsidian October 😅

Oh no.... I'm sorry, this is really embarrassing. He seemed to refer to Chris Lovejoy (on GH, at least). I am only recently getting more active in the obsidian community, and wasn't aware that we had multiple Chris' and latched onto the first one I knew of, I'm sorry.🤦

Source:

Reading View:

Default theme reading view:

and source

Just for clarification, is this the expected result in reading mode?
Enabled "Permanently show Metadata & YAML Frontmatter (Reading mode) in my pseudo-test vault", otherwhise default settings and no relevant plugins enabled.

I tracked down the last confirmed version in which I do not have this change: 3.257 - the version of an offline, non-synced phone's instance of my vault that I don't keep up to date at all times. Is there a way to retrieve/provide a specific version of a theme so I can make a personal test of whether or not this is the theme's fault, or a weird plugin interaction? I keep my plugins up to date, but didn't recall updating a theme-related plugin today - and checking this will take substantially more time :/
Below is a screenshot of the theme as it is rendered on my phone, at version 3.257, with essentially the same plugins enabled as on PC - they sync to the same vault, so the only delta between the two is that my PC-vault has been updated theme- & plugin-wise today, which is not synced because I disabled plugin sync a few days ago.

thanks, is fixed.

No it's not :P

(I am sorry for the extremely funky arrow solution, couldn't be bothered to do this properly)
I am talking about the this link (raw: https://github.com/chrisgrieser/Changelog.md#changelog) in the checklist for (bug-)issues, cf above image and the respective link in this very issue.

No it's not :P
yes it is :P

probably the link has not yet updated for you due to github's caching. Try force reloading ;)

Just for clarification, is this the expected result in reading mode?

yes, it's the expected result, due to the change from Obsidian core to remove the other yaml frontmatter block.
It only looks a bit plain since I also removed "tags" and "aliases". Guess it's better to add them back to prevent confusion. :P

probably the link has not yet updated for you due to github's caching. Try force reloading ;)

Alright, now  I am confused.  So I went to edge (ugh, but it's actually surprisingly useable now), which is my backup browser and that still didn't let me access the link :P Is GH caching for my machine's IP in general?  But it also doesn't seem to update on my phone, regardless of how I access it - doesn't work from GH app, nor if visiting this website in the browser, regardless of device or login-status. This is super weird.
Huh, Idk. It won't kill me, I'll just assume it's a bug on my end as it clearly seems to work for you and keep this in mind for the time being. ¯\_(ツ)_/¯

change from Obsidian core to remove the other yaml frontmatter block.

By that, do you mean the missing yaml-keys, leaving only the values to be displayed? Is that revertible somehow/implementable? In find yaml values without any meaning as to what key they belong to borderline confusing, as in "might just as well forfeit the entire notion of displaying it at all" because frontmatter handles a great load of different shit for me.
If you mean something else I am really confused.

Guess it's better to add them back to prevent confusion

Yes. Please. Having frontmatter-aliases, and especially tags separated is a small, but very useful feature this theme provided me so far.

Huh, Idk. It won't kill me, I'll just assume it's a bug on my end as it clearly seems to work for you and keep this in mind for the time being. ¯_(ツ)_/¯

yeah no idea ¯_(ツ)_/¯

By that, do you mean the missing yaml-keys, leaving only the values to be displayed? Is that revertible somehow/implementable? In find yaml values without any meaning as to what key they belong to borderline confusing, as in "might just as well forfeit the entire notion of displaying it at all" because frontmatter handles a great load of different shit for me.

yes, Obsidian core now only has a metadata block which shows tags and aliases, nothing more. Knowing that metadata-improvements are up next on the roadmap, I assume that they are soon gonna add something else. But well, that is an Obsidian issue, not an theme issue.
nevertheless, tags and aliases should be easily distinguishable since one of them is colored, and the other is not?

I mean, tags are, aliases are not, neither is anything else in that box . I'd prefer the box'd separation we had before; maybe as an optional setting?
(Talking about this:
)

The aliases can be distinguished by the arrow in front of each of them?
If you mean sth else, you will have to be more specific?

I am talking about the small box below the actual yaml-render that contains solely aliases and tags, without their key names "alias" & "tags", and with rendered hashtags and "link-arrows".
To be sure, I just checked the differences between PC and synced vault state, the relevant plugins (all that deal with rendering in some sort or another) are on the same version on mobile. The only real difference is the theme version, 3.235 on mobile vault vs 3.258 on desktop.
And yes, I have absolutely no idea why this is suddenly colored, and not last time I took the screenshot. What I could confirm is that the image above is not a result of plugins, I took it in safe mode, and none of the core plugins have any reason to influence this. Thus, the theme is the only thing that can reasonably be the cause.
The small box shown in the image also shows up for "Things", "default", "Minimal" & "Prism" (all non-legacy).

Yes, I know that you mean that small box.
But what is your issue with it? What do you want changed?

I want it there; instead of not. In the current version of the theme - with all plugins disabled - it is no longer rendered.
I want that separate box for tags and aliases, for a better distinction of them vs normal frontmatter (as they are the only interactible and most important parts of the frontmatter to be rendered imo).

In a perfect world, I suppose I'd ask for a way to only render those in reading view and disregard the rest of the yaml header (or even better,  have the rest be pushed to the floating button toggled by disabling Permantently show Metadata & YAML Frontmatter (Reading Mode) & address metadata and yaml frontmatter by separate settings ) entirely, but that's a bit more to ask for right know than I seem necessary - I can't do it myself, and it would be kind of rude to just ask you for featurs A-Z just cuz I'd want them; so I try to not be too overbearing.

P.S.:
Is there a bug-tracker somewhere? I noticed that, if disabling the aforementioned setting Permantently show Metadata & YAML Frontmatter (Reading Mode), only the "M" for the Metadata-block is shown. The "Y" mentioned in the setting itself is missing. But I don't know if you are aware of that already.

P.S.:
Is there a bug-tracker somewhere? I noticed that, if disabling the aforementioned setting Permantently show Metadata & YAML Frontmatter (Reading Mode), only the "M" for the Metadata-block is shown. The "Y" mentioned in the setting itself is missing. But I don't know if you are aware of that already.

Yes, this github lol. Just open another bug report. Although that issue is already fixed in the latest theme version. As I said, one of the two frontmatter blocks in reading view have been removed, and that one was the one labeled with "Y" by the theme.

Sorry, but I still don't get what your issue is.

"In a perfect world, I suppose I'd ask for a way to only render those in reading view and disregard the rest of the yaml header" this is already the case?
"I want it there; instead of not. In the current version of the theme - with all plugins disabled - it is no longer rendered." have you maybe disabled the frontmatter block in the Obsidian settings? It's there for me.

Okay. I'll try and explain.
Image 1: Current View, all things updated, toggled on Permanently show Metadata & YAML and Show frontmatter

Image 2: Old rendering before whatever the heck happened (Reading view):

Image 3: The part of the old reading view that I would like to see permanently

Image 4: the Hover-menu for the metadata

"I want it there; instead of not. In the current version of the theme - with all plugins disabled - it is no longer rendered." have you maybe disabled the frontmatter block in the Obsidian settings? It's there for me.

Again, I am specifically refering to the contents of image 3 / the lower box image 2.

"In a perfect world, I suppose I'd ask for a way to only render those in reading view and disregard the rest of the yaml header" this is already the case?

I don't see that being the case.
We can show both permanently. We can move the metadata to the side. We can hide it all  together.
We cannot hide one and show the other, one of them we can't show at all.
Elaboration:
The for-me-best-case would be

Allow completely hiding the general yaml header (the entire block of image 1, or upper box in image 2) permanently, independently of 2). This removes it from rendering, and does not add the on-hover letter mentioned in 3)
Allow completely hiding the alias&tag-subbox (image 3, lower box in image 2), independently of 1). This removes it from the rendering, and does not add the on-hover letter mentioned in 4)
Allow displaying the general YAML header (the entire block of image 1, or upper box in image 2) either permanently (cf. image 1), or on-hover (like image 4, but the yaml one that no longer exists)
Allow displaying the subbox containing alias & tags permanently, or on hover, compare step 3
haven them all show on hover (image 4, but also for tags&aliases)
have them all permanent (image 2)
have either one of them permanent, and the other one on-hover (<permanent yaml, hovered tags/aliases> ←→ <permanent tags/aliases, hovered yaml>)

Which essentially boils down to the crude points:

implement the rendering of alias&tag as in image 3
for the general yaml header, add a checkbox to decide if it is rendered at all

if the above option is set to "render it at all", add a checkbox to decide if it is permanently shown, or pushed to the "letter" on the side

for the alias/tag-box, add  a checkbox to decide if it is rendered at all

if the above option is set to "render it at all", add a checkbox to decide if it is permanently shown, or pushed to the "letter" on the side

That would allow all of the scenarios outlined in steps 1-7 to be toggleable.

I'm sorry if I apparently completely suck at getting my point across :P

Allow completely hiding the general yaml header

This is what you get when the Obsidian setting "Show Frontmatter" is disabled?

Allow completely hiding the alias&tag-subbox (image 3, lower box in image 2), independently of 1).

as I said before, the recent Obsidian update did get rid of one of the previously two frontmatter boxes in reading view (or rather, somewhat merged them.) So you cannot act independently on it. You should also notice that this is literally the same with every other theme, since it's an underlying Obsidian change?

Allow displaying the general YAML header (the entire block of image 1, or upper box in image 2) either permanently (cf. image 1), or on-hover (like image 4, but the yaml one that no longer exists)

This is what you get when the Obsidian setting "Show Frontmatter" is enabled?

have either one of them permanent, and the other one

(Summarizing for the following points:) I may repeat myself, but as I said, there now only is one frontmatter box in Obsidian. you can hide it or not with the respective Obsidian setting. You cannot do stuff in one case and then in a different case, since I can either target the box, or not target the box via CSS. There is no more two boxes where you can do different things to.
I don't know, maybe I am really misunderstanding something, but this issue is the very same with any other theme right now. I think what you are looking for is a feature request for Obsidian core?

We can show both permanently. We can move the metadata to the side. We can hide it all together.
We cannot hide one and show the other, one of them we can't show at all.

this is a good example: you use "both", "one not the other" in these contexts and your post does not really make it clear what "both" or "one" or "the other" refers to. Having four images before, and then referring to two things keeps your point simply unclear.

I'm sorry if I apparently completely suck at getting my point across :P

well, this is why students of STEM disciplines should visit classes in humanities or social sciences: not only for getting a look beyond their discipline, but simply cause in those classes, you practice making clear arguments lol. (sorry, if this sounds lecturing, I teach at university, after all 🙈)

btw, I pushed a new update with some changes to how metadata looks and new settings to customize that only tags or aliases are shown in reading mode. Not sure if that is what you are after, but it's the most a theme can do right now


Do not remove documents if they are not files

Fixes AB#2261836
When the preview changes window closes, it issues a document closed for a document being tracked but with a URI of 'vscode-bulkeditpreview-editor'. This is a valid notification for closing a document but it should not be removed because that will cause the content to be lost making the client and server out of sync for what it thinks the csharp/html code is

@dibarbet could you take a look? I'm not sure if schema checking is the best way to do this or if there are schemes I might be missing

@dotnet-policy-service rerun


Implemented POST /encounter endpoint

Allow encounter creation through /encounter endpoints

Valid encounter with reference to Person returns 201 CREATED
Valid encounter without reference to any Person returns 400 BAD RESPONSE
Invalid encounter returns 400 BAD RESPONSE
If User is not found, returns 403 FORBIDDEN

For #41
Testing Notes:
Implemented integration tests and unit tests.

Most of test cases passed, with some failed due to some test cases relies on other methods and endpoints (not implemented yet) to properly test

Done manual testing on Postman and endpoints work as expected

Why is there front-end stuff being added with this merge?

Why is there front-end stuff being added with this merge?

Why is there front-end stuff being added with this merge?

I'm not sure why Git just added those files into my commits. What I did was pulling changes from upstream (that had the changes for the front-end files in this commit), fixed merge conflicts, and commit. Somehow those files were also included in the merge conflict commit as my changes.
I can't seem to remove the changes since it's already committed quite some time ago. Does anybody knows how to fix this, or could I just leave it as it is since it's not being changed?

Why is there front-end stuff being added with this merge?

Why is there front-end stuff being added with this merge?

I'm not sure why Git just added those files into my commits. What I did was pulling changes from upstream (that had the changes for the front-end files in this commit), fixed merge conflicts, and commit. Somehow those files were also included in the merge conflict commit as my changes.
I can't seem to remove the changes since it's already committed quite some time ago. Does anybody knows how to fix this, or could I just leave it as it is since it's not being changed?

Is it possible to only commit the files you changed onto a new branch forked from main and then perform a PR from that? That might be a possible solution.

Sounds like a way. I'll close this and open up a new pull request


add_build_coarse_space and get_local_to_global_numbering

Codecov Report

Merging #9 (9b8c4db) into main (931c89b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   98.63%   98.66%   +0.03%
==========================================
  Files           6        6
  Lines         293      300       +7
==========================================
+ Hits          289      296       +7
  Misses          4        4

Impacted Files
Coverage Δ

src/htool/ddm_solver.hpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931c89b...9b8c4db. Read the comment docs.


Semantic highlighter

edit.Highlighter is now backed by parse.Lexer. It processes a flow of tokens, identify commands and variables, resolve their validness and highlight them accordingly. However,

Commands and variables can be difficult to identify properly without syntax knowledge; the current Highlighter does a poor job on this. This requires the use of Parser.

The validness of command or variable can not be determined reliably without semantics knowledge. For instance, identifying that the second x in fn x { }; x is actually valid is impossible without knowing about the fn form. This requires the use of Compiler.

It is very desirable to also highlight syntax errors and static type errors.

The plan: Highlighter should be backed by parser.Parser and eval.Compiler. It parses the (incomplete) text and in case of syntax errors, highlight the affected areas. It then compiles the tree and highlights any static type errors. The plan consists of several parts:

Parser needs to handle incomplete text better; it also needs to be able to continue parsing to some extent in face of errors (or a single syntax error will cause everything after it to not be parsed).

Compiler also needs to continue compiling to some extent in face of errors.

Static type errors cover invalid variable references, but invalid command references are a bit tricky. Currently Compiler simply mark all unresolved commands as externals, and does not attempt to resolve them into actual paths. Compiler needs to make it possible to enumerate such commands after compiling an AST.

Rewrite the Highlighter. The structure of Highlighter may also need a change. Since parsing and compiling can be a bit time-consuming, running the text through Highlighter before displaying them on screen can cause lags. Highlighter may now output a series of highlighting instructions. Editor displays the text immediately (with proper ItemType highlighting), run Highlighter asynchronously and apply the instructions once they are ready.

The syntax highlighting now uses the AST.

The utilization of the compiler will be tracked in #64.


Add support to vote on polls. Add more fields to Poll

Hi,
I've added two more functions to the API.

GetPoll to fetch polls by their ID.
PollVote to vote on a poll with the ID and the index of the polls choices

Thank you. I added GitHub Actions for CI. Could you please rebase master?

Codecov Report

Merging #140 (c0a2091) into master (8c434b5) will increase coverage by 0.38%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   77.66%   78.05%   +0.38%
==========================================
  Files          29       30       +1
  Lines        1330     1358      +28
==========================================
+ Hits         1033     1060      +27
+ Misses        205      204       -1
- Partials       92       94       +2

Impacted Files
Coverage Δ

polls.go
83.33% <83.33%> (ø)

status.go
72.72% <86.66%> (+1.21%)
:arrow_up:

streaming.go
97.40% <100.00%> (+0.03%)
:arrow_up:

cmd/mstdn/main.go
66.80% <0.00%> (+1.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39c10b...c0a2091. Read the comment docs.

I'm no expert at git, but I think I managed to rebase it as you wanted me to :)


Remove multi-FPGA feature toggle

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Removes the multi-fpga feature toggle and conditional code executed by the toggle.
Why should this Pull Request be merged?
The multi-FPGA feature is ready to go and no longer needs to be hidden by a feature toggle.
What testing has been done?
2019_05_24_10_00_51 VI Tester.txt

New test results.
2019_05_24_13_38_37 VI Tester.txt


Support for Fluentd v1 + td-agent 3

Are there any plans to support Fluentd v1 + td-agent 3?

I will work for this issue after merging #222, #223.

Thank you @okkez - your work is highly appreciated.


Regen patch hash

Patch Hash Didn't Match

Git was showing the patch file as corrupt on Jakes computer, so had him regenerate it and it seems to apply find on vendoring here and on my computer.  Noting that the hash length has increased by one character.


New version: TheDocumentFoundation.LibreOffice.HelpPack version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #4827.
Logs
Updated: <IP_ADDRESS> → <IP_ADDRESS>
400 Bad Request: can't parse entities: Can't find end of Bold entity at byte offset 4090
Submitting WinGet manifests
400 Bad Request: can't parse entities: Can't find end of Bold entity at byte offset 4090

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,
This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.
(Automated response - build 880.)

Edit: Apologies, this was from running the approval automation without having the installer.yaml unfurled.


Allow configuring the built-in formatter to leave /> on its own line

Hi, I have configured the HTML formatter to my liking by disabling extra liners, enabling indentation of head and body, configuring the formatter to leave my indentation of attributes alone and turning off maximum line length (opting to control it myself instead). I am missing once piece of configuration that would allow me to write HTML the way I prefer, like so:
<input
  autocomplete="off"
  autofocus
  list="suggestionsDatalist"
  placeholder="Press Enter to submit…"
/>

With editor.formatOnSave, when I save this document, the formatter will move the /> after the last attribute, like so:
<input
  autocomplete="off"
  autofocus
  list="suggestionsDatalist"
  placeholder="Type a command or a draft and press Enter…" />

I am hoping a setting could be introduced to control this. I want all attributes on one line, when the entire tag fits on a single line, or all attributes on their own line, when it doesn't, with just the attributes on each line, the opening and closing tags on their own respective lines as well.

We use beautifyjs as the underlying HTML formatter. Would you mind filing this request directly against https://github.com/beautify-web/js-beautify ?


basic-card view doesn't render links?

Noticed while working on #362. Is the twitter bot also broken?

This broke in 7799a473421777e612514c0ffc2fdb484e8d872a while working on #362, so it was never broken in production.


placements-page

placements page of mobile view is not appropriate

Corrected in the new pr:
https://deploy-preview-43--iiitdwd.netlify.app/

Once check it out , if any issues msg me


Automatically open peek view if running test from a document

Ref https://github.com/microsoft/vscode/issues/107467

To verify, there are a couple settings for this:

testing.automaticallyOpenPeekView configures when the peek is opened. You can choose to only open when there's a failure in a visible document, or when there's a failure anywhere.
testing.automaticallyOpenPeekViewDuringAutoRun configures whether a peek is opened during auto run. This is off by default since it would be a very disruptive behavior for users who use autosave.


Add OS install parameters for kickstart/preseed values

This will make it easier to point our OS installer workflows toward custom kickstart/preseed files.
Requires https://github.com/RackHD/on-http/pull/302
@RackHD/corecommitters @jlongever @heckj

Coverage increased (+0.007%) to 88.182% when pulling 9233e6385cd31cfa2e8a17bcbd82860059275756 on benbp:os-install-params into af80703cfe4abaa476a5e3440386f79ab0c5aed2 on RackHD:master.

+1

:+1:


jsdom cleanup after removal

remove all orphan/unused/unnecessary functions & operations that are no longer needed.

some minor details might be left. not closing issue yet.

The remaining objects to clean up have nothing to do with dom now.


Do not use ACC-accepting constructor for JBossThreadFactory

Linux Build 6909 is now running using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9

Linux with security manager Build 1807 is now running using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9

Windows Build 1984 is now running using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9

:+1:
... assuming the testsuite runs ok

Linux with security manager Build 1807 outcome was SUCCESS using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9
Summary: Tests passed: 864, ignored: 311 Build time: 0:06:47

Windows Build 1984 outcome was SUCCESS using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9
Summary: Tests passed: 2930, ignored: 367 Build time: 0:49:41

Linux Build 6909 outcome was FAILURE using a merge of 9290f73cc96ecdbcf62238baba4eee277d119fe9
Summary: Tests failed: 2 (2 new), passed: 2927, ignored: 367, muted: 1 Build time: 0:51:51
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: <no details avaliable>


Develop

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.25%. Comparing base (6352d96) to head (04c08a0).
Report is 8 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   96.25%   96.25%
=======================================
  Files          17       17
  Lines         374      374
=======================================
  Hits          360      360
  Misses         14       14

Components
Coverage Δ

core
100.00% <ø> (ø)

api
90.00% <ø> (ø)

tests
100.00% <ø> (ø)


No results Il Corsaro Nero [KeyError: 'movie_extra2']

Hello @elgatito,
I've tried to use "Il Corsaro Nero" as provider, but no results and on screen appear the notification: "Provider" too slow.
This is the log:
00:46:31.260 T:20234  NOTICE: [script.elementum.burst] Burstin' with Il Corsaro Nero 00:46:31.275 T:20237   ERROR: Exception in thread Thread-1:                                             Traceback (most recent call last):                                               File "/home/jenkins/workspace/Android-ARM/tools/depends/xbmc-depends/arm-linux-androideabi-21-release/lib/python2.7/threading.py", line 801, in __bootstrap_inner                                               File "/home/jenkins/workspace/Android-ARM/tools/depends/xbmc-depends/arm-linux-androideabi-21-release/lib/python2.7/threading.py", line 754, in run                                               File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.elementum.burst/burst/burst.py", line 545, in run_provider                                                 filterInstance.use_movie(provider, payload)                                               File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.elementum.burst/burst/filtering.py", line 217, in use_movie                                                 self.extras.append("%s" % definition['movie_extra2'] if definition['movie_extra2'] else '')                                             KeyError: 'movie_extra2'
So I've tried to edit providers.json in this way:

"movie_keywords": "{title:it} {year}",
"movie_keywords2": "{title:original} {year}",
+"movie_keywords": "{title:original} {year}",
and finally it's works! (Is that the right choice?)
Can I ask you why that second parameter was added? What's that supposed to do?

Thanks!

Not the owner, but I've been tinkering with this plugin for a while now and I think I figured it out. The "2" variants of searches, see also tv_keywords2 or season_keywords2, are just other searches the script performs. It's pretty clear how this works with tv_keywords, which is used to search tv shows episodes, if you have a look you'll see most providers will have something like this
        "tv_keywords": "{title:original} s{season:2}e{episode:2}",
        "tv_keywords2": "{title:original} s{season:2}"

basically, what that that does is searching for the single episode AND the whole season, so that if the single episode isn't found, maybe it can find the whole season (which of course contains the episode).
 The "correct" fix would be to add a movie_extra2: "" line, anyway. What you're doing right now is making it search for original versions only.

Today after some queries to the provider I understand that we need to search with both titles, because unfortunately sometimes they are loaded with the Italian title and others with the original title.
So after, I realized I did a foolishness in leaving only the original title, I checked that the error is only in the missing parameter: ""movie_extra2": "",(that I initially confused with "movie_keywords2" and I didn't understand the error log)

What's that whole "sometimes it's loaded with the English title sometimes with the Italian one" thing? That's super weird, could you provide an example? I'm genuinely curious. Does it happen on the website as well?

Yes it happen also on the website e.g. the first movie on Trending list (Ralph).
If you try to search with English title no results, otherwise 2 result with Italian title.

Yeah, but that's normal, since ilcorsaronero is Italian only. IMO, we should leave the title: it lines only as that will be the Italian title if there is a translation (Ralph, for example) or the original title if there is none (Inception comes to mind)

@castiman if you want to search both languages, you have to define few queries:
"tv_keywords": "{title:it} s{season:2}e{episode:2}",
"tv_keywords2": "{title:original} s{season:2}e{episode:2}"

Closing this issue.
New issues should come in separate issues.


improvement: add mysql payments

Description

Add support for mysql database for the payments service

Changes

Add required dependencies
Add required annotations for the Entity classes - Payment and PaymentUnit
Add an interface repository for the Payment Entity CrudOperations on DB
Update the Springboot component scan packages to scan classes from the service-sdk module
Update the Springboot application configurations to include default DB configurations
Implement a PaymentGateway that uses the database
Update the APIServerController to adapt to changes

Related PRs:

PR https://github.com/GoogleCloudPlatform/point-of-sale/pull/89 must be reviewed before this one

Access the Point-of-Sale at:

:zap:  Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

MySQL DB backed deployment: <IP_ADDRESS>
Embedded H2 DB backed deployment: <IP_ADDRESS>

:zap:  Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

MySQL DB backed deployment: <IP_ADDRESS>
Embedded H2 DB backed deployment: <IP_ADDRESS>

:zap:  Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

MySQL DB backed deployment: <IP_ADDRESS>
Embedded H2 DB backed deployment: <IP_ADDRESS>

:zap:  Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

MySQL DB backed deployment: <IP_ADDRESS>
Embedded H2 DB backed deployment: <IP_ADDRESS>

:zap:  Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

MySQL DB backed deployment: <IP_ADDRESS>
Embedded H2 DB backed deployment: <IP_ADDRESS>


texlive.withPackages: do not override .out, .all attributes

Description of changes
The .out, .all attributes should never be modified to avoid interfering with standard interfaces such as .overrideAttrs. For instance, .overrideAttrs would not change the value of .out, breaking all sorts of things, including nix-shell.
Messing around with the outputs using passthru was a really bad idea. By the looks of it, this is the last piece of code related to it. I am temporarily leaving texmfdist, texmfroot in place, but they will disappear with the new refactor (they will become normal derivation arguments).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

PS: this should be a zero rebuild change because it's all about passthru (let's see if ofborg confirms).

PS: this should be a zero rebuild change because it's all about passthru (let's see if ofborg confirms).

Interesting. I am not sure why rebuilds are happening. Somehow, I created the wrong fixed point around passthru.out? That might explain why I couldn't fix the store paths issues...
I suppose running nixpkgs-review on Linux is the safest course of action to make sure the rebuilds are the ones we expect (i.e. only the schemes and associated outputs).

Result of nixpkgs-review pr 296751 run on x86_64-darwin 1

30 packages built:

texliveBasic
texliveBasic.info
texliveBasic.man
texliveBookPub
texliveBookPub.info
texliveBookPub.man
texliveConTeXt
texliveConTeXt.info
texliveConTeXt.man
texliveFull
texliveFull.info
texliveFull.man
texliveGUST
texliveGUST.info
texliveGUST.man
texliveInfraOnly
texliveInfraOnly.info
texliveInfraOnly.man
texliveMedium
texliveMedium.info
texliveMedium.man
texliveMinimal
texliveMinimal.info
texliveMinimal.man
texliveSmall
texliveSmall.info
texliveSmall.man
texliveTeTeX
texliveTeTeX.info
texliveTeTeX.man

I suppose running nixpkgs-review on Linux is the safest course of action to make sure the rebuilds are the ones we expect (i.e. only the schemes and associated outputs).

You can see the list of rebuilds in "Details" for ofborg-eval. In fact, nixpkgs-review by default tries to use that same evaluation if it is available.

Could this be related to nix shell not working?
 ➜ nix shell nixpkgs#texliveMedium
error: path '«unknown»/nix/store/567f3f6bkiwwc9kiys6xnnk67msyvdj3-texlive-2023-env-man' is a symlink

Could this be related to nix shell not working?
 ➜ nix shell nixpkgs#texliveMedium
error: path '«unknown»/nix/store/567f3f6bkiwwc9kiys6xnnk67msyvdj3-texlive-2023-env-man' is a symlink

Oh my, I can't reproduce it on my machine, nixpkgs-unstable darwin. Could that be a nix (intentional) regression? Which nix version is it?
(PS: by the way the man output is a symlink to a directory, surely there is no reason to reject it?)

I can't reproduce it on my machine

I reproduced it by running nixUnstable.
nix shell nixpkgs#nixUnstable
nix shell nixpkgs#texliveMedium

This should be flagged as a Nix regression, I think. In the meanwhile I'll mitigate it on the Nixpkgs side, somehow.

This could be similar to https://github.com/NixOS/nix/issues/9882 and some things could have been missed in https://github.com/NixOS/nix/pull/9884 . I can only reproduce this with nix 2.20 and 2.21, 2.19 works fine.

I think the actual code that introduced this is https://github.com/NixOS/nixpkgs/pull/270232/files#diff-dc2ebdb8ed1e22695937e7c0c7b6bee656bade7c86422d7d9766d79f829bebcfR238-R245
Either
 pkgs/tools/typesetting/tex/texlive/build-tex-env.nix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
index 73e69578dc9f..1035bb73904c 100644
--- a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
+++ b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
@@ -238,7 +238,7 @@
     for otherOutputName in $outputs ; do
       if [[ "$otherOutputName" == 'out' ]] ; then continue ; fi
       otherOutput="otherOutput_$otherOutputName"
-      ln -s "''${!otherOutput}" "''${!otherOutputName}"
+      cp -r "''${!otherOutput}" "''${!otherOutputName}"
     done
   '' +
     # environment variables (note: only export the ones that are used in the wrappers)

or maybe
diff --git a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
index 73e69578dc9f..74db05e3f310 100644
--- a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
+++ b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
@@ -32,7 +33,7 @@
 , __extraName ? "combined"
 , __extraVersion ? ""
 # emulate the old texlive.combine (e.g. add man pages to main output)
-, __combine ? false
+, __combine ? true
 # adjust behavior further if called from the texlive.combine wrapper
 , __fromCombineWrapper ? false
 }@args:

or
diff --git a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
index 73e69578dc9f..e06ccf5d3103 100644
--- a/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
+++ b/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix
@@ -14,6 +14,7 @@
 , toTLPkgSets
 , bash
 , perl
+, xorg

   # common runtime dependencies
 , coreutils
@@ -228,6 +229,7 @@
     tl.texlive-scripts # fmtutil, updmap
     tl.texlive-scripts-extra # texlinks
     perl
+    xorg.lndir
   ];

   inherit meta passthru;
@@ -238,7 +240,8 @@
     for otherOutputName in $outputs ; do
       if [[ "$otherOutputName" == 'out' ]] ; then continue ; fi
       otherOutput="otherOutput_$otherOutputName"
-      ln -s "''${!otherOutput}" "''${!otherOutputName}"
+      mkdir "''${!otherOutputName}"
+      lndir "''${!otherOutput}"/ "''${!otherOutputName}"/
     done
   '' +
     # environment variables (note: only export the ones that are used in the wrappers)
diff --git a/pkgs/tools/typesetting/tex/texlive/default.nix b/pkgs/tools/typesetting/tex/texlive/default.nix
index cab889f5f8b3..ee2c4ac5c712 100644
--- a/pkgs/tools/typesetting/tex/texlive/default.nix
+++ b/pkgs/tools/typesetting/tex/texlive/default.nix
@@ -10,7 +10,7 @@
 , makeWrapper, installShellFiles
 , python3, ruby, perl, tk, jdk, bash, snobol4
 , coreutils, findutils, gawk, getopt, gnugrep, gnumake, gnupg, gnused, gzip, html-tidy, ncurses, zip
-, libfaketime, asymptote, biber-ms, makeFontsConf
+, libfaketime, asymptote, biber-ms, makeFontsConf, xorg
 , useFixedHashes ? true
 , recurseIntoAttrs
 }:
@@ -109,7 +109,7 @@
   buildTeXEnv = import ./build-tex-env.nix {
     inherit bin tl;
     ghostscript = ghostscript_headless;
-    inherit lib buildEnv libfaketime makeFontsConf makeWrapper runCommand
+    inherit lib buildEnv libfaketime makeFontsConf makeWrapper runCommand xorg
       writeShellScript writeText toTLPkgSets bash perl coreutils gawk gnugrep gnused;
   };


Fixed fallback for broken images on image field issue #203

fixes #203
I've fixed a fallback solution when image is broken. Just added a svg icon with a broken image and set the min-height to 100px ... that will show the icon on broken images. Used the color from the sidebar on the toggle button.

Possibly fixes #203

I'm going to approve and merge this, but when it comes time to use that SVG icon in another place we'll have to pull it out into a separate file (works great for now, though). Looks good! 😄

Great to hear! Thanks!
Skickat från min iPhone

7 jan. 2020 kl. 14:57 skrev Scott Byrne<EMAIL_ADDRESS>
I'm going to approve and merge this, but when it comes time to use that SVG icon in another place we'll have to pull it out into a separate file (works great for now, though). Looks good! 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add New Language: Delphi

Description
Provide a description of the programming language.

Hi, Can you please assign this to me?

@ericspring08 Done


Feature: App should disable Wi-Fi config if robot isn't connected via Ethernet

overview

As a user, I don't want my robot's Wi-Fi configuration to be messed with by anyone who does not have physical access to the robot
As a user, it is confusing when I change my robot's Wi-Fi network to a network I am not on because it is difficult to figure out if I succeeded

The Wi-Fi configuration of a robot shouldn't be messed with by anyone without physical access to the robot. Given how our Wi-Fi endpoints currently function, it is also difficult to reasonably return a status to the client when telling a robot (via Wi-Fi) to get on a different network that the client is not on
acceptance criteria

[ ] Wi-Fi selection options are disabled and greyed out in the app for non-local robots

https://zpl.io/beLx9vl

[ ] App displays tooltip informing user why options are disabled

implementation details
Takes over for #2718 in conjunction with #4847 and #4849
┆Issue is synchronized with this Wrike Task by Unito

Bug triage determination: LMM


New Get Started tab needed for .NET/ASP.NET/C# Hub

A new Get Started tab is needed for the hub page representing all .NET areas including ASP.NET, C# etc.   Currently 40+ links are shown representing all the guides, API ref and architecture content in what is essentially a guide tab.  It should be 2 or three at the most that are recommended as starting point.  Scott Hanselman and other evangelists asked for better get started path to point to.

[x] Get agreement from stakeholders on design & content.
[x] Create new Get Started tab and any new artwork needed.
[x] Update .NET Guides tab.
[ ] PR for review for stakeholders

This will be a temporary fix since a new hub design is being set for all docs for all areas to make the experience more consistent.  We have had enough request however a proper getting started page to point to however that it was decided not to wait until then.

PR in review here: https://github.com/dotnet/docs/pull/14125

Closing.  Really should have opened this against the dotnet repo even thought the hub is also for ASP.NET.
Moved to here: https://github.com/dotnet/docs/pull/14125