Environment not activated before running linting?

VS Code version
1.62.3
Extension version
v2021.11.1422169775
OS type
Windows
OS version
Windows 10
Python distribution
Anaconda
Python version
3.9.7
Language server
Pylance
Expected behaviour
Conda environment activated before pylint is run
Actual behaviour
python.exe from the virtual environment is used, but the environment is not activated.
This causes pylint to throw "no-module-in-name" errors for the package lxml.
Steps to reproduce
Ctrl + Shift + P to run Linting.
Check output under Output/Python.
The need for activation can be tested using the same command in cmd.exe and checking behaviour when the environment is (or isn't) activated beforehand.
Logs
C:\src\apps\Anaconda3\envs\ENV\python.exe -m pylint --rcfile=.pylintrc --msg-template='{line},{column},{category},{symbol}:{msg} --reports=n --output-format=text
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This should be addressed with support for conda run. Closing in favour of https://github.com/microsoft/vscode-python/issues/17973


Review ASP.NET Core extension methods before the next release

Figure out if we need one for processor.
And maybe merge AddEventHubConsumerClientWithNamespace into AddEventHubConsumerClient

I reviewed and confirmed that what we have remains valid.   I added an extension for the processor client prior to GA.   I didn't merge anything at this point, leaving the extensions to match the available major constructors.


Enforce lint and coverage

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
301

Relevant Lines:
301

💛  - Coveralls


fix(player container): replaced div container with react.fragment

Description

Replaced the container <div> with React.Fragment so that styling applied from the <Player> element can be correctly applied as expected.
Type of change

[ ]  Patch: Bug (non-breaking change which fixes an issue)
[ ]  Minor: New feature (non-breaking change which adds functionality)
[x] lottie-react Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Breaking change due to the removal of the 'lf-player-container' class
Checklist

[x] This is something we need to do.

Was this never merged? As this is not in master: https://github.com/LottieFiles/lottie-react/blob/a3b91c19b5036b9e768c86bfddc15aeacd321ab7/src/Player.tsx#L206
We need this to apply styling to the actual container to be able to set grid-area, and not some nested element. (Without adding even more additional wrapper elements.)

@andreas-ateles No it wasn't merged, as styling can be applied by overriding this class:
.lf-player-container

@samuelOsborne when using CSS in JSX this becomes cumbersome, as there is no direct way to apply any styling to the actual container (the docs lie on this, styling is not applied to the actual container but some inner element).


I CANNOT UPDATE WINDOWS SERVER 2008 r "TO WINDOWS SERVER 2012R2

Hi team,
I moved this from here: https://github.com/MicrosoftDocs/windowsserverdocs.it-it/issues/2
Hi, I tried to make the inplace upgrade from windows server 2008R2 Standard
Edition to windows server 2012R2; it starts regularly I accept the license
term and then select the 'upgrade' option, but at this time I get this
message: Impossibile eseguire l'aggiornamento da Windows Server 2008 R2
Standard a Windows Server 2012 R2 Standard Evaluation (installazione dei
componenti core del server)... so I don't know what to do. I looked for some
help on web but I didn't find any item. Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88d8e06f-1416-57d1-84b9-fd82d217a481
Version Independent ID: 9047ff8c-95f0-ffea-38d6-9a6d6c56e383
Content: Windows Server Installation and Upgrade
Content Source: WindowsServerDocs/get-started/Installation-and-Upgrade.md
Product: windows-server
Technology: server-general
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

First of all, I would like to point out that I have not participated much in the issue tickets here on MicrosoftDocs/windowsserverdocs, compared to my contributions in MicrosoftDocs/windows-itpro-docs.
To me, the original author's issue looks very much like a support issue in need of direct dialog with the customer/administrator of that specific computer system. Also note that the current original feedback does not contain any more technical information than the general error message:

Unable to upgrade from Windows Server 2008 R2 Standard to Windows Server 2012 R2 Standard Evaluation (installation of core server components)

As a computer hardware & software support technician, to me, it seems more than difficult to follow up on the original author's issue without launching a full support action to set up & try to replicate the server hardware & software scenario while also getting hold of more detailed information about the installation error by requesting logs and other information directly from the originator.
In my experience, it would be much more productive for the originator to contact the nearest Microsoft Support tenant or Microsoft partner/provider for direct follow-up and detailed information access.

@CeciAc : Thank you for migrating the issue to the English docs page, although I am still quite certain that this type of issue can happen if the user's starting point is a less than ideal configuration of the server. The user's issue should be handled by a Microsoft Support tenant in the user's area, if possible, asking the user to post back if there are any points to be made in the documentation for this specific issue.
Please note that these pages are intended for reporting issues in the documentation itself. We are only able to follow up documentation issues when pointed out what is incorrect, and preferably the factual information required to correct the documentation.
As previously stated, I am fairly certain that the issue needs troubleshooting locally at the user's location, either via phone support or remote access to the user's server environment, whichever solution is available. Reporting back to the Microsoft Docs is encouraged, particularly if errors in the documentation have been found.

#please-close


chore: fix typo in readme

Should say "all test cases pass" instead of "all test case passes"

thanks @liamdebeasi !


Mileage tracking (business vs. personal)

What would you like to be added:
Ability to flag each drive - as personal or business.
Ability to export reports - with relevant selectable drives data, like start address, end- address, Km, date+time, odometer start-end, etc...
(or more applicable: create a slightly altered Grafana view, with filter for "trip type", and the data from above.. - similar to "Drives" or "Trip" - only with some different data and filters...)
Why is this needed:
For tax purposes - and to not having to rely of manual tracking or expensive (or poor) app, with questionable impact on battery of phone etc.
Additional context:
It would be brilliant if it was somehow possible to select "something" in the car before or during a drive (I know driver profile is not an option) - perhaps a "mode switch", through MQTT or web (Siri shortcut or similar).. But obviously needed to be able to change/re-classify afterwards.
Perhaps also an option to add a note - like costumer name if parking is not next to that company... I know some of it could be solved with geo-fencing, but perhaps it is not a good idea to abuse to core geofencing for that (so a copy of the function, just for this purpose) - perhaps it is all perfect to use the existing geo-fences??? That could solve automatic "costumer tagging", but a way to alter for a specific drive would be valuable...

This seems to be a mix of #505 and #989 and a new feature ("in car tagging")

This seems to be a mix of #505 and #989 and a new feature ("in car tagging")

#989 should be dead easy, since the drives tables has "start_km" and "end_km" - sp that is purely a bit of Grafana exercise..
#505 has some of the same ideas, although I would prefer not to have automation based on any of these existing data (but can live with going through my drives to adjust the type for those that shouldn't stay default)..
But yes - I think either 2 more columns to drives table (the type, could be integer/smallint, and the "note" a varchar or text) - or a separate table referencing the drives table... Both should be a breeze to build - and creating a Grafana layout with all those filtered drives (and perhaps a simple summary on top) also a small feat....
I will gladly participate...... Only challenge I can see, would be to allow for setting a default/automated drive type, but that could be "on top", the data structure could come first, and would give 99% of the benefit...

#989 is already done (or at least for a special case), so "only" the part with the data-layer is missing. I would volunteer for the Grafana-part in case someone (@tonypilborg ?) volunteers for the data-layer-part...

From my brief (very brief) scanning of the issue, I don't think it is covered - even the special case..
The issue is, that - as has been mentioned in #912 - sometimes it takes quite a while (for my car yesterday almost 15 minutes!) before the api has contact to the car... And that is significant for tax putpose, since end_km for drive x-1 is not (In TeslaMate, but obviously in reality) equal to start_km for drive x...
So for the sake of taxation - it is either (probably both) necessary to be able to adjust manually (although this could be done in an excel extract, or be able to use end_km as the start_km for the next drive.... And it is then complicating the SELECT in the "tax report", since start_km drive x has to be inherited from end_km drive x-1, even if drive x-1 is not included in the select (if it was a private putpose, and thus not applicable for the tax report)...
(in other words - when your are looking at the Grafana part, you should SELECT all drives, but only display those with the chosen "purpose". - and then actually always use end_km from the previous drive as the start_km.... (except if the previous drives wasn't logged - which could happen.. So perhaps include all 3: end_km(x-1), start_km(x), end_km(x) - for all drives, and then filter which lines are shown...)
I actually don't have a dev install of TeslaMAte - but the structure could simply be:
CREATE TABLE public.drivepurpose (
id integer NOT NULL,
drive_id integer,
purpose_id integer,
customer character varying(255),
);
CREATE TABLE public.purpose (
id integer NOT NULL,
purpose_text character varying(255),
);
I would ever only use business or private purposes - but other might choose something more granulated (especially if somebody taskes up the idea of pre-populating the purpose automatically... And if purpose is something other that business, perhaps the drivepurpose_customer should be called something else.... ...
but obviously it is needed to allow maintenance of these tables - links in Grafana to TeslaMate???

I don't think we'd need a specific column for purpose if tagging was implemented. It would allow you to tag drives with a purpose, but also with many other things (perhaps driver, trip for drives as part of a larger trip, etc). If tagging is implemented as an opt-in system such as charge costs are, where certain geofences might trigger an automatic tag if you configure it or otherwise tagging can be applied manually, it should suit both use cases - those who want automatic tagging or those who want to do it manually.

I don't think we'd need a specific column for purpose if tagging (#505) was implemented. It would allow you to tag drives with a purpose, but also with many other things (perhaps driver, trip for drives as part of a larger trip, etc). If tagging is implemented as an opt-in system such as charge costs are, where certain geofences might trigger an automatic tag if you configure it or otherwise tagging can be applied manually, it should suit both use cases - those who want automatic tagging or those who want to do it manually.

I idsagree.... Or rather, I agree only if tagging could then be more than one dimension... If you consider the case with business trips, a tagging as business makes sense, but it could be very valuable with a way to mark a drive with a customer name (for tax purposes)...
But when pulling out to overview of drives, I would not want to select all customers - I would need to select private vs. business...
But I agree - much more elegant as an opt-in option, like for charging... Although that implementation can not be directly copy-pasted. We would need a table for these tags, irrespective of the number of tagging dimension 👍

which will be more complex, that is why I suggested the "purpose" approach....

Just tag it with the customer's name? Your column is one-dimensional - it's one value per drive. Tagging is inherently multi-dimensional as you can apply multiple tags for multiple things
Frankly, you're pushing for a worse design

You are absolutely right!
I didn't even consider a 1:many relation between drives and tags...
That is clearly a good solution - and I can't think of a scenario where some Grafana logic wouldn't be able to cater for any requests/filtering.
Do you have any insights in to the issue with "missing start of drives"? I am aware I could export all to excel, and then do some managing there . but it would be great to have it built in to the report set :)
(or does this actually belong to #989 ???)

There are two separate issues covering that, I have been following the issues but I think they're somewhat multi-faceted. The issues are https://github.com/adriankumpf/teslamate/issues/912 and https://github.com/adriankumpf/teslamate/issues/785 and I do think the suggestion of a UI to allow modifying the start/end time of a drive is a good one, perhaps one to propose in #912

You're welcome to check out my tesla_journal repo (https://github.com/emilfors/tesla_journal) if you need this functionality ASAP. The UI is in Swedish only so far, so sorry about that. Work in progress.

You're welcome to check out my tesla_journal repo (https://github.com/emilfors/tesla_journal) if you need this functionality ASAP. The UI is in Swedish only so far, so sorry about that. Work in progress.

A few notes of feedback - after I have installed:

you should mention in the notes, that if Teslamate is run from the docker-compose (which I assume many are doing, especially those that are less experienced), then postgres should expose the port 5432 (you mention "if on another host".
Swedish not a problem for me :)
for the purpose of tax, a few things would need a change (I assume for most tax-offices):
3.a. You need from a to adresses - not TeslaMate "location names"
3.b. You probably need start and end odometer (please see note above regarding using end_km from previous drive as start_km)
3.c. It is most likely needed to be able to export.... And perhaps consider reversing the order (both dates and start above end for each drive)
3.d. For a report (export or print) it would be beneficial to have the option to hide private or business trips - and only include those relevant... (it is just for me to know where I drive privately - neither my boss nor tax needs to have that detailed info on this :)

And some "bugs" (I assume):

I have data since February 2020 - but I get empty reports for February, March, April and September... No pattern there, so not sure if some bad data (missing end of drives or similar) could break a month report...
(upd: yes - some nil data from end_date..)

And then some of the generic notes:
I like some of the ideas - the grouping/ungrouping is great - and marking of private vs. business equally so, It is super easy to use!
But I am confused why you decided to go this route - and not work within Grafana and the exisitng project?? I assume you maintain your own internal database for the classification and grouping of trips - and haven't added tables to the existing database?? Where is that stored?
Definitely some good ideas - let me know if you need inputs (I can translate to Danish and English with confidence) or testing....

And then some of the generic notes:
I like some of the ideas - the grouping/ungrouping is great - and marking of private vs. business equally so, It is super easy to use!
But I am confused why you decided to go this route - and not work within Grafana and the exisitng project?? I assume you maintain your own internal database for the classification and grouping of trips - and haven't added tables to the existing database?? Where is that stored?

OK - I just browsed the code, and I can see you have added tables in the TeslaMate database... That worries a bit, and I would have preferred a note about that. (but no panic, I assume you are only writing to those 2 tables?
But for the sake of sleeping calm - I would probably go with separate db users for TeslaMate and Tesla_Journal, and make sure the latter can only read from the main tables... But anyway some noise also regarding backup etc...
I really hope you wish to join your ideas in to the main project?? Or is there a compelling reason your would prefer an external program??

Hi Tony, thanks for checking out the project. You're actually its very first user besides me :)
Here's a brief background which I guess will answer a few of your questions. I took delivery of my Tesla late August. I used to have an OBDII dongle-based solution for keeping a drive journal, but soon realized that wouldn't fly with the new car. So I started looking for alternatives. While doing that I came across TeslaMate which seemed like an awesome thing altogether and also like it might suit my journal keeping needs. Unfortunately it didn't, but I thought I could at least leverage its data tracking and tweak the Grafana UI into doing what I needed. So I started trying to do that, I think I spent a couple of weeks on it but eventually gave up. I just couldn't seem to understand how to make Grafana accept input and not just produce data visualizations. I toyed with the idea of modifying TeslaMate itself but that would still mean I'd need to build a separate UI (since I couldn't make Grafana act as one).
Meanwhile, I had to learn Go for a new project at work and so I figured what better way to do that than to build something useful, right? And because I didn't feel like learning two new languages at once (I don't know Elixir at all) I dropped the thought of doing anything with TeslaMate directly. Hence this project.
This wasn't intended for anyone else's use but mine, which may or may not be obvious. That's one reason why I didn't actually consider security at all (i.e. just piggybacking on the teslamate db user). Another is that I didn't know PostgreSQL either and didn't want to spend time figuring out users, access rights and all that. I thought IF that would prove necessary, then that's always something that can be changed later. To answer your question, yes, my project writes two its own two tables only, and reads from the others.
I made the repo public because I thought it might actually be useful to someone else and because I could use some help testing it. As I made this for my own intents and purposes, it caters to Swedish regulations only at this point - as far as I know it's compliant barring the fact that you need to be able to add comments to the trips (so you can let the tax authorities know what they were for). That's what I'm working on now - adding a detailed trip view where you can add that information. After that, the next step is implementing a report generator (probably just spitting out a PDF). And just as you say, in the generated report I intend to include odometer readings, hide the private trips and so on.
TL;DR - I made this in part because I need it personally and in part as a way of teaching myself Go, PostgreSQL, JQuery and a few other things that I needed to learn anyway.

@emilfors:
Makes sense. I really like your take on grouping and marking (business vs. private) - would actually consider using it, and then modify the standard "Dutch tax" report to include/consider/filter based on the marking made in Tesla_Journal....
(but at the same time, I realized that this "Dutch-tax" solves 98% of my need for now - not as elegant as if the classification/filter is done in TeslaMate+Grafana - but doable in Excel :)
And the option to set the type of drive - the default marking - through a webservice (sure it would be easy in Tesla_journal) - so that I would have to think about it, if I just remember to set the proper type before driving - that would be great :)
(and most likely force me to open my TeslaMate installation to the internet - currently it is only addressable on my LAN :)

@emilfors:
I finally got my finger out of wherever i forgot it....... And maintained my 4 corrupted drives in the database...
After having made my first month of mileage reporting - in excel with a dump from the "dutch_tax" report - I realize how much of an improvement the classification AND grouping of drives could be.
A few suggestion:
0. Possibility to replace an address with a custom address (I can possibly solve through geofences in TeslaMate.)

A custom date interval, not just full months (I need to report from 21st through the 20th the following month)
Possibility to only show drives with a specific classification (none, business or personal) - a crude filter.
2.b. I realize you have "printing to PDF" on the to-do, and it would make sense in that - but perhaps also in view itself??
Translation of labels.....
Start and end odometer.... Just because it is probably a good idea to give tax auths even more data :)
A comment of each drive (like purpose or customer)

I REALLY like hos the grouping of trips is designed - easy and efficient. - correct me if I am wrong, but you just use:
Start address and time of first drive in a group - and end address and time of the last drive.
adding the drive time and km (not just from start_odo of first through end_odo of last)
I am not entirely sure how to setup this behavior in Grafana... But perhaps I will attempt on a copy...
@adriankumpf: it would be SO nice, if you could make a switch in the TeslaMate interface - to select default classification of drives (business vs. personal)... Perhaps complying with the table name introduced by Emil??

Hey Tony, sorry for the late reply. Totally swamped with "real" work at the moment so there hasn't been much time to work on this lately. I'm hoping to change that soon :)
As for your suggestions:
0. Yeah I haven't bothered doing anything with addresses and such since that can be done fairly simply through TeslaMate / Grafana.

I hadn't thought of that, I've always reported full calendar months. Shouldn't be a hard thing to fix of course.
Yeah, a filter would be easy enough to implement too of course. I had already planned to include business trips only in the generated report.
Heh. You mean not everyone speaks Swedish? :D
The odometer I thought would just clutter the presentation up, but I am planning to include them in the report (precisely for the reason you mentioned)
Yes, comments are what I'm working on now. Required by the Swedish tax authority.

I'm glad you like the grouping feature! I think it's pretty useful myself. Yes, that's exactly right. Start time and address of the first drive in the group, end time and address of the last and the driven distance and time are the sums of all drives in the group.
Cheers :)


Chorng/update contribution markdown

Could you please help edit this markdown? We don't know about the structure back there and we are not included in the loop for update, e.g., the time interval update you mentioned in the other PR. It is really difficult for me to compile the contributing markdown correctly with the latest update. It is also difficult to create a ymal for new data collections.

@dthiex  could you please do a final review, i think we made the changes from our side already


CMake generates incorrect compilation database with missing include path.

Issue description
With the cmake parameter -DCMAKE_EXPORT_COMPILE_COMMANDS=ON, cmake should generate a compilation database consumed by clang tooling.  The compilation database should contain all necessary include paths.
Steps to reproduce
Using boost as a dependency for illustration: nix-shell -p cmake boost --pure
CMakeLists.txt
add_executable(main main.cc)
find_package(Boost 1.56 REQUIRED COMPONENTS filesystem)
target_link_libraries(main Boost::filesystem)

The generated compilation database does not contain any include path:
[
{
  "directory": "/home/jiaming/Workspace/NixIssues/CMake/nbuild",
  "command": "/nix/store/ppfvi0cfcpdr83klw5kx6si2l260n1gh-gcc-wrapper-9.3.0/bin/g++    -o CMakeFiles/main.dir/main.o -c /home/jiaming/Workspace/NixIssues/CMake/main.cc",
  "file": "/home/jiaming/Workspace/NixIssues/CMake/main.cc"
}
]

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 5.8.0-28-generic, Ubuntu, 20.10 (Groovy Gorilla)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.8`
 - channels(root): `"nixpkgs-21.03pre251181.dd1b7e377f6"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

I think the gcc wrapper is biting us here.
If you unset the following everything should work fine.
unset NIX_CFLAGS_COMPILE_FOR_TARGET
unset NIX_CFLAGS_COMPILE
unset NIX_LDFLAGS
unset NIX_LDFLAGS_FOR_TARGET

IMHO, cmake is also biting us.
cmake probes the compiler and populates a list of include paths (and library paths) that the compiler knows about. Because the nixpkgs gcc wrapper feeds -isystem dir flags to the unwrapped gcc, for every dir in buildInputs, cmake knows the compiler will always find those paths and will not pass those dirs to the compiler at build time.
Ref. https://stackoverflow.com/a/58589570 and direct link to cmake bug: https://gitlab.kitware.com/cmake/cmake/-/issues/17966.
From the above link(s), it seems this is an alternative workaround for the cmake side:
unset(CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES)
unset(CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES)

I wonder if there is a way for us to use something else than -isystem dir, something with "lower priority" so that cmake doesn't put those include paths on its ignore list (e.g. CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES). CPATH maybe?

Still an issue.


Mark task test

Closes #169

Codecov Report
Base: 57.17% // Head: 62.09% // Increases project coverage by +4.91% :tada:

Coverage data is based on head (f605d97) compared to base (db28139).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #236      +/-   ##
============================================
+ Coverage     57.17%   62.09%   +4.91%
- Complexity      547      590      +43
============================================
  Files           109      109
  Lines          2125     2129       +4
  Branches        250      253       +3
============================================
+ Hits           1215     1322     +107
+ Misses          854      741     -113
- Partials         56       66      +10

Impacted Files
Coverage Δ

.../seedu/address/logic/commands/TaskEditCommand.java
0.00% <0.00%> (ø)

...du/address/logic/parser/TaskEditCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/team/Team.java
85.00% <0.00%> (+8.33%)
:arrow_up:

.../java/seedu/address/model/team/UniqueTeamList.java
81.48% <0.00%> (+8.75%)
:arrow_up:

.../java/seedu/address/model/task/UniqueTaskList.java
62.06% <0.00%> (+10.34%)
:arrow_up:

src/main/java/seedu/address/model/AddressBook.java
74.57% <0.00%> (+11.86%)
:arrow_up:

src/main/java/seedu/address/model/task/Task.java
82.22% <0.00%> (+13.33%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
61.22% <0.00%> (+18.36%)
:arrow_up:

...du/address/logic/parser/TaskMarkCommandParser.java
76.92% <0.00%> (+76.92%)
:arrow_up:

.../address/logic/parser/TaskUnmarkCommandParser.java
76.92% <0.00%> (+76.92%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fixed bug in secrets assignment, added logging

Fixes a secret assignment bug
Fixes swarmctl to add SecretID to the SecretReferences
Adds a validation that all secret references have a name and an ID
Adds simple logging to the secrets control api

Signed-off-by: Diogo Monica<EMAIL_ADDRESS>

/cc @aaronlehmann @ehazlett

Unit test failure
--- FAIL: TestAssignmentsInitialNodeTasks (0.47s)
	Error Trace:	dispatcher_test.go:414
	Error:		Not equal: 5 (expected)
			        != 6 (actual)

assignment fix LGTM (not a maintainer)

What is the bug?

/cc @aluzzardi @aaronlehmann

LGTM

Not LGTM
The tests still don't pass.

Current coverage is 56.23% (diff: 67.74%)

Merging #1697 into master will increase coverage by 0.65%

@@             master      #1697   diff @@
==========================================
  Files            89         90     +1
  Lines         14606      14540    -66
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           8117       8176    +59
+ Misses         5418       5278   -140
- Partials       1071       1086    +15

Powered by Codecov. Last update 8148920...596ad76

it's 💚 now

LGTM


There is only one scheduling time for a workflow, but the workflow will be scheduled and executed multiple times

*For better global communication, please give priority to using English description, thx! *
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior, for example:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Which version of Dolphin Scheduler:
-[1.1.0-preview]
Additional context
Add any other context about the problem here.
**Requirement or improvement

Please describe about your requirements or improvement suggestions.

Please provide more information, such as ds version, several masters, can check if the clocks of the following machines are synchronized

At present, the version of dolphin scheduler is 1.1.0, with two masters and three slaves, the clock difference of each server will not exceed 1 minute

Cause no more adding information here, I would close this issue. You could reopen it if you have further question @Cock001 .


Question: What’s the difference between optional-dependencies and dependency-groups in pyproject.toml?

Hi,
I have a question regarding the configuration of dependencies in pyproject.toml.
I’ve noticed that both optional-dependencies and dependency-groups seem to handle optional dependencies in a similar way, so I'm a bit confused about how they differ and when each should be used. Could you clarify the following points?

Purpose: What is the intended purpose of optional-dependencies versus dependency-groups?

Usage Scenarios: In what specific scenarios would it make sense to use one over the other?

Any insights or examples you could provide would be really helpful.
Thanks in advance for your time and assistance!

I was wondering about the same today, looking for some insights here. From my understanding:

optional-dependencies (aka package's extras) are meant to be shipped with your code. However, installing them is optional as they provide "extra" features of your package, maybe supporting a smaller set of users. Think about how pandas handle them. Most users want to work with their core API, ie, with Dataframe or Series data structures with some locally stored csv/parquet files. However, some user wants to have extra features to read/write the data from/to some remote storage. To fulfill this purpose they provide pip install pandas[aws,gcp,fss]

dependencies-groups are still optional dependencies, but are not meant to be shipped with your package. I'm thinking about all those dependencies that help to support your package development activities (testing, linting, formatting, QA, etc,). Indeed they're called dev dependencies in the doc

I think it's more about what ends up in the published package than how they are handled by uv. In theory, you can move all your optional-dependencies into the optional-dependencies table and vice-versa, ending up with the same amount of resolved/installed packages in your venv.
Moreover optional-dependencies are part of the the pep 621 standard specification while dependencies-groups is uv specific. Therefore, the former also works with other pep 621 compliant tools (eg. pip) while the latter only with uv.
I'm new to uv, so they are just considerations. Probably some contributor could shed more light on the rationale behind this feature :smiley:

PEP 735 – Dependency Groups in pyproject.toml. project.optional-dependencies are part of your published package and can be installed by the end user via pip install your-package[some-extra] while dependency groups are not published with your package.

Thanks for pointing it out @Ravencentric, I was not aware of it :-)

@PRFina Thanks for your response; it was really helpful!

See also: https://github.com/astral-sh/uv/issues/8981#issuecomment-2466787211.


Mixing ratios become wrong beyond the critical point

Both Aeolus and the standalone general adiabat crash beyond the critical point of water, at different places depending on how we set the composition...
Cases tried so far:
Ts = 650 K ; p(N2) = 1e5 Pa ; p(H2O) = p_sat(Ts) => P_surf = 578 bars. This worked fine using vol_mixing but crashed using vol_partial.
Ts = 700 K ; p(N2) = 1e5 Pa ; p(H2O) = p_sat(Ts) => P_surf = 1045 bars. This crashes with both vol_mixing and vol_partial.
It goes wrong inside the dlnT_dlnP_d routine of the general adiabat, the eta_vol = atm.x_gas[vol][idx] / atm.xd[idx] goes NaN because xd goes to 1e-10 and x_gas[H2O] goes far beyond 1.

Possibly linked to #1.


Make sure the ceph user and group is always present

Some installation types do not have ceph user or Group. This change
ensures that user and group are always present and created if this
is not the case.
Closes: ceph/ceph-ansible#2250

Learned a bit more about variable precedence in ansible. Can be closed as invalid.


Replace the brain guy

Sent in Slack, please change the home screen with updated brain dude so it's more clear.

also added a splash screen


Better File Structure

With addition of new features our source code is getting bigger and bigger. We currently have reference.js (4k lines of code) which uses core.js (3k) and utilities.js (1.5k). We don't have a good structure for our files.
We could break them into more files. Each one responsible for one part of the API. For instance putting all the ReferenceColumn logic into its own file. Since we are not exposing classes, then they will not have access to the classes of other files. To solve this problem, we can change our build step to put all the content of files into a single module. Instead of extending the module in each file.
We should investigate for potential solutions.

@RFSH @jrchudy If I am not mistaken, you guys have already done this correct? If so, should we close this issue?

We have not yet. We only created a mechanism to allow for easily merging all the code into one single module at build time. We have yet to reduce the content of some of the js files. For instance, reference.js still contains ~1500 lines worth of code specific to ReferenceColumns and it's sub types.

I am going to close this issue. This can be done as part of any task that includes changing a lot of the code  and I don't think we need a separate issue for it.


When custom infoWindow is shown ui updates not synced

When marker is changed custom infowindow content is not synced

@rustamsmax Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.

Related to #46


Pr/dynamic

Replaces #269
This is #269 rebased plus fixed the test so it runs all the time and not against remote repo

@JakeGinnivan
When I ran this, after the following line:

I checked the _dynamicrepository directory expecting to see a .git repo.
Instead I see an empty folder:

Is this correct? I was kind of expecting to see my git repo located there!

@GeertvanHorrik help! :)

@dazinator do you have hidden folders turned on? the .git folder could be hidden. The code says not to check anything out

Ah gees - I am using a new laptop today - and yes.. do not show hidden files is turned on.

Hits self on head with large object

Cool - this seems to be running well based on my own local testing. I have not tried plugging it in to a team city build yet, I'm curious to know if it will allow the checkout on agent scenario. I will try that next. Cheers Guys!

We do a bare clone (not a checkout since we don't need that). That means that you only have the hidden .git folder. For another project, GitLink, I have created this:
https://github.com/CatenaLogic/GitLink/blob/develop/src/GitLink/TemporaryFilesContext.cs
Maybe good to copy/paste to ensure the removing of temporary files? Or are they already being deleted? (I am not sure, done so many projects I simply forgot).

@JakeGinnivan @GeertvanHorrik  - I found a problem.
Because we don't checkout the repo - the files don't exist on disk. This includes the "NextVersion.txt" file which GitVersion expects to be on disk in the repo directory - so it won't ever find that file at the moment!
I'm not that familiar with Git (as you well know) - would it be possible to query the git repo to see if has such a file and then if it does, check it out? I think that's the only bit that's missing.

ok going merge this. @dazinator can u raise a new issue for the nextversion issue and we will work on that separately.

It should be supported, see https://github.com/ParticularLabs/GitVersion/blob/ca002ed570b03f2f3a610523ab79adf34848fdc1/GitVersionExe/GitPreparer.cs#L105

Thanks @GeertvanHorrik - from looking at that code - it seems that nextversion txt checkout only happens if you pass in a targetbranch argument - which I'm not doing so that may explain it. I'll raise a seperate issue

@dazinator thanks

@dazinator thanks


Support for std::string_view in sf::String?

Noticed today when trying to load an sf::Text that when a function requires an sf::String argument, std::string_view will not work, since there's no conversion. I'm not sure what the status is in terms of what C++ version most users are on, but it would be handy to have an overload for sf::String to accept std::string_view as an initialization argument. I reckon it could be segregated into a preprocessor block that checks for support before including it.
This would imply overloads for

String::String(const std::string& ansiString, const std::locale& locale)
String::String(const wchar_t* wideString)
String::String(const std::basic_string& utf32String)

...and the inclusion of <string_view> in the header.
Thinking about it for a minute, the only potential issue that jumps out at me is that it would require some code repetition. This could potentially be avoided by having the acting overload accept std::string_view (or variant) as the relevant argument, then having the overloads simply forward their arguments into that function, since std::string_view will convert from the relevant types. If compatibility is a concern, then the preprocessor checks could just be in the header file, blocking the inclusion of <string_view> and the declaration of the overloads that use it in that scope, effectively making it an internal implementation detail, although that could potentially be an issue for users who compile the library themselves.
I'm not sure what the posture of the project is towards this kind of thing, but I figured I'd make the suggestion.
Cheers.

P.S. - I'm aware that I can just enclose the sv in a std::string when passing it. I just wanted to propose the feature.

I'm not sure what the status is in terms of what C++ version most users are on

SFML 3 (in development in master) uses C++17 so this is available to us and we've already started using std::string_view in a few places, mostly internally. I'm open to this idea. Is it something you're willing to write a PR for?

I'd need to set up cmake and all that for it, which I haven't done in a few years, but I have tomorrow off. I'll take a whack at it.

Should the PR be for the 2.6.x branch?

No, as std::string_view is a C++17 feature and SFML 2.6 remains on C++03

Where should a PR for SFML3 be submitted?
On Tue, Mar 14, 2023, 2:09 AM Lukas Dürrenberger @.***>
wrote:

Should the PR be for the 2.6.x branch?
No, as std::string_view is a C++17 feature and SFML 2.6 remains on C++03
—
Reply to this email directly, view it on GitHub
https://github.com/SFML/SFML/issues/2445#issuecomment-1467688419, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXDSQBYBVN7SUPAMYQGQTDW4AYWJANCNFSM6AAAAAAVZ4464U
.
You are receiving this because you authored the thread.Message ID:
@.***>

Target the master branch

@ChrisThrasher, Sorry for missing that when you said it in your initial post. I wasn't really on top of my game last night.
I was able to implement this, but in testing I found that functions expecting a const sf::String& weren't able to carry out the two stares of conversion required to go from std::string to std::string_view to sf::String. I was able to resolve this by adding delegating constructors with the original signature, but those are the extra overloads that Chris was concerned about. I don't think there's a simpler way to get around the issue.
I've posted what I've got for now and I'll wait to hear back.


upgrade pause image to 3.5 for non-root

After https://github.com/kubernetes/k8s.io/pull/1793 is promoted, update pause image in containerd

cc @dims

/ok-to-test

To move this forward, should we add a param pauseImageRunAsUser in containerd configuration files?
Then we can define a specified user in containerd.
Some users are using the k8s cluster in local env, and the pause image is from a private repo. The current behavior is based on the pause image user. If you use pause:3.5, it is default not-root. If you use pause:3.4.1, the default is root.
If we can force the RunAsUser in containerd config, it would restrict user to run pause as non-root.

FYI upstream opted not to ship it in dockershim etc. until the next release cycle https://github.com/kubernetes/kubernetes/pull/100292


[Upgrade to Next 12] - WIP

Description
To update repo to use latest version of nextJS.
There is branch WIP - feature/update_next_and_its_deps
It has the latest version of the following libraries

chakra
next
next-seo
next-mdx-remote

Issues

Faced an issue with node version, as next bumped the minimum required node version from 12.0 to 12.22

Solution: Use bash terminal which has the latest node version, v14.7.5

Nvm is installed in bash terminal
If nvm common not found in bash then troubleshoot - https://github.com/nvm-sh/nvm#troubleshooting-on-linux
bash: source ~/.bashrc
Then bash should by default have node version 14x
node —version
v14.7.5

Unable to start the server. React is not defined

This is because next now uses SWC compiler instead of babel. Chakra uses emotion which has a dependency on babel plugin.
The porting of this babel plugin into SWC is in progress - Port @emotion/babel-plugin to SWC. Hence, waiting for it to complete the next update.
The issue was because of JSX pragma being used to style some of the elements in the components. As a workaround, those css props were removed and replaced with chakra props 😄.
This is no longer a blocker.
Progress Overview

[x] Update chakra
[x] Update next and all related deps
[x]  Fix node issue
[x] Fix React not defined issue

Faced one more issue, because of chakra upgrade from 1.3 to 1.7. https://github.com/chakra-ui/chakra-ui/issues/4226#issuecomment-904630320.
For a workaround, I have removed the ThemeOverride type for overrides - commit

Next 12 also forces an incremental config in tsconfig.js, which makes union from chakra-ui theme don't show at all, and it's a very annoying bug because it doesn't notice in logs and we can't differ if was a config in IDE or was that from packages versions..

Hi @ruansenadev
I am not quite sure what is the issue you are facing. I am guessing it's related to the type of theme we are passing to extendTheme function and tsconfig.
I didn't face any issue with chara-ui theme being displayed when I write code. If you give an example I will check if it's happening for me or not.
Thank you.


keep missed comments appearing after the struct/enum ident

Close #1096

few PRs including this one are failing because of https://github.com/rust-lang/rust/issues/59731

Thanks!


Add RSS support for commits (per branch)

option to follow commits on branches via rss
pull to get inspiration how to add rss: https://github.com/go-gitea/gitea/pull/21696
more info at #19071

Do you expect that will support per-file feeds? GitHub supports this and I find it useful for some projects to watch the commits on an individual file.

@adamcstephens can you provide an example url?

@6543 Yep, you can get one for any file. Browse to the file, then the commit history of that file, and add .atom to the end of the URL.
e.g. https://github.com/go-gitea/gitea/commits/main/README.md.atom


Dagger 2 for dependency injection

Are there any plans on using Dagger 2 for dependency injection in this project? Would be great with a working Android sample using this together with view models and repositories.

While Dagger 2 is great for dependency injection, the focus of this project is on Android Jetpack and the framework.


is it ok to request animation?

I'd like to request one, if it's ok.

Describe your animation, the community can help you :)

https://codepen.io/diomed/pen/jjYZov
animation is already made by someone else, in this pen, but it glitches.
if one could make a non glitching version that would be perfect.

#14 Check these PR

@luan0ap I've checked. It should be a bit faster.

@luan0ap I've managed to make it a bit faster, but I notice tiny red lines below and above.
can they be removed somehow? they're not so noticeable, but I have an eye for those tiny details 😛


get_grad_norm_direct: fix a case of empty norm group

fix for #5145
empty norm group create a norm tensor with shape=[1], while other norms will be shapeless. torch.stack does not support such case. Fixing empty group norm to be shapless as well, instead of shape=[1].

Hello @nelyahu,
Thanks for the PR, had to make a quick change from:
total_norm = torch.FloatTensor(0.0).to(self.device)

to:
total_norm = torch.tensor(0.0, dtype=torch.float32).to(self.device)

due to torch.FloatTensor not supporting initialization in that manner i.e.:
TypeError: new(): data must be a sequence (got float)

Tested the prallelism again and all looks good:

TP
PP
DP
Pass/Fail

2
1
1
PASS

1
2
1
PASS

1
1
2
PASS

2
2
1
PASS

1
2
2
PASS

2
1
2
PASS

2
2
2
PASS


[Bug][Connector-V2][Assert] AssertSinkWriter supports multiple concurrent operations

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
The current AssertSinkWriter has a bug in the Close method to verify whether the data has been run completely, especially when dealing with multiple concurrent instances.
For example, if there are two AssertSinkWriter threads A and B, and A has finished running while B has not, A will execute the close method to count whether the overall execution is complete.
The correct logic is to perform validation after all threads have completed running, or alternatively, thread A only verifies the data it runs.

link #8356

Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can use this configuration file to reproduce this issue
env {
  job.mode = "BATCH"
}

source {
  FakeSource {
    parallelism = 1
    tables_configs = [
      {
        row.num = 1000
        schema = {
          table = "test.abc"
          columns = [
            {
              name = "id"
              type = "bigint"
            },
            {
              name = "name"
              type = "string"
            },
            {
              name = "age"
              type = "int"
            }
          ]
        }
      },
      {
        row.num = 1000
        schema = {
          table = "test.xyz"
          columns = [
            {
              name = "id"
              type = "bigint"
            },
            {
              name = "name"
              type = "string"
            },
            {
              name = "age"
              type = "int"
            }
          ]
        }
      },
      {
        row.num = 1000
        schema = {
          table = "test.www"
          columns = [
            {
              name = "id"
              type = "bigint"
            },
            {
              name = "name"
              type = "string"
            },
            {
              name = "age"
              type = "int"
            }
          ]
        }
      }
    ]
  }
}

transform {
  FilterRowKind {
    table_match_regex = "test.a.*"
    table_transform = [{
      table_path = "test.xyz"
      exclude_kinds = ["INSERT"]
    }]
    exclude_kinds = ["INSERT"]
  }
}

sink {
  Assert {
    rules =
      {
        tables_configs = [
          {
            table_path = "test.abc"
            row_rules = [
              {
                rule_type = MIN_ROW
                rule_value = 0
              },
              {
                rule_type = MAX_ROW
                rule_value = 0
              }
            ]
          },
          {
            table_path = "test.xyz"
            row_rules = [
              {
                rule_type = MIN_ROW
                rule_value = 0
              },
              {
                rule_type = MAX_ROW
                rule_value = 0
              }
            ]
          },
          {
            table_path = "test.www"
            row_rules = [
              {
                rule_type = MIN_ROW
                rule_value = 1000
              },
              {
                rule_type = MAX_ROW
                rule_value = 1000
              }
            ]
          }
        ]
      }
  }
}

I'm in 'rehabilitation training' [/dog], if I have time I can try this issue


Implement the project page design and functionality [large feature]

Description
We need to have a paginated project page where we display all the Open Source projects. When a user clicks on the projects button on the navbar, this is the page they should view. This is a large feature and multiple people can work on it. These are the tasks you should complete:
Design - https://www.figma.com/design/mALWb4e0vqfBbtRwop3g16/AFOS?node-id=2019-4439&t=IpmdXDgKlYiLWOeE-0
Tasks

[ ] Implement the mobile and desktop view of the project page as per the design.
[ ] Apply pagination - we're using Shadcn UI for pagination and creating the cards
[ ] Create a search functionality. You can use JSON dummy data for now as we figure out the endpoint
[ ] Include search filters functionality as per the design

Good practice

Implement type safety where necessary
Ensure the mobile designs are responsive

@CatherineKiiru I want to contribute can you assign it to me please?

Hi, @ozaharsh95 I've assigned you!

Hi @CatherineKiiru I'd love to contribute. Is there any issue I could work on? If yes, please assign me. Thanks.

Hi @CatherineKiiru, Can I be assigned too? Thanks.

Hi @ozaharsh95 I'd like you to work with @Giftea and @komenAnna. What sections can you collaborate on?

@CatherineKiiru ,
I have done pagination and view tasks but filter and search functionality are left to be implemented.
And also the react components implemented as jsx components do we need to convert them to tsx ?

@CatherineKiiru ,
I have done pagination and view tasks but filter and search functionality are left to be implemented.
And also the react components implemented as jsx components do we need to convert them to tsx ?

Hello @ozaharsh95, can you create a PR?

@CatherineKiiru ,
I have done pagination and view tasks but filter and search functionality are left to be implemented.
And also the react components implemented as jsx components do we need to convert them to tsx ?

Hello @ozaharsh95, can you create a PR?

YES @Giftea

@CatherineKiiru ,
I have done pagination and view tasks but filter and search functionality are left to be implemented.
And also the react components implemented as jsx components do we need to convert them to tsx ?

Hi @ozaharsh95  write in jsx for now, I'll refactor it. I am refactoring the codebase to tsx

@CatherineKiiru ,
I have done pagination and view tasks but filter and search functionality are left to be implemented.
And also the react components implemented as jsx components do we need to convert them to tsx ?

Hi @ozaharsh95 write in jsx for now, I'll refactor it. I am refactoring the codebase to tsx

@CatherineKiiru Okay Thanks for guiding.

@Giftea can you work on the filter and search functionality? cc @ozaharsh95

@Giftea can you work on the filter and search functionality? cc @ozaharsh95

Yes I can

@ozaharsh95 Can you invite me to your Fork?
Email<EMAIL_ADDRESS>Username: Giftea

@ozaharsh95 Can you invite me to your Fork?
Email<EMAIL_ADDRESS>Username: Giftea

yes sure

@CatherineKiiru Is there a Figma prototype that demonstrates the flow of the "search filters functionality"?

@CatherineKiiru Is there a Figma prototype that demonstrates the flow of the "search filters functionality"?

No

Hi @CatherineKiiru is there are any tasks that are not yet completed. If so, I would be happy to contribute to them. Please let me know if I can assist with any ongoing tasks or issues.

Hi @Shubhankar-1 I'll let you know once I create more issues


fix: set user metadata key to lowercase

What problem are we solving?

After we migrated from ceph s3 to SeaweedFS, we found that the metadata key has changed, so we changed the returned key according to the aws standard
How are we solving the problem?
replace return result

@chrislusf Is it necessary to add a configuration item to control whether to convert to lowercase, so that it will not affect the original user

should be fine. most clients should be using case insensitive.


Add another nightly workflow to publish nightly packages off of features/conditional-compilation branch (to get beta features).

Why
We've removed all beta features from main in preparation for GA. But we'd like our alpha packages to include those.
How Tested
Prayed to the GH gods.

It will be interesting to put a build from this conditional branch into self hosting to see if there are any unforseen bugs at runtime?

Maybe it's just me but the filename nightly-ci-beta made me think that it was a beta release pipeline.

Maybe it's just me but the filename nightly-ci-beta made me think that it was a beta release pipeline.

Renamed.

See the simpler https://github.com/Azure/communication-ui-library/pull/1193 instead.


[DRAFT] Blurhash

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

I have been playing around with trying to make perform better with little luck.

I have created a breakout PR for just rendering blurhash. See https://github.com/google/web-stories-wp/pull/9941. Let's merge that first.

Just converting to draft again to save some Percy snapshots :-)

@spacedmonkey So I briefly looked into how we could possibly optimize this by reducing main thread work.
Some observations:
From what I can tell, we can't put color-thief in a worker, because it requires the DOM. Its API is designed so that it takes an image URL and creates a Canvas from that.
On the other hand, blurhash doesn't do that as it just accepts an Uint8ClampedArray as its first argument. So we could load the image into a canvas ourselves and then transfer control over it to a worker. So blurhash would do the encoding on this OffscreenCanvas all in the worker.
The downside: this method is not available in Firefox and Safari. So using it might be considered progressive enhancement and we could fall back to some other method.
That said, we could still optimize color-thief usage — and in fact all resource backfilling (muted, poster generation) by using requestIdleCallback so we prevent latency as much as possible.
Coincidentally, Max is working on some simple task queue handler in #9700 using requestIdleCallback, which is exactly what we'd need.
https://github.com/google/web-stories-wp/blob/cea8fd3081a26a786e2186c3569e660a6bc85b9c/packages/story-editor/src/app/pageDataUrls/pageDataUrlsProvider.js
Maybe we could turn it into a reusable useTaskQueue() hook or something that we use for all media backfilling.


doas: don't configure pamdir

In the future, doas won't ship PAM files (see
https://github.com/Duncaen/OpenDoas/commit/cfa9f0d3b306d6c1287ec4f2aa42be29de66c9de),
and we already configure PAM in the doas module. Configuring the pamdir
serves no purpose.

Motivation for this change
I received an e-mail from Duncan about the recent doas CVE, where (following the disclosure of the fact he filed a CVE) he notified me that doas will stop shipping PAM files in the future. Seeing as how the presence (or lack thereof) of these files doesn't affect us (the doas module already configures PAM for it), I thought it best to just remove it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg test doas

@ofborg build doas doas.passthru.tests
@ofborg eval


Fix page tree node slug validation to prevent URL encoded characters

Improve the Slug validation to filter out url escaped special characters to prevent path traversal attacks

PR Checklist

[x] Verify if the change requires a changeset. See CONTRIBUTING.md
[x] Link to the respective task if one exists: COM-788
[x] Provide screenshots/screencasts if the change contains visual changes

This would be were suitable for a unit test

Please write a description for your PR

This validation should also be adapted in the API: https://github.com/vivid-planet/comet/blob/main/packages/api/cms-api/src/common/validators/is-slug.ts

you are removing url encoded special characters (%ab)

But you are also:

you are removing ~ and . from the allowed chars
you are not allowing uppercase letters anymore
not allowing - or _ a at the beginning (eg. -abc is not allowed)
not allowing more than one - or _ (eg. abc--123 is not allowed)
not allowing - or _ a the and (eg. abc- is not allowed)

(at least that is what I observed by looking at your regex)
That should all have been explained in the description, together with reasons for the change.

And as support for encoded special chars was explicitly implemented, are we really sure we can remove it? What was it originally inteded for?

And as support for encoded special chars was explicitly implemented, are we really sure we can remove it? What was it originally inteded for?

Was this explicitly implemented?
Background: In a recent pen test it was concerned that certain characters in the slug input aren't allowed, but that the url-encoded variants of those characters are allowed.

Was this explicitly implemented?

@fichtnerma could you please check when and why this was originally implemented?

Was this explicitly implemented?

@fichtnerma could you please check when and why this was originally implemented?

This validation was added before this repository was moved over to github and as far as i can tell this was not implemented for a specific reason other than the regex supporting all allowed chars in a URI according to https://tools.ietf.org/html/rfc3986#section-2.1

@fichtnerma please address this concern: https://github.com/vivid-planet/comet/pull/2229#issuecomment-2242463328. IMO we should only remove the URL encoded characters here.

you are removing url encoded special characters (%ab)

But you are also:

you are removing ~ and . from the allowed chars
you are not allowing uppercase letters anymore
not allowing - or _ a at the beginning (eg. -abc is not allowed)
not allowing more than one - or _ (eg. abc--123 is not allowed)
not allowing - or _ a the and (eg. abc- is not allowed)

(at least that is what I observed by looking at your regex)
That should all have been explained in the description, together with reasons for the change.
And as support for encoded special chars was explicitly implemented, are we really sure we can remove it? What was it originally inteded for?

I have adjusted the validator to only fail if a slash was provided.
The rest of your examples do now work again and were added as tests.

In the linked task it also mentions ".". Wouldn't it be better to remove URL encoding altogether?

@fichtnerma we discussed this in last week's meeting: Please remove support for URL encoded characters in general (as it's supposedly a security issue).


[Bug]: Cannot convert the confmap.Conf: environment variable "1" has invalid name

Welcome to the AWS Observability Accelerator

[X] Yes, I've searched similar issues on GitHub and didn't find any.

AWS Observability Accelerator Release version
v2.12.0
What is your environment, configuration and the example used?
Environment: EKS observability, EKS version 1.29.
EKS ADOT Add-on version: v0.102.0
Configuration: using https://github.com/aws-observability/terraform-aws-observability-accelerator/blob/[…]ks-monitoring/otel-config/templates/opentelemetrycollector.yaml
Example used: https://aws-observability.github.io/terraform-aws-observability-accelerator/eks/
What did you do and What did you see instead?
I followed the instructions.
Errors: Error: failed to resolve config: cannot resolve the configuration: cannot convert the confmap.Conf: environment variable "1" has invalid name: must match regex ^[a-zA-Z_][a-zA- ││

Other:
I have tested with v0.104.0, v0.107.0, v0.108.0 all same errors
otel Chart.yml
apiVersion: v2
name: opentelemetry
description: A Helm chart to install otel operator
type: application
version: 0.8.0
appVersion: 0.108.0

Additional Information
Interesting things is I followed the instructions and deployed whole observability resources about 2 weeks ago and everything works fine.

The issue is because of this line.
Please change replacement: $1 to replacement: $$1

Ran into same issue. No more errors after replacing $$1 with $${1} and $$2 with $${2}
AWS have to make this fix in their example. Until then have to download the module and make the changes locally.

#281 should address this


:undefined method `primary_key' for Class:Class. when recipient: self

I can't find any other way to set the recipient to the current user, so trying this way, it fails with message :undefined method `primary_key' for Class:Class.

Just another point.
Recipient stopped updating itself on the database and I tried this implementation from here :
https://github.com/pokonski/public_activity/issues/187
I am not sure why this works, but it surely does (tested):
tracked owner: ->(c,m){ m.owner }, recipient: ->(c,m){ m.user }

I have to use
    tracked recipient: proc {|_, investment| investment}

Yeah this is my mistake from some time ago, the proc takes controller and
model in that order, which doesn't make sense. You can use a symbol instead
which will be equivalent in your cases.
On Feb 27, 2015 12:15 PM, "Karl Entwistle"<EMAIL_ADDRESS>wrote:

I have to use
tracked recipient: proc {|_, investment| investment}

—
Reply to this email directly or view it on GitHub
https://github.com/pokonski/public_activity/issues/191#issuecomment-76379488
.


Time Series: Missing support for Nanosecond precision

What happened:
When I query the time field that includes nanoseconds (e.g. time DateTime64(9)), the data points gets cropped (in time) to the nearest millisecond, losing the information of microseconds & nanoseconds. But these data are important to me and I want to visualize the actual series of events how it happened during that one millisecond.
What you expected to happen:
To visualize the data points in time as they happened, without cropping the micros & nanos.
How to reproduce it (as minimally and precisely as possible):
Create table:
CREATE TABLE nanos (
  time DateTime64(9),
  value UInt32
) ENGINE = MergeTree
  ORDER BY time;

Fill it with some nanosecond data throughout 3 milliseconds:
INSERT INTO nanos SELECT
  now() + INTERVAL (number * 111111) NANOSECOND,
  number
FROM numbers(30);

What we'll get:
SELECT *
FROM nanos

┌──────────────────────────time─┬─value─┐
│ 2024-03-22 08:20:20.000000000 │     0 │
│ 2024-03-22 08:20:20.000111111 │     1 │
│ 2024-03-22 08:20:20.000222222 │     2 │
│ 2024-03-22 08:20:20.000333333 │     3 │
│ 2024-03-22 08:20:20.000444444 │     4 │
│ 2024-03-22 08:20:20.000555555 │     5 │
│ 2024-03-22 08:20:20.000666666 │     6 │
│ 2024-03-22 08:20:20.000777777 │     7 │
│ 2024-03-22 08:20:20.000888888 │     8 │
│ 2024-03-22 08:20:20.000999999 │     9 │
│ 2024-03-22 08:20:20.001111110 │    10 │
│ 2024-03-22 08:20:20.001222221 │    11 │
│ 2024-03-22 08:20:20.001333332 │    12 │
│ 2024-03-22 08:20:20.001444443 │    13 │
│ 2024-03-22 08:20:20.001555554 │    14 │
│ 2024-03-22 08:20:20.001666665 │    15 │
│ 2024-03-22 08:20:20.001777776 │    16 │
│ 2024-03-22 08:20:20.001888887 │    17 │
│ 2024-03-22 08:20:20.001999998 │    18 │
│ 2024-03-22 08:20:20.002111109 │    19 │
│ 2024-03-22 08:20:20.002222220 │    20 │
│ 2024-03-22 08:20:20.002333331 │    21 │
│ 2024-03-22 08:20:20.002444442 │    22 │
│ 2024-03-22 08:20:20.002555553 │    23 │
│ 2024-03-22 08:20:20.002666664 │    24 │
│ 2024-03-22 08:20:20.002777775 │    25 │
│ 2024-03-22 08:20:20.002888886 │    26 │
│ 2024-03-22 08:20:20.002999997 │    27 │
│ 2024-03-22 08:20:20.003111108 │    28 │
│ 2024-03-22 08:20:20.003222219 │    29 │
└───────────────────────────────┴───────┘

Screenshots

Anything else we need to know?:
🤷
Environment:

Grafana version: v10.0.2 (but this should be enough)
Plugin version: Don't know how to find out, but I've just installed it, so it's probably latest
OS Grafana is installed on: Docker image
User OS & Browser: Ubuntu 22.04 / Chrome Version 123.0.6312.58 (Official Build) (64-bit)
Others:

I believe this is a limitation of Grafana. The data is actually returned with nanoseconds to the browser (you can see the nanos field in the query inspector), but it will not be displayed on most panels. Internally it gets converted to a JavaScript Date, and those are limited to milliseconds. The same goes for the dashboard time range, so you cant even filter time ranges less than 1ms apart.
You might be able to find a workaround by converting the time to Unix nanos, and then instead of using a time chart just use a number chart, but filtering will be difficult. Keep in mind you might also need to scale the number to fit within JavaScript's number limit to prevent rounding issues.
Related discussion on Grafana: https://github.com/grafana/grafana/issues/6252#issuecomment-1566460589
Related discussion on this repo https://github.com/grafana/clickhouse-datasource/discussions/479


Some bugfixes

Bugfixes:

canonical headers names
remove temporary directory after upload
bug with checking GatewayAPI existance by name instead of id

Features:
Full DynamoDb access added to default zappa policy. Does it make sense?

Coverage increased (+0.04%) to 93.563% when pulling 0a155c2090503be6f30c50f50a5e796b4f23b4e6 on mialinx:master into 1959059b282f4bc11abc97cefa3b1b8727df9fb0 on Miserlou:master.

Excellent!


<IP_ADDRESS> fw errors on blackhole

<IP_ADDRESS> fw bundle does not work on P150 and P100 Blackhole cards.
SysEng and Devs are working on addressing issues discovered in <IP_ADDRESS>.
https://github.com/tenstorrent/tt-metal/issues/14613
https://github.com/tenstorrent/tt-metal/issues/14617

fyi @abhullar-tt @TTDRosen

BH CI machines seem to work consistently over <IP_ADDRESS> now.
Closing this issue


Any plans to support running on top of XWayland?

I've played a bit around with XWayland and got bumblebee running through vgl without big problems (some window issues, but nothing dramatic).
Are there any plans to support primus on top of XWayland? Should I investigate some time into debugging errors I find?

I don't suppose it would be possible to load the nvidia driver directly into an Xwayland xserver?  It seems excessive to go: nvidia-X-server -> Xwayland xserver -> wl_surface
What I'm suggesting is a second Xwayland server using the nvidia driver instead of the glamor ddx.  Originally the Xwayland server used the normal xorg ddx drivers so it should be possible...?


Add ByteBufAdaptor.intoByteBuf method

Motivation:
During the transition period, it will be convenient to have a utility method for converting a Buffer into a ByteBuf in the most efficient way.
A ByteBufConvertible interface already exists for this purpose, but not all Buffer instances are guarenteed to implement this, and those that did had been broken.
Modification:
Fix the broken ByteBufConvertible implementations.
Add a ByteBufAdaptor.intoByteBuf method that uses ByteBufConvertible when available, and a direct ByteBufAdaptor wrapping when not.
Result:
Converting a Buffer to a ByteBuf is now just one method call away.

@NiteshKant I think this one will be useful to you in #11711


Device interview, missing Binary Switch.

zwave-js-ui: 8.9.0
zwave-js: 10.10.0
Hi Everyone, I finally made the move in my homeassitant to migrate from legacy openzwave to zwavejs ui. So far the migration has worked great. However, I have a device that I just can't get to run.
The device is a: "EBV HeatApp! Floor"
Product Manufacturer: 0x017c
Product Identifiers: 0x0006:0x0003
This is actually a simple binary switch on which you can switch 8 relays. Since the migration only one relay can be switched, the other 7 are either not shown at all or sometimes only shown as readable "Binary Switch vundefined" (see picture).
Is there any way how I can get this device fixed? Maybe disabling the interview and adding the 7 missing relays?

node_26.zip
zwave-js-ui-logs.zip
I would be very happy about any help. The device controls my heating, and its currently snowing :-)

I can certainly add a workaround for this in the driver code, but this seems like you need some more urgent help. This will require editing the cache files while the driver is not connected to a stick.
I'm not sure if this will work, but you could try the following:

Open Z-Wave JS UI, remember your home ID (somewhere in the top right corner)
Go to the store view (in Z-UI), download the 3 .jsonl files which have this home ID in the name
Send me the files (e-mail in my profile), I'll edit in the other endpoints
When you have the files back, pull the stick, replace the files' contents in the store
Put the stick back in.
Maybe: refresh the values for the Binary switches

Thank you very much. Your modified jsonl files have provided urgent relief. It now works as desired. If you want me to test something out here, I'm always happy to do so.

@sheggy012 this should be fixed in the upcoming release (needs re-interview, which would override your manual edits). If you're adventurous, give it a test please.


on_member_join(member)

Summary
on_member_join(member) not working?
Reproduction Steps
When trying to trigger the on_member_join event the selfbot doesn't detect any members joining the guild it is in. It could be me using the event wrong but I'm not sure. Any help on this?
Code
@client.event
async def on_member_join(member):
    await member.send("hey")
    print(f"Sent message to {member.username}")

Expected Results
Member object
Actual Results
Nothing
System Information
Windows 10
Checklist

[X] I have searched the open issues for duplicates.
[x] I have shared the entire traceback.
[X] I am using a user token (and it isn't visible in the code).

Additional Information
No response

Unfortunately, that event doesn't work on this library. https://github.com/dolfies/discord.py-self/discussions/42

Updating discord.py-self worked but ran into some issues with aiohttp. This was fixed by updating aiohttp to 3.8.1. Thanks!

Remember that

Remember that chunking only works on guilds with < 1k members.

Does this mean the on_member_join doesn't register joins in servers bigger then 1K?


initial work on using new folder for constant propagation

Adds a flag that switches ConstantPropagation.cpp to use the new folder.
Makes some existing constant propagation tests pass with the new flag.

The next step is to keep making more of the existing constant propagation tests pass with the new flag.
I also noticed that SimplifyCFG.cpp uses the old folder. This PR does not touch that. We'll have to do that at some point.
I certainly won't finish before I leave for my weeklong vacation tomorrow. I'll pick up where I left off when I get back, unless someone else goes ahead and finishes everything while I'm gone.

@swift-ci please test tensorflow

Can one of the admins verify this patch?


Can't submit and check my work in cs50

ADD ISSUE DESCRIPTION HERE
Version: 1.91.0
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

I got a mail , but I can't really get it

/causedByExtension please use your course support channel.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


[Do not merge] Testing CI failure

@haroldrandom, PR #171 is also failing with the same error:
py36 run-test: commands[3] | pytest
Traceback (most recent call last):
  File "/home/travis/build/microsoft/knack/.tox/py36/bin/pytest", line 7, in <module>
    from pytest import main
  File "/home/travis/build/microsoft/knack/.tox/py36/lib/python3.6/site-packages/pytest.py", line 13, in <module>
    from _pytest.fixtures import fixture, yield_fixture
  File "/home/travis/build/microsoft/knack/.tox/py36/lib/python3.6/site-packages/_pytest/fixtures.py", line 839, in <module>
    class FixtureFunctionMarker(object):
  File "/home/travis/build/microsoft/knack/.tox/py36/lib/python3.6/site-packages/_pytest/fixtures.py", line 841, in FixtureFunctionMarker
    params = attr.ib(convert=attr.converters.optional(tuple))
TypeError: attrib() got an unexpected keyword argument 'convert'
ERROR: InvocationError for command /home/travis/build/microsoft/knack/.tox/py36/bin/pytest (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   py36: commands failed
The command "tox" exited with 1.

Seems to be related to https://stackoverflow.com/a/58189684/2199657

CI seems broken. We are fixing it.

Feel free to close this PR.
I am not closing just in case you are tracking CI failure by this.

Close as fix here https://github.com/microsoft/knack/pull/172


Generate deployment manifests from jsonnet

Since most of the projects in the kube-prometheus ecosystem are using jsonnet to generate their manifests, it would be great to do the same in prometheus-adapter.
We could bring the prometheus-adapter.libsonnet file from kube-prometheus here and include it in kube-prometheus. This would require the kube-prometheus contributors to make the changes in this repository which would benefit the ecosystem as a whole. This way we would avoid going into the state we are in where the configuration from this repository drifted from the more up-to-date one in kube-prometheus.

Hi. I am a new contributor and I would like to work on this issue. Can you please guide me through this and assign me the issue?

Hi @jayesh-srivastava, sorry for the delay. Sure, if you are still interested in working on this issue, I can guide you.
What we want to do here is to have manifests generated from jsonnet. In kube-prometheus, the prometheus-adapter manifests are already generated from this jsonnet library. The goal would be to move this file in the project and add some tooling to generate YAML manifests.
If you are not yet familiar with Jsonnet, I would advise having a look at the tutorial on their website as well as looking into how we leverage jsonnet to customize a monitoring stack in kube-prometheus: https://github.com/dgrisonnet/kube-prometheus#customizing-kube-prometheus
The generation should work the following way:

Add library: https://github.com/prometheus-operator/kube-prometheus/blob/main/jsonnet/kube-prometheus/components/prometheus-adapter.libsonnet
Import library in a .jsonnet file: https://github.com/prometheus-operator/kube-prometheus/blob/main/jsonnet/kube-prometheus/main.libsonnet#L8
In the same jsonnet file split the different Kubernetes resources inside of the PrometheusAdapter jsonnet object into different files: https://github.com/prometheus-operator/kube-prometheus/blob/main/example.jsonnet#L34
Lastly, generate yaml manifests by running build.sh $jsonnet_file

Hey @dgrisonnet Thank you for the guidance. I see this issue is closed. So probably I can't work on this right?

This issue is still opened, I closed a duplicate. If you want to work on this feel free to assign this issue to yourself by commenting /assign.

Ok thank you much.

/assign

/remove-lifecycle rotten

/reopen

/remove-lifecycle rotten


support gemini 1114

Issue
I don't see it in the benchmarks is it supported? it's free
Version and model info
gemini-1114

I meant gemini-exp-1121, I apologize

Also it seems the endpoints are vertex endpoints rather than ai studio endpoints?
https://generativelanguage.googleapis.com/v1beta/models/ ?

Thanks for trying aider and filing this issue.
The quotas are so low it's very hard to benchmark at the moment.

it got solved


A discussion on the "module" property in package.json

Where target: "web" is set inside Webpack, it defaults resolve.mainFields to be ["browser", "module", "main"].
I'm running into issues whereby certain libraries like https://github.com/krisk/fuse (amongst others) are not transpiling the code they reference via module. This means that where module is prioritised over main, certain cutting-edge features are making it into the bundle file, hence resulting in poor browser compatibility.
The argument can be made that libraries should transpile their module output by default whilst keeping ES Module support; however, this doesn't seem to be standardised, and to me it seems like an uphill battle to enforce our interpretation of a non-standard feature (there is no mention in any proposed spec of whether module can or cannot contain cutting-edge JavaScript).

Is this current method of prioritising the module field before main in all circumstances the most appropriate way to handle module resolution?
What is the best approach to ensuring maximum browser compatibility whilst reducing the amount of code to be transpiled during build processes, and preserving features such as tree-shaking?

I am considering a strategy similar to the following:

If browser exists on package.json, load this; if not,
If module exists on package.json and sideEffects is set to false, load this; if not,
If main exists on package.json, load this; if not,
If module exists on package.json, load this.

Any suggestions or thoughts on this issue are welcome! Thanks 😄

Duplicate of #5756, please put feedback here and we will answer you


Re templating#179

@HHildenbrandt
I think I have managed to template everything correctly. Could you let me knwo what you think?
Thanks in advance.


Initial History state replace

In the example test you write:

Note that reloading and bookmarking doesn't work with the "full URL" example, because that requires server-side support that I haven't implemented for the example. (That is, you'd have to adopt a scheme for the full URLs so that the server knows what actual page to send).

Since the example is for a SPA perhaps you should mention that you can have the same page return for all URL.
Anyway, I did exactly that, but I'm not seeing the initial state replace. Suppose you reload the page on /dog/humans. Then the generic SPA backend is served and then the Elm needs an initial kick so that location2messages is called.
It I'm not missing something, how do you usually go about this?

My apologies. I wasn't handling the update correctly.


feat: Sign editor with the advanced editor

fixes #63

[x] Add a setting to disable opening sign editor: Label: Open sign editor. Values: Never, Default (default)

/deploy

/deploy

/deploy

/deploy

/deploy

/deploy

/deploy

/deploy


Hide IntervalCollection from public API

Description
Cleans up the @fluidframework/sequence public API by exposing an interface for IntervalCollection rather than the class. This allows hiding a few other undesirable exports.

this is a draft while I stage the deprecation. will fix merge conflicts and publish after.


springen auf sachen zum damagen

find out which sachen are meant; jumping on bears not recomended

wish from pfail on itch.io:
"The bouncing fireballs are fun, too, but I really wished I could use the bouncing to do damage to the enemies. Could be a fun idea to experiment with."


Add Drone CI support

Almost identical to Travis CI, I just replaced variable names with the ones from http://readme.drone.io/usage/variables/

👍

        1 Warning

  </th>
 </tr>

:warning:
Author @gabro is not a contributor

  Generated by :no_entry_sign: danger

finally! OSX being case-insensitive didn't really help...

Aside from the super tiny changelog change, this LGTM! 🚀

Also, thanks for contributing to Danger!

Changelog edit done, thank you for the great tool!


Deployment Reporting "Execution Exception (state: ValidateAzureResource) (step: Invocation) Error:   Cannot read properties of undefined (reading 'AzureWebJobsStorage')"

Most recent deployment yesterday worked with no issues. No changes to our function environments or publish profile and today we have the following occurring on two Actions:
Successfully parsed SCM credential from publish-profile format.
Using SCM credential for authentication, GitHub Action will not perform resource validation.
(node:1100) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Error: Execution Exception (state: ValidateAzureResource) (step: Invocation)
Error:   Cannot read properties of undefined (reading 'AzureWebJobsStorage')
Error:     TypeError: Cannot read properties of undefined (reading 'AzureWebJobsStorage')
    at ResourceValidator.<anonymous> (D:\a\_actions\Azure\functions-action\v1\lib\handlers\resourceValidator.js:[17](https://github.com/craigeddy/ferretly-backend/actions/runs/5894948324/job/15989655032#step:5:18)8:40)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_actions\Azure\functions-action\v1\lib\handlers\resourceValidator.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Deployment Failed!
https://github.com/Azure/functions-action/issues/181

yaml has:
      - name: 'Run Azure Functions Action'
        uses: Azure/functions-action@v1
        id: fa
        with:
          app-name: 'StagingMaintenance'
          slot-name: 'Production'
          package: '${{ env.AZURE_FUNCTIONAPP_PACKAGE_PATH }}/output'
          publish-profile: ${{ secrets.AZUREAPPSERVICE_PUBLISHPROFILE_902FD29C58B149C787FC9323230F93D7 }}

Same issue, worked yesterday and haven't changed anything but noticed a release was published 2 hours ago.

Same issue, pushes this morning were working and then pushes about an hour ago failing with the noted error.

Also getting same issue.  Was able to deploy 14 hours ago.
Re-ran function deployment 3x, and all jobs failed

Sorry for inconvenience and thank you for reporting. I have reverted the v1 tag to 1.5.0 and actively investigating the issue with 1.5.1.

Sorry for inconvenience and thank you for reporting. I have reverted the v1 tag to 1.5.0 and actively investigating the issue with 1.5.1.

FYI I tried a yaml that had uses<EMAIL_ADDRESS>and had the same error.

Bug fix released for v1.5.1. I'll wait for feedback on v1.5.1 before updating v1. Thanks.

v1 tag is now pointing to v1.5.1 latest release.


Fix incorrect call to Unicode Win32 InetPton

The recent commit for https://github.com/apache/incubator-tvm/pull/4281 is calling the Win32 MACRO InetPton.  If the Visual studio project is set to "Use Unicode Character Set", (which tvm.dll seems to be) this calls InetPtonW, which uses wchar_t* (aka PCWSTR).  This causes a build error as the "addr_buf" is a char*.
From InetPton docs:

When UNICODE or _UNICODE is defined, InetPton is defined to InetPtonW, the Unicode version of this function. The pszAddrString parameter is defined to the PCWSTR data type.
When UNICODE or _UNICODE is not defined, InetPton is defined to InetPtonA, the ANSI version of this function. The ANSI version of this function is always defined as inet_pton. The pszAddrString parameter is defined to the PCSTR data type.

This can be fixed by directly calling InetPtonA, which is safe as the tvm function always uses a char* for add_str and InetPtonA always takes a char* (aka PCSTR)

@jmorrill I have  read the doc: https://docs.microsoft.com/en-us/windows/win32/api/ws2tcpip/nf-ws2tcpip-inetptonw. Seems that Windows has Unix's inet_pton function too. i.e. InetPtonA defines. Do you think we should be better to use inet_pton and needn't distinguish _WIN32 / Unix?
i.e.
inline bool ValidateIP(std::string ip) {
  if (ip == "localhost") {
    return true;
  }
  struct sockaddr_in sa_ipv4;
  struct sockaddr_in6 sa_ipv6;
  bool is_ipv4 = inet_pton(AF_INET, ip.c_str(), &(sa_ipv4.sin_addr));
  bool is_ipv6 = inet_pton(AF_INET6, ip.c_str(), &(sa_ipv6.sin6_addr));
  return is_ipv4 || is_ipv6;
}

And I am curious why we don't function redefinition error because Windows has inet_pton too.

@jmorrill seems there was some problem in rebasing, please cherry pick your windows change and rebase against the master

Sorry you are dealing with a n00b, I'm still new with these git features.
The commit we want is here: https://github.com/apache/incubator-tvm/pull/4306/commits/6f96747698fb89764dd409103e23f900da0efed7

git fetch upstream
git rebase upstream/master
Reports everything up to date

Sorry you are dealing with a n00b, I'm still new with these git features.
The commit we want is here: 6f96747

git fetch upstream
git rebase upstream/master

Reports everything up to date

No worries. Our TVM website has one good Git usage tips: https://docs.tvm.ai/contribute/git_howto.html

Thanks @jmorrill @FrozenGene @soiferj !


Update stack to latest spec

Per spec and inflight changes to be merged:
https://github.com/crossplaneio/crossplane/pull/772/files

links is no longer a map of links -> website, source now fields
description -> readme
Added:  overviewShort - one sentence description
Added: overview - multi line, but relatively short abstract about the stack

Thanks for the report @lukeweber!
Closed by crossplaneio/sample-stack-wordpress#8 and crossplaneio/sample-stack-wordpress#14


Show names not working for "new" project slice by assignee

In the "new" project dashboard, it looks like the Show names function is not working for 1 specific use case.
When creating a view, with the layout dashboard, there is an option to Slice by which ever attribute you want. One of the possible attribute is Assignee. However, unfortunately, the "bar" on the left side (containing each assignee of the project / view) still shows the userID.
It worked before when I used Name instead of UserId for SAP GitHub, but I switched to this extension instead since it has more functionality (thanks for creating it BTW).

FYI I looked at the code and it seems like it might be somewhat related to https://github.com/nikolockenvitz/sap-addon/blob/393d0155cd1d86f36655de09c44a996df7b566ef/content_scripts/github/username.js#L77-L86. Feel free to contact me privately if you want an example
However, I don't really understand this query "language" 😅 . Would be happy to create a PR if you can give a bit of guidance with that!

Hi @etiennnr, thanks for reporting! I can reproduce the issue. The code section you found is indeed where we need to add a query (the two queries there are for the actual assignee column in the table, so we need to add a new query).
Posting a PR would be great! The query language is CSS selectors. You can use your browser's dev tools to inspect the HTML structure (DOM tree) of the page. And based on tag names, classes, and attribute values, we can create a rule to match the corresponding element. The query is later used with document.querySelector() or document.querySelectorAll() respectively. Usually a single space between two selectors is sufficient (to get any child of any depth of the node), but sometimes more advanced combinators are helpful. For the query itself you can take inspiration from the other "new" projects' queries there. Sometimes it's also a bit arbitrary which parts of the "full path" / query selector string to take for the query, and sometimes also a bit common sense / experience what seems useful.
For testing, you can start with your browser's console (document.querySelector("<query>") and potentially then also set up the extension locally (https://github.com/nikolockenvitz/sap-addon/blob/main/CONTRIBUTING.md#readme) to test whether it works end to end.
Let me know if I can assist in any way!

Will try to take some time to do that after the holidays. Thanks for the reply!