Automatic configuration of DHCP makes NAT networks with multiple prefixes unusable

Version Reports:
Distro  version of host:
Arch
Terraform Version Report
v0.11.2
Libvirt version
3.10.0
terraform-provider-libvirt plugin version (git-hash)
29cd517335347ed7a8b190e60664887a9b715f09

Description of Issue/Question
Setup
resource "libvirt_network" "terraform" {
  name      = "terraform"
  domain    = "terraform.local"
  mode      = "nat"
  addresses = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
}

Steps to Reproduce Issue
Attempt to apply the above resource results in:
Error: Error applying plan:

1 error(s) occurred:

* module.infra.module.libvirt.libvirt_network.terraform: 1 error(s) occurred:

* libvirt_network.terraform: Error defining libvirt network: virError(Code=67, Domain=19, Message='unsupported configuration: Multiple IPv4 dhcp sections found -- dhcp is supported only for a single IPv4 address on each network') -   <network>
      <name>terraform</name>
      <bridge stp="on"></bridge>
      <forward mode="nat"></forward>
      <domain name="terraform.local"></domain>
      <ip address="<IP_ADDRESS>" family="ipv4" prefix="24">
          <dhcp>
              <range start="<IP_ADDRESS>" end="<IP_ADDRESS>"></range>
          </dhcp>
      </ip>
      <ip address="<IP_ADDRESS>" family="ipv4" prefix="24">
          <dhcp>
              <range start="<IP_ADDRESS>" end="<IP_ADDRESS>"></range>
          </dhcp>
      </ip>
  </network>

The original intention of having multiple IP ranges was to provide IPv4 as well as IPv6 addresses for the network, as multiple IPv4 addresses do not make much sense (at least for regular users). So this is the expected behaviour, even when we are getting the error from the lower layers of the stack (libvirt).
We could 1) improve documentation and/or 2) do some checks at the terraform-libvirt-provider layer.

It seems it is properly documented here, and the checks at the terraform-libvirt-provider layer would be a nice-to-have feature but not strictly necessary...

The original intention of having multiple IP ranges was to provide IPv4 as well as IPv6 addresses for the network

From an API point of view, these should probably have been two separate string fields then.

multiple IPv4 addresses do not make much sense (at least for regular users)

What is a 'regular user'? I need multiple IP address ranges to replicate a production environment.

We could 1) improve documentation and/or 2) do some checks at the terraform-libvirt-provider layer.

Or:
3) Allow an address range to be configured without enabling DHCP on it?
4) Provide a structure for configuring DHCP properties for an address range?

I don't wish to sound rude, but I'm rather baffled by your attitude towards handling issues on this project, which seems to be that if the project supports whatever precise subset of features you personally require, nothing else is relevant, and issues relating to such features are closed out-of-hand.
Is this the case? Should we not bother reporting issues here and just have everyone work on their own forks to support anything that's not required by your downstream?  That sounds rather painful for any users trying to work out what to do, but if this is the case, it should probably be explicitly documented in the README.

I think you don't need to configure address ranges if you are not going to use DHCP. Just try to not specify addresses and I think DHCP will not be started, so you can configure your interfaces statically in some other way (ie, with cloud-init).

It is not valid to define a NAT network (at least, I suspect some other types may be similarly restricted) without specifying address ranges.  Additionally, libvirt applies iptables rules to the bridge device to ensure that only configured address ranges will pass traffic through the bridge, so it's not possible to use statically configured address ranges without specifying them in the network definition.

What kind of properties are you interested in?

I'm really only interested in being able to disable configuration of dhcp for a range, my thought was that a separate DHCP stanza might be a way to achieve this without breaking changes (though it may not be the most intuitive).

regular users do not use NUMA topologies

The assertion that it's possible to determine with confidence what a regular user is or might want still troubles me, though I don't think multiple IP address ranges are in the same category as NUMA topologies.

If you need some feature that is not present in this provider, I would suggest 1) to fill out an issue specifying your feature request 2) discuss things like the proposed syntax, implementation, etc 3) submit a PR implementing it.

Do I need to file a new issue?  As it may not have been clear - the implication from the initial report here was that I would like to configure multiple address ranges, however multiple address ranges cannot currently be configured, since all ranges enable DHCP.
I need to maintain a fork anyway, since my last PR to allow IP addresses to be output/consumed from modules was rejected (as it is only necessary due to upstream bugs, and apparently you don't feel the need to support modules in the foreseeable future), however I'm happy to submit code for this if there's some guidance as to what might be accepted.


Bump CFPropertyList to >= 3.0.6

CFPropertyList up until 3.0.6 used the File.exists? method, which was deprecated in Ruby 2.7 and removed entirely in Ruby 3.2.
Because puppet-agent 8 vendors Ruby 3.2, this commit bumps CFPropertyList's dependency from ~> 2.2 to >= 3.0.6.
See also: https://github.com/puppetlabs/puppet-runtime/commit/0977603530285ce5af113a5378d7a75fb4c8d624

Blocked on updating Rubocop checks in https://github.com/puppetlabs/puppet/pull/9316


Python37

This PR adds Python 3.7 support

Travis CI slave doesn't have 3.7 installed

@cgoldberg It should pass if you add sudo: true to the py37 travis matrix - https://travis-ci.org/mbeacom/locust/jobs/430394601

@mbeacom thanks!  merging this now


Logseq marketplace

Great plugin! Is possible for author to share this plugin via marketplace?

Would second this. Nice work on this!

thank you! it should be available on marketplace soon


Suggestions for updating readme

I've got this working now but I would have found it easier with the following pointers so these are documentation suggestions that might help others;
show how to bend the sensor to fit the 3D case ( I know this must seem obvious but I scratched my head worrying I'd got the wrong component for a bit)
mention the need to adjust the sensitivity of the photodiode to suit the meter led. I found one of the meters much darker than the other and this took several adjustments to get it working
mention that it is possible to use 2 glow sensors if your solar meter also has a pulse led and integrate this with the Energy dashboard
I found the pulse_meter behaved strangely with the solar meter. I switched to use pulse_counter and it seems to be stable if slower to update - I guess it updates at a lower frequency
I defined an additional pin (I use 13) as solar_pin
great work by the way - I now have a working HA Energy dashboard working for the cost of a few sensors!
Extract from my yaml
sensor:
  - platform: pulse_meter #counter
    name: '${friendly_name} - Power consumption'
    unit_of_measurement: 'W'
    state_class: measurement
    device_class: power
    icon: mdi:flash-outline
    accuracy_decimals: 0
    pin: ${pulse_pin}
    on_value:
      then:
        - light.turn_on:
            id: led_red
            flash_length: 400ms
    filters:
      # multiply value = (60 / imp value) * 1000
      # - multiply: 60
      - lambda: return x * ((60.0 / ${pulse_rate}) * 1000.0);
    total:
      name: '${friendly_name} - Total energy'
      unit_of_measurement: 'kWh'
      icon: mdi:circle-slice-3
      last_reset_type: auto
      state_class: measurement
      device_class: energy
      accuracy_decimals: 3
      filters:
        # multiply value = 1 / imp value
        # - multiply: 0.001
        - lambda: return x * (1.0 / ${pulse_rate});
  - platform: pulse_counter
    name: '${friendly_name} - Solar production'
    unit_of_measurement: 'W'
    state_class: measurement
    device_class: power
    icon: mdi:flash-outline
    accuracy_decimals: 0
    pin: ${solar_pin}
    on_value:
      then:
        - light.turn_on:
            id: led_red
            flash_length: 400ms
    filters:
      # multiply value = (60 / imp value) * 1000
      # - multiply: 60
      - lambda: return x * ((60.0 / ${pulse_rate}) * 1000.0);
    total:
      name: '${friendly_name} - Total solar'
      unit_of_measurement: 'kWh'
      icon: mdi:circle-slice-3
      last_reset_type: auto
      state_class: measurement
      device_class: energy
      accuracy_decimals: 3
      filters:
        # multiply value = 1 / imp value
        # - multiply: 0.001
        - lambda: return x * (1.0 / ${pulse_rate});

How did you power the second one? Splitter from the 3.3v on the espboard?

How did you power the second one? Splitter from the 3.3v on the espboard?

I split off the 5v output on the board. I'm powering the esp32 using a phone charger. I haven't tried off the 3.3v pin. It might also be useful to note that my meter box is outside. I've run wires from the sensors to the esp32 inside the house. It seems that the circuit still works with quite long sensor wires (about 3m) and this might suit other situations.

@DavidREWorthington
I as well had to change to the pulse counter to get mine to be accurate. The default refresh rate of the pulse counter is 60s so it is slower to update however you can increase the refresh rate by adding a different update_interval:
I used 10s
sensor:

platform: pulse_counter
name: '${friendly_name} - Power consumption'
unit_of_measurement: 'W'
state_class: measurement
update_interval: 10s
device_class: power
icon: mdi:flash-outline
accuracy_decimals: 0
pin: ${pulse_pin}
on_value:

For the glow I deliberately did not choose the pulse_counter component. This is not accurate at all for me, because it makes fixed steps in watts.
While the pulse_meter component is just a mix of the pulse_counter and `` pulse_width`, which should result in correct better and more accurate calculations. https://github.com/esphome/esphome/pull/1434#issue-545850359

As for modifying the documentation, anyone is free to create a pull request to add or modify additional information. I like the first 2 points to add more information about it.


Is it possible to create expectation with binary file in request using API?

new MockServerClient("localhost", 1080)
                .when(
                        HttpRequest.request()
                                .withMethod("POST")
                                .withPath("/somePath")
                                .withBody(Files.readAllBytes(File(PATH_TO_PHOTO).toPath()))
                )
                .respond(
                        HttpResponse.response()
                                .withBody("some body")
                                .withStatusCode(200))

How can I create the expectation with binary file in request using mock server API? I did not find any examples in documentation.

Please see the example on the web site:
http://mock-server.com/mock_server/creating_expectations.html#button_match_request_by_binary_body
http://mock-server.com/mock_server/creating_expectations.html#button_response_literal_binary_PNG_body


How to add custom control bar or customize control bar???

please flow the blog post  I hope You will be satisfied
https://medium.com/prototyped/react-native-video-handling-fullscreen-and-controls-on-android-dbb45a2e52ea

Check below documentation to create custom controls
https://infinitbility.com/react-native-video-example-with-custom-control


ACS Chat - Update the method params in factory methods from list to IEnumerable

Addressing comments from https://apiview.dev/Assemblies/Review/0a808c3dd8ed4e6395c092be77b94729
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.Chat


Create native font implementation

use sprites:
https://www.scirra.com/forum/sprite-font-generator-v2_t86546
http://www.isogenicengine.com/tools/fontSheetGenerator/

Implementation is based on https://github.com/dhepper/font8x8

First part (support ASCII chars) was committed on e4ee73890208d39b9bb10533b62b48775d25938f

This implementation is based in ANSI C standard. In the future, I will implement support for UTF-8 (uses ICU library for it).
Basic feature implemented in e4ee738 commit


Filtering for null nested entities

Given the following schema:
type BadgeSpec @entity {
  id: String!
  metadata: SpecMetadata
}

type SpecMetadata @entity {
  id: ID!
  name: String!
}

The BadgeSpec metadata field is populated with the ID of a SpecMetadata entity. At query time, that is used as a lookup to return a SpecMetadata entity, if there is one with a matching ID. If there is no matching ID, the metadata object returns as null.
Users might want to filter for BadgeSpecs with no connected metadata, and might expect the following query to do that:
{
  badgeSpecs(where: {metadata: null}) {
    id
    metadata {
      id
      name
    }
  }
}

However that is not necessarily the current behaviour - filtering badgeSpecs on metadata filters on the value of the metadata field. So if the field is populated with an ID, but there isn't a SpecMetadata entity with that ID, then that BadgeSpec will not be returned. BadgeSpecs will only be returned when the value of the metadata field is itself null. There is currently no way to filter for all badgeSpecs with no connected metadata, regardless of whether the metadata field is populated.
Potential solutions:

Update functionality for nested entities such that the filter reflects the nested entity's ID, so that null applies where entities are not found. This is a change in behaviour, so raises the question: are there valid cases where users wouldn't expect filtering to work in this way?
Update nested filter functionality to filter for "null" IDs, i.e.

badgeSpecs(where: {metadata_: {id: null}}) {
  id
  metadata { id }
}

Maybe metadata_is_null: true / false? Sending null is kind of limiting.
type Query {
  feed: Article
}

type Article {
  id: ID!
  title: String!
  description: String
  body: String!
}

With description_is_null: true we show all articles without descriptions, description_is_null: false would result in the opposite, only articles with with descriptions.

@kamilkisiela yes I think that can make sense as a more explicit filter. Would you make it a specific filter to the nested entity case from the OP?

@kamilkisiela yes I think that can make sense as a more explicit filter. Would you make it a specific filter to the nested entity case from the OP?

I think we can have it for all kinds of fields? (not just nested)
because null can be set on first-level fields that are defined as nullable?

As long as it works for the specific case mentioned (nested entities, where the value in the first-level table is not null, but there is no entity in the child table) - it is already possible to filter for null first-level fields

Given the schema
type BadgeSpec @entity {
  id: String!
  metadata: SpecMetadata
}

type SpecMetadata @entity {
  id: ID!
  name: String!
}

The following query
{ badgeSpecs(where: {metadata_exists: false}) { ... } }

will be translated to:
SELECT ... FROM badge_spec WHERE metadata IS NULL

If it's derived, then the SQL will be:
SELECT ... FROM badge_spec WHERE NOT EXISTS (
  SELECT 1 FROM spec_metadata WHERE badge_spec.metadata = spec_metadata.id
)

Does it make sense, that's what we try to achieve?
Another question. Should we support only 1-to-1 connection?

hey @kamilkisiela that sounds good to me! I think at the outset 1-to-1 is a reasonable starting point


Create a team command to easily update team changes

Title basically says it all, perhaps other parts of the !approve command could also get individual commands for updating users as well. Thanks!

I will add to this actually. When running the !approve just now to change the team, it didn't remove the former team role, only added to my current role set - so my in server color didn't change.

Unsure as of yet if I'll want this to be a mod command or a unprivileged command. I feel like mod would make the most sense as to prevent abuse.
####Mod command
#####Pros

Managed by trusted members of the community
User doesn't have to learn anything

Cons

Users have to wait

####Unprivileged
#####Pros

No wait required, as long as the user knows the command, they can update their team
#####Cons
Users are able to freely reassign their team roles to spy in team chats, this would be undesirable in some guilds

Sorry I missed the reply, Mod and up only for sure. Thanks! :)

Sweet! I'm working on a bug fix for TrainerDex/PogoOCR right now, as that's causing OCR to not work for several people. However, once that's done I'll start working on this as it won't be much work.

Scrap the command, switch to a PokeNav style team OCR team check.
Things we'll want to verify via the team check:

Username matches what we have in file
Find the team
As a bonus, if stats found, update them. Since we're having to call Google Vision API anyway.

Steps:

Update PogoOCR to check for colours, you can find old working code in PokeOCR, your old project.
Since this is the first time we're actively using the username from the OCR, use a tool to check if the username is a close enough match as OCR wasn't 100% accurate on that. @Azelphur, you used a tool for that to detect Pokémon and Gym typos in Monord, do you have any insights?

Development on this has halted. It will still happen, just not yet. Sorry man.


Container issues with honister and later branches

Since OE-Core upgraded glibc to version 2.34, NVIDIA pre-built containers that rely on the Jetson library passthrough mechanism will see application failures, due to mismatches between the host-side libraries being exposed to the container and the older glibc inside the container.
This has always been a risk with the passthrough mechanism, and while we've been able to implement some workarounds for similar issues in the past, it's unlikely we'll be able to do so for this one.

Related discussion thread at https://matrix.to/#/!mKaltPMAHUgQwPUKcH:gitter.im/$O6KhBIqTWBRML8F5YSk3supKrPKWPFLp6F2A7p3DnyY?via=gitter.im&via=matrix.org&via=0m.ax


This can happen when your local repo is "behind" the one in GitHub.  If it's unclear how to get there from here, please feel free to ask.
I see you've called "dibs" on palindrome-products! :)  👍

Thank you. I'll check the state of branch later. Thank you for informing
me. :)
On Fri, Dec 2, 2016 at 10:46 AM, Stuart Kent<EMAIL_ADDRESS>wrote:

Merged #204 https://github.com/exercism/xjava/pull/204.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xjava/pull/204#event-880159044, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIezh-UCpP5IOT2zk4SmIyZbGepM_Oxnks5rED1RgaJpZM4LCqG8
.


feat(cdk/table): virtual scroll directive for tables

Adds a virtualRows directive which enables virtual scrolling for CDK tables.
Open questions
Blocks of code that are subject to further discussion or contain potentially breaking changes are annotated with FIXME.
Out of scope for now

Variable size rows (virtual scroll autosize directive)
Material tables support (let's hash out the CDK variant first)
Checkbox state
Row animations

Known issues

Sticky headers/footers flicker if an animation frame exceeds ~35ms. Karl and I will investigate further.

Performance considerations
We've already improved row rendering by 50% or better. Without headers/footers, the scrolling experience is comparable to most other Angular material virtual scroll demos.
However, the entire table shifts position as the user scrolls. The position of sticky headers and footers must be offset by the distance scrolled to keep them in place. On average, the table is able to keep 15-20ms per animation frame. Frames that occasionally exceed ~35ms cause sticky headers/footers to flicker. It looks like longer than usual style calculations are hindering performance the most.
While I believe we can further optimize rendering, we will likely reach a threshold where the table can no longer be optimized and non-trivial tables will still experience flickering (e.g. tables with inline editing, cells with custom components, etc.). A while back, I experimented with rendering tables in multiple pieces so the body content can scroll independently of header/footers (https://github.com/angular/components/pull/20414). There are some a11y challenges to this solution, but it would resolve the flickering.
For example:

...

Related PRs

https://github.com/angular/components/pull/21704

Since the description mentions an issue with flickering, could it be the same problem as https://github.com/angular/components/issues/21576?

Since the description mentions an issue with flickering, could it be the same problem as https://github.com/angular/components/issues/21576?

Since the description mentions an issue with flickering, could it be the same problem as #21576?

Yes, though the flickering I'm seeing is not nearly as significant as observed in #21576. Likely due to internal performance optimizations that are present in this PR, but not yet accessible through the public API (e.g. recycle view repeater and enhancements made in #21704).

Since the description mentions an issue with flickering, could it be the same problem as #21576?

Yes, though the flickering I'm seeing is not nearly as significant as observed in #21576. Likely due to internal performance optimizations that are present in this PR, but not yet accessible through the public API (e.g. recycle view repeater and enhancements made in #21704).

@jelbourn The view_engine_build check fails with the following error, but passes locally.
ERROR: /home/circleci/ng/src/dev-app/table/BUILD.bazel:5:10: Compiling Angular templates (ViewEngine - devmode) //src/dev-app/table:table failed
RangeError: Maximum call stack size exceeded

Local command:
 bazel build --build_tag_filters=-docs-package,-release-package --config=view-engine -- src/...

Am I missing something?

@jelbourn Ready for another review.

@MichaelJamesParsons Would you like to rebase and continue iterating on this?

Yes, I'll set aside time to wrap this up.

@andrewseguin would it be ok if I work on this one? I have the same issue here: https://github.com/angular/components/issues/10122#issuecomment-440442656 and I see this hasn't been touched for sometime. Would love to help and have this one go over the finish line


Email Alert

Can the extension email me when the alert is triggered?

@NotSoLateShow
No, this extension just adds DOM element when registered pattern matches the URL of current tab.
There are 6 patterns of notification DOM element.
Below is the 'bottom' pattern.


Add cython entry in 'rosdpe/base.yaml'

Cython + Catkin sample: https://github.com/wkentaro/cython_catkin_example

This looks reasonable could you add
debian: [cython]
fedora: [Cython]

https://packages.debian.org/sid/cython
https://admin.fedoraproject.org/pkgdb/package/rpms/Cython/
and for reference: http://packages.ubuntu.com/xenial/cython

Thanks for the info. I added those entries.

+1


Question: Jest testing & ignoring tests

I'm using, https://github.com/piotrwitek/react-redux-typescript-starter-kit, which in turn is using the plugin-typescript. Thank for making this.
I trying integrate jest, https://github.com/facebook/jest, and I keep running into an issue     SyntaxError: Unexpected token import. My hypothesis is that the plugin is transpiling tests, they have a tsx extension. Is there a mechanism to blacklist certain folders, e.g. test or something like that?

There is no way currently to blacklist files, but it may be possible using packages configuration. However it sounds to me like the problem is that files are not getting transpiled from es6 modules to common's. That is what the error is saying - there are still import statements in the code which node is trying to run.

@cramhead if the source files are .tsx they need to be transpiled even if they don't contain import export because they will likely contain TypeScript specific syntax as well as jsx syntax. Unless you have conflicting compiler options for your own source or for other dependencies, you should be able to accomplish this by configuring the loader to pass those files through plugin-typescript. As @frankwallis noted  you can accomplish this with package configuration.
This is just an example:
SystemJS.config({
  transpiler: "plugin-typescript",
  packages: {
    jest/tests: {
       "*.tsx": {
         loader: "plugin-typescript"
       }
    }
  }
});

react-redux-typescript-starter-kit uses the ts-jest plugin to compile typescript when running jest. This is all configured in jest.config.json - to run the tests use jest --config ./jest.config.json or npm test and the files should get compiled.
see https://github.com/piotrwitek/react-redux-typescript-starter-kit/blob/master/package.json#L30


Updated Python Version

This is just a 1 line change that just changes the version from 3.6.2 to 3.6.12 because Heroku no longer supports 3.6.2.

Thank you!


Fixed bug for asymmetric log-normal uncertainties

The original code breaks when an asymmetric log-normal uncertainty, which is a list of two floats, is introduced in a datacard. In this pull request, I introduced a new logic that checks if an element in a list of uncertainties are actually ints or floats. If the element is not either of those, it should be considered as not a zero.
I don't know if there would be another bugs occurring with my new logic. If there is one please let me know.

Thanks - this looks like a good edit!

Thanks - this looks like a good edit!


handling of NA labels

Minor comment that I just tried this out and NAs in the labels gave me: N labels supplied, but M are required., which took some effort to figure out; would be great if the method could handle this internally :)

Hi @HelenaLC, I'll work on this today and update shortly. Thank you


Maven Compiler - Quarkus Annotations Processor failed with Processor

Describe the bug
Since the current version (2.71.0) of jf-cli, we are unable to compile any project using Quarkus Annotation Processors.

When we run our pipeline with the jf-cli, the maven compiler throws the following stack.
[2024-10-16T12:09:27.458Z] [main] INFO org.apache.maven.plugin.compiler.CompilerMojo - -------------------------------------------------------------
[2024-10-16T12:09:27.458Z] [main] ERROR org.apache.maven.plugin.compiler.CompilerMojo - COMPILATION ERROR :
[2024-10-16T12:09:27.458Z] [main] INFO org.apache.maven.plugin.compiler.CompilerMojo - -------------------------------------------------------------
[2024-10-16T12:09:27.458Z] [main] ERROR org.apache.maven.plugin.compiler.CompilerMojo - error: Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: Provider io.quarkus.annotation.processor.ExtensionAnnotationProcessor could not be instantiated
[2024-10-16T12:09:27.458Z] [main] INFO org.apache.maven.plugin.compiler.CompilerMojo - 1 error
[2024-10-16T12:09:27.459Z] [main] INFO org.apache.maven.plugin.compiler.CompilerMojo - -------------------------------------------------------------
[2024-10-16T12:09:27.461Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - ------------------------------------------------------------------------
[2024-10-16T12:09:27.461Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - Reactor Summary for <quarkus-solution>-parent 18.0.0-SNAPSHOT:
[2024-10-16T12:09:27.461Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger -
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - <quarkus-extension>-parent ............. SUCCESS [  0.667 s]
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - <quarkus-extension> .................... FAILURE [  2.412 s]
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - <quarkus-extension>-deployment ......... SKIPPED
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - ------------------------------------------------------------------------
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - BUILD FAILURE
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - ------------------------------------------------------------------------
[2024-10-16T12:09:27.462Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - Total time:  3.772 s
[2024-10-16T12:09:27.463Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - Finished at: 2024-10-16T08:09:27-04:00
[2024-10-16T12:09:27.463Z] [main] INFO org.apache.maven.cli.event.ExecutionEventLogger - ------------------------------------------------------------------------
[2024-10-16T12:09:27.479Z] [main] ERROR org.apache.maven.cli.MavenCli - Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project <quarkus-extension>: Compilation failure
[2024-10-16T12:09:27.479Z] [main] ERROR org.apache.maven.cli.MavenCli - error: Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: Provider io.quarkus.annotation.processor.ExtensionAnnotationProcessor could not be instantiated
[2024-10-16T12:09:27.479Z] [main] ERROR org.apache.maven.cli.MavenCli - -> [Help 1]
[2024-10-16T12:09:27.479Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project <quarkus-extension>: Compilation failure
[2024-10-16T12:09:27.479Z] error: Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: Provider io.quarkus.annotation.processor.ExtensionAnnotationProcessor could not be instantiated

We have reverted to the previous version (2.70.0) and the problem does not appear.
We suspect that the https://github.com/jfrog/jfrog-cli-core/pull/1277 commit is somewhat related to the error.
The modification of the projectRoot if no .mvn is found could be problematic to projects that does not use it.
Current behavior
I am currently unable to provide a fullstack with the JFROG_CLI_LOG_LEVEL="DEBUG" enabled.
for the current behaviour, see Describ the bug section above.
Reproduction steps
lauch regular maven deploy cycle with the jenkin plugin. The resulting command looks like this
/var/lib/****/tools/io.****.plugins.jfrog.JfrogInstallation/jfrog/jf mvn deploy -B -e -U -Dmaven.repo.local=/var/lib/****/.m2/executor1 -Dexecutor.number=1 -Dmaven.test.skip=true -Dartifactory.username=**** -Dartifactory.password=****

Expected behavior
Maven compiler annotation processor still works and does not fail during the annotation processing for quarkus extension processors.
JFrog CLI version
2.71.0
Operating system type and version
Ubuntu 20.04 LTS
JFrog Artifactory version
No response
JFrog Xray version
No response

@pspino
Thanks for reporting this issue!
@galusben - Could it be related to this?
https://github.com/jfrog/jfrog-cli-core/pull/1273
https://github.com/jfrog/build-info-go/pull/279

Is there any news on this issue? We won't be able to update the jfrog-cli as long as it is a problem.
Thanks!


*.pods.officeapps.live.com is required endpoint for Microsoft Teams

[Enter feedback here]
It seems that Microsoft Teams need to access *.pods.officeapps.live.com for sharing PPT content in meeting, but the endpoint is not listed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66bd8666-3566-a901-b25b-eb6baba6264a
Version Independent ID: e9f6310f-2207-8c81-d31a-3d5a80beb26b
Content: Office 365 URLs and IP address ranges - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@chwakims Thank you for the feedback. I'll work with the author to get this portion updated.

@chwakims Thank you for the feedback. I'll work with the author to get this portion updated.

@JoeDavies-MSFT We see *.online.office.com, *broadcast.officeapps.live.com, *excel.officeapps.live.com, *onenote.officeapps.live.com, *powerpoint.officeapps.live.com, *rtc.officeapps.live.com, *shared.officeapps.live.com, *view.officeapps.live.com, *visio.officeapps.live.com, *word-edit.officeapps.live.com. However,  *.pods.officeapps.live.com is missing from the endpoint list and it is required for Sharing Powerpoint in teams meeting.
Would you be able to work with the team to add this information as this is highly restricted content?
Thanks
Sri

@JoeDavies-MSFT We see *.online.office.com, *broadcast.officeapps.live.com, *excel.officeapps.live.com, *onenote.officeapps.live.com, *powerpoint.officeapps.live.com, *rtc.officeapps.live.com, *shared.officeapps.live.com, *view.officeapps.live.com, *visio.officeapps.live.com, *word-edit.officeapps.live.com. However,  *.pods.officeapps.live.com is missing from the endpoint list and it is required for Sharing Powerpoint in teams meeting.
Would you be able to work with the team to add this information as this is highly restricted content?
Thanks
Sri

@chwakims I have forwarded this request to the product teams that maintain these lists for their consideration in a future update. Thanks so much for letting us know.

@chwakims I have forwarded this request to the product teams that maintain these lists for their consideration in a future update. Thanks so much for letting us know.


Error deleting zimbra distribution list

[2016-09-13 14:48:50,014] ERROR in app: Exception on<EMAIL_ADDRESS>[DELETE]
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python2.7/site-packages/flask_restful/__init__.py", line 477, in wrapper
    resp = resource(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/flask/views.py", line 84, in view
    return self.dispatch_request(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/flask_restful/__init__.py", line 587, in dispatch_request
    resp = meth(*args, **kwargs)
  File "/opt/jenova/resources/base.py", line 65, in decorated
    return f(*args, **kwargs)
  File "/opt/jenova/resources/distribution_list.py", line 262, in delete
    Zr.deleteDistributionList(dlist_zimbra_id = zid)
NameError: global name 'Zr' is not defined

fixed


chore: DNM event leak demo build

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Thanks for the build 👍

TLDR; I did not test for every possible interaction for now and also limited the assertions to grid interaction keys only. It's very likely that additional components will also fail when tested more throughly. Point of this demo was to hightlight that many components, not only nested collections, will cause problems when used inside grids.

View the playtest (auto-run)

closing PR for now since it was just for the build


Extend interpreter to all cbor types

Hey,
I want to integrate your library to a project I'm developing, however I need the types to be returned with the decoded value.
I see that your library has an interpreter for tagged values, thus with this PR I propose to extend that interpreter for all decoded types.
I know that you currently aren't accepting any contribution, however if this PR is accepted it would make the integration a lot easier and please have in mind that I tried to change the least code I could.

It seems pretty straightforward, let's give it a try :)


Investigate tools for voice input

Consider entirely removing the custom voice input in order to allow users with OS-level voice input to be able to use that. Need to ensure pages work correctly with OS-level voice control.
Consider tools we might be able to leverage for better voice input, like AI natural language processing (NLP) libraries or ones specifically dealing with human input of times (TimeAgo?).
Document findings of approaches considered, and why they should be selected or excluded as we need this information in the TDD. Place findings in the documents as a draft, no need for extensive polishing within this task. Some content may be moved out later to the Programmers Guide.
Additionally, if implementation appears to be simple, developing a proof of concept (or locating an existing one built by someone else) would also be great for our next presentation.

from the professor in response to me asking about if it would be acceptable to remove the "custom" screen reader and recommend our applications just ensure that we support the native OS accessibility tools: "The UI/UX is left to the team. The higher-level requirement is that the app should be easy to use be someone who is visually impaired as well as someone who is not. If the team believes that using the OS Screen Reader is more appropriate, please note the reasoning behind your decision, proceed with it, and then show the client the improved interface."

thinking we should continue pursuing removing the current implementation and enhancing support for the native iOS "voice control" and android equivalent.


AutoRelease + Header Checker Upgrades

Description

add requirements.txt for easy installation of dependencies pip -r requirements.txt

strictly depend on python libs so requirements.txt can be sufficient

Replaced the Git API to use gitpython for local edits/commits etc.
Replaced zipping utility with python lib

refactored/improved some of the older scripts ('versioning.py', 'release.py')
Add mechanism for undoing an entire flow
git org should be required input
Add mechanism for baselining on certain commit, and creating detached HEAD tags
Version number updates need to update header check ref for kernel and fr/fr

decoupled kernel and core configs so they live in their respective repos. Need for next bullet

See https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/236

Git auth is more flexible for release.py. Needed to run in git action environment
Created git action that wraps script
Faster
Added fix to header checker

Test Steps
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cbmc run checks


update quickstart to not use dockerhub

The example currently used by the quickstart involves a subscription to the nginx image on DockerHub. There is a high probability of users trying the quickstart being rate-limited.
We should update the quickstart to use an image that isn't hosted on DockerHub.

Duplicate of https://github.com/akuity/kargo/issues/1966.
But will add the concern of not to use dockerhub because of rate limits.


[Feature Request] Can add  table columns filter slot at el-table?

Existing Component
Yes
Component Name
el-table
Description
Sometimes, users want to search some thing at special column, so I think it is possible to implement at el-table? Yes, the requirement that column with enumeration filter has been implemented at current version. But some columns may need date range or number range or input keyword and so on. So slot and function interface may allow user to define their filters. This slot can placed between the table header and table data.

+1 I need this too.
I had to create my own wrapper instead of filter-panel and patch table elements in ugly way =(
Hope this can have native support. Please )

+1

+1 plz this will be usefull

Similar to https://onewaytech.github.io/vue2-datatable/examples/dist/

+1


feat: Release/0.0.4

#24  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Studio: JS error in the Dashboard->Cache diagrams

With the following syntax:
Uncaught (in promise) Error: Type mismatch. Value [object Object] does not match type number in column index 1
at gvjs_yk (www.gstatic.com/charts/51/js/jsapi_compiled_default_module.js:277:264))
at gvjs_M.gvjs.G_ (www.gstatic.com/charts/51/js/jsapi_compiled_default_module.js:294:194))
at gvjs_M.gvjs_.Yn (www.gstatic.com/charts/51/js/jsapi_compiled_default_module.js:295:73))
at BxDolStudioDashboard.showChart (gzip_loader.php:136:29)
at callback (gzip_loader.php:135:287)
at jsapi:156:59_
As the result the block isn't drawn

Fixed here #3827


playing and play fire together, but playing should fire a bit later

playing should fire when the play head starts moving, not when .play() is requested
I have to check for readyState in update(), perhaps both on the audio and video elements, and track the video's "potentially playing" state to only fire the event once.
https://www.w3.org/TR/html5/embedded-content-0.html#dom-media-readystate

[If] the media element's readyState attribute has the value HAVE_FUTURE_DATA or HAVE_ENOUGH_DATA: queue a task to fire a simple event named playing at the element.
From: https://www.w3.org/TR/html5/embedded-content-0.html#playing-the-media-resource


MultipleOf 1/100 validation: it seems that MultipleOf validation always fail for price values

What version of ogen are you using?
$ go list -m github.com/ogen-go/ogen

github.com/ogen-go/ogen v0.81.1

Can this issue be reproduced with the latest version?
Yes.
What did you do?
I've generated code from the spec with "multipleOf": 0.01 rule in the JSON schema.
It gave validation rule, which gives error on valid prices like:

invalid: data (invalid: [0] (invalid: price (invalid: book (float: value 3765.700000 is not multiple of 1/100), total (float: value 3983.010000 is not multiple of 1/100))), [1] (invalid: price (invalid: total (float: value 4579.870000 is not multiple of 1/100))), [2] (invalid: price (invalid: total (float: value 3419.830000 is not multiple of 1/100))), [3] (invalid: price (invalid: total (float: value 2298.890000 is not multiple of 1/100))), ...

I traced it to the line of code<EMAIL_ADDRESS>line 84:
if !val.Quo(val, t.MultipleOf).IsInt() {...}

It seems, this condition never/rare holds for val < 1.
What did you expect to see?
I expect values as 0.01, 0.02, etc would pass the rule, as they are multiples of 0.01.
What did you see instead?
Those values do not pass validation.

I understand that this is due floating-point representation discreteness.
val :=  new(big.Rat).SetFloat64(0.01) gives huge numbers in a/b, and not exactly 1/100, as it has for multipleOf value.
As a workaround I'd use a way to bypass response validation if it were possible.

This is an example of the validation code it generated for the total field:
	if err := func() error {
		if value, ok := s.Total.Get(); ok {
			if err := func() error {
				if err := (validate.Float{
					MinSet:        false,
					Min:           0,
					MaxSet:        false,
					Max:           0,
					MinExclusive:  false,
					MaxExclusive:  false,
					MultipleOfSet: true,
					MultipleOf:    ratMap["1/100"],
				}).Validate(float64(value)); err != nil {
					return errors.Wrap(err, "float")
				}
				return nil
			}(); err != nil {
				return err
			}
		}
		return nil
	}(); err != nil {
		failures = append(failures, validate.FieldError{
			Name:  "total",
			Error: err,
		})
	}

And this is what in the ratMap:
var ratMap = map[string]*big.Rat{
	"1/10": func() *big.Rat {
		r, ok := new(big.Rat).SetString("1/10")
		if !ok {
			panic(fmt.Sprintf("rat %q: can't parse", "1/10"))
		}
		return r
	}(),
	"1/100": func() *big.Rat {
		r, ok := new(big.Rat).SetString("1/100")
		if !ok {
			panic(fmt.Sprintf("rat %q: can't parse", "1/100"))
		}
		return r
	}(),
}


Created RR.c

I have added Round Robin Scheduling Algorithms into  a new directory

Issue number not found


[Feat]: Setup Nextjs

Use the create next CLI App, and generate a boilerplate

Should be typescript
Add metadata to the package-lock file
Add an src folder for better dir management: https://nextjs.org/docs/advanced-features/src-directory

I mean we cannot fork it that's why 😅


Implement Get Terraform Command

This PR provides a new function that simply returns the current terraform command.
This will be handy in two of our use-cases. First, we use different IAM Roles a read-only and a read-write, knowing the terraform commands help us set the correct role. Second, we want to define a global variable with the terraform command to pass to some modules that need to assume cross-account roles (vpc peering accept is an example). The variable helps the module decide the IAM Role that needs to be assumed in our IAM organization.
PS: The docs use to be in the README, where are the docs now? Should I worry about documenting the function?

Thanks for the PR! This makes sense to me, but two requirements before we can merge this:

We need an integration test of some kind. Please take a look at the test folder for ideas, e.g. this one is a good starting point.
This needs to be added to the reference docs.

@yorinasub17 take a look now, please let me know if you need anything else.
PS: I've changed the order of some test arguments which were switched (expected/actual)

Tests passed so will merge and release this. Thanks for your contribution!


Modifying a route configured with Kubernetes using kong REST API get rollbacked

NOTE: GitHub issues are reserved for bug reports only.
For anything else, please join the conversation
in Kong Nation https://discuss.konghq.com/c/kubernetes.

Summary
Using Kubernetes ingress controller I configured an ingress and service
---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: konga
  name: konga-svc
  namespace: kong
spec:
  ports:
    - name: http
      protocol: TCP
      port: 80
      targetPort: 1337
  selector:
    app: konga
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: konga
  namespace: kong
  annotations:
    kubernetes.io/ingress.class: "kong"
spec:
  rules:
  - host: konga.mydomain.net
    http:
      paths:
      - path: /
        backend:
          serviceName: konga-svc
          servicePort: http

Then if I modify this route to only be accessible from HTTPS, modification is performed, but after a while is automatically rolled back
Kong Ingress controller version
kong:1.4
kong-ingress:1.6
Kubernetes version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.7-gke.10", GitCommit:"8cea5f8ae165065f0d35e5de5dfa2f73617f02d1", GitTreeState:"clean", BuildDate:"2019-10-05T00:08:10Z", GoVersion:"go1.12.9b4", Compiler:"gc", Platform:"linux/amd64"}t
Environment

Cloud provider or hardware configuration: Google Cloud
OS (e.g. from /etc/os-release): cOS

What happened
The route modification done using Admin API is roll-back after a while
Expected behvaior
Modification should not be rollback
Steps To Reproduce

Install kong-ingress using official documentation
Create a Service and Ingress in kubernetes
Modify the route using Rest API
Wait some time to see rollback

This is expected.
You should use Kong Ingress resource to override Kong specific route details.
More here: https://github.com/Kong/kubernetes-ingress-controller/blob/effb126a68abfb6485325032c14ea1be8f90c965/docs/guides/using-kongingress-resource.md


feat: Push ArrayGet instructions backwards through IfElse instructions to avoid expensive array merges

Description
Problem
Resolves #5501
Summary
Implements #5501
Additional Context
None.
Documentation
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

I don't get that gate diff on my machine. On master:
+-----------------+----------+----------------------+--------------+
| Package         | Function | Expression Width     | ACIR Opcodes |
+-----------------+----------+----------------------+--------------+
| regression_5252 | main     | Bounded { width: 4 } | 81786        |
+-----------------+----------+----------------------+--------------+

In this PR:
+-----------------+----------+----------------------+--------------+
| Package         | Function | Expression Width     | ACIR Opcodes |
+-----------------+----------+----------------------+--------------+
| regression_5252 | main     | Bounded { width: 4 } | 81786        |
+-----------------+----------+----------------------+--------------+

In this PR:

I would make sure to run with nargo info --force as we cache build artifacts.
I got the following:
+-----------------+----------+----------------------+--------------+
| Package         | Function | Expression Width     | ACIR Opcodes |
+-----------------+----------+----------------------+--------------+
| regression_5252 | main     | Bounded { width: 4 } | 82053        |
+-----------------+----------+----------------------+--------------+

This is just blocked on the regression_5252 regression, right?

@TomAFrench I'd say its also blocked on not showing any other circuit improvements

True.

I've pushed an example program which drops from 305 opcodes to 9 with this PR


Update get_ext function to return Null or Default value

Hello, I have fixed the get_ext function to return Null value (None in Python) and additionally I have added a comment to return a Default value if necessary as well.

Thank you for your work. I've commented in #1 and I'll close this one. Please take a look over there. Again, please feel free to comment and submit new PR if you have any suggestions.


Build improvements [do not merge]

I am working on some Travis improvements, this branch is being used to validate. Once the changes look good I will rename this PR and request review.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Automation for azure-libraries-for-java

Automation for azure-sdk-for-node


Add support for building the muti-module project microprofile-telemetry

After talking with @xstefank ! I have merged all of the suggestions and then merge in to see whether the build can go through. Martin will propose a better PR later.


Magic functions can't use variables created outside function

I wanted to be able to use the lambda context and re-use the HTTP client that the AWS SDK sets up between invocations. Code can be found here: https://gist.github.com/pierskarsenbarg/a7b86d64cb3ccccac7dcbc55deb5caa4 (note the new SSM client being set up on line 33).
I think this might just be a "you can't do this using magic functions" but Pulumi shouldn't just hang.
Expected behavior

Pulumi uses the "magic function" to create a lambda with the callback code in the main handler but the ssm client outside of the handler.
Current behavior

Pulumi hangs when trying to deploy. Verbose output here (I stopped it running ten minutes after the last line in the log)
Steps to reproduce

Clone repo
Run pulumi up

I updated the dependencies and ran your program and looks like this has been resolved. I think this can be closed.
https://github.com/colin-williams/test-pulumi-aws-1433
Previewing update (test-other-magic):
     Type                                  Name                             Plan
 +   pulumi:pulumi:Stack                   magic-function-test-other-magic  create
 +   ├─ aws:ssm:Parameter                  myParam                          create
 +   ├─ aws:s3:Bucket                      my-bucket                        create
 +   │  ├─ aws:s3:BucketEventSubscription  docHandler                       create
 +   │  │  └─ aws:lambda:Permission        docHandler                       create
 +   │  └─ aws:s3:BucketNotification       docHandler                       create
 +   ├─ aws:iam:Role                       docsHandlerRole                  create
 +   ├─ aws:iam:RolePolicyAttachment       lambda-ssm                       create
 +   └─ aws:lambda:Function                function                         create

Resources:
    + 9 to create

Do you want to perform this update?  [Use arrows to move, enter to select, type to filter]
  yes
> no

As an aside:
I've been struggling to develop a more robust lambda via Pulumi / Typescript. I have an open bug https://github.com/pulumi/pulumi-aws/issues/1665 for "magic lambdas". But I think perhaps creating a seperate node application and importing it like: https://www.pulumi.com/blog/easy-serverless-apps-and-infrastructure-real-events-real-code/#approach2-manual-function-resources would be ideal. But I can't find a complete example. If you'd be interested in trying to pair up to produce some lambda example(s) feel free to reach out.

Updating (test-other-magic):
Type                                  Name                             Status

pulumi:pulumi:Stack                   magic-function-test-other-magic  created
├─ aws:s3:Bucket                      my-bucket                        created
│  ├─ aws:s3:BucketEventSubscription  docHandler                       created
│  │  └─ aws:lambda:Permission        docHandler                       created
│  └─ aws:s3:BucketNotification       docHandler                       created
├─ aws:ssm:Parameter                  myParam                          created
├─ aws:iam:Role                       docsHandlerRole                  created
├─ aws:iam:RolePolicyAttachment       lambda-ssm                       created
└─ aws:lambda:Function                function                         created

Outputs:
bucketName: "my-bucket-a7a878f"
Resources:
+ 9 created
Duration: 1m5s


Search API Structure

Description
Over the past week or so, I've doing some planning for the search API, understanding how things will be implemented into this repo. I've created a few commits to reflect this which show skeletons of files and unimplemented classes that will serve as placeholders so we know where to implement things when the time comes.
Please see the bullet points in each of the commit messages that explain more about each change I've made.
@louise-davies I have assigned you as a reviewer. Please could you take a look (while the PR is in draft) at this branch/these commits and let me know your thoughts on the structure/skeleton bits I've added? I'm basically trying to split up DataGateway API and the Search API (see commit message of 568af6d) and then inherit/pick out functionality from the ICAT backend of DataGateway API to prevent duplication when creating the search API. This seems to be the least confusing way to structure this repository, but I might've missed something obvious so would appreciate your thoughts on this.
I do find the following path a bit jarring however:
datagateway-api/datagateway_api/common/__init__.py
Perhaps in an ideal world, we could rename datagateway-api to icat-apis (i.e. rename this repo) but I feel that might do more harm than good. Maybe best just to leave alone 🤔
Testing Instructions
Once we've discussed the structure, I'll go and make any changes, then fix the imports and turn this into a PR marked 'ready to review' and something that can be merged.

[ ] Review code
[ ] Check GitHub Actions build
[ ] If icatdb Generator Script Consistency Test CI job fails, is this because of a
deliberate change made to the script to change generated data (which isn't
actually a problem) or is there an underlying issue with the changes made?
[ ] Review changes to test coverage

I'm going to have a read around the how Python projects should be structured because I'm no expert either. But I think I agree with you, I find it confusing too. When there was much less code in common/ (around the time I started work on the API) it made more sense, but there's now more code in common/ than in src/ which doesn't seem to make sense. Think it's one of those "it's always been like that" situations so I overlooked it.

@louise-davies I've just pushed a few more commits on this so I ready for some further thoughts. I've essentially put common/ into src/ and removed some of the datagateway_api/ and search_api/` because there was quite a few before.
Inside of src/, the following directories exist:

common/ - Files used between both APIs, such as config and the date handler
datagateway_api/ - Files specific to DataGateway API, all the backend and specific filter implementations
resources/ - Endpoint definition for both APIs
search_api/ - Files specific to the search API
swagger/ - Files for the swagger docs
main.py, config.json, wsgi.py also live directly inside src/, there's no change from what currently happens on master


Example content for testAssemblyVer2 needs to express newlines

There needs to be newlines to separate the match expressions.  This could be done with double quote and escape characters, e.g:
"**\\*test*.dll\n!**\\*TestAdapter.dll\n!**\\obj\\**"
or by making use of multiline operators in YAML, e.g.:
#testAssemblyVer2: |
#   **\*test*.dll
#   !**\*TestAdapter.dll
#   !**\obj\**

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 16bd8dd1-7650-8c18-2553-38a8bc54e892
Version Independent ID: f9fa517a-7adc-e327-d12e-256295a1ed52
Content: Visual Studio Test
Content Source: docs/pipelines/tasks/test/vstest.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: dastahel

bumping this to give it a little more lifetime, as the existing example does not work - users who copy it will have to debug the syntax issues.

This just ate my lunch for a couple of hours. 😠 Getting the docs correct and using double quotes in the example to ensure \n gets properly interpreted is pretty important to getting people on the path to success, especially when most of the editing is done in YAML instead of through a nice visual designer that handles the serialization.
It wouldn't hurt to get some YAML multiline examples on the pattern matching page, too since none of the ones there would actually work if you pasted them into a pipeline YAML doc.
I'm still fighting through trying to get multiple exclusions (!pattern) working, starting to think it's related to #2551. Anyway, having a working example would be great.

Definitely need to fix this.  Even using the new online YAML graphical editing puts in invalid values for testAssemblyVer2 and ONLY by seeing this thread was I able to use the pipe multi line and fix it.

@andyjlewis Can we push the changes as raised by @jimmylewis or @dlumpp above?

Just ran into the same situation and asked on SO and got the same answer as @jimmylewis already posted in his initial post of this issue. And I can confirm that this approach works. Also I posted the issue on [Developer Community].(https://developercommunity.visualstudio.com/content/problem/570805/working-with-multiple-pattern-matchings-in-vstest.html).

Following up with the product team.

@jimmylewis We just checked in a doc fix for this and it should be live soon. Thank you for letting us know.

Hit the same problem and took me a couple of hours before seeing this thread.
In my situation, I have to write a script to dedup the list of test files since the test projects could be referencing each other and the same test assemblies appear in multiple output directories. (We know it's bad but we've not got around to sort them out yet).
Then I had this issue when I got the list of specific files and echo that as a variable to be used for vstest task's testAssemblyVer2. The example needs improving.


fix: archway bump v6.0.3

Fixed @tombeynon

Pre-release image: ghcr.io/akash-network/cosmos-omnibus:v0.4.16-rc1-archway-v7.0.0


Docs for Embeddings?

Is there a way to embed text with OpenAI for Manifest? I couldn't find docs.

Not yet. There's been some discussion around adding embedding functions and there's preliminary rough support in the HF models. The caching layer is ready so it's just a matter of adding the request object, function calls, and making sure pipes work.

Embeddings added to main. I'm working on adding embeddings to local models (e.g. SentenceTransformer style) this week before pushing to pip.
See first half of notebook https://github.com/HazyResearch/manifest/blob/main/examples/manifest_embedding.ipynb.
Caching is also supported.


@clerk/clerk-react should have react-dom as a peer dep

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs

[X] I have searched for existing issues: https://github.com/clerk/javascript/issues

[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)

[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction / Replay Link
n/a
Publishable key
n/a
Description

Steps to reproduce:
Building an app that depends on @clerk/clerk-react with vite results in the following error:
[vite]: Rollup failed to resolve import "react-dom" from "<redacted>/web/node_modules/.pnpm/@clerk+clerk-react@4.28.0_react<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
Expected behavior:
vite build should work.
Actual behavior:
see the above
Environment
N/A

Problem
useCustomElementPortal.tsx has import { createPortal } from 'react-dom'; but react-dom is not listed as a peer dep or a dep in @clerk/clerk-react's package.json.

Indeed if I force it as a peer dep using pnpm's packageExtension mechanism vite build now works:
  "pnpm": {
    "packageExtensions": {
      "@clerk/clerk-react": {
        "peerDependencies": {
          "react-dom": "*"
        }
      }
    }
  }

Hey, thanks for the issue!
That is indeed correct, it should set react-dom as a peerDep.
To anyone who wants to pick this up, go to here:
https://github.com/clerk/javascript/blob/86ac27a9c3b6d3197d2535c9d8c3e7f9e3abd6e7/packages/react/package.json#L74-L76
And add:
"react-dom": ">=16"

This was fixed in https://github.com/clerk/javascript/pull/2164 and will be released with a new major. You can install npm install @clerk/clerk-react@alpha-v5 to try out the pre-release.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


How to access Muxer from Transformer

How to access Muxer from Transformer
We are trying to use some audio processing for our video, for which we need to access the muxer of Transformer
The audio processing code is different from the one used by Transformer,java class , we just want to use the muxer in order to process the video using the Transformer and the audio which is processed from our code and create a new video using both the features,
All we want is to access the muxer used by Transformer class, how can we do that

@pawaom Can you please explain your requirements a bit more in details?
This is what I have understood so far

Process audio in your code.
Process video via Transformer.
Mux both audio and video using muxer.

The muxer used by Transformer can not be accessed directly but you can pass your custom muxer
https://developer.android.com/reference/androidx/media3/transformer/Transformer.Builder#setMuxerFactory(androidx.media3.transformer.Muxer.Factory)
If your requirement is to pass a custom implementation for processing audio then please let us know we can suggest accordingly.

What we want to achieve is overlay audio over existing video which contains audio as well.
For this in one of our previous issue raised here we were told it is currently not supported by transformer
so for this we are using this library
https://github.com/ZeroOneZeroR/android_audio_mixer#merging-audio-with-video-and-using-external-mediamuxer
however  we also came across this in a different issue raised here
https://github.com/androidx/media/issues/557#issuecomment-1661772844
we implemented it using the main branch using this code and the files that were provided by the user who had asked the question here,
code
https://github.com/androidx/media/issues/557#issuecomment-1671081176
files
https://github.com/androidx/media/issues/557#issuecomment-1670276144
however it created blank video with duration of audio with only audio from the music file playing in the background
the question that we want to know is

can we overlay audio over video which already contains audio using transformer(is it supported,) not remove the audio of the video and replace it

other modifications, like adding audio at specific duration like video is 45 seconds long and overlay audio over the video from 15th second to 40 th second , looping audio  etc is supported

@pawaom: here are some answers regarding your questions in the previous comment:

can we overlay audio over video which already contains audio using transformer(is it supported,) not remove the audio of the video and replace it:
Yes you can. You can create 2 sequences: the first one with video (containing an audio track) and the second one with background audio, add those sequences into a composition.
other modifications: It is currently not supported to add audio at a particular time as mentioned in issue 598. It is only supported to add audio at the beginning of a composition. It is also possible to add a 10 second audio and set  isLooping to true. In this case, the background audio track will start at the beginning of the video and keep looping over 10 second interval for a duration of a video.

Please share your sample code if possible and output file, if you still experience issues.
Please keep in mind that this codebase is rapidly developing and some of the previous answers might not be applicable anymore.

other modifications: It is currently not supported to add audio at a particular time as mentioned in issue [598]

will this be considered as an enhancement so we can track the development of this feature
Also since this is not supported is there a way to create silent audio using transformer like this Library based on media codec and media muxer
https://github.com/natario1/Transcoder
https://github.com/natario1/Transcoder/issues/51

The issue number 598 has now an enhancement label, so you should be able to track the progress there.
It is not supported to have a silent audio so you can use it as a gap item.


Add structure for request data

This PR adds a defstruct for the location and content request data that is needed in ycmd--request. This encapsulates and makes the creation of the request data more descriptive

The change looks good. Any idea why the travis test is failing?

Some of the tests are flaky and fail sometimes. Restarted the failing one, hopefully it runs through. I have the travis tests also running for my fork and there it succeeded.

Test pass now.
I'll have a look into the flaky tests sometimes soon


using PyPlot from os console

Hello!
First of all thank you so much for developing this exciting stuff! I am very new to julia and I am trying to plot some basic stuff. Thus I followed the available examples and its was quite straight forward use PyPlot with all the explanations in the console for the next step. But I got stuck when trying to run a .jl script from my os console (not from within the julia prompt, there it works fine):

$ julia plot.jl
INFO: Loading help data...

and nothing happens.
this is the plot.jl:
using PyPlot

x = collect(-pi:0.2:pi);
plot(x, sin(x), ".")

What am I doing wrong or is this intended behaviour?

It's intended.  When you're at the REPL (Julia prompt), it implicitly calls display(ans) where ans is the result of the command.  When running a script it doesn't have this behavior, so you need to explicitly call display on your plot.

ok, bbut when I try to call the display function explicitly:
using PyPlot
x = collect(-pi:0.2:pi);
display(plot(x, sin(x), "."))

I get the following:
$ julia plot.jl
INFO: Loading help data...
1-element Array{Any,1}:
 PyObject <matplotlib.lines.Line2D object at 0x7fbc2853bcd0>

Or is there no way doing it like I want?

You're right... instead of display, after the plot command you can do:
PyPlot.plt[:show]()

There may be a shortcut for this, but I don't remember.  I tend to deal with PyPlot from a lower level for my package Plots.

Thanks a lot Thomas! That's working fine!
And I definitely going to have a look Plots.jl, too.
Offtopic:
Can I also use this in the Jupyter QtConsole? Do you know a good tutorial/example?

I can't comment on QtConsole as I've never used it, but I use Jupyter/IJulia a lot and it works really well.  PyPlot has some trickiness occasionally if you want to have both inline graphics and an interactive GUI... if you run into trouble let me know (though I'll be more help if you're accessing it through Plots)

If you are running Julia interactively, e.g. in the REPL, then it runs Matplotlib in interactive mode, where plots appear immediately.   If you are running Julia non-interactively, from a script, then it runs Matplotlib in non-interactive mode, where you have to run show().
It is enough to run show() ... you don't need PyPlot.plt[:show]()

I've added some documentation to clarify this situation.


Fix date time formatting

There are currently no differences between formatting a timestamp in UTC and local time zones.
There is probably a bug in time_utils module.

Issue is now visible in travis build for commit dff5f13daaa0b3f5093bed97bbb4af2730488de8.

It seems related to rust-lang-deprecated/time#116.

A possible cause is the run of tests in parallel. When time zone is changed, it is changed globally, so the output depends on execution order of tests. See Disable parallel tests.


Use the new shared memory manager for initialize and finalize

In this PR, the new shared memory interface is implemented. Currently, only initialize and finalize functions can work properly. The lifecycle management of the objects is handled such that if one makes a mistake and forgets to handle the lifecycle properly, they will see a double free instead of shared memory leak which is silent and can go unnoticed.
All the other logic (request execution, BLS, etc.) has been removed temporarily from the code and will be added back in separate PRs.

@Tabrizian Out of interest, can you explain what would be different with this?
Will it impact us as users in some way (performance improvement, or something else) or is that only affecting things internally?

@naor2013 This mainly improves the lifecycle management of objects in shared memory and addresses limitation 1 for BLS:
https://github.com/triton-inference-server/python_backend#limitations


add a comment on reshape in the docs

compose(A,B) reshapes A to shape B.

with_shape is a shortcut for that.


Provide a way to abort/suspend "cargo check"

In the rustc repository, "cargo check" can take a long time. During that time, any other x.py command is blocked because of the workspace lock. Sometimes, I am doing work where I do not want a full "cargo check" (e.g. when I am just editing a doc comment in libstd, or so). In that case, after doing the edit (which can take less than a minute), I now have to wait several minutes for "cargo check" to complete before I can run doctests (which doesn't need a full "check" of the entire compiler). That is enough friction that I end up using a different editor for this job just to avoid the automatic "cargo check".
Is there a way to temporarily (until I close this session, or so) disable "cargo check" in RA? I usually want "check" for the rustc workspace, so a workspace setting doesn't entirely fit here. Just sometimes I want to disable this until I close this workspace again.

This is definitely possible once we move to fully-lsp-compatible progress reports for cargo check runs.
Related PRs: #4407
I might tackle this just once I have time, but everyone should feel free to take over

That doesn't help with x.py unfortunately which performs many operations and often releases and re-acquires the lock.
I sometimes even get strange errors about not finding particular crates in the sysroot or so when my x.py and RA's check overlap -- re-running the x.py command fixes those.

For working on libstd I actually switched back to using another editor as vscode keeps rechecking all of rustc after each save, which is rather excessive.

You can always disable the flycheck/check-on-save functionality and manually invoke x.py as a vscode runnable.

Ah good point, I didn't realize there is a way to disable it.
I never used "vscode runnables", will have to look into this. Thanks!

{
    "rust-analyzer.checkOnSave.enable": false,
}

@RalfJung Ah sorry, that's because they're called "Tasks" and not runnables.

Something like:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "x.py",
            "type": "shell",
            "command": "./x.py",
            "problemMatcher": ["$rustc"]
        }
    ]
}

In tasks.json should be a starting point, I'm not able to check it right now though.

I have configured my tasks.json as follows:
		{
			"type": "shell",
			"command": "./x.py check --json-output",
			"problemMatcher": [
				"$rustc"
			],
			"label": "rustc full check"
		},

However, this behaves very differently from the normal "check" task. it opens a terminal to show the output with all the glorious JSON, and more important it does not actually interpret the JSON to highlight the errors in the code -- making it basically useless.
Is there a way to tell it to parse the JSON the way it normally would?

I recently got rust-analyzer working in Sublime Text editor and now encountered the same issue.
rust-analyzer.checkOnSave.enable=false isn't a solution for me because there is no way to execute a check operation operation otherwise (that I know of) and I don't think the tasks.json suggestion is applicable to non-vscode editors.
I'm not really familiar with the technical details of LSP, but if its possible I'd suggest a different approach where cargo check isn't executed on every save but rather only with an explicit command from the client. (I've been told workspace/executeCommand might be suitable for that?)
That way a key mapping could be bound to that command on the client and specifically executed by the user if desired/required.

I'm not sure how good LSP is supported in Sublime Text 3, but there's a custom command in rust-analyzer, experimental/runnables
that allows running a "clever" cargo check:

it's supported in VSCode and there might be a way to support it in Sublime?

Their docs list an LSP implementation status, but I'm not seeing anything experimental there so I'm assuming that its not supported.
However there is also more info regarding executing server commands.
Other than these are the possible server-specific settings that can be configured in the plugin:
// Sent to server once using workspace/didChangeConfiguration notification
"settings": { },

// Sent once to server in initialize request
"initializationOptions": { },

// Disable providers if so desired
"disabled_capabilities": { },

// Extra variables to override/add to language server's environment.
"env": { },

PS: I'm actually using ST4, as far as I know the last LSP plugin version for ST3 is relatively old and not being updated anymore (unfortunately ST4 currently also requires a license).

that allows running a "clever" cargo check:

Sadly that's not enough even inside vscode when one has set rust-analyzer.checkOnSave.overrideCommand. So this does not resolve my original issue I'm afraid. What would be best is if the exact thing that RA does "on save" automatically by default, could instead be triggered on-demand.

It looks like even hitting Ctrl-S will not abort the existing run to start a new one? At least, I am experiencing extremely high latency (>30s) between hitting Ctrl-S and RA starting a new check run (removing the old diagnostics and starting to add new one) when there is already a check run ongoing (I am in the middle of a big refactoring, so there is hundreds of diagnostics).


ImportError: cannot import name 'json' from 'itsdangerous'

Environment:

Python version: 3.8.10, but 3.7 is affected too
ItsDangerous version: 2.1.0

After upgrade the lib to 2.1.0 version, the lib show the error: ImportError: cannot import name 'json' from 'itsdangerous'
I'm using python 3.8.10, but in 3.7 version doesn't work too.

Should the line from ._json import json have been remove from file src/itsdangerous/__init__.py on commit 506ca21d8cc1d16313270c37b6990c9e7762f68e ? It is breaking some libs which I use as well

Duplicate of #289
You are using an unsupported version of Flask, please update to the latest version if possible. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.


Getting consent for a live.com account fails with invalid_request: The provided request must include a 'client_id' input parameter.

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.23.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.2.0
Description
I load msal in an Office.js add-in. The first time I run the add-in the user needs to give consent. When I use a AzureAD account, the consent screen shows up inside the add-in just fine. But when I use a live.com address, the consent screen doesn't show up and instead a new browser window opens to https://login.live.com/oauth20_authorize.srf?res=error&ec=&uaid=xxx without a consent prompt.
When I instead of loginredirect open a dialog windows like Office.context.ui.displayDialogAsync(window.location.origin + '/#/login', ... I DO get a consent prompt inside that dialog. When I then give consent for the live.com address, and change the code back to loginRedirect, everything works fine. When I remove the consent on https://account.live.com/consent/Manage, the error is back and I can't log in.
Weird thing is that for AzureAD accounts I get the consent prompt just fine without the Dialog window. Only live.com addresses seem to have this problem.
In the add-in Manifest I tried adding all AppDomains I could find in my Wireshark capture but when the Addin needs consent, it opens an external browser window with said error.
snippit from manifest:
  <AppDomains>     <AppDomain>https://localhost:4200</AppDomain>     <AppDomain>https://graph.microsoft.com</AppDomain>     <AppDomain>https://login.microsoftonline.com</AppDomain>     <AppDomain>https://login.live.com</AppDomain>     <AppDomain>https://account.live.com</AppDomain>     <AppDomain>https://aadcdn.msauth.net</AppDomain>     <AppDomain>https://aadcdn.msftauth.net</AppDomain>     <AppDomain>https://www.microsoft.com</AppDomain>     <AppDomain>https://privacy.microsoft.com</AppDomain>   </AppDomains>
Error Message
invalid_request: The provided request must include a 'client_id' input parameter.
Msal Logs
Because this happens after MSAL redirects, there are now msal logs specific to the error. the logs are similar for AzureAD accounts, with or without consent and for live accounts, also with or without consent. The only thing showing in the console.log is
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - loginRedirect called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - acquireTokenRedirect called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Verbose - preflightBrowserEnvironmentCheck started
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Verbose - preflightInteractiveRequest called, validating app environment
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.getTemporaryCache: No cache item found in local storage
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Verbose - getAllAccounts called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Info - Emitting event: msal:loginStart
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Verbose - Emitting event to callback 9adf98ca-1ca5-4aac-a328-e32535a3351c: msal:loginStart
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Verbose - BroadcastService - msal:loginStart results in setting inProgress from none to login
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - initializeAuthorizationRequest called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - getRedirectUri called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - Initializing BaseAuthRequest
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - Authentication Scheme wasn't explicitly set in request, defaulting to "Bearer" request
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.getTemporaryCache: No cache item found in local storage
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.getTemporaryCache: No cache item found in local storage
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.updateCacheEntries called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - initializeServerTelemetryManager called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - initializeAuthorizationRequest called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - getClientConfiguration called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - getDiscoveredAuthority called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Trace - PerformanceClient: Performance measurement started for standardInteractionClientGetDiscoveredAuthority
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Trace - PerformanceClient: Performance measurement for standardInteractionClientGetDiscoveredAuthority started
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - Creating discovered authority with configured authority
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.getAuthorityMetadata: cache hit
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.setAuthorityMetadata called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Trace - PerformanceClient: Performance measurement ended for standardInteractionClientGetDiscoveredAuthority: 3.100000023841858 ms
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Trace - PerformanceClient: Performance measurement for standardInteractionClientGetDiscoveredAuthority added/updated
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - Auth code client created
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - Redirect start page: https://localhost:4200/?_host_Info=Word$Win32$16.01$en-US$$$$0#/
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - RedirectHandler.initiateAuthRequest called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - RedirectHandler.initiateAuthRequest: redirectStartPage set, caching start page
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT]<EMAIL_ADDRESS>: Trace - BrowserCacheManager.cacheCodeRequest called
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Info - RedirectHandler.initiateAuthRequest: Navigate to: https://login.microsoftonline.com/common/oauth2/v2.0/authorize?client_id=04634b9b-7e1a-45d2-be82-f8de64c13fa2&scope=User.Read openid profile offline_access&redirect_uri=https%3A%2F%2Flocalhost%3A4200&client-request-id=d8e582dd-7925-4a4b-818a-8684b05f12cd&response_mode=fragment&response_type=code&x-client-SKU=msal.js.browser&x-client-VER=2.23.0&client_info=1&code_challenge=nJdNzZQoS_tjpH14SEKkKdtmpWbLUk1YvRL3GxPrP8A&code_challenge_method=S256&nonce=fe7416b0-26a1-4f4c-88b8-4315d082ea34&state=eyJpZCI6ImY5YjA3ZDJiLTkxMGMtNGUzZC05Nzk2LWYwMmU1ZTFiMDY2YiIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D
VM37:470 [Sat, 30 Apr 2022 13:18:46 GMT] : [d8e582dd-7925-4a4b-818a-8684b05f12cd]<EMAIL_ADDRESS>: Verbose - RedirectHandler.initiateAuthRequest: Navigating window to navigate url
Navigated to https://login.microsoftonline.com/common/oauth2/v2.0/authorize?client_id=04634b9b-7e1a-45d2-be82-f8de64c13fa2&scope=User.Read+openid+profile+offline_access&redirect_uri=https%3A%2F%2Flocalhost%3A4200&client-request-id=d8e582dd-7925-4a4b-818a-8684b05f12cd&response_mode=fragment&response_type=code&x-client-SKU=msal.js.browser&x-client-VER=2.23.0&client_info=1&code_challenge=nJdNzZQoS_tjpH14SEKkKdtmpWbLUk1YvRL3GxPrP8A&code_challenge_method=S256&nonce=fe7416b0-26a1-4f4c-88b8-4315d082ea34&state=eyJpZCI6ImY5YjA3ZDJiLTkxMGMtNGUzZC05Nzk2LWYwMmU1ZTFiMDY2YiIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D&sso_nonce=AwABAAEAAAACAOz_BAD0_1nlnyCOy0FXkcSwtOJ0ptS5DYyVdx7DiGqmXs7-wv_lko6mkJqUiKdKOWop9VivpDVC9bB0g_ruvSNsj7eWKIogAA&mscrid=d8e582dd-7925-4a4b-818a-8684b05f12cd
Navigated to https://login.live.com/oauth20_authorize.srf?client_id=04634b9b-7e1a-45d2-be82-f8de64c13fa2&scope=User.Read+openid+profile+offline_access&redirect_uri=https%3A%2F%2Flocalhost%3A4200&response_type=code&state=eyJpZCI6ImY5YjA3ZDJiLTkxMGMtNGUzZC05Nzk2LWYwMmU1ZTFiMDY2YiIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D&response_mode=fragment&nonce=fe7416b0-26a1-4f4c-88b8-4315d082ea34&code_challenge=6AtxuGcgXSsAXnawP5UogYtngQ0wK9W_H4E7eA7JWDQ&code_challenge_method=S256&x-client-SKU=msal.js.browser&x-client-Ver=2.23.0&uaid=d8e582dd79254a4b818a8684b05f12cd&msproxy=1&issuer=mso&tenant=common&ui_locales=en-US&client_info=1&epct=AQABAAAAAAD--DLA3VO7QrddgJg7WevrUV4bl35LR6al9KG2Rz3_haC1sKvnZOM0yXmRKR4NAGdoC6-usYq5nqbi913oNCmwrk7rx-I7g2qw5-kZEo6OmkBEenQZ8WbZ2x3olIvbi4Hn4vdQlIXBtq96CZzZzSAtiKTqR7Cu5vzpgAC5WyK0uxsd9zFi2flMNxNeylzqv1kz1YrmcQWaNFCB3ngKMofDxc4C-xXrt-ttiXFNpda1uiAA&jshs=0&username=xxxx%40hotmail.com&login_hint=xxxx%40hotmail.com
MSAL Configuration
export const msalConfig: Configuration = {
     auth: {
         clientId: '04634b9b-7e1a-45d2-be82-f8de64c13fa2', // This is the ONLY mandatory field that you need to supply.
         authority: 'https://login.microsoftonline.com/common', // Defaults to "https://login.microsoftonline.com/common"
         redirectUri: window.location.origin, // Points to window.location.origin. You must register this URI on Azure portal/App Registration.
     },
     cache: {
         cacheLocation: BrowserCacheLocation.LocalStorage, // Configures cache location. "sessionStorage" is more secure, but "localStorage" gives you SSO between tabs.
         storeAuthStateInCookie: isIE, // Set this to "true" if you are having issues on IE11 or Edge
     },
     system: {
         loggerOptions: {
             loggerCallback(logLevel: LogLevel, message: string) {
                 console.log(message);
             },
             logLevel: LogLevel.Trace,
             piiLoggingEnabled: true
         }
     }
 }

Relevant Code Snippets
if (this.isIframe || this.msalGuardConfig.interactionType === InteractionType.Popup) {
      if (this.msalGuardConfig.authRequest) {
        this.authService.loginPopup({ ...this.msalGuardConfig.authRequest } as PopupRequest)
          .subscribe((response: AuthenticationResult) => {
            this.authService.instance.setActiveAccount(response.account);
          });
      } else {
        this.authService.loginPopup()
          .subscribe((response: AuthenticationResult) => {
            this.authService.instance.setActiveAccount(response.account);
          });
      }
    } else {
      // Office.context.ui.displayDialogAsync(window.location.origin + '/#/login',
      //   { height: 50, width: 24 }, (result: any) => {
      //     const dialog = result.value;
      //     dialog.addEventHandler(Office.EventType.DialogMessageReceived, (arg: { message: string, type: string }) => {
      //       const messageFromDialog = JSON.parse(arg.message);
      //       if (messageFromDialog.status === 'success') {
      //         console.log(messageFromDialog.result);
      //       } else {
      //         console.log("Message error\n" + JSON.stringify(messageFromDialog));
      //       }
      //       dialog.close();
      //     });
      //   }
      // );
      if (this.msalGuardConfig.authRequest) {
        this.authService.loginRedirect({ ...this.msalGuardConfig.authRequest } as RedirectRequest);
      } else {
        this.authService.loginRedirect();
      }

Reproduction Steps
See problem description
Expected Behavior
Consent popup for live.com accounts should open in office.js add-in just like it does for azureAD accounts
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Edge
Regression
No response
Source
External (Customer)

Also, if I really do need displayDialogAsync (although I don't understand why AzureAD accounts don't need it and live.com accounts do), how do I configure MsalGuard to open a dialog too instead of redirecting or even worse, trying to open a popup in the add-in...

@brugh This looks like the same issue you raised previously in #3179. To build an office add-on you need to use the dialog API when invoking interaction, every time. There's 2 ways you can do this:

Write your own custom guard that opens the dialog box to a page that calls login and returns to a page that handles the response and sends the response back up to the guard. This approach is roughly demonstrated in the office add-on sample
Use the onRedirectNavigate parameter on your redirect request to open the dialog box, have the redirectUri page send the url hash back up to the guard and have the guard call handleRedirectPromise with that hash.

True, I struggled with this before. Good that you remember the other case.
I noticed the new msal versions and gave it another go. I tried some reworks of my other workaround of having two separate applications which created a situation that our dev env differs from our prod significantly which makes for hard testing.
the new version does solve a few of our issues, except this one. Since we can now get the entire authenication including consent questions inside the Add-in without any dialogs for AzureAD accounts I was hoping we can figure out what makes live accounts require the dialog still. As said, once consent is give, live accounts work fine inside the add-in too.
that said, I reworked our auth.service so it pops the dialog when any regular login requests are given so that works fine. I no longer need 2 apps to handle login. But I run into trouble when a protected resource get called before a user is logged in and the msal interceptor takes over and gives an Interaction Required error. We can only set interactionType: InteractionType.Redirect (or Popup) which redirects inside the add-in. How can we hook into that and prevent the default redirect? When I subscribe to this.msalBroadcastService.msalSubject$ and check for InteractionType.Redirect I can open a dialog but the redirect inside the add-in also still happens. if I can prevent that redirect, I think I can get a working flow.

Since we can now get the entire authenication including consent questions inside the Add-in without any dialogs for AzureAD accounts

Whether it works or not, this is not the recommended approach for developing office add-ins. Dialogs are the recommended approach.

But I run into trouble when a protected resource get called before a user is logged in and the msal interceptor takes over and gives an Interaction Required error.

You should wait until the inProgress observable indicates there is not interaction in progress before making an http request that might invoke the interceptor. See here for an example.

Very well, I concede ;) I still don't understand exactly why we need the dialogs but the flow in this version works fine now.
I created a boilerplate repo because I can't seem to find a sample project that works for Office desktop as well as Office Online and that has the correct MSAL flow for Office.js in Angular and uses Fluent-UI Web-components and Redux state. Perhaps somebody looking at the same issues finds this useful: https://github.com/brugh/Angular-office-msal
because this works now in pre and post consent and in desktop apps and online, I guess you can close this ticket now :) thanks for you patience 👍

Great thank you! I've created an item in our backlog to write an official sample for Angular + Office Add-in, we will certainly take a look at what you've got there when we're ready to pick that up. Closing for now but let us know if you have any other questions


Outstanding nips to be implemented

NIP 12, 16, 20 and 33 were already there, which have now been made explicit. Extra issues will be opened for 2,9,15,22,40


fix: make autofill work for controlled input in Firefox

SPT-2611
Description
There is an issue in React that breaks Firefox browser behavior for autofill/autocomplete in controlled inputs.
How to test

FIXME: ...

Development checks

[ ] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
n/a Annotate all props in component with documentation
n/a Create examples for component
n/a Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
n/a Covered with tests

Breaking change

[ ] codemod is created
[ ] test alpha package of Picasso in StaffPortal

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

FF

Chrome on/on

@toptal-bot run all

I have it checked on FF with on/off options on the last available Picasso version.
Now it looks good!

@toptal-bot run all

Hello, @denieler! Regarding https://github.com/toptal/picasso/pull/2698#pullrequestreview-958879982 – I think we do need this fix, as it was reported by actual users (this affects the Screening Ops team work, for example (https://toptal-core.slack.com/archives/C01ANC5RH8B/p1650458144649619)

@toptal-bot run all


'HPOpenWeather' initializer is inaccessible due to 'internal' protection level

I get the error in the title when initialising the api key:
var api = HPOpenWeather(apiKey: OWM_API_KEY)

Should be fixed in 3.1.1

It seems the version available with pod is still the 3.0.0

On 5 May 2020, at 17:39, Henrik Panhans<EMAIL_ADDRESS>wrote:
Closed #4 https://github.com/henrik-dmg/HPOpenWeather/issues/4.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/henrik-dmg/HPOpenWeather/issues/4#event-3305077690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKAVF5TJ4P7L5ULSMMREDN3RQA6NNANCNFSM4MZWZDIQ.

Just pushed a new version :) let me know if there are any issues (NOTE: I still need to update the documentation)

Still downloading version 3.0.0 with pod "HPOpenWeather" if I try pod "HPOpenWeather", "3.1.1"it throws an error

I kinda fix it by replicating your changes in the last commit: https://github.com/henrik-dmg/HPOpenWeather/commit/a953d448165bb4714511fd91a20657aa9357dbb6
Fortunately they aren't a lot :D

Have you run pod repo update? The latest version is shown on here


MPU 6050_serial_to_imu node stops sending data or hangs

Hi, so i have set up everything as per the article attached. after the connections i run serial node for mpu6050 and to check correctly I,
rostopic echo /imu/data   for sometime every thing works fine, for like 10 seconds, then it freezes, no new data, even in demo.launch the simulation freezes. i am using a fairly powerful pc, i7 10th etc and everything else works. can you tell me anything about it.
no error warnings are shown, nothing. it just freezes. only this node.

SOLUTION: it is a bug of i2c library which is very well documented. see [https://www.fpaynter.com/2020/07/i2c-hangup-bug-cured-miracle-of-miracles-film-at-11/]
it is resolved for me so i am closing this issue