Create a command line flag to specify the maximum depth of analysis

We sometimes need to get the 1st-level (direct) dependencies of a project.
I think that setting a --max-depth N could be helpful, N being 1 in the case of direct dependencies. It also could help to run ORT faster when resolving issues "iteratively" (eg by depth level): first level 1, then level 2, etc.
If maintainers don't think having the ability to set an arbitrary depth is useful, then just a --direct-deps-only flag could also be useful.

(FWIW we're currently working on this, so feel free to assign this to @qequ)

@dgutson
Would you mind sharing the use case, e.g. for what purpose is the analysis result needed?
I'm asking this, since in case it is used in order to evaluate license compliance, then the definition of the depth may be a bit inaccurate. E.g. if you have a software project and you factor out a component X of that project into a separate library, then the direct of X, which have been first level before, become 2nd level dependencies of the project. So, the decision whether a package is reported or not would become dependent on the internal sub module structure of the project somewhat.

Hi @fviernau, sure.
I see what you mean.
We have the "third party libraries" compliance audits, where we need to fill a number of data about the libraries we use. This is what is under our direct control (choosing what libs to use), rather than modifying those external libs, so this is our action space. We could do this by post-processing the report, but this requires a script and wasting processing power and time by ORT running on libraries we don't need to be analyzed anyways (just the "first level"). Another CLI option could tell ORT where/which are the "internal" dependencies, so depth count could start outside of that set.

Hi @dgutson
here's a list of approaches to consider, I tried to make it rather complete even if I don't really like some of these:

Add logic to each package manager integration to handle the maxDepth. I have doubts about this due to added complexity /   maintenance costs, in particular the cost / benefit ratio as this would IIUC not lead to a significant speed-up for several (most?)  the package managers.
Keep the package managers integrations as is, but make the analyzer command filter out the packages, after each respective
package manager integration determined the full dependency tree. This is cheap to maintain and reduces the size of the analyzer result, so the succeeding stages (scanner, evaluator, reporter) will speed-up and the report will contain just what you need.
Same as 2. but implement a separate command to filter a given analyzer result by depth, or maybe even highly customizable: pass a .kts script which decides whether a package needs to be filtered out.
Add a depth parameter to the scan command: This only saves effort for scanning, the full dep tree would still be contained in the report.

All in all, what do you think about #3? Would this address your problem sufficiently?

Hi @fviernau ,
I think that, based on your initial comment, we need to tackle first the separation between "internal/external" libs. This is a key underlying problem in our use case. Internal deps should not count in the depth calculus. And this should be provided in a code-less way (a list of repos, or folders in a case of monorepo, rather than a script).
Maybe I should create a separate issue for this?
Only after ORT can know what is internal vs external, we could start addressing the "direct dependency" (or n-depth) issue.
This being said, the direction seems to be towards your 3rd alternative.

If we provide a parameter to reduce the maximum depth of analysis this would change one of the core assumptions of ORT that everything is analyzed (but not necessary scanned). If we change this assumption we would need to update all ORT results to record maximum depth of analysis  and we would need to update all reports to make communicate this fact - this is not easy to communicate in SPDX or CycloneDX.

@dgutson I understand your use case, you want to make sure we can support it without breaking existing functionality. For me the simplest was to implement this would be to implement a skipTransitiveDependenciesAfterLevel = [int] within the scanner configuration within ort.conf. Everything would still be analyzed but not scanned after a certain level which means we don't break existing assumptions and don't need to touch analyzer or reporter code.

That would be a optimization of execution time of scans, but the report would still contain entries for all dependencies.
Not sure if @dgutson wants the "level > X" dependencies to compeltely disappear. @dgutson can you clarify?

I actually don't care about the level > X dependencies; however the "internal vs external" dependencies still hold (internal should not count in the X).
Also, running ORT this way is one use case, so I think changing the configuration each time I need to use ORT for a different use case is not a good UX. This is why I suggested a command line flag.

I think that setting a --max-depth N could be helpful, N being 1 in the case of direct dependencies.

While I also understand your use case @dgutson, I agree with @tsteenbe's comment that this goes against one of the fundamental design concepts of ORT: We always try to get all information that we can, and then eventually filter down or consider only relevant parts of the data in later steps. This way ORT results are much more transparent and reproducible, and you do not need to record which parts of a project you did not analyze / scan in order to avoid confusion when comparing results from analyzing / scanning the same project with different ORT configuration.
So I would be be :-1: on introducing a --max-depth N option or one that limits to direct dependencies.
However...

we need to tackle first the separation between "internal/external" libs. This is a key underlying problem in our use case. Internal deps should not count in the depth calculus. [...] Maybe I should create a separate issue for this?

I agree that we need to make it easy in ORT to distinguish between internal and external dependencies, as usually differently policy rules apply for these, and to me this smells mostly like  https://github.com/oss-review-toolkit/ort/issues/4892.
But I do not yet get how the depth calculus relates to this. Do you really want to look at different depths of transitive dependencies depending on whether a direct dependency is internal or external? Or would it be enough to just distinguish between internal and external, and skip internal completely as the assumption is that internal dependencies were already scanned by ORT as root projects at some point in time, and thus do not need to be scanned as dependencies anymore at all?

Note to myself, meanwhile this actually was implemented specific to the DotNet / NuGet analyzers to work around an issue with dependency resolution.

The old DotNet / NuGet analyzers were replaced with a completely new approach that does not have the depth-limitation work around anymore. In general, I don't see us implementing this. It's simply too much work to do for all package managers individually. Post-processing the result for the level of dependencies one is interested in is the was to go despite the "[waste of] processing power and time" mentioned here.

It's ok, but just for the record, ORT takes a full night (more than 6hs) to do the job for part of our project.

I'm curious about how long it takes for other users?

Feel free to start a discussion.


[WIP] Add support for postgres persistence

I did the first steps for adding postgres support.
Fixes https://github.com/uber/cadence/issues/2536 and https://github.com/uber/cadence/issues/1834

[x] Add basic support for postgres
[x] Migrate the schema files
[ ] Add postgres tests
[ ] Fix postgres tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Niels Hofmans seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@wxing1292 I fixed your comments, please take a look.
FYI I do not have viewing permissions on the buildkite server, so no idea what is happening there.

@longquanzheng could you review the event v2 part?
@vancexu could you review the visibility part?

@wxing1292 I fixed your comments, please take a look.
FYI I do not have viewing permissions on the buildkite server, so no idea what is happening there.

--- FAIL: TestPostgresConnTestSuite (0.01s)

    --- PASS: TestPostgresConnTestSuite/TestParseCQLFile (0.00s)

    --- FAIL: TestPostgresConnTestSuite/TestSQLConn (0.00s)

        require.go:765:

            	Error Trace:	conn_test.go:127

            	Error:      	Expected nil, but got: &errors.errorString{s:"unsupported database driver: postgres"}

            	Test:       	TestPostgresConnTestSuite/TestSQLConn

@vancexu the difference is only in the connection string (DSN), schema SQL files and perhaps some minor query syntax differences.
@wxing1292 how can I run the tests locally?

@vancexu the difference is only in the connection string (DSN), schema SQL files and perhaps some minor query syntax differences.
@wxing1292 how can I run the tests locally?

Sorry about the inconvenience, please refer to this local docker file
basically, build kite is using this .buildkite file as a list of validation tasks.
the .buildkite file is basically referencing to this docker file
the local docker file shown at the very beginning should be the local test equivalent

BTW, usually, we do make clean && make for local testing. (assuming that you have cassandra & MySQL 5.7 running locally)
BTW, this is the error shown on build kite

# github.com/uber/cadence/common/persistence/sql/storage/mysql
--
  | common/persistence/sql/storage/mysql/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:
  | *DB does not implement sqldb.Tx (missing DeleteFromEvents method)
  | common/persistence/sql/storage/mysql/db.go:37:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Interface in assignment:
  | *DB does not implement sqldb.Interface (missing DeleteFromEvents method)
  | common/persistence/sql/storage/mysql/db.go:57:14: cannot use NewDB(mdb.db, xtx) (type *DB) as type sqldb.Tx in return argument:
  | *DB does not implement sqldb.Tx (missing DeleteFromEvents method)
  | # github.com/uber/cadence/common/persistence/sql/storage/postgres
  | common/persistence/sql/storage/postgres/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:
  | *DB does not implement sqldb.Tx (missing DeleteFromEvents method)
  | common/persistence/sql/storage/postgres/db.go:37:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Interface in assignment:
  | *DB does not implement sqldb.Interface (missing DeleteFromEvents method)
  | common/persistence/sql/storage/postgres/db.go:57:14: cannot use NewDB(mdb.db, xtx) (type *DB) as type sqldb.Tx in return argument:
  | *DB does not implement sqldb.Tx (missing DeleteFromEvents method)
  | Makefile:118: recipe for target 'cadence' failed

Can someone help out on the above errors? I can't seem to find the cause of:
common/persistence/sql/storage/mysql/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:

Can someone help out on the above errors? I can't seem to find the cause of:
common/persistence/sql/storage/mysql/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:

Deletion of  common/persistence/sql/storage/mysql/event.go is the cause.
The statement var _ sqldb.Tx = (*DB)(nil) is asserting that mysql.DB satisfies the sqldb.Tx interface.  Specifically, it's failing because DeleteFromEvents() was deleted with the rest of mysql/event.go.

I believe events V1 is deprecated. plz remove this file and panic on usage of events v1 & postgres

Note that only removal of the postgres implementation was requested, not mysql. It's not clear to me where the postgres panics should be added. Perhaps @wxing1292 can clarify?
Sorry I can't be more helpful. I just started exploring Cadence a couple days ago, but I'm really interested in PostgreSQL support.

Can someone help out on the above errors? I can't seem to find the cause of:
common/persistence/sql/storage/mysql/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:

Deletion of common/persistence/sql/storage/mysql/event.go is the cause.
The statement var _ sqldb.Tx = (*DB)(nil) is asserting that mysql.DB satisfies the sqldb.Tx interface. Specifically, it's failing because DeleteFromEvents() was deleted with the rest of mysql/event.go.

I believe events V1 is deprecated. plz remove this file and panic on usage of events v1 & postgres

Note that only removal of the postgres implementation was requested, not mysql. It's not clear to me where the postgres panics should be added. Perhaps @wxing1292 can clarify?
Sorry I can't be more helpful. I just started exploring Cadence a couple days ago, but I'm really interested in PostgreSQL support.

Sorry for the confusion again, please keep the file, function, but panic whenever the functions are called.

@hazcod it seems that your PR (adding support of postgres) has collide with @meiliang86's change (Kafka deprecation)
@meiliang86 can you plz help?
ref:
# github.com/uber/cadence/common/persistence/sql/storage/postgres
--
  | common/persistence/sql/storage/postgres/db.go:36:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Tx in assignment:
  | *DB does not implement sqldb.Tx (missing GetLastEnqueuedMessageIDForUpdate method)
  | common/persistence/sql/storage/postgres/db.go:37:5: cannot use (*DB)(nil) (type *DB) as type sqldb.Interface in assignment:
  | *DB does not implement sqldb.Interface (missing GetLastEnqueuedMessageIDForUpdate method)
  | common/persistence/sql/storage/postgres/db.go:57:14: cannot use NewDB(mdb.db, xtx) (type *DB) as type sqldb.Tx in return argument:
  | *DB does not implement sqldb.Tx (missing GetLastEnqueuedMessageIDForUpdate method)
  | Makefile:118: recipe for target 'cadence' failed

@hazcod We recently added a queue interface for domain replication. Relevant MySql implementation is at cadence/common/persistence/sql/sqlQueue.go
It should be fairly simple for you to port to postgres.

I added the missing queue.go in https://github.com/uber/cadence/pull/2537/commits/298947cbafe1d9f2c59cd1624695bb330fdca324 @meiliang86 @wxing1292

@hazcod is it ready to test this locally?

@SebastianM I have never used or ran cadence before, so please do test it locally!

@hazcod I get an error for the history manager when starting the cadance server:
{"level":"fatal","ts":"2019-10-04T09:15:13.151+0200","msg":"failed to create shard manager","service":"cadence-history","error":"sql: unknown driver \"postgres\" (forgotten import?)","logging-call-at":"service.go:337","stacktrace":"github.com/uber/cadence/common/log/loggerimpl.(*loggerImpl).Fatal\n\t/Users/.../cadence/common/log/loggerimpl/logger.go:139\ngithub.com/uber/cadence/service/history.(*Service).Start\n\t/Users/.../cadence/service/history/service.go:337\nmain.execute\n\t/Users/.../cadence/cmd/server/server.go:225"}

Seems like a side effect import is missing somewhere for pq?

@SebastianM how are you compiling & running the server? I'll fix.

Steps to reproduce:

go to cmd/server and run go build
create a config dir in cmd/server
create a base.yaml file in the new config dir with the following config (change db credentials):

log:
stdout: true
level: info

persistence:
defaultStore: postgres
visibilityStore: postgres
numHistoryShards: 4
datastores:
  postgres:
    sql:
     driverName: postgres
     databaseName: "xxx"
     connectAddr: "<IP_ADDRESS>:5432"
     connectProtocol: "tcp"
     user: "xxxx"
     password: "xxxx"
     maxConns: 10
     maxIdleConns: 5
     maxConnLifetime: "1m"
ringpop:
name: cadence
bootstrapMode: hosts
bootstrapHosts: ["<IP_ADDRESS>:7933"]
maxJoinDuration: 30s

services:
frontend:
  rpc:
    port: 7933
    bindOnLocalHost: true
  metrics:
    statsd:
      hostPort: "<IP_ADDRESS>:8125"
      prefix: "cadence"
  pprof:
    port: 7936

matching:
  rpc:
    port: 7935
    bindOnLocalHost: true
  metrics:
    statsd:
      hostPort: "<IP_ADDRESS>:8125"
      prefix: "cadence"
  pprof:
    port: 7938

history:
  rpc:
    port: 7934
    bindOnLocalHost: true
  metrics:
    statsd:
      hostPort: "<IP_ADDRESS>:8125"
      prefix: "cadence"
  pprof:
    port: 7937

worker:
  rpc:
    port: 7939
    bindOnLocalHost: true
  metrics:
    statsd:
      hostPort: "<IP_ADDRESS>:8125"
      prefix: "cadence"
  pprof:
    port: 7940

clusterMetadata:
enableGlobalDomain: false
failoverVersionIncrement: 10
masterClusterName: "active"
currentClusterName: "active"
clusterInformation:
  active:
    enabled: true
    initialFailoverVersion: 0
    rpcName: "cadence-frontend"
    rpcAddress: "localhost:7933"

dcRedirectionPolicy:
policy: "noop"
toDC: ""

archival:
history:
  status: "enabled"
  enableRead: true
  provider:
    filestore:
      fileMode: "0666"
      dirMode: "0766"
visibility:
  status: "disabled"
  enableRead: false

domainDefaults:
archival:
  history:
    status: "disabled"
    URI: "file:///tmp/cadence_archival/development"
  visibility:
    status: "disabled"

kafka:
clusters:
  test:
    brokers:
      - <IP_ADDRESS>:9092
topics:
  cadence-visibility-dev:
    cluster: test
  cadence-visibility-dev-dlq:
    cluster: test

publicClient:
hostPort: "localhost:7933"

run ./server start

@SebastianM sorry for the hassle, but seems like there is a level of indentation gone in the config file?

@hazcod hmmm, try this: https://gist.githubusercontent.com/SebastianM/5b77a83f07c4bc51a75b2cdc4a8e132f/raw/711e0111cc1e9cad57217a58bef59dbf3c33d65e/base.yaml

@SebastianM that is now fixed, not just needs a locally listening postgres.

@hazcod thanks, now it requests a ssl certificate for postgres connection. Is there a way to disable ssl via the configuration?
{"level":"fatal","ts":"2019-10-04T12:00:01.123+0200","msg":"failed to create shard manager","service":"cadence-history","error":"pq: SSL is not enabled on the server","logging-call-at":"service.go:337","stacktrace":"github.com/uber/cadence/common/log/loggerimpl.(*loggerImpl).Fatal\n\t/Users/sebmueller/.../cadence/common/log/loggerimpl/logger.go:139\ngithub.com/uber/cadence/service/history.(*Service).Start\n\t/Users/.../cadence/service/history/service.go:337\nmain.execute\n\t/Users/.../cadence/cmd/server/server.go:225"}

https://github.com/hazcod/cadence/pull/2

Honestly I feel like I miss too much of the code familiarity of cadence here to be able to fully support this code change. Can someone from the team step in too?

Honestly I feel like I miss too much of the code familiarity of cadence here to be able to fully support this code change. Can someone from the team step in too?

We are actually trying to (see https://github.com/uber/cadence/pull/2537#issuecomment-539747740), although we cannot really promise the progress.
Can you plz take a look at https://github.com/hazcod/cadence/pull/2 ?
We may have to create multiple PRs to your repo (so it can land in this PR).

Oh apologies, I for some reason thought that was a PR to uber/cadence. Merged!

Oh apologies, I for some reason thought that was a PR to uber/cadence. Merged!

That is fine, since we are also doing server side cleanup, there maybe more PR (there is already one PR merged removing events V1 table & corresponding logic)
We probably also need to setup the test correctly, may take some time :)

Close in favor of https://github.com/uber/cadence/pull/2836


Cleanup options

Add ability to pass options to cleanup/clear methods.
Also protect methods that should be protected in base storage subclasses.

Nit: I would consider breaking this into two PR's (one for supporting cleanup options, and another for protecting protected methods), but it's totally not a big deal.

I'll be merging this as two commits without squashing so the history is essentially the same as 2 PRs.

Also, just out of curiosity (and because I'm probably going to use the cleanup method next week 😄) ... what's the first use-case you have in mind for cleanup options?

We have a sql storage mechanism internally that needs this in order to be interruptible for infrastructure stability reasons.


feat: Apply the ALM example increment to existing CRs

fix #637
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@bitscuit @Daniel-Fan
Could you help review this PR?


Support Athena's new use of QUEUED state

API change within last 24 hours that started creating sporadic failures.

Fixed in v1.53.3!


RF Stockalike provides RealPlume configs

OP also strongly recommends RealPlume since stock effects are broken in some cases, so that is reflected as well

LGTM :)
Seems the RO train has started picking up speed 👍


Improve kkt creation on GPUs

This PR improves KKT System creation on GPUs.
For some parts, we've been calling CPU versions. We introduce native GPU code for them.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.83%. Comparing base (8801bef) to head (6e0e8cd).
Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   68.75%   68.83%   +0.07%
==========================================
  Files          42       42
  Lines        4622     4630       +8
==========================================
+ Hits         3178     3187       +9
+ Misses       1444     1443       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgraded to 0.9.4

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham Hi! I am sorry to bother you again, but it seems that there is something wrong with CircleCI; it skipped the build for this PR with "NOT RUNNING" state: https://circleci.com/gh/conda-forge/flask-oauthlib-feedstock/13. Is this fine?

No bother at all.
Weird. I saw something similar like this with the scipy feedstock the other day. Hadn't really seen it since. Maybe there is some low frequency issue we are encountering with CircleCI.
In any event, canceling that build and restarting it appears to have created a new build with the scheduled status. That actually isn't surprising as we have a lot of builds going in order to rebuild everything for NumPy 1.13, which was released recently. Also we are now seeing the CircleCI status on the PR, which we weren't previously.
Guessing this has fixed the issue. Though if you see anything else strange, please let us know.

All tests are passed! It is ready to merge.

@pmlandwehr @jakirkham I am kindly pinging you for getting this merged.


Add PS signatures

Signed-off-by: lovesh<EMAIL_ADDRESS>

I am eager to see this merged, because it will be helpful for some enhancements to Hyperledger Indy credential schemes.

There needs to be more sad path tests implemented

I added more.

Thank you @lovesh . I will merge


add Korean translation for missing names

Great!  Thank you very much!

My pleasure!
Liam Jongsu Kim
Sent from
https://polymail.io/
On 2017년 2월 12일 (일) at 오전 1:26 Jon Capa
<
mailto:Jon Capa<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
Great! Thank you very much!
—
You are receiving this because you authored the thread.
Reply to this email directly,
https://github.com/capajon/r6maps/pull/59#issuecomment-279157211
, or
https://github.com/notifications/unsubscribe-auth/AAJjpEidwusUdFJO8xiyp-iPgFoe-dXCks5rbeFFgaJpZM4L-F0A
.


Merge new version with master branch

Sorry.. This pull request was an oversight.... If possible, please delete it.. Thank you!


New syntax?

In Swift 3 version of SwiftShell this code was working perfectly:
`let unavailState: String = run("/bin/bash", with: [ "-c", "/usr/local/bin/zpool status | grep state | grep -w UNAVAIL | wc -l"])
let trimUnavail = unavailState.trimmingCharacters(in: .whitespacesAndNewlines)
let degradedState: String = run("/bin/bash", with: [ "-c", "/usr/local/bin/zpool status | grep state | grep -w DEGRADED | wc -l"])
let trimDegraded = degradedState.trimmingCharacters(in: .whitespacesAndNewlines)
let offlineState: String = run("/bin/bash", with: ["-c", "/usr/local/bin/zpool status | grep state | grep -w OFFLINE | wc -l"])
let trimOffline = offlineState.trimmingCharacters(in: .whitespacesAndNewlines)
let faultedState: String = run("/bin/bash", with: ["-c", "/usr/local/bin/zpool status | grep state | grep -w FAULTED | wc -l"])
let trimFaulted = faultedState.trimmingCharacters(in: .whitespacesAndNewlines)
let removedState: String = run("/bin/bash", with: ["-c", "/usr/local/bin/zpool status | grep state | grep -w REMOVED | wc -l"])
let trimRemoved = removedState.trimmingCharacters(in: .whitespacesAndNewlines)
let onlineState: String = run("/bin/bash", with: ["-c", "/usr/local/bin/zpool status | grep state | grep -w ONLINE | wc -l"])
let trimOnline = onlineState.trimmingCharacters(in: .whitespacesAndNewlines)
But now, it throw an error while compiling:Argument labels '(_:, with:)' do not match any available overloads`
So, what is new way to do the same thing?

Yes, there is a new syntax, you can read more about it here: https://github.com/kareman/SwiftShell .
So e.g. the first command will be:
let unavailState = run(bash: "/usr/local/bin/zpool status | grep state | grep -w UNAVAIL | wc -l").stdout
let trimUnavail = unavailState.trimmingCharacters(in: .whitespacesAndNewlines)

You may not even need to do the trimming yourself if the output is one line.


gitleaks does not scan correct files with pre-commit run --files

Describe the bug
gitleaks pre-commit hook scans the staged files instead of the files that pre-commit requests to scan.
To Reproduce
Steps to reproduce the behavior:
# assuming pre-commit 2.21.0, go 1.22.3
mkdir -p precommit-reproduce
rm -rf precommit-reproduce/*
cd precommit-reproduce
git init
cat > .pre-commit-config.yaml <<EOF
repos:
- repo: https://github.com/gitleaks/gitleaks
  rev: v8.18.2
  hooks:
    - id: gitleaks
EOF
echo "export BUNDLE_ENTERPRISE__CONTRIBSYS__COM=cafebabe:deadbeef" > leak.go
git add .pre-commit-config.yaml leak.go
git commit -m "Initial commit with a leak"
pre-commit install
pre-commit run --files leak.go   # succeeds, but should not

echo "export BUNDLE_ENTERPRISE__CONTRIBSYS__COM=cafebabe:deadbeef" >> leak.go
git add leak.go
# This one fails as expected.
git commit -m "Add another leak"

Expected behavior

pre-commit run --files leak.go should fail with a message about a leak

Screenshots
none
Basic Info (please complete the following information):

OS: Ubuntu 20.04
Gitleaks Version: 8.18.2

Additional context
pre-commit run --files is a use case eg. in merge-gate scenario in CI. A generic way of running pre-commit on all changed files in a PR is to git diff the changes between source and target branch, then feed the list to pre-commit.
The workaround is probably to use gitleaks-action or to write custom code which creates a scan baseline. But couldn't gitleaks accept a list of files to scan, so that it integrates nicely with less-commonly-used commands of pre-commit?
cc @zricethezav

I'm having this same issue so I thought I'd try to alter the invocation to become gitleaks file file1 file2 file3. But this ends up scanning the entire current working directory and not just the provided files.

The same happens with "pre-commit run --all" gitleaks


DockingLayoutBuilder Missing dividerProportion

Looks like DockingLayoutBuilder is also missing an option to add the dividerPropertion.

This has been added, but I missed actually using it. The DockingSimplePanelNode builds a DockingSplitPanelNode with dividerProportion hardcoded to .5.

The DockingTabPanelNode also builds a split and has a hardcoded 0.5.

The divider proportion (when docking to a simple panel) appears to be sizing the left/top object when it should be sizing the new dockable being docked. For instance, I had to use 0.7 instead of 0.3 when docking a dockable to the east of the existing dockable.


Log a warning/ raise an error when lightning replaces an existing Sampler

🚀 Feature
First of all, thanks for this awesome project! Really enjoying using it!
Feature Request: Log a warning or raise a MisconfigurationException when lightning replaces an existing sampler with DistributedSampler.
Even though this behaviour is documented, it's not intuitive. Also, if someone has defined a sampler - it will lead to very different training results if you use Single GPU vs DDP. So best to warn a user to remove the sampler from their code if using replace_sampler_ddp=True.
Motivation
I'm pretty new to lightning - and recently moved one of my models to lightning. Unaware of the details, I chose ddp training strategy (since it was recommended). For a long time, my model was not converging on the val set - and it took me a lot of time to realise what was happening - lightning had replaced my Dataloader's sampler with DistributedSampler! In my particular model, balanced sampling iskey to convergence (since data is highly imbalanced). Lightning's behaviour makes sense in hindsight, and is well documented - but  may have saved me a lot of debugging time had it given a simple warning or error when this happens.
Additional context
The code change is very trivial. We can take advantage of the fact that DataLoader's default sampler is SequentialSampler (if shuffle=False and sampler=None).
data_loading.py:115
if self.replace_sampler_ddp and need_dist_sampler:
    if not isinstance(dataloader.dataset.sampler, SequentialSampler):
        raise MisconfigurationException(...)

Does this make sense? Happy to submit a PR if it does.
On a separate note, can anyone here explain why exactly is DistributedSampler needed when using DDP? I can see that it will help if I have shuffle=false. It will probably help maintain sanity of an epoch (since otherwise epoch length will become num_processes*epoch).
But let's say I am doing random shuffling - and am cognizant of the fact that my epoch sizes will be higher, there is no real reason that I need to use DistributedSampler for DDP right? Or am I missing something?

@devashishshankar sounds good to me, mind send a PR?

@Borda Yes, will do!


refactor sensors_qcom

new struct SensorState
remove hardcoded sensor handles, get them from get_sensors_list.
use callback function to build sensor message.
try to solve the following problem(sensor.which() will return 0(ACCELERATION) if the message is empty):
https://github.com/commaai/openpilot/blob/59698344a2c1f6557b06485de1dcf296ec5eb542/selfdrive/ui/ui.cc#L216-L217

regarding 4. That happened while running sensors_qcom2. Also pretty sure it's on the receiving end, I can run multiple instances of ui at the same time, and only one will crash.

oic

@pd0wm The reason that sensorEvents reads an empty list may be that the number of read connections exceeds the limit (NUM_READERS) :
https://github.com/commaai/cereal/blob/97bfe99980a3ef58e07eb8006ac5e59bf83ad986/messaging/msgq.hpp#L27-L29

regarding 4. That happened while running sensors_qcom2. Also pretty sure it's on the receiving end, I can run multiple instances of ui at the same time, and only one will crash.

it's fixed in #21427


[Discord Dark] Fix a broken color after v1.9.1/v1.9.2 update

Fixes issues that appeared after v1.9.1 or v1.9.2 update of Element (see https://github.com/vector-im/element-web/issues/19381)

Invisible "Explore Space" icon
Invisible Reaction panel icons (React/Reply/Expand quote/Options)
No border at selected space icon

Note: we might see more variables and name changes soon. But this was the only change needed for the latest version (v1.9.2).
If you set it to timeline-text-color value, your theme should be fixed.

One more variable was needed after all. Missed this little arrow.

Let me know if there are some other places where new variables are used. It's quite hard to catch them individually.


Merge pileup

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/531/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/532/
Test PASSed.


[testing] removed deprecated test helper methods and usage of deprecated ES test helpers

removed following deprecated TestHelpers methods:

createFunction() (all variants)
whereClause()

also removed usage of deprecated ES client().prepareCount() test helper method

otherwise awesome cleanup :+1:

ack


fixes typos: #1375

fixes typos: MicrosoftDocs/architecture-center#1375

OPS Build status updates of commit cdd95e0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


lame: spec refactoring

I prepared package lame which contains an MP3 encoder and optionally, an MP3 frame analyzer. It provides lame encoding utility and mp3rtp streaming utility. I divided binaries and libraries/headers by lame and lame-devel.

Looks good, merged. Thanks!


Fix in ProcessInitImageCommand

When capturing trimmed under certain conditions texture data were dumped to the capture file using a staging buffer and at during replay they were loaded back to the texture without a staging buffer. This occasionally led to corrupted textures. This patch should address this issue

CI gfxreconstruct build queued with queue ID 60279.

CI gfxreconstruct build # 3374 running.

CI gfxreconstruct build # 3374 failed.

CI gfxreconstruct build queued with queue ID 60455.

CI gfxreconstruct build # 3377 running.

CI gfxreconstruct build # 3377 failed.

CI gfxreconstruct build queued with queue ID 60906.

CI gfxreconstruct build # 3380 passed.


Treat assert() as a branch

Right now, assert()s don't matter in coverage (they're always considered covered), which makes them easy to skip when writing tests. Is there any way to change that behaviour?

You could use an if statement instead of an assert which would make this show up as a branch.

True, but that looks considerably uglier (3 lines instead of 1), especially in a block of aprox. 10 consecutive asserts. I'm just suggesting that assert could be a frequent enough use case to warrant special behaviour.

Not doing this. In the general case, there is no way for the instrumenter to know what the function being executed actually is unless it does a scope analysis and puts in all sorts of assumptions about how things work in node


Hyundai Website Clone

Description
Description of the project here
I want to add  Hyundai Website Clone , which will be made HTML,CSS,JS
Code of Conduct

[X] I follow Contributing Guidelines of this project.

/assign


Databricks parquetFilters api change in db 8.2 runtime

Note this is targetted for 21.08 so don't merge until we get OK and we might need in 21.06.02
Fixes https://github.com/NVIDIA/spark-rapids/issues/3191
parquet tests pass on 21.08 and 21.10 running on databricks 8.2 runtime
Signed-off-by: Thomas Graves<EMAIL_ADDRESS>

build

Shall we commit this fixing to branch-21.06, and let it auto-merge to 21.08 then 21.10?


Your license has expired

Steps to reproduce
In my jupyter (within docker environment) I ran:
!conda config --add channels conda-forge
!conda config --add channels https://conda.atoti.io
!conda install --yes atoti atoti-jupyterlab

import atoti as tt

session = tt.create_session()

Actual vs Expected Result
I'm getting Exception: Your license has expired, contact ActiveViam to get a new license. where I was expecting this to work fine.
Environment

Python: 3.8.6
Operating System: linux

Hello,
Which version of atoti do you have ? (from atoti import __version__.
Also do you have ACTIVEPIVOT_LICENCE or ATOTI_LICENCE env variable set on your computer ?

it throws the license exception when trying to check the version:
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
<ipython-input-7-2bfbd9da0f4c> in <module>
----> 1 from atoti import __version__

/opt/conda/lib/python3.8/site-packages/atoti/__init__.py in <module>
     44 (_LICENSE_END_DATE, _IS_COMMUNITY_LICENSE) = retrieve_info_from_jar()
     45
---> 46 check_license(_LICENSE_END_DATE, _IS_COMMUNITY_LICENSE)
     47
     48 register_active_plugins()

/opt/conda/lib/python3.8/site-packages/atoti/_licensing.py in check_license(end_date, is_community_license)
    152     for output in get_license_outputs(end_date, is_community_license):
    153         if output.output_type == OutputType.EXCEPTION:
--> 154             raise Exception(output.content)
    155         if output.output_type == OutputType.REGULAR:
    156             print(output.content)

Exception: Your license has expired, contact ActiveViam to get a new license.

I don't have neither of these variables set:
jovyan@e64ea8ddf388:~$ env | grep LICENSE
jovyan@e64ea8ddf388:~$

does it work with conda list ? Can you also run a pip list

Sure.
jovyan@e64ea8ddf388:~$ conda list | grep atotia
atoti                     0.5.5                   dc3a2a6    https://conda.atoti.io
atoti-jupyterlab          0.5.5                   dc3a2a6    https://conda.atoti.io
jdk4py                    <IP_ADDRESS>                 py38_2    https://conda.atoti.io

jovyan@e64ea8ddf388:~$ pip list | grep atoti
atoti                         0.5.5
atoti-jupyterlab              0.5.5

That's so weird, I'm pretty sure I just installed this a few days ago. Thanks, I'll check on my side.

Oh ok, mystery solved, looks like conda solver pulled an older version (namely 0.5.5). I think it would be good to mention this in installation docs, as isn't very obvious.

To mention the license duration ?

Yes - especially considering that conda solver might pull an older version unknowingly to the user (me in this example :smile:).

Hello this was resolved in 0.6.2 by https://github.com/activeviam/atoti/pull/2549


Fatal error when running monkey-dl.exe for the first time

So when trying to start the program, I get this error. My Python version is 3.7 and I have rebooted since installing.

Windows 7? Sorry this is a known issue that Monkey-DL does not support Windows 7

Windows 7? Sorry this is a known issue that Monkey-DL does not support Windows 7

Aw, that's a shame. Thanks for letting me know nevertheless!


Lots of "XIO:  fatal IO error 0 (Success)" errors when running tests under Xvfb

Issue Report Checklist

[x] Searched the issues page for similar reports
[x]  Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
When I run the whole test suite or almost any collection of tests within it under xvfb (as I have to in the non-interactive testing autopkgtest environment), I consistently get an error at the very end like the following:
The X11 connection broke: I/O error (code 1)
XIO:  fatal IO error 22 (Invalid argument) on X server ":30"
      after 62939 requests (62933 known processed) with 0 events remaining.
QObject::~QObject: Timers cannot be stopped from another thread

That means that I can't actually determine easily whether the tests have been successful or not, as this error causes pytest to exit with an error code whether or not all of the individual tests have passed; this is clearly a spurious error.  It is also well-known: https://github.com/The-Compiler/pytest-xvfb/issues/11.  The best suggestion there so far is to ensure that all windows are closed before finishing the test.  This probably affects hundreds of the tests in the spyder test suite, so I wonder whether there is an easy way to close all open windows in conftest.py, perhaps using some sort of general teardown function that applies to every test?  I don't yet know enough about how qtbot etc works to be able to do this myself, I'm afraid, but it would be a right pain to have to modify every single test to achieve this.  Do you have any ideas?
What steps reproduce the problem?
CI=true xvfb-run -a -s "-screen 0 1024x768x24 +extension GLX" python3.9 runtests.py

(possibly with some tests excluded; I also have to specify the HOME directory and some other inconsequential tweaks).
A smaller example is this; here /tmp/tmp.lzQBAqxWji is a temporary initially-empty directory created for this set of tests:
(sid-minimal)jdg@euler:/build/spyder-jdg/build-area/spyder-5.2.1+dfsg1$ HOME=/tmp/tmp.IzQBAqxWjj xvfb-run -a -s "-screen 0 1024x768x24 +extension GLX" python3.10 runtests.py spyder/plugins/shortcuts/tests
Pytest Arguments: ['-vv', '-rw', '--durations=10', '-W ignore::UserWarning', 'spyder/plugins/shortcuts/tests']
============================= test session starts ==============================
platform linux -- Python 3.10.1, pytest-6.2.5, py-1.10.0, pluggy-0.13.0 -- /usr/bin/python3.10
cachedir: .pytest_cache
PyQt5 5.15.6 -- Qt runtime 5.15.2 -- Qt compiled 5.15.2
rootdir: /build/spyder-jdg/build-area/spyder-5.2.1+dfsg1, configfile: pytest.ini
plugins: flaky-3.7.0, xvfb-2.0.0, mock-3.6.1, cov-3.0.0, order-1.0.0, qt-4.0.2, lazy-fixture-0.6.3
collected 13 items

spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcuts PASSED  [  7%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcut_in_conf_is_filtered_with_shortcut_data PASSED [ 15%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcuts_filtering PASSED [ 23%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcut_filtering_context PASSED [ 30%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_clear_shortcut PASSED [ 38%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_press_new_sequence PASSED [ 46%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_press_new_compound_sequence PASSED [ 53%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_clear_back_new_sequence PASSED [ 61%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_sequence_conflict PASSED [ 69%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_sequence_single_key PASSED [ 76%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_set_sequence_to_default PASSED [ 84%]
spyder/plugins/shortcuts/tests/test_shortcuts.py::test_invalid_char_in_sequence PASSED [ 92%]
spyder/plugins/shortcuts/tests/test_shortcuts_config_dialog.py::test_config_dialog[config_dialog0] PASSED [100%]

============================= slowest 10 durations =============================
0.21s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcuts
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts_config_dialog.py::test_config_dialog[config_dialog0]
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcuts_filtering
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_set_sequence_to_default
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_shortcut_filtering_context
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_sequence_conflict
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_press_new_compound_sequence
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_clear_back_new_sequence
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_sequence_single_key
0.05s setup    spyder/plugins/shortcuts/tests/test_shortcuts.py::test_press_new_sequence
============================== 13 passed in 1.65s ==============================
The X11 connection broke: I/O error (code 1)
XIO:  fatal IO error 0 (Success) on X server ":30"
      after 1206 requests (1198 known processed) with 0 events remaining.

That will be amazing, thanks!  Most of the test suite does pass already with PyQt 5.15.2, as I have discovered; I think I've reported all of the "obviously" failing tests.  Please do let me know if there's anything I can do to help; once the nbconvert bug (https://github.com/jupyter/nbconvert/issues/1685) is resolved, it would be great to get Spyder 5.x into Debian!

Hi
just recently I learnt of  spyder python IDE. I was  quite impressed with the layout and its functionality and its ipython console. However when I tried running it remotely executed from my CentOS machine  connected from my ubuntu notebook   I get the following error:
(20:37 admpy@ThermalBox anaconda3) > bin/spyder
The X11 connection broke: No error (code 0)
XIO:  fatal IO error 0 (Success) on X server "localhost:10.0"
after 426 requests (426 known processed) with 0 events remaining.
  this is with Spyder 5.2.2

Which is the same error listed in this issue. Will this be fixed when spyder supports PyQt5 5.15 ?

Thanks

Hi @juliangilbey I was checking this and seems like uninstalling or deactivating pytest-xvfb  prevents showing the message. I think the reason why the fatal IO error 0 messages are not showing in our CI is because we are uninstalling it: https://github.com/spyder-ide/spyder/blob/b3c292de6c7d9cc7c476625e1c68809cc548a784/.github/scripts/install.sh#L36-L37
Could you check if that helps?
Also, hi @admanero thank you for your feeback! I'm not totally sure but maybe it could be caused by the Spyder screen resolution preferences set on your CentOS machine. It could be also related with incompatibility with drivers or graphics cards as in https://github.com/spyder-ide/spyder/issues/8057 . If you get any other info let us know!

Hi @dalthviz - thanks, that's it exactly - good catch!  Removing pytest-xvfb from the environment resolves this issue.  So this issue can be closed as far as I am concerned.

It'll be closed when PR #16409 is merged.


Awesome Persian NLP/IR, Tools And Resources

https://github.com/mhbashari/awesome-persian-nlp-ir
*The best resource and tools for natural language processing and information retrieval experts wanna to build Persian language based system or research about new methods and paradigms in that two (Persian NLP and Persian IR).Because of the rareness of data,corpus and easy-to-use tools in such fields, this curated list can accelerate the initial steps of research or developing.

[x] I have read and understood the contribution guidelines and the instructions for creating a list.
[x] This pull request has a descriptive title. (For example: Add Node.js)
The list I added

[x] has been around for at least 20 days,
[x] is a non-generated Markdown file in a GitHub repo,
[x] is not a duplicate,
[x] only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
[x] contains the awesome badge on the right side of the list heading,
[x] has a Table of Contents section named Contents as the first section,
[x] has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
[x] has contribution guidelines,
[x] has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),
[x] has been added at the bottom of the appropriate category.

only has awesome items with descriptions

Please actually read the following this time:

ALL THE BELOW CHECKBOXES SHOULD BE DONE AND CHECKED AND THE ABOVE PLACEHOLDERS SHOULD BE FILLED IN BEFORE SUBMITTING A PULL REQUEST!

Descriptions added (as much as possible)
:)

This is the list of some popular attempts.

What?

has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),

No it hasn't. Example proving it:

tok-tokTok-tok is a fast, simple, multilingual tokenizer(single .pl file).

only has awesome items with descriptions

No it doesn't.

Recheck Please...

Recheck Please...

There's still some inconsistencies, e.g. this line:
 Mojgan Seraji Corpus - is a modified version of the Bijankhan corpus
Should start with a capital and end with a dot.
Some descriptions like this one could be more concise.
Also your links are rubbish, what's the URL shortener necessary for? This one for example does not even lead to the page and the iframe is broken http://mhbashari.ir/url/tok-tok

Original links replaced...

Hi!
Please open the issue or report probable problems.
Thank you very much.

Still no consistency.
Example:

polyglot (polarity) - Natural language pipeline that supports massive multilingual applications (Like Tokenization (165 Languages),Language detection (196 Languages), Named Entity Recognition (40 Languages),Part of Speech Tagging (16 Languages),Sentiment Analysis (136 Languages),Word Embeddings (137 Languages),Morphological analysis (135 Languages),Transliteration (69 Languages)).

No idea why are these words capitalized.
After some of the commas, there's a space character, after others, there is no space character.

In Addition to your request(Comma and Capitalization) the replicated "polylot" title is removed.

Please check again ...

Check again please...


Test: start to add some test cases (no need to add for all)

Suppose if could add some test cases to increase test coverage. No need to add for all functions or HTTP APIs. Just starting to add some is OK. Thanks.

I will try to add simple test cases for APIs. So the @dependabot PRs could be merged directly after CI passed.


[SPARK-7604] [MLlib] Python API for PCA and PCAModel

Python API for PCA and PCAModel

Merged build triggered.

Merged build started.

Test build #33231 has started for   PR 6315 at commit 4d9d121.

Test build #33231 has finished for   PR 6315 at commit 4d9d121.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PCAModel(JavaVectorTransformer):
class PCA(object):

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33231/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33343 has started for   PR 6315 at commit 1d58734.

Test build #33343 has finished for   PR 6315 at commit 1d58734.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PCAModel(JavaVectorTransformer):
class PCA(object):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33343/
Test PASSed.

@mengxr @jkbradley

@jkbradley @mengxr

LGTM  sorry for the delay!
I'll rerun tests since it's been a while, before merging

test this please

Merged build triggered.

Merged build started.

Test build #35403 has started for   PR 6315 at commit 1d58734.

Test build #35403 has finished for   PR 6315 at commit 1d58734.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PCAModel(JavaVectorTransformer):
class PCA(object):

Merged build finished. Test PASSed.

Merging with master and branch-1.4
Thanks!


Merge term and terminal

This is a merge of the new changes listed in #2 . Please test and see if classic methods still work. Haven't bumped the version number.

Two issues:

[ ] Old style doesn't seem to be working
[ ] Installing from git does not supply the clipboard.min.js dependency

Example page


Yale YRD430-ZW2 spamming network

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?
NO, my problem is NOT within Z-Wave JS UI
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
Adding a newly purchased YRD430-ZW2 causes the entire network to slow down and spams traffic
What do you observe?
All devices, including lock operation are significantly slowed down, debug logs are filled with entries from YRD430-ZW2.  Excluding the lock returns the network to normal.  Including it again reintroduces the problem.  Reinteviewing and healing the node do not help.
What did you expect to happen?
I also have an older YRD256 on another door with presumably the same zwave chipset, it performs normally and does not spam the network
Steps to reproduce the behavior:
Including the YRD430-ZW2 creates the issues.
Device information
Manufacturer: Yale
Model name: YRD430-ZW2
Node ID in your network: 99
How are you using node-zwave-js?

[X] zwave-js-ui (formerly zwavejs2mqtt) Docker image (latest)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker image (dev)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version:
node-zwave-js branch:
zwave-js-ui branch:
Homeassistant addon Z-Wave JS UI.
Addon version 1.12.0.
zwavejsui version v8.15.0
Did you change anything?
yes (please describe)
If yes, what did you change?
Included YRD430-ZW2
Did this work before?
Don't know, this is a new device
If yes, where did it work?
No response
Attach Driver Logfile
zwavejs_2023-05-04.log

Unfortunately it only supports S0 per its zwave certification.  I think only yale model numbers designated with *-ZW3 use a ZWave Plus V2 and support S2.  My YRD256 also only supports S0
Also it definitely is the Schedule Entry Lock queries, I woke this morning and noticed the network was fine, no more spamming in the logs.  To test, I restarted the Z-Wave JS UI and the problems started again as the logs were filling with Schedule Entry Lock queries for each code slot.  It took almost 30 minutes for it go through all 250 code slots, but once it was finished, everything was fine.


Round Summary Page Dies When Some Race Results Have Zero Values

PR #28 backs out the heat summary tables until a decision is made to better manage saved race data.


RSpec/VariableName & RSpec/VariableDefinition complain on non-rspec subject method

# `email_spec.rb` or whatever
Mail.new do
  subject 'This is a test email'
end

which is mail gem DSL for creating new emails, leads to
$ rubocop -rrubocop-rspec -V
1.14.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.5.0, running on ruby 3.0.0 x86_64-linux)
  - rubocop-rspec 2.2.0
$ rubocop -rrubocop-rspec email_spec.rb
Inspecting 1 file
C

Offenses:

email_spec.rb:3:11: C: RSpec/VariableDefinition: Use symbols for variable names.
  subject 'This is a test email'
          ^^^^^^^^^^^^^^^^^^^^^^
email_spec.rb:3:11: C: RSpec/VariableName: Use snake_case for variable names.
  subject 'This is a test email'
          ^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 2 offenses detected

Hey @ojab !
Indeed, this is problematic. mail testing doc.
I'm thinking if limiting those cops inspection to only subject that is a defied directly in an example group block would result in false positives in some other DSL. I believe your current project is rich in examples of various RSpec DSLs. What do you think?

I think we can lower the false positives by:

limiting the check to block and blockpass nodes

and/or

ignoring rspec DSL inside class/module/struct .new blocks (we can go for the extra mile to check if the defined class icludes the RSpec DSL, but that would be too edgy)

limiting the check to block and blockpass nodes

Brilliant idea, that should do it.
I couldn't quickly find if mail supports subject with a block, apparently it doesn't.

I couldn't quickly find if mail supports subject with a block, apparently it doesn't.

It does, but only with explicit receiver, so should be fine
> Mail.new { |mail| mail.subject = 'foo' }.subject
=> "foo"

@ojab Ping

I'd like to, but lack of capacity :crying_cat_face:


Sample views for FHIR resources

To make it easier and bootstrap usage of FHIR views we should create sample/generic views for a subset of FHIR resources. This serves two purposes:

Users can create simple SQL queries on these simpler views. If the views are generic enough, the user does not even need to touch FHIR-views.
These examples can be used as a starting point to experiment with more customized FHIR-views.

Here is a proposed list of initial resources (to be updated later):

Condition
Encounter
Immunization
MedicationAdministration
MedicationRequest
Observation
Patient
Procedure

I would suggest adding:

Organization - to be able to filter by organization (e.g. show me the data for Org A v B)
Practitioner - to filter by healthcare worker
PractitionerRole - to filter by healthcare worker type
ServiceRequest - to look at what has been ordered e.g. investigations, procedures or labs
DiagnosticReport - for lab results or test results (lab results often come back as Observations)


fix: fix flaky test assertions in org.apache.helix.rest.server.TestPerInstanceAccessor#testGetAllMessages

Issues

[x] My PR addresses the following Helix issues and references them in the PR description:

Fixes apache#2667
Description
This fix changes the flaky assertions of the tests in the class org.apache.helix.rest.server.TestPerInstanceAccessor#testGetAllMessages.
Sets return the elements in a non-deterministic order, which means that this assertion is not correct, because it checks whether the collections contain the same elements in the same order (this was changed in the library). This leads to a flaky test. To fix this problem, the assertion has been rewritten to check if the collections contain the same amount of elements as well as both collections contain all values of the other collection.
The flaky test has been found by using the NonDex tool – to reproduce run
mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestPerInstanceAccessor -DnondexSeed=933178

Tests
No test have been written – one existing test has been updated.

The following is the result of the "mvn test" command on the appropriate module:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:23 min
[INFO] Finished at: 2023-10-17T22:47:43-05:00
[INFO] ------------------------------------------------------------------------

This fix looks good to me!

Hi, I think if you put code to the comment will make it easier to know how you fix it. Others LGTM.


Release 0.5.4

Release 0.5.4
A value adding release with no changes outside of the Numbers Module scope.
Strict Package Additions
Create new utilities that expand on the IntRange Interface.
Resolves #106

Code Coverage Limits Need Raising:

[ ] Raise Coverage Limits in Numbers
[ ] Check other Modules for Coverage Limits

IntRange Mutable has not been completely implemented yet.
The tests are to be created next time, along with increasing the coverage limits.


Display on two rows

Hi,
I'd like to use vue-carousel but to display multiple element on two rows, something like one slide contain two elements one under another.
This feature is not currently implemented how would it be possible to implement it ?

Hey @ouraios, there are many ways to go about this. Using a component as a slide is probably the easiest. Let me know how it goes!

I mean i have an array in my component data, and i want items of the array to be visible on your vue-carousel component but i want to display two items vertically per slide.
Your vue-carousel actually dont provide this feature, maybe its me on my own to do it but i want to manipulate the items of my array as i wish.
FOr example i want to display group or products in the carousel and when selecting one group of product i want the carousel to show the products who belong to this group of product.
But i want the items to be displayed on two rows in only one carousel.
How that's possible to achieve ?
(I dont know if i'm understandable in my english, sorry i'm french)

I need the same issue, I would display two row of items (6 per page). I try to set flex-wrap on VueCarousel-inner module, but dosn't work. Have you got any suggestions? @quinnlangille
thanks!

As I mentioend above, a custom component being fed into the slide should work - something like
<template>

    <slide1> { ... props that dictate top slide content here } </slide1>
    <slide2> { ... props that dictate bottom slide content here } </slide2>

</template>

This is one of many ways you could achieve this effect, but it would cause a reorganization or maybe a computed property to transform the data. I'll be happy to see what solution you'll think of, if it's cool post it back here and I can include it as an example!


[Feature] Starrocks regexp function support CASE_INSENSITIVE

Fixes #issue
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@numbernumberone first, thanks for your contribution. I have some suggestions for this PR.

could you please describe what you are doing in this PR in the PR comment block?
You need to change document according to what you have changed
Need to add more sql-test in test/ directory.

[FE PR Coverage Check]
:disappointed: fail : 2 / 13 (15.38%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/FunctionAnalyzer.java
2
13
15.38%
[87, 88, 89, 91, 92, 93, 94, 170, 171, 186, 187]


Evaluator: Can't evaluate QIR file

Using NonadaptiveEvaluator.eval crashes the process when given a QIR .ll file and fails with an encoding exception when given a bitcode version of the same file. Nothing custom was done to generate the QIR (straight from the Q# compiler) or bitcode (just passed directly to llvm::WriteBitcodeToFile). The code itself is very basic - just one of the many Q# examples floating around. pyqir was also installed from pip, not a local version.
Bitcode issue is likely due to us using LLVM 13 which I believe is a different version than the one you're using, so may not be an issue per-say, but attaching it if you want to look at it further. There might be a way to strip version/encoding from the bitcode, but haven't spent too much time digging as-of yet.
Just mention if you need any additional info.
QIR and bitcode files.
Versions/System Info
py-evaluator: 0.4.0-alpha.1
OS: Windows 10 Pro, 21H1
Python: 3.8
Rust: 1.60
Q# SDK: 0.24.208024

Hi @chemix-lunacy and thanks for your feedback!
Regarding the encoding error when evaluating the BasicExample.bc file:
Doing the test, I get the same LLVM ERROR: Invalid encoding problem as you do.
This is a very low-level fatal error thrown by the core LLVM itself.
Your file does not seem valid. Running llvm-bcanalyzer on it returns the same error with LLVM 11, 13 and even 14:
llvm-bcanalyzer: can't skip to bit<PHONE_NUMBER>6 from 864
Which llvm::WriteBitcodeToFile did you use?
When assembling from BasicExample.ll with llvm-as, the resulting bitcode can be analyzed properly with llvm-bcanalyzer.
And the encoding error disappears, yippee! 😄
Unfortunately, both bcand ll files still make pyqir-evaluator crash. 😢
I'll try to find some time to investigate further.
In particular, llvm-bcanalyzer itself is not able to parse a short piece of the file (details with --dump):
  <UnknownBlock26 NumWords=6 BlockCodeSize=2>
    <UnknownCode1 op0=115 op1=105 op2=110 op3=103 op4=108 op5=101 op6=116 op7=104 op8=114 op9=101 op10=97 op11=100/>
    <UnknownCode1/>
  </UnknownBlock26>

  Block ID #26:
      Num Instances: 1
         Total Size: 245b/30.62B/7W
    Percent of file: 0.2501%
      Num SubBlocks: 0
        Num Abbrevs: 0
        Num Records: 2
    Percent Abbrevs: 0.0000%

	Record Histogram:
		  Count    # Bits     b/Rec   % Abv  Record Kind
		      2       172      86.0          UnknownCode1

@LaurentAjdnik Thanks for looking into it!
I'm using the same method that llvm-as uses but obviously with some required arguments missing or slightly different. It's not super import I get it working though as I don't need the bitcode right now, I was simply seeing if it worked where basic QIR didn't.

Hi again @chemix-lunacy! I think I got it!
I did many tries until I simplified your ll file to the extreme:
%String = type opaque

@0 = internal constant [3 x i8] c"()\00"

declare %String* @__quantum__rt__string_create(i8*)

define void @Microsoft__Quantum__OracleGenerator__RunProgram() #1 {
entry:
  %0 = call %String* @__quantum__rt__string_create(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @0, i32 0, i32 0))
  ret void
}

attributes #1 = { "EntryPoint" }

But it still failed...
On the other hand, replacing @__quantum__rt__string_create with any of the "well-known functions" (@__quantum__qis__h__body, @__quantum__qis__x__body...) works!
Looking into the code of the evaluator, it seems only a few functions are currently handled.
@__quantum__rt__string_create is simply unknown and cannot be evaluated. Hence the crash.
Well... It should rather return an error rather than crash... I'll file a separate issue...

Thanks @LaurentAjdnik - We should update the readme and code docs saying what bitcode is supported. Right now the evaluator can JIT QIR produced by the pyqir-generator, but cannot use any external function calls. The pyqir-evaluator does not have a full runtime environment and thus does not have a definition for __quantum__rt__string_create. We should also make better error messages as noted in #122 . We have another PR that is adding multiple LLVM version support (if manually building) and will be changing the default version to 13 after that PR is merged.

@chemix-lunacy I'm going to close this issue for now and use #122 to track a fix.


[Sema] Have operator diagnostics get types from solutions where those exprs have no fixes.

diagnoseOperatorAmbiguity() was previously only looking at the first solution in the set, and thus in the reported issue there was a fix being applied to the LHS in that solution and so the type of the LHS expression was forced to be wrong.
The code now looks through all solutions, and pulls type info from the LHS and RHS expressions only if there isn't a fix anchored to that expression. This resolves the reported issue.
It also lets us skip reporting any diagnostic at all from here if all of the possible solutions contain fixes for one or the other of the args. See the rest of the test expected-error changes, which are all places where the operator ambiguity diagnostic was applied inappropriately and a more targeted diagnostic is already emitted.
Fixes #73029

@swift-ci Please smoke test.

Apologies! Missed a test file with expected-error changes.
@swift-ci Please smoke test.

@xedin @hborla A couple years ago when I was more active in the project, I'd just merge this, as it seems to me to be obviously correct. But it's been awhile, my judgement is fallible, and I'm not sure how much I ought to use the commit permission that I have.
So, since this has been waiting on review for a few weeks (before and during WWDC, granted!), I'll take the opportunity to ask for feedback: Should I be more patient, or explicitly ping one of you to ask for review after awhile, or go ahead and merge? Thanks!

It’s in my queue and I am going to the PRs and issues daily. We are trying to get PRs reviewed before merging, thank you for all the work!

You might have noticed that we have reviewers assigned automatically now based on code owners and we are working on updating contributor guidelines too.

I appreciate it! I just wasn't sure what the guidelines are like these days. :)

No worries!


Factory: enable template feature for arm64

Template: enable template for arm64

Now, template feature can't work on arm64. When using bypass-shared-memory
cap to saving sandbox as a template, new sandbox cloning from the template
will fail. From initial investigation, it maybe a qemu issue. Further
research should be done.
To enable template on arm64, this patch adds a switch to offer the capability
to open or close the bypass-shared-memory cap.
While closing bypass-shared-memory cap, saving vm will occupy more space
and consume more time. So increase 300M for mount size and bump the time
waiting for migration to 10 seconds.

Fixes: #1336

Signed-off-by: Jianyong Wu<EMAIL_ADDRESS>
@jodh-intel @grahamwhaley  @bergwolf  @Pennyzct

/test

Ping @kata-containers/runtime - review required over here y'all! ;)

/test

@jongwu Agree with @bergwolf here. It would make sense to have an architecture specific implementation for
ExecSetMigrationCaps. You would need to open a PR in this repo https://github.com/intel/govmm for that.

@amshinde thanks, I agree with @bergwolf , so I just issue an identical workaround for it, maybe an easier way. also I can fellow @bergwolf , but I assume that it is not necessary  to open a PR in https://github.com/intel/govmm, for we can fix it here.

@jongwu - if you need to modify govmm files (below vendor/), then yes, you do need to raise a PR on the govmm project. But if you can resolve the issue without modifying govmm files, you can just use this PR - see https://github.com/kata-containers/community/blob/master/VENDORING.md and https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#re-vendor-prs.
Let us know when this PR is ready to re-review.

@jongwu I will mark this as wip till the PR to govmm is submitted  and merged. Let us know when this PR is ready.

Hi @markdryan - is ^ something you might be able to help @jongwu with?

@jodh-intel Sure, but first could some clearly spell out what is required, either in this issue or in a new govmm issue?
Do you just want a version of ExecSetMigrationCaps that does nothing on arm?  What about ExecSetMigrateArguments?  What is the underlying reason for this?  Are these QMP methods not supported on ARM versions of QEMU?

@jodh-intel @markdryan thanks, we need an arm64 version of ExecSetMigrationCaps which just return nil. nothing should be done for ExecSetMigrateArguments. in additional, some copys of the normal implementation of ExecSetMigrationCaps  for other archs like amd64, ppc, should be added.
we need that PR because bypass-shared-memory caps does not support on arm64 in kata-runtime for now. so we need disable ExecSetMigrationCaps for arm64.

@jongwu Thanks for the clarification.  However, I'm not sure disabling ExecSetMigrationCaps on ARM is the correct thing to do.  If I understand correctly, the function itself should work on ARM but one of the capabilities kata is passing to this function is not supported on ARM.  Is that the case?
If so we can't really disable ExecSetMigrationCaps in govmm.  Another project may want to use GoVMM on ARM to set a migration capability that was supported.
I note that there does seem to be a QMP function called query-migrate-capabilities.  We could add a method for that which kata could call and then only pass "bypass-shared-memory" if it is supported.  Would that work?

@markdryan yeah, that's really the case. maybe disabling ExecSetMigrationCaps for arm64 doesn't make sense. @amshinde @bergwolf any comments?
howerver bypass-shared-memory caps is supported by qemu on arm64 now. running vm will go into failure if it cloning from a template vm which using bypass-shared-memory in migration.  That's the point. so query-migrate-capabilities would not help.

@jongwu I see.  That is unfortunate.   I don't know the kata code base but looking at where ExecSetMigrationCaps is called, could we not achieve what we want by ensuring BootToBeTemplate is never set to true on ARM or do you want the code in setupTemplate to run, even though ultimately, the caps should not be set.

The other thing we could do would be to provide an ARM version of ExecSetMigrationCaps in govmm that returns a specific error if " bypass-shared-memory" is passed as a parameter.  Then kata could could detect this error and ignore it.  The thing that worries me about this solution is that, just from looking at the code, it seems to me that the BootToBeTemplate functionality would still be half enabled as the code in setupTemplate would still run.

@markdryan don't worry. template can be enabled for arm64 just by disable bypass-shared-memroy cap when create the template. if saving vm as a template without using bypass-shared-memory, running vm cloning from it will start successfully. so if we can implement a version of ExecSetMigrationCaps returning nil when detect bypass-shared-memory, it will do what we want.

so if we can implement a version of ExecSetMigrationCaps returning nil when detect bypass-shared-memory, it will do what we want.

We could do this but it would be a bit misleading.  Someone call could call ExecSetMigrationCaps with "bypass-shared-memory" have the function return nil and reasonably expect that the capability had been set, when in fact nothing had happened.  If we're going to do this we need to return an error to correctly signal that the parameter was not set.  This specific error could be trapped in kata and ignored.
BTW is there any bug open in qemu related to "bypass-shared-memory" and ARM we could reference when we make the change?

@markdryan it sounds great that the error can trap into kata and be ignored. but how can this error trapped into kata  be ignored?
there is no issue related bypass-shared-memory proposed to qemu community for now. but you can reference it freely.

Something like
	err = q.qmpMonitorCh.qmp.ExecSetMigrationCaps(q.qmpMonitorCh.ctx, []map[string]interface{}{
			{				{
				"capability": qmpCapMigrationBypassSharedMemory,					"capability": qmpCapMigrationBypassSharedMemory,
				"state":      true,					"state":      true,
			},				},
		})			})
		if err != nil && err != qemu.Unsupported {

or something like that.

@markdryan yeah, I see. however I'm not sure about if this  additional check can be accept in kata.

@amshinde, @bergwolf, @jodh-intel Would this solution work for you, i.e., returning a specific error on ARM if "bypass-shared-memory" is passed to ExecSetMigrationCaps?  We can't disable the function entirely on ARM and we can't do nothing and return nil either, so this is the only option I can see for a govmm based fix.

@markdryan yeah, it makes sense to return an error from govmm. However, I was actually thinking of adding a new function in the qemuArch interface and then qemu.go has something like:
       if q.config.BootToBeTemplate {
                err = q.arch.setBypassSharedMemoryMigrationCaps()
                if err != nil {
                        q.Logger().WithError(err).Error("set migration bypass shared memory")
                        return err
                }
        }

Then arm64 can just return nil doing nothing in setBypassSharedMemoryMigrationCaps until this is actually fixed in qemu. Other arch can use the default qemu_arch_base version implementing the original qmp action.
wdyt?

@bergwolf Okay, that sounds good to me.  If I understand correctly this wouldn't actually require any modifications to govmm at all.  The knowledge about bypassing migration caps not working on ARM would be coded into kata rather in govmm.  Is that correct?  I didn't realise that there was already an architectural abstraction in kata, but seeing as there is, I agree that this seems like a good place to make the fix.

@markdryan yes, you are right. It doesn't need any govmm modification.

@amshinde @bergwolf @jodh-intel follow workaround from @bergwolf . Add setBypassSharedMemoryMigrationCaps to enable bypass-shared-memory cap for no-arm arch and return nil for arm64 only.

@amshinde any comments?

/test

Error Trace:	linters_test.go:34
linters_test.go:138
linters_test.go:54
Error:      	Received unexpected error:
			            	unmatched errors
			            	2019/03/23 06:52:27 unknown architecture wasm

@jodh-intel @amshinde I'm confused with these lots of similar odd failures.  what should I do?

The travis-ci cannot pass until https://github.com/kata-containers/runtime/pull/1372 get merged.

@teawater thanks, does it means that this commit won't merge before #1372?

@teawater thanks, does it means that this commit won't merge before #1372?

Looks new policy is that.  We can do test first.

/test

@teawater @jongwu ping. Any updates? Thx!

@teawater @jongwu ping. Any updates? Thx!

#1372 is still not merged.  And looks most of test failed.

The issue is with k8s tests and there is a workaround in place that fuentess is working on. I can rekick #1372 as soon as that workaround lands.

continuous-integration/travis-ci/pr still try to use go 1.10 but  #1372 changed it to go1.11 to handle the issue.
Is there any way to let travis-ci change to use 1.11 except re-push the code?

/retest

/retest

@jodh-intel  @bergwolf why travis-ci can't pass?

Hi @jongwu - it has hit a strange compilation (link) error - I think we have seen this on another PR, and I'm not sure it is because of your changes. @jodh-intel @sboeuf @chavafg - is this something we have tried to diagnose yet?:
# github.com/kata-containers/runtime/cli/containerd-shim-kata-v2
/home/travis/.gimme/versions/go1.11.7.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-053240943/000010.o: unrecognized relocation (0x2a) in section `.text'
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status

@grahamwhaley thx.

ARM CI is not happy
level=error msg="Create new sandbox failed" error="QEMU path (/tmp/vc-tmp-578885730/hypervisor) does not exist" sandbox=7f49d00d-1995-4156-8c79-5f5ab24ce138 sandboxid=7f49d00d-1995-4156-8c79-5f5ab24ce138 source=virtcontainers subsystem=sandbox

@Pennyzct can we merge this either way?

Hi~ @devimc I will /retest to see if it's repeatable. ;)

@Pennyzct same error

@devimc thanks. I will check if it's related. ;)

@devimc @Pennyzct help retest.

/test

ARM gut stuck at build triggered on github, need a new retests.
@GabyCT could you trigger a rebuild just for arm?
Also in Fedora got this error: Looks like is a non stable test I've seen with a few times
@devimc @chavafg @grahamwhaley
• Failure [21.767 seconds]
state
/tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/tests/functional/state_test.go:26
  container
  /tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table.go:92
    with workload [true], timeWait 5 [It]
    /tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:46

    Expected
        <int>: 1
    to equal
        <int>: 0

    /tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/tests/functional/state_test.go:45
------------------------------

Summarizing 1 Failure:

[Fail] state container [It] with workload [true], timeWait 5
/tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/tests/functional/state_test.go:45

Ran 8 of 8 Specs in 24.580 seconds

That second fail @jcvenegas looks like the one I'm seeing over on https://github.com/kata-containers/packaging/pull/314 I think...

@jcvenegas it looks like it is already running

@devimc what's next?

@jongwu thanks


Add logging for terminal process input/onData

Part of #140060

won't this be super noisy?
since the issue we're interested in investigating with this is windows and remote, could we add a conditional so as not to do this for other setups?

It will be but it's only on trace which is the noisiest log level, this won't show up when debug logging which I've been using more recently or escape sequence logging.


Not load new entity

I have the following problem:
When I try to create a document [the document has a receiver associated], you must load the list of receivers, as the image shows.

There loads the receivers that were created in the database.
After that step: I try to insert a receiver into the database [using an sql statement, directly inserting the receiver]

When I refresh the page and try to create a document, with the new receiver, does not appear in the list of possible receivers.

I have removed the "TwoLevelCached" attribute from the "DocumentRow" entity, but it also does not load the new inserted element until I restart the internet information service [iis]
I show a summary of the classes involved:
[ConnectionKey("Default"), DisplayName("Documento"), InstanceName("Documento")]
[ReadPermission(PermissionKeys.DocumentoReadOnly)]
[ModifyPermission(PermissionKeys.Documento)]
public sealed class DocumentoRow : Row, IIdRow, INameRow
{
[DisplayName("Receptor"), NotNull, ForeignKey("[dbo].[Receptor]", "Id"),
LeftJoin("receptor"),
TextualField("RazonSocialReceptopr")]
public int? IdReceptor
{
get { return Fields.IdReceptor[this]; }
set { Fields.IdReceptor[this] = value; }
}
}
[FormScript("Factura.Documento")]
[BasedOnRow(typeof(DocumentoRow))]
public class DocumentoForm
{
[LookupEditor(typeof(ReceptorLookup))]
public int IdReceptor { get; set; }
}
[LookupScript("Catalogo.Receptor")]
public class ReceptorLookup : RowLookupScript
{
public ReceptorLookup()
{
IdField = ReceptorRow.Fields.Id.PropertyName;
TextField = ReceptorRow.Fields.RazonSocial.PropertyName;
}
    protected override void PrepareQuery(SqlQuery query)
    {
        base.PrepareQuery(query);
        query.Select(ReceptorRow.Fields.Id)
            .Select(ReceptorRow.Fields.Documento)
            .Select(ReceptorRow.Fields.RazonSocial)
            .Select(ReceptorRow.Fields.IdTipoDocReceptor);
    }

    protected override void ApplyOrder(SqlQuery query)
    {
    }
}

Try Q.reloadLookup(someRow.lookupKey);

Also set timeout to negative in LookupScript

Hi @volkanceylan , do you can explaining, do you have any examples?

Please search in prior issues.


fix linebreaks in final html

I see you're limiting line length, probably in your md editor, which isn't a problem for composing regular paragraphs (md compilers usually ignore single linebreaks), but it gets messed up when you have a number list because it creates second paragraphs under the first line of the number (ie "1.", "2.", etc) instead of adding to the first line.

thanks!


The thickness of the crop box is too thick

I have been using Android-Image-Cropper for a while.
Recently I found the thickness of the crop box is too thick, so it is sometimes difficult for users to judge whether the pixels on the edge of the border will be cropped.

And this is the image cropping box in Google Photos, which has thinner edges so users can crop photos more precisely.

So I'm wondering if there is any way to achieve a more precise crop box style when using this library, like what Google Photos looks like?
Sincerely.

Have you looked at all of the options in CropImageOptions? borderLineThickness should be what you're looking for.

I found it! Thanks for your prompt reply.


Enable Dark Theme

Hi,
I'm trying to use Daisyui with Svelte. I want the same result as on the DaysiUi website but all the themes have a white background (dark, halloween etc ...) on my app
I follow this tutorial for install tailwindcss and i follow the DaysiUI documentation for DaysiUI
https://dev.to/matebek/simplest-way-to-set-up-svelte-with-tailwind-css-41bn
https://daisyui.com/docs/install
My meta HTML :
<html lang="fr" data-theme="dark">
tailwind.config.js
  module.exports = {   purge: {     enabled: !process.env.ROLLUP_WATCH,     content: ['./public/index.html', './src/**/*.svelte'],     options: {       defaultExtractor: content => [         ...(content.match(/[^<>"'\s]*[^<>"'\s:]/g) || []),         ...(content.match(/(?<=class:)[^=>\/\s]*/g) || []),       ],       safelist: [           /data-theme$/,         ]     },   },   darkMode: false, // or 'media' or 'class'   theme: {     extend: {},   },   variants: {     extend: {},   },   plugins: [     require('daisyui'),   ],   daisyui: {     styled: true,     themes: ['dark'],     resets: true,     utils: true,     logs: true,     rtl: false,   }, }
My result :

On website DaysiUI

I tested this but it also doesn't work:
<div class="container" data-theme="dark">
TY

@jcparant I think you need to add bg-base-100 text-base-content to your root/container element so everything inside, actually use the colors defined by themes.
Reason:
Each theme is just a set of color values that will be added to Tailwind. So just like Tailwind colors (like bg-red-100, bg-blue-500, etc), we can use color utility classes (like bg-base-100, bg-primary, etc)
When we use light theme, it defines that bg-base-100 is a light background
and when we use dark theme, it defines that bg-base-100 is a dark background.
Some components (like card) don't come with a background color be default (so you can set any color to them).
But some components (like btn) must have a color by default.
So, If we want the card to use base color, we have to add bg-base-100 text-base-content to a root/container element or the card itself.
Or if we want card to use primary color, we have to add bg-primary text-primary-content to a root/container element or the card itself.

Please let me know if you have any questions.

Thank you very much for your help, it works!

Could you point to a reference for text-base<-content>.  I can't find it referenced on the site or in a search of the repo.
I see text-base as a font size attribute in tailwind, but I'm not seeing how this is related to the "content" portion of your solution...  just trying to learn from other's issues...

@cwalton Color names are here and we can use them on all utility classes just like any other Tailwind color
.bg-COLOR_NAME
.text-COLOR_NAME
.placeholder-COLOR_NAME
.from-COLOR_NAME
.via-COLOR_NAME
.to-COLOR_NAME
.border-COLOR_NAME
.divide-COLOR_NAME
.ring-COLOR_NAME
.ring-offset-COLOR_NAME

As you can see here we have primary color.
And primary-content is the color of any content (text, border, etc) that should go on a primary color.
Not to be mistaken:
text-base is font size from tailwind but text-base-100, text-base-200, text-base-300 are text colors from DaisyUI
I know it might look confusing but the color name is base-100 and can be used as a CSS text-color. I couldn't find a better name for base color because ...well it's ...the "base color" of a design 😅
I will update docs with more descriptions.

Please let me know if you have any questions.

Thanks, this was a great response.  What was making it confusing is the existing tailwind "text-base" and no description of the *-content classes.
Also, unless I'm missing something (and it might be because I can't find any doc on *-content), in all other cases, the item to decorate comes BEFORE the color and nothing after it accept a scaler (100,200,etc)...  your "text-primary-content" seems inconsistent...   primary is the color but it's smacked in-between two items that we want to decorate.
I'm assuming that you created "-content" and it's really just a convenience to combine certain already existing utility classes such as text and border, etc.  if you are set on keeping it. then it might be more consistent as just content-color-scale.
That said, if "content" is a creation outside of tailwind, it seems to be a bit like tailwind's fill-current mechanism, except 1) you're naming the color as opposed to inheriting it and 2) you're applying it to more than just an svg.  It almost feels like you could just extend fill to serve your purpose--- resulting examples being fill-primary or fill-base.
I hope this makes sense and that I'm not being too presumptive.

@cwalton Actually, -content is not meant to be a utility class or a variant or a postfix. primary-content is a color name (as a whole) and it exists as the perfect color (based on contrast and readability) to be used on a bg-primary.
I thought about other names like primary-foreground or primary-fg or primary-data but primary-content looks better and easier to remember.
I also think it's important to give designers freedom to choose their exact color to use on their design, so I don't want to automatically choose a text-color based on background-color.

Thanks!  Your statement "primary-content is a color name" explained it all - and you should definitely add that to the docs.
The project is fantastic... and thanks for sharing it with the world.


Support for ALTER SCHEMA ... RENAME

Closing as a wontfix: the sqlparser crate used by datafusion doesn't support this statement. We'll have a workaround that involves moving the tables to a new schema and deleting the old one.


PSD with RGB channel 16 or higher can not be correctly parsed

Psd with RGB channel 16 has no children in layers property after the file is parsed. But after I change the RGB channel to be 8, all layers can be found.
Here is my code
var PSDAPP = require("psd"); // var file = "friend.psd"; var file = "sample16.psd"; PSDAPP.open(file).then(function(psd){     var retTree = psd.tree();     console.log(retTree); });
testFiles.zip

Hey @qichaoch. I am at the moment not able to research your issue.
I will do this over the weekend and report what my findings are in this issue thread.

Hey @qichaoch. after a little look in the color.coffee file, You can see that it only converts to 8 bit colors and not 16 bit. I will experiment a little bit to see if i can make it work for 16 bit.
Also, thank you for providing the files, this makes my life a lot easier when testing

PSD.rb has 16-bit support so it shouldn't be too difficult to implement.
--
Ryan LeFevre (@meltingice)
Sr. Software Engineer
HODINKEE

From: Ryan Vlaming<EMAIL_ADDRESS>Sent: Saturday, September 16, 2017 1:35:55 PM
To: meltingice/psd.js
Cc: Subscribed
Subject: Re: [meltingice/psd.js] PSD with RGB channel 16 or higher can not be correctly parsed (#105)
Hey @qichaochhttps://github.com/qichaoch. after a little look in the color.coffeehttps://github.com/meltingice/psd.js/blob/master/lib/psd/color.coffee#L6 file, You can see that it only converts to 8 bit colors and not 16 bit. I will experiment a little bit to see if i can make it work for 16 bit.
Also, thank you for providing the files, this makes my life a lot easier when testing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/meltingice/psd.js/issues/105#issuecomment-329983638, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHtueEBm0crXY5tvdLr3fMuozQEgMRPks5sjAb7gaJpZM4PXI5_.

I will see about making a PR for this tonight.

@fabulousduck What's the status on this? I ran into the same problem today.

Hi, I think I am having the same problem

Any news about this issue ?

Seems like a fix on PR: https://github.com/meltingice/psd.js/pull/175

Any update?

Any update on this?

Can someone patch make a PR for this?


There are no crosswalks

There are no crosswalks in these images:

Yet Google ReCaptcha insist that I'm "not clicking on all the crosswalks"

They just want you to loop over and over and over and over to train their crap. It's a lie and fraud.


Added and implemented new references schema

This PR implements a new approach in the use of references as an additional field in the document. It's use is similar to what we are doing with specs as a list of strings but references will consist in a list of ReferenceDocument object that can store a label and a url. The references object does not sit inside metadata; it seems more appropriate to leave it at the same level of metadata and specs

Failures on the 3.9 build were all from the very-deprecated databroker v0 sqlite backend, Test_AD_hdf5_files.


export via a single object

@sayrer (regarding some comments in #10 and #7) why not put HoganTemplate inside the iife that produces Hogan and include it as part of the return statement?
var Hogan = (function () {
  var HoganTemplate = (function () {
    // ...
  })();

  // in the generate function, use Hogan.Template rather than HoganTemplate so that
  // the template can be replaced

  // ...

  return {
    Template: HoganTemplate,
    // ...
  };
})();

then you only have a single export (Hogan) and don't have the inconsistency of HoganTemplate in the browser and Hogan.Template in node

I think we want to go the other direction, actually, and break up Hogan into two files. It should be possible to isolate Hogan.Template enough that only the lambda features require the Hogan compiler. I think we'll have to go with Hogan.Template everywhere, too.

It's now Hogan.Template everywhere, using a slightly different technique. Thanks for filing!
https://github.com/twitter/hogan.js/commit/f23649fe154ba16ba384b4b463afb9af38778d47


fix: mutating deployment selector on apps-dns

This PR fixes upgrades from KubeCF 2.5 to next.
Error: UPGRADE FAILED: cannot patch "apps-dns" with kind Deployment: Deployment.apps "apps-dns" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"apps-dns", "app.kubernetes.io/instance":"susecf-scf", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"susecf-scf-kubecf", "app.kubernetes.io/version":"0.2.0-1952.g99e5ce80", "helm.sh/chart":"kubecf-0.2.0-1952.g99e5ce80"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

FWIW, we now have standard helper templates for selectors & labels that shouldn't have this issue.  (This is mostly helpful for future changes.)


sign-up page is not accessible (404 error) in development environment

I wanted to create a user for testing purposes in development version. I managed to create a user in previous development version but now it fails in the new version.
I pulled the current source base using git pull. and then ran the docker instances via docker compose -d. I'm able to access to all pages including main page, my resources etc. flawlessly, but now I got the 404 (Page not found error) when I clicked on "Sign up now" button on the main page. I attached the docker instance via docker attach --sig-proxy=false hydroshare_hydroshare_1 to track the error and saw the following message:
[03/Feb/2016 19:55:36] "GET /sign-up/ HTTP/1.1" 404 1577
and the screenshot looks like that:

Thanks...

@ahmetartu - For convenience we've put together a control script for HydroShare since it has many moving parts.
It is the hsctl script in the main hydroshare directory.
$ ./hsctl --help
*** HydroShare Control script ***
usage: ./hsctl loaddb          # loads database specified in hydroshare-config.yaml into running container
usage: ./hsctl managepy [args] # use the arguments in a manage.py [args] call from the hydroshare container
usage: ./hsctl maint_off       # removes maintenance page (only if USE_NGINX = true)
usage: ./hsctl maint_on        # displays maintenance page (only if USE_NGINX = true)
usage: ./hsctl rebuild         # deletes hydroshare container contents only and deploys using exsiting database
usage: ./hsctl rebuild --db    # deletes all database and container contents and deploys from scratch
usage: ./hsctl rebuild_index   # rebuild solr index in a non-interactive way
usage: ./hsctl reset_all       # remove all data, containers and images that were previously deployed
usage: ./hsctl restart         # restarts the hydroshare container without rebuilding
usage: ./hsctl start           # attempts to start all containers
usage: ./hsctl stop            # stops all running containers
usage: ./hsctl update_index    # update solr index in a non-interactive way to be run as a cron job

If you've just installed the code and are running for the first time, or want a fresh start, you'd want to use hsctl rebuild --db.
After that a hsctl rebuild call will rebuild the primary containers but keep your database intact.
A hsctl restart call would simply restart the primary hydroshare container.
Reference

Thanks Michael, I ran the following commands in order:
$ git pull # for fetching the latest code snapshot
$ ./hsctl rebuild
$ ./hsctl restart
$ docker attach --sig-proxy=false hydroshare_hydroshare_1
However, still getting the 404 error when I clicked on "Sign up" button
[04/Feb/2016 20:30:21] "GET /sign-up/ HTTP/1.1" 404 1577
Any further ideas?

Any further ideas?

Use ./hsctl rebuild --db so that the included development database is loaded and populates your base pages.
It also includes a single admin user: user: admin, pass: default

After passing --db option to ./hsctl rebuild, it worked! Thanks Michael...