remove VmWorkJob after adding a nic to a vm

Description
This PR intents to

Fixes: #5541 without regressing #5651

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[x] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

still needs testing @weizhouapache m but can you review?

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1663

PR doesn't seem ready cc @DaanHoogland @weizhouapache @nvazquez @sureshanaparti

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1668

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2525)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2525-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_native_to_native_vpc_migration
Error
32.72
test_migration.py

@blueorangutan test matrix

@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Trillian Build Failed (tid-2529)

Trillian Build Failed (tid-2530)

Trillian Build Failed (tid-2531)

@blueorangutan test matrix

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1673

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

note that travis job 14 is showing regressions. we can't merge this.
it assumes cone in #5541 which should be reverted to get 4.16 out.
cc @div8cn

Trillian test result (tid-2539)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35511 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2539-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_native_to_native_vpc_migration
Error
30.71
test_migration.py

Trillian test result (tid-2541)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29920 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2541-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_native_to_native_vpc_migration
Error
32.45
test_migration.py

Ping any update/news on this @DaanHoogland cc @sureshanaparti @weizhouapache

No @rhtyd , this will need addressing. The original fix caused a regression.

@DaanHoogland can you fix the conflicts. thanks.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1992

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1994

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 1996

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1997

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2031

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2033

@blueorangutan test keepEnv

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2748)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 108361 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2748-kvm-centos7.zip
Smoke tests completed. 60 look OK, 31 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestRVPCSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcRemoteAccessVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestRemoteDiagnostics>:setup
Error
0.00
test_diagnostics.py

ContextSuite context=TestLoadBalance>:setup
Error
0.00
test_loadbalance.py

ContextSuite context=TestVPCRedundancy>:setup
Error
0.00
test_vpc_redundant.py

ContextSuite context=TestPrivateGwACL>:setup
Error
0.00
test_privategw_acl.py

ContextSuite context=TestDeployVirtioSCSIVM>:setup
Error
0.00
test_deploy_virtio_scsi_vm.py

ContextSuite context=TestIsolatedNetworksPasswdServer>:setup
Error
0.00
test_password_server.py

ContextSuite context=TestDeployVMFromISO>:setup
Error
0.00
test_deploy_vm_iso.py

ContextSuite context=TestRouterDHCPHosts>:setup
Error
0.00
test_router_dhcphosts.py

ContextSuite context=TestRouterDHCPOpts>:setup
Error
0.00
test_router_dhcphosts.py

ContextSuite context=TestResetVmOnReboot>:setup
Error
0.00
test_reset_vm_on_reboot.py

ContextSuite context=TestDeployVmWithUserData>:setup
Error
0.00
test_deploy_vm_with_userdata.py

ContextSuite context=TestDeployVmWithVariedPlanners>:setup
Error
0.00
test_deploy_vms_with_varied_deploymentplanners.py

ContextSuite context=TestRAMCPUResourceAccounting>:setup
Error
0.00
test_resource_accounting.py

ContextSuite context=TestPortForwardingRules>:setup
Error
0.00
test_portforwardingrules.py

ContextSuite context=TestDomainsServiceOfferings>:setup
Error
1515.56
test_domain_service_offerings.py

ContextSuite context=TestISOUsage>:setup
Error
0.00
test_usage.py

test_01_template_usage
Error
11.44
test_usage.py

test_01_volume_usage
Error
187.40
test_usage.py

test_list_clusters_metrics
Error
1512.27
test_metrics_api.py

test_list_vms_metrics
Error
0.18
test_metrics_api.py

ContextSuite context=TestRouterDns>:setup
Error
0.00
test_router_dns.py

ContextSuite context=TestRouterDnsService>:setup
Error
0.00
test_router_dnsservice.py

ContextSuite context=TestRouterServices>:setup
Error
0.00
test_routers.py

ContextSuite context=TestIsolatedNetworks>:setup
Error
0.00
test_routers_network_ops.py

ContextSuite context=TestRedundantIsolateNetworks>:setup
Error
0.00
test_routers_network_ops.py

test_01_invalid_upgrade_kubernetes_cluster
Failure
0.01
test_kubernetes_clusters.py

test_02_upgrade_kubernetes_cluster
Failure
0.00
test_kubernetes_clusters.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
0.00
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
0.00
test_kubernetes_clusters.py

test_05_basic_lifecycle_kubernetes_cluster
Failure
0.00
test_kubernetes_clusters.py

test_06_delete_kubernetes_cluster
Failure
0.00
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
0.00
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.00
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.00
test_kubernetes_clusters.py

test_02_native_to_native_vpc_migration
Error
30.70
test_migration.py

test_01_add_delete_kubernetes_supported_version
Error
1802.58
test_kubernetes_supported_versions.py

ContextSuite context=TestCpuCapServiceOfferings>:setup
Error
0.00
test_service_offerings.py

ContextSuite context=TestServiceOfferings>:setup
Error
0.14
test_service_offerings.py

ContextSuite context=TestListIdsParams>:setup
Error
0.00
test_list_ids_parameter.py

test_delete_account
Error
1512.29
test_network.py

test_delete_network_while_vm_on_it
Error
1.15
test_network.py

test_deploy_vm_l2network
Error
1.14
test_network.py

test_l2network_restart
Error
2.21
test_network.py

ContextSuite context=TestPortForwarding>:setup
Error
3.40
test_network.py

ContextSuite context=TestPublicIP>:setup
Error
1.14
test_network.py

test_reboot_router
Failure
0.05
test_network.py

test_releaseIP
Error
0.45
test_network.py

ContextSuite context=TestRouterRules>:setup
Error
0.50
test_network.py

ContextSuite context=TestNetworkACL>:setup
Error
0.00
test_network_acl.py

test_01_nic
Error
178.35
test_nic.py

ContextSuite context=TestSnapshotRootDisk>:setup
Error
0.00
test_snapshots.py

ContextSuite context=TestAdapterTypeForNic>:setup
Error
0.00
test_nic_adapter_type.py

ran one of the failing tests and it passed, now re-running the entire suite.

@blueorangutan test keepEnv

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2762)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31962 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2762-kvm-centos7.zip
Smoke tests completed. 88 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
229.19
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
236.33
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
362.64
test_privategw_acl.py

test_02_native_to_native_vpc_migration
Error
37.18
test_migration.py

test_01_nic
Error
174.09
test_nic.py

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2070

Hi @DaanHoogland is this PR ready?

@sureshanaparti no

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2085

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2092

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2093

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2789)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32681 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2789-kvm-centos7.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
225.22
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
232.23
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
344.70
test_privategw_acl.py

test_02_native_to_native_vpc_migration
Error
38.99
test_migration.py

test_01_nic
Error
175.39
test_nic.py

@sureshanaparti @weizhouapache I finally weeded out the final crinch here, a job was joined twice leading to an SQL exception. It did work but I'll start another test round for both parallel adding and re-adding of a network.
@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2129

fully works for adding in parallel and re-adding. I did notice however that deleting in parallel sometimes doesn't work. We will need to revisit the general area of this functionality again in the future
@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

fully works for adding in parallel and re-adding. I did notice however that deleting in parallel sometimes doesn't work. We will need to revisit the general area of this functionality again in the future @blueorangutan test matrix

great ! @DaanHoogland

@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-2825)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2825-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2828)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2828-kvm-centos7.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestSnapshotRootDisk>:setup
Error
0.00
test_snapshots.py

ContextSuite context=TestRouterIpTablesPolicies>:setup
Error
0.00
test_routers_iptables_default_policy.py

ContextSuite context=TestVPCIpTablesPolicies>:setup
Error
0.00
test_routers_iptables_default_policy.py

ContextSuite context=TestVPCNics>:setup
Error
0.00
test_vpc_router_nics.py

Trillian test result (tid-2824)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34903 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2824-xenserver-71.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_sys_vm_start
Failure
0.12
test_secondary_storage.py

Trillian test result (tid-2829)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34882 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2829-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2826)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36578 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2826-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2827)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37773 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5658-t2827-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Is this ready for merging, or needs testing @DaanHoogland @weizhouapache ?

Is this ready for merging, or needs testing @DaanHoogland @weizhouapache @sureshanaparti ?

I have tested it but I am (co-)author It has my lgtm ;)
I'll add a brief test description.


how to change the color of progress bar?

Currently there is no method to change the progress bar color. But you can always import KProgressHUD into your project and add the method yourself.

Currently there is no method to change the progress bar color. But you can always import KProgressHUD into your project and add the method yourself.

Thanks for your reply. I have change the color after importing it.  Thumbs up.


CMake Error: CMake server mode has been removed in favor of the file-api.

The bazel_ros2_rules CMake scraping code uses the CMake server api - but it's been removed as of CMake 3.20. bazel build //... in drake_ros_core fails with a lot of the same message printed to the console:
CMake Error: CMake server mode has been removed in favor of the file-api.

@IanTheEngineer FYI this will need to be fixed to enable upgrading to Jammy.

Resolved by #150 and #181.


Base64 implementation

Added Base64.Encoder, Base64.Decoder together with fix for bug found in Base64Impl.

I merged the PR, but tests turned out to be broken. Please, run tests before creating PR


'characters' is deprecated: Please use String or Substring directly

Zip.swift, line 151

+1

This should be fixed in 1.1.0. Sorry for the delay.


DEVC: Jump to package not possible - object does not exist

It's not possible to open a package from the object list, error: Object DEVC xxx doesn't exist

Reason:
mv_local_devclass is not set correctly in zcl_abapgit_object_devc->constructor

Works for me. Seems like some kind of special case.

same error for CTS relevant package
PR set obj_name as fallback

also broken here:


Scheduler worker in group main failed with an uncaught exception StackOverflow

We are getting the StackOver flow error and the Mongo Changestream is not triggering for new events with respect to resumetoken after this error has occured.
The project dependencies are as mentioned below:
<java.version>1.8</java.version>
<spring-cloud.version>Finchley.SR1</spring-cloud.version>
<mongodb.version>3.8.0</mongodb.version>
<mongo-driver-reactivestreams.version>1.9.0</mongo-driver-reactivestreams.version>
<spring-data-releasetrain.version>Lovelace-RC2</spring-data-releasetrain.version>
StackTrace:
] ERROR reactor.util.Loggers$Slf4JLogger.error Line #283 [22722e4161855f81] Scheduler worker in group main failed with an uncaught exception java.lang.StackOverflowError: null at java.util.regex.Pattern.sequence(Pattern.java:2132) at java.util.regex.Pattern.expr(Pattern.java:1998) at java.util.regex.Pattern.compile(Pattern.java:1698) at java.util.regex.Pattern.(Pattern.java:1351) at java.util.regex.Pattern.compile(Pattern.java:1028) at java.lang.String.replaceAll(String.java:2223) at reactor.core.Scannable.operatorName(Scannable.java:390) at reactor.core.Scannable.name(Scannable.java:379) at org.springframework.cloud.sleuth.instrument.reactor.ReactorSleuth.scopePassingSpanSubscription(ReactorSleuth.java:157) at org.springframework.cloud.sleuth.instrument.reactor.ReactorSleuth.lambda$null$2(ReactorSleuth.java:128) at reactor.core.publisher.MonoLiftFuseable.subscribe(MonoLiftFuseable.java:46) at reactor.core.publisher.MonoFlatMapMany.subscribe(MonoFlatMapMany.java:49) at reactor.core.publisher.FluxLift.subscribe(FluxLift.java:46) at reactor.core.publisher.FluxOnErrorResume.subscribe(FluxOnErrorResume.java:47) at reactor.core.publisher.FluxLift.subscribe(FluxLift.java:46) at reactor.core.publisher.FluxPeek.subscribe(FluxPeek.java:83) at reactor.core.publisher.FluxLift.subscribe(FluxLift.java:46) at reactor.core.publisher.MonoNext.subscribe(MonoNext.java:40) at reactor.core.publisher.MonoLift.subscribe(MonoLift.java:46) at reactor.core.publisher.MonoPeek.subscribe(MonoPeek.java:71) at reactor.core.publisher.MonoLift.subscribe(MonoLift.java:46) at reactor.core.publisher.MonoPeek.subscribe(MonoPeek.java:71) at reactor.core.publisher.MonoLift.subscribe(MonoLift.java:46) at reactor.core.publisher.Mono.subscribe(Mono.java:3080) at reactor.core.publisher.Mono.subscribeWith(Mono.java:3188) at reactor.core.publisher.Mono.subscribe(Mono.java:2965) at

Is this problem still there with Greenwich?

No. We are using the below version.
<spring-cloud.version>Finchley.SR1</spring-cloud.version>
<spring-data-releasetrain.version>Lovelace-RC2</spring-data-releasetrain.version>

Ok, so please always use the latest versions. If the problem is still there in the latest versions then we can fix it. If it's not then your problem is solved.

Thanks Marc. Will switch to the new version and revert if the issue still exists.


added an alternative single function call interface for vcf clustering; updated README

@martinghunt what do you think?

Looks great! Merging it.


Refactor: templates

Make fn.Template an interface instead of a concrete struct.

@zroubalik @lkingland @salaboy PTAL

@lkingland I addressed some of your comments:
diff: https://github.com/knative-sandbox/kn-plugin-func/compare/99df90558e9412350b0c2c79095320e6915419b4...07c0aa4566085b12372d38df621d8b2471556291

@lkingland please re-LGMT

/lgtm

@zroubalik @salaboy if you don't have objections I'll merge this.


Add url utilities for transaction api endpoints to network package

Is your feature request related to a problem? Please describe.
I was frustrated when I wanted to look up a transaction by it's id via the hosted API and could not find the appropriate endpoint in the network package's url utilties.
Describe the solution you'd like
Add utility function(s) that produce the api route for looking up transactions.
Describe alternatives you've considered
Hard coding these endpoint strings into my own code.

@youfoundron Are these methods enough ? https://hirosystems.github.io/stacks-blockchain-api/client/index.html

This is out of scope for stacks.js, will not be pursuing this


[BUG] Updating a single document fails using the Update API

What is the bug?
A clear and concise description of the bug.
The bug has already been reported on the forums, but creating a bug report on GH for better visibility and tracing.
After successfully indexing (creating) a new document in the index using the neural ingest pipeline, updating the created document with the Update API fails.
This is the error that is returned:
{
    "error": {
        "root_cause": [
            {
                "type": "mapper_parsing_exception",
                "reason": "failed to parse field [Field_vectorized] of type [knn_vector] in document with id '9'. Preview of field's value: 'null'"
            }
        ],
        "type": "mapper_parsing_exception",
        "reason": "failed to parse field [Field_vectorized] of type [knn_vector] in document with id '9'. Preview of field's value: 'null'",
        "caused_by": {
            "type": "illegal_argument_exception",
            "reason": "Vector dimension mismatch. Expected: 384, Given: 768"
        }
    },
    "status": 400
}

How can one reproduce the bug?
Steps to reproduce the behavior.
Complete the Sease neural search plugin tutorial.
Then we can update an existing document like this:
POST http://localhost:9200/<INDEX>/_update/9

With the request body like this:
{ "doc": { "Body":"The New American frontier, also known as the Old West, popularly known as the Wild West, encompasses the geography, history, folklore, and culture associated with the forward wave of American expansion in mainland North America that began with European colonial settlements in the early 17th century and ended with the admission of the last few contiguous western territories as states in 1912. This era of massive migration and settlement was particularly encouraged by President Thomas Jefferson following the Louisiana Purchase, giving rise to the expansionist attitude known as \"Manifest Destiny\" and the historians' \"Frontier Thesis\". The legends, historical events and folklore of the American frontier have embedded themselves into United States culture so much so that the Old West, and the Western genre of media specifically, has become one of the defining periods of American national identity."}}

But it returns the error as shared above.
What is the expected behavior?
A clear and concise description of what you expected to happen.
The expected behavior is that the document gets indexed without errors.
What is your host/environment?
Operating system, version.
MacOS 13.3, but running OpenSearch on Docker with Ubuntu.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
N/A
Do you have any additional context?
Add any other context about the problem.
I am happy to contribute to a solution.

@juntezhang is this similar to this issue: https://github.com/opensearch-project/neural-search/issues/213

It's related, but not the same. We can accept that updates don't work with the ingest pipeline. But doing a single call with the Update API is another case. Now we can only use the Index API, so we have to always send the whole document. Updating by script is not possible then.

@juntezhang This can be a feature gap where the ingest pipeline is not workin on Update API call. I would recommend cutting a github issue to OpenSearch Core repo. https://github.com/opensearch-project/OpenSearch

@juntezhang This can be a feature gap where the ingest pipeline is not workin on Update API call. I would recommend cutting a github issue to OpenSearch Core repo. https://github.com/opensearch-project/OpenSearch

Thanks, then it's good to know this limitation. We have worked around this problem by using the Index API instead for updates, but when it's necessary to use the Update API, because when updating by script, then add the query parameter pipeline=_none to the Update API. This allows you to keep updating docs by script by bypassing the neural search pipeline.

This is a same issue with this: https://github.com/opensearch-project/neural-search/issues/207, and it's already fixed, closing this issue now.


nushell: 0.10.0 -> 0.11.0

Motivation for this change
Release notes: https://www.nushell.sh/blog/2020/03/10/nushell_0_11_0.html
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

nixpkgs-reviewed + ran binaries


ask to share results after scanning

what do you think about after they scan the device the user can be prompted to share their results for research, with a checkbox/option to disable asking in the future.
we could have some info about how the info is shared (via an anonymous google form submission).
related to #6, #59

IMHO, for better user experience and data collection, upon the first run of the app, we can show app's privacy policy and an option to disable collection of anonymous scanning results (opt-out).  By default the app will collect anonymous scanning results.

What happens to the shared data? Is it available publicly? Is there a good source of which phones are patched / able to be patched?

I would recommend the abiloty to convert log to .txt files as txt is the most standard for sharing logs.


Redirecting a SBH instance to an alternate homepage

Would it be possible to add a config to redirect from a new SBHv2/3 instance to a separate homepage?
(e.g. if we want to have a separate landing page to what is the current SBH homepage.)

Closed with #653


Bugsnag doesn't send crash on RCTFatal() call

https://github.com/bugsnag/bugsnag-js/blob/59e4de95790d72ae3a755d8201951f0de30bc6ca/packages/react-native/ios/BugsnagReactNative/BugsnagReactNativePlugin.m#L19
How to reproduce:
[<RCT bridge> enqueueJSCall:<JS Module Name> method:<JS Method Name> args:<JS Method Args> completion:^{
    @throw [NSException exceptionWithName:@"MyException" reason:@"Manual" userInfo:nil];
}];

Exception will be thrown from https://github.com/facebook/react-native/blob/6031e4ab626b7aa57e6ed1bbf266e39220d61adc/React/Base/RCTAssert.m#L146.
I think that the filter in the subject doesn't work properly because in that case JS Exception will not be thrown but the exception will have RCTFatalException name.
P.S.: we faced the issue in our project.
A crash I found in device logs from Xcode:
Last Exception Backtrace:
0   CoreFoundation                         0x1a30d1d78 __exceptionPreprocess + 220
1   libobjc.A.dylib                        0x1bbd36734 objc_exception_throw + 60
2   MyApp                                  0x103c8917c RCTGetFatalHandler + 0
3   MyApp                                  0x103ca0d14 -[RCTCxxBridge handleError:] + 1232148 (RCTCxxBridge.mm:1211)
4   MyApp                                  0x103c9f250 __34-[RCTCxxBridge _initializeBridge:]_block_invoke + 1225296 (RCTCxxBridge.mm:719)
5   MyApp                                  0x103cb4724 facebook::react::RCTMessageThread::tryFunc(std::__1::function<void ()> const&) + 56
6   MyApp                                  0x103cb44b8 invocation function for block in facebook::react::RCTMessageThread::runAsync(std::__1::function<void ()>) + 1311928 (RCTMessageThread.mm:45)
7   CoreFoundation                         0x1a30ab0e4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 28
8   CoreFoundation                         0x1a30ac040 __CFRunLoopDoBlocks + 412
9   CoreFoundation                         0x1a3043ec8 __CFRunLoopRun + 1720
10  CoreFoundation                         0x1a30576b8 CFRunLoopRunSpecific + 600
11  MyApp                                  0x103c9c9b4 +[RCTCxxBridge runRunLoop] + 1214900 (RCTCxxBridge.mm:367)
12  Foundation                             0x1a488e55c __NSThread__start__ + 808
13  libsystem_pthread.dylib                0x21405a9ac _pthread_start + 148
14  libsystem_pthread.dylib                0x214059e68 thread_start + 8

RN wraps exception to own one.

Hi @RishatShamsutdinov - a fix for this was released in v7.16.4 of bugsnag-js 🎉  Thanks again for reporting this!


Use Docker Compose

Use Docker Compose rather than Docker run, allowing for easier future extensions
Swap to Debian for up to date docker packages

Also swap to London region


Supply API: POST API calls where the item has to be searched, returns "invalid address", if only the name is provided.

The supply API POST calls, where the node has to search for the particular item to carry out the operation like update / transfer give the error "invalid address" when searched with only the name.
Tried with name using the username:itemname format and also using only itemname, both do not work. If the address is provided then it works perfectly.
The API Call:

This is the error message received:

This issue is resolved with commit 5c9035733293a675caeb24fbe0625e937774ca18


Deploy OCI loadbalancer for Istio

Deploy a second load balancer that points at Istio NodePorts
Outputs IP addresses of both loadbalancers, this could be extended to a new feature where DNS records are automatically modified.
Resolves #12

There is a healthcheck for Istio but it's not on a stable port (15020 /healthz/ready) so leaving as TCP healthcheck on the HTTP port. Note that istio-ingressgateway will not start responding to queries until a Gateway object is defined in Kubernetes

Are you also deploying the istio module as part of this or you are just preparing the networking?

Are you also deploying the istio module as part of this or you are just preparing the networking?

Just creating the OCI load balancer to point to the correct NodePorts

Are you also deploying the istio module as part of this or you are just preparing the networking?

Just creating the OCI load balancer to point to the correct NodePorts

In that case, we should also add a variable that controls its creation i.e. it will only be created if Istio is installed

In that case, we should also add a variable that controls its creation i.e. it will only be created if Istio is installed

Any suggestions on how it should be done? I can't do something like count = var.deploy_istio_loadbalancer ? 1 : 0 as it has non-instance based references.

This update is now too old compared to the updated code we bring from internal OCNE terraform repository.


Broken link

Broken link for General --> Configure Email Notifications
https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/configure-email-notifications?view=o365-worldwide

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 81812335-239a-b679-b94d-4edc51881fc9
Version Independent ID: ff002d4e-5cf0-258f-cb80-1d5e09ff394a
Content: Configure general Defender for Endpoint settings
Content Source: microsoft-365/security/defender-endpoint/preferences-setup.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@gb5757870 Thank you for your feedback. Configuration of vulnerability email notifications can be found at https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/configure-vulnerability-email-notifications?view=o365-worldwide
There are no changes required in the said document
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @gb5757870 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Issue is not fixed.
On this page: https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/preferences-setup?view=o365-worldwide
General --> "Configure Alert Notifications" link takes to a page with 404 errors

@msbemba

@gb5757870 I don't see General --> "Configure Alert Notifications" link on this page https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/preferences-setup?view=o365-worldwide
Could you share a screenshot of the page with that option?
Thanks
Sri

Hi, here is the screenshot
[image: image.png]
On Sun, 19 Feb 2023 at 16:58, Sriraman M S @.***> wrote:

@gb5757870 https://github.com/gb5757870 I don't see General -->
"Configure Alert Notifications" link on this page
https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/preferences-setup?view=o365-worldwide
Could you share a screenshot of the page with that option?
Thanks
Sri
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/11009#issuecomment-1434735389,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJD4NVII6JZGQDZLCHT63TWX6EHTANCNFSM6AAAAAAU4MJCOE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@msbemba

@gb5757870 I see the 404 error, but how did you get to the broken link? Is the link mentioned anywhere on this or any other page page - https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/preferences-setup?view=o365-worldwide ?
Thanks
Sri

@msbemba See the highlighted place which takes me to the broken link.

@gb5757870 Thank you for your feedback. We have emailed the author to fix the broken link.
@yogkumgit  Email sent 2.24.2023
Thanks
Sri

Fixes checked in. Updates should be reflected soon.


364/submit profile image

Dev Summary

Standardize CTA buttons per our design docs
Use new standard CTA buttons
Make step four form use form input element
New profile type
Update user profile after register (this won't fully work until we fix out email verification)

Test Plan

repro steps:

go to signup-citizen
fill out the form, add an image in the upload part of the 4th step. Expect to see validation on extension and file size
watch the network call
For now, this causes an unauthorized response because the user hasn't yet confirmed their email

Resources

hi @esteban-gs, one thing I noticed is that when first choosing an invalid image format, we get the error message displayed, which is great, but this message continues to be displayed even if subsequent selection for image is valid.  Also, maybe this can be a follow-up ticket, but once a valid image is selected, maybe it'd be nice to show it instead of the default image for profile.


Enable CI testing of helm chart

Currently the helm chart is not tested in CI, so ensuring it is current with changes in master is a manual process.  As a starting point, a new test run could be added that tears down the most recent script-deployed control plane, deploys with helm, and runs the e2e tests.  Eventually the helm chart could replace the script-based deployment entirely when it proves reliable.

This was fixed by #525


read_parquet_metadata fails on Columns with only NULLS

Each table location on S3 has multiple files. The schema is consistent through out all of these files. However, in some files, the Columns may be NULL, due to the nature of the data. When one of these files are picked up in the Sampling of read_parquet_metadata, it results in a "awswrangler.exceptions.UndetectedType: We can not infer the data type from an entire null object column" exception.
I feel this is something that can be overcome by introducing an override data type. So if it cannot infer the data type, it uses the value from the override parameter.
P.S. this library has changed my life!

Thanks @xtrearer for the feedback! Glad you're enjoying the library.
I've created a PR with a small fix that would let you override types with dtype:
wr.s3.read_parquet(path)
Out[2]:
   c0    c1
0   0  None
1   1  None
2   2  None

wr.s3.read_parquet_metadata(path, dtype={'c1': 'bigint'})
Out[3]: ({'c0': 'bigint', 'c1': 'bigint'}, None)

You can install and try it out via:
pip uninstall awswrangler -y
pip install git+https://github.com/awslabs/aws-data-wrangler.git@feat-override-nulls

However, can you elaborate a bit more your use case? What are you doing with the schema after you've read it?

Hi!
Thank you for the reply!
I've made the pull and read your response, and this is not exactly what I was looking for. So yes, let me give some context on the Use Case as well as why this current solution will not work.
Use Case:
AWS Glue Crawler has failed me for the last time and I basically went, "fine, I'll do it myself". So I wrote a Lambda based alternative that can crawl my Data Lake, looking for any new Partitions and or Schema changes, and taking the required actions.  It works REALLY well. In order to achieve the Schema part, I needed to be able to do 1 of 2 things: 1.) Read the metadata from the Parquet files, or 2.) Read the Parquet files themselves into a Dataframe.
I wanted to avoid option 2.) as it would be memory intensive on a Lambda and run longer, making this more expensive than it needs to be. Option 1.) was perfect - low memory usage and faster run times. In my lake, some of the event data streams have fields that are optional. So it sometimes occurs that one entire Parquet file would have that column as NULL. My Custom Crawler takes X amount of Sample Paths to determine the Schema. In my tests, it sometimes grabbed files where these Columns are all NULL. This causes the Exception I mentioned.
To summarize, the Custom Crawler creates its version of the Schema by reading the metadata from the actual Parquet files. This means that the Custom Crawler does not know which columns exists before reading the metadata. So the solution you have provided - while it does work - will not work for my application, as it depends on API call knowing which Columns exist prior to reading the metadata.
So the function would need to offer some override functionality that is blind to the Columns. For consistency, updating the "dtype" parameter to function like it does on the "read_csv" function could sort of work, i.e. input of "dtype=str" would force all columns retrieved to be of type "string". However, this will cause other issues and does not satisfy the requirement of simply overriding certain columns if their dtype is NULL.
So ultimately having some form of parameter that only triggers IF the column dtype could not be confirmed would probably be best. So either make it default behavior, which leads to lots of regression testing I guess, or make a new parameter that only triggers when a column dtype is NULL, something like dtype_na?
Hope this helps to make sense out of it and thanks again for spending time on this!
Cheers,
Leo

The issue I see with overriding dtype for columns with NULL is that you might have multiple columns with different types containing NULLs and with that solution you would force them to the same type when they are not. You can see this would work in a very narrow range of use cases. Is that assumption true for your case?

That is true, I agree... is it perhaps then possible to not have the code
fail and just have the response contain NULLs for the columns where the
data type could not be determined? That way it becomes the end users task
to deal with NULL data types in whatever way they see fit.
Your thoughts?
On Thu, 06 Jan 2022, 15:09 kukushking, @.***> wrote:

The issue I see with overriding dtype for columns with NULL is that you
might have multiple columns with different types containing NULLs and
with that solution you would force them to the same type when they are not.
You can see this would work in a very narrow range of use cases. Is that
assumption true for your case?
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-data-wrangler/issues/1082#issuecomment-1006578698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APJZA65UP7LFGD6NZWFP7P3UUWIBZANCNFSM5KSGMEFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


Can not Add Notes to a Highlight

Issue - Hi, I tried this new version and I wonder that I can not add notes to a highlight at this version. Did I miss something ?
FolioReader version -  0.4.3
FolioReader Stock / Modified -
Android SDK -
Mobile / Tablet / Emulator Info -
Crash / Error -
Steps to reproduce / Describe in detail -

My pardon, simply my mistake


How to capture the access token from an external provider, for subsequent use with that provider's API

We are integrating with a number of external providers, such as Twitter, Facebook, & Google.   Beyond simply using those providers to authenticate, we need to be able to access the providers' APIs to do things on the authenticated user's behalf.  In order to do this, we need to capture the access token issued by these providers during the authentication sequence.   How is this done?

How is this done?

No differently than if you were not using identityServer.
This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


error

hi guys,
i got this error. can anyone help me?
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/2.7/bin/ptc", line 9, in
load_entry_point('PTCAccount==1.2.1', 'console_scripts', 'ptc')()
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ptcaccount/console.py", line 45, in entry
args.username, args.password, args.email, args.email_tag
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ptcaccount/accountcreator.py", line 379, in random_account
try_username, password, try_email
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ptcaccount/accountcreator.py", line 226, in create_account
resp_code=200
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/ptcaccount/accountcreator.py", line 88, in request
raise PTCInvalidStatusCodeException(str(resp.status_code))
ptcaccount.ptcexceptions.PTCInvalidStatusCodeException: 500

Same issue, script was working 6 hours ago, no changes on my end since then. Other scripts are also returning errors, I'm thinking PTC is blocking requests, but who knows. Waiting patiently.

I tweaked the exception to print the content and pulled this out of it:

With the exciting launch of Pokémon GO, there’s an overwhelming demand for access to Pokémon Trainer Club accounts, including new accounts, profile changes, and password/username retrieval. Our team is hard at work improving support for these features. Until the work is complete, for a brief time, we’ll be limiting the amount of access to these features. Please refresh your browser and try again.


Fix #115

First draft for fixing #115.
I'll add/fix tests and documentation as soon as the general idea has been approved.

As discussed, this needs to be handled elsewhere which I believe you've done.


amplify init not asking "Do you want to use an existing environment?"

Amplify CLI version: 4.13.1
In brief, I'm trying to provision an existing backend (react app) to a new react native app.
Following the docs here, I've performed steps 1-3 to add the env to a local project (on a different machine from where the site was initially built).
In step 3 (the second one, as there are 2 of them), its shows a prompt: Do you want to use an existing environment? Yes.
This prompt does not show.  Instead, the prompts are:
? Enter a name for the project
? Enter a name for the environment
? Choose your default editor: (Use arrow keys)

Did I miss a step, have I lost the plot, or have things changed since this doc was written?
Thanks

A bit late but I just faced the same problem. When you go to your app console, you'll see in the backend environments panels the command to init from the current appId
$ amplify init --appId YOUR_APP_ID


Add support for array_function protocol

Resolves #4563.

[ ] Tests added / passed
[ ] Passes flake8 dask

cc @shoyer @hameerabbasi

Ok, I'm not really sure why that's failing only on newer Python/NumPy versions. Anybody sees something obvious I've missed?

NumPy 1.13 and 1.11 didn't have this protocol... So what you added was essentially dead code then.

I'm surprised to see tests with sparse and cupy in this PR.  From my perspective this is more about having Dask Arrays respond to NumPy functions, rather than having the blocks of a Dask array respond to NumPy functions.
So I would be more interested in checks like the following:
x = da.ones(...)
y = np.concatenate([x, x, x])
assert isinstance(y, da.Array)

Where we would also want to check things like np.linalg.qr (which you ran into with cupy) and any others that we know are sometimes problematic.

NumPy 1.13 and 1.11 didn't have this protocol... So what you added was essentially dead code then.

Oh yes, that makes sense. I've been testing with upstream NumPy, that's why it passed here.

@mrocklin it's good that you mention that, I've totally forgotten about that case. But either way, are you suggesting we drop Sparse and CuPy tests? I understand it may be a little early to have them properly setup due to different version requirements, but ultimately, isn't that what we want, to have Dask working also with other arrays?

We do want those to work, yes, but I think that that effort is somewhat orthogonal from the solution you've added here.
Or, in testing terms, you've got some great integration tests here, it would be good to see some unit tests as well that just test dask array's support of the __array_function__ protocol with normal NumPy arrays.

Ok, so here's my suggestion, I will add the tests you suggested (which I really forgot before), and skip the tests we currently have if NumPy < 1.17, does that sound acceptable?

Sure.  More tests are always great (assuming they're decently fast)
On Fri, Mar 8, 2019 at 11:51 AM Peter Andreas Entschev <
<EMAIL_ADDRESS>wrote:

Ok, so here's my suggestion, I will add the tests you suggested (which I
really forgot before), and skip the tests we currently have if NumPy <
1.17, does that sound acceptable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/4567#issuecomment-471054678, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszPhczbZ13URRnlpNqoNeYL8lLmNFks5vUr9AgaJpZM4bl0pH
.

Sure. More tests are always great (assuming they're decently fast)

Agreed, the current ones were tweaked to be fast, I didn't profile them exactly, but all 3 tests were certainly < 1 sec.

Ah, now I realized why the tests are failing, before 1.17 (currently, upstream), we have to set the environment variable NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1.
So the question here is, can we enabled that in CI for newer versions of Python? Otherwise, I think the only alternative is to skip these tests until v1.17 is released.

I think that enabling that is fine
On Fri, Mar 8, 2019 at 12:10 PM Peter Andreas Entschev <
<EMAIL_ADDRESS>wrote:

Ah, now I realized why the tests are failing, before 1.17 (currently,
upstream), we have to set the environment variable
NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1.
So the question here is, can we enabled that in CI for newer versions of
Python? Otherwise, I think the only alternative is to skip these tests
until v1.17 is released.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/4567#issuecomment-471060807, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszHKr2YQbaO8EN5x5O-0oUo-bz46Dks5vUsOngaJpZM4bl0pH
.

Alright, I added some __array_function__ unit tests, it's by no means an extensive list, but probably a good starting point for us.
Regarding the NumPy version, we need at least v1.16 (now skipped for older versions) and NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1 variable exported, which I now added. Is it possible for us to test also with NumPy v1.16.x?

Regarding the NumPy version, we need at least v1.16 (now skipped for older versions) and NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1 variable exported, which I now added. Is it possible for us to test also with NumPy v1.16.x?

You need to add that for 1.16, where it was experimental. For 1.17, though, the env var isn't needed currently, but people are proposing that we keep the "experimental" status of the NEP for one more version...

You need to add that for 1.16, where it was experimental. For 1.17, though, the env var isn't needed currently, but people are proposing that we keep the "experimental" status of the NEP for one more version...

While I agree that features should be experimental until they can really be considered stable, I was really expecting that v1.17 would introduce this feature as stable. Without that, it's difficult to even get other projects to even run unit tests for it, e.g., CuPy. I'm totally willing to help improving everything we can to attempt having this in v1.17 as stable, are there many major concerns about its maturity?

are there many major concerns about its maturity?

CuPy has been using it for a while (as short as whiles go)... So I think not. There might be features added but not removed.

One thing I must mention I like about this implementation is that it specifically avoids a NumPy dependency or mapping.

Hmm, I just noticed that the reduction tests test_topk_argtopk* fail due to the lack of a sort() implementation in Dask. This turns us back again to the discussion in https://github.com/numpy/numpy/issues/12974. While we can easily fix those (or hack those to work, depending on how one look at the problem) by simply forcing a fallback of the arrays to NumPy before calling np.sort()and np.argsort() (the results are only used as baselines), maybe it would be also interesting to have a closure on that NumPy discussion to have soon a more robust solution?

Oh, there's more in ufunc tests. It fails specifically for i0, nan_to_num and sinc, which are being tested in test_unary_ufunc. However, those 3 functions are defined just after the following comment in ufunc.py: "non-ufunc elementwise functions".
It seems to me that these 3 functions are being tested in test_unary_ufunc by mistake, is my assumption correct?

I'm willing to author a revision to the NEP. I'd love feedback from the community!

However, the proper fix would not be to "coerce" to NumPy as that'd break sort everywhere except NumPy arrays. What I suggest instead is to "exctract" the underlying array (call .compute()) and run np.sort on that. That should be the default implementation in Dask.

However, the proper fix would not be to "coerce" to NumPy as that'd break sort everywhere except NumPy arrays. What I suggest instead is to "exctract" the underlying array (call .compute()) and run np.sort on that. That should be the default implementation in Dask.

I see what you mean about coercing. However, I'll have to disagree with you if by "default implementation" you mean Dask implementing sort() as a sort of wrapper to np.sort(), in that case, it would give the impression to users that Dask really implements it, when the following is documented:

Operations like sort which are notoriously difficult to do in parallel, and are of somewhat diminished value on very large data (you rarely actually need a full sort). Often we include parallel-friendly alternatives like topk

Since in this PR we only need np.sort() for a test case, I'd rather call .compute() on the array in that test to simulate the behavior you suggested.

Then, if the "default behaviour" inside Dask is to coerce instead of error, we'd need some kind of reverse dispatcher in general, or the np.NotImplementedButCoercible sentinel mentioned in the NEP. Another reason to have one. :slightly_smiling_face:

Then, if the "default behaviour" inside Dask is to coerce instead of error, we'd need some kind of reverse dispatcher in general, or the np.NotImplementedButCoercible sentinel mentioned in the NEP. Another reason to have one. 🙂

You're absolutely right. Just for the sake of clarity, my initial thought was one of the following:

Automatically coerces if undocumented; or
Documents that there's no Dask implementation, but coerces depending on the input.

For the scope of this PR, I only wanted to avoid that we add a deceptive implementation.

Oh, there's more in ufunc tests. It fails specifically for i0, nan_to_num and sinc, which are being tested in test_unary_ufunc. However, those 3 functions are defined just after the following comment in ufunc.py: "non-ufunc elementwise functions".

I fixed this issue in my latest commit. If anyone thinks this is wrong, please let me know.
I would say this is ready for another round of review now.

I fixed this issue in my latest commit. If anyone thinks this is wrong, please let me know.

That looks correct to me, @pentschev. Those are not really ufuncs, but they happened to more or less work for the purposes of the original tests. So it is more correct to test them separately. Thanks for correcting these.

@jakirkham thanks for the review!

I think that with @shoyer 's statements below we can drop this conditional entirely. It should always pass

The array_function protocol guarantees that it will only get called if dask.array.Array is in types. So if that's all you wanted to check, you could drop this entirely.

I think I've left this for a reason, I can't remember for sure. But I think it was in the case of having arrays of different types. Wouldn't it if one array was a Dask array and another a CuPy one, for example?

Currently the code is
        if not any(issubclass(t, (Array, np.ndarray)) for t in types):
            return NotImplemented

But we know that any(issubclass(t, Array) for t in types) is true.  If it wasn't then we wouldn't be in this function.

@mrocklin I'm confused, you're saying now we should get rid of the entire condition or just of Array and keep np.ndarray?

I'm saying that I think we can remove the entire condition.  If what @shoyer suggests is true then I don't think it will ever be triggered.

I was thinking of other types, like CuPy and maybe Sparse. I thought I had seen one such case, but maybe I got confused. I'll remove for now, and if need be, we can always add it back later.

Currently your condition will not trigger if any of the arguments is of dask.array.Array type.
The fact that Array.__array_function__ is triggered means that at least one of our arguments is of dask.array.Array type.  It doesn't matter what the other arguments are.
I may not fully understand things though.

@mrocklin I don't either, but that's most likely right, since Dask can operate on different types as well, it should probably be capable of operator on mixed types too. For now I've removed this condition.

Merging this in.   Thanks for the effort here @pentschev and thank you @hameerabbasi, @jakirkham, and @shoyer for the review

For testing, I suppose this is OK, but I do think it's a really bad idea for dask not to include any type checking inside __array_function__. This is basically guaranteed to result in bugs.
But let's discuss more in https://github.com/dask/dask/issues/4583.

To be clear, thanks @pentschev and @mrocklin for pushing this forward. I'm really excited about the potential here!
I just want to get the design right. Given that we were involved in writing the NEP, I feel like we should try hard to be an exemplar implementation of __array_function__.

Ah, my apologies if I jumped the gun here.  Happy to revert and reopen if desired.

no need to revert, we can fix this forward

Thanks for the reviews @mrocklin, @shoyer, @hameerabbasi, @jakirkham.
I absolutely agree with @shoyer, we should get the design right. I'm happy to help with whatever I can, I'm not sure I can help much now with coming up with a design since I'm not aware of many of the use cases and how they should work, but count on me later on for implementation and testing.


element-plus component "steps" lagging or taking taking time to load

I were using element-plus' steps for my sign up pages, when I try it to run it take too much time to render or load.

This Steps component requires collecting slot config on the client side, so it cannot be fully rendered on the server side.
This may be the cause of the problem


Add font style to font metrics

Summary

This PR fixes the following bug

[V] a text with an italic font style is not aligned to the baseline

Fantastic library!
One small issue: text with italic font can be rendered higher than it should.
It happens because a span with an italic version of a font can have bigger height than normal, so the baseline should be lower for the italic version.
Currently FontMetrics is calculated without font style, so for an italic version of a font a normal font baseline is used.
This simple PR adds font style to font metrics calculation.

Test plan
This fiddle is with current release version of the library.

This fiddle is with this PR included.

Reftest is at the bottom of this file

The fiddle does not appear to be misaligned on windows chrome - which os/browser/versions where you having issues with?

Chrome and Firefox on Linux both show misaligned italic text in this fiddle for me.
But it is probably not a browser/os issue. It is most likely a font issue.
Sans font family gets resolved to Nimbus Sans font on my system. It is with Nimbus Sans italic text gets misaligned. If i change font family to Droid Sans then italic text gets perfectly aligned.
Nimbus Sans has something in it that makes the height of a span with italic version of the font bigger than not italic one.


a moth specs is failing

Month with failing travis_ci? LOKH!

It's rspec-core bug. https://github.com/rspec/rspec-core/blob/master/Changelog.md Fixed in master, waiting for release.

what release? 2.8.0 released already :)

R u stupid? 2.8.1 obviously.


Some adjustments for grammar/typos

PR checklist

[x] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the qbicsoftware/rnadeseq branch on the qbicsoftware/test-datasets repo
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (qbicsoftware lint .).
[ ] Documentation in docs is updated
[ ] CHANGELOG.md is updated
[ ] README.md is updated

Hi Alex, thanks for your corrections! Would it be possible that you make a pull request to the dev branch? It's then a bit easier for me to have the overview :)


Add .npmignore to exclude unnecessary development files from npm package

I copied .gitignore as .npmignore and added a few development files and folders to be excluded from the npm package as they're unnecessary. Also removed node_modules as it's unnecessary as per npm's documentation.

Ah, there's already a files array in package.json.


Identifying rigid bodies in collisions

Using rapier, it is sometimes necessary to identify what rigid body another rigid body is colliding with, in collision events.
Right now I have workaround where I set userData on the rigid body reactively, but it would be useful to identify rigid bodies declaratively, either through user data, or the rigid body handle.
Does this make sense?
Thanks!

Yes. In those events you have access to the rigid body/collider, but afaik there's no easy way to check if it's a specific element. We have access to the rigid body handle, but it seems that is a random uuid.
For example, in a scene with a bunch of colliders, we check the collisionenter events on collider A: if it collided with collider B we want to run some arbitrary logic, but if it hit collider C we want to run something else.
I've managed to workaround this by setting the rigidBody.userData, but there's not a way of doing that declaratively,
such as:
<RigidBody type="dynamic" userData={{ name: "foo" }}>
  ...
</RigidBody>

So I was wondering if there is some "proper" way of checking this that I don't know of.

From what I can see in the docs and source code, there is no such API at the moment. There is some use of userData within the <RigidBody> component, but I think we could easily expose an addition prop to let Threlte users pass data declaratively in this way (@grischaerbe correct me if I am wrong).

Thanks for the reply. That would be a useful feature!

Added to<EMAIL_ADDRESS>thanks!


[openapi] Support cross-origin requests for schema

Allow cross-origin GET requests for the generated OpenApi schema. This will allow tools such as swagger-ui to render the schema remotely.

Great, thank you!

This has been released as part of 3.1.0 now: https://javalin.io/news/2019/06/23/javalin-3.1.0-released.html


fix wiki links

looks like many have been broken when transferring the repo

update links on README.md

finsihed


Various matches

Various matches
JSystem stuff picked from other projects

That's the name the compiler generates.
On Fri, Jul 21, 2023, 04:00 TakaRikka @.***> wrote:

@.**** approved this pull request.
In libs/Runtime.PPCEABI.H/runtime.cpp
https://github.com/zeldaret/tp/pull/378#discussion_r1270132661:

 nofralloc

-#include "asm/Runtime.PPCEABI.H/runtime/__restore_gpr.s"
+#include "asm/Runtime.PPCEABI.H/runtime/_restgpr_14.s"
is there a reason for these save/rest gpr changes? i'm fine with it, just
curious about the motivation
—
Reply to this email directly, view it on GitHub
https://github.com/zeldaret/tp/pull/378#pullrequestreview-1540328282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYQXXIN4U44HABXH7XSR4DXRHICXANCNFSM6AAAAAA2RS446M
.
You are receiving this because you authored the thread.Message ID:
@.***>


Allow Sec-WebSocket-Protocol to be configurable in fe2o3-amqp-ws

It'd be nice if we could support something like this:
        this.ws = new WebSocket(`wss://${hostname}/$servicebus/websocket`, 'wsrelayedamqp', {
            protocolVersion: 13,
            headers: {
                'Host': hostname
            }
        });

wsrelayedamqp vs hardcoded amqp https://github.com/minghuaw/fe2o3-amqp/blob/701484d7e75f727dd96ea185ba6bf87b83c8c5b4/fe2o3-amqp-ws/src/native.rs#L299

I think this is required by the spec (see http://docs.oasis-open.org/amqp-bindmap/amqp-wsb/v1.0/csprd01/amqp-wsb-v1.0-csprd01.html#_Toc386635618)

Identifies the WebSocket subprotocol. For this AMQP WebSocket binding, the value MUST be set to the US-ASCII text string “AMQPWSB10” which refers to the 1.0 version of the AMQP Web Socket Binding as defined in this document.

If you want to customized value, I think you can use the WebSocketStream, split it into the reading and writing half, and then wrap it in

I think this is required by the spec

Wouldn't it make fe2o3-amqp more flexible/easier to use if it supported accepting a different string?


No error when compass-include-once is required but not installed

Hi,
I have the problem that when I use the require option to load a plugin (compass-include-once) but this plugin is not installed, there is no error thrown. Instead, compass is started up without the plugin, which leads to a very unpleasant result where large files are included multiple times. For me this results in my css file growing from ~2MB to ~9MB in size.
We have a large team and it is not easy to coordinate a manual plugin installation if nothing in the build fails.
Is there a possibility to make grunt-contrib-compass throw an error if a specified plugin can not be found?

What happens if you try to require something that isn't installed using the cli compass binary? If it also silently fails, there's nothing we can do here, and you'll have to ask in the compass issue tracker.

I'll give it a try.


fix: fixed nightlies component naming & appearance

I was overly trigger happy with the previous PR, this should have been in there too


Implemented Steiner Tree optimizer for "Skill Highlighted Nodes"

I'd consider the coding work for #98 done.
There's still the part of writing a decent documentation, but I don't feel like I'll get that done tonight. If you don't want to add that separately later, just leave this open I guess.
Oh right, and the window owner thing. Well, no rush.

If everyone wants to check and see if there is anything missing before merge that would be great
@l0g0sys @SpaceOgre

Looks go to me, I will fix the window owner thing after the merge is done and other than that I think it looks good.

Ok, code documentation has been pushed to my repo. If you ever wondered how I approached this, or why the number of used nodes in the best solution sometimes goes up, Steiner.cs is the place to look. :)

Awesome! Now onto the next project...


Enabling and disabling tests (without modifying code)

This is mentioned in https://github.com/assaf/vanity/issues/158, but a bunch of work has been done in https://github.com/assaf/vanity/pull/121.

Ab tests can now be "enabled" or "disabled". While disabled, a "default" option will always be chosen and no metrics/participants will be tracked. The dashboard shows the status and also lets users change it by clicking a link. Tests also have a different colored background depending on if they're enabled, disabled, or finished.

It might possible to pull out some of the smaller PRs, such as default values for experiments (see https://github.com/apartmentlist/vanity/pull/2).

Closed by #281


Inference Time

How much time does Agentformer model takes to inference upon a given sample.

I think the inference is usually real-time. It also depends on how many agents are there in the scene. From my experience, the model can infer in real-time for < 40 agents.


Updating the README to point to SDK 3.3 and adding a more detailed IP…

…U install instructions
Changelogs

Updated the main IPU install instructions to point to SDK 3.3
Added a more detailed walk though for installing the Poplar SDK, I think too much knowledge was assumed in the main part, but also didn't want to make that install bloated. So a second section walking through the install seems like a good idea.

Checklist:

[ ] Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
[ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added, or an existing one is deleted.
[ ] Write concise and explanatory changelogs above.
[ ] If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@kerstink-GC - does this look better to you?


Fix selection tests

The latest selection changes broke a few tests, these have been
corrected.
Two of these tests were broken because they assumed different span
types, the test have been changed here because the result was correct.
One test did actually catch a bug where selection of two cells from
right to left would incorrectly mark the cells as selected even though
they should not have been, this has been fixed in the simple_span
method.
This is also rebased on top of the latest selection branch.

Thanks @chrisduerr. I ended up cherry picking this onto the scroll/fix-tests branch after a rebase.


mapSamples2 and mapSamples3

Codecov Report

Merging #598 (d3a2f39) into develop (1e4aecd) will decrease coverage by 1.90%.
The diff coverage is 19.49%.

@@             Coverage Diff             @@
##           develop     #598      +/-   ##
===========================================
- Coverage    55.13%   53.22%   -1.91%
===========================================
  Files           48       50       +2
  Lines         3047     3158     +111
===========================================
+ Hits          1680     1681       +1
- Misses        1367     1477     +110

Impacted Files
Coverage Δ

...ucerInterface/ReducerInterface_ExpressionValue.res
34.66% <0.00%> (-22.05%)
:arrow_down:

packages/squiggle-lang/src/rescript/Utility/E.res
43.75% <0.00%> (-0.36%)
:arrow_down:

...es/squiggle-lang/src/rescript/Utility/DateTime.res
9.30% <9.30%> (ø)

...ipt/ReducerInterface/ReducerInterface_DateTime.res
15.90% <15.90%> (ø)

...ucer/Reducer_Dispatch/Reducer_Dispatch_BuiltIn.res
84.09% <41.66%> (-8.41%)
:arrow_down:

...ript/Distributions/SampleSetDist/SampleSetDist.res
33.33% <75.00%> (-3.04%)
:arrow_down:

...ucerInterface/ReducerInterface_ExternalLibrary.res
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61dc08...d3a2f39. Read the comment docs.


Claim unsuccessful bid message

after claiming the unsuccessful bid the msg currently is "You have unsuccessful bid claim" is ambiguous not sure if it means successfully or unsuccessful
msg can be adjusted to "You have successfully claim your unsuccessful bid!"

Updated mess toast @mitchdoan


Use ros2-gbp release repository for message_tf_frame_transformer.

This package was previously copied into the ros2-gbp repository during the Iron branching but not used for subsequent releases.
As a result, there is divergent bloom info between the ros2-gbp repository and the upstream one. But all tags, which are the important artifacts for release integrity, have been copied over to the ros2-gbp repository.
Future releases in all ROS 2 distributions should use the ros2-gbp repository which is configured in https://github.com/ros2-gbp/ros2-gbp-github-org/pull/458

FYI @lreiher Per REP-2002 release repositories for ROS 2 are centralized in the ros2-gbp organization on GitHub. The release repository was previously mirrored into ros2-gbp for an earlier migration. I've updated the ros2-gbp repository with tags from the previous release repository so that it contains all release artifacts used for ROS 2 distributions.
Your access to the release repository in ros2-gbp will be available once you accept the invitation to join the organization which will be deploying shortly now that https://github.com/ros2-gbp/ros2-gbp-github-org/pull/458 is merged. Please open an issue on https://github.com/ros2-gbp/ros2-gbp-github-org if you have any questions or trouble.


New Sample: Raster Layer from GeoPackage.

I was basing it off the screenshot for the Qt sample which showed the edge of the raster, which I felt was possibly useful (showing it's a raster overlaid on top of a basemap rather than just filling the display, which doesn't show that).

That's fine. Just need the image to show the updated raster
Plus you'll have to fix the merge conflict in the project file now that I have merged another PR for a new sample (yikes!)


Switch 5.1.0 workflows to rc1

This PR switches the GitHub action workflows to test 5.1.0~rc1.
I've created a PR against shym/custom-opam-repository to switch under Mingw and Cygwin https://github.com/shym/custom-opam-repository/pull/2. Until that is merged and in the interest of testing 5.1.0~rc1 the most, the PR is temporarily using the relevant branch from jmid/custom-opam-repository

CI summary:

Cygwin 5.1 timeout due to general slowness (2299.8s Domain.spawn/join - atomic, 2834.6s Lin DSL Bigarray.Array1 (of ints) test with Domain, 2358.4s Lin DSL Bytes test with Domain, ...)
Linux trunk debug timeout during 11346.8s Lin DSL In_channel test with Domain #373 (a 2 days old CI run, should be fixed by #375 merged yesterday)
Mingw bytecode 5.1 and Mingw bytecode trunk timeouts during threadomain #203
Mingw trunk crash of threadomain #203
ppc64 trunk/5.2 triggered an infinite loop on STM Array test sequential #380

(+ 2 ongoing Cygwin part 2s)

The last Cygwin runs finished, so I've updated the above summary. None of these issues are new, so I'll merged.


refactor: Remove unnecessary dep in @fluid-tools/markdown-magic

Description
markdown-magic-template is not used at all as far as I can tell, and it brings in a transitive dependency on lodash.template: 4.5.0 which is flagged with a CVE that can't be addressed easily because lodash seems to have stopped publishing each of their functions as a separate package after 4.5.0.
Reviewer Guidance
The review process is outlined on this wiki page.

Interesting. Must be superseded by @tylerbu/markdown-magic? Assuming you've verified everything is still working, looks good to me!

The build and tests for the package still work, and build:docs from the root succeeded and didn't make any changes. Is there another validation you'd suggest I do? I don't recall exactly which flows/scripts exercise the tool.


Issues with adding custom xml when being added for the first time

Reproducer:

Delete .zap repo from your root directory
Add an xml file from the zcl extensions
You get a red ribbon which drops down from the top but does not really say what that is about so it is confusing
Also the xml does not get added. However if you add the xml again then it gets added.

Note: This happens only when the .zap repo is deleted. You may not see this again the next time you run zap and upload the custom xml

Closing this since I do not see this happening any more. Seems like it has been resolved.


Cached data do not use the sample name from the new spec

Suppose I have the following spec for processing a sample with the name "foo"
from servicex import ServiceXSpec, General, Sample, deliver

def run_query(input_filename=None):
    import uproot
    return uproot.open({input_filename: "CollectionTree"}).arrays(['EventInfoAux.eventNumber'])

filename = ("root://eosuser.cern.ch//eos/atlas/atlascerngroupdisk/phys-higgs/HSG1/MxAOD/h028/mc16a/Nominal/"
            "mc16a.PowhegPy8_bbH125.MxAODDetailedNoSkim.e6050_s3126_r9364_p4180_h028.root")

spec = ServiceXSpec(
    General=General(
        ServiceX="servicex-uc-af",
        Codegen="python",
        OutputFormat="root-file",
        Delivery="LocalCache",
    ),
    Sample=[
        Sample(
            Name="foo",
            XRootDFiles=[filename],
            Function=run_query
        )
    ]
)

deliver(spec)

which gives something like
{'foo': ['/tmp/servicex_chlcheng/555eabc6-b680-4391-a35b-e37736408ef0/_fb8d56b26c71d7760000ede59ac8cb59ead5b951364_p4180_h028.root']}

Then if I create a new spec, with the same data reduction, the same input file, but with a different sample name "bar"
spec = ServiceXSpec(
    General=General(
        ServiceX="servicex-uc-af",
        Codegen="python",
        OutputFormat="root-file",
        Delivery="LocalCache",
    ),
    Sample=[
        Sample(
            Name="bar",
            XRootDFiles=[filename],
            Function=run_query
        )
    ]
)
deliver(spec)

This will give the same result as the previous spec
{'foo': ['/tmp/servicex_chlcheng/555eabc6-b680-4391-a35b-e37736408ef0/_fb8d56b26c71d7760000ede59ac8cb59ead5b951364_p4180_h028.root']}

However, I would expect the result to use the new sample name instead, i.e.
{'bar': ['/tmp/servicex_chlcheng/555eabc6-b680-4391-a35b-e37736408ef0/_fb8d56b26c71d7760000ede59ac8cb59ead5b951364_p4180_h028.root']}

or am I misunderstanding the purpose of sample name here?

Closing this issue because the recent 3.0.0 resolves this


Read promotion

Read promotion model, test and service updated.

Codecov Report

Merging #23 into master will decrease coverage by 4.04%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   89.89%   85.84%   -4.05%
==========================================
  Files           2        2
  Lines          99      106       +7
==========================================
+ Hits           89       91       +2
- Misses         10       15       +5

Impacted Files
Coverage Δ

service/service.py
83.33% <28.57%> (-9.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916358c...d29677f. Read the comment docs.


Fix Table cell capitalization

Testing
Go to packages/table/stories/helpers/mocks.ts and change items to something like
export const items = [
  {
    name: "brian Vaughn",
    role: "software Engineer",
    city: "san Jose",
    state: "cA",
    zipcode: 95125
  },
  {
    name: "jon Doe",
    role: "Product engineer",
    city: "Mountain View",
    state: "CA",
    zipcode: 95125
  },
  {
    name: "jane Doe",
    role: "UX Designer",
    city: "San Francisco",
    state: "CA",
    zipcode: 95125
  }
];

Open any table, for example default checkbox table and verify that the table cells are not capitalized.

Cypress is failing for some reason.

I'm looking into the Cypress issue. I'm not sure what's wrong


What does connect:sf:auth --login do?

Hi there,
What does connect:sf:auth --login do?
I see that is passes an argument to the API call, but it is not actually documented as part of the API.
https://devcenter.heroku.com/articles/heroku-connect-api#step-6-authenticate-the-connection-to-your-salesforce-org
Best!
-Joe

Honestly, it does nothing. It looks like it was added here in preparation for a feature that was never developed. I'll get it removed.


How to merge?

I did not find how to merge  in the documentation.

Hello,
Unfortunayely, merging isn‘t supported currently. I will add this in a future update.

I need it too

why is merging still unsupported now?


Update demos to Webex Teams name

Deploy preview for hopeful-hamilton-4090b9 ready!
Built with commit 1ce471e99b2ebf0fb29fd945efe77561a0a2ab84
https://deploy-preview-792--hopeful-hamilton-4090b9.netlify.com


at the beginning of the training, total losses of many samples are close to 0

I try to train my own dataset, and the loss of many samples is close to 0 all the time.  The final score is 10% lower than the pytorch version.  Can you help me?
Thank you.

The latest code has been updated, and the performance has been greatly improved.


Add function that calculates ledger account from a principal

Feature requested by community: https://dx.internetcomputer.org/topic/180
Requires a SHA224 and CRC32 implementation. Implementation taken from Timo's implementation:
https://github.com/research-ag/sha2

I asked Timo if I could include his implementation here and he said yes.
It seems that converting Principal to Account is a basic enough function to have it in base. I hid the cryptographic functions as private functions though.
I will look into where the CRC32 is coming from.

Won't it be confused with ICRC1 account?
Personally, I’m used to the fact that ledger account is accountId

It looks like the Ledger documentation specifies the prepending of the CRC32 hash
https://internetcomputer.org/docs/current/references/ledger#_accounts

Interesting. Better to clarify with the ledger team, because their code doesn't have CRC32 either: https://github.com/dfinity/ic/blob/master/rs/rosetta-api/icp_ledger/src/account_identifier.rs#L58

I just tried making a call to the Ledger Canister with and without the CRC checksum. The call without the checksum failed.
The code you linked to has logic for checking the checksum. I think internally, they strip off the CRC but the public interface requires it. (https://github.com/dfinity/ic/blob/a6d4159013996396c84ca33f54dd60f2c5e17ea0/rs/rosetta-api/icp_ledger/ledger.did#L13)

@ZenVoich that's a fair feedback and seems consistent with the documentation.
Maybe it should be called toAccountID() or toLedgerAccountId()

https://m7sm4-2iaaa-aaaab-qabra-cai.ic0.app/?tag=1188592470
This example seems to clearly show you need the CRC32.


Vulnerability roundup 79: openslp-2.0.0: 1 advisory

search, files

[ ] CVE-2019-5544 CVSSv3=9.8 (nixos-19.03, nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.03: d1dff0bcd9f; nixos-19.09: d85e435b7bd; nixos-unstable: d942688fc13. May contain false positives.

But this was also about nixos-unstable.

@flokli This was a grave mistake from your side. See https://www.zdnet.com/article/ransomware-gangs-are-abusing-vmware-esxi-exploits-to-encrypt-virtual-hard-disks/.


task: drop usage of scss variables and embrace css properties

What is the purpose of this pull request? (put an "x" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)
Since the SCSS variables are already filled with CSS properties
there is no need anymore to keep them around. The build result
does not change and has no impact on users at all.

Note:

font awesome paths are still kept as they are necessary for the third-party lib
error, success, and checked colors are still kept since they have no general settings yet

Hey and good morning!
Thanks for the suggestion, but I've started to rework the UI using tailwindcss already:
https://github.com/PhotoboothProject/photobooth/tree/feature/tw-ui
There's some work left to do, but it's enough to get an idea about what's changing (branch will be force pushed frequently until it's ready for review).

Good Morning, I saw your tailwind changes - I have to confess, that I am not a big tailwind fan.
It´s not about tailwind in specific, it´s more like Utility-CSS frameworks in general.
But I have to admit, It always depends on the use case.
While Utility CSS-Frameworks are great for rapid prototyping,
they are the worst-case for maintaining customizable, themeable, environments.
You can already see the negative impact in your tw-ui branch.

    <a class="<?= $btnClass ?> rotaryfocus ml-2 hidden" href="#" id="btnCollageNext">
    <a class="<?= $btnClass ?> rotaryfocus ml-2 hidden" href="#" id="btnCollageProcess"">
    <a class="<?= $btnClass ?> rotaryfocus ml-2 hidden" href="#" id="btnCollageRetake">
    <a class="<?= $btnClass ?> rotaryfocus ml-2 hidden" href="#" id="btnCollageAbort"">

// Button Configs

// modern
$btnClasses['modern'] = ' inline-flex m-2 items-center justify-center flex-col shrink-0 grow-0';
$shapeClasses['modern'] = 'rounded-md';
$btnShapeClasses['modern'] = 'rounded-full';
$borderClasses['modern'] = 'border-solid border-4 border-btn-border';
$btnSize['modern'] = 'w-16 h-16 md:w-24 md:h-24 lg:w-28 lg:h-28';

This is only the beginning of this and will need to extend to all kinds of areas.
My point here is, that this should not be necessary in the first place.
I would like to propose a different route here:

Unify the markup rendered
Avoid template overrides whenever possible
Introduce preconditioned components
Make adjustments via CSS only

Example:

:root {
  --button-border-radius: 0;
}
.button {
  border-radius: var(--border-radius);
}

:root {
  --button-border-radius: .25rem;
}

:root {
  --button-border-radius: 50%;
}

This will require some rework and will be breaking for users' customizations.
Users would benefit in the long term from more easy and reliable customizations.
Can share more insights into maintaining such systems if you like.
Just ping me, and we can hop into a call.

Back to the original PR, I am currently facing some CSS bugs on my Android tablet. I started investigating and am currently trying to understand the underlying structure and how themes make use of the available CSS. This is just an initial cleanup patch to better see what is used where.


Macros don't work anymore

I can't create the clock with macros anymore. I even tried the example in your readme.
Can you help?
Tks

What Foundry VTT version and Challenge Tracker version are you running?

What Foundry VTT version and Challenge Tracker version are you running?

Just tested on those versions and mine still works. Do you have the Color Picker module enabled?
Can you also click on the main.js:313:13 link and take a screenshot of where it highlights please.
I don't know why they might impact it, but maybe also try disabling other modules temporarily and see if it works then.

Just tested on those versions and mine still works. Do you have the Color Picker module enabled?
Can you also click on the main.js:313:14 link and take a screenshot of where it highlights please.
I don't know why they might impact it, but maybe also try disabling other modules temporarily and see if it works then.
Color Picker was disabled

tks


Build should not attempt to tag a release for PRs that target a non-release branch

Currently the Deploy build task runs on those branches but it should not be the case at all.

I think this got somehow resolved at some point


iOS App with Tauri

TODO

Supply proper .env for tauri build
Fix Supabase session storage
Set initial page to jukebox
Play test

token refresh
bluetooth
airplay
remote

Token refresh might not be working. That's likely a regression in #44 and Supabase / Spotify tokens

Closing this for now. Having more success with Kotlin Multiplatform for VizLab stuff than Tauri


isDirty() false positive with boolean fields

isDirty() is returning true even if nothing changed.
How to reproduce
$user = User::find(1);

var_dump($user->locked); // false
var_dump($user->isDirty('locked')); // false

$user->locked = false;

var_dump($user->locked); // false
var_dump($user->isDirty('locked')); // true, should be false

I assume this is because you have casts bool on that property. This is a known bug, and an issue already exists for it.

Thanks though.

I was about to raise this issue but I see it's cropped up a few times already.
@GrahamCampbell do you know where the other issue is, I can't see anything that still open?

Try with this filter https://github.com/laravel/framework/issues?utf8=✓&q=is%3Aissue is%3Aopen cast
It's not only about the boolean but casting in general: dates, etc...

There are a few possible issues there but nothing that seems to have been "accepted"


Attempt to replace Jackson with Micronaut Serialization

Micronaut Serialization may not support all the Jackson features used here, but it's worth trying

Closed via https://github.com/micronaut-projects/micronaut-discovery-client/pull/456


Font height buffer

created a dynamic buffer, because as the font size increases the buffer winds up not being big enough between glyphs and sometimes they bleed in

Changes Unknown when pulling 7bdc7f68a58b4cae9d517260a42c6eb44978d65e on font-height-buffer into ** on master**.

Changes Unknown when pulling 08877cf390eb751469764423bab153994d131250 on font-height-buffer into ** on master**.


Database lists shell to upgrade task (task #5577)

Moved shell responsible for database lists creation to upgrade task.

@georgeconstantinou have a look at the CodeClimate issues ... some of them do indeed point to weird thingies :)
https://codeclimate.com/github/QoboLtd/project-template-cakephp/pull/631

Codecov Report

Merging #631 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
- Coverage     31.33%   31.29%   -0.04%
- Complexity     1166     1168       +2
============================================
  Files           104      104
  Lines          3996     4001       +5
============================================
  Hits           1252     1252
- Misses         2744     2749       +5

Impacted Files
Coverage Δ
Complexity Δ

src/Shell/Task/Upgrade20180907123600Task.php
0% <0%> (ø)
20 <0> (?)

...c/Event/Plugin/Menu/View/DashboardMenuListener.php
0% <0%> (ø)
12% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daddedc...84c999d. Read the comment docs.


Tests are not actually parallel by default

The docs say that tests are parallel by default, but Runner.parallel is never initialized to true anywhere in the codebase that I can find. We noticed that changing the code to do so sped our tests up a lot.
https://github.com/regen-network/gocuke/blob/8921eaed4a6dc3104f000cb4636da0d927b6cc3b/runner.go#L62

Thanks for catching this error @dgunay ! Would you be able to push a small PR to fix it?

Thanks for catching this error @dgunay ! Would you be able to push a small PR to fix it?

Sure: #33


mystmd: 1.1.52 -> 1.1.53

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for mystmd is: Command line tools for working with MyST Markdown
meta.homepage for mystmd is: https://github.com/executablebooks/mystmd
meta.changelog for mystmd is<EMAIL_ADDRESS>Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.53 with grep in /nix/store/qvib80ygbamrrvvir0avzdh8q27p4xmn-mystmd-1.1.53
found 1.1.53 in filename of file in /nix/store/qvib80ygbamrrvvir0avzdh8q27p4xmn-mystmd-1.1.53

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mystmd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qvib80ygbamrrvvir0avzdh8q27p4xmn-mystmd-1.1.53 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mystmd https://github.com/r-ryantm/nixpkgs/archive/b8d10fa8b4c7737671a29a71182805ad53de6eba.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b8d10fa8b4c7737671a29a71182805ad53de6eba#mystmd

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qvib80ygbamrrvvir0avzdh8q27p4xmn-mystmd-1.1.53
ls -la /nix/store/qvib80ygbamrrvvir0avzdh8q27p4xmn-mystmd-1.1.53/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

mystmd

Maintainer pings
cc @marsam for testing.

Result of nixpkgs-review pr 303964 run on x86_64-linux 1

1 package built:

mystmd


Moving to official v3 endpoint

Partial implementation of official v3 api support.

Pagination and find is implemented in a separate branch see #21 and merge it first to that branch.


Describe how to effectively exclude nested properties from WAF inspection

Even though some requests have been made in the past to improve this documentation, I would still consider it lacking.
There are currently two examples and:

They're wordier than necessary (which makes them harder to understand)
They don't cover much of the available functionality (one covers a request header and one covers a query parameter -- there are no examples for cookies or request body properties)

Suggestions:

To address the first point, reduce the wordiness of the first two examples (e.g. in example 1, there's no need to describe the purpose of the User-Agent header or the potential reasons one would want to exclude it)
Add an example that covers request cookie exclusion
Add multiple examples that cover request body parameter exclusion, utilizing a variety of the available operators (e.g. Equals, Contains, Begins With, Ends With)

IMPORTANT: To address the actual reason that brought me to create this issue (and the title of the issue), provide examples of how to exclude nested body properties from WAF inspection (and highlight the current downsides of what I can tell to be the only available approach)

First, an "example example":

Example 1:
Desired exclusion:

Type: Request Header
Name: User-Agent

Azure Powershell Command:
{insert-az-powershell-command}
Azure Portal Configuration:

Field: Request Header Name
Operator: Equals
Selector: User-Agent

Next, onto address the "IMPORTANT" note -- nested properties.
If I have a request body with the following structure:
{
  "aRootProperty": "value",
  "aRootContainer": {
    "aNestedProperty": "some-string-that-causes-false-positives"
  }
}

And I want to make sure to exclude inspection of the aNestedProperty request body property, a WAF exclusion of Request Attribute Name, Equals, aNestedProperty does not work.
Apparently, Equals operator only works on root properties. To exclude the nested property, one must use the Contains operator -- Request Attribute Name, Contains, aNestedProperty.
This is very unexpected behavior but it's how it behaves, and therefore could really use some documentation.
The downside to using the Contains parameter is that any property name that contains that string, e.g. aNestedPropertyFoo, will now also be excluded from inspection. This is more permissive than I'd like, but from my testing it's the best available option.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4cf0428-ac89-d265-d2c2-0a0d932c99c9
Version Independent ID: 8200ffa3-22ec-39a8-6227-ed1cbe9043a4
Content: Web application firewall exclusion lists in Azure Application Gateway - Azure portal
Content Source: articles/web-application-firewall/ag/application-gateway-waf-configuration.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

After writing all of that, I decided to test if the selector understand dot-syntax for nested property access, and it does!
So, in the above example for nested properties, instead of using Contains as I originally thought was necessary, one can use the following exclusion configuration Request Attribute Name, Equals, aRootContainer.aNestedProperty.
This badly needs documented.

Additionally, for examples, it would be very useful to show for each an example request that would be blocked without the exclusion and bypassed with the exclusion in place.

@mm-gmbd Thanks for your comment. We will review the issue and get back to you shortly.

@mm-gmbd , We have assigned this to the content owner/author for review & update.
@vhorne , for your review.

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close