Object oriented interface for Unirest (e.g. new UnirestClient()...)

It would be useful if Unirest could provide an object oriented interface for those who wish to use it e.g. new UnirestClient() or similar.
Then one could create this object and shut it down, in isolation from other or future Unirest clients.
Unirest.XX static methods could still exist for those wishing to use them, using a UnirestClient a singleton. The Options class would also need to be pulled out of static-land.
My use case is a long-running application, and does not use Unirest all the time, so it's threads can be shut down in between.
This would also solve #127
Side-Note: If this feature is implemented, I also think that the async methods should not be able to be accessed via Unirest's static classes - they should use this via an Object, so it is more obvious that they are also responsible to shut the object down. This however would break backward compatibility, so IMHO the feature should be deprecated and removed in a future version.

Another thought: If this feature is implemented, it would be useful to have the option to create a Unirest instance using a builder pattern, to configure the various options.
I could work on a PR for this if there is interest. The changes will be moderately extensive.

I think this is similar to issue #145. I would also be interested in such a feature.

Yes. please.

Hello, this should be resolved or addressed in Unirest 2. Please see the upgrade guide for important changes.


Why EPK kit is not supported in ThreadX release 6.3.0?

Describe the bug
I'm using ThreadX port for Cortex-R5. I have several tasks in my application and  want to measure overall CPU load by means of kindly provided Execution Profile Kit
According to tx_api.h comments (line 618):
"For Azure RTOS 6, user shall use TX_EXECUTION_PROFILE_ENABLE instead of TX_ENABLE_EXECUTION_CHANGE_NOTIFY"
In fact there is no any use of TX_EXECUTION_PROFILE_ENABLE macros.
On the other hand tx_thread_schedule.s contains lines:
#ifdef TX_ENABLE_EXECUTION_CHANGE_NOTIFY
@
@    /* Call the thread entry function to indicate the thread is executing.  */
@
    BL      _tx_execution_thread_enter      @ Call the thread execution enter function
#endif

Also there is not clear description how to use EPK to measure CPU load

I see what you are seeing. It appears that the information in tx_api.h applies to building the C code. It appears that TX_ENABLE_EXECUTION_CHANGE_NOTIFY should be used when building the assembly code.  Have you tried that combination yet?


Questions about Code in TIN_HICO.py

Sorry to bother you，I have some doubts about the codes in TIN_HICO.py
Question1：
I see the code:
pool5_O = self.crop_pool_layer(head, self.O_boxes[:self.H_num, :], 'Crop_O')
You only use the positive labels, and I want to ask the shape of your O branch(cls_prob_O) in the below code:
self.predictions["cls_prob_HO"] = cls_prob_sp * (cls_prob_O + cls_prob_H)
Cause I found the the shape of cls_prob_sp and cls_prob_H is (pos+neg, 600), while the shape of cls_prob_O is (pos, 600) when rewrite it in pytorch, they can't add
Question2：
tf.reshape(cls_prob_binary, [1, self.num_binary])
And:
tf.reshape(cls_prob_H, [1, self.num_classes])
tf.reshape(cls_prob_O, [1, self.num_classes])
tf.reshape(cls_prob_sp, [1, self.num_classes])
Are they useless cause I found they are not given to a variable?

I found the reason just now and will close it! Sorry to bother you again！


gtestd.lib refers to gtest.dll, not gtestd.dll

This is about gtest:x64-windows.
debug/lib/manual-link/gtestd.lib seems to refer gtest.dll, not gtestd.dll.
There is gtestd.dll at debug/bin/gtestd.dll.
# dumpbin /ALL .\gtestd.lib | Select-String DLL

I have the same doubt, the suffix 'd' should be in the name? or the correspond dll file is not right?

it seems that debug/bin/gtestd.dll becomes debug/bin/gtest.dll.
I think it is not best for cmake (difficulty in ADD_TESTS(ENVIRONMENT)).
But the issue should be closed.

Very simple solution for this issue - use CMAKE_DEBUG_POSTFIX=d:
`
vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
OPTIONS
-DBUILD_GMOCK=ON
-DBUILD_GTEST=ON
-DCMAKE_DEBUG_POSTFIX=d
-Dgtest_force_shared_crt=${GTEST_FORCE_SHARED_CRT}
)
'


updated scripts templates for s2i create

small improvements related to the conversation here

lgtm [merge]

re[test] had to update another part of the template meanwhile.

[merge]


Certain files do not have a corresponding icon when using .txt or .md extension

Certain files, like CHANGELOG, CONTRIBUTING, TODO etc. have special icons. However, if they are suffixed with .md or .txt, they sometimes no longer have their icons.
I would like that such special files also have those icons when they have extensions in their names; many OSes support linking a program to open files with certain extensions (e. g. a markdown reader for .md, or a text editor for .txt). Although VSCode does not have this problem, many of my users use the regular Notepad to read those files; for their convenience, I need to append all my documentation files with .txt (or .md) so that they can easily open those files in their preferred program.
For convenience, here are the pairings that have special icons:

File name
.md
.txt
(no extension)

Readme
x

Changelog
x

x

Changes
x

Version
x

x

Licen[cs]e
x

x

Copying

x

Compiling

x

Contributing

x

Todo

x

I would like to propose to make it so all pairings have the special icon corresponding to the file name.

This is related to https://github.com/microsoft/vscode/pull/144144, correct?
It's the seti theme that has the mappings of icons to the file names. Please create a PR against https://github.com/jesseweed/seti-ui


What hardware requirements does this model have for the machine?

Hi, the model is small (~0.5B) and hardware like rtx 3090 will be good enough.


s-v features + tests for Bug 5379/v11

Previous PR: https://github.com/OISF/suricata-verify/pull/1099
Changes since v10:

Use lt-version for now and skip fixing the broken version check till release

I used #1099 instead due to timing, haven't looked at this one. Can you do a new PR with the changes if necessary?

I used #1099 instead due to timing, haven't looked at this one. Can you do a new PR with the changes if necessary?

It just had fixes for broken version checks. Jason had suggested to put them off till release so this one was without the version check fixes and some workarounds to make the tests pass.


Stop building gardener/gardener dev-images in prow

/kind enhancement
What this PR does / why we need it:
We cannot build productive images in prow in a foreseeable future. For node-agent we plan to build multi-arch images (amd64 & arm64), which is not supported in prow yet. That's why we disable prow dev-builds for gardener/gardener in favor of concourse docker buildx builds.
Additionally, this harmonizes dev and productive image build.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @rfranzke
/hold merging this PR needs to be synchronized with enabling concourse dev-builds

/hold cancel
Concourse pipeline is updated.

/unhold


[Task]: Automatically generate constraints file based on Unit tests and integration test status

What needs to happen?
For Python SDK, we can provide a constraints file. Good read on constraints file: https://luminousmen.com/post/pip-constraints-files.
To automate the dependency management of Python SDK, we can create a task that runs unit tests and some integration tests and if they get a green signal, we can pip freeze to get the latest dependency list and push it to the constraints file.
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

cc: @tvalentyn

.take-issue


[modp-base64] Add missing header files

Describe the pull request

What does your PR fix?
Fixes #28499

After modp-base6 install, only one header file https://github.com/microsoft/vcpkg/blob/b295670e4bab14debe88d92cd5364b21ce26232c/ports/modp-base64/CMakeLists.txt#L23 is included. When using it, if #include <modp_b64. h> will report an error:
Compiler error: modp_b64.h(33,10): fatal error C1083: Cannot open include file: 'extern_c_begin.h': No such file or directory

I installed all the .h files in the "${SOURCE_PATH}/src/" directory to the include directory in CMakeLists.txt to fix this problem and successfully tested locally.

Thanks for the fix!


Update issue templates

Did you want newlines after your bold text? You'll need 2 newlines instead of 1 to make it render that way. Here's how VSCode preview looks:

Thanks @Nking92, yes I'd like newlines after the bolded section headers. The .md files are processed a bit different for templates somehow. The templates actually look like this if we apply the .md files on this PR:


Use pkg-config to find libffi

The previous lookup code doesn't work on systems where the libffi
headers are installed in unusual locations, such as on Arch Linux,
where for some reason the headers are installed in
/usr/lib/libffi-$VERSION/include.
Now uses pkg-config to locate wherever libffi is installed.

Thanks, this has been merged.


How to Configure the Project?

I have cloned it locally and trying to open in Android Studio. I am getting following Errors:
Error:(16, 0) Gradle DSL method not found: 'runProguard()'
Possible causes:

The project 'Abelana-Android-App' may be using a version of Gradle that does not contain the method.
Gradle settings

The build file may be missing a Gradle plugin.
Apply Gradle plugin

I have tried by changing the Gradle Version to latest one classpath 'com.android.tools.build:gradle:1.5.0' too but no luck
@lesv @zafir can you please check?

We haven't worked with this in a while.  https://github.com/GoogleCloudPlatform/abelana is the current one. I should be fixing things this week w/ it.

Thanks @lesv for sharing the repository link.


Add Radial Line of Sight and Range Tool

Description

Add RadialLineOfSightAndRange tool and test case(s)
Action from viewshed/RLOS meeting to add/begin process of analyzing RLOS tools and potentially moving GP tool from:
https://github.com/Esri/solutions-webappbuilder-widgets/tree/dev/Visibility/gpservices here
Renamed mispelled tool/script: RadiaLineOfSight -> RadialLineOfSight
Added layer files, modified RLOS.lyr to add additional labels

How Has This Been Tested?

Tested extensively in previous repo/project (AirC2)
Tested extensively during last sprint
Unit test cases added with PR

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.*
[ ] I have updated the documentation accordingly.*
[X] I have read the CONTRIBUTING document.

* Pending further investigation by the team into 2 RLOS tools
FYI (Meeting attendees): @adgiles @topowright @mfunk @NatalieCampos @BobBooth @pHill5136 @kgonzago @nfeuerstein @lfunkhouser

I did do on 10.4, I'll install 10.3 on a VM and make the change (a lovely benefit of binary compatibility), you should be able to test on Pro 1.4 (assuming that is the correct version) - sorry about that (I didn't know 10.4/10.3 weren't binary compatible)

Just go from your 10.4 machine and "SAVE AS" >> 10.3.  :)

OK - de-updated/downgraded this to 10.3 - this is ready for review again.
Important/Note: this should probably not be merged until after the 1.1 Release/branch is created but feel free to review at your convenience.

The 1.1 release has been created so this is ready to review/merge at your convenience (and hopefully before someone makes another toolbox change).

@csmoore Checking now....


matching runoff to 1.e-5

fixed minor depression storage bug in python code
can now match runoff to tight tolerance

Codecov Report

Merging #84 (bc4780a) into main (1b2405e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   83.05%   83.05%
=======================================
  Files          34       34
  Lines        2998     2998
=======================================
  Hits         2490     2490
  Misses        508      508

Impacted Files
Coverage Δ

pynhm/hydrology/PRMSRunoff.py
81.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2405e...bc4780a. Read the comment docs.


Sep'23 WP3.5 (UKD-UKD-S5) FY23 Annual Evaluation

03/OCT/23

sent email to Manda to complete the Annual Evaluation

30/OCT/23

Manda submitted Annual Evaluation


Daily tests should not test in one namespace

istio/test-infra's config.yaml points to files in istio-releases/daily-release. Some of these files test in a single namespace but they should be testing cluster wide. This will allow us to remove istio-one-namespace-auth.yaml and istio-one-namespace.yaml from the release archive, as described in istio/istio#4859.
This issue is in conjunction with istio/test-infra#795.

Resolved by #532.


Add delegation token as auth

Description
When running in Data Flow, DF provides Delegation Token for accessing Object Storage. We must use InstancePrincipalsDelegationTokenSigner if the application runs in DF.
Ref
https://docs.oracle.com/en-us/iaas/data-flow/data-flow-tutorial/use-your-delegation-token/overview.htm#use-python-app-token
Test

Unit Test

Test beta whl in DF session
I added some print statements to check signer created. These print statements have been removed from the PR.
InstancePrincipalsDelegationTokenSigner created successfully.

Can we use -
if get_token_path():
  ads.set_auth(signer_callable=get_delegation_token_signer, signer_kwargs={"token_path":get_token_path()})

and then use ads.auth.default_signer() to create the signer?

Can we use -
if get_token_path():
  ads.set_auth(signer_callable=get_delegation_token_signer, signer_kwargs={"token_path":get_token_path()})

and then use ads.auth.default_signer() to create the signer?

Yes. It can work. Thanks, Mayoor. This can preserve user-agent.


Pending Release: Use Improved Pluralization

Describe the bug
This issue is to track the release of Improved Pluralization in https://github.com/aws-amplify/amplify-codegen/pull/255
We have a few issues that are open that will be referenced in this issue, while closing them in favor of tracking this issue.
Steps To Reproduce
N/A

Expected behavior
N/A
Amplify Framework Version
N/A
Amplify Categories
API
Dependency manager
Swift PM
Swift version
N/A
CLI version
N/A
Xcode version
N/A
Relevant log output
<details>
<summary>Log Messages</summary>

INSERT LOG MESSAGES HERE

```
Is this a regression?
Yes
Regression additional context
No response
Platforms
No response
OS Version
N/A
Device
N/A
Specific to simulators
No response
Additional context
No response

https://github.com/aws-amplify/amplify-swift/issues/1707#issuecomment-1079413894

https://github.com/aws-amplify/amplify-swift/issues/1443

https://github.com/aws-amplify/amplify-swift/issues/1505

https://github.com/aws-amplify/amplify-swift/issues/1841

Appreciate the attention to fix this. I have personally run into this issue and had to work around it.
Is there an approximate ETA for the CLI tool release that will include this fix?

Hey @shawnyapa, please track the codegen changes for swift in https://github.com/aws-amplify/amplify-codegen/pull/667 (it was merged in today!)

Using Amplify CLI version 12.4.0
Tested with the following schema, gathered from the various issues open.
# This "input" configures a global authorization rule to enable public access to
# all models in this schema. Learn more about authorization rules here: https://docs.amplify.aws/cli/graphql/authorization-rules
input AMPLIFY { globalAuthRule: AuthRule = { allow: public } } # FOR TESTING ONLY!

type NoteData @model {
    id: ID!
    name: String!
    description: String
    image: String
}

type Activity @model {
    id: ID!
    name: String
}

type EventNews @model {
    id: ID!
    name: String
}

type Protocols @model {
    id: ID!
    name: String
}

amplify codegen models
 model.listPluralName = "Activities"
    model.syncPluralName = "Activities"

    model.listPluralName = "EventNews"
    model.syncPluralName = "EventNews"

    model.listPluralName = "NoteData"
    model.syncPluralName = "NoteData"

  model.listPluralName = "Protocols"
    model.syncPluralName = "Protocols"

For customers impacted by this, please use Amplify CLI 12.4.0 or greater to get the fix for the pluralization issue, and re-run codegen amplify codegen models

I confirm this is working for me.  Thanks


Add BETA Badge

Add a BETA Badge to the page until the product is developed further and ready for release

Added orange beta banner to top left of page in 3b9d1ca9d216c4255cda9395cc0c54af8cd03fb2


Unable to deserialize JSON into JsonWebKeySet

Currently, it is not possible to deserialize a JWK Set into Microsoft.IdentityModel.Tokens.JsonWebKeySet without additionnal configuration.
This is because the Keys property is readonly.
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/eeaa61ba4887ded80875ed5659aa8a7c04b1da96/src/Microsoft.IdentityModel.Tokens/JsonWebKeySet.cs#L82
Steps to reproduce:
using System.Net.Http.Json;
using Microsoft.IdentityModel.Tokens;

var client = new HttpClient();
var response = await client.GetAsync("https://login.microsoftonline.com/common/discovery/v2.0/keys");
var jsonWebKeySet = await response.Content.ReadFromJsonAsync<JsonWebKeySet>();
var count = jsonWebKeySet!.Keys.Count; // 0

Known workaround
Before .NET 8, we can use JsonWebKeySet.Create(string) to create an instance of JsonWebKeySet from the raw content:
using System.Net.Http.Json;
using Microsoft.IdentityModel.Tokens;

var client = new HttpClient();
var response = await client.GetAsync("https://login.microsoftonline.com/common/discovery/v2.0/keys");
var raw = await response.Content.ReadAsStringAsync(); // An temporary string is allocated here :(
var jsonWebKeySet = JsonWebKeySet.Create(raw);
var count = jsonWebKeySet!.Keys.Count; // 5

With .NET 8, we can use the new JsonObjectCreationHandling introduced, this way:
using System.Net.Http.Json;
using System.Text.Json.Serialization;
using System.Text.Json;
using Microsoft.IdentityModel.Tokens;

var client = new HttpClient();
var response = await client.GetAsync("https://login.microsoftonline.com/common/discovery/v2.0/keys");
var jsonWebKeySet = await response.Content.ReadFromJsonAsync<JsonWebKeySet>(new JsonSerializerOptions
{
    PreferredObjectCreationHandling = JsonObjectCreationHandling.Populate
});
var count = jsonWebKeySet!.Keys.Count; // 5

Suggested solution
We can add the attribute JsonObjectCreationHandlingAttribute with the value JsonObjectCreationHandling.Populate directly on the Keys property to allow the deserialization without additional configuration.
This attribute has been introduced in .NET 8 so it will probably be necessary to condition it with if NET8_0_OR_GREATER.

@cakescience yes, this is an issue we hit when removing Newtonsoft and removing the Set;
What you have written above will not work until we release a .net 8 target with the attribute changes.
Using the ctor that takes a string will work.

@cakescience once .net 8 is released, we can address this and similar issues.


fix #2023, add parent in the new TraceFeignContext

as stated in title

Thanks for the PR! Can you please add tests and look at my comment ?

Hey, I've merged the commons fix. Can you please update the code to reflect this?

Noted. Will be done

Congrats @HashZhang on your contribution :)


Add bower support

Hi Anna.
First, thank you for the great amount of work done! It saved me a lot of time.
To improve usability of the library, I have added bower support to make it easier to include your library in other projects.
While in lib directory d3 v3.5 was used for examples, I had to use 3.3 version in bower dependencies to avoid conflict with d3.chart dependency.
Also it would be nice to publish the library in bower repository, but before I suggest renaming package name from 'd3.chart.layout' to 'd3.chart.layout.hierarchy' to better reflect its purpose. What do you think?

Hi Basil,
You are very welcome, and thank you very much for the Bower support.
About renaming the package and publishing in Bower:
Yes, renaming makes sense. I used to think about implementing more layouts, but I have to admit that I will not develop them. So I will publish it with the name 'd3.chart.layout.hierarchy'.
Thoughts about version conflict:
I am very new to Bower, actualy I payed more attention on it after your comment. In a long term basis I would like to add dependency on the latest version of 'd3.js'. Recently I do not know how to achieve this in Bower. Maybe I should fork the 'd3.chart' package and maintain it myself.
(Finally, there will be some modifications in the source folder structure. It will reflect to [M. Bostock's layout folder] (https://github.com/mbostock/d3/tree/master/src/layout).)

Thank you for the merge! :)
I see you already changed repository name, and that's great! So if you don't mind, I can prepare bower manifest for publishing.

Of course, you made a nice enhancement! Yes, pleae, create that file.

I got it: bower.json IS the manifest file :)
I have published the package to Bower, and would like to say thank you again Basil, for your valuable suggestions and contribution.

I'm glad that you published the library! Congrats with the first Bower release!)


DAPR Code Sample Not Working

A previously running Aspire AppHost with DAPR sidecars no longer runs the sidecars, but services standup.
Aspire version
Version 8.0.0-preview.4.24156.9
DAPR versions
CLI version: 1.8.1
Runtime version: 1.13.0
To reproduce run the Aspire DAPR sample , which at least on my machine fails with same results in sample as my project.
This is the log from the DAPR sidecar from the DAPR sample project...

Notes:

All DARP sidecars fail to run
Paired services run.
My Services run via Tye, suggest DAPR env is fine.

What version of dapr do you have installed?

@davidfowl
DAPR versions
CLI version: 1.8.1
Runtime version: 1.13.0

@davidfowl  I too have the issue. In my case I started from scratch, installed VS 2022 Preview and related bits.
Initially I has running an older version of DAPR and when I run the Aspire DAPR sample it fails identically as @jkears  explained.
I then upgraded DAPR to 1.13.0 and see the same error.   Please try sample and let us know if you witness similar behavior.

cc @philliphoff

I just realized this is the main repo, which is using the daily aspire bits, not the released ones.

Sorry I noticed the link again 😄

@jkears Is there a reason you have version 1.8.1 of the Dapr CLI (which is nearly 2 years old and may not support the --app-channel-address argument).  Could you try with 1.13.0 of the CLI.
There are some significant differences between how Tye ran Dapr sidecars vs. Aspire (the latter which uses --app-channel-address as a way to get calls from the sidecar to the application to go through the application's Aspire proxy).

I'm going to close feel free to open if you are able to answer q above.


Add Codecov

Description
Add Codecov for Pull Requests.

Closed by https://github.com/healthy-queue/back-end/pull/48!


Long Response times in App

Hi,
we have the problem that our app service has very bad response times (according monitoring from 20ms up to 40s!). So when the website is reloaded it takes often very long.
The app service is running on Azure plan S2.

+1 , we have the same issue, the app response times are too high, sometimes hitting 30 - 40 seconds. The ASP is
Premium v2 P3V2, single instance.

Hi folks, please see this section in the readme: https://github.com/microsoft/sample-app-aoai-chatGPT?tab=readme-ov-file#scalability
You may be able to improve performance of your app by updating the gunicorn settings to have multiple threads and workers. Additionally #460 should improve response time when multiple users are accessing the app.

Thanks @sarah-widder for the suggestion.
We have a UAT copy of the app (using the same AI and Search), it has no users, but response times are still too high.
Here it took 1.8 minute:

Any advice?

@dmbuk, @sarah-widder - Did you manage to figure out an approach/solution to reduce the response times?
We've tried running various production sized ASPs, without luck.


Storage interface methods return types

I think put, remove, and clear methods of Storage class can return the result of the operation because the user may want to take some action according to success or failure.

solved by you in v1.4 :)


import-blocks: Do not read stdin to memory

This fixes a bug with import-blocks reading the entire stdin before starting to import the
blocks. However, for huge files that uses quite a lot of memory. We can just read from stdin step
by step as we do it with a file. This ensures that we don't read the entire input at once into memory.
Fixes: https://github.com/paritytech/substrate/issues/11071

bot merge


Point release-please at main branch

The release-please automation appears to be configured but it isn't apparently active yet. It looks like the app may default to releasing from the "master" branch, so I'm retargeting "main" here.

Plus one for init actions and custom images
On Tue, Nov 26, 2024, 15:00 Ben Sidhom @.***> wrote:

The release-please automation appears to be configured but it isn't
apparently active yet. It looks like the app may default to releasing from
the "master" branch, so I'm retargeting "main" here.
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9
Commit Summary

ebb2d1a
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9/commits/ebb2d1aa067b77ed06c276e368945e9c3a3a7b3f
Point release-please at main branch

File Changes
(1 file
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9/files
)

M .github/release-please.yml
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9/files#diff-35de1d9d9feb5d407dc0e1ca40e9490c335cdd441607bdaf49f8c1bb0a5e0c7d
(1)

Patch Links:

https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9.patch
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9.diff
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/9,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAM6UR72DJKE447SOOHGFT2CT4Q7AVCNFSM6AAAAABSRQ5GP2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TMMZXGQZDQMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Closing as obsolete. The automation appears to be working: https://github.com/GoogleCloudDataproc/dataproc-spark-connect-python/pull/10


Feature: Project setup

Project Setup
This is the Issue Title
Changes made

Add essential pages
Added basic routing setup
Added Mockbee setup
Updated config setup

How does the solution address the problem
This PR will complete the basic setup
Linked issues
Resolves #1

Setup done right. Good to go.


Feature Request / Filtering Issue

It would be nice to be able to defer execution of the Kata search filter method to a new filter button on the page. When I search for Kata I almost always search by 3 conditions: specific language, progress, and the difficulty. The default behavior of the filter is to immediately execute when one of the filtering options are selected. This can be quite annoying because I have to wait for the page to reload before I can select additional options. Because I regularly filter by 3 conditions it can take 9-12 seconds before I can began looking through the filter results. You could either remove the ability of the controls to trigger the filter method (preferred) and instead defer that control to a filter button or if you are dead set against changing the current filter behavior you could alternatively create another widget below that provides that functionality. Another alternative would be to allow users to save their preferred filter configuration which you could persist in your database and then use it to set default control values when the page is loaded.

You can apply more filters while the CW is loading, and if you are fast enough you can select every option you need during just one loading time. Not that it solves the issue, but at least you won't have to wait for 9-12 sec every time.

Cool thanks for the response. Its not a huge deal but I thought I would throw it out there as suggestion since it would make for a better user experience and the solution would be relatively simple.
Sent from Mail for Windows 10
From: Alexander Fedorov
Sent: Sunday, February 3, 2019 4:53 AM
To: Codewars/codewars.com
Cc: JTsquared; Author
Subject: Re: [Codewars/codewars.com] Feature Request / Filtering Issue (#1714)
You can apply more filters while the CW is loading, and if you are fast enough you can select every option you need during just one loading time. Not that it solves the issue, but at least you won't have to wait for 9-12 sec every time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


X509_dup returns NULL for certs with ENGINE based associated keys

Hi!
I found that X509_dup uses EVP_PKEY_dup to copy associated keys in openssl-3.0.0. The problem is that EVP_PKEY_dup is a new method and can't be used for ENGINE based keys. So X509_dup returns NULL for any cert with ENGINE based associated key.
The root of problem "Why can't EVP_PKEY_dup used for ENGINE based keys?" is that there is no interface to set up copy method of EVP_PKEY_ASN1_METHOD structure.
I've found two approaches to resolve it:

Save the old logic inside X509_dup on EVP_PKEY_dup failure.
Add EVP_PKEY_asn1_set_copy function to setup the copy method of EVP_PKEY_ASN1_METHOD structure.

For the first approach I've create a patch:
diff --git a/crypto/x509/x_x509.c b/crypto/x509/x_x509.c
index d14de0e77e..88d4e3f0e1 100644
--- a/crypto/x509/x_x509.c
+++ b/crypto/x509/x_x509.c
@@ -105,14 +105,16 @@ static int x509_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
             if (!ossl_x509_set0_libctx(ret, old->libctx, old->propq))
                 return 0;
             if (old->cert_info.key != NULL) {
-                EVP_PKEY *pkey = X509_PUBKEY_get0(old->cert_info.key);
+                EVP_PKEY *pkey_old = X509_PUBKEY_get(old->cert_info.key);

-                if (pkey != NULL) {
-                    pkey = EVP_PKEY_dup(pkey);
+                if (pkey_old != NULL) {
+                    EVP_PKEY *pkey = EVP_PKEY_dup(pkey_old);
                     if (pkey == NULL) {
-                        ERR_raise(ERR_LIB_X509, ERR_R_MALLOC_FAILURE);
-                        return 0;
-                    }
+                        pkey = pkey_old; // FIXME
+                    } else {
+                       EVP_PKEY_free(pkey_old);
+                   }
+
                     if (!X509_PUBKEY_set(&ret->cert_info.key, pkey)) {
                         EVP_PKEY_free(pkey);
                         ERR_raise(ERR_LIB_X509, ERR_R_INTERNAL_ERROR);

In the second approach I'm afraid that EVP_PKEY_asn1_set_copy function will be deprecated at birth.
What do you think about that?

This is basically a duplicate of #16606
Yeah, the option 2 does not make any sense.
I think the option 1 is the only reasonable way. Would you submit a PR, please?

Ok!


Development

This PR is to improve the look and feel of the website.
Also to enhance the readme file.

👍🏻  Approved


Update links with query params

Black Duck Security Report
Merging #78 into master will not change security risk.
Added Components
Clean:       3
Click here to see full report


npm install 安装失败

xazy@DESKTOP-7UOSQIE E:\00\01.WorkSpace\ABP-MicroService\WebApp\vue
$ npm install
npm WARN deprecated<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>3.x is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>This project has been renamed to 'tasksfile'. Install using 'npm install tasksfile' instead.
npm WARN deprecated<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>This loader has been deprecated. Please use eslint-webpack-plugin
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>This project has been renamed to @pawelgalazka/cli . Install using @pawelgalazka/cli instead
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
npm WARN deprecated<EMAIL_ADDRESS>Support has ended for 9.x series. Upgrade to @latest
npm WARN deprecated<EMAIL_ADDRESS>joi is leaving the @hapi organization and moving back to 'joi' (https://github.com/sideway/joi/issues/2411)
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>This project has been renamed to @pawelgalazka/cli-args. Install using @pawelgalazka/cli-args instead
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to kleur@3 or migrate to 'ansi-colors' if you prefer the old syntax. Visit <https://github.com/lukeed/kleur/releases/tag/v3.0.0\> for migration path(s).npm WARN deprecated<EMAIL_ADDRESS>use String.prototype.padStart()
npm ERR! Error while executing:
npm ERR! C:\Program Files\Git\cmd\git.EXE ls-remote -h -t git://github.com/adobe-webplatform/eve.gitnpm ERR!
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: <IP_ADDRESS>]: errno=Unknown error
npm ERR!
npm ERR!
npm ERR! exited with error code: 128

xazy@DESKTOP-7UOSQIE E:\00\01.WorkSpace\ABP-MicroService\WebApp\vue
$ yarn install
yarn install v1.22.10
info No lockfile found.
[1/5] Validating package.json...
[2/5] Resolving packages...
warning element-ui > async-validator > babel-runtime ><EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
warning jsonlint ><EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
warning tui-editor ><EMAIL_ADDRESS>Support has ended for 9.x series. Upgrade to @latest
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error Couldn't find match for "eef80ed" in "refs/heads/master,refs/tags/v.0.1.2,refs/tags/v0.1.1,refs/tags/v0.2.0,refs/tags/v0.2.1,refs/tags/v0.2.2,refs/tags/v0.2.3,refs/tags/v0.2.4,refs/tags/v0.5.1,refs/tags/v0.5.2,refs/tags/v0.5.3,refs/tags/v0.5.4" for "git://github.com/adobe-webplatform/eve.git".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

发错地方了，呃呃呃


Urdu Text not getting displayed

I'm using the react-native-html-to-pdf package. The pdf works fine in English language but when I change my language to any other language except English then the text is not visible and it shows empty spaces instead of the text.

This is happening on Android.

I'm using the react-native-html-to-pdf package. The pdf works fine in English language but when I change my language to any other language except English then the text is not visible and it shows empty spaces instead of the text.

do you found any solution??


google-cloud-sdk: 321.0.0 -> 322.0.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108774 run on x86_64-linux 1

1 package built:

google-cloud-sdk (google-cloud-sdk-gce)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108774 run on x86_64-linux 1

1 package built:

google-cloud-sdk (google-cloud-sdk-gce)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108774 run on x86_64-darwin 1

1 package built:

google-cloud-sdk (google-cloud-sdk-gce)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108774 run on x86_64-darwin 1

1 package built:

google-cloud-sdk (google-cloud-sdk-gce)

Please add a pythonImportsCheck.

Could you help me out with what imports I'd check here? This tool exposes a suite of commands to work with rather than it being used as a library. So I'm confused with this. Or should we check for the commands that are exposed work(execute) or not? @SuperSandro2000

Please add a pythonImportsCheck.

Could you help me out with what imports I'd check here? This tool exposes a suite of commands to work with rather than it being used as a library. So I'm confused with this. Or should we check for the commands that are exposed work(execute) or not? @SuperSandro2000

I can't easily check the source code of this right now but an importsCheck checks if all dependencies are correct.

I can't easily check the source code of this right now but an importsCheck checks if all dependencies are correct.


Error in typings: Exports and export assignments are not permitted in module augmentations.

TypeScript 2.0.3 throws the following error on typings.d.ts
...\node_modules\react-masonry-component\typings.d.ts
(31,5): error TS2666: Exports and export assignments are not permitted in module augmentations.

I don't know why this is not allowed but I'll do some research on how to workaround this problem.

The problem is that the export needs to be outside the "declare module" and in order to declare a variable (Masonry) we need to use the declare keyword,
Here's the working typings.d.ts file. I guess you can just replace the contents of it. I don't think forking your project and submitting a PR is worth the trouble.
Thank you
import { ComponentClass } from "react";

declare module "react-masonry-component" {

    export interface MasonryOptions {
        columnWidth?: number;
        itemSelector?: string;
        gutter?: number;
        percentPosition?: boolean;
        stamp?: string;
        fitWidth?: boolean;
        originLeft?: boolean;
        originTop?: boolean;
        containerStyle?: Object;
        transitionDuration?: string;
        resize?: boolean;
        initLayout?: boolean;
    }

    interface MasonryPropTypes {
        disableImagesLoaded?: boolean;
        updateOnEachImageLoad?: boolean;
        onImagesLoaded?: (instance: any) => void;
        options?: MasonryOptions;
        className?: string;
        elementType?: string;
        style?: Object;
    }

}

declare const Masonry: ComponentClass<MasonryPropTypes>;
export default Masonry;

https://github.com/eiriklv/react-masonry-component/pull/59

I have merged in #59 and will close this issue. Please reopen if needed


Lost compatibility with the Token Magic FX effects

I use libwrapper, Token Magic FX both the lates and I am aware of the fact Token Magic FX does not support the foundryvtt 11 fully yet and my foundry version is the latest.
Between getting foundry vt 11.307->11.308 and Walled template 0.64->0.6.6 I lost the ability to cover the template with Token Magic FX effect like Shock. I use Walled template to autotarget and handle the token attachement.
I can get back a static TMFX effect by changing all the colors in the template and effect, but it is not moving/rotating with the template.
It is possible your change did not effect this, but as you know more about this I ask your opinion if one of your bugfix could cause this. I could not downgrade to 0.6.4 but 0.6.2 and the atachement is not working there.

I downgraded to Walled template 0.6.2 now and use Token Attacher to bind the token centered magic area and effect, thus I have workaround, but something went sideways here. I would appreciate any insight.

same issue


Feat/Image Upload Cloudinary

Fixes #319 Adding functionality of upload image in cloudinary and store its secure_url in database of User.profilePicture.
Code changes:
Index.js => simply call to cloudinaryConnect and also use middleware to parse files using package of express-fileupload.

CloudinaryConnect require CLOUD_NAME, CLOUD_API_KEY, CLOUD_SECRET you can get all of these by registering in cloudinary

Image uploader function having many parameter you can also edit the quality of image and also sent video as well.

Admin image upload=> it fetches file from req.body if file exist then it will upload to cloudinary otherwise skip and after uploading it will give you secure_url by which you can see your upload image.

Customer image upload=> it fetches file from req.body if file exist then it will upload to cloudinary otherwise skip and after uploading it will give you secure_url by which you can see your upload image.

@RamakrushnaBiswal Please review and merge it with labels:)

@RamakrushnaBiswal I also add image filed during signup if any one want image upload during signup then it can upload and stored in database.

@harshbhar0629 resolve code rabit suggestions

@RamakrushnaBiswal this code is also work and given changes are not very small so that i can change easily

Resolve conflicts @harshbhar0629

Resolve conflicts @harshbhar0629

Ok

@RamakrushnaBiswal All conflicts are resolved:)


Testing for DataBoundary .NET SDKs

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


500 error when running a report

On prod ibutsu, select the "Satellite QE" project and try to run a report:
{
  "detail": "The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.",
  "status": 500,
  "title": "Internal Server Error",
  "type": "about:blank"
}

Any errors in the log files?

[2020-10-27 16:59:30,329] ERROR in app: Exception on /api/report [POST]
Traceback (most recent call last):
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/opt/app-root/lib/python3.6/site-packages/flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/app-root/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/decorator.py", line 48, in wrapper
    response = function(request)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/uri_parsing.py", line 144, in wrapper
    response = function(request)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/validation.py", line 184, in wrapper
    response = function(request)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/parameter.py", line 121, in wrapper
    return function(**kwargs)
  File "/opt/app-root/src/ibutsu_server/controllers/report_controller.py", line 61, in add_report
    report_dict.project_id = get_project_id(report_parameters["project"])
AttributeError: 'dict' object has no attribute 'project_id'


Import issue in plot_calibration notebook

Hi !
I tried to lauch your code,
I got an issue with these import :
from src.datasets.read_dataset import RealDataSet
from src.models.diverse_ensemble import DiverseEnsembleMLP

indeed, the only folder in src folder is tsim so we need to add tsim in the import by :
from src.tsim.datasets.read_dataset import RealDataSet
from src.tsim.models.diverse_ensemble import DiverseEnsembleMLP

Hello, thanks for noticing, and sorry for the disturbance, the package is still under development.
As it is a package, you can simply do import tsim or  from tsim import <function> to use it.
I updated the notebooks accordingly.


[C++] Add algo appendModel to merge to Models.

Solves #742
It also:

corrects the inertia of humanoid model,
make Model printing function easier to read.

It shouldn't be hard to tweak the code of this PR to solve #470.

It could also be extended to solve #379

Thanks @jmirabel for this new feature. It will be required to update it later, but for the time being, your implementation is already sufficient.

Thanks for having been flexible.


Drop extra properties

and make sure that client parameters are not duplicated (again)

No, it was happening before, just not getting filtered . They shouldn't be in there regardless of Parameter or VirtualParamter


Update issue templates

Codecov Report

Merging #105 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #105   +/-   ##
========================================
  Coverage    83.55%   83.55%
========================================
  Files           73       73
  Lines         3959     3959
  Branches       722      722
========================================
  Hits          3308     3308
  Misses         425      425
  Partials       226      226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc4ff0...86b04bf. Read the comment docs.


doc: Remove "with slurm"

Fix hpcaitech/ColossalAI#2851
📌 Checklist before creating the PR

[ ] I have created an issue for this PR for traceability
[x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[ ] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g. fixed #1234, closed #1234, resolved #1234

Fix hpcaitech/ColossalAI#2851
📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

[x] I have linked my PR to an issue (instruction)
[ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[ ] I have added thorough tests.
[ ] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Thank you very much for your contribution!


Software requirements

Hey guys,
I'm currently trying to setup your repo and struggled with the versioning. Can someone tell me which Python version is required as well as the associated tf version.
Thanks in advance!

Hello,
Thanks for being interested in our work. This project is implemented a while ago and based on my memory we used Python 3.3 and Tensorflow 1.6. However, I would suggest to use the most current version and give it a try.


Use newest Guava version

i use cloud-spanner in a project. But the currently used Guava version, has vulnerability issues.
Please release a new version that uses Guava 32.0.1

Closing as this has been released.


bug:

Prerequisites

[X] I have searched for existing issues that already report this problem, without success.

Script Version
1.3.3
Platform
Webapp
Current Behavior
When there is:
„Buy failure ERROR (Other user won…(461)”
Script does „add delay after buy”.
Expected Behavior
Only after bought players should be a delay.
Steps to Reproduce
.
Additional Information
No response

Its per design, irrespective for whether you win or not its a request to EA server so delay will be added


fix: Misconfigured SidecarSpec doesnt crash sidecar.

Codecov Report
Base: 31.83% // Head: 26.71% // Decreases project coverage by -5.12% :warning:

Coverage data is based on head (a1010e8) compared to base (c399126).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   31.83%   26.71%   -5.12%
==========================================
  Files         102        5      -97
  Lines        2513      131    -2382
==========================================
- Hits          800       35     -765
+ Misses       1713       96    -1617

Impacted Files
Coverage Δ

...configurations/sidecar_spec/sidecar_spec_base.dart

...figurations/sidecar_spec/sidecar_spec_parsers.dart

...sidecar/lib/src/protocol/models/edit_result.g.dart

...es/sidecar/lib/src/utils/printer/lint_printer.dart

.../lib/src/analyzer/providers/results_providers.dart

...decar/lib/src/protocol/models/analysis_result.dart

...car/lib/src/protocol/models/file_update_event.dart

...ges/sidecar/lib/src/analyzer/sidecar_analyzer.dart

...idecar/lib/src/server/starters/server_starter.dart

...ecar/lib/src/protocol/models/analysis_results.dart

... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


test h2c

Codecov Report

Merging #30 (e3d8e70) into master (2ab9711) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage    9.37%   9.59%   +0.21%
=========================================
  Files           3       6       +3
  Lines         512     636     +124
=========================================
+ Hits           48      61      +13
- Misses        458     569     +111
  Partials        6       6

Impacted Files
Coverage Δ

crypto/sort.go
0.00% <0.00%> (ø)

crypto/keyset.go
0.00% <0.00%> (ø)

crypto/b_dhke.go
19.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Batch code reorganization

No changes only new methods more readable, this pr is the same than the last one but not broken.

Converted to draft to stop myself from merging LOL

Okay I've adapted the Carlos solutions to the branch. Now it's optional to enable manual synchronization of the persistent buffers by adding BATCHING_SYNCED to the preprocessor definitions. I also noticed that we have the issue persisting with 4 segments, so I bumped up them to 8 segments which seems to solve the issue. The other solution with manual sync was left to be safe, which we can always enable if we see the issue persisting.


Unspent Txs not detected even after -rescan

Describe the issue
We updated our Dogecoin core from 1.10 to 1.14 and upon updating, the wallet seemed to have rescan by itself. Once that is done and after it fully synced, we ran getbalance "*" 1 which gave us a negative value. Running getbalance only with out params gives us a positive value but a wrong one, it is missing a lot of unspent inputs(about 3.8M doge).
Troubleshooting that we did:

We restarted the dogecoin wallet with -rescan. It seems to work fine as we see AddToWallet on the logs. And after sometime, it finishes and it starts to sync with the latest block. getbalance "*" 1 still gives us negative balance, and getbalance still gives us a wrong balance.

We restarted the dogecoin wallet again with -reindex. It finishes reindexing and this time getbalance "*" 1 and getbalance both gives us a positive balance but a wrong one.

We restarted again with -rescan and same result as no. 2, positive balance but wrong one.

Our total balance was supposed to be more than 7.2M doge. It was only showing about 3.38M doge. We tried to run listunspent 1 9999999  "[\"DDiXUq2LGcF29v9XE18BKvgWjZtu8bjSoW\"]"  and it only gave us a few unspent inputs.

We secured first the balance that can be "seen" and sent the 3.38M doge to another external address using sendtoaddress, and this works fine, after sending, doing getbalance gives us about 1000 doge left. Our hot wallet address is https://blockchair.com/dogecoin/address/DDiXUq2LGcF29v9XE18BKvgWjZtu8bjSoW In which you can see that it still has a balance of 3.88M doge and you can also see that we sent out 3.38M doge to another address. Given the fact that we where able to send it, just means that the address is ours, and doing validateaddress also says ismine:true.

Now we are on the last straw of our patience, and we'd like to try to simply delete the blocks and chainstate folder and try to start it from that.  If you guys have another suggestion, feel free to comment.

Expected behaviour
It should give the correct balance after -reindex and -rescan
Actual behaviour
It gave us wrong balance
What version of Dogecoin Core are you using?
https://github.com/dogecoin/dogecoin/releases/tag/v1.14.0
Machine specs:

OS: Ubuntu 18.04.1 LTS
CPU: Intel(R) Xeon(R) CPU E5-1660 v3 @ 3.00GHz
RAM: 125G
Disk size: 4TB
Disk Type (HD/SDD): HD

It's not a problem I've seen myself, so it's hard to be sure where to start with this, but I'll see if I can generate a significantly more complex wallet on testnet to reproduce this.

To update on this, deleting the blocks and chainstate folder did not worked either. So we suspect a corrupted wallet.dat file somehow since we had thousands of transactions for this wallet file.
So we ended up creating a new wallet.dat file. However, we still have about 3.9M doge left plus any balances on other addresses on the old wallet.dat file. We plan to simply dump the private keys and recover the balances, however, we have thousands of addresses and it would be great if we could simply export the private keys of addresses that has balance in them. Any suggestion would be appreciated.

How did you fix it? i have been trying for years. all my doge is gone.

How did you fix it? i have been trying for years. all my doge is gone.
you should delete mempool.dat  first , then rescan

@patricklodder @rnicoll @michilumin We can close this one.


Make Redis reporting transactional and support multiple simultaneous servers

For some reason, the IDs registered were IP:PORT. I had tons of those keys in my Redis. However, the code is OK. I will close until I encounter the issue again.


create volume path validations

Right now volume paths are not checked until after the container is created, which can cause a container to fail to start, but not fail to be created in certain circumstances.
Need a set of validations on the volume paths prior to volume initialization.
This would include, but not limited to:

Is the path an empty string?
Is the path relative?
Is the path a file
Is the bind-path relative
...

Can you provide examples?
Here are the results on my end: (tested with docker 1.5)
empty string - shows error
docker create -v "" busybox
invalid value "" for flag -v:  is not an absolute path

relative path - shows error
docker create -v . busybox
invalid value "." for flag -v: . is not an absolute path

file - doesn't show error but does successfully bind to /test.txt
docker create -v /test.txt busybox
012c0d8fac59d1fd1bfe7d0d588cd6ded845320d9afee95dee0655b82a75b588

bind-path relative (host) - shows error
docker create -v .:/dest busybox
FATA[0000] Error response from daemon: cannot bind mount volume: . volume paths must be absolute.
docker create -v /src:. busybox
invalid value "/src:." for flag -v: . is not an absolute path

Yes, thanks for looking at this, sorry this seems a bit ambiguous.
In some cases there are client side validations, so api requests aren't validated, builder, etc.
These should go into a common place.

Unable to replicate. Can you please provide an example in which run -v works and create -v doesn't?

@ctate I think what @cpuguy83 means is that those validations happen in the client side of docker, but they should probably be in the server too. The CLI checks whether the paths are correct when it calls runconfig.Parse: https://github.com/docker/docker/blob/455a272aef4e109ce57c20f9ea224e4d4b32ece7/runconfig/parse.go#L31
Since those validations are not in the server, everybody that wants to use the remote api needs to create those validations for their use case. Moving them to the server would make the expectations for every client consistent to the default CLI.

#dibs I'm writing a PR to solve this.

@resouer when you do a PR, can you please add fixes or closes keyword to it? Thanks!

@rrarunan will do!

@cpuguy83 In our PR we found that VOLUME in dockerfile is allowed to pass a relative path to dockerd (which lead ci failed), I think we should not allow that too. What do you think?

Just a user feedback: guys, it would be really helpful to fix this one - have just spent 2h stairing on "Unable to find image" after I have build on and it's on the list of images.. because of the malformed -v. And it also took a while to find this issue too.

@bzz do you mind to send us the docker version you're using and the command line that caused the problem? That would help us narrow the error cases down.

@calavera sure. Docker is awesome piece of software, so thank you for your time spent on making it even better!
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): darwin/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

and the problem was actually very simple (and quite common, I assume) - an un-expanded env vars in the -v flag
$docker images
REPOSITORY                                TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
debian                                    jessie              bf84c1d84a8f        8 days ago          125.2 MB

$echo $OUT

$docker run -it -v "$OUT:/root/out" debian:jessie bash
Unable to find image 'debian:jessie' locally

The issue here is a misleading error message.

@bzz I think your issue might be solved in 1.7, but it could need some improvements:
sudo docker run -it -v ":/root/out" alpine ash
Error response from daemon: Cannot start container b7f8148ab813a2682ce2bc357f41e5008d4c27aa5aa941ec89bafcd21b9cc333: Unable to setup mount point, neither source nor volume defined

sorry, didn't want to close this issue. Daemon validations are still useful.


notes

Hi Phil,
Thanks for your interest in the architecture!
I just wanted to point out that we don't actually tie the weights across RIN blocks of the same forward pass:
https://github.com/lucidrains/recurrent-interface-network-pytorch/blob/main/rin_pytorch/rin_pytorch.py#L398
This is important because tieing the weights in the forward pass (which I experimented with)  gives the model significantly less capacity. Will highlight this more in the paper's pseudo-code in an updated version.
In that way, the architecture is actually more similar to models like Perceiver / BigBird / memory transformer, rather than ISAB, because achieving depth without reinitializing "inducing points" is quite important for the model to learn how to use the latents effectively (ISAB mostly achieves clustering of the data tokens at each block, since it resets inducing points at each block).
You can view RIN as factoring a global-self attention matrix  that operates on a set of [global, data tokens] into global-global, global-data (write), data-global (read), and data-data interactions. We never use data-data interactions (like Perceiver), but show that adding global-data interactions (writing) is important. We use global-global interactions (like BigBird / memory transformer), but apply them more frequently than other interactions; importantly, global tokens have more channels and are processed with wider blocks.
The 'recurrent' aspect actually comes from the fact that warm-starting the latents across iterations (i.e. forward passes) gives you an effect akin to an RNN, since you can propagate latent information; the result is that the model is effectively very deep at inference.
Happy to discuss further :)
Allan

@ajabri hey Allan, i've unweight tied the layers and the results do look more promising now. will update the readme once the flowers come into view
i reread the set transformers paper, and indeed they never mentioned propagating the latents, so that would be a slight difference
were you able to get the number of latents any lower than 256?

RE propagating latents, this seems to be a key requirement, as otherwise
the effective lack of depth on the latent path becomes a problem.
RE the number of latents, it really has to do with the complexity of the
dataset and the performance you'd like to achieve; for example, to get to
state of the art results on ImageNet 128x128, you can use 128 latents. For
ImageNet 256x256, or kinetics 16x64x64 where the number of interface tokens
is 2048, using 256 latents suffices. But in general, using fewer latents
works (i.e. 128 or even fewer), but at the expense of few FID points. For
flowers, I imagine you can get away with fewer (e.g. 64 or 128). We also
found that you can use fewer channels for less complex data (e.g. for
flowers, I except 256 dim tokens and 768 dim latents would suffice).
Allan
On Mon, Dec 26, 2022 at 4:46 PM Phil Wang @.***> wrote:

@ajabri https://github.com/ajabri hey Allan, i've unweight tied the
layers and the results do look more promising now. will update the readme
once the flowers come into view
i reread the set transformers paper, and indeed they never mentioned
propagating the latents, so that would be a slight difference
were you able to get the number of latents any lower than 256?
—
Reply to this email directly, view it on GitHub
https://github.com/lucidrains/recurrent-interface-network-pytorch/issues/2#issuecomment-1365281400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBVLKBGUFBV33YIXPBFKDWPHDXDANCNFSM6AAAAAATJSARBI
.
You are receiving this because you were mentioned.Message ID:
@.***
.com>

--
A.

@ajabri if you still have access to google level compute, maybe try training some images at 1024x1024 (FFHQ), and including the results in the paper? i am willing to change my mind

@ajabri nonetheless, i think your sigmoid noise schedule and your insight that any hidden state of the network can be self-conditioned, are both great contributions. i may try self conditioning on the output of the inner most stage of the unet in another project, and will cite you accordingly.

@ajabri nonetheless, i think your sigmoid noise schedule and your insight that any hidden state of the network can be self-conditioned are both great contributions. i may try self-conditioning on the output of the innermost stage of the unet in another project, and will cite you accordingly if it works well.

@ajabri one thing for certain, self-conditioning is here to stay as a technique!

Hi @ajabri, what do you mean by tying the weights ?

hey Allan, given the claims of the paper, could you try training on 1024 x 1024 FFHQ? the results would be most informative. I'm skeptical you can stick with 256 latents and still get good results, but willing to change my mind.

@lucidrains How long did you train the 130k flowers model for on how many GPUs? What were the hyperparameters you used, like model dimension and number of layers?

@Lamikins pretty much what is in the readme
it should be even better, as the run i did was using weight tied layers

@ajabri I was unable to reproduce your CIFAR10 results from the paper,
here are my FID scores over ~90k steps using RIN with dim=256, patch_size=1, num_latents=256, depth=6, latent_self_attn_depth=2 and batch_size=128. Learning Rate scaled from 1e-3 to ~2e-4 over training. EMA set to .9999 after a few thousand steps.

I am wondering how you were able to achieve the 1.81 FID in the paper-- did you use any additional model changes, or additional hyperparameters?
Example Generations:

@Lamikins, from what I understand the latent (z) dim and attention should be larger than image (x) dim and attention, yet they are the same in this implementation. Is that correct @ajabri, @lucidrains  ?

Yea that's correct; Although the cross attention requires the dims of Q,K,V to be the same, so eventually we will have to map to the same dimensions anyway

Yeah except for the the x-z cross attention and x self-attention, the self-attention for z can be much larger so that the model can have greater learning capacity

oh interesting, I overlooked that. I'll try running those experiments.

@Lamikins i apologize but i had a big bug where i tied the cross attention layers going to and from image to latents - should be fixed in 0.1.0! i'll rerun my experiments overnight
@thuanz123 thanks Thuan for noticing that the latent dimension can be separate from the image dimension. i've added the option as dim_latent

Thanks Phil! I caught that as well, unfortunately despite my best efforts this weekend I was unable to get RIN to converge.
I used this architecture in the k-diffusion repo and the model is very unstable during training.
I added layer norms to the architecture similar to the normal transformer and that seemed to help a bit.

However, despite adding layer norm, untying the weights, and enabling different latent_dim and interface_dim, the FID scores are nowhere near the paper (nor near the base model of k-diffusion, a CIFAR FID score of ~28). The increasing FID scores are due to nans in the base model (I use the EMA model to calculate FID).
This is using a batch size of 128, lr=1e-3 with ADAM, and varying between 30 and 75M parameters.

One thing to note: without using layernorm on every latent output, the magnitude of the latents grows very large, which is a reason for the NaNs.

@Lamikins oh that's strange, i have pre-layernorms for all the attention and feedforward layers

@Lamikins try lowering your learning rate to something like 2e-4

@Lamikins where are you adding the layernorms?

@Lamikins actually yea, that's another thing with the ISAB-like architecture. i've run into stability issues trying to apply it for a contract work where i needed long context

yea I think learning rate may be too high-- although I don't have the compute to do 12 hour long runs with a lower rate 😅
Let me know if you want to collaborate on reproduction.
In this block:
      # latent self attention

      for attn, ff, ln1, ln2 in self.latent_self_attns:
          latents = attn(ln1(latents), time=t) + latents
          latents = ln2(ff(latents, time=t) + latents)

I found that ln2(ff(latents, time=t) + latents) versus the more standard ff( ln2(latents), time=t) + latents makes it harder for the latent vector to explode.
Upon your comment I realize ln1 is redundant, so I'll try removing it

@Lamikins ohh got it, yes, SwinV2 actually uses that pattern, but they place the ln2 every 3rd transformer block

@Lamikins actually yea, it may make sense to have a norm just before cross attending from the image features to the latents, let me add that

@lucidrains @ajabri what is the value of K or num_layers_per_block or latent_self_attn_depth in the paper? I am unable to find, it is not given either in the appendix A or C.

@ajabri hi Allan, just saw this paper https://arxiv.org/abs/2301.10972
Sorry for doubting your results. Will be putting more work into RIN soon 🙏

@lucidrains hi Phil, can I ask what's the reason of adding input self conditioning? Did you find any performance increase from it? Since in the paper I see only latent self conditioning being used.

Hi Phil,
No worries, I understand. We didn’t run experiments on FFHQ because it’s
not allowed at Google. I didn’t have the compute to scale up to 1024x1024
ImageNet as an intern (Ting got more compute after I left), but as you can
see the model can handle even 16384 tokens with 256 latents.
I’d be happy to help out in reproducing the results with your repository —
would love to have a performant pytorch version.
Best,
Allan
On Fri, Jan 27, 2023 at 04:47 Phil Wang @.***> wrote:

@ajabri https://github.com/ajabri hi Allan, just saw this paper
https://arxiv.org/abs/2301.10972
Sorry for doubting your results. Will be putting more work into RIN soon
🙏
—
Reply to this email directly, view it on GitHub
https://github.com/lucidrains/recurrent-interface-network-pytorch/issues/2#issuecomment-1406016842,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBVLMOH5Y7Z5B4XXTOG5LWUNHOLANCNFSM6AAAAAATJSARBI
.
You are receiving this because you were mentioned.Message ID:
@.***
.com>

--
A.

@juvekaradheesh i can make that optional, was just improvising

No that's alright, I was just curious if it improved performance, to decide if I should keep it or not. But anyway, it might be dataset specific.

@lucidrains @ajabri I was able to reproduce the CIFAR 10 results using eps pred instead of x_0 pred in this repo. One challenge: because we use latent warm-starting, it's hard to get good results with smaller sampling steps. Sampling seems to require the latents to be "close" to the learned distribution, ie t-1 is very similar to t
Allan does this seem plausible? Any ideas on how to mitigate the effect?

Hi @Lamikins, For shorter sampling I found that DDIM works better. And yea, the way the latent self-condition is trained atm is a bit naive... it would be interesting to try unrolling the network, training it with different gaps between the latent self-cond, or using progressive distillation (perhaps with bptt). And yea, eps pred works significantly better; also good to use the lamb optimizer with weight decay on kernels and pos embeddings.

oh oops, i don't remember why i had predict x0 objective as default
will get the predict eps objective in there tomorrow morning! (as well as the resolution dependent noise schedules from Ting Chen)

Great ideas @ajabri, I'm investigating the bptt unrolling idea. I also think the latent shifting idea is good, but haven't been able to get it to work, will try again.
Phil here are the CIFAR10 generations I got after 70k steps at bs=512, AdamW 1e-3, eps_pred, DDIM 1000 steps. It took longer to train than I expected, around 12 hours on 1xa100, and I think I can achieve better results with another 12 hours. However, I calculated that it should only have taken ~6-12 hours total, assuming 1xa100 = 2x TPUv3 (3 hours on 8 chips). Let me know what results you are able to get.

Darius

@Lamikins LAMB optimizer with lr=1e-3 and wd on pos embeddings + kernels should work better. Sampling with 250 steps of DDIM should be decent. Should train for at least 150k steps (w/ bs=1024, so longer with bs=512).

Great ideas @ajabri, I'm investigating the bptt unrolling idea. I also think the latent shifting idea is good, but haven't been able to get it to work, will try again.
Phil here are the CIFAR10 generations I got after 70k steps at bs=512, AdamW 1e-3, eps_pred, DDPM 1000 steps. It took longer to train than I expected, around 12 hours on 1xa100, and I think I can achieve better results with another 12 hours. However, I calculated that it should only have taken ~6-12 hours total, assuming 1xa100 = 2x TPUv3 (3 hours on 8 chips). Let me know what results you are able to get.

Darius

yup it looks good
early generations look unfamiliar and checkerboardy given the patch training, but it converges nicely
i will try Ting Chen's logsnr shifting idea soon

@Lamikins LAMB optimizer with lr=1e-3 and wd on pos embeddings + kernels should work better. Sampling with 250 steps of DDIM should be decent. Should train for at least 150k steps (w/ bs=1024, so longer with bs=512). What kind of arch did you use?

hmm, i think LAMB is strictly a google thing, all the papers i've read suggests it doesn't do that much
but i'll stay open minded and look around for an open sourced implementation (or code up my own)

@lucidrains In case it might save you time, note that the logsnr shifting isn't necessary for images at 256 and below (only really helps significantly when going to 512 and 1024, and mainly for faster convergence). Also, you'll find that adamw converges to higher losses and worse sample metrics across the board; from my experience, LAMB is very useful when learning latent cross attention (see also use in Perceiver/PerceiverIO).

@lucidrains In case it might save you time, note that the logsnr shifting isn't necessary for images at 256 and below (only really helps significantly when going to 512 and 1024, and mainly for faster convergence). Also, you'll find that adamw converges to higher losses and worse sample metrics across the board; from my experience, LAMB is very useful when learning latent cross attention (see also use in Perceiver/PerceiverIO).

@ajabri will reread! thank you Allan!
yea, me and everyone else in the world is interested in 512 and 1024. consumers realistically don't care about 256 haha

@lucidrains yes ofc bigger is better  :) (and the main motivation for RIN) ... but training a 512/1024 model is ofc more expensive (e.g. the 1024px model was trained on 256-TPUv4 for 1M iterations), so may not be ideal for tuning.

@lucidrains actually some friends put together this open-sourced LAMB: https://github.com/cybertronai/pytorch-lamb
It's 3 years old and slow so it might be worth forking + updating

@ajabri some initial results using variable time-step latent conditioning:

I am able to get decent results using DPM++ and 20 sampling steps, not great yet. As expected this procedure degrades DDPM 1k sampling:

there is an interesting connection here between the latent conditioning + sampling procedure. I expect that tying latent conditioning to the sampling procedure will give much better results. We need to latents to be warm-started "around the local time-region" of each timestep.

ok, i've incorporated Ting Chen's findings in the latest version, so 512 / 1024 training for RIN should be optimal by setting the scale to be less than 1

@Lamikins  sorry I missed your message above, here are some useful hyper params for CIFAR-10:
Optimizer: LAMB with lr3e-3, cosine decay, weight decay of 0.01, dropout 0.1. Arch: 3 blocks of depth 2, 128 latents, 512 latent dim, 256 interface dim.

closing this issue, as mostly resolved except for the tangent on optimizers

Great ideas @ajabri, I'm investigating the bptt unrolling idea. I also think the latent shifting idea is good, but haven't been able to get it to work, will try again.
Phil here are the CIFAR10 generations I got after 70k steps at bs=512, AdamW 1e-3, eps_pred, DDPM 1000 steps. It took longer to train than I expected, around 12 hours on 1xa100, and I think I can achieve better results with another 12 hours. However, I calculated that it should only have taken ~6-12 hours total, assuming 1xa100 = 2x TPUv3 (3 hours on 8 chips). Let me know what results you are able to get.

Darius

@Lamikins What FID can you get on CIFAR10?

Hey @ajabri. I've tried to reproduce your results on CIFAR but i could not achieved the same speed performance that you have on the paper (3h on 8 TPUv3). I'm myself running on 8 V100 with global batch-size of 256 and doing 150k iteration. I'm using the configs you shared with 3 blocks of 2 modules. My training speed is around 4.5it/s. I'm curious if you had any tricks to speed up and what training speed you achieved? Thanks!

Hi Nicolas,
We've finally been able to open source the code:
Architecture: https://github.com/google-research/pix2seq/blob/main/architectures/tape.py
Image diffusion: https://github.com/google-research/pix2seq/blob/main/models/image_diffusion_model.py
CIFAR-10 config: https://github.com/google-research/pix2seq/blob/main/configs/config_diffusion_cifar10.py
Hope this helps!
Allan


Add configuration debugpyPath

When developping my project in specific environments, I want to use a specific executable of debugpy, like I can for formatting (e.g. black) or linting (e.g. flake8).
Or maybe just be able to let python pickup the available debugpy.
Current behavior: VS Code Python only use its own .vscode-server-insiders/extensions/ms-python.python-2020.10.332292344/pythonFiles/lib/python/debugpy/launcher
For now I have to use this setup to debug my projects:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Start debug (Nix)",
            "request": "launch",
            "type": "node-terminal",
            "command": "nix-shell --run 'python -m debugpy --listen localhost:5678 --wait-for-client -m myproject'",
            "env": {}
        },
        {
            "name": "Connect debug (Nix)",
            "type": "python",
            "request": "attach",
            "port": 5678,
        }
    ]
}

This is available, via debugAdapterPath.
        {
            "name": "Launch: program",
            "type": "python",
            "request": "launch",
            "console": "integratedTerminal",
            "program": "${file}",
            "debugAdapterPath": "<path-to-installed-libraries>/debugpy/adapter",
        },

You will see squiggles, since this is not exposed via launch.json schema. But it should work.

Thanks !
IMO "exposing debugAdapterPath to launch.json schema" should be the closing condition of this issue then.

We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

Thanks for your reply.
It seems to me that the functionality was already implemented before this feature request (https://github.com/microsoft/vscode-python/issues/14631#issuecomment-722550342)
Do you consider removing the debugAdapterPath attribute ?

Hi, Is this issue still available?

Hi, Is this issue still available?

@vvijayalakshmi21 yes

@vvijayalakshmi21 yes


Bumping httparty to 0.10.0

This removes yaml support while fixing an old vulnerability.

ship when 🍏


[Writers] STL files

@msermesant and one person from the LIRYC ask us if we can add an STL file exporter.
ITK has already functions to handle STL files https://itk.org/Doxygen/html/classitk_1_1STLMeshIO.html and
https://blog.kitware.com/writing-stl-files-from-itk-for-3d-printing/

As STL files represent meshes, I would rather use the VTK STL writer:
https://www.vtk.org/doc/nightly/html/classvtkSTLWriter.html
Maybe best to write as ASCII to ensure compatibility

Perfect!


Brenda's ask

getting rid of "a sustained"

@rishabv90 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@rishabv90: I'm sorry - only the author of this article, @brbell, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @rishabv90 -- This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make this content update in the private repo? We'll close this PR. Thanks.


Add unreferenced file cleanup count to merge stats

Description
Adding stats for unreferenced files cleanup count on segment merge failure due to disk full.
unreferenced_file_cleanup.count: Number of times unreferenced files are cleaned up on segment merge failures.
"indices": {
        "merges": {
          "current": 0,
          "current_docs": 0,
          "current_size_in_bytes": 0,
          "total": 0,
          "total_time_in_millis": 0,
          "total_docs": 0,
          "total_size_in_bytes": 0,
          "total_stopped_time_in_millis": 0,
          "total_throttled_time_in_millis": 0,
          "total_auto_throttle_in_bytes": 101044596,
          "unreferenced_file_cleanup": {
            "count": 2
          }
        }
      }

Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RS146BIJAY let us also add an assert to validate rollup of unreferenced_file_cleanup.count at various levels. We may already have some test(s) for this.

@RS146BIJAY we would also need to open an issue/PR in https://github.com/opensearch-project/documentation-website for updating the docs for the respective node/index/cluster stats APIs to account for this change once merged

@RS146BIJAY we would also need to open an issue/PR in https://github.com/opensearch-project/documentation-website for updating the docs for the respective node/index/cluster stats APIs to account for this change once merged

This information resides in Lucene and OpenSearch does not have any info about the files that are cleaned up. So we cannot add a metrics for the same.

This information resides in Lucene and OpenSearch does not have any info about the files that are cleaned up. So we cannot add a metrics for the same.

@RS146BIJAY then where will this metric be shown, i.e. which API? Based on the PR description and code changes, it appears to be related to index/nodes stats APIs. The docs would need to reflect any new fields being added to the API response.

This information resides in Lucene and OpenSearch does not have any info about the files that are cleaned up. So we cannot add a metrics for the same.

@RS146BIJAY then where will this metric be shown, i.e. which API? Based on the PR description and code changes, it appears to be related to index/nodes stats APIs. The docs would need to reflect any new fields being added to the API response.

Clarified offline on this. Will update docs as well.


Error after updating

Hi, after updating I had the following error:
Argument 2 passed to Maatwebsite\LaravelNovaExcel\Actions\ExportToExcel::replaceFieldValuesWhenOnResource() must be of the type array, null given, called in /Users/danieljones/Dev/newforest-rustic-furniture/vendor/maatwebsite/laravel-nova-excel/src/Actions/ExportToExcel.php on line 242 {"userId":1,"email":"daniel@groundup.consulting","exception":"[object] (Symfony\Component\Debug\Exception\FatalThrowableError(code: 0): Argument 2 passed to Maatwebsite\LaravelNovaExcel\Actions\ExportToExcel::replaceFieldValuesWhenOnResource() must be of the type array, null given, called in /Users/danieljones/Dev/newforest-rustic-furniture/vendor/maatwebsite/laravel-nova-excel/src/Actions/ExportToExcel.php on line 242 at /Users/danieljones/Dev/newforest-rustic-furniture/vendor/maatwebsite/laravel-nova-excel/src/Actions/ExportToExcel.php:282)
[stacktrace]
I am now running version 1.1.0 up from 1.0.6.

Can you show your code please. It seems your export hasn't "selected" any fields to be exported.

@patrickbrouwers
/**
 * Get the actions available for the resource.
 *
 * @param  \Illuminate\Http\Request  $request
 * @return array
 */
public function actions(Request $request)
{
    return [
        (new DownloadExcel)
            ->withHeadings()
            ->allFields(),
    ];
}

what's in your fields() array ? ->allFields() is supposed to build up a list of fields from there.
Also ->allFields() is the default behaviour, so you can also remove that call :)

on the original resource I had it on:
/**
     * Get the fields displayed by the resource.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array
     */
    public function fields(Request $request)
    {
        return [
            ID::make()->sortable(),
            Text::make('Name', 'name')->sortable(),

            new Panel('Shopify', $this->shopifyFields()),
            new Panel('Amazon', $this->amazonFields()),
            new Panel('Wayfair', $this->wayfairFields()),

            BelongsToMany::make('Orders'),
        ];
    }

    /**
     * Get the shopify fields for the resource.
     *
     * @return array
     */
    protected function shopifyFields()
    {
        return [
            Text::make('Shopify SKU', 'shopify_sku')
                ->sortable()
                ->hideFromIndex(),
            Text::make('Shopify Product ID', 'shopify_product_id')
                ->sortable()
                ->hideFromIndex(),
            Text::make('Shopify Variant ID', 'shopify_variant_id')
                ->sortable()
                ->hideFromIndex(),
            ExternalUrl::make('Edit on Shopify', function () {
                    if ($this->shopify_product_id == null || $this->shopify_product_id == "") {
                        return null;
                    }

                    $link = "https://new-forest-rustic-furniture-ltd.myshopify.com/admin/products/{$this->shopify_product_id}";

                    if ($this->shopify_variant_id != null && $this->shopify_variant_id != "") {
                        $link = $link . "/variants/{$this->shopify_variant_id}";
                    }

                    return $link;
                })
                ->hideFromIndex(),
        ];
    }

    /**
     * Get the amazon fields for the resource.
     *
     * @return array
     */
    protected function amazonFields()
    {
        return [
            Text::make('Amazon ASIN', 'amazon_asin')
                ->sortable()
                ->hideFromIndex(),
            Text::make('Amazon SKU', 'amazon_sku')
                ->sortable()
                ->hideFromIndex(),
            Text::make('Amazon Marketplace ID', 'amazon_marketplace_id')
                ->sortable()
                ->hideFromIndex(),
            ExternalUrl::make('Edit on Amazon', function () {
                    if ($this->amazon_asin == null || $this->amazon_asin == "") {
                        return null;
                    }

                    if ($this->amazon_sku == null || $this->amazon_sku == "") {
                        return null;
                    }

                    $link = "https://catalog-sc.amazon.co.uk/abis/product/DisplayEditProduct?sku={$this->amazon_sku}&asin={$this->amazon_asin}";

                    if ($this->amazon_marketplace_id != null && $this->amazon_marketplace_id != "") {
                        $link = $link . "&marketplaceID=A1F83G8C2ARO7P{$this->amazon_marketplace_id}";
                    }

                    return $link;
                })
                ->hideFromIndex(),
        ];
    }

    /**
     * Get the wayfair fields for the resource.
     *
     * @return array
     */
    protected function wayfairFields()
    {
        return [
            Text::make('Wayfair SKU', 'wayfair_sku')
                ->sortable()
                ->hideFromIndex(),
            ExternalUrl::make('Edit on Wayfair', function () {
                    if ($this->wayfair_sku == null || $this->wayfair_sku == "") {
                        return null;
                    }

                    return "https://partners.wayfair.com/v/product_catalog/manage_product_description/index?skus={$this->wayfair_sku}";
                })
                ->hideFromIndex(),
        ];
    }

but I have simpler models like users which it isn't working on either:
public function fields(Request $request)
    {
        return [
            ID::make()->sortable(),

            Gravatar::make(),

            Text::make('Name')
                ->sortable()
                ->rules('required', 'max:255'),

            Text::make('Email')
                ->sortable()
                ->rules('required', 'email', 'max:254')
                ->creationRules('unique:users,email')
                ->updateRules('unique:users,email,{{resourceId}}'),

            Password::make('Password')
                ->onlyOnForms()
                ->creationRules('required', 'string', 'min:6')
                ->updateRules('nullable', 'string', 'min:6'),
        ];
    }

I just changed the users field to use:
public function actions(Request $request)
    {
        return [
            (new DownloadExcel)
                ->withHeadings()
                ->only('name', 'email'),
        ];
    }

but its now giving the following error when opening:

Your first problem is due to ->allFields() . allFields in the past referred to exporting all database columns.  Removing that, should export all fields visible on the index screen.
For your new problem, how is your file name? It seems something wrong with the extension.

The exports look fine in their names?
is there a simple all for all DB columns or do I need to specify this on all resources now manually?

Weirdly, I can view to contents of the broken exports in text-edit, but the non broken ones are locked and wont show their contents?

, the broken file has an empty line at the start of the file

That's a known issue of PhpSpreadsheet. You most likely have an empty line or whitespace in front of a <?php opening tag. It could be in any file in your project.
For the allFields() I've released a patch release, that makes it work again.

@patrickbrouwers aha! yeah there was a whitespace in one of my configs, thanks for the tip there!
Also thanks for adding that back, I should probably define the fields explicitly anyway, but it's a nice helper for testing!

@DanielDarrenJones great! Happy you found it so quickly :)
Yes explicit would for sure be better :)


Is getting the size of the journal possible?

Would be good to know for monitoring purposes how much data is in the journal. (I'm attempting to use it as a queue)

that would be interessting to know, yes ..


Duplicate event assets loose all tags except archive

In Opencast 13, when one duplicates an event, the assets lose all tags. The lost tags appear as null.
Here is a screenshot of the problem:
The original event:

Duplicate:

On the admin API:
GET /{eventId}/asset/attachment/attachments.json
The original event:
Status: 200 (success)

[
  {
    "mimetype": "text/xml",
    "id": "security-policy-episode",
    "type": "security/xacml+episode",
    "url": "https://oc.url/assets/assets/f967fed9-c4df-48d9-92c5-7a7c3022a7dc/security-policy-episode/4/xacml.xml",
    "tags": [
      "archive",
      "engage-download"
    ]
  },
  {
    "mimetype": "text/xml",
    "id": "security-policy-series",
    "type": "security/xacml+series",
    "url": "https://oc.url/assets/assets/f967fed9-c4df-48d9-92c5-7a7c3022a7dc/security-policy-series/4/xacml.xml",
    "tags": [
      "archive",
      "engage-download"
    ]
  },
  {
    "mimetype": "text/xml",
    "id": "281de8d1-6a9a-49f0-b9ad-66f71dafdc19",
    "type": "processing/defaults",
    "url": "https://oc.url/assets/assets/f967fed9-c4df-48d9-92c5-7a7c3022a7dc/281de8d1-6a9a-49f0-b9ad-66f71dafdc19/4/processing-properties.xml",
    "tags": [
      "archive"
    ]
  },
  {
    "mimetype": "image/png",
    "id": "aabe7870-d558-48d3-80f4-effa2f1a1c2d",
    "type": "presentation/player+preview",
    "url": "https://oc.url/assets/assets/f967fed9-c4df-48d9-92c5-7a7c3022a7dc/aabe7870-d558-48d3-80f4-effa2f1a1c2d/4/coverimage.png",
    "tags": [
      "archive",
      "engage-download"
    ]
  }
]

Duplicate:
[
  {
    "mimetype": "text/xml",
    "id": "cd4c4a47-f5e7-4c11-abbc-b48487ed2b24",
    "type": "security/xacml+episode",
    "url": "https://oc.url/assets/assets/9020dacf-87b3-4427-98c0-9ab13c79b3a3/cd4c4a47-f5e7-4c11-abbc-b48487ed2b24/0/xacml.xml",
    "tags": [
      "archive",
      "null"
    ]
  },
  {
    "mimetype": "text/xml",
    "id": "363e76a0-9e99-411e-ade5-0ef4c5433dce",
    "type": "security/xacml+series",
    "url": "https://oc.url/assets/assets/9020dacf-87b3-4427-98c0-9ab13c79b3a3/363e76a0-9e99-411e-ade5-0ef4c5433dce/0/xacml.xml",
    "tags": [
      "archive",
      "null"
    ]
  },
  {
    "mimetype": "text/xml",
    "id": "4d331672-56ba-40d2-b059-7d3af8b30af6",
    "type": "processing/defaults",
    "url": "https://oc.url/assets/assets/9020dacf-87b3-4427-98c0-9ab13c79b3a3/4d331672-56ba-40d2-b059-7d3af8b30af6/0/processing-properties.xml",
    "tags": [
      "archive",
      "null"
    ]
  },
  {
    "mimetype": "image/png",
    "id": "a6f01fd2-3e5c-44d0-815a-11cc597593cb",
    "type": "presentation/player+preview",
    "url": "https://oc.url/assets/assets/9020dacf-87b3-4427-98c0-9ab13c79b3a3/a6f01fd2-3e5c-44d0-815a-11cc597593cb/0/coverimage.png",
    "tags": [
      "archive",
      "null"
    ]
  }
]

To Reproduce
Steps to reproduce the behavior:

Create an event
Duplicate the event with a workflow that adds more tags than archive
See error

Expected behavior
Tags should be preserved in the copy
Server environment:

OS: Rocky linux 9
Distribution:Admin
Installation method: RPM
Version 13

I just found the issue, it was related to the conversion between xml to yaml.


Investigate if parts of the codebase can leverage other libraries code

Problem Description
We have some custom implementations of pretty basic functionality code which is often done better by other libraries that are already part of the required libraries to run Probatus. Maybe this would allow us to clean up more code and use more optimized functions instead.
Desired Outcome
Replace functions which are better done in the respective libraries as compared to some of the custom implementations in Probatus
Solution Outline
Investigate code, especially code which hasn't been updated recently. Find which functions can be replaced and do so.

@PaulZhutovsky The scoring.py allows us to define multiple scorers. This might be an interesting use-case. I am not certain yet if this is something we want to expand on or not. Maybe something to consider before thinking of replacing it with a simple sklearn implementation because that would inadvertently change it so just a single scorer.

After another investigation, the Probatus implementation seems the most elegant for getting the name of the scorer since Sklearn does not provide that functionality. It only allows us to get the names of all possible scorers, but not the name given a scorer. @PaulZhutovsky


fix: Improved the boxes and made it adjustable to the texts in the gita storyline

Fixes #1312
Screenshot-

Great! Work...


Change import statement to allow direct importing swagger files

Spec:
import FILENAME [as [PACKAGE_NAME.]APP_NAME] [~MODE] [# comments...]
where:
FILENAME - path to the file to import (i.e backend.yaml)
The following is required if importing non-sysl files
PACKAGE_NAME (optional) - Package name of the generated sysl
APP_NAME - Name of the application of the generated sysl
MODE - import mode, empty is guess based on the extension,
	currently supported:
		~swagger

Fixes # .
Changes proposed in this pull request:

@anz-bank/sysl-developers

@anzdaddy If you're happy with this approve and merge please, no need to wait till wednesday for merge if green ticks.

@nofun97 fyi