[FEA] Qualification tool: Operator mapping, check if execs/expressions off by default

Is your feature request related to a problem? Please describe.
This is follow on from the discussion https://github.com/NVIDIA/spark-rapids/pull/5298#discussion_r856214693 . We need to figure out a good way to get the configs that are set for certain execs.

Synced with @tgravescs on this. We are checking expressions and Execs which are OFF by default in GpuOverrides from the disabledMsg . Other than these, we don't see any important configs OFF by default in https://nvidia.github.io/spark-rapids/docs/configs.html .
We will parse more information from the eventlog and update individual Execs parser in https://github.com/NVIDIA/spark-rapids/issues/6064. i.e for BHJ, we will use the tagging logic to check if a certain joinType is supported.
Closing this issue.


Not working in new U/I of GAS

Hi,
There is an issue while getting all projects from Bitbucket in new U/I of GAS & I am getting the below error as:
[github assistant] TypeError: Cannot read property 'forEach' of undefined
Not Able to view all projects' branch and no action on push & pull.

Same here. I also used it with Bitbucket. It worked like a charm, but I always getting this error on pageload for few weeks. Apps Script APi enabled, I checked.

I am getting the following error when trying to push to a repo:
[github assistant] undefined
I have already tried to uninstall and reinstall the app.  Is this app still not working because Google has not yet approved it?

Maybe you have recreated the Github GAS Token?
Log out of the Google Apps Script GitHub Assistant first, then log in again with a new token to fix it.

Although my token was set to never expire, creating a new one fixed this for me.


Where is the source code?

 November 2021. Where is the rest? I mean, there are older releases on PyPI and there are newer testing versions. Where can I find the source for all previous releases?

Hi @SammysHP,
GitHub source is published as a snapshot of an unzipped wheel - this is not optimal, but it is the workflow we are using for now.
To get 'previous source' you can always download the wheels and unzip them.
Anything in particular you are looking for??

Thank you, @xedbg. This workflow makes forking and contributions from the community much more difficult because you have no hierarchy of commits that you can track, but on the other hand the community is rather small.
Nothing in particular, I was just confused that I couldn't find previous revisions or the latest development in this repository. If it is your policy to develop in private and just publish snapshots, that's fine, just a little bit weird.

@SammysHP I understand and do agree that its not conducive to contributions.
We rely on pymcuprog for regression test purposes for Curiosity Nanos, and that it still our primary use-case, which is reflected in that workflow.  (And also makes us less open to architectural changes which might be proposed.) Maybe one day we will adjust this though.
I have in the past taken PRs in by generating a patch, applying it to our bitbucket repo internally, and then the tweak gets released outward again - this is also how we use test.pypi as a way to publish changes which we can't test properly ourselves.


Report types can now be selected for rule. Fixes #54

@falko could you also look at this PR, please? I'm unsure if I need to write a test on it, because the changes are very simple and I've tested in manually.

@falko could you also look at this PR, please? I'm unsure if I need to write a test on it, because the changes are very simple and I've tested in manually.

@falko, thank you! Done!

@falko I'd also would like to ask: are there any plans for release? I've seen that the latest release was in 2017, can I hope that my PR will be released?

I might push a release out to get Spring Boot support for 7.13 done. But no timeline yet. It depends on the progress with the archetypes.


feat(dev): make the Clouseau development flow more flexible

This change features a set of extensions to the integration of Clouseau in the developer setup, added in 2d8a33b9:

Introduce the --clouseau-dir option for the ./dev/run script to allow for ad-hoc integration of Clouseau with CouchDB, even without being configured previously.  This facilities experimentation with various alternatives and lets the user switch between them with ease.

The directory specified by --clouseau-dir could either hold an unpacked set of JAR files or git clone of the Clouseau source code.  The script can automagically determine which version is being used and invoke Apache Maven to compile the sources and launch the nodes with the proper classpath.  In this latter case, check for JDK 1.7 because that is the edition that could be used for compiling the sources currently.

Modify the ./configure script to support deploying locally a specific branch of Clouseau's git clone instead of a tagged release.

Adjust the Makefiles to set --clouseau-dir by the CLOUSEAU_DIR variable.

Testing recommendations
This change is backwards compatible with the additions of the original commit.  The new scenarios that are worth trying could be the following.

Run ./dev/run without Clouseau being configured by ./configure, using --clouseau-dir (together with --with-clouseau).
Configure a Clouseau release locally and override it with --clouseau-dir.
Configure a branch of the Clouseau source code repository or one of its forks for local use.
Run Clouseau through the elixir-search and mango-test make targets.
Use everything as before (to verify backwards compatibility).

I created a ~/repos/clouseau/log4j.properties based on the one that the configure script creates, and this time it worked!

@jaydoane did you feel it inconvenient that you had to create those files yourself?  I am asking because I have been pondering about having the clouseau.ini and log4j.properties files automatically created by ./dev/run when they are missing.  My motivation is that users should not peek into the sources to figure out what kind of files are needed.  But provide them with sane defaults that they can tune further.  I am a bit unsure though if that is over-engineering here.

I created a ~/repos/clouseau/log4j.properties based on the one that the configure script creates, and this time it worked!

@jaydoane did you feel it inconvenient that you had to create those files yourself? I am asking because I have been pondering about having the clouseau.ini and log4j.properties files automatically created by ./dev/run when they are missing. My motivation is that users should not peek into the sources to figure out what kind of files are needed. But provide them with sane defaults that they can tune further. I am a bit unsure though if that is over-engineering here.

It was moderately inconvenient, but the error messages were clear enough to make progress. I don't think it's necessarily over-engineering to generate those files, however. Maybe output some text that they are being generated if they are missing?

the error messages were clear enough to make progress

In my experience, the format of these files could be tricky to get right without some external help therefore it might be a nuisance for the first-time user.

I don't think it's necessarily over-engineering to generate those files, however. Maybe output some text that they are being generated if they are missing?

Yes, that is a good idea.

@rnewson are you okay with the current version?


Getting started docs

Hey, I just made a Pull Request!
I was working through the Getting Started tutorial and noticed a couple of inconsistencies that could be corrected.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks @tim775!

Congrats on your first PR merged @tim775! Happy to count you as a contributor.


Question: How do we give a fixed size for the canvas?

Firstly thanks for the wonderful package. I would want to know if we can set the height and width of the canvas itself. Currently, we can scroll infinitely and I need to restrict this.

Hello, thanks for the feedback.
I haven't tested this feature but there is a function setPosition in CanvasStateWriter. So you can set the position to your limit if a user scrolls the canvas more.


A JSONArray text must start with '[' at 1 [character 2 line 1]

We are using the client to submit a trigger using the following code:

            Payload payload = Payload.Builder.newBuilder()
                    .setSummary(createSummary(operation))
                    .setSource(operation.getAttribute().getId())
                    .setComponent(IdManager.getAncestorId(IdManager.Service.NODE_NODE, operation.getAttribute().getId()))
                    .setGroup(IdManager.getAncestorId(IdManager.Service.NODE_ECU, operation.getAttribute().getId()))
                    .setSeverity(convertHealthToSeverity(operation.getAttribute().getHealth()))
                    .setTimestamp(OffsetDateTime.ofInstant(Instant.ofEpochSecond(operation.getTimestamp()), ZoneOffset.UTC))
                    .setCustomDetails(Json.writeValueToString(operation.getAttribute()))
                    .build();

            TriggerIncident incident = TriggerIncident.TriggerIncidentBuilder
                    .newBuilder(routingKey, payload)
                    .setDedupKey(operation.getAttribute().getId())
                    .setClient(client)
                    .build();

           this.client.trigger(incident);

The serialized incident as a json looks like this:
{
    "client":"--removed_for_security--",
    "dedup_key":"cu3fbbe4-ne30773e-nnd17182-na11f804",
    "event_action":"trigger",
    "payload":{
       "component":"cu3fbbe4-ne30773e-nnd17182",
       "custom_details":"{\"ecuId\":\"cu3fbbe4-ne30773e\",\"health\":500,\"id\":\"cu3fbbe4-ne30773e-nnd17182-na11f804\",\"nodeId\":\"cu3fbbe4-ne30773e-nnd17182\",\"projectId\":\"cu3fbbe4-np932c1d\",\"read\":{\"type\":\"STRING\"},\"reference\":\"s1_server_disconnected_on_system_initialisation_alarm!\",\"value\":\"Critical\"}",
       "group":"cu3fbbe4-ne30773e",
       "severity":"critical",
       "source":"cu3fbbe4-ne30773e-nnd17182-na11f804",
       "summary":"The value of 's1_server_disconnected_on_system_initialisation_alarm' changed to Critical",
       "timestamp":"2022-07-29T13:45:32Z"
    },
    "routing_key":"--removed_for_security--"
 }

However, we are unexpectedly getting the following error:
com.github.dikhan.pagerduty.client.events.exceptions.NotifyEventException: com.mashape.unirest.http.exceptions.UnirestException: java.lang.RuntimeException: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1]

Any ideas?

After digging into the code and following the stack trace I found the error is originating from PagerDutyEventsClient.main(...) on line 80.
This is very random as main seems to be a test class!
public static void main(String[] args) throws NotifyEventException {
        String routingKey = "ROUTING_KEY";
        String dedupKey = "DEDUP_KEY";

        PagerDutyEventsClient pagerDutyEventsClient = create();

        JSONObject customDetails = new JSONObject();
        customDetails.put("field", "value1");
        customDetails.put("field2", "value2");

        Payload payload = Payload.Builder.newBuilder()
                .setSummary("This is an incident test to test PagerDutyEventsClient")
                .setSource("testing host")
                .setSeverity(Severity.INFO)
                .setTimestamp(OffsetDateTime.now())
                .setCustomDetails(customDetails)
                .build();

        List<ImageContext> imageContextList = new ArrayList<>();
        imageContextList.add(new ImageContext("src1"));
        List<LinkContext> linkContextList = new ArrayList<>();
        linkContextList.add(new LinkContext("href", "text"));

        TriggerIncident incident = TriggerIncident.TriggerIncidentBuilder
                .newBuilder(routingKey, payload)
                .setDedupKey(dedupKey)
                .setClient("client")
                .setClientUrl("https://monitoring.example.com")
                .setLinks(linkContextList)
                .setImages(imageContextList)
                .build();

        pagerDutyEventsClient.trigger(incident);

        AcknowledgeIncident ack = AcknowledgeIncident.AcknowledgeIncidentBuilder
                .newBuilder(routingKey, dedupKey)
                .build();
        pagerDutyEventsClient.acknowledge(ack);

        ResolveIncident resolve = ResolveIncident.ResolveIncidentBuilder
                .newBuilder(routingKey, dedupKey)
                .build();
        pagerDutyEventsClient.resolve(resolve);

        ChangeEventPayload changeEventPayload = ChangeEventPayload.Builder.newBuilder()
                .setSummary("This is an change event test to test PagerDutyEventsClient")
                .setSource("testing host")
                .setTimestamp(OffsetDateTime.now())
                .setCustomDetails(customDetails)
                .build();

        ChangeEvent changeEvent = ChangeEvent.ChangeEventBuilder
                .newBuilder(routingKey, changeEventPayload)
                .setLinks(linkContextList)
                .build();

        pagerDutyEventsClient.trackChange(changeEvent);
    }

Line 80 in this is:
ChangeEvent changeEvent = ChangeEvent.ChangeEventBuilder
                .newBuilder(routingKey, changeEventPayload)
                .setLinks(linkContextList)
                .build();

So it appears that the error is caused with this static test class and not even our payload.

So we updated the version to 3.1.2 which seems to be the latest version on maven. The error persists but it now seems to be originating from the response from pager duty:
 private EventResult notifyEvent(PagerDutyEvent event, String api, int retryCount) throws NotifyEventException {
        try {
            HttpRequestWithBody request = Unirest.post(api)
                    .header("Content-Type", "application/json")
                    .header("Accept", "application/json");
            request.body(event);
            HttpResponse<JsonNode> jsonResponse = request.asJson();

            if (log.isDebugEnabled()) {
                log.debug(IOUtils.toString(jsonResponse.getRawBody()));
                // A reset, so we can get the contents from the body that were dumped in the log before
                jsonResponse.getRawBody().reset();
            }

            int responseStatus = jsonResponse.getStatus();
            switch(responseStatus) {
                case HttpStatus.SC_OK:
                case HttpStatus.SC_CREATED:
                case HttpStatus.SC_ACCEPTED:
                    return EventResult.successEvent(JsonUtils.getPropertyValue(jsonResponse, "status"), JsonUtils.getPropertyValue(jsonResponse, "message"), JsonUtils.getPropertyValue(jsonResponse, "dedup_key"));
                case HttpStatus.SC_BAD_REQUEST:
                    return EventResult.errorEvent(JsonUtils.getPropertyValue(jsonResponse, "status"), JsonUtils.getPropertyValue(jsonResponse, "message"), JsonUtils.getArrayValue(jsonResponse, "errors"));
                case RATE_LIMIT_STATUS_CODE:
                case HttpStatus.SC_INTERNAL_SERVER_ERROR:
                    if (doRetries) {
                        return handleRetries(event, api, retryCount, jsonResponse, responseStatus);
                    } else {
                        return EventResult.errorEvent(String.valueOf(responseStatus), "", IOUtils.toString(jsonResponse.getRawBody()));
                    }
                default:
                    return EventResult.errorEvent(String.valueOf(responseStatus), "", IOUtils.toString(jsonResponse.getRawBody()));
            }
        } catch (UnirestException | IOException e) {
            throw new NotifyEventException(e);
        }
    }

The stack does not show which line is causing it but i'm guessing its coming from HttpResponse<JsonNode> jsonResponse = request.asJson();

same here

Any update here?

Any update here?

Version 3.0.8 works for me

3.0.8 not working for me 🙁

Same here, in 3.1.2.
Full trace:
com.github.dikhan.pagerduty.client.events.exceptions.NotifyEventException: com.mashape.unirest.http.exceptions.UnirestException: java.lang.RuntimeException: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1] 	at com.github.dikhan.pagerduty.client.events.HttpApiServiceImpl.notifyEvent(HttpApiServiceImpl.java:106) 	at com.github.dikhan.pagerduty.client.events.HttpApiServiceImpl.notifyEvent(HttpApiServiceImpl.java:70) 	at com.github.dikhan.pagerduty.client.events.PagerDutyEventsClient.sendEvent(PagerDutyEventsClient.java:208) 	at com.github.dikhan.pagerduty.client.events.PagerDutyEventsClient.trigger(PagerDutyEventsClient.java:188) 	[...] Caused by: com.mashape.unirest.http.exceptions.UnirestException: java.lang.RuntimeException: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1] 	at com.mashape.unirest.http.HttpClientHelper.request(HttpClientHelper.java:143) 	at com.mashape.unirest.request.BaseRequest.asJson(BaseRequest.java:68) 	at com.github.dikhan.pagerduty.client.events.HttpApiServiceImpl.notifyEvent(HttpApiServiceImpl.java:79) 	... 18 more Caused by: java.lang.RuntimeException: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1] 	at com.mashape.unirest.http.HttpResponse.<init>(HttpResponse.java:106) 	at com.mashape.unirest.http.HttpClientHelper.request(HttpClientHelper.java:139) 	... 20 more Caused by: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1] 	at com.mashape.unirest.http.JsonNode.<init>(JsonNode.java:51) 	at com.mashape.unirest.http.HttpResponse.<init>(HttpResponse.java:95) 	... 21 more Caused by: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1] 	at org.json.JSONTokener.syntaxError(JSONTokener.java:433) 	at org.json.JSONArray.<init>(JSONArray.java:105) 	at org.json.JSONArray.<init>(JSONArray.java:144) 	at com.mashape.unirest.http.JsonNode.<init>(JsonNode.java:48) 	... 22 more
any idea @dikhan?

Probably an error in the Unirest HTTP client com.mashape.unirest.unirest-java. Maybe an upgrade to com.konghq.unirest-java is possible @dikhan?

See Pull request https://github.com/dikhan/pagerduty-client/pull/32 issue appears if payload isn't json but an error string

@machajdik @DodoMorph @salml I am still getting this issue.
Can we please publish a new package ?


gzip

So it would be cool to have all js and css gzipped by default. In case, we may want to have a setting to disable it on the component level? (not sure it is needed).
Gzip support: http://schroepl.net/projekte/mod_gzip/browser.htm

I guess this could be as simple as including the compression module: https://github.com/expressjs/compression

Well I want gzip also on compiled views and css and js files during packaging. We already use tar.gz as dependency to do other stuff, if we gzip the stuff before uploading to cdn too then this should be a good win

So what's the idea for the CSS/JS. If we gzip it and throw it onto the CDN during publish, how do we reference it in the browser?
How do we tell the CDN to transfer the content with the correct type?

So, in theory we reference it in the same way and we publish it in the same way using the usual Content-Type header (depending on file's type). Then, we need to ensure content comes back from CDN with an additional Accept-Encoding: gzip header (the browser should handle it). It doesn't look like a tricky thing to do as soon as we define a standard and simple way to do it.

"You also need to develop your application to intercept viewer requests and change the request URL based on whether the request includes an Accept-Encoding: gzip header."
...
"Your application determines that Accept-Encoding: gzip appears in the request header and changes the CloudFront URL to request the compressed version of the file."
For requesting the template, that would probably be OK, the registry can just say 'if the client supports gzip then add the .gz extension to the template path'. But for static css/js assets (referenced from template.js) then it's going to be nasty.

Closing this as is solved.


[TASK] re-key dataExtension that was aito generated by event

Maybe to event key + "_event"

already done


Add a Makefile

This commit replaces the top-level clean script with a Makefile that
can be used to centralise project-level build commands.
It also provides a make serve task to serve the contents of the
docs/html directory locally.
A word of warning: make clean, and the prior clean script, both
remove docs/html. It's not immediately clear how to regenerate it.
Once we know how to do that, the relevant task can be added to the
Makefile.

I'm closing this due inactivity.

Ah, damn. I've not been getting notifications. I can see we've got another toplevel Makefile that does the clean bit now, so I guess the best thing to do might be to transplant the serve task to a new PR.


Lack of some files of thefuck

I downloaded the thefuck(version 1.3.2) yesterday and get the problem at the bottom.
what should I do?  Is that thefuck's problem or it's my python and pip broken?
I use brew to install my python on my Mac OSX(Yosemite)and the version of python is 2.7.6.
I have followed the two step below
sudo pip install thefuck

alias fuck='eval $(thefuck $(fc -ln -1))'
# You can use whatever you want as an alias, like for Mondays:
alias FUCK='fuck'

Traceback (most recent call last):
  File "/usr/local/bin/thefuck", line 9, in <module>
    load_entry_point('thefuck==1.32', 'console_scripts', 'thefuck')()
  File "/Library/Python/2.7/site-packages/thefuck/main.py", line 134, in main
    matched_rule = get_matched_rule(command, rules, settings)
  File "/Library/Python/2.7/site-packages/thefuck/main.py", line 81, in get_matched_rule
    for rule in rules:
  File "/Library/Python/2.7/site-packages/thefuck/main.py", line 39, in get_rules
    loaded_rule = load_rule(rule)
  File "/Library/Python/2.7/site-packages/thefuck/main.py", line 24, in load_rule
    rule_module = load_source(rule.name[:-3], str(rule))
  File "/Library/Python/2.7/site-packages/thefuck/rules/brew_unknown_command.py", line 69, in <module>
    brew_commands += _get_brew_tap_specific_commands(brew_path_prefix)
  File "/Library/Python/2.7/site-packages/thefuck/rules/brew_unknown_command.py", line 36, in _get_brew_tap_specific_commands
    for user in _get_directory_names_only(brew_taps_path):
  File "/Library/Python/2.7/site-packages/thefuck/rules/brew_unknown_command.py", line 61, in _get_directory_names_only
    return [d for d in os.listdir(path)
OSError: [Errno 2] No such file or directory: '/usr/local/Library/Taps'

Try to upgrade to 1.34+, probably fixed.

I finally found that it was the problem about path.
'/usr/local/Library/Taps'--->This folder isn't exist, so I mkdir a empty folder named:Taps and then solved.
Thank you.


encode is inconsistent and wrong

I'm using this on a RPi4 running Ubuntu 18. This is in a jupyter notebook, python 3.7.5, but same issue running from a flask application I'm developing on the same Pi.
The following code
from pylibdmtx.pylibdmtx import encode
encoded = encode('5e78e9945f627d09ca1c28a7')
#print(dir(encoded))
bc = Image.frombytes('RGB', (encoded.width, encoded.height), encoded.pixels)
bc

Produces slightly different barcode every time, and the barcode decodes with a commercial scanner to an incomplete portion of the encode string, usually something like:
78e9

Treepoem works to generate the barcode and it is read correctly, but is quite dependency heavy and slow.
tp = treepoem.generate_barcode(barcode_type="datamatrix", data='5e78e9945f627d09ca1c28a7')
tp

I am hoping I'm somehow using the encode method wrong or there is some simple fix so I can go back to using pylibdmtx
Thanks

It seems like the example on https://pypi.org/project/pylibdmtx/ is wrong - you can't just pass a string. You have to convert it to bytes first.

text = "This is some test data!" encoded = encode(text.encode('utf-8'))
audoh is right. I had the same problem. This fixed it.


doc:http pkg variables info added in pull cmd

- What I did
Note added about the $NO_PROXY $HTTP_PROXY for http pkg will be indicated when engine open connection to registry, for #10972
- How I did it
Insert a note section in /docker/docs/reference/commandline/pull.md
- How to verify it
Direct to /docker/docs/reference/commandline/pull.md to verify the changeset
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Lin Lu<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "10972-docs-Support-for-non-proxied-private-registry" git@github.com:DoraALin/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

PR udpated.

thanks! changes LGTM, but I see there's now a merge commit in this PR. Can you rebase your PR, to get rid of the merge commit? Some information about that can be found in our contributors guide; https://docs.docker.com/opensource/workflow/work-issue/#pull-and-rebase-frequently

@thaJeztah. PR updated. Characters in statement is reduced per your suggestion.

@DoraALin oh! I think you misunderstood! The text was good, just meant to wrap the line-length to 80 characters :blush:

@thaJeztah,
PR updated. Characters per line is under 80 now, for your review ：）

Thanks! LGTM
ping @vdemeester for the merge :)

LGTM 🐯


Force elasticsearch-slm cronjob to use integers

What this PR does / why we need it:
Bug fix
Which issue this PR fixes (use the format fixes #<issue number>(, fixes #<issue_number>, ...) to automatically close the issue when PR gets merged):
fixes #339
Public facing documentation PR (if applicable)

Special notes for reviewer:
Checklist:

[x] Added relevant notes to WIP-CHANGELOG.md
[x] Proper commit message prefix on all commits
[ ] Updated the public facing documentation
Is this changeset backwards compatible for existing clusters? Applying:

[x] is completely transparent, will not impact the workload in any way.
[ ] requires running a migration script.
[ ] will create noticeable cluster degradation.
E.g. logs or metrics are not being collected or Kubernetes API server
will not be responding while upgrading.
[ ] requires draining and/or replacing nodes.
[ ] will change any APIs.
E.g. removes or changes any CK8S config options or Kubernetes APIs.
[ ] will break the cluster.
I.e. full cluster migration is required.

Pipeline config (if applicable)
If you change some config options (e.g. add/rename variable or change the default value) you may need to update the config used by the pipeline in pipeline/config.

Maybe we could do something like this?

I still think that we should convert the variable in the beginning since it's used in multiple places. I guess we can move out the test but I feel like we should do that for all the if statements then?

Yes that sounds good. Not sure if it is useful to do all if statements like this though. If we do it in this file, we should also do it everywhere else. :slightly_smiling_face:


Example from README.md does not work

The "hello world" example from the README.md does not work.
holst@puff ~/src/duffle (master)
$ duffle init
==> The following new directories will be created:
/home/holst/.duffle
/home/holst/.duffle/bundles
/home/holst/.duffle/logs
/home/holst/.duffle/plugins
/home/holst/.duffle/claims
/home/holst/.duffle/credentials
==> The following new files will be created:
/home/holst/.duffle/repositories.json

holst@puff ~/src/duffle (master)
$ duffle build ./examples/helloworld/
Error: invalid tag format

holst@puff ~/src/duffle (master)
$

Invalid. I was not using the latest release but the one packaged from docker-app.


Feat #65: Improve balance lose check and mention it's details in docs

Closes #65. Also see #62.

Thanks for taking a look @adacapo21! The PR would be merged as soon as it is reviewed from someone else from team.

You are welcome. Good luck!

The proposed changes ensure that there is no Ada loss, even when taking fees into account, when the currency is lovelaces; and that when the trade involves a non-lovelace currency then the Ada loss is only due to fees paid.  This seems reasonable to me.


[Microsoft.BillingBenefits] Adding 2022-11-01 stable version

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
] Other, please clarify

, API version update for previous endpoints as the second commit, and new API endpoint as the third commit.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Hi @gaoyp830 Please fix the error showed in https://github.com/Azure/azure-rest-api-specs/pull/21340/checks?check_run_id=9307674327

Thanks for taking another look at this PR. Those errors are by design and not applicable to our service:

in our service we dont do resource deletion ( AllResourcesMustHaveDelete )
we dont list resources by subscription, we only list by tenant or billing admin( TopLevelResourcesListBySubscription )
Created is same as Succeeded in our service, and we do have Cancelled and Failed state as well in the definition( ProvisioningStateValidation)
We dont support patching sku property in our resource ( PatchSkuProperty )

Thanks for taking another look at this PR. Those errors are by design and not applicable to our service:

in our service we dont do resource deletion ( AllResourcesMustHaveDelete )
we dont list resources by subscription, we only list by tenant or billing admin( TopLevelResourcesListBySubscription )
Created is same as Succeeded in our service, and we do have Cancelled and Failed state as well in the definition( ProvisioningStateValidation)
We dont support patching sku property in our resource ( PatchSkuProperty )

/azp run

discussion in teams : Microsoft.BillingBenefits ARM API Review


Feature/2265 --Create endpoint for Adding Menu Items

2265-Create endpoint for Adding Menu Items and Unit Tests - AddMenuItem
📲 What
Created endpoint for adding an item to a Menu
🤔 Why
Need to be able to add Item to a Menu
🛠 How
A new Item can be added to an existing category in a Menu
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵 How to test
Please use the user story to find the acceptance critieria
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

Closing this since these changes are now merged into master from https://github.com/amido/stacks-java/pull/32


Fix the 0% rebase rate

btw if anyone wants to PR into the website to fix the 0% rebase rate, we need to change the addresses of STAKING_ADDRESS here https://github.com/OlympusDAO/olympus-frontend/blob/main/src/helpers/addresses.ts to be 0xce6568338708400d03f430d29f2eb40a33a3f4c4 and also update the abi of OlympusStaking, and also here line 101 https://github.com/OlympusDAO/olympus-frontend/blob/main/src/store/modules/analytics.ts to be stakingContract.getCurrentRewardForNextEpoch()
Source: https://discord.com/channels/838651642190495804/841905788984492063/842481198298955847

You can assign this to me.

@jsnx Garamundo initially reported this solution here: https://discord.com/channels/838651642190495804/841905788984492063/842481198298955847
I'm not sure if this is even an issue since the contract addresses are up-to-date. Feel free to dig in and submit a PR or close this issue if there's no changes to be made.


Host key verification failed

I have problems with the key parameter.
I would like to write the key directly into the yaml but I do not know in which format
(line breaks ?, private + public, only private).

I have the same problem.

only private. try the following command.
$ drone secret add --name git_push_ssh_key --value @/xxxxx/teabot_id_rsa --event push --image appleboy/drone-git-push go-gitea/gitea


Stream proof??

is it possible to make the chams and esp and everything else who shows up on the screen stream proof?

try Daniel's obs proof Cheat "GOESP"

chams are inherently impossible to make stream proof, they rely on the game's DrawModelExecute function. (you could recreate it with dx9 but with severe performance implications.)

i will not use cheat in my stream, or else i will get clara-fied.

Stream Proof ESP has been added.


Allow sep=; leading line so Excel can correctly determine separator

I would propose that we allow an extra optional prop, eg. addSeparatorStatement, which would add the following line as a first line to the exported CSV (given that the separator is a ,):
sep=,

This will allow Microsoft Excel to always correctly determine the separator, and render correctly.
I've looked into the code, and it looks like this could easily be supported.
We just have to change the joiner function
@abdennour Would you accept a PR for this ?

If someone is interested in being a contributor in this project, please let contact me.
While it's hard to review all issues/PR due to time limitation, it is also not acceptable to approve PRs without review.


[draft] Add definition of an adjunction in Bicategory

Hoping to get some feedback on design decisions. I am still planning to prove that this gives an equivalence in terms of hom-categories. If there is anything else that should be included feel free to let me know.

@Boarders this was really good - a couple of small changes, and it's ready to go in. Will you be able to do there? Or would like us to?

@JacquesCarette Sorry for the delay, I'll be happy to get this finished soon (give me a week or so as I have a current knee injury which makes too much time at the computer somewhat tricky)

No worries! I'm patient and not in a hurry. Don't strain your knee for this.

I'd like to get this done - if you give me permission to push to your fork, I can do those small changes needed and then merge it in?


Close button on the modal doesn't show in the viewport for certain window sizes

Steps
Use a 'large' size Modal and resize the window.
Expected Result
The close button should be shown inside or outside the modal depending on the size of the window, but never outside of the viewport.
Actual Result
There are some window sizes that make the close icon display outside of the modal but not inside the viewport.
Version
0.77.2
Testcase
https://codesandbox.io/s/jvw9rzmm5y
Play around with the width between 1040 and 990.

@robespmun this looks like it is an issue with the CSS in SUI Core. I believe this is fixed in the latest version but we don't have our latest compatibility release to work with the latest yet.

Likely resolved with #2550

Confirming the provided codesandbox is using https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.13/semantic.min.css.
However, it seems this issue only appears on CodeSandbox due to their injecting style#detectElementResize.  This style element contains styling that breaks SUI's container.  That is unfortunate.  Remove it manually from the head and you'll see it works as advertised.
Here is the working example in our docs as well:
https://react.semantic-ui.com/modules/modal#modal-example-close-icon

Womp.  Our large size is also broken.  This is a then a CSS bug as noted by @brianespinosa.  Unforunately, it needs to be posted over at https://github.com/Semantic-Org/Semantic-UI as we don't control the CSS here, yet (#2710).


Add AppleStrategy

Hi everyone 👋,
I have been working on "Sign In with Apple" for the last few days and managed to set up a working strategy.
Of course Apple does some things different than the "classic" OAuth flow. But I think I found an acceptable solution to integrate the whole thing into the existing OAuth strategy without having to adapt it.
I will create the documentation and an example and make a PR, I am curious what you think about my solution.

I'm closing this since strategies are not going to be part of the Remix Auth package and they should be published independently.


Having the option to switch language

As a user I want to be able to switch the language, between english and german (framework, button, yaml files or so, but not translation).

See ruby on rails i18n.

https://phrase.com/blog/posts/localizing-javascript-in-rails-apps/


Smart cursor and backspace/delete-> inconsistend behaviour when at end of line

Problem Description
When shifting lines, the smart cursor behaves inconsistently.
Consider the following example where I want to remove the last digit of each variable (i.e. the 1,2,3,4)
var1
var2
var3
var4

Here, I have the cursor at var1, press backspace, then down, and I would expect that the cursor lands on the end of the line. However, it lands between var and 2. So for the next removal, I need to press delete to delete the 2. However, when pressing down now, the cursor jumps to the end of line! So for removing the 3, I need to press backspace again.
This behaviour is inconsistend.
Solution: Either keep in the same column for both backspace of delete, or always move to end of line of we are at the end of line?

var1
var2
var3
var4

Put cursor to var1[CURSOR]. Remove with backspace. Then try to delete 2. etc
Versions

Spyder version: 5.1.1
Python version: N/A
Qt version: N/A
PyQt version: N/A
Operating System name/version: win/linux

Hi @skjerns thank you for the feedback! Checked this on Windows using Spyder 5.5.5 from the standalone installer and I'm unable to reproduce. For me, after the first backspace, the cursor column position doesn't change and I can continuously use delete  to remove things:

Could it be possible for you to check with a more recent Spyder version? Seems like you are using a quite old one (5.1.1) so maybe the behavior you are experiencing was fixed at some point 🤔
Let us know!

Ah, sorry, my bad. I am indeed using 5.5.4, no idea why I wrote 5.1.1.
I've updated to 5.5.5 but the problem persists :-/

Thanks for the feedback @skjerns ! If updating didn't work maybe the issue could be related with an Editor config (I think there are a couple of preferences realted with the handling of backspace :thinking:) In my setup I have the Editor preferences set in this way:

Is there something different in your setup? Could it be possible for you to share your Spyder preferences files to see if I'm able to reproduce this when using them? Let us know!

All settings the same except for highlight occurances, show indent guides and scroll past end
I reverted to your settings and then turned on my initial settings again. And suddenly the problem is gone 🤯 no idea what caused the problem.

Screenshots
![image](https://github.com/user-attachments/assets/f92c2c2b-1a6d-491d-8d63-b601eae7f480)
![image](https://github.com/user-attachments/assets/ac1c422b-98f7-44ab-a8b1-ee02b93fb89c)
![image](https://github.com/user-attachments/assets/a7cecf1c-2c8c-44fc-8acb-6747bccf9740)
![image](https://github.com/user-attachments/assets/992d3a23-4780-40dd-95d1-ce7bbd17fc9c)


The Nav bar is not showing up properly

Describe the bug

The navbar of sales is not showing up correctly in the UI

To Reproduce
Steps to reproduce the behavior:

Go to 'CRM->Project Contracts'
Click on 'Sales in the navbar'

Expected behavior
It should be something like this

This seems fixed. Closing.


Provides better formatting and a bit extra information about doctype tag

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@aviral2004, thank you for taking the time to improve this section of the guide. Unfortunately, this article was updated with similar formatting by another PR that was accepted earlier, so I'll have to close this. However, please feel free to help us improve other sections of the guide. Happy coding! :+1:


Update advanced-features.md

Added Endpoint attack notifications URL to the document
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12393

@JohanFreelancer9 Please copy review


Hotfix referened_message

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
This PR fixes some bugs with Message#getReferencedMessage and MessageReference#resolve
getReferencedMessage was previously returning null due to an incorrect override in AbstractMessage
resolve was previously not considering channel overrides when checking permissions.

This has changes that were wrongly committed to my fork, closing


Refactor validateSubmit in admin_predicate_configuration.ts

Description

Remove unnecessary Array.froms
Change ? to ! because #predicate-config-value-row-container should always exist and is an error if it doesn't, rather than failing silently
Condition the missing value logic on whether the input is a checkbox type, rather than whether there is more than one input
Remove unnecessary early returns that are barely optimizing anything and add complexity
Re-work the logic to show the error message to flow more naturally

In addition to being cleaner this enables #6109 where we will have more than one non-checkbox input box.
Checklist
General
Read the full guidelines for PRs here

[X] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[X] Performed manual testing (Chrome and Firefox if it includes front-end changes)

Are tests already present for this use case? Should we add any?

Yes there are tests in admin_predicates.test.ts that cover each of the error cases: https://github.com/civiform/civiform/blob/92045e2e92c047b3126f91c8ce1dcb4cda859e53/browser-test/src/admin/admin_predicates.test.ts#L242-L284


.Net 6 not support for calculated field

This nuget package version 1.2.14 was working great with .Net Core 2.0, and my project is now upgraded to .Net 6.
My data collection has a custom DTO including a string MemberTypeText field which returns the text version of the same class enum field of MemberType. Previously OrderBy() method works for MemberTypeText but now the expression crashes with the error ...could not be translated. either rewrite the query in a form that can be translated,... Below is my C# statement.
 var list = await source.OrderBy("MemberTypeText").ToListAsync();
TIA!

What does source.ElementType return? source.GetType()?
Are you calling any other LINQ methods to create source?
Just to confirm, MemberTypeText is a field, not a property?

The following:
using System.ComponentModel.DataAnnotations;
using System.Linq.Dynamic.Core;
using System.Reflection;

IQueryable source = new List<MemberDto>().AsQueryable();
source = source.OrderBy("MembershipTypeText");
Console.WriteLine(
    source.Expression
);

public enum MembershipType {
    Simple,
    Complex
}

public class MemberDto {
    public MembershipType MembershipType { get; set; } = MembershipType.Simple;
    public string MembershipTypeText => MembershipType.GetDisplayName();
}

public static class Extensions {
    public static string? GetDisplayName(this Enum value) {
        var attribute = value.GetType().GetCustomAttribute<DisplayAttribute>();
        return attribute == null ? value.ToString() : attribute.Name;
    }
}

works just fine and prints out:
System.Collections.Generic.List`1[MemberDto].OrderBy(Param_0 => Param_0.MembershipTypeText)

Do you have any thoughts on why your code might be acting differently?

@sandunangelo
Did you try the proposed code change from Zev Spitz?

Sorry guys, could not attend to this issue to check the given solution either, had to switch the work context. Will update here when I switched back.

@sandunangelo Did you already have time to investigate?

@sandunangelo Did you already have time to investigate?

@sandunangelo Did you already have time to investigate?


Replace recursive reload with deletion of mgear modules.

This relates to: http://forum.mgear-framework.com/t/reload-all-of-mgear/577
This is a much better solution for reloading the modules that works every time no matter the amount of newly introduced modules to the mgear namespace.

Thank you very much for this. I will check it ASAP.
Also, I will update the template __init__.py.in


Index: Button to include missing words to total word count

Add two-state button, which selects, if the total number of words shown for elements is words.text or words.text + words.missing
I think in the longer run the default will be summing plain text and missing words together.

Now we do so, that target=text+missing, so, missing words are always included to target word count. So, this issue is bit outdated, and we close it.


Is executing a range from the current buffer possibe?

First of all, very useful plugin and has been satisfying so far to use. Just wondering is there a feature where I can execute a specified range (as in selected using visual mode), similar to snip run.
Tried RunCode on a range but it said no ranges allowed

It is not something that I use often, so I do not implement it (I do not plan to do it, because I do not use it).But if you have enough time I could send a PR and I gladly accept it.

Thanks for the clarification man. I'll try to work on it someday whenever I have the time. Great plugin man, works smooth as butter so far!


 This will lead to unexpected behavior, data loss and errors. For more information, see https://docs.docker.com/reference/commandline/daemon/#daemon-storage-driver-option
ERRO[0000] There are no more loopback devices available.
FATA[0000] Error starting daemon: error initializing graphdriver: loopback attach failed
Timed out trying to connect to internal docker host.
root@efbf8932789a:/#  docker images
Cannot connect to the Docker daemon. Is the docker daemon running on this host?
root@efbf8932789a:/#

Oh.  I just read more carefully, and I see I need to start a daemon first...   That seems to work, with lots of warnings...
[docbill@media ~]$ sudo docker run -d -p 1234 -e PORT=1234 --privileged -t -i jpetazzo/dind
[sudo] password for docbill:
3c55db04ce5e311bd9274987cf38733f52ea54cad48f8257e5d1939655592361
[docbill@media ~]$ docker run --privileged -t -i jpetazzo/dind
Cannot connect to the Docker daemon. Is the docker daemon running on this host?
[docbill@media ~]$ sudo docker run --privileged -t -i jpetazzo/dind
ln: failed to create symbolic link '/sys/fs/cgroup/systemd/name=systemd': Operation not permitted
WARN[0000] devmapper: Udev sync is not supported. This will lead to unexpected behavior, data loss and errors. For more information, see https://docs.docker.com/reference/commandline/daemon/#daemon-storage-driver-option
WARN[0000] devmapper: Usage of loopback devices is strongly discouraged for production use. Please use --storage-opt dm.thinpooldev or use man docker to refer to dm.thinpooldev section.
WARN[0000] devmapper: XFS is not supported in your system. Either the kernel doesnt support it or mkfs.xfs is not in your PATH. Defaulting to ext4 filesystem
INFO[0000] devmapper: Creating filesystem ext4 on device docker-253:0-3218087-base
INFO[0007] devmapper: Successfully created filesystem ext4 on device docker-253:0-3218087-base
INFO[0008] Graph migration to content-addressability took 0.00 seconds
WARN[0008] Running modprobe bridge br_netfilter failed with message: modprobe: ERROR: ../libkmod/libkmod.c:556 kmod_search_moddep() could not open moddep file '/lib/modules/4.4.6-300.fc23.x86_64/modules.dep.bin'
modprobe: ERROR: ../libkmod/libkmod.c:556 kmod_search_moddep() could not open moddep file '/lib/modules/4.4.6-300.fc23.x86_64/modules.dep.bin'
, error: exit status 1
WARN[0008] Running modprobe nf_nat failed with message: modprobe: ERROR: ../libkmod/libkmod.c:556 kmod_search_moddep() could not open moddep file '/lib/modules/4.4.6-300.fc23.x86_64/modules.dep.bin', error: exit status 1
INFO[0009] Default bridge (docker0) is assigned with an IP address <IP_ADDRESS>/16. Daemon option --bip can be used to set a preferred IP address
INFO[0010] Loading containers: start.
INFO[0010] Loading containers: done.
INFO[0010] Daemon has completed initialization
INFO[0010] Docker daemon                                 commit=20f81dd execdriver=native-0.2 graphdriver=devicemapper version=1.10.3
INFO[0010] API listen on /var/run/docker.sock
root@e49437da6065:/# docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
root@e49437da6065:/# docker run -ti fedora /bin/bash -i
ERRO[0045] Handler for POST /v1.22/containers/create returned error: No such image: fedora:latest
Unable to find image 'fedora:latest' locally
latest: Pulling from library/fedora
a3ed95caeb02: Pull complete
236608c7b546: Pull complete
Digest: sha256:1fa98be10c550ffabde65246ed2df16be28dc896d6e370dab56b98460bd27823
Status: Downloaded newer image for fedora:latest
[root@c537f50cca2b /]# exit
exit


View blacks out when adding cards. 003 FIXES THIS

I was able to get the alarm card that was added back by deleting the "-null" entry but it seems to have completely deleted the entity card that i edited pryor. The yaml for that card is even gone

from the raw editor.

Do we need to download a new version of the js file to test the changes?
I'm seeing the same sort of problems:
views:

path: default_view
type: 'custom:grid-dnd'
title: Home
cards:

null
null
null
null
null
type: button
tap_action:
action: toggle
entity: switch.002008635ccf7f50aed1
layout:
key: 1323588a-de52-4025-ab9c-543bf7db4ecc
type: entities
entities:

binary_sensor.wyzesense_77a67a2e

path: ecobee

I downloaded the new version with no joy. But yes i would assume you would need to download and place inside your www folder.

I apoligize!! I can confirm 003 fixes this issue ! Just download new file Here
Then place inside your www folder and RESTART HOME ASSISTANT , lol (I forgot to do the last part)

I'm still seeing the issue after downloading the new grid-view.js file and replacing it in the www folder, restarting HA.
Is there anything else that needs to be done?
Thanks

Interesting I just tried with a different browser (Edge) and it worked fine. Its not working in the Brave browser. Could this be a caching problem?

Definitely could be caching


Check if conn is closed before writing to it.

Description
Check if connection is closed before writing anything to it.
Reference issue
Fixes #503

Hi @m1k1o, is it possible to write a test for the fix?

Simplified by checking the error we receive. Reason for errors not being logged I found in this commit to be Downstream isn't able to distinguish a temporary from a Permanent error yet. But io.ErrClosedPipe is permanent error, therefore it should be returned.

@m1k1o Do you mind fixing the CI commit message check which fails?
Or, are you okay if I do so for you?

I can do it later today. But feel free to do it now if you want.

@m1k1o I adjusted the commit messages. However, it seems like I am lacking the permissions to push the changes to your branch. :(

@stv0g i added permissions, can you try again?


Error: Can’t find variable: TreeBuilder

I wanted to try your framework and followed the installation instructions. I referenced d3, lodash and dTree. Created the options and data and tried to initialize. I get error about missing TreeBuilder.
I guess the TreeBuilder is supposed to be included in the https://cdn.rawgit.com/ErikGartner/dTree/1.3.1/dist/dTree.min.js or then it needs to be separately referenced?

Hi @microbecode!
No it should be included as you mention.

What browser are you running?
Can you attach a log file?
Is the website public, can you link to it or share a https://jsfiddle.net/?
Does the non-minified version work?

Running Chrome. But surely the problem isn't dependent on the browser. If a file is missing it's missing.
https://jsfiddle.net/09aud823/ .
Non-minified version doesn't work either. It seems to have the TreeBuilder but possibly not accessible or so.
I don't have npm installed (yet) so haven't tried the 'real' installation.

I have tested your code and there are two problems.
Firstly you include d3 v4 while dTree currently supports v3. This is a separate matter and I've created a ticket for this.
Secondly, yes TreeBuilder isn't readily accessible for outside the dTree package. While this is something that I should fix it isn't really a problem in most situation since it contains code that is used internally.
Notice that the example that you run isn't really a good one since the options object that you use is the internal default state. There is no need to overwrite all the callback with TreeBuilder calls, this is default mode. You should only overwrite callback if they do not intend to use the TreeBuilder functions.
So basically don't use TreeBuilder in the options object and you should be fine. Have a look at the demo example I mentioned before it is a better starting point and works fine.

Thanks for reply.
I had no idea what the TreeBuilder is - I just took the example code and smashed it all together. Maybe the documentation could be improved on that part.
And yes, didn't notice that I used wrong d3 version.

I hoped this solved your problem.
I admit that now that I look at it the default options object in the readme looks a lot like a suitable example.  So yeah, improving documentation probably wouldn't hurt!
/Erik

Is there a working sample on jsfiddle please ?

No, but look in test/demo for a simple example.

Thanks, but when I open the index.html I get a cross domain error on the
json.
Made one myself and put it on jsfiddle
https://jsfiddle.net/daddie888/Lz8cv1z4/
You can use it if you like.
Would you like to take a look at https://jsfiddle.net/daddie888/y934abmc/1/
also ?
I would like to avoid the elbow above Peter. Is that possible ? In the
other example it dispappears when there are more children/spouces, but what
when there are only two ?
Greeting
Peter
2017-01-05 21:40 GMT+01:00 Erik Gärtner<EMAIL_ADDRESS>
No, but look in test/demo
https://github.com/ErikGartner/dTree/tree/master/test/demo for a simple
example.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ErikGartner/dTree/issues/35#issuecomment-270751320,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpXqgl845x6zfed_m3AycjkQ3CaoPMRks5rPVUygaJpZM4JE2Nu
.

Hi Peter!
Thanks for creating the JSFiddle. I probably should make an official one, the demo isn't as convenient as it should be.
The elbow is an unfortunate consequence of the layout engine used by dTree. Until it is replaced with a more advanced algorithm you'll get the elbow for two nodes like in your example.
dTree uses the D3 tree layout. I'm pretty busy with other projects right now. Feel free to hack away at a better implementation and in that case feel free to make a pull request!
Best regards,
Erik


Waveform markers draw region is too large

Win10 x64
Joulescope UI 0.7.0
The waveform widget supports single markers and dual markers, which are drawn over the waveform.  These markers draw correctly, but they are not sufficiently bounded.  They draw over the y-axis and the view statistics at the right.  The expected behavior is that the markers are constrained to the waveform plot region only.  This GIF shows the current behavior:

Fixed in 0.9.1.


Backport CacheKV iterator fix v15

backport https://github.com/cosmos/cosmos-sdk/pull/14350

This shouldn't be backported because it's state breaking


build+ci: make local, gh, and Jenkins envs identical

Description
An attempt to get our Python environments consistent across: local, Github CI, and Jenkins builds.
Changelog

CI would just upgrade pip to the latest sometimes. make venv did not upgrade pip. Jenkins pinned pip to 23.0.1. To make this consistent, CI now calls make venv and make venv installs pip==23.0.1.
CI installed pydocstyle pylint pytest separately from calling make install. pylint and pytest were already listed in every indicator's setup.py and pydocstyle was haphardly listed, so I removed the install command from CI, and added pydocstyle to the rest of the indicators.
Jenkins had an unnecessary pip install numpy command since each indicator either explicitly lists it as a dependency or transitively through Pandas, so I removed that line.
twine and build are needed to build and publish _delphi_utils and were only installed in the release CI. Added that to the [dev] section of _delphi_utils dependencies instead and removed the CI-specific line.
wheel had a separate install in many places, but we only need it for the bdist_wheel command, which setuptools>=70.1 provides (see historical note), so I removed it and added the setuptools>=70.1 version requirement to _delphi_utils build environment.

Associated Issue(s)

Addresses #1973

@minhkhul wasn't this somewhat solved by rebuilding the virtualenv in croncile

need to add changes nhsn since nhsn was added in the new release


add generate_manifest.py script

Usage:
usage: generate_manifest.py [-h] --global_config GLOBAL_CONFIG
                            [--imaging_filename IMAGING_FILENAME]
                            [--tabular_filenames TABULAR_FILENAMES [TABULAR_FILENAMES ...]]
                            [--group_filename GROUP_FILENAME] [--backups BACKUPS]
                            [--regenerate] [--make_release]

Script to generate manifest file for PPMI dataset. Requires an imaging data availability
info file that can be downloaded from the LONI IDA, the PPMI participant status info
files, as well as at least one PPMI tabular file with subject and visit columns. All these
files should be in <DATASET_ROOT>/tabular/study_data.

optional arguments:
  -h, --help            show this help message and exit
  --global_config GLOBAL_CONFIG
                        path to global config file for your mr_proc dataset (required)
  --imaging_filename IMAGING_FILENAME
                        name of file containing imaging data availability info, with
                        columns "Subject ID", "Visit", "Research Group", and "Description"
                        (default: idaSearch.csv)
  --tabular_filenames TABULAR_FILENAMES [TABULAR_FILENAMES ...]
                        name of files containing tabular data availability info, with
                        columns "PATNO" and "EVENT_ID" (default: 7 files)
  --group_filename GROUP_FILENAME
                        name of file containing participant group info, with columns
                        "PATNO" and "COHORT_DEFINITION" (default: Participant_Status.csv)
  --backups BACKUPS     path to backups directory for storing different versions of the
                        manifest, relative to <DATASET_ROOT> (default: tabular/.manifests)
  --regenerate          regenerate entire manifest (default: only append rows for new
                        subjects/sessions)
  --make_release        copy <DATASET_ROOT>/tabular to a release directory in
                        <DATASET_ROOT>/releases

New manifest file has been added to /data/pd/ppmi/tabular/mr_proc_manifest.csv (on BIC). Now follows format described in neurodatascience:mr_proc/57 (slight change for "yes/no availability for anat/dwi/func", and without bids_id or participant_dicom_dir following discussion with Nikhil).
Closes #1.

I just realized that the anat/func differentiation cannot be based on the Modality column in the LONI file, because some fMRI entries also have Modality=MRI... Will try to figure out another way to get the availability.

Added a filter_image_descriptions.py script to generate lists of description strings for each datatype (anat, dwi, func, and also t1/t2/flair since that should be useful for HeuDiConv).
The datatype-to-description mapping is saved in ppmi_imaging_descriptions.json (and is used to generate the manifest), and the descriptions that were dropped (because they didn't correspond to any datatype, were 2D, etc.) are listed in ppmi_imaging_ignored.csv. @nikhil153 could you take a look when you have the time to see if these are good?
/data/pd/ppmi/tabular/mr_proc_manifest.csv on BIC has also been updated.

I have added all motor/non-motor assessment files (instead of just the Age_at_visit file) to check for tabular data availability, but there are still 13 imaging visits that don't have corresponding tabular data entries. That number becomes 14 if we only check Age_at_visit.csv, the 5 UPDRS files, and MoCA.

More changes:

More changes after discussions with Nikhil:

The manifest now only has 4 columns: participant_id, visit, session, datatype
The default behaviour is to append new rows to the existing manifest
We do a sanity check to make sure that all subject-session pairs from the existing manifest are still valid (i.e., no subject ID change, no deleted subjects)
The --regenerate flag can be used to create a new manifest that ignores content of any existing manifest. This should be used if we want to modify existing rows in the manifest
All manifests are stored in a backup directory: mr_proc_manifest.csv is a symlink to the newest file in the backup directory
The --make_release flag can be used to create a backup of the <DATASET_ROOT>/tabular directory in <DATASET_ROOT>/releases. This only copies a subset of the PPMI study files (those needed to generate the manifest), because otherwise the release directory is too large (>4Gb)


Redirect to callback route after SAML request fails

By submitting an Issue to this repository, you agree to the terms within the Auth0 Code of Conduct.
Describe the problem
Thank you for troubleshooting this issue. Setting up an open /callback route fixed one of the issues I was having but only when logging in directly to the web app.
I need this same behavior with SAML SSO. So the redirect URI is *.auth0.com/samlp/..... with a RelayState parameter that points to encodeURIComponent(`${window.location.origin}/callback`)
The authentication of the third-party app is successful and it properly redirects back into my app to the callback route, but no code or state parameters come with it and it just hangs on /callback. I am assuming those parameters are getting eaten in a prior step, but should they be passed along?
Perhaps, I misunderstand how this should be working. I added https://localhost:3000/callback and https://[AUTH0_DOMAIN].auth0.com/samlp/.....?RelayState=https://localhost:3000/callback to my allowed callback URLs along with setting up the SAML 2 Web App addon. Again, the authentication works with that third-party app, just not coming back to my app that uses some authenticated iframes and components from that third-party, thus needing the authentication.
I am using onRedirectCallback() defined as:
  const onRedirectCallback = (appState) => {
    props.history.push(appState?.returnTo || window.location.pathname);
  };

Again, this all works properly when the redirect URI is ${window.location.origin}/callback, but then no third-party authentication takes place.
Are there other required steps when doing this with SAML requests?
What was the expected behavior?
Expected behavior would be:

Unauthenticated user comes to / route and redirected to universal login
User logs in
Auth0 makes SAML request to third party app with a relay state to return my app
Returns to /callback with code and state parameters and authenticates on my app
Redirects to index route fully authenticated

Reproduction
const ProtectedRoute = ({ component, ...args }) => (
  <Route
    component={withAuthenticationRequired(component)}
    {...args}
  />
);

const AppRoutes = () => {
    return (
        <div className={styles.AppRouter}>
            <Switch>
                <ProtectedRoute exact path="/" component={Home} />
                <Route path="/callback" exact />
            </Switch>
        </div>
    );
};

const Auth0ProviderWithHistory = (props) => {
  const domain = process.env.REACT_APP_AUTH0_DOMAIN;
  const clientId = process.env.REACT_APP_AUTH0_CLIENT_ID;

  const onRedirectCallback = (appState) => {
    props.history.push(appState?.returnTo || window.location.pathname);
  };

  const relayState = encodeURIComponent(`${window.location.origin}/callback`);
  const redirectUri = `https://[AUTH0_DOMAIN].auth0.com/samlp/...?RelayState=${relayState}`;

  return (
    <Auth0Provider
      domain={domain}
      clientId={clientId}
      // redirectUri="https://localhost:3000/callback"
      redirectUri={redirectUri}
      onRedirectCallback={onRedirectCallback}
    >
      {props.children}
    </Auth0Provider>
  );
};

function App() {
    return (
        <Router>
            <Auth0ProviderWithHistory>
                <AppRoutes/>
            </Auth0ProviderWithHistory>
        </Router>

    );
}

Environment

Please provide the following:

Version of auth0-react used: 1.5.0
Which browsers have you tested in? Chrome
Which framework are you using, if applicable (Angular, React, etc): React
Other modules/plugins/libraries that might be involved: react-router-dom 5.0.1

Hey,
Thanks for reporting this.
We are looking into this, but will need to sync with some of our more SAML experts as it's not a common thing with our SPA SDKs.
Will get back to this when we have more information.
Thanks.

Thank you! I am not even sure if this is happening on the Auth0 side or if it is happening on the third-party service side. Trying to figure that out.
In the meantime, it appears that I can get something working where I set the redirectUri to my callback route. Then in the OnRedirectCallback, I call window.location.replace("https://[AUTH0_DOMAIN].auth0.com/samlp/...?RelayState=https://localhost:3000") and it completes the loop by directing the browser to the samlp endpoint after authenticating a user for my app through Auth0.
Not sure if this is a bad idea, but the alternative (as recommended by the third-party service we are trying to integrate with) is to prepend the samlp endpoint anytime we need to use an asset in their domain to make sure the user is authenticated. We are loading dashboards in an iframe. This causes a lot of redundant calls to authenticate though so the OnRedirectCallback seems to get around that for now.

Sorry for going a bit silent, but we had to also do some research here.
The SDK being used here, Auth0-React, is built on top of our Auth0-SPA-JS SDK . That latter SDK only supports OAuth2's Authorization Code flow using PKCE and OpenId Connect.
The idea would be to log in to Auth0 using OpenId Connect and keep the SAML stuff outside of this SDK, most likely by doing what the 3rd party provider is recommending.
I would advise asking on https://community.auth0.com/, there might be people there that are more familiar with SAML. However, as the React and SPA JS SDK's do not support SAML, this repository might not be the most effective way to get assistance.
Closing this, but feel free to ping if there is anything we could still (try and) assist with.


SAS-Report does not show up in project list

First of all we are very enthusiast about your work you have done, but when we try to retrieve our reports they did not show. Only reports that showed were .sas files

the text in the images are in dutch
As you can see in the images above, in Viya it shows 3 reports which 1 is a Sas-Report file and the other 2 are .sas files. But it only shows the .sas files in your app.
How can we fix this?
Secondly how can we show diagrams/graphs in reports like you did in this video: https://vimeo.com/431629954?
Thank you for reading our question.

Hi @CXNQ
Before I give you the 'long answer', I just want to confirm.
I see you've got the app up and running and talking to your Viya install, that's great.
From your screenshot it looks like you have correctly configured your app with a Folder Root in the Viya, and that location contains two SAS programs and one Visual Analytics report. And when you click the 'open project' button, you see the two SAS programs in the list but not the report.
Is that correct?

Yes that's correct.

Ok, good. Here's the explanation.
The React apps you create with this project are not just a way to render Visual Analytics reports. They are designed to allow you to build custom interfaces and workflows that exchange data with Viya at various steps in your application workflow.
For example, this allows you to do things like collect that data from a form that the user has filled out in the app, a custom input component or a device sensor, send that data to SAS as a SAS table, process it and return resulting data from SAS and, and then render those results, but using javascript components that you choose, not necessarily VA reports. The vimeo chart you linked to in this issue is an example of that - using a draggable chart component to prepare inputs that are sent to SAS as a SAS table, triggering some SAS code that runs and returns a SAS table, and then rendering that SAS data as a set of 5 charts using a javascript library, in this case Highcharts.
The project save / load mechanism that you're using to try to load VA reports is not designed to let you load reports directly. What it lets you do is  save a data file which describes the state of your app, most likely in stringified json format - the form selections, results, settings, dashboard layout, anything else you consider to be a 'save file' from your app. You, or other users, can then load these savefiles to load the same project into their app.
CSA also makes it considerably easier for you to implement charting from the SAS Visual Analytics SDK if that is what you are looking to do, but this works slightly differently to what you are assuming.  For example, we've worked on building a portal for a client that, among other things, allowed users to select a set of VA report components and display them in a draggable grid, and customise that portal layout. When they clicked 'save', what was saved to the project file the list of components they chose for their portal, and the layout coordinates for each component. Not the report components themselves.
I suggest you look at using the SAS VA SDK to achieve what you're trying to. It is very well documented - check out the Getting Started link.
What our project should let you do is play with the SDK without needing to do those first 4 steps: enabling cross-origin resource sharing, cross-site request forgery, enabling cross-site cookies or allowing guest access.  I will open a separate issue to document a step-by-step guide on integrating VA report components into CSA apps, and we may look at publishing our report element selection component as part of that write-up. I'm not sure how soon we'll be able to do that though.
Hope that makes sense.

@CXNQ I'm going to close this as I think it answered your question. I've opened #16 to address your use case.


Documentation Cleanup

Circle back on all components and important pieces of the application and punch up the docs to make sure everything is super ultra on point

ALMOST DONE!


Add Chaordic, Cheesecake Labs from Brazil

Thank you for the PR! Could you please update it so that locations are listed in alphabetical order?

Thanks!


Created definitions file

I have added the definition file I wrote for myself by the moment that the one on definitely types does not work

Hi thanks I really appreciate this however the defs are maintained by third parties and I'm planning to remove the dependency from this component. Also I don't want there to be two competing defs it would be preferable if you raised this PR against the types over at https://github.com/DefinitelyTyped/DefinitelyTyped