Trying to add material to jobset

Sponge Version: 1.12.2-2768-7.1.5
Forge Version: <IP_ADDRESS>14
Total Economy Version: 1.8.1
Description of issue
I am trying to add materials from other mods to the jobsets and i know i'm not doing it right. I tried using idtraits, and name:item _type, but nothing seems to be working on my end.  Coud y'all give me some tips?
The mods I am using that add materials:
BaseMetals-1.12-2.5.0-beta5.214.jar
DungeonTactics-1.12.2-0.15.9.jar
NetherEx-1.12.2-2.0.8.jar
rustic-1.1.0.jar
TConstruct-1.12.2-<IP_ADDRESS>.jar
Related Configuration Files
https://gist.github.com/SeaDonkey81/be8135b00b7e0c095733c3f5be423460

Hey there :wave:
For breaking blocks, the steps would be:

Determine the block id of the ore/block
Determine whether or not multiple blocks exist with the same id.

2.1 If so, determine the id-traits of the blocks that should issue rewards (can be skipped if all of them should issue the same reward)
(You can use the debug toggle command for this)

Write them down! (It's good practice to have some place that is not a configuration file for oversight)
Add the blocks without traits into the job sets
Add the blocks with traits into the job sets but do not set a reward for them
5.1 Set the id-trait settings for those blocks
5.2 With the trait name as the configuration key, set the rewards.

You can see how this should look like with some vanilla blocks that are configured in the default sets.
I hope this helps you in a way.
If not, feel free to ask :slightly_smiling_face:

Would you mind giving me a visual example of the id-triats format?  I tried using the idtriats and id-traits from another comment I had came across {I  think you made it} a while back to someone else, but it kept throwing a closing error at the end of the entire config file when I never changed anything that far down.

I think I have the mining portion done correctly. It's the lumberjack part that was giving me issues when using idtraits.

Nowadays, both idTrait and "id-trait" should be accepted by TE due to some confusion during an earlier update.
However, if HOCON gives you issues about syntax, that's not up to us. You can use sites like HOCONLint to check your syntax before starting the server.
If you attach an updated gist, I can check it for errors too.

I updated the gist. It's the idtriat under lumberjack

Indentation really help you with these issues. At the moment, your configuration basically looks like this:
    lumberjackset {
        break {
            "minecraft:log2" {
                "id-trait"="variant"
                "variant" {
                    Acacia_Wood {
                        exp="20"
                        money=""
                    }
                    spruce_wood {
                        exp="15"
                        money=""
                    }
                    birch_wood {
                        exp="15"
                        money=""
                    }
                    jungle_wood {
                        exp="25"
                        money=""
                    }
                    acacia_wood {
                        exp="55"
                        money=""
                    }
                    dark_oak_wood {
                        exp="35"
                        money=""
                    }
                }
            } // <-- This is missing in your configuration.
        } // <-- This is missing too
        place {
            "minecraft:sapling" {
                exp="1"
                money=""
            }
        }
    }
...

If you try this with your configuration, it should be easier to spot missing braces.

I am so confused right now.  I looked over each line and I don't see anything that's missing.
This works (No error)
lumberjackset {
break {
"minecraft:log2" {
"id-trait"="variant"
"variant" {
acacia_Wood {
exp="20"
money=""
              }
           }
        }

    place {
        "minecraft:sapling" {
            exp="1"
            money=""
      }
   }
}

}
but this doesn't ( String: 69: Expecting close brace } or a comma, got end of file)
lumberjackset {
break {
"minecraft:log2" {
"id-trait"="variant"
"variant" {
acacia_Wood {
exp="20"
money=""
}
"minecraft:log2" {
"id-trait"="variant"
"variant" {
dark_oak_wood {
exp="45"
money=""
}
"minecraft:log" {
"id-trait"="variant"
"variant" {
birch_wood {
exp="15"
money=""
}
"minecraft:log" {
"id-trait"="variant"
"variant" {
jungle_wood {
exp="25"
money=""
}
"minecraft:log" {
"id-trait"="variant"
"variant" {
spruce_wood {
exp="10"
money=""
}
"minecraft:log" {
"id-trait"="variant"
"variant" {
oak_wood {
exp="22"
money=""
}
"rustic:log" {
"id-trait"="variant"
"variant" {
olive_wood {
exp="30"
money=""
}
"rustic:log" {
"id-trait"="variant"
"variant" {
ironwood {
exp="35"
money=""
}
}
}
}
place {
"minecraft:sapling" {
exp="1"
money=""
}
}
}
}

I'm so confused right now. I don't see anything missing.
This works. (No errors)
https://gist.github.com/SeaDonkey81/8004d855e0efad442e83320340a52d04
but this doesn't (String: 68: Expecting close brace } or a comma, got end of file)
Some of the lines jumped out of wack when i made the git.
https://gist.github.com/SeaDonkey81/04706bb1e82e2bfb7adb36e43fbbdc36

In the second one, you use the opening braces to open this path lumberjackset > break > minecraft:log2 > variant > acacia_Wood.  And then close one brace which leaves the following second entry of minecraft:log2 in the variant context of the first entry because you are missing the closing brace of the variant and minecraft:log2 context.
This is not what you want to do.
You want to add all variants of the block into the variant context of that block.
However, HOCON completely accepts this nesting as it is syntactically okay but fails to parse your file at the end when it notices the missing closing braces.

Think of each pair of { and } as a single context.
Contextually, the job sets configuration should look like this:

Many of set-context

Some of action-context ("break", "fish", "kill", "place", ...)

Many of block-id-context

[Many of block-variant-context]

Each time you use { you go one level to the right (into) and each time you use } you go one level to the left (out of).

Thanks for all your help. It's working now.

Glad to hear that :+1:

I am having issues with jobsets for mining. Everything works like it's supposed to except the last entry for minecraft:stone.  Is it still seeing that as part of the geolosys:ore variant? If so how do i break it up?
https://gist.github.com/SeaDonkey81/be8135b00b7e0c095733c3f5be423460

Yes, it is still seeing your entry of stone as a variant entry.
The entries are associated according to their position within the { and }s.
That means, you'll have to move the entry for stone within the pair of braces corresponding to the break key.
Also: A similar thing goes for the place action of your lumberjack set which needs to be next to - not inside - the break action.

Thank you, that fixed it.

@SeaDonkey81 You're welcome, glad to hear that 🙂

Added a new jobset "Digger", gaining exp and money was working fine until i tried to type /job, it then threw a null error and disconnected me with a timeout.
https://gist.github.com/SeaDonkey81/5604736487c25972deb2e37b9c8f1046

Farming only works on naturally spawn crops. I tried planting them myself, but I'm not receiving any exp or  money.

That's because the current implementation of database support does not automatically adapt to new jobs.
You'll need to alter the experience tables and add a column for that new job.
I'm very sorry for that. We have been planning on changing this for a while now but things always got in the way of a proper review and merge every time.
I'm hoping that will change though..

What about the farming job and not gaining exp or money from planted crops? Is that just how it works?

Planted crops that grow should yield money and exp for harvests when a growth-trait is set.
Otherwise, they will be ignored by the exploit-protection for repeated placement and breaking of blocks.

Do i need to put a stage next to "age" in the script?

Euhh.. can you re-word that, please? I don't think I understand what you mean there 😅

"growthTrait": "age". Crops grow in stages. I was asking if i needed to put the stage of the growth for example "age_7". if that would even work.

No you don't need to. When the trait is called age you put age into the config. TotalEconomy will check what the maximum, current and minimum values are for the broken block and apply rewards based on the percentage of growth given.


[BUG] The menu disappears

Sometimes I accidentally touch the menu and it disappears from the screen. Even if I restart ComfyUI, it won't display; unless I delete the node and clone the project again.

Where did you touch and it disappears? When it disappears, can you F12->Console and see if there is any error logs? Also check the python terminal has any error logs?

From: TFL-TFL @.>
Sent: Thursday, March 21, 2024 5:57:18 PM
To: 11cafe/comfyui-workspace-manager @.>
Cc: Subscribed @.***>
Subject: [11cafe/comfyui-workspace-manager] [BUG] The menu disappears (Issue #300)
Snipaste_2024-03-21_17-44-56.png (view on web)https://github.com/11cafe/comfyui-workspace-manager/assets/63155358/47d33323-8b32-49ca-8f7e-d065f5e5a844
Sometimes I accidentally touch the menu and it disappears from the screen. Even if I restart ComfyUI, it won't display; unless I delete the node and clone the project again.
—
Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/300, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOICBBGRRNHEAR6TPWTYZKVH5AVCNFSM6AAAAABFBDMEOWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TSNRZHA4DKNQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

It seems like I clicked on it with the left mouse button and scrolled up a little bit (I accidentally clicked it).
The node is successfully loaded, I didn't see any errors on the python terminal, but I saw this error in the console:

I didn't find the "workspaceManagerPanel" element on the webpage：

There are no IndexDB related errors.
There is another situation where the menu disappears.  When I use the ComfyUI launcher developed by the AIGODLIKE developer on GitHub, there is a function to update nodes.  After performing a one-click update on all nodes on the launcher, this issue also occurs. I don't know where there is a conflict.
Here are the terminal logs:
D:\05Tools\Stable_Diffusion\Blender_ComfyUI>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
** ComfyUI startup time: 2024-03-23 21:56:51.874177
** Platform: Windows
** Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct  2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)]
** Python executable: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\python.exe
** Log path: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\comfyui.log
[Maras IT] Initialization

Prestartup times for custom nodes:
   0.0 seconds: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI-MarasIT-Nodes
   0.0 seconds: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\rgthree-comfy
   0.1 seconds: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 6140 MB, total RAM 16120 MB
xformers version: 0.0.23.post1
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4050 Laptop GPU : cudaMallocAsync
VAE dtype: torch.bfloat16
Using xformers cross attention
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI-ArtGallery\../../web/extensions/core/uploadImage.js
File already contains the necessary modifications.✅
File 'D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI-ArtGallery\../../folder_paths.py' updated successfully.✅
File already contains the necessary modifications.✅
[Crystools INFO] Crystools version: 1.11.0
[Crystools INFO] CPU: 13th Gen Intel(R) Core(TM) i5-13500H - Arch: AMD64 - OS: Windows 10
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA GeForce RTX 4050 Laptop GPU
[Crystools INFO] NVIDIA Driver: 551.61
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:249: FutureWarning: `AutoencoderTinyBlock` is deprecated and will be removed in version 0.29. Importing `AutoencoderTinyBlock` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AutoencoderTinyBlock`, instead.
  deprecate("AutoencoderTinyBlock", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:254: FutureWarning: `UNetMidBlock2D` is deprecated and will be removed in version 0.29. Importing `UNetMidBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import UNetMidBlock2D`, instead.
  deprecate("UNetMidBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:259: FutureWarning: `UNetMidBlock2DCrossAttn` is deprecated and will be removed in version 0.29. Importing `UNetMidBlock2DCrossAttn` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import UNetMidBlock2DCrossAttn`, instead.
  deprecate("UNetMidBlock2DCrossAttn", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:264: FutureWarning: `UNetMidBlock2DSimpleCrossAttn` is deprecated and will be removed in version 0.29. Importing `UNetMidBlock2DSimpleCrossAttn` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import UNetMidBlock2DSimpleCrossAttn`, instead.
  deprecate("UNetMidBlock2DSimpleCrossAttn", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:269: FutureWarning: `AttnDownBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnDownBlock2D`, instead.
  deprecate("AttnDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:274: FutureWarning: `CrossAttnDownBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import CrossAttnDownBlock2D`, instead.
  deprecate("CrossAttnDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:279: FutureWarning: `DownBlock2D` is deprecated and will be removed in version 0.29. Importing `DownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import DownBlock2D`, instead.
  deprecate("DownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:284: FutureWarning: `AttnDownEncoderBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnDownEncoderBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnDownEncoderBlock2D`, instead.
  deprecate("AttnDownEncoderBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:289: FutureWarning: `AttnSkipDownBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnSkipDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnSkipDownBlock2D`, instead.
  deprecate("AttnSkipDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:294: FutureWarning: `SkipDownBlock2D` is deprecated and will be removed in version 0.29. Importing `SkipDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import SkipDownBlock2D`, instead.
  deprecate("SkipDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:299: FutureWarning: `ResnetDownsampleBlock2D` is deprecated and will be removed in version 0.29. Importing `ResnetDownsampleBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import ResnetDownsampleBlock2D`, instead.
  deprecate("ResnetDownsampleBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:304: FutureWarning: `SimpleCrossAttnDownBlock2D` is deprecated and will be removed in version 0.29. Importing `SimpleCrossAttnDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import SimpleCrossAttnDownBlock2D`, instead.
  deprecate("SimpleCrossAttnDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:309: FutureWarning: `KDownBlock2D` is deprecated and will be removed in version 0.29. Importing `KDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import KDownBlock2D`, instead.
  deprecate("KDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:314: FutureWarning: `KCrossAttnDownBlock2D` is deprecated and will be removed in version 0.29. Importing `KCrossAttnDownBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import KCrossAttnDownBlock2D`, instead.
  deprecate("KCrossAttnDownBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:319: FutureWarning: `AttnUpBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnUpBlock2D`, instead.
  deprecate("AttnUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:324: FutureWarning: `CrossAttnUpBlock2D` is deprecated and will be removed in version 0.29. Importing `CrossAttnUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import CrossAttnUpBlock2D`, instead.
  deprecate("CrossAttnUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:329: FutureWarning: `UpBlock2D` is deprecated and will be removed in version 0.29. Importing `UpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import UpBlock2D`, instead.
  deprecate("UpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:334: FutureWarning: `UpDecoderBlock2D` is deprecated and will be removed in version 0.29. Importing `UpDecoderBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import UpDecoderBlock2D`, instead.
  deprecate("UpDecoderBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:339: FutureWarning: `AttnUpDecoderBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnUpDecoderBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnUpDecoderBlock2D`, instead.
  deprecate("AttnUpDecoderBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:344: FutureWarning: `AttnSkipUpBlock2D` is deprecated and will be removed in version 0.29. Importing `AttnSkipUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import AttnSkipUpBlock2D`, instead.
  deprecate("AttnSkipUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:349: FutureWarning: `SkipUpBlock2D` is deprecated and will be removed in version 0.29. Importing `SkipUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import SkipUpBlock2D`, instead.
  deprecate("SkipUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:354: FutureWarning: `ResnetUpsampleBlock2D` is deprecated and will be removed in version 0.29. Importing `ResnetUpsampleBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import ResnetUpsampleBlock2D`, instead.
  deprecate("ResnetUpsampleBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:359: FutureWarning: `SimpleCrossAttnUpBlock2D` is deprecated and will be removed in version 0.29. Importing `SimpleCrossAttnUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import SimpleCrossAttnUpBlock2D`, instead.
  deprecate("SimpleCrossAttnUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:364: FutureWarning: `KUpBlock2D` is deprecated and will be removed in version 0.29. Importing `KUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import KUpBlock2D`, instead.
  deprecate("KUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:369: FutureWarning: `KCrossAttnUpBlock2D` is deprecated and will be removed in version 0.29. Importing `KCrossAttnUpBlock2D` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import KCrossAttnUpBlock2D`, instead.
  deprecate("KCrossAttnUpBlock2D", "0.29", deprecation_message)
D:\05Tools\Stable_Diffusion\Blender_ComfyUI\python_embeded\Lib\site-packages\diffusers\models\unet_2d_blocks.py:375: FutureWarning: `KAttentionBlock` is deprecated and will be removed in version 0.29. Importing `KAttentionBlock` from `diffusers.models.unet_2d_blocks` is deprecated and this will be removed in a future version. Please use `from diffusers.models.unets.unet_2d_blocks import KAttentionBlock`, instead.
  deprecate("KAttentionBlock", "0.29", deprecation_message)
Comfy-Easy-Use (v1.1.1): Loaded
### Loading: ComfyUI-Impact-Pack (V4.84)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.4)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Inspire-Pack (V0.68.2)
### Loading: ComfyUI-Manager (V2.7)
### ComfyUI Revision: UNKNOWN (The currently installed ComfyUI is not a Git repository)
[Maras IT] Loaded
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
--------------
 ### Mixlab Nodes: Loaded
## lama torchscript model not found: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\models\lama/big-lama.pt,pls download from https://github.com/enesmsahin/simple-lama-inpainting/releases/download/v0.1.0/big-lama.pt
LaMaInpainting.available True
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
## clip_interrogator_model not found: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\models\clip_interrogator/Salesforce/blip-image-captioning-base, pls download from https://huggingface.co/Salesforce/blip-image-captioning-base
ClipInterrogator.available True
TextGenerateNode.available False No module named 'lark'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
RembgNode_.available True
 --------------
Using device cuda
[SD Prompt Reader] Node version: 1.3.1
[SD Prompt Reader] Core version: 1.3.4.post1
(pysssss:WD14Tagger) [DEBUG] Available ORT providers: TensorrtExecutionProvider, CUDAExecutionProvider, CPUExecutionProvider
(pysssss:WD14Tagger) [DEBUG] Using ORT providers: CUDAExecutionProvider, CPUExecutionProvider
### Loading: Workspace Manager (V1.0.0)

From Bmad Custom Nodes
 Loaded 124 nodes:
  + api nodes (14)
  + simple utility nodes (58)
  + CV nodes (49)
  + color clip ade20k node (1)
  + extension dependent nodes (2)

------------------------------------------
Comfyroll Studio v1.76 :  175 Nodes Loaded
------------------------------------------
** For changes, please see patch notes at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/blob/main/Patch_Notes.md
** For help, please see the wiki at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/wiki
------------------------------------------
[comfyui_controlnet_aux] | INFO -> Using ckpts path: D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
DWPose: Onnxruntime with acceleration providers detected
FizzleDorf Custom Nodes: Loaded
# 😺dzNodes: LayerStyle -> Cannot import name 'guidedFilter' from 'cv2.ximgproc'
A few nodes cannot works properly, while most nodes are not affected. Please REINSTALL package 'opencv-contrib-python'.
For detail refer to https://github.com/chflame163/ComfyUI_LayerStyle/issues/5
# 😺dzNodes: LayerStyle -> Invalid FONT directory, default to be used. check D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI_LayerStyle\resource_dir.ini
# 😺dzNodes: LayerStyle -> Invalid LUT directory, default to be used. check D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI_LayerStyle\resource_dir.ini
# 😺dzNodes: LayerStyle -> Find 1 LUTs in D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI_LayerStyle\lut
# 😺dzNodes: LayerStyle -> Find 1 Fonts in D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\ComfyUI_LayerStyle\font
[tinyterraNodes] Loaded
[ComfyUI_zfkun] check start
[ComfyUI_zfkun] "Pillow" is not installed. Trying to install.
Looking in indexes: https://pypi.mirrors.ustc.edu.cn/simple/
Requirement already satisfied: Pillow in d:\05tools\stable_diffusion\blender_comfyui\python_embeded\lib\site-packages (9.5.0)
[ComfyUI_zfkun] "Pillow" is installed
[ComfyUI_zfkun] all dependency installed
[ComfyUI_zfkun] check end
[ComfyUI_zfkun] boot start
[ComfyUI_zfkun] node install: preview_text.js
[ComfyUI_zfkun] node install: preview_text_multiline.js
[ComfyUI_zfkun] node install: share_screen.js
[ComfyUI_zfkun] boot end
Config Export Error[Errno 2] No such file or directory: 'C:\\Users\\NIER\\AppData\\Roaming\\Blender Foundation\\Blender\Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!
Patching UNetModel.forward
UNetModel.forward has been successfully patched.
[Power Noise Suite]: 🦚🦚🦚 MooOoo!!! 🦚🦚🦚
[Power Noise Suite]: Tamed 11 wild nodes.

[rgthree] Loaded 34 extraordinary nodes.
[rgthree] Will use rgthree's optimized recursive execution.

WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable `CLIPTextEncode` support.
WAS Node Suite: `CLIPTextEncode (BlenderNeko Advanced + NSP)` node enabled under `WAS Suite/Conditioning` menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\05Tools\Stable_Diffusion\Blender_ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 212 nodes successfully.

        "Art is the bridge that connects imagination to reality."   Menu disappeared and display "idle" instead of.

Greetings,
A small input, may need to consider multiple instances deployment with same URI. In my case, I am using Traefik to publish two ComfyUI instances.


Delete depracated plugin: List symbols

Hi, you can delete my plugin List symbols, because the same functionality is now available in binja

Thanks for the reminder, done.


"'undefined' is not a function (evaluating 'mocha.ui('bdd')')"

Hi! I'm trying to run some tests using the following HTML:

    <meta charset="utf-8">

    <link rel="stylesheet" href="../node_modules/mocha/mocha.css" />

I double-checked the file paths, they are all correct. If I console.log(mocha.ui) it returns the correct function. However, when I run mocha-phantomjs, I get the following error:
TypeError: 'undefined' is not a function (evaluating 'mocha.ui('bdd')')

I'm on Windows 10, phantomjs version is 2.1.1, mocha version is 2.4.5 and mocha-phantomjs version is 4.0.2.
Thanks in advance!

Do the tests pass in your browser?

Yes, they work fine in the browser.

Change the windows backslash (\) to unix slash (/) in the test runner file path.
For example C:/dev/test/runner.html

Closing without more information. mocha.ui('bdd') is used everywhere in the tests.


[BUG] - Issue with Autocomplete Component Not Reflecting React Hook Form's Reset

NextUI Version
2.4.8"
Describe the bug
I'm currently using the NextUI Autocomplete component in a form that handles both creating and updating entries. The form utilizes react-hook-form with Controller, and I’m using useForm’s reset function to prepopulate the form fields when updating existing data. However, I’m facing an issue where the Autocomplete component doesn’t display the preloaded data from reset on the interface as expected.
Here’s the relevant codes snippet:
  const {
    reset,
    register,
    handleSubmit,
    control,
    formState: { errors, isSubmitting },
  } = useForm<UpdateStudentFormSchema>({
    resolver: zodResolver(updateStudentFormSchema),
  });

inside useEffect:
          setStudent(foundStudent);
          reset({
            ...foundStudent,
          });

<Controller
  name="icd_id"
  control={control}
  render={({ field }) => {
    return (
      <Autocomplete
        label="CID (if available)"
        className="w-[824px]"
        selectedKey={field.value}
      >
        {icds.map((ICD) => (
          <AutocompleteItem key={ICD.value} value={ICD.value}>
            {ICD.label}
          </AutocompleteItem>
        ))}
      </Autocomplete>
    );
  }}
/>

Despite calling reset with pre-existing data, the Autocomplete component does not visually reflect the selectedKey. Despite calling reset with pre-existing data, the Autocomplete component does not visually reflect the selectedKey. Is there a specific approach required for this component (and others like Select and DatePicker) to work with react-hook-form's reset, or any workaround to ensure the preloaded values display correctly?
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Steps to Reproduce the Issue
Set up the form: Create a form using react-hook-form with a Controller to manage an Autocomplete component from NextUI. Also, include other components like Select or DatePicker if relevant.
Initialize the form with data: Use the useForm hook’s reset function to populate the form with existing data, such as updating an entry.
Trigger the reset function: Call reset with a predefined data object to set initial values in the form fields, including the Autocomplete.
Observe the component: After calling reset, check if the Autocomplete displays the preloaded data (for example, the selectedKey value). Notice whether the preloaded data appears in the component interface.
Expected behavior
As a user, I expected see the information at the form component, but i'm not seeing
Screenshots or Videos
No response
Operating System Version
Windows
Browser
Edge

ENG-1527 [BUG] - Issue with Autocomplete Component Not Reflecting React Hook Form's Reset

the linear link is for us to mention the issue. you can simply ignore it.
please provide a minimal reproducible sandbox instead of just code snippets. this could help us to investigate faster.

Closing - inactivity


[Bug] Messages are sorted according to time on the sending machine, not server

Or are they?
I just scanned a document on a photocopier that sends an email with the attachment to the user. The email immediately showed up in nmail, but not on top:

This is the highlighted email here, and it was 13:59 at the time the screenshot was taken (meaning the first message was already there since half an hour). I checked the time on the photocopier: 12:08, which matches surprisingly well the 13:08 for the email it sent. There must be some summer/winter time conversion in place.
Wouldn't it be expected that emails are sorted according to the time on the server they have travelled through, instead of the time on the sending machine? Or is it actually already what nmail does? In that case, this would mean that the issue is in the way the photocopier is set up in my working environment, like perhaps the machine is its own server, but I have no way to checking that so I prefer asking here in case this would be a nmail bug. Else, sorry for the noise!

I think nmail currently uses timestamp from the email header itself (i.e. whatever the sending machine/application put in the raw email). It should be possible to use the timestamp determined by the email server instead. Let me do some research into this and update here again.

Thanks. I admit I do not know how it should be done and if there is a standard for emails in general, but using the timestamps from the header sounds like an issue if it is determined by the time on the sending machine. One could send emails with times in the past on purpose, and then claim the email was sent long before, and nmail couldn't prove that wrong.

Support for using server-side timestamps has been added in above commit. The functionality is disabled by default, and can be enabled by editing ~/.nmail/main.conf and setting server_timestamps=1.
The reason it is not enabled by default is that it causes messages imported to a server to show the date of import, rather than the message's original (internal) timestamp.

Support for using server-side timestamps has been added in above commit. The functionality is disabled by default, and can be enabled by editing ~/.nmail/main.conf and setting server_timestamps=1.
The reason it is not enabled by default is that it causes messages imported to a server to show the date of import, rather than the message's original (internal) timestamp.


LISA model_forward bug, only occurs when inference.

I replace the backbone of llava to another projects' llava, they both build on the original llava model.
When I run train_ds.py file, the training mode works well but the inference raises bug:
Traceback (most recent call last):
  File "/home/user/LISA-RS/train_ds.py", line 605, in <module>
    main(sys.argv[1:])
  File "/home/user/LISA-RS/train_ds.py", line 394, in main
    giou, ciou = validate(val_loader, model_engine, epoch, writer, args)
  File "/home/user/LISA-RS/train_ds.py", line 566, in validate
    output_dict = model_engine(**input_dict)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
    ret_val = func(*args, **kwargs)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/deepspeed/runtime/engine.py", line 1855, in forward
    loss = self.module(*inputs, **kwargs)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/peft/peft_model.py", line 918, in forward
    return self.base_model(
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/user/anaconda3/envs/LISA/lib/python3.9/site-packages/peft/tuners/tuners_utils.py", line 94, in forward
    return self.model.forward(*args, **kwargs)
  File "/home/user/LISA-RS/model/LISA.py", line 177, in forward
    return self.model_forward(**kwargs)
  File "/home/user/LISA-RS/model/LISA.py", line 277, in model_forward
    pred_embeddings = last_hidden_state[seg_token_mask]
IndexError: The shape of the mask [1, 338] at index 0 does not match the shape of the indexed tensor [33, 338, 256] at index 0
[2024-06-06 10:00:21,670] [INFO] [launch.py:319:sigkill_handler] Killing subprocess 1165665
[2024-06-06 10:00:21,670] [ERROR] [launch.py:325:sigkill_handler] ['/home/user/anaconda3/envs/LISA/bin/python', '-u', 'train_ds.py', '--local_rank=0', '--version=BigData-KSU/RS-llava-v1.5-7b-LoRA', '--dataset_dir=../remote_LISA_dataset', '--vision_pretrained=./download_weights/sam_vit_h_4b8939.pth', '--dataset=reason_seg', '--sample_rates=1', '--exp_name=model_test', '--batch_size=1', '--grad_accumulation_steps=1', '--steps_per_epoch=1'] exits with return code = 1

at first the bug is from output_hidden_states_level = torch.cat(output_hidden_states, dim=0), which turns out to be a type error, I fix this by output_hidden_states_level = torch.cat(output_hidden_states[0], dim=0)
however, the following error comes as IndexError: The shape of the mask [1, 338] at index 0 does not match the shape of the indexed tensor [33, 338, 256] at index 0, I print the things and find that this should be a problem in these code:
hidden_states = []

assert len(self.model.text_hidden_fcs) == 1
hidden_states.append(self.model.text_hidden_fcs[0](output_hidden_states[-1]))

last_hidden_state = torch.stack(hidden_states, dim=-1).sum(dim=-1)
print(f"inference last_hidden_state shape: {last_hidden_state.shape}\n\n\n")
pred_embeddings = last_hidden_state[seg_token_mask]

specifically, seg_token_mask.shape (final): torch.Size([1, 338])
inference last_hidden_state shape: torch.Size([33, 338, 256])  I have no idea why this happens.

I update my transformers from 4.31 to 4.35 and peft from 0.4 to 0.5, but this does not seem like a version problem to me

Same. looking for helper

@Yonggie I solved mine, my problem is solved for the LISA's llava backbone only return the last hidden state, while the training return the whole hidden state. I solved this by something like returning hidden_state[-1] in the inference mode. Hope this helps.


Update Dask configuration reference with undocumented options

I noticed that there are a lot of configuration options that are used throughout Dask's code that aren't actually mentioned on the configuration reference page, which is where I'd imagine a lot of users would go immediately to see what a specific option controls.
This PR is an attempt to enumerate all of those undocumented options, and give them descriptions / a default value in the config YAML if that makes sense. Some other out of scope, but also useful things that could be done:

making sure that all config.get/set calls are using an existing / consistent config option; in looking through the codebase, I noticed some typos when setting config options, and others that are referred to by different names (i.e. array.slicing.split-large-chunks vs array.slicing.split_large_chunks)

Adding a simple Python test (or, if mandatory, CI job) to check that if a new config option is added, it is referenced in the schema

[ ] Closes #xxxx

[ ] Tests added / passed

[ ] Passes pre-commit run --all-files

Thanks for working on this @charlesbluca!

I noticed some typos when setting config options

Ouch. Perhaps we should start validating the config set/get operations against the schema.

others that are referred to by different names (i.e. array.slicing.split-large-chunks vs array.slicing.split_large_chunks

Yep, the dask config normalizes underscores to dashes, so these two should be equivalent.


Devel option is broken

Hi! I try to catch error about using console.log, but jshint doesn't throw error
when is set devel:false.
Passed to JSHINT function arguments:
{ '0': '/* jshint unused:false, browser:true, strict:true, devel:false */\n\nvar foo = "foo";\n\nconsole.log("foo");\n',
  '1': {},
  '2': undefined }

jshint -v -> jshint v1.1.0
P.S.
I can not find unit test on this option in file tests/stable/unit/options.js.

@Skalman Thx :)


How to add composer requirements

It pulls the whole requirements for asgardcms to the module vendor dir.

if you plan on re-using your module: module composer.json file + main composer json file
if not: main composer json file only.

That's not true https://github.com/nWidart/laravel-modules/blob/1.0/src/Commands/stubs/composer.stub
You might be talking about asgardcms, which does add those.
Glad you found the solution. 👍


Profile login FE

Merge AFTER https://github.com/cesko-digital/volebni-kalkulacka-2022/pull/420

Looks quite outdated. Closing.


examples\system\sysview_tracing unstable openocd connection in dual core  (IDFGH-9216)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
IDF version.
master
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
ESP-IDF CMD
Hardware
ESP32-S3-DevKitC-1
Issue description
I made two very little modification to the sysview tracing example:

I increased the timers frequency by 10.
event_data[i].period = 100000 * (i + 1);
I increased the number of iterations in order to let it run forever:
if (tim_arg->count++ < INT_MAX) {

I compiled in dual core mode.
Than I flashed, started a monitor, launched openocd with:
openocd -f board/esp32s3-builtin.cfg
And after started sysvire tracing via telnet
esp sysview start pro-cpu.SVDat app-cpu.SVDat 1 -1 -1
After a while (10 to 100 seconds) openocd exits with error:
1395454
1395707
1395960
Error: Incomplete block sz 2, wr 56

I increased the verbosity of openocd but I did non find more info.
Other Info
I have the same problem on IDF v4.4.3
I changed JTAG clock frequency from default (40M) to 10M and 20MHz.
Rising the verbosity of the terminal I can see that the target is running and stacked in apptrace module code.

could you tell us when it's going to be propagated to 4.4.5 ? thanks

The issue should be reopened.
I tested the bug fix and had the same bahaviour.
I also tried to update the esp-idf and to re-run the example but than I got different errors reported on this new issue
https://github.com/espressif/esp-idf/issues/12268
We are not yet able to reliably perform tracing on ESP32-S3


Setup Communication Data Models

Describe the task that needs to be done.
(If this issue is about a bug, please describe the problem and steps to reproduce the issue. You can also include screenshots of any stack traces, or any other supporting images).
Create data models and DTOs for messages, chatrooms etc.
Describe how a solution to your proposed task might look like (and any alternatives considered).
Have models and DTOs setup for getting data through endpoints
Notes

This is an important early PR


Got cudaErrorIllegalAddress error when running the 1778 example

Hi,
I got the following error when running the following command:

I've checked nvidia-smi and seems that I have enough GPU memory.
Could you help me investigate what might be wrong?
Thank you.

Hi,
I remember 12GB GPU memory is not enough to solve Venice-1778. Possibly, you can use implicit Hessian (https://github.com/MegviiRobot/MegBA/blob/main/examples/BAL_Double_analytical_implicit.cpp). The implicit Hessian builds the Hessian on the fly, which will save a lot of memory.
Best,
Jie

@JieRen98 Thanks for the response!
Unfortunately I was not able to build target BAL_Double_analytical_implicit due to the following compile errors:

Could you tell me what I should do to make this file successfully built?

Will check it later.

Greetings,
The bug is solved. Do not forget to use git submodule update --init to register the submodule.
If you have further problems, you can re-open this issue or open a new one.
Best,
Jie


background color differs between st and termite

I've been noticing a difference in the background colours between termite and st. This happens when using the default colors-wal-st.h as well as with a custom template in which "colour0" is actually set to {colour0} rather than the default {background}, and when the following is set thus
unsigned int defaultbg = 256
/* [rather than] unsigned int defaultbg = 0 */

Another thing I've observed is that this happens when "colour0" differs from the specified "background" colour, wherein termite gets the correct background colour while st gets color0 as the background. In this case, termite has the correct background that is #000000 while st has a background #0a1124 (which is color0)
Screenshots
(apologies if the screenshots are too large)
st

termite

Does changing defaultbg fix the issue in its entirety?

Nope. I think I mentioned this in the description (albeit not as clearly I think!)

I personally use pywal without the .h file (with st). I just add the cat command to my .shellrc and all is well. Have you tried it this way?

Will try this out. Sounds a lot more convenient that recompiling st each time!

I thought I'd let you know that I'm having issues with this too! Turns out that I had the cat command in my shellrc all along (not sure why I didn't remember having added it). Tried another theme that I got off someone on reddit and this happened with st:

This is a similar theme wherein color0 actually is whiteish for some reason. It seems pywal sets the background correctly for termite but not for st. Also not sure why I get that odd bar of colour on the top in st. It disappears if a new window is spawned.


Updated CI and coverage links in README #5

Coverage remained the same at 99.615% when pulling 3f5add93817cab86c9ccd76eeded8f7c286169ee on joachimmetz:readme into b84ef3c09564e579db6f6034f9c3706f0ba3ead3 on log2timeline:master.

Please rebase this before more review

I resolved the merge conflict of the readme. Don't quite understand how this made the AppVeyor build fail.

Please rebase this before more review

rebased

Don't quite understand how this made the AppVeyor build fail.

Looks like this cause by issue(s) in yapf, should not be a show stopper


Links in README.md are broken

DATAFORMATS.md doesn't seem to exist anymore (https://github.com/Netflix/vizceral-react/blob/master/README.md#definitions)

Fixed in 4d9b56da41010b06012bc43155bcf8e21cdf674c


Rethink Button and Link components

This refers to these four components:

Button and ThemedLink
Link and TextButton

Problems with the current components
There are a handful of open issues related to these components:

TextButton and Link inherit theme have different hover states
Add support for basic text styling to TextButton and Link
Link uses inline-block
Think of how the components that link to pages will work in a SPA world
Make it easier to use padding with the Link component

And these are issues that aren't already captured:

Link and TextButton don't allow for 100% width.
<Link theme="inherit" /> and <TextButton theme="inherit" /> is clunky API and doesn't work for complex layouts.

@dcapo. @lavelle — Does this capture the problems well?

Would also be good to add the event argument to the onBlur and onFocus methods of these components, as we do for others like TextArea and Dropdown

Original Slack Thread (TT employees only) https://thumbtack.slack.com/archives/C0GKYQVTR/p1603911530021700


mkdir issue after switching to ./run_1940_cluster.sh in start_das.sh

I'm following the CLUSTER.md instructions and I think I've got a spark clustering running on top of SGE. Awesome!  I'm hitting a mkdir error, though, which looks like this:
(base) [abie@long-uge-archive-p126 census-das-container]$ time singularity run --home /share/scratch/users/abie/ --bind singularity_tmp:/tmp census_das.img
...
py.test tests/gurobi_2_test.py
============================================================== test session starts ==============================================================
platform linux -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /ihme/homes/abie/projects/2021/census-das-container/census2020-das-e2e, inifile:
plugins: remotedata-0.2.1, openfiles-0.3.0, doctestplus-0.1.3, arraydiff-0.2
collected 1 item

tests/gurobi_2_test.py .                                                                                [100%]

=========================================================== 1 passed in 10.52 seconds ===========================================================
mkdir: cannot create directory ▒/home/abie▒: Read-only file system

Awesome the spark cluster is running! This is the same error from #2 but of course I somehow didn't copy the fix over when creating the cluster script... something like "fool me once shame on them, fool me twice shame on me" echoing in my head right now.
Anyways, I just pushed the fix which I think should resolve that issue, let me know when you have a chance to try again!

Your fix got me past that error, but now I have an issue with the path for python:
  File "/usr/local/spark/spark-2.4.7-bin-hadoop2.7/python/lib/py4j-0.10.7-src.zip/py4j/protocol.py", line 328, in get_return_value
py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.spark.api.python.PythonRDD.runJob.
: org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: Lost task 0.3 in stage 0.0 (TID 27, <IP_ADDRESS>, executor 3): java.io.IOException: Cannot run program "/usr/local/anaconda3/bin/python3.6": error=2, No such file or directory

I have lots of options:
(base) [abie@long-uge-archive-p126 census-das-container]$ whereis python3.6
python3: /opt/infra/bin/python3.8-config /opt/infra/bin/python3.8 /opt/infra/bin/python3 /opt/set_uge_cgroup/bin/python3 /opt/salt/bin/python3 /opt/kill_orphans/bin/python3 /ihme/homes/abie/miniconda3/bin/python3 /ihme/homes/abie/miniconda3/bin/python3.7 /ihme/homes/abie/miniconda3/bin/python3.7-config /ihme/homes/abie/miniconda3/bin/python3.7m /ihme/homes/abie/miniconda3/bin/python3.7m-config

Ah I think this is where the interactions get weird between the application and the workers since the app is in a singularity container/environment and the workers are not. I'll do some research/reading, but my initial thought is that the best route to go down is to have everything running in a container. And ideally setting this up in a way that allows us to reuse the census_das.img (I think singularity has some options for changing the entrypoint script) since we really only need to change the command that is run when we start the container.
Long story short, I'll update here when I think I have a fix!

Ok updated https://github.com/p-b-j/census-das-container/blob/main/CLUSTER.md with new instructions for setting up a cluster and running DAS. I was able to setup a cluster following these instructions on my local machine and successfully submit the DAS, but I'm not sure if that success will translate to the SGE.
One thing I'll note is the cluster only made progress when I explicitly set the memory/cores when starting the worker nodes. I think this was due to the weirdness of running all of the nodes on the same machine, but it might be something to be aware of.

Finally got around to making the commands much nicer to run since our last conversation. The repo structure shifted a bit, but the new instructions are viewable in cluster/README.md.
I changed some of the cluster setup instructions as well, so it might be good to go through that entire README to make sure everything is setup properly!

Seems clear and working.  Now let’s see if it runs to completion!
From: p-b-j<EMAIL_ADDRESS>Sent: Thursday, March 4, 2021 6:23 PM
To: p-b-j/census-das-container<EMAIL_ADDRESS>Cc: Abraham Flaxman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [p-b-j/census-das-container] mkdir issue after switching to ./run_1940_cluster.sh in start_das.sh (#4)
Finally got around to making the commands much nicer to run since our last conversation. The repo structure shifted a bit, but the new instructions are viewable in cluster/README.mdhttps://github.com/p-b-j/census-das-container/blob/main/cluster/README.md.
I changed some of the cluster setup instructions as well, so it might be good to go through that entire README to make sure everything is setup properly!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/p-b-j/census-das-container/issues/4#issuecomment-791097893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAMQJDQ7Z27RCLW35XTF6TTCA6A3ANCNFSM4YIY3HKQ.

Successful completion in about 3 hours. :thumbs up emoji:
From: Abraham D Flaxman<EMAIL_ADDRESS>Sent: Monday, March 8, 2021 1:22 PM
To: p-b-j/census-das-container<EMAIL_ADDRESS>p-b-j/census-das-container<EMAIL_ADDRESS>Cc: Abraham Flaxman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: RE: [p-b-j/census-das-container] mkdir issue after switching to ./run_1940_cluster.sh in start_das.sh (#4)
Seems clear and working.  Now let’s see if it runs to completion!
From: p-b-j<EMAIL_ADDRESS>Sent: Thursday, March 4, 2021 6:23 PM
To: p-b-j/census-das-container<EMAIL_ADDRESS>Cc: Abraham Flaxman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [p-b-j/census-das-container] mkdir issue after switching to ./run_1940_cluster.sh in start_das.sh (#4)
Finally got around to making the commands much nicer to run since our last conversation. The repo structure shifted a bit, but the new instructions are viewable in cluster/README.mdhttps://github.com/p-b-j/census-das-container/blob/main/cluster/README.md.
I changed some of the cluster setup instructions as well, so it might be good to go through that entire README to make sure everything is setup properly!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/p-b-j/census-das-container/issues/4#issuecomment-791097893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAMQJDQ7Z27RCLW35XTF6TTCA6A3ANCNFSM4YIY3HKQ.


Clarification: CompletionOptions.triggerCharacters

How does an IDE decide to trigger completion when the user types an alphabet character, e.g. a?
I experimented with a bunch of different IDEs and languages. In EVERY case, when you type any alphabet character, then autocomplete is triggered automatically. For instance if I type a then autocomplete will pop up with a list of available identifiers/classes/methods that start with the letter a.
Is this fact represented anywhere in LSP? What exactly is meant to go in the CompletionOptions.triggerCharacters that a server sends in response to an initialize request?
export interface CompletionOptions {
  // The characters that trigger completion automatically.
  triggerCharacters?: string[];
}

I looked around at various LSP implementations to see what they send for completion triggerCharacters. Clearly, none of these mention anything about alphabet characters triggering autocomplete.

Microsoft HTML... triggerCharacters: ['.', ':', '<', '"', '=', '/']
Eclipse Java... Arrays.asList(".","@","#")
@georgewfraser Javac... new CompletionOptions(true, ImmutableList.of("."))
Microsoft PHP... public triggerCharacters = ['.', ':', '$'];
@freebroccolo OCaml... triggerCharacters: ["."],
@felixfbecker PHP... triggerCharacters = ['$', '>']
HvyIndustries Crane... triggerCharacters: ['.', ':', '$', '>', "\\"]
Rust... trigger_characters: vec![".".to_string(), ":".to_string()]
Scala... completionProvider = Some(CompletionOptions(false, Seq(".")))
@RLovelette... triggerCharacters: [" ", ".", ":", "<", "("]

My suspicion: it's up to the editor when to automatically trigger autocomplete, and all good editors will trigger autocomplete when the user types any alphabet character, and IN ADDITION they should also automatically trigger autocomplete when the user types one of the LSP's triggerCharacters. This is the same conclusion that @prabirshrestha reached when rewriting VIM's autocomplete to behave more like that of VSCode link.
If that is indeed the intent of CompletionOptions.triggerCharacters, then I think it should be documented in the LSP protocol. My suggestion:
export interface CompletionOptions {
  // The additional characters that should trigger completion automatically, in addition to
  // whatever other characters the editor already uses to trigger completion automatically -
  // typically [a-zA-Z].
  triggerCharacters?: string[];
}

Good question! It is assumed that typing an identifier automatically triggers code complete as well.

Add this to the spec:
	/**
	 * Most tools trigger completion request automatically without explicitly requesting
	 * it using a keyboard shortcut (e.g. Ctrl+Space). Typically they do so when the user
	 * starts to type an identifier. For example if the user types `c` in a JavaScript file
	 * code complete will automatically pop up present `console` besides others as a
	 * completion item. Characters that make up identifiers don't need to be listed here.
	 *
	 * If code complete should automatically be trigger on characters not being valid inside
	 * an identifier (for example `.` in JavaScript) list them in `triggerCharacters`.
	 */


Implement virtualState (for VirtualCollection)

Handling a virtualCollection from a webcomponent is currently cumbersome. See: https://github.com/blikblum/nextbone-wires/blob/master/src/colors/index/colors-view.js#L41
something like:
class Colors extends HTMLElement {
   @virtualState
   filteredColors = new VirtualCollection({
      filter: 'x'
   })
}

Will require changing VirtualCollection behavior / signature to allow late source collection binding

done


oh/b077 PoE PD non isolated

first test results:

silkscreen on the PCB is wrong, should be 'osf.b077v0.1' is 'osf.b076v0.1'
pins 13 and 14 not connected

After connecting pins 13 and 14 everything worked as expected. Waiting for corrected PCB to be assembled and tested, then this PR can merge.


[stdlib] Audit inlinability in BridgeObjectiveC [WIP]

rdar://problem/45949961

@swift-ci Please benchmark

@swift-ci Please smoke test

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

DictionaryKeysContainsCocoa
27
30
+11.1%
0.90x

Improvement

IterateData
1460
1309
-10.3%
1.12x

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

DictionarySwap.o
27803
28635
+3.0%
0.97x

SetTests.o
64829
65533
+1.1%
0.99x

Improvement

ObjectiveCNoBridgingStubs.o
8181
8085
-1.2%
1.01x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeFromNSSetAnyObjectForced
3392
4937
+45.5%
0.69x

Improvement

IterateData
1383
1221
-11.7%
1.13x

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

RGBHistogram.o
27533
28317
+2.8%
0.97x

DictTest3.o
21782
22230
+2.1%
0.98x

DictTest2.o
14342
14614
+1.9%
0.98x

DictionarySwap.o
27107
27555
+1.7%
0.98x

Improvement

ObjectiveCNoBridgingStubs.o
8087
7911
-2.2%
1.02x

ObjectiveCBridging.o
41127
40535
-1.4%
1.01x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

--------------

@swift-ci Please benchmark

@swift-ci Please benchmark

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 7cee8f68553c744f45aae1d3ed0bc4692c3f0c80

@swift-ci Please benchmark

Build failed
Swift Test OS X Platform
Git Sha - 7cee8f68553c744f45aae1d3ed0bc4692c3f0c80

Build comment file:
No performance and code size changes

@swift-ci Please benchmark

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

IterateData
1675
1448
-13.6%
1.16x

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCNoBridgingStubs.o
8181
8085
-1.2%
1.01x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

UTF8Decode_InitFromBytes_ascii
584
483
-17.3%
1.21x

IterateData
1550
1358
-12.4%
1.14x

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCNoBridgingStubs.o
8087
7911
-2.2%
1.02x

ObjectiveCBridging.o
41127
40375
-1.8%
1.02x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 70700cf618dd45becbbe448d9f27a0034847d60b

Build failed
Swift Test OS X Platform
Git Sha - 70700cf618dd45becbbe448d9f27a0034847d60b

@swift-ci Please test


[Bug Report] el-input maxlength="44" 必须使用:maxlength

Element UI version
1.3.6
OS/Browsers version
win7/chrome53.0.2774.3
Vue version
2.3.4
Reproduction Link
https://jsfiddle.net/pj71jkyw/
Steps to reproduce
maxlength="4"
[Vue warn]: Invalid prop: type check failed for prop "maxlength". Expected Number, got String.
found in
What is Expected?
maxlength="4"能直接使用
What is actually happening?
maxlength="4"不影响功能 console抛错

That's how Vue works.

[Vue warn]: Invalid prop: type check failed for prop "maxlength". Expected Number, got String.

i got the common problem....

@tianhongye @mykite Mabye you can edit like :maxlength="42"

@youyou837 我也觉得应该支持 type = "number"


Polkadot JS dashboard TX returns error.

Whenever I try to payout rewards I get the following error:
1002: Verification Error: Execution: Trap: Trap { kind: Unreachable }: RuntimeApi, Execution: Trap: Trap { kind: Unreachable }

Could you explain step by step how can I reproduce this error?

Yes,
1: Navigate to https://parachain.robonomics.network/#/staking/payout
2: Submit payout all transactions.
3: Sign with password which returns the error: 1002: Verification Error: Execution: Trap: Trap { kind: Unreachable }: RuntimeApi, Execution: Trap: Trap { kind: Unreachable }
Issue started since last night.

I see, it's for the IPCI chain, right? Please use the original IPCI explorer at https://ui.ipci.io
The parachain.robonomics.network was updated and could be temporarily incompatible with the IPCI chain.

Thanks Akru.
Yes, correct. Regarding the IPCI chain.
Got it, just tried https://ui.ipci.io and can confirm it works.
Thanks!


switching to ODK for the maintanance of RXNO & MOP

There are a lot of open issues (e.g.: #37, #30, #28, #27) that could be resolved better with a repository structure and workflow as layed out by the Ontology Development Kit (ODK). Switching to an ODK workflow would not just make the development and maintanance of RXNO & MOP much easier and less error prone, but would also ensure these two to adhere to the OBO Foundry principles, as most of them are checked for in the quality control checks implemented in ODK.
As we allready use RXNO in NFDI4Chem and plan on using / contributing more to it, I started working on the ODK migration in our NFDI4Chem fork, documenting it in its wiki. I have talked about migrating a repo to ODK in general with @matentzn in late 2021 and I will follow the inofficial "how to video" he share with me as the basis.
An important part of this is addressing the fact that MOP and RXNO are hosted and maintained in the same repository. It seems to me, that creating a repo for MOP would be best, but for now I will go for having an ODK folder structure for each (RXNO & MOP) within the existing rxno repo.
The following TODOs are the needed steps I have identified. Constructive feeback to these steps is very welcome :)
TODOs:

[x] write documentation  on how to set up a VM for the plattform independent use of an ODK workflow
[ ] migrate RXNO to an ODK workflow

[ ] seed repo folder structure with templates
[ ] export lists of terms with ROBOT|export from recent rxno.owl to be used as input for the building of import modules
[ ] somehow copy existing RXNO terms including all annotations and axioms into new rxno-edit.owl (using ROBOT filter probably)
[ ] find out if rxno.makefile is needed for the import module build

[ ] migrate MOP to an ODK workflow

[ ] seed repo folder structure with templates
[ ] export lists of terms with ROBOT|export from recent rxno.owl to be used as input for the building of import modules
[ ] somehow copy existing MOP terms including all annotations and axioms into new mop-edit.owl (using ROBOT filter probably)
[ ] find out if mop.makefile is needed for the import module build

[ ] test the workflow by making a proper release and adjusting the metadata YAML for the purls to resolve

@colinbatchelor as soon as I have something to show, I will ping you to explain and discuss this, ok?

Yes, this is very exciting.


Minors should be able to use with parental consent

Please read our README.md and CONTRIBUTING.md files before creating an issue. If you are creating an issue to provide feedback about our Closed Policies, please note that we may not incorporate your feedback into our policies due to laws that limit our flexibility around those issues. If your feedback is not related to any of the questions below, feel free to delete the template questions and enter your comments in free form.
1. What's the name of the policy?
GitHub Terms of Service - indirectly affects all policies by broadening who can use
2. Is this issue related to a specific section within one of our policies (e.g. the Terms of Service)? If so, please include a link to the section or subsection.
https://github.com/github/site-policy/blob/master/Policies/github-terms-of-service.md#b-account-terms
Paragraph beginning in "You must be age 13 or older."
3. Did you already open a pull request? If so, please include a link to the PR.
#43
4. Sometimes it's easier to just put your feedback text into an issue. If that's how you'd prefer to contribute, this is the section to do that.
See above.
5. Why do you think this section or language needs improvement?
Children under 13 have coding ability, too. They currently cannot use GitHub at all. If accepted, children under 13 will be able to join with a parent's consent (software changes are needed to implement this policy in order to prevent registering fake parent accounts)

Yeah, it seems like a no-brainer. The "13 years old thing" is usually just standard in legal documents of tech companies, though.
Does Khan Academy have something similar in their document? I guess they could be an example to check about it.

We all know the reason:children cannot consent to a binding contract by themselves. One-time irrevocable parental consent with retroactive deletion in violations is a reasonable compromise.

Added more clarification over parent's and child's IP stating child has a right to use parent's code ensured by parent.

We all know the reason: children cannot consent to a binding contract by themselves.

Of course they can. Under most jurisdictions, if their consent does not have legal downsides.
The reason is that GitHub copied COPPA without thinking and have useless insulting rules in their ToU that require consent to legal downsides.

@Natureshadow your comment was deleted as a violation of the Site Policy Code of Conduct as it was insulting or derogatory. You may consider this an official warning.

@Natureshadow your comment was deleted as a violation of the Site
Policy Code of
Conduct
as it was insulting or derogatory. You may consider this an official
warning.

Hah, what :D?
Now this makes GitHub finally unusable. There was NOTHING like that in my comment. Please prove that my comment violated this policy - deleting it and then making questionnable statements about it looks really weird.

Why would the parent need to have any age restriction except being 13 years or older?
(I can think of some very extreme cases where an under-18 parent could have a legal child old enough to code, and I see nothing that restricts this.)
I was told the age limit of 13 was due to COPPA and “nothing could be done about it”. As European, I can only shake my head on this, but whatever. Consult a lawyer specific to the USA and gather what exactly is required, instead of creating potentially not legal stuff like this.

As I mentioned in https://github.com/github/site-policy/pull/43, we are unable to allow minors under the age of 13 to have GitHub accounts. There are significant legal requirements (such as COPPA) regarding verifying parental consent, and we do not currently meet those requirements.
We completely agree, there are some really brilliant young coders out there, and we would love to encourage and nurture their skill. However, we don't have the ability to welcome them at this time.

We completely agree, there are some really brilliant young coders out
there, and we would love to encourage and nurture their skill. However,
we don't have the ability to welcome them at this time.

Which makes GitHub a discriminating p.o.s.
Block me if you want, but it will only give everyone less contributions and harm your image.

To everyone watching: Feel free to move to https://edugit.org, going public within the next two weeks.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@Natureshadow
I'm sorry but, if that kind of name-calling and sour grapes behaviour is what you consider acceptable, I wouldn't want to send kids your way and risk that the community on edugit would teach them that such behaviour is acceptable in other parts of the open-source world.

I deleted the above comment because it contained an advertisement.

Reconsider with MS acquistion. Microsoft has a very large team dedicated to child-friendly products.

Reconsider with MS acquistion. Microsoft has a very large team dedicated to child-friendly products.

I guess it is unneeded. Children can always claim that they are more than 13 years old and GH won't check it (for example by asking ID) even if it could. These are just protective legal words which are de-facto as enforceable as some games asking users to input their age on first launch or as a ToS of some well-known torrent tracker prohibiting its usage for everyone except its owners. If the age is raised to 16 years old it doesn't make any difference for everyone except well-known public persons whose age is known by everyone, and even this doesn't prevent them from using a nickname.

Not necessarily. I'm preparing to backup what I have on GitHub for fear that the acquisition by Microsoft will lock me out of GitHub the same way they locked me out of Hotmail for not owning a smartphone that could be paired with it.

16 years is GDPR&ePrivacy majority age. Microsoft has a team dedicated to child&family friendly software, hence they can adapt GitHub to be child friendly both in consent collection and other aspects.

Microsoft made sharing your smartphone number mandatory to log back into existing Hotmail accounts, which means that, if my old Hotmail account still exists, I can't get into it.

Ouch :( . Luckily, I don't have any private repos here. All I lose is interactions to the ones who are not #moving.

You seem to be awfully dependent on the location of the central repository of your decentral version control system…

It's more about stuff that is inherently tied to being logged into GitHub, like a complete list of secret (ie. unlisted) gists which may not all be embedded in my self-hosted blog, and ensuring that I've got alternative login options for any 3rd-party services which I currently log into via GitHub OAuth.
The rest shouldn't be too difficult for me to backup anonymously.

a complete list of secret (ie. unlisted) gists

If you’re logged in, you can get that by going to https://gist.github.com/your-user-name/secret, i.e. https://gist.github.com/ssokolow/secret for you.

You misunderstand. I'm already well-aware of everything I need to do and how to do it. I was just giving you a sample of the checklist I intend to find time to go through over the next little while.
(Also, this is off-topic so we should stop.)

I guess it is unneeded. Children can always claim that they are more than 13 years old and GH won't (I hope) check it (for example by asking an ID or stalking on social networks) even if it could.

It creates problems for me with teaching younger kids. Older kids can sign up for an account with a personal email and then fork a repository for a lesson. I can't ask younger kids to break the ToS. Getting all parents on board may not be possible because they do not want to sign up for a service they don't really understand. I guess the only way around it is for me to host my own git server which eats into time I would rather spend on preparing lessons.

iargent dixit:

It creates problems for me with teaching younger kids. Older kids can
sign up for an account with a personal email and then fork a repository
for a lesson. I can't ask younger kids to break the ToS. Getting all
parents on board may not be possible because they do not want to sign
up for a service they don't really understand. I guess the only way
around it is for me to host my own git server which eats into time I
would rather spend on preparing lessons.

For what it’s worth, Teckids e.V. offers youth-friendly git hosting for
educative/related projects for free on https://edugit.org/
Of course this still precludes minors from contributing to github-hosted
projects but it may just suffice for your teaching situation (and if not
contact the charity; we may be able to figure out a solution).
bye,
//mirabilos
Thorsten Glaser (Founding Member)
Teckids e.V. — Digital freedom with youth and education
https://www.teckids.org/


Followdata on benchmark

Show data from followed vessels on the benchmarkview

The page crashes if don't follow anyone

Please move FollowList.tsx and FollowListItems.tsx into a different subfolder. I suggest either in ./components/Benchmark or create a new folder ./components/FollowList

Missing information of followers data on the hover in SpeciesHistogram.tsx. Also, I see that the label of the graph is different from the text (Forrige tur in the tooltip vs. Siste 10 turer on the label). Which is the correct one?

Last comment (for future improvements): The BenchmarkCards component has become very large and complex. It does not scale  if we are to add even more data to this in the future. I recommend a major refactoring of the logic here.


How to open new window on production build?

Hi all!!
I need to open a new window to preview the document before print it.
I using the Router to separate requests by its paths:
    <Router>
        <Suspense fallback={''}>
            <Switch>
                <Print path="/print/:thingId" />
                < . . . >
                <App default />
            </Switch>
        </Suspense>
    </Router>

I try to open a new window through nw.Window.open() and <Link /> component from react-router-dom module.
When i use next code on DEVELOPMENT build thats works as was expected: window are opens and loads the content.
nw.Window.open(nw.Window.get().window.location.origin + '/print/123');

<Link to={'/print/123'} target="_blank">Print this!!</Link>

But on PRODUCTION build this shows 404 Not Found page.
How i can open a new window on PRODUCTION build??

Are you answered me after three years?? Seriously??😅

Lol I'm pretty new, took over maintainance of the project a few days ago.


Add queries and mutation for handling user credit cards

What I'm trying to achieve
I would like to have query and mutation for managing user credit cards.
Needed data can be found on mockup from storefront design on Figma:

Querying would include:

List of all CCs
Data for each card - Name on card, expiration date, last 4 digits of CC

Mutation:

Removing CC
Changing Name on card/expiration date

This is not yet supported in Saleor, here is the related backend issue: #2700.

@mateuszkula
We are not going to store in saleor db CC info, we rely on gateways in this regard, so mutation part is pointless, if anyone want to change card, using new one in checkout is the way to go.
Implemented in #4195 .

Is this issue resolved then @salwator @mateuszkula ?

Part of that is already covered - we have queries to get stored credit card info:
{
  me {
    storedPaymentSources {
      gateway
      creditCardInfo {
        brand
        firstDigits
        lastDigits
        expMonth
        expYear
      }
    }
  }
}

However, storing credit cards depends on the gateway's configuration and it's not available for all of them. At the moment we have it only for Stripe.


syslink: Unbalanced use of semaphore

@dennisss
In visiting all semaphore use cases for an upcoming nuttx change I found this:
https://github.com/PX4/Firmware/blame/master/src/modules/syslink/syslink_main.cpp#L423
https://github.com/PX4/Firmware/blame/master/src/modules/syslink/syslink_main.cpp#L143-L145
We should remove it, if not needed or fix it if it is need. Please also indicate if it's use case is a  signal
(cross thread) or a mutex

@davids5 , forgot about that one! It was originally intended as a signal for async acknowledgments similar to the other semaphore in that module. I'm removing the unbalanced one in favor of a better same-thread approach. This issue should close once that's in.


incorrectCredentials in remote server

Hi! Thanks for this great package.
While developing a server side app locally, I had no problem. The MongoDB connection was open without any problem.
However, I'm deploying my app to a server (I've tried using Dokku on Ubuntu and also Heroku, both with the Swift Buildpack), and to my surprise, the exact same code gives the following error:
fatal error: Error raised at top level: MongoKitten.AuthenticationError.incorrectCredentials: file /home/buildnode/jenkins/workspace/oss-swift-4.0-package-linux-ubuntu-14_04/swift/stdlib/public/core/ErrorType.swift, line 187
The URI looks totally fine:
mongodb://<DBUser>:<DBPassword>@<First>.mongodb.net:27017,<Second>.mongodb.net:27017,<Third>.mongodb.net:27017/<DBName>?ssl=true&replicaSet=<ReplicaSet>&authSource=admin
The MongoDB instance is hosted by MongoDB Atlas, and the server IP is whitelisted correctly so it can access the DB. MongoDB version is 3.4
Any ideas why I might be receiving this error?

Which MongoKitten version is this? #127 which you referenced showed this problem and was fixed in 4.0.11

@Joannis I'm using MongoKitten 4.1.1

Was this issue ever solved? I am having the same problem.

@Joannis
I have the same issue, I can connect to a local host but when I try to connect to through atlas I get an incorrectCredentials error, It seems to have something to do with this section:
if let certBytes = CFDataCreate(kCFAllocatorDefault, bytes, data.count), let cert = SecCertificateCreateWithData(kCFAllocatorDefault, certBytes) {
guard SSLSetCertificateAuthorities(context, cert, true) == 0 else {
                            throw Error.cannotConnect
                        }
}

This keeps throwing a -- Use of unresolved identifier 'SSLSetCertificateAuthorities' -- error. I commented it out and my local db worked fine but the atlas wont connect, I'm assuming the atlas connection requires this part of the code to not be commented out but I can get it to stop throwing the error.
Was this issue ever solved and if so how was fixed?

@Joannis I am experiencing the same issue.
v4.0.16 (latest compatible with Vapor 2)
Although when running from Xcode (macOS) I have no problem in connecting to Atlas.
When running on Linux (Ubuntu 14, with docker), I keep getting inconsistent errors:
Disconnecting all connections because we're reconnecting
Successfully created a new connection to the server at [myserver-00]
Found a master connection at [myserver-00]
Starting SASL authentication for [REDACTED] against admin
Proving authentication using "[REDACTED]"
Responding to the SASL challenge using payload "[REDACTED]"
Authentication was successful
Successfully created a new connection to the server at [myserver-01]
Starting SASL authentication for [REDACTED] against admin
Proving authentication using "[REDACTED]"
Responding to the SASL challenge using payload "[REDACTED]"
Authentication was successful
Successfully created a new connection to the server at [myserver-02]
Starting SASL authentication for [REDACTED] against admin
Authentication for MongoDB user [REDACTED] with SASL failed against Optional("admin") because of the following error
{"ok":0}
Couldn't open a connection to MongoDB at [myserver-02]
incorrectCredentials

Or
Starting SASL authentication for [REDACTED] against admin
Authentication for MongoDB user [REDACTED] with SASL failed against Optional("admin") because of the following error
{"ok":0,"codeName":"AtlasError","errmsg":"could not find config for [myserver-00]\u0002","code":8000}
Couldn't open a connection to MongoDB at [myserver-00]
incorrectCredentials

As I thought there was a memory leak on the hostname string. This has now been fixed in https://github.com/OpenKitten/MongoKitten/pull/157
@Joannis grateful if you could merge it and release a hot-fix.

I'm closing this issue now that the PR has been merged


[Feature] Simply node network for large models

Add toggle to display full network or just system level network (excluding zone nodes for AHUs, etc)

Completed in 5affeaa


Unable to render the SiteOrigin's Page Builder (plugin) WYSIWYG editor content on any post or page

Expected behavior
After installing, activating and switching to SiteOrigin's Page Builder editor on any page or post, calling {{ post.content }} should render Page Builder's editor content with applied filters, shortcodes, widgets etc. to {{ post.content }}.
Timber's documentation states that calling {{ post.content }} does just that. However It doesn't seem to handle the Page Builder's content. I inquired SiteOrigin about this on Page Builder's github repo in this issue. They bounced the ball back to you.
If I investigate the output of {{ post | print_r }} I can see that the Page Builder  added additional fields panels_data and panels_data_preview that hold data needed to render Page Builder's content. By their github response to my issue as well as Timber's documentation, one would expect to find the Page Builder's content properly rendered in the {{ post.content }} variable, witch doesn't happen.
I tried various ways to process the panels_data field like:
{% filter shortcodes %}
        {{ aboutPost.panels_data ? aboutPost.panels_data : aboutPost.content }}
{% endfilter %}

or
{{ aboutPost.panels_data | apply_filters('siteorigin_panels_data') }}

where siteorigin_panels_data is a filter added to WP from the Page Builder siteorigin-panels.php
and even called the
siteorigin_panels_filter_content( $context->post );
function (also defined within the siteorigin-panels.php) right before Timber::render,
but no joy.
Actual behavior
Timber renders the content of the standard WordPress editor rather that Page Builder's content created with the visual editor.
Steps to reproduce behavior
Install/Activate SiteOrigin Page Builder plugin.
Switch WYSIWYG editor to Page Builder on any post and add some content/grid/widgets.
Call {{ post.content }} on relevant post/page twig template.
What version of WordPress, PHP and Timber are you using?
WordPress 4.5.3, PHP 5.6.23, Timber 1.0.5
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Installed 1.0.5 version via plugin installer in WordPress dashboard.

Hi Jared, did you even figure out a solution? Thanks

Also interested in a solution

Any solution??? I Also interested in a solution

This solution is pretty late and very simplistic (will build on it shortly) but I just started integrating timber into an existing WP theme that uses page builder and I've figured out how to access the page builder content.
Here is a screenshot ot the data returned using
             {{ greeting | print_r }}
 in my home.twig file.

As you can see the actual page builder content [text] (Lorem ipsum) is nested three level down in the panels_data array. To access the content I simply chained the arrays like so
{{ greeting.panels_data.widgets.0.text }}
 .
As stated above this is a very simplistic way of accessing the content. I will make a follow up post with a more dynamic way to loop through and select the wanted content.

Is there any more progress in getting timber to render the pages created with SiteOrigin's Page Builder properly?


"SWS/S&M Remove all envelopes for selected tracks" incremental behavior

The action deletes track envelopes but instead of doing it in one go it does so in increments, with every run halving their number to the extent their number permits. Doesn't matter whether the envelopes are shown or hidden, sit in their own lanes or in media lane. Don't know if this was the intent, but if it was the title of the action doesn't reflect it.

Are you running the recently (officially) released SWS v<IP_ADDRESS> ?
(That bug looks familiar from an older SWS version but should be fixed in the current one.)

Yes, it's fixed in the latest release. Sorry about trouble.


Localization JSONs: compare languages to detect missing keys

e.g. svg.contentTable

Related: https://github.com/readium/readium-desktop/issues/396

Related issue: https://github.com/readium/readium-desktop/issues/413

Potential tools:
https://www.i18next.com/overview/plugins-and-utils#extraction-tools
http://i18next.github.io/i18next-scanner/
https://github.com/i18next/i18next-parser

In another project, I use the NPM package i18next-json-sync (CLI utility) to ensure all locales (in our case here: fr and de) are consistent with a master language (in our case here: en).
Missing JSON keys are added by the CLI utility, redundant keys are removed.
Note that keys are automatically sorted so that the tool can compare canonical-ish representations. So, the initial pass creates a big diff, just for the re-ordering.
https://github.com/jwbay/i18next-json-sync
For the avoidance of doubt regarding the large initial commit (key sorting), I used the following shell script to sort the locale JSONs (using jq, a well-established native/binary CLI JSON manipulation tool):
#!/bin/bash

## https://stedolan.github.io/jq/manual/
JQ_PARAM="def recsort: if type==\"array\" then [.[]|recsort]|sort elif type==\"object\" then (.[]) |= recsort else . end; recsort"

find ./packages -maxdepth 100 -type f -name "*.json" -regex "\./src/resources/locales/[^/]*\.json" -print0 | while IFS= read -rd '' relativefilepath; do
    filename=`basename "${relativefilepath}"`
    echo "${relativefilepath} ===> ${filename}"

    jq -S "${JQ_PARAM}" --indent 4 "${relativefilepath}" > "${relativefilepath}.tmp" && mv "${relativefilepath}.tmp" "${relativefilepath}"
    git --no-pager diff "${relativefilepath}"
done

git status

Then, I commit the JSON-sorting changes to my local Git repository clone, and I invoke the i18next-json-sync CLI utility to track key addition/removal:
package.json
  "scripts": {
    "i18n": "sync-i18n --files 'packages/**/src/l10n/locales/*.json' --primary en --languages fr --space 4 --finalnewline --newkeysempty",
    "i18n-check": "yarn run i18n --check",
    "i18n-help": "sync-i18n --help"
  }

That part works great. The next step in my other project is to scan the source code in order to match the invoked i18next keys with those that are actually present in the JSON locales, and again: add missing keys, remove unused keys.

Here is a Pull Request to address missing and unused keys in secondary languages fr and de (against the primary language en):
https://github.com/readium/readium-desktop/pull/506


Add a few more fun movie quotes to keep things spicy

Just for fun, I'm a new $DESO developer getting my feet wet.

Thanks @lazynina . I don't have merge perms, mind merging this?

Great first contribution Tyler!


Allow control of the container ID

Hi - I need to be able to control the value of the ID that is currently being generated as "react#" - I thought you may have fixed this as part of https://github.com/reactjs/React.NET/issues/45 but instead that change allows the user to define the element type.  Any chance you could include the ability to change the id?  I think others would be happy to have this ability as well.
Your code is setup well to allow for this change easily, something like so is all I need:
Addition on the Extension:
public static IHtmlString React(
			this HtmlHelper htmlHelper,
			string componentName,
			T props,
			string htmlTag = null,
                        string htmlId = null
		)
		{
            var reactComponent = Environment.CreateComponent(componentName, htmlId, props);
			if (!string.IsNullOrEmpty(htmlTag))
			{
				reactComponent.ContainerTag = htmlTag;
			}
			var result = reactComponent.RenderHtml();
			return new HtmlString(result);
		}
Addition on ReactEnvironment:
public virtual IReactComponent CreateComponent(string componentName, string componentDomId, T props)
		{
			EnsureUserScriptsLoaded();

            if (string.IsNullOrEmpty(componentDomId))
            {
                _maxContainerId++;
                componentDomId = string.Format(CONTAINER_ELEMENT_NAME, _maxContainerId);
            }

            var component = new ReactComponent(this, _config, componentName, componentDomId)
			{
				Props = props
			};
			_components.Add(component);
			return component;
		}
Thanks!

Hi @Daniel15, on the same issue, is it possible include another additional optional parameter on the helper like this:
@Html.React("HelloWorld", new {name = "Daniel"}, "my-own-container", "my-own-class1 my-own-class2");
Situation:
I have to render a list of comments, like:

It has a class applied to it that you may want for styling all comments on the page, but it also has a unique ID value (dynamically generated, nicely enough). This ID value is useful for direct linking. Now I can link directly to a particular comment on a particular page easily and keep a standard.
To set a style for each id in my css will be a little ugly, like:
#comment-27299{
...
}
#comment-27300{
...
}

So, if have a possibility to set a class-name in @Html.React will be great.
Thanks.


Put back missing report summaries.

A fix for #3738
Seems to be broken by a9b69aef

@martinpovolny looks good, can you please add some tests?

Good for me!


[Question]: Set Zoom for the cropper on initilization

Hi
I have an issue that I wanted to discuss related to setting up the initial Zoom
Let's say when I upload the image the initial state of the cropper is this

Now without Zooming in or Zooming out, I change the position of the crop window and save my entity

If I now save my card the position of the cropper window will persist. The image below shows the position of the cropper window when I save my card and visit the page again

Problem
If I Zoom out or Zoom In in the cropper like this and save the card

The zoom is not persisted. Check what happened below

I am saving the following Meta Information

Height
Width
ScaleX
ScaleY
X
Y
Rotate
OldRatio (Fetched from OnZoomEvent)
Ratio (Fetched from OnZoomEvent)

On initializing the cropper, I set the non-zoom properties like this in SetDataOptions

And I set the zoom properties by calling the ZoomTo method

Is there a special way to set the zoom of the canvas, unfortunately, I am not very clear about this. Waiting for your response
I am using Blazor Server NET 6 and the package version is 1.2.4 which is the latest stable
Thank you very much!
Regards
Saad

Hi @saadsaeed01. I suppose this option only available when the autoCrop option had set to the true, see official documentation: https://github.com/fengyuanchen/cropperjs#data

Hi @MaxymGorn
I have set AutoCrop to true but this is not working. Please see the example

@saadsaeed01 You can try to use Zoom or ZoomTo, for example in OnCropReadyEvent

I might that can help you!
And data on how much you need to zoom in or zoom out can be obtained from OnZoomEvent

Hi @MaxymGorn
Check out this solution, Hopefully, this will help other developers too. This is achieved using OnReadyEvent

Thank you for your valuable input :)
Regards
S


Failing e2e tests - scorecard-head on ossf-tests/scorecard-action

Matrix: null
Repo: https://github.com/ossf-tests/scorecard-action/tree/main
Run: https://github.com/ossf-tests/scorecard-action/actions/runs/5418802356
Workflow name: scorecard-head
Workflow file: https://github.com/ossf-tests/scorecard-action/tree/main/.github/workflows/scorecards-head.yml
Trigger: schedule
Branch: main

Looks like rate limit issue. Hasn't triggered in a while.


Where is get_file?

In the file vocabulary-embedding.ipynb (https://github.com/llSourcell/How_to_make_a_text_summarizer/blob/master/vocabulary-embedding.ipynb),
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-21-ff6b5a000c0e> in <module>()
      9 if not os.path.exists(glove_name):
     10     path = 'glove.6B.zip'
---> 11     path = get_file(path, origin="http://nlp.stanford.edu/data/glove.6B.zip")
     12     get_ipython().system(u'unzip {datadir}/{path}')

NameError: name 'get_file' is not defined

I believe it is installed via iPython. You may want to check that it is installed correctly. That all said, I can guarantee that you can also import it via keras.utils.data_utils via keras or the newly included keras implementation in Tensorflow 1.2.  Hope that helps.
https://www.tensorflow.org/versions/master/api_docs/python/tf/contrib/keras/utils/get_file

get_file is part of keras and can be found in keras and tf, import it using
from keras.utils.data_utils import get_file


Is OpenXLSX thread safe

Hello,
If I compile OpenXLSX into a .dylib on MacOSX and use it in a multi-threaded environment does OpenXLSX support multi threading? Is it thread safe?

Hi @Duster12
It’s not thread-safe, I’m afraid.
The underlying XML library is thread-safe for all reading operations. OpenXLSX could be made thread-safe for reading operations as well, but this is not the case at the moment, but maybe in the future.
For writing operations, it’s more complicated.
You can try the XLNT library (https://github.com/tfussell/xlnt). I don’t know if it’s thread-safe, but it’s worth checking out.


if (!foo in map) should be an error

This is a common JS gotcha:
/** @flow */
function add(map: {[key:string]: number}, k: string) {
  if (!k in map) map[k] = 0;  // <-- looks up "!k"
}

it should be:
/** @flow */
function add(map: {[key:string]: number}, k: string) {
  if (!(k in map)) map[k] = 0;  // note extra parens
}

Flow should be able to catch this but, as of Flow 0.18.1, it does not.
!k where k is a string should either be an error or have type boolean, which shouldn't be possible to look up in a map with keys of type string.

We identify this pattern in Type_inference_js.ml. Right now we simply claim that the whole l in r expression is a boolean, but it is possible we could do more.

Cool. I don't see much loss for making x in map be an error if x has the wrong type. If Flow can determine ahead of time that this will evaluate to false, then you should just remove it :)

Even in your example, we wouldn't know statically that the expression evaluates to false, because the boolean is coerced to a string. false in { "false": null } is true, for example. Still, I think there's a reasonable argument to be made for warning in this case.

Even so, I don't think there's much loss to making this an error.
If you really intend to look up "false", then you can just write k.toString() in map.