Allow creating dev server without opening port.

Added a config for devOptions.server?: boolean which defaults to true;
If false, then no http(s) server will be created and it will be up to
the caller to create the initial server.
Created a stub for EsmHmrEngine that avoids any processing if HMR is disabled.
Changes

Testing
TODO: Add Tests
Docs
TODO: Update Docs

Creates a new http(s) server for HMR if needed, using the same snowpack certificates as the main server. Fixes https://github.com/snowpackjs/snowpack/discussions/2288
Allows passing devOptions.server: false to prevent the creation of a new http(s) server. Addresses https://github.com/snowpackjs/snowpack/discussions/2239

Creates a new http(s) server for HMR if needed, using the same snowpack certificates as the main server. Fixes https://github.com/snowpackjs/snowpack/discussions/2288
Allows passing devOptions.server: false to prevent the creation of a new http(s) server. Addresses https://github.com/snowpackjs/snowpack/discussions/2239

The failed unit test is caused by another bug.
Fixed here https://github.com/snowpackjs/snowpack/pull/2328

The failed unit test is caused by another bug.
Fixed here https://github.com/snowpackjs/snowpack/pull/2328

Test failures are fixed in this PR https://github.com/snowpackjs/snowpack/pull/2328

Test failures are fixed in this PR https://github.com/snowpackjs/snowpack/pull/2328

rebased to keep up with @FredKSchott speedy fixes

rebased to keep up with @FredKSchott speedy fixes

Fixed in #2707 by passing port = 0 (will add some docs for this).
In the next breaking change for Snowpack, I'd like to add a .listen() method to the dev server to start the actual server itself (instead of being always on by default).


Delete gimakad.txt

The site is down.

@aaapl Thank you! The website is down, however the domain is valid, and the mail server is alive. I have to close this request without merging.


Revert "Revert "Refactor Channelz Service to Support Internal Build""

Reverts grpc/grpc#16993
Will merge this again as soon as the internal changes are approved and submitted.
NOTE: there is no fixing commit. All changes that were missing were internal only. This PR is identical to the original

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,014,439      Total (=)      2,014,439

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,113,668      Total (<)     11,113,675

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences


woodpecker: 2.5.0 -> 2.6.0

Description of changes
Changelog: https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.6.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319627 run on aarch64-darwin 1

3 packages built:

woodpecker-agent
woodpecker-cli
woodpecker-server

Result of nixpkgs-review pr 319627 run on x86_64-linux 1

3 packages built:

woodpecker-agent
woodpecker-cli
woodpecker-server

@ofborg build woodpecker-server woodpecker-agent woodpecker-cli


Pass files to tasks instead of genome lib dir

I think there are processes in ctat-VIF that use the genome lib in order to extract the gene annotations (or may in the future).  The ctat genome lib is at the heart of many of the ctat-tools, and so I'm not super psyched about removing the genome lib parameter.   Do we really need to do this for some reason?

The genome lib parameter remains at the top level, but passes the
needed files within the genome lib to each task.
On Mon, Mar 22, 2021 at 7:02 PM Brian Haas @.***> wrote:

I think there are processes in ctat-VIF that use the genome lib in order to extract the gene annotations (or may in the future). The ctat genome lib is at the heart of many of the ctat-tools, and so I'm not super psyched about removing the genome lib parameter. Do we really need to do this for some reason?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

ah!  ok, that makes sense.  thanks!
On Mon, Mar 22, 2021 at 7:06 PM Joshua Gould @.***>
wrote:

The genome lib parameter remains at the top level, but passes the
needed files within the genome lib to each task.
On Mon, Mar 22, 2021 at 7:02 PM Brian Haas @.***> wrote:

I think there are processes in ctat-VIF that use the genome lib in order
to extract the gene annotations (or may in the future). The ctat genome lib
is at the heart of many of the ctat-tools, and so I'm not super psyched
about removing the genome lib parameter. Do we really need to do this for
some reason?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/broadinstitute/CTAT-VirusIntegrationFinder/pull/12#issuecomment-804453131,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZRKXY3MGRH2IDMAV7R5KLTE7ENZANCNFSM4ZUAZG3A
.

--
Brian J. Haas
The Broad Institute
http://broadinstitute.org/~bhaas http://broad.mit.edu/~bhaas


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.4.143 to before v5.4.162",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=69aa1a1a569f5c6d554b59352130ef363342ed4c",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=edd783162bf2385b43de6764f2d4c6e9f4f6be27"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "69aa1a1a569f5c6d554b59352130ef363342ed4c",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "edd783162bf2385b43de6764f2d4c6e9f4f6be27",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "scsi: core: sysfs: Fix hang when device state is set via sysfs\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.162 by commit edd783162bf2385b43de6764f2d4c6e9f4f6be27, it was introduced in version v5.4.143 by commit 69aa1a1a569f5c6d554b59352130ef363342ed4c. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002262


Pico ALXR client will not install onto Pico Neo 2 due to APK not being compatible with android 8.1

Trying to get ALXR client installed through both ADB and the headset storage itself without success. I've tried everything within my immediate scope to get it installed, but as far as I can tell the client APKs are all built for android 9, not the 8.1 that the Neo 2 is running.
This is the error message I get with ADB:
adb: failed to install alxr-client-pico.apk: Failure [INSTALL_FAILED_OLDER_SDK: Failed parse during installPackageLI: /data/app/vmdl727685437.tmp/base.apk (at Binary XML file line #1): Requires newer sdk version #28 (current version is #27)]
I just want clarification on the issue because I feel I'm missing something here. Any help would be appreciated, thanks!

Forgot to add, yes currently alxr has minimum sdk api level of 29. It maybe possible to bring down a bit lower but it's something I'll need to look into and as I mentioned Neo 2 lacks an OpenXR runtime right now.


Port UTxO-HD docs from the ouroboros-network repository.

Description
Resolves #151.
This PR ports the UTxO-HD docs from https://github.com/input-output-hk/ouroboros-network/pull/3863.

We should probably take some time to discuss where we want this documentation to land. We currently have report and website inside docs and maybe we want to keep this structure. Also, I don't know if we want to expand the report or leave it as a historical reference. The tex files could be put into our website directory in the latter case.

We discussed this, and the consensus is that we want to move most of the (contents of) the docs to the website (See the Structure section of
https://github.com/input-output-hk/ouroboros-consensus/issues/126). I've done exactly that for a few files in this PR, but I would suggest we incrementally integrate the remaining files in the website in follow-up PRs. I've added a NOTE.md file to the docs/utxo-hd folder, which records that we are supposed to remove the folder at some point, i.e., when we have integrated everything we want to integrate in the documentation website.


[Cherry-pick][Branch-2.4][BugFix] when the path contains(),replaceFirst not work

Signed-off-by: zombee0<EMAIL_ADDRESS>What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #12641
Problem Summary(Required) ：

repalceFirst will use the first param as regex, so when the path contains (), it will not work.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.

run starrocks_fe_unittest


Create a CLI commands that shows all routes

We can adding a cli commands which prints all the application routes.
for example
rr controllers

[Methos] [URI]

Also try
lc routes --curl

to output a simplistic curl command for each of the routes (when POST, use a small json object -d {"data":"hello"} or similar.
note:

alias will change to alias lc='cargo run --' (because loco bin is the new project generator)
Rails uses rails routes and not rails controllers so let's follow that too

First pr show all register controller: https://github.com/loco-rs/loco/pull/35


fix typo in comment

Changes

Fixes

When I read the doc, I noticed a small typo in the comment.

Fix typo in example in README.md

Checklist

Have you...

[x] Tested the change acts as expected
[x] Checked the change doesn't remove or change existing functionality
[x] Considered how the feature impacts the product and tested around it (not just the happy paths)
[x] Where possible, executed the hardware tests on multiple operating systems

Thanks!


Revert "Snappy/v2.0.1"

Reverts SnappyDataInc/spark#17

Reverted the merge from branch2.0. It was done by mistake. Instead it should have been merged to snappy/branch2.0.


Fix copyDir test case bug

Purpose
$subject
Fixes #20533
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20603 into master will decrease coverage by 4.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #20603     +/-   ##
=========================================
- Coverage    19.9%   15.21%   -4.7%
=========================================
  Files          55       50      -5
  Lines        1437     1341     -96
  Branches      218      208     -10
=========================================
- Hits          286      204     -82
+ Misses       1138     1121     -17
- Partials       13       16      +3

Impacted Files
Coverage Δ

...ool-plugins/vscode/src/debugger/config-provider.ts
0% <0%> (ø)
:arrow_up:

composer/packages/tracing/src/ToolBar.tsx

composer/packages/tracing/src/TraceList.tsx

composer/packages/tracing/src/DetailView.tsx

composer/packages/tracing/src/TraceLogs.tsx

composer/packages/tracing/src/index.ts

tool-plugins/vscode/src/core/extension.ts
28.16% <0%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35241c9...ced8dae. Read the comment docs.


Add support for combine-releases-packages and combine-record-packages

Also, if a file is a JSON array of packages, append each package to the list of packages to process, instead of appending the JSON array.
Since some OCDS data is published as a JSON array of packages, this avoids a user having to split the array into individual files before using combine-*-packages.

+1 to adding support for combine-release-packages as a priority

Note: The (unreleased) 0.1.0 version of OCDS Kit now has library functions for these.

This version of OCDS Kit has now been released.

Closed by #52


EPG output is blank?

Describe the bug
Trying to implement on the epg: https://github.com/matthuisman/i.mjh.nz/raw/master/SamsungTVPlus/all.xml.gz
m3u8 file generated is perfect...but epg xml file is blank??
Required To Reproduce
When requesting support for something not working as expected all of the following are required. Issues not supplying all items will be closed. Please supply sanitised data files with username/passwords removed and attach the smallest files possible that reliably reproduce to the issue.

All input arguments passed to the script CLI / complete input --json_cfg configuration.

Using only CLI command:

python3 ./m3u-epg-editor-py3.py -m="https://script.google.com/macros/s/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/exec?region=all&service=SamsungTVPlus" -e="https://github.com/matthuisman/i.mjh.nz/raw/master/SamsungTVPlus/all.xml.gz" -g="'India','Canada','United States','United Kingdom'" -pc -ns -d="/home/rana/iptv" -f="m3u-new"

A sample input m3u data file and an epg data file (if in use).

m3u8 url for SamsungTVPlus can be generated for all regions using google script easily as mentioned at: https://github.com/dtankdempse/free-iptv-channels
EPG url is https://github.com/matthuisman/i.mjh.nz/raw/master/SamsungTVPlus/all.xml.gz

The --log_enabled log file of a run where the problem occurred.
Forgot log option ...see if you can find the root cause without log.

Additional context
I guess your code is for some IPTV services as mentioned in rhe readme...specify if this can be implemented on the above mentioned repo.

Please supply the actual m3u file that was processed that you believe is paired against the EPG file that you've applied.
I'm not willing or able to try and guess at the data that you're using.
If you can't this will be closed won't fix.

I ran a test with your input data
"m3uurl": "https://cutt.ly/ZeTNyZnn",
"epgurl": "https://github.com/matthuisman/i.mjh.nz/raw/master/SamsungTVPlus/all.xml.gz"

With "log_enabled": true this is the process log for the test run: process.log
These are the resulting generated files (file extensions changed to .txt to enable attach here):

84.m3u8
84.xml

This is the output of no_epg_channels.txt for the test run: no_epg_channels.txt
From the readme

no_epg_channels.txt
This is a log of any channels that you decided to keep that were subsequently found to have no epg data available.

There is no EPG data in the xml file for the channels in the m3u file.
This can't and won't work, m3u data channels vs EPG data channels are unmatched, this is why the resulting generated EPG XML contains no channels.


showcase a sample with endpoint and an invocation to RequireCors

Write sample code using .NET 7 or .NET 8
See this comment
Put sample in aspnetcore/security/cors/7.0sample/Cors/Web2Api

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 59bca5db-1196-2a8b-a0d8-4e89b2382288
Version Independent ID: d3f332c4-4c60-039e-0e1e-bc6b11831f87
Content: Enable Cross-Origin Requests (CORS) in ASP.NET Core
Content Source: aspnetcore/security/cors.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Associated WorkItem - 64386

cc @fiyazbinhasan  @sammychinedu2ky


[BUG] Message bar does not extend when it exceeds to next lines

Client Mod
Powercord, BetterDiscord
Description of bug
When I'm typing a long paragraph, I expected the message bar to extend with the message exceeding to next lines. But instead the bar stayed the same and had the ability to scroll through the message. Its difficult like that to see what I've written.
Steps to reproduce
If you write a message which reaches next lines, the bar doesnt extend making it difficult to read what you typed.
Suspected cause
Don't know the cause but probably an easy fix
Screenshots

You can see in the image the next line is only slightly visible which requires me to scroll down making it difficult to understand what I typed before and after
This issue is unique

[x] I have searched the issue tracker and did not find an issue describing my bug.

The chat box is scrollable to see bigger messages.


Start fixing the gomega.Eventually wrong pattern

When using Eventually or Constantly, if an inner assertion is failed, the whole function is fails and does not keep polling.
Example:
Eventually(func() {
    ...
    Expect(something).To(...) // <<<<< if this fails, the whole Eventually fails
    ...
}).Should(...)

There is a built in solution for that, by passing a Gomega argument to the function:
Eventually(func(g Gomega) { <<< add the Gomega argument here
    ...
    g.Expect(something).To(...) // <<<<< Now, only the current poll fails
    ...
}).Should(...)

This PR is starting to fix these cases in the tests/ directory.
In some cases this issue was solved by returning an error, but the Gomega argument allow us to use nicer code. e.g.
Eventually(func() error {
	vmi, err := virtClient.VirtualMachineInstance(vmi.Namespace).Get(context.Background(), vmi.Name, &metav1.GetOptions{})
	if err != nil {
		return err
	}

	if vmi.Status.NodeName == vmiNodeOrig {
		return fmt.Errorf("VMI is still on the same node")
	}

	if vmi.Status.MigrationState == nil || vmi.Status.MigrationState.SourceNode != vmiNodeOrig {
		return fmt.Errorf("VMI did not migrate yet")
	}

	if vmi.Status.EvacuationNodeName != "" {
		return fmt.Errorf("VMI is still evacuating: %v", vmi.Status.EvacuationNodeName)
	}

	return nil
}, 360*time.Second, 1*time.Second).ShouldNot(HaveOccurred())

We can do this instead:
Eventually(func(g Gomega) {
	vmi, err := virtClient.VirtualMachineInstance(vmi.Namespace).Get(context.Background(), vmi.Name, &metav1.GetOptions{})
	g.Expect(err).ToNot(HaveOccurred())
	g.Expect(vmi.Status.NodeName).ShouldNot(Equal(vmiNodeOrig), "VMI is still on the same node")
	g.Expect(vmi.Status.MigrationState).ToNot(BeNil(), "VMI did not migrate yet")
	g.Expect(vmi.Status.MigrationState.SourceNode).Should(Equal(vmiNodeOrig), "VMI did not migrate yet")
	g.Expect(vmi.Status.EvacuationNodeName).Should(BeEmpty(), "VMI is still evacuating: %v", vmi.Status.EvacuationNodeName)
}, 360*time.Second, 1*time.Second).Should(Succeed())

None

/sig code-quality

/test pull-kubevirt-goveralls

@nunnatsa great improvement, much more readable code as per your example! :+1:
The only thing I'd even prefer to be different in your example inside the PR description would be a combining matcher that checks all assertions at once. This way you wouldn't miss other assertions that are failing after the first one and thus are effectively shadowed.
Just a thought. WDYT?

/test pull-kubevirt-e2e-k8s-1.25-sig-storage

@nunnatsa great improvement, much more readable code as per your example! +1
The only thing I'd even prefer to be different in your example inside the PR description would be a combining matcher that checks all assertions at once. This way you wouldn't miss other assertions that are failing after the first one and thus are effectively shadowed.
Just a thought. WDYT?

Not sure I get your point. The example above, as far as I understand, is 100% logically identical to the original implementation. But maybe I miss something.

Looks awesome! worth to include the doc (I didn't know about this):
https://onsi.github.io/gomega/#category-3-making-assertions-eminem-the-function-passed-into-codeeventuallycode

@nunnatsa great improvement, much more readable code as per your example! +1
The only thing I'd even prefer to be different in your example inside the PR description would be a combining matcher that checks all assertions at once. This way you wouldn't miss other assertions that are failing after the first one and thus are effectively shadowed.
Just a thought. WDYT?

Not sure I get your point. The example above, as far as I understand, is 100% logically identical to the original implementation. But maybe I miss something.

Yes, it is. I am trying to say that the approach of checking one assertion after the other is wrong, since in case of failure you only ever get to the nth assertion but don't check the (n+1)th assertion, thus you don't know what the state of that (n+1)th assertion is.
In this case it should be fine, since all of the assertions should be satisfied. I am just pointing out that the test might hide details of how the actual state is.

@nunnatsa Are you able to rebase? Could we make a file per commit for easier review?
Note: In some cases, I could see why we would want to fail inside the block. Per se, this is not the wrong pattern but I really like how few tests could be simplified.


Feature request: WARN for improperly configured CommandBlocks

CommandSigns 2.1.2
Strictly speaking, "was not able to extract ... location" is incorrect; the location is not a valid CommandSigns command block. And the message should be a WARN.
So, instead of:
[21:13:42] [Server thread/INFO]: Was not able to extract command block location from
[21:13:42] [Server thread/INFO]: plugins/CommandSigns/CommandBlocks/configurations/20.json

something like:
[21:13:42] [Server thread/WARN]: Invalid command block location in configurations/20.json

Even better, make the message configurable.

https://github.com/Nokorbis/ar-command-signs/releases/tag/2.1.3.Alpha

Looks good. Note that plugin.yml

version: 2.1.2

Moderately serious issue: WARN messages are produced for worlds that have not yet been loaded, but contain valid signs. ARCS needs to wait until the worlds have been loaded.

Hmm, ARCS also reports the same incorrect WARN messages on arcs reload, at which time the worlds are certainly loaded, although the relevant chunks may not be.

What plugin are you using for your multi-world ?

Multiverse-Core 4.1.1-SNAPSHOT-b777
Spigot 1.14.4

I have no idea if the worlds are loaded with ARCS is enabled. I can guarantee that they are loaded when I run reload.

When you have a message saying a command sign is not loaded because of the world
Can you /mv tp
on the given world ?

Of course.

I should have asked it another way...
Instead of "can you"... I mean "Are you able to..." ?

This is what happens for me

My mistake. That one world is not loaded. I forgot that I removed it for a previous unrelated test. Mea culpa.
So all good.

I changed the message format to avoid spam :

Nice!

Will be fixed in next snapshot

(Funny it isn't by default, but I guess the OS does not give the files in the order of the file explorer :D)
Linux (Unix) directories are stored in inode order. Without manipulation, the contents will be returned in that order.


Do not return promises' result in hooks/events

The route POST /chains/:chainId/hooks/events was returning an array with the length of promises resolved. It should return an empty body instead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 92.068%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
4153

Relevant Lines:
4399

💛  - Coveralls


Display winner

Show the winner name for a while before starting a new game

This is done with the viewers autoload update


Allow identifying readonly properties in mapped types

Search Terms
Pretty much the ones in the title...
Suggestion
Any TypeScript modifier should be allowed to be easily identified in mapped types. In particular, readonly should, but possibly others too, such as ?.
Use Cases
Define mapped types where the values depend on whether the property is readonly or not. At the moment, the following madness is necessary for this:
 type Or<A extends boolean, B extends boolean> = A extends true
    ? true
    : B extends true
        ? true
        : false

type Equals<X, Y> =
    (<T> () => T extends X ? 1 : 2) extends
        (<T> () => T extends Y ? 1 : 2)
            ? true
            : false

type IsReadonly<O extends Record<any, any>, P extends keyof O> =
    Not<Equals<{[_ in P]: O[P]}, {-readonly [_ in P]: O[P]}>>

I would like to see some syntactic sugar similar to (not intended to be a full implementation):
type Writable<T> = {
    [P in keyof T]: isreadonly T[P] ? never : T[P]
}

In my case, I would like to define a hyperscript-style function which accepts a series of attributes for the creation of HTML elements. For this, I reuse the interfaces that TypeScript defines, such as HTMLAnchorElement, but obviously readonly properties (among others) need to be excluded.
Other people seem to have similar use cases, e.g. https://stackoverflow.com/questions/52443276/how-to-exclude-getter-only-properties-from-type-in-typescript
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

I'd be interested in more streamlined manipulation of modifiers in mapped types.  Detecting readonly and optional properties is indeed a bunch of hoop jumping, and then if you want to selectively alter the modifiers, you need to split the mapping into pieces and intersect them:
type SelectivePartial<T, K extends keyof T> =
  Partial<Pick<T, K>> & Required<Pick<T, Exclude<keyof T, K>>> extends
  infer U ? { [P in keyof U]: U[P] } : never;

type Foo = SelectivePartial<{ a: string, b: number, c?: boolean }, 'b'>
// type Foo = { b?: number | undefined; a: string; c: boolean; }

It would be a lot nicer to essentially read and selectively write modifiers inside the mapping directly.  (Note the word "selectively"; the current support for altering modifiers is all-or-nothing ).


Port changes of [#17081] to branch-2.8

The master/worker processes will dump jstack/metrics when:

Process exits normally, from an error, or SIGTERM from alluxio-stop.sh. (Note that segfault is abrupt and the process doesn't have a chance to output these information.)
Primary master fails over to standby.

The major changes in the code are:

Dumping those information into files
CollectInfo and CollectLog commands will capture those output files
Change the jstack dumping to async (https://github.com/Alluxio/alluxio/commit/9ae71902499b005852563055ae5135e97833e274 changed that to sync), so we don't block the process. The trade off is the output is not totally consistent. That should be acceptable in troubleshooting.

This change depends on
https://github.com/Alluxio/alluxio/commit/9ae71902499b005852563055ae5135e97833e274
Sample output files:
alluxio-master-exit-stacks-20230315-063353.txt
alluxio-master-exit-metrics-20230315-063353.txt
This helps persisting critical troubleshooting information because when the system unexpectedly exits or failover, the admin doesn't have a chance to manually poll these information before it's too late (process already died or primacy is lost).
See above
pr-link: Alluxio/alluxio#17081
change-id: cid-5c9dcd5abb5c9731d3c20fe734d3f8d07f8fd167
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

alluxio-bot, merge this please


Incorrect file type for generated image

Hello. Congratulations for your book. I tried the wasm application and noticed the following bug: When I upload a PNG image the final result will have a JPEG file extension. On linux if you try to open it without renaming the file extension you get an error

Thanks for letting me know. I will check the code. I made the uploader explicitly ask for JPGs only, to avoid having to type-check the incoming image.


Question: Use RadIO with TIFF/JPG

Hello experts:
Would I be able to use RadIO without the raw Dicom slices/files? I am working with CT scan images that have been cleaned and exported from Dicom to Tiff/Jpeg format. How would I use RadIO in this case? Please advise.
Thanks,
Indus

Hi, @induswell!
By default, RadIO does not support loading from TIFF/JPEG. Yet, there is a way
for you to make use of the framework. For this you need to write your own batch-class
with custom loader from TIFF/JPEG. This part could look something like
class CustomCTImagesBatch(CTImagesMaskedBatch):
   """ Your batch-class with custom loading action from TIFF/JPEG.
   """
   @action
   def load_from_images(self, images_folder):
       """ Load 3d-scans stored in JPEG.

       Assume each scan is stored in its own subfolder inside images_folder.
       """
       # initialize list of scans
       scans = []

       # iterate over items in batch
       for ix in batch.indices:
           # get folder for a specific scan
           item_folder = os.path.join(images_folder, ix)

	   # read all slices for a specific batch-item
 	   slices = read_jpegs(item_folder)	# your loader of jpegs for a scan should be here

	   # stack slices in 3d-scan and store them into the list
           scans.append(np.stack(slices))

       # concatenate scans-data into a skyscraper
       images = np.concatenate(scans)

       # put scans-data in a batch
       self.load(fmt='ndarray', images=images, bounds=np.cumsum(np.array([len(a) for a in [[]] + scans])))

    return self

To get a better understanding of how to work with data in RadIO check out this part  of the documentation.
You can then chain the loader into a pipeline with other actions from RadIO:
ds = Dataset(dataset_index, batch_class=CustomCTImagesBatch)
pipeline = (Pipeline()
            .load_from_images(folder)
            .resize(shape=(128, 256, 256))
            ...)

Best,
Alex.

Thanks for the quick response and tips, @akoryagin. I'll try your suggested approach.

The issue seem to be resolved, so I close it.
Feel free to reopen if needed.


Prefer wedging bonds that were wedged in the input SDF file

What does this implement/fix? Explain your changes.
If a molecule comes from SDF, it may have had input bonds
marked as wedged or dashed. When we choose wedge/dash bonds,
it would be friendly to take that into account.
I think that this would make it easier for users to visually
see that their input and output molecules from RDKit are
the same. Chirality is... somewhat tricky to perceive, so
any help we can give our users is nice.

The downside of this scheme is that two instances of the same
molecule that come out of RDK may have different bonds wedged/
dashed. I don't know if we were trying to canonicalize bond
wedging, though.

Any other comments?
I'm fine with dropping this if people don't like it, I don't have strong
drivers for it. I do think it would be nice for our users.

@d-b-w : It seems like it would be safer to have a function which reapplies the bond wedging from the input CTAB (if present) which can be called before calling WedgeMolBonds().
Perhaps a C++ equivalent of something like this:
https://github.com/chembl/ChEMBL_Structure_Pipeline/blob/8d599ad389a458c002be9fd8353a91ebaf370743/chembl_structure_pipeline/standardizer.py#L469

To me it seems like they serve different purposes.
Reapplying input wedging makes sense if the 2d coordinates haven't changed, and allows depictions using RDKit to match data in an SD file. It requires pretty strong knowledge of the full workflow that the molecule sits in.
wedgeMolBonds() is called whenever we write an SD file or display a 2d image. At the time that it is called, we don't know if the coordinates match the coordinates of the input file. The 2d coordinates could change by adding atoms (like, in a reaction) or by calling rdDepict (and probably other ways). It doesn't care what happens before or after.
That being said, maybe I'll take a whack at reapply_molblock_wedging() and see if I can coerce my use case to fit it.

Ah, right. Now I think I understand the use case better. So this is like doing reapply_molblock_wedging() but re-determining in which direction the wedging should go given that something, like coordinates, may have changed with the molecule. That's not completely bizarre. :-)
How about we add reapplyMolBlockWedging() but include an updateWedgeDir argument to it which defaults to true and which takes new coordinates into account? Once that's been called and wedges are present then subsequent calls to wedgeMolBonds() shouldn't have any affect, so drawings and CTABs should be generated correctly.

IIRC, I put something like that in the drawing code in the last round of
modifications.  If I am remembering correctly, it is not exposed to Python
but accessible via a drawing option. If so, it would be straightforward to
expose it for more general use.
Sorry, I don’t have my computer on to check at the moment.
Dave
On Wed, 14 Dec 2022 at 10:03, Eloy Félix @.***> wrote:

Hi @greglandrum https://github.com/greglandrum @d-b-w
https://github.com/d-b-w,
+1 to have the reapplyMolBlockWedging() in RDKit. As @greglandrum
https://github.com/greglandrum points we have it as a Python function
in our standardiser but it would be cool to have it built in RDKit.
Something that I guess the function will also help with is that 2
different properties with different values need to be checked depending if
the molecule is a V2000 or a V3000. _MolFileBondStereo (1, 6) vs
_MolFileBondCfg (1, 3)
—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/5010#issuecomment-1350775035, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FXKCFX3EDK57UBUPBDWNGLPBANCNFSM5OQSVN2Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk


Added responsive popup with bootstrap and refactored the layout struc…

I have added a responsive popup and refactored the messy layout structure. Making it responsive in all devices.

Thanks for the PR @ishan-me. Let us give one day to the other guy to work upon that issue, meanwhile you can try removing some bugs which your code creates.

@ishan-me update the PR after, now #74 is assigned to you.
Adding a modal was a good idea:+1:.

@ishan-me update this PR or make another PR after closing this one, as there are some commits in this branch which are already there in our master branch, if you still want to use this PR, then you have to reset and rebase this PR.

Closing in favor of #101.

@ishan-me I am labelling this PR as hacktoberfest-accepted because this was a good approach and this code will be used to fix #74. And I am unassigning you that issue .


Update apache-client, kinesis, sqs to 2.25.29

About this PR
📦 Updates

software.amazon.awssdk:apache-client
software.amazon.awssdk:kinesis
software.amazon.awssdk:sqs

from 2.25.21 to 2.25.29
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #853.


node-bencode can produce dictionary entries with duplicate keys.

Bug
node-bencode can produce dictionary entries with duplicate keys.

node-bencode assumes that binary string keys made out of unique Javascript string keys are unique as well, which is false.
https://github.com/webtorrent/node-bencode/blob/ee70f267c8d34b9a94820ca8c42cd67d1274fc89/lib/encode.js#L53-L55
https://github.com/ThaUnknown/uint8-util/blob/149c44c010b3ad17a7904c4266545bbca1fd4403/_node.js#L13
 encode.string = function (buffers, data) {
   buffers.push(text2arr(text2arr(data).byteLength + ':' + data))
 }

export const text2arr = str => new Uint8Array(Buffer.from(str, 'utf8'))

Proof-of-concept
For example, let node-bencode try encoding {"\uD800": 1, "\uDFFF": 2}. It’ll produce dictionary entries with the duplicate key, "3:\xEF\xBF\xBD".
const lone_surrogates = "\uD800\uDFFF";
// Lone (“unmatched”) UTF-16 surrogates. Invalid in UTF-16.

const a = Buffer.from(lone_surrogates[0], "UTF-8");
const b = Buffer.from(lone_surrogates[1], "UTF-8");
// Decoding the Javascript strings in UTF-16 and encoding them into UTF-8.

console.log(a, a.toString(), b, b.toString());
//  Since those Javascript strings are invalid in UTF-16,
// those lone surrogates are decoded
// into `REPLACEMENT CHARACTER`s (U+FFFD)
// and subsequently encoded into `<Buffer ef bf bd>`.
// Meaning,

console.log(a.equals(b));
// is true, when (lone_surrogates[0] === lone_surrogates[1]) is false.

oooh i was mentioned, yup, i have no clue what i'm looking at

Since Buffer.from("\uD800").equals(Buffer.from("\uDFFF")), node-bencode can produce multiple dictionary entries with the same key, which is invalid.


Commit from codesandbox?

This was an "experiment" trying to commit back to the repo from a forked codesandbox.


A way to load a card deck ?

Is there a way to load a deck of cards?
If not, maybe two ideas for that :
Idea 1:

A button to choose several picture files into a folder, then create picture items (stacked!) with these pictures files as front picture.
(for the back picture, select all items and choose a picture file in picture back dropzone)

Idea 2:

Drap-and-drop a new empty picture item.
Duplicate it, but with a new function (TODO) to duplicate it x times, and stack them.
With mouse, select the duplicated picture items, and in parameters :

select at back picture dropzone a picture file : ok, it works. All duplicated picture items share the same back picture.
select at front picture dropzone several picture files (the same number as items) : pb, all duplicated picture items share the first selected picture. TODO : we would map each items with a picture file (to have a different front picture).

Yes, you create deck of card quickly. I've created a (dirty) mini tutorial for you.
https://www.youtube.com/watch?v=E2lULjNFRl4
You can upload all your card images (even the back side) by drag'n'droping from your desktop to the board. Then copy the url of the back image and paste it to the back image of others card by all selecting them and "mass-edit" the back image field.
You have an action to stack items that have the corresponding action enabled from edit panel.
That's what you are looking for ?

Wow super ! It works very well.
This is still enough to make a multi-player card game.
Problem solved.

Ok thanks for the feedback. I close the issue.


Move build files, fix issues, add comments

Move the demo targets into CMakeLists.txt in the demos directory
Add a comment in .gitignore about why we're ignoring the build
directory
Change the kmod build so it doesn't put build outputs in the source
tree and stops modifying kmod/Makefile
Instead of setting the CMake build type, just make sure we add the
one flag we need to avoid a known bug.
Add more comments throughout

This breaks the build on Windows and MSVC:
------ Build started: Project: spectre_v1, Configuration: Debug x64 ------
Building Custom Rule C:/Users/asteinhauser/Desktop/safeside-mattdr-build-tweaks/demos/CMakeLists.txt
cl : Command line error D8016 : '/O1' and '/RTC1' command-line options are incompatible
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(429,5): error MSB6006: "CL.exe" exited with code 2.
Done building project "spectre_v1.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Rebased on #28 so I can see+debug the build failure.

Thanks for catching the MSVC break. I believe I've fixed it and the Travis Windows/MSVC build is green.


Darksky

I've just found your card and love the look of it. Currently, I'm using the DarkSky (https://www.home-assistant.io/integrations/darksky/) integration to gather my weather data. The problem is that it presents itself as a bunch of sensors, rather than a weather. entity.
Is there a way to pull the DarkSky sensor data into your card?

Glad you like the card 😄
You could try creating a template weather entity based on the sensors and then using that for the card.
That said, isn't DarkSky shutting down their API in March? Maybe a good time to try a different weather provider 😉

Fair enough... thanks for all your work!!!

There are two Dark Sky integrations. This is the one you need to work with this card: https://www.home-assistant.io/integrations/weather.darksky/


Adding IDEA theme

@marijnh Oh, Sorry. I merged changer from console I did not notice old changes. Okay, I will :)


Update client3:circe, client3:core to 3.3.7

Updates

com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core

from 3.3.6 to 3.3.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

labels: library-update, semver-patch

Superseded by #50.


Put the installation of Scarb in the jupyter notebook

Hi thanks for the amazing work!
I meanwhile would like to report an issue. When I am trying to run the final execution block, I found due to that I did not install Scarb, it cannot be run. However, in the notebook I did not find the instruction to install Scarb.
Maybe we can add some arguments at the very beginning?

Hi @gillsgills can you link to a specific tutorial?
This one has the steps on adding all the dependencies required.
https://github.com/gizatechxyz/orion_tutorials/blob/main/mnist_nn/QAT_MNIST_MLP.ipynb
@raphaelDkhn should I make a PR to add the dependency installation steps to the other two tutorials? It might be helpful for people trying them out in random order.

@okhaimie-dev Sure sounds good! Thanks!

Hey @raphaelDkhn @gillsgills I can work on it if it's still pending

@gillsgills Kindly assign this to me.

@gillsgills can i work on this. This is the detailed installation that needs to be added
Install via quick installation script
curl --proto '=https' --tlsv1.2 -sSf https://docs.swmansion.com/scarb/install.sh | sh
install via asdf version manager
asdf plugin add scarb
asdf install scarb latest
asdf global scarb latest


Add "missing" data sources and plotting backends to the home page tabs

Amazing new docs! https://pyviz-dev.github.io/hvplot/
The data sources section is really great for showing the power of hvPlot. Right now the purpose is to guide a single user that reads top to bottom. So Pandas is left out because its already mentioned.

But I believe it can also be used in a discussion with your team or as a screenshot or video on social media to show all the data sources that it works with. So I would really like to have Pandas included. And if others are missing (CuDF?) then get them added.
Similarly with the plotting backends. Please add Bokeh to the mix for completeness.
Thanks.

Very true! A PR would be very helpful!


fix: compile-time configurable NY-delimiter

Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes

Endpoint
Method
Request body
Response Body

API
GET/POST, etc
request
response

Possible Issues in the future
Describe any possible issues that could occur because of this change

Lets not label anything with ny and lets keep it a generic feature (no matter for what short time period we would be keeping this feature)

Write a proper PR description

we would need changes in Makefile as well, right ?


Default value not given for optional boolean parameter

On both Uap2:Verb and Uap3:Verb documentation there is an optional boolean value named "Default", which indicates whether the verb is the default shell command for the supported file type.
In the documentation, no default value is defined, leaving one to wonder what happens if the parameter is not expressed.
I would guess that not expressing the parameter should mean the same as default=no, but it really should be defined here.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5b826703-042f-7cf4-6973-20923b1373d7
Version Independent ID: b18204a7-4920-8d16-3d05-60ea49a4a8db
Content: uap3:Verb - Windows UWP applications
Content Source: winrt-related-src/schemas/appxpackage/uapmanifestschema/element-uap3-verb.md
Product: uwp
Technology: winrt-reference
GitHub Login: @drewbatgit
Microsoft Alias: drewbat

@TimMangan I traced through the source code for this and there's not really a default value. The code only sets the default if the value is present. Since this is functionally similar to there being a default value, I went ahead and specified that the default value is false. During this investigation I noticed that the code throws an error if there is already a default verb set, so I added that to the description as well "Only one verb within SupportedVerbs can be set as the default verb."


Ambiguous instructions on contributing to the project in Contributing.MD

What Operating System?
Windows

What steps will reproduce the issue?
Click on Contributing Guide link on README.md then read the instructions on how to contribute.

What would you expect to be the outcome?
A first time contributor should be able to easily understand the steps and follow through them.

All these details will help people to fix any potential bugs?
The instructions should be clear about which repository should be used to create a branch i.e. a cloned repository or a forked repository. In step three the phrase pop-up box should be removed.

Partially resolved, transferring remaining info to issue #86


Update cmake/upstream/FindCUDAToolkit.cmake

Previously MXNet includes a hotfix for a cross-compiling bug in upstream FindCUDAToolkit.cmake. Upstream has fixed the bug now. Thus remove MXNet patch and replace by upstream fix
cf https://gitlab.kitware.com/cmake/cmake/-/issues/20572

@mxnet-bot run ci [unix-gpu]


Please add or_else

Hi,
could you please add or_else to the Maybe monad?

@jasondelaat, thank you for this fantastically useful, yet unbloated, library!
I would like to see this for Either as well, but perhaps instead of defining new methods, the Maybe.maybe and Either.either methods can simply be modified (since they appear to simply be or_else named differently) such that the identity function is the default value for the second argument to those methods, since that is arguably the most common use case, and having to repeat lambda x: x (or identity, if that is defined somewhere) is tiresome and unnecessarily verbose.
For example:
class Maybe(pymonad.monad.Monad, Generic[T]):
    ...
    def maybe(self: 'Maybe[S]', default_value: T, extraction_function: Callable[[S], T] = lambda x: x) -> T:
        ...

class Either(pymonad.monad.Monad, Generic[M, T]):
    ...
    def either(
            self: 'Either[M, S]', left_function: Callable[[M], T], right_function: Callable[[S], T] = lambda x: x
    ) -> T:
        ...

I'd be happy to submit a PR, if this is something you're agreeable to.


Opposite of $ignoreChangedAttributes?

May be useful to have a reverse of this, something like $ignoreChangedAttributesExcept or $onlyChangedAttributes?
i.e. we list only the attributes that we wish to trigger an activity being logged.
Does such a thing exist? Would anyone else find it useful? Have I overlooked another way to do this?

There were already a lot of variables that allow to customize the logged attributes. A new one will just make this package a lot more complicated. I would recommend you, if you need this, to override the shouldLogEvent() method, which uses the $ignoreChangedAttributes.
https://github.com/spatie/laravel-activitylog/blob/c1dd4932d21216a3d0b23778c867ee1000eb87c7/src/Traits/LogsActivity.php#L107-L125
On the last line you could add your logic and use array_only() or you change attributesToBeIgnored() method and inverse your whitelist via the available attributes to the already existing blacklist. This could also be done on boot() in best case via trait-boot-method https://laravel-news.com/booting-eloquent-model-traits - this way you won't touch any of the package logic but could get your request done in your own trait.
If you got the trait work you are free to create a gist with it and link it here for others with this request. Keep in mind that $ignoreChangedAttributes does not remove the attributes from the log entry but just is used to decide if the entry has to be logged or not.

Hi @Gummibeer thanks for the response.
I believe this should be included. I think in Laravel we're all very familiar with whitelist/blacklist functionality like fillable/guarded. This is only a similar thing.
You say it makes the package a lot more complicated but in fact the required code changes are minimal so there is no added complexity there. What I think might be the problem is that there are already a lot of variables and this seems complicated, but I would politely suggest this is down to the documentation and explanation of each variable/property rather than the variables themselves or their implemented logic. I have personally found it confusing to get to grips with so I'm only speaking from my own experience.
I think I saw there has been some refactoring recently to make variable names more friendly and this could probably benefit from something like this:
    /**
     * Update activity won't be logged if only these attributes changed.
     *
     * @var array
     */
    protected static $dontLogUpdateFor = [];

    /**
     * Update activity will only be logged if any of these attributes changed.
     *
     * @var array
     */
    protected static $onlyLogUpdateFor = [];

Note: you may only use $dontLogUpdateFor or $onlyLogUpdateFor
What do you think?

Thanks for your input!
The complexity isn't only about the needed code - yes this isn't much. But primary to test, document and keep in mind.
I agree that there are a lot of static variables and the documentation isn't perfect. But to rework this and make these more readable we would need a v4 and it's just a month since we did the step to v3.
The next thing is the need: until now no one has requested this (except you) - so could be that they are just silent and have solved it. Or it it's really not needed.
My major problem with white-/blacklist is to define the priority.
The last decision is up to @freekmurze but he want's to keep everything as simple as possible.
My idea/offer would be to bring all the static variables and possible opposites into discussion for v4. I also see some optimization room in this area and would think about ways to list them in some way not only in the code which use it. Ideas would be to switch to non-static or even abstract methods and/or interface which forces the developer to see them all and think about what/how to use.
But so far I don't see a good reason to add more complexity if it's easy for the developer to do it himself. And like I said I would be happy about a gist for the others how to do it. If we decide to implement it we could use your gist as base.
For the future I would also like to think about an Observer approach and not the traits.

Ok, adding these new things within v3 and keep the old ones as alias but deprecated would be an option. But the problem here is that the only way to mark them as deprecated would be to put it in the docs. There is no way to use the @deprecated php-doc flag. 😕
One of my goals for a rewrite would be to find a way to have them defined with default values to remove all the isset(static::$abc) calls and be able to use php-type-hins, php-doc and so on. This would help a lot if you use an IDE like PhpStorm.
I agree that the pure addition of the new variable (whitelist) wouldn't introduce a BC. We already have a whitelist for the list of logged attributes attributesToBeLogged().
https://github.com/spatie/laravel-activitylog/blob/ae7558db4d0f926b2c02dfec50c0e927858d00a0/src/Traits/DetectsChanges.php#L26-L51
So yeah we also already have a rule how to handle whitelist and blacklist at the same time and decided the other way. An attribute listed in the blacklist will never be logged - independent of the whitelist. The reason for this was that the list of attributes could also be filled by dynamic lists (fillable & guarded).
My major issue with the current available variables is that we have two parts that have configuration for what they do:

what will trigger an activity entry (which events, which attributes if changed and so on)
what will be logged if an activity is created

Primary in the attributes case this seems pretty similar and the variables aren't clear enough there. This has caused a lot of issues in the past and even I have to open the code and look which does what.
Adding a new one will just increase this problem f it's not done right. The alias-idea could be a solution! (thanks for this) For myself I don't like to migrate this way because you have to keep code that isn't needed - I like hard breaks more, no room for deprecated usage. But I would let @freekmurze decide this, if he says a new major-release in, I would say about a month is needed, isn't an option and we should wait for more major-issues I would be fine with aliases.
To make it clear: I'm 100% with you and don't want to close this issue without a solution. But as a package collaborator I also have to keep the others in mind and with ~700k downloads atm there are a lot of them.
I would end this discussion between us two for the moment and wait what freekmurze says. We have cleared out our standing, solutions, problems and ideas but aren't able/allowed to decide how to do it.

Currently I don't want to invest time to do this. There aren't many people asking for this feature. I think it could be part of a rewrite for a new major version.
Currently a new major version of this package isn't high on my planning. If other good breaking feature ideas come in, I'll revisit this issue.


Cloud Sdk warning messaging is incorrect in the dev app server run config

closed via https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1046


Protocol Routing

Hello there, don't know if this is in the scope of the software but would be neat to have the option to route players to different proxy using different protocol versions

Hi, thank you for the idea: yes it would be in the scope of this project.
How would you represent something like this in config?

Maybe making every domain configurable like you did in [routing.protocol] could be an idea? Letting users specify a range instead of a particular version could also be an idea:
[routing.routes."hostname"]
versions = { "750..=754" = "ip1", "755.." = "ip2" }

[routing.routes."hostname"]
versions = { "750..=754" = "ip1", "755.." = "ip2" }

Although I fear this syntax might be a bit too complicated

It can work since the comments can help guide the person that is going to configure the software


Bridge in bugfixes

Description

This PR adds several crucial bugfixes to get the deposit flow working which involves:

Being able to fetch operator pubkey table from the full node and find the client's own index
Being able to poll for deposit duty and create a valid Deposit Transaction via cooperative signing
Being able to recover from catastrophic failures (client crashing, sequencer crashing, etc.) while aggregating signatures/nonces by redoing duties that could not be completed

The withdrawal process might have some bugs too but since the process is similar, deferring any bugfixes in that flow to a later PR.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Refactor

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[ ] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

I"m adding one more check in the code so let's hold off on the merge till then.

Okay, I think we're all good to go on this PR.


resource/cloudflare_account: initialize AccountSettings

Attempt to fix a panic issue with uninitialized account.Settings in resourceCloudflareAccountUpdate
Fixes #2031

thanks for this @jfchevrette. appreciate it!
instead of unconditionally initialising the Settings i opted to only initialise it when 2FA is present. this avoids unnecessary allocations only to be ignored by the struct. added a test as well to confirm the functionality works as intended.
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccount_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccount_Basic
=== PAUSE TestAccCloudflareAccount_Basic
=== RUN   TestAccCloudflareAccount_2FAEnforced
=== PAUSE TestAccCloudflareAccount_2FAEnforced
=== CONT  TestAccCloudflareAccount_Basic
--- PASS: TestAccCloudflareAccount_Basic (18.17s)
=== CONT  TestAccCloudflareAccount_2FAEnforced
--- PASS: TestAccCloudflareAccount_2FAEnforced (18.58s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	37.356s

@jacobbednarz, thank you for accepting this change! Much appreciated.
However, with the changes you added atop of the original changeset, you won't ever be able to disable the 2-factor requirements via the enforce_twofactor attribute (the test added wouldn't catch this). This is because of how schema.ResourceData.GetOK() and Go zero-values work.
Have a look at the following. I added GetOk(), GetOkExists() and printed the variable that hold the Account type, as per:

Enabling enforce_twofactor:

2022-11-18T21:49:01.484+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout="(string) (len=7"
2022-11-18T21:49:01.484+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout=") "GetOk()""
2022-11-18T21:49:01.484+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout="(bool) true
(bool) true
(string) (len=13) "GetOkExists()"
(bool) true
(bool) true
(string) (len=10) "updatedAcc"
(cloudflare.Account) {
 ID: (string) "",
 Name: (string) (len=11) "kwilczynski",
 Type: (string) "",
 CreatedOn: (time.Time) 0001-01-01 00:00:00 +0000 UTC,
 Settings: (*cloudflare.AccountSettings)(0xc000044c20)({
  EnforceTwoFactor: (bool) true
 })
}"

Disabling enforce_twofactor:

2022-11-18T23:08:03.778+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout=""GetOk()"
(bool) false
(bool) false
(string) (len=13) "GetOkExists()"
(bool) false
(bool) true
(string) (len=10) "updatedAcc"
(cloudflare.Account) {
 ID: (string) "",
 Name: (string) (len=11) "kwilczynski",
 Type: (string) "",
 CreatedOn: (time.Time)"
2022-11-18T23:08:03.778+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout="0001-01-01 00:00:00 +0000 UTC,"
2022-11-18T23:08:03.778+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout=Settings:
2022-11-18T23:08:03.778+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout=(*cloudflare.AccountSettings)(<nil>)
2022-11-18T23:08:03.778+0900 [WARN]  unexpected data: registry.terraform.io/cloudflare/cloudflare:stdout=}

Even though the logging in Terraform can be a bit unwieldy, can you see where the problem manifests itself?

the zero value issue will need to be solved by updating the struct in cloudflare-go to be a boolean pointer. regardless of where the settings struct would have been initialised, we still would have had this issue due to zero values in Terraform, not only Go (this is something I've raised with the core team a couple of times).

actually disregard; this is slightly different to the underlying issue at https://github.com/hashicorp/terraform-plugin-sdk/issues/817.
as the schema has false as the default, the update shouldn't be conditionally setting this at all. the payload should always include the value regardless.
you're welcome to send a PR removing the conditional or I can do it next week.

Hi @jacobbednarz,

actually disregard; this is slightly different to the underlying issue at hashicorp/terraform-plugin-sdk#817.

I am glad you raised this with them. I was worried that it would be a hill I, and many other people, would die on alone, so to speak. This has been an issue in Terraform for almost half a decade now.

as the schema has false as the default, the update shouldn't be conditionally setting this at all. the payload should always include the value regardless.
you're welcome to send a PR removing the conditional or I can do it next week.

You can do it at your convenience as long as it makes it into the next release. No rush otherwise. Also, thank you in advance for your help! Much appreciated.

i've raised #2036 which covers the removal use case however, in testing this, i also found a bug that prevents creating a new account with the settings from the start. the only way to apply 2FA is with a second run to update the resource. thanks for helping uncover these two issues!

Hi @jacobbednarz,

i've raised #2036 which covers the removal use case however, in testing this, i also found a bug that prevents creating a new account with the settings from the start. the only way to apply 2FA is with a second run to update the resource.

This amazing. Thank you so much!

thanks for helping uncover these two issues!

My pleasure! This is some amazing work you and your team are doing with this provider, so I am always happy to help as its user. :)


use Rebass UI components?

What do you think Rebass, any desire to use it for Nova?
http://jxnblk.com/rebass/
Finally a react-friendly (and stateless, functional) component library.

Oh that's really cool! We could totally use this, but I wonder if we need to import all these components? Or maybe just recreate the ones we want?
Also, Nova's default front-end component package is supposed to remain very simple and unstyled to be easy to customize, so I don't know if that fits in with this goal?

I think Rebass should be treated like a framework, like a Bootstrap for React.  So we just import the components that are useful.  Maybe not all are useful.  Things like the different Button components and input components could be useful.
If you look at the code, you'll see it is very simple and the styles are decoupled.  See for example Button component.  And the Base and config are also simple:
https://github.com/jxnblk/rebass/blob/master/src/Button.js
https://github.com/jxnblk/rebass/blob/master/src/Base.js
https://github.com/jxnblk/rebass/blob/master/src/config.js
It is easy to customize by writing a configuration JS file:
https://github.com/jxnblk/rebass/blob/master/demo/configurations/basic.js
I think it fits the goal very well.  If you compare this to solid.css file, the base styles are much smaller.

Hey @vonwao! I kind of refactored this issue in #1464 with some guidelines :)
I'm closing this one, feel free to give a try to what Nova is today, and maybe create a theme with Rebass! 😄 🚀


Add 'jsonKey' option for GcsPinotFS

Currently, we support 'gcpKey' option which requires to have the gcp credential file available locally.
We add 'jsonKey' option where the raw string or base64 encoded gcp credential can be passed via configuration.

Codecov Report

Merging #11890 (4335816) into master (5d58102) will decrease coverage by 15.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11890       +/-   ##
=============================================
- Coverage     61.45%   46.45%   -15.01%
+ Complexity     1147      939      -208
=============================================
  Files          2375     1778      -597
  Lines        128500    93212    -35288
  Branches      19846    15054     -4792
=============================================
- Hits          78974    43301    -35673
- Misses        43815    46863     +3048
+ Partials       5711     3048     -2663

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
46.45% <ø> (-14.86%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
46.45% <ø> (-14.84%)
:arrow_down:

temurin
46.45% <ø> (-15.01%)
:arrow_down:

unittests
46.45% <ø> (-15.00%)
:arrow_down:

unittests1
46.45% <ø> (-0.20%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 972 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Better to document and add a release notes

@xiangfu0 added the release document. I will update the documentation as well.


Rubocop offenses prevent Travis from running tests

As a contributor I want to see the full test output from Travis even if something fails.
With the current config, a Rubocop failure will cause travis to stop early and not run the test suite.
Sometimes a Rubocop offense will make it into master. When this happens we can't see if PR's pass the test suite on Travis.
I was about to create a PR to remove rubocop out of the default rake task and into the travis.yml.
But then noticed that would be undoing the work of this commit https://github.com/codetriage/codetriage/pull/611/commits/0eeb4333325d3baaee0ca2a892e398ad8e8e6676
I have opened this issue instead because I don't know the context.
What was the reason for putting rubocop in the default rake task?
And can it we move it back, or find another way to get the output of both tests and rubocop showing in Travis?
@benoittgt

TBH I like this behavior.
It's maintainer's fault (cough cough me cough cough @schneems) if stuff that breaks rubocop gets merged into master, not Rubocop's fault. We can fix the human problem here.

Master should be green, if something goes in that makes it not green, we should revert.

Hello @elliotthilaire
Sorry for this unpleasant behavior.
I saw this behavior on puma and implemented the same here. 🤷♂
At the beginning task were splitted (it will still output one result for travis) but travis was running test, then rubocop in separate task. I don't think it's possible to have two results rubocop and travis output and I don't think we want this.
If you are again one or few cop from Rubocop feel free to open an issue. 😉

Hello.
I have made an example app with 4 branches and set it up with travis to demonstrate how separating the steps in .travis.yml works.
i.e,
script:
  - bundle exec rubocop
  - bin/rails test

Please take a moment to look at:
https://travis-ci.org/elliotthilaire/rails-travis-example-app/branches

tests-pass-rubocop-passes (build pass)
tests-pass-rubocop-fails  (fails build)
tests-fail-rubocop-passes (fails build)
tests-fail-rubocop-fails  (fails build)

If you have a look at the build logs you will see output from both tests and rubocop and the build still fails appropriately.
e.g. the tests-fail-rubocop-fails case: https://travis-ci.org/elliotthilaire/rails-travis-example-app/builds/266084051
This feature is documented here: https://docs.travis-ci.com/user/customizing-the-build#Customizing-the-Build-Step

When one of the build commands returns a non-zero exit code, the Travis CI build runs the subsequent commands as well, and accumulates the build result.

In the example above, if bundle exec rake build returns an exit code of 1, the following command bundle exec rake builddoc is still run, but the build will result in a failure.

If your first step is to run unit tests, followed by integration tests, you may still want to see if the integration tests succeed when the unit tests fail.

This is the .travis.yml file.
https://github.com/elliotthilaire/rails-travis-example-app/blob/master/.travis.yml
I wasn't suggesting we make the build green if it shouldn't be. Instead if the rubocop and tests fail, we can find out in a single build instead of two.
This is especially useful if you decide to add more linters or checks to a project.
I hope that provides some clarity. If you have any questions I'll answer. Otherwise I won't push this any further.

@elliotthilaire that's what I did at the beginning https://github.com/codetriage/codetriage/pull/608/files
I'm ok with splitting the task on travis. It can even be
script:
  - bundle exec rake test
  - bundle exec rake rubocop


Automated cherry pick of #5560

Cherry pick of #5560 on release-5.24.

#5560: Force red background on mobile view header

/cc  @devinbinnie

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.


Haptics fire on Android regardless of settings

Bubble card buttons behave differently to usual Home assistant buttons in terms of haptics, so there is no way to switch off vibration..
Current behaviour:
Android = Android settings under Settings -> Sounds and Vibration -> More settings -> System Haptics
Home Assistant = Vibrate settings under user profile
Android 	Home Assistant	  HA button	   Bubble Button
On		On			             Vibrate		Vibrate
On		Off			             Vibrate		Vibrate
Off		On			             Vibrate		Vibrate
Off		Off			             No Vibrate	        Vibrate
In the case of Bubblecard, vibrations are generated in all cases.
Nothing special in terms of YAML as just configured using visual editor.
Expected behavior
Bubblecard should behave in the same manner as Home assistant buttons (or at least be able to disable the haptic response)
type: custom:bubble-card
card_type: button
button_type: state
entity: sensor.tempmasterbedroom_temperature
show_last_changed: true
show_attribute: false
name: Master Bedroom
scrolling_effect: true
show_icon: false
force_icon: false
card_layout: normal
sub_button:
  - entity: sensor.tempmasterbedroom_humidity
    name: Humidity
    show_name: true
    show_last_changed: false
    show_state: true

 - OS: Android 10
 - Browser/App: Home assistant mobile app
 - Bubble Card version: 2.2.1
 - Home Assistant version: 2024.7.4

Thank you! 🍻

Hi and thank you for the feedback. I was not aware that it is possible to turn them off, I will take a look at how I can add this to my code.

Any update on this? Cards still vibrate even though Vibration is disabled in user profile.

Hi! I tried to find how HA was handling that in the past, and I haven't found how... But I will try again! 😅

awesome, thank you, very much appreciate it! My Wallpanel is mounted to a drywall so when i press a button it fells like my whole room is shaking haha


test: Shuffle some tests between directories

Move a bunch of specific tests from testsuite/oiiotool to testsuite/oiiotool-copy to group similar tests together, and also to load balance better between the tests.

No objections + passes CI + doesn't change user-facing code = merge


fix: check for command_prefix=None before warning about message content intent

Summary
Disables the message content intent warning when using Bot(command_prefix=None), and improves the docs regarding None prefixes.
There isn't really a use for command_prefix=None since InteractionBot exists, but it should still be handled properly.
Resolves #688.
Checklist

[x] If code changes were made, then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running task lint
[x] I have type-checked the code by running task pyright

[x] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

I don't think we should fully remove the warning. Instead of displaying the message content intent warning, we should instead use a warning to use InteractionBot and None as the prefix is deprecated.

I don't think we should fully remove the warning. Instead of displaying the message content intent warning, we should instead use a warning to use InteractionBot and None as the prefix is deprecated.

Fair enough, changed it to a deprecation warning instead.


Race in DataChannel

In my app, I am seeing a race condition at the following line:
https://github.com/pions/webrtc/blob/90b85e8c7a5bf92405d2a07fde0069bcfd3ab526/datachannel.go#L189
	dc, err := datachannel.Dial(d.sctpTransport.association, *d.ID, cfg)
	if err != nil {
		d.mu.RUnlock()
		return err
	}

	d.ReadyState = DataChannelStateOpen // <------------ race
	d.mu.RUnlock()

	d.handleOpen(dc)
	return nil
}

I believe, we need to use write lock instead of read lock here.

nice catch! This sounds right to me, if you cut a PR I can :+1: it right away :)

Will do!

I thought this was fixed, but I am seeing the race at dc.ReadyState again with my app...
I noticed, in my app, that I am reading dc.ReadyState, which is of course not protected by mutex dc has... This would be the same as other parameters DataChannel struct defines as public members.
@Sean-Der @backkem I think we need to do something about it asap. What do you guys think the best way would be?  My first reaction is to make all these parameters private and add a method like GetParameters()...

I've just remembered that we already have DataChannelParameters... We could use it...?

DataChannel Properties
Mutated by Lib
User Access
Can Race

Label string
No
Read-only
No

Ordered bool
No
Read-only
No

MaxPacketLifeTime *uint16
No
Read-only
No

MaxRetransmits *uint16
No
Read-only
No

Protocol string
No
Read-only
No

Negotiated bool
Yes(?)
Read-only
Maybe

ID *uint16
No
Read-only
No

Priority PriorityType
No
Read-only
No

ReadyState DataChannelState
Yes
Read-only
Yes

BufferedAmount uint64
Yes
Read-only
Yes

BufferedAmountLowThreshold uint64
No
Read/Write
Yes


slider angle

Implements the slider angle control.
FYI -- I'm working on making python demo code that calls all of the imgui widgets via python, whereas pyimgui's demos currently defaults to calling the C++ implementation of the demos, which makes copying and pasting demo code difficult for Python programmers who may not know C++.  As part of this work of mine, I am implementing any missing controls, such as slider angle, and I plan to incrementally send over those implementations via PRs into master as I make them.
My implementation of the python-based demo is at https://github.com/billsix/pyimgui/tree/implementDemos .  Once I have implemented the full set, I plan to do a squash merge into master, and send the one final pull request for those demos.  The reason for this method is to to minimize commits of partial work that I make, which I expect to be 20+ commits of incomplete work, and instead provide 1 complete commit into your master.
However, a commit such as what I've attached is complete work, as it implements slider_control, so I believe that it should be in its own commit in master.
I just bought your book yesterday to support the good work that you are doing.  Thank you.

Coverage increased (+0.09%) to 55.866% when pulling 0e789ad8419e93f1d84aa1316af0c342aa6bd95e on billsix:master into<PHONE_NUMBER>7a7d5678eaa9d63b919f98c96688e7 on swistakm:master.

Whoa! So many good news! :)
That's great. I'm merging this in! As we fixed the multi-system pipeline I now hopefully be now able to do gradual releases.
Regarding the python-only demo, that's wonderful. People requested it numerous times and started their work but we haven't merged anything substantial yet as it was often incomplete work. Keep in mind that I plan to merge #192 this week and do a pre-release of imgui 2.0.0. That version will have some backward incompatible changes as it migrates to latest imgui version. You may want to check it out to make sure your deo will be compatible.
Thank you for buying the book :). I hope it will serve you well.

Great news, python-based demo was on my todo list for the 2.0.0 upgrade, and a little help with it would be fantastic.
It is excellent that you implement missing controls, but be aware of the changes coming. I am currently working on the upgrade from Imgui 1.65 to 1.79 (#192). As @swistakm said, this change has some backward incompatibilities, and you should be careful. Numerous functions have changed name or input arguments, some default values changed too, and many new flags have been added. Moreover, many controls have already been mapped for this new version, including SliderAngle(). Maybe we should coordinate our work a little bit to avoid repeating work?
I merged your implementation of SliderAngle() with mine, but we didn't do it very differently. I kept the documentation describing the difference between angle format taken as input (radian vs degree), default values, and new SliderFlag input. Let me know if I have forgotten something.

Sorry for my delay in responding.
Thanks for reaching out, that sounds good.  Right now I'm trying to just go
for low hanging fruit in the demo, so I'll minimize the implementation of
extra controls (i.e. stuff not already implemented, like sliderangle), and
Ill take a look at your branch as well to minimize duplicated work.
I just submitted a PR for my demo into master.  It's got most of the common
controls, and about 50 to 60% of the demo converted.
On Mon, Dec 21, 2020, 10:24 AM KinoxKlark<EMAIL_ADDRESS>wrote:

Great news, python-based demo was on my todo list for the 2.0.0 upgrade,
and a little help with it would be fantastic.
It is excellent that you implement missing controls, but be aware of the
changes coming. I am currently working on the upgrade from Imgui 1.65 to
1.79 (#192 https://github.com/swistakm/pyimgui/pull/192). As @swistakm
https://github.com/swistakm said, this change has some backward
incompatibilities, and you should be careful. Numerous functions have
changed name or input arguments, some default values changed too, and many
new flags have been added. Moreover, many controls have already been mapped
for this new version, including SliderAngle(). Maybe we should coordinate
our work a little bit to avoid repeating work?
I merged your implementation of SliderAngle() with mine, but we didn't do
it very differently. I kept the documentation describing the difference
between angle format taken as input (radian vs degree), default values, and
new SliderFlag input. Let me know if I have forgotten something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/swistakm/pyimgui/pull/197#issuecomment-749029543, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGK5SCTGOYZJFYTHCCKYITSV5SBXANCNFSM4VCOWYSA
.

Sorry for my delay in responding.
Thanks for reaching out, that sounds good.  Right now I'm trying to just go
for low hanging fruit in the demo, so I'll minimize the implementation of
extra controls (i.e. stuff not already implemented, like sliderangle), and
Ill take a look at your branch as well to minimize duplicated work.
I just submitted a PR for my demo into master.  It's got most of the common
controls, and about 50 to 60% of the demo converted.
On Mon, Dec 21, 2020, 10:24 AM KinoxKlark<EMAIL_ADDRESS>wrote:

Great news, python-based demo was on my todo list for the 2.0.0 upgrade,
and a little help with it would be fantastic.
It is excellent that you implement missing controls, but be aware of the
changes coming. I am currently working on the upgrade from Imgui 1.65 to
1.79 (#192 https://github.com/swistakm/pyimgui/pull/192). As @swistakm
https://github.com/swistakm said, this change has some backward
incompatibilities, and you should be careful. Numerous functions have
changed name or input arguments, some default values changed too, and many
new flags have been added. Moreover, many controls have already been mapped
for this new version, including SliderAngle(). Maybe we should coordinate
our work a little bit to avoid repeating work?
I merged your implementation of SliderAngle() with mine, but we didn't do
it very differently. I kept the documentation describing the difference
between angle format taken as input (radian vs degree), default values, and
new SliderFlag input. Let me know if I have forgotten something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/swistakm/pyimgui/pull/197#issuecomment-749029543, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGK5SCTGOYZJFYTHCCKYITSV5SBXANCNFSM4VCOWYSA
.


GCC: Maybe bug in kalman filter

Your environment.

Version: latest

What happened?
The bug lies in this section of code in the Kalman filter..
https://github.com/pion/interceptor/blob/master/pkg/gcc/kalman.go#L81-L84
I think it should be an if else statement, as this is what I'm seeing in another implementation https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/blob/main/net/rtp/src/gcc/imp/kalman_estimator.rs?ref_type=heads#L53-59
and how I interpret it from the RFC

If z(i) > 3sqrt(var_v_hat) the filter is updated with 3sqrt(var_v_hat) rather than z(i).

In https://datatracker.ietf.org/doc/html/draft-ietf-rmcat-gcc-02#section-5.3
It would be great to have another pair of eyes on it

@mengelbart Could you take a look?

I wasn't involved in writing the GCC implementation, but I agree with your assessment that it should be an if else statement.

Yes, I think you are correct. Want to open a PR @sterlingdeng ?


Can't connect wifi interfaces of two devices, instead wired interfaces are shown

Environment

Python version:  3.5.4
NetBox version:  2.5.5

Steps to Reproduce

Create a device type with at least one Wifi interface (e.g. IEEE 802.11ac)
Create two devices of this type
Click on "connect" button on device A and try to connect wifi interface of device B

Expected Behavior
I expected the wifi interface of device B to be shown in the interfaces list on the cable page.
This is relevant for documenting point-to-point wifi backhaul links and automation of their configuration accordingly.
Observed Behavior
Only wired interfaces are shown in the drop-down on the cable page which doesn't make sense as those should be incompatible.
Best
Max

To clarify, the bug here isn't that you can't connect wifi interfaces, it is that the wifi interface shows a connection option.
Connecting wifi interfaces was proposed and rejected in #2067 as per @jeremystretch in #2730

It might be better to allow a "Circuit" to terminate on a wifi interface, than a "Cable"

I don't disagree with that idea.

Agree. A cable-in-the-air is a bit too abstract to fit the current list of physical cables, it is more like the pre 2.5 versions model of a logic connection. It could be represented as a separate type of "cable" where color, label, length, and connector is irrelevant - or maybe like a virtual hub?

Hi,
I see the point that with the current cable management (which is great, thanks for that <3) you can "only" PTP links but no PTMP. For me this wouldn't be a blocker to allow connecting two WIFI interfaces as a lot of people (as this thread and the comments in the other tickets show without a doubt) do.
If one would like to connect multiple device one could "hack" that by adding a "WIFI Cloud" device with lots of interfaces ;-)
So IMHO it would be REALLY great if connecting wifi interfaces would be possible.
Best
Max

or maybe like a virtual hub?

The nearest thing like that is a VLAN.
You can already associate a wireless interface with a VLAN, either directly (set 802.1Q mode "Access" then update then "Add VLANs"); or indirectly (via its IP address sitting within a prefix which in turn is associated to a VLAN).  Either way models multipoint wireless connections reasonably well I think - any further would require modelling channels/frequencies.
There's still an argument that point-to-point wireless is different, and might be usefully modelled as a circuit.

But it's not a "cable".  If you were running a cable to anything, it would be an antenna.
The Netbox concept of "interface" combines a physical entity (a port), a layer 2 entity (some electronics with a MAC address) and a layer 3 interface (IP address(es)).
Suppose you have three PCs connected into a switch.  All three PCs are "neighbours" in the sense that they are sharing the same VLAN and subnet.  But Netbox doesn't show all three PC interfaces as connected to each other directly.  Instead you have:

the physical star cable topology into the switch
the interfaces are optionally associated with VLANs.  If you use this feature (i.e. configure each PC interface as "Access" port and add the VLAN), then the interfaces on the same VLAN form a group.  You can see this if you browse to the VLAN and look at the "Members" tab.
the layer3 interfaces have IP addresses, which are implicitly within a prefix, in which case all the IP interfaces within the same prefix form a group.  You can browse to the Prefix, and under the "IP Addresses" tab you can see the list of addresses with "Parent" and "Interface" linking to the device/interface.

(2) and (3) are just as applicable to wireless as to wired.  If you wanted to model (1) for wireless then it would be some sort of wifi domain, but it would be multipoint, unlike a cable or circuit.  In that regard it would be similar to VLAN, although the same VLAN could be spread over both wired and wireless parts of the network.
Adding RF and SSID attributes to VLAN might be an idea, but you can already use Description for that, or Custom Fields.

Thanks everyone for the discussion here. Let me try to sum up:

NetBox currently includes a "connect" button on wireless interfaces but does not allow for creating a connection between them. This is dumb, and is fixed in @DanSheps' PR #2896.
The Cable model is ill-suited for representing wireless connections, and would be unintuitive at best.
The Circuit model may be a good candidate for representing point-to-point wireless connections, however this (and any other discussion of new wireless mechanisms) would be out of scope for the current topic and need its own issue.


Update documentation (fixed grammatical errors)

Fixed grammatical mistakes in CONTRIBUTING.md
Added RELEASE.md describing changes

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Grammar fixes - changed 'corresponding tests, if tests' to 'corresponding tests. If tests' and removed extraneous period from 'Provide specific examples to demonstrate the steps..'. Also made 'Enhancement' lowercase to stay consistent with its usage in documentation and changed 'on the Strawberry' to 'to Strawberry'.


Error message unclear on QR code scanning

I've been trying to check my test result with scanning the QR code that I'm given, but each time I get this error dialog:

Diagnosis cannot be found

Message below is:

To make it easier to read the QR code, try to align the QR code vertically to the scanner, or turn on the flash.

I think those title and text message are not very compatible. When I read the title, I assume my test result is not in database, but when I read the text, I assume qr scan is unsuccessful.
That makes me wondering about what is the actual reason;

QR scan is unsuccessful ?
QR scan is done but code is not found ?
Code is found but test result is missing ?
Another issue ?

Internal Tracking ID: EXPOSUREAPP-3018

The reason for this message is

The QR codes is not a valid CWA Diagnosis QR Code
The QR code is not readable to recognize a valid CWA Diagnosis QR Code

Hey everyone,
I have created a Jira ticket EXPOSUREAPP-3018 for this issue so that the developers are notified.
Thanks again for your input!
Best regards,
SG
Corona-Warn-App Open Source Team

Had today the same issue with the same error message!

Still same issue today! When can we expect a solution?

See also this comment

Same issue and error message here.
I don't think readability is the problem as it happens with with 2 different tests taken by two persons at the same facility and i've no issues at all to read the information/link with a 3rd party app. It is in the format https://localhost/?XYZ whereas XYZ matches the sequence that is printed below the qr code.
I even tried to manually generate another qr code thar contains the readout information without any other result within CWA.
The sheet that contains the QR Code is specifically mentioning CWA though and matches the example here (the lower half):
https://github.com/corona-warn-app/cwa-documentation/issues/400#issuecomment-669937832
Therefore i would expect the code to be a valid one for CWA and none of the above mentionted reasons make sense to me.
Also i think it would be a good idea to be able to manually enter the sequence just to rule out any issues with the readout of the qr code.

@fuxxx

... i think it would be a good idea to be able to manually enter the sequence just to rule out any issues with the readout of the qr code.

Just for cross-reference, your suggestion is already registered under https://github.com/corona-warn-app/cwa-wishlist/issues/227.

I'm also having the same problem. I scanned my QR code which brings me to a localhost address and gives a 404. It's not clear where / how the error is happening.

I'm also having the same problem. I scanned my QR code which brings me to a localhost address and gives a 404. It's not clear where / how the error is happening.

Are you scanning the code within CWA? The code is supposed to be used within the app through the "I got tested - help and inform" (my translation) function.
Sounds to me like you are using a different QR scanner.

Are you scanning the code within CWA? The code is supposed to be used within the app through the "I got tested - help and inform" (my translation) function.
Sounds to me like you are using a different QR scanner.

I think sbourke is actually experiencing the issue mentioned by seckincann. And then tried to find out if the QR code could be read by another app, just to confirm that the issue is within CWA and not with the QR code’s readability.
I am having the same issue (that is, getting the warning as documented by the original poster) on three different devices in the family, scanning QR codes from within CWA, as actually recommended in the test receipt.
Our tests were done in Cologne, at Wisplinghoff lab, Toyota Allee, on a Tuesday morning. We were not charged for the tests. We agreed to transfer the results for CWA. (*) We tried to scan the QR code for four consecutive days. On Saturday, we tried to check the results on their website (using the GUID) and they were shown to be available since Wednesday. Therefore, I think there must be some issue between the lab and the CWA backend that caused the QR code to not be recognized (not sure on how the test information will be transferred to the backend).
I second the original author of this issue that the error message should be clearly stating “not found” instead of suggesting a QR code reading issue.maybe modify the text just a bit so it reads “your results may not have been received yet, OR your QR code was not properly scanned.” Or even better as suggested above, use different error messages for each occasion (“your QR code could be read and seems to be valid but we were unable to find your test result” / “the QR code you scanned is not recognized as a valid CWA code. Try scanning again under better conditions”...)

this part is probably the most error prone, as I think about it - maybe the agreement is not being recorded from the paper document handed before the test, and thus it is not a backend or app issue?

@durchstarter please post your experience with the lab results also at #400 - they are collecting exactly such stories and experience there

Related: https://github.com/corona-warn-app/cwa-wishlist/issues/343

@seckincann, Thank you for contributing here. In the meantime this notification was changed:

We think that this message is much clearer, and suggest closing this issue. Thanks again, Best wishes, DS

Corona-Warn-App Open Source Team

I have also suggested a further improvement to the message, mentioned by @dsarkar in the previous post here https://github.com/corona-warn-app/cwa-documentation/issues/429#issuecomment-779073282.
The suggestion for improvement is logged on the wishlist as item "Improve response to scanning non-CWA lab QR code" https://github.com/corona-warn-app/cwa-wishlist/issues/343, so that the two different error conditions:

QR code invalid due to wrong format
QR code already used

are separated and cause distinctly different error messages to be shown.

@seckincann @MikeMcC399
I suggest to close this issue in favour to corona-warn-app/cwa-wishlist#343.

Cloosed in favour of https://github.com/corona-warn-app/cwa-wishlist/issues/343. The QR code scanning and submission flow will we reworked.

Corona-Warn-App Open Source Team


avoid multiple getState calls

Summary
avoid multiple getState calls in actions/views/create_comment.tsx
Ticket Link
Fixes - https://github.com/mattermost/mattermost-server/issues/21348
Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

NONE

Hello @pradeepmurugesan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

Sorry for the long wait on this, I updated the ticket and have been talking to @pradeepmurugesan in DM as well. We would ideally be calling getState as long as it's coming from a thunk inside the component. We don't want to import it from stores/redux_store


Add alternative for the image

Hello,
I think can do this issue, Could you please assign me.
Thank you./


USHIFT-238: Set type of microshift.service to "notify".

With the default type "simple", microshift is considered ready
immediately after its process has forked instead of waiting for an
sd_notify message.

/retest-required

/approve
/lgtm