Introduce XmppDirectProducer

@oscerd You are right. The factory is totally unnecessary.

Thanks @allancth :-)
I will review as soon as possible :-)

No worries, thanks.
On a side note, Smack latest version is now 4.1.8 if not mistaken, which they do have the packet extension class required for FCM connectivity. Would it be a good idea to update Smack's library?

Yes, it's a good idea but you have to take care of the karaf features that are using smack:
https://github.com/apache/camel/blob/master/platforms/karaf/features/src/main/resources/features.xml
and check they install correctly

Noted. I'll have a look and see what needs or can be done.

Subscribe yourself to JIRA to open an issue for this. Then open another PR for the upgrade in case :-) Thanks

Noted. JIRA created: CAMEL-10423 - Integration with FCM

The commit breaks tests:
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.camel.component.xmpp.GoogleTalkEndpointTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.066 sec - in org.apache.camel.component.xmpp.GoogleTalkEndpointTest
Running org.apache.camel.component.xmpp.GoogleTalkTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.051 sec - in org.apache.camel.component.xmpp.GoogleTalkTest
Running org.apache.camel.component.xmpp.UriConfigurationTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.554 sec - in org.apache.camel.component.xmpp.UriConfigurationTest
Running org.apache.camel.component.xmpp.XmppDeferredConnectionTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.265 sec - in org.apache.camel.component.xmpp.XmppDeferredConnectionTest
Running org.apache.camel.component.xmpp.XmppMultiUserChatTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.011 sec - in org.apache.camel.component.xmpp.XmppMultiUserChatTest
Running org.apache.camel.component.xmpp.XmppProducerConcurrentTest
Tests run: 6, Failures: 6, Errors: 0, Skipped: 0, Time elapsed: 62.781 sec <<< FAILURE! - in org.apache.camel.component.xmpp.XmppProducerConcurrentTest
testNoConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 11.534 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <1> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testNoConcurrentProducers(XmppProducerConcurrentTest.java:34)

testConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 10.021 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <10> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testConcurrentProducers(XmppProducerConcurrentTest.java:39)

testConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 10.019 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <10> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testConcurrentProducers(XmppProducerConcurrentTest.java:39)

testNoConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 10.017 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <1> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testNoConcurrentProducers(XmppProducerConcurrentTest.java:34)

testConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 10.015 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <10> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testConcurrentProducers(XmppProducerConcurrentTest.java:39)

testNoConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)  Time elapsed: 10.016 sec  <<< FAILURE!
java.lang.AssertionError: mock://result Received message count. Expected: <1> but was: <0>
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.doSendMessages(XmppProducerConcurrentTest.java:58)
	at org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testNoConcurrentProducers(XmppProducerConcurrentTest.java:34)

Running org.apache.camel.component.xmpp.XmppRobustConnectionTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.708 sec - in org.apache.camel.component.xmpp.XmppRobustConnectionTest
Running org.apache.camel.component.xmpp.XmppRouteChatTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.435 sec - in org.apache.camel.component.xmpp.XmppRouteChatTest
Running org.apache.camel.component.xmpp.XmppRouteMultipleProducersSingleConsumerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.545 sec - in org.apache.camel.component.xmpp.XmppRouteMultipleProducersSingleConsumerTest
Running org.apache.camel.component.xmpp.XmppRouteTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.009 sec - in org.apache.camel.component.xmpp.XmppRouteTest

Results :

Failed tests:
org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)
  Run 1: XmppProducerConcurrentTest.testConcurrentProducers:39->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <10> but was: <0>
  Run 2: XmppProducerConcurrentTest.testConcurrentProducers:39->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <10> but was: <0>
  Run 3: XmppProducerConcurrentTest.testConcurrentProducers:39->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <10> but was: <0>

org.apache.camel.component.xmpp.XmppProducerConcurrentTest.testNoConcurrentProducers(org.apache.camel.component.xmpp.XmppProducerConcurrentTest)
  Run 1: XmppProducerConcurrentTest.testNoConcurrentProducers:34->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <1> but was: <0>
  Run 2: XmppProducerConcurrentTest.testNoConcurrentProducers:34->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <1> but was: <0>
  Run 3: XmppProducerConcurrentTest.testNoConcurrentProducers:34->doSendMessages:58->CamelTestSupport.assertMockEndpointsSatisfied:875 mock://result Received message count. Expected: <1> but was: <0>

Tests run: 16, Failures: 2, Errors: 0, Skipped: 6

Can you take a look? Thanks.

Noted.

Will do another PR when ready.


test: synchronizing gherkin spec

What
APM agent specs automatic sync
Why
Changeset

https://github.com/elastic/apm/commit/48565ba OTel bridge spec (https://github.com/elastic/apm/pull/516)

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-03-16T08:56:26.939+0000

Duration: 26 min 46 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
4827

Skipped
3207

Total
8034

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Port memory-based loader and CMAKE support

This PR does the following:

port the memory-based loader from the version in the zip on the website: https://www.catnapgames.com/2013/04/09/nltemplate-html-template-library-for-c/
add CMAKE support
fix the markdown of the README

Hi!
I'm not the author of the original work, but there is apparently no "official" public repo.
Then, I merge the PR as there is no other obvious place to do so!


Add lldb to the tools list

This works in local testing on my macOS box.
I did not know how to write a test case for this, so I could use some help here.

Thanks for this! I'm a little hesitant to do this though as this is inserting a new lldb executable into users PATH which seems like it'll be easy to clash. For unstable tools like the LLVM binutils we only ship them in the sysroot and then rely on wrapper tools like cargo-binutils to find them, but is such a strategy not feasible for LLDB? If not, could this perhaps be called rust-lldb to avoid clashes with system-installed versions?

rust-lldb just invokes lldb from the path, so if we require cargo lldb or some such, then rust-lldb will have to be adapted somehow.
I tend to think installing an lldb in the user's path is the better approach, though.  Primarily, I think, because you have to ask for this -- lldb isn't a default tool and it is only nightly.

I'm worried about confusing developers who aren't as familiar with rustup to know what's going on

I'd like to take one last stab at convincing you that this is all ok.  If you're still not convinced, I will look into the cargo binutils approach.
Here are the reasons I think it makes sense to make this link.

Rust's lldb is optional.  It is only available in nightly and it is not installed by default.  Users must ask for it by adding a component.  I think users are generally sophisticated enough to not need a second layer of safety -- the gate of asking for the package to be installed is enough.

Rust's lldb is actually just the standard lldb.  We just have a snapshot of upstream lldb and clang.  It's easy to rebase these and bring over any fixes.  Rust's lldb will work as well for C and C++ as any other lldb.

If Rust's lldb is not installed, then the failure mode will be quite different: users will try lldb and it will not work in some situations.  That will happen because only the Rust lldb will understand their program properly.

Finally, this seems to be accepted practice in other toolchains.  Swift has its own fork of lldb but the swift instructions do not mention anything special here, implying that it is added to the path.

Some thoughts:

Rust's lldb is optional. It is only available in nightly and it is not installed by default

We might in the long-run want to install it by default, ideally we wouldn't mess with the names then

Rust's lldb is actually just the standard lldb

User's might have non-standard lldbs installed though, e.g., Swift's.

3 4

These seem like good reasons.

We could tweak rust-lldb yeah or simply repurpose it on OSX to the actual binary (which should probably have the pretty printers anyway)?

This seems like a pretty good solution to me. @tromey do you think re-using rust-lldb would work? If not, I think we should  just install as lldb - it is optional to install, and if that is the best way forward we could keep it optional.

@tromey ah yeah as @nrc mentioned I think we should plan for installing LLDB by default, and in that case it'd be in PATH by default and may override other LLDB installations. Also isn't ours "special" in that it doesn't do "the thing" with signing code on OSX, right? (does that mean it doesn't work for everything on OSX? or has that changed?)
I agree that we should try to avoid the weird failure cases, but I think we can do that by always saying that users should execute rust-lldb, right? That way if it's not installed they get a clear error explaining why.
I also sort of trust Swift to ship its own LLDB than us, they've got a lot more Apple people looking at it than we do :(

Also isn't ours "special" in that it doesn't do "the thing" with signing code on OSX, right?

The lldb build will pick up the xcode signed lldb-server rather than the unsigned one.  Which is weird but has the side effect of making it work for us.  As far as I can tell.
Any opinions on what would be a good name for our lldb?  I am not sure I am ready yet to remove the rust-lldb script and rename "lldb" to "rust-lldb".  Instead in the interim I think I would prefer to make rust-lldb adaptive, assuming that's possible somehow.

That way if it's not installed they get a clear error explaining why

They won't because stock lldb pretends that rust is c++ and will try to solider on.  That is, with the current plan "lldb myprogram" will still do something, and a user may or may not notice until the debugger prints something incorrect.

Ok, thanks.  I'll come back around when the prerequisites are done.

If we don't make a wrapper at all, perhaps we can just keep the name lldb and have rust-lldb look for that name in the sysroot.  This seems simplest of all.

Yeah that sounds reasonable to me!

https://github.com/rust-lang/rust/pull/53973


Show env and tag in Slack message when deploying Puppet

Takes inspiration from #11819. See at a glance which environment and which release is being deployed.

Didn't work. Not high value enough to investigate.


Support for iPhone 13 Pro

Error saying it only supports arm, not arm64.

yes, the current version doesn't support newer jailbreaks. I'm going to consider this issue "ios 15+ support" and close it as a dupe of https://github.com/EthanArbuckle/carplay-cast/issues/77
iOS 15 support is in progress


Generate series of .table-responsive-* classes to accomodate overflowing tables in a variety of screen sizes

The old .table-responsive was nice because it helped manage unwieldy tables. This adds responsive tables at all screen sizes and at each breakpoint, .table-responsive, .table-responsive-sm, .table-responsive-md, .table-responsive-lg, and .table-responsive-xl respectively.

Dang, that's a rad update. Slating for Beta 2!

@pat270 nice PR. can you confirm the behavior of this feature? most of our responsive classes work  by applying the state to everything above them. This ones works the opposite direction, correct?
If I say table-responsive it will only apply to XS sizes, and if I say table-responsive-xl it will apply to all sizes, correct?
Thanks!

@browner12 It's actually the other way around. table-responsive applies to all sizes and table-responsive-xl applies to screen sizes 1199px and below.
https://github.com/twbs/bootstrap/blob/v4-dev/docs/4.0/content/tables.md#responsive-tables


Utilize MissingProbes config for offset errors

Instead of auto aborting if uprobe/kprobe alignment is invalid or if there is a kprobe offset error, use the value of the MissingProbes config to determine if we should abort, warn, or ignore.
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

Maybe a different fix here is to just not force safe_mode in the alignment check. It already defaults to true in most cases so if users want to override they can just pass --unsafe

Upon closer inspection. I think I might abandon this PR and just remove the HAVE_UNSAFE_PROBE compiler flag, which doesn't make a ton of sense to me since we already default to safe_mode. It also feels better as an explicit command line flag instead of a config.

Really there are a few options we could expose to users in the case of invalid alignment:

warn and force attach anyway
user failure (similar to abort)
warn and just skip probe attachment
silently skip probe attachment

Upon closer inspection. I think I might abandon this PR and just remove the HAVE_UNSAFE_PROBE compiler flag, which doesn't make a ton of sense to me since we already default to safe_mode. It also feels better as an explicit command line flag instead of a config.

Agreed. IIUC, not compiling with -DALLOW_UNSAFE_PROBE (which I believe most distros don't use) will force the safe mode for probe alignment checks but not for any other case (e.g. usage of system()). I'm not sure what the motivation for the flag was but it feels sort of redundant to me.
I also remember some discussion where someone claimed that kernel will not allow unaligned kprobes anyways. Maybe we could verify that and get rid of the check entirely (at least for kprobes)?

Really there are a few options we could expose to users in the case of invalid alignment:

warn and force attach anyway
user failure (similar to abort)
warn and just skip probe attachment
silently skip probe attachment

I think that it's generally a good idea to respect what we do for missing probes here.

I think that it's generally a good idea to respect what we do for missing probes here.

That means we would never attempt attachment if the alignment is invalid. Do we see any use cases where we want to allow users to force attachment? If not, then I'll keep this PR and just delete the compiler flag.

You're right, allowing to force the attachment is the reason why unsafe flag exists for this case. I'm not very familiar with its motivation, though.

I also remember some discussion where someone claimed that kernel will not allow unaligned kprobes anyways.

Yup, this seems to be the case - at least on my 5.12 kernel.
ERROR: Possible attachment attempt in the middle of an instruction, try a different offset.
ERROR: Error attaching probe: kprobe:do_nanosleep+2

Abandoning in favor of this: https://github.com/bpftrace/bpftrace/pull/3476


fix: update automated-interpretability dep to use newly released version

Description
This PR updates pyproject.toml to pull in newer versions of the automated-interpretability dependency. This dependency was recently updated to relax numpy and scikit-learn dependencies to help make SAELens easier to install, especially on colab. However, since the version number for automated-interpretability is 0.0.x, poetry's ^ dependency operator won't update to new versions automatically. This PR changes the dependency specification for automated-interpretability to >=0.0.5,<1.0.0 to allow minor and patch versions of this library to be automatically installable.
Fixes #246
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

[x] I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

seems like torch 1.4 causes some typing errors with optimizers, will investigate how to address...


dropwizard-testing JUnit 5 extensions documentation

The current documentation (1.3.X) does not mention the built in support for JUnit 5 extensions added in #2166.
Documentation for 2.0.0 has an example of DropwizardClientExtension, but it there's no references or examples of ResourceExtensions, DropwizardAppExtension or DAOTestExtension.

@dotTrench The JUnit 5 extension is documented in the current master branch which Dropwizard 2.0.x will be based on:
https://www.dropwizard.io/en/latest/manual/testing.html

Those docs still seem to only include DropwizardClientExtension, though


"Review and edit settings for the Report Phishing add-in"

The section "Review and edit settings for the Report Phishing add-in" can be improved in two ways:

The current link to "Services and add-ins" is outdated -- it takes user to the "Org settings" page. Instead, it should be /Settings/Addins ("Add ins" or "Integrated apps" in newer releases). If user follows the link he's never find "Report phishing" in that list.

More importantly, in this section there should be a link or a brief description of "User submissions policy" from the "Security and Compliance center" -- that's what most people are looking to configure after enabling the add-in.

Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 214e9296-0909-0946-57b0-dca5f22ee854
Version Independent ID: 689f3c32-eeb9-9c60-5d7c-78ebd6dcb165
Content: Enable the Report Phish add-in - Office 365
Content Source: microsoft-365/security/office-365-security/enable-the-report-phish-add-in.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: siosulli

I have fixed this links in the Enable the Report Phish add-in - Office 365 article and it should be available shortly.
Users submissions is already referenced in the what-do-you-need-to-know-before-you-begin section and the view-and-review-reported-messages sections.

I have fixed this links in the Enable the Report Phish add-in - Office 365 article and it should be available shortly.
Users submissions is already referenced in the what-do-you-need-to-know-before-you-begin section and the view-and-review-reported-messages sections.


[NEW ALGORITHM] I want to Insert Interpolation Search Algorithm

Description:
The Interpolation Search is an improvement over Binary Search for instances, where the values in a sorted array are uniformly distributed. Interpolation constructs new data points within the range of a discrete set of known data points
Checklist:

[✔ ] Contributor in GSSoC-ext
[ ✔] Want to work on it

Additional Information:
Time Complexity: O(log2(log2 n)) for the average case, and O(n) for the worst case
Auxiliary Space Complexity: O(1)

Hey I have already completed it Please do another


Package description should be more expository

a longer description that doesn't define the package in terms of itself?

hi, my suggestion was to change the description field, aren't we in charge of that part?

Description is changed to This package supports sending push notifications to your mobile device, using the IBM Bluemix Push Notifications service.


Add an option to create client proxy through source generators

I tested Kiota generator in one of our projects, and I can tell is great, I like the way the client proxy is generated, however, there is the downside that, we need to start the website to have the swagger.json available, in order to generate the proxy, this unfortunately is not efficient in the initial stages of API development when endpoints change drastically constantly.
We'd like to have an alternative version using C# Incremental Generators, to create the client proxy as the code is been written.

Hi @efonsecab,
Thanks for your interest in kiota and for reaching out.
We've considered multiple options to integrate with the ASP.NET stack over the years for automatic client generation.
One of which was OpenAPIReference support, but there are severe limitations of that stack which lead us to give up on that option. (See #3005 and #544 and associated PRs/issues).
We've also looked at source generators in the past, while we haven't done any development for that option, it brought more questions than we had answers.
First off, source generators are limited to netstandard2.0 which poses severe performance and capabilities limitations, the dotnet team doesn't seem to have any plan to modernize them as far as we know. This could be worked around by having kiota as a separate process and using JSON-RPC to interact with it, like we do for the vscode extension today. This approach would still require the "installation" of kiota to be managed somehow.
Then, the experience still needs to be determined: I'm guessing this would work with a combo of an attribute + source generator. The attribute would allow users to set things like the client class name, usage of the backing store, etc... This brings the questions: where would this attribute live? Would people use the source generator to generate anything else than CSharp? I'm curious to your expectations here.
Also, the client code usually resides in a different project than the API project. We'd need to be able to "navigate" between the two (as far as I remember source generators allow for that), and "ask" additional details when multiple API projects are part of the solution.
Lastly, I don't believe the ASP.NET OpenAPI generation today exposes and API for source generation (it performs the description generation as runtime as far as I know), and we'd need to solve for that as well, without reimplementing all the logic behind the attributes, etc...
Your input is extremely valued here in terms of experience you'd expect from such a source generator.

Thanks for the additional context.
Is this something you'd be willing to explore and build a POC for?

Thanks for the additional context. Is this something you'd be willing to explore and build a POC for?

Yes, for sure, I may eventually need some guidance on Kiota's patterns, coding style and such.

don't hesitate to ask follow up questions!

Hey @efonsecab !  I really like the idea of being able to generate the client as you are designing the API.  It is something that I have done while describing the API using TypeSpec to generate my OpenAPI.
However, Kiota is optimized to build from OpenAPI and I think it would be a significant amount of  work to adapt that strategy.  Have you considered instead, exploring ways to generate OpenAPI from an ASP.NET at compile time instead of having to run the API?   The Endpoints Explorer feature in VS 2022 must use some similar mechanism to be able to create the tree of API actions at design time.  https://devblogs.microsoft.com/visualstudio/web-api-development-in-visual-studio-2022/

Hey @efonsecab !  I really like the idea of being able to generate the client as you are designing the API.  It is something that I have done while describing the API using TypeSpec to generate my OpenAPI.
However, Kiota is optimized to build from OpenAPI and I think it would be a significant amount of  work to adapt that strategy.  Have you considered instead, exploring ways to generate OpenAPI from an ASP.NET at compile time instead of having to run the API?   The Endpoints Explorer feature in VS 2022 must use some similar mechanism to be able to create the tree of API actions at design time.  https://devblogs.microsoft.com/visualstudio/web-api-development-in-visual-studio-2022/

Hello @darrelmiller, thanks for the reply. I had done some research, considered creating an Incremental Source Generator which would be in charge of invoking the kiota CLI, though it may not work for every solution since it would require the API to have already be compiled in order to process the swagger file.
I need to check the swashbuckle CLI and the source code to verify if I could use any patterns from there without re-implementing all of the swagger file generation logic.


add navigation to a new tab in background.

Using background script to gain access to this operation (tabs.create).

Thanks @gilhanan , looks good overall!
Can you please update the "new in 0.26" section in https://github.com/infokiller/google-search-navigator/blob/master/assets/chrome_webstore_description.txt
Thanks

Thanks :)
Updated chrome_webstore_description.txt


Add consuming modifier to lvalues that are passed by value and not Copy

Related to #5856

bors r+


Add feature to disable automatic Do-not-disturb on Focus time

Add the possibility to disable/enable automatic Do Not Disturb status while on Focus time.

Hi sergetherriault,
You can change some settings for your focus time. Open the MyAnalytics Focus page and then select Plan configuration. On the Configurations page, in the Plan configuration area, you can select Yes or No for Silence Teams notifications during focus time? Does this cover what you want to do, or are there sources of notifications other than Teams that you'd like to allow/disallow while in your focus time?
Thank you,
-- paul9955

Hello Paul,
I have none of those options.  What I would like to do is have my status to be “Busy” instead of “Do not disturb” in Teams while I am on focus time which was automatically scheduled.
Here is a screenshot of the configuration available in MyAnalytics.  As you can see, there is almost nothing that is customizable.
<EMAIL_ADDRESS>Thanks,
Serge
[Logo Desjardins 2018]
Serge Therriault, M. Sc., PSPO, PSM
Analyste d’affaires
Analyse d’affaires, Bancaire
Stratégie, Marketing Mouvement et Services aux particuliers
Montréal
514 281-7000, poste 5554513
1<PHONE_NUMBER>, poste 5554513
Mobile :<PHONE_NUMBER>
Faites bonne impression et imprimez seulement au besoin!
Ce courriel est confidentiel, peut être protégé par le secret professionnel et est adressé exclusivement au destinataire. Il est strictement interdit à toute autre personne de diffuser, distribuer ou reproduire ce message. Si vous l'avez reçu par erreur, veuillez immédiatement le détruire et aviser l'expéditeur. Merci.
De : Paul Schafer<EMAIL_ADDRESS>Envoyé : 27 novembre 2020 18:01
À : MicrosoftDocs/OfficeDocs-WorkplaceAnalytics<EMAIL_ADDRESS>Cc : Serge Therriault<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [MicrosoftDocs/OfficeDocs-WorkplaceAnalytics] Add feature to disable automatic Do-not-disturb on Focus time (#179)
Sécurité –  Ce courriel provient d'un expéditeur externe. Merci d'être vigilant, particulièrement avec les liens et pièces jointes, et de ne jamais donner des informations personnelles.
Warning – This email is from outside Desjardins. Don’t click any links or attachments unless you trust the source. Never share personal information.
Hi sergetherriault,
You can change some settings for your focus time. Open the MyAnalytics Focushttps://myanalytics.microsoft.com/?v=focus page and then select Plan configuration. On the Configurations page, in the Plan configuration area, you can select Yes or No for Silence Teams notifications during focus time? Does this cover what you want to do, or are there sources of notifications other than Teams that you'd like to allow/disallow while in your focus time?
Thank you,
-- paul9955
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-WorkplaceAnalytics/issues/179#issuecomment-735007254, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5FS35WQP52BTFZQYJKEITSSAVRPANCNFSM4UE4YJ2Q.

Hi Serge,
I've passed your request on to the product team. I'll respond here when I find out more from them.
Thank you,

paul9955

Hello again Serge,
I just heard back from a program manager on the product team. Here's what she said: "Currently, users do not have a way of modifying their Status to Busy during Focusing Time.  This is a request that customers have made and we are looking into how we can incorporate this feedback."
So, we know that this is on their radar, and you have added weight to this request. If that capability appears, I will update the MyAnalytics documentation with a full description.
Thank you,
-- paul9955

Hello Paul,
Great news.  Thanks for the followup !
Serge
[Logo Desjardins 2018]
Serge Therriault, M. Sc., PSPO, PSM, PMI-ACP
Analyste d’affaires
Analyse d’affaires, Bancaire
Stratégie, Marketing Mouvement et Services aux particuliers
Montréal
514 281-7000, poste 5554513
1<PHONE_NUMBER>, poste 5554513
Mobile :<PHONE_NUMBER>
Faites bonne impression et imprimez seulement au besoin!
Ce courriel est confidentiel, peut être protégé par le secret professionnel et est adressé exclusivement au destinataire. Il est strictement interdit à toute autre personne de diffuser, distribuer ou reproduire ce message. Si vous l'avez reçu par erreur, veuillez immédiatement le détruire et aviser l'expéditeur. Merci.
De : Paul Schafer<EMAIL_ADDRESS>Envoyé : 1 décembre 2020 19:47
À : MicrosoftDocs/OfficeDocs-WorkplaceAnalytics<EMAIL_ADDRESS>Cc : Serge Therriault<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [MicrosoftDocs/OfficeDocs-WorkplaceAnalytics] Add feature to disable automatic Do-not-disturb on Focus time (#179)
Sécurité –  Ce courriel provient d'un expéditeur externe. Merci d'être vigilant, particulièrement avec les liens et pièces jointes, et de ne jamais donner des informations personnelles.
Warning – This email is from outside Desjardins. Don’t click any links or attachments unless you trust the source. Never share personal information.
Hello again Serge,
I just heard back from a program manager on the product team. Here's what she said: "Currently, users do not have a way of modifying their Status to Busy during Focusing Time. This is a request that customers have made and we are looking into how we can incorporate this feedback."
So, we know that this is on their radar, and you have added weight to this request. If that capability appears, I will update the MyAnalytics documentation with a full description.
Thank you,
-- paul9955
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-WorkplaceAnalytics/issues/179#issuecomment-736913768, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5FS35NMQL2M2RDJBO2EKTSSWE7RANCNFSM4UE4YJ2Q.

You're welcome, Serge!

Paul


Include detekt to perform static code analysis during PRs

implement in https://github.com/tapptitude/AndroidKotlinMVVMTemplate/pull/44


Link to GitHub repos for each application

I think it would be good to have a prominent GitHub link for every application on the page.
Personally I tend to click code first, then the application, because I want to know whether it's up to date, dependencies, see the README, etc.

Created landing page based on the code and layout used by Trafford Data Lab https://github.com/traffordDataLab/traffordDataLab.github.io.

I don't understand. Is this deployed? I can't see GitHub links

Do you mean this https://cdu-data-science-team.github.io/? I need to update the README, I missed that but the link is the about.

Ah, do you mean have a GitHub link near each image?

Much as I love GitHub, I'm just going to call you I think, do it the old fashioned way :laughing:


Provision for query logs

Is your feature request related to a problem? Please describe.
There are many cases where we want to see queries which are actually getting executed when there is any database operation.
In loopback juggler we can use DEBUG=loopback:connector:postgresql
It would be great of there is any provision for doing so.

It's already there @subhamjagurisf. The debug string is named as loopback:sequelize:queries.
Documented here: https://github.com/sourcefuse/loopback4-sequelize#debug-strings-reference
PS: Please use the official version of this package: https://www.npmjs.com/package/@loopback/sequelize as we'll be deprecating loopback4-sequelize soon and upcoming updates will be published on the @loopback/sequelize only.


Get rid of special TreeNodes

Is your feature request related to a problem or challenge?
Currently there are many special TreeNode trees in DataFusion so as to carry additional information needed for tree transformations. These special trees are a bit cumbersome as they need to implement TreeNode functions (apply_children(), map_children()).
Describe the solution you'd like
I'm suggesting to add TreeNode.transform_with_payload(), TreeNode.transform_down_with_payload() and TreeNode.transform_up_with_payload() to propagate down/up additional information during TreeNode transformation.
Please see 4. in https://github.com/apache/arrow-datafusion/pull/7942 and its POC implementation.
Describe alternatives you've considered
No response
Additional context
No response

let me open a PR once https://github.com/apache/arrow-datafusion/pull/8653 landed.

I checked SortPushDown and ExprOrdering when opened https://github.com/apache/arrow-datafusion/pull/8664 on the top of this PR.

We have also observed the complex API and different implementation approaches of TreeNode. I'm not sure if this is the right place to share these but, let me share our findings and a simple POC of how we can have a new trait providing a simpler and more understandable API:
Since the general approach in Datafusion tree structs involves having the children nodes within the self node, a pure transform_down cannot be performed. Even if the nodes are applied by the given op() in pre-order, the build order is always bottom-up. Inserting some logic into that build process (into map_children()) can introduce hidden transform-up functionality. For transform-up()s, the same flexibility may also cause the spread of a rule's logic into different parts of the code, going against code integrity.
There are also some unused functionalities and outcome types in general, so I think that a more simple API is enough usually. I scribbled a little and came up with something like this, sharing it here in case it's useful.
trait TreeNode_v2: Sized {
    fn children<'a>(&mut self) -> &'a mut [Self];

    fn transform<F>(&mut self, op_up: &mut F, op_down: &mut F) -> Result<()>
    where
        F: FnMut(&mut Self) -> Result<()>,
    {
        op_down(self)?;

        let children_as_mut_ref = self.children();
        if !children_as_mut_ref.is_empty() {
            children_as_mut_ref
                .iter_mut()
                .map(|c| c.transform(op_up, op_down))
                .collect::<Result<_>>()?;
        }

        op_up(self)?;
        Ok(())
    }
}

op_up and op_down may also be separated into 2 different functions. But the key concept is that the user only must implement how the node reaches its children, and the corresponding rule logic to apply while traversing the tree. It is also important that the whole tree must be created before the traversals with default payloads. Before the refactor, there were some places making on-the-fly children construction during the traversal.
I don’t know yet how this design can be integrated with the existing TreeNode, but in many places, such a design makes things easier and more understandable.

I think think this is partly the same idea I was suggesting in 1. of https://github.com/apache/arrow-datafusion/pull/7942. The main point there was that the closures change from FnMut(Self) -> Result<...> to the self mutating FnMut(&mut Self) -> Result<...>.
(Please note that the TreeNodeTransformer trait is not important in my PR. I just added there it to make transform() similar to the existing rewrite(). rewrite() uses a TreeNodeRewriter that has a pre-order (pre_visit()) and post-order like (mutate()) methods collected into one object, but I too would prefer separate f_down and f_up closures. Actually the new transform_with_payload() in https://github.com/apache/arrow-datafusion/pull/8664 follows that idea.)
Where I see some differences is the return type of our closures. Your code snipett shows Result<()> while I was suggesting Result<TreeNodeRecursion>. This is because I wanted to deprecate the current rewrite() / TreeNodeRewriter and replace/combine that with a new transform() method. If we want to do that then the new closures need to be able to prune the tree traversal (skip a subtree) and I don't think we can do it with a simple Result<()>.
(Actaully as the same pruning capability is needed for the TreeNode.apply() / TreeNode.visit() as well so I poposed to have a common TreeNodeRecursion enum for visit and transform functions. This is 2. in https://github.com/apache/arrow-datafusion/pull/7942)
So basically here is the transform() I suggested:
trait TreeNode_v2: Sized {
    fn transform_children<F>(&mut self, f: &mut F) -> Result<TreeNodeRecursion>
    where
        F: FnMut(&mut Self) -> Result<TreeNodeRecursion>;

    fn transform(&mut self, f_down: &mut F,f_up: &mut F) -> Result<TreeNodeRecursion>
    where
        F: FnMut(&mut self) -> Result<TreeNodeRecursion>,
     {
        // Apply `f_down` on self.
        f_down(self)?
            // If it returns continue (not prune or stop or stop all) then continue
            // traversal on inner children and children.
            .and_then_on_continue(||
                // Run the recursive `transform` on each children.
                self
                    .transform_children(&mut |c| c.transform(f_down, f_up))?
                    // Apply `f_up` on new self.
                    .and_then_on_continue(|| f_up(self)))?
            // Applying `pre_transform` or `post_transform` on self might have returned
            // prune, but we need to propagate continue.
            .continue_on_prune()
    }
}

Regarding

the key concept is that the user only must implement how the node reaches its children

I totally aggree.
But my question about fn children<'a>(&mut self) -> &'a mut [Self]; is that can we return children as &mut[Self] without collecting them into a temporary collection like Vec? Currently Expr.map_children() doesn't collect the children into a temporary collection so if we start doing it then we might introduce some performance regression.
BTW I was trying to follow a very similar approach initially. My initial children() returned an impl Iterator<Item=&mut Self> so as to avoid collecting childrens. But I simply couldn't implement it for Expr without returning an dynamic dispatch iterator so I remained at the above transform_children() that is similar to the current map_children().
Lastly, in this particulat issue I wanted to see if there is a way to get rid of those special trees. It seems unecessary to create those thees and I found it very hard to follow how additonal payload is propagated down/up. In https://github.com/apache/arrow-datafusion/pull/8664 I removed SortPushDown and PlanWithRequitements and ExprOrdering with the help of transform_down_with_payload() and transform_up_with_payload() functions and I think the new f_down / f_up closures are much simpler to understand now.
But, I'm open for other proposals like @alamb's https://github.com/apache/arrow-datafusion/issues/8663#issuecomment-1870402672 although I'm not sure yet if capturing the state in the closures make things easier.

Thanks @peter-toth for your detailed explanation ☺

Where I see some differences is the return type of our closures. Your code snipett shows Result<()> while I was suggesting Result<TreeNodeRecursion>. This is because I wanted to deprecate the current rewrite() / TreeNodeRewriter and replace/combine that with a new transform() method. If we want to do that then the new closures need to be able to prune the tree traversal (skip a subtree) and I don't think we can do it with a simple Result<()>. (Actaully as the same pruning capability is needed for the TreeNode.apply() / TreeNode.visit() as well so I poposed to have a common TreeNodeRecursion enum for visit and transform functions. This is 2. in #7942)

I hadn't thought deeply about the return type, but your suggestion makes a lot of sense.

But my question about fn children<'a>(&mut self) -> &'a mut [Self]; is that can we return children as &mut[Self] without collecting them into a temporary collection like Vec? Currently Expr.map_children() doesn't collect the children into a temporary collection so if we start doing it then we might introduce some performance regression.

I wasn't aware of Expr specifically, but I considered this approach because collection is already performed in all rules on the physical plan side.
I will review #8664 and write my new thoughts there. I believe we will find the most appropriate solution 🚀

Is this ticket still tracking anything I wonder (or is it now covered by #8913 🤔 )

Is this ticket still tracking anything I wonder (or is it now covered by #8913 🤔 )

I believe https://github.com/apache/arrow-datafusion/pull/8891 had covered this issue.

I think we can close this issue as https://github.com/apache/arrow-datafusion/pull/8817 reduced the number of TreeNode by introducing PlanContext and ExprContext.

Thanks again @berkaysynnada  and @peter-toth  -- the TreeNode API is looking quite good these days


Microsoft Edge adds extra margin to heading and paragraph elements

I'm using Microsoft Edge version 107.0.1418.56 and I'm noticing it adds a couple of margin rules to just about any text element. Here's an unstyled <h2> as an example. See how there's a little bit of top and bottom margin?

Just to double-check I opened the styles tab and yes, the "user agent stylesheet" added a couple of rules.

I'm wondering if these rules should be added to normalize. If so, I'd be happy to create a PR.

stale issue


Added Cody Barr to list of devs 😉.

Howdy guys 👋🏻

Good stuff!

Be sure to sign up at https://hacktoberfest.digitalocean.com and do your four pull requests before the end of October to get your free t-shirt!


(Solution Needed) Program to convert string from lower case to upper case

@SahilKr24 can i work on this issue.

done the program as 32.c

updated in the program 02.h


metro_nav: 0.1.0-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository metro_nav to 0.1.0-1:

upstream repository: https://github.com/MetroRobots/metro_nav.git
release repository: https://github.com/ros2-gbp/metro_nav-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: null

kinematics_2d
* Initial kinematics_2d_msgs and kinematics_2d packages
* Contributors: David V. Lu

kinematics_2d_msgs
* Initial kinematics_2d_msgs and kinematics_2d packages
* Contributors: David V. Lu

By looking at the source, I'm unsure if the functionality in the packages kinematics_2d and kinematics_2d_msgs is generic. Can you please confirm if these aren't specific to any application or robot perhaps?

This is a generalization from the nav stack. The goal is to cover a wide range of mobile base applications where the base moves in x, y and theta directions. It does not apply to ackermann bases. What name would you suggest?

I'd suggest prefixing with the project name to easily meet REP144 requirements. metronav_kinematics_2d (etc.) would be great

Would you consider base2d_kinematics as sufficiently specific?

yeah, in the interest of unblocking, that seems to at least narrow in the package scope somewhat - let's move forward with that proposal

Closing for https://github.com/ros/rosdistro/pull/38484


Added Search Bar Category and a Component

Fixes Issue🛠

Closes #119
Description👨💻

I have added a search bar component
Type of change📄

[x] New feature (non-breaking change which adds functionality)

This has been tested✅

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
https://github.com/Rakesh9100/Beautiify/assets/125905089/0c6163e2-27f9-4756-84e8-4a6f7934567a

Nice, Merged!! 🎉 @saurav2208


Removed workaround for deprecated get_work RPC call

Deprecated in 2013, I think people have had enough time by now :)

Coverage increased (+0.06%) to 75.88% when pulling 385f54b2125c96681adc3de9f562491f629070c7 on erikbern/get-work into 0f866fa624b1c363b2fa2031df9195114489d77e on master.

Hm should we really fail builds on pep8 issues?

I think we should. It's annoying to get all the issues from other people being shown in my editor each time I save a file.


Investigate what to use for search

Maybe it would be worth looking into some sort of document based DB, to quickly search by words.

At Laracon22 Taylor briefly showed how to use "fullText" fields and, database backed, Scout to implement a simple search. It may be enough for our need.
https://www.youtube.com/watch?v=0Rq-yHAwYjQ


worker ocall abstraction onchain

This is based on #293 - draft review for now
Refactor the abstractions for the onchain ocalls. This required some additional refactoring of our global variables in the main file (see https://github.com/integritee-network/worker/blob/344b53796636868c96430fbbc6dfdccbc00d3af0/worker/src/main.rs#L91-L96 ). Access to these is now wrapped in separate Accessor traits. These can be injected and so the nature of the global variables can be hidden.
This now started building the object dependency tree, that we initialize upon application startup and then distribute to wherever it is needed. Unfortunately, because of the nature of the ocalls (and because we can't pass all of the state into the enclave), we still need that global state outside the enclave.
A diagram of this refactoring:

I have had another idea about these factories. I think what we want is not a factory, we want a global singleton. Furthermore, the factory code is very repetitive, so I propose a singleton! macro which essentially looks as follows:
pub trait Singleton {
     type Target;

     fn store_global();
     fn read_global() -> Arc<Self::Target>
}

#[export_macro]
singleton! {
     (m_singleton: ident) =>

     // some details here would need to be worked out.

     lazy_static! {
            // todo: check how to derive variable name based on `m_singleton`
            pub static ref SINGLETON_REF:  RwLock<Option<Arc<$m_singleton>>= Default::default()'
     }

    impl Singleton for $m_singeton {
           type Target = $m_singleton;

          fn store_global(instance: $m_singeton ) {
                *SINGLETON_REF.lock().unwrap() = Some(rt.handle().clone());
         }

         fn store_global(instance: $m_singeton ) -> Arc<Self::Target> {
                  SINGLETON_REF
                           .lock()
                           .unwrap()
                           .as_ref()
                           .expect(format!("{} instance has not been initialized!", $m_singleton))
                           .clone()
         }
    }
}

// then we can do at top-level
singleton!(NodeApi);

// and we get the singleton getters and setters without boilderplate code

Still a draft - need to re-target the merge to master, once PR #293 is merged into master


DIY Neural Network mouseXY classification example

→ Description 📝
This is an attempt at making a new example that classifies x,y positions (added by mouse clicks) according to two labels: A / B. I think I'm very close, but current status is that it hangs on train() and only returns A.
→ Screenshots 🖼

ooops, I went branch crazy, this should be merged to nn-examples-cleanup. I'll sort out.

This should be good now, multiple commits above but changes reflect new example only.

@shiffman - there were 2 errors:

outputs should be 2 - "A" and "B"
.predict() should be .classify()

These are fixed in https://github.com/ml5js/ml5-examples/pull/199/commits/814fd9ede5e96e4f5c1ac0817af4fa14395a0938
Feel free to merge when ready!

Ah, yes, of course that makes sense!!
This is a little tricky b/c with, say, the titanic dataset there was only a single "column" name listed:
  const options = {
    outputs: ['survived'],
    task: 'classification'
  }

So maybe this is more like . . .
  // Create the model
  const options = {
    inputs: 2,
    labels: ['A', 'B'],
    task: 'classification'
  }

Also, as an aside, It would be interesting to consider how it might work to create the model after the dataset is collected. For example a la teachable machines where a user is entering in label names. This would be an argument for a separate ml5.data() function where you prepare the dataset and then create the model. But one thing at a time!

Ah, yes, of course that makes sense!!
This is a little tricky b/c with, say, the titanic dataset there was only a single "column" name listed:
  const options = {
    outputs: ['survived'],
    task: 'classification'
  }

So maybe this is more like . . .
  // Create the model
  const options = {
    inputs: 2,
    labels: ['A', 'B'],
    task: 'classification'
  }

Also, as an aside, It would be interesting to consider how it might work to create the model after the dataset is collected. For example a la teachable machines where a user is entering in label names. This would be an argument for a separate ml5.data() function where you prepare the dataset and then create the model. But one thing at a time!

hmm yes this is interesting. I think for now it is ok if you have to put in the number of inputs/outputs if you're creating a "blank" neural net. It means that you have to be explicit about the number of "inputs" and "outputs" which I think matches some of your examples like with your flappy bird example. The label names are then retrieved from the data after being fed in with .addData().

With the Titanic example or any of the examples where data are loaded in on object instantiation, I think it works that the data class figures out the nature of the data. I do think it is good to support explicitly adding in the output names in the constructor to make it clearer though! I'll add to the list of todos.

@shiffman - I will merge this in for now and work on allowing people to specify the ['a','b'] labels for the outputs in classification. Thank you!

Yes, thank you, your comments are super helpful and clarifying! Excited to keep pushing this new feature forward!


SourceControl: Error: Operation 'UpdateChangelistsStatus' not supported by source control provider 'Git LFS 2'

SourceControl: Error: Operation 'UpdateChangelistsStatus' not supported by source control provider 'Git LFS 2'
What's going on here?

Hi,
Git doesn't support Changelists nor Shelves like Perforce of Plastic SCM so this error in the log is normal.
In Unreal Engine 5.1 the "View Changeslists" entry menu will be greyed out for source control providers not supporting it, so it won't even be an issue.
Cheers!


24 cpv3 test cases absorption curve

closes #24

Due to the refactoring made recently, acceptance criteria may have changed.
Functions tested:

set_project_carbon
set_absorptions
get_current_absorption

Other minor functions used (getters):

get_project_carbon
get_absorptions
get_times

Additional changed:

tests of test_project.cairo have been updated and

Due to the refactoring made recently, acceptance criteria may have changed.
Functions tested
in test_carbon_handler.cairo

set_project_carbon
set_absorptions
get_current_absorption

Other minor functions used (getters):

get_project_carbon
get_absorptions
get_times

Additional changed:

tests of test_project.cairo have been updated
Absorber_ton_equivalent has been removed from Storage, and get_ton_equivalent now using CREDIT_CARBON_TON to convert.
I feel like  CREDIT_CARBON_TON and  CC_DECIMALS are redundant; am I wrong?


Supports for WebGL2?

Hi,is there any plan to support webgl2? I tried to pass WebGL2RenderingContext to MapViewOptions,but it's not works for all functionalities,especially for mesh with RawMaterial.
Thanks so much.

@Mofangbao , we have an internal ticket to support this however we haven't yet started it, or planned when to work on it.
We could however consider to increase the priority, what do you want to achieve with it?

I have a need to merge the Map renderer with my own Three.js based renderer which requires WebGL2 functionality. Would be great if you support this.

@J-Rojas , thanks for your comment, I will try to raise the priority of the ticket. If you want however, feel free to create a PR if you want to fix it, it should just require fixing the shaders in SolidLineMaterials.ts.

This is currently blocked by this issue: https://github.com/mrdoob/three.js/issues/19959
The material code dynamically updates the programs using #defines and the way the code is structured, it would be a larger refactor to workaround that bug.

@J-Rojas, thanks for linking to the bug!

I saw the recent commits by @atomicsulfate to address some of these issues. I believe there is also code in SdfTextMaterial that also needs refactoring to support GLSL 3.0.

@nzjony  Sorry for my delay response.  Actually I have some glsl codes based on WebGL2's 3D texture support,so only when harp.gl supports WebGL2, can I update them.


Remove JSON

Remove all JSON-related features since it's not used by Rizin.
A first step to address https://github.com/rizinorg/rizin/issues/274#issuecomment-752898326
cc @thestr4ng3r @08A

Does rizin still work against this or does it need adjustments?

@thestr4ng3r 3 things still need it:

Panels configuration storage
JSON grep (just parsing JSON)
Debug Session storage

https://github.com/rizinorg/rizin/issues/985

@ret2libc any idea why this error appeared?
src/meson.build:43:0: ERROR: declare_dependency keyword argument 'link_whole' was of type array[SharedLibrary] but should have been array[BothLibraries | StaticLibrary | CustomTarget | CustomTargetIndex | Dependency]

@ret2libc any idea why this error appeared?
src/meson.build:43:0: ERROR: declare_dependency keyword argument 'link_whole' was of type array[SharedLibrary] but should have been array[BothLibraries | StaticLibrary | CustomTarget | CustomTargetIndex | Dependency]

I think 0.63.0 became stricter. The manual actually says that link_whole should be a list, thus it should be:
sdb_whole_dep = declare_dependency(
-  link_whole: libsdb,
+  link_whole: [libsdb],
  include_directories: libsdb_inc,
)

@ret2libc didn't help, looking at the error message, the culprit seems in the value itself


Minor fixes for playbook to run successfully to completion

Added a newline to haproxy.cfg.j2
Added cargo as a package needed for successful compilation

Closes #13
Closes #14

ty for contribution!


Create Code of Conduct page

let's use all of the text from here: https://www.contributor-covenant.org/version/2/0/code_of_conduct/code_of_conduct.md (We can edit and translate in Nepali later.)
We will have the link to this page in the footer. We'd be grateful for your help @pratimakandel

I think we've added code of conduct  here b0a1925 but We still need to link it as a page in our site. I'd probably replace this page with code of conduct for now https://code4nepal.github.io/website20/legal


Better communication computation overlap

This PR patches torch to get better communication/computation overlap. Instead of using just one stream to unshard (all-gather) both attention params and FFN params, this uses a separate unshard stream for each. Computation now does not have to unnecessarily wait on communication from unrelated parts of the network.
Testing shows similar convergence with and without patching. Training instabilities, mainly due to load-balancing loss and not shuffling, were observed both with and without patching, which impacted convergence nondeterministically.

MFU improves by ~1.4% at small scales (first image) and ~25% at large scales, where without the patch, MFU is ~31% - (second image).

What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

I did have comments on the monkeypatched portion of the function, are there other comments you'd like me to add?


the latest gonum library using Nodes instead of []Node

..\github.com\chewxy\gorgonia\walker.go:43:43: cannot use g (type *ExprGraph) as type graph.Directed in argument to topo.SortStabilized:
*ExprGraph does not implement graph.Directed (wrong type for From method)
have From(int64) []graph.Node
want From(int64) graph.Nodes

I have created a branch ìssue-237` and tried to implement the new interface of gonum.
Not all the tests are green (concurrent training is failing and I didn't investigate to see if it is due to my modifications).
I do not assign the ticket to myself because I won't have more time to work on it by now.

Gonum is now using an Iterator. Gorgonia should be modified to use (or implement) this interface.
I have created a branch issue-237. I am using one of the implementations provided by Gonum within the Iterator package.
Not all the tests are green (concurrent training is failing, and I didn't investigate to see if it is due to my modifications).
This is why I do submit a PR

Thanks Very Much
I am afraid to modify the library because I found that there are lots of related code
So I do "git reset --hard commit OldID" to use old []Node make it successful run
Waiting for your next released version adapting these change


help to send image

Congratulations, I'm really liking the lib,
Give me a little help, please.
I want to send an image
I'm doing the following
self._driver.chats [message.chat.id] .send_media ('/ home / profiles / archive / voucher.jpeg', caption = 'test')
but I think I'm wrong, what's the right way?

send_media method needs a file-like object, not a file path:
with open(filename) as f:
    await self._driver.chats[message.chat.id].send_media(f, caption='test')

Look at the console exit, please.

sorry... it's a binary file...
with open(filename, 'rb') as f:
    await self._driver.chats[message.chat.id].send_media(f, caption='test')

changed the error but it still did not work :(

try to send content_type='image/jpg'

It worked perfectly now ...
it looks like you had a problem in the test file,
look at messages with content_type and no content_type
thank you very much

content_type tells whatsapp how to process file. If it is unknown, file is treated as binary.


add Shadow

This change make it looks better on a white background

This is not valid anymore, due to the recent changes on the master branch. Please reopen if necessary.

@honkmaster is it possible to add a shadow then?


Fixed #29823 -- Doc'd limitation of DecimalField on SQLite.

buildbot

@claudep Thanks!

buildbot


Thanos Tools Downsample Shutting Down without Reason

Thanos, Prometheus and Golang version used:
Thanos 0.24

Object Storage Provider:
Azure Blob Storage
What happened:
When I'm running the Thanos tools downsample command, I'm the command is finished by an internal server error without providing context.
What you expected to happen:
Be able to downsample data as a service.
How to reproduce it (as minimally and precisely as possible):
I just try to run the command as described above against the storage.
./thanos tools bucket downsample --objstore.config-file=storage.yaml --downsample.concurrency=1 --log.level=info
Full logs to relevant components:
level=info ts=2022-01-18T11:31:47.690110153Z caller=downsample.go:164 msg="starting downsample node"
level=info ts=2022-01-18T11:31:47.690263439Z caller=intrumentation.go:48 msg="changing probe status" status=ready
level=info ts=2022-01-18T11:31:47.690362235Z caller=downsample.go:117 msg="start first pass of downsampling"
level=info ts=2022-01-18T11:31:47.690449192Z caller=intrumentation.go:60 msg="changing probe status" status=healthy
level=info ts=2022-01-18T11:31:47.690525045Z caller=http.go:63 service=http/server component=downsample msg="listening for requests and metrics" address=<IP_ADDRESS>:10902
level=info ts=2022-01-18T11:31:47.690888877Z caller=tls_config.go:195 service=http/server component=downsample msg="TLS is disabled." http2=false
level=info ts=2022-01-18T11:31:52.118450487Z caller=fetcher.go:481 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.428046733s duration_ms=4428 cached=526 returned=526 partial=0
level=info ts=2022-01-18T11:31:52.124909498Z caller=downsample.go:132 msg="start second pass of downsampling"
level=info ts=2022-01-18T11:31:53.288659373Z caller=fetcher.go:481 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.163633704s duration_ms=1163 cached=526 returned=526 partial=0
level=warn ts=2022-01-18T11:31:53.290916369Z caller=intrumentation.go:54 msg="changing probe status" status=not-ready reason=null
level=info ts=2022-01-18T11:31:53.290971518Z caller=http.go:74 service=http/server component=downsample msg="internal server is shutting down" err=null
level=info ts=2022-01-18T11:31:53.292400844Z caller=http.go:93 service=http/server component=downsample msg="internal server is shutdown gracefully" err=null
level=info ts=2022-01-18T11:31:53.292477557Z caller=intrumentation.go:66 msg="changing probe status" status=not-healthy reason=null
level=info ts=2022-01-18T11:31:53.292593896Z caller=main.go:161 msg=exiting

Anything else we need to know:

Yeah, looks like this command is for one pass run.
Continuously downsamples blocks in an object store bucket. That's the command description so I think we should fix it and make it long running.


When not connected to a wallet, Create  buttons should be disabled

User Impacted
0x0F7494eE0831529fD676ADbc234f858e280AeAF0
Discord ID (including number)
gnomadic#8135
Workflow Impacted
Brainstorm
Feature Impacted
Create Marketplace
Issue description
when I'm not connected I can fill out the create marketplace form and hit submit, which will crash the app - I don't think I should be able to get to the create a marketplace form in the first place
Blocking
no it is not
Relevant log output
No response

Currently when not connected to a wallet, if a user attempts to perform an action the button will prompt the connect window, are we missing some places or in need of more clear UX?

Whoa!  confirmed this is no longer an issue. Even tried with the form open and filled out, disconnecting my wallet, and hitting submit - and it does pop the connect a wallet prompt!


asyncpg #question

Hi!
Recently, I have stumbled upon interesting article - https://magic.io/blog/asyncpg-1m-rows-from-postgres-to-python/
Questions:

Whether peewee-async can work with asyncpg driver?
If not - Do you have some plans to implement interfaces for asyncpg?

Thanks!

@DennisMatveyev: Not sure if you're still interested, but FWIW, it looks like asyncpg is being considered over in issue #52. You might ask there instead.

Yeah it does not look complicated to add asyncpg pool backend. You can do it on your own. Unfortunately we don't have plans to add the backend yet. We have plans for adding psycopg3 backend  #225


Preexisting Docker images are only listed after pull, so nothing is cached

I want to use this action to cache the MegaLinter Docker image to speed up my CI pipeline, which seems to be exactly what this action was designed for.
I've now added another step to my megalinter.yml workflow that uses docker-cache prior to the MegaLinter step, as instructed by the README:
# ...

jobs:
  lint:
    runs-on: ubuntu-latest

    steps:
      # Git Checkout
      - name: Checkout Code
        uses: actions/checkout@v3
        with:
          token: ${{ secrets.PAT || secrets.GITHUB_TOKEN }}
          fetch-depth: 0

      # Cache MegaLinter image
      - name: Cache Docker images
        uses<EMAIL_ADDRESS>        with:
          key: docker-${{ runner.os }}-${{ hashFiles('.github/workflows/megalinter.yml') }}

      # MegaLinter
      - name: MegaLinter
        id: ml
        uses<EMAIL_ADDRESS>        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

      # ...

However, when I now run this workflow, the pull of the MegaLinter image is lifted up and run first:

Only afterwards does docker-cache retrieve the list of pre-installed Docker images, which now also includes MegaLinter:

Because of this, the post-action does not find any difference between the Docker images before and after the workflow is run and nothing is cached:

I'm a little confused by this behavior since the documentation of GitHub actions clearly says that "Steps are executed in order and are dependent on each other.". Because of this, I'm not sure whether this is an issue with my configuration, MegaLinter, docker-cache, or some "optimization" applied by GitHub Actions, so sorry if this is unrelated to docker-cache.

Thank you for this excellent issue. We run MegaLinter via npx rather than the dedicated GitHub Action, which as you observed is a Docker GitHub Action. The GitHub Actions runner itself pulls the Docker image of Docker GitHub Actions in a pre step. This is a good motivation for supporting a new input that allows the user to explicitly list which Docker images they would like to cache. In case someone gets a chance to work on that before our team does, be advised not to permit a shell injection attack as discussed in #44. In the meantime, you could run MegaLinter via npx as a workaround.

Thanks for the pointers to the npx workaround and the MegaLinter issue. That should fix my issue for now.


Extra topic parameter getting appended for listen topic or missing parameter on client topic?

A repo of the issue: https://github.com/jreeter/seneca-redis-test/blob/master/README.md
.listen seems to be adding .add parameters to the pin, even when pin is set in .listen? Please see above repo. Is this intended? This is causing the .listen to subscribe to a topic that does not match the client topic.

@mihaidma can anyone confirm this behavior is an issue?

@jreeter Could you submit a pull with this change? It looks like you are right. We are just tight on the ground for resourcing the change.

Lol accidental close :D

Apologies, I plan to hop back on this issue very soon. @mcdonnelldean

Hi everyone
any updates? 🙂


letter-spacing increased

Letter-spacing has increased in the latest commit 9cd558f. Using the same svg font files, the newly generated ffont files used in the latest fctx produce significantly wider lines than ffont files from the same svg sources compiled for and used with the previous fctx release. There were no code changes in the watchface. I could observe this on centered and right justified lines, but have no left justified lines to confirm it also happens there.
Example screenshot before and after

on closer inspection it seems the problem might be in the compiler, not fctx itself

I tried finding the origin of the problem but only got as far as that if I take metadata.emScale*0.9 in the compiler it produces something fairly close to the expected result. Hope that helps

Good catch!  The problem was in the compiler.  Fixed by https://github.com/jrmobley/pebble-fctx-compiler/commit/cf966743acd2ce87998c2bfdbb462ef5db588e08.

thank you for the excellent work and fast fixing


Show some loading indicator when switching PR descriptions

Testing #5939
Repro:

Open GHPR view
Click the description of a PR
Click the description of another PR, 🐛 nothing happens for ~2 seconds and then the custom editor switches suddenly. Could we show a loading indicator here?

Adding view progress.


Arcade video snaps not showing up (but scrape fine)

Hi.
Just set-up a Pi3 and retropie and found your amazing scraper. most systems scrape video snaps fine but i am having trouble with Arcade/mame
All roms are in the arcade folder and most of the titles seems to scrape fine (i can see snaps and videos in the created folder) but when i view the roms in the emaulation station menu the video snaps dont play. snaps seem to work if there is one.
i noticed the rom zip files and video files are named differently.. i have tried renaming the video files but still doesnt work. what the best way of scraping arcade titles and what settings to use?

I haven't used any of the video stuff but something like this should work -mame -mame_src="adb" -download_videos" You could alternatively substitute "ss" for "adb" I imagine that adb has better coverage but if the console videos work you might want ss since that is the same source.
Since you are playing on the Pi you could also download handbrakecli and either place it in the same directory as the scraper, in the system path, or if you have already installed the regular handbrake on windows it is already there. Then use -convert_videos which will hopefully convert the files to something that will play more easily on the pi. But if you are doing that it is best to probably do that on another system.

Thanks Stephen. i sorted it.. used the same scraper as consoles and it works fine now

Hello Kiaengima27,
is there any way you can provide more information on how the problem was fixed, i am having the same issue and i am not sure what you mean by, 'used the same scraper as consoles'.
Thank you!

@phatazz What this means is, when you're in the Scraper Config/Options page, you set "Arcade Source" to the same value as "Console Source". For me, this meant changing from ArcadeItalia to ScreenScraper.
For what it's worth, my MAME games scraped videos fine from ArcadeItalia, but the videos don't work with the OMX video player. When I turned that off, the videos appeared fine. But I want to use the hardware accelerated player, so I'm going to scrape again with ScreenScraper as the Arcade Source. But I may need to delete the existing videos, as they won't get overwritten I expect (different encoding, so maybe different file extension)

Yes, you can scrap from a different source, or re-encode the progetoemma videos from arcadeitalia. I just used Handbrake to batch re-encode all of the scraped snaps to the "normal" or "High Profile" preset and turning down quality to 25 to make the files a little smaller (on par with the original sizes). They play just fine then in OMX.

The ADB video source could be changed to improve compatibility issues.
Can you make a test with mp4 videos created for Hyperspin, available on the bottom of this page?
http://www.progettosnaps.net/videosnaps

I have uploaded video samples for 33 games, you can all the files here:
shortplay native resolution (82MB)
shortplay scaled to 1080p (314MB)
Please let me know if this solved the compatibility issue, so I will upload all new videos on my web-site for the scraper.

Yes, you can scrap from a different source, or re-encode the progetoemma videos from arcadeitalia. I just used Handbrake to batch re-encode all of the scraped snaps to the "normal" or "High Profile" preset and turning down quality to 25 to make the files a little smaller (on par with the original sizes). They play just fine then in OMX.

Hello.  I'm not a coder, so a lot of this is another language. Any chance you can do a step by step on how to do this? Specifically, how to re-encode in the raspberry pi terminal? Or whichever way is easiest.


Uchiwa dahsboard to accept multiple user credentials

@lukyanov: Awesome! :+1: I'll get some testing done today and merge in. Thanks very much :)

@lukyanov: sorry it took so long for me to get around to this! Thanks for your contributions 👍🏻


[1.11.2] Client crash - java.lang.NullPointerException: Rendering screen     at mcjty.rftools.blocks.storage.GuiModularStorage.updateList(GuiModularStorage.java:451)

http://pastebin.com/CP5utQ5j
User reported this crash when using his modular tablet.

Fixed next release


Analysis/Plotting script raises error when loading data

Describe the bug
I get the error when I run the cell to load the data. I think it doesn't like having the pixel size set to a float in the metadata. But the pixel size is 0.109524 microns so I can't have it as an int.

0.109524

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Python version: [e.g. Python 3.9]
OS: [e.g. Windows 10]
Cell-ACDC Version [e.g. v1.2.4, you can find this from the menu "Help-->About Cell-ACDC" on the main Launcher]

Additional context
error:
`Load files for good_positions, Position_2...
Number of cells in position: 40
Number of annotated frames in position: 121
Calculate regionprops on each frame based on Segmentation...
0%|                                                                                | 0/121 [00:00<?, ?it/s]
TypeError                                 Traceback (most recent call last)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\ops\array_ops.py:163, in _na_arithmetic_op(left, right, op, is_cmp)
162 try:
--> 163     result = func(left, right)
164 except TypeError:
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\computation\expressions.py:239, in evaluate(op, a, b, use_numexpr)
237     if use_numexpr:
238         # error: "None" not callable
--> 239         return _evaluate(op, op_str, a, b)  # type: ignore[misc]
240 return _evaluate_standard(op, op_str, a, b)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\computation\expressions.py:69, in _evaluate_standard(op, op_str, a, b)
68     _store_test_result(False)
---> 69 return op(a, b)
TypeError: can't multiply sequence by non-int of type 'float'
During handling of the above exception, another exception occurred:
TypeError                                 Traceback (most recent call last)
Input In [12], in <cell line: 1>()
----> 1 overall_df, is_timelapse_data, is_zstack_data = cca_functions.calculate_downstream_data(
2     file_names,
3     image_folders,
4     positions,
5     channels,
6     force_recalculation=True # if True, recalculates overall_df; use this if anything upstream is changed
7 )
File ~\miniconda3\envs\acdc\lib\site-packages\cellacdc\cca_functions.py:127, in calculate_downstream_data(file_names, image_folders, positions, channels, force_recalculation)
125 else:
126     print(f'Calculate regionprops on each frame based on Segmentation...')
--> 127     rp_df = _calculate_rp_df(seg_mask, is_timelapse_data, is_zstack_data, metadata, max_frame=cc_data.frame_i.max()+1)
128     print(f'Calculate signal metrics for every channel and cell...')
129     flu_signal_df = _calculate_flu_signal(
130         seg_mask,
131         channel_data,
(...)
135         is_zstack_data
136     )
File ~\miniconda3\envs\acdc\lib\site-packages\cellacdc\cca_functions.py:434, in _calculate_rp_df(seg_mask, is_timelapse_data, is_zstack_data, metadata, max_frame, label_input)
432 else:
433     t_rp = regionprops(img.astype(int))
--> 434     vol_vox = [_calc_rot_vol(obj, metadata.loc["PhysicalSizeY"], metadata.loc["PhysicalSizeX"])[0] for obj in t_rp]
435     vol_fl = [_calc_rot_vol(obj, metadata.loc["PhysicalSizeY"], metadata.loc["PhysicalSizeX"])[1] for obj in t_rp]
436     assert len(t_rp_df) == len(vol_vox)
File ~\miniconda3\envs\acdc\lib\site-packages\cellacdc\cca_functions.py:434, in (.0)
432 else:
433     t_rp = regionprops(img.astype(int))
--> 434     vol_vox = [_calc_rot_vol(obj, metadata.loc["PhysicalSizeY"], metadata.loc["PhysicalSizeX"])[0] for obj in t_rp]
435     vol_fl = [_calc_rot_vol(obj, metadata.loc["PhysicalSizeY"], metadata.loc["PhysicalSizeX"])[1] for obj in t_rp]
436     assert len(t_rp_df) == len(vol_vox)
File ~\miniconda3\envs\acdc\lib\site-packages\cellacdc\cca_functions.py:467, in _calc_rot_vol(obj, PhysicalSizeY, PhysicalSizeX)
466 def _calc_rot_vol(obj, PhysicalSizeY=1, PhysicalSizeX=1):
--> 467     vox_to_fl = PhysicalSizeYpow(PhysicalSizeX, 2)
468     rotate_ID_img = skimage.transform.rotate(
469         obj.image.astype(np.single), -(obj.orientation180/np.pi),
470         resize=True, order=3
471     )
472     radii = np.sum(rotate_ID_img, axis=1)/2
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\ops\common.py:70, in _unpack_zerodim_and_defer..new_method(self, other)
66             return NotImplemented
68 other = item_from_zerodim(other)
---> 70 return method(self, other)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\arraylike.py:116, in OpsMixin.mul(self, other)
114 @unpack_zerodim_and_defer("mul")
115 def mul(self, other):
--> 116     return self._arith_method(other, operator.mul)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\series.py:5639, in Series._arith_method(self, other, op)
5637 def _arith_method(self, other, op):
5638     self, other = ops.align_method_SERIES(self, other)
-> 5639     return base.IndexOpsMixin._arith_method(self, other, op)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\base.py:1295, in IndexOpsMixin._arith_method(self, other, op)
1292 rvalues = ensure_wrapped_if_datetimelike(rvalues)
1294 with np.errstate(all="ignore"):
-> 1295     result = ops.arithmetic_op(lvalues, rvalues, op)
1297 return self._construct_result(result, name=res_name)
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\ops\array_ops.py:222, in arithmetic_op(left, right, op)
217 else:
218     # TODO we should handle EAs consistently and move this check before the if/else
219     # (https://github.com/pandas-dev/pandas/issues/41165)
220     _bool_arith_check(op, left, right)
--> 222     res_values = _na_arithmetic_op(left, right, op)
224 return res_values
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\ops\array_ops.py:170, in _na_arithmetic_op(left, right, op, is_cmp)
164 except TypeError:
165     if not is_cmp and (is_object_dtype(left.dtype) or is_object_dtype(right)):
166         # For object dtype, fallback to a masked operation (only operating
167         #  on the non-missing values)
168         # Don't do this for comparisons, as that will handle complex numbers
169         #  incorrectly, see GH#32047
--> 170         result = _masked_arith_op(left, right, op)
171     else:
172         raise
File ~\miniconda3\envs\acdc\lib\site-packages\pandas\core\ops\array_ops.py:127, in _masked_arith_op(x, y, op)
124         mask = np.where(y == 1, False, mask)
126     if mask.any():
--> 127         result[mask] = op(xrav[mask], y)
129 np.putmask(result, ~mask, np.nan)
130 result = result.reshape(x.shape)  # 2D compat
TypeError: can't multiply sequence by non-int of type 'float'`

it seems that its an issue with version 17. Jordan has 16, and it works fine for him

Hi Jacob, I released a new version v1.2.4rc18 where I fixed this issue. Let me know if it works, thanks!

Thanks. It loads now, but now I get the problem where the pixel area, volume, etc measurements are missing from overall_df.
This is what I see when I upload a movie:
"Volume is missing in acdc output, NaNs inserted in concentration columns of channel Phase
Volume is missing in acdc output, NaNs inserted in concentration columns of channel mCitrine
Volume is missing in acdc output, NaNs inserted in concentration columns of channel mKate2
Saving calculated data for next time...
Done!"
Most of the measurements are there, but I think somehow the area measurement is excluded or renamed, and it leads to problems with calculating the volume, concentration, etc.

Ok that warning is when it calculates concentration and it wants to divide the amount by the cell volume.
Can you please check if in the acdc_output.csv file you have a column called cell_vol_fl? If you have that column I think the fastest is that you zip the entire position folder and you send it to me for testing.
If you don't want to make a public google drive link you can share a folder with my email<EMAIL_ADDRESS>thanks!

If you don't have the cell_vol_fl column you first have to calculate the metrics in the GUI. Currently the cell volume is computed only in the GUI metrics, we will add it to the notebook in the next release.

This happens even after I re-save the additional measurements in the GUI. The "cell_vol_fl" column isn't there. Also, I only have the option to close with comment on this thread. But it's definitely not closed. I'll send you the folder to your email.

The closing is weird, let me try to re-open.
I will test with your positions thanks!

just reopened

Ok I received the position, I will test first thing in the morning (here is 9pm unfortunately). The issue is reopened now. I will keep you updated, thanks!

thank you!

Hi Jacob, I released a new version v1.2.4rc19 with the fix to this issue.
It was my fault, when I refactored the code to remove possible sources of crashes I moved the calculation of the volume in the main thread (since in a separate thread it was a possible source of crashes), but then I forgot to add the result to the final table.
So even if you saved the metrics, the columns cell_vol_fl and cell_area were not saved. Sorry about that!
Let me know if it works now, thanks.


[CP] analytics not reporting context_result information as intended

Commit(s) to merge
7c1e2fee7006ae4552c9081ca3ea946fb7af72ce
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/296065
Issue Description
When analytics are enabled for a user, on shutdown there is a set of data that is supposed to be sent.   One important piece of this data was missing because an old bug in the LSP analysis server prevented that data structure from being populated.
What is the fix
Fix the bug in the LSP analysis server so it can properly recognize when analysis is complete, and populate the data structure.
Why cherry-pick
It will be challenging to determine the full meaning and impact of potential problems identified in analytics without this data.  The data includes things like the number of files and lines of code that can help determine correlations in the data.
Risk
low
Issue link(s)
https://github.com/dart-lang/sdk/issues/52089
Extra Info
No response

SGTM

I am looking at the original commit and it has no tests. How are we making sure that we are not regressing this?
/cc @jacob314

The original commit was tested end to end manually.

@jcollins-g My point was not about the cherry-pick request itself. I agree with your assessment that the risk of cherry-picking is close to zero and I am in favour of approving it.
My point was that the CL which we are cherry-picking is a fix which does not contain any tests. What prevents us from regressing back to the unfixed behaviour? (e.g. somebody accidentally removes these lines in some refactoring on main). Unless absolutely impossible we should make sure that we have some CI coverage for the desired analytics behaviour. I probably should have flagged this concern on the original issue/CL rather than here. Sorry, for the confusion.

We might also be able to test at the AnalyticsManager level, with a mock Analytics object that would record when given events are requested to be sent. Then we'd at least be able to test to the point where Analytics takes over.

We might also be able to test at the AnalyticsManager level, with a mock Analytics object that would record when given events are requested to be sent. Then we'd at least be able to test to the point where Analytics takes over.

Yes, that's reasonable.


Oauth2 token expired and refresh token not set

I'm uploading multiple big videos to google photos using the cli. Always, few hours in, I started getting errors:
panic: interface conversion: error is *url.Error, not *googleapi.Error

goroutine 69 [running]:
github.com/gphotosuploader/google-photos-api-client-go/lib-gphotos.(*Client).UploadFile(0xc000249680, 0xc00002c900, 0x30, 0xc0001776c0, 0x1, 0x1, 0x0, 0x0, 0x0)
        /home/moritz/code/go/src/github.com/gphotosuploader/google-photos-api-client-go/lib-gphotos/client.go:123 +0xb5a
github.com/nmrshll/gphotos-uploader-cli/upload.(*Item).upload(0xc0001cec40, 0xc0000931c0, 0xc00011c000, 0xc00009c580)
        /home/moritz/code/go/src/github.com/nmrshll/gphotos-uploader-cli/upload/fileUpload.go:79 +0x1a1
github.com/nmrshll/gphotos-uploader-cli/upload.concurrentUpload.func1(0xc00011c000, 0xc0000931c0, 0xc0001cec40)
        /home/moritz/code/go/src/github.com/nmrshll/gphotos-uploader-cli/upload/fileUpload.go:36 +0x63
created by github.com/nmrshll/gphotos-uploader-cli/upload.concurrentUpload
        /home/moritz/code/go/src/github.com/nmrshll/gphotos-uploader-cli/upload/fileUpload.go:34 +0xb2

Some previous uploads worked, only now that they're done this error occured, hours after the last log about the upload of a specific video. I conclude that this error either happened during this long upload or on the attempt of starting a new one. I haven't found out if it's related to the concurrency of five workers.
After modifying the source code in google-photos-api-client-go/lib-gphotos/client.go and re-building, I was able to see the underlying URL Error:
oauth2: token expired and refresh token is not set relating to the url https://photoslibrary.googleapis.com/v1/mediaItems:batchCreate?alt=json
This may have been related to the fact that it prompted me for new keyring passwords and created multiple keyring entries on every new execution.
Desktop:

OS: Ubuntu 19.04
Go v1.12.7 Linux/amd64
Version: master branch on 26 July 2019 (the error occured since I initially pulled the repo on 23 July 2019)

This should be fixed by the combination of:

#63 (specifically https://github.com/nmrshll/gphotos-uploader-cli/commit/12c07054aba6e1ba9b428c4bd9b2f0120ba6f98e)
https://github.com/gphotosuploader/google-photos-api-client-go/pull/5
https://github.com/nmrshll/oauth2-noserver/pull/5

@schokotets let's continue on #103


Replace React with preact

I added preact as an alias so React/ReactDOM can still be referenced in component imports. preact/compat should be a safe default over just preact as it gives the most backwards compatibility with other React libraries.
This should bring bundle size down by about 35%.
Closes #2

Very cool! I've merged it to a new branch so I can test it locally first, then I'll merge it to mater/main.
Many thanks!

Confirmed it works, and it takes bundle size from 90kb to 60kb. Which is awesome. Thanks again!


Correct load_kwh_in_bin_initial to match load_kwh_per_customer_in_bin_initial*customers_in_bin - residential agents only

Non-critical, non-urgent issue (i.e. doesn't impact model runs or results). Only pertains to residential agents.
For residential agents, load_kwh_in_bin_initial should be equal to load_kwh_per_customer_in_bin_initial*customers_in_bin. As load_kwh_per_customer_in_bin_initial included the units_representated and 0.81 derating factor, as it seems that didn't get transferred to the load_kwh_in_bin_initial variable.
Proposed Solution: load residential agents and simply set: load_kwh_in_bin_initial = load_kwh_per_customer_in_bin_initial*customers_in_bin. Once new agent files are completed these will need to be uploaded to OEDI and old ones need to be removed.

residential agent files have been corrected and are awaiting upload to OEDI. Will close issue once upload is confirmed.

Residential agent files have been updated in their respective folders as well as the zipped agents containing the revised (v2) national residential agents on OEDI.


@alloy->fetch ALL works in show on artwork view

fixes https://github.com/artsy/eigen/issues/472

Aha, I must have misunderstood the use of pagination in the ticket for on-demand pagination (e.g. scrolled to bottom).
I guess there are no shows with massive amounts of works, huh?

The api is paginated. Probably most shows are 1-2 pages
On Mon, Jun 29, 2015 at 14:21, artsy/eigen
<EMAIL_ADDRESS>wrote:
Aha, I must have misunderstood the use of pagination in the ticket for on-demand
pagination (e.g. scrolled to bottom).
I guess there are no shows with massive amounts of works, huh?
—
Reply to this email directly or view it on GitHub
[https://github.com/artsy/eigen/pull/560#issuecomment-116783464] .[https://github.com/notifications/beacon/ADBlTnsdpc0kMr-s2RHjq6jcHYeGE8Xgks5oYYRGgaJpZM4FOU5C.gif]

Can you add a CHANGELOG?
And are you planning on adding tests?

Probably most shows are 1-2 pages

Gotcha, good call then :+1:

Superbelicious :+1: