Teensy 3.6 with ros2 Humble - No topics with publisher example

I am using a teensy 3.6 with ros2 humble on ubuntu 22. I have installed the teensyduino patches and the code 'micro-ros_publisher.ino' compiles fine and is running on the teensy.
When I source my terminal window and run ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 I get this output:
[1688391842.255238] info     | TermiosAgentLinux.cpp | init                     | running...             | fd: 3
[1688391842.255336] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 4
[1688391848.636169] info     | TermiosAgentLinux.cpp | fini                     | server stopped         | fd: 3
[1688391848.646262] info     | TermiosAgentLinux.cpp | init                     | Serial port not found. | device: /dev/ttyACM0, error 2, waiting for connection...
[1688391849.650129] info     | TermiosAgentLinux.cpp | init                     | Serial port not found. | device: /dev/ttyACM0, error 2, waiting for connection...
[1688391850.656217] info     | TermiosAgentLinux.cpp | init                     | Serial port not found. | device: /dev/ttyACM0, error 2, waiting for connection...
[1688391851.418302] info     | TermiosAgentLinux.cpp | init                     | running...             | fd: 3
[1688391853.435834] info     | Root.cpp           | create_client            | create                 | client_key: 0x604882F6, session_id: 0x81
[1688391853.435892] info     | SessionManager.hpp | establish_session        | session established    | client_key: 0x604882F6, address: 0
[1688391853.446454] info     | ProxyClient.cpp    | create_participant       | participant created    | client_key: 0x604882F6, participant_id: 0x000(1)
[1688391853.451422] info     | ProxyClient.cpp    | create_topic             | topic created          | client_key: 0x604882F6, topic_id: 0x000(2), participant_id: 0x000(1)
[1688391853.456573] info     | ProxyClient.cpp    | create_publisher         | publisher created      | client_key: 0x604882F6, publisher_id: 0x000(3), participant_id: 0x000(1)
[1688391853.461512] info     | ProxyClient.cpp    | create_datawriter        | datawriter created     | client_key: 0x604882F6, datawriter_id: 0x000(5), publisher_id: 0x000(3)

And then running ros2 topic list gives me this:
/parameter_events /rosout
I have also specified different baud rates and have gotten the same result.
I do not see any topics being published to from the teensy, and the onboard led is on all the time. I am expecting to see a topic that the teensy is publishing to.
I have also used this tutorial to set everything up. I am not using docker, and I have followed it for humble and teensy 3.6 instead of their exact setup.
https://micro.ros.org/docs/tutorials/core/teensy_with_arduino/

The publisher is being created, as this line details:
[1688391853.461512] info     | ProxyClient.cpp    | create_datawriter        | datawriter created     | client_key: 0x604882F6, datawriter_id: 0x000(5), publisher_id: 0x000(3)
Could you the agent on debug mode? You can do this adding the -v6 flag:
ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 -v6
Did you modify any part of the micro-ROS example code?
Any modifications on your ROS 2 environment? (For example a custom ROS_DOMAIN_ID configuration)

I removed export ROS_DOMAIN_ID=1 from ~/.bashrc and I was able to see the topic. Is there any way to use a domain id with micro ros?

Yes, you can configure it on the node, check this tutorial: Link
Closing!


Rebuild cuda110 0 1 h957760

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: scipy >= 1.2.0 should not contain a space between relational operator and the version, i.e. scipy >=1.2.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


misc: Move types. Renaming/typos in comments. Fix linting errors. Add license headers. Add FIXMEs

Remove no longer used packages/contracts types file

Rename Ethcore to Parity

Change license header from 2017 to 2018 validity

Create Input___ types in packages/api to fix linting errors

Fix typo 'receiving' and 'initialises'

Rename 'pubsub' to 'pub-sub', 'rpc' to 'RPC', and 'abi' to 'ABI', and 'ether' to 'Ether' (when referring to denomination), and 'electron' to 'Electron', and 'parity' to 'Parity' or 'Parity Ethereum' (as applicable) in comments. Refer to 'parity binary' as 'parity binary'

Move types Api, Contract, and ContractInstance to '@parity/api/src/types'

Reword to 'The message of the RPC call.'

FIXME added since cannot find file '../../test/e2e/ethapi' used in unit test

FIXME added for test description 'returns and the chain'

Pull Request Test Coverage Report for Build 229

0 of 28 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.84%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/electron/src/getParityPath.ts
0
2
0.0%

packages/electron/src/runParity.ts
0
2
0.0%

packages/api/src/format/input.ts
0
24
0.0%

Totals

Change from base Build 222:
0.0%

Covered Lines:
852

Relevant Lines:
1819

💛  - Coveralls


Support saving decode KV cache to boost multi-turn conversation

This PR resolves #129 .
Currently, decode cache is saved if seqlen (prompt tokens+generated tokens) % chunk_size == 0
By default, this feature is disabled.
To enable this feature, we need to specify "save_decode_cache: True" in config yaml.
@Siddhant-Ray Please update the doc as well.
Currently, we only support mistral-7b.
There should be a patch per model. For example, in mistral-7b, assume the first run is text 1 -> text 2. Then input of the second run should take in text 1 + text 2. However, there's always an empty padding token 28705 between text 1 and text 2, making the cache for text 2 not reusable.
See https://github.com/LMCache/lmcache-vllm/pull/17/files#diff-ebeb6ecf30c81dd3fac7c2a4ec1b9ed188a07dd005a6fa94b1d5eabfcea68d1aR175 for solution.
Created an issue to support more models #151 .
@Shaoting-Feng There should be more tests for this feature.
@XbzOnGit There's a naive example at https://github.com/LMCache/LMCache/pull/149/files#diff-3fb66e5f1f5c6e784cf25f543303d240b9130723481a3ea0481d3e38dcfbcb1dR1 .
Please refine this example and also other examples (see #142).
Created an issue to improve the performance #150.

This has been E2E tested. TTFT doesn't reduce; retrieved number of chunks looks good; prompt_token_ids confusing. @YaoJiayi

E2E Test Setting

Suppose text1 is the prompt (context + question) of request 1 and text2 is the output message of request 1. Then text1 + text2 is the context of request 2. In this logic, I ran five-turn tests. The number of tokens goes from <100 to >15000.

Performance:

TTFT doesn't reduce

TTFT1
TTFT2
TTFT3
TTFT4
TTFT5

save_decode_cache: True
0.196
0.281
0.672
1.432
3.570

save_decode_cache: False
0.094
0.558
0.684
1.529
3.769

From stderr.log, retrieved number of chunks:

save_decode_cache = True: 0 0 2 10 25
save_decode_cache = False: 0 0 2 2 2

From stdout.log, last four IDs (after 28705) in prompt_token_ids are different in the next turn of request

About the number of retrieved chunks:

Only the fifth round contain 15000 tokens. The fourth round contain 6538 tokens, so the test result of the number of retrieved chunks is correct.

About the TTFT:


Mock-Up Approuter Application

[x] create an mock-up approuter app

[x] integrate authentication through SAP IdP

[x] put a debugger to observe JWTs

Can you please make a PR containing your current work on the approuter repository?
Thanks.

I have made the pull requested as requested. It is on the ev-sap-app-router repository.

Could you please update your work in progress branch on ev-sap-app-router repository?
Thanks.

I have pushed the latest files to the respective repository. Thanks a lot!


Enterprise add build logs

Enterprise add build logs

The current build log contains some credentials
	-     url: https://0c725acec44447a2a73c7a06.file.core.windows.net/<some-blob-path>?<plain-sas-token>
	+     url: https://0c725acec44447a2a73c7a06.file.core.windows.net/<some-blob-path>?<plain-sas-token>

This was not introduced by your change, but we should work with the team to clear them from the log streams.


Distinguish speakers with the same name

When two users with the same name join a meeting, the meeting transcript can't tell who is who. Is it possible to return some extra fields that can distinguish them?
I also noticed the Microsoft teams app can identify the right user in the transcript. So seems the data does exist but just not surfaced.
Thanks!
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 519a4b94-7379-4649-0e3f-b0fe6918fda2
Version Independent ID: d1732c1a-8bd7-a23a-4e03-c726a4540e26
Content: Get callTranscript - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/calltranscript-get.md
Product: microsoft-teams
Technology: microsoft-graph
GitHub Login: @v-sdhakshina
Microsoft Alias: MSGraphDocsVteam

Not an doc issue, closing...


Getting started with Eleventy

Link to Getting Started with Eleventy article and template featured on SitePoint.com.
The tutorial shows how Eleventy can be used as a complete build system for HTML, CSS, JavaScript, and image optimization.

Thank you!


add ispath, and file size check before publishing

Check for file, and that file size is not zero before publishing

LGTM


Look into making repo internal

User story
As a developer, I want to make repos only used internally to be marked as internal.
Acceptance criteria

[ ] If only internal repositories are using this, then we should make this an internal repo.

Sprint Ready Checklist

[ ] 1. Acceptance criteria defined
[ ] 2. Team understands acceptance criteria
[ ] 3. Team has defined solution / steps to satisfy acceptance criteria
[ ] 4. Acceptance criteria is verifiable / testable
[ ] 5. External / 3rd Party dependencies identified
[ ] 6. Ticket is prioritized and sized

Notes
Add any helpful notes here.

Is this really something we need?


Forked to AmazingPrint

I see anumber of open pull requests needing reviews and merging. Does this project need new/more maintainers?
Update: we haved forked this project to https://github.com/amazing-print/amazing_print

@imajes I'd be happy to help out :)

For anyone interested, we have forked this to a new organization and project: https://github.com/awesomer-print/awesomer_print
Please contact me if you're interested in becoming an organization member.

Hey @HarlemSquirrel! I think it's fine if you update the title of this issue and do a little bit of self-promotion here.
Thanks for taking on this amazing project and continuing developing it!

Thanks for forking. I'd be cool if they'd put a deprecation notice on the readme.

@BryanH nice!!! 👏

@BryanH nice!!! 👏


Update parameters for Bouncer Jenkins job

Actually, I'm still not sure this job is safe to include on staging. If somebody left the HOSTNAMES variable blank staging would grab the production hostname list and try to configure Fastly with it.

I've removed the more controversial commit 87a37701e833b4b9f42c5732e760755eb62a6ac0 from this pull request so I think this is good to be reviewed now.

:+1: Merge when green.


update logo; use .svg too

nvm. we're going to store the logos in a central place (in the docs most likely)


Search for Duplicate Items

It would be great if you could search for duplicate items and it highlighted them for easy house cleaning and switching to characters for comparing. Love the app!

It does. Type "is:dupe" or "is:duplicate" into the search box.


Update about-shared-mailboxes.md

Made changes to the use with outlook paragrph
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12200

@JohanFreelancer9 please copy review


Menu dropdown doesn't work on NeurIPS docs page

If the window is narrow, the dropdown to show the main menu interacts strangely with the side navbar.

Solved in #137


docs: reference for cast --format-bytes32-string and --parse-bytes32-…

This PR adds reference for the new cast subcommands: --format-bytes32-string and --parse-bytes32-string as instructed by:
https://github.com/foundry-rs/foundry/pull/2653#pullrequestreview-1065244008

I'm a bit confused, how is this new functionality different to cast --to-bytes32?

Does this help?
https://github.com/foundry-rs/foundry/pull/2653#issuecomment-1208367276


Multiple parameter examples for FromSqlRaw and related

You should have examples also with multiple parameters FromSqlRaw...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e1289d5-8364-18a4-3445-6bba05c6854b
Version Independent ID: 2680e647-f64a-7991-f821-3b5e2a845960
Content: Raw SQL Queries - EF Core
Content Source: entity-framework/core/querying/raw-sql.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @smitpatel
Microsoft Alias: avickers

Fixed in This PR

Closing as this change does not add value.


transcribe: 9.21 -> 9.25

Description of changes
Release notes:
https://www.seventhstring.com/xscribe/history/history925.html

Things done

"Built" it and ran it.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

It works for me.

I've tested it, it works for me too.


Update scala-parallel-collections to 1.0.4

Updates org.scala-lang.modules:scala-parallel-collections from 1.0.3 to 1.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-parallel-collections" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #563 (45bae4e) into master (a1e0ddc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   62.54%   62.54%
=======================================
  Files          39       39
  Lines        1303     1303
  Branches        7        7
=======================================
  Hits          815      815
  Misses        488      488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e0ddc...45bae4e. Read the comment docs.


tls: add functionality to override requested server name in the upstream cluster

Description: add functionality to override requested server name in the upstream cluster
Risk Level: medium
Testing: unit tests
Docs Changes: yes
Release Notes: yes
Related to #4076

@lizan I have extracted the override server name functionality from the extension PR https://github.com/envoyproxy/envoy/pull/4334. Could you please review it? Are the tests I wrote sufficient?
The test on mac fails for some reason, could you please rerun it?

Thanks @vadimeisenbergibm for extracting this. The structure looks nice though I think it can be more future proof. I re-kicked mac CI as it seems unrelated.

@lizan I have implemented your comments, the tests pass.

@htuch do you have any remarks? Should I fix something in this PR? Any feedback is welcome.

@vadimeisenbergibm sorry, I tagged myself but forgot to review. I will give this  a full pass today.

@htuch Regarding
https://github.com/envoyproxy/envoy/pull/4973#discussion_r233937590

Rename to serverNameOverride or just simply serverName; otherwise, it sounds like a mutating method vs. an option.

I would like to convey the meaning that this option instructs the tcp_proxy and the TransportSocketFactory to override the configured server name in the cluster. If I would use very long function names, I would call this function serverNameToOverride or serverNameToOverrideInTheUpstream.
What do you think? I am OK with serverNameOverride.

Agree on the intended meaning front, but still prefer serverNameOverride, since the intention is already conveyed by the naming of the enclosing structures, transport socket options, which presumably influence the transport socket.

@htuch Agreed on serverNameOverride.

@htuch Fixed
https://github.com/envoyproxy/envoy/pull/4973#issuecomment-439167145

Agree on the intended meaning front, but still prefer serverNameOverride

in c9ed4a7146d5e5398f6a62c6f739d3ac5df2332c .

@htuch I have addressed your comments. asan fails due to some timeout.

@htuch I have applied your comments, all the tests pass.

@htuch My pleasure! Thank you for your patient reviewing.

@lizan if you have any further feedback, I'm thinking this will only be test related, so we can punt that to a further PR.


add more contribution guidance

Write guidance to say best practices for writing the documents (as well as template things like)   include the dataset… .…If small dataset can put into output.     if dataset is too large, to put a link to it in the data folder (& output header & first 5 lines if possible).
include images for SAS, but make sure the R code runs for R.
Add to the contributions… back and forth review process… & how to add comment / update that would be useful.
ie.. if you do the change to the file in the pull request, then you need to push it to your own fork & then it automatically updates the pull request.

Instead of the above,  create a template with the Table of differences....


feat: add in style for Note

The main reason for this is that currently you get nice highlighting for:
// TODO

but not for
// NOTE
// XXX

This ensure that the notes are also highlighted in a similiar manner.

Superseded by https://github.com/rebelot/kanagawa.nvim/pull/130.


Documentation doesn't state an important aspect of providing "accessUrl"

Since you have to supply a remote access url with a trailing path the documentation's example is somewhat misleading
since the given example is just a base path.
Not providing a URL with a path creates a local data object - accessing the artifact's data url then causes a NPE.

Hi,
just to verifiy that I understand the problem described:

An artifact is created with the the accessUrl set to a value that is not an URL.
On access of the artifact's data the connector throws an NPE/returns HttpCode 500.

Hello!
No, that's not the issue. It is a valid url, it just doesn't conform to having a path.
For example:
https://URL-WITHOUT-A-PATH.IT - this one would cause a NPE
https://URL-WITH-A-PATH.IT/THIS-IS-THE-PATH
The issue is at the ArtifcatFactory, if I remember correctly, where you check if the path length of a valid URI is not empty.


Update model is not working

When i try to update the model it is making duplicate entry for that same model.
please let me know hot to handle this problem.

I would need more information. I'm working on a new version with many fixes.

@sl0wik let me put it this way,
if i have an instance of App\User class $user when i tried  to update the details in that object it didn't update the details,
instead of that every time new entry was being created on users collection(firebase).
i found the temporary way out before calling update method on $user object i deleted currently existing entry in the colletion,
and after instead of calling update method i created a new instance.
i hope this will help you, le tme know if you need anything else from myside, i would love to help you.


Our pytype check is painfully slow

It takes like 5 minutes to run and I don't know why.

It's because pytype is doing a lot of type inference. In contrast, mypy finishes in a few seconds, but reports 100's of problems, presumable because it is not doing as good a job at type inference. And it looks like pytype is slowest when mypy is unhappiest, e.g. tensornetwork/network_components.py.
Therefore, I'd hazard the guess that making mypy happy would make pytype faster.

That's a good point. I think I can fix most of these issues.

What's the status here? It seems better now, but still slow. I don't mind taking a look, I have some time for an issue like this.

Yeah go for it.
Not much pregress on our side. It's never been too slow to warrent through investigation for us.

Ok! Indeed, it's not blocking at all, I'm interested more out of curiosity about PyType's inner workings than about quicker builds = )


I want to be able to send action events (e.g. TAP) programatically

Hello colleagues. I faced the following problem: DropdownButton / CupertinoPicker doesn't have open API to call tap event programatically. I assume that it would be great to have feature like in iOS Send action event:
[picker sendActionsForControlEvents:UIControlEventTouchDown];
So this will help me present DropdownButton / CupertinoPicker popup programatically without forcing user to do it. Sorry if I am missing already existing solutions.
Thanks in advance any help.

Hi, you can just set expandedparameter to true inside a setState and it will open.


Cyan background

Not sure that's normal, but I just tried podinfo for the first time and it displays a kind of agressive cyan background instead of the darker blue.
I do see where it comes from, see the following code :
<div class="v-parallax" id="parallax-hero" style="height: 500px; background-color: cyan;">

How did you deployed it? In the kustomization deployment the background is set like this https://github.com/stefanprodan/podinfo/blob/master/kustomize/deployment.yaml#L51

Thanks I was just using a bare deployment without any parameters.


Add basic test for kite websocket protocol

@vividvilla Can you please test websocket on python 3 env.

Codecov Report

Merging #29 into kite3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            kite3      #29   +/-   ##
=======================================
  Coverage   79.29%   79.29%
=======================================
  Files           3        3
  Lines         256      256
  Branches       27       27
=======================================
  Hits          203      203
  Misses         44       44
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cce366...e1b6972. Read the comment docs.


ARXIVNG-194 added integration tests

Coverage increased (+1.4%) to 83.588% when pulling a4814f1035977fbb902400049858cb70888f1985 on task/ARXIVNG-194 into 4b47fe569c42a61c62266b494aa5ae92411ddac3 on develop.


[Performance] Refactor use of -allKeys for a 1-2% global CPU optimization.

In this trace, -allKeys and the retain / release costs account for >1% of global app CPU (in this case, a brief scroll in the Profile screen of Pinterest).
Considering that this trace includes substantial image decoding / drawing costs, other UIKit / UICollectionView costs, and also heavy cache reading and writing — this is a surprising % total for this call.
As a simple solution, it would probably be worth maintaining the keys as a separate, duplicated array alongside the NSDictionary to avoid this.  Alternatively, NSHashMap or a similar class might allow for accessing the keys as an array directly without a copy.
A fix for this would further extend PINRemoteImage's performance lead on many competing image downloaders :)

@appleguy - Rather than maintaining another data structure, wouldn't it be sufficient to replace allKeys with keyEnumerator? The large cost is likely due to the fact allKeys performance is going to degrade as the dictionary grows where the enumerator should be a fixed cost. Thoughts?

Good idea!  Let's try that.  It may well be faster than a separate array, but mainly depends on the access patterns.
Sent from my iPhone

On Dec 8, 2016, at 12:26 AM, Rahul Malik<EMAIL_ADDRESS>wrote:
@appleguy - Rather than maintaining another data structure, wouldn't it be sufficient to replace allKeys with keyEnumerator? The large cost is likely due to the fact allKeys performance is going to degrade as the dictionary grows where the enumerator should be a fixed cost. Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Unable to deploy Instance Scheduler template as a Nested Stack (within a StackSet)

The instance-scheduler.template generates the "Main" resource Lambda Function name using the following code
    "FunctionName": {
      "Fn::Join": [
        "",
        [
          {
            "Ref": "AWS::StackName"
          },
          "-InstanceSchedulerMain"
        ]
      ]
    },

If the template is deployed as a Nested Stack, the AWS::StackName is generated by CloudFormation. This causes the above concatenation to exceed the 64 character limit for a Lambda Function name (the AWS::StackName is 100 characters long before adding the hard coded suffix).
This could be easily overcome by allowing the FunctionName to be passed in as a parameter to the template (optionally with a default value pre-populated), rather than forcing an unconstrained string concatentation.

Hi @micklaing-kcom sorry about the issue. We will review it and address the issue in a future release.

We reviewed this request in detail and we do not support the usage of Instance Scheduler as a nested stack. The workaround that we would recommend is to directly customize the instance scheduler template to remove the lambdafunction name.


Interoperating with Trio

Hello! I'm a maintainer of Trio, an async library for Python. (Think of it as an alternative to asyncio.) We just had someone try to use it and raven together, and they ran into some issues: https://github.com/python-trio/trio/issues/469
I'm not sure what the best way to fix these is, and it might require changes on both sides, so I figured it was worth starting a conversation. There are a few different things.
Raven crashes when trying to process Trio program stack frames
Trio, for extremely annoying reasons related to limitations in the Python interpreter and control-C handling, has to store some metadata inside magic invisible local variables that it injects into some user frames  [1]. In order to make sure that we don't collide with actual user local variables, we do this by storing an entry in the frame.f_locals dict with a unique sentinel object as its key, i.e., it's a local variable but its name is not a string. Yeah, Python allows this – who knew, right? Well... apparently raven didn't :-). It makes raven crash. On the one hand, trio's behavior here is The Right Thing, and raven might want to be robust against this in general, given that Python does allow it. OTOH, if raven is breaking then probably other things will also break, and maybe I should just hold my nose and name the variable __trio_internal_value_please_ignore_this_and_dont_name_any_variables_like_this_awoiehiuawf or whatever.
Trio's extensions to Python's extension semantics cause problems with/for Raven
This is more interesting. Trio is a concurrency library, and one of the fun advantages of concurrent programs over sequential programs is that in a concurrency library, you can have multiple things crash at the same time. Most (all other?) concurrency libraries for Python handle this by throwing some exceptions on the floor and hoping for the best. (I guess you of all projects are aware of this!) Trio doesn't throw exceptions on the floor; instead it arranges its tasks in a tree, and if one task doesn't handle an exception it flows up into its parent task, etc., until it eventually hits the root of the whole program. But this means that you have to handle the case where two exceptions are propagating independently and bump into each other. Python... doesn't really have any way to handle this, but we refuse to throw exceptions on the floor, so we're stuck hacking around Python's limitations.
Basically the way we do this is with a MultiError class, which is an Exception class that acts as a container for other exceptions. It's actually fairly sophisticated: you can have MultiErrors nested inside each other, and the nested structure represents the nested structure of the task tree, we have mechanisms to catch "part of" a MultiError and trio knows how to fix up tracebacks afterwards, we can print tracebacks in a nice way where we first show the path that each exception took independently, then as they join up we switch to printing the common traceback together, etc.
There's a simple example here to give you the idea.
Of course, raven has no idea about any of this.
One issue this causes is that trio and raven both want to take over sys.excepthook. They're both written carefully, but since trio actually wants to replace the default handling of tracebacks, it can't do raven's trick of falling back on the regular hook; instead, if it detects that some other library has been missing with sys.excepthook, then it prints a warning and skips installing its hook. End result: if you import raven, trio, then exception printing is broken. import trio, raven OTOH works fine. It'd be nice if we could coordinate to make this work both ways. Any ideas?
The other deeper issue is obviously raven has no idea about these special MultiError objects, so even after we get excepthook to run, it won't actually be able to report proper traceback information. Ideally raven should be peeking inside to gather up the full traceback tree, especially since the topmost MultiError's traceback will usually be the boring stuff you already knew like "oh the error happened underneath main that's nice good to know", and it's the embedded exceptions that have the information on the frames where the errors actually occurred.
I'd love to hear any thoughts here.

[1] If you really want to know the details, there's an exhaustive/exhausting blog post here, and bpo-12857 is the upstream issue that I'm hoping we might be able to fix for 3.8. But in the mean time we're stuck with this.

Just a quick comment about storing integers in f_locals: is not a great idea because it requires that the dict representation allows non string keys which is normally not the case.

@mitsuhiko You mean, you lose the optimization for dicts where all the keys are strings? I guess that's true, but I don't think it matters – the f_locals dict isn't used at all during normal execution.

I ran into the  LOCALS_KEY_KI_PROTECTION_ENABLED :/ I thought maybe we can adapt the JSON encoder to deal with this, but it doesn't seem possible to change it's behaviour with any default types (in this case, a dict).

I have prepared #1273 that fixes that problem, but it still hasn't been merged yet.
FWIW, python-trio/trio#599 which is included in 0.7.0 also prevents this issue from occurring.


Added "get_quest_property"

Summary
This PR main goal is to add the get_quest_property to quest_manager.gd, to access properties of quests through the "QuestSystem" Autoload.
func get_quest_property(quest_id: int, property: String) -> Variant:

	# Find the quest
	var quest: Quest = __get_quest_by_id(quest_id)

	if quest == null: return null

	# Now check if the quest has the property
	var property_found : bool = __quest_has_property(quest, property)

	# Return if the property was not found
	if not property_found: return null

	# Finally we get the value
	return quest.get(property)

Because get_quest_property and set_quest_property share same logic, I extracted these logics to separate functions to be reused by these two functions.
func __quest_has_property(quest: Quest, property: String) -> bool:
	# If the property is null -> we return
	if property == null: return false

	var was_property_found: bool = false
	# Then we check if the property is present
	for p in quest.get_property_list():
		if p.name == property:
			was_property_found = true
			break

	return was_property_found

func __get_quest_by_id(quest_id: int) -> Quest:
	var quest: Quest = null

	# Find the quest
	for pools in get_all_pools():
		if pools.get_quest_from_id(quest_id) != null:
			quest = pools.get_quest_from_id(quest_id)

	return quest

I also fixed some commentary issues in the code, like the missing "region" in "QuestAPI" and a type "QuesySystem" in quest_resource.gd.
Checklist

[x] This PR changes something in the code (e.g. for better performance).

[x] If any code changes had taken place, I've tested them before committing.
[x] I've properly updated the documentation to reflect the changes I've made.

[x] This PR adds something new.
[ ] This PR fixes an issue.
[ ] This PR includes breaking changes.
[ ] This PR is not code related (e.g. README, Documentation)

If there is any other issues with the code, please let me know.

Overall, the PR looks good, just some minor things to change!

Done, see if everything is ok now.

Almost done! You just forgot to change the return type in the documentation, but other than that it looks good enough for me!

Ok, I will now just squash the commits


Remove useless tests which occasionally fail because of timestamps

Remove tests which just check that the logger is hooked up to the error handler, not really useful and occasionally fails if the ttime changes as the test is running
@anz-bank/sysl-developers

Don't have much clue on this functionality, but seems like valid test cases for SyslParserErrorListener. Why do we have to remove them?

@springwiz They are useless tests because the only thing they do is check that the callback writes something to the log and the correct timestamp. It was failed enough during my local builds that its driving me mad (the timestamp between the test happening and the log being written can be long enough to fail). Just want to remove them

the test caused #381 too


Bring back support for 16299 for UWP apps

Is your feature request related to a problem? Please describe.

16299 is essential for enterprise customer, who can't/don't update to the latest version. It seems like the Azure DevOp issue that was forcing RxUI to set the min version to 17763 is now merged.
Describe the solution you'd like

Describe alternatives you've considered

Describe suggestions on how to achieve the feature

Additional context

Will come back with rxui 10 which will be released soon.

Fixed by  #2102

This was released in 9.19.2 -- 10 was taking a bit too long to get out.


Theme Saving

Moved the loading chunk out of the page load function so that it will work on old browsers. Fixes #24

Glad to be able to help!


Hooks: $ID variable is not working anymore

Description
Previously we were using a lot of hooks based on simple action, eg:
NAME      = report_done
TYPE      = state
COMMAND   = report-done.sh
ARGUMENTS = "$ID"
ON        = CUSTOM
RESOURCE  = VM
STATE     = DONE
LCM_STATE = LCM_INIT

This hook should call report-done.sh 123 where 123 is virtual machine id.
Now we forced to use $TEMPLATE instead and parse object ID from it manually
To Reproduce

create hook /var/lib/one/remotes/hooks/report-done.sh:

#!/bin/sh
echo "ID=$1" >> /tmp/123

configure hook template in opennebula
try run hook
check /tmp/123

Expected behavior
ID will be written into file
Details

Affected Component: hem
Hypervisor: kvm
Version: 5.10.3

Additional context
Add any other context about the problem here.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Hello @kvaps,
Yes $ID is not supported anymore, you can use $API or $TEMPLATE (depending on the type of hook you are using) and retrieve it from it. Please check the upgrade guide and the documentation to find more info:

http://docs.opennebula.org/5.10/intro_release_notes/upgrades/upgrade_58.html#update-your-hooks
http://docs.opennebula.org/5.10/integration/infrastructure_integration/hooks.html

Any feedback is very welcome!


SHIP-0039: Command line option to set node selector on Build/BuildRun

Feature
Add command line option to set node selectors on BuildRun objects (and potentially Build objects). Described in SHIP-0039
Depends on https://github.com/shipwright-io/build/issues/1635

hey, I would like to take this issue.

@7h3-3mp7y-m4n this issue depends on https://github.com/shipwright-io/build/issues/1635 being implemented first. Please take a look!

Okay @adambkaplan , I'll look at it. Thanks!


BAU add last know healthy shrinkwrap

WHAT
Add the shrinkwrap from the last known healthy version of selfservice to master.
This should pin the dependencies to the versions as they were before we experienced problems.

The version of nunjuks being pulled in
+--<EMAIL_ADDRESS>👍


Types: Add html props from the native element each component inherits…

… from.
Resolves #65

Merged, thanks!


[WIP] Migrate torchvision Github docs from master to main

Closes #4356

[x] Add .gitignore
[x] Edits versions.html and Readme
[x] Create symbolic link for master to main.

Note that this PR goes to gh-pages branch and not to the master branch.

Hi @NicolasHug  I think I have done all the changes. Also I think I have created a correct symlink for master to main.
Can you have a look at CircleCI failure?

Apparently the Circle CI failure appeared in torchaudio PR too.
https://github.com/pytorch/audio/pull/1676

The gitignore is also in torchaudio over gh-pages. I merely copy pasted it. And added to ignore editor configs.
Also there is a small chance someone working on torchvision might push it and docs. So just added that too. (It did happen in my editor why made it hard to see stuff).

Let's merge over weekend. 😀 Good idea.

Thanks!


The add user button (+) is not working

As the title says, nothing happens.

The + button is scraped from messenger.com, that's probably the reason


A few of your favorite things

Step 8: Add a list
In this pull request, you'll learn about lists and emoji. You'll also list a few details in your resume.
:point_down: These are expandable dialogues! Click to open and see more information.

Emoji
Emoji
Emoji are fun :sparkles:, and they can be silly :stuck_out_tongue_winking_eye:, but they can also be an important communication tool when working with remote teams ✅. Tone doesn't come across as clearly when reading text as it comes speaking face to face, and emojis can be helpful in conveying context and emotions. :heart:
Emoji are best used as additive extras, not replacements for text. With images, descriptive text makes it clearer for screen readers, but screen readers aren't guaranteed to convey the intent of an emoji. Make sure your meaning is clear in text, so emoji will help instead of causing more confusion.
Here are some examples of popular emojis in markdown.

What you see
What you type

:heart:
:heart:

:+1:
:+1:

:smile:
:smile:

:sparkles:
:sparkles:

:tada:
:tada:

For more information about available emoji, see this handy cheat sheet. In most text fields on GitHub, you can type : and then begin to type the name of an emoji. A fuzzy search will bring up the 5 best guesses and let you select one.

Ordered Lists
Ordered Lists
Ordered lists have numbers. You can nest ordered lists within a list item by indenting them. You can read more about formatting and syntax in the GitHub Help.
1. Item 1
2. Item 2
3. Item 3
   1. Item 3a
   2. Item 3b

Item 1
Item 2
Item 3

Item 3a
Item 3b

Unordered Lists
Unordered Lists
To create an unordered list, use either the - or * character. As with ordered lists, you can nest a list by indenting two spaces.
* Item 1
* Item 2
  * Item 2a
  * Item 2b

Item 1
Item 2

Item 2a
Item 2b

Adding a list
Help people get to know you by adding a list containing a few of your favorite things. Don't know what to add? Why not add a list of your favorite books or places to eat.
:keyboard: Activity: Create a list

Edit the _includes/04-lists.md in this pull request.
Create a markdown list in the file. It can be ordered or unordered.
Commit your changes.

Step 9: Use emphasis
Great job with those lists! Let's try something new. You can use bold and italic text in Markdown. There are a couple of ways to create emphasis.
*This text will be italic*
_This will also be italic_

**This text will be bold**
__This will also be bold__

_You **can** combine them_

:keyboard: Activity: Add some emphasis

Edit the file _includes/05-emphasis.md in this pull request.
Use the Preview tab and your :sparkles: new Markdown knowledge, add emphasis (like bold or italics) to your skills.
Enter a short and descriptive commit message.
Commit your changes.

:keyboard: Activity: Merge the Pull Request

Click Merge pull request below.

:keyboard: Activity: Delete the branch

Delete your branch in this pull request.


Add docs on starting up bot

Since people are starting to contribute to this, we need docs on how to get the bot up and running locally, or a workaround on how to test the bot without actually being logged into Discord, potentially.

Docs have been updated.


NonViewComponentAttribute

Currently if I have the following class in the project:
public class BaseViewComponent
{
    // nothing interesting here, continue reading
}

I will receive an exception from the view component descriptor collection provider that the above class is missing Invoke or InvokeAsync method. I can easily fix the issue by making the class abstract but since there are NonControllerAttribute and NonActionAttribute maybe it will be useful to have NonViewComponentAttribute.

/cc @Eilon this is probably something it wouldn't hurt to add

I believe NonViewComponent as described here might introduce an inconsistency with the behavior for NonController. NonController marks everything in the hierarchy as not a controller. I'm not sure what the convention for view components is, but given that BaseViewComponent is being picked up, I tend to think its not compatible with the controller one. This is just something to factor in.

I think @javiercn is right here, we'd want it to behave the same for a hypothetical NonViewComponentAttribute as it does for NonControllerAttribute, so the solution to your problem is, as you said, mark it abstract like we do here. That said I think it's perfectly reasonable to add a NonViewComponentAttribute seeing as it seems to be the pattern.


Redis/Memcache clients should return failure exceptions

Right now, if any Error type is returned from the underlying parser, they get grouped into an 'unexpected reply exception', which is not the same as an error.  The clients should be able to differentiate between this and throw exceptions accordingly.

I'm trying to remember the context of this ticket.  I think we wanted to differentiate between an actual Error from redis/memcache and just a garbled/bad response?
If that is the case, then I think  we are already doing that.


_reactRouter.match is not a function

Hi!
I try to create an isomorphic router but i got some errors. I base my work on this post https://github.com/rackt/react-router/issues/1990#issuecomment-141915021 but in my router file, my react-router match function is undefined.
import React from 'react';
import Router, { match, RoutingContext } from 'react-router';
import createRoutes from './create-routes';

function getRootComponent(renderProps) {
  let component = null;

  if(__SERVER__) {
    component = (<RoutingContext {...renderProps} />);
  }else{
    component = React.createElement(Router, renderProps);
  }

  return component;
}

export default function isomorphicRouter(location, history, req, res) {
  const routes = createRoutes();

  console.log(match);

  return new Promise( (fullfill, reject) => {
    match({routes, location, history}, (error, redirectLocation, renderProps) => {
      if(!error) {
        if(renderProps) {
          renderProps.history = history;
        }

        fullfill(getRootComponent(renderProps));
      }else{
        reject(error);
      }
    });
  });
}

I use it like this with my express middleware
import React from 'react';
import createLocation from 'history/lib/createLocation'
import createMemoryHistory from 'history/lib/createMemoryHistory';
import isomorphicRouter from '../isomorphic-router';

export default function(req, res) {
  let location = createLocation(req.url);
  let history = createMemoryHistory();

  isomorphicRouter(location, history, req, res)
  .then((reactEl) => {
    try {
      let reactStr = React.renderToString(reactEl);
      res.send(reactStr);
    } catch (err) {
      res.status(500).send({error: err.toString()});
    }
  }, (err) => {
    console.log('err', err);

    res.status(500).send({error: err});
  });
}

What goes wrong in this? Thank you!

What version are you on? Try run npm list react-router.
You need to be on v1.0.0-rc1 to be able to use match.

You can close it, sorry i was in 0.13... I was sure to be at v.1

Do you have some errors, then you were trying change path?

@DWboutin You should have a "close issue" button somewhere on the page.


Standardize spelling of "pseudoinstruction"

The change is ok for me, but it does not cover all instances:
riscv-asm.md:can use an `UNIMP` pseudo-instruction, which should trap in nearly all systems.
riscv-asm.md:affect the expansion of the `la` pseudoinstruction, refer to
riscv-asm.md:[listing of standard RISC-V pseudoinstructions](#pseudoinstructions).
riscv-asm.md:The following example shows the `li` pseudo instruction which
riscv-asm.md:The following example shows the `la` pseudo instruction which is used to load
riscv-asm.md:For non-PIC this is an alias for the `lla` pseudo instruction documented below.
riscv-asm.md:For PIC this is an alias for the `lga` pseudo instruction documented below.
riscv-asm.md:The `la` pseudo instruction is the preferred way for getting the address of
riscv-asm.md:The following example shows the `lla` pseudo instruction which is used to load
riscv-asm.md:The following example shows the `lga` pseudo instruction which is used to load
riscv-asm.md:The following pseudo instructions are available to load from and store to
riscv-asm.md:The following example shows how these pseudo instructions are used:
riscv-asm.md:The following pseudo instructions are available to call subroutines far from
riscv-asm.md:The following example shows how these pseudo instructions are used:
riscv-asm.md:##  A listing of standard RISC-V pseudoinstructions

Please make them all equal (pseudoinstruction).

ok, Thanks for reminding

Merged. Thx!


Support flattening lists in step plugins list

Is your feature request related to a problem? Please describe.
In an effort to keep our pipeline steps more concise we're using YAML anchors and aliases to define the plugins for our steps at the top level and we reuse the lists in multiple places. This works well but we have some steps that need to fetch artifacts or add additional plugins. Since YAML doesn't support merging lists with anchors like it does for dictionaries, we need to redefine the list of plugins for these other use cases. Because of how our caches are layered, our lists of plugins can be 9 elements or longer and we have 3 redefinitions of the same list with only one plugin change each. The motivation to DRY this up is that our pipeline is already pretty long and over time when new cache layers are added, I don't want it to be so easy to forget to add it to the other plugin lists used by other steps.
Describe the solution you'd like
If the command plugins option also supported lists of lists of plugins as elements, we could do something like this simplified example:
docker-plugins: &docker-plugins
  - docker-compose#v3.9.0: ~
  - cache#v1.0.0:
  	keys: "v1-gems"
        paths: "vendor/bundle"

asset-plugins: &asset-plugins
  - cache#v1.0.0:
  	keys: "v1-assets"
        paths: "public/assets"

steps:
  - label: Do something with assets
  	command: ".buildkite/steps/asset_stuff"
    plugins: *asset-plugins

  - label: Do something with docker
    command: ".buildkite/steps/docker_stuff"
    plugins: *docker-plugins

  - label: Do something with assets and docker
    command: ".buildkite/steps/rspec"
    plugins: [*asset-plugins, *docker-plugins]

The statement [*asset-plugins, *docker-plugins] produces a list with 2 elements both being lists of plugins. If the agent supported running a flatten operation on the plugins list, this would work.
Describe alternatives you've considered
I don't see any downsides to this solution, the plugin order is still clear as long as the flattening happens in order of list definition. It should also be a pretty small change, though might require a schema change in the backend to support validating the pipeline.
Additional context
Add any other context or screenshots about the feature request here.

Hey kevin! i've raised this with the team internally, and we'll discuss it over the next little while - i see your use case here, having heaps of plugin defs gets hard to read.
one thing that you could do in this case is generate your pipeline.yml using some other tool (possibly Starlark/Jsonnet and friends), but in that case you'd probably lose the readability of it, which would be a bummer.


Removing prefix warning for brew doctor in arm mac

Provide a detailed description of the proposed feature
I find that the warning provided by brew doctor is quite confusing: If we simply follow the default installation script, brew is installed under /opt/homebrew/bin/.
Warning: Your Homebrew's prefix is not /usr/local.
Some of Homebrew's bottles (binary packages) can only be used with the default
prefix (/usr/local).
You will encounter build failures with some formulae.

But from some of the discussion, this seems to be a designed choice made officially. I think this warning should either be taken down entirely or directed to discussions like the link above and tell the user that the rosetta-2 version can be installed in /usr/local if needed.
What is the motivation for the feature?
The default prompt is now confusing and not informative.
How will the feature be relevant to at least 90% of Homebrew users?
There are a LOT arm-mac users nowadays, and it'll keep growing.
What alternatives to the feature have been considered?
Not sure.

Have you been able to generate that warning with brew doctor on an M1 Mac?

Yes, see the following.

That shouldn't be happening.
What's the output of brew config?
Also, please don't use screenshots when sharing the output of commands in your terminal. They're often difficult to read and impossible to reuse (e.g. when looking up error messages). Instead, copy the text here and wrap them in three back-ticks (```) on the line before and on the line after to format them properly.

Ah, sure. The output of brew config is the following.
❯ brew config
HOMEBREW_VERSION: 3.5.6
ORIGIN: https://github.com/Homebrew/brew
HEAD: 0b030b74e2ac518bd0bc4158f96c449198f9957f
Last commit: 9 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 2c4f76e9687659cac2ca50558c044c9c2459e183
Core tap last commit: 5 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_REPOSITORY: /opt/homebrew
HOMEBREW_CELLAR: /opt/homebrew/Cellar
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit westmere
Clang: 13.1.6 build 1316
Git: 2.32.1 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.5-x86_64
CLT: <IP_ADDRESS>.1.1651278267
Xcode: 13.4.1
Rosetta 2: true

This is your problem:
Rosetta 2: true

Don't run brew under Rosetta (e.g. try prepending arch -arm64 to your brew invocations).


Support a Per-Machine Install in Chocolatey Package for Boxstarter

I have some Ops who have to change profiles during a build process.
Would be nice if boxstarter could be installed to ProgramData where it could be accessed by all profiles and referenced in a consistent manner when calling it in other scripts.
ProgramData would not require admin rights.
Thanks,
D.

Yup. This was also mentioned in #32 but this more succinctly captures the issue so I'm gonna track it here. Thanks!

Installing to ProgramData would be more consistent with chocolatey's approach, and would also be more friendly for use in scheduled tasks, etc.
It's a bit odd installing to a user's AppData because chocolatey tracks package installations system-wide (in ProgramData) so if another user wanted boxstarter they would need to "reinstall". Starts getting weird...

Would probably be as simple as changing setup.ps1 from:
$boxstarterPath=Join-Path $env:AppData Boxstarter

to
$boxstarterPath=Join-Path $env:ProgramData Boxstarter

and from:
$value = [Environment]::GetEnvironmentVariable($variableName, 'User')
...
[Environment]::SetEnvironmentVariable($variableName, $values, 'User')

to
$value = [Environment]::GetEnvironmentVariable($variableName, 'Machine')
...
[Environment]::SetEnvironmentVariable($variableName, $values, 'Machine')

If you think the above changes are sufficient then I'll submit a pull request.
However, this is potentially a breaking change. Specifically, existing installations with packages in $boxstarterPath\BuildPackages would need these to be moved when upgrading. Ought this be performed by the upgrade, or the user's responsibility?
The installation location could alternatively be controlled through $installArgs, but I think the default ought to change to ProgramData regardless for system-wide consistency.

A PR would be great @samjetski !

I just ran into this as well - I think the suggested changes in the proposed PR make sense - this following should be vetted

However, this is potentially a breaking change. Specifically, existing installations with packages in $boxstarterPath\BuildPackages would need these to be moved when upgrading. Ought this be performed by the upgrade, or the user's responsibility?

What are the thoughts on the best path forward

I should have looked #221!
Does this need anymore help - looks like you wanted to strip the user install completely and only go with machine

I'm just waiting for recent chocolatey updated to stabilize before pulling in #221.

Is chocolatey stable enough for this change yet?

@mwrock As @brettjacobson said above, where are we at with this?  I noticed this has issues running in any scenario where the boot strapper is running as system(most cloud deployments).

just merged that PR along with changes to docs. Will go out in next release soon.


avoid integer overflow when setting up zipf distribution

I have workloade running in an infinite loop because I passed in recordcount=0 and operationcount > 0.
recordcount 0 is treated as a special case meaning "MAX_INT"
recordcount=Integer.parseInt(p.getProperty(Client.RECORD_COUNT_PROPERTY, Client.DEFAULT_RECORD_COUNT));
if(recordcount == 0)
  recordcount = Integer.MAX_VALUE;

and later workload e calculates the generator
else if (requestdistrib.compareTo("zipfian")==0)
{
  //it does this by generating a random "next key" in part by taking the modulus over the number of keys
  //if the number of keys changes, this would shift the modulus, and we don't want that to change which keys are popular
  //so we'll actually construct the scrambled zipfian generator with a keyspace that is larger than exists at the beginning
  //of the test. that is, we'll predict the number of inserts, and tell the scrambled zipfian generator the number of existing keys
  //plus the number of predicted keys as the total keyspace. then, if the generator picks a key that hasn't been inserted yet, will
  //just ignore it and pick another key. this way, the size of the keyspace doesn't change from the perspective of the scrambled zipfian generator
  int opcount=Integer.parseInt(p.getProperty(Client.OPERATION_COUNT_PROPERTY));
  int expectednewkeys=(int)(((double)opcount)*insertproportion*2.0); //2 is fudge factor

  keychooser=new ScrambledZipfianGenerator(recordcount+expectednewkeys);
}

ScambledZG takes a long for number of items, but since recordcount and expectednewkeys are both integers, the result is overflow and then poor behavior while trying to get the next keynum.
workload e is the only one of the standard workloads to have a zipf distribution and insert operations in run mode. In all of my load statements I don't use recordcount=0 because I'm breaking up the inserts over multiple clients.

note that this happens before anything can be written out, so you can only see it by looking at jstacks. :person_frowning:
also it can happen with any combination of record count, opcount and insertporportion that cause s the calculation to go above MAX_INT

I currently work around this by lowering my record count by the amount that the expectednewkeys raises it:
-P "${WORKLOADS}/workloade"  -p recordcount=$((RECORD_COUNT - INSERT_COUNT * 2 / 20)) -p operationcount=${INSERT_COUNT}

In the script where I use this, RECORD_COUNT is MAX_INT and INSERT_COUNT is RECORD_COUNT / NUM_CLIENTS


Updating the Bios

Docs Build status updates of commit d46a057:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/nishith-pathak.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nispathak
Your change is merged and published to live. Please check it from RD website: https://rd.microsoft.com/en-us/nishith-pathak


Feature/mentees endpoints

Description
Wrote endpoints for the Mentees model. similar to the Mentor model
adeed some tests
Checklist
Remove any items which are not applicable.

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works AND the tests pass

@damola-sd  Please pull from development, I have merged a PR from @iamcristos since I left my review.


inline style of new tag have not affected by the slot template

Hello,
I was trying to customize that tags to it own background color. I add a template slot like this:
<template slot="tag" slot-scope="props">

        {{props.option.value}}

</template>

However, the background is not change instantly after a add a new tag, instead, it only change after I refresh the page. I found that the inline style of the slot is not applied once a new tag is added.
init state (expected result):

delete test3 and re-add:

the source code:

I just found the problem, it was missing color attribute in the options props. Sorry for bothering


Remove stuff that was deprecated in 0.9

Codecov Report

Merging #888 into master will decrease coverage by 27.67%.
The diff coverage is 20%.

@@             Coverage Diff             @@
##           master     #888       +/-   ##
===========================================
- Coverage    85.1%   57.43%   -27.68%
===========================================
  Files          76       76
  Lines        2498     2469       -29
  Branches      186      172       -14
===========================================
- Hits         2126     1418      -708
- Misses        372     1051      +679

Impacted Files
Coverage Δ

.../scala/io/circe/generic/extras/Configuration.scala
100% <ø> (+6.66%)
:arrow_up:

.../core/shared/src/main/scala/io/circe/ACursor.scala
18.6% <ø> (-36.96%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonObject.scala
81.59% <ø> (-12.2%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
88.46% <ø> (-7.58%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
38% <0%> (-51.91%)
:arrow_down:

...in/scala/io/circe/benchmark/FoldingBenchmark.scala
0% <0%> (-89.66%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
89.37% <100%> (-1.81%)
:arrow_down:

...ed/src/main/scala/io/circe/disjunctionCodecs.scala
0% <0%> (-100%)
:arrow_down:

...rc/main/scala/io/circe/benchmark/ExampleData.scala
0% <0%> (-100%)
:arrow_down:

...scala/io/circe/benchmark/JsonObjectBenchmark.scala
0% <0%> (-100%)
:arrow_down:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9299d0a...2feb1c6. Read the comment docs.


add OSGeo.QGIS 3.18.3

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

🤷🏻♂

/azp run

/azp run


[Explicit Module Builds] Rely on the dependency scanner to produce complete compile commands for Swift dependencies

This change removes instances where the driver modified command-line invocations used to build Swift module dependencies, as produced by the dependency scanner. Instead, the scanner will now emit command line argument sets that are sufficient to build all such module dependencies out-of-the-box, including explicit dependency inputs.
The scanner adopts (https://github.com/apple/swift/pull/63460) newly-(re-)added -swift-module-file to specify explicit Swift interface dependencies' explicit dependencies. The driver continues using -explicit-swift-module-map-file JSON file input to specify all explicit dependencies for the main module's compilation commands (emit-module, compile, etc.), furthermore moving prebuilt Clang dependencies to also appear in this file, thanks to @allevato's change in https://github.com/apple/swift/pull/63178.

We should wait a fair bit to merge this, at least until https://github.com/apple/swift/pull/63460 makes it to a toolchain snapshot picked up by CI.

https://github.com/apple/swift/pull/63460 has made it to a nightly toolchain. (swift-DEVELOPMENT-SNAPSHOT-2023-02-09-a )

@swift-ci test

@swift-ci test

Not to be merged until https://github.com/apple/swift/pull/63697 lands, otherwise Explicit Modules functionality will be limited.

@swift-ci test


Grant permissions from enabled datasources

This PR technically doesn't affect the behaviour of the CM, due to other bugs (see https://github.com/me-box/admin/issues/11#issuecomment-282441263). Once those bugs are solved though, it will (for the better).

Merged this into #46 manually


Describe certificates' reconciliation in points

Description
Changes proposed in this pull request:

Write the description of the certificates' reconciliation in points.
Adjust the certs diagram

Related issue(s)
Resolves #362

/retest


Setup.bat copying to wrong folder

Description
Setup.bat copying to wrong folder.
It created folder in desktop but it must be on project folder.
bug in setup.bat line 46  "......\spatial\schema"
I think it must be "....\spatial\schema"
Expected behavior
Setup.bat to copy files to projectfolder/spatial
Current behavior
Setup.bat copies files to upper folder /projectfolder/../
Possible solution
change a single line
Steps to reproduce

Run Setup.bat
get errors on run

Environment
Windows 10
UE 4.20

Hi @ihavenick, I believe you may need to adjust your project structure as per our porting guide.
Your new project structure should look something like this:
\OuterFolder\
\OuterFolder\spatial\schema
\OuterFolder\ProjectFolder\

In case it would be easier with a reference, please take a look at the project structure in our ThirdPersonShooter project.

I used starter content allready.
and realizied setup.bat is at wrong location or need to create a master folder for plugins.

Leaving my wrong folder structure for others not to do like me.


[Snyk] Upgrade rollup from 2.67.2 to 2.74.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade rollup from 2.67.2 to 2.74.1.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 15 versions ahead of your current version.
The recommended version was released a month ago, on 2022-05-19.

Release notes

Package name: rollup

2.74.1 - 2022-05-192022-05-19
Bug Fixes

Revert #4498 until some issues are understood and resolved

2.74.0 - 2022-05-192022-05-19
Features

Remove unneeded default values for function parameters (#4498)

Bug Fixes

Use a consistent mechanism to resolve the config file to avoid issues on Windows (#4501)
Avoid an inaccurate warning about an event emitter leak for complicated builds (#4502)
Ensure that reexporting values from other chunks via dynamic imports does not reference non-imported variables (#4499)

Pull Requests

#4498: Tree shake parameter defaults (@ lukastaegert)
#4499: Ensure reexports are available for namespaces (@ lukastaegert)
#4501: fix: config path problem on windows (@ pos777)
#4502: Avoid maximum listeners exceeded warning (@ lukastaegert)

2.73.0 - 2022-05-132022-05-13
Features

Do not treat Object.defineProperty/ies as side effect when called on an unused object (#4493)
Do not assume that assigning a property can create a getter with side effects (#4493)
Do not treat string.prototype.replace(All) as side effect when used with two literals (#4493)

Bug Fixes

Detect side effects when manually declaring getters on functions (#4493)

Pull Requests

#4493: Handle getters on functions and improve property deoptimization (@ lukastaegert)
#4494: Do not treat string.replace as side effect when used with a literal (@ lukastaegert)
#4495: Update docs for --configPlugin using typescript (@ Jimmydalecleveland)

2.72.1 - 2022-05-072022-05-07
Bug Fixes

Improve tree-shaking of classes with super classes in certain scenarios (#4489)

Pull Requests

#4489: Do not deoptimize entire super class when adding a property (@ lukastaegert)

2.72.0 - 2022-05-052022-05-05
Features

Add CLI hooks to run external commands at certain points in watch mode (#4457)

Bug Fixes

Fix an issue that could accidentally treat relevant assignments as side effect free (#4486)

Pull Requests

#4457: feat: CLI event hook flags (@ Harris-Miller)
#4486: Fix reassignment tracking (@ lukastaegert)

2.71.1 - 2022-04-302022-04-30
Bug Fixes

Allow importing loadConfigFile without extension (#4483)

Pull Requests

#4483: Add exports exception for loadConfigFile (@ lukastaegert)

2.71.0 - 2022-04-302022-04-30
Features

Mark Object.hasOwn as pure (#4482)

Bug Fixes

Prevent infinite recursion and display proper warning for recursive reexports (#4472)
Fix type issue in TypeScript nightly (#4471)

Pull Requests

#4467: docs: update deprecated option in tools.md (@ kimjh96)
#4471: Fix: tsc did not build (@ frank-dspeed)
#4472: Throw proper error when indirectly reexporting a recursive binding (@ lukastaegert)
#4475: chore: bump deps (#4475) (@ dnalborczyk)
#4477: chore: bump github actions (@ dnalborczyk)
#4478: ci: test with node.js v18, remove v17 (@ dnalborczyk)
#4479: chore(repo): replace git.io in the issue template (@ SukkaW)
#4482: feat: add Object.hasOwn as pure function (@ dnalborczyk)

2.70.2 - 2022-04-152022-04-15
Bug Fixes

Do not enforce undefined return values in TypeScript types (#4463)

Pull Requests

#4463: use void for options hook instead of undefined (@ ycmjason)

2.70.1 - 2022-03-142022-03-14
Bug Fixes

Handle unfinished hook action errors as regular errors and avoid console logging (#4434)
Allow access to "dist" folder in a Node 17 compatible way (#4436)

Pull Requests

#4434: Track unfinished hook actions as regular errors (@ lukastaegert)
#4436: Update package.json (@ frank-dspeed)

2.70.0 - 2022-03-072022-03-07
Features

Make the watchChange and closeWatcher hooks asynchronous and make Rollup wait for these hooks before continuing (#4427)

Bug Fixes

Do not abort watch mode for errors in watchChange but display them properly (#4427)

Pull Requests

#4427: Do not abort watch mode on errors in watchChange (@ lukastaegert)

2.69.2 - 2022-03-06

2.69.1 - 2022-03-04

2.69.0 - 2022-03-02

2.68.0 - 2022-02-22

2.67.3 - 2022-02-18

2.67.2 - 2022-02-10

    from rollup GitHub release notes

Commit messages

Package name: rollup

e823ede 2.74.1
de80b7e Update changelog
1743794 Revert "Tree shake parameter defaults (#4498)"
fc99e96 2.74.0
ba0ca85 Update changelog
4624917 Tree shake parameter defaults (#4498)
05d294f Ensure reexports are available for namespaces (#4499)
0537d93 Avoid maximum listeners exceeded warning (#4502)
bf1ff32 fix: config path problem on windows (#4501)
931a199 2.73.0
7a78313 Update changelog
4079fbe Do not treat string.replace as side effect when used with a literal (#4494)
bbd54b7 Update docs for --configPlugin using typescript (#4495)
f3a1fa3 Handle getters on functions and improve property deoptimization (#4493)
8c6e0f3 2.72.1
5ea1b39 Update changelog
47d8d5a Do not deoptimize entire super class when adding a property (#4489)
19aef13 2.72.0
c890249 Update changelog
6195638 Fix reassignment tracking (#4486)
0c75914 feat: CLI event hook flags (#4457)
f44a3a3 2.71.1
e092ea6 Update changelog
51972b0 Add exports exception for loadConfigFile (#4483)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:


Form widget is wider than its parent.

Create a widget with a Form descendant.
class MyWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
      width: 500,
      child: MyForm(),
    );
  }
}

class MyForm extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Form(
      child: Column(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: <Widget>[
            TextFormField(
              decoration: const InputDecoration(
                labelText: 'label',
                hintText: 'hint',
              ),
            ),
          ]),
    );
  }
}

I expected that MyForm and MyForm > Form will be no wider than 500px. In reality both widgets expand to fill the width of the entire screen.
The only way I've found to limit the size of a form is by putting it in a Flex with other widgets, like Row or Column:
class MyWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    // Now the form only takes up 1/3 of the screen width.
    return Row(children: [
      Expanded(child: Container()),
      Expanded(child: MyForm()),
      Expanded(child: Container()),
    ]);
  }
}

Why does this happen?

@kharland is MyWidget the root of your application (i.e. passed to runApp)?

Form isn't a render object so it has no geometry. You should have the same problem if you just used Column in MyForm directly.
As far as I can tell this is working as intended.


Fixes #495 - add a player implementation of isVRCameraActive()

and don't initialise object picking if we're in player mode

lgtm


icon and template do not seem properly on mozilla and mozilla editions

hi
i am using sourcegraph for one weeks, its cool tool but in mozilla extension there is a puzzle icon for the  app, and extension view/template is not properly as in chrome. I use the extension in Mozilla developer edition and also looked up for normal Mozilla but all editions do not looks good.
here is screenshot.
is it normal or are there are problem with CSS/HTML rendering cause mozilla engine etc?

Hi @eliakorkmaz thanks for the report. Which version of firefox are you running?

Hi @keegancsmith . for normal Firefox version its 57.0.2 and for Dev edition 58.0b10.

cc @KattMingMing

@attfarhan owns the extension now

same.

Thanks for the report.  Fix coming soon.


Missing constant in calculation of A and A_w?

Hi Nico,
In the change to a matrix-vector calculation it seems that the constant 0.305 is left out. The original equation reads
(2 * R + G  + B/20 - 0.305)*Nbb

Is this a mistake in your manuscript or is the difference made up someplace else? I can't seem to find either an explanation or an obvious substitution.
Thank you very much for the time, happy new year.
-Tucker

Where exactly?

Where exactly?

In step 4* you replace the A and Aw equations with the first line of the matrix vector equation. A useful speedup but I am wondering about a constant that is located in the original equation.
(step 6 from CAM16 by Li et. al, doi: 10.1002/col.22131)

However, after testing your method as an implementation of CAM02 and CAM16 it is correct with the examples from "Color Appearance Modeling" Fairchild 2013 and Colorimetry 4th ed from CIE.
TLDR what I thought was a bug doesn't appear to be, but I'm not sure where the difference is being made up.

In step 4* you replace the A and Aw equations with the first line of the matrix vector equation. A useful speedup but I am wondering about a constant that is located in the original equation.
(step 6 from CAM16 by Li et. al, doi: 10.1002/col.22131)

However, after testing your method as an implementation of CAM02 and CAM16 it is correct with the examples from "Color Appearance Modeling" Fairchild 2013 and Colorimetry 4th ed from CIE.
TLDR what I thought was a bug doesn't appear to be, but I'm not sure where the difference is being made up.

I see. In CAM16, they're adding +0.1 to each of the RGB values. 2*0.1 + 0.1 + 0.1/20 = 0.305, and it cancels out exactly. Not sure why they add it in the first place, but then again, the original algorithm is flawed in various places.

I see. In CAM16, they're adding +0.1 to each of the RGB values. 2*0.1 + 0.1 + 0.1/20 = 0.305, and it cancels out exactly. Not sure why they add it in the first place, but then again, the original algorithm is flawed in various places.

Ok. Thank you for the help. :) Much appreciated and thank you for your algorithm. It's about... 15-20% faster IIRC on my computer implemented in MATLAB

Ok. Thank you for the help. :) Much appreciated and thank you for your algorithm. It's about... 15-20% faster IIRC on my computer implemented in MATLAB


[Suggestion] Crafting skill calculator section - Add checkbox similar to bonuses for "Making your own molten glass"

Is your feature request related to a problem? Please describe.
After playing GIM for some weeks now, like the majority I have gone through the route of blowing glass to raise my crafting level but I noticed that I would always have to do my own calculation regardless because the skill calculator does not take into consideration if you were to create your own molten glass.
Describe the solution you'd like
I believe there should be a toggleable button titled "Crafting own Molten Glass" that will simply add the 20xp on top of the xp of making the respective glass blowing item and then from there the needed xp can be divided by the new total. This way players could gather the respective supplies needed properly.
Ex: If you need 1000 xp  for the next level and decide to make Unpowered orbs which is 52.5 xp and you're also planning on making your own molten glass it would be  Math.ceil(1000 / (52.5 + 20)) and the Calculator would show "14 Actions" as opposed to the "20 Actions" it would of been.
Describe alternatives you've considered
At higher levels the majority of people making their own glass would most likely use the superglass make spell which would also be an interesting thing to add as its own item on the crafting skill calculator or as a toggle since you get 10 xp per bucket of sand used. The only issue is you wouldn't end up with exactly the same amount of molten glass needed due to the fact its an average of 1.6 molten glass per bucket of sand not a specific number. Another issue would also taking into consideration if people use regular or giant seaweed and the amount of seaweed they use per cast.

You can select multiple actions by holding shift. Doing so causes the action info to display:

2 actions selected
72.5 exp - 14 actions

There's not really any good way to handle superglass make, however

You can select multiple actions by holding shift.  Sorry about that. This would obviously be suffice.


Audit mode with default true

What does this PR change?

Kubernetes REST client settings are set to Queries per second of 20 and Burst of 10. This is still low to avoid log message having Kubernetes request.go warning about waiting to get the kubernetes object.

Does this PR rely on any other PRs?
None
How does this PR impact users?
Default will be audit mode, unless it set to false the Disk auto scaling wouldnt perform any scaling up and scaling down operations
Links to Issues or tickets this PR addresses or fixes
closes #4

What risks are associated with merging this PR? What is required to fully test this PR?
The audit mode is a safe option as default so its better for user
How was this PR tested?
When run in audit mode logs will look like below
2024-05-16T22:44:17Z INF Namespace: steven, Deployment: steven-prometheus-server, PVC: steven-prometheus-server, PV: pvc-8fb7e7f6-83ef-444a-b337-0c6698cc9f90, Target Utilization: 70%, current size is: 32Gi, recommended size is: 1Gi, and expected monthly savings is: $3.10
2024-05-16T22:44:17Z INF Namespace: thanos, Deployment: thanos-compactor, PVC: thanos-compactor, PV: pvc-5f174e0f-8245-4023-880e-d44383ba4c2a, Target Utilization: 70%, current size is: 8Gi, recommended size is: 1Gi, and expected monthly savings is: $0.70
2024-05-16T22:44:19Z INF Namespace: disk-scaler-demo, Deployment: ubuntu-deployment-scale-up, PVC: scale-up-pvc, PV: pvc-bd21b08e-7f68-4798-b1db-16577a5d9772, Target Utilization: 70%, current size is: 6Gi, recommended size is: 6Gi, and expected monthly savings is: $-0.08
2024-05-16T22:44:19Z INF Namespace: thomasn-guardduty-tmp, Deployment: thomasn-guardduty-tmp-cost-analyzer, PVC: thomasn-guardduty-tmp-cost-analyzer, PV: pvc-589ada18-bd52-41e6-a768-a2da2e12e67d, Target Utilization: 70%, current size is: 32Gi, recommended size is: 2Gi, and expected monthly savings is: $3.00
2024-05-16T22:44:20Z INF Namespace: thomasn-guardduty-tmp, Deployment: thomasn-guardduty-tmp-prometheus-server, PVC: thomasn-guardduty-tmp-prometheus-server, PV: pvc-7f3bde56-5ad0-43bb-b7a7-61e6878200d9, Target Utilization: 70%, current size is: 32Gi, recommended size is: 1Gi, and expected monthly savings is: $3.10
2024-05-16T22:44:21Z INF Namespace: ecr-test, Deployment: ecr-test-cost-analyzer, PVC: ecr-test-cost-analyzer, PV: pvc-cfa8a9c3-88e6-4bbc-8511-9bdeb5e89141, Target Utilization: 70%, current size is: 32Gi, recommended size is: 1Gi, and expected monthly savings is: $3.10
2024-05-16T22:44:21Z INF Namespace: thomasn-nightly-dev, Deployment: thomasn-nightly-dev-cost-analyzer, PVC: thomasn-nightly-dev-cost-analyzer, PV: pvc-691a99a8-ad61-4432-b125-fd136e8de168, Target Utilization: 70%, current size is: 32Gi, recommended size is: 2Gi, and expected monthly savings is: $3.00

Without audit mode tested for scale up and scale down operation

Can you please copy that logged output in audit mode as a code block, not screenshot? We should add this to the README.

Done

@avrodrigues5 please review latest README changes.

Really cool! Just a future idea, could be nice to show % savings and maybe even a total expected savings amount.


Collect UT warnings (with FIXME) and do not account these tests as passed

Some tests have been modified (reduced scope, increased tolerance, etc) and currently they are passing, but they generate warnings, which can be parsed. Such test should not be accounted as passed in the pass rate dashboard. It is reasonable to keep these modified tests with warnings in CI (instead skipping them completely) to avoid regressions.

Related to #471.

@pbchekin can we close this ticket?


Configuration management slides for Winter 2016

lgtm +1

@ElijahCaine I'm not a collaborator on this repo, so you'll have to merge it (or give me access :stuck_out_tongue_winking_eye: )


Opening context menu from the exception filter input box hides the input

Also can't right-click to get a context menu either, since the input will disappear.

Re-titling as the cut/copy/paste issue was cause by something else (a window restart fixed it).

This works for me.
What OS are you using? This might be due to custom menus if you are on Windows. Probably the custom menu steals focus.
Can you reproduce with explorer input box?

Yeah, I'm on Windows with custom menus.

This is happening for all input boxes on Windows. Including ports view, explorer, breakpoints, variables view...
No plans to fix atm

@isidorn the input boxes experiencing this issue can adopt the shadowDom api for opening context menus as children of the input boxes which should address this problem though will need to be tested to ensure other issues are not introduced.


Update README.md

For go1.13 and beyond we next to explicitly disable go modules since it will be enabled for all go commands

lgtm


Update doc/generated_code.md

It might be worth looking into updating this automatically.

Yeah, might be worth it, but I'd fear to hit https://xkcd.com/1205/. More time spent on the automation than time saved. Especially if the automation breaks / requires maintenance.

If this were to be added to the code generator, it could end up being wrong
Parsing the generated code to extract these sections might be non-trivial (but more doable than the previous option)
I don't have a third idea

Actually... I'll give this a try. This is not work, but instead I am doing this for fun and this could actually be fun...


[BUG] The artist main page is really broken when scrolling down

Whenever I go to an artist's main page it seems alright at first but when i scroll the banner image stays in place and it looks broken and janky

Im on the latest version of spicetify and spotify
Im not sure if this helps but i installed the theme from the spicetify marketplace

i think it is the issue with the spotify version can you try updating it should fix it
it is working on newer version

@MrMcNuggie is the problem fixed sir ?

without proper context i cannot provide a fix the issue was solved in another commit so am closing this issue sir  @MrMcNuggie


python3Packages.requests: remove unneded trustme dependency

This removes rust from the build closure

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.requests

Result of nixpkgs-review pr 162045 run on aarch64-darwin 1

1 package built:

python3Packages.requests


Factor variables are not correctly handled anymore

The reason why Pkgdown rendering failed lately is due to a bug probably introduced with issue #106 or earlier, and in particular the handling of factor variables as predictors. I think it has something to do with the code added here where variables subset?
This reprex here fails regardless of engine (glm, xgboost, etc) now, resulting in several vignettes to fail to render...
library(terra)
# Background layer
background <- terra::rast(system.file("extdata/europegrid_50km.tif",package = "ibis.iSDM", mustWork = TRUE))
# Load virtual species points
virtual_species <- sf::st_read(system.file("extdata/input_data.gpkg",package = "ibis.iSDM", mustWork = TRUE), "points")
# Predictors
predictors <- terra::rast(list.files(system.file("extdata/predictors/", package = "ibis.iSDM", mustWork = TRUE), "*.tif",full.names = TRUE))
predictors <- subset(predictors, c("bio01_mean_50km","bio03_mean_50km","bio19_mean_50km",
                                   "CLC3_112_mean_50km","CLC3_132_mean_50km",
                                   "CLC3_211_mean_50km","CLC3_312_mean_50km",
                                   "elevation_mean_50km",
                                   "koeppen_50km"))
# One of them (Köppen) is a factor, we will now convert this to a true factor variable
predictors$koeppen_50km <- terra::as.factor(predictors$koeppen_50km)

# Create a distribution modelling pipeline
x <- distribution(background) |>
  add_biodiversity_poipo(virtual_species, field_occurrence = 'Observed', name = 'Virtual points') |>
  add_predictors(predictors, transform = 'scale', derivates = "none") |>
  engine_glm()

# Now train
mod_null <- train(x, runname = 'Normal PPM projection', only_linear = TRUE, verbose = FALSE)

It does work if factors are fully exploded, e.g. split up per factor level (add_predictors(..,explode_factors = TRUE). I will set this flag now by default in the vignette and hope that they render...

Interesting that all test etc. still run. But I will try to figure out what broke exactly to address this.

Yeah, the tests don't check for factor variables, only the vignettes do use them. In the vignette I added the explode_factors flag which makes them render. Merged dev with main branch recently.
Not quite sure why this is not working anymore (some engines always require split factors, but others won't)

This is really hard to debug since I cannot always re-produce the error. Sometime it runs locally (Code chunk Train models with spatial constrains), and sometimes it does not?!

I am working on this on a new branch (https://github.com/iiasa/ibis.iSDM/tree/factors) because its all a bit more puzzling than expected

https://github.com/iiasa/ibis.iSDM/commit/e42b25b09ebfae3dda85ce360dd704a402ec2ac5
https://github.com/iiasa/ibis.iSDM/commit/94da65b07be5e7118caa336755f04b81d54774f7

There were quite a few issues with factors, mainly:

Not more than one factor variables was possible for some engines.
Some penalty factors created did not match the present factor levels.
If exploded, original factor variables was not removed from predictor data.frame.
Improved documentation in add_predictors.

Should be all fixed (#128)

Will close for now. Please re-open if needed


Update dependencies

The grizzly server version should be updated. In the process, we should just update everything where possible.
### Non-major versions to bump
- [x] kotlin = "1.9.10" -> "1.9.22"
- [x] jersey = "3.1.3" -> "3.1.5"
- [x] grizzly = "4.0.0" -> "4.0.2"
- [x] okhttp = "4.11.0" -> "4.12.0"
- [x] junit = "5.10.0" -> "5.10.1"
- [x] mockitoKotlin = "5.1.0" -> "5.2.1"
- [x] hk2 = "3.0.4" -> "3.0.5"
- [x] jackson = "2.15.3" -> "2.16.1"
- [ ] slf4j = "2.0.9" -> ?
- [ ] log4j2 = "2.20.0" -> ?
- [x] jakartaJaxbCore = "4.0.3" -> "4.0.4"
- [x] jakartaJaxbRuntime = "4.0.3" -> "4.0.4"
- [x] swagger = "2.2.17" -> "2.2.20"
- [x] hibernate = "6.3.1.Final" -> "6.4.2.Final"
- [x] liquibase = "4.24.0" -> "4.25.1"
- [x] postgres = "42.6.0" -> "42.7.1"

@yatharthranjan I don't know where to find the packages that are updated by this function
    radarKotlin {
        javaVersion.set(Versions.java)
        kotlinVersion.set(Versions.kotlin)
        log4j2Version.set(Versions.log4j2)
        slf4jVersion.set(Versions.slf4j)
        junitVersion.set(Versions.junit)
    }

The junit, kotilin and java packages that are updated are self-explanatory but what are the exact packages updated by log4j2 and slf4j

You should be able to find those here -- https://github.com/RADAR-base/radar-commons/blob/master/radar-commons-gradle/src/main/kotlin/org/radarbase/gradle/plugin/RadarKotlinPlugin.kt


RPC doesn't clear once Roblox Studio closes

Unsure if this is an issue with Coyenn's fork or the main branch. Merged fork

thanks for the report i'm looking into it

fixed


multivalue variable gives value with curly brackets

I have a problem using variable when 'ALL' value is being used. Using MySQL in Update Request Payload variable gives value with curly brackets which generates error in request.
I have rather poor programming skills and can't solve this problem.
I know I can solve this by using reaping panels option but I want to avoid that.

@qczak We just merged PR, which replaced dashboard variables in the payload.
It's a part of the today's release.


Feat: Determine the packages installed in an environment

We need to determine what packages are installed into an environment, so that we can actually mark these as favored when using the solver.
When a certain directory is selected determine if and what package(s) is/are installed. Maybe take a look how pip/poetry are doing this.

It's more of an art than a science when you have a mixed pip/conda environment!

@shughes-uk it looks like conda packages of python packages have an INSTALLER file that contains conda. Do you know if this is always the case?

even if they don't, with rattler/mamba we could potentially force this, right? I think some really old packages might not have the right value.
The other option would be to compare with the entries of conda-meta (although pip might still have overwritten the contents of the site-packages folder after it was installed with conda).

Tips off the top of my head

The INSTALLER file is usually around, but usually missing from egg packages (lots of these on conda-forge)
Fetch hashes for package files that are listed in conda-meta, compare with the hash of actually "active" files, not sure there's a better way to figure out what's actually installed.
Multiple dist-info files for a one package is actually not uncommon, probably from people killing pip during an install or conda shenanigans
egg-link still pops up
.pth files pointing to editable installs can exist alongside the non-editable normal install, they just take precedence.
There's a few older versions of poetry that generate valid but bad direct_urls.json if you want to look at that, i forget the issue number where they fix it.

Uh oh, we don't deal with egg files as of now :D Are they really still around?! We also currently deal with source distributions, but that's kinda high up on the list as it seems very much required for a bunch of real-world resolves.
Thanks for your insights!

@tdejager should we close this issue and open new ones if we encounter problems?

@baszalmstra / @tdejager as far as I understand we do have code for this, right?

Yeah we do! We can close this. There are probably edge cases but lets file new reports for those.


Feature request - Native transport on ARM system

Is it planned to support native transport on ARM systems? Or is it somehow supported? I get the error
could not load a native library: netty_transport_native_epoll_arm_32

when calling
Epoll.unavailabilityCause().getMessage()

@konsultaner there is currently no plan to ship support for arm systems. That said you should be able to compile it by yourself on the system.

@normanmaurer I'll give it a try but gcc-multilib is not available on raspian. Do I have to have it?

@konsultaner keep up updated in case of success. You don't need raspian in order to compile native transport for ARM as far as I know. And gcc-multilib is used exactly for cross-compilation.

ARM has grabbed a lot of marketshare in the last few years, and is still growing. Is the plan still not to ship binaries for ARM?
If this hasn't happened yet, but the Netty project is interested in it, it's possible I can find funding for this effort.

@elharo we do cross compile for aarch64... I think this should be enough ?


Validation for multiple possible values or notValues

I was looking through the validators to see if there was an easy way to blacklist or whitelist a set of strings/numbers (all in one go). I see that .value and .notValue are there, but didn't see any ones that would allow for an array of items to check against.
I'm aware this could be done with a custom .check or .regex, but wondered if it was a common enough usecase where we might consider adding .values and .notValues?

On a related note, NaN doesn't play well with .value or .notValue...
This is more of a JS issue though, as NaN === NaN is always false. Dunno if its a scenario worth handling, but had me scratching my head for a moment. I'm just using v.check(i => !Number.isNaN(i), () => I18n.t('validation.notNumber')) instead.

Thanks for sharing that idea. Yes, we can add values and notValues. Instead of using values you may want to consider using picklist or literal with union first as it leads to a more precise TypeScript type.
Can you share your entire !NaN schema? v.number() already excludes NaN for you.

Can you share your entire !NaN schema? v.number() already excludes NaN for you.

This likely occurred for me because I'm also allowing string as a valid input and coercing to number. The intention here was to first conform every valid input to the expected type allowing them to share the same validation logic:
v.pipe(
  // Input
  v.union([
    // Expected (intended "input" type)
    v.number(),
    // Coerced (supported alternative "input" types)
    v.pipe(v.string(), v.trim(), v.transform(i => Number(i || NaN))),
  ]),
  // Validation
  // v.notValue(NaN, () => 'Not a Number'), // <--- couldn't use this
  v.check(i => !Number.isNaN(i), () => 'Not a Number'),
  v.integer(() => 'Not an Integer'),
  v.minValue(1, () => 'Too Small'),
  v.maxValue(65535, () => 'Too Large'),
);

The tricky thing with Number(string) is that an empty string evaluates to 0, so it makes more sense to force blank to NaN. I could instead force to null, but the number validations would then misbehave.
The bigger picture is that I was trying to recreate a Zod usage we had, where we needed "optional numbers", and I recalled it being a bit of a pain... Essentially, a form input (string) where the value should be coerced to a number, is within a range, but can also be optional (with no fallback). Here is an example:
import * as v from 'valibot';

/** Schemas */
const AsNumberSchema = v.union([
  // Expected (intended "input" type)
  v.number(),
  // Coerced (supported alternative "input" types)
  v.pipe(v.string(), v.trim(), v.transform(i => Number(i || NaN))),
]);

const AsUndefinedSchema = v.union([
  // Optional (coercing null as undefined)
  v.pipe(v.null(), v.transform(() => undefined)),
  v.undefined(),
]);

const PortSchema = v.pipe(
  // Supported Types
  AsNumberSchema,
  // Validation
  v.check(i => !Number.isNaN(i), () => 'Not a Number'),
  v.integer(() => 'Not an Integer'),
  v.minValue(1, () => 'Too Small'),
  v.maxValue(65535, () => 'Too Large'),
);

const ConfigurationSchema = v.object({
  port: v.union([ PortSchema, AsUndefinedSchema ]),
});

/** Types */
type ConfigurationSchema = v.InferOutput<typeof ConfigurationSchema>;

/** Debug */
const result = v.safeParse(ConfigurationSchema, { port: undefined }, { abortPipeEarly: true });
console.log(result);

There might be a better (more repeatable) approach to this, as I would also need to do similar string/undefined support for booleans (who don't have an "invalid" state to work with). So maybe using null could make more sense, but I'd need to find a way to restructure it to bypass these validations.
Alternatively, perhaps the better option is to just create a separate dedicated Form/UserInput version of the schemas (that always assumes a string as input) rather than one that caters for everything. I was just trying to avoid repetition, but potentially separating out these concerns makes more sense.

Instead of using values you may want to consider using picklist or literal with union first as it leads to a more precise TypeScript type.

With the above in mind, the scenario I was curious about, was if I needed to exclude a set of reserved ports from those available. If it was always a non-contiguous list then something like .notValues([], ...) would have been handy, but in this case its more likey to be a collection of ranges, so a custom .check probably makes more sense anyways. It just occurred to me that a whitelist/blacklist validation could be handy in other situations.

Yes, let's keep this open. Maybe someone in the community will implement it, or I will do it at a later date.

@fabian-hiller I'll work on adding values and notValues actions.