Kendra Web Crawler documents not showing in QnABot Designer

Describe the bug
When I use Kendra Web Crawler "Start Crawling" button after some time it says successfully, that the crawling status is "COMPLETE" and there is number of documents added. But after finishing web crawling I can't see questions generated by Kendra in Edit Questions tab.
My configuration is:
ENABLE_KENDRA_WEB_INDEXER: true
KENDRA_INDEXER_URLS: https://docs.aws.amazon.com/ (example)
KENDRA_INDEXER_SCHEDULE: rate(1 day)
KENDRA_INDEXER_CRAWL_DEPTH: 4
KENDRA_INDEXER_CRAWL_MODE: SUBDOMAINS
KENDRA_WEB_PAGE_INDEX: f0459633---****-44fb11faaa6f

Here you have the effect of my recent crawling. Previous ones are my experimentations - don't look at that.
Expected behavior
Kendra documents visible in Edit Questions tab. Possibility to test crawled documents in Test panel.
Please complete the following information about the solution:

[X] QnABot Version: 5.2.5

[X] Region: us-east-1

[X] Have you checked your service quotas for the sevices this solution uses?

[] Were there any errors in the CloudWatch Logs? No

Additional context
I searched through all Kendra, QnABot documentations and didn't found any information about how to use crawled documents. I don't know how this should work. Can anyone help me? Thank you.

Hello, coming back to this thread after some time. The issue still persists.
After successful web crawling(in this example some Discord FAQ website):

In Kendra, I can see the documents added by the web crawler which is good. But if I use any question from given documents in Alexa Skill, for example:

It returns error response:

Logs from fulfillment Lambda:
2023-04-06T12:17:41.759Z	0255ff2e-13e4-4ec4-9937-b535cddb30d5	INFO	kendra query request:  {     "kendra_faq_index": "e2a9cc66-13c4-43f6-a003-eb025b6b446b",     "maxRetries": 8,     "retryDelay": 600,     "minimum_score": "HIGH",     "size": 1,     "question": "what is vid con",     "es_address": "search-qnabot-elasti-1jc9qzq3hhe6t-gz2ovqjifwlzcyotxrzspjujgy.us-east-1.es.amazonaws.com",     "es_path": "/qnabot-website-crawler/_doc/_search?search_type=dfs_query_then_fetch",     "same_index": true }
2023-04-06T12:17:41.864Z	0255ff2e-13e4-4ec4-9937-b535cddb30d5	INFO	 {     "message": "Index Id e2a9cc66-13c4-43f6-a003-eb025b6b446b not found for Customer Id<PHONE_NUMBER>03.",     "code": "ResourceNotFoundException",     "time": "2023-04-06T12:17:41.863Z",     "requestId": "639b3450-2f06-4125-94c2-a2b6f663c48e",     "statusCode": 400,     "retryable": false,     "retryDelay":<PHONE_NUMBER>64807 }
2023-04-06T12:17:41.865Z	0255ff2e-13e4-4ec4-9937-b535cddb30d5	ERROR	Invoke Error 	 {     "errorType": "Error",     "errorMessage": "Error from Kendra query request:ResourceNotFoundException: Index Id e2a9cc66-13c4-43f6-a003-eb025b6b446b not found for Customer Id<PHONE_NUMBER>03.",     "stack": [         "Error: Error from Kendra query request:ResourceNotFoundException: Index Id e2a9cc66-13c4-43f6-a003-eb025b6b446b not found for Customer Id<PHONE_NUMBER>03.",         "    at intoError (file:///var/runtime/index.mjs:46:16)",         "    at postError (file:///var/runtime/index.mjs:707:51)",         "    at callback (file:///var/runtime/index.mjs:723:11)",         "    at file:///var/runtime/index.mjs:778:20",         "    at router.start (/var/task/lib/router/index.js:24:17)",         "    at processTicksAndRejections (node:internal/process/task_queues:96:5)"     ] }
I'm curious about that Customer ID error. Can you confirm if its Kendra related or QnABot-related error?
Thank you in advance for any help.

Hey @maxsiopl, I see the following:
"message": "Index Id e2a9cc66-13c4-43f6-a003-eb025b6b446b not found for Customer Id<PHONE_NUMBER>03."
Does the Kendra index you have set for kendra_faq_index exist in your account?
I believe the FAQ_INDEX setting is used for pointing to an index where QnABot can upload your question bank into the Kendra index (to provide semantic search capabilities instead of keyword based search). It is not intended for use as a fallback. So if the index does exist, and you have never synced your question bank into the index (see screenshot), then the FAQ will be empty and may be responsible for this error.

If you want to use the kendra fallback you need to use ALT_SEARCH_KENDRA_INDEXES.
But this are all just guesses. Can you let me know what your Kendra settings are (redact private info of course!)? Also, please give me a short description of what you are trying to do and I may be able to provide some general tips (for example I now see Alexa Skill involved, very cool!)

Okay, so when KENDRA_FAQ_INDEX is set and I try to SYNC KENDRA FAQ after some time it returns just error:

But in CloudWatch Lambda logs we got:

2023-04-10T15:02:51.322Z	993ab2e0-5d5d-4d77-a0c6-8a420c9d64b6	INFO	describeFaq
{
"Id": "4f4a7474-3d1a-412e-9ece-6eecbad0a6df",
"IndexId": "bfd4157b-83e6-4d5b-87c3-cf2757beeee7",
"Name": "qna-facts",
"Description": "Exported FAQ of questions from QnABot designer console",
"CreatedAt": "2023-04-10T15:01:15.067Z",
"UpdatedAt": "2023-04-10T15:02:46.769Z",
"S3Path": {
"Bucket": "qnabot-website-crawler-exportbucket-3l52jl0qjoh6",
"Key": "kendra_json/qna_FAQ.json"
},
"Status": "FAILED",
"RoleArn": "arn:aws:iam::003994647303:role/QnABot-Website-Crawler-ExportStack-1F-KendraS3Role-1BGJRE7D5SM68",
"ErrorMessage": "The FaqDocuments list in the specified JSON file is null or empty. You must specify a list. Make sure that you have a list of FAQ documents and try your request again.",
"FileFormat": "JSON"
}

Here is my QnABot config(Export config function only returns json with settings other than default, but I wanted to include all settings):

Basically the goal of this QnABot would be to scan FAQ website (in this example Discord FAQ) and redirect those faqs to Alexa Skill. Is this possible with QnABot Web Crawler? Can you explain what I am doing wrong? :) Also, in this scenario how should I use Kendra Fallback?
Again thanks for help!

Thanks for the settings, that helps. It seems my last comment was more confusing than it was helpful. Let me try to be more clear (I just setup a test using v5.3.1 and asked "What is Vidcon" through alexa and it provided the right response).

Clear KENDRA_FAQ_INDEX setting. From what I can tell, you are not using that feature so it is causing errors when trying to search for responses (it looks like you are not using Kendra FAQ, you are using a Kendra Data source)

You are using 2 different Kendra indexes. KENDRA_WEB_PAGE_INDEX is the index where web crawled documents will be stored. ALT_SEARCH_KENDRA_INDEXES is where QnABot will search for responses. So you need to include the KENDRA_WEB_PAGE_INDEX into the ALT_SEARCH_KENDRA_INDEXES. See here

Give that a try and let see how it goes.

After performing these 2 tasks you proposed now everything works just fine! Thank you a lot!
I guess it is worth mentioning in Kendra Web Crawler readme about where to fill specific Kendra indexes just to be clear :)
Thank you again!

Thanks for the feedback, I'll have a look at that section of the documentation to see how we can make it more clear.
Glad it all worked out, best of luck! And don't forget to upgrade and test on the latest version while running your initial prototype!


Add support for subject alternative name

Fix #4

Fixed

Other than that, it's great, thanks :) !


Test stable peek and peek resize

tests #5120

[ ] any os - @waderyan
[ ] OS X - @joaomoreno

The peek window go improved for code in the peek window-scenarios. Test that

you can resize peek windows, for find references and peek definition in height and when the tree shows also vertically
the size adjustments are persisted
there is a new setting stablePeek which  when enabled doesn't close the peek window on Esc or when double clicking the content
let me know if don't like the name of the setting stablePeek

Wow!

Not super comfortable with the setting name, but I lack a better suggestion.

@kieferrm please close item after setting last checkbox.


radiotray-ng: 0.2.3 -> 0.2.4

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: radiotray-ng
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: radiotray-ng
Partial log (click to expand)
Wrapping program /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4/bin/radiotray-ng
shrinking RPATHs of ELF executables and libraries in /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4
shrinking /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4/bin/.radiotray-ng-wrapped
shrinking /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4/bin/.rtng-bookmark-editor-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4/bin
patching script interpreter paths in /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4
/nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4/bin/..rt2rtng-wrapped-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/74b1xd5srd6ja54xwznvbrd5hcfl6k1n-python-2.7.15/bin/python2.7"
checking for references to /build in /nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4...
/nix/store/vz6kijjyhbqgklg9fnhbasd1mz3z4rb1-radiotray-ng-0.2.4

Success on x86_64-linux (full log)
Attempted: radiotray-ng
Partial log (click to expand)
Wrapping program /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4/bin/rtng-bookmark-editor
shrinking RPATHs of ELF executables and libraries in /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4
shrinking /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4/bin/.radiotray-ng-wrapped
shrinking /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4/bin/.rtng-bookmark-editor-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4/bin
patching script interpreter paths in /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4
/nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4/bin/..rt2rtng-wrapped-wrapped: interpreter directive changed from "/usr/bin/env python2.7" to "/nix/store/2brlr94ahy3a9mvcjy0qbqpv8zrb7b7s-python-2.7.15/bin/python2.7"
checking for references to /build in /nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4...
/nix/store/siknnib3fqy9vdms8jnrnq5f74xw1sv0-radiotray-ng-0.2.4


Update use of Collections API to receive a collection UUID instead of a Collection Slug

On 14 May we met and adjusted some details on the info the Collections API will deliver to CoherenceBot.  It will now send a UUID instead of a slug.  Adjust the CB code to accept the new value and use it in the  naming of exported JSON.

This is done.  See: https://github.com/coherentdigital/coherencebot/commit/61f260e3e39b7b43bf4f4a8aabc90c67d555bedb


phrase correction needed

We didn't store a secret in this quickstart but the page states otherwise.

CLI page shows correct phrase

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 930afeda-ea55-4e46-6dd0-25da38eae788
Version Independent ID: 2c4f9d1a-92db-d480-c690-960f72602f60
Content: Quickstart - Create an Azure Key Vault with the Azure portal
Content Source: articles/key-vault/general/quick-create-portal.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

duplicate

@DebashishSarkar

@msmbaldwin can you look into it?

Thanks! Looks like someone created a pull request to fix this. https://github.com/MicrosoftDocs/azure-docs/issues/67242


Remove dead code

@yashykt

LGTM. Last touched in 2016, and probably unused. The Makefile still mentions systemtap, is any of that still relevant?

It's probably not


(maint) Sort ci:test:quick tests

Sort ci:test:quick tests in lexicographical order.
$ bundle exec rake ci:test:quick
...
    "tests": [
        "tests/direct_puppet/cached_catalog_remediate_local_drift.rb",
        "tests/environment/environment_scenario-default.rb",
        "tests/face/loadable_from_modules.rb",
        "tests/language/functions_in_puppet_language.rb",
        "tests/lookup/hiera3_custom_backend.rb",
        "tests/modules/install/basic_install.rb",
        "tests/node/check_woy_cache_works.rb",
        "tests/parser_functions/calling_all_functions.rb",
        "tests/pluginsync/4420_pluginfacts_should_be_resolvable_on_agent.rb",
        "tests/puppet_apply_basics.rb",
        "tests/resource/file/content_attribute.rb",
        "tests/resource/package/yum.rb",
        "tests/resource/service/puppet_mcollective_service_management.rb",
        "tests/resource/service/ticket_5024_systemd_enabling_masked_service.rb",
        "tests/ssl/puppet_cert_generate_and_autosign.rb",
        "tests/ticket_4622_filebucket_diff_test.rb",
        "tests/utf8/utf8-in-function-args.rb",
        "tests/zzzz_configuration_interpolation.rb"
    ],
    "xml": true,
    "forge_host": "forge-aio01-petest.puppetlabs.com",
    "is_puppetserver": true,
    "use-service": true,
    "puppetservice": "puppetserver",
    "puppetserver-confdir": "/etc/puppetlabs/puppetserver/conf.d",
    "pre_suite": [
        "setup/common/pre-suite/000-delete-puppet-when-none.rb",
        "setup/aio/pre-suite/010_Install.rb",
        "setup/aio/pre-suite/020_InstallCumulusModules.rb",
        "setup/aio/pre-suite/021_InstallAristaModule.rb",
        "setup/common/pre-suite/025_StopFirewall.rb",
        "setup/common/pre-suite/040_ValidateSignCert.rb",
        "setup/aio/pre-suite/045_EnsureMasterStarted.rb"
    ],
    "hosts_file": "/Users/josh/work/puppet/acceptance/hosts.yaml",
    "command_line": "/Users/josh/work/puppet/acceptance/.bundle/ruby/2.2.0/bin/beaker --options-file merged_options.rb --hosts=hosts.yaml --tests=tests/direct_puppet/cached_catalog_remediate_local_drift.rb,tests/environment/environment_scenario-default.rb,tests/face/loadable_from_modules.rb,tests/language/functions_in_puppet_language.rb,tests/lookup/hiera3_custom_backend.rb,tests/modules/install/basic_install.rb,tests/node/check_woy_cache_works.rb,tests/parser_functions/calling_all_functions.rb,tests/pluginsync/4420_pluginfacts_should_be_resolvable_on_agent.rb,tests/puppet_apply_basics.rb,tests/resource/file/content_attribute.rb,tests/resource/package/yum.rb,tests/resource/service/puppet_mcollective_service_management.rb,tests/resource/service/ticket_5024_systemd_enabling_masked_service.rb,tests/ssl/puppet_cert_generate_and_autosign.rb,tests/ticket_4622_filebucket_diff_test.rb,tests/utf8/utf8-in-function-args.rb,tests/zzzz_configuration_interpolation.rb",
...

/cc @branan @McdonaldSeanp

👍

CLA signed by all contributors.

Do we want this on the LTS too? Seems weird to change the test ordering on only some of the branches...

@Magisus I think we can actually close this, as we resolved the underlying issue that caused us to try this. /cc @joshcooper

I was thinking sorting the tests would ensure a more consistent test environment, so we don't get random order-dependent test failures when running ci:test:quick, but not when running ci:test:aio. Agree about targeting for LTS-1.7, that would be weird to get different behavior across branches.

I agree that this is useful even without a known ordering issue, and with the LTS re-target.

I'm with Josh on this one too.

k, let me close this out and open a new PR targeted at LTS-1.7


Templated CUDA Kernel

This PR includes templated CUDA code to (hopefully) allow NVCC to better optimise compute, compute_with_gradients and compute_with_hessians.

PR failing mostly because stubs aren't functional yet.


[Docs] PackageRepository installation removes Packages defined namespace

There's no clear documentation that defined the behavior of kapp-controller when reconciling packages and packagemetadatas from a PackageRepository as it removes the defined namespace from those resources so that they are applied in the same namespace as the packagerepository.
k8s Slack conversation that triggers this issue with all the context: https://kubernetes.slack.com/archives/C02GY94A8KT/p1634834194017300

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Reopening this issue as it hasn't been addressed and is still applicable.
Thank you for submitting this issue. Looks like we might be gathering a few docs stories to justify dedicating some focused time on docs improvements. In the meantime, contributions are always welcome! (doc to improve: https://github.com/vmware-tanzu/carvel/blob/develop/site/content/kapp-controller/docs/latest/package-consumer-concepts.md)


Fix MSS status retrieval

dict path was wrong

coverage: 33.016%. remained the same
when pulling ad1414676c1f046f8979df31603a725ae134f0f4 on ginger/mss-status
into e1c88385d3c8d261b00818fed28936e68d6e14bf on patch.


Structure the images in the products description bar in the home page

Describe the feature
Equalize the size of images in the products description bar in the home page
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@arghadipmanna101 Pls assign labels under GSSOC 24 guidelines


T83426: Blender GLTF Exporter - Missing texture filtering

See https://developer.blender.org/T83426
Broken: version: 2.91.0
Worked: 2.90.1

https://github.com/KhronosGroup/glTF-Blender-IO/blob/5c0bc25d44d13eaf3e901e801c9a1642ada80423/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_sampler.py#L79
This is probably supposed to be LinearMipmapNearest (do linear filtering with the nearest mipmap), not NearestMipmapLinear (do nearest filtering with the two closest mipmaps, then average them).
It could also be LinearMipmapLinear.

Changed line 79 as suggested by scurest and it's better now. But something is still missing/wrong please see attatched picture. "2.92.0_mod" is exportet from Blender with line 79 changed to "LinearMipmapNearest".

Try LinearMipmapLinear.

"79    return TextureFilter.LinearMipmapLinear" did the job :)

To explain what happens: Linear has been (incorrectly) exported as NearestMipmapLinear since at least 2.81, but before 2.91 the sampler would be omitted for textures that are Linear/Repeat in Blender. When the sampler is omitted, the viewer picks the filtering on its own. This was changed to fix #307 (texture was Linear in Blender, but sampler was omitted, and a viewer could pick nearest filter); the sampler is now never omitted. That means the viewer is no longer picking the filter to use itself, it's using the one specified in the .gltf file.

@f3lix-s Ah, thanks.

Here is what it looks like in Blender

So yeah, LinearMipmapLinear looks like it's closest, let's do that.

Thank you for your solution and explanations! I am quite new in coding and new in Blender as well.
Coming from Cinema 4D with the aim for three.js ...
And this was my first reported bug ever, what an exiting day ;)

@f3lix-s Nice work finding this :)
I opened #1286.


Mousewheel Fast scrolling in firefox

Scroll amount is much smaller in Firefox then in other browsers. Is this plugin restricting scroll amount in some way, and if not, maybe implementing this code inside, could help.
http://keithclark.co.uk/articles/faster-scrolling-parallax-websites-in-firefox/

sorry, it was not the problem in this library.


availability of FOSS APK

Would you consider making a F/LOSS APK available (e.g. by tagging releases and attaching it there) for those without PlayStore access, ideally without the two analytics trackers (Crashlytics, Firebase Analytics)? Thanks in advance!

any cance, @nirajprakash ?

@IzzySoft, working on it. I'll update you soon.

Thanks a lot – looking forward to that :star_struck:

@IzzySoft, added one release,
https://github.com/JunkieLabs/sensify-android/releases/

Thanks a lot! But app-release-unsigned-signed.apk suggests the APK is, hm, unsigned? That means the "end user" is lost as it doesn't install this way. Would you mind attaching a signed APK instead?

Thanks a lot! The unsigned got me confused initially, the APK is indeed signed. BUT:
Offending libs:
---------------
* Crashlytics (/com/crashlytics): NonFreeDep,Tracking
* Google Ads (/com/google/ads): Ads,NonFreeDep
* Firebase Data Transport (/com/google/android/datatransport): NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeDep
* Firebase (/com/google/firebase): NonFreeNet,NonFreeDep
* Firebase Analytics (/com/google/firebase/analytics): NonFreeDep,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

7 offenders.

is not really FOSS (5 of these libs are non-free, the other 2 at least use non-free network services). Not sure why any of them would be needed to visualize sensors. Maybe you could establish a "foss build flavor" having the offenders removed?

Crashlytics is used for crash checks. And analytics for the understanding of app usage to publish new updates. Those are not used for visualization.
Can you tell me specifically, where you want to use this app?

Sure I can. I want to make it available and easy to discover/update in the FOSS world and, for "privacy-aware", outside of Google's walled garden – where it (due to the non-free components) cannot enter e.g. F-Droid.org. For that purpose (apps which are per-se FOSS but somehow cannot enter F-Droid.org) I run a well-known third-party F-Droid repo (in fact the largest one after F-Droid.org itself) at https://apt.izzysoft.de/fdroid (currently covering more than 1k apps) and would like to add your app there. While my inclusion criteria are a bit more lenient than those at F-Droid.org, there are still some limits: I can close an eye or two, but I do not have 7 eyes :see_no_evil:
So a FOSS flavor would be highly appreciated. Considering that probably more than 95% of your users will still install the app from Play Store, the loss of analytics wouldn't really hurt. If you'd still want some, be welcome to take a look at alternatives I collected – and btw, there are also some for Firebase itself, like appwrite and Supabase, just mentioned above the linked section. For crash reporting, a good choice would e.g. be ACRA with only its crash reporter configured to ask the user sending the details by mail (presenting the details and offering a button to open with their mail app for sending). Us privacy folks love transparency, so we want to see what we send :wink: For other analytics, e.g. a (self-hosted) Sentry.io (configured opt-in, i.e. first getting the user's consent before enabling it) should be fine. I guess the remaining libraries are just dragged in as dependencies – so the list would probably be cleared after replacing Crashlytics and Firebase Analytics, unless you use Firebase directly for other purposes.
While the "easiest" way would probably be replacing these in general, it could also be done using "build flavors" (e.g. one with Crashlytics/Firebase Analytics to ship to Google Play, and one using ACRA/Sentry for the "privacy folks").
Thanks for considering – and thanks in advance should you implement this :star_struck:

For this one, I will add a different flavor.

@IzzySoft, check this one.. https://github.com/JunkieLabs/sensify-android/releases/tag/Sensify_FOSS_2023.03.05_02-07
I removed google plugins.

Thanks – that looks perfect! All "offenders" are gone! :partying_face:
Adding it now to my repo. I see you're using a different tag for the FOSS release. Could the name of that tag maybe reflect the versionName, like being v3.0.12-foss? That would make it easier for my updater to detect new releases (without downloading and checking the file each time). For now I've restricted it to only consider tag names matching the regular expression /Sensify_FOSS_.+/ which should work but would still rely on one more check (alleged timestamp of the file), which in the past sometimes failed and I still have no idea why – maybe timezone stuff).
That said, your app should show up here around 7 pm UTC (with the next sync). If you like what you see, be welcome to pick a badge to link there from e.g. your Readme. And if you want to stay in control how your app is presented here, I gladly open a PR sending you the metadata I've set up in Fastlane format (see my Fastlane Cheat Sheet for details on how to build on that, e.g. adding per-release changelogs or support other locales).
Thanks a lot for your app, and especially for providing the FOSS build! :star_struck:

I will try to link the app's version with the GitHub action.
For now, I have used this format for release tags:
Sensify_FOSS_$(date +"%Y.%m.%d_%H-%M").

That's what I try to match on currently (and hope it works). Ideally I can match on something containing either versionName (using semantic versioning) or versionCode. For both I can clearly say what's already available in my repo and whether the latest tag should be an update (tag > version) or not without having to dig deeper (check file dates etc).
We can of course first see if it works as-is (it should); if the other means too much trouble for you, we certainly can do with what we have now. Most important is you have some indicator (like currently FOSS) in the tag name (or file name) so I do not accidentally pick the wrong APK :smile:

@nirajprakash I see you've just closed this, but there was no new release yet. Sure it works without adjustments? I thought we first wanted to verify.


Roll back topLevelSelector so Reaper can process datasets

See #373

Not necessary as reposting datasets solved our issue.


Feature Request: File naming

Going along the same lines as the youtube-dl output format it would make sense to enable some file renaming.
This would enable more organized archiving, e.g. by automatically putting episodes in named podcast folders. Assuming other metadata could be extracted it would be nice to put the release date and duration in the filename among other things.
youtube-dl uses something like  -o '%(podcast_name)s/%(release_date)s - %(title)s.%(ext)s

This would be a great add. I like the keyword approach and if built correctly would be easy to extend with more keyword options.
I imagine I'll some time for this in the next few weeks. 👍

Added a simple version of this in the latest release with --episode-template. I think extending --out-dir to handle folder creation or using the podcast name automatically will be the likely path for better folder options.

--out-dir now supports basic templating options as well and will generate the folder if it doesn't exist. 👍


Missing comma from 'Example Configuration'

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to page 'https://nuxt-speedkit.grabarzundpartner.dev/setup'
Copy paste the Example Configuration content in a nuxt.config.js
before the property 'componentAutoImport' there's a missing comma

Expected behavior
The configs should be copy-pastable with no error.
Screenshots

Thanks! :)


Refactor yaml parser to use rapidyaml

Drop yaml-cpp library in favor of rapidyaml. The conversion was a PITA, but this change will make everything faster cleaner and more robust for the future.
TODO:

[ ] Convert core/robot.cpp remaining functions. Reenable later, will add issue
[x] Convert core/dataset_filter.cpp remaining functions
[x] Keep Tree instead of NodeRef in some places
[x] Keep buffer chars + Tree and use parse_in_place instead ? YES
[x] Convert mtc package
[x] Test

Benchmarks
So far so good! I suspect that using a variant for the metrics slows down decoding by a good factor...

Encode (sec)
Write (sec)
Read (sec)
Parse (sec)
Decode (sec)

Collision BM (78 MB)
1.11
1.61
0.0346
1.37
2.42

Here goes nothing !


[WFCORE-6286] Document the purpose of the wildflyee.api module in its…

… module.xml, and mark it as private
https://issues.redhat.com/browse/WFCORE-6286

Thanks @bstansberry


MultiAuth Laravel 5.1 (kbwebs/multiauth)

How we can use kbwebs/multiauth with dingo api? We must use it with Internal Requests and API Authentification. Other Issues have not solved my problem.

Why do you need multiauth? What's your issue?


Sniper specialist

Done in https://github.com/CM-14/CM-14/commit/1f7b0449240b94b711833f6851af42d34c39de51, still needs the night goggles, backpack, vp78, facepaint and spotter


[SPARK-14269][SCHEDULER] Eliminate unnecessary submitStage() call.

What changes were proposed in this pull request?
Currently a method submitStage() for waiting stages is called on every iteration of the event loop in DAGScheduler to submit all waiting stages, but most of them are not necessary because they are not related to Stage status.
The case we should try to submit waiting stages is only when their parent stages are successfully completed.
This elimination can improve DAGScheduler performance.
How was this patch tested?
Added some checks and other existing tests, and our projects.
We have a project bottle-necked by DAGScheduler, having about 2000 stages.
Before this patch the almost all execution time in Driver process was spent to process submitStage() of dag-scheduler-event-loop thread but after this patch the performance was improved as follows:

total execution time
dag-scheduler-event-loop thread time
submitStage()

Before
760 sec
710 sec
667 sec

After
440 sec
14 sec
10 sec

This PR is based on #11720, so please check it first.

Test build #54509 has started for PR 12060 at commit a304235.

Test build #54509 has finished for PR 12060 at commit a304235.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54509/
Test PASSed.

Seems that this optimization must need correct stage graphs fixed in #11720, is this right?

Yes, that's right.
#11720 is needed to find child stages correctly.

If so, it'd be better to close #11720; the benefit of correct stage graphs fixed in #11720 seems to be clear in this pr.

Test build #54582 has started for PR 12060 at commit f1407c0.

@maropu I see. I'll close #11720.

Test build #54582 has finished for PR 12060 at commit f1407c0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54582/
Test FAILed.

Jenkins, retest this please.

Test build #54595 has started for PR 12060 at commit f1407c0.

Test build #54595 has finished for PR 12060 at commit f1407c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54595/
Test PASSed.

This pr seems great in terms of spark-core performance, so could you assign qualified guys to review this? cc: @rxin

Test build #54940 has started for PR 12060 at commit b0511f7.

Test build #54940 has finished for PR 12060 at commit b0511f7.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54940/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #54951 has started for PR 12060 at commit b0511f7.

Test build #54951 has finished for PR 12060 at commit b0511f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54951/
Test PASSed.

Merged build finished. Test PASSed.

cc @kayousterhout the scheduler czar.

I'll look at this sometime in the next 48 hours.

In theory this seems like a good idea: there do seem to be lots of unnecessary calls to submitWaitingStages(), and those calls seem somewhat expensive since they repeatedly re-compute the stage DAG.  I'm a little nervous about the change though, because the DAGScheduler code is generally somewhat brittle and doesn't have well-documented invariants / abstractions, so this should be merged towards the beginning of a release cycle, ideally.  I'm most nervous about the change to getAncestorShuffleDependencies (which adds a lot of complexity) so curious to hear why that is necessary.

@kayousterhout Thank you for your review.
I split a PR for the correctness of the stage building at #12655.

Great thanks @ueshin! I've left some comments on that PR.

@kayousterhout Thank you.
I'll check and modify it to follow your comments.

Test build #58529 has started for PR 12060 at commit 0c0d9ed.

Test build #58529 has finished for PR 12060 at commit 0c0d9ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58529/
Test PASSed.

Good PR, will it plan to be merged into branch-1.6?

@zzcclp Not likely.  This PR shouldn't produce any different results, but rather produces the same results faster.  We're typically very conservative with patch-level releases, so the optimization work for this PR will almost certainly only appear in the Spark 2.x series.  That's not too far off.

@markhamstra , thanks for your explaintion.

This LGTM with the small comment changes I suggested. @markhamstra any objections to this? Mark / @rxin thoughts on merging it into the 2.0 branch?

Test build #58659 has started for PR 12060 at commit 4eb8c05.

@kayousterhout Thank you for your review.
I updated the comments and pushed.

Test build #58659 has finished for PR 12060 at commit 4eb8c05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58659/
Test PASSed.

Test build #59133 has started for PR 12060 at commit 4eb8c05.

Test build #59133 has finished for PR 12060 at commit 4eb8c05.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59133/
Test FAILed.

Jenkins, retest this please.

Test build #59153 has started for PR 12060 at commit 4eb8c05.

Test build #59153 has finished for PR 12060 at commit 4eb8c05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59153/
Test PASSed.

I merged this into master (not 2.0, since it's a performance problem rather than a correctness problem, and this isn't a regression).  Thanks @ueshin!

Thanks a lot for merging this!


Add a reference to INODES in the Maxfiles section

With the Maxfiles section. Please include a reference that Linux file systems refer to these as INODES, and so an INODE limit request is the same as Maxfiles limit.
This will help ease confusion when Support are processing an inode increase and refer customers to the maxfiles limit table per volume size on what the limits are so the customer can overprovision to achieve the desired inode number (if less than 100million)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93ca706a-09d1-39dc-80b5-3df2a180a5e9
Version Independent ID: 72abc701-095f-3f2f-b35c-0161e4980c1e
Content: Resource limits for Azure NetApp Files
Content Source: articles/azure-netapp-files/azure-netapp-files-resource-limits.md
Service: azure-netapp-files
GitHub Login: @b-juche
Microsoft Alias: b-juche

@jolauMSFT Thanks for the question! We are investigating and will update you shortly.

@jolauMSFT - thanks!  I'm running the proposed changes by the team members.

We added that maxfiles limits are inodes limits in Linux systems:
Linux file systems refer to the limit as inodes.
You can initiate a support request to increase the maxfiles (inodes) limit beyond 100 million.

#please-close


Does it support xaml ?

Hello , i would like to thank you for your participation and i think this would be really usefull if it would be complete :)
so I want to ask :

Does it have a support for Xaml ?
How to use this package ?

Hi, Thank you for your interest!
Yes, it will support Xaml, now it is in development.
As an example of the use will be soon, I'm still working on it

HI @AfaqSofware !
Please check new release)


How to run agent?

I successfully setup everything except for agent by using local_install.sh.
There are two instructions for running agents.
For the first one docker exec -it craftassist-container bash, I don't have craftassist-container.
For the second one python ./python/craftassist/craftassist_agent.py, I don't have all the dependencies downloaded. It gives me another error when I try to download packages.
What should I do with it?

Hi @feipenghe ,
For the first one, you will need to create a container from the docker image you created as discussed in previous issue using the following command:
docker run -it -p 25565:25565 -p 3000:3000 -p 2556:2556 -p 2557:2557 -p 9000:9000 -p 5000:5000 -p 8000:8000 -v "$(pwd)"/python:/craftassist/python -v "$(pwd)"/annotation_tools:/craftassist/annotation_tools --name craftassist_container craftassist

This will create the container, start it and open an interactive bash shell for you. Then you can use docker exec -it craftassist-container bash to open as many bash shell as you want.
If you are using local_install.sh the name would be minecraft for the image and minecraft_container for the container. The above steps are the same.
For the second one, could you please share what errors you get when you try to download packages? Are you using these instructions?

Thanks, I think I didn't understand how to use docker container. I realize python script should be run in the container.


Testing complex element, how to get it's state?

What are you trying to achieve?
I would like to test our video player integration. But I am strugeling, due inability to find any documentation. For example how to get Element.
I need the element to be able to access to element, I need to test, that pausing really paused the video etc...
What do you get instead?
Headache... I have on idea where to look. I tried to make a helper:
'use strict';
//@ts-check

class VideoHelper extends Helper {
	async _getVideo() {
		return this.helpers.Puppeteer._locate(`.videojs video`);
	}

	async seeVideoIsPaused() {
		const video = await this._getVideo();
		console.log(video);
	}
}

module.exports = VideoHelper;

Details

CodeceptJS version: 1.3.3
NodeJS Version: 9.11.1
Operating System: Win / Linux
Puppeteer (using original chrome, but chromium ain't any better)
Configuration file:

# paste suite config here

PS: class Helper don't have any definition, this could be possibly improved.

Can you give page, for testing on it?
Maybe you have error on _getVideo method,
You do not return result of _locate, only _locate itself.
Maybe you should try to use await before return return await this.helpers.Puppeteer._locate(`.videojs video`);
see https://codecept.io/helpers/Puppeteer/#_locate

M bad this can be closed, but I still think class Helper need some type definition.

@Akxe , did you tried this?
Or there are no Helpers definition in this generator ?

Well maybe not, I got something like an element, but for some reason calling addEventListener on it is invalid. Any thoughts? I need to seek and resolve only when seek is truly done.

@LukoyanovE I have done this, it will produce wrong types (it gives string type for everything, regales of JSDoc). Also Helper isn't defined there.

This doc says that Puppeteer return array of ElementHandle
Did not worked with puppeteer, maybe you should call getProperties on element in returned array of elements and console.log all it's methods/properties to find out which method it has

Helper... just write one on your own...

@Akxe, you always can commit your fixes


network: address socket interface pointer instead of name

Signed-off-by: Florin Coras<EMAIL_ADDRESS>Risk Level: Low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a

Thanks!

Thank you for the review!


IPC fixes related to post commit review of PR 1219

Ref https://github.com/criblio/appscope/pull/1219#issuecomment-1378558337

Repeated here, just so I can check these off at review time...  =)

replacing the configuration and handling the old configuration - free it or not ?
currently, if something went wrong I pass the information - metadata status or message status with the number there are no string details - maybe it is worth adding such a logic - my original intention was to save space as much I can to ensure that I fit into the message queue size buffer

[ ] regarding first one: freeing it
[ ] regarding second one: add DBG statement
[ ] other: ensure that msg is NUl ended on JSON before call CjSON_Parse
[ ] other: test framing more


Feature/aql modificators cpp test

This just adds more C++ test for all Modification Executors.
We did some refactoring there in a different branch and we want to make sure we have not broken anything.
No production changes just additional google test code.
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6803/

It should be highlighted that this PR contains fixes for the test mocks (and which those are).

Once again,
after comment merges:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6912/

The non maintainer compile failed because c05 seems to have been broken. I started yet another compile to be sure here: http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6922/

Tests are blue


docs: escape the characters in completion text

Escape the characters in the HTML text for the completion commands.
Fixes: https://github.com/istio/istio.io/issues/15462 and https://github.com/istio/istio.io/pull/15453

@peterj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e7236c322a52842a4b2a7ddae1dd99d474349a1d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes


How can I connect css?

How can I connect css?

answer
import 'rc-datetime-picker/dist/picker.css';


[gateway] queue shards before connecting

Before starting a connection, put in a request to the queue and wait for
it to be realized. This will ensure that only one shard is connecting at
a time, due to the ratelimit around how often shards can connect.
Closes #34.
Signed-off-by: Zeyla Hellyer<EMAIL_ADDRESS>

It'd be a good idea, opened #37 for that question


Onboarding Volunteers

[ ] Volunteers list

Details to be collected

[ ] Expertise in Django & Python

[ ] Contribution Type(Design, code, planning etc)

[ ] Number of Hours they can contribute

[ ] Others

Should list out the perks of being a Volunteer and the basic instructions/ guidelines of being a volunteer.


Darwin: Only set FD_CLOEXEC when creating a socket FD

Not when an existing FD is passed to Socket.new

Follow up on https://github.com/crystal-lang/crystal/pull/14632#pullrequestreview-2080836656

I notice some issues with this change: when we create the socket the @handle ivar isn't set and calling #fcntl will fail (see CI) but we also set CLOEXEC for plain fd (e.g. Socket.new(fd, ...) which is used in UNIXSocket.pair for example.

when we create the socket the @handle ivar isn't set and calling #fcntl will fail (see CI)

Yeah I think we need to use LibC.fcntl(fd, ...) like before to fix the current failure. The file descriptor is not assigned yet, so we cannot use #fcntl.

we also set CLOEXEC for plain fd (e.g. Socket.new(fd, ...) as called from UNIXSocket.pair or Socket#accept? for example.

Yes, that's the current behaviour. But I believe it's wrong. We probably shouldn't autoclose a file descriptor that's coming from outside the process. Only close what we opened ourselves.
That means all uses in stdlib like Socket#accept? need to be updated to explicitly set close on exec.
However, I'm wondering if this isn't too bad a silent breaking change in behaviour... 🤔

I agree: it may not be the best API, but security-wise it doesn't sound like a bad practice to always close file descriptors on exec... and maybe always calling fcntl ain't a bad idea instead of setting O_CLOEXEC. If you need it to not be closed on exec, you can always call fcntl to disable the flag.

The following methods (at least) must also be fixed to set FD_CLOEXEC for darwin targets:

Socket#accept?
UNIXSocket#accept?
UNIXSocket.pair

Why Apple wouldn't implement the O_CLOEXEC flag is beyond me :face_exhaling:

Yeah, I suppose we should also setup specs for those methods.
@carlhoerberg If you want to go on, please continue. But we'll be happy to take over these final steps if you prefer.

Go for it! :)


[youtube] "youtube.com/name" can be a user or a channel

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Direct youtube URLs (youtube.com/name) now doesn't have to be a username but can be channel name. Closes #186

have no time to review it. maybe monday. maybe someone else can.

have no time to review it. maybe monday. maybe someone else can.

Seems to be a legit fix and works fine for the cases described. Links like this: _https://www.youtube.com/zsecurity_ are going to work fine with this improvement. However, I'm not sure how it was generated. Clicking on various YouTube channels within YouTube all came up why a /c/someChannelName - https://www.youtube.com/c/PeterSantenello
Doubt there's any risk approving and adding it to the next release. It works with all link formats, so it's definitely a good thing. Maybe, someone else can take a look and confirm with more expertise.

However, I'm not sure how it was generated. Clicking on various YouTube channels within YouTube all came up why a /c/someChannelName or /channel/somechannelid

@someziggyman  Youtube allows to shorten /c/channelName to just /channelName. But they also allow /u/userName to /userName. So given a url such as /name, it not possible to tell whether it is a usename or a channel name. However, since all the code for downloading user and channel is the same, I just made it use the shortened URL itself for extraction. That way there is no need to know if it is a user page or channel page.

Made obsolete by #245


Excellent Project

I was thinking of exactly this sort of method just a day or two ago! I'm glad to see it formalized and proven out.
Are you all interested in working on more? If you'd like to collaborate, let me know!

Also can I ask, was there worse outputs when you included the context in the task generating prompt? It seems to be the one that doesnt seem to utilize it

Hi @teknium1 , thank you. We are open to collaborations, the project is open-source so any kind of contribution is welcome.
Regarding the second question - when writing prompts with context the only problem was we had to be much more careful, and designing the prompt was harder.  The prompt without context, was just there for comparison. Usually, if the context is good, the prompts with context give better results.

Hi @teknium1 , thank you. We are open to collaborations, the project is open-source so any kind of contribution is welcome.
Regarding the second question - when writing prompts with context the only problem was we had to be much more careful, and designing the prompt was harder. The prompt without context, was just there for comparison. Usually, if the context is good, the prompts with context give better results.

Perhaps we can ask GPT4 to rate the quality of what it makes from the text chunk given and can exclude what it thinks is bad from final dataset. People seem impressed by GPT4-Evals (though I'm not yet convinced), so maybe it can determine if a given text chunk is valid for doing any of the dataset creation with. Then, while more costly, you could pipe in raw data without extensive cleaning and judging processes.

I'm not a big fan of using GPT-4 to eval the quality, based on what I've seen it tends to prefer a certain writing style and you end up with a dataset that is not very diverse.
The main challenge is in fact the question/task, not the answer, given a context the answers tend to always be very good (correct). So the problem is how to create a diverse set of tasks that you can use to prompt the model to generate answers/solutions. My idea was, given a context (or many of them) create a large dataset of tasks, then embed each task using the embedding API from OpenAI, remove similar tasks and keep only a very diverse dataset of tasks. Then use those with different contexts to generate answers/solutions. Could be something we should test.

Another thing to expand into different fields is somehow make this line in your prompt either variable (based on domain of the text to transform), or have GPT4 generate who or what style it should be writing it as:
Create a conversation between a Patient concerned about the symptoms and disorders presented above and an AI-Assistant. The conversation should abide by the following rules and instructions:

One prompt to rule them all? ^_^


fix(satori): fix incorrect impl about resource elements, fix #198, fix #217

image -> img
url -> src

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6390012) 86.08% compared to head (f32984d) 86.08%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   86.08%   86.08%
=======================================
  Files           1        1
  Lines         503      503
  Branches      111      111
=======================================
  Hits          433      433
  Misses         70       70

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: add missing await in src/gridfs

I found the code for gridfs has some promises without await. I made a small fix to add those awaits.

@lucsoft

You don't need Return await it's harming performance and needs it's pressures the GC

@c0per did you had problems with the missing awaits?
VS Code show still show you that you need to await even though its not a "async function"


API -  Posting reviews on my website

API - can you only get 1 review to appear on my website-- is that review at random? how can i get ALL the reviews to be linked to my website? (please cc answer to<EMAIL_ADDRESS>thank u

@marvalpert : The Yelp API chooses one very relevant review.


fix: DEV-1975: DEV-1843: Support long unbroken taxonomy line breaks

In order to support text without spaces that exceed the maximum width for taxonomy, creation of an invisible taxonomy item to check its width and calculate how many lines was necessary per item. Additionally I added the missing visibility mixin check.

Looks good to me!


Issue with building ios version

From @TimothyKrajewski on October 5, 2016 17:32
Here the error log:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'build' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle test2@~prebuild: test2@
6 silly lifecycle test2@~prebuild: no script for prebuild, continuing
7 info lifecycle test2@~build: test2@
8 verbose lifecycle test2@~build: unsafe-perm in lifecycle true
9 verbose lifecycle test2@~build: PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/TimKrajewski/TimsDrive/TimCollegeDrive/CSC498Capstone/Test2/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/git/bin
10 verbose lifecycle test2@~build: CWD: /Users/TimKrajewski/TimsDrive/TimCollegeDrive/CSC498Capstone/Test2
11 silly lifecycle test2@~build: Args: [ '-c', 'ionic-app-scripts build' ]
12 silly lifecycle test2@~build: Returned: code: 1  signal: null
13 info lifecycle test2@~build: Failed to exec build script
14 verbose stack Error: test2@ build: ionic-app-scripts build
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:87:13)
14 verbose stack     at EventEmitter.emit (events.js:172:7)
14 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:87:13)
14 verbose stack     at ChildProcess.emit (events.js:172:7)
14 verbose stack     at maybeClose (internal/child_process.js:829:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
15 verbose pkgid test2@
16 verbose cwd /Users/TimKrajewski/TimsDrive/TimCollegeDrive/CSC498Capstone/Test2
17 error Darwin 16.0.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
19 error node v4.5.0
20 error npm  v3.10.8
21 error code ELIFECYCLE
22 error test2@ build: ionic-app-scripts build
22 error Exit status 1
23 error Failed at the test2@ build script 'ionic-app-scripts build'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the test2 package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     ionic-app-scripts build
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs test2
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls test2
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]
I had to change the permissions of the hooks folder with chmod +x hooks/after_prepare/010_add_platform_class.js of the app just to run the command then it still failed
Copied from original issue: driftyco/ionic-cli#1474

From @cjdreiss on October 7, 2016 22:18
just started getting a similar issue.  my app was building last night, going to try rolling back some changes in my app to see if it helps.  ionic serve runs fine and my app functions.
Here's my NPM log...
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'build' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle enterprise-demo@~prebuild: enterprise-demo@
6 silly lifecycle enterprise-demo@~prebuild: no script for prebuild, continuing
7 info lifecycle enterprise-demo@~build: enterprise-demo@
8 verbose lifecycle enterprise-demo@~build: unsafe-perm in lifecycle true
9 verbose lifecycle enterprise-demo@~build: PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/username/Sites/enterprise-demo/node_modules/.bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Postgres.app/Contents/Versions/9.4/bin
10 verbose lifecycle enterprise-demo@~build: CWD: /Users/username/Sites/enterprise-demo
11 silly lifecycle enterprise-demo@~build: Args: [ '-c', 'ionic-app-scripts build' ]
12 silly lifecycle enterprise-demo@~build: Returned: code: 1  signal: null
13 info lifecycle enterprise-demo@~build: Failed to exec build script
14 verbose stack Error: enterprise-demo@ build: `ionic-app-scripts build`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:242:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:877:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid enterprise-demo@
16 verbose cwd /Users/username/Sites/enterprise-demo
17 error Darwin 15.6.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
19 error node v6.7.0
20 error npm  v3.10.3
21 error code ELIFECYCLE
22 error enterprise-demo@ build: `ionic-app-scripts build`
22 error Exit status 1
23 error Failed at the enterprise-demo@ build script 'ionic-app-scripts build'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the enterprise-demo package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     ionic-app-scripts build
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs enterprise-demo
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls enterprise-demo
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

From @cjdreiss on October 8, 2016 13:38
So, the actual error didn't show up in the npm log file.
I scrolled up a bit more and saw that the ngc process was failing, and complaining that I had something set to private
ngc: Error: Error at /Users/USER/Sites/enterprise-demo/.tmp/pages/dashboard/dashboard.ngfactory.ts:1919:42: Property 'pagesService' is private and only accessible within class 'DashboardPage'.

I set that to public and I'm good to go again.

@cjdreiss,
Glad you were able to get it resolved.
Thanks,
Dan


Ansible request for libnss3.so & libnssutil3.so to be added.

An issue was encountered whereby the 2 libraries required for SSL testing
libnss3.so
libnssutil3.so
These should be added in a more usable/resilient fashion.

Closed as duplicate of #3224


uiAccess=true is supported in MSIX

This combination is supported for MSIX packaging.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12379f43-c827-669f-6aeb-4b4d8650cfdf
Version Independent ID: fadedb99-8dfe-7371-105a-2944bc8d9766
Content: Prepare to package a desktop application (MSIX) - MSIX
Content Source: msix-src/desktop/desktop-to-uwp-prepare.md
Product: msix
GitHub Login: @Huios
Microsoft Alias: tajimha

@EHO-makai thank you for your comment, I can take care of updating the docs accordingly


reference: use named capturing groups

[x] depends on https://github.com/distribution/distribution/pull/3883

Rewrite the regular expressions to use named capturing groups.
This simplifies handling the resulting matches, but does require
some additional handling to associate matches with their names.
Also making some changes to the matching to match how domains
are actually matched; some of that was already handled in
code parsing the results of the regex, but now this is handled
by the regex itself.
Before:
BenchmarkParse
BenchmarkParse-10              12696             93805 ns/op            9311 B/op        185 allocs/op
PASS

After:
BenchmarkParse
BenchmarkParse-10              12486             94774 ns/op           18617 B/op        178 allocs/op
PASS

Benchstat:
go test -run='^$' -bench=. -count=10 ./reference/ > old.txt
go test -run='^$' -bench=. -count=10 ./reference/ > new.txt

benchstat old.txt new.txt
name       old time/op    new time/op    delta
Parse-10   91.7µs ± 0%    97.0µs ±11%   +5.82%  (p=0.000 n=9+10)

name       old alloc/op   new alloc/op   delta
Parse-10    9.32kB ± 0%   18.63kB ± 0%  +99.93%  (p=0.000 n=10+10)

name       old allocs/op  new allocs/op  delta
Parse-10        185 ± 0%       178 ± 0%   -3.78%  (p=0.000 n=10+10)

Codecov Report
Base: 56.56% // Head: 56.64% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (5435a29) compared to base (ede90db).
Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3803      +/-   ##
==========================================
+ Coverage   56.56%   56.64%   +0.08%
==========================================
  Files         105      105
  Lines       10638    10647       +9
==========================================
+ Hits         6017     6031      +14
+ Misses       3948     3943       -5
  Partials      673      673

Impacted Files
Coverage Δ

reference/reference.go
80.85% <83.33%> (+2.56%)
:arrow_up:

reference/regexp.go
92.30% <90.00%> (-7.70%)
:arrow_down:

reference/normalize.go
76.41% <100.00%> (+0.22%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Looks like ghcr.io is unhappy (tried locally and also unable to pull);
Pull down action image 'ghcr.io/opencontainers/distribution-spec/conformance:v1.0.0@sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f'
  /usr/bin/docker pull ghcr.io/opencontainers/distribution-spec/conformance:v1.0.0@sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f
  Error response from daemon: Get "https://ghcr.io/v2/opencontainers/distribution-spec/conformance/manifests/sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f": Get "https://ghcr.io/token?scope=repository%3Aopencontainers%2Fdistribution-spec%2Fconformance%3Apull&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  Warning: Docker pull failed with exit code 1, back off 7.185 seconds before retry.
  /usr/bin/docker pull ghcr.io/opencontainers/distribution-spec/conformance:v1.0.0@sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f
  Error response from daemon: Get "https://ghcr.io/v2/opencontainers/distribution-spec/conformance/manifests/sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f": Get "https://ghcr.io/token?scope=repository%3Aopencontainers%2Fdistribution-spec%2Fconformance%3Apull&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
  Warning: Docker pull failed with exit code 1, back off 8.553 seconds before retry.
  /usr/bin/docker pull ghcr.io/opencontainers/distribution-spec/conformance:v1.0.0@sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f
  Error response from daemon: Get "https://ghcr.io/v2/opencontainers/distribution-spec/conformance/manifests/sha256:6302582c3b35169f7846282ad5b81471cd8814f30f7a958030e04fd82b19e17f": Get "https://ghcr.io/token?scope=repository%3Aopencontainers%2Fdistribution-spec%2Fconformance%3Apull&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Error: Docker pull failed with exit code 1

@corhere @squizzi @milosgajdos interested to hear your take on this; I think this makes the code/handling easier to reason with, and the Regexes more "complete", and potentially more usable. But (as commented) does come with an increase memory use. Wondering if we think the pros outweigh the cons.

@thaJeztah do you mind moving this PR to the https://github.com/distribution/reference repo?

ping @thaJeztah we need to move this to the new repo. I don't think you can move PRs between repos (I know you can move issues), so we might wanna close this and open it in the new repo.

@thaJeztah do you want to close this now that reference is in its own repo?

 Mind closing this @thaJeztah or moving it to distribution/reference?

Closing as reference has moved to https://github.com/distribution/reference
We need to re-open the PR there.


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2024-07-15T13:49:31+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-cni

integ-pilot-istiodremote_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-cni

integ-pilot-istiodremote_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot

integ-pilot-istiodremote-mc_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-cni

integ-pilot_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot

integ-pilot-istiodremote-mc_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-cni

integ-pilot-istiodremote-mc_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
4d0a2bddb5587eb89f13232b0a36c0373b5b3673
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-security-multicluster

integ-pilot-istiodremote_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-cni

integ-pilot_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4eeac313fd2412b6e1137d7eb2ae5c2f8b382354
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


[web] Not allowed to load local resource

After some time, the flutter web stops running in chrome. The only thing that helps is the creation of a new project and the transfer of the entire code base there. But this is enough for several hours of active work ... The browser opens, but nothing happens then.
I'm on a beta channel, but on the master everything happens exactly the same.

C:\flutter_projects\disinsection>flutter run -d chrome -v
[  +20 ms] executing: [c:\dev\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +58 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 2a7bc389f28d83c581f7ddd4601588a22e12512e
[        ] executing: [c:\dev\flutter/] git describe --match ..* --first-parent --long --tags
[  +50 ms] Exit code 0 from: git describe --match ..* --first-parent --long --tags
[        ] 1.17.0-3.2.pre-0-g2a7bc389f
[  +11 ms] executing: [c:\dev\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +35 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [c:\dev\flutter/] git ls-remote --get-url origin
[  +39 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +98 ms] executing: [c:\dev\flutter/] git rev-parse --abbrev-ref HEAD
[  +32 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[  +29 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +18 ms] executing: C:\Users\maxim\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +34 ms] List of devices attached
[   +4 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +211 ms] Generating C:\flutter_projects\disinsection\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +94 ms] Launching lib\main.dart on Chrome in debug mode...
[  +55 ms] Updating assets
[ +103 ms] Syncing files to device Chrome...
[  +65 ms] Generating C:\flutter_projects\disinsection\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +34 ms] <- reset
[   +7 ms] c:\dev\flutter\bin\cache\dart-sdk\bin\dart.exe c:\dev\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root c:\dev\flutter\bin\cache\flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names -Ddart.developer.causal_async_stacks=true --output-dill
C:\Users\maxim\AppData\Local\Temp\flutter_tool.a6b0150e-88cf-11ea-ab0e-74d02b9624ce\app.dill --libraries-spec file:///c:/dev/flutter/bin/cache/flutter_web_sdk/libraries.json --packages C:\flutter_projects\disinsection.packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-root C:\Users\maxim\AppData\Local\Temp\flutter_tools.a6b0150f-88cf-11ea-ab0e-74d02b9624ce --filesystem-scheme
org-dartlang-app --initialize-from-dill build\cache.dill --platform file:///c:/dev/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill
[  +16 ms] <- compile org-dartlang-app:///web_entrypoint.dart
[+9179 ms] Syncing files to device Chrome... (completed in 9 291ms, longer than expected)
[   +1 ms] Synced 20.9MB.
[   +1 ms] <- accept
[ +161 ms] [CHROME]:
[   +5 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:60676/devtools/browser/f9a21aea-bf88-4cd7-b19f-b9f26cc88c3a

C:\flutter_projects\disinsection>flutter doctor -v
[√] Flutter (Channel beta, v1.17.0-3.2.pre, on Microsoft Windows [Version 10.0.18362.778], locale ru-RU)
• Flutter version 1.17.0-3.2.pre at c:\dev\flutter
• Framework revision 2a7bc389f2 (6 days ago), 2020-04-21 20:34:20 -0700
• Engine revision 4c8c31f591
• Dart version 2.8.0 (build 2.8.0-dev.20.10)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\maxim\AppData\Local\Android\sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] IntelliJ IDEA Ultimate Edition (version 2019.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.1.2
• Flutter plugin version 45.1.2
• Dart plugin version 193.6494.35
[√] VS Code (version 1.39.1)
• VS Code at C:\Users\maxim\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.5.1

Hi @zeppelin-tt
so don't you have
[+9408 ms] Debug service listening on ws://<IP_ADDRESS>:58122/CB5kct3Wfio=

[ +293 ms] Debug service listening on ws://<IP_ADDRESS>:58122/CB5kct3Wfio=
[   +2 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[        ] 🔥  To hot restart changes while running, press "r". To hot restart (and refresh the browser), press "R".
[   +2 ms] For a more detailed help message, press "h". To quit, press "q".

in your log after
[ +5 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:60676/devtools/browser/f9a21aea-bf88-4cd7-b19f-b9f26cc88c3a ?
Can you see any error in the browser console?

No, I have nothing in the log after.
Here is my error in browser console:

require.js:1961 Not allowed to load local resource: file:///C:/flutter_projects/project/lib/pages/home/components/header.dart
req.load @ require.js:1961
require.js:143 Uncaught Error: Script error for "C:/flutter_projects/project/lib/pages/home/components/header.dart", needed by: packages/disinsection/pages/home/main_page.dart
http://requirejs.org/docs/errors.html#scripterror
at makeError (require.js:168)
at HTMLScriptElement.onScriptError (require.js:1738)

The most interesting thing is that just copying the entire code base into a new project helps. Temporarily.

Does the problem go away if you do git clean -xdf in your codebase (assuming you are using git; WARNING: this can undo uncommitted changes)?

@yjbanov it helps me! Thx!

Warning: Don't do git clean -xdf if you don't know what it is!! It will remove all your files that are not under version control!!


feature: dynamic target group stickiness configuration block

Adds a dynamic block for target group stickiness configuration.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

@adenot  Is it okay for the variable to be any type?

@adenot Is it okay for the variable to be any type?

yes, we had some problems before when using dictionaries without "any" type.


Client cannot send named message to server through SendNamedMessage overload

Describe the bug
When using the overload on the class CustomMessagingMessenger.cs:
public static void SendNamedMessage(
      string name,
      List<ulong> clientIds,
      Stream stream,
      string channel = null,
      SecuritySendFlags security = SecuritySendFlags.None)

It will throw an error stating: "Can not send named messages to multiple users as a client" when called from a client. This happens regardless of there only being the server id in the list.
To Reproduce
Steps to reproduce the behavior:

Create a custom named message
Send it from a client to a server, but using the above mentioned overload

Expected behavior
The expected behaviour is that the method will send the method to a server, if the list only contains one id, which matches that of the server.

As I can see from the implemented SendNamedMessage function and the corresponding Send function, it isn't a bug. This behavior seems to be intended.
Nonetheless it would be handy to be able to send CustomNamedMessages from a client to the server?
I guess this is more like a feature request.

@blacktoby At this point in time you can send custom named messages from the client to the server, only the overload with multiple client ids will not even if there is only one id which corresponds to the server. I'm actually using the other (single clientId) overload to send messages from clients to the server right now. The message only gets suppressed when the client itself is a host.

Yes, I agree. Missed this point here.

This can be accomplished with the following overload:
public static void SendNamedMessage(string name, ulong clientId, Stream stream, string channel = null, SecuritySendFlags security = SecuritySendFlags.None)

The clientId should be NetworkingManager.Singleton.ServerClientId


Export roller geometry in a way that is suitable for plotting

Export roller geometry in a way that is suitable for plotting.
E.g. as a closed polygon with all rollers rotated in correct positon.

Okay, so by going through all the other issues I will combine the tasks.

Make the property contour_lines of class RollPass availabe in the export
Make sure that the property is already in it's correct technological representation -> already handled by pyroll-core if the hooks orientation are set.

Should already be solved with https://github.com/pyroll-project/pyroll-core/pull/243 (except the "technological" orientation)

As agreed yesterday, we will add a hook for this in the core.


[Android] Sluggish overall performance

On both Asus Chromebook C100 Flip and direct-from-Google Nexus 6, overall application performance is extremely sluggish.  I have encountered similar symptoms with applications I've written in which I did not properly import images, resulting in incorrect resolutions being scaled at run-time.  I solved this problem by using the popular android studio plugin for batch image imports, which will automatically scale and sort the copies of the images for various device resolutions.  I don't know if that's the issue here, but thought I'd mention it as a possible direction to look to improve application performance.

This issue is atrocious. I am running on a OnePlus 5T, a flagship model with four CPU cores running at 2.45 GHz and another four running at 1.9 GHz. When I am typing into the Keybase chat, I often have to wait in excess of 10 seconds (!!) for the text input box to catch up. I know this must be killing my battery life too. Something in the GUI desperately needs to be fixed!


added windows port

Do you like to support windows?

Hey, I appreciate you taking the time to add in Windows support, but according to the official Windows API documentation, isn't CryptGenRandom() deprecated? Wouldn't it be better to use BCryptGenRandom() or something?

@7thSamurai I do not know if there are issues with the old API, it was an example I had, but if you want, I can modify the RNG to BCryptGenRandom

Yeah, I'd appreciate that. While it probably isn't a big deal to use the old method, I just figure that we might as well use the new version.
Besides Microsoft does state that "Microsoft may remove this API in future releases.", so while that's unlikely I'd prefer not to risk any issues in the future. Thanks.