Status ticker fails to update periodically on some builds

See original issue on GitLab
In GitLab by [Gitlab user @tlater] on Oct 24, 2017, 15:14
Issue #107 appears to have been two independent issues.
The second part of this issue not targeted by buildstream/107-failing-child-processes-when-tracking-missing-git-branches is a UI freeze that occurs during certain builds.
Occasionally, during tracking, any timers in the status area may stop to count by themselves, only being updated by messages written to the main log. If run through bst build --track, this will correct itself once an actual build starts.
I have not been able to track down the exact cause, but I believe this might be caused by a track job failing and the user choosing 'continue' or anything that causes  [https://gitlab.com/BuildStream/buildstream/blob/master/buildstream/_scheduler/job.py#L275](this error).
I have been able to quite consistently reproduce this issue building gnome-modulesets (one of its sources currently fails to track due to an outdated SSL certificate), but I have been unable to reproduce it otherwise.

In GitLab by [Gitlab user @tlater] on Oct 25, 2017, 18:07
created branch 128-status-ticker-fails-to-update-periodically-on-some-builds

In GitLab by [Gitlab user @tlater] on Oct 25, 2017, 18:07
mentioned in merge request !123

In GitLab by [Gitlab user @tristanvb] on Oct 26, 2017, 14:25
Some notes:

I have confirmed that this bug does not happen when running builds, after a build fails and you choose to continue, ticker keeps ticking reliably
[Gitlab user @tlater] has confirmed that this bug does not happen when tracking elements that are not ostree

OSTree has a bad track record for messing up the process it's run inside of - somehow it would seem that ostree being run in the child task and failing is leaving some debris behind.
Maybe we need some better bullet proofing of child tasks, which are intentionally fork() without execve(), are we setsid() in a child task ? If not, there is certainly a reason (probably to do with suspend/resume), and if not, would this cause us to inherit damage done in the child to the session group ?

In GitLab by [Gitlab user @tlater] on Oct 26, 2017, 17:41
More notes:

It appears that raising an Exception in the ostree plugin's track function before any ostree invocations results in the same symptoms - this is probably not related to the process being run.
I have also found a pipeline that fails this way without requiring a failing track. It's possible that these just take more time than normal tracks.
The smallest pipeline showing this behavior I have found was 47 elements.

Looking at the documentation for asyncio, if we were for some reason blocking on track jobs it's possible that the loop is simply being swamped with processes and doesn't run the tick timer until all others have finished.

In GitLab by [Gitlab user @tlater] on Oct 27, 2017, 11:32
Since this is taking a while and there are more critical bugs, final little mind dump:

In job.spawn() we call watcher.add_child_handler() outside of a context manager. Though this isn't documented very well, the docstring for child handlers mentions that this is required https://github.com/python/cpython/blob/63ae04461fb0cc93ca57cd151103a8dd295581d6/Lib/asyncio/unix_events.py#L694. Since we are using our own implementation of Popen perhaps this isn't necessary, but I'm unsure.
Under certain circumstances, encountering this bug seems to block SIGINT (so ^C doesn't work). Once the effects wear off, sometimes several SIGINTs arrive at the same time, bringing up multiple prompts in sequence. This is probably the most major issue with this bug.

In GitLab by [Gitlab user @tlater] on Jan 23, 2018, 17:48
This has not been updated in a while, and I don't seem to be able to reproduce it anymore.
Some more digging made our element state resolution issues seem related, so this may have been fixed by !215 - should we close the issue?

In GitLab by [Gitlab user @LaurenceUrhegyi] on May 25, 2018, 12:14
assigned to [Gitlab user @tristanvb]

In GitLab by [Gitlab user @LaurenceUrhegyi] on May 25, 2018, 12:14
[Gitlab user @tristanvb] Do you think we can close this one since it has not been seen in a long time?

In GitLab by [Gitlab user @tristanvb] on May 27, 2018, 03:19
closed


Cannot reorder Favorites

Thread: http://forums.hummingbird.me/t/cant-edit-re-order-favourites/18755
This is evidently broken in two places by two different changes (ember-cli and JWT), so I expect the following tasks:

[ ] Meet or remove dependency on jQuery UI
[ ] Move favorites calls off APIv1

Solution for this is working through #185


Request returning unexpected HTTP-Status Code on a Bad Request  with DELETE composition

Configuration information
<ehrbase_version>0.17.2</ehrbase_version>
<openehr_sdk_version>fac6c67</openehr_sdk_version>
<archie_version>5a4a9442e5e2516aed5f25636ac236682aace7b9</archie_version>
<jvm_version>Oracle Corporation 11.0.12+7</jvm_version>
<os_version>Linux amd64 5.4.0-90-generic</os_version>
<postgres_version>PostgreSQL 11.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 8.3.0) 8.3.0, 64-bit</postgres_version>

Steps to reproduce

Send an example composition to the server
Template: ZLG_Testdaten.opt.txt
Delete the composition using
Endpoint: DELETE {{host}}/ehrbase/rest/openehr/v1/ehr/:ehrId/composition/:compositionId

Enter compositionId
Leave ehrId blank

Actual result
Leaving the ehrId or both ehrId and compositionId blank like ( DELETE {host}/ehrbase/rest/openehr/v1/ehr//composition/)
leads to 401 Unauthorized.

Expected result (Acceptance Criteria)
Like:
I guess 400 Bad Request would be appropiate?
Leaving the compositionId blank gives back 405.
Definition of Done

[ ] The defect is checked by an unit or an integration test (Robot)
[ ] Merge Request approved
[ ] Unit tests passed
[ ] Build without errors
[ ] Release notes prepared
[ ] No additional runtime warnings

Just an update:
I tried the :next-Docker-Image (related to an other now fixed issue) and there was no change in behaviour.
<ehrbase_version>0.17.3-SNAPSHOT</ehrbase_version>
<openehr_sdk_version>1e26bf1</openehr_sdk_version>
<archie_version>1.0.4</archie_version>
<jvm_version>Oracle Corporation 11.0.13+8</jvm_version>
<os_version>Linux amd64 5.4.0-90-generic</os_version>
<postgres_version>PostgreSQL 11.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 8.3.0) 8.3.0, 64-bit</postgres_version>

Dear @richter122-goe
I just tried locally with the following config:
{
    "ehrbase_version": "0.17.3-SNAPSHOT",
    "openehr_sdk_version": "1e26bf1",
    "archie_version": "1.0.4",
    "jvm_version": "AdoptOpenJDK 11.0.11+9",
    "os_version": "Windows 10 amd64 10.0",
    "postgres_version": "PostgreSQL 11.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 8.3.0) 8.3.0, 64-bit"
}

    environment:
      ADMIN_API_ACTIVE: 'true'
      SECURITY_AUTHTYPE: BASIC
      SECURITY_AUTHUSER: user
      SECURITY_AUTHPASSWORD: Azerty1234
      SECURITY_AUTHADMINUSER: admin
      SECURITY_AUTHADMINPASSWORD: Azerty123456

and here are the results:

No user = 401 Unauthorized
User = 403 Forbidden
Admin with empty EHR ID = 401 Unauthorized
Admin with invalid EHR ID =  404 Not Found
Admin with invalid or empty Composition ID = 404 Not Found
Admin with valid EHR ID and Composition ID = 204 No Content

Based on the status code 401 Unauthorized, I guess that you are running EHRbase with security (Basic Auth/OAuth2) enabled?
If yes and if you are correctly authenticated with admin user, the error 401 Unauthorized comes from the implementation of HttpFirewall.
By default, Spring Security uses StrictHttpFirewall implementation to validate the URL. Using http://localhost:8080/ehrbase/rest/admin/ehr//composition/, request is rejected because the URL contains a potentially malicious string ( //).
In my opinion, even if the status code 401 Unauthorized looks strange, current behavior is correct knowing that is a security exception.

Dear subigre,
thank you for your replay and additional information. Yes, i am using Basic Auth.
I guess I didn't think far enough here, but considering the HttpFirewall and the resulting string http://localhost:8080/ehrbase/rest/admin/ehr//composition/ the 401 Unathorized-Response makes sense.


PLT-97 Add style guide and a link to it from CONTRIBUTING doc.

I commented out a couple things that we aren't very sure about. Changed the wording a bit in a couple places.
Added a link under the "Working conventions" section, which maybe could use a tidy up now that we have the style guide. It's also OK as is, it's not very repetitive.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

A few comments. Worth looking at the rich diff on Github, makes rendering issues more obvious!

Sorry I was using the vscode preview function, maybe that doesn't render the same as on here. I'll remember that for next time.

Sorry I was using the vscode preview function, maybe that doesn't render the same as on here. I'll remember that for next time.

Huh, weird? I think asciidoc isn't fully standardized, so maybe that's it...

I think I got everything? Ready to merge once approved.


SO-4044: Replace import job key test with instanceof

Codecov Report

Merging #577 into 7.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                7.x     #577      +/-   ##
============================================
- Coverage     52.81%   52.79%   -0.02%
+ Complexity    13598    13592       -6
============================================
  Files          1800     1800
  Lines         86327    86327
  Branches      11302    11302
============================================
- Hits          45593    45578      -15
- Misses        35942    35961      +19
+ Partials       4792     4788       -4

Impacted Files
Coverage Δ
Complexity Δ

...re/index/change/SnomedRepositoryPreCommitHook.java
92.00% <100.00%> (ø)
44.00 <0.00> (ø)

.../b2international/snowowl/core/ServiceProvider.java
15.00% <0.00%> (-65.00%)
2.00% <0.00%> (-4.00%)

...nal/snowowl/core/jobs/SearchJobRequestBuilder.java
37.50% <0.00%> (-12.50%)
2.00% <0.00%> (-1.00%)

...ernational/snowowl/core/jobs/SearchJobRequest.java
46.42% <0.00%> (-7.15%)
5.00% <0.00%> (-1.00%)

...ational/snowowl/core/domain/DelegatingContext.java
92.15% <0.00%> (-1.97%)
11.00% <0.00%> (-1.00%)

...nternational/snowowl/core/jobs/RemoteJobEntry.java
60.46% <0.00%> (-1.56%)
23.00% <0.00%> (-2.00%)

...d/ecl/parser/antlr/internal/InternalEclParser.java
56.52% <0.00%> (+0.05%)
368.00% <0.00%> (+2.00%)

.../snomed/core/ecl/SnomedEclRefinementEvaluator.java
88.04% <0.00%> (+0.29%)
110.00% <0.00%> (ø%)

...onal/snowowl/snomed/core/tree/TerminologyTree.java
82.69% <0.00%> (+1.92%)
21.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9730501...3c2bd8d. Read the comment docs.


start/redis.js seems not booted/registered.

Package version
"@adonisjs/redis": "^2.0.7"

Node.js and npm version
Node: v10.8.0
Npm:6.4.1
Sample Code (to reproduce the issue)
Redis.subscribe('music',async (track) => {
  console.log(track)
});

The start/redis.js file which copied from https://github.com/adonisjs/adonis-redis/blob/develop/examples/listener.js is seems not booted by default. Because for example if I uncomment
Redis.subscribe('music',async (track) => {
  console.log(track)
});

this piece of code, and publish a message from redis-cli, nothing happens and redis returns 0 which means channel has no subscriber.
If i copy the code above (Redis.subscribe... code) to event.js, It works as expected. Do I have to register/boot manually the redis.js (listener) file ? I think It should be registered/booted by default. Or am I missing something else?
Thanks!

The file should be copied to start/events.js as mentioned in the docs https://adonisjs.com/docs/4.0/redis#_pub_sub.
I will push a fix soon

I have copied start/redis.js to start/events.js but still not working. And then downgrade to version ^2.0.4 to fixed this issue.


fix(webpack): use this to support server side

Fix #597

Thanks for sending this PR! Merged #599 instead since it doesn't contain the dist file changes.


feat:export additional graphql types

Description
Closes https://github.com/payloadcms/payload/issues/2557 , I will update the documentation around GraphQL after this PR in case there are any further changes needed in this code.
This PR exports:

buildPaginatedListType
the internally used GraphQL library and type to make sure there's no conflicts (happy to revert on this one but I thought it might make the DX easier)
the mutations and queries type into a re-usable type GraphQLExtension in the config

And it attaches the created buildPaginatedType from collections to the available types for re-use on payload.collections.graphQL.

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update (will come in a PR after this one)

@denolfe I've fixed those code style issues. Added documentation, let me know how it looks.
Going through it again, there's probably another round of work to do to make working with GraphQL feel more first class.


Stop rendering of visualizer when visualizer is minimized

It looks like HID monitoring should be disabled too when the HID is minimized. This would be good to implement


Only run GH action for local PRs

... so that this should NOT fail the action on this PR, but also NOT add it to our board, as it is now skipped

/lgtm


Have scheduled return a disposer function

Wouldn't it be better if a scheduled returns a disposer function. This way they mirror the built-in timers like setTimeout and you can't clear unless you set one.
const trigger = debounce((message: string) => console.log(message), 250);
const clear = trigger("Hello!");
clear();

Well it looks clean, sure. But there is a problem. The clean function isn't tired to a specific trigger, it's "global" - always clearing the current timer.
Also you cannot assign the clear function to a variable before triggering the callback in the process.
The current API may look worse, but I think it's more practical.

You are right. Current implementation is way more flexible. Thanks.


How to customize optimization methods

Hello，I'm using egobox with python. I want to know if I can customize the optimization method.
I know egor optimizes with slsqp or cobyla, Is it possible to use the optimization algorithm provided by yourself in python? For example, I want to use differential evolution (DE) .

Hi. The short answer is this is not possible. Egor is written in Rust and uses internally Cobyla (default) or Slsqp also written in Rust. If you develop in Rust we could imagine adding another kind of optimizer but adding a Python optimizer would be difficult (not to say a bit clumsy).

Thank you very much for your answer, I used smt before but I found egobox to be even better, especially in terms of speed and handling constraints!


feat/ui-adjust: adjust spacings on large screens on game details ui

On bigger screens (1280px+), game content gets shrinked so images don't get weirdly placed on the center.
(on smaller screens minor adjusts were made)
Old:

New:

LGTM


default aggregator

hi I'm so satisfied with pivottable, but I have to display a report for the end users and need sum as default aggregator for this report, I've read all documentation and examples but I can´t find a solution
hope you can help me

Are you using pivot() or pivotUI() ?

hi thanks for your answer, I'm using pivot ()

See new example here: http://nicolas.kruchten.com/pivottable/examples/simple_agg.html

thank you so much , it´s just what I need... I tried by this way before but I missed some parameters
wonderful tool


Новые юнит-тесты

[Current coverage][cc-pull] is 10%

Merging [#119][cc-pull] into [master][cc-base-branch] will increase coverage by 2%

2 files (not in diff) in ...oupLockiOS/GroupLock were modified. more

Misses -6
Hits +6

@@            master       #119   diff @@
=========================================
  Files           12         12
  Lines          332        332
  Methods          0          0
  Messages         0          0
  Branches         0          0
=========================================
+ Hits            28         34     +6
+ Misses         304        298     -6
  Partials         0          0

[][cc-pull]

Powered by Codecov. Last updated by [565fcd4...116c8b8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/lanit-tercom-school/grouplock/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/lanit-tercom-school/grouplock/compare/565fcd4df62db803486962d99dff08775e04e87f...116c8b856f4bce37a17fe623eb17f467492009e0
[cc-pull]: https://codecov.io/gh/lanit-tercom-school/grouplock/pull/119?src=pr


stop hitting the database directly, to minimize breaking on upgrades.

I need to make a list of operations that hit the database directly,
if there are nodebb core functions for those, use them
if not, propose them

closing this one in favor of its superset https://github.com/akhoury/nodebb-plugin-import/issues/144


Add color logging to Staramr

There's currently a library called colored logs which is a python library that output colors in the terminal. I think this would be really helpful especially for debugging code in the project.
Example:

That looks really cool :+1:

Closing issue as this have been implemented


I was wrong, this is implemented. It just doesn't work in the case when you have a single regular slice (any horizontal drag gets treated as if it is on a boundary).

It should be possible to do this contraction by dragging horizontally near the middle of the diagram:

Relevant parts of the code:
https://github.com/homotopy-io/homotopy-rs/blob/ddbff0d4138ec644aaa8ea95b7b308e6cafa46d9/homotopy-web/src/app/diagram_svg.rs#L547
https://github.com/homotopy-io/homotopy-rs/blob/ddbff0d4138ec644aaa8ea95b7b308e6cafa46d9/homotopy-web/src/app/diagram_svg.rs#L490


Support primary key personalize column name at VoyagerBreadController.php

Laravel Version: 5.3.28
Voyager Version: 0.10.11
PHP Version: 5.6.28
Database Driver & Version:
Mysql  Ver 14.14 Distrib 5.7.16, for Linux (x86_64)
Client API library version => mysqlnd 5.0.11-dev

Description:
I got this error while trying to access a BREAD, i supossed that the issue was retaled to personalized primary key column.
Column not found: 1054 Unknown column 'id' in 'order clause' (SQL: select * from departamentoorder byid desc)
Then i track down till this class TCG\Voyager\Http\Controllers\VoyagerBreadController at line 44 where generate getting the collection ordered by "id" as default, i change this line:
$dataTypeContent = call_user_func([$model->orderBy($model->getKeyName(), 'DESC'), $getter]);
Please correct me if i'm wrong, if is not then i recomend this as a change since Eloquent supports customs primary key columns name Voyager should do it as well.
Regards.

Exactly, I was just going to write about this issue here when i saw yours. Voyager should support custom Primary Key names. Firstly i was going to change id with {$model->getKeyName()} everywhere but i thought it will be good if TCG team do it themselves.

I'm open for pull requests on this.

Got bit by this but on a table that's for continent lookups. It's an app I inherited in a table with just the continent_code and continent_name, so no timestamps or primary key.
The biter in the BREAD Controller is:

$dataTypeContent = call_user_func([
    $model->with($relationships)->orderBy($model->getKeyName(), 'DESC'),
        $getter,
    ]);

Voyager needs to remain agnostic around keys, which is why we use getKeyName().  Do you have anything in the model identifying your table's primary key? What is the primary key, the continent_code?

@fletch3555 Yes, setting the primary key to continent_code in the model is how I resolved it for them.
Totally agree on the need for an agnostic way via getKeyName(). I was thinking more around what a better DevX would be, because the error floored a failry-new-to-Laravel dev which just made me think that there could be a more graceful way to fail than Column not found: 1054 Unknown column 'id'.


Possible index out of bounds

Fixed a case that resulted in an index out of bounds exception when a
mention is the first part of the message.

<3


Error: SHA1 mismatch while installing

brew install sshcd
==> Installing sshcd from fraction/homebrew-formulae
==> Downloading https://raw.github.com/fraction/sshcd/master/sshcd
==> Downloading from https://raw.githubusercontent.com/fraction/sshcd/master/sshcd
######################################################################## 100,0%
Error: SHA1 mismatch
Expected: c988d9e9ae6c3ec73e891d9d265f7611e1bf9209
Actual: 509b0a62293793a03cb7bf6362e27a0b420bb5c6
Archive: /Library/Caches/Homebrew/sshcd-master
To retry an incomplete download, remove the file above.

Tried the installation on two different machines (both OS X 10.10.4) with the same result.

Thanks, just resolved this. Let me know if it gives you any trouble!

Great, thank you! :smiley:


chore: remove manifest.json, Version.php, and ServiceBuilder.php

PHP removed docs/manifest.json a few months ago, and src/Version.php and src/ServiceBuilder.php likewise will be removed in https://github.com/googleapis/google-cloud-php/pull/6210

The errors here seem unrelated to my changes, and also are appearing in other pull requests

@bshaffer I re-ran the tests and they passed. Seems like it was a transient issue with some dependent package.


v4.3.0 update

Update to v4.3.0 including removing all disables for HTTRPC

@stickz  not sure if there is anything else needed for the 4.3.0 migration but ya, lmk if there is anything else.


Spec out FastSync and StateSync

Will add more details shortly

I think, it makes more sense to at least consider writing a custom block-sync (aka fast-sync) reactor using libp2p instead of modifying the current blockchain reactors:
https://github.com/lazyledger/lazyledger-core/tree/master/blockchain
Alternatively, and the first thing we should investigate thoroughly: we could make the blockchain reactor load the block data from the IPFS data store instead of the tendermint store - which will only store headers moving forward: #182.
We would basically change this line and in the blockchain reactor to load the whole block (locally) from the IPFS datastore: https://github.com/lazyledger/lazyledger-core/blob/c48bd16994a9fb707c9e15bc76070c9a4eeb29a1/blockchain/v0/reactor.go#L181
Given that the blockchain reactor looks kinda horrible and the v2 is still not stable (ref: #309) and also not really straightforward to understand, we should probably write our own block-sync protocol in the long run. We should first think through if we can leverage the existing one first though as it is used in production for several years now.

ref: https://github.com/lazyledger/lazyledger-core/issues/191

Closing this for now. We will use tendermint more as a black box. in case we later merge core and celestia node into one node repo, this becomes relevant again.


[Feature Request] Night Mode/Theme

A dark gray theme for night mode that doesn't hurt the eyes so much.

Feature requests go here: https://draw.uservoice.com/forums/266072-feature-requests

Thx, I will leave this for reference: https://draw.uservoice.com/forums/266072-feature-requests/suggestions/13087449-dark-theme


Update libjuice to 0.7.1 to update libdatachannel

Describe the pull request
Updates libjuice to 0.7.1 to update libdatachannel to 0.12.0.

I'll fix this, I forgot to update the control file.

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
https://github.com/microsoft/vcpkg/pull/17077#discussion_r607447541
I'm quite lost, version formats everywhere.

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
#17077 (comment)
I'm quite lost, version formats everywhere.

Here you should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
#17077 (comment)
I'm quite lost, version formats everywhere.

Here you should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

Ok then, but why does NancyLi1013 want to use version-semver while we have the same version scheme ? e.g. X.Y.Z ?

Hi thanks, should I put something like:
"version": "0.7.1" or "version-semver": "0.7.1" ?
#17077 (comment)
I'm quite lost, version formats everywhere.

Here you should use "version", if you are confused about this, you can refer to the detailed meaning and difference here

Ok then, but why does NancyLi1013 want to use version-semver while we have the same version scheme ? e.g. X.Y.Z ?

Generally speaking, if every number of the version has meaning or there is an api change in the version update, you need to use version-semver. If the number of the version has no meaning, it is incremental or there is no API change, you need to use version, if it is generally a date. Need to use version-date

Generally speaking, if every number of the version has meaning or there is an api change in the version update, you need to use version-semver. If the number of the version has no meaning, it is incremental or there is no API change, you need to use version, if it is generally a date. Need to use version-date

Thanks for the explanation, I'll keep this in mind.


Docker on RPi 4 fail to run generate command - query-engine-debian-openssl-1.1.x (32bit OS)

Bug description
I'm trying to deploy a project with prisma2, nexus and graphql to a docker container on my raspberry pi 4. The node server crashes with an error: You most likely forgot to initialize the Prisma Client. Please run prisma generate and try to run it again. If that does not solve your problem, please open an issue.
If I run yarn prisma generate I receive a following error:
Get config<EMAIL_ADDRESS>1<EMAIL_ADDRESS>Syntax error: "(" unexpected

Any input is appreciated, thank you.
Dockerfile
FROM node:latest

RUN apt-get update && apt-get install --no-install-recommends --yes openssl

WORKDIR /app

COPY ./package.json .
COPY ./yarn.lock .

RUN yarn install

COPY . .

EXPOSE 4444

CMD yarn dev

Project dependencies
"dependencies": {
    "@nexus/schema": "^0.15.0",
    "@types/express": "^4.17.8",
    "@types/node": "^12.12.56",
    "apollo-server-express": "^2.17.0",
    "cookie-parser": "^1.4.5",
    "cross-env": "^7.0.2",
    "express": "^4.17.1",
    "graphql": "^14.7.0",
    "graphql-middleware": "^4.0.2",
    "graphql-shield": "^7.3.6",
    "jsonwebtoken": "^8.5.1",
    "nexus": "^0.26.1",
    "nexus-plugin-prisma": "^0.19.0",
    "ts-node": "^9.0.0",
    "typescript": "^4.0.2"
  },
  "devDependencies": {
    "ts-node-dev": "^1.0.0-pre.62"
  }

Can you please share the schema that you are using? We haven't actually never received a report of that RPC failing failing but might be related to a syntax error.
I don't have a raspberry pi 4 in hand so I can't test this. I will ask my coworkers after I have verified that the schema is fine.

@pantharshit00 here's the schema:
datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
}

enum Role {
    USER
    ADMIN
}

model User {
    id              String      @id @default(uuid())
    username        String      @unique
    password        String
    role            Role        @default(USER)
}

model Movie {
    id              String      @id @default(uuid())
    scId            String      @unique
    name            String
    year            Int
    poster          String
    imdb            String
    csfd            Int
    kodiId          Int
}

model TvShow {
    id              String      @id @default(uuid())
}

btw. running prisma generate on my notebook (mac os) works fine.

The model looks fine, now I will need to test it on a RPi4 somehow.

@pantharshit00 ok, thank you. I can try and look how to make the rpi, I have, accessible from the internet. If I manage to do that, I can send you ssh credentials.

@theboxer No need for that, we will figure this out. Thanks for reporting!

But please note that this would be a bit of low priority for us right now with no timeline. We would love to fix this but we also need to prioritise other important things first.

That's a nice devotion

I am ordering a Raspberry Pi 4

Thank you

Can you please also tell me which OS you are running on your Raspberry Pi? I will assume Raspberian but still please confirm.

Yup, raspbian, more specifically:
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian

I can reproduce this issue as well. I think this is being caused as raspbian is a 32bit operating system and we build the ubuntu binary for a 64bit ubuntu system. I am not sure if we want to support this.

If this is running on an RPi, keep in mind that's ARM architecture which I don't believe binaries are supplied for yet. There are notes in #861 regarding building your own binaries in the interim.

Excuse my ignorance, why is it so hard to provide pre-built binaries for ARM if the prisma engine is written in rust and rust compiles everywhere?

We are currently working on providing binaries for ARM. The reason this is not trivial is because the build process has to be integrated into our CI system. Our CI currently runs on x86 machines. In order to integrate we started to look into cross compiling. Support in Rust is good here but we also needed OpenSSL compiled for ARM to link against at build time. This was quite some work but we are nearing the finish line :-)

@mavilein Thank you so much for clarifying!

You probably already know but it is easily possible to compile arm on any platform with socker buildx (qemu)

We are currently working on providing binaries for ARM. The reason this is not trivial is because the build process has to be integrated into our CI system. Our CI currently runs on x86 machines. In order to integrate we started to look into cross compiling. Support in Rust is good here but we also needed OpenSSL compiled for ARM to link against at build time. This was quite some work but we are nearing the finish line :-)

Many thanks for taking this on. Any ~ETA when we can expect this to be available? Doesn't have to be stable, just "usable" :)

@kilrau ARM aarch64 ( I think which is basically arm64, different names by different vendors) binaries are available in the dev channel right now if you are interested.
Install the dev channel like so npm install @prisma/cli@dev @prisma/client@dev

@pantharshit00 what about ARMv7 (32bit) are those binaries also available?

Hello everyone here
At the current moment, we are not adding 32bit target in the official release pipeline.
But for Pi and ARMv7, I have put together this repository which has precompiled 32 bit engines for these platforms and you can use prisma via this in the meantime: https://github.com/pantharshit00/prisma-rpi-builds
This will build the engine on every stable release.

@pantharshit00 you saved me. with your binaries I successfully build my docker image which do prisma generate during build. Thank you so much.

I am closing this now, as there are no further plans to provide 32bit engine files, sorry.


Add mods on WAU.msi install

Proposed Changes

Same as included/excluded_app.txt, mods can be placed in the source location:

The mods will get copied during installation.

@KnifMelti for first install. Don't know if it can help. I was thinking of SCCM or Autopilot scenarios.

No -Force in copy?
Good you deletes mods on uninstall!

We can use "-force" to overwrite. Perhaps it's a good idea.
On upgrade, if you want to push new mods, you're right. I'll take a closer look at that. 😅

I made new tests on my WSB:

Installed msi 1.21.1
put custom mods in Mods WAU's location
enabled prerelease in regedit
run WAU
Custom mods still there after upgrade to 1.22.2-n ✅

Installed msi 1.21.1
put custom mods in Mods WAU's location
installed msi 1.22.2-n manually
Custom mods still there after upgrade ✅

Installed msi 1.21.1
put custom mods in Mods WAU's location
installed msi 1.22.2-n with Mods in root msi location
Custom mods still there after upgrade and the ones in 1.22.2-n replaced the 1.21.1 ones ✅

Uninstalled 1.22.2-n
Everything removed ✅

Im running Proxmox with a full Win11 as major test machine with rollback to snapshot afterwards, WSB for fast testing.
I'm in bed sick now so I'm not testing this 😉

GitHub Copilot says:
The selected line in the code is:
Copy-Item -Path $ModsFolder -Destination "$InstallPath" -Recurse

Even though the -Force parameter is not explicitly used, the destination can still be overwritten because of how Copy-Item operates in PowerShell. By default, Copy-Item will overwrite existing files in the destination if they have the same name as the source files. The -Recurse parameter ensures that all items and child items in the source directory are copied to the destination, which includes overwriting files if they already exist in the destination directory.

so, that's perfect, no? :p


Fix .env.example variable name for listen hostname

Example env file incorrectly called the listen hostname LISTEN_HOST.

Thank you, good catch.


Fix Openbravo logo to be properly displayed in users page

The logo provided in #587 appears as blank in the current ESLint website at least in Chrome. This commit fixes the Openbravo svg logo to be properly displayed on the users page . :sweat:

Hey there - it does look like it's currently broken. I just merged a PR that moves the file to assets/img/logos. Do you mind updating this PR?

Updated :smiley:


Add kwargs field to SignedTransaction

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
fixes https://github.com/valory-xyz/open-aea/issues/693
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b20ef46) 91.81% compared to head (482dddf) 91.81%.

Files
Patch %
Lines

aea/helpers/transaction/base.py
85.71%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%
==========================================
  Files         371      371
  Lines       29774    29800      +26
==========================================
+ Hits        27338    27361      +23
- Misses       2436     2439       +3

Flag
Coverage Δ

unittests
91.81% <85.71%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


BUGFIX: cainjector leaderelection defaults are missing

In https://github.com/cert-manager/cert-manager/pull/6345, I forgot to add the defaults for the cainjector leaderelection options.
The original defaults can be found here: https://github.com/cert-manager/cert-manager/blob/ba6268135d0f2ebea5f8eb29a57934f1acae15e2/internal/cmd/util/defaults.go.
Fixes https://github.com/cert-manager/cert-manager/issues/6808
Kind
/kind bug
Release Note
BUGFIX: cainjector leaderelection flag/ config option defaults are missing

/cherrypick release-1.14

/retest


Add sensible builtin defaults as reader preferences

🧰 Task
Add sensible default settings for common filetypes so that the file open dialog doesn't pop up on initial opening of common filetypes.
My plan is to add defaults for anything that builtin plugins can read. These preferences could then of course be removed/changed via the preferences dialog.

So I started looking at implementing this, but I actually don't necessarily think we should? I initially opened this issue based on discussion in community meeting, and I think it was @sofroniewn who originally suggested it.
However, working with a clean install of napari now, I think I prefer the existing behavior. The reader dialog only ever pops up when there's a choice to be made. This means if you just clean install napari, you can already use all the builtins as you'd expect.
https://user-images.githubusercontent.com/17995243/151274336-cfd7ac5d-4a2f-42f1-8c8b-a5cb5b27dffa.mov
It's only once you install plugins that can also read what builtins can read that the dialog pops up and asks you to make a choice.
https://user-images.githubusercontent.com/17995243/151274611-8efe29e5-7c5a-4764-ae1f-f30c72a4d60b.mov
Adding default fie extension preference seems less usable because in that second recording, you'd have to actually go into preferences and remove the association before you could use your freshly installed plugin.
I'm curious whether now that the reader dialog has been out in the wild and people have had a chance to play with it, we still think we'd like to add default associations? Pinging @jni who liked this issue before, and @nclack and @tlambert03 who are also familiar with the work, but I'd love to get feedback from anyone who's interacted with the dialog as is.

The reader dialog only ever pops up when there's a choice to be made.

Seems pretty convincing to me.

Ok yeah, i have actually given this more thought after I started using the new release too and quite like the current behavior. thanks for looking into it more - i think you've made a pretty compelling case though that we shouldn't do this. curious what others think, but right now i'd be fine with just closing this.

I like the current behavior too after using it a bit!  thanks @DragaDoncila!

Btw... so we know what happens if the previously selected plugin has been uninstalled in the meantime?  I forget if that was handled

Btw... do we know what happens if the previously selected plugin has been uninstalled in the meantime? I forget if that was handled

If for whatever reason we can't open the file with the associated plugin, we present the dialog to the user (even if there's only one choice remaining) e.g.
https://user-images.githubusercontent.com/17995243/151281429-b269f2ba-8e8f-47f1-bae0-50c32f551ffe.mov
It's up to them at that stage if they want to overwrite the association with the remaining plugin, cancel the file open and figure out where their plugin went, etc.

Thanks everyone for weighing in. I will leave this issue open overnight in case someone dissents, and will otherwise close tomorrow morning.


.eh_frame: Bubble up DWARF expressions and value registers

And print them accordingly. This implementation mostly comes from this commit: https://github.com/parca-dev/parca-agent/pull/744/commits/e1ac8c62bc6a2715a170b095ae5e198f0e104a74, but also cleans up the code to make it less confusing and adds some assertions in the form of panics to ensure that things are working the way we expect. We might change this in the future once this code is more battle-tested.
The tables have been regenerated and tested in https://github.com/parca-dev/testdata/commit/483300c38df358af9aca8938b648953723c3f75c
Signed-off-by: Francisco Javier Honduvilla Coto<EMAIL_ADDRESS>

LGTM :tada:


CLIMATE-747 - Adding configuration files as an example of NASA's downscaling project

A new folder, NASA_downscaling_project_Part1 has been added with four yaml (configuration) files in RCMES/configuration_files.

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Failed.

These config files look good for the Dynamic Downscaling I Tutorial.


feat: add pause handeling game_window.c

Randomly found this repo in the search tab, saw that you wanted to add a pause function to the game. This is just a couple lines of code that checks if player pressed P key to pause the game, then use another function that just handles pause events.
Not entirely sure it will work since I can't run the program to test it because main branch is missing a file called SDL_pixels.h >_>

Hi @PedroFellipeAntunes, I  will review it a bit later but the problem occurs on your PC, we didn't create any SDL_pixels.h so there is not a missing file in our repository. If you're on Windows, you should download SDL on WSL or in Linux.
Thanks for your contribution that's great !!

Btw, can you do something like this if you succeed to run the program ? Thanks a lot :)

@PedroFellipeAntunes Keep us updated if you still work on the issue.


Add local authority name to the project information list

We currently show the local authority name in the at-a-glance summary list, we want to include it in the full project information list as well.

 Add local Authority details to Project Information


"Please Leave a Review"

Upon payment permit generation the bot should say something like "If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!"

Perhaps we can do a lottery to give people a reason to press the buttons.

so, just quick question. should I add "If you enjoy the ...." label before the "Permitted" label is added?

/assign

/wallet 0x9e4EF4353C928cD3eb473E8f12aeCF58C208ef40

@pavlovcik! so, just quick question. should I add "If you enjoy the ...." comment before the "Permitted" label is added to that issue and the issue closed?

I would put it at the very end, so after the Permitted label is added!

yeah, seems I did it right.


when i use PKCE, i failed to get /well-known/openid-configuration  because of a cors error

Describe the bug
i'm using pkce with vue  +  oidc-cllient-ts
but  the corsFilter is not included in the filter chain

Request received for GET '/.well-known/openid-configuration':
org.apache.catalina.connector.RequestFacade@395a9811
servletPath:/.well-known/openid-configuration
pathInfo:null
headers:
user-agent: PostmanRuntime/7.29.2
accept: /
postman-token: b49536ef-3493-4157-b7a0-30a1c8138789
host: localhost:8080
accept-encoding: gzip, deflate, br
connection: keep-alive
cookie: JSESSIONID=5B9D8005A1DE4268AB06CE6CFA995F47
Security filter chain: [
DisableEncodeUrlFilter
WebAsyncManagerIntegrationFilter
SecurityContextPersistenceFilter
ProviderContextFilter
HeaderWriterFilter
CsrfFilter
LogoutFilter
OAuth2AuthorizationEndpointFilter
OidcProviderConfigurationEndpointFilter
NimbusJwkSetEndpointFilter
OAuth2AuthorizationServerMetadataEndpointFilter
OAuth2ClientAuthenticationFilter
UsernamePasswordAuthenticationFilter
DefaultLoginPageGeneratingFilter
DefaultLogoutPageGeneratingFilter
BearerTokenAuthenticationFilter
RequestCacheAwareFilter
SecurityContextHolderAwareRequestFilter
AnonymousAuthenticationFilter
SessionManagementFilter
ExceptionTranslationFilter
FilterSecurityInterceptor
OAuth2TokenEndpointFilter
OAuth2TokenIntrospectionEndpointFilter
OAuth2TokenRevocationEndpointFilter
OidcUserInfoEndpointFilter
]

Describe the bug i'm using pkce with vue + oidc-cllient-ts
but the corsFilter is not included in the filter chain
Request received for GET '/.well-known/openid-configuration':
org.apache.catalina.connector.RequestFacade@395a9811
servletPath:/.well-known/openid-configuration pathInfo:null headers: user-agent: PostmanRuntime/7.29.2 accept: / postman-token: b49536ef-3493-4157-b7a0-30a1c8138789 host: localhost:8080 accept-encoding: gzip, deflate, br connection: keep-alive cookie: JSESSIONID=5B9D8005A1DE4268AB06CE6CFA995F47
Security filter chain: [ DisableEncodeUrlFilter WebAsyncManagerIntegrationFilter SecurityContextPersistenceFilter ProviderContextFilter HeaderWriterFilter CsrfFilter LogoutFilter OAuth2AuthorizationEndpointFilter OidcProviderConfigurationEndpointFilter NimbusJwkSetEndpointFilter OAuth2AuthorizationServerMetadataEndpointFilter OAuth2ClientAuthenticationFilter UsernamePasswordAuthenticationFilter DefaultLoginPageGeneratingFilter DefaultLogoutPageGeneratingFilter BearerTokenAuthenticationFilter RequestCacheAwareFilter SecurityContextHolderAwareRequestFilter AnonymousAuthenticationFilter SessionManagementFilter ExceptionTranslationFilter FilterSecurityInterceptor OAuth2TokenEndpointFilter OAuth2TokenIntrospectionEndpointFilter OAuth2TokenRevocationEndpointFilter OidcUserInfoEndpointFilter ]

Can you provide me with a demo to learn? Recently, I have also been learning about this integration, including front and back, thank you!

@jgrandja I have been seeing similar CORS error when I try to use openId option with Angular UI and not able to get .well-know/openid-configuration without CORS error

Thank you so much @jgrandja, I updated my corsConfigurationSource method with the example from the link you shared. It works now. I was using it slightly different.  Much appreciated


ARTEMIS-1162: Make new TimedBuffer Configurable

Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable.
https://issues.apache.org/jira/browse/ARTEMIS-1162
Rename new version of TimedBuffer to AdaptingTimedBuffer (and tests)
Add back old version of TimedBuffer to FixedTimedBuffer (and tests)
Extract shared public interface
Add configuration option to toggle between which TimedBuffer to user, in broker.xml "journal-timed-buffer-type=[FIXED,ADAPTING]"

@franz1981 I hope you don't mind me doing this, just as the new timed buffer work you've done, whilst benchmarked we won't get any proper real use feedback till systems hit production, and just want to mitigate risks.
Also it will make less risky other changes, such as the IOLimiter.
Idea would be to add an extra timed buffer type enum, for your IOLimiter version also.

@michaelandrepearce Nope, no problem for me...but I'm not 100% sure is the best way to do it: changing the new one to be like the original one is a matter of 1 line change and a boolean flag to be put in the right spot.
Instead of having:
if (checkpoint || currentPendingSyncs >= estimatedOptimalBatch) {

Need to be changed into:
if (checkpoint || (smartCoalescing && currentPendingSyncs >= estimatedOptimalBatch)) {

Finished.
Now you have one implementation that cover the 2 behaviours.
wdyt?

@michaelandrepearce And about loosing some tests, it is not a big deal; the deleted ones has some issues, so it has no practical effect to have them deleted.
On https://github.com/franz1981/activemq-artemis/tree/timed_buffer_iops_test the shouldNotFlusgUntilTimeout test shows that with the original implementation was possible to go out of IOPS too.

I actually started with a boolean flag option, but then thought about the other bits being added and before we know it we'd have quite a few flags which equate to lots of config options to be added in broker.xml
Where as having an enum from a user perspective means you simply define which timed buffer type you want, and is a little more plain English with what you're selecting.
Maybe I can see if I can make the enum for config so we don't explode the config paeans but re work the reintroduction of the old behaviour like you propose.

"paeans" wow my iphone is doing its best today!
I meant parameters

For me is ok to have an enum, but I mean that it doesn't make sense to have 2 TimedBuffer implementations.
You can have one with a flag in the constructor to disable the coalescing: this way the behaviours will be the same as before, but with off heap batch buffer + bulk copy too.
Then you can you an enum to set that flag or not: it is simpler to maintain IMHO.
It is different if you want to maintain the older things that wasn't good (heap buffers + no bulk copy)...this is what you're proposing?

I agree with you, thanks for the comments :) it's always good to have the second opinions :). Let me re work it and I'll msg once ready for another review :)

@michaelandrepearce I've updated the dev list post with the latest results on the new TimedBuffer vs old and with/without the IO limiter to let other devs to ask/propose/give advice about them if possible.
As you said, is always good to have more opinions :100:

@michaelandrepearce  I removed that update because I've noticed that writing on dev list using Gmail produce better images than using nabble to do the same :(

@franz1981 I did re work this, but based on the discussion thread i may kill it and the jira as clement is for an all or nothing approach, but with the caveat of having a lot of testing some.

@michaelandrepearce I don't know honestly how to deal with it: effectively I didn't see any regressions with maxed out writes on disks (only a couple of SSD right now)...
So maybe makes sense to test it more and fix it (reverting it? is one option, but not the best one IMHO) if it won't work as expected.
Right now I've only a great improvement in throughput, especially with concurrent writers...

@franz1981 and here in lies the issue, that the project doesn't currently have a set of agreed performance metrics for different end 2 end scenarios, that are run automatically and reported each release.
I like micro benchmarks as they help isolate a problem, and quickly test if the changes look promising and the best we have today.
As we move to look at other perf improvements without the end 2 end scenarios reporting perf metrics version to version, some changes may start to even step on each other, e.g. one fix may actually regress another, e.g. the classical, batching can improve throughput very easily but trades it for latency.

@michaelandrepearce

the project doesn't currently have a set of agreed performance metrics for different end 2 end scenarios, that are run automatically and reported each release
:100:
some changes may start to even step on each other, e.g. one fix may actually regress another
Having a default load generator with different test cases against agreed metrics to make easier identify evident performance changes is a nice idea indeed!
IMHO the hardest part (for me! I'm giving space to devs more math skilled than me) is to identify the responsibility of a single point of change in a end 2 end result.

I suspect that having proper performance counters on the broker to be collected by user/devs using their own tests (ie with their SLAs in mind) are an additional tool that could help to identify isolated code changes perf changes.
I smell this could be a good forum discussion to start some thought around this :)

@michaelandrepearce

batching can improve throughput very easily but trades it for latency.

Agree for my old experiences, but I admit that...depends :+1:
https://mechanical-sympathy.blogspot.it/2011/10/smart-batching.html
https://vanilla-java.github.io/2016/07/09/Batching-and-Low-Latency.html

I like the first link, much clearer and concisely written to explain the idea.
Just need to prove and get the stats like in the second :)

FYI I've closed the JIRA as won't fix.

Happy to hear that!I think that there are few people that could explain that concept sound and clear like Martin :)
What I've implemented on TimedBuffer is something similar but using the queue of the executor service that push the writes against the buffer :P

@michaelandrepearce
Re performance metrics:
it is a work in progress, but I've built something to provide real time instrumentation on the journal performances: https://github.com/franz1981/activemq-artemis/tree/real_time_journal_latency
Right now I need to:

define a better lifecycle of the instrumentation -
add a console command that collect the samples using the IPC RCU buffer I've built, translating them in a human readable form

The cool thing is that it could be enabled in production system too with no performance impact.


Functions not being defined in Neovim

Hello. Unless I'm doing something wrong in my config, I can't seem to get Plug working with neovim. I'm using windows, and have ~\vimfiles\autoload in my runtime path with plug.vim inside that folder. However, neovim gives me errors saying that plug#begin(), Plug, and plug#end are undefined. I also have no access to :PlugInstall or anything like that.

And never mind. Figured out my directory structure was wrong. My bad

@zovt Ya, unfortunately that XDG move strikes again. I'm not sure it was entirely warranted given all the confusion it has likely lead to.

Wasn't the XDG move. Since I'm on Windows I'm not sure that really applies to me anyways. My problem was that ~\vimfiles\autoload was the actual folder in my rtp, so it was looking for an autoload folder inside that one.

@zovt Ah, heh. Ok then, glad you got it sorted then.


Mismatch sequence names in output

Hi! Thanks for the interesting and fast tool!
I was testing it on the GCF_000001735.4 A. thaliana assembly and I noticed a mismatch between the sequence names in the output files.
This is the fasta index (.fai) for the input genomes after extracting only the five chromosomes:
NC_003070.9	30427671	56	60	61
NC_003071.7	19698289	30934920	60	61
NC_003074.8	23459830	50961579	60	61
NC_003075.7	18585056	74812472	60	61
NC_003076.8	26975502	93707344	60	61

And with ModDotPlot (@ commit c1388eba02c4d8f4d34b99b5d8f6c250a455bd28) I ran the following command:
moddotplot static -f GCF_000001735.4_TAIR10.1_genomic.chrs.fna

Unexpectedly, this was the output. Notice the mismatch between the filename and the content of the files.  This is a bug where a multifasta file would be sorted by genome size, but the names would be sorted by order of entry.
This should be patched in latest commit c1d945a

Thank you! I reran it with the v0.8.2 and it looks perfect now :)


[FIX] [Add-Commit] Attributes

IN BECanvasComponent
Remove:
[Parameter]
public long Height { get; set; }

[Parameter]
public long Width { get; set; }

Add:
[Parameter(CaptureUnmatchedValues = true)]
public Dictionary<string, object> InputAttributes { get; set; }

IN BECanvas.razor
Remove:
<canvas id="@Id" width="@Width" height="@Height" @ref="_canvasRef"></canvas>
Add:
<canvas id="@Id" @attributes="InputAttributes" @ref="_canvasRef"></canvas>
Finish, use:
<BECanvas style="height: 250px; flex: auto" @ref="_canvasReference" ></BECanvas >
<BECanvas Height="@SizeY" Width="@SizeX" @ref="_canvasReference" />

I have created PR #119 that does exactly as you described.


You get smithing EXP even if you have no bars

This is a big bug. If you try to smith something where you don't have the sufficient bars... your smithing level will raise.

👍


NanoHTTPD uri router

Hi guys,
Is there any plan to add simple routing mechanism in NanoHTTPD.
Something as server.add("/user/:id", SomeClass.class);
SomeClass can have methods get(), post, put, etc. and these methods can get Map<String, String> urlParams with all other things coming from IHTTPSession.
I can try to implement such functionality.

No plans for now. Since NanoHTTPD is a generic HTTP server library instead of an application server, routing would be difficult to make generic enough. That said, it should be quite easy to implement a custom one by subclassing and overriding serve(). If you manage to write a small but functional implementation, we'd be happy to include one to samples/.

Ok, anyway I have to write it so I can use this cute project to serve some rest services in Android. Let's see what will emerge from that :) for the samples/ folder.

What will be the best approach for this sample? Should I make a fork, put the new java files in samples/ and make push request?

that would be great!

Pull request created :)

ok, I will take a look this weekend. maybe this is worth a own module when we reduce it to one class ;-)

Yes it can be reduced to a single class, but because is in samples I kept the classes separate to be more readable.Of course if a new modules is created... a single class is better :)

I had an idea and I gave some thoughts about it and came out with the below. By extending the NanoHTTP and providing these 2 methods. This approach will adopt the nodejs and express approach on handling incoming request. The first "Router" that has a match URI (AKA url path) and return a response will have its results served. This should effectively decoupled the serving of content and server itself. Further more we can create specialized router class to handle the request uniquely. For example respond in JSON rather than text/html, serve up static content, perform accesslogs functionality etc
void loadRouters() {
    String[] routerArrayClasses = applicationContext.getResources().getStringArray(R.array.router);
    for (String inst : routerArrayClasses) {
        try {
            Routers r = (Routers) Class.forName(inst).newInstance();
            r.setContext(this.applicationContext);
            this.routerArray.add(r);
        } catch (ClassNotFoundException cnfe) {
            Log.w(TAG, "Unable to Instantiate " + inst);
        } catch (InstantiationException ie) {
            Log.w(TAG, "Unable to Instantiate " + inst);
        } catch (IllegalAccessException iae) {
            Log.w(TAG, "Unable to Instantiate " + inst);
        }
    }
    Log.i(TAG, "Router Count: " + this.routerArray.size());
}

@Override
/**
 * Adopt the NODE Express Routing approach to handling request.
 * Default behavior is to return a not found.
 */
public Response serve(IHTTPSession session) {
    Method method = session.getMethod();
    Response res = null;
    try {
        for (Routers r : routerArray) {
            Log.v(TAG, "Class " + r.getClass().getName());
            switch (method) {
                case GET:
                    res = r.doGet(session);
                    break;
                case PUT:
                    res = r.doPut(session);
                    break;
                case POST:
                    res = r.doPost(session);
                    break;
                case DELETE:
                    res = r.doDelete(session);
                    break;
                case HEAD:
                    res = r.doHead(session);
                    break;
                case OPTIONS:
                    res = r.doOptions(session);
                    break;
                case TRACE:
                    res = r.doTrace(session);
                    break;
                case CONNECT:
                    res = r.doConnect(session);
                    break;
                case PATCH:
                    res = r.doPatch(session);
                    break;
                default:
                    res = r.doGet(session);
            }
            if (res != null) return res;
        }
    } catch (Exception e) {
        Log.e(TAG, "", e);
        return new ServerError().doGet(session);
    }
    return new NotFound().doGet(session);
}

The pull request I submitted is inspired of Node.js too. It is slightly different but the idea is the same. You can check the code.

sorry that it takes that long, I have some "urgent" other projects ... @elonen  I think the sample is worth making a module and maybe name them "nanolets" ?

@Vnnv also mentioned he/she was inspired by the Nodejs, Express approach. I was similarly inspired. So I feel it might be appropriate to pay tribute to it somehow. Once it is incorporated I hope all that is required to provide a more comprehsive server solution is to configure the mapping and implement the handler.
===================================
To live is to grow. To grow is to Learn.
  From: Richard van Nieuwenhoven<EMAIL_ADDRESS>
To: NanoHttpd/nanohttpd<EMAIL_ADDRESS>Cc: James Tang<EMAIL_ADDRESS>Sent: Tuesday, 4 August 2015, 12:34
Subject: Re: [nanohttpd] NanoHTTPD uri router (#214)
sorry that it takes that long, I have some "urgent" other projects ... @elonen I think the sample is worth making a module and maybe name them "nanolets" ? —
Reply to this email directly or view it on GitHub.

I have created a routable nanohttpd: https://github.com/synapticloop/routemaster

pull requests included and adapted to one class with a more compact logic.


Remove uid/gid mapping limit depend on kernel

Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

LGTM

Updated.

LGTM

LGTM


JavaScript error and crash when a Prolog exception is expected

I frequently get the following JavaScript error and crash when a Prolog exception is expected:
/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2171
			var app = this.args[i].apply(subs);
			                       ^

TypeError: this.args[i].apply is not a function
    at Term.apply (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2171:27)
    at Term.apply (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2171:27)
    at Object.unify (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:4425:30)
    at Thread.step (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2836:20)
    at Thread.again (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2921:13)
    at Object.callback (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:5034:12)
    at Thread.again (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2936:13)
    at Thread.answer (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2881:8)
    at catch/3 (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:5036:12)
    at Thread.step (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2823:13)

Does this stack trace gives enough hints on the bug?

This crash happens notably anytime there's an instantiation error in an arithmetic expression that's being evaluated.

I can't reproduce this error. Do you know any specific goal for which it fails? If not, it would also help me to know how to reproduce the error using Logtalk.

Thanks for looking into it. Try e.g. X is sin(_). or something a bit more complex: X is sin(abs(3 + _))..

I am not getting any error with the latest version. Maybe it has been fixed with the recent PRs?

In the particular case of my pull requests, none addressed this issue. Did you also tried with a predicate definition in a consulted file that calls one of those test goals? That was the context where the crash happened when I report this issue.

I can still reproduce the crash using the abs/1 arithmetic function tests:
$ export NODE_PATH=/Users/pmoura/Documents/Logtalk/tp/node_modules
$ taulgt
...
?- {tester}.
%
% tests started at 0(-)00(-)00(,) 00(:)00(:)00
%
% running tests from object tests
% file(:) (/)Users(/)pmoura(/)Documents(/)Logtalk(/)logtalk3(/)tests(/)prolog(/)functions(/)abs_1(/)tests.lgt
%
% iso_abs_1_01(:) success
% iso_abs_1_02(:) success
% iso_abs_1_03(:) success
% iso_abs_1_04(:) success
/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2176
			var app = this.args[i].apply(subs);
			                       ^

TypeError: this.args[i].apply is not a function
    at Term.apply (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2176:27)
    at Term.apply (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2176:27)
    at Object.unify (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:4431:30)
    at Thread.step (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2841:20)
    at Thread.again (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2927:13)
    at Object.callback (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:5052:12)
    at Thread.again (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2942:13)
    at Thread.answer (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2887:8)
    at catch/3 (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:5054:12)
    at Thread.step (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2828:13)

But I got a detail wrong. The crash happens with a non-evaluable argument to an arithmetic function. However, I have been unable so far to reduce the crash to a minimal example. The error may be instead on the propagation of the exception.


Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts'

Current Behavior
TSDX uses rollup-plugin-typescript2 to compile and check TypeScript files. Due to certain anomalies specific to this plugin, tsdx users are unable, inter alia, to use additional rollup plugins that contain async/await syntax (e.g., rollup-plugin-visualizer) without a workaround. See https://github.com/ezolenko/rollup-plugin-typescript2/issues/105; see also https://github.com/palmerhq/tsdx/pull/183#issuecomment-528312690.
Unfortunately, the workaround, aptly titled, objectHashIgnoreUnknownHack, 'can potentially make cache stale,' due to the fact that rollup-plugin-typescript2 uses a hash of the entire rollup configuration to facilitate cache invalidation. See https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412986356. As a workaround for the workaround, users are encouraged to bypass the cache completely by setting clean to true in their rollup configurations. See https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412955438.

The plugin uses rollup config as part of cache key. object-hash is used to generate a hash, but it can't hash certain elements at the moment. Setting this option to true will make object-hash ignore unknowns, at the cost of not invalidating the cache if ignored elements are changed. Only enable this if you need it (Error: Unknown object type "asyncfunction" for example) and make sure to run with clean: true once in a while and definitely before a release. (See #105)

Desired Behavior
As a tsdx user, I should be able to extend tsdx's rollup configuration to include additional plugins that use async/await syntax without a workaround and, especially, without having to worry whether my cache is stale.
Suggested Solution
Replace rollup-plugin-typescript2 with rollup-plugin-ts.
Who does this impact? Who is this for?
While #183 added support for extending tsdx's rollup configuration, making it easy to add additional rollup-plugins, there is no easy way to swap out tsdx's default plugin choices. See, e.g., infra, Alternative Solutions. Thus, tsdx users are, more or less, blocked from using any rollup plugin that contains async/await code. As the async/await syntax continues to gain popularity, it is likely that this issue will affect more and more tsdx users.
Describe alternatives you've considered
With #183, tsdx users can hack tsdx's default plugin choices (example below) to either (1) to modify the rollup-plugin-typescript2 configuration as described above, or (2) swap out the plugin for rollup-plugin-ts; however, neither approach is ideal.
const ts = require("@wessberg/rollup-plugin-ts");

module.exports = {
  rollup(config, options) {
    config.plugins = config.plugins.map(plugin => {
      if (plugin && plugin.name === "rpt2") {
        return ts({
          tsconfig: tsconfig => ({
            ...tsconfig,
            target: "esnext",
            sourceMap: true,
            declaration: true,
            jsx: "react"
          }),
          transpiler: "babel"
        });
      }
      return plugin;
    });

   ...

    return config;
  }
};

For diagnostic purposes, a working example using the above swap-out hack can be found here:  https://github.com/medelman17/tsdx-monorepo-template
Additional context
The rollup-plugin-typescript2 plugin appears to have several additional bugs that may cause tsdx users pain. For example, to enable code splitting, users must also employ an additional workaround, setting rollupCommonJSResolveHack to true. But see:

On windows typescript resolver favors POSIX path, while commonjs plugin (and maybe others?) uses native path as module id. This can result in namedExports being ignored if rollup happened to use typescript's resolution. Set to true to pass resolved module path through resolve() to match up with rollup-plugin-commonjs. rollup-plugin-commonjs fixed this in 10.1.0, so projects using this option who update to new version will be broken again. This also works around the similar bug affecting code splitting (see rollup/issues/3094).

https://github.com/ezolenko/rollup-plugin-typescript2

thanks for filing. no strong feelings on this one, leaving for jared

Thanks for the write up. Let’s make the change
--
Jared

From: Michael Edelman<EMAIL_ADDRESS>Sent: Sunday, September 8, 2019 4:26 AM
To: palmerhq/tsdx
Cc: Subscribed
Subject: [palmerhq/tsdx] Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts' (#200)
Current Behavior
TSDX uses rollup-plugin-typescript2 to compile and check TypeScript files. Due to certain anomalieshttps://github.com/ezolenko/rollup-plugin-typescript2/issues/105 specific to this plugin, tsdx users are unable, inter alia, to use additional rollup plugins that contain async/await syntax (e.g., rollup-plugin-visualizerhttps://github.com/btd/rollup-plugin-visualizer) without a workaround. See ezolenko/rollup-plugin-typescript2#105https://github.com/ezolenko/rollup-plugin-typescript2/issues/105; see also #183 (comment)https://github.com/palmerhq/tsdx/pull/183#issuecomment-528312690.
Unfortunately, the workaround, aptly titled, objectHashIgnoreUnknownHack, 'can potentially make cache stale,' due to the fact that rollup-plugin-typescript2 uses a hash of the entire rollup configuration to facilitate cache invalidation. See ezolenko/rollup-plugin-typescript2#105 (comment)https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412986356. As a workaround for the workaround, users are encouraged to bypass the cache completely by setting clean to true in their rollup configurations. See ezolenko/rollup-plugin-typescript2#105 (comment)https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412955438.
The plugin uses rollup config as part of cache key. object-hash is used to generate a hash, but it can't hash certain elements at the moment. Setting this option to true will make object-hash ignore unknowns, at the cost of not invalidating the cache if ignored elements are changed. Only enable this if you need it (Error: Unknown object type "asyncfunction" for example) and make sure to run with clean: true once in a while and definitely before a release. (See #105https://github.com/palmerhq/tsdx/issues/105)
Desired Behavior
As a tsdx user, I should be able to extend tsdx's rollup configuration to include additional plugins that use async/await syntax without a workaround and, especially, without having to worry whether my cache is stale.
Suggested Solution
Replace rollup-plugin-typescript2 with rollup-plugin-tshttps://github.com/wessberg/rollup-plugin-ts.
Who does this impact? Who is this for?
While #183https://github.com/palmerhq/tsdx/pull/183 added support for extending tsdx's rollup configuration, making it easy to add additional rollup-plugins, there is no easy way to swap out tsdx's default plugin choices. See, e.g., infra, Alternative Solutions. Thus, tsdx users are, more or less, blocked from using any rollup plugin that contains async/await code. As the async/await syntax continues to gain popularity, it is likely that this issue will affect more and more tsdx users.
Describe alternatives you've considered
With #183https://github.com/palmerhq/tsdx/pull/183, tsdx users can hack tsdx's default plugin choices (example below) to either (1) to modify the rollup-plugin-typescript2 configuration as described above, or (2) swap out the plugin for rollup-plugin-ts; however, neither approach is ideal.
const ts = require("@wessberg/rollup-plugin-ts");
module.exports = {
rollup(config, options) {
config.plugins = config.plugins.map(plugin => {
if (plugin && plugin.name === "rpt2") {
return ts({
tsconfig: tsconfig => ({
...tsconfig,
target: "esnext",
sourceMap: true,
declaration: true,
jsx: "react"
}),
transpiler: "babel"
});
}
return plugin;
});
...
return config;

}
};
Additional context
The rollup-plugin-typescript2 plugin appears to have several additional bugs that may cause tsdx users pain. For example, to enable code splitting, users must also employ an additional workaround, setting rollupCommonJSResolveHack to true. But see:
On windows typescript resolver favors POSIX path, while commonjs plugin (and maybe others?) uses native path as module id. This can result in namedExports being ignored if rollup happened to use typescript's resolution. Set to true to pass resolved module path through resolve() to match up with rollup-plugin-commonjs. rollup-plugin-commonjs fixed this in 10.1.0, so projects using this option who update to new version will be broken again. This also works around the similar bug affecting code splitting (see rollup/issues/3094).

https://github.com/ezolenko/rollup-plugin-typescript2

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/palmerhq/tsdx/issues/200?email_source=notifications&email_token=AA67IG56KPNVRDJDOT6KTNDQIRPGZA5CNFSM4IUR6GM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ7QNRQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA67IG3H2RTP3QMONDSHENTQIRPGZANCNFSM4IUR6GMQ.

Sounds good. I’ll submit a PR by EOW.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jared Palmer<EMAIL_ADDRESS>Sent: Sunday, September 8, 2019 3:12:37 AM
To: palmerhq/tsdx<EMAIL_ADDRESS>Cc: Michael Edelman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [palmerhq/tsdx] Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts' (#200)
Thanks for the write up. Let’s make the change
--
Jared

From: Michael Edelman<EMAIL_ADDRESS>Sent: Sunday, September 8, 2019 4:26 AM
To: palmerhq/tsdx
Cc: Subscribed
Subject: [palmerhq/tsdx] Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts' (#200)
Current Behavior
TSDX uses rollup-plugin-typescript2 to compile and check TypeScript files. Due to certain anomalieshttps://github.com/ezolenko/rollup-plugin-typescript2/issues/105 specific to this plugin, tsdx users are unable, inter alia, to use additional rollup plugins that contain async/await syntax (e.g., rollup-plugin-visualizerhttps://github.com/btd/rollup-plugin-visualizer) without a workaround. See ezolenko/rollup-plugin-typescript2#105https://github.com/ezolenko/rollup-plugin-typescript2/issues/105; see also #183 (comment)https://github.com/palmerhq/tsdx/pull/183#issuecomment-528312690.
Unfortunately, the workaround, aptly titled, objectHashIgnoreUnknownHack, 'can potentially make cache stale,' due to the fact that rollup-plugin-typescript2 uses a hash of the entire rollup configuration to facilitate cache invalidation. See ezolenko/rollup-plugin-typescript2#105 (comment)https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412986356. As a workaround for the workaround, users are encouraged to bypass the cache completely by setting clean to true in their rollup configurations. See ezolenko/rollup-plugin-typescript2#105 (comment)https://github.com/ezolenko/rollup-plugin-typescript2/issues/105#issuecomment-412955438.
The plugin uses rollup config as part of cache key. object-hash is used to generate a hash, but it can't hash certain elements at the moment. Setting this option to true will make object-hash ignore unknowns, at the cost of not invalidating the cache if ignored elements are changed. Only enable this if you need it (Error: Unknown object type "asyncfunction" for example) and make sure to run with clean: true once in a while and definitely before a release. (See #105https://github.com/palmerhq/tsdx/issues/105)
Desired Behavior
As a tsdx user, I should be able to extend tsdx's rollup configuration to include additional plugins that use async/await syntax without a workaround and, especially, without having to worry whether my cache is stale.
Suggested Solution
Replace rollup-plugin-typescript2 with rollup-plugin-tshttps://github.com/wessberg/rollup-plugin-ts.
Who does this impact? Who is this for?
While #183https://github.com/palmerhq/tsdx/pull/183 added support for extending tsdx's rollup configuration, making it easy to add additional rollup-plugins, there is no easy way to swap out tsdx's default plugin choices. See, e.g., infra, Alternative Solutions. Thus, tsdx users are, more or less, blocked from using any rollup plugin that contains async/await code. As the async/await syntax continues to gain popularity, it is likely that this issue will affect more and more tsdx users.
Describe alternatives you've considered
With #183https://github.com/palmerhq/tsdx/pull/183, tsdx users can hack tsdx's default plugin choices (example below) to either (1) to modify the rollup-plugin-typescript2 configuration as described above, or (2) swap out the plugin for rollup-plugin-ts; however, neither approach is ideal.
const ts = require("@wessberg/rollup-plugin-ts");
module.exports = {
rollup(config, options) {
config.plugins = config.plugins.map(plugin => {
if (plugin && plugin.name === "rpt2") {
return ts({
tsconfig: tsconfig => ({
...tsconfig,
target: "esnext",
sourceMap: true,
declaration: true,
jsx: "react"
}),
transpiler: "babel"
});
}
return plugin;
});
...
return config;
}
};
Additional context
The rollup-plugin-typescript2 plugin appears to have several additional bugs that may cause tsdx users pain. For example, to enable code splitting, users must also employ an additional workaround, setting rollupCommonJSResolveHack to true. But see:
On windows typescript resolver favors POSIX path, while commonjs plugin (and maybe others?) uses native path as module id. This can result in namedExports being ignored if rollup happened to use typescript's resolution. Set to true to pass resolved module path through resolve() to match up with rollup-plugin-commonjs. rollup-plugin-commonjs fixed this in 10.1.0, so projects using this option who update to new version will be broken again. This also works around the similar bug affecting code splitting (see rollup/issues/3094).

https://github.com/ezolenko/rollup-plugin-typescript2

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/palmerhq/tsdx/issues/200?email_source=notifications&email_token=AA67IG56KPNVRDJDOT6KTNDQIRPGZA5CNFSM4IUR6GM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ7QNRQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA67IG3H2RTP3QMONDSHENTQIRPGZANCNFSM4IUR6GMQ.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/palmerhq/tsdx/issues/200?email_source=notifications&email_token=ADQ3VLJXFQPLH7OHKZE76HTQISQWLA5CNFSM4IUR6GM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FJR6I#issuecomment-529176825, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADQ3VLK6HYVZUKX36O7L7A3QISQWLANCNFSM4IUR6GMQ.

This switch will be amazing! :) I'm playing around in the last couple of days and the @wessberg plugin works beautifully. One huge benefit is that it bundles and tree-shakes the declarations files - no such thing possible until recently. And frees the road to use Babel for the rest. Which isn't exactly true, since when type-check tsc (and in your editor) will error. But at least that's until TypeScript 3.7.
I was working on a Rollup config that using it too. Some working example (with monorepo support) can be seen here (and the whole monorepo uses it too) https://github.com/tunnckoCore/configs/tree/master/packages/rollup-config. Usage is simple as
const config = require('@tunnckocore/rollup-config/config');

module.exports = config({ prod: true, monorepo: true }).concat(config({ prod: false, monorepo: true }));
// generating cjs, esm, umd, index.d.ts for each, and .map files

Amazing! I’ve submitted a PR (https://github.com/palmerhq/tsdx/pull/208) but having a hard time getting last two tests to pass. Would you be able to take a look and offer any insight you might have. Sounds like you’re way more versed than I am :-)
Get Outlook for iOShttps://aka.ms/o0ukef

From: Charlike Mike Reagent<EMAIL_ADDRESS>Sent: Sunday, September 15, 2019 10:58:16 PM
To: palmerhq/tsdx<EMAIL_ADDRESS>Cc: Michael Edelman<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [palmerhq/tsdx] Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts' (#200)
This switch will be amazing! :) I'm playing around in the last couple of days and the @wessberghttps://github.com/wessberg plugin works beautifully. One huge benefit is that it bundles and tree-shakes the declarations files - no such thing possible until recently. And frees the road to use Babel for the rest. Which isn't exactly true, since when type-check tsc (and in your editor) will error. But at least that's until TypeScript 3.7.
I was working on a Rollup config that using it too. Some working example (with monorepo support) can be seen here (and the whole monorepo uses it too) https://github.com/tunnckoCore/configs/tree/master/packages/rollup-config. Usage is simple as
const config = require('@tunnckocore/rollup-config/config');
module.exports = config({ prod: true, monorepo: true }).concat(config({ prod: false, monorepo: true }));
// generating cjs, esm, umd, index.d.ts for each, and .map files
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/palmerhq/tsdx/issues/200?email_source=notifications&email_token=ADQ3VLLUDUFLBYLRDIEODS3QJ3Y4RA5CNFSM4IUR6GM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6X736Y#issuecomment-531627515, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADQ3VLLB4V2WURZPWCAX5VTQJ3Y4RANCNFSM4IUR6GMQ.


Fix event count for multiple handlers

If multiple event handlers are registered for the same event, the counter is incremented before each handler. This results in filters like every: 10 to never match any events.

Good catch, thanks!

Could we have a test somehow? 🤔

@josevalim I'm currently testing it by always adding a second handler in the dummy loop, which causes the existing test to fail without the fix.
Maybe not the most elegant/obvious solution. I'm happy to refactor the test if you point me in the right direction (I'm very new to axon) 😅

I've added a test for the event counting. Let me know if this is OK or if you would like me to further refactor the test.

Actually, the test now passes even without the fix because I removed the dummy handlers. Let me re-add them again...


Add support for AES-256 and AES-192

Currently, supported symmetric cipher algorithms are DES, 3-DES.
This issue will be tracking the addition of support for AES-256.
( I am taking up the development for this ).
Potential pitfalls:

might need unrestricted policy jars. ( Applies for AES-192 and AES-256 )

Please do not close this

Hi!
What about supporting AES in GetCACaps in ScepServlet? Currently Capability enum misses it.
According to https://tools.ietf.org/html/draft-gutmann-scep-03, there is now "AES" keyword.

@oleg-alexeyev: can you create a PR?


Package versioning

With development picking up we need a better way of communicating changes to our users. I propose we:

Adopt semver and bump versions like so:

major

make a backwards-incompatible change to an existing macro or package option

minor

introduce a new macro
introduce a new package option
make a backwards-incompatible change to an existing macro or package option before 1.0.0

patch

backwards-compatible bug or documentation fixes

We can start at 0.1.0 because things are still in flux.

Obey LaTeX conventions and \ProvidePackage{dnd}{YYYY/mm/dd <version>}.

Compile the manual/example document for every release and attach it as a release artefact.

Maintain a changelog.

Note in the README that we adopted semver as of <date>.

Tools like bumpversion and github-release can automate most of the chore work.

Sounds like a plan. I am newer to github, so I need to do a bit of reading on releases and the like.

We might as well start at 0.6.0 as the readme has a "version" of 0.5.0.
I need to do a bit more reading on this. I assume <version> matches the version in bullet 1?
Yes, and add *.pdf to .gitignore.
Another thing I need to read up on how it fits into git.
Probably only need mention that is what we are doing along with the rules in 1.

Sure, the starting version doesn't matter too much. Semver communicates a relative difference in changes.
Yep. If you add \listfiles to the preamble, LaTeX will print all the included packages and versions. They vast majority seem to be YYYY/mm/dd or YYYY/mm/dd <version>.
Yep.
Constructing a changelog from Git is possible, but not particularly useful for end-users. Here is a guideline for maintaining one.
Sure, users can find the latest release easily.

Since we have, at least temporarily, cleared out all but one of the pull requests, I will try to put together a release over the weekend. @benwebber, if you would like to handle the LaTeX changes within the package (Update ProvidePackage with 0.6.0 and a date of October 1 and add example.pdf to .gitignore) it would be greatly appreciated.

Sure. Will be ready soon.


Cannot find clang-format-diff

OS: macOS 11.5.2
clang-format version 12.0.1, installed by Homebrew
But, error while using it:
$ ./scripts/apply-format -i --staged
Cannot find clang-format-diff which should be shipped as part of the same
package where clang-format is.

Please find out where clang-format-diff is in your distro and report an issue
at https://github.com/barisione/clang-format-hooks/issues with details about
your operating system and setup.

You can also specify your own path for clang-format-diff by setting the
$CLANG_FORMAT_DIFF environment variable, for instance:

    CLANG_FORMAT_DIFF="python /.../clang-format-diff.py" \
        ./scripts/apply-format

Any idea where it's actually installed?
What do these say:
ls -l $(which -a clang-format)

and:
find /usr/local/ -name clang-format-diff*

@barisione Still not found

You need to set the CLANG_FORMAT_DIFF environment variable to tell the script where to look. e.g.
export CLANG_FORMAT_DIFF="python3 /opt/homebrew/Cellar/clang-format/15.0.7/share/clang/clang-format-diff.py"


fix: Ingest main: actually initialize the connector

This brings back the connector initialization as was intended and got lost in a refactor.
Thanks @tomaarsen for catching this.

Looks good!


fix: entry chunk is array type

Support this situation
{
	entry: {
		main: ['a.js', 'b.js']
	}
}

I signed it!


[DC-2102] Adds AoU custom concepts for the Summer, Fall, and Winter Minute Surveys

looks good to me.

Should I add these concepts to the current vocabulary as we did earlier?

looks good to me.

Should I add these concepts to the current vocabulary as we did earlier?

Yes, I think that is expected.


Enable formatting packets

While debugging an issue, I wanted to create a fake monitor that would send packets of my own construction. To do that, I enabled Field and Packet to format values as well as parse them.

Ah, builds failing due to use of match. I put up #185 to bump Python to 3.11, but I'll take out the matches if you don't want to do that yet.

No need to do a release for this, at least not on my account. I was just using it for local testing and figure it would be useful to push upstream.


GUI designs ideas

Discussion for Dashboard designs.
Found many interesting dashboard designs here: link or in this app: link

most of these designs are not meant to be in Android apps, they don't follow Material design guidelines.
anyway, you still can use them by ImageSpeedometer, Imageindicator and ImageLinearGauge.

Simple gauge (without animated ambience lights could be added) : https://dribbble.com/shots/14580109-Speedometer-Concept-Motion-Design-Sound-ON
https://user-images.githubusercontent.com/50620416/117211308-1d999b00-adf9-11eb-9af3-555f6bee7aa2.mp4


[Proposal] Add the ability to schedule continuous

Dear Airflow Maintainers,
Please forgive the sudden PR, but I felt like it would be easier to describe what i want to do if there was some (pseudo) code to look at to understand the idea.
I'd like to add a "continuous" scheduling option.  A "continuous" schedule is one that will run the DAG unless there is already an instance of the DAG running.  This is primarily useful for DAGs that are started by sensors written under the assumption that you either want the sensor to be active and checking for data or you want the DAG to be running.
I.e. if you have a sensor that watches something like HCat for partition changes, you'd really like to know that either there is a partition change that is being processed or that there is nothing to be processed but you are actively looking and waiting for something to show up.
I haven't run the attached code yet so there's likely some issue with it, but I believe that it expresses what I think is required.  Namely, we add the "@continuous" scheduling option as well as a new parameter max_consecutive_failures parameter on the DAG.
max_consecutive_failures exists as a protection to an error in the DAG causing infinite restarts of the DAG.  It is a property that only applies to the continuous case (or it could be promoted to apply in any scheduled case as well, if people were interested in that, but I'm intending to keep this proposal self-contained and not affect other things).
The primary downside I see to this implementation is that the DAG execution_date is always equal to start_date and is "non-deterministic".  I.e. it will be difficult to use the time selector in the DAG view on the UI to view a specific run of the DAG.  You can still track things down through the DAG history views and it could be possible to eventually adjust the UI to jump to like "next" and "previous" runs if this is a significant concern.  For us right now, this is not a significant concern.  Also, given that it only muddies the waters when you choose to use the continuous scheduling, it should only impact people who use this feature.
Is this something that could get accepted into airflow or is this an abomination that you would never be willing to accept?  If it is something that people would be willing to accept, I can work on making it actually work and have tests and all that good stuff.

It sounds reasonable, we have to take a bit of time to think about the implications.
Effectively it could also be implemented as an externally triggered DAG where the external trigger cares only about not having a current active DagRun. If that's what you need though it's nice to let the scheduler take care of it and not have to write and manage your own external trigger.
I think it's compatible with depends_on_past=True on "dealbreaker" task. Where if you want the flow to stop on error you can hook that up using the existing methodology.
It seems like it would be as easy as the code you sketched here. Though the check on "no running DagRuns" should be pushed down to the database.

Cool, wasn't familiar with depends_on_past but yeah, I think setting that on the sensor will work for protecting against infinite failed runs.  Thanks.
I agree it could be externally triggered if that is preferable...  I'd probably do it by having my DAG end with a node that fires the DAG again, effectively making it infinitely recursive (assuming it keeps on succeeding).  I believe I can do that on my own without needing to make any changes in core, so if that's the preferred method just let me know.
Actually, that might even be simpler.  The only downside I can see to it is that nothing in the way the job is scheduled would tell someone how it is being triggered.  They'd have to know about my special end-node on the DAG.  That's not the end of the world though.

(hi @cheddar :))

Hey @criccomini, is github the new FB now? :P
@mistercrunch How do you feel about me doing it as an external trigger that is triggered by the final node in my DAG?  That seems to have nice properties, but I'm looking for confirmation that it's how you think airflow should be used (versus adding it as a scheduling option).

I just figured out the reason not to do it as a trailing node in our DAG.  When we restart all of the airflow services, we have to kill all running DAGs as well (otherwise things seem to get into a weird state).  Doing it with a DAG that invokes itself over and over again would require us to restart all of our DAGs manually every time we restart the airflow services, which is annoying.
Having the scheduler do this would mean that we do not have to do that.

Coverage decreased (-0.08%) to 67.008% when pulling a519004c9d9e94667be10016b81e55fd9237574a on cheddar:continuous-scheduling into a88662b88bd25dbd88d53e742eadcc57a0c32e82 on airbnb:master.

@cheddar As part of Cold Case PR Clean up, I am reviewing all PRs older than 2 weeks. We have reduced open PRs from >110 to ~30 : https://cwiki.apache.org/confluence/display/AIRFLOW/Cold-Case+PR+Resolution
Is this PR still needed? If so, can you rebase. A lot of your changes have already been submitted in other PRs. Pls respond within the next 5 days, else I will close this PR.


Trim

Use Object.assign instead of module assign
Remove all white space at end of line

Looks great! I think I had this before the polyfill days but prefer this for sure


Handle config file subdirectories properly

@legeana,
With the adjustment to a loop, the variables aren't updated as they were before due to Meson having immutable variables. We need to call subdir() in the loop, and use the generic config variable for that run. I didn't realize this until I did some heavy testing across systems - OS X built fine, but Linux was suddenly failing to find headers like signal.h, even though they were properly detected.
With this change, I see the configuration headers populated correctly once again.

lgtm

@legeana, changes made as requested. Tested locally with a project using CMocka as a subproject, configuration header output still generated properly.


Contradictory condition in encode.c

In the following code:
https://github.com/lexbor/lexbor/blob/f0539d137a9760d724dd378fad1c9fba1b083419/source/lexbor/encoding/encode.c#L386-L403
We first check if cp < 0x80, but there is a switch case that checks for cp to be equal to 0x203E. This seems impossible and I guess it may be a bug. Unfortunately I'm not familiar with this encoding so I don't know what it's supposed to be instead.

@nielsdos
In  encoding spec step 5.
5. If ISO-2022-JP encoder state is Roman and code point is an ASCII code point, excluding U+005C and U+007E, or is U+00A5 or U+203E, then:
    1. If code point is an ASCII code point, return a byte whose value is code point.
    2. If code point is U+00A5, return byte 0x5C.
    3. If code point is U+203E, return byte 0x7E.

I think I'm confused about the description of the steps.   There is indeed a logical bug here, it's strange that my static analyzers didn't detect it.
I'll do a patch on this tomorrow, with tests.
Thanks for the report.

@nielsdos
Thanks for the report! Fixed in 48afb62.

Thanks, I checked and the patch looks good to me.


Add more logs to Augur contracts

Some of the logs we will want to add include:

Fees when claiming trading proceeds
Fees when selling a complete set
Start & end dates for market creation events (needed for full-text search)
Forking market to UniverseForked
price to OrderFilled
Event logging for when a market has begun normal dispute pacing (possibly as a new param in DisputeCrowdsourcerCompleted)
No-show bond amount
Market info: finalizationTime, consensus, endTime, numTicks: https://gist.github.com/adrake33/c4b671181a1b4fb350b5dc6f18d11570
Market price history (should use finalization payout amount): https://gist.github.com/adrake33/f7e71594182020a585ccf71306b83e31
Market outcome price change (payout for that outcome should be used): https://gist.github.com/adrake33/d192651a004684cfcd8d347bc5a9bff6
Market creator has unclaimed fees & market creator claimed fees: https://gist.github.com/adrake33/10c16da8ac291ef392cc6844a741b888

And more to come

@nuevoalex status?

Closing this in favor of just using new issues to handle any additional logs we may need.


fix: fix validating of command roles

Previously, all command roles were validated by attempting to assume them. This was done even for stacks that were not selected to be in a stack deploy or undeploy operation. After this change, only command roles in stacks that are selected for an operation are validated.

:tada: This PR is included in version 5.0.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Documentation

Updating docs/features/roll-editor.md from the Hot Metal app.

Gonna merge even though the linter's complaining... should probably add that to the whitelist