Add observability via Pydantic Logfire

Closes #250

@shenanigansd ➜ /workspaces/dragonfly-mainframe (logfire) $ docker ps -a
CONTAINER ID   IMAGE                           COMMAND                  CREATED              STATUS                            PORTS     NAMES
9106dee56aaa   dragonfly-mainframe-mainframe   "pdm run coverage"       About a minute ago   Exited (137) About a minute ago             dragonfly-mainframe-mainframe-1
750328ac70c3   postgres                        "docker-entrypoint.s…"   About a minute ago   Exited (0) About a minute ago               dragonfly-mainframe-db-1

SIGKILL? That's weird, you didn't change the handling, unless your new integration is catching it for some reason.
Doesn't look it OOMed:
@shenanigansd ➜ /workspaces/dragonfly-mainframe (logfire) $ docker inspect 9106dee56aaa
[
    {
        "Id": "9106dee56aaaa57f8efb74b9381dc010ff794b918eb4276f97e6d2c47cd763a3",
        "Created": "2024-06-03T16:18:29.4155635Z",
        "Path": "pdm",
        "Args": [
            "run",
            "coverage"
        ],
        "State": {
            "Status": "exited",
            "Running": false,
            "Paused": false,
            "Restarting": false,
            "OOMKilled": false,
            "Dead": false,
            "Pid": 0,
            "ExitCode": 137,
            "Error": "",
            "StartedAt": "2024-06-03T16:18:47.999252849Z",
            "FinishedAt": "2024-06-03T16:18:58.089443847Z"
        },
[...]


Add basic documentation with AWS examples

@furkhat @zreigz please take a look, I finished basic documentation with AWS examples.


Solution for accounts with a LOT of token transfers

For Ethereum there's a limit of 10k logs returned at a time. We have a tree-like retry mechanism for those cases, so that covers almost all accounts. However, for other chains where we use Etherscan's API, for which we can receive 10k logs (paginated in 1k-sized pages) logs at a time, which can be prone to timeouts / rate limit issues.

The new version has improved this setup slightly, but I feel like it could be improved further so will leave this open.

For now I've subscribed to a paid version of the BscScan API and moved many other chains to Infura or Alchemy. It seems that this is now mostly working fine.


chore(discovery): ensure consistent names for discovery options in CRD

Welcome to Cryostat! 👋
Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #715
Description of the change:

Correct documentations for discovery fields. The field doc said the below previously though it should be the opposite.

// When true, the Cryostat application will use the default port name jfr-jmx to look for JMX connectable targets.
DisableBuiltInPortNames bool json:"disableBuiltInPortNames,omitempty"

Updated field names to be consistent. @ebaron Is it OK to update v1beta2  as such? Otherwise, I can just update the docs only.

Motivation for the change:
Documentation might be confusing as they state the opposite of what the fields should do.

/build_test

/build_test

/build_test


Prediction problem

Hi @yongshangli @CHDyshli
Thanks for your great work!
I am having problem with prediction. I am using paddle=2.4.1, paddleseg=2.7.0
I tried the hrsegnetb48 and ran prediction on one image from crackseg9k (cracktree200_6227.jpg)
There is something wrong with result. Below is output from running prediction:
W0109 14:57:12.200444 1112407 gpu_resources.cc:61] Please NOTE: device: 0, GPU Compute Capability: 8.6, Driver API Version: 12.0, Runtime API Version: 10.2
W0109 14:57:12.200459 1112407 gpu_resources.cc:91] device: 0, cuDNN Version: 8.9.
2024-01-09 14:57:12 [INFO]	Number of predict images = 1
2024-01-09 14:57:12 [INFO]	Loading pretrained model from /home/test/HrSegNet/hrsegnetb48/best_model/model.pdparams
2024-01-09 14:57:12 [INFO]	There are 180/180 variables loaded into HrSegNetB48.
2024-01-09 14:57:12 [INFO]	Start to predict...
1/1 [==============================] - 1s 828ms/step

Result in added_prediction

Any suggestions?

I found that it is my installation/library problem

You can delete this issue...

Hello,I am confused with the words around "registering model".Could you please tell me how to do it?

Hello,I am confused with the words around "registering model".Could you please tell me how to do it?

Thank you for reply!
So it seems that this sentence is already in the "hrsegnet_b16.py".
I have configured the Paddle environment and executed the prediction according to the tutorial.
Following the tutorial, I successfully ran "sh tests/install/check_predict.sh".
Then when I ran the predict,it occurs problem.

python tools/predict.py --config hrseg_config/hrsegnetb16.yml  --model_path output/model.pdparams --image_path dataset/concrete3k/images --save_dir output/result
'hrseg_config' is the directory I created, which is the same level as tools.
'model.pdparams' is the best model I move from the trained model "hrsegnetb16".
WHy?

Thank you for reply! So it seems that this sentence is already in the "hrsegnet_b16.py".
I have configured the Paddle environment and executed the prediction according to the tutorial. Following the tutorial, I successfully ran "sh tests/install/check_predict.sh". Then when I ran the predict,it occurs problem.
python tools/predict.py --config hrseg_config/hrsegnetb16.yml --model_path output/model.pdparams --image_path dataset/concrete3k/images --save_dir output/result
'hrseg_config' is the directory I created, which is the same level as tools. 'model.pdparams' is the best model I move from the trained model "hrsegnetb16".
WHy?

Maybe you should add "from hrsegnet import *" to this file.

Thank you for reply! So it seems that this sentence is already in the "hrsegnet_b16.py".
I have configured the Paddle environment and executed the prediction according to the tutorial. Following the tutorial, I successfully ran "sh tests/install/check_predict.sh". Then when I ran the predict,it occurs problem.
python tools/predict.py --config hrseg_config/hrsegnetb16.yml --model_path output/model.pdparams --image_path dataset/concrete3k/images --save_dir output/result
'hrseg_config' is the directory I created, which is the same level as tools. 'model.pdparams' is the best model I move from the trained model "hrsegnetb16".
WHy?

Also, paddleseg should be installed from source.

Of course,I also installed it.

Hi @CHDyshli,
I found this issue https://github.com/CHDyshli/HrSegNet4CrackSegmentation/issues/5. Is the normalization required for prediction?
Thanks in advance :-)

Hi @CHDyshli,
I found this issue #5. Is the normalization required for prediction?
Thanks in advance :-)

no


remove network 2018-05-01 as the API was never published

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Can one of the admins verify this patch?


docs: fix broken documentation links and other cargo doc warnings

Running cargo doc --all-features resulted in a lot of warnings. We should probably add this to the CI/CD pipeline to prevent it from degrading again.

Nice! Do the links work when opening cargo doc? Afaik there's an 'issue' with not being able to link to other crates in the workspace.

Nice! Do the links work when opening cargo doc? Afaik there's an 'issue' with not being able to link to other crates in the workspace.

Yeah, it's not really a bug but more of a missing feature. There's some solutions out there but they're basically hacks. The best solution is just to either not link, or to do a full external link manually.


♻(backend) Compress images after upload

Purpose
To ensure that uploaded images are appropriately validated and compressed before being stored. This will prevent oversized images from exceeding storage limits and improve loading times by reducing image file sizes.
Proposal

Integrate file validation for both type and size in the FileUploadSerializer to ensure only allowed images are accepted.
Apply compression to images that exceed size constraints, aiming to optimize storage usage.

[x] Validate file type and size in FileUploadSerializer.
[x] Implement image compression within the validate_file method if file type is allowed.
[x] Add checks to ensure the compressed image also meets the size constraints before storing.
[x] Document the maximum file size and allowed types for the upload endpoint.

@sampaccoud I just implemented storing the image in webp format, the gain we got by this is kinda minimal, but still present, at best we save like 30-100KB on average per image compared to the previous method that was in use. But there are still some leftover we need to address, e.g. "# Validate compressed file size", this is currently commented out.
Besides the is_unsafe flag now also brings some new questions. Currently, if there’s a mismatch between the guessed MIME type and the actual MIME type, the current condition of:
extension_mime_type, _ = mimetypes.guess_type(file.name)

        # Try guessing a coherent extension from the mimetype
        if extension_mime_type != magic_mime_type:
            self.context["is_unsafe"] = True

Doesn't make sense anymore, since the MIME type discrepancy would be irrelevant once the image is converted to WebP.
Should we simply remove this, or do you have any other plans on that?

@lindenb1 All tests aren't passing. I can't ask for a review from our team until it's the case.

@lindenb1 All tests aren't passing. I can't ask for a review from our team until it's the case.

@virgile-dev I don't think that is an issue with the changes, but the GH actions setup has a problem to run multiple jobs, failing with the same error message:

Run actions/create-github-app-token@v1
/home/runner/work/_actions/actions/create-github-app-token/v1/dist/main.cjs:39845
throw new Error("Input required and not supplied: app-id");
^

@lindenb1 Can you rebase?

@lindenb1 Can you rebase?

Has been rebased again


Button alignment in navBarwhen using menuToggle directive

Button with directive [menuToggle]="menuId" is right aligned on Android and Windows platform when used inside <ion-navbar>.
Button is left aligned for all 3 platforms (iOS, Android and Windows) when menuToggle directive is used without menuId specified, but is right aligned on windows when menuId is specified as such [menuToggle]="menuId" on Android and Windows.
Steps to reproduce:

Checkout menuToggle API documentation: http://ionicframework.com/docs/v2/api/components/menu/MenuToggle/

Expected Behavior
<button ion-button menuToggle>Toggle Menu</button> and <button ion-button menuToggle="menuId">Toggle Menu</button> to behave consistently and the button to be left aligned navbar.
Which Ionic Version? 2.x

Hi @nakulgulati, I don't understand what should be the expected behavior. Can you follow the issue template provided?

Hi @manucorporat, I have updated the issue and included 'expected behavior'.

Thanks @nakulgulati! I added this issue to my roadmap to RC2

I can't reproduce this issue, for me it is always left aligned. Can you share exactly the same code you are using?


"Select Free IPv4 IP?" should either be a button (without the question mark) or should gray out the IP field

If we keep the checkbox, maybe it should be checked by default?


Proposed updated code-style

This change seeks to improve readability of multiline statements in a
number of situations.

All right, these are the weird cases I found when applying this (only pasted one example per case):
Behaves a bit strangely when one of the arguments has a lot of arguments:
MemoryBackendTest:
        assertEquals(ImmutableSet.of("w",
                                     "wo",
                                     "wor",
                                     "worl",
                                     "world",
                                     "h",
                                     "he",
                                     "hel",
                                     "hell",
                                     "hello"), MemoryBackend.analyze("HelloWorld"));

General case: chaining futures pushes things very far to the right:
GrpcRpcProtocol:
        final AsyncFuture<ClusterNode> setup = channel.start()
                                                      .lazyTransform(n -> {
                                                          final GrpcRpcClient client =
                                                              new GrpcRpcClient(async,
                                                                                address,
                                                                                mapper,
                                                                                channel);

                                                          return client.request(METADATA,
                                                                                CallOptions
                                                                                .DEFAULT
                                                                                .withDeadlineAfter(
                                                                                5,
                                                                                TimeUnit
                                                                                .SECONDS)
                                                          ).<ClusterNode>directTransform(
                                                              m -> new GrpcRpcClusterNode(client,
                                                                                m));
                                                      });

Long constructors get shifted:
DatastaxMetricModule:
    public DatastaxMetricModule(@JsonProperty("id") Optional<String> id,
                                @JsonProperty("groups") Optional<Groups> groups,
                                @JsonProperty("seeds") Optional<Set<String>> seeds,
                                @JsonProperty("schema") Optional<SchemaModule> schema,
                                @JsonProperty("configure") Optional<Boolean> configure,
                                @JsonProperty("fetchSize") Optional<Integer> fetchSize,
                                @JsonProperty("readTimeout") Optional<Duration> readTimeout,
                                @JsonProperty("consistencyLevel")
                                    Optional<ConsistencyLevel> consistencyLevel,
                                @JsonProperty("retryPolicy") Optional<RetryPolicy> retryPolicy,
                                @JsonProperty("authentication")
                                    Optional<DatastaxAuthentication> authentication
    ) {

I think like @parmus mentioned that most of these cases could be addressed by always insisting on indenting.

Closing due to age, feel free to re-open if this is still an issue.


Optionplus order issue .

Hi ,
I am trying to use the "place_order" to place buy order in optionplus .
I have few questions for you .

How to decide "price" base of the "stoploss" ?
if the order_type_fresh="Market" , then what is the use of "order_rate_fresh" ?

Thanks ,
Ajit

Dear Ajit,
If you have given order_type = "Limit" then stoploss = "" is the Stop Loss Trigger Price(SLTP) where stop loss order will be activated and price="" is the limit price where you will supposed to execute your limit order, price will always less than equal to SLTP.
If order_type_fresh = "Market" then the order will be executed at market price and there is no need to give any value at order_rate_fresh, but it if you will choose order_type_fresh="Limit" then you can give a value.

From: Ajit Phusate @.>
Sent: Saturday, June 17, 2023 2:52 PM
To: Idirect-Tech/Breeze-Python-SDK @.>
Cc: Subscribed @.***>
Subject: [Idirect-Tech/Breeze-Python-SDK] Optionplus order issue . (Issue #28)
External Email Warning:
Use 'Report suspicious Email' button to report Phishing mails. Do not click on any attachment or links/URL in this email unless sender is reliable.
Hi ,
I am trying to use the "place_order" to place buy order in optionplus .
I have few questions for you .

How to decide "price" base of the "stoploss" ?
if the order_type_fresh="Market" , then what is the use of "order_rate_fresh" ?

Thanks ,
Ajit
—
Reply to this email directly, view it on GitHubhttps://github.com/Idirect-Tech/Breeze-Python-SDK/issues/28, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3TQZ43W3IXP6UDKXQDBDCLXLVZM7ANCNFSM6AAAAAAZKDWW6A.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Print this mail only if absolutely necessary. Save Paper. Save Trees." "The information contained in this e-mail and any attachments to this message are intended for the exclusive use of the intended recipient and may contain proprietary, confidential or legally privileged information. If you are not the intended recipient, please note that you are not authorised to disseminate, distribute or copy this e-mail or any parts of it or act upon/rely on the contents of this e-mail in any manner. Please notify the sender immediately by e-mail and destroy all copies of this e-mail and any attachments. Please also note that ICICI Bank or its subsidiaries and associated companies, (collectively "ICICI Group"), are unable to exercise control or ensure the integrity of/over the contents of the information contained in e-mail transmissions and that any views expressed in this e-mail are not endorsed by/binding on the ICICI Group unless the sender does so expressly with due authority of ICICI Group. Before opening any attachments please check them for viruses and defects and please note that ICICI Group accepts no liability or responsibility for any damage caused by any virus that may be transmitted by this email. Any unauthorized use of this email or any attachment(s) may be treated as infringement of right(s) including right of privacy under the applicable laws of India including Information and Technology Act, 2000. Thank you for your cooperation. Regulatory Disclosures are available on https://www.icicisecurities.com (for institutional business) and www.icicidirect.com (for retail business).

closing the issue


Closes #38 by replacing vars with direct var reference in the vars file

Too bad it does not work any more with real names.
@trumant  Thank you for pinning this one down.


Add getting started example

We need a simple hello world-like example. It would also be nice to pull benchmarks from the paper out on the main page

As option it can be ipynb? They are displayable in github directly (with some limitations)
https://docs.github.com/en/github/managing-files-in-a-repository/working-with-jupyter-notebook-files-on-github
Cell 0
import sys
!{sys.executable} -m pip install luminaire
!{sys.executable} -m pip <other deps>

Cell 1
from luminaire.exploration.data_exploration import DataExploration
...


Cannot install Azure modules on Docker-PowerShell

Output of $PSVersionTable (from a powershell process):
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
BuildVersion                   <IP_ADDRESS>
CLRVersion
GitCommitId                    v6.0.0-beta.2
OS                             Linux 4.9.12-moby #1 SMP Tue Feb 28 12:11:36 UTC 2017
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Output of ipmo Docker; (module Docker).Version.ToString() (from a powershell process):
Docker version 17.03.0-ce, build 60ccb22

Steps to reproduce the issue:

docker run -it microsoft/powershell:latest
PS /> Install-Module Azure
PS /> Import-Module Azure
Import-Module : The specified module 'Azure' was not loaded because no valid module file was found in any module directory.

What actually happened?:
Powershell not picking up newly installed modules. Restarting the container doesn't help
What did you expect to happen?:
Additional information:
OS: MacOS 10.11.3

This looks like it's actually an issue with open source powershell being able to load that module.  Since you are using docker directly and not using the Docker-PowerShell cmdlets, this isn't the right repository to file this issue against.  Please re-file your issue against https://github.com/powershell/powershell and they should be able to follow up with you there about issues using the Linux powershell image.


Update localization [07/25/23]

This PR updates localization for the following tasks:

AzureCloudPowerShellDeploymentV2
AzureResourceGroupDeploymentV2
JavaToolInstallerV0
KubeloginInstallerV0
KubernetesV1

Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run

/azp run


Update documentation of device.establishConnection()

Summary
Since device.establishConnection(context, false) is deprecated, the documentation should be updated

Preconditions
version 1.1.0 -> 1.2.0

device.establishConnection(context, false) should be replaced by device.establishConnection(false)
I don't know whether other things need updating but thought I would mention this one.

Thanks for noticing!


Request help Start windowS XPVM blue scree

Kubernetes version  v1.22.12
kubevirt version 0.49.0-2
Kernel  5.3.18-150300.59.87

@dhiller You have played with windows previously. Would you know how to help here?

/cc @dhiller

@maikoulin, are you trying to use an existing image with a WinXP VM or to install a fresh system? Could you share your VM yaml? Also looking at kubevirt version 0.49.0-2 I guess you are using Harvester?

@maikoulin I've had same problems getting the 0X7B when I tried that.
I had success when moving an old VirtualBox image to KubeVirt. Here's what I did in a nutshell:

Prepare the VM to be imported inside VirtualBox
Convert the disk image to an importable format
Import the image into kubevirt using cdi-uploadproxy
Create the vm with the image

Regarding the first step: what helped me was running the converted qcow image with qemu beforehand:
Example:
$ qemu-system-x86_64 -netdev user,id=hostnet0 \
    -device virtio-net-pci,netdev=hostnet0 \
    -device ahci,id=ahci \
    -drive id=disk,file=/path/to/your/disk.qcow2,index=0,media=disk,format=qcow2,bus=0 \
    -vga cirrus -display gtk -device AC97 -audiodev alsa,id=alsa -usb

Here's the repo with all manifests, scripts and slides I used: https://github.com/dhiller/containerdays.io-2022

I have some problem when i according this web try to set machine type  pc-i440fx-3.1
https://github.com/kubevirt/kubevirt/issues/2762
but I  get error:
The request is invalid: spec.template.spec.domain.machine.type: spec.template.spec.domain.machine.type is not supported: pc-i440fx-3.1 (allowed values: [q35* pc-q35*])

after set machine type pc-i440fx-3.1, I got :
/usr/libexec/qemu-kvm' does not support machine type 'pc-i440fx-3.1'

kubevirt  v1.0.0  qemu-kvm -machine help
Supported machines are:
pc                   RHEL 7.6.0 PC (i440FX + PIIX, 1996) (alias of pc-i440fx-rhel7.6.0)
pc-i440fx-rhel7.6.0  RHEL 7.6.0 PC (i440FX + PIIX, 1996) (default) (deprecated)
q35                  RHEL-9.2.0 PC (Q35 + ICH9, 2009) (alias of pc-q35-rhel9.2.0)
pc-q35-rhel9.2.0     RHEL-9.2.0 PC (Q35 + ICH9, 2009)
pc-q35-rhel9.0.0     RHEL-9.0.0 PC (Q35 + ICH9, 2009)
pc-q35-rhel8.6.0     RHEL-8.6.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.5.0     RHEL-8.5.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.4.0     RHEL-8.4.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.3.0     RHEL-8.3.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.2.0     RHEL-8.2.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.1.0     RHEL-8.1.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel8.0.0     RHEL-8.0.0 PC (Q35 + ICH9, 2009) (deprecated)
pc-q35-rhel7.6.0     RHEL-7.6.0 PC (Q35 + ICH9, 2009) (deprecated)
So we should compile qemu-kvm  by myself  to support   pc-i440fx-3.1 .


Route a decommissioned domain to the default decommissioned page

Background

Test the process to point a decommissioned domain as the maintenance app "decommissioned page".
Proposed user journey

Visiting a decommissioned page takes you to the default page.
Questions / Assumptions

[ ] Identify a domain to use.

Acceptance Criteria

[ ] Domain returns the maintenance pages app page.

Reference
How to write good user stories

antony.bishop  < 1 minute ago
We can use nomisqc.justice.gov.uk as our trial decommissioned domain.


docs: Fixed wrong structure reference (IDFGH-8081)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

sha=29bdfc5ecca0df329fd0a5b641c7be7b6e8399ab


fix PropTypes

Yes! react-dock is the last remaining dependency throwing the PropTypes warning for me, hope this gets merged & included in a small release update soon :+1:

Published in 0.2.4. Thanks!


Configure metadata_http_put_response_hop_limit for AWS Launch Configuration

I have issues
I could not find a way to configure metadata_http_put_response_hop_limit when using worker_groups with this module. In the AWS Launch Configuration console, the option is available at creation time, under "Additional configuration - optional/Advanced details/Metadata response hop limit"
I'm submitting a...

[ ] bug report
[x] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Cannot configure Metadata options like Metadata response hop limit for AWS Launch Configurations defined by worker_groups.
If this is a bug, how to reproduce? Please include a code sample if relevant.
Using a tf block like this, the metadata option is not applied:
module "eks" {
    source = "github.com/terraform-aws-modules/terraform-aws-eks?ref=v12.2.0"
    ...
    worker_groups = [
        {
          name                  = "blue"
          instance_type         = "t3.large"
          ...
          metadata_http_put_response_hop_limit = 2
        },
        ...
    ]
    ...
}

What's the expected behavior?
Worker_groups can also use metadata_http_endpoint, metadata_http_tokens, metadata_http_put_response_hop_limit
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version:
OS:
Terraform version: 0.12.

Any other relevant info

We have the same problem that it is not available to set metadata_http_put_response_hop_limit for worker groups (launch configuration), but it works ok and sets for worker_groups_launch_template in the same manner.
Maybe for worker_groups metadata may be set in another manner?
Terraform: 0.13.5

Experiencing the same issue. Can't find metadata options for worker_groups.
Setting metadata_http_tokens is required for AWS Security Hub Foundational Security Best Practices v1.0.0 control EC2.8. The control fails if metadata_http_tokens isn't set to "required".

The newly released aws provider (3.23.0) now includes support for metadata_options in launch configurations, including http_put_response_hop_limit.  This would make it fairly straightforward to include in this module as well.

The newly released aws provider (3.23.0) now includes support for metadata_options in launch configurations, including http_put_response_hop_limit.  This would make it fairly straightforward to include in this module as well.

Same issue here, AquaSec and AWS Security Hub complains for each worker fired up so I'd love to see this fixed.

I was looking for same thing and I saw metadata_http_put_response_hop_limit was already added here: https://github.com/terraform-aws-modules/terraform-aws-eks/commit/23ad497557438b5fd95daaf33cf8859e091b9c98
Probably this issue can be closed.

@alialperak it's been added for launch templates, but not for launch configurations.

This is now supported in v15.2.0
https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1301


Treat StringIO like IO when auto-coercing to protobuf bytes

Codecov Report

Merging #115 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   99.48%   99.53%   +0.05%
==========================================
  Files          19       19
  Lines        1925     1932       +7
==========================================
+ Hits         1915     1923       +8
+ Misses         10        9       -1

Impacted Files
Coverage Δ

lib/google/gax/util.rb
97.72% <ø> (ø)
:arrow_up:

spec/google/gax/util_spec.rb
100% <100%> (ø)
:arrow_up:

spec/google/gax/bundling_spec.rb
100% <0%> (+0.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8df812...0e4266c. Read the comment docs.