bufferedbatch: batch v2 implementation

Implement a batch v2 buffered batch.
It will most likely be used as-is in all our stores since the batch is now simpler than what it was previously.
Note: I found it horrible to have to manually implement the mocks, we need to take some time to find a good package to do that for us (and at the same time add a good assertions library for our unit tests).

This change is

Good job :+1:

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

cs/cs.go, line 332 at r1 (raw file):

// Segmentify returns a segment from a link,
// filling the link hash and appropriate meta.
func (l *Link) Segmentify() *Segment {

Why l is a pointer?
This comment can be applied in function signatures above.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

cs/cs.go, line 332 at r1 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
Why l is a pointer?
This comment can be applied in function signatures above.

Good point, it probably doesn't need to be a pointer. I'll update it and verify that it works correctly with a value.

Comments from Reviewable

Review status: 6 of 7 files reviewed at latest revision, 1 unresolved discussion.

cs/cs.go, line 332 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
Good point, it probably doesn't need to be a pointer. I'll update it and verify that it works correctly with a value.

Fixed

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

bufferedbatch/batchV2.go, line 76 at r2 (raw file):

	for _, link := range b.Links {
		if filter.MatchLink(link) {
			segments = append(segments, link.Segmentify())

In retrospect, does it make sense that the BatchV2 implements GetSegment and FindSegments instead of GetLink and FindLinks? We are a bit lying here since we're actually returning Links wrapped in Segments. Maybe GetSegment and FindSegments is a higher level interface implemented only by adapters that have access to an EvidenceStore and a LinkStore?

Comments from Reviewable

I think it makes sense to keep it like that because the batch contains the underlying store adapter and does GetSegment and FindSegment in both its batched data and the underlying adapter.
So it could return data with evidence if the underlying store adapter returns a segment with evidence.
The only issue I would see would be to do GetSegment on a link that's both in the batch and in the underlying store adapter:

if the underlying store adapter has some evidence, it would return it
but right now since we find it in the batch (without evidence), we return that link wrapped in a segment

I'm not sure this is a very valid scenario though, but we could fix this by always doing GetSegment in both the batch and the underlying store to enrich with the store's evidence. But since I think this situation shouldn't happen, I think it's fine to keep that way don't you think?


Bower Installable

Hi,
Thanks for making this super easy to use library.
Could you please make it bower installable?
Thanks,
Edmond

Good idea, will do.

@edmondchui I have modify the code to make it bower installable
bower install ng-responsive-calendar

Here is the error I got:
$ bower install
bower ng-responsive-calendar#~0.1.0       not-cached git://github.com/twinssbc/AngularJS-ResponsiveCalendar.git#~0.1.0
bower ng-responsive-calendar#~0.1.0          resolve git://github.com/twinssbc/AngularJS-ResponsiveCalendar.git#~0.1.0
bower ng-responsive-calendar#~0.1.0     ENORESTARGET No tag found that was able to satisfy ~0.1.0

Additional error details:
No versions found in git://github.com/twinssbc/AngularJS-ResponsiveCalendar.git

I guess you need to add something else in the git repository.

Sorry, I forgot to push the tag. Now it should work.

Thanks! It works now.


Implement sub-workflow mapper

[ ] sub-workflow mapper
[ ] integration test
[ ] unit tests
[ ] documentation

[ ] sub-workflow mapper
[ ] integration test
[ ] unit tests
[ ] documentation


Running puppet agent -t to update gitlab configuration tries to download and install gitlab again

Running: Gitlab EE 7.10.4, CentOS 6.6
We installed successfully, but were trying t omodify the configuratioon (add a new setting), and when we re-run puppet agent -t, the run failed, complaining that it couldn't update ensure status from absent to latest, and then displayed the rpm command output, which obviously printed that gitlab was already installed.
Any ideas? Is this because the ensure is set to latest, instead of installed?

Gitlab changed the names of their packages when they released 7.1.x. which this module depended on.
There are several bug tickets open on this.
#141
#150
#149
#140
Unfortunately it is going to take a major refactor to handle the way that gitlab changed their package names.
Issue #140 has a pull request that might fix this, but I haven't tested it yet.

Sorry, didn't quite understand that those issues were the same.

No problem. I think people who aren't using puppet will run into the same issue.


File naming options for "Refactor -> Move to a new file"

The "Move to a new file" refactor is a great tool, except that the generated file keeps the casing of whatever you are moving.
Example:
export interface UserSettings {
  language: string;
}

Using the refactor here creates a file named "UserSettings.ts" (PascalCase) while I would like it to be named "user-settings.ts" (kebab-case)
A setting to change this behavior with options like:

Keep case of class/interface/etc name (current behavior)
Convert to PascalCase
Convert to kebab-case
Convert to lower case
(plus snake_case and camelCase i guess)

would remove an extra step (renaming the generated files or creating files by hand and manually importing it) and would make me and at least one other person on stack overflow very happy.

(closing because issue was created with the wrong github account)


Allow selection of all tags with Ctrl+a / cmd+a

It would be nice if ngTagsInput would allow the user to select all tags / text that has yet to be parsed to a tag with keyboard shortcuts.
There are two usecases where this would be helpfull:

I want to delete all entered text that is not yet parsed to a tag and all tags already parsed with Ctrl + a + backspace / Cmd + a + backspace. because if the amount of tags is large, manually removing them or pressing backspace for a long time can be time consuming.
I want to coppy all entered text that is not yet parsed to a tag and all tags already parsed with Ctrl + a > Ctrl + c / Cmd + a > Cmd + c.

I can understand if you don't want the last useCase to be implemented as it's quite app-specific, but in my opinion due to the flexibility of this directive it is possible that person A enters a large amount of tags for inviting people or sending a newsletter Then person B wants to copy those and put them in excel as CSV etc. It's possible that person A and person B don't know each other and thus don't have access to the source file that was used to enter the tags.
This ofc all is related for use-cases where the tagCollection get's very large.

Is this extensibility added?

Is this function still in your mind ? I'd like to use it too ;)


Made PHP7 puppet code readable by humans

Tried for the 2nd time to use legit puppet code like (apt::ppa) to
install PHP7 ppa but failed.
So for now, we'll make the code readable by humans.
Also removed a duplicate package and removed apache2 manual restart
since puppet restart a2 via notify anyway.

How to test:
git@github.com:akeif/vagrantpress.git vagrant_test
cd vagrant_test
git checkout refactor-php7-puppet-code
vagrant up

Visit http://vagrantpress.dev


feat(strm-2115): start of entity monitoring

filter parameters trigger NPE in CRS back-end, so have been disabled for now

:tada: This PR is included in version 3.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] Looking for Microsoft.SharePoint.PowerShell does not exists. Can you use Microsoft.Online.SharePoint.PowerShell?

Notice
Many bugs reported are actually related to the PnP Framework which is used behind the scenes. Consider carefully where to report an issue:

Are you using Invoke-PnPSiteTemplate or Get-PnPSiteTemplate? The issue is most likely related to the Provisioning Engine. The Provisioning engine is not located in the PowerShell repo. Please report the issue here: https://github.com/pnp/pnpframework/issues.
Is the issue related to the cmdlet itself, its parameters, the syntax, or do you suspect it is the code of the cmdlet that is causing the issue? Then please continue reporting the issue in this repo.
If you think that the functionality might be related to the underlying libraries that the cmdlet is calling (We realize that might be difficult to determine), please first double check the code of the cmdlet, which can be found here: https://github.com/pnp/powershell/tree/master/src/Commands. If related to the cmdlet, continue reporting the issue here, otherwise report the issue at https://github.com/pnp/pnpframework/issues

Reporting an Issue or Missing Feature
Please confirm what it is that your reporting
Expected behavior
Please describe what output you expect to see from the PnP PowerShell Cmdlets
Connect to SharePoint Online
Actual behavior
Please describe what you see instead. Please provide samples of output or screenshots.
Error looking for Microsoft.SharePoint.PowerShell that does not exist on my system and cannot find in PSGallery
Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists
Connect-PnPonline $_.url
What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
1.8
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

@DECBuzz - I don't understand what your issue is? Connect-PnPOnline works fine.

When I use:
PS C:\WINDOWS\system32> Install-Module Microsoft.SharePoint.PowerShell
PackageManagement\Install-Package : No match was found for the specified search criteria and module name
'Microsoft.SharePoint.PowerShell'. Try Get-PSRepository to see all available registered module repositories.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\<IP_ADDRESS>\PSModule.psm1:1809 char:21

...          $null = PackageManagement\Install-Package @PSBoundParameters

                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Package], Exception
FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage

You may have it on your system already. I only found Microsoft.Online.SharePoint.PowerShell.
Regards,
Danny Causey
From: Veronique Lengelle @.>
Sent: Friday, November 12, 2021 03:05
To: pnp/powershell @.>
Cc: Danny Causey @.>; Mention @.>
Subject: Re: [pnp/powershell] [BUG] Looking for Microsoft.SharePoint.PowerShell does not exists. Can you use Microsoft.Online.SharePoint.PowerShell? (Issue #1341)
@DECBuzzhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDECBuzz&data=04|01|danny.causey%40iidm.com|314d6babe5b247238b1408d9a5bb82a1|f39e1d48866349f982de30b54a1d2a0d|0|0|637723047058516492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bomVQg6spxO4%2BkOck%2BncJ7oThKqZBbQosN3Tfs%2B9EgM%3D&reserved=0 - I don't understand what your issue is? Connect-PnPOnline works fine.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnp%2Fpowershell%2Fissues%2F1341%23issuecomment-966937318&data=04|01|danny.causey%40iidm.com|314d6babe5b247238b1408d9a5bb82a1|f39e1d48866349f982de30b54a1d2a0d|0|0|637723047058516492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kjSKjS76oP1U4jMgjPBhBr2HQS%2FST0p68Y5uL1mno4U%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOYGFVXNXKY6AD4GHFPI6S3ULTKDZANCNFSM5H3QL7OQ&data=04|01|danny.causey%40iidm.com|314d6babe5b247238b1408d9a5bb82a1|f39e1d48866349f982de30b54a1d2a0d|0|0|637723047058526440|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kEa%2FCsxXaHxMXc2p9uXrDP%2FLH2VmaNKpcu%2BsyYKLY70%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|danny.causey%40iidm.com|314d6babe5b247238b1408d9a5bb82a1|f39e1d48866349f982de30b54a1d2a0d|0|0|637723047058526440|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Svflkh%2FV6LxGOpfKHo21jC35eYACezvit2IA%2B70Q9f0%3D&reserved=0 or Androidhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|danny.causey%40iidm.com|314d6babe5b247238b1408d9a5bb82a1|f39e1d48866349f982de30b54a1d2a0d|0|0|637723047058536402|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ibQlUPvSA6IQuyGxoH%2FRotY84E5e0bFkgzf8WvRKSec%3D&reserved=0.

You are trying to install the SharePoint Management Shell (from Microsoft), not the PnP.PowerShell module (this repo).
If you want to install the PnP PowerShell module, please refer to our documentation.
To install the SharePoint Management Shell, it's in the PSGallery: https://www.powershellgallery.com/packages/Microsoft.Online.SharePoint.PowerShell/16.0.21811.12000,
Or use Install-Module -Name Microsoft.Online.SharePoint.PowerShell
Closing as there no issue.


Vega-2467 pactv2 upgrade

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.50%. Comparing base (6480553) to head (812305f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   79.50%   79.50%
=======================================
  Files          35       35
  Lines        1059     1059
=======================================
  Hits          842      842
  Misses        156      156
  Partials       61       61

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


jsonwebtoken has insecure input validation in jwt.verify function

Seems like there is security vulnerability with jsonwebtoken dependency.
can you please plan to update the dependency as per below?

@pdurgapr Could you suggest the detailed package you've used to trigger this security vulnerability with jsonwebtoken dependency?

@MaryGao This came up in our organisation github Dependabot alerts.

Got it and may link to the issue: https://github.com/Azure/azure-sdk-for-js/issues/24337

<EMAIL_ADDRESS>has been released with the updated dependency.

we are using @azure/identity dependency, can we expect a release of same soon?


Import statements are converted to require, but not hoisted

🐛 Bug Report
When using ES6 imports, which don't require a specific order, the import statements are changed to a require statement, and are then not in the correct place. To mimic the same location indifference/automatic hoisting the require statements should all be hoisted to the top of the files
export class EmailModel extends ContactMethodBase implements IEmailModel {
    email!: string | undefined;

    constructor(data?: IEmailModel) {
        super(data);
    }
}

export interface IEmailModel extends IContactMethodBase {
    email: string | undefined;
}

import { ContactMethodBase, IContactMethodBase } from "./contactMethodBase";

Becomes the following:
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.EmailModel = void 0;
var tslib_1 = require("tslib");
var EmailModel = /** @class */ (function (_super) {
    tslib_1.__extends(EmailModel, _super);
    function EmailModel(data) {
        return _super.call(this, data) || this;
    }
    return EmailModel;
}(contactMethodBase_1.ContactMethodBase));
exports.EmailModel = EmailModel;
var contactMethodBase_1 = require("./contactMethodBase");

Which errors because contactMethodBase_1 is currently undefined.
Expected behavior
The CommonJS implementation matches functionality of the ES6 module code.
System:
    OS: Windows 10
    Node version:  v12.19.0
    TS-Jest version: 27.0.4

PR is welcome if you know how to fix the issue. We are using https://github.com/kulshekhar/ts-jest/blob/master/src/transformers/hoist-jest.ts to hoist jest api.

your problem is TypeScript itself, see PR fix https://github.com/microsoft/TypeScript/pull/39764


fix: align footer items to center in small devices

Description
Align the Elements in the Footer Component to Center

Before
After

Related issue(s)
Resolves #2524

@nikhilkalburgi I don't think we should make this change
@Mayaleeeee wdyt about this

@Mayaleeeee Can you please leave the same comment on the issue so that we can close the PR as well as issue?

Thanks for the PR @nikhilkalburgi but we would prefer to leave it the way it is.
ref:

I agree with @sambhavgupta0705. The centred alignment looks strange and uncommon. @nikhilkalburgi, thank you, but I'd prefer we leave it the way it is.

https://github.com/asyncapi/website/pull/2525#pullrequestreview-1850449582


Add Nextjs example

Pull Request Description
Related Issue
Fixes #58
Changes Made
This PR adds the following changes:

Adding nextjs example
Creating agent by user private key and OpenAI Key
Integrates langchain and uses OpenAI
ChatGPT base UI

Implementation Details

NextJS is used.
Langchain is used.

Transaction executed by agent

Example transaction:
Prompt Used

npm run dev

Additional Notes

The tweet about the pr is here
Checklist

[x] I have tested these changes locally
[x] I have updated the documentation
[x] I have added a transaction link
[x] I have added the prompt used to test it

can you share a deployed link?

can you share a deployed link?

Here is the web page . Please consider that the app contains OpenAI key which has 10$ credits, the wallet has not funding and the cluster is mainnet.

great work @DogukanGun

the chat history on left side is not showing currently, can you pls fix it
for the wallet, can you use something like privy to create embedded wallet on your frontend and auto-approve each transaction?

closed in favour of #75


Filter key parameters from request URIs

Move API authentication keys from request URIs (i.e. the key parameter) into HTTP X-API-KEY headers:

make URIs publishable without leaking authentication credentials
allow URIs to be canonical
allow URIs to be reused with other keys without editing the URI

TroveProxy should accept keys from the client as any of X-API-KEY header, key URL parameter, or a cookie, and should pass the key to Trove as an X-API-KEY header (stripping any key parameter from the URL), and pass the key back to the client as a cookie.


fix: add rainbow-module logo

fix: #86
Changes

add the logo and name to the sidebar header
add the logo on the favicon

the image in the header of the sidebar may change...


AQL path query not working for RC1

in the RC1 workspace, when running a path query, the query does not work (no network is returned, no error is to be seen).
My suspicion is that the query times out.

The query was case-sensitive. Removing issue


Room conflict withe Work Manager dependencies

After adding workout manager dependencies already working module giving below error
java.lang.NoSuchMethodError: No direct method (Landroid/arch/persistence/room/DatabaseConfiguration;Landroid/arch/persistence/room/RoomOpenHelper$Delegate;Ljava/lang/String;)V in class Landroid/arch/persistence/room/RoomOpenHelper; or its super classes (declaration of 'android.arch.persistence.room.RoomOpenHelper' appears in /data/app/com.workoutapps.height.v2-FoiGsai4Uj3rgP8SvlPnOA==/split_lib_dependencies_apk.apk)
at androidx.work.impl.WorkDatabase_Impl.createOpenHelper(WorkDatabase_Impl.java:44)
at android.arch.persistence.room.RoomDatabase.init(RoomDatabase.java:110)
at android.arch.persistence.room.RoomDatabase$Builder.build(RoomDatabase.java:623)
at androidx.work.impl.WorkDatabase.create(WorkDatabase.java:100)
at androidx.work.impl.WorkManagerImpl.(WorkManagerImpl.java:159)
at androidx.work.impl.WorkManagerImpl.(WorkManagerImpl.java:138)
at androidx.work.impl.WorkManagerImpl.initialize(WorkManagerImpl.java:120)
at androidx.work.WorkManager.initialize(WorkManager.java:139)
at androidx.work.impl.WorkManagerInitializer.onCreate(WorkManagerInitializer.java:40)
at android.content.ContentProvider.attachInfo(ContentProvider.java:1919)
at android.content.ContentProvider.attachInfo(ContentProvider.java:1894)
at android.app.ActivityThread.installProvider(ActivityThread.java:6329)
at android.app.ActivityThread.installContentProviders(ActivityThread.java:5895)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5816)
at android.app.ActivityThread.-wrap1(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1674)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6592)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:769)

Has same issue

Try updating Room to the newest version (currently: 1.1.1-rc1). This solved the issue for me.

Still got the exception even after change the Room version to latest version .. :(

Thanks for reporting this.
I'm closing this issue because this forum is for issues with the codelab.
If you think that this is a problem of the WorkManager library, please open a bug on the WorkManager public issue tracker: https://issuetracker.google.com/issues/new?component=409906&template=1094197
Please reopen if you still think this is an issue with the codelab, however Stackoverflow might be a better forum for this kind of questions.
In this particular case you should be able to use jetifier (in Android Studio).
Your dependencies on android.arch.* get rewritten to to the appropriate androidx packages.
You can find more information on this blog post.

Android Studio 3.2 helps you through this migration with a new refactoring action. To use the feature, navigate to: Refactor → Refactor to AndroidX. As an additional enhancement to the refactoring process, if you have any maven dependencies that have not migrated to the AndroidX namespace, the Android Studio build system will automatically convert those project dependencies as well. You can manually control the conversion process by toggling the android.enableJetifier = true flag in your gradle.properties file. While the refactoring action supports common project configurations, we recommend that you save a backup of your project before you refactor.


Fix the compilation of solo5-aarch64 and the TLS support

/cc @palainp can you confirm that it's the right fix for aarch64?

Oh sorry I missed that thank you! I unfortunately can't test it due to lack of hardware :(
It looks good to me, perhaps you'd merge both liges into single one ?

It looks good to me, perhaps you'd merge both liges into single one ?

I think it's fine. About testing, we still are under the experimental state about the aarch64 support :+1:. Thanks for the quick review.


Issue with token local_auth_token

Version of the custom_component

ha-google-home v1.0.0
core-2021.3.3
supervisor-2021.03.4

Configuration
Installed through HACS
Created app password since I use 2FA
Describe the bug
No error during initial configuration (when I enter my Google account and app password), but I don't see any sensors. Seems like it's trying again and again to connect (without success). My Google account on other devices has been signing out due to the repeated attempts...
Debug log

2021-03-12 17:44:22 ERROR (SyncWorker_1) [glocaltokens.client] local_auth_token doesn't follow the correct format.
2021-03-12 17:44:22 ERROR (MainThread) [custom_components.google_home] Unexpected error fetching sensor data: 'Device' object has no attribute 'ip'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 151, in async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 139, in _async_update_data
    return await self.update_method()
  File "/config/custom_components/google_home/api.py", line 164, in update_google_devices_information
    devices = await self.get_google_devices()
  File "/config/custom_components/google_home/api.py", line 74, in get_google_devices
    self.google_devices = [
  File "/config/custom_components/google_home/api.py", line 78, in <listcomp>
    ip_address=device.ip,
AttributeError: 'Device' object has no attribute 'ip'

Thanks for reporting it, @philippefs35.
Sorry it has logged out all of your google devices, but that's the security behind Google 😄
What i can see here are two problems:

In the underlying glocaltokens package this integration is using we do a validation of a local authentication token, however, if the validation fails (as it has happened in your case) we still initialize and return the object. We should not be doing that, instead if the validation fails we should just skip adding this device. I have created a corresponding issue here that will have to be taken care of to avoid propagated errors as you are having.
Somehow the local authentication token that you have received from Google is invalid. This is my first time seeing this, so i am a bit surprised and curious what kind of data are you actually receiving there. If you are interested in helping our you can try obtaining those tokens in isolation away from this integration. You can do that by trying glocaltokens python package(this integration uses glocaltokens under the hood) on your laptop/pc. It will allow you to make sure your username/password are right and the package returns all data as expected (see example/get_tokens.py) and if the error that you are getting persist you will see the python package failing with the same error message "local_auth_token doesn't follow the correct format.".
If that happens please try this sketch:

    client = GLocalAuthenticationTokens(
        username=GOOGLE_USERNAME,
        password=GOOGLE_PASSWORD,
        master_token=GOOGLE_MASTER_TOKEN,
        android_id=DEVICE_ID,
    )
    homegraph = client.get_homegraph()
    for item in homegraph.home.devices:
        if item.local_auth_token != "":
            print(item.local_auth_token)

This will print all of your local authentication tokens from all the devices connected to your google account. They are changed about every day, but are still somewhat sensitive data(you might want to change a few symbols here and there). If you will get to this point - paste them to corresponding bug issue, so we can improve validation and checks.

We have now merged the fix(see here) for the bug you were having, so after a new release of glocaltokens comes out it will not recognize non google home devices that have a token of a different format than expected. :)  So I'll close the issue


:open_book: Docs: Chinese of index

What should be changed?
complete https://docs.devstream.io/en/latest/index.zh/
pls assign me

Is the demo in index uploaded on the chinese website? If not, I will use the Youtube version.

I have found https://www.bilibili.com/video/BV1W3411P7oW


Delete duplicated addOption

There are two addOptions calls for "debug" argument (lines 276 and 283).

Good catch, @fourlex. Thanks!


warnings when synthesizing on ZynqParrot and vivado 2022.1

WARNING: [Synth 8-689] width (64) of port connection 'io_cmd_data_o' does not match port width (32) of module 'bp_me_axil_client' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:215]
WARNING: [Synth 8-689] width (64) of port connection 'io_resp_data_i' does not match port width (32) of module 'bp_me_axil_client' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:221]
1:51
WARNING: [Synth 8-689] width (32) of port connection 'axi_awaddr_addr_o' does not match port width (33) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:593]
WARNING: [Synth 8-689] width (4) of port connection 'axi_awlen_o' does not match port width (8) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:594]
WARNING: [Synth 8-689] width (2) of port connection 'axi_awlock_o' does not match port width (1) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:599]
WARNING: [Synth 8-689] width (32) of port connection 'axi_araddr_addr_o' does not match port width (33) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:615]
WARNING: [Synth 8-689] width (4) of port connection 'axi_arlen_o' does not match port width (8) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:616]
WARNING: [Synth 8-689] width (2) of port connection 'axi_arlock_o' does not match port width (1) of module 'bsg_cache_to_axi' [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot-subsystems/axi/v/bp_axi_top.sv:621]
WARNING: [Synth 8-3848] Net data_1g_high_r[0] in module/entity bp_tlb does not have driver. [/home/mbt/hotel/zynq-parrot/cosim/import/black-parrot/bp_common/src/v/bp_tlb.sv:162]

These are fixed in latest ZP!


chore: release main

:robot: I have created a release beep boop
ui5-cc-spreadsheetimporter: 1.1.0
1.1.0 (2024-06-13)
Features

new option excludeColumns (#575) (a639b02)
parse Edm.Time when excel data is text (#573) (cfaeace)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/releases/tag/ui5-cc-spreadsheetimporter-v1.1.0 :sunflower:


Remove intermediate pixel_mat_clustered/cell_mat_clustered directory/file

Describe the solution you'd like
pixel_mat_clustered contains the same data as pixel_mat_consensus, just without the meta cluster columns. Now that we're working with large datasets, we should not need to keep large duplicate datasets around.
We write to one pixel_mat_consensus directory with just the SOM labels at first. It will be much more intuitive to overwrite the old .feather files with the pixel data containing the meta cluster labels once that step is performed. This removes an additional variable from the notebook and also simplifies the directory structure prior to finalizing the pipeline for pixel and cell clustering.

@ngreenwald plan to get this finished up before opening the PRs for parallel processing and restarting from crashing since those two depend at least partially on the current directory structure, which the PR addressing this one will change.

totally, makes sense


Android Theme with Dark Mode is unreadable

How to reproduce:

Open the app;
Click on your avatar;
Select Settings;
Select Android under Theme;
Select Dark under Dark Mode Preference.
Go back to home, see the sessions are not readable;

Note the Default theme works as expected.

We should compare with nowinandroid app and see what we're missing.

Should be fixed now


Ra dspdc 1237 multiflow

Break up the main import workflow into multiple workflows. This way we can run staging and ingestion pieces separately, and we have separate flows for including files or not (which were not in the spec but are useful for testing). The main import workflows are composed of the staging and ingestion workflows, which keeps the code just a little bit dryer than it would've been otherwise.

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   48.57%   48.57%
=======================================
  Files           1        1
  Lines         105      105
  Branches        1        1
=======================================
  Hits           51       51
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d227b...e768fdd. Read the comment docs.

I like the naming suggestions, Sarah; I changed it to "import" because for this project, other folks take issue with us using the term "ingest". I think "load" makes more sense, and I agree with the "table" comment. Will make changes and push.


Import mnemonic seed

I only see the ability to create a new wallet/seed. Will there be support in the future for importing existing seeds?

Sure, there will be support for importing existing seeds in the future.


How to set the icon for a repo?

Not really a bug/issue, but how does one set the icon for a repo, so there is something other than the whale?   Recommended repo's all have cool icons... i'd like my own pub/privates to have their own icons too.  How to do i do that?

Currently this is setup in a hard-coded way, where the 'recommended' images have an img entry defined, that is then pulled from the web:
https://kitematic.com/recommended.json
Ideally this would be a feature of the repo that you're using, where an icon could be added.

That would be really sweet... maybe even in the build or push step?  Or heck have it a feature of registry / hub / DTR as long as Kite can view it.

If it's in Hub, Kitematic would be able to use it.
You can open up a ticket for it here:
https://github.com/docker/hub-feedback

Closing this in favor of an issue opened with Hub :)

Hey ben.. i just opened up hub issue. https://github.com/docker/hub-feedback/issues/431

Thanks @michaelwilde I believe it's an up and coming feature. The issue just makes sure there is more leverage for it to happen sooner ;)


Doesn't lint .ts files in a new create-vue project

Steps to Reproduce

Run npm init vue@latest.
Open one of the .ts files.
No ESLint diagnostics show. They do show in .vue files.

Running with tracing enabled shows:
ESLint log
[Info  - 11:58:38 AM] ESLint server is starting
[Trace - 11:58:38 AM] Sending request 'initialize - (0)'.
Params: {
    "processId": 91801,
    "clientInfo": {
        "name": "Visual Studio Code",
        "version": "1.68.1"
    },
    "locale": "en-us",
    "rootPath": "/Users/segevfiner/junk/vue-ts-lint-issue",
    "rootUri": "file:///Users/segevfiner/junk/vue-ts-lint-issue",
    "capabilities": {
        "workspace": {
            "applyEdit": true,
            "workspaceEdit": {
                "documentChanges": true,
                "resourceOperations": [
                    "create",
                    "rename",
                    "delete"
                ],
                "failureHandling": "textOnlyTransactional",
                "normalizesLineEndings": true,
                "changeAnnotationSupport": {
                    "groupsOnLabel": true
                }
            },
            "didChangeConfiguration": {
                "dynamicRegistration": true
            },
            "didChangeWatchedFiles": {
                "dynamicRegistration": true
            },
            "symbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                },
                "tagSupport": {
                    "valueSet": [
                        1
                    ]
                }
            },
            "codeLens": {
                "refreshSupport": true
            },
            "executeCommand": {
                "dynamicRegistration": true
            },
            "configuration": true,
            "workspaceFolders": true,
            "semanticTokens": {
                "refreshSupport": true
            },
            "fileOperations": {
                "dynamicRegistration": true,
                "didCreate": true,
                "didRename": true,
                "didDelete": true,
                "willCreate": true,
                "willRename": true,
                "willDelete": true
            }
        },
        "textDocument": {
            "publishDiagnostics": {
                "relatedInformation": true,
                "versionSupport": false,
                "tagSupport": {
                    "valueSet": [
                        1,
                        2
                    ]
                },
                "codeDescriptionSupport": true,
                "dataSupport": true
            },
            "synchronization": {
                "dynamicRegistration": true,
                "willSave": true,
                "willSaveWaitUntil": true,
                "didSave": true
            },
            "completion": {
                "dynamicRegistration": true,
                "contextSupport": true,
                "completionItem": {
                    "snippetSupport": true,
                    "commitCharactersSupport": true,
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "deprecatedSupport": true,
                    "preselectSupport": true,
                    "tagSupport": {
                        "valueSet": [
                            1
                        ]
                    },
                    "insertReplaceSupport": true,
                    "resolveSupport": {
                        "properties": [
                            "documentation",
                            "detail",
                            "additionalTextEdits"
                        ]
                    },
                    "insertTextModeSupport": {
                        "valueSet": [
                            1,
                            2
                        ]
                    },
                    "labelDetailsSupport": true
                },
                "insertTextMode": 2,
                "completionItemKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25
                    ]
                }
            },
            "hover": {
                "dynamicRegistration": true,
                "contentFormat": [
                    "markdown",
                    "plaintext"
                ]
            },
            "signatureHelp": {
                "dynamicRegistration": true,
                "signatureInformation": {
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "parameterInformation": {
                        "labelOffsetSupport": true
                    },
                    "activeParameterSupport": true
                },
                "contextSupport": true
            },
            "definition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "references": {
                "dynamicRegistration": true
            },
            "documentHighlight": {
                "dynamicRegistration": true
            },
            "documentSymbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                },
                "hierarchicalDocumentSymbolSupport": true,
                "tagSupport": {
                    "valueSet": [
                        1
                    ]
                },
                "labelSupport": true
            },
            "codeAction": {
                "dynamicRegistration": true,
                "isPreferredSupport": true,
                "disabledSupport": true,
                "dataSupport": true,
                "resolveSupport": {
                    "properties": [
                        "edit"
                    ]
                },
                "codeActionLiteralSupport": {
                    "codeActionKind": {
                        "valueSet": [
                            "",
                            "quickfix",
                            "refactor",
                            "refactor.extract",
                            "refactor.inline",
                            "refactor.rewrite",
                            "source",
                            "source.organizeImports"
                        ]
                    }
                },
                "honorsChangeAnnotations": false
            },
            "codeLens": {
                "dynamicRegistration": true
            },
            "formatting": {
                "dynamicRegistration": true
            },
            "rangeFormatting": {
                "dynamicRegistration": true
            },
            "onTypeFormatting": {
                "dynamicRegistration": true
            },
            "rename": {
                "dynamicRegistration": true,
                "prepareSupport": true,
                "prepareSupportDefaultBehavior": 1,
                "honorsChangeAnnotations": true
            },
            "documentLink": {
                "dynamicRegistration": true,
                "tooltipSupport": true
            },
            "typeDefinition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "implementation": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "colorProvider": {
                "dynamicRegistration": true
            },
            "foldingRange": {
                "dynamicRegistration": true,
                "rangeLimit": 5000,
                "lineFoldingOnly": true
            },
            "declaration": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "selectionRange": {
                "dynamicRegistration": true
            },
            "callHierarchy": {
                "dynamicRegistration": true
            },
            "semanticTokens": {
                "dynamicRegistration": true,
                "tokenTypes": [
                    "namespace",
                    "type",
                    "class",
                    "enum",
                    "interface",
                    "struct",
                    "typeParameter",
                    "parameter",
                    "variable",
                    "property",
                    "enumMember",
                    "event",
                    "function",
                    "method",
                    "macro",
                    "keyword",
                    "modifier",
                    "comment",
                    "string",
                    "number",
                    "regexp",
                    "operator"
                ],
                "tokenModifiers": [
                    "declaration",
                    "definition",
                    "readonly",
                    "static",
                    "deprecated",
                    "abstract",
                    "async",
                    "modification",
                    "documentation",
                    "defaultLibrary"
                ],
                "formats": [
                    "relative"
                ],
                "requests": {
                    "range": true,
                    "full": {
                        "delta": true
                    }
                },
                "multilineTokenSupport": false,
                "overlappingTokenSupport": false
            },
            "linkedEditingRange": {
                "dynamicRegistration": true
            }
        },
        "window": {
            "showMessage": {
                "messageActionItem": {
                    "additionalPropertiesSupport": true
                }
            },
            "showDocument": {
                "support": true
            },
            "workDoneProgress": true
        },
        "general": {
            "staleRequestSupport": {
                "cancel": true,
                "retryOnContentModified": [
                    "textDocument/semanticTokens/full",
                    "textDocument/semanticTokens/range",
                    "textDocument/semanticTokens/full/delta"
                ]
            },
            "regularExpressions": {
                "engine": "ECMAScript",
                "version": "ES2020"
            },
            "markdown": {
                "parser": "marked",
                "version": "1.1.0"
            }
        }
    },
    "initializationOptions": {},
    "trace": "verbose",
    "workspaceFolders": [
        {
            "uri": "file:///Users/segevfiner/junk/vue-ts-lint-issue",
            "name": "vue-ts-lint-issue"
        }
    ],
    "workDoneToken": "74c1a90c-fc66-445e-af89-6d30a7e65bf7"
}

[Trace - 11:58:38 AM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "ESLint server running in node v16.13.0"
}

[Info  - 11:58:38 AM] ESLint server running in node v16.13.0
[Trace - 11:58:38 AM] Received notification '$/progress'.
Params: {
    "token": "74c1a90c-fc66-445e-af89-6d30a7e65bf7",
    "value": {
        "kind": "begin",
        "title": "Initializing ESLint Server"
    }
}

[Trace - 11:58:38 AM] Received notification '$/progress'.
Params: {
    "token": "74c1a90c-fc66-445e-af89-6d30a7e65bf7",
    "value": {
        "kind": "end"
    }
}

[Trace - 11:58:38 AM] Received response 'initialize - (0)' in 81ms.
Result: {
    "capabilities": {
        "textDocumentSync": {
            "openClose": true,
            "change": 2,
            "willSaveWaitUntil": false,
            "save": {
                "includeText": false
            }
        },
        "workspace": {
            "workspaceFolders": {
                "supported": true
            }
        },
        "codeActionProvider": {
            "codeActionKinds": [
                "quickfix",
                "source.fixAll.eslint"
            ]
        },
        "executeCommandProvider": {
            "commands": [
                "eslint.applySingleFix",
                "eslint.applySuggestion",
                "eslint.applySameFixes",
                "eslint.applyAllFixes",
                "eslint.applyDisableLine",
                "eslint.applyDisableFile",
                "eslint.openRuleDoc"
            ]
        }
    }
}

[Info  - 11:58:38 AM] ESLint server is running.
[Trace - 11:58:38 AM] Sending notification 'initialized'.
Params: {}

[Trace - 11:58:38 AM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///Users/segevfiner/junk/vue-ts-lint-issue/src/App.vue",
        "languageId": "vue",
        "version": 1,
        "text": "


Support manifest comments

Type:

[x] bug
[ ] feature
[ ] enhancement
[ ] question

I'm going to open a PR:

[x] yes (If you agree that this should be addressed.)
[ ] no

Description:
Both Chrome and Firefox state that comments are allowed in the manifest:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json
https://developer.chrome.com/docs/extensions/mv2/manifest/
Yet, they cause this project to crash.
As far as I can tell, you only read the manifest here: https://github.com/SimplifyJobs/webpack-ext-reloader/blob/master/src/utils/manifest.ts#L11
So it should be pretty simple and not add a lot of overhead to strip the comments there. 🙂

This makes sense, and I would welcome a PR!

Damn, I missed that response back in March somehow. Sorry about that! 🙈
(Thanks for taking care of it - should be of help to my former colleagues.)


Add collectionID attribute to the Audio NFT tokens

Description
As explained in #16, Audio NFT tokens should belong to a collection. Therefore the collectionID attribute is required for them.
Assuming this issue is being developed after Collection NFT tokens are implemented, we should refactor the Audio module to include the changes explained in the Acceptance Criteria.
Acceptance Criteria

Audio entity should have collectionID as buffer. This property is required.
The collectionID should correspond an existing collection that belongs to the sender. Otherwise throw relevant errors.
Collections can not be deleted unless all of their Audios are destroyed or moved to collections. e.g. you can destroy a collection only if no audio is assigned to it.

Resolved by #49


Job_id is optional, Reraise exceptions in eager mode

If job_id is not provided by the broker, it shouldn't break the worker
Reraise exceptions in eager mode

+1


Printing Too Far to The Left

Hey, I'm printing spine labels and the issue I'm having is that 6/8 columns and rows print fine, but the last two columns and rows are shifted to the left too much. I adjusted the layout settings a few times but every adjustment I made would not fix the last two columns. Is there a way I can move the last two columns more to the right of the labels? There's 56 labels total, 8 rows and 7 columns. Thank you

I appreciate it

@CKidd368, I can't replicate the problem. It looks like you are left aligning the call number in the template. Is there any other special formatting in the template? If so, you can get the source code of the template by clicking the "..." in the toolbar and then clicking the "<>" icon in the toolbar when you are editing the template. Then share the source code here.
My test results:

Do you have a particular label stock you are using? Manufacturer, stock number, etc? Maybe that information could help me replicate the problem. Thanks.

Here are the labels we are using and the source code

@CKidd368, try these settings for the layout:
Top margin: 0
Left margin: 0
Page width: 8.5
Label width: 1.05
Label height: 1.56
Horizontal gap: 0
Vertical gap: 0
Labels per page: 56
Left padding: 0.25
This one seems so simple; not sure why it's an issue.

I tried the new layout but unfortunately, it didn't resolve this issue. I know it seems simple, I don't know what the issue is exactly. When I make changes to the layout it seems to shift over some of the columns for some reason as you can see if you compare this image to the one I posted earlier in this discussion

@CKidd368, looking at the template you provided, I would try these layout settings:
Measurement units: inches
Top margin: .25
Left margin: .21
Page width: 8.5
Label width: 1.01
Label height: 1.5
Horizontal gap: 0
Vertical gap: 0
Labels per page: 56
Left padding: 0
What manufacturer and model printer are you using?
Thanks.

Here's what it looks like with the layout you recommended:

It's printing too far to the left and too far up
When I go to print and enable "print with gridlines", it looks like it will print perfectly but doesn't. :

This is the closest I got to it printing correctly. Still needs to go a little down and to the left.

For that I used these settings:
Measurement units: inches
Top margin: 0
Left margin: 0
Page width: 8.5
Label width: 1
Label height: 1.5
Horizontal gap: .05
Vertical gap: 0.060
Labels per page: 56
Left padding: 0.25

@CKidd368, which printer driver are you using? PCL5e, PCLXL, or Postscript Level 3? Are there any printer settings/properties with which you could experiment with left and top settings?

We are using the Dell B5460dn Laser Printer XL driver. I can change the paper size width and layout. I don't see any options to change the top and left settings specifically

@CKidd368, I was able to install the printer driver, but everything continues to look fine. Of course, I don't have the label stock you are using, nor the actual printer to test.
What's most interesting to me is that in the template you included earlier, the top margin is clearly .25 inches, and the left margin is .21 inches. Yet, you have best results with both of those set to 0. Do small increases in the top/left margins help at all or does it immediately throw the top/left beyond what you need?

@CKidd368, do you have the "Enable marginless templates and layouts" switch on or off when you print? It should be off.

@CKidd368, when I print labels using the Dell B5460dn printer driver, I see a "More settings" option in the print preview (in Chrome, Firefox and Edge browsers). If you see the same, do you have the correct "Paper size" selected and "None" selected for the "Margins"?

I'll have to get back to you with the results on Monday. (I'm trying to help our librarian with this issue and I don't have access to SpineOMatic on my computer.) I'll make sure to check if the correct paper size is selected and see if "enable marginless templates and layouts" is enabled. Thank you @mgobat

Hey, so I kept the exact layout:
Measurement units: inches
Top margin: 0
Left margin: 0
Page width: 8.5
Label width: 1
Label height: 1.5
Horizontal gap: .05
Vertical gap: 0.060
Labels per page: 56
Left padding: 0.25
And enabled "Enable marginless templates and layouts." When I got to the print page, I clicked on "Margins" and selected "Custom margins" and set the top margin to .13, the bottom margin to .25, and the left and right margins to .25. The labels are now printing correctly. Thank you for all of your help!

@CKidd368. that's great! Thanks for the update.


Missing translated languages on all interfaces

All interfaces are missing translations

What translations should be made available?

all updates that are available to be used on the respective interfaces
Especially select the language through calamares
I speak Portuguese from Portugal and Esperanto

just a quick mention, in KDE plasma there is no translated language


How to get class assignment for columns for predict_proba?

predict_proba returns probabilities for corresponding classes and user needs to know the class correspondence.
In other frameworks this information is accessible through .classes_ instance variable of estimator.
Is there anything like this for DeepTables models? I am currently working with DCN.

@nadiiach  nice suggestion! DT will support it soon.

Now, you can get classes information like this:
dt.fit(X,y)
dt.classes_
dt.num_classes
dt.pos_label  #only for binary classification


Transport layer - remove the CFG_SYSLOG and CFG_SHM ?

I think our code can be adjusted/refactored to remove support for these values - since according to my knowledge they are not used

Done in #1273


Add support for rollback of config to previous version in config client

any update on this? Or any workaround on how to manage rollbacks on either client or config repository?

No plans as of yet


Allow customization of VMServiceScrape in various objects

Hi @f41gh7,
This is my 2nd pull request: kinda big and includes API changes, so I hope that it can be reviewed well before having any next actions.
This pull request solves #454 by adding serviceScrapeSpec on various places, so we can have more flexibility with the generated VMServiceScrape objects.
Thank you.

Thanks for contribution!


Table of Inverse Laplace Transform

I would like to add the table of "Inverse Laplace Transform" under Laplace Transforms and Properties section.

Go ahead
Deadline 24 April,2021 11:59 PM IST


Increase pool stacks to 32

A change like this without literally any accompanying explanation or benchmarks isn't really appropriate. The obvious downside of this change is that it increases memory usage across the board. In particular, that CacheLine is problematic since it takes up 64 bytes on its own. So this change increases base memory usage from 8 * 64 = 512 bytes to 32 * 64 = 2,048 bytes.

@BurntSushi I am so so sorry, I did not mean to open this pull request against the original repo - it was only meant for my fork. I completely understand (and agree) this change is not appropriate across the board!

Thank you so much!
I've filed https://github.com/rust-lang/regex/issues/1241


MonitorControl changing brightness on wrong external monitor

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Looked through the wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the bug
I have two identical p32u-10 monitors plugged into my MacBook Pro (14-inch M1 2021, Monterey 12.4). Most of the time, MonitorControl controls the brightness on the wrong monitor when I use the brightness keys.
I perused https://github.com/MonitorControl/MonitorControl/issues/49 already, but the test build is no longer available.
Steps to reproduce
Bring mouse cursor to screen 1. Press brightness up/down keys. Watch brightness change on screen 2. Vice versa.
Expected behavior
When I have my mouse on screen 1, I expect the brightness to change on screen 1 when using the brightness keys.
Anything else?
No response
Environment Information (please complete the following information)
- macOS version: 12.4
- Mac model: 14-inch M1 2021
- MonitorControl version: 4.1.0 build 7034
- Monitor(s): p32u-10
- Apple Silicon/M1 (yes or no): yes

The monitors are connected natively via USB-C.
Screenshots from BetterDisplay:

.

Does brightness control BetterDisplay exhibit the same issue with brightness control as MonitorControl?
MonitorControl uses vendor/model id to identify displays while BetterDisplay uses UUID by default. If identifiers match up exactly, the OS itself has difficulties telling the displays apart in some scenarios, but the UUID method might be better in this case. The thing is even more complicated for DDC control - as you see, the two displays look exactly the same except for the service location (order in the ioreg tree) which is not very reliable and might change. In some situations it might happen that software and hardware controls got mixed up (software dimming affects one display, while for hardware the other).

I played around with BetterDisplay. At first, it was controlling the correct monitor. However, after changing a few settings/restarting the app, it started controlling the wrong monitor. I couldn't get it to control the correct monitor again - I tried reverting my changes, and I also tried the "Use alternative method to identify displays," to no avail - but I finally gave up.
I prefer the simplicity of MonitorControl anyway. I'll make do with having my cursor on the opposite external monitor for brightness control :). Thanks for your help.

I am facing the exact same issues. I also downloaded BetterDisplay, using it solves the issue of DDC Volume control being linked to the wrong monitor, since both monitors audio devices have the same name and BetterDisplay has an option to control both at the same time. However, it still mixes up the displays. DDC Control applies to the wrong display (without the cursor present) while software brightness control applies to the correct display.
This is the metadata of the screens I am using provided by BetterDisplay:

I have another clue about what might be going on here though. MacOS (without any extra software installed) also frequently switches up the monitors I am using, as if it were just identifying them by their name and not by their id. Whenever I reboot or reattach both screens via USB-C they randomly switch positions. To mitigate this I am using the displayplacer command line tool with the following command, which is activated by a launchd agent whenever any of the two monitors is plugged in:
displayplacer "id:82870237-92A9-4ADE-8FC2-4BB588A6E433 res:3008x1692 hz:144 color_depth:7 scaling:on origin:(0,0) degree:0" "id:37D8832A-2D66-02CA-B9F7-8F30A301B230 res:1496x967 hz:120 color_depth:8 scaling:on origin:(-1496,914) degree:0" "id:0E37B605-4D39-4A31-9962-E33EDA8F7E73 res:3008x1692 hz:144 color_depth:7 scaling:on origin:(3008,0) degree:0"

The odd thing for me now is that MonitorControl always controls the wrong monitor's brightness, every time, no matter what I do.
Whenever I reboot or reattach both screens via USB-C they randomly switch positions
Whenever this happens for me, I simply power off my left monitor, wait a second, and power it back on. This consistently resolves the issue.

It simply depends on the order the displays are enumerated and which gets the lower CGDirectDisplayID ("CGDD ID" in BetterDisplay). When reattaching one of the displays, the order is reversed. As you guys say, even macOS cannot tell the displays apart as they have the same identifier.
Maybe we could add an option to simply reverse the detection order which might help with these kinds of issues. This would not be an exact solution to the problem, but a practical one that would work most of the time. If you could open an issue related to this under BetterDisplay, I could provide a test build to see if this approach helps.


feat: npx svelte-migrate self-closing-tags

Companion to https://github.com/sveltejs/svelte/pull/11114. This adds an npx svelte-migrate self-closing-tags migration that replaces all the self-closing non-void elements in your .svelte files.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

The lint failure here is caused by a battle between this and Prettier, which turns <slot></slot> back into <slot />. I'm not sure why that's happening — prettier-plugin-svelte is supposed to ignore closing tag style as of version 3 — but we'll need to get to the bottom of it before we can release this.

@Rich-Harris Fixed in sveltejs/prettier-plugin-svelte#435.

Fantastic, thank you! Updated the migration task to prompt people to upgrade — as soon as it's released, we'll bump the prettier-plugin-svelte version used in this repo and release this

We should ideally figure out why we now have simultaneous two versions of esbuild as of this PR.

i have absolutely no idea

downgrading prettier-plugin-svelte back to the previous version doesn't seem to change anything

The two versions of esbuild, at least, appears to be because we upgraded Vite in this PR (probably unnecessarily), which depends on a newer version of esbuild - but other things, like some adapters, still depend on the old version.

I've taken the liberty of pushing 3148f190bd3f60ce8fe680db010bd1304a4858a1 - let's see how this looks now.

I think that looks good? For posterity, what I did was grab an old copy of pnpm-lock.yaml from main, run pnpm install again, and commit that.

yeah, aside from the random failing test — investigating

The failing test relates to this file:
https://github.com/sveltejs/kit/blob/3148f190bd3f60ce8fe680db010bd1304a4858a1/packages/package/test/fixtures/typescript-esnext/src/lib/Plain.svelte#L6-L12
Looks like https://github.com/sveltejs/prettier-plugin-svelte/pull/424 introduced a change to how JSON+LD scripts are handled — they are now assumed to contain JSON and formatted as such. The test seems to assume that the contents of these elements are treated literally (i.e. not interpolated) which is wrong. Will update the test.

We should ideally figure out why we now have simultaneous two versions of esbuild as of this PR.

Just FYI, we have two on main since adding better Cloudflare support recently because wrangler is stuck on an old version (https://github.com/cloudflare/workers-sdk/issues/5222).

edit: And two versions of Rollup.

I sent https://github.com/sveltejs/kit/pull/12118 to upgrade vite, vitest, rollup, and esbuild (minus the version being pulled in by wranger, which we can't do anything about)

closing in favour of #12128


[multistage] support having

Codecov Report

Merging #9274 (ff36262) into master (718f41f) will decrease coverage by 0.11%.
The diff coverage is 62.57%.

:exclamation: Current head ff36262 differs from pull request most recent head fd6efc7. Consider uploading reports for the commit fd6efc7 to get more accurate results

@@             Coverage Diff              @@
##             master    #9274      +/-   ##
============================================
- Coverage     68.75%   68.64%   -0.12%
- Complexity     4755     4759       +4
============================================
  Files          1859     1867       +8
  Lines         99129    99312     +183
  Branches      15077    15109      +32
============================================
+ Hits          68161    68176      +15
- Misses        26076    26244     +168
  Partials       4892     4892

Flag
Coverage Δ

integration1
26.19% <23.97%> (-0.23%)
:arrow_down:

unittests1
67.11% <63.98%> (+0.03%)
:arrow_up:

unittests2
15.38% <28.13%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...apache/pinot/broker/api/HttpRequesterIdentity.java
28.57% <0.00%> (-57.15%)
:arrow_down:

...org/apache/pinot/broker/api/RequesterIdentity.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...er/api/resources/LLCSegmentCompletionHandlers.java
43.56% <ø> (-18.82%)
:arrow_down:

...ces/PinotSegmentUploadDownloadRestletResource.java
55.00% <ø> (-0.84%)
:arrow_down:

...che/pinot/core/query/scheduler/QueryScheduler.java
84.56% <ø> (+3.79%)
:arrow_up:

...ache/pinot/server/api/resources/QueryResource.java
0.00% <0.00%> (ø)

...va/org/apache/pinot/spi/utils/CommonConstants.java
27.69% <ø> (ø)

...query/runtime/operator/operands/FilterOperand.java
17.85% <17.85%> (ø)

...perator/query/DictionaryBasedDistinctOperator.java
76.08% <33.33%> (-1.00%)
:arrow_down:

...core/query/executor/ServerQueryExecutorV1Impl.java
80.95% <33.33%> (-1.42%)
:arrow_down:

... and 70 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create template from our Application Insights Dashboard and publish in docs and blog post.

Application Insights Workbooks :https://learn.microsoft.com/en-us/azure/azure-monitor/visualize/workbooks-overview


nix-prefetch-git: add iterative shallow clone, fix invalid refspec

Motivation for this change
avoid full clone in fetchgit
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Describe the bug
nix-prefetch-git fails to do a shallow clone, when the commit is not directly reachable
related:
stackoverflow: How to shallow clone a specific commit with depth 1?
Reproduce the bug
$ /nix/store/*-nixos-$(nixos-version --json | jq -r .nixosVersion)/nixos/pkgs/build-support/fetchgit/nix-prefetch-git \
  --url https://git.torproject.org/tor.git --rev 62a500dd1d3ad012e12b7bf49fad912c9733107a

Actual behavior
full clone = large and slow
Receiving objects: 100% (278793/278793), 62.76 MiB | 5.51 MiB/s, done.

real    0m47.457s
user    0m52.799s
sys     0m3.514s

Expected behavior
iterative shallow clone = small and fast
fetch loop: depth 2: received 2137 objects = 7.80 MiB @ 5.58 MiB/s
fetch loop: depth 6: received 1166 objects = 292.95 KiB @ 3.85 MiB/s

real    0m7.307s
user    0m3.003s
sys     0m1.153s

= 7x smaller and 6x faster
or: shallow clone with correct refspec
Receiving objects: 100% (2133/2133), 7.80 MiB | 5.30 MiB/s, done.

real    0m3.511s
user    0m1.180s
sys     0m0.687s

= 7x smaller and 12x faster
Details

when the commit is not directly reachable
this means:

there is no refspec (tag or branch) to reach the commit.
only the nearest tag can be found ("peeled tag", sample: foo-1.2.3^{})
git clone $url --branch $hash fails,
cos the git server config has uploadpack.allowReachableSHA1InWant = false

example:
the expected tag is tor-<IP_ADDRESS>, but fetchgit requests tor-<IP_ADDRESS>^{}
fatal: invalid refspec '+refs/tags/tor-<IP_ADDRESS>^{}'

"fetch by hash" fails
error: Server does not allow request for unadvertised object 62a500dd1d3ad012e12b7bf49fad912c9733107a

... so fetchgit does fallback to full-clone, which is wasteful

git fetch only works for refs
fetchgit/default.nix says:

NOTE:
fetchgit has one problem: git fetch only works for refs.
 This may
change in the future when some caching is added to git (?)
Usually refs are either tags (refs/tags/*) or branches (refs/heads/*)
Cloning branches will make the hash check fail when there is an update.
But not all patches we want can be accessed by tags.
The workaround is getting the last n commits so that it's likely that they
still contain the hash we want.
for now : increase depth iteratively (TODO)

where does the invalid refspec tor-<IP_ADDRESS>^{} come from?
fetchgit/nix-prefetch-git function ref_from_hash is trying to map the commit hash to a refspec (tag or branch)
$ cd ricochet-refresh/src/extern/tor
$ git ls-remote origin | grep -C1 62a500dd1d3ad012e12b7bf49fad912c9733107a

553177a8ee0c4a698ed05a49994dff7a7137a93e        refs/tags/tor-<IP_ADDRESS>
62a500dd1d3ad012e12b7bf49fad912c9733107a        refs/tags/tor-<IP_ADDRESS>^{}
3b9e8205ef57f6551b9449c23bb39f7ad63a1e18        refs/tags/tor-<IP_ADDRESS>

refs/tags/tor-<IP_ADDRESS>^{} is a "peeled tag" or "annotated tag".
this means, the commit 62a500d comes AFTER the tag tor-<IP_ADDRESS> = commit 553177a
now, fetchgit runs git clone ... --branch '+refs/tags/tor-<IP_ADDRESS>^{}'
which throws the error fatal: invalid refspec '+refs/tags/tor-<IP_ADDRESS>^{}'
fetchgit should clone the next tag, in this case tor-<IP_ADDRESS>,
and from there, seek back to the commit 62a500d.
since the exact distance is unknown, we need "iterative shallow clone"

sample output
$ ./nix-prefetch-git --url https://git.torproject.org/tor.git --rev 62a500dd1d3ad012e12b7bf49fad912c9733107a
Initialized empty Git repository in /tmp/git-checkout-tmp-bQWK82co/tor-62a500d/.git/
error: Server does not allow request for unadvertised object 62a500dd1d3ad012e12b7bf49fad912c9733107a
fetch loop: depth 2: received 2137 objects = 7.80 MiB @ 5.15 MiB/s
fetch loop: depth 3: received nothing
fetch loop: depth 4: received nothing
fetch loop: depth 6: received 1166 objects = 292.95 KiB @ 4.96 MiB/s
fetch loop: depth 9: received nothing
fetch loop: done: found object 62a500dd1d3ad012e12b7bf49fad912c9733107a, type commit
Switched to a new branch 'fetchgit'
removing `.git'...

git revision is 62a500dd1d3ad012e12b7bf49fad912c9733107a
path is /nix/store/44cgvmjr9jvziprv2jmin96c5xz39glm-tor-62a500d
git human-readable version is -- none --
Commit date is 2021-06-10 13:17:19 -0400
hash is 0nwm6h2y31d20h67vqc9hr44z3b359h3dsnifdijw5fcp1h3gwri
{
  "url": "https://git.torproject.org/tor.git",
  "rev": "62a500dd1d3ad012e12b7bf49fad912c9733107a",
  "date": "2021-06-10T13:17:19-04:00",
  "path": "/nix/store/44cgvmjr9jvziprv2jmin96c5xz39glm-tor-62a500d",
  "sha256": "0nwm6h2y31d20h67vqc9hr44z3b359h3dsnifdijw5fcp1h3gwri",
  "fetchSubmodules": false,
  "deepClone": false,
  "leaveDotGit": false
}

where does the invalid refspec tor-<IP_ADDRESS>^{} REALLY come from? (fixed)
553177a = tag tor-<IP_ADDRESS> pointing to commit 62a500d
62a500d = commit of git submodule, in git ls-remote appears as "peeled tag" refs/tags/tor-<IP_ADDRESS>^{}
so the correct solution is

commit 62a500d to peeled tag refs/tags/tor-<IP_ADDRESS>^{}
peeled tag to tag refs/tags/tor-<IP_ADDRESS> = commit 553177a
clone by tag refs/tags/tor-<IP_ADDRESS>
git rev-parse --short HEAD should now be 62a500d

Result of nixpkgs-review pr 135545 at 7a9ba9ce run on aarch64-linux 1

14 packages built successfully:

bundix
cabal2nix
crate2nix
dep2nix
go2nix
haskellPackages.cabal2nix-unstable
haskellPackages.nvfetcher
haskellPackages.update-nix-fetchgit
nix-prefetch-git
nix-prefetch-scripts
nix-update-source
nvfetcher
update-nix-fetchgit
vgo2nix

user was banned https://github.com/NixOS/moderation/blob/main/moderation-log.md


 Just use vscode, goland or a even a terminal like a sane developer...
If whatever IDE you use can't execute the go run main.go or go build commands it's broken and I do not want to support it. Feel free to create a PR if you figure it out though.

That being said if by reading the replit docs you should be able to set environment variables and then run go run cmd/main.go
https://docs.replit.com/programming-ide/storing-sensitive-information-environment-variables


IntelliJ software update fails

I set up my brand new MBP from workstation-setup early this month (September 2018).
A few days ago, I decided to check for updates in IntelliJ. When attempting to install the update I ran into this bug:
https://intellij-support.jetbrains.com/hc/en-us/community/posts/203463924-Upgrading-IntelliJ-IDEA-after-Sierra-Upgrade-does-not-have-write-access-to-private-var
In troubleshooting, I noticed that this repo installs JetBrains products via the Homebrew JetBrains Toolbox install. I was able to work around the bug, but performing the upgrade from JetBrains Toolbox instead of directly in IntelliJ.

Hi Bill,
How do you recommend on solving this issue? Do you think that eventually, Intellij from brew will solve this problem and we should wait for the community to handle it?

Hmm well I see two options:

change this repo to install IntelliJ directly, instead of installing JetBrains Toolbox.
wait for JetBrains to fix the upgrade bug in JetBrains Toolbox

Here's the IntelliJ cask: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/intellij-idea.rb BTW
I don't see any value in JetBrains Toolbox, since the only JetBrains product I use is IntelliJ and if I were to use one more tool, I'd be ok with managing that directly also, so I am inclined toward (1).

We install both Intellij and JetBrains Toolbox.
Intellij is here:
https://github.com/pivotal/workstation-setup/blob/3d1f3203bba7d289154636eabdfeab341ad38a26/scripts/opt-in/java-tools.sh#L3
Toolbox is a recent addition:
https://github.com/pivotal/workstation-setup/pull/220/files
Is Jetbrains Toolbox not seeing the Intellij install from brew?  I
personally would not use Toolbox, but others wanted it included.
On Fri, Sep 28, 2018 at 10:04 AM Bill Burcham<EMAIL_ADDRESS>wrote:

Hmm well I see two options:

change this repo to install IntelliJ directly, instead of
installing JetBrains Toolbox.
wait for JetBrains to fix the upgrade bug in JetBrains Toolbox

Here's the IntelliJ cask:
https://github.com/Homebrew/homebrew-cask/blob/master/Casks/intellij-idea.rb
BTW
I don't see any value in JetBrains Toolbox, since the only JetBrains
product I use is IntelliJ and if I were to use one more tool, I'd be ok
with managing that directly also, so I am inclined toward (1).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pivotal/workstation-setup/issues/230#issuecomment-425501873,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA5preUw6Tr5jIMcSWdxSxL7QVhgtTnks5uflaTgaJpZM4W7Z0p
.


issues comment API : list, create, edit

Implements issue comments API as proposed in https://github.com/gogits/gogs/issues/1692#issuecomment-206590786
The API is similar to github API, except:

the list API still not supporting since parameters
edit comment needs index query parameter

This PR depend on API client lib PR https://github.com/gogits/go-gogs-client/pull/26
docs
List comments on an issue
GET /repos/:owner/:repo/issues/:index/comments

Response
Status: 200 OK
Content-Type: application/json

[
  {
    "id": 4,
    "type": 0,
    "poster": {
      "id": 1,
      "username": "ibk",
      "full_name": "",
      "email"<EMAIL_ADDRESS>      "avatar_url": "https://secure.gravatar.com/avatar/0d02f30bf8f58f6344ea19fd8e26ad6b"
    },
    "issue_id": 1,
    "commit_id": 0,
    "line": 0,
    "content": "id 3 atau apa hayo?",
    "created": "2016-04-09T11:06:35+07:00",
    "created_unix":<PHONE_NUMBER>,
    "commit_sha": ""
  },
  {
    "id": 5,
    "type": 0,
    "poster": {
      "id": 1,
      "username": "ibk",
      "full_name": "",
      "email"<EMAIL_ADDRESS>      "avatar_url": "https://secure.gravatar.com/avatar/0d02f30bf8f58f6344ea19fd8e26ad6b"
    },
    "issue_id": 1,
    "commit_id": 0,
    "line": 0,
    "content": "komen no piro yo, soko postman pokoke",
    "created": "2016-04-11T11:37:31+07:00",
    "created_unix":<PHONE_NUMBER>,
    "commit_sha": ""
  }]

Create a comment
POST /repos/:owner/:repo/issues/:index/comments

Parameters

Name
Type
Description

content
string
the comment

Example
{"content":"this is issue comment"}

Response
Status: 201 Created
Content-Type: application/json
```

{
"id": 9,
"type": 0,
"poster": {
"id": 1,
"username": "ibk",
"full_name": "",
"email"<EMAIL_ADDRESS>"avatar_url": "https://secure.gravatar.com/avatar/0d02f30bf8f58f6344ea19fd8e26ad6b"
},
"issue_id": 1,
"commit_id": 0,
"line": 0,
"content": "this is issue comment",
"created": "2016-04-12T11:18:45+07:00",
"created_unix":<PHONE_NUMBER>,
"commit_sha": ""
}

## Edit a comment

PATCH /repos/:owner/:repo/issues/:index/comments/:id

Parameters

Name    |   Type |  Description
----------  |  ------- | ------------------
content  |  string | the comment

Example

{"content":"metu pora (wis diedit)"}

Response

Status: 200 OK
Content-Type: application/json

{
"id": 8,
"type": 0,
"poster": {
"id": 1,
"username": "ibk",
"full_name": "",
"email"<EMAIL_ADDRESS>"avatar_url": "https://secure.gravatar.com/avatar/0d02f30bf8f58f6344ea19fd8e26ad6b"
},
"issue_id": 1,
"commit_id": 0,
"line": 0,
"content": "metu pora (wis diedit)",
"created": "2016-04-11T11:47:48+07:00",
"created_unix":<PHONE_NUMBER>,
"commit_sha": ""
}

i added since query string support to list issue comment API

Any progress on this? I would love to see this and more rest apis added!

I just tested this locally at our installation and all three API worked for me. Would be good if the code could be reviewed and rebased on the current code.

Please sign the CLA.

@Unknwon done, just signed the CLA

@iwanbk can you also rebase your code against the current state of the develop branch so it is easier for people to test the code.

@iwanbk any news on getting this up2date? There have been more changes to the upstream code so the chunk of work that needs to be rewritten gets larger and larger. I would really love to see this feature in upstream as that would help me to keep my gogs near the develop branch and ease some pain till #813 is implemented.

@hhenkel
Will do it tomorrow. Sorry for the delay

@hhenkel
Will do it tomorrow. Sorry for the delay

Sorry, can't make it today.
I will do it this friday.

Just a quick tip while you fix conflict, now Issue and User both uses *.APIFormat not convert.To*(*) anymore.

@Unknwon thanks for the tips.
But this PR depend on client side PR at https://github.com/gogits/go-gogs-client/pull/26, the build will failed before that PR getting accepted

@Unknwon @iwanbk so is this pr in a deadlock situation now?
iwanbk waiting to have the go-gogs-client stuff merged and Unknwon waiting that the code is refactored against the current head?

@iwanbk sorry for long waiting.
https://github.com/gogits/go-gogs-client/pull/26 has been merged with necessary code cleanup. Please resolve conflict in this PR.

@iwanbk sorry for long waiting.

No problem
 Please resolve conflict in this PR.

Done :)

Thanks!


Export as RDF

Export data from SAGE projects in RDF format (XML files).

Also provide import support from this format.


the link to the datasets used in the paper seems to be broken. Where can we track down the data?

Hello,
were you able to download the code from the 'KG data' link. We are facing the same issue. any help will be appreciated!
Thanks


Add a -h flag option for the CLI

When you type an invalid command for the CLI, the help message isn't very helpful (it tells you to use another invalid command):
ValueError: Invalid command download. use "brainglobe -h for more info."
(atlas) atyson@enc2-node7:~/python/brainreg$ brainglobe -h
Usage: brainglobe [OPTIONS] COMMAND
Try 'brainglobe --help' for help.

Error: no such option: -h

Can we add a -h option with click (I've never used it)?

oh weird, I would've thought that -h would implemented automatically by click. It should be possible though.


Update async tx methods to use 0.11 bp consensus types

It looks like bp Tx is missing a number of useful properties from esplora Tx... See:
https://github.com/BP-WG/bp-esplora-client/blob/689eb8f93282c69a77c98f878492f0726c5d5fe4/src/api.rs#L76-L87
vs
https://github.com/BP-WG/bp-core/blob/cbcaf16c302d0e3bd3b6dbc414d255ed86d37b81/consensus/src/tx.rs#L424-L438
These properties are needed to create a valid TxCredit for bp-wallet. I'm unsure how to resolve this. @crisdut @dr-orlovsky

It looks like bp Tx is missing a number of useful properties from esplora Tx... See:
https://github.com/BP-WG/bp-esplora-client/blob/689eb8f93282c69a77c98f878492f0726c5d5fe4/src/api.rs#L76-L87
vs
https://github.com/BP-WG/bp-core/blob/cbcaf16c302d0e3bd3b6dbc414d255ed86d37b81/consensus/src/tx.rs#L424-L438
These properties are needed to create a valid TxCredit for bp-wallet. I'm unsure how to resolve this. @crisdut @dr-orlovsky

Another object in the bp-wallet is responsible for that: TxWallet.

https://github.com/BP-WG/bp-wallet/blob/master/src/data.rs#L190-L200
https://github.com/BP-WG/bp-wallet/blob/master/src/indexers/esplora.rs#L74-L98


"Move pulled object" keybind / PullController should be using entity coordinates instead of map coordinates

The "Move pulled object" (ctrl+right-click) keybinding is currenly partially broken, depending on where you are on the map.
Content.Server.Physics.Controllers.PullController currently compares the MovingTo map coordinates with a pullable entity's current map coordinates using Vector2.EqualsApprox. This checks if both of the individual vector components are relatively equal. As a result it considers the map coordinates: (500, 0) and (504.9, 0) to be equal, even though they are ~5 tiles apart. The effect is that when not near the centre of the map, trying to move a pulled entity using ctrl+right-click considers relatively large distances to be the "same" position, effectively stopping you from using the "Move pulled object" action.
Instead, this should probably either use vectors defined in the pulled entity's reference frame, or use an absolute distance measure. If using the former solution, then the PullController.MaximumSettleDistance variable should probably be renamed to make it clear that it is a tolerance measure, not an absolute distance.
On a related note, Robust.Shared.Maths.MathHelper.CloseTo does not behave as described in it's comments. It uses the largest values do determine the tolerance level, not the smallest one.

As a result it considers the map coordinates: (500, 0) and (504.9, 0) to be equal, even though they are ~5 tiles apart.
How is this even possible? I'm looking at the code and everything seems fine

Approx equals checks if the X and Y components are approximately equal using
MathHelper.CloseTo(X, other.X, tolerance) && MathHelper.CloseTo(Y, other.Y, tolerance);
with tolerance = MaximumSettleDistance  (i.e., 0.01)
MathHelper returns true if the difference between the two values is less than EITHER the tolerance, or the largest value multiplied by the tolerance (contradicting it's own comments).
So in my example, 0==0 is trivially approximately equal. Meanwhile 500 and 504.9 are within 1% of each other, so for the given tolerance it considers the X coordinates equal.
For example, just try running:
Basically just try running:
var vec1 = new Vector2(504.9f, 0f);
var vec2 = new Vector2(500f, 0f);
var equals = vec1.EqualsApprox(vec2, tolerance: 0.01);

fixed by #4708


Filter may be a PDFArray with a single item

To fix  #96

@Hopding done !

Looks great. Thanks again @mlecoq!


Event table @index operations are not uniform across stores

Description:
We have behaviours as below,
Example - @Index('a', 'b')

In-memory table - An element inside @Index is considered as seperate index i.e 2 indices, 1. a, 2. b
MongoDB - Same as in-memory, however, a.b has to be valid MongoDB indices
RDBMS - The elements are combined to create only one index. i.e 1 index of a and b

Moreover, @Index annotation functionality also differs from @PrimaryKey functionality as in @PrimaryKey we combine all elements to create one primary key however in @Index this is seperate
Affected Siddhi Version:
Siddhi 4.x and relevant extensions

In databases, if you want to create indexes for multiple columns then you have to create individual indexes multiple time.  And if we want to add multiple columns for same index then it is considered as composite index. Then we can have below approach.
If you wanted to create individual indexes for column a, b and c then
@index (a)
@index (b)
@index (c)
If we wanted to create composite index key then we can go as @index(a, b, c). Then, RDBMS extension behavior is correct. We should correct the behavior of in-memory and mongodb. As the first step, we'll print an error log for in-memory if multiple columns are defined within @index annotation and ask the user to define it separately. And we could work on improving the composite index key support for in-memory and mongo db store in future.

+1 for correcting it this way. However, for MongoDB, there is an issue as only getting the column name is not enough. since for index creation, we have to pass 3 params, column name, sorting order and options,
db.myColl.createIndex(
   { score: 1}, { collation: { locale: "fr" } } )

For mongo DB as of now, the index annotation will be as follows,
@IndexBy("volume 1 {background:true,unique:true}")

However, if we want to standardise this, we can go with
@Index('volume:1',  '{background:true,unique:true}')

As it will be easy for composite keys as follws,
@Index('volume:1', 'score:-1',  '{background:true,unique:true}')

Any other suggestions for this?

As long as MongoDB does not have a composite index this approach will be fine.

The support is finished for InMemory, RDBMS and MongoDB.
I have opened the issue for siddhi-store-redis in extension repo. https://github.com/siddhi-io/siddhi-store-redis/issues/30


Create id.js

which language is this?

i think indonesian.

i think indonesian.

Yes, Indonesian language


David Jones Data Engineering Coding Test Solution

Details
This PR implements the solution to the David Jones Data Engineering Coding Test.
Additional Details

Details pertaining to the execution of the solution can be found in the README.md

:shipit:


Otherwise, it won't work.


Weird navigation in Vaadin 23+ demos

Steps to reproduce

Open 23 staging demo site https://addonsv23-staging.flowingcode.com
Go to Orgchart demo
Click the Export button
Open the side menu and go to another demo (e.g. error-window)

Observed behavior
The URL is https://addonsv23-staging.flowingcode.com/orgchart/error-window
Expected behavior
The URL should be https://addonsv23-staging.flowingcode.com/error-window
Observations
It does not happen if you open https://addonsv23-staging.flowingcode.com/orgchart/drag-and-drop instead of steps 1 and 2 above.

I have done some local testing and when clicking the orgchart export button I see this exception in browser console:

Need to investigate more.


Why name the script build instead of compile?

Hey friends! Just a little question/curiosity.
In a lot of babel/coffee modules I see, people name a "build" script in their package.json, just like this boilerplate does, but I've got an issue with that and I'm wondering if I'm just being dense:
npm build is a built-in npm command that builds the package for npm link & npm install. Just calling npm build and expecting it to fall through to the package's "build" script (like one would npm test) creates the false impression that things were just compiled, because that command will almost always run silently and exit code 0.
Because of the potential confusion when mistyping npm build instead of npm run build (and for the fact those two things do different things when npm start|test and npm run start|test do the same thing), it seems to me to be prudent to establish the convention of naming the build script "compile" or some other thing instead, so that npm compile fails loudly when mistyped.
Thoughts?

@gaearon just raised the point that npm uses "build" themselves in their docs: http://blog.npmjs.org/post/118810260230/building-a-simple-command-line-tool-with-npm


Use station name instead of station ID in plotly tooltips

Turns out @jeremylweiss doesn't have all the station IDs memorized!

🤷♂ 🤣


Generated encoder for a case class with None produces invalid json

case class User (name: Option[String], age: Int)
object User {
  implicit val encoder = DeriveJsonEncoder.gen[User]
}

scala> User(None, 37).toJson
res7: String = {,"age":37}

Note the extra comma at the beginning.
If the fields are re-ordered, the json is fine:
case class User (age: Int, name: Option[String])
object User {
  implicit val encoder = DeriveJsonEncoder.gen[User]
}

scala> User(36, None).toJson
res9: String = {"age":36}

Thanks for the report, @alvaroc1.

I'll take a crack at fixing it

Closed by #91


Release v1.1.21

Background
New release for the plugin support.
Demo https://s3.amazonaws.com/vitessce-data/demos/2022-04-27/a1589f3/index.html
Docs http://vitessce-data.s3-website-us-east-1.amazonaws.com/docs/2022-04-27/a1589f3/index.html
Checklist

[ ] Ensure PR works with all demos on the dev.vitessce.io homepage
[ ] Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
[ ] Documentation added or updated

Shortly after making this PR i realized some additional exports for plugins are needed so made https://github.com/vitessce/vitessce/pull/1215, maybe we can get that in first


Add support for adding subscriptions for data changes

The Problem
The BackendClient class currently only supports fetching the snapshots of the current state of requested data (see the fetchAll and fetchById methods).
What we need in addition to this is to add subscriptions for the same pieces of data (all items by type, and one item by id), so that the user of spine-js-client could receive notifications when the data that is being subscribed to changes.
Preliminarily, when subscribing to collection changes, we might receive the following kinds of notifications:

"Item added".
"Item changed".
"Item removed".
Possibly, if order of items can ever be controlled in queries, "Item moved".

Use Cases
This feature can be used for implementing use cases like these in Web UI:

A users visits a page with a list of entities, stays on that page, and needs to see the up-to-date information when other users update this list on their own workstations.
A user opens some entity for viewing and needs to see any data updates that other users make to this entity while it is open.

Same for (long-time) editing of an entity — it might be be helpful to know that another user has edited this entity while the user was editing it.

A Possible API
Here's what such API can look like:
/**
 * @param {TypeUrl} typeUrl
 * @returns EntitiesSubscription
 */
subscribeToAll(typeUrl)

/**
 * @param {TypeUrl} typeUrl
 * @param {TypedMessage} id
 * @returns EntitySubscription
 */
subscribeById(typeUrl, id)

class EntitiesSubscription {
  /**
   * @param {function(Object???)} handler
   *           (we might also need to identify a place in a list where an item is inserted,
   *           if we respect the order of items in our fetches/queries, see also `onItemMoved`
   *           below)
   */
  onItemAdded(handler)

  /**
   * @param {function(Object???)} handler
   *           a function that is passed an entity that was modified (a new version of the entity
   *           is passed here)
   */
  onItemChanged(handler)

  /**
   * @param {function(Object)} handler
   *           a function that is passed an entity that (hash?) was removed
   */
  onItemRemoved(handler)

  /**
   * (optional, depending on whether we're going to respect items order in our queries)
   *
   * @param {function(Object, Number(???how will we define a place in a collection))} handler
   */
  onItemMoved(handler)
}

class EntitySubscription {
  /**
   * @param {function(Object)} handler
   *           an updated version of the respective entity
   */
  onChanged(handler)

  /**
   * @param {function(Object ???see below??? )} handler
   *     (we might not have to implement passing the removed object into the removal callback,
   *     since the one adding a subscription should already know what entity is being subscribed to,
   *     but seems it might still be generally useful, e.g. to be able to attach the same callback to
   *     different entities, if needed, so we might consider implementing it, if it is technically possible)
   */
  onRemoved(handler)
}

Some things that might need to be thought about during the implementation:

Not sure whether any error notifications could also be present here.
Besides, not sure whether any close/dispose/cleanup functionality should be added for subscriptions (whether it is technically needed for an actual subscriptions implementation).

The usage of such an API can be like this:
  const licensesSubscription = backendClient.subscribeToAll(commercialLicensesTypeURL);
  licensesSubscription.onItemAdded(license => { ... } );
  licensesSubscription.onItemChanged(license => { ... } );
  licensesSubscription.onItemRemoved(license => { ... } );
  licensesSubscription.onItemMoved(license => { ... } );

or like this for single entity subscriptions:
  const taskSubscription = backendClient.subscribeById(taskTypeURL, taskId);
  taskSubscription.onChanged(task => { ... });
  taskSubscription.onRemoved(task => { ... });

A Possible Implementation
Not sure whether there's any existing mechanism for this already prepared, but here's just a quick observation that Firebase provides notifications for child updates that seem to align with the list updates functionality that we need. See the "Listen for child events" section here.

Implemented in https://github.com/SpineEventEngine/web/pull/20.