Properly differentiate between multiple anonymous modules

Partial fix for issue #353.
Instead of checking if the prettyprinted qualified module name is a prefix to determine if a module is contained within another, we check if the actual list of Name is a prefix, which uses the internal hashes.
With this fix, calling another function within the same local module will still cause an issue, but at least calling other modules won't cause arguments to magically disappear.
I am also not completely sure if the direction of the check is correct? Wouldn't we want to skip arguments only if calling a function from a surrounding module, rather than only when calling into a submodule? The current version is mostly equivalent to an equality check, since you can't call into a where-clause from outside of it

I tested calling a function from an outer where-clause from a nested where-clause and it did indeed have the expected issue. However, the fix is not as simple as flipping the order of the arguments, since we get the number of arguments from the current module instead of the module where the function is defined. I don't yet know how to get the info from another module that you just have the name of.
nested : Bool → Nat
nested b = inner1
  where
    outer : Nat
    outer = 5

    inner1 : Nat
    inner1 = 2 + inner2
      where
        inner2 : Nat
        inner2 = outer

generates
nested :: Bool -> Natural
nested b = inner1
  where
    outer :: Natural
    outer = 5
    inner1 :: Natural
    inner1 = 2 + inner2
      where
        inner2 :: Natural
        inner2 = outer b -- Notice the extra b argument here

with the current version.

Thank you for the PR, this is great! For the remaining issue, I wonder if we could throw an error when compiling a call to a function from the current module (or a nested one), that module is anonymous and parametrized, and it is not the where module we are currently compiling. But perhaps getting access to all the information for those checks is tricky.

my guess is that it is no more difficult to solve the remaining issue than it is to show that error

this version of the code covers almost all cases, including calling between functions in the same module.
    defIsClass <- isClassModule defMod -- If we're compiling a minimal class
    -- TODO: simplify this when Agda exposes where-provenance in 'Internal' syntax
    isLocal <- asks compilingLocal -- or if we're calling from a where-clause
    localDefs <- asks locals -- or if we're calling into a where-clause

    (ty', args') <-
      -- and we're calling into a module that we're currently in, then we drop the module parameters.
      if f `elem` localDefs (isLocal || defIsClass) && (mnameToList defMod `isPrefixOf` mnameToList currentMod) then do

the only issue that remains is if you call a function in the same local module, from within a where-clause, we currently have no easy way to distinguish it from a binding in an outer where-clause (until Agda exposes where-provenance in 'Internal' syntax), so that call still loses arguments:
module _ (b : Bool) where

    bar : Bool
    bar = True
    {-# COMPILE AGDA2HS bar #-}

module _ (b : Bool) where

    foo : Bool
    foo = True
    {-# COMPILE AGDA2HS foo #-}

    -- Works fine now
    bar : Bool
    bar = foo
    {-# COMPILE AGDA2HS bar #-}

    -- The call to foo won't get the necessary Bool argument here
    callFromNested : Bool
    callFromNested = nested
      where nested = foo
    {-# COMPILE AGDA2HS callFromNested #-}

Now I've added code that keeps track of which where-clauses are currently in scope, so we can use that to determine if the arguments should be removed or not. This change replaced the compilation of the body in the module of the where-declaration, since we keep track of it in a different way now.
https://github.com/agda/agda2hs/blob/078622c928dbf36c0ecbb70143b37780a40dc09a/src/Agda2Hs/Compile/Function.hs#L227-L230
This should fix the last issues. All test cases succeed now!

Awesome! Thanks again.


Metadata Storage

Idea
Sometimes it would be useful to store additional data with IAM Resources.
We could provide a key / value storage to our customers.
Limitations

[ ] Limits size to (n)kb

Which resources might be relevant

[x] Organisation
[x] User

Possibel Scopes

urn:zitadel:org:metadata
urn:zitadel:user:metadata

WIP here https://github.com/caos/zitadel/pull/2025

I will close this issue, because we do have the possibility to store org and user metadata. only thing that is missing is the frontend part for org metadata


Add method to get digits of LitInt in base 10

Something like:
impl LitInt {
    pub fn base10_digits(&self) -> String;
}

This method enables access to the digits of the number without needing to ordain a "widest integer type" in the API. The caller can use FromStr to parse those digits into whatever integer type they need.
After adding base10_digits, we can remove the current fn value(&self) -> u64 in the next breaking change.
The base10_digits implementation will need logic for removing underscores and performing a base conversion on 0x / 0o / 0b literals.

We may additionally want:
impl LitInt {
    pub fn base10_parse<N>(&self) -> syn::Result<F>
    where
        F: FromStr,
        <F as FromStr>::Err: Display;
}

which attaches the literal token's Span to the resulting error.


operator-cli update command fails for gui

When running the command operator-cli update, dry-run fails for gui with the following error (although ls -la shows the gui directory) :
----- STARTING GUI UPDATE PROCESS -----
Found a new version, starting update...
Running update dry run

Cloning into 'gui'...
fatal: Remote branch new-gui not found in upstream origin
update.sh: 30: cd: can't cd to gui

exec error: Error: Command failed: sh update.sh
Cloning into 'gui'...
fatal: Remote branch new-gui not found in upstream origin
update.sh: 30: cd: can't cd to gui

Hey @phy-chain I suspect that you're using the old installer script which is why it is trying to clone the new-gui branch of the Validator GUI which has since been deprecated.
This is the latest install script:
curl -O https://raw.githubusercontent.com/shardeum/validator-dashboard/main/installer.sh && chmod +x installer.sh && ./installer.sh

If you found the old script anywhere in our docs, please share a link to it so we can update


2023 11 13 early access journey

PR Checklist

[X] Set yourself as the Assignee
[X] Tag anyone you would like to review, or @forms-design or @forms-devs
[X] Fill in the template below

What
Added documentation of design work and agreed MVP for the early access journey we are including in the forms platform.
How to review

Do you agree with the write up?
Are there any key decisions or agreements we made that have been misinterpreted or missed?
Spelling, grammar, etc.

Who can review
Anyone in the team can review.

This looks good to me too! I made minor changes as i spotted some typo. It's asking everyone to review it again. Is there a way we can bypass this and just close this PR?


Python instructions don't tell you to install virtualenv

I have a new machine and, after running pulumi new, I get:
Your new project is ready to go! ✨

To perform an initial deployment, run the following commands:

   1. virtualenv -p python3 venv
   2. source venv/bin/activate
   3. pip3 install -r requirements.txt

Then, run 'pulumi up'

Unfortunately, virtualenv doesn't appear to be installed by default, and (unless I missed it), none of our instructions tell you to install it. (Neither the Getting Started guide nor the Python docs.)
It seems we should be explicit about what to do here, especially as it wasn't obvious how to get it on your PATH. For reference, I had to do this on my Mac:
$ pip3 install virtualenv
$ sudo /usr/bin/easy_install virtualenv

This is effectively https://github.com/pulumi/docs/issues/1764 which is being worked on in https://github.com/pulumi/docs/pull/2184.

Resolving as a dupe of #1764.


Somehow "ignore" old CETs during rehydration

Previous CETs are irrelevant after a rollover. However, due to the use of event sourcing, those are still kept around and pro-actively deserialized upon every hydration, regardless of whether or not they are used.
The deserialization of those CETs (around 1.3MB per event) incurs a big performance hit that is significant over time.
We need to somehow address this within the bounds of event sourcing (i.e. deleting the old event is not really a solution :upside_down_face:).
Ideas:

Have a Lazy wrapper around data types that allows to delay deserialization up until the data is actually accessed.
Have an in-memory read-model that keeps the applied CFD around so we don't go to the database for every update but only load the new events.

Why is pruning event (data) not an option?
I think it's far to keep the event around but remove the data of old ones when storing a new, successful rollover.

drive-by, unsolicited suggestion: one way to handle this in event-sourced systems (I haven't dug into the ES in itchysats, so I'm going to be general and hand-wavy) is:

Have a "snapshot" event type that reifies/materializes the state as of event t in the log and store that as entry t+1.
store a start-index on disk with the log that points to the latest snapshot event

Periodically write a new snapshot entry to the log and bump the index stored in start-state. Whenever a node starts up or needs to rehydrate its state (after an update or something), it reads event-log[start-index] to initialize state and then starts replaying all the events that came after it. In this case with old (and no longer relevant) CETs, the CETs would still be in the log, but would be older than the latest state so you won't deserialize them again.

drive-by, unsolicited suggestion:

Very appreciated!

Have a "snapshot" event type that reifies/materializes the state as of event t in the log and store that as entry t+1.

store a start-index on disk with the log that points to the latest snapshot event

Periodically write a new snapshot entry to the log and bump the index stored in start-state. Whenever a node starts up or needs to rehydrate its state (after an update or something), it reads event-log[start-index] to initialize state and then starts replaying all the events that came after it. In this case with old (and no longer relevant) CETs, the CETs would still be in the log, but would be older than the latest state so you won't deserialize them again.

This is very interesting. I hadn't considered the idea of a snapshot event! This should definitely improve the performance for rehydration.
I also added the idea of an in-memory read-model to the original ticket description. When given the choice, would you pick the read-model or the snapshot event as an initial performance improvement?

Why is pruning event (data) not an option? I think it's fair to keep the event around but remove the data of old ones when storing a new, successful rollover.

I am hesitant to do this because it is a pretty unexpected way of dealing with the problem. At the moment we assume that historical CETs are absolutely useless and there is a very high chance that this is the case. However, I'd prefer if we find solutions that mitigate the problem in different ways before we go down the path of selectively deleting data out of old events.
My current, preferred order would be (to optimize rehydration performance, not disk usage):

Check how much we can shave off with https://github.com/itchysats/itchysats/issues/1288, i.e. reduce the storage down to the absolute minimum required
Introduce an in-memory read-model
Snapshot closed CFDs and delete all of their events

Optimizing for long-term disk storage is a different concern but (1) and (3) would also help with that!

The projection actor now keeps in-memory read-model, meaning this problem is solved for now.


vector: 0.13.1 -> 0.14.0

Motivation for this change
https://github.com/timberio/vector/releases/tag/v0.14.0
https://vector.dev/releases/0.14.0/
Here is what I did

add TODO on investigating additional feature flags to enable
remove obsolete feature flags (jemalloc was dropped and rdkafka has a different flag)
add missing buildInputs (oniguruma for onig-sys and zstd for zstd-sys)

Here is what is left to do

the latest version of curl-sys depends on libnghttp2-sys (when http2 feature is enabled). This dependency is only required in the checkPhase. Looking at the underlying library it seems that it needs the following environment variable
DEP_NGHTTP2_ROOT I'm not sure exactly how to set this variable for tests only. I've added it to the checkPhase but it doesn't seem to be passed to the dependency compilation process. I still have the following failure.

libnghttp2-sys-67ea4c7b35af0690/build-script-build` (exit code: 1)
  --- stdout
  TARGET = Some("x86_64-apple-darwin")
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-apple-darwin")
  CC_x86_64-apple-darwin = None
  CC_x86_64_apple_darwin = None
  HOST_CC = None
  CC = Some("clang")
  CFLAGS_x86_64-apple-darwin = None
  CFLAGS_x86_64_apple_darwin = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  running: "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-apple-darwin" "-I" "nghttp2/lib/includes" "-I" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/include" "-DNGHTTP2_STATICLIB" "-DHAVE_NETINET_IN" "-DHAVE_ARPA_INET_H" "-o" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/lib/nghttp2/lib/nghttp2_buf.o" "-c" "nghttp2/lib/nghttp2_buf.c"
  cargo:warning=In file included from nghttp2/lib/nghttp2_buf.c:25:
  cargo:warning=In file included from nghttp2/lib/nghttp2_buf.h:32:
  cargo:warning=nghttp2/lib/includes/nghttp2/nghttp2.h:55:10: fatal error: 'nghttp2/nghttp2ver.h' file not found
  cargo:warning=#include <nghttp2/nghttp2ver.h>
  cargo:warning=         ^~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=1 error generated.
  exit code: 1
  running: "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-apple-darwin" "-I" "nghttp2/lib/includes" "-I" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/include" "-DNGHTTP2_STATICLIB" "-DHAVE_NETINET_IN" "-DHAVE_ARPA_INET_H" "-o" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/lib/nghttp2/lib/nghttp2_callbacks.o" "-c" "nghttp2/lib/nghttp2_callbacks.c"
  cargo:warning=In file included from nghttp2/lib/nghttp2_callbacks.c:25:
  cargo:warning=In file included from nghttp2/lib/nghttp2_callbacks.h:32:
  cargo:warning=nghttp2/lib/includes/nghttp2/nghttp2.h:55:10: fatal error: 'nghttp2/nghttp2ver.h' file not found
  cargo:warning=#include <nghttp2/nghttp2ver.h>
  cargo:warning=         ^~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=1 error generated.
  exit code: 1

  --- stderr

  error occurred: Command "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-apple-darwin" "-I" "nghttp2/lib/includes" "-I" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/include" "-DNGHTTP2_STATICLIB" "-DHAVE_NETINET_IN" "-DHAVE_ARPA_INET_H" "-o" "/private/tmp/nix-build-vector-0.14.0.drv-0/source/target/debug/build/libnghttp2-sys-a9070bd53e651889/out/i/lib/nghttp2/lib/nghttp2_buf.o" "-c" "nghttp2/lib/nghttp2_buf.c" with args "clang" did not execute successfully (status code exit code: 1).

Not sure where to override some of these flags.
Here are some questions I still have but that can be ignored for now.

The rdkafka thing is basically some feature to enable kafka. Should we have a flag to mark it as optional and drop it by default. I personally don't use kafka but I don't know what the majority of users does.
if we leave rdkafka in and don't care that much about closure size, should be not enable the disk-buffer feature based on leveldb. I'm not even sure what that feature exactly is, but I'm guessing it's a performance improvement.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

@danieldk If you are not busy, could I request your help on this? If you feel the issue is not detailed enough or if you don't have time, no worries.

@danieldk If you are not busy, could I request your help on this? If you feel the issue is not detailed enough or if you don't have time, no worries.

From a quick look it seems at the output that you posted, it seems that the include directory of nghttp2 is not not added to cflags (per -I). You could try adding ibnghttp2 to checkInputs.

The rdkafka thing is basically some feature to enable kafka. Should we have a flag to mark it as optional and drop it by default. I personally don't use kafka but I don't know what the majority of users does.

Kafka is one of the number one source/sinks for a tool like Vector, in my experience. Ideally we should keep it, IMO (though frankly rdkafka is a rather tiresome dependency, in my experience.)

if we leave rdkafka in and don't care that much about closure size, should be not enable the disk-buffer feature based on leveldb. I'm not even sure what that feature exactly is, but I'm guessing it's a performance improvement.

Yes, but IIRC I removed leveldb support largely because it was broken on AArch64 at the time and I hadn't taken time to re-enable it. If it can be enabled, it should. (Frankly, the use of leveldb is supremely annoying as well, not only because it seems poorly supported on AArch64 but because it adds a whole bunch of C code that Cargo needs to deal with; the only pure Rust alternative I can think of at the moment is a library like sled which is unfortunately not yet ready.)

@thoughtpolice thanks a lot for your input on this, I'm adding comments for our future selves to remember :-)
I have one more question. You overrode the checkPhase because of the need to pass an env var to cargo test, correct?
the checkPhase is
checkPhase = "TZDIR=${tzdata}/share/zoneinfo cargo test --no-default-features --features ${lib.concatStringsSep "," features} -- --test-threads 1;
The idea was to not define that TZDIR variable for the buildPhase since it's not needed, correct?
I'm asking since the --test-threads 1 can be enabled by having dontUseCargoParallelTests = true; and there is a checkFlags variable that can be passed.

@danieldk thanks a lot for your help on this. I think you are right, it's a missing include!
Looking at the cargo-check-hook it seems that checkInputs is not used, am I wrong?
https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/rust/hooks/cargo-check-hook.sh
In this case the checkPhase has been overidden since it needed to include an environment variable just for the checkPhase.
Here is what I tried.
something with RUSTFLAGS="-C link-args=\"-I ${libnghttp2.dev}/include\"" it didn't work.
I posted an issue in the original rust library to see if he has more info.
There seems to be something like link-arg as well, but I couldn't find how to make it work.
Instead of RUSTFLAGS you can pass the flags directly to the command but it seems that if you do that, those flags won't be used for dependencies of dependencies.
This is what I found out so far, not really sure where to go next.

I've disabled the test for now. I've opened an issue in nghttp2-rs asking how to pass a http2 at compilation
https://github.com/alexcrichton/nghttp2-rs/issues/2
Since disabling tests could be controversial, I'll leave this open for a bit to enable people to comment.

I've disabled the test for now. I've opened an issue in nghttp2-rs asking how to pass a http2 at compilation
https://github.com/alexcrichton/nghttp2-rs/issues/2
Since disabling tests could be controversial, I'm going to leave this open for a bit.
I tested building on local and it worked, but I see there are some CI failures, will investigate.

I've learned a bit more
the rdkafka/dynamic_linking feature that I thought was an old flag that had been removed is not a vector feature flag but a flag for a dependency.
the syntax with a slash enables you to pass specific feature flag to dependencies.
I put it back again, it seemed to be the cause of the failure for linux x86_64 and AArch64.
Regarding the failing tests. I'm trying just disabling the tests for darwin. I want to check with the ci if the tests pass for linux.
Regarding the dev-dependency compilation failure. I've put a comment but here is the gist of it.
on of the dev-dependency of vector is httpmock, which in turns depends on isahc which depends on curl-sys enabling http2 feature. I tried passing specific features,, but you can't pass feature flags to dependencies of depencies.
I tried

curl-sys/force-system-lib-on-osx but that doesn't work since curl-sys is not a direct dependency of vector.
httpmock/isahc/curl-sys/force-system-lib-on-osx but that doesn't work since you can't have slashes after a slash inside a feature.

Another possibily I thought, could be to override the cargo.toml of one of the dependency with a patch.
If the tests pass on other platform than darwin, then I would like to avoid that.

The aarch64 error seem to be a timeout.
The linux build passes.
I think this is in a mergeable state.
Leaving it open until monday just in case anybody wants to have a look


dev: Refactor Loops in Orion

With the integration of Cairo 2.5.x into Orion, it's an opportune moment to enhance our loop structures. Here's a guideline for the refactoring process:

Prioritize the adoption of while loops as detailed in the Cairo Book.
In cases where while loops are not suitable, ensure that array iterations conform to best practices for clarity and performance, as outlined in the guide on idiomatic array looping.

hi @raphaelDkhn , may i work on this issue?

@raphaelDkhn  i'm also refactoring other stuff :

panic! macro now available instead of panic
array! macro for instantiating and filling arrays in a single line
homogeneity in some files : for ex , a few functions in tensor helpers use  return x;, and other x  for the return value, i make it consistent

tell me if this is ok for you :)

Perfect Thank you :)
Cairo has changed a lot since Orion's first commits. An refactoring is definitely in order! Thanks!

@raphaelDkhn  just some news :
I noticed using macros is not really gas efficient, for example :
#[cfg(test)]
// 101270
#[test]
#[should_panic]
fn test_panic_macro_gas() {
    panic!("The input is an empyt optional-type.")
}

// 800
#[test]
#[should_panic]
fn test_panic_function_gas() {
    panic(array!['The input is an empty', 'optional-type.'])
}

or for assert :
#[cfg(test)]
// 9970
#[test]
fn test_assert_macro_gas() {
    assert!(1 == 1, "");
}

// 990
#[test]
fn test_assert_function_gas() {
    assert(1 == 1, '');
}

I think you might to keep functions instead of macros for gas efficiency?

@raphaelDkhn  just some news :
I noticed using macros is not really gas efficient, for example :

#[cfg(test)]

// 101270

#[test]

#[should_panic]

fn test_panic_macro_gas() {

    panic!("The input is an empyt optional-type.")

}

// 800

#[test]

#[should_panic]

fn test_panic_function_gas() {

    panic(array!['The input is an empty', 'optional-type.'])

}

or for assert :

#[cfg(test)]

// 9970

#[test]

fn test_assert_macro_gas() {

    assert!(1 == 1, "");

}

// 900

#[test]

fn test_assert_function_gas() {

    assert(1 == 1, '');

}

Maybe  you might want to keep functions instead of macros for gas efficiency?
For assert, consumption is small in both cases, but the returned string will cost way more with the macro (but anyway, if the assertion fails, the programm will stop so it is not a big deal)

Wow that's great! Thanks @TAdev0! Yes we can replace with functions if it improves performance efficiency

Same applies for panic :
#[cfg(test)]
// 101270
#[test]
#[should_panic]
fn test_panic_macro_gas() {
    panic!("The input is an empyt optional-type.")
}

// 800
#[test]
#[should_panic]
fn test_panic_function_gas() {
    panic(array!['The input is an empty', 'optional-type.'])
}

panic! macro is more convenient, but less efficient, will stick to panic function everywhere !


Add Teams resources

Pull Request

Pull Request (PR) description

Add config for teams resources.
Added

Teams Resources

Task list

[x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@raandree, all good to go now.

Thanks, @dan-hughes!


Add docs how to pass YAML config to docker run

The README.md file does not include information on how to run the docker db-sync image with the YAML config file.

It is included now in the installation guide:
https://github.com/MerginMaps/mergin-db-sync/blob/master/docs/install.md


Principal component Analysis(PCA),K-Means, Logistic Regression, Linear regression

I am a GSSOC 21's participant and want to work on the algorithms- Principal component Analysis(PCA), K-Means, Logistic Regression, Linear regression. kindly assign me.

I am a GSSOC 21 participant, I will like to contribute, please assign me this

Hi I am GSSoC'21 participant , I would love to contribute this algorithms. Kindly assign it to me.

@Rutikab12 I have updated the issues list you can claim one of those among these.

assign me PCA or K-means

@ashwani-rathee please assign me with PCAas It would also help me for a better grasp

All these have been assigned already for next 4 days,you can check the updated issues to see which issue is assigned and which is free.


[KeyVault] BREAKING CHANGE: az keyvault role assignment/definition list: roleDefinitionName should be roleName in command output

Description

roleName is the name of a role, which is provided by user as the display name.
roleDefinitionName is the name of a role definition, which is a GUID. It's called roleDefinitionName in the request body while is called name in response.

This pr provides two improvements

In the current command output of az keyvault role assignment/definition list, the roleDefinitionName actually is roleName, this pr fixes the problem.

previously

now

Besides, the pr provides another column for the table view of command az keyvault role definition list, so that users won't be confused by the two names.

previously

now

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

we'll need communicate with Amit about the change

we'll need communicate with Amit about the change

Sure, i'll do that

Have confirmed with service team about the breaking changes, they agree to fix. @yungezz @fengzhou-msft Please find time to review.


Settings -- Tabs not saving

I'm having an issue with trying to add/change my tabs. I go into the settings change the tabs/config and when I click save nothing happens.

that is very interesting.  What version of PHP are you running?  Are the file permissions set correctly?  Does it display an error when clicking save?

PHP 7.0.9-1+deb.sury.org~wily+1 (cli) ( NTS ) I was able to setup all of my other tabs initially. Came back a day later and couldnt add anymore. No errors. Here's a gif.
http://i.imgur.com/yDQHjhS.gifv

Thank you for the clip. I'm going to do some testing and see what the heck happened.

Alright. Let m eknow if you want anything tested. Its great so far besides this lil hiccup.

ok, so I ran some tests and it looks like it is a permissions issue.  make sure you change the owner to your webserver.
i.e.
sudo chown -R www-data /var/www/html
When I had the incorrect permissions it did exactly what yours did.  I'll make sure to code it so it throws an error.  Lemme know.

I have the permissions setup as follow:
/var/www/html/dash$ ls -l
total 100
-rw-rw-r--  1 admin www-data  2081 Aug  6 20:44 README.md
drwxrwxr-x+ 2 admin www-data  4096 Aug  6 20:44 css
-rw-rw-r--  1 admin www-data   988 Aug  6 20:44 example.ini.php
-rw-rw-r--  1 admin www-data 21297 Aug  6 20:44 favicon.ico
drwxrwxr-x+ 2 admin www-data  4096 Aug  6 20:44 fonts
drwxrwxr-x+ 3 admin www-data  4096 Aug  6 20:44 img
-rw-rw-r--  1 admin www-data  8825 Aug  6 20:44 index.php
drwxrwxr-x+ 2 admin www-data  4096 Aug  6 20:44 js
-rw-r--r--  1 admin www-data  1037 Aug 10 22:15 settings.ini.php
-rw-rw-r--  1 admin www-data 31070 Aug  6 20:44 settings.php
-rw-rw-r--  1 admin www-data  2953 Aug  6 20:44 setup.php
Are the www-data group permissions sufficient?

Looks like the settings.ini.php file doesn't have write permission for the group. Chmod 775 for that file.

did it work @mrdeadlocked


Feature: Dry Run

Please add an option to run the script just to show what would be removed instead of removing right away.

PR: https://github.com/spotify/docker-gc/pull/94

This PR is merged


Fix resource resourceVersion inconsistency with member clusters in list/watch operation

What type of PR is this?
/kind bug

What this PR does / why we need it:
When querying resources using list or watch, the resourceVersion of the resource keeps changing, but the resourceVersion of the resource in the member cluster does not change.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Fix resource resourceVersion inconsistency with member clusters in list/watch operation.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @RainbowMango

LGTM


feat: add agent_id filter for topology

Fixes: #175

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Work with Moby Dock to iron out shibboleth deployment issues

Might involve changing existing infrastructure for deployment (i.e. having all services except database in the save container)
Fix blank page for the /Shibboleth.sso routes

Moby Dock fixed the Shibboleth issue by adding this to the apache config file.
<Location /Shibboleth.sso>
SetHandler shib
</Location>

All services are now being consolidated into 1 container.


Fix bad Coingecko API header key

Fixes the Coingecko header key to hold the ERC20 contract addresses when retrieving prices (bug introduced in this commit)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 91.395%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
4802

Relevant Lines:
5127

💛  - Coveralls


Setup Travis correctly for phpspec (+ cache improvements)

Currently, Travis is not used the run the test. There are tests, so might as well run them :)

Use phpspec instead of phpunit
Add php 5.6/7.0 to build matrix
No need anymore to install the composer phar
use composer retry to install the composer dependencies
Prefer dist + use the cache/sudo settings to cache the downloads from composer for faster builds.

After this, Travis still needs to be setup as hook by the author.

@antonioribeiro Can you enable Travis on the repo?

Done


3.2.3 needs a real tag

When going to http://pywps.org/download/ and clicking All Releases 3.2.3 does not show up on GitHub releases.
I believe this is because there is no release tag per se against 3.2.3, and that the download links:
https://github.com/geopython/pywps/archive/pywps-3.2.3.tar.gz
https://github.com/geopython/pywps/archive/pywps-3.2.3.zip
are actually based off the 3.2.3 BRANCH, not TAG.
Can we tag 3.2.3 off the 3.2.3 branch to make it a true GitHub release?
Moving forward, once we merge pywps-4 branch into master, we can branch pywps-4.0 once 4.0.0 is final.

Done.


PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Lets rip out httplib and replace with requests and use requests kerberos
Notes

Will not work out of the box, since requires virtualenv on anaconda
Excluded the IT from list, needs to be invoked manually
mvn -Dit.test=org.apache.phoenix.end2end.SecureQueryServerPhoenixDBIT verify

Standalone install
This is currently a manual procedure with a few steps due to the current version not being in a public pipy and also the fact that we had to fork requests-kerberos

Create a python virtual environment by calling conda create or virtual-env
. activate the virtual environment
pip install phoenix/python/phoenixdv-module
You need kerberos credentials run kinit
Profit

Example script
import phoenixdb
import phoenixdb.cursor
import sys

if __name__ == '__main__':
    pqs_port = sys.argv[1]
    database_url = 'http://localhost:' + str(pqs_port) + '/'

    print "CREATING PQS CONNECTION"
    conn = phoenixdb.connect(database_url, autocommit=True, auth="SPNEGO")
    cursor = conn.cursor()

    cursor.execute("CREATE TABLE users (id INTEGER PRIMARY KEY, username VARCHAR)")
    cursor.execute("UPSERT INTO users VALUES (?, ?)", (1, 'admin'))
    cursor.execute("UPSERT INTO users VALUES (?, ?)", (2, 'user'))
    cursor.execute("SELECT * FROM users")
    print cursor.fetchall()

Replaces #307

This looks awesome, @pu239ppy. Testing it out.

This looks awesome, @pu239ppy. Testing it out.

Hi @joshelser , did you finally managed to test it out successfully?

@akhmadMizkat this solution currently does not work, please see latest commentary on PHOENIX-4688 for description.  There are existing solutions to remediate this, however I was hoping not to distibute a patched version of requests-kerberos

@pu239ppy thank you for the clarification. Hope they can accept your PR on the requests-kerberos. Really looking forward for that.

Hi @joshelser , did you finally managed to test it out successfully?

No, sadly. I didn't get the last variant working. Pulling down this version and trying again.

2018-09-27 14:05:06,308 ERROR [main] end2end.SecureQueryServerPhoenixDBIT(358): + python /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.py 50023
2018-09-27 14:05:06,309 ERROR [main] end2end.SecureQueryServerPhoenixDBIT(358): /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.sh: line 60:  7582 Illegal instruction: 4  python $PYTHON_SCRIPT $PQS_PORT

We're back to this junk again. @pu239ppy what version of Python are you running for which this is working?

Ok, with python 3.6.5, downgrading to pykerberos to 1.1.14 (in requests-kerberos), and updating test_phoenixdb.py for python3 print syntax, it works!!!

Oops, forgot one more thing. I changed the integration test that had heimdal syntax because, even though I have OSX, I have MIT Kerberos installed.
Although, now that I think about it, do we need to generate a specific krb5.conf based on OS at all? The embedded KDC is provided by Kerby from Apache Directory -- it's not Heimdal or MIT Kerberos. That can be cleaned up completely.
@pu239ppy let me know. I can send a pull request to your branch if you're ready to just be done with these changes. I want to poke around some more at Python versions that work locally.

Awesome guys. This is a very good improvement for the phoenixdb library.

Python version has to >= 3.6.5?
@joshelser @pu239ppy

Hey @Reidddddd -- likely other version of Python will work too, we just only tested using 3.6.5


Is one postgres_expoter can connect only one database address?

As far as I understood , yes. So e.g. in kubernetes one would need to create a separate deployment with a separate datasource name.

What happens if both exporters are returning the same fields?  Is there any way to segment the results?  Or would you need to spin up a separate Prometheus for each to dump metrics to?
We have a master and two read slaves and I'm trying to come up with a good solution for getting metrics into Prometheus without overcomplicating things.


why no protractor tests documentation for angular 2

In official angular 2 documentation for testing there is no detailed informtion for e2e testing.

What do you mean by "detailed information on e2e testing"?

There's a mention of Protractor on the Features and Benefits page under Testing; there's a description of the e2e/ directory as Jasmine tests to be run by the Protractor test runner; likewise a mention of protractor.conf.js in the QuickStart guide; many mentions in the Upgrading from AngularJS guide; and a single table entry describing Protractor in the Testing guide.
That might be what he means by no detailed information. Detailed information would be (perhaps) guidance similar to that for writing Jasmine tests running under the Karma runner.

@nikhilrayaprolu and @luskwater
What do you expect for information and where do you expect it? Do you expect

Protractor to tell more about Angular 2,
orAngular 2 to tell more about protractor.

If you mean 1, than we are happy to see a PR, if you mean 2 than I would say to add a PR on the Angular website. We can then also close this issue if you agree.
Tnx in advance

In my Update above, I noted that there was a whole Protractor subdomain of angular.io. This has given me enough to work with at the moment.  The official Angular guides probably could do with a link saying, "Look here for more on Angular and Protractor," even if it's just pointing next door to the Protractor and Angular site.

@luskwater ,
Sorry, tnx for your reaction. Do you agree that is is sufficient and that we can close this issue?

If someone with suitable privs (I'm on a billable project, and don't have time for the contributor paperwork I might need to change the docset) can just go to the QuickStart guide (mentioned above) and the single entry in the Testing guide, and add,

Learn more about using Protractor for end-to-end testing of Angular

to each of those mentions of Protractor (on the Angular side), then I'd say, "Close the issue."

Because this is concerning adjusting documentation on a different project then the Protractor git I'm gonna close this for now.
Feel free to add a PR on the Angular docs site to make a reference to Protractor / Add a PR to the Protractor Git if you are missing docs.


fix: typos in documentation files

This pull request contains changes to improve clarity, correctness and structure.
Description correction:
Corrected exern to extern.
Please review the changes and let me know if any additional changes are needed.

@dot-asm Hi! Apologies for the inconvenience. I just wanted to check if there’s anything I can improve in my pull request. Please feel free to ask any questions or let me know if any changes are needed to meet the project's merge requirements. I’m happy to make adjustments!

I've chosen to remove the struck out phrase. Thanks.


PM - Get rid of some weak functions

This pr changes how pm policies and notifications are done. Instead of using weak functions that can be override by the application this pr defines new types and APIs for that. I kept the same behavior and name conventions for now, the idea is to do incremental steps. Currently I took slightly different approaches between the notification and policy API. For the policy, the API allows application to extend the basic policy, that is a little bit different from what we have being done so, any feedback is welcome here.
The next step, is to define a better name convention for power management, organize headers, power states, ... (ensure that points agreed in https://github.com/zephyrproject-rtos/zephyr/pull/27315 are addressed)

A few additional comments based on current status. Some of my previous ones may still be relevant.

Thanks for reviewing it. I'll check them again, but I believe they were either addressed or became invalid with latest changes


Provide TypeScript type definitions for MWS JSON responses

Hi,
would it be possible to provide TypeScript type definitions for the different MWS JSON responses? For example, a call to mws.reports.submit({'Version': '2009-01-01', 'Action': 'RequestReport', ...) would provide the following result:
// Base type for Report Responses
export type ReportResponse = {
	Headers: { [key: string]: string; };
	StatusCode: number;
	ResponseMetadata: { RequestId: string };
	Type?: string;
	Code?: number;
	Message?: string;
}

// RequestReportResponse
export type RequestReportResponse = ReportResponse & {
	ReportRequestInfo: ReportRequestInfo;
}

export type ReportRequestInfo = {
	ReportType: string;
	ReportProcessingStatus: string;
	EndDate: string;
	Scheduled: boolean,
	ReportRequestId: string;
	SubmittedDate: string;
	StartDate: string;
	CompletedDate: string;
	GeneratedReportId: string;
}

I'm going to create type definitions for a few API calls as I need them. I could provide them as PR, if you are interested in taking them into your project?

@chriszirkel Sure, I would like to add this.
Please take a look a this file https://github.com/bhushankumarl/amazon-mws/blob/master/index.d.ts.

@chriszirkel Sure, I would like to add this.
Please take a look a this file https://github.com/bhushankumarl/amazon-mws/blob/master/index.d.ts.


Test the Resolver against the varisat Library

Resolution can be reduced to the SAT problem. So this is an alternative implementation of the resolver that uses a SAT library for the hard work. This is intended to be easy to read, as compared to the real resolver, and run as part of the test sweet to make sure the real resolver works as expected. Part of #6120.
Some notes on performance:
The initial version did not support public & private deps:
~64 loc, O(nln(n)) vars, O(nln(n) + n*d) clauses, 0.5x slower on prop_passes_validation
The final version:
~163 loc, O(dn^2) vars, O(dn^3)  clauses, 1.5x slower on prop_passes_validation
That comparison makes me feel better about spending months trying to get public & private deps to be fast enough for stabilization.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

cc @jix

@bors: r+
Nice! I won't really pretend to understand what's going on here, but having more tests always sounds good to me!

:pushpin: Commit e08d0324828c8c39419347c91c84ba649829f8f4 has been approved by alexcrichton

:hourglass: Testing commit e08d0324828c8c39419347c91c84ba649829f8f4 with merge a7648c75429f03595ec367d24823dfb3422555a5...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing a7648c75429f03595ec367d24823dfb3422555a5 to master...

So after this PR prop_passes_validation is by far the slowest test in the sweet. Using profile overrides we can fix this by compiling varisat with optimizations and/or without debug-assertions. If we need to fix this before profile overrides is stable, we can tweak the number of cases generated by proptest. The structure of the SAT problem is generated once per index case.  So if cases: 256 and .take(20) is to slow we can try cases: 128 and .take(40). Alternately @jix offered to make a feature to disable debug-assertions, if we need it.


Twitter Social Link Preview Configuration Needed

The combo/id pages have handling for a Twitter preview, but the other pages do not. Definitely need to fix that ASAP.

Here's how the configuration looks on the combo detail page: https://github.com/Commander-Spellbook/website-v2/blob/f272285979eafa5c18161c92f859006b1cb0185f/pages/combo/_id.vue#L297-L321
Here's where the configuration needs to be added for the rest of the site: https://github.com/Commander-Spellbook/website-v2/blob/f272285979eafa5c18161c92f859006b1cb0185f/nuxt.config.js#L13-L22


Missing variants for 4-letter syllables in Korean

I'll show the problem using 있 syllable, but I think several other variants may have the same issue:
이ᄉ: "잇", (3+1):
https://github.com/simple-keyboard/simple-keyboard-layouts/blob/6775b2402a0bcdfb3ba13772ba447f3d9686ab1a/src/lib/layouts/korean.ts#L7071
But 있 is constructed from 이ᄊ: "있" (2+2):
https://github.com/simple-keyboard/simple-keyboard-layouts/blob/6775b2402a0bcdfb3ba13772ba447f3d9686ab1a/src/lib/layouts/korean.ts#L7072
Due to the lack of ᄊ (2), we're not able to construct 있 as it should be 잇ᄉ: "있" for that case. I think that 4-letter syllables should have matching 3+1 variants, as any 2+2 won't be resolved by current impl.

Same response as https://github.com/hodgef/simple-keyboard/issues/1994#issuecomment-1574342178

Hmm, did you generate korean.ts using some kind of script? This file is pretty long and knowing that you're not familiar with Korean, I assume it was somehow automated.

Unfortunately, I do not recall the sources (will link it as soon as I find it) but yes it was generated through script. Let's continue this conversation in https://github.com/hodgef/simple-keyboard/issues/1994#issuecomment-1574342178 as the CandidateBox logic is all done in the main library. Thanks!


fix(legacy-plugin-chart-nvd3): disable bad linting rule

🐛 Bug Fix
The import/extensions rule makes it impossible to correctly import ts from js.

It's approved, tests pass, but codecov is confused. Merging!


Create issue templates

This repo has basically 2 types of issues:

Bug
Simple task

It would be nice to add templates for them that will be automatically shown when creating an issue. We can copy the ones we have on the qiskit.org repo:

Template for bugs
Template for simple task

The ones we have on Terra might actually be a little better - they use the new GitHub forms.  I've been meaning to update the Qiskit/qiskit ones as well, so I might do that.

I agree! Let's go with the Terra ones :), thank you!

This repo doesn't get much traffic anymore. Going to close as low priority.


Problems with local install

Hi Cole,
I am facing problems with the local install. I am afraid I didn't understood the following instruction:
"When working locally comment out url or else you will get a bunch of broken links because they are absolute and prefixed with {{ site.url }} in the various _includes and _layouts. Just remember to uncomment url when building for deployment or pushing to gh-pages..."
Which url? Could you pls provide a screenshot?
Thank you!

This would be in the _config.yml I believe. I've changed my workflow a little bit so this is no longer present in the config.yml.
Try running jekyll with a new baseurl, like jekyll serve --baseurl localhost:3000
http://jekyllrb.com/docs/configuration/
— Cole  ________________________________
Phone:<PHONE_NUMBER> Skype: cole.n.townsend
Twitter: http://twitter.com/twnsndco
On Wed, Feb 18, 2015 at 12:11 PM, Stefania Druga<EMAIL_ADDRESS>wrote:

Hi Cole,
I am facing problems with the local install. I am afraid I didn't understood the following instruction:
"When working locally comment out url or else you will get a bunch of broken links because they are absolute and prefixed with {{ site.url }} in the various _includes and _layouts. Just remember to uncomment url when building for deployment or pushing to gh-pages..."
Which url? Could you pls provide a screenshot?
Thank you!
Reply to this email directly or view it on GitHub:
https://github.com/ColeTownsend/Balzac-for-Jekyll/issues/20


Wrong version

The version in the project file (0.4.7) doesnt match the one of the latest release (0.5.0)

https://github.com/abichinger/semantic-release-pypi can fix this

As a workaround I've been installing from GitHub... no wheels available this way though, publishing correctly would be much better
scrcpy-client<EMAIL_ADDRESS>

OK actually I think this was occurring because the CI was broken. I just fixed the CI, so it should (hopefully) be fine now. We need to retroactively manually publish the versions for which the CI failed. @leng-yue

0.4.8
0.4.9
0.5.0

I'll try to watch the CI to confirm that I did indeed fix it.


Hydrofab2ngen tools

For review -- may replace #26
More details coming...

@JordanLaserGit
Could we work with @arpita0911patel  to create the template files for each of the VPUs and store those in the CIROH cloud buckets?
That would save everyone quite a bit of time and could be a step towards more efficient data access...

watching

Almost there -- need to resolve subset import issue.


Preserve manifest ordering when injecting namespace

Closes #272

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: haines sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Guided Anchor performs worse compared to baseline.

I tried the Guided Anchor ResNet50 on custom dataset, but got 4 points worse than baseline resnet50, any ideas? All settings follow the default values in GA config file.

Do you try on coco first and reproduce the mAP？

@Joker316701882 You may try on COCO first to check if everything is okay. And more information about your custom dataset is needed. Otherwise, I will have no idea about your problem.

@myownskyW7  Thanks for your excellent work!
Could you share the results and configs about the Cascade GA-RPN?
I have test on coco with  Cascade-r50-GA but the performance is only 40.4%,  just 0.5% gain compared with faster r50 GA-RPN

My result of GA on retinanet with coco dataset is worse than that of baseline. I don't know if i have changed any important code, but i don't change the config for sure.

Using GA in Mask R-CNN, there is no performance improvement compared to baseline on my data set.

using GA in cascade R-CNN with default configure parameters on my dataset, but got 2 point worse than the baseline.

This issue is closed since there is no way to debug the problem. Please create a new issue using the implementation questions template and describe your issue precisely.


[QUERY] Discord invite link invalid

Discord invite link invalid in the README.md

@sirjamesgray thank you for calling this out. The link in the upper right is correct, but the one down in the readme was not. It is fixed now. Please let me know if it's not


Option type missing from docs

It is not clear how to represent a Rust Option type in XDR. The custom-types documentation does not include any information about Option types.
Also, it would be helpful to have more tooling or at least a link to a reference implementation which converts Soroban types into their corresponding XDR structures. Otherwise, you are left guessing at how values should be encoded as SCVals.

@tamirms @paulbellamy
How is the status on this Issue? We have had some updates since it was opened and I'm thinking that things may have changed or it this issue has been resolved.
I would appreciate an update when you get a chance
Thanks!

https://github.com/stellar/stellar-xdr/pull/70 completely overhauled the scval system since this issue was written. There are two ways Option is represented in xdr.
In the ContractSpec (what you get if you do a soroban contract inspect), there is an ScSpecTypeOption type.
In the actual invocation xdr, there is no explicit Option type. Instead there is an ScVoid value, which you can pass for any value that should be None. This roughly means that in the arguments every argument is implicitly optional. But if you make the wrong one optional it will be rejected.
Good luck 🤷


[QUESTION] what's the  difference between dolphinscheduler and activiti?

Describe the question
what's the  difference between dolphinscheduler and activiti?

dolphinscheduler is not BPM, it is designed for solving the complex task dependencies relation in big data task processing(like ETL and so on) and easy to use


[BUG] Clicking on Download logs/config button yields a 404

🐛 Bug
Clicking on Download logs/config button yields a 404:

To Reproduce
Note that the training was NOT finished. Does this play a role ?..

Thank you for reporting. I am seeing the same on current main.
#217 caused this issue with the full path for data_folder and `output_folder.
Need to look into a proper fix for the routing when others paths are used, too.

Sorry about that! Thanks for fixing


Update ERG tools with 2016 guidance

Can you please update the ERG GP with the new 2016 distances and guidance when they are released?
http://phmsa.dot.gov/hazmat/library/erg

Going to keep going with #327 and close this one.


Update some example generators

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (61f889e) 100.00% compared to head (f149ad1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           94        94
  Lines         3236      3234    -2
  Branches       255       255
=========================================
- Hits          3236      3234    -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tenant switch in Kibana does not stay permanent or default to user's tennant

For some users, the tenant switch in Kibana seems not to stick and keeps changing. The two possibilities currently known are:

Although the global tenant is disabled in the Open Distro configuration, somehow it still appears for some users
Global tenant does not appear but the tenant is empty before switching

I've had a look into this and done a quick test locally.
Our logs-db-ui uses opendistro-1.6 (https://github.com/amazeeio/lagoon/blob/main/services/logs-db-ui/Dockerfile#L62)
I checked where the default tenant gets sourced from, and it happens here in the getTenantByPreference function https://github.com/opendistro-for-elasticsearch/security-kibana-plugin/blob/opendistro-1.6/lib/backend/opendistro_security.js
There appear to be some checks that check for the global tenant being enabled etc, but then it falls back to this check https://github.com/opendistro-for-elasticsearch/security-kibana-plugin/blob/opendistro-1.6/lib/backend/opendistro_security.js#L389-L393
The tenants array that is iterated over contains global_tenant in it still, so when it comes time to tenantkeys.sort() it does so alphabetically, then returns the first item in the array. This means anyone with a tenant that is alphabetically behind global_tenant will use global.
There isn't anyway to set a specific default tenant though from what I can find, so it will still use alphabetical sorting. But quick testing of this block of code works. But it isn't perfect, if the length of tenants is 1 (being just the global_tenant) this will probably fail. But I think you can't actually log in unless you are in a tenant anyway.
for (k in tenants) {
    if (globalEnabled === false && k == "global_tenant") {
        continue;
    }
    tenantkeys.push(k);
}
tenantkeys.sort();
return tenantkeys[0];

We could, for now, in the logs-db-ui service create a file backend.js with the above code change. Then in the Dockerfile add a COPY just after adding the RUN bin/kibana-plugin
COPY backend.js /usr/share/kibana/plugins/opendistro_security/lib/backend/opendistro_security.js

Only thing I could find for setting a default tenant
https://discuss.opendistrocommunity.dev/t/default-tenant-kibana/889

Kibana is no longer managed by Lagoon


Start run book crashes bot

If you type "start run book" it will crash the bot with an error. "Oops! Something went wrong :(. Technical Details: Sequence contains no elements"

Fixed by retraining LUIS


ASCII Cat Fetch

I really love the cat fetch in the screenshots, and I want to install that on my computer, but couldn't find it. Could you please link it?
Thanks!

That's pfetch with kitties, created by @andreasgrafen.
https://github.com/andreasgrafen/pfetch-with-kitties


Config location

Checklist

[x ] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x ] I've searched the bugtracker for similar questions including closed ones

Question

Is there a way to specify the youtube-dl.conf config file without using the command? I'm using sinusbot with pterodactyl which uses docker and the /etc/youtube-dl.conf directory does not exist, but i have to use the youtube-dl.conf file to specify the --force-ipv4 argument and --cookies because i'm getting the 429 error "Too many requests"

hi?

A few potential solutions;
If you can create the /etc directory, try that.
If you can specify the arguments in question at the command line, try that.
If you can't do either of those, fork the source code and make the necessary modifications to alter the default youtube-dl.conf directory to one of your choosing.


Report problems during benchmarks

The benchmark scripts should detect if some possible problems occurred during benchmarking and issue a warning to the user.
The following problems could be detected:

swapping: the memory cgroups allow to monitor whether swapping occurs for any of the processes in each cgroup (file memory.stat), so we could detect this both for the benchmarked process and for the whole system.
thermal throttling of the CPU due to overheating: can be detected from the files /sys/devices/system/cpu/cpu*/thermal_throttle/*_throttle_count

Detecting swapping for only the benchmarked process is not easy as the memory.stat file misses the pswpin and pswpout counters. However, this is not necessary if we warn for the full system, and we have now disabled swapping for the benchmarked process completely.


allow custom bunfig.toml file

If users define a bunfig.toml file at the root of their reflex project, during the init step, it will be copied in .web folder and used instead.
Closes #4225

considering that this would require creating a file that cannot be checked to git, can we instead use something like NPM_CONFIG_TOKEN flag?

actually it seems from the docs that it's possible to make it reference an env variable, then it's prob fine


When specify java-cataloger, java-pom-cataloger will also be selected

What happened:
I need to scan a directory, but I want to use only image catalogers, so I tried to use --catalogers options, like:
$syft <path-to-scan> --catalogers=...,java-cataloger,graalvm-native-image-cataloger,...

As you can see, I only specified "java-cataloger", but scan result always contained packaged found by "java-pom-cataloger". So I debugged a little bit, and found the problem is at https://github.com/anchore/syft/blob/main/syft/pkg/cataloger/cataloger.go#L186C56-L186C56. According to the function, "java-pom-cataloger" will match to "java-cataloger", so that it is selected as well.
I wonder if the behavior is intentional? If yes, why? @wagoodman
What you expected to happen:
Steps to reproduce the issue:
Anything else we need to know?:
Environment:

Output of syft version: main branch
OS (e.g: cat /etc/os-release or similar): MacOS

Hi @evanchaoli, thanks for the report, we've added this to a list of related issues to be fixed as soon as we can.

This is not intentional behavior and will be addressed by #1383


Recommendation for clearing up buffer local and global enabling

This is a recommendation for restructuring the vim.b.neocodeium_enabled and vim.g.neocodeium_enabled variables to allow not only disabling individual buffers but also enabling individual buffers.
This also also recommends separating out the function for filtering buffers after being enabled to make it clearer what it's used for, similar to the filetypes setting.
This is a relatively large change and is meant to be a recommendation that aligns with how buffer/window local options in core vim such as comment string, completion opts, indentation, etc.
Resolves #27

I will not accept this. For me it's perfectly fine how it works right now.
But maybe it's not too late to split enabled and filter to two different options. I was thinking before implementing this feature, not really sure why I chosen to merge them.
What do you think? Split them?

I think splitting them is a good idea since the enabled variable and the function are processed separately and it's a bit confusing how it is now. Which part do you not want to accept? Just the prioritizing buffer local enabling? It seems like it doesn't change the behavior you are looking for and all it does is enable the opposite usability that is currently not supported.
I think some people are going to be confused down the line when they enable a buffer but it's then not enabled

Actually I have remembered why I merged them, it simplifies global enabling/disabling. But maybe more code wouldn't harm.

Lets leave buffer over global to another discussion. But I would accept splitting of enabled and filter, when you clean up it from buffer/global logic.

I have answered in the issue, what users who would want to achieve your desired behavior could do. It then can be added to the tips examples.

It seems like for it to fully be supported they would then have to make their own enable/disable variable as well as their own enable disable functions and they wouldn't be able to use :NeoCodeium enable/:NeoCodeium disable/:NeoCodeium toggle

Ye, thats why I have merged them. Let me think overnight for some solution, if you would not come up with some idea.
And thanks for remind me of vim.b[bufnr].neocodeium_enabled really hate that vim.api.nvim_buf_get_var just can't return nil, or accept third parameter for default value.

No problem, I have gone ahead and opened a separate PR with the separation of the enabeld and filter function

I'm closing this it still have controversal local over global precedence. And most code already present in #29


Show what exactly was updated after pull/merge

As a user, I want after successful pull/merge request extension automatically open output on the panel and show list of files which are changed.

@romanfedyshyn I've added a new Recent incoming changes node to repositories in the Repositories view. Please try it out and let me know what you think? I'm not too sure on the naming right now, fyi. Also in order for it to show up, make sure you have gitlens.insiders set to true
gitlens-9.7.3.vsix.zip
Just remove the .zip extension and install it.

@romanfedyshyn FYI, I just released GitLens 9.7.4 which includes a new experimental Incoming Activity node to each repository in the Repositories view (enabled via "gitlens.insiders": true)

Incoming Activity — lists the recent incoming activity (merges and pulls) to your local repository

Provides the activity command, branch (if available), and date

Please let me know what you think.


Protect for missing slack_sdk import

What does this PR do?
Fixes #2030 . slack_sdk is not in the base install, so the HealthChecker needs to check the import.
Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

manual testing evidence
In [1]: import slack_sdk
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import slack_sdk

ModuleNotFoundError: No module named 'slack_sdk'

In [2]: from composer.callbacks import HealthChecker

In [3]: hc = HealthChecker(slack_webhook_url='test')
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
File ~/github/composer/composer/callbacks/health_checker.py:75, in HealthChecker.__init__(self, threshold, sample_freq, window_size, wait, slack_webhook_url, test_mode)
     74 try:
---> 75     import slack_sdk as slack_sdk
     76 except ImportError as e:

ModuleNotFoundError: No module named 'slack_sdk'

The above exception was the direct cause of the following exception:

MissingConditionalImportError             Traceback (most recent call last)
Cell In[3], line 1
----> 1 hc = HealthChecker(slack_webhook_url='test')

File ~/github/composer/composer/callbacks/health_checker.py:77, in HealthChecker.__init__(self, threshold, sample_freq, window_size, wait, slack_webhook_url, test_mode)
     75         import slack_sdk as slack_sdk
     76     except ImportError as e:
---> 77         raise MissingConditionalImportError('health_checker', 'slack_sdk') from e
     79 self.last_sample = 0
     80 self.last_check = 0

MissingConditionalImportError: Composer was installed without health_checker support. To use health_checker related packages, with Composer, run `pip install 'mosaicml[health_checker]'` if using pip or `conda install -c conda-forge slack_sdk` if using Anaconda.

New round of manual checks
without pynvml or slack_sdk
In [1]: from composer.callbacks import SpeedMonitor, HealthChecker

In [2]: hc = HealthChecker()
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
File /workdisk/danielking/github/composer/composer/callbacks/health_checker.py:146, in HealthChecker._is_available()
    145 try:
--> 146     import pynvml
    147     pynvml.nvmlInit()  # type: ignore

ModuleNotFoundError: No module named 'pynvml'

During handling of the above exception, another exception occurred:

MissingConditionalImportError             Traceback (most recent call last)
Cell In[2], line 1
----> 1 hc = HealthChecker()

File /workdisk/danielking/github/composer/composer/callbacks/health_checker.py:77, in HealthChecker.__init__(self, threshold, sample_freq, window_size, wait, slack_webhook_url, test_mode)
     74 self.last_check = 0
     76 self.metrics = []
---> 77 if self._is_available():
     78     self.metrics.append(GPUUtilization(threshold))

File /workdisk/danielking/github/composer/composer/callbacks/health_checker.py:150, in HealthChecker._is_available()
    148     return True
    149 except ImportError:
--> 150     raise MissingConditionalImportError('health_checker', 'pynvml', None)
    151 except pynvml.NVMLError_LibraryNotFound:  # type: ignore
    152     logging.warning('NVML not found, disabling GPU health checking')

MissingConditionalImportError: Composer was installed without health_checker support. To use health_checker related packages, with Composer, run `pip install 'mosaicml[health_checker]'` if using pip or `pip install pynvml` if using Anaconda.

with pynvml, without slack_sdk
In [1]: from composer.callbacks import SpeedMonitor, HealthChecker

In [2]: hc = HealthChecker()

In [3]: hc._is_available()
Out[3]: True

In [4]: hc = HealthChecker(slack_webhook_url='test')
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
File /workdisk/danielking/github/composer/composer/callbacks/health_checker.py:68, in HealthChecker.__init__(self, threshold, sample_freq, window_size, wait, slack_webhook_url, test_mode)
     67 try:
---> 68     import slack_sdk
     69     del slack_sdk

ModuleNotFoundError: No module named 'slack_sdk'

The above exception was the direct cause of the following exception:

MissingConditionalImportError             Traceback (most recent call last)
Cell In[4], line 1
----> 1 hc = HealthChecker(slack_webhook_url='test')

File /workdisk/danielking/github/composer/composer/callbacks/health_checker.py:71, in HealthChecker.__init__(self, threshold, sample_freq, window_size, wait, slack_webhook_url, test_mode)
     69         del slack_sdk
     70     except ImportError as e:
---> 71         raise MissingConditionalImportError('health_checker', 'slack_sdk', None) from e
     73 self.last_sample = 0
     74 self.last_check = 0

MissingConditionalImportError: Composer was installed without health_checker support. To use health_checker related packages, with Composer, run `pip install 'mosaicml[health_checker]'` if using pip or `pip install slack_sdk` if using Anaconda.

with pynvml and slack_sdk
In [1]: from composer.callbacks import SpeedMonitor, HealthChecker

In [2]: hc = HealthChecker(slack_webhook_url='test')

In [3]: hc._is_available()
Out[3]: True


(BUG) presenters are not visible on presenters page

Hello, @az
Could you check if there is everything ok with: https://ecommerceberlin.com/presenters page, please?
The are presenters missing on the website. Mark said that they were visible previously

@klaudia2209 sprawdzam

@klaudia2209 idzie build z fixem

@klaudia2209 live

super, dzięki!


TAJO-1424: Too many 'Try to connect' messeges during Travic CI build

Would you close this PR, please?

Absolutely!


Enhanced the contact form

Description
Enhanced the contact form
Fixes:  #195
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
Before:-

After

@Abidsyed25 please check this PR

@Abidsyed25 please check this


docker-compose.yml invalid with disablePostgres

Generating a docker-compose.yml with disablePostgres: true will output a non-functional file. Trying to start the file will give the error:
Configuration error - Service 'backendAction' depends on service 'postgres' which is undefined.

It seems most services that expect to be able to connect to the DB directly still depends_on: postgres.

This and #215 are still an issue.


meteor desktop system notifications

Hi,
Made a module for enabling native system notifications in meteor desktop (thanks again) and wanted to see if you could take a look and maybe give us some pointers if there s something wrong, etc.
The plan is to extend this and make it a plugin, so any pointers in that direction are also most appreciated.
For now, it s simple and you can see the code here
https://gist.github.com/tzapu/14f92eb419c212768aa525112448261d
Thanks
Alex

Hey,
I am very excited for first plugin being made by somebody else than me 😄
Just to let you know, I will respond to this in detail over the weekend. Probably tomorrow.

I just finally found a moment for this.
At first glance it looks fine. I have just run it.
Please make a repo for this plugin with a pull request - it will be easier for me to comment.
I am now thinking how to make such things simpler - I mean, you had to create a new window just to use Notification API - and that seems like an overkill.
On the one hand, we can safely assume that Meteor app in Electron runs in Chrome, so you could skip creating a meteor-desktop plugin and just do that in a Meteor plugin, or just a npm package.
On the other hand there should be a possibility to load some code into the main window, so that it could expose api in the Desktop namespace saving you from creating a separate window just for that purpose.
I will probably add an API to load a file with code into the main file. For now you can start with this implementation.

i completly agree with this
I mean, you had to create a new window just to use Notification API - and that seems like an overkill.
looking forward to your changes. in the mean time we have it working properly as a module, will try to package it asap as a plugin and let you know.
thanks

Have you already made a repo for this plugin? I will start working soon on 0.4.0 where I am planning an API for directly adding code to renderer process - so just curious if you'd be still interested in this.

hi, no repo yet, still at module level.
seems to be working find though
still interested in code for render process but it s not an urgent in any way, so maybe your time would be better spend on more pressing issues.
i ll try to make it a plugin asap, just worried that it will get a lot harder to debug...
thanks

i ll try to make it a plugin asap, just worried that it will get a lot harder to debug...

Please check out the second paragraph https://github.com/wojtkowiak/meteor-desktop#how-to-write-plugins
With the use of linkPackages and having some tests it should not be a bad experience.

I can write the test if you want, as it requires some time to get accustomed to the test suite.

thank you very much for all the help. i was under the impression linked packages wouldn't work, but now i know it should be a lot better
to my great shame, i must admit i m not very productive in test driven dev. never got into it properly, but i must really start.
will throw a plugin together today/tomorrow and see your thoughts
thanks

hi,
the repo is here
https://github.com/tzapu/meteor-desktop-system-notifications
it's also published and we re seeing now if it all works ok
long way to go as i want to add tests and all that jazz so any feedback is more than welcomed, including what your development flow is on plugins and so on
another thing that might be worth it if you would have a boiler plate plugin repo maybe
check it out and you would already have pretty much all the little files set to go, tweak a bit and drop your module...

as the api/ipc commands for this are so simple, do you think it's worth having the meteor counterpart as well, just to abstract them?

in our tests so far it seems to work fine which makes be very happy :D
we are getting this
WARN  electronApp:  you are using outdated version 0.0.1 of meteor-desktop-system-notifications, the suggested version to use is undefined

not sure what else should of set

Sorry for no response from me. I was ill for some time. I will get back to this next week, ok?

I'm trying to use this plugin, so i've installed it with:
npm i meteor-desktop-system-notifications
Then I added it to the plugins array in .desktop/settings.json so my plugins now looks like:
"plugins": {
     "meteor-desktop-localstorage": "0.0.11",
     "meteor-desktop-system-notifications": {
         "version": "0.0.2"
     }
 },

However I don't quite know how to use the plugin, I tried this in 'main.ts' file in my server folder:
    Desktop.send('systemNotifications', 'notify', {
         title: 'Title',
         text: 'Text'
     });

I was getting a typescript error about 'Desktop' not being know so I added:
let Desktop: any;
But as expected this doesn't work and says can't read property 'send' of undefined. So I guess I actually need to import the module from somewhere. How do I do that?

hi, i think you may need to wrap all that in Meteor.isDesktop
it should only be ran in a desktop app
hope this helps

Hey thanks for your help but that gives me a typescript error:
Property 'isDesktop' does not exist on type 'typeof Meteor'.
And if I don't use the Meteor.isDesktop line my app crashes:
W20170306-21:09:24.194(0)? (STDERR) /Users/michaelbattcock/.meteor/packages/meteor-tool/.1.4.3_1.10pxpug++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280
W20170306-21:09:24.194(0)? (STDERR) 						throw(ex);
W20170306-21:09:24.195(0)? (STDERR) 						^
W20170306-21:09:24.195(0)? (STDERR)
W20170306-21:09:24.196(0)? (STDERR) Error: Cannot find module './log'
W20170306-21:09:24.197(0)? (STDERR)     at require (packages/modules-runtime.js:123:19)
W20170306-21:09:24.198(0)? (STDERR)     at meteorInstall.node_modules.meteor-desktop.dist.desktop.js (packages/modules.js:1225:12)
W20170306-21:09:24.198(0)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:197:9)
W20170306-21:09:24.199(0)? (STDERR)     at require (packages/modules-runtime.js:120:16)
W20170306-21:09:24.200(0)? (STDERR)     at meteorInstall.server.main.js (server/main.ts:24:15)
W20170306-21:09:24.200(0)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:197:9)
W20170306-21:09:24.200(0)? (STDERR)     at require (packages/modules-runtime.js:120:16)
W20170306-21:09:24.201(0)? (STDERR)     at typings/site.ts:54:2
W20170306-21:09:24.201(0)? (STDERR)     at /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/local/build/programs/server/boot.js:303:34
W20170306-21:09:24.201(0)? (STDERR)     at Array.forEach (native)

Is there anything I need to add when using typescript? I'm importing the module with:
import Desktop = require('meteor-desktop/dist/desktop.js');
but i'm not sure if thats correct...

@michaelb-01 did u solve ur problem? able to use isDekstop?


unresolved type arguments to dynamic generic function invocation

Given an example like:
void _test(Int2Int2Int f) {
  int y = f(123, 456);
  Expect.equals(y, 123);
  // `f` doesn't take type args.
  Expect.throws(() => (f as dynamic)/*<int>*/(123, 456));
}

... the <int> TypeArgumentList appears to be unresolved: the TypeName.type is null.
Probably resolution is just skipping that subtree?
Not a big deal, this only came up in a test case I was trying to write. Not sure if MethodInvocation has the same problem, I'll try it out and report back.

Methods appear to have the same problem:
class C {
  /*=T*/ m/*<T extends num>*/(/*=T*/ x, /*=T*/ y) => min(x, y);
  int m2(int x, int y) => min(x, y);
}
main() {
  Expect.equals(123, (new C() as dynamic).m/*<int>*/(123, 456));
  Expect.throws(() => (new C() as dynamic).m2/*<int>*/(123, 456));
}

I don't understand why methods don't work, though. In resolver.dart, I can see that visitFunctionExpressionInvocation is skipping the type args. But visitMethodInvocation it is not skipped, as far as I can see. Maybe it comes through as a FunctionExpressionInvocation?
Another strange issue:
``dart
dynamic c = new C()l
Expect.equals(123, c.m//(123, 456));
Expect.throws(() => c.m2//(123, 456));
Now I get `[error] The type '(int, int) → int' is declared with 0 type parameters, but 1 type arguments were given` from the m2 line. Uh, that's great *but* ... why did it infer an explicit `dynamic` local var?

CC @leafpetersen @bwilkerson as FYI. My sense is this is not immediately high priority but I wanted y'all to be aware in case you hit this.

Works for me.
See the attached screenshots, note that TypeNameImpl with name int has type and element set.

okay I can take another look. Possibly has been fixed or is somehow an artifact of how we build DDC's tests (for speed, they all use the same AnalysisContext, which might stress things more than usual)

I can still reproduce this in DDC. The full test file is:
https://github.com/dart-lang/dev_compiler/blob/ef2f54c5d20c01fe29b2d7377ab2886a360e0c0a/test/codegen/language/generic_tearoff_test.dart#L20
To reproduce this line has to be removed:
https://github.com/dart-lang/dev_compiler/blob/ef2f54c5d20c01fe29b2d7377ab2886a360e0c0a/lib/src/compiler/code_generator.dart#L523
if (node.type == null) return js.call('dart.dynamic');

then this command line will do it from a DDC checkout (after pub get)
$ ./bin/dartdevc.dart compile -o out.js --url-mapping=package:expect/expect.dart,test/codegen/expect.dart test/codegen/language/generic_tearoff_test.dart

results in
  The null object does not have a getter 'isVoid'.

  NoSuchMethodError: method not found: 'isVoid'
  Receiver: null
  Arguments: []
  dart:core                                                      Object.noSuchMethod
  package:dev_compiler/src/compiler/code_generator.dart 2244:14  CodeGenerator._emitType
  package:dev_compiler/src/compiler/code_generator.dart 525:12   CodeGenerator.visitTypeName
  dart:_internal                                                 ListIterable.toList
  package:dev_compiler/src/compiler/code_generator.dart 2566:52  CodeGenerator._emitFunctionTypeArguments
  package:dev_compiler/src/compiler/code_generator.dart 2548:12  CodeGenerator._emitInvokeTypeArguments
  package:dev_compiler/src/compiler/code_generator.dart 2528:22  CodeGenerator._emitFunctionCall
  package:dev_compiler/src/compiler/code_generator.dart 2650:7   CodeGenerator.visitFunctionExpressionInvocation
  package:analyzer/src/dart/ast/ast.dart 5288:15                 FunctionExpressionInvocationImpl.accept
  package:dev_compiler/src/compiler/code_generator.dart 4143:23  CodeGenerator._visit
  package:dev_compiler/src/compiler/code_generator.dart 2394:29  CodeGenerator.visitExpressionFunctionBody
  package:analyzer/src/dart/ast/ast.dart 3964:15                 ExpressionFunctionBodyImpl.accept
  <snip>

I'm not sure if it's something we're setting up in the AnalysisContext? We are turning on summaries including for the SDK.

Oh ... you know what. I totally forgot, these bugs almost always due to ResolutionCopier not copying over the data. We clone the AST before we generate code in DDC:
https://github.com/dart-lang/dev_compiler/blob/ef2f54c5d20c01fe29b2d7377ab2886a360e0c0a/lib/src/compiler/reify_coercions.dart#L120
I've fixed a handful of bugs where elements and types are not copied over (you can see some of our workarounds below in _TreeCloner, some of those can probably be removed now)

Ah, yeah, ResolutionCopier is not copying over TypeName.type, I fixed the problem with this change:
  @override
  TypeName visitTypeName(TypeName node) {
    var clone = super.visitTypeName(node);
    clone.type = node.type;
    return clone;
  }

I think we didn't hit this before because usually we have an element for the generic method we're calling, or in the case of a constructor new List<int>.from(...) we have the constructor element as well as the full type. But for generic methods f.m<int>(...) we only have the TypeArgumentList and its List<TypeName> nodes available.

Is this the problem?
AFAIK ResolutionCopier does copy TypeName.type.
  @override
  bool visitTypeName(TypeName node) {
    TypeName toNode = this._toNode as TypeName;
    if (_and(_isEqualNodes(node.name, toNode.name),
        _isEqualNodes(node.typeArguments, toNode.typeArguments))) {
      toNode.type = node.type;
      return true;
    }
    return false;
  }

But it does not process MethodInvocation.typeArguments.
  @override
  bool visitMethodInvocation(MethodInvocation node) {
    MethodInvocation toNode = this._toNode as MethodInvocation;
    if (_and(
        _isEqualNodes(node.target, toNode.target),
        _isEqualTokens(node.operator, toNode.operator),
        _isEqualNodes(node.typeArguments, toNode.typeArguments), <<< This!
        _isEqualNodes(node.methodName, toNode.methodName),
        _isEqualNodes(node.argumentList, toNode.argumentList))) {
      toNode.propagatedInvokeType = node.propagatedInvokeType;
      toNode.propagatedType = node.propagatedType;
      toNode.staticInvokeType = node.staticInvokeType;
      toNode.staticType = node.staticType;
      return true;
    }
    return false;
  }

Oh! yeah that could be it

https://codereview.chromium.org/1970053002

https://github.com/dart-lang/sdk/commit/fad1ca3460c57d88c912a2d77c95f9dc700a41bd

awesome, thank you!


add [elm-package] badge

Lovely, thank you! 🌟 🌟 🌟

@paulmelnikow Hello, would you mind making a release? I'd like to start using elm-package badge. Thank you.

I can't; I don't have access. Deploys usually happen every 1–3 weeks. Thaddée, who has limited time on this project, is the only sysadmin. He's working on giving me access to deploy and logs, but doing so is complicated because the hosting account (and maybe the servers too) are shared with other services he runs.


Remove make-a-sorn custom slug

make-a-sorn was previously a custom slug with a hard corded html
template. This removes all the custom code associated with that which
makes it fall back to a regular transaction. There is already a start
now page for make-a-sorn in Publisher.
Before

After

Trello card
cc @keithiopia

It's all 🔴 ! Big 👍 for delete-only PRs :)

On closer inspection it also looks to do the correct thing.  Happy to merge once we get the ok from content that the new version of the make-a-sorn document has been published.

This is waiting on the ok from either @keithiopia or John Ploughman in the content team before merging.

New make-a-sorn page will be published 5th July. This PR is now ready for merging


Throttle issue (solved)

I'm not sure yet if that's a Laravel issue or not. I'll investigate further but i'm leaving this here in the meantime to let you know, maybe you have some information to share.
I enabled throttle per the doc and I encounter 2 issues:

The value returned in the header X-RateLimit-Limit keeps returning the value set in Kernel for the api group, whatever value I set on the route. But it is the value set on the route that is taken into account so it works as intended but the information returned in the header is wrong.

The X-RateLimit-Remaining decreases two by two on each request. As if the api was called twice every time. That is if I have a throttle of 60:1, I'm allowed only 30 requests.

I'm going to test two things. Install your demo to see if I can reproduce the problem, and install a simple Laravel App with basic functionality to test as well. Maybe that's a Laravel issue.
For the record I'm using the latest and greatest for Laravel.

Ok so this was simple to solve.
Looks like throttle cannot be overridden, it behaves weirdly...
Just remove the throttle from the api group in Kernel and everything returns to normal.
Same goes if you apply throttle on a the JsonApi route and try to override it on the resource:
    JsonApi::register('v3')
        ->middleware('throttle:60,1')
        ->routes(function ($api, $router) {
            $api->resource('posts')->relationships(function ($relations) {
                $relations->hasMany('tags');
            })->middleware('throttle:10,1');
        });

The throttle on posts won't behave as intended.
I'll keep looking to see if that is intended behavior or a Laravel bug.

Looks like intended (from 2016): https://github.com/laravel/framework/issues/16786
Maybe a note on the docs on the corresponding throttle part could be added.
Closing this for now.


Could not find nokogiri-1.13.3 in any of the sources

LicenseFinder::Bundler: Finished prepare on project
LicenseFinder::Yarn: Running prepare on project
LicenseFinder::Yarn: Finished prepare on project
LicenseFinder::Bundler: is installed
LicenseFinder::Yarn: is installed
LicenseFinder::Bundler: including groups [:default, :development, :staging, :production]
Traceback (most recent call last):
	24: from .../bin/license_finder:23:in `<main>'
	23: from .../bin/license_finder:23:in `load'
	22: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/bin/license_finder:6:in `<top (required)>'
	21: from .../lib/ruby/gems/2.6.0/gems/thor-1.2.1/lib/thor/base.rb:485:in `start'
	20: from .../lib/ruby/gems/2.6.0/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
	19: from .../lib/ruby/gems/2.6.0/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
	18: from .../lib/ruby/gems/2.6.0/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
	17: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/cli/main.rb:159:in `report'
	16: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/license_aggregator.rb:11:in `dependencies'
	15: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/license_aggregator.rb:49:in `aggregate_packages'
	14: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/license_aggregator.rb:49:in `flat_map'
	13: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/license_aggregator.rb:49:in `each'
	12: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/license_aggregator.rb:51:in `block in aggregate_packages'
	11: from .../lib/ruby/2.6.0/forwardable.rb:224:in `acknowledged'
	10: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/core.rb:79:in `decision_applier'
	 9: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/core.rb:84:in `current_packages'
	 8: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/scanner.rb:42:in `active_packages'
	 7: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/scanner.rb:42:in `flat_map'
	 6: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/scanner.rb:42:in `each'
	 5: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/package_manager.rb:105:in `current_packages_with_relations'
	 4: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/package_managers/bundler.rb:16:in `current_packages'
	 3: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/package_managers/bundler.rb:51:in `details'
	 2: from .../lib/ruby/gems/2.6.0/gems/license_finder-7.0.1/lib/license_finder/package_managers/bundler.rb:66:in `gem_details'
	 1: from .../lib/ruby/gems/2.6.0/gems/bundler-2.3.10/lib/bundler/definition.rb:240:in `specs_for'
.../lib/ruby/gems/2.6.0/gems/bundler-2.3.10/lib/bundler/definition.rb:481:in `materialize': Could not find nokogiri-1.13.3 in any of the sources (Bundler::GemNotFound)

nokogiri is not in the application's Gemfile directly, but referenced in Gemfile.lock as a dependency of two other gems:
    actiontext (<IP_ADDRESS>)
      actionpack (= <IP_ADDRESS>)
      activerecord (= <IP_ADDRESS>)
      activestorage (= <IP_ADDRESS>)
      activesupport (= <IP_ADDRESS>)
      nokogiri (>= 1.8.5)
…
    capybara (3.36.0)
      addressable
      matrix
      mini_mime (>= 0.1.3)
      nokogiri (~> 1.8)
      rack (>= 1.6.0)
      rack-test (>= 0.6.3)
      regexp_parser (>= 1.5, < 3.0)
      xpath (~> 3.2)
…
    loofah (2.15.0)
      crass (~> 1.0.2)
      nokogiri (>= 1.5.9)

and also directly:
    nokogiri (1.13.3)
      mini_portile2 (~> 2.8.0)
      racc (~> 1.4)

The prepare step works fine, but the actual analysis then fails – I’m guessing that it’s not loading the right nokogiri in the end, but I have no clue how to further debug this unfortunately.
(Docker does not work for this either as neither the dlf tool nor direct invocation even manage to get the right ruby going, somehow - I opened another issue for that).

(Obviously, I might be missing something, in which case I would appreciate pointers as well :) )

This might be the same as #862 and #828

Duplicate


Document heroku demo app and create small open source repository

Add a Tutorial section for the justpy demo browser in heroku

https://justpy-demo.herokuapp.com/

Add Info to main tutorial that question / issues should be accompanied with online example e.g. via heroku as in
https://justpy-demo.herokuapp.com/demo/issue_387_aggrid_tabgroup (when mounted)

Live demo bedeckt das code

What does the filter for the second column serve? There is only label visible which leads to source code. But there is also a source column which leads to source code.

All of the try it links leads to the same example.
Why is there a seperate try it link when trying it is also possible inside the link of name column

@byzakyz  thanks for trying out. One of the highchart tests seems to have this effect - there is a probably a state problem.
If you set up your own heroku account Tim and i can give you the files needed to to set up your own test environment   restart things on failure.

https://github.com/justpy-org/justpy/blob/master/docs/blog/heroku.md has the tutorial part

There will be no separate project since there are only three needed files available at https://github.com/justpy-org/justpy/tree/master/tutorial/heroku


Compare .tex files

What say we all do a build of commit number 5b36f  ('Corrected the citation....' - my latest one since I'm winning the Network Graph race!). And then compare .tex files to check we're all good.
I guess we have to email then to each other, which is fine. I have to leave soon. Chris can probably easily compare them in the morning.

I'm a bit behind on model loading and document compiling so I'll skip this
comparison, but go ahead without me.
On Mon, Feb 29, 2016 at 3:45 PM, andrew-edwards<EMAIL_ADDRESS>wrote:

What say we all do a build of commit number 5b36f ('Corrected the
citation....' - my latest one since I'm winning the Network Graph race!).
And then compare .tex files to check we're all good.
I guess we have to email then to each other, which is fine. I have to
leave soon. Chris can probably easily compare them in the morning.
—
Reply to this email directly or view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/164.

Ian - no worries. Last time all four of us had identical .tex files (except comments regarding R versions and xtables), which was very gratifying. Presumably the .pdf files would all be the same as well.

All our TEX files are identical for commit 5b36f.

Great. I'm source-all.r-ing again after merging (not sure what changed with thelatest commits) and deleting knitr-cache to rebuild...


Fix error message alignment for change password form

Inline error messages

Fixes https://github.com/HyphaApp/hypha/issues/3842
Test Steps

[ ] Try changing the password and use different password while retyping

Can we have the error message pop up on the "New password" field instead of the "New password confirmation" field?


dumb-init: Add Darwin to supported platforms

Description of changes
dumb-init can build and run on Darwin systems, but is not marked that way in it's derivation. This adds Darwin as a supported platform in meta.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Your commits are breaking Commit Conventions please rebase.
Reword 93b0aaf6cc82f936917da6100dd33cd79a6214ad to dumb-init: fix missing platforms for example and squash 51231f7fb2482ed6d9a28f247e7b8cd77d857d29 into 93b0aaf6cc82f936917da6100dd33cd79a6214ad

@ofborg build dumb-init


--help misaligned if one option only has long flag and one only has short flag

Affected Version of clap
2.25.0
Expected Behavior Summary
    --free <space>    Ensure filesystem has at least this much free space. (ex: 9.5%, 10G)
    -o     <option>    Additional system-specific mount options. Be careful!

Actual Behavior Summary
        --free <s[ace>    Ensure filesystem has at least this much free space. (ex: 9.5%, 10G)
    -o <option>          Additional system-specific mount options. Be careful!

This is subjective, I know, but personally I think that'd be a good more code to maintain for only a little benefit. In small programs this may look nicer, but in larger scenarios I think it'd get lost in the noise.
I'm going to close this since I don't have the bandwidth to maintain code doing this, but I'm open to discussion if there's an argument to made as to why it'd be better (in all cases) to do this.


Monitoring of testing infrastructure

Currently we understand that our testing infrastructure is broken when tests start failing on it as we don't have any additional monitoring. This creates frustration in teams as they get pinged for the failures. So let's ensure our infra is stable and reliable.
- [ ] https://github.com/giantswarm/giantswarm/issues/27580
- [ ] https://github.com/giantswarm/roadmap/issues/2646
- [ ] https://github.com/giantswarm/giantswarm/issues/27961
- [ ] https://github.com/giantswarm/giantswarm/issues/27900
- [ ] https://github.com/giantswarm/giantswarm/issues/28024
- [ ] https://github.com/giantswarm/giantswarm/issues/28025
- [ ] https://github.com/giantswarm/giantswarm/issues/28026
- [ ] https://github.com/giantswarm/giantswarm/issues/28027

All the tasks have been completed. Marking this epic as done.


Vulnerability roundup 114: mruby-3.0.0: 3 advisories [9.8]

search, files

[ ] CVE-2022-1276 CVSSv3=9.8 (nixos-21.11, nixos-unstable)
[ ] CVE-2022-1286 CVSSv3=9.8 (nixos-21.11, nixos-unstable)
[ ] CVE-2022-1427 CVSSv3=7.8 (nixos-21.11, nixos-unstable)

CVE details
CVE-2022-1276
Out-of-bounds Read in mrb_get_args in GitHub repository mruby/mruby prior to 3.2. Possible arbitrary code execution if being exploited.
CVE-2022-1286
heap-buffer-overflow in mrb_vm_exec in mruby/mruby in GitHub repository mruby/mruby prior to 3.2. Possible arbitrary code execution if being exploited.
CVE-2022-1427
Out-of-bounds Read in mrb_obj_is_kind_of in in GitHub repository mruby/mruby prior to 3.2. # Impact: Possible arbitrary code execution if being exploited.

Scanned versions: nixos-21.11: 3c5ae9be1f1; nixos-unstable: f419dc5763c.
Cc @nicknovitski

See also: #155337

Similar to previous situations, the vulnerable code was never shipped in an mruby release. Tried the POCs and 3.1.0 is not vulnerable to any.