Request: Add support for NEC PC-9800 Series floppy format

Dear developer,
Sorry, I'd like to ask if GreaseWeazle can add read/write support for NEC PC-9800 series floppy disk format.
The common PC98 HD format is: 2 sides, 77 tracks per side, 8 sectors per track, 1024 Bytes per sector, and the total capacity of the disk is 1,261,568 Bytes (often referred to as 1232KB). And, to read such
disk, FDD motar must spin at 360rpm.
For a 5.25-inch floppy disk or a 3.5-inch floppy disk, the above structural divisions are the same.
Thanks!

Do you have a setup where you can test the support if I add it? It's easy to add, but I only add features that someone can test for me.

Do you have a setup where you can test the support if I add it? It's easy to add, but I only add features that someone can test for me.

Thank you for replying me。
I have purchased GW hardware from your ebay store and assembled it with the floppy drives, and I have several such PC-9800 floppy disks to test with (well, I found software called FluxEngine can dump PC98 disks using GreaseWeazle，although I succeeded, I don't know what the rationale is.)

Yes, FluxEngine is good! Okay, I will work on some patches and post a link here for you to test. Thanks!

Please can you try the following tools:
https://github.com/keirf/greaseweazle/suites/7217264817/artifacts/289092911
The formats of interest to you are pc98.dd and pc98.hd. The latter is your 1232kB format.

Please can you try the following tools: https://github.com/keirf/greaseweazle/suites/7217264817/artifacts/289092911 The formats of interest to you are pc98.dd and pc98.hd. The latter is your 1232kB format. PS: You need to be logged into GitHub for the above link to work.

Thank you so much for your hard work!
My test enviroment:
GreaseWeazle V4.
A 5.25 inch FDD (drive A) and a 3.5 inch FDD (drive B), both connected to GreaseWeazle via a ribbon cable.
My 3.5 inch FDD's motor can only spin at 300rpm.
I used the following command to read several floppy disks in PC98 HD format:
gw read --drive B --format pc98.hd test.img
The result of operation is not so well. GW first reads the first 154 tracks (Track 0.0 to Track 76.1) of the floppy disk normally. At this time, all valid tracks of the floppy disk should be read, but GW will still try to read Track 77.0 to Track 80.1, however these tracks are not valid for PC98 format floppy disks. The resulting floppy image was also not the correct size, implying that extra data was mixed in.
P.S. Should I use --adjust-speed 360rpm and --fake-index 360rpm to read? I've tried so, but get the same error.

Use --tracks=c=0-76

Can you tell me are all PC98 HD disks 77 cylinders only? What about PC98 DD disks?


Question: how to set resources from the snakefile

Hi!
There are a bunch of jobs that run in parallel, but there are some of them that I'd like to limit to a specific number of parallel jobs. I've noticed that what I want is something similar to what is asked in https://groups.google.com/g/snakemake/c/ykyWDoYBhoI?pli=1. The problem is that I'd like to define the resources, if not provided through --resources, from the Snakefile since there is where I have my configuration about how many jobs for the specific rules should be executed in parallel (I know that a profile or something similar would do the work, but I'd rather to don't use them since I don't want to duplicate the configuration in different files).
Example:
localrules: targets, sleep_local

rule targets:
        input:expand("testSleep{localOrCluster}{sample}", localOrCluster=["Local", "Cluster"], sample=["S1","S2","S3","S4","S5","S6"])

rule sleep_local:
        output:"testSleepLocal{sample}"
        resources: qq=3
        threads: 2
        shell:"""
        sleep 10s
        touch {output}
        """

MAX_SLEEP_CLUSTER_PARALLEL_JOBS = 2

# What I want is something similar to the next line, but I don't know if it's possible
if not workflow.resources.gpu: # Check if the value was set from CLI
        workflow.resources.gpu = MAX_SLEEP_CLUSTER_PARALLEL_JOBS

rule sleep_cluster:
        output:"testSleepCluster{sample}"
        resources:
          gpu=1,
        threads: 1
        shell:"""
        sleep 10s
        touch {output}
        """

I'd like to be able to configure the resource gpu from the Snakefile in order to be able to decide the maximum parallel number of sleep_cluster rules which will be running in parallel. So, since the resource gpu from the rule sleep_cluster is configured to 1, if not provided it will be ignored (that is what happened when I ran the test), and if I want to run at maximum 2 sleep_cluster rules but I provided -j 128, in order to do not run all the sleep_cluster rules I'd need to configure that the resource gpu is 2 if was not provided from the CLI. Is this possible? Is there something like workflow.resources.gpu?
Thank you!

Another question related to the previous one: is it possible to limit the resources in a way that is taken into account across multiple instances? I think that I want something like --set-resource-scope gpu=global. What I'd expect with that configuration is that if I run
snakemake --resources qq=100 gpu=1 --cores 8 -j 8 & &> ./first_execution   # First execution
sleep 1
snakemake --resources qq=100 gpu=1 --cores 8 -j 8 & &> ./second_execution  # Second execution

the rule sleep_cluster is executed in the first instance but not in the second until the first finishes. Is this possible? I'm running in a single machine these commands, so the resources are shared and I think that should be a way to tell this to snakemake.

About the first question, I think I've found out a solution:
if "gpu" not in workflow.global_resources:
    workflow.global_resources["gpu"] = MAX_SLEEP_CLUSTER_PARALLEL_JOBS

I've checked out the code and it seems to work as described. Of course, this might have side effects which I don't know.
About the second question I'm not sure I'll be able to find a solution since my knowledge of Snakemake is not as deep as the question requires, I think.

@cgr71ii, your solution to the first question seems reasonable to me. I can't guarantee it won't cause bad side effects (I don't think Snakemake officially supports that type of modification), but it's the way I would approach the problem, and I've done similar on other workflow variables.
For the second question, unfortunately that won't work. resource-scope only limits resources within a single snakemake instance. scope=global prevents snakemake from submitting multiple jobs in a cluster environment that together consume more than the resource limit.
I don't know of any obvious way of achieving your outcome: it seems more a problem of communication between processes. On the other hand, manually running multiple snakemake instances isn't exactly intended usage... Is it possible to use snakemake cluster support to orchestrate your instances? Because then scope=global will work perfectly.

I can't guarantee it won't cause bad side effects (I don't think Snakemake officially supports that type of modification), but it's the way I would approach the problem, and I've done similar on other workflow variables.

That's what I though that might be a problem, but for the moment, it's work. Of course, that doesn't mean that if I use something different which I usually don't, it might break because of this tweak. At least, is nice to know that someone else would do it the same way (and have done similar things), since it means that I'm not following the wrong direction.
By the moment I think I haven't experienced any side effect and it works the way is intended:

https://github.com/bitextor/bitextor/blob/9d9b84befd746d5c5e8f14f3719704aff4fe981e/bitextor/Snakefile#L378
https://github.com/bitextor/bitextor/blob/9d9b84befd746d5c5e8f14f3719704aff4fe981e/bitextor/Snakefile#L923

I don't know of any obvious way of achieving your outcome: it seems more a problem of communication between processes.

That's exactly what it is, and following one of the FAQ answers (https://snakemake.readthedocs.io/en/stable/project_info/faq.html#i-want-to-pass-variables-between-rules-is-that-possible) I found out that this is possible. Of course, not trivial, in fact even difficult, but I've achieved a PoC that this is possible with snakemake: https://github.com/bitextor/bitextor/tree/neural_modifications
What I've done is use PersistentStorage and implement a basic mutex mechanism so different snakemake instance can communicate among them. Doing this, I've been able to communicate among different rules of 1 snakemake instance, but since the communication is done through a file with PersisntentStorage, this should be extensible to multiple snakemake instances. Maybe not directly and some changes might be needed, which I think it's not needed in my case for use this mechanism to multiple instances, but I think it's possible. The reason I think it will work even with multiple instances and not only with multiple rules instances of the same instance is because the mutex mechanism is done through PersistentStorage. Since all the rules are different processes, I need to communicate them using this mechanism. Since they access the same file, other snakemake instances would access the same file as well, which would lead to access the same mutex in order to ask for a GPU, and it should work.
I'll let the issue open for the moment in case that something of what I told is wrong.
Thank you, @pvandyken , for answering my doubts!

@cgr71ii, glad you were able to figure out a way to do your process communication. Feel free to close this if there's nothing else

Since you told me that I'm doing it the way that I should (at least the way it's possible without taking into account the possible side effects), it's all I needed to know. Thank you for the help!
Closing.


Tree - NodeDrop - OrderNumber

When running the drag and drop sample, the order number being reported after a drop seems off.  For example, if I expand Europe and drag England to below Germany, Bulgaria, or Poland, the orderNumber returned is always 3.  I would expect the order number would be 2 if dropped after Germany, 3 if dropped after Bulgaria, and 4 if dropped after Poland.

We are going to check that and get back to you soon.

This is fixed in the new development version. You can find the latest dev build at https://github.com/atatanasov/gijgo/tree/master/dist


Constraint-based optimization of 'regex' queries doesn't seem to work using Dremio

Description
Dremio doesn't provide information about primary and foreign keys in its metadata, which is used by Ontop to optimize queries.
A solution for this is to provide a "db_prefs" constraints file in the initialization of Ontop.
However, this option doesn't seem to improve the efficience of queries using  FILTER regex functions.
Steps to Reproduce

Run a Dremio server with available datasets.
Execute an ontop CLI endpoint, with an ontology mapping the dremio datasets, and a constraints file in the CLI options. (Ontop Protege plugin also tested)
Execute advanced queries with more than one FILTER regex function. My SPARQL queries uses 3 filters:
FILTER regex (?var1, '^somevalue$')
FILTER regex (?var2, '^anothervalue$')
FILTER (?date > '...'^^xsd:datetime && ?date < '...'^^xsd:datetime)

If at least one of the regex filters is removed, in some queries the response times improves.
If the two regex filters are removed, the issue disappears.
Expected behavior:
An improvement of the queries response times when connecting to Dremio, as it happens when testing the same configuration with MariaDB server.
Actual behavior:
No improvement is noticed. Queries took forever to being answered. In some cases an answer is never provided in several minutes, so the request has to be cancelled.
The same ontology, mappings and constraint file (with the necessary adaptations) were tested in a connection to the original MariaDB database accessed by Dremio, and the response times in that case are in order of less than a second, for most queries.
Reproduces how often:
Always
Attached material
No relevant information in the logs.
Using three different datasets in the same Ontop connection to Dremio.
Constraints file sample:
region.municipality:id region.municipality:province_id:region.province:id
'region' is one of the Dremio datasets, 'province' and 'municipality' are tables.
Versions
Ontop CLI endpoint 4.1.0
Protege for Windows 5.5 with Ontop plugin 4.1.0
Dremio 3.3.2 CE
MariaDB 10.4.14
Additional Information
Workaround: it is not always possible, but in my case, I replaced FILTER regex calls with FILTER exact matches.

Hi @manuel-delaiglesia ,
Could you show us how the SQL queries generated by Ontop look like? With Dremio, it is fairly easy, you can see the queries in the "Jobs" panel.
One of the main impacts of integrity constraints is that they reduce the number of joins and, in particular, eliminate most of the "self"-joins (joining on the same table multiple times). Missing integrity constraints, which can then be user-provided, are usually easy to spot when looking at the SQL queries.
In a recent project, we successfully used manually specified db constraints with Dremio, so in principle it should work if you use the latest stable release.
For what regards REGEX conditions, as far as I know, they are not directly connected to integrity constraints.
Best,
Benjamin

Hi @bcogrel , thank you for your answer.
this is one of the queries, please excuse me for the delay and the Spanglish:
the original SPARQL query:
SELECT DISTINCT ?province ?name (SUM(?w) AS ?weight) (COUNT(?p) AS ?packages)
WHERE {
	?m :manifest_arrival_date ?d ;
	:manifest_arrival_port ?arrivport ;
	:manifest_arrival_status ?arrivstatus .

	FILTER regex(?arrivport, '^.*$')
	FILTER regex(?arrivstatus, '^.*$')
	FILTER ( ?d >= '2020-09-07T00:00:00'^^xsd:dateTime && ?d <= '2020-09-24T00:00:00'^^xsd:dateTime )
	MINUS {?m :manifest_deactivated_by 'miglesia'^^xsd:string .}

	?m :manifest_has_package ?p .

	?p :package_dest_province ?province ;
	:package_weight ?w .

	?province :province_name ?name .

Would it be correct to specify unique constraints for the following entries?
"prealert"."envio":"noEnvio"
"prealert"."manifiesto":"id"

There might also be a constraint for "region"."province", that would be nice to add it.
Also, have you tried to move the MINUS after the last triple pattern?
Best,
Benjamin

hello @bcogrel
you are totally right. Please forgive me, I didn't provide the full constraints file. This is it:
region.country:name
region.country:alpha2_code
region.country:alpha3_code
region.province:id
region.province:cod_dpa
region.municipality:id
region.municipality:cod_dpa
region.municipality:province_id:region.province:id
prealert.envio:id
prealert.envio:noEnvio
prealert.envio:idManifiesto:prealert.manifiesto:id
prealert.envio:destNacionalidad:region.country:alpha3_code
prealert.envio:remitNacionalidad:region.country:alpha3_code
prealert.envio:paisOrigenDestino:region.country:alpha3_code
prealert.envio:destDomCodigoProvincia:region.province:cod_dpa
prealert.envio:destDomCodigoMunicipio:region.municipality:cod_dpa
prealert.manifiesto:xmlNombre
sip.active_manifests:user,manifest

I tried your suggestion, moved the MINUS after the last triple pattern, and it was successful!
There was a response in about 3 seconds, worst time 4.8s, best 2.7s
(I did try to change the order way before, but it was for the FILTERs only and before adding the constraints and the MINUS, that didn't work then and never tried again)
this is the SQL generated with the change:
SELECT v8."destDomCodigoProvincia1m12" AS "destDomCodigoProvincia1m12", v8."name1m17" AS "name1m17", SUM(CAST(v8."peso1m48" AS DOUBLE)) AS "sum1", COUNT(*) AS "v7"
FROM (SELECT DISTINCT v2."destDomCodigoProvincia" AS "destDomCodigoProvincia1m12", v1."estado" AS "estado1m44", v1."fechaArribo" AS "fechaArribo1m43", CASE WHEN v6."v0" IS NOT NULL THEN v1."xmlNombre" ELSE NULL END AS "manifest1m18", v3."name" AS "name1m17", v2."noEnvio" AS "noEnvio1m5", v1."origen" AS "origen1m14", v2."peso" AS "peso1m48", v6."v0" AS "v0", v1."xmlNombre" AS "xmlNombre1m43"
FROM "prealert"."manifiesto" v1
 JOIN
"prealert"."envio" v2 ON 1 = 1
 JOIN
"region"."province" v3 ON ((CAST(REPLACE(REPLACE(v1."fechaArribo",'T',' '),'Z','+00:00') AS TIMESTAMP) >= '2020-09-07 00:00:00') AND (CAST(REPLACE(REPLACE(v1."fechaArribo",'T',' '),'Z','+00:00') AS TIMESTAMP) <= '2020-09-24 00:00:00') AND REGEXP_LIKE(v1."estado",'^.*$') AND REGEXP_LIKE(v1."origen",'^.*$') AND v1."fechaArribo" IS NOT NULL AND v1."origen" IS NOT NULL AND v1."estado" IS NOT NULL AND v2."peso" IS NOT NULL AND v3."name" IS NOT NULL AND v1."xmlNombre" IS NOT NULL AND v2."noEnvio" IS NOT NULL AND v1."id" = v2."idManifiesto" AND v2."destDomCodigoProvincia" = v3."cod_dpa")
 LEFT OUTER JOIN
(SELECT v4."active" AS "active1m18", 'ontop-provenance-constant' AS "v0", v4."manifest" AS "xmlNombre1m0"
FROM "sip"."active_manifests" v4
WHERE ((v4."active" = 0) AND 'miglesia' = v4."user")
) v6 ON v1."xmlNombre" = v6."xmlNombre1m0"
WHERE v6."v0" IS NULL
) v8
GROUP BY v8."destDomCodigoProvincia1m12", v8."name1m17"

Thank you very much for your help!
I would humbly suggest to add some documentation about the use of constraints, all I found was in a very old issue. Also, something about SPARQL query organization to maximize performance. Moreover, it would be great if that could be handled by Ontop itself at the start of the query rewriting process.
Again, thank you!
best,
Manuel


Patching the CMake to respect $FALCO_VERSION

Signed-off-by: Kris Nova<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

/area rules

/area deployment

/area integrations

/area examples

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Welcome @kris-nova! It looks like this is your first PR to falcosecurity/falco 🎉

@kris-nova: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kris-nova: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.
In case you do not know which kind this proposal is please mention the maintainers using @team/maintainers.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash:<PHONE_NUMBER>c8385ecd8fb55a17f0f8160f756aa4

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

be65690 Merge branch 'dev' into bpf-version-patch

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Can't scroll to the last item

after implementation, the slider works fine but can't scroll to the last item it always bouncing back to the (last item-1)  position

I tried to enableSnapping(false), still not working

yes same issue i am facing , did any one find any solution .?

I also had this issue I've solved it by giving end margin to my carousel item.


Use the correct username when linking

Have you seen this causing bugs? The Scrapbook URL field is an Airtable function that returns exactly this with their latest username, so I’m not sure how this would work differently

we fetch the user record before changing the username, so it has the old username

ohhh cool


Adding home work 1

Adding home work 1

Thank you @SaniieAsanova for utilizing this curriculum! Great to see your assignment solutions. For now, the best place to share your solutions would be in Show and Tell.
Closing this PR so you can share your solutions within Discussions. Thank you!


Better compression ratios

Hi there!
I'm using this plugin on a Windows computer and I have realized that the compression ratio I got setting compression level 9 is not as good as using WinRAR with "the best" compression level, for instance.
Difference is a 3%, which might seem little, but on big archives it results in something important.
My question would be if there is any other setting I can configure to get better compression ratios or if you have planned to improve compression ratios in some way.
Thanks!

@enventa , I wish to attain different compression ratios with this package. Is there any option which allows us to do this? The "Quality" option didn't work for me.
Thanks for your help.


Allow using default gRPC dialer

The builtin dialer in gRPC has support for things like HTTP connect proxy which we need to support BYOC satellites in some environments. Buildkit was previously forcing it's own dialer implementation.

Corresponding earthly PR https://github.com/earthly/earthly/pull/4115


Fix error in get_ssm_by_samples function

get_ssm_by_samples function uses parallel::mclapply internally. But it neither import mclapply nor add parallel:: prefix to mclapply. Hence, the error
could not find function "mclapply"

may be returned (which could be avoided by running library(parallel) before calling get_ssm_by_samples).
Other functions that use get_ssm_by_samples internally (e.g. get_ssm_by_patients) return the same error.
Add parallel:: prefix to mclapply.
Pull Request Checklists
Checklist for all PRs
Required

[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)

library(GAMBLR)

#set sample IDs
these_samples = c("HTMCP-01-06-00485-01A-01D",
                  "14-35472_tumorA",
                  "14-35472_tumorB")

#get_ssm_by_samples
these_samples_ssm = get_ssm_by_samples(these_sample_ids = these_samples,
                                       projection = "grch37",
                                       seq_type = "genome")

#set patient IDs
these_patients = c("00-14595",
                   "00-15201",
                   "01-12047")

#get_ssm_by_patients
these_patients_ssm = get_ssm_by_patients(these_patient_ids = these_patients,
                                         seq_type = "genome",
                                         projection = "grch37")

Visualization of the these_samples_ssm object:
> head(these_samples_ssm, 3)
   Hugo_Symbol Entrez_Gene_Id Center NCBI_Build Chromosome Start_Position
1:     Unknown              0      .     GRCh37          1        5507023
2:      CAMTA1              0      .     GRCh37          1        7304379
3:        PER3              0      .

[x] I generated the documentation and checked for errors relating to the changed function (e.g. devtools::document()) and added NAMESPACE and all other modified files in the root directory and under man.

[ ] I have rebuilt the site with pkgdown::build_site(lazy = TRUE) to reflect any updated package documentation.

Optional but preferred with PRs
Checklist for New Functions
Required

[x] I changed an existing function and now it uses a library that isn't already a dependency of GAMBLR and I made the package aware of this dependency using the function documentation importFrom statement.

Please, notice that I didn't check the pkgdown::build_site step of the checklist, since it is not working for me. See error message in this slack discussion.

I updated this branch to contain the last pushes to master.


BUG: misc: Ensure fromimage converts mode 'P' to 'RGB' or 'RGBA'.

Convert images with mode 'P' to mode 'RGB' or 'RGBA', otherwise the array of palette indices is returned by imread() instead of the array of actual colors.

Maybe we'd like to keep 100% backward compat?
Then, adding a kwarg to_rgb=False and document it as converting palette images to RGB.

Maybe we'd like to keep 100% backward compat?

I wondered a bit about that, but decided the problem is really just a bug.  imread should "just work":  I shouldn't have to know or care that the image is indexed, it should just give me the array of colors.  As it is now, I need some other software (possibly PIL) to know that I read an index rather than the actual image colors.  While it is possible that there are users who learned to expect the index values rather than the actual colors, there could be other users who are currently being misled--they think the image is grayscale because that's what imread() returned, when in fact the image is RGB.  And I wonder what anyone who is relying on getting the index values does with that data?  Using scipy.misc.imread, they had no way to get the actual colors.  (I guess, if they happened to also be aware of scipy.ndimage.imread with its mode argument, they could read the file again with mode='RGB' or mode='RGBA'.)
So, IMHO, the current behavior is bug that should be fixed.  If this breaks someone's code, it seems likely that it happens because their code was already broken (mistaking an RGB image for grayscale).
Now that scipy.misc.imread has the mode argument (recently unified with scipy.ndimage.imread), if you really want the index values, you can explicitly request mode='P':
In [3]: im = imread('foo3x5x4indexed.png', mode='P')

In [4]: im
Out[4]:
array([[2, 2, 2, 2, 2],
       [3, 3, 0, 0, 0],
       [1, 1, 1, 1, 1]], dtype=uint8)

(My last commit fixes a warning that this call generated in PIL.)

Treating the current behavior as a bug and just changing it sounds reasonable to me.

@pv are you OK with merging this?

ok with me

thanks. in it goes then.

Thanks Warren.


How should I run it in Windows?

I tried building it using Visual Studio in Windows but I got a lot of errors of unknown reasons, I have zlib and zstd but still can't build and use it. Does it not work in Windows?

if you use c programing convert to .exe


AP-5396: Update SCA merits report

What
Link to story
Update the merits report when handling SCA cases:

Hide Emergency cost limit section for a backdated SCA application
The delegated function section is now aligned to matchthe rest of the page
The spacing above Separate representation has been corrected to match the other sections' spacing

Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
The standards in the Git Workflow document on Confluence should be followed
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

I have added a maintanence ticket to review rationalising display_emergency_certificate? and non_sca_used_delegated_functions?


I have a table defined as:

I have a table defined as:
@Table(name = "Rooms")
@Entity
interface IRooms : Persistable {
    @get:Column(nullable = false)
    @get:Key
    var roomJid: String

    @get:Column(name = "gameId", nullable = false)
    @get:ManyToOne
    var game: IGames

    @get:Column(name = "creatorJid", nullable = false)
    @get:ManyToOne
    var creator: IProfiles

    @get:Column(nullable = false)
    @get:OneToMany(cascade = arrayOf(CascadeAction.DELETE, CascadeAction.SAVE))
    val players: MutableList<IPlayers>

    @get:JunctionTable
    @get:ManyToMany(cascade = arrayOf(CascadeAction.DELETE, CascadeAction.SAVE))
    val invitedContacts: MutableList<IInvitedContacts>

    @get:Column(nullable = false)
    var lastModified: Long

    @get:Column(nullable = false)
    var isLocked: Boolean

    var nextPlayerJid: String?

    @get:Column(nullable = false)
    var hasGameEnded: Boolean

    @get:Column(nullable = false)
    var isSoloRoom: Boolean
}

What I want to do is to delete isSoloRoom column and add another column matchType defined as:
@get:Convert(MatchType.RequeryConverter::class)
var matchType: MatchType?

Now, I want to write migration script to remove isSoloRoom column and if isSoloRoom value is True set matchType to 'SOLO' else null.
What I tried:
I removed isSoloRoom column from the Schema above and in onUpgrade method I wrote:
db?.execSQL("UPDATE Rooms SET ('matchType') = ('SOLO') WHERE soloRoom = 1")
The matchType column is successfully added with desired effect but isSoloRoom is not removed.
What should I do in order to remove the isSoloRoom column and add matchType column. Should I remove it from Schema too and from onUpgrade script too via sqlite (which would be very hectic to write entire create table) or does requery provides some alternative to it?

Hi,
requery adds columens automatically, but tables or columns are not dropped. So if you want to remove an attribute and drop the column, you first need to remove the field from the entity and then drop the column. Unfortunately, sqlite does not simply allow you to drop columns. So you need to first move the data you want to a new temporary table, create a new table with the desired columns and then copy the data back and drop the temporary table (you can google these steps).

Okay. But can I create a single table using requery.

I'm not sure if I understand your question correctly. Requery creates the schema for you based on your entities. If there is already a schema in place then it will add new columns to the existing schema.

I have to drop one table only. Is this possible via requery?


Travis build failing due to mpi.h

Can't find mpi.h.
Tried including /usr/include and /usr/include/mpich and neither worked.

Fixed by removing MKL dependency.
Misread missing mkl.h as mpi.h!


Add generic Shoot ConfigMap validation webhook handler

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Common parts from the following handlers have been moved here:

https://github.com/gardener/gardener/blob/master/pkg/admissioncontroller/webhook/admission/auditpolicy/handler.go
https://github.com/gardener/gardener/blob/master/pkg/admissioncontroller/webhook/admission/authenticationconfig/handler.go
https://github.com/gardener/gardener/blob/master/pkg/admissioncontroller/webhook/admission/authorizationconfig/handler.go

This drastically reduces duplicating the same boilerplate again and again.
Which issue(s) this PR fixes:
Follow-up of #10682
Release note:

NONE

/assign


Relay icon does not appear in the badge

Are you experiencing an issue with...
badge-maker NPM package
🐞 Description
The Relay icon does not appear, even though it is already available on the simple icons website
🔗 Link to the badge
https://img.shields.io/badge/relay-F26B00?style=for-the-badge&logo=relay&logoColor=white
💡 Possible Solution
No response

Icon for relay was added in simple-icons 7.13.0. We're still running 7.12.0.
For more info on our update process for icons see https://github.com/badges/shields/discussions/5369
We usually review dependencies over the weekend so it'll probably be available in about a week.


Connection monitor

This started out as a quest for defining a trigger for the identify - we should trigger it upon establishing a new connection.
@klochowicz and me agreed that the current abstraction of each actor having to poll the endpoint for connection information is problematic, because already with ping we have quite a load of messages on the endpoint - and with adding more and more of actors that require this information this is inefficient and cumbersome.
So, we decided to add a connection_monitor that acts as a proxy. It monitors connections being established and dropped, as well as listening addresses. This new connection_monitor actor is the only actor that polls the endpoint for connection information.
Additionally we came to the conclusion that other actors don't want to poll to get connection information but want to get notified on changes, so we let actors that are interested in changes subscribe to the connection_monitor that notifies them about the relevant changes. (i.e. observer pattern)

With this work in place adding identify becomes easy.

@klochowicz I added some comments for the last commit.

thanks for having a look! actioned and pushed a commit.

Sorry to come up with this now, but after thinking about the endpoint_monitor overnight I came to the conclusion that this solution is flawed.
The current endpoint_monitor will not detect re-connects properly. I the user disconnects and re-connects within the polling interval of the endpoint_monitor we will not detect that a new connection was established. (Because the delta will be the same, we never notify about disconnect / connect again).
This can lead to not sending offers to the user, because the plan is to use the notifications in the maker to open the substream to the user to send offers. If the maker does not detect the re-connect it will open the substream.
I think this might already be a problem in the current implementation where we poll the connections!
I think the proper solution is to build the notifications about ConnectionEstablished and ConnectionDropped into the endpoint itself, once it actually happens. Only then can we properly detect re-connects.
I don't think that building this into the endpoint has downsides besides the endpoint getting a bit more complex (I don't think this is a big deal at this point, it's not especially hard code).
If we build the subscription and notification mechanism into the endpoint we will also be more efficient - we won't have to send around all the ConnectionStats anymore; GetConnectionStats could just go away.

Sorry to come up with this now, but after thinking about the endpoint_monitor overnight I came to the conclusion that this solution is flawed.
The current endpoint_monitor will not detect re-connects properly. I the user disconnects and re-connects within the polling interval of the endpoint_monitor we will not detect that a new connection was established. (Because the delta will be the same, we never notify about disconnect / connect again). This can lead to not sending offers to the user, because the plan is to use the notifications in the maker to open the substream to the user to send offers. If the maker does not detect the re-connect it will open the substream. I think this might already be a problem in the current implementation where we poll the connections!
I think the proper solution is to build the notifications about ConnectionEstablished and ConnectionDropped into the endpoint itself, once it actually happens. Only then can we properly detect re-connects.
I don't think that building this into the endpoint has downsides besides the endpoint getting a bit more complex (I don't think this is a big deal at this point, it's not especially hard code). If we build the subscription and notification mechanism into the endpoint we will also be more efficient - we won't have to send around all the ConnectionStats anymore; GetConnectionStats could just go away.

Interesting thoughts, initial response so far:

I am open to try to cram this into the endpoint itself, as this will reduce the periodic message load a bit further, however: I think your point showcases a flaw in the `offer' protocol more than this - we should be as resilient as possible. in this case, the taker who connects again is in a better position to open a substream again to retrieve the latest state.
I wouldn't go as far as removing the polling API, because it can be useful (metrics, ephemeral actors etc).

That said, I think it's worth a shot. Happy to do a POC in the meantime to see how much complex will it get (I bet 'not much', if we pass in a single Subscribers struct).
I'll stop trying to address the review feedback until we settle on this.

Sorry to come up with this now, but after thinking about the endpoint_monitor overnight I came to the conclusion that this solution is flawed.
The current endpoint_monitor will not detect re-connects properly. I the user disconnects and re-connects within the polling interval of the endpoint_monitor we will not detect that a new connection was established. (Because the delta will be the same, we never notify about disconnect / connect again). This can lead to not sending offers to the user, because the plan is to use the notifications in the maker to open the substream to the user to send offers. If the maker does not detect the re-connect it will open the substream. I think this might already be a problem in the current implementation where we poll the connections!
I think the proper solution is to build the notifications about ConnectionEstablished and ConnectionDropped into the endpoint itself, once it actually happens. Only then can we properly detect re-connects.
I don't think that building this into the endpoint has downsides besides the endpoint getting a bit more complex (I don't think this is a big deal at this point, it's not especially hard code). If we build the subscription and notification mechanism into the endpoint we will also be more efficient - we won't have to send around all the ConnectionStats anymore; GetConnectionStats could just go away.

Interesting thoughts, initial response so far:
* I am open to try to cram this into the endpoint itself, as this will reduce the periodic message load a bit further, however: I think your point showcases a flaw in the `offer' protocol more than this - we should be as resilient as possible. in this case, the taker who connects again is in a better position to open a substream again to retrieve the latest state.

* I wouldn't go as far as removing the polling API, because it can be useful (metrics, ephemeral actors etc).

That said, I think it's worth a shot. Happy to do a POC in the meantime to see how much complex will it get (I bet 'not much', if we pass in a single Subscribers struct).
I'll stop trying to address the review feedback until we settle on this.

The problem is not only the offers protocol, but also identify. For identify each peer is supposed to poll the identity message upon connection established. But both sides might not notice that a connection was re-established.
Note that a taker re-connecting might not notice neither because the delta does not change. (Unless I'm missing something)
I think the problem is not the protocols, but that this solution cannot handle re-connects properly. Even if we re-design the protocols to be resilient against that, this is a flaw!

The problem is not only the offers protocol, but also identify. For identify each peer is supposed to poll the identity message upon connection established. But both sides might not notice that a connection was re-established. Note that a taker re-connecting might not notice neither because the delta does not change. (Unless I'm missing something)
I think the problem is not the protocols, but that this solution cannot handle re-connects properly. Even if we re-design the protocols to be resilient against that, this is a flaw!

Identify would not be problematic - it's unlikely that someone would swap to a different version within the polling time.

Closing this PR in favour of #2159 based on the discussion with @da-kami above - it turned out to be simpler to just add the new capability of subscribing directly into the Endpoint.

@luckysori thank you for your valuable feedback! due to creation of the new PR some of the issues became obsolete so I marked them as 'resolved',  I have also addressed some of them in the new PR, and then I have left open the issues I pushed back on. Happy to discuss them here to avoid doubling on work in the new PR.


[Issue] olareg help serve does not mention the "shared" store option

Current Behavior
$ olareg help serve
Run a registry server

Usage:
  olareg serve [flags]

Examples:

<snip>

Flags:
<snip>
      --store-type string          storage type (dir, mem) (default "dir")
<snip>

Expected Behavior
The shared store type should also show.
Steps To Reproduce
In a container from ghcr.io/olareg/olareg:edge-alpine:
Run olareg help serve and check the output.
Version
 $ olareg version
VCSTag:     (devel)
VCSRef:     003b719af399682673c301cec902726a84bb4f2e-dirty
VCSCommit:  003b719af399682673c301cec902726a84bb4f2e
VCSState:   dirty
VCSDate:    2024-12-29T15:42:28Z
Platform:   linux/amd64
GoVer:      go1.23.4
GoCompiler: gc

Environment

Running as binary or container: container
Host platform: Linux
Other tools / container runtimes: docker

Anything else
I'm currently considering olareg for a containerised registry mirror. The default store seems to be usable to load in the contents of the tarballs that come out of ctr image export which is awesome. (I was looking at the shared store to reduce duplication (I think I saw it in the code) when I noticed this)

Ok, that store might not be working:
~ $ docker push localhost/olareg/olareg:edge
The push refers to repository [localhost/olareg/olareg]
6dfc3bb3f798: Retrying in 4 seconds
c08bf7a96dd8: Retrying in 4 seconds
8fe07296a23e: Retrying in 4 seconds
4adbcf9b435e: Retrying in 4 seconds
^C
~ $ docker logs olareg
time=2024-12-31T14:52:57.429Z level=ERROR msg="ServeHTTP called without a backend store"
time=2024-12-31T14:52:57.430Z level=ERROR msg="ServeHTTP called without a backend store"
time=2024-12-31T14:52:57.430Z level=ERROR msg="ServeHTTP called without a backend store"
time=2024-12-31T14:52:57.431Z level=ERROR msg="ServeHTTP called without a backend store"
time=2024-12-31T14:52:57.431Z level=ERROR msg="ServeHTTP called without a backend store"
time=2024-12-31T14:52:57.432Z level=ERROR msg="ServeHTTP called without a backend store"

This seems to be the only reference to it
So I'm guessing it is not implemented yet... (I can probably run fdupes and hardlink duplicate blobs)

I'm guessing that a shared store should be quite simple: Move the blobs directory to the root of the store directory instead of under the individual repository

So I'm guessing it is not implemented yet... (I can probably run fdupes and hardlink duplicate blobs)

Correct, not implemented yet. Hard links are a consideration for how to implement it, but that may limit the underlying filesystem.

I'm guessing that a shared store should be quite simple: Move the blobs directory to the root of the store directory instead of under the individual repository

That would be part of the solution, but individual blob directories are still needed per repo to follow the OCI Layout specification. If a user later changes the root to be a sub-directory or parent directory, that would cause things to break. GC would need to be aware of the parent blobs folder and all child repositories, even those created outside of olareg. And the repo listing API (_catalog) would likely get supported in the process.


Dont run the btree-stress test under valgrind.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@toregge PR


Image Picker XCUITests Failing (XCode 16, IOS 18)

Steps to reproduce
*Steps to Reproduce:

Install XCode 16.0 Beta 1 and iOS 18.0 Simulator.
Clone the Flutter packages repository: git clone https://github.com/flutter/packages
Open the example iOS directory on XCode: packages/image_picker/image_picker_ios/example/ios
Select Flutter master version (3.23.0-13.0.pre.188) or stable (3.22.2)
Run the tests using the XCode test view and selecting some simulator with iOS 18.0

Expected results
The mentioned tests were previously succeeding. Please note that we are currently testing with Xcode 16 Beta 1, which includes the iOS 18 simulator, and this might be breaking the tests.
Actual results
The following test case fails:

Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
testPickingFromGallery: failed - Failed due to not able to find an image with 30 seconds

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale en-UY)
    • Flutter version 3.22.2 on channel stable at /Users/qa/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (6 days ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc4)
    • Android SDK at /Users/qa/Library/Android/sdk
    • Platform android-34, build-tools 35.0.0-rc4
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode-beta.app/Contents/Developer
    • Build 16A5171c
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)

[✓] VS Code (version 1.87.2)
    • VS Code at /Users/qa/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

I was able to reproduce this, here's the xcresult (larger than GitHub's 25MB upload limit): https://drive.google.com/file/d/1Jf_XBCF1Rx7iqA16ZaIqvktplFtot1Bh/view?usp=sharing
@rzambroni these reports would be most helpful if the detailed test failures/screenshots/device recordings are included.
Unfortunately I don't know how to export the Test Report in Xcode's UI, but from the command line you can run this (swap iPhone 15 Pro with whatever simulator you're using:
$ cd packages/image_picker/image_picker_ios/example/
$ flutter build ios --config-only
$ xcodebuild test -workspace ios/Runner.xcworkspace -scheme Runner -configuration Debug -destination 'platform=iOS Simulator,name=iPhone 15 Pro,OS=18.0' -resultBundlePath test/

And then you can zip up test.xcresult and attach to the issues.

Looks like the app hierarchy for the picker changed, will need to update the expectations.


请求调节正文字体（编辑模式、阅读模式及Code字体）

请求调节正文字体（编辑模式、阅读模式及Code字体），能否像Header font一样做到style setting里面可以自定义，谢谢~

you can do that with obsidian own font selector (Settings > Appearance). Both for normal text font as well as code block font. See screenshot below. If you meant something else let me know.


Changed the footer background color

thank you so much for the contribution @eduardoallegrini! and for adjusting the footer method, very much appreciated 🙏


vacuole PMID:30451685

tubular vacuole morphology
(original request/synonym: tubular-shaped vacuoles)
note: "abnormal vacuolar morphology during dithiothreitol(DTT) treatment" also requested, but he only thing it would add is not having to look at the conditions column

normal growth on cobalt

normal growth on manganese

PECO:new +DTT
synonym: +dithiothreitol

tubular vacuole morphology during vegetative growth FYPO:0006784
normal growth on cobalt FYPO:0006785
normal growth on manganese FYPO:0006786
edit file: 9f98f631344a0eaeadf0158d63f9ba443fda6e85
release: 56002b9f89b16c58a9fd22e41cdad8e2cdac8e6d

PECO term added now.


Disable knockback when using vanilla damage

Description
Ability to disable knockback on weapons when using the vanilla damage system.
Configuration
No_Knockback: <true/false>

Payment (optional)

[ ] I'm willing to pay for this feature

disable vanilla damage to disable knockback


Tested with Lenovo Z580 and it works

I am using windows 10 21H2 and program works. There is one thing that Temperature shows wrong values. I see temperature sometimes 255c sometimes around 100c.
Thanks for project.

Thanks for the feedback!
CPU temperature value comes directly from Embedded Controller and this value stored on different registers for different laptop models. I initially decided to wrote this program to work only with Z500 model because at the time I wasn't sure this program will work for other models as well and due to this I avoided using third party libraries to get the temperature for keeping the program size small as possible. FAN SPEED value also might be incorrect due to mentioned issue.
Unfortunately you also can't use --temperature  CLI parameter to watch the temperature and run the fan accordingly.
However if you interested you can use EmbeddedController or RWEverything to find the register and change it in here and recompile the whole thing for yourself.
Or maybe a simpler approach is to get the temperature with help of Open Hardware Monitor and small PowerShell script to run this program based on gathered temperature. (e.g. link)


String operations should honor PowerFxConfig's CultureInfo

I'd expect the all operations that involves locale/culture should honor PowerFxConfig culture setting, but looks like we'll using the CurrentCulture of the host instead.
Example
System.Threading.Thread.CurrentThread.CurrentCulture = new System.Globalization.CultureInfo("tr-TR");

var config = new PowerFxConfig(System.Globalization.CultureInfo.InvariantCulture);
var engine = new RecalcEngine(config);
...

Then we get the Turkish culture instead of the invariant version
Upper("indigo") --> İNDİGO
Same problem applies to Lower, Proper
Same problem would likely occur in string comparison operations as well, but I couldn't find such functions.

Another related one is temporal data.
if I set host culture
System.Threading.Thread.CurrentThread.CurrentCulture = new System.Globalization.CultureInfo("tr-TR");
then
> Text(DateTimeValue("10/11/2014 1:50:24.765 PM", "tr-TR"))
10.11.2014 13:50

If I set host back to default (en-US), then
> Text(DateTimeValue("10/11/2014 1:50:24.765 PM", "tr-TR"))
10/11/2014 13:50

expected?

I did a quick check with the latest daily builds, looks like Proper() isn't updated
Proper("indIgo") --> Indıgo
Proper("INDIGO") --> ındıgo
https://github.com/microsoft/Power-Fx/blob/a8e4eaefd6349522c06a2e9a5c7a26848775f458/src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryText.cs#L293
Probably should be
return new StringValue(irContext, runner.CultureInfo.TextInfo.ToTitleCase(runner.CultureInfo.TextInfo.ToLower(args[0].Value)));

(not sure if ToLower() is really necessary here...)

Hi @susosuso. I've tried a few scenarios from my end and couldn't simulate your problem.
There is a test case checking if Proper is working as intended:
https://github.com/microsoft/Power-Fx/blob/a8e4eaefd6349522c06a2e9a5c7a26848775f458/src/tests/Microsoft.PowerFx.Interpreter.Tests/ConfigTests.cs#L347
Can you please elaborate what your scenario is?


Kustomize upgrade method misses couchbase patch of old password and creation of new superpass secrets

resolved in https://github.com/GluuFederation/cloud-native-edition/commit/670717edd46d742b200f27ac02a93a9b0f8ffa50


Failed to find best cuBLAS algorithm, GEMM performance might be suboptimal

Dear Yoshitaka,
I was able to successfully install ColabFold in a machine runnine Ubuntu 20 and a Tesla K40c GPU. Running a prediction is completed, although it takes ~24 hs to be completed (430 residues long), with command
colabfold_batch --amber --templates --num-recycle 3 test.fasta /home/pc08/Desktop/test_AF
During calculation, I get the following messages:
E external/org_tensorflow/tensorflow/stream_executor/cuda/cuda_driver.cc:771] failed to alloc<PHONE_NUMBER>0 bytes unified memory; result: CUDA_ERROR_OUT_OF_MEMORY: out of memory
W external/org_tensorflow/tensorflow/compiler/xla/service/gpu/gemm_algorithm_picker.cc:211] Failed to find best cuBLAS algorithm, GEMM performance might be suboptimal: INTERNAL: All algorithms tried for %cublas-gemm.21 = f32[1908,128]{1,0} custom-call(f32[1908,128]{1,0} %bitcast.319, f32[128,128]{1,0} %bitcast.321), custom_call_target="__cublas$gemm", backend_config="{\"alpha_real\":1,\"alpha_imag\":0,\"beta\":0,\"dot_dimension_numbers\":{\"lhs_contracting_dimensions\":[\"1\"],\"rhs_contracting_dimensions\":[\"0\"],\"lhs_batch_dimensions\":[],\"rhs_batch_dimensions\":[]},\"batch_size\":\"1\",\"lhs_stride\":\"244224\",\"rhs_stride\":\"16384\"}" failed. Falling back to default algorithm.
Let me repeat, that nevertheless, the calculations of the 5 models are completed, and looking good. But I would like to know if this can be improved to run it more efficiently.
Not sure if it's useful, but I've noticed that the GPU is only sporadically used (with GPU's memory used to the max the whole time), and one CPU being used at 100% during most of the run.
If you have any insights on how to resolve this, I would greatly appreciate it. Thanks!

Can you share the output of nvidia-smi and your CUDA toolkit version (nvcc --version)?

These are the outputs:
`pc08@pc08:~$ nvidia-smi
Thu Feb 24 09:13:42 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 470.103.01   Driver Version: 470.103.01   CUDA Version: 11.4     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla K40c          Off  | 00000000:01:00.0 Off |                    0 |
| 30%   63C    P0    67W / 235W |  11098MiB / 11441MiB |      3%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A       919      G   /usr/lib/xorg/Xorg                 16MiB |
|    0   N/A  N/A      1446      G   /usr/lib/xorg/Xorg                 67MiB |
|    0   N/A  N/A      1622      G   /usr/bin/gnome-shell               23MiB |
|    0   N/A  N/A      1932      G   /usr/lib/firefox/firefox            9MiB |
|    0   N/A  N/A     48904      C   ...bfold-conda/bin/python3.7      208MiB |
+-----------------------------------------------------------------------------+`
pc08@pc08:~$ nvcc --version nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2021 NVIDIA Corporation Built on Mon_Oct_11_21:27:02_PDT_2021 Cuda compilation tools, release 11.4, V11.4.152 Build cuda_11.4.r11.4/compiler.30521435_0

11098MiB / 11441MiB

The Memory-usage seems very high. Is any other process using GPU running?
Or, are these issues https://github.com/YoshitakaMo/localcolabfold/issues/22, https://github.com/YoshitakaMo/localcolabfold/issues/27, and https://github.com/YoshitakaMo/localcolabfold/issues/50 helpful to you?

Thanks Yoshitaka, I'll look into those issues and I'll come back.
Best, Fernando
On Thu, Feb 24, 2022 at 8:39 PM Yoshitaka Moriwaki @.***>
wrote:

11098MiB / 11441MiB
The Memory-usage seems very high. Is any other process using GPU running?
Or, are these issues #22
https://github.com/YoshitakaMo/localcolabfold/issues/22, #27
https://github.com/YoshitakaMo/localcolabfold/issues/27, and #50
https://github.com/YoshitakaMo/localcolabfold/issues/50 helpful to you?
—
Reply to this email directly, view it on GitHub
https://github.com/YoshitakaMo/localcolabfold/issues/62#issuecomment-1050366693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK537YQCJJOEMHZKBJSLFKLU426TXANCNFSM5PFHBHTQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Yoshitaka,
I have tried again installing cuDNN for my CUDA 11.4, and running the commands suggested in the issues you suggested
export XLA_FLAGS=--xla_gpu_force_compilation_parallelism=1
export TF_FORCE_UNIFIED_MEMORY="1"
export XLA_PYTHON_CLIENT_MEM_FRACTION="4.0"
export XLA_PYTHON_CLIENT_ALLOCATOR="platform"
export TF_FORCE_GPU_ALLOW_GROWTH="true"
Even though the same warnings were showing in the terminal, I was surprised to see that now the GPU was being used almost at capacity (GPU's memory was also >97% used). However, after a while, the process stopped with the following message:
`E external/org_tensorflow/tensorflow/stream_executor/cuda/cuda_driver.cc:1047] could not synchronize on CUDA context: CUDA_ERROR_LAUNCH_FAILED: unspecified launch failure :: *** Begin stack trace ***
PyDict_SetItem
_PyModule_ClearDict
PyImport_Cleanup
Py_FinalizeEx
Py_Exit

PyErr_PrintEx
PyRun_SimpleFileExFlags

_Py_UnixMain
__libc_start_main

*** End stack trace ***
2022-03-07 16:58:22.142478: F external/org_tensorflow/tensorflow/compiler/xla/service/gpu/gpu_executable.cc:127] Check failed: pair.first->SynchronizeAllActivity() `
The complete terminal's output in the text file.
Any suggestions on how to proceed?
Thanks,
Fernando
issue_colabfold.txt

Hello, I have an update for this. Today I ran the same test, but this time WITHOUT the commands indicated in the issues:
export XLA_FLAGS=--xla_gpu_force_compilation_parallelism=1
export TF_FORCE_UNIFIED_MEMORY="1"
export XLA_PYTHON_CLIENT_MEM_FRACTION="4.0"
export XLA_PYTHON_CLIENT_ALLOCATOR="platform"
export TF_FORCE_GPU_ALLOW_GROWTH="true"

Now, the calculations were completed, with the GPU being used at capacity and taking one hour for a ~430 residues model.
Still, the Failed to find best cuBLAS algorithm, GEMM performance might be suboptimal warnings are showing up, and the memory is also at ~97%, but at least the process is completed and much faster than before.
Thanks,
Fernando


Fixed bug with the wrong images being removed from the images array, …

…depending on the size of the array and the options.offset.

I'm trying to remind myself why I used count instead of images.length like you did and I really can't. Look good, thanks for pull request!


UI was broken after upgraded to macOS Big Sur with 2.14

Describe the bug
Wall paper, some of the system icons, borders of context menu was broken after upgraded to macOS Big Sur with 2.14.
Expected behavior
Graphics display correctly
Environment:

Running OSX version: 11.0.1

Target drive OSX version: 11.0.1

HaC Mini installer version: 2.14

Additional context

closed. submitted with wrong type


flows

Bundle Report
Changes will decrease total bundle size by 53.84kB :arrow_down:

Bundle name
Size
Change

yapt-server-esm
594.68kB
594.68kB :arrow_up:

yapt-client-esm
(removed)
648.52kB :arrow_down:


add close

this fixes chromedriver not closing

Hey, I think the Quit() method is a stronger way to close the browser, there is no need to call both.
Please read here
https://www.geeksforgeeks.org/how-to-use-close-and-quit-method-in-selenium-python/
While doing stuff with selenium multiple browsers with multiple tabs will normally opens in order to close these tabs close() and quit() methods are used. close() method is used to close the current browser window on which the focus is set, on the other hand quit() method essentially calls the driver.dispose method that successively closes all the browser windows and ends the WebDriver session graciously.

So I don't think this PR will improve anything. Please feel free to explain if you have a different take on this.

Hey, if you try to run a config with selenium, with current rurilib, drivers don't get killed,
if you compile "my" version of rurilib drivers do get killed...
so it does matter
regards

Van: openbullet @.>
Verzonden: donderdag 16 juni 2022 7:52
Aan: openbullet/OpenBullet2 @.>
CC: DJHooligan @.>; Author @.>
Onderwerp: Re: [openbullet/OpenBullet2] add close (PR #743)
Hey, I think the Quit() method is a stronger way to close the browser, there is no need to call both.
Please read here
https://www.geeksforgeeks.org/how-to-use-close-and-quit-method-in-selenium-python/
While doing stuff with selenium multiple browsers with multiple tabs will normally opens in order to close these tabs close() and quit() methods are used. close() method is used to close the current browser window on which the focus is set, on the other hand quit() method essentially calls the driver.dispose method that successively closes all the browser windows and ends the WebDriver session graciously.
So I don't think this PR will improve anything. Please feel free to explain if you have a different take on this.
—
Reply to this email directly, view it on GitHubhttps://github.com/openbullet/OpenBullet2/pull/743#issuecomment-1157260717, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHO3K6FYC2UDEEH6ITQL53VPK6JPANCNFSM5Y42VZNQ.
You are receiving this because you authored the thread.Message ID: @.***>

Oh I didn't know that this was an issue with the chromedriver itself. Thanks for the heads up, I will merge.

Chromium will start if you setup a user in dockerfile .
(https://developer.chrome.com/blog/headless-chrome/)
regards,

I am against this change.
I tried long time ago to run OB2 in Docker as an unprivileged user.
But i noticed a lot of problems with the UserData volume cause Docker is using the UserID and GroupID of it's Container which might be totally different than the one of the mounted Volume.
So either users have to start the Docker Container in a more complicated way or we produce a file permission mess the Users system - depending on the Host configuration. (also think of multiuser systems and mounted folders from a NAS or so - most solutions only have a workaround for user+group ID 0:0 but not some random other)
Some of these Problems can be tackled somehow on a linux host for sure. - But also for Windows and MacOS?


SLIM-598_Fix_Documentation

SUMMARY.md.

 You should sign our Contributor License Agreement in order to get your pull request merged.

All is well.

All is well.


[Hacktoberfest]: Update the Tania Rascia entry in the Mentors Section

🆕🐥☝ Beginners Only:
This issue is reserved for people who are new to Open Source. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
To do:

Update the Tania Rascia entry in the Mentors Section so the comments say Software engineer, writer, and open-source creator instead of the generic placeholder comment Be Kind
See below for link to step-by-step tutorial
Add your details in the contributors section at the bottom of the page using the same formatting as the last one

📋 Step by Step
Step-By-Step Tutorial
Remember to observe the Code of Conduct - by which we mean, in short - Be Kind, Be Positive, Be Helpful

I'll take this


AE Circuits produce spurrious phase kickback

Information

Qiskit Software
Version

Qiskit
0.23.6

Terra
0.17.0.dev0+55eb6f3

Aer
0.7.5

Ignis
0.5.2

Aqua
0.8.2

IBM Q Provider
0.11.1

Python | 3.7.3 (default, Mar 27 2019, 16:54:48)  [Clang 4.0.1 (tags/RELEASE_401/final)]
OS | Darwin
CPUs | 4
Memory (Gb) | 16.0
Fri Mar 05 09:22:52 2021 CST
What is the current behavior?
Related to #5914
When I

Apply an AE circuit
Apply CX from one output qubit onto a clean ancilla
Uncompute AE
Measure only the AE output qubits.

My AE output qubits are not returned to their initial state.
Because the ancilla is in the |0> state, there should be no phase kick-back, so I expect all qubits to return to the initial state, aside from the (un-measured) ancilla.
This issue seems to depend in severity on whether the qasm_simulator or statevector_simulator is being used. As shown below.
Steps to reproduce the problem
The following code reproduces the issue:
import sys, qiskit
from qiskit import QuantumRegister, QuantumCircuit, Aer, execute, ClassicalRegister
from qiskit.tools.visualization import plot_histogram
import numpy as np
from qiskit.aqua.algorithms import AmplitudeEstimation
import matplotlib.pyplot as plt

theta = 0.65
m=5 #number of evaluation qubits

q = QuantumRegister(1, 'q') # objective qubit
ae_q = QuantumRegister(m, 'm') # AE output register
anc = QuantumRegister(1, 'anc') # Add an ancilla register
c = ClassicalRegister(m, 'c')
qc = QuantumCircuit(q, ae_q, anc, c)

# State preparation circuit
qc2 = QuantumCircuit(q)
qc2.ry(theta, q[0])

# Forward AE
ae = AmplitudeEstimation(m, state_preparation=qc2, objective_qubits=[0])
ae_inst = ae.construct_circuit().to_instruction()
qc.append(ae_inst, list(ae_q) + list(q))

# Do a CNOT controlled on one of the AE output qubits
# with the ancilla qubit as the target.
qc.cx(ae_q[0], anc[0])

#Reverse AE
ae_inst_r = ae.construct_circuit().inverse().to_instruction()
qc.append(ae_inst_r, list(ae_q) + list(q))
qc.measure(ae_q, c)
qc.decompose().draw()

shots = 1000

backend = Aer.get_backend('statevector_simulator')
results = execute(qc, backend, shots=shots).result()
counts = results.get_counts()
plot_histogram(counts)
print("Counts when using statevector_simulator:")
print(counts)

backend = Aer.get_backend('qasm_simulator')
results = execute(qc, backend, shots=shots).result()
counts = results.get_counts()
plot_histogram(counts)
print("\nCounts when using qasm_simulator at {} shots:".format(shots))
print(counts)

total_counts = {}
for i in range(100):
    backend = Aer.get_backend('statevector_simulator')
    results = execute(qc, backend, shots=shots).result()
    counts = results.get_counts()
    total_counts.update(counts)
plot_histogram(total_counts)
print("\nAfter running the statevector_simulator many "\
      "times and merging the counts dictionaries, we observe:")
print(total_counts)

import qiskit.tools.jupyter
%qiskit_version_table
%qiskit_copyright

This gives the output:
Counts when using statevector_simulator:
{'00000': 1}

Counts when using qasm_simulator at 1000 shots:
{'00000': 955, '10001': 1, '10010': 2, '10011': 2, '10100': 4, '10101': 3, '10110': 2, '10111': 1, '11011': 2, '11100': 1, '11101': 4, '11110': 1, '00011': 2, '00100': 2, '00101': 5, '00110': 5, '00111': 3, '01001': 1, '01010': 3, '01111': 1}

After running the statevector_simulator many times and merging the counts dictionaries, we observe:
{'00000': 1, '10010': 1, '10001': 1, '00101': 1, '01100': 1, '11110': 1}

What is the expected behavior?
Counts when using statevector_simulator:
{'00000': 1}

Counts when using qasm_simulator at 1000 shots:
{'00000': 1000}

After running the statevector_simulator many times and merging the counts dictionaries, we observe:
{'00000': 1}

Suggested solutions
I suspect global phases may again be the issue, as was the case for #5914.

@Cryoris


Dynamic Navigation Menu

This adds the ability to create new locations from within the WordPress Menus system and use them within the project.
It starts off by using the default PRIMARY navigation from WordPress, and if a menu is set to that location, uses it for the top level navigation.
Otherwise, it just displays all of the top level pages, which needless to say won't support a huge list of them.
The menus do not support children at this time.
By default, inside next.config.js, the primary menu is set to the ID:
MENU_LOCATION_NAVIGATION: 'PRIMARY',

But can be changed if would prefer to use another location, making this work without a location and easy to add.
Fixes #148
Fixes #7

This is awesome it handles external and internal links well and looks good.
I think it's quite likely to have a location that's not PRIMARY. I wonder if the line in the next.config.js should be
    MENU_LOCATION_NAVIGATION: process.env.WORDPRESS_PRIMARY_NAV_LOCATION || 'PRIMARY,

and documented in the readme. Happy to be disagreed with though! :)

This is awesome it handles external and internal links well and looks good.
I think it's quite likely to have a location that's not PRIMARY. I wonder if the line in the next.config.js should be
    MENU_LOCATION_NAVIGATION: process.env.WORDPRESS_PRIMARY_NAV_LOCATION || 'PRIMARY,

and documented in the readme. Happy to be disagreed with though! :)

@doingandlearning yeah that make sense, my thought process was somsone would edit the next.config.js instead of an env variable but not reason it can't co-exist
also is there a "default" name? i had "PRIMARY" in there by default, though i totally could have added that myself and not remember, or maybe it comes by default with the Bitnami verion from Lightsail

@doingandlearning i added the env variable like you said as well as the documentation for the variable, having it still default to PRIMARY. going to merge this in
still curious though if there is a true "default" that wordpress ships with, if any. thats really the only reason i used PRIMARY


I think we should have one manager for each source.

Expected Behavior
Customer installs container source and they try to look at the reconciliation logs, they have a hard time finding a controller that has "container source" in it's name.
Actual Behavior
We smash most source controllers into one pod.

/kind proposal

/kind feature-request


Demo site for WebServerOAuthFlow is offline

In the README, the URL https://sfdcauth.cloudapp.net/ is given for a demo of this flow.  It does not exist.

I confirm this.
On https://github.com/developerforce/Force.com-Toolkit-for-NET/blob/master/README.md
There is a sentence:

You can see this demo live here: https://sfdcauth.cloudapp.net/

If you will fix the sample sites builds - you can change the setence ;)
If you will fix the demo on cloud app - maybe add there some kind of version number or synchronize the depoly there with TeamCity build, so it will be always up-to-date.

Fixed. https://github.com/developerforce/Force.com-Toolkit-for-NET/commit/f22db31e3d4ce9626fc3cdb9ba9435ac4225afaf


RIOT not working when migrating data from 1 redis cluster to other

Hi,
I am not sure if riot supports this but i was trying to migrate 1 redis cluster to a different redis cluster using the below command.
Command:
root@migration-riot-redis-cluster-migration:/home/# ./riot-redis/bin/riot --info --timeout=600 -h 10.x.x.x -p 6379 -a '123456' -c -n 0 replicate --timeout=600 -h 10.x.x.x -p 6379 -a '12345678'  -c -n 0 --mode live

Its able to migrate data at the first time but its failing on live migration, is that expected in RIOT ?
Executing step: [live]
Executing step: [scan]
Scanning   0% [                                                                                ]  0/13 (0:00:00 / ?) ?/s
Listening  ? % [=                                       ] 0/? (0:00:00 / ?) ?/sEncountered an error executing step live in job replicate
Listening  ? % [=                                       ] 0/? (0:00:00 / ?) ?/s
Step: [live] executed in 303ms
Job: [SimpleJob: [name=scan-reader]] launched with the following parameters: [{}]
Executing step: [scan-reader]
Step: [scan-reader] executed in 292ms
Scanning 100% [=================================] 13/13 (0:00:00 / 0:00:00) ?/s{}] and the following status: [COMPLETED] in 310ms
Step: [scan] executed in 861ms
Job: [FlowJob: [name=replicate]] completed with the following parameters: [{}] and the following status: [FAILED] in 900ms
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed

In live mode, the Source of Redis nodes must modify this config.  did you ?
config set notify-keyspace-events KA

May be ,you can try this args,  replicate --type ds

In live mode, the Source of Redis nodes must modify this config. did you ? config set notify-keyspace-events KA

i did set on only 1 of the master of the cluster, that should be fine right ?
Or i need to set on all the 3 masters ?
Even if i set on just 1 master , i am able to get all data to destination cluster but live mode is not working

@szy345 does redis riot doesn't work with redis cluster migration ?

i did set this config set notify-keyspace-events KA on all 3 master but still live replication fails as soon as i add one new key on the source master node.
Error log:
Listening  ? % [ =                                     ] 1/? (0:00:03 / ?) .3/st not served
Step: [live] executed in 3s661ms
Job: [FlowJob: [name=replicate]] completed with the following parameters: [{}] and the following status: [FAILED] in 3s713ms
Parent JobExecution is stopped, so passing message on to StepExecution
Step interrupted through StepExecution
Encountered interruption executing step live-reader in job live-reader : Job interrupted status detected.
Step: [live-reader] executed in 3s363ms
Parent JobExecution is stopped, so passing message on to StepExecution
Exception while closing step execution resources in step live-reader in job live-reader
Encountered interruption executing job: Job interrupted by step execution
Job: [SimpleJob: [name=live-reader]] completed with the following parameters: [{}] and the following status: [STOPPED] in 3s382ms

Are both the source and destination sides self built clusters? Or Alibaba Redis Cloud services？ Or others？

self build clusters

actually previously i missed to add -c in the riot command now that i added that, replication at the first time runs fine. But because i am running live replication as soon as i add a new key the riot fails with this error
Listening  ? % [ =                                     ] 1/? (0:00:04 / ?) .2/sartition for slot 866.
Step: [live] executed in 4s940ms
Job: [FlowJob: [name=replicate]] completed with the following parameters: [{}] and the following status: [FAILED] in 4s972ms
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Connection is already closed
Parent JobExecution is stopped, so passing message on to StepExecution
Step interrupted through StepExecution
Encountered interruption executing step live-reader in job live-reader : Job interrupted status detected.
Step: [live-reader] executed in 4s633ms
Parent JobExecution is stopped, so passing message on to StepExecution
Exception while closing step execution resources in step live-reader in job live-reader
Encountered interruption executing job: Job interrupted by step execution

I test it,and I'm ok
In my case ,No pwd, and versions are same. I use docker .
The command for example:
docker run -d --name=riot  fieldengineering/riot -h <IP_ADDRESS> -p 6382 --cluster replicate -h <IP_ADDRESS> -p 6385 --cluster --mode live --progress=log
The logs :
Listening  ? % [=                                        ] 0/? (0:00:00 / ?) ?/s
Scanning   0% [                                          ] 0/5 (0:00:00 / ?) ?/s
Scanning 100% [====================================] 5/5 (0:00:00 / 0:00:00) ?/s
Scanning 100% [====================================] 5/5 (0:00:00 / 0:00:00) ?/s
Listening  ? % [ =                           ] 1/? (0:00:36 / ?) .0/s | 0 queued    # THis one is the new key
The Keys on both sides are same。

My command looks like this


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2896

Questions ?
Please refer to the Backport tool documentation


Update model props in "deleting" event observer

Laravel Version: 5.8.37
PHP Version: 7.4.3
Database Driver & Version: sqlite

Description:
This might be not a bug, but a limitation and an expected behavior, but I didn't find it mentioned in docs.
namespace App\Observers;

use App\User;

class UserObserver
{
    public function deleting(User $user)
    {
        $user->status |= User::STATUS_DELETED;
    }
}

The model uses softDeletes, so it may look redundant while there's deleted_at property. However, I have a use case for this and I can imagine a case where I would want to change some other props on delete.
Should the UPDATE query (the one that sets deleted_at) after the event is fired include the status column? Would be nice. Note that I would not expect updating/updated event be invoked in this case.
Edit: Corrected method name in the code above from deleted to deleting.

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? We'll help you out and re-open this issue if so.
Thanks!

@driesvints Hello Dries,
I'm running the latest laravel and having the same issue.

PHP 8.3
Laravel v11.34.2
Database SQL Server 2019

To explain better, I am using the deleting event like so:
class WorkOrderObserver
{
    public function deleting(WorkOrder $workOrder): void
    {
        $workOrder->status = WorkOrderStatus::Deleted;
    }
}

Unfortunately, the status is not being updated when the model is persisted. I've verified the event is being hit by dumping/logging the model inside the method.
In any of the other ing events, I can update a property on the model before it's persisted. For example, I'm doing this with the restoring event and it's working. It's only the deleting event that this doesn't work. I'm trying to avoid doing a second database query to update the status when the model is soft-deleted.


Routing error on /review

When I go to the review page I get a routing error, I attached the full trace as an attachment.
I don't think this is supposed to be happening :p
full_trace.txt

That’s because you’re not a reviewer, so you can’t visit /review
app/controllers/application_controller.rb:62:in `verify_reviewer'

I think we should have something nicer and clearer here when we verify privileges.

@j-f1 [status-completed] I've added a nicer view for access-denied. b6b4a6cdf7c9ab47733bc700b2ed1ca2227dfba6


fn eval should follow the same output format with fn render

Part of #1557

Some considerations:

The package information shouldn't be printed if the directory is not a package.
The final statement Successfully executed x function(s)... is not necessary since eval always runs one function.
The output should be entirely hidden when the result resources are printed to stdout, like in --dry-run mode or in a function chain.


fix(types): correctly set type for AccessorKeyColumnDef#accessorKey

This PR includes:
Sets the correct type for AccessorKeyColumnDef#accessorKey. Currently with out this PR it doesn't give the correct auto complete, with this fix it does.

@Dev-CasperTheGhost I just tested this and your PR does fix the auto-complete when not using the columnHelper function. However there are now merge conflicts with it after a big type refactor. If you remake this by tomorrow, I'll review again.

@KevinVandy, merge conflicts are fixed :)


[FEATURE] Logging to testing logger

New feature request checklist

[x] I have updated go-smtp-mock to the latest version
[x] I have read the Contribution Guidelines
[x] I have read the documentation
[x] I have searched for existing GitHub issues

Feature description
Currently this package supports logging to stdout. Which works well, but I think inside unit test it would be even better if it would support logging to testing.Logf. Then it is easier to see chronological order of logging messages, when other parts of your unit test are using testing.Logf. They are also shown only if the test fails.
I think API could be an option to ConfigurationAttr, something like LogToTesting *testing.T and you would pass *testing.T instance to it.
Alternative would be that I could pass my own "logger" instance and then I could make my own adapter.

@mitar I'll take for develop this feature next week.


py3 unicode is not defined

Getting this error in make_alphabet_transformer on python 3.4
  File "/Users/tim/venvs/py3/lib/python3.4/site-packages/pepdata/reduced_alphabet.py", line 76, in make_alphabet_transformer
    if isinstance(reduced_alphabet, (str, unicode)):
NameError: name 'unicode' is not defined

Never mind, sorry. I seem to be using an old version of pepdata


[ogg_opus_player] Build in windows error

flutter doctor:
[√] Flutter (Channel stable, 3.0.1, on Microsoft Windows [版本 10.0.17763.2928], locale zh-CN)
[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.15)
[!] Android Studio (not installed)
[√] VS Code (version 1.67.2)
[√] Connected device (3 available)
[√] HTTP Host Availability

build error info:
严重性	代码	说明	项目	文件	行	禁止显示状态
错误	C1900	“P1”(第“20211014”版)和“P2”(第“20210202”版)之间 Il 不匹配	ogg_opus_player	D:\workspace\github\flutter-plugins-custom\packages\ogg_opus_player\example\build\windows\plugins\ogg_opus_player\shared\LINK	1

https://stackoverflow.com/questions/8959973/il-mismatch-between-p1-version-20080116-and-p2-version-20070207
The libs in [ogg_opus_player] are compiled by Visual Studio 2022, so it seems make the library can not compile on Visual Studio 2019.

https://stackoverflow.com/questions/8959973/il-mismatch-between-p1-version-20080116-and-p2-version-20070207
The libs in [ogg_opus_player] are compiled by Visual Studio 2022, so it seems make the library can not compile on Visual Studio 2019.

Ok.I compiled the libs using vs2019 and it can run.


chore (test/Lint): remove #align test

This breaks testing for #14887 but can't be automated with sed so we remove it manually.

bors d+


feat: implement RENode, which provides querying Pattern nodes like DOM

TODO

[ ] Add RENode document
[ ] Add test

This is interesting feature, but it is hard to make API as useful on TypeScript. I dispose this for now.


MRG: Speed up functions and tests

Various tweaks to speed tests and helper functions. Let's see if I broke anything.

Codecov Report

Merging #4322 into master will increase coverage by 1.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4322      +/-   ##
==========================================
+ Coverage   84.42%   86.06%   +1.63%
==========================================
  Files         346      346
  Lines       62897    62910      +13
  Branches     9672     9671       -1
==========================================
+ Hits        53099    54141    +1042
+ Misses       7118     6107    -1011
+ Partials     2680     2662      -18

Okay I'll stop here for now. If the CIs come back happy, ready for review/merge from my end.
I think there is a way to (greatly) speed up morph map computation using sklearn BallTree, but I'll do that in another PR.

besides LGTM

travis is not happy

Okay CIs appear to be coming back happy, can you look now @agramfort?

Travis appears to have sped back up (hooray!) but this still contains some nice testing speed boosts.

... and 2 of the 3 slowest tests are now Gamma-map and TF-MxNE if you feel like trying to speed those up:
https://travis-ci.org/mne-tools/mne-python/jobs/244540557#L3245

ok merge when you're done then
thanks a lot for taking a stab at this

Okay merging to save some time. Hopefully can make more progress at some point

thx !
I'll look gamma map and tf-mxne tests asap

The latest slow-list is here:
https://travis-ci.org/mne-tools/mne-python/jobs/245020880#L3230

any idea why test_read_write_epochs is so slow?

That function tests a ton of stuff. My guess is that it's actually an I/O bottleneck but I've never profiled those functions so maybe we're doing something unnecessarily slow


Fontawesome 5 icon names.

If we still want to use font awesome webfonts when we need to update some icon names.

I think keeping the webfont is fine. I will take a look at your branch in Texture later.

Obsolete.


Add EMAX Smart plug

This is a WB2S, I have added more info and pictures
orginal.bin.tar.gz
Found BK7231T config!
Switch/plug config

relay 1: pin P24
button 1: pin P10
Status LED: pin P26, inverted True
Power monitoring chip BL0937: CF/ELE=P6, CF1/VI=P7, SEL=P8
shunt resistor: 1 mΩ

Didn't take a look to find out why, but your dump is missing about 4k, but it does have storage, so it is enough to create a profile.  Unsure if this would be a valid dump to restore from or not.
Added as Emax 8774 Smart Plug v1.3.5


fix: more liberal regex on gdpr ssn mask; to support 2024 ssn

Description :sparkles:
Shared libraries' gdpr test has been failing since @mjturt  ssn upgrades. Loosen regex to support 2024 style on masking ssn.

API branch is deployed to platta: https://tet-pr2647.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr2647.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://tet-admin-ui-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://kesaseteli-pr2647.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-employer-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-handler-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-youth-pr2647.dev.hel.ninja :laughing::tada::tada::tada:

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2647.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://tet-youth-ui-pr2647.dev.hel.ninja :laughing::tada::tada::tada:


Improve README

Add info about:

[ ] channels
[ ] docker
[ ] badge

PLEASE provide more information about how to configure the server. Thanks.

Please add to the README file that, in the user's GitHub Releases section of their repository, they NEED to prefix their releases with a "v" character or squirrel-updates-server won't work.
Also, a note to the maintainer: This convention isn't necessarily standard. For example, look at the Atom Releases page: https://github.com/atom/atom
Perhaps squirrel-updates-server should be intelligent enough to look for both "#.#.#" AND "v#.#.#" in the user's repository and match whichever it finds? Or, alternatively, it could be a configurable setting in the conf.js file?


Output format

Very beautiful color picker. Unfortunately, it's not possible to choose output format. Can you return e.details.color.hex etc as possible values from lib?
Thanks

All your examples set value to css styles, but what if I need to store some format into database :-(
Looks like need to search for other color picker :-(

Very beautiful color picker. Unfortunately, it's not possible to choose output format. Can you return e.details.color.hex etc as possible values from lib?

This is useful and something ill add

All your examples set value to css styles, but what if I need to store some format into database :-(
Looks like need to search for other color picker :-(

What do you mean by this?
Like if you needed to send the color output to the database? If its this then yeah thats already possible. The example use the color picker to set css sytles, only as an example of how you can use it.
So to understand your need better could you expand?

It is all about array with output of different values (hex, hsla, rga etc.) I'm already solved my issue. I convert default hsla output to hex with external script, but better if it will be possible to choose output values from array in the next version.
p.s. Maybe you can add description to readme how to initialize everything with jQuery. I'm already met the problem that after html button code with event updated (from external ajax request, it is the same button, with the same id, but new one....) then need to add event again. With jQuery code it will be more simple. As I know jquery .on made this automatically and need to maintain less code.

It is all about array with output of different values (hex, hsla, rga etc.) I'm already solved my issue. I convert default hsla output to hex with external script, but better if it will be possible to choose output values from array in the next version.

Yes I'll add that feature in soon, most of the work is already there I just have passed the options to choose those different formats, so should be a quick add.

p.s. Maybe you can add description to readme how to initialize everything with jQuery. I'm already met the problem that after html button code with event updated (from external ajax request, it is the same button, with the same id, but new one....) then need to add event again. With jQuery code it will be more simple. As I know jquery .on made this automatically and need to maintain less code.

Not sure what there is to initialize with Jquery, unless you mean changing the color picker source code to be reduce/simplify code. If so, this picker wasn't created to be a JQuery component, it can be used with JQuery though and you can replace the event listeners with the JQuery equivalent, etc.
Also, I couldn't fully make sense of your issue, is it that you have to different buttons that that trigger the same request and you have to make a new button instance and create the same request again in your code? Maybe, you could expand on this so I can see if there are solution for it, or possible features that could be added to the color picker to overcome it.
Thanks

it can be used with JQuery though and you can replace the event listeners with the JQuery equivalent, etc.
I only suggest to add this jQuery equivalent to README page :+1:

is it that you have to different buttons that that trigger the same request and you have to make a new button instance and create the same request again in your code?

No. it's the same buttons. They have the same IDs. They are placed inside <form>. I update the code of <form> html from server side by request (buttons also updated), because of that they lose event listining binding. After this I must re-init everything related to color picker. I guess that with jQuery event .on equivalent it can work out of the box after html update, because jQuery will automatically re-bind everything, but I'm not sure.

it can be used with JQuery though and you can replace the event listeners with the JQuery equivalent, etc.

I only suggest to add this jQuery equivalent to README page

is it that you have to different buttons that that trigger the same request and you have to make a new button instance and create the same request again in your code?

No. it's the same buttons. They have the same IDs. They are placed inside <form>. I update the code of <form> html from server side by request (buttons also updated), because of that they lose event listining binding. After this I must re-init everything related to color picker. I guess that with jQuery event .on equivalent it can work out of the box after html update, because jQuery will automatically re-bind everything, but I'm not sure. It's not a big issue. More like thinking out loud.
Thanks!

Oh right I understand now. The the color picker saves the button as a node, so even if a button has the same ID after being updated the instance will not update to that button, which seems to be the issue your having. I'll have to do some testing to see if there is a way to solve this (ill check how the .on works too), but for now a re-init seems the be the only way around. Anyway, good insight to use cases for this, so Ill look into it.
Thanks

Thanks! You can also try to use it with zubr foundation (ccs+js from cdn). It also have 2 issues:

It's break little bit input field of hex (move it to the left). Not a problem really.
If used with zubr foundation modals, it opened under it. I solve this by closing and then reopening foundation dialog. Same. Not a problem.
I wrote it more for information. Really, it's not a problems.

Updated with the optional color output formats

@R-TEK ot works, need only to update readme and maybe add not only "hexa", but "hex" to object
thank you for update!

@evadogstar
Yes, I'll add the new information to the readme.
You said add a hex value too, rather than just a hexa. What is you reason for wanting this, just curious because ultimately, that value will provide the same color even in hexa format?
Either way I think I will add this, as well as a rgb and hsl (along side the existing rgba and hsla)


fix: $emit message when gridster loaded

I just added this with a direct commit.  Thank you!

thanks @danomatic


⚠ Bofrost.at has degraded performance

In e042212, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1064 ms

Resolved: Bofrost.at performance has improved in 16f1396.


Support Replicated 2.x

Tiny change to support Replicated 2. We have to use a path that is accessible to the replicated docker container. (We should come up with a better mechanism in the future instead of shoehorning things into Replicated data dirs.)

Ideally, we would be using the ImportSettingsFrom feature of https://www.replicated.com/docs/kb/developer-resources/automate-install/, but if this works, it works, and it's much less effort.

Turns out it'll take some AMI tweaks at a minimum to support ImportSettingsFrom, so will go ahead and merge this.


Example usage for OAuthWebViewController

Like everyone else I am trying to open the sign in process through a web view instead of Safari. This is the piece of code I have:
    if #available(iOS 9.0, *) {
        oauthswift.authorize_url_handler = SafariURLHandler(viewController: self)
    }
    else {
        let webView = OAuthWebViewController()
        oauthswift.authorize_url_handler = webView
    }

SafariURLHandler works fine but the OAuthWebViewController does not work I need to present the webvViewController both from the root view controller and some other view controller.
What is the proper implementation of OAuthWebViewController in my case? Thank you in advance.

version used?
message, log, error ? maybe #154
Did you try breakpoint into OAuthWebViewController, doHandle method ?

Ok yeah I know about that recursive code I used it before. I have the above lines on two places on of them being the root view controller. When I try it on the root view controller I am getting the black screen so maybe I am not adding the view to the hierarchy but I thought that was being done inside doHandle on this line:
UIApplication.sharedApplication().keyWindow?.rootViewController?.presentViewController(
self, animated: true, completion: nil)
I pulled the code through cocoaPods and oauthswift.version.shortVersion gives me 2.0. What else would you recommend me to add into this piece of code?
if #available(iOS 9.0, *) {
oauthswift.authorize_url_handler = SafariURLHandler(viewController: self)
}
else {
let webView = OAuthWebViewController()
oauthswift.authorize_url_handler = webView
}

There is no version 2.0, see https://github.com/OAuthSwift/OAuthSwift/releases
If you use cocoapod there is a PodFile.lock near PodFile with version used
Please update because that following code is old, previous 0.5.0
UIApplication.sharedApplication().keyWindow?.rootViewController?.presentViewController(

As per your advice, I used my own class like in the demo and I have updated my version to 0.5. It is working fine right now, thank you for your help.