Refactor mount/mode setting for local SSD RAID

The local SSD RAID solution is written in Ansible which will successfully handle re-creating the RAID array and mounting it in scenarios where the VM has been re-created and the contents of local SSD have been discared. The Slurm solutions do not re-run startup scripts after the first boot using a given persistent disk. During maintenance events, the persistent disk is retained while the local SSD disks are discarded. PR #3129 addressed re-creating, formatting and mounting the RAID array but left a gap in setting the mode of the mounted directory after power off/on cycles. This PR refactors mounting and mode-setting to resolve this gap.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cluster Toolkit Contribution guidelines #

Noting: PR-test-ml-a3-megagpu-slurm passed before squashing commits prior to merge.

Testing with
#!/bin/bash

set -ex
mountpoint /mnt/localssd
ls -lhd /mnt/localssd
cat /etc/enroot/enroot.conf

and
srun --container-image=alpine grep PRETTY /etc/os-release

both demonstrated end-to-end functionality of enroot on local SSD volumes on first-boot/reboot/power off-on/re-creation.


Change processing time

hi
how to Change processing time to prepare mp4 files?

Hi @msh13792,
Thanks for reaching out. I unfortunately did not understand your question. Could you be a little bit more specific?
Thanks in advance

i should explain when "export_presentation" was working on recorded video to prepare mp4 files that is consume more CPU of my server and it was bad effected on meeting that was opened on server ,i want to know that is a way to change time of processing "export_presentation" automatically for example on 1AM to 8AM of day ?
i hope you can understand exactly what i want.
Thank you for your attention

To reduce resource usage you can turn the SVGZ option on in the script and set THREADS to 1.
You could disable the presentation workflow entirely and only let it run from 1AM to 8AM with a cronjob.

Reducing the CHAT_CANVAS_SIZE to 320 will also help you out with the CPU load.

Closed. Please reopen if the cronjob suggestion did not fullfill your needs or submit it as a feature request.


 Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like, including relevant patches or source
A clear and concise description of what you want to happen.
Additional Notes
Add any other context or screenshots about the feature request here.

huh? 😂

Bruh pls change title to "Clear only the browsing history on exit", and put the rest on your previous  title to Additional Notes section


Unknown opcode: 7 with scalatest async testing

https://github.com/hsn10/scalajs-async-scalatest
run: sbt test
This bug is related to execution contexts, but it is only triggered when async test suite is invoked as nestedSuite. From investigation it seems it needs 2 different active ec to fail.
I have to do:
implicit override def executionContext = scala.concurrent.ExecutionContext.Implicits.global

because later I am using JS promises auto conversion to scala future.
import scala.scalajs.js.Thenable.Implicits._

and these conversions can't use user provided execution context. Not overriding it give error: future not finished but queue is empty.
Proposed fix add Execution context as implicit parameter to conversion functions, this is standard in scala.

Hi, thanks for your interest.
The conversions in js.Thenable.Implicits do not accept custom ExecutionContexts because they don't need an ExecutionContext at all. It's not like they're using a hard-coded one. They're not using any ExecutionContext.
So if they were taking an implicit EC, as you suggest, they would simply ignore it.

To me, it looks like a bug in ScalaTest. Or maybe some usage that you're doing of ScalaTest that is not supported?
In any case I don't think there's anything we can change in Scala.js for this.
If you still think that the conversions in js.Thenable are at fault, and that you could fix the problem with a custom EC given to them, I encourage you to copy-paste the conversion from https://github.com/scala-js/scala-js/blob/c72bf677d77472d8f9bb35bca217b5dcb8f7e731/library/src/main/scala/scala/scalajs/js/Thenable.scala#L45-L66, and adapt it until it works for you.

What helps is to use:
implicit override def executionContext = scala.scalajs.concurrent.JSExecutionContext.Implicits.runNow
inside of AsyncWordSpec

runNow is a fake EC. If using it helps, it means that some code somewhere is not actually ready to accept the fully asynchronous nature of Futures.

http://www.scalatest.org/user_guide/async_testing
On JavaScript, where single-threaded execution is the only possibility, the default execution context is scala.scalajs.concurrent.JSExecutionContext.Implicits.queue.
scalatest async testing and its execution context works as long you do not call JS code returning promise.

scalatest async testing and its execution context works as long you do not call JS code returning promise.

So ... it looks like a bug (or limitation) in ScalaTest, doesn't it?

I'm going to close this with the assumption that there's nothing actionable to do in this repo. Feel free to reopen if you have more evidence that there should be a fix in this repo.


Support loading Grok patterns from S3

Is your feature request related to a problem? Please describe.
Currently, user can configure Grok Processor with pattern_directories to load pattern files only from local file system.
processor:
  - grok:
      patterns_directories: ["path/to/patterns_folder", "path/to/extra_patterns_folder"]
      match:
        message: ["%{CUSTOM_PATTERN_FROM_FILE:my_pattern}"`

Describe the solution you'd like
Allow users to load the pattern directories from S3. This would allow specifying S3 URI in pattern_directories.
This change would use ListObjectsV2 API and require s3:ListBucket permission.
Additional context
This is similar to loading index template and ISM policy from S3: https://github.com/opensearch-project/data-prepper/issues/2120

@asifsmohammed , Should we support a directory? I tend to think that we should only allow for a pre-defined list of S3 objects to load from. I see that this is different from patterns_directories.

We will just allow list of objects from S3 through a new s3_patterns_files config option.


Rubocop 0.47.1

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

Updates rubocop to 0.47.1, because I keep getting editor warnings shouted at me since I ran gem update the other day and it's annoying 😅.

Thanks again @DomT4!

Thanks! My Atom plugin can get off my back every time I edit a brew file now 😄.


chore(master): release 1.1.66

:robot: I have created a release beep boop
1.1.66 (2023-09-05)
Miscellaneous

deps: update dependency orchestra/testbench to v8.10.1 (d06037f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-webhook-client/releases/tag/v1.1.66 :sunflower:


Enable dvr if hls stream stalls

Still waiting for event to merged into the next version of hlsjs. https://github.com/dailymotion/hls.js/commit/c061f1d66ba51484195f5c0d0402bbc6803ed8b5
This can be merged before this though without issues.
Tested with hlsjs master locally.
(Closes #770)

Actually don't merge this because it might not be needed if the html5_video refactor I'm working on works :P

I think this could be done slightly better by listening for buffering events instead (when #787 is merged). Then new hlsjs stalled event could be used to inform the html5_video playback that playback is stalled immediately instead of waiting for it to realise.


Publishing not working

Hey,
I got Python 3.5.2 here, on a ubuntu 16.04 and a rabbitpy of version 1.0.0.
When executing exactly the code from the example in "Mandatory Publishing"
http://rabbitpy.readthedocs.io/en/latest/examples/publisher_confirms.html
I got that error:
$ python3 publish_example.py

Traceback (most recent call last):
  File "publish_example.py", line 19, in <module>
    print('RabbitMQ indicates message publishing failure')
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/connection.py", line 149, in __exit__
    raise exc_val
  File "publish_example.py", line 19, in <module>
    print('RabbitMQ indicates message publishing failure')
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/channel.py", line 99, in __exit__
    raise exc_val
  File "publish_example.py", line 16, in <module>
    if message.publish('test_exchange', 'test-routing-key', mandatory=True):
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/message.py", line 288, in publish
    response = self.channel.wait_for_confirmation()
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/base.py", line 242, in wait_for_confirmation
    specification.Basic.Nack])
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/base.py", line 464, in _wait_on_frame
    self._check_for_rpc_request(value)
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/channel.py", line 271, in _check_for_rpc_request
    super(Channel, self)._check_for_rpc_request(value)
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/base.py", line 328, in _check_for_rpc_request
    self._on_remote_close(value)
  File "/usr/local/lib/python3.5/dist-packages/rabbitpy/base.py", line 380, in _on_remote_close
    raise exceptions.AMQP[value.reply_code](value)
rabbitpy.exceptions.AMQPNotFound: <pamqp.specification.Channel.Close object at 0x7ffa2f81a5a0>

I tried this example, because in the app I am building, publishing also doesn't work. As you can see, the broker is up and running, also the connection gets established nicely. But when it comes to find the proper exchange, a 404 is returned. I tried another URL without the trailing / for the vhost, resp. omitted the exchange, but neither worked out.
/usr/local/lib/python3.5/dist-packages/rabbitpy/base.py:380: AMQPNotFound
---------------------------------------------- Captured log -----------------------------------------------
base.py                    100 DEBUG    Connection setting state to 'Opening'
base.py                    100 DEBUG    IO setting state to 'Opening'
events.py                  132 DEBUG    Waiting for 3 seconds on event: Socket Connected
io.py                      532 DEBUG    Connecting to ('<IP_ADDRESS>', 5672)
base.py                    100 DEBUG    IO setting state to 'Open'
io.py                      400 DEBUG    Socket connected
connection.py              246 DEBUG    Adding channel 0 to io
base.py                    100 DEBUG    Channel0 setting state to 'Opening'
io.py                      235 DEBUG    Returning PollPoller
channel0.py                101 DEBUG    Received frame: 'Connection.Start'
channel0.py                242 DEBUG    Server b'version': b'3.6.5'
channel0.py                242 DEBUG    Server b'cluster_name': b'rabbit@a2930e58b427'
channel0.py                242 DEBUG    Server b'platform': b'Erlang/OTP'
channel0.py                242 DEBUG    Server b'capabilities': {b'per_consumer_qos': True, b'authentication_failure_close': True, b'consumer_cancel_notify': True, b'publisher_confirms': True, b'basic.nack': True, b'connection.blocked': True, b'direct_reply_to': True, b'consumer_priorities': True, b'exchange_exchange_bindings': True}
channel0.py                242 DEBUG    Server b'product': b'RabbitMQ'
channel0.py                242 DEBUG    Server b'copyright': b'Copyright (C) 2007-2016 Pivotal Software, Inc.'
channel0.py                242 DEBUG    Server b'information': b'Licensed under the MPL.  See http://www.rabbitmq.com/'
channel0.py                101 DEBUG    Received frame: 'Connection.Tune'
channel0.py                259 DEBUG    Heartbeat interval (server/client): 60/60
channel0.py                101 DEBUG    Received frame: 'Connection.OpenOk'
channel0.py                219 DEBUG    Connection opened
base.py                    100 DEBUG    Channel0 setting state to 'Open'
heartbeat.py                36 DEBUG    Heartbeat started, ensuring data is written at least every 30.00 seconds
base.py                    100 DEBUG    Connection setting state to 'Open'
endpoint.py                100 INFO     Established connection to host: rabbitmq, port: 5672
connection.py              246 DEBUG    Adding channel 1 to io
base.py                    100 DEBUG    Channel setting state to 'Opening'
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Channel.OpenOk object at 0x7f815dd24c48>
base.py                    100 DEBUG    Channel setting state to 'Open'
channel.py                 186 DEBUG    Channel #1 open
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Confirm.SelectOk object at 0x7f815dcabb70>
endpoint.py                111 INFO     Created channel
amqp_queue.py              384 DEBUG    Declaring Queue test_queue, durable=False, passive=False, exclusive=False, auto_delete=False, arguments={}
base.py                     37 DEBUG    Issuing RPC to RabbitMQ: <pamqp.specification.Queue.Declare object at 0x7f815dc86e18>
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Queue.DeclareOk object at 0x7f815dcb2b88>
endpoint.py                139 INFO     Declared queue with name: test_queue
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Basic.ConsumeOk object at 0x7f815dd24cd8>
base.py                    100 DEBUG    Connection setting state to 'Opening'
base.py                    100 DEBUG    IO setting state to 'Opening'
events.py                  132 DEBUG    Waiting for 3 seconds on event: Socket Connected
io.py                      532 DEBUG    Connecting to ('<IP_ADDRESS>', 5672)
base.py                    100 DEBUG    IO setting state to 'Open'
io.py                      400 DEBUG    Socket connected
io.py                      235 DEBUG    Returning PollPoller
connection.py              246 DEBUG    Adding channel 0 to io
base.py                    100 DEBUG    Channel0 setting state to 'Opening'
channel0.py                101 DEBUG    Received frame: 'Connection.Start'
channel0.py                242 DEBUG    Server b'version': b'3.6.5'
channel0.py                242 DEBUG    Server b'cluster_name': b'rabbit@a2930e58b427'
channel0.py                242 DEBUG    Server b'platform': b'Erlang/OTP'
channel0.py                242 DEBUG    Server b'capabilities': {b'per_consumer_qos': True, b'authentication_failure_close': True, b'consumer_cancel_notify': True, b'publisher_confirms': True, b'basic.nack': True, b'connection.blocked': True, b'direct_reply_to': True, b'consumer_priorities': True, b'exchange_exchange_bindings': True}
channel0.py                242 DEBUG    Server b'product': b'RabbitMQ'
channel0.py                242 DEBUG    Server b'copyright': b'Copyright (C) 2007-2016 Pivotal Software, Inc.'
channel0.py                242 DEBUG    Server b'information': b'Licensed under the MPL.  See http://www.rabbitmq.com/'
channel0.py                101 DEBUG    Received frame: 'Connection.Tune'
channel0.py                259 DEBUG    Heartbeat interval (server/client): 60/60
channel0.py                101 DEBUG    Received frame: 'Connection.OpenOk'
channel0.py                219 DEBUG    Connection opened
base.py                    100 DEBUG    Channel0 setting state to 'Open'
heartbeat.py                36 DEBUG    Heartbeat started, ensuring data is written at least every 30.00 seconds
base.py                    100 DEBUG    Connection setting state to 'Open'
endpoint.py                100 INFO     Established connection to host: rabbitmq, port: 5672
connection.py              246 DEBUG    Adding channel 1 to io
base.py                    100 DEBUG    Channel setting state to 'Opening'
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Channel.OpenOk object at 0x7f815dd24f18>
base.py                    100 DEBUG    Channel setting state to 'Open'
channel.py                 186 DEBUG    Channel #1 open
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Confirm.SelectOk object at 0x7f815dcabba8>
endpoint.py                111 INFO     Created channel
channel.py                 270 DEBUG    Checking for RPC request: <pamqp.specification.Channel.Close object at 0x7f815c608f30>
base.py                    327 DEBUG    Channel closed
base.py                    100 DEBUG    Channel setting state to 'Remotely Closed'
base.py                    379 ERROR    Received remote close (404): b"NOT_FOUND - no exchange 'test-exchange' in vhost '/'"

This is how I open a connection:
        self._connection = rabbitpy.Connection('amqp://guest:guest@localhost:5672/%2F')

After that the channels/ connection are closed. I am sure, I am missing something and really could use a nudge in the right direction.
Thanks in advance :-)

This comes a bit late, but the error states that the defined exchange is unknown. Unfortunately this reply does not bubble up and rabbitpy quits with this (not helpful) AMQPNotFound Exception.

Going to close this, but the AMQP NotFoundException is straight out of the protocol and the response from RabbitMQ. I guess I could create a bunch of new exceptions inspecting the not found exception for what was not found, but that seems like a fair amount of extra code with little value.


[zh] Sync command-line-tools-reference/kube-controller-manager.md

Sync with en text:
content/zh-cn/docs/reference/command-line-tools-reference/kube-controller-manager.md

See preview please.

/approve


Add support for modin dataframes

Currently only in central data loading mode. Integration with distributed mode would require more access to private modin functions - we can look into this at another time.
This PR also adds (and fixes) compatibility tests for the latest ray release when some dependencies are not installed. E.g. if Tune or Modin are not installed, certain tests and examples should still run.

I updated the docstrings. As for the example, we could do that, but we might want to wait until we have support for distributed loading. Right now it would be just a duplication of passing a pandas dataframe/series, and even the data distribution would be the same.


Implement ACI driver

It should be fairly straightforward to use the Azure Go SDK and create a Container Instance executor and follow the logs until the container exits.

See https://github.com/deislabs/duffle-aci-driver


repeat.fors over Maps don't update on element change

Repro:
http://plnkr.co/edit/MqKNE4QdjMO5lAkJCoqN?p=preview
If you have a Map over which you do a repeat.for, changes to the contents of the Map do not appear in the repeat.
The repeat can be forced to refresh by wrapping it in a container with an if.bind and toggling the condition off and on (with a 0ms timeout).

Fixed in https://github.com/aurelia/templating-resources/commit/7f245ce3b490fa82cae20103281b665a07cf3eb2.


How to check sanity of a bundle when user uses http/https

As part of #3277 we are adding support to have http/https support for -b option and  https://github.com/code-ready/crc/pull/3319#pullrequestreview-1086636250 comment deserve an issue and plan to solve it or ignore it.
2 different scenario comes to my mind

Advance user who create the bundle using snc and upload it to file server and use it with crc.
Normal user or an IT admin download the released bundle and upload it local file server and tell dev/CI to use this location for crc.

Either we mandate that each bundle they upload should have respective sha256sum file like crc_<hypervisor>.4.11.1.crcbundle.sha256sum and uploaded along side bundle and we fetch it during bundle download. Or we will add config option to provide bundle sha256sum, or something else...?

The scenario I would focus on at the moment is not listed, it is crc start --bundle https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/bundles/openshift/4.11.0/crc_libvirt_4.11.1_amd64.crcbundle

@cfergeau We are only going to release 1-2 OCP bundle to mirror and shifting to quay https://github.com/code-ready/crc/issues/3311#issuecomment-1225227289 for OCP bundles also. So should we add code only for mirror sha256sum? Also as soon as we expose the option how do we know user are not using different fileserver location. I am already anticipating for CI usecase they might do that same as registry mirror.

should we add code only for mirror sha256sum?

The problem is that you can't trust a sha256sum you downloaded from the same location as the bundle, it could have been modified at the same time as the bundle was hacked. This is why we had to use signatures when putting the bundles on quay rather than only a sha256sum.

https://github.com/crc-org/crc/issues/3493 is related to this.


Use "en" as default locale for stories

Since all code and communication on github is in english, it makes sense to use english by default.
Also this prevents annoying error messages in the console about missing translations.

Also this prevents annoying error messages in the console about missing translations.
:clap:


Making internal requests using app()->handle() will stop Session from persisting

Laravel Version: 7.4.4
PHP Version: 7.2.5
Database Driver & Version: 10.4.11-MariaDB

Description:
If you make internal requests using app()->handle() no changes you make to the Session will persist anymore.
Steps To Reproduce:

Make an invokable controller with the code below and refresh it a couple of times.
Now change true to false in the if-statement.
Now the session will start persisting.

public function __invoke(Request $request)
{
    var_dump($request->session()->get('test'));     // null; no matter how many times your refresh, unless you change if statement's true to false...
    $request->session()->put('test1', 123);
    var_dump($request->session()->get('test'));     // 123;

    if (true) {     // change this to false and test will now start persisting to 123
        var_dump(app()->handle(\Request::create('/', 'post'))->getContent());
    }

    return;
}

Subrequests are a Symfony thing. Laravel does not official support them (as you can see there is nothing about them in the documentation) so it's no wonder that some things don't work as you'd expect when you use them.

Yeah sub requests are not really an officially supported Laravel thing as I consider them essentially an anti-pattern.


mgmt, fix ProviderRegistrationPolicy

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

@XiaofeiCao
It might also solve this error (one of older bug on you)
java.lang.IllegalArgumentException: The provided context does not contain serialized PollingState.

	at com.azure.core.management@1.8.1/com.azure.core.management.implementation.polling.PollingState.from(PollingState.java:117)
	at com.azure.core.management@1.8.1/com.azure.core.management.implementation.polling.PollOperation.lambda$pollFunction$1(PollOperation.java:53)


Failed extracting integrated utils when path to conty.sh isn't provided in command

I put my conty.sh in ~/.local/bin so that I could just call it with a conty.sh command in terminal. After the latest update, though, doing so would result in the following error:
The integrated utils were not extracted!
Perhaps something is wrong with the integrated utils.tar.gz.

However, my .desktop shortcuts still works, and after trying a few things, it seems that not providing conty.sh the path towards its location is the issue. So /home/fenglengshun/.local/bin/conty.sh, ~/.local/bin/conty.sh, $HOME/.local/bin/conty.sh all works, it's just when I try conty.sh it doesn't (even though which conty.sh gives /home/fenglengshun/.local/bin/conty.sh).

Hmm, interesting, i have this issue too. I'll try to figure out why it happens and fix it.

The issue should be fixed now.


add -experimental to enable rescheduling

Signed-off-by: Victor Vieux<EMAIL_ADDRESS>

ping @docker/swarm-maintainers what do you think of this ?

@docker/swarm-maintainers So the context is that I expressed my concerns for #1624 because I though that adding experimental on the restart flag was an issue when we'll change the flag back when it's out of experimental (for example users scripting their deployments, etc. this would be a breaking change).
With this change it's actually a flag on the Manager which I think is better because not breaking existing scripts and deployments.

I'll add Experimental: true in the Info API response once this one gets merged (if it does) because it required yet another godep update.

@abronan actually I put the flag on swarm itself, not the manager, so if one day we have experimental features on join on list, it will make things easier :)

@vieux even better imho :+1:

@vieux There is conflict please rebase.

@dongluochen done. sometime I'm disappointed by git, this was was a no brainer, it could have resolved it.

LGTM.

LGTM

docs LGTM


[material-ui][Select] Improve a11y by adding combobox role and aria-controls attribute

Resolves: #35586

[x] I have followed (at least) the PR section of the contributing guide.

generate a unique id for the aria-controls attribute

@DiegoAndai thanks for your feedback. I am very new to this repo and I want to clarify somethings here:

what do you mean by "Native Select component"? which other components should I add the attributes to?
regarding the id, I noticed there is already an id assigned to Menu component, and aria-controls should "Identifies the element that serves as the popup" which in this case is the Menu

@xulingzhihou thank you for taking an interest in contributing to Material UI 😊

what do you mean by "Native Select component"? which other components should I add the attributes to?

Sorry, I got confused. Don't consider my Native Select component comment 😅 I confused the SelectNativeInput here with NativeSelectInput, another component we use to render a native browser select.

regarding the id, I noticed there is already an id assigned to Menu component

The aria-controls ID should be the ID of the listbox element, and here we're referencing the menu root:

Finally, I think the combobox role and aria-controls properties should go to the element that right now has an incorrect "button" role. For comparison, look at Base UI's Select.
I don't know why we have the hidden input 🤔
@mui/core, does anyone know the use of this element?

does anyone know the use of this element?

Form auto-fill support

@xulingzhihou let me know if you need help with the failing tests

Hey @xulingzhihou, is this ready for review? 😊
Could you provide an example with the before and after to make this review easier? To do so, you can provide the same example in these different environments:

Latest released version: https://codesandbox.io/s/material-ui-issue-latest-s2dsx
Build for this PR: https://codesandbox.io/s/mui-issue-latest-f4wfn7

This should allow us to see the correct role and aria-controls attribute being applied. It would be perfect if you could do so with all components being affected (Select, TextField, TablePagination).

Hey @xulingzhihou, is this ready for review? 😊
Could you provide an example with the before and after to make this review easier? To do so, you can provide the same example in these different environments:

Latest released version: https://codesandbox.io/s/material-ui-issue-latest-s2dsx
Build for this PR: https://codesandbox.io/s/mui-issue-latest-f4wfn7

This should allow us to see the correct role and aria-controls attribute being applied. It would be perfect if you could do so with all components being affected (Select, TextField, TablePagination).

@DiegoAndai  yes it is ready for review!
Here are the examples requested:

Latest released version:  https://codesandbox.io/s/jovial-wildflower-xttyx6?file=/src/App.tsx:0-1384
Build for this PR: https://codesandbox.io/s/mui-issue-latest-forked-jq9yg9

Ready to merge 🎉 Great work 🙌🏼 I'll merge as soon as the CI passes

Thank you for helping me with my first mui pr @DiegoAndai !!


Patch plugin to bump  containered version to v1.7.11

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Question: How to show the svg image in its native size?

Hello!
I have a simple svg image
<svg
   xmlns="http://www.w3.org/2000/svg"
   width="20"
   height="20"
   version="1.1">

  <rect rx="0" ry="0" y="0" x="0" height="20" width="20" style="fill:red" />
</svg>

When I set the Image.Stretch property to None I expect the image size will be the same as svg size (20x20).
<Image x:Name="image1" Source="MyImage.svg" Stretch="None" HorizontalAlignment="Center" erticalAlignment="Center"/>
But actually the image ocupies the entire window area.
Setting Width="20" and Height="20" solve this. But in my scenario I do not know the svg image size and I dont want to parse the svg file to get the size.

@BorzillaR what are the layout properties of the image? I think Horizontal alignment = stretch could cause this behavior as well.

@StephenLPeters, you are right.
I tried to set different values for Image.HorizontalAlignment/VerticalAlignment/Stretch properties but without success. The image still has a large size.
For more clarity, I create an image with the one red rectangle inside and put it into the green border.
The svg image

Xaml

Then I set the different properti values and see the results.
None of my experiments ended with success.
I also noticed that the svg content is drawn in size 20x20 as I want, but the image is still large.


ondataavailable called twice. Only first file is proper, others are corrupted or too small

I want to record local and remote stream at the interval of 2 seconds and upload it to the server with Ajax. But the problem is, the method ondataavailable is called twice so the same video is uploaded to the server twice. The first video is playable and proper, while the rest of the videos are either corrupted or very small (less than one second). The size of all the videos is almost the same!
This is my code,
This is how I get the local stream
navigator.mediaDevices.getUserMedia({         video: false,         audio: true     }).then(function (myStream) {         localStream = myStream;         localStream.getTracks().forEach(function (track) {             yourConn.addTrack(track, localStream);         });     }).catch(function (error) {         streamAdded = false;         console.warn('Could not detect microphone');         return false;     });
This is how I perform recording
`yourConn.ontrack = function (e) {
remoteVideo.srcObject = e.streams[0];
   let recorder = RecordRTC([localStream, e.streams[0]], {
        mimeType: 'video/webm;codecs=h264',
        type: 'video',
        timeSlice: 5000,
        ondataavailable: function(blob) {
            uploadBlob(blob);
        },
    });

    recorder.startRecording();

}`
uploadBlob function
` var mp4File = new File([blob], getFileName('mp4'), {
type: 'video/mp4'
});
var formData = new FormData();
formData.append('recorded_file', mp4File);

$.ajax({
    url: myURL,
    data: formData,
    cache: false,
    contentType: false,
    processData: false,
    type: 'POST',
    success: function (response) {
        console.log(response);
    }
});`

I've tried with 5 seconds of the interval but still no luck!

I also have this problem！

Please find details about this issue here: https://stackoverflow.com/questions/57786036/recordrtc-ondataavailable-called-twice-only-first-file-is-proper-others-are-c


EF generates very unclear error message in case too generic key types in M:M relationship

I have many-to-many relationship entity that accidentally got property of type object. This happened by accident — during automatic creation of the property by Visual Studio. Later that property was set as a key by FluentAPI.
During start-up my application ensures that database created, and as soon it reaches that place — following exception fired:
Exception message: The property 'Sprint.TempId' is of type 'object' which is not supported by current database provider. Either change the property CLR type or ignore the property using the '[NotMapped]' attribute or by using 'EntityTypeBuilder.Ignore' in 'OnModelCreating'.
Stack trace:    at Microsoft.EntityFrameworkCore.Metadata.Conventions.Internal.PropertyMappingValidationConvention.Apply(InternalModelBuilder modelBuilder)
   at Microsoft.EntityFrameworkCore.Metadata.Conventions.Internal.ConventionDispatcher.ImmediateConventionScope.OnModelBuilt(InternalModelBuilder modelBuilder)
   at Microsoft.EntityFrameworkCore.Metadata.Conventions.Internal.ConventionDispatcher.OnModelBuilt(InternalModelBuilder modelBuilder)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.Model.Validate()
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalModelBuilder.Validate()
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.CreateModel(DbContext context, IConventionSetBuilder conventionSetBuilder, IModelValidator validator)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.<>c__DisplayClass5_0.<GetModel>b__0(Object k)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.GetModel(DbContext context, IConventionSetBuilder conventionSetBuilder, IModelValidator validator)
   at Microsoft.EntityFrameworkCore.Internal.DbContextServices.CreateModel()
   at Microsoft.EntityFrameworkCore.Internal.DbContextServices.get_Model()
   at Microsoft.EntityFrameworkCore.Infrastructure.EntityFrameworkServicesBuilder.<>c.<TryAddCoreServices>b__7_1(IServiceProvider p)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, ServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.<>c__DisplayClass22_0.<RealizeService>b__0(ServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
   at Microsoft.EntityFrameworkCore.DbContext.get_InternalServiceProvider()
   at Microsoft.EntityFrameworkCore.DbContext.Microsoft.EntityFrameworkCore.Infrastructure.IInfrastructure<System.IServiceProvider>.get_Instance()
   at Microsoft.EntityFrameworkCore.Infrastructure.DatabaseFacade.Microsoft.EntityFrameworkCore.Infrastructure.IInfrastructure<System.IServiceProvider>.get_Instance()
   at Microsoft.EntityFrameworkCore.Infrastructure.AccessorExtensions.GetService[TService](IInfrastructure`1 accessor)
   at Microsoft.EntityFrameworkCore.Infrastructure.DatabaseFacade.get_DatabaseCreator()
   at Microsoft.EntityFrameworkCore.Infrastructure.DatabaseFacade.EnsureCreated()
   at Web.Startup.ConfigureServices(IServiceCollection services)

Steps to reproduce

Create 2 entities. In my case Issue and Sprint;
Create N:N relation entity. In my case IssueSprint;
Set type of a property to object. In my case SprintId;
Use that property as key by FluentAPI;
Try to create database;

From N:N relation entity:
public class IssueSprint
    {
        #region Public Constructors

        public IssueSprint(Issue issue, Sprint sprint)
        {
            Issue = issue;
            IssueId = issue.Id;

            Sprint = sprint;
            SprintId = sprint.Id;
        }

        #endregion Public Constructors

        #region Public Properties

        public Issue Issue
        {
            get;
            private set;
        }

        public string IssueId
        {
            get;
            private set;
        }

        public Sprint Sprint
        {
            get;
            private set;
        }

        public object SprintId  // <-- note generic type `object`. It should be `string` as for `IssueId`
        {
            get;
            private set;
        }

        #endregion Public Properties

        #region Public Methods

        public override string ToString()
        {
            return $"{IssueId} <-> {SprintId}";
        }

        #endregion Public Methods
    }

From DbContext.cs:
        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<IssueSprint>()
                .HasKey(record => new { record.IssueId, record.SprintId });

            // 1:N connection from relation entity to issue
            modelBuilder.Entity<IssueSprint>()
                .HasOne(relation => relation.Issue)
                .WithMany(issue => issue.Sprints)
                .HasForeignKey(relation => relation.IssueId);

            // 1:N connection from relation entity to sprint
            modelBuilder.Entity<IssueSprint>()
                .HasOne(relation => relation.Sprint)
                .WithMany(sprint => sprint.Issues)
                .HasForeignKey(relation => relation.SprintId);

            base.OnModelCreating(modelBuilder);
        }

From Startup.cs:
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddMvc();

            using (var context = new DbContext())
            {
                context.Database.EnsureCreated();
            }
        }

Problem: Error message tells about problem with Sprint.TempId field. Which does not exist anywhere. While in reality IssueSprint.SprintId is the main reason of that exception. Switching type from object to less generic type (string in my case) has fixed the issue.
Although just by reading this error message it is almost impossible to find real cause.
I believe error message should be updated to point user to correct location in the code, that triggers the issue.
Further technical details
EF Core version: 2.0.0
Database Provider: Microsoft.EntityFrameworkCore.Sqlite
Operating system: Windows 10 x64
IDE: Visual Studio 2017

Note: We would throw for object property in first entity type we encounter (perhaps alphabetically).

@shytikov I was unable to reproduce this using the code below--it correctly throws, "The property 'IssueSprint.SprintId' is of type 'object' which is not supported by current database provider. Either change the property CLR type or ignore the property using the '[NotMapped]' attribute or by using 'EntityTypeBuilder.Ignore' in 'OnModelCreating'."
There is probably something different in your entity types that makes it throw for "Sprint.TempId". Can you update the repro code below so that it exhibits the behavior you are seeing?
public class Issue
{
    public string Id { get; set; }

    public ICollection<IssueSprint> Sprints { get; set; }
}

public class Sprint
{
    public string Id { get; set; }

    public ICollection<IssueSprint> Issues { get; set; }
}

public class IssueSprint
{
    public IssueSprint(Issue issue, Sprint sprint)
    {
        Issue = issue;
        IssueId = issue.Id;

        Sprint = sprint;
        SprintId = sprint.Id;
    }

    public Issue Issue
    {
        get;
        private set;
    }

    public string IssueId
    {
        get;
        private set;
    }

    public Sprint Sprint
    {
        get;
        private set;
    }

    public object SprintId  // <-- note generic type `object`. It should be `string` as for `IssueId`
    {
        get;
        private set;
    }

    public override string ToString()
    {
        return $"{IssueId} <-> {SprintId}";
    }
}

public class TestDbContext : DbContext
{
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
        optionsBuilder.UseSqlServer(
            @"Server=(localdb)\mssqllocaldb;Database=Test;Trusted_Connection=True;ConnectRetryCount=0");
    }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<IssueSprint>()
            .HasKey(record => new { record.IssueId, record.SprintId });

        // 1:N connection from relation entity to issue
        modelBuilder.Entity<IssueSprint>()
            .HasOne(relation => relation.Issue)
            .WithMany(issue => issue.Sprints)
            .HasForeignKey(relation => relation.IssueId);

        // 1:N connection from relation entity to sprint
        modelBuilder.Entity<IssueSprint>()
            .HasOne(relation => relation.Sprint)
            .WithMany(sprint => sprint.Issues)
            .HasForeignKey(relation => relation.SprintId);
    }
}

public class Program
{
    public static void Main()
    {
        using (var context = new TestDbContext())
        {
            context.Database.EnsureDeleted();
            context.Database.EnsureCreated();
        }
    }
}

Maybe it's an issue on specific provider implementation. I was able to catch this exception for SQLite, I haven't tried for SQL Server
        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlite("Data Source=test.sqlite");
        }

@shytikov As @smitpatel pointed out, there is an order dependency--I was able to repro just by changing the name IssueSprint to SprintIssue. So no need to dig further to get it to repro on your end--thanks for filing the issue!

We should validate explicit configuration and non-shadow properties first

Seeing this error in 2.1 for configuring a join table entity for a many-to-many relationship using Pomelos MySQL connector.
Was there eventually a fix for this?

@douglasg14b Your scenario is different from this bug. A key can only contain primitive properties:
modelBuilder.Entity<TransactionTagsEntity>()
    .HasKey(c => new { c.TagId, c.TransactionId });

ohhhh, I see. That's actually a fault of my own then, that should have been the TransactionId. Thanks for catching that.
Keep doing great things!

Getting this error trying to use a byte[] as part 2 of a primary key. Any database will allow a byte[] (blob) to be part of a primary key, why does this error show up for that? Very odd...

@jjxtra If you are getting this error in v2.2.0 or higher please file a new issue with a small repro project

It was due to lack of get/set on the field, maybe it would be helpful to add that as a possible resolution in the error message.


Add the ability to accept an array as the second parameter in RpcRouter methods

Now RpcRouter allows you to pass only a string as the second parameter:
use AvtoDev\JsonRPC\RpcRouter;

RpcRouter::on('please_sum_array_values', 'SomeController@sum');
RpcRouter::on('show_full_request', 'SomeController@showInfo');

The original Laravel router can also take an array as the second parameter.
Please add the ability to accept an array as the second parameter in RpcRouter methods, like:
use AvtoDev\JsonRPC\RpcRouter;

RpcRouter::on('please_sum_array_values', [SomeController::class, 'sum']);
RpcRouter::on('show_full_request', [SomeController::class, 'showInfo']);

@gomzyakov Is issue still actual ? If so, I can help with making a PR.

@shirokovnv
No one has had a need for the feature mentioned in almost 2 years. I think the issue can be closed)


Document how the RelayHub is instantiated locally

It's not obvious where and how the RelayHub gets deployed locally. I know that it's always located at 0xD216153c06E857cD7f72665E0aF1d7D82172F494, but it'd be great to have more details about it.

Hey @PaulRBerg[
Some details were omitted on purpose to simplify GSN tutorial. RelayHub is deployed during fund-recipient command which deploys RelayHub if not present.
gsn-helpers is a great way to learn more. The repo has methods for developing and testing GSN related stuff locally. Check it out to learn more.

I forked the repo and added the explanation in README before reading your comment. Sorry! Feel free to ignore the PR.

Technically speaking you don't need to deploy it ever explicitly. It is always deployed using fund-recipient but if you want you can 😄

Yes, so this silent deploy is what made me do the PR.
Bottom line, I may be pedantic. But the reason I want to understanding the behaviour of the RelayHub locally is that I'll (probably) write tests that will touch it somehow.


A transformer imported unknown package "drudge" (in "package:drudge/drudge.dart").

When you "pub get" in the tools package, which running the "flutter" tool does automatically, you get this message now.

I fixed this.


Mobile experience is terrible

The mobile experience of dpaste.de is terrible at the moment. We should be at least give a basic form and good viewing experience for snippets.

ouch

This is fixed. ❤ CSS Grid.


Update MacOS ventura to 13.7

Fixes #34

@MatthewCroughan It looks like the build was stopped, ti says FatalError {fatalErrorMessage = "user interrupt"} (worker: ExitFailure 1). Did you manually stop it?

@aciceri the CI machine is having a bad day, I have been kicking it a bunch. Have never been able to debug whether it's the disk or the memory, or even the CPU.

Yeah, the CI machine is experiencing hardware failure, but I know it works so I'll just merge it for now, and later on I'll fix the CI box.

@aciceri Actually, it looks like they updated the product version string from 13.6 to 13.7 in this release, which the VM test caught, so I'm updating that now.

You mean the repeatibility test? I cannot find where it looks for the product version.
Anyway glad you figured it out!

@aciceri It's defined here
https://github.com/MatthewCroughan/NixThePlanet/blob/2f622af217807da78e44a5a15f620743dac57f46/makeDarwinImage/vm-test.nix#L22-L41


Optimize MemoryIOReader & MemoryIOWriter

Structure MemoryIOReader and MemoryIOWriter are used to serialize / deserialize knowhere index binary.
We can enhance them in many aspects:

file name should be renamed to memory_io.cpp and memory_io.h
rename struct field to "rp_" and "data_"
add constructor for MemoryIOReader
add new interface data() and tellg() to access struct field

/close


STORM-1533: IntegerValidator for metric consumer parallelism hint

Please revert the pom changes. Other than that, +1

Thanks for review @knusbaum . This PR has fix for STORM-1533 and STORM-1534. Since commits have the individual JIRA ids attached, I have sent the fix in same PR.

+1 looks good to me.

Thanks @revans2 - can you also merge this PR? This affects 1.x release so it should be backported as well.


⚠ TechNews 科技新報 has degraded performance

In d0fb7a7, TechNews 科技新報 (https://technews.tw/) experienced degraded performance:

HTTP code: 200
Response time: 1497 ms

Resolved: TechNews 科技新報 performance has improved in 04893be.


ConnectWithManagedIdentity API throws AzureServiceTokenProviderException when running in .Net Core Azure Service Fabric microservice

Actual:
Calling ConnectWithManagedIdentity throws AzureServiceTokenProviderException when hosted in a stateful Service Fabric .Net Core microservice.
Expected:
Calling ConnectWithManagedIdentity within Service Fabric .Net Core microservices (both stateless and stateful) is fully supported. The ConnectWithManagedIdentity API should integrate with the fabric:/System/ManagedIdentityTokenService Service.
Example code:

Exception:
'fabric:/ServiceFabric.DataProtection/DataProtectionService' reported Error for property 'AppConfigurationHealth'.
Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProviderException: Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried the following 4 methods to get an access token, but none of them worked.
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Managed Service Identity. Access token could not be acquired. MSI ResponseCode: BadRequest, Response: {"error":{"correlationId":"93de0137-6a21-490a-827b-ac45c0bad929","code":"InvalidApiVersion","message":"The api-version '2017-09-01' is not supported. Supported version is '2019-07-01-preview'."}}
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Visual Studio. Access token could not be acquired. Visual Studio Token provider file not found at "C:\Windows\system32\config\systemprofile\AppData\Local.IdentityService\AzureServiceAuth\tokenprovider.json"
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Azure CLI. Access token could not be acquired. 'az' is not recognized as an internal or external command,
operable program or batch file.
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: https://login.microsoftonline.com/common. Exception Message: Tried to get token using Active Directory Integrated Authentication. Access token could not be acquired. get_user_name_failed: Failed to get user nameInner Exception : No mapping between account names and security IDs was done
at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__16.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.AppConfiguration.ManagedIdentityConnector.ManagedIdentityConnector.d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.AppConfiguration.ManagedIdentityConnector.AzconfigClientFactory.d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationOptions.ConnectWithManagedIdentity(String endpoint)
at AspNetCore.DataProtection.ServiceFabric.DataProtectionService.<>c.b__5_0(AzureAppConfigurationOptions options) in C:\Projects\AspNetCore.DataProtection.ServiceFabric\AspNetCore.DataProtection.ServiceFabric\DataProtectionService.cs:line 51
at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationSource.<>c__DisplayClass2_0.<.ctor>b__0()
at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationSource.Build(IConfigurationBuilder builder)
at Microsoft.Extensions.Configuration.ConfigurationBuilder.Build()
at AspNetCore.DataProtection.ServiceFabric.Dat [Truncated]
Library versions:
Microsoft.Azure.AppConfiguration.AspNetCore" Version="2.0.0-preview-009470001-12"
Microsoft.ServiceFabric" Version="6.5.664"
Microsoft.ServiceFabric.Services" Version="3.4.664"
Microsoft.ServiceFabric.Services.Remoting" Version="3.4.664"
Links / Related:
#143
#100

Hi @MedAnd, I was not aware of the support of managed identity from service fabric according to this, but after a quick search, I found service fabric just had a preview of managed identity support. Just to confirm... is this the same document you followed to enable the managed identity in service fabric? Did you get the managed identity working with Azure services other than App Configuration? Looks like service fabric can only support new deployment for managed identity at this point. Is this the case for you?

The exception you linked has an interesting piece: "The api-version '2017-09-01' is not supported. Supported version is '2019-07-01-preview'." It looks like the service fabric managed identity support is using a different api version. All of the msi token services are supposed to be able to be used for msi so will have to figure out where the disconnect is.

Should I raise a Service Fabric support ticket, GitHub issue etc or will you guys coordinate?

It sounds like service fabric implementation is missing an api version to me. So it may be faster if you open a support ticket for Service Fabric.

@MedAnd we're also going to coordinate on our side to see if we can figure it out.

Doing some research I've come across similar issues connecting to Key Vault... not sure if related?

Lesson #1: pass “RunAs=App;” in the connectionString parameter  of AzureServiceTokenProvider. This way it will not try different modes to obtain a token, and the exception is a bit better.

https://luisfsgoncalves.wordpress.com/2018/09/06/asp-net-core-on-azure-service-fabric-accessing-key-vault-with-managed-identities-and-the-errors-on-the-token-endpoint/

I think I may have found out what the issue is. Adding a reference to this NuGet package may resolve the issue: "Microsoft.Azure.Services.AppAuthentication" Version="1.3.1". It will take me a bit to be able to spend up a repro environment to verify this.

Will test below as I've got the environment:

Lesson #2: install/update the latest version of Microsoft.Azure.Services.AppAuthentication. The aforementioned package with the configuration extensions doesn’t depend on the latest version of this one. It happens that there’s an hard-coded URL of the endpoint that is used to get the Vault access token… and that endpoint changed since there was an “old way” of getting those tokens that is being deprecated.

Just tested with Microsoft.Azure.Services.AppAuthentication Version="1.3.1" and the same exception as above:
fabric:/ServiceFabric.DataProtection/DataProtectionService' reported Error for property 'AppConfigurationHealth'.
Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProviderException: Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried the following 4 methods to get an access token, but none of them worked.
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Managed Service Identity. Access token could not be acquired. Received a non-retryable error. MSI ResponseCode: BadRequest, Response: {"error":{"correlationId":"ddbcf916-0342-4880-af12-58d3ef7873e0","code":"InvalidApiVersion","message":"The api-version '2017-09-01' is not supported. Supported version is '2019-07-01-preview'."}}
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Visual Studio. Access token could not be acquired. Visual Studio Token provider file not found at "C:\Windows\system32\config\systemprofile\AppData\Local.IdentityService\AzureServiceAuth\tokenprovider.json"
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: . Exception Message: Tried to get token using Azure CLI. Access token could not be acquired. 'az' is not recognized as an internal or external command,
operable program or batch file.
Parameters: Connection String: [No connection string specified], Resource: https://management.azure.com, Authority: https://login.microsoftonline.com/common. Exception Message: Tried to get token using Active Directory Integrated Authentication. Access token could not be acquired. Failed to get user name from the operating system.
at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult()    at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__18.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult()
at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__16.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
at Microsoft.Azure.Services.AppAuthentication.AzureServiceTokenProvider.d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.AppConfiguration.ManagedIdentityConnector.ManagedIdentityConnector.d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.AppConfiguration.ManagedIdentityConnector.AzconfigClientFactory.d__1.MoveNext()
--- End of stack trace

@medand okay, that is the same root cause The api-version '2017-09-01' is not supported. Supported version is '2019-07-01-preview'. Will have to continue our follow up with Service Fabric. It is good that we confirmed the latest "Microsoft.Azure.Services.AppAuthentication" does not work though.


Who gets help from Github?

Having read a few of these issues XLM comes up a lot (As I’m still waiting 5 weeks later for my return of XLM tokens) interested if any of you peeps actually get a result or is it just left? Asking as 5 weeks is tooooooo long even if it is only a few XLM there nine and I’d like them back
PLEASE!

Thank you in advance!!!!!

Thank you in advance!!!!!


Home Assistant Error

Trying to configure home assistant with my skybell today and im getting this error any ideas why?

Sorry tried to copy and paste the error is here:
https://pastebin.com/6DmVKvqH

Sorry tried to copy and paste the error is here:
https://pastebin.com/6DmVKvqH

I am also unable to set up skybell with Home Assistant. Error is the same as the one posted by above.

I am also unable to set up skybell with Home Assistant. Error is the same as the one posted by above.

I had some time to dig into this. I found some additional error message in Home Assistant debug messages
./home-assistant.log:2021-02-07 15:28:29 DEBUG (SyncWorker_4) [skybellpy] HTTP get https://cloud.myskybell.com/api/v3/devices/xxxxxxxxxxxxxxxxxx/info/ Request with headers: {'Authorization': 'Bearer xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'user-agent': 'skybellpy/0.6.3 (HomeAssistant/2021.2.1)', 'content-type': 'application/json', 'accepts': '*/*', 'x-skybell-app-id': 'f802c621-9efc-xxxx-xxxxx-xxxxxxxxxxx', 'x-skybell-client-id': 'ab875aa5-xxxx-xxxx-xxxxxxxxxx'}
./home-assistant.log:2021-02-07 15:28:29 DEBUG (SyncWorker_4) [skybellpy] <Response [403]> {"name":"Forbidden","message":"Device not found"}

I was using a separate account that I create for use with Home Assistant and had the SkyBell shared with that account. I tried logging into the SkyBell app with the shared account and the video from the SkyBell never loaded. I tried to sign out and the app kept crashing. Eventually cleared the SkyBell app storage and I was able to log back in with my normal account. After all that, I updated Home Assistant to use the same credentials as my regular account, deleted the skybell.pickle file in the /config directory, restarted Home Assistant, and the the SkyBell integration was able to connect from Home Assistant.
Hard to say if there is some problem with the alternate account I was using, or if the integration requires an account with full permissions, but at least it is connecting successfully now.


TeamCity CI server fails fetch from gogs

TeamCity uses java git and ssh implementation (JGit & Jsch). When it tries to list refs of the remote repository hosted by Gogs it fails with timeout exception. Debugging shows that Jsch sets WantReply flag for its ssh requests and waits for reply from Gogs but never gets one. It seems like Gogs doesn't handle ssh requests with WantReply flag set to true.
Gogs Version: v0.8.10 @ 2015-12-18, as well as Gogs built from master branch
Git Version: not applicable since TeamCity uses JGit - java git implementation
System Type: all systems
Error Log: there is no errors in the Gogs logs

This issue is claimed to be fixed by merging #2432

I'll try to get this fix verified as soon as possible (probably end of this week, beginning of next).

I can confirm that this works now. (Running x64 version on Windows)

Thanks @redoz !


DuckDNS wildcard/sub-domains failure

I currently try to get a single certificate for a duckdns domain and a sub domain, which fails. You can find some redacted output below for reference.
I think dehydrated first deploys all challenges, then triggers validation for all domains and then cleans all challenges (HOOK_CHAIN is off). However, duckdns is a bit special in that sense that while they do support subdomains, these simply point to the same record as the main domain and you can only set the latter. So what seems to happen is:

Challenge token X is set for main domain
Challenge token Y is set for sub domain, this actually overrides X (my hook strips the sub-domain as per the above).
one of the  validations fails because Y is not equal to X

Am I doing something wrong on my end or is this a restriction of how dehydrated/ACME works? In the latter case, would it be possible to explicitly sequence deploy/validate/clean per (sub)domain via some option?
about my setup:
Config only overwrites CA (to use staging) and sets domain file. My domain file is really simple  'mydomain.duckdns.org mysub.mydomain.duckdns.org'. I validated and the hook is working just fine if I only try the single domain or sub-domain, it's the combination that fails.
For reference: I tried using a wildcard certificate instead of a subdomain but that gave the same problem. In this case I actually don't understand how it could work even for other DNS providers, because dehydrated itself asked to install tokens for 'mydomain.duckdns.org' and 'mydomain.duckdns.org' (it stripped the *. itself), which would always conflict.
# INFO: Using main config file /data/workdir/config
Processing mydomain.duckdns.org with alternative names: mysub.mydomain.duckdns.org
 + Signing domains...
 + Generating private key...
 + Generating signing request...
 + Requesting new certificate order from CA...
 + Received 2 authorizations URLs from the CA
 + Handling authorization for mydomain.duckdns.org
 + Handling authorization for mysub.mydomain.duckdns.org
 + 2 pending challenge(s)
 + Deploying challenge tokens...
OK //result from my hook: set TXT for one domain
OK //result from my hook: set TXT for the other
 + Responding to challenge for mydomain.duckdns.org authorization...
 + Challenge is valid!
 + Responding to challenge for mysub.mydomain.duckdns.org authorization...
 + Cleaning challenge tokens...
OK
OK
 + Challenge validation has failed :(
ERROR: Challenge is invalid! (returned: invalid) (result: {
  "type": "dns-01",
  "status": "invalid",
  "error": {
    "type": "urn:ietf:params:acme:error:unauthorized",
    "detail": "Incorrect TXT record \"<redacted>\" found at _acme-challenge.mysub.mydomain.duckdns.org"
    "status": 403
  },
  "url": "https://acme-staging-v02.api.letsencrypt.org/acme/challenge/<redacted>",
  "token": "<redacted>"
})

Probable duplicate of #544.
Did you read the troubleshooting guide?
Why are DNS challenges deployed first and verified later?

I missed that troubleshooting guide, my apologies. If I read that correctly the better solution would be to actually have duckdns support multiple txt records per domain, I will check with them.

@KillianDS Have found a solution? I have same issue...

@letroll I don't have a technical solution, as explained in the link above the only way to work around that limitation is to do challenges one by one and to wait for the DNS cache to timeout in between. This would take a while, even with duckdns' short TTL.
I left a suggestion on duckdns'  google+ community to support more than one TXT record but did not get any feedback on that.
In any case closing this here as it is indeed a duplicate of #553 (and #554)


adding bower.json

removed items that can be acquired with bower.
updated demo.html to reflect new locations
gitignore added to not include what bower should be doing
I have a public site that uses codaslider and I was hoping to get this change in so I/we could submit it to bower. Just about all of my other components are supported there and this was one of the few outstanding.

I don't plan on ever updating the plugin again as I consider it obsolete. Have you tried the Liquid Slider? It's basically an updated version of the Coda Slider that is also responsive.
Actually, I'm considering building a new slider that allows for easier control of the style, content and transitions. Just need to find time.

It's fine if it's obsolete. It's actually obsolete in my code base as well and is "marked for deletion".
However, until we get to removing it, I'll need to include it in bower as it's part of our tool stack.
There's a few ways to do this, please say if I've missed something:

I can submit my repo to bower, but it kinda becomes mine so far as bower users are concerned.
You can do the PR and keep the profile traffic generated by having it on bower.

Either way is fine, but I wanted your input before submitting it.
Thanks! Josh

You can now use bower.


Broken link to Atlassian docs in README

What it is:
https://developer.atlassian.com/display/DOCS/Introduction+to+the+Atlassian+Plugin+SDK
What it should be (?):
https://developer.atlassian.com/docs/getting-started

Thanks!


Why did dependabot miss the cobra 1.4.0 bump?

Not sure... but it picked up Cobra 1.5.0...
Gonna close this for now... if we see this happen again, we can re-open and investigate.


Hubot fails to connect on hipchat

I'm trying a brand new install of hipchat running nodejs v0.12.2 on OSX Yosemite in homebrew.
I'm getting a ton of HipChat connection errors
Here's a gist of everything https://gist.github.com/samgranieri/811a0fded03c3209129d
Am I doing anything wrong?

Are we supposed to use the hipchat adapter in the shell? I just tried it that way and got the same errors, I guess I've just always been running the shell adapter locally.

Update, so for me -- it was an enviornment variable issue like, #240 suggests fixing. However, I just tried with a bad JID / password combo and got the same error. With a good password all was well, at least for me.
Obviously, I don't know what your password was, but you might try changing the export line to
export HUBOT_HIPCHAT_PASSWORD='password' (note the quotes), incase there are any special characters.

Thanks for the suggestion @cycomachead.  Does that help, @samgranieri?  Feel free to re-open this if it doesn't help.

@cycomachead I just want you to know that you inadvertently made me realize I was using HUBOT_HIPCHAT_PASS instead of HUBOT_HIPCHAT_PASSWORD. Thanks for that. :+1:

No problem! :+1:


fix: Update RuleVisitor type

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?
Make RuleVisitor type work practically with subinterfaces.
What changes did you make? (Give an overview)

Converted RuleVisitor interface into a mapped type.

Related Issues
fixes #134

Is there anything you'd like reviewers to focus on?
The typescript-eslint rule recommended using a record instead of an object type. Does that make sense?

Oh, now Prettier 3.4 is complaining because of the formatting of Markdown files. It's the same problem as with eslint/json#67.

I guess their semver policy isn't a strict as ours. :smile:


How can i make the theme change colors with vivaldifox?

https://addons.mozilla.org/en-GB/firefox/addon/vivaldifox/
Thanks for the cool theme btw.

It's possible... kinda, but seems like Vivaldifox doesn't supported dynamic theme mode change (example: When I use light mode by default, once I visited a website with dark mode, I would love to use light toolbar icon, light URL text, and such.) Because ArcWTF uses transparent URLbar and use the same color (--lwt-accent-color) for the whole navbar + tabbar + #browser-container border, the coloring might clashed when you visited dark websites in light mode. Anyway here's a config that worked if you're okay with that condition:

I advise you to use Adaptive Tab Bar Color instead, the automatic color scheme fits ArcWTF very well 👌 Here's my setup:

Ive been experimenting with https://github.com/Frewacom/pywalfox and ive managed to get it working i think?
I created spotipaper that would work amazingly with this theme +  pywalfox.
But yeah thanks for the feedback on vivaldi I really appreciate it, I will check that out if i ever get bored of pywal.

Two steps:

Changing toolbar icons scale on toolbar/navbar.css line 13. Default is 0.85, you can change it to 1 or 2.
Changing URL bar height. The original code are Here are the original code from toolbar/urlbar.css line 17, feel free to modify:

 /* urlbar height */
  & #urlbar-container {
    --urlbar-container-height: calc(8px + 16px + var(--toolbarbutton-inner-padding) * 2) !important;
  }

  & #urlbar {
    --urlbar-toolbar-height: calc(5px + 16px + var(--toolbarbutton-inner-padding) * 2) !important;
    --urlbar-height: calc(16px + var(--toolbarbutton-inner-padding) * 2) !important;
    --urlbar-min-height: calc(16px + var(--toolbarbutton-inner-padding) * 2) !important;
    font-size: 1em !important;
  }

yeah i played with that but i could only seem to move the url bar... i would just like a bit more padding on the toolbar because its quite squished atm

Oh you should edit toolbar/navbar.css line 8 then, especially --toolbarbutton-outer-padding. Sorry for forgetting it 😅
:root {
  --toolbarbutton-border-radius: 4px !important;
  --toolbarbutton-inner-padding: 4px !important;
  --uc-toolbarbutton-inner-inline-padding: 4px !important;
  --toolbarbutton-outer-padding: 6px !important;
  --tabs-navbar-shadow-size: 0px !important;
  --message-bar-border-radius: var(--border-radius-medium);
}


Repacking a .resourceFile

I can unpack them, just like unity3d files, so how can I repack them back to resourceFiles?  The resourceFiles seem to have the UnityWeb version header at the beginning of the file and then compressed data.
Basically, I'm taking unity asset bundles stored in the unity cache folder in AppData and trying to repack them into resourceFiles.  The cached asset bundles seem to be extracted.
When I try to use the "bundle unpack CustomAssetBundle -o Compressed.resourceFile" command, I get a null reference exception.  I tried renaming the CustomAssetBundle file to .unity3d and not using the -o parameter but that didn't work either.
Thanks

I created a custom tool.


Add Query for tracking ICA msg execution

Summary
Add a query to host and controller chains to make it easy to see the results of a message executed with interchain accounts. These messages aren't executed in the way normal messages are where the user is given a tx hash to query. There is a tx hash but it's difficult to know what it will be since it is submitted by some relayer.
Problem Definition
Pasting the relevant parts of a conversation in the IBC internal slack channel about querying the results of interchain account msg execution under Problem Definition.
it looks like the only query the host module of ica has is for the params. I guess when a message is submitted via ICA it's the relayer's tx that contains information about the execution of the ICA msg right? Is there a convenient method for the user/module that initiated the ICA msg (controller side) to query the host about the results of the Msg? I know there is some Ack logic in the controller demo but it has to be custom created to handle each msg type and isn't necessary unless there is some action that takes place depending on the results of the execution.
basically what i'm looking for is how to check the results of the ICA msg on the host chain. Would the flow be something like:

controller chain generates outgoing IBC packet (this has some kind of UID?)
query the host chain for a transaction that contains the incoming IBC packet by UID(?)
once you know the tx hash on the host chain you can query the tx for events about the execution of the actual Msg?

...
as a user who initiated the transaction would i do the following:

submit my IBC transaction on controller chain
look in my successful tx for EventTypeSendPacket which contains all the unique info of my outgoing packet. However I don't see any universal unique ID here that I might be able to query on the host chain.

Now I know that there's the possibility for the packet to be submitted to the host chain but I don't know who will do it so I don't know what the tx hash of that tx will be. Is there any generic query on the host chain to ask for the tx that contained my message?
is it possible to query the host chain for transactions that contain EventTypeRecvPacket messages where all the attributes from EventTypeSendPacket are the same?
...
You can query all txs on the host by running something like this:
icad q txs --events 'recv_packet.packet_src_port=icacontroller-cosmos1m9l358xunhhwds0568za49mzhvuxx9uxre5tud' -o json | jq

where the event attribute of interest is the channel source port. Piping the JSON output through jq is a little more readable, but you do get quiet a hefty response, as the relayer sends a multi msg tx including the MsgUpdateClient as well as the MsgRecvPacket.
...
I wonder if it's worth considering a new query on the host chain that is designed for this specifically? maybe like the tx command but for messages that have been executed by an ICA? Adding new queries doesn't break state so it could be a patch release down the line and not block any major or minor releases in the mean time.
just thinking it would make debugging ICA account interactions easier for users and eventually wallets / applications.
...
In the v6.0.0 release (with the ICA improvements) the MsgSendTxResponse will include the sequence number, so maybe we can use that on the query on the host to get information about the message execution. Although then any custom authentication modules (like mauth) would need to implement also a response message that includes the sequence (i.e. adding it here).

Proposal
On the controller chain make it easy to retrieve a set of unique identifiers for a message sent over ICA using a new query (or the result returned from the originally executed message)
On the host chain create a query that accepts the set of unique identifiers for a message sent over ICA to return results similar to a tx query for that specific set of messages.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

@okwme Thanks for opening the issue and raising awareness for this problem.
After discussing with the rest of the team we have decided the following:

We will use this issue to implement a CLI query on the controller chain that will check if the acknowledgment for a packet was successful or not. This will be part of the v6 release, but we think that we can back port this CLI to previous version (v3, v4, v5).
For pre-v6 ibc-go, the custom authentication modules should implement the OnAcknowledgment callback and check whether the ack contains an error or not. You can do that with a smile switch like it is done here for transfer. Then on each case of the switch statement you can log or emit an event.

It's nice to be able to see from the controller side whether the tx was successful in the Ack but it does not achieve the goals stated in the issue above unless all of the events are also carried through the Ack. As a user I want to know whether my tx was successful and what the events that followed were and this is only possible by querying the host side.
@AdityaSripal mentioned that a new packet ID system was being implemented, being able to query the host for the packet ID and receiving the events would satisfy the flow I'm describing I believe.

Hey @okwme, what is your use case? Is this only going to be used for testing purposes?

As someone who is facillitating a governance enabled interchain account transaction I need to populate the gov module with correct subsequent transactions to be voted on. One flow in mind is adding liquidity to an osmosis pool or swapping tokens on an osmosis pool. It should be possible to query the account for LP tokens or resulting tokens but if the account already has a balance it is much safer to check the event logs to ensure the correct amount.
Since ICA can be used with any variety of host chain modules I would expect there to be a generalized way to query resulting events.
Beyond being the party resposible for checking gov ICA messages and setting up subsequent ones there is, as you said, a need just for debugging that this would enable.

Thanks for the followup @okwme. We will add a cli to the host chain which takes in the channel-id and sequence on the host chain side and returns the events associated with the ica tx execution

For the implementer, see how sdk queries events via cli

Events aren't included in the ack sent to the controller due to the nondeterminism.

being able to query the host for the packet ID and receiving the events would satisfy the flow I'm describing I believe.

We implemented a query on the host for packet events in: https://github.com/cosmos/ibc-go/pull/782

We implemented a query on the host for packet events in: #782

So good that you remembered about this, @damiannolan! :) So then we can close this issue?

Closing as packet events query implemented in #782 👍


[BUG] Treats UTF-16 text files as binary

Bug
Describe the problem
Is this intended? Converting UTF16 files to UTF8 to do a diff would be a little cumbersome...

Oops, sorry wrong project. Had the same name.


Update manifests/c/calendulish/SteamToolsNG/3.1.1/calendulish.SteamToolsNG.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

URL:
Invalid URI: The hostname could not be parsed.
(Automated message - build 896)

[Policy] Reset Labels


Update file locations and names in documentation to accomodate for pl…

…anned custom functions template updates addressed in https://github.com/OfficeDev/Excel-Custom-Functions/pull/24/files/c644731ab3cc36417ad2932dbc4c6e10f5861b86..12bf5d0f2e6c1dd3ded5114e8f15688981d4b9ee.
NOTE: We will need to push these changes to master at the same time we push changes to https://github.com/OfficeDev/Excel-Custom-Functions/pull/24/files/c644731ab3cc36417ad2932dbc4c6e10f5861b86..12bf5d0f2e6c1dd3ded5114e8f15688981d4b9ee

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks! Merging to master now


supertest-restify-gzipresponse-file-upload

I've asked this question on stackoverflow without any luck yet:
http://stackoverflow.com/questions/36306505/supertest-restify-gzipresponse-file-upload
I'm getting
TypeError: Cannot read property 'status' of undefined

when attempting to upload a file using supertest to a simple restify server, with gzipResponse turned on.
Versions etc:
$ npm list | grep 'super\|mocha\|restify'
├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>
$ node -v
v5.5.0

The server:
const restify = require('restify');
const server = restify.createServer();

server.use(restify.gzipResponse());

server.put('image', (req, res) => {
    res.send(200, 'OK!');
});

// For testing
module.exports = server;

// For actually running the server
if (!module.parent) {
    server.listen(8888);
    console.log('Listening on 8888');
}

The test:
const request = require('supertest');
const server = require('./index');
const path = require('path');

describe('insertImage', function () {

    it('should send an image', done => {
        request(server)
        .put('/image')
        .attach('image', path.join(__dirname, 'pc.png'))
        .expect(200, done);
    });

});

The test will pass when gzipResponse is disabled, and it will also pass if no file is attached.
Moreover, when running the server, and just firing a request with curl, the server responds successfully.
curl -X PUT -F<EMAIL_ADDRESS>local8888/image
So this makes me think the problem is not with Restify/gzipResponse, but rather with supertest/superagent. What do you guys think?

@edorivai  I just left an answer on the SO question. TLDR I think that supertest handles gzip responses just fine. There must be some issue with the server set up for the test.

I see, but what do you think about the fact that curl seems to work just fine?

Not really sure. Using the same test server curl and request appears to be working as well:
        request.put({
            url: 'http://localhost:3000/image',
            method: 'put',
            body: fs.createReadStream('./pc.png')
        }, function(err, res, body) {
            console.warn(body);
            return done();
        });

Based on these results I'd suspect supertest, but if they were unable to reproduce, then it could be something specific to your environment. Not sure what to tell you besides rm -rf node_modules, and reinstalling everything to see if it helps.

You know what, I even got a completely new computer. Obviously installed everything from scratch; OS, node (nvm), all of the modules etc, problem still persists. Not sure what to make of this.

Bummer - not sure what to tell you. I just pulled down your snippets here and ran them locally and it seemed to be working for me. What OS/node version are you using? What commands are you using to start your server and run the tests?

posted comment for similar (if not the same issue) on #348

Hey, on request of the people over at restify, I've setup a repo that produces the issue:
https://github.com/edorivai/supertest-restify-upload
According to this comment, the restify peeps think the problem is with supertest:

It doesn't look like restify is on the path of this exception, I'm fairly certain this issue is down inside of supertest. _assertStatus inside of lib/test.js expects to be given a res object and it doesn't appear one is being passed in. Hope that helps!

Hey y'all,
@retrohacker from the restify repo here. Happy to work together to try to solve this bug :smile: I hate to see @edorivai being bounced back and forth. Where we are at right now is that it doesn't appear _assertStatus is getting a res object back from supertest. It may be that restify is breaking an assumption that supertest makes, but I don't know enough about supertest to get much further at this point.

Sorry, just read this thread. @edorivai, have you run the patch from #348? Looks pretty much identical to what we are describing here.

I didn't, will check tomorrow!
On Tue, May 9, 2017, 17:12 William Blankenship<EMAIL_ADDRESS>wrote:

Sorry, just read this thread. @edorivai https://github.com/edorivai,
have you run the patch from #348
https://github.com/visionmedia/supertest/pull/348? Looks pretty much
identical to what we are describing here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/visionmedia/supertest/issues/328#issuecomment-300196395,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAutrk6hp1jB5ov3NdI1hLmC2Fm5IB1uks5r4IJXgaJpZM4IEX7p
.

@retrohacker The v5 branch in my repo uses supertest v3: https://github.com/edorivai/supertest-restify-upload/blob/v5/package.json#L6
And the issue still persists there.


Compliance with new "main branch" upcoming github changes

there's plans to rename "master" to "main" in a lot of repos in favor of the BLM movement, among other reasons, see this article on zdnet. Currently my repository Dash has renamed it's main branch to main and due to this, attempting to load master fails on https://deno.land/x/dash.
An easy fix for this would to be to check if master exists, and if it doesn't get the default branch name of the repository and then instead fetch that branch.

Duplicate of #1130.


chain invoke method returns different sources from ainvoke

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
I have retriever like this
class FilteringRetriever(VectorStoreRetriever):

    def _get_relevant_documents(
        self, query: str, *, run_manager: CallbackManagerForRetrieverRun
    ) -> List[Document]:
        docs = super()._get_relevant_documents(query=query, run_manager=run_manager)
        # filter documents
        newdocs = my_filter(docs)
        return newdocs[:5] # I want only 5 documents

Error Message and Stack Trace (if applicable)
No response
Description
When I call chain.invoke it correctly returns 5 documents. But when I invoke it asynchronously chain.ainvoke it returns all 100 (probably from initial search_kwargs). I'd expect it to be consistent, but I appreciate maybe that's not intended use of retriever. Can someone point me towards some workaround, as I need async calls in my application?
System Info
System Information
------------------
> OS:  Darwin
> OS Version:  Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000
> Python Version:  3.11.7 | packaged by conda-forge | (main, Dec 23 2023, 14:38:07) [Clang 16.0.6 ]

Package Information
-------------------
> langchain_core: 0.1.16
> langchain: 0.1.4
> langchain_community: 0.0.16
> langchain_openai: 0.0.5

Packages not installed (Not Necessarily a Problem)
--------------------------------------------------
The following packages were not found:

> langgraph
> langserve

Ok, I figured that my custom implementation of retriever was lacking:
    async def aget_relevant_documents(self, query: str, *, run_manager: CallbackManagerForRetrieverRun) -> List[Document]:
        return await run_in_executor(None, self._get_relevant_documents, query, run_manager=run_manager)

Just wonder why this is not a default behaviour 🤔 .


fix: reduce change config logs

这个 PR 实现什么功能/修复什么问题:
修正：减少更新配置的操作日志

是否需要 backport 到之前的 release 分支:

release/3.4

/area keystone
/cc @zexi

Codecov Report

Merging #8353 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8353      +/-   ##
=========================================
- Coverage    6.12%   3.53%   -2.60%
=========================================
  Files         762     304     -458
  Lines      118376   62563   -55813
=========================================
- Hits         7256    2211    -5045
+ Misses     110465   60198   -50267
+ Partials      655     154     -501

Flag
Coverage Δ

#aFlag
3.53% <ø> (-2.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/response.go
64.40% <0.00%> (-3.39%)
:arrow_down:

pkg/util/qemuimg/consts.go

pkg/util/atexit/atexit.go

pkg/mcclient/options/cloudgroup.go

pkg/multicloud/aws/loadbalancerbackendgroup.go

pkg/keystone/models/user_option.go

pkg/multicloud/aws/keypair.go

pkg/util/qemuimg/init.go

pkg/mcclient/options/cloudpolicy.go

pkg/cloudcommon/validators/validators_sshkey.go

... and 447 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2ecd1...60167da. Read the comment docs.

/hold

/hold cancel

/lgtm
/approve


Update to 0.33.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

#14 is in, I think we can close this PR?

#14 is in, I think we can close this PR?

Yes, let's close it.


Improve Wallet Backup UX

If we're printing the path, let's use the input type that makes it easy to select and copy it. Most likely the identical component used for Receiving Credits in the Wallet would work.

Add a button that opens the folder or file directly.

We have a pr for the button already.. Probably just needs some positioning/styling fixes.
https://github.com/lbryio/lbry-app/pull/1628
Agreed with the copyable field.

I'll try to work on 1. too


chore: missing topic info duration 1000 -> 5000

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>Description
Currently, duration of debug print for missing topics is too high.
Therefore, I made them low (1000 -> 5000).

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Let me know if 5000 is too low.


Sema: Fix crash on static -vs- non-static witness mismatch with deserialized witness [5.3]

Deserialized computed properties don't get a PatternBindingDecl apparently.
Fixes rdar://problem/68241758.

@swift-ci Please test


armv7s arch - iPhone 5, iPhone 5c, iPad(4G) is not supported

when running the following query against both, MobFoxSDKCore and MobFoxSDKCoreDynamic:
lipo -info MobFoxSDKCoreDynamic
I receive the following output:
Architectures in the fat file: MobFoxSDKCore are: i386 armv7 x86_64 arm64
Architectures in the fat file: MobFoxSDKCoreDynamic are: x86_64 i386 armv7 arm64
It means that armv7s is not supported(iPhone 5, iPhone 5c, iPad(4G))
Can you elaborate on this? why these arch was dropped out from Release build?

Hi,
I think it's due to XCode changes in the default archs. We'll issue an update with a fix soon.
Itamar

Hi, please try the build below and tell me if it works for you.
Architectures in the fat file: MobFoxSDKCore.embeddedframework/MobFoxSDKCore.framework/MobFoxSDKCore are: i386 armv7 armv7s x86_64 arm64
armv7s.zip

Yep, it seems that armv7s is no longer in the list of $(ARCHS_STANDARD) variables. Now, using the file you attached, armv7s arch is included into the build build.

ok, we'll include this in our next bug fix release and then I'll close this issue.

Thanks

added in 3.1.8c


Suggestion: Utilize the model type defined in a resolved view for visitedObjects instead of string

I have gotten bitten by the visitedObjects being populated by the string type when I attempt to force a null object to render.
Html.Editor("notInViewState","ModelWithCustomStringEditor")

This causes issues if I have a custom editor for the string type on a property in my model.
The current work around is to define a variable with the type set to the intended datatype
ModelWithCustomStringEditor temp = null;
Html.EditorFor(m=>temp,"ModelWithCustomStringEditor")

but this seems to be a bit of a gotcha.

@Tarig0 sorry I'm not sure I understand what the issue is here.

InvalidOperationException: The model item passed into the ViewDataDictionary is of type 'System.Collections.Generic.List1[Labels.Electrical.Models.ElectricalFanPart]', but this ViewDataDictionary instance requires a model item of type 'System.Collections.Generic.IList1[Labels.Electrical.Models.Interfaces.IElectricalPart]'.

The current behavior
The first block will have the following template path
BASE -> "string" -> "string"
I would expect this to be
BASE -> "ModelWithCustomString" ->  "string"

@Tarig0 thanks for the extra info.
@dougbu any idea on this?

Note this suggestion steamed from the issue #6939

any idea on this?

Something is definitely wrong here. Passing Editor(...) an explicit templateName should use that name.
@Tarig0 please provide a repro project, preferably as a GitHub repo. Need to be sure I'm understanding your scenario.

https://github.com/Tarig0/CustomStringEditor

https://github.com/aspnet/Mvc/blob/8f8bf5af341b5cc07e0611dc9a3a02e471e2bf63/src/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewFeatures/TemplateBuilder.cs#L145
This is the section of code that I think if you could extract the resolved type of the model and use that over the string type found in the modelexplorer

@Tarig0 the code you copied above looks fine since TemplateInfo information is shared only "vertically" i.e. between nested views.  However your application isn't providing enough metadata for the system to work properly.
One issue in your application is this line
@Html.Editor("notinViewState", "ModelWithCustomStringEditor")

Editor(...) cannot be used with expression names that do not map to ViewDataDictionary keys, Model properties, or indexers and property accesses relative to one of those two. So, the call should be
@Html.Editor("ModelWithCustomStringEditors")

or
@Html.Editor(nameof(ParentModel.ModelWithCustomStringEditors))

Either will iterate through the Model.ModelWithCustomStringEditors collection and invoke the ModelWithCustomStringEditor.cshtml template for each. That template will have the correct metadata and TemplateBuilder won't refuse to render it.
However, the model is null in your application, not even an empty collection. That hits a restriction of string-based HTML helpers: They traverse the model or ViewData entries, not metadata, and thus can find information about null properties but nothing inside null collections or objects. Use EditorFor(...) instead e.g.
@Html.EditorFor(m => m.ModelWithCustomStringEditors[0])

(For the above to work, you'll also have to switch the property from IEnumerable<T> to IList<T> or ICollection<T>.)

@Tarig0 I think I've answered your questions. Please reopen if I missed something.