split out compiled js from typescript types and autogenerate both

Fixes https://github.com/rnmapbox/maps/issues/2140#issuecomment-1230278406

@natew Thanks for doing this and I support the overall direction of compiling as part of the publish step.
I'll leave it to @mfazekas to decide whether this is the direction the library can go, but a couple thoughts:

Shouldn't the prepare script include compiling/packaging? It gets run on npm install, so without that, it'll be hard to install the library directly from Github, or from a local copy.
It would be nice if the declaration files got generated directly into lib, so they didn't clutter up the source project.

@natew thanks for the PR, but we still wait for repro steps for the issue you're seeing.
Metro bundler does transpile packages in node_modules so publishing transpired stuff is optional.
Also following should be checked/verified:

[ ] our example app works just fine (and editing package file and pressing r should resuling in example with modified code. Watch is possible but not optional.)
[ ] use package with yarn add rnmapbox/maps#main and npm install rnmapbox/maps#main works

BTW if you look at react-native-reanimated they also point to src/index and not to lib/... for react-native . https://github.com/software-mansion/react-native-reanimated/blob/acf7429068c4f801eef41267c2a94b5515ec4ff8/package.json#L30
Same one for react-native-paper
https://github.com/callstack/react-native-paper/blob/6ff9a20885ffcbe9c864542a26a6ee47db355002/package.json#L7

@natew
Regarding the test failure of the pattern

'MapView' cannot be used as a JSX component.

I had the same thing in my now-cancelled Typescript conversion PR, and the only way I was able to fix it was adding these comments:
 *
 * @extends {Component<MapViewProps>}
 */
class MapView extends NativeBridgeComponent(Component) { ... }

Perhaps you can solve it another way, but I thought this might help.

BTW if you look at react-native-reanimated they also point to src/index and not to lib/... for react-native .
Same one for react-native-paper

@mfazekas it is worth noting that both of these projects use https://github.com/callstack/react-native-builder-bob, which does compile to lib and thereby has a very wide range of support.
I've also had a lot of trouble installing @rnmapbox/maps from a local copy (currently using npm pack for local dev ☹), which by contrast has been easy to do with other projects built on react-native-builder-bob. So I'm not exactly advocating for rebuilding on top of that template, but compiling down to a 100% JS library does seem like a clean, effective pipeline.

BTW if you look at react-native-reanimated they also point to src/index and not to lib/... for react-native .
Same one for react-native-paper

@mfazekas it is worth noting that both of these projects use https://github.com/callstack/react-native-builder-bob, which does compile to lib and thereby has a very wide range of support.
I've also had a lot of trouble installing @rnmapbox/maps from a local copy (currently using npm pack for local dev ☹), which by contrast has been easy to do with other projects built on react-native-builder-bob. So I'm not exactly advocating for rebuilding on top of that template, but compiling down to a 100% JS library does seem like a clean, effective pipeline.

From react-native-builder-blob:  https://github.com/callstack/react-native-builder-bob

It's usually good to point to your source code with the react-native field to make debugging easier. Metro already supports compiling a lot of new syntaxes including JSX, Flow and TypeScript and it will use this field if present.

So I don't think for react-native project that changes anything - unless you're not using metro, say for react-native-web. So sure I'm fine with doing transpiration esp. for non metro bundlers. But I doubt that it will make any difference for regular metro based rn projects.

@mfazekas are you able to develop on this project locally, as in npm install /my/local/clone/maps in a parent RN project? If so, can you describe what your setup is?
I think this is one of the fundamental things that makes me support this PR, to make local development more predictable.

Sorry for drive-by PR. Honestly, part of this is just that my tsc --watch on my app complains and I can't seem to find a way to disable it, despite trying a few different excludes, declares etc. But I think in general it's also just a nice practice, it means you can require() from a node REPL to introspect the shape of things, for example.

@mfazekas are you able to develop on this project locally, as in npm install /my/local/clone/maps in a parent RN project? If so, can you describe what your setup is?
I think this is one of the fundamental things that makes me support this PR, to make local development more predictable.

@naftalibeder but are they?!
I'm mostly using yarn, and I'm usually install from GitHub, (Btw. npm link would be awesome but symlinks don't work with metro used by RN). I'll try npm install as soon a I have some time.
I don't see what's the difference between npm install <path> and npm install rnmapbox/maps#main. You should be able to diff the node_modules/@rnmapbox/maps to see if they are any different, but I don't think so.
What is the error you're seeing?!

I have a multi-platform project where this library is used for maps on native platforms and the official JS SDK is used for web. The project uses react-native-web which has already been mentioned as a possible reason to start doing transpilation.
At the moment, there is no way to tell the typescript compiler to ignore this library when building the web version since the library is included (imported) in the project. The bundler (webpack) never actually includes any of its code because of platform-specific file extensions, but the library is still type-checked since tsc doesn't recognize said extensions.
I'm using several libraries that are built with RN in mind (which usually means that they include JSX in JS files), but this is the only library that causes issues - because it includes raw TS files. My current workaround can be found here, it would be awesome if this step was not necessary! 🙌

It absolutely could've, thanks for the tip! It's been a while since I last heard of rnx-kit, they have some really useful stuff!
Unfortunately, I'm using fork-ts-checker-webpack-plugin, and patching it in order to use rn-tsc instead would be about as hacky as the current workaround IMO. But for those running tsc themselves, that could be a potential (temporary) solution!

Folks, just to clarify i do accept a pr that transpiles to lib dir. Provided that:

generated sources are not stored in git (for now)
react-native keep pointing to ./javascript/index.js. Note that main or browser can point to lib/index.js or similar.

See
https://github.com/software-mansion/react-native-reanimated/blob/acf7429068c4f801eef41267c2a94b5515ec4ff8/package.json#L30
and
https://github.com/callstack/react-native-paper/blob/6ff9a20885ffcbe9c864542a26a6ee47db355002/package.json#L7
for reference

react-native keep pointing to ./javascript/index.js. Note that main or browser can point to lib/index.js or similar.

@mfazekas if you insist on keeping this as-is (which some libraries that you mention seem to do indeed), I don't think there's any benefit to ship compiled JS in the first place right?
I would argue it's a bit of an anti-pattern, as it causes issues like this down the line: https://github.com/rnmapbox/maps/issues/2333, for example if there are different typescript settings.
However, I do understand that it has a benefit where you can keep referring to a github branch in package.json and everything "just works", like you explain here.
I think a cleaner way to get a github/branch-referenced package working (i.e.: create an app "DemoApp" that depends on rnmapbox#branch-name) is to:
a) point react-native in package.json to the transpiled, built files
b) include a postinstall step in "DemoApp" that builds node_modules/rnmapbox.
Of course, the postinstall step would not be necessary when depending on a published version of rnmapbox.
What do you think?

react-native keep pointing to ./javascript/index.js. Note that main or browser can point to lib/index.js or similar.

@mfazekas if you insist on keeping this as-is (which some libraries that you mention seem to do indeed), I don't think there's any benefit to ship compiled JS in the first place right?

I don't think you're right about that. The bug report that contains the concrete issue Is #2333, which is about tsc with a custom config. Tsc doesn't use the react-native key from package.json so tsc related issues should be addressed.

I don't think you're right about that. The bug report that contains the concrete issue Is https://github.com/rnmapbox/maps/issues/2333, which is about tsc with a custom config. Tsc doesn't use the react-native key from package.json so tsc related issues should be addressed.

Depends how you look at it :) The reason this is related is that this issue (#2333) wouldn't have occured if the typescript build process would have been decoupled from this package. By keeping it like this, you're implicitly forcing consumers to:

use a specific Typescript version that's compatible with RNMapbox
use specific settings for Typescript that are compatible with RNMapbox

This limits the re-usability of the library in my opinion


Update README.md

Adding a bit, inspired by Orwell's "Politics And The English Language".

Like.
This looks like it needs a rebase, and for you to add yourself to the AUTHORS file, please.


Events and Timeline for containers, pods and projects

This handles the requests in #4039 and fixes the event type for containers.

@miq-bot add_label providers/containers
@miq-bot add_label enhancement
cc @h-kataria @blomquisg @chessbyte
Please don't merge this yet :-1: Merge #4039 first. Thanks!

@h-kataria @chessbyte since #4039 is not mergeable and @dkorn is away for this week, we should continue here. Thanks!

ping @h-kataria @blomquisg @chessbyte

@chessbyte UI changes look good to me, i am not sure about model changes, please merge if they look good to you.


Fixes: Renamed the OpLabels field to Labels

…bels
Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #26923 line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[x] Thanks for contributing!

It basically renames the OpLabels field to Labels in structs having this FIXME comment
Fixes: #26923
Fix renamed OpLabel field to Label in structs Endpoint and serializableEndpoint

What's the rationale behind renaming the field? Such changes may introduce unnecessary churn in the code base, and complicate backports.

not sure as it was mentioned in comment as FIXME!
should I remove the FIXME tag in comments?

I think in this case, the FIXME is probably outdated and will need to be removed, but we'll need to check with the original author.
Thanks for this PR @dipankardas011, love the energy, but I think we probably should close this one out for now.

Sure should we mention the author in the issue?


_.pick Returns Keys Not Present And Assigns 'undefined' To Them

Not sure if this is expected behaviour or not (the test indicate it is) but if you use _.pick on a stream of objects and one of the keys you're looking for isn't present, the key still appears in the filtered stream but with the value undefined instead. For example,
_([{ name: 'Test', id: 1234 }]).pick(['name', 'blah']).toArray(console.log)
// => [{ id: 1234, blah: undefined }]

I would have expected this output:
// => [{ id: 1234}]

It also has the strange side effect where if none of the keys you are looking for are found then the objects returned are not empty like with lodash or Ramda:
var R = require('ramda')
R.pick(['blah'], { name: 'Test', id: 1234})
// => {}

This makes it harder to filter out unwanted elements because you can't do something like this:
_([{ name: 'Test', id: 1234 }, {name: 'Test'}]).pick(['id']).filter(R.isEmpty).toArray(console.log)

I have a pull request done for this and ready to submit if no one has any objections. Even if we don't change it, we should at least document the behaviour because it's a bit unusual.

I think this is "expected behavior" in the sense that it was the easiest way to implement it rather than that it must be this way. @mpj originally implemented this though, so he could give a more definitive answer.
As for me, I'm happy to accept a PR that changes the behavior of pick to be more in-line with existing libraries.

Hello,
I was the one originally asking @mpj to make the undefined appear.
I must admit that I did not look at what the other libraries are doing, but the way I see pick is that you want to "standardize" the downstream objects.
another way would be to push errors when pick is trying to pick a property that does not exist upstream. should the user be warned about picking a property that does not exist ?
I understand the use case with filter but this could be done with a specific filter and I am not sure that the pick handling should be drived by this use case.
what do you think ?

Standardising an object by filling it full of undefineds seems a bit strange to me but I can see the logic.
For me, the principle of least astonishment applies and that's why I think the filter case is quite pertinent here: most queries you run in any context return an empty set if the items requested are not found, I think we should do like likewise.
That said, I do like the idea of pushing errors if certain properties don't exist and also we have to think that this could be a breaking change if people are relying on this behaviour.

Thing is, there's no point in "standardizing" the downstream objects, since if you ask for an undefined key, you get undefined anyway ({}['a'] // => undefined). I don't see a real semantic difference between the two. In my experience, it's rare for people to use hasOwnProperty or something similar.
I agree with @svozza here about the principle of least astonishment. To me, the word "pick" implies that the result object will be a "sub-object" of the original. You're picking out the keys from the original. So it seems weird to me that it would contain keys that the original doesn't.
Another concern is that compatibility (as much as possible) with other libraries that provide the same transforms is important to help people migrate, and we shouldn't do something different unless there's a good reason.
Pushing errors may be a good solution, but we'd have to consider whether or not that would be useful to users or not before breaking back-compat.

ok I went back to the original discussion on this - https://github.com/caolan/highland/pull/135#issuecomment-64048685
It seems the current behavior is more a clarification of what the PR was already doing.
it is fine with me (and probably better for migrations as you said) if pick has a behavior similar to other libs.
This seems sufficiently light (and annoying for @svozza who might be the first user of the feature except @mpj) that we consider that it is not a back-compat issue.
regarding the error handling it might be a bit more of a breaking change if we start pushing error for each missing key so I don't think it is needed now - even if for me "picking" a non existing property is definitely something that should trigger a warning.
that might be done by another transform like checkProperty

Yeah, definitely hold off on the errors part for now, it's a big enough change. Whilst we're on the subject of pick, do we want a pickBy method? It would accept a predicate function - called on each key/value pair of the object - that takes a key and value as parameters and allows the pair through if the function returns true. I may need this functionality in the future so I'd be happy to do it; it should be fairly easy to implement.

pickBy sounds reasonable if you have a use-case for it.

Yeah, I actually have two: one is where you want to pick objects based on a pattern in their key like beginning with an underscore and the other is where you have a nested object and you want to pick a key on basis of a something present in the nested object.

I think _.pickBy(function) the properties list is largely redundant with an arbitrary selector function.

@svozza Please open a new issue if you want to discuss pickBy further. Otherwise, feel free to make a PR!


CRA's sourcemaps don't match code in node_modules, which breaks IDE debugging

React source code inside sourcemaps generated by create-react-app adds many extra blank lines and extra indentation compared with React's node_modules source.  Because line and column numbers don't match between source maps and actual source, debuggers like VSCode don't accurately set breakpoints inside React source and can't accurately step into React source.  Debuggers like Chrome are not affected because they use the sitemap source (not the on-disk files) to set breakpoints.
This issue is the cause of #6044 that @raiskila filed 6 weeks ago. I created a new issue with a new repro to simplify the repro case, to remove the need to install VSCode to reproduce the problem, and to clarify that all file-based debuggers will be affected (not just VSCode).
It's possible that the root cause of this problem might be https://github.com/webpack/webpack/issues/8302, although I don't know enough about webpack to know for sure one way or the other.  It's also possible that the problem is caused by create-react-app's webpack configuration. It's also possible that the problem might be in how React itself is transforming its source code before publishing generated source files like react-dom.development.js to NPM.
Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes. Well, really N/A because the repro starts with npm install -g npm@latest and npx create-react-app so there are no deps to recover!
NPM version is the latest: 6.7.0
Which terms did you search for in User Guide?
sourcemap sourcemaps "source map" "source maps" mismatch whitespace line breakpoint
Environment
Environment Info:
  System:
    OS: macOS 10.14.2
    CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.14.2 - /usr/local/bin/node
    npm: 6.7.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 71.0.3578.98
    Firefox: 63.0.1
    Safari: 12.0.2
  npmPackages:
    react: ^16.7.0 => 16.7.0
    react-dom: ^16.7.0 => 16.7.0
    react-scripts: 2.1.3 => 2.1.3
  npmGlobalPackages:
    create-react-app: Not Found

Steps to Reproduce
1. Create a new app
npm install -g npm@latest
npx create-react-app sourcemap-bug
cd sourcemap-bug
npm start

2. Load the sourcemap and extract code from it

2.1 download https://localhost:3000/static/js/1.chunk.js.map (if this doesn't return a sourcemap, then try https://localhost:3000/static/js/0.chunk.js.map instead). If you're using HTTP for your CRA (I'm using HTTPS), then use http:// URLs instead of https.
2.2 find the top of the react-dom.developmment.js source in the map by searching for "react-dom.development.js\n" (without quotes) inside the sourcemap content. If it's not there, try http://localhost:3000/static/js/0.chunk.js.map instead.
2.3 starting with /** @license which should be right before the found content, copy 40-50 lines of code. Here's an example of what I copied:

/** @license React v16.7.0\n * react-dom.development.js\n *\n * Copyright (c) Facebook, Inc. and its affiliates.\n *\n * This source code is licensed under the MIT license found in the\n * LICENSE file in the root directory of this source tree.\n */\n'use strict';\n\nif (process.env.NODE_ENV !== "production") {\n  (function () {\n    'use strict';\n\n    var React = require('react');\n\n    var _assign = require('object-assign');\n\n    var checkPropTypes = require('prop-types/checkPropTypes');\n\n    var scheduler = require('scheduler');\n\n    var tracing = require('scheduler/tracing');\n    /**\n     * Use invariant() to assert state which your program assumes to be true.\n     *\n     * Provide sprintf-style format (only %s is supported) and arguments\n     * to provide information about what broke and what you were\n     * expecting.\n     *\n     * The invariant message will be stripped in production, but the invariant\n     * will remain to ensure logic does not differ in production.\n     */\n\n\n    var validateFormat = function validateFormat() {};\n\n    {\n      validateFormat = function validateFormat(format) {\n        if (format === undefined) {\n          throw new Error('invariant requires an error message argument');\n        }\n      };\n    }\n\n

2.4 Now paste that code into an editor and replace all instances of \n with a newline and \" with a regular single quote.  You should end up with code like this:

/** @license React v16.7.0
 * react-dom.development.js
 *
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
'use strict';

if (process.env.NODE_ENV !== "production") {
  (function () {
    'use strict';

    var React = require('react');

    var _assign = require('object-assign');

    var checkPropTypes = require('prop-types/checkPropTypes');

    var scheduler = require('scheduler');

    var tracing = require('scheduler/tracing');
    /**
     * Use invariant() to assert state which your program assumes to be true.
     *
     * Provide sprintf-style format (only %s is supported) and arguments
     * to provide information about what broke and what you were
     * expecting.
     *
     * The invariant message will be stripped in production, but the invariant
     * will remain to ensure logic does not differ in production.
     */

    var validateFormat = function validateFormat() {};

    {
      validateFormat = function validateFormat(format) {
        if (format === undefined) {
          throw new Error('invariant requires an error message argument');
        }
      };
    }

3. Compare the sourcemap code to actual source in node_modules/react-dom/cjs/react-dom.development.js:
/** @license React v16.7.0
 * react-dom.development.js
 *
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

'use strict';

if (process.env.NODE_ENV !== "production") {
  (function() {
'use strict';

var React = require('react');
var _assign = require('object-assign');
var checkPropTypes = require('prop-types/checkPropTypes');
var scheduler = require('scheduler');
var tracing = require('scheduler/tracing');

/**
 * Use invariant() to assert state which your program assumes to be true.
 *
 * Provide sprintf-style format (only %s is supported) and arguments
 * to provide information about what broke and what you were
 * expecting.
 *
 * The invariant message will be stripped in production, but the invariant
 * will remain to ensure logic does not differ in production.
 */

var validateFormat = function () {};

{
  validateFormat = function (format) {
    if (format === undefined) {
      throw new Error('invariant requires an error message argument');
    }
  };
}

Expected Behavior
Source is the same, which is required for VS Code's debugger breakpoints and step-into to work properly.
Actual Behavior
The "sourcemap source" has many extra blank lines compared with the "node_modules source". As a result of these whitespace differences, VSCode breakpoints won't work and VSCode will set focus to the wrong code line when stepping into React's source code.
Also, the "sourcemap source" is indented differently from the "node_modules source". This breaks columnar breakpoints in VSCode.
Note that the Chrome debugger only uses the "sourcemap source" (and ignores the actual source files) so it's not affected by this problem by default. However, if you use a Chrome devtools workspace to actually load the on-disk source files, it's possible that Chrome debugging may break too.
Refer to #6044 for screenshots demonstrating the impact on VSCode users. This issue is narrowly defined to highlight the root cause of #6044 (the mismatch in whitespace between sourcemaps code and node_modules code) without requiring VSCode to reproduce the problem.
Reproducible Demo
Repro is trivial and the problem reproduces with every create-react-app project so I'm assuming that a hosted repro is not needed. If this is a bad assumption, let me know and I'll post a repro project.

FWIW, I tested every possible value of webpack's devtool setting in https://webpack.js.org/configuration/devtool/. None of them worked. :-(
Here's the process I used for testing:

manually edit the devtool value in node_modules/react-scripts/config/webpack.config.js
npm start
started VSCode debugger
set a breakpoint at ReactDOM.render in my own code
Repeatedly do "step into" in the debugger until it gets into React's code in node_modules/react/cjs/react.development.js
By comparing to the call stack, verified that the debugger is showing the wrong line in the wrong method.
Stop debugger
CTRL+C in the terminal to quit the dev server started by npm start
Pick another devtool value and repeat from step 1

@justingrant not sure if it will make a difference to this particular bug, but note that the config for webpack's sourcemap creation was recently changed. That change fixes a different sourcemap related bug (see https://github.com/facebook/create-react-app/issues/6074#issuecomment-462087174); it might be worth seeing how it affects this one.

not stale

@justingrant the "whitespace handling" is because the CRA webpack config runs node_modules through a limited babel transformation to support ES6 packages after long and concerted demand from users.  The "bug" this issue relates to is actually another opinionated and deliberate design choice (#5096 by @Timer) which you can't get out of unless you fork or eject.  FWIW I think that options like this should be controllable without an eject.
To save you the hassle of finding it, this code is now here.

To get this to work, you need to change two things.
In the loader definition for node_modules change the value for sourceMaps to true (here).
Before the main loaders (around here) add the following:
{
  test: /\.m?js/,
  enforce: 'pre',
  use: ['source-map-loader'],
},

This is so that files in node_modules that have already been transpiled, and have source maps already, are picked up by webpack to show the original source.  Remember to add source-map-loader to your package.json!

PR #6296 is (hopefully) the solution for this issue. Please go over there for more info about the root cause and proposed solution for this problem. And while you're there, vote for it with a thumbs up! ;-)

not stale. still waiting for PR #7022 to get some attention.

Not stale. Waiting for #7022.


fix requirement on N. N must be >= K. N=K=2 is now allowed.

Is there any reason for the N > 2 requirement? I don't see any theoretical reason for not being able to do 2-out-2 secret sharing, for example. I applied the fix to allow any N >= K, and it seems to work.

Thanks!
In terms of why I disallowed it: I figured folks wanting 2/2 sharing would use a traditional scheme for n=k sharing.

Thanks. Great library btw!


XMLRPC error

I was following this installation guide http://spritelink.github.io/NIPAP/docs/config-www.html.  However, when trying to run this command "xmlrpc_uri = http://nipap-www@local:s3cret@<IP_ADDRESS>:1337" without the quotes, I received an error, "-su: xmlrpc_uri: command not found.
Help please.....

Hi, it's not a shell command but a configuration parameter to set in /etc/nipap/nipap.conf. I'll update the documentation to state this clearly.

Oh ' okay thank you very much!  :)


env VAULT_ADDR

Hello, i trying to use vault-init in a development setup, and I'm not using https.
I think the application is not respecting VAULT_ADDR env var.
Reproduce:
root@vagrant-ubuntu-trusty-64:~# echo $VAULT_ADDR
http://<IP_ADDRESS>:8200
root@vagrant-ubuntu-trusty-64:~# vault-init
2018/09/27 19:35:18 Starting the vault-init service...
2018/09/27 19:35:18 Get https://<IP_ADDRESS>:8200/v1/sys/health: http: server gave HTTP response to HTTPS client
2018/09/27 19:35:28 Get https://<IP_ADDRESS>:8200/v1/sys/health: http: server gave HTTP response to HTTPS client
2018/09/27 19:35:38 Get https://<IP_ADDRESS>:8200/v1/sys/health: http: server gave HTTP response to HTTPS client

Seth vargo fork is working well...


Replaced ping-based healthcheck with net.createConnection

Older ping-based healthcheck had a bunch of problems:

Doesn't work in ipv6-only environment (because of calling ping, not
ping6).
Doesn't work if ICMP is blocked, but TCP is not
Doesn't work as expected if TCP on this exact port is firewalled out.
Uses a lot of CPU on process spawning, may cause DoS in clusters with
large number of worker processes.

Healthcheck with net.createConnection seems to be a much simpler and
more robust alternative
Two test were needed changing:

One was implicitly tied to ping interval; ECONNREFUSED was thrown faster,
I've tuned reconnect timeout in test
Another one actually relied upon one of aforementioned problems:
setting up server at <IP_ADDRESS>:1234 would mean server is available to
ping, but not to TCP connection. In that test, I've used
net.listen to actually listen for connections on socket

Test are faililng on nodejs 4/5 because mocha@^4 uses object destructuring, which isn't supported by those versions of node.
Downgrading to mocha@^3 helps

@3rd-Eden what do you think?

@mapleeit, @kevin-greene-ck, looks like you are maintainers now?

Anyone? @3rd-Eden @mapleeit @kevin-greene-ck ?

@mutantcornholio  @3rd-Eden  Any one working to integrate this, we are in environment without  ping command, this will help us.

I've published fork here:
https://www.npmjs.com/package/memecached
https://github.com/mutantcornholio/memcached
This PR is the only difference in code now


Decide how Editor will integrate with Kriya

Recent discussions with Exeter have impacted how Editor and Kriya will integrate. The 2 options on the table either require us to work closer with Exeter, as to integrate the Editor into their toolset. Or to take more of the Editor out-of-band, and hence potentially requiring us to create an initial version of the producer dashboard as part of MVP.
We need to make a decision on our technical approach, and update plans to reflect the outcome.
DoD

[ ] A decision made as to how Editor will integrate with Kriya.
[ ] Design documentation updated to reflect technical approach.
[ ] Project backlog updated to reflect integration strategy.

Produced an initial architecture diagram for Option 2, and shared with Exeter for Comment.

Agreement reached at a high level, captured in...
https://docs.google.com/document/d/1yPEFU76Qn6b9E87RHgmlV3VgitMFHxYDdyT5NNHJ04s/edit?usp=sharing


Add reading DH5 CONT data as Fieldtrip raw data

The powerful toolbox Fieldtrip is very popular and it would be very useful to  be able to quickly read DH5 CONT data as ft_datatype_raw.

Similar to the bids_tsv in Fieldtrip for reading BIDS data, the daq_hdf5 function can be used  as dataformat, headerformat and eventformat when reading data into Fieldtrip with ft_load_data etc.

Relevant information for this

https://www.fieldtriptoolbox.org/faq/how_can_i_find_out_what_eventvalues_and_eventtypes_there_are_in_my_data/
https://www.fieldtriptoolbox.org/faq/what_is_the_relation_between_events_such_as_triggers_and_trials/
https://www.fieldtriptoolbox.org/workshop/natmeg2014/preprocessing/


Release PHP 5.6.9

Coverage decreased (-0.11%) to 58.82% when pulling 0dbb6730a9c1b1fdeb7c3f5547fee214e417c4f8 on ovr:patch-7 into d40f66d5db965437942777914dea854aef8ee74e on phpbrew:develop.

Please don't update this release list file anymore, we don't need it. Just phpbrew self-update and then run phpbrew update so phpbrew can get the release list directly from the php.net website.
Thanks for the pull request, anyway.


Follow up on min-width

https://github.com/carbon-app/carbon/pull/925#discussion_r365625312 @aquaductape

Closed with https://github.com/carbon-app/carbon/pull/925#discussion_r365626736


Load Related

Hello,
from you example:
foreach ($vehicles as $v) {
        echo sprintf("%s - %s\n", $v->name, $v->url);
		foreach ( $v->films as $film) {
                       // code?
			echo $film->title;
		}
    }

Film title on right is not populated.  What's the best manner to fill object by $film->url ?
My idea is separate id from url and use it in FilmEndpoint get method. Is there another clean way?
Thanks for you work!

Hi!
Yeah, so I wanted to do an invisible lazy-load here - where you access $v->films[0] and it goes away and gets the full Film object for you. It's a bit fiddly with JsonMapper so I'll have a think about the best way to do that.
In the meantime, I've added a method in v0.2.0 that allows you to get a resource by it's URI:
$film = $swapi->getFromUri($film->uri);

Cheers

Great! Thanks for add.


Requires download framework when installing

Hello, when I want to install the program, it says that you need to install Microsoft .Net Framework, if I install it, then I have an error, please tell me what version of the framework is needed, so I installed it myself in advance and when I installed the program, there was no request for it
Please read
https://github.com/Franiac/TwitchLeecher#support--issues
before posting anything!

The most current version should be fine, I'd say.
Currently this should be .NET Framework 4.8 (2019-04-18)

thank you, but If I install version 4.7 or 4.8, the program crashes and does not start, and if lower, it requires utsanovit 4.8, such a situation, what can I do?

Please stop opening up issues without providing the requested infos:
https://github.com/Franiac/TwitchLeecher#support--issues
Please read this and answer the questions accordingly, otherwise I will close the issues. We cannot make guessing games here.

What information should be provided?

Read the link provided by @Franiac and the preset text in new bug report form:

https://github.com/Franiac/TwitchLeecher#support--issues

Provide the version of Twitch Leecher you are using
Provide as much information about the VOD as possible (Url, Channel, ID)
Provide information about your operating system (e.g. Windows 10 64 Bit)
Try to describe the problem as detailed as possible, I cannot read your mind ;)
Is there any additional information about the issue that might be interesting for me? Write it down!
When you have a problem with a download, provide the download log created by Twitch Leecher (see screenshot below)

thank you

I'm sorry) I have version  Twitch Leecher 1.7.3 , Windows 7 64 bit, If I install .net Framework version 4.8, then when I try to install Twitch Leecher, Twitch Leecher fails: problem event Name: APPCRASH error module Name: KERNELBASE.dll program Stopped working. Additional information: If I install .net Framework 4.5, then I have sony vegas pro running, but Twitch Leecher needs .net Framework 4.8, when I install .net Framework 4.8 I also fail and sony vegas pro, yesterday I still reinstalled windows, maybe something is related to this, but before everything worked, windows is the same as it was

Please stop opening up issues without providing the requested infos:
https://github.com/Franiac/TwitchLeecher#support--issues
Please read this and answer the questions accordingly, otherwise I will close the issues. We cannot play guessing games here.

I'm sorry) I have version  Twitch Leecher 1.7.3 , Windows 7 64 bit, If I install .net Framework version 4.8, then when I try to install Twitch Leecher, Twitch Leecher fails: problem event Name: APPCRASH error module Name: KERNELBASE.dll program Stopped working. Additional information: If I install .net Framework 4.5, then I have sony vegas pro running, but Twitch Leecher needs .net Framework 4.8, when I install .net Framework 4.8 I also fail and sony vegas pro, yesterday I still reinstalled windows, maybe something is related to this, but before everything worked, windows is the same as it was

Please stop opening up issues without providing the requested infos:
https://github.com/Franiac/TwitchLeecher#support--issues
Please read this and answer the questions accordingly, otherwise I will close the issues. We cannot play guessing games here.

I'm sorry) I have version  Twitch Leecher 1.7.3 , Windows 7 64 bit, If I install .net Framework version 4.8, then when I try to install Twitch Leecher, Twitch Leecher fails: problem event Name: APPCRASH error module Name: KERNELBASE.dll program Stopped working. Additional information: If I install .net Framework 4.5, then I have sony vegas pro running, but Twitch Leecher needs .net Framework 4.8, when I install .net Framework 4.8 I also fail and sony vegas pro, yesterday I still reinstalled windows, maybe something is related to this, but before everything worked, windows is the same as it was

Read the link provided by @Franiac and the preset text in new bug report form:

https://github.com/Franiac/TwitchLeecher#support--issues

Provide the version of Twitch Leecher you are using
Provide as much information about the VOD as possible (Url, Channel, ID)
Provide information about your operating system (e.g. Windows 10 64 Bit)
Try to describe the problem as detailed as possible, I cannot read your mind ;)
Is there any additional information about the issue that might be interesting for me? Write it down!
When you have a problem with a download, provide the download log created by Twitch Leecher (see screenshot below)

thank you

If I get this right you even have problems installing .NET 4.8 from the Microsoft installer, right?
If this is the case I we cannot really help you since it is not a problem related to TL but the installation process of .NET Framework 4.8 in general.

If this is the case I we cannot really help you since it is not a problem related to TL but the installation process of .NET Framework 4.8 in general.

It's bad :( but thanks :)
Topic can be closed, the question is not on topic, if you may have ever faced with similar, I don't know what could be the problem?


bug

sometimes my bot stops moving at any random time and it loses on time cuz it doesnt move

and it didnt move in the lichess bot championships match against yobot

This is quite a common thing that occurs when the bot plays a chess game. Here are a few tips and suggestions, I hope it helps solve your issue.
Firstly to start of with, I too have faced the same problem many times and have somewhat gotten the solution to this. I have realised that when I my bot is running in chrome and I open a new tab in chrome itself, not is no issue at al that usually does occur, but if my bot is running in chrome and I open a new tab in another app or another browser (like Firefox or Safari) the same issue occurs and my bot stops playing. So I suggest while running your bot(on any browser) make sure that if you are doing some other work you do it in the same browser that you are running your bot on.
Also in rapid games I’ve realised that my bot tends to take a long time to play a move and I start doubting that it is even working. Therefore to make sure that it is working all you need to do is open the heroku app(which must be in another tab for your bot to play) and check the position of the board in the app and match it with the position of the board on lichess, and I have realised that every time the bot is working properly the position is exactly the same on lichess and in the app. Also if you feel that it is too difficult the match the position on both boards, you can check the last move which is highlighted on in all chess games. If all of this is fine then you have no issue in your bot and your bot is just pondering about the next move(ponder time is really high when in a loosing position I have noticed).
Now, if everything I said above is not the way it is supposed to be, then only there is an actual issue. In that case what works best for me is just simply refreshing the page in your browser where you have opened your heroku app. After this is done, the chess board will not be seen, so the only solution is to have patience until the next move is played. And once the next move is played automatically in your app also the chess board will be visible.
Hope this helps you in your issue.

I too have faced this same issue with respect to my bot. Here are some suggestions and tips on what to do when it occurs next time.
Firstly, this issue has happened quite often for my bot too lately and these are just some things I have noticed that has helped. I have realised that when I run my bot in a certain browser (say Chrome) and I do my personal work in another tab in the same browser (i.e. Chrome) then usually no issue occurs at all, but if I open my bot in a certain browser (say Chrome) and I do my personal work in another app or browser (like Firefox or Safari) then this issue arises. Hence I suggest that you keep the browser in which your bot is running open and do your personal work too in that browser itself.
Also I have noticed something in the heroku app created. To keep your bot running you have to keep the app open in another tab, otherwise it will not work. Also in the app you can view the chess game your bot is playing. If your bot takes a really long time to play a move and you are doubtful of whether your bot is even working, you can simply check the game in the app and in lichess and if the position of the bot is the same in the app and in lichess, there is no issue. Also if you find it difficult to match the exact position of the chess pieces in both boards, you can simply see the last move played in the game at lichess and check whether the last move (which is highlighted) in your heroku app matches. If it doesn’t match then you must immediately refresh the page in the browser in which you have opened the app. After you refresh the page, the chess board will not be shown in your heroku app until your bot plays the next move. So do have patience during that time.
I too have faced the same situation many times while my bot is playing rapid games (or higher time controls and sometimes blitz games). Making sure of what I said above can help. Many times in games where the bot has a lot of time remaining (in comparison to its opponent) or when the bot is in a loosing position it just simply takes time pondering on the next move as it knows that it is in a loosing position. So if the above points are checked and everything is running smoothly (on the basis of the above points I mentioned), then you’ll just have to have patience until your bot plays the next move.
Hope this helps!


Pass props down into SafeAreaView's nested View

this was causing a problem where we were setting pointerEvents on a SafeAreaView and it wasn't being respected

lol nope this totally breaks SafeAreaView, gonna do a new PR that only passes along pointerEvents.


Documentation

Let's add some solid documentation for this tool. I think it can be used just about anywhere that uses pyvista, and in many places that don't that simply want to compare images.
Documentation should use sphinx and follow the pydata-theme. Ping @banesullivan to create a new subdomain for this. Something like "pytest.pyvista.org".

Added the new pytest.pyvista.org subdomain. Once GitHub pages are added for this repo, point to that domain and all should work


Can I read .xls file with this Library?

When I try to read .xls file with this library, The Results are something wrong.
Is it possible to read .xls file?

XLSX I/O is only for .xlsx files.
The old .xls fileformat is completely different and will never be supported by this library.

Thank you for you Answer. :)


Docker port binding not working as per documentation (iisdemo)

The iisdemo / port binding described on https://msdn.microsoft.com/en-us/virtualization/windowscontainers/quick_start/manage_docker#create-iis-image-1- does not work in the way described there.
It's either not clear what the host is (from my understanding, it should be the actual Windows 2016 server that I run docker on, so it should be "localhost" relative from there) or the port binding isn't working.
docker run --name iisdemo -it -p 8800:80 windowsservercoreiis cmd
does not bind the port 8800 on the host. I should be able to open "localhost:8800" or "<IP_ADDRESS>:8800" on the host (<IP_ADDRESS> being the IP of the host, while <IP_ADDRESS> being the IP of the container).
Neither works a:
docker run --name iisdemo -it -p 80:80 windowsservercoreiis cmd
(Firewall rules are added, but also Windows Firewall entirely disabled just to be sure).
What's also interesting is that when I block port 80 on the host with some other service, and then start the docker container with port binding 80:80, I don't get any conflict, which I would expect though.
I can reach the IIS via the container IP, but I cannot reach it via host IP and bound port.
Original, fully detailed problem description here:
http://superuser.com/questions/1057223/windows-container-port-binding-on-windows-server-2016-not-working
Update:
In a second attempt, I used powershell instead of Docker to manage the container. I followed the documentation step by step on https://msdn.microsoft.com/en-us/virtualization/windowscontainers/quick_start/manage_powershell#create-iis-container-1-, but also with no luck. I cannot reach the IIS via the host IP and bound port, only via the container IP.

Stefan Scherer from the Docker team was able to reproduce the issue on Windows Server 2016 TP4.
https://github.com/docker/docker/issues/21558#issuecomment-202536462
Seems to be a regression in TP4 and will hopefully be gone in TP5.

@mathiasconradt Thank you for the compliment, but I'm not from the Docker team :laughing:

I verify @StefanScherer 's latest https://github.com/StefanScherer/docker-windows-box Windows 2016 TP5 still have this issue. docker run -it -p 8080:80 microsoft/iis:windowsservercore cmd bind is accessable only from external to the host machine request, but requesting external ip interface from inside of the host machine self, does not work.

I checked with the devs and they're aware of the issue. It will be fixed before Windows Server 2016 is shipped, but unfortunately I don't have a workaround for TP5.

Thanks for an update!

Can this be the reason localhost port binding doesn't work on Windows 10, too?
I can access the containers via IP but they don't expose their port to localhost.
What does work however is:
Getting the IP of the container via "docker inspect" and then doing:
C:\Program Files\docker>docker-proxy.exe -container-ip <IP_ADDRESS> -container-port 80 -host-port 8123
After that it works, but I assume docker-proxy is an "old way" to do it and it's going to be included in Hyper-V directly?

Is there any news on this? I have the same issue on Windows 10 with latest Docker 1.13 beta...

Pinging @JMesser81

It is well documented that container endpoints attached to a Windows NAT network cannot be accessed using the external (host) IP and port. Instead, if you're trying to access a container endpoint from the container host itself, you must use the internal (NAT) IP and port. This limitation is being fixed in the next release of Windows.

@JMesser81 what next release? Server? Win10?

@JMesser81 you write "cannot be accessed using external IP and port" but I can't use "localhost" or <IP_ADDRESS> to access local containers, is that the same issue?

Looking for more documentation Windows 10 container endpoints attached to the host issue on what is normal and/if there is a game plan on what is going to be fixed.  Just started with docker engine for windows but this is honestly a surprise and this thread is what comes up on google about this issue.

@pbering - not sure I understand. Are you trying to access a container endpoint from the host using <IP_ADDRESS> or loopback? Or, are you trying to access the host from a container using <IP_ADDRESS> or loopback?

@JohnPAguirre  - Here's a blog article I wrote about WinNAT capabilities and limitations. Most of the limitations I mention will be fixed in the next release.
@rs38 - Server and client are now merged so they're essentially one and the same release. Hoping to see some improvements in Windows Insider Preview (WIP) builds and possibly Windows Server previews (TBD) sometime in the new year.

@JMesser81 I'm trying to access a container endpoint from the host with localhost:8000.

@JMesser81 could you also throw the link to the blog post about "WinNAT capabilities and limitations. " that you mentioned?

https://blogs.technet.microsoft.com/virtualization/2016/05/25/windows-nat-winnat-capabilities-and-limitations/
Accessing a container endpoint from the host using localhost is not supported. You must use the internal IP address/port of the container endpoint.

Related issue requesting a timeline for this fix: https://github.com/Microsoft/aspnet-docker/issues/13

@JMesser81
Hey Jason,
any update on this one?

I would also like to know some ETA for this. It's been over a year now and this is still not done. In developer's point of view this is one of the most critical things but it seems that all the "sexier" stuff gets done.

@kallie-b  - who can provide an update. Soon :-)

@jmesser81 @kallie-b can you at least reveal if it will be for Windows Insiders first or for all? Insiders means it will be again months after users restricted by corporate policies are able to use it.

@JanneRantala--Localhost/loopback support is part of the work we're doing for our next Windows release. We just completed a release, and currently Windows is on a semi-annual release cadence. That puts the next full Windows release in the Spring.
But, as you mentioned, before then you'll have access to our newest features via the Windows Insiders program. I'll reply back to this thread when localhost/loopback support for containers is available to Windows Insiders, which should be very soon :)
Of course, as is mentioned above, while you're waiting for localhost/loopback support, you can access your containers via published port on their host using either:

The container's private IP and published port
The host's public IP and published port for the container

Hi @kallie-b any news on windows Localhost/loopback support ?

It‘s available in Windows Insider 17035 or above. So it should be part if 1803 release.

@StefanScherer I'm running Windows 10 Build 1803, but still have the same problem.  Can you confirm if this fix made it into 1803, or do I still need to use Windows Insider builds?

I tested the fix sucessfully two weeks ago with 1803. Visual Studio "deploy to docker" still does the "old" way with grabbing the "172.x.x.x." from the container config.

Strange.  I'm running the container like so:
docker run -d -v "C:\Product\src\API:C:\inetpub\wwwroot" `
-p 567:80 `
--dns-search=kitchenpc.com `
kitchenpc/api:dev

I can reach the site on the IP of the container on port 80, but I cannot reach the site on localhost:567 or <IP_ADDRESS>:567.  I'm using pure Docker commands and not Visual Studio for anything.  I'm on Windows 10 Build 1803, and am NOT on Windows Insider.

@MikeChristensen the container image must also be newer than the ltsc image.
The kitchenpc/api:dev should use the 1803 base image.

@daschott :)

Ah, so this is only supported on Windows 10 images.  I was using microsoft/aspnet:4.7.1-windowsservercore-1709  (Though I also tried microsoft/aspnet:4.7.1-windowsservercore-ltsc2016)
λ curl.exe --head http://<IP_ADDRESS>/home/
HTTP/1.1 302 Found
Cache-Control: private
Content-Length: 149
Content-Type: text/html; charset=utf-8
Location: /Login.aspx?ReturnUrl=%2fhome%2f
Server: Microsoft-IIS/10.0
X-AspNetMvc-Version: 5.2
X-AspNet-Version: 4.0.30319
WSN: E2B9870CF10D
X-Frame-Options: SAMEORIGIN
X-Powered-By: ASP.NET
Date: Wed, 23 May 2018 14:56:12 GMT

λ curl.exe --head http://localhost:8080/home/
curl: (7) Failed to connect to localhost port 8080: Timed out

Any idea when the Windows Server Core images will support this?  Thanks!

there are no "Windows 10 images"...
docker images can base on the latest semi annual core which can be servercore or nano.
simply try:
microsoft/aspnet:4.7.1-windowsservercore-1803 in your case.
By the way I do not really understand why the virtual NIC / Switch and NAT Problem resulting in not binding to localhost needs Container Host and Base Image 1803 when working in Hyper-V abstraction like mandatory for Win10.

@rs38 @MikeChristensen @StefanScherer I confirm that localhost/loopback support on Windows 10 April 2018 and Windows Server 1803 is a known issue that is actively being fixed.
Even though the functionality may work for some people, it will not work for everyone. Using a new container image is also not going to fix it unfortunately!
I will post back here once a fix is out :)

As a (perhaps not very ideal) workaround in the meantime:
If you have at least one network adapter which is connected (and does not have a 169.254.x.y IP address) localhost should work. Disabling any adapters which have a 169.254.x.y IP address assigned should make this work again.
Otherwise, you should be also able to access the exposed service using http://:hostport

Odd.  I don't have any 169.x.x.x addresses, yet localhost doesn't work (on Windows 10 host and aspnet:4.7.1-windowsservercore-1709 image).   I can reach the port from another computer on network (goes to 192.168 IP).

I am still a bit confused because I thought I already had that running and tested that app bound at locahost.
Currently I can reach the container (either 1709 or 1803 nano based, they behave the same) locally on my static IP, which is okay:
docker run -d -p 8001:80 rs38/hellonano1803
wget http://surfacebook:8001

Win10 1803
IPv4/v6 does not relate to that?

@lahma https://github.com/moby/moby/issues/36990

Hi, @MikeChristensen @rs38 @StefanScherer. We backported the container localhost/loopback access fix for Windows April 2018 Update (Windows 10 version 1803) through KB4340917, available now.
To validate this fix, you can use docker run -p 8080:80 microsoft/iis command. Once the container is running, you should be able to use loopback and access the container using http://localhost:8080 or http://<IP_ADDRESS>:8080.

Confirmed this works on Windows 10 with latest updates.  Thanks!!

@daschott has the fix been ported to Windows Server, version 1803

see this previous comment
This should work for you on 1803 with the KB4340917 now :)

Fixed in 1803.  See  KB4340917


Spyder-terminal cannot be installed in Python 3.8 or 3.9

Description of your problem
The Spyder-terminal installer needs to do version checks for Python and Spyder FIRST, warn the user, and stop if they are not using Python 3.6 or Python 3.7.
We need much clearer documentation for Spyder-Terminal on this Github.com home page too.    It must state WHICH versions of Spyder and Python that Spyder-Terminal v0.5.x requires.
Right now spyder-terminal installation requires a lot of trial-and-MANY-errors to learn that Spyder-terminal only works with Spyder v4.2 and NOT Spyder v5.0.3.
You must use Python 3.6 or 3.7 (and NOT v3.8.x or v3.9.x) in a new conda virtual environment, and install spyder-terminal there.
Create a new conda environment with Python 3.6 and install spyder-terminal and spyder-notebook there.
The correct version of Spyder will be installed along with all of its dependencies.
Use the following commands...
conda create -n python36 -c conda-forge python=3.6
conda install spyder-terminal -c conda-forge spyder-ide
conda install spyder-notebook -c conda-forge spyder-ide

What steps will reproduce the problem?

try installing into an Anaconda distribution with Python 3.8 or Python 3.9 kernels
Wait a long time and get many errors.
Rip out a few locks of hair (preferably someone else's)
Start over after you read the instructions above.

What is the expected output? What do you see instead?
errors lost when I closed the installation console
Versions and main components

Terminal Version:  spyder-terminal-0.5.0 (spyder-ide/win-64)
Spyder Version:  '4.2.5'
Python Version:  3.8 or 3.9
Operating system:  Windows 10

Hey @richdevboston, thanks for reporting. We'll verify that Spyder-terminal can be installed in those Python versions in our next release.

Hi @richdevboston,
We just made the release 1.0.0 for the terminal compatible with Spyder 5.0.5. Please update your Spyder and install the latest version available from pip and conda-forge channel in conda.
Thanks for reporting!

What versions of Python is this update compatible with?
Thank you.
Best Regards,
Rich Lysakowski, Ph.D.
Data Scientist, Analytics Engineer,
and Senior Business Analyst
781-640-2048 mobile
On Wed, Jul 7, 2021 at 7:23 PM Stephannie Jimenez Gacha <
@.***> wrote:

Hi @richdevboston https://github.com/richdevboston,
We just made the release 1.0.0 for the terminal compatible with Spyder
5.0.5. Please update your Spyder and install the latest version available
from pip and conda-forge channel in conda.
Thanks for reporting!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder-terminal/issues/269#issuecomment-875998689,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHJVLYOE65QRXZNFI4NODLTWTOYLANCNFSM467MO3CA
.

With Python 3.6, 3.7, 3.8 and 3.9


fix: missing errors in MA agent loop

Description
fix 2 places where the error is not being yielded
Risk

Deploy Plan

🙏🏻


Cannot running GNN+Transformer model

Hi,
This error happened only in GNN+Transformer model.
Let's use 1 GPU!
--- Data Preparation ---
--- Go for Training ---
Traceback (most recent call last):
File "Pharos_DeepPurpose_ATFP_clf_demo.py", line 103, in
trainModel(coding)
File "Pharos_DeepPurpose_ATFP_clf_demo.py", line 96, in trainModel
model.train(train, val, test)
File "/home/data/aidd/DeepPurpose/DeepPurpose/DTI.py", line 436, in train
score = self.model(v_d, v_p)
File "/home/AIDD/anaconda3/envs/DeepPurpose/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/data/aidd/DeepPurpose/DeepPurpose/DTI.py", line 52, in forward
v_f = torch.cat((v_D, v_P), 1)
RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 512 but got size 2 for tensor number 1 in the list.

Could you send code to reproduce error?

Thank you for reply. I definited my own dataset, also ,the same error happened when I run the benchmark dataset.
import os
import pandas as pd
import numpy as np
os.environ['CUDA_VISIBLE_DEVICES'] = "1"
import DeepPurpose.DTI as models
from DeepPurpose.utils import *
from DeepPurpose.dataset import *
from DeepPurpose import utils, DTI, dataset
CODING_TYPE = ["0"]
def dataLoader():
X_drugs, X_targets, y = dataset.load_Pharos(binary=True)
return X_drugs, X_targets, y

def createModel(coding):
X_drugs, X_targets, y = dataLoader()

if coding == "0":

    drug_encoding = 'DGL_GIN_AttrMasking'
    target_encoding = 'transformer'
    train, val, test = utils.data_process(X_drugs, X_targets, y,
                            drug_encoding, target_encoding,
                            split_method='random',frac=[0.7,0.1,0.2],
                            random_seed = 1)
    config = utils.generate_config(drug_encoding = drug_encoding,
                     target_encoding = target_encoding,
                     cls_hidden_dims = [1024,1024,512],
                     train_epoch = 150,
                     LR = 0.001,
                     batch_size = 512,
                     hidden_dim_drug = 128,
                     mpnn_hidden_size = 128,
                     mpnn_depth = 3,
                     cnn_target_filters = [32,64,96],
                     cnn_target_kernels = [4,8,12]
                    )
    model = models.model_initialize(**config)

return train, val, test, drug_encoding, target_encoding, model

def trainModel(coding):
train, val, test, drug_encoding, target_encoding, model = createModel(coding)
model.train(train, val, test)
model.save_model('./Pharos_model/'+drug_encoding+"-"+target_encoding+"_clf")

if name == "main":
for coding in CODING_TYPE:

    trainModel(coding)

Are you using multiple GPUs? could you try a single GPU? also, does other combination work?


Issues observed in Account List command

Environment info
NooBaa Version: 5.15
Platform: Linux
1.All Account should be listed with all the details present in the manifest
Actual Behaviour:
Command :
[root@ramya-sc-worker noobaa-core]# node src/cmd/manage_nsfs account list --config_root /ibm/fs1/ces/s3-config
Oct-25 23:17:32.074 [/2859127]   [LOG] CONSOLE::  [ { name: 'noobaa' } ]
Expected Behaviour:
Command :
[root@ramya-sc-worker noobaa-core]# node src/cmd/manage_nsfs account list --config_root /ibm/fs1/ces/s3-config
Oct-25 23:17:32.074 [/2859127]   [LOG] CONSOLE::  [ { name: 'noobaa' ,config_root:/ibm/fs1/ces/s3-config,email:noobaa@gmail.com,new_buckets_path:/ibm/fs2  } ]
2. Account details should be listed with particular accountName
Actual Behaviour:
Command :
[root@ramya-sc-worker noobaa-core]# node src/cmd/manage_nsfs account list --config_root /ibm/fs1/ces/s3-config
Oct-25 23:17:32.074 [/2859127]   [LOG] CONSOLE::  [ { name: 'noobaa' } ]
Expected Behaviour:
Command :
[root@ramya-sc-worker noobaa-core]# node src/cmd/manage_nsfs account list --config_root /ibm/fs1/ces/s3-config —name noobaa
Oct-25 23:17:32.074 [/2859127]   [LOG] CONSOLE::  [ { name: 'noobaa' ,config_root:/ibm/fs1/ces/s3-config,email:noobaa@gmail.com,new_buckets_path:/ibm/fs2  } ]

@guymguym @romayalon . Please take a look of this issue. Thank you.

The following are api exposed for ocp for list accounts the api should work similar to this
Api: "account_api", Method: "read_account",
			Params: getAccountParamsNoobaaRequest{
				Email: name,
			},

Api: "account_api", Method: "list_accounts",

Api: "account_api", Method: "list_accounts",
			Params: getAccountNoobaaRequestParams{
				Filter: getAccountNoobaaRequestFilter{
					Fs_identity: getAccountNoobaaRequestFsIdentity{
						Uid: uid,
						Gid: gid,
					},
				},
			},


Triple dot context menu opening button in Extensions view ignores every other click

VS Code version: Code 1.23.0 (7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45, 2018-05-03T16:44:55.614Z)
OS version: Windows_NT x64 10.0.16299

Steps to Reproduce:

Go to the Extensions view on Windows (maybe on other platforms?)
Click the triple dot menu and observe it working
Click the triple dot menu and observe it not working
Click the triple dot menu and observe it working
Click the triple dot menu and observe it not working
Click the triple dot menu and observe it working
Click the triple dot menu and observe it not working
Go to 2

@vscodebot Microsoft/vscode#45356 is a feature request, not a duplicate and it has to do with the Integrated Terminal pane, not the Extensions pane. You're not the brightest lightbulb out there.


Wrong window size is used in next tests after using I.resizeWindow()

What are you trying to achieve?
run tests on different viewports
What do you get instead?
I have several tests in my suit. most of them use window size set in codecept.conf.js. But in some tests in Before hook I have I.resizeWindow(375, 812). what I get is:

firstly some tests with default viewport are executed
then a test with I.resizeWindow(375, 812) is executed
after this ALL tests (even without I.resizeWindow() command) are executed on (375, 812) window size.

I was only able to stop this behavior with restart: true,
Details

CodeceptJS version: 2.6.8
NodeJS Version: 12.6.3
Operating System: Mac OS Mojave / Ubuntu
Playwright 1.3.0
Configuration file:

const { setHeadlessWhen } = require("@codeceptjs/configure")

// turn on headless mode when running with HEADLESS=true environment variable
// HEADLESS=true npx codecept run
setHeadlessWhen(process.env.HEADLESS)

exports.config = {
  tests: "./tests/*.js",
  output: "./output",
  helpers: {
    Playwright: {
      url: process.env.URL || "https://some.url",
      browser: "chromium",
      show: true,
      restart: true,
      windowSize: "1440x900",
      chromium: {
        args: [
          "--no-sandbox",
          "--disable-dev-shm-usage",
        ],
        defaultViewport: {
          width: 1440,
          height: 900,
        },
      },
      waitForAction: 200,
      waitForNavigation: "load",
      getPageTimeout: 30000,
      waitForTimeout: 5000,
    },
    ChaiWrapper: {
      require: "codeceptjs-chai",
    },
    ifElementExists: {
      require: "./helpers/ifElementExists.js",
    },
    extendWithPlaywright: {
      require: "./helpers/accessPlaywright.js",
    },
    REST: {
      // endpoint: config.url,
    },
  },
  multiple: {
    basic: {
      browsers: ["chromium"],
    },
    firefox: {
      grep: "@firefox",
      browsers: ["firefox"],
    },
  },
  include: {
    // some files here
  },
  bootstrap: null,
  mocha: {},
  name: "web-app-tests",
  plugins: {
    retryFailedStep: {
      retries: 3,
      enabled: true,
      defaultIgnoredSteps: ["amOnPage", "wait*"],
    },
    screenshotOnFail: {
      enabled: true,
    },
    customLocator: {
      enabled: true,
      attribute: "data-testid",
    },
  },
}

What about 3.1.0?
still there?

@DavertMik
I have the same issue with viewport when opened new tab. It resised to default value.
It looks like the context is lost when opening a new tab.
It ease to test - open any page in browser and click to add new tab.
my packages:
playwright: 1.17.1
codeceptjs: 3.2.2


Make harness return performance results

As discussed in #109 there is an opportunity to connect OpenTuner
to tune parameters for existing experts.
This change makes test_harness return performance result as a nested
dictionary that contains the same information as what's currently
printed to stdout. As the result, it can be invoked programmatically.

/cc @giuseros

Please rebase on #121, this should solve the CI brekage.


Carthage not working

Build is failing when running either
$carthage update --platform iOS
I also tried
$carthage update --platform iOS --no-use-binaries
as suggested in a stackoverflow question. However, I had the same result:
*** Fetching jsonmodel
*** Checking out jsonmodel at "1.7.0"
*** xcodebuild output can be found in /var/folders/tx/rp4f94cn3l796g97x6xv4d400000gn/T/carthage-xcodebuild.ZwuYbV.log
*** Building scheme "JSONModel" in JSONModel.xcodeproj
** BUILD FAILED **
The following build commands failed:
CompileC /Users/name/Library/Developer/Xcode/DerivedData/JSONModel-ahcpxzxnjollwnbaxethcepkowhj/Build/Intermediates/JSONModel.build/Release-iphoneos/JSONModel.build/Objects-normal/armv7/JSONHTTPClient.o JSONModel/JSONModelNetworking/JSONHTTPClient.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
A shell task (/usr/bin/xcrun xcodebuild -project /Users/name/repo/project/Carthage/Checkouts/jsonmodel/JSONModel.xcodeproj -scheme JSONModel -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **
The following build commands failed:
CompileC /Users/name/Library/Developer/Xcode/DerivedData/JSONModel-ahcpxzxnjollwnbaxethcepkowhj/Build/Intermediates/JSONModel.build/Release-iphoneos/JSONModel.build/Objects-normal/armv7/JSONHTTPClient.o JSONModel/JSONModelNetworking/JSONHTTPClient.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
I'm attaching log file:
carthage-xcodebuild.ZwuYbV.log.zip

#572


Single 3D pass optimisation for mobile renderer

The 3D rendering logic performs 3 passes:

Opaque
Sky
Transparent
Then copies the end result into the Viewport buffer applying post effects.

On mobile devices having these 3 steps split is causing bottlenecks. This PR attempts to merge them into a single pass when possible.

This needs a lot of cleanup still, pretty much just a proof of concept atm to test if this indeed has benefits.

Wondering whether that's Vulkan-only or GLES, too?

Wondering whether that's Vulkan-only or GLES, too?

It's Vulkan-only.

Wondering whether that's Vulkan-only or GLES, too?

Only Vulkan

@clayjohn do you think splitting updating the half and quarter buffers the way I've done is the right approach? Also any ideas on making this nicer? It feels like a lot of double work while most of it is just setup.

Need to do some testing but the subpass approach we're working on likely makes this approach obsolete.

With the subpass implementation merged this is no longer relevant


Mallet doctests fail in some situations

There are two mallet doctests that sometimes fail when I run them either using pytest in the checked-out project’s root directory, see the test output below.
I’ve also manually run the commands in the project root, and this also fails:
In [1]: from dariah_topics.utils import Mallet
In [2]: tokenized_corpus = [['this','is','a','tokenized','document']]
In [3]: document_labels=['document_label']
In [4]: mallet = Mallet(corpus_output='.')
In [5]: mallet_corpus=mallet.import_tokenized_corpus(tokenized_corpus, document_labels)
[Same OSError about missing files as below]

Running the same code in an empty directory (with the same virtualenv) does work, and it produces the text file as well as the expected corpus.mallet.
I see multiple issues here:

the tests fail for no obvious reason
there is no message from mallet, not even an error message. Should not be. Should be logged as ERROR when mallet fails, or be part of the exception
the tests clutter the current (i.e. project) directory

As for 3., I think this simply should not be a doctest. Pytest has fixtures to provide a proper working directory, so we should write this as a proper test.
dariah_topics/utils.py:239 ([doctest] dariah_topics.utils.Mallet.import_tokenized_corpus)
279                 False.
280
281         Returns:
282             The absolute path to the created MALLET corpus file.
283
284         Example:
285             >>> tokenized_corpus = [['this', 'is', 'a', 'tokenized', 'document']]
286             >>> document_labels = ['document_label']
287             >>> mallet = Mallet(corpus_output='.')
288             >>> mallet_corpus = mallet.import_tokenized_corpus(tokenized_corpus, document_labels)
UNEXPECTED EXCEPTION: OSError('MALLET did not produce any output files. Maybe check your args?\nMissing files:\n - ./corpus.mallet\nPresent files: \n - \nWorking dir /home/tv/git/Topics',)
Traceback (most recent call last):

  File "/usr/lib/python3.6/doctest.py", line 1330, in __run
    compileflags, 1), test.globs)

  File "<doctest dariah_topics.utils.Mallet.import_tokenized_corpus[3]>", line 1, in <module>

  File "/home/tv/git/Topics/dariah_topics/utils.py", line 300, in import_tokenized_corpus
    _check_mallet_output(os.path.join(self.corpus_output, 'corpus.mallet'))

  File "/home/tv/git/Topics/dariah_topics/utils.py", line 163, in _check_mallet_output
    "\nWorking dir " + os.getcwd())

OSError: MALLET did not produce any output files. Maybe check your args?
Missing files:
 - ./corpus.mallet
Present files:
 -
Working dir /home/tv/git/Topics

/home/tv/git/Topics/dariah_topics/utils.py:288: UnexpectedException

dariah_topics/utils.py:304 ([doctest] dariah_topics.utils.Mallet.train_topics)
376             beta (float): Smoothing parameter for each topic-word. Defaults to 0.01.
377
378         Returns:
379             None.
380
381         Example:
382             >>> tokenized_corpus = [['this', 'is', 'a', 'tokenized', 'document']]
383             >>> document_labels = ['document_label']
384             >>> mallet = Mallet(corpus_output='.')
385             >>> mallet_corpus = mallet.import_tokenized_corpus(tokenized_corpus, document_labels)
UNEXPECTED EXCEPTION: OSError('MALLET did not produce any output files. Maybe check your args?\nMissing files:\n - ./corpus.mallet\nPresent files: \n - \nWorking dir /home/tv/git/Topics',)
Traceback (most recent call last):

  File "/usr/lib/python3.6/doctest.py", line 1330, in __run
    compileflags, 1), test.globs)

  File "<doctest dariah_topics.utils.Mallet.train_topics[3]>", line 1, in <module>

  File "/home/tv/git/Topics/dariah_topics/utils.py", line 300, in import_tokenized_corpus
    _check_mallet_output(os.path.join(self.corpus_output, 'corpus.mallet'))

  File "/home/tv/git/Topics/dariah_topics/utils.py", line 163, in _check_mallet_output
    "\nWorking dir " + os.getcwd())

OSError: MALLET did not produce any output files. Maybe check your args?
Missing files:
 - ./corpus.mallet
Present files:
 -
Working dir /home/tv/git/Topics

/home/tv/git/Topics/dariah_topics/utils.py:385: UnexpectedException

Ah, now I see what happens: When I run mallet import-dir --input . --output corpus.mallet, I get an OutOfMemoryError after a while. Appearently, mallet tries to parse not only the files from the test but the whole working directory, probably including tox’ virtualenvs etc.
BTW Mallet class should log (debug level?) the exact command line it uses to call mallet in order to make debugging easier


Annotate field usage in DVPI stage_table_dict

To allow sorting of stage columns in the table by usage, we need the list of column classes, a field is used in at the stage_column_dict

Implemented and tested


'this' not inferred for immediately invoked .bind()/.call()/.apply()

Bug Report

🔎 Search Terms

function type inferrence, function apply function, function call function
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about type inference

⏯ Playground Link

Playground link with relevant code
💻 Code

let f2 = function(this: number[]) {
    console.log(this)
}.bind([1, 2, 3]);
// ^^ works fine

let f1 = function() {
    console.log(this)
// ^^ 'this' implicitly has type 'any' because it does not have a type annotation.
}.bind([1, 2, 3]);

🙁 Actual behavior

Compiler shows an error: "'this' implicitly has type 'any' because it does not have a type annotation."
🙂 Expected behavior

The type of this to be correctly infered from the bind, call or apply call.

We do inference based on arguments of IIFEs, but that's because IIFEs are common. I've never seen this pattern in the wild. Is there a use-case for this?

You need arguments (which is obviously not in arrow functions) but you want this to not change.


Fix timer keeps active when resampling disabled in some cases

There are two purposes for this PR:
1.  Cancel  the timer when all resamplers are stopped.  The problem will  occur like this:

a developer set resamplingEnabled to true.
If need, a periodic timer will be started . If event.timestamp > sampleTime, the timer will not be canceled, such as https://github.com/flutter/engine/pull/30422,  timestamp of a fake event is much more than sampleTime.
Then, the developer set resamplingEnabled to false.
While the periodic timer is still active,  therefore the _handleSampleTimeChanged and _resampler.stop()  will be executed in a loop.

2. Add tests for https://github.com/flutter/engine/pull/30422.

If using system startup timestamp, the fake event can flush the ongoing event successfully.
If using  since1970 timestamp, the fake event fails to flush the ongoing event.
The event.timestamp > endTime will always be true, so that the timer for resampling will keep active for a very long time.
Moreover, the test case is finished while timer not be canceled, so that an assert exception  with "A Timer is still pending even after the widget tree was disposed" message will be thrown .

Gold has detected about 6 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 41 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 30 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 49 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 50 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 37 new digest(s) on patchset 6.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 12 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/97197

Gold has detected about 49 new digest(s) on patchset 8.
View them at https://flutter-gold.skia.org/cl/github/97197

@wangying3426 Looks like this PR is addressing two different issues? Can you please split it in two so we can evaluate (and land) them seperatly?

Gold has detected about 24 new digest(s) on patchset 9.
View them at https://flutter-gold.skia.org/cl/github/97197

@goderbauer  I have modify this PR to focus only one issue.

@wangying3426 Can you rebase this to the latest master to make the checks pass, please?

Gold has detected about 38 new digest(s) on patchset 11.
View them at https://flutter-gold.skia.org/cl/github/97197

@wangying3426 Can you rebase this to the latest master to make the checks pass, please?

@goderbauer I have merged master branch, but it still seems to have some tests failed.

Restarted the tests, let's see if it was just flakes...

@goderbauer Could you please also review this related PR https://github.com/flutter/engine/pull/30422 ？ thanks.

@wangying3426 It would be best to have that one reviewed by an engine expert.


[MAJOR] don't reimplement native closest

Not sure if new polyfill is a major semver change, but just in case.
As we already in game with polyfills it makes no sense to reimplement native Element.prototype.closest here.

@jshjohnson need to add Element.prototype.closest also to settings in #709, if that one will be merged first


fix typo

@lengyijun Can you squash these commits together? Then I'll r+ this.

:pushpin: Commit 8adb250841080d521b6bb742b44ba40072a6c8b4 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 8adb250841080d521b6bb742b44ba40072a6c8b4 with merge c7f7bc0ca2031cb33b8def2422fa973a8ec0b945...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing c7f7bc0ca2031cb33b8def2422fa973a8ec0b945 to master...

Merged in aebfbf2a91606d9a6f39005aee72725d867fd2fd


Reporting module name in log

With the introduction of the modules, it has introduced a necessary context that should be tracked in the logs.  Right now, when requests come in you can't differentiate with module or storage provider is responding to the request.
This log was generated from a single docker instance talking with three volume endpoints that are all pointing to the same storage platform.
I believe this is part of some of the 0.4 changes that @akutz has planned re context, but wanted to make sure we track it.
time="2016-02-12T15:50:26Z" level=info msg="getting volume" driverName=docker volumeName=newvol2001
time="2016-02-12T15:50:26Z" level=info msg="getting volume" driverName=docker volumeName=newvol2001
time="2016-02-12T15:50:32Z" level=info msg="getting volume" driverName=docker volumeName=newvol2001

Hi @clintonskitson,
I opened a PR where I implemented a short-term fix for this.

https://github.com/emccode/rexray/pull/296


Error downloading version: 'TarFile' object is not an iterator

Hello,
Since commit f95de48 - Resolve all py3 compat warnings, integrated in release 2.3.3, I have a TypeError when downloading and extracting cassandra: WARNING Downloading 2.2.1 failed, due to 'TarFile' object is not an iterator. Trying to build from git instead.
I ran the function repository.download_version('2.2.1') locally to get a full traceback:
14:34:26,877 ccm INFO Extracting /tmp/ccm-kzjt40s_.tar.gz as version 2.2.1 ...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/ccm/ccmlib/repository.py", line 278, in download_version
    dir = next(tar).name.split("/")[0]
TypeError: 'TarFile' object is not an iterator

It seems that next can not be called on a TarFile object. So I am puzzled why this change was made 2 weeks ago.
I use python 3.5.2

Fixed in  5143a76213f12cb114c561f96fff28881ef3ddd4 thanks!


Remove per-service loggers

Motivation:

ServiceConfig.loggerName() and ServiceRequestContext.logger() have
been deprecated since long ago.
LoggerFactory.getLogger() is currently invoked on each request to
create a new Logger, which may have performance impact on a certain
logging framework, such as Log4J2, as reported in #2306.

Modifications:

Remove:

Server{Builder,Config}.serviceLoggerPrefix()
ServiceConfig.loggerName()
ServiceRequestContext.logger()

The default Logger of LoggingService is now:
LoggerFactory.getLogger(LoggingService.class)
Add RequestContext.makeContextAware(Logger)

Move RequestContextAwareLogger from server to common

Make the logging implementations in LoggingDecorators log the
current RequestContext.
Remove unnecessary RequestLogListener instantiations in Logging{Client,Service}.

Result:

A user can prepend the current RequestContext to log messages by
using RequestContext.makeContextAware(Logger).
(Breaking) The following properties and/or methods have been removed:

Server{Builder,Config}.serviceLoggerPrefix()
ServiceConfig.loggerName()
ServiceRequestContext.logger()
Use your own logger or consider using RequestContext.makeContextAware(Logger).

LoggingClient now always prepend the current RequestContext to the
log message.
Slightly reduced memory footprint in Logging{Client,Service}

@ylgrgyq You might want to review this, too.

Thanks! 👍 🎉


VALIDATION fixes

Docs Build status updates of commit 8e3939a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8e3939a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/sql.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

docs-ref-conceptual/includes/sql.md

Line 6, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'sql'(docs-ref-services/latest/sql.md(89,1) -> docs-ref-conceptual/includes/sql.md(6,1))) are not allowed. You can only have one top-level heading.
Line 6, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'sql'(docs-ref-services/preview/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(6,1))) are not allowed. You can only have one top-level heading.
Line 6, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'sql'(docs-ref-services/legacy/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(6,1))) are not allowed. You can only have one top-level heading.
Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'sql' is duplicated with other articles: 'docs-ref-conceptual/includes/sql.md(6,1), docs-ref-conceptual/includes/sql.md(6,1)'. First level headings must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 249dde8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 249dde8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/sql.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

docs-ref-conceptual/includes/sql.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 81f1da0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/sql.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

docs-ref-conceptual/includes/sql.md

Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'SQL resources'(docs-ref-services/legacy/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'SQL resources'(docs-ref-services/latest/sql.md(89,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'SQL resources'(docs-ref-services/preview/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SQL resources' is duplicated with other articles: 'docs-ref-conceptual/includes/sql.md(7,1), docs-ref-conceptual/includes/sql.md(7,1)'. First level headings must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cc3e74c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/sql.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

docs-ref-conceptual/includes/sql.md

Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/legacy/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/latest/sql.md(89,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/preview/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Azure SQL resources' is duplicated with other articles: 'docs-ref-conceptual/includes/sql.md(7,1), docs-ref-conceptual/includes/sql.md(7,1)'. First level headings must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

NOTE: multiple-h1s is not the case. In the warning, multiple other files are pointing to the same file. The file itself only has one H1. For duplicate-h1s, the two files listed are in fact the same file.

Docs Build status updates of commit 557f701:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/sql.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

docs-ref-services/legacy/sql.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/preview/sql.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-conceptual/includes/sql.md

Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/latest/sql.md(89,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/preview/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Azure SQL resources'(docs-ref-services/legacy/sql.md(86,1) -> docs-ref-conceptual/includes/sql.md(7,1))) are not allowed. You can only have one top-level heading.
Line 7, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Azure SQL resources' is duplicated with other articles: 'docs-ref-conceptual/includes/sql.md(7,1), docs-ref-conceptual/includes/sql.md(7,1)'. First level headings must be unique within a docset.

docs-ref-services/legacy/sql.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 11, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ramyar' is not a valid Microsoft alias.

docs-ref-services/preview/sql.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 11, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ramyar' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@sima-zhu
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!
NOTES:
*Multiple-h1s is not the case. In the warning, multiple other files are pointing to the same file. The file itself only has one H1. For duplicate-h1s, the two files listed are in fact the same file.
*Additional fixes for the following files are covered in the following PRs:
docs-ref-services/legacy/sql.md https://github.com/Azure/azure-docs-sdk-java/pull/2242
docs-ref-services/preview/sql.md https://github.com/Azure/azure-docs-sdk-java/pull/2240

Global effort to fix build validation errors
@sima-zhu
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!
NOTES:
*Multiple-h1s is not the case. In the warning, multiple other files are pointing to the same file. The file itself only has one H1. For duplicate-h1s, the two files listed are in fact the same file.
*Additional fixes for the following files are covered in the following PRs:
docs-ref-services/legacy/sql.md https://github.com/Azure/azure-docs-sdk-java/pull/2242
docs-ref-services/preview/sql.md https://github.com/Azure/azure-docs-sdk-java/pull/2240

#sign-off


Fix position of menu icons

Currently, the game menu icons move with the screen (such as the sword icon for bringing up the artes menu). We'd like to lock it down to not move at all.

Fixed by commit 9b0541cb85a605a3b0414d402c8e0bfaeb3c40e9.


Documentation - React example (using state value for a transition)

Bug
Description:
In the react gallery app example, line 78. When calling the transition method, the value being used for the current state is stateValue, not the stateNode. If you use this approach and try to access history, it will return the wrong state, see here.
Potential fix:
Use getState() method (when made available) to calculate the current state for a transition.

Refer to https://xstate.js.org/docs/recipes/react.html (will eventually rework React gallery example).