Frontend: Show all text fields.

The pilots need this to judge, how cluttered their pages will be. Other (non-text) fields might be good, as well.

I commented on this here
I think we should work the other way round. Find out what information the pilots really need to display and then make sure the page is not cluttered. It should not be up to the pilots to not clutter the page, the design should prevent it.

In any case: They want to see the end-result when writing their texts and I think this is the next important point for the front-end.

Well, right now, there is no text field on the city page. Maybe, we can just start of with one or some of them.
The idea of task.summary was, to place it on the card for that task of the city / sector page directly above it, i.e. be very short, while all other texts shall go on the detail page and may even be hidden when opened initially.

Would you have time for a video chat in the next days? I think this is something, a small group (maybe just the two of us) can flesh out a little bit. But I would be happy if you put some stuff out there and we wait till the pilots enter more data.

@mdrie you briefly showed something at the last meeting sketching an idea of how to place the text fields. Can I find that somewhere? Can you commit that to a branch for me to look at?

This has a lot in common with #188. To keep it simple, I will mark this as...
Duplicate of #188


Listener question (bug ?)

Hey, sorry for disburbing, is there a way or an event to listen to Object change (for example when I call RBucket.set(something) ?
If no, what do you advise me to use instead ?
Thanks in advance ! :)

just subscribe to PUBLISH __keyspace@0__:mykey set via RTopic object

just subscribe to PUBLISH __keyspace@0__:mykey set via RTopic object

Thanks again, really good software !

org.redisson.api.SetObjectListener added

org.redisson.api.SetObjectListener added

Oh really cool ! Is there just a place to get the jar file or should I build it in my ways ? :)

And just for info, your advise about how to subscribe a value by a key doesn't work correctly for me :/
//1
RBucket<Integer> rBucket = redissonClient.getBucket("test");
rBucket.addListener((ExpiredObjectListener) s -> {
    System.out.println("event 1");
});

//2
redissonClient.getPatternTopic("PUBLISH __keyspace@0__:test expired",StringCodec.INSTANCE).addListener(Integer.class, (charSequence, charSequence1, integer) -> {
    System.out.println("event 2");
});

//3
Task.repeat(0, 50, true, (taskId) -> {
    rBucket.set(RandomTools.getRandomInteger(10000), 1, TimeUnit.SECONDS);
});

First paragraph represents the registration via the api, works correctly !
Second paragraph represents logically the same registration in another way, following your comment (I also tested with getTopic() and oher commands (del, set, etc) doesn't work.
Third paragraph should be ignored, just a task from my own mehods, that occurs every 2.5 seconds.
Thanks in advance for your help and sorry for disturbing if I made a mistake ! :)

getPatternTopic("PUBLISH keyspace@0:test expired")

it has wrong topic, try follow: "__keyspace@*:expired"

getPatternTopic("PUBLISH keyspace@0:test expired")

it has wrong topic, try follow: "__keyspace@*:expired"

Doesn't work either :/ But don't worry, I'll wait for a release or a jar with SetObjectListener, it's enough for my use :)

Did you set notify-keyspace-events = E$ Redis setting

Yes ^^

Did you try to set org.redisson.api.ExpiredObjectListener to catch expired events?

Did you try to set org.redisson.api.ExpiredObjectListener to catch expired events?

Yes, that's the first paragraph of my code above, and it's perfectly working, but I need "manual" catch for events that are not in the api (like set event if you added it) :)

Nevermind, it's working with SetObjectListener, thanks again :)

Hey !
Sorry for reopening this issue / question but whould be great if you could add the same opportunities for a List (when an element is added for example).
Thanks in advance ! :)

Done

Hey, sorry for disturbing,
With the new event ListRemoveListener, is there a way to get the deleted element or not ?
Thanks in advance :)

@Aurelien30000
Just call RList.removeListener() method


Patched Task Class

Needed to add a new push function to the task class to allow the windows example to build - with the delayed tasks queues.
Also inlined the task classes member functions to try improve speed - referring to PR below on discussion of performance.
https://github.com/WeSpeakEnglish/ANTIRTOS/pull/2

Unfortunately figured out, that broad majority of Arduino boards have no ported std library (Arduino UNO, NANO, etc..)  ...
Probably will return to 'old' version on this main branch.


[Snyk] Upgrade html-snapshots from 1.2.0 to 1.3.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade html-snapshots from 1.2.0 to 1.3.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a day ago, on 2022-10-24.

Release notes

Package name: html-snapshots

1.3.0 - 2022-10-24add puppeteerLaunchOptions

1.2.0 - 2022-10-14major dependency update

    from html-snapshots GitHub release notes

Commit messages

Package name: html-snapshots

a49fd66 Merge pull request #181 from localnerve/rc-1.3.0
5f9d602 @ 1.3.0, add puppeteerLaunchOptions, update deps
ca25324 @ 1.3.0, add puppeteerLaunchOptions, update deps
99ca466 Merge pull request #178 from localnerve/snyk-upgrade-aa3117416518a939dec98f907ce31323
2648b50 fix: upgrade html-snapshots from 1.1.0 to 1.2.0
c2a802b Merge pull request #177 from localnerve/snyk-upgrade-6d96c4f709194e3cdeb78ac2affe3705
18bb593 fix: upgrade html-snapshots from 1.1.0 to 1.2.0
4da10ca Merge pull request #176 from localnerve/snyk-upgrade-5c69c05b63d0fe58f8991ca9d391df9a
bbbd07c fix: upgrade html-snapshots from 1.1.0 to 1.2.0
2c573bf Merge pull request #175 from localnerve/snyk-upgrade-5aee78d6ccb4d72c5f1e7b7edff7555d
038d782 fix: upgrade html-snapshots from 1.0.1 to 1.1.0

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage remained the same at 99.223% when pulling de7bce32f2bb8a456288e37512834f63163f6f67 on snyk-upgrade-d83ad1676d064182f483093e8d74b375 into a49fd66277f77d1ba2ea502bcb6fd790433acdad on master.


Add further documentation to the crate

Screenshot of attribute-level changes rendered:

Screenshot of top-level changes rendered: (Just the readme pretty much)

Thank you so much for this - this looks excellent. I'm away this weekend but I'll address your 2 issues when I'm back!

Closed in favour of #5


Refactoring Maker workflow to use retry queue

:tada: This PR is included in version 2.0.4 :tada:
Your semantic-release bot :package::rocket:


Handoff cleanup timeouts

2016-03-04 11:30:18 =ERROR REPORT====
** Generic server <0.8393.2> terminating
** Last message in was {'EXIT',<0.8392.2>,{timeout,{gen_server,call,[<0.8393.2>,delete]}}}
** When Server state == {state,388211372416021087647853783690262677096107081728,'dalmatinerdb@<IP_ADDRESS>',{0,nil},["/data/ddb",47,"388211372416021087647853783690262677096107081728"],104857600}
** Reason for termination ==
** {timeout,{gen_server,call,[<0.8393.2>,delete]}}
2016-03-04 11:30:18 =CRASH REPORT====
  crasher:
    initial call: metric_io:init/1
    pid: <0.8393.2>
    registered_name: []
    exception exit: {{timeout,{gen_server,call,[<0.8393.2>,delete]}},[{gen_server,terminate,7,[{file,"gen_server.erl"},{line,826}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,240}]}]}
    ancestors: [<0.8392.2>,riak_core_vnode_sup,riak_core_sup,<0.129.0>]
    messages: []
    links: []
    dictionary: []
    trap_exit: true
    status: running
    heap_size: 2072833
    stack_size: 27
    reductions: 6133497
  neighbours:
2016-03-04 11:30:18 =SUPERVISOR REPORT====
     Supervisor: {local,riak_core_vnode_sup}
     Context:    child_terminated
     Reason:     {timeout,{gen_server,call,[<0.8393.2>,delete]}}
     Offender:   [{pid,<0.8392.2>},{name,undefined},{mfargs,{riak_core_vnode,start_link,undefined}},{restart_type,temporary},{shutdown,300000},{child_type,worker}]

This happens regularly when handing off, and the timeout likely occurs within the metric_io gen_server where the default of 5000ms is exceeded.

Due to the significant number of buckets in some partitions, this operation could not complete in the allotted 5s, and no longer times out on the extended 30s time window.  This ensures that handoff data is cleaned up properly on the source.


Request body gets replayed during redirects

When clj-http client is configured to follow redirects, and posts to a server that responds with a redirect (e.g. an authentication gateway that returns a 303 to an originally requested resource), it preserves all of the entries in the request map that generate a request body, including the :body and :content-type top level keys, and the "content-type" key in the :headers map.
This results in sending get requests with a body, which while not invalid, is often not what is expected of any participants in the HTTP session, particularly with the body that was appropriate to the request that initiated redirecting.
With confirmation that this issue is something that @dakrone  would like resolved, I will open a pull request w/ tests and fix.

Am I correct in understanding that this is primarily about the case of a post-redirects-to-get sort of response? That is, you explicitly don't want to replay the request as it originally was (but at a new url), but instead just follow the redirect via a simple get to the indicated url. Right?

@joegallo That's exactly correct. In our particular use case, a POST with a multipart form content body receives a 303 response. The clj-http client follows the redirect in the 303 with a GET request, and provides the same multipart form content body as the content of said GET.

Okay, in that case it seems like it should be pretty straightforward to dissoc the body in follow-redirect.
I'm trying to come up with a situation where removing the POST body wouldn't make sense. Perhaps it would be a good idea to only remove the body in the case where the original request was a POST?

I'm just thinking that if PRG is ubiquitous enough to get its own wikipedia page, then it's probably worth supporting more fully. :D

I've already resolved this locally with a quick hack by monkey-patching clj-http.client/follow-redirect (https://github.com/dakrone/clj-http/blob/master/src/clj_http/client.clj#L200) to dissoc the values in the request I described opening the issue. This seemed consistent with existing principles of follow-redirect's implementation, as it already will dissoc the :query-params key when following the redirect (https://github.com/dakrone/clj-http/blob/master/src/clj_http/client.clj#L213)
I agree that it's a sufficiently impactful change that considering undesired consequences deserves some time, it's not a sufficiently burning issue to demand immediate resolution, and my team has already worked around the issue with a satisfactory temporary fix.

I think this issue is no longer relevant, clj-http has vastly different redirect handling now in the later versions. Since this is a couple of years old, I'm going to close this. If this is still a problem let me know and I'll be more than happy to re-open it.


[FEATURE] Improve package code generation

*Is your feature request related to a problem? Please describe.
Hello, we would first like to thank you for the amazing work you've done so far ❤  !
However, we would like to give you some feedback on the elements we noticed when we tried the package:
For big projects, you get very large files (I'm at 35000 lines for the template "api.swagger.dart" file). The "separated_models" option only creates a separated file with all the model classes inside.  When those files are pushed to the repository, it makes reviews impossible (because we can't see what changes where made in the file)
Describe the solution you'd like
The solution we would suggest :

Generate one file per template and each file would contain all the info about the template (class definition, extensions, etc...)
Generate one file per "tag" : For each scheme tag, create a "tag_api" file which will contain all the relative client code, ex: home-controller -> home_controller_api.dart
Generate a file which contains the exports of all the models/all the tags (previously generated)
Options per request ? (for cache management, header injection on a specific request, etc...)
[NIVE TO HAVE] Use Object? instead of dynamic when you don't know the type of an object ?
[NIVE TO HAVE] A point that would also be interesting is to use the swagger url as an input. Unless I'm mistaken, today it is absolutely necessary to keep the openapi schema in the project (and thus to version it), whereas one could simply use the url of the swagger doc as an input to get the scheme (as the openapi-generator-cli does)

I don't know if I was clear enough, but these are basically the irritating points we've noticed. If you ever need some clarification on any points or have questions, we'll be happy to answer them.
Have a good day 😃

Hi @stevenosse ! What is problem of huge files? It's anyway generated code and you don't need to investigate it. From my perspective if we will have 1000 files instead of one file with 10000 lines - we will have no advantage. It's not comfortable anyway. But it will be too complicate to support this. So we will generate everything in one file anyway.
About swagger url as input. No, you don't need to keep this file locally. We just save file locally to have ability to re-generate files, when you have no internet. (For example you have new developer without VPN or smth). Feel free to remove swaggers folder after generation.
About Object? instead of dynamic. Sounds OK, I will do this in scope of this issue.
Generation of file, exporting all models is not possible, because we can have models with duplicated names and code will be not valid in this case.
You can inject any headers into your requests using Interceptors of Chopper client. You can modify any request and any response if needed.

I hope I answered all your questions. Please let me know if everything not clear and in case of new ideas.

I'm closing issue. Please reopen it if you not agree with me in any case.


should call callback before response event

const http = require('http');

const req = http.get('http://nowhere.com/', res => {
  console.log('response event');
})
req.on('finish', () => console.log('finish'))
req.end('', null, () => console.log('callback'))

This prints:

finish
callback
response event

I can open a PR which pass the callback to the respondWIth and put it after the finish event.

Hi, @mikicho. Can you please describe the expected behavior here? Is this the callback order that you find wrong? That seems to be correct (in your example). Are we not printing some of this? I suppose the .end() callback never gets called for bypassed requests?

Sorry for the incomplete description. Updated it.


limit parallel connection attempts

The spec says:
"There MUST be no more than one connection in a CONNECTING state. If multiple connections to the same IP address are attempted simultaneously, the client MUST serialize them"

The spec (RFC6455) is clear in this regard, and Autobahn doesn't implement this. However, this is aimed at browsers that need to cope with rogue, random JS. This is largely irrelevant for AutobahnPython, as we cannot contain Python app code above AutobahnPython, or prohibit it from doing whatever it likes. Won't fix. Not worth the hassles.

FWIW, I agree. Browsers have to cope with possibly-malicious browser JS, but if you're running "maybe malicious" Python you've already lost.


Fix wrong duration in vpx due to buffer usage

VPX doesn't allow 0 duration. If 0 is given, vpx_codec_encode will fail with VPX_CODEC_INVALID_PARAM.
0 duration is possible because mediadevices first gets the frame meta data by reading from the source,
and consequently the codec will read the first frame from the buffer. This means the first frame won't
have a pause to the second frame, which means if the delay is <1 ms (vpx duration resolution), duration
is going to be 0.
This is only a temporary fix for now. The main issue is tracked here, https://github.com/pion/mediadevices/issues/250.

Thanks, looks good to me


Remove endpoint pessimisation on ClientCall.cancel()

Codecov Report
Patch and project coverage have no change.

Comparison is base (2d87f6e) 50.96% compared to head (7d13c05) 50.96%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #145   +/-   ##
==========================================
  Coverage      50.96%   50.96%
  Complexity      1099     1099
==========================================
  Files            175      175
  Lines           7154     7154
  Branches         720      720
==========================================
  Hits            3646     3646
  Misses          3247     3247
  Partials         261      261

Files Changed
Coverage Δ

...main/java/tech/ydb/core/impl/YdbTransportImpl.java
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


use pyproject.toml configuration

This PR unifies all configurations to be set in pyproject.toml:

Remove setup.py, setup.cfg, .coveragerc
Regenerate requirements using pip-compile from pyproject.toml
Remove unnecessary CLI params, that will be parsed from config in scripts and pipeline

Resolves https://github.com/raimon49/pip-licenses/issues/201

@raimon49 should be ready for review

@mbalatsko pip-licenses 5.0.0 was shipped as our work product!!
https://pypi.org/project/pip-licenses/5.0.0/
Package metadata of this project is now very modern. Thanks for your contribution 🎉


In-product release notes design issues

VSCode Version: Code - Insiders 1.5.0 (f62883f07422cae4b53c2a185b105091460a0a85, 2016-09-27T13:07:11.616Z)
OS Version: Linux x64 4.4.0-38-generic, Ubuntu 16.04

#12520
Since this will become one of the main ways users will consume release notes it should look good.

No padding on page

Link color is unreadable on some themes

<code> should use editor.fontFamily

kb() annotations are not resolved

No syntax highlighting

Mainly build issue.


Migrate to PatternFly4

Migrate all components to PatternFly 4
Mast Head and Navigation would be the first one?

completed


CRM possible add-on - Ability to highlight team users that are NOT (yet) onboarded to Cloud

Describe the issue
Create way to highlight (possibly visually) the users in our CRM tool
Additional context

By being able to identify quickly if there are any individuals new to the team that may have been added by someone else an additional person can help, follow up if necessary with the client or ensure Cloud training is scheduled themselves
Enables more of a team effort to training and allows for possible quick follow ups

Definition of done

Show Jon the training list in Teams
Identify what options exist within the CRM that may allow for this (colours, highlighting, bold\unbold names, etc.)
Discuss potential best\easiest approach to a solution
Can be added to new CRM backlog if not reasonably possible (create a 'New CRM Backlog' & add)
If possible add a way to show as NOT yet onboarded but that are already scheduled for their training (highlight, colour, etc.)
Implement if it is deemed possible and not too much time

Had meeting with Prabhu about this and a demo was worked out in the test enviro

Was put into our prod instance of Google CRM

Note that this ticket was in progress but left unassigned so missed last update: The functionality added in question helped identify new projects\teams that needed to onboarded and\or possibly teams that may have to be re-onboarded due to new team members.  However, it is not capable of identifying\tracking client team members individually when new ones are added within Ministries.  Will discuss further with Julian and if can't resolve currently we may close this and\or create other tickets if necessary

Possibly considering here to add in a 'Client Self-reporting' capability, that drops info directly into our CRM (possibly uni-directional - ie. they can sent it and it populates a field - Field history would have to be turned on due to client ability to overwrite previous information).  To start this could work for clients changing their teams up and new members needing cloud training\onboarding - Clients would go to a CPF Self-Reporting page and add the names of the new members and when they press Send it would update the appropriate 'Onboarding\Training Need' in the project's CRM entry - will see if possible as well

Moving this back to the product-backlog so we can factor it in with capacity

An initial solution for our AppSheets CRM for this 'Client Self-reporting' mechanism has been identified, and Prabhu who believes it's fairly straight forward.  He will advise if any issues arise during a further short review period.
The idea is that our Ministry clients have a web form that they can fill out to PO\team self-report changes in their group - training needs, team make-up and\or communicate other important info.  Once submitted by the client it will update a Sheets 'feedback\request' field automatically (field here will have history activated as well so every submission is back-trackable) and a client 'Submission time' stamp will be added.
Note that the client PO\service lead will likely be required to submit this with the relevant project name, or some other known field and if an algorithm cannot match it to an existing project name (or ticket\Cloud request service#) then it would drop under an empty default project in our CRM and we would correct it upon review - empty CRM entry we would have to create this as part of the build for this functionality.  This would likely require an if\then capability within AppSheets which if not possible would require us to expose our Cloud request numbering system currently hidden and have it show up on every future Cloud Services\onboarding request submission in the future (on the post-submission PDF copy they receive by email), so the Ministry lead\PO could reference this in the 'self-reporting' form; However, this may be less ideal as names  are easier to remember, or a use of drop-down list could be implemented if it did not expose more info than necessary (ie. perhaps use a drop down of PO\service lead names in lieu & have all go to empty default project until processed or something similar)

Since this ticket has moved from an original intent of team individual training tracking into the 'Client Self-reporting' web form idea, we will close this ticket and create a backlog ticket to be activated when priorities allow

not relevant


Upgrade terraform-provider-mongodbatlas to v1.9.0

This PR was generated via $ upgrade-provider pulumi/pulumi-mongodbatlas.

Upgrading terraform-provider-mongodbatlas from 1.8.2 to 1.9.0.
Upgrading pulumi-terraform-bridge from v3.43.0 to v3.45.3.
Fixes #210

Curious @aq17 if we understand why the test broke?
index.ts(7,56): error TS2345: Argument of type '{ orgId: pulumi.Output<string>; }' is not assignable to parameter of type 'ProjectArgs'.
[203](https://github.com/pulumi/pulumi-mongodbatlas/actions/runs/4855747741/jobs/8654694484#step:22:205)
        Property 'name' is missing in type '{ orgId: pulumi.Output<string>; }' but required in type 'ProjectArgs'.
[204](https://github.com/pulumi/pulumi-mongodbatlas/actions/runs/4855747741/jobs/8654694484#step:22:206)

Did something change in the signature, like breaking change and out of date test?

@t0yv0 believe this is another case of https://github.com/pulumi/pulumi-terraform-bridge/pull/1064 – I'll try again with bridge version v3.46.0

closing in favor of https://github.com/pulumi/pulumi-mongodbatlas/pull/216


Can't figure out the installation

Requires GoTypelist to be downloaded and in your path.
I just can't seem to get this done as a basic user.
I tried "apm link" to no avail.
If you can add all key the GoTypelist files to the go types installation that will be great and really convenient.
Thank you.

Cliff -
Update to the newest version and see if it self-installs.
Thanks!

Closing from inactivity

Hello,
go-typelist seems broken:
# github.com/natdm/go-typelist
/media/data//dev/go/src/github.com/natdm/go-typelist/main.go:48: undefined: sort.Slice

go version go1.6.2 linux/amd64

It work with GO 1.9.1


hide when minimized option not working

Brief description of your issue
hide when minimized option is not working when enabled
Steps to reproduce (optional)

set "Start Hidden" and "hide when minimized" in the options.
Close the program and start it again
restore the main window from the systray
minimize the main window, it shoud disappear from the taskbar

Expected behavior (optional)
SI shoud disappear from the taskbar
Actual behavior (optional)
SI stays in the taskbar
Environment (optional)
Sistem Informer 3.0.7310  https://github.com/winsiderss/systeminformer/commit/bc98048
Windows 10

I've tested multiple machines and can't reproduce. Either you've disabled tray icons or need to reset settings.


chore: fix CI

Description of the change
This pull request addresses the issues with the Release CI job.
Checklist
Development

[ ] The changes have been covered with tests, if necessary.
[ ] You have a green build, with the exception of the flaky tests.
[ ] UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
[ ] The network calls work for all modules affected by your changes (e.g., solving a problem).
[ ] The console messages are validated for all modules affected by your changes.

Code Review

[ ] This pull request includes an explanatory title and description.
[ ] The GitHub issue is linked.
[ ] At least one other engineer has approved the changes.
[ ] After PR is merged, inform the reporter.

@triceo, the changes were validated here.


[BUG] BulkIndexer holds onto memory

What is the bug?
Observed when using the BulkIndexer and during a period of heavy indexing, an application's memory usage will climb to some high level and remain there after the period of indexing has completed, suggesting that there are allocated objects that are not being/not able to be GCed.
How can one reproduce the bug?
Still working on being able to reproduce this locally.
What is the expected behavior?
After a period of indexing, the memory usage returns to it's pre-indexing level.
What is your host/environment?
Application is deployed in a Docker container as an ECS task.
Do you have any screenshots?

As you can see in the above screenshots, memory usage & CPU usage of the application container align during a period of heavy indexing. When the CPU usage subsides, the memory usage remains at its elevated level. The return to a lower level corresponds with the container being recycled.
Do you have any additional context?

Library version: github.com/opensearch-project/opensearch-go v1.1.0

This is a good catch. Feel free to take a crack at it if you have any thoughts on where the issue lies.

This issue seems to say that we expect CPU/memory to stay stable (low) when doing more work (indexing). Isn't that proportional to the work being done?

@dblock The issue is not that CPU or memory spikes during indexing, it's that memory wasn't reclaimed starting at 15:30 in the graphs, when CPU went back down. The indexing was finished but memory stayed high until the container recycled.

Hey guys, we did some further investigation on this and we are pretty confident that it's not a memory leak. We believe that the memory is not in use, but the Go garbage collector is not deallocating it. I believe this is an optimisation whereby if there is no memory pressure on the system, the GC will not free memory that is not immediately needed, bit of context on that in this comment on the Go Github repo.
I'll close out the issue.


Video component

Moves the video loading logic into a separate component
Also adds: prettier, eslint, recoil and editor config

You're on fire! <3


Unable to set connect timeout

Hi,
The "timeout" parameter on LDAPClient.connect() seems to only affect the LDAP bind process, and not the network connection. So if the network connection times out (aka. SYN timeout) Bonsai seems to hang forever.
Example code:
import bonsai

def main():
    cli = bonsai.LDAPClient("ldap://bonsai.test.watn.no")
    print("Connecting...")
    cli.connect(timeout=2.0)
    print("Connected!")
    cli.close()

if __name__ == "__main__":
    main()

(bonsai.test.watn.no drops packets on port 389, so the connection will end in SYN timeout).
This also affect LDAPS connections if the SSL handshake times out. I'm testing on Linux, Fedora 27, with OpenLDAP 2.4.45-4.fc27.
(otherwise; great module! Thanks for making it.)

Hi!
"bonsai.test.watn.no" should behave the same way for you as for me, so just running the example code should do the trick. That's the SYN timeout one, I can make a test for the SSL handshake timeout as well, if you wish.
But, I see now that I jumped the gun when I said "just hangs". The connection attempt fails after about two minutes:
>>> datetime.now().isoformat()
'2018-06-18T20:28:58.006610'
>>> main()
Connecting...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 4, in main
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapclient.py", line 555, in connect
    return LDAPConnection(self, is_async).open(timeout)
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapconnection.py", line 101, in open
    return self._evaluate(super().open(), timeout)
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapconnection.py", line 52, in _evaluate
    return self.get_result(msg_id, timeout)
bonsai.errors.ConnectionError: Can't contact LDAP server. (0xFFFF [-1])
>>> datetime.now().isoformat()
'2018-06-18T20:31:08.471086'
>>>

This is a bit on the high side for my project, so it would be great to be able to adjust it.

Oh, that's cool. Should have checked the example, before I asked.
Looked into it, and unfortunately there's no workaround for it in the current releases. :(
But it might be fixed in a future one. There is an LDAP_OPT_NETWORK_TIMEOUT option in OpenLDAP specifically for this. By setting that, the connection honours the timeout.
Actually, this option would be the key for truly asynchronous connection build-ups (setting it to 0), but I had bad experience with it: on some OSes (Ubuntu, Mac, ...) the LDAP operations somehow polled the socket's status incorrectly, and tried to use it earlier than they should, while on other OSes (e.g. Fedora) it worked just fine. It's on my todo list to check this again in the near future.

I have now configured bonsai.test.watn.no to drop the connection during the ssl handshake on ldaps, so you can try out the handshake timeout as well. It seems to hang forever (or at least > 5 minutes):
>>> datetime.now().isoformat()
'2018-06-18T23:01:08.816638'
>>> main()
Connecting...
^C^C^C^C^CTraceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 4, in main
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapclient.py", line 555, in connect
    return LDAPConnection(self, is_async).open(timeout)
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapconnection.py", line 101, in open
    return self._evaluate(super().open(), timeout)
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/ldapconnection.py", line 52, in _evaluate
    return self.get_result(msg_id, timeout)
  File "/home/mhw/.local/share/virtualenvs/api-Zf5oDCEJ/lib/python3.6/site-packages/bonsai/errors.py", line 181, in _get_error
    def _get_error(code: int) -> type:
KeyboardInterrupt
>>>
>>> datetime.now().isoformat()
'2018-06-18T23:06:53.123616'
>>>

But yeah, sounds like LDAP_OPT_NETWORK_TIMEOUT is the right knob to adjust. Wonderful if you could take a look in the near future - "truly asynchronous" sounds pretty sweet :-)

Thanks, I tried, and it seems like that the SSL connection is even beyond reach for OpenLDAP.
It still hangs after setting LDAP_OPT_NETWORK_TIMEOUT. My guess that the timeout param is not pass down to the SSL connection.
You can use bonsai.set_debug(True, 1) to see what steps is actually stuck.

Ok, I've looked into it. I set the LDAP_OPT_NETWORK_TIMEOUT to 0 and the LDAP_OPT_CONNECT_ASYNC flag on before opening a connection, rebuilt the module, then ran the tests on the last 3 Ubuntu LTS releases and on an older Fedora. The results are:

14.04-trusty: libldap 2.4.31, all connection related tests failed.
Fedora 22: libldap 2.4.40,  all connection related tests failed.
16.04-xenial: libldap 2.4.42, only TLS related tests failed.
18.04-bionic: libldap 2.4.45, all tests were ok.

Then I found this in OpenLDAP 2.4.41's Change Log:

Fixed libldap async connections (ITS#8090)

Oddly, there's no mention about a TLS fix in the change logs, but it has been fixed since 2.4.43, or at least that's what I've experienced.
So the next step will be to add a version test macro in the source and set these options when newer libldap is used to build the extension. That will grant us async connection built-up, and solve your problem as a non-negligible "side-effect". :)
Or that'd be the next step, but I also ran the test on a Mac OS, and it failed miserably, regardless of the fact that the extension was built with a very new libldap 2.4.46. I'll investigate this a little bit more, before making the changes.

Sounds very good! :+1:

The new release is out and it contains the fix for libldap 2.4.43+ on Linux.

Thanks!


Django 1.9 compatibility warning.

RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9. -- and django-assets imports it.

See https://github.com/miracle2k/django-assets/commit/c7517b78a385c427500a0f9240d2945ef27dbf1f
This is not applied to current release version https://github.com/miracle2k/django-assets/releases/tag/0.10
You can either ignore warning messages or just use django-assets with recent commit-ed version.

I hop a new release will be out soon.

requires_model_validation is also deprecated ;)


Tiles are not request from backend after blob storage request fails

Discussed in https://github.com/iTwin/itwinjs-core/discussions/4531

Originally posted by BlowyXDU October 22, 2022
Hi!I just followed the steps in sample in Get Started,everything was fine but the web didn't show anything,just black screen,what happened?Thanks for answering me :).

Here are the result and errors report.

![图片](https://user-images.githubusercontent.com/116451744/197350389-3f26dba6-3990-4a7a-a05c-8c390cbfa433.png)
![图片](https://user-images.githubusercontent.com/116451744/197350432-030fd0ab-cb8a-460b-abe7-2c31bff2a996.png)
![图片](https://user-images.githubusercontent.com/116451744/197350449-96262e5f-ace5-4343-8ff1-598000bbdfbe.png)

@aruniverse @calebmshafer @paulius-valiunas @wgoehrig @swbsi @nick4598
IModelTileRpcInterface.requestTileTreeProps succeeds and returns tile trees. We then attempt and fail to download tiles from blob storage, as expected. No subsequent requests are made to IModelTileRpcInterface to generate the tiles.
In TileRequest.dispatch an error is caught:
"RestError: The specified blob does not exist.
RequestId:82eb8eb2-601e-0035-3a34-e640d4000000
Time:2022-10-22T16:39:51.4561057Z
    at new RestError (http://localhost:3000/static/js/vendors~object-storage.chunk.js:3418:28)
    at handleErrorResponse (http://localhost:3000/static/js/vendors~object-storage.chunk.js:1962:17)
    at http://localhost:3000/static/js/vendors~object-storage.chunk.js:1898:18"

Previously, I believe requestContent would have returned undefined instead of throwing an error, and we would have proceeded via onNoContent to request the tile via rpc.
I recall some changes were made to HTTP status handling in 3.4 which may be relevant.
We need to figure out how this went undiscovered until just now.

This might be the issue @nick4598 and I was seeing when testing out the 3.5.0-dev.22

I suppose I will update TileRequest.dispatch to handle 404 errors.


FEAT: Create mambaforge recepie for ngspice and multi-platform installation

Create mambaforge recepie for ngspice and multi-platform installation so that ngspice installs itself it is not, and related dependencies.
Sometimes you're not working inside IIC-OSIC-TOOLS

See https://www.cascode-labs.org/viper-forge/


Ability to Create Profiles Groups in 'New Tab' Drop-Down Profile Menu

Description of the new feature/enhancement
I have a lot of profiles, such that the drop-down menu listing of them runs off the bottom of my screen and requires scrolling to reach those at the bottom.
I'd like to be able to construct groupings of profiles within the 'settings.json' file such that the group would have a name that would show up in the main drop-down, with its own drop-down menu listing the contained profiles.
Proposed technical implementation details
Here is an example 'profiles' object with a 'list' containing a 'group' object as a member that names and defines a group of profiles:

{
   "profiles":{
      "defaults":{
         "useAcrylic":true,
         "acrylicOpacity":0.7,
         "cursorShape":"filledBox",
         "cursorColor":"#00FF00",
         "closeOnExit":true
      },
      "list":[
         "group":{
            "name":"Profile Group",
            "members":[
               {
                  "guid":"{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                  "name":"Windows PowerShell",
                  "commandline":"powershell.exe",
                  "hidden":true
               },
               {
                  "guid":"{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                  "name":"Command Prompt",
                  "commandline":"cmd.exe",
                  "hidden":false
               }
            ]
         },
         {
            "guid":"{574e775e-4f2a-5b96-ac1e-a2962a402336}",
            "hidden":false,
            "name":"PowerShell",
            "colorScheme":"Campbell Powershell",
            "source":"Windows.Terminal.PowershellCore"
         }
      ]
   }
}

Given the above, there would be a 'Profile Group' listed in the New Tab drop-down, with an arrow to the right indicating a sub-menu.  Hovering or clicking on the sub-menu would display profile names 'Windows PowerShell' and 'Command Prompt'.
The 'group' object could also have other contained properties that would define characteristics of the profile name in the New Tab drop-down--probably identical to the properties used for the profile name display itself.
The 'group' object could also contain other 'group' objects that would define sub-groups within the top-level group, with some reasonable limit to group nesting.

Thanks for writing this up! It looks like we've got some of this covered in #1571, and a spec accepted in #5888 :smile:
I'm gonna close this one out as a duplicate.

is this really implemented , it doesn't exists in Version: 1.18.2681.0

@lakani It sure is! #1571 was closed by #13763, which shipped in 1.17.
See: https://learn.microsoft.com/en-us/windows/terminal/customize-settings/appearance#new-tab-dropdown

many thanks, it works now

@lakani ...thanks for checking on this and @zadjii-msft ...thanks for the link to the documentation.  This is a great addition to Windows Terminal!


Added quotes around terraform vars

Our linter was mad, so adding the vars seemed like the thing to make it happy.

🤑


[Bug][Sonarqube] No option to add scope config even though documentation suggests

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Add sonarqube connection and add data scope to the connection - I can see data scopes coming through but cannot see scope config option.
It’s all just N/A

What do you expect to happen
Expect to see option to add scope config and only then we can get DORA metrics
How to reproduce
Add sonarqube connection and the add data scope.
Anything else
No response
Version
v1.0.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

fyi I am using Sonarqube enterprise v10.6

What document were you referring to?
I can clearly see that Sonarqube data source doesn't have any scope config: https://devlake.apache.org/docs/Configuration/SonarQube#step-3---adding-transformation-rules-optional

Step 2 Data entities
https://devlake.apache.org/docs/Configuration/SonarQube/

@sanjchhoker I see.
Sorry for missing the point, my brain somehow filtered the section completely for me. 😂

Hi @sanjchhoker , the docs have been updated by: https://github.com/apache/incubator-devlake-website/pull/787
You'll see the latest doc after it gets merged.

The updated sonarqube doc: https://devlake.apache.org/docs/Configuration/SonarQube/


IE bug with window.location.replace and base tag

I noticed this from this question: https://stackoverflow.com/questions/49467305/react-routers-hashrouter-redirects-to-base-tag-url
While IE seems to be doing the right thing there, here's the underlying bug.
Say we have a page at /url/ with code like this:
<base href="/base/">
<script>window.location.replace("new")</script>

In IE it will redirect to /url/new
whereas in other browsers it will go to /base/new
Not sure what a general fix would be, that's why I'm not sending a PR myself. But in this line here https://github.com/ReactTraining/history/blob/master/modules/createHashHistory.js#L51, using an absolute url would fix it, allowing HashRouter to be used with the base tag as in the case of the SO question.

The line that you use is using an absolute path. It just strips off the existing hash and appends the new one.
// https://example.com/some/location
replaceHashPath('newPage')
// https://example.com/some/location#newPage

// https://example.com/some/location#withHash
replaceHashPath('newPage')
// https://example.com/some/location#newPage

history doesn't use the <base> tag at all, so if that tag is breaking things, I think the best recommendation would be to remove it from the page.

What I mean is in your first example, since there is no hash, window.location.replace inside the replaceHashPath function ends up being called with the relative anchor url "#newPage", not the full url.
That's why if the page has a <base href="/base/"> the result would be
https://example.com/base/#newPage
instead of
https://example.com/some/location#newPage
If HashRouter isn't meant to be used together with the <base> tag though as you said, this is not important then.

Oh, yes, for some reason when I glanced at that before I thought that it was using the absolute path. I think that a PR that does this would be useful because while the <base> isn't supported, the fix is easy enough and should save a few people from headaches.
The history tests are run in various browsers, so this should be testable. Probably just a separate block that adds a <base> to the DOM prior to running the tests and strips it out once they are complete.


Dark mode in quick accent

Description of the new feature / enhancement
In the quick accent I would like dark mode to be added as well as mica efects.
Scenario when this would be used?
Now, the toolbar that appears is white. If it becomes dark it will match better with the rest of the os when dark mode is enabled
Supporting information
No response

Hope they take this into account.

/dup https://github.com/microsoft/PowerToys/issues/20217


Does not work on Steam Version (9/14/2024)

Resolution 32:9 (5120x1440)

Can you post your FISTFix.log file please?


HTTP request archives should omit some streaming responses

Version
f32232e6aae6025ea2dc53af9288988c5b6a42eb
Describe the bug
The recording.har.yaml files are verbose because streaming completions reiterate the prefix of the completion every time.
Expected behavior
recording.har.yaml files remain reviewable by manual inspection; that is the point.
Additional context
We should drop most of the streaming completions responses, deterministically, but produce streams with enough variety that streaming completions are still exercised. For example maybe we could hash the response text and only keep every 1/mod N of the hash or something.

Note from @olafurpg , the hook to do this lives in vscode/src/testutils/CodyPersister.ts?L74


Added --allow-not-run-notebook option

Added --allow-not-run-notebook option
Allow notebooks with only unrun cells to pass.

@christopher-hacker I did not update the README yet. Please let me know if you like the --allow-not-run-notebook flag and intend to merge this PR first, then I'd be happy to add a README section.

I think this should be the default behaviour, so I don't think this needs to be an option. But it should probably check that the outputs are empty when the execution_count is None.

@christopher-hacker can we wrap up  this PR?

Note https://github.com/christopher-hacker/enforce-notebook-run-order/issues/13 is related

On deadline at work right now, but will try to clear this up this week. My plan is to make this the default behavior per @jamesmyatt's suggestion, and will clear up #13 as well.

This is now the default behavior for all empty cells, per #16


FIX Raise an error when performing mixed adapter inference and passing non-existing adapter names

PEFT allows mixed batch adapter inference, i.e. when predicting, the same batch can use different adapters by passing the adapter_names argument. However, when users pass an adapter name that does not correspond to any of the existing adapters, these samples are currently being ignored (i.e. just the base model output is used). This is unexpected and can easily lead to errors, e.g. when users mistype the name of an adapter.
This PR fixes this issue by checking all the existing adapter names first and comparing them to the adapter_names that the user passed. If there are unexpected entries, an error is raised.
Due to this fix, an error in the test
test_mixed_adapter_batches_lora_merged_raises was discovered and promptly fixed.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ping @SunMarc Could I get a review please, it should hopefully not take long.

No worries, that happens sometimes. Thanks a lot for the review.


Fix #63295:  Refer to Sudo in Linux Save Error Message

This PR is meant to address #63295:

When editing a file that can't be saved without elevation, a notification pops up, prompting to try and save as administrator. On Linux, perhaps this should say "Retry with sudo"

I have changed the button to what @bpasero suggested in the issue ("Retry as Sudo"):

I look forward to any suggestions or comments, and I would be happy to change the code or error messages as necessary.  This is my first attempt at a contribution, so please let me know if I am missing anything.  Thanks!

That makes total sense.  I figured I might have something wrong with the localization.  Thanks for the correction.  I will fix ASAP.

Thanks 👍


BUG: unhandled error in plugin discover: "Nonetype object has no attribute 'group' : Plugin Alparatio

Expected behaviour:
I've just started using Flexget and got a friend to set me up. He's running the same script and for him this seems to be working.  There might be some errors trying to get my  series to download but thats not the issue I'm trying to tackle at the moment. Whenever the series or Movie  task finds something to download and tries to do so it throws up the following Bug / errors.
Actual behaviour:
I've tried searching what this could be but all I could find where some layout issue's that appearently were fixed a while ago.  Find it so weird that the exact same script could work on one computer but not on mine.  I've tried downgrading he flexget version to the one my friend is running and even straight copying his alpharatio plugin and didn't seem to fix the issue.  Any ideas what it could be?
Config:
variables: secrets.yml

schedules:
  - tasks: '*'
    interval:
      minutes: 5

templates:
  global:
    no_entries_ok: yes
    regexp:
      reject:
        - (P2P|3D|HSBS|Half-SBS|remux|HDCAM|CROPPED|DTS|DD5|WEB-DL|DVDRip)
  tv:
    thetvdb_lookup: yes
    configure_series:
      settings:
        quality: 720p+
        timeframe: 0 minutes
        propers: 1 days
        target: hdtv+ 1080p
      from:
        trakt_list:
          account: "{? trakt.account ?}"
          list: "{? trakt.series ?}"
          type: shows
    deluge:
      path: "{? deluge.download ?}"
      movedone: "{? deluge.series ?}/{? series_name ?}/Season {? series_season ?}/"
      label: series
      queuetotop: yes

  movies:
    tmdb_lookup: yes
    movie_list: trakt-movies
    quality: 1080p
    deluge:
      path: "{? deluge.download ?}"
      movedone: "{? deluge.movies ?}/"
      label: movies
      queuetotop: yes

  music:
    regexp:
      accept:
        - Hitzone
        - Trivium
        - Five Finger Death Punch
        - SLAM ADE
        - SLAM_ADE
    download: "{? folder.root ?}{? folder.music ?}"

tasks:
  follow show from ep:
    priority: 1
    seen: local
    trakt_list:
      account: '{? trakt.account ?}'
      list: '{? trakt.series ?}'
      type: episodes
    accept_all: yes
    set_series_begin: yes

  get shows:
    priority: 2
    template:
      - global
      - tv
    discover:
      what:
        - next_series_episodes: yes
      from:
        - alpharatio:
            username: "{? ar.username ?}"
            password: "{? ar.password ?}"
            scene: yes
            category: tvhd
            order_by: time
            order_desc: yes
            leechstatus: normal

  movie fill:
    priority: 3
    trakt_list:
      account: "{? trakt.account ?}"
      list: "{? trakt.movies ?}"
      type: movies
      strip_dates: yes
    accept_all: yes
    list_add:
      - movie_list: trakt-movies

  movie download:
    priority: 4
    template:
      - global
      - movies
    discover:
      interval: 15 minutes
      release_estimations: loose
      what:
        - movie_list:
            list_name: trakt-movies
            strip_year: yes
      from:
        - alpharatio:
            username: "{? ar.username ?}"
            password: "{? ar.password ?}"
            scene: yes
            category: moviehd
            order_by: time
            order_desc: yes
            leechstatus: either
    list_match:
      from:
        - movie_list: trakt-movies
    list_remove:
      - trakt_list:
          account: "{? trakt.account ?}"
          list: "{? trakt.movies ?}"
          type: movies

Log:
2017-02-16 09:08 DEBUG    manager                       Figuring out config load paths
2017-02-16 09:08 DEBUG    manager                       Found config: C:\Users\Philip\flexget\config.yml
2017-02-16 09:08 DEBUG    manager                       Config file C:\Users\Philip\flexget\config.yml selected
2017-02-16 09:08 INFO     manager                       Test mode, creating a copy from database ...
2017-02-16 09:08 INFO     manager                       Test database created
2017-02-16 09:08 VERBOSE  task_queue                    There are 4 tasks to execute. Shutdown will commence when they have completed.
2017-02-16 09:08 VERBOSE  trakt_list    follow show from ep Retrieving `episodes` list `series`
2017-02-16 09:08 WARNING  trakt_list    follow show from ep No data returned from trakt for episodes list series.
2017-02-16 09:08 VERBOSE  trakt_list    follow show from ep Retrieving `episodes` list `series`
2017-02-16 09:08 WARNING  trakt_list    follow show from ep No data returned from trakt for episodes list series.
2017-02-16 09:08 VERBOSE  details       follow show from ep Task didn't produce any entries.
2017-02-16 09:08 VERBOSE  details       follow show from ep Summary - Accepted: 0 (Rejected: 0 Undecided: 0 Failed: 0)
2017-02-16 09:08 VERBOSE  trakt_list    get shows       Retrieving `shows` list `series`
2017-02-16 09:08 WARNING  trakt_list    get shows       No data returned from trakt for shows list series.
2017-02-16 09:08 VERBOSE  trakt_list    get shows       Retrieving `shows` list `series`
2017-02-16 09:08 WARNING  trakt_list    get shows       No data returned from trakt for shows list series.
2017-02-16 09:08 WARNING  configure_series get shows       Input trakt_list did not return anything
2017-02-16 09:08 INFO     configure_series get shows       Did not get any series to generate series configuration
2017-02-16 09:08 WARNING  discover      get shows       Input next_series_episodes did not return anything
2017-02-16 09:08 VERBOSE  discover      get shows       Discovering 0 titles ...
2017-02-16 09:08 VERBOSE  details       get shows       Task didn't produce any entries.
2017-02-16 09:08 VERBOSE  details       get shows       Summary - Accepted: 0 (Rejected: 0 Undecided: 0 Failed: 0)
2017-02-16 09:08 INFO     deluge        get shows       Connecting to daemon at localhost:58846..
2017-02-16 09:08 INFO     deluge        get shows       Connected to daemon at <IP_ADDRESS>:58846..
2017-02-16 09:08 INFO     deluge        get shows       Connection lost to daemon at localhost:58846 reason: Connection was closed cleanly.
2017-02-16 09:08 VERBOSE  trakt_list    movie fill      Retrieving `movies` list `watchlist`
2017-02-16 09:08 VERBOSE  details       movie fill      Produced 1 entries.
2017-02-16 09:08 VERBOSE  task          movie fill      ACCEPTED: `Cross Wars` by accept_all plugin
2017-02-16 09:08 VERBOSE  details       movie fill      Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2017-02-16 09:08 VERBOSE  list_add      movie fill      adding accepted entries into movie_list - trakt-movies
2017-02-16 09:08 VERBOSE  discover      movie download  Discovering 1 titles ...
2017-02-16 09:08 VERBOSE  api_bluray    movie download  Searching from blu-ray.com `Cross Wars`
2017-02-16 09:08 VERBOSE  discover      movie download  Searching for `Cross Wars` with plugin `alpharatio` (1 of 1)
2017-02-16 09:08 VERBOSE  utils.requests movie download  Waiting 4.48 seconds until next request to alpharatio.cc
2017-02-16 09:08 CRITICAL task          movie download  BUG: Unhandled error in plugin discover: 'NoneType' object has no attribute 'group'
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\flexget\task.py", line 483, in __run_plugin
    return method(*args, **kwargs)
  File "c:\python27\lib\site-packages\flexget\event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "c:\python27\lib\site-packages\flexget\plugins\input\discover.py", line 290, in on_task_input
    return self.execute_searches(config, entries, task)
  File "c:\python27\lib\site-packages\flexget\plugins\input\discover.py", line 155, in execute_searches
    search_results = search.search(task=task, entry=entry, config=plugin_config)
  File "c:\python27\lib\site-packages\flexget\plugin.py", line 118, in wrapped_func
    return func(*args, **kwargs)
  File "c:\python27\lib\site-packages\flexget\plugins\sites\alpharatio.py", line 210, in search
    e['content_size'] = parse_filesize(size.group(0))
AttributeError: 'NoneType' object has no attribute 'group'

Additional information:

Flexget Version: 2.9.23
Python Version: 2.7.13
Installation method:
OS and version: Pip Running on windows 7
Link to crash log:

Cannot reproduce. I have made sure it won't crash anymore and added some more logging. Please update to 2.10.2 tomorrow and test it again. It should log something like this No size found! Please create a Github issue. Size received: ....

thanks for working on this. Just got back from a trip and got the chance of testing. it returns:
"Size Received: 6 days ago"
Strangely it gives me this a few lines lower:
ValueError: Invalid literal for long() with base 10: '6.56 GB'

Looks like the order of the columns of the site changed, but it worked for me.

Yes. I do.
I got it to work sort of by going into the plugin and changing the column numbers so it gets the right one. Seems to be working, getting a little error now and then but nothing that major crashes the system.
If I remember correctly I added one with every column above 4. So 4 changed to 5, 5 to 6 etc.  So weird that its only on my computer..
Only error I'm getting every once in a while is:
Error searching with alpharatio: invalid literal for long() with base 10: '1.069
But that looks like it's something that has nothing to do with my changes

Looks like the regex is failing but the column is right one
2017-03-25 12:59 ERROR    alpharatio    alpharatio      No size found! Please create a Github issue. Size received: 1 month ago
2017-03-25 12:59 ERROR    discover      alpharatio      Error searching with alpharatio: invalid literal for long() with base 10: '2.62 GB'
Last time i patched somehow the plugin, but i'm a bit clueless on how to do it right now
Flexget: 2.10.21
Python: 2.7.9
OS: Debian Jessie

Size received: 1 month ago... that's not the right column.


Include running time as evaluation metric

The running time should be included as an evaluation metric. It is already being logged for the overall process, but it would be nice to get a plot over time. It could also be interesting to split into training time / testing time.

Hi @jmread, I intend to implement this capability and also the memory usage accounting soon.
@jacobmontiel and @jmread could you give me some guides or suggestions of how I can make those changes maintaining the structure and standards of the framework?
Would adding new classes to the measure collection be the best option? In this case, these metrics would be common for all the prediction tasks. This could change the way how the framework makes the distinction among the prediction tasks unless the new metrics are added to all tasks (in skmultiflow/utils/constants.py). For example, when computing the following set operations:
https://github.com/scikit-multiflow/scikit-multiflow/blob/fdf348712e39db3c6b79ed96669b9e623095cedf/src/skmultiflow/evaluation/base_evaluator.py#L203-L218

Hello again @jacobmontiel
When you mention evaluating n models, are you referring to ensemble predictors or the comparison of different techniques?

In the case of ensembles, I think that might be interesting to report the total running time, excluding individual predictors, at least initially.

Additionally, reporting the training and testing time separately (in addition to the total running time) could be very useful too.

I meant n models being compared (either simple models or ensembles). Now, if we consider multiple time points to track then it may be worth to have a class or method for this specific purpose.

Hi @jacobmontiel,
I agree with you. If the running time and memory costs are going to be reported at the same stream "points" (or at the same frequency) as other metrics, e.g., accuracy, then it may be worth creating classes like *TimeAndMemoryMeasurements for these tasks.
In fact, the major reason I see to do this, would be writing the measured values into the output log and plotting the measured results.

I prefer to have separate trackers for memory and time. I think time has to be tracked by default (as currently is) and could be added to the plots in the form o a legend (text). On the other hand, memory could be optionally selected and plotted.

You are right. Computing time will add little extra processing to the framework. On the other hand, calculating the total memory used by the models is costly when done at possibly small time intervals. My bad!

@smastelini , I am currently working on a refactoring of the evaluator and visualizer which will impact this issue.
We will add a buffer object to share data between evaluators and visualizer(s). Additionally, this should help reduce the amount of code by providing a generic way to share data. I expect to have the change ready in the next couple of days.

Very nice @jacobmontiel! Currently I have the time and memory measurements under "alpha" tests. I plan to integrate these new features soon as a PR.
I will wait for the mentioned refactoring and integrate my changes, as well as, prepare tests and documentation for the new features. After that I will proceed with the PR.

Hello @smastelini
The new buffer structure is in place. You will see changes in the evaluators and visualizer (for the good I hope) which could be confusing at first. Let me know if you have questions.

Hello @smastelini ,
I agree that time and memory are special cases with respect to default current/mean measurements:

Time will always increase, so the best approach is to display the current value (no plot)
Memory, on the other hand, will behave differently for each algorithm. While in some cases it might be interesting to "see" (plot) memory over time, in most cases current only displaying current memory measurement would be enough.
Additionally, we can include time and memory into the summary file (csv).

I have been thinking about this and considering the current layout I have this proposal:
+++++++++++++++++++++++++++++
+                   Figure Title                        +
+ ========================== +
+  |     Subplot_1      |     Metrics_1     |  +
+ ========================== +
+  |     Subplot_n      |     Metrics_n     |  +
+ ========================== +
+   *Time:  Training    Testing    Total*   +
+   *Memory: M_1    M_2    M_m*        +
+  Figure Legend                                    +

This would only apply to the default visualizer, as new visualizer are added they should provide their own layout.
My only concern is if the user sets the evaluator with multiple plots and multiple models (+3) which could result in visual clutter. But for a  normal" setup should work. Comments?
As a comment, the new data buffer is intended to be generic and support different types of data. For example, you can check the true_vs_predicted and data_points portions that are cases that do not follow the current/mean paradigm.
Let me know what you think.

Hi @jacobmontiel,
I think that your solution might be the best one for generality. As the time and memory measurements are reported in the csv output, I agree that just showing the current measurements as text in the plots should be enough. Detailed analysis could be performed using the generated log.
I will adapt the visualizer to show textual information of those metrics following the proposed layout. As soon as those changes were done, I'll let you know!
Thanks for the suggestions.


Feature: Ability to Preview in app by entering Id and version

feature: use playground app id and version number to preview inside mobile app.

@bhavincb, could you please elaborate a bit more about this requirement? I am not quite sure to understand it quite right.

currently we can preview playground app by scanning the QR code to mobile playground app. but this is only way currently. i'm suggesting there should be an input field available on mobile playground app. in which we can enter playground project ID and then we can preview it.

@bhavincb, you already can do that. For example try typing the following url in your mobile browser: https://play.nativescript.org/?template=play-vue&id=b9acUH and it should open the mobile version of the playground allowing you to directly browse the saved session.

i'm talking about android and ios native playground app. see the output of any playground demo by inserting it's id to native playground app.

Yes, currently there's no way to insert only the id of a saved session, you need to type the full url or click on a link.

yup, that is the feature request i am asking.


doc(plugin): fix typo

Description

Fixes a typo in the plugin docs in "Plugin System" section.   onDestory() => onDestroy()
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Thanks!


System.Collections.Generic.Comparer Default and Create issue in sorting

Expected
I expect that System.Collections.Generic.Comparer<T>.Default and System.Collections.Generic.Comparer<T>.Create(IComparison<T>) can be called generically. Specifically it means they have generic (alias) method named System$Collections$Generic$IComparer$1$T$compare
Actual
Actually they don't have it as evidenced by code that calls IComparer<T>.Compare(T x, T y) in a generic way.
Without too much abstraction: it means that currently it is impossible to sort using code that delegates its work to Comparer<T>.Default
Steps To Reproduce
Deck
Test below should write 6 messages ending with true. In Bridge 15.6 it throws an exception while producing 5th and 6th line. I suspect it can be broken in older versions.
public class CustomCmp<T> : IComparer<T> where T : IComparable<T>
{
    public int Compare(T x, T y)
    {
        return x.CompareTo(y);
    }
}

public class WrappingCmp<T> : IComparer<T>
{
    private readonly IComparer<T> _wrapped;

    public WrappingCmp(IComparer<T> wrapped)
    {
        _wrapped = wrapped;
    }

    public int Compare(T x, T y)
    {
        return _wrapped.Compare(x, y);
    }
}

public class Main
{
    public static void Main()
    {
        //comparer Default "as such" works
        {
            var cmp = Comparer<string>.Default;
            Console.WriteLine("[1]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }

        //comparer Create "as such" works
        {
            var cmp = Comparer<string>.Create((x,y) => x.CompareTo(y));

            Console.WriteLine("[2]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }

        //custom comparer "as such" works
        {
            var cmp = new CustomCmp<string>();
            Console.WriteLine("[3]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }

        //custom comparer wrapped works
        {
            var cmp = new WrappingCmp<string>(new CustomCmp<string>());
            Console.WriteLine("[4]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }

        //default comparer wrapped doesn't work
        {
            var cmp = new WrappingCmp<string>(Comparer<string>.Default);

            Console.WriteLine("[5]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }

        //created comparer wrapped doesn't work
        {
            var cmp = new WrappingCmp<string>(Comparer<string>.Create((x,y) => x.CompareTo(y)));

            Console.WriteLine("[6]is less than zero as expected?" + (cmp.Compare("a", "b") < 0));
        }
    }
}

Hi @d-p-y, thank you for the great report and test case. It is fixed and will be released in 15.7.

thanks!


Attachments

i just noticed a lot of the folder structure has been changed in this pr, this creates has too many conflicts with the other PRs, so i will try to merge the other ones first and then take a look into this one


[Question] Adding navigation arrow to map

Is it possible to create some sort of a navigation arrow on map that points on markers outside visible area using Mapsui? Or any advices on it?
I need some sort of a marker indicator on sides of a visible area. Picture below shows what I intend to do. Red dot represents marker and I need an arrow that points on it.

Perhaps the best option is the custom style renderer:
https://mapsui.com/documentation/custom-style-renders.html
It is a bit of work but will give you the most flexibility.

Thanks, I'll give it a try. Also is it possible to get info about objects out of your visible bounding box? Seems like I'd need to gather info about them like that

ah yes, that will also be an issue.
One way is to create your own MemoryProvider (perhaps copy the one in Mapsui) and always return all features instead of filtering.
Another route is to work with features with a bigger extent. In general this is what you want, a features visibility depends on it's style. A wide outline can make it visible outside of it's geometry. A point with a big image as style will be visible while the point itself is outside of the extent. In your case you have a feature that because of it's style is always visible. So it's extent is as wide as the fill extent of the map, or it has an infinite extent. But I don't see yet how we could make that work in Mapsui.

Oh, I got it :) the problem is that I tried to make markers as small as possible because I need click and navigate events on each feature on the map. That's why wide objects are not an option. I'm already facing a problem that one feature style (picture) is too large and I can't click on feature behind that one. And it makes it impossible to select some features

The mapinfo event also returns a list of all features touched. Perhaps you could use that. Look at MapInfo.MapInfoRecords. You could present the use with a selection dialog.

That's an interesting one, perhaps I could use that. Thanks a lot :)


[tool] guard remaining unguarded non-test stdin.writeln calls

Contributes to fixing https://github.com/flutter/flutter/issues/137184
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This test is timing out:

Ah, okay; I think what was happening here is that we were awaiting the command's completion before consuming the stdin stream (through the transform call that comes after call run in the test body). With the introduction of ProcessUtils.writelnGuardedUnsafe into AnalysisServer::start, the command cannot complete until the stdin buffer is flushed (and this is turn can't complete until the buffer is listened to via transform, in this case).

Closed to be superseded by a PR focusing on compile.dart changes.


Voting

Adds vote sorting for plugin/vote/up and plugin/vote/down
Sort by total votes, score (up - down), and decaying score (1 hour half life)

TODO: Check query plan to see if these are executed for non-sorting queries


HHH-14919 - Improve handling for java.sql.Date, Time and Timestamp

https://hibernate.atlassian.net/browse/HHH-14919

What we talked about earlier today

I believe the raw types changes shouldn't be necessary, unless I am missing something?

It makes the impl easier and really serve no purpose.  In "real usage" these are always handled in a de-typed (Object) manner.

Either way, I can clean that up later in case it's giving you trouble.

^^


added support for fakeQuantWithMinMaxVars,

currently it is ignore until quant is supported

This change is

fixed https://github.com/tensorflow/tfjs/issues/258

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[flutter_tools] UnsupportedError at _Uri._checkWindowsPathReservedCharacters when parsing assets in pubspec

On beta/3.18.0-0.1.pre.
Command: run --machine --start-paused -d chrome --devtools-server-address http://<IP_ADDRESS>:9100/ --target <redacted>/<redacted>.dart
Stack trace:
UnsupportedError: Unsupported operation: Illegal character in path: http:
at _Uri._checkWindowsPathReservedCharacters(uri.dart:1840)
at _Uri._toWindowsFilePath(uri.dart:2893)
at _Uri.toFilePath(uri.dart:2865)
at ManifestAssetBundle._parseAssetsFromFolder(asset.dart:895)
at ManifestAssetBundle._parseAssets(asset.dart:810)
at ManifestAssetBundle.build(asset.dart:265)
at <asynchronous gap>(async)
at ResidentWebRunner._updateDevFS(resident_web_runner.dart:527)
at <asynchronous gap>(async)
at ResidentWebRunner.run.<anonymous closure>(resident_web_runner.dart:320)
at <asynchronous gap>(async)
at asyncGuard.<anonymous closure>(async_guard.dart:111)
at <asynchronous gap>(async)

14 crashes to-date from one user.

I was able to reproduce this on my Windows 11 machine.

`flutter doctor -v`
[√] Flutter (Channel stable, 3.13.8, on Microsoft Windows [Version 10.0.22621.2715], locale en-US)
    • Flutter version 3.13.8 on channel stable at C:\Users\Jozz\Documents\GitHub\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c4930c4ac (8 weeks ago), 2023-10-18 10:57:55 -0500
    • Engine revision 767d8c75e8
    • Dart version 3.1.4
    • DevTools version 2.25.0

[√] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Jozz\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: E:\Programs\New folder\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.0)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34003.232
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2022.3)
    • Android Studio at E:\Programs\New folder
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] VS Code (version 1.85.1)
    • VS Code at C:\Users\Jozz\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.79.20231130

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.2715]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 120.0.6099.71
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 120.0.2210.61

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Repro steps:

Create a new flutter project.
In the assets section of your pubspec, add a list item that includes : anywhere in the path.
flutter run -d chrome (the crash does not happen when using -d windows).

14 crashes to-date from one user.

Addendum: there are about 250 crashes in total across various versions.

Up to date stack traces as of 29db9dbd44b1dbf781a84318811db676aadd6fd7 (using flutter run -d chrome):

 "http://whitehouse.gov/foo.png"

FileSystemException: FileSystemException: Exists failed, path = 'C:\Users\Jozz\Desktop\deleteme\assets_test\http:\\whitehouse.gov' (OS Error: The filename, directory name, or volume label syntax is incorrect.
, errno = 123)

#0      _Directory.existsSync (dart:io/directory_impl.dart:87:7)
#1      ForwardingFileSystemEntity.existsSync (package:file/src/forwarding/forwarding_file_system_entity.dart:43:33)
#2      ErrorHandlingDirectory.existsSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:490:22)
#3      _runSync (package:flutter_tools/src/base/error_handling_io.dart:587:14)
#4      ErrorHandlingDirectory.existsSync (package:flutter_tools/src/base/error_handling_io.dart:489:12)
#5      _AssetDirectoryCache.variantsFor (package:flutter_tools/src/asset.dart:1254:43)
#6      ManifestAssetBundle._parseAssetFromFile (package:flutter_tools/src/asset.dart:974:37)
#7      ManifestAssetBundle._parseAssets (package:flutter_tools/src/asset.dart:829:9)
#8      ManifestAssetBundle.build (package:flutter_tools/src/asset.dart:267:54)
<asynchronous suspension>
#9      ResidentWebRunner._updateDevFS (package:flutter_tools/src/isolated/resident_web_runner.dart:531:26)
<asynchronous suspension>
#10     ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/isolated/resident_web_runner.dart:319:41)
<asynchronous suspension>
#11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:24)
<asynchronous suspension>

 "http://whitehouse.gov/pictures/"

UnsupportedError: Unsupported operation: Illegal character in path: http:

#0      _Uri._checkWindowsPathReservedCharacters (dart:core/uri.dart:1840:11)
#1      _Uri._toWindowsFilePath (dart:core/uri.dart:2893:7)
#2      _Uri.toFilePath (dart:core/uri.dart:2865:38)
#3      ManifestAssetBundle._parseAssetsFromFolder (package:flutter_tools/src/asset.dart:916:29)
#4      ManifestAssetBundle._parseAssets (package:flutter_tools/src/asset.dart:817:9)
#5      ManifestAssetBundle.build (package:flutter_tools/src/asset.dart:267:54)
<asynchronous suspension>
#6      ResidentWebRunner._updateDevFS (package:flutter_tools/src/isolated/resident_web_runner.dart:531:26)
<asynchronous suspension>
#7      ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/isolated/resident_web_runner.dart:319:41)
<asynchronous suspension>
#8      asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:24)
<asynchronous suspension>

Another thing to note is that if I instead use flutter run -d windows, I don't get a crash. Instead, I get an error from VS that's even less useful than a crash:
Launching lib\main.dart on Windows in debug mode...
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(249,5): error MSB8066: Custom build for 'C:\Users\Jozz\Desktop\deleteme\assets_test\build\windows\x64\CMakeFiles\2103228256e52c9a1428711c685a3aa3\flutter_windows.dll.rule;C:\Users\Jozz\Desktop\deleteme\assets_test\build\windows\x64\CMakeFiles\b847e1c2ab5b4b4fa16f57a4fdf59571\flutter_assemble.rule' exited with code 1. [C:\Users\Jozz\Desktop\deleteme\assets_test\build\windows\x64\flutter\flutter_assemble.vcxproj]
Building Windows application...                                     5.9s
Error: Build process failed.


KeyError(1) while parsing output from applying flake8

Hi
Running nbqA flake8 over notebooks in a set of directories, I encountered a few errors of the form:
KeyError(1) while parsing output from applying flake8 to ...

I will try to dig into the notebooks to see what the problems appear to be and raise a separate issues as appropriate, but more generally it would be useful if nbQA could trap these errors rather than erroring and then publishing a notice or error file capturing the errors.
In passing, would it be worth adding to docs a simple example recipe for excluding multiple files with different filename patterns for folk who aren't overly familiar with regex? eg I am using a pattern of the form nbqa flake8 --nbqa-exclude "(.*02.2.*)|(.*07.1.*)|(.*07.2.*)"  Part\ *\ Notebooks/*.ipynb with | separated bracketed expressions.

no code cells!

I can't reproduce this, I just tried running nbqa flake8 tests/data/empty_notebook.ipynb and it didn't report anything. Do you remember which command you ran? Could you show the output of flake8 --version please? Thanks 👍

Here's a file that fails for me (will expire in a week) with a simple nbqa flake FILENAME command.

Still can't reproduce:
% nbqa --version
nbqa 0.8.0
% flake8 --version
3.8.4 (mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.5 on Darwin
% nbqa flake8 t.ipynb
t.ipynb:cell_2:1:121: E501 line too long (202 > 120 characters)
t.ipynb:cell_11:1:1: E402 module level import not at top of file

Does flake8 --version not show anything between the brackets for you?

In situ:
nbqa --version
nbqa 0.8.0

flake8 --version
3.8.4 () CPython 3.9.4 on Darwin

nbqa flake8 Part\ *7*/*.ipynb
KeyError(1) while parsing output from applying flake8 to Part 07 Notebooks/07.1 Spreadsheet basics.ipynb
Please report a bug at https://github.com/nbQA-dev/nbQA/issues

I'm running over may 100 notebooks and that error report on maybe 10 of them, five of which have no code cells. I will try to investigate what is throwing the issue in erroring notebooks.

Does the error happen even if you only run on Part 07 Notebooks/07.1 Spreadsheet basics.ipynb alone, or only if you run it on Part\ *7*/*.ipynb?

The regex works fine just as a shortcut into a set of files (which makes it easy for me to run checks over lots of notebooks); the issue definitely that file...
nbqa flake8 Part\ 07\ Notebooks/07.1\ Spreadsheet\ basics.ipynb
KeyError(1) while parsing output from applying flake8 to Part 07 Notebooks/07.1 Spreadsheet basics.ipynb
Please report a bug at https://github.com/nbQA-dev/nbQA/issues

(Apols, not had a chance to dig into the detail debug myself; my immediate concerns are fixing the notebooks, not the debug tools helping me identify issues in the notebooks...)

No worries about debugging it, but is Part\ 07\ Notebooks/07.1\ Spreadsheet\ basics.ipynb  the file which you posted above in pastebin? If so, I'm really confused about why it would fail for you but not for me. If not, any chance you could post that exact notebook somewhere and I'll take a look?

Yep, same file...
https://gist.github.com/psychemedia/2e05c7a4aac8002bf9a26c7d97920a9f
Could there be any side effects from other flake8 packages (either present or absent?). Possibly unusual things in the notebook include jupytext markup (I also run dev versions of jupytext in pretty much all my environments).

Other things in various notebooks - code blocks in markdown cells, including language qualified fenced codeblocks in markdown cells.

Could there be any side effects from other flake8 packages (either present or absent?)

Yes, that's what I'm thinking...do you remember if you have any flake8 extensions installed? Perhaps could you show the output of pip freeze? @s-weigand any ideas?
Thanks for being so helpful here with debugging by the way, really appreciate it! 🙏

flake referenced packages in filename... (thanks for being so persistent with this, debuggong a possibly problem w/ my setyup....:-)
pip3 freeze |grep .*flake.*
flake8==3.8.4
flake8-bugbear==20.11.1
flake8-builtins==1.5.3
flake8-docstrings==1.5.0
flake8-nb @ file:///Users/tonyhirst/Documents/GitHub/flake8-nb
flake8-polyfill==1.0.2
nb-report-injecter @ file:///Users/tonyhirst/Documents/GitHub/nbqa-inject-flake8-report
pyflakes==2.2.0

I'll upgrade all those now to see if it helps...

Okay.. that errored; just uninstalled everything, including nbqa and then installed latest nbqa from pip again; that gave a missing flake8 dependency; installed that, tried again, missing flake8-polyfill dependency, tried again and it passed.
So from this I learn: nbqa has undeclared dependency on flake8 and flake8-polyfill.
If I now try to add things back in:

flake8-builtins continues to work;
flake8-docstrings fails with KeyError(1) while parsing output from applying flake8
uninstall flake8-docstrings, install flake8-bugbear, continues to work.

So flake8-docstrings-1.6.0 is messing things up.

Nice! Thanks @psychemedia , now I can reproduce the error!

So from this I learn: nbqa has undeclared dependency on flake8 and flake8-polyfill.

Just to be clear, nbqa just requires you to have installed whatever tool you want to run. E.g. to run nbqa flake8, you need to have installed flake8, to run nbqa pyupgrade, you need to have installed pyupgrade, etc.

@all-contributors please add @psychemedia for bugs

Hey @psychemedia - I believe this should be fixed in version 0.8.1, would really appreciate it if you could install it and check (pip install nbqa==0.8.1)

Yep, that's free of errors for me on that notebook now. Thanks :-)


Does obj2gltf has draco support

The document doesn't show draco options and will this tool support draco in the future?

Draco will probably not be added here but you can use gltf-pipeline.


Support (rare) Type3 fonts with Pattern resources (issue 16127)

This simply extends the approach in PR #10727 to also cover Patterns, which shouldn't be a common occurrence in Type3 fonts (since this is the first issue we've seen).

/botio test

/botio makeref

/botio-windows makeref


AVRO-3749: [Java] avoid conflict in method name for generated code

What is the purpose of the change
As decribe in JIRA  AVRO-3749, SqlCompiler can generate same method name when field name start with undescore '_' name.
hence, a schema with fields
"x", "X", "_x"
generates several method getX$0(), and source can't compile.
With this PR, it will generate getX() of x, getX$0 for X and getX$1() for _x
(but a schema that contains only field _x will generate only getX() method.)
For each field, it count number of collision with "preceding fields" to generate method. Preceding is defined with order, number of underscore (start with 0), and, for same number of underscore, start with lower case.
This PR can also modify the generated code for a given schema. thats why ipc TestSpecificCompiler is modify.
Verifying this change
new Unit test on TestSpecificCompiler for compiler module.
Test on TestSpecificCompiler for module IPC is changed.
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Nicely done! I like that the method calcNameIndex (also) documents the "no index" case.
This does, however, adjust the generated index (as indicated by the adjusted IPC test). This breaks existing code written against it.
A question: do such duplicate fields occur little enough that breaking code is worth the visual improvement (I like it, other may not)?

do such duplicate fields occur little enough that breaking code is worth
Well, i don't know the frequency of duplicate fields issue in Avro client usage (at least an issue for author's AVRO-3749), but as breaking change occurs only when schema contains duplicate fields, i think it's ok. May be need a discussion on dev mailing list.


[NME] Regression: Elbow blocks should not have a target parameter

We changed elbows a while ago to remove the target parameter since there is no reason an elbow should be able to change the target of the previous block they are wired to as this should only be possible on the non-elbow blocks to help comprehension. You don't want parameters that can break a shader hiding in a random elbow block. Such as when an elbow modifies the world normal block to a neutral target.
In NME v5.14.0, elbow blocks have a Target parameter again and this should be removed for clarity in the graph.

There was no change for elbow recently.
can you reproduce it?

And I confirm that elbow still uses their source connection to evaluate

This was the culprit of this error in the PBR node material I made yesterday:

It happened because I dropped elbow nodes into the path of the world normal which changed the target to Neutral. Alexis mentioned we have an issue with the world matrix being calculated twice and that the target of a block using the world matrix not being set to Vertex can cause this issue. All the blocks were, but the elbows changed the target to Neutral. Changing them to Vertex corrects the issue, so it seems that somehow the elbow is still exerting some control over the target.


After upgrading vscode, debugger in dotnet core does not work anymore

Just right after I upgraded the vscode, I was not able to debug anymore. I click to debug test and start the compilation process and just right after start the debugging process got this:
Failed to start debugger: "System.InvalidOperationException: The debugger could not be started\n  at OmniSharp.DotNetTest.Services.DebugTestService.Handle (OmniSharp.DotNetTest.Models.DebugTestGetStartInfoRequest request) [0x00044] in <66fbc68f45b847819d5287ab3b7082c9>:0 \n  at OmniSharp.Endpoint.Exports.RequestHandlerExportHandler2[TRequest,TResponse].Handle (TRequest request) [0x00000] in <f11ec2bb20ee4123b1374adc4be3230b>:0 \n  at OmniSharp.Endpoint.EndpointHandler2[TRequest,TResponse].HandleSingleRequest (System.String language, TRequest request, OmniSharp.Protocol.RequestPacket packet) [0x0008a] in :0 \n  at OmniSharp.Endpoint.EndpointHandler`2[TRequest,TResponse].Process (OmniSharp.Protocol.RequestPacket packet, OmniSharp.Endpoint.LanguageModel model, Newtonsoft.Json.Linq.JToken requestObject) [0x0024b] in :0 \n  at OmniSharp.Stdio.Host.HandleRequest (System.String json, Microsoft.Extensions.Logging.ILogger logger) [0x000e7] in <42872752b63d489cb58d6862f71b060f>:0 "
Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
Version:   2.2.300
Commit:    73efd5bd87
Runtime Environment:
OS Name:     debian
OS Version:  9
OS Platform: Linux
RID:         debian.9-x64
Base Path:   /usr/share/dotnet/sdk/2.2.300/
Host (useful for support):
Version: 2.2.5
Commit:  0a3c9209c0
.NET Core SDKs installed:
2.1.700 [/usr/share/dotnet/sdk]
2.2.300 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.11 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.11 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.11 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version: 1.34.0
C# Extension version: 1.19.1
As mentioned before, everything was okay during months ago until I decided yesterday to upgrade the vscode.
Thanks in advanced.

I'm observing the same issue here:
.NET Core SDK (reflecting any global.json):
 Version:   3.1.300
 Commit:    b2475c1295

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19041
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.1.300\

Host (useful for support):
  Version: 5.0.0-preview.6.20305.6
  Commit:  4ba9ecaabd

.NET SDKs installed:
  2.1.802 [C:\Program Files\dotnet\sdk]
  2.2.402 [C:\Program Files\dotnet\sdk]
  3.0.100 [C:\Program Files\dotnet\sdk]
  3.1.100 [C:\Program Files\dotnet\sdk]
  3.1.300 [C:\Program Files\dotnet\sdk]
  5.0.100-preview.6.20318.15 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.18 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.18 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.0-preview.6.20312.15 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.0-preview.6.20305.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.1.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.0-preview.6.20308.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

VsCode at: 1.47.2
c# extension: 1.22.1

Looks like this issue got missed. @enzian you are seeing the same problem with Unit test debugging showing an error: "Failed to start debugger: "System.InvalidOperationException: The debugger could not be started\n at..."?
Both @enzian and @diegotrujillor (assuming you haven't given up) --
You can debug non-unit tests normally?
What type of test are you trying to debug? (ex: xunit, mstest, etc)
If OmniSharp got far enough to ask the debugger to launch, you can enable debugger logging which might reveal the problem -- https://github.com/OmniSharp/omnisharp-vscode/wiki/Enabling-C%23-debugger-logging#quick-method-for-unit-tests. Can you try that and see if that produces anything?

@enzian you are seeing the same problem with Unit test debugging showing an error: "Failed to start debugger: "System.InvalidOperationException: The debugger could not be started\n at..."?

Yes, I do!
You can debug non-unit tests normally?

Yes, I can.
What type of test are you trying to debug? (ex: xunit, mstest, etc)
XUnit
I do get errors in the output that, I do not get, when building using the CLI or the vscode build tasks. These tasks, in my case, build in the solution directory and do so without errors. So das dotnet test, also in the solution directory and without errors.

Not sure if this is any indicator, but we have $(SolutionDir) references in the .csprojs project reference paths? The errors I'm getting indicate, that these references cannot be resolved... (there no warning indicating this)
I do get errors when running dotnet test directly in the test projects directory, but not when running it from the solution directory.

Unfortunately I think you are going to need someone from the language service side of the extension to have a look -- I only know the debugger side. There does seem to be some change that has occurred with XUnit tests as I have seen a lot more issues come in lately.
Did you try enabling the debugger log? Did that do anything?
Is your project sharable by chance?

Is your project sharable by chance?

Not really, but I may be able to make a repo that reproduces the circumstances!

I hit this issue today when for the first time I tried "Debug Test" from a unit test.  I just resolved the issue.  I'm not sure of the root cause but I'll describe my steps in any case.
Before fixing, I enabled OnniSharp debug logs as mentioned above and put them in this gist.  This was the error that started with System.InvalidOperationException: The debugger could not be started....
I then found this page and changed the launch.json setting console to "IntegratedTerminal" per those instructions.
I then kicked off a normal debug session per this section (which I didn't ever do before - I was launching from a unit test) and it worked...
I then tried the "Debug Test" option above the Unit Test and it worked too.
Hopefully someone will find this useful and save some time.


Wrong install path for gdk-pixbuf plugin

gdk-pixbuf plugin will currently install in a wrong path when cross-compiling because pkg_get_variable(GDK_PIXBUF_MODULEDIR gdk-pixbuf-2.0 gdk_pixbuf_moduledir) will unfortunately return the absolute path on the build machine.
See this idea and this idea for potential fixes.

Should be fixed via #1040


[FEATURE] Willpower Rerolls updating the original message

Is your feature request related to a problem? Please describe.
Willpower reroll should return a new chat message with the un rerolled dice to calculate successes and keep track of previous ankhs.
Describe the solution you'd like
Either send a rerolled message with all the dice or edit the rerolled message

I plan to rework the Willpower Reroll system in the near future to:

[ ] Update the message that the rerolls are made from
[ ] Grey out any rerolled dice
[ ] Insert the new dice in the appropriate spots
[ ] Mark on the chat message with a footer if a point of Willpower damage has been dealt to the actor (if that automation is toggled on)

Additionally...

[ ] Fix the UI of the die selector to look better


Map/Stop Ux Improvements

Work that fell out of #1331 that needs to be completed for 18.2.

[x] scroll the map when the user selects an annotation so that the annotation is visible
[x] Why is 'nearby' only showing 1 item?
[ ] Show toolbar on embedded stop page (maybe as a pair of buttons under title?)

+1 on the new design but can we have a toggle for the tap-vibration?

@wesmi The feedback should've been turned off altogether. Thanks for the note. I'll get this fixed in the next build.

broken into separate tasks. Closing this.


Manage Allocations page duplicates Allocations if Save button is clicked multiple times

The Manage Allocations page duplicates Allocations if the Save button is clicked multiple times.  This causes the Opportunity to become improperly allocated.

Fixed By #5269

Included in beta release 1.0 (Beta 2)


mscolab UI misses a rename Project

We have in mscolab UI not implemented to rename a project.
update_project can be used, from the file_manager

Hey @ReimarBauer @joernu76 I am also having a look on this if I can solve this.


GraphCDN Integration

GraphCDN is a caching layer that lives between Wordpress and Next.js. It's been helpful on several recent installs where Next.js usage was high due to repetitive GraphQL requests. Getting sites setup has been pretty easy, but there's a few things we can do to make the integration tighter

[x] Document ideal GraphCDN/GraphQL plugin configuration values (considering preview mode, etc)
[x] Implement targeted GraphCDN purge caching when a post in Wordpress is updated

The google login plugin breaks cache, need to add our cookies handler to clear.

In addition to adding docs (which are ready), let's also use graphcdn in our default env.sample (and on our live testing site)

We have graphcdn, we have docs now, closing out.


Add 'not found' page UI

currently when we open any unknown route on UI, we just get a blank page. Instead we must define a 404 not found page.
Please design a good 'Not Found' page and return it for all unknown routes.

I’ll take it