SCons: Format buildsystem files with psf/black

Configured for a max line length of 120 characters:
find \( -name "SConstruct" -o -name "SCsub" -o -name "*.py" \) -exec black -l 120 {} \;

psf/black is very opinionated and purposely doesn't leave much room for
configuration. The output is mostly OK so that should be fine for us,
but some things worth noting:

Manually wrapped strings will be reflowed, so by using a line length
of 120 for the sake of preserving readability for our long command
calls, it also means that some manually wrapped strings are back on
the same line and should be manually merged again.

Code generators using string concatenation extensively look awful,
since black puts each operand on a single line. We need to refactor
these generators to use more pythonic string formatting, for which
many options are available (%, format or f-strings).

CI checks and a pre-commit hook will be added to ensure that future
buildsystem changes are well-formatted.

Review comments welcome to identify locations where the formatted output doesn't look good and could be improved (which means changing the code, as we can't configure the formatter beyond line length).
As I mentioned in the OP, code generators look ugly and should be refactored, but it's a significant amount of busy work so I'm leaving it for a future PR (or a contributor? ;)).

As I mentioned in the OP, code generators look ugly and should be refactored, but it's a significant amount of busy work so I'm leaving it for a future PR (or a contributor? ;)).

Worth noting SCons provides Textfile() and Substfile() builders which could likely help this to some extent.


July 1st, 2024 Community Meeting

Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
(optional) Paste the image of an animal 😸

Discuss on v0.14.0 release date.
New SHIP on release automation. Reach out if interested.

Meeting minutes:

We don't have any formalities on the release cadence. v0.13.0 was released at the beginning of May.  A proposal would be to ship v0.14.0 4 or 3 months after. A proposal is to do this by the beginning of September 2024.
Call to action on working for a SHIP for release automation.


chore(deps): upgrade to Erlang 18.3

There were the following issues with your Pull Request

Commit: 34d97e94c69ffdfd3e59a4cde252c370670d3d8e
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/benlangfeld/QueueFlex/blob/master/CONTRIBUTING.md#pull-requests

This message was auto-generated by https://gitcop.com


Minor fixes on env vars and runtime for kubernetes

First of all: this is an awesome project!
This commits changes the following:

The vars on k8s deployment of the karavan-app
As all variables were lowercase, quarkus did not see them, resulting in errors (like not finding the git repo's URL)

Adds the JAVA_OPTS unused var to the command line used to run karavan-app
The var was been defined on the Dockerfile, but not used on the final command
With this change, It was replaced the docker 'exec form' with the 'shell form' so we can use the env var (or else we could not use it, as it has multiple values). I took caution to use the exec command to replace the shell by the java process (so it continues to receive OS signals)

Adds a default runtime to the build.sh script for k8s, or else when creating an integration using only the karavan-app on k8s (did not tested with vscode extension) de build was failing with 'The runtime option must be specified'

There are more stuff that I wish to contribute (for example: there is an error on git checkout when the repo's HEAD does not exist, even if we would not use it ), but let's see if those simple ones here are accepted first :)

Thanks @thgruiz !


Support for getting a list of all revisions that were made of a specific entity class

Currently it is not possible to search the revision history for specific audited entities. This will allow you to add a filter with one or more entity classes.

@sebastianreloaded , can you:

squash the commits
use ~2.2 as version constraint? probably some more fixes may apply, but I don't want to raise the requirement
update the doc?

Thanks!

@andrewtch no problem, will do that.

Hey,
Just working on something lately and this would be a pretty useful feature.
Alternative seems to be to get the history of each entity in a collection which ends up being over 1000 database queries in my test run.

Hey, can you revert the changes in the composer.json and rebase it? Thanks!

Could you please rebase your PR and fix merge conflicts?


Fixes #53 for Rails 5 compatibility.

Here is a version that works with Rails 5 with passing tests for previous versions. I had to add a number of Rails version conditionals to get the tests to pass for Rails 3 and 4. I had to tell Rubocop to ignore lines with positional parameters. I also had to remove Ruby  2.2.4 from the Travis build because ruby_dep is never going to install in 2.2.4.
I'm happy take second passes at things.

I guess there are multiple Rails 5 requests. I originally meant to fix #25 but it's late and the holidays. :beers:


Add Wide&Deep model

For this we first need:
#153

Can we do a version of this that doesn't utilize the two optimizers in the meantime?

ETA: 3/18


Update Import Flow to Match Designs

This updates our import flow (and confirmation dialog) to match our v1 designs.
I tried reusing https://github.com/microsoft/pxt/blob/master/webapp/src/draganddrop.ts, by moving it into browserutils and adding extra events for when drag enters and exits/leaves, but it didn't quite work out. The enter and exit events caused a lot of flickering when hovering over child elements, which I believe would require a workaround somewhat like the one I've described in the DragAndDropFileSurface in this PR. I wasn't comfortable adding that workaround at such a global scale (and it isn't necessary when you don't care about enter/exit), so I decided not to reuse.
Upload target: https://makecode.microbit.org/app/5fc5d7fc1489c936a8bdc40422b6a5b3a5926855-6b68fdda25--eval
Screenshots
Import:

File hover:

Confirm:

Invalid file:

Small screen:

I tried dropping tsconfig.json and got this error in the console:

I tried dropping tsconfig.json and got this error in the console:

Good catch. Added a check in verifyRubricIntegrity to ensure criteria is not undefined.


Add "Other medical issue" #631

I rule and have completed some work on Case Manager that's ready for review!
I updated "Fetal anomaly" to "Fetal diagnosis" and added check boxes for "Other medical issue" and "Undocumented".
This pull request makes the following changes:

Updated the special circumstances check boxes per user feedback

(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:

Fixes #631

Kevin said that if we need to update previous entries for "Fetal anomaly" we will have to write a script to run through and update those entries. Is this something we want to do? I'd be happy to tackle that as well if the answer is yes. I'd just need to discuss with you what the production environment is running on.

@KatSDC yeah, @Kevin-Wei is right, since we're storing this as an array of strings we'll want to bulk update it. If you want to dig into that I'd appreciate it -- you can probably whip something up using the rails console in a dev environment, if that makes sense -- but we can backlog it otherwise.
Code looks good to me, I'll plan on having this deployed next Sunday during our regularly scheduled release window.

ps thank you!! This is something a couple of CMs have asked for recently, esp as we've moved onto all three lines, so this is very timely.

@KatSDC nice work up in here -- love how clean this turned out! I've spun out the task to update these entries in our prod db to #786.


Investigate CI/CD process for the monorepo

Arising from #7; we have to find a  way to manage our CI/CD pipeline process given the new proposed monorepo structure.

Will update with specifics once i have at the least thought out the specifics that this issue targets.

@cKellyDesign
I do not think that we are producing and sending coverage data to coveralls in the correct way,.. A possible symptom of this can be observed from this build where I added a testcase but instead of the test coverage rising or stagnating, it fell.
IMO, I would ideally want the packages project and each of the client application projects in the clients folder to be able to generate their own coverage data. This data would then preferably be sent to a static code analysis web tool separately, and display it on github  as shown below.

AFAIK only codecov provides functionality that would easily enable us to do the above, we however use coveralls.
For coveralls; we could generate the coverage data separately during a ci build then merge them into a single .lcov file and upload that to coveralls
I strongly feel that this will help us get a better sense of exactly which files and in which project the code coverage changed.
Also testing would now be localized per project and the package.json testing script would feel more natural and less hacky


Potential naming conflict

A few redditors have pointed out the fact that the name of this project conflicts with that of a particular GUI crate, which has probably been around longer than this project has.

That could only be an issue when both are disassemblers which is not the case. Even companies can share a name when they are doing different stuff. And many companies share their name already without its being a legal issue. If your only argument is that both share the same name, then go ahead and try convincing Apple to change their name as its conflicts with a fruit name that has been around longer than their product name 🤷♂

I don't think this will confuse anyone since they have different names on crates.io and each crate's description + README clearly explains what it is and how to add it to your cargo.toml.

which has probably been around longer than this project has.

FYI, it's easy to check this since both are on github, so there's no reason to guess. (hint: this project is older)


vlc: add skin support

Motivation for this change
Lack of support to skins in the NixOS VLC compilation
Things done
Add this support as an option in the package

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Also, please squash your commits.

Also, please squash your commits.

IDK why this is happening but when I force push my squashed commits it pushes the commit before it too.
The hash changes because the commit before change too. Probably for the merge it will be necessary to cherry-pick the commit to master.

IDK why this is happening but when I force push my squashed commits it pushes the commit before it too.
The hash changes because the commit before change too. Probably for the merge it will be necessary to cherry-pick the commit to master.

IDK why this is happening but when I force push my squashed commits it pushes the commit before it too.

if you're doing git rebase -i, you're probably specifying a range which includes the commit before yours. You can do git branch --set-upstream-to=origin/master to enable just doing git rebase -i and git will be able to determine your specific commits
git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

IDK why this is happening but when I force push my squashed commits it pushes the commit before it too.

if you're doing git rebase -i, you're probably specifying a range which includes the commit before yours. You can do git branch --set-upstream-to=origin/master to enable just doing git rebase -i and git will be able to determine your specific commits
git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.elisa
libsForQt514.elisa

21 packages failed to build and are new build failures:

libsForQt5.elisa: log was empty
(kdeApplications.elisa: log was empty
,libsForQt515.elisa): log was empty
libsForQt5.phonon-backend-vlc: log was empty
(libsForQt515.phonon-backend-vlc): log was empty
libsForQt512.phonon-backend-vlc: log was empty
libsForQt514.phonon-backend-vlc: log was empty
libvlc: log https://termbin.com/pzpz
megaglest: log was empty
minitube: log was empty
obs-move-transition: log was empty
obs-ndi: log was empty
obs-studio: log was empty
obs-v4l2sink: log was empty
obs-wlrobs: log was empty
pympress: log was empty
python37Packages.python-vlc: log was empty
python38Packages.python-vlc: log was empty
python39Packages.python-vlc: log was empty
strawberry: log was empty
tribler: log was empty

1 package built:

vlc (vlc_qt5)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.elisa
libsForQt514.elisa

21 packages failed to build and are new build failures:

libsForQt5.elisa: log was empty
(kdeApplications.elisa: log was empty
,libsForQt515.elisa): log was empty
libsForQt5.phonon-backend-vlc: log was empty
(libsForQt515.phonon-backend-vlc): log was empty
libsForQt512.phonon-backend-vlc: log was empty
libsForQt514.phonon-backend-vlc: log was empty
libvlc: log https://termbin.com/pzpz
megaglest: log was empty
minitube: log was empty
obs-move-transition: log was empty
obs-ndi: log was empty
obs-studio: log was empty
obs-v4l2sink: log was empty
obs-wlrobs: log was empty
pympress: log was empty
python37Packages.python-vlc: log was empty
python38Packages.python-vlc: log was empty
python39Packages.python-vlc: log was empty
strawberry: log was empty
tribler: log was empty

1 package built:

vlc (vlc_qt5)

Please fix the libvlc build failure.

Please fix the libvlc build failure.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.elisa
libsForQt514.elisa

21 packages failed to build and are new build failures:

libsForQt5.elisa: log was empty
(kdeApplications.elisa: log was empty
,libsForQt515.elisa): log was empty
libsForQt5.phonon-backend-vlc: log was empty
(libsForQt515.phonon-backend-vlc): log was empty
libsForQt512.phonon-backend-vlc: log was empty
libsForQt514.phonon-backend-vlc: log was empty
libvlc: log https://termbin.com/1nnw
megaglest: log was empty
minitube: log was empty
obs-move-transition: log was empty
obs-ndi: log was empty
obs-studio: log was empty
obs-v4l2sink: log was empty
obs-wlrobs: log was empty
pympress: log was empty
python37Packages.python-vlc: log was empty
python38Packages.python-vlc: log was empty
python39Packages.python-vlc: log was empty
strawberry: log was empty
tribler: log was empty

1 package built:

vlc (vlc_qt5)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.elisa
libsForQt514.elisa

21 packages failed to build and are new build failures:

libsForQt5.elisa: log was empty
(kdeApplications.elisa: log was empty
,libsForQt515.elisa): log was empty
libsForQt5.phonon-backend-vlc: log was empty
(libsForQt515.phonon-backend-vlc): log was empty
libsForQt512.phonon-backend-vlc: log was empty
libsForQt514.phonon-backend-vlc: log was empty
libvlc: log https://termbin.com/1nnw
megaglest: log was empty
minitube: log was empty
obs-move-transition: log was empty
obs-ndi: log was empty
obs-studio: log was empty
obs-v4l2sink: log was empty
obs-wlrobs: log was empty
pympress: log was empty
python37Packages.python-vlc: log was empty
python38Packages.python-vlc: log was empty
python39Packages.python-vlc: log was empty
strawberry: log was empty
tribler: log was empty

1 package built:

vlc (vlc_qt5)

Your last commit does not fix libvlc which I expected because currently it does nothing at all.

Your last commit does not fix libvlc which I expected because currently it does nothing at all.

I think now libvlc is fine xD
When you asked to fix I didn't understand how to fix the problem then, before sleep, I realized that the problem is skins2 enabled in libvlc, that doesn't make sense, then I set skins2 default parameter to false if libvlc is being built.
This is the first PR that I sent that I was scared because I broke something and I didn't know how to fix it but this kind of problem usually has the solution right before sleep xD. It was an honor question, I must find this solution.
This is one of the things that makes programming awesome.

I think now libvlc is fine xD
When you asked to fix I didn't understand how to fix the problem then, before sleep, I realized that the problem is skins2 enabled in libvlc, that doesn't make sense, then I set skins2 default parameter to false if libvlc is being built.
This is the first PR that I sent that I was scared because I broke something and I didn't know how to fix it but this kind of problem usually has the solution right before sleep xD. It was an honor question, I must find this solution.
This is one of the things that makes programming awesome.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

1 package built:

vlc (vlc_qt5)

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
vlc:

Please consider this feature to be alpha:
A substituteInPlace with an unused --replace got detected:
substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'configure'

Please check the offending substituteInPlace for typos or changes in source.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109235 run on x86_64-linux 1

1 package built:

vlc (vlc_qt5)

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
vlc:

Please consider this feature to be alpha:
A substituteInPlace with an unused --replace got detected:
substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'configure'

Please check the offending substituteInPlace for typos or changes in source.


Add proxy support for benchmarking #382

This pull request adds proxy support for benchmarking via the http_proxy environment variable, and closes #382.
As suggested by @danielmitterdorfer, a urllib3.ProxyManager is utilised.
In addition it is necessary to monkey patch elasticsearch.connection.Urllib3HttpConnection in order that the perform_request method prepends the correct scheme, host and port to the path. This is required due to the different semantics of direct HTTP v.s. proxied requests in urllib3.
Support for SSL and round-robin-ish connection selection is included.
Real-world testing can be accomplished using a default install of squid on ubuntu.
Finally, please note that this would be a breaking change for any users who currently use a proxy for downloading benchmarking-related data, but not for the benchmarking operation itself. For such cases, an additional environment variable esrally_benchmark_no_proxy may be set as described in docs/configuration.rst

@maharg101 Thank you for your PR! Sorry for the delay here, we are looking at it (and also doing some benchmarking) and will get back to you.

Hi @dliappis - thanks for the response. Yes, I agree it is much simpler to add proxy functionality to the elasticsearch python client. There have been several requests for proxy functionality over the years which were not implemented.
The monkey patch - or use of super() - to modify the behaviour of perform_request was required. If not, then the perform_request method calls the ProxyManager.urlopen method with only the path part, which is not a valid url to request from a proxy server. That is to say it would ask for the proxy for /_cluster/health rather than http://somehost:9200/_cluster/health.
I agree with the point about the load balancing, it was either that, or only ever use the first host (or a random host) from the list of hosts specified by the user.
I look forward to proxy support in elasticsearch-py 👍


fs.meta.save lost data

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Describe the bug
I want to change a new filer storage.
so i use fs.meta.save to dump data.
but it lost many data.
System Setup
List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
/data/seaweedfs/weed master -port 19333 -ip <IP_ADDRESS> -ip.bind <IP_ADDRESS>
/data/seaweedfs/weed filer -master=<IP_ADDRESS>:19333 -port=9998 -port.readonly=9999
/data/seaweedfs/weed volume -dir=/data/seaweedfs/vol1 -max=15 -mserver="<IP_ADDRESS>:19333" -port=18080 -ip=<IP_ADDRESS> -ip.bind=<IP_ADDRESS>

use shell command
./weed shell -master <IP_ADDRESS>:19333
> fs.cd http://<IP_ADDRESS>:9998/
> fs.meta.save
...
...
/images/666kb.com/i/e3l7c2udy8y7q49og.jpg
/images/666kb.com/i/e3l7cjwpdknks77y8.jpg
/images/666kb.com/i/e3l7d8luxemvrvaww.jpg

total 56695 directories, 94760 files
meta data for http://<IP_ADDRESS>:9998/ is saved to <IP_ADDRESS>-9998-20190806-064321.meta
>

Expected behavior
There should actually be 8.4 million files.
➜  ~ redis-cli
<IP_ADDRESS>:6379> DBSIZE
(integer) 8409980

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Can not debug unless you have a dump of your redis database.

make sure your redis do not evict keys.

redis info
# Stats
evicted_keys:0

I'm sure there no evicted keys

fine. need to have a reproducible case.

I just sliced the data in the interrupted position, tried to reproduce it.  But it run ok.
So I guess the reason for the lack of memory,
Now I try to increase the memory to reproduce

Not a memory problem.
It seems that it can only be reproduced when the amount of redis data is particularly large.
May be a recursion problem in command_fs_meta_save.go
The dump.rdb is 1.2G.
I'm trying to reproduce in my local redis.

If you can upload the dump to somewhere, I can try to reproduce it locally also.

Ok, thank you. I will send dump.rdb to your email.

....I forgot. I don't have your email yet.

fixed in https://github.com/chrislusf/seaweedfs/commit/fb3c9ed80d37a08dcf9f8f6a926e7734816a2a63

Excuse me？How can I transfer the metadata in redis to MySQL?


allow asdf 2.10

Changes

add asdf 2.10 back since the conda build seems to work now

asdf 2.10 now also works from conda so I think we can put this back in?
feedstock PR: https://github.com/conda-forge/weldx-feedstock/pull/15

LGMT! Thanks.


Add "timestamp without time zone" as supported data type

Amazon Redshift has a data type "timestamp without time zone" which isn't supported by the target yet (only "timestamp with time zone" is supported via target-postgres)

Data Type
Aliases
Description

TIMESTAMP
TIMESTAMP WITHOUT TIME ZONE
Date and time (without time zone)

TIMESTAMPTZ
TIMESTAMP WITH TIME ZONE
Date and time (with time zone)

Source: https://docs.aws.amazon.com/redshift/latest/dg/c_Supported_data_types.html
So when target-redshift scan the destination schema, the following error occurs:
File "/app/target/.venv/lib/python3.7/site-packages/target_postgres/postgres.py", line 782, in sql_type_to_json_schema
    raise PostgresError('Unsupported type `{}` in existing target table'.format(sql_type))
target_postgres.exceptions.PostgresError: Unsupported type `timestamp without time zone` in existing target table

@pcorbel does target-redshift/target-postgres create TIMESTAMP WITHOUT TIME ZONE columns somewhere?
Currently, the thinking is that the only supported tables are those that the target created.

@AlexanderMann
does target-redshift/target-postgres create TIMESTAMP WITHOUT TIME ZONE columns somewhere? --> No
I  agree that only supported tables are those that the datamill-co/target-redshif created.
However, as of today, we need the totality of the tables in the schema to be created by datamill-co/target-redshif.
We can't have:

schema_a/table_stitch
schema_a/table_manually_created
schema_a/table_singer_datamill

But only:

schema_a/table_stitch
schema_a/table_manually_created
schema_b/table_singer_datamill

@pcorbel do you know whether you're getting these errors on just running the target, or is it when a stream you're processing tries to persist to a table created by some other means?
ie, is it:

stream FOO tries to persist to remote table foo a table created and maintained by target-redshift

another table, bar, exists in the remote schema which has been created by another process

stream FOO tries to persist to remote table foo which exists in the remote schema which has been created by another process

I ask, because I think the guidance has been that targets should probably be run in their own schemas and if they happen to work alongside other processes, that's great, but not a given. For target-redshift specifically, we've turned down trying to support tables not created and maintained by target-redshift.
The reason for this is that the stores a tonne of metadata into the remote table's COMMENT and has to use that for most operations.

@AlexanderMann It is the 1 case you mentioned.
My usecase is that I would like to migrate some tables from Stitch to in-house extraction.
To be able to do it in a transparent and smooth way, I would like my end users to use the same table name, in the the same schema name. It is just the extraction that would be different.

Fascinating. So @pcorbel to be clear, you are not looking to mix and match maintenance of tables between target-redshift and something else, but rather are looking to simply use it inside a schema which has other things in it?
If yes, I think we should identify where the code is blowing up by pulling in other stuffs first, as I can easily see this becoming a game of whack-a-mole with types etc.


Add paramterScaler with an usage example and deprecate VoltageDivider

Here I propose an enhanced version of the VoltageDivider. Compared to it, it has the ability to set either a division or a gain, depending on the nature of the instrument attached to it. Unit of the resulting parameter can be changed. Moreover, the gain/division can be a Qcodes parameter, in the case that is set by a remote instrument and not locally.
We are using this object in SpinQubit group in QuTech since few months with modules in IVVI/SPI racks, so it's well tested on the field.
@WilliamHPNielsen, @jenshnielsen

Any news for this PR? @WilliamHPNielsen, @jenshnielsen

Sorry for the delay @YakBizzarro I am not absolutely sure this it the way we want to do this in the long term but for now it should be fine. I would prefer not to deprecate the voltage divider just yet. And I would very much like to see this have some tests if possible

Thank you for the feedback @jenshnielsen , I'll try to write some tests. BTW, what are the plans for the long term?

Not very concrete at the moment but we want to design some more generic objects that can abstract multiple instruments and how they interact

@jenshnielsen tests added

@astafan8 Ok, I made the modifications that you suggested, except for the factory and role

Btw, initially I put this class in qcodes/instruments_drivers/devices.py because I was extending VoltageDivider, but since now it's a very generic helper, would it better to have it in qcodes/instrument/parameter.py?

Is it good now or should I do some other modification?

@YakBizzarro yes, there is a discussion going on here about whether the "role" part is needed at all. could you take a look?

@astafan8 ops, completely missed it, thank you

@YakBizzarro After some time thinking about it and also discussing with the core team, my conclusion is that I am going to merge this PR as is. The only thing that needs to be done is to resolve the merge conflict. After you do it, I will merge. I appreciate your patience, and effort spent in fixing comments and adding tests!

@YakBizzarro Please fix the mypy errors (see Travis output) and codacy complaints. And then I'll merge.

@YakBizzarro Well, they are not false positives :)
the get_raw/set_raw one comes from a confusion with Parameter and _BaseParameter classes - in the first, you have to redefine get/set methods, while in the second you have to redefine get_raw/set_raw; but because constructor of Parameter calls the constructor of the _BaseParameter before dealing with get/set methods, you can redefine get_raw/set_raw even though you are inheriting from Parameter. But this is not your fault, we will clean up Parameter and _BaseParameter classes in some time in the future.
And the "_multiplier is not callable" can be solved by first getting it into a local variable like multiplier_param = self._multiplier, and then calling the new variable. Extra type annotations can help with making this code understandable.
But as discussed before, this implementation has quite some other more important problems, so for the sake of time, let's not bother about these minor issues now. I am going to merge.


How to change column types?

We need to change couples of columns of a fact table from INTEGER to DECIMAL and from NONE to DICTIONARY encoding text. Currently the table has a few tens billions of records. We could not figure out usage of ALTER TABLE MODIFY COLUMN statement using omniscidb. We found no related usage description in omniscidb documentation. Any working MODIFY COLUMN example to share with us?

Hi,
You can try adding a column with the new datatype, updating with valu8es of the actual column, dropping the e old column, and renaming the new column like the original one.
I'm not sure if it's working and how it performs on such nig table.
anyway, this is an example
omnisql> alter table supplier add column S_NATIONKEY_dec decimal(8,2);
omnisql> update supplier set S_NATIONKEY_dec=S_NATIONKEY;
omnisql> alter table supplier drop column S_NATIONKEY;
omnisql> alter table supplier rename column S_NATIONKEY_dec to s_nationkey;
omnisql> select S_NATIONKEY from supplier limit 10;
S_NATIONKEY
10.00
13.00
17.00
10.00
5.00
20.00
16.00
11.00
15.00
10.00
10 rows returned.

I'm not sure if it works with shared tables.
You can use the same approach with text columns to convert encoded none to an encoded dictionary.
Regards,
Candido


Vex and Pikaday don’t play nicely

https://github.com/dbushell/Pikaday/issues
Ref:
https://twitter.com/tl8roy/status/616058707453964288

No clue if this is still an issue, but I was able to get vex 3 and Pikaday working together. See code snippet below:
vex.defaultOptions.className = 'vex-theme-wireframe'; // pick any theme
var input = document.createElement('input');
input.type = 'text';
input.value = '9 Aug 2016';
var picker = new Pikaday({
    field: input,
    format: 'D MMM YYYY',
    onSelect: function() {
        console.log(picker.toString());
    }
});
vex.open({
    unsafeContent: input
});

I don't know what the use case was a year ago. If it's still of concern, I'd be happy to help.

@tl8roy

I will have to update everything to really check. When I am working on that project again I will test this.

Assuming this is still working. Thanks all.


[NEW CONTENT TYPE REQUEST] Type Script

What type of file would you like magika to detect?
Type Script code (.ts)
What software can create/open these files?
Many IDEs, any text editor.
Where can these files be found?
https://github.com/search?q=language%3ATypeScript&type=repositories
If possible, please provide a specification for this file type.
Additional context

Closing, see #152 for context. Thanks!


Import issue encountered in the Preprocess section of SuperGradients How To Use a model to Predict.ipynb

🐛 Describe the bug
import torchvision.transforms as transforms
import torch
Prepare preprcoess transformations
We resize to [640, 640] by COCO's dataset default, which the model was pretrained on.
preprocess = transforms.Compose([
transforms.Resize([640, 640]),
transforms.PILToTensor()
])
Run preprocess on image. unsqueeze for [Batch x Channels x Width x Height] format
transformed_image = preprocess(image).float().unsqueeze(0)
print(transformed_image)
transformed_image
ImportError                               Traceback (most recent call last)
 in <cell line: 1>()
----> 1 import torchvision.transforms as transforms
2 import torch
3 #Prepare preprcoess transformations
4 #We resize to [640, 640] by COCO's dataset default, which the model was pretrained on.
5 preprocess = transforms.Compose([
5 frames
/usr/local/lib/python3.10/dist-packages/PIL/ImageFont.py in
36 from . import Image
37 from ._deprecate import deprecate
---> 38 from ._util import is_directory, is_path
39
40
ImportError: cannot import name 'is_directory' from 'PIL._util' (/usr/local/lib/python3.10/dist-packages/PIL/_util.py)

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
Versions
--2023-05-31 10:43:10--  https://raw.githubusercontent.com/pytorch/pytorch/main/torch/utils/collect_env.py
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 21676 (21K) [text/plain]
Saving to: ‘collect_env.py’
collect_env.py      100%[===================>]  21.17K  --.-KB/s    in 0s
2023-05-31 10:43:10 (107 MB/s) - ‘collect_env.py’ saved [21676/21676]
Collecting environment information...
PyTorch version: 1.13.1+cu117
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.5 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Clang version: 10.0.0-4ubuntu1
CMake version: version 3.25.2
Libc version: glibc-2.31
Python version: 3.10.11 (main, Apr  5 2023, 14:15:10) [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.15.107+-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: Tesla T4
Nvidia driver version: 525.85.12
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.7.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              2
Core(s) per socket:              1
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU @ 2.20GHz
Stepping:                        0
CPU MHz:                         2199.998
BogoMIPS:                        4399.99
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       32 KiB
L1i cache:                       32 KiB
L2 cache:                        256 KiB
L3 cache:                        55 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Vulnerable; SMT Host state unknown
Vulnerability Meltdown:          Vulnerable
Vulnerability Mmio stale data:   Vulnerable
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Vulnerable: __user pointer sanitization and usercopy barriers only; no swapgs barriers
Vulnerability Spectre v2:        Vulnerable, IBPB: disabled, STIBP: disabled, PBRSB-eIBRS: Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Vulnerable
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt arat md_clear arch_capabilities
Versions of relevant libraries:
[pip3] numpy==1.22.4
[pip3] torch==1.13.1
[pip3] torchaudio==2.0.2+cu118
[pip3] torchdata==0.6.1
[pip3] torchmetrics==0.8.0
[pip3] torchsummary==1.5.1
[pip3] torchtext==0.15.2
[pip3] torchvision==0.14.1
[pip3] triton==2.0.0
[conda] Could not collect

Duplicate of #1062 #950
See the suggested solution:
https://github.com/Deci-AI/super-gradients/issues/950#issuecomment-1539627376


pfe-navigation doesn't render slot="mobile-login" unless slot"mobile-language" exists.

Discovered in our site, pfe-navigation doesn't render slot="mobile-login" unless slot"mobile-language" exists.

Impacted component(s)
In our HTML, we have:
   Log in
This results in the Log in link not being displayed on mobile.
But if we alter it to include:
Log in     English
Then both links render. The issue is, our site does not have a mobile language link.
Steps to reproduce

Add a slot in HTML for mobile-login only.
Observe that the slot isn't used.

Expected behavior
A mobile-login link can be used by itself.
Screenshots

@castastrophe Hey! Any chance the linked PR that would resolve this issue will be merged in the near future?

@ryanissamson Hey Ryan, it's on our radar but is not a high priority at the moment.  If you would like to advocate for a bump in priority, please reach out the @kylebuch8 or @starryeyez024.  Thanks!


Add agent tags from ECS container metadata

Adds selected ECS metadata as agent tags. The metadata that I felt was useful to add was:

Container name
Docker image
ECS task ARN

Tested a custom build on our infrastructure:

Thanks for the comments, updated

i've rebased this from main and am running CI on it now. thanks so much for your contribution @francoiscampbell!

Hey @moskyb, I've rebased this, are we still interested in merging?

hey, sorry! this got caught up in the end-of-year rush. CI is passing, and i'll merge it now :)


Adapt to rmm logger changes

This PR adapts to breaking changes in rmm in https://github.com/rapidsai/rmm/pull/1722.

The test is running into https://bugzilla.redhat.com/show_bug.cgi?id=1722181. We can try messing with import order to fix according to various threads I've seen. A good reference discussion is in https://github.com/pytorch/pytorch/issues/2575.

/merge


libredirect fails to build on aarch64-darwin

With nixpkgs at 64c7e3388bbd9206e437713351e814366e0c3284 (tip of nixpkgs-21.11-darwin; though the same happens for master and nixos-21.11).
$ NIX_PATH=nixpkgs=$PWD/nixpkgs nix-build nixpkgs -A libredirect --check --argstr system aarch64-darwin
checking outputs of '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv'...
unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
libredirect.c:102:11: warning: incompatible function pointer types initializing 'int (*)(const char *, int, mode_t)' (aka 'int (*)(const char *, int, unsigned short)') with an expression of type 'int (*)(const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*open_real) (const char *, int, mode_t) = LOOKUP_REAL(open);
          ^                                        ~~~~~~~~~~~~~~~~~
libredirect.c:107:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
libredirect.c:134:11: warning: incompatible function pointer types initializing 'int (*)(int, const char *, int, mode_t)' (aka 'int (*)(int, const char *, int, unsigned short)') with an expression of type 'int (*)(int, const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*openat_real) (int, const char *, int, mode_t) = LOOKUP_REAL(openat);
          ^                                               ~~~~~~~~~~~~~~~~~~~
libredirect.c:139:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
4 warnings generated.
installing
install: creating directory '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0'
install: creating directory '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib'
'libredirect.dylib' -> '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib'
post-installation fixup
patching script interpreter paths in /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0
patching script interpreter paths in /nix/store/cbzgblyik90wag4arznwrw5sx62xfqsa-libredirect-0-hook
running install tests
dyld: could not load inserted library '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib' because no suitable image found.  Did find:
        /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib: mach-o, but wrong architecture
        /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib: stat() failed with errno=1

Assertion failed: (system(TESTPATH) == 0), function test_system, file test.c, line 37.
/nix/store/i97a6fwzdp2n2mb9crzhnvdb7r15arqi-stdenv-darwin/setup: line 1355:  3156 Abort trap: 6           NIX_REDIRECTS="/foo/bar/test=/nix/store/dwhdayp98xmpp9vzzb1qp4va1pjy65gz-coreutils-9.0/bin/true" ./test
builder for '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv' failed with exit code 134
error: build of '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv' failed

Now we could argue, alright you are building with an x86_64 nix executable, that might not work. So let's build a native nix for aarch64-darwin
NIX_PATH=nixpkgs=$PWD/nixpkgs nix-build nixpkgs -A nix --argstr system aarch64-darwin
these paths will be fetched (1.26 MiB download, 6.29 MiB unpacked):
  /nix/store/1hkdg2083q0w5y8n6j0nbr5ghpyi8ixl-boehm-gc-8.0.6
  /nix/store/1s9bhccsyicfil6am1wrmdwfg4akv9fg-nix-2.3.16
  /nix/store/fl7qafl1xwf006sir3ya4q05jkn2fkd7-nix-2.3.16-man
copying path '/nix/store/fl7qafl1xwf006sir3ya4q05jkn2fkd7-nix-2.3.16-man' from 'https://cache.nixos.org'...
copying path '/nix/store/1hkdg2083q0w5y8n6j0nbr5ghpyi8ixl-boehm-gc-8.0.6' from 'https://cache.nixos.org'...
copying path '/nix/store/1s9bhccsyicfil6am1wrmdwfg4akv9fg-nix-2.3.16' from 'https://cache.nixos.org'...
/nix/store/1s9bhccsyicfil6am1wrmdwfg4akv9fg-nix-2.3.16

This looks good:
/nix/store/1s9bhccsyicfil6am1wrmdwfg4akv9fg-nix-2.3.16/bin/nix-build: Mach-O 64-bit executable arm64

But that fails as well :-/
$ PATH=/nix/store/1s9bhccsyicfil6am1wrmdwfg4akv9fg-nix-2.3.16/bin:$PATH NIX_PATH=nixpkgs=$PWD/nixpkgs nix-build nixpkgs -A libredirect --check                                                                                ~
checking outputs of '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv'...
unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
libredirect.c:102:11: warning: incompatible function pointer types initializing 'int (*)(const char *, int, mode_t)' (aka 'int (*)(const char *, int, unsigned short)') with an expression of type 'int (*)(const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*open_real) (const char *, int, mode_t) = LOOKUP_REAL(open);
          ^                                        ~~~~~~~~~~~~~~~~~
libredirect.c:107:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
libredirect.c:134:11: warning: incompatible function pointer types initializing 'int (*)(int, const char *, int, mode_t)' (aka 'int (*)(int, const char *, int, unsigned short)') with an expression of type 'int (*)(int, const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*openat_real) (int, const char *, int, mode_t) = LOOKUP_REAL(openat);
          ^                                               ~~~~~~~~~~~~~~~~~~~
libredirect.c:139:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
4 warnings generated.
installing
install: creating directory '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0'
install: creating directory '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib'
'libredirect.dylib' -> '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib'
post-installation fixup
patching script interpreter paths in /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0
patching script interpreter paths in /nix/store/cbzgblyik90wag4arznwrw5sx62xfqsa-libredirect-0-hook
running install tests
dyld: could not load inserted library '/nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib' because no suitable image found.  Did find:
        /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib: mach-o, but wrong architecture
        /nix/store/1v371qinn0fivjc595yazzxbdb13k4ac-libredirect-0/lib/libredirect.dylib: stat() failed with errno=1

Assertion failed: (system(TESTPATH) == 0), function test_system, file test.c, line 37.
/nix/store/i97a6fwzdp2n2mb9crzhnvdb7r15arqi-stdenv-darwin/setup: line 1355:  3594 Abort trap: 6           NIX_REDIRECTS="/foo/bar/test=/nix/store/dwhdayp98xmpp9vzzb1qp4va1pjy65gz-coreutils-9.0/bin/true" ./test
builder for '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv' failed with exit code 134
error: build of '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv' failed

am I holding it wrong?

One data point I have for you - on linux at least, when using LD_PRELOAD with qemu-emulated binaries it causes weirdness because the LD_PRELOAD gets applied to the linking/execution of qemu. So the linker finds itself asked to preload an aarch64 binary to an x86 program. Normally that just prints an error message, skips the lib and continues, at which point qemu tends to pick up the LD_PRELOAD and do it itself. But for all I know on macos it's a hard failure.
On linux, the most trouble it causes is if something is reading the output of the program and it chokes on the unexpected warning/error, and I'm eyeing up the patch @ https://sourceware.org/bugzilla/show_bug.cgi?id=20172 to possibly work around that.

On linux, the most trouble it causes is if something is reading the output of the program and it chokes on the unexpected warning/error, and I'm eyeing up the patch @ https://sourceware.org/bugzilla/show_bug.cgi?id=20172 to possibly work around that.

LD_PRELOAD warnings aren't the only problem on Linux, and there's also argv[0]. I have #143060 to address both.

But this isn't qemu, this is at best rosetta2. Then again this is on a mac mini m1, (aarch64-darwin).
The really confusing part to me is that hydra somehow managed to build this somehow in CI at some point. The fact that the builder for this somehow ends up being an x86_64 bash is already strange, but I don't know where I'd have to look to fix that.  And then we'd have to deal with the arm64 vs arm64e (I gotta love apples naming scheme...), which would point to a slightly misconfigured toolchain. So are we leaking the host toolchain somehow in?
Maybe @thefloweringash has some idea? :-)

Are you running a multi-user setup? If so, then the architecture of the client doesn't matter if you don't relaunch nix-daemon with the native aarch64 version as well. But either way, this seems to be an issue.

So I've moved to a pure aarch64-darwin setup on BigSur (11.6.2 (20G314)) on a M1 mini.
The libredirect.dylib we produce has the following header:
00000000: cffa edfe 0c00 0001 0000 0000 0600 0000  ................
00000010: 1000 0000 b806 0000 8500 1000 0000 0000  ................

CPU_TYPE: 0c00 0001 => CPU_TYPE_ARM64 (12 = 0xc) | CPU_ARCH_ABI64 (0x01000000)
CPU_SUB_TYPE = 0000 0000 => CPU_SUBTYPE_ARM64_ALL

/*
 *  ARM64 subtypes
 */
#define CPU_SUBTYPE_ARM64_ALL           ((cpu_subtype_t) 0)
#define CPU_SUBTYPE_ARM64_V8            ((cpu_subtype_t) 1)
#define CPU_SUBTYPE_ARM64E              ((cpu_subtype_t) 2)

I've also tried force setting 1 and 2. Same effect:
dyld: could not load inserted library '/nix/store/19j8my6waz6agi4247jx3q23lx3wqx69-libredirect-0/lib/libredirect.dylib' because no suitable image found.  Did find:
	/nix/store/19j8my6waz6agi4247jx3q23lx3wqx69-libredirect-0/lib/libredirect.dylib: incompatible cpu-subtype: 0x00000000 in /nix/store/19j8my6waz6agi4247jx3q23lx3wqx69-libredirect-0/lib/libredirect.dylib
	/nix/store/19j8my6waz6agi4247jx3q23lx3wqx69-libredirect-0/lib/libredirect.dylib: stat() failed with errno=1

however, hydra must somehow have managed to pass the test-suite. 🤯
Otherwise I wouldn't be able to grab the same library from the cache.

On macOS Monotery, we get a slightly more descriptive error message:
dyld[4843]: terminating because inserted dylib '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' could not be loaded: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)
dyld[4843]: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)

if we then use the system clang, we get
NIX_DEBUG=7 /usr/bin/clang -Wall -std=c99 -O3 -fPIC -ldl -shared -Wl,-install_name,$out/lib/$libName -o "$libName" libredirect.c -arch arm64e

and
DYLD_INSERT_LIBRARIES="$PWD/libredirect.dylib" NIX_REDIRECTS="/foo/bar/test=/nix/store/dwhdayp98xmpp9vzzb1qp4va1pjy65gz-coreutils-9.0/bin/true" ./test

succeeds.

Potential fix is in https://github.com/NixOS/nixpkgs/pull/153441

Actually, "somewhere around" merging that PR, libredirect builds regressed on Hydra for aarch64-darwin.  Links: https://github.com/NixOS/nixpkgs/pull/154708#issuecomment-1019514934
In particular, it seems OK on master and 21.11 recently:

https://hydra.nixos.org/job/nixpkgs/nixpkgs-unstable-aarch64-darwin/libredirect.aarch64-darwin
https://hydra.nixos.org/job/nixpkgs/nixpkgs-21.11-darwin/libredirect.aarch64-darwin

(I'm just pinging people; I know too little about the platform and can't work on this.)

Now it's in master and 21.11, so I'll assume all is OK.


GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run SQL PostCommit

Run Java_Examples_Dataflow_Java11 PreCommit

Run SQL PostCommit

Run Java_Examples_Dataflow_Java11 PreCommit

Run Spotless PreCommit


feat: separate go mods for integration packages

Is your feature request related to a problem? Please describe.
We need to separate integration packages into their own go mod files because unused integrations can be imported into the go.sum files of user projects which can cause potential build failures.
Describe the solution you'd like
We need to have separate go.mod files for integration packages.
Describe alternatives you've considered
NA
Additional context
NA

@slayerjain will love to work on this ........please assign me this issue.


Fix evaluation bug due to recent update

Solves this issue.
CC: @sarapapi.
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) Yes
[x] Did you read the contributor guideline?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
This change causes an error during evaluation. Evaluation is running fine with this modification
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@mzaidi59 Thank you so much for your pull request! The same change has been updated in https://github.com/pytorch/fairseq/commit/a20dc364647c94417f493ba0b0c8d1e1834e67eb.

Thanks a lot @xutaima!


can't run show_objects_node:Required argument missing: num_beams

Thx for the code you provided. But I can't rosrun depth_clustering show_objects_node .

Now,I am solve this problem.
I use VLP16.so,
rosrun depth_clustering show_objects_node  --num_beams 16


1.5.5 Release for Homebrew

Hi,
Could you please release 1.5.5 so that we can update the app via Homebrew? Thanks!

done (it might take some time for it to reach homebrew, I'm not sure about who does that and how)


Fix kube-inject with no webhook having errors

Please provide a description of this PR:
When there is no webhook exists, kube-inject will fall back to use injector config maps. However the values parameter is not set ahead, which leads to the error Error: failed to run injection template: failed parsing generated injected YAML (check Istio sidecar injector configuration): unmarshal patched pod: json: cannot unmarshal string into Go struct field Probe.spec.containers.readinessProbe.failureThreshold of type int32.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
df73da9c07d9a8a5159b135d865129dccbcb3838
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
c1aaa13f3884f4cc0744b1bc4b10dda418d57f9c
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not stale

Can you describe the root cause and solution?  I am having trouble seeing how this code relates to the linked issue...

Can you describe the root cause and solution? I am having trouble seeing how this code relates to the linked issue...

@therealmitchconnors The root cause is: when we have the webhook injector, kube-inject will use the injector to inject the file. However if there is no webhook, kube-inject falls back to use configs from the injection configmap. In this situation, the old logic is missing the part to obtain the values config, which leads to unmarshalling errors. This PR is to get and set values config in this situation, and make kube-inject work properly.

not stale

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio
4045c21a1ace6198a8f76e45e009937d3a1efeaf
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
4045c21a1ace6198a8f76e45e009937d3a1efeaf
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
4045c21a1ace6198a8f76e45e009937d3a1efeaf
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[dashboard] Change protocol to proto3, etc.

dashboard change  protocol to proto3.
auth-proxy refactoring.
delete open api resources.

close #599


Doc question: How are void pixels handled?

I am currently reading through the patent and have a question (probably stupid and there are probably more to come :D ). I hope it is ok if I use an issue here for this.
A LERC block knows about the number of valid/non-negative pixels and then there is the bitstuffed data (which can be unpacked since we know the bits per pixel and the number of pixels). But there could be "void" pixels (~=NODATA pixels).
Looking at https://raw.githubusercontent.com/Esri/lerc/master/doc/LercEncodingSample.png there are four "void" pixels.
What happens with them when encoding? How would I know where to re-insert them in the block when unpacking if I just find 12 pixel values for the 4x4 (=16 pixels) block?

@kannes  No problem. Both during encode and decode, it uses the bit mask that tells which pixel is valid / invalid. For decode, see https://github.com/Esri/lerc/blob/master/src/LercLib/Lerc2.cpp#L1983 . Here, it would go over the 12 valid values, and assign them to the valid pixels. The void pixels are skipped. The order in which it goes over the pixels is fixed. The bit mask is encoded before the pixel values in the Lerc blob and read before the pixel values.

Thank you very much, that makes a lot of sense now :)


react-c3 break on React 15

We are trying to work on react-c3 but we are using React 15.
our developer reported that library is breaking on React.findDOMNode,
It will be great if you fix it or tell us any workaround !

The findDOMNode function has been moved to the react-dom package.
I guess we can replace React.findDOMNode by ReactDOM.findDOMNode safely.


select and copy

Hello, I am trying to use this package to select and copy text.  It selects the text just perfect, but I couldn't figure out how to copy the text. I would appreciate any help.
Thank you

You have to use https://reactnative.dev/docs/clipboard togather with this library to copy text.


E2e tests for external issuers

Fixes: https://github.com/jetstack/cert-manager/issues/3152
NONE

/test pull-cert-manager-e2e-v1-19

/retest

/retest

/retest

/kind bug

/retest

/retest

@JoshVanL Thanks for the review.
I've used the issuer conformance test suite, as you suggested.
It was easier than I expected. Good suggestion.
PTAL
/assign @JoshVanL
/unassign

@JoshVanL Thanks for the review.
I've used the issuer conformance test suite, as you suggested.
It was easier than I expected. Good suggestion.
PTAL
/assign @JoshVanL
/unassign

Looks good to me, pleased to be getting this in.
I think my comment has gone missing, but I'm keen to get the images into a cert-manager namespace, rather than your personal. Don't see a reason to block this PR though, and we have an issue for it.
/lgtm

Looks good to me, pleased to be getting this in.
I think my comment has gone missing, but I'm keen to get the images into a cert-manager namespace, rather than your personal. Don't see a reason to block this PR though, and we have an issue for it.
/lgtm


Fix loopback IP for proxy exception during initial configuration

There is a typo in the pre-configured proxy exceptions during initial config: 127.0.01 instead of <IP_ADDRESS>.  Note the missing dot.

Nice catch! Thanks!


First digit is considered as integer

The usual behavior of the lib is that every digit inputted, it compound the value from the smallest decimal case and keeps bumping the previous numbers into the bigger cases.
But the last released version seems to have a bug.
Every first digit in my input consider the first digit as the first integer digit and the following inputs follow the normal behavior of compounding the value from the smallest case and bumping the previous numbers.
I noticed it in the latest version: 3.17.4
I'm using the component with v-model.number.
Configuration:
{
  decimal: ',',
  thousands: '.',
  prefix: 'R$ ',
  suffix: '',
  precision: 2,
  masked: false,
  disableNegative: false,
  disabled: false,
  min: Number.MIN_SAFE_INTEGER,
  max: Number.MAX_SAFE_INTEGER,
  allowBlank: false,
  minimumNumberOfCharacters: 0
}

Here follows a gif of me tabbing into the component and only pressing 1.

New tests are done also with puppeteer.  This insures that we have better control of what is happening at the browser level.
This issue now has it's own tests. Thanks for reporting!
Fixed on 3.17.5


Update DeveloperGuide.md

To add in 2 use cases (Add class and Delete class)
To resolve #38

Well done! As the last PR in a series of use cases, there were a few merge conflicts which I have resolved. I have also swept through all of the use cases and corrected any missing details as required. Thanks for the work :)


Flashing screen when site is in dark mode

Hello there, I want to commend you for creating such a beautiful theme. I recently visited your website at https://shibuya.lepture.com/, and since my browser preference is set to dark mode, the dark theme was automatically applied. However, I noticed that every time I visit a new page, the site flashes from white to dark.
I'm using Firefox 110 on Linux, and I'm not sure if this issue is specific to my setup. Unfortunately, it's pretty difficult to capture in a screenshot, so I don't have anything to show you.

Oh. Thanks for your feedback. I believe I can reproduce it.

Good job @lepture, it's fixed.


Utility Palette

New collapsable utility palette..  print button, create SVG button, create PNG button.  I have no idea how to do these things but might be cool... get an image and share on Facebook.  Save and share button eventually.

http://jsxgraph.uni-bayreuth.de/wp/2012/11/02/howto-export-jsxgraph-constructions/

Print button should open a new tab and display a png... then you can right click and copy the png to the clipboard or actually print using the browser print button.

I will make this into specific issues.


Unable to build C# IoT Edge Solution

I've just installed a new Windows 10 VM, to run Azure IoT Edge 1.0.6.
As described in the doc I installed:

Docker CE previously to the IoT Edge Runtime
IoT Edge Runtime without any issue and deployed successfully containers from the marketplace
VS Code with the C# extension, to create a C# module.

When I try to Build my IoT Edge solution in VS Code, I have the following error in the integrated Terminal.
Where should I investigate to find a solution?
Thanks
Arnaud

docker build  --rm -f "c:\Users\demo\Documents\MyCSharpModules\EdgeSolution\modules\FilterModule\Dockerfile.amd64" -t afoedgemodules/filtermodule:0.0.1-amd64 "c:\Users\demo\Documents\MyCSharpModules\EdgeSolution\modules\FilterModule"
Sending build context to Docker daemon  523.3kB
Step 1/12 : FROM microsoft/dotnet:2.1-sdk AS build-env
---> 66a4ea40ad22
Step 2/12 : WORKDIR /app
---> Using cache
---> 12cb01967de8
Step 3/12 : COPY *.csproj ./
---> Using cache
---> bad5f162fdf5
Step 4/12 : RUN dotnet restore
---> Running in fe1b34d0fec1
CreateComputeSystem fe1b34d0fec10df3477d2d8813d07764141f052067431367ad4512519c154c44: The virtual machine could not be started because a required feature is not installed.
(extra info: {"SystemType":"Container","Name":"fe1b34d0fec10df3477d2d8813d07764141f052067431367ad4512519c154c44","Owner":"docker","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\ProgramData\docker\windowsfilter\fe1b34d0fec10df3477d2d8813d07764141f052067431367ad4512519c154c44","Layers":[{"ID":"70d875c3-0578-5dd6-a856-4b23a7014e54","Path":"C:\ProgramData\docker\windowsfilter\9ee5024b663daf96a66c8c50297e9400e72078c61db3f69e9c48aeef1808bc24"},{"ID":"0edcc64a-90cf-54c8-abdc-0b61e61f5b79","Path":"C:\ProgramData\docker\windowsfilter\2ec71618e43e3246b40607d6c47bea77f7ccbb61efac9609b8df1d02604ee274"},{"ID":"1c473831-fc7f-5122-a9fe-1b9b5f87c509","Path":"C:\ProgramData\docker\windowsfilter\c1da6b70e153d309e5568a67944ee80d061419cd02c632f08ea344921ce6cb00"},{"ID":"f03c9f77-efb1-5144-99db-bbdcac90dd7e","Path":"C:\ProgramData\docker\windowsfilter\79b3f27aa868dc281822e5d456b449e3414df89fb075f56350ff3c3360a6ac2f"},{"ID":"7644aea0-3b45-534a-ac38-2ac9bacf60db","Path":"C:\ProgramData\docker\windowsfilter\a42a6dae6f8bc40746f6b9f486da0b6fabd374fae7f4a9ea95f324d34f9bccc0"},{"ID":"86d2e987-f271-5c0a-b551-57d53269aabf","Path":"C:\ProgramData\docker\windowsfilter\b25e2c13e94e321f3f4f4acca9e550e9213ad60dd8a246ce7897ee4d2e910854"},{"ID":"49f6d7bf-2caf-53e5-91cc-2f9cf055c8a6","Path":"C:\ProgramData\docker\windowsfilter\f2abe12515f2dcbb95f7d19271bfee6691e3d63353e334ada1bd43af37ac717c"},{"ID":"9c55cbd9-576b-5ec6-88b7-e07ab5ac1d16","Path":"C:\ProgramData\docker\windowsfilter\ee3b9465a6f3528c3713e0fde9e1d642b383192b1afcd06ea9b15bdca1973589"},{"ID":"0842d9c3-6872-5aa7-95b9-9e02bb86bd99","Path":"C:\ProgramData\docker\windowsfilter\91590991a9e153f1e4418643edcd7775ff3dea1fabdce3ea587baadad250e72e"},{"ID":"676ee62c-42da-5875-9001-534b3d839970","Path":"C:\ProgramData\docker\windowsfilter\7e5531cdb2444d416d512fd314f2b02d362753f987f3433f21849b2e1b6d7037"}],"HostName":"fe1b34d0fec1","HvPartition":true,"EndpointList":["1E3FD05E-F17D-4A58-A88F-CD17E1C63800"],"HvRuntime":{"ImagePath":"C:\ProgramData\docker\windowsfilter\91590991a9e153f1e4418643edcd7775ff3dea1fabdce3ea587baadad250e72e\UtilityVM"},"AllowUnqualifiedDNSQuery":true})

After investigation I found that my issue was related to nested virtualization, because I was running my VM on a Standard_D2 instance on Azure. Resizing to a D3_V2 solved the issue.
Could you please update the Installation process (https://docs.microsoft.com/en-us/azure/iot-edge/quickstart) and highlight the compatible VM available in Azure.

@garolion Thanks for the feedback! We are currently investigating and will update you shortly.


false positive: aws_ebs_volume is found missing

Description
driftctl 0.9.0 reports a missing aws_ebs_volume:
Scanned states (1)
Scanned resources (51)
Found missing resources:
  aws_ebs_volume:
    - vol-000e2dffd7f09fdc0
[...]

The said volume is available tho:
$ aws ec2 describe-volumes --volume-ids vol-000e2dffd7f09fdc0

{
    "Volumes": [
        {
            "Attachments": [
                {
                    "AttachTime": "2021-05-05T06:26:01+00:00",
                    "Device": "/dev/xvdd",
                    "InstanceId": "i-0a85fc94dad0eee9a",
                    "State": "attached",
                    "VolumeId": "vol-000e2dffd7f09fdc0",
                    "DeleteOnTermination": false
                }
            ],
            "AvailabilityZone": "eu-west-3a",
            "CreateTime": "2021-05-05T06:25:39.455000+00:00",
            "Encrypted": true,
            "KmsKeyId": "arn:aws:kms:eu-west-3:943295019655:key/a53ba348-5a9a-4f86-8cd3-86698e80ac39",
            "Size": 125,
            "SnapshotId": "",
            "State": "in-use",
            "VolumeId": "vol-000e2dffd7f09fdc0",
            "Tags": [
                {
                    "Key": "Name",
                    "Value": "aws-www-1-data"
                }
            ],
            "VolumeType": "st1",
            "MultiAttachEnabled": false
        }
    ]
}

Table version for readability if needed:
---------------------------------------------------------------------------------------------------------
|                                            DescribeVolumes                                            |
+-------------------------------------------------------------------------------------------------------+
||                                               Volumes                                               ||
|+--------------------+--------------------------------------------------------------------------------+|
||  AvailabilityZone  |  eu-west-3a                                                                    ||
||  CreateTime        |  2021-05-05T06:25:39.455000+00:00                                              ||
||  Encrypted         |  True                                                                          ||
||  KmsKeyId          |  arn:aws:kms:eu-west-3:943295019655:key/a53ba348-5a9a-4f86-8cd3-86698e80ac39   ||
||  MultiAttachEnabled|  False                                                                         ||
||  Size              |  125                                                                           ||
||  SnapshotId        |                                                                                ||
||  State             |  in-use                                                                        ||
||  VolumeId          |  vol-000e2dffd7f09fdc0                                                         ||
||  VolumeType        |  st1                                                                           ||
|+--------------------+--------------------------------------------------------------------------------+|
|||                                            Attachments                                            |||
||+-------------------------------------------+-------------------------------------------------------+||
|||  AttachTime                               |  2021-05-05T06:26:01+00:00                            |||
|||  DeleteOnTermination                      |  False                                                |||
|||  Device                                   |  /dev/xvdd                                            |||
|||  InstanceId                               |  i-0a85fc94dad0eee9a                                  |||
|||  State                                    |  attached                                             |||
|||  VolumeId                                 |  vol-000e2dffd7f09fdc0                                |||
||+-------------------------------------------+-------------------------------------------------------+||
|||                                               Tags                                                |||
||+--------------------------------+------------------------------------------------------------------+||
|||  Key                           |  Name                                                            |||
|||  Value                         |  aws-www-1-data                                                  |||
||+--------------------------------+------------------------------------------------------------------+||

Environment

OS: fedora 34
driftctl version: 0.9.0 (previous versions affected too)

How to reproduce

The following HCL is used:
resource "aws_ebs_volume" "aws-www-1-data" {
  availability_zone = "eu-west-3a"
  size              = 125
  type              = "st1" # Throughput Optimized HDD
  encrypted         = true

  tags = {
    Name = "aws-www-1-data"
  }
}

Here's the representation in the state:
$ terraform state show aws_ebs_volume.aws-www-1-data
# aws_ebs_volume.aws-www-1-data:
resource "aws_ebs_volume" "aws-www-1-data" {
    arn                  = "arn:aws:ec2:eu-west-3:943295019655:volume/vol-000e2dffd7f09fdc0"
    availability_zone    = "eu-west-3a"
    encrypted            = true
    id                   = "vol-000e2dffd7f09fdc0"
    iops                 = 0
    kms_key_id           = "arn:aws:kms:eu-west-3:943295019655:key/a53ba348-5a9a-4f86-8cd3-86698e80ac39"
    multi_attach_enabled = false
    size                 = 125
    tags                 = {
        "Name" = "aws-www-1-data"
    }
    throughput           = 0
    type                 = "st1"
}

Here are the different representations in the state itself.
First the aws_ebs_volume:

    {
      "mode": "managed",
      "type": "aws_ebs_volume",
      "name": "aws-www-1-data",
      "provider": "provider[\"registry.terraform.io/hashicorp/aws\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "arn": "arn:aws:ec2:eu-west-3:943295019655:volume/vol-000e2dffd7f09fdc0",
            "availability_zone": "eu-west-3a",
            "encrypted": true,
            "id": "vol-000e2dffd7f09fdc0",
            "iops": 0,
            "kms_key_id": "arn:aws:kms:eu-west-3:943295019655:key/a53ba348-5a9a-4f86-8cd3-86698e80ac39",
            "multi_attach_enabled": false,
            "outpost_arn": "",
            "size": 125,
            "snapshot_id": "",
            "tags": {
              "Name": "aws-www-1-data"
            },
            "throughput": 0,
            "type": "st1"
          },
          "sensitive_attributes": [],
          "private": "bnVsbA=="
        }
      ]
    },

Then the instances section
      "instances": [
        {
          "schema_version": 1,
          "attributes": {
            "ami": "ami-039233e7845c61711",
            "arn": "arn:aws:ec2:eu-west-3:943295019655:instance/i-0a85fc94dad0eee9a",
            "associate_public_ip_address": true,
            "availability_zone": "eu-west-3a",
            "cpu_core_count": 2,
            "cpu_threads_per_core": 2,
            "credit_specification": [
              {
                "cpu_credits": "unlimited"
              }
            ],
            "disable_api_termination": false,
            "ebs_block_device": [
              {
                "delete_on_termination": false,
                "device_name": "/dev/xvdd",
                "encrypted": true,
                "iops": 0,
                "kms_key_id": "arn:aws:kms:eu-west-3:943295019655:key/a53ba348-5a9a-4f86-8cd3-86698e80ac39",
                "snapshot_id": "",
                "tags": {
                  "Name": "aws-www-1-data"
                },
                "throughput": 0,
                "volume_id": "vol-000e2dffd7f09fdc0",
                "volume_size": 125,
                "volume_type": "st1"
              }
            ],

Finally the aws_volume_attachment part:
      "mode": "managed",
      "type": "aws_volume_attachment",
      "name": "aws-www-1-data",
      "provider": "provider[\"registry.terraform.io/hashicorp/aws\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "device_name": "/dev/xvdd",
            "force_detach": null,
            "id": "vai-2313885580",
            "instance_id": "i-0a85fc94dad0eee9a",
            "skip_destroy": null,
            "volume_id": "vol-000e2dffd7f09fdc0"
          },
          "sensitive_attributes": [],
          "private": "bnVsbA==",
          "dependencies": [
            "aws_internet_gateway.gw",
            "aws_key_pair.admin",
            "aws_security_group.ssh",
            "aws_security_group.www",
            "aws_subnet.production-subnet-1",
            "aws_vpc.production",
            "aws_ebs_volume.aws-www-1-data",
            "aws_instance.aws-www-1"
          ]
        }
      ]
    },

Possible Solution

Additional context

Terraform 0.15.1 & AWS provider 3.37.0

can't reproduce ... because this infrastructure moved to TF 1.0.0 and provider 3.46.0
we should try to qualify this one with original requirements (don't have the time right now)

issue confirmed with 0.10
Found missing resources:
  aws_ebs_volume:
    - vol-000e2dffd7f09fdc0

issue fixed with 0.11
Found 26 resource(s)
 - 100% coverage
Congrats! Your infrastructure is fully in sync.
Scan duration: 3s

LGTM!

This issue still exists in driftctl-0.38.2 when a volume is listed in state for an instance as both the root volume and an ebs volume.
I was able to work around the issue by removing the instance from state (state rm), and then re-importing it. After re-import the volume is only listed as a root volume on the instance. So there may be some TF state cruft going on here that's causing problems for driftctl.


Fix non-cloud mode of AppScale launch.

Fixes problem when starting AppScale was not allowed because of max_machines option.

http://ocd.appscale.net:8080/job/Daily Build/6440/


Subclips in a Bin

Hi,
I was wondering if there was a way to return only the subclips within a bin and not everything on a timeline? I have a bin that has a few supclips and a seq but running mastermobs() or compositionmobs() returns everything that is on the timeline along with everything within the bin.

If it is like AAF, then subclips are CompositionMobs with compositionmob.usage == 'subclip'


Count negatives in Row and Column Sorted Matrix in Kotlin

🚀 Feature
To count the no. of negatives in a row and column sorted matrix.
Have you read the [Contributing Guidelines on Pull Requests]
Yes
(Write your answer here.)
Motivation
This problem uses the concept of StairCase Search which I added in the Kotlin directory.
Pitch
This problem uses the concept of StairCase Search which is the most common approach in Row and Column Sorted Matrix

/assign


Blank App in Teams

We are having an issue with the Teams App not displaying any content after deployment. The title bar is there with the info, help, and feedback icons. The "welcome" message is also displayed, but there is no content below that to actually use the app. I did confirm the REACT_APP_SHAREPOINT_SITE_NAME is set properly in Azure. I have also verified the issue occurs in the browser version of Teams, as well as the desktop version. I will try to get the console logs to share for further troubleshooting. I was able to get the console log exported. Is there a secure way for me to share that with you here?

@CSBenW, Thank you for reaching out to us. You can attach the log file here to help us troubleshoot the issue.

teams.microsoft.com-1694091952860.log

@CSBenW , Thank you for sharing logs with us.
Can you please check the REACT_APP_SHAREPOINT_SITE_NAME value from AppService. It should be only site name i.e. TEOCTestSite.
Once updated perform this step, to get the code updated with the new site name value in your app service. Once that is done, open the app in teams and verify if that works as expected.

I'm getting the same thing. I checked the REACT_APP_SHAREPOINT_SITE_NAME and it is set to the SharePoint Site I built for this app. I need an overview of the architecture of this system. Can it be added to any Team and it lives inside of Azure with the SharePoint Site as database? I've deployed it to a team then had it working once. I came back to rebuild it and deleted the team. I rebuilt it with the same name. Then it won't work anymore. Then I did it into a new team with a different name and it still is not launching the dashboard. Blank screen like OP above.

@bderry71 , Please open new issue and share console logs and network trace by opening the TEOC app in browser version of teams.

@CSBenW, Please confirm if you are still facing the issue so we can close this.

@CSBenW , Can you please share screenshot with us for validation.

Also request you to perform this step and share logs and network trace with us along with manifest files for troubleshooting.


fix(build): include C++14 options in default build flags

Fixes #4006. Recent versions of LLVM require some C++14 features, which may not be enabled by default. Ensure Bazel enables them for local builds as well as remote (CI) builds.
Also mention the need for C++14 in the setup instructions, to aid someone trying to debug this from an old configuration (as I did).
Question: Will the settings for build:remote include those for build, and if so should I remove the duplicate clause?

Fixes #4006. Recent versions of LLVM require some C++14 features, which may not be enabled by default. Ensure Bazel enables them for local builds as well as remote (CI) builds.
Also mention the need for C++14 in the setup instructions, to aid someone trying to debug this from an old configuration (as I did).
Question: Will the settings for build:remote include those for build, and if so should I remove the duplicate clause?

The documentation is not entirely clear on this point, so best to leave it in, I think?


unable handle some coordinates

I found that the lib is unable to return the right countries for these:
-36.9144444<PHONE_NUMBER>  // should be New Zealand
22.8716377<PHONE_NUMBER>   // should be Taiwan

Thank you for reporting, unfortunately, the geographical inforamtion is based on the geojson from https://github.com/datasets/geo-countries, and is not the most accurate, mainly in edges of countries.
If you have an idea, which is good for offline usage, please share :)

Looking at https://github.com/carmi2214/country-locator/blob/master/countries.geojson, the polygons are indeed disappointingly coarse.
My initial idea was to manually expend the query point to a small rect and then use findCountriesByPolygon, but my data is rather static, so right now I just call google maps api to get the country info and store them...

Anyway, if I will find a better data source in the future, it will be used here.
Closing.


added CU10 for 2016SP1 and CU2 for 2016SP2

codecov is being a D again!

thank you for keeping it updated 🙇


Package name is too long

Thanks for a good implementation for research community. However, I suggest you use a shorter module's name to replace 'maskrcnn_benchmark', say, 'det' or 'detectron' before more people start to use it. It seems you originally use 'torch_detectron' (inferred from .gitignore).
Another suggestion is to include .idea(Pycharm setting files) in .gitignore.

Thanks for your feedback.
We will definitely add a .idea file in .gitignore, would you be willing to send a PR?
About renaming the package, that's a good question. We will discuss it and come back to you.

Thanks for replying. I would send a PR for updating .gitignore file. Hope that you will find a better name.

Awesome @Jiayuan-Gu  I was wondering the same thing... :octocat:

Don't IDE-specific files generally belong to the global .gitignore?

@paleckar I don't know, I don't use IDEs :-)
But we've added it in the .gitignore from maskrcnn-benchmark, so it should be fine even if unnecessary?


Scroll Wheel not working for some parts of scroll area in Firefox

Current Behavior
Scroll Wheel not working for some parts of scroll area in Firefox. The scroll wheel will only work when the mouse is over certain elements in the scrollable section. Whereas in Chrome it works fine as long as the mouse is anywhere within the element with overflow.
Additional context
I'm using aurelia if that's important.
Your environment

Software
Version(s)

SimpleBar
5.1.0

Browser
Firefox

npm/Yarn
npm

OS
Win 10

Update: for some reason, setting the z-index of the main scrollable content fixes the issue.

Closing as it's probably related to specific implementation.


Connections interception

Description
Adjusted cypress tests for connections to assert intercept payloads
How Has This Been Tested?
Tested locally
Test Impact
Changed tests from cy.wait('@createConnection'); and cy.wait('@editConnection'); to be a proper cypress intercept
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm


Homebrew-and-Python seems all wrong

https://github.com/Homebrew/brew/blob/master/docs/Homebrew-and-Python.md
Doc says...

python points to the macOS system Python (with no manual PATH modification)
python2 points to Homebrew's Python 2.7.x (if installed)
python3 points to Homebrew's Python 3.x (if installed)
pip2 points to Homebrew's Python 2.7.x's pip (if installed)
pip3 points to Homebrew's Python 3.x's pip (if installed)

but...

python points to Python 3.6.4
python2 no longer exists
pip2 no longer exists

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

Fixed in https://github.com/Homebrew/brew/pull/3863.
In future: please always fill in the issue template.


Set nav button background-color to transparent

Setting the default navigation background-color to transparent improves the integration into the nav bar on Strava and changes this:

... to this ...

Note the nice grey underline under the button.

Thanks for this man ;)
Cheers,
Tom


Dramatically update thanks parsing capabilities

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
We can carry over a similar solution from the original. We should also add the same tests to verify we get the same support as before.
Additional context
Here is the regex that was applied, it was slightly hard to find, but I guess this is what was used to check if the message had the command:
https://github.com/freeCodeCamp/camper-gitter-bot/blob/529cc6e989f2f9661e3dd65d927727c6489c8249/data/rooms/RoomMessages.js#L49

So I've tried playing with the regex, but it doesn't seem to match correctly...


Dsc v3.2.0 - Rasteranalytics Server - Wrong RasterDataStoreItem UNC path (wrong machine)

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version
3.2.0
Affected Resource(s)

ArcGIS_Server

Configuration Files
{
"AllNodes": [
{
"NodeName": "myserver.mydomain.com",
"Role": [
"Server",
"RasterDataStoreItem"
],
"SslCertificates": [
{
"Path": "C:\setups\certificates\xxxx\xxxxx.pfx",
"Password": "xxxxx",
"CNameFQDN": "myserver.mydomain.com",
"Target": [
"Server"
]
}
]
},
{
"NodeName": "mywebadaptor.mydomain.com",
"Role": [
"ServerWebAdaptor"
],
"SslCertificates": [
{
"Path": "C:\setups\certificates\xxxxx\xxxxx.pfx",
"Password": "xxxx",
"CNameFQDN": "mywebadaptor.mydomain.com",
"Target": [
"WebAdaptor"
]
}
]
}
],
"ConfigData": {
"Version": "10.9",
"ServerRole": "RasterAnalytics",
"ServerContext": "imagesite",
"Credentials": {
"ServiceAccount": {
"Password": "xxxxx
"UserName": "xxxx",
"IsDomainAccount": true
}
},
"Server": {
"LicenseFilePath": "xxxx",
"Installer": {
"Path": "C:\setups\ArcGIS_10.9.0\ArcGIS_Server_Windows_109_177775.exe",
"InstallDir": "C:\ArcGIS\Server",
"InstallDirPython": "C:\Python27"
},
"ServerDirectoriesRootLocation": "\\xxxx.file.core.windows.net\serverdirectories",
"ConfigStoreLocation": "\\xxxx.file.core.windows.net\configstores",
"LocalRepositoryPath": "C:\arcgisserver\local-config-store",
"ConfigStoreCloudStorageAccount":{
"UserName": "xxxx.file.core.windows.net",
"Password": "xxxxxx",
"CloudStorageType": "AzureFiles",
"AzureFileShareName": "configstores",
"CloudNamespace": "imagesite"
},
"ServerDirectoriesCloudStorageAccount":{
"UserName": "xxxx.file.core.windows.net",
"Password": "xxxxxxx",
"CloudStorageType": "AzureFiles",
"AzureFileShareName": "serverdirectories",
"CloudNamespace": "imagesite"
},
"PrimarySiteAdmin": {
"UserName": "xxxx",
"Password": "xxxxx"
},
"ExternalLoadBalancer": "mydomain.com"
},
"DataStoreItems": {
"RasterStore": {
"FileShareLocalPath": "F:\ArcGISRasterDataStore",
"FileShareName": "ArcGISRaster"
}
},
"WebAdaptor": {
"AdminAccessEnabled": true,
"Installer": {
"Path": "C:\setups\ArcGIS_10.9.0\ArcGIS_Web_Adaptor_for_Microsoft_IIS_109_177789.exe"
}
},
"Federation": {
"PortalHostName": "mywebadaptor.mydomain.com",
"PortalPort": "443",
"PortalContext": "portal",
"PortalAdministrator": {
"UserName": "xxxx",
"Password": "xxxx"
}
}
}
}
Expected Behavior
I expect, that on the image server a local directory f:\ArcGISRasterDataStore is created and shared with the name "ArcGISRaster" and that this path is registered as folder as a raster data store item.
The first part seems to work, that a local directory is created, but the registered item shows up with wrong path. It shows the UNC path with the machine starting the DSC Configuration. In our case we started the DSC Deployment from a jumphost.

Actual Behavior
The registered Data Store Item has a wrong UNC pointing to the machine that started the DSC configuration instead of the machine, where the share has been created before.
Steps to Reproduce
Run this DSC config from another machine than the image server.
Important Factoids

Azure On-Prem Virtual Machines, Windows Server 2016 (no ArcGIS Images)
References

@scma-esrich FYI

Hello @lorenzmeyer77,
We will address this in a future release, however here is a workaround in the meantime:
https://github.com/Esri/arcgis-powershell-dsc/blob/78e488fc0aac6f8f4cdf574e1bdb50a7d39ed350/Modules/ArcGIS/Configurations-OnPrem/ArcGISRasterDataStoreItem.ps1#L67
Change to:
DataStorePath = if($ExternalFileSharePath){ $ExternalFileSharePath }else{ "\\$($Node.NodeName)\$($FileShareName)" }

Thanks,
Cameron K.

Hello @lorenzmeyer77,
This has been addressed in the latest release, v.3.3.0.
Thanks,
Cameron K.


Improve sql.operators typings

Description
Improve sql.operators typings to pass in strict mode
Checklist

This pull request is:

[ ] A documentation / typographical error fix

Good to go, no issue or tests are needed

[x] A short code fix

please include the issue number, and create an issue if none exists, which
must include a complete example of the issue.  one line code fixes without an
issue and demonstration will not be accepted.
Please include: Fixes: #<issue number> in the commit message
please include tests.   one line code fixes without tests will not be accepted.

[ ] A new feature implementation

please include the issue number, and create an issue if none exists, which must
include a complete example of how the feature would look.
Please include: Fixes: #<issue number> in the commit message
please include tests.

Have a nice day!

ClauseElement might be more general than needed for most of these operators, not including the conjunctions.


Hangs on large files

Reported in https://github.com/Cobertos/unitypackage_extractor/issues/20#issuecomment-937458915 and can confirm
It looks like the extractor is hanging on large files (on the extracting portion specifically). A 330MB package takes 660 seconds (exe) and 864 seconds (python -m) vs 8 seconds in v1.0.0.
Workaround is to use v1.0.0 if you want it fast and trust your .unitypackage

I believe this was when switching to tarsafe instead of tarfile as tarsafe does a iteration over names which caused great slowness in previous versions
Ideally tarsafe would need to be more performant... but I don't think there's any way around the iteration before extraction

I'm thinking:

Add an --unsafe flag to use tarfile instead of tarsafe
Add a print message right before extraction suggesting to use --unsafe if you trust the package to speed up the process

@catfag any thoughts maybe?

Yeah this tool is super slow

Having some output, either progress or just "working on it..." would help a lot

For me it is 58 seconds for a 2.2MB file.


Javascript code on remote page not executed in external-html plugin

First, thanks for making jspsych. It is a great help for our projects here at Mozilla.
I noticed an issue with the external-html plugin as it does not execute

Thanks for diagnosing this! A PR would be great. I bet this also solves #332.

I agree that this will most likely also solve #332. In the pull request, I made the parameter to run scripts false by default.
I think that also documentation update is required.

@onkeltom Was also running into this issue and added in your fix to the plugin - the good news is that I believe the script is being executed, but it has having issues detecting D3 methods as functions:
Uncaught TypeError: d3.select is not a function
    at <anonymous>:3:24
    at jspsych-external-html.js:84
    at XMLHttpRequest.xmlhttp.onload (jspsych-external-html.js:105)

Viewable in the repository here, where index.html calls the d3_chart.html via the external-html plugin.
Not sure if this is because it is dependent on the external D3 script, and if additional loading would have to take place. Any insight would be appreciated! (And apologies in advance if the solution is otherwise trivial, am still new to front end development.)

@coyiutoc I have identified the problem.
You need to replace your variable name on line 36 of your index.html file with another name. What is happening there is that you override the d3 properties that are loaded in the header globally with your variable.
Try changing it to something else. I can see the output here.

@onkeltom
Aha, awesome catch! Thank you so much!
Really does help to have another set of eyes.
Many thanks once again!


WFLY-5665 Infinispan enables statistics instrumentation even though statistics-enabled is false

https://issues.jboss.org/browse/WFLY-5665

:+1: Looks good.


Import clean up

Treat tests as part of the local package (for import order)
Import modules instead of objects (some slipped by since this was cleaned up previously)

lgtm. I don't know why django-related code always looks so gross to me.

(waiting for the test god to merge)

Flask > Django?

Flask > Django?

At least to me. I've never been much of a fan of Django (though I love their community!)


Merge 'develop' to create new release

It's been a while since the last release and some bugs have been fixed (mostly changes with the build system).

:white_check_mark: Build psmsi 3.2.26+gffc4c94b7f completed (commit https://github.com/heaths/psmsi/commit/ffc4c94b7f by @heaths)