Painfully slow server performance on .NET Core 1.0.0

I'm having an extremely slow server performance all of a sudden.
In order to test it wasn't anything I added to the template, I've created an empty React/Redux application from the yeoman generator and modified package.json to use the newly .NET Core 1.0.0 packages as following:
{
  "dependencies": {
    "Microsoft.NETCore.App": {
      "version": "1.0.0",
      "type": "platform"
    },
    "Microsoft.AspNetCore.Diagnostics": "1.0.0",
    "Microsoft.AspNetCore.Mvc": "1.0.0",
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-preview1-final",
      "type": "build"
    },
    "Microsoft.AspNetCore.ReactServices": "1.0.0-*",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
    "Microsoft.AspNetCore.Server.Kestrel": "1.0.0",
    "Microsoft.AspNetCore.StaticFiles": "1.0.0",
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",
    "Microsoft.Extensions.Configuration.Json": "1.0.0",
    "Microsoft.Extensions.Logging": "1.0.0",
    "Microsoft.Extensions.Logging.Console": "1.0.0",
    "Microsoft.Extensions.Logging.Debug": "1.0.0"
  },

  "tools": {
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": {
      "version": "1.0.0-preview2-final"
    }
  },
  // rest of project.json
}

Then running the project in development mode results in huge load times of assets:

info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Executing action method AspnetcoreSpa.Controllers.HomeController.Index (aspnetcore-spa) with arguments () - ModelState is Valid
info: Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Home/Index.cshtml.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action AspnetcoreSpa.Controllers.HomeController.Index (aspnetcore-spa) in 3637.6857ms
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 3642.5351ms 200 text/html; charset=utf-8
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/dist/main.js?v=6ZYWO9abDsbS5XJslj81MbyRPyrDaTQq9MpyEwgW3fQ
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/dist/vendor.js?v=BH772UWWJoCyeGM9-pZo_Fy6c6FOXG7K6vaVvPPC7cg
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/dist/vendor.css?v=WkDR4QmPsmL8e0G1mrsXi7xUVZAD5VjImuuRyjPg2KQ
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/dist/site.css?v=cSV83nJuUJ1OdTRQnj_lYGuqHtCa3BmcL8mwRweYFJI
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 2579.2843ms 200 application/javascript
info: Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware[2]
      Sending file. Request path: '/dist/vendor.js'. Physical path: 'E:\Desktop\aspnetcore-spa\wwwroot\dist\vendor.js'
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 5545.0118ms 200 application/javascript
info: Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware[2]
      Sending file. Request path: '/dist/vendor.css'. Physical path: 'E:\Desktop\aspnetcore-spa\wwwroot\dist\vendor.css'
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 7684.0947ms 200 text/css
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 10233.8428ms 200 text/css
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/dist/bootstrap.css.map
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/__webpack_hmr
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 0.4131ms 302
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/favicon.ico
info: Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware[2]
      Sending file. Request path: '/favicon.ico'. Physical path: 'E:\Desktop\aspnetcore-spa\wwwroot\favicon.ico'
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 1.8288ms 200 image/x-icon
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 2554.541ms 404

Running it with ASPNETCORE_ENVIRONMENT=Production results in normal performance:

Nevermind, it's working fast now. Might have been my computer.


Missing state saved value is restored to select filter as null and inuse

In our project, we have several tables which depend on each other.
For example, entries from TableA are used in a select filter in TableB.
We've just started using DT state saving. It works perfectly for the filters, but in case we have a saved filter value in TableB, then we remove this entry from TableA and move back to TableB, the filter tries to preselect this stored value in the dropdown, but it's selected as null and also set as inuse.
Expected behaviour: In case the option to be preselected does not exist in the select dropdown, do not try to preselect it.

simple jsfiddle test page will speed up the fix for this issue

Hey, here's a jsfiddle, where you can simulate the behaviour:
http://jsfiddle.net/you54cr1/16/
Just uncomnent the line 13, which will simulate a non existing select option being stored in datatables state.
I also made a PR with a proposed solution. #494
Here's a fiddle whith the fix: http://jsfiddle.net/fxvjueqL/3/


Irasone

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for Nichebiche @ 2024-08-27 19:24:59 UTC
User must have write permissions to review

Review Error for Nichebiche @ 2024-08-27 19:24:59 UTC
User must have write permissions to review

Can I please have permissions?

Review Error for Nichebiche @ 2024-08-28 03:16:44 UTC
User must have write permissions to review

Review Error for Nichebiche @ 2024-08-28 10:27:56 UTC
User must have write permissions to review

Review Error for Nichebiche @ 2024-08-28 10:28:31 UTC
User must have write permissions to review

Review Error for Nichebiche @ 2024-09-11 22:34:01 UTC
User must have write permissions to review


NOREF - Faktory Docs

NOREF
Changes and Description

Update Faktory docs.

How to test this change
View README
PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Can you speak to why you alphabetized the .spelling doc? It doesn't really hurt anything to alphabetize, except that we lose some context for git line history (which is not really important for this file). I'm not sure alphabetizing buys us anything either functionally, (I'm a bit hesitant about these sorts of changes without getting team consensus first.)

@StevenWadeOddball Just cleaner to alphabetize a long list of words imo. nbd, I'll just revert it.


ScopedBuilder-based JSON reader

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

Due to the tla-io package being a dependency for tla-types, these classes must temporarily be placed in tla-types (or higher). Once package refactoring is addressed, these classes should replace the ones in io.json, which currently use the old builder.
Additionally, the deserialization tests should use generators, but we currently lack ways to generate type-correct TLAIR, which would mean that deserializing serialized auto-generated expressions would throw, more often than not.
closes #2201

Codecov Report

Merging #2207 (4706b1b) into main (4f82ca5) will decrease coverage by 1.36%.
The diff coverage is 43.58%.

:exclamation: Current head 4706b1b differs from pull request most recent head f60d8f4. Consider uploading reports for the commit f60d8f4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   80.62%   79.26%   -1.37%
==========================================
  Files         426      428       +2
  Lines       13929    14475     +546
  Branches     1854     1993     +139
==========================================
+ Hits        11230    11473     +243
- Misses       2699     3002     +303

Impacted Files
Coverage Δ

...apalache/tla/typecomp/json/BuilderCallByName.scala
30.62% <30.62%> (ø)

...alache/tla/typecomp/json/JsonToTlaViaBuilder.scala
73.61% <73.61%> (ø)

.../forsyte/apalache/tla/typecomp/ScopedBuilder.scala
82.89% <100.00%> (+0.22%)
:arrow_up:

...a/at/forsyte/apalache/tla/lir/TlaLevelFinder.scala
93.75% <0.00%> (-2.09%)
:arrow_down:

...la/typecomp/subbuilder/LiteralAndNameBuilder.scala
100.00% <0.00%> (+13.63%)
:arrow_up:

.../typecomp/unsafe/UnsafeLiteralAndNameBuilder.scala
100.00% <0.00%> (+16.66%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Azure refactor update

Azure refactor update

Please create a separate PR for only the Vpc section.

Raised separate PR for VPC section : https://github.com/IBM/ibm-spectrum-scale-cloud-install/pull/468

created separate PR , Hence closing
https://github.com/IBM/ibm-spectrum-scale-cloud-install/pull/452


New version: TuringGLM v2.12.1

Registering package: TuringGLM
Repository: https://github.com/TuringLang/TuringGLM.jl
Created by: @rikhuijzer
Version: v2.12.1
Commit: f11ac85daf755f453abe5be774e6cffb04172010
Reviewed by: @rikhuijzer
Reference: https://github.com/TuringLang/TuringGLM.jl/commit/f11ac85daf755f453abe5be774e6cffb04172010#commitcomment-149770348
Description: Bayesian Generalized Linear models using @formula syntax.
Release notes:

Updated dependencies and fixed a bug for the Bernoulli mixed model.

Can be closed in favor of https://github.com/JuliaRegistries/General/pull/120427


Expose Force Field Aromaticity Model

Is your feature request related to a problem? Please describe.
The aromaticity model used by a force field can currently only be set and not accessed.
Describe the solution you'd like
Add a getter for a force fields aromaticity model.
Describe alternatives you've considered
Assume MDL, but this is not particularly future proof.

Closed by #665


Create a notebook based GUI for region selection

Description
A notebook GUI where users can display polygons from a WFS layer, click on a region and get the associated polygon.

I was thinking we could benefit from creating a small utilities libraries for selecting entities, regions and general georeferenced user interaction inside a jupyter notebook. Something that could be reusable...
It's more of a medium term planning that would need more discussion, but I think we seem to be heading towards that. For simple inputs we can still get around with one-off helper functions.

Sounds good. I suggest we embed those capabilities within an existing project to benefit, e.g. owslib.
@tomLandry Worth discussing with Tom K ?

I think what I'm thinking about is a bit out of the scope of owslib, because owslib focuses on implementing ows standards (I could be wrong?) Kind of the same way that birdy is a 'more convenient' library over owslib for WPS processes.
I agree it would be nice to benefit an existing library, but I'm not sure which one...

No, you're probably right. Let's keep looking.

I can recall coming across a python library maybe a year that had controlled terms for specific regions. I'll try looking through my old bookmarks to see if I can find it. Might be something that satisfies our needs that we can leverage for multiple projects. I'll update what I find here.

Found it: https://regionmask.readthedocs.io/en/stable/
There are a few pre-defined regions within the package (countries, SREX regions). This would be an interesting library to build upon to add a few more regions (Quebec, QC-CLIMEX, CORDEX, etc.). Again, this is probably a medium priority issue.

@Zeitsperre Status ? I've got a meeting with Canarie next week and having this would be nice.

Haven't had time to work on this. Seeing that this is a priority, I'll put some hours into this today.

@huard Looking over the comments here, I can see that there's a lot of overlap with the needs of other services (finch in particular). I can also see where @davidcaron is coming from with the need for "a better owslib".
As it stands, the way that RAVEN collects WFS layers is via some hard coded owslib functions in gis.py. This is due to the fact that we haven't figured ou a reliable and easy way to interface with our GeoServer instance. If we wanted to pull this out and into its own generic process, that would be fine for now, I imagine.
The approach I'm going to try is to see if I can use IpyLeaflet to pull data from the WFS and see if there's a way to extract coordinates from a mouse-click on a map object to setup a WFS hydrobasins-select process. I don't imagine it will be pretty but if you have any advice, feel free to pass it my way.

I suppose one option would be to have a WFSLayer class in ipyleaflet. This is probably not trivial and may require some js coding. Step one would to be open an issue in ipyleaflet about this.
As a first pass, can you reuse those raven gis functions inside a notebook and just display them inside the leaflet canvas ?
Another option would be to download the layer as geojson and use something like this: https://ipyleaflet.readthedocs.io/en/latest/api_reference/geo_json.html#methods

@huard the basics are shown here. I'm still running into the issue with how old the RAVEN instance is on our PAVICS but both the API calls are in the notebook. I'm going to look into what functions can be turned into user-facing processes. I'll save my work to the #175 branch.

I suggest to focus on the notebook for this branch and get it merged rapidly. Please open another issue for further backend work.

Okay. All I've done is add some type hinting to utils.py. I'll refrain on further backend work in that branch.


no-unexpected-multiline rule clashes with Prettier

I am using TypeScript, Prettier (1.17.0) and styled-components in a CRA app. When I define the prop types of my styled components inline, I end up with constructs like these:
const Component = styled.div<{
  prop1?: Type;
  prop2?: Type;
}>`
  /* Some styles here... */
`;

The above is the formatting chosen by Prettier. However, CRA's ESLint config doesn't seem to agree:
Line 1:  Unexpected newline between template tag and template literal  no-unexpected-multiline [no-unexpected-multiline]

This means that when I use the pattern above, it is impossible for me to use ESLint and create-react-app together without getting linter errors. It would be cool if the no-unexpected-multiline rule could be either disabled or configured to not trigger in the cases that Prettier creates.

this is crazy annoying, one kind of a workaround I found so far is replacing this
export const Checkbox = styled.input<
  React.HTMLAttributes<HTMLInputElement> & SpaceProps
>``

with this
type Props = React.HTMLAttributes<HTMLInputElement> & SpaceProps;
export const Checkbox = styled.input<Props>``

just ran into this issue. had to downgrade below 3.0.0 in order for the linter warning to go away.

I added this to my package.json
"eslintConfig": {
    "extends": "react-app",
    "overrides": [
      {
        "files": [
          "**/*.ts?(x)"
        ],
        "rules": {
          "no-unexpected-multiline": 0
        }
      }
    ]
  },


Add option for specifying the public API root cert

Add a --public-api-root-cert option to all commands that talk to the
Bracket service.  This option is used for specifying the path to the
self-signed root cert when brkt-cli talks to a Customer Managed MCP.
Also add a config environment key for this option.
Add crypto.validate_cert_path() for validating a cert that's stored on
disk.  Call this function when validating the --public-api-root-cert and
--ca-cert values.

Yep, already there.  😄

Must have missed it!

Belated LGTM (FWIW)


Mobile Design

The website was design for use on Desktop only. I believe we can do better. Mobile-web use would make it much more open
Mobile app is not considered for now

Businesses will use the mobile app in Flutter
Clients will use a website in React
2.1 Seeing schedules and logs by their Id and that's it


Could you help tag a new version?

Dear @peterbourgon
Latest version 3.0.0 was tagged on Apr 25, 2019, there're few fixes after that, doesn't it deserve a new release? :)

Tagged v3.0.1.

Thanks. :)


How to change mouse hover tooltip pop-up delay time?

When I hover over unfamiliar icons in the editor, it takes 3-5 seconds for its name or description to appear... I'd like to change this to 1 or 2 seconds, but I'm seeing no option for this anywhere.
I found this - "editor.hover.delay": 300 - but it doesn't specify what numerical unit 300 is so I'm assuming it means milliseconds which means that doesn't appear to be the correct settings. There's no 'tooltip' in settings and 'delay' doesn't seem to show relevant settings.
I'm on a Mac.

@skyvondave you use the correct setting. The delay describes how long VS Code waits until it requests the hover. If it is as slow as you see it, its an issue with the language extension you use. See the gif for a demonstration on our own TypeScript code base.

@skyvondave I missed the "unfamiliar icons" part. There is no setting that you can use to control that delay.


LoadingScene: access to task progress and game state vars

[x] allow loading scene to be triggered from user code, e.g. getGameController().startLoadingScene(Runnable), the runnable is then to be executed in a bg thread while loading scene is displayed
[ ] we can't access game state vars in loading scene since game scene is not yet ready
[x] access to bg task progress so subclasses of LoadingScene can also update UI as needed

Number 2 is not essential, so this is marked as completed


Fixing phpdoc for Resource::call method return type

Found that issue by the way of using Google_Service_Drive->files->export.
Files::export calling Resource::call and returning its output. In normal circumstances it returns psr ResponseInterface, just in some cases (when request is defered) it returns RequestInterface.
Current @return in Resource::call method has 2 issues:

Its solid class Response instead of ResponseInterface
Its cheating IDE which dont know that File::export could return ResponseInterface which end up with code as following. Of course its triggers ERROR: TypeError: Return value of Foxstone\BackendPHP\service\GoogleDriveService::exportFileContents() must be an instance of GuzzleHttp\Psr7\Request, instance of GuzzleHttp\Psr7\Response returned

Example of generated code (type returns by exportFileContents method was inherited from types returns from File::export (and then from Resource::call) which is wrong):
    /**
     * @throws Exception
     */
    public function exportFileContents(
        string $fileId,
        string $exportMimetype
    ): ResponseInterface {
        $this->connect();

        return self::$GoogleServiceDrive->files->export(
            $fileId,
            $exportMimetype,
            ['alt' => 'media']
        );
    }

@googlebot I signed it!

@amackiewicz This looks great, although I'm not sure when it would return array for these functions. Can you elaborate?

Hey @bshaffer ! well, me too :) but problem was with REST::execute returning type in phpdoc (https://github.com/googleapis/google-api-php-client/blob/master/src/Http/REST.php#L44).
I've changed phpdoc also for that method, check it out plz

any updates here @bshaffer  ? :)


raymarching composite_rays build error

Description
i pulled the latest stuff from git and wanted to rebuild, but i failed with raymarching composite_rays error.
After struggling a while, i deleted the "const" from line 925 of raymarching.cu file ( https://github.com/ashawkey/stable-dreamfusion/blob/main/raymarching/src/raymarching.cu ). So that the signature matches the declaration in https://github.com/ashawkey/stable-dreamfusion/blob/main/raymarching/src/raymarching.h
After that it builds raymarching and i can run stable-dreamfusion
Steps to Reproduce
deleted the "const" from line 925 of raymarching.cu file ( https://github.com/ashawkey/stable-dreamfusion/blob/main/raymarching/src/raymarching.cu ) . So that the signature matches the declaration in https://github.com/ashawkey/stable-dreamfusion/blob/main/raymarching/src/raymarching.h
Expected Behavior
it builds
Environment
windows 11, anaconda 3, cuda-11.8

@flobotics Thanks for reporting the bug!

So，I wanna know if cuda is not supported, will the project still work?Thank you very much


Write documentation for rolling builds of the ontology

https://wiki.geneontology.org/Daily_version_of_the_Gene_Ontology

@kltm Can you please have a look and let me know if this is what you were looking for?
It seems short, but I'm not sure what else to add.

Okay, I think it might be good to touch bases on this again, as I think both the words "daily" and "version" are misleading at best. It's important here to pass on the right understanding of what this is to prevent confusion, both internally and externally. Shouldn't this be with the rest of the pipeline/snapshot/release info? For my take on it, I have something here: https://github.com/geneontology/pipeline?tab=readme-ov-file#functional-branches

this has been addressed


Commit message box rendered weirdly when SCM view is unhidden

Commit message rendered weirdly

Repro:
I don't have exact steps, so

Open SCM view
Try hiding the sidebar, switching to explorer view, then switch back to SCM view

Version
Version: 1.85.0-insider
Commit: a9d8fbca9ec9a7914f2077a83ca66a08c7e10f83
Date: 2023-11-02T09:12:38.373Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.0.0

I believe that this should be fixed.
Closing it optimistically but please feel free to reopen in case you are able to reproduce.


[#174878683] Placeholder for empty resolution list

https://www.pivotaltracker.com/story/show/174878683

I think we can add link with creating resolution to word one instead of button New resolution

I think we can add link with creating resolution to word one instead of button New resolution

@Vadim-Kurnatovskiy I've updated the view


MySQL installer does not install packages

Brief description of your issue

While installing MySQL via winget, only the installer is installed, and not the packages that are supposed to accompany the installer
Steps to reproduce

Run winget install Oracle.MySQL
Navigate to the folder where the installer has been installed and run MySQLInstaller.exe

Expected behavior

The installer should install normally, with the various packages installing as usual

Actual behavior

The installer can not find the required packages for installation

Environment
[winget --info]
Windows: Windows.Desktop v10.0.22000.100
Package: Microsoft.DesktopAppInstaller v1.15.11694.0
MySQL version: 8.0.25

Apologies, I realised that Winget Packages would be a better place.

Duplicate of #https://github.com/microsoft/winget-pkgs/issues/22462


make Elem private to the RISCV executor

Bootloader/continuations now handle field elements directly instead of Elem.
The bootloader can't use u32 directly because it uses register memory from the previous chunk, which may be holding values larger than 32-bit depending where the execution stops (i.e., negative Elem::Binaries or Elem::Field).

the idea here is to hide executor implementation details from the outside, in preparation for the BB executor


GH-1065: Reject fatal with MANUAL ack mode

Fixes https://github.com/spring-projects/spring-amqp/issues/1065
Previously, messages with fatal errors (e.g. conversion) would be
left in an un-acked state.
They are now rejected and NOT requeued by default.
cherry-pick to 2.1.x

... and cherry-picked as https://github.com/spring-projects/spring-amqp/commit/2d4c3c0373e9f94a9668cd8092da5e85753a29f5 after fixing conflicts.


How do I static link mongc library under linux

I was using MongoDB and trying to static link it with no success.
here what I do:
    find_package(libmongocxx REQUIRED)
    find_package(libbsoncxx REQUIRED)
    find_package(mongo-c-driver CONFIG REQUIRED)
    # if(MSVC)
    #     find_package (libmongoc-1.0 REQUIRED)
    # else()
    #     find_package (libmongoc-static-1.0 REQUIRED)
    # endif()

    message("--   mongoc found version \"${MONGOC_VERSION}\"")
    message("--   mongoc include path \"${MONGO_INCLUDE_DIRS}\"")
    message("--   mongoc libraries \"${MONGO_LIBRARIES}\"")
    message("--   mongoc found version \"${MONGOC_STATIC_VERSION}\"")
    message("--   mongoc include path \"${MONGOC_STATIC_INCLUDE_DIRS}\"")
    message("--   mongoc libraries \"${MONGOC_STATIC_LIBRARIES}\"")

    message("--  LIBMONGOCXX_INCLUDE_DIRS = ${LIBMONGOCXX_INCLUDE_DIRS}")
    message("--  LIBMONGOCXX_LIBRARIES = ${LIBMONGOCXX_LIBRARIES}")
    message("--  LIBBSONCXX_INCLUDE_DIRS = ${LIBBSONCXX_INCLUDE_DIRS}")
    message("--  MONGOC_STATIC_LIBRARY = ${MONGOC_STATIC_LIBRARY}")
    message("--  MONGOC_STATIC_LIBRARIES = ${MONGOC_STATIC_LIBRARIES}")
    message("--  MONGOC_LIBRARIES = ${MONGOC_LIBRARIES}")
    message("--  MONGOC_STATIC_DEFINITIONS = ${MONGOC_STATIC_DEFINITIONS}")

    add_executable(mongo-bench-dev src/app/db-tools.cpp)
    target_include_directories(mongo-bench-dev PRIVATE
        ${Boost_INCLUDE_DIRS}
        ${MONGOC_INCLUDE_DIRS}
        ${LIBMONGOCXX_INCLUDE_DIRS}
        ${LIBBSONCXX_INCLUDE_DIRS})
    target_link_libraries(mongo-bench-dev PRIVATE
        options
        ${Boost_LIBRARIES}
        ${LIBMONGOCXX_LIBRARIES}
        ${LIBBSONCXX_LIBRARIES}
        ${MONGOC_STATIC_LIBRARIES}
        -ldl fmt::fmt fmt::fmt-header-only)

this works but it links dynamically. when I try to statically link it with by adding -static
    target_link_libraries(mongo-bench-dev PRIVATE
        options
        ${Boost_LIBRARIES}
        ${LIBMONGOCXX_LIBRARIES}
        ${LIBBSONCXX_LIBRARIES}
        ${MONGOC_STATIC_LIBRARIES}
        # /home/ttan/repo/public/vcpkg/installed/x64-linux/lib/libmongoc-1.0.a
        -ldl fmt::fmt fmt::fmt-header-only -static)

it failed with

/usr/bin/ld: attempted static link of dynamic object `/home/ttan/repo/public/vcpkg/installed/x64-linux/lib/libmongoc-1.0.so'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

here's what I observe from the variables
--   mongoc found version ""
--   mongoc include path ""
--   mongoc libraries ""
--   mongoc found version "1.15.1"
--   mongoc include path "/home/repo/public/vcpkg/installed/x64-linux/include;/home/repo/public/vcpkg/installed/x64-linux/include"
--   mongoc libraries "/home/repo/public/vcpkg/installed/x64-linux/lib/libmongoc-1.0.so;/home/repo/public/vcpkg/installed/x64-linux/lib/libbson-1.0.so;/usr/lib/x86_64-linux-gnu/librt.so;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libssl.a;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libcrypto.a;rt;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libz.a;resolv"
--  LIBMONGOCXX_INCLUDE_DIRS = /home/repo/public/vcpkg/installed/x64-linux/include;/home/repo/public/vcpkg/installed/x64-linux/include
--  LIBMONGOCXX_LIBRARIES = optimized;/home/repo/public/vcpkg/installed/x64-linux/lib/libmongocxx-static.a;debug;/home/repo/public/vcpkg/installed/x64-linux/debug/lib/libmongocxx-static.a;optimized;/home/repo/public/vcpkg/installed/x64-linux/lib/libbsoncxx-static.a;debug;/home/repo/public/vcpkg/installed/x64-linux/debug/lib/libbsoncxx-static.a
--  LIBBSONCXX_INCLUDE_DIRS = /home/repo/public/vcpkg/installed/x64-linux/include
--  MONGOC_STATIC_LIBRARY = /home/repo/public/vcpkg/installed/x64-linux/lib/libmongoc-1.0.so
--  MONGOC_STATIC_LIBRARIES = /home/repo/public/vcpkg/installed/x64-linux/lib/libmongoc-1.0.so;/home/repo/public/vcpkg/installed/x64-linux/lib/libbson-1.0.so;/usr/lib/x86_64-linux-gnu/librt.so;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libssl.a;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libcrypto.a;rt;/home/repo/public/vcpkg/installed/x64-linux$<$<CONFIG:DEBUG>:/debug>/lib/libz.a;resolv
--  MONGOC_LIBRARIES =
--  MONGOC_STATIC_DEFINITIONS = MONGOC_STATIC;BSON_STATIC

two thing I found not right:

MONGOC_STATIC_LIBRARIES and MONGOC_STATIC_LIBRARY pointing to *.so, not *.a
running `vcpkg install mongo-c-driver' says

``For use dynamic library:
	target_link_libraries(${project} PRIVATE ${MONGOC_LIBRARIES})
For use static library:
	target_link_libraries(${project} PRIVATE ${MONGOC_STATIC_LIBRARY})
`
however `MONGOC_STATIC_LIBRARY` does not really work.

what should I do to force static link of mongo C&C++ driver under Linux?

This issue will be fixed in #10010.

Looks that fix for #10010 was for Windows,   This issue is about Linux.

@rockonedege The PR fixes the issueof generating dynamic library under static configuration.

Fixed.


cmake macro add_backward erroneously expanded

In BackwardConfig.cmake, macro add_backward does not necessarily get correctly expanded:
indeed it uses variable _BACKWARD_INCLUDE_DIRS (instead of BACKWARD_INCLUDE_DIRS), so when this macro is called elsewhere in another cmake scope, _BACKWARD_INCLUDE_DIRS is empty while BACKWARD_INCLUDE_DIRS is ok.
The simple fix is just to replace _BACKWARD_INCLUDE_DIRS by BACKWARD_INCLUDE_DIRS

Hi,
in commit c660fb9 (merge request #107) macro add_backward was erroneously modified:
an application CMakeLists.txt be able to call this macro in a different scope, so the variables used inside this macro should only variables exported to cmake cache: BACKWARD_INCLUDE_DIRS, BACKWARD_LIBRARIES and not the variables with a leading underscore which are "local" to BackwardConfig.cmake.
Besides, about linking, if BackwardConfig.cmake made its jobs, that is to populate BACKWARD_LIBRARIES variable, I think variable BACKWARD_HAS_EXTERNAL_LIBRARIES is not needed inside macro add_backward.
If you think it is needed it must be put in cmake cache to be used inside the macro.

Thank you, I am really lost with anything touching cmake. I wish we had https://github.com/rust-lang/cargo for C++ !


Verify CA is false in CSR extension

Please provide a description of this PR:
When istiod is configured as the RA, verify the CA field in the BasicConstraint extension of the CSR is set to false. Otherwise, reject CSR.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[x] Security

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
01906de90088e08c510c1be881456d369675aafb
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
01906de90088e08c510c1be881456d369675aafb
link
true
/test unit-tests-arm64

lint_istio
01906de90088e08c510c1be881456d369675aafb
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
01906de90088e08c510c1be881456d369675aafb
link
true
/test lint

unit-tests-arm64_istio
95375f6bdc57706cef25e1879a81d4d364fca565
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
95375f6bdc57706cef25e1879a81d4d364fca565
link
true
/test unit-tests-arm64

unit-tests_istio
95375f6bdc57706cef25e1879a81d4d364fca565
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
95375f6bdc57706cef25e1879a81d4d364fca565
link
true
/test unit-tests-arm64

unit-tests_istio
95375f6bdc57706cef25e1879a81d4d364fca565
link
true
/test unit-tests

lint_istio
5697e677c6b417e045ad689a504433a682a25d99
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Maybe I missed it - where do we check the Subject?

I never claimed this PR verifies the subject? To clarify, by "subject" are you referring to the DN, CN, O, etc?

My suggestion is to check the agent and ztunnel generation code, make sure they do the same thing - and generate a CSR here with the same code. Then compare the one we generate to the one we received.

[ ] Could you please clarify if you are referring to the Istio CSR? Are you suggesting that we generate an Istio CSR on both the client and the server (once the request is received but the server?) and then compare the generated fields? This PR was scoped to verify the extensions in the workflow for Istio configured with an external CA. Rather than specifically checking for the CA field we could reject all istio CSRs with unknown fields.

The DER is deterministic - we could reuse the same code as agent, really just need to verify ztunnel has same fields. If ztunnel is already divergent - we can check for it too.

I'll need to check that we have access to all of the information we need to recreate the CSR on the server without examining the CSR from the client.

This is safest and strictest check - we only approve the CSRs with fields we know we generate, nothing else.

On Fri, Jul 5, 2024, 20:47 Jackie Elliott @.***> wrote:

Maybe I missed it - where do we check the Subject?
I never claimed this PR verifies the subject? To clarify, by "subject" are
you referring to the DN, CN, O, etc?

Yes, we shouldn't approve CSRs with arbitrary subject that we can't verify.
My suggestion is to check the agent and ztunnel generation code, make sure

they do the same thing - and generate a CSR here with the same code. Then
compare the one we generate to the one we received.
Could you please clarify if you are referring to the Istio CSR? Are you
suggesting that we generate an Istio CSR on both the client and the server
(once the request is received but the server?) and then compare the
generated fields? This PR was scoped to verify the extensions in the
workflow for Istio configured with an external CA. Rather than specifically
checking for the CA field we could reject all istio CSRs with unknown
fields.

Yes. We can't compare the full CSR - can't sign - but the idea is to make
sure the CSR template is not including any fields we can't verify and the
agent wouldn't generate.
Having a negative check - this PR verify isCA is not set, another PR to
verify the CN - is not very safe, who knows what extensions or fields get
added to a CSR that have some use - and we blindly approve.
What we really want is to only approve the minimum that agent generates -
and keep parity with the Istio-CA, where we only extract the public key and
SAN and create our clean tempate ( not using anything else in the client
CSR). We can't do this - since we don't have the private key and the real
CA will need the signature, but we can serialize what we expect and
compare.
The DER is deterministic - we could reuse the same code as agent, really

just need to verify ztunnel has same fields. If ztunnel is already
divergent - we can check for it too.
I'll need to check that we have access to all of the information we need
to recreate the CSR on the server without examining the CSR from the client.
This is safest and strictest check - we only approve the CSRs with fields
we know we generate, nothing else.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51920#issuecomment-2211619675, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2SIVM2TAQPHKMBUNE3ZK5SGJAVCNFSM6AAAAABKNYNRQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGYYTSNRXGU
.
You are receiving this because your review was requested.Message ID:
@.***>

If an org needs CRL - they most likely should add them as part of the
signer, not have each pod get some CRL somehow ( injection?), pass it in
CSR, have it approved without any check if the CRL is good or not - and
signed.
On Mon, Jul 8, 2024, 15:10 Keith Mattix II @.***> wrote:

@.**** commented on this pull request.
In security/pkg/pki/ra/common.go
https://github.com/istio/istio/pull/51920#discussion_r1669388002:

@@ -89,6 +99,69 @@ func ValidateCSR(csrPEM []byte, subjectIDs []string) bool {
return true
}

+// basicConstraints is a structure that represents the ASN.1 encoding of the
+// BasicConstraints extension.
+// The structure is borrowed from
+// https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L975
+type basicConstraints struct {

IsCA       bool asn1:"optional"
MaxPathLen int  asn1:"optional,default:-1"
+}

+func checkIsCAExtension(exts []pkix.Extension) (bool, error) {
and for the purpose of Istio we don't need the RA path to have a very
different behavior than the normal CA path.
Correct me if I'm wrong (I don't spend most of my time with certs), but
isn't the whole purpose of having a separate CA vs. RA so that you can have
the entity that authenticates the request be different from the entity that
actually mints the certificate? If an organization has a requirement that
all of their certs have a certain extension set, why should istiod (acting
as an RA) care?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51920#discussion_r1669388002, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2QUHOS6ENO4BZJUGATZLME7BAVCNFSM6AAAAABKNYNRQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRUGUZDINJRGA
.
You are receiving this because your review was requested.Message ID:
@.***>

Istiod acting as RA shouldn't care - Istiod acting as an approver does
care, it's the job of approver to make sure the request is correct.
Users can run other approvers as well enforcing other policies - and
verifying.
On Mon, Jul 8, 2024, 15:32 Costin Manolache @.***> wrote:

If an org needs CRL - they most likely should add them as part of the
signer, not have each pod get some CRL somehow ( injection?), pass it in
CSR, have it approved without any check if the CRL is good or not - and
signed.
On Mon, Jul 8, 2024, 15:10 Keith Mattix II @.***>
wrote:

@.**** commented on this pull request.
In security/pkg/pki/ra/common.go
https://github.com/istio/istio/pull/51920#discussion_r1669388002:

@@ -89,6 +99,69 @@ func ValidateCSR(csrPEM []byte, subjectIDs []string) bool {
return true
}

+// basicConstraints is a structure that represents the ASN.1 encoding of the
+// BasicConstraints extension.
+// The structure is borrowed from
+// https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L975
+type basicConstraints struct {

IsCA       bool asn1:"optional"
MaxPathLen int  asn1:"optional,default:-1"
+}

+func checkIsCAExtension(exts []pkix.Extension) (bool, error) {
and for the purpose of Istio we don't need the RA path to have a very
different behavior than the normal CA path.
Correct me if I'm wrong (I don't spend most of my time with certs), but
isn't the whole purpose of having a separate CA vs. RA so that you can have
the entity that authenticates the request be different from the entity that
actually mints the certificate? If an organization has a requirement that
all of their certs have a certain extension set, why should istiod (acting
as an RA) care?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51920#discussion_r1669388002, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2QUHOS6ENO4BZJUGATZLME7BAVCNFSM6AAAAABKNYNRQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRUGUZDINJRGA
.
You are receiving this because your review was requested.Message ID:
@.***>

The basic problem is that K8S signing is not designed for delegated RA  -
the expectation is that the originator of the
request is a component ( pod, user, kubelet ), the identity of the
originator as verified by K8S is included in the request -
and an approver (RA) decide based on the originator, CSR and policies - and
finally the signer signs (and may do additional
checks !).
With Istio - we are both originator and approver, and the information about
originator is lost. It is also quite inefficient -
we create a CSR that we approve with some watchers in the middle. But the
main problem is that the
signer can no longer apply any policy since it doesn't know who the
originator is ( unless it's parsing the SAN and parsing
Istio spiffee perhaps) - they only see Istiod. If the CSR is for a CA -
that's quite reasonable to sign since Istiod may use the
CA and is entitled to ask for one.
Since we use K8S signing this way - as an requester and approver at the
same time -  we must make all the checks that are
no longer possible on the signer.
It would be very clean if Istiod created the private key and CSR - and
returned the private key along with the chain, as it
does for SDS. That would also allow Istiod to handle ztunnel impersonation
more cleanly and add the info it needs ( the
proposed extensions to include the k8s node and pod info for example)
On Tue, Jul 9, 2024 at 11:57 AM Ben Leggett @.***>
wrote:

@.**** commented on this pull request.
In security/pkg/pki/ra/common.go
https://github.com/istio/istio/pull/51920#discussion_r1671017242:

@@ -89,6 +99,69 @@ func ValidateCSR(csrPEM []byte, subjectIDs []string) bool {
return true
}

+// basicConstraints is a structure that represents the ASN.1 encoding of the
+// BasicConstraints extension.
+// The structure is borrowed from
+// https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L975
+type basicConstraints struct {

IsCA       bool asn1:"optional"
MaxPathLen int  asn1:"optional,default:-1"
+}

+func checkIsCAExtension(exts []pkix.Extension) (bool, error) {
IIUC the basic problem is that istiod can't actually act as a
particularly robust RA, so we have to fence of potential abuses of the CSR
model in other ways (like rejecting CSRs that look funny).
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51920#discussion_r1671017242, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2W2TABDAMNPQRTSFWTZLQXAXAVCNFSM6AAAAABKNYNRQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRXGEZDINJSG4
.
You are receiving this because your review was requested.Message ID:
@.***>

Since we use K8S signing this way - as an requester and approver at the
same time -  we must make all the checks that are
no longer possible on the signer.

Ahh I see; this is the part I was missing. Thanks for explaining!

Closing in favor of https://github.com/istio/istio/pull/51966


Fetch definitions of PVs and PVCs

These are useful to understand the state of storage objects in the cluster.
https://issues.jboss.org/browse/RHMAP-9543

:+1: This looks good to me.

It might be better to get persistentvolumes once per dump as it currently isn't possible to use -n to restrict them to a project

Got this working, but based the work on top of code from currently in-flight PRs. Will wait for them to merge first to update this with only the relevant patch.

Updated implementation to get every PVC of every project + all PVs of the cluster.

:+1: LGTM


flutter: Error: Failed to capture screenshot.

Version
4.9.0
Steps to Reproduce

Integrate posthog SDK
Initialize it
Roam around the app to record few session
Once 3-4 sessions are recorded, incoming sessions will be blank screens along with exception.

flutter: Error capturing image: 'dart:ui/painting.dart': Failed assertion: line 6042 pos 12: '<optimized out>': is not true.
flutter: Error: Failed to capture screenshot.

Expected Result
It should not show blank screen recording nor the exception
Actual Result
Logs
flutter: Error capturing image: 'dart:ui/painting.dart': Failed assertion: line 6042 pos 12: '<optimized out>': is not true.
flutter: Error: Failed to capture screenshot.

File Path in library/SDK
File path:

Screenshots

Solution Tried
I've tried enabling the config.optOut = true but still didn't work
  static void init() async {
    try {
      final config =
          PostHogConfig('<API_KEY>');
      config.host = 'https://us<url_cont>.com';
      config.debug = kDebugMode;
      config.captureApplicationLifecycleEvents = true;

      // check https://posthog.com/docs/session-replay/installation?tab=Flutter
      // for more config and to learn about how we capture sessions on mobile
      // and what to expect
      config.sessionReplay = true;
      // choose whether to mask images or text
      config.optOut = true;
      // config.sessionReplayConfig.maskAllTexts = false;
      // config.sessionReplayConfig.maskAllImages = false;

      // Setup PostHog with the given Context and Config
      debugPrint(' ------- PostHog initialized --------');
      await Posthog().setup(config);
    } catch (e) {
      debugPrint('--------- PostHog error: $e');
    }
  }

duplicate #138


BIGTOP-3363. Drop Apex, Hama and Tajo in the 1.5.0 release.

Please refer to BIGTOP-3363 for the info of affected files.

LGTM, +1.

Thanks, @sekikn.


use POST to scroll data - fix issue #453 Elasticdump Fails to copy data

fixes taskrabbit/elasticsearch-dump#453

This fix will break versions lower than v2, hence it can't be merged.

We copy from :
version":{
"number": "6.0.1",
"build_hash": "d951bbf",
"build_date": "2017-12-07T01:43:54.348Z",
"build_snapshot": false,
"lucene_version": "7.0.1",
"minimum_wire_compatibility_version": "5.6.0",
"minimum_index_compatibility_version": "5.0.0"
},

to
"version":{
"number": "6.2.2",
"build_hash": "10b1edd",
"build_date": "2018-02-28T15:42:08.616107Z",
"build_snapshot": false,
"lucene_version": "7.2.1",
"minimum_wire_compatibility_version": "5.6.0",
"minimum_index_compatibility_version": "5.0.0"
},

I'm not sure, if the problem is different behavior of the cluster. It looks like the body will not sent by calling  a http-GET. We are using a http-proxy, the aws-loadbalancer and a zuul application to get to our es-cluster. A lot of stages that need to handle the body of a get-request.

Ok - It is Zuul who drops the body.
see: spring-cloud/spring-cloud-netflix#1964
But a GET could have a body, but should not. I've never understand why es does this.
Does it make sense to wrap the fix in a if version > 2 ?


[COMMUNITY] Mehrdad Hessar -> Committer

Please join us to welcome @mehrdadh as a new committer to TVM.
Mehrdad has greatly contributed to the Hexagon backend, tvmc bug fixes as well as microTVM implementation. He has been also very active in the PR reviews, community meetings and forum discussion to share his ideas.

Commits History
Code Review
Community Forum Summary

Congratulations @mehrdadh!

Congrats @mehrdadh !

Congrats!!

@leandron @gromero @junrushao1994 @masahi
Thanks everyone! Happy to continue my contributions as a committer.


NuGet package has dependency with known security vulnerabilities (Microsoft.AspNetCore.Hosting)

Describe your environment.

SDK version: 2.14.0
.NET runtime version (.NET or .NET Core, TargetFramework in the .csproj file): netcoreapp3.1
Hosting Info (IIS/Azure WebApps/etc): IIS
Platform and OS version: Windows Server 2019

Steps to reproduce.
Add Microsoft.ApplicationInsights.AspNetCore reference to your project. Look at transitive dependencies.
What is the expected behavior?
Reference to version of Microsoft.AspNetCore.Hosting without known security vulnerabilities (maybe latest from 1.0.x ?)
What is the actual behavior?
Reference to Microsoft.AspNetCore.Hosting 1.0.2 which is a version with security vulnerability.
Additional context.
I understand that this is probably can be fixed by using latest version of runtime in hosting, but this gets reported by security scanners as vulnerability in the project, so it is still good idea to use references on libraries without known security vulnerabilities.

Hello, thanks for reporting.
I'll be reviewing all of our compliance issues this month, including this.

Subscribed, because our package vulnerability gate is failing on this

@older, @quepasadiformaggio what tool are you using to detect this vulnerability?
The tool we're using hasn't identified this. It HAS identified other out of date packages so maybe it's a configuration issue.
I'm working on this issue this week and I'll reply to this thread when my PR has merged. You'll be able to grab our nightly build to validate.

Just merged this fix. It will be available tomorrow from our nightly builds.

We used WhiteSource bolt. You can find the message below.
Question: I'm not that familiar (yet) with GitHub & NuGet. How can we find the fixed version from NuGet? Latest I see is 2.15.0-beta2 which does not have this fix yet. Or do you mean that we grab the current develop branch from GitHub, build it locally and use in project to check wether it is fixed?
WhiteSource bolt message:
High7.5
CVE-2018-0808
Mar-14-2018
Microsoft.AspNetCore.Hosting-<IP_ADDRESS>217.dll
ASP.NET Core 1.0. 1.1, and 2.0 allow an elevation of privilege vulnerability due to how ASP.NET web applications handle web requests, aka "ASP.NET Core Elevation Of Privilege Vulnerability". This CVE is unique from CVE-2018-0784. Solution:
Upgrade to version Microsoft.AspNetCore.Server.IISIntegration - 2.1.0, Microsoft.AspNetCore.Hosting - 2.1.0
https://portal.msrc.microsoft.com/en-US/security-guidance/advisory/CVE-2018-0808

https://github.com/microsoft/ApplicationInsights-dotnet#nuget-packages - Nightly builds are available in myget feed: https://www.myget.org/F/applicationinsights-dotnet-nightly/api/v3/index.json

Thank you. I have run it again and get the same message but now for 1.1.3. Seems like upgrading to >= 2.1.0 will only fix the problem.
High7.5
CVE-2018-0808
Mar-14-2018
Microsoft.AspNetCore.Hosting-<IP_ADDRESS>908.dll
ASP.NET Core 1.0. 1.1, and 2.0 allow an elevation of privilege vulnerability due to how ASP.NET web applications handle web requests, aka "ASP.NET Core Elevation Of Privilege Vulnerability". This CVE is unique from CVE-2018-0784.
Upgrade to version Microsoft.AspNetCore.Server.IISIntegration - 2.1.0, Microsoft.AspNetCore.Hosting - 2.1.0
https://portal.msrc.microsoft.com/en-US/security-guidance/advisory/CVE-2018-0808

Can we get any update on this?

@vkpraveen there's an open PR linked to this issue, you can monitor our progress there.
Upgrading this library breaks some of our tests. The only holdup is making the time to fully investigate what changed.
We're still planning on delivering this change with our next stable release (v2.15).

Hello all, we just merged the fix for this issue.
Sorry for the many delays.
We're going to start the next beta (v2.15.0-beta3) release tonight, but because of the holiday weekend, it likely won't be available until the middle of next week.


Support the new long-distance matcher

zstd 1.3.2 added a long-distance matcher
(https://github.com/facebook/zstd/releases/tag/v1.3.2); add a function
to set that parameter.

I'd love to use this as part of compressing Rust's own dist tarballs.

Looks great, thanks for the PR!

Thanks for the merge! Would you mind publishing a new version of the zstd crate with this change?

0.8.0 should be out


Added a new button element

Changes proposed in this pull request:

Check that following are added:
-[] HTML and CSS files.
-[] Screenshots.

Good work @garvitkhandelwal :+1:
Thanks for contributing. :smile:


KAFKA-6813: Remove deprecated APIs in KIP-182, Part II

Remove the deprecated StateStoreSuppliers, and the corresponding Stores.create() functions and factories: only the base StateStoreSupplier and MockStoreSupplier were still preserved as they are needed by the deprecated TopologyBuilder and KStreamBuilder. Will remove them in a follow-up PR.

Add TopologyWrapper.java as the original InternalTopologyBuilderAccessor was removed, but I realized it is still needed as of now.

Minor: removed StateStoreTestUtils.java and inline its logic in its callers since now with StoreBuilder it is just a one-liner.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

test failures in Java 8 unrelated.
retest this please.

@mjsax @bbejeck updated based on comments

@guozhangwang Build failing with checkstyle error.

Retest this please


Mac CI via Azure Pipelines

I have successfully set up Azure Pipelines to run CI on their Mac images. I am currently running it on my fork and it all seems to work correctly.
@lmcinnes, it's a tiny bit more work to hook up the repo than the other CI providers. Here are some generic instructions, but you basically need to:

Sign up to Azure DevOps. This in turn requires some sort of (free) Microsoft account, of the sort that one would use to log into a Windows 10 PC, or an xbox, or skype, or outlook.com.
Create an "organization", which seems to be a way to collect various CI pipelines together. I just called mine 'pynndescent'.
Provide the usual permissions to/from your github account.
Add the pynndescent repo to the organization. The azure-pipelines.yml should already be correctly configured so there is no more to do.

Because I can now commit directly to lmcinnes/pynndescent, if you're not that bothered, I can probably just add it to the organization I created and/or add you as an administrator of it until such a time you want to go through the rigmarole of creating a microsoft account (if you don't already have a suitable one). I will then deal with adding a badge to the README, which is obviously the most important part of any CI system.
No new issues were surfaced from running the tests on Mac, so this is definitely not very high priority.

Pull Request Test Coverage Report for Build 14

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.365%

Totals

Change from base Build 13:
0.0%

Covered Lines:
1708

Relevant Lines:
1810

💛  - Coveralls

Thanks for this -- I have been meaning to set up azure-pipelines (to at least try it out). My problem was that I had an MS account from some time ago that I essentially never used and apparently forgot the password and now the whole thing is locked out, but associated to my email address (so I can't just create a new one). I have not yet gone through the required hoops to fix all that up. If you want to go ahead I am perfectly happy with your proposal for now.

Looks like the repo needs to install the Azure Pipelines Github App (why must this be so complicated?).
I am going to merge in the configuration file, so that when/if the microsoft account issue is resolved this can be activated without much extra fuss. I will create an issue with some of the info from here as a reminder of what will need to be done (which I will definitely not remember otherwise).
In the meantime, I will be merging from here to my fork anyway, so that will probably pick up any Mac-related issues.

Memo to self: remember to squash commits when merging.


dashboard/app: fix UI typo and formatting error

There is a typo and a formatting bug that can be viewed at bugs such as
https://syzkaller.appspot.com/bug?id=f007ef1d7a31a469e3be7aeb0fde0769b18585db
Also cleanup the formatting in surrounding areas so that it is much clearer.

Codecov Report

Merging #1324 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   57.66%   57.66%
=======================================
  Files         131      131
  Lines       24669    24669
=======================================
  Hits        14225    14225
  Misses       9770     9770
  Partials      674      674

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02b5bc...2597538. Read the comment docs.


sdl2_mixer: new package at version 2.0.4

Please fill out the template.
Read: https://k1sslinux.org/wiki/kiss/style-guide
Please include the manifest for version bumps and new packages.

Description of package
From upstream [0]:

SDL_mixer is a sample multi-channel audio mixer library.
It supports any number of simultaneously playing channels of 16 bit stereo audio, plus a single channel of music, mixed by the popular FLAC, MikMod MOD, Timidity MIDI, Ogg Vorbis, and SMPEG MP3 libraries

[0] https://www.libsdl.org/projects/SDL_mixer/
Installed manifest of package
(kiss manifest <pkg>)
/var/db/kiss/installed/sdl2_mixer/version
/var/db/kiss/installed/sdl2_mixer/sources
/var/db/kiss/installed/sdl2_mixer/manifest
/var/db/kiss/installed/sdl2_mixer/depends
/var/db/kiss/installed/sdl2_mixer/checksums
/var/db/kiss/installed/sdl2_mixer/build
/var/db/kiss/installed/sdl2_mixer/
/var/db/kiss/installed/
/var/db/kiss/
/var/db/
/var/
/usr/lib/pkgconfig/SDL2_mixer.pc
/usr/lib/pkgconfig/
/usr/lib/libSDL2_mixer.so
/usr/lib/libSDL2_mixer.a
/usr/lib/libSDL2_mixer-2.0.so.0.2.2
/usr/lib/libSDL2_mixer-2.0.so.0
/usr/lib/
/usr/include/SDL2/SDL_mixer.h
/usr/include/SDL2/
/usr/include/
/usr/

New package

[X] Latest upstream version.
[X] I agree to maintain this package.
[X] I agree to notify the @kiss-community maintainers if I can no longer maintain this package.

Existing package

[ ] I am the maintainer of this package.

https://github.com/kiss-community/community/pull/1068#issuecomment-1120940119

Removed libtool make


Clean up gitignore

It is a mess :)

Less of a mess now, will probably be an ongoing issue like most clean up tasks


Microsoft.UI.Colors throwing TargetInvocationException

Since I updated to version 3.0.0-preview3.201113.0, I'm getting the following exception when accessing Microsoft.UI.Colors.Red static property

System.Reflection.TargetInvocationException
HResult=0x80131604
Message=Exception has been thrown by the target of an invocation.
Source=System.Private.CoreLib
StackTrace:
at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean wrapExceptions, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& hasNoDefaultCtor)
at System.RuntimeType.CreateInstanceDefaultCtorSlow(Boolean publicOnly, Boolean wrapExceptions, Boolean fillCache)
at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, Boolean wrapExceptions)
at System.Activator.CreateInstanceT
at WinRT.WeakLazy`1.get_Value()
at Microsoft.UI.Colors._IColorsStatics.get_Instance()
at Microsoft.UI.Colors.get_Red()
at InputHandling.MainWindow..ctor() in C:\Projects\GrapeCity\c1-netcore\WinUI\Samples\Core\InputHandling\InputHandling\MainWindow.xaml.cs:line 34
at InputHandling.App.OnLaunched(LaunchActivatedEventArgs args) in C:\Projects\GrapeCity\c1-netcore\WinUI\Samples\Core\InputHandling\InputHandling\App.xaml.cs:line 31
at Microsoft.UI.Xaml.Application.Microsoft.UI.Xaml.IApplicationOverrides.OnLaunched(LaunchActivatedEventArgs args)
at ABI.Microsoft.UI.Xaml.IApplicationOverrides.Do_Abi_OnLaunched_1(IntPtr thisPtr, IntPtr args)
This exception was originally thrown at this call stack:
System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(int)
WinRT.BaseActivationFactory.BaseActivationFactory(string, string)
Microsoft.UI.Colors._IColorsStatics._IColorsStatics()
Inner Exception 1:
COMException: ClassFactory cannot supply requested class (0x80040111 (CLASS_E_CLASSNOTAVAILABLE))

@Scottj1s as FYI

@arivoir, this can happen if you update a preview2 project to preview3. There are some files that are in the build folder of the packaging project that have changed and need to be updated.
You can copy them over from a new preview3 project and that should unblock you

Copying the "build" folder worked. Thanks for the workaround!

Copying the "build" folder worked. Thanks for the workaround!


[Question] How to deploy Laf separately to Liunx without deploying Sealos?

Search before asking

[X] I had searched in the issues and found no similar issues.

Question
How can LAF run on Docker without deploying Sealos?

You need to find 0.8 version in releases. Current version is not support to be deployed by docker.


refactor ALB listeners/rules/certs

The load balancer/listener/rule/cert setup needs some thought:

ALBs are limited to 50 per region per account
An ALB can have a max of 25 certs, 50 listeners, and 100 rules
certs are setup at the listener level, so if there's a cert per app, we'll have a max of 25 apps (and 25 listeners)
if we do a wildcard cert for all apps, we can have a single listener and a rule for each app. this probably has the best bang for buck.
the rules for path matching are not super flexible when many paths are needed. we'll need to play around with the best way to do this. seems it's best to have a new rule for each path (as opposed to a different condition as there can only be 5 conditions per rule). if we go with one listener and a rule per app as described in a comment above, the following would work with a little refactor (with one condition per rule which maps to a specific path)

FOR NOW, WE'RE SETTING UP WITH A CERT/LISTENER PER APPLICATION AS THAT IS HOW WE TESTED ORIGINALLY. THIS SHOULD BE REFACTORED AS ASAP.  We still have some gruff, but have issues covering specific needs. Closing this as a result.

We've got wildcard certs now (one cert per port/proto pair) and a large portion of the refactor was done on https://github.com/cape-ph/cape-cod/issues/126. We still have some gruff, but have issues covering specific needs. Closing this as a result.


Add ALB limitation

ALBs now support SNI, so this piece of the guide was wrong. However, they do have an undocumented limitation of 25 certs per ALB.
Also, my editor aggressively removes trailing whitespaces. Hope this isn't a problem - if it is, I can redo my commit.

libraries.io is down so awesomebot is failing to check this link: https://libraries.io/github/awslabs/aws-iot-demo-for-danbo

LGTM! Thanks @gabinante . @ThanosBaskous is a load balancing expert so let's get his review for merge.

Also added a link on the SNI support update and restored the "undocumented" emoji.

LGTM as well. Thanks @gabinante  (and @jlevy)!


Add extra columns to table docs

Partially address #25813.

Closing since this doesn't address the docs problem as originally reported.

Actually, reopening to at least partially address the docs.


Run\Logs\<IP_ADDRESS>\2024-09-09.txt

Microsoft PowerToys version
0.81.1
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
C:\Users\devin\AppData\Local\Microsoft\PowerToys\PowerToys Run\Logs\<IP_ADDRESS>\2024-09-09.txt
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22631.0
IntPtr Length: 8
x64: True
Date: 9/9/2024 10:25:56 AM
Exception:
System.Runtime.InteropServices.COMException (0x80263001): {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (0x80263001)
at Standard.NativeMethods.DwmExtendFrameIntoClientArea(IntPtr hwnd, MARGINS& pMarInset)
at System.Windows.Shell.WindowChromeWorker._ExtendGlassFrame()
at System.Windows.Shell.WindowChromeWorker._UpdateFrameState(Boolean force)
at System.Windows.Shell.WindowChromeWorker._HandleDwmCompositionChanged(WM uMsg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Shell.WindowChromeWorker._WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
Normal operation
❌ Actual Behavior
Abnormal operation. Flashing screens. Programs closing down. Monitors going black, coming back, going black, coming back, multiple times.
Other Software
General interaction with computer.

/dup #30507


allow for help_color to be an Pastel::Detached object

Describe the problem
This goal of this ticket is to make it possible to give a Pastel::Detached instance as help_color argument to TTY::Prompt#new. This would make sense since Pastel is used anyway and it would allow for more options.
Steps to reproduce the problem
irb(main):001:0> require 'tty-prompt'
=> true
irb(main):002:0> require 'pastel'
=> false
irb(main):003:0> pastel = Pastel.new
=> #<Pastel @styles=[]>
irb(main):004:0> fancy_color = pastel.cyan.on_white.underline.detach
=> #<Pastel::Detached styles=[:cyan, :on_white, :underline]>
irb(main):005:0> prompt = TTY::Prompt.new(help_color: fancy_color)
=> #<TTY::Prompt: {:input=>#<IO:<STDIN>>, :output=>#<IO:<STDOUT>>, :prefix=>"", :active_color=>:green, :error_color=>:red, :enabled_color=>nil, :help_color=>#<Pastel::Detached styles=[:cyan, :on_white, :underline]>}
irb(main):006:0> prompt.select('Whats ya eatin?', %i[hamburger fries salad])
Traceback (most recent call last):
       16: from /usr/local/bundle/gems/tty-prompt-0.20.0/lib/tty/prompt/list.rb:404:in `render'
       15: from /usr/local/bundle/gems/tty-prompt-0.20.0/lib/tty/prompt/list.rb:455:in `render_question'
       14: from /usr/local/bundle/gems/tty-prompt-0.20.0/lib/tty/prompt/list.rb:491:in `render_header'
       13: from /usr/local/lib/ruby/2.6.0/forwardable.rb:230:in `decorate'
       12: from /usr/local/lib/ruby/2.6.0/forwardable.rb:230:in `decorate'
       11: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:60:in `decorate'
       10: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:140:in `lookup'
        9: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:140:in `fetch'
        8: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:141:in `block in lookup'
        7: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:153:in `code'
        6: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:153:in `each'
        5: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:158:in `block in code'
        4: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:236:in `validate'
        3: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:195:in `valid?'
        2: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:195:in `all?'
        1: from /usr/local/bundle/gems/pastel-0.7.3/lib/pastel/color.rb:195:in `block in valid?'
NoMethodError (undefined method `to_sym' for #<Pastel::Detached styles=[:cyan, :on_white, :underline]>)
Did you mean?  to_s

Actual behaviour
Only instance of Symbol or responding to to_sym is allowed.
Expected behaviour
I hoped an instance of Pastel::Detached would also work.
Describe your environment

OS version: Ubuntu 18.04.3 LTS
Ruby version: ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux] (in docker, FROM ruby:2.6.5)
TTY version:

gem list tty

*** LOCAL GEMS ***

tty-color (0.5.0)
tty-cursor (0.7.0)
tty-prompt (0.20.0)
tty-reader (0.7.0)
tty-screen (0.7.0)```

Hi Paul,
Thanks for using this gem! ❤
My preferred way would be to make it respond to common interface like call method. In other words, provide a way to specify color as a lambda. Both, lambda and Pastel::Detached respond to the same method. This would make it more flexible.

Thanks for your idea. Should we maybe change the Pastel#decorate method instead of Prompt#decorate (as is currently in #124 )?

The pastel gem is used by many gems and I would need a very good reason to change its api and break many other projects. I don't believe the changes in pastel are needed. The reason to use proc is so that you should be able to inject any type of coloring library.

I feel as though the :help_color should accept both a symbol or proc object. When proc gets passed in then the user needs to provide their own coloring:
help_color: ->(string) { 3rdPartyLibrary.color(string) }

And then the Prompt#decorate method would check if colors are simple strings or proc object and act accordingly. Would you have time to change your PR?

Any callable object, not only Pastel#detached can be used as the value for :active_color, :error_color and :help_color values.


apko development environment

This PR adds a shell script that allows a one-command way to start an apko development environment.
Running the following script from the top of the apko repo launches a series of steps that use apko itself to build an image and drop the user into a development shell:
./hack/make-devenv.sh

The environment is pre loaded with some tools (currently go, git and jq) and the user shell is opened with the apko repository mounted, ready to run any changes you make in your editor. I've also added a first draft of a CONTRIBUTING.md doc with instructions to launch the shell and basic info for contributors.
The image is apko-inception because apko is building the apko environment with a script that calls itself multiple times :)

Let me know of any problems in other (non linux) platforms, etc


Eager execution of lifecycle.beforeProject

Part of https://github.com/gradle/gradle/issues/29187

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this on linux

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger)(Linux) (Check)

@bot-gradle test this on linux

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger)(Linux) (Check)

@bot-gradle test this on linux

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger)(Linux) (Check)

@bot-gradle test this on linux

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger)(Linux) (Check)

@bot-gradle test this on linux

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger)(Linux) (Check)

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.


Pushing latest work

@marcesher and @vickumar1981 Please review
also paging @dgreisen and @Ooblioob form beyond CFPB, because things just got interesting and I know you are interested.

hmmm there seems to be conflicts on this PR :(


Add attribute to indicate whether element has value or not

Add an attribute/property which indicates whether the input is empty or not. Intended usage is in CSS selectors ie
paper-chip-input-autocomplete[has-value] {...}

Unfortunately it seems that the standard :placeholder-shown class is not working with polymer elements (ie even with paper-input).
Vaadin elements do have (at least combo-box and date-picker) hasValue property for this purpose.

You can check the length of the property items in paper-chip-input-autocomplete.

Could check the items.length in code, but how to write it in CSS? Ie
  paper-chip-input-autocomplete[not(items.length=0)]{
     --paper-chip-autocomplete-focus-color: yellow;
  }

doesn't work.


cmd/compile: valid string(1<<s) is not accepted

https://play.golang.org/p/iS44hmBD5n
produces
tmp/sandbox014611473/main.go:5:12: invalid operation: 1 << s (shift of type string)
which is clearly wrong. The program should compile and run.

It's not obvious to me that the error is wrong. If complex128(1<<s) is invalid, why should string(1<<s) be valid?
I realize integer-to-string conversion is a different kind of conversion than integer-to-complex, but I can't immediately spot any spec wording that suggests this distinction is relevant here.


[BUG] Editing Stickers or Making the same skin already applied with Other Stickers not applying atm.

Reproducing:
Alternative 1

Edit existing skin
Add Stickers
Say !ws
Stickers not applying after buying..

Alternative 2

Create same skin as existing one
Add stickers to it
Say !ws
Stickers wont apply after buying.

All of this either update when reconnecting.

Added this to the list of known issues.
Looks like the server/client caches the stickers IDs in the first person viewmodel and that's why it won't change even if the new stickers are being added as an attribute to the weapon. Due to my lack of deep RE skills this won't be fixed anytime soon.


Continue Url not utilized after upgrade to Vendr.net 1.5

First of all I do realize that this is a bit premature to send an Issue, since the repo is not updated to support vendr 1.5 as of writing, but we have upgraded the rest of the website and now the continue url isn't utilized on the reepay payment window.
Is this something that will be resolved in an upcoming version and if so, is there an estimate on the release?
Webhooks and the order flow seems to work as before, but we would like the customer to be transferred back to the website as before.

I haven't tested Reepay with v1.5 yet, but I don't think there should be changed how continueUrl is returned from Vendr.
https://github.com/vendrcontrib/vendr-payment-provider-reepay/blob/dev/src/Vendr.Contrib.PaymentProviders.Reepay/ReepayCheckoutPaymentProvider.cs#L128
As a recall Reepay payment window shows a "Continue" button after payment and clicking this, would redirect to the Accept URL.

Hi Bjarne
Thank you for the reply. It's quite mysterious, since we haven't changed anything in backoffice, so the continue url should be the same, do you know if there is a way to check the parameters passed to reepay? The changelog on Vendr doesn't mention any changes to the parameters either, so we are searching for a needle in a haystack. I think we will revert Vendr back to 1.4 and hope that it will solve the issue for now.

@larsnikander is this continue URL in Vendr a relative or absolute URL?
Do you use another route for backoffice than /umbraco, which is configurable, but Vendr didn't support that until v1.6.0, but since it worked to you previous I guess this isn't the issue here.
Some payment gateways allow to see logs of the requests, but as far I can tell Reepay doesn't have an option to see this in the UI. You could eventually contact Reepay to check to payment request - if you inform them about the Order Number .

@bjarnef we use absolute urls since the frontend is running on a different domain than backoffice, so continue and cancel urls are pointing to a different domain than where umbraco is running. Could that be an issue? I will try to contact Reepay to hear about the orders.

Maybe, but then it's strange it worked previous.
If you could check the raw payment request from Reepay it would be great to see if the "AcceptUrl" is correct. The redirect when clicking the Continue button is handled by Reepay, so it could be a change in their end.

So after talking to Reepay I found that the accept url is not send to their system after the upgrade, neither is the cancel url
Session from before the upgrade:
{   "id": "cs_a92a[...]c9110",   "type": "CHARGE",   "expires": "2021-06-25T08:58:25.874+00:00",   "charge": "TEST-0449-0537-MW7L",   "settle": false,   "recurring": false,   "customer": "3519[...]0805",   "created": "2021-03-25T08:58:25.872+00:00",   "currency": "DKK",   "url": "https://checkout.reepay.com/#/cs_a92a[...]c9110",   "phone": "53733057",   "cancel_url": "https://[...].illumi.dk/bestil",   "accept_url": "https://[...].illumi.dk/tak-for-bestilling",   "payment_methods": [     "visa",     "dankort",     "mc",     "mobilepay",     "visa_elec",     "maestro",     "diners"   ] }
Session from after the upgrade:
{   "id": "cs_fb9d[...]3017f",   "type": "CHARGE",   "expires": "2021-07-07T07:12:19.399+00:00",   "charge": "TEST-0461-0432-9R7R",   "settle": false,   "recurring": false,   "customer": "9d9[...]06f",   "created": "2021-04-06T07:12:19.396+00:00",   "currency": "DKK",   "url": "https://checkout.reepay.com/#/cs_fb9d[...]3017f",   "phone": "00000000",   "payment_methods": [     "visa",     "dankort",     "mc",     "mobilepay",     "visa_elec",     "maestro",     "diners"   ] }

Okay strange, it should be included here unless the value is null.
https://github.com/vendrcontrib/vendr-payment-provider-reepay/blob/dev/src/Vendr.Contrib.PaymentProviders.Reepay/ReepayCheckoutPaymentProvider.cs#L128
You could eventually fork/clone the project, compile the project in debug mode and copy the dll to tin site /bin folder.
Then on local environment go the checkout, select Reepay and continue to payment window.
If the place a breakpoint here https://github.com/vendrcontrib/vendr-payment-provider-reepay/blob/dev/src/Vendr.Contrib.PaymentProviders.Reepay/ReepayCheckoutPaymentProvider.cs#L143 you should be able to see the payment request data and the value of continueUrl.

I found the error, but it wasn't in the Reepay package.
When we generate the payment form we access the PaymentProviderSettings from the payment method using camelCase, this however is now PascalCase (don't know if it is due to the new vendr update or if we have changed something) thus the ContinueUrl and CancelUrl is never fed to the form generation.

Okay great you found the root cause 👍
Not sure if something specific has changed in PaymentProviderSettings in Vendr (not as far as I know).
However the ReepayChargeSessionRequest model should be fed with data and serialized according to the model properties:
https://github.com/vendrcontrib/vendr-payment-provider-reepay/blob/main/src/Vendr.Contrib.PaymentProviders.Reepay/Api/Models/ReepaySessionRequestBase.cs#L16-L20
Actually I wonder if you might have globally overwritten the JSON serializer settings, which could affect the serialization here:
https://github.com/vendrcontrib/vendr-payment-provider-reepay/blob/dev/src/Vendr.Contrib.PaymentProviders.Reepay/Api/ReepayClient.cs#L114-L120

I have just checked v1.1.0 with Vendr v1.5.3 and v1.6.0 and in both cases in seems both Accept URL and Cancel URL are populated correct.


Remove unecessary gradient computation

Fixes #301. As far as I can tell, the autograd graph is never needed anywhere after OptimIterator.forward.
Would there be a better way to do this? It would seem simpler and more efficient to wrap the entirety of OptimIterator.forward in a no_grad context manager, but I'm not familiar enough with the codebase to know whether that could have some unwanted side effects.
Checks to be done before submitting your PR

[X] python3 -m pytest tests/ runs successfully.
[X] black . runs successfully.
[X] make html runs successfully (in the docs/ directory).
[X] Updated docstrings related to the changes (as applicable).
[X] Added an entry to the CHANGELOG.rst.

Thanks for spotting this - @samuro95 / @matthieutrs can you have a look?

Thanks ! I think that model.eval() should solve the issue.

Thanks for noticing this important issue. I propose the following workaround: add a torch.no_grad() in the forward of the class BaseOptim and keep it unchanged in the forward of the class BaseUnfold


Pointer style can confuse function name parsing

If I have a function defined as follows:
/* 0x800360F0 */ void *Malloc(struct heap_node *heap, s32 size);

The logic in get_funcs_defined_in_c will consider the asterisk to be part of the name, which causes downstream issues.
This can be avoided by keeping the asterisk from touching the function name. It seems unintentional to have this tool enforce a pointer style though.

Thanks for raising this! yeah, the idea of putting the ram address before the function defintion like this seemed like a good idea to me at the time, but in Paper Mario we've moved to a new format that I recommend. You can create a symbol_addrs.txt that looks like undefined_syms.txt:
Malloc = 0x800360F0;

I think I'll phasae out this comment before the function in the code files approach soon. Let me know if you have trouble migrating to the new format or you have any other questions. :)

I had seen the symbol_addrs.txt handling in the code and hadn't tried it yet. I agree this will be a more maintainable approach, so I'll close this issue. Thanks!

I'd like to reopen this based on additional testing. I've switched to symbol_addrs.txt, which is working well, but I'm noticing that this parsing issue leads to unnecessary nonmatchings files. So despite having void *Malloc() { ... } implemented in my actual C file, I still get a Malloc nonmatchings file. It doesn't get used and the build is fine, so this not a high priority issue for me.

Thanks for the info (and sorry for the late reply)!
I'm going to close this one, but I opened #18 which is more specific to your problem.

@PartyPlanner64 is the issue in #18 still present? If so, I'd like to try to debug it with your project. Could you let me know what repo / branch I can use to reproduce?

@PartyPlanner64 is the issue in #18 still present? If so, I'd like to try to debug it with your project. Could you let me know what repo / branch I can use to reproduce?


Feature/exclude classes protocols

This PR adds the optional feature to exclude certain classes and protocols from being mocked.
Use case:

Protocol with associatedType(s) has default extension methods that we want to mock in concrete class that conforms to this protocol.
And we might want to mock these default protocol extension implementations.

So we do need the protocol to be defined as input files for inheritance. But we exclude the protocol as being mock 'stand-alone'.

@TadeasKriz and this one as well ;)

Hi, sorry for the long delay. I finally merged huge change and I'd like to ask you if you could try and rebase this PR on top of current master. Then I'd like to merge it. Thanks!

Merged, thanks!


java core plugin metadata stuck/out-of-date

Describe the bug
The metadata actions running at https://github.com/jdx/rtx-java-metadata seem to be failing. There were Java releases earlier this week but they seem to not be flowing through.
https://github.com/jdx/rtx-java-metadata/actions/workflows/update.yml
Root cause seems to be Required status check "test" is expected.. I'm guessing the direct push-to-main action is not able to satisfy this status check?
There are no code changes since then, so I guess either the repository config was changed, or GitHub changed the way these work? (edit: Now I think about it, if there were no Java releases there would have been nothing to do/push on earlier dates so this might have been broken earlier than July 16 - it was just that July 16 was the Java quarterly release date)
Push to branch main
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Required status check "test" is expected.
To https://github.com/jdx/rtx-java-metadata.git
 ! [remote rejected]     HEAD -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/jdx/rtx-java-metadata.git'
Error: Invalid exit code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/ad-m/github-push-action/master/start.js:30:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1
}

To Reproduce
mise use<EMAIL_ADDRESS>should be working by now, all releases for major archs have been published and are on the Adoptium API.
https://api.adoptium.net/v3/assets/feature_releases/21/ga?page=0&page_size=20&project=jdk&sort_order=ASC&vendor=adoptium
Expected behavior
mise use<EMAIL_ADDRESS>works :-)
Additional context
Sorry, issues tab is disabled on that repo, so raising here.

Oh, I see this may be a known issue based on the comment at https://github.com/jdx/rtx-java-metadata/pull/7

Yes i assume some branch protection settings are in place on the repository which prevent the action from pushing the changes successfully. Same actions work fine on my fork at https://github.com/roele/mise-java-metadata/actions.

Should be pretty easy to remove; just requires a bit of care reviewing PRs.
Alternatively, change the automation to push to a branch instead + create a PR which is set to auto-merge/squash/rebase+merge on test pass :-)

@roele since my availability is very poor this summer for mise, I went ahead and added you as a collab for the Java Metadata repo to figure out what settings may need to change.

I will note the obvious that given we’re in a state where we can’t even review PRs because the diffs are obvious is not good. I considered maybe this should just be rolled into the version host but then again just the Java metadata alone is way more complex than everything else put together.

@jdx Thanks for adding me as collaborator. The permissions do not seem to allow me access to the repository settings though. I suspect that push to main is forbidden/restricted. Maybe the workflow should create a PR which is automerged as suggested by @chadlwilson instead.
Regarding the PRs i share your sentiment. The fact that the each update touches thousands of files is insane. GitHub is not even showing the diff because of the amount of changes.

@jdx Thanks for adding me as collaborator. The permissions do not seem to allow me access to the repository settings though. I suspect that push to main is forbidden/restricted. Maybe the workflow should create a PR which is automerged as suggested by @chadlwilson instead.

Yeah, I think you need to be admin or repo owner to change that. Should be pretty easy to change the rule though:

Just means a bit more discipline when reviewing any PR to ensure the checks are passed before hitting merge, which should be manageable for that repo given the limited contributors and low PR count.

@chadlwilson Since the update-metadata workflow runs every 12h we don't want to merge these manually. Manual merges for other/manual PRs affecting the bash scripts etc. would be good though.
I was playing around with this in a personal repository (https://github.com/roele/create-pr-test) using peter-evans/create-pull-request@v6 to create a pull request for the scheduled workflow. There seems to be some pitfalls though like using GITHUB_TOKEN which prevents other related workflows such as a Test to run. Also cannot get auto-merge to work even though it is enabled on repository level. Require status checks is enabled but cannot add a Test workflow as required as it does not show up in the picker.

@roele Yes, I agree - I am explaining for @jdx how to disable the status check so the workflow can continue to push to main directly for the 12-hourly updates, on the assumption that he's perhaps not familiar and enabled this some time ago and then forgot about it :-)
It's literally a couple of button clicks to disable a status check from being required/un-"peotect" a branch. Note the very important text:

When enabled, commits must first be pushed to another branch [...]

This is why the required status check broke the update automation.
What I'm trying to say is that for any other remaining PRs, the consequence of making the status check no longer "required" is that PRs submitted to fix things manually (perhaps in the scripting or the github actions automation) aren't automatically blocked from clicking the merge button.
Branch protection is pretty limited anyway. A repo admin can still override it and force the merge unless "Do not allow bypassing the above settings" is enabled - all it does is force a "wait, status checks didn't pass/run" stop point, and force a bit more discipline on any outside collaborators.
Just disabling the status check seems infinitely easier than trying to set up a whole PR and auto-merge flow and with very limited downsides in this case. If the status check is simply disabled the automation should flow through normally.

Require status checks is enabled but cannot add a Test workflow as required as it does not show up in the picker.

They only appear in the picker when they have been run once, but you do seem to have done so, so it should be there. Weird. But yes, having spent a lot of time with it, the UI is pretty annoying (any the required checks unmaintainble in practice when using matrix builds that change often).

@roele sorry this one completely slipped past me but I disabled that setting


Test fail when using vitest, Angular 18 and @jscutlery/swc-angular v0.17.0

Hey!
I have a Stepper Component extending the CDKStepper. In it's Provider Array it has something like:
providers: [{provide: CDKStepper, useExisting: CustomStepper}]
Also We have a Custom Step Component having the same but CdkStep and CustomStep
In our tests we use a test Component that is using the Custom Stepper and Steps.
With version < 0.17.0, the CDKStepper gets its Constructor Arguments e.g. ChangeDetectorRef, but in version 0.17.0 it doesn't
The Error:
TypeError: Cannot read properties of undefined (reading '_stateChanged')
It's properly this line
Can't create a example repo for now.
Just let me now if you need more infos
Thanks!

@jahusa02 Hi, did you update @swc/core to latest too? If it not help, need detailed reproduction for component and tests

same issue. I got Error: 'env' and 'jsc.target' cannot be used together.

@jahusa02 OK try to dig to it soon, to check why that happens, because transpiled code works properly, but original code has problems.


feat(regioninput): add RegionInput component, use in AddressForm

Resolves #345
Impact: minor
Type: feature

RegionInput

Creates RegionInput component, pulling https://github.com/reactioncommerce/reaction-component-library/blob/97a0d91f5d03dd7262e69633960b17cd8194d997/package/src/components/AddressForm/v1/AddressForm.js#L392 out of AddressForm and into its own re-usable component
Adds docs and tests for various scenarios: TextInput field, Select field, a pre-filled TextInput field, a pre-filled Select field

AddressForm

Refactors AddressForm to use RegionInput

Fixes

I corrected a spelling on a prop object value: https://github.com/reactioncommerce/reaction-component-library/pull/354/files#diff-f9fd26feeb715b8d3d2968faa3f81589L110

Testing

RegionInput: https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com/#!/RegionInput
AddressForm: https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com/#!/AddressForm

🚀 Preview deployed
Built with commit 4af28eae3aa1afa0a8c9d1636a5779ca6c3d49d7
https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com

@aldeed Ready for re-review!

:tada: This PR is included in version 0.54.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve performance for git dependencies

At the moment, the git dependencies download method performs the following:

Clone entire repository (not recursive, no submodules)
Git checkout to the desired rev if any
Git rev-parse HEAD to get the checked out commit hash

If submodules are not desired, then we could maybe instead do

a shallow clone (when no "rev" is present), but then checkout and rev-parse will not work

e.g. for the chainlink repo, normal cloning takes 32 seconds, shallow takes 5 seconds

a tree-less clone (with --filter=tree:0), which is faster and pulls trees as needed (so checkout and rev-parse work)

e.g. for the chainlink repo, tree-less takes 10 seconds

hitting the zip file instead (at https://github.com/owner/repo/archive/[commit].zip)

Working on it, for now I added --filter=tree:0 which seems to be the less disturbing solution.

We need to make sure it will work with tags and branches and everything that we added new

This has been improved by using --filter=tree:0. I don't think we can do much better if we want to keep supporting dependencies using git submodules for their deps (default foundry behavior).


Staking weight goes down when coins are sent?

Had full weight for staking in the wallet, but when coins were sent, staking weight went to 1.  Sending coins appears to reduce almost the entire staking weight until the sent coins are confirmed.

It appears the weight is reduced until the sent transaction reaches 50 confirmations.

Staking weight grew to 3 after about ten minutes.

It appears the full staking weight is restored after the last sent transaction has 50 confirmations.

I tested the process again, and it does appear to be what is taking place.  This could be a challenge for staking if frequent transactions are made.  This doesn't appear to take place when sending coins to your own wallet.
Steps for reproduction:
Send x42 to another wallet.
Wait for the sent transaction to reach 50 confirmations.

And what's the problem? You spent the input (inputs), so it (their) weight decreased.

I sent several small transactions again tonight in rapid succession.  The weight did not decrease until the fourth transaction.

Sending coins will reduce your weight, as you will have less of them mature.
Sending coins to yourself can also reduce your weight for the same reason.

This is a normal process of spent coins and staking weight.
This issue should be closed


Computations taking infinite time for some velocity models

Hi @wsja
For some velocity models, receiver function computations take an infinite time. When I use verbose=1, I see the following output, and stays the same forever. What could be happening here? I tried tweaking the velocity model in question, but same outcome. I am sorry for opening all these issues, but it seems the only way to resolve them. Thanks in advance!
 phase:          400
 layer: type:
      8     1
      7     1
      6     1
      5     1
      4     1
      3     1
      2     1
      1     1
      1     5
      2     5
      3     5
      4     6
      5     6
      6     6
      7     6
      7     3
      6     3
      5     3
      4     3
      3     2
      2     2
      1     2

 phase:          401
 layer: type:
      8     1
      7     1
      6     1
      5     1
      4     1
      3     1
      2     1
      1     1
      1     5
      2     5
      3     5
      4     6
      5     6
      6     6
      7     6
      7     3
      6     3
      5     3
      4     3
      3     3
      2     3
      1     3

@pasansherath, no reason to apologize. Your comments are very helpful for making PyRaysum better and may be valuable for other users. Thanks for raising them.
I'll come back to you later this week. In the meantime, could you please post the parameters that you were using (model file, and the non-default arguments to Control and Geometry)? Perhaps a minimal working example?

From your output, I understand that you have set mults=2 in combination with a model with 8 layers. I understand and expect that seemingly infinite run times result from this setup, as the code will compute a vast combination of reflected wave types. In the standard configuration, this would yield a segmentation fault. Please see curve Obs-M2-F-RF or Num-M2 of Figure 6 of the PyRaysum paper.
You have several options to proceed from here:

Isolate the specific reflections you are interested in and define them using Control.set_phaselist(descriptors). This is advanced usage and I am happy to get you started with that.
Try to reduce the complexity of your model, using fewer layers
If you do not require dipping layers, you can try Telewavesim instead.

To limit the number of phases, there is now a new method of Model in the dev branch: Model.get_phaselist() gives you fine-grained control over which phases to include in your calculation. This could be useful for your use case. I'd be happy to get some feedback, if you'd like to give it a try :smile:

Hi @wsja, Thanks very much for your suggestions, and I am sorry for the delay in responding to you.
I was able to resolve the issue I had by splitting a ~20 km thick layer into two identical ~10 km thick layers.

I also need to model all possible phases, therefore setting the phase list is not ideal.


If server business server down ,how to maintain transaction

I am wondering If my service server crash，how to resume transactions and maintain data consistency?

If a caller receives failback, the alpha will rollback. So this situation shall not concern.


Is this repo being maintained?

This repo is great, however, it needs updates with the latest GH Copilot features.
Is this repo being maintained?

Happy to help but with no response I
will diverge my fork even more

Hello,
Yes it is maintained. It receives updates quite often.

Friends I've been OOF recovering. This is the main reason some of the PR's have not been merged yet.
I would really appreciate some patience here.

Take care @cmendible Hope you recover soon.
And patience is no problem.