Https verify can have Boolean or string

I removed string_to_bool function, It was only used for HTTPS_verify, I changed It for get_valid_https_verify which is more accurate now.
I added unittests for several cases with this method.
I couldn't get all the project unittests working, It would be nice if there could be some documentation on what's necessary for all the tests to pass, I couldn't find It in CONTRIBUTING or README files. The Unittests for the method I added pass (util_test.py).
This should close #55. :-)

Can one of the admins verify this patch?

test this please

Thank you Javier for this PR! It's very good that you added unit tests for the extended functionality, however it would be more useful if they were referenced from main_test_script.py so that they can be run automatically along with the rest of the unit tests. More information about running B2HNADLE unit tests can be found in the README.
One last thing: I'm in favour of the previous method name (string_to_bool) because it's more generic and it will be easier to reuse in the future if an option other than HTTPS_verify needs the conversion functionality.

Hi!
I'll add It to main_test_script.py. :-)
The problem with string_to_bool is that now is wrong, because is not a string to bool conversion, but It could be also a string returned. It's a very specific functionality and string_to_bool was only used for this case and now the case has changed. I'm open to change the name but string_to_bool wouldn't be accurate anymore, maybe something like string_to_bool_or_string but I don't find It very appealing and this method transformation is very specific to HTTPS_verify.
What do you think?

By the way, It would be nice to have a link from the main README to the test README.

The problem with string_to_bool is that now is wrong, because is not a string to bool conversion, but It could be also a string returned. It's a very specific functionality and string_to_bool was only used for this case and now the case has changed. I'm open to change the name but string_to_bool wouldn't be accurate anymore, maybe something like string_to_bool_or_string but I don't find It very appealing and this method transformation is very specific to HTTPS_verify.

I see your point. I would also expect a string_to_bool method to behave like distutils.util.strtobool. On the other hand, if the method is specific to HTTPS_verify, why do we include it in a util library intended for common re-usable functions?
I don't have a strong preference so we might as well leave the new method name.

By the way, It would be nice to have a link from the main README to the test README.

Good point - will fix that.
One last thing: It would be nice to update the help text for the HTTPS_verify param to make it clear that, besides true/false, a user can pass the path to a CA_BUNDLE file or directory with certificates of trusted CAs
Again, many thanks for the PR.

I see your point. I would also expect a string_to_bool method to behave like distutils.util.strtobool. On the other hand, if the method is specific to HTTPS_verify, why do we include it in a util library intended for common re-usable functions?
I don't have a strong preference so we might as well leave the new method name.

I totally agree with you, I added there the method because It was were the string_to_bool method was. I'll check if It makes sense having It somewhere else.

One last thing: It would be nice to update the help text for the HTTPS_verify param to make it clear that, besides true/false, a user can pass the path to a CA_BUNDLE file or directory with certificates of trusted CAs

Sure!

Hi!
I added all the changes you suggested, I created a new utilconfig.py and moved the tests to utilconfig_test.py. I also added the unittests to main_test_script.py.
Could you please let me know if everything is good to go?
Thank you!
Note: I didn't squash any commits so It's easier to follow what I did.

test this please


HBASE-27043 Let lock wait timeout to improve performance of SnapshotHFileCleaner

More details and improve result is at https://issues.apache.org/jira/browse/HBASE-27043

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 58s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
compile
0m 45s
master passed

+1 :green_heart:
shadedjars
3m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
shadedjars
3m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
201m 41s
hbase-server in the patch passed.

224m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4437

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3578bc607b31 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ad64a9baae

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/testReport/

Max. process+thread count
2813 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
0m 38s
master passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
206m 51s
hbase-server in the patch passed.

229m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4437

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a4e2026ee622 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ad64a9baae

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/testReport/

Max. process+thread count
2536 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4437/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.


Provide a hook to configure the grouping of operations

The grouping of swagger operations on swagger-ui is now controlled by tags on the operation. Given that the entire swagger JSON is now a single http endpoint it a appears far simpler to determine a resource grouping and we could potentially eliminate the need for and complexity of ClassOrApiAnnotationResourceGrouping. We should also provide an easy way to extend or hook into how tags are assigned to operations.

Currently uses the existing resource grouping to generate tags based on groups generated via ClassOrApiAnnotationResourceGrouping.
Fixed via refactoring


BigModel Provider Addition

Description
Implements BigModel provider adapter with proper error handling.
Key Changes

Add BigModel adapter extending OpenAISDKChatAdapter
Implement retry logic with exponential backoff for rate limits
Handle Chinese-specific error messages ("未正常接收到prompt参数", "messages 参数非法")
Add proper type hints and overloads for async execution

Model Support
Added All GLM models with CNY pricing (following Moonshot's pattern lines 16-32):
Testing

All tests passing
Mypy type checking passing
Proper error handling verified

Hello, is there anyway i can have this reviewed soon, or maybe i can contanct support?
-Thank you

Thank you so much! Will be waiting for your reply!

Thanks for the contribution. Merging!

Fixed pricing here

Thank you so much. ive tried contacting your customer support through the web interface, is there a better place as this was not the only contribution i had planned. Thank for reviewing!

@DexSniffer You can create issues on github or contact me directly

Hey Luke, I'm the one who submitted big models. I'm also like the second
person to fork the repo and I will say you did not make that easy to do at
all. Actually if I had to guess you dont want people doing it lol.  Not one
dev I knew could do it and I had to use AI all the way through. Took me 20
hours non stop but I finally got my endpoint. It was So worth it. Insane
what I've accomplished with it.
Ive restricted my self from Making videos about martian. Its too good to
give away. All my content goes viral and I was wondering if you had an
affiliate link?  Also I'd like a job with Martian. I'd rebrand everything
to martian and pump my same content. You did an amazing job literally noone
knows what this is. I run a discord and a tiktok and we are going to be
building these out and configuring them as part of our company package as a
premium model for rag applications. I'm currently building one purely for
embedding models. Anyway exciting stuff.
Regards-
Justyn
On Tue, Nov 26, 2024, 11:56 AM Luka Samkharadze @.***>
wrote:

@DexSniffer https://github.com/DexSniffer You can create issues on
github or contact me directly
—
Reply to this email directly, view it on GitHub
https://github.com/withmartian/llm-adapters/pull/132#issuecomment-2501596398,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BI42IJ3K36LNYTUPT243FMT2CSY6JAVCNFSM6AAAAABSF77QFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGU4TMMZZHA
.
You are receiving this because you commented.Message ID:
@.***>

Hey @0xcmd, could you email me at<EMAIL_ADDRESS>Let's have a call to discuss some

Hey Luke, Do you mind telling me what endpoint im supposed to use? for
microsoft azure.
Thanks,
Justyn
On Thu, Dec 5, 2024 at 11:22 PM Luka Samkharadze @.***>
wrote:

Hey @0xcmd https://github.com/0xcmd, could you email me at
@.***?
Let's have a call to discuss some
—
Reply to this email directly, view it on GitHub
https://github.com/withmartian/llm-adapters/pull/132#issuecomment-2522168659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BI42IJ2FRX2AVAUN5QVUVQD2EEYAXAVCNFSM6AAAAABSF77QFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRSGE3DQNRVHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

We don't have proper azure support as of now. But as far as I know when you register for Azure, they give you custom endpoint

Ya ive figured it out, but on your front end you accept azure base url and
api key. And I've tested and it works fine, now I'm off to DATABricks to
move my models from azure over to a group in databricks similar to github.
Then Turn my azure endpoint Into agents and or flows. Should be
interesting. Ive made a custom prompt for router using openweb frameworks,
3 system prompts clashing together lol it literally thinks and reasons with
the router, will stop, think and continue. I had to get azure cause I was
hitting limits hard.
Most fun I've had in a long time.
Thanks again for making it.
Bts I'm still looking for that affiliate link or marketing job you have
posted.
Regards
Justyn
On Thu, Dec 12, 2024, 12:27 AM Luka Samkharadze @.***>
wrote:

@0xcmd https://github.com/0xcmd We don't have proper azure support as
of now. But as far as I know when you register for Azure, they give you
custom endpoint
—
Reply to this email directly, view it on GitHub
https://github.com/withmartian/llm-adapters/pull/132#issuecomment-2537921625,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BI42IJ4Q2WUS66MVNRDD3NL2FEUGZAVCNFSM6AAAAABSF77QFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXHEZDCNRSGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Could you contact me on email for ways to collaborate?
<EMAIL_ADDRESS>or
<EMAIL_ADDRESS>


Please update the typings

When registering a 'chat' trigger the callback requested is a (...args: unknown[]) => void through some testing I came to the conclusion that the only argument ever provided to the callback is a ChatTrigger$Event I suggest that the requested call back should be a (event: ChatTrigger$Event) => void
What this would mean registering a new 'chat' trigger would look like this
register('chat', (Event: com...ChatTrigger$Event) => {
    // Do stuff
});

I have also noticed that the typings that were generated and provided with the beta 12 release are incorrect. Example:
// typings.d.ts Line 42022
const ChatTrigger$Event: {
    message: com.chattriggers.ctjs.api.message.TextComponent;
    new(message: com.chattriggers.ctjs.api.message.TextComponent): com.chattriggers.ctjs.api.triggers.ChatTrigger$Event;
}
interface ChatTrigger$Event extends com.chattriggers.ctjs.api.triggers.CancellableEvent {
}

// Should be
interface ChatTrigger$Event extends com.chattriggers.ctjs.api.triggers.CancellableEvent {
    message: com.chattriggers.ctjs.api.message.TextComponent;
    new(message: com.chattriggers.ctjs.api.message.TextComponent): com.chattriggers.ctjs.api.triggers.ChatTrigger$Event;
}

Now this is not the only instance of incorrect typings but it is the main one the bothered me. Because when working in a TypeScript environment (which is able to be properly loaded by ChatTriggers) I can not get proper auto complete or type hints and get constant errors because types do not match or do not have to properties they should,
Examples:

register('chat', (Event) => {
    cancel(Event);
})

register('chat', (Event) => {
    const Message = Event.message.getUnformattedText();
    const Tokens = Message.split(' ');

    console.log(Tokens[5]);
}).setChatCriteria('${*}').setStart().setFormatted(false);

Messages with captured parameters in the criteria also pass in those parameters before the chat event. For instance
register('chat', (name, message, event) => {
}).setChatCriteria('${name}: ${message}');

register('chat', (name, message, event) => {
    console.log(`Name: ${name}`);
    console.log(`Message: ${message}`);
    console.log(`Event: ${event}`);
}).setChatCriteria("${*}");

Ok so only if the message captures something like the player name will it be passed through

Also, yes there are some issues with the typings so we can still tweak them, but we separate interfaces and consts as a way to mimic static and instance properties/methods.

I'll have to admit I have never seen that before, but it is def causing issues with auto complete and compiling the TS to JS

But in that case the callback def should be (event: ChatTrigger$Event, ...args: (string | unknown)[]) => void

The event is always the last parameter, not the first. The signature would have to be (...args: (string | unknown)[], event: ChatTrigger$Event) => void, but unfortunately Typescript does not support vararg parameters in the non-final position in a parameter list. Though I believe the typing generator was written before or very soon after the release of a bunch of new typing features like infer, so it's possible we could get around it now somehow.

I'll have to admit I have never seen that before, but it is def causing issues with auto complete and compiling the TS to JS

The typings shouldn't have any effect on compilation, it's only for the IDE. They've always been full of errors since the API surface is so large, and the Java type system doesn't map perfectly to Typescript.

I had noticed a little while after making that first reply, that the event was always the last argument so we can ignore that comment,
when it comes to the Java types, when attempting to compile to TypeScript to JavaScript using tsc from the npm typescript package it does cause some errors because types do not have the correct properties and thus it fails, and if attempting to load any typescript file directly with cjs causes errors because type specification is not supported.
When it comes to errors with Java types from Java.type() I believe it is acceptable to have the user manually define the type and its properties to clear any errors.
But as I showed in the initial post of this issue there are some types that were just not defined properly and did not have any properties defined, I did take the time to understand the interface and const separation that is used and I actually like it, it was just the first time I have ever seen it. I did notice several places where the interface and const were defined properly like Client for example, I would just like to see this issue fixed, so I could get proper property hints and auto-complete.

when it comes to the Java types, when attempting to compile to TypeScript to JavaScript using tsc from the npm typescript package it does cause some errors because types do not have the correct properties and thus it fails, and if attempting to load any typescript file directly with cjs there are errors because type specifiers and other small things are not supported.

Then I'm pretty sure you have it set up incorrectly, as this is the first time I'm hearing of this issue. I'd suggest asking in our discord for more help there.

But as I showed in the initial post of this issue there are some types that were just not defined properly and did not have any properties defined,

The only issue you showed in the initial post is that the event parameter of a chat trigger was not typed correctly, which I just said is not possible to fix. For cancel, you'd have to do cancel(event as CancellableEvent). Unless you have some more examples to provide, there is nothing actionable in this issue. I want to reemphasize though that the typings will never be perfect, and there will always be an error somewhere. The goal is to get them to be pretty good.

The only issue you showed in the initial post is that the event parameter of a chat trigger was not typed correctly, which I just said is not possible to fix. For cancel, you'd have to do cancel(event as CancellableEvent). Unless you have some more examples to provide, there is nothing actionable in this issue. I want to reemphasize though that the typings will never be perfect, and there will always be an error somewhere. The goal is to get them to be pretty good.

ChatTrigger$Event was not defined properly

Because my questions and concerns have been answered I will close this issue


Creating Contact Us page

@codervivek5 Can you assign this to me.

"Hi there! I'm excited to contribute to this project'GSSOC;'23 I've taken a look at the codebase and I believe I can make some valuable improvements. I'll start working on it right away. If you have any specific requirements or suggestions, please let me know. Looking forward to collaborating with you all on this!

I'm a contributor for GSSoC '23. Please, assign me an issue.

try to refer Readme file design

hey @codervivek5 can you assign this to me if nobody else is working on it?


No array access in strings

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues
-

To fix altogether cases like #18395, #18426, #9754

👍


Remove support for accessdev and revise mosrs.setup.gpg_startup

Closes #18. Closes #19. Closes #20.

Note that mosrs-setup is now intended to only run gpg-agent in interactive login shells, and not in batch jobs.
Update the README.md file to state this.

Merge. Tag in master as v0.5.0. Extensive testing is needed, especially with an updated mosrs-setup module.


Improved controls 2

current features

refactored comms.py parsing of keys
keys C and V for slight servo control

todo:

control station-side IMU neutral rotation mode
automatic transect

code is not tested yet.

will do a more comprehensive testing session later. expect one more commit

additions:

refactored comms.py parsing of keys
keys C and V for slight servo control
control station-side IMU neutral rotation mode
adds utils for later use

still todo:

automatic transect line


[DNM] west.yml: Test of mcuboot fix for boot_write_trailer

This is test PR for boot_write_trailer fix in mcuboot.
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

Test completed, mcuboot PR merged.


Enabled clicking on abacus beads to move it #146

Earlier, the user had to drag the beads, now a single click sends the beads up and double-clicking on them brings them down.

Is there any other behavior associated with a single click or a touch (long or short) on a bead beyond moving it?

According to the changes made in the PR, a single click/tap should send the bead up and double click/double tap moves it down.

On Sun, Mar 04, 2018 at 03:01:11AM -0800, Aditi Gupta wrote:

According to the changes made in the PR, a single click/tap should send the
bead up and double click/double tap moves it down.

OK. I'm just wondering why not make a single click do both?
Or rather, the only option in either direction is "move to the other
position."
So why use one for one direction and the other for the other direction?

There are a few types of abacii, (like the one shown in the gif) in which beads can move in either direction. So to differentiate that, different gestures are needed.

Thanks all for your analysis. So my first intuition is the right: we could propose an automatic move on click/tap when there is no doubt about the direction expected and let the drag gesture - since double-tap is not intuitive - when it's not possible to do the deduction.

Fixed by https://github.com/llaske/sugarizer/pull/277


Fix the CI

After pushing sigstore/cosign#745, the signing/verifying mechanism for
the created binaries was broken. This patch fixes the issue and removes
the useless duplication, making the CI workflow DRYer.

@cpanato @dlorenc sorry it looks like I broke the CI with my last PR. This one should fix it.


Update hardware docs for 3.0b

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MAR-1469, MAR-1324 Multicandidate flow

I think this is ready for a review.  Please review if you have a chance


Regenerate APIs (excluding Spanner)

These are more significant changes than normal, so need more review.

Monitoring and DLP: It's not clear where the "NoRetryRetryFilter" is coming from. It's probably worth checking that we actually want this, as removing it later would be a breaking change.

PubSub: This looks like renamed filters. Given that we're so close to GA, again I'd like this checked carefully.

Bigtable: It looks like some backoffs have been removed. This would have been a breaking change if we'd gone to GA. Mike, can you check this?

Redis.V1: Trivial change in comments

Bigtable changes caused by https://github.com/googleapis/googleapis/commit/59036b030f4a02b1eef2425d76064992b50c4d9e#diff-05c73320211201124119d8c88eb6d5d2
Original change description:
Updating timeouts for Cloud Bigtable admin to larger numbers.
CreateTable was timing out in a flaky way for a test that creates 2 clusters, and then does a create table.  See https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5928 for more context.
While I was at it, I noticed a bunch of non-idempotent methods that were incorrectly labeled, including create table.  I made a bunch of changes which ought to be considered.

The DLP NoRetryRetryFilter and HttpGetRetryFilter is odd. I don't see where these are coming from, as there's no reference to them in: https://github.com/googleapis/googleapis/blob/master/google/privacy/dlp/v2/dlp_gapic.yaml

Likewise for monitoring, there's no reference to NoRetryRetryFilter in: https://github.com/googleapis/googleapis/blob/master/google/monitoring/v3/monitoring_gapic.yaml

Yup, the lack of changes in those APIs concerned me too.
I suspect this change is responsible - we should probably consider it carefully before merging these.

Yes that is responsible. That change is due to the move to proto-annotations, away from gapic-config.yaml. This fully explains the DLP, monitoring and pubsub changes.
The way retry is specifying is changing, and HTTP GET RPC methods now need to default to an implicit idempotent retry. Java is re-using the existing gapic codegen for their proto-annotation work, hence changes like this appearing.
It looks like the extra retry code is simply being added, without regard to whether it's needed or not.
I suggest these changes are not merged until this is resolved. The BigTable and Redis changes are different, so perhaps should be split out into a different PR.

Righto, will split this into three:

Redis, which can be merged trivially
Bigtable, which is probably fine but which I'd like @evildour to look at (and decide whether we should do another beta release for)
DLP/Monitoring/PubSub

sgtm

Split done - closing this PR.


fix: ask user for the camera permission

Displays a warning to the user if they don't allow permission to the camera for the QR scanner.

 Bug: If the QR Scanner doesn't have access to the camera, there should be an error message and an ability for users to re-request.

 Bug: If the QR Scanner doesn't have access to the camera, there should be an error message and an ability for users to re-request.

@fhenrich33 once you're done with the small fixes go ahead and merge it to master. You shouldn't have any issues since it's approved.

@fhenrich33 once you're done with the small fixes go ahead and merge it to master. You shouldn't have any issues since it's approved.

@aerinsol It seems that I can't merge it:

You’re not authorized to merge this pull request.

@fhenrich33 it looks like one of the FE tests failed in Circle CI. Are you able to get it to pass? If it passes and you still can't merge tell me - I'll merge and take a look at the permissions later.

@aerinsol Managed to make the flaky frontend test pass, but now a backend test is failing 😞

Hmm, functional review blocker as tested in the field - iPhone Safari seems to not have this option to unblock in the address bar and requests permissions every time. Do we need to set a cookie of some sort to make it work.

Unfortunately the best implementation is described here: https://support.scandit.com/hc/en-us/articles/360008443011-Why-does-iOS-keep-asking-for-camera-permissions

@aerinsol Waiting for the copy for iOS. I used this as a placeholder:
const CAMERA_NOT_PERMITED_TEXT_SAFARI_IOS = "Camera access was denied. Please unblock camera access by tapping the AA icon > Website Settings > set Camera permission to \"Allow\".";

@fhenrich33 looks good, I would do:
Camera access was denied. Please allow camera access in the address bar by selecting AA > Website Settings >  Camera > "Allow"


Field "doc" must not have a selection since type "JSON" has no subfields.

So I am very new to Apollo/GraphQL in general, so please bear with me:
const GET_USERS = gql`
  query($limit: Int, $skip: Int) {
    lists(limit: $limit, skip: $skip) {
      _id
      list_id
      row_id
    }
  }
`

const SUBSCRIBE_USERS = gql`
  subscription($limit: Int, $skip: Int) {
    lists(limit: $limit, skip: $skip) {
      event
      doc {
        _id
        list_id
        row_id
      }
    }
  }
`

My :
<ReactiveQuery
  query={GET_USERS}
  variables={{limit: 20, skip: (page-1)*20}}
  subscription={SUBSCRIBE_USERS}
>
  {
    ({ loading, error, data }) => {
      if(loading) return
loading

      if(error) {
        console.log(error)
        return
Error

      }
      let { lists } = data;
      console.log(lists);
      return 'loaded'
    }
  }
</ReactiveQuery>

my typeDefs on the server look something like this:
type Query {
  lists(limit: Int, skip: Int): [List]
  list(id: Int): List
}

type List @mongo(name: "listsbody") {
  _id: ID
  list_id: ID
  row_id: Int
}

type Item @mongo(name: "items") {
  _id: ID
  created_at: String
  supplier_id: ID
}

type Subscription {
  lists(limit: Int, skip: Int): SubscriptionEvent
}

... any my Subscription resolver:
Subscription: {
  lists: {
    resolve: payload => payload,
    subscribe(_, {limit, skip}, { db }, ast) {
      const observer = db.listsbody.astToQuery(ast, {
        $options: { limit, skip }
      });
      // const observer = db.listsbody.find({}, { limit: 100 });
      return asyncIterator(observer);
    }
  }
}

After some time always the same Error pops up:
Field "doc" must not have a selection since type "JSON" has no subfields.

I guess I am missing something here I just can't see right now with my not existing GraphQL experience. 😄 Hope someone can help, thanks!

const SUBSCRIBE_USERS = gql`
  subscription($limit: Int, $skip: Int) {
    lists(limit: $limit, skip: $skip) {
      event
      doc
    }
  }
`

Use it without nested fields, just doc

Thank you @theodorDiaconu!
Now I have a new error:
TypeError: observable.observeChanges is not a function
in this line:
Subscription: {
  lists: {
    resolve: payload => payload,
    subscribe(_, {limit, skip}, { db }, ast) {
      const observer = db.listsbody.astToQuery(ast, {
        $options: { limit, skip }
      });
      return asyncIterator(observer); // THIS LINE //
    }
  }
}

@Twisterking because it's done on a mongo cursor, not a query. db.listsbody.find() is a cursor.

Okay it kinda works now.
Unfortunately the subscriptions don't update the data on the client.
I already tried this:
<ReactiveQuery
  query={GET_USERS}
  variables={{listId: "pshLYD4optX3yj9Pw", limit: 20, skip: (page-1)*20}}
  subscription={SUBSCRIBE_USERS}
  fetchPolicy='no-cache'
>

no change! 😢
One more thing: Since you said that I don't need to define any subfields in the doc in my Subscription, why do you have it like this in your Readme?

@Twisterking you'll have to create repro for me.


WIP: Add magic diagnostics and other calculations

Please rebase to dev to get correct tests on this PR.


STATS: Seaonal Amplitude analysis

We will add options to evaluate the seasonal amplitude on a station-by-station basis and for the gridded array.
@dbekaert, should we also capture phase values by (1) default, (2) by specifying a separate option, or (3) not at all. In my opinion, we either do (1) or (3) as I would aim to be conservative with options going forward where possible to not overwhelm the user. I.e. with (2) users would have to specify 4  separate flags just to plot both station-by-station and gridded plots of amplitude and phase.

@sssangha lets go with option 1.


HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622

Cherry picked #4553 to branch-3.3

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m  0s

branch-3.3 passed

+1 :green_heart:
compile
18m 51s

branch-3.3 passed

+1 :green_heart:
checkstyle
3m 18s

branch-3.3 passed

+1 :green_heart:
mvnsite
21m  1s

branch-3.3 passed

+1 :green_heart:
javadoc
7m  4s

branch-3.3 passed

+0 :ok:
spotbugs
0m 27s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
59m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 56s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
25m 42s

the patch passed

+1 :green_heart:
compile
18m 12s

the patch passed

+1 :green_heart:
javac
18m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 12s

the patch passed

+1 :green_heart:
mvnsite
20m 33s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
6m 57s

the patch passed

+0 :ok:
spotbugs
0m 25s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
60m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
773m 58s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
2m 14s

The patch does not generate ASF License warnings.

1074m 26s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean

hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.server.namenode.TestSecureNameNode

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.namenode.TestSecurityTokenEditLog

hadoop.hdfs.server.namenode.TestFileTruncate

hadoop.hdfs.server.namenode.TestFSImage

hadoop.hdfs.server.namenode.TestFsck

hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4600

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 498b721f9712 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 9d6326071acb9e4859a0be5d5bccb0bce2948ffd

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/1/testReport/

Max. process+thread count
2227 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang can you do a rebase and push this up so we can see what yetus says now?

Let's see what it says.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
14m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 22s

branch-3.3 passed

+1 :green_heart:
compile
18m 53s

branch-3.3 passed

+1 :green_heart:
checkstyle
3m 22s

branch-3.3 passed

+1 :green_heart:
mvnsite
21m 35s

branch-3.3 passed

+1 :green_heart:
javadoc
7m 12s

branch-3.3 passed

+0 :ok:
spotbugs
0m 28s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
60m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 58s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
26m 10s

the patch passed

+1 :green_heart:
compile
18m 33s

the patch passed

+1 :green_heart:
javac
18m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 11s

the patch passed

+1 :green_heart:
mvnsite
21m 10s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
7m  1s

the patch passed

+0 :ok:
spotbugs
0m 26s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
60m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
572m 32s
/patch-unit-root.txt
root in the patch failed.

+1 :green_heart:
asflicense
2m 27s

The patch does not generate ASF License warnings.

893m 45s

Reason
Tests

Failed junit tests
hadoop.mapred.TestMRTimelineEventHandling

hadoop.mapred.TestMiniMRClasspath

hadoop.yarn.client.api.impl.TestAMRMClient

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4600

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 541fee4d4af3 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 207f5df1760a0882959105b36dd5645263bb3286

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/2/testReport/

Max. process+thread count
2216 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4600/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for verifying the test for me. Merged.

No issues. You are most welcome.


Remove extra spaces from Range reflect impls

Objective
Remove extra spaces from Range reflect impls. Follow up to #5763
Solution
Remove extra spaces from Range reflect impls.

bors r+


Feat/v3 cache warmer and other tech debt cleanup

Cleans up the following tech debt:

use Box containers instead of div flex
configure root level lint:fix with concurrency
Fix pool searching to support spaces

Updates the memoizer to accept a custom cache key for a function. This way we can set a static cache key to be used by another process to get / set a memoized function. I'm using this in a new cache warmer script that will keep the GET /api/v1/mainnet/pools?count=1000&sort=volumeUSD route hydrated on an interval we define.

@kkennis @luckyOdisetti ready for review
@zmanian for vis

going to close this and reopen


Clarify in configuration.md docs if regexp allowed for scrub_fields

I'm looking at an app that contains many sensitive fields so I'd like to default to scrubbing all fields as they shouldn't be logged to a 3rd party (no offence intended Rollbar).
Its unclear from the docs (configuration.md) if the scrub_fields config accepts a regex, e.g. its not clear if this would work.
SCRUB_ALL_FIELDS_PATTERN = /.+/
Rollbar.configuration.scrub_fields += [SCRUB_ALL_FIELDS_PATTERN]

Hi @eliotsykes, thanks for reaching out.
When we filter the parameters we build a regex in this way:
sensitive_params_regexp = Regexp.new(sensitive_params.map{ |val| Regexp.escape(val.to_s).to_s }.join('|'), true)
So I'd say that regex expressions doesn't work for scrubbing parameters. We have in our roadmap improve this functionality, but I can't tell you right now when that will be ready.

Thanks for the fast response @jondeandres! Until the feature is added, is there a recommended workaround to prevent all request params from being logged to Rollbar?

Hey @eliotsykes, you could monkey patch this method in this module, https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/request_data_extractor.rb#L191-L213, so it generates a new Hash with obfuscated values.
I think we should probably make scrubbing more powerful, so thank you for open an issue :smile:

Yep - at the moment this makes it difficult to recommend Rollbar to businesses with strict PII regulations.

@eliotsykes what requirements do you have? We could try to work on this in few days.

There's many request params (100+) from many forms (and growing) that all contain PII data.
This PII data ought not to be exposed to 3rd parties (including Rollbar). Exception messages are fine as they contain no PII. Its the request params that often contain personally identifiable info (e.g. birthday, financial info, more).

aha, what features would you like to have?

scrub all params? this can be easily done
scrub by regex? this will take a little more time but it's doable

scrub all params

would be absolutely fine for right now.

:+1: Brilliant, thanks @jondeandres!

hey @eliotsykes, we hope your experience with this feature is successful. ping us if you have any problem with something.


Add PeerTube package (v3.1.0), without module

Split off of https://github.com/NixOS/nixpkgs/pull/106492 with only the pkg addition, not the module. Will open a separate MR for the module. Changed since https://github.com/NixOS/nixpkgs/pull/106492 is that I bumped version to v3.1.0.

@stevenroose error build:
><EMAIL_ADDRESS>install /build/node_modules/bcrypt
> node-pre-gyp install --fallback-to-build

sh: /build/node_modules/bcrypt/node_modules/.bin/node-pre-gyp: /usr/bin/env: bad interpreter: No such file or directory
npm ERR! code ELIFECYCLE
npm ERR! errno 126
npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 126
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/yarn_home/.npm/_logs/2021-04-13T12_30_32_587Z-debug.log

builder for '/nix/store/q9w24n8rvhwwvqd2p9ifg8s1b5rpfily-peertube-server-yarn-modules-3.1.0.drv' failed with exit code 126

Commit messages should be [pkg]: init at [version]. So, in this case: peertube: init at 3.1.0. See here: https://nixos.org/manual/nixpkgs/stable/#submitting-changes-making-patches

@stevenroose error build:
><EMAIL_ADDRESS>install /build/node_modules/bcrypt
> node-pre-gyp install --fallback-to-build

sh: /build/node_modules/bcrypt/node_modules/.bin/node-pre-gyp: /usr/bin/env: bad interpreter: No such file or directory
npm ERR! code ELIFECYCLE
npm ERR! errno 126
npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 126
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/yarn_home/.npm/_logs/2021-04-13T12_30_32_587Z-debug.log

builder for '/nix/store/q9w24n8rvhwwvqd2p9ifg8s1b5rpfily-peertube-server-yarn-modules-3.1.0.drv' failed with exit code 126

Strange, that works for me. If I change the buildInputs with nativeBuildInputs, it stops working for me..

Pushed some changes:

add nodejs export so that module can use the same version
inherit nodejs from default.nix into server.nix and client.nix
@SuperSandro2000 's comments (I don't understand the difference between buildInputs and nativeBuildInputs)
fixed commit message as per @Synthetica9 's suggestion

@stevenroose error build with sandbox true.

@stevenroose error build with sandbox true.

How do you do that? I'm trying nix-build --option build-use-sandbox true . -A peertube --verbose but that seems to work..

Used this configuration:
  imports = [
...
    <nixpkgs/nixos/modules/profiles/hardened.nix>
  ];

  nix = {
...
    useSandbox = true;

I'm just running nix-build on a non-NixOS system, so I have no idea where I would put that.. In /etc/nix/nix.conf or so?

I do have this there:
build-sandbox-paths = /bin/sh=/nix/store/ily14d68xl11cnbbkf9svwnzwsrrnzah-bash-4.4-p23/bin/bash /usr/bin/bash=/nix/store/ily14d68xl11cnbbkf9svwnzwsrrnzah-bash-4.4-p23/bin/bash /usr/bin/bzip2=/nix/store/mymkz6qhf46j6j7nanilyd15cgj5p9br-bzip2-<IP_ADDRESS>.1-bin/bin/bzip2 /usr/bin/env=/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31/bin/coreutils /usr/bin/gzip=/nix/store/rvybssv5lxm6rfdbqmkiapv91hrl5cmx-gzip-1.10/bin/gzip /usr/bin/mkdir=/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31/bin/coreutils /usr/bin/mv=/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31/bin/coreutils /usr/bin/tar=/nix/store/znsa81k72j5aaclg1crv5575n4w726fc-gnutar-1.32/bin/tar /usr/bin/tr=/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31/bin/coreutils /usr/bin/xz=/nix/store/ch63h3ysgnsyjgw0inqplfh5af2bqhxb-xz-5.2.4-bin/bin/xz

I'm just running nix-build on a non-NixOS system, so I have no idea where I would put that.. In /etc/nix/nix.conf or so?

Yes, you need to write there - useSandbox = true;
I don't know how to reproduce the error on non-NixOS system.

Thanks for the effort into packaging PeerTube.
However, I don't understand the package's complexity around yarn. It seems unnecessary to me.
I ran in the PeerTube source directory on commit e81af30 (I admit v3.1.0 seems to have a somehow broken yarn.lock file, but that could be fixed):
nix-shell -p yarn yarn2nix nodejs python3
yarn install --production
yarn2nix > yarn.nix

(Be sure to have a recent yarn2nix with https://github.com/nix-community/yarn2nix/pull/130, I think it solves the problem with http-node dependency but I didn't checked).
Then I copied yarn.nix to the nixpkgs package's directory, plus this default.nix file:
{ stdenv, lib, fetchFromGitHub, mkYarnPackage, yarn2nix-moretea }:

mkYarnPackage rec {
  pname = "peertube";
  version = "3.1.0-e81af30";

  src = fetchFromGitHub {
    owner = "Chocobozzz";
    repo = "PeerTube";
    rev = "e81af3000f1881ec5041678ae54b402b0314bd42";
    sha256 = "0cwgla4w27cbygf8rkjpr0bqgqwbb332yvla1jbhrgd86rkn47x9";
  };

  yarnNix = ./yarn.nix;
  yarnFlags = yarn2nix-moretea.defaultYarnFlags ++ [ "--production" ];
}

This builds correctly on top of your commit.
However, the package is somewhat broken: the $out/bin/peertube symlink is broken. This is probably something related to the dist phase? But I think it can be fixed without the yarn-related scaffolding.
The dependencies (youtube-dl?) can be added if needed (or maybe they should just be in the future NixOS' module $PATH).
Please tell-me if I'm wrong or if I missed something (client? dist?)

Thanks for the effort into packaging PeerTube.
However, I don't understand the package's complexity around yarn. It seems unnecessary to me.
I ran in the PeerTube source directory on commit e81af30 (I admit v3.1.0 seems to have a somehow broken yarn.lock file, but that could be fixed):
nix-shell -p yarn yarn2nix nodejs python3
yarn install --production
yarn2nix > yarn.nix

(Be sure to have a recent yarn2nix with nix-community/yarn2nix#130, I think it solves the problem with http-node dependency but I didn't checked).
Then I copied yarn.nix to the nixpkgs package's directory, plus this default.nix file:
{ stdenv, lib, fetchFromGitHub, mkYarnPackage, yarn2nix-moretea }:

mkYarnPackage rec {
  pname = "peertube";
  version = "3.1.0-e81af30";

  src = fetchFromGitHub {
    owner = "Chocobozzz";
    repo = "PeerTube";
    rev = "e81af3000f1881ec5041678ae54b402b0314bd42";
    sha256 = "0cwgla4w27cbygf8rkjpr0bqgqwbb332yvla1jbhrgd86rkn47x9";
  };

  yarnNix = ./yarn.nix;
  yarnFlags = yarn2nix-moretea.defaultYarnFlags ++ [ "--production" ];
}

This builds correctly on top of your commit.
However, the package is somewhat broken: the $out/bin/peertube symlink is broken. This is probably something related to the dist phase? But I think it can be fixed without the yarn-related scaffolding.
The dependencies (youtube-dl?) can be added if needed (or maybe they should just be in the future NixOS' module $PATH).
Please tell me if I'm wrong or if I missed something (client? dist?)

Tbh I don't understand too much about yarn. But I tried for several weeks to get this to work from scratch. There's some dependencies in the package.json that are forced to use a certain version and that didn't seem to work with yarn install --offline. The approach in this package wsa done by @immae after I struggled for multiple weeks.
There's indeed also the patch for the yarn.lock and the bcrypt special need.
Also, in your example, you don't have the server and the client dists built both.

I see. I took a look and PeerTube seems to need two (or three) steps to be installed:

yarn install
(npm install)
npm run build
Step 1 creates the node_modules directories in the root directory and the client directory.

My strategy would be to keep a single mkYarnPackage with a postInstall for the extra steps:
  pkgConfig.peertube = {
    postInstall = ''
      patchShebangs --build ../..
      npm install
      npm run build
    '';
  };

It's possible to use the Nix code generated node2nix to generate Nix files allowing to run the npm commands in a sandboxed environment. (see https://github.com/svanderburg/node2nix#using-the-nodejs-environment-in-other-nix-derivations)
Indeed, some packages needs fixes (bcrypt) and I failed at this stage…
One thing is certain: you need to test this package with sandboxing enabled, or you won't catch 100% of errors related to Yarn/NPM doing (non fixed-output) network requests.

@stevenroose https://github.com/mohe2015/nixpkgs/tree/my-add-peertube-pkg is a working version with sandboxing (though without the suggestions here). But it should be pretty simple to adjust your current code to this as I only changed one or two lines.

Version 3.2.0 released!

cc @stevenroose

How to build cli tools - https://docs.joinpeertube.org/maintain-tools?id=installation

Just a small update on this.
I tried to update this PR (on my local) and build it with version 3.4.0
However I encountered 2 errors both on the server and the client.
I posted those errors upstream, I don't think they are related to nix.
https://github.com/Chocobozzz/PeerTube/issues/4393
https://github.com/Chocobozzz/PeerTube/issues/4394

We should really close this as https://github.com/NixOS/nixpkgs/pull/119110 contains the current state and nothing happened here in the last few months


[FEATURE] Vector or box sizes of logo.png

logo.png is, as far as I can find, only offered in an odd 468x334 format. In many cases, an SVG or box-sized raster (like 128x128) is much more useful for launchers and similar software.
If you have any other formats that can be easily converted to any square multiple-of-two size, it might be beneficial to upload them to the repository, as it would allow the desktop entry from #44 to have a corresponding image in proper size. These icons can then be added (by package maintainers) to the default hicolor theme as per the freedesktop specifications. The ArchWiki has some extra information about this.
If you don't have any other formats, it could be possible to simply crop and scale the original, but this can result in quality loss.

[x] checked that this feature wasn't requested before in an issue
[x] read CONTRIBUTING.md

icons may be a good directory option to place these icons, as dnkl's foot does

If you can export as any size of SVG, it's possible to simply crop it to the desired box size. I could do this using Inkscape if you don't have any way yourself.

I've now exported it into an SVG (chosen a different aspect-ratio)

Apparently that SVG is about 230 kilobytes, which is quite absurd for something this simple. As a comparison, I made one that looks almost identical in 603 bytes.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1024 1024">
  <rect width="1024" height="1024" rx="64" ry="64"/>
  <circle cx="96" cy="96" r="32" fill="red"/>
  <circle cx="181.3" cy="96" r="32" fill="#ff0"/>
  <circle cx="266.7" cy="96" r="32" fill="#0f0"/>
  <path fill="#74e500" d="M349 256v15h12v-15h-12zm58 0v97h12v-28l9-8 25 36h15l-32-43 27-27h-14l-30 29v-56h-12zm96 0v15h12v-15h-12zm309 0v15h11v-15h-11zm-162 7v20h-18v9h18v38c0 9 2 15 6 18 3 4 9 5 18 5h14v-9h-13c-5 0-8-1-10-3s-3-6-3-11v-38h26v-9h-26v-20h-12zm-412 20 17 70h11l11-38 11 38h11l16-70h-11l-12 57-10-36h-10l-10 36-12-57h-12zm93 0v9h18v52h-23v9h58v-9h-23v-61h-30zm154 0v9h18v52h-22v9h57v-9h-23v-61h-30zm309 0v9h18v52h-23v9h57v-9h-23v-61h-29zm-81 0v44c0 9 2 16 5 21 4 5 9 7 16 7a22 22 0 0 0 21-12v10h11v-70h-11v40c0 7-2 13-5 16-2 4-7 6-12 6s-8-1-10-4c-3-3-4-8-4-14v-44h-11zm-144 30v10h32v-10h-32z"/>
  <path fill="#ac9393" d="M127 317v27q7 0 11-4 4-3 4-10 0-5-3-9-4-3-12-4zm0 55h-6v-19l-13-1-12-4v-12q6 4 13 6l12 2v-28q-12-2-19-8-6-6-6-15 0-10 7-16 6-5 18-6v-15h6v15l10 1 11 3v10l-11-4-10-2v27q13 2 20 8t7 16q0 10-8 16-7 7-19 7zm-6-67v-26q-6 1-10 4-4 4-4 9 0 6 4 9 3 3 10 4z"/>
</svg>

(It uses DejaVu Sans Mono)

Oh wow, didn't notice that huge size. The SVG you made looks awesome (more colorful than the current one). Could you maybe "cut it in half", so that there isn't that huge empty space below $ wiki-tui?

In half:

<svg xmlns="http://www.w3.org/2000/svg" width="256" height="256" viewBox="0 0 1024 1024">
	<rect width="1024" height="512" y="256" rx="64" ry="64"/>
	<circle cx="96" cy="352" r="32" fill="red"/>
	<circle cx="181.3" cy="352" r="32" fill="#ff0"/>
	<circle cx="266.7" cy="352" r="32" fill="#0f0"/>
	<path fill="#74e500" d="M349 512v15h12v-15zm58 0v97h12v-28l9-8 25 36h15l-32-43 27-27h-14l-30 29v-56zm96 0v15h12v-15zm309 0v15h11v-15zm-162 7v20h-18v9h18v38c0 9 2 15 6 18 3 4 9 5 18 5h14v-9h-13c-5 0-8-1-10-3s-3-6-3-11v-38h26v-9h-26v-20zm-412 20 17 70h11l11-38 11 38h11l16-70h-11l-12 57-10-36h-10l-10 36-12-57zm93 0v9h18v52h-23v9h58v-9h-23v-61zm154 0v9h18v52h-22v9h57v-9h-23v-61zm309 0v9h18v52h-23v9h57v-9h-23v-61zm-81 0v44c0 9 2 16 5 21 4 5 9 7 16 7a22 22 0 0 0 21-12v10h11v-70h-11v40c0 7-2 13-5 16-2 4-7 6-12 6s-8-1-10-4c-3-3-4-8-4-14v-44zm-144 30v10h32v-10z"/>
	<path fill="#ac9393" d="M127 573v27q7 0 11-4 4-3 4-10 0-5-3-9-4-3-12-4zm0 55h-6v-19l-13-1-12-4v-12q6 4 13 6l12 2v-28q-12-2-19-8-6-6-6-15 0-10 7-16 6-5 18-6v-15h6v15l10 1 11 3v10l-11-4-10-2v27q13 2 20 8t7 16q0 10-8 16-7 7-19 7zm-6-67v-26q-6 1-10 4-4 4-4 9 0 6 4 9 3 3 10 4z"/>
</svg>

Extra gap:

<svg xmlns="http://www.w3.org/2000/svg" width="256" height="256" viewBox="0 0 1024 1024">
	<rect width="1024" height="640" y="192" rx="64" ry="80"/>
	<circle cx="96" cy="288" r="32" fill="red"/>
	<circle cx="181.3" cy="288" r="32" fill="#ff0"/>
	<circle cx="266.7" cy="288" r="32" fill="#0f0"/>
	<path fill="#74e500" d="M349 448v15h12v-15zm58 0v97h12v-28l9-8 25 36h15l-32-43 27-27h-14l-30 29v-56zm96 0v15h12v-15zm309 0v15h11v-15zm-162 7v20h-18v9h18v38c0 9 2 15 6 18 3 4 9 5 18 5h14v-9h-13c-5 0-8-1-10-3s-3-6-3-11v-38h26v-9h-26v-20zm-412 20 17 70h11l11-38 11 38h11l16-70h-11l-12 57-10-36h-10l-10 36-12-57zm93 0v9h18v52h-23v9h58v-9h-23v-61zm154 0v9h18v52h-22v9h57v-9h-23v-61zm309 0v9h18v52h-23v9h57v-9h-23v-61zm-81 0v44c0 9 2 16 5 21 4 5 9 7 16 7a22 22 0 0 0 21-12v10h11v-70h-11v40c0 7-2 13-5 16-2 4-7 6-12 6s-8-1-10-4c-3-3-4-8-4-14v-44zm-144 30v10h32v-10z"/>
	<path fill="#ac9393" d="M127 509v27q7 0 11-4 4-3 4-10 0-5-3-9-4-3-12-4zm0 55h-6v-19l-13-1-12-4v-12q6 4 13 6l12 2v-28q-12-2-19-8-6-6-6-15 0-10 7-16 6-5 18-6v-15h6v15l10 1 11 3v10l-11-4-10-2v27q13 2 20 8t7 16q0 10-8 16-7 7-19 7zm-6-67v-26q-6 1-10 4-4 4-4 9 0 6 4 9 3 3 10 4z"/>
</svg>

I would say the "in half" one looks the best. Would you mind creating a pull request adding the updated icon (just replace the old logo.png and docs/assets/images/logo.png)? That way you are clearly marked in the changelog! I can then go ahead and put the logo in icons/hicolor/logo.svg.
Thank you for updating the logo! ❤


Bugfix/issue 525 d gamma cdf da

Submission Checklist

[X] Run unit tests: ./runTests.py test/unit
[X] Run cpplint: make cpplint
[X] Declare copyright holder and open-source license: see below

Summary:
Improves derivative for Gamma CDF w.r.t alpha.  See issue #525 for rationale as well as plots of errors from the original implementation, errors from the full set of implementations I tried, and the final function with its specific branches.
Intended Effect:
Make it possible to run a Gamma model with truncation (or anything else that relies on gamma_p or gamma_cdf/lcdf
How to Verify:
Look at the plots from issue #525

, run the new tests.  I added a prim test that covers the whole grid of a/z values, that's what I used to choose branches.
Side Effects:
Should have less trouble with models that use these functions.  Some of these are currently very fragile (unusable as far as I can tell).
Documentation:
Hm... I have it all on paper but I guess I need to put formulas in to the doxygen... obv. this part is not ready yet.
Reviewer Suggestions:
I had a lot of implementations I trimmed down to three for the PR so the code might be over-organized with the structs now.  Let me know if there's something simpler I should do there or with the naming.  The plots should be relatively straightforward to check too so look at those.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Krzysztof Sakrejda
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Ok, I'll change to throwing. K
On Wed, Apr 26, 2017, 1:36 PM Bob Carpenter<EMAIL_ADDRESS>wrote:

@bob-carpenter commented on this pull request.
In stan/math/prim/scal/fun/lower_reg_inc_gamma.hpp
https://github.com/stan-dev/math/pull/533#discussion_r113516154:

   return d;

 }

};

template <>
struct lower_reg_inc_gamma<1> {

 template <int ARG, typename T1, typename T2>

 static

 typename boost::math::tools::promote_args<T1, T2>::type

 grad(T1 a, T2 z, double precision = 1e-10,

                            int max_steps = 1e5) {

   typedef typename boost::math::tools::promote_args<T1, T2>::type TP;

   if (is_nan(a)) return std::numeric_limits<TP>::quiet_NaN();

   if (is_nan(z)) return std::numeric_limits<TP>::quiet_NaN();

There is a relatively clear policy: any function other than a built-in C++
library function should throw with an informative error message as soon as
it encounters an unrecoverable error. We haven't done that consistently,
but that's the policy.
We have toyed with changing the behavior of log, exp, etc., but the
problem there is that if we do that, we potentially mess up other functions
that use them and have to go back in and change the double implementations
to make them consistent with the autodiff implementations. So I originally
decided it was worth following the NaN/inf policy of the library functions
when implementing our autodiff to guarantee you always get the same value
of a function using double and var instantiations.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/533#discussion_r113516154, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfA6VxkUMo-ryDNetDiE1OUgY1lUVsNks5rz4CFgaJpZM4NH5Dw
.

If it didn't previously throw, you don't need to change behavior in this pull request.  Nice, but not necessary.

Ok, this should be good now.

This looks OK to me on the code organization and efficiency front.  I'm not going to merge in case someone wants to look at the math side of this.  But I'm OK with merging it as is if nobody else wants to look.

seems like it has some very slightly failing tests: http://d1m1s1b1.stat.columbia.edu:8080/job/Math Pull Request - Tests - Unit/611/
Should we fix those first? I am assuming the tests are now slightly wrong?

Yes, the tests should pass before merging.

Yes I'll definitely fix this, I think it's just a test file where I didn't update test values to the higher precision.

I see, I was hoping to not update the fwd algorithm for gamma_p derivatives but I think the failing test relies on it.  @bob-carpenter does this test (below) rely on the implementation in stan/math/fwd/scal/fun/gamma_p.hpp?
TEST(AgradFwdGammaP, FvarVar_FvarVar_1stDeriv) {
  using stan::math::fvar;
  using stan::math::var;

  fvar<var> x(0.5,1.0);
  fvar<var> z(1.0,1.0);
  fvar<var> a = stan::math::gamma_p(x,z);

  EXPECT_FLOAT_EQ(boost::math::gamma_p(0.5,1.0), a.val_.val());
  EXPECT_FLOAT_EQ(-0.18228334, a.d_.val());

  AVEC y = createAVEC(x.val_,z.val_);
  VEC g;
  a.val_.grad(y,g);
  EXPECT_FLOAT_EQ(-0.3898372643285106,g[0]);
  EXPECT_FLOAT_EQ(boost::math::gamma_p_derivative(0.5,1.0),g[1]);
}

I have not looked at this PR too carefully yet, but have y'all seen
http://blog.wolfram.com/2016/05/16/new-derivatives-of-the-bessel-functions-have-been-discovered-with-the-help-of-the-wolfram-language/
particularly the link at the bottom to the accumulated results "in Grid format"? Many of these may not be that amenable to numerical computation, but we should be able to check a few well-behaved values against them.
The incomplete Gamma function (which is directly related to the Gamma CDF) is
1 / a * x ^ a * 1F1(a; 1 + a; -x)

and the derivatives of 1F1 with respect to a and b are given in terms of hypergeometric functions.

@sakrejda Yes, that should call the fvar version, which should recursively call the rev version, which probably in turn calls the prim version.
You can always drop a print statement into the version you care about to verify.

@bgoodri Thanks that looks neat.  If you look at the repo for this branch on my account (sakrejda/math) you can see what all the implementations I tested were but I don't recall if I tried what you're suggesting.  I tested against a grid of values from Mathematica to identify regions and then tried to narrow down to fewer implementations.  I ended up with two covering the entire range.  We could probably do better but I don't think it's worth it.

Jenkins, retest this please.

@sakrejda, do you want me to go through and fix the cosmetic things?

I can change the cosmetic stuff, or you can if you want, but here's what I
need help with: some of the mix/fwd tests are failing and I haven't read up
about those pieces yet so I don't know is how to get reference values for
these tests.  If you can tell me which derivatives I need to get values for
in order to update the tests I can finish this (I think).  There might be
another copy of the old algorithm in the fwd version of the derivatives
(why they don't all use the same helper function I don't know) so I might
still have to fix that.  I just haven't had the focused time to do the
reading.
On Mon, May 15, 2017 at 6:00 PM Daniel Lee<EMAIL_ADDRESS>wrote:

@sakrejda https://github.com/sakrejda, do you want me to go through and
fix the cosmetic things?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/533#issuecomment-301617488, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfA6RFyVb4pBgJRyPtHrge2NXIBTe52ks5r6MsKgaJpZM4NH5Dw
.

You can see how all the mixed stuff works up to second order by
checking out the mixed fvar implementation of hessian.hpp.
We have functionals like hessian() that should be usable if you can
convert your function into a functor.  We have both finite diffs
and autodiff, which provides a full test.

Bob

On May 15, 2017, at 6:20 PM, Krzysztof Sakrejda<EMAIL_ADDRESS>wrote:
I can change the cosmetic stuff, or you can if you want, but here's what I
need help with: some of the mix/fwd tests are failing and I haven't read up
about those pieces yet so I don't know is how to get reference values for
these tests. If you can tell me which derivatives I need to get values for
in order to update the tests I can finish this (I think). There might be
another copy of the old algorithm in the fwd version of the derivatives
(why they don't all use the same helper function I don't know) so I might
still have to fix that. I just haven't had the focused time to do the
reading.
On Mon, May 15, 2017 at 6:00 PM Daniel Lee<EMAIL_ADDRESS>wrote:

@sakrejda https://github.com/sakrejda, do you want me to go through and
fix the cosmetic things?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/533#issuecomment-301617488, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfA6RFyVb4pBgJRyPtHrge2NXIBTe52ks5r6MsKgaJpZM4NH5Dw
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sakrejda --- There are finite difference implementations for first, second, and third-order derivatives.  You can see the pull request I just made for testing fvar and higher-order to see how I used them.  I learned the hard way (well, failing tests isn't that hard) that you can't finite diff NaN or infinite values.
I'm going to try to go through and update all of the function tests to just use this framework.  It's much easier than trying to write hundreds of lines of tests at different orders.

@bob-carpenter I was about to try to finish this off, does that mean that I should wait until you update the tests and then see if they are still failing?

Nope, go ahead and finish it off.  My pull request got hung up somewhere in the MCMC lib and it'll be a while before I get to the CDFs anyway.

I made the changes I could. I see changing to throwing on NaN is actually harder to do in this situation, so I left the logic the same since it's all tested. Once it passes tests, we can merge.

thanks, @sakrejda

@syclik thanks for bringing it up to develop.  It looks like maybe some of the metaprograms have changed since I wrote this (it's been sitting for a while) but the main outstanding issue is making the fwd tests work.  Bob suggested changing them over to his test framework and I haven't had the time to either do that or to look up better test values.  I'll get back to this after the standalone functions PR's for Stan and rstan go in.

@sakrejda, I made a few changes. I think we're down to having slight numerical differences.
Mind taking a quick look? Here's the test that fails now:
./runTests.py test/unit/math/mix/scal/fun/gamma_p_test.cpp

I'm getting results like:
[ RUN      ] AgradFwdGammaP.FvarVar_Double_1stDeriv
test/unit/math/mix/scal/fun/gamma_p_test.cpp:58: Failure
Value of: a.d_.val()
  Actual: -0.38983727
Expected: -0.38983709
test/unit/math/mix/scal/fun/gamma_p_test.cpp:63: Failure
Value of: g[0]
  Actual: -0.38983727
Expected: -0.38983709
[  FAILED  ] AgradFwdGammaP.FvarVar_Double_1stDeriv (1 ms)

Awesome, thanks! I get where the NaN was coming from now! As far as these numerical differences, I just need to switch this over to Bob's finite diff framework or read enough about the fwd diff to come up with new values.  For the other tests, I checked the test values, and some of them were weirdly off to begin with so that might be the case here too. Given other recent performance issues I should also re-run some performance tests before we merge this.

Whow! Looks like we can MERGE this. Amazing.

@seantalts, please unmerge.

we're still working through issues with the NaNs.

You really should have updated the PR to either say [WIP] or to not be approved, haha. Are you sure it's not fixed? @sakrejda updated the PR and the tests pass now: https://github.com/stan-dev/math/pull/533/commits/5d338de469ba5eb93a6943be31b8daef187ee6d9

I won't hold it up beyond trying to find out how the NaN's are propagating through fvar<fvar<var>>, but this is something we need to find before we let this get in. It's clearly touching a different behavior than the rest of the distributions (all of them) for third order derivatives.
We need to know why before we move on.

Yes, I am sure. The discussion made it to discourse:
http://discourse.mc-stan.org/t/is-this-an-ok-solution-to-make-this-test-pass/3354/9
The patch used to pass the tests weren't reviewed. @wds15 prematurely
stated it was good to merge.
On Tue, Feb 20, 2018 at 9:37 AM, seantalts<EMAIL_ADDRESS>wrote:

You really should have updated the PR to either say [WIP] or to not be
approved, haha. Are you sure it's not fixed? @sakrejda
https://github.com/sakrejda updated the PR and the tests pass now:
5d338de
https://github.com/stan-dev/math/commit/5d338de469ba5eb93a6943be31b8daef187ee6d9
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/533#issuecomment-366996659, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F61jiAegFTy_w4YI9juy3F71WYUgks5tWtiZgaJpZM4NH5Dw
.

Of course, I can't add a review until it's unmerged. Yay.

The PR is closed now, someone will have to open a new one. I will revert the merge commit.

Wups, sorry if I caused a premature merge here. It wasn't clear to me that there were things which still needed to be resolved.

@wds15, no worries! It was a comedy of errors.
@sakrejda, want to put up a new pull request? Don't worry about digging more into it unless you want to. I'm really going to get to the bottom of this.


Whitelist shipped gdscripts in the itchio download

We can whitelist shipped gdscripts in the game engine itch.io shop for now instead of Wasgo.

Postponed until a later date.


Speaker changes in dialogues

In French (at least), it's common do have speaker changes in dialogues introduced by an em-dash:
— Lorem ipsum dolor sit amet, consectetur adipiscing elit, dit il.
— C’est sûr !
For comparison, English does not use such dashes normally.
“Lorem ipsum dolor sit amet, consectetur adipiscing elit,” he said.
“Sure!”
(English may used em-dashes, but at the end of a quote. Anyway, that's not the point).
The tricky thing here is that the following space ought to be fixed (= not stretched or shrinked by line justification) so that subsequent dialogue lines start identically.
Of course, I need to typeset such dialogues...
I was first tempted to do it in SILE itself (as we do for other fancy Unicode character and French punctuation, etc.) but it is not completely obvious to do there (I'm pulling my hair out trying, and I don't have much hair left, lol) and it requires awaiting a release...
It would be fairly obvious to do here, intercepting —[ ]+ at the start of a paragraph (where the — is native or derives from --- in Markdown or Djot, it ends up as — anyway in the SILE AST).
The workaround is to manually enforce it, working in Djot only (attributes on anything, here a nbsp):
---\ {.fixed}Lorem ....

---\ {.fixed}Sure!

Cumbersome and annoying when copying/pasting text....
I dunno. Try harder to implement it in SILE for any input (incl. SIL), or push my already working attempt here?

Expected:

Weird, but that is the only proper way.

Turkish also uses this pattern. I believe from bookstore observation that many publishers use a thin space after it in their internal style guides while others fall victim to the same stretching problem you note here to rather unsightly effect.
Do you have branch(es) with attempts to make this work on the SILE side?

Turkish also uses this pattern.

Interesting!

Do you have branch(es) with attempts to make this work on the SILE side?

I don't know what I was thinking in those attempts, trying to do it in SILE.nodeMakers with an insane attempt at keeping tracks of paragraphs. A newer attempt at typesetter level seems better --> I'll report to SILE and push a PR there.

Interesting!

Interesting perhaps but not that surprising. Back about 100 years ago when Turkish orthography was being switched over from the (Arabic-like) RTL script to a Latin-derived script, it was a team a largely French linguists that were tasked with adapting the orthography and many (but not all) of the typography rules were invented by some folks with largely French training.
That being said, there are probably more languages out there with French influence.

Hence, issue rejected here:

The better solution made its way to SILE 0.14.15 :+1:
I just updated silex's special typesetter in silex.sile (0.4.1) with a backport of the changes.

Tested successfully with a resilient document in Djot.


Remove sdx-common logging

What? and Why?

What does this pull request change/fix? Why was it necessary? Remove sdx-common logging

Checklist

[ ] CHANGELOG.md updated? (if required) Y

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   83.27%   83.27%
=======================================
  Files           9        9
  Lines         550      550
=======================================
  Hits          458      458
  Misses         92       92

Impacted Files
Coverage Δ

app/settings.py
100% <100%> (ø)
:arrow_up:

app/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0fcee1...c3bf7c8. Read the comment docs.


docs(example): Use routes with modals example

Thanks for the review 👍 I can remove the extra stuff to make the example focused on the modal and route usage.

@arnaudambro,
Could you create a reproduction of your attempt and put it in either the discord or a github discussion? It's hard to keep track of comments on PRs and not as many people see them as well so we're limited on the number of people who can help.


Passcode Login Screen UI improvements

Login Screen/ Passcode adding screen needs improvement, things could be more centre aligned, CTA needs a better width and placement. Overall could need a whole upgrade moving forward

Have Worked on new UI for teh passcode screen
Section link
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3863-3763&t=uf5XrZROF6WSlPcr-1

Have Worked on new UI for the passcode screen - centralized the UI and also added another interactive feature to it - have described it in dev note @ben-kaufman
Section link
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3863-3763&t=uf5XrZROF6WSlPcr-1

Verified this issue on keeper app v 1.2.20(419)


Bump remaining dependencies

Pull Request Test Coverage Report for Build 87361bf6e23bdcca483bdb4b0631ec5896137b9d-PR-725

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.093%

Totals

Change from base Build 4d4ee43313ca8f3fa9c31510f2132ece0fff3108:
0.0%

Covered Lines:
1503

Relevant Lines:
1548

💛  - Coveralls


fix/camera-initialisation

closes #2

The problem was caused by the mousePosCallback ignoring the mouseDelta. The first time this callback is run (when a mouse movement is first detected) the mousePos_last should be equal to the mousePos to avoid large movement jumps when the mouseDelta is later calculated in update.


Wrong responsive with col-sm-* (missing max-width in sass-mixins)

Replicate:

open https://getbootstrap.com/docs/4.0/layout/grid/#sass-mixins with chrome
open chrome toggle device tools
choose ipad/ipad pro
search div with text .col-sm-5 .col-md-6
Issue: .col-sm-5 never affects because there is no max-width in responsive media

See https://getbootstrap.com/docs/4.0/layout/grid/#grid-options : medium breakpoint start from ≥768px.
The width in your example is 768px so the .col-md-6 wins over the .col-sm-5.

Closed per last comment.


Concurrent syncer

In this change the update/delete operations on the bundle's objects received via transport are execute concurrently.
This improves performances especially for case when bundle consists of many objects.

/approve


Require password policies configuration

Gitea version (or commit ref):
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[x ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
In sample config file app.ini.sample, I can config MIN_PASSWORD_LENGTH of security section. But password like '0123456789' still not secure. Implementation of custom password policies configuration is strongly recommended.
Screenshots

This was implemented as PASSWORD_COMPLEXITY https://docs.gitea.io/en-us/config-cheat-sheet/#security-security


Error: Google API error - [503] The service is currently unavailable.

I am getting this error when i try to write the data on the sheet. It was running fine in the last 2 days.

I have run into a few situations before where it is some very specific data in the sheet that causes weird errors. Try with another sheet and see if you can narrow it down.

Closing this for now.
@Aeyzaz - if you are still having issues, please give me some more details and reopen.


Fixes a crash when no zone is found

Issue
The pull request fixes a bug when no zone was found by the http server.
Reason for the Bug
The first_zone variable was not explicitly initialized to NULL when the server started.
The program crashes when attempting to read uninitialized memory:
for (http_zone *zone = ctx->server->first_zone; zone; zone = zone->next) {

The zones form a linked list, where the first zone (zone->next) is assigned to server->first_zone.
void http_server_add_zone(http_server_instance server, http_zone *zone, const char *prefix, http_request_handler handler, void *context)
{
  zone->next = server->first_zone;
  zone->prefix = prefix;
  zone->prefix_len = strlen(prefix);
  zone->handler = handler;
  zone->context = context;
  server->first_zone = zone;
}

When looping in the for loop, depending on the compilator, the last pointer may not be NULL. (This was my case)
Change and Improvement
The Fix
The fix involved explicitly initializing first_zone to NULL.
Best regard,

Thanks, looks great.


No value is displaying for few indices in tooltip

No value is displaying for few indices  in tooltip in Udise Report(School infrastructure)

@Inchara98 could you also provide the specific details.

What is the expected outcome?
what are the files emitted / processed in school infrastructure data source.

Invalid defect (As they emitted 1 file values are not displaying in the tooltip)


Is it possible to write datashader output to a raster file?

Hi,
I'm getting to know datashader and I'm finding it incredible, congratulations! I'm working with a large batch of spatial points (XY coordinates in a given CRS). Is it possible/relatively straightforward to write the output of an aggregation with datashader into a say GeoTIFF file that can be open in standard GIS and used to be merged with other spatial data (e.g. GeoJSON in geopandas)?
Thanks,
]d[

Thanks!  The output of a datashader aggregation is simply an XArray, so you can do anything you want with the output, if it can be done with an XAarray object.   XArray's I/O docs show how to read and write NetCDF and how to read GeoTIFF, but I don't see anything about writing to GeoTIFF. Can you use NetCDF instead?
In any case, if you make a good example of writing Datashader output and integrating it with GIS software, we'd love to include that for other Datashader users to have as a guide.

BTW, sometime this year we are scheduled to add support for slippy-map tiles, which will let you set up a tile server that you can use with any GIS system that supports Web Mercator tiles...

Possible solution.

Create the canvas with the size (per pixel) desired.
use datashader aggreate, flipud
use rasterio to create the geotiff.


is whatsapp no longer working?

01:35:39.122 [Client ERROR] Client outdated (405) connect failure (client version: 2.2332.15)
[0002]  INFO whatsapp:     QR channel result: err-client-outdated
[0004]  INFO whatsapp:     WhatsApp connection successful
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x12f41e2]
goroutine 1 [running]:
github.com/42wim/matterbridge/bridge/whatsappmulti.(*Bwhatsapp).Connect(0xc00029e600)
/root/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20230805184319-56e7bd01ca09/bridge/whatsappmulti/whatsapp.go:125 +0x602
github.com/42wim/matterbridge/gateway.(*Router).Start(0xc00017d0e0)
/root/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20230805184319-56e7bd01ca09/gateway/router.go:76 +0x345
main.main()
/root/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20230805184319-56e7bd01ca09/matterbridge.go:65 +0x39e

-> #2146

who can fix me for me? i can pay 10$
tg: darthvadertips
thanks

You can try #2148, just follow instructions on #2146 for local compilation


Configurable Search Options

It would be good to be able to set the search options at a ListView level, mainly for text fields. This could lead onto a discussion around other data types, mainly dates where I'm sure it will quickly get more complex.
Initially the option for starts with or contains would probably be enough, but the case could be made that it should do a like out of the box, unless that's considered too expensive given you don;t know the size of the data set/fields being searched.

Hey Andy, I'm happy to look into this as an option but yea, I'd generally stick to starts with as the default as like you say, not knowing the data in the db, likes are much more intesive than a starts with so I'd like to keep things as reserved as possible OOTB but allow someone to change that if they wish and if they understand the consequences.
I think the important thing to work out is what is the entry point for this. I think it would likely make sense to add an Enum to the AddSearchableProperty function so you can define per field. The tricky thing here is that functions like setting the name property auto set a searchable field so how do you change that if you want the name to be a like?
One option could be that you just set the global action so maybe introduce a new method SetSearchBehaviour or something.
These are just things off the top of my head, I'll have a more thurough think when I have some spare more spare time.


More info on data type/format

This would be more helpful if it included information on what can be returned from the R-script back into Power Query. For example, can the result of an R-script be a list, or does it have to be a data.frame? Does it have to be assigned to a particular variable (i.e. in your example it is called "output")?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4253d0e-7a9f-a0a7-edee-4cbd387ec98d
Version Independent ID: 14a7818e-43ac-86ca-a4a1-d4da38441e42
Content: Using R in Power BI Query Editor - Power BI
Content Source: powerbi-docs/desktop-r-in-query-editor.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for posting – note that we can only answer feedback related to the documentation, and can’t provide direct support or respond feature requests.
Your best venue for getting an answer or feedback on your question is from the community (https://community.powerbi.com) or from support at https://support.powerbi.com. You can also provide feedback using the Give Product Feedback button at the bottom of the article page.


[TRI-1426] : Improve the Resend integration documentation

Closes #661
✅ Checklist

[x] I have followed every step in the contributing guide
[x] The PR title follows the convention.
[x] I ran and tested the docs site and it works properly.

Testing
I locally deployed the Docs Website using Netlify and verified all the changes.
Video Snapshot
https://github.com/triggerdotdev/trigger.dev/assets/47860497/eebc64e7-20d8-4d51-9d21-5bee54c7ffd3

Changelog
The Resend Documentation has been updated such that it follows the same format as the GitHub Integration.
Resend Documentation is now divided into two sections.

Resend Overview and Authentication
Resend tasks

Screenshots
Overview and Authentication Page

Tasks Page

This PR exactly follows the GitHub Integration format.

An overview section has been added based on the official Resend Site.
Both the Overview and Tasks pages have been separated properly.
Comments have been added to all the code blocks for better understanding.

Please review and suggest changes, if any. Thanks.
cc: @D-K-P

Nice. Same feedback as SendGrid

@D-K-P I have included the changes suggested by you. Please review. Thanks.


attributes

Pull Request

Description
Write a short description of the changes made in this pull request.
What changed?
List important changes here. Changes within a file should be an indented bullet point.

#123  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 29, 8:06 AM EDT: A user merged this pull request with Graphite.


"action":"activating product key","message":"The secure connection to the activation servers failed due to a TLS or certificate error.

/usr/lib/rstudio-server/bin/license-manager activate XXXX-XXXX-XXXX-XXXX-XXXX-XXXX

{"result":57,"action":"activating product key","message":"The secure connection to the activation servers failed due to a TLS or certificate error. This is most often caused by MITM (man-in-the-middle) attempts on corporate networks or, if on Unix operating systems (macOS, Linux, BSD, etc.), it's caused by out-of-date or missing CA certificates. This means either keeping your system itself up-to-date, or manually updating the CA certs."}

deactivate

echo '== Exiting =='

rstudio-server stop

== Exiting ==
Deactivating license ...

echo 'Deactivating license ...'

/usr/lib/rstudio-server/bin/license-manager deactivate

== Done ==

echo '== Done =='

2022-06-29 15:21:08,265 INFO exited: rstudio-workbench (exit status 1; not expected)
2022-06-29 15:21:08,265 INFO exited: rstudio-workbench (exit status 1; not expected)
2022-06-29 15:21:09,266 INFO gave up: rstudio-workbench entered FATAL state, too many start retries too quickly
2022-06-29 15:21:09,266 INFO gave up: rstudio-workbench entered FATAL state, too many start retries too quickly
2022-06-29 15:21:10,268 WARN received SIGQUIT indicating exit request
2022-06-29 15:21:10,268 WARN received SIGQUIT indicating exit request
2022-06-29 15:21:10,268 INFO waiting for rstudio-launcher, sssd, process-monitor to die
2022-06-29 15:21:10,268 INFO waiting for rstudio-launcher, sssd,

Any update on this. The new images are broken

Interesting! Apologies for missing this! Which image tag are you using? Do you have an outbound proxy in play here? We will see if we can reproduce in our environment!

RStudio-workbench latest image and also we tried with pre release images.
Also we cannot log into container as it shuts down completely.
Thank you
Vamshi
On Mon, Jul 11, 2022 at 6:51 PM Cole Arendt @.***>
wrote:

Interesting! Apologies for missing this! Which image tag are you using? Do
you have an outbound proxy in play here? We will see if we can reproduce in
our environment!
—
Reply to this email directly, view it on GitHub
https://github.com/rstudio/rstudio-docker-products/issues/338#issuecomment-1181118463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAECTQFBCZRZKJTIT2G7OLVTSXOZANCNFSM52GER4UQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Closing in hopes that this was addressed through other channels. Please let us know if you are still running into trouble!


Possible race condition between Fini and PollEvent

Both cScreen and tScreen will eventually set their stopQ channels to nil in response to Fini. This update of the struct field is protected by a mutex, however the read of the field in PollEvent is not, which triggers a data race.
While the documentation for PollEvent does indicate it should be called from the main loop, it isn't clear about who is allowed to call Fini.  However from the locks, it appears that Fini is intended to be callable from anywhere, thus making the underlying data shared rather than exclusive to the main loop.
As such the data access should be protected in PollEvent as well, even if PollEvent is only allowed to be called from a specific routine.  Alternatively, Fini should be documented to only be callable from the main goroutine as well (this is an API break, however)

Fair point.  What I'll do is move the clearing of that to after waiting for the waitgroup.

PollEvent does not read from the stopQ in the tscreen implementation.  It would be an error to call PollEvent when the application is not started.  I will change Fini not to clear it, but I do need to set it during start().

(For anyone watching ... its pretty unlikely that you'll ever actually hit this as a real world bug.)

PollEvent does not read from the stopQ in the tscreen implementation.

My bad, I confused myself!
Thanks for the quick response.


feat(diagnose): add a sample left navigator for diagnose report

UCP #200
What have you changed?
Add a left navigator for diagnose report.

Add a id property for h3 HTML tag as anchor. It takes value from TableDef.Title.
Add a new template file navigator.gohtml.
Some CSS in index.gohtml

What are the type of the changes?
New feature.
How has this PR been tested?
Manually tested.
Preview:
(I will put a screen shot later.)
Does this PR affect documentation (docs/docs-cn) update?
No.
Refer to a related PR or issue link
#200

@baurine Hi, this pr makes test failure. I can not find out reason. Can you help me?

Hi @STRRL , thanks for your contribution. I restart the CI job to see what will happen, and yep, please attach the screenshot for easy review.

please attach the screenshot for easy review.

I was stuck with this issue #310 .😕
Her is my way to preview changes:

Start up tidb-dashboard like ./bin/tidb-dashboard --pd=http://<IP_ADDRESS>:32780
Login into pd then create a "diagnose report"
Copy the url and change port to 12333

After "diagnose report" generated, I can just do step 3.
I use tidb-docker-compose to bootstrap tidb cluster. And I always cleanup my environment after coding. Now I can NOT access tidb-dashboard page via pd, so I can not create new "diagnose report" anymore.
It there any other ways to generate a fake/mocked TableDef data?

please attach the screenshot for easy review.

I was stuck with this issue #310 .😕
Her is my way to preview changes:

Start up tidb-dashboard like ./bin/tidb-dashboard --pd=http://<IP_ADDRESS>:32780
Login into pd then create a "diagnose report"
Copy the url and change port to 12333

After "diagnose report" generated, I can just do step 3.
I use tidb-docker-compose to bootstrap tidb cluster. And I always cleanup my environment after coding. Now I can NOT access tidb-dashboard page via pd, so I can not create new "diagnose report" anymore.
It there any other ways to generate a fake/mocked TableDef data?

Hi @STRRL , try to use tiup according to the CONTRIBUTING.md, and start the cluster by tiup playground night --monitor, that would be easier. It will config and run the Prometheus for you as well.
After that, you can generate a diagnosis report which only include a error message, and continue  following the instruction in the error message.

@baurine Honestly, I don't like tiup. 🙈It runs every component directlly on my matel host.  "playgorund", "nightly" might means "unstable", I think tiup should make improve on isolation via container even VM. (off-topic
It is also the reason  I use tidb-docker-compose.
But I will try tiup in my VM and take a screenshot very soon.

I make a little changes on CSS, and make a new commit.


Developing SLURM submission examples for py-hypertrace {WIP}

Wimmy wam wam wozzle!
Putting together some templates/examples for running py-hypertrace through SLURM.

I will revist this once I get up to speed on the sRTM version of Hypertrace and work on asking for review then. This will support my AGU paper so I will be working on this soon.  Just wanted to give an FYI - yes this stalled out but I expect to get back to this soon.


Mental commands

Hello!
I am having some difficulties when I try to load a profile for using the mental commands.  But here I get a NullReferenceException in  if (_profileLists.Contains(profileName))...

Also I am getting only the neutral state with power 0....
Am I missing something?

The problem was that the profile was loaded, but Init was not done.... Therefore I load the profile in OnQueryProfileOK


Crash: java.lang.ArithmeticException: / by zero

Server crashes because of the com.eerussianguy.firmalife.common.blockentities.VatBlockEntity
Player says he was filling firmalife:vat using tfc:wooden_bucket with water, then it crashed.
Mod version: 1.2.13
Modpack: TerraFirmaCraft HardRock v0.3.5
Crast report: https://pastebin.com/7pci7ava

fixed


Question about cropping randomness

Hello,
Thanks for your great work. I noticed that you sampling image crops in log space along w-axis during making the dataset (dataloader.py,  line 203) . What's your motivation about this operation?
Looking forward to your reply.

Hi Haocheng,
You are right. The distribution of sampling image crops should be uniform distribution.
The current dataLoader uses log-sampling because I was working on some small experiments and I forgot to change it back (I tried to render in log-space so I need to sample in log space).
Feel free to change the sampling back to uniform distribution! I will try to update the code in the future.
Please let me know if you have any other questions.


operators [N] knative-operator (1.4.0)

Signed-off-by: Vincent Hou<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@mvalarh This operator is tested locally.
It has a minimum requirement of kubernetes 1.22 to run. That's the reason the kiwi test failed.

@houshengbo i restarted kiwi test, it was not able to pull image. Now i see that image gcr.io/knative-releases/knative.dev/operator/cmd/operator:v1.4.0 is available. Let's see now

@mvalarh This operator is tested locally. It has a minimum requirement of kubernetes 1.22 to run. That's the reason the kiwi test failed.

That might be also case, since we are running kind ks8 1.21. Let's see now

@houshengbo i updated k8s to 1.22.7

@houshengbo it passed. Please have a look at cleanup

/merge possible

/merge possible


How can query a batch vertices by using a graphAPI ?

OrientDB Version: 2.2.26
Java Version: 1.8
We use graphAPI for getting vertices. We want a one batch API, and the execution result is same as the result of  executing the  “select from Code where codeId in ("1","2") ” . The result of the SQL is two vertices of "Code". The vertex's name is "Code", and have unique index called "codeId".
We found the api like  "public Iterable getVertices(String label, String[] iKey, Object[] iValue) ",  but this function can't meet our requirements.
How can query a batch vertices by using a graphAPI ?
Thanks a lot!

Hi @KishoDai
There is no direct way to do batch queries (eg. queries with IN conditions) with a native graph API, apart from using an SQL query as follows:
graph.command(new OCommandSQL("select from Code where codeId in ('1', '2')")).execute();

Thanks
Luigi

OK. Thanks!