Catch Operation Finish

Consider this task:
const switchFileType = (str, type) => {
  // probably nicer with a regex replace..
  const pieces = str.split('.')
  pieces.pop()
  return pieces.join('.') + '.' + type
}

const throughUppercase = through(function (chunk, enc, cb) {
  cb(null, chunk.toString().toUpperCase())
})

const uppercaser = task({
  input: '*.lowercase',
  output: '*.uppercase',
  name: 'Uppercase Transform'
}, ({ input }) =>
  fs.createReadStream(input)
    .pipe(throughUppercase)
    .pipe(fs.createWriteStream(switchFileType(input, 'uppercase')))
)

The operation for this task will return a writable stream. Then dup.setWritable(operation) will apply it to the task duplexify stream. Similarly for readable.
Then in the catchTask action, the purpose is to resolve once the operation has completed. It's called "catch" because it stops the task lifecycle action pipeline until the operation is completed, so that then resolve output and validate output can be ran.
After output is successfully validated (file is not empty, etc.), I set an _output object in the duplex stream, and destroy the stream:
function finish(uid) {
  stream._output = getTask(uid).resolvedOutput
  stream.destroy()
  // TODO not this
  // 'destroy' may as well be 'breaksCompatibleWithStreamsModules'
  stream.emit('destroy')
}

On destroy() the duplex stream emits a close. Then the lifecycle of a task is something like:
uppercase()
  .on('destroy', function() {
     console.log(this._output) // object with absolute path of output
  }

and join will use that to run tasks after each other, collect all the outputs into the "output dump", etc.
However, this breaks if the operator itself throws a close event, as what happens with child processes. My solution to this was (which only switched to the emit('destroy') hack recently as I was hacking features into refactored code) was to add a function to the stream object, which could access things through a closure, and would run the output resolution and validations inside that function. On any "ending type" event - end, close, finish, you could call it. So the lifecycle for a task was:
uppercase()
  .on('close', function() {
     const output = this._output() // runs output resolution and validation now, but "outside" the task
     console.log(output)
  }

Which is better because it uses no made up events, but a little annoying because if you just do
myTask()

if will not actually run the whole task lifecycle until this._output() is called. Perhaps a taskWrapper could auto call this, and then itself emit a close.
Ideally:
someTask() // whole lifecycle contained inside here
  .on('close', // or some otherwise standard event, end, finish, etc
    function(this) {
      console.log(this._output) // prepared resolved+validated output
   })

This way task lifecycle is contained in one place without doing weird wrappers that would themselves need to emit close, and the resolved output is available immediately when a task is "done".
I saw mention of a flush function, but perhaps only for a writable stream?
Also, operations which are actually just duplex streams, like a transform, can be set as the duplex inside task and forking/parallel should work as if task is a regular duplex; so the "catch finish" need not apply since no output files need to resolved to absolute paths.

Summary and notes from chat about this:

can use prefinish event to cork and uncork writable stream just before it emits finish: so for example, catch prefinish from a writable stream, resolve and validate output, then uncork and the wrapping duplex emits finish: prefinish example

works for writable streams, but nothing like this for readable streams
could wrap readable in an outer stream, and the outer can emit a end after the child readable does and output resolution/validation is done

issues with task returning a stream object:

assumes the use will consume the stream and will handle errors on it
e..g edge case: stream won't ever emit end if it never has a buffer, so need to call .resume() to "make it alive" so that then it can emit end right after

use end not close: close is meant for errors!

ways to make sure a stream is drained:

resume() or pipe or .on('data')

instead

put stream object inside of an object returned by task:

myTask().stream.pipe(hackInnerStreamIntoWritable) (not recommended)
this way it is less likely for the user to misuses myTask()

use end-of-stream to "catchFinish"

try to avoid "foot shooting" - example, if a streaming task is joined to a non-writable:
join(streamingTask, somethingThatIsNotWritable)

done with async-done


Transform UI improvements

Support inputting the interval for date histogram grouping
Today one can only select the date histogram granularity, but cannot input interval for this granularity

Scripted metric input is not user friendly

Cannot resize the input

Cannot enter multi line scripts

If inputted invalid script, the information is lost and cannot correct the script

Pending tasks:

Update the scripted field to be more user friendly
Have a more reliable mapping for supported field types to aggregations/groupings


SkypeExport: init at 1.4.0

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This may be controversial due to the fact that I use the same case in the attribute name (and the directory name) as the author uses in the executable's name and the project's name.

Thanks for the contribution!

This may be controversial due to the fact that I use the same case in the attribute name (and the directory name) as the author uses in the executable's name and the project's name.

I would suggest changing these names to "skype-export" instead which is closer to the naming guidelines.

I would suggest changing these names to "skype-export" instead which is closer to the naming guidelines.

No, even according to the linked section the options are SkypeExport and skypeexport.

I'd prefer skypeexport for the attribute in all packages and SkypeExport for name, following the convention used for VirtualBox.

@orivej But "skypeexport" would clash with the directory name:

Names of files and directories should be in lowercase, with dashes between words — not in camel case. For instance, it should be all-packages.nix, not allPackages.nix or AllPackages.nix.

I've taken this to apply also to the package names and have attempted to clarify the naming in https://github.com/NixOS/nixpkgs/pull/31668.


Dart extension issue on vscode

i can't find dart extension in my vscode, although i have installed both dart and flutter extenion.

You must be doing something that doesn't work.
I'd consider asking in the Dart-Code repository, which is where the VS-Code plugin is developed, with some details about what you have done so far.


feat: add asinh function to math.

Adding hyperbolic sine because it's needed in https://github.com/GEOS-DEV/GEOS/pull/3280

Adding hyperbolic sine because it's needed in GEOS-DEV/GEOS#3280

I have not added half precision versions of these because I would have to implement them. I guess that they could be added if really necessary.

Adding hyperbolic sine because it's needed in GEOS-DEV/GEOS#3280

I have not added half precision versions of these because I would have to implement them. I guess that they could be added if really necessary.

Yeah I only added half precision support to testing out on the Chevron finite difference code, I don't think we have to maintain it for everything.


Update mocha to version 4.0.1

Closes #58

Coverage remained the same at 100.0% when pulling dc24661a6bdc9d823bc2d95d4e363e0e8f9626c8 on greenkeeper/mocha-4.0.1 into 402c3b4e0f24904c7901f78609ecba37b9b8d491 on master.

Coverage remained the same at 100.0% when pulling dc24661a6bdc9d823bc2d95d4e363e0e8f9626c8 on greenkeeper/mocha-4.0.1 into 402c3b4e0f24904c7901f78609ecba37b9b8d491 on master.


[5.2] Added SoftDelete Acceptance Test Functionality

I've added a trait to check that something was soft deleted in the database for better acceptance tests.
Example Usage:
<?php

use Illuminate\Foundation\Testing\SoftDeletes;

class MyControllerTest extends TestCase
{

    use SoftDeletes;

    ....

    public function test_delete_a_user_successfully()
    {
        $user = new User();
        $user->name = "Test User";
        $user->save();
        $this->seeInDatabase("users", ["name" => "Test User"]);

        $response = $this->call('delete', '/users/'.$user->id, []);
        $this->assertEquals(HTTP::OK, $response->status());
        $this->seeInDatabase("users", ["name" => "Test User"]);
        $this->seeIsSoftDeletedInDatabase("users", ["name" => "Test User");
    }

This thoroughly tests that the api endpoint is working as intended.
I just wrapped the code in a trait and submitted the pull request.  The actual code was written on SO here: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.

This is good :+1: IMO. I like the idea of having small Traits for specific testing purposes.

Going to hold off on this for now.

@taylorotwell any chance you'd reconsider this? It would be handy to be able to easily test this.

Can't you already test it by just running the query and asserting against the count returned or something?

I wound up testing it using seeInDatabase('table', ['id' => $id])->notSeeInDatabase('table', ['id' => $id, 'deleted_at' => null]) - I had only wondered if it was something that could be wrapped behind a nicer single method, as I'd have thought it's something tested often enough to warrant it.

@taylorotwell Just curious on this one... You've built in alias API methods ( for notSeeInDatabase, for instance) to make things easier. Why not include this one? It's reasonable.


vite build error, Unexpected reserved word

Describe the bug

There will be no problem in compiling the project on my personal computer, but there will be problems in the docker environment on the server. I found that the problem is that when the if judgment is entered in the server, I do not understand why the logical judgment is entered
Reproduction
no url
System Info
System:
    OS: macOS 12.5
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 50.80 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - ~/.nvm/versions/node/v18.7.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.7.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v18.7.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Safari: 15.6

Used Package Manager
npm
Logs

vue-tsc --noEmit && vite build --mode develop
file:///app/node_modules/vite/bin/vite.js:7
await import('source-map-support').then((r) => r.default.install())
^^^^^
SyntaxError: Unexpected reserved word
at Loader.moduleStrategy (internal/modules/esm/translators.js:140:18)
at async link (internal/modules/esm/module_job.js:42:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build:dev: vue-tsc --noEmit && vite build --mode develop
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I checked the relevant versions of vite and found that the await keyword was added only from 3.0.0. Before that, there was no such keyword

Why was this issue closed? This is still a problem. I check in 3.0.0 and 3.0.4.


cmd/clone: clean up the detached tree in the background

Scan and clean detached nodes more than 24 hours ago every 24 hours

Codecov Report
Patch coverage: 9.79% and project coverage change: -0.06 :warning:

Comparison is base (c14b7f0) 54.72% compared to head (1c3e662) 54.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   54.72%   54.67%   -0.06%
==========================================
  Files         147      147
  Lines       35382    35471      +89
==========================================
+ Hits        19362    19392      +30
- Misses      13913    13969      +56
- Partials     2107     2110       +3

Impacted Files
Coverage Δ

pkg/meta/base.go
64.37% <0.00%> (-0.41%)
:arrow_down:

pkg/meta/interface.go
51.42% <ø> (ø)

pkg/meta/tkv.go
69.28% <7.50%> (-0.39%)
:arrow_down:

pkg/meta/sql.go
56.75% <7.69%> (-0.47%)
:arrow_down:

pkg/meta/redis.go
65.22% <13.51%> (-0.21%)
:arrow_down:

cmd/gc.go
12.33% <33.33%> (-0.17%)
:arrow_down:

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


_convertToArray() error

Laravel 5.6
PHP 7.2.7
I copy the example(code) and then error at _convertToArray() in /vendor/paypal/rest-api-sdk-php/lib/PayPal/Common/PayPalModel.php

This seems to be a problem with php 7.2, so I guess that if this error isn't fixed the repository will be deprecated in a little amount of time.
Also, someone pasted this comment on the youtube tutorial of this repo:
How ever I'm not going to use this repo anymore. Specially since this is an issue known for more than 6 months and no fix has surfaced.

OIC. Finally, i use paypal's official API.
https://github.com/paypal/PayPal-PHP-SDK/wiki/Making-First-Call

https://github.com/systemEDOM/laravel-paypalpayment You can use this repository. This is same but i updated PayPal SDK


fix: Revamp - Resolved errors in styles.yml File

GSSOC'23 Contributor
Proposed Changes

In Previous PR #1181 about this same File, Shows Minor Issue. That's why I created Separate PR links to #1140

For Reviewers

Please Consider my Request.

Hi @narayan954 . As your Suggestions based on I created Separate PR links  with Previous PR and that's Issue. Kindly Consider my Request and Review on this PR as soon as Possible. Also add Valid Level Label under GSSOC'23. Thank You !


Support "Cell Body" for ASC files

After discussing this today, we probably want to support "Cell Body" definition format as, due to historical reasons, there are morphologies using that soma definition format and other tools are able to process them.
Example morphology:
http://neuromorpho.org/dableFiles/jonas/Source-Version/02022018_252Lgc11.ASC
available here: http://neuromorpho.org/neuron_info.jsp?neuron_name=02022018_252Lgc11)
Looks like there was a similar issue(#264) related to "Cell Body" and there was a PR to support them.

There is an attempt to implement it already in #39.


Feature/#274

Fixes / New Feature #
fixes #274
BREAKING CHANGE
Proposed Changes

Dont use CookieContainer or follow redirects by default...true is a bad default anyway imo.
Updated docs with more info around the consequences of using CookieContainer
Added tests to show behaviour with CookieContainer and without for Cookies

Coverage increased (+0.009%) to 82.072% when pulling 43f7497e21b944c7362fb895763e6af3d8fc43d0 on feature/#274 into c1b315173f5be626a8eba98c7a71eebd9e7a10d5 on develop.


./gen.py all

I needed pants 2.22.0

Oh, hmm. I think I see the problem. The template.nix file provides hashes for console-0.15.7 but since 2.21.1 it looks like the console dependency is getting pulled from the registry, so the hash isn't needed anymore.
I'm going to try to update ./gen.py to prefetch the necessary hashes

Ok I got that working in this commit. @grihabor Let me know if you want this bit in a separate PR. I am currently regenerating all of the versions using the new gen.py and will commit those on top of this PR.

Updated the tags https://github.com/grihabor/pants-nix/pull/3


Development: Unify nullability annotations

Development Hint
If IntelliJ complaints about the fact that your signatures don't provide nullability annotations despite them being there, you have to fix your settings:

Settings > Editor > Inspections
Search for Nullability and data flow problems and click on it
Scroll down on the right to Configure Annotations... and click it.
Make sure you select jakarta.annotation.Nullable for Nullable and jakarta.annotation.Nonnull for NotNull. You might have to add them if they are not on the list
Confirm

Checklist
General

[X] I chose a title conforming to the naming conventions for pull requests.

Server

[X] I strictly followed the server coding and design guidelines.

Motivation and Context

I considered it always odd that we use nullability annotations from several packages. There were times we had even more usages; then we chose one for each, positive and negative. They were replaced when Java moved from javax to jakarta, but the internal packages stayed the same.
Description

I decided to go for the shorter package name jakarta.annotation using Nullable and Nonnull. Thus, I had to replace jakarta.validation.constraints.NotNull with jakarta.annotation.Nonnull. We already use jakarta.annotation.Nullable throughout the system.
I did a simple search-and-replace for all imports and another for all annotations, so these are automated changes. I then fixed the corresponding architecture test and renamed it. Nullability is the term used by IntelliJ for these sort of annotations.
The only manual changes are in the architecture test.
Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Nice idea, but jakarta.annotation.Nonnull doesn't to runtime checks. Hence, we would have to rework some ways we validate dtos. Thus, I just close this PR. It was only meant as a quick code improvement.


[Snyk] Fix for 2 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
:sparkles: Snyk has automatically assigned this pull request, set who gets assigned.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

sendsoknad-auth/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Information Exposure SNYK-JAVA-ORGAPACHECXF-3168313
org.apache.cxf:cxf-rt-transports-http:  3.3.10 -> 3.4.10
No
No Known Exploit

808/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.3
Server-side Request Forgery (SSRF) SNYK-JAVA-ORGAPACHECXF-3168315
org.apache.cxf:cxf-rt-frontend-jaxws:  3.3.10 -> 3.4.10  org.apache.cxf:cxf-rt-transports-http:  3.3.10 -> 3.4.10  org.apache.cxf:cxf-rt-ws-security:  3.3.10 -> 3.4.10
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
👩💻 Set who automatically gets assigned
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Server-side Request Forgery (SSRF)

Fikset i main allerede.


Direct dependencies have been extended with ArchUnit 0.9.0

JavaClass.getDirectDependenciesFromSelf() now contains dependencies from field types and codeunit parameter and return types. Unfortunately I couldn't throw out the custom parameter type logic, since the DependencyType can't be derived anymore for event listeners then (wants to check for annotations on codeunit, but Dependency at the moment doesn't know anything about that).
I'm working on that part at the moment anyway, I think I'll add a Dependency.is(Predicate<JavaAccess>) method, so it's possible to get that information from Dependency afterwards (i.e. it won't lose the information anymore, that it was originally derived from an access).
I don't know if some dependencies might be duplicated now? If they are also derived from directDependenciesFromSelf. The message is probably slightly different.
Also we don't really need archunit-junit4 because that artifact just contains the extra JUnit 4 Runner to cache classes between runs. Since the infrastructure how ArchUnit is used is pretty customized anyway :wink:, the core artifact is quite fine (and doesn't transitively pull in JUnit 4).

That's merged, thanks!


[siloptimizer] Teach VariableNameInference how to look through convert_escape_to_no_escape.

This was causing us to emit old style diagnostics in TransferNonSendable in certain cases.
Just doing a walk through of the diagnostics and fixing issues while I am here sprucing up sending diagnostics.
rdar://130915737

@swift-ci smoke test


I2C Race Condition when using Arduino's TwoWire

Info
Platform: ESP32 (M5Stack Core2)
ESP-IDF: 5.1.4
Arduino ESP32: 3.0.6
Connected Hardware: BME280 Environment Sensor on GPIO pins 21 and 22 using https://github.com/adafruit/Adafruit_BME280_Library
Issue
When using M5Unified/M5GFX with another I2C device on the system I2C bus (i.e. Wire1 / I2C_NUM_1 / GPIO 21+22 on M5Stack Core2) I run into a race condition when communicating with this device on a different thread.
As far as I can tell, this is because M5.update() uses lgfx::i2c::beginTransaction(...) internally to update the touchscreen, while an Arduino Wire based library uses Wire or Wire1 but neither have any knowledge of each other's locking mechanisms.
Example
This uses the sensor mentioned above, but I assume any I2C device would encounter these issues.
#include <thread>
#include <M5Unified.hpp>
#include <Adafruit_BME280.h>
#include <Wire.h>
#include <esp_pthread.h> // stack size

Adafruit_BME280 sensor;
std::thread sensorReader;

void setup() {
    // This is only required because I can't set the stack size through ESP-IDF currently
    // and it crashes in printf otherwise
    esp_pthread_t pthreadCfg = esp_pthread_get_default_config();
    pthreadCfg.stack_size *= 4;
    esp_pthread_set_cfg(&pthreadCfg);

    auto cfg = M5.config();
    M5.begin(cfg);

    Wire1.setPins(G21, G22);
    Wire1.begin();

    sensor.begin(0x77, &Wire1);
    sensorReader = std::thread([]() {
         for (;;) {
              M5.Lcd.clear();
              M5.Lcd.setCursor(0, 0);

              // This will print garbage values like a temperature of 180°C or -144°C
              M5.Lcd.printf("Temperature: %f\nHumidity: %f\nPressure: %f",
                  sensor.readTemperature(), sensor.readHumidity(), sensor.readPressure());
         }
    });
}

void loop() {
    M5.update();
}

Workaround
I have worked around this issue for now by enclosing M5.update() like this:
// ...

void loop() {
    Wire1.beginTransmission(0x38);
    M5.update();
    Wire1.endTransmission();
}

However, there are two problems with this approach:

This comes with a bit of a performance penalty because it's now locking two mutexes and performing some extra communication.
It's not a perfect solution since I'm only protecting against concurrent access from the touchscreen, but I'm assuming the PMIC and other ICs on the same bus also bypass Wire.h.

Is there a way for M5GFX to use Arduino's Wire library through beginTransaction() / endTransaction() that I'm missing?
Alternatively, would it be possible to make https://github.com/m5stack/M5GFX/blob/ff11e09ac0bb5ec29433e81abbdc66c26488ba44/src/lgfx/v1/platforms/esp32/common.cpp#L823 public? I could then lock() and unlock() before and after any Arduino llbrary is using the I2C bus and at least address the second issue.

Hello, @wurzlphi
Thank you for your feedback.
Your concerns are valid. We are aware of that, but the Arduino TwoWire mechanism is simply difficult to use, so we have no plans to create a library that depends on it.
We are currently planning to separate and redesign the routines that handle these buses into a new library called M5HAL.
We intend to basically make it independent of Arduino.


Notgithub: a service to simulate GitHub token scanning

Note: ⚠ Please only review the last commit ! ⚠
This PR is based on #8563, and it probably makes more sense to merge that one first. If you have something to say about the commits before the last, I encourage you to do so in #8563, it's still in review :)
Because manually testing the GitHub token scanning code in my dev environment was nontrivial to say the least, I've made a service to automate the complicated parts, and here's the integration of this service to the Warehouse dev environment.

Ping @greysteil : I believe this may be of interest to you and whoever gets to integrate GitHub token scanning, see https://github.com/ewjoachim/notgithub-token-scanning

Oh nice, thanks for the ping @ewjoachim.

Thank you :)


Update README.md

Updated grammar a bit.

Thanks for your contribution! Sorry for the slow reaction time on our end. Could you please rebase your changes on top of the current master? Thanks!


Different shared secret from encaps/decaps in SIKE-pX-Compressed

The compressed versions of SIKE seem to have a probability of disagreeing on the shared secret. See discussion in https://github.com/open-quantum-safe/liboqs/issues/988 and the linked issue.
@jschanck wrote up the following reproducer in this repo's test harness:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "rng/rng.h"
#include "../src/P434/P434_compressed_api.h"

#define KAT_SUCCESS          0
#define KAT_CRYPTO_FAILURE  -4

int
main()
{
    unsigned char       seed[48] = {0x70, 0x4D, 0x49, 0xD5, 0xFF, 0x14, 0x5E, 0xF5, 0xB7, 0x90, 0x43, 0x93, 0x55, 0x38, 0xBC, 0xAC, 0x03, 0x71, 0x08, 0x17, 0x9E, 0x68, 0xBD, 0xDB, 0x47, 0x60, 0x06, 0x11, 0x9B, 0x7F, 0x3C, 0x68, 0x37, 0x29, 0xEB, 0x33, 0x97, 0x87, 0xBB, 0x93, 0x09, 0xA4, 0x48, 0x5C, 0xA4, 0xBA, 0x25, 0x38};
    unsigned char       ct[CRYPTO_CIPHERTEXTBYTES], ss[CRYPTO_BYTES], ss1[CRYPTO_BYTES];
    unsigned char       pk[CRYPTO_PUBLICKEYBYTES], sk[CRYPTO_SECRETKEYBYTES];
    int                 ret_val;

    randombytes_init(seed, NULL, 256);

    // Generate the public/private keypair
    if ( (ret_val = crypto_kem_keypair_SIKEp434_compressed(pk, sk)) != 0) {
        printf("crypto_kem_keypair returned <%d>\n", ret_val);
        return KAT_CRYPTO_FAILURE;
    }

    if ( (ret_val = crypto_kem_enc_SIKEp434_compressed(ct, ss, pk)) != 0) {
        printf("crypto_kem_enc returned <%d>\n", ret_val);
        return KAT_CRYPTO_FAILURE;
    }

    if ( (ret_val = crypto_kem_dec_SIKEp434_compressed(ss1, ct, sk)) != 0) {
        printf("crypto_kem_dec returned <%d>\n", ret_val);
        return KAT_CRYPTO_FAILURE;
    }

    if ( memcmp(ss, ss1, CRYPTO_BYTES) ) {
        printf("crypto_kem_dec returned bad 'ss' value\n");
        return KAT_CRYPTO_FAILURE;
    }

    return KAT_SUCCESS;
}

This issue might also exist in compressed versions of SIDH — I'm not sure what the expected failure rate is.
A seed that triggers differing shared secrets in SIDH-p434-compressed is 1D4195F28F6203603A329870DADAB52B2CFEB187F25B63DD8C101315BD9460066BCD4CE87557475D7C92367FC57F273A

@patricklonga, can you look into this?

Thanks for reporting this, Thom. We are indeed looking into this.

This issue was solved in a recent PR. Thanks for notifying this, @thomwiggers.


This Certificate has expired

Cert vaild from 4/28/2018 to 4/29/2019 form release page

Certificate has expired & I think the current release does not support wsl 2

There is a new test signature on the new release. The releases here originally were only intended for testing and for cases where the windows store could not be used.
There will not be a wls 2 supporting release from my side.


(googlechrome-zenhub) Added new chrome extension

I'm also getting the following errors when trying to install the extension:
2016-12-07 09:23:22,515 [ERROR] - Cannot find path 'HKLM:\SOFTWARE\Wow6432node\Google\Chrome\Extensions\ogcgkffhplmphkaahpmffcafajaocjbd\' because it does not exist.
2016-12-07 09:23:22,532 [ERROR] - Cannot find path 'HKLM:\SOFTWARE\Wow6432node\Google\Chrome\Extensions\ogcgkffhplmphkaahpmffcafajaocjbd\' because it does not exist.

@AdmiringWorm thank you very much for the review.  I think I have addressed all your feedback.

@AdmiringWorm thanks for doing the review, very much appreciate it!


Look into autopep8

https://avilpage.com/2015/05/automatically-pep8-your-python-code.html

It would be nice to have a way to auto-fix linter warnings so that it doesn't have to be done by hand

You can use autopep8 package :)


setting dots=true breaks the slider

when setting dots to true the slider doesn't load properly.
  {{#slick-slider autoplay=false arrows=true dots=true infinite=false}}

Page 1

Page 2

Page 3

Page 4

  {{/slick-slider}}

The console gives throws this error:
Uncaught TypeError: Cannot read property 'call' of null

Thanks for reporting it I noted this issue when testing for the responsive configuration and I'm working on it now. I'll let you know when it's fixed.

@4xposed it's fixed now on the latest version. Thanks!

Thanks for fixing it!


add spinner when user is logging in

Currently nothing happens when user clicks on submit button for logging in or signing up. Add a spinner until user is getting logged in/signed up.

Hello, can I take this one?

Ok go ahead
@ElyesSellami assigned

Thank you!

Can I take this issue

Can I take this issue

@ElyesSellami Any updates on your work?

Sorry mate, not yet. I've been busy this last week

Done here with other features https://github.com/harshjohar/stutea/pull/123

Nice work @evirusky, I cannot see you on the leaderboards yet. Can you fill the mentee form, form link is in website itself
Website link: https://pwoc.vercel.app/

thank you! i just did it, thank you for telling me :)


Unable to render to mp4 with RuntimeError: stack expects a non-empty TensorList

Describe the bug
Tried to render to MP4. got this error:
✅ Done loading checkpoint from outputs/lego_processed/nerfacto/2024-02-14_193442/nerfstudio_models/step-000029999.ckpt
Traceback (most recent call last):
  File "/usr/local/bin/ns-render", line 8, in <module>
    sys.exit(entrypoint())
  File "/usr/local/lib/python3.10/dist-packages/nerfstudio/scripts/render.py", line 896, in entrypoint
    tyro.cli(Commands).main()
  File "/usr/local/lib/python3.10/dist-packages/nerfstudio/scripts/render.py", line 456, in main
    camera_path = get_path_from_json(camera_path)
  File "/usr/local/lib/python3.10/dist-packages/nerfstudio/cameras/camera_paths.py", line 178, in get_path_from_json
    camera_to_worlds = torch.stack(c2ws, dim=0)
RuntimeError: stack expects a non-empty TensorList
root@3eada9a39237:/workspace# ns-render camera-path --load-config outputs/lego_processed/nerfacto/2024-02-14_193442/config.yml --camera-path-filename /workspace/lego_processed/camera_paths/2024-02-14-19-34-49.json --output-path renders/lego_processed/2024-02-14-19-34-49.mp4

To Reproduce

Download images for training. https://files.extrastatic.dev/extrastatic/Photos-001.zip. Unzip into a directory called lego
 ns-process-data images --data lego/ --output-dir lego_processed
ns-train nerfacto --data lego_processed/
When completed, try to run render command: ns-render camera-path --load-config outputs/lego_processed/nerfacto/2024-02-14_193442/config.yml --camera-path-filename /workspace/lego_processed/camera_paths/2024-02-14-19-34-49.json --output-path renders/lego_processed/2024-02-14-19-34-49.mp4

Expected behavior
It should create the mp4 file.
Additional context
Using docker:
docker build \
    --build-arg CUDA_VERSION=11.8.0 \
    --build-arg CUDA_ARCHITECTURES=86 \
    --build-arg OS_VERSION=22.04 \
    --tag nerfstudio-86:0.0.1 \
    --file Dockerfile .

Inside container nvidia-smi:
# nvidia-smi
Wed Feb 14 20:39:13 2024
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 545.29.02              Driver Version: 545.29.02    CUDA Version: 12.3     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 3090        Off | 00000000:0A:00.0 Off |                  N/A |
|  0%   41C    P8              23W / 370W |      5MiB / 24576MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|  No running processes found                                                           |
+---------------------------------------------------------------------------------------+

colmap -h
# colmap -h
COLMAP 3.8 -- Structure-from-Motion and Multi-View Stereo
              (Commit 43de802 on 2023-01-31 with CUDA)

Usage:
  colmap [command] [options]

Documentation:
  https://colmap.github.io/

Example usage:
  colmap help [ -h, --help ]
  colmap gui
  colmap gui -h [ --help ]
  colmap automatic_reconstructor -h [ --help ]
  colmap automatic_reconstructor --image_path IMAGES --workspace_path WORKSPACE
  colmap feature_extractor --image_path IMAGES --database_path DATABASE
  colmap exhaustive_matcher --database_path DATABASE
  colmap mapper --image_path IMAGES --database_path DATABASE --output_path MODEL
  ...

I've noticed that this issue also always appears to happen to me when I only have 1 keyframe trying to render a single image.
The moment I add another camera keyframe in the path, multiple images will render.
I assume it may not be exactly the same issue since you were trying to create a video (which would usually have multiple frames),
but at least this is a way to provide a minimum reproducible example that seems to always result in the error.
{
  "default_fov": 75,
  "default_transition_sec": 2,
  "keyframes": [
    {
      "matrix": [
        0.48770182459400074, -0.6865172221850452, -0.5392967957729877,
        -0.4507239373890963, -0.8727777603899364, -0.369160257136332,
        -0.31934258331729526, -0.2323788609443143, 0.020147239424029684,
        0.6264302101546237, -0.7792170946207637, -0.7966745989802786,
        0, 0, 0, 1
      ],
      "fov": 75,
      "aspect": 1.7777777777777777,
      "override_transition_enabled": false,
      "override_transition_sec": null
    }
  ],
  "camera_type": "perspective",
  "render_height": 1080,
  "render_width": 1920,
  "fps": 30,
  "seconds": 0,
  "is_cycle": false,
  "smoothness_value": 0,
  "camera_path": []
}

E.g. as we can see the camera path list is empty.
And in the code the "camera_to_world" key is supposed to be read and added to c2ws, which is later used in the line erroring.
It fails because c2ws is empty since there was no camera in the empty "camera_path".
https://github.com/nerfstudio-project/nerfstudio/blob/d1fc2ee33863071aa03c6679595d554d67246258/nerfstudio/cameras/camera_paths.py#L149-L155
https://github.com/nerfstudio-project/nerfstudio/blob/d1fc2ee33863071aa03c6679595d554d67246258/nerfstudio/cameras/camera_paths.py#L178

请问解决了吗？

meeeee  tooooooooo

me too+1

Hi, I have met the same error. Have you solved that?


Fix GitHub handle parsing and use better email address validation

This PR switches out the email address validation especially in order to support SMTPUTF8. It uses a small crate for that because it is implemented as described in the RFCs.

Thanks! I had briefly checked for a crate, but didn't find a good one with few deps. Have missed this one.


Poppler 22.10.0

Package for poppler v22.10.0
Checklist:

[x] I have confirmed that poppler-feedstock has been updated.
[x] I have bumped package.sh POPPLER_VERSION to the current build.

Issue appears to be that it can't find jbig.dll anymore.
Will investigate as soon as possible.

Thanks @oschwartz10612!

I have just been so busy lately. I will get to this soon and if not ping me again!

Looks like that was it: jbig.dll no longer needed. Sorry this took me so long!

Thanks for keeping this up to date @Fdawgs!


keyRecover "Cannot parse hextstring"

I remember having a discussion about this previously, but I don't remember what the conclusion was.
I have a private key that a Lotus node has returned to me directly: DU1DkMquULRDovTdiCSCdF9AWTYSI49fxPfrYi5SZf4=, when passing this as the argument to keyRecover I get the Cannot parse hextstring.
When I use a key that matches the example code, the call works fine.
Not sure what the best solution is here, but I vaguely remember @jleni saying this library would handle the key discrepancies?

Well yes, that is not a hexstring.. that is base64.
At the moment, we support:

hexstrings
Buffer / uint64arrays

I think we have Lotus API related issues.. we can add base64, that would not be a problem.
But given the other Lotus vs Forest compatibility issues, I think it would be good to have a draft spec for all the things you need on the plain signer.

I will rename the issue so it is easier to track


Json update not pushing

It seems when script is run, the data is not being pushed (json data changes not appearing to be applied to site)
We make changes to google spreadsheet, run https://sheets.code4recovery.org/oiaa but changes are not showing up.
Tom - March 10 - 10PM MST

hi @csrcarlson could you give an example of a specific data point thats not syncing up?
assuming this just started happening recently?

looks like the oiaa.json file was last modified at 9:56pm MT, so looks like at least some amount of data is getting fetched and saved

@csrcarlson we need more info from you to know what problems to look for, thanks

I think it was a lag. I changed a few records and they appear to be updated now. I will keep checking and see, but I think we are good now. Weird...

ok great


Has one with zero

I've got a pre-existing database that started all its 'serial' IDs at zero...so I need to allow for Zero as a valid value for FK column in hasOne().
hasValues() is only used in hasOne association, so it's probably ok to make this change.

Looks good and makes sense, however the new tests are failing in postgres :(

Fixed for postgres....better check sqllite now.

Fixed it for postgres & sqlite wonder what's wrong for redshift.

Had to do a silly commit to force Travis to re-try the build.  Seems ok now.

:+1:

Released in v2.1.29.


4.2.2 Map: The records are in a hidden tab on mobile devices.

This was implemented by @charlesroper


PyImath install override variable is useless

https://github.com/AcademySoftwareFoundation/Imath/blob/e2832ca08665ef44a737dc244e5ad73d6796e737/src/python/config/PyImathSetup.cmake#L11
It would be good to be able to customize the install directory. Currently the override is not used in the code

Indeed, these variables got overlooked when we consolidated the python building options. Hopefully, #200 provides the customization you're suggesting? Let me know if you had something else in mind.

This is hopefully resolved by #200, let us know if there are further issues.


fix(amplify-appsync-simulator): mock websocket subscriptions

Description of changes

The Amplify API client libraries example JS use web-sockets to connect to the mock subscription server. They treat the mock appsync endpoint as custom domain and hence, try to connect to the path graphql/realtime, as mentioned in Appsync docs here. The mock appsync endpoint that clients try to connect to is ws://localhost:20002/graphql/realtime.
The current mock implementation however, starts the web-socket at graphql path instead of graphql/realtime and also uses port 20003. This prevents the Amplify customers from testing their subscriptions via Amplify client libraries and the mock plugin. Also note that the mock GraphiQL interface does not support running subscriptions directly from the dashboard.
With this change, we update the mock web-socket server to run on the endpoint that the Amplify clients expect from a custom appsync domain. We also remove support for legacy MQTT subscription server which runs on and hence blocked the port 20002.
Issue #, if available

https://github.com/aws-amplify/amplify-category-api/issues/122
Description of how you validated changes
Tested using React JS sample app that we are able to subscribe and get mutation events.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10870 (e446cdf) into dev (9100adf) will increase coverage by 0.29%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##              dev   #10870      +/-   ##
==========================================
+ Coverage   47.43%   47.72%   +0.29%
==========================================
  Files         673      666       -7
  Lines       33274    32741     -533
  Branches     6724     6622     -102
==========================================
- Hits        15782    15626     -156
+ Misses      15803    15467     -336
+ Partials     1689     1648      -41

Impacted Files
Coverage Δ

packages/amplify-util-mock/src/api/api.ts
0.00% <0.00%> (ø)

...amplify-appsync-simulator/src/server/operations.ts
80.00% <66.66%> (+1.05%)
:arrow_up:

...ages/amplify-appsync-simulator/src/server/index.ts
93.10% <100.00%> (-0.84%)
:arrow_down:

...src/server/subscription/websocket-server/server.ts
96.29% <100.00%> (+0.02%)
:arrow_up:

...ync-simulator/src/server/websocket-subscription.ts
96.42% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phani-srikar looks like this needs a rebase


[SPARK-4908][SQL][hotfix]narrow the scope of synchronized for PR 3834

compared with  https://github.com/apache/spark/pull/3834,  this PR narrow the scope of synchronized

Can one of the admins verify this patch?

ok to test

This LGTM, thanks!

Test build #25403 has started for   PR 4001 at commit 4bfa306.

This patch merges cleanly.

Test build #25403 has finished for   PR 4001 at commit 4bfa306.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25403/
Test PASSed.

But why this PR is marked as "hotfix"? Does it break anything?

Yeah, generally hot fixes are reserved for things like "the build is broken and we need to fix it now"

Hi @liancheng and @marmbrus I had remove [hotfix] from the title.

Indeed, the code passed all the test when I do test locally,  I had [hotfix] to title just because i want illustrate that this is not the final solution of [SPARK-4908]

Hi @marmbrus ,can this PR be merged? :)

Do we know that HiveShim.getCommandProcessor( and stuff are threadsafe?  Since we only use this for DDL operations and not actually querying this seems more risky than worthwhile to me.  Thoughts?

HiveShim.getCommandProcess delegates to methods defined in CommandProcessorFactory, which tries to find a cached Driver object and initialize it. The underlying Driver cache map is synchronized. However, I'm not quite sure whether Driver is thread-safe. Also, HiveServer2 actually creates a new Driver instance for every SQL statement and never caches them. Considering all the above, I'd agree that the risks is greater than the benefits. A better solution for this is to avoid using HiveShim.getCommandProcess (which caches Driver objects) but mimicing what HiveServer2 does and create new Driver instances for every SQL statement.

@baishuo Would you mind closing this PR? The Driver.plan field is not properly synchronized; otherwise we wouldn't need the synchronization at all. And other parts of Driver are not obviously thread-safe. Considering DDL operations is infrequent, synchronize the whole function is both safe and performance insensitive.

no problem,clolse it :)


Update sbt-sonatype to 3.11.2

This sbt-sonatype version removes zio dependancy from the sonatype central support implementation

Let's do 1.6.0 release if no one objects?

Done - https://github.com/sbt/sbt-ci-release/releases/tag/v1.6.0

Thanks!

👏


Make it so you can't play against yourself

Currently you can login and play against yourself on different tabs and that would change your score

currently in progress in #21


no module found error

Using a clean Pi4 install and making the lib path change noted in the other open issue, results in the following error
Using 7.5 inch epaper red/black screen
Traceback (most recent call last):
File "/home/hornett/e_paper_weather_display/weather.py", line 14, in
from waveshare_epd import epd7in5_V2
ModuleNotFoundError: No module named 'waveshare_epd'

This is strange - I'm seeing the same thing now - not using the red/black screen. Made the change with the path and everything.

Thank you for flagging. I'll see if I can find some time to take a look into it soon. If you happen to find a solution, please do let me know, and I'll adjust. I can't make promises on when I'll be able to take a look myself.

tried it with the b&w V2 7.5 inch waveshare...same error.

Fixed it. I ran the code through Claude.ai, and it told me to take out the second instance of epd = epd7in5_V2.EPD(). I took out line 17 and it works just fine (after I subscribed to the openweather onecall plan)

doesnt' seem to have fixed it for mine, still the same issue, wondering if i have a path problem for the waveshare_epd dir... seems to be correctly referenced, but how can i check for sure?


[CU-9phw06] DaskCluster: start workers in parallel

Task linked: CU-9phw06 start initial dask workers when we start the scheduler?

Is it possible to just contribute this directly to dask-kubernetes, or is there something very Saturn-specific about what we're doing?

Well, if we figure out a way to reuse the env var there instead of setting our own, then yeah we could push it out to dask-kubernetes (after it's been tested by us and merged for a while without any big issue).

Is it possible to just contribute this directly to dask-kubernetes, or is there something very Saturn-specific about what we're doing?

Well, if we figure out a way to reuse the env var there instead of setting our own, then yeah we could push it out to dask-kubernetes (after it's been tested by us and merged for a while without any big issue).

ok, got it. I want to hear if @jsignell has any ideas for alternatives to this issue you faced: https://github.com/saturncloud/images/pull/58#discussion_r480208762. My biggest concern with this PR is that it's exposing our application to a lot more of the dask-kubernetes API than the current state, which means there is a greater risk of this breaking as dask-kubernetes evolves. Maybe it's unavoidable and we have to do that...I think @jsignell will know better than me

I agree that we are taking on a lot more of dask-kubernetes, but we already do a fair amount of that in dask-saturn so I'm not too worried about it. If we find that it works well, we can suggest a PR upstream to start dask workers at the same time as the scheduler.

alright, sounds good to me. Thanks


updated class on download button and added some custom css

Changed down-link class to transparent on hover and added custom css to maintain its position removed down-link class from download button because it's not required anymore

Issue:#699

Great work thank you!
@all-contributors please add @harjotscs for code


Model Data in Power BI Desktop, Part 1

"Part 1" should be removed from the lab name, as there is no Part 2. It seems to be a copy & paste issue from DA-100, which did have 2 lab parts.

Thank you, we will update this on Friday.

Update has been made.


Check if formio is defined before use submission

ngOnChange is triggered before this.formio is defined, so an error occurs for the use of this.formio.submission

This will be done in a different way for next push.


Modal Window Not Always Centered on Page

Hi All,
I setup Reveal to pop-up a class registration form here on a Wordpress powered site:
http://aplaceforsustainableliving.org/learn/classes-workshops-2/
Try clicking on the "Register" button under the featured workshop.
I setup the page so that the "reveal-modal" class div is inserted before the closing body tag.
Nevertheless, for some reason, when the I click on the "Register" button for the featured workshop, the div doesn't always appear centered on the page. Sometimes it will get cut-off at the top of the page, perhaps 1/3rd of the time when the modal pop-up is called.
Could someone recommend a solution?  Any insight would be appreciated.
Best,
Tak

The default animation behavior is not ideal.  Most people are not passing in custom animation to their reveal settings.
I had this same issue and there are lots of posts about it.  If zurb, just would setup the default animation to
$(document).foundation({
            reveal : {
                animation: null
            }
        });

This will solve a ton of headache on the users part.  Can someone set this up?
Why is this code so important? @ridiculous @mrsweaters @javiercejudo @thedeerchild @jonathanmelville.  I realize it helps with some specific case, but it breaks a basic use case by not centering things properly with this extra top calculations.
https://github.com/zurb/foundation/blob/master/js/foundation/foundation.reveal.js#L324-L355
It seems like you guys put this into the latest releases in the past two months to accommodate this sitaution, but it would be better suited if the default reveal animates nothing so the popup remains a fixed position and scrolls along with the document.
In my tests, if my anchor which reveals the popup moves up and down, it messes up the top positioning of the modal window because of those blocks of code that these 5 authors have whipped up the past few months.
I have a pull request for this:
https://github.com/zurb/foundation/pull/6415
Please merge after the zurb team discusses.


Change the default for db-writer-connection-concurrency

Based on benchmarks having it set to 1 performs much better so let's have it as a default.
Also rewording a description for the given flag to make it more clear what it does.

Can you provide some quantitive assessment for the difference? What does 'performs much better' mean in numbers? Do we understand why it performs much better?

Setting this to 1 makes around 20% improvement in the ingest performance. It seems that the lock contention becomes just too high (due to a lot of parallel writers)  and damages the ingest performance.

If setting this to 1 is best performance-wise, I wonder what would be the case for setting this to higher values?

This configuration is tightly couple with the number of CPUs you have available. It might be that current setting is more optimal for low cpu env (eg 1 cpu). However on higher number of CPUs ( I was mostly testing >8 cpus) this turned to be too aggressive. I don't have any numbers for 1CPU env mostly because I think most people use more resources. In general ingest is usually i/o bound so increasing number of parallel writers can only help to certain degree. Thinking again, maybe setting this to 2 would be a better balance for low CPU envs.

I quick run some benchmark for 4CPU and I got just a slightly better ingest with setting db-writer-connection-concurrency to 1 compared to 2.

Just to clarify, I am not against this change. I would only like to know in what situations users would need to change this setting and document it.

Additionally, if that setting is tied to the number of CPU cores available, we may want to include some mechanism in the helm chart to automatically set this to a different value based on pod resource requests. (implementation of this can be done in a follow-up issue by someone else)


Q

Q is the sum of the VMT in a spatial and temporal region divided by the sum of the VHT in the same region. For a single location its interpretation is the average speed. But this value can be computed across many different links.
Q is computed at the 5-minute level for each loop detector location as well as aggregated across all lanes. The measures Q and TTI are just ratios of the base performance measures of VMT and VHT.

Closing, fixed by #164


@conda-forge-admin, please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/types-awscrt-feedstock#3.


Updating Particle Physics constants - Issue #78

Checked consistency of CCL constants with other software being used and outside sources. Msun was updated to be consistent with GSL and rho_crit was changed to be derived from GNEWT.

I got swig running and regenerated the wrapper.
Checks are now passing.

hi @matthewkirby. C tests pass but I had a problem with the python test. When I run run_tests.py, I got an error: "cannot import SOLAR_MASS". I'm not sure where this is coming from, but it might be that we are missing "include gsl" somewhere linked by the python wrapper and this could be why the constant cannot be found.
@tmcclintock: There is no Sigma_CRIT in CCL yet.

@matthewkirby Have you checked on the issue mentioned above with the "SOLAR_MASS" parameter?

@elisachisari I took a quick look but I was unable to reproduce the error.

I'm still having this problem though. Can you try installing from scratch? I.e., go to the CCL directory and then remove the "build/" directory. Then re-install CCL and its python version (run the python install command twice in a row).

Alright, I am now able to get the error. I will play around with this and get it working.

@matthewkirby: @damonge fixed the problem with the python installation. The checks now pass both in C and python. Before we merge this, could you edit the CCL note indicating which constants we are using and why. I remember you had a table with relative differences which was very useful, which I think should go into a new section of the note. You can edit directly in this branch.

It'd also be good to merge master into this branch to check that the new setup.py also works here

Sorry for all of commits that got displayed again. I wanted to verify that my changes still worked with master so I

Pulled master
Rebased PPconstants with master
Rebuilt and ran the C and python tests (they all passed)
Pulled PPconstants, then pushed PPconstants and it put all of those commits there

Was this not the correct process?
As for the note, I will take care of that this afternoon. Sorry again fro the delays.

Thanks @matthewkirby. Usually we merge master onto the branch instead of rebasing. One can adopt different options really: https://www.atlassian.com/git/tutorials/merging-vs-rebasing But our policy has been to do git merge master to bring the branch up to date with master and fix any conflicts before the final merge with master. It seems your option worked too, although the commit history is a bit strange (https://github.com/LSSTDESC/CCL/pull/241/commits, some commits appear twice in the history?). On the other hand, there don't seem to be any conflicts and the tests pass.

@matthewkirby @elisachisari I see that there are conflicts here, but they are on SWIG files. I am not familiar with how swig works at all, but I believe they can just be rebuilt. Is this true, Elisa?

@philbull @damonge I'm having some problems merging with master. After git merge master, I ran swig to update the files in conflict and it gives me an error like this:
pyccl/ccl_constants.i:17: Error: Unable to find 'gsl/gsl_const_mksa.h'
I committed the merge but the python implementation is currently not working. Would one of you be willing to take a look at this?

@elisachisari : alright, you need to include -I<path_to_gsl> inside the swig command if GSL is in a non-standard path. I'll add a note to this in CONTRIBUTE.md
I've checked after doing this everything works for me


Add TransactionRegister Functions to Rebucket With New Global Params

#1230  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tholonious and the rest of your teammates on  Graphite


CI for AdGem Unity SDK package

We want to setup basic CI/CD pipeline for this repo allowing us to do the following:

Automatically check for updates to Unity SDK dependencies. Ideally, whenever a new AdGem Android/iOS SDK is released we want to create a corresponding PR to Unity SDK which bumps its version in the config file (see External Dependency Manager for extra context)
Generating new releases during the release process (need to add a semantic release configuration file .releaserc)
Pull requests title linting

We've got semantic releases and pull request linting working, mostly. There is more work needed to get the exact file structure like how that first release is.
Your first ask is still a work in progress 🫡

@tustanivsky I've got a GitHub Action implemented now for updating the Android Dependencies Manifest file. It hasn't gone all the way through yet, but I'll keep an eye on it.
If this is satisfactory, feel free to close this issue.
Do you want something similar done for the iOS dependencies? Which file is that, do you know?

Do you want something similar done for the iOS dependencies? Which file is that, do you know?

@dakotawashok Yes, I've created a small PR that explicitly sets the iOS dependency version in the same file so we can track the corresponding updates, too - #8.


Adding turbo-rails helpers ?

Hi everyone,
as I just started a new rails / trurbo / phlox app, I was wondering if it will be relevant to open a PR to add latest turbo-rails meta helpers :
turbo_refreshes_with(method: :replace, scroll: :reset)

Yes please! If you’d like to PR this, you should be able to copy one of the existing turbo helpers. Check out helpers.rb.


Catch stdin errors of pscide

I debugged a bit and I think it's errors on stdin occurring if another process is using purs ide, too. It looks like simply catching this case, is solving the issue, because the error won't kill the process anymore. It's working afterwards.
I could reproduce it solving the issue #155 and also that the issue will come back with the current version.
Solves #155

I think this makes sense; however, should it be a debug or perhaps verbose debug message instead of using console.log? Or maybe it should push on to the stderr variable, similar to:
https://github.com/ethul/purs-loader/blob/fe23d01577af497cd69ac18046490098b5c443b5/src/ide.js#L53
Does the code get to the close event in this case to reach the reject call?

Thanks for digging into this.

I changed it to push to stderr. I think what actually solves the issue is only catching the missing cases. Still looks good to me.

Looks great, much appreciated! I will get a release out soon.

Don't wont to hurry, but is the release coming in the near future? ;)

Apologies for the delay, done! (Version 3.7.2)


Implementing Open Fire

Looks like the implementation file is in the wrong place, it should go under SOR_01/events/

Ah apologies, I was going through and auto-updating PRs after the last merge and hit yours by mistake, looks like you're still doing changes.
Also please do reach out in the discord server so we can add you to the contributor channels (if you're not in there already)

Should be good now. Sorry the card was in the wrong place because I copied it over to the forked repo in the wrong location. Now i'm all set up to work off the forked branch


Handle low disk space scenarios by resorting to unsafe write/rename

Since the safe operations take double the size of the target file as extra space, if there is no enough space, they fail with No space left on device (os error 28).
In those situations when a copy or write operation fails with no space error, we take a shortcut and resort to the unsafe counter parts of those operations.
Closes #120

lgtm


Failing to Load Unity Project File

Environment data
dotnet --info output:
.NET Command Line Tools (2.0.2)

Product Information:
 Version:            2.0.2
 Commit SHA-1 hash:  a04b4bf512

Runtime Environment:
 OS Name:     linuxmint
 OS Version:  18.1
 OS Platform: Linux
 RID:         linuxmint.18.1-x64
 Base Path:   /usr/share/dotnet/sdk/2.0.2/

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0
  Build    : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

VS Code version:
Version 1.17.2
Commit b813d12980308015bcd2b3a2f6efa5c810c33ba5
Date 2017-10-16T13:57:00.652Z
Shell 1.7.7
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Mono Version
Mono JIT compiler version <IP_ADDRESS> (tarball Fri Oct 13 21:51:45 UTC 2017)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       altstack
        Notifications: epoll
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug
        LLVM:          supported, not enabled.
        GC:            sgen (concurrent by default)

C# Extension version:
1.13.0

Unity Version (download at http://beta.unity3d.com/download/ee86734cf592/unity-editor_amd64-2017.2.0f3.deb):
2017.2.0f3 Personal

Steps to reproduce

Create a Unity 2D project
Set code to be External Script Editor

Go to Edit > Preferences.

Go to External Tools tab and change the External Script Editor using the Browse... option

Select /usr/bin/code/

Back in Unity, create a C# script asset
Double click on script

Expected  behavior
C# Intellisense to work.
Actual behavior
C# Intellisense doesn't work. Here is my OmniSharp Log output:
Starting OmniSharp server at 11/8/2017, 12:45:30 PM
    Target: /home/dhicks/Dropbox/unity_class/Text101/Text101.sln

OmniSharp server started wth Mono
    Path: /home/dhicks/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/OmniSharp.exe
    PID: 20320

[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 15.0 - "/usr/lib/mono/msbuild/15.0/bin"
            2: StandAlone 15.0 - "/home/dhicks/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/msbuild/15.0/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 15.0 - "/usr/lib/mono/msbuild/15.0/bin"
            CscToolPath = /home/dhicks/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/msbuild/15.0/Bin/Roslyn
            CscToolExe = csc.exe
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/dhicks/Dropbox/unity_class/Text101'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Initializing in /home/dhicks/Dropbox/unity_class/Text101
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Auto package restore: False
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Update workspace context
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Resolving projects references
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Detecting projects in '/home/dhicks/Dropbox/unity_class/Text101/Text101.sln'.
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Loading project: /home/dhicks/Dropbox/unity_class/Text101/Assembly-CSharp.csproj
[warn]: OmniSharp.MSBuild.MSBuildProjectSystem
        Failed to load project file '/home/dhicks/Dropbox/unity_class/Text101/Assembly-CSharp.csproj'.
/home/dhicks/Dropbox/unity_class/Text101/Assembly-CSharp.csproj(1,1)
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
  at OmniSharp.MSBuild.MSBuildProjectSystem.LoadProject (System.String projectFilePath) [0x00038] in <b33b7bcd685c4ae4bb5069e4d26c1bf0>:0

[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/home/dhicks/Dropbox/unity_class/Text101'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.Stdio.Program
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.Stdio.Program
        Configuration finished.
[info]: OmniSharp.Stdio.Program
        Omnisharp server running using Stdio at location '/home/dhicks/Dropbox/unity_class/Text101' on host 20231.

What I have tried.

Updating to the latest version of Mono (http://www.mono-project.com/download/)
Updateing to the latest version of dotnet (https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.0.2-sdk-download.md)
Loading the .csproj file outside of Unity.
Using the VSCode asset in Unity
Disabling and Enabling the C# plugin in vscode.

Thanks for all of the detail. I'm creating a VM right now to take a look.

@DustinCampbell Great! I honestly think it has something to do with the .sln or the .csproj files that Unity generates, but I can't be sure.

One thing to quickly check -- could you list the contents of /home/dhicks/.vscode/extensions and let me know if there are multiple ms-vscode.csharp versions or just a single one.

$ ls ~/.vscode/extensions | grep csharp
ms-vscode.csharp-1.13.0

Thanks I've seen situations where old extension versions where left behind and loaded incorrectly by VS Code.

Another thing to check: does the file, /usr/lib/mono/msbuild/15.0/bin/Microsoft.Build.dll exist?

Also, which mono package did you install? mono-devel?

$ ls -a /usr/bin/mono/msbuild/15.0/bin
.  ..  Roslyn

Microsoft.Build.dll doesn't exists :/ I installed both mono-devel and mono-complete. Here is the output of the Roslyn folder:
$ ls -a /usr/bin/mono/msbuild/15.0/bin/Roslyn
.               csi.rsp                                      Microsoft.CodeAnalysis.dll            System.Collections.Immutable.dll
..              Microsoft.Build.Tasks.CodeAnalysis.dll       Microsoft.CodeAnalysis.Scripting.dll  System.Reflection.Metadata.dll
csi.exe         Microsoft.CodeAnalysis.CSharp.dll            Microsoft.CSharp.Core.targets         VBCSCompiler.exe
csi.exe.config  Microsoft.CodeAnalysis.CSharp.Scripting.dll  Microsoft.VisualBasic.Core.targets    VBCSCompiler.exe.config

Hmmm... it seems that Microsoft.Build.dll simply doesn't exist. That's very strange if you installed both  mono-devel and mono-complete. However, that would also explain the problem. I would also assume that running msbuild at the command-line would fail.
I believe there's a separate msbuild package for Debian environments that Mono provides. I would have expected it to be installed with the mono packages you installed, but maybe there's an issue. Try installing msbuild via apt-get.

It is super weird, I agree. No idea what happened. Okay, I ran sudo apt install msbuild.

Here is my folder now:
$ ls -a /usr/bin/mono/msbuild/15.0/bin
.                                        Microsoft.Common.overridetasks                 Microsoft.WinFx.targets
..                                        A+

You can definitely close the issue. Thanks, @DustinCampbell, you're the best.

Great! Thanks for the heads up. I'm going to file an issue over in omnisharp-roslyn to make sure we fix this appropriately.

I filed https://github.com/OmniSharp/omnisharp-roslyn/issues/1011 to improve OmniSharp when the msbuild package is not installed.


feat: Add absolute paths for routers using base

This PR is linked to issue #152.

Adds support for 'absolute' paths: paths starting with the token ~ are always handled as absolute paths, even inside a Router using base
Links correctly set the href attribute accordingly
useLocation returns location accordingly, thus making matcher work without any changes needed
Added tests for Route, Redirect, useLocation and Link

Taking the following sample:
<Router base="/app">
  <Link href="/relative">Relative Link</Link>
  <Link href="~/absolute">Absolute Link</Link>
</Router>

The first Link will point to /app/relative, while the second points to /absolute
Taking the following sample:
<Router base="/app">
  <Switch>
    <Route path="/subpage">Subpage</Route>
    <Route path="/">
	  <Redirect to="/subpage" />
    </Route>
  </Switch>
</Router>

Redirect will match /app and redirect to /app/subpage. It will not match / which will be reported as ~/ inside the Router.

All looks great, I've merged into the master branch. The further steps are:

Working on some CodeSandbox examples to illustrate the multiple sub-apps use case and global routing.
Preparing for the release

Awesome, thanks!
I can put together one or two CodeSandbox examples if you want. I was thinking something along the line of:
MyAppOne / MyAppTwo with two subpages each, with MyAppOne having a link to a subpage of MyAppTwo, and vice-versa.

@molefrog
Here is a first go I had with a sandbox:
https://codesandbox.io/embed/wouter-absolute-paths-ccovi

@jvdsande I've just published 2.7.0-alpha.1, could you try to install this version in your project and check if it resolves the issue?


Is there a support for roberta models for text classification?

Yes, if you use the Transformer API in ktrain:  see this blog post and this tutorial.  Another ktrain user just recently applied Roberta to a biomedial NLP problem.


Modify the code such that you can still get representation of events like the Dunkelflaute after the scaling

What and Why
The current implementation matches the capacity factor to the target, but that means that weather events like the Dunkelflaute are softened during the process.
Possible Drawbacks
More complexity in the code
Related Issues
No response

@gnawin @nope82, please add more details if needed.


test issue

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

Run '...'
See error

Expected behavior

A clear and concise description of what you expected to happen.

Details (please complete the following information):

Have you tested on the latest Flank snapshot?
Post the output of  flank --version.

Additional context

Add any other context about the problem here.

Adding a comment


failed to connect to socket 'tcp:21784' when using VPN to communicate

-Scenario：
Device(USB) --> Pc A --> VPN <---> VPN --> Server --> scrcpy
What I'm trying to do is to let the Server use scrcpy to control the device which has connected to Pc A through VPN
(PC A and Server both are using vpn)
Step/ Configuration I've done:
Pc A
- adb kill-server
- adb -a -P 5037 nodaemon server start

Server
- adb kill-server
- ssh -CN -L5037:localhost:5037 -L27184:localhost:27184 user@Pc A's VPN IP address
- **Another Terminal**
-scrcpy -p 27184 --force-adb-forward -Vdebug

-Output from server scrcpy
scrcpy 2.0 <https://github.com/Genymobile/scrcpy>
DEBUG: ADB device found:
DEBUG:     -->   (usb)           R38MC037W7X            device  SM_G970U1
DEBUG: Device serial: R38MC037W7X
DEBUG: Using server (portable): C:\Users\pgm.vm02\Desktop\scrcpy\scrcpy-server
C:\Users\pgm.vm02\Desktop\scrcpy\scrcpy-server: 1 file pushed, 0 skipped. 79.8 MB/s (52867 bytes in 0.001s)
DEBUG: Remaining connection attempts: 100
DEBUG: Remaining connection attempts: 99
[server] INFO: Device: samsung SM-G970U1 (Android 12)
DEBUG: Remaining connection attempts: 98
...
DEBUG: Remaining connection attempts: 1
DEBUG: Server disconnected
DEBUG: Server terminated
ERROR: Server connection failed

-Output from PC A terminal
adb E 05-12 15:19:23 27260 26172 services.cpp:83] failed to connect to socket 'tcp:21784': cannot connect to <IP_ADDRESS>:21784: No connection could be made because the target machine actively refused it. (10061)
adb E 05-12 15:20:07 27260 26172 services.cpp:83] failed to connect to socket 'tcp:21784': cannot connect to <IP_ADDRESS>:21784: No connection could be made because the target machine actively refused it. (10061)
adb E 05-12 15:20:09 27260 26172 services.cpp:83] failed to connect to socket 'tcp:21784': cannot connect to <IP_ADDRESS>:21784: No connection could be made because the target machine actively refused it. (10061)

And another way I tried without ssh tunnel is:
>scrcpy --tunnel-host=172.xx.xx.xx --no-audio -Vdebug
scrcpy 2.0 <https://github.com/Genymobile/scrcpy>
INFO: Tunnel host/port is set, --force-adb-forward automatically enabled.
DEBUG: ADB device found:
DEBUG:     -->   (usb)           R38MC037W7X            device  SM_G970U1
DEBUG: Device serial: R38MC037W7X
DEBUG: Using server (portable): C:\Users\pgm.vm02\Desktop\scrcpy\scrcpy-server
C:\Users\pgm.vm02\Desktop\scrcpy\scrcpy-server: 1 file pushed, 0 skipped. 143.8 MB/s (52867 bytes in 0.000s)
DEBUG: Remaining connection attempts: 100
DEBUG: Remaining connection attempts: 99
[server] INFO: Device: samsung SM-G970U1 (Android 12)
[server] DEBUG: Using encoder: 'OMX.qcom.video.encoder.avc'
adb.exe: Derror: protocol fault (couldn't read status): Invalid argumentE
BUG: Interrupting process
ERROR: "adb forward --remove" returned with value 1
DEBUG: Server disconnected
DEBUG: Server terminated
ERROR: Could not retrieve device information
ERROR: Server connection failed

Question:
Is there any configuration that I missing? or need to forward PC A's VPN port to PC A's local port?

yes, able to run

Your commands look good to me.
But I already get this error on Windows without reason with a simple adb connect:

No connection could be made because the target machine actively refused it. (10061)

Maybe some firewall or other weird restriction somewhere.

Maybe some firewall or other weird restriction somewhere.
U mean need to verify the port from PC A or the VPN side?
Btw, I saw that some one said need to open the port 27183 or something like that, will this "open port" will be an issue for this if didn't open?

Since you connect from localhost (via the ssh tunnel), you don't need to open it (port 27184 in your case) on your network, but maybe you might need to open it in your firewall.


Manage index/collection routes exist

Add check if index/collection routes exist in Layout component
Clean 404 component template

Codecov Report

Merging #391 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #391   +/-   ##
=======================================
  Coverage   85.89%   85.89%
=======================================
  Files          38       38
  Lines         723      723
=======================================
  Hits          621      621
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af0d1c...766c313. Read the comment docs.


Gitsigns QFListOpts error

Description
Error with command QFListOpts
https://imgur.com/x23aeB5.png
Neovim version
0.8
Operating system and version
Arch Linux
Expected behavior
No error
Actual behavior
Error
Minimal config
require('gitsigns').setup{}

Steps to reproduce

nvim --clean -u minimal.lua
...

Gitsigns debug messages
No response

QFListOpts is not a valid command

QFListOpts is not a valid command

What it's mean?

It's a type used in the code.

It's a type used in the code.
This function not implemented?
https://imgur.com/5sBABYo.png

That just an error in the completion. It isn't a function.

It is not a function. Don't call it.

It is not a function. Don't call it.

But there are only two options for calling :Gitsigns in my case:

I can verify from :PackerStatus that gitsigns is loaded.

It is not a function. Don't call it.

But there are only two options for calling :Gitsigns in my case:

I can verify from :PackerStatus that gitsigns is loaded.

Update. I forgot to negate a condition in the completion code.


configure gitflow

to check:

https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

let it be


metadata: Add CheckpointVolumesDirectory

The volumes directory was introduced in Podman with https://github.com/containers/podman/pull/8781. It is used to store the content of volumes associates with checkpointed container.

@adrianreber the volumes field is used in https://github.com/containers/podman/pull/13505


Parser cannot read arbitrary precision numbers

http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf specifies in the second paragraph of the introduction that JSON is agnostic about numbers, and simply represents them as a series of digits.
However, serde-json parses anything with a decimal point as a Rust f64, which causes numbers to be read incorrectly. There is no way to avoid this because this behaviour is chosen as soon as a decimal point is encountered. This makes it impossible to use serde-json to interoperate with financial software using JSON.

It'd be nice for both ergonomics and correctness if serde supported this.
But... how common are protocols that rely on this behavior? The two money protocols I'm familiar with, Stripe and Stockfighter, both use integer cents. I believe this is to avoid issues with implementations like Javascript's that are more hopelessly entangled with lost precision.
I'm trying to get a feel for priority, not arguing against the request.

@JohnHeitmann Bitcoin Core, and things with API-compatibility with it, uses these numbers for monetary values. This is an historical accident but one that can't be changed now without breaking a lot of applications.
This is the only application I'm aware of, but it's a pretty big one.

Hi, I'm going to try and send you a pull request dealing with this. You'll find the lost precision to be an issue with almost every bitcoin exchange API and Forex api's as well. Some even go the way of serializing decimals as JSON strings so it's more evident for the client/consumer.
And for most other cases, even when I don't know about the precision of the 0.00022 value being sent from JS, I don't want my rust to make it worse giving me a 0.00029999...
I'm familiar with a breadth of Ruby JSON libraries and the community seems to have agreed upon deserialising JSON floats as decimals by default, with an option to reverting to Floats.
Rust has a decimal crate since december 2015, looks very complete, and seems to be using num under the hood so they probably don't reinvent much. I'll try using that. https://crates.io/crates/decimal
Anyways just to let you know this is being looked at :)

@nubis Okay but once you parse it, what do you do with the result? The Visitor trait will require you to convert it to f64 in order to do anything.
You are going to need to fix https://github.com/serde-rs/serde/issues/185 before you fix this.

hehe, I was coming to that same conclusion by the time you wrote that.

Hi people, just to share some progress on this, implementing decimal. I've forked both serde https://github.com/nubis/serde and serde_json https://github.com/nubis/json
It took me a few nights to make sense of all the codebase and what goes where, but I finally got decimal deserialization to work.
I'm going to focus now on cleaning everything up, so I'm still a long way to go.
While working on it, and just to make it easier on myself I made it so that all numbers are initially parsed as decimals. As the decimal module has it's own internal parser it lifts some weight from serde which essentially just parses any '0'...'9' or '.'
I do think it's a good idea to start parsing as if it was an integer then scale up to a decimal once we're sure we need the precision, so I'm going to revert to something similar to what you had before, but using decimals instead of f64.
Then, I also think conversions between d128 and f64 are more lossy than they should so I'm going to check that too.
I'd really like some feedback if any of you can give it, I think d128 could be more integrated like any other primitive and its implementations could be using the existing macros.

just fyi - str.parse::<f64>() does a much better job than the current implementation and could be used as a stopgap measure. I separated it from the format check in Hjson.

@laktak how did you determine that str.parse::<f64>() does a better job? Are there some inputs on which it is more accurate? What are they?
I recently rewrote float parsing to be 40% faster and much more accurate in #110. Does that resolve the difference?

Sure, here's a simple test with the current versions:
    let input = r#"{
        "x1": -9876.543210,
        "x2": 0.14,
        "x3": 0.1401,
        "x4": 0.14004,
        "x5": 0.14005
    }"#;

    let json: serde_json::Value = serde_json::from_str(&input).unwrap();
    println!("{}", serde_json::to_string_pretty(&json).unwrap());

    let hjson: serde_hjson::Value = serde_hjson::from_str(&input).unwrap();
    println!("{:?}", hjson);

{
  "x1": -9876.543210000002,
  "x2": 0.14,
  "x3": 0.1401,
  "x4": 0.14004000000000003,
  "x5": 0.14005
}
{
  x1: -9876.54321
  x2: 0.14
  x3: 0.1401
  x4: 0.14004
  x5: 0.14005
}

For hjson I adopted your code to do the testing but then fed the string to str.parse::<f64>().

If by "current versions" you mean serde_json 0.7.4, that does not have my fixes. They will be in 0.8.0. On the current master branch I get the correct output.

Sorry, forgot to switch the branch. There are still issues with different numbers though. E.g.
let input = r#"{
        "x1": 4094.1111111111113,
        "x2": 0.16666666666666666
    }"#;

prints
{
  "x1": 4094.1111111111115,
  "x2": 0.16666666666666667
}
{
  x1: 4094.1111111111113
  x2: 0.16666666666666666
}

Neither of those is a parsing issue - the numbers are parsed correctly but printed incorrectly. I can take a look later.

I filed https://github.com/miloyip/rapidjson/issues/687 to follow up on the printing issue upstream.

I have an arbitrary precision implementation in #252. If you have been waiting for this feature, please take a look and let us know whether it addresses your use case.
The PR adds a cfg:
serde_json = { version = "0.9", features = ["arbitrary_precision"] }

that turns serde_json::Number and serde_json::Value into arbitrary precision types. If you parse some JSON to either of those types, serializing it back to JSON or calling to_string() will preserve exactly the original representation.
The implementation relies on specialization so will only work on nightly for now.

The PR is ready to merge but I would like to hear from at least two people that this implementation would be useful to them. I don't want to merge and maintain this if nobody will use it.

I would be happy even to help you maintain this, if you like. The code looks pretty clear now that I've gone over it.

Also, I think usage will increase hugely once specialisation gets stabilised. (I'm not sure when that's coming; next release perhaps?)

next release perhaps?

by the look from the tracking issue and the 2017 roadmap, I'd say next year at the earliest.

Ouch, that's slow-moving progress!
Sent from my iPhone

On 13 Feb 2017, at 16:34, Oliver Schneider<EMAIL_ADDRESS>wrote:
next release perhaps?
by the look from the tracking issue and the 2017 roadmap, I'd say next year at the earliest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

#348 has a promising implementation with the same API as #252 but without relying on unstable specialization. It also interacts better with deserializer "adapters" like erased-serde, serde-ignored, and serde-encrypted-value which would not have worked with specialization.

The arbitrary_precision feature released in serde_json 1.0.13 adds support for dealing with arbitrary precision numbers through the serde_json::Number type.


Minor spelling/formatting cleanups

Most of the changes are cosmetic, but in one place the images weren't showing up because the capitalization in the image link didn't match the path to the images.

If you choose to take this PR, feel free to squash all the commits into one, if that suits you.  I just wanted to make it easier to isolate a particular change if you'd prefer it be removed or done differently.

Multiple readmes identify key K1 as being tied to IO0, but the pinout image of the board says that's it's IO2.  One of the two should be corrected to be consistent, either the pinout image is wrong, or the READMEs should be fixed to say IO2.
I believe the READMEs are wrong, because it looks like the RS232 lines are are on IO0 and IO1.

If the readmes are wrong, I can make that correction, and update this PR with the change.


Warnings emitted by the desugarer are not shown

I sometimes have some enabled warnings which don‘t get displayed even if all other warnings are and there are no errors in the code. A cabal run on the same file shows the warning. My feeling is it depends on the category of the warning. I noticed the problem with following categories:

all-missed-specialisations
incomplete-patterns

There might be more. I’d like to know if this warnings work for anybody else.

These warnings are generated by the desugarer. We only run as far as the type checker. We could go onwards, and have the code to do so, but it costs more CPU time. Should probably be added as a low priority rule and discard the output (to save memory).

IIRC GHC shows these warnings even if you pass -fno-code. Probably worth looking at what code path triggers the warnings here.

So currently there is no workaround to make ghcide to emit those warnings?

Does this mean that no warnings work? Currently using -Wall and -Wincomplete-record-updates on a project and I don't get any warnings at all.

@emlautarom1 no, not by a very long way, 90%+ of warnings show up, just those about pattern matches. If you are seeing no warnings, its not because of this issue.

@ndmitchell Then please, take a look at #524 since I'm getting no warnings when using -Wall and -Wincomplete-record-updates. This is the only reason I keep using ghcid instead of ghcide

@maralorn do you continue missing those warnings?

@jneira On
haskell-language-server --version
haskell-language-server version: <IP_ADDRESS> (GHC: 8.8.4) (PATH: /nix/store/ri34qr8kzx4qwwg3yw4sj0skv738723v-haskell-language-server-<IP_ADDRESS>/bin/haskell-language-server)

yes.
{-# OPTIONS_GHC -Wall #-}
data A = A | B
f :: A ->  ()
f A = ()

This file shows a warning when compiled, but is clean in the editor.

(Which is an especially important warning in my opinion. For example this ghc proposal wants to make incompleteness an error via an extension.)

@maralorn thanks for confirming that, i am not sure if this would be a feature request or a bug fix so both :wink:

@maralorn I am afraid -XNoIncomplete wouldn't allow emitting those warnings much earlier, but GHC's exaustive checker (massively) relies on already having types.

It's not about types, its that these warnings are emitted during desugaring - we have the types available. If we could generate these warnings without doing a full desugar that would definitely be preferable. If not, desugaring is just a time/memory cost, with the benefit of getting these warnings.

@Ericson2314 I didn‘t put any hopes in the proposal for fixing this issue. I just mentioned it to underline the importance of a fix. If anything the proposal would probably make this issue slightly worse since one could argue that a false negative on an error is worse than on a warning.

One option is to desugar only on open/save, so that we don't take the performance hit on every keystroke.

Would be possible to do the desugaring async? So that typechecker errors can be shown before the desugaring is finished?

@maralorn - the architecture of ghcide is such that if you write it, its almost certainly going to be async. Doing it on open/save is one option, but to be fair, we haven't actually measured performance. That's worth doing before we try and decide if it needs optimising. I don't actually think it's all that hard to do. Approximately:

Define a desugar warnings target, which runs the desugarer and collects warnings. This might already be in Ghcide somewhere, since DAML uses it.
Make whatever asks for the type check values instead ask for the desugared warnings.
Perhaps fiddle with flags to try and make desugaring do less work, if you can.

As a result, I'm marking it beginner suitable bug. I personally find the desugarer warnings mostly useless, which is why I never prioritised it way back when, but I appreciate I'm an outlier here!


Func ideas

Bionic reading html formatting
Squid reader formatting
Mark Favorite articles

Add Similar/Recommended Articles:

scoped to my article universe
scoped to my following-links(N) universe // Nmax = 8
(Just writing down a funny thought, isn't this type of functionality going to be limited to who has metadata to support such query? If so, is that what the product wants? )


Remove deprecated critical-pod annotation

Description
scheduler.alpha.kubernetes.io/critical-pod is deprecated as of Kubernetes 1.13.
It is replaced by priorityClassName set as system-cluster-critical or system-node-critical that can be used starting with Kubernetes 1.10.
https://v1-15.docs.kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note
None required

Deploy preview for calico ready!
Built with commit cbe3967d566a32f9cedd9f9878f924d86ea5dc46
https://deploy-preview-3502--calico.netlify.app

Sorry for the delay... this LGTM!


Unable to change the status of user.

Framework Version: 0.1.2
Test Steps:

Create a user and check his account as active.
Edit the created user and and Uncheck the status and save.

Result- Status of User will be still Active

more information is needed on this where in Admin panel or which user?

In admin section ,User grid

This issue had been fixed and will appear to show up in next release.

Framework Version: 0.1.3
Fixed


VariantPicker broken

The VariantPicker does not show anymore for products with multiple variants. The element doesn't get rendered and the picker and the add-to-cart button don't show.
Completly fresh install, commit afce249.
There is no specific error showing, however this looks new in the JS console: (shows on every page, not just one with a variantpicker)
Uncaught TypeError: Cannot read property 'unstable_cancelScheduledWork' of undefined
    at storefront.js:formatted:19083
    at Object.31 (storefront.js:formatted:24354)
    at n (storefront.js:formatted:11)
    at Object.<anonymous> (storefront.js:formatted:3831)
    at Object.1379 (storefront.js:formatted:3863)
    at n (storefront.js:formatted:11)
    at Object.1364 (storefront.js:formatted:877)
    at n (storefront.js:formatted:11)
    at 0 (storefront.js:formatted:71)
    at storefront.js:formatted:72

So far I discovered that importing ReactDOM causes this error. We upgraded it's version recently, maybe some other package should be updated as well as they're not compatible at the moment?

It appears that the UMD version of ReactDOM is broken since CommonJS is working perfectly. I'll post a fix in a few minutes.


question: are long IN clauses handled?

Hi! Neither a bug nor feature but a question (apologies if not best forum for it) -
This is somewhat obscure, but I'm wondering how you handle composing a query where you have a very long "IN" clause. For example, imagine you are looking for Contact records and you are searching for say 100-200 email addresses.
In the past (using other libraries) this has been a problem as - if I recall correctly - the HTTP GET request to Salesforce becomes too long (the URL is too long).
Just wondering if you've run across that and have a solution for it in this library.
Thanks!
and p.s. thanks for suggesting this library (over on a jsforce github issue thread)

@techieshark - There are some use-cases that Jetstream handles programmatically to solve these types of use-cases. Basically the idea is to split up the query into multiple queries and then combine all the results as if it were just one query.
Nothing is built into this library specifically right now, but it is a good feature request to include something like this to automatically split up queries if they are too large.
Take a look here for an example: https://github.com/jetstreamapp/jetstream/blob/main/libs/shared/ui-utils/src/lib/hooks/useFetchPageLayouts.ts
Gist:

Either calculate the maximum length of all the item or just set an upper bound on number of items if you have an idea of the possible length of items and know how large the rest of your query will be
Build multiple queries (I have a helper function I used here splitArrayToMaxSize)
Query each set of data, e.x. for (const query of getPageLayoutQueries(sObjects)) { - I use a for loop to make them consecutive, you could try concurrent if there are not too many queries
And depending on if the results would be paginated or not, you may want to build a queryAll helper function like I did in Jetstream https://github.com/jetstreamapp/jetstream/blob/5b1caa2585f13392e2239d64ca87e9268be8cf1a/libs/shared/data/src/lib/client-data.ts#L305

Here is another example where Jetstream will fetch all child records for a given parent record, and to do this it builds subqueries dynamically, but also makes sure not to make the SOQL too large (just limits to 50 child relationships, but the number of fields is largely known - so this was a safe number I landed on)
https://github.com/jetstreamapp/jetstream/blob/5b1caa2585f13392e2239d64ca87e9268be8cf1a/apps/jetstream/src/app/components/core/ViewChildRecords.tsx#L175
Hope this helps

Thanks for the detailed response @paustint!
Yeah that final example here does look similar to what I try to do currently:
https://github.com/jetstreamapp/jetstream/blob/5b1caa2585f13392e2239d64ca87e9268be8cf1a/apps/jetstream/src/app/components/core/ViewChildRecords.tsx#L208-L214
composeQuery looks great!
I will close this issue now to keep things tidy


[QUARKS-129] create SimpleSimulatedSensor

@queeniema, pls review to ensure this meets your needs/expectations. Thanks.

@dlaboss, looks great! It will greatly simplify the existing recipes.


Patch 1

hibernate#1362 Override clear() to clear reactiveActionQueue

I think this change is correct, but I'm not sure why guy included my fix to #600 in the PR. Was that a mistake?

Was that a mistake?

sorry, I make a mistake.  x_x


Is there a way in content protection which allows L1 content to decrypt with non secure decoder?

I encountered a scenario where L1 content was successfully decoded on a non-secure decoder, contrary to expectations.
When I tried using the Media3 sample app to test "HW secure decode" asset, I found crypto failure when forced the software decoder and encountered an expected failure. However, when testing with my specific asset, I did not receive a crypto error, and the decoder was able to decrypt the content successfully.
So I assume output protection rule can cause this difference. I want to achieve the same behavior like media3 sample where L1 content is only decrypted on secure decoders. Could you suggest suitable license protection rules to achieve this? Specifically, my L1 track fails to decrypt on an L3 CDM, but it decrypts successfully on an L1 CDM. However, it's also being decoded by a software decoder, which contradicts the expected secure decoding behavior of L1 content.
Showing below warnings, but the playback continues without any widevine error.
2024-09-26 15:47:45.191  3597-4605  MediaCodecRenderer      androidx.media3.demo.main            W  Drm session requires secure decoder for video/avc, but no secure decoder available. Trying to proceed with [c2.android.avc.decoder].

Output protection rule query: In which condition we can decode DRM protected video which has L1 key with device designated as widevine L1 (CDM) but decoded as part of software decoder ?

If your company is not a Widevine partner, you can sign up through https://www.widevine.com/contact at no cost. We can answer some of your questions there or guide you in case they are more complex.