Move boundary event from sub-process to task gives exception

See screenshot, I tried to drag the error event attached to the sub-process to the boundary of the inner service task, which gives me:
Error: unexpected dockingDirection: <undefined>
    at getDockingPoint (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110713:9)
    at connectRectangles (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110367:22)
    at repairConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110429:25)
    at BpmnLayouter.layoutConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:35786:107)
    at LayoutConnectionHandler.execute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:102008:41)
    at file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92075:31
    at CommandStack._atomicDo (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92038:5)
    at CommandStack._internalExecute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92069:8)
    at CommandStack.execute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:91825:8)
    at Modeling.layoutConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:101010:22)  [error]
Error: unexpected dockingDirection: <undefined>
    at getDockingPoint (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110713:9)
    at connectRectangles (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110367:22)
    at repairConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:110429:25)
    at BpmnLayouter.layoutConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:35786:107)
    at LayoutConnectionHandler.execute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:102008:41)
    at file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92075:31
    at CommandStack._atomicDo (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92038:5)
    at CommandStack._internalExecute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:92069:8)
    at CommandStack.execute (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:91825:8)
    at Modeling.layoutConnection (file:///Applications/CamundaModeler.app/Contents/Resources/app.asar/public/index.js:101010:22)  [error]

Unfortunately, I cannot reproduce it in smaller example.

Please share the exact diagram contents (SubProcess + Boundary Event + Task) so that we're able to reproduce the issue.
Additionally, please provide us with the Camunda Modeler version you're using.

Modeler 2.0.0
Sorry, exact diagram contents are gone, hoped stacktrace would be sufficient. BTW, it was a rendering issue only, the BPMN-contents were ok (re-open Modeler showed all as expected).

Unfortunately I'm not able to reproduce this issue using the latest version of bpmn-js (packed into the Camunda Modeler). A great help for us is if you could provide relevant parts of a diagram you're able to reproduce the issue with.
Based on my testing (and the inability to reproduce this issue) it seems like you found a rare edge case which is hard to fix without a reliable way to reproduce it.

It appears to me as if the diagram was previously broken, too: As shown in the stack trace, the editor attempts to layout a connection. However, there is no connection attached to the boundary event.

There was a connection to the lower right end event which went away on my first dragging attempt. It sure was an edge case since I cannot reproduce it either. If it happens again, I will try to save all necessary infos.


.NET Framework publishes bad TaskWaitBegin ETW event

(This can't be fixed in this package but adding issue for tracking)
I attempted to hook this up with WCF services that run on .NET Framework and was able to get an IServiceBehavior configured relatively easily. Unfortunately, it appears that .NET Framework publishes the TaskWaitBegin ETW event with 5 parameters when it's defined as having 6.
This was addressed in .NET Core (https://github.com/dotnet/coreclr/pull/8942) but it's not clear that the desktop/.NET Framework backport was ever completed.
The result is that the listener rejects the ETW event since it doesn't provide the 6 parameters it's expecting.

The latest reference source for .NET Framework doesn't appear to have the fix:
https://github.com/microsoft/referencesource/blob/5697c29004a34d80acdaf5742d7e699022c64ecd/mscorlib/system/threading/Tasks/TPLETWProvider.cs#L520-L522


[rxjs-6] combineLatest operator is missing

RxJS version:
"rxjs": "^6.0.0-beta.2",
"rxjs-compat": "^6.0.0-beta.2",

Code to reproduce:
While trying to upgrade my app, I noticed that combineLatest operator doesn't exist anymore:
import { combineLatest } from 'rxjs/operators';

is it removed ?
if yes then I think it should be available when using rxjs-compat
Thanks!

seems fixed in ^6.0.0-rc.0


CPU 100% on Ubuntu KDE

Summary
mattermost-desktop constantly at 100% cpu
When I open the program the spawned thread goes to 100 and doesn't go below +- 90%
System:
Ubuntu 17.10 with KDE. Linux firen-werk 4.13.0-17-generic #20-Ubuntu SMP Mon Nov 6 10:04:08 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Mattermost-desktop version: I can't open the help menu, because it doesn't load but the going for the three stripes in the interface -> Help says 4.4 . (dpkg says: mattermost-desktop (3.7.1-3.7.1))

Mattermost Server version : Version: 4.0.0  (dev) Database: postgres
When I open the program the spawned thread goes to 100 and doesn't go below +- 90%
I have global menu's enabled in KDE without any other special tweaks on the interface

Expected behavior
2 / 3 % cpu usage on my i5-6300U CPU
Observed behavior
Using $ strace mattermost-desktop I see the following messages constantly:
futex(0x1ebedaa4ae70, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebeda844180, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebedaa30058, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebeda7809c0, FUTEX_WAIT_PRIVATE, 2, NULL) = -1 EAGAIN (Resource temporarily unavailable)
futex(0x1ebeda7809c0, FUTEX_WAKE_PRIVATE, 1) = 0
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}, {fd=36, events=POLLIN}], 4, 0) = 0 (Timeout)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}, {fd=36, events=POLLIN}], 4, 9) = 1 ([{fd=19, revents=POLLIN}])
read(19, "\1\0\0\0\0\0\0\0", 16)        = 8
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
futex(0x1ebeda844180, FUTEX_WAKE_PRIVATE, 1) = 1
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}], 3, 0) = 0 (Timeout)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
futex(0x7f0afefa31f8, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x1ebeda4a8b20, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x7f0afc90ebb0, FUTEX_WAIT_PRIVATE, 2, NULL) = -1 EAGAIN (Resource temporarily unavailable)
futex(0x7f0afc90ebb0, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x7f0afefa3288, FUTEX_WAKE_PRIVATE, 1) = 1
write(77, "\1\0\0\0\0\0\0\0", 8)        = 8
<!--
Using `$ strace mattermost-desktop` I see the following messages constantly:
futex(0x1ebedaa4ae70, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebeda844180, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebedaa30058, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x1ebeda7809c0, FUTEX_WAIT_PRIVATE, 2, NULL) = -1 EAGAIN (Resource temporarily unavailable)
futex(0x1ebeda7809c0, FUTEX_WAKE_PRIVATE, 1) = 0
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}, {fd=36, events=POLLIN}], 4, 0) = 0 (Timeout)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}, {fd=36, events=POLLIN}], 4, 9) = 1 ([{fd=19, revents=POLLIN}])
read(19, "\1\0\0\0\0\0\0\0", 16)        = 8
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
futex(0x1ebeda844180, FUTEX_WAKE_PRIVATE, 1) = 1
recvmsg(18, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=18, events=POLLIN}, {fd=19, events=POLLIN}, {fd=28, events=POLLIN}], 3, 0) = 0 (Timeout)
recvmsg(28, {msg_namelen=0}, 0)         = -1 EAGAIN (Resource temporarily unavailable)
futex(0x7f0afefa31f8, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x1ebeda4a8b20, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x7f0afc90ebb0, FUTEX_WAIT_PRIVATE, 2, NULL) = -1 EAGAIN (Resource temporarily unavailable)
futex(0x7f0afc90ebb0, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x7f0afefa3288, FUTEX_WAKE_PRIVATE, 1) = 1
write(77, "\1\0\0\0\0\0\0\0", 8)        = 8

@yuya-oc thoughts?

For now, unfortunately I'm not familiar at reading strace. Although https://github.com/electron/electron/issues/8455 might be related. If it's true, upcoming v4.0.0 would fix the problem due to upgrading of Electron. Wondering if you could try v4.0.0-beta.

Perfect, v4.0.0-beta fixed the issue. The output of strace went back to a normal amount.


Directly use zod schema in validate

Hi, im trying to get the type safety working with my API but I already have a ton of zod schemas defined in another file, when I try to use these it wont work.
	const { data } = await validate(request, {
		mySchema
	});

gives
Error: "Invalid data: at 'mySchema': 'Required'."
	const { data } = await validate(request, {
		...mySchema.shape
	});

gives
error when starting dev server: TypeError: Cannot read properties of undefined (reading 'getBaseTypes')
const { data } = await validate(request, mySchema);
gives
Argument of type 'ZodObject<{ mystuff }, "strip", ZodTypeAny, { ...; }, { ...; }>'.
Is there any way to make this work?

Thats weird... The shape property works well on my test project.
// This can be imported
const postSchema = z.object({
    id: z.string(),
});

export const POST = (async ({ request, locals }) => {
    const { data } = await validate(request, { ...postSchema.shape });

    return json({});
}) satisfies RequestHandler;

You also aren't required to spread the shape. (validate(request, postSchema.shape))
Can you maybe share more details about your project?

Thats weird... The shape property works well on my test project.
// This can be imported
const postSchema = z.object({
    id: z.string(),
});

export const POST = (async ({ request, locals }) => {
    const { data } = await validate(request, { ...postSchema.shape });

    return json({});
}) satisfies RequestHandler;

You also aren't required to spread the shape. (validate(request, postSchema.shape))
Can you maybe share more details about your project?

Thanks for the fast reply! You're right that I dont need to spread the shape, I found out that it seems to be caused by z.enum, whenever I comment out that line it will give the
TypeError: Cannot read properties of undefined (reading 'getBaseTypes')
error
i.e.
export const testSchema = z.object({
	test: z.string(),
	someData: z.enum(["maybe", "orthis"]).optional()
});

I added a z.enum in my schema and it worked normally...
Maybe its your vite version that is causing this issue? (it would be suprising tho)
I would recommend updating your dependencies. Here is my package.json:
"dependencies": {
    "@sveltejs/kit": "^2.3.3",
    "svelte": "^4.2.8",
    "sveltekit-typesafe-api": "^0.1.2",
    "vite": "^5.0.11",
    "zod": "^3.22.4"
  },

I added a z.enum in my schema and it worked normally... Maybe its your vite version that is causing this issue? (it would be suprising tho) I would recommend updating your dependencies. Here is my package.json:
"dependencies": {
    "@sveltejs/kit": "^2.3.3",
    "svelte": "^4.2.8",
    "sveltekit-typesafe-api": "^0.1.2",
    "vite": "^5.0.11",
    "zod": "^3.22.4"
  },

Ah yes I'm still on Svelte 1 but I did a dirty upgrade to Sveltekit 2 and it seems to work now..
Thank you! I'll try it out when I'm at a point that I can upgrade to Sveltekit 2 (soon) 👍

Hello, Im sorry to bother again but I have upgraded to Svelte 2 and somehow I'm still getting the error. I have set up a codesandbox and I'm also getting the error there.
Not sure what I might be doing wrong here, it still seems to becaused by z.enum:
https://codesandbox.io/p/devbox/friendly-meadow-xqhwp5


i can not reach digit ocr engine

i got "not found error" with  digit

Yes, looks like both the repo and the owner have gone 410 :( thanks for the heads-up, I removed the link.

how can i reach it, is there another fork for it or archived verison


python311Packages.torch-xla: init at 2.1.0

Add torch-xla
This passes tests on my machine, although about half of the tests are disabled since they require hardware devices.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[X] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

(I'm aware that torch-xla 2.2 has recently been released. Due to other dependency constraints I'm not able to test that properly yet).


100 list channels

This should handle everything that we need for displaying the list of channels. There are a couple of other fixes (the default landing page, fixing an error for a missing property), but this has been tested to work on Android.


Update showcase.json

Pull for Final Demo Checklist

Dear @anunomac,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation

Pull for Final Demo Checklist

@anunomac Can you please go through the CLA steps?

@anunomac Can you please also make the updates suggested in the conversation above? Please note that the Ecosystem page is meant to promote the product.

@anunomac Can you please also make the updates suggested in the conversation above? Please note that the Ecosystem page is meant to promote the product.
Thank you for going through the CLA steps.

@anunomac Can you please review and update by Wednesday, January 3rd?

Hey jenni, apologies for the delay.
Everything you requested is done, except the stats. What stats would you like us to include and in what form?
Thank you.

Hey @jennifertrin , apologies for the delay. Everything you requested is done, except the stats. What stats would you like us to include and in what form?
Thank you.

Thank you. Please put down number of users in the format of "x users"

Hey @jennifertrin , apologies for the delay. Everything you requested is done, except the stats. What stats would you like us to include and in what form?
Thank you.

Hello @anunomac, are you sure that you added the logo and screenshot? I do not see them included in the commit.

@anunomac Can you please review the comments above?

@anunomac Can you please review the comments above?

@anunomac Are you sure that you added the logo and screenshot? I do not see them included in the commit.

@anunomac Due to lack of response, we will close this PR.


#43 Resolve import issue

Description
Closes #43
Remove type: module from engine and add missing dependency on babel runtime.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Manually switched to affected nodejs version, cleared dependencies and installed / built to reproduce issue. Applied fix, re-ran to see fixed.
[x] Had Aslam do the same cos I'm 😈

Checklist:

[x] My code follows the javascript standard style
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation and versioning
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have rebased onto master and there are no code conflicts

lgtm. let’s have @nattrass test for Windows if possible. Thanks!


chore: set flushing log level to info

Describe your changes
No not merge, used for a debug image to check flushing.
How best to test these changes
Issue ticket number and link

Was used for debugging, not needed any more.


Svelte 3.52 with typescript has breaking changes with TwicPics

npm package isn't up to date with latest Svelte changes
I followed the instructions in official docs and got the following error:
	"resource": "/Users/***/Carousel.svelte",
	"owner": "_generated_diagnostic_collection_name_#4",
	"code": "2345",
	"severity": 8,
	"message": "Argument of type 'SvelteComponentTyped<Attributes, undefined, undefined>' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'.\n\nPossible causes:\n
- You use the instance type of a component where you should use the constructor type\n
- Type definitions are missing for this Svelte Component. If you are using Svelte 3.31+, use SvelteComponentTyped to add a definition:\n
- import type { SvelteComponentTyped } from \"svelte\";\n  class ComponentName extends SvelteComponentTyped<{propertyName: string;}> {}",
	"source": "ts",
	"startLineNumber": 14,
	"startColumn": 10,
	"endLineNumber": 14,
	"endColumn": 17
}]```

Hi @Korayem.
Thank you for opening this issue.
Can you confirm that the error only appears in IDE and that your images are displayed or are you experiencing a problem during the build?
Obviously notice that we encounter this problem as soon as we use typescript and this whatever the version of svelte...

Thanks for your response @mbgspcii
Indeed, I thought it might be a warning so I proceeded to run my sveltekit app but got this error:

This caused my page not to render...
I think Sveltekit is less forgiving than Svelte :)

@mbgspcii  It may also be due to svelte embracing vite vs rollup in the past?

HI @Korayem
Using components with SvelteKit is a bit tricky: SvelteKit evolves very fast and there are still a lot of breaking changes.
At the moment, TwicPics components are not SSR compatible with SvelteKit.
If you don't need the ssr mode, you can add export const ssr = false;  in the /routes/+layout.js file
This file is not created by default. If it doesn't exist in your project, just add it with the single line const ssr = false;
Should normally work then.
Setting the TwicPics installation in layout.svelte will work as long as it is the base layout of the application (gg).

Adapting TwicPics components to sveltekit's SRR mode is on our roadmap but not at the top of the list.
Tell us if the temporary deactivation of the ssr mode is problematic.
Hoping it helps.
Thank you for your feedback.
Regards.
Miguel

Hey Miguel @mbgspcii
Thanks again for the detailed response
I do need SSR in my project :)
Good news is, I managed to get Twicpic working in sveltekit. What I've done is extracted from the twipics project all the svelte specific code and added it manually to my project and it works like a charm. Needed a bit of tweaking here and there but it's working fine with SSR.
This should do for now till you guys support Sveltekit.
Here's what I copied

src/_ > lib/twicpic
src/svelte3/* > components/* (did some changes here to make it work)

BTW is Rich Harris announced RC in the last Svelte Summit (about a month ago) that SvelteKit won't have any breaking changes as they lock down Kit for 1.0.0 final release.

Great++ @Korayem
Thanks for the feedback and again bravo for adapting the TwicComponents to your SvelteKit project.
We'll let you know as soon as we've adapted our components to SvelteKit.
Sincere greetings.
Miguel

@mbgspcii I gave this another search to see what can be done to use the npm package with sveltekit without getting the error:
<TwicPic is not a valid SSR component. You may need to review your build config to ensure that dependencies are compiled, rather than imported as pre-compiled modules.
I found this documented way of loading external packages client-side
So this is what I have now
+layout.svelte
<script lang="ts">
  import { installTwicPics } from '@twicpics/components/svelte3';
  import<EMAIL_ADDRESS>
  installTwicPics({
    // domain is mandatory
    domain: 'https://my-domain.twic.pics'
  });
</script>

A dummy wrapper for TwicImg (the same can be done for TwicVideo)
components/TwicImg.svelte
<script lang="ts">
  import { onMount } from 'svelte';

  export let src;
  export let alt;
  export let classProp;

  //
  let TwicImg;

  onMount(async () => {
    const module = await import('@twicpics/components/svelte3');
    TwicImg = module.TwicImg;
  });
</script>

<svelte:component
  this={TwicImg}
  {src}
  {alt}
  class={classProp}
/>

Then in any page to use TwicImg
<script lang="ts">
  import TwicImg from '$components/TwicImg.svelte';
</script>

<TwicImg alt="" classProp="" src="" />

Note I changed props class to classProp since class is reserved
The caveat with this approach is that SSR generates the page WITHOUT any  and all is done client-side which is slower and defeats the purpose of SSR
The 2nd approach people mentioned but couldn't figure out is to inform vite to precompile twicpics (requires installing the package as devDependency using -D). But I couldn't make this work...
vite.config.js
  optimizeDeps: {
        include: [ '@twicpics/components/svelte3' ]
      },

Looking forward to having twicpics native sveltekit support

Hi @Korayem
I thank you for the time you spend to solve this problem. We have come to the same conclusion as you.
We are looking for a solution that will allow the use of SSR. This task is scheduled in a near future.
We will keep you informed of our progress.
Sincerely yours.
Miguel

Any updates on this?

Am also facing this issue. Thanks @Korayem for your at least temporary solution 🙏

Hi.
We are currently modifying the generation of our Svelte3 components.
Once this step is done we will be able to expose TwicPics components usable with SvelteKit.
Sincerely yours.
Miguel

Hi @Korayem, @angelokeirsebilck and @raremiroir.
We have just deployed version 0.15.0  of our components.
In this version we now support SvelteKit. This version also fixes Svelte Components typing.
Sorry for the delay and we hope you will be satisfied with this version.
Thanks again for using TwicPics and feel free to send us your feedback.
Sincerely yours.
Miguel

Thank you @mbgspcii!
Will give it a whirl

Works like a charm, thanks @mbgspcii !


Does autodoc-pydantic support the pydantic.v1 compatibility layer?

Hi, my team is trying to move our relatively large codebase over to pydantic v2 and were hoping to do this gradually using the pydantic.v1 compatibility layer. Upon our testing, it seems like autodoc-pydantic ≥v2 only works with pydantic ≥v2 syntax and isn't backwards compatibility even when importing pydantic.v1 in our code.
Are we understanding the situation correctly, and/or do you have any suggestions for how we might be able to proceed? Happy to contribute if you can point us in the right direction.

Hi @goroderickgo,
you're correct, autodoc-pydantic supports either pydantic v1 or v2. It does not support the pydantic v1 compatibility layer.
Actually, this was never really intended. In fact, it was a deliberate choice to have two separated branches for autodoc-pydantic supporting either pydantic v1 or v2, respectively. The reasoning behind this decision lies in a simpler and less complex code base without the requirement to distinguish between various versions of pydantic models.
Currently, I have no proper idea on how to support the pydantic v1 compatibility layer other than creating a separate branch integrating the logic/implementation from both autodoc-pydantic v1 and v2. From my experience, this will be a substantial amount of work.
Adding support for the pydantic v1 compatibility layer in autodoc-pydantic v2 does not feel right to me because the large amount of added complexity is only needed infrequently and will become completely obsolete in 1-2 years. However, I'm completely open for any suggestions.

Thanks @mansenfranzen that makes sense. I understand that it's hard to invest time into something that will only last a short time. This was helpful for our team to decide how to proceed with the migration (and pushes us to not use the v1 layer for long 😅)


100% method coverage for Java SDK

WorkflowClient:

MetadataClient:

TaskClient:

AuthorizationClient:

EventClient:

SecretClient:

SchedulerClient:

Added 100% coverage for metadata client: https://github.com/orkes-io/orkes-conductor-client/pull/25

Method with partial tests: workflowClient.skipTaskFromWorkflow
Explanation: it makes a valid request, but 500 response is received due to the task being already executed.


Feature/v2.0

Codecov Report

Merging #8 into develop will decrease coverage by 2.87%.
The diff coverage is 96.91%.

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage      100%   97.12%   -2.88%
===========================================
  Files            5        8       +3
  Lines          150      278     +128
  Branches        12       25      +13
===========================================
+ Hits           150      270     +120
- Misses           0        8       +8

Impacted Files
Coverage Δ

src/interfaces.ts
100% <ø> (ø)
:arrow_up:

src/meta-value.ts
100% <100%> (ø)
:arrow_up:

src/builder.spec.ts
100% <100%> (ø)

src/meta-header.ts
100% <100%> (ø)

src/separator.ts
100% <100%> (ø)

src/path-node.ts
87.5% <87.5%> (ø)

src/data-type.ts
96.9% <96.55%> (-3.1%)
:arrow_down:

src/builder.ts
97.05% <97.05%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f30c6...66d06b7. Read the comment docs.


Programming exercises: Allow automatically graded exercises where all test cases give 0 points

This PR is based on #5994
Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I implemented the changes with a good performance and prevented too many database calls.
[ ] I documented the Java code using JavaDoc style.

Client

[ ] I followed the coding and design guidelines and ensured that the layout is responsive.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context
#6093
Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Exam Mode Testing

Prerequisites:

1 Instructor
2 Students
1 Exam with a Programming Exercise

Log in to Artemis
Participate in the exam as a student
Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
...

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test

Test Coverage

Screenshots

Codecov Report

Merging #6101 (bb5a56f) into refactor/programming-exercise-grading-service (2ce5d9c) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##             refactor/programming-exercise-grading-service    #6101      +/-   ##
===================================================================================
- Coverage                                            80.05%   80.04%   -0.01%
+ Complexity                                           12770    12766       -4
===================================================================================
  Files                                                 2206     2206
  Lines                                                87266    87260       -6
  Branches                                             13013    13010       -3
===================================================================================
- Hits                                                 69861    69848      -13
- Misses                                                9713     9720       +7
  Partials                                              7692     7692

Impacted Files
Coverage Δ

...programming/ProgrammingExerciseGradingService.java
91.78% <ø> (ø)

...rogramming/ProgrammingExerciseTestCaseService.java
89.01% <0.00%> (-2.39%)
:arrow_down:

.../artemis/web/rest/ProgrammingExerciseResource.java
87.95% <0.00%> (-0.73%)
:arrow_down:

...rogramming-exercise-configure-grading.component.ts
71.87% <100.00%> (-0.88%)
:arrow_down:

...va/de/tum/in/www1/artemis/service/FileService.java
79.85% <0.00%> (-0.74%)
:arrow_down:

...idebar/conversation-selection-sidebar.component.ts
87.97% <0.00%> (+0.63%)
:arrow_up:

...e/scheduled/WeeklyEmailSummaryScheduleService.java
68.96% <0.00%> (+3.44%)
:arrow_up:

Flag
Coverage Δ

client
76.07% <100.00%> (-0.01%)
:arrow_down:

server
84.45% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce5d9c...bb5a56f. Read the comment docs.


[GEP-18] Adapt etcd-server-cert and etcd-client-tls secrets to new secrets manager

How to categorize this PR?

/area security
/kind enhancement
/merge squash
What this PR does / why we need it:
This PR adapts the etcd-server-cert and etcd-client-tls secrets to new secrets manager. It moves the generation into the etcd component since it actually belongs there (this is the only component that uses it). The kubeapiserver component was adapted as well such that it uses the Get function of the secrets manager instead of expecting the etcd secrets being injected from outside.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/3292#issuecomment-1036058890
/invite @timebertt @BeckerMax
/invite @ishan16696 @abdasgupta @shreyas-s-rao
Special notes for your reviewer(s):
✅ Depends on

https://github.com/gardener/etcd-custom-image/pull/10,
https://github.com/gardener/etcd-druid/pull/309,
https://github.com/gardener/etcd-druid/pull/310,
https://github.com/gardener/gardener/pull/5693

hence PR is in draft state.
Release note:

NONE

/retest

I tested this locally by reconciling an existing shoot and it worked well. The secrets etcd-client-tls and etcd-server-cert were replaced by secrets manager secrets etcd-client-* and etcd-server-(main|events)-* with the correct names, immutability, and labels. These new secrets were also correctly mounted to both etcd statefulsets and the kube-apiserver deployment. The ca-etcd-bundle-* secret was mounted instead of the ca-etcd secret that was previously mounted.
A few things that I noticed:

The ca-etcd secret was not deleted, even though it's mounted by both etcd and kube-apiserver. Is this secret still needed for anything?
The checksums for the old secrets were not deleted from the etcd statefulsets:

  annotations:
    checksum/secret-etcd-ca: 645b4e6de924f657e5138b4c709b267bca97923989750aea78735f575095af2d
    checksum/secret-etcd-client-tls: 30f53f48fad0db9c3b3b64c5690c913518abebd1879cc5ebcc6103e45e04a401
    checksum/secret-etcd-server-cert: 745eca45fbea1b912541c4193d429cbdb59af41cfcdffef96dcc32d6ee813a97

I believe these annotations are not needed anymore?

Again, thanks @stoyanr for your efforts, highly appreciating it!

The ca-etcd secret was not deleted, even though it's mounted by both etcd and kube-apiserver. Is this secret still needed for anything?

The CA secrets will never be deleted/always remain in the system so that they can be used for signing certificates. The CA bundle secrets will be used by the components when communicating with secured endpoints, so that all works as expected, I think.

The checksums for the old secrets were not deleted from the etcd statefulsets:
I see that the annotations are actually removed from the Etcd resources, but it seems etcd-druid preserves them in the statefulsets - is this an etcd-druid bug?

Hm, I have just tried to reproduce this again and in my system I don't see these checksum annotations anymore for the StatefulSets or Pods. Am I missing something?

Hm, I have just tried to reproduce this again and in my system I don't see these checksum annotations anymore for the StatefulSets or Pods. Am I missing something?

I updated the PR to the latest changes and tried reconciling a shoot previously created with the latest master, you are right, the checksum annotations are there only on statefulsets, but not on pods (so not part of spec.template in statefulsets either). I am not even sure why are these annotations added to the statefulsets in the first place, this was perhaps wrong before and is even more wrong now that these secrets don't even exists. But this clearly has nothing to do with this PR.
/lgtm


Something wrong with the date of this article.

An article that revolves around SQL Server 2005?  That wouldn't have been written on 07/19/2015.  What happened here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29f8852e-4df3-d3ff-174a-86182b88c79d
Version Independent ID: 09358ac9-475e-d3f0-7f04-10fa5e9ad31b
Content: Adding Printable Reports to Visual Studio Applications
Content Source: docs/visual-basic/developing-apps/printing/adding-printable-reports-to-visual-studio-applications.md
Product: dotnet-visualbasic
GitHub Login: @KathleenDollard
Microsoft Alias: kdollard

@KathleenDollard I think we should remove this note. I don't think it's worth pointing out.

Let's remove it! Also, to answer @PerryCodes question about date: the date shown here was an arbitrary date we had to pick when we migrated the content from MSDN to docs. So they're not super accurate for content that hasn't been revised since the migration (all changes done to this topic were global changes like metadata updates, etc.)


Installation of packages fails after 28.7.0 upgrade: Documentation object is not iterable

Getting a weird error:  TypeError: 'Documentation' object is not iterable trying to install rjsmin in a brand new virtualenv with the latest setup tools.  This is on Ubuntu 16.0.4 and my OS X machine does the same thing.
ubuntu@staging:~$ virtualenv env
New python executable in /home/ubuntu/env/bin/python
Installing setuptools, pip, wheel...done.
ubuntu@staging:~$ source env/bin/activate
(env) ubuntu@staging:~$ pip install rjsmin
Collecting rjsmin
  Using cached rjsmin-1.0.12.tar.gz
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info/rjsmin.egg-info
    writing pip-egg-info/rjsmin.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/rjsmin.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/rjsmin.egg-info/dependency_links.txt
    writing manifest file 'pip-egg-info/rjsmin.egg-info/SOURCES.txt'
    warning: manifest_maker: standard file '-c' not found

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-EeZDjY/rjsmin/setup.py", line 42, in <module>
        setup()
      File "/tmp/pip-build-EeZDjY/rjsmin/setup.py", line 33, in setup
        return run(script_args=args, ext=ext, manifest_only=_manifest)
      File "_setup/py2/setup.py", line 421, in run
        return _core.setup(**kwargs)
      File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
        dist.run_commands()
      File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
        self.run_command(cmd)
      File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
        cmd_obj.run()
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 279, in run
        self.find_sources()
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 306, in find_sources
        mm.run()
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 533, in run
        self.add_defaults()
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 562, in add_defaults
        sdist.add_defaults(self)
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/py36compat.py", line 35, in add_defaults
        self._add_defaults_data_files()
      File "/home/ubuntu/env/local/lib/python2.7/site-packages/setuptools/command/py36compat.py", line 111, in _add_defaults_data_files
        dirname, filenames = item
    TypeError: 'Documentation' object is not iterable

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-EeZDjY/rjsmin/
(env) ubuntu@staging:~$ pip show setuptools
---
Metadata-Version: 2.0
Name: setuptools
Version: 28.7.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email<EMAIL_ADDRESS>Installer: pip
License: UNKNOWN
Location: /home/ubuntu/env/lib/python2.7/site-packages
Requires:
Classifiers:
  Development Status :: 5 - Production/Stable
  Intended Audience :: Developers
  License :: OSI Approved :: MIT License
  Operating System :: OS Independent
  Programming Language :: Python :: 2.6
  Programming Language :: Python :: 2.7
  Programming Language :: Python :: 3
  Programming Language :: Python :: 3.3
  Programming Language :: Python :: 3.4
  Programming Language :: Python :: 3.5
  Topic :: Software Development :: Libraries :: Python Modules
  Topic :: System :: Archiving :: Packaging
  Topic :: System :: Systems Administration
  Topic :: Utilities
Entry-points:
  [console_scripts]
  easy_install = setuptools.command.easy_install:main
  easy_install-3.5 = setuptools.command.easy_install:main
  [distutils.commands]
  alias = setuptools.command.alias:alias
  bdist_egg = setuptools.command.bdist_egg:bdist_egg
  bdist_rpm = setuptools.command.bdist_rpm:bdist_rpm
  bdist_wininst = setuptools.command.bdist_wininst:bdist_wininst
  build_ext = setuptools.command.build_ext:build_ext
  build_py = setuptools.command.build_py:build_py
  develop = setuptools.command.develop:develop
  easy_install = setuptools.command.easy_install:easy_install
  egg_info = setuptools.command.egg_info:egg_info
  install = setuptools.command.install:install
  install_egg_info = setuptools.command.install_egg_info:install_egg_info
  install_lib = setuptools.command.install_lib:install_lib
  install_scripts = setuptools.command.install_scripts:install_scripts
  register = setuptools.command.register:register
  rotate = setuptools.command.rotate:rotate
  saveopts = setuptools.command.saveopts:saveopts
  sdist = setuptools.command.sdist:sdist
  setopt = setuptools.command.setopt:setopt
  test = setuptools.command.test:test
  upload = setuptools.command.upload:upload
  upload_docs = setuptools.command.upload_docs:upload_docs
  [distutils.setup_keywords]
  convert_2to3_doctests = setuptools.dist:assert_string_list
  dependency_links = setuptools.dist:assert_string_list
  eager_resources = setuptools.dist:assert_string_list
  entry_points = setuptools.dist:check_entry_points
  exclude_package_data = setuptools.dist:check_package_data
  extras_require = setuptools.dist:check_extras
  include_package_data = setuptools.dist:assert_bool
  install_requires = setuptools.dist:check_requirements
  namespace_packages = setuptools.dist:check_nsp
  package_data = setuptools.dist:check_package_data
  packages = setuptools.dist:check_packages
  python_requires = setuptools.dist:check_specifier
  setup_requires = setuptools.dist:check_requirements
  test_loader = setuptools.dist:check_importable
  test_runner = setuptools.dist:check_importable
  test_suite = setuptools.dist:check_test_suite
  tests_require = setuptools.dist:check_requirements
  use_2to3 = setuptools.dist:assert_bool
  use_2to3_exclude_fixers = setuptools.dist:assert_string_list
  use_2to3_fixers = setuptools.dist:assert_string_list
  zip_safe = setuptools.dist:assert_bool
  [egg_info.writers]
  PKG-INFO = setuptools.command.egg_info:write_pkg_info
  dependency_links.txt = setuptools.command.egg_info:overwrite_arg
  depends.txt = setuptools.command.egg_info:warn_depends_obsolete
  eager_resources.txt = setuptools.command.egg_info:overwrite_arg
  entry_points.txt = setuptools.command.egg_info:write_entries
  namespace_packages.txt = setuptools.command.egg_info:overwrite_arg
  requires.txt = setuptools.command.egg_info:write_requirements
  top_level.txt = setuptools.command.egg_info:write_toplevel_names
  [setuptools.installation]
  eggsecutable = setuptools.command.easy_install:bootstrap

For the record, can make installation pass if I hack this into py36compat.py at line 110:
                    if not isinstance(item, tuple):
			continue

Obviously not the fix, but ya, setuptools doesn't seem to like the 'Documentation' object being passed in.

Also downgrading to 28.6.2 makes this work..

same here, downgrading temporary solves the issue.

@tweksteen

@tweksteen, could you investigate. What is the cause? What's the proper fix?

This issue also occurs when installing rcssmin. And issues in the repositories have been opened already: https://github.com/ndparker/rcssmin/issues/6 & https://github.com/ndparker/rjsmin/issues/9

Working on another project noticed my builds were failing at rcssmin and then other packages. I tracked down the common error files and saw it was setuptools package, and found this issue.
I too can vouch that there are issues with this version 28.7.0, and the work around is using 28.6.2

@jaraco I don't understand why you reversed this patch when the correct thing is to fix the failing package itself. I've reproduced the install of rjsmin. The backtrace is similar to this:
Traceback (most recent call last):
  File "<string>", line 17, in <module>
  File "/home/twek/.virtualenvs/tmp-c712bdea02dc1ccb/build/rjsmin/setup.py", line 42, in <module>
    setup()
  File "/home/twek/.virtualenvs/tmp-c712bdea02dc1ccb/build/rjsmin/setup.py", line 33, in setup
    return run(script_args=args, ext=ext, manifest_only=_manifest)
  File "_setup/py2/setup.py", line 421, in run
    return _core.setup(**kwargs)
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "<string>", line 15, in replacement_run
  File "/home/twek/.virtualenvs/tmp-c712bdea02dc1ccb/local/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 306, in find_sources
    mm.run()
  [...]

If you read a bit the code of that specific package, you will see that it is strongly hooking onto the setup process. If you traceback the setup call, you'll find that data_files is populated using a call to the find_data function. A bit further down, if you have a look at what is returned by that function, you will find that it builds a list of Documentation object (an internal class define in this package).
Now, the standard Python documentation (3.7) mentions:
data_files specifies a sequence of (directory, files) pairs [...]
or even You can specify the data_files options as a simple sequence of files without specifying a target directory, but this is not recommended
At no point does it mention that it will accept random object... So yes, someone hacked onto the setup process and relied on the undocumented and inconsistent past behaviour of setuptools.
Moving forward, the correct solution is to create a bug for that project. But this is not a setuptools issue. setuptools should follow the standard behaviour described in the Python documentation.

I reversed the patch because a regression was reported and I don't have enough time to dig in and analyze the underlying cause. Thanks for doing that. I had the feeling that multiple projects were already filing complaints, but now that I review the history, I see that you have indicated that the issue is probably isolated to one or a few projects and they may be abusing the API. I'm happy to bring the change back if that's the right behavior.

if there's a bug people rely on it's not a bug, it's a feature (as linus would say) and focus should be to not break userspace, see: https://lkml.org/lkml/2012/12/23/75

I wouldn't state it nearly as strongly as Linus did there. If this usage can be shown to be isolated to a single project (or just a few projects), and those projects can develop a solution avoid encountering the issue, then I'd have no problem re-introducing the behavior.

The main thing I'd like to know - does the use of Documentation objects in data_files serve any purpose? That is, does that interface work for installing that documentation? I guess it must. I wonder how it is that Documentation objects are a suitable interface for other aspects of distutils/setuptools such that they don't cause problems during installation.

I've added further technical details on that issue on the rcssmin bug tracker (https://github.com/ndparker/rcssmin/issues/6). The extra setup code in that project is hooking onto the install_data command and translating the options later on. This is where the Documentation objects are 'flatten' to a list of pair of strings. That translation does not happen when running the egg_info subcommand.
From a setuptools perspective, I'll create a new pull request with unit test to make sure that particular behaviour is tested. Additionally and since setuptools is a corner stone software of the Python community, we might want to setup larger integration tests where we install each of the top 100 Pypi packages (http://pypi-ranking.info/?) using the test version of setuptools. This will make sure this type of commit and rollback does not happen again. It will also give quantitative details on the impact of such change.

I see that there is already this kind of test in test_integration.py. Would it be worth expanding these to cover Pypi top downloaded packages?

If you make it the top 200 this would've been caught, as rcssmin is a dependency of django_compressor :wink:

Would it be worth expanding these to cover Pypi top downloaded packages?

Perhaps. The integration tests as currently implemented are already brittle and somewhat broken (virtualenvwrapper and novaclient are marked xfail). I'm sure the situation would get messy if a dynamic list of hundreds of packages were tested. If someone is able to maintain those tests, I'd be all for it.
We might want to add a command-line option to opt-in to those tests such that a developer running the tests locally wouldn't have to shoulder the burden of running those slow tests during development.

FYI, I have run the integration test on the top 300 packages of Pypi and django_compressor has been the only package failing the installation with the patched setuptools.


Prefer autoload to only require what you use

What does this PR do?
I have been profiling my Rails app's startup time, and noticed a number of gems have took quite a bit (relatively speaking) to require. The datadog_api_client is one of them. Looking over the ruby files, it seems to be related to purely the number of files. It is taking about 200ms on my laptop to require with how it is today.
Our app doesn't use much of the API, so it's a lot of required files that aren't actually used. I started this PR to see how much improvement there would be if we could see improvements. I don't have an exact time it was dropped to yet, but it was small enough that it wasn't showing up the flamegraph I generated with rbspy/speedscope.
I started this before realizing this uses the openapi-generator. If I could get some pointers how it runs to generate this, I can take a look at applying the change there.

Additional Notes

Review checklist
Please check relevant items below:

[ ] This PR includes all newly recorded cassettes for any modified tests.

[ ] This PR does not rely on API client schema changes.

[ ] The CI should be fully passing.

[ ] Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

Hi, thanks for the PR. Unfortunately we don't believe autoload is the correct approach here given its not thread safe and not recommended to be used in libraries.
I am going to go ahead and close this pr but we are looking into optimizing imports and startup times.


why not to remove foreach dependency in favor of for in?

Hi!
In this project foreach is used for traversing plain objects. Then, I guess that using for in there is a way  to do the same and, then, to remove foreach dependency that could be useful for traversing indistinctly arraylike and own key objects but not, in this case.

for..in has bugs in many engines, and is not a good coding practice.
Indeed, in this case, I'm using it just to traverse the own keys of two internal objects. I'm also utilizing the scope that the foreach callback is creating, so even with for..in i'd want to call a function.
It's a small dependency, and more dependencies is better - what would the benefit be to remove it?

I like dependencies. But I think more dependencies is not always better. For example, if a dependency does not bring any benefit for the dependency consumer, why should it be imported?
In this case:
forEach(typedArrays, function (_, typedArray) {
//...
})
// ...
forEach(toStrTags, function (getter, typedArray) {
    //...
})

it could be replaced by:
for(var typedArray in typedArrays) {
    //...
}
// ...
for(var typedArray in toStrTags) {
    var getter = toStrTags[typedArray];
    //...
})

without any increment of code in the project.
On the other hand, I don't know if for..in has many bugs traversing literal objects in many engines.

Your replacement is broken; it'd also have to have an "own property" check to avoid hitting enumerable things in Object.prototype.

That you say, is for preventing the implementation of some library that put enumerable properties on Object.prototype? or there is some engine that put enumerable properties on Object.prototype?

That you say, is for preventing the implementation of some library that put enumerable properties on Object.prototype? or is there some engine that put enumerable properties on Object.prototype?

Yes, user code might do it.

Ok! thanks


v3fs9

Description
[Insert description of issue here]
Detailed Information
Is available here

buddy you're using a modded ancient version of pex on an ancient version of bukkit why do you think we can or will help you

From: likunheng666<EMAIL_ADDRESS>Sent: Sunday, August 25, 2019 7:01:39 AM
To: PEXPlugins/PermissionsEx<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [PEXPlugins/PermissionsEx] v3fs9 (#3030)
Description
[Insert description of issue here]
Detailed Information
Is available herehttps://gist.github.com/15c89b8826e38c1ce7b8
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/PEXPlugins/PermissionsEx/issues/3030?email_source=notifications&email_token=AAEZSZF7GQWBR3CQP3RYNODQGKGEHA5CNFSM4IPJEV42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHHQU3Q, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAEZSZCVWWAQLJURNYOV2ZTQGKGEHANCNFSM4IPJEV4Q.


Pending updates to columns in db_signals.csv

This PR is derived from #1434; i removed all of the new columns but this should include all of the changes to the existing columns (except Available Geography, more on that in a bit).
Please let me know if we need to fix any of these -- the summary of differences appears to me to be:

"day"' removed from Time Type column, replaced with empty string: (this seems like it was accidental)

dsew-cpr:confirmed_admissions_covid_1d_7dav

"n/a" removed from Pathogen/Disease Area column, replaced with empty string: (these seem intentional)

nchs-mortality:deaths_allcause_incidence_num
nchs-mortality:deaths_allcause_incidence_prop
nchs-mortality:deaths_percent_of_expected
safegraph-daily:completely_home_prop
safegraph-daily:completely_home_prop_7dav
safegraph-daily:full_time_work_prop
safegraph-daily:full_time_work_prop_7dav
safegraph-daily:median_home_dwell_time
safegraph-daily:median_home_dwell_time_7dav
safegraph-daily:part_time_work_prop
safegraph-daily:part_time_work_prop_7dav
safegraph-weekly:bars_visit_num
safegraph-weekly:bars_visit_prop
safegraph-weekly:restaurants_visit_num
safegraph-weekly:restaurants_visit_prop

Newline added at the end of the file (this is effectively inconsequential)

The Available Geography column has some sweeping changes applied to it...  In one example from chng, the text was modified from county,hhs,hrr,msa,nation,state to county, hrr (by Delphi), msa (by Delphi), state (by Delphi), hhs (by Delphi), nation (by Delphi).  I believe this signifies that only county data came from the source, and we computed the various other higher levels of geo aggregation.  This is valuable information, but i would suggest we keep the column the way it was and create a new column called something like Geographies aggregated by Delphi or Post-aggregated geographies that lists the geography types that were extrapolated by us.  There are a few reasons for doing it this way, including that (i believe) the Signal Documentation app expects the structured comma-separated text without the extra annotations as it was before, and that representing the same information in its own column should save some space.  If you agree with this, let me know as i think i should be able to apply those changes pretty easily.  Also, some entries (like quidel for instance) have " (by Delphi)" attached to every geography in the list; that suggests to me that we did aggregations to produce county-level data from finer-grained locations, but i didn't think that was the case.

Just kidding!  Those n/a values were not actually removed in the source spreadsheet nor in #1434 -- i inadvertently stripped them due to the way i imported the csv files...  I edited the above message to strikethrough the irrelevant text.

Here is some code that you can paste into a python interpreter to see the (correct) list of differences:
import pandas as pd

base_url = 'https://github.com/cmu-delphi/delphi-epidata/raw/{}/src/server/endpoints/covidcast_utils/db_signals.csv'

current = pd.read_csv(base_url.format('dev'), na_filter=False)
proposed = pd.read_csv(base_url.format('bot/update-docs'), na_filter=False)

new_cols = set(proposed.columns) - set(current.columns)
print(new_cols)

non_matching = (proposed[current.columns] != current)
diffs_per_col = non_matching.apply(sum)
print(diffs_per_col)

mismatched_time = pd.concat([current[['Source Subdivision', 'Signal']], non_matching[['Time Type']]], axis=1)
print(mismatched_time[mismatched_time['Time Type']])

the source data in the google sheet has changed since this was done; closing this PR to create a new one...


Craft 2 support

Hello,
I have a website using craft 2.9.2 and craft-embedded-assets 0.4.1. Is the plugin supposed to work? I am trying to embed youtube links but all the data is coming empty.
I need to update to craft 3 but I was wondering if there is any quick way to update just the plugin to solve the problem as upgrading to craft 3 would take more time to test all the other features.
Thank you very much!

Yeah, the final release of the Craft 2 version was almost four years ago, so the project dependencies (including the embed-grabbing package that was being used by the plugin at the time) would be fairly out of date at this point, it wouldn't be surprising if some providers no longer worked.  Development for the Craft 2 version was ended at the release of the Craft 3 version, before we took over the plugin, so we're not going to provide support for the Craft 2 version (and also Craft 2 itself is no longer supported outside of critical security issues).  However, you are free to fork the project and make any changes you like, including updating the project dependencies and hopefully getting them to a working state.

Thank you very much for the quick reply @ttempleton ! I've forked a version and managed to fix the issues!

@lucashfreitas I'm having the same issue on some of our sites; any chance I'd be able to see your fixed version? We are in the same boat of not being quite ready to upgrade to Craft 3 due to having to re-evaluate all our sites and change some plugins.

Hey @tlacure17 sorry for taking long to reply. Actually the problem was related to the embed/embed plugin. It was out of date, so whenever I tried to load youtube iframe content it was returning an empty/invalid Json. This happens because youtube iframe request must use HTTPS and the old version of the plugin was using HTTP only, so I have replaced the code directly on vendor folder and it worked. What is the problem you having atm?


Extending multiprovider

to handle requests that have a "," in the path (separating individual layers for ex: /buildings,places,pois/123/132.json)
Valid URLs:
/all/15/9660/12314.json //returns all the layers specified with this multiprovider
/buildings/15/9660/12314.json //returns just buildings
/pois,places/15/9660/12314.json //returns pois and places only
/places,land-usages,buildings/15/9660/12314.json //returns places, land-usages and buildings

and these are obviously invalid and throws a 404
/foo/15/9660/12314.json //foo is not a valid layer
/buildings,pois,foo,places/15/9660/12314.json //foo is not a valid layer
/buildings,all,pois/15/9660/12314.json //this throws a 404 because all is a multiprovider

This is no longer relevant, closing.


AZ-204_lab_12.md

English:
Enter video.
Current Translation:
輸入 影片。
Suggested Translation:
輸入 video。
Description:
Don’t translate the names of contains. Global check

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result ICMS QUERY


DAWN-624 ⁃ readme.md tag for public testnet is out of date

Should be DAWN-2018-02-14

Phil Indicates this is complete


CSS requirements?

Hi! First, thanks for a great React component!
I have an issue that keeps coming back to me occasionally. Sometimes, I just cannot get the waypoint to fire as intended, no matter  what I do. I usually put the waypoint after/at the end of lists (to load more elements), but most of my implementations it simply doesn't work. Usually it fires on page load, regardless of where I put it, and then simply dont fire again no matter what I do. So, I wonder, are there any basic requirements that needs to be fulfilled for this to work? Are there any common issues you can think of that can cause the type of issues I'm having?
I'll post some code to, but I couldn't get it working as intended even when I mimicked the example code. Really weird!
Thanks in advance for your time!

I don't think there are any special CSS requirements that need to be fulfilled for <Waypoint> to work. However, I doubt it would work if it was in a container that had display: none; on it or something like that. And, it needs to be the descendant of a scrollable ancestor (e.g. the window or a <div> with an overflow style that enables scrolling).
It's possible that there is something weird going on here. Let us know if you discover any more useful information.

One thing that came to mind as I was reading this: Is there a chance the Waypoint is injected into the DOM before the content above? That's just speculation though. Any code you can post here would help track this down.

Hey guys, and thanks a lot for your reply! I will get back to you with actual code ASAP, I'll try and get a fiddle set up. Talk to you soon again!

Posting this here because I don't think it warrants opening a new issue, and is somewhat related to OP.
I was, at first, having the same issue as the OP where the Waypoint onEnter was being triggered on every page load and then never firing again (and not firing onLeave either). This was happening because the Waypoint was placed at the end of a long (several times the window height) Feed component, and was always inside it. Specifically (and banally), the calculations in _currentPosition showed that the Waypoint was both above the bottom of and below the top of the Feed, which was true as soon as the page loaded. This confused me for a while, because I had assumed that the position of the Waypoint would be evaluated with respect to the window/viewport, and not just the whole encompassing parent component. I thought that it would work just like the demo fiddle, where the Waypoint onEnter is triggered as it becomes visible, and onLeave likewise triggered as it leaves the screen, with affordances made for threshold. However, when a long non-window parent component is used, the onEnter is calculating whether the Waypoint is indeed contained within that component, which is obviously true at all times unless ... that parent component has its own scrollbar and a fixed height.
That wasn't clear to me from the outset, but I moved on.
I changed the Feed to be overflow: hidden, and now the scrollableAncestor is the window. This works. My only remaining confusion is that I want to trigger the onEnter something like 50% down the page, and since I'm using the window only, it seems weird that the threshold calculation uses the innerHeight property instead of the document.body.offsetHeight, because innerHeight is just the size of my screen, and document.body.offsetHeight is the height of the whole page, including the parts not shown. It does, however, make sense for the isAboveBottom and isBelowTop to use the contextBottom and contextTop values derived from innerHeight in determining the Waypoint's position, but when the thresholdPx is similarly derived from innerHeight it forces me to use values greater than 1 for the threshold to approximate the 50% down the page that I'm shooting for. This doesn't make sense to me, and I don't imagine it would make any sense to you all, so I'm pretty sure I'm doing something wrong here.
In any case, I changed how the threshold is calculated when the scrollable parent is the window, and was able to get it working the way I know it was intended — I can now set the threshold to .5, and trigger the onEnter halfway down the page.
Here's the (very slightly) altered code for the _currentPosition function: https://gist.github.com/2cf24017a7d43ab0c99c
Cheers, and thanks for the great component.

Hi @ameensol and thanks for using react-waypoint!

This was happening because the Waypoint was placed at the end of a long (several times the window height) Feed component, and was always inside it.

The method to find the scrollable parent is somewhat limited, and we've tried explaining that in the README. More specifically, we only look at the calculated overflow-y or overflow property of a parent to determine its scrollable-ness. Would you mind sharing the CSS properties of the Feed? There might be something there that could highlight a bug with the current way we find the scrollable parent. Also, there's an open PR to allow you to pass in a custom scrollableParent, though I haven't seen any activity in the last week, so I'm not sure whether that person is actively working on it or not. That might help your usecase, but without more context I'm not sure.

My only remaining confusion is that I want to trigger the onEnter something like 50% down the page, and since I'm using the window only, it seems weird that the threshold calculation uses the innerHeight property instead of the document.body.offsetHeight

When we implemented the threshold support, we had infinite scroll in mind. When you do infinite scrolling, you don't want the trigger point to be based on the height of the container, because the container will grow for each "page" being injected at the bottom.
However, I do realize that the supprt for threshold is somewhat limited, and I'd be open to creative PRs to extend how that can be used. For instance, I was in a situation last week where I needed a waypoint to trigger at exactly 56 pixels from the top. Using threshold here would have meant looking at the height of the window to compute it, which would feel brittle.
Would you mind sharing a bit more about how you use the waypoint in the Feed? I think that could help figuring out what actions we could take to make your (and other developers) lives easier.

I'm also doing an infinite scroll. I ended up implementing threshold like this:
    // .5 at page 0 bc halfway down page
    // .25 at page 1 bc 30/40 articles
    let threshold = 1 / (2 * (page + 1))

where page starts at 0 for the first set of articles in the feed, and is incremented after every article load. I realize now that my use case of loading at 50% down the page is a little convoluted, and it might be easier to trigger the waypoint say, when the user is 5x the height of their device away from the bottom or something along those lines, in which case the threshold would just be (5), or the multiple of device height from the end that I want waypoint triggered. I understand now why you guys have it as you do. I'm going to keep playing around with it and see if I like it my way or if I want to switch back.
Thanks for the quick response and again for the awesome library!


There is no "new scaffolded item" option in Core 2.1

I'm really confused and seem to be the only person on the web with this one.
Basically I have been following the tutorial and when I got to the stage where I scaffold a new page - there are no options for scaffolding whatsoever (VS2017 community). It's there when I create a project in Core 2.0 but not 2.1
Also, I tried simply downloading the tutorial project from github (the 21 version), opened it in VS and again, there is no scaffold choice when adding an item.
Any ideas where I can start looking?

I've updated the version of VS2017 and it's now working!


Blog post pages doesn't have the post title in the  element

Describe the bug
Blog post pages doesn't have the post title in the  element
To Reproduce
Steps to reproduce the behavior:

Go to https://opencollective.com/open-web-docs/updates/introducing-open-web-docs
Title element is Open Web Docs - Open Collective

Expected behavior
Expected title element to be [title of the blog post] - Open Web Docs - Open Collective.
E.g. Introducing Open Web Docs - Open Web Docs - Open Collective.

Ya, it's using  tag.


Add chromium-browser for login auth

Was really confused why I wasn't able to log in. I just have Chromium, not Google Chrome or Firefox.

Thanks!


Emitting mouse sequences?

Understandably, emitting escape sequences to generate terminal mouse sequences is rather niche, but is it within the scope of this project? I'm thinking of using it as part of a terminal multiplexer for forwarding mouse events to pseudoterminals.

Thanks for the issue. To answer your question, it really depends on how we're looking at the anes crate.

One view can be - foundation for crates like crossterm and then it's really out of scope.

These crates needs to emit stuff like colors, text attributes, move the cursor, ...
Consume input events mouse, key, resize, ...
But they do not need to emit mouse events for example.

Another view can be - anes states that it provides & parses ANSI escape sequences. Mouse event is an ANSI escape sequence for sure and then it isn't out of scope.

I wrote this crate for the first use case and it doesn't make much sense to add support for this. It's also a bit complicated, see below.

There's no single ANSI escape sequence type for mouse events. We have:

X10 compatibility mode - ESC [ M CB Cx Cy (6 bytes only)
Xterm - ESC [ < Cb ; Cx ; Cy (;) (M or m)
rxvt - ESC [ Cb ; Cx ; Cy ; M

Let's say we will implement Display for the Mouse enum:
https://github.com/zrzka/anes-rs/blob/378ac7461ecac29fde9e10df7b08359d1315a9ad/anes/src/parser/types.rs#L52-L65
Which variant should we emit? X10 compatibility mode? Xterm mode? Rxvt mode? Add special method just for the mouse to emit correct variant? We can introduce another enum like:
enum Mouse {
  Xterm(...),
  X10(...),
  Rxvt(...),
}

Then we will know what to emit, but we will complicate it for the Parser users - they want to know which mouse button was used & the location. They don't care about ANSI escape sequence type.

There's one thing you can do to forward mouse events. Skip the Parser and use Engine & Provide. Unfortunately, both these types are private, but I can make them public. Then you can implement your own provide_csi_sequence in this way:
impl Provider for MyType {
    fn provide_csi_sequence(&mut self, parameters: &[u64], ignored_count: usize, ch: char) {
        if ch == 'm' || ch == 'M' {
            // Mouse event - reconstruct ANSI sequence & forward it
        } else {
            // Not a mouse event
        }
    }
}

Not sure if I helped you. Thoughts?

I think this makes sense. Thanks.

@eaglgenes101 so for now, I'd recommend to copy & paste Engine & Provide to your code base. I'm still thinking how to expose these two types (directly via anes crate, move just these two types to a separate crate like anes-parser, ...). No decision made yet and I do not want to block you while thinking what would be the best option.


List a team's member API page parameter is 0-based (should be 1-based)

Description
In the API specification, page is supposed to be specified as 1-based.
https://try.gitea.io/api/swagger#/organization/orgListTeamMembers

However, it seems to be implemented with 0-based. (Please see screenshots)
Gitea Version
1.19.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
Target Organization/Team

Result when page=1 is specified

Result when page=0 is specified

Git Version
No response
Operating System
No response
How are you running Gitea?
Installed with Helm chart and running on Kubernetes.
Override values
service:
  http:
    type: LoadBalancer

Install command
helm install gitea gitea-charts/gitea --version 8.3.0 -f override-values.yaml

Database
None

The fix would be a breaking change so this shouldn't go in 1.19.4

It should be a bug, because the API documentation said it's 1 based.

I agree it's a bug. The fix itself would be a breaking change so it should be fixed in 1.20


⚠ Bofrost.fr has degraded performance

In ad4e6a7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 918 ms

Resolved: Bofrost.fr performance has improved in 27232f4.


FINERACT-2081: Validation error in mandatory loan account parameters

Description
In CreateLoan request, missing mandatory fields which were being returned as 400 in the past are currently being returned as 403 ? Is this an expected change? Please confirm. The following fields are being returned with 403 code when missing

clientId
productId
principal
transactionProcessingStrategyCode
expectedDisbursementDate
submittedOnDate

FINERACT-2081

Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

I just note that this is being done on an open ended ticket for "small bug fixes" (2081).... is this a new functionality or a bug fix and if a bug fix the idea should be to make sure the approach is clear, maintainable by the next person coming along.  If the logic and approach is not clear then that defeats the purpose of the changes.   The definition of "DONE" needs to be better than we found it.

Please see my review!

Done! Comments reviewed and attended

@galovics do you have any concerns left with this PR?


fix version convention in dev

Description
Since moving to setuptools in setup.py, the following results when trying to build pycsw:
mandalor:/home/tkralidi/Dev/pycsw/pycsw-tomkralidis# python setup.py build
/usr/local/lib/python2.7/site-packages/setuptools/dist.py:334: UserWarning: Normalizing '2.1.0-dev
' to '2.1.0.dev0' normalized_version,

This was originally brought up during https://github.com/geopython/pycsw/pull/524/commits/4eb9a3320509d791d4619199c832d4481c3813f7#r120224942 by @ricardogsilva
In master, we always keep a VERSION.txt specified as x.y-dev, where x is the major version and y is the minor version.  y is always an odd number as per the producingoss.com even/odd strategy.  VERSION.txt is only updated when making releases (which are then tagged, and the VERSION.txt in master goes back to x.y-dev).
We need to settle on a versioning convention (x.y.dev0 ? Other ideas?) for when in development given the setuptools warning.  Our formal release versions should be unaffected.
In addition, since setup.py now uses VERSION.txt directly we should ensure that reading it strips all spaces before using (i.e. update https://github.com/geopython/pycsw/blob/master/setup.py#L42 to contents = fh.read().strip()).
Environment

operating system: all
Python version: 2/3
pycsw version: master
source/distribution

[x] git clone
[ ] DebianGIS/UbuntuGIS
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):

web server

[ ] Apache/mod_wsgi
[ ] CGI
[ ] other (please specify):

Steps to Reproduce
python setup.py build
Additional Information

Some more context
Python's conventions for specifying versions are described in PEP440. This is followed by pip and setuptools and subsequently by pkg_resources (which is part of setuptools), which we're using in order to read the version at runtime.
According to the PEP, the scheme major.minor-dev, which we are using for dev releases, is perfectly valid. The PEP states that there is a normalization process that transforms major.minor-dev into major.minor.dev0 and states that this is done in order to ensure compatibility with other formats.
Our current versioning scheme
IMHO there doesn't seem to be a problem here. We can keep using the same versioning format as before. The only thing to be aware of is that python normalizes the dev version to major.minor.devnumber (with number being zero if not specified). This means that when installing a dev release of pycsw, if one runs the following:
>>> import pycsw
>>> pycsw.__version__
2.1.dev0

The result is slightly different from what is actually written in the VERSION.txt file:
$ cat VERSION.txt
2.1-dev

However, semantically speaking, both refer to the exact same version.
About possible whitespaces in the version file
As for the whitespace concern, the PEP has this case covered too, by stating that any leading and trailing whitespace must be ignored when determining the version. This means that we don't really need to trim the whitespace when reading the file in setup.py.
should we further distinguish one dev build from another?
Now we could further argue that if I install a dev version now, then someone makes a couple of commits to master and then I install a dev version again, then the two dev versions will be different while still having the same version identifier. Should we consider this a problem?
It seems to me that we could address this by including the git revision number in the dev versions. there seems to be a way to do this by using git describe. A possible implementation might take something from each of these links:
https://stackoverflow.com/questions/14989858/get-the-current-git-hash-in-a-python-script
https://github.com/numpy/numpy/blob/master/setup.py#L70-L92
Personally I think this is something that we could eventually implement, but I don't see it as a priority, nor am I motivated at present to work on it.
What do you think?

@ricardogsilva thanks for the (as always) deep and thorough feedback. Sounds like we should leave this as is then. Perhaps stripping the whitespace is a good safeguard regardless? Objections?

Thanks @ricardogsilva
Lets leave that as is for now and use the git hash in the future.


Compound documents not showing up

Hey there guys.
I've been trying to use the compound document serialization, but for some reason things aren't working.
I have a number of models that are being serialized by the gem. This is what they look like:
class Shift < ApplicationRecord
  belongs_to :team, optional: true
  ...

class Team < ApplicationRecord
  has_many :shifts
  ...

This is what the serializer looks like
class ShiftSerializer
  include FastJsonapi::ObjectSerializer
  ...
  belongs_to :team
  ...
end

The serialization works. However, even though I am including the compound team document:
def index
  shifts = policy_scope(Shift)
  options = {}
  options[:include] = [:team, :'team.name', :'team.color']
  render json: ShiftSerializer.new(shifts, options)
end

I'm still getting the object formatted like so:
...
relationships: {
  team: {
    data: {
      id: "22",
      type: "Team"
    }
  }
}

Whereas I'm expecting to get also the attributes of my team model.

Did you find a fix for this?

Having this exact issue myself... hopefully I can find a fix.

It seems Netflix has abandoned this project. The community created a new fork to continue supporting this project. Please refer https://github.com/fast-jsonapi/fast_jsonapi


allow explicitly providing redirect_uri for github sign in

when trying to deploy keystatic on our infrastructure, i am running into an issue with the redirect_uri setting for github sign in.
the callback uri in the github app is configured to use the /api/keystatic/github/oauth/callback route on the domain the app is deployed to, however the redirect_uri actually used by keystatic is using a hostname internal to our cluster infra. (in our case, the correct hostname would be only on x-forwarded-host header)
which means i cannot sign in, but instead see this error:
An error occurred when trying to authenticate with GitHub:
The redirect_uri MUST match the registered callback URL for this application.

the redirect_uri query param is constructed here by keystatic:
https://github.com/Thinkmill/keystatic/blob/bcc3c69638c3affd758215289f572ac22afadfa5/packages/keystatic/src/api/generic.ts#L375-L378
allowing to set the redirect url explicitly via environment variable would work around this issue i think.

Could you share what framework you're using? I believe Next.js respects x-forwarded-host in the URL passed to route handlers but I think Astro might not, we could probably handle that ourselves

i am using Next.js, and am currently using a work-around modelled after this comment, which seems to do the trick:
import { makeRouteHandler } from "@keystatic/next/route-handler";

import config from<EMAIL_ADDRESS>
const { GET: _GET, POST: _POST } = makeRouteHandler({ config });

function rewriteUrl(request: Request) {
    const forwardedHost = request.headers.get("x-forwarded-host");
    const forwardedProto = request.headers.get("x-forwarded-proto");

    if (forwardedHost && forwardedProto) {
        const url = new URL(request.url);

        url.hostname = forwardedHost;
        url.protocol = forwardedProto;
        url.port = "";

        return new Request(url, request);
    }

    return request;
}

export function GET(request: Request) {
    return _GET(rewriteUrl(request));
}

export function POST(request: Request) {
    return _POST(rewriteUrl(request));
}

I am also running into this error using Remix + Vite deployed to fly.io.
No issues authenticating locally with github but then i receive An error occurred when trying to authenticate with GitHub: The redirect_uri MUST match the registered callback URL for this application. when i try to sign in against my hosted app.


Homepage hearing schedules: linking to new tabs instead of same tab

QA testing - Homepage - Hearing scheduled - Testing #9
After clicking on the hearing schedules, users should be redirected to the corresponding page in a new tab instead of the same tab. This applies to all external links, as we don't want users to get distracted from their workflow and leave MAPLE.

pr #990 should address this issue with hearing scheduled links
the external links on individual bill pages seem to properly open new tabs
as I and/or other people find links that aren't properly opening new tabs, I'll attempt to update them to the proper new tab opening behaviour.

PR #990
pending merge: links on /about/our-team open new tabs now

closed by #990


[SITE BROKEN] dreame.com

dreame.com
Additional information
Download stops after the first 5 chapters.  Manual browsing of the site shows a message to download their app to continue reading.

I don't think there is much you can do about that. The Table of Content only shows 5 chapters total. NG needs a list of chapters to work with.


[Unexpected Behavior] Game opens with a blank, white screen

What you're using
Hello Team Rizu,
My name is Gabriel-minceraft, I am a player of Stepmania since 2019, I make packs and stepcharts.
I have recently taken a break from Stepmania for some months, and then I returned.
I opened the game, and saw a blank, white screen...
Note: the game was working, however the screen is white.

I am using a Windows 7 Home Premium, DirectX 11.
Expected behavior
I was actually expecting Stepmania to actually open correctly, but as I said, the game opens with a white screen.
For any more info tell me.
Gabriel-minceraft, 2021

Hiya!
We need the log files that will be in the /logs folder. Then we will be able to assist you further.
thanks a lot!

any update?


Repair Auto Push Starter Action

Describe the bug
The auto publish of starters action is broken since renaming master branch to main. This is due to action-push-subdirectories action fixed to master branch. I've submitted and issue and a pull request here; https://github.com/johno/actions-push-subdirectories/issues/8.
To Reproduce
Just make a change to one of the themes to trigger the action and we see that it fails; https://github.com/OpenArchitex/gatsby-themes/runs/1340163572?check_suite_focus=true
Expected behavior
Should correctly update the starters based on the theme changes.

This issue has been fixed in the latest version of the publish starters action. 😄


[Frontend] Do not output swiftinterface when there has been errors

When allowing errors with
-experimental-allow-module-with-compiler-errors, do not output the
.swiftinterface when there has been errors. There's no real need to
output them for invalid modules, so this avoids module interface
printing having to have checks for normally-impossible cases.
Resolves rdar://78039608.

Windows failure is unrelated


[Bug] IDX10503: Signature validation failed. Token does not have a kid. Keys tried: ''. Number of keys in TokenValidationParameters: '8'.  Number of keys in Configuration: '0'.

Which version of Microsoft.IdentityModel are you using?
Microsoft.IdentityModel.Tokens 6.24.0
Where is the issue?

[ ] M.IM.Protocols.OpenIdConnect
[ ] M.IM.Protocols
[ ] M.IM.Tokens
[ ] S.IM.Tokens.Jwt

Is this a new or an existing app?
The app is in production and the issue disappears if I restart the Function App, but it can appear quite often.
Repro
var authHeader = AuthenticationHeaderValue.Parse(request.Headers[AuthenticationSchemas.AuthorizationHeader]);

                if (authHeader != null &&
                    AuthenticationSchemas.IsBearerAuthenticationSchema(authHeader.Scheme) &&
                    !string.IsNullOrEmpty(authHeader.Parameter))
                {
                        // Load the tenant-specific OpenID config from Azure
                        var configManager = new ConfigurationManager<OpenIdConnectConfiguration>(
                        $"https://login.microsoftonline.com/{tenantId}/.well-known/openid-configuration",
                        new OpenIdConnectConfigurationRetriever());

                        var config = await configManager.GetConfigurationAsync();

                        _validationParameters = new TokenValidationParameters
                        {
                            // Use signing keys retrieved from Azure
                            IssuerSigningKeys = config.SigningKeys,
                            ValidateAudience = true,
                            // Audience MUST be the app ID for the Web API
                            ValidAudience = expectedAudience,
                            ValidateIssuer = true,
                            // Use the issuer retrieved from Azure
                            ValidIssuer = config.Issuer,
                            ValidateLifetime = true
                        };

                    var tokenHandler = new JwtSecurityTokenHandler();
                    try
                    {
                        // Validate the token
                        var claimsPrincipal = tokenHandler.ValidateToken(authHeader.Parameter, _validationParameters, out var jwtToken);

                        // If ValidateToken did not throw an exception, token is valid.
                        return new TokenValidationResult(
                            GetMsalAccountId(claimsPrincipal),
                            authHeader.Parameter,
                            claimsPrincipal.Identity!.Name);
                    }
                    catch (Exception exception)
                    {
                        log.LogError(exception, "Error validating bearer token");
                    }
                }

Expected behavior
The token is validated successfully
Actual behavior
Token validation is failing with the following error:
IDX10503: Signature validation failed. Token does not have a kid. Keys tried: '[PII of type 'System.Text.StringBuilder' is hidden. For more details, see https://aka.ms/IdentityModel/PII.]'. Number of keys in TokenValidationParameters: '8'.
Number of keys in Configuration: '0'.
Exceptions caught:
'[PII of type 'System.Text.StringBuilder' is hidden. For more details, see https://aka.ms/IdentityModel/PII.]'.
token: '[PII of type 'System.IdentityModel.Tokens.Jwt.JwtSecurityToken' is hidden. For more details, see https://aka.ms/IdentityModel/PII.]'. See https://aka.ms/IDX10503 for details.

@brentschmaltz do you have any ideas what may cause this issue?

We have also just randomly started seeing this since Saturday (27th Jan 2024) with no changes made to our code base. We now see this all the time running Kubernetes with Workload Identities connecting to Azure Storage and SQL.
A pod restart does not make this go away, some requests are still authenticated whilst others fail.

Hello Mark!
I noticed that you've taken down this comment on GitHub. Have you
successfully addressed the issue?
Appreciate it!
чт, 1 лют. 2024 р. о 15:41 Mark Tallentire @.***> пише:

We have also just randomly started seeing this since Saturday (27th Jan
2024) with no changes made to our code base. We now see this all the time
running Kubernetes with Workload Identities connecting to Azure Storage and
SQL.
A pod restart does not make this go away, some requests are still
authenticated whilst others fail.
—
Reply to this email directly, view it on GitHub
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/2469#issuecomment-1921351217,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIVEOR6GK4HR7TPDLGIARUTYROLPZAVCNFSM6AAAAABCRNZYSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGM2TCMRRG4
.
You are receiving this because you authored the thread.Message ID:
<AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/2469/1921351217
@github.com>

we recently got something similar https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/2484
might be same root cause?

@SofiiaRomah first off the error message needs a touch up. In 7.x we marked the variable 'keyAttempted' as nonPII so something meaningful show up.
A service restart would refresh the metadata and keys, so if there were stale keys, tokens would start to validate.
We throw a SecurityTokenSignatureKeyNotFoundException which is a signal to refresh metadata.

@brentschmaltz I've upgraded Microsoft.Identity.Web to version 2.17.0, which now allows us to see the keys in the exception. However, the root cause of the intermittent error remains unclear, and restarting the app service isn't a sustainable solution. Could you give me some more guidance on how to fix this issue?

I ran into the similar exception while working with IdentityServer4 v7. After playing around with package refs, I found out that if I targeted .NET 8.0 and used the below packages
Microsoft.AspNetCore.Authentication.JwtBearer 8.0.11
Microsoft.AspNetCore.Authentication.OpenIdConnect 8.0.11
And by default, those pulled in the following transient assembly
Microsoft.IdentityModel.Protocols.OpenIdConnect 7.1.2  (exact version <IP_ADDRESS>121)
Apparently, there might be some bug with that version. After I added an explicit reference of a version like the below to the main/executing project
e.g., Microsoft.IdentityModel.Protocols.OpenIdConnect 7.5.2 (exact version <IP_ADDRESS>513)
the issue went away. I didn't test with all versions. I just happened to have that version explicitly reference before I decided to remove it thinking .NET 8.0 direct and transient refs would give me that assembly without me have to ref it directly. Found it broken so had to walk back the changes one ref at a time until I narrowed it down to that specific assembly.
One other thing, be sure to clean and rebuild your solution. Just adding the ref without a clean + rebuild won't pull the newer version in :(
Review your situation and give it a try. Hope you have the same and this will solve it. And maybe someone can dig through it and confirm what changed since 7.1.2 to fix it.

@QHQuach Thank you! You just saved me multiple hours of rolling back packages to find the broken one.


[ja] Localize Nodes for Japanese

Describe your changes
Localize Nodes for Japanese
Related issue number or link (ex: resolves #issue-number)
resolves #2719
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@naonishijima
いつもレビューありがとうございます。確認、修正を行いましたので、再度ご確認いただけますと幸いです


CI comparison tool

The task is to compare tools use in continuous integration.

 CI comparison tool

https://github.com/spectre-team/spectre/wiki/CI


No registered env with id: halfcheetah-medium-v2

When I run "python scripts/train.py --dataset halfcheetah-medium-v2", then exception occurred : "gym.error.UnregisteredEnv: No registered env with id: halfcheetah-medium-v2".  And my gym version and mujoco version are all same as environment.yml

This environment should be registered upon importing d4rl, so my guess is that something is wrong with the d4rl installation. You can check your installation by running:
python -c "import d4rl; print([k for k in d4rl.infos.DATASET_URLS.keys() if 'halfcheetah' in k])"

There should be a list of halfcheetah environments printed out.
Alternatively, you can use my docker image with:
docker pull jannerm/trajectory

for something that will work out of the box.


Respring loop iphone 7+ Unc0ver 3.0.0 b46&47&48

The tweaks that make respring loop on iPhone are:
StatusTint (libCSpreferences -libSparkAppList)
Gif2Any(libCSPreference)
Yourspring(libdevImagePick)
libmitsuha

Yourspring or Yourespring?
Yourespring sometimes lock my screen while in the middle of respring. But it’s not because of unc0ver but it’s because of the developers of Yourespring for not updating it to be fully compatible with iOS 11 which resulted in Stability issues.


Test quick pick item icon API

Refs: https://github.com/microsoft/vscode/issues/176049

[x] macOS @TylerLeonhardt
[x] linux @roblourens
[x] windows @sandy081

Complexity: 4
Create Issue

We have finalized the quick pick item icon API. To test the API, you'll need to write an extension that uses quick pick or start from the quick input sample extension. You can see where the sample extension set up some quick pick items here: https://github.com/microsoft/vscode-extension-samples/blob/f7b27a91779e770b8f8f0e6791bcefc5d9c64035/quickinput-sample/src/quickOpen.ts#L73-L84. If you use the sample, you can just try adding an icon to those quick pick items.
This is the new API:
https://github.com/microsoft/vscode/blob/de6839abe8ba06d86bd1f0827dc2b60e53e5dac4/src/vscode-dts/vscode.d.ts#L1736-L1739
Verify:

That you can use the API to add an icon to quick pick item. Try with both a codicon and with a URI.
That the JS doc makes sense.

My silly extension based on https://www.dicebear.com/how-to-use/http-api 😄


Fix package licensing and metadata.

Add license information to empty LICENSE.txt and fix various erroneous metadata in docstrings.

I have rebased these commits so that they will merge cleanly again.
Please let me know if you have any comments or suggested changes.

Hey @martey, sorry about the HUGE delay here. The project is actually supposed to be Apache 2.0 licensed. I cleaned everything up though and re-pushed the latest version to PyPi.


Nterl0k - [T1574] Hijacks Gone Wild 2

Details
Rewrote the previous tstats based search to work solely on EID7, while using backwards compatible evals/extractions in the detection.
It's less efficient cause no tstats, but shouldn't break with TA changes.

Checklist

[ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
[ ] CI/CD jobs passed ✔
[ ] Validated SPL logic.
[ ] Validated tags, description, and how to implement.
[ ] Verified references match analytic.

@patel-bhavin  - I did the thing, enjoy.