Need for Release Notes: What's Changed

With each PnP release there is a need for release notes.  Going through source code and pull request to deduce what has changed is not really an option.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b3240d3-6a7d-fc4b-62fd-d3a5375d8a4a
Version Independent ID: 561212df-4dab-92b7-b634-57d53d313c6f
Content: PnP PowerShell overview
Content Source: sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
Service: unspecified
GitHub Login: @Techwriter40
Microsoft Alias: kirks

@VesaJuvonen Please look at this issue.

PnP PowerShell changes are always covered in our PnP monthly release notes at https://dev.office.com/blogs/pnp-april-2018-update. We have been including all PnP PowerShell changes in our monthly summary for past 3 years and will keep on doing that also in future. You can always also have a look on the changelog.md file at the repository at https://github.com/SharePoint/PnP-PowerShell/blob/master/CHANGELOG.md.
You can follow OfficeDev, SharePoint or individuals in social media to get notified of the new documentation and releases.
If there are some other ideas on where and how the changes should be shared, the input is always welcome. Closing this for now as release notes do exist and have existed for past 3 years.

Thanks @VesaJuvonen

It would be helpful if those release notes were included in the docs.microsoft.com site. This site navigation should have a navigation link to make that content more easily accessed.

@VesaJuvonen i'm confused, it looks like the analyses has already been done and is available at https://github.com/SharePoint/PnP-PowerShell/blob/master/CHANGELOG.md. I'm just suggesting that the changelog page be linked to https://docs.microsoft.com/en-us/powershell/sharepoint/sharepoint-pnp/sharepoint-pnp-cmdlets?view=sharepoint-ps so that it shows up in the master table of contents somehow


Finish cell interactions

Task
Now that the structure of the code is complete we just need to build the game, to start with we should finish the cell, and all interactions involved with it.
Areas and their interactions

[x] Cell
[x] First visit
[x] Return
[x] Combining the sheet and the broken glass
[x] Bed
[x] First visit without the broken glass
[x] First visit with the broken glass
[x] Taking the sheet
[x] Stabbing the bed with the broken glass
[x] Stabbing the bed with the shiv
[x] Returning with the sheet & with the broken glass
[x] Returning without the sheet & with the broken glass
[x] Returning without the sheet & without the broken glass
[x] Returning with the sheet & without the broken glass
[x] Returning with the shiv
[x] Mirror
[x] First visit
[x] Returning with the broken glass
[x] Returning without the broken glass
[x] Taking the broken glass
[x] Door
[x] First visit
[x] Returning
[x] Using fists on the door
[x] Using the broken glass on the door
[x] Using the shiv on the door
[x] Pushing the door
[x] Yelling through the door
[x] Trying the lock
[x] Corridor
[x] Attacking the guard with the shiv or broken glass
[x] Attacking the guard without a weapon
[x] Talking to the guard when he's facing you
[x] Talking to the guard when he's facing away from you
[x] Sneaking passed the guard
[x] Running passed the guard

Done


Do I need connect() from React Redux or should I use store.subscribe()?

Greetings to all of you seasoned Redux veterans!
I'm new to React and Redux but I'd like to get this stuff right before moving on with our project. I've read about connecting presentational and container components but before going there, I'd like to make a simple component that does it all. I have a Header component that should render user's username if user is authenticated. I already managed to successfully login the user using our API and update my immutable Redux store accordingly. So, looking from the surface, the following code works.
The question is whether the following implementation is an antipattern or otherwise 'bad' e.g. performance-wise? Am I allowed to call setState() manually when using Redux? Without the setState() call the component doesn't seem to recognise state changes in store at all. Is there performance (or some other relevant) differences between this implementation strategy and the one that uses mapStateToProps() method with connect()?
// import stuff...
class Header extends React.Component {
  constructor(props, context) {
    super(props, context);
    this.state = {
      isAuthenticated: false,
      username: ''
    }
    let unsubscribe = context.store.subscribe(() => {
      let state = context.store.getState();
      //state is an Immutable.Map
      let user = state.get('login').get('user');
      let newState = {isAuthenticated: state.get('login').get('isAuthenticated')};
      if (newState.isAuthenticated) {
        newState.username = user.get('username');
      }
      this.setState(newState);
    });
  }

  render() {
    let loginStatus = null;
    if (this.state.isAuthenticated) {
      loginStatus = (

Logged in as ({this.state.username})

      );
    }
    return (

        {loginStatus}

    );
  }
}
Header.contextTypes = {
  store: React.PropTypes.object
}
export default Header

This is a good example to understand how React Redux works, but I wouldn’t do this in a real app.

Without the setState() call the component doesn't seem to recognise state changes in store at all

Yes, this is precisely how React works: you must tell it that the state has updated.

The question is whether the following implementation is an antipattern or otherwise 'bad' e.g. performance-wise?

One issue you have there is that you never unsubscribe. You should be unsubscribing in componentWillUnmount.

Is there performance (or some other relevant) differences between this implementation strategy and the one that uses mapStateToProps() method with connect()?

Yes. You don't implement any optimizations. For example, components generated by connect() bail out of rendering if they see that the props returned from mapStateToProps() are shallowly equal to their previous versions.
Have a look at connect() source code. You will see that the idea is the same, but it has a ton of optimizations at different points. In general, it avoids calling your functions or rendering unless absolutely necessary.
I was a guest at this readthesource episode explaining how React Redux works so you might want to check it out.
We definitely recommend using React Redux for best performance instead of rolling your own subscription logic.

Thanks @gaearon.  This was extremely helpful. Have a nice weekend.


Introduce failing test for flattened enums

From: https://github.com/toby/serde-bencode/pull/31#issue-1448971290
By: nrempel
Hello,

This pull request adds a failing test for deserializing flattened structs containing enums.

Is it expected that this test should pass or is there some serde caveat that I'm unaware of here? I'm happy to take a crack at fixing this if it's fixable. Any pointers would be appreciated.

Thanks.

ACK 43ba81eba064959a37447f1fa68a670445c2675c


Edit sequence diagram and activity diagram images

Change the params if they are too long + update the images to most updated implementation

create sequence diagram and activity diagram for show command


ezmomi status' can show more VM info & new way to print the output (a 'grep' firendly one)

In this pull request contains 2 changes

'ezmoni status' has one extra parameter named '--extra' which will print multiple VM details.
2 added a new '--parserFriendly' parameter for 'ezmomi status'.

Some comments related with those changes:

I've tried to use the same code style in my changes, if I've failed to do that, please give me some feedback and I will try to fix that. you will see that I've used 'sys.stdout.write' instead of 'print'. The reason is this: http://stackoverflow.com/questions/255147/how-do-i-keep-python-print-from-adding-newlines-or-spaces . For python2 I don't see a simpler way to do that without to confuse others.
I've changed the 'tabulate' name to 'print_as_table' since I've added another way to deliver the output 'print_as_lines'.

All those changes were done based on my actual needs. I hope that they help the community.
I hope this one will pass PEP8 checks.

Thanks @ciorceri for the great contributions. I'll take it for a spin today or tomorrow and get back to you.


Revert "v4l2: Stream CAPTURE queue during initialisation"

Commit 7a36a4225fe022cf72a0e7c70036c4c5ff73f547 is no longer required as https://github.com/bbc/linux/commit/7792edd663040e7751375a36b16092b6aea28299 fixes #11.
Resolves: #11, #25, #29, #32

Testing needed for #29. All other issues have been tested successfully.

Merging as three of the tests have passed. Will close #29 separately if it fixes it too.


Redesign Footer for Improved User Experience

The current footer section is taking up excessive space on the page and is not visually appealing. The design is cluttered and lacks clear navigation, potentially hindering user interaction. To enhance the user experience, we propose redesigning the footer to be more compact, visually appealing, and user-friendly. This involves reducing the amount of content, reorganizing elements for better clarity, and incorporating more intuitive navigation options. By implementing these changes, we can create a footer that is both functional and aesthetically pleasing, contributing to a more positive overall user experience.
I would love to work on it , as for the pas days I have been working on GSSOc repos and Hacktoberfest ones to contribute. Thanks

Sure @kekubhai assigning the issue to you,
Kindly provide an image of the design you would like to add then send a PR

I was thinking of adding an bg to the footer with this this :

I guess It would go great, tell me what you like or adding a starry theme footer bg will be good ?

Ummm, not this one, can you find something new and unique. It will make the website heavier and slower.

Yeah you are right right . I guess I will find some great static designs and when I am done I will show you how it looks, ASAP

hey there , Check this one :

I guess this goes good with the UI and the overall background. Should I add a PR ?

Okay this one looks better @kekubhai.
Update this one

Good to hear that you liked it.  Raising a PR . Thank you.


a suggestion

First of all, a great website! Makes bedrock map artists jobs so much easier. But for the suggestion, there's already a software that lets you convert any structure block files into texture pack, which you can enable, place armour stand and it lets you see where to place blocks for a build, or map art.
( https://ravinmaddhatter.com/2022/09/14/structura-1-5/ , https://github.com/RavinMaddHatter/Structura/releases/tag/v1.5Beta )
but the process of taking structure block copies of a map art and then running them through the app is impossible on mobile, and slightly confusing on pc to people that have never used the app before. So would it be possible to somehow work with Ravinmaddhatter, and implement that as a feature to your website? It would make server/survival map art making so much simplier.
Picture below what it looks like. Structure blocks have some limitations though. for a 2d 128x128 map art you need to make               2x 64x42 and 64x43 4 times, even then the right bottom corner sometimes gets unrendered. for a 3d map i think you'd need at least 8 texture packs.

Thanks for the suggestion !
It sounds like a great idea - and will make the building process without commands much easier.
I'm assuming that if there was to be an extension to either app that added this functionality, it would be simpler to remove the structure block format as an intermediary, and communicate which blocks to highlight where in another way, since in both apps the purpose of some code will only be to decipher this from other formats (an image in my case, or the mcstructure file in Structura), and that gets rid of these restrictions and more processing/conversion etc...
Though, as a side note, as I wrote in a few places around the website, I haven't been getting too much free time lately to devote to this, which started just as a one-time hobby project 😅. So it may be a while before I consider starting work on something like this.
I'll leave this post open for now so that anyone else who comes across the site and has some know-how about the minecraft structure file and JSON geometry file definitions & format etc, can comment if they're interested. Pull requests and contributions are welcome!


fix(pdk) plugin closure syntax correction

fix https://github.com/Kong/kong-python-pdk/issues/28
Drafted using the new-instance method as a template.
Tested in a sample instance of kong.
I don't see any unit testing in this library; have I missed it somehow?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@wjziv Tests for python PDK are planned work but not yet prioritized, PRs are welcomed in the meanwhile!

Thank you @wjziv !


Add IPIP tunnel mode

Currently, the following two tunneling options are available.

Protocol
Max MTU

VXLAN
1450

Routing
1500

The VxLAN option is easy to configure, and doesn't require a secondary dedicated subnet. A limitation of the VXLAN option is MTU size.
Calico, a widely used CNI plugin, has following three options for inter-node communication.

Protocol
Max MTU

VXLAN
1450

IPIP
1480

None
1500

The None option has no limitation regarding MTU size, but requires access to infrastructure routers for cross-subnet communication. Due to this reason, the IPIP option is widely used, and its max MTU size 1480.
When we combine Calico IPIP with the cloud-api-adaptor VXLAN tunnel, the MTU size becomes 1450, which is 30 bytes smaller than that without peer pods. (https://github.com/confidential-containers/cloud-api-adaptor/issues/67)
To improve the performance and compatibility, we also need to implement the IPIP tunnel option in cloud-api-adaptor.

@yoheiueda is this issue still relevant or can be closed?
If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?


Details pane flips to the left instead of the top

Testing #109394
See screen cast. I would have expected the details pane positioned to the top than to the left since it was position to the bottom before.

I would have expected the details pane positioned to the top than to the left since it was position to the bottom before.

We don't use top because that's the potential place for signature help

Agree.


Add coalesce_0 macro

Adding a coalesce_0 macro - I use this pattern often in my own project when I've left joined a table and want to map nulls to 0s without changing the column name.

Just realised I forgot to add a readme. brb.

I'm going to close this, as it's a kimball-specific thing that warrants other kimball-specific things. I'd love to create a package for all types of dimensional modeling macros! But I don't think they all belong in dbt-utils.
@clrcrl let me know if you want to discuss how to make that happen! I actually don't think it's something that fishtown analytics should own :)


corrected false claims in README.rst

Now, the fastest pure-Python markdown parser is: https://github.com/Al-Caveman/cavemark

It’s not full featured.

But that's not your claim.  Your claim is broader "fastest pure-Python markdown parser", regardless of the features set.
If you want to be specific to certain features set, then kindly narrow down your claims to the features set of interest.  Else, your claim is false.
Note about features: "Markdown" is a general term that does not dictate a specific features set.  "Common Mark", on the other hand, dictates a specific features set, but not even "mistune" is compliant with "Common Mark".  "mistune" also lacks some features that are in CaveMark.

reminder.  either:

update ur claim.
restrict ur claim by specifying the features set.


fix(boilerplate): Podfile update for hermes-engine

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant

Describe your PR

Fixes vanilla Podfile.lock for hermes-engine

:tada: This PR is included in version 8.8.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Debugger: Cannot specify configuration, that is debugger always loads ../bin/Debug/*/whatever.dll

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.0-preview2-003121)

Product Information:
 Version:            1.0.0-preview2-003121
 Commit SHA-1 hash:  1e9d529bc5

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.11
 OS Platform: Darwin
 RID:         osx.10.11-x64

VS Code version:
1.2.1

C# Extension version:
1.2.1

I have some tests that fail only on osx and linux in release builds running on CoreCLR. I cannot get the debugger to attach to release artifacts in ../bin/Release/netcoreapp1.0/ folder.
I have to tried to make 'build' task only build configuration=Release. But 'codelens' run test and debug test, seems always to run tests with configuration=Debug. And I cannot get F5-debugging to work with this canonical './src/library', '/.test/library.tests' repo tree.
I have commited .vscode folder together with the rest of my code here
task 'failingtest' is a failing test (-method switch shows test method) that I cannot debug with the omnisharp debugger extension.
Related to #455, especially this comment

Hi, it appears that this issue has gotten stale without a response from us. Our apologies!
It looks like you've mentioned a few issues above:

Unable to get F5 debugging to launch on Release artifacts
Unable to get "debug test" to work on Release artifacts

The second is issue is something we don't support today. However, I'm curious if you were every able to get the first issue working.


fix(masthead): remove unnecessary aria-label

Related Ticket(s)
[Masthead]: Screen reader announces the landmark label as "Nav LTR" which is not meaningful #8853
Description
the top-nav aria-label is unnecessary and should be removed to not confused the user.
Changelog
Removed

aria-label from top-nav

Now the unnecessary labels are not announced by the screen reader


Move wiki to github or wiki.ia

A lot of the info on the trac wiki has become outdated or invalid with the passage of time. If we want to copy over the info, we have to be selective in what we need to copy over.

Started writing some new Getting Started guides at https://wiki.ia.utwente.nl/index.php/WWW:Main

@Kurocon TRAC has been removed, right?


stitch: Get github sshkeys with get request instead of github api

This patch makes a get request to github for sshkeys instead of using their api. This should solve the github api key rate error problem as you can curl their site for the keys seemingly without limit.

Make sure you run gofmton your edits (or make check)
The build failed because your import statements are not alphabetically ordered

Thanks for the help. I just realized that as well.


Handle missing CGM time change record for 5/7-series

See attached Trello card for details.

 Missing CGM time change records for 5/7-series

 After a 24-hour temp basal, resuming scheduled basal sometimes missing in 5/7-series pump history


Changed the code in README.md to the latest version

Hi, I had to modify the code in README.md to get it to working.
In addition, I believe you also need the vonage/jwt package.
https://github.com/Vonage/vonage-php-sdk-video/compare/0.x...oooooooo:vonage-php-sdk-video:fix/readme?expand=1
Please also update the following documents. 📝
https://developer.vonage.com/en/video/server-sdks/php

done, thanks for reporting


Debug display fix

Need to test it manually as all transaction hash giving error
cannot find 'hash' of null

Everything is working in my testing except this. Maybe problem with ReactDiffViewer


📊 wb: Update World Bank PIP to version 20240326

Main issue https://github.com/owid/owid-issues/issues/1475
Datasets on staging:
2011 PPPs: http://staging-site-update-world-bank-pip-0324/admin/datasets/6447
2017 PPPs: http://staging-site-update-world-bank-pip-0324/admin/datasets/6448
The pipeline is the same as the one in the January update, so it should not be reviewed that thoroughly

@Marigold Hi! Is there any reason for explorer files like http://staging-site-update-world-bank-pip-0324:8881/explorers/wb/latest/world_bank_pip/income_consumption_2017_headcount_ratio_3000.csv not being updated? I want to check some changes and I can't see them.

@paarriagadap the reason was that ETL on the staging server was failing. It was because one of the downloaded snapshots was corrupted (this is the first time this happened, I'll be keeping an eye on it. Deleting it and recreating helped).
ETL on the staging server is green again, and explorer files should be updated accordingly.


Added cloud firestore, auth, lists, updates and Bottom navigation

I have added most of the part i had done. These include, firebase authentication, listing the items in homepage, editing those items, added bottom navigation for profile and search page.

really a lot of changes to a lot of files in one commit, I am lost


refactor pngwriter

This makes the PngWriter class stateless, which makes it much, much easier to reason about. Now it just keeps track of the outdir, tells you what the next unused prefix is, and actually writes the files (and metadata) to disk. It doesn't know anything about seeds, upscaling, or auto-incrementing; it is the caller's responsibility to handle that sort of thing.
In passing, I've made it so that when the "save originals" option is selected for upscaling, the images are saved as "00001.seed.png" and "00001.seed.postprocessed.png", which I think is more useful than 01. (I don't actually have upscaling set up, so I haven't tested that part.)
I haven't made any changes to the actual metadata, but I'd like to do so. In particular, the fact that we're storing structured data as an unstructured string makes me unhappy; we should at least be JSON-ifying it. (Then the web UI could reasonably extract the metadata from an existing image, which would be handy - firing up the script for that is painful.) But I'll worry about that in a later PR.
Also, the metadata for grid images could be improved - it could store the data for each image individually, so that you could extract the information for just one image and re-run that. But again, something for a later PR.

That's a very reasonable motivation. Happily it's achieved by the design in this PR as well - this PR does exactly the same listdirs as before.


Make flyouts "viewport aware"

On viewports where there is not enough vertical space, the flyouts from the toolbar are cut off at the bottom (see image below). They should be "viewport aware" and align vertically so they don't get cut off. This would most likely mean adding some form of arrow or other UI visualization to indicate which toolbar item the flyout belongs to.

Is anyone working on this issue or I create a PR for this ?


moduleDeps don't work with PublishModules

It seems to be caused by this upstream Mill issue https://github.com/com-lihaoyi/mill/issues/2082

Fixed upstream in Mill.
Please update to 0.10.8-9-dd81ad.


Alpha working cicd.yml

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Transaction with query version executes successfully Instead of throwing error

Describe the bug (observed vs expected behavior)
Currently, the devnet allows the execution of a transaction that is meant to be used for fee estimation instead of throwing an error.
Not reproducible on alpha-goerli

[X] This issue is only present on Devnet and cannot be reproduced on alpha-goerli (check the box if true).

To Reproduce
Steps to reproduce the behavior:

Create any Invoke/Declare/DeployAccount transaction.
Sign the transaction off-chain for fee estimation. Use the query version (version + 2**128), for example 0x100000000000000000000000000000001.
Proceed to execute the transaction as if it's a normal transaction.
At this point, the process should produce an error. However, it successfully completes the execution instead.

Devnet version

I am using Devnet version: ebd9f85

System specifications

OS: MacOS M1

Hey @ddoktorski did you send the transaction to endpoint add_<declare/invoke/deploy_account>_transaction ?

Only_query value of a transaction, must be based on transaction version. Not hardcoded in endpoints. Whether an error should be returned or not TBD

Hi @marioiordanov

did you send the transaction to endpoint add_<declare/invoke/deploy_account>_transaction ?

If you're referring to method names that exclude underscores, such as addInvokeTransaction, then yes that's correct. If you meant something else, please let me know.


update dependency on libsodium-sys for 0.2.5 release

Pull Request Test Coverage Report for Build 1170

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.041%

Totals

Change from base Build 1168:
0.0%

Covered Lines:
3009

Relevant Lines:
3166

💛  - Coveralls

bors: r+


feat: port Firebase Web Push config

Signed-off-by: Otieno Calvine<EMAIL_ADDRESS>Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Codecov Report

Merging #3 (50cc836) into main (17eabe9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   65.65%   65.65%
=======================================
  Files           7        7
  Lines         396      396
=======================================
  Hits          260      260
  Misses         98       98
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eabe9...50cc836. Read the comment docs.


Add pre-processing to sanitise operation names.

Add pre-processing to remove mutilated names from the generated method types.

First of all, this is seriously awesome! Thanks for working on this. I'll do some testing and review later today.
The first thing that comes to mind is how we plan on handling a version upgrade to the Hubspot API in the future. For example, what happens when this get-/crm/v3/objects/companies_getPage changes to this get-/crm/v4/objects/companies_getPage. Previously, this would result in separate functions in the generated code, but that would not be the case with these adjustments. Maybe a tagged version scheme like 3.0.0 where the major version would follow the Hubspot API version, and the minor/patch versions follow internal updates and patches to this library.
I'll need to noodle on that a bit more, any ideas would be appreciated.

If I'm honest, it was probably a little premature of me to open a PR at this stage, as I've done very little testing myself. Was more interested in getting some initial visibility and making sure the approach would be acceptable before investing any time in it. Thanks for the positive feedback - sounds like there's a path forward once we iron out some of the details.
The first thing that comes to mind to solve the versioning issue would be to append the API version number to the generated output path, so when importing you would reference say github.com/clarkmcc/go-hubspot/generated/v3/companies instead of just github.com/clarkmcc/go-hubspot/generated/companies. It would also probably make sense to do a fuzzy match on the operationId to ignore the version number. I'll get something up for these soon!

@erlendp No problem! I did notice that only a few types were supported, and I do think it makes sense to support all the API types before we merge this PR. Once this gets closer to being ready to merge, we can implement it for the rest of the API types.
I do think this is a much-needed change so let's keep moving forward.

@clarkmcc Fixes pushed as discussed. All that's outstanding now is to add the remainder of the API methods.

@erlendp Awesome! I'll take a look.

Okay, everything looks great so far. A few todo items:
Update the README.md
Under this section in the documentation, we refer to the mutilated method names generated by openapi-generator, we can remove this line, and it would be helpful if you could provide an example illustrating how to use different API versions. The versioning approach seems great and callers should be able to just grab the version they want based on import paths.
https://github.com/clarkmcc/go-hubspot/blob/4779d52d088f7e9e2163240cccd4657ca3894237/README.md?plain=1#L17-L20
Add the remaining API methods
A quick regex ("\/crm\/v[0-9]\/.*") pulled back this list of API methods that need to be re-written.

There are just a couple of outstanding methods that I'll add shortly, but getting pretty close I think.

@clarkmcc Should all be good to go now!

Thanks! This is an extremely valuable contribution to the project.


docs: clarify some of the bits

This is the result of my experiments with different settings of
LineaMatic.

Thank you @jbenc.
I'm not 100% sure, but i guess the following.

Relay 03 on UAP1 equals the HOR1 (Hörmann Optionsrelails) in functionality.
The 2 unkown pins on the bus connector are used to control the HOR1, because HOR1 seems to just consist of two connectors, two diodes and one relay.

* The 2 unkown pins on the bus connector are used to control the HOR1, because HOR1 seems to just consist of two connectors, two diodes and one relay.

That's an interesting thought and makes a lot of sense. I haven't seen HOR1, I wondered whether there's a processor there. Now I wonder whether UAP1 makes use of those two wires to control relay 03 or whether it's driven by the protocol :-)
Would be interesting to (1) verify that those two pins indeed correspond to the relay and (2) look at how UAP1 is wired. I don't have the two pins connected in my test cable; maybe I'll make another cable and check with an oscilloscope later. As for (2), my UAP1 is physically built into my home automation in a way that removing it to explore the wires is not really something I'd like to do.
Thanks for the thoughts!


Issue : Ensure Segment Server closes all idle connections.

Change log description
Ensure Segment Server closes all idle connections.
Purpose of the change
Fixes #issue
What the code does
After a client establishes a connection it sends periodic keepAlives to the server
This ensures the connection does not timeout and it also enables early detection of connection failures.
During the investigation of issue 3900 it was observed that none of the connection was not dropped and
neither were the messages delivered to the Segment store on time.
This PR ensures the Segment store detects such idle connections and ensures such connections are closed. In this PR we are choosing an idle timeout of 100 seconds. i.e. connections where writes and reads do not happen for more than IDLE_TIMEOUT_SECONDS  are closed by the IdleStateHandler.
The only open point with this approach is the the following issue
https://github.com/netty/netty/issues/8912#issuecomment-486633037.
How to verify it
Verified that the channel is infact closed after the idle timeout.

If you look at FlowHandler you can see it already has a RecentMessage boolean tracker. This used to be used to time out the connection. Perhaps we should restore this mechanism?


1.10, Capacitor Bank not adapted to newer Baubles versions

Currently on EnderIO 1.10.2-<IP_ADDRESS>_beta, the Capacitor Bank GUI needs to be updated with the three new Baubles' slots.

How did you get it to work with that? Last time I had a look, the crash was rather extreme...


General Data Protection Regulation(GDPR) Complaince

Is your feature request related to a problem? Please describe.
We need to make app comply with GDPR to legally enable this app in EU. We need to review user tracking, user details storage, deletion policy etc
Describe the solution you'd like
Need to evaluate to potential violations first.
Some possible violations:

[ ] Do I need to collect this data for the scope of my business (and not to sell it to third parties)?
[ ] Has my user been warned and affirmatively consented (filled a not-pre-filled checkbox, for example) that I’ll be collecting this data and why I need it, how I’ll use it and who it will be shared with?
[ ] Have I given my user a way to update this data by themselves?
[ ] Have I given my user a way to withdraw their consent and by doing so stopping all processing of their data?
[ ] Have I given my user a way to delete all data we have collected from them permanently and notify third parties not to process their data further?
[ ] Have I given my user a way to download/export all their data in an industry standard format (.json, .csv, .xls, etc.)?
[ ] Have I recollected consent from all users previous to the GDPR deadline?

Are you working on this? (Yes/No)
No

Yes, thank you for creating this issue.

I will consult an expert in college regarding this and get back.

https://medium.com/@thiagoko/gdpr-checklist-for-small-business-and-startups-who-want-no-trouble-1de5cc08be45

Do I need to collect this data for the scope of my business (and not to sell it to third parties)?
Has my user been warned and affirmatively consented (filled a not-pre-filled checkbox, for example) that I’ll be collecting this data and why I need it, how I’ll use it and who it will be shared with?
Have I given my user a way to update this data by themselves?
Have I given my user a way to withdraw their consent and by doing so stopping all processing of their data?
Have I given my user a way to delete all data we have collected from them permanently and notify third parties not to process their data further?
Have I given my user a way to download/export all their data in an industry standard format (.json, .csv, .xls, etc.)?
Have I recollected consent from all users previous to the GDPR deadline?

These are some of the checks we need to do to be GDPR compliant.

@vik-y @tachyons do you have any inputs?

We also need to automatically delete the user's data after a specified amount of time (like 3 years for example), but that could be impractical for analytics (such as how many users we have had).

Maybe we should just remove all personal data (e.g. names, emails, etc.) but keep the ghost account? Otherwise we can just delete the whole thing.

As far as I'm aware we don't really send data to third parties so that isn't an issue.
If we ID users through an email ID like @satu0king said it might be better to replace it with a randomly generated number or string
We should have a GDPR account page where a user can choose to manually delete their account and also export their data through CSV

Theoretically this should just be a case of exporting/deleting all the data from the users table and any rows where the users' ID is referenced

@satu0king said we should have a field in the users table saying if they have consented to the policy which is good for tracking existing users' consent, but technically if they haven't consented we shouldn't actually be storing their details in the first place.

Have this as a mandatory checkbox in the signup/registration form as well
Once this is implemented we should notify all users that they need to consent to the privacy policy in a certain time (e.g. 2 months), otherwise their account will be deleted

As a sidenote I noticed that the password field in the database is called encrypted_password. I couldn't find where this is set in the controllers code, however if passwords are only encrypted they should urgently be changed to being securely hashed instead.

encrypted_password actually stores hashed password with salt, it is done using bcrypt algorithm

Ok @tachyons that's fine, just checking

Here in, CircuitVerse we don't get any terms and conditions or any consents filled before signing up. I think we should focus on having that. I think there are websites that help making terms for other websites. Also, do we even have any delete my account feature?

Here in, CircuitVerse we don't get any terms and conditions or any consents filled before signing up. I think we should focus on having that. I think there are websites that help making terms for other websites. Also, do we even have any delete my account feature?

There currently isn't a delete account feature on the production website

I think for us to make people agree to the terms we need to give them this option. Also, we have to make sure that after deleting all their data is deleted. Do we plan on deleting their public circuits also? Is there some provision that some data is kept and other gets deleted and still it follows GDPR?

I think for us to make people agree to the terms we need to give them this option. Also, we have to make sure that after deleting all their data is deleted. Do we plan on deleting their public circuits also? Is there some provision that some data is kept and other gets deleted and still it follows GDPR?

I think we can keep some data as long as it isn't personally identifiable and more for analytics purposes (like how many users the platform has had, total number of circuits, etc.) but it's probably better off and safer just deleting their whole account.
If they want to delete their account their public circuits should also be deleted

But then we have to decide that people who have replicated that circuit as in shared it on their account or like if the teacher deletes his account then students associated with the assignment, they shouldn't be left hanging. So the deletion process has a lot of details we should consider. Lets list all the pointers with solutions and various cases including above points that @tachyons has mentioned @JoshHeng .

But then we have to decide that people who have replicated that circuit as in shared it on their account or like if the teacher deletes his account then students associated with the assignment, they shouldn't be left hanging. So the deletion process has a lot of details we should consider. Lets list all the pointers with solutions and various cases including above points that @tachyons has mentioned @JoshHeng .

Forked circuits should just become independent circuits. For teachers, I think the assignments should just be set to be issued by a 'deleted user' (i.e. just have the user id on the database blank)

Lets try to write all the points in one comment and look for best solutions from our side. So like pick the first point and research on net and come to a solution, suggest it. Lets discuss first if there is some confusion and then we can focus on making a full comment including everything. As of assignments, they are submitted after a deadline is reached so we can't keep that id blank. What we can do though is discard the assignment and notify students that its no longer available. Lets organize all points in one comment first. Otherwise we'll have 20-30 comments of random discusssion. Though if something is unclear we can obviously discuss that. Okay? I am reading all the points myself so if you get stuck we can discuss here/on the dashboard 😊

This is a issue need research which includes some legal help. If someone can do the research and list out the things to be done for GDPR compliance, that will be great

Notes

All of GDPR must be fulfilled as CircuitVerse offers service to people in the EU and/or is based in the EU.
Not fulfilling it can lead to a huge fine.

Principles

Consent: All new and existing users must directly give consent to the storage of their personal data. They must also be able to easily withdraw it. The GDPR notice must be clear, transparent and concise.

There should be a mandatory consent checkbox that the user has to tick when they register.
Existing users should be sent an email asking for consent. If they don't respond or don't accept within 2 months, all their data should be deleted.

A database column will need to be created recording this, probably recording the date they consented.

Fair Processing Notices: The privacy policy must explain what personal data is stored. The user must also be aware that their consent may be withdrawn, the rights they have and how to complain about GDPR.

We need to have a clear privacy policy easily accessible on the website. This must include the Google Analytics privacy notice.

Type Of Personal Data Stored: Any personal data stored must be fully justified and necessary. This data cannot be used for any other purpose than what it was originally collected for.

This shoudn't be a problem as as far as I'm aware we already do this.

The Period Personal Data Can Be Stored: Personal data should only be stored for as long as is necessary, and not permanently.

We may need to automatically delete users after five years if there is no activity and they have not responded to warning emails

Users Can Have Their Data Deleted: Any user can request to have all their data deleted and it must be done so within a reasonable timeframe

There must be an option for a user to have all their data permanently deleted. This probably includes all their circuits and tasks, so CircuitVerse must be able to handle this.

Personal Data Must Be Accurate And Up To Date: Personal data should be as accurate and up-to-date as possible. This includes giving the user the ability to update their data if they need to

Users can already update their data themselves but they need to be able to change their email

Users Can Request To Have A Copy Of All Their Data: Any user can request to have a copy of all their personal data, which must be provided

We should have an option for all of a users' data to be emailed in a CSV format. This is probably only the user row in the table, any references to the user ID in the database (such as circuits), etc.

Data Must Be Stored Securely And Safely

Only certain people should be able to see all the personal data, and only if absolutely necessary
It might be worth encrypting email addresses along with creating a blind index hash (used for logging in and comparing an email address to the ones in the database)

Personal Data Breach: Organisations must notify the authorities/local data protection regulator within 72 hours of a breach. If the breach is high risk, all individuals must also be notified. A personal data breech register must also be kept internally.

We should keep things secure to avoid a breach, and be aware of who we need to report a breach to if a breach does happen (this probably depends on where the founder/main person running CircuitVerse is located)

Third Parties & The Transport of Data: Personal data cannot be exported outside of the European Economic Area unless the destination country has adequate data protection safeguards.

This shouldn't be a problem as we don't have any third parties

I think that Google Analytics (and other analytics) don't need specific GDPR action/consent (apart from cookie notices) as they do not store personally identifiable data

Its not just for EU , India has adopted these measures, so it'll work. As far as I know there is one issue which discusses that not all the fields are filled by the user when they register. So that can be

The first step that we fill all the data.
Then we can ensure that we give them a checkbox option for their data usage.
We can ensure we bring up a delete my account feature.
We can make sure that the loose ends including Public circuit being used by other users or teachers who made assignment are fixed.
The point where their csv(and other forms) data has to be given to them when they ask for it, requires some work too.
We should also focus on setting a time frame as @JoshHeng mentioned.
Data transfer across borders should be save, so this has to be made sure too.
The data we have collected should be anonymized so as to prevent misuse.

Articles 17 & 18 – Articles 17 and 18 of the GDPR give data subjects more control over personal data that is processed automatically. The result is that data subjects may transfer their personal data between service providers more easily (also called the “right to portability”).
Article 35 – Article 35 requires that certain companies appoint data protection officers.
Article 79 – Article 79 outlines the penalties for GDPR non-compliance, which can be up to 4% of the violating company’s global annual revenue depending on the nature of the violation.

@tachyons I think @JoshHeng did his research work. I filled up where ever I felt it was required. Should I go ahead and approve his task?

FYI there is no proper data protection laws in India

FYI there are no proper data protection laws in India

https://economictimes.indiatimes.com/tech/internet/the-india-draft-bill-on-data-protection-draws-inspiration-from-gdpr-but-has-its-limits/articleshow/65173684.cms?from=mdr
https://thenextweb.com/asia/2019/07/30/india-to-seek-eus-approval-on-gdpr-compliance-for-adequacy-status/
Though strangely its not effective and fails to account various measures. India is trying to execute proper laws. Lets hope it happens soon @tachyons

Article 35 – Article 35 requires that certain companies appoint data protection officers.

Under the GDPR, you must appoint a DPO if:
- You are a public authority or body (except for courts acting in their judicial capacity);
- Your core activities require large scale, regular and systematic monitoring of individuals (for example, online behaviour tracking); or
- Your core activities consist of large scale processing of special categories of data or data relating to criminal convictions and offences.
I don't think we need a DPO

@JoshHeng We don't. If you go through these articles, they'll specify that these are the most important articles that should be taken care of, if not then it might lead to article 79. @tachyons should I approve the task?

Is this task added to GCI already ?

Yes it was added long back, with aim of just researching and providing solutions

https://docs.google.com/document/d/1x_DZx3ruqdcsQNMZPHLftjH7DpT2_4t2ZSpwopENFHY/edit?usp=sharing

I think I should mention it here
This issue is blocked by: #849. It is needed to fully implement deleting the account or downloading user's information.

@aayush-05

Basically we require an export script for user's data and some changes to the Privacy Policy/TnC reflecting new additions. Rest all is covered.


open bundled quest in editor

could make development a bit more friendly

only for dev

postponed, when I really need to rework a quest


add QuoraQP dataset and demo files.

#649

These files qp_test_demo.csv and qp_train_demo.csv are not necessary for the project. The users are assumed to download the dataset by themselves.

These files qp_test_demo.csv and qp_train_demo.csv are not necessary for the project. The users are assumed to download the dataset by themselves.

These files are used in test, should I delete them? or move them to tests/?

Codecov Report

Merging #650 into master will decrease coverage by 0.16%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
- Coverage   94.32%   94.16%   -0.17%
==========================================
  Files          60       61       +1
  Lines        2169     2228      +59
==========================================
+ Hits         2046     2098      +52
- Misses        123      130       +7

Impacted Files
Coverage Δ

matchzoo/datasets/quora_qp/load_data.py
80% <80%> (ø)

matchzoo/models/drmm.py
100% <0%> (ø)
:arrow_up:

matchzoo/models/drmmtks.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff628f0...129caba. Read the comment docs.

Wait, why master? I thought we agreed that master won't have any new features.

Please open another merge pull request and merge to 2.1-dev.

I changed the base branch of this issue.


[5.1][03-18-2019] Parseable interface cherrypicks from 5.1

Various parseable interface cherry-picks.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 95e5be77f4f3b74d3c574bb869f592be20c31a91

Build failed
Swift Test OS X Platform
Git Sha - 95e5be77f4f3b74d3c574bb869f592be20c31a91

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 95e5be77f4f3b74d3c574bb869f592be20c31a91

Build failed
Swift Test OS X Platform
Git Sha - f00d150db9f05330a0d5a45bb1a0e74573d84c1b

@swift-ci please test OS X Platform

Build failed
Swift Test OS X Platform
Git Sha - f00d150db9f05330a0d5a45bb1a0e74573d84c1b

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f00d150db9f05330a0d5a45bb1a0e74573d84c1b

Build failed
Swift Test OS X Platform
Git Sha - f00d150db9f05330a0d5a45bb1a0e74573d84c1b

Is this good to merge?


Add generation of apiserver-builder executables, .deb and .rpm packages in build/.

This PR creates apiserver-builder executables for darwin-amd64, linux-amd64 and windows-amd64 in build/ via make build:
metmajer$ tree build/
build/
├── darwin-amd64
│   └── bin
│       ├── apiregister-gen
│       ├── apiserver-boot
│       └── apiserver-builder-release
├── linux-amd64
│   └── bin
│       ├── apiregister-gen
│       ├── apiserver-boot
│       └── apiserver-builder-release
└── windows-amd64
    └── bin
        ├── apiregister-gen.exe
        ├── apiserver-boot.exe
        └── apiserver-builder-release.exe

Additionally, it enables the creation of .deb and .rpm packages using jordansissel/fpm in build/ via make packages:
metmajer$ tree build/
build/
└── linux-amd64
    └── pkg
        ├── apiserver-builder_0.1-alpha.14_amd64.deb
        └── apiserver-builder_0.1-alpha.14_amd64.rpm

The version number is now stored in VERSION for better version management.
Debian Package
Information
ubuntu@ubuntu-xenial$ dpkg-deb -I apiserver-builder_0.1-alpha.14_amd64.deb
 new debian package, version 2.0.
 size 5705424 bytes: control archive=579 bytes.
     422 bytes,    11 lines      control
     292 bytes,     4 lines      md5sums
 Package: apiserver-builder
 Version: 0.1-alpha.14
 License: Apache-2.0
 Vendor: kubernetes-incubator
 Architecture: amd64
 Maintainer: The Kubernetes Authors
 Installed-Size: 17381
 Section: default
 Priority: extra
 Homepage: https://github.com/kubernetes-incubator/apiserver-builder
 Description: apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types.

Installation
ubuntu@ubuntu-xenial$ sudo dpkg -i apiserver-builder_0.1-alpha.14_amd64.deb
Selecting previously unselected package apiserver-builder.
(Reading database ... 53918 files and directories currently installed.)
Preparing to unpack apiserver-builder_0.1-alpha.14_amd64.deb ...
Unpacking apiserver-builder (0.1-alpha.14) ...
Setting up apiserver-builder (0.1-alpha.14) ...

ubuntu@ubuntu-xenial$ ls -la /usr/local/bin/
total 17396
drwxr-xr-x  2 root root    4096 Sep 15 18:31 .
drwxr-xr-x 10 root root    4096 Sep 15 18:31 ..
-rwxr-xr-x  1 root root 7894084 Sep 15 18:30 apiregister-gen
-rwxr-xr-x  1 root root 5598073 Sep 15 18:30 apiserver-boot
-rwxr-xr-x  1 root root 4306566 Sep 15 18:30 apiserver-builder-release

ubuntu@ubuntu-xenial$ file /usr/local/bin/apiregister-gen
/usr/local/bin/apiregister-gen: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

RPM Package
Information
vagrant@fedora$ rpm -qip apiserver-builder_0.1-alpha.14_amd64.rpm
warning: ./apiserver-builder_0.1-alpha.14_amd64.rpm: Header V4 RSA/SHA1 Signature, key ID c1cbfc12: NOKEY
Name        : apiserver-builder
Version     : 0.1_alpha.14
Release     : 1
Architecture: x86_64
Install Date: (not installed)
Group       : default
Size        : 17798723
License     : Apache-2.0
Signature   : RSA/SHA1, Fri 15 Sep 2017 06:38:50 PM UTC, Key ID b8495724c1cbfc12
Source RPM  : apiserver-builder-0.1_alpha.14-1.src.rpm
Build Date  : Fri 15 Sep 2017 06:38:50 PM UTC
Build Host  : martins-macbook-pro.local
Relocations : /
Packager    : The Kubernetes Authors
Vendor      : kubernetes-incubator
URL         : https://github.com/kubernetes-incubator/apiserver-builder
Summary     : apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types.
Description :
apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types.

vagrant@fedora$ rpm -ihv apiserver-builder_0.1-alpha.14_amd64.rpm
warning: apiserver-builder_0.1-alpha.14_amd64.rpm: Header V4 RSA/SHA1 Signature, key ID 8f0e18b6: NOKEY
Preparing...                          ################################# [100%]
Updating / installing...
   1:apiserver-builder-0.1_alpha.14-1 ################################# [100%]

vagrant@fedora$ ls -la /usr/local/bin/
total 17216
drwxr-xr-x.  3 root root    4096 Sep 15 20:20 .
drwxr-xr-x. 12 root root    4096 Nov 15  2016 ..
-rwxr-xr-x.  1 root root 7888579 Sep 15 20:18 apiregister-gen
-rwxr-xr-x.  1 root root 5530494 Sep 15 20:18 apiserver-boot
-rwxr-xr-x.  1 root root 4197066 Sep 15 20:18 apiserver-builder-release

With that, .deb and .rpm packages can now be attached to a release on GitHub. If you like, I can also include the generation of source and binary .tar.gz distributables.

Oh my... I've meant to squash 2 consecutive commits and now ended up in a mess of 8 commits. The change set is fully intact though. Sorry.

Try just doing a rebase onto head

I was doing git rebase -i HEAD~$n where $n was the number of commits that showed up in the pull request. Squashing these commits into my first commit always resulted in generating only more commits. This branch became totally screwed, so I thought it was best to close and recreate. Sorry for the mess.


Several changes on brain-score, candidate_models, and model-tools for screen degrees branch

~Removes cropping images to 85% for tensorflow models in preprocessing.~
Adds stimulus size of 6deg for behavioral benchmark.
Adds stimilus size of 2deg for Cadena benchmark.
~Allows behavior benchmark to work on models with multiple layers.~

looks good, but there's a merge conflict in brainscore/benchmarks/behavioral.py. You can resolve this locally by merging brain-score:screen-degrees into your fork tiagogmarques:screen-degrees and pushing


Bug: TaskListClient does not fetche task variables when withVariables is set to true

Hi,
we just upgraded to version <IP_ADDRESS> and noticed that there is a bug when fetching tasklist variables. The TaskListClient should fetch task variables when withVariables is set to true. Unfortunately the logic seems to be flipped as the TaskListClient only fetches the variables when withVariables is set to false.
The reason being:
if (!withVariables) {
     variables = taskApi.searchTaskVariables(taskId, new VariablesSearchRequest());
 }

Hi @sam0r040,
Thanks, I'll fix it today!

Can you already say if you will provide a bugfix release soon or will it take some time?

I'll fix it and release it today!

Oh thats great, thanks!

Hi @sam0r040,
Version <IP_ADDRESS> has been released and is available in maven central and should fix the issue! I'll let you close the issue once you have tested it
Thanks again

Issue is fixed, thanks for the really quick bugfix :)


recognize amenity=vending_machine also when the node is part of a way

Please imagine something like this: https://www.openstreetmap.org/node/6489235043 this cigarette vending machine is support=wall_mounted, so I think it's allowed to tag such machine nodes as part of the building-outer-way which represents the building the machine is mounted to. Maybe so it would be possible that iD recognizes such things also when the nodes are part of a way? At the moment iD donesn't.

Hmmm interesting idea. I really don't think most features like this should be tagged as part of ways. This is a tricky case since it's wall-mounted, but I see the following disadvantages:

It's unclear what side of the way it's on. Is it inside the building? Outside? Does the wall run straight through it? In theory you could make up a tag for this, but that is more complicated than just placing it on the correct side.
Renderers that avoid collisions between POIs and ways won't render it. Even if they do, it's again visually unclear what side of the wall this is on even if you made up a tag for that.

I don't think iD should support ambiguous tagging like this unless the OSM community deems otherwise.

For what it’s worth, there are already some wall-mounted features that are commonly tagged as vertices. ATMs, emergency telephones, and historical plaques come to mind. Renderers handle such features OK when mapped as vertices. The direction or indoor tag is often used to distinguish between indoor and outdoor in these cases.
For the time being, one workaround is to map the vending machine as a stand-alone point, then drag it to the building area’s edge to merge it in.

Now that iD has a warning for points-as-vertices, I think it should be more permissive in edge cases like this. See https://github.com/openstreetmap/iD/issues/6319#issuecomment-546733544.


Update to ungoogled-chromium 123.0.6312.86

Notes:

(continuation of #156)
LLVM is updated to 18. (continuation of #155)

closes #151 (P.S.: The use of ARM64 LLVM improved build time on local environment by a lot.)
LLVM 17 related patches is removed.

A submodule bump is made.
A patch refresh is made.
Rust disable patches are removed.
Rust toolchain download and unpack are added.
Rust is enabled.
disable-missing-clang-flags patch is removed.
Documentations related to ungoogled-chromium update is updated.

Building locally...

Some issues were found with the GitHub CI building... I will try to get it fixed by this weekend.

Everything now builds and runs. Should be good to go.
/cc @networkException @PF4Public

By the way, it seems that the source check on Cirrus are always scheduled but not running...

hm yes, for the binaries repository we also moved to GitHub Actions for these kinda things. Feel free to remove the check entirely for now though if you're not interested in working on a migration.

hm yes, for the binaries repository we also moved to GitHub Actions for these kinda things. Feel free to remove the check entirely for now though if you're not interested in working on a migration.

Okay I see, I will then try to migrate the check to GitHub Actions then. Thanks for the update.


Modernize dependencies and static analysis

Minimum PHP version is now 8.0
Updated psr/http-message and teapot/status-code dependencies
Added native type declarations
Switched from PHP_CodeSniffer to PHP-CS-Fixer (using same configuration as teapot-php/status-code)
Enabled Psalm static analysis
Migrated to GitHub Actions for CI instead of Travis

Resolves #54

@shrikeh Can you review this?

@theodorejb
I believe @shrikeh has moved most - if not all - of this code into the @teapot-php organization.
Can you take a look there?

@localheinz I did look in the @teapot-php org, but it doesn't seem to contain any of this code. The teapot repository there is empty.

I shall investigate tomorrow!
Sent from Proton Mail for iOS
On Thu, Aug 24, 2023 at 16:33, Theodore Brown @.***(mailto:On Thu, Aug 24, 2023 at 16:33, Theodore Brown < wrote:

@.(https://github.com/localheinz) I did look in the @.(https://github.com/teapot-php) org, but it doesn't seem to contain any of this code. The teapot repository there is empty.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

OK thoughts, as I finally have a little development time as we have a Bank Holiday here.

Accept or improve any PRs here
Migrate this entirely to the teapot org
Keep this as a metapackage to the teapot/status-codes repo.
Finally get around to the validator
teapot/teapot will get both the validator and the status codes.

Thoughts?

One thing to consider is that there are currently 41 libraries in Packagist that depend on shrikeh/teapot (plus who knows how many additional private projects). So if you decide to migrate the project to the teapot org, I would still leave the name as shrikeh/teapot in Packagist so as to not disrupt the ecosystem.

Good point. OK, so to ensure we don't break downstream:

shrikeh/teapot in the packagist sense will point to a composer.json at https://github.com/shrikeh/teapot
The contents of that composer.json will list in the require section the teapot/status-code package. There will be no code left in https://github.com/shrikeh/teapot except some READMEs etc.
teapot/teapot in packagist will include both the status code library and the validator.

@localheinz what do you reckon?

If you want the project to be teapot-php/teapot on GitHub, the current empty repository there should first be deleted and then this one transferred there. That way it won't lose stars, pull requests, and contributor history, and existing links to https://github.com/shrikeh/teapot will automatically redirect to the new location.
This doesn't require changing the name in Packagist, but simply editing the package URL there (see https://github.com/composer/packagist/issues/47). I'm not sure if it's a good idea to try to support two different names for the Packagist library, as an extra repository would have to be set up for this, and the new package name would not keep the download stats (currently over 1.7 million downloads), dependents, and suggesters that shrikeh/teapot has.

Good point. OK, I think I see what you're saying


Set up GitHub actions to check formatting

Runs prettier on every push and pull request
Closes #4

Good work on this, merging


RNA-seq workflow not working with GATK3 but works with GATK4

Hi,
I am testing the same sample (~400 MB bam file with just chromosome X) for RNA-seq variant calling using GATK3 and GATK4.
Here is my config files, both are exactly the same except for tools_off has gatk4 in the first config:
GATK3:
details:
- algorithm:
    aligner: false
    bam_sort: false
    variantcaller: gatk-haplotype
    tools_off: [gatk4, gemini, vcfanno, gatk-haplotype-joint, salmon, htseq-count, fastqc, multi-qc]
  analysis: RNA-seq
  description: 'Sample 1: 27571P'
  files:
  - Sample_1__27571P-dedup.splitN_chrX.bam
  genome_build: GRCh37
  metadata:
    batch: 27571P
fc_name: 27571P-CDLS
upload:
  dir: /mnt/isilon/cbmi/variome/rathik/mendelian_rnaseq/gatk_output/27571P_gatk3

GATK4:
details:
- algorithm:
    aligner: false
    bam_sort: false
    variantcaller: gatk-haplotype
    tools_off: [gemini, vcfanno, gatk-haplotype-joint, salmon, htseq-count, fastqc, multi-qc]
  analysis: RNA-seq
  description: 'Sample 1: 27571P'
  files:
  - Sample_1__27571P-dedup.splitN_chrX.bam
  genome_build: GRCh37
  metadata:
    batch: 27571P
fc_name: 27571P-CDLS
upload:
  dir: /mnt/isilon/cbmi/variome/rathik/mendelian_rnaseq/gatk_output/27571P_gatk4

The run for GATK4 finishes without any issues but I am consistently getting the following error with GATK3:
##### ERROR MESSAGE: SAM/BAM/CRAM file htsjdk.samtools.SamReader$PrimitiveSamReaderToSamReaderAdapter@338270ea appears to be using the wrong encoding for quality scores: we encountered an extremely high quality score of 63. Please see https://software.broadinstitute.org/gatk/documentation/article?id=6470 for more details and options related to this error.

I have uploaded the input bam file and the log files for both the runs here: https://drive.google.com/open?id=1qnaHW34r30JyyZsWpO_c4pRBdHw2aqTm.
Please let me know if you need any other information from my side.
Thanks,
Komal

Hi Komal,
Something is broken with your BAM file. I'd set the aligner to STAR, which will re-align and give a proper BAM file.

I figured because of the error, but then why does it work when I have exactly the same configuration for GATK4?

Hi Komal,
I'm not sure, I'd have to look at it more in depth to figure out why it is working with one and not the other, but I'm overwhelmed with other things to look at so it is unlikely I'm ever going to spend the time to figure it out.

Sure, I get it.
If you don't mind, I would like to keep this open as I have tried to debug it myself but cannot figure out what the exact issue is.

Ok! Thanks!

Hi @komalsrathi!
Thanks for reporting this issue!
I looks like gatk3.8 complaining about quality scores in your file.
They indeed look unusual (I converted bam2fastq):
@K00283:161:HL3YHBBXX:4:1113:31142:43251/2
GCAGAAGTGGCGGTCTCCTCCCTTAGGATTACAGGCACCCTGCGTTAACCTCAAAATTGTCTCAGTCCCAAAGAAGGGGCTAGATTTTCTTTTATACTTT
+
``eeeiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii
@K00283:161:HL3YHBBXX:4:2216:27773:8365/2
CTCGAGGTGATCCCGAGGGAAGGAGCGGGGGTCTGAGGGTGGTCCCGAGAGGGACCCGAGGGGTGGAGCGGGGGGAGGGTCTGGAGATGGCCCCGAGGAG
+
``eeeiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiieiiii[ii[ieiiiiiiieei`i[eieiiiiieieViiiiii

The range of quality scores in your file:
Min phred:.66
Max phred:.105

in a typical file:
Min phred:.35
Max phred:.73

It seems that you are dealing with a rare sample from [llumina1.5, Illumina1.8) era, those had different quality scores: https://en.wikipedia.org/wiki/FASTQ_format .
Not sure why gatk4 work and gatk3 does not. Maybe gatk4 just ignores the scores, or decodes them properly. You may try to specify quality scores:
details:
- algorithm:
    aligner: star
    quality_format: illumina
    strandedness: unstranded
    tools_off:
    - gatk4
    variantcaller: gatk-haplotype
  analysis: RNA-seq
  description: test_sample1
  files:
  - /path/to/test2835/test/input/test_sample1.bam
  genome_build: GRCh37
  metadata:
    batch: test
fc_name: test
resources:
  default:
    cores: 2
    jvm_opts:
    - -Xms750m
    - -Xmx7000m
    memory: 15G
upload:
  dir: ../final

I'm not sure if this works in RNA-seq pipeline or in DNA variant calling only (variant2). If the trick is not working for RNA-seq, you may try to realign and correct quality scores with variant2, and then call variants with RNA-seq pipeline using the new bam file.
Please let us know if that works for you.
Sergey

Hi,
Thanks for the response. I also tried using just the fastq input (instead of the bam) and I get exactly the same error message using GATK3.8.  I will definitely try your suggestion by modifying the config file and update here.
Thanks
Komal

Thanks, +1 for Sergey's suggestion, that should work.

I tried again using the config file suggested above and also with fastq input files but I get the same error. Is there a way to correct quality scores using variant2 in the bcbio pipeline?

Hi Komal!
Thanks for confirming that quality_format: illumina is not working with RNA-seq pipeline.
I was able to convert your example bam file with variant2 pipeline:
details:
- algorithm:
    aligner: bwa
    quality_format: illumina
    mark_duplicates: false
    realign: false
    recalibrate: false
    save_diskspace: true
    variantcaller: false
  analysis: variant2
  description: test_sample1
  files:
  - /path/test2835/test/input/test_sample1.bam
  genome_build: GRCh37
  metadata:
    batch: test
fc_name: test
resources:
  default:
    cores: 3
    jvm_opts:
    - -Xms750m
    - -Xmx3000m
    memory: 3G
upload:
  dir: ../final

Variant2 correctly parses Illumina [1.5-1.8) phred format (see Q64 option):
bamtofastq filename=/path/test2835/test/input/test_sample1.bam T=/path/test2835/test/work/bcbiotx/tmpqdc20tnl/test_sample1-1.fq-sort  F=>(/path/bcbio_1.1.5/galaxy/../anaconda/bin/seqtk seq -Q64 -V /dev/stdin | bgzip -c /dev/stdin > test_sample1-1.fq.gz) F2=> ...

When converting the resulting bam file to fastq, quality scores are Phred+33:
@K00283:161:HL3YHBBXX:4:2106:18923:4884/1
GCCATGTGTATTTTTTTAAATTTCCACTGATGATTTTGCTGCATGGCCGGTGTTGAGAATGACTGCGCAAATTTGCCGGATTTCCTTTGCTGTTCCTGCA
+
AAFFFJJJJJJJJJJJJJ<<JJJFA<FJFFJJJJJJJJJJJJJJJFJJJJJJJFAJFJJJJFFFJF<FJJJJJJJJJJFJJJJJJJJJAJJJJJFFFFF<

I think you may use the output of variant2 (bam) as input for RNA-seq pipeline (realign with star).
Let us know if this works for you.
Sergey

Ok, I see why this isn't working now. GATK3 had the ability to fix the quality scores on the fly, and GATK4 does not, so the quality scores don't get converted. There is an option to scale the quality scores by a number, I think if we subtract 31 from the quality scores we can get ones that will work.

I think it's probably a better idea to groom the FASTQ files though, if we swap the quality scores on the alignments then we have two different versions of the quality scores and we have to keep track of which is which.

I see-- it looks like we already do that, so I'm not sure why starting from the FASTQ files doesn't work with GATK4. Did you run with those FASTQ files and have the "illumina" option set as the quality_format?

I am re-running with the following config. Let you know in a couple hours:
details:
- algorithm:
    aligner: star
    quality_format: illumina
    strandedness: unstranded
    tools_off:
    - gatk4
    variantcaller: gatk-haplotype
  analysis: RNA-seq
  description: 'Sample 1: 27571P'
  files:
  - Sample_1__27571P-dedup.splitN_chrX_1.fastq.gz
  - Sample_1__27571P-dedup.splitN_chrX_2.fastq.gz
  genome_build: GRCh37
  metadata:
    batch: 27571P
fc_name: 27571P-CDLS
resources:
  default:
    cores: 2
    jvm_opts:
    - -Xms750m
    - -Xmx7000m
    memory: 15G
upload:
  dir: realign

I got the same error using the above config file with fastq input and quality_format:
nohup_fastq.txt

Related to my issue, in GATK docs, they suggest turning the following parameters on --fix_misencoded_quality_scores / -fixMisencodedQuals or -allowPotentiallyMisencodedQuals / --allow_potentially_misencoded_quality_scores. How do I do that in the bcbio pipeline?

Hi Komal,
We do that, but what is happening is with FASTQ files we groom them first, so the quality score should be fixed at that point, so then we don't run GATK with those options. You can see we turn them on here if they haven't been fixed yet.
https://github.com/bcbio/bcbio-nextgen/blob/master/bcbio/rnaseq/variation.py#L52
But we fix them here:
https://github.com/bcbio/bcbio-nextgen/blob/b40970724e2827f7aa96dccfb99e8d6fe24136bd/bcbio/pipeline/fastq.py#L36
so I'm not sure what is happening.

Hi,
Just keeping you updated: Using GATK3.8 and latest bcbio-nextgen installation, I did some tests on a small fastq file as is and a fastq file where I converted the scores from 1.3 to 1.8 (using https://en.wikipedia.org/wiki/FASTQ_format as suggested by Sergey) with and without the parameter quality_format: illumina:
Fastq file as is:
1. with quality_format: illumina - same error as above
2. without quality_format: illumina - same error as above

Converted fastq file Illumina 1.3 to 1.8
# convert
sed -e '4~4y/@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghi/!"#$%&'\''()*+,-.\/0123456789:;<=>?@ABCDEFGHIJ/' input.fastq  > output.fastq

1. with quality_format: illumina - does not work as it has been converted to standard format. As expected, I get this error: ValueError: Quality format specified in the YAML file might be a different encoding. 'illumina' was specified but possible formats detected were standard
2. without quality_format: illumina - works

Thanks,
Komal

Hi Komal,
Are you still running into this issue? We never figured out what was happening, did you?

Hi Rory,
The last thing that worked for me was to first convert the Fastq files from 1.3 to 1.8 which worked with Gatk3.8. I honestly could never figure out why the scores were not automatically getting converted when using v3.8. If you want, you can close this. Thank you!

Thanks Komal-- sorry for not having a good answer either, but I'm glad you got your work done. Thanks so much for following up!


Implement webInfo

webInfo allows ayb to retrieve endpoints from a given frontend.
This commits removes the email.templates object from ayb.toml and adds web.info_url of type Url.
The webInfo endpoint (web.info_url) is queried on server startup. An example of the response is provided at docs/config/endpoints/example.json and the schema is also provided at docs/config/endpoints/schema.json.
Related to #239

Ready for the second round! :)
Just a comment about expect messages and E2E


Not able to connect mssql using Visual Studio Code 2017

VSCode Version: 2017
OS Version: Windows 10- Home

I am not able to login my SQLEXPRESS database server using VC2017.
I am using windows credentials for authentication purpose.
So in that case, what will be my username and password, please explain this with example or step by step.

Reproduces without extensions: Yes/No

@Swapnil2095 sorry I don't think this has anything to do with VSCode. If the functionality is provided by an extension, please file issues there.


Reduce the score of a checkmating move each ply

Hi, I've got another pull request as well :)
I noticed that the bot doesn't distinguish between how long it will take to do a checkmating move. As long as it knows it has a forced checkmate, it gives it the highest score. The problem is that even if the bot has mate in 1, it won't necessarily play it as it might randomly choose to play a mate in 2 (or higher if the depth is turned up) move instead.
This pull request replaces the scores from being inf or -inf, to instead being<PHONE_NUMBER> which I believe is higher than the evaluation function can ever output. Then, each ply, subtract 1 from a score if it's a mate score (which I say is a score higher than 999000000. That should work so long as there aren't any mate in 1 millions ;) ) This means, that a mate in 1 is slightly better than a mate in 2, and that a mate in 2 is slightly better than mate in 3, etc.
During debugging, I added a line in minimax_root that prints the evaluation for each move. I set it up with a simple fen position 6k1/8/8/5r2/8/8/4r3/2K5 b - - 1 1 which demonstrates the problem. Here is what it looks like with the original code (annotated with comments):
uci
id name Andoma
id author Andrew Healey & Roma Parramore
uciok
position fen 6k1/8/8/5r2/8/8/4r3/2K5 b - - 1 1
go
info move g8h8 has eval -1100
info move g8f7 has eval -1070
info move f5f2 has eval -1100
info move g8f8 has eval -1040
info move g8h7 has eval -1090
info move g8g7 has eval -1090
info move f5f8 has eval -1090
info move f5f7 has eval -1090
info move f5f6 has eval -1090
info move f5g5 has eval -1090
info move f5e5 has eval -1090
info move f5d5 has eval -inf      <-- notice they are all -inf!
info move f5c5 has eval -1090
info move f5b5 has eval -1090
info move f5f4 has eval -1090
info move f5f3 has eval -1090
info move f5f1 has eval -inf      <--
info move e2g2 has eval -inf      <--
info move e2f2 has eval -1090
info move e2d2 has eval -550
info move e2c2 has eval -550
info move e2b2 has eval -580
info move f5h5 has eval -1085
info move f5a5 has eval -1085
info move e2e8 has eval -1055
info move e2h2 has eval -inf      <--
info move e2a2 has eval -1085
info move e2e7 has eval -1050
info move e2e6 has eval -1050
info move e2e5 has eval -1050
info move e2e4 has eval -1050
info move e2e3 has eval -1050
info move e2e1 has eval -1050
info {'nodes': 1227, 'time': 0.13769292831420898}
bestmove e2h2                   <- doesn't know which -inf was best.

Here is what it looks like now:
uci
id name Andoma
id author Andrew Healey & Roma Parramore
uciok
position fen 6k1/8/8/5r2/8/8/4r3/2K5 b - - 1 1
go
info move g8h8 has eval -1100
info move g8f7 has eval -1070
info move f5f2 has eval -1100
info move g8f8 has eval -1040
info move g8h7 has eval -1090
info move g8g7 has eval -1090
info move f5f8 has eval -1090
info move f5f7 has eval -1090
info move f5f6 has eval -1090
info move f5g5 has eval -1090
info move f5e5 has eval -1090
info move f5d5 has eval -999999998     <-   Mate in 2! Good, but not as good as...
info move f5c5 has eval -1090
info move f5b5 has eval -1090
info move f5f4 has eval -1090
info move f5f3 has eval -1090
info move f5f1 has eval -1000000000    <-   Mate in 1!!
info move e2g2 has eval -999999998
info move e2f2 has eval -1090
info move e2d2 has eval -550
info move e2c2 has eval -550
info move e2b2 has eval -580
info move f5h5 has eval -1085
info move f5a5 has eval -1085
info move e2e8 has eval -1055
info move e2h2 has eval -999999998
info move e2a2 has eval -1085
info move e2e7 has eval -1050
info move e2e6 has eval -1050
info move e2e5 has eval -1050
info move e2e4 has eval -1050
info move e2e3 has eval -1050
info move e2e1 has eval -1050
info {'nodes': 1310, 'time': 0.14292550086975098}
bestmove f5f1                           <-   It now picks the best move

Thanks for making this engine and writing up about it, I've been having fun looking through the code.

Hi @thearst3rd!
Thanks for this PR and the clear technical write-up of the change.
This is a good improvement for the engine and the PR code is great 👍
Can you please add a test as part of this PR? It would be good to have coverage to check that the engine will always choose the shortest mate-in-X.
Let me know if you get stuck adding the test and I can advise/take it on.

Hi @healeycodes, thanks for the kind words :)
Just added the test case I was using before - there are multiple mate-in-Xs but only a single move that's mate in one so that should hopefully be a good test.

The test looks great!
Nice work @thearst3rd ⭐
Merging this.


Help needed with rendering

Describe your problem here. If you are modding, please try testing your problem in a clean version of the engine instead, this ensures the problem is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!

The actual rendering works fine but for some reason the video file isn't showing up where it's supposed to be
(using new rendering mode)
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
nop

It's possible that you did not put FFmpeg.exe in the same folder that JSEngine.exe is located in.

On Sat, Oct 26, 2024 at 5:38 PM Jordan Santiago @.***>
wrote:

It's possible that you did not put FFmpeg.exe in the same folder that
JSEngine.exe is located in.
—
Reply to this email directly, view it on GitHub
https://github.com/JordanSantiagoYT/FNF-JS-Engine/issues/695#issuecomment-2439743764,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYUPIR33GVGMUAF6KXUZ2PDZ5QDW3AVCNFSM6AAAAABQVEGVTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZG42DGNZWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Alt ill try that

there should be a check for if it's there before rendering

ex dee

i got it exported but opening the file in media player says that it has unsupported encoding

(i'm using libx264)

i got it exported but opening the file in media player says that it has unsupported encoding

oh
You can't really open these kinds of videos inside a normal video player.
you have to use something like VLC or a video editor (the one i use is CapCut)

ah ok tysm


High load on management server due to stale KVM agent

ISSUE TYPE

Bug Report
Improvement Request
Other

COMPONENT NAME

KVM, Management Server

CLOUDSTACK VERSION

4.18.1, Any

CONFIGURATION

KVM
OS / ENVIRONMENT

Rocky 8 KVM, Management server
SUMMARY

Removed KVM host with agent management server IP configured pointing to a new management server leads to high CPU load on the management server.

We can see the below logs in the management server:

2024-01-16 10:14:00,089 WARN  [c.c.u.n.Link] (AgentManager-SSLHandshakeHandler-381:null) (logid:) SSL Handshake has taken more than 30s to connect to: /<IP_ADDRESS>:46493. Please investigate this connection.
2024-01-16 10:14:00,099 WARN  [c.c.u.n.Link] (AgentManager-SSLHandshakeHandler-29:null) (logid:) SSL Handshake has taken more than 30s to connect to: /<IP_ADDRESS>:46475. Please investigate this connection.

STEPS TO REPRODUCE

1. Remove a KVM host. Restart the agent.
2. Reinstall the management server or run cloudstack-setup-database
3. Watch the Management server CPU load.

OR

1. Update the agent.properties of a KVM host to point it to an existing management server where the host is not added.
2. Restart the cloudstack agent.
3. Wait for a few minutes until the management server CPU load goes very high.

this is a bad bug, @rajujith . I know some people are explicitely using this scenario in operations, so it should be supported. Can you confirm the the host/agent is not added to the cloud-installation?

this is a bad bug, @rajujith . I know some people are explicitely using this scenario in operations, so it should be supported. Can you confirm the the host/agent is not added to the cloud-installation?

@DaanHoogland
the issue is easy to reproduce: reinstall cloudstack database on management server
the running cloudstack-agent will try to connect the management server with old configuration, again and again.
the workaround is also very simple: stop cloudstack-agent on kvm hosts, and add hosts on cloudstack UI if needed.

this is a bad bug, @rajujith . I know some people are explicitely using this scenario in operations, so it should be supported. Can you confirm the the host/agent is not added to the cloud-installation?

Agent is not added to cloudstack and the workaround is to stop the agent. However it would be nice to have it fixed.

should I up the level from major to critical on this, @rajujith @weizhouapache ?

should I up the level from major to critical on this, @rajujith @weizhouapache ?

@DaanHoogland
I do not think it is a major/critical issue.
when users reinstall an environment, they should better stop all running cloudstack services (management, usage, agent).

right, there is an issue when the management is reachable to rogue agents, but that is an operational issue. I was thinking we must guard against that.

Rogue agents shoudn't have the ability to create high load on the management server and crash it.

Assigned to @weizhouapache - perhaps we can explore a simpler solution where the management server can send a shutdown command to stale/old KVM agents?

Fixed in #9258


AtlasService.converterCheck() contains incomplete code

@jpav commented on Thu Nov 02 2017
Code near the end of the method that determines whether a response should be generated indicating a converter is needed to perform a mapping has been left incomplete.  We should determine the necessity of this code and either complete its implementation or remove it from the class.

@igarashitm commented on Thu Nov 02 2017
Weird thing is that we sometimes see "converter is not available" warning in UI. I thought it came from this converterCheck. Need to investigate.

@igarashitm commented on Wed Nov 08 2017
I now suspect the converterCheck is not used at all. All the converter validation results I have ever seen come from validate. Make sure UI doesn't invoke it and remove.

AtlasService.converterCheck() is not used anywhere. Its look like we can remove AtlasService.converterCheck() and the corresponding Rest API


Fix shell expansion using ansible fact

The previous apt repo line was using a shell expansion which will not work inside the apt_repository module. Replacing it with a Fact.

Thanks for the quick fix!

Another short fix to help consul install on Ubuntu/Debian via repository. When using the package module, apt prefers PKG=VERSION format instead of PKG-VERSION.


Results as map[string]interface{} rather then map[string]string

Would it be possible to have response return the actual data type like a map[string]interface{} rather then have the value always be a string.

I believe the Thrift interface to osquery is providing us the values as strings. Perhaps we could add a helper function that attempts conversion to various types?

I think if this is a design because of a protocol limitation then I would just close the ticket, converting values into another type is simple enough for anyone using it and it would also require knowledge of the underlying schema.

https://github.com/kolide/osquery-go/pull/77 is a draft of the inverse, and may or may not be interesting


Security Advisory 886 Fix

tl;dr
Updates unzipper to 0.9.12.
details
Includes update in this
which addresses this.

Done.


(GH-536) Add ability to ignore cake version when executing build

This pull request adds a simple way to disable the throwing of an error when the version of Cake do not match the version that Cake.Recipe was built with.
This switch --ignore-cake-version is used without any arguments to allow this to happen, a warning will be outputted to the user that he/she is running an unsupported/untested version of Cake, but execution of the build will be allowed to continue.
resolves #536

@AdmiringWorm thanks for getting this added!


Dynamic headers

https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/blob/32d6739161077e95cc2b91937cb221c3553ee2ee/resources/META-INF/graphql.config.json#L31
Hi I have to pass up a user's session as a Cookie header to my api in order to authenticate the user. I'm currently just placing this in the headers object in the graphql.config.json which is working but I was wondering if you had any ideas for doing this more dynamically to accomplish 1 or both of the following:

I'd like to hit a login endpoint and use the value returned from that
I'd like to have a way to parameterize the graphql.config.json so I don't have to edit it so often and possibly commit it to the repo

thanks!

Closing this now that the plugin supports graphql-config with environment variables that it preserves while a project is open.
Best regards,
Jim.


doc: update installation instructions re wheels

@kgriffs I'm fine either wording, I've approved so you can merge either way


dotnet 8 - isolated model - httpTrigger does not generate Request object in Application Insights

Description
I'm using dotnet 8 isolated with Http trigger, when invoking an http triggered api I do not see a corresponding Request object in Application Insights.
I'm using IHostApplicationBuilder, the only line of code I was not able to port was this one:
logging.AddConfiguration(hostingContext.Configuration.GetSection("Logging")); in the ConfigureLogging of the previous model IHostBuilder.
Steps to reproduce
Please find below csproj, program.cs, SimpleFunction.cs, host.json and appsettings.json.
Traces, dependancies are working for every function. In this project I also have some durable orchestration and the v2 model is working effectively (I see request/dependencies).
csproj
   <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
    <PackageReference Include="Azure.AI.OpenAI" Version="2.0.0" />
    <PackageReference Include="Azure.Identity" Version="1.13.1" />
    <PackageReference Include="Azure.Monitor.OpenTelemetry.AspNetCore" Version="1.2.0" />
    <PackageReference Include="Microsoft.Azure.AppConfiguration.Functions.Worker" Version="8.0.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="2.0.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" Version="1.2.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.2.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore" Version="2.0.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.ServiceBus" Version="5.22.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Timer" Version="4.3.1" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Warmup" Version="4.0.2" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.OpenTelemetry" Version="1.0.0-preview1" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="2.0.0" />
    <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" Version="2.22.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.ApplicationInsights" Version="2.0.0" />
    <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="9.0.0" />
    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.0" />
    <PackageReference Include="System.Net.Http" Version="4.3.4" />
    <PackageReference Include="System.Private.Uri" Version="4.3.2" />
    <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
  </ItemGroup>

Program.cs
using DnsClient;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Builder;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using System.Data;

var builder = FunctionsApplication.CreateBuilder(args);
builder.ConfigureFunctionsWebApplication();
builder.Services
    .AddApplicationInsightsTelemetryWorkerService()
    .ConfigureFunctionsApplicationInsights();
//.AddHttpClient()
//.AddHealthChecks();

// full details for durable task host.json: https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-bindings?tabs=python-v2%2Cin-process%2C2x-durable-functions&pivots=programming-language-csharp#hostjson-settings

builder.Logging.Services.Configure<LoggerFilterOptions>(options =>
{
    // The Application Insights SDK adds a default logging filter that instructs ILogger to capture only Warning and more severe logs.
    // Application Insights requires an explicit override.
    // Log levels can also be configured using appsettings.json.
    // For more information, see https://learn.microsoft.com/azure/azure-monitor/app/worker-service#ilogger-logs
    #pragma warning disable CS8600 // Copied from link https://learn.microsoft.com/en-us/azure/azure-functions/dotnet-isolated-process-guide?tabs=ihostapplicationbuilder%2Cwindows#start-up-and-configuration

    LoggerFilterRule defaultRule = options.Rules.FirstOrDefault(rule => rule.ProviderName
              == "Microsoft.Extensions.Logging.ApplicationInsights.ApplicationInsightsLoggerProvider");

    #pragma warning restore CS8600
    if (defaultRule is not null)
    {
        options.Rules.Remove(defaultRule);
    }

});

// builder.Logging.Services.AddApplicationInsightsTelemetryProcessor<RenameCategoryNameToCategory>();

var host = builder.Build();

await host.RunAsync();

SimpleFunction.cs
public class SimpleFunction(ILogger<SimpleFunction> logger)
{
    [Function(nameof(SimpleFunction))]
    public IActionResult Run([HttpTrigger(AuthorizationLevel.Function, "get", "post")] HttpRequest req)
    {
        StringBuilder stringBuilder = new();
        stringBuilder.AppendLine($"Trace: {logger.IsEnabled(LogLevel.Trace)}");
        stringBuilder.AppendLine($"Debug: {logger.IsEnabled(LogLevel.Debug)}");
        stringBuilder.AppendLine($"Info: {logger.IsEnabled(LogLevel.Information)}");
        stringBuilder.AppendLine($"Warning: {logger.IsEnabled(LogLevel.Warning)}");
        stringBuilder.AppendLine($"Error: {logger.IsEnabled(LogLevel.Error)}");
        stringBuilder.AppendLine($"Critical: {logger.IsEnabled(LogLevel.Critical)}");
        logger.LogError(stringBuilder.ToString());

        logger.LogInformation("MyMessage Info: SimpleFunction processed a request ok.");
        logger.LogDebug($"MyMessage Debug: SimpleFunction processed a request ok.");
        logger.LogTrace($"MyMessage Trace: SimpleFunction processed a request ok.");
        logger.LogWarning($"MyMessage Warning: SimpleFunction processed a request ok.");
        logger.LogError($"MyMessage Error: SimpleFunction processed a request ok.");
        logger.LogCritical($"MyMessage Critical: SimpleFunction processed a request ok.");

        return new OkObjectResult("Welcome to Azure Functions!");
    }
}

host.json
{
  "version": "2.0",
  "extensions": {
    "durableTask": {
      "tracing": {
        "distributedTracingEnabled": true,
        "Version": "V2",
        "traceInputsAndOutputs": true
      }
    }
  },
  "logging": {
    "LogLevel": {
      "default": "Information",
      "Function": "Information",
      "Host.Aggregator": "Trace",
      "Host.Results": "Information",
      "Function.HealthCheck": "Warning"
    },
    "applicationInsights": {
      "enableDependencyTracking": true,
      "dependencyTrackingOptions": {
        "enableSqlCommandTextInstrumentation": true
      },
      "samplingSettings": {
        "isEnabled": false,
        "excludedTypes": "Request"
      },
      "enableLiveMetricsFilters": true
    }
  }
}

appsettings.json
{
  "logging": {
    "LogLevel": {
      "default": "Information",
      "Function": "Information",
      "Host.Aggregator": "Trace",
      "Host.Results": "Information",
      "Function.HealthCheck": "Warning"
    },
    "applicationInsights": {
      "enableDependencyTracking": true,
      "dependencyTrackingOptions": {
        "enableSqlCommandTextInstrumentation": true
      },
      "samplingSettings": {
        "isEnabled": false,
        "excludedTypes": "Request"
      },
      "enableLiveMetricsFilters": true
    }
  }
}

Last comment (I hope :). By replacing .AddApplicationInsightsTelemetryWorkerService() with .AddApplicationInsightsTelemetry() (from package Microsoft.ApplicationInsights.AspNetCore) now http requests are tracked.
In this function app I also have some durable functions, curios thing is that now I have two items in the application map representing my azure function

One (without any arrows) coming from durable function, with RoleInstance equal to pd1sdwk0007S6
The other one coming from http triggered functions, with roleinstance equal to fd44d9b4958f4c9906de94b125d0970e95d5665ce7ced9f7fca7a51da3c094ac.
Questions:

are there any known issues in using the application insights dotnet core package?
would request be generated from other function as well (service bus trigger and so on)?
maybe docs have to be updated?

thanks!

@Banchio can you try using Microsoft.ApplicationInsights.AspNetCore instead of the worker service one?

Thanks @jviau  for looking into this. Using AddApplicationInsightsTelemetry() (from package Microsoft.ApplicationInsights.AspNetCore) http requests are tracked. Maybe an update to the docs is needed, if I can contribute just lmk. Closing this issue for now


[FEATURE REQUEST] web 1.1.0 Support

Dependency constraints for package web 1.1.0 are not fulfilled, which blocks other package updates in my app.
Pdfrx is the only package in my app still constraining to 1.0.0, so I kindly ask to update to web 1.1.0-support.

Because my_app depends on pdfrx ^1.0.87 which depends on web >=0.5.1 <1.1.0, web >=0.5.1 <1.1.0 is required.
So, because my_app depends on web ^1.1.0, version solving failed.

P.S.: Good work with pdfrx, excellent package!

Supported on 1.0.89.


iOS TextField issues with Center and Right text alignment

Describe the bug
There are some bugs with Center or Right text alignment on iOS. Sample code:
TextField(
        value = text,
        onValueChange = {
            text = it
        },
        textStyle = LocalTextStyle.current.copy(textAlign = TextAlign.Right),
    )

Bug #1: In empty TextField the caret is placed always on the left side, and doesn't respect text alignment. Same happens with each new line.
https://user-images.githubusercontent.com/3955262/234054834-da28e67a-c3a8-4059-82ef-7ed654a13352.mov
Bug #2: With Right layout a whitespaces after a symbol aren't displayed until a next symbol is entered. It works fine with Left and Center layouts.
https://user-images.githubusercontent.com/3955262/234055764-59bbfbde-97f0-48de-a437-dd8a752c1bf2.mov
Affected platforms

iOS

Versions

Kotlin version*: 1.8.20
Compose Multiplatform version*: 1.4.0

@dima-avdeev-jb checked on Android as requested:

caret is being showed according to TextField's text alignment
whitespace after word is showing correctly on right text alignment

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Sitrep vs. cloc Results

Scanning my current branch of Alamofire, Sitrep gives these LOC results:
Sizes
   Total lines of code: 11102
   Source lines of code: 9481

However, cloc gives these results:
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Swift                           32           1606           3598           5897

Perhaps Sitrep could use a similar break down?

We only realistically have one language to work with, but printing a blank/comment count would be great! Want to try implementing it yourself? I'm going to add the "good first issue" comment to flag this one up.

I'm wondering if (with a command line flag) we could do a table like you show, except across files? So rather than Language Swift as the first field, it would be File a.swift, then b.swift, etc.

@jshier
Could you tell us the command used with cloc to have that report?