Error when using modelFlow/modelAction over subclass

Discussed in https://github.com/xaviergonz/mobx-keystone/discussions/469

Originally posted by aboyer1013 July  8, 2022
Looking for some guidance here with regards to errors when using inheritance with abstract classes. I'm not sure if this is a mobx-keystone bug or a misunderstanding of abstract classes and how they work in TypeScript.
I have to declare the method (fetch2) in the base class in order to resolve the error. Essentially, a noop filler just to get rid of the error. I have some questions:

Why does it complain about modelFlow but not the same for modelAction?
Is there a better way to do this?

I appreciate any feedback. Thanks!
Code Sandbox demo
import {
  _async,
  _await,
  ExtendedModel,
  model,
  Model,
  modelFlow,
  idProp,
  prop,
  modelAction
} from "mobx-keystone";

abstract class BaseModel extends Model({
  id: idProp,
  name: prop<string>()
}) {
  // If this method is removed, the error goes away.
  @modelFlow
  fetchData = _async(function* (this: BaseModel) {
    const promise = new Promise((resolve) => {
      setTimeout(() => {
        resolve("done");
      }, 3000);
    });
    const response = yield* _await(promise);

    console.log("response: ", response);
  });

  // In order to resolve, this method must be declared in the base model. Uncomment the next line to resolve.
  // fetch2: () => void = () => {}
}

// If this class is removed, the error goes away.
@model("ModelA")
class A extends ExtendedModel(BaseModel, {
  foo: prop<string>()
}) {}

@model("ModelB")
class B extends ExtendedModel(BaseModel, {
  foo: prop<string>()
}) {
  // The existence of fetch2 produces an error: modelFlow has to be used over functions
  @modelFlow
  fetch2 = _async(function* (this: BaseModel) {
    const promise = new Promise((resolve) => {
      setTimeout(() => {
        resolve("done");
      }, 3000);
    });
    const response = yield* _await(promise);

    console.log("response: ", response);
  });

  @modelAction
  something() {
    this.foo = "foo";
  }
}

const a = new A({
  foo: "bar",
  name: "test"
});

console.log(a.name);
```</div>

@aboyer1013 fixed in 0.69.2

I'll close it for now. If for some reason the fix does not work for you feel free to reopen.


Use mkHListValue in LabelledMacros

I've found that LabelledMacros contains a copy of mkHListValue inside. Just to avoid duplication.

Codecov Report

Merging #787 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   86.94%   86.94%
=======================================
  Files          90       90
  Lines        2521     2521
  Branches       51       51
=======================================
  Hits         2192     2192
  Misses        329      329

Impacted Files
Coverage Δ

core/src/main/scala/shapeless/labelled.scala
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc6a1b...e77e725. Read the comment docs.

Well spotted! Many thanks ... merging :-)


Updated readme with options from cropperjs

Updated readme to show all possible options for vue-cropper component.

thanks @bwin . thanks for the awesome vue conversion package for cropperjs


Update index.md

中文简体 使用系统级别API 显示成了 使用系统A级PI

Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Hey @Amanoi, can you please explain this change a bit? I translated using https://translate.google.com and seems to translate to almost the same thing (which is a good fact I guess).


The server start up takes around 25min, when 350 XACML policies are being loaded during the initial startup.

Describe the issue:
The server startup takes around 25 minutes when 350 XACML policies are being loaded during the initial startup.
How to reproduce:

Add around 350 XACML policies to the /repository/resources/identity/policies/xacml/ directory so that they will be published to the PDP during initial server startup.
Start the server.

Expected behavior:
In IS-5.8.0 the server startup takes around 4min with the same policies.
Environment information :

Product Version: [IS 5.10.0]
Database: [Postgres]
Userstore: [JDBC]

In IS-5.8.0 the following properties in the /repository/conf/registry.xml were set to true by default.
    <staticConfiguration>
        <versioningProperties>true</versioningProperties>
        <versioningComments>true</versioningComments>
        <versioningTags>true</versioningTags>
        <versioningRatings>true</versioningRatings>
    </staticConfiguration>

But in IS-5.10.0, the above properties are set to false to avoid registry buildup related issues. with this set to false in IS-5.10.0, there is an additional delete query executed which gets captured as a slow query.
DELETE FROM REG_RESOURCE_PROPERTY WHERE REG_PROPERTY_ID= ? AND REG_TENANT_ID=?;
When the above "versioningProperties" is set to true, the server starts up in 5 min.
The startup time of 5min is also too slow and needs to be improved.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Brought printf to recent C-FFI standard

Added mandatory use statement and replaced printf[None](...) with  printf(...)

Looks like the lib that we rely on is incorrectly linking against zlib again.


Anvil consumes entire stack in "sacrifice" slot when not repairing

Minecraft 1.16.1
Stacc 1.16.1 4
When an anvil is used (besides for repairing purposes), the entire stack inside the 'sacrifice' slot is consumed, regardless of what's in the 'target' slot. For example, combining a single Diamond Helmet with a Protection IV book (stacked to 1,000,000) will consume all 1,000,000 Protection IV books to produce a single Protection IV diamond helmet at a cost of 4 XP levels, where it should have consumed as many Protection IV books as there were Diamond Helmets in the "target" slot. If there are not enough items in the "target" slot (in this case Protection IV books), then the remainder of the items in the "sacrifice" slot are left unenchanted.
Additionally, it is "too expensive" (40 XP levels or more) to combine more than 1 item in the "target" slot at once (stacked) with something in the "sacrifice" slot, whether it be an elytra with Unbreaking and Mending, or a Diamond Helmet with itself where both are enchanted differently.

fixed in katest release, 1 billion swords now require 1 billion books to craft

The XP cost requirement is still not fixed, IMO. It still returns a cost of 40 XP levels or more to combine more than 1 item in the "target" slot with an equal or greater number of the item in the "sacrifice" slot. Is that intended?

Not intended, will fix

fixed, will be in next release


jarek/6852:  rename more packages

now that I look into this one more closely I changed my mind, it should be like this:
com.twosigma.beakerx.widget.*.X
→
com.twosigma.beakerx.widget.X


Have Model layer update Storage directly, and remove connection between Logic and Storage

This will be fixed by merging dev/drop-logic-storage-link


Disappointing Support for False

As much as we want to love Libtrue, and appreciate what the community here are trying to achieve with this groundbreaking work, our team has been running up against challenges extending the library to also add support for False.
We really don't want to derail the project, but if it isn't possible to get decent support for false in the next few months we may have to propose a fork. .
Seriously don't want to "ruffle any feathers", but we feel it is important to address these concerns sooner rather than later before it is true late

False truth?
Not sure

I prefer to think of it as non-true.

It's an alternate true


pwmFrequency() gives no output

Hi,
Just FYI.
I don't get output with current implementation.
I have a patch, I'll test it once I get hardware and make a pull request.

What's not working exactly? What code or you using?
pwmFrequency() doesn't enable the PWM output, it just sets the frequency being generated in the PWM module. pwmWrite() (or analogWrite()) has to be called to enable the output.

I see. It seemed to me by the wiki that pwmFrequency() alone is enough, sorry. It would be nice to stress it in the wiki.

Just updated the wiki, should be more clear now. Thanks!


Reference needed

"Hosting datacenters around the world can consume more than 80 percent of an annual IT budget"
Could a reference be added to increase the credibility of the figure please? thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ce8b55e-8db7-a1c0-a0e8-7b3f93ad1553
Version Independent ID: f9044c8e-8665-1f66-6ee5-6f2fd8febe86
Content: Examples of global reach outcomes - Microsoft Cloud Adoption Framework for Azure
Content Source: docs/cloud-adoption/business-strategy/business-outcomes/reach-outcomes.md
Service: cloud-adoption-framework
Sub-service: strategy
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

@eyast Thank you for your feedback! We will review and provide an update as appropriate.

Added the backlog for Cloud Adoption Framework


Personal details

Screenshot

@gavinwye Is this a pattern? Is it going to be used in more than one place?

I'm not sure how many services have a need for this. More investigation is necessary with this.

We have this page. Or at least it's an off shot of registering a company if you don't have a gov gateway sign in.
https://www.tax.service.gov.uk/government-gateway-registration-frontend?accountType=organisation&continue=%2Fregister-your-company%2Fpost-sign-in&origin=company-registration-frontend
Not sure it's a pattern, but if it were to be a pattern I think it definitely needs work to improve it, I think.

Useful and Unique but requires more work

Hi @gavinwye is this more about related to creating user accounts??

@ignaciaorellana yes and the title is not a true reflection of what it is. I'll update it from 'Personal details' to 'Create a password'

@gavinwye this doesn't look password specific though. are you suggesting that it should be but the screenshot has too much in it? if not, then it feels more like "Create an account".

@gavinwye
One thing to consider is that all patterns that relate to Government Gateway such as this one will probably be completely different in less than 12 months. The BAS project is currently looking at different approaches to more high level pain point regarding the Government Gateway journeys.

Published on GOV.UK Design System


autoformatting creates a new semi colon when i save

when i save (cmd + s) there is a new semicolon added to the end of my code (where there should be one)
video
edit: seems to be only with typescript, also using react and the typescript create-react-app template

I can't what the video. It is some Minecraft thing :-)
I am pretty sure that you have auto fix on save enabled which fixes these errors on save. Is that the case?

i probably uploaded the wrong vid sry
idk why but its fixed now lol


Show always the arrows

I want to show always the arrows (disabled if there is no more slides), and also the dot
It's there a way to do it ?

settings  example
{
autoplay: false,
infinite: false,
arrows: true
}

You can use custom arrow and append dots feature for this usecase


Re-factor Quote Domain Models

Please re-factor the following:

use 'phone: {number: string, type: string}' object instead of phone
use street[] instead of street1 and street2.
add county to address.
use min instead of minBudget the type should be a long number
use max instead of maxBudget the type should be a long number
use min instead of minTimeLine
use max instead of maxTimeLine
add establishedYear to company object.
add projectPlatform to quote object.
add projectType to quote object.

While working this issue please remove the DTO and VO and try to stick to just the Model interfaces and Domain objects.
We'll create DTO and VO on a need to basis.
New JSON:
{    "projectPlatform": "string",    "projectType": "string",    "contact": {      "firstName": "Aman1",      "lastName": "Abrol1",      "email"<EMAIL_ADDRESS>     "phone": {        "number": "1234567890",        "type": "home"      },     "address": {        "street": [ "16241 N 30th Pl", "1200" ],       "city": "phoenix",        "state": "az",        "zip": "85032",        "county": "genesee",       "country": "USA"      }    },    "company": {      "name": "Private LLP",      "type": "LLP",      "establishedYear": 2012,      "url": "https://www.google.com",      "description": "description",      "budget": {        "min": 15000,        "max": 100000      },      "timeline": {        "min": "4",        "max": "7"     }   }  }
Old JSON:
{   "contact": {     "firstName": "Aman1",     "lastName": "Abrol1",     "email"<EMAIL_ADDRESS>    "phone": "1234567890",     "address": {       "street1": "16241 N 30th Pl",       "street2": "1200",       "city": "phoenix",       "state": "az",       "zip": "85032",       "country": "USA"     }   },   "company": {     "name": "Private LLP",     "type": "LLP",     "url": "https://www.google.com",     "description": "description",     "budget": {       "minBudget": "15000",       "maxBudget": "100000"     },     "timeline": {       "minTimeLine": "4",       "maxTimeLine": "7"     }   } }

@ocampd1 Can you verify that this is done.  I believe this is completed.


Possible fix for crash URI-related crash on windows

URLs such as jar:file:C:/... are invalid. With this PR, it should be jar:file://$relativePath.

Confirmed to not break on Linux. Safe to merge at least.


Enhancement/569 change reuse user randomizer

Checklist

[x] tests added
[x] commits conform to the Commit message format
[ ] documentation updated

Squash commit message

Make session id count also for reuse user iterations
Determinism not broken due to a failed iteration when using reuse user flag
Bugfix for determinsm and thinktime actions
Randomizer can now be overriden by other by users or future schedulers

@carlcervin remember, these two files are generated:

docs/settingup.md
generatedocs/generated/documentation.go


Fix #305, add no repeat mode in player

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1081

Relevant Lines:
1081

💛  - Coveralls


Windowsphone "at to start" missing Favicon

On Windowsversion there is no favicon to display as APP Image if I Pin it to start

Is this issue fixed with the latest 0.6 version?

No Sorry - on Windows Phone Lumia 640 it is still Show a screenshot of my Playlist if i attach it to  the startscreen

If i found a Solution fir my Phone Modell i will create a fix

All your code and browserconfig seems correct
https://github.com/martijnboland/moped/blob/master/dist/assets/images/browserconfig.xml
Is there any accesslog in your webserver?
So i can see what kind of image my phone try to load
Same code on own webserver works fine

With the decline of Windows Phone usage, this issue is probably not relevant anymore. Please feel free to reopen when otherwise.


feat(clip2onnx): model_card dataclass

Rewrite clip_to_onnx.py as a dataclass for better extensibility.
Support for exporting all types of open-clip models.
I've provided a examples/demo_clip2onnx.py.

Hey, we had an internal discussion about it and we'll release a new version of onnx_clip today that bumps the minimum version of Python to 3.8. This should make things easier. Let me know when this PR is ready for review.

I've added an auto-labeling project demo module that loads ONNX models locally and uses them.
I think exporting an ONNX model and using an ONNX model should be two tasks that run independently.
The environment used to export the model can be completely different from the environment used to use the model.
This is because you can completely package all available models ahead of time, then upload them to the database and download them on demand at another endpoint.
Also, I think the interface could accept the path to the model instead of the model name, which would decouple the two tasks.

Regarding the auto-labeling demo, I copied and reloaded part of the code to avoid conflicts, so you can remove it if you don't feel comfortable with it.

If you guys decide to switch styles, maybe standardize the naming of the models
https://github.com/lakeraai/onnx_clip/blob/5f7e128e5737f8c917af3ee4075a8d27d28e171e/clip2onnx/model_card.py#L81-L98


Cranelift AArch64: Generate the UDF instruction for Inst::Udf

Cranelift's AArch64 backend currently uses an unallocated encoding for the Inst::Udf VCode instruction. There is a risk that the encoding could be allocated in the future, so it might no longer be an undefined instruction, resulting in incorrect code generation. On the other hand, there is an instruction, UDF, which is permanently undefined and which avoids this issue.
In a previous discussion, @bnjbvr has explained the reasons for the current approach:

Yes, a few reasons come to mind. None of them seem particularly inevitable, and they could all be worked around, if we decided to use a new value, but it was simpler to choose this one for a few reasons:

this is the same value Spidermonkey uses for triggering SIGILL, with the reasons explained there: https://searchfox.org/mozilla-central/source/js/src/jit/arm64/vixl/Constants-vixl.h#2668-2690 . If we didn't use the same value as Spidermonkey did use, either Cranelift would need a compiler option to allow selecting which undefined instruction is used (or select it among a list of predefined), or Spidermonkey should refactor its code to support different undefined instruction encodings in their aarch64 backend.
there might be an argument that a native compiler (rustc/llvm) would use the default UDF instruction, and that using a different instruction in cranelift-generated code makes it easier to spot what's the actual issue in a test case. For instance, for the initial issue discussed here in particular, we could directly infer that it was a cranelift-generated undefined encoding not being properly handled by the OS. A sigill with another undefined encoding could have been this problem or another illegal encoding problem (coming from llvm codegen in native code).

Note that UDF has an immediate parameter, which could be used to address the second point to an extent, e.g. UDF #0xBAD could signify Cranelift-generated code.

Maybe use 0xC11F as immediate? (clif) Or encode the trap code directly without requiring a side table like it does right now?

The requirement seems mainly to come from our desire to conform to SpiderMonkey's convention when used in that context, but I don't think we need to completely freeze the bits of our design that overlap with the integration if it prevents us from "doing the right thing" otherwise. It does seem more idiomatic / in line with what the ISA design and other tools expect to actually use the canonical "undefined" instruction for traps; and from the SM point of view, this is a slight adjustment (catch a different signal or similar) in line with other API-change and similar updates that need to happen in the normal course of updating to new crate versions.
cc @bnjbvr for any updated thoughts on this? Also @julian-seward1, if you're around: what's the latest (if any) on maintaining usage of Cranelift in SpiderMonkey, and if it's maintained, would it be a significant blocker to adapt to the use of udf for traps rather than the arbitrarily-selected instruction used now?

Agreed that keeping a custom convention that's required by a single Cranelift user makes it less relevant for other users, not much to add on the topic otherwise.


Executable available?

Thanks for sharing this fantastic work!
Is there a compiled exacutable available anywhere for the less technically inclined like myself?

Yes, in github releases: https://github.com/AdrianEddy/telemetry-parser/releases

Thanks!


[question] Where does (gtk-)youtube-viewer store downloaded videos?

As far as I understand the program downloads the full video and then plays it (please correct me if I am wrong). Where does the downloaded file reside?
Also: there seems to be no visual feedback about what is happening when one double clicks a video in the gtk-youtube-viewer (i.e. whether it is loading, whether something else is happening). Is there a way to know what is going in between the double click and the video playback (or its failure for whatever reason)?

Videos are played without being downloaded first. This is done by passing the YouTube URL of a video to the selected media player, which downloads (in memory) and plays the video at the same time. The full video file is never stored on the disk.
Regarding the visual feedback, an error message will be displayed when a certain video cannot be played. See also the warnings log (Menu->Warnings log), which includes all the warnings and error messages if something goes wrong.
Also, if you set debug => 1, in the Preferences, and execute gtk-youtube-viewer in a terminal, additional output will be printed out , which can be useful to undertsand what's happening under the hood.

Regarding the visual feedback, an error message will be displayed when a certain video cannot be played.

I don't get any error messages ever. Example STR:

Search in gtk-youtube-viewer for: journey separate ways
The first video in the search results (for me) is: https://www.youtube.com/watch?v=LatorN4P9aA
I try to play it

EXPECTED
To get some kind of feedback telling me that there is DRM restriction.
Note: I use avideo just like you recommended here).
ACTUAL
Nothing happens. I look at the warnings log and all it shows me is:
[Fri Mar 16 13:30:29 2018]: WARNING **: Invalid borders specified for theme pixmap:
        /usr/share/themes/Breeze/gtk-2.0/../assets/line-h.png,
borders don't fit within the image at /usr/bin/gtk-youtube-viewer line 3074.

which looks unrelated as it was there even before trying to play the video.

Also, if you set debug => 1, in the Preferences, and execute gtk-youtube-viewer in a terminal, additional output will be printed out , which can be useful to understand what's happening under the hood.

Well, that is not quite GTK is it? :) Anyway I have set debug => 1 and repeated the steps above. On the fronted - same result. In console I get:
[~]: gtk-youtube-viewer
** GET https://www.googleapis.com/youtube/v3/search?key=AIzaSyA2PQakgMYbX3U3imqplLMhpfM8mzEn22Q&maxResults=10&order=relevance&part=snippet&prettyPrint=false&q=journey%20separate%20ways&safeSearch=none&type=video&videoCaption=any&videoDefinition=any&videoDuration=any ==> 200 OK (1s)
** GET https://www.googleapis.com/youtube/v3/videos?id=LatorN4P9aA,_wY6i5vRlUU,UfJQ6yveYH0,0WwNYY-rqIY,f-7I1dRo7WQ,jEVKoeVYugA,x4wf5ya4C3Y,epX1025v1Ls,fWqMV40Gkcg,yoqYO0ShUXc&key=AIzaSyA2PQakgMYbX3U3imqplLMhpfM8mzEn22Q&maxResults=10&part=contentDetails,statistics,snippet&prettyPrint=false ==> 200 OK
** GET https://i.ytimg.com/vi/LatorN4P9aA/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/_wY6i5vRlUU/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/UfJQ6yveYH0/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/0WwNYY-rqIY/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/f-7I1dRo7WQ/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/jEVKoeVYugA/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/x4wf5ya4C3Y/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/epX1025v1Ls/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/fWqMV40Gkcg/mqdefault.jpg ==> 200 OK
** GET https://i.ytimg.com/vi/yoqYO0ShUXc/mqdefault.jpg ==> 200 OK (1s)
[Fri Mar 16 13:47:13 2018]: WARNING **: Invalid borders specified for theme pixmap:
        /usr/share/themes/Breeze/gtk-2.0/../assets/line-h.png,
borders don't fit within the image at /usr/bin/gtk-youtube-viewer line 3074.
** GET https://www.youtube.com/get_video_info?video_id=LatorN4P9aA&el=detailpage&ps=default&eurl=&gl=US&hl=en ==> 200 OK
2017.9.27
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/avideo/extractor/youtube.py", line 1183, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python3.4/site-packages/avideo/extractor/youtube.py", line 1114, in _extract_signature_function
    raise ExtractorError("Youtube's DRM has prevented this software from obtaining the video URL", expected=True)
avideo.utils.ExtractorError: Youtube's DRM has prevented this software from obtaining the video URL
 (caused by ExtractorError("Youtube's DRM has prevented this software from obtaining the video URL",)); please report this issue on https://notabug.org/GPast/avideo/wiki/bug . Make sure you are using the latest version; see  https://notabug.org/GPast/avideo/wiki/update  on how to update. Be sure to call avideo with the --verbose flag and include its complete output.
-> Resolution: 480
-> Video itag: 244
-> Audio itag: 251
-> Video type: video/webm; codecs="vp9"
-> Audio type: audio/webm; codecs="opus"
** Backgrounding process: mpv --audio-file https\:\/\/r3\-\-\-sn\-nvm\-cxbs\.googlevideo\.com\/videoplayback\?id\=o\-AF1ZL8u6x\-kXx8e3M78hwWHrmDeSl2MMzvcuhQsO96GB\&expire\=1521222458\&ip\=95\.169\.201\.19\&lmt\=1521053886966050\&gcr\=bg\&ei\=2q6rWtWlIsXq1gLPk6eIAQ\&mm\=31\%2C29\&pl\=24\&sparams\=clen\%2Cdur\%2Cei\%2Cgcr\%2Cgir\%2Cid\%2Cinitcwndbps\%2Cip\%2Cipbits\%2Citag\%2Ckeepalive\%2Clmt\%2Cmime\%2Cmm\%2Cmn\%2Cms\%2Cmv\%2Cpl\%2Crequiressl\%2Csource\%2Cexpire\&source\=youtube\&initcwndbps\=1835000\&keepalive\=yes\&c\=WEB\&clen\=4282274\&mime\=audio\%2Fwebm\&ipbits\=0\&fvip\=2\&requiressl\=yes\&dur\=264\.581\&mt\=1521200752\&mv\=m\&ms\=au\%2Crdu\&key\=yt6\&mn\=sn\-nvm\-cxbs\%2Csn\-4g5ednsz\&itag\=251\&gir\=yes --really-quiet --title Journey\ \-\ Separate\ Ways\ \(Worlds\ Apart\) --no-ytdl https\:\/\/r3\-\-\-sn\-nvm\-cxbs\.googlevideo\.com\/videoplayback\?id\=o\-AF1ZL8u6x\-kXx8e3M78hwWHrmDeSl2MMzvcuhQsO96GB\&aitags\=133\%2C134\%2C135\%2C160\%2C242\%2C243\%2C244\%2C278\&ip\=95\.169\.201\.19\&lmt\=1521054230116191\&gcr\=bg\&ei\=2q6rWtWlIsXq1gLPk6eIAQ\&key\=yt6\&pl\=24\&sparams\=aitags\%2Cclen\%2Cdur\%2Cei\%2Cgcr\%2Cgir\%2Cid\%2Cinitcwndbps\%2Cip\%2Cipbits\%2Citag\%2Ckeepalive\%2Clmt\%2Cmime\%2Cmm\%2Cmn\%2Cms\%2Cmv\%2Cpl\%2Crequiressl\%2Csource\%2Cexpire\&source\=youtube\&initcwndbps\=1835000\&expire\=1521222458\&keepalive\=yes\&c\=WEB\&clen\=16070821\&mime\=video\%2Fwebm\&ipbits\=0\&fvip\=2\&requiressl\=yes\&dur\=264\.564\&mt\=1521200752\&mv\=m\&ms\=au\%2Crdu\&mm\=31\%2C29\&mn\=sn\-nvm\-cxbs\%2Csn\-4g5ednsz\&itag\=244\&gir\=yes

And there is no running mpv process.
Also doesn't this output indicate that there is an attempt to first download the video (using avideo)?


fix(email-validator): use different email validation package

:tada: This PR is included in version 1.1.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can't overload async/await methods with NUnit Test Adapter

I'm getting a System.Reflection.AmbiguousMatchException when at least one of the methods are async and the method is overloaded when the NUnit tests are run using the NUnit Test Adapter <IP_ADDRESS> in Visual Studio. I'm able to run the tests without problem when I use the ReSharper unit test runner. I also posted this on StackOverflow
    [TestFixture]
    public class SimpleReproAttempt
    {
        [Test]
        [TestCase("I'm valid")]
        [TestCase("So am I!")]
        public async Task Foo(string resource)
        {
            Assert.IsNotNull(resource);

            await Task.Delay(new TimeSpan(0, 0, 1));
        }

        [Test]
        public async Task Foo()
        {
            Assert.IsNotNull(Guid.NewGuid().ToString("N"));

            await Task.Delay(new TimeSpan(0, 0, 1));
        }
    }

Does the test run correctl under the nunit console or gui runners?

Yes it runs correctly under the current stable release of the offical GUI test runner 2.6.4 (win) found at http://www.nunit.org/index.php?p=download

Thanks @ErikCL That will help us and it's good news! If the error were in NUnit 2.6.4, which we are not planning to maintain further, you'd be stuck. Since it only occurs in the adapter, it's should be something we can fix!
Please add info about the environment under which you are running the adapter.

I've noticed this bug on my local environment with Windows 8.1 running Visual Studio Ultimate 2013 Update 5. I've also noticed this bug on the standard Visual Studio Online hosted build server.

Confirmed.  Repro here. folder Issue87


Report code coverage

We should add integration with a code coverage provider like codecov or coveralls so we can report overall coverage and work towards 100% coverage. At the moment, we only have 68% coverage, meaning the tests don't even try to run 32% of the code and it may or may not work, at least for the versions we want to test.

Completed as part of #1011


Increase unit tests code coverage controller location

Increase unit tests code coverage controller location

Current coverage is 78.29% (diff: 100%)

Merging #488 into master will increase coverage by 0.50%

@@             master       #488   diff @@
==========================================
  Files            25         25
  Lines          2314       2428   +114
  Methods         396        396
  Messages          0          0
  Branches        197        197
==========================================
+ Hits           1800       1901   +101
- Misses          514        527    +13
  Partials          0          0

Powered by Codecov. Last update c42fa5c...c1567ba

https://github.com/redhat-developer-tooling/developer-platform-install/pull/491 replaces this PR


Stop tokenizer using start chars for attributes

This is a change to stop legitimate name characters in attribute names
causing errors, e.g. '-' should be allowed.

Thanks!


Question about the annotations methods for Sfaira pretrained models

hello,
Thank you very much for providing such a great software, it is very helpful for my research !!!
I noticed that you have provided a trained model(with annotations) to do automated annotations for other datasets.
I want to ask how the annotations in the model are obtained, which one of the following methods is used :

annotations from the published paper
manual annotation by your team
automatic annotation by software, such as scVI

Thanks !!!

Thanks @bitcometz! The models that we published on zenodo are trained based on the original annotation provided by data set authors!

Thanks @davidsebfischer ,
I also want to confirm one more thing:
For some data sets, if they are unable to obtain the annotation results of the article, in this case, I think that those data sets are annotated by your model.  Is that so?
Thanks !!!

We trained only on data setes with annotation, but it is a predicitve model, so you can always extrapolate to data sets that are not annotated!

thanks !!!

@davidsebfischer
hello，
Is there a way to know whether the annotations of this data set come from the article or the prediction from sfaira?
Thanks ！！！

Hi @bitcometz could you point me to what output of sfaira you are exactly looking at? The data loaders only report original annotation, no model imputation of labels.

hi, @davidsebfischer

For example, for this item "cell_type", I want to know is it from the original paper annotation or the predictions by the modle.
If the dataset has no original paper annotation, then the "cell_type" is full of None?
Thanks !!!

For example, for this item "cell_type", I want to know is it from the original paper annotation or the predictions by the modle.

The original one, but we mapped it to cell ontology, so named slightly differently. You can also find the original annotation in the object before you streamline, ie directly after load()!

If the dataset has no original paper annotation, then the "cell_type" is full of None?

Only after streamlining the data set streamline_metadata, otherwise it's even empty!

Thanks！


Problem opening Plaid Link : Can't find variable PLKLinkTokenConfiguration

For plugin nstudio/nativescript-plaid on iOS, when testing on iOS (14.4) the Plaid Link does not open and following error occurs :
2021-03-05 11:49:39.446 nsplaydev[3798:1258227] *** JavaScript call stack:
(
	0   UIApplicationMain@[native code]
	1   run@file:///app/tns_modules/@nativescript/core/application/application.js:312:26
	2   @file:///app/bundle.js:159:67
	3   ./app.ts@file:///app/bundle.js:175:34
	4   __webpack_require__@file:///app/runtime.js:817:34
	5   checkDeferredModules@file:///app/runtime.js:44:42
	6   webpackJsonpCallback@file:///app/runtime.js:31:39
	7   anonymous@file:///app/bundle.js:2:61
	8   evaluate@[native code]
	9   moduleEvaluation@:1:11
	10  @:2:1
	11  asyncFunctionResume@:1:11
	12  @:24:9
	13  promiseReactionJob@:1:11
)
2021-03-05 11:49:39.446 nsplaydev[3798:1258227] *** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: ReferenceError: Can't find variable: PLKLinkTokenConfiguration

I am using a Link Token in a sandbox environment
plaid iOS SDK 2.0.11

EDIT : Problem only occurs when using European accounts : they require an OAuth endpoint and in my case, it was not set properly. No problem when using US accounts.


include energy kernel for MMD loss

Situation/Background:
For the MMD loss only the Gaussian kernel and the inverse multiquadratic kernel are implemented
Changes made:
I implemented additionally the energy kernel as suggested in [1,2]
Still ToDo:
Sofar the kernel for the MMD loss can't be selected by the user but is by default the "gaussian" kernel.
[1] Feydy, J., Séjourné, T., Vialard, F. X., Amari, S. I., Trouvé, A., & Peyré, G. (2019, April). Interpolating between optimal transport and mmd using sinkhorn divergences. In The 22nd International Conference on Artificial Intelligence and Statistics (pp. 2681-2690). PMLR.
[2] Feydy, J. Geometric Data Analysis, beyond Convolutions. Ph.D. Thesis, Université Paris-Saclay, Gif-sur-Yvette, France, 2020.

Thank you for this PR! As discussed offline, I will close the PR as it was made against master rather than dev.


(add docs for how to configure to avoid) Issues recovering pre-computed blocks from logs as truncated due to length

In attempting to recover some missing archive blocks from my logging service (Loki) I noticed that some precomputed blocks were being truncated. It appears this is due to size. If the size of these log messages is expected then likely there needs to be a warning to that effect to ensure users are capturing the full log message.
This only appears to be an issue on some logs. Take these two:
Worked, and imported: https://gist.github.com/garethtdavies/d7bb391c1f52bcff556402362fbbff87
This one was truncated: https://gist.github.com/garethtdavies/525a2d5ebd523e092bbf77798658fbd8
Looking at the local logs the log for a pre-computed block that has issues is 6MB in size.
precomputed-log-line.txt.zip.

I'm also seeing this on the Gcloud uploads - is a 4.5MB pre-computed block considered normal?

This probably has to do with storing the snark work in the block logs. For that particular block there are 128 of them.

Ah, that makes sense. I was thinking this was more like the extensional format and only stored the data required by the archive node. Given an active chain, it seems this logging will be significant at circa 5MB per block

Maybe related to https://github.com/MinaProtocol/mina/issues/7380

@bkase  to provide a write up on how to write to a path instead of the std out

@bkase --precomputed-blocks-file is the flag I was talking about.


Allows to display progress messages by player instead to everyone on the server.

When a server has a lot of people, player advancements spam the chat, a lot of servers turn it off to make the chat clean.
My patch allows to keep it on the server but by sending it only to the player concerned and not to the whole server.

It's good


add poll for apps in helm install component

What this PR does / why we need it:

redirect from helm install page if there is an app installed

Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/60232/the-install-with-helm-screen-should-automatically-redirect-to-apps-page-when-a-chart-is-installed
Special notes for your reviewer:
with your kots install in helm mode, you can just navigate directly to /install-with-helm to test the redirect behavior.

Steps to reproduce

Does this PR introduce a user-facing change?
- fixes an issue where kots would not redirect from `/install-with-helm` automatically after an application is installed

Does this PR require documentation?
none

I'm updating the helm-managed suite by removing the step that manually navigates to the app page.


Fix -Wcast-align issues

gcc with -Wcast-align=strict, as well as clang (by default), warns about casting issues.
The typical case is when a record is read into a STRING (which being char * underneath only requires 1-byte alignment) and then the STRING is cast to INT32 (which requires 4-byte alignment) to read a (binary) integer value from the record.
This is detected (and tolerated) on the x86/x86_64 architectures where unaligned accesses do not cause problems.
However, on other architectures, such as ARM, will result in runtime failures.
(I suspect this will be the next big problem on ARM-based Mac systems, now that we've got most of our 64-bit issues resolved.)
The way I'm going to approach this is to:

create a RECSTRING type that has alignment hints
update string routines (such as strsave() and sz_str()) to respect alignment hints for the RECSTRING type

The RECORD-based issue only shows up once in load_nkey_list() when we try to read a packed node list from a record.
Another singleton case is in the report lexer when a STRING is returned as a PNODE directly and is used or freed by subsequent actions.
The more common case is when a STRING or ZSTR (which are 1-byte aligned char* types) are used in conjunction with wchar_t* which are 2/4-byte types.

On Linux, malloc() returns buffers that are " which is suitably aligned for any built-in type", which practically means that all allocated memory is 4/8-byte aligned (on 32/64-bit platforms).
In the context of all of these warnings. the pointers are suitably aligned, but since the native alignment provided by malloc() is not captured and propagated through our custom types, the compiler loses this information and warns.
It would appear that adding alignment hints to our standard types should resolve this.


[[When insted of the normal tiddler to learn

Hi,
I somehow must have somthing in one of my tiddlies becouse from one moment to another as I was going though the learning process, by goint to the fish icon, click it then due/undue and then by clicking  Forget or Remember or Grasp or Discard.
But then when I clicked one of the four options, only  [[When comes in the title of the tiddle and nothing in the tiddle body. When I click to Forgot or Remeber ... this tiddle closes and another opens with the same title and empty body.
Is there any log-file I can give you without revealing all my tiddles ?
Cheers,
Labi

Is there a tiddler in the queue with special characters in the title, e.g. [{|.
Special characters are not supported.

I had only ( and , in the title.  After I shortened all of them it works again.

Thanks for the quick response and help.


Update Spring and Jersey framework to latest release

Update Spring support to 5.0.2.RELEASE
Update Jersey to support 2.26

Resolving this since updates are committed and tested


Implement atcoder bot

Codecov Report

Merging #136 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #136     +/-   ##
=========================================
+ Coverage   44.39%   44.49%   +0.1%
=========================================
  Files          39       39
  Lines        3895     3895
  Branches      795      795
=========================================
+ Hits         1729     1733      +4
+ Misses       1703     1699      -4
  Partials      463      463

Impacted Files
Coverage Δ

mahjong/index.js
27.07% <0%> (+0.31%)
:arrow_up:

prime/index.js
17.79% <0%> (+0.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b730232...efb8e63. Read the comment docs.


Customizing prompts using Options -- variables throw command not found error when sourcing .zshrc

Hi all!
This issue may have been answered somewhere (though I spent some time checking but couldn't actually find it), still I believe it should be easily available information for any new user (ideally a step-by-step in the docs).
When trying to use the variables listed in the options section of the docs for some very basic customizations, the following issues come up:

The docs specifically say that you should specify the variables after sourcing spaceship-prompt however a bunch of issues here mention that doing so before is more correct and works more often. If this is the case then the line in the docs should be updated.
When trying to update certain variables (for eg. SPACESHIP_USER_SHOW) (either before or even after sourcing spaceship-prompt), they are not recognized and throw command not found errors.

I'm aware that there is probably a very easy solution which everyone knows -- however, for a new user or beginner in zsh/bash etc, it would be great to have some information about how exactly to proceed.
This is a pretty awesome repo and I would want it to be accessible (in every way) to as many people as possible. For that, maybe a slightly more detailed customization documentation is required.
Anyway, that's the problem. Thanks for your help!

I have the same problem, when customizing vim_mode, trying to replace standart [I] and [N] with nice unicode symbols:

When restarting the shell I get the following errors:
/home/weiss-d/.zshrc:82: command not found: SPACESHIP_VI_MODE_INSERT
/home/weiss-d/.zshrc:83: command not found: SPACESHIP_VI_MODE_NORMAL

@gpratyush Probably we should clarify our docs on this topic.
@weiss-d you should not use spaces around =. Assignment in zsh works only when it's not surrounded by spaces, otherwise, it's treated as a command. Try this instead:
SPACESHIP_VI_MODE_INSERT="[I]"


asanyarray: handle sequences containing dask Arrays

asarray worked on lists containing dask Arrays, but asanyarray didn't.
x = da.asarray([1, 2, 3])
# works
da.asarray([0, x[1], x[2]])
# failed
da.asanyarray([0, x[1], x[2]])

Looks like #5280 only changed asarray, not asanyarray. I made most of the asarray tests use both methods, just to guard against such drift in the future.
test_asarray_chunks was the only one with inconsistent behavior, because asanyarray sets chunks=a.shape, but asarray does not. Unclear to me if that's intentional---if not, I'm happy to make them consistent in this PR.

[x] Tests added / passed
[x] Passes black dask / flake8 dask

@jakirkham done. Looks like a new version of black was released a couple weeks ago, and I hadn't updated my env. But the python -m pip install black in travis pulled it in.

Thanks @gjoseph92! 😄


Add support for $min and $max operations

Sorry @plocharz-9livesdata! I didn't see that you were making the pull request against the wrong branch. It should be develop instead of master. I'm going to revert the changes an master. Can you please re-open your PR to develop?

Sorry about that @mdomke . I've created new pull request for develop branch: #235


Fix typos

Hey @OmarJalil, you need to sign the CLA to be able to contribute to the repo.

@cla-bot check

@dianaafanador3 Done! Do I have to do anything else?


[NNBD] No compile error in CFE to read non-initialized nullable variable in spread operator

The following code produces a compile error in analyzer and only runtime error in VM
main() {
  List? x2;
  Set? x3;
  Iterable? x4;

  Set res;

  res = {...x2}; // Analyzer error - An expression whose value can be 'null' must be null-checked before it can be dereferenced.
  res = {...x2}; // Analyzer error - An expression whose value can be 'null' must be null-checked before it can be dereferenced.
  res = {...x2}; // Analyzer error - An expression whose value can be 'null' must be null-checked before it can be dereferenced.
}

There must be compile error in CFE as well
Dart SDK version: 2.10.0-110.0.dev (dev) (Wed Sep 9 17:51:43 2020 -0700) on "windows_x64"

Proposed fix: https://dart-review.googlesource.com/c/sdk/+/164561.


Minor UI updates

@krishnacheemalapati 's updated UI

Good work, I have made one small change (we can revert it later if we want)

I have added text for the actual intent on top of the modal.
the "Intent: find_hotel" in the image


Added form-wide onChange functionality

Was suggested and attempted in #2530.
Fixes #883.

Codecov Report

Merging #2576 into master will not change coverage.

@@          Coverage Diff           @@
##           master   #2576   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          66      66
  Lines        1364    1367    +3
======================================
+ Hits         1364    1367    +3

Impacted Files
Coverage Δ

src/reduxForm.js
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c73c8d...5a37810. Read the comment docs.

Where is this fantastic new feature documented?

Uh, nowhere, at the moment!

This has some odd interaction with initialValues when the new global onChange event is used to submit the form on change.
In the reduxForm decorator's mapStateToProps, there is the following:
const shouldUpdateInitialValues = enableReinitialize && initialized && !deepEqual(initialValues, stateInitial)
const shouldResetValues = shouldUpdateInitialValues && !keepDirtyOnReinitialize

let initial = initialValues || stateInitial || empty

if (shouldUpdateInitialValues) {
  initial = stateInitial || empty
}

let values = getIn(formState, 'values') || initial

if (shouldResetValues) {
  values = initial
}

Specifically:
if (shouldUpdateInitialValues) {
  initial = stateInitial || empty
}

This always uses the state values, which are stale as initialize() is not called until reduxForm's componentWillReceiveProps (i.e. the component rendered by the connect() HOC). The end result is an infinite update loop (and the tab eventually being killed by the browser) as values & initialValues will continuously alternate.

@erikras just wondering if there is a minor version release planned soon. This patch in particular would be really useful to me. As usual, thanks for the great library!

Published in v6.6.0.

I'm having the same issue as @jscinoz in 6.6.0, can't use enableReinitialize with onChange.
For now, I'm using an ugly flag to skip unwanted calls to onChange. Did anyone had a better solution for this?

@jscinoz @j-machado: I think it may be related to #2427 and #2153.


Add support for landing zone manifest files

From the original issue by @holtgrewe:
Further, it would be useful to have support for "MANIFEST.txt" files that lists all files to be expected in the landing zone. This would allow for upload tools to append to this file first and then upload the files. Missing file+.md5 file uploads could thus be detected.

I would suggest something along the following spec.
What is the addressed problem?
We need to assure that the user's uploaded files are (a) correct, i.e., the uploaded content is identical with the source content, and (b) complete, i.e., there is no missing or extra uploaded file.
What is the current status?
We allow for uploading $file.md5 files together with the actual $file. This addresses problem (a) and is very useful for incremental file uploads.
However, we do not address (b) yet.
What does your proposed solution look like?
Optionally, users should be able to upload a SODAR_MANIFEST file. This file would contain the MD5 sums and full paths. In this case, all .md5 files become optional. When they are included, their content will be compared to the corresponding file's content anyway.
When transferring the landing zone with a manifest file, the files in the landing zone will be compared to the files in the manifest and the set of both files have to be equal. Further, the corresponding MD5 checksums in the manifest file are compared to the MD5 checksums in iRODS. If everything works out, the files are transferred and the $file.md5 files are created automatically based on the checksums in the manifest.
The manifest file itself is not included in the target iRODS storage.
Example for creating a manifest file.
# mkdir -p subdir
# head -c 100 /dev/random >subdir/foo
# head -c 100 /dev/random >subdir/bar
# for i in $(find . -type f | sort); do md5sum $i >>SODAR_MANIFEST; done
# cat SODAR_MANIFEST
d307d8a9635109d760c9e1dc90a54bad  ./subdir/bar
6a139e890ddcc8c2ae235c71ca772881  ./subdir/foo


Adds additional e2e tests and fixes existing ones

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-
Changed

Screenshots

@tim-yao have updated again

Hey @dylankelly This is a milestone of e2e tests. Just need CI passed. Somehow it's timeout at the moment.


Add --vector-catch flag

I have an interesting boot process where the chip (arm) bootloader will reset at least once during the process; having the vector catch enabled during this process will cause probe-rs run to halt and stop the boot process.
Alternatives
We make this a negative flag, i.e --no-vector-catch.

IMO this shold be 2 separate flags, for "catch reset" and "catch hardfault".


Save struct (perhaps through Serde?)

It would be really nice if one could do something like
struct Model {
    title: String,
    body: String,
}

let m = Model { title: "Title", body: "Body" };
coll.save(bson!{m});
# or even
coll.save(&m);

One way I attempted to do this was by using Serde:
use bson::to_bson;

#[derive(Serialize, Deserialize, Debug)]
struct Model {
    title: String,
    body: String,
}
let m = Model { title: "Title", body: "Body" };
coll.save(to_bson(&m).unwrap());

... and a variety of other things including from_bson and EjdbDocument.
I'm a Rust noob, so attempting to integrate this with Serde is beyond my understanding for now. Do you have any other suggestions as to how this could work?

This is something which should be provided by the bson-rs library. It appears it has some kind of support for automatic serialization through serde and rustc-serialize. Check whether it supports your use case; if it does, please write here and I'll bump the bson-rs dependency version if necessary.

Ah, I see. It indeed does have the serialization support in 0.3, but ejdb-rs depends on 0.2. I'll bump the version number and release the new version when I'll be able to, probably today or tomorrow.

The second example I gave is me trying to get bson-rs to work. That attempt fails with the error:
53 |         coll.save(to_bson(&self).unwrap());
   |              ^^^^ trait `bson::Bson: std::borrow::Borrow<ejdb::bson::ordered::OrderedDocument>` not satisfied

Yep, it happens because ejdb-rs depends on bson-0.2 but you seem use to_bson() from bson crate directly, instead of ejdb::bson module (which reexports the bson crate the library depends on).

Gotcha. OK. Looking forward to a new version number, and thank you :)

Fixed by #3.


Analyzer for internal types

Removes the SQL injection analyzer (#15034) and adds a new analyzer for internal type usage (#12104).
Some comments:

The default diagnostic level is warning. Considering that people opt in by installing the analyzer, it could be justified to make it an error.
The idea was to have the analyzer work on providers as well, which also have their pubternal types. So we warn on any type whose namespace contains EntityFrameworkCore and ends with .Internal.
At first I thought of just detecting and generating warnings on the using directives, rather than on method invocation, etc. The problem with that is fully-qualified names (no using), but also that we want to allow namespaces such as Npgsql.EntityFrameworkCore.PostgreSQL.Internal as long as its within the same Npgsql assembly. This kind of thing requires the semantic model, etc.
The analyzer detects member access on an internal type (including method invocation), instantiation and subclassing. There are probably some other expression types that we can catch, let me know if you think anything else is important.

@roji What about members that are documented as internal, but aren't part of types that are in the Internal namespace?
Also, not all provider writers are as diligent as others. If they haven't updated the namespaces they use so that they don't match this pattern, then they will get lots of warnings which they may just suppress as false positives.
Both reasons that I am still in favor of the attribute approach, rather than the namespace approach. 🚎

@ajcvickers it seems like I missed part of the conversation somewhere...! I'll be happy to do the analyzer in another way, but can you provide more details about what the "attribute approach" means, or point me in the right direction?

@roji The "attribute approach" is to define an attribute e.g. EntityFrameworkInternalAttribute and then add it to:

Any type that is fully internal
Members of public types that are considered internal

Then the analyzer would use this information to know whether or not the thing being used is internal.

Oh, OK - thanks.

Also, not all provider writers are as diligent as others. If they haven't updated the namespaces they use so that they don't match this pattern, then they will get lots of warnings which they may just suppress as false positives.

Do you mean that some providers may have types that are meant to be public-facing under Internal namespaces, thus triggering false positives? Do we have examples of this, should we adopt a new attribute everywhere just because some providers may be badly-organized? I do see that pubternal members/methods on public types are a usecase we can only support with an attribute, but do we think we have a significant number of those? I'm a bit worried that requiring an attribute in addition to the namespace (just for the purpose of the analyzer) would simply mean nobody uses it except for us.
If we do decide to go with the attribute-everywhere approach, does it make sense to stop having the namespace altogether and simplify our file organization?
And finally, regardless of namespace vs. attribute question, we can also pursue omitting internal types in the documentation system, allowing us to remove all the internal XML boilerplate comments everywhere.

Do you mean that some providers may have types that are meant to be public-facing under Internal namespaces...

Yes, that's expected (depending what you mean by public facing.) . But specifically the problem comes when the provider and EF share a pubternal namespace. See discussion starting at this comment: https://github.com/aspnet/EntityFrameworkCore/issues/11266#issuecomment-373228656
Our providers, and others, at least used to have their own internal types in namespaces like Microsoft.EntityFrameworkCore.Metadata,Internal. It is of course fine for the provider to use these types--they are pubinternal provider types.
The new recommendation is for providers to instead use namespaces like Microsoft.EntityFrameworkCore.SqlServer.Metadata,Internal, which makes it much easier to tell when the provider is using EF pubternals, as opposed to its own pubternals.
So if a provider is still using the old conflicting namespaces, then the analyzer will flag them. But this is a false positive. Once provider writers start to have to skip false positives I think we lose a lot of value from having the analyzer. It will be all to easy to skip something that isn't a false positive.

@ajcvickers reading this again, I understand (and remember...) the provider transition from the common namespaces (Microsoft.EntityFrameworkCore.Metadata.Internal) to provider-specific ones (Microsoft.EntityFrameworkCore.SqlServer.Metadata.Internal), but I don't quite see the issue...
The way the analyzer currently works in this PR, usage of a type is flagged with a warning if:

Its namespace contains EntityFrameworkCore and ends with .Internal
It doesn't reside in the same assembly as the referencing code.

The 2nd one is the important bit: a provider with types in Microsoft.EntityFrameworkCore.Metadata.Internal can use those types internally with getting flagged, since they're in the same assembly. However, if it attempts to use types from that same namespace but from another assembly (i.e. EF Core itself) it will get a warning.
That still leaves the issue of pubternal members on public types, which of course can't be covered via namespace detection, but only via an attribute. I'm not sure I've seen many cases that require this, but if we think it's important we could still introduce the attribute and have both logics implemented in the analyzer. The point is to not force people to do two manual things in order to make a type internal - both place it in a namespace and add an attribute - as there's a chance at least one would be forgotten. Keeping the namespace logic would also reduce the attribute clutter in our codebase.
But if you feel strongly about just going with attributes I'll go ahead and implement that.

@roji I missed that the usage had to be from another assembly. That does seem much safer.
For the other point, I will go look how many internal members we would be missing.

@roji Looks like there are currently 304 usages--see #15106

@roji Although we should review these.

@ajcvickers OK. Assuming at least some of these are legit, I can add the attribute. I propose that we retain the namespace behavior as well, which simplifies the process for types already in the Internal namespace.
Does that make sense? If so I'd uncomment all 304 usages mentioned above, and later we could go over and remove some that we want to make public.

@roji Sounds good.

Pushed a new version, ready for review:

Introduces [EntityFrameworkInternal] attribute and includes @ajcvickers's attributes from #15106
The new attribute is recognized on methods, members and types and causes a warning to be generated.
In addition, any type in a namespace matching *.EntityFrameworkCore.*.Internal is also flagged.
No warnings are generated if the reference is within the same assembly, like regular internals.

To do:

Add an exemption for references from EFCore.Relational to EFCore (and possibly other internal references)

Rebased on later master and force-pushed. The last remaining thing seems to be to decide on the message - the current one is the same that we have in our xmldocs, but we may want to improve. Waiting for @divega.


dco-check: 0.5.0

Useful lil' script for running against incoming PRs in CI, to check that all the commits in it have a Signed-off-by trailer.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I remember there being a way to refer to version without rec (taking a closure somehow?), but I can't find how to do that rn.


Can't patch XR metadata

What happened?
Status propagation works
            apiVersion: example.crossplane.io/v1beta1
            kind: XR
            status:
              dummy: cool-status

But metadata propagation does not.
            apiVersion: example.crossplane.io/v1beta1
            kind: XR
            metadata:
                  annotation:
                      cool: annotation

How can we reproduce it?
Try to set custom annotation for XR as in the example above. You will notice that annotation is not propagated to the XR
What environment did it happen in?
Function version:  v0.4.1

This is because function can't update the xr outside of the status. See the upstream related issue.


Supported module list in changelog is incomplete

https://docs.silverstripe.org/en/4/changelogs/4.11.0/
Supported modules (toggle open)
Missing session-manager despite it being in the cow plan.  Probably missing multiple others.

Closing as a duplicate of #229


Respect panel_orientation_quirks when determining default rotation

Hyprland Version
v0.32.0
Bug or Regression?
Bug
Description
The Linux kernel has a mapping of known devices to their primary intended orientation.  This is useful, for instance, in gaming handhelds, where portrait-oriented tablet screens are installed in a landscape orientation.  Hyprland should use thie by default - displaying in the orientation described by the kernel if present.
How to reproduce
Install Hyprland on a device listed in drm_panel_orientation_quirks (or patch the kernel to add a quirk for the device you're testing on), and observe that Hyprland does not automatically match the prescribed rotation with
monitor=,preferred,auto,auto

Crash reports, logs, images, videos
No response

Hyprland should use thie by default - displaying in the orientation described by the kernel if present.

No, this is not KDE.
Ignoring how those drm props are not exposed to us via wlroots, there already is a third-party daemon for hl that does this, I just forgot the name.

It looks like this is exposed in wlroots and supported in sway.
I don't understand why you'd want the first launch to be wrong until someone manually sets the transform or discovers and runs some third party daemon.

woops, didn't see that


Update serverless-saas-stack.ts

Python runtime change from 3.8 to 3.9 in order to ensure consistent deployment of the serverless-saas-pipeline deploy phase
Issue #, if available:
lambda-deploy-tenant-stack.lambda_handler still leveraging Python3.8  Issue#56
Description of changes:
serverless-saas-stack.ts modified to use Python 3.9 runtime.  Lambda application deployment changed and Codepipeline for serverless-saas-pipeline deploy phase launches correctly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tvanceadv , thanks for the contribution!


Errors when trying to import .scss files in TextField

Hi, I tried @import "preact-material-components/TextField/_mixins.scss"; in order to use the sass mixins to style the textbox, however i get this error:
@import "bottom-line/mixins"; ^       File to import not found or unreadable: bottom-line/mixins.
I want to change the text label color, and I'm using sass. Thank you for your help! 😄
P.S:
How do I change the label color in general? I'm really confused on how to style Textfield and other preact-material-components in general.. some help would be great! Thank you so much!
I'm also pretty new to Sass too...

oh yeah! that is because they have created a new component bottom-line.
This will be fixed in 1.3.6 version

also did you just tried doing it with normal css selector higher specificity?

@prateekbh How do I change the label color in general? I also have issues with changing the colors of the resting switch with scss, I imported the .scss file from preact-material-components/mdc-switch and in my style.scss I tried to do @include mdc-switch-track-color($color) in a subclass but I couldn't change the track color. Please help me.  I also tried to do it with css selectors but it didn't work.
Thank so much!

Should be fixed


fix: allow null mask props

Description
Allows passing a null mask prop

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.73.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Platform-specific contribution emoji

A lot of times open source projects only support one or a few platforms and a contributor will port or add support for a previously unsupported platform. It would be cool if they could be recognized for that (usually significant) contribution.

Agreed 👍 what emoji do you propose?

I was hoping there would be Windows/iOS/Android/MacOS/Linux emoji, but I guess I'm just spoiled by Slack's custom emoji. 😢 Maybe 🚉as a stand-in for "platform"? That's pretty weak, but it's all I've got for the moment. Certainly open to other suggestions.

That sounds fine to me! Feel free to make a pull request :+1:

I'll give it a bit of time to see if anyone else has better suggestions, but I'm totally up for doing a PR.

:computer: ?
Also, there are colored hearts:
💙  windows?
💚  Android
🖤  iOS
💛  Linux
❤  Mac
💜  Other

I'd rather just have one emoji for the whole concept and 💻 is already taken :)

I'm running into similar where I have to recognize the people shepherding that essential part of my projects and it's keeping me from being all in on all-contributors.
What about 📦 for packaging/porting?

I'm fine with either. The first PR gets to choose the emoji :wink:

I think I like 📦 better than 🚉.

Awesome! I didn't want to steal your thunder @kevinvangelder - just happy another internet friend wants to solve the same problem. 😄

We'll probably also want a PR on the cli.

Sgtm! Hoping i can get in there but we'll see who can write the codez first.


How to change taxation process

Hi I want to change the taxation process (showing products with taxes).
Should I change the code in webkul package ?
Please suggest how to do changes.

Hi @rohan7chaudhary
This feature request is already raised https://github.com/bagisto/bagisto/issues/4463.

Hi @rohan7chaudhary
This feature request is already raised https://github.com/bagisto/bagisto/issues/4463.

Hi @rohan7chaudhary
This feature request is already raised #4463.

Hi @vaishaliwebkul , Thanks for your prompt response.
My next question is can we change the code in webkul package ?
What could be the consequences.?
If there is some more elegant way of doing this, please suggest.

Hi @rohan7chaudhary
This feature request is already raised #4463.

Hi @vaishaliwebkul , Thanks for your prompt response.
My next question is can we change the code in webkul package ?
What could be the consequences.?
If there is some more elegant way of doing this, please suggest.

Hi @rohan7chaudhary,
If you change the package, then maybe you face some problems during an upgrade if conflicts occur.
The better way is to override the class. So that you can define your custom functionalities.

Hi @rohan7chaudhary,
If you change the package, then maybe you face some problems during an upgrade if conflicts occur.
The better way is to override the class. So that you can define your custom functionalities.


WebSocket Connection Failed

We are getting below error while clicking on mic button. Any help on this will be appreciated.
WebSocket connection to 'wss://speech.platform.bing.com/speech/recognition/interactive/cognitiveservices/v1?format=simple&language=en-US&Ocp-Apim-Subscription-Key=6f9971474e0041b7aa40d122dc0fb145&X-ConnectionId=AF89B5FFD67145929DD038EDC475FC65' failed: Error during WebSocket handshake: Unexpected response code: 403

Hi @compulim,
There is no option to create Bing Speech API Key since it has replaced with new speech service and the webchat is not compatible with newer one. Any help in this case will be appreciated.

@compulim the key i am using is perfectly fine.
if i make a call to this endpoint
https://eastus.api.cognitive.microsoft.com/sts/v1.0/issuetoken
Ocp-Apim-Subscription-Key: MY_KEY
Method: POST
i am getting a token from above API call.
and this token is used in below call to Cognitive service.
WebSocket connection to wss://speech.platform.bing.com/speech/recognition/interactive/cognitiveservices/v1?format=detailed&language=en-US&Authorization=GENERATED_TOKEN failed: Error during WebSocket handshake: Unexpected response code: 403
ConnectionEstablishErrorEvent | metadata: {} | connectionId: D41CB45AAAAC4092B802115A69BA9886 | statusCode: 1006 | reason:  OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 i.connectionState.r.ConnectionState.Disconnected.i.connectionEstablishDeferral.i.websocketClient.onclose @ webchat.js:67
RecognitionEndedEvent | metadata: {} | requestId: D303B6BA0EAC4C9D8CA89B20D1EECD51 | audioSourceId: DB3BAA83BF8C4F809C6CA27F5901E80C | audioNodeId: 425C937AB8F6469FBEB2421FD1F5E672 | connectionId: D41CB45AAAAC4092B802115A69BA9886 | authFetchEventId: 09D5A88B0EC942DABF1C8CC931174A26 | status: 7 | error:  | serviceTag: <NULL> OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnComplete @ webchat.js:67 OnConnectionEstablishCompleted @ webchat.js:67 (anonymous) @ webchat.js:67 (anonymous) @ webchat.js:67 ExecuteSuccessCallback @ webchat.js:67 Resolve @ webchat.js:67 Resolve @ webchat.js:67 i.connectionState.r.ConnectionState.Disconnected.i.connectionEstablishDeferral.i.websocketClient.onclose @ webchat.js:67
Any help is really appreciated.

@compulim the key i am using is perfectly fine.
if i make a call to this endpoint
https://eastus.api.cognitive.microsoft.com/sts/v1.0/issuetoken
Ocp-Apim-Subscription-Key: MY_KEY
Method: POST
i am getting a token from above API call.
and this token is used in below call to Cognitive service.
WebSocket connection to wss://speech.platform.bing.com/speech/recognition/interactive/cognitiveservices/v1?format=detailed&language=en-US&Authorization=GENERATED_TOKEN failed: Error during WebSocket handshake: Unexpected response code: 403
ConnectionEstablishErrorEvent | metadata: {} | connectionId: D41CB45AAAAC4092B802115A69BA9886 | statusCode: 1006 | reason: OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 i.connectionState.r.ConnectionState.Disconnected.i.connectionEstablishDeferral.i.websocketClient.onclose @ webchat.js:67
RecognitionEndedEvent | metadata: {} | requestId: D303B6BA0EAC4C9D8CA89B20D1EECD51 | audioSourceId: DB3BAA83BF8C4F809C6CA27F5901E80C | audioNodeId: 425C937AB8F6469FBEB2421FD1F5E672 | connectionId: D41CB45AAAAC4092B802115A69BA9886 | authFetchEventId: 09D5A88B0EC942DABF1C8CC931174A26 | status: 7 | error: | serviceTag: <NULL> OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnEvent @ webchat.js:67 OnComplete @ webchat.js:67 OnConnectionEstablishCompleted @ webchat.js:67 (anonymous) @ webchat.js:67 (anonymous) @ webchat.js:67 ExecuteSuccessCallback @ webchat.js:67 Resolve @ webchat.js:67 Resolve @ webchat.js:67 i.connectionState.r.ConnectionState.Disconnected.i.connectionEstablishDeferral.i.websocketClient.onclose @ webchat.js:67
Any help is really appreciated.
Update:

I have tried websocket.js from https://cdn.botframework.com/botframework-webchat/latest/webchat.js & https://cdn.botframework.com/botframework-webchat/master/webchat.js. but none of them works.

what is solutions to ressolved it

No, fix as of i know. we changed our approach. we are building a Xamarin forms application and we build our own bot client using DirectLine API's. and now using Cognitive Speech Service REST API's to make Speech to Text and Text to Speech Conversion. But it also has a 15 seconds limit on REST API's. and There is no limit on SDK. But, sadly no SDK for Xamarin.

Actually I used in angular but not work...can you suggest any approach for
speech to text
On Mon 10 Dec, 2018, 2:15 PM Jawand Singh<EMAIL_ADDRESS>wrote:

No, fix as of i know. we changed our approach. we are building a Xamarin
forms application and we build our own bot client using DirectLine API's.
and now using Cognitive Speech Service REST API's to make Speech to Text
and Text to Speech Conversion. But it also has a 15 seconds limit on REST
API's. and There is no limit on SDK. But, sadly no SDK for Xamarin.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotFramework-WebChat/issues/1257#issuecomment-445735333,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AinMSPgjGn0kwzHTF8dg8fr9PHjZO9lWks5u3h8qgaJpZM4YBUIL
.

I would suggest either wait for it to get fixed.
Or
use REST API's and do it on your own. (Beware there is 15 seconds limit) https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/rest-apis
Or
debug the webclient library and check if the library is using old urls.
as new urls looks like with region (eastus, westus, etc.) https://eastus.stt.speech.microsoft.com/speech/recognition/conversation/cognitiveservices/v1?language=en-US

This is a hack.
ok, i did a quick PoC on changing the URL's from above webclient.js file and it worked.
Here, is what you need to do.

download the webclient.js from here https://cdn.botframework.com/botframework-webchat/master/webchat.js

Change two endpoints

find  https://api.cognitive.microsoft.com/sts/v1.0/issueToken and replace it with this https://{your-region}.api.cognitive.microsoft.com/sts/v1.0/issueToken
find wss://speech.platform.bing.com and replace it with this wss://{your-region}.stt.speech.microsoft.com

I haven't changed the URL for Text to Speech but this (https://speech.platform.bing.com/synthesize) is what you need to find from the js file. and replace it with new cognitive services URL and see if it works or not.


Add SkipBlocks option for DescribedClass cop

Now the following code will never be flagged:
describe MyClass do
  Class.new  { foo = MyClass }
  Module.new { bar = MyClass }
end

With the SkipBlocks option enabled the following code would receive the following flags:
describe MyClass do
  controller(ApplicationController) do
    bar = MyClass
  end

  before do
    MyClass
    ^^^^^^^ Use `described_class` instead of `MyClass`

    Foo.custom_block do
      MyClass
    end
  end
end

With SkipBlocks disabled (the default option) the code would receive the following flags:
describe MyClass do
  controller(ApplicationController) do
    bar = MyClass
          ^^^^^^^ Use `described_class` instead of `MyClass`
  end

  before(:each) do
    MyClass
    ^^^^^^^ Use `described_class` instead of `MyClass`

    Foo.custom_block do
      MyClass
      ^^^^^^^ Use `described_class` instead of `MyClass`
    end
  end
end

@andyw8 would love your feedback here

I would need to spend some more time to better understand this, but I don't see any blockers, so feel free to merge if you're happy with it.

Thanks @andyw8.
After today's opened issue about semver I'm considering just always releasing a minor version bump unless I'm releasing a bugfix. Think that sounds reasonable?

Yeah, seems the right approach.
On Wed, 3 Aug 2016 at 8:38 am, John Backus<EMAIL_ADDRESS>wrote:

Thanks @andyw8 https://github.com/andyw8.
After today's opened issue about semver I'm considering just always
releasing a minor version bump unless I'm releasing a bugfix. Think that
sounds reasonable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nevir/rubocop-rspec/pull/147#issuecomment-237165458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA0WEzbgKI3zKtDfazOl771CgI37C4zks5qcEVWgaJpZM4JbXxF
.


Add a watermark when done

The generated watermark file is watermark.txt
It contains a timestamp in UTC + the must-gather-clean version

/label tide/merge-method-squash


Unable to Install node-problem-detector version v0.8.19 on Rocky Linux version 8.10

Hi!
Installation of node-problem-detector-v0.8.19-linux_amd64.tar.gz (https://github.com/kubernetes/node-problem-detector/releases/download/v0.8.19/node-problem-detector-v0.8.19-linux_amd64.tar.gz) on rocky linux OS gives below error.
Installation Error:
libc.so.6(GLIBC_2.32)(64bit) is needed by node-problem-detector-0.8.19
libc.so.6(GLIBC_2.34)(64bit) is needed by node-problem-detector-0.8.19
GCC Version Installed On Host:
$ ldd --version
ldd (GNU libc) 2.28
Since upgrading gcc version on host is not an option, should I build the project with CGO_ENABLED:=0?  If yes, could you pls provide the necessary flags to set for the build.

We need cgo to build log-counter binary. You could disable it by running ENABLE_JOURNALD=0 make build-tar: https://github.com/kubernetes/node-problem-detector/blob/369020d878d03fffcb35d40482c3d400448ce1a4/Makefile#L97

/close
Please reopen if the above comment doesn't help.


Lots of java.lang.NoSuchMethodError warnings

I haven't yet worked out why, but for some reason when I run lein ancient on my projects using lein-ancient 0.6.15 (Leiningen 2.8.1, Clojure 1.9.0 and Java 1.8.0_151), I see a lot of output like the following:
(warn)  [releases] - Δ    2ms - failure when checking environ/environ: java.lang.NoSuchMethodError: com.amazonaws.util.StringUtils.trim(Ljava/lang/String;)Ljava/lang/String;
(warn)  [releases] - Δ    1ms - failure when checking com.codahale.metrics/metrics-logback: java.lang.NoSuchMethodError: com.amazonaws.util.StringUtils.trim(Ljava/lang/String;)Ljava/lang/String;
(warn)  [releases] - Δ    0ms - failure when checking ch.qos.logback/logback-classic: java.lang.NoSuchMethodError: com.amazonaws.util.StringUtils.trim(Ljava/lang/String;)Ljava/lang/String;
(warn)  [releases] - Δ    0ms - failure when checking clj-http/clj-http: java.lang.NoSuchMethodError: com.amazonaws.util.StringUtils.trim(Ljava/lang/String;)Ljava/lang/String;

@joelittlejohn Looks like there might be a conflicting version of the AWS SDK on your classpath. Can you paste your profiles.clj and the output of lein deps :plugin-tree?

Hmm, there's something a little more going on here. When I use lein-ancient in my profiles.clj, I see the warnings. When I add it to my project directly (even when my profiles.clj is still intact) I don't see the warnings :thinking:
I'll do some more investigation and reopen this if I find any evidence that something needs to change in lein-ancient :slightly_smiling_face:

Just in case anyone else finds this, in the end my problem was this plugin [s3-wagon-private "1.2.0"]. Upgrading to [s3-wagon-private "1.3.1"] causes an upgrade of aws-java-sdk-s3 and fixes these 'failure when checking' warnings.
See also #82


Add SPM support and migrate to Swift 5.1

This PR bumps to Swift 5.1 and adds support for Swift Package Manager. It also lowers the required deployment target to 9.0 since there is nothing in the library that requires a higher target sdk.
I have verified that it still works by adding it to a SwiftUI project using SPM, then presenting toasts from the application's key window's root view controller.

This is awesome! Thanks for doing this!

Thanks for a great library :)


Properly parse path separators in format-like postfix

I haven't looked at the code, does it work even for longer paths (foo::bar::baz())? Maybe we should have a test.
bors d+

Doesn't hurt adding those 2 to the tests 👍
bors r+


how to merge all geojson files into 1 single layer?

I use this, it works,
tippecanoe -zg -o counties-merged.mbtiles -l counties --coalesce-densest-as-needed --extend-zooms-if-still-dropping tl_2010_17_county10.geojson tl_2010_18_county10.geojson
However, I want to merge 50 geojson files for all 50 states into single layer, single mbtiles,
type all 50 states name is a pain!
Is there any default setting automatically read all files within such folder and merge them all into 1 layer?

You can use a shell wildcard for multiple files:
tippecanoe -zg -o counties-merged.mbtiles -l counties --coalesce-densest-as-needed --extend-zooms-if-still-dropping dirname/*.geojson

it works, thanks.
I run this:
tippecanoe -o microsoft_us_building_footprint.mbtiles -l microsoft_us_building_footprint -zg --drop-densest-as-needed --extend-zooms-if-still-dropping *.geojson
-l single layer name
-o output file
-zg auto max zoom level

It works perfectly, now I be able to merge all 50 states into single geojson 28.8GB, then convert to mbtile as 3.8GB, here is result:
https://transparentgov.net:3200/pbf/mapbox_default?&layer=microsoft_us_building_footprint&center_lat=38.907192&center_long=-77.036873&center_zoom=11&url=https://transparentgov.net/tileserver/microsoft_us_building_footprint/{z}/{x}/{y}.pbf


Improve the console output

Linked issue: #2
As of now, the amount of potentiel threats removed is the only displayed information.
Having two output formats would be fine, with a toggle: 👨 (textual) & 🤖  (json).
Nice informations to include:
For the 👨 display, name & location of the threat ("Macro executed when the document is opened", "Active.X object in the 2nd page" ....), list of the removed content
For the 🤖 output: same thing, with internal data?

This output should be sent to syslog instead/before output

Commit 43a516b adds a json output option, I'll consider this issue closed
The output (json/log) is sent to STDERR by SLF4J, sending it to syslog seems weird to me as this is not a daemon (for now, atleast)


Name the thread in ConditionAwaiter#pollSchedulingThread

In
org.awaitility.core.ConditionAwaiter#pollSchedulingThread
a thread is created that doesn't have a name.
I think it could be helpful if that thread had a name containing "awaitility"

@jschneider can we close this issue?

Yes I think so!


Results of paper reproduction

Thank you very much for your work; I have been following it since the beginning. I would really like to know if you have reproduced the results from the original paper. I also created a multilingual OCR version, using LoRA to fine-tune all layers of the model, but the performance was quite poor. I'm looking forward to your response, thank you very much.

hello @Mistsink, thank you for reaching out and closely following my work.
to reproduce the results from the original paper, the model needs to be pre-trained with 10b examples (according to the paper). without this step, no amount of fine-tuning is going to give us the results we desire. for example, i was able to achieve 99% accuracy on IAM train set, but only 75% on the test set. in the paper however, using the pre-trained model, the accuracy on IAM is in the high 90s, which shows the importance of pre-training the model.
this is a personal project i am doing at home in my spare time with an A4000 (16GB) card. while i will (hopefully soon) manage to do some amount of pre-training, it will not be at the scale described in the paper; for that, i will need to hire a cluster of A100s or H100s, and i don't have the budget for that.
out of curiosity, can i ask if you are working on scene text or printed text? or is it handwritten text?

Thank you very much for your prompt reply; I thought you would be resting at this time. I understand that this paper primarily aims to address the OCR tasks for multilingual and multi-line texts, involving scene text, printed text, and handwriting, with printed text being the most prominent. If you don't mind, we could explore some collaboration. I currently have four 3090 GPUs available for use. I hope this won't cause you any inconvenience.

hhhh I am more interested in whether the architecture proposed in this paper is effective; I want to try out multilingual models, rather than just replicate the paper. If you have any ideas, can we connect on a software where it's convenient for us to communicate later?

interesting idea. sure, perhaps with some refactoring, i can make the model configurable for multilingual and point you in the right direction.
happy to connect. may i know your whereabouts so that i get an indication on your timezone?

I am in China, which is in the UTC+8 time zone. I can use Telegram or Discord; which one works best for you?

I am 3 hours ahead of you. What about connection via Discord?
Can we do it one of the weekdays next week if you are good with that?

I'm happy to do so! How can I add you on Discord? We can discuss the details there.

Thank you for your efforts. I would like to inquire about the current status of reproducing the results from certain papers. I have GPU computing resources available on my side which could provide some assistance. Can we discuss this further?

hello @Mistsink, thank you for reaching out and closely following my work.你好，感谢您伸出援手并密切关注我的工作。
to reproduce the results from the original paper, the model needs to be pre-trained with 10b examples (according to the paper). without this step, no amount of fine-tuning is going to give us the results we desire.为了重现原始论文的结果，需要用 10B 个样本对模型进行预训练（根据论文）。如果没有这一步，再多的微调也无法给我们带来我们想要的结果。 for example, i was able to achieve 99% accuracy on IAM train set, but only 75% on the test set. in the paper however, using the pre-trained model, the accuracy on IAM is in the high 90s, which shows the importance of pre-training the model.例如，我在 IAM 训练集上能够达到 99% 的准确率，但在测试集上只有 75% 的准确率。然而，在论文中使用预训练模型时，在IAM上的准确率在90s以上，这表明了预训练模型的重要性。
this is a personal project i am doing at home in my spare time with an A4000 (16GB) card.这是我在空闲时间在家里使用 A4000 （16GB） 卡进行的个人项目。 while i will (hopefully soon) manage to do some amount of pre-training, it will not be at the scale described in the paper; for that, i will need to hire a cluster of A100s or H100s, and i don't have the budget for that.虽然我会（希望很快）设法做一些预训练，但不会达到论文中描述的规模;为此，我需要租用一组 A100 或 H100，但我没有这方面的预算。
out of curiosity, can i ask if you are working on scene text or printed text? or is it handwritten text?出于好奇，我能问一下你是在处理场景文本还是印刷文本吗？还是手写文本？

Thank you for your efforts. I would like to inquire about the current status of reproducing the results from certain papers. I have GPU computing resources available on my side which could provide some assistance. Can we discuss this further?

@Mistsink are you able to find me using the same username as my github account?

Thank you for your efforts. I would like to inquire about the current status of reproducing the results from certain papers. I have GPU computing resources available on my side which could provide some assistance. Can we discuss this further?
@Past-Tang are you also keen on reproducing the DTrOCR model?

@arvindrajan92 Where is the project currently at? Can we work together to complete the pre-training tasks and attempt to reproduce the performance reported in the papers?

@arvindrajan92 Where is the project currently at? Can we work together to complete the pre-training tasks and attempt to reproduce the performance reported in the papers?

@I am currently trying to implement key-value caching by referring to HuggingFace's GPT2 implementation. This would improve inference speed.
I am thinking of refactoring the model to be more flexible to accept multilingual. Currently it's designed only for English text using GPT2 vocabulary. If I could successfully refactor the model and its processor, do you have the resources to replicate the training done in the paper?

@arvindrajan92
On my end, I have four NVIDIA A6000 48GB GPUs. If we can expect good results, there's also some additional computing power available. If you think your task can be completed with these resources, I believe we could proceed with the training.

@Past-Tang key-value caching is still a work in progress and i anticipate finishing up that bit this week.
once that is done, i will look into making the model more flexible for multilingual OCR. currently, i am using GPT2's tokeniser, which is English. assuming you can 1) get the dataset ready following the procedures outlined in the paper; and 2) have a tokeniser module for encoding and decoding, you should be good to pre-train the model for languages of your choice.

@arvindrajan92 Hey, dear brother, how's the progress going? I've been following your repository.

hi @Past-Tang, it's been a little slow but i am making progress. i have added some cards for training and benchmarking scripts. currently i am working on making some notes for preparing the dataset here.
once i can get the model pre-training in a short trial run, i would be more confident in making changes to support multilingual ocr.


Bypass the mock adapter

It would be helpful to be able to bypass the mock adapter in tests for certain tests. I can imagine this is quite a difficult request.
Here's the justification:
I have one client that communicates with ElasticSearch and another client that communicates with some other API. My app pulls information from the API and stores it in ElasticSearch. Since ElasticSearch is running locally (and since you shouldn't really mock a database in tests), it would be nice to bypass it for these requests. The proposed API could look like this:
Tesla.Mock.mock fn
  %{url: "http://localhost" <> _} ->
    :bypass
  %{method: :get, url: "http://example.com/hello"} ->
    %Tesla.Env{status: 200, body: "hello"}
end

Actually, I just realized that my specific use-case is addressed by:
# config/test.exs
config :tesla, adapter: :mock
config :tesla, MyClient, adapter: :httpc


Update README.md

Add JDK 1.8+ requirement and update Using ONNX-MLIR section.

thanks for your quick update

@AlexandreEichenberger the patch hasn't been merged yet.


Helm chart install failed when install multiple times with CRDs

We found this issue in federation v2 helm chart at https://github.com/kubernetes-sigs/federation-v2/issues/557
The use case is as following:

Federation v2 helm chart include some CRDs.
Install the federation v2 helm chart on my k8s cluster in namespace1, install succeed and all CRDs are installed.
Install the federation v2 helm chart on my k8s cluster in namespace2, install failed due to CRDs already exist.

Does there are any solutions to make the CRDs can be shared between different releases?

I can take a shot at this. We want the behavior created by @calind's response to be default?

@calind This solution looks promising, however we are checking for the group (clusterregistry.k8s.io) to be present in .Capabilities.APIVersions.
Is there a way to check for the specific name (clusters.clusterregistry.k8s.io)?

.Capabilities.APIVersions.Has $version indicates whether a version (batch/v1) is enabled on the cluster.
Does that help?


Create GUI with tkinter or some other UI toolkit

I'm happy to do this :)

This is rendered useless by integrating into Ringing Room


Failed to ConfigSet when an absolute path is given as an argument

Prerequisites

[x] Can you reproduce?
[x] Are you running the latest version of SoftEtherVPN?

SoftEther version: Version 4.39 Build 9772   (English)
Component:Server [Server, Client, Bridge, etc.]
Operating system:Linux [Windows, Linux, BSD, macOS, etc.]
Architecture:64bit [64 bit, 32 bit]
[In case it's a computer with known specs, such as the Raspberry Pi, you can specify it omitting the details.]
Processor: [Specify brand and model. Example: AMD Ryzen 7 1800x]
Description
Expected behavior:
The ability to give an absolute path as an argument to the VPN Server's ConfigSet command.
example:
# /usr/local/vpnserver/vpncmd /server /csv /cmd ConfigSet /usr/local/vpnserver/vpn_server.config

Actual behavior:
occured error.
but it works fine if you pass a path relative to the vpncmd or give path by interactive.
Is this the intended behavior?
↓ absolute path
# /usr/local/vpnserver/vpncmd /server /csv /cmd ConfigSet /usr/local/vpnserver/vpn_server.config
Specify the host name or IP address of the computer that the destination VPN Server or VPN Bridge is operating on.
By specifying according to the format 'host name:port number', you can also specify the port number.
(When the port number is unspecified, 443 is used.)
If nothing is input and the Enter key is pressed, the connection will be made to the port number 8888 of localhost (this computer).
Hostname of IP Address of Destination: localhost

If connecting to the server by Virtual Hub Admin Mode, please input the Virtual Hub name.
If connecting by server admin mode, please press Enter without inputting anything.
Specify Virtual Hub Name:
Password: ********

The parameter "/usr/local/vpnserver/vpn_server.config" has been specified. It is not possible to specify this parameter when using the command "ConfigSet". Input "ConfigSet /HELP" to see the list of what parameters can be used.

#

↓ relative path
# /usr/local/vpnserver/vpncmd /server /csv /cmd ConfigSet ./vpn_server.config
Specify the host name or IP address of the computer that the destination VPN Server or VPN Bridge is operating on.
By specifying according to the format 'host name:port number', you can also specify the port number.
(When the port number is unspecified, 443 is used.)
If nothing is input and the Enter key is pressed, the connection will be made to the port number 8888 of localhost (this computer).
Hostname of IP Address of Destination: localhost

If connecting to the server by Virtual Hub Admin Mode, please input the Virtual Hub name.
If connecting by server admin mode, please press Enter without inputting anything.
Specify Virtual Hub Name:
Password: ******************

#

Steps to reproduce

install latest softether server
run /usr/local/vpnserver/vpncmd /server /csv /cmd ConfigSet /usr/local/vpnserver/vpn_server.config
occured error

The reason is that the leading / is considered special in softether language. It is used to speficy an option.

You can use path like //usr/local to escape.

thanks for support 🙏
I can confirm that ConfigSet works by escaping the / 👍


chore: Adding SSM Layer Arn Instructions to Docs

Adds the following to read the docs

Relates

#2434

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: fe9959d6bc99a071625750ce6883d763d402e99d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 677b18a0a53fd7227e59e887d858be1002652e05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 677b18a0a53fd7227e59e887d858be1002652e05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


How to include credentials for GitArtifact?

Hi,
I love the idea of hera-workflows and how easy is to create workflows.
Can somebody please point me on how to use credentials to authenticate when using GitArtifact as input artifact?
For example, in official argo workflow example there are usernameSecret and passwordSecret: https://github.com/argoproj/argo-workflows/blob/master/examples/input-artifact-git.yaml#L24
I was looking at example you shown for InputArtifact:
with Workflow("artifact", service=WorkflowService(host="https://my-argo-server.com", token="my-auth-token")) as w:
    w_t = Task("writer", writer, output_artifacts=[OutputArtifact("test", "/file")])
    c_t = Task(
        "consumer",
        consumer,
        input_artifacts=[InputArtifact("test", "/file", "writer", "test")],

and based on that created my task with GitArtifact:
input_artifact=[GitArtifact("test", "/src", "url_to_git_repo", "master")]

but I do not know how to add credentials in the line above.
I know I could mount secret as a volume and provide .netrc to perform cloning of repository, but that seems like an overkill if I can provide credentials for GitArtifact.
Thanks.

Thank you for the issue submission @bvidovic1! I am going to take a look at it soon