An security alert about this repo has been (accidentally) sent to my github email

I have nothing to do with either the alert or this repo. I'm just reporting the situation.
The email was sent by<EMAIL_ADDRESS>(but seemed to be dispatched by<EMAIL_ADDRESS>on Sat Jul 08 2023 06:21 GMT+0800.
Here is a snapshot about it:

A rough translation:

Hello githubuser88:
xiaoN, a contributor from the open source security community, performed a security check on your open source project moudey/Shell at 2023-07-08 18:06:56 and generated a security report.
The test results show that your project relies on some open source components and has security vulnerabilities and license risks.
Get safety report
In case the button don't function properly, you can copy and access the link: https://s.murphysec.com/r/report.html?p=moudey/Shell

Murphy Security Code detection technology is based on the following principles:

Identify all open source components that your code relies on through software component analysis techniques.

Match whether these components have security vulnerabilities with the vulnerability knowledge base built based on large model technology.

Use large model analysis technology to provide vulnerability repair solutions, and can easily repair vulnerabilities with one click.

Product technical documentation: www.murphysec.com/docs
Copyright © 2022 Murphy Future Technology (Beijing) Co., Ltd.
I don't wish to receive it again

Thank you for this alert. The repository will be reviewed as soon as possible

我也是，今天莫名其妙收到

Landed here by Googling the domain of<EMAIL_ADDRESS>as I received an email from the address yesterday. Didn't open, as it looks like spam or phishing, no idea. Just putting it out there for others' info.

The repository is clean and does not contain any malicious files.  There may be a false positive test result.


How to build without Internet?

I wanna run jadx on my server, however, there is no Internet on the server. So the command ./gradlew dist will be error. How to fix it?

You could more than  likely build on computer, and upload the dependencies it's grabbing to the server

@Dave1991 why does your server not have an internet connection?

Because the server store something sensitive.

@Dave1991 it doesn't have to be publicly accessible


Reconciling wasmtime::Instance and Send

Currently as of today the Instance type in the wasmtime crate is not Send. This means that you cannot send it to other threads once it's created. There's a whole bunch of technical issues as to why this is, but for the sake of this issue I'd like to assume a world where we can instantly design everything the way we want.
In our eventual world, for example, Module is Send and Sync along with most other types in wasmtime. We, in this world, get to decide whether we want Instance to be Send or not. As a quick note we fundamentally cannot make Instance Sync because that would allow concurently invoking the same function and (at least) concurrently modifying globals in a non-atomic fashion. This is what we've historically discussed, where Send is desired to send instances to other threads.
I want to write down some reasoning, though, for why I think this may actually be extremely difficult if not impossible. There's two issues I see with trying to make Instance a send-able type:

One is that all the externals today rely on reference counting. Once you put Rc somewhere it's fundamentally neither Send nor Sync. Types like Global, however, internally contain an Rc. We may be able to fix this by only allowing acquisition of &Global from Instance, however. This is the easier of the constraints to solve.

Perhaps the more fundamental constraint though is how we want to deal with function imports. Today this is done with the Callable trait, and those values are stored within an Instance (transitively through Func and such). The Callable, trait, however, does not require Send, which means that, again, Instance is not send. For the rest of this issue I'll discuss this problem.

One possible solution to the latter point would be to add Send as a requirement to the Callable trait, but this also unfortunately is not a great API decision. That requires everyone, even those who don't need it, to implement the Send trait. That's surprisingly restrictive because there are legitimate cases where you don't want to implement Send or deal with the overhead.
The only real solution I know of is to somehow get generics into the picture. For example we can make Instance<T> conditionally Send based on T, allowing users to enable an instance to be Send if they configure it accordingly, but also accomodating users who don't want to deal with Send and only want to work on one thread.
This "real solution", though, doesn't really make sense to me. What is T in Instance<T>? Naively it's basically "the import object" but how can we express this? Is there a way we can create a trait to represent this?

The tl;dr; of this issue is basically:

I assert that it is a local maximum today (and likely beyond) for Instance to not be Send.
For Instance to be Send, I think it will require a type parameter, like Instance<T> where T is the "import object" with some trait to make it work. I haven't the foggiest though how this trait would be designed that satisfies all our constraints for possible optimizations and such.

As a result, I'd like to propose that we commit to, for now, the Instance type not being Send, and then getting as much mileage out of that as we can.

I would very much like Instance to be Send. I don't necessarily see myself shipping an Instance explicitly between threads, but rather working with interfaces that expect things to be Send (e.g. a multi-threaded async runtime).
On the Rc front, it seems like that can be pretty trivially solved by just switching to Arc, right?
It seems like it'd be possible through some kind of marker trait design to parameterize over Send-ness. Particularly if it's an opaque, sealed trait it should allow the implementation to remain flexible - the associated types and methods on the trait can vary as the implementation wants.

Yes it should be simple enough to switch Rc values to Arc (there's quite a few to go through but it's not the end of the world). The more fundamental problem is what to do about the Func type. I don't think we can acceptable say "Func must be Send" because that excludes the usage of Rc entirely, but similarly if we say Func can never be Send then neither can Instance.
I'm not sure I understand though what you mean by a marker trait, which presumably is targeted at this problem, can you elaborate what you're thinkign?

Sure - roughly something like this:
pub trait Style: Sealed {
    // some public API associated types
    type Func;

    // but mostly hidden implementation-defined glue code
}

pub enum LocalStyle {}

impl Style for LocalStyle {
    type Func = NonSendFunc;

    // ...
}

pub enum SendStyle {}

impl Style for SendStyle {
    type Func = SendFunc;

    // ...
}

pub struct Instance<S>
where
    S: Style,
{
    // ....
}

So the idea is that the Style parameter contains all of the types/functionality that would change depending on if the instance's environment is Send or not. Since it's a sealed trait you can maintain flexibility on the implementation side by adding and removing "private" APIs within the trait without worrying about breaking downstream impls since those can't exist.

Ah thanks, makes sense. I feel though that it would be pretty difficult to compose crates if that were used. If only one crate at a time used wasmtime (which may be the case?) then it would be ok but otherwise as a producer of a *Func, for example, I've got to pick one and I may wish to also be somewhat generic and/or abstract.
That being said it's definitely a more concrete suggestion than my own, so it's likely a good starting point!

I think you should be able to define some kind of inheritance (or at least conversion) to go from a SendFunc to a NonSendFunc, but yeah, the details of the API would need to be worked out for sure.

I'm running into problems right now in a few downstream crates that I'm writing on top of wasmtime where I am having to jump through all kinds of hoops and create some pretty gnarly looking code because the wasmtime Instance isn't send. I can't even hide the instance under an Arc<RwLock<...>> because of its internal use of Rc<RefCell>>s.

How does https://github.com/bytecodealliance/wasmtime/pull/1363 affect this?

It seems the most up-to-date explanation of the problem here may be at https://github.com/bytecodealliance/wasmtime/issues/777#issuecomment-625942214
I still really hope it's possible to make Instance be Send. This issue causes me to need to decide whether to use Wasmer instead (speaking of which, how do they do it? Is it actually safe? What's different? I actually thought the way wasmer Modules need a Store made using threads harder until I tried it with wasmtime and discovered this issue.) Or just wrap it in a newtype and unsafe impl Send for it... But then I'll have no idea if it's actually working right until something breaks.

At this point Instance is pretty unlikely to ever be Send. It is, however, safe to move everything connected to a Store to a different thread all at once. It's just not safe to use a Store simultaneously across threads. We haven't documented this, however, it's just a feature of the implementation that will likely always be true. I don't know how wasmer internals work, but for Wasmtime it is not memory safe to add unsafe impl Send for Instance.

So basically there's no way to enforce in the type system that you move everything connected to the Store all at once?

Correct, yeah, we haven't implemented a way of doing that yet. (I'm not sure if it exists for us)

Thanks. Turns out Wasmer just has an unsafe impl Send for InstanceHandle {} https://github.com/wasmerio/wasmer/blob/a2e744aba6c4898841f8a67f4d56a24f204ee439/lib/vm/src/instance.rs#L769-L772
And a comment saying /// TODO: this needs extra review. Not to call anyone out, but I'd rather use a library that has thoroughly considered all safety implications and decided that it's not sound to add this impl, rather than one that just assumes it's fine... I can just wrap it in a newtype and impl Send on that myself, and at least I'll have a better understanding of why it's unsafe and what invariants I need to uphold to make it sound.

It isn't safe. There is a Clone impl that shares the memory. This means that you can use send a clone to another thread and then call table_set from multiple threads at the same time. There doesn't seem to be any synchronization, so this is a race-condition and thus UB.

Can we run the wasi example on the async pattern now ? It looks like we just have async Func and Store, but we do not have async Linker. If we can, is there any tutorial to run wasi example on async mode?

@Knight-X currently wasi-common doesn't have async bindings, but that is planned for the future. Using a Linker you can insert Func values created from async host functions too.


Powered by Enketo requirement feedback

I added something to the license section: https://github.com/enketo/enketo-core#license after a giant corporation adopted Enketo in a new product, and I seem to have failed to convince them to help the project in any way, despite asking for very little (just to show the brand outside of an acknowledgement document that nobody will every see).
Any feedback? Bad, good? By email or below are both great.

Is it supposed to be 12 pixels or 12 points? Pixels are really small, but maybe that's intentional.

Thanks! Should be points.


Startify not starting up Neovim?

On nvim 0.4.3 (macOS Catalina), I just added this line to my neovim config https://gist.github.com/naknode/f8f9aab6b758d05df900afe340713219 Plug 'mhinz/vim-startify' and I still do not see this on startup.
I added the same line to my even more simpler vim config and alas, no startup. On either. What am I doing wrong? Is this not a startup screen?
And yes :Startify does indeed work.

On nvim 0.4.3 (macOS Catalina), I just added this line to my neovim config https://gist.github.com/naknode/f8f9aab6b758d05df900afe340713219 Plug 'mhinz/vim-startify' and I still do not see this on startup.
I added the same line to my even more simpler vim config and alas, no startup. On either. What am I doing wrong? Is this not a startup screen?
And yes :Startify does indeed work.

I have the same question.

https://github.com/mhinz/vim-startify/issues/420#issuecomment-624073856
I solved the problem by setting this in my .zshrc:
alias vim="nvim +:Startify"

In my case, I could solve if by adding autocmd VimEnter * Startify to my .vimrc.

Is this still an issue? This really shouldn't happen at all.

@mhinz no issue with NeoVim 0.5.1, I think you can close the issue 👍


x/pkgsite: javascript links to wrong lines  (cs.opensource.google)

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
Chrome/Ubuntu
go env Output
$ go env

What did you do?
When I go to
https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1792 I click on "QueryRowContext"
What did you expect to see?
I expect to be taken to the defintion of that method
What did you see instead?
I am taken instead to
https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1814
Which is an unrelated call inside an unrelated method
It was pointed out that the definition for db.QueryRowContext on master is at https://cs.opensource.google/go/go/+/master:src/database/sql/sql.go;l=1814
It appears that the problem is that the javascript is confusing the branches that it is on, it is linking to

I've submitted this feedback to cs.opensource.google. Feel free to leave this open for visibility, but this is out of scope for pkgsite.

Thanks, I wasn't sure where to raise it

I tested this this morning and things are still a little confused
That is I go to https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1792
Click on "QueryRowContext"
and am now taken to
https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;drc=47f806ce81aac555946144f112b9f8733e2ed871;l=1812
Which has the correct definition for the method, but the version of the code is different ( a look at the page shows that it should instead be linked to https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1777 )

This is a limitation in https://cs.opensource.google/. The cross-reference metadata is generated at one commit. In this case, it is currently 47f806ce81aac555946144f112b9f8733e2ed871. This updates about once per day.
When browsing at a different commit [1], the UI still does its best to match references despite source skew. However, to try to link to the right location, it always links to code at the cross-reference commit (this the drc parameter you see in the URL; it is unfortunately rather misleading to include the tag name and drc in the URL).
When browsing the Go 1.17 code, this limitation is certainly rather annoying since the code skew can be quite high. I think https://cs.opensource.google/ would like to be able to address this and support multiple cross-reference sources, but I don't know if / when that will ever come.
P.S. in your original issue comment, I'm not sure why you ended up with a cross-reference link missing the drc component. The behavior you see today of being taken to a different version is the intended behavior.
[1] This is quite likely, at least by a few commits, since the cross-references are only updated once per day.

@prattmic Thanks!
Is there a better way to discuss/resolve this issue - there's no apparent way to directly send feedback to the team looking after the site, nor to get feedback from them on when a fix is rolled out (etc)
WRT the feedback on the actual issue, I had suspected that the problem might lie in the building of the map for the javascript to know where to link to because of things like tags/commits changing things often (an update every time a PR was merged to the branch would be expensive, I wonder how Git{lab,hub} manage it).

No, unfortunately I don't think they have much public presence. There should be a "Send feedback" button in the ... menu in the upper right corner of the pages, but that is obviously a one-way mechanism.

I wonder how Git{lab,hub} manage it

FWIW, my experience with GitHub cross-references (not sure about Gitlab) is they seem to be mostly text-search-based which looks like strings that might be the identifier, but is not fully precise. https://cs.opensource.google/ is using Kythe indexing, which actually builds the code to provide completely precise references (for the configuration built; we build linux/amd64 e.g.). The text approach does have the advantage that I imagine it is a bit simpler/cheaper to provide across multiple revisions.


db column type choices: text, mediumtext, number

Added the ablilty to specify the db column type (based on how richtext fieldtype does it. Choices are the two text options (large and huge), and number.
Sorry about sublime mucking with the whitespace.

That's awesome, thanks Marion!

You are very welcome! It is an amazingly useful plugin.


Improved "Pipe operator" lesson

Improved "Pipe operator" lesson example according to suggestion in #305 task.

Awesome @brain-geek, thanks for your help 👍


Enrol Cloudflare plugin in a Wordpress site on a subdomain using API Token fails.

Hello,
I think this may be somewhat related to #255. I've also written about this issue here. When I try to enrol a wordpress site which sits at a subdomain, using an API Token, ie: wp1.test.com, it fails. Global API key works but is not my preference as the wordpress site admins may not be the same as the Cloudflare admins. API Token is strongly preferred.
Drilling down the logs, I observed the API call is made like this:
https://api.cloudflare.com/client/v4/zones/?name=wp1.test.com
If I replicate this in Postman I get this error:
"message": "Actor 'com.cloudflare.api.token.xxxxxxx' requires permission 'com.cloudflare.api.account.zone.read' to list zones"
If I change the name filter to the actual zone name, it succeeds.
Searching the code base I identified that the login routine is handled in the file AbstractPluginActions.php, and the API call is made on line 95. The function getOriginalDomain() used returns the site URL hostname but this is not the Cloudflare zone name, its just a DNS record. If I replace the function call and hard code the zone name (ie: test.com instead of wp1.test.com), it succeeds and the plugin is able to load and then manage things as expected.
Perhaps an advanced feature could be to allow the zone name to be specified manually? We will not always be able to position the Wordpress site at the apex record.
Thanks. Please let me know if I could provide any more information.
-Josh

To add, I had opened case 2002281 with Cloudflare Support, I updated them with this information as well.

Currently our plugin expects to operate at the apex given that all setting changes will affect the entire zone not just the subdomain wordpress runs on, so some issues can occur when using subdomains. I think we likely need to do a bit better job supporting subdomains before we change this otherwise we give folks the wrong conclusion.

Understood. The primary factor the customer is interested in at the moment is cache purge, as there are other apps in the domain which may not play well with enabling all of the performance features available. It would be nice to have more specific failure messaging depending on what's going on.

please follow https://support.cloudflare.com/hc/en-us/articles/360049822312#h_01EQVCQBMEVE37SXPD26ZD168A.

@sejoker why was this closed when it doesn't seem like the issues was actually addressed/fixed.

@timnolte You will need to activate the wordpress plugin on the zone as it is named in Cloudflare. We don't support running the plugin for a non-zone subdomain as its not possible to control zone settings for a subdomain of a zone unless it is a standalone subdomain zone.
If you are looking to use APO then you can enable APO for only the relevant subdomain.

@timnolte You will need to activate the wordpress plugin on the zone as it is named in Cloudflare. We don't support running the plugin for a non-zone subdomain as its not possible to control zone settings for a subdomain of a zone unless it is a standalone subdomain zone.
If you are looking to use APO then you can enable APO for only the relevant subdomain.

@garrettgalow I'm not quite clear on this as the situation is that the main domain and the subdomain are were configured with their own zones. I'll take a look at that article but when you say a "standalone subdomain" are you referring to a subdomain zone where the primary domain doesn't have it's own zone?

@timnolte You will need to activate the wordpress plugin on the zone as it is named in Cloudflare. We don't support running the plugin for a non-zone subdomain as its not possible to control zone settings for a subdomain of a zone unless it is a standalone subdomain zone.
If you are looking to use APO then you can enable APO for only the relevant subdomain.

@garrettgalow I'm not quite clear on this as the situation is that the main domain and the subdomain are were configured with their own zones. I'll take a look at that article but when you say a "standalone subdomain" are you referring to a subdomain zone where the primary domain doesn't have it's own zone?

@garrettgalow I just read through that subdomain article and we are trying to do exactly what that article describes with ensuring that the root domain and the subdomain each have their own full setup. The WordPress plugin doesn't seem to support this setup.


all capital letters names are not detected

Describe the bug
When the name is all capital letters, PERSON entity is not detected
To Reproduce
print(analyzer.analyze(entities = ["PERSON"],text='SOPHY SANTINO', language ="en"))
print(analyzer.analyze(entities = ["PERSON"],text='Sophy Santino', language ="en"))
print(analyzer.analyze(entities = ["PERSON"],text='sophy santino', language ="en"))

Expected behavior
PERSON entity should be detected in all 3 prints

Hi, this could be an issue with the default spaCy model, which has lower accuracy for all capital names. I would suggest to try a few approaches with the Presidio demo, and consider using a different model (e.g. from huggingface or flair)


Much stricter thresholds

Some points from the meeting earlier, for discussion

Currently no specific gnomad AC count on Hemizygote MOI test
Gnomad Homs - > 1 should be enough to dismiss any variant? > 2?
Add gnomad exomes and genomes counts when counting the number of homs/hemi in population data?

I'm not super enthusiastic about this, if we're soon (?) moving to a 700k genome Gnomad v4

AC within joint call should be much lower than 10%. Suggesting a shifting threshold so that we remain sensitive to segregation of causative variants within large families no matter the cohort size:

AC < 100, 5% cut-off?
100 < AC < 1000, 1% cut-off?
AC > 1000, 0.5%?
Should these be specific numbers, or percentages?

Thanks @MattWellie. I can comment relating to VCGS clinical process in a rare disease context:

Currently no specific gnomad AC count on Hemizygote MOI test

We'd typically disregard >=1 hemi as long as there are multiple hets ('multiple' is vague and up for discussion...>2?).

Add gnomad exomes and genomes counts when counting the number of homs/hemi in population data?

Also not enthused by this.

Gnomad Homs - > 1 should be enough to dismiss any variant? > 2?

We'd typically disregard any variant with >=1 het and >=1 hom. >=2 homs is conservative, I wouldn't go higher than that.

AC within joint call should be much lower than 10%. Suggesting a shifting threshold so that we remain sensitive to segregation of causative variants within large families no matter the cohort size:

We use:

AC >= 500, 1%;  OR
variant count needs to be >=5 (so 2% at AC = 250, 5% at AC = 100, etc) where our AC < 500

I like that AC/AN threshold. I'm going to switch it up so that we'll remove variants with AC > 1%, but no filter applied to AC<=5


Generic Result Method Failure

Generic Result method fails when explicitly two assertions are in the same test function.
enum Result<T, E> {
    Ok: T,
    Err: E,
}

impl<T, E> Result<T, E> {
    pub fn unwrap_or(self, default: T) -> T {
        match self {
            Result::Ok(inner_value) => inner_value,
            Result::Err(_) => default,
        }
    }
}

// REVERTS
pub fn test_unwrap_or<T>(val: T, default: T)
where
    T: Eq
{
    assert(Result::Ok::<T, T>(val).unwrap_or(default) == val);
    assert(Result::Err::<T, T>(val).unwrap_or(default) == default);
}

// PASSES
pub fn test_unwrap_or_ok<T>(val: T, default: T)
where
    T: Eq
{
    assert(Result::Ok::<T, T>(val).unwrap_or(default) == val);
}

// PASSES
pub fn test_unwrap_or_err<T>(val: T, default: T)
where
    T: Eq
{
    assert(Result::Err::<T, T>(val).unwrap_or(default) == default);
}

Reproduce
https://github.com/jtriley-eth/test-proj
Version Information
Forc version: 0.32.2
Cargo Version: 1.68.0-nightly (cc0a32087 2022-12-14)
Cargo Generate version: 0.17.4
Mac OS Montery (M1) Version 12.6

I was facing a similar issue yesterday and I think there is an issue with the implementation of eq that is chosen for T. In my case, when I tried logging the left and right sides of the ==, they were indeed equal, but the equality check itself fails which tells me that the implementation of eq that is "discovered" for T is wrong. This points to an issue in trait constraints.

This issue no longer occurs with the changes from PR #3621. The PR improves consistency between inserting and getting stored trait implementations this allows to retrieve trait implementation when it was not possible before because the call paths wouldn't match.
Added this repro to PR #3621.


Refactors/macos example

Changes in this pull request
Issue fixed: #381
Checklist

[X] All tests pass. Demo project builds and runs.
[ ] I added tests, an experiment, or detailed why my change isn't tested.
[X] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[X] I have reviewed the contributing guide

Awesome! I think this looks good. I haven't messed w/ NSCollectionView before, so assuming its working :p

My first time to @rnystrom but it's showing the items and animated diff animation as known from the iOS example so I think that's what it should demo :)


Update copyright to 2022

@javadev001001, @hj325488 has offered an alternative solution:

Is the correct format for the copyright strings: "Copyright - Crown Copyright"?

 If so, I've written a small helper script that creates this information from the Git history.
 If this ticket isn't being worked on by anyone else at the moment, I could pick it up and
finish it off.

(Team discussion: ) This item can be done automatically with suitable hooks in updates. Come back to this after v2.0

@GCHQDeveloper314 Does the merging of #2588 mean that this issue can be closed?

Yes the merging of that means this issue can now be closed. There's no need for it or similar issues in future as copyright dates are now checked automatically as part of the CI. Through this, if a change in a PR causes a date to be incorrect, this will be flagged and will need to be corrected before the PR can be merged - preventing dates from getting wrong again.

Satisfied by #2588


Multiple assets emit different content to the same filename error for assets with persistent cache

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
No
Description
This issue is a continuation for the https://github.com/angular/angular-cli/issues/12186. The fix, introduced for that issue, does not correctly work when using webpack 5 persistent cache.
The problem comes from the fact that when you have multiple assets with the same name, but different folder, CLI emits the first visited asset to the root of fs(disregarding it's folder path), while emiting subsequent assets with this name to their corresponding folders.
To do that Angular CLI keeps track of the emitted(visited) files in-memory, and it does not work when part of the compilation was restored from file system cache. This makes it so that CLI does not realise that a certain svg file was previously emited to the root of the fs, which in turn may lead to the emition of a different svg file(with the same name, but different content) to the same place in the root of the fs, triggering webpack emit conflict error.
🔬 Minimal Reproduction

Enable webpack 5 persistent cache feature
Make sure the cache is clear
Create a project with 2 different SVG assets with the same name, but place them in two different folders
Import one of this images somewhere in the code of the project
Run ng build. The svg is emitted to the root of fs, and is cached
Change the code to import second image right before the first one
Run ng build again. CLI will try to emit the second svg to the root of fs, but there is already the first svg retrieved from the cache there.
You should see the webpack emit conflict error.

🔥 Exception or Error
Error: Conflict: Multiple assets emit different content to the same filename empty.svg
🌍 Your Environment

Angular CLI: 12.2.0
Node: 14.17.3
Package Manager: npm 6.14.13
OS: darwin x64

Angular: 12.2.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.0
@angular-devkit/build-angular   12.2.0
@angular-devkit/core            12.2.0
@angular-devkit/schematics      12.2.0
@schematics/angular             12.2.0
rxjs                            6.6.7
typescript                      4.2.4
webpack                         5.47.1

Hi @pshurygin, I tried to replicate this locally, but I am not managing to replicate the issue.
Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@alan-agius4 Are you using actually different images for that? If so, I guess one might also need to have import of the second asset from a different(lazy loaded) chunk, as this is how we have it in our repo. I will try to make a minimal reproduction repo for that.

Yes, the 2 images are different.

@alan-agius4 Yes, you need your second asset to be in a different bundle. I've also didn't mention that you have to run build in development mode, otherwise file names are hashed. Here is the reproduction repo

Comment out contents of child.component.scss
run NG_PERSISTENT_BUILD_CACHE=1 ng build --configuration development
Uncomment contents of  child.component.scss
run NG_PERSISTENT_BUILD_CACHE=1 ng build --configuration development again

Hi @alan-agius4,
I would like to provide a data point that this issue still persists.
This thread helped me to solve a similar issue which was caused by two independent third-party dependencies adding equally named static assets to the build (fonts).
Luckily, one of the dependencies could be replaced but if that was not the case, we would have been forced to disable angular caching for local development.


Rotate ability for SecDebugLog

We use cronolog for rotating all of our apache logs.  Currently, for SecAuditLog, this works in mod_security 3.0:
SecAuditLogType Serial
SecAuditLog "|/usr/local/sbin/cronolog --symlink=/usr/local/apache/logs/modsec_audit.log /usr/local/apache/logs/modsec_audit_%m%d%y.log"
however, piping the DebugLog fails:
SecDebugLog "|/usr/local/sbin/cronolog --symlink=/usr/local/apache/logs/modsecurity.log /usr/local/apache/logs/modsecurity_%m%d%y.log"
Syntax error on line 175 of /usr/local/apache/modsecurity.d/modsecurity.conf:
ModSecurity: Failed to open debug log file: /usr/local/apache/|/usr/local/sbin/cronolog --symlink=/usr/local/apache/logs/modsecurity.log /usr/local/apache/logs/modsecurity_%m%d%y.log
Can the SecDebugLog directive be fixed to allow the same pipe handling as the Audit Log?

Hi @macapone,
In ModSecurity version 3, you can have a custom DebugLog back-end. The DebugLogs are meant to write the rules, not really to be used in production. That is why we never had the pipe functionality implemented for it. Enable the debuglogs in production may reduce significantly the performance.
If you are intend to build an UI for rules customization, I would suggest the implementation of a custom DebugLog engine while calling the libModSecurity API.


np.int deprecated in 1.20

https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

@microsoft-github-policy-service agree [company="Kid Dangerous"]
@microsoft-github-policy-service agree [company="Kid Dangerous"]
@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree


Focus outline cut off in this case

Testing #116559

Same here:

I can repro.
There is nothing special that the action bar is doing here. But this was working in stable so I did break this. Thus assigning to this milestone.
@sandy081 and @sbatten was there something special that you were doing here to make this work previously? If you have time can you also take a look?

Maybe an artefact from the fact that this view is not to the top.

It seems this is happening only with some themes like Light, Light+, Dark, Dark+. These themes have top border for views headers instead of bgcolor. This border is pushing the outline.

Oh yeah, I can also reproduce with Stable.
Let's also assign to @misolori and you @sandy081 and move out of endgame. You can assign it back if you prefer

One alternative is to change the box-sizing property to content-box which means that border will be placed on the outside making the header 1px taller. This will cause a slight shift in views where certain themes that don't use a border but only noticeable when switching themes.

Trying out the second option since it's the less-obtrusive solution, we can re-visit if it doesn't work.


feat(*): use alpine:3.2 for image base

This reuses some of the proposed changes in deis/deis#4641. Advantages:

allows Deis to control the registry version explicitly
allows building registry from a different code repo or fork, which may be necessary if S3 compatibility changes are still outstanding
makes the config.yml file explicit so it's easier to modify
is fully compatible with registry:2 and can be configured by environment variables similarly
is much smaller

$ docker images | grep registry
<IP_ADDRESS>:5000/deis/registry      git-f4c2e91  7e200fa98286   8 minutes ago  32.86 MB
registry                               2            dfb4481bd21b   3 weeks ago    223.5 MB

big +1


Rule request: strict-number-check

TypeScript code being linted
const value: number | null = 0;
// value is 0 and js sees 0 == false
if (value) {
	// ...
}

(Lint only if there is no other expression in the if)
Expected behavior
If value can also be number, then warn and suggest:
const value: number | null = 0;
if (value || value === 0) {
	// ...
}

@Shinigami92 does the strict-boolean-expressions satisfy your use case here? Seems pretty similar.

@JoshuaKGoldberg I think yes


hotkey to view tagtabs

i se most of these issues and suggestions are left opened and unresolved, but figured i'd give it a shot regardless. Viewing tagtaps is incredibly useful, especially for fixed client users and limited UI realestate in the bank interface. it'd be nice to have a hotkey set, or the ability, say got example just hitting tab when you enter the bank to open it up.

for those who don't know, you can put view tag tabs as left click on the plus icon by putting "view tag tabs, *" in custom menu swaps plugin.

wouldn't hurt to have a hotkey update. view tag tabs, new tag tab, import tag tab, remove single item (remove-layout, remove-duplicate-item, or remove-tag, depending on what it is), duplicate item, etc.
Not super high priority for me personally though. If someone else wants to do it, that would be cool though.
Also, "View tag tabs" is not from bank tag layouts, it is from bank tags. I'm not 100% sure if bank tag layouts can create a hotkey for it.


[Question] Do I need to have gym installed in addition to gymnasium in order to run the lunar lander example?

❓ Question
I am running Ubuntu 22.04.5 LTS, and have used pip to install the following packages:

gymnasium
gymnasium[box2d]
stable-baselines3[extra]
rl_zoo3

When I run the following
python3 enjoy.py --algo ppo --env CartPole-v1
it works as expected. However, when I run
python3 enjoy.py --algo ppo --env LunarLander-v2
I get the following:
Loading latest experiment, id=1
Loading rl-trained-agents/ppo/LunarLander-v2_1/LunarLander-v2.zip
Traceback (most recent call last):
File "/home/jimr/.local/lib/python3.10/site-packages/rl_zoo3/enjoy.py", line 276, in
enjoy()
File "/home/jimr/.local/lib/python3.10/site-packages/rl_zoo3/enjoy.py", line 192, in enjoy
model = ALGOS[algo].load(model_path, custom_objects=custom_objects, device=args.device, **kwargs)
File "/home/jimr/.local/lib/python3.10/site-packages/stable_baselines3/common/base_class.py", line 680, in load
data, params, pytorch_variables = load_from_zip_file(
File "/home/jimr/.local/lib/python3.10/site-packages/stable_baselines3/common/save_util.py", line 434, in load_from_zip_file
data = json_to_data(json_data, custom_objects=custom_objects)
File "/home/jimr/.local/lib/python3.10/site-packages/stable_baselines3/common/save_util.py", line 165, in json_to_data
deserialized_object = cloudpickle.loads(base64_object)
ModuleNotFoundError: No module named 'gym'
Do I need to install gym in addition to gymnasium? I am concerned that installing both will lead to incompatibilities.
Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the SB3 documentation
[X] I have read the RL Zoo documentation
[X] If code there is, it is minimal and working
[X] If code there is, it is formatted using the markdown code blocks for both code and stack traces.

Hello,
For running some pretrained agents, you might need gym indeed (0.21), but it should not be needed for using the rest of RL zoo.
However, if you retrain a lunar lander model, only Gymnasium is enough.


How to train from scratch

Can you provide the training instructions? (or I have missed sth. ?)

Do you train successfully?

@FishWoWater @cyjouc Do you train now? Could share, pls.

Hi everyone, could you share your training code plz? I have no idea how to train. @fashionguy @cyjouc @FishWoWater

is the plan to open source the training code? WHEN?

is it required to train? is not it pre-trained?


Value of margin for body seems opinionated

We are currently defining a margin of 0 for the body element. As stated in the test file, apparently this is an opinionated value.
Is this something we want to keep anyway or is it OK if I do some research about this particular property?

Yes, we really should take a look.
I’ll want to coordinate any changes we make to this with the bootstrap team, since they are not overwriting normalize.css here.
@patrickhlauke, many people have been contributing tests and screenshots to narrow down exactly which versions of browsers are affected by normalize.css. In that process, we’ve found that some rules are not normalizations. Those rules, when used vanilla, sometimes hinder the display of things, and body { margin: 0 } may fall under this category.
Would you be comfortable adding this to your reboot? The goal is for normalize.css to fix missing/broken/inconsistent/non-spec styles and generally make things just work™, but not introduce opinionated defaults.

@jonathantneal, great! During the week I'll prepare some test cases to see if any normalization is really needed, so we can do an informad decision about this alongside with de Bootstrap team.

bootstrap does indeed rely on having the { margin: 0 } (for full-bleed elements), so quite happy to add it to your reboot in coordination with its removal from normalize /cc @mdo

I think removing the default margin from body is pretty much essential. Despite the name of the project, it has intentionally never been about pure normalization. And bootstrap isn't the only consumer of the project.

I'll not argue that a margin of 0 in the body element is not a good default; and a change on this property will certainly have a huge impact on most projects/websites that rely on that.
Lately "pure normalization" was the direction taken; but we can —and guessing by your comment, should— try to identify in which cases is okay to be "opinionated" in favor of a widely used default and in which not.
I don't have a strong opinion on this matter, but I do think that if the "pure normalization" path were taken, usually we would need —unless using BEM or some other methodology— an extra set of rules to act as baseline —here I'm talking about Bootstrap's Reboot, Sanitize.css, etc.

I think removing the default margin from body is pretty much essential.

I'm inclined to agree.

Closed by #529.

Was it decided to remove the margin? I don't see an agreement here though.

yeah please add it back.

@jq-87, @adamgruber may be creating a soft reset we will link to in the project README.md.
I would be very open to creating a list of soft resets that leverage normalize.css with short descriptions of how they work. I was hesitant to create such a list if only sanitize.css was going to be on it (it seemed too self-referential). I know people have similarly asked for / pleaded for / demanded a similar soft reset for forms.


[release-v0.26] Golang 1.17 container image

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>related to https://github.com/openshift-knative/serverless-operator/pull/1302
Let's see how this really goes...

/hold

/unhold


Tree shanking for re-exported entry

🚀 Feature Proposal

As the following description. In watch mode, Container A related test suits will not run while Button Change:

As a developer, I only want to rerun related tests.
Now:

jest collectModules logic not expose to user.
jest dependencyExtractor use regex match.

Hope:

dependencyExtractor extract dependencies with import export info.
collectModules let use decided which file need to run.

Motivation

My project use index.tsx re-exported a lot of components.
In jest watch mode, many relationship test suites run when I change only one basic component.
If could tree shaking the re-exported entry, would reduce many times.
Example

According to above picture, When Button changed, Container A related test will not running.
Only Tab component changed, Container A will run.
Pitch
Why does this feature belong in the Jest core platform?
Common feature proposals that do not typically make it to core:

New matchers (see jest-extended)
Changes to the default reporter (use custom reporters instead)
Changes to node/jsdom test environments (use custom environments instead)

https://github.com/facebook/jest/issues/11234 talks about similar thing (entry/barrel) but more about performance in that issue.


Allow for negative inputs?

By default allow for negative number inputs. At the moment SAT_RANGE_ERROR is raised for negative numbers unless validateBitcoinMaxSupply = false.
I think the error should not be raised for validateBitcoinMaxSupply  = true and that the error should be raised if the abs(satoshis) > MAX_SATOSHIS

Merged and released for v1.1


🐛 Modulemap not found (2.0.3, Xcode 15)

Describe the bug
Hello! I faced with this Xcode error:
/Users/user/Tests/RugbyTest/Pods/Target Support Files/Pods-RugbyTest/Pods-RugbyTest-dummy.m module map file '/Users/user/Library/Developer/Xcode/DerivedData/RugbyTest-engmykdkznjnrcbmcwflmqvdswxq/Build/Products/Debug-iphonesimulator/Alamofire/Alamofire.modulemap' not found

To Reproduce
Steps to reproduce the behavior:

Create a new Xcode iOS project from scratch;
Create a new Podfile with following content:

source 'https://cdn.cocoapods.org'

platform :ios, '15.0'

use_modular_headers!
inhibit_all_warnings!

target 'RugbyTest' do
  pod 'Alamofire'
end

Run pod install and rugby;
Try to build the project.

Expected behavior
Project should build without errors.
Environment:
$ rugby
⚑ Cache
  ⚑ Build
    ✓ CLT: Xcode 15.0
    ✓ Reading Project
    ✓ Finding Build Targets
    ✓ Backuping
    ⚑ Checking Binaries Storage
      ✓ Calculating Storage Info
      ✓ Used: 0,47 GB (0%)
    ✓ Checking Binaries Storage
    ✓ Hashing Targets
    ✓ Finding Binaries
    ✓ Creating Build Target
    ✓ Saving Project
    ✓ [3.7s] Debug: sim-arm64 (1)
    ✓ Saving binaries (1)
  ✓ [3.8s] Build
  ⚑ Use
    ✓ Reading Project
    ✓ Finding Build Targets
    ✓ Hashing Targets
    ✓ Backuping
    ✓ Patching Product Files
    ✓ Deleting Targets (1)
    ✓ Saving Project
  ✓ Use
✓ [3.8s] Cache
✓ ⚑ Let's Roll-oll 🏈

$ rugby env
Rugby version: 2.0.3
Swift: 5.9
CLT: Xcode 15.0 (Build version 15A240d)
CPU: Apple M1 Pro (arm64)
Project: RugbyTest
Git branch: Unknown

$ pod --version
1.13.0

Additional context
I found Alamofire.modulemap in Pods/Target Support Files/Alamofire/Alamofire.modulemap and if modify Pods-RugbyTest.debug.xcconfig from:
OTHER_CFLAGS = $(inherited) -fmodule-map-file=$(inherited) -D COCOAPODS -Xcc -fmodule-map-file="${PODS_CONFIGURATION_BUILD_DIR}/Alamofire/Alamofire.modulemap"
OTHER_SWIFT_FLAGS = $(inherited) -D COCOAPODS -Xcc -fmodule-map-file="${PODS_CONFIGURATION_BUILD_DIR}/Alamofire/Alamofire.modulemap"

to

OTHER_CFLAGS = $(inherited) -fmodule-map-file="${PODS_ROOT}/Target Support Files/Alamofire/Alamofire.modulemap"
OTHER_SWIFT_FLAGS = $(inherited) -D COCOAPODS -Xcc -fmodule-map-file="${PODS_ROOT}/Target Support Files/Alamofire/Alamofire.modulemap"

The project builds without errors, but if I try to use some object from Alamofire I got error:
import UIKit
import Alamofire

class ViewController: UIViewController {
    func test() {
        _ = AF // Error: Cannot find 'AF' in scope
    }
}

If I click with pressed Command key to import Alamofire I see next:
import UIKit

public var AlamofireVersionNumber: Double
public let AlamofireVersionString: <<error type>>

Hello @rock88! It's the same as #231.
Right now 🏈 Rugby doesn't support libraries.
So, you should add use_frameworks! to your Podfile.
Or, we need to add support of libraries in #231.
Please, let me know if you have another one issue.

@swiftyfinch oh, thank you for explain!
I made few manual fixes and seems like all works fine, I'll just write what I did step by step, maybe I can make a PR with fixes:

Only libAlamofire.a is not enough for static libraries, needs full set of modulemap/headers/etc:
Xcode produced this files:

Rugby produced only libAlamofire.a:

So I copied all files (except libAlamofire.a) to ${HOME}/.rugby/bin/Alamofire/.../5a9ab27:

Fix Alamofire.modulemap in rugby binary folder ("${HOME}/.rugby/bin/Alamofire/.../5a9ab27"):
Origin:

module Alamofire {
  umbrella header "Alamofire-umbrella.h"

  export *
  module * { export * }
}

module Alamofire.Swift {
  header "/Users/user/Library/Developer/Xcode/DerivedData/RugbyTest-engmykdkznjnrcbmcwflmqvdswxq/Build/Products/Debug-iphonesimulator/Alamofire/Swift Compatibility Header/Alamofire-Swift.h"
  requires objc
}

Fixed:
module Alamofire {
  umbrella header "Alamofire-umbrella.h"

  export *
  module * { export * }
}

module Alamofire.Swift {
  header "Swift Compatibility Header/Alamofire-Swift.h"
  requires objc
}

Fix paths in Pods-RugbyTest.debug.xcconfig (diff only):
Origin:

LIBRARY_SEARCH_PATHS = $(inherited) "${PODS_CONFIGURATION_BUILD_DIR}/Alamofire" "${TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}" /usr/lib/swift
OTHER_CFLAGS = $(inherited) -fmodule-map-file="${PODS_CONFIGURATION_BUILD_DIR}/Alamofire/Alamofire.modulemap"
OTHER_SWIFT_FLAGS = $(inherited) -D COCOAPODS -Xcc -fmodule-map-file="${PODS_CONFIGURATION_BUILD_DIR}/Alamofire/Alamofire.modulemap"
SWIFT_INCLUDE_PATHS = $(inherited) "${PODS_CONFIGURATION_BUILD_DIR}/Alamofire"

After rugby and manual fixes:
LIBRARY_SEARCH_PATHS = $(inherited) "${HOME}/.rugby/bin/Alamofire/${CONFIGURATION}${EFFECTIVE_PLATFORM_NAME}-${ARCHS}/5a9ab27" "${TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}" /usr/lib/swift
OTHER_CFLAGS = $(inherited) -fmodule-map-file="${HOME}/.rugby/bin/Alamofire/${CONFIGURATION}${EFFECTIVE_PLATFORM_NAME}-${ARCHS}/5a9ab27/Alamofire.modulemap"
OTHER_SWIFT_FLAGS = $(inherited) -D COCOAPODS -Xcc -fmodule-map-file="${HOME}/.rugby/bin/Alamofire/${CONFIGURATION}${EFFECTIVE_PLATFORM_NAME}-${ARCHS}/5a9ab27/Alamofire.modulemap"
SWIFT_INCLUDE_PATHS = $(inherited) "${HOME}/.rugby/bin/Alamofire/${CONFIGURATION}${EFFECTIVE_PLATFORM_NAME}-${ARCHS}/5a9ab27"

Great news! You are right, I made the similar steps yesterday. And I have almost made a draft. But after that I found an issue with Keyboard+LayoutGuide modulemap naming. And it needs some polishing.
I think there are such ways:

You can open your own pull request if you like to continue solving the issue. You are welcome here!
I can continue working on my draft this evening and maybe I will try to open pull request.

I can't share it right now, because I'm on the different mac.

@rock88 This feature will be available in the next release 🚢
Thank you for your help!

@swiftyfinch 🏈🚀 Many thanks!


Adding words from the crossword lists from Moby Words II

Oops, meant to create this PR on my forked repo to better see the difference, disregard.


[backport] Fix DropoutStates interface to avoid using cuDNN handle

Backport of #1734

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 24edbfebe40d78b7a126ea1571ec98e2ece10844, target branch v5) succeeded!

LGTM!


update for version 1.3

Now python 3 compatible. The miriad c code from aipy is in pyuvdata (and it no longer requires aipy or pyephem).

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Done in #2


[ENHANCEMENT] Consider renaming the extension to Robot Code

Is your enhancement request related to a problem? Please describe.
When searching for "Robot Framework" in the Marketplace RobotCode has a very low relevance. Since people are more likely to install an extension that appears in the top 5 results, RobotCode will continue to be relatively unknown.
It is worth noting that only one of the top 5 results is actively maintained, which means that abandonware gets more attention than RobotCode.
It is also well known that the Marketplace search is broken.
Describe the solution you'd like
According to the issue linked above:

One way to improve your extension rank is to break word node_modules into separate words node modules. This will increase the string matching score and push your extension up in the result.

Therefore, I recommend changing the name to Robot Code. This should increase its relevance score in the Marketplace.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

It worked! Now it is the first extension after all the extensions whose name begins with Robot Framework. This should give it more visibility :)


Feature/bitbucket default catalog value

Hey, I just made a Pull Request!
This PR adds a default value of "catalog-info.yaml" to BitbucketDiscoveryProcessor that's used when no catalog path is given.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Hey @goober, can you chime in here? I'm not 100% what this is doing and i'm don't have the most context here.

Sure thing @benjdlambert, just want to clarify that @ONordander is a colleague of mine.
Some context for other reviewers. The documentation states that you should define a pattern for matching repositories while crawling the Bitbucket instance. e.g. by defining the path https://bitbucket.mycompany.com/projects//repos//
However, if you leave out the filepath part, it will be empty when the parser is called. By defaulting to catalog-info.yaml in the case when the filepath is left out we are a little bit more forgiving on how the adopter configure the discovery-reader

OK sweet - make sense to me!

@goober @ONordander just to clarify though this change isn't breaking right? It should be patch in this case whilst we are <1.0.0

@goober @ONordander just to clarify though this change isn't breaking right? It should be patch in this case whilst we are <1.0.0

Correct me if I'm wrong but I think it is breaking, since we are changing default functionality.
If a user has has written a custom parser that overrides https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/src/ingestion/processors/bitbucket/BitbucketRepositoryParser.ts
the input to the parser will change.
If they have built logic around getting empty catalogPaths as input it could affect them (the 'target' input here https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/src/ingestion/processors/bitbucket/BitbucketRepositoryParser.ts).

@ONordander in that case - do we need to add more to the changeset suggesting how to migrate to the later version if that's possible?

@ONordander in that case - do we need to add more to the changeset suggesting how to migrate to the later version if that's possible?

That sounds like a good idea, I'll get on it!

Perfect - I wonder if it also (not in this PR, perhaps a follow up PR) it would be good to move some of the bitbucket parts into their own module instead similar to the LDAP module. Means it can be versioned seperately from the catalog-backend plugin :)


I can't find the add publisher button.

I want to setup multiple plublisher accounts.
I logged in as instructed, and maybe i am being stupid, but as written i don't see an add publisher button or an account settings button.  Could you add more detailed documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00448cbd-79ca-5067-9d01-7f99578864f7
Version Independent ID: 07d739db-c455-fc2e-53c4-9109f4e966e8
Content: Create a commercial marketplace account in Partner Center
Content Source: articles/marketplace/partner-center-portal/create-account.md
Service: marketplace
Sub-service: partnercenter-marketplace-publisher
GitHub Login: @parthpandyaMSFT
Microsoft Alias: parthp

Ok i finally found the flow, here is roughly how your docs should read as there is nothing to select call account settings.

sign into the partner portal
from the cog on the menu bar select developer settings
choose publisher settling
click add publisher

note you will need to create your publisher buisness location before it can be added here
to create a location do the following.

select the cog icon from the top menu
choose partner settings.
select locations
4 click add location

@scyto Thank you for bringing this to our notice and glad to hear that you were able to sort out the issue. We appreciate you taking time to share the flow for broader community here.
Will take your feedback and work with respective document author to see how we can enhance the documentation to reflect this flow. Will take it as a backlog item and update this thread accordingly when we have an update.

@scyto Thanks again for bringing this to our notice, we will share the feedback to our document authoring team and have it as a backlog item to enhance the document accordingly.  Will reference this thread once we have the work item. We will go ahead and close this issue for now, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


接入AppsFlyer导致微信登录失败

接入AppsFlyer导致微信登录失败

Hi @DriverFrameWork ,
Thank you for reaching out to us.
To provide optimal support, we would kindly ask you to submit a support ticket to<EMAIL_ADDRESS>When submitting the ticket, please specify your AppsFlyer sign-up (account) email, app ID, reproduction steps, code snippets, logs, the links you used, and any additional relevant information.


Postgresql Custom image

Hello
I want to use custom postgresql image. For instance "supabase/postgres"
For it I rebuild image and prepared postgres user id (26) by dockerfile like your image "registry.developers.crunchydata.com/crunchydata/crunchy-postgres:centos8-13.4-1".
Also after start image I get the error: "Error: container has runAsNonRoot and image has non-numeric user (postgres), cannot verify user is non-root"
What I need to do for starting?

My Dockerfile
From supabase/postgres:13.3.0
ARG UNAME=postgres
ARG UID=26
ARG GID=26
RUN groupmod -g 3000 $(getent group | grep $GID |cut -d':' -f1 )
RUN groupmod -g $GID $UNAME
RUN usermod -u $UID -g $GID $UNAME
USER $UNAME

This repo is specifically for working with the examples around PGO. For support issues, please see the support section in the documentation.


Misleading paragraph to be reviewed

[Enter feedback here]
The paragraph needs to be corrected "Additional settings are available for B2B collaboration with non-Azure AD identities (for example, social identities or non-IT managed external accounts)." As it implies these additional settings are only available for non-azure ad identities which is incorrect.
Instead you can use "Additional settings are available for B2B collaboration such as ...."
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6138502-6a71-9671-fd88-312884ffb14c
Version Independent ID: 1f3137c1-8ab1-e493-4dbe-49562aebe5dc
Content: Cross-tenant access overview - Azure AD - Microsoft Entra
Content Source: articles/active-directory/external-identities/cross-tenant-access-overview.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@larasawalha90
Thanks for your feedback! We will investigate and update as appropriate.

Thanks! I made a pull request to update the paragraph. https://github.com/MicrosoftDocs/azure-docs-pr/pull/206975


(PUP-10923) Change all acceptance back to audit/risk:high

This PR changes all acceptance tests back to risk:high/audit:high so all tests are run in CI. While testing this, we discovered some failing tests:

tests/aix/aix_package_provider.rb - the URL to download packages was no longer valid, replaced it with a correct one
tests/resource/service/launchd_provider.rb - the service status assertions were too strict, changed the assertions to use the helper methods
systemd tests that were relying on puppet resource service - see https://tickets.puppetlabs.com/browse/PUP-10949

Jenkins please test this on all

Jenkins please test this on all

Jenkins please test this on all

Jenkins please test this on all

Jenkins please test this on all


Display warning when user opens superhero from a browser which we don't support

I think we should not update package-lock.json, without changing package.json, or if having any issues with packages. Else, please revert if it is unrelated change.

Accidentally closed.
Ref. https://github.com/aeternity/superhero-ui/pull/313


Feature/sql contract definition

What this PR changes/adds
Adds an implementation for ContractDefinitionStore, ContractDefinitionLoader via SQL based on a ContractDefinitionSchema.
Why it does that
To allow for SQL persistence of Contract Definitions.
Further notes
none
Linked Issue(s)
Closes #460 #461
Brendan Cronin<EMAIL_ADDRESS>Daimler TSS GmbH, legal info/Impressum

Codecov Report

Merging #816 (499cc01) into main (e12c13a) will decrease coverage by 0.03%.
The diff coverage is 57.51%.

@@             Coverage Diff              @@
##               main     #816      +/-   ##
============================================
- Coverage     59.68%   59.64%   -0.04%
- Complexity     2189     2238      +49
============================================
  Files           594      606      +12
  Lines         12830    13165     +335
  Branches        899      905       +6
============================================
+ Hits           7657     7852     +195
- Misses         4752     4886     +134
- Partials        421      427       +6

Impacted Files
Coverage Δ

...connector/transfer/core/CoreTransferExtension.java
0.00% <ø> (ø)

.../api/multipart/controller/MultipartController.java
62.06% <ø> (ø)

...alog/cache/query/IdsMultipartNodeQueryAdapter.java
26.66% <0.00%> (ø)

...e/api/validation/RemoteTokenValidationService.java
0.00% <0.00%> (ø)

...r/dataplane/spi/pipeline/OutputStreamDataSink.java
60.00% <0.00%> (ø)

...definition/schema/SqlContractDefinitionTables.java
0.00% <0.00%> (ø)

...nnector/token/TokenGenerationServiceExtension.java
0.00% <ø> (ø)

.../contract/offer/store/ContractDefinitionStore.java
0.00% <0.00%> (ø)

...tdefinition/schema/FlywayDataSourceConnection.java
17.14% <17.14%> (ø)

...ql/contractdefinition/schema/FlywayDataSource.java
28.57% <28.57%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c4411...499cc01. Read the comment docs.

eclipsefdn/eca failed due to our corporate email change. Should be solved now.

@jimmarino @paullatzelsperger Does #542 impact the requirements of this PR in any way?

@bcronin90 eventually the functionality will change, but don't worry about that now. #814 isn't yet ready for development, and it might not make it into Milestone 3.

There are a few things that can be improved (see code), other than that it looks promising. Also, please use var wherever possible. The only real concerns I have is regarding flyway, and they are two-fold:
1. The flyway-extension shouldn't be inside the `contract-definition` directory. Seems like that feature is independent of the `ContractDefinition`, it rather cuts across all SQL data stores.

2. Using Flyway **must** be optional. Some people may want to use alternatives like Liquibase. Renaming the `schema` module to `extensions/sql/migration/flyway` would make this possible and more visible at the same time.

I'm adapting all the smaller changes right now. On flyway though:

We've kept the flyway migrations in each separate sql extension to allow for separate migrations for each schema.
The (extension currently called) schema is a dependency for the other sql extensions (in this case loader and store). So if we want to generalize this we probably have to define an SPI for it, that is then implemented via flyway, right?

eclipsefdn/eca failed due to our corporate email change. Should be solved now.

It still looks like it is failing

@bcronin90

The (extension currently called) schema is a dependency for the other sql extensions (in this case loader and store). So if we want to generalize this we probably have to define an SPI for it, that is then implemented via flyway, right?

If that's the case you have a design problem: the other sql extensions should never depend on a specifc tool like flyway particularly because a schema and a migration tool are orthogonal concerns and should not be in the same extension. All code pertaining to a schema (table name constants, etc.) could be put into an -spi.

side note: we now have checks in place that require a certain PR title format. in this case renaming to e.g. Feature: SQL contract definition should suffice.

In preparation for getting this mergeable: could you please mark every conversation as "resolved" if the respective issue has been addressed?
Once that's done, please rebase on main, resolve any conflicts and let reviewers know that they can re-review.

Also, can you please provide the schema.sql file in such away that people can easily consume and use it when they set up their database?

Also, can you please provide the schema.sql file in such away that people can easily consume and use it when they set up their database?

Certainly! Currently the idea is to provide a readme for database setup. Alternatively we could use a migration tool to provide the initial setup, as was the case earlier. I'm open to both approaches.

Also, can you please provide the schema.sql file in such away that people can easily consume and use it when they set up their database?

Certainly! Currently the idea is to provide a readme for database setup. Alternatively we could use a migration tool to provide the initial setup, as was the case earlier. I'm open to both approaches.

just put the schema.sql file somewhere, maybe in extensions/sql/contract-definitions/resources, which people can use easily to configure their database. Migration tools are great but some discussion needs to happen before we decide on adding any particular one to the code base.

@paullatzelsperger Ready for re-review.
Please ignore the lack of readme and schema.sql for now. Will add tomorrow.

minor things, but once they are in, I think we're OK to merge

Should be fixed now


chore(develop): release hermes 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-09-21)
Features

cors: enable cors policy for anubis, enki and quetzalcoatl (6652dbc)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

hermes/v1.0.0
:sunflower:


Fix faulty SBOM param name change

What does this PR do?
Fix parameter that was probably hit by search&replace from https://github.com/DataDog/datadog-agent/pull/25886
Motivation
Bugfix
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Run Agent with SBOM scanning. It should not emit errors.

/merge


flatten certain fields

Set and define specific questions that I want to move into a unique custom field on the related case?  What I like to call “flattening it out”  for lihwap Brian had added some apex and 2 fields on the question, source and target, where we would put in the api name of the field where the answer is stored for that specific question, then the api name of the custom field on the case to write it too.  What are your thoughts on something like this on the LWC package?  Or is this just have to be an add-on after the install for if/when needed.  At this point for Delaware I don’t think we need it, this may change but as of now, no.

Hell yea!


Remove metadata xls/x support altogether

Is your feature request related to a problem? Please describe.
Pros:

remove entropy
one less dependency
Cons:
honestly none that is likely to outweight the pros

Describe the solution you'd like
Just remove it

@alecristia if you agree I'll just proceed.


Data and resourse for History page (documentation)

Describe the Issue
Data and resources on the History page like:

history of the periodic table
about Mendeleev(father of the periodic table)
Mendeleev periodic table
how many periodic tables are made

hey harsh,
i think i can do this

I can do both. But I can't be sure if data and resources would be as good as you want

ya, that's why just wait for today we will create the mock-up design where you can add any type of data.  And when we have real data then we just replace dummy data with real data.

And I will let you know that I have created the issue for UI.

I am interested in working on making the documentation. Please assign this issue to me @HarshKumarraghav

It is not creating the UI it's just providing the data for the history page.

Okay

okay, @Apurv428 I'm assigning this issue to you. You can connect with me on LinkedIn so that we can discuss how It will be done.

Hey I want to contribute to this issue

Hey I want to contribute to this issue

ok, I'm assigning this issue to you.

@janmesh799 I have created the issue for coding the UI for the history page If you are still interested in it.

Hey I want to contribute to this issue

h1 @Sonal-Maurya If you want to contribute to the documentation I can assign it to you.

Hey, I want to contribute for the documentation of history page.

Ok, I am assigning this task to you @TechGeek3

This is how the documentation should be right?

Ya but some images would be favourable.

Ya sure I'll add them.

Where should I add the images used in documentation? public folder?


Elaine/trace call

https://github.com/ethereumproject/emerald-wallet/issues/87

Okay, I believe the problem was that geth has a different trace output than parity. I think the output should be standardized by the connector instead of the wallet, but this should work for now.

Yeap, geth has different traceCall
we will make proper handling for different clients in next milestone
thanks, @elaineo


Setuptools CVE-2022-40897

Prerequisites

[X] I am using the latest version of Locust
[X] I am reporting a bug, not asking a question

Description
Version 2.29.0 of locust still reports the usage of<EMAIL_ADDRESS>which contains the vulnerability CVE-2022-40897. This has been fixed in version 65.5.1.
Command line
n/a
Locustfile contents
n/a

Python version
n/a
Locust version
2.29.0
Operating system
Linux

Hi! What does this issue actually mean for a tool like locust?

I don't know, tbh - I just know it's being flagged with the CVE listed as there is an available fix since Nov, 2022.

Ok. A quick look seems to indicate this is not relevant for us, and we dont limit the maximum version so most people will end up using latest version anyway.
Maybe we could/should bump the minimum version but it isnt top prio and there’s an open PR doing lots of things with the build system so I’m not touching it now.


Image::GetBufferAsFloat() to modify pixel values in a c# array

Hi,
I've been trying to avoid creating an issue because I was sure it was a bug in my code, but after doing lots of test now I'm not sure what's the problem.
I'm using GetBufferAsFloat() to read an image and write another using a float array. I've tried both ways using an unsafe code and float*, and doing a marshall copy to a float[] as proposed in the documentation. I can read the image properly, but when I write into the array, the new image values are not being stored in the Image object. Is the pointer obtained with GetBufferAsFloat()  points directly to the memory in the Image object or I need to do an additional copy? I tried using the ImportImageFilter also without good results.
This is my code, with the two options:
public Image DivideImageReplacNaN(Image num, Image den)
        {
            // output image:
            Image output = new Image(num.GetSize(), PixelIDValueEnum.sitkFloat32);
            // Get ptr:
            IntPtr ptrItkNum = num.GetBufferAsFloat();
            IntPtr ptrItkDen = den.GetBufferAsFloat();
            IntPtr ptrItkOut = output.GetBufferAsFloat();
            VectorUInt32 size = num.GetSize();

            /*unsafe
            {
                float* bufferPtrNum = (float*)ptrItkNum.ToPointer();
                float* bufferPtrDen = (float*)ptrItkDen.ToPointer();
                float* bufferPtrOut = (float*)ptrItkOut.ToPointer();
                for (int i = 0; i < size[0]; i++)
                {
                    for (int j = 0; j < size[1]; j++)
                    {
                        for (int k = 0; k < size[2]; k++)
                        {
                            if (bufferPtrDen[i + j * size[1] + k * size[2] * size[1]] != 0)
                                bufferPtrOut[i + j * size[1] + k * size[2] * size[1]] =
                                    bufferPtrNum[i + j * size[1] + k * size[2] * size[1]] /
                                    bufferPtrDen[i + j * size[1] + k * size[2] * size[1]];
                            else
                                bufferPtrOut[i + j * size[1] + k * size[2] * size[1]] = 0;
                        }
                    }
                }
            }
           //output = SimpleITK.ImportAsFloat(bufferPtrOut, output.GetSize(), output.GetSpacing(),
              output.GetOrigin());
           */
            // calculate the number of pixels
            int len = Convert.ToInt32(size[0] * size[1] * size[2]);
            float[] numAsArray = new float[len]; // Allocates new memory the size of input
            float[] denAsArray = new float[len]; // Allocates new memory the size of input
            float[] outAsArray = new float[len]; // Allocates new memory the size of input
            Marshal.Copy(ptrItkNum, numAsArray, 0, len);
            Marshal.Copy(ptrItkDen, denAsArray, 0, len);
            Marshal.Copy(ptrItkOut, outAsArray, 0, len);
            for (int i = 0; i < size[0]; i++)
            {
                for (int j = 0; j < size[1]; j++)
                {
                    for (int k = 0; k < size[2]; k++)
                    {
                        if (denAsArray[i + j * size[1] + k * size[2] * size[1]] != 0)
                            outAsArray[i + j * size[1] + k * size[2] * size[1]] =
                                numAsArray[i + j * size[1] + k * size[2] * size[1]] /
                                denAsArray[i + j * size[1] + k * size[2] * size[1]];
                        else
                            outAsArray[i + j * size[1] + k * size[2] * size[1]] = 0;
                    }
                }
            }

            Marshal.Copy(outAsArray, 0,ptrItkOut, len);
            return output;
        }

So, I wonder if there is a bug or what's the correct way to write an Image using an array.
Thanks,
Martin

What you are doing looks correct to me.
I suggest simplifying your problem or code to narrow down the problem. Please create a function which takes no input, creates a new image, allocates a buffer, fills the buffer with a constant or something then, Marshal.Copy the buffer into the ITK image.

 It was a problem with the linear index, it should have been:
bufferPtrNum[i + j * size[0] + k * size[1] * size[0]]
I'll close this.
Thanks.

Yes, your order of the loop is different from the example:
https://github.com/SimpleITK/SimpleITK/blob/master/Examples/CSharp/ImageGetBuffer.cs#L62-L67
For efficiency, the inner most loop is generally the fast axis of the image. This provides access to the buffer's pixels in the order they are stored in memory, as opposed to jumping between slices as you are doing.


vue2 not recognizing change when pushing a previously set array to query

Version
2.6.14
Reproduction link
codesandbox.io
Steps to reproduce
Imagine using this function to push the changes to query when user play with the website filters:
async pushQuery(inputs) {
      const query = Object.assign({}, this.$route.query);

      // if we are in page 5 for example when adding new filter we need to reset back to the first page!
      if (query.page) {
        delete query.page;
      }
      // In case we are doing the same filter need to toggle!
      for (const input of inputs) {
        if (query[input.key] === input.value) {
          delete query[input.key];
          if (!query[input.key]) return;
          return await this.$router.push({ query });
        }
       // formating the array form of query
        if (Array.isArray(input.value)) {
          input.key = input.key + "[]";
        }
       // making the query
        query[input.key] = input.value;
        if (input.value === "" || !input.value) {
          delete query[input.key];
        }
      }
     // finally we will push the new query
      await this.$router.push({ query });
    },

now everything is going to work fine the first time using this code, the problem will occur when the user has already changed some filters, let's say we have a dropdown filter called "country" and it's already set to "Canada" and "France", this is the result:
https://website.com/find-tutors?country[]=Canada&country[]=France
If user try reloading the page then add or remove some countries, vue will fail to add changes to the path.
In order to make vue realize these changes I found 2 solutions:
We can add a new query like :
      query.changed = Math.floor(new Date().getTime() / 1000);

right before we call router.push .
Shuffling the country array (using underscore library e.g.) can also give us the results we are looking for.
What is expected?
https://website.com/find-tutors?country[]=Canada&country[]=France&country[]=Iraq&country[]=Ukraine
What is actually happening?
https://website.com/find-tutors?country[]=Canada&country[]=France

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


Link in autocomplete popup does nothing

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
On deprecated variables there's a link to a source file, clicking it does nothing. Can it be hidden?

I couldn't find yet whether this is a configurable option in monaco-editor or not, so I've asked on their repo https://github.com/microsoft/monaco-editor/issues/3455 if this is even possible


appdata links to wrong url

https://github.com/TenderOwl/Norka/blob/55e8812923cedce19c60956971196690c8203fe4/data/com.github.tenderowl.norka.appdata.xml.in#L28
Kindly fix

https://fedoramagazine.org/fedora-linux-flatpak-cool-apps-to-try-for-april/
Discussion in the comments section on here is whether or not that is a scam site. Perhaps just unfinished?


chore: better fitting of the plt title and summary.

@fchollet this PR does the following:

Changes the summary of the example. The earlier one was broken.
Adds a line of code to fit the image captions as plot titles better.

Since the changes are minor, I decided to add all files in the PR directly. Let me know in case of anything.

@fchollet addressed your comments. See if the changes are good to go.


Update http4s-blaze-client, ... to 0.21.6

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server
org.http4s:http4s-core
org.http4s:http4s-dsl

from 0.21.3 to 0.21.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

#587


allow for multiple interfaces connected to the same network

/kind enhancement
Once this: https://github.com/kubevirt/kubevirt/pull/1342 is delivered, it should be possible to expose a network from the host into the VM.
As noted there, the underlying device plugin, as well as the API defined with kubevirt, allows for multiple interfaces on the pod, to be connected to the same network. Hence, it should be possible to connect multiple interfaces from the VM into the ones on the pod (currently only one of the is selected, and exposed to the VM).
Would suggest the following addition to the VMI yaml:
networks:
  - name: red
    resource:
      resourceName: bridge.network.kubevirt.io/red
      resourceCount: 3

One of the usecases for that, would be running a virtual router inside kubevirt. The router needs multiple interfaces on the machine it is running on, and will manage vlans on them.
On the other end, its will be connected to a trunk interface on the host.

I am not sure if adding resourceCount: 3 there. You would then have to reference the same networks entry three times from different interfaces. I think the correct way for this would be:
networks:
  - name: red1
    resource:
      resourceName: bridge.network.kubevirt.io/red
  - name: red2
    resource:
      resourceName: bridge.network.kubevirt.io/red
  - name: red3
    resource:
      resourceName: bridge.network.kubevirt.io/red

this would also require defining 3 interfaces. this extra verbosity does not provide extra functionality in this case. why do you think this is needed?

this would also require defining 3 interfaces. this extra verbosity does not provide extra functionality in this case. why do you think this is needed?

You need to define three interfaces anyway. So you would save two "networks" definitions for this corner-case (not interface definition) and sacrifice the very predictable way on how networks and interfaces are connected. I am sure there are also corner-cases in k8s where someone would want to mount the same volume to multiple directories inside the same container. Still the person will have to add the same volume then multiple times with a different name and.

OK, makes sense. I guess this should just work with the device plugin as it works today - these will just be multiple allocation request for the same network.
Please keep the issue open, since this will have to be at least verified.

The L2 device plugin work (https://github.com/kubevirt/kubevirt/pull/1342) was cancelled. hence closing this issue.


Added support for python venv display in paradox prompt

Just a simple tweak to the paradox prompt to show the name of the python virtualenv being worked on at the end of the prompt.

Thanks for the contribution! Nice to get some of these small tweaks in.

It would be nice if this was not obligatory. As is I'm seeing the following error in my console:
prompt_paradox_preexec:2: command not found: python-info
I am not a python dev and would rather not have to worry about figuring out why my rather stock macos Sierra installation is missing said command.

Sorry about that @wojtekgalaj. I've pushed a fix here: https://github.com/sorin-ionescu/prezto/commit/b963484fe7a929db309946d777988c39f082ebf6


fd_write not respecting offset from fd_seek

The fd_write implementation doesn't seem to respect an offset previously set by fseek, instead it always writes to the end.
Reproduction
#include <stdio.h>

const char *source = "/absolute/path/to/fseek_test";

int main(void) {
    long offset = 4;

    FILE *f = fopen(source, "w");
    if(!f){
        perror("fopen");
    }
    if(fprintf(f, "%s", "123456789123456789") == 0){
        perror("fprintf");
    }

    if(fseek(f, 4, SEEK_SET) != 0){
        perror("fseek");
    }
    if(fprintf(f, "%s", "abc") == 0){
        perror("fprintf");
    }
    if(fseek(f, 0, SEEK_END) != 0){
        perror("fseek");
    }
    if(fprintf(f, "%s", "end") == 0){
        perror("fprintf");
    }

    if(fclose(f) != 0){
        perror("fclose");
    }
    return 0;
}

(with https://github.com/CraneStation/wasi-sdk/releases/tag/wasi-sdk-8)
# compile
clang --target=wasm32-unknown-wasi --sysroot ..../wasi-libc/sysroot test.c

# run, produces `123456789123456789abcend`
wasmer-js run a.out --dir=/

# run, produces `1234abc89123456789end` (correct, same as with "real" libc)
wasmtime --dir=/ a.out

@mischnic Thank you soooo much for such a detailed issue with a repro case!
cc @syrusakbary as they have been doing a lot of the Wasi polyfill work here.
If they don't get the chance to get to it, I'll try to when I get the chance! 😄

Hi @mischnic both issues should now be fixed on master.

We just published a new version of wasmer-js 0.5.1 that should have this issue fixed.


Develop new GUI for the acquisition workflow

[x] Green and red status feedback for each stream
[x] Button to send LSL messages to EEG
[x] Visualizers to check critical streams (ECG, sound capture, and GPS)

This has been fixed in PR #77


Signature ProofOptions not included

Since I'm running a couple of tests with the MIW and it's VCs, I ran into the following:
I fetch a VC from MIW.
I create a VP with this VC (with MIW)
I verify the VP (and its VCs) with the MIW and it is valid.
I change the VC proof.created
I create a VP with this changed VC (with MIW)
I verify the VP (and its VCs) with the MIW and it is valid.
I think the last step should NOT be a valid result!
It looks to me like for creating the signature, only the 'unsecuredDocument' is taken, but not the 'proofOptions'.
Can you please double check this desired behavior? To my understanding it should be the hash from the 'proofOptions' +  the hash from the 'unsecuredDocument' that are concatenated and then used as the data that is signed.
Can we add a test case that verifies the produced VC/VPs with a 3rd party library? Just to make sure compatibility is ok.
--
Matthias Binzer

I've added a test case for ProofOptions manipulation that fails without any additional changes - because it should fail.
I can change the 'created' or 'proofPuspose' without the signature check ('verify') failing.
The specs for JsonLd Proofs (now Data Integrity Proofs) have changed quite heavily in recent times, but I think a good example can be found here:
https://www.w3.org/TR/vc-di-eddsa/#test-vectors
and the more formal description here:
https://www.w3.org/TR/vc-di-eddsa/#hashing-ed25519signature2020

@borisrizov-zf, please assign this to me.


Looking for good example of point and path forecast beyond current known time series data points

in other words, estimating X and call forecast modules for point and path forecasting.

Estimating X is still problematic and may have multiple approaches.


[MM-37054] Subscription test script for system console

Summary
Test script for Subscription functionalities
Ticket
https://mattermost.atlassian.net/browse/MM-37054

Release Note
NONE

Hello @vinod-demansol,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

Hey @vinod-demansol, thanks for the PR!
2 things:

Can we get you to sign the CLA as per the message above?
There are some lint errors that need to be resolved, can you look into those?

Thanks again!

@stevemudie this PR includes initial tests to the Subscribe are in the System Console for which we will need the Zephyr test cases numbers

I'll wait for @stevemudie to confirm test cases/criteria.

@vinod-demansol Let me know once ready for review.

for yellow color marked test cases , we do not have zypher id yet , request @stevemudie help to get the ID's for it

Thanks @vinod-demansol for updating! For some reason, I'm out until tomorrow (earliest), and will likely review this by Wednesday.

for yellow color marked test cases , we do not have zypher id yet , request @stevemudie help to get the ID's for it

@vinod-demansol Sorry for not getting back sooner but you can find all of the related Zephyr links you need in the ticket for this now.

@stevemudie thanks for providing Zephyr tests!
@vinod-demansol Thanks for updating! Could we arrange the tests as follows?

Combine MM-T4118, MM-T4119, MM-T4126 and MM-T4121 into one it block with title "MM-T4118 Subscription page UI check"
Combine MM-T4123, MM-T4124, MM-T1449 and MM-T4127 into one it block with title "MM-T4123 Purchase modal UI check"
Combine MM-T4128 and MM-T4129 into one it block with title "MM-T4128 Enable/disable "Subscribe" button in Purchase modal"

@stevemudie , @devinbinnie and @marianunez, Please review my PR (8361) and let me know if you need any changes in my script.

@vinod-demansol Based on what I'm seeing it's heading in the right direction. Based upon what @saturninoabril wrote here we should be left with the following test case numbers mapped to the PR:

MM-T4118 Subscription page UI check
MM-T4123 Purchase modal UI check
MM-T4128 Enable/disable "Subscribe" button in Purchase modal

That said it looks like you combined them into the following test case numbers. Is that about right?

MM-T4118 Subscription page UI check
MM-T4122 "Subscribe now" navigation and closing of Subscribe window
MM-T4124 Purchase modal UI check
MM-T4128 Enable/disable "Subscribe" button in Purchase modal

I just need to know so that I can combine them over on Zephyr Scale to match.

Oh, sorry Steve and thanks for checking! I missed to mention that I've already combined the tests into the last 4 that you've mentioned.

Merging now. Thanks @vinod-demansol!


Add Pupper logo

Hi! What is your PR about?

[x] Add images for your space
[ ] Add custom domain for your space
[ ] Add alias for migrate your space
[x] Add or edit a skin
~Edit your space with GitHub?~ (deprecated) Please migrate your space to ENS https://docs.snapshot.page/spaces/migrate
~Create your space with GitHub~ (deprecated) Create your space with ENS instead https://docs.snapshot.page/spaces/create

Whoops! Just changed everything to reflect Pupperdao.eth and PupperDao name. Thanks!

Should be fixed!


Param as type "array" in swagger_api

I am trying to send a param with type array, but the params that I am getting in the controller is always of type string.
Swagger_api definition:
swagger_api :invite do
          summary 'Invite employees to organization'
          param :form, 'organization[emails]', :array, :optional, 'Employee emails (should be array)'
          param :header, 'auth-token', :string, :required, 'Authentication token'
          response :unauthorized
          response :not_acceptable, 'The request you made is not acceptable'
end

Generated swagger doc:

Params that I am getting in the controller:
=> <ActionController::Parameters<EMAIL_ADDRESS><EMAIL_ADDRESS>"controller"=>"api/v1/organizations", "action"=>"invite"} permitted: false>

Is array even supported? Or do I need to change something here?

@toshitapandey did you end up solving this?

@vamsipavanmahesh - no, I ended up changing my API format and had the frontend send it in the way that swagger sends it.

we ended up changing from array to comma-separated string. Found this pattern in many sites, including JIRA @toshitapandey


Warning in SocialNav (Instantiating render asset ... with incompatible light setup, instance will not be correctly lit.)

Thank you for the updated README for SocialNav!
Thanks to the updated README, I can successfully run training a SocialNav agent, but I see many warnings like below.
[Warning]:[Assets] ResourceManager.cpp(945)::createRenderAssetInstance : Instantiating render asset 'data/robots/hab_spot_arm/urdf/../meshesColored/arm0.link_el0.glb' with incompatible light setup, instance will not be correctly lit.
Have you observed this warning before? Would it affect reproducing the result?

Hi @qwerty863! Yes, we have observed this before, and this should be okay. It would not affect the results.

Hi @jimmytyyang! Thank you for confirming this!


Fast Attention TF: Unit test unstable?

When executing test_softmax_noncausal_attention_block_output in performer/fast_attention/tensorflow/fast_attention_test.py
it produces a maximum error of 0.20 which is clearly below the max allowed error max_error = 2.0.
However, when changing length to a different value. The maximum relative error jumps up significantly.
The commit I'm running on is: 6f29c8099fbb1474769046276c8744521470cab9
I run on TF 1.15.
Here is a table of length vs error and unit test state:

length
relative error
unit test status

2
0.20
Pass

4
1.24
Pass

8
106
FAIL

10
9.7
FAIL

Ping @xingyousong

Also confirmed with TF version 2.4.0

How many random features do you use ? Also, we recently updated our TF implementation (see: https://github.com/google-research/google-research/commit/b09ac837cd5720bc60f1c16b472a7ab462b0ddb8) (previously there was a bug in the code).  Did you run the most updated version ?

Also, I think what you observe (for some values of L) is simply much larger relative error. The way we compute it in unit tests is: |our_value - exact_value|/exact_value per entry of a matrix (abd then take max over all entries). So if exact value is very small, even with very good estimator (with variance going to 0 as approximated values go to 0) you might have large relative error and still very small absolute error which is really what matters at the end. We will update the unit tests to measure absolute error since it is more meaningful and and informative than the relative error.

Hi @kchoro,
the commit b09ac83 is a predecessor of 6f29c80, so I should have those changes included.
Here is the configuration, which is the same as the standard, except varying in length
batch_size = 1
length = VAR
num_heads = 1
dim = 8
num_random_features = 30000

Your argument makes definetely sense. I updated the table with the max absolute and mean absolute errors.
While the mean error seems to
I used the following code to generate the errors (mostly the unit test code):
def test_softmax_noncausal_attention_block_output(self):
    batch_size = 1
    length = 50 # <-- this varibale is changed for the table
    num_heads = 1
    dim = 8
    num_random_features = 30000
    query = tf.random.normal([batch_size, length, num_heads, dim])
    key = tf.random.normal([batch_size, length, num_heads, dim])
    value = tf.random.normal([batch_size, length, num_heads, dim])
    kernel_transformation = fast_attention.softmax_kernel_transformation
    projection_matrix = fast_attention.create_projection_matrix(
        num_random_features, dim)
    attention_block_output = fast_attention.favor_attention(
        query, key, value, kernel_transformation, False, projection_matrix)

    query = tf.multiply(query, 1.0 / math.sqrt(float(dim)))
    attention_scores = tf.einsum("BXHD,BYHD->BXYH", query, key)
    attention_scores = tf.nn.softmax(attention_scores, axis=2)
    exact_attention_block_output = tf.einsum("BXYH,BYHD->BXHD",
                                             attention_scores, value)
    error = tf.math.abs(exact_attention_block_output - attention_block_output)
    print("Max: {}".format(tf.math.reduce_max(error)))
    print("Mean: {}".format(tf.math.reduce_mean(error)))

length
max abs_error
mean abs_error

2
0.081
0.023

4
0.19
0.047

10
0.20
0.064

50
0.67
0.045

500
0.67
0.022

This is a scatter plot showing abs_error error over exact_attention_block_output. The error sometimes seems to be quite big

Hi @mschoeler, thank you for an update. What I see is that the mean absolute error is pretty small which is great. My guess is that the small fraction of larger values of absolute error (most of the values are concentrated around 0) correspond also to larger values that are being approximated. Also take into account that the computational block includes renormalization so it is not purely an approximation of the linear transformation of the attention matrix.

Thanks for your quick reply.
The error could also be heavily influenced by the dimensionality of the values. Since the weighted sum becomes more similar, if values are sampled from a lower dimensional space I assume.
Wouldn't it make sense to add a unit test for the kernel approximation of the softmax directly?

Hi @mschoeler, very good point. Yes, we will definitely add this test to the open-sourced version. We have it in our internal codebase and as you noticed, indeed the error is even smaller if we focus only on the attention matrix. Of course the test can be implemented in particular by taking the value matrix to be an identity.

I guess to mimic this, the value matrix would need to be identity and d_value == length.
So basically a quadratic matrix with main diagonal set to 1

Yes, exactly (see my comment above, I guess we posted our comments at the same time :))

👍

@kchoro I actually tested our proposal in the unit test.
So I created V as an identity matrix in order to be able to see the attention scores in the performer.
Here is the code:
def test_softmax_noncausal_attention_block_output(self):
        batch_size = 1
        length = 32
        num_heads = 1
        dim = 32
        num_random_features = 2000
        tf.random.set_random_seed(5)
        query = tf.random.normal([batch_size, length, num_heads, dim])
        key = tf.random.normal([batch_size, length, num_heads, dim])
        value = tf.eye(dim, batch_shape=[batch_size, num_heads])
        value = tf.transpose(value, perm=[0, 2, 1, 3])
        kernel_transformation = softmax_kernel_transformation
        projection_matrix = create_projection_matrix(
            num_random_features, dim)
        attention_block_output = favor_attention(
            query, key, value, kernel_transformation, False, projection_matrix)

        ## Check that attention weights for performer sum to one
        sum_of_weights = tf.math.reduce_sum(attention_block_output,axis=-1)
        self.assertLess(tf.abs(tf.reduce_max(sum_of_weights) - 1 ), 10e-4 )

        ## Check difference to exact attention
        query = tf.multiply(query, 1.0 / math.sqrt(float(dim)))
        attention_scores = tf.einsum("BXHD,BYHD->BXYH", query, key)
        attention_scores = tf.nn.softmax(attention_scores, axis=2)
        exact_attention_block_output = tf.einsum("BXYH,BYHD->BXHD",
                                                 attention_scores, value)

        ## Visualize attention scores
        from matplotlib import pyplot as plt
        fig, (ax0, ax1, ax2) = plt.subplots(nrows=3, constrained_layout=True)
        im0 = ax0.imshow(attention_scores[0,:,:,0])
        ax0.set_title("attention_scores")

        im1 = ax1.imshow(exact_attention_block_output[0, :, 0, :])
        ax1.set_title("exact_attention_block_output")
        im2 = ax2.imshow(attention_block_output[0, :, 0, :])
        ax2.set_title("attention_block_output")
        fig.colorbar(im0, ax=ax0)
        fig.colorbar(im1, ax=ax1)
        fig.colorbar(im2, ax=ax2)
        plt.show()

While the fast attention scores are normalized for a certain query the visual comparisong of the attention scores between fast_attention and the exact attention show quite some differences.

Top: Exact attention scores; Middle: Exact attention block output; Bottom: FastAttention block output
Any idea, what could cause that discrepancy?