Changed peer dependency in 1.0.9

Hi!
Few hours ago new version of react-konva were published in npm and it requeirs now react 15.4.0 as peer dependency instead of 15.1.0.
It could be assumed as breaking change, so I wanna ask why you did such changes under same minor version of the library?

In fact it was even in patch version which is assumed only for bugfixes.

I am not sure how semantic version works for that case. I wasn't able to google an answer. Please post a link if you can find.
The thing is - public API of react-konva itself didn't change.
So if you update react-konva AND react you will have backwards compatible change.

Real life projects often use ~ to define dependency ranges in projects to minify chance. Minor version upgrades often could bring new bugs with new features.
Upgrading react to 15.4.0 requires special intention and testing.
Returning to peer dependency. It also can be treated as public API since it defines compatibility range. BTW you should define it as wide as possible to avoid issues with other libs that also defines same peer. I don't think that 1.0.9 introduced somth that couldn't work with react less 15.4.0.
So if you really need to shrink peer dep range support please consider do it at least with minor version. But it's better solution to extend this range as much as possible.
Semver maybe not cover exactly this question since it just general common sense rules. But I hope I have argued enough. Still will try find some links later.

Thre is a note about updating dependency on semver FAQ:

What should I do if I update my own dependencies without changing the public API?
That would be considered compatible since it does not affect the public API. Software that explicitly depends on the same dependencies as your package should have their own dependency specifications and the author will notice any conflicts. Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. I would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.

http://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
It's not exactly same situation, but at least it suggests to have minor increment.
I would still suggest to publish patch version increment (1.0.10) with extended range of react. I am pretty sure that there is nothing that avoids using react-konva with<EMAIL_ADDRESS>range,

@Guria I can't extend the range of react versions. You can see change here: https://github.com/lavrton/react-konva/commit/d4837afaaf37ba043d2066e7b3b3c05975a78783#diff-1f10719214e0d5e2a72f54b98f667499

Ouch. Have you read release blogpost?

However, there is a possibility that you imported private APIs from react/lib/*, or that a package you rely on might use them. We would like to remind you that this was never supported, and that your apps should not rely on internal APIs. The React internals will keep changing as we work to make React better.

Anyway it was mistake to release this breaking change in patch version. Semver suggests a fix for such situations:

What do I do if I accidentally release a backwards incompatible change as a minor version?
As soon as you realize that you’ve broken the Semantic Versioning spec, fix the problem and release a new minor version that corrects the problem and restores backwards compatibility. Even under this circumstance, it is unacceptable to modify versioned releases. If it’s appropriate, document the offending version and inform your users of the problem so that they are aware of the offending version.

But in your case it means we need 1.0.10 which will be the same as 1.0.8 with range of react >15.0.0 <15.4.0. And then release 1.1.0 or even 2.0.0 with ~15.4.0 range.
And for future safety you have to find a way not to depend on React internals.

I published 1.0.10 with React >=15.0.0 <15.4.0 range.
And 1.1.0 with React ~15.4.0 range.

And for future safety you have to find a way not to depend on React internals.

Unfortunately, I don't know any possible implementations without using React internals.
Please reopen if I missed something.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1970

Questions ?
Please refer to the Backport tool documentation


field_types[name] generics type cannot be used with isinstance (python 3.7)

What I'm trying to achieve
Pycharm error
python 3.7
Steps to reproduce the problem
saleor/saleor/payment/utils.py
Line 332
`field_types = {
'amount': Decimal,
'currency': str,
'is_success': bool,
'kind': str,
'transaction_id': str,
'error': (type(None), str),
}
for response in responses:
    if not REQUIRED_GATEWAY_KEYS.issubset(response):
        raise GatewayError(
            'Gateway response needs to contain following keys: {}'.format(
                sorted(REQUIRED_GATEWAY_KEYS)))

    for name, value in response.items():
        if name in field_types:
            if not isinstance(value, field_types[name]):
                raise GatewayError('{} must be of type {}, was {}'.format(
                    name, field_types[name], type(value)))

    if response['kind'] not in ALLOWED_GATEWAY_KINDS:
        raise GatewayError(
            'Gateway response kind must be one of {}'.format(
                sorted(ALLOWED_GATEWAY_KINDS)))

    if response['currency'] != settings.DEFAULT_CURRENCY:
        logger.warning('Transaction currency is different than Saleor\'s.')

    try:
        json.dumps(response, cls=DjangoJSONEncoder)
    except (TypeError, ValueError):
        raise GatewayError(
            'Gateway response needs to be json serializable')`

if not isinstance(value, field_types[name]):
error: Parameterized generics cannot be used with instance and class checks
isinstance not accept generics type field_types[name]
What I expected to happen
…
Screenshots

System information
Operating system:
Browser:

@hanyelbanna What are the exact steps to reproduce the error? It is not so clear from the description you've provided. Were you able to resolve it?


Matherial from the “Euro-BioImaging’s  Guide to FAIR BioImage Data"

We should add the public material from this course:
Euro-BioImaging Youtube channel (https://www.youtube.com/c/eurobioimagingcommunication)
Practical Exercise
https://zenodo.org/records/11474407
Most important document (maybe to add even in a separe entry):
data management plan template (https://zenodo.org/records/11473803

Hi @rmassei ,
the first link points to a YouTube channel (which is already in our collection).
Could you provide a link to the specific course video you mean?

ah sorry @haesleinhuepf! here we are:
FAIR BioImage Data
https://www.youtube.com/watch?v=8zd4KTy-oYI&list=PLW-oxncaXRqU4XqduJzwFHvWLF06PvdVm

done in #92


Log training metrics to visualize them via tensorboard

Proposed changes:
Related to https://github.com/RasaHQ/research/issues/56
Add option tensorboard_log_directory to DIETClasifier, ResponseSelector and
TEDPolicy.
By default tensorboard_log_directory is None. If a valid directory is provided,
metrics are written during training. After the model is trained you can take a look
at the training metrics in tensorboard. Execute tensorboard --logdir <path-to-given-directory>.
We also write down a model summary (layers, input size, type) in the provided directory.
Status (please check what you already did):

[ ] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

Just to be sure: How would you log on minibatch level? Would you have a counter that increases over time so that you see all steps in one plot? For example, if the first minibatch has 64 steps, the second minibatch would start with step 65 in the plot.

@tabergma Just tried on the scaffold project dataset - The steps for test logger do not correspond to the steps for the train logger. For example, if evaluate_after_every_epochs is set to 20, then the steps for test logger should be 20,40,60 rather than 1,2,3. Sharing the step size would directly give an indication of which epoch does the validation loss correspond to. Otherwise the user has to calculate that on their own. Attaching a screenshot -

If this is easy enough to change, I would suggest we change it now.

This only happens if you set tensorboard_log_level to minibatch correct? So in that case, training metrics should be plotted after every step, but evaluation metrics just after every epoch?

Yes, setting it to epochs works fine. For your question regarding minibatch -  IMO they should be plotted after every evaluate_after_every_epochs steps. So if evaluate_after_every_epochs is set to 2, and number of minibatches in training set is 20 and number of minibatches in validation set is 2 then steps for test logger would be 40,41,80,81,120,121

Update:
Do you mean something like this?

Yes, there should be some inherent corresponding steps.


feat(spanner): add samples for Proto columns

This PR contains samples and integration tests for insert, read and delete operation of Proto Message, Proto Enum and also NullProtoMessage, NullProtoEnum that supports null values using mutations and DML.
This PR contains samples and integration tests for insert and read operation of Array of Proto columns along with null support.

@rahul2393 Can you please review this PR?

@harshachinta This PR is pretty big. Could we break it down to 500 line chunks? It's hard to review otherwise.

@enocom
To make code review easier, I am splitting the changes into multiple PR's.
I have created a PR-2776 for this. Hence closing this PR.


✨ tag container images with branch name, too

Summary
To make it possible to write documentation that is somewhat stable over time, it would be nice to have something like the latest tag on container images. However latest can be super misleading, especially when there are multiple active release branches at the same time.
This PR therefore does not use latest, but instead simply the branch name (e.g. main) as additional tags on the generated manifests. This would allow for example the kcp helm-charts to just reference kcp-dev/kcp:main.
Release Notes
Container images are now not just tagged with their version, but also the branch name.

/lgtm
/approve


Need Help on Visdom

Hi,
I rerun your implementation on my machine but it seems to not work for me. Can you please suggest how can I solve this

I am going to begin with CelebA dataset
I extracted the dataset to folder  D:...
Beta-VAE-master\data\CelebA\Training
I deleted most of the photos to make the size manageable to see if it can run (left with around 40 phtos)
install visdom, torch, torchvision
initialize visdom   (python -m visdom.server)

Use my browser to access http://localhost:8097/

python main.py --dataset celeba --seed 1 --lr 1e-4 --beta1 0.9 --beta2 0.999   --objective H --model H --batch_size 64 --z_dim 10 --max_iter 1.5e3    --beta 10 --viz_name celeba_H_beta10_z10

Even if there is no error shown, I there is no output shown on either http://localhost:8097/ or in the folder D:...\Beta-VAE-master\outputs\celeba_H_beta10_z10

All I can suggest is trying different combinations of packages and Python versions, perhaps there is a version conflict. Miniconda is your friend here. The screenshots show that you are using Windows, perhaps try it on Linux?


eat: export shallowEqual from react-redux

Checklist

[x] npm test passes
[x] tests are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Description of change

close   #2154
增加 shallowEqual 导出，以便实现 useShallowEqualSelector

Coverage remained the same at 87.282% when pulling 074e7d5403175795e42993931c771e9641920424 on atzcl:master into 8a890348a1308e8756d113dba6fe2243e8a823f8 on dvajs:master.

Coverage remained the same at 87.282% when pulling 074e7d5403175795e42993931c771e9641920424 on atzcl:master into 8a890348a1308e8756d113dba6fe2243e8a823f8 on dvajs:master.


Failed to install on Raspbian

VSCode Version: 1.38
OS Version:
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=Debian
Description:	DebianEdu/Skolelinux
Release:	9.9
Code-name:	stretch
uname = Linux

Steps to Reproduce:

Simply download the .deb (Debian) VSC File
Install with Package install

This file will not install on my Raspberry Pi 3 B, because a specific package that is required for installation is missing. Where and what package can I install?

We do not support VS Code on ARM, not sure where you got that deb from.

What do you mean "where I got that .deb from"? I got it from your own
Visual Studio code website? There were 3 categories: Windows, Linux,
and Apple. In the Linux category, there were two file types, .deb and
.rpm. .deb is the file type that is a closest match to Raspbian, so I
downloaded it. If you don't believe where I got it from, I can post
the link below.

We only support

https://code.visualstudio.com/Download
On Mon, Sep 30, 2019 at 7:16 AM João Moreno<EMAIL_ADDRESS>wrote:

We only support
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/81585?email_source=notifications&email_token=AKV6JOSWSG35ZW7WZ5TJ3E3QMH3ZPA5CNFSM4I3OYWQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD75S3HI#issuecomment-536554909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKV6JORV2QQD54QPJ3W3CWTQMH3ZPANCNFSM4I3OYWQA
.

Try this instead https://code.headmelted.com/. Note that the code hasn't been maintained recently and there is a specific version you need to use in order to make it run on Raspberry Pi.

Which version of what? Version of VSC or Raspbian?

The version of Headmelted's compiled VS Code for ARM.
Basically, what joaomoreno saying is that the linux build on the download link you mentioned was made for x64 linux, which does not work with ARM processor (Raspberry Pi). You will either have to compile the code yourself or get the pre-build by others. Headmelted was one of the folks who build VS Code on ARM and then share with others. However, his latest build doesn't work and only show blank screen when the app is open.
See this thread for more details: https://github.com/microsoft/vscode/issues/6442

So I should just use Python IDE for python projects if it won't work on my Pi?

Personally, I use Thonny IDE for Python as it comes with Raspbian by default. I only use VS Code for JavaScript-based stuff to develop web-application (e.g., Gatsby.js). I find designated Python IDEs that came with Raspbian perform better than VS Code, but to each their own, I guess.


output.libretiny_pwm not working

Hi all, I am new to libretiny, and this one has been throwing me through a loop... I have been getting an error saying platform not found: 'output.libretiny_pwm'
I am attempting to finalize cloudcutting of some tuya downlights and this is the only thing stopping me. I was able to get the code to be accepted when using "output.ledc" but clearly that doesnt work with the lights anymore.  Below is my esp yaml.
attached is an image of the errors.
esphome:
  name: office-downlight-01
  friendly_name: office-downlight-01

bk72xx:
  board: generic-bk7231n-qfn32-tuya

# Enable logging
logger:

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password
  ap:

ota:
  password: !secret ota_pass001

text_sensor:
  - platform: libretiny
    version:
      name: LibreTiny Version

output:
  - platform: libretiny_pwm
    id: output_red
    pin: P8
  - platform: libretiny_pwm
    id: output_green
    pin: P24
  - platform: libretiny_pwm
    id: output_blue
    pin: P26
  - platform: libretiny_pwm
    id: output_cold
    pin: P7
  - platform: libretiny_pwm
    id: output_warm
    pin: P6

light:
  - platform: rgbww
    id: light_rgbww
    name: Light
    color_interlock: true
    cold_white_color_temperature: 6500 K
    warm_white_color_temperature: 2700 K
    red: output_red
    green: output_green
    blue: output_blue
    cold_white: output_cold
    warm_white: output_warm

You are using an old version of the add-on.  You should switch to the official ESPHome add-on, and libretiny_pwm will work fine.


Malloc error with .toJSON();

During tests on iOS I got stuck with some XML string (http://rdlpzg.gis-net.pl/geoserver-zg/wms/?request=GetCapabilities&service=WMS).
Creating an object works fine:
var xml = new XMLTools(this.responseText);```

but using .toJSON():

`xml.toJSON();`

 casue malloc (memory allocation) error and freezes the app.

If there is no good way to work with long XMLs then there should be some safety gauge which would prevent occuring such error (try/catch doesn't work in this case).

Regards and thanks for great work.

That's a big file and might be a little hard to debug.
The library uses recursion in JS, so size might be the issue.
Can you debug the library and see where it crashes.

Hi,
Thanks for quick answer.
The problem is not with the file. Other (online) libraries can manage that
file. Library you use (http://www.thomasfrank.se/xml_to_json.html) get
error here:
SyntaxError: identifier starts immediately after numeric literal
....service.onlineresource.xmlns%3axlink=unescape('http%3A//www.w3.org/1999/xlink'
line 79: eval() function;
Regards
2015-02-11 23:18 GMT+01:00 David Bankier<EMAIL_ADDRESS>
That's a big file and might be a little hard to debug.
The library uses recursion in JS, so size might be the issue.
Can you debug the library and see where it crashes.
—
Reply to this email directly or view it on GitHub
https://github.com/dbankier/XMLTools-For-Appcelerator-Titanium/issues/8#issuecomment-73977047
.

Not sure. As an FYI, XMLTools doesn't use that the library, only follows its syntax.


Update s3, sso, ssooidc to 2.23.6

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sso
software.amazon.awssdk:ssooidc

from 2.21.46 to 2.23.6
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #37.


Move Github Releated Operations from OpenApiHub to Other place

For my understanding, what operations where moved and to where?
We use some logic in the Scheduler app so I am curious if we can reutilize some of the work you did


[Bug]

Describe the bug
LittleXS Settings not showing up in device settings
Please complete the following information:

Device: iPhone 8 Plus
iOS Version: iOS 12.4

Additional context
LittleXS is the only thing I have since I jailbreaked. I would like to disable the iPhone X Keyboard but I can't as far as settings are not available.. :/

Make sure "PreferenceLoader" is installed on your device. If you get the settings to work, an option to disable the iPhone X keyboard will be available.

It did work, thank you.
A good idea would be to add it to dependencies list, as it is not specified on the tweak page / not installed with the packet !


Istio issues with cert-manager, vault and cert-manager-istio-csr

Bug Description
Hello,
I'v setting up an istio configuration with those parameters :
Created self-signed ROOT-CA on Vault.
CN=istio.internal
Created 1 intermediate CA on Vault.
CN=istio.internal
allowed_domains=["istio.internal"]
Created cert-manager and configured vault as an issuer.
Everything is working on this side :
k get issuers.cert-manager.io -o wide
NAME                       READY   STATUS           AGE
vault-istio-admin-issuer   True    Vault verified   5h41m
Installing cert-manager-istio-csr :
cert-manager-istio-csr-c8ccdf96d-26mft     1/1     Running   0          41m
k get certificate
NAME     READY   SECRET       AGE
istiod   True    istiod-tls   5h41m
Trying to starting an istio with istioctl :
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  profile: "demo"
  values:
    global:
      meshID: mesh-admin
      multiCluster:
        clusterName: cluster-admin
      network: network-admin
      caAddress: cert-manager-istio-csr.cert-manager.svc:443
  components:
    pilot:
      k8s:
        env:
          # Disable istiod CA Sever functionality
        - name: ENABLE_CA_SERVER
          value: "false"
        overlays:
        - apiVersion: apps/v1
          kind: Deployment
          name: istiod
          patches:

            # Mount istiod serving and webhook certificate from Secret mount
          - path: spec.template.spec.containers.[name:discovery].args[7]
            value: "--tlsCertFile=/etc/cert-manager/tls/tls.crt"
          - path: spec.template.spec.containers.[name:discovery].args[8]
            value: "--tlsKeyFile=/etc/cert-manager/tls/tls.key"
          - path: spec.template.spec.containers.[name:discovery].args[9]
            value: "--caCertFile=/etc/cert-manager/tls/ca.crt"

          - path: spec.template.spec.containers.[name:discovery].volumeMounts[6]
            value:
              name: cert-manager
              mountPath: "/etc/cert-manager/tls"
              readOnly: true
          - path: spec.template.spec.containers.[name:discovery].volumeMounts[7]
            value:
              name: ca-root-cert
              mountPath: "/etc/cert-manager/ca"
              readOnly: true

          - path: spec.template.spec.volumes[6]
            value:
              name: cert-manager
              secret:
                secretName: istiod-tls
          - path: spec.template.spec.volumes[7]
            value:
              name: ca-root-cert
              configMap:
                defaultMode: 420
                name: istio-ca-root-cert

istioctl install -f cluster-admin.yaml --set meshConfig.trustDomain=istio.internal
This will install the Istio 1.14.1 default profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N) y
✔ Istio core installed
✔ Istiod installed
✘ Ingress gateways encountered an error: failed to wait for resource: resources not ready after 5m0s: timed out waiting for the condition
Deployment/istio-system/istio-ingressgateway (containers with unready status: [istio-proxy])

Pruning removed resources
Error: failed to install manifests: errors occurred during operation

The istiod pod start well, but i got issue with istio-proxy :
2022-07-06T15:01:33.925544Z     warn    ca      ca request failed, starting attempt 1 in 101.943628ms
2022-07-06T15:01:34.027967Z     warn    ca      ca request failed, starting attempt 2 in 205.704512ms
2022-07-06T15:01:34.234417Z     warn    ca      ca request failed, starting attempt 3 in 417.770519ms
2022-07-06T15:01:34.653351Z     warn    ca      ca request failed, starting attempt 4 in 759.414808ms
2022-07-06T15:01:35.413444Z     warn    sds     failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"istio.internal\")"
2022-07-06T15:01:43.394960Z     warning envoy config    StreamAggregatedResources gRPC config stream closed since 740s ago: 14, connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"istio.internal\")"
2022-07-06T15:02:02.019782Z     warning envoy config    StreamAggregatedResources gRPC config stream closed since 759s ago: 14, connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"istio.internal\")"
2022-07-06T15:02:19.711247Z     warning envoy config    StreamAggregatedResources gRPC config stream closed since 776s ago: 14, connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"istio.internal\")"

I have checked my certs with : https://istio.io/latest/docs/ops/common-problems/injection/#x509-certificate-related-errors but they both give the same MD5SUM.
Did you know what i miss or if its a bug ?
Version
istioctl version
client version: 1.14.1
control plane version: 1.14.1
data plane version: none
kubectl version --short
Client Version: v1.22.0
Server Version: v1.22.9-eks-a64ea69
helm version --short
v3.9.0+g7ceeda6

Additional Information
k get secrets
NAME                                               TYPE                                  DATA   AGE
default-token-kdqrc                                kubernetes.io/service-account-token   3      26h
istio-egressgateway-service-account-token-hbkxd    kubernetes.io/service-account-token   3      15m
istio-ingressgateway-service-account-token-k6kb9   kubernetes.io/service-account-token   3      15m
istio-reader-service-account-token-tgbct           kubernetes.io/service-account-token   3      15m
istiod-ca-pem                                      Opaque                                3      178m
istiod-service-account-token-l957d                 kubernetes.io/service-account-token   3      15m
istiod-tls                                         kubernetes.io/tls                     3      6h
istiod-token-h7k7g                                 kubernetes.io/service-account-token   3      15m
vault-issuer                                       kubernetes.io/service-account-token   3      26h
vault-issuer-approle                               Opaque                                1      23h
vault-issuer-token-dhnrn                           kubernetes.io/service-account-token   3      26h

k get cm
NAME                              DATA   AGE
istio                             2      15m
istio-ca-root-cert                1      69m
istio-csr                         0      23h
istio-gateway-deployment-leader   0      3h16m
istio-gateway-status-leader       0      3h16m
istio-leader                      0      3h16m
istio-sidecar-injector            2      15m
kube-root-ca.crt                  1      26h

k get validatingwebhookconfigurations.admissionregistration.k8s.io
NAME                                               WEBHOOKS   AGE
admin-admission                                    1          167d
aws-load-balancer-webhook                          2          167d
istio-validator-istio-system                       1          15m
nginx-ingress-controller-ingress-nginx-admission   1          167d
validation.webhook.config.karpenter.sh             1          84d
validation.webhook.provisioners.karpenter.sh       1          84d
vpc-resource-validating-webhook                    2          168d

k get mutatingwebhookconfigurations.admissionregistration.k8s.io
NAME                                           WEBHOOKS   AGE
admin-admission                                1          167d
aws-load-balancer-webhook                      2          167d
defaulting.webhook.provisioners.karpenter.sh   1          84d
istio-sidecar-injector                         4          15m
pod-identity-webhook                           1          168d
vpc-resource-mutating-webhook                  1          168d

allowed_domains=["istio.internal"] is this your cluster domain, if so you may need config it in you IstioOperator yaml.


operator cert-manager (1.13.1)

Signed-off-by: Richard Wall<EMAIL_ADDRESS>

/merge possible

/merge possible

/merge possible


[m3u8] network Video play error when drag the progress bar to an unbuffered position

When I drag the progress bar to an unbuffered position,
it will freeze some second and then jump back to the beginning at 0:00.
flutter_meedu_videoplayer
I test flutter_meedu_videoplayer on  macos and ios , the error will exists
but , i test web [https://zezo357.github.io/flutter_meedu_videoplayer_example/#m3u8]  , It's OK , It's OK !!!!!
test code is project   m3u8_page_example.dart
flutter_meedu_media_kit
I  test  flutter_meedu_media_kit ,and update media_kit version to lastest , the error still exist
test code is project   m3u8_page_example.dart
same macos player app
i test macos player [IINA.app],  same  url , same drag to a nunbuffered position, it's not work too....
but [VLC.app] not this error,  it's work~
need help
i don't know, how to sloved this error,  I also don't have any solution ideas at the moment.
@zezo357   need help ~~
Thank you ~

I must clarify that I refrain from engaging with NSFW content. However, if the issues are prevalent on macOS and iOS, it's likely related to the media_kit. Have you tested it on iOS without using media_kit? It's also worth noting that the web version uses HLS, which relies on a dedicated JavaScript library.
Please note, I've removed the links related to NSFW content from the repository. My apologies, but I believe it's important to maintain a professional standard.

Sorry, the URL  I provided was incorrect. I have now provided the correct link.
https://twitter.com/CHENLEITO/status/1688935503733645312

https://video.twimg.com/amplify_video/1687553528854646784/pl/63-3Engy9Suh_mKY.m3u8?variant_version=1&tag=14&container=fmp4

#EXTM3U
#EXT-X-VERSION:6
#EXT-X-INDEPENDENT-SEGMENTS
#EXT-X-STREAM-INF:AVERAGE-BANDWIDTH=787470,BANDWIDTH=2460802,RESOLUTION=1280x720,CODECS="mp4a.40.2,avc1.640020"
/amplify_video/1687553528854646784/pl/1280x720/VDCNxX576c0Xs7dU.m3u8?container=fmp4
#EXT-X-STREAM-INF:AVERAGE-BANDWIDTH=297320,BANDWIDTH=933944,RESOLUTION=640x360,CODECS="mp4a.40.2,avc1.4d001f"
/amplify_video/1687553528854646784/pl/640x360/_xRBv1fckeY4cLBi.m3u8?container=fmp4
#EXT-X-STREAM-INF:AVERAGE-BANDWIDTH=107647,BANDWIDTH=322434,RESOLUTION=480x270,CODECS="mp4a.40.2,avc1.4d001e"
/amplify_video/1687553528854646784/pl/480x270/80nPrpcso5b-Ywxx.m3u8?container=fmp4

https://video.twimg.com/amplify_video/1687553528854646784/pl/1280x720/VDCNxX576c0Xs7dU.m3u8?container=fmp4

Q: Have you tested it on iOS without using media_kit
A: Yes  ,   macos   and ios will error when drag the progress bar to an unbuffered position

Also I think it may be the logic of separating the m3u8 to qualities is the one causing the problem
But further testing will make me sure

I can add an option to disable logs


(feat): Add pagination to risk time series and risk summary endpoints.

Can now pass other rows and pages for pagination when calling physical_risk_summary and physical_risk_timeseries.
Example:
ts = pf.assets().physical_risk_timeseries(risk_type=RiskType.FIRE, page_size=250)
Note that 250 is the largest page size allowable by the API.

Good suggestions. Updated.

@johnorcutt one little thing, then please squash and merge!


Submodule cloning failures

I'm pretty sure it's caused by submodule URLs in .gitmodules starting with<EMAIL_ADDRESS>The file should look like this:
[submodule "external/commonItems"]
	path = external/commonItems
	url = https://github.com:ParadoxGameConverters/commonItems.git
[submodule "external/googletest"]
	path = external/googletest
	url = https://github.com:google/googletest.git
[submodule "external/fmt"]
	path = external/fmt
	url = https://github.com:fmtlib/fmt.git
[submodule "external/Fronter.NET"]
	path = external/Fronter.NET
	url = https://github.com:ParadoxGameConverters/Fronter.NET.git

I tried to update it, but can't push a commit for some reason.

Odd. Are you cloning using https or ssh? If https, are you configured to work with ssh? My understanding is that either should work, and that ssh is preferred these days.

And you should have all necessary permissions to push now. Though you should have before too.

Odd. Are you cloning using https or ssh? If https, are you configured to work with ssh? My understanding is that either should work, and that ssh is preferred these days.

I tried to clone via https. Didn't add SSH keys to GitHub.


Trust/Distrust Always High

The current implementation only takes into account the high of each period. Wouldn't it be better to use High, Low, and Close appropriately?

I should also point out that once it is made greedy, it stays greedy. There should be some reset point or alert to the user that the bot needs restarted.

Yea I noticed this as well after a big rally I think it places a small amount a little too high, thinking it will reach the same peak. Normally I think after a rally the peak is a bit lower

It's a fairly "dumb" strategy at this point, this kind of feedback allows it to get better, keep it coming and let's see if I or other contributors can implement it at some point.


Crashes when using non-rest controllers (like Hessian)

Our project uses a combination JSON API endpoints, served by normal controllers, and a RPC endpoint served by Hessian using a HessianServiceExporter.  When SpringSandwitch is included.  I get the following crash anytime the hessian endpoint is hit:
16:26:16 [http-nio-8080-exec-1] ERROR o.a.c.c.C.[.[.[.[dispatcherServlet] - Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.ClassCastException: org.springframework.remoting.caucho.HessianServiceExporter cannot be cast to org.springframework.web.method.HandlerMethod] with root cause
java.lang.ClassCastException: org.springframework.remoting.caucho.HessianServiceExporter cannot be cast to org.springframework.web.method.HandlerMethod
	at com.kastkode.springsandwich.filter.internal.InterceptDelegator.preHandle(InterceptDelegator.java:34)
	at org.springframework.web.servlet.HandlerExecutionChain.applyPreHandle(HandlerExecutionChain.java:134)

SpringSandwhich shouldn't process any controllers that aren't normal web controllers.  This patch causes it to ignore them.
I also removed the super calls to HandlerInterceptorAdapter because they are no-ops in the parent class.

Apologies, didn't see this til now.  Thanks for the patch, will take a look

Thanks for the patch, I merged it in!  Good point about the super calls being NOPs, but I restored them nonetheless, on principle really, because the cost is negligible and who knows whether in future they may add needed side-effects into those calls...


not found Piont.mat

can you share Point.mat  file ? email<EMAIL_ADDRESS>

I just added the sample Point.mat file on the repo


Highlight dyn as a keyword

dyn is already implemented in nightly, so maybe dyn should be highlighted somehow in the playpen?

should be highlighted somehow

Syntax highlighting is provided by ACE — perhaps you'd be willing to submit a pull request to them?

in the playpen?

There is no playpen. There is only the playground.

"Rust Playpen" =? "The Rust Playground" =? "play.rust-lang.org site".

Sounds good, vim [sic]. Names have meanings and differences; the very old site was called the playpen.

Only now realized the difference.

Thank you for opening an issue on Ace. Once there's a corresponding PR, I can probably hack up the existing Rust highlighter using the diff. I just don't want to be forced into maintaining a perpetual fork of an open source project without very good reason.

The PR has been merged.


Known Bug: Stack frames are incorrectly marked with in_app

In the image above, the typescript file is marked in_app: false, while the JS file is marked in_app: true. It should be the other way around.

It isn't quite clear the usage of in_app for Type/JavaScript code, for now all I found was the following mention:
https://github.com/getsentry/sentry-javascript/commit/858c2f7ac627211f8803eb2c6e03418ac3ce610e#diff-6872f62e614276844d459602f9ddbc095baae448ca27e35fcd0d053ea85e97ebR11-R12
My current sugestion for this fix: consider all browser frames as in_app as long as they don't come from vendor.*.js and polyfills.*.js.
What do you think @bruno-garcia  and @marandaneto?

@AbhiPrasad or @lobsterkatie might help here, I don't know the inApp logic for JS that well.

Closing this since the expected behavior was implemented.


A cut at Suave for Core with Paket ping @forki

Fixes https://github.com/fsharp-editing/Forge/issues/84

https://github.com/fsharp-editing/Forge/pull/81#issuecomment-327029916


Image not shown in emulator - Even onSuccess was triggered

Hi,
I'm facing a problem which I have no point how to solve it. I use Kingfisher for loading Image by URL.
In the preview the image has been loaded and shown correctly. The onSuccess has been also triggered when running with the simulator

But in the simulator, the images doesn't show up at all.

I'm not sure if Kingfisher needs any permission for storage on the simulator? Or do I miss something?

It seems that you rendered these images as a template. Maybe it is set somewhere in your outer view or it is the default render mode for the container view. I guess adding a .renderingMode(.original) after the KFImage would solve your issue.

Thank @onevcat , setting .renderingMode(.original) solves my problem. I'm trying to understand what exactly happened with the .renderingMode setting.


Treat LoadErrors for known gems as trivial

Fixes part of #1273.

Known gems: e.g. require 'nokogiri' -> considered a trivial LoadError; Nanoc will tell you to add nokogiri to the Gemfile.

Unknown gems: Usual stack trace.

The error message is still crappy:
% bundle exec nanoc
Loading site… Error: cannot load such file -- nokogiri
Make sure the gem is added to Gemfile and run `bundle install`.

Better:
% bundle exec nanoc
Loading site…

Error: cannot load such file -- nokogiri

1.  Add the `nokogiri` gem to your Gemfile:

        gem 'nokogiri'

2.  Run `bundle`

3.  Re-run `bundle exec nanoc`


Provide Documentation on How to Set the Bot Up and Get it Running

Creating the .env file
How to set up a discord bot and where to get API keys - https://github.com/SinisterRectus/Discordia/wiki/Setting-up-a-Discord-application
What commands to use to start it
etc

I just had this thought yesterday when setting it up. Luckily I already knew how to work with Discord bots, but it doesn’t hurt to lower the barrier of entry for others. If you weren’t working on this, I’m happy to do this.

@twalton83 I'll assign this to you :)

We can close this one now :)

We can close this one now :)


Ignore maven files of subprojects

Reasons for making this change:
When the maven project is a multi-project, each sub-project have a target folder. They should be ignored.
Links to documentation supporting these rule changes:
The updated pattern can be found in https://git-scm.com/docs/gitignore

@EricXing any links to StackOverflow discussions or other documentation about this change?

@shiftkey  this is about ignore sub-folders.

@EricXing this is not necessary... Try it:
cd /tmp
mkdir git-subfolder-test
cd git-subfolder-test
git init
mkdir foo
mkdir -p bar/foo
touch foo/test.txt
touch bar/test.txt
touch bar/foo/test.txt
echo "foo/" > .gitignore
git add .
git status

--> only .gitignore and bar/test.txt are listet; content of both foo/directories is ignored, without **/foo/
** is only required for more complex ignores like **/foo/bar.txt. But simple file.txt and folder/ rules are always matched globally.
You can also have a look a at the official gitignore documentation.

BTW: It seems that you mixed up your pull requests:
#2097 and #2098
are also contained here

@drothmaler I have tested it. Thank you.
I really mixed up my pull requests. #2097 and #2098 have been closed.


fix(akmods): Build failure since Ublue's switch to negativo17 repos with some akmods

They don't utilize RPMFusion anymore, so some akmods are missing.
Those include VL42Loopback & WL (Broadcom) akmods.
https://github.com/ublue-os/bluefin/pull/1748

Fixed with: https://github.com/blue-build/modules/commit/a7f021283cbcdac9b28fd11a3dfb8ffa7397929e


Adding stan math c++ to conda forge ?

This is more a feature request than a bug.
Would it be possible to add stan-math c++ to conda-forge ?
https://conda-forge.org
This way it would be possible to work with stan-math through an easy installation with xeus-cling, which is a c++ interpreter in a jupyter notebook.
https://github.com/jupyter-xeus/xeus-cling
Thank you !

Thanks. This is the right place for feature requests, too.  I don't imagine it'll be hard because stan-dev/math gets installed as part of CmdStan.  I'm pinging @WardBrian, who worked on putting CmdStan on conda.

This is definitely reasonable (and probably the 'right way' to handle CmdStan on conda is to do this instead, assuming we can point the CmdStan makefiles at the separate math lib), I just wasn't sure if people would it separately from CmdStan

Just wondering @faysou - what would you be looking for out of a conda installation? stan-math doesn't have something like a make install target. It seems like mainly what it would offer is an easy way to download the package and put it somewhere on the library path, but not much else. Am I missing some benefit?

I don't know how they're built, but I think there are at least three binaries required:

Intel Thread Building Blocks (low-level threading tools),
Sundials (ode solver), and
MPI (multi-process).

@WardBrian what I would like is to work interactively with stan-math inside a jupyter c++ notebook. This is possible with xeus-cling. I'm curious if automatic differentiation would also work in the notebook interactively.

I suppose my question is, what about the current process is not able to support that which a conda installation would? Are you currently able to point xeus-cling at a local copy of stan-math?

No, I haven't even tried. The point of having stan-math as a conda-forge recipe would be to have conda install it without a local installation. Some projects use conda-forge for this purpose, so I'm point this out as I think it could be useful.

The question is whether cling would be up to compiling Stan and all its associated packages, some of which are binaries that need to be linked or somehow also compiled with cling.

I remember that the conda-forge project is designed to allow remote compilations for different target systems, so then users only download compiled binaries for their system.

That is correct, but there is no compiled binary for stan-math
Several of the libraries it depends on are already on conda, such as tbb here: https://anaconda.org/conda-forge/tbb
I'm pretty certain only macos builds use clang however, so I'm not sure how compatible with xeus-cling they end up being

I'm not sure of the feasibility, I don't know stan-math enough. My suggestion was more from a user point of view, it could make prototyping easier.

I'm not terribly familiar with C++ library packaging, but my understanding header-only libraries like stan-math have no object file they get compiled to. This is different from packages like boost (just picking an example off your list above), some parts of which get installed by building a .(dylib|so|dll) file and then placing that somewhere.
To phrase this another way, if you've downloaded the stan-math repository, I believe that you  have installed it. The only difficulty here is that it depends on other libraries which do need to be built, but those are likely available on conda.
I think all you would need to do is download stan-math, install tbb and sundials from conda, point stan-math to those libraries in make/local, and then point cling to where stan-math is downloaded and the #includes should work. I don't think conda can make this any simpler besides perhaps pre-setting the make/local variables unless there is something I don't understand here.
I was able to find a few header-only libraries on conda, but they are only there if they use cmake to set up dependency paths so other people can link to them.
@bob-carpenter probably knows better if there really is a sense in which stan-math can be "installed" other than just downloading it.

@WardBrian, then what you say means a conda recipe on conda forge is possible.

I don’t think there’s any meaningful way of having stan-math on conda the way it is currently conceived of. If we added a cmake installation method to the library then we could make a very minimal conda package which basically consisted of the output of that process

I'll try your suggestion then. You are better placed than me to know what's possible with the library. Maybe it will be possible in the future, at least it's on your radar. Thank you

Again, @bob-carpenter knows more and may conceive of better way of installing.
You could also try installing the cmdstan package on conda, as it contains stan-math and the required libraries, and then pointing cling towards <CONDA_ENV>/bin/cmdstan/stan/lib/stan_math

Ok thank you.
Here's another similar discussion for packaging in conda a c++ library.
https://github.com/Dobiasd/FunctionalPlus/issues/161#issuecomment-576007525

The parts of Stan math that the Stan team wrote are largely header only.  The dependent libraries are not.  I'm not sure how TBB, Sundials, and MPI get built as part of the Stan math lib.  There's nothing in Stan per se to compile as far as I know, just these external dependencies.
Somehow, these libraries must be getting either built or just brought in as binaries with the CmdStan install.

FunctionalPlus uses cmake to generate an install target for conda to use, like the other header libraries I mentioned
The libraries in stan that need to be built are build during the cmdstan build, or you can point to existing versions with a make variable. In the cmdstan conda build, we do a bit of both. I’m not sure if stan-math by itself even has a make target to build them or if it’s all upstream


INTEGRATION [PR#1299 > development/8.0] ci(main.yml): add mem tests

This pull request has been created automatically.
It is linked to its parent pull request #1299.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.0/feature/ZENKO-549-ci-mem-tests, please follow this
procedure:
#!bash
 $ git fetch
 $ git checkout w/8.0/feature/ZENKO-549-ci-mem-tests
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.0/feature/ZENKO-549-ci-mem-tests

Please always comment pull request #1299 instead of this one.

close


What do the defines in part 3 mean?

What do all the defines in part 3 mean? What is #define SIGNERSCORE_LOGO_PREMIUM? What? Where do I add this - to my inf file, to my driver file?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70062259-782d-7d6a-08a1-d01d33edf46c
Version Independent ID: 2922b3e2-ae65-2a09-8de3-fa80808ff953
Content: Driver matching criteria
Content Source: windows-driver-docs-pr/display/driver-matching-criteria.md
Product: windows-hardware
GitHub Login: @nabazan-microsoft
Microsoft Alias: windowsdriverdev

Thanks for the questions, @karel-3d
@mimisasouvanh can you please triage this request and add it to your backlog appropriately?

@EliotSeattle What would I love to see are more clarifications in the text itself :) right now it is very confusing.

@karel-3d Do you mean the section you spoke of, this particular topic, our docs in general? Also, for this particular topic, I must point out that WDDM 1.2 was released in Window 8 and is not our most recent offering. Are you also targeting Windows 8?

Hello,
I am developing a driver that has to work in win 7, win 8 and win 10.
The problem is that on some PCs, some other drivers are "overriding" our drivers on our devices. So I tried to find an order how is Windows deciding which driver to use for a given device.
The only document that describes this is the linked one. However it is not very clear what the linked document actually says and what do the defines actually mean, and if it even solves my problem in the first place.

...oh now I noticed it is in display drivers, so not at all related. My device is a USB device not related to displays. Should I close this issue?

What I needed was this document
https://docs.microsoft.com/en-us/windows-hardware/drivers/install/overview-of-the-driver-selection-process


Multiple Loggers : Only first mentioned logger used as default insider Trainer.fit()

Bug description
In the event of using Multiple Loggers inside the Trainer, we pass loggers as a List. I found that multiple loggers are not being used upon calling the Trainer.fit() function. Since any lightning hook or function can access the loggers except init, I see that only the first mentioned logger is being used as default.
How to reproduce the bug
from pytorch_lightning.loggers import TensorBoardLogger, WandbLogger

logger1 = TensorBoardLogger(save_dir="tb_logs", name="my_model")
logger2 = WandbLogger(save_dir="tb_logs", name="my_model")
trainer = Trainer(logger=[logger1, logger2])

```ruby
print(logger)
# Output
[<pytorch_lightning.loggers.tensorboard.TensorBoardLogger object at 0x7fe12d9d9970>, <pytorch_lightning.loggers.wandb.WandbLogger object at 0x7fe12d9f12b0>]

trainer.fit(model=model,datamodule=datmodule)
print(self.logger)
# Output : Issue
<pytorch_lightning.loggers.tensorboard.TensorBoardLogger object at 0x7fe12d9d9970>

# Inside Model module

def training_step(self,batch: Any, batch_idx: int):
        print(self.logger)
        print(self.logger[1])

# OUTPUT
<pytorch_lightning.loggers.tensorboard.TensorBoardLogger object at 0x7fe12d9d9970>
Error:
TypeError: 'TensorBoardLogger' object is not subscriptable

_
Issue: Turns out self.logger takes the 1st logger(index 0) by default and raises error on calling 2nd logger(index 1)
_
Line: 2148  https://github.com/Lightning-AI/lightning/blob/ae14f9d1b355859b258d5bacaeff74917fc8cc74/src/pytorch_lightning/trainer/trainer.py#L112
What worked for me by changing the following inside trainer.py
#What's Wrong :
    @property
    def logger(self) -> Optional[Logger]:
        return self.loggers[0] if len(self.loggers) > 0 else None

#What worked
@property
    def logger(self) -> Optional[Logger]:
        return self.loggers if len(self.loggers) > 0 else None

### Error messages and logs

Error messages and logs here please

```ruby
Error:
TypeError: 'TensorBoardLogger' object is not subscriptable

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0): 1.8.3.post1   pypi_0
#- PyTorch Version: 1.13.0   py3.9_cuda11.7_cudnn8.5.0_0
#- Python version: 3.9.15
#- CUDA/cuDNN version: 11.7.1

More info
@
cc @awaelchli @borda @Blaizzy

@kamranisg I think the issue is that you have a typo, it should be:
print(self.logger)  # access the first logger
print(self.loggers[1])  # access multiple loggers (plural)

Does that make sense?

Yes, Thanks !!
Indeed it was a typo. It works with self.loggers[1]
But I took the idea from the documentation of torch lightning which still stays
self.logger[0] and not self.loggers[0] to access the indexed logger among multiple loggers.
class MyModule(LightningModule):
    def any_lightning_module_function_or_hook(self):
        some_img = fake_image()
        # Option 1
        self.logger.experiment[0].add_image("generated_images", some_img, 0)
        # Option 2
        self.logger[0].experiment.add_image("generated_images", some_img, 0)

Link: https://pytorch-lightning.readthedocs.io/en/1.6.1/common/loggers.html
Is this correct in the documentation?

No. Would you like to open a PR with the fix?

Yes, I would like to.


retention policy on Enabling Transcription Logging by using Group Policy

Summary of the new feature / enhancement
currently, there is no retention policy on Enabling Transcription Logging by using Group Policy, so they might be a capacity issue over time
Proposed technical implementation details (optional)
No response

What kind of retention policy would you want? Total number of transcripts? Transcript size? Date? I always assumed it was the IT pro's responsibility to manage transcript files.

What kind of retention policy would you want? Total number of transcripts? Transcript size? Date? I always assumed it was the IT pro's responsibility to manage transcript files.

I think this is for when transcription is on via GPO so the IT Pro (or other user) doesn't necessarily know there are files to manage. If there is a location set it wouldn't be hard for whatever turns logging on to check that location for files over a certain age, or more than some size in aggregate.   If the suggestion is for a GPO to hunt down the transcripts I've left here there and everywhere - that would be a tougher job entirely.

Hi Jeff,
Apology for the late response.
Retention policy on each text file size I meant.
Regards,
Mohammad
On Tue, 8 Aug 2023 at 06:34, jhoneill @.***> wrote:

What kind of retention policy would you want? Total number of transcripts?
Transcript size? Date? I always assumed it was the IT pro's responsibility
to manage transcript files.
I think this is for when transcription is on via GPO so the IT Pro (or
other user) doesn't necessarily know there are files to manage. If there is
a location set it wouldn't be hard for whatever turns logging on to check
that location for files over a certain age, or more than some size in
aggregate. If the suggestion is for a GPO to hunt down the transcripts I've
left here there and everywhere - that would be a tougher job entirely.
—
Reply to this email directly, view it on GitHub
https://github.com/PowerShell/PowerShell/issues/20070#issuecomment-1668396109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXBPD5KK2KMQ5S73N53V4Z3XUEYMHANCNFSM6AAAAAA3B7ZVAU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
--
Best Regards,
Mohammad Torabi.

+1
We've seen this filling up drives on DCs. We use a number of monitoring technologies that use PowerShell to perform monitoring functions (i.e. System Venter Operations Manager) and it can generate quite a number of transcripts, and the setting is required by DISA STIG:
https://www.stigviewer.com/stig/microsoft_windows_server_2022/2023-05-03/finding/V-254384
(meaning we can't turn it off)
If you don't own this .admx send me that direction please.


request for an npm package

We need better solution of dependency management, please.
And the name https://www.npmjs.com/package/smoothscroll is already taken, maybe try another.

Well https://www.npmjs.com/package/smoothscroll-polyfill

@jiyinyiyong is there any chance you can pass me the ownership to smoothscroll-polyfill? I'm planning on doing a refactor containing a commonjs valid approach and some other fixes and was planning to use that name.

@jeremenichelli sure. I found your name on npm. Check it out.

Thanks a lot @jiyinyiyong 🙏

This should now work correctly as an npm package requiring it and calling the polyfill method like this:
require('smoothscroll-polyfill').polyfill();


bump terraform-equinix-fabric-connection module version to 0.4.0

Note: In fabric connection modules for cloud providers all the connection logic happens in submodule terraform-equinix-fabric-connection, therefore user-agent will include the terraform-equinix-fabric-connection metadata module name and not terraform-equinix-fabric-connection-oci in this case.

Please add the DRE team to this repo so that our approving reviews will make PRs mergeable.


Can't open the Sketch file

Same problem here - I'm using the 3.1 beta version.

That's pretty weird. I tried to download the file and opened it with Sketch 3.1 & 3.2 with no problem. I gonna investigate more.
In the meantime, please try to download the file here: https://www.dropbox.com/s/xvi8g8b688yx7kz/Bootflat Sketch.sketch?dl=0
If you still get the problem, pls tell us.
Thanks for your feedbacks!

Just an update, I downloaded the non-beta version (3.2.2) and it opened up fine.

@fabianhenzler could you tell us the exact version you used?

The one that didn't open up was Version 3.1 (8603). It was a beta version.

I'm using the most recent AppStore Version of Sketch

Same problem with Sketch version 3.3 (11970)

OK, I think I found the issue here.
Because the github branch was named as "bootflat-ui-kit.sketch" so when you downloaded the zip and extracted, you got a sketch file instead of a folder.
We will correct the branch name. In the mean time, after extracting the zip, try to rename "bootflat-ui-kit.sketch" to "bootflat-ui-kit.zip" and extract it. You can also download the sketch file only from this link:
https://www.dropbox.com/s/xvi8g8b688yx7kz/Bootflat Sketch.sketch?dl=0
Tell me if it works for you.

Yes! That was it. Thank you :)

the repo was renamed from https://github.com/teracyhq/bootflat-ui-kit.sketch to https://github.com/teracyhq/bootflat-ui-kit-sketch
it should work now, so I clos this.


Bundle Bastion Host with Simple E2E Deployment

This PR fixes

Bundle Bastion Host with Simple E2E Deployment

TODO:

[ ] Fix issue in Bastion and recreate ARM template

Preview Link


Coverage report does not show when multi file input

or am I doing sth incorrect?

It was missing by design, just release a version that fixed that, you can use:
- name: Pytest Coverage Comment
  uses: MishaKav/pytest-coverage-comment@main
  with:
      pytest-coverage-path: ./data/pytest-coverage_4.txt
      multiple-files: |
        title1, ./data/pytest-coverage_4.txt, ./data/pytest_1.xml

or use specific version
- name: Pytest Coverage Comment
  uses<EMAIL_ADDRESS>  with:
      pytest-coverage-path: ./data/pytest-coverage_4.txt
      multiple-files: |
        title1, ./data/pytest-coverage_4.txt, ./data/pytest_1.xml

thank you!
thanks for the great tool!

hmm but does this work for multiple coverage files?

this is what you can get

right, but are we able to get multiple coverage report showed in ui? in our case we run the pytest twice and they generates models_coverage.txt and common_coverage.txt

can pytest-coverage-path take multiple file path I guess?

can pytest-coverage-path take multiple file path I guess?

on which property name are you talking?

- name: Pytest Coverage Comment   uses<EMAIL_ADDRESS> with:       pytest-coverage-path: ./data/pytest-coverage_4.txt       multiple-files: |         title1, ./data/pytest-coverage_4.txt, ./data/pytest_1.xml
above essentially indicating that they can be only one coverage report since pytest-coverage-path takes one path only, can we make it to take multiple paths so that it can generate multiple coverage report?

currently pytest-coverage-path support only a single file. I don't think that I will add this feature at all.
GitHub comments are very limited, especially when the action posts rich HTML with links etc, so sometimes that is not enough space even for one report.
I can suggest you try running this action twice (each time for a different report) and pass the create-new-comment: true, in this way it should post you 2 different reports (2 different comments)

I see.. thank you so much!


Extended BIDS for animals

Could we have sub- changed to the species e.g. in http://datashare.is.ed.ac.uk/handle/10283/2122 we used rat instead of sub (rat- mice- cat- dog- there is more and more stuff out there now)
when using mutant we could either have it in the participant description or right away in the name, e.g. rat-SD-Bdnftm1sage_seq-SE_task_flashing-light_bold.nii.gz

Original authors: Unknown

@TheChymera wrote:

Could we have sub- changed to the species e.g. in http://datashare.is.ed.ac.uk/handle/10283/2122 we used rat instead of sub (rat- mice- cat- dog- there is more and more stuff out there now)

I would advise against this. I work with animals myself, and each animal is a subject. Sub is perfectly fine.

@CPernet wrote:

I would advise against this. I work with animals myself, and each animal is a subject. Sub is perfectly fine.

yes and no, sub is perfectly fine indeed but then in a large database it makes things easy to download / analyze based on the name

@jcolomb wrote:

yes and no, sub is perfectly fine indeed but then in a large database it makes things easy to download / analyze based on the name

I would also say this information should not end in the folder name, it will make development of tool species specific... a specific type of metadata would do the trick (and be back-compatible (?) )

@TheChymera wrote:

when using mutant we could either have it in the participant description or right away in the name, e.g. rat-SD-Bdnftm1sage_seq-SE_task_flashing-light_bold.nii.gz

The difference between mutants and genotypes is merely nominal. Increasingly, double and triple transgenes are used in mouse studies. Soon enough multiple genotypes will be tracked in species without inbred strains (incl humans). This addition simply doesn't scale. Not least of all, Bdnf isn't a very descriptive mutant name. Is it a knockout? Point mutation? Variant? and then, is that homozygous? hetero? Ideally we should be weary of BIDS tracking too much info, lest it becomes encumbered. If necessary, I would propose tracking such info in a per-subject JSON.

@CPernet wrote:

The difference between mutants and genotypes is merely nominal. Increasingly, double and triple transgenes are used in mouse studies. Soon enough multiple genotypes will be tracked in species without inbred strains (incl humans). This addition simply doesn't scale. Not least of all, Bdnf isn't a very descriptive mutant name. Is it a knockout? Point mutation? Variant? and then, is that homozygous? hetero? Ideally we should be weary of BIDS tracking too much info, lest it becomes encumbered. If necessary, I would propose tracking such info in a per-subject JSON.

yes agree we can move it in the JSON - do you have references / standard on how to ref animals ; I know there is some work done on using DOI to identify them ; might be worth having this as well if possible

yes agree we can move it in the JSON - do you have references / standard on how to ref animals ; I know there is some work done on using DOI to identify them ; might be worth having this as well if possible

This is very much an open question, we would need input from somebody who is more thoroughly active in the cutting-edge of genetics. Genome sequencing is not ubiquitous enough for us to be able to link the genome via a DOI. In animals for which we use inbred strains, a possible solution would be to have a string field for the strain, and a list of strings field for the tested genetic variants, e.g.
strain: 'C57BL/6'
gene_variants: ['DAT-IRES-Cre','ePet-Cre']

This is of course, just a dummy example, in truth gene variants have highly complex naming schemes (see these links for the above two: https://www.jax.org/strain/006660 , https://www.jax.org/strain/012712 ), with plenty of superscripts. Ideally we would first need to find out what the best standard for unambiguous identification of gene variants and insertion sites is, and just use that. Ideally this would also be a standard which doesn't use superscript — while I do assume we all use unicode by now, there's lots to be said for legibility.

Please, have a look at reagents.io .
In brief: for reagents, the best PID are called RRID, but while some tried to use it for animal strains, specialists are calling against it, but would better see a system using the PID of the databases (species specific database for now, but see the encode project: https://www.encodeproject.org)
for rodents, there are MGI numbers. I do not know if one can get a MGI number for a strain before publication or if only published strains/genetic alteration get one. For example, for the first example above ( https://www.jax.org/strain/006660), the correct PID would be http://www.informatics.jax.org/allele/genoview/MGI:3689567.
(the first link goes to the specific strain available at jax, the second could link to several mice providers.)
It is quite complexe to find and few researchers would get it right...

Hi all, thanks @jcolomb to mention the neuroscience-data-structure project
We have indeed launched a dedicated focus group (which will soon appear as a Special Interest Group of the INCF) to try to standardize the structuring of data and metadata recorded in animal models, with any modalities (from electrophysiology to calcium imaging, via MRI)... Several ongoing initiatives are trying to address this, and we'd like to see how to accommodate them to reach a wide adoption by the community at large. One of the questions that we aimed at addressing is of course "would it make sense to do this within BIDS, or are there enough specifics with animal data that forces us to go outside of BIDS", and we of course would like to address this question with as much feedback as possible from the community...
Anyhow, if you are interested in this endeavor, do not hesitate to get in touch with me and/or to participate in the discussions that we started in the Issues of this project: https://github.com/INCF/neuroscience-data-structure
Cheers,
Sylvain

@TheChymera wrote:

Could we have sub- changed to the species e.g. in http://datashare.is.ed.ac.uk/handle/10283/2122 we used rat instead of sub (rat- mice- cat- dog- there is more and more stuff out there now)

I would advise against this. I work with animals myself, and each animal is a subject. Sub is perfectly fine.

in parallel with the wider neuroscience-data-structure project, we've tried to come up with some internal rules within our 150-people institute (see our current state of affairs here: https://int-nit.github.io/AnDOChecker/ ; it's not BIDS-compatible, but not too far... comments welcome!!! ;) )... we chose to stick with sub-XXX, and we're pushing towards XXX being some kind of GUID; for animals, our GUID remains human-readable, and we we have one letter dedicated to specifying the species of the animal in our GUID...

As to me this proposal goes against common principle of BIDS of having entity-{value} composition in the filenames etc, but taking value of a potential entity (species) and making it into an "entity". Also demand seems to be simply not there, so I would simply close this one. If someone wants to resurrect -- please chime in, or do so.

Not resurrecting, just updating, since the original rat-{value} proposal was a quote by me. I have long since moved to sub-{value}. This is no longer a current proposal on my part.

Not sure if I'm the original originator. Just wanted to clarify that there's nobody remaining in support of this now, since the only quote in its support was from me → https://github.com/bids-standard/bids-2-devel/issues/38#issuecomment-668047141

the authors of the datasets are mentioned - at the time in 2016 when I was in Edinburgh I helped/pointed Xenios Milidonis to BIDS, he made that dataset


Incomplete prerequisites for “Resize CPU and Memory Resources assigned to Containers”

my k8s version:1.27.2
kubectl get nodes
NAME                      STATUS   ROLES           AGE   VERSION
<IP_ADDRESS>              Ready              7d    v1.27.2
<IP_ADDRESS>             Ready              7d    v1.27.2
ecs6w3fxmxy5c.novalocal   Ready    control-plane   7d    v1.27.2
Problem
I want to try in-place update and I do as the document describe.
But when I execute the cmd kubectl -n qos-example patch pod qos-demo-5 --patch '{"spec":{"containers":[{"name":"qos-demo-ctr-5", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}',it threw err:
The Pod "qos-demo-5" is invalid: spec: Forbidden: pod updates may not change fields other than `spec.containers[*].image`,`spec.initContainers[*].image`,`spec.activeDeadlineSeconds`,`spec.tolerations` (only additions to existing tolerations),`spec.terminationGracePeriodSeconds` (allow it to be set to 1 if it was previously negative)
  core.PodSpec{
        Volumes:        {{Name: "kube-api-access-p29n4", VolumeSource: {Projected: &{Sources: {{ServiceAccountToken: &{ExpirationSeconds: 3607, Path: "token"}}, {ConfigMap: &{LocalObjectReference: {Name: "kube-root-ca.crt"}, Items: {{Key: "ca.crt", Path: "ca.crt"}}}}, {DownwardAPI: &{Items: {{Path: "namespace", FieldRef: &{APIVersion: "v1", FieldPath: "metadata.namespace"}}}}}}, DefaultMode: &420}}}},
        InitContainers: nil,
        Containers: []core.Container{
                {
                        ... // 6 identical fields
                        EnvFrom: nil,
                        Env:     nil,
                        Resources: core.ResourceRequirements{
                                Limits: core.ResourceList{
-                                       s"cpu":    {i: resource.int64Amount{value: 700, scale: -3}, s: "700m", Format: "DecimalSI"},
+                                       s"cpu":    {i: resource.int64Amount{value: 800, scale: -3}, s: "800m", Format: "DecimalSI"},
                                        s"memory": {i: {...}, Format: "BinarySI"},
                                },
                                Requests: core.ResourceList{
-                                       s"cpu":    {i: resource.int64Amount{value: 700, scale: -3}, s: "700m", Format: "DecimalSI"},
+                                       s"cpu":    {i: resource.int64Amount{value: 800, scale: -3}, s: "800m", Format: "DecimalSI"},
                                        s"memory": {i: {...}, Format: "BinarySI"},
                                },
                                Claims: nil,
                        },
                        ResizePolicy: nil,
                        VolumeMounts: {{Name: "kube-api-access-p29n4", ReadOnly: true, MountPath: "/var/run/secrets/kubernetes.io/serviceaccount"}},
                        ... // 12 identical fields
                },
        },
        EphemeralContainers: nil,
        RestartPolicy:       "Always",
        ... // 28 identical fields
  }

/language en
/sig docs
ref link: https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/

/kind support

/retitle Incomplete prerequisites for “Resize CPU and Memory Resources assigned to Containers”
/remove-kind support
/kind bug
The prereqisited section of https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/ should state that your cluster must have InPlacePodVerticalScaling enabled on the control plane and on nodes; however, it does not.
/triage accepted
/priority backlog
/sig node
Thank you for reporting this @THMAIL

/retitle Incomplete prerequisites for “Resize CPU and Memory Resources assigned to Containers”
/remove-kind support /kind bug
The prereqisited section of https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/ should state that your cluster must have InPlacePodVerticalScaling enabled on the control plane and on nodes; however, it does not. /triage accepted /priority backlog /sig node
Thank you for reporting this @THMAIL

Thank you for your reply.And I have modified the file /etc/kubernetes/manifests/kube-apiserver.yaml, add InPlacePodVerticalScaling=true
But there's another problem:

I execute the cmd kubectl -n qos-example patch pod qos-demo-5 --patch '{"spec":{"containers":[{"name":"qos-demo-ctr-5", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}'
the pod can't start ,run kubectl get pod qos-demo-5 --namespace=qos-example -o wide

NAME         READY   STATUS             RESTARTS        AGE   IP                NODE            NOMINATED NODE   READINESS GATES
qos-demo-5   0/1     CrashLoopBackOff   8 (5m11s ago)   17m   <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>

run kubectl describe pod qos-demo-5 --namespace=qos-example,Event log:

Events:
  Type     Reason     Age                    From               Message
  ----     ------     ----                   ----               -------
  Normal   Scheduled  4m32s                  default-scheduler  Successfully assigned qos-example/qos-demo-5 to <IP_ADDRESS>
  Normal   Pulled     4m28s                  kubelet            Successfully pulled image "nginx" in 2.299559292s (2.299579947s including waiting)
  Normal   Started    4m28s                  kubelet            Started container qos-demo-ctr-5
  Normal   Killing    3m13s                  kubelet            Container qos-demo-ctr-5 definition changed, will be restarted
  Normal   Pulled     3m10s                  kubelet            Successfully pulled image "nginx" in 2.311044787s (2.311062277s including waiting)
  Normal   Pulled     3m7s                   kubelet            Successfully pulled image "nginx" in 2.167481718s (2.167497407s including waiting)
  Normal   Pulled     2m50s                  kubelet            Successfully pulled image "nginx" in 2.217118706s (2.217147034s including waiting)
  Normal   Pulling    2m21s (x5 over 4m30s)  kubelet            Pulling image "nginx"
  Normal   Created    2m19s (x5 over 4m28s)  kubelet            Created container qos-demo-ctr-5
  Warning  Failed     2m19s (x4 over 3m10s)  kubelet            Error: failed to start container "qos-demo-ctr-5": Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: failed to write "80000": write /sys/fs/cgroup/cpu,cpuacct/kubepods.slice/kubepods-podd6170de3_c124_47d6_a641_6b10f5b690cb.slice/qos-demo-ctr-5/cpu.cfs_quota_us: invalid argument: unknown
  Normal   Pulled     2m19s                  kubelet            Successfully pulled image "nginx" in 2.09857171s (2.098667953s including waiting)
  Warning  BackOff    110s (x4 over 2m34s)   kubelet            Back-off restarting failed container qos-demo-ctr-5 in pod qos-demo-5_qos-example(d6170de3-c124-47d6-a641-6b10f5b690cb)

my docker version is latest:
docker version
Client: Docker Engine - Community
 Version:           24.0.1
 API version:       1.43
 Go version:        go1.20.4
 Git commit:        6802122
 Built:             Fri May 19 18:06:42 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.1
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       463850e
  Built:            Fri May 19 18:05:43 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Linux <IP_ADDRESS> 3.10.0-862.el7.x86_64 #1 SMP Fri Apr 20 16:44:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

If you do want help with Kubernetes @THMAIL, please ask elsewhere. This issue tracker is the right place to tell us about shortcomings in the docs, and the wrong place to get advice on using features (alpha or otherwise).
If / when you can point out a new problem, you are welcome to file an issue so that we can cover that. SIG Node can then look at improving the docs for the beta.

/assign
@sftim Quick question about feature gates, is there a way to specify the specific feature gate that must be enbaled for alpha/beta features within the feature state tag so that we don't have to manually edit docs every time a feature graduates or the Kubernetes version updates?

Hi @criscola
This issue is still waiting for a volunteer / contributor to pick it up and work on a fix.

I have go to bed, it's too late. Tomorrow I will tell you how to make it happen发自我的iPhone------------------ Original ------------------From: Cristiano Colangelo  @.>Date: Wed,Jun 28,2023 10:08 PMTo: kubernetes/website @.>Cc: LiYuXin @.>, Mention @.>Subject: Re: [kubernetes/website] Incomplete prerequisites for “Resize CPU and Memory Resources assigned to Containers” (Issue #41365)
Can someone please write precisely how to enable this feature? I tried to pass the flag like that: --feature-gates=InPlacePodVerticalScaling=true to kube-scheduler but kube still forbids patches to pod resources.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
[
{
@.": "http://schema.org",
@.": "EmailMessage",
"potentialAction": {
@.": "ViewAction",
"target": "https://github.com/kubernetes/website/issues/41365#issuecomment-1611484146",
"url": "https://github.com/kubernetes/website/issues/41365#issuecomment-1611484146",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
@.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Can someone please write precisely how to enable this feature? I tried to pass the flag like that: --feature-gates=InPlacePodVerticalScaling=true to kube-scheduler but kube still forbids patches to pod resources.

This is my config, anyone help me to check it?
cat > config.yaml << EOF
apiVersion: kubeadm.k8s.io/v1beta3
bootstrapTokens:
- groups:
  - system:bootstrappers:kubeadm:default-node-token
  token: abcdef.0123456789abcdef
  ttl: 24h0m0s
  usages:
  - signing
  - authentication
kind: InitConfiguration
localAPIEndpoint:
  advertiseAddress: <IP_ADDRESS>
  bindPort: 6443
nodeRegistration:
  criSocket: unix:///var/run/containerd/containerd.sock
  imagePullPolicy: IfNotPresent
  name: kubernetes-01
  taints: null
  kubeletExtraArgs:
    feature-gates: InPlacePodVerticalScaling=true
---
apiServer:
  timeoutForControlPlane: 4m0s
  extraArgs:
    feature-gates: InPlacePodVerticalScaling=true
apiVersion: kubeadm.k8s.io/v1beta3
certificatesDir: /etc/kubernetes/pki
clusterName: kubernetes
controllerManager:
  extraArgs:
    feature-gates: InPlacePodVerticalScaling=true
dns: {}
etcd:
  local:
    dataDir: /var/lib/etcd
imageRepository: registry.aliyuncs.com/google_containers
kind: ClusterConfiguration
kubernetesVersion: 1.27.2
networking:
  dnsDomain: cluster.local
  serviceSubnet: <IP_ADDRESS>/12
  podSubnet: "<IP_ADDRESS>/16"
scheduler:
  extraArgs:
    feature-gates: InPlacePodVerticalScaling=true
EOF

Regarding this issue, it might be obvious that the in-place vertical scaling has to get kubelet involved. There are some technical implementation details as well. The scheduler has to reconsider the resource requests and limits, the ResourceQuota controller has to adjust its behavior as well, so on and so forth.
This leads me to rethink about a related topic. Maybe we were right when we avoided to document the feature gates on a per-component basis. Today the feature gate list is "shared" by all components. The implementation for some features like this one (in-place scaling) may involve several components. There could be a chance that feature FOO is only about the API server and the scheduler today, but soon the developers realize that the controller-manager has to do something as well to cover a corner case.

cc @tallclair @AnishShah @esotsal
From a quick glance this looks like a documentation limitation, though the code changes for beta may also affect this situation

/triage accepted

/retitle [FG:InPlacePodVerticalScaling] Incomplete prerequisites for “Resize CPU and Memory Resources assigned to Containers”

Hi,
I see that docker engine was used , is cri-dockerd used ?  If yes this looks like the same situation described at the first item in InPlacePodVerticalScaling known issues and discussed also here
If cri-dockerd was used then i recommend to repeat the tests using a cri-o or a containerd container runtime version satisfying InPlacePodVerticalScaling CRI APIs requirements.
CRI APIs requirements for InPlacePodVerticalScaling can be found at

cri-api/pkg/apis/runtime/v1/api.proto and
v1.25 release notes referring to CRI changes to support in-place pod resize

Added  [FG:InPlacePodVerticalScaling] prefix in title, to use this input to improve documentation especially with the forthcoming graduation of InPlacePodVerticalScaling to beta.  Feel free to reach InPlacePodVerticalScaling community also at sig-node-inplace-pod-resize Slack channel.


Rename ApiDefinition to HttpApiDefinition

This is because, we will have support for other protocols such as  GrpcApiDefinition,

Blocked on #282 and other refactoring

This is a duplicate ticket


Integrate GUTS testing framework

going to close this out in favor of mirroring the test harness of godot-cpp


Settings page copy/style changes

add help copy to some email notifications headers
add full stop to winner's notification header copy
make deadline date container wider so it fits in one line

 As an admin, I want the Buckingham Palace reception attendee information due by deadline to be on 1 line

 [QAE17IMP] As an Admin I want to see help copy in the date settings, so it is clear what all of the date's do and how they affect users


Validation with sales channel context

1. Why is this change necessary?
There is currently no way to add SalesChannelContext depending validations for example, based on the selected payment method. By changing the method signature, this is now possible via decoration of the actual OrderValidationService.
2. What does this change do, exactly?
Changes the method signature of all ValidationServices
3. Describe each step to reproduce the issue or behaviour.
Try to add a validator based on a payment method
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

hey @jochenmanz
thanks for your contribution. could you please sign the CLA?

@mitelg singed

Hey @jochenmanz,
we've needed this feature too, i've tried to rebase your PR but the merge conflicts were insane,
so i ended up reimplemting your change:
Bad news:
Your PR will not get merged, sorry for that :)
Good news:
The changes will make it into the product.
Thanks again for your contribution :tada: :blue_heart:


np.append

Is there an equivalent method to np.append?  If not, what is the best workaround?

Maybe np.concatenate, np.vstack or np.stack will help you. They might require reshaping to emulate np.append.


[7.11.24] Create form for contacts

Motivation

We are introducing a new feature "contact information". A form is needed for it.
Proposed Solution

Implement a form to create a new contact and to edit an existing one.
❓ Make it sure at least one of E-mail address, telephone number or website is given.
💡 Reuse venue_box.html for the step of selecting/creating a POI.
💡 Reuse _related_contents_table.html to show where the contact is embedded.
Alternatives

None. We do it.
User Story

Additional Context

Wait for #2952
Design Requirements

See the design here
⚠ There are two versions in the link above. New Version 30.07 is the one we have to implement.

The cancel (Abbrechen) button will be implemented in #2930. It is not consistent with other contents and may be confusing for users if the cancel button is only available in the contact form.

blocked by #3015

The design suggests to mark the fields "title" and "name" with * to make it clear that they are mandatory, but mandatory fields of other forms are not marked at all. Should we probably introduce the * systemwide at once? #3028

TBD: removing E-mail, phone number and website from POI.
We have those three fields not only in POIs but also in contacts. If those fields are managed only in contacts, we can avoid redundancy, maintenance like #3033 and check boxes in #3034 .
@david-venhoff Feel free to add commnets 😸

TBD: removing E-mail, phone number and website from POI.
We have those three fields not only in POIs but also in contacts. If those fields are managed only in contacts, we can avoid redundancy, maintenance like #3033 and check boxes in #3034 .
@david-venhoff Feel free to add commnets 😸 @PeterNerlich You're invited to the discussion too 😸

This idea was confirmed and will be implemented. See #3086


Fix to changelog

Quick PR to fix changelog, which had not been updated for the 0.1.1 release; it now correctly reflects changes since that tag separately.

Failure of test is not related to PR


Saving issues in chunks that unload

Hello! This is the first of a couple bugs I will report on this. Basically what goes on is that for any changes I make to a chunk, if that chunk is unloaded shortly afterward, more often than not, the changes I made will not be saved. If I should add any more information, let me know and I will add it, but that is the general description of what is going on. There is no crashes associated with it, but some of the time I will also only see the loss of data after reloading or exiting.

This is caused by the server not saving chunks in time when the game closes, causing queued chunks to be thrown away (see #11 )

This might also have been caused by some broken IO thread synchronization, which I just fixed in 93af916a47b53f565e8020a9d25c5a3109a5456e


Pcb rev3b - Power Sequencing code

Should ignore the PCB files ;)

Not sure how these are still open.


[ISSUE] OIDC operator does not populate "state=" parameter required for OIDC

Describe the issue:

When making a OIDC login request the "state=" paramerer is passed but it is empty. Ory Hydra (and standards compliance OIDC) rejects this as state should be >= 8 characters.

Actual behavior:
URL created for login has an empty state= parameter in query string.
Expected behavior:
The URL created to sign into OIDC provider should include a populated state= parameter.
How to reproduce:
Run OIDC client (Ory Hydra) and try to login to operate.
Logs:

Environment:
Docker
      - CAMUNDA_IDENTITY_TYPE=GENERIC
      - CAMUNDA_IDENTITY_ISSUER=https://secure.dev.klustr.io/hydra
      - CAMUNDA_IDENTITY_ISSUER_BACKEND_URL=https://secure.dev.klustr.io/hydra
      - CAMUNDA_IDENTITY_CLIENT_ID=<removed>
      - CAMUNDA_IDENTITY_CLIENT_SECRET=<removed>

@camunda/identity This issue looks like related to the app not the chart, do you have any input about it?

Hi @terrancesnyder and @aabouzaid
I briefly investigated with the team and we are currently not supporting the state parameter being set. Sorry about that.
Please feel free to open a feature request for it. 🙂

I already talked with the team, who opened a public issue to track that feature.
So I will close this issue for now.


Added functionality for deep JSON object injection (#131)

This feature allows an attribute from a JSON object of an indefinite depth to be parsed by FlexibleMink's injectStoredValues() system, so that the following Behat feature lines will parse successfully:
    When the affiliate sends a GET request to "/api/v1/account/(the account->accounts_id of the response)/orders"
    Then the deep property "(the parent->parent->name of the Family)" should contain "Mary"

This change is

Removing reviewers since this has been closed.


exp/lighthorizon: Refactor archive interface and support parallel ledger downloads.

What
This is a sizeable PR. I recommend reviewing it commit by commit rather than the whole thing at once to get a sense of the progression.
Major changes
This makes the following major changes:

the data model (LedgerTransaction) just embeds an *ingest.LedgerTransaction directly; this is simpler until/if/when we decide to deviate from that
Archive has been renamed Ingester and incorporates MetaArchive in the following way:

MetaArchive is now an interface
an Ingester extends MetaArchives with

PrepareRange (important for parallel downloads)
NewLedgerTransactionReader (to create a tx reader off of a ledger)

a basic liteIngester is just a MetaArchive + a network passphrase
a complex parallelIngester adds the ability to download ledgers in parallel (more below)

GetTransactionParticipants and GetOperationParticipants are now standalone functions as there's no need for them to be tied to an instance
searchAccountTransactions now prepares checkpoint ranges before iterating
NewIngester creates a parallelIngester if the -parallel-downloads <count> parameter is appropriate
Cursors can now Advance() more than once with a times parameter
Fixes bugs in on-disk cache synchronization (this should be probably be a separate PR)

How parallel downloads work
The architecture for parallel download feeds (parallelIngester) follows:

There exist workerCount perpetual worker routines that run forever, ready to take ledger sequences off of the queue and download them.
When they complete a download they add it to the ledgerFeed (indexed by sequence) and notify along the signalChan.
The consumer (i.e. GetLedger()) should wait on the signalChan and check the feed for the ledger it's looking for.
The feed is carefully kept under a reader-writer lock.
There's also a ledgerQueue so that consumers can know whether or not their requested ledger sequence is in the download queue. This lets certain ledgers be prioritized if they aren't in the queue already.

Why
Parallel downloads of ledgers have demonstrably decreased latency times, especially for requests that span large ledger ranges.
Known limitations

The workers exist forever without a way to close them, but the web process should never close, meaning this is generally okay for an MVP.
I'm not entirely sure the way the ledgerQueue, ledgerFeed, and GetLedger() interact is optimal.

I have to update the test cases to handle the refactor which is a pain in my side bc the mocking hides a lot of stuff, but I still think the general code is RFR :+1:

I noticed there's a ticket https://github.com/stellar/go/issues/4468 in the platform scrum for this effort, how about in that case then the PR can just state Closes <issue_no>rather than add PR to the project also, and then can move the #4468 to 'needs review' ? otherwise the board has two cards shown representing the same work.


Fix katacoda id

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f7b1618c796c1e7f9b3fe6bdf47ee1a5abd76bb2/
Edited pages:

tutorials/learn-cockroachdb-sql-interactive.md


Optionally, replace circular references with the key it points to

Currently, circular references are each replaced with the string [Circular]. It would be helpful to identify which key the circular reference points to.
const foo = {a: true};
foo.b = foo.a;

console.log(safeStringify(foo));
//=> '{ "a": true, "b": "[Circular]" }'

console.log(safeStringify(foo, { trace: true } ));
//=> '{ "a": true, "b": "[Circular *a]" }'

Not something I need, but a good pull request would be welcomed.

@binyamin your example does not produce a circulare reference, foo.a will be resolved to true. I can find the value in this issue, but there are many edge cases to consider. Suppose the following example:
const foo = {a: true};
foo.b = foo;
foo.c = foo.b;

console.log(safeStringify(foo, {trace: true}));

There are multiple correct outputs we can expect:
Output 1:
{"a":true,"b":"[Circular *]","c":"[Circular *]"}

Output 2:
{"a":true,"b":"[Circular *]","c":"[Circular *b]"}

In the first output, we resolve from c -> b -> *, where * is the root object. The second output is also valid but stops the trace at the first reference which is b.
Another case which has beeen retrieved from the tests is the following:
const fixture = {
    a: true,
};

fixture.b = fixture;

console.log(safeStringify({x: fixture, y: fixture}, optionsWithTrace));

A possible output would be:
{"x":{"a":true,"b":"[Circular *x]"},"y":"[Circular *x]"}

Here both keys x and y reference the root object, but because the value of x is the root object itself, as it is for y, the final output uses the x key to resolve the reference, which is correct algorithmically.
I'm going to push a PR to track a possible solution.
Due to the nature of circular references and the makeCircularReplacer function we cannot guarrantee the final indicator value. The algorithm will always return the correct result, but we cannot know easily ahead of time which key it will choose. What we know is that every time a new circular reference appears, we push the corresponding key and value to a WeakMap. Depending on the object traversal the final value is calculated.

If anyone wants to work on this, see the initial attempt and feedback here: https://github.com/sindresorhus/safe-stringify/pull/3

I learned about the content of this PR - https://github.com/sindresorhus/safe-stringify/pull/3. According to the latest code, the latest implementation of the trace function is shown below:
function safeStringifyReplacer(seen, trace) {
	return function (key, value) {
		if (value !== null && typeof value === 'object') {
			if (seen.has(value)) {
				return trace ? `[Circular *${seen.get(value)}]` : '[Circular]';
			}

			seen.set(value, key);

			const newValue = Array.isArray(value) ? [] : {};

			for (const [key2, value2] of Object.entries(value)) {
				newValue[key2] = safeStringifyReplacer(seen, trace)(key2, value2);
			}

			seen.delete(value);

			return newValue;
		}

		return value;
	};
}

export default function safeStringify(object, {indentation, trace} = {}) {
	const seen = new WeakMap();
	return JSON.stringify(object, safeStringifyReplacer(seen, trace), indentation);
}

Assuming there is an object:
const obj = {
	a: 'a',
	b: {
		prop1: 'prop1',
		b: {}
	}
};

Set circular reference:
obj.b.b.f = obj.b

Run safeStringify(obj, { trace: true })
'{"a":"a","b":{"prop1":"prop1","b":{"f":"[Circular *b]"}}}'

If the circular reference set above is another b
obj.b.b.f = obj.b.b

There is no difference in the results of running the safeStringify function. Which one of the circular references cannot be intuitively determined.
So I think when opening trace, the key should not be directly displayed, but the path of the key should be displayed.
The path of the key, just like when the second parameter of Lodash's get function is a string.
var object = { 'a': [{ 'b': { 'c': 3 } }] };

_.get(object, 'a[0].b.c');

The expected outcome should be the following:

obj.b.b.f = obj.b

'{"a":"a","b":{"prop1":"prop1","b":{"f":"[Circular *b]"}}}'

obj.b.b.f = obj.b.b

'{"a":"a","b":{"prop1":"prop1","b":{"f":"[Circular *b.b]"}}}'

What is your opinion？

I expect it to show the full path (the second one).
You could use this as inspiration: https://github.com/sindresorhus/decircular/blob/main/index.js

I like this library — decircular. Although I will not invent from scratch, I have learned a lot from your code, and I am grateful from the bottom of my heart.
I have one last question for you, regarding the case where the access path is a number:
// property a is an array
const obj = {
	"a": [
		{
			"b": {
				"c": 3
			}
		}
	]
}

// or property a is an object, but key is a number
const obj = {
	"a": {
		0: {
			"b": {
				"c": 3
			}
		}
	}
}

If you want to read the value of attribute c, the valid access path in the above two cases in JS should be: obj.a[0].b.c, not obj.a.0.b.c

In decircular
const object1 = {
	a: 1,
	b: [
		{
			c: 2,
		}
	]
};

const object2 = {
	a: 1,
	b: {
		0: {
			c: 2,
		}
	}
};

object1.b[0].d = object1.b[0]; // Creates a circular reference
object2.b[0].d = object2.b[0]; // Creates a circular reference

console.log(decircular(object1));
console.log(decircular(object2));

The reference path output in the log is [Circular *b.0] instead of the available [Circular *b[0]]. Do you think it should be changed to the path available in JS ([Circular *b[0 ]]), but it seems that [Circular *b.0] is more intuitive, because only one square bracket will appear.