Status

Coverage decreased (-0.1%) to 90.022% when pulling fe297414191dedaf17f9a5343195e4bf2987d336 on status into 6b52099d0c7db0b5afea22a373e1b7c35cdee09d on master.


Turkish Language Support

I added the Turkish language to make the dashboars more understandable in Turkey. In this way, employees can monitor the machine's status, etc. can see in the local language.
Description
It's not a merge I did against a problem. I just added the translation of the Turkish language. For this, I set up an else if structure between the existing if - else structure.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I haven't done any testing.
Test Configuration:

Kubernetes Version:
Helm Version:
Hardware:

Checklist:

[ ] I have made corresponding changes to the documentation
[ ] I have made corresponding changes to the changelog (if needed).
[ ] I have made corresponding notices to the upgrade instructions (if needed)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Nice! Let's wait until @Scarjit is back from holidays and then we will be probably able to merge it


Feature request - Rename displays

Hi, thank you for this useful plasmoid.
It would be nice to add the ability to rename displays under  general settings

I'll implement this into the next major release but don't expect it any time soon as I am pretty busy right now.


Binding & Bindings now children of abstracts TerminusModel & TerminusCollection

Toward #411

This seems to keep the existing functions behavior, but applies new patterns, looks good. +1


what's the role of the function "find_seq" defined in the class "SkeletonPool" in skeleton.py?

Hi=.=, it's me again,
Could you please describe the role of the function "find_seq" defined in the class "SkeletonPool" in skeleton.py as well as the role of the attribute "self.seq_list" for me?
According to my understanding so far, after the Skeleton pooling, we need a new topology to help us to calculate the neigboring list/matrix for the next Skeleton convolution layer.
But I haven't make it clear after reading the code.
Many thanks!

Note that in skeletal pooling, we only pool on "sequences". Here sequence means a sequence of connected vertices in the tree topology that doesn't contain any branch. (Thus, a single joint with more than one child forms a sequence with length 1.) find_seq finds sequences recursively, and stores the result of dividing the tree into sequences in self.seq_list.
After getting self.seq_list, we can apply pooling on the sequences easily. The new topology is then stored in self.new_edges.
Hope this will help.

Note that in skeletal pooling, we only pool on "sequences". Here sequence means a sequence of connected vertices in the tree topology that doesn't contain any branch. (Thus, a single joint with more than one child forms a sequence with length 1.) find_seq finds sequences recursively, and stores the result of dividing the tree into sequences in self.seq_list.
After getting self.seq_list, we can apply pooling on the sequences easily. The new topology is then stored in self.new_edges.
Hope this will help.

Thanks for the replying! Almost get it, besides, there is also one thing I'd like to ask:
As mentioned in the paper, the skeleton pooling removes the nodes with degree 2. But for the initial skeleton graph(e.g. Fig.2 showed in the paper), there are many nodes with degree 2, but you just remove part of those nodes after the first pooling layer. Then how to determine which node should be removed or not among all those nodes with degree 2?
Many thanks!

In one pooling operation we pool two adjacent joints into one. If the length of a sequence is odd, we keep the nearest one to root and pool the others.

Thanks!


chore: ensure we don't try to compile any C++ code

We don't have any C++ code in this repo, and want to make sure that our examples don't transitively depend on building protoc from source.
#13 should have been red due to the issue I fixed in https://github.com/protocolbuffers/protobuf/pull/17078
This change ensures that PR and any others that regress will be caught by CI.
It should be the case that users with a broken or non-hermetic CC toolchain are still able to work with Protocol Buffers.

@fmeum this fails for the wrong reason: rules_go doesn't ship with a binary of the Go stdlib.
We discussed that in some thread on Slack I think.
Can you suggest a different way to prevent transitives from accidentally compiling protoc from source? I want that to be a hard fail if it occurs.

I sent https://github.com/aspect-build/toolchains_protoc/pull/17


remove the unnecessary argument in the CreateTrigger func in wiretap

CreateTrigger function has an unnecessary parameter.
Maybe forgot to remove it after the function structure was changed.

Hey, @tzununbekov
just a minor fix.


[SE-0304] Update the conformances of TaskPriority

Add Codable (synthesized conformance, single-value container) to match the implementation.
Add RawRepresentable (instead of using the raw-value-enum syntax).

Should any of the following be changed before release? The current implementation has:

an @_alwaysEmitIntoClient property for the medium priority;
a static let property for the deprecated default priority;
an unused _downgradeUserInteractive property.


Publish ScubaGear to PowerShell Gallery

🗣 Description
Enhanced GitHub Workflow to allow publishing a ScubaGear release to PowerShell Gallery
closes #94
💭 Motivation and context
This is to provide easier access to ScubaGear for users.
🧪 Testing

Dispatched workflow to publish release
Installed release (i.e., Install-Module)
Imported ScubaGear and executed against a tenant, Got epected results.
Executed 'Find-Module -Name ScubaGear -Repository PSGallery -AllowPrerelease' got expected results
Executed 'Uninstall-Module -Name ScubaGear' got expected results.

📷 Screenshots (if appropriate)

✅ Pre-approval checklist

[X] This PR has an informative and human-readable title.
[X] PR targets the correct parent branch (e.g., main or release-name) for merge.
[X] Changes are limited to a single goal - eschew scope creep!
[X] Changes are sized such that they do not touch excessive number of files.
[X] All future TODOs are captured in issues, which are referenced in code comments.
[X] These code changes follow the ScubaGear content style guide.
[X] Related issues these changes resolve are linked preferably via closing keywords.
[X] All relevant type-of-change labels added.
[X] All relevant project fields are set.
[X] All relevant repo and/or project documentation updated to reflect these changes.
[X] Unit tests added/updated to cover PowerShell and Rego changes.
[X] Functional tests added/updated to cover PowerShell and Rego changes.
[X] All relevant functional tests passed.
[X] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

Everything looks good. Just one question, should we also modify the Readme to call out PS Gallery as an alternate installation path?

It is my opinion that we should update the README indicating the install from PowerShell Gallery is the preferred method.  The download zipped version should be deprioritized - it is useful so I don't think we deprecate it. If an official release (i.e., 1.1.1) of ScubaGear will be published to PowerShell then absolutely we need to update. Otherwise, defer till next sprint/release.

@crutchfield looks like there's a merge conflict now

@nanda-katikaneni , I think this one is ready.

Great job! I can prefer see this as the preferred method. It took me some time to figure out how to configure the inline script part. Also took me some time to figure out how to make this work without AKV, but fantastic stuff.


Dedicated Docs for JWT and VC JWTs

Clarify:
https://www.w3.org/TR/vc-data-model/#jwt-decoding
Originally from https://github.com/TBD54566975/web5-js/pull/421/files
Clarify the language and vc jwt examples for these claims:

If any of these steps fail, the function will throw a [Error] with a message indicating the nature of the failure:

exp MUST represent the expirationDate property, encoded as a UNIX timestamp (NumericDate).

iss MUST represent the issuer property of a verifiable credential or the holder property of a verifiable presentation.

nbf MUST represent issuanceDate, encoded as a UNIX timestamp (NumericDate).

jti MUST represent the id property of the verifiable credential or verifiable presentation.

sub MUST represent the id property contained in the credentialSubject.

Once the verifications are successful, when recreating the VC data model object, this function will:

If exp is present, the UNIX timestamp MUST be converted to an [XMLSCHEMA11-2] date-time, and MUST be used to set the value of the expirationDate property of credentialSubject of the new JSON object.

If iss is present, the value MUST be used to set the issuer property of the new credential JSON object or the holder property of the new presentation JSON object.

If nbf is present, the UNIX timestamp MUST be converted to an [XMLSCHEMA11-2] date-time, and MUST be used to set the value of the issuanceDate property of the new JSON object.

If sub is present, the value MUST be used to set the value of the id property of credentialSubject of the new credential JSON object.

If jti is present, the value MUST be used to set the value of the id property of the new JSON object.

Also relevant to this https://github.com/TBD54566975/web5-spec/issues/134
@decentralgabe I think we need dedicated docs around JWT thangs, like we did for VCs and DIDs

@nitro-neal do you believe the guidance in the spec is sufficient?
if not, would you like to add text that helps clarify this? and test vectors to match? please add to #168


Skip plashets in ocp4 builds by default; automation will re-enable them

Needs to go along with https://github.com/openshift-eng/art-tools/pull/431

/approve
/lgtm


Zha - bellows - Errors in the logs

I have following zigbee devices:
Nortek USB stick with Zwave and zigbee protocol.
1 Osram lightify RBGW buld
2 sengled tunable white light bulbs.
3 cree connected bulbs
List of errors in the logs and after sometimes not able to control zigbee devices until home assistant is restarted. The light stop to respond to the home assistant and when i verify the logs found following error.
   Resetting
2017-11-08 10:00:43 ERROR (MainThread) [homeassistant.core] Timer got out of sync.  Resetting
2017-11-08 12:03:52 ERROR (MainThread) [aiohttp.access] Error in logging
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/aiohttp/helpers.py", line 500, in log
    for key, value in fmt_info:
  File "/usr/lib/python3.6/site-packages/aiohttp/helpers.py", line 483, in return
    ((key, method(args)) for key, method in self._methods)
  File "/usr/lib/python3.6/site-packages/aiohttp/helpers.py", line 436, in _format_a
    peername = args[3].get_extra_info('peername')
  File "/usr/lib/python3.6/asyncio/sslproto.py", line 306, in get_extra_info
    return self._ssl_protocol._get_extra_info(name, default)
  File "/usr/lib/python3.6/asyncio/sslproto.py", line 547, in _get_extra_info
    return self._transport.get_extra_info(name, default)
AttributeError: 'NoneType' object has no attribute 'get_extra_info'
2017-11-08 12:03:57 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:05:21 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:06:04 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:15:24 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:16:06 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:20:28 ERROR (MainThread) [homeassistant.core] Error doing job: Fatal error on transport TCPTransport (error status in uv_stream_t.read callback)
TimeoutError: [Errno 110] Operation timed out
2017-11-08 12:25:26 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:26:09 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:26:48 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:27:21 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:35:29 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:36:11 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:39:33 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:41:51 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.6/asyncio/tasks.py", line 179, in _step
    result = coro.send(None)
  File "/usr/lib/python3.6/site-packages/homeassistant/core.py", line 1038, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/init.py", line 282, in async_handle_light_service
    yield from light.async_turn_off(**params)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/zha.py", line 118, in async_turn_off
    yield from self._endpoint.on_off.off()
  File "/usr/lib/python3.6/site-packages/bellows/zigbee/application.py", line 286, in request
    v = yield from asyncio.wait_for(reply_fut, timeout)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 356, in wait_for
    raise futures.TimeoutError()
concurrent.futures._base.TimeoutError
2017-11-08 12:42:21 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.6/asyncio/tasks.py", line 181, in _step
    result = coro.throw(exc)
  File "/usr/lib/python3.6/site-packages/homeassistant/core.py", line 1038, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/init.py", line 282, in async_handle_light_service
    yield from light.async_turn_off(**params)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/zha.py", line 118, in async_turn_off
    yield from self._endpoint.on_off.off()
  File "/usr/lib/python3.6/site-packages/bellows/zigbee/application.py", line 284, in request
    v = yield from send_fut
  File "/usr/lib/python3.6/asyncio/futures.py", line 331, in iter
    yield self # This tells Task to wait for completion.
  File "/usr/lib/python3.6/asyncio/tasks.py", line 244, in _wakeup
    future.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 244, in result
    raise self._exception
bellows.zigbee.exceptions.DeliveryError: Message send failure: EmberStatus.DELIVERY_FAILED
2017-11-08 12:45:32 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:46:14 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:48:41 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:55:34 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
2017-11-08 12:55:52 WARNING (SyncWorker_15) [netdisco.ssdp] Found malformed XML at http://<IP_ADDRESS>:9080: status=ok
2017-11-08 12:56:16 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification

Please update the issue and fill out the issue template that was present when you opened the issue. You can read it again here:
https://github.com/home-assistant/home-assistant/blob/dev/.github/ISSUE_TEMPLATE.md

this is identical to #10973 can we maybe merge that information over and use that bug?

@MartinHjelmare  I would add the logs that @sumitrajancse  has provided here to my bug however in my case the logs just stop generating.  The logs in this ticket are very similar to the logs I have seen however once this issue occurs they just stop.  I don't even get an error when I try to control the device, almost as if the component just stops working.  Turning on debugging also does not provide anything in addition.
2017-11-08 12:56:16 WARNING (MainThread) [bellows.zigbee.application] Unexpected message send notification
This is always the last log I see, usually in the middle of the night while I am sleeping when this issue occurs.

Now some of the bulbs stop working, try to add again by resetting but not working.
All_Lights
Log Details (ERROR)
Fri Feb 02 2018 13:06:04 GMT-0400 (SA Western Standard Time)
Error executing service <ServiceCall light.turn_on: entity_id=['light.cree_connected_a19_60w_equivalent_fe03e82d_10']>
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/homeassistant/core.py", line 1010, in _event_to_service_call
yield from service_handler.func(service_call)
File "/usr/lib/python3.6/site-packages/homeassistant/components/light/init.py", line 270, in async_handle_light_service
yield from light.async_turn_on(**params)
File "/usr/lib/python3.6/site-packages/homeassistant/components/light/zha.py", line 118, in async_turn_on
duration
File "/usr/lib/python3.6/site-packages/bellows/zigbee/application.py", line 284, in request
v = yield from send_fut
File "/usr/lib/python3.6/asyncio/futures.py", line 332, in iter
yield self  # This tells Task to wait for completion.
File "/usr/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
future.result()
File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
raise self._exception
bellows.zigbee.exceptions.DeliveryError: Message send failure: EmberStatus.DELIVERY_FAILED

The NCP expects prompt responses, and is not getting them. What you're seeing can be caused by other components blocking the event loop for too long. "Timer got out of sync ..." is a usual tell-tale of this, afaict. This is kinda a dup of zigpy/bellows#37 -- bellows should probably run the time-critical sections on a different thread. That said, Home Assistant components should not block the event loop.
Closing this out to track in zigpy/bellows#37 .


thirdparty Add streamvbyte thirdparty lib

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[nhcb branch] Use single bit to differentiate between optimized bounds and floats

Use one bit to decide what kind of data to read/write. This reduces storage need of floats from 72 bits to 65 bits and makes the integers store in 17 instead of 16.

What is the nhcb branch?  Is it ok that TestQueryStatistics failed in CI?
Doesn't this make a breaking change to the storage on disk?

What is the nhcb branch? Is it ok that TestQueryStatistics failed in CI?
Doesn't this make a breaking change to the storage on disk?

What it is:
https://github.com/prometheus/proposals/blob/main/proposals/2024-01-26_classic-histograms-stored-as-native-histograms.md
EPIC: https://github.com/prometheus/prometheus/issues/13485
It's not a breaking change, doesn't affect histogram chunk with the current schema for exponential histograms.

Generally, I would say it helps a bit if we store things byte-aligned. Of course, it depends on the exact location in the bit stream if things are byte aligned at the position where we store the NHCB bounds. If generally not byte-aligned stuff has been in the stream before anyway, maybe we could also use the varbit (not varint) encoding for integers and be even a bit more compact.
(I preferred varint previously because I somehow assumed we are still byte-aligned, but that might actually not be true. Needs verification.)

OK, I checked.
We are definitely not byte-aligned at the time putHistogramChunkLayoutCustomBounds is called.
So I would like to modify the algorithm once again:

If you get a positive integer number (or zero) after multiplying with 1000, write a 1 bit and then use putVarbitUint to write that integer.
Otherwise, do what's done in this PR (write a 0 bit and the 64 bit of the float64).

Actually, looking at how varbit is implemented there, maybe this optimisation could work? https://github.com/zenador/prometheus/commit/1f97f359f88a0674940563970984abc1f8a4b6fe
And once the implementation is finalised, we'd need to update the doc comments.

Actually, looking at how varbit is implemented there, maybe this optimisation could work? zenador@1f97f35

Yes, this should work.

Actually, looking at how varbit is implemented there, maybe this optimisation could work? zenador@1f97f35

Yes, this should work.

Picked @zenador optimization, nice find!

LGTM


libQt5Core.so.5 patching randomly breaks in TravisCI

Current hypothesis is if patchelf is being run on libQt5Core then it breaks
(previously there was a bug related to race between patchelf and pathQtCore() function which overwrote one another, but now builds reproducibly fail)

Possibly caused by https://github.com/NixOS/patchelf/issues/124

Does not repro if using Debian's patchelf


Make no-extraneous-deps lint only dependencies that can be resolved

no-extraneous-deps assumes, that every package that lives in a node_modules folder or cannot be resolved is an external package. This happens because of that line.
If project uses aliasing, or transforms imports, this assumption is wrong, as they may not be resolvable by import plugin, but also, they should not be defined in package.json.
Changing isExternalPath will make any ordering lints unstable (order may change depending if you ran npm install or not). My proposal, is that no-extraneous-deps ignores packages that cannot be resolved, as otherwise it's impossible to test whether they live in node_modules or somewhere else.
In #903, we talked about using import/ignore setting, but I think it doesn't make sense, as it's mostly used to ignore imports unknown to the plugin, like .css files. But still, you may import a css file from a dependency, and this rule should check that.
Both with ignore and without are parts of this PR - I'll squash them once we decide.

I like ignoring unresolved to start. If I understand correctly, that is less of a change than also considering the import/ignore setting and sounds like a considerable ergonomic improvement, especially considering the purpose and spirit of this rule is to remind you to put things in your package.json if you've installed them to use them.

BTW: stellar PR! ⭐⭐⭐⭐⭐ I really appreciate the detail!

@benmosher yes, that's correct. I've came to that conclusion once I actually did the ignores - that's why I left them, but just ignoring unresolved is more sound here AND simpler, a win-win in my eyes :D

If they can't be resolved, doesn't that mean this plugin can't check across imports to them?
If you're going to use aliases or transforms, I want errors until I've provided a resolver to eslint-plugin-import - this seems like it erases useful errors. At the very least, I'd expect it to go under an option and not be on by default.

@ljharb you actually will get errors - for unresolved dependencies - another linter. Here I'm trying to fix the case, where for unresolved dependencies you're told to add them to package.json, which is not correct.

@panrafal ahhh ok so you're saying that this specific rule shouldn't be checking aliases - that makes sense.
Should it be ensuring that the thing that the alias resolves to, though, is either a local file or in package.json?

@ljharb if you've aliased something, I think it's fine to just decide it's out of scope for this rule. This rule is just supposed to be a gentle reminder that you may have installed a dependency locally without properly declaring it in package.json.
Once a dependency is more complicated than that, I think it's fine if it goes off the radar for this rule.

@ljharb @benmosher cool :) do you want me to squash it/rebase it, or you will do it through GitHub when merging?

Doing it through github sadly doesn't actually update your PR branch; it's definitely ideal if you do it; but if not, one of us can do it for you on the command line prior to merging :-)

Coverage increased (+0.006%) to 96.088% when pulling e80a98941c044891555dd50a306792a017febf49 on panrafal:feature/no-extraneous-deps-ignore into ee515817b8ecb7d7566e019bebe6c666fc6414c6 on benmosher:master.

Coverage increased (+0.006%) to 96.088% when pulling e80a98941c044891555dd50a306792a017febf49 on panrafal:feature/no-extraneous-deps-ignore into ee515817b8ecb7d7566e019bebe6c666fc6414c6 on benmosher:master.

Coverage increased (+0.006%) to 96.088% when pulling e80a98941c044891555dd50a306792a017febf49 on panrafal:feature/no-extraneous-deps-ignore into ee515817b8ecb7d7566e019bebe6c666fc6414c6 on benmosher:master.

@ljharb Done! In the meantime, I've added one additional rule: #966

Coverage increased (+0.006%) to 96.088% when pulling ae3731874d6e835904c97d5b05867e5b5056f489 on panrafal:feature/no-extraneous-deps-ignore into ee515817b8ecb7d7566e019bebe6c666fc6414c6 on benmosher:master.


Avoid database access loading metadata

To fix #553
Move datetime type field from database type detection to service configuration

Looks good!

Thank you


Install script does not install all dependencies

On Ubuntu server for Raspberry Pi, two additional packages are needed. Here is the patch:
diff --git a/install.sh b/install.sh
index c553e2e..b4d4b24 100755
--- a/install.sh
+++ b/install.sh
@@ -4,7 +4,7 @@ systemctl -q is-active zram-config  && { echo "ERROR: zram-config service is sti
 [ "$(id -u)" -eq 0 ] || { echo "You need to be ROOT (sudo can be used)"; exit 1; }
 [ -d /usr/local/bin/zram-config ] && { echo "zram-config is already installed, uninstall first"; exit 1; }

-apt-get -y install libattr1-dev
+apt-get -y install libattr1-dev make gcc
 if grep -q "buster" /etc/os-release
 then
        git clone https://github.com/StuartIanNaylor/overlayfs-tools -b Arch

If you check the branches there is an arch branch with the old


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 46s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
checkstyle
0m 12s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 26s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 56s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

28m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4564/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4564

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux b3930b84ef7a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4564/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

We have discussed this before. The IA.Private annotations on the exception classes usually means you should not create a new instance for it, but you are free to catch it.

Ok, hadn't seen that discussion. Will close this, thanks

https://lists.apache.org/thread/kqo9pf3bxlyd7nljm4994l38hk846p76


Consider checking default ANDROID_HOME locations

e.g. on Mac, if you have the default Android Tools installed (Android Studio) your sdk is:
ANDROID_HOME=~/Library/Android/sdk/
http://stackoverflow.com/questions/26739114/android-studio-sdk-location
Even if we don't default to this (which I think we should consider) we could make the flutter tool offer this.

We do this now.


WPF - Customize default filename for 'Save to Image' right-click action.

ScottPlot Version: 4.1.16
Operating System: Windows 10
Application Type: WPF
Question:  How to customize the default filename provided on a plot when a user right-clicks and selects 'Save Image'?  Currently it defaults to 'ScottPlot.png', but I would like to customize this to reflect the specific chart and data range being exported (e.g. 'User Statistics - fromDate to toDate.png').
It is set through these lines of code, and does not appear to be externally accessible:
https://github.com/ScottPlot/ScottPlot/blob/master/src/controls/ScottPlot.WPF/WpfPlot.xaml.cs#L237-L250

Alternatively -- is there a standard method to disable the default right-click context menu so that I might implement my own? (certainly not ideal, but I'll take what I can get).
I'm inferring I'll have to replace this event handler through code-behind, and point towards my own event handler implementation ( https://github.com/ScottPlot/ScottPlot/blob/master/src/controls/ScottPlot.WPF/WpfPlot.xaml.cs#L40 ).  Is this correct?
Thanks in advance....

Hi, This is how I implemented a custom right click menu. See if this helps,
    private void Graph_RightClick_Menu()
    {
        Graph.RightClicked -= Graph.DefaultRightClickEvent;
        Graph.RightClicked += Graph_RightClick_Menu_Options;
    }

    private void Graph_RightClick_Menu_Options(object sender, EventArgs e)
    {
        MenuItem addSaveImageMenuItem = new MenuItem() { Header = "Save Image" };
        addSaveImageMenuItem.Click += Right_ClickSave_Graph_Image;
        MenuItem addCopyImageMenuItem = new MenuItem() { Header = "Copy Image" };
        addCopyImageMenuItem.Click += RightClick_Copy_Graph_Image;

        ContextMenu rightClickMenu = new ContextMenu();
        rightClickMenu.Items.Add(addSaveImageMenuItem);
        rightClickMenu.Items.Add(addCopyImageMenuItem);
        rightClickMenu.IsOpen = true;
    }

    private void Right_ClickSave_Graph_Image(object sender, EventArgs e)
    {
        Save_Graph_to_Image();
    }

    private void Save_Graph_to_Image()
    {
        try
        {
            var Save_Image_Window = new SaveFileDialog
            {
                FileName = "Graph Plot_" + Measurement_Unit + "_" + DateTime.Now.ToString("yyyy-MM-dd h-mm-ss tt") + ".png",
                Filter = "PNG Files (*.png)|*.png;*.png" +
                  "|JPG Files (*.jpg, *.jpeg)|*.jpg;*.jpeg" +
                  "|BMP Files (*.bmp)|*.bmp;*.bmp" +
                  "|All files (*.*)|*.*"
            };

            if (Save_Image_Window.ShowDialog() is true)
            {
                Graph.Plot.SaveFig(Save_Image_Window.FileName);
            }
        }
        catch (Exception Ex)
        {
            Insert_Log("Could not save Graph Plot Image.", 1);
            Insert_Log(Ex.Message, 1);
        }
    }

    private void RightClick_Copy_Graph_Image(object sender, RoutedEventArgs e)
    {
        System.Drawing.Bitmap Graph_Image = Graph.Plot.Render(); ;

        MemoryStream Image_Memory = new MemoryStream();
        Graph_Image.Save(Image_Memory, System.Drawing.Imaging.ImageFormat.Png);

        BitmapImage Graph_Bitmap = new BitmapImage();
        Graph_Bitmap.BeginInit();
        Graph_Bitmap.StreamSource = new MemoryStream(Image_Memory.ToArray());
        Graph_Bitmap.EndInit();

        Clipboard.SetImage(Graph_Bitmap);

        Graph_Image.Dispose();
        Image_Memory.Dispose();
        Graph_Bitmap.Freeze();

    }


feat: add repository and commit_id parameters

This MR adds two params - repository and commit_id of the component. Example of the action:
https://github.com/magicarm22/example_component/actions/runs/7330486526/job/19962669349
It wrote an error because it is an old version of idf-component-manager. Command looks good:
compote component upload --allow-existing --namespace=dmitry --project-dir=/github/workspace/. --name=test_uploading_component --repository=git://github.com/magicarm22/example_component.git --commit-sha=c3ab451ac4294038efeda32404a6e9f9466de8da

LGTM

PTAL
Action with empty repo and commit_sha. We don't send this information to the registry - https://github.com/magicarm22/example_component/actions/runs/7959023469/job/21725123036. Result: https://components-staging.espressif.com/components/dmitry/test_uploading_component/versions/1.0.6?language=en
Action with default repo and commit_sha (current working repo and sha) - https://github.com/magicarm22/example_component/actions/runs/7959000791/job/21725047991. Result: https://components-staging.espressif.com/components/dmitry/test_uploading_component/versions/1.0.5?language=en
Action with components from another repository: https://github.com/magicarm22/example_component/actions/runs/7959133292/job/21725489344. Result: https://components-staging.espressif.com/components/dmitry/comp_a and https://components-staging.espressif.com/components/dmitry/comp_c


Eating all CPU and memory

When I try to process the code below with elm-make, then it eats all my memory and it uses all my CPU's at 100%. The same thing happens on http://elm-lang.org/try.
Version: elm-make 0.18 (Elm Platform 0.18.0)
Line 7 (type annotation of string) is the problem. Commenting this line out solves the problem. I am aware of the fact that the type annotation is wrong, but it should not eat all my resources. It should report a compilation error.
import Html exposing (text)

ctor: a -> (a -> List String -> Result String b) -> List String -> Result String b
ctor ctor next list =
  next ctor list

string: (a -> List String -> Result String a) -> (String -> a) -> List String -> Result String a
string next f list =
  case list of
    [] ->
      Err "Not enough arguments"
    head::tail ->
      next (f head) tail

end: a -> List String -> Result String a
end result list =
  case list of
    [] -> Ok result
    _ -> Err "Too many arguments"

type MyType1 = MyCon1 String String
type MyType2 = MyCon2 String String String

chain1: List String -> Result String MyType1
chain1 = ctor MyCon1 <| string <| string <| end
result1 = chain1 ["A", "B"]

chain2: List String -> Result String MyType2
chain2 = ctor MyCon2 <| string <| string <| string <| end
result2 = chain2 ["A", "B", "C"]

main = text (toString1 result1 ++ toString2 result2)

toString1 result = case result of
  Err err -> "Error: " ++ err
  Ok (MyCon1 a b) -> a ++ b

toString2 result = case result of
  Err err -> "Error: " ++ err
  Ok (MyCon2 a b c) -> a ++ b ++ c

In my development build, I get the following error immediately from this code:
-- SHADOWING ---------------------------------------------------------- temp.elm

These variables cannot have the same name:

10| ctor ctor next list =
    ^^^^ ^^^^
Think of a more helpful name for one of them and you should be all set!

Note: Linters advise against shadowing, so Elm makes “best practices” the
default. Read <https://elm-lang.org/hints/0.19.0/shadowing> for more details on
this choice.

My suspicion is that some sort of infinite type was created before shadowing was restricted. Not sure though. Anyway, thank you for the report!


Improve recognizing variable references. Add tests

This fixes a bug in #34 and adds in more tests. Let me know if you think of any more tests we should add in.
If you're ok with modifying the environment for the tests, then we could add in a test to make sure that variables like FOO="this has    spaces" get treated properly when referenced.

Looks great! 2 points noted, and then I think we're good.
Yeah, you can modify the environment. Worst case, you can remove the env variable when done in the after clause.

@dthree As I was refactoring the code, I came up with the idea for something like #38. Since it's a pretty different direction, I decided to put it in a different PR and leave this open for now. I can probably refactor this to accommodate something more similar to what we were discussing, if you'd rather go with this route instead of the direction in #38.

Agreed.


Generate js ignores automatically

This follows on from https://github.com/espruino/BangleApps/pull/3390#discussion_r1590348186 and allows us to automatically ignore any typescript-generated files

@atjn am I doing something wrong here? eslint docs say to specify a top-level ignores, but we get:
ESLint: 8.57.0

Error: ESLint configuration in apps/.eslintrc.js is invalid:
	- Unexpected top-level property "ignores".

Lint-only change: linting passes -> merging


Not redirecting to other page after successful login

Hello, after successful login page is not redirecting to root view controller.

let api = Instagram.shared
// Login
api.login(from:self.navigationController!, withScopes: [.publicContent], success: {
// Do your stuff here ...
}, failure: { error in
print(error.localizedDescription)
})
This Is the code am using for login.

I am using the same code and it is working for me, are you redirected to different ViewController? if so, make sure that the desired viewController is also the root

Same problem on my side. I guess it’s related to changes that were done on Instagram API

I just tested it and had no problem. Are you guys unchecking the "Disable implicit OAuth" option in the Instagram client? (https://github.com/AnderGoig/SwiftInstagram/wiki/Authentication#swiftinstagram-authentication)

FWIW, I'm seeing this behavior if I attempt to use the "Continue with Facebook" option on the login screen. If I'm logging in with a username/password, it behaves as expected.

@AnderGoig  I have the same issue like @panchsheelmind
I really have no idea what I am doing wrong, but its simply loading instagram first screen...
"Disable implicit OAuth" is disabled, but I have no idea why I need redirect URI . I just put simply put https://thispic.io/ but no idea if it affects.
I entered in sdk and printed url, then opened in browser, and it redirected succesffully to:
http://www.thispic.io/#access_token=7276677373.b4ceae8.e33aa2d3e0d0451c83a8391896d93e71
which is fine, I think. But in app, its not working.
Any idea ?
Really appreciate your help.

Maybe this will help

Any update on this?


update USI engine management

説明 / Description
https://github.com/sunfish-shogi/electron-shogi/issues/501
連続対局や CSA サーバーへの再接続をした際に、 USI エンジンのプロセスをキープするよう改善します。
チェックリスト / Checklist

MUST

[ ] npm test passed
[ ] npm run lint was applied without warnings
[ ] changes of /docs/webapp not included (except release branch)
[ ] console.log not included (except script file)

RECOMMENDED (it depends on what you change)

[ ] unit test added/updated
[ ] i18n

Codecov Report
Patch coverage: 61.11% and project coverage change: -0.02 :warning:

Comparison is base (92847f5) 70.49% compared to head (55699bf) 70.47%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   70.49%   70.47%   -0.02%
==========================================
  Files          75       75
  Lines       15436    15487      +51
  Branches     1974     1982       +8
==========================================
+ Hits        10881    10915      +34
- Misses       2609     2618       +9
- Partials     1946     1954       +8

Impacted Files
Coverage Δ

src/renderer/store/research.ts
58.91% <0.00%> (-0.47%)
:arrow_down:

src/renderer/players/human.ts
42.25% <50.00%> (+0.46%)
:arrow_up:

src/renderer/store/game.ts
66.39% <58.00%> (-0.11%)
:arrow_down:

src/renderer/store/csa.ts
71.75% <63.41%> (+0.01%)
:arrow_up:

src/renderer/ipc/web.ts
55.79% <66.66%> (+0.11%)
:arrow_up:

src/renderer/players/usi.ts
49.47% <75.00%> (+0.27%)
:arrow_up:

src/renderer/ipc/api.ts
82.68% <80.00%> (-0.05%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Packet Format Not Found error - Crashes Homebridge

Noticed this morning that none of my HOOBS-related items were working and the log shows an unknown packet format error.
11/8/2020, 7:09:07 PM Error: [packet/packer.js] Packet format not found: 7b226d6163223a2234433a35353a43433a31393a42383a4546222c226273736964223a2237343a41433a42393a34373a32353a4446222c226368616e6e656c223a312c226970223a223139322e3136382e3135372e313634222c2273736964223a227468657374726f6d732e6f7267222c2272737369223a2d34312c2272656d6f74655f7465726d696e616c5f706f7274223a323030302c2274696d65223a313630343839313334373031312c2276657273696f6e223a22454d5745524b2d4a425f315f312d312e342e302e32372c20323032302d30352d32395432333a30363a32385a2c205a656e7472694f532d575a2d332e362e342e30222c2275756964223a2230363431333034313030303030303030343930303232303030463531333733313334333433323333227d
    at loadPacketStructure (/home/hoobs/.hoobs/node_modules/xbox-smartglass-core-node/src/packet/packer.js:22:19)
    at module.exports (/home/hoobs/.hoobs/node_modules/xbox-smartglass-core-node/src/packet/packer.js:35:21)
    at EventEmitter.<anonymous> (/home/hoobs/.hoobs/node_modules/xbox-smartglass-core-node/src/events.js:15:19)
    at EventEmitter.emit (events.js:310:20)
    at Object.<anonymous> (/home/hoobs/.hoobs/node_modules/xbox-smartglass-core-node/src/smartglass.js:324:30)
    at Socket.emit (events.js:310:20)
    at UDP.onMessage [as onmessage] (dgram.js:924:8)
11/8/2020, 7:09:07 PM Got SIGTERM, shutting down Bridge...

This is Xbox Tv plugin 1.2.39, HOOBS 3.2.9, Node 12.16.3.

Its hoobs related problem.

@grzegorz914 looks like it actually may be an issue with the OpenXbox/xbox-smartglass-core-node repo. I've logged an issue there: https://github.com/OpenXbox/xbox-smartglass-core-node/issues/34

@grzegorz914 FYI this is not a HOOBS issue, looks like it was an issue with xbox-smartglass-core-node. The fix will be in release 0.6.7 (not yet released) but it's available in this commit: https://github.com/OpenXbox/xbox-smartglass-core-node/commit/f88751d7412c38d4eecbe27ca8ff47764752cddc

OK,
I have not observed this error on my site, I will update the core api as soon as will be released.

Just wanted to let you know that xbox-smartglass-core-node is updated to 0.6.7 that should fix this problem.

OK, thanks


Don't use "import * as React" to avoid deprecation warnings

I never used Flow before, so I have no idea whether this is correct or not 😃
I just started a trial and error game until the warnings disappeared and no errors were spilled by npm run test:flow
Fixes #3385

Codecov Report

Merging #3387 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3387   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          68      68
  Lines        1525    1525
======================================
  Hits         1525    1525

Impacted Files
Coverage Δ

src/util/getDisplayName.js
100% <100%> (ø)
:arrow_up:

src/createReduxForm.js
100% <100%> (ø)
:arrow_up:

src/createFormValues.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b49d43...00bfada. Read the comment docs.

is this release already in 7.0.4?

No, it isn't, @piuccio. The problem this PR fixes was introduced in 7.0.4 😐

@erikras if at all possible it would be awesome to cut a tiny release with just this fix ... this is blowing up all test runs with so much noise :/
Thanks for the fix @gustavohenke !

***FWIW anyone else that arrives here, I pinned to 7.0.3 and that solved it for me for now.

Should be updated in a new version asap.
I spent one afternoon on this...

Published in v7.1.0.


Strong mode should infer Null for generic types inside constant expressions

If an inference for a constant expression needs to match a generic type, strong mode should infer Null (or later Nothing).
For example:
List<T> foo<T>() {
  return const [];
}

I think @eernstg was going to follow up on this, but just to mention:
My guess is that the right approach (ignoring type bounds) is to infer a type as usual, and then replace all covariant occurrences with Null and contravariant occurrences with dynamic or Object.  This yields a type which is a subtype of the precise inferred type.
I haven't thought through whether bounds add anything interesting to the problem or not.

That makes sense for cases where the T isn't the actual type. E.g.:
List<T Function(T Function(T))> foo<T>() => const [];

In this case, the inference wants a List<Something> that is a subtype (and therefore assignable) to List<T Function(T Function(T))> for any T (and T isn't even bounded here, so it's "easy").
Obviously List<Null> is a solution, but less precise than possible since List<Null Function(Object Function(Null))> is also one. I guess we want the greatest lower bound that can be reasonably found. Or, is that really important? You can't use the class at runtime anyway, and you can assign it to any static type you care about, so does it matter that the runtime type isn't precise?
If we do infer a preciser type, with a bound on T, we'd use the bound instead of Object. With an F-bound, we'll ... do whatever we do for F-bounds (fail, default to Object or introduce the anonymous infinite type) instead of Object. The contravariant positions are still satisfied by Null.

I believe that would be the way to go.
Just double checking, it is possible to create a constant expression where we would like to have a type argument inferred, where we need to match a formal type parameter of an enclosing declaration (such that we must find a constant value that fits with all possible actual type arguments), and where the inferred type argument occurs contravariantly:
typedef void Foo<T>(T t);
void foo<T>(T t) {}
void bar<T>([Foo<T> arg = foo]) {}

main() {
  bar<int>();
}

For the default value foo of arg in the declaration of bar, we need to infer foo<Object> or foo<dynamic> rather than foo<Null> (at some point, foo<Nothing>), ignoring that we don't support these generic instantiation tear-offs yet.
Bounds do create the usual problems. We would have a rule like this: 'for a formal type parameter which is used in a contravariant position, replace it by the least upper bound of all possible actual type arguments', as well as the (unproblematic) 'for a formal type parameter which is used in a covariant position, replace it by the Null (or Nothing)':
class C<S extends C<S>> {}
class C1 extends C<C1> {}

typedef void Foo<T>(T t);
void foo<U extends C<U>>(U t) {}
void bar<V extends C<V>>([Foo<V> arg = foo]) {}

main() {
  bar<C1>();
}

We cannot use foo<Object> nor foo<dynamic> because the given type arguments do not satisfy the bounds (and even though we may contemplate using malbounded type annotations, this is a malbounded runtime entity, so that's still just plain wrong ;-), and we cannot express the least upper bound of all the possible type arguments U satisfying U extends C<U>.
So I'd give the same recommendation that I usually do for instantiate-to-bound: Refuse to solve this problem, i.e., reject that default value at compile time.
Adjusting the title to catch up with the developments so far.

Ah, I forgot to reload so I didn't see your response first, Lasse.
Just for completeness, though, I could add that we do have cases where inference con't provide a sufficiently "universal" type:
typedef T Foo<T>(T t);
T foo<T>(T t) => null;
void bar<T>([Foo<T> arg = foo]) {}

main() {
  bar<int>();
}

In this case neither a top nor a bottom type will work (because we have both covariance and contravariance), so there will of course be some cases where we must declare that the inference failed and the program is rejected.

I don't think we've committed to treating instantiated tearoffs of generic functions (foo<T> in @eernstg's example above) as const objects?  Or did we decide that was fine?  If so, then yes, there are some examples we can't find a sound approximation for and will have to error out.  I don't expect that to be a common issue.
The point that @lrhn makes about simply using Null as the type argument to the outermost type constructor and not worrying about getting the most precise runtime type seems like a good one.  I think there's probably a reasonable definition that can be made around this.  I don't immediately see any benefit to having a more precise type offhand.

Right, const objects are specified syntactically, and the supported syntactic forms do not include generic tear-offs like foo<T>.
We could (1) add syntactic support for generic tear-offs, and add this form to the list of constant expressions, with constraints as needed (e.g., can't use formal type parameters in scope); and we could (2) add support for generic tear-offs via inferred type arguments (such that we can have them semantically for expressions like foo), without adding syntactic support (foo<T>).
The things I said were intended to be compatible with (2), but I needed a hypothetical (1) in order to explain what I meant; finally, we could of course have both (1) and (2).

On Fri, Feb 10, 2017 at 12:46 PM, Erik Ernst<EMAIL_ADDRESS>wrote:

Right, const objects are specified syntactically, and the supported
syntactic forms do not include generic tear-offs like foo.

I believe we already allow instantiation at tear-off. Like:
T id(T x) => x;
int Function(int) intId = id;  // id inferred and instantiated as id
At least the strong-mode analyzer in dartpad considers intId to require an
int argument, and accepts the assignment from id, which it shouldn't for
any type parameter different from int. (OK, I use a typedef, not
Function, because dartpad doesn't have the Function syntax yet :)
I do think it is something of a problem that we don't allow you to write
the same thing explicitly. That makes it a case where inference does
something that you can't do explicitly. (Another case is inference of
return type on non-"=>" function expressions).
We could (1) add syntactic support for generic tear-offs, and add this form

to the list of constant expressions, with constraints as needed (e.g.,
can't use formal type parameters in scope); and we could (2) add support
for generic tear-offs via inferred type arguments (such that we can have
them semantically for expressions like foo), without adding syntactic
support (foo).

I think we should add the syntax in any case.
The question of whether it is a const expression is a separate concern. It
doesn't have to be, even if we have the syntax.
I think our conclusion is that it's possible. In a const context, or with
a constant type parameter, id<String> can be treated as constant and
canonicalized - without id<T> - T a type variable - having to be
canonicalized to the same thing, even if T happens to be String.
I think it would be a good idea to allow id<int> as a compile-time
constant. It is a likely candidate for a default parameter or similar uses.
I also think that it's not essential and is something we can add later
without breaking anything (few people should depend on the non-identity of
function values).
(And as a side note, exposing the identity of objects sure does break a lot
of nice optimizations for objects that the compiler knows to be immutable).
:)

The things I said were intended to be compatible with (2), but I needed a
hypothetical (1) in order to explain what I meant; finally, we could of
course have both (1) and (2).

I believe we have (2) already. I think we should have (1), either constant
capable or not.

/L
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

See comment on this bug here: https://github.com/dart-lang/dart-lang-evolution/issues/111  for the last state of the discussion around partial instantiations, and the inference thereof. There is an open issue against strong mode analyzer to restrict inference to only inferring partial instantiations on tearoffs (not on function expressions).


move test from mathbot

Overview
What’s going on in this PR?
Changelog
Related Pull Requests

Codecov Report

Merging #60 (2a66ee0) into master (fa609cb) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   43.13%   43.35%   +0.21%
==========================================
  Files          48       48
  Lines         459      459
  Branches       15       15
==========================================
+ Hits          198      199       +1
+ Misses        261      260       -1

Impacted Files
Coverage Δ

.../com/mathbot/pay/btcpayserver/ChargeInfoData.scala
100.00% <0.00%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa609cb...2a66ee0. Read the comment docs.


Zoom

Hello everyone!
I love this plugin and I would like to thank anyone who contributed to the project.
Has anyone experimented with something I could work on for the zoom feature?
Thank you

Hi,
I have the same problem as you.
Have you found a solution?

Actually no, but it's an important feature but I can't get it to work... If you find any alternative solution please let me know.

There is a Cordova Plugin which is like this one and has zoom.
See also #99
Last time (in march 2021) I tested, the to-back feature does not work correctly with capacitor.

is the height and width if you erase that in yhe CameraPreviewOptions the camera should look fine.

Hi everyone, pinch and zoom is now available in version 2.1.0 released today. Good luck using it!


Extend Scalar sub-type of Index to the iter() method

[X] Closes #365
[X] Tests added: Please use assert_type() to assert the type of any return value

As mentioned in that issue, I am a little bit confused about what the type of a column or index label is.....feels like in some places we decided it is a Hashable and in other places we decided it's a Scalar. But just to stay consistent with the way this was already annotated, I continued to use Scalar.

So it appears NDArray is being treated as a Hashable, which creates overlapping overloads per MyPy. I don't see any way to fix this currently.
So I took a different approach. Went back to annotating using Scalar, but then augmenting that Union with a Tuple[Scalar, ...]. I added some tests to illustrate some of the edge cases. There is one old test that is failing, and not sure what the best course of action there is, I added a note.


error linking uWSGI

I am trying to install uwsgi, which is part of my custom python package and before that I am installing openssl as mentioned in https://github.com/mcepl/M2Crypto/blob/master/INSTALL.rst#pre-requisites with Docker. But I keep receiving linking error during the compilation of uwsgi.
00:17:14     subscription.c:(.text+0x9da): undefined reference to EVP_MD_CTX_free'
00:17:14     subscription.c:(.text+0xa0e): undefined reference to EVP_MD_CTX_free'
00:17:14     core/subscription.o: In function subscription_new_sign_ctx':
00:17:14     subscription.c:(.text+0x147d): undefined reference to EVP_MD_CTX_new'
00:17:14     subscription.c:(.text+0x14fe): undefined reference to EVP_MD_CTX_free'
00:17:14     core/ssl.o: In function uwsgi_ssl_init':
00:17:14     ssl.c:(.text+0xb9): undefined reference to OPENSSL_init_ssl'
00:17:14     ssl.c:(.text+0xc5): undefined reference to OPENSSL_init_ssl'
00:17:14     ssl.c:(.text+0xd1): undefined reference to OPENSSL_init_crypto'
00:17:14     core/ssl.o: In function uwsgi_ssl_new_server_context':
00:17:14     ssl.c:(.text+0x21f): undefined reference to TLS_server_method'
00:17:14     ssl.c:(.text+0x304): undefined reference to SSL_CTX_set_options'
00:17:14     ssl.c:(.text+0x340): undefined reference to SSL_CTX_set_options'
00:17:14     ssl.c:(.text+0x51e): undefined reference to SSL_CTX_set_options'
00:17:14     core/ssl.o: In function uwsgi_rsa_sign':
00:17:14     ssl.c:(.text+0x80c): undefined reference to EVP_MD_CTX_new'
00:17:14     ssl.c:(.text+0x892): undefined reference to EVP_MD_CTX_free'
00:17:14     ssl.c:(.text+0x9c5): undefined reference to EVP_MD_CTX_free'
00:17:14     core/ssl.o: In function uwsgi_sni_cb':
00:17:14     ssl.c:(.text+0xeeb): undefined reference to SSL_CTX_get_options'
00:17:14     ssl.c:(.text+0xef6): undefined reference to SSL_set_options'
00:17:14     collect2: error: ld returned 1 exit status
00:17:14     *** error linking uWSGI ***

This is what my Dockerfile looks like
RUN wget https://www.openssl.org/source/openssl-1.1.1.tar.gz -O /tmp/openssl-1.1.1.tar.gz && \
    tar xvf /tmp/openssl-1.1.1.tar.gz && \
    cd openssl-1.1.1 && \
    ./config -Wl,--enable-new-dtags,-rpath,'$(LIBRPATH)' &&\
    make && make install
# install third party dependencies
RUN apt-get update && apt-get -y install libssl-dev libffi-dev \
    build-essential python3-dev python-dev swig libyajl-dev \
    libjansson4
RUN pip install --find-links file:///src/build/python_pkgs \
                /src/build/python_pkgs/service-0.0.1.tar.gz

It looks like you need to tell the uwsgi build where openssl is installed.
This is not an openssl bug.


Mediaplayer selector tries to activate old skins

All the LeftMouseDown actions still reference the old Normal.ini, Spotify.ini, and GPMDP.ini. I believe these references can just be removed.

Fixed with commit 1b152e43884b3dcf1fdb660c78da8628384e91a5.


This can be overridden with a local annotation, but that annotation must include a comment explaining correctness

This PR is meant as a draft to discuss these rules, and decide if they are too onerous or not onerous enough.
For now, only unwrap is tracked/annotated, if we like these rules this PR will expand.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Expanded to all core, and added cargo clippy as a workflow target.


Is there any demo code for PWM and what's the base address of it ?

Hi
Is there any demo code for the pwm in Earl Grey?
and, I can't find the base address of pwm in the link below.
https://docs.opentitan.org/hw/top_earlgrey/doc/
Could you please provide me this information?
Thanks a lot.

There's neither a driver nor demo code at the moment for PWM.
You can find the base address of all modules e.g. in hw/top_earlgrey/sw/autogen/top_earlgrey.h:
#define TOP_EARLGREY_PWM_AON_BASE_ADDR 0x40450000u

@martin-lueker
do you guys have any dv code that could be used as a reference?

Hi @tjaychen, @nicolast0604,
It's all SystemVerilog right now, there no any c-examples yet.

i think that would be helpful too
On Thu, Oct 21, 2021 at 11:02 AM Martin Lueker-Boden <
@.***> wrote:

Hi @tjaychen https://github.com/tjaychen, @nicolast0604
https://github.com/nicolast0604,
It's all SystemVerilog right now, there no c-examples yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/8796#issuecomment-948872809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSXZ4H4ZBUOWKE4TOODUIBITBANCNFSM5GNROV6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

PWM now has a DIF and there are Earlgrey top-level tests using PWM, e.g., sleep_pwm_pulses_test.c. That could serve as demo code (although it's test code, so it does not necessarily follow best principles for using PWM).
I'm thus closing this issue. If anyone has objections, please re-open it.


[develop] Bindings - add runtime table cfg to prover index creation

See https://github.com/MinaProtocol/mina/pull/13549 for more explanation.
Related to https://github.com/o1-labs/snarkyjs/pull/1020.
Built on top of #78
Also did:
git merge origin/fix-snarkyjs-berkeley
git checkout HEAD compiled MINA_COMMIT
npm run bindings

The result of npm run bindings has been commited in the latest commit.

With the latest changes,  I have runtime errors with null pointers passed to rust. Trying to fix it.
I have opened multiple other PR which are merged in this branch as it is overlapping with the changes here and good to have here.

This seems to include unrelated changes (deleting tests etc.). Please revert

Done

https://github.com/o1-labs/snarkyjs-bindings/pull/104 (and the counterpart https://github.com/o1-labs/snarkyjs-bindings/pull/105) should be merged first to solve the conflict.


changed rounding behavior of float to int color conversion from floor() to round()

changed rounding behavior of float to int color conversion from floor() to round()
This is huge especially for the low values because human eyes distinguish darker colors much better.

excellent, thanks!


Use EMOS coefficients cube

Addresses #855
Description
This PR contains changes required to use the coefficients cube added in #850. This also builds on top of #856, which removed redundant functionality that is not required for usage in IMPROVER. The main aim of this PR is to use the coefficients cube within both the estimation of the coefficients and the application of the coefficients. Both of these edits are required in this PR to support the pre-existing EnsembleCalibration plugin and ensemble-calibration CLI, which chain together the estimation of the coefficients and application of the coefficients into one call. However, with a view to real-time running, we would like to separate the estimation and application of the coefficients, so that the coefficients can be estimated ahead of time with the application of the coefficients being a relatively quick process.
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

Suggested change in process method of GeneratePercentilesFromProbabilities line 554:
        if not isinstance(forecast_probabilities, iris.cube.Cube):
            forecast_probabilities = forecast_probabilities.concatenate_cubes()

All unit tests and CLI tests pass with this change. It stops the var names being lost unnecessarily.


flow: add a way to fill builder type description

Set type description to use, input/output ports and options
are automatically set.

-1

I'll send a v2, thanks for the comments


Add global cache for downloaded file

Add cache for downloaded file so that no need to download file every time when building script in development.
Cache crate reference: https://crates.io/crates/cached-path.
Ps: I was doing the same crate earlier today and I just found you published this:), my build script for reference:
use cached_path::{Cache, Options};
use std::{env, path::PathBuf};
pub fn bundle_mach_dxc() {
    println!("cargo:rerun-if-changed=mach_dxc.rs");
    println!("cargo:rerun-if-changed=mach_dxc.h");
    generate_bindings();
    link_lib();
}

fn generate_bindings() {
    let bindings = bindgen::Builder::default()
        // The input header we would like to generate
        // bindings for.
        .header("mach_dxc.h")
        // Finish the builder and generate the bindings.
        .generate()
        // Unwrap the Result and panic on failure.
        .expect("Unable to generate bindings");

    // Write the bindings to the bindings.rs file.
    let out_path = PathBuf::from("src/dx12/mach_dxc/bindings.rs");
    bindings
        .write_to_file(out_path)
        .expect("Couldn't write bindings!");
}

fn link_lib() {
    let path = download_if_no_cache();
    println!("cargo:rustc-link-lib=static=machdxcompiler");
    println!("cargo:rustc-link-search=native={:?}", path.display());
}

fn download_if_no_cache() -> PathBuf {
    let project_name = "dxcompiler";
    let project_url = format!("https://github.com/hexops/mach-{project_name}");
    let latest_binary_release = "2024.10.16+da605cf.1";

    let arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap();
    let os = env::var("CARGO_CFG_TARGET_OS").unwrap();
    let abi = env::var("CARGO_CFG_TARGET_ENV").unwrap_or_else(|_| "none".to_owned());
    let triple = format!("{arch}-{os}-{abi}");

    if !matches!(
        triple.as_str(),
        "x86_64-linux-gnu"
            | "x86_64-linux-musl"
            | "aarch64-linux-gnu"
            | "aarch64-linux-musl"
            | "x86_64-windows-gnu"
            | "aarch64-windows-gnu"
            | "x86_64-macos-none"
            | "aarch64-macos-none"
    ) {
        panic!("Unsupported target: {triple}\nCheck support targets on {project_url}");
    }

    // Compose the download URL, e.g.
    // https://github.com/hexops/mach-dxcompiler/releases/download/2023.11.30%2Ba451866.3/aarch64-linux-gnu_Debug_bin.tar.gz
    let release_file_url = format!(
        "{project_url}/releases/download/{latest_binary_release}/{triple}_ReleaseFast_lib.tar.gz"
    );
    let cache = Cache::builder().build().unwrap();
    cache
        .cached_path_with_options(
            release_file_url.as_str(),
            &Options {
                subdir: Some("mach-dxcompiler-sys".to_owned()),
                extract: true,
            },
        )
        .unwrap()
}

Hey, looks like you made quite some progress on a mach-dxcompiler crate (even more so than myself - you have support for multiple targets and it looks like you are generating the custom Mach bindings for Rust too). Would you be open to combining efforts or potentially making PRs with whatever extra functionality you have?
I think caching is a reasonable request. But the cached_path crate depends on reqwest and tokio. These are very heavy dependencies and (in my opinion) bloat build times far beyond downloading a file. Do you think it would be reasonable to just use the system curl/tar tools to create the cache instead? This is the approach that I currently use for downloading the binaries.

Yeah those deps are too heavy, I think we only need to find the cache path and add etag for download file. I will look into the implementation on cached_path and make a PR then.


How to change its background color dialog

I want to change its background color from white color to dark color.

Hello @kittist ,
I was able to set the background to yellow on the latest version of this plugin as PR #13  with the following:
    return MaterialApp(
      theme:   ThemeData(
        cardColor: Colors.yellowAccent,
      ),
...

Here is the result within the example app:

Dialog

Menu

If you need to change the card color for all cards in your MaterialApp, this solution is quite convenient. Otherwise, changing the background color for just one widget would probably require a change in code. Is this something that you would need or changing for all cards through theme is good enough for you?

Hello @kittist ,
I just added a menuBackgroundColor to the next PR #16 for this plugin. (If you don't want to wait for the publication of this PR, I also implemented it on my version of the plugin ).
With this parameter, you can define the background color of the menu without affecting the other cards of the app.

I tried it in PR #16.
It works! thanks
but It would be perfect if I can change font/icon color like this

Hi @kittist
I've published the update (thanks @lcuis ) on pub.dev.
I'll close this issue and feel free to reopen if you think this issue is not solved yet.
Thanks


Incremental Rollup Settings

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

@kofijohnson Shouldn't this PR merge into feature/RollupsIncrementalBatch rather than master?

@force2b my goal is we first merge feature/RollupsIncrementalBatch first into master (and mrbelvedere will merge back to feature/RollupsIncrementalBatch__UI). Then we merge feature/RollupsIncrementalBatch__UI (expose the settings to the users) probably the next sprint.
The goal of merging first the feature/RollupsIncrementalBatch is to be able to do the test with big org like the NRDC before we make the settings available to all our customer.

That makes sense, however this PR should still point to its parent feature/RollupsIncrementalBatch branch. Otherwise, if you look at the list of changed files it's impossible to determine which changed items relate to the UI. In the end, this is still a child of feature/RollupsIncrementalBatch even if you're going to merge it after a release of the main functionality.
Also, keep in mind that the next push to production is not until 9/18. Is there a plan to test the main incremental rollups functionality as a beta package inside an NRDC Sandbox earlier?

@kofijohnson @force2b are we going to try to get this in?

@njjc @kofijohnson I don't think we can squeeze this in at the moment. If I remember this correctly there are still some outstanding issues that needed to be resolved for this to work. If anything, I would say we should write up document detailing what is necessary to bring this across the finish line and create the necessary work items to do so.
Also, there are two open PR's on this which, which I think need to be merged into a single branch/PR.

Sounds good. @kofijohnson could you merge the two into a single branch and document any outstanding items? Thanks!


Continuous looping

Is it possible to do continuous looping?
https://codepen.io/luckyluke007/pen/ZraYgN

http://animejs.com/documentation/#infiniteLoop
as simple as that...


[string "?"]:5116: attempt to get length of a nil value

At the end of categories (while scrolling) instead of going back to vita category I get the error:
[string "?"]:5116: attempt to get length of a nil value

I'm having trouble replicating the issue.
When i reach the last game it's looping back to the first without an error.
Hopefully these questions will help me replicate the issue:

Are you using the D-Pad, Analogue sticks, Trigger buttons, or touch to scroll through the games when this happens?
Does it happen for every game category?
Also, is the startup scan on or off?

Thanks

I generally run with start up scan off unless I add things. It's not at the end of a category it is at then end of the categories. So my first category is vita and my last is favorites. When I press square to go from favorites back to vita, that's when I get the error.

function GetNameAndAppTypeSelected() -- Credit to BlackSheepBoy69 - This gives a massive performance boost VS reading whole app info.
if CatLookup then
if #xCatLookup(showCat) > 0 then --if the currently-shown category isn't empty
app_title = xCatLookup(showCat)[p].apptitle
apptype = xCatLookup(showCat)[p].app_type -- needed for launching games from mixed categories
filename = xCatLookup(showCat)[p].filename -- needed for adding to recent
else
app_title = "-"
end
	if showCat == 40 and #search_results_table == 0 then
	    app_title = lang_lines.Search_No_Results
	end
end

end
If I do this it works but I think it may be breaking the function.

This appears to be working properly
function GetNameAndAppTypeSelected() -- Credit to BlackSheepBoy69 - This gives a massive performance boost VS reading whole app info.
if showCat then
if #xCatLookup(showCat) > 0 then --if the currently-shown category isn't empty
app_title = xCatLookup(showCat)[p].apptitle
apptype = xCatLookup(showCat)[p].app_type -- needed for launching games from mixed categories
filename = xCatLookup(showCat)[p].filename -- needed for adding to recent
else
app_title = "-"
end
if showCat == 40 and #search_results_table == 0 then
app_title = lang_lines.Search_No_Results
end
end
end

Okay, thanks for the info.
If you can undo any changes you have made, then change the following on line 10053:
Change GetNameAndAppTypeSelected() to GetInfoSelected()
Let me know if that solves the issue, thanks.

That appears to fix everything!

Good stuff, thanks for reporting. I'll release a fix soon.

Should be resolved with v3.6.1
https://github.com/jimbob4000/RetroFlow-Launcher/releases/tag/v3.6.1


[SPARK-11276][CORE] SizeEstimator prevents class unloading

The SizeEstimator keeps a cache of ClassInfos but this cache uses Class objects as keys.
Which results in strong references to the Class objects. If these classes are dynamically created
this prevents the corresponding ClassLoader from being GCed. Leading to PermGen exhaustion.
We use a Map with WeakKeys to prevent this issue.

Can one of the admins verify this patch?

Test build #1951 has started for PR 9244 at commit 22a02a2.

Test build #1951 has finished for PR 9244 at commit 22a02a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

If there are no objections, I'll merge to master. This looks like a good targeted fix.

merged to master


Serve directory for file server & Fix bufio flush bug

Closes #14

Now file_server would serve directory!
Also fix a small bug with bufio.ts BufWriter that failed to await on flush (which would cause server to stuck forever on files larger than buf size)

@kevinkassimo It would be cool if you abstracted the file server like this:
https://golang.org/pkg/net/http/#ServeFile

@ry Hmm, in that case, I might need to abstract file_server.ts content as a function and create a new file like file_server_bin.ts that run this function?
Or actually, probably we can add the feature like Python's if __name__ == "__main__" that checks if the current file is run directly or imported as a module to Deno, such that we can optionally start the server? (Dunno if it is a good idea...)

@kevinkassimo You can move the serveFile() into the http.ts module

@ry FileServer sounds more like the expected abstraction: https://golang.org/pkg/net/http/#FileServer

@kevinkassimo Ah, rightly so

Here's a nice test: https://github.com/golang/go/blob/353ebe721019ac833646bea829d7840e55f3da30/src/net/http/fs_test.go#L220


scrollToDate Not working

Hello,
I'm using calendar version 7.1.5.
I'm trying to scroll programmatically to needed date like that self.calendarView.scrollToDate(date).
Basically I have function which receives date from object and then depending on value should scroll calendar, unfortunately nothing works for me.
private func scrollCalendarView(to date: Date) {
        self.calendarView.scrollToDate(date)
        self.updateHeader(date: date)
 }

Here is calendar configuration
        self.calendarView.calendarDelegate = self
        self.calendarView.calendarDataSource = self
        self.calendarView.isRangeSelectionUsed = true
        self.calendarView.allowsMultipleSelection = true
        self.calendarView.register(UINib(nibName: Constants.Xibs.calendarCell, bundle: nil),
                                   forCellWithReuseIdentifier: Constants.Xibs.calendarCell.lowerCaseFirst)
        self.calendarView.minimumInteritemSpacing = 0
        self.calendarView.minimumLineSpacing = 0
        self.calendarView.sectionInset = UIEdgeInsetsMake(0, -8, 0, 3)
        self.calendarView.scrollingMode = .stopAtEachSection
        self.calendarView.scrollDirection = .horizontal

Please let me know if you need more information.

scroll to date should work as expected.
if you are using cocoapods, can you use breakpoints to check to see if you are scrolling to an invalid date (a date outside of the calendar boundary) ?

Hey, thanks for quick response. I guess my mistake was to call this method in initializer of custom ui view subclass.

cool. closing this then.


Add a 'compactMap'-Function to 'LoadableState'

A 'compactMap'-Function would help with scenarios like transforming an array of entries to a single entry where it is not sure whether the desired specific entry is really in the array of entries.
Assume a loadable list of points of interests:
`var pois: LoableState<[POI]>
var aPOI: LoadableState {
pois.compactMap { pois in
pois.first { $0.id == poiId }
}
}
`
This scenario comes up with respect to deep linking for instance.

Nice, thanks 👍


The widevine library does not install.

I assembled and installed the plugin in Kodi 21.0.Python 3.12.3.
SRCREV = "e5bc154525bcf1dea11138c30f602f441a361d79"
When trying to update the WIDEVINE library, the error is:
2024-05-19 16:19:37.077 T:9202  warning : [script.module.inputstreamhelper] Recursively create directory '/home/root/.kodi/cdm/'.
2024-05-19 16:19:37.082 T:9202    error : [script.module.inputstreamhelper] Widevine CDM is not installed.
2024-05-19 16:19:37.089 T:9202  warning : [script.module.inputstreamhelper] Recursively create directory '/home/root/.kodi/userdata/addon_data/script.module.inputstreamhelper/temp/'.
2024-05-19 16:19:37.130 T:9202    error : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'ModuleNotFoundError'>
Error Contents: No module named 'distutils'
Traceback (most recent call last):
File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/utils.py", line 356, in parse_version
from packaging.version import parse
ModuleNotFoundError: No module named 'packaging'
                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/default.py", line 8, in <module>
                                                   run(sys.argv)
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/api.py", line 15, in run
                                                   widevine_install(choose_version=params[2])
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/api.py", line 48, in widevine_install
                                                   Helper('mpd', drm='widevine').install_widevine(choose_version=choose_version)
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/__init__.py", line 34, in clean_before_after
                                                   result = func(self, *args, **kwargs)
                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/__init__.py", line 219, in install_widevine
                                                   if not self._supports_widevine():
                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/__init__.py", line 163, in _supports_widevine
                                                   if parse_version(config.WIDEVINE_MINIMUM_KODI_VERSION[system_os()]) > parse_version(kodi_version()):
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                 File "/home/root/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper/utils.py", line 359, in parse_version
                                                   from distutils.version import LooseVersion  # pylint: disable=deprecated-module
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                               ModuleNotFoundError: No module named 'distutils'
                                               -->End of Python script error report<--

Please install the following zip and try again
script.module.inputstreamhelper-0.6.1-master-e5bc154.zip

It works. Is the plugin not building correctly for me or did you change something?

Here is my assembly recipe.
kodi-addon-inputstreamhelper.zip

I didn't change anything. I built the zip with make zip. See the Makefile.
I have no experience with yocto build recipes, but it seems your KODIADDONDIR is wrong. there is a dot missing before kodi, i.e. ${datadir}/.kodi/addons
The sed command is no longer necessary. Other than that I guess it should be fine.

Can this issue be closed?


Provide drag and drop from ComponentLibrary to main canvas.

Going to close this since there's no imminent plans to support this.


Fix tile selection bug, add some helpful tools for debugging

Fixes #1028
The sketchiness described in that issue was a legitimate bug in the tile selection algorithm. Here's the scenario:

Frame 1: We start off zoomed in, looking a level 15 tile (among others). Because "Preload Ancestors" is disabled (or we just haven't waited long enough), there are no less-detailed tiles loaded that cover the area of this level 15 tile.
Frame 2: The user zooms out, so now we'd ideally select that level 15 tile's parent, a level 14 tile. We start the process to download it, but it's not available yet. So we continue showing the level 15 tile (thanks to ancestorMeetsSse).
Frame 3: The user zooms out more, so now we'd ideally select the level 14 tile's parent, at level 13. We start downloading that. We're still showing the level 15 tile.
Frame 4: The load of the level 14 tiles completes. So we select this tile for rendering instead of the previously-selected level 15 tile.
Still in Frame 4: While in _visitTile for the level 13 tile, we execute this code after traversing children, including our selected-for-rendering level 14:

bool kickDueToNonReadyDescendant =
    !traversalDetails.allAreRenderable &&
    !traversalDetails.anyWereRenderedLastFrame;

And this evaluates to true. So the level 14 gets kicked out, and the level 13 is selected instead. Only the level 13 isn't even loaded yet, so we just made detail (the level 15 tile) disappear. Wait, why does this evaluate to true?
Well, allAreRenderable is false because some of the level 13 tile's children are loaded and some are not. We're zooming out with a very incomplete tile tree, so it's expected that there will be some tiles missing around the edges. No problem here.
anyWereRenderedLastFrame is also false because this is the first time we're rendering the level 14 tile. So that's accurate, too. But hang on a minute... even though we've never rendered this level 14 tile before, we have rendered the level 15 tile in the same location. So there were tiles rendered last frame in this space. The value of this flag should be true.
So this PR ensures that it is. It works by tweaking how the TraversalDetails are computed for a single tile. Previously, it would only set anyWereRenderedLastFrame to true if the single tile's last frame state was Renderable. Now, it will also check if the last frame state was Refined, and, if so, it will check to see if its children were rendered last frame. This check is recursive as necessary, in case one of the children was also refined last frame.
In addition to the above bug fix, this PR:

Adds a const version of Tileset::forEachLoadedTile.
Adds DebugTileStateDatabase class.
Adds CesiumAsync::SqliteHelper, containing functions for working with SQLite.

The DebugTileStateDatabase is a handy class to help debug tile selection problems by logging the state of every tile to a SQLite database every frame. I'll open a separate cesium-unreal PR soon that demonstrates how to use this. I found it really helpful to track down this problem.

Thanks for the review @j9liu!

is there any particular case I should use to test this?

Did you see the corresponding PR in cesium-unreal?
https://github.com/CesiumGS/cesium-unreal/pull/1568

Oh hang on I thought you were asking about testing the new debugging tools. You're asking about how to test the bug. Let me get back to you with instructions on reproducing that.

The bug can be reproduced in Unreal using the instructions at the top of #1028. Start with the first level of the Samples project, and make the following changes:

Add a DebugColorizeTilesRasterOverlay to Cesium World Terrain. Designate it Overlay1.
Turn off the two "Preload" options.
Set Maximum Simultaneous Tile Loads to 1.

Zoom in close anywhere on the globe, looking straight down. Press Ctrl-1 to save this view, save the level, and exit Unreal. Delete the request cache, which is found at %userprofile%\AppData\Local\UnrealEngine\5.2\cesium-request-cache.sqlite or similar. Start up Unreal and record a video using the game bar or whatever. The tips in #1568 will help. Zoom directly away from the Earth while continuing to look straight down.
Now watch the video carefully. As you zoom out, newly-exposed areas will initially be blank, and that's fine. But you should never see a spot that used to be covered by a tile suddenly turn blank. That's the bug. It should happen pretty much every time in main, and not at all with this PR.

Thanks @kring ! Weirdly I can't reproduce the error that you're describing on main, but I also don't have access to Xbox gamebar on my laptop... so maybe it's picking up something that OBS can't.
But I'll take your word for it! At least the branch doesn't make anything worse. 😛 Going to merge after CI passes


google_play_services_version

java.lang.IllegalStateException: A required meta-data tag in your app's AndroidManifest.xml does not exist.  You must have the following declaration within the  element:
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2429)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2493)
at android.app.ActivityThread.access$800(ActivityThread.java:166)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1283)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5584)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.IllegalStateException: A required meta-data tag in your app's AndroidManifest.xml does not exist.  You must have the following declaration within the  element:
at com.google.android.gms.common.zze.zzbs(Unknown Source)
at com.google.android.gms.common.zze.isGooglePlayServicesAvailable(Unknown Source)
at com.google.android.gms.common.zzc.isGooglePlayServicesAvailable(Unknown Source)
at com.google.android.gms.internal.zzsb.zzcs(Unknown Source)
at com.google.android.gms.internal.zzsb.zzd(Unknown Source)
at com.google.android.gms.internal.zzsb$1.zzd(Unknown Source)
at com.google.android.gms.internal.zzsb$5.zza(Unknown Source)
at com.google.android.gms.internal.zzsb.zza(Unknown Source)
at com.google.android.gms.vision.barcode.internal.client.zzd.zzchw(Unknown Source)
at com.google.android.gms.vision.barcode.internal.client.zzd.(Unknown Source)
at com.google.android.gms.vision.barcode.BarcodeDetector$Builder.build(Unknown Source)
I checked entire project but there is no google_play_services_version anywhere

Hi Naresh-Katta.
I'm on vacation at the moment so I'll check into this in a week or two.. But I surely state compile 'com.google.android.gms:play-services:9.4.0' in gradle so I'm not sure that you really "checked entire project".
Have you installed Play Services in Android studio?

I installed Google play services revision 39.

@Naresh-Katta I'm really not able to do anything with that information... Did installing help?

@Naresh-Katta If you don't have any more info on this I would like to close the issue.

Sorry, Currently I stopped working on QR scanner, due to some problems. You can close this issue for sure.


--exclude-non-flow  to exclude non flow files from coverage report

Fixes this: https://github.com/rpl/flow-coverage-report/issues/85 by introducing --exclude-non-flow flag.
Reasoning is that project might contain legacy files which will never be turned into Flow, so it does not make sense to track coverage on them. Instead, it makes sense to concentrate on flow annotated files and their quality.
Also added bunch of libdefs and flow annotated few files :)
ping @rpl

This PR looks good, right? Could we move ahead with this changes :) This option will be really useful.
Thank you.

Hi @villesau sorry for the long waiting time, and thanks a lot for contributing the changes needed to add the --exclude-non-flow cli option.
I've been looking a bit into how I would prefer to manage the updates of the new flow-typed definition included in the repo (and tried to reduce them to the minimum), and I also added a new unit test for the --exclude-non-flow cli option and so I ended up creating a new pull request with the new changes applied on top of yours.
I'm closing this PR because #154 include both this pull request and the additional changes I've been working on locally, but don't worry... I'm going to merge #154 as soon as all the tests pass on travis ;-)
(at least if you confirm that #154 does also cover your use case as it is, otherwise I'm open to quickly discuss if we need to change anything on it before merging it)


Concurrent createUploadSession requests failing

#749
Category

[ ] Question
[ ] Documentation issue
[X] Bug

Expected or Desired Behavior
I have been using createUploadSessions in SPO for months now and it has worked perfectly for uploading a large chunk of files. What I normally do is that I spin up 40 concurrent requests, start uploading the file chunks, and start new sessions once any of the previous ones is finished. This has worked fine until now, the sessions were created, chunks were created and finally the files were created in OneDrive.
Observed Behavior
What I'm seeing now that I receive an invalidRequest response after creating a bunch of requests and it seems like only a handful of files will get uploaded completely. I can make it work by only creating one session, finishing it, and creating another session. However, this is considerably slower that what it used to be when I was able to upload multiple files concurrently.
  method: 'POST',
  path: '/sites/root/drive/root:%2F<snip>.pdf:/createUploadSession',
  responseBody: '{"error":{"code":"invalidRequest","message":"Invalid request","innerError":{"date":"2020-09-06T14:53:11","request-id":"dff3cfa9-54e8-4eb5-b108-bf0dec0b04e6"}}}'

If this is a new rate limit being applied, I believe the error code should be changed to something more meaningful or understandable.
Steps to Reproduce
Create a bunch of upload sessions concurrently and start uploading chunks. The specific code I'm using is located here:
https://github.com/turist-cloud/ship/tree/master/packages/ship-board

src/upload-files.ts
src/fetch-graph-api.ts

[ ]: http://aka.ms/onedrive-api-issues
[x]: http://aka.ms/onedrive-api-issues

The attribution seems like a bug, which we'll put on our backlog. To be clear, we discourage spinning up that many concurrent requests - the application should be getting a throttling response.

@chackman Oh yes, I was going to say that I was hoping for a throttling response. I'm not sure if that happened before but my code would handle that just fine.

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


Add benchmarks

Improve performance of from_decimal, from_integer, from_float. These are microbenchmarks so to be taken w/ a grain of salt, but I think you can see that in the implementation that circumventing doing the to_string dance would improve performance
before
make with formatted decimal               100000   12.78 µs/op
make with unformatted decimal             100000   17.89 µs/op
make with string                           50000   35.91 µs/op
make with string and currency option       50000   41.40 µs/op
make with integer                          50000   42.34 µs/op
zero                                       50000   42.46 µs/op
make with float                            50000   42.55 µs/op

After
zero                                     1000000   1.16 µs/op
make with formatted decimal              1000000   1.23 µs/op
make with integer                        1000000   1.38 µs/op
make with float                           500000   4.62 µs/op
make with unformatted decimal             100000   18.11 µs/op
make with string                          100000   23.50 µs/op
make with string and currency option       50000   32.78 µs/op

wow that's amazingly better! Thanks a lot :heart:


Support Windows Server 2019

Supported operating system for OLE DB Driver for SQL Server should contain Windows Server 2019 like any other drivers/tools for SQL Server.

@rikat-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Prompt user if data is not saved in Grid textbox

Hi,
I just need to prompt User, when the user is trying to leave the site by pressing panel back button without saving the data in grid.
I can able to prompt in dialog and I find difficult in Grid. can anyone please suggest me a solution.
And also, though it is not serenity thing, How to detect the browser back button click and stop user going back?

see this https://serenity.is/demo/Northwind/Product

You may also check javascript window beforeunload event
https://stackoverflow.com/questions/1631959/how-to-capture-the-browser-window-close-event


Localization in partially observable environment

With reference to #161
The visualization is in accordance with the partially observable maze problem referenced in chapter 4. Please go through it to completely understand what I am trying to do here.
There are 3 parts to it (as of now).

We first introduce the concept of percepts in a maze where the robot can only see if there is a wall beside it. The user is given a specific percept and he/she needs to click on all the cells of the maze where the robot may get that percept.
We show an abstract solution to the above problem by allowing the user to hover over any cell and see its percept. Along with it, it also highlights all other cells which can have the same percept. This is to introduce the concept of belief states (states where the robot believes it can be)
We start with an actual robot (hidden from the user) and its corresponding belief states. User needs to pinpoint the location of the robot by moving around the robot. The user can move the robots around and see how some of them gets eliminated when the percepts do not match with the actual percept.

The actual problem in the book has only one action "move" where the robot will move in some random direction. This would be easier to explain after the first 3 diagrams.
The visualization is still incomplete and any review or criticism is welcomed.
I will continue working on it if is still useful to aima-javascript.
(Work in progress. Do not merge)

For this summer, aima-javascript is moving towards a focus on narrative instead of a focus on visualizations.