Crash at plenary async module on all actions that show a select UI

Description
Error executing vim.schedule lua callback: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ....local/share/nvim/lazy/neogit/lua/neogit/lib/git/cli.lua:797: i
nvalid value (table) at index 9 in table for 'concat'
stack traceback:
        [C]: in function 'error'
        ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
        ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'on_select'
        .../.local/share/nvim/lazy/neogit/lua/neogit/lib/finder.lua:232: in function <.../.local/share/nvim/lazy/neogit/lua/neogit/lib/finder.lua:231>

This happens whenever I need to select something from a select UI:

Right after selecting, I get the trace above.
Neovim version
 ~/Development/memfault => nvim --version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/nix/store/i9f72lw9lymhc10ib5x2knp2g0d09arz-neovim-unwrapped-0.9.1/share/nvim
"

Run :checkhealth for more info

Operating system and version
~/Development/memfault => uname -a Linux nixos 6.1.55 #1-NixOS SMP PREEMPT_DYNAMIC Sat Sep 23 09:11:13 UTC 2023 x86_64 GNU/Linux
Steps to reproduce

Open any workflow that requires selecting
It breaks

Expected behavior
No response
Actual behavior
See the summary
Minimal config
-

Enabled Telescope integration to work around this. But the default selector UI is broken.
    integrations = {
      telescope = true,
    },

For me, telescope integration is not working (crashing). And if I disable it, select something via another select UI, it crashes right after selection.

For me, telescope integration is not working (crashing).
E5108: Error executing lua ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...cker/start/telescope.nvim/lua/telescope/
actions/init.lua:74: Key does not exist for 'telescope.actions': nop

Thats... odd. If you run := require("telescope.actions").nop in neovim, does anything print?

It prints error.
-- debug
local actions = require("telescope.actions")
local keys = vim.tbl_keys(actions)
print(#keys) -- 75
print(vim.tbl_contains(keys, "nop")) -- false

My telescope setup options:
telescope.setup({
  pickers = {
    find_files = {
      find_command = {
        "rg",
        "--files",
        "--hidden",
      },
    },
  },
})

It's because I have telescope tagged to 0.1.0 version, that doesn't have this

Try updating. I have 83 keys, including nop and git_reset_hard.

Try updating. I have 83 keys, including nop and git_reset_hard.

Updated, seems the second error message is gone. But nop error is present for me.
Maybe it's possible to replace nop with an empty function

I add this to my config:
local actions = require("telescope.actions")
actions.nop = function(_) end

And the error changed to:
E5108: Error executing lua ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...k/packer/start/telescope.nvim/lua/telesc
ope/mappings.lua:285: bad argument #1 to 'lower' (string expected, got table)
stack traceback:
        [C]: in function 'error'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:118: in function 'callback'
        ...cal/share/nvim/lazy/neogit/lua/neogit/lib/popup/init.lua:588: in function 'cb'
        .../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:449: in function <.../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:448>
        ...are/nvim/lazy/neogit/lua/neogit/lib/mappings_manager.lua:14: in function 'invoke'
        [string ":lua"]:1: in main chunk

@coffebar can you open a new issue with a minimal config that I can use to reproduce this?

Tested your fix @CKolkey, it works!


Support configuring the indent to use tab rather than 2 spaces

Is your feature request related to a problem? Please describe.
The command Breadcrumbs: Copy a Local Index to the clipboard will generate a hierarchical list.
The indent used in this hierarchical list is the space, i.e. adding 2 spaces increases a level of indent.
However, in the obsidian, the indent used for hierarchical list is configurable. And in my case, the indent used is the tab, i.e. adding 1 tab will increase 1 level of indent.
Therefore, here comes the problem, when I generate a long list with Breadcrumbs, I need to manually replace the indent of almost every item from 2 spaces to 1 tab.
Describe the solution you'd like
A configuration is preferred, so the user can choose the indent that they need.
Describe alternatives you've considered
alt 1. find and replacement performed manually.
alt 2. manually patch the main.js
function createIndex(allPaths, asWikilinks) {
    let index = "";
    const copy = lodash.cloneDeep(allPaths);
    const reversed = copy.map((path) => path.reverse());
    reversed.forEach((path) => path.shift());
    const indent = ".."; //patch this line with: const indent = "\t";
    const visited = {};
    reversed.forEach((path) => {
        for (let depth = 0; depth < path.length; depth++) {
            const currNode = path[depth];
            // If that node has been visited before at the current depth
            if (visited.hasOwnProperty(currNode) &&
                visited[currNode].includes(depth))
                continue;
            else {
                index += `${indent.repeat(depth)}- ${asWikilinks ? makeWiki(currNode) : currNode}\n`;
                if (!visited.hasOwnProperty(currNode))
                    visited[currNode] = [];
                visited[currNode].push(depth);
            }
        }
    });
    return index;
}

Additional context
no

I like this idea :)
I've added a setting under BC Settings > Commands > Create Index  >Indent Character(s). Let me know your experience with it

The new feature is great, thanks!


Add beforeEnqueue hook

Add a beforeEnqueue hook that's called before a job is placed on a queue. You can cancel the creation of a job by throwing Resque_Job_DontCreate in a hook/plugin.
This is basically #199, but works slightly differently (throws an exception). The changes in #199 have issues if multiple plugins are listening on the one event, and don't include tests.
The only thing I've not accounted for here is returning the not created status back to the caller. How do we want to handle this?
Ping @wedy & @danhunsaker

I think given #228 where I want to surface Redis errors/failures as exceptions, returning false here might make more sense (the job wasn't created, vs there was an error creating the job)
I've updated the PR & tests to reflect that. Can you have a quick look @danhunsaker?

Makes sense.  Still a 1.3 rather than a 1.2.1 to throw exceptions anywhere we don't handle them ourselves.


Add TaskList managed resources for Images and Buffers

Daxa task list should be able to synchronize between runs for persistent ressources.
This includes synching on changes of permutation between runs.

Feature goals:

persistent ressources

"persistent" means, that the ressource is not transient, so lives over multiple executions
persistent images should retain their content between executions, eg. no from layout undefined transfers
open issues:
[X] Do we batch all start of execution barriers?
yes. Drivers prefer strong batching of barriers and synch will likely even improve.
[X] Are split barriers a good idea here?
no. they overcomplicate the design.

persistent ressources are in.

As of the rescent changes we have transient resources that are fully managed by task lists.


Some questions about the prepare_cvact.py

Hello, I had some problems while preparing for CVACT, as follows,
**dataset index: 218255 dataset unexist pair:  ['G:/datasets/ANU_data_small/streetview/HkiKa_k0d5RXDxW14D_A1A_grdView.jpg',                                     'G:/datasets/ANU_data_small/satview_polish/HkiKa_k0d5RXDxW14D_A1A_satView_polish.jpg']**
This kind of prompt appeared many times. After processing, the 70G data finally generated only a 600M data. Can you tell me how to solve this problem?

Hello. For the first problem, you do not need to care about the prompt. The prompt is caused by the dataset. For the second problem, it is also normal for the raw data to become smaller due to some processing. I do not know whether the 600M data belongs to the training set or the val set. Can you give me the detailed information about the memory occupation of training set and val set. @Allen-lz

I re-executed the data processing and found that an error occurred during the process of decompressing ANU_data_small.tar.gz. This resulted in a data set that was too small.
`
tar: Skipping to next header
tar: Archive contains ‘}߅\317\332\363gf\006\017ۮ’ where numeric off_t value expected
tar: Skipping to next header
tar: Archive contains ‘φ\373\304\003\221\324\343\234\347\2478’ where numeric off_t value expected
tar: Archive contains ‘\357\342+K\254\217\335\333\337ë\254’ where numeric off_t value expected
tar: Archive contains ‘\336\317t\265\365?\224\351c\226\v\275’ where numeric off_t value expected
tar: Skipping to next header
tar: Archive contains ‘1\361\226\252u\313\373\237\0\374:\037’ where numeric off_t value expected
tar: Archive contains ‘\251a\247\262E&\373\333Ź\206_’ where numeric off_t value expected
tar: Archive contains ‘\373|\036\321\3760x\202?\020\334\374’ where numeric off_t value expected
tar: Archive contains ‘k\372\274Zwښ\347\354\207H\270’ where numeric off_t value expected
tar: Archive contains ‘\252\370SHK/\v\350\227(\0323’ where numeric off_t value expected
tar: Archive contains ‘Yd\374;\217l\363\374\271S\246^’ where numeric off_t value expected
tar: Archive contains ‘\274]\254XKw\341]:\v\254\225’ where numeric off_t value expected
tar: Archive contains ‘컾\276\233\276\237\257\336\025)\373’ where numeric off_t value expected
tar: Archive contains ‘\245\0336\256\222\373=?\256\306\027}’ where numeric off_t value expected
tar: Archive contains ‘8\253Rxv\240\333m\362\255o\246’ where numeric off_t value expected
tar: Archive contains ‘4\322xgH\267\325n\315ֱ\373’ where numeric off_t value expected
tar: Archive contains ‘?\361+\366\230\360\226\255c\017\2064’ where numeric off_t value expected
tar: Archive contains ‘?\356\366~\226\364ӥ\377\0\377\331’ where numeric off_t value expected
tar: Archive contains ‘V\217\354\262.P\264s0i<\246’ where numeric off_t value expected
tar: Archive contains obsolescent base-64 headers
tar: Archive contains ‘+\2229R\001洭\364\273ɐ’ where numeric off_t value expected
tar: Archive contains ‘\2142\301%\253\334\335ʒ\264q\262’ where numeric off_t value expected
tar: Archive contains ‘\216\313\304\032\234ڥ\335Ƈ\252\244’ where numeric off_t value expected
tar: Archive contains ‘\242\272[\305\354PiX\221R\021\366’ where numeric off_t value expected
tar: Archive contains ‘\226&\021\005\375ۯ\356\036\vĂ’ where numeric off_t value expected
tar: Skipping to next header
gzip: stdin: invalid compressed data--crc error
gzip: stdin: invalid compressed data--length error
tar: A lone zero block at 151070495
tar: Child returned status 1
tar: Error is not recoverable: exiting now
`
@wtyhub

I am sorry and I do not know how to solve this problem. I also encountered this error and I re-downloaded this dataset at that time to solve this error. You also can try to solve this error via Google. When you unzip this dataset correctly, you will see two folders, one containing 44415 images and one containing 44416 images. @Allen-lz

oh~, thank you very much for your prompt reply, I will also try it again.

Hello, when I run file prepare_cvact.py, the program reminds me that there is no file ACT_data.mat. Have you ever encountered this problem?


Set new dimensions without rerender React component

It's possible to set new Iframe dimensions without react rerender iframe and change URL?

Yes -- depending on where you are, you should be able to call resize()
From the child: window.xchild.resize(width, height)
From a prop in the parent: this.resize(width, height)

Thanks @bluepnume ! You are amazing

@bluepnume
Sorry to reopen the issue. I am facing a similar one.
In the xcomponent.create I have:
autoResize: {
    height: true,
    width: true
}

But it does not autoresize.
I tried  to pass a prop from parent resizeParent:function(){ window.resize('100%', '100%');}
Then, calling window.xprops.resizeParent();
I have a react component as child. It is a list of items.
I would like to resize parent container once there are more/less items in the child.
But that did not work as well 😟
Thanks!


Experimental variant on #57465 with two optimizations

This adds two optimizations to #57465:

For the false check, if trueType is a large union (20+ constituents) then split it into two chunks when calling getFlowTypeOfReference. The first chunk has the first 10 types, the second has the remainder. If the first chunk doesn't narrow to never then we don't have to check the second. This is a huge win on #54148. On my laptop it reduces the time for the most extreme check from 312ms→140ms by only checking 10/112 types in the union. There are several other expensive calls on that PR that it's able to bypass as well. This has less of an effect on the Compiler-Unions benchmark.
A fast path for functions of the form x => x === y (or ==, !==, !=). These can only be type predicates if y is a unit type like null or undefined, but that can be expensive to determine via the usual calls to getFlowTypeOfReference if x and y are both large union types. In both Compiler-Unions and #54148 there are some expensive checks that this bypasses, notably d => d === objectLiteralDeclaration.

In local testing these help on both Compiler-Unions and #54148. The x === y optimization is definitely targeted at a specific case in Compiler-Unions, but it's a win on #54148 as well, so perhaps it does generalize.

@typescript-bot perf test this

I'm surprised this wasn't a win. Might be time to stop optimizing this!


Deniz Uzun

Do you have any advice on how to add the match and mismatch within the code? Did I define it properly in the function? @kescobo

I see you've been trying a lot of stuff, but may be going around in circles a bit. Let me know if we can hop on a call today or tomorrow.

A zoom call tomorrow would be super helpful, thank you! @kescobo

Not sure why the automated tests are failing to run here - let me know if you think you're done and I'll run them locally

@kescobo I am definitely done with lab3 but not with lab4... it might be because I am continuing to work on lab4 through this same file? Anika and I decided that would be the best way to still have the old needleman_wunch to work on for lab4, maybe there is a better way?

Lab 3 complete as of https://github.com/wellesley-bisc195/AlignmentAlgorithms/pull/2/commits/3f4fe7fde2ed620d72c444dd71d8eb3a6a4f4069


Add feature: Rearranging items

Add a feature to rearrange items in each template.
For example:- In Comprehension Template or Quiz template if instructor prepare a quiz, once questions are added there is no way to rearrange questions.

Similar to issue #349

I checked #349 and it is not exactly what @vishwesh3  is suggesting. @vishwesh3 this looks like a useful feature to work on. Please pick this up if you want to work on this.

Thanks @croozeus working on this and will send PR soon.

Sorry my mistake. Just understood that.

Created PR #383 Please have a look.

Closed via #383


Support the equivalent of tags in resource files.

Make it possible to create dynamic types that can contain other types, tags and individual entries, that can be used at the same level as normal types.


GH-342 Removing basic authentication and api_token

All authentication methods, other than the Bearer token (access key) are removed.
Currently, basic auth is not supported by some tests, using Projects calls and webhooks, but core Artifactory will remove basic authentication in future versions.

So, the changes look good, but @danielmkn you had suggested keeping the api_key

I think, maybe for the time being, we should keep API token - that's something a user can generate themselves.  What do you think @alexhung

I think, maybe for the time being, we should keep API token - that's something a user can generate themselves.  What do you think @alexhung

@chb0github Regular users can generate their own scoped access token as well, so not restricted to just admin users.

@danielmkn Please include update to CHANGELOG.md.

@chb0github I've just double checked with non-admin user. When logged in as non-admin user, I don't have access to any of the Settings so no way for me to create an access token.
So @danielmkn let's put back the API key so regular users can also use the provider with their own API key.


Fixed bug with synchronous multi component asyncConnect.

Changed recursive promise resolution to instead use a loop and a final resolve return. This is related to #78

Please do not change mapSeries - this is not where you should make changes. mapSeries works exactly how it should work.
You need to apply changes where components are flattened and then promises are iterated over in the mapSeries. When we have branching in the component we can resolve their statics asynchronously, but we need this to be resolved before getting onto nested statics
It should work like this:
Promise.mapSeries([
  [a, b] components A, B rendered in MainLayout resolve different statics -> Promise.map(a, b)
  c,  -- can use smth from a or b (assume its nested in (a)), so uses smth from promise (a) -> uses previous data from Promise['all' || 'map']([a, b])
  e,  -- uses previous data from [a, b] & c -- Promise(...)
  [f, g] -- uses previous data from -- Promise['all' || 'map'](...)
])

Ok I understand. So the aim for this given a routing structure as follows:
<Route component={Home}>
  <Route components={{ compA: CompA, compB: CompB }}>
    <IndexRoute components={{ compC: CompC, compD: CompD, compE: CompE }}/>
  </Route>
</Route>

Is to resolve the promises in the order:
Home then (CompA & CompB) then (CompC & CompD & CompE)?

@thomasdrakebjss yes, you are exactly right

@AVVS I have undone the changes to mapSeries and implemented it using a multidimensional array. I added a new function as I couldn't figure a way to tie filterAndFlattenComponents and eachComponents the way it was working before. I have left the two functions in the code in case they are to be used again at some point. I can remove them if they are no longer needed, I was just suspicious with them being exported.

tests do not cover some weird possible cases, so I'll play around with your code a little bit more and possibly simplify it. meanwhile it would be great if you can add test cases supporting layered layout

I have added a test case to support this change. It adds some extra bits to the router and makes sure the promises are resolved in the expected order.


infra: Fix the workspaceFolder setting in devcontainer.json to ensure the VSCode explorer displays repository contents

Description
This PR addresses an issue with the devcontainer setup, where the VSCode explorer remains empty after executing >Dev Containers: Rebuild and Reopen in Container.
Problem
Repro Steps

Open the LangChain repository in VSCode
Press F1
Type >Dev Containers: Rebuild and Reopen in Container
Wait for the Docker build to complete

This step will take a few minutes. Please make sure that https://github.com/langchain-ai/langchain/pull/19465 has been merged into your environment for the Docker build to finish in a realistic timeframe.

Current Behavior
Even after the Docker build finishes, the VSCode explorer is empty, as illustrated in the following image:

Expected Behavior
The VSCode explorer should display all the contents of the LangChain repository, as shown below:

Analysis
In .devcontainer/docker-compose.yaml, the repository's root directory is linked to /workspace:
    volumes:
   # Update this to wherever you want VS Code to mount the folder of your project
      - ..:/workspaces:cached

However, in .devcontainer/devcontainer.json, the workspaceFolder is set as "/workspaces/${localWorkspaceFolderBasename}", which translates to "/workspaces/langchain":
	"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",

This discrepancy causes the issue. Although the root directory is mounted as /workspaces in the container, the workspace is incorrectly set to /workspaces/langchain, which lacks contents.
Fix
Modify the workspaceFolder setting in devcontainer.json to directly reference /workspaces, making it the workspace directory in VSCode:
-       "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
+       "workspaceFolder": "/workspaces",

I've come to realize that the fundamental cause might stem from how the repository's root directory is mounted differently depending on the execution environment.
In my local environment, the contents of the LangChain repository's root directory are deployed directly under /workspaces on the container. On the other hand, in other environments like GitHub Codespaces, the contents of the root directory are deployed in the container under /workspaces/langchain. (I've confirmed that the devcontainer environment works without any issues in GitHub Codespaces.)
Therefore, to fundamentally resolve this issue, we need to ensure that regardless of the environmental differences, the root directory is consistently deployed on the container under /workspaces/langchain. Although I haven't delved into it in detail yet, the difference might be attributed to the execution environment of docker-compose.

If the comment above is correct, changing the workspaceFolder as suggested in this pull request would not be advisable. This modification could negatively impact environments like GitHub CodeSpaces, which are currently operating without any issues.
Therefore, I will close this pull request.


Use the Gradle Enterprise 2022.2.4 API to more accurately calculate executed cacheble task stats

Non-cacheable tasks that were non-cacheable because of overlapping outputs are
ripe for optimization (they can usually be fixed). Likewise, cacheable tasks
that were not cacheable in order to ensure correctness can also often be fixed
to be cacheable again. For these reasons, we want to treat such tasks as
cacheble tasks that were executed.
This change ensures the stats shown on the build scan page opened by the
Executed cacheable tasks quick link match the stats shown in the experiment
summaries.
However, this change filters out such tasks from the stats for non-cachelable
tasks, which differs from build scan page that is opened via the Executed
non-cacheable tasks quick link. The ideal solution would be to fix the quick
link to exlcude these tasks as well, but the current Gradle Enterprise UI
filtering options make this impossible.

This PR is a draft to prevent merging before PR #96 is merged.


Notebooks sometimes corrupted when power lost

This happens even with saving automatically.
To reproduce:

Open a notebook
Change it
Save it
Unplug the board

Sometimes the file will be corrupt.

Fixed by https://github.com/livebook-dev/livebook/pull/1378.


#837 Add contributing.md

I really don't think this is complete - but its a start!
This PR adds contributing.md, adds a link to it in the readme, and rebuilds the specs to include the updated readme.
It also includes a .gitattributes file which overrides the core.autocrlf = true setting that most Windows Git setups will have. This is important because TypeDoc does not normalize line endings when parsing files. If a file is checked out with crlf line endings and a specs.json file is generated, tests can fail because multiline strings will include "\r\n" instead of "\n". Most editors (Notepad being the one exception that comes to mind) will correctly handle either line endings, so this shouldn't cause any issues there.

This is a minor nitpick, but could you rename the file to uppercase? It's one of those project files like README and LICENSE where using uppercase is the convention.


Issue with non-clickable search bar when used in ionic modal

I'm using the filter bar in a ionic modal to filter through a collection-repeat list of items.
The search bar can be clicked initially and shows as usual but both input and cancel button cannot be clicked.
Any ideas?
Thanks

The ion-filter-bar is placed outside the Modal backdrop & Modal wrapper div tags, making it not a part of the modal itself.

Ah... Apologies... I was looking for how to append to a different container and you've already done that ;) Awesome


python310Packages.angr: 9.2.50 -> 9.2.51

Description of changes
Bump angr stack to 9.2.51

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 232378 run on x86_64-linux 1

16 packages built:

python310Packages.ailment
python310Packages.angr
python310Packages.angrcli
python310Packages.angrop
python310Packages.archinfo
python310Packages.claripy
python310Packages.cle
python310Packages.pyvex
python311Packages.ailment
python311Packages.angr
python311Packages.angrcli
python311Packages.angrop
python311Packages.archinfo
python311Packages.claripy
python311Packages.cle
python311Packages.pyvex


Properly detect ibc_receive websocket events (unchained, not needed for release)

Overview
Websockets are not properly propogating cosmos ibc_receive txs.
Fixing this is the last osmos trading bug we are aware of (atom not showing up after an osmo -> atom trade until the page is refreshed)
References and additional details
example tx:
https://www.mintscan.io/cosmos/txs/AF665E6285D513FC56E9D56F11279C12B7851FC6D6CD93AE637FAD7390C66564
Relevant area of code:
https://github.com/shapeshift/unchained/blob/main/go/coinstacks/cosmos/api/handlers.go#L49
Acceptance Criteria
cosmos ibc_receive txs are sent over websockets
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

closed by:
https://github.com/shapeshift/unchained/pull/478


convert issue

Hi,
When I use native-css, I found a weird issue that sometimes it will export error format in-line styles, for instance, "background-color": "#F8F8F8" => "background-color": "#F8F8F8"(should be "backgroundColor": "#F8F8F8")
Thanks & Regards!

hmm, makes a lot of sense =)
I'll put this issue on "help wanted", feel free if you want to help it.

Hi, @laboratoryyingong I maded this fixes and publish on<EMAIL_ADDRESS>:octocat:
Thanks for reporting :)


zippedArchive not working for DailyRotateFile

I have set zippedArchive to true but it seems not to work for DailyRotateFile. Any suggestions ?

I made a PR for this issue  #675

I made a PR for this issue  #675

The DailyRotateFile transport was moved to a separate module (winston-daily-rotate-file) as of<EMAIL_ADDRESS>As such we are closing issues here and tracking their status in a single tracking issue in the new repository.
Please open a new issue on winston-daily-rotate-file to continue the discussion.


broken stream after error

Bug Report
Current Behavior
After first catched error I cannot make second Api call. Only actions before first error match and trigger api call.
  action$.pipe(
    ofType(POST_CREDENTIALS),
    mergeMap(action =>
      apiCall
        .post('/api/users/login', action.credentials)
        .pipe(
          map(ajaxResponse => postCredentialsSuccess(ajaxResponse.response))
        )
    ),
    catchError(e => {
      return of(postCredentialsError(e));
    })
  );

export const postCredentialsError = error => ({
  type: POST_CREDENTIALS_ERROR,
  payload: error.xhr.response,
  error: true
});

Expected behavior
I would like to trigger action even if error occurs in previous api call
Environment

Runtime: [e.g. Node v10.5.0, Chrome v67.0.3396.99]
RxJS version: 6.2.1

same as https://github.com/ReactiveX/rxjs/issues/3815#issuecomment-395660527.
Once observable meets error, it is terminating condition of observable and no way to continue original stream. To prevent outer observable stops, inner observable should catch error.

Thank you!


Fetch {Cluster}Tasks using generated client

It seems like using the Lister to fetch ClusterTasks and Tasks results
in some flakiness when attempting to run the Task immediately after it's
created (as in clustertask.yaml). Using the Lister is likely faster, due
to caching, but if it means failed runs for just-created Tasks, that
speed isn't worth it.
Fixes https://github.com/tektoncd/pipeline/issues/1661
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[n] Includes tests (if functionality changed/added)
[n] Includes docs (if user facing)
[y] Commit messages follow commit message best practices

See the contribution guide for more details.

My only thought is wondering if we should be skipping the lister for more types, or maybe cluster tasks are just especially vulnerable?
Anyway
/lgtm
/approve
/meow space

My only thought is wondering if we should be skipping the lister for more types, or maybe cluster tasks are just especially vulnerable?

oh you included Tasks even. ive got nuthin


[JENKINS-8532] added workaround so that SCM Polling for Subversion wo…

…rks again, added logging instead of silently returning no SCM

In my debug Jenkins started by IntelliJ that worked, on the installation it didn't. The problem was finally fixed by enabling "Allow anonymous read access" therefore no fix required.


Some Enhancement Ideas that you should look into.

According to me, adding these enhancements can make your application way better than it is at this moment, and for a music hog like me, these features are pretty much necessary. Please look into them IF you have time :)
Allow the application to do/make -

Set as Ringtone
Allow to modify SD content (Delete, Rename Music from storage)
Auto Created Playlist (Last Added, Last Played, Most Played, Random Songs)

I'm going to close this issue since it's outdated and lists like this are hard to keep track of.
To respond to each point individually:

Setting a song as your ringtone seems like it could clutter the UI a bit -- I feel like people wouldn't change their ringtones that often. If you disagree, feel free to make a new issue for this.
Jockey has had Auto Playlists for a while per your request (although are temporarily broken in master. It'll be fixed before the next release).
I've made a separate issue (#75) for song editing since it was getting duplicated a lot.


test_stripe: Add remote server non-sponsorship E2E test.

First commit -- follow-up: https://github.com/zulip/zulip/pull/28196#issuecomment-1858211066

check what /billing/ says about the next renewal date and amount is better than checking the data structure for it.

Second commit:  Add remote server non-sponsorship E2E test.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Can you rebase this one following #28281? I suspect the tests may require fixture regeneration.

I rebased and tests run fine. No fixture regeneration was required.

Merged, thanks @prakhar1144! We can probably do a round of # nocoverage comment deletion soon.


Add message store() method

Summary

add message class and test.
add store() method.

Thank you for review @platfowner! now merging and beta version release for testing


feat: implement Prometheus metrics [WIP]

IMPORTANT: Please do not create a PR without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary

Specs:
Metrics

threat_datasets: Number of avaiable threat datasets. (Gauge)
teler_event: Number of incoming teler WAF events. (Counter, labels: rule & threat)
request_duration_seconds: Request duration times in seconds. (Histogram)

Note
Since there is no proposal for this, revisit inline TODOs and NOTEs that need to be reconsidered.

Proposed of changes
This PR fixes/implements the following bugs/features:

Bug 1
Bug 2
Feature 1
Feature 2
Breaking changes

How has this been tested?
Proof:

Closing issues
Fixes #
Checklist:

[ ] My code follows the code style of this project.
[ ] My changes successfully ran and pass linters locally (run make lint).
[ ] I have written new tests for my changes.

[ ] My changes successfully ran and pass tests locally.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

We're currently processing your upload.  This comment will be updated when the results are available.


Colour Palettes and Construction guidelines - Future colour font formats

I understand these may be free for remixing and use - and not for seeking people to submit additions.
But it would be neat to see the palettes, gradients, colour combinations used for these - as well as some of the guidelines the Emoji teams work to, when making future additions to the sets.
As for the font formats - will the upcoming Google colour font format, with its support for gradients - be used for generating from the non flat SVGs?  And is it possible the Windows team could adopt this, either as a replacement for the flat colour versions, or maybe as a toggle in settings?

Hey hey @mdtauk - good to see you enjoying the emoji! Just like the icons, we'll add some guidelines soon - just updating some stuff. You know how it goes...WIP and all that...haha.
Thanks for the feedback on the gradient font support, that is a really interesting idea.

... will the upcoming Google colour font format...

@mdtauk: What you're referring to isn't a Google specific format but is part of the OpenType font formation specification, developed jointly by Google, Microsoft and other contributors.

... will the upcoming Google colour font format...

@mdtauk: What you're referring to isn't a Google specific format but is part of the OpenType font formation specification, developed jointly by Google, Microsoft and other contributors.
Related: #16

Yes I know it's a joint effort by the opentype group.  But I think Google Fonts has been the most vocal in support and have implemented the Android 12 emojis with it.
I didn't mean to imply it was solely Google's endeavour

From the latest Windows insider builds, the emojis are moving to the new font format.


SolidDataset should implement DatasetCore

Search terms you've used
DatasetCore
Feature suggestion
SolidDatasets do not currently implement either the Dataset interface, nor the DatasetCore interface. This make it very difficult to use existing RDF libraries with SolidDatasets, since many of them expect DatasetCore. In a couple places in our application, we create a DatasetCore from the quads in a given SolidDataset manually, and it seems to continue to work just fine as both a DatasetCore and a SolidDataset. However, doing it manually does not seem like good practice. It would be nice if this library supported that transformation for us.
Expected functionality/enhancement
Ideally the SolidDataset interface would be an extension of the DatasetCore interface. All DatasetCore methods would be supported on SolidDatasets. I think this is the best developer experience, however, I don't think it is possible. SolidDatasets are supposed to be ImmutableDatasets, and DatasetCore explicitly requires mutation with add and delete. Even if implementing the full DatasetCore standard is impossible, it would be convenient to have support in SolidDataset for the immutable DatasetCore methods (like match and has).
A more practical solution would be a set of convenience methods that allow the developer to easily transform to and from an equivalent DatasetCore, perhaps using signatures similar to the one below:
function asDatasetCore(dataset: SolidDataset): DatasetCore {...}
function fromDatasetCore(dataset: DatasetCore): SolidDataset {...}

This would maintain the immutability of SolidDataset, while allowing developers to easily get a mutable DatasetCore copy they could use in libraries that expect a DatasetCore.
Actual functionality/enhancement
SolidDataset is a custom type defined by the Inrupt client library (ImmutableDataset) with no clear mapping or relationship to the DatasetCore RDF standard.
Use Cases

I would like to be able to use the Inrupt client library to fetch and deserialize a SolidDataset, but then use that dataset in a variety of other RDF search, traversal, matching, and reasoner libraries that expect a DatasetCore (i.e. clownface).
I would like to be able to use useful functions like match that are part of the DatasetCore specification on SolidDatasets.

It's not publicly documented (yet), but solid-client does actually include those! import { fromRdfJsDataset, toRdfJsDataset } from "@inrupt/solid-client";

Hiya @ianconsolata, yeah, you've certainly highlighted a known problem there, and explained it extremely well.
 (Technically RDF/JS isn't an official 'standard', but I know what you mean, i.e., for all intents and purposes it can certainly be considered one today in JavaScript-land).
But as you rightly point out, immutability was deemed to be even more important, and so we decided (reluctantly!) to break that contract (because immutability is so crucial a capability for all the state management systems used by the major client-side UI frameworks today (e.g., React, Vue, AngularJS)).
And so yeah, today solid-client no longer plays so nicely with all the existing RDF tooling out there, and so the to() and from() functions are the best option for now (unfortunately for you, and all the other RDF practitioners out there).
Ideally we would have first discussed with the RDF/JS community the possibility of updating the RDF/JS interfaces to offer explicit support for both mutable and immutable datasets. We were going to offer suggestions for such interface changes, but we never got around to that, as we just didn't have the time (and I've no idea how active the RDF/JS community is these days anyway, or whether they'd be interested in discussing such potentially major changes (which could take a long time to discuss and decide on, and then a further long time for implementations to be upgraded)).
But if you were interested in pursuing such a discussion with the RDF/JS community (with a view to RDF/JS interfaces supporting immutable datasets), then you'd certainly have our active support in that effort :) !

I think for now converting between the two is sufficient. I generally don't like mutable types, so now that I have a better understanding of what is going on I appreciate the separation. For now, SolidDataset seems like a perfectly valid alternative. It would be nice if it supported an immutable matches eventually though, i.e. one that returned a new SolidDataset, so that I don't have to convert just to query it. Unless there is some easy way to run more complex matches style RDF queries on SolidDatasets that I don't know about.


Another pull request deploy-playground.yml rename

Checkmarx One – Scan Summary & Details – 97fda6ee-6a9d-4c92-b200-fc61ef0823aa
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Privilege Escalation Allowed
/deploy-playground.yml: 31
Containers should not run with allowPrivilegeEscalation in order to prevent them from gaining more privileges than their parent process

CPU Limits Not Set
/deploy-playground.yml: 32
CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests

CPU Requests Not Set
/deploy-playground.yml: 32
CPU requests should be set to ensure the sum of the resource requests of the scheduled Containers is less than the capacity of the node

Container Running As Root
/deploy-playground.yml: 31
Containers should only run as non-root user. This limits the exploitability of security misconfigurations and restricts an attacker's possibilities...

Container Running With Low UID
/deploy-playground.yml: 31
Check if containers are running with low UID, which might cause conflicts with the host's user table.

Memory Limits Not Defined
/deploy-playground.yml: 31
Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than t...

Memory Requests Not Defined
/deploy-playground.yml: 31
Memory requests should be defined for each container. This allows the kubelet to reserve the requested amount of system resources and prevents over...

NET_RAW Capabilities Not Being Dropped
/deploy-playground.yml: 31
Containers should drop 'ALL' or at least 'NET_RAW' capabilities

Readiness Probe Is Not Configured
/deploy-playground.yml: 31
Check if Readiness Probe is not configured.

Seccomp Profile Is Not Configured
/deploy-playground.yml: 31
Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls

Service Account Token Automount Not Disabled
/deploy-playground.yml: 27
Service Account Tokens are automatically mounted even if not necessary

Image Pull Policy Of The Container Is Not Set To Always
/deploy-playground.yml: 31
Image Pull Policy of the container must be defined and set to Always

Image Without Digest
/deploy-playground.yml: 31
Images should be specified together with their digests to ensure integrity

Liveness Probe Is Not Defined
/deploy-playground.yml: 31
In case of an unresponsive container, a Liveness Probe can help your application become more available since it restarts the container. However, it...

Missing AppArmor Profile
/deploy-playground.yml: 23
Containers should be configured with an AppArmor profile to enforce fine-grained access control over low-level system resources

No Drop Capabilities for Containers
/deploy-playground.yml: 31
Sees if Kubernetes Drop Capabilities exists to ensure containers security context

Pod or Container Without Security Context
/deploy-playground.yml: 31
A security context defines privilege and access control settings for a Pod or Container

Root Container Not Mounted Read-only
/deploy-playground.yml: 31
Check if the root container filesystem is not being mounted read-only.

Fixed Issues

Severity
Issue
Source File / Package

Privilege Escalation Allowed
/deploy-playground.yml: 31

CPU Limits Not Set
/deploy-playground.yml: 32

CPU Requests Not Set
/deploy-playground.yml: 32

Container Running As Root
/deploy-playground.yml: 31

Container Running With Low UID
/deploy-playground.yml: 31

Memory Limits Not Defined
/deploy-playground.yml: 31

Memory Requests Not Defined
/deploy-playground.yml: 31

NET_RAW Capabilities Not Being Dropped
/deploy-playground.yml: 31

Readiness Probe Is Not Configured
/deploy-playground.yml: 31

Seccomp Profile Is Not Configured
/deploy-playground.yml: 31

Service Account Token Automount Not Disabled
/deploy-playground.yml: 27

Image Pull Policy Of The Container Is Not Set To Always
/deploy-playground.yml: 31

Image Without Digest
/deploy-playground.yml: 31

Liveness Probe Is Not Defined
/deploy-playground.yml: 31

Missing AppArmor Profile
/deploy-playground.yml: 23

No Drop Capabilities for Containers
/deploy-playground.yml: 31

Pod or Container Without Security Context
/deploy-playground.yml: 31

Root Container Not Mounted Read-only
/deploy-playground.yml: 31


Gmail Double Notifications

It seems like I am getting double notifications for G-mail messages.
For example, I get an e-mail, I see the notification but it shows it twice grouped together.
It seems like it MAY have something to do with Gmails "All inboxes" and "Inbox" because after I read the one from "Inbo" I still saw a 1 next to "All Inboxes", but I went into it and everything was read and there were no duplicates. So maybe it is sending a notification when it is put in "All Inboxes" and "Inbox"?
6.7.11 Fdroid

This is a bug I get with Gmail. I will edit to update if it happens with any other email providers

Here I'm getting TRIPLE notifications for every gmail message.
6.603 F-Droid, LineageOS 20 (Android 13)

Yeah I am now getting triple as well

I have the same issue

I'm getting the same thing!
I'm on stock android 14 on pixel fold and this is happening with all of my accounts, Gmail and non Gmail
Currently I have Gmail, AOL, outlook, 2 business emails with custom hosted domains, and yahoo
Also attached is my notification settings from Android and from k9, all the accounts have the exact same settings

Ok I think I might have resolved this, tell me if this fixes it for you guys.
I noticed the same issue on Thunderbird on desktop too.
I took one more look in G-Mail (Web).
Under settings > labels > system labels
Uncheck "show in imap" for the "Important, All Mail" lines.
Refresh your clients. They should disappear and hopefully you don't get duplicate notifications for those folders.
It may be worth disabling "Importance Markers" in "Inbox" settings menu on G-mail too. Personally I just use stars feature and this was an annoyance. To each their own.
I also set the Spam folder to show up in imap.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 28837f4, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 11578 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 5b9e80c.


Refactor huff lz

I was looking at issue #134. My knowledge of what the code is accomplishing is insufficient to correct the issue. However, I did fix a couple of typos and the construction process in the HuffLZ which I thought were worth committing.
I forgot to update the master branch with merged changes which created a merge conflict with the new name for BitStream. I was happy that GitHub chose to ignore the changes in the merge commit so they are not confusing the actual changes to the code base.

AdaptHuffTree rename is complete. Still need to fix class variable pointers in HuffLZ. Should have time tomorrow for this.

@DanRStevens,
What do you think of the following three lines:
HuffLZ::HuffLZ(BitStreamReader& bitStream) :
	m_BitStreamReader(bitStream),
	m_ConstructedBitStreamReader(), // Don't need to delete stream in destructor

I think this is the proper way to handle creating the HuffLZ class around an existing bitstream, but wanted to make sure it looked good to you.
I have compiled the code, but have not used it to actually read a HuffLZ compressed volume yet. I will do that before merging.
Thanks,
Brett

Ok, I removed the field in question.
I did not remove any of the constructors, nor address the order of constructor parameters. After taking a quick look, I think those are separate issues that should be addressed in their own PR. In particular, any changes there would relate to the compressed streams design, which we haven't fully fleshed out yet. Let's close this off meanwhile, and I'll add a separate issue with my notes on the other areas.

It looks like something we did has damaged the Huffman LZ decompression algorithm. The program executes without an exception, but the results appear partially mangled. It looks worse then just the file endings that we discussed earlier. I'll post the results in the forum.
-Brett

I did some more troubleshooting. Both x64 and x86 produce the same garbled results. Unpacking a version of sheets.vol that is not compressed produces proper results.
I switched back to the master branch of OP2Utility, but still had the same garbled results. So it looks like we broke this somewhere before this branch.
I reverted OP2Utility back to 7/28/2018 "Fix warnings produced when writing strings to map files and unknown tileGroup variable" After modifying OP2Archive to work with this version of OP2Utility, I was able to extract a proper version of sheets.vol. It looks like the error was added sometime between 7/28/2018 and before the current branch.
It may bear fruit to check for changes in both how VolFile calls the decompress code and any changes to the decompress code between then and now.
Brett

Nice work discovering that bug, and determining it was pre-existing. Sounds a bit like you were doing a manual git biset to narrow in on a range of commits where the error was introduced. This seems like additional justification to have more unit tests.
Given the error is pre-existing, do we go ahead and merge the current change set, or hold until the error is fixed. It seems like the proper thing to do in a large widely used repository, would be to fix the error first, before committing new code. However, for a small library, it may make sense to just keep moving forward, and fix things along the way. At the very least, there would be fewer merge conflicts that way.
I'll look into adding some additional unit tests.

After looking at this with fresh eyes, I realized the additional changes I had proposed in Issue #150 are actually quite simple, so I went ahead and did them.

All the changes look good. Thanks for taking the time to make them.
After merging the master into this branch, I tested by decompressing sheets.vol again. Everything checked out fine.
-Brett


Huge number of responses when WebConnectionWrapper.getResponse is overridden and webClient.getPage() is called

Created a WebConnectionWrapper and overridden getResponse() to see the count of responses and to ignore any 404 issues for .js or .img files.
When webClient.getPage(url) is called it is invoking getResponse more than 1000+ times for the below URL:
http://www.profuturo.mx/content/wps/portal/Grupo-Profuturo/Informacion-financiera
But on seeing the number of requests on chrome or any browser, it should be around 119. Is this expected because HtmlUnit is using Rhino Engine? Would we miss the webpage content if we try to parse it in parallel to getPage()

Sorry for working that late on this - looks like the page was changed and has new problems now.
Will close this - please open a new one if you still have problems (and you still use HtmlUnit ;-))


osu-lazer-bin: 2023.1008.0 -> 2023.1008.1

This commit upgrades the osu-lazer-bin package to version 2023.1008.1. It addresses an issue for multiplayer crashes. The releases page for this version can be viewed on GitHub here:
https://github.com/ppy/osu/releases/tag/2023.1008.1
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 261179 run on aarch64-darwin 1

1 package built

osu-lazer-bin


C NUL

Product and Version [VS/VSCode]:
OS Version [macOS/Windows/Linux]:
Live Share Extension Version:
Target Platform or Language [e.g. Node.js]:
What were you doing when you encountered the desync?
How often have you encountered desyncs?

Thanks for reporting this! Please refer to #2993

Closing this due to inactivity. Please reopen it if you’re still encountering the issue. Thanks!


Use logback for logging and add a log configuration

Logback because we use it (or log4j) for all our other projects. It is only in test scope. A logback configuration is provided to easily change it when needed.

test this please

No idea why or how, but this change seems to cause an OOME on the build during integration tests.

Debug here will enable a huge amount of logging... it's probably trying to buffer it all in heap.


Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.1.0) of this package:

Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
Requiring $ from atom is no longer supported. If you are using space-pen, please require $ from atom-space-pen-views. Otherwise require jquery instead: {$} = require 'atom-space-pen-views' or $ = require 'jquery' Add "atom-space-pen-views": "^2.0.3" to your package dependencies. Or add "jquery": "^2" to your package dependencies.
The atom.syntax global is deprecated. Use atom.grammars instead.

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.
If this package has been replaced by another package or functionality in core, please reply with this information.
See https://github.com/atom/atom/issues/6867 for more info. Thanks!

Fixed in v0.2.1. Please update.


Is Gen.chooseNum excluding part of the valid range of doubles?

Hi,
I'm using Gen.chooseNum(Double.MinValue, Double.MaxValue) in a generator, but it's causing the generator to fail at a high rate. Checking the source for chooseNum, it seems like chDbl is excluding doubles below zero in this line:
if (d < 0 || d > Double.MaxValue) r(None)
I think this is causing the high failure rate as it will try generating positive and negative numbers but filter out the negatives. Does this sound like a bug in chooseNum or is this the intended behaviour?
Ultimately I solved the problem by using arbitrary[Double] instead but still seems like something chooseNum should be able to do.
Many thanks!

This sounds like an issue. I'll take a look, thanks!

@matthewdooler Which version of ScalaCheck are you using? This code changed recently and it seems to be working for me on master. Here's the test I used:
import org.scalacheck._

case class Dbl(n: Double)
implicit val arbDbl: Arbitrary[Dbl] =
  Arbitrary(Gen.chooseNum(Double.MinValue, Double.MaxValue).map(Dbl(_)))

val p = Prop.forAll { (x: Dbl) => x == x }
p.check // + OK, passed 100 tests.

Please let me know if you can confirm that this is still broken (or works for you) on the newest release and/or master.

Thanks for checking. We're on 1.12.5 which is quite old, but all our property tests fail if we try upgrading to 1.13.2:
[info] DeferredAbortedSuite:
[info] Exception encountered when attempting to run a suite with class name: org.scalatest.DeferredAbortedSuite *** ABORTED ***
[info]   java.lang.IncompatibleClassChangeError: Implementing class
[info]   at java.lang.ClassLoader.defineClass1(Native Method)
[info]   at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
[info]   at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
[info]   at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
[info]   at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
[info]   at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
[info]   at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
[info]   at java.security.AccessController.doPrivileged(Native Method)
[info]   at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
[info]   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
[info]   ...
[error] Uncaught exception when running common.example.ExampleProperties: java.lang.IncompatibleClassChangeError: Implementing class
sbt.ForkMain$ForkError: java.lang.IncompatibleClassChangeError: Implementing class
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at common.example.ExampleProperties.<init>(ExampleProperties.scala:13)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
	at java.lang.Class.newInstance(Class.java:442)
	at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:468)
	at sbt.ForkMain$Run$2.call(ForkMain.java:296)
	at sbt.ForkMain$Run$2.call(ForkMain.java:286)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

That's another problem though (probably some sort of conflict with other dependencies, or scala version) so unless the cause is immediately obvious I'm happy for this to be closed since you're confident master works!

OK yeah, those issues probably stem from the fact that 1.13.2 isn't binary compatible with 1.12.5, meaning any code compiled against the old version will need to be recompiled/republished for your project.
Good luck! I'm fine with leaving this open until you can confirm the fix, but I'm also fine with closing it and reopening it if you later notice problems on the newer version.

I tried recompiling from scratch but no luck, so we'll have to find some time to have a proper look. I'll close this and reopen if we discover the bug still exists in the latest version :)


Using GoTrue library in Sveltekit gives this error at build time: GoTrue is not a constructor

Describe the bug
Using the GoTrue library in a sveltekit project (that uses vite) gives the following error when running npm run build:

GoTrue is not a constructor
TypeError: GoTrue is not a constructor

In development mode (npm run dev) it works correctly.
The issue doesn't come from the library because it works in other projects built with vuejs and webpack.
This issue  was first opened on sveltekit's project and considering that it's happening at build time, it was labeled as a vite's bug.
Reproduction
GitHub repo: https://github.com/ClaudiaGiv/sveltekit-tailwindcss-board
System Info
System:
    OS: Windows 10 10.0.19041
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 3.41 GB / 11.84 GB
  Binaries:
    Node: 14.17.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.14.13 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1023.0), Chromium (92.0.902.73)
    Internet Explorer: 11.0.19041.906
  npmPackages:
    @sveltejs/adapter-netlify: ^1.0.0-next.17 => 1.0.0-next.17
    @sveltejs/kit: next => 1.0.0-next.113
    svelte: ^3.34.0 => 3.38.2

Used Package Manager
npm
Logs
6:09:17 PM: Build ready to start
6:09:19 PM: build-image version: c6001ed68662a13e5deb24abec2b46058c58248a
6:09:19 PM: build-image tag: v3.9.0
6:09:19 PM: buildbot version: ec3023c261ea976fed2230c267a6d92f413f9260
6:09:19 PM: Fetching cached dependencies
6:09:19 PM: Starting to download cache of 159.1MB
6:09:21 PM: Finished downloading cache in 1.902516416s
6:09:21 PM: Starting to extract cache
6:09:26 PM: Finished extracting cache in 4.767463057s
6:09:26 PM: Finished fetching cache in 6.714003282s
6:09:26 PM: Starting to prepare the repo for build
6:09:26 PM: Preparing Git Reference refs/heads/master
6:09:27 PM: Parsing package.json dependencies
6:09:27 PM: Different build dir detected, going to use the one specified in the Netlify configuration file: '' versus '/' in the Netlify UI
6:09:27 PM: Different publish path detected, going to use the one specified in the Netlify configuration file: 'build' versus 'public' in the Netlify UI
6:09:27 PM: Starting build script
6:09:28 PM: Installing dependencies
6:09:28 PM: Python version set to 2.7
6:09:28 PM: Started restoring cached node version
6:09:31 PM: Finished restoring cached node version
6:09:31 PM: v16.3.0 is already installed.
6:09:32 PM: Now using node v16.3.0 (npm v7.15.1)
6:09:32 PM: Started restoring cached build plugins
6:09:32 PM: Finished restoring cached build plugins
6:09:32 PM: Attempting ruby version 2.7.1, read from environment
6:09:33 PM: Started restoring cached ruby version
6:09:33 PM: Finished restoring cached ruby version
6:09:35 PM: Using ruby version 2.7.1
6:09:35 PM: Using PHP version 5.6
6:09:35 PM: Started restoring cached node modules
6:09:35 PM: Finished restoring cached node modules
6:09:35 PM: Started restoring cached go cache
6:09:35 PM: Finished restoring cached go cache
6:09:35 PM: go version go1.14.4 linux/amd64
6:09:35 PM: go version go1.14.4 linux/amd64
6:09:35 PM: Installing missing commands
6:09:35 PM: Verify run directory
6:09:36 PM:
6:09:36 PM: ────────────────────────────────────────────────────────────────
6:09:36 PM:   Netlify Build
6:09:36 PM: ────────────────────────────────────────────────────────────────
6:09:36 PM:
6:09:36 PM: ❯ Version
6:09:36 PM:   @netlify/build 18.2.1
6:09:36 PM:
6:09:36 PM: ❯ Flags
6:09:36 PM:   baseRelDir: true
6:09:36 PM:   deployId: 6115399d96c5b100070e8a06
6:09:36 PM:
6:09:36 PM: ❯ Current directory
6:09:36 PM:   /opt/build/repo
6:09:36 PM:
6:09:36 PM: ❯ Config file
6:09:36 PM:   /opt/build/repo/netlify.toml
6:09:36 PM:
6:09:36 PM: ❯ Context
6:09:36 PM:   production
6:09:36 PM:
6:09:36 PM: ────────────────────────────────────────────────────────────────
6:09:36 PM:   1. build.command from netlify.toml
6:09:36 PM: ────────────────────────────────────────────────────────────────
6:09:36 PM:
6:09:36 PM: $ npm run build
6:09:36 PM: ><EMAIL_ADDRESS>build
6:09:36 PM: > svelte-kit build
6:09:37 PM: vite v2.3.6 building for production...
6:09:37 PM: transforming...
6:09:39 PM: warn - You have enabled the JIT engine which is currently in preview.
6:09:39 PM: warn - Preview features are not covered by semver, may introduce breaking changes, and can change at any time.
6:09:41 PM: (node:1456) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /opt/build/repo/node_modules/tslib/package.json.
6:09:41 PM: Update this package.json to use a subpath pattern like "./*".
6:09:41 PM: (Use `node --trace-deprecation ...` to show where the warning was created)
6:09:42 PM: ✓ 220 modules transformed.
6:09:43 PM: rendering chunks...
6:09:48 PM: .svelte-kit/output/client/_app/manifest.json                               3.29kb
6:09:48 PM: .svelte-kit/output/client/_app/error.svelte-c5a90755.js                    1.19kb / brotli: 0.57kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/index.svelte-b1056c44.js              1.76kb / brotli: 0.79kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/__layout.svelte-e52efd18.js           4.86kb / brotli: 1.50kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/board2.svelte-a2a62ef2.js             3.52kb / brotli: 1.26kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/register.svelte-d89f6332.js           5.24kb / brotli: 1.53kb
6:09:48 PM: .svelte-kit/output/client/_app/start-3789a8dc.js                           18.65kb / brotli: 5.73kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/board.svelte-ac5b5056.js              21.78kb / brotli: 3.82kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/board1.svelte-0e194a99.js             15.48kb / brotli: 4.24kb
6:09:48 PM: .svelte-kit/output/client/_app/chunks/board-45ce14ab.js                    0.61kb / brotli: 0.25kb
6:09:48 PM: .svelte-kit/output/client/_app/chunks/go-true-b1e0ebcb.js                  0.16kb / brotli: 0.14kb
6:09:48 PM: .svelte-kit/output/client/_app/assets/start-0826e215.css                   0.18kb / brotli: 0.11kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/login.svelte-96a7a7a6.js              2.88kb / brotli: 1.05kb
6:09:48 PM: .svelte-kit/output/client/_app/assets/pages/board2.svelte-ce4806e6.css     0.50kb / brotli: 0.18kb
6:09:48 PM: .svelte-kit/output/client/_app/assets/pages/board3.svelte-78437c54.css     0.23kb / brotli: 0.09kb
6:09:48 PM: .svelte-kit/output/client/_app/pages/board3.svelte-4e399f3e.js             20.55kb / brotli: 5.48kb
6:09:48 PM: .svelte-kit/output/client/_app/assets/pages/__layout.svelte-dac65d4e.css   27.61kb / brotli: 2.97kb
6:09:48 PM: .svelte-kit/output/client/_app/chunks/vendor-1963d08a.js                   101.20kb / brotli: 24.38kb
6:09:48 PM: vite v2.3.6 building SSR bundle for production...
6:09:48 PM: transforming...
6:09:49 PM: "flip" is imported from external module "svelte/animate" but never used in "src/routes/board2.svelte" and "src/routes/board3.svelte".
6:09:49 PM: ✓ 48 modules transformed.
6:09:49 PM: rendering chunks...
6:09:49 PM: .svelte-kit/output/server/app.js   110.03kb
6:09:49 PM: Run npm run preview to preview your production build locally.
6:09:49 PM:
6:09:49 PM: > Using @sveltejs/adapter-netlify
6:09:49 PM:  > .svelte-kit/output/server/app.js:7:7: warning: Ignoring this import because "node_modules/graphql/language/printer.js" was marked as having no side effects
6:09:49 PM:     7 │ import "graphql/language/printer.js";
6:09:49 PM:       ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
6:09:49 PM:    node_modules/graphql/package.json:9:2: note: "sideEffects" is false in the enclosing "package.json" file
6:09:49 PM:     9 │   "sideEffects": false,
6:09:49 PM:       ╵   ~~~~~~~~~~~~~
6:09:49 PM: > GoTrue is not a constructor
6:09:49 PM: TypeError: GoTrue is not a constructor
6:09:49 PM:     at file:///opt/build/repo/.svelte-kit/output/server/app.js:965:14
6:09:49 PM:     at ModuleJob.run (node:internal/modules/esm/module_job:175:25)
6:09:49 PM:     at async Loader.import (node:internal/modules/esm/loader:178:24)
6:09:49 PM:     at async prerender (file:///opt/build/repo/node_modules/@sveltejs/kit/dist/chunks/index7.js:80:14)
6:09:49 PM:     at async Object.prerender (file:///opt/build/repo/node_modules/@sveltejs/kit/dist/chunks/index7.js:312:5)
6:09:49 PM:     at async adapt (file:///opt/build/repo/node_modules/@sveltejs/adapter-netlify/index.js:33:4)
6:09:49 PM:     at async adapt (file:///opt/build/repo/node_modules/@sveltejs/kit/dist/chunks/index7.js:338:2)
6:09:49 PM:     at async file:///opt/build/repo/node_modules/@sveltejs/kit/dist/cli.js:654:5
6:09:50 PM:
6:09:50 PM: ────────────────────────────────────────────────────────────────
6:09:50 PM:   "build.command" failed
6:09:50 PM: ────────────────────────────────────────────────────────────────
6:09:50 PM:
6:09:50 PM:   Error message
6:09:50 PM:   Command failed with exit code 1: npm run build
6:09:50 PM:
6:09:50 PM:   Error location
6:09:50 PM:   In build.command from netlify.toml:
6:09:50 PM:   npm run build
6:09:50 PM:
6:09:50 PM:   Resolved config
6:09:50 PM:   build:
6:09:50 PM:     base: /opt/build/repo
6:09:50 PM:     command: npm run build
6:09:50 PM:     commandOrigin: config
6:09:50 PM:     environment:
6:09:50 PM:       - NODE_VERSION
6:09:50 PM:       - VITE_FAUNA_API
6:09:50 PM:       - VITE_FAUNA_KEY
6:09:50 PM:     publish: /opt/build/repo/build
6:09:50 PM:     publishOrigin: config
6:09:50 PM:   functionsDirectory: /opt/build/repo/functions
6:09:50 PM: Caching artifacts
6:09:50 PM: Started saving node modules
6:09:50 PM: Finished saving node modules
6:09:50 PM: Started saving build plugins
6:09:50 PM: Finished saving build plugins
6:09:50 PM: Started saving pip cache
6:09:50 PM: Finished saving pip cache
6:09:50 PM: Started saving emacs cask dependencies
6:09:50 PM: Finished saving emacs cask dependencies
6:09:50 PM: Started saving maven dependencies
6:09:50 PM: Finished saving maven dependencies
6:09:50 PM: Started saving boot dependencies
6:09:50 PM: Finished saving boot dependencies
6:09:50 PM: Started saving rust rustup cache
6:09:50 PM: Finished saving rust rustup cache
6:09:50 PM: Started saving go dependencies
6:09:50 PM: Finished saving go dependencies
6:09:50 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
6:09:50 PM: Creating deploy upload records
6:09:50 PM: Failing build: Failed to build site
6:09:50 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2
6:09:50 PM: Finished processing build request in 31.190567658s

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi!
I have the same problem but lib is dagre-d3.
It works normally in dev mode but when I build app the problem appear.
Does anyone have an ideia how to resolve that problem?

I sorted this out.
I used the solution of the issue #3356
In my case I imported dagre-d3 this way:
import * as dagreD3 from "dagre-d3/dist/dagre-d3"

I tested the repro with the latest SvelteKit and Vite version, and it seems to work for me. But I am able to reproduce the bug if I uncomment:
// export const auth = new GoTrue({
// 	APIUrl: NETLIFY_IDENTITY_URL,
// 	audience: '',
// 	setCookie: true
// });

With that said, this isn't a bug in Vite, but rather the bug happened during SvelteKit's adapt phase which runs the Nodejs code that cause the error, because running new GoTrue() is not compatible in NodeJS due do how Netlify bundled it (Netlify bundled gotrue-js for bundlers in mind).
There's two ways you can fix this:

ssr.noExternal: ["gotrue-js"]
or new GoTrue.default()

But also with all these, looks like GoTrue isn't meant to be used in Node in the first place (https://github.com/netlify/gotrue-js/issues/46), so perhaps you'd want to avoid calling new GoTrue() in the server-side code in the first place, which should fix this too.


rmg: 0.5.7 -> 0.6.5

Description of changes
Launches, though I again don't have any ROM dumps to test this with.
Couldn't get nixpkgs-update setup, so I just added a regular updateScript & used nix-shell maintainers/scripts/update.nix.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you :heart:, I really appreciate it


Can't open new tab

Hi,
Windows 10 Pro user here, when I Shift+Ctrl+t for a new tab I get the error message in ther picture here:

I'm using Hyper 1.4.8
Thanks

Hey @spences10 do you have any other plugins installed? Also could you double check the installed version, from the stack it looks like that might be coming from Hyper v2.0.2

Okke, I removed all the plug-ins and added them back in until I got the error.
It was when I added this one back in it gave that error
I'm in the latest of this package and hyper
Thanks :+👍

Can I leave this with you now @hharnisc?


behavior change: relay integration and proxy health check

the health check was doing the following

grid proxy api itself: reaching the gridproxy api e.g /farms /nodes to make sure the server is responding (there's a ping endpoint now too on the gridproxy)
random nodes connectivity to yggdrassil: by trying to proxy simple command like zos.system.version on nodes via the proxy

Now with the Relay integrated, nodes are reachable through the relay, and we removed the proxying features of ygg https://github.com/threefoldtech/tfgridclient_proxy/pull/292 so this will always fail in the current checks
So, let's keep the gridproxy api health check only and remove the nodes checks
https://github.com/threefoldtech/tf_operations/issues/1360

Verified.
with new twin relay changes, all functionality works fine.


studies-search GET/POST response

The studies-search POST call allows for searching by studyNames. Both the POST and GET call have in their response object name as ouput. I propose to rename those to studyName to make it more clear what name signifies.
I think this holds for many calls and not only the studies-search response.
e.g.
/programs: name -> programName
/programs-search: name -> programName

I believe this is covered by #171 which is fixed in pull #261

True that it is covered by #171 and pull #261 should have fixed all generic name fields. However, there are still some calls that have generic name fields in their response objects.
E..g. studies-search (GET/POST), programs-search, programs

Oh you are right, I fixed the internal model files, but not the example responses. Good catch!

Thanks Peter. Good I am still awake, just before my holidays start.
Please also check the test-server content, I guess that will also need to be updated.

the test-server is still on v1.2 and will not get any v1.3 changes until it is officially released.


remove 9.4 link and add 11 and 12

Links to pg 9.4 have now been removed from upstream.
Removing the links from our list and add 11 and 12 to the list

The removal of the entry matches the fact the the version is EOL and the YUM repos have been dropped. :+1:
On a related note, the final release of 9.5 will happen in 1 week after which PSQL 9.5 will become EOL. Should we remove the entry as part of this PR?

By the time the doc is published, 9.5 will be removed so I have removed the entry

https://github.com/ome/ome-documentation/issues/2172


[python] Let ingest accept additional_metadata: dict[str, Metadatum]

Dupe of https://github.com/single-cell-data/TileDB-SOMA/pull/2258, for testing tiledb:// test (and associated credentials)

tiledb:// + metadata test passed (though it took 5m17s, for pbmc-small; saw comparable slowness locally as well)
test_context.py::test_replace_config_after_construction is an unrelated failure; having a AWS_DEFAULT_REGION set seems to break it


added sanjay-kv.json file

Great collaboration 👍
@sanjay-kv please can you change your GitHub Org strapline to be different to EddieHub ... Collaboration 1st, Code 2nd! ...

Great collaboration 👍
@sanjay-kv please can you change your GitHub Org strapline to be different to EddieHub ... Collaboration 1st, Code 2nd! ...

This has been done.

@Panquesito7 (Sorry if the question is Novice to you) I was trying to understand the working of GitHub by contributing to this repo. Now the case is all check has been passed and I should be able to see the profile listed in linkfree.eddiehub.org right. For some reason I'm not able to see the profile yet.

@Panquesito7 (Sorry if the question is Novice to you) I was trying to understand the working of GitHub by contributing to this repo. Now the case is all check has been passed and I should be able to see the profile listed in linkfree.eddiehub.org right. For some reason I'm not able to see the profile yet.

You can only see it after your pr is merged... Thanks for your patience


Converted the project into Python3 and the README into Markdown

Converted the project into Python3 and the README into Markdown

apologies for missing this; thanks!


chore: improve the cli doc to avoid misunderstandings

As part of a poc for testing on our CI, I'm exploring Bruno's cli.
Based on this excerpt from the documentation:
Or run all requests in a folder:

`bru run folder`

I tried to run the following command:
bru run apps/backend/requests
where apps/backend/requests is the collection root folder. I got the following error:
You can run only at the root of a collection
Thinking I typed the command wrong, I tried several commands before realizing that the command is only valid for the sub-folders of a collection.
I therefore propose a change in the document in order to clarify this point for newcomers

I agree @LesageYann !
Many Thanks for improving the documentation


improve performance of nibbles helper functions

What was wrong?
The bytes_to_nibbles function had some un-necessary overhead.
How was it fixed?
Removed it by using a more streamlined approach.
Cute Animal Picture

I suspect this will have some measurable effect on trie performance.


Accessibility: aria-label on MudMenu

Feature request type
Enhance component
Component name
MudMenu
Is your feature request related to a problem?
For accessibility, all buttons need inner text that shows what the button will do (like Save), or an aria-label that describes what the button does. When MudButton renders, the inner text is wrapped in a span so the accessibility checkers, like lighthouse, say the "buttons do not have an accessible name". Luckily, with MudButton, one can add and aria-label attribute to the MudButton and it passes it to the html  element. So all is good, aside from the duplicate work of adding the aria-label AND the inner text.
However, with MudMenu, this trick does not work. the aria-label is put on the enclosing div (which is bad, a net negative) and not on the  element.  There doesn't seem to be a way to get it onto the button element.
Describe the solution you'd like
It'd be awesome if when I add aria-label to MudMenu it would put it on the button rather than on the enclosing div.
In general, better support for aria stuff would be very helpful
Have you seen this feature anywhere else?
MudTextField has a property to do this for Adornments, to solve this very problem. It is called AdornmentAriaLabel and the description on mudblazor.com says "For WCAG standards for buttons, an AdornmentAriaLabel can be added to use as the aria-label". We just need the exact same functionality for MudMenu
Describe alternatives you've considered
I'll do a pull request if that would help, but wanted to check with the team first
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

resolved by #8710


Set appropriate log levels for production/tests.

Expected behavior
We want console's stdout to show only really important informative messages, warnings and errors.
The rest of the message should be considered as Debug messages. written to log file but not shown in console unless running a test or declared as a flag beforehand.
limit the logging lib with log.SetLevel(logging.INFO) on either a test or a flag, change console log messages that are not critical for the user to see to .Debug instead Info/Warning.
Actual behavior
All messages are output to the console all the time.
Steps to reproduce the actual behavior
run any instance or test of the spacemesh.

is this issue still need to be done? If so I'd like to work on it.

Sure go ahead please. We need to make sure logging is set to debug across the whole project.
save only super critical errors and information as info/error.
please post here if you have any questions.

Now we set all log messages to Debug apart from app init messages.
I'm leaving this issue open for now to reference that we need to decide which messages we should present to the user.


Azure KeyVault Active Directory AcquireTokenAsync timeout when called asynchronously

AcquireTokenAsync does not work after the first active directory authentication token expires.
I'm trying to authenticate against Azure KeyVault using some code from the 'Hello Key Vault' sample application. I am able to authenticate and get a new token properly after the first 1 hour token expires using AcquireToken, but not AcquireTokenAsync.
var result = context.AcquireToken(resource, clientCredential); //works
var result = await context.AcquireTokenAsync(resource, clientCredential); //hangs

I opened up a question on Stack Overflow outlining my problem in more detail: https://stackoverflow.com/questions/32594642/azure-keyvault-active-directory-acquiretokenasync-timeout-when-called-asynchrono
However I think this may actually be a bug. The reason is that even calling .Result on the AcquireTokenAsync return object hangs, but using AcquireToken does not:
         var result = context.AcquireTokenAsync(resource, clientCredential);
         return result.Result.AccessToken; //hangs

         var result = context.AcquireToken(resource, clientCredential);
         return result.AccessToken; //works

I bet someone forgot a ConfigureAwait(false) and it never gets back to the right thread.

@akonyer please provide your authentication context code as well (minus all sensitive strings).

   public class AzureEncryptionProvider : IEncryptionProvider
   {
  public AzureEncryptionProvider()
  {
     _keyVaultClient = new KeyVaultClient(GetAccessToken);
     _keyBundle = _keyVaultClient.GetKeyAsync(_keyVaultUrl, _keyVaultEncryptionKeyName).GetAwaiter().GetResult();
  }

  private static readonly string _keyVaultAuthClientId = ConfigurationManager.AppSettings["KeyVaultAuthClientId"];

  private static readonly string _keyVaultAuthClientSecret =
     ConfigurationManager.AppSettings["KeyVaultAuthClientSecret"];

  private static readonly string _keyVaultEncryptionKeyName =
     ConfigurationManager.AppSettings["KeyVaultEncryptionKeyName"];

  private static readonly string _keyVaultUrl = ConfigurationManager.AppSettings["KeyVaultUrl"];

  private readonly KeyBundle _keyBundle;
  private readonly KeyVaultClient _keyVaultClient;

  public string DecryptString(string textToDecrypt, string algorithm = null)
  {
     algorithm = GetEncryptionAlgorithm(algorithm);
     var data = Convert.FromBase64String(textToDecrypt);
     var decrypted = _keyVaultClient.DecryptDataAsync(_keyBundle, algorithm, data).GetAwaiter().GetResult();
     return Encoding.UTF8.GetString(decrypted.Result);
  }

  public string EncryptString(string textToEncrypt, string algorithm = null)
  {
     algorithm = GetEncryptionAlgorithm(algorithm);
     var data = GetPlainText(textToEncrypt);
     var encrypted = _keyVaultClient.EncryptDataAsync(_keyBundle, algorithm, data).GetAwaiter().GetResult();
     return Convert.ToBase64String(encrypted.Result);
  }

  private async Task<string> GetAccessToken(string authority, string resource, string scope)
  {
     var clientCredential = new ClientCredential(_keyVaultAuthClientId, _keyVaultAuthClientSecret);
     var context = new AuthenticationContext(authority, null);
     var result = await context.AcquireTokenAsync(resource, clientCredential);
     return result.AccessToken;
  }

  private string GetEncryptionAlgorithm(string algorithm = "")
  {
     if (string.IsNullOrEmpty(algorithm))
     {
        algorithm = JsonWebKeyEncryptionAlgorithm.RSAOAEP;
     }
     return algorithm;
  }

  private byte[] GetPlainText(string text)
  {
     return Encoding.UTF8.GetBytes(text);
  }

   }

I'm not sure if you have read through the StackOverflow question, but I'll add some more information here as well.
I have discovered that this does not seem to happen from within a console application, but is reproducible in a MVC web application.  The second time I hit the same web endpoint, the program hangs on await context.AcquireTokenAsync.
In this sample, I am passing null as the second constructor to AuthenticationContext. This is to force no caching and request a new token each time. Otherwise, I had to wait an hour for the token to expire before I could reproduce the problem.
In production, I got this to work by using AcquireToken instead. So AcquireTokenAsync seems to be causing the issue. TokenCache.DefaultShared is passed into the AuthenticationContext in production to allow for caching.
A user on stack overflow believes I am causing a deadlock by not using "async" all the way down. He believes that calling ".GetAwaiter().GetResult();" in the constructor is part of the problem - but since I can not make the constructor asynchronous, this is a bit of a pain.

I'm facing same issue, I don't think this should be closed.
@devigned you said:

I bet someone forgot a ConfigureAwait(false) and it never gets back to the right thread.

Did you mean something in the SDK or in client code we are supposed to write?
Any chance to also have a sync version of the calls which at least saves one from trying to understand why the call would lock for eternity / help troubleshooting AD stuff (which doesn't provide very helpful messages).
For the AD part itself, when I manage to get task.Result I'm getting Microsoft.IdentityModel.Clients.ActiveDirectory.AdalServiceException: AADSTS65001: The user or administrator has not consented to use the application with ID 'MYCLIENTID'. Send an interactive authorization request for this user and resource.
This message could, let say, give the complete URI to go to and login so that "consent" is given, even after doing it succesfully (although it took me some time to peruse several pages in the portal + some google search to find correct URIs just to get the info I needed).
When those error messages are designed, people shouldn't assume that the recipient is going to have in-depth knowledge of Azure, Active Directory on azure, all the authentication API or REST end points, etc. so message should drive to next step for resolution in a more straight-forward manner.
I've also commented there:
https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/issues/248#issuecomment-230645154

The problem for me was that I was not using "async all the way down".
There were places I was using async/await, and then other places I was forcing it to be synchronous by calling .Result, which was causing a deadlock. I'm not 100% sure why the deadlock was happening, but using async all the day down did solve the issue.
It is good practice in general when you are working with async code.
Hopefully this helps you with your issue.

@akonyer thanks for feedback.
Then as I say the issue is that we don't have any alternative to the async method, and a Task exposed as a public API shouldn't deadlock client code, this seems totally backward.
There is probably lots to say about how async/await/task is done in C#, in F# running async workflow has never led me to such outcome of deadlocking calling thread.
I've tried to run the code in a background thread as well and it was doing the same kind of deadlocking, only after cancelling and running several ones it would somehow complete (now with the AD error message that I'm sure many people faced).
Ideas for the Azure team to help people using their APIs/SDKs:

provide synchronous calls which are guaranteed to not deadlock aside of async calls (so they can be tested for correctness of setup from a simple script file)
methods returning tasks shouldn't lead to deadlock, even if user doesn't do the "best practice", make .Result throw an exception or complete but no such thing as deadlock
get rid of "only AD is great" in all the APIs/SDKs, having something akin to .publishsettings seems like a reasonable alternative for those who don't want to deal with AD
provide more helpful error messages in API responses
provide only a single code sample per language, and very focused to the sequence of few calls, the profusion of samples and their questionable lack of focus is not helping end-users

I agree that it should not deadlock, and that there should be alternatives to having to use async/await.
Since the GetAccessToken method absolutely has to be async, I have simply labelled it as such in the method signature, but used no await within the method.
      private static async Task<string> GetAccessToken(string authority, string resource, string scope)       {          ILogger logger = new Log4NetLogger();          ClientCredential clientCredential = new ClientCredential(_keyVaultAuthClientId, _keyVaultAuthClientSecret);          AuthenticationContext context = new AuthenticationContext(authority, TokenCache.DefaultShared);          AuthenticationResult result = context.AcquireToken(resource, clientCredential);          return result.AccessToken;       }
This is what my GetAccessToken method looks like, and it is working without deadlocking. It is too bad though that you can not initialize the KeyVaultClient withouth an async callback.

@akonyer somehow I don't have AcquireToken available this is the version of the assembly I'm using:

Microsoft.IdentityModel.Clients.ActiveDirectory (3.10.305231913)

Am I using wrong version?
My code, I'm not using vault but the end result is the same as you had initially (deadlocking on .Result):
 let authenticate (settings: CloudSettings) =
    let authenticationContext =
      settings.ActiveDirectoryAuthenticationUrl
      |> AuthenticationContext

    let userCredential =
      UserPasswordCredential(settings.ActiveDirectoryLogin, settings.ActiveDirectoryPassword)

    authenticationContext.AcquireTokenAsync(settings.ServiceManagementUrl, settings.ActiveDirectoryClientId, userCredential)

Hmm, actually you are using a newer version than I am. I am using 2.25.305061457
I just updated to 3.10 to check, and sure enough, they have removed the non-async method.
I guess I am going to have to look into updating my code myself then. Seems likely that if I update I will run into the same problem as you.

I have had the same deadlock problem with version 3.13.7 and a web api using Entity Framework/SQL Always Encrypted.
I added ConfigureAwait(false) to the AcquireTokenAsync call and then it worked without any problems.
One way to test is to set the TokenCache to null in the AuthenticationContext constructor. Without ConfigureAwait(false) it deadlocks immediately but with ConfigureAwait(false) it works every time.


[Bug]: @stickyroll/react not available on CSB

Contact Details
<EMAIL_ADDRESS>What happened?
Should be available shouldn't it?
Version
2.x (Default)
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

They might be using use a cache, therefore the autocomplete might not pick it up yet, I'm not sure.
You can still install it by simply pressing enter or adding it manually to package.json.
It has been published the npm: https://www.npmjs.com/package/@stickyroll/react


Check coverage when a directory has no tests

Seems like having directories without tests makes the plugin ignore it.

it seems that isparta-instumenter-loader has been deprecated. we have to update deps definition and webpack config to use the new isparta-loader.
i'll look into this.

bug confirmed also with the new loader. it needs more investigation.

i've found the problem.
tests are executed via require.context method so *if there aren't .spec.js files that import the code you want to cover or  that piece of code (e.g. a component) is not imported in your application somewhere, you will not see it in the coverage output.

I think that doesn't happen in the ng2 version
El 23 jul. 2016 19:19, "Francesco Soncina"<EMAIL_ADDRESS>escribió:

i've found the problem.
tests are executed via require.context method so *if there aren't
.spec.js files that import the code you want to cover or that piece of
code (e.g. a component) is not imported in your application somewhere, you
will not see it in the coverage output.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/preboot/angular-webpack/issues/8#issuecomment-234729584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCZ1TpoeiJqmsApfUK1ct-B4A9OTcP-ks5qYk0dgaJpZM4HRpJy
.

@Foxandxss do you think #49 is an acceptable solution for this? can i also proceed to merge #48 ?

@Foxandxss i've found a generic way to include all the js files. i've updated the PR, let me know if we can merge #49 to close this issue.


Juan

Before reporting a bug, please see our FAQ in FAQ.md!
Description

Failed Step

More Details

Gracias


Explicitly close all STDIO streams when terminating

This simplifies termination logic and avoids keeping pending (and
unused) streams to the child process.
This should also fix the failing (timeout) tests on Travis.

Unrelated HHVM build error is being addressed in #44 :shipit:


Fix errors in SQLite sample code

The sample code for the SQLite README fails to compile due to a typo in a variable name, and failing to supply an id property for the INSERT.

The id field shouldn't be required in this case, because it has a default value. If you observe this behavior with the latest ORM version, could you please create an issue with it? Otherwise, please remove it from the docs.


Implement PROTOCOL url parsing as part of parse_url support

PROTOCOL parsing will consist of pulling out the protocol portion of the uri, such as https in https://www.google.com/q/cats. It will need to conform to the spark interpretation of what constitutes a hostname and not the RFC as there are discrepancies.
In some ways, the implementation appears naive, such as www.google.com:8080 results in a www.google.com protocol. In other ways, the implementation is more complex such as allowing a different character set in the protocol than in the rest of the uri.

Found some issues regarding the validation for URIs. This is being addressed in #1554


Publishing the container image directly to remote registry with -p:ContainerRegistry tag is slow

I have a couple of projects where I tried pushing the images directly to Azure Container Registry with -p:ContainerRegistry during dotnet publish as a part of my CI (To avoid hard dependency on docker cli). However, this approach took me almost 4 minutes compared to creating the docker images in the local docker daemon and pushing them manually to ACR in two steps (which took only 1 minute total). I will have around 26 such images I need to build and publish, it could take several minutes if I directly publish them into acr. Is this by design or am I missing something here?

Not exactly by design, and there is likely some improvement we can do here. We saw fairly unreliable uploads before we moved to uploading fairly small chunks and doing chunk retry, which improved reliability, but at some performance cost. We expect to tweak chunk size parameters and I expect we'll also try to build in better reporting of retries, to give us some clues about what is causing the slowness.

I'd also be interested in seeing the Dockerfile you're comparing from, and the binarylog from your attempts to use this tooling @asankaf - one thing I see folks accidentally hitting is shipping their app Self Contained. This happens implicitly when a Runtime Identifier is chosen (which we encourage here). The result of this is that you're sending a ~150MB layer instead of a much smaller layer with just your application's DLL + direct dependencies.

@baronfel I am not using a Dockerfile to build the images. Following are the two scenarios I tested on,

dotnet publish-c Release --no-build /t:PublishContainer -p:ContainerImageName=<image_name> -p:ContainerBaseImage=<base_img> -p:ContainerImageTag=18021 -p:ContainerRegistry=<acr_address>
Step 1: dotnet publish-c Release --no-build /t:PublishContainer -p:ContainerImageName=<image_name> -p:ContainerImageTag=18021 -p:ContainerRegistry=<acr_address>
Step 2: docker tag <image_name>:18021 <acr_address>/<image_name>:18021
Step 3: docker push <acr_address>/<image_name>:18021

Approach 1 took 4 mins (for 2 types of images)
Approach 2 took 1 min (for the same 2 types of images)

Thanks for the clarification - that's definitely not the kind of experience we want. @rainersigwald a couple thoughts that come to mind to give users some knobs to tweak:

[easy] environment variable to set chunk size?
[easy] environment variable to set chunked/non-chunked uploads?
[easy] environment variable to set parallel/sequential uploads of chunks
[hard] sliding-scale chunk uploads that increase in size over time until they start erroring out, backing off of that to whatever the local maxima is?

We've got knobs for all of these now, so closing until/unless we get more specific perf issues.