[GOBBLIN-315] Fix shaded avro is used in LineageEventBuilder

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/GOBBLIN-315

Description

[x] Here are some details about my PR:

a shaded guava Maps from avro-1.8 is imported in LineageEventBuilder by mistake.

Tests

[x] My PR does not need testing for this extremely good reason:

No logic change.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@htran1 Please review.


Update README.md

Improved grammar

Thanks @agriyakhetarpal for the changes 👍🏻

Thanks @agriyakhetarpal for the changes 👍🏻


AM2315 is not AM2315C sensor

(by email, abbreviated )
I am trying to use your library to interface with the ASAIR AM2315C sensor. I got the correct "AM2315_ADDRESS" which I updated into the header file & seems it recognize the i2c &  pullup 4.7k is also done. But its showing "AM2315_ERROR_CHECKSUM"  Can you please help me out for the same ?

I am using esp8266 dev board & supplied 5v to sensor & did pull up 4.7k using that same 5v
Cable lengths from sensor to i2c is not more than 6-8inch
If i comment out that crc check return statement from the header file it says ok but temperature shows a 320.0 static value & humidity shows nothing. Note that temperature value dose not change though I increase or decrease temperature.

I already run the i2c scanner & found the different address that mentioned at your header file & I updated same address. Then it started saying crc error. If i use different address it says sensor not found. So i am confident here that my setup finds the i2c address & sensor itself

i found this i2c address 0x38 using i2c scanner. So i applied same to the library header.

https://www.adafruit.com/product/5182
Here it is mentioned AM2315C is a different one from the AM2315.
https://github.com/RobTillaart/DHT20 might work for as it also has fixed 0x38 address (same sensor different package?)

From AHT20 datasheet

from DHT20 datasheet

look pretty similar!

Created https://github.com/RobTillaart/AM2315C

@RobTillaart thanks for your help. Its sorted using the DHT20 library. Many thanks

@fuzonmedia
Thanks for the support!


[AIRFLOW-249] Refactor the SLA mechanism

Hello
Please have a look at this patch addressing the concerns I have observed on the current SLA mecanism :
https://issues.apache.org/jira/browse/AIRFLOW-249
I did some tests and I'm confident about that patch but I think it needs some additionnal testing.
Let me know if something needs to be reworked.
dud

Hey @dud225 thanks! The sla stuff is indeed in need of some code love :). I really would like to see some unittests for this as it is close to the core of the scheduler and this is the area where everyone gets a bit nervous when changes are happening.
Next to to that, a bit more fundamental, relying on tasks here is probably not the best way forward. We are processing per dag and your approach would consider all tasks first, this can lead to operational issues like waiting for locks etc. That would need to be turned around.
Small nit: please correct your commit message (mechanism)

Codecov Report

Merging #1601 into master will increase coverage by 0.03%.

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   64.05%   64.08%   +0.03%
==========================================
  Files         120      120
  Lines        8412     8407       -5
==========================================
  Hits         5388     5388
+ Misses       3024     3019       -5

Impacted Files
Coverage Δ

airflow/jobs.py
74.33% <ø> (+0.61%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c4414...ff939ab. Read the comment docs.

Hi @dud225
I wanted to see if you were still interested in taking a crack at this. If I don't hear back in a few days, I'll close this. You are welcome to reopen it however.

Closing for now. Please reopen once you have updated the PR.


Examine HDF5 format

@bartaelterman @stijnvanhoey

@adokter has uploaded a HDF5 file with obsolete structure in the repo. Might be worth to use it for testing purposes, e.g. with https://github.com/h5py/h5py
The new format is documented here

I've uploaded a new example which will closely resemble the operational profile. One thing that will still likely change is the ordering of the datasetXX subfolders in the hdf5-tree.

@adokter I don't seem to find a lot of metadata in these files. Is that correct? For instance dataset1/data1/what seems to be empty, so I'm not sure what the values mean.

You can use the h5dump command to list the structure of the hdf5 file. If you use HDFView GUI, you will find the what folder to be empty, because attributes do not show up by default. You have to do a  Show properties on the folder.
 Functions to extract the metadata/data are written as testcase in the notebook.
However, I'm just wondering why the individual files are all so small, which seems a drawback of using hdf5, having the capability of using with very large datasets.  It connects to the discussion of collecting the data in a dbase or not. As individual files are so small, the creation of download-service or the ability to make queries will be an iteration over a lot of files when we only store metadata in a dbase.
I quickly checked, and maybe it could be interesting to think about some aggregation? In the notebook (last section), an aggregation to daily level is performed and the compliance with pandas provides an easy (daily) query. At the same time, doing this effort, we could just opt to put the data in a dbase.

The main reason for using ODIM hdf5 is that its the standard data exchange format at the meteorological datahubs, we simply need to conform to that specification if we want to integrate the bird product generation at the datahub.
The processing is a simple file in - file out (so the source data is large, but the bird product is very small)

Thanks for clarifying and I certainly do not want to question the original hdf5-file fomat. It is an important condition that should be taken into account.
In function of the data-products (download request, services) for the users, there are different options. I'm wondering if it would be most useful to put all the data and metadata in a dbase for the download service or only the metadata as suggested in issue #4? In the latter situation, when a query is provided by a user, it would result in collecting data from a high number of small hdf5-files. What would you suggest?

I think having a dbase with all the data that can be queried would be very handy, but the decision also depends on feasibility, time and resources we have at the moment. Arguments against it are:

it adds an extra component, so extra work
it needs to be maintained
data will likely be reprocessed once in a while, and replacing a simple directory tree with new files is likely easier than updating a dbase

In an earlier discussion @peterdesmet suggested a directory tree and a service that shows what's available is therefore the more feasible option. But a dbase would be handier, because it's more flexible and you don't have to deal with a multitude of files anymore (which is a problem that remains, even if you aggregate to days).


How to Implement Caching for Specific Tables ?

Hello,
I am currently using the GORM cache plugin and would like to know how to implement caching for specific tables only. Is there a way to configure the plugin to cache queries or results for designated tables while excluding others?
Any guidance or examples would be greatly appreciated!
Thank you!

Any update on this? It would be great if we can do this. Or are there other ways to cache in gorm now?

Really need this feature


Fix escape problems in the branch selector

Fix #25865

Can we ship this PR.

Backport needed?

If a branch named aa#b, should that be encoded as aa%2311 or not?

If a branch named aa#b, should that be encoded as aa%2311 or not?

Yes.

Backport needed?

I am not sure about it but it was reported before the release of 1.20 stable version.

As per https://github.com/go-gitea/gitea/issues/26088, backport is needed.


XQueryTree

I need support. I am trying to get the list of open windows via XQueryTree for hours now, but i don't find out how to iterate over the children result array.
That's my code so far:
var ffi = require('ffi');
var ref = require('ref');

var window = ref.types.ulong; //maybe uint?
var windowPtr = ref.refType(window);
var windowPtrPtr = ref.refType(windowPtr);

var xlib = ffi.Library('libX11', {
    ...
    XQueryTree: ['int', ['pointer', window, windowPtr, windowPtr, windowPtrPtr, uintPtr]],
    ...
});

...
var children = ref.alloc(windowPtrPtr);
var numberOfChildren = ref.alloc(uintPtr);
xlib.XQueryTree(display, rootWindow, root, parent, children, numberOfChildren);
numberOfChildren = numberOfChildren.readInt32LE(0);
console.log("Number of top level windows: " + numberOfChildren);

// How to iterate over the children?

You should probably check out ref-array! https://github.com/TooTallNate/ref-array


Sync VSO - GitHub.

Sync VSO - GitHub.
npm package version 0.5.4.

Hi @ignatvilesov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Vilesov Ignat (Akvelon)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Make LicenseeTask cacheable

How does the test  success checking for UP_TO_DATE work without CacheableTask?

The up-to-date mechanism is about the task not re-doing work when re-executed. The cache is orthogonal to that. It memoizes the output based on the inputs and never actually runs the task. A test for this would enable the cache (it may be on by default now), invoke a clean between the two builds, and then see the task report itself as FROM_CACHE when invoked a second time.


Add support for Building Scene Layer (BSL) OGC I3S standard

Esri Contribution: Adds support for OGC I3S Building Scene Layer (BSL) in CesiumJS.
Co-authored-by: Anton Smirnov<EMAIL_ADDRESS>Co-authored-by: Maxim Kuznetsov<EMAIL_ADDRESS>Co-authored-by: Tamrat Belayneh<EMAIL_ADDRESS>This PR adds a new functionality to support an OGC Indexed 3D Scene Layer (I3S) 1.3 : Building Scene Layer (BSL) type. The PR also adds a new I3S Building Scene Layer – Cesium Sandcastle application showcasing BSL consumption of a BIM data in CesiumJS. The PR is largely based on extending the original contribution to PR #9634 supporting I3S 3D Object and IntegratedMesh Scene Layers.

PR Description
This PR adds a new functionality to support an OGC Indexed 3D Scene Layer (I3S) 1.3 : Building Scene Layer (BSL) type. The I3S Building Scene Layer – Cesium Sandcastle application showcases BSL consumption of BIM data for Turanga Library in Christchurch (NZ) in CesiumJS. The PR is largely based on extending the original contribution to https://github.com/CesiumGS/cesium/pull/9634.

Find here a running version of I3S Building Scene Layer - Cesium SandCastle show case.
Below are overviews detailing changes brought about by this PR on both UI and Engine level.
UI Changes Overview

Application creates I3S data provider and adds it as a primitive data type to Cesium Viewer
I3S BSL Explorer UI is implemented as Cesium widget and is located @ /packages/widgets/Source/I3SBSLExplorer
I3S BSL Explorer widget implementation follows MVVM pattern and uses knockout js:
Model is created as I3S data provider in the application
View is represented by js file I3SBSLExplorer.js, defines html elements and data binding between the elements and ViewModel
ViewModel is represented by I3SBSLExplorerViewModel.js, creates ViewModel based on I3S data provider and handles the following user events:
selecting top layer for exploring
checking/unchecking layers and sublayers visibility
expanding/collapsing BSL tree view
To display I3S Explorer widget the showcase application passes two arguments to Cesium.I3SBSLExplorer – id of the container html element where the widget is planned to be displayed and I3S data provider

List of files added/modified:
Apps/Sandcastle/gallery/
    I3S Building Scene Layer.html
    I3S Building Scene Layer.jpg
packages/widgets/Source/
    I3SBSLExplorer/
    I3SBSLExplorer.css
    I3SBSLExplorer.js
    I3SBSLExplorerViewModel.js
    widgets.css – added import url of the I3SBSLExplorer widget styles (I3SBSLExplorer.css)
Engine Changes Overview
High-level structure of changes:
Scene layer initialization became dependent on the layer type ("Building", "3DObject" and "IntegratedMesh" layer types are supported). Common 3D Scene Layer initialization is not changed.I3S Layer class still represents a single user-visible layer: 3D Object or Integrated Mesh.
When a Building Scene Layer is initialized, it accomplishes the following:

It processes the [Building Scene Layer resource] (https://github.com/Esri/i3s-spec/blob/master/docs/1.8/layer.bld.md) of an I3S dataset, by creating the hierarchy of sublayers and loading statistics summary.
Each I3S Sublayer represents either a group of sublayers or a user-visible layer (I3S Layer), a 3D Scene Layer resource is requested for each I3S Layer.
I3S Data Provider stores the collection of all I3S layers in the scene (to control the life cycle of tilesets) as well as the collection of I3S sublayers (to manage sublayers and layers visibility).

Transcoding changes:

If requested, when creating an I3SDataProvider the user has now a new option enableFeatureFiltering to enable displaying geometries by I3S features against the default displaying by I3S nodes. By default, enableFeatureFiltering is disabled for Common 3D Scene Layer, but enabled for Building Scene Layer. When the enableFeatureFiltering option is enabled, we add EXT_mesh_features and EXT_structural_metadata extensions into a glTF document to force CesiumJS to create Cesium 3D Tile Feature for each feature in a node.
A new option, adjustMaterialAlphaMode is added to enable features transparency by adjusting the alpha mode of their material definition. By default, it is disabled for Common 3D Scene Layer, but enabled for Building Scene Layer. When the adjustMaterialAlphaMode option is enabled, we separate each geometry into two mesh primitives depending on whether the vertex color has transparency or not. Then the alpha mode in the material definition is updated for each mesh primitive based on its transparency.
A new option, applySymbology is added to enable displaying outlines if they are defined by the I3S layers' symbology. By default, it is disabled for Common 3D Scene Layer, but enabled for Building Scene Layer. When applySymbology option is enabled, we add CESIUM_primitive_outline extension into a glTF document to display outlines for 3D objects in the layers.
A new option, calculateNormals, is added to enable normals calculation if they are missing. By default, it is disabled for Common 3D Scene Layer with textures (if textureSetDefinitions details are present), but enabled for Common 3D Scene Layer without textures and Building Scene Layer.When the calculateNormals option is enabled, we generate the normals buffer with the flat normals per face for each geometry without the vertex normal attribute. Flat normals are calculated based on the vertex position attribute. The vertex normal attribute may be stripped out from the geometry buffer to reduce the size of the buffer. This is allowed by glTF specification where it states: "When normals are not specified, client implementations MUST calculate flat normals". However, the current CesiumJS implementation doesn’t automatically calculate flat normals for glTF 2.0 yet , which leads to unlit visualization for 3D objects.

About color saturation:

I3S material colors properties (baseColorFactor, emissiveFactor etc.) are assumed to be in the same color space as the textures, most commonly sRGB while in glTF they are interpreted as linear. The color vertex attribute is also assumed to be Standard RGB (sRGB space).We convert colors from sRGB color space to linear color space during transcoding I3S to glTF.

About feature attribute driven filter:

When the enableFeatureFiltering option is enabled (enabled by default for BSL) and any I3S node geometry contains features, there is now a new functionality to apply a filter driven by feature attribute values. A filter may contain one or multiple attributes and each attribute may specify one or multiple values. When a filter is applied, a 3D feature object will be hidden if its value for at least one attribute in the filter doesn't match to any attribute value of the filter. A filter can be applied either to specific I3S Layer or to all I3S layers in the scene.
When a filter is applied, it accomplishes the following: I3S Layer stores the copy of the filter attributes and requests the root node and all children of the root node to apply the filter. If any node is not visible or even not loaded yet, then the filter is applied once the content model is created and becomes ready. We then load an I3S Field for each attribute in the filter and set the visibility for each Cesium 3D Tile Feature based on the filter and the feature attribute values. We hide the whole model for I3S Node content while filtering is in progress to apply the filter for all features at once.

About transparency:

The color vertex attribute of the geometry buffer may contain transparent colors for any vertex. The interpretation of these alpha values depends on the alphaMode property of the material definition. The alphaMode value should be set to "BLEND" to render transparent objects. On the other hand, the blending mode for the fully opaque colors (100% alpha) also creates the effect of translucency. Processing the transparency in I3S layers is optional and can be configured by the adjustMaterialAlphaMode option (for BSL it is enabled by default). When the adjustMaterialAlphaMode option is enabled, the blending alpha mode is set for each geometry with the transparency in the color attribute.

About symbology:

Each I3S layer may define symbology details for rendering. Generally, it may specify the existence and the color for outlines (edges) and the material color. Symbology may be defined for all data in the layer or for particular 3D features, based on attribute values (unique or ranges).
When the applySymbology option is enabled, we parse data for the symbology during layers loading. As the result of parsing, we may have a list with specific symbology per feature and the default symbology for all other features. The outlines color from the default symbology is set as the default value for outlineColor option for 3D Tileset. Then we use additional processing during transcoding I3S to glTF.

List of files added/modified :
packages/engine/Source/
    Core/
      srgbToLinear.js
      - Added support for conversion from sRGB color space profile to linear color space profile
      Purpose: Helper function to fix color saturation
    Scene/
      I3SDataProvider.js
      - Added support for BSL structure per the OGC I3S standard
      Purpose: To display 3D BIM models and access the BSL sublayers hierarchy
      - Added support for BSL statistics
      Purpose: To provide the field names and values for BSL which may be used for the attribute driven filter UI
      - Added support for the generic feature attribute driven filter
      Purpose: To filter the drawn elements of all scene layers
      - Added new initialization option: enableFeatureFiltering
      Purpose: To provide an ability for common 3D Scene Layer to use the attribute driven filter
      - Added new initialization option: adjustMaterialAlphaMode
      Purpose: To set the 3D objects transparency based on the vertices color data
      - Added new initialization option: applySymbology
      Purpose: To define and show outlines for 3D Scene Layer based on symbology details in I3S Layer data
      - Added new initialization option: calculateNormals
      Purpose: To generate the buffer with flat normals per face if normals are stripped out from I3S geometry.
      - Added Support for BSL structure, BSL statistics, generic feature attribute driven filter.
      - Added new initialization option: enableFeatureFiltering, adjustMaterialAlphaMode, applySymbology and calculateNormals
    I3SField.js
      - Added support for binary attribute data with values stored in objectIds property
      Purpose: Some attribute data for Turanga_Library BSL stores values in objectIds property (not in attributeValues) which caused runtime errors
      - Added validation for actual and expected binary buffer size
      Purpose: Some attribute data for Turanga_Library BSL looks corrupted, the size of the binary buffer doesn't correspond to attributeStorageInfo which caused runtime errors
      - Added support for binary attribute data with values stored in objectIds property
      - Added validation for actual and expected binary buffer size
    I3SGeometry.js
      - Added support for extensions and extensionsUsed properties of the glTF root object
      Purpose: To add information about features into a glTF asset
      - Added support for 3D objects transparency
      - Fixed material color saturation by converting sRGB colors in I3S data to linear color space profile
I3SLayer.js
      - Added support for BSL hierarchy of layers: Scene -> Sublayer -> ... -> Layer versus common 3D SL hierarchy: Scene -> Layer
      Purpose: To adjust the URL to the 3DSceneLayerResource and manage the layers visibility
      - Added support for the generic feature attribute driven filter
      Purpose: To filter the drawn elements of a layer
      - Added support for I3S symbology
      Purpose: To display the outlines for 3D objects
      - Added support for BSL hierarchy of layers
      - Added support for the generic feature attribute driven filter
      - Added support for I3S symbology
    I3SNode.js
      - Added support for the generic feature attribute driven filter
      Purpose: To filter the drawn features of a node
      - Added support for I3S symbology
      Purpose: To display the outlines for 3D objects
      - Added support for the generic feature attribute driven filter
      - Added support for I3S symbology
    I3SStatistics.js
      - Added support for loading and parsing BSL statistics
      Purpose: To provide the field names and most frequent values for BSL
    I3SSublayer.js
      - Added support for BSL structure per the OGC I3S standard
      Purpose: To provide the BSL sublayers hierarchy and manage the layers visibility
    I3SSymbology.js
      - Added support for symbolization defined in I3S Layer data
      Purpose: To provide the outlines and material details for the Layer
    Workers/
      decodeI3S.js
      - Added support for EXT_mesh_features and EXT_structural_metadata glTF extensions with the feature index data
      Purpose: To add information about features into a glTF asset
      - Added support for 3D objects transparency
      - Fixed vertex color saturation by converting sRGB colors in I3S geometry to linear color space profile
      - Added support  for CESIUM_primitive_outline glTF extensions with the generated outlines indices
       Purpose: To display the outlines for 3D objects
      - Added support for flat normals calculation if vertex normals are stripped out from I3S geometry
       Purpose: to enable lighting effects for I3S datasets without normals

@Tamrat-B 👏 🙏
Really appreciate the work by you and the team.
We'll chat with @lilleyse and @ggetz to find some cycles for a code review.

Thanks @Tamrat-B! Exciting! We'll take a review pass of this before the end of the week.

Thanks @ggetz. Looking forward to it.

@ggetz please have a look for the requested changes based on your reviews.

Thanks for the updates @Tamrat-B! We'll take another pass soon.
@lilleyse Let us know if you have any thoughts or suggestions on performance.

@ggetz As to the question regarding performance, we believe there are two main things that affect performance: applySymbology option affecting I3S layer initialization and using a detailed terrain provider (such as ArcGIS elevation provider) seems to affect both initialization and navigation. With disabled terrain and outlines the performance looks quite good.
Unfortunately, if we were to use the default CesiumTerrainProvider provider there is a severe mismatch with the Turanga model and half of it will be submerged underground and is not a good option (though performance with quantized mesh looks good).
As per the open issue: https://github.com/CesiumGS/cesium/issues/8481, it looks currently in CesiumJS the one or two globe picks per frame seems to slow down Cesium for height map based detailed terrain providers like ArcGIS. There is also some community discussions around same topic here. Note: as suggested in the work around of that issue setting Cesium.ScreenSpaceCameraController.enableCollisionDetection to false seems to help, which we can set in the sample.

@ggetz updated based on latest review. Thanks.

Thanks @Tamrat-B! I was able to sync up with @lilleyse offline. He agrees that for the scope of this PR, the performance is acceptable.
I have a few comments after testing.

Would it be possible to start in "Overview" mode? I think it's a bit confusing that nothing appears on screen to start.

I also noticed in the example that the following is logged to the console for the Sandcastle example. I understand the first message, but would it be possible to pass the geoid service providers like is done in the other I3S examples?

Point layer LocationPoints is skipped as not supported.
No Geoid Terrain service provided - no geoid conversion will be performed.

Given that we're already showing the metadata property values in the info box, can we skip the additional console.log(${fieldName}: ${fields[fieldName]}); when a feature is selected?

@ggetz we've resolved all the issues you brought up in the latest reviews (1-3 above). Thanks!

Thanks @Tamrat-B!
I did tweak the naming of "I3SBSL*" to "I3SBsl*" to be consistant with out naming conventions, and added an additional bullet in CHANGES.md for the updates to the widget package.
Assuming CI passes, this should be good to merge.

🎉 Thanks again @Tamrat-B and team!

Thanks much @ggetz @pjcozzi @lilleyse. Looking forward for users using this workflow!

Hello, I found information for a console while running the sandcastle example I3S Building Scene Layer.

After further analysis, it was found that the problem was I3SDataProvider.fromUrl, and there was indeed a definition of LocationPoints in the Turanga Library.

At the same time, I also found that the example I3S Building Scene Layer is an upgrade to I3S 1.3, but in the introduction of I3SDataProvider.fromUrl it says "Currently supported I3S versions are 1.6 and 1.7/1.8 (OGC I3S 1.2)".

Is this problem normal, or is there another way to fix it? However, there is no negative impact on the operation of the sample at this time.


Cannot find module 'archiver' just after installation

From @bussiere on February 16, 2016 11:7
I'am on ubuntu 14.04 and nodejs4
ussiere@dagobert:~/WorkspaceSafe/anansimobile$ ionic start anansiMobile blank
module.js:328
    throw err;
    ^

Error: Cannot find module 'archiver'
    at Function.Module._resolveFilename (module.js:326:15)
    at Function.Module._load (module.js:277:25)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/ionic/node_modules/ionic-app-lib/lib/utils.js:3:16)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:417:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Module.require (module.js:354:17)

Copied from original issue: driftyco/ionic#5468

From @cyprusglobe on February 16, 2016 15:40
@bussiere can you run ionic info
should look something like this
Your system information:

Cordova CLI: 5.4.1
Ionic Version: 2.0.0-alpha.57
Ionic CLI Version: 2.0.0-beta.17
Ionic App Lib Version: 2.0.0-beta.8
ios-deploy version: 1.8.4
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v5.4.1
Xcode version: Xcode 7.2.1 Build version 7C1002

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Reference: #810

I have the same issue since a long time. I even reported in on Ionic official forum. Any help possible ?


Extended changelog, group by tags

Add the possibility to group by tags on the extended log just like here https://github.com/angular/angular.js/blob/master/CHANGELOG.md
Use this kind of commit messages to grep tag names :
chore(release): v1.4.0 codename(jaracimrman-existence)

#32

I love the idea of grouping by tag, but would prefer that the grep pattern be made optional. Ie, if the commit message or tag annotation matches the grep, then use it to decorate the tag, but otherwise just use the tag name.


A way to disable user registration

Hello.
I need a way to disable the user signup. The registration of new users will be done by the admin of the system, and the new users can't signup by themselves
It's possible to have a env var to disable the signup mutation?

I think we can implement this. :D I'll try latter. I've now the same use case. Thanks.

Thanks @mihazs, PR: #9


Remove the PRAGMA setting of journal_mode which attempted to revert to the default journal_mode

Description
The intention of the PRAGMA was to revert the databse back from WAL, however, this pragma is creating problems when multiple instances of continue are open
Checklist

[x] The base branch of this PR is dev, rather than main
[x] The relevant docs, if any, have been updated or created

Good catch 👍


Feature/connector version api

Currently supporting: Conviva, Nielsen and Comscore

Hi @wvanhaevre,
Maybe I come a bit late to the game but why don't we use the same approach as we use for THEOplayer core? That is, the version accessible through a global variable THEOplayerVersion.
That way we cannot have any runtime failures to look up the version (for example due to SPM vs Cocoapods differences).

Hi @wvanhaevre, Maybe I come a bit late to the game but why don't we use the same approach as we use for THEOplayer core? That is, the version accessible through a global variable THEOplayerVersion.
That way we cannot have any runtime failures to look up the version (for example due to SPM vs Cocoapods differences).

Would be ok for me, but on the core this is a value that requires a manual update for every release. It felt like an easy source for mistakes. Certainly when knowing that for every SDK release we  currently also release all connectors.

For Core this is done in a release script I think. (see scripts/node/src/release-tool.ts line 235)

To be reworked to also support SPM


Add ed25519 support

Type of change

New feature

Description
Due to some considering NIST curves insecure and
Golang having ed25519 native support, there was
not a reason for not implementing in Fabric.
Tests cases for ed25519 were also added. Since
ed25519 key derivation is not called by any
function, I left as a TODO.
As I am working on ed25519 support for node fabric-gateway,
I needed to add ed25519 support for cryptogen also,
aiming to pass tests with certificates containing
ed25519 keys. Since the node fabric-gateway tests
generate their crypto material with cryptogen, I
adapted cryptogen to support ed25519 keys.
Additional details
Some tests concerning ed25519 key generation and certificate parsing
were added.
Related issues

I generally support this idea, and am in favor of it, but unfortunately adding support for ed25519 in a safe manner is more complex than just adding the code for generating signatures and verifying them.
If you could atomically and instantly upgrade all nodes of a Fabric network to support ed25519 then there wouldn't have been any problem at all.
But Fabric nodes may be upgraded at different times, and some nodes might be offline or unreachable and then afterwards be reachable and online again and these nodes will receive the ed25519 signatures and they will reject them.
On the other hand, the nodes that were upgraded, will not reject them, and you will have a fork in the blockchain.
The key problem is that we need a way for Fabric validation to understand that "until a certain point in the blockchain, all ed25519 signatures are invalid" and "starting from a certain point in the blockchain, all ed25519 signatures are valid".
In Fabric, this is done using the capabilities feature.  Essentially, you "mark" in the channel config a certain configuration property and then the nodes know when to use that property and when not to use it.

Aside from my comment above, the PR is missing integration tests that generate ed25519 crypto material, and run a network and transact to ensure everything is good.

Incidentally, have you checked that the verification takes care of
https://datatracker.ietf.org/doc/html/rfc8032#section-8.4
We had to do this manually for ecdsa

Incidentally, have you checked that the verification takes care of
https://datatracker.ietf.org/doc/html/rfc8032#section-8.4
We had to do this manually for ecdsa

It seems that golang has already implemented it:
https://github.com/golang/go/blob/4e79f06dac712d35d67d72777dae6df6d8c97888/src/crypto/ed25519/ed25519.go#L220
In previous versions they even had a comment about preventing signature malleability:
https://github.com/golang/go/blob/go1.15/src/crypto/ed25519/ed25519.go

@johannww On ed25519 support for node fabric-gateway... I'm sure you already know the signing implementation is entirely pluggable. The client application can supply its own (ed25519) signing implementation and the API doesn't need to have an implementation built in. However, I would be quite happy to include this in the API. Just note that there need to be implementations in all three client languages (Go, Type/JavaScript and Java).

Ok i understand this is still work in progress. So please tag me once you feel this is ready.
Take into account that it will take quite a while for this to be merged, and also even more time until this will be included into any release, because if it will go to any release it will be to Fabric v3.0

One important issue:
I am implementing Ed25519 support for fabric-gateway using the code in this pull request as my Hyperledger Fabric. I created the crypto-material by setting field PublicKeyAlgorithm to ed25519, instead of ecdsa as here:
https://github.com/johannww/fabric-gateway/blob/81f5ee44f37f7148500f1039e5b33bd4f17d8f4d/scenario/fixtures/crypto-material/crypto-config.yaml#L41-L45
This generated ed25519 TLS keys for the peers. When running the scenario-test, only the java-gateway failed in a scenario with ed25519 TLS keys, due to the library netty (see the issue). I see 2 possible ways to go from here, regarding changes to fabric and/or gateway:

Disable ed25519 certificates for TLS explicitly and prevent cryptogen from generating ed25519 TLS certificates.
Ignore Java limitation and issue a warning when errors related to the grpc and netty happen. Count on netty developers to implement ed25519 support soon.
Any other suggestions?

When running the scenario-test, only the java-gateway failed in a scenario with ed25519 TLS keys, due to the library netty (see the issue).

I noticed this JDK issue, which says TLS support for EdDSA signatures was added in Java 16:
https://bugs.openjdk.org/browse/JDK-8254709
Any chance that it worked with Java 17?

I see 2 possible ways to go from here, regarding changes to fabric and/or gateway:

Disable ed25519 certificates for TLS explicitly in fabric and prevent cryptogen from generating ed25519 TLS certificates.
Ignore Java limitation and issue a warning when errors related to the grpc and netty happen. Count on netty developers to implement ed25519 support soon.
Any other suggestions?

I think I would be happy to proceed with only Java clients not currently able to establish TLS connections to peers that use Ed25519 keys. There is precedent for certain crypto only being supported by certain client, such as Idemix. This is clearly a bug outside of our control and should get fixed at some point.

@johannww what's the status of this? is this still work in progress?

From my perspective it is ready.On 23 Dec 2022, at 08:16, yacovm @.***> wrote:
@johannww what's the status of this? is this still work in progress?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@johannww I'm not a maintainer of this repository so I don't know if there is any other reason this PR has not been reviewed, but it does show as having merge conflicts with the main branch that need to be resolved.

Thanks for resolving the conflicts.
@yacovm Could you take another look at this one?

Thanks for resolving the conflicts.
@yacovm Could you take another look at this one?

I want to merge this PR very much, as eddsa has additional benefits beyond having another signature algorithm - for example it has a much faster threshold signature algorithm than ECDSA.
I'm a bit overloaded this week and the next, but I will try to find some time.

For the fabric-gateway, I think it is better to wait for the release 3.0. It seems that a lot has changed (ubuntu docker images/fabric-tools does not have go binary anymore). The main ed25519 implementations are done, but I will wait for the gateway to catch up to Fabric 3.0 to offer the pull request.

For the fabric-gateway, I think it is better to wait for the release 3.0. It seems that a lot has changed (ubuntu docker images/fabric-tools does not have go binary anymore). The main ed25519 implementations are done, but I will wait for the gateway to catch up to Fabric 3.0 to offer the pull request.

I don't really understand the motivation for waiting for Fabric v3, and why there was no desire to include this in the Fabric v2.5 LTS release. What is the blocker to both reviewing and delivering this PR?

@johannww I tried to test your pull request with the recent release of fabric-gateway v1.3.0 (@bestbeforetoday ) which added support for Ed25519 signer implementations but I had no success. Here is what I did:
I used the asset-transfer-basic from fabric-samples repository to test. I mainly used the default settings. The only thing I changed was in the file fabric-samples/test-network/organizations/cryptogen/crypto-config-org1.yaml:
PeerOrgs:
  - Name: Org1
    Domain: org1.example.com
    EnableNodeOUs: true
    Template:
      Count: 1
      SANS:
        - localhost
    Users:
      Count: 1
      PublicKeyAlgorithm: ed25519

I used the following commands (inside the test-network folder) to create a channel and deploy it:
export FABRIC_CFG_PATH=$PWD/../config/
export CORE_PEER_TLS_ENABLED=true
export CORE_PEER_LOCALMSPID="Org1MSP"
export CORE_PEER_TLS_ROOTCERT_FILE=${PWD}/organizations/peerOrganizations/org1.example.com/peers/peer0.org1.example.com/tls/ca.crt
export<EMAIL_ADDRESS>export CORE_PEER_ADDRESS=localhost:7051
export CORE_VM_DOCKER_ATTACHSTDOUT=true

./network.sh down
./network.sh up createChannel -c mychannel
./network.sh deployCC -ccn basic -ccp ../asset-transfer-basic/chaincode-go -ccl go

After deploying the channel, I compiled and ran the assetTransfer application from fabric-samples/asset-transfer-basic/application-gateway-go/assetTransfer.go folder. In the initLedger step it fails with the following error:
failed to submit transaction: rpc error: code = Aborted desc = failed to endorse transaction, see attached details for more info.

check if creator is a valid certificate - access denied: channel [mychannel] creator org [Org1MSP]: could not validate identity's public key algorithm: Ed25519 is not supported.

Could you please help me out here if I am missing some configuration?

@mkhattat, I don't have much experience with the test network, but you should look here in the config.tx file. You should replace "V2_0" for "V3_0", because ed25519 is, for now, a fabric 3.0 feature. This might change, as discussed here in this pull request.

@mkhattat Did you have any luck getting the asset-transfer-basic sample to with with the Fabric configuration change suggested by @johannww above?
One other thing to note is the hash expectations of different signature algorithms, documented here.

Note that the Sign implementations have different expectations on the input data supplied to them.
The ECDSA signers operate on a pre-computed message digest, and should be combined with an appropriate hash algorithm. P-256 is typically used with a SHA-256 hash, and P-384 is typically used with a SHA-384 hash.
The Ed25519 signer operates on the full message content, and should be combined with a NONE (or no-op) hash implementation to ensure the complete message is passed to the signer.

By default the client API applies a SHA-256 hash to the message to create a message digest, and that message digest is passed to the signer. This is the desired behaviour for an ECDSA signer, which operates on a pre-computed digest. The Ed25519 signer computes the digest as part of the signing operation so needs to receive the complete message bytes.
To use an Ed25519 signer, it is not sufficient to only provide an Ed25519 signing implementation as an option to Connect. You must also provide the WithHash option with a NONE hash implementation. This causes the unaltered message bytes to be passed to the Ed25519 signing implementation instead of a pre-computed digest.

@hyperledger/fabric-core-maintainers Now that Fabric v3 is the next scheduled release from the main branch codebase, what is the blocker to this PR being reviewed and merged? This submission has been open for approaching 2 years so it would be good to make some kind of decision on what is to be done with it.

Complementing the @bestbeforetoday  request, let me clarify the importance of this pull request for me and Hyperledger Fabric. I implemented the code in this pull request for a Brazilian Government project I work for. Brazil's public-key infrastructure does not allow NIST curves anymore. The first option was to adopt the Brainpool curves, but Go did not implement it. Thus, we opted to implement ed25519 support and offer this pull request.
Generally, I believe that supporting ed25519 can expand Hyperledger Fabric's adoption for similar cases. I guess that there are many other valid incentives. For instance, the Brazilian CBDC pilot is using Hyperledger Besu. Consider that, as I believe it is in your and the community's best interest to evaluate this pull request.

Thanks for not giving up on this PR. I did a superficial pass and gave some comments.
Please rebase on top of latest master and let's also have @ale-linux and @adecaro  and @denyeart  take a look at this.

By the way, what about TLS? Have you tried spinning up a node with TLS certificates containing ed25519 keys? I am sure it should be possible as we don't do anything special in our TLS stack regarding keys, but I would like to ask that regardless.

By the way, what about TLS? Have you tried spinning up a node with TLS certificates containing ed25519 keys? I am sure it should be possible as we don't do anything special in our TLS stack regarding keys, but I would like to ask that regardless.

Testing with Ed25519 TLS was mentioned in this comment above. The only issue mentioned was an issue with Java client applications due to a bug / limitation in the Netty library used by gRPC-Java.

By the way, what about TLS? Have you tried spinning up a node with TLS certificates containing ed25519 keys? I am sure it should be possible as we don't do anything special in our TLS stack regarding keys, but I would like to ask that regardless.

Testing with Ed25519 TLS was mentioned in this comment above. The only issue mentioned was with Java client applications due to a bug / limitation in the Netty library used by gRPC-Java.

oh I totally forgot about it, I even replied to the comment :-)
I still concur with Yacov from the past:

Generally, as a rule of thumb - Fabric core sets the standard, and the clients track the Fabric core, and not the other way around.

@johannww likely because other changes have been merged in the meantime but this PR is showing as having merge conflicts that need to be resolved. You might need to rebase your change on the main branch and force-push an updated commit. Hopefully then @yacovm can review.

I can review but I think it's also good if @adecaro and @ale-linux will both take a look :-)

@bestbeforetoday I guess I will have to open a pull request in fabric-lib-go also. The deleted bccsp folder seems to be the only problem.

I rebased on main branch again. Notice that my bccsp modifications were moved to the fabric-lib-go vendor folder but the changes were not accepted at fabric-lib-go repo yet. A pull request was opened there.

@hyperledger/fabric-core-maintainers Please can somebody review hyperledger/fabric-lib-go#29 so this PR can be completed?

@johannww Now that hyperledger/fabric-lib-go#29 has been been merged, I guess this PR needs updating to pull in the new fabric-lib-go dependency version?

@yacovm @denyeart @adecaro @ale-linux this PR is now building successfully against the BCCSP updates delivered in hyperledger/fabric-lib-go#29. Can you re-review?

@johannww I just wanted to say thank you for sticking with this pull request. I acknowledge that it has taken a  very long time to fully review it, but this is indeed on our list for the upcoming v3.0 release.
Do you have any interest in adding ed25519 support to fabric-ca for certificate issuance?

I have just detected an error in the integration test's chaincode deploy: error. I get the following message: "binary is the only supported type", but my chaincode is "golang" type. I am working on it.

@denyeart You're welcome. I remember. I tried to add ed25519 to the fabric-ca previously but stumbled into a problem with cloudfare cfssl support for ed25519: https://github.com/cloudflare/cfssl/pull/1097#issuecomment-1332834508.
This seems to be solved and merged. I should take a look into it.

ok it looks good to me, let's have @ale-linux or @adecaro also review it.

ok it looks good to me, let's have @ale-linux or @adecaro also review it.

How long do we wait for a review before merging?

ok it looks good to me, let's have @ale-linux or @adecaro also review it.

How long do we wait for a review before merging?

I talked to @adecaro the other day and he confirmed he will take a look so that we can get this in for v3.0... I do think it is valuable to have one of the original MSP authors take a look.

@denyeart you're welcome! Thank you also for reviewing big pull request.
@bestbeforetoday thank you for ensuring that this pull request remained active throughout this period.
@yacovm thank you for all the reviews and hints given.


Installing new version fails

I get these errors belo when trying to install the new version of the game maker on the new version of Ubuntu. Apparently at least part of it is either because of [bdist_wheel] or because of the python package termcolor (that is a separate error message which I didn't copy here). Whatever I tried I couldn't get to install with either python 3.8.3, 3.8.0 or 3.7.2. I also tried on two Linux distributions, Ubuntu 20.04 and Linux Mint 20. Any hint? This is the first of several error messages I get.
ERROR: Command errored out with exit status 1:
command: /home/dan/.virtualenvs/lean-game/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-msmlfhh9/fire/setup.py'"'"'; file='"'"'/tmp/pip-install-msmlfhh9/fire/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-cu0ppvct
cwd: /tmp/pip-install-msmlfhh9/fire/
Complete output (92 lines):
running bdist_wheel
The [wheel] section is deprecated. Use [bdist_wheel] instead.
running build
running build_py
creating build
creating build/lib
creating build/lib/fire
copying fire/parser_fuzz_test.py -> build/lib/fire
copying fire/init.py -> build/lib/fire
copying fire/test_components_test.py -> build/lib/fire
copying fire/inspectutils_test.py -> build/lib/fire
copying fire/helptext.py -> build/lib/fire
copying fire/trace_test.py -> build/lib/fire
copying fire/custom_descriptions.py -> build/lib/fire
copying fire/inspectutils.py -> build/lib/fire
copying fire/test_components_py3.py -> build/lib/fire
copying fire/test_components_bin.py -> build/lib/fire
copying fire/fire_import_test.py -> build/lib/fire
copying fire/core_test.py -> build/lib/fire
copying fire/core.py -> build/lib/fire
copying fire/parser_test.py -> build/lib/fire
copying fire/value_types.py -> build/lib/fire
copying fire/main_test.py -> build/lib/fire
copying fire/parser.py -> build/lib/fire
copying fire/docstrings_test.py -> build/lib/fire
copying fire/completion_test.py -> build/lib/fire
copying fire/fire_test.py -> build/lib/fire
copying fire/docstrings.py -> build/lib/fire
copying fire/completion.py -> build/lib/fire
copying fire/decorators_test.py -> build/lib/fire
copying fire/decorators.py -> build/lib/fire
copying fire/formatting_windows.py -> build/lib/fire
copying fire/main.py -> build/lib/fire
copying fire/test_components.py -> build/lib/fire
copying fire/testutils.py -> build/lib/fire
copying fire/testutils_test.py -> build/lib/fire
copying fire/formatting.py -> build/lib/fire
copying fire/trace.py -> build/lib/fire
copying fire/helptext_test.py -> build/lib/fire
copying fire/interact.py -> build/lib/fire
copying fire/custom_descriptions_test.py -> build/lib/fire
copying fire/formatting_test.py -> build/lib/fire
copying fire/docstrings_fuzz_test.py -> build/lib/fire
copying fire/interact_test.py -> build/lib/fire
creating build/lib/fire/console
copying fire/console/init.py -> build/lib/fire/console
copying fire/console/console_pager.py -> build/lib/fire/console
copying fire/console/console_attr_os.py -> build/lib/fire/console
copying fire/console/encoding.py -> build/lib/fire/console
copying fire/console/platforms.py -> build/lib/fire/console
copying fire/console/files.py -> build/lib/fire/console
copying fire/console/text.py -> build/lib/fire/console
copying fire/console/console_attr.py -> build/lib/fire/console
copying fire/console/console_io.py -> build/lib/fire/console
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-msmlfhh9/fire/setup.py", line 46, in
setup(
File "/home/dan/.virtualenvs/lean-game/lib/python3.8/site-packages/setuptools/init.py", line 145, in setup
return distutils.core.setup(**attrs)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/dan/.virtualenvs/lean-game/lib/python3.8/site-packages/wheel/bdist_wheel.py", line 259, in run
self.run_command('install')
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/dan/.virtualenvs/lean-game/lib/python3.8/site-packages/setuptools/command/install.py", line 61, in run
return orig.install.run(self)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/command/install.py", line 557, in run
self.run_command(cmd_name)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/dist.py", line 984, in run_command
cmd_obj.ensure_finalized()
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/cmd.py", line 107, in ensure_finalized
self.finalize_options()
File "/home/dan/.virtualenvs/lean-game/lib/python3.8/site-packages/setuptools/command/install_lib.py", line 17, in finalize_options
self.set_undefined_options('install',('install_layout','install_layout'))
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/cmd.py", line 290, in set_undefined_options
setattr(self, dst_option, getattr(src_cmd_obj, src_option))
File "/home/dan/.pyenv/versions/3.8.3/lib/python3.8/distutils/cmd.py", line 103, in getattr
raise AttributeError(attr)
AttributeError: install_layout
ERROR: Failed building wheel for fire

Progress. I was finally able to install fire and termcolor in Mint 20. Now the only error that I still get when trying to install is:
Installing collected packages: Lean-game-maker
  Running setup.py develop for Lean-game-maker
    ERROR: Command errored out with exit status 1:
     command: /home/dan/.virtualenvs/leanGame-380/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/dan/Lean-game-maker/setup.py'"'"'; __file__='"'"'/home/dan/Lean-game-maker/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /home/dan/Lean-game-maker/
    Complete output (30 lines):
    running develop
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/dan/Lean-game-maker/setup.py", line 17, in <module>
        setup(
      File "/home/dan/.virtualenvs/leanGame-380/lib/python3.8/site-packages/setuptools/__init__.py", line 145, in setup
        return distutils.core.setup(**attrs)
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/dist.py", line 984, in run_command
        cmd_obj.ensure_finalized()
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/cmd.py", line 107, in ensure_finalized
        self.finalize_options()
      File "/home/dan/.virtualenvs/leanGame-380/lib/python3.8/site-packages/setuptools/command/develop.py", line 56, in finalize_options
        easy_install.finalize_options(self)
      File "/home/dan/.virtualenvs/leanGame-380/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 311, in finalize_options
        self.set_undefined_options(
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/cmd.py", line 287, in set_undefined_options
        src_cmd_obj.ensure_finalized()
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/cmd.py", line 107, in ensure_finalized
        self.finalize_options()
      File "/home/dan/.virtualenvs/leanGame-380/lib/python3.8/site-packages/setuptools/command/install_lib.py", line 17, in finalize_options
        self.set_undefined_options('install',('install_layout','install_layout'))
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/cmd.py", line 290, in set_undefined_options
        setattr(self, dst_option, getattr(src_cmd_obj, src_option))
      File "/home/dan/.pyenv/versions/3.8.0/lib/python3.8/distutils/cmd.py", line 103, in __getattr__
        raise AttributeError(attr)
    AttributeError: install_layout
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/dan/.virtualenvs/leanGame-380/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/dan/Lean-game-maker/setup.py'"'"'; __file__='"'"'/home/dan/Lean-game-maker/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

Finally figured it all out! The problem was an outdated setuptools. I did pip3 install --upgrade setuptools and then everything worked well.


[YouTube Downloader] YTD chokes on MKV files

Extension
https://www.raycast.com/vimtor/youtube-downloader
Description
When attempting to download a file that was originally uploaded as an MKV (I think), the YTD extension fails.
Steps To Reproduce
I'm on macOS Sonoma 14.4.1 (23E224) running Raycast v1.72.1. I have the current version of the YouTube Downloader.

Attempt to download this video.
Notice that the video download completes but produces an error: "Output format mp4 is not available"

Current Behaviour
Attempting to download this video:

...Results in an error: "Output format mp4 is not available"

The extension probably should not be showing the MP4 formatted files in the Format dropdown if that format is not natively available, OR the extension should be able to convert MKV files to MP4s.
Expected Behaviour
The extension should be able to handle MKV-formatted files, ideally by presenting them in the file format download list.

Hi @chrismessina!
Sadly, this is a known issue. The problem is related to the new ffmpeg version and the library we are using to process the videos.
Check out the temporary solution here: https://github.com/raycast/extensions/issues/12110#issuecomment-2089490625

This was fixed by https://github.com/raycast/extensions/pull/12583
@raycastbot close this issue


Crash on Android

Hello,
I'm trying to run node-sass on Android. npm install seems to work fine but when I run ./node_modules/.bin/node-sass, it crashes with a segfault:
WARNING: linker: /data/data/com.termux/files/home/go/src/github.com/mattermost/platform/webapp/node_modules/node-sass/vendor/android-arm-48/binding.node has text relocations. This is wasting memory and prevents security hardening. Please fix.
Segmentation fault

NPM version (npm -v): 3.10.10
Node version (node -v): v6.10.1
Node Process (node -p process.versions):

{ http_parser: '2.7.0',
  node: '6.10.1',
  v8: '5.1.281.95',
  uv: '1.11.0',
  zlib: '1.2.8',
  ares: '1.12.0',
  modules: '48',
  openssl: '1.0.2k' }

Node Platform (node -p process.platform): android
Node architecture (node -p process.arch): arm
node-sass version (node -p "require('node-sass').info"):  It crashes.
npm node-sass versions (npm ls node-sass<EMAIL_ADDRESS>(I can also reproduce on master.)

Android isn't a supported platform

Maybe you could make that more explicit by adding an os key in package.json then?

@Rudloff I managed to build node-sass on my android/termux. See http://blog.akehir.com/2017/05/building-node-sass-libsass-python.html for how to do it on your end.
At the moment I'm investigating, if it's possible to build the binary automatically for android and providing it to node-sass (see sass/node-sass#1960)


⚠ Bofrost.lu has degraded performance

In 7543355, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2697 ms

Resolved: Bofrost.lu performance has improved in 072d5e4 after 9 minutes.


Find a better solution for string interpolation

Currently we interpolate strings by splitting them into pieces. This does not work well across different langauges and may lead us into a bad place if we continue to do it. We should find a better solution for interpolation variables and other DOM elements into strings.
Consider:

off the shelf solutions
if we want to just bulk out our basic library for now

Originally posted by @dexturr in https://github.com/vegaprotocol/frontend-monorepo/pull/1126#discussion_r953628599

My vote goes to https://www.i18next.com/. I mean, I should wait for your research.

Mine too, not that I have any bias or preformed expectation while I wrote this ticket 😈

Probably use the exsiting function we have but support some form of string interpolation & react component injection to prevent smelly code from poliferating


Saving changes in the grid

Hello,
Is it possible that after I change a cell, I will be able to press CTRL+S right away, without hitting on Enter? It's not very comfortable.

When I'm editing a field, in order to apply the change to the database, I need to hit Enter, so the field will be applied in the grid and then ctrl+s to apply the change to the database.
In similar too, that I currently switched from, I could hit ctrl+s right away, so field was applied to the grid and then whole row to the database.
Hope it's more clear now.

Good point.
It will work with CTRL+S and CTRL+ALT+S shortcuts.


Edit text inputs like in this image

Hi! Thank you for this awesome library!
How can I achieve a form like the image below? Especially the text inputs are what I wonder about. Is there a widget for it or any examples?
Or it's just a concave shape that I then have to add an input inside?
https://raw.githubusercontent.com/Idean/Flutter-Neumorphic/master/medias/samples/sample_form.png

Found the example here:
https://github.com/Idean/Flutter-Neumorphic/blob/master/example/lib/samples/form_sample.dart

Yes :) and it's juste a emboss stadium shape with an edit inside !


Add application trigger

This pull requests adds the functionality to switch power plans when an application starts or stops.
New configuration items have been added for:

Application process name (e.g. 'notepad.exe')
Power plan to switch to at application start
Power plan to switch to at application exit

Note that this functionality requires that the app be given administrator privileges.

Hi!
First off, amazing work! Happy to see that my code is still useful after all this time. Unfortunately I'll not be merging the PR at the moment for two reasons:

I don't feel like making the app admin only as I generally don't like giving admin permissions to apps. Also, I'm not quite sure how the requireAdministrator plays together with MSIX/AppX "container" / if it's possible to have based-on-settings admin privileges, etc.
As of right now I don't have the time (#23)  to rework the packaging pipeline so even if 1) wasn't an issue I'd still not build a publish a new version.

Given that I see little reason to merge this in master. If someone wants to build their own version with app trigger support they can just just clone your fork and use it.

Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.
I hope you understand. :)

Hi Petr,
I completely get it - I had the same annoyance when I found out it would
require admin access too. To be honest I just wanted this feature myself
and had some time on my Sunday, and thought I may as well share the results.
Hopefully someone finds it useful!
Cheers,
Will
On Sun, 31 May 2020, 10:18 pm Petr Houška<EMAIL_ADDRESS>wrote:

Hi!
First off, amazing work! Happy to see that my code is still useful after
all this time. Unfortunately I'll not be merging the PR at the moment for
two reasons:

I don't feel like making the app admin only as I generally don't
like giving admin permissions to apps. Also, I'm not quite sure how the
requireAdministrator plays together with MSIX/AppX "container" / if
it's possible to have based-on-settings admin privileges, etc.
As of right now I don't have the time (#23
https://github.com/petrroll/PowerSwitcher/issues/23) to rework the
packaging pipeline so even if 1) wasn't an issue I'd still not build a
publish a new version.

Given that I see little reason to merge this in master. If someone wants
to build their own version with app trigger support they can just just
clone your fork and use it.
Alternatively, I'd be happy to create a separate branch for this feature
on this repo and you can merge into that one. I'll remember to keep it in
sync with master if I ever come back to developing this.
I hope you understand. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/petrroll/PowerSwitcher/pull/27#issuecomment-636463490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPOQXPHJKIGPN476GF5IPTRUJDH7ANCNFSM4NPCQS2Q
.

Just dropped by and wanted to say that you actually have (literally) a whole fanbase of at least 50 IT professionals and esports players - who use this small addon since its inception, across various CPU platforms that came along, trough all of the W10 iterations...up until now. :-)
We all would love to see an update from you - at least a symbolic zero point one. ;-P
Stay well and all the best !

Hi, @MilanPutnik thanks for the kind words! I'll think about it :).


docs: add variables comments and types

Which issue(s) this PR fixes

Fixes None
Additional comments

Add comments on functions and classes
Add types on functions parameters and return
Remove unused logger

Agreements

[X] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[X] I hereby agree to grant TOSIT a copyright license to use my contributions.

I took inspiration from the Google Python Style Guide. If that's ok, I'll mention it somewhere in the developer doc.


wrong jQuery minimum version referenced

Hey there,
http://pixelmatrixdesign.com/uniform/ says it requires 1.3+ while the js file and the github project page say it requires 1.4+ (bugs out with "Uncaught TypeError: Cannot read property 'guid' of undefined" on 1.3.2)
I know this isn't rly an issue for the project per sé, but I wanted to bring it to your attention anyway as it could easily confuse people
I'm currently working on a project where I'm not able to upgrade jQuery so I was wondering if you know off the top of your head which commit I need to take out to make it play nice with 1.3.2
If you don't know this, or have to spend some time looking for it, please don't. It's not that huge so I can probably manually modify it to comply, but if you do know, I will be forever in your debt!
kind regards!

+1   This tripped me up for hours.


"Run" button for an HTTP-triggered function can be unnecessarily slow

Create a simple HTTP trigger based c# function.
Keep hitting run.  You'll see it returns back in reasonable time (<1 second most times after first)
Now wait 10 seconds.
Hit run again.  It now takes 4-5 seconds.
Throughout, if you hit the function from a browser it comes back superfast each time.

So this leads me to believe that the "run" button either blocks on some logging to complete, or does something else which is time consuming and unrelated to the function execution.
This makes the platform feel much slower than it is.

The only thing that I think may cause this is that we were going through a proxy on F.A.C backend to be able to hit the main site. With f48b530ba506b69e96886cd29c3756c763335667 this should no longer be the case. We're setting CORS on all containers for F.A.C.
We don't really have any delay in firing the xhr, unless if you have a dirty code editor, then we save the data first, wait for 200 msec, then send the xhr.

I think this is probably fixed now?

I've also been waiting to hear any feedback on whether the 1 second flush interval I added to the runtime file logging (part of the perf work I did). I don't think that's a factor here, but we could easily halve that interval to 500ms if we wanted.

I think the issue is resolved.  I don't notice is anymore and I forget to close it.


Enable exporter on non INF instances

Add the possibility to disable the validation in optimum-cli for better export experience on CPU only instances.

Use the flag --disable-validation when export with no neuron devices

optimum-cli export neuron --model yiyanghkust/finbert-tone --disable-validation --sequence_length 128 --batch_size 1 test_issue/

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[bug] [Python SDK] tfjob_client.get_logs broken

The error is
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Audit-Id': '531cbdff-8d93-4a9a-818d-4d11b0b386b7', 'Content-Type': 'application/json', 'Date': 'Fri, 10 Jul 2020 20:09:23 GMT', 'Content-Length': '271'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"a container name must be specified for pod text-classification-worker-0, choose one of: [tensorflow istio-proxy] or one of the init containers: [istio-init]","reason":"BadRequest","code":400}

Even when running kubectl logs <job-name>-worker-0 a container parameter needs to be passed (-c tensorflow). Not passing the container parameter, returns the same error.

/assign @jinchihe

Yeah, seems that's a bug if there is one more istio-proxy container, I'm going to fix that, and release new one.
Thanks @yanniszark to report that.

Turned off istio with
template=V1PodTemplateSpec(
        metadata=V1ObjectMeta(
            annotations={'sidecar.istio.io/inject':'false'}
        ),
        spec=V1PodSpec(
            containers=[container]
        )
    )

Everything worked as expected. The istio sidecar container caused problems. Closing the issue now.


Theme review refactor and cleanup

Looks good to me, don't know if you want to wait for Derek's review, feel free to merge otherwise

@derekherman This PR includes changes to bundle webpack concatenated but unminified assets in the zip file, could you review those changes ?


WIP - Handle open issues

https://github.com/jorisvandenbossche/DS-python-data-analysis/issues/165

with respect tot he matplotlib notebook formatting string exercise, adjusted as follows:


Prevent "extension is already registered" error

(I'm not sure how to reproduce the issue inside VSCode itself, so I wasn't able to create a issue)
When starting an extension host, the current existing extensions are sent to it via the initData in the handshake
When adding an extension, the diff is sent to the extension host using the $deltaExtension function
The call to deltaExtension is delayed until the extension host is ready
So if an extension is added before an extension host handshake is finished, the extension host will receive all the extensions in the initData THEN the added extension in a deltaExtension call, which will trigger a Extension ... is already registered
https://github.com/microsoft/vscode/blob/bb389f28ea44f4a9fad87dbf8c5e0ad7874acc0c/src/vs/workbench/services/extensions/common/extensionDescriptionRegistry.ts#L72
The suggestion solution is to get the initData immediately

Thank you! I've decided to do a slight refactoring and introduce a versioning mechanism to avoid any such problems -- https://github.com/microsoft/vscode/pull/193145

I confirm the bug no longer exists, thank you!


v0.3.11 error win32 x64

:warning:Please attach %TEMP%\vscode-java-installer\log.txt and %TEMP%\vscode-java-installer\AdoptOpenJDK-MSI.log for more details.
version: 0.3.11
env:
JAVA_HOME: undefined
PATH:
C:\Program Files (x86)\Google\Chrome\Application
C:\Program Files\Python38\Scripts\
C:\Program Files\Python38\
C:\Program Files\Git\cmd
C:\Windows\System32
C:\flutter\bin
C:\Users\best\AppData\Local\Programs\Microsoft VS Code\bin
JDKs:
C:\Program Files\Java\jdk-12	DefaultLocation

log:
[22:01:38] arch:x64
[22:02:59] Download Visual Studio Code ... [Completed]
[22:02:59] Install Visual Studio Code
[22:03:48] Error occurred
[22:03:48] Error: Command failed with exit code 1: C:\Users\best\AppData\Local\Temp\vscode-java-installer\binaries\vscode\x64\VSCodeUserSetup-x64-1.52.1.exe /MERGETASKS=!runcode,desktopicon,addtopath /SILENT

The installer didn't recognize VS Code on your machine, thus tried to download and install one but failed for some reason.
You can manually install Java Extension Pack. Please let me know if it works.

The installer didn't recognize VS Code on your machine, thus tried to download and install one but failed for some reason.
You can manually install Java Extension Pack. Please let me know if it works.


PVS-Studio: fixed vulnerabilities

V3041 The expression was implicitly cast from 'long' type to 'float' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;. Microsoft.Build CommunicationsUtilities.cs 615
V3118 Milliseconds component of TimeSpan is used, which does not represent full time interval. Possibly 'TotalMilliseconds' value was intended instead. MSBuild XMake.cs 629
V3095 The 'name' object was used before it was verified against null. Check lines: 229, 235. Microsoft.Build.Tasks GenerateBindingRedirects.cs 229
V3095 The 'publicKeyToken' object was used before it was verified against null. Check lines: 231, 235. Microsoft.Build.Tasks GenerateBindingRedirects.cs 231
V3095 = CWE-476 (NULL Pointer Dereference)

@dotnet-bot test Windows_NT Build for Desktop please

Thanks!


Unable to run multi nested Query

Unable to run a complicated query for example:
{
"suggest": {
"movie-suggest" : {
"prefix" : "captain america the",
"completion" : {
"field" : "name.completion"
}
}
}
}
Any idea how this can be achieved?

How would you do this with curl?

on kibana shell
we use
`POST _search
{
"suggest": {
"movie-suggest" : {
"prefix" : "cap",
"completion" : {
"field" : "name.completion"
}
}
}
}'

on kibana shell we use POST _search {     "suggest": {         "movie-suggest" : {             "prefix" : "cap",             "completion" : {                 "field" : "name.completion"             }         }     } }

here is another example
POST _search {   "suggest": {     "movie-suggest-fuzzy": {       "prefix": "captain amerca the",       "completion": {         "field": "name.completion",         "fuzzy": {           "fuzziness": 1         }       }     }   } }

here is another example
POST _search { "suggest": { "movie-suggest-fuzzy": { "prefix": "captain amerca the", "completion": { "field": "name.completion", "fuzzy": { "fuzziness": 1 } } } } }

This query supports fuzziness ( ability to get similar output  but this time with a typo captain "amrica the")

I see. Could you please also provide an example result set? I'm not actively using the suggest query, and the current search() method is using a top-level query object. If the format is the same, I'd probably massage this inside that method, otherwise this could go into a new method.

This is what we are trying to implement.
This doc is exactly what we have on our elastic instance.
https://hackernoon.com/elasticsearch-building-autocomplete-functionality-494fcf81a7cf
Now if you want to test. You can query through cURL
elastic : <IP_ADDRESS>:9200
The above mentioned link is working with demo data  and querying will give you the results.
Give it a try.

Looks like this is a better URL about the suggest queries:
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters.html
It needs a bit of coding to introduce an extension on both the search requests and response, not sure when it will be done, but I accept PRs.

I've released 0.1.1 with the support for suggest queries. I haven't done much testing with it, please let me know if they are useful/working.

Maybe that PR can made the search method more dynamically functional:
https://github.com/isoos/elastic_client/pull/5
please take a look


test explorer

quick and dirty test explorer for c#.
based dotnet 6 with blazor server and mudblazor for styling.

Hi Angelo.
Thank you for your interest in, and support of Clipper2. And I like your idea of a viewer for the tests.
However I'm going to reject your contribution for several reasons. Firstly, ISTM that it requires a third-party library (Blazer),
and I also want any additional utilities to be as simple as possible. But most importantly, since I'll be the one maintaining the library, I generally prefer to write additional utilites myself (though of course that may not happen straight away).
Cheers,

no problem Angus! I'll keep using for my experiments with you library
Just a small clarification, Blazor it's not third-party but it is part of the base sdk (like asp.net, wpf, winforms).


Phoenix/group prefixes

Description
adding prefix to group table for easier public id generation
Issue
ch141263
Test plan
run migration, run tests

No, they don't. CDPH is weird that way.
On Thu, Jun 3, 2021 at 1:52 PM Shannon Axelrod @.***>
wrote:

@.**** commented on this pull request.
In
src/backend/database_migrations/versions/20210602_224122_adding_prefix_to_group.py
https://github.com/chanzuckerberg/aspen/pull/508#discussion_r645117565:

   "Alameda County Public Health Department": "CA-ACPHD-",

   "Contra Costa County Public Health Laboratories": "CA-CCC-",

   "Fresno County Public Health": "CA-FC-",

   "Humboldt County Dept Human and Health Sevices-Public Health": "CA-HC-",

   "Marin County Department of Health & Human Services": "CA-MRNC-",

   "Monterey County Health Department": "CA-MCPHL-",

   "Orange County Health Care Agency": "CA-OC-",

   "San Bernardino County Public Health": "CA-SBC-",

   "San Joaquin County Public Health Services": "CA-SJC-",

   "San Luis Obispo County Health Agency, Public Health Laboratories": "CA-SLOC-",

   "Santa Clara County Public Health": "CA-SC-",

   "San Francisco Public Health Laboratory": "CA-SFC-",

   "Tulare County Public Health Lab": "CA-TCPHL-",

   "Tuolumne County Public Health": "CA-TLMNC-",

   "Ventura County Public Health Laboratory": "CA-VC-",

   "CDPH": "CA-CDPH",

These ones don't have the trailing -?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/chanzuckerberg/aspen/pull/508#pullrequestreview-675713382,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAIYX2GFCPL46C2NDVH3ODTQ7TPXANCNFSM457U7DAQ
.


PO001 | JSON Threat Protection

A check for a body element must be performed before policy execution.

completed


[FEATURE] Add Fade Animation to Links in 'Popular User Guides' Section

Description
I would like to take on this issue and work on adding the fade animation to the links in the "popular user guides" section. I believe that this animation will greatly enhance the user experience and make the website more visually appealing.
I plan to implement the fade animation using CSS transitions and apply it to the links in the designated section. I will ensure that the animation is smooth and matches the desired behavior described in the issue.
Once the animation is implemented, I will create a pull request for review and include any necessary documentation or instructions for further maintenance.
I look forward to working on this issue and making the necessary improvements
Screenshots

Additional information
No response

@qwertyroop thank you for your suggestion for enhancing the website, but we are in the process of redesigning this so there is no point making additional changes at this stage and I will close this Issue for now.


markdown parsing should be able to handle consecutive lines with headings

and avoid the need for this additional <br/>

Resolved here: https://github.com/100mslive/100ms-docs/pull/1012


Use original CWD when opening files in the ipc plugin

Fixes an issue where if you're using the ipc plugin, you can only open a file from the terminal if you are in the same directory as it.

So wait; perhaps I'm just not seeing it; but could we not simply do something like
local dir = os.getenv(PLATFORM == "windows" and "CD" or "PWD")
local path = dir .. PATHSEP .. ARGS[i]

Instead of changing directories? I'm not sure we even need to use system.absolute_path here if we do something like this.

I guess, I just want to avoid missing some edge case(s) that absolute_path handles.

Also, that wouldn't work for something like ~/Repos and ~/Repos/wgpu/Cargo.toml. I'm not even sure what would happen if you just concatenated them and tried to open it.

Oh, good point. Ideally though, we just minimize the amount of global state we have to deal with. How about something like this, then?
local dir = os.getenv(PLATFORM == "Windows" and "CD" or "PWD")
local path = common.home_expand(ARGS[i])
if not common.is_absolute_path(path) then
  path = dir .. PATHSEP .. path
end
path = system.absolute_path(path)

That'll probably work.

Also, that wouldn't work for something like ~/Repos and ~/Repos/wgpu/Cargo.toml. I'm not even sure what would happen if you just concatenated them and tried to open it.

You should never be getting ~ from the command line anyways. It will be expanded by the shell when calling Lite XL.

Oh, I just used ~ as a shorthand so I wouldn't have the write the full thing here.

Then an absolute path check should be enough, right?

Yes.

Could you try with something like:

Get "original" cwd via local original_cwd = system.absolute_path(".") on plugin load, so outside any functions.
Add a function like:local function get_absolute_path(filename)
  if common.is_absolute_path(filename) then
    return common.normalize_path(filename)
  else
    return original_cwd .. PATHSEP .. common.normalize_path(filename)
  end
end

Replace local path = system.absolute_path(ARGS[i]) with the above function local path = get_absolute_path(ARGS[i]).

The problem is that by the time the plugin is loaded, the CWD has changed.

Ah yeah, it's the user module that gets loaded before, alright.

Still, instead of the weird double cwd change, you could still use PWD from the environment variable in my proposed function instead of original_cwd.


RSSI sensor

Hi @wifwucite!
I would like to create a smart lock with ESPhome.
(I dont want to publish a beacon with my phone)
My idea is to pair my andorid phone with the esphome device, for security reasons.
I guess it will auto-connect if in range.
I need to measure the rssi value to calculate distance, then set it as a sensor value.
I can't get pairing with the core esphome ble server.
What do you think about this?
Is it possible anyway and with your controller lib?

I tried your code, but it does not connect automatically, just with the BLE scanner app

Well, technically the controller is a BLE server, I.e. it advertises services and waits for a BLE client like your phone to connect. So the client has to start the connection process. That means you need an app on your phone. Or you could try the BLE client from ESPHome, which can also do presence detection and measure RSSI values. However that is all based on MAC addresses, which can be spoofed. So for me this would be too insecure for a lock.


Trivial: Backticks do not work in page title

The backticks around NetworkPolicy in the title display as backticks on https://docs.projectcalico.org/v2.6/getting-started/kubernetes/tutorials/advanced-policy and do not format the text as intended.
Description
This is a trivial, and tiny change.
Documentation only.
Just a typo.
Two screenshots from Safari 11.0 attached.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, thanks @nicdoye ! 👍

It might be nice, if we wanted this fix to persist beyond 2.6, to make this change in the master folder as well. However, let me go ahead and merge this, we appreciate your contribution!


Java or Python Research

I think that the obvious choice here is Python since the team is more comfortable with it and more people know it.


Bindgen for cuda_runtime_api.h

I was looking for methods like cudaGetDeviceProperties from include/cuda_runtime_api.h but they don't seem to be present. Is there a reason for that, or is it just not done yet? I can look at adding a bindgen for it, if that's reasonable?

Yeah we only have support for the driver api, so no support for runtime api at the moment. I think supporting runtime api might look slightly different from the other APIs, because the safe runtime api would look very similar to the safe driver api.
Perhaps we only add the sys/result levels for runtime api?


Registration Discussion

Discussed in https://github.com/SolarexIT/OpenID-Connect-PHP/discussions/6

Originally posted by houssamkhalifeh November 27, 2021
This discussion was created with the goal of making it the starting point from which issues will be created and then assigned to any existing participant or new joiner to the list of participants by means of taking part in this discussion
Created from the discussion after @housssec left a comment. housssec ** still does not** seem to be mentionable at the creation.

This kind of make sense nevertheless; housssec is not a participant of this issue yet. Just creating an issue from a discussion does not automatically add the participants of the discussion to the list of participants of the newly created issue.


Shuffle examples

Purpose
This PR aims to enhance the ExampleList.tsx component by allowing it to display three randomly selected questions every 7 seconds from a list of questions. This improves the user experience by periodically refreshing the examples displayed.

Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
[ ] Yes
[X] No

Type of change
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist
See CONTRIBUTING.md for more details.

[ ] The current tests all pass (python -m pytest).
[ ] I added tests that prove my fix is effective or that my feature works
[ ] I ran python -m pytest --cov to verify 100% coverage of added lines
[ ] I ran python -m mypy to check for type errors
[X] I either used the pre-commit hooks or ran ruff and black manually on my code.

https://github.com/user-attachments/assets/4dd2eee3-27b5-4c85-841b-8c3d8ef55040

Possible Approaches for Improved Question Listing
@pamelafox - I am considering different approaches to enhance the question listing feature. The table below outlines a few of these approaches, including the currently implemented method and some proposed alternatives. I'd love to hear any other ideas you might have.

#
Approach
Description
Considerations

1
Current Approach
Predefined List of Questions: Displaying a list of predefined questions that shuffle every 7 seconds. The questions are stored in a file (examples.ts) and selected based on whether GPT-4V is used or not.
Simple to implement and ensures a controlled set of questions, but may become stale over time, requiring periodic updates. Hence, maintenance can become challenging if the front end needs to support multiple languages in the future.

2
User Feedback-Based Curation
User Feedback-Based Curation: Users submit questions through chat, and highly rated questions are added to the list. This list can then be shuffled and displayed as in the current approach.
Engages users and keeps content relevant, but requires a rating mechanism and potentially moderating user submissions.

3
AI-Generated Questions
AI Search-Based Generation: Utilize Azure AI Search to generate questions based on the data provided. These dynamically generated questions can be shuffled and displayed to keep content fresh and relevant.
Provides highly relevant and updated questions, but requires integration with AI services and potential cost-performance considerations (with the recent GPT-4 mini it could be challenged?).

I like the idea of a shuffle and multi-language support would help as well! Great stuff.
Our Application owners favor adding custom questions over User/AI generated ones

Interesting feature! Thanks @mrmueller for chiming in. Love to hear other developer's thoughts about what they/customeres want. I'm concerned this might make the local developer experience difficult as I'm fairly accustomed to always clicking the same question to check something. On the other hand, it'd be good if I tested with more than those same 3 questions.
What do you all think about the impact on local developer experience?


non-prod mode for easier debugging

... per meeting today
to make eg Webpack / chunk*.js more transparent

@achen2401  notes:
She currently writes out what is returned here:
console.log("expression ", expression[0], " result ", result).

[SurveyComponent.vue](https://github.com/uwcirg/asbi-screening-app/blob/8aef97f34ee58bf98bb2e1d6b988c7f781d14775/src/components/SurveyComponent.vue)
        evaluateExpression(expression[0]).then(result => {

Let's call this first pass done, might wire into a larger SAFER config later


How to hidden at launch after update to Flutter 3.7?

After updated to Flutter 3.7, the win32_window.cpp file has been changed, and the original Hidden at launch is not available.
Can you upgrade the method?
New win32_window.cpp
  HWND window = CreateWindow(
      window_class, title.c_str(), WS_OVERLAPPEDWINDOW,
      Scale(origin.x, scale_factor), Scale(origin.y, scale_factor),
      Scale(size.width, scale_factor), Scale(size.height, scale_factor),
      nullptr, nullptr, GetModuleHandle(nullptr), this);

#291
#292
The pr is right, Ithink.

#291 #292 The pr is right, Ithink.

Merged


Update gradle to the latest version

Update Gradle and apply subsequent changes:

Fix plugin publication logic
Fix kotlin toolchain definition (new versions requires https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support)

In the meantime, I upgraded to Gradle 8.7 which is newer.


”MIERCUREA SIBIULUI” is listed in the drop-down menu

Description:
"MIERCUREA SIBIULUI" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "MIERCUREA SIBIULUI" in the search bar.

Expected results
The location is listed in the drop-down menu as "Oraș MIERCUREA SIBIULUI, SIBIU".


[reorder] general improvement

[ ] export a HOC so user can define their own card UI & preview
[ ] better looking loading state
[ ] handle the case where the targeted folder collection is empty

handle the case where the targeted folder collection is empty

It should ideally also display a link user can click to create a new entry in that collection


Fixes small api error

Neuromorpho API filtering query should work according to http://neuromorpho.org/apiReference.html#neuron-filter-query

This change fixes https://github.com/brainglobe/morphapi/issues/9

perfect thank you!


Fix code typo in example

Remove an extra semicolon from the code example in the documentation.

If you find more, please combine them in one PR, or you'll become the top contributor in no time 😄


let's release the spring-cloud-kubernetes-bom

The sundr maven plugin creates the BOM for us. https://github.com/fabric8io/spring-cloud-kubernetes/blob/master/pom.xml#L261
Can we add this to what gets attached to the deploy when we push to mvn central? Not seeing it there:
http://central.maven.org/maven2/io/fabric8/

this maven goal should do the trick:
http://www.mojohaus.org/build-helper-maven-plugin/attach-artifact-mojo.html
wanna experiment locally and see if it gets installed into your local maven repo?

will give it a try and send a PR, thanks!

@jstrachan when I build/deploy this locally w/o any changes it properly attaches the BOMs (spring-cloud-kubernetes-bom and spring-cloud-kuebrnetes-bom-with-platform-deps). Looking at fabric8io/fabric8 and fabric8io/kubernetes-client (which also push BOMs up to mvn central) i don't see an explicit attach with the builder-helper mvn plugin.. can you point me to where these builds/releases, specifically for spring-cloud-kubernetes, happen in Jenkins?

Hmm I'm a bit stumped; I looked at the sundr-maven-plugin usage in fabric8 for example (which I assume is the plugin that attaches the bom to build) and it looks about the same; don't see any differences in the release plugin versus fabric8 either.
Lemme try another release and see what happens & then we'll have the log

Thx. Is this part of the fabric8 release pipeline or has a Jenkins job I
can see for future debugging?
On Thursday, August 18, 2016, James Strachan<EMAIL_ADDRESS>wrote:

Hmm I'm a bit stumped; I looked at the sundr-maven-plugin usage in fabric8
for example (which I assume is the plugin that attaches the bom to build)
and it looks about the same; don't see any differences in the release
plugin versus fabric8 either.
Lemme try another release and see what happens & then we'll have the log
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/spring-cloud-kubernetes/issues/50#issuecomment-240928701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADP0Z2tnKpZDJ1CikQcyjWvFWubHw7Zks5qhTlAgaJpZM4Jm3GM
.

--
Christian Posta
twitter: @christianposta
http://www.christianposta.com/blog
http://fabric8.io

its a separate job, its on our VPN unfortunately so I'll mail you offline

Most probably we haven't released since we added the bom generation stuff

yeah, it seems the bom generation stuff were added early july and last release is mid june.

I've just kicked off a release, fingers crossed!

it seems that it worked!

Yay, awesome!
On Friday, August 19, 2016, Ioannis Canellos<EMAIL_ADDRESS>wrote:

it seems that it worked!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/spring-cloud-kubernetes/issues/50#issuecomment-241018706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADP0Q0AH9Yo4_s9C2cxKEw26HXs712cks5qha_0gaJpZM4Jm3GM
.

--
Christian Posta
twitter: @christianposta
http://www.christianposta.com/blog
http://fabric8.io


[Bug]: After grouping 2 widgets the widget position is getting changed

Is there an existing issue for this?

[X] I have searched the existing issues

Description
2 widgets where grouped and the expectation was post grouping the position of the widget shouldn't change, in this case it has changed and test has failed.

Steps To Reproduce
1.Make sure you have multiple widgets in canvas.
2.Select widgets using cmd + click and group using cmd + G
3.Once grouping is successful make sure the location of the widget stays the same
Actual:
The grouped widget is coming below Camera widget which is change of location
Expected:
the widget shouldn't change upon grouping

, in this case it has changed and test has failed.
Public Sample App
No response
Version
Appsmith v1.6.26-SNAPSHOT

@NandanAnantharamu, I am unable to reproduce this. The test seems to be passing consistently in my local on latest release code. Also imported the dsl into an App and grouped them it seems to be working as expected. Please let me know if there is a way to reproduce this.

@rahulramesha the latest release even i am not able to reproduce, you can close this


Change base image to no longer require JDK

This new image[1] has no critical or high vulnerabilities whereas the one we were on[2] has 6 critical and 8 high.
When looking at the Kotlin template that we were originally based off we can see that it has made the change from openjdk to eclipse-temurin on the basis that "Kotlin doesn't require JDK to build" [3]. We stop short of jumping to Java 18 as that pull request does to try and make the smallest step.
[1] https://hub.docker.com/layers/library/eclipse-temurin/17-jre-jammy/images/sha256-ddf36656dc8920621fddf4928bdcb4b98c0d0e7bc9672f0cea8115c10ad5cbc6?context=explore
[2] https://hub.docker.com/layers/library/openjdk/17-slim/images/sha256-779635c0c3d23cc8dbab2d8c1ee4cf2a9202e198dfc8f4c0b279824d9b8e0f22?context=explore
[3] https://github.com/ministryofjustice/hmpps-template-kotlin/commit/25457f47e8bd9b03d70408b6c038728f6afcf24e
You can test this with Trivy locally by checking the branch out and running the following:
$ docker build . -t test-17jammy
$ docker run --rm -v trivy-cache:/root/.cache/ -v /var/run/docker.sock:/var/run/docker.sock aquasec/trivy:latest image --exit-code 100 --no-progress --severity HIGH,CRITICAL --ignore-unfixed --skip-dirs /usr/local/lib/node_modules/npm --skip-files /app/agent.jar test-17jammy

@brownbearsoftware I would appreciate a more detailed review of this given. The tests seem to pass without the JDK. I trust the change made to the template repo somewhat but think it would be good if you could checkout this change and kick the tyres on it please?

The tests seem to pass without the JDK.
The Dockerfile doesn't actually run the tests anywhere (./gradlew assemble is esentially a build without verification tasks (ktLintCheck and test in our case)).  Running ./gradlew test locally and on the GitHub actions isn't using the Docker image that's built from Dockerfile at all.  So even if this was a problematic change, I suspect the tests would still be fine.

That said, I did checkout the branch and run docker build and it does work fine - I'm pretty surprised that you don't need a JDK to compile a Kotlin JVM app but apparently not!

Thanks for testing @brownbearsoftware  👍