Compatibility with PHP7

Drupal8 has a critical release blocker to be compatible with PHP7.
The installer currently fails because of guzzle. I tried to fix those errors myself, but I can't really make sense of the code, apart from the first one, which seems easy enough to fix:
Fatal error: Redefinition of parameter $_ in /vendor/guzzlehttp/ringphp/src/Client/StreamHandler.php on line 313
=> This seems easy enough, I guess it's no longer possible to have multiple identical parametes
Fatal error: Argument 3 passed to GuzzleHttp\Ring\Client\StreamHandler::createResponse() must be of the type array, null given, called in /vendor/guzzlehttp/ringphp/src/Client/StreamHandler.php on line 34 and defined in /vendor/guzzlehttp/ringphp/src/Client/StreamHandler.php on line 40
=> I can't figure out where headers would be set, it's just passed around by reference but never set?
Fatal error: Argument 1 passed to GuzzleHttp\Message\FutureResponse::proxy() must implement interface GuzzleHttp\Ring\Future\FutureInterface, null given, called in /src/RequestFsm.php on line 133 and defined in /src/Message/FutureResponse.php on line 36
=> This is coming from testCanSpecifyHandler(), somehow that trick with throwing an exception doesn't seem to work anymore...
Didn't get past the last one yet...

For reference, this is the Drupal issue: https://www.drupal.org/node/2454439#comment-9768963

Oh, i actually wanted to open the issue in guzzle, but the errors are in both projects, so it doesn't matter much..

Quick update, fixing the obvious first error with repeated arguments makes the Drupal installer work again, so far it looks like the additional errors are test-specific problems.

I'll merge any necessary PRs.

@Berdir which one of these have you fixed and which do you still need help on? I can have a look but just wondering if you could give any background -- the "trick" is obvious from the code or do I need to know anything?

I've experimented a bit, no real fixes. The $_ fix is easy, only question is how to name the variables, $_1, $_2, $_3 was what I did. A quick OK or a better suggestion from @mtdowling would be useful, before creating a PR.
For the second, I've just added a $headers = array(); before it is used, then it worked for me, but I don't understand what the code is supposed to do. And I don't understand why it works in PHP 5, some by-reference trickery apparently.
No solution for the third yet, would appreciate any guidance on how to proceed there. Looks like we might need a real callback function to test, but I have no idea what that would have to do.

The first and second errors are fixed.
Haven't looked into the future proxy problem yet.

Actually, looks like that stream wrapper fix may have inadvertently fixed the future proxy issue: https://travis-ci.org/guzzle/RingPHP/jobs/56357602
Looks like we are good to go on PHP 7 for RingPHP. I'll leave the Guzzle issue open until that's working as well.


NZBGetPostProcess: IOError: [Errno 22] invalid mode ('a') or filename:

After updating the script four days ago, every single download made with NZBget for Sonarr or CouchPotato on Windows 2012 R2 Server is erroring.
Here are the logs from NZBget...

Kind
Time
Text

error
Fri Mar 20 2015 12:31:53
Post-process-script NZBGetPostProcess.py for xxxxxxxxxx.S01E01.HDTV.x264-LOL-NZBgeek failed (terminated with unknown status)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: IOError: [Errno 22] invalid mode ('a') or filename: 'C:\\x07utoProcess\info.log'

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: stream = open(self.baseFilename, self.mode)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging_init_.py", line 936, in _open

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: StreamHandler.init(self, self._open())

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging_init_.py", line 911, in init

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: logging.FileHandler.init(self, filename, mode, encoding, delay)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging\handlers.py", line 64, in init

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: BaseRotatingHandler.init(self, filename, mode, encoding, delay)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging\handlers.py", line 117, in init

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: h = klass(*args)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging\config.py", line 163, in _install_handlers

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: handlers = _install_handlers(cp, formatters)

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\Python27\lib\logging\config.py", line 85, in fileConfig

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: fileConfig(os.path.join(MP4folder, 'logging.ini'), defaults={'logfilename': os.path.join(MP4folder, 'info.log')})

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: File "C:\autoProcess\NZBGetPostProcess.py", line 65, in

info
Fri Mar 20 2015 12:31:52
NZBGetPostProcess: Traceback (most recent call last):

info
Fri Mar 20 2015 12:31:52
Executing post-process-script NZBGetPostProcess.py for xxxxxxxxxx.S01E01.HDTV.x264-LOL-NZBgeek

info
Fri Mar 20 2015 12:31:52
Move for xxxxxxxxxx.S01E01.HDTV.x264-LOL-NZBgeek successful

info
Fri Mar 20 2015 12:31:52
Moving completed files for xxxxxxxxxx.S01E01.HDTV.x264-LOL-NZBgeek

info
Fri Mar 20 2015 12:31:51
Cleanup for xxxxxxxxxx.S01E01.HDTV.x264-LOL-NZBgeek successful

The folder the this script is stored in is C:\autoProcess\ and this is what is MP4_FOLDER is set as.  I've moved the script for NZBget to the script folder at C:\Program Files (x86)\NZBGet\scripts .
I've updated the script, no change.  Any assistance you can give would be appreciated.  I couldn't see where the best place to post this would be, so posted it here on GitHub.

I fixed the issue, needed MP4_FOLDER to be C:/autoProcess/ instead.  Not sure if this can be changed in the coding so this isn't needed, or if it should be mentioned in the supporting text next to the field.

Hm that's very strange. I use an almost identical windows path to yours (C:\Scripts\ instead of C:\autoProcess) without this being an issue. However, its easy enough to correct in code so I just pushed a commit that should allow it to work with the backslashes. Try grabbing it and then putting your MP4folder back to C:\autoProcess\ and let me know.

Confirmed, all working fine now.  Thanks :)

When trying to run a manual conversion from a command prompt, I'm getting the same issue as well...
`�Microsoft Windows [Version 6.3.9600]
(c) 2013 Microsoft Corporation. All rights reserved.
C:\Users\Administrator>C:\autoProcess\manual.py --input "G:\Public\Videos\Movies
\xxxxxxxxxxx, The (2014)\The xxxxxxxxxxx.mkv" --auto
Traceback (most recent call last):
File "C:\autoProcess\manual.py", line 20, in
fileConfig(os.path.join(os.path.dirname(sys.argv[0]), 'logging.ini'), defaul
ts={'logfilename': os.path.join(os.path.dirname(sys.argv[0]), 'info.log')})
File "C:\Python27\lib\logging\config.py", line 85, in fileConfig
handlers = _install_handlers(cp, formatters)
File "C:\Python27\lib\logging\config.py", line 163, in install_handlers
h = klass(*args)
File "C:\Python27\lib\logging\handlers.py", line 117, in init
BaseRotatingHandler.init(self, filename, mode, encoding, delay)
File "C:\Python27\lib\logging\handlers.py", line 64, in init
logging.FileHandler.init(self, filename, mode, encoding, delay)
File "C:\Python27\lib\logging_init.py", line 911, in init
StreamHandler.init(self, self.open())
File "C:\Python27\lib\logging_init.py", line 936, in _open
stream = open(self.baseFilename, self.mode)
IOError: [Errno 22] invalid mode ('a') or filename: 'C:\Users\Administrator\
x07utoProcess\info.log'
C:\Users\Administrator>`�

After doing some googling, it appeards that the full file name fields may need to be raw strings, as per this link, and this link too.

Try the latest commit and see if your issue is resolved

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain ianfitzpatrick.eu has exceeded the max emails per hour (3/3 (100%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext3.iad.github.net ([<IP_ADDRESS>]:54159 helo=github-smtp2b-ext-cp1-prd.iad.github.net)
by server.budgettopserver.nl with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.85)
(envelope-from<EMAIL_ADDRESS>id 1YZSn1-003fVo-HE
for<EMAIL_ADDRESS>Sun, 22 Mar 2015 00:26:47 +0100
Date: Sat, 21 Mar 2015 16:26:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1426980405;
bh=nsQ6i6A58S8VgNp1SSh0vVu/XTtRnHZZS99nCCpjsEM=;
h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=HD9Ni+IgEufaHU9936LNZhRncUqm1FIH+GRbbXT6QBCn94xTBVpKoNhV6uYg7qw8v
rbMuLSfPUJFvEwu3LrfS7tEw9hesLIVWd0cD638zSj7rvnLAvgM34oXzItRwPq7hDm
Z+bQxTIV/+KShfRv2OhVmfjJ65ACG6F/1+XC9dDE=
From: Michael Higgins<EMAIL_ADDRESS>Reply-To: mdhiggins/sickbeard_mp4_automator<EMAIL_ADDRESS>To: mdhiggins/sickbeard_mp4_automator<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [sickbeard_mp4_automator] NZBGetPostProcess: IOError: [Errno 22]
invalid mode ('a') or filename: (#221)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_550dfe355f9a5_a053fce79c832a02725f8";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mdhiggins
X-GitHub-Recipient: ifitzpat
List-ID: mdhiggins/sickbeard_mp4_automator
<sickbeard_mp4_automator.mdhiggins.github.com>
List-Archive: https://github.com/mdhiggins/sickbeard_mp4_automator
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AGXPC3A7CrLsniOjtupDGti2a8omq3suks5n3fW1gaJpZM4Dx1E2
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>----==_mimepart_550dfe355f9a5_a053fce79c832a02725f8
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Try the latest commit and see if your issue is resolved

Reply to this email directly or view it on GitHub:
https://github.com/mdhiggins/sickbeard_mp4_automator/issues/221#issuecomment-84472907
----==_mimepart_550dfe355f9a5_a053fce79c832a02725f8
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Try the latest commit and see if your issue is resolved
—Reply to this email directly or view it on GitHub.

----==_mimepart_550dfe355f9a5_a053fce79c832a02725f8--

Thanks, the latest commit seems to have fixed the issue.  Really appreciate the fast response :)


Better treatment of masks

Cleanup and better treatment of masks with specialized cdopipe functions for now. Will need further future refinements (in a new branch). Closes #13

I changed (yet again) the masks interface. The solution with the 'deferred' evaluation of variables really seemed too complex and error-prone to me (it also still required a specific order in calling the masks functions). I tried to keep the modular approach though. My suggestion is to revisit this once we develop also for another model (eg ECE3 or CMIP CMOR models) and see then what works best based on a practical example of the complications.

Ok, merging and closing, further tampering of grids and fixes in new branch


Cannot find module '@uni' or its corresponding type declarations.

I am building multiple apps with shared resources and here is my folder structure

I register the alias '@uni' into both vite.config.ts and tsconfig.json, it works well for both the dev and build-only
But when i using command 'type-check' it make error as this issue title

tsconfig.json

vite.config.ts

error when using and compile by vue-tsc

So, how i can resolve it? I really want to using type-check for safe check but with this way i must to ignore to finish build process :((
btw, if this issue done, it will affect to Volar? I don't want to see error during development time :(
Thank you

You should add alias to the tsconfig that includes your app.

You only include ../uni/**/*, so typescript server dose not know that app-a and app-b can also use @uni alias.

You only include ../uni/**/*, so typescript server dose not know that app-a and app-b can also use @uni alias.

I edited my issue to be clearer. My problem appears at app-a (for example, app-b also). And I registered @uni for both tsconfig and vite.config.ts (you can re-see in my issue description).
I know that in that way it was tell to typescript that using @uni for app-a. So what is the wrong here?

create tsconfig.json under app-a does not automatically include files in app-a you have to explicitly add to the tsconfig.
e.g.
- 	"include": ["../uni/**/*"],
+ 	"include": ["../uni/**/*", "./src/**/*"],

Both IDE error and typecheck error due to this.
Your build works because vite does not require typescript at all which mean it does not read tsconfig.json.

Hey there, as there have been many fixes in the last 2.x versions: Please let us know if you're still encountering this issue. Otherwise kindly close this one, thanks!


BtbN release build vs. ffmpeg commit

Hi,
sometimes I find myself verifying a particular ffmpeg commit has fixed a reported particular ffmpeg issue. I am considering using BtbN builds to check. However, I am having hard times to determine ffmpeg commit from BtbN release. Lets say I have just downloaded ffmpeg-N-105930-ga71a3d1ed2-win64-lgpl.zip
running it produces following banner:
ffmpeg version N-105930-ga71a3d1ed2-20220314 Copyright (c) 2000-2022 the FFmpeg developers
  built with gcc 11.2.0 (crosstool-NG <IP_ADDRESS>3_681aaef)

but ga71a3d1ed2 does not seem to match any ffmpeg commit.
Compared to https://www.gyan.dev/ builds, for example:
ffmpeg version 2022-01-24-git-0a83ecbf48-full_build-www.gyan.dev Copyright (c) 2000-2022 the FFmpeg developers
  built with gcc 11.2.0 (Rev7, Built by MSYS2 project)

0a83ecbf48 references a commit
Would it be possible to include ffmpeg commit hash info into "latest" builds or is there any option already in place to resolve it somehow?

you want to omit the g. the g means git.
it's actually commit a71a3d1ed2.

Compared to https://www.gyan.dev/ builds, for example:

he uses shallow clone that why itsn't prefix with g. https://github.com/FFmpeg/FFmpeg/blob/master/ffbuild/version.sh#L14

perfect, thanks @nanake


:seedling: Vendor webui dependencies

Signed-off-by: Mauro Morales<EMAIL_ADDRESS>
What this PR does / why we need it:

[x] Add web UI dependencies using npm
[x] generate node_modules during build time
[ ] cache node_modules installation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #608

@mudler after some fiddling around between GA and Earthly I decided to leave it the same way as go deps are currently installed. However, I'd like this to be a bit different in the future because I find it's a bit wasteful to re-build dependencies if the definition of the dependencies didn't change. I think that the CI should instead build the dependencies before calling the builds matrix, so that each of them don't need to do the building themselves. It's probably not going to be a huge time improvement but I like the idea of not having to do any unnecessary computations/downloads/etc. If we were doing it all on GA it would look something like this:

But I agree with you that the most we can stay independent from GA, the better. What do you think?
In the meantime, I think this can be reviewed

tested locally and works!


Fix issue page link in Github Issue templates (#3431)

Hi, I found a problem in linking to github issues page on Feature request issue template, the checkbox should redirect user to Bit platform issues not microsoft dotnet issues.

The pre-release has been published. Please give it a try and give feedback.

The pre-release has been published. Please give it a try and give feedback.

Thanks for your information :)
I will test the new release soon :100:


Add python-can on Python 3

This is the same package as python-can, just for Python 3 instead of Python 2. To quote the docs:

The python-can library provides Controller Area Network support for Python, providing common abstractions to different hardware devices, and a suite of utilities for sending and receiving messages on a CAN bus.

It is also used in some robotics environments and thus qualifies for this list.
For Debian & Ubuntu.

Okay, sure. Thanks for the review. I addressed it in the last commit.

Done. :smile:


Random Fatal Error during fast travel

UE4Minidump.dmp
Hello, since i installed the mod for unlock the FPS, i got some random crash during fast travel. I dont know wich log i need to share if that can help, i send one i found in the crash folder.

It does appear it's crashing in UE4SS...could you get the crash to occur again and attach UE4SS.log (same directory as AT-Win64-Shipping.exe)?
Also, more so just curious, in the Config.ini, are you leaving the MaxFPS at 0 or setting it to your FPS cap?

I am gonna play soon during few hours, i will share the log if i got a crash. And i didnt change nothing in the config file, so its always set to 0. The crash happens on my gsync screen, i cap the fps to 120 in nvidia pannel. And the crash happens too on my tv 60hz wiyh vsync on in nvidia pannel.

I finally got the crash again, i send you the log.
UE4SS.log


add test for failed preds and catch timeout during streaming

We need to add tests for when:
- predict fails during streamed generation -> Users will receive 200 HTTP status if fails at LitAPI side and 50x if fails at endpoint side.
- ~a timeout happens during streaming~ -> we can't do this since, FastAPI will just stream the output till timeout instead of throwing an error.
- test end-to-end streaming: Done
Originally posted by @lantiga in https://github.com/Lightning-AI/litserve/pull/37#discussion_r1566478060

I think we should close it now @lantiga


Tag new release with new APCu support

Latest release is from 6/Nov, so there is no release with the new features.

Yes, please!


Set viewport on drawing board

Description:
Codepair is displaying the coordinates of the screen as absolute values
We need to show dots on the screen according to the viewport.
Why:
All recorded dots must be displayed on the mobile environment and on screens with different resolution
If the resolution is different, the recorded point may not be visible.

Close the issue because it supports tldraw.


Fixed: max bitrate still using v13 format

This PR fixes a backup load failure caused by MAX_BITRATE_PER_TIER using an outdated format. Find more in #7.
This fixes #7.
Small note for line 219: As GuildPremiumTier is now a number (see discord-api-types), the logic was simplified - please let me know if that is an unwanted change ^^

@SCDerox thanks for creating a PR for this. Love the simplification of line 219.


What's the difference between Azure DevOps Server visions?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2197a6a8-ecda-b647-6cbf-c08defccc54b
Version Independent ID: c66fa15d-cb16-b734-d73b-701acf368f95
Content: What is Azure DevOps? - Azure DevOps
Content Source: docs/user-guide/what-is-azure-devops.md
Product: devops
Technology: devops-new-user
GitHub Login: @chcomley
Microsoft Alias: chcomley

@alice322Hry -- thank you for your question.  Please consider these articles and resources:

Azure DevOps Server 2020 Release Notes

Azure DevOps Server 2019 Release Notes

Team Foundation Server Release Notes History

Azure DevOps Services

Azure DevOps on Stack Overflow

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


"AWS::SNS::Topic" does not appear to be fully defined

Hi there,
Thanks for all your great work on this gem. I have been using it very heavily.
It looks like AWS::SNS::Topic is not fully defined in the YAML file. I am happy to create a PR that fixes this one up.
If you could provide some guidance on your preferred path to contribution that would also be really helpful. Would you prefer I create issue and put then create the PR off the back of that for changes such as this? Or is a simple PR on its own sufficient?
Fraser

A simple PR should suffice.
On Wed, Feb 4, 2015 at 6:33 PM, Fraser Perkins<EMAIL_ADDRESS>wrote:

Hi there,
Thanks for all your great work on this gem. I have been using it very
heavily.
It looks like AWS::SNS::Topic is not fully defined in the YAML file. I am
happy to create a PR that fixes this one up.
If you could provide some guidance on your preferred path to contribution
that would also be really helpful. Would you prefer I create issue and put
then create the PR off the back of that for changes such as this? Or is a
simple PR on its own sufficient?
Fraser
—
Reply to this email directly or view it on GitHub
https://github.com/stevenjack/cfndsl/issues/81.

PR @ https://github.com/stevenjack/cfndsl/pull/80
Interested to hear your thoughts.


Issues opening solution with latest VS2017? (v15.7.6)

I've been debating whether I have the time to try helping out with the project. Today I cloned the repo and to my surprise VS responded with a csproj upgrade notice and a few failures. It also threw an error I haven't seen before. The build instructions say VS2017 is required so these were surprising to me.
I went ahead with the conversions to see what happens, but as I'm very new to the project I won't PR anything until someone weighs in on the problem. The images below show the error that is thrown whenever I open the SLN, the one-time csproj update notice, and the csproj conversion failures (Android and OSX, everything else converted ok).
The link on the csproj conversion failures goes to the Xamarian home page, so I'm guessing the Android and iOS projects need some sort of extension installed, or something of that nature? Whatever the fix is, I suppose the build instructions should clarify this. Meanwhile, what else do I need to install to get this to load correctly?

You need to install the modules for mobile development first to be able to open these projects. Just open the visual studio installer and select the mobile development workload.

@Gillibald Is anything beyond the basic SDK required?

The android images are just for the emulator. In general the mobile workload should be enough.


hook c library function return 0, but not work by inject dll.

CrashDumpHelper.zip
I hook strcmp function success, and it take effect in app(.exe) code.
But it doesn't work if hook strcmp function in dll while inject the dll to app(.exe)
attachment is my code, could you please answer me? thks

It's possible that the application you are injecting into statically links the CRT, or uses a different (older or newer) version of the CRT.

It's possible that the application you are injecting into statically links the CRT, or uses a different (older or newer) version of the CRT.

I used the same function and the same header, compile them together with VS. attachment is my code, could you please fix it ?

I can't check your code because it gets flagged as virus and autodeleted. Can you upload it on GitHub?

https://github.com/LickBag/DetourDemo

Any progress @LickBag

These take effect only in Debug mode

If its working in debug but not in release mode its likely that the function is inlined and not actually called. Just because a function has a header signature doesn't mean its part of the DLL, it could be part of the LIB and the linker can decide whether to inline or call it.


Next

Next iteration of gymnast
Pre Release

[x] Remove Layout, Root, asCol, asLayout
[x] Remove Layout, Root, asCol, asLayout from examples
[x] Reduce bundle size and bundle size threshold
[x] Cleanup CircleCI yaml file
[x] Stabilize branch / pass CI
[x] Use React.forwardRef instead of relying on innerRef https://github.com/gymnastjs/gymnast/pull/407
[x] Switch to react hooks https://github.com/gymnastjs/gymnast/pull/407
[x] Switch to TS https://github.com/gymnastjs/gymnast/pull/407
[x] Update dependencies (except nightwatch) https://github.com/gymnastjs/gymnast/pull/409
[x] Add support for flex-direction row and column https://github.com/gymnastjs/gymnast/pull/410
[x] switch top / bottom / right / left to "start" and "end" https://github.com/gymnastjs/gymnast/pull/410
[x] Add Col and Grid specific tests https://github.com/gymnastjs/gymnast/pull/411
[x] Remove setting fallback key through context https://github.com/gymnastjs/gymnast/pull/411
[x] Rename ConfigProvider to GymnastProvider https://github.com/gymnastjs/gymnast/pull/411
[x] Document reduced react tree on migration guide https://github.com/gymnastjs/gymnast/pull/412
[x] Publish flow and TS types https://github.com/gymnastjs/gymnast/pull/413
[x] Publish next as npm @next (manually released)

Post Release

[ ] Validate flow and TS types
[ ] Validate re-render inconsistencies on resolution changes fix
[ ] Validate performance against current gymnast

Before Master Release

[ ] Update package.json#publishConfig
[ ] Update default branch on https://gymnast.readme.io
[ ] Update README / code sandbox demo
[ ] Run semantic release dry run to ensure correct versioning

BREAKING CHANGES

<Col /> cannot be easily removed since it's used by other projects

next next: React Native support.

Closing to see if semantic release triggers a release when there's no PR attached to next

A version of gymnast has been released on the next branch. To try it out, run yarn<EMAIL_ADDRESS>


Lf 95 sdk execution files

TODOs:

[x] stop execution
[x] resume execution
[x] handling chain switches

Closed in favor of #143


Increase Buffer - Feature

Now it currently supports 32-bit. How to increase it?

Could you please provide more info on this issue?


All linting passes if flake8 is not installed.

Reproduction steps:
$> git clone git@github.com:btholt/grunt-flake8.git
$> cd grunt-flake8
$> sudo pip uninstall flake8
$> grunt flake8

All tests will pass, even if there are errors.
It's definitely outside of the scope of the task to try and get flake8 installed for you, but it needs to at least warn you/quit when it runs the command which flake8.
It should return the exit code from that which call, and display a failure message if that code is equal to 1.

I noticed this the other day, an error or warning should be triggered instead of just passing.

+1. I reproduce the problem.
1. Summary
Build passed, if flake8 isn't installed.
2. Files

Look at KiraFlake8 branch of my demo repository:

Gruntfile.coffee:

module.exports = (grunt) ->
    grunt.initConfig
        flake8:
            dist:
                src: "grunt_flake8.py"

    grunt.loadNpmTasks 'grunt-flake8'
    return

grunt_flake8.py — invalid file, no closed parentheses:

"""Docstrings."""
print("Kira Goddess!"

3. Behavior
3.1. flake8 exist
>> grunt_flake8.py … fail
>> grunt_flake8.py:1:1: E902 TokenError: EOF in multi-line statement
>> grunt_flake8.py:2:21: E999 SyntaxError: unexpected EOF while parsing
Warning: Task "flake8:dist" failed. Use --force to continue.

Aborted due to warnings.

3.2. flake8 no exist

Travis CI demo

>> grunt_flake8.py … pass
Done.
The command "grunt flake8 --verbose" exited with 0.

Thanks.


Added support for highgui module on WinRT 8.1+

Provides WinRT implementation for most of highgui API except for keybord and mouse events tracking. It enables using highgui quick preview and interaction API like namedWindow(), imshow(), createTrackbar() etc. from Windows Runtime 8.1+ applications.
Also updates existing FaceDetection sample to make use of highgui API.

Added support for highgui module on WinRT 8.1+: ca93b9c72d5b6f75a6c676138b611ae33a1a222d
Updated sample to showcase highgui WinRT usage: 6168d0d762f39edb1f65b0fa693405074d76c9e9

@vpisarev, @alalek
I'd like to kindly ask if this PR can be reviewed/merged by Tuesday next week (June 30). The reason is that there would be a period of unavailability afterwards and I wouldn't be able to respond to CRs and work on this PR. It's hard to tell how long would it last, so I'm looking to avoid the risk of eventually loosing this PR.
Thank you in advance

In general, Looks good to me, :+1:
Please squash 3rd and 1st commits to eliminate unnecessary changes from history (git history & git blame are powerful tools, but they require some commit policy)

@alalek  done, should be ready to go as soon as the builds get verified.

@alalek Looks like builds have passed, are we good to go?

Thanks!
:+1:

Thank you for prompt feedback, looking forward to having this merged :)


[No QA] Checkout repo before trying to use setupGitForOSBotify

Details
We were trying to decrypt files in the repo before checking it out. As a bonus, got rid of old debug job.
Fixed Issues
$ n/a – broken workflow: https://github.com/Expensify/App/runs/7326575491?check_suite_focus=true
Tests

Merge this PR
It should deploy to staging.

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Model bias monitoring

Related issues:

https://github.com/opendatahub-io/sig-ml-developer-experience/issues/36

@kywalker-rh How does this differ from #29 ?

@andrewballantyne Bias monitoring is a separate effort from the explainability UX so we split it up into two. They are often grouped together, but they will end up with different needs and designs. @vconzola Feel free to jump in if I didn't get it right or you want to add anything.


Remove version: Ryujinx.Ryujinx.Ava version 1.1.1403

part of #179207
All InstallerUrls returned 404 Not Found

https://github.com/Ryujinx/release-channel-master/releases/download/1.1.1403/test-ava-ryujinx-1.1.1403-win_x64.zip

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Ryujinx/release-channel-master/releases/download/1.1.1403/test-ava-ryujinx-1.1.1403-win_x64.zip
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


Update cartographer conventions release to v0.1.0-build.4

Co-authored with @derwei  : Bump Cartographer Conventions to v0.1.0-build.4 :

awesome! thank you! 😁  will cut a release soon including a new rc of carto too 👍 👍

Thanks Ciro!!


Tag DNSPolicy CRD as direct policy attachment class

Label the DNSPolicy CRD gateway.networking.k8s.io/policy: direct

Fixed in #416


inference using predict.py

i save a input.jsonlines file with this {
"document_id": "tc_mydoc_001",
"cased_words": ["Hi", "!", "Bye", "."],
"sent_id": [0, 0, 1, 1]
}
Now when i run command  python predict.py roberta "input.jsonlines" "output.jsonlines" --weights "data/roberta_(e20_2021.05.02_01.16)_release.pt"
using the weights downloaded from dropbox, it loads default config which gives errors maybe because it by default start training and when it gets no training file it gives error.
Can you please give me details how to run inference using custom input using pretrained weights file downloaded from dropbox?

Hi! Try this solution:
https://github.com/vdobrovolskii/wl-coref/issues/13#issuecomment-1044694236


Support reading from STDIN

Hey,
would be nice to transfer files with azcopy which are read by STDIN, like:
cat MYFILE | azcopy cp "https://myaccount.blob.core.windows.net/mycontainer/1file.txt?sastokenhere"

This is already implemented in azcopy v7.
Best regards,
Jonas

Hi @onny, thanks for reaching out! This feature is already implemented in V10 as well, we just haven't documented it officially yet.
The upload scenario works great, but the download scenario currently have a bug because we recently started printing "Scanning..." when the copy operation starts, this string unfortunately gets piped into the destination file when downloading. I'll fix this as soon as possible and also add documentation for this feature.

This bug seems to be raised for the STDIN ( the upload scenario)... So there is no bug here.. Right ?

@seguler yes you are right, I just wanted to use this issue for tracking purpose. I updated the tags accordingly. Thanks!

Hi @onny, this was fixed in v10.0.1.

Hi @zezha-msft  how do you use STDIN/STDOUT with AzCopy? I'm looking for the same thing


Add ConnectionMetadata.getDatabaseMajorVersion() and getDatabaseMinorVersion()

Feature Request
Is your feature request related to a problem? Please describe
When working with JDBC's DatabaseMetaData, I don't recall having ever used DatabaseMetaData.getDatabaseProductVersion(), which returns a string. The String is maybe useful to display in logs, or whatever, but in programmatic version specific logic, I've always appreciated the DatabaseMetaData.getDatabaseMajorVersion() and DatabaseMetaData.getDatabaseMinorVersion() methods much more. Querying them is much less error prone than relying on some string unformatting.
Describe the solution you'd like
Would be useful to have these methods also in R2DBC
Describe alternatives you've considered
Well, for now, I'll just parse the strings that the drivers offer me, or I ignore the versions.
Teachability, Documentation, Adoption, Migration Strategy
R2DBC tends to return nullable Integer types for compatibility reasons, so drivers can opt in to implementing these methods or just return null.

Version numbers can be tricky because every server is doing versions differently (SQL Server 2018, version 14.00.3365, Postgres 13, version 13, and so on). We could follow the JDBC model and let drivers and consumers try to make sense out of the information.
It would be good to get a bit more opinions and how that information is used by folks that depend on the database version so we can come up with something useful.

Version numbers can be tricky because every server is doing versions differently (SQL Server 2018, version 14.00.3365, Postgres 13, version 13, and so on). We could follow the JDBC model and let drivers and consumers try to make sense out of the information.

Sure, it's weird. But it works in JDBC :)

It would be good to get a bit more opinions and how that information is used by folks that depend on the database version so we can come up with something useful.

Yeah, not the most pressing issue


chore: Add bcryptjs to list of recommended libraries

Description
This PR adds bcryptjs to the list of recommended libraries
PR fixes following issue(s)
Fixes #25282
Media

Latest DP
https://appsmith-31pw51tul-get-appsmith.vercel.app/
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[x] Manual
[ ] Jest
[ ] Cypress

Test Plan

[x] Install and uninstall library
[x] lint errors during uninstallation and clearing it during reinstallation
[x] Edit and deployed mode behaviour
[x] Sanity of all links
[x] UI check
[x] App export/import/fork flow

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[x] Speedbreak features have been covered
[x] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[x] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[x] Cypress test cases have been added and approved by SDET/manual QA
[x] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true env=release

LGTM @ohansFavour

/perf-test


How to add backbone or loss functions ?

I love mmdetection very much. I want to know how to add backbone or loss functions that are not officially provided to mmdetection?

Please refer to the documents:
https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html
https://mmdetection.readthedocs.io/en/latest/tutorials/customize_losses.html


Use Sinopia Editor for Creating/Updating Resource Templates

Based on @justinlittman's prototype work in PR https://github.com/LD4P/sinopia_editor/pull/2326, finish implementing and provide feature tests for editing resource templates as resources in the editor. This issue is blocked until/if @michelleif approves this major change to how resource templates are managed within Sinopia.
Blocks https://github.com/LD4P/sinopia_profile_editor/issues/403

Closing merged #2326


How to do, NOT to apply forbidden words in minions?

I think that
if (!this.socket.playerTracker.isMi && this.gameServer.checkBadWord(name))
but im wrong

forbidden words in minions
ummmmmmmm what

Hey there!
This is the issues section of MultiOgar-Edited. Only issues and feature-requests are to be put here. We do not support questions about programming a custom function in. The code is pretty documented with comments, and is provided as-is. If you require support for this project please contact someone with experience that is willing to help.
Enjoy!

@MastaCoder like you 💯 🥇


check if blob is loaded before trying to load again

We have had race conditions where a blob is loaded but not yet marked as such in BlobStatus (e.g. it checks BlobStatus as the other is loading; by the time it gets to load, it does not have a LOADED status but it already is in containerd and the file is deleted from verified).
This checks not only the status, but also the state in containerd to avoid reloading.
It probably also should reload blob status, but that is for another PR.

Tested the scenario by applying this PR. It works and the app gets deployed successfully without any stutter.

Thanks @vignesh-zededa . So we just need to wait to resolve the design question @eriknordmark raised. When he responds, I will update this one.

We have had race conditions where a blob is loaded but not yet marked as such in BlobStatus (e.g. it checks BlobStatus as the other is loading; by the time it gets to load, it does not have a LOADED status but it already is in containerd and the file is deleted from verified).

I thought this was due to concurrency, but since the only goroutine doing this (for now) is the single worker goroutine, that isn't the case.
Is it because we have repeated blob shas in a single ContentTree? In that case we need to make sure that we operate with a list of pointers to BlobStatus and not with a list of BlobStatus.

I thought this was due to concurrency, but since the only goroutine doing this (for now) is the single worker goroutine, that isn't the case.

We have to have at least 2 routines: the main one and the worker.

Is it because we have repeated blob shas in a single ContentTree? In that case we need to make sure that we operate with a list of pointers to BlobStatus and not with a list of BlobStatus.

Actually, that is interesting, and also possible. Either would be addressed by this PR.

We have to have at least 2 routines: the main one and the worker.

Sure, but the main goroutine doesn't load things into CAS.
Anyhow, since this is fixing the issue at hand I'll pull it and we can discuss more tomorrow.


Doc typo - missing space between words Distance and Direction widget

Distance and Direction (Doc) on page 12 "Configure the distance and direction widget" there needs to be a space between The and confic and in step 5 and Save and config.json in step 7.
theconfig.json
Saveconfig.json and refresh the application to view labels within the widget.

Fixed.

verified. closing


QAQC for European surveys

Comparing weights from abundance and length, and reported weights in the datasets. New folder with results on this available: https://github.com/AquaAuma/FishGlob_data/tree/main/QAQC/DATRAS
More work/checks need to be made for surveys for which weights don't match, but abundances do. Most likely due to three aspects (i) quality of length-weight relationships, (ii) units/values of lengths in the datasets, (iii) units of reported weight at the haul level, as was noted as an issue by DATRAS
https://www.ices.dk/data/data-portals/Pages/DATRAS-News-and-updates.aspx

(iii) does not affect the current dataset, because we did not use the reported weights, but the re-calculated ones

we documented the correlations between reported weights and re-estimated weight from abundance at length in DATRAS surveys to make users aware of this issue in the dataset, but the ICES DATRAS Data team (Vaishav Soni) indicated this was an ongoing issue for which they're working on solutions.


Inference

Can you publish the inference code?

Hi, the inference code is available in inference.py. Unfortunately, this is still a working version of it (i.e. no comments, and there might be smaller bugs) as we're currently working on moving the project into another framework. Hopefully once that's done in the coming months, we will be able to update this repository with a cleaner version of the inference script.
However, if you have good python / pytorch understanding, running the inference script should be possible without too many issues.


read_csv - pandas_kwargs argument

Describe the bug
I want to use the wr.s3.read_csv() method to read csv files in s3.
When reading the files I want to specify the the dtype of the dataframe to be str.
However, when specifying the dtype under pandas_kwargs I get the following error:
TypeError: parser_f() got an unexpected keyword argument 'pandas_kwargs'
Code
Here is the code I am using:
df = wr.s3.read_csv(         path=object_key,         pandas_kwargs={             'dtype':str         }     )
I am using awswrangler==1.5.0 and python version 3.7.7

@armandwfourie  I would not say that it is a bug. Because pandas_kwargs in wr.s3.read_csv(path=path, **pandas_kwargs) is a keyworded argument(https://book.pythontips.com/en/latest/args_and_kwargs.html) . So you can directly assign dtype={'col': str} in the function like:
df = wr.s3.read_csv( path=object_key, dtype={'col': str})

And dtype should be a dict format. please the example from pandas official document below:
dtypeType name or dict of column -> type, optional
Data type for data or columns. E.g. {‘a’: np.float64, ‘b’: np.int32, ‘c’: ‘Int64’} Use str or object together with suitable na_values settings to preserve and not interpret dtype. If converters are specified, they will be applied INSTEAD of dtype conversion.

Other pandas keywords and more detailed information you could find are in this document: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.read_csv.html

Hi @armandwfourie, thanks for reach out to us!
@bryanyang0528 explained it perfectly 👍
Please, let us know if it resolve your problem.

Thanks for the quick response guys... Assumed that this would be referenced the same way as the s3_additional_kwargs.
This worked great thanks!

Hi @armandwfourie !
It is totally off-topic, but we are stating a "Who uses AWS Data Wrangler?" section. So feel free to add yourself if you want 😄 .


Update docs for multiple worker node groups & resolvConf

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm


fix(pack): servicePath not set for invoke local

I debugged the problem #120 and found that the function invokeLocalNodeJS will use this.serverless.serviceDir to set the path to the transpiled handler entry file.
I also compared this with serverless-webpack and they handle this similar.
@floydspace can you check if I missed to set this correctly when service.package.individually is set to true.

Hey @aheissenberger thank you for contribution, I think this is the reason, I checked the serverless-offline plugin - it indeed relies on this option. merging it.


Add NC scrape

https://www.nccommerce.com/data-tools-reports/labor-market-data-tools/workforce-warn-reports
These are PDFs for each year.
The PDFs are well structured (as least for 2021), but as always, we should inquire with state if they're willing to post the Excel files to avoid PDF scraping.

At least two levels of scraping HTML to get to the PDF, some additional tables in there to ignore and a slightly different table format with less structure in earlier years, but otherwise as described.


feat(conductor): implement verification of chain IDs commitment

Summary
previous PR implemented generating the chain IDs commitment in prepare_proposal and verifying it in process_proposal. this PR finishes the job by ensuring the chain IDs commitment is verified in conductor.
Background
required so that we can ensure that the sequencer-relayer actually wrote data for every rollup ID in a block, previously it would have been able to omit data for a whole rollup without detection. we still need to implement slashing (eventually) for this - what happens right now is that the conductor will fail to verify a block if the commitment does not match up, even if it was able to obtain the rollup data for its own chain ID.
Changes

ensuring the chain IDs commitment is verified in conductor
update the sequencer app and SequencerBlockData::from_tendermint_block to handle a block with 2 commitments at the start of the txs correctly; this should have been done in my previous PR, apologies
update ChainId to be max 32 bytes

Testing
unit tests
Related Issues
closes #308

@noot PR #375 and #376 have been merged, unblocking (but also breaking :-( ) this. If you want I can fix this PR.

@SuperFluffy no worries, I can fix it later today!


ADD Q&A Suggestion Template

Pull Request Checklist
Thank you for contributing to our project! Please ensure the following before submitting your pull request:
Description of Changes
Incorporating a Q&A Suggestion Template into the project to improve communication and collaboration. This template allows users and contributors to ask questions and make suggestions in a structured manner, making it easier to track, respond to, and implement feedback. This addition enhances user engagement, helps identify potential improvements, and supports a continuous improvement process for the project.
Type of Change

[ ] Bug fix
[x] New feature
[x] Documentation update
[ ] Refactoring
[ ] Other (please describe):

Related Issue
Closes: #255
Testing
To ensure the template works as expected, a series of mock Q&A submissions were created using the new template. This process validated the format and verified that all fields render correctly on GitHub. Additionally, multiple team members reviewed the template to confirm it is intuitive and easy to use for new contributors.
Checklist

[x] I have tested my changes and ensured they work as expected.
[x] I have added necessary documentation (if applicable).
[x] I have reviewed my code for style and linting issues.
[x] I have ensured that any dependent changes are merged before this PR.

Additional Notes
This Q&A Suggestion Template aligns with our project’s goal of fostering a collaborative environment. It was developed with feedback from contributors who requested a dedicated space for questions and suggestions. Further adjustments can be made based on additional feedback after implementation.

@Vimall03 the task has been completed. Kindly check the PR
Dont forget to add label "GSSOC-EXT"


HOMEBREW_CACHE replacement during installation?

Cookbook version
2.1.0
Chef-client version
12.12.15
Platform Details
OS X 10.11.6 with chef-client run as service (created by chef-client resource)
Scenario:
When deploying system, a kickstart script install chef and register workstation to my chef server and run content from a default role.
The kickstart occur when the target admin account owning the homebrew setup has never been logged to the Mac (installation done with https://github.com/MagerValp/CreateUserPkg)
Steps to Reproduce:
Run the homebrew installation from chef-client run as a launchd service when the target admin as never been connected to the mac
Expected Result:
homebrew should install and admin account should be OK
Actual Result:
Due to HOMEBREW_CACHE localization, the installer create a partial home folder for the never logged admin.
When the admin authenticate after, the system will display a lot of errors saying that Library is broken. This is because home folder exist but is empty. So all OS X home folder creation system are blocked due to files in HOMEBREW_CACHE
Homebrew cookbook should play with env to avoid using cache folder in /Users but in /tmp for example.

I don't think this is an issue with this cookbook, I think you should adjust your build scripts so the users are properly provisioned prior to running Homebrew as them.

Since provisioning home folder on OS X mean human based login I think this cookbook should be updated.
Otherwise system automation is 100% useless if I need to have a human to be connected on the admin account before being able to run chef using home brew.

Pretty sure given the timing of this issue that this was adjusted upstream as well in homebrew. Closing but please do open a new one with the repro steps if still present.


SOMA name prefixing

The abstract spec has names like SOMADataFrame which is fine.
In Python were package names are explicit:
import tiledbsoma
sdf = tiledbsoma.SOMADataFrame(uri)

is repetitive.
In R it's not repetitive:
library(tiledbsoma)
sdf <- SOMADataFrame(uri)

Proposal:

For Python, omit SOMA prefixes from class names, so sdf = tiledbsoma.DataFrame(uri)
In R, leave them so sdf <- SOMADataFrame(uri)
In both cases, s-o-m-a gets uttered just once; with a dot in Python, and without in R

@thetorpedodog I'm fast-tracking on request of @bkmartinjr :v: -- I will try to get this out today

#464 is merged


[Bug]: The anchor tag is not directing to its position

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
contact us button is not opening the location of contact us

Add ScreenShots
No response
What browsers are you seeing the problem on?
Chrome
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@OpenTekHub Kindly assign this issue to me

Please can i fix this issue please assign it to me


Add table of content for all available readme.md files

Make a table of content for better navigation of readme.md files.

Hi, I'd like to assign myself to this. Please could you just clarify the issue a bit further?

yes, kindly add sample readme.md files for all framework along with .gitignore files.


WIP compiling LLVM 9.0.0

This PR is for compiling with LLVM 9.0.0.

as part of this PR @kulibali, i think we should update the vendored LLVM to use 9.0.0 instead of 7.0.1.
once we get there, we'd also want a changelog entry as well.

Ok, will do.

@kulibali i deleted my comment. decided that it was out of scope and should be done as part of a different PR. only thing i think we need is a changelog for 9.0.0 support when it comes.

I'm wondering if there is any list of pending tasks or known bugs on moving toward 9.0?
The only TODO list I found now are the failing tests in some of the build bots.

There are failing tests on both Windows and Linux that need to be fixed -- that's the main area that we need help in.
Also the Linux CI setup needs to be updated to build with LLVM 9, but the branch should be rebased before doing that since Sean has been making lots of changes to the CI.

I just came up with some small fixes, what is the best way to present them here? Fork and PR maybe?

Yes please.

Or if the diff is small enough, just include it here.

The diff is pretty small so I'll just post it here:
diff --git a/src/libponyc/codegen/codegen.c b/src/libponyc/codegen/codegen.c
index 91bf4b3c..1b89b16d 100644
--- a/src/libponyc/codegen/codegen.c
+++ b/src/libponyc/codegen/codegen.c
@@ -1179,7 +1179,7 @@ void codegen_poptry(compile_t* c)

 void codegen_debugloc(compile_t* c, ast_t* ast)
 {
-  if(ast != NULL)
+  if(ast != NULL && c->frame->di_scope != NULL)
   {
 #if PONY_LLVM < 900
     LLVMSetCurrentDebugLocation2(c->builder,
@@ -1194,9 +1194,7 @@ void codegen_debugloc(compile_t* c, ast_t* ast)
 #if PONY_LLVM < 900
     LLVMSetCurrentDebugLocation2(c->builder, 0, 0, NULL);
 #else
-    LLVMMetadataRef loc = LLVMDIBuilderCreateDebugLocation(c->context, 0, 0,
-      c->frame->di_scope, NULL);
-    LLVMSetCurrentDebugLocation2(c->builder, loc);
+    LLVMSetCurrentDebugLocation2(c->builder, NULL);
 #endif
   }
 }

Here is the root cause:
Previously we use our own wrapper function, LLVMSetCurrentDebugLocation2 (it has the same name as another API in LLVM 9, unfortunately) defined in src/libponyc/codegen/gendebug.cc, to attach the debug MD. That wrapper called DebugLoc::get(...), which will do sanity check on the scope parameter and use an empty DebugLoc (which will not even attached on an instruction actually) instead if the scope is null.
The new API we use, LLVMDIBuilderCreateDebugLocation and LLVMSetCurrentDebugLocation2 in LLVM 9, will not do any sanity check on scope. So it's possible to have a DILocation with a null scope. However, LLVM verify rules doesn't allow null scope, so it bail out.
The fix I just presented will match the behavior of old LLVM: If the scope passed in is null, don't even create a DebugLoc for it.

Awesome, thanks @mshockwave!

Windows is working now. The one remaining issue is that CodegenTest.TryBlockCantCatchCppExcept fails on Unix, only when it is run in combination with other codegen tests. If it is run by itself it succeeds.

Yes I also found that problem. It didn't appear when using LLVM 7 and it's more difficult to debug since most of the stack frames are corrupted when looking into it with a debugger. My rough guess will be something to do with different EH behaviors in LLVM 9 or libunwind.

FYI, 9.0.1-final is scheduled for 9 Dec 2019

Building with 9.0.1-rc1 shows the same problem in CodegenTest.TryBlockCantCatchCppExcept on Linux.

@kulibali all the tests are passing, what environment are you getting a failure in?

O I C, this isn't testing with using 9.0.0, right?

@SeanTAllen I don't think any of the bot is using 9.x now

So I finally figure out the problem on the CodegenTest.TryBlockCantCatchCppExcept test case. It took me so long (at least a month I would say) to dig out the root cause, which is pretty complicate and required an separate matter to describe it. So I will only put the solution here:
Again, the problem falls inside the LLVM part. Apply the following patch on the release/9.x branch of LLVM and you're good to go.
diff --git a/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp b/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
index 925049b2a1b..b30628a6448 100644
--- a/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
+++ b/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
@@ -226,6 +226,7 @@ void SectionMemoryManager::invalidateInstructionCache() {
 }

 SectionMemoryManager::~SectionMemoryManager() {
+  deregisterEHFrames();
   for (MemoryGroup *Group : {&CodeMem, &RWDataMem, &RODataMem}) {
     for (sys::MemoryBlock &Block : Group->AllocatedMem)
       MMapper.releaseMappedMemory(Block);

Just an off-topic story: this bug has been discovered since 2015: https://bugs.llvm.org/show_bug.cgi?id=23991
But it never got fixed due to the rapid-changing architecture of ORC JIT in recent years.
Also, this bug is actually pretty hard to triggered in real-world Pony: you need to invoke PonyJIT several times (at lease 10 times) within single program execution.

Awesome! Thanks so much @mshockwave!

Update: During my development I temporarily comment out the -static-libstdc++ flag in Makefile:
diff --git a/Makefile-ponyc b/Makefile-ponyc
index 9f031a2d..85875f0c 100644
--- a/Makefile-ponyc
+++ b/Makefile-ponyc
@@ -187,7 +187,7 @@ endif
 ifneq (,$(filter $(link),static llvm-static))
   LLVM_LINKING =--link-static
   ifeq (,$(filter $(OSTYPE),bsd osx))
-    LINKER_FLAGS += -static-libstdc++
+    #LINKER_FLAGS += -static-libstdc++
   endif
   ifneq (,$(shell $(CC) -v 2>&1 | grep gcc))
     LINKER_FLAGS += -static-libgcc

And I found my solution doesn't work if I restore the Makefile 😢
Looks like we need more investigation

We have decided to:

Disable this test for now, as it seems to be related to the JIT and does not necessarily affect regular programs.
Update vendored LLVM to 9.0.x and merge.
Create issues to investigate further, both the JIT issue and also exception handling on Windows.

@mshockwave your fix worked for me in a fresh docker container (i confirmed the segfault prior to applying your diff):
[----------] Global test environment tear-down
[==========] 1364 tests from 48 test cases ran. (69793 ms total)
[  PASSED  ] 1364 tests.
root@12d2f5497507:/home/pony/ponyc# ./build/release/ponyc --version
0.33.0-cd7805ad [release]
compiled with: llvm 9.0.1 -- cc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
Defaults: pic=true
root@12d2f5497507:/home/pony/ponyc# git diff
diff --git a/lib/llvm/llvm-8.x.cfg b/lib/llvm/llvm-8.x.cfg
index e73df4e6..d70d3eea 100644
--- a/lib/llvm/llvm-8.x.cfg
+++ b/lib/llvm/llvm-8.x.cfg
@@ -1 +1 @@
-LLVM_CHECKOUT_REF := release/8.x
+LLVM_CHECKOUT_REF := release/9.x
diff --git a/lib/llvm/src b/lib/llvm/src
index 4856a933..c1a0a213 160000
--- a/lib/llvm/src
+++ b/lib/llvm/src
@@ -1 +1 @@
-Subproject commit 4856a9330ee01d30e9e11b6c2f991662b4c04b07
+Subproject commit c1a0a213378a458fbea1a5c77b315c7dce08fd05-dirty
root@12d2f5497507:/home/pony/ponyc# cd lib/llvm/src
root@12d2f5497507:/home/pony/ponyc/lib/llvm/src# git diff
diff --git a/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp b/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
index 925049b2a1b..b30628a6448 100644
--- a/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
+++ b/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp
@@ -226,6 +226,7 @@ void SectionMemoryManager::invalidateInstructionCache() {
 }

 SectionMemoryManager::~SectionMemoryManager() {
+  deregisterEHFrames();
   for (MemoryGroup *Group : {&CodeMem, &RWDataMem, &RODataMem}) {
     for (sys::MemoryBlock &Block : Group->AllocatedMem)
       MMapper.releaseMappedMemory(Block);
root@12d2f5497507:/home/pony/ponyc/lib/llvm/src#

@kulibali  that sounds a reasonable decision. This issue has taken me and rest of us too much time. Regardless, I think we still can create a JIT fix patch mentioned earlier for our vendored LLVM
@dipinhora thanks for your verifying. That reminded me a config that was different from the usual building process: I'm linking all the LLVM libraries dynamically.
I will also report our discovery regarding the JIT issue to the LLVM community.

There was a small twist regarding the JIT fix patch I posted earlier: One of the ORC JIT creators, Lang Hames, also committed a patch to solve the same problem (i.e. missing EH frames deregistration in ORCv2) but with a more general solution. So I think (before we synchronize with upstream LLVM) we should use that patch instead.
Also, I did some extra experiments to confirm that under the following conditions, both my patch and Lang's patch will fix our problem:

Link libstdc++ statically
Link LLVM libraries statically
Link libgcc statically

Which, are the "normal" build configurations.

@kulibali LLVM 9.0.1 doesn't seem to have been released yet, what version is the vendored LLVM updated to? 9.0.0? an rc candidate for 9.0.1?

9.0.1 final has been tagged; the vendored LLVM is at c1a0a213378a458fbea1a5c77b315c7dce08fd05 llvmorg-9.0.1.

Awesome. @kulibali I'm going to add a couple of CHANGELOG entries to this PR.

@kulibali I fixed a small formatting error. I'm going to make sure it passes CI and will then merge.

Party time @kulibali. This one was merged.


get query returns null but search query returns the correct record.

Note: If your issue/bug is regarding the AWS Amplify Console service, please log it in the
Amplify Console GitHub Issue Tracker

Describe the bug
Search query will return one record, which is the record I am looking for
{
  searchModel(filter: {
    id: {
      eq: "8ff0cdf9-e2f1-4f5f-b5d6-e97f05cb993b"
    }
  }) {
    items {
      id
    }
  }
}

but get query will return null
{
  getModel(id: "8ff0cdf9-e2f1-4f5f-b5d6-e97f05cb993b") {
    id
  }
}

Amplify CLI Version
4.18.0
To Reproduce
I am unsure how to reproduce this, it simply happened out of nowhere which is very weird...
Expected behavior
Get query should return correct record.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Mac/Windows/Ubuntu]
Node Version. You can use node -v to check the node version on your system

This is not applicable as I used the AppSync console to run those queries
Additional context
I'm thinking this might be related to this https://github.com/aws-amplify/amplify-cli/issues/3705

Look like the record is not in the DynamoDB because when I tried to find the ID, it did not return any records. I am unsure how that happened.

@aprilmintacpineda Can you provide more detail about your project configuration or detailed repro steps if possible? Without more information, there's not much we can investigate.

@edwardfoyle I am very sorry but I also don't have enough details to figure out what may have happened and how to replicate it. The record was created last April 13 and I experienced the said issue on April 14 when I tried to get the record, I tried to figure it out before opening this issue and tried to ask around but couldn't find anything useful so I decided to open a ticket in hope that someone out there may have experienced the same issue... Very sorry, but I'm trying to figure out how to replicate it, if I find anything, I will definitely update this...

@aprilmintacpineda Yes please let us know if you find any more details. A few questions that may help us debug:

Did this only happen once or it happens every time with that id?
Has it happened with other records, or just that one?
Was there ever a duplicate of this record entered or a record that was deleted and then another added with the same id?

Closing due to lack of response. Please follow up below if you have more debugging info.


Fix minishift deployment

Minishift was pretty broken - this should improve things a bit.

This PR is stale and is now too far out of date :(


Revert "fixed usm encoding protocols CODEOWNERS (#25932)"

What does this PR do?

Motivation
Attempt to fix incident 27674, since this commit the k8s-e2e-cspm-main test is failing consistently

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


ORACLEDB: Updated handling of connection errors for disposal

Solves #2514 and #2603. I tested it on my-machine 😄 I am thinking that simulating this will be tricky and probably take about 15-20 minutes for oracle (or maybe I am exaggerating)
In addition to updating connection error list, we also need to update oracledb to check for connection errors.
Disclaimer: I am not good with vanillajs (prototypes etc.) so it would be great if someone reviews the syntax/approach.

To me code looks pretty good, I would need to checkout the connection.__knex__disposed setting if that is the thing that should be done there (probably it is correct though). @atiertant how does tihs looks to you?

@cemremengu oracle database has a dead connection detection mechanism but we should call connection.close before set the connection.__knex__disposed.
@elhigu looks great, but didn't tested it

@atiertant calling connection.close seems to throw an error though so I am not sure if it achieves anything
 ERROR 8672 nodejs.unhandledRejectionError: NJS-003: invalid connection

@cemremengu see node-oracledb examples
https://github.com/oracle/node-oracledb/blob/master/examples/select1.js#L73
should ask @cjbj on a node-oracledb issue which errors needs to close the connection and which other need only to remove the connection object from pool ...
can't find this kind of mechanism in the node-oracledb driver pool, does it has the same bug ?

Added connection.close() to conform what @cjbj stated

Closing the connection is the way to remove it from the connection pool, which is important so the pool slot can be reused by a new valid connection. You should always call conn.close(). What you may want to do is ignore errors on the close.

The issue heading mentions oracledb but the files changed are for dialect/oracle, not dialect/oracledb.  Is this what you intended?
Also, my comments about connection pooling are for the node-oracledb connection pool, which isn't used in dialects/oracledb

@cjbj Does that mean that currently used list of errors that should close connections is invalid in case of not using oracledb connection pool?

@kibertoad the ORA errors that indicate a bad connection are pretty much going to be the same for pooled & non-pooled connections.  You could check for the same numbers that ODPI-C uses, see my earlier link.

@cemremengu Could you please provide me write permissions to your repo so that I could fix the PR accordingly to cjbj's comments without forking and resubmitting the pr?

@cjbj Thanks!

@kibertoad Sorry, snowed under work lately. Updated the error list accordingly

@cemremengu looks like there are random failures, can you rerun tests by closing and opening pr?

@kibertoad done. Also given you permission in case you want to tweak stuff

awesome, thank you! also tests passed, yay :)

I think this could be tested by mocking/monkeypatching client.isConnectionError method and returning the original implementation after tests.

@elhigu What should such test assert?

@kibertoad that connection state is set to disposed in all of the changed code paths (test should fail before this change).

What's the status of this PR?

@alanchristensen I could resolve the merge conflict, but would really appreciate it if someone else wrote the test :)

Hi, any updates on this?
Looks like it could solve the issues when oracle connections are consuming one pool's connection and failing each request that fall in that connection.

@pablopen Any chance you would volunteer to write at least some test for it?

@kibertoad I could try. I'll check elhigu suggestion of mocking the errors.

@pablopen You are my hero :)

I would still have preferred having some tests for this, now this is waiting for regression to happen if anyone ever touches that code.

@elhigu In ideal world, yes. However, year passed, and noone did, and I lost all hope to ever get to it myself; and this change is both straightforward enough and useful (as evidenced by already reported problems solved by it).

In this particular case I considered that benefits were bigger than risks of it causing problems later on.


HDFStore: AttributeError: exit in with statement

I have this method in a class:
def save(self, filename, key='/'):
    """Saves to an HDF5 store."""
    with pd.HDFStore(filename) as store:
        for g in self.GENDERS:
            df = getattr(self, g)
            store.put(key+g, df,
                      data_columns=df.columns,
                      format='table',
                      encoding='utf-8',
                      dropna=False)

and in my Unittest:
def test_save_to_hdf(self):
    td = TrackData()
    with tempfile.NamedTemporaryFile(suffix='.h5') as temp:
        td.save(temp.name)

When I run nosetests I get this:
ERROR: test_save_to_hdf (courtana.tracker.tests.test_trackdata.TestTrackData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/hugo/projects/courtana/courtana/tracker/tests/test_trackdata.py", line 34, in test_save_to_hdf
    td.save(temp.name)
  File "/home/hugo/projects/courtana/courtana/tracker/trackdata.py", line 54, in save
    with pd.HDFStore(filename) as store:
AttributeError: __exit__

Why did this suddenly stop working?

the HDFStore context manager was introduced in 0.15.2. are you sure you are using the same (or greater version). as you say

Why did this suddenly stop working?

stop working from what?

Yeah I'm reaching that conclusion... I think I messed around with my virtualenvs and I'm doing the tests with version 0.13... Thank you for the hint!

Ok turns out it is not an old version problem. I'm using 0.16.0 and still get that error.

stop working from what?

When I use that code (save method) outside my Test class it works.

I don't think pd.HDFstore was ever a context manager. You want pd.get_store(filename)

That is also referenced in #8791. But I find it odd that it is not mentioned in the docs. I can only find a pd.get_storer().
But note that the pd.HDFStore is mentioned in the docs and an example is given with a with statement (IO Tools)
# Working with, and automatically closing the store with the context
# manager
In [266]: with HDFStore('store.h5') as store:
   .....:     store.keys()
   .....:

So what's the correct way of doing this?

@cachitas what you posted above should work just fine.
so be sure you have at least 0.15.2.

I figured it out. For some reason I had version 0.16.0 in my virtualenv but when nosetests ran it was reporting 0.14... I reactivated it and it was solved. Looks like this was only a version issue from my side.


OR-1413 update contracts

Fix cannot withdraw from L2 if depositing by using L1CrossDomainMessenger for the first time
Reason: overflow in L1StandardBridge.finalizeERC20()
Test: start running a new devnet,  cd packages/tokamak/sdk, fund token and setup .env

Deposit: npx hardhat deposit-native-token-via-messenger --amount "5" --network devnetL1
Withdraw:  npx hardhat withdraw-native-token --amount "2" --network devnetL1

Thank you!

@nguyenzung Thank you very much. It works well.
I added some code and push it. If you have some good idea, please let me know.

We need some L2 native token in bridge test. We can use it before bridge test for L2 native token (https://github.com/tokamak-network/tokamak-titan-canyon/pull/81/commits/54b4003f20ff92b2bf9e906b9a624a27fbee8964)
For using .env in hardhat, we should import it to hardhat.config.ts (https://github.com/tokamak-network/tokamak-titan-canyon/pull/81/commits/4bffefab5b55e07d75faf975dd2c28c696e21841)

And, To testing withdrawals for native token, we need some TON in L2 below. The amount "5" is too low to pay txn fee. tx fee in L2 is about 0.0002 (unit: Ether)
npx hardhat withdraw-native-token --amount "2" --network devnetL1
Setup task...
Withdraw Native token: 2
l2 native token balance in L1:<PHONE_NUMBER>00000000002
l2 native balance:<PHONE_NUMBER>999814002
withdrawal Tx: 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9  Block 10052  hash 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9
l2 native balance:<PHONE_NUMBER>999662110
Prove the message
Proved the message:  0xc490ea83ced61581887e563e00b5bf11d6a056ad5810f0a45ee47c3ce07ce6ed
l2 native token balance in L1:<PHONE_NUMBER>00000000002
Finalized message tx 0xcda36c254cb208de3382883cea23623a1af45096acb91b4e4d1058a68781b157
Finalized withdrawal
l2 native token balance in L1:<PHONE_NUMBER>00000000004

@nguyenzung Thank you very much. It works well.
I added some code and push it. If you have some good idea, please let me know.

We need some L2 native token in bridge test. We can use it before bridge test for L2 native token (54b4003)
For using .env in hardhat, we should import it to hardhat.config.ts (4bffefa)

And, To testing withdrawals for native token, we need some TON in L2 below. The amount "5" is too low to pay txn fee. tx fee in L2 is about 0.0002 (unit: Ether)
npx hardhat withdraw-native-token --amount "2" --network devnetL1
Setup task...
Withdraw Native token: 2
l2 native token balance in L1:<PHONE_NUMBER>00000000002
l2 native balance:<PHONE_NUMBER>999814002
withdrawal Tx: 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9  Block 10052  hash 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9
l2 native balance:<PHONE_NUMBER>999662110
Prove the message
Proved the message:  0xc490ea83ced61581887e563e00b5bf11d6a056ad5810f0a45ee47c3ce07ce6ed
l2 native token balance in L1:<PHONE_NUMBER>00000000002
Finalized message tx 0xcda36c254cb208de3382883cea23623a1af45096acb91b4e4d1058a68781b157
Finalized withdrawal
l2 native token balance in L1:<PHONE_NUMBER>00000000004

Thank you very much.
Your added feature is very helpful. I have fund token manually before.
I will add more code to calculate gas used and print it out. It will help us see the result more clearly.
In fact, when testing I usually use much larger number like 1ETH or 2ETH

@nguyenzung Thank you very much. It works well.
I added some code and push it. If you have some good idea, please let me know.

We need some L2 native token in bridge test. We can use it before bridge test for L2 native token (54b4003)
For using .env in hardhat, we should import it to hardhat.config.ts (4bffefa)

And, To testing withdrawals for native token, we need some TON in L2 below. The amount "5" is too low to pay txn fee. tx fee in L2 is about 0.0002 (unit: Ether)
npx hardhat withdraw-native-token --amount "2" --network devnetL1
Setup task...
Withdraw Native token: 2
l2 native token balance in L1:<PHONE_NUMBER>00000000002
l2 native balance:<PHONE_NUMBER>999814002
withdrawal Tx: 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9  Block 10052  hash 0x29ebf7d76e45589a0d6b418b72b8ee2c46a40902ab9e5e8b99de98ca41c04fc9
l2 native balance:<PHONE_NUMBER>999662110
Prove the message
Proved the message:  0xc490ea83ced61581887e563e00b5bf11d6a056ad5810f0a45ee47c3ce07ce6ed
l2 native token balance in L1:<PHONE_NUMBER>00000000002
Finalized message tx 0xcda36c254cb208de3382883cea23623a1af45096acb91b4e4d1058a68781b157
Finalized withdrawal
l2 native token balance in L1:<PHONE_NUMBER>00000000004

Thank you very much. Your added feature is very helpful. I have fund token manually before.
I will add more code to calculate gas used and print it out. It will help us see the result more clearly. In fact, when testing I usually use much larger number like 1ETH or 2ETH

I added gas-cost-calculation in withdrawal task. Those numbers are correct.


refactor(CreateMany): Apparently you can only update 40 documents at a time.

:tada: This PR is included in version 2.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ignore some auxiliary files from knitr

knitr is an R package that can be used to compile a .Rnw file containing both LaTeX and R source code to a .tex file, which can then be further compiled to a .pdf file with your favorite TeX engine. When the R source code generates images (e.g., a graph), it will create some auxiliary files, including .tikz file(s) and a BASEFILENAME-tikzDictionary file (at least if the dev chunk option is set to 'tikz'). Additionally, if opts_knit$get('concordance') is TRUE, then an auxiliary BASEFILENAME-concordance.tex file is generated. None of these things need to be tracked with version control.

Thanks for this! :sparkles:


[Bug]Metamask signature does not work.

Describe the bug

After the metamask is logged in, the signature process is called, but not only is the metamask not opened, but the signature process is not called.

To Reproduce
Steps to reproduce the behavior:

Launch metamask and connect
Go back to the app and "sign wallet
launch metamask and sign
go back to the app and log in

Expected behavior
Transition to the meta mask and expect to be able to process signatures
Screenshots

I want to send a video, but skip it because it contains meta mask information.

Smartphone (please complete the following information):

Device: Google Pixel 7
OS: 14

Flutter Doctor
[✓] Flutter (Channel stable, 3.16.5, on macOS 14.4.1 23E224 darwin-arm64 (Rosetta), locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.88.0)

Additional context

Specific implementations are described
For Packages, only those necessary to explain

dependencies:
  web3modal_flutter: ^3.1.3
  riverpod_annotation: ^2.3.3

dev_dependencies:
  build_runner: ^2.4.7
  riverpod_generator: ^2.3.9
  riverpod_lint: ^2.3.7

import 'package:riverpod_annotation/riverpod_annotation.dart';
import 'package:web3modal_flutter/web3modal_flutter.dart';

part 'wallet_connect.g.dart';

@riverpod
Future<W3MService> walletConnect(WalletConnectRef ref) async {
  const metamask =
      'c57ca95b47569778a828d19178114f4db188b89b763c899ba0be274e97267d96';
  final w3mService = W3MService(
    projectId: ApiConstants.projectId,
    includedWalletIds: {metamask},
    featuredWalletIds: {metamask},
    excludedWalletIds: {metamask},
    metadata: const PairingMetadata(
      name: 'Web3Modal Flutter Example',
      description: 'Web3Modal Flutter Example',
      url: 'https://web3modal.com/',
      icons: ['https://web3modal.com/images/rpc-illustration.png'],
      redirect: Redirect(
        native: 'web3modalflutter://',
        universal: 'https://web3modal.com',
      ),
    ),
  );
  await w3mService.init();
  return w3mService;
}

/// Provider for signature
@riverpod
class Certification extends _$Certification {
  @override
  bool build() {
    return false;
  }

 Future<bool> certificationWithWalletConnect(BuildContext context) async {
    final walletConnect = await ref.read(walletConnectProvider.future);
    ///  The address is ready to be acquired.
    final address = ref.watch(walletProvider);
    /// The nonce is also getting it right.
    final nonce = await getNonce();
    final bytes = utf8.encode('Here is a basic message!$nonce');
    final encoded = hex.encode(bytes);
　///  I want to call in signedMessage, but the signature process doesn't work.
    final signedMessage = await walletConnect.web3App!.request(
      chainId: 'eip155:1',
      topic: walletConnect.session?.topic ?? '',
      request: SessionRequestParams(
        method: 'personal_sign',
        params: ['0x$encoded', address],
      ),
    );

    if (signedMessage == '') {
      return false;
    }
    return true;
  }

Referenced implementations

https://docs.walletconnect.com/web3modal/flutter/actions#send-an-rpc-request

Status quo

Attempt login with walletConnect.openModal(context); to open meta-mask → login succeeded, address retrieval complete
Return to the application and go to the authentication screen
Press the signature button, but the metamask does not transition and not even a signature appears.

Hello, @iseruuuuu
Did you call _w3mService.launchConnectedWallet(); right before your walletConnect.web3App!.request() call? Did you try some other Wallet?
On a side note, this 👇 is wrong:
includedWalletIds: {metamask},
featuredWalletIds: {metamask},
excludedWalletIds: {metamask},

What's your goal here? If you want to show only Metamask (which I don't recommend) you would just use includedWalletIds: {metamask}, that's enough.

@quetool
Thanks for replay🙇

On a side note, this 👇 is wrong:
includedWalletIds: {metamask},
featuredWalletIds: {metamask},
excludedWalletIds: {metamask},
What's your goal here? If you want to show only Metamask (which I don't recommend) you would just use includedWalletIds: {metamask}, that's enough.

I try to fix it.

Did you try some other Wallet?

For other wallets, we are assuming only Metamask signatures, so we do not plan to try others

Did you call _w3mService.launchConnectedWallet(); right before your walletConnect.web3App!.request() call?

Is the following assumption correct for implementation? I was able to open the meta mask, but no signature appeared.

await walletConnect.launchConnectedWallet();
final signedMessage = await walletConnect.web3App!.request(
    chainId: 'eip155:1',
    topic: walletConnect.session?.topic ?? '',
    request: SessionRequestParams(
    method: 'personal_sign',
    params: ['0x$encoded', address],
   ),
 );

Is the following assumption correct for implementation?

Nope, it's totally fair if you want to use only Metamask, for that it's enough to just use includedWalletIds: {metamask},
I asked to try some other wallets just to check if could be an issue with Metamask alone or a broader issue.

@quetool
Thank you.
As an additional matter to share, I did the above implementation on iOS and was able to confirm that the transition to the meta mask was correct and the signature process was issued. Therefore, I felt that there might be a problem with Android.
Also, I have tried to describe the AndroidManifest and other descriptions with reference to the SAMPLES, but it does not work.
As for the specific Android status,

Metamask is opened.
The application crashes without processing the signature.

 I'd like to see at the crash.

Might have ran into the same problem.
I was following the video in the official tutorial https://docs.walletconnect.com/web3modal/flutter/installation#tutorial
Remark: In the video at https://youtu.be/v_M2buHCpc4?t=1149, also in the gist the signMessage method is:
void signMessage() async {
    _w3mService.launchConnectedWallet();
    await _w3mService.request(
      topic: _w3mService.session?.topic ?? '',
      chainId: 'eip155:$chainId', // Connected chain id
      request: SessionRequestParams(
        method: 'personal_sign',
        params: ['Sign this', _w3mService.address],
      ),
    );
  }

However the params list entry _w3mService of type W3MService does not have a property address, see here: https://pub.dev/documentation/web3modal_flutter/latest/services_w3m_service_w3m_service/W3MService-class.html. It seems the property has been removed. Because I did not find any information on this, I guessed _w3mService.session!.address instead. _w3mService.session!.address does indeed return a String with the account address of the connected (Metamask) wallet.
I previously had connected the app to the wallet with the W3MConnectWalletButton and the button still showed 'connected'. When calling the signMessage method, the wallet popped up and returned to the app which crashed (w3m_service.dart, line 959) with

I tried disconnecting and reconnecting the wallet and now it works. So the cause was possibly an expired or disconnected session while the W3MConnectWalletButton still displayed connected while the error message and the crash site were not helpful.
Hope that information helps others who run into the problem. It would be cool to have a code snippet showing how to reset the W3MConnectWalletButton when a disconnect / expiry event happens.

Hello @crcdng !
Indeed the proper address is in the session as you mention _w3mService.session!.address!. I will go over Boidu's video and check for inconsistencies and fix them, thanks for pointing it out.
Regarding the W3MConnectWalletButton state I'll check what could be happening, however I have never faced such scenario if I use onModalConnect and onModalDisconnect events to setState() accordingly.
It is true however that the button should have n internal state mechanism working. I'll check and get back to you. Thanks!

I am sorry to reply.
I checked AndroidManifest and try change　scheme, host path and success to sign with metamask🙌

Wonderful @iseruuuuu! By the way, just a note, you shouldn't await launchConnectedWallet();. I believe since latest version that is not an async method anymore but in any case that could be an issue as well, so please remove the await from await walletConnect.launchConnectedWallet();


Update windows-10-enterprise-e3-overview.md

Edited line 18: added "and activated" to enhance clarity and removed "also known as" to keep sentence concise. (Also removed /en-us/ locale code from links on  lines 252 and 253)  Resolves https://github.com/MicrosoftDocs/windows-itpro-docs/issues/2723

Thank you. I was contemplating opening this PR myself, but I see you have already done so and also improved more of the text than I was aware of. Good job. 👍

@illfated   Thanks for the tip (the process of closing issues is a bit more complicated for our team:smiley:)  but if that is the GitHub convention I will try it

Very good. BTW, just an hour ago I found another keyword which is used by Github to close issues: Resolves #<issue_number> - same way as Closes #<issue_number>.

Please note: When I said "I usually add Closes #<issue number> at the end of my commit text", I meant that it is part of the text written in git (or Git Extensions) when finalizing the commit before pushing. This is the same place as you put your commit text line As per #2723 -- just to indicate where it is at.

@illfated Thanks.  I read more about  closing issues with keywords  - although it wont have any effect I will not experiment further, "As per" is just how I reference issues.  What convention would you suggest?

The most common one is to add Closes #1234 as the ending line (or one of the ending lines) in the first commit text added to the commit before pushing the commit to the origin repository and creating the PR. Subsequent commits to the same PR do not need to have any more text than what is needed to explain changes in the commit (see my PR #2817 as an example with extra commit added to the same PR).
When I put the same text in the Github page comment as in the PR, it was mostly because I did not see any need to expand on the existing text to explain the issue, due to my preceding dialog with Justinha. So the occurrence of Closes ... in that page is mostly only useful to link the PR page back to the originating issue (it does not close the issue ticket by itself, that is what (Closes #2813) the first commit text does. (And the commit text is where the keyword "Resolves #..." is an option.)

@illfated I read more about closing issues with keywords  it probably wont have any effect but I now see how it works. Thank you.


Add MapOf

Equivalent of react objectOf but for Immutable types
Usage:
IPropTypes.MapOf(IPropTypes.List) // map where values are lists

have you seen this: https://github.com/HurricaneJames/react-immutable-proptypes it does a similar thing and has that functionality. Might be good for inspiration.


Clean up ui/learning docs

Replace sample code with UI 2.0 implementations
Remove obsolete language (e.g., references to UI for extensions, settings storage)
Remove docs for Zone/9Zone implementations

@Mergifyio update


Releases page is 404 after migrating to 1.11.3 from 1.2.3

Gitea version (or commit ref): 1.11.3
Git version: 2.22
Operating system: CentOS 6
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Hi, I would like to raise an issue regarding the "Releases" page being 404 after upgrading it to 1.11.3 from 1.2.3. For the upgrading process, I tried to upgrade to each version (1.2 to 1.3 then 1.3 to 1.4, etc.). Even though there are some issues encountered along the way, I managed to upgrade its version to the latest but I overlooked this one.
I initially thought this was caused by the Git version as stated on https://github.com/go-gitea/gitea/issues/1133 so I updated the Git to its latest version but the issue still persists. When I go to the FAQ page, I executed the commands found in the Missing releases after migrating repository with tags but with no progress. I guess this might be a UI issue so I tried to access it directly through a URL however it shows 404.
I can confirm also that the Releases page will only show on created repositories after the said upgrade. I created a new repository and pushed a single file then the Releases page shows up after. This is not the case on existing repositories though.

It may because you lost some data on repo_unit. I remember somebody has workround about that you can search on issues.

Hi, @lunny thanks for the response. Fortunately, I was able to fix this issue on my own. In the settings of the specified repository, I just press the Update Settings button in the Advanced Settings and both Releases and Activity tabs were now visible on the page. With this, I will now close this issue.


Fixed #11379, validate fixed header bits.

Motivation:
The MQTT spec states that the bits in the fixed header must be set to specific values depending on message type. If a client sends a message with the wrong bits, the server must treat the message as malformed. Netty did not check the value of the reserved bits in the fixed header.
See:
MQTT3.1.1: http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/errata01/os/mqtt-v3.1.1-errata01-os-complete.html#_Toc442180835
MQTT 5.0: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901023
Modification:
Add validation checks to MqttDecoder.java
Add unit tests to MqttCodecTest.java
Fixed two instances where messages were generated for other unit tests with an incorrect fixed header.
Result:
Fixes #11379.

@hylkevds did you sign our ICLA ?
https://netty.io/s/icla

Please fix:
Error:  codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java:[160,9] (extension) NoHttp: http:// URLs are not allowed but got 'http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/errata01/os/mqtt-v3.1.1-errata01-os-complete.html'. Use https:// instead.

I just signed the ICLA.

@hylkevds thanks a lot!


Allow TISR kwargs to pass data_utils -> solar_radiation

If we are using graphcast's built in module to compute incoming solar radiation, then we may want to control things like the integration period. For instance, the default is to show TISR accumulated over the past hour, whereas we may want to show this value accumulated over the past delta_t, where delta_t is the time period of our model.
This adds the capability to control those settings by passing keyword arguments to the solar_radiation module from the extract_inputs_targets_forcings function.

Thanks, Tim. Much better to have this capability instead of the default one hour accumulation. I have left a comment in the other related PR. We can merge this after that.

Thanks @nniraj123!
I'll go ahead and merge this one, then update the branch in our submodule in the other repo, then merge that other PR.


fn state_pruning does not return PruningMode::Default

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug
CliConfiguration trait does not return PruningMode::default() for fn state_pruning as stated in docs:
	/// Get the state pruning mode.
	///
	/// By default this is retrieved from `PruningMode` if it is available. Otherwise its
	/// `PruningMode::default()`.
	fn state_pruning(&self) -> Result<Option<PruningMode>> {
		self.pruning_params()
			.map(|x| x.state_pruning())
			.unwrap_or_else(|| Ok(Default::default()))
	}

It returns Ok(Default::default()), which is Ok(Option::default()), so in the end it is Ok(None).
Default 256 value for state pruning is from using .unwrap_or_default() in StateDb::open(...): https://github.com/paritytech/substrate/blob/a9c4334d96cbb63aff8e3141a5b3dcad8c636bb7/client/state-db/src/lib.rs#L538
So state_pruning function should instead look like:
	fn state_pruning(&self) -> Result<Option<PruningMode>> {
		self.pruning_params()
			.map(|x| x.state_pruning())
			.unwrap_or_else(|| Ok(Some(Default::default())))
	}

Steps to reproduce
In bin/node-template/node/src/command.rs (here), right after
let runner = cli.create_runner(&cli.run)?;

add
println!("{:?}", cli.run.state_pruning());

and run node without providing pruning parameter.

Yeah, we should update the docs, but otherwise the implementation is currently correct. We need to return None when you don't specify any pruning mode to fetch the pruning mode from the database.


[WIP] Add local task server

This is a work-in-progress branch for adding a local task server. Requires further work before release, and is entirely missing the actual React front-end implementation. However, introduces some concepts and skeleton for building the project. Here's a rundown of things:
Tasks library

Parse input and output schema for tasks from function signature
Expose schema in list command
Allow passing task arguments after -- with run command, e.g. python -m robocorp.tasks run tasks.py -- --arg "value"

Server library

Introduce new Python package: robocorp-task-server
Allows starting local HTTP server as a barebones Control Room, e.g. Control Coffin
Runs inside same environment as project, uses robocorp-tasks for collecting tasks and running them
Bundles the front-end as a static file inside the package and serves it
Stores project-locally a history of tasks and runs (in sqlite3)
Offers an API for inspecting and running tasks (http://localhost:8080/docs)
Can watch project for changes and re-collect tasks
Allows starting tasks with arguments, validates payload based on schema given by tasks library
Serves local artifacts statically, available at http://<addr>:<port>/artifacts/<run-id>/<artifact-name>

CLI

Add serve command for starting local task server
Probe capability of environment (tasks, local server) before running commands, add result to environment cache
Change configuration file from pyproject.toml to new tasks.toml. The actual format is not final, and not all fields are used yet, but this is the first proposal.
Add configuration for "tasks file", e.g. tasks.py
Add base for new template that uses server library

Next steps

Go through all TODO comments
Nail down new tasks.toml spec
Figure out if running tasks in subprocess is the only way to go, or if calling directly via Python API is feasible
Figure out how to pass task output values to server (related to above)
Figure out how task arguments / returns map to work items concept, can these be integrated so that a work item maps into the arguments automatically?
Add log output streaming, can use same approach as VSCode if a websocket endpoint is added that is injected to runs
Add robo CLI support for run arguments passing
Generate client bindings for backend with OpenAPI generator. Schema available with python -m robocorp.task_server --schema openapi.json
Implement entire front-end 😅

Hey @fabioz, what do you think it will work best for getting a quick UI that can use the API? (React (and use our DS), Bootstrap, <something else>)

I'll go with react / DS (since we use it in multiple places already).

As a note, I'm closing this PR. The idea will be first brewing the task server in a different repo (and moving to the mainline when we agree it's what we want).
I'll extract the change to add arguments to tasks into a separate PR (and we can still reference what we need from the closed PR).


Zombies as not a real entitys and No Death in Stats

Hi there, i have 2 problem with this fabulous script !
the zombies or the player are not detected as real entities by the game/script and therefore some resources like nbk_damagemessage do not work... I search and try to modify bits of code but I can't find it. Nothing...
Second point, the death of the players is not counted in the Statistics, I think that the concern comes from "Disc-death"?! :
AddEventHandler('disc-death:onPlayerRevive', function(data)
     isDead = false
end)

I don't know much about Lua, even if it looks like php... if someone could help me, thanks!
(Sorry for my bad English, I use Google translate)

I answer myself for the recording of the number of deaths in the statistics, it is not mentioned anywhere but I found the information on the Forum of cfx.re :
Supporting QBCore qb-ambulancejob script for death counting but on ESX you must manually call
TriggerServerEvent("tp-advancedzombies:updatePlayerStatistics", "deaths", 1)
in your ambulance script where function RemoveItemsAfterRPDeath() is called.


'ADSyncExportDeletionThreshold' doesn't require GA

A change has been made to the "ADSync" module, over a year ago to make the 'Get / Disable / Enable -ADSyncExportDeletionThreshold' cmdlets consistent with the other cmdlets in the module, removing the prompt for GA credentials.
This document needs to be updated as the user is no longer prompted to enter GA creds.

@riantu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Refactor the code, add count for min and max group, prepare for Rank …

…and Search impl.

Now Search and Rank is supported by GroupCount


Upgrade cobra to make kool run autocomplete

kool run scripts autocomplete for zsh is possible today only loading the entire list of scripts before. Lazy autocomplete is possible only version 1.1.0 or greater of cobra, and we use 1.0.0 today.
https://github.com/spf13/cobra/pull/1070
This is the PR that enables zsh lazy completions, available only on 1.1.0

Good catch 👍🏻  I say this is a nice UX feat!


BRF+ serialization

might be relevant, https://archive.sap.com/documents/docs/DOC-4562

There are three storage types of BRF+ application.

System - entry exists in TADIR with OBJECT = FDT0.
Customizing - entry DOESN'T exist in TADIR.
Application name and ID are stored in table FDT_ADMN_0000.
Package is stored by Application ID in table FDT_APPL_0000.
Mater Data - always in local package, no need to support.

Any suggestion on how to support Customizing storage type?

one solution is to manually add it to a business configuration set, https://github.com/larshp/abapGit/issues/1004
but I'd probably recommend changing the storage type of the BRF+ object to system, this would also reflect which package the object belongs to

SYSTEM type cannot be added to a business configuration set.
Changing storage type is not an option. SYSTEM and CUSTOMIZING are two different things.
CUSTOMIZING type does have package information in table FDT_APPL_0000.

Is it a good idea to add support for SYSTEM type only? It may cause confusion since there are two different ways to handle BRF+ objects based on their storage types.


Simplify clipping of lower resolution regions

This fixes the remaining issue with lines at tile borders described in #4934. In addition, it fixes another issue that can be seen in http://jsfiddle.net/norric/mopu8d7x/ when zooming in and out fast and for a long time: the clip geometry was created in a way that inner rings could have overlaps, which resulted in no clipping.
In addition to fixing several issues, this pull request simplifies the code and should make higher resolution tile clipping easier to read and understand.

https://github.com/openlayers/ol3/issues/4934#issuecomment-191669241 confirms that the regression is finally fixed with this change.
Thanks for any review.

LGTM