Fix incorrect action duration time when rerun the job before executed once

Fix #28323
Reason was mentioned here: https://github.com/go-gitea/gitea/issues/28323#issuecomment-1841867298

Thanks for figuring out the bug, but it may not be a good idea to always reset the Started and Stopped time of a run.
Users may rerun a specific job, not all jobs of a run.

What about
diff --git a/models/actions/run_job.go b/models/actions/run_job.go
index 4b8664077d..a96ab6a7c1 100644
--- a/models/actions/run_job.go
+++ b/models/actions/run_job.go
@@ -138,11 +138,20 @@ func UpdateRunJob(ctx context.Context, job *ActionRunJob, cond builder.Cond, col
                        return 0, err
                }
                run.Status = aggregateJobStatus(jobs)
-               if run.Started.IsZero() && run.Status.IsRunning() {
-                       run.Started = timeutil.TimeStampNow()
+               var started, stopped timeutil.TimeStamp
+               for _, job := range jobs {
+                       if !job.Started.IsZero() && (started.IsZero() || started > job.Started) {
+                               started = job.Started
+                       }
+                       if !job.Stopped.IsZero() && (stopped.IsZero() || stopped < job.Stopped) {
+                               stopped = job.Stopped
+                       }
                }
-               if run.Stopped.IsZero() && run.Status.IsDone() {
-                       run.Stopped = timeutil.TimeStampNow()
+               run.Started = started
+               if run.Status.IsDone() {
+                       run.Stopped = stopped
+               } else {
+                       run.Stopped = 0 // reset the stopped time, it could have been stopped before but is being rerun again.
                }
                if err := UpdateRun(ctx, run, "status", "started", "stopped"); err != nil {
                        return 0, fmt.Errorf("update run %d: %w", run.ID, err)

It should work but I haven't tested it.

You are right. But it seems that the suggestion doesn't right.
The duration time will become bigger and bigger.

Convert Stopped into Duration for not only ActionRun but also ActionRunJob
ActionRunJob.Duration can be calculated by SUM(ActionTaskStep.Stopped - ActionTaskStep.Started)
ActionRun.Duration can be calculated by SUM(ActionRunJob.Duration)
This can avoid similar issue (maybe occurred?) for action run job too.

The duration time will become bigger and bigger, as the start time may not be changed, but the stop time will be updated every time.

It could happen, such as the run contains two jobs, the first one started and stopped yesterday and you rerun another job today. Then the duration of the run will be very long.

Maybe the correct way is calculating the total duration of all jobs, but not simply calculate stop - start

I'm not sure. The point is, how do you define the duration of a run? Jobs in a run could execute concurrently. Think about this: the run contains 100 jobs, all of them started at 9:00 and stopped at 9:01. So, would you say the run lasted for 1 minute or 100 minutes?
I prefer 1 minute because I just want to know how much time I need to wait, instead of how much work time the runner takes. Let's say it's pretty clear but "rerun some or all jobs of a run" makes it complex. So I know that my patch is not perfect, but it's good enough for me.

ActionRunJob.Duration can be calculated by SUM(ActionTaskStep.Stopped - ActionTaskStep.Started)

It couldn't be right. While Gitea now treats some works before any step as Set up job, it's actually not a step, and so is Complete job.

This can avoid similar issue (maybe occurred?) in action run job too.

I don't think the issue exists. Steps execute sequentially, and the job will be completely reset when you rerun it.

how do you define the duration of a run?

I prefer the time cost in running instead of stopped time - started time here.
For example, the run contains 100 jobs, all of them started at 9:00 and stopped at 9:01 today. And I rerun one of them at 9:00 today, and it stopped at 9:01.
I prefer displaying 1minite (yesterday) + 1minite (today), but not 24h1m.
In another way, as a quick fix, maybe your solution is good enough.
But for the feature, we need to redesign the action, and rerun job should create new jobs but not overwrite it in frontend,
as user can not check the execution result before the rerun.

@wolfogre Cc @lunny
I have changed the solution and updated the description of this PR.
If this solution looks good to you, I will add a migration later,
as the migration for this PR is simple, so we can quickly add it, but maintaining it is terrible.

Sorry, I don't think it's a good idea to maintain TotalDuration and reset Started, and your patch doesn't work well in some cases.

Then we only reset start time when it is done?

This sounds better. Let's do it. 😄

Old data can keep zero PreviousDuration, you don't need to migrate it.

I agree. My previous plan is only creating the new column in the migration.

Migration seems strange.
where v284.go is not used but id is correct.

Migration seems strange. v284.go is not used.

https://github.com/go-gitea/gitea/pull/28827

I was unable to create a backport for 1.21. @yp05327, please send one manually. :tea:
go run ./contrib/backport 28364
...  // fix git conflicts if any
go run ./contrib/backport --continue


Flag on market cards

Market list page

Flag on the market card, on hover shows a tooltip with messaging and link to post
https://www.figma.com/file/csVtbWhGCAYe3nVe2LI1UEPM/v1---updates-to-the-UI?node-id=321%3A849
(scroll right to see more)
Only show on markets that expire after the cut off
Show on the reporting and disputing pages still but hide on the disputing and reporting forms

PR opened https://github.com/AugurProject/augur-ui/pull/3038

need to update date to correct cutoff date in tooltip text and constant when available
update read more link to correct link when available

Looks good. Do we want to keep this open until we have date/link added? @phoebemirman

lets close it


Config.unobserve is deprecated.

Config::unobserve no longer does anything. Call .dispose() on the object returned by Config::observe instead.
Config.unobserve (/usr/share/atom/resources/app.asar/src/config.js:1060:19)
LinterPep8.destroy (/home/wes/.atom/packages/linter-pep8/lib/linter-pep8.coffee:29:16)
LinterView.remove (/home/wes/.atom/packages/linter/lib/linter-view.coffee:252:6)
<unknown> (/home/wes/.atom/packages/linter/lib/linter-view.coffee:124:7)
Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
TextEditor.destroyed (/usr/share/atom/resources/app.asar/src/text-editor.js:265:27)

Fixed by https://github.com/AtomLinter/linter-pep8/pull/14


Merge all parser grammars?

I think that we could merge all of the grammars into one mega-grammar.
We would prefix the input with a special token indicating which parser to use, and the top level parser would match a start token followed by the appropriate production.
I believe this would result in all of the parsers sharing an overwhelming majority of their state tables, which should be a good memory savings for compiler workers.
(Since #5856 makes the IO process only load the expression fragment parser, we might want that one to be able to stay separate, since it'll be lighter weight)

Done in #6175


[Addition]:  SenseCAP fake locations

Hotspot b58 Addresses
112FGaJDPjetb7YaUWAespkYx67PmNQi7VoYcoMMtNFY84fHaU9u
Discord Handle
No response
Reason(s)
Placed at the same time

There does seem to be an anomaly in this area.
Although I believe it's too early to tell. We may need to wait a little while to gather more data.


Add expected installer return codes

Adding expected return codes for installer. Expected return codes are translated to specific HResults when found and show a custom error message.

Updated v1.1 manifest schema with new field for expected return codes. Updated file would look like this:

Installers:
    - InstallerUrl: https://example.com
      InstallerType: exe
      ExpectedReturnCodes:
          PackageInUse: 1
          InstallInProgress: 2

Updated manifest parsing and validation for the new fields.
Refactored common code for checking installer exit code from MSI and ShellExecute installs into a workflow task that now also checks the expected return codes.

Not in this PR: Changes for REST sources
Microsoft Reviewers: Open in CodeFlow

Updated with default values per installer type.
I changed the way this is represented in the manifest because I hadn't considered multiple return codes mapping to the same response. The format is now
      ExpectedReturnCodes:
          - InstallerReturnCode: 1
            ReturnResponse: PackageInUse


Kubeflow StatefulSets and Deployments fail to start

/kind bug
I've been trying to get Kubeflow to work on a local k8s cluster without success. Interestingly, this problem only occurs when I delete and reapply my Kubeflow config. So if I completely remove my cluster and do a fresh install, Kubeflow works just fine. But once I delete Kubeflow and start it again I get the following.
kubectl get all -n kubeflow
NAME                                                   TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)             AGE
service/admission-webhook-service                      ClusterIP   <IP_ADDRESS>   <none>        443/TCP             2m7s
service/application-controller-service                 ClusterIP   <IP_ADDRESS>    <none>        443/TCP             2m8s
service/argo-ui                                        NodePort    <IP_ADDRESS>   <none>        80:31308/TCP        2m8s
service/centraldashboard                               ClusterIP   <IP_ADDRESS>     <none>        80/TCP              2m7s
service/jupyter-web-app-service                        ClusterIP   <IP_ADDRESS>    <none>        80/TCP              2m7s
service/katib-controller                               ClusterIP   <IP_ADDRESS>    <none>        443/TCP             2m4s
service/katib-db                                       ClusterIP   <IP_ADDRESS>     <none>        3306/TCP            2m4s
service/katib-manager                                  ClusterIP   <IP_ADDRESS>     <none>        6789/TCP            2m4s
service/katib-ui                                       ClusterIP   <IP_ADDRESS>   <none>        80/TCP              2m4s
service/kfserving-controller-manager-metrics-service   ClusterIP   <IP_ADDRESS>    <none>        8443/TCP            2m5s
service/kfserving-controller-manager-service           ClusterIP   <IP_ADDRESS>    <none>        443/TCP             2m5s
service/metadata-db                                    ClusterIP   <IP_ADDRESS>    <none>        3306/TCP            2m7s
service/metadata-envoy-service                         ClusterIP   <IP_ADDRESS>    <none>        9090/TCP            2m7s
service/metadata-grpc-service                          ClusterIP   <IP_ADDRESS>    <none>        8080/TCP            2m7s
service/metadata-service                               ClusterIP   <IP_ADDRESS>   <none>        8080/TCP            2m6s
service/metadata-ui                                    ClusterIP   <IP_ADDRESS>   <none>        80/TCP              2m6s
service/minio-service                                  ClusterIP   <IP_ADDRESS>     <none>        9000/TCP            2m3s
service/ml-pipeline                                    ClusterIP   <IP_ADDRESS>    <none>        8888/TCP,8887/TCP   2m4s
service/ml-pipeline-ml-pipeline-visualizationserver    ClusterIP   <IP_ADDRESS>     <none>        8888/TCP            2m2s
service/ml-pipeline-tensorboard-ui                     ClusterIP   <IP_ADDRESS>    <none>        80/TCP              2m3s
service/ml-pipeline-ui                                 ClusterIP   <IP_ADDRESS>   <none>        80/TCP              2m3s
service/mysql                                          ClusterIP   <IP_ADDRESS>   <none>        3306/TCP            2m3s
service/notebook-controller-service                    ClusterIP   <IP_ADDRESS>     <none>        443/TCP             2m6s
service/profiles-kfam                                  ClusterIP   <IP_ADDRESS>    <none>        8081/TCP            2m2s
service/pytorch-operator                               ClusterIP   <IP_ADDRESS>   <none>        8443/TCP            2m6s
service/seldon-operator-controller-manager-service     ClusterIP   <IP_ADDRESS>   <none>        443/TCP             2m1s
service/tensorboard                                    ClusterIP   <IP_ADDRESS>   <none>        9000/TCP            2m5s
service/tf-job-operator                                ClusterIP   <IP_ADDRESS>    <none>        8443/TCP            2m4s
service/webhook-server-service                         ClusterIP   <IP_ADDRESS>    <none>        443/TCP             2m1s

NAME                                                          READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/admission-webhook-deployment                  0/1     0            0           2m7s
deployment.apps/argo-ui                                       0/1     0            0           2m8s
deployment.apps/centraldashboard                              0/1     0            0           2m7s
deployment.apps/jupyter-web-app-deployment                    0/1     0            0           2m7s
deployment.apps/katib-controller                              0/1     0            0           2m4s
deployment.apps/katib-db                                      0/1     0            0           2m4s
deployment.apps/katib-manager                                 0/1     0            0           2m4s
deployment.apps/katib-ui                                      0/1     0            0           2m4s
deployment.apps/metadata-db                                   0/1     0            0           2m6s
deployment.apps/metadata-deployment                           0/1     0            0           2m6s
deployment.apps/metadata-envoy-deployment                     0/1     0            0           2m6s
deployment.apps/metadata-grpc-deployment                      0/1     0            0           2m6s
deployment.apps/metadata-ui                                   0/1     0            0           2m6s
deployment.apps/minio                                         0/1     0            0           2m3s
deployment.apps/ml-pipeline                                   0/1     0            0           2m4s
deployment.apps/ml-pipeline-ml-pipeline-visualizationserver   0/1     0            0           2m2s
deployment.apps/ml-pipeline-persistenceagent                  0/1     0            0           2m3s
deployment.apps/ml-pipeline-scheduledworkflow                 0/1     0            0           2m2s
deployment.apps/ml-pipeline-ui                                0/1     0            0           2m3s
deployment.apps/ml-pipeline-viewer-controller-deployment      0/1     0            0           2m3s
deployment.apps/mysql                                         0/1     0            0           2m3s
deployment.apps/notebook-controller-deployment                0/1     0            0           2m6s
deployment.apps/profiles-deployment                           0/1     0            0           2m2s
deployment.apps/pytorch-operator                              0/1     0            0           2m6s
deployment.apps/spartakus-volunteer                           0/1     0            0           2m5s
deployment.apps/tensorboard                                   0/1     0            0           2m5s
deployment.apps/tf-job-operator                               0/1     0            0           2m4s
deployment.apps/workflow-controller                           0/1     0            0           2m8s

NAME                                                                     DESIRED   CURRENT   READY   AGE
replicaset.apps/admission-webhook-deployment-78d899bf68                  1         0         0       2m7s
replicaset.apps/argo-ui-55b859f7d7                                       1         0         0       2m8s
replicaset.apps/centraldashboard-75474d6f94                              1         0         0       2m7s
replicaset.apps/jupyter-web-app-deployment-6c8f4c8997                    1         0         0       2m7s
replicaset.apps/katib-controller-85995d4f5f                              1         0         0       2m4s
replicaset.apps/katib-db-6558656ffc                                      1         0         0       2m4s
replicaset.apps/katib-manager-79f78fc794                                 1         0         0       2m4s
replicaset.apps/katib-ui-fcdb8f8c5                                       1         0         0       2m4s
replicaset.apps/metadata-db-5dd459cc                                     1         0         0       2m6s
replicaset.apps/metadata-deployment-b745d8bcf                            1         0         0       2m6s
replicaset.apps/metadata-envoy-deployment-7ccf5c4f74                     1         0         0       2m6s
replicaset.apps/metadata-grpc-deployment-6496f66c8c                      1         0         0       2m6s
replicaset.apps/metadata-ui-78f5b59b56                                   1         0         0       2m6s
replicaset.apps/minio-6f48db9cc4                                         1         0         0       2m3s
replicaset.apps/ml-pipeline-844645fd                                     1         0         0       2m4s
replicaset.apps/ml-pipeline-ml-pipeline-visualizationserver-865894f5f7   1         0         0       2m2s
replicaset.apps/ml-pipeline-persistenceagent-66f89b56d9                  1         0         0       2m3s
replicaset.apps/ml-pipeline-scheduledworkflow-57445ddf88                 1         0         0       2m2s
replicaset.apps/ml-pipeline-ui-5c64b6c666                                1         0         0       2m3s
replicaset.apps/ml-pipeline-viewer-controller-deployment-7cc8d77468      1         0         0       2m3s
replicaset.apps/mysql-749f87bff5                                         1         0         0       2m3s
replicaset.apps/notebook-controller-deployment-6c887454f7                1         0         0       2m6s
replicaset.apps/profiles-deployment-bd576fd8f                            1         0         0       2m2s
replicaset.apps/pytorch-operator-84c58df794                              1         0         0       2m6s
replicaset.apps/spartakus-volunteer-9768df654                            1         0         0       2m5s
replicaset.apps/tensorboard-6544748d94                                   1         0         0       2m5s
replicaset.apps/tf-job-operator-db676465c                                1         0         0       2m4s
replicaset.apps/workflow-controller-676484d796                           1         0         0       2m8s

NAME                                                        READY   AGE
statefulset.apps/admission-webhook-bootstrap-stateful-set   0/1     2m7s
statefulset.apps/application-controller-stateful-set        0/1     2m8s
statefulset.apps/kfserving-controller-manager               0/1     2m5s
statefulset.apps/metacontroller                             0/1     2m8s
statefulset.apps/seldon-operator-controller-manager         0/1     2m1s

When I take a look at the events I get:
kubectl get events -n kubeflow
LAST SEEN   TYPE      REASON               OBJECT                                                              MESSAGE
10s         Warning   FailedCreate         statefulset/admission-webhook-bootstrap-stateful-set                create Pod admission-webhook-bootstrap-stateful-set-0 in StatefulSet admission-webhook-bootstrap-stateful-set failed error: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
47s         Warning   FailedCreate         replicaset/admission-webhook-deployment-78d899bf68                  Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m1s        Normal    ScalingReplicaSet    deployment/admission-webhook-deployment                             Scaled up replica set admission-webhook-deployment-78d899bf68 to 1
7s          Warning   FailedCreate         statefulset/application-controller-stateful-set                     create Pod application-controller-stateful-set-0 in StatefulSet application-controller-stateful-set failed error: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
75s         Warning   FailedCreate         replicaset/argo-ui-55b859f7d7                                       Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m2s        Normal    ScalingReplicaSet    deployment/argo-ui                                                  Scaled up replica set argo-ui-55b859f7d7 to 1
69s         Warning   FailedCreate         replicaset/centraldashboard-75474d6f94                              Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m1s        Normal    ScalingReplicaSet    deployment/centraldashboard                                         Scaled up replica set centraldashboard-75474d6f94 to 1
47s         Warning   FailedCreate         replicaset/jupyter-web-app-deployment-6c8f4c8997                    Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m1s        Normal    ScalingReplicaSet    deployment/jupyter-web-app-deployment                               Scaled up replica set jupyter-web-app-deployment-6c8f4c8997 to 1
42s         Warning   FailedCreate         replicaset/katib-controller-85995d4f5f                              Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m58s       Normal    ScalingReplicaSet    deployment/katib-controller                                         Scaled up replica set katib-controller-85995d4f5f to 1
42s         Warning   FailedCreate         replicaset/katib-db-6558656ffc                                      Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m58s       Normal    ScalingReplicaSet    deployment/katib-db                                                 Scaled up replica set katib-db-6558656ffc to 1
42s         Warning   FailedCreate         replicaset/katib-manager-79f78fc794                                 Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m58s       Normal    ScalingReplicaSet    deployment/katib-manager                                            Scaled up replica set katib-manager-79f78fc794 to 1
37s         Warning   ProvisioningFailed   persistentvolumeclaim/katib-mysql                                   no volume plugin matched
41s         Warning   FailedCreate         replicaset/katib-ui-fcdb8f8c5                                       Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m58s       Normal    ScalingReplicaSet    deployment/katib-ui                                                 Scaled up replica set katib-ui-fcdb8f8c5 to 1
9s          Warning   FailedCreate         statefulset/kfserving-controller-manager                            create Pod kfserving-controller-manager-0 in StatefulSet kfserving-controller-manager failed error: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
6s          Warning   FailedCreate         statefulset/metacontroller                                          create Pod metacontroller-0 in StatefulSet metacontroller failed error: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
46s         Warning   FailedCreate         replicaset/metadata-db-5dd459cc                                     Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/metadata-db                                              Scaled up replica set metadata-db-5dd459cc to 1
46s         Warning   FailedCreate         replicaset/metadata-deployment-b745d8bcf                            Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/metadata-deployment                                      Scaled up replica set metadata-deployment-b745d8bcf to 1
45s         Warning   FailedCreate         replicaset/metadata-envoy-deployment-7ccf5c4f74                     Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/metadata-envoy-deployment                                Scaled up replica set metadata-envoy-deployment-7ccf5c4f74 to 1
45s         Warning   FailedCreate         replicaset/metadata-grpc-deployment-6496f66c8c                      Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/metadata-grpc-deployment                                 Scaled up replica set metadata-grpc-deployment-6496f66c8c to 1
37s         Warning   ProvisioningFailed   persistentvolumeclaim/metadata-mysql                                no volume plugin matched
44s         Warning   FailedCreate         replicaset/metadata-ui-78f5b59b56                                   Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/metadata-ui                                              Scaled up replica set metadata-ui-78f5b59b56 to 1
41s         Warning   FailedCreate         replicaset/minio-6f48db9cc4                                         Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
37s         Warning   ProvisioningFailed   persistentvolumeclaim/minio-pv-claim                                no volume plugin matched
2m57s       Normal    ScalingReplicaSet    deployment/minio                                                    Scaled up replica set minio-6f48db9cc4 to 1
41s         Warning   FailedCreate         replicaset/ml-pipeline-844645fd                                     Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
39s         Warning   FailedCreate         replicaset/ml-pipeline-ml-pipeline-visualizationserver-865894f5f7   Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m56s       Normal    ScalingReplicaSet    deployment/ml-pipeline-ml-pipeline-visualizationserver              Scaled up replica set ml-pipeline-ml-pipeline-visualizationserver-865894f5f7 to 1
40s         Warning   FailedCreate         replicaset/ml-pipeline-persistenceagent-66f89b56d9                  Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m57s       Normal    ScalingReplicaSet    deployment/ml-pipeline-persistenceagent                             Scaled up replica set ml-pipeline-persistenceagent-66f89b56d9 to 1
39s         Warning   FailedCreate         replicaset/ml-pipeline-scheduledworkflow-57445ddf88                 Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m56s       Normal    ScalingReplicaSet    deployment/ml-pipeline-scheduledworkflow                            Scaled up replica set ml-pipeline-scheduledworkflow-57445ddf88 to 1
39s         Warning   FailedCreate         replicaset/ml-pipeline-ui-5c64b6c666                                Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m57s       Normal    ScalingReplicaSet    deployment/ml-pipeline-ui                                           Scaled up replica set ml-pipeline-ui-5c64b6c666 to 1
39s         Warning   FailedCreate         replicaset/ml-pipeline-viewer-controller-deployment-7cc8d77468      Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m57s       Normal    ScalingReplicaSet    deployment/ml-pipeline-viewer-controller-deployment                 Scaled up replica set ml-pipeline-viewer-controller-deployment-7cc8d77468 to 1
2m58s       Normal    ScalingReplicaSet    deployment/ml-pipeline                                              Scaled up replica set ml-pipeline-844645fd to 1
40s         Warning   FailedCreate         replicaset/mysql-749f87bff5                                         Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
37s         Warning   ProvisioningFailed   persistentvolumeclaim/mysql-pv-claim                                no volume plugin matched
2m57s       Normal    ScalingReplicaSet    deployment/mysql                                                    Scaled up replica set mysql-749f87bff5 to 1
44s         Warning   FailedCreate         replicaset/notebook-controller-deployment-6c887454f7                Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/notebook-controller-deployment                           Scaled up replica set notebook-controller-deployment-6c887454f7 to 1
38s         Warning   FailedCreate         replicaset/profiles-deployment-bd576fd8f                            Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m56s       Normal    ScalingReplicaSet    deployment/profiles-deployment                                      Scaled up replica set profiles-deployment-bd576fd8f to 1
43s         Warning   FailedCreate         replicaset/pytorch-operator-84c58df794                              Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m          Normal    ScalingReplicaSet    deployment/pytorch-operator                                         Scaled up replica set pytorch-operator-84c58df794 to 1
8s          Warning   FailedCreate         statefulset/seldon-operator-controller-manager                      create Pod seldon-operator-controller-manager-0 in StatefulSet seldon-operator-controller-manager failed error: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
43s         Warning   FailedCreate         replicaset/spartakus-volunteer-9768df654                            Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m59s       Normal    ScalingReplicaSet    deployment/spartakus-volunteer                                      Scaled up replica set spartakus-volunteer-9768df654 to 1
42s         Warning   FailedCreate         replicaset/tensorboard-6544748d94                                   Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m59s       Normal    ScalingReplicaSet    deployment/tensorboard                                              Scaled up replica set tensorboard-6544748d94 to 1
42s         Warning   FailedCreate         replicaset/tf-job-operator-db676465c                                Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
2m58s       Normal    ScalingReplicaSet    deployment/tf-job-operator                                          Scaled up replica set tf-job-operator-db676465c to 1
72s         Warning   FailedCreate         replicaset/workflow-controller-676484d796                           Error creating: Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.pod-mutator": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-pods?timeout=30s: service "kfserving-webhook-server-service" not found
3m2s        Normal    ScalingReplicaSet    deployment/workflow-controller                                      Scaled up replica set workflow-controller-676484d796 to 1

I did a little digging and found similar issues #235 and #568. I believe these two caused this pull request (#571) to be merged today. But I honestly don't see how any of these can help me with my issue. I'm not even sure if my issue stems from the same root causes.
Any guidance on this would be very appreciated.
Environment:
Not sure how to obtain most of these versions, but if they're important please let me know and I'll do some digging.

Istio Version:
Knative Version:
KFServing Version:
Kubeflow version: v0.7.0
Minikube version:
Kubernetes version: (use kubectl version): Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:11:03Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.9", GitCommit:"500f5aba80d71253cc01ac6a8622b8377f4a7ef9", GitTreeState:"clean", BuildDate:"2019-11-13T11:13:04Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
OS (e.g. from /etc/os-release): 18.04.3 LTS (Bionic Beaver)

There's a problem w/ the kubeflow install and a admission webhook deadlock. Short term fix is:
kubectl delete mutatingwebhookconfigurations.admissionregistration.k8s.io
kubectl delete validatingwebhookconfigurations.admissionregistration.k8s.io

This has been resolved in 0.2.2
/close


Docs: query ordering

Signed-off-by: Mikhail Boldyrev<EMAIL_ADDRESS>

Description of the Change
documentation for #338

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@MBoldyrev I tried something here. What do you think of the idea? I still think there should be a little more info on where to add the pagination stuff but what it looks like n general?

@LiraLemur thank you, the PR seems ready

@mboldyrev You think so? I am not sure it's easy to understand  how to add pagination to the queries though. Maybe let's ask someone like a QA person to take a quick look? I mean I'm not very techy and so maybe it is something obvious. But what if it's not?
God, I miss 2 review rule :D

summon @stepanlavrentev


hvloader: add patch for CVE-2023-0464

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
hvloader: add patch for CVE-2023-0464
Change Log

hvloader: add patch for CVE-2023-0464

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-0464

Test Methodology

Pipeline build id: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=589441&view=results
Successful Image build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=602492&view=results

Conformance tests: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=602546&view=results

Conformance tests: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=602546&view=results

Re-run for ConfPods: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=602764&view=results


Ferox Enclave breaks Menu Entry Swapper on the Jewelery Box

Description:
Menu Entry Swapper allows you to left click the jewelry box to go to last location. However if your last location is Ferox Enclave, it doesn't work.
Steps to reproduce the behavior:

Enable Menu Entry Swapper
Under Object Swaps, check the box for the jewelry box.
Use jewelry box to go to ferox enclave.
Return to POH and notice you can't left click to go to ferox enclave.

Desired Outcome:
Left click to use the Jewelry box should still work if ferox enclave was your last destination.

RuneLite version: 1.6.24

This is fixed in master in commit 6998931f84964cf2071df23faaa495329e96e520


Error: Comparison of: String < Integer, is not possible

We are getting ready to upgrade from puppet 3.8 to 4.2 so we have set stringify_facts = false. Once we did that an error popped up from this module. The full error:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Comparison of: String < Integer, is not possible. Caused by 'A String is not comparable to a non String'. at /modules/nginx/manifests/resource/location.pp:238:17
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run
and the section in question:
  $priority             = 500
...
  validate_array($rewrite_rules)
  if ($priority < 401) or ($priority > 899) {
    fail('$priority must be in the range 401-899.')
  }

To force puppet to see the $priority as an integer by adding zero to it:
(https://docs.puppetlabs.com/puppet/latest/reference/lang_data_number.html#converting-strings-to-numbers)
  validate_array($rewrite_rules)
  if (($priority + 0) < 401) or (($priority + 0) > 899) {
    fail('$priority must be in the range 401-899.')
  }

Created PR: https://github.com/jfryman/puppet-nginx/pull/687

Updated PR to use str2num

Created PR https://github.com/jfryman/puppet-nginx/pull/689


@KafkaListener groupId property is not working

@KafkaListener(id="consumer1" ,idIsGroup = false, groupId="myGroup",
topicPartitions ={@TopicPartition(topic="myTopic", partitions={"0"})})
@KafkaListener(id="consumer2", idIsGroup = false, groupId="myGroup" ,
topicPartitions ={@TopicPartition(topic="myTopic", partitions={"0"})})

I configured 2 consumers in one group,  i found consumer1 and consumer2 both reading the message. please tell me how could i get the message consumed just once in the group.
i found the  2 consumers have the same offset value in my console log, that confused me.
whether  using spring-boot 2.1.5.RELEASE or spring-boot 1.5.3.RELEASE & spring-kafka 1.3.10.RELEASE has the same problem.

GitHub issues are not for asking questions about why something is not working the way you expect; they are for reporting bugs and asking for new features.
When you manually assign topics and partitions with @TopicPartition, you are NOT using group management, you are explicitly  saying you want to receive all records in that partition.
use topics = "myTopic" instead and Kafka will allocate partitions to the instances.

I'm sorry. i will use issues funciton  in right way. thank you very much

This is just an Apache Kafka feature: when you assign partitions manually to your consumers, they are not involved in group management: https://kafka.apache.org/documentation/#intro_consumers
So, what you have with your configuration is expected behavior.
Therefore closing as Works as Designed.


Description view doesn't update if already opened

Repro:

Open a PR description
Merge the PR (might not matter)
Focus another tab, keep the PR description open though
Open a different PR description

The tab title will update but the contents will not.

Closing as I'm not able to reproduce with the latest version of the extension


chore: support GNOME 47

Changes

update shell-version to include 47 in metadata.json
bump version to 15 in metadata.json

Motivation
https://release.gnome.org/47 was released a while ago and this extension stopped working after I upgraded to Ubuntu 24.10 today.
I tried to run this extension locally with the contributing steps but failed to have it show up in extension manager to be able to test it properly. Therefore, please double check that this extension is indeed compatible with GNOME 47 out of the box without any further code changes.

Thanks @mcmxcdev for the contribution. I’m not able to verify the extension at the moment since I haven’t upgraded to 47 yet myself.

I was able now to verify that GNOME 47 works with the minimal changes in this PR.
The npm run linkdist command copies the content in a way that is not discoverable by "Extensions" applications, I will take a look if I can fix it in a separate PR.


prepare for release 0.9.0

This 0.9.X releases will be last compatible releases for netbox 3.0 and 3.1

Our version check strategy is not working anymore.
>>> # {% if settings.VERSION < '3.1.2' %}
>>> "3.1.10" < "3.1.2"
True

I will try to find another solution.

From the top of my head:
from packaging import version

version.parse("3.1.10") < version.parse("3.1.2")
False

The downside is that packaging is an extra dependency. The upside is that packaging.version handles all types of version comparisons nicely.

pkg_resources package may solves our issue and it is part of standard library (I tested on docker python alpine images; 3.8 3.9 3.10).
>>> import pkg_resources
>>> pkg_resources.parse_version("3.1.10") < pkg_resources.parse_version("3.1.2")
False
>>> "3.1.10" < "3.1.2"
True

Maybe we can add some template tag or function. An extra step is required.

Link: https://stackoverflow.com/a/57634066
Link: https://peps.python.org/pep-0365/

OK. For now this trick looks work.
# view_helpers.py

@register.filter()
def check_version(version):
    # from pkg_resources import parse_version
    # from django.conf import settings
    return parse_version(settings.VERSION) < parse_version(version)

And ..
{# in templates #}
{% if '3.1.2'|check_version %}

Edit: I am not sure this is the best option. I'm open to new suggestions.

Works for me, and the whole issue should become obsolete once NetBox' interface to plugins is stable, i.e. after the final release of 3.2. So I wouldn't put too much effort into it.


⚠ Samsung has degraded performance

In 68d379d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3056 ms

Resolved: Samsung performance has improved in 7f5d0e9.


Update index.md

chinese to english 1.0
Summary
Brief explanation of the proposed changes.
Basic example
Include a basic example, screenshots, or links.
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome?
Checks

[ ] Read Create a Pull Request
[ ] Supports all screen sizes (if relevant)
[ ] Supports both light and dark mode (if relevant)
[ ] Passes npm run test

roadmap update


CHEBI:88801 (R)-salsolinol structure

Hi Adnan,
I just submitted CHEBI:194082 and noticed that the structure of its conjugate base CHEBI:88801 is missing the R stereo. Could you please fix it?
Many thanks,
Nevila

Now fixed. Thanks


hitting toggle CheckButton repeatedly causes TreeView to keep expanding

This is my code.
If I keep hitting that toggle button the treeview just keeps expanding and finally goes out of screen.
import tkinter as tk
from tkinter import ttk

root = tk.Tk()
style = ttk.Style(root)
root.tk.call('source','./forest-light.tcl')
root.tk.call('source','./forest-dark.tcl')
style.theme_use('forest-dark')

def toggle_mode():
    if mode_switch.instate(['selected']):
        style.theme_use('forest-light')
    else:
        style.theme_use('forest-dark')

frame = ttk.Frame(root)
frame.pack()

widgets_frame = ttk.LabelFrame(frame, text='Label Frame')
widgets_frame.grid(row=0,column=0,padx=20,pady=10)

mode_switch = ttk.Checkbutton(widgets_frame,text='Mode',style='Switch', command=toggle_mode)
mode_switch.grid(row=0,column=0,padx=5,pady=10,sticky='nsew')

tree_frame = ttk.Frame(frame)
tree_frame.grid(row=0,column=1,pady=10)

# scrollbar needs to be added and attached to treeview
treescroll = ttk.Scrollbar(tree_frame)
treescroll.pack(side='right',fill='y') # fill entire vertical axis

# treeview
excel_columns = ['name','age','subscription','employment']

treeview = ttk.Treeview(tree_frame,
                        show='headings',
                        columns=excel_columns,
                        height=11,
                        yscrollcommand=treescroll.set)

treeview.column('name',width=100)
treeview.column('age',width=40)
treeview.column('subscription',width=100)
treeview.column('employment',width=100)

treeview.pack()
treescroll.config(command=treeview.yview)

root.mainloop()

I was following a tutorial based of here
https://github.com/codefirstio/tkinter-excel-app/blob/main/main.py
https://www.youtube.com/watch?v=8m4uDS_nyCk&ab_channel=CodeFirstwithHala

Refs.:
https://core.tcl-lang.org/tk/tktview?name=bc602049ab
https://github.com/rdbende/Azure-ttk-theme/issues/40
https://github.com/rdbende/Sun-Valley-ttk-theme/issues/11

Thanks for sharing the specifics. I have right now decided to remove the toggle button altogether and instead will use the config file to set the theme for my use case which seems to be a suitable solution for my need.

Thanks for sharing the specifics. I have right now decided to remove the toggle button altogether and instead will use the config file to set the theme for my use case which seems to be a suitable solution for my need.

I'm not good at English, I looked at the links but I don't understand, guys, is there a solution for this problem? And how?

     # Treeview
    ttk::style element create Treeview.field image $I(card) \
        -border 5\
        -width 0\
        -height 0\

For each light and dark tcl file, add the last two lines of code ( -width 0\  -height 0) at ttk::style element create Treeview.field image $I(card). Hitting the toggle check button will no longer cause TreeView to keep expanding!


Distinguish between no & no new applicable configurations

This patch allows additional distinction in the displaying of pending
configurations:

if there's no applicable configuration the pending configuration will be
shown as "";
if the applicable configuration is same as currently applied one, it will
be displayed as an empty string "".

Signed-off-by: Patrick Benavoli<EMAIL_ADDRESS>

This pull request is now managed with CodeReviewHub. Refresh.

:+1: previously reviewed on #197

This needs to be documented somewhere.

:+1:


documentation

current documentation is mostly useless, as the same could be achieved by simply browsing through src/Psl directory.
Plan:

write better documentation using markdown
each component should be documented on it's own, with examples.
each component documentation should include all symbols defined within the component.
deploy documentation using GitHub pages.

Task list:

[ ] Cover
[x] Installation
[ ] Contribution
[ ] Components

[ ] Async
[x] Channel
[x] Class
[ ] Collection
[ ] DataStructure
[ ] Dict
[ ] Encoding

[ ] Base64
[ ] Hex

[ ] Env
[ ] File
[ ] Filesystem
[ ] Fun
[ ] Hash
[x] Html
[ ] IO
[x] Interface
[x] Iter
[x] Json
[x] Math
[ ] Network
[ ] Observer
[ ] Password
[x] PseudoRandom
[ ] RandomSequence
[ ] Regex
[ ] Result
[ ] Runtime
[x] SecureRandom
[x] Shell
[ ] Str

[ ] Byte
[ ] Grapheme

[ ] TCP
[x] Trait
[ ] Type
[ ] Unix
[ ] Vec

[ ] CHANGELOG
[ ] Credits
[ ] License

documentation repository: https://github.com/php-standard-library/php-standard-library.github.io
documentation url: https://php-standard-library.github.io

channel component documentation has been written 🎉 https://php-standard-library.github.io/#/components/channel/

class, interface, trait, and html components are now documented 🎉
https://php-standard-library.github.io/#/components/class/
https://php-standard-library.github.io/#/components/interface/
https://php-standard-library.github.io/#/components/trait/
https://php-standard-library.github.io/#/components/html/

shell component is now documented:
https://php-standard-library.github.io/#/components/shell/

Been through the links above: very clear explanations. Haven't really found any typos at this point either 🙂

pseudo-random, and secure-random components are now documented:
https://php-standard-library.github.io/#/components/pseudo-random/
https://php-standard-library.github.io/#/components/secure-random/

runtime component is now documented:
https://php-standard-library.github.io/#/components/runtime/

shell exceptions are now documented:
https://php-standard-library.github.io/#/components/shell/?id=exceptions

@veewee wanna take care of Fun and Regex? i think you would be better at explaining those.

json component is now documented:
https://php-standard-library.github.io/#/components/json/

iter component is now documented:
https://php-standard-library.github.io/#/components/iter/

@veewee wanna take care of Fun and Regex? i think you would be better at explaining those.

I don't mind, but am a bit limited in OS time the coming 2 months. We're working hard on a tight deadline.

I just added inline-code-highlight docsify plugin to the documentation.
This helps 99% of the time, and makes things more readable, e.g:

examples of before/after
Html before:

Html after:

Shell before:

Shell after:

However, a big disadvantage is that it breaks for signatures such as Iter\apply<T>(iterable<T> $iterable, (callable(T): void) $callback): void;
everything gets highlighted correctly, except the Ìter\apply<T> part:

so to get around this, i moved the generic templates declaration before the function name, so now it looks like this:

It looks a bit weird, but works, and it's the only option i could come up with at the time.
personally, i don't see it as an issue since before signatures are not real, but rather put in place to help people understand the function behavior.
If anyone has a better option, I'm open for suggestions.
commit: https://github.com/php-standard-library/php-standard-library.github.io/commit/c40c7299df4f4640fc52ff669c217d97eb8db370

Would it make sense to introduce an attribute for annotating the generics in the docs?
It might be less confusing for PHP developers?

i think @template works great.
i also did some modification to remove list style type, and add a bottom border for each symbol definition.
before:

after:

another update:
each symbol now has a border around it to make it look like a box, the next step would be to give these "boxes" unique ids, and add a "link" button, so people can share links to a specific symbol in the documentation.

Yes, @template works well indeed.
Would it also make sense to add @pure instead of showing it in those separate info elements?

yea, i think that would work, same for @mutation-free, @external-mutation-free, and @immutable

done 🎉

async component is now documented:
https://php-standard-library.github.io/#/components/async/

HI @azjezz, I think it could be useful to add some documentation about why using this library (or maybe I missed it).
For instance, I saw a PR https://github.com/Roave/BackwardCompatibilityCheck/pull/306 removing some libraries in favor of this one, and I was kinda curious about why this change was worth it.
So for instance, as a developper using webmozart/assert currently, would I have some benefit to change ?

I think that would be a nice addition, but currently it's not a high priority, as it's more important to document components that write a comparison.

fun, and promise components are now documented:
https://php-standard-library.github.io/#/components/promise/
https://php-standard-library.github.io/#/components/fun/

TCP component is now documented:
https://php-standard-library.github.io/#/components/tcp/

Unix component is now documented:
https://php-standard-library.github.io/#/components/unix/

Fyi : The docs web site on my phone tries to display the content in about half the available screen size. It is due to the borders and the margins. It is a bit annoying, not sure if other people will read it on the phone though 😉

Yea, I'm aware of that issue, i will try fixing it after finishing up the documentation ( though, I am not really good with CSS stuff :p )


Generate end-user documentation in the Wiki

Create the User Guide in this project's Wiki.
~Reserve the Wiki for the end-user documentation. Developer docs are in the README.~

[x] Add link to the User Guide to the callattendant's nav-bar branding.
[x] Add a link to the User Guide to the README.
[x] Add Installation instructions including service setups for Linux/Raspberry Pi
[x] Add Configuration instructions
[x] Add Hardware Interface instructions

Wiki User Guide completed.  Always room for improvement, but no need to keep this issue open.


Add more info about the host value on the "Starburst/Trino setup" oage

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/docs/core/connect-data-platform/trino-setup
What part(s) of the page would you like to see updated?
Under "Host parameters", host contains the info

host
mycluster.mydomain.com
The hostname of your cluster.Don't include the http:// or https:// prefix.

I personally struggled a bit to connect dbt to Starburst Galaxy because the URL of Starburst Galaxy is not the host. The host contains information about the cluster as well and not only the URL used to access Starburst Galaxy.
I managed to get the correct host by checking "partner connect" in Starburst Galaxy but I couldn't have guessed it otherwise

Additional information
No response

hey @damian3031 @findinpath - wanted to ask if you had any insight on this so we can clarify further? thank you in advance!

I agree that it would be useful to include an example with a host specific to Starburst Galaxy. I have added one in the PR https://github.com/dbt-labs/docs.getdbt.com/pull/6571


[Issue]: DB async session isn't thread safe

Contact Details(optional)
No response
What is the issue you are having?
We have multiple async requests on a single async session of sqlalchemy. However, it doesn't support this. So, we should re-design and re-write this part.
See https://github.com/MagicStack/asyncpg/issues/863
We need to re-design the async part by following https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html
Relevant log output
These logs below are from different services.

sqlalchemy.exc.InterfaceError: (sqlalchemy.dialects.postgresql.asyncpg.InterfaceError) <class 'asyncpg.exceptions._base.InterfaceError'>: cannot perform operation: another operation is in progress
[SQL: SELECT account.id, account.username, account.email, account._hashed_password, account._hash_salt, account.is_verified, account.is_active, account.is_logged_in, account.created_at, account.updated_at
FROM account
WHERE account.username = $1::VARCHAR]
[parameters: ('user',)]
(Background on this error at: https://sqlalche.me/e/20/rvf5)

sqlalchemy.exc.InterfaceError: (sqlalchemy.dialects.postgresql.asyncpg.InterfaceError) <class 'asyncpg.exceptions._base.InterfaceError'>: cannot perform operation: another operation is in progress
[SQL: SELECT data_set.id, data_set.name, data_set.account_id, data_set.created_at, data_set.updated_at
FROM data_set ORDER BY data_set.updated_at DESC]
(Background on this error at: https://sqlalche.me/e/20/rvf5)

raise sa_exc.IllegalStateChangeError(
sqlalchemy.exc.IllegalStateChangeError: Method 'close()' can't be called here; method '_connection_for_bind()' is already in progress and this would cause an unexpected state change to <SessionTransactionState.CLOSED: 5> (Background on this error at: https://sqlalche.me/e/20/isce)

cc @Micost

raise sa_exc.IllegalStateChangeError(
sqlalchemy.exc.IllegalStateChangeError: Method 'close()' can't be called here; method '_connection_for_bind()' is already in progress and this would cause an unexpected state change to <SessionTransactionState.CLOSED: 5> (Background on this error at: https://sqlalche.me/e/20/isce)


Fixed lookahead crash error

Removed indexing of input to prevent possible crash

Context: this successfully fixes the crash when (1)/sqrt(x) is pasted. Merging


search("g4m3", x)['song_hits'] returns a list of length 9, regardless of what X is

Okay so when I try searching for "g4m3" using the Mobileclient.search method, I ALWAYS get a song_hits list with a length of 9. Here is my code:
import gmusicapi
from gmusicapi import Mobileclient
import json

api = Mobileclient()
api.login(email, pass, "1234567890abcdef")

print(len(api.search("g4m3", 1)['song_hits']))

(the '1' in api.search can be anything)
Am I doing something wrong or is this a bug in either the api or Google Play Music?

Huh, odd. My bet is it's a bug on Google's side triggered by results that don't fill out an entire chunk, in which case they just return all the results. For example, trying "the beatles", 1 does properly get only 1 result.

Is it also possible that this is affecting the official Google Play Music applications, as searching "g4m3" on music.google.com results in the same list of 9 songs?

Yup, exactly: if my theory is right, this is a serverside issue that affects all clients (including our unofficial one).

Going to close this since it seems like it was just something wonky on Google's end.


Message "statusscan blocked (124) - fallback to old results" while Syncing

I have a problem. from 90% suddenly this message went off and the syncing stops felt.

"statusscan blocked (124) - fallback to old results" whats this?

I saw the other post. But there is no solution in it. Why does this happen and how can I fix it?

I had this same error message. Not sure if it will work for everyone, but my issue was that my network security was blocking it as a potential threat. I allowed an exception for its IP address and the error disappeared and the blockchain downloaded.

"statusscan blocked (124) - fallback to old results" whats this?

statusscan blocked is due to the way the v1.7.1 still gathers system information on the pi before showing status information. This will change with v1.7.2 which introduces a non-blocking background scan for system information.
Why you experience this on "syncing" I dont know. Last resort would be to CTRL+C to exit to terminal - use command restart. If that still blocks CTRL+C to exit to terminal - use command off and then startup with a fresh flashed sd card & choose setup fresh (with use existing blockchain data).

"statusscan blocked (124) - fallback to old results" whats this?

statusscan blocked is due to the way the v1.7.1 still gathers system information on the pi before showing status information. This will change with v1.7.2 which introduces a non-blocking background scan for system information.
Why you experience this on "syncing" I dont know. Last resort would be to CTRL+C to exit to terminal - use command restart. If that still blocks CTRL+C to exit to terminal - use command off and then startup with a fresh flashed sd card & choose setup fresh (with use existing blockchain data).

I am having the same issue after months of rock-solid/no-problems operation. For me, the trouble began after my network switch failed while I was on extended holiday, resulting in my raspiblitz running for weeks but receiving no data.
I've tried re-flashing the SD card, and issue still exists.
I am ready to try your last suggestion: re-flashing + choosing fresh setup.
Question: If I go to the main menu and select Repair > Reset HDD is that the same as choosing a fresh setup on installation?
Also, what exactly gets deleted during this....I assume my wallets & onion addresses, etc. remain intact and unchanged?

Beware that "fresh setup" deletes wallets - if you have funds on that node other options should be considered.
If you want to do a "fresh setup" you dont need to go to "Repair" first. You just flash a new sd card, boot your Raspi with that. It will ask you to ssh in again and when asked to recover you just say "other options" and then from the menu "fresh setup". It will then ask you if you want to use the blockchain and delete all other data (including old wallets, etc).

Beware that "fresh setup" deletes wallets - if you have funds on that node other options should be considered.
If you want to do a "fresh setup" you dont need to go to "Repair" first. You just flash a new sd card, boot your Raspi with that. It will ask you to ssh in again and when asked to recover you just say "other options" and then from the menu "fresh setup". It will then ask you if you want to use the blockchain and delete all other data (including old wallets, etc).

Thanks for that detail. I was considering doing the "repair" option before re-flashing, just to see if that alone would fix the issue.


Refactor the command line option handling of the jerry tool

The file main-unix.c contained a lot of recurring patterns in the
command line option handling parts. This patch removes these code
clones with the introduction of two helper macros. The goal of the
patch is to have a smaller jerry tool, both source and binary
wise.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

Note: the first version of this patch had static functions for check_feature and check_usage. Interestingly, they have increased the binary. Interestingly no.2, the use of macros has decreased the size of the tool.

I've updated the PR according to the comments

I've updated the PR (removed the inlines)


Search result screen animation is broken

The search results screen has had animation that causes the header and footer to slide away when the list is scrolled.
This animation is no longer there. The screen is usable, but the amount of screen real estate lost to header and footer makes the screen hard to use.
Probably need to do a binary search through the commit history to find the change that broke this. Look into making better automatic testing for this, as the functionality is probably somewhat fragile.
Acceptance Criteria

[ ]  The scroll animation works again

As of April 29, 2021, this is broken in prod and working in staging on my android, on Ian's Android staging broken, production is fixed.


test: replace Jasmine with Jest as the testing framework

Description
Replace Jasmine testing framework with Jest in order to improve the development experience, and allow features like global setup and teardown functionalities, as well as parallel processing.
Changes

Remove Jasmine and replace with Jest
Use ts-jest library to support Jest with TypeScript
Add option to silence logs to the console to improve readability
Create global setup and teardown for Docker containers in integration tests

🎉


Link to full node log from the window

Resubmitting https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/61
Switching from the convenient log thing to full log listing is annoying, and in case the logs are longish, often necessary. This adds direct link.

@svanoort, I am refiling the PR  have merge prematurely. Please review.

Is there any update? I would really like to get this trivial thing integrated. Thanks!

Re-running the build.

The tests on windows are failing for ages. Should we not better be without them?

Guys is there any way to move this forward? I see maintainers are busy and my attempts to take a lead and integrate this was not appreciated in the past...

@olamy, Thanks!


healthcheck: Support positional type+endpoint args

Actually in the Python version the type and endpoint args are only
positional. This is the full --help output:
usage: baseplate-healthcheck [-h] [--probe {readiness,liveness,startup}]
                             {thrift,wsgi} endpoint

Check health of a baseplate service on localhost.

positional arguments:
  {thrift,wsgi}         The protocol of the service to check.
  endpoint              The endpoint to find the service on.

optional arguments:
  -h, --help            show this help message and exit
  --probe {readiness,liveness,startup}
                        The probe to check.

So support up to 2 positional args, and use them to override
--type/--endpoint flags, and as a result the go version of healthcheck
can really take the same args as the python version (and more).

:haircut: ping

:haircut: Added this part:

Also add unexported runArgs which allows to override the output to be used in tests, so we don't get so much stuff going into stderr in tests.


Deployment error: ״Failed to create or update User app in Azure Active Directory״

az cmdlets with deprecated attributes need to update to:
az ad app update --id $app.appId --sign-in-audience "AzureADMultipleOrgs" --enable-access-token-issuance $AllowImplicitFlow
az ad app create --display-name $appName --sign-in-audience "AzureADMultipleOrgs" --enable-access-token-issuance $AllowImplicitFlow

Hi @OritOrlanczyk ,
We are testing this scenario from our end and will keep you posted.

I'm having the exact same issue as OP. I tried to run the deploy.ps1 yesterday starting from fresh (including PowerShell modules), but it always fails, when it tries to create the azure ad apps. I checked that none of the apps were created. Ran the script step by step to confirm it fails to the azure ad app creation, even tho I'm running as global admin.
I need to try to fiddle with the az commands as recommended by OP.

@gsv022 I can confirm the fix. Made the following changes and it started to work.
Running PS 5.1 build 20222 rev 653
Az 8.0.0
Replaced in line 309:
This: az ad app update --id $app.appId --available-to-other-tenants $MultiTenant --oauth2-allow-implicit-flow $AllowImplicitFlow
With this: az ad app update --id $app.appId --sign-in-audience "AzureADMultipleOrgs" --enable-access-token-issuance $AllowImplicitFlow
And in line 323:
This: az ad app create --display-name $appName --available-to-other-tenants $MultiTenant --oauth2-allow-implicit-flow $AllowImplicitFlow
With this: az ad app create --display-name $appName --sign-in-audience "AzureADMultipleOrgs" --enable-access-token-issuance $AllowImplicitFlow

Hi @OritOrlanczyk ,
Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses. Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up.

Hello, the script still has this issue... just had it with customer... please fix!


Firefox inputs focus issue (1.1.0)

Hi,
Im seeing similar issues that seem to have been resolved in 1.1.0. However I still notice some issues on Firefox!
What does not seem to work for us is portal select components for example with Nextui. Dont retain focus on Firefox. On Chrome I managed to get it to work just fine!
https://github.com/user-attachments/assets/6c640886-7ed6-4f7f-b57d-a64ada33c88c
Clicking does not trigger focus, or gets lost too quickly. Repeated pressing and holding somehow retains focus, but only briefly.


Adblock integration?

any plans of a adblock integration?

what is the need for adblock?
ads: If you are wrapping something like JIRA, or Trello, or Facebook Messenger, you don't need to worry about ads.
privacy: If you are serious about privacy you may want to consider something like privoxy. Which can filter on the http level. also.
as a simple alternative to Fluid, there are many user stories i would prioritize over this.  mostly something like: #35

Thought it for sites using annoying ads and popups.
Not most important but useful in some case I think.

@featdd this app makes more sense for wrapping web apps instead of something like the new york times. but seriously, try checking out privoxy.

@featdd Nope, no plans at the moment. I do agree with what @jkatzer said, I don't think this is an important issue if you're wrapping web apps. Though it would be cool to have a --no-ads cli option to disable ads on pages like Facebook, you're more than welcome to submit a pull request if you can find a way to do this.

don't know how difficult it can be to integrate adblock, chrome plugin can be found on github.

@featdd It should be possible to port Chrome Extensions like Adblock into a .js script that is loaded by app/src/preload.js


Support Quantile and Ordinal scaling

Close #3579

Background

Change List

Updated Docs
Add domain property on functions
Add case for CPU fallback

Coverage decreased (-2.9%) to 79.909% when pulling da05589b3802a7eff28d96c995e52494834600bd on Navneet-Sahota:support-quantile-and-ordinal-scaling into cc598f470bababf6e10fe7a734d9114546420682 on uber:master.

CPUGridLayer
Scale: Linear

Scale: Quantize

Scale: Quantile

Scale: Ordinal

Also add test cases, to grid-layer-spec.js to verify new fallback cases.

For colorScaleType prop, you need to add unit tests in cpu-grid-layer.spec.js, you can look at existing tests for reference.

Please remove all references to EnhancedCPUGridLayer, it was only for testing. Given you are using golden images from this layer, we should be good. Once removed it is good to land.


which engine do you use 同

hello， the visualization is cool， could you please tell me which software do you use to do the rendering? or where can I get the similar code to do the rendering, thanks

We use bevy engine to render 3d dynamic scenes. We have not released the visualization code because the tool is complicated to deploy, and it is inconvenient to add new visualization features.

thank you for replying！


Added Swift Package Manager

This PR organizes the files into the standard structure provided by swift.org. The file format should help as we can easily add more targets (like a CLI). The manifest currently contains all swift targets (so not XiCore) because I'm not sure how to add a compiled rust target as a dependency in the manifest. That means the manifest cannot currently completely replace the project file in the repo (if anyone knows how to, any guidance would be greatly appreciated).

Thank you for reviewing the PR. Is there anything left for me to do in order to merge?

@liamrosenfeld cool, thanks for this. I would be curious for feedback from other contributors who have been following recent changes in swift/cocoa land: @terhechte, @lukakerr, @ryanbloom @demalex?
In any case I'll want to give this a look through and think, but it probably makes sense. Has SPM supplanted things like CocoaPods and Carthage, now?

Okay @liamrosenfeld I'm interested in this patch but I don't really feel like I have a good enough sense of what's going on here to make an informed decision. What does SPM buy us? what does it replace? what are its current limitations, etc? If you can point me towards anything that I should read for background info I'd be grateful.
As an aside, we're starting to use zulip as an extra collaborative tool; it might be a helpful way to chat about this? If interested take a look at http://xi.zulipchat.com.

@cmyr, SPM would immediately provide the project with a more organized directory structure as the manifest enforces the use of 'Sources' and 'Tests' folders. In the medium term, it would act as a dependency manager (which a CLI target would most likely need) and as it's the official dependency manager it would save the headache of switching from Cocoapods/Carthage later on. In the long term, it possibly could replace the Xcode project files. It currently does so in server-side swift, which allows for development in more IDEs then solely Xcode.
Joining the Zulip now.

@liamrosenfeld Okay, took another look through and am happy to get this merged once the conflicts are resolved!

Resolved all the conflicts!

Resolved the new conflicts

I just got a CLI working that is able to open a file inside the editor (working on --wait functionality now).  It's based on this branch so I'll create the PR once this is merged.

I added Xi-Editor as a submodule because if the Xcode Project is ever replaced it would require a couple more cds during the install process which can get annoying. It is just tracking the master branch instead of any specific version so it should auto update.

@liamrosenfeld Okay one nit here is I'd like the Submodule change to be a separate PR so that we can sort of think about it separately. Ping me after that change and we can merge this. 👍

@cmyr, I split the submodule commit off.

Resolved the conflicts.

Thank you! I moved the submodule commit over to this PR.


2024-05-07-nope

OpenReview Submission Thread

Checklist before opening a PR

[ ] I am opening a pull request against the main branch of the 2024 repo.
[ ] The title of my PR is exactly the name of my markdown file

i.e. _posts/2024-05-07-[SUBMISSION NAME].md would require a PR name 2024-05-07-[SUBMISSION NAME]

[ ] I have anonymized my post: my author's list is Anonymous, and there is no potential
content which can reveal my/my collaborators identities.
[ ] My post matches the formatting requirements, including (but not limited to):

[ ] I have ONLY MODIFIED files in the following locations (failure to do so will result in
your PR automatically being closed!):

a Markdown (or HTML) file in _posts/ with the format _posts/2024-05-07-[SUBMISSION NAME].md (or .html)
static image assets added to assets/img/2024-05-07-[SUBMISSION NAME]/
interactive HTML figures added  to assets/html/2024-05-07-[SUBMISSION NAME]/
citations in a bibtex file in assets/bibliography/2024-05-07-[SUBMISSION NAME].bib

[ ] I have a short 2-3 sentence abstract in the description field of my front-matter (example)
[ ] I have a table of contents, formatted using the toc field of my front-matter (example)
[ ] My bibliography is correctly formatted, using a .bibtex file as per the sample post

Any other comments

This counter-example doesn't work because a file that doesn't match our filters was pushed to the assets directory!

Yes! Intended behaviour! These are examples I'm linking in the submitting page ^^ @fabianp

thats amazing. Thank you so much for testing!

(I'll now delete my comments to avoid distraction from your examples)


Problem installing requirements

(.venv) user@DESKTOP:~/Asyrp_official$ pip install -r requirements.txt
Collecting blobfile==1.3.1
Using cached blobfile-1.3.1-py3-none-any.whl (70 kB)
ERROR: Could not find a version that satisfies the requirement clip==1.0 (from versions: 0.0.1, 0.1.0, 0.2.0)
ERROR: No matching distribution found for clip==1.0
How can I get clip==1.0?

I encountered the same error, it is the openai-clip package, not the PyPi one.
I commented that from the requirements file and used this command instead:
pip3 install clip-by-openai


(params_with_wd if needs_wd else params_with_wd)['params'].append(parameter) in deep.py，is there a mistake here? Why if...else...  are all connected to params_with_wd?

Thanks for your interesting work, which gives us new hope for tabular data research!
I have some questions  to ask:
（1）(params_with_wd if needs_wd else params_with_wd)['params'].append(parameter) in deep.py，is there a mistake here? Why if...else...  are all connected to params_with_wd?
（2）This bug occurs during training when trial_0 is completed and trial_1 is in progress, I observed that the gpu usage increases as trial increases, is this normal? Is it possible to release the gpu after trial_0 is completed and then proceed to trial_1? Currently, we only have 12 G of gpu resources.
[...] tmp22mqfk7j_trial_1/output | 0:03:04.846372
Epoch 39: 100%|███████████████████████████████████████████████████████████████████| 52/52 [00:04<00:00, 12.
(val) -0.426 (test) -0.414 (loss) 0.11597█████████████████████████████████████████| 52/52 [00:04<00:00, 13.
[W 2023-10-24 17:37:27,179] Trial 1 failed with parameters: {'model.d_main': 353, 'model.context_dropout':<PHONE_NUMBER>6, 'model.dropout0': 0.2300649112954666, 'optimizer.lr': 0.0004817508474772368, '?optimizer.weigh': True, 'optimizer.weight_decay': 7.098936257405907e-05} because of the following error: AttributeError("mtorch.cuda' has no attribute 'OutOfMemoryError'").

Hi! Thank you for your interest in our work and for reporting these issues!

is there a mistake here? Why if...else... are all connected to params_with_wd?

Yes, this is definitely a mistake :) Luckily, this is not something critical, though we should remove this to avoid confusion.

I observed that the gpu usage increases as trial increases, is this normal?

Does it happen only between trial 0 and trial 1 or throughout the whole tuning process? Also, is your environment configured as described in README? I mean all the software versions etc. I have just checked my environment for TabR and torch.cuda has the OutOfMemoryError class in it, however, in a different environment, it does not. Perhaps, torch.cuda.OutOfMemoryError is available only in some versions of PyTorch and only if CUDA is available.

Currently, we only have 12 G of gpu resources.

Most of the time I run experiments on a 12G GPU, too, and so far, without any issues related to memory leaks. Overall, for now, I don't have good explanations for why it can happen.

What is the difference or connection between trial_0 and trial_1?The process of trial_0 consists of: each epoch contains batch number as samples number /batch size, the epochs number performed depends on the patience(set as 16) setting, then reprot and save....
So trial_1 is also the same process  as trail_0?

Yes. Let's consider this config as an example:

this line launches the hyperparameter tuning procedure.
specifically, it runs the objective function for n_trials=100 times (see the config).
the objective function, in turn, calls the function = "bin.tabr.main" (see the config).
the report of each of n_trials runs is saved. So you have to ensure that you don't store anything non-trivial in reports, otherwise, it indeed can result in high memory consumption, because they are all stored in memory during the whole tuning process.

Feel free to reopen the issue if needed!


Fix JsonUtil.addTo*() null add

Found through FirstMessageAsJSON failing and showing Unavailable in red in jconsole for queues/messages with null property values.

I'm adding a JIRA to the commit message. I'm doing this through my manual merge


Short solution needed: "Working with linear algebra in Rust" (rust)

Please help us write most modern and shortest code solution for this issue:
Working with linear algebra in Rust (technology: rust)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to multiply matrices in Rust?
How to calculate the inverse of a matrix in Rust?
How to add matrices in Rust?
How to declare a matrix in Rust?
How to perform matrix operations in Rust?


Help output is too useful

$ ./build/Build/Products/Debug/fbsimctl help
Help

I know this is mentioned in https://github.com/facebook/FBSimulatorControl/issues/70 but maybe it'd be better to say:

"Help information coming soon..."

The plumbing is in, that doesn't mean the help is ready yet. I'll put some unimplemented message in there.

Duping to #256


Request: Overload the createAccount function in CoinbaseSmartWalletFactory.sol

Context
The ERC7579 standard is great because it allows third-parties to add new features and functionality to a smart account without changing the core logic. I'm assuming the Coinbase Smart Wallet support this standard or something similar at mainnet launch.
Proposal
Currently in the CoinbaseSmartWalletFactory.sol smart contract doesn't include support for enabling modules during setup.
function createAccount(bytes[] calldata owners, uint256 nonce)
        public
        payable
        virtual
        returns (CoinbaseSmartWallet account)
    {
        if (owners.length == 0) {
            revert OwnerRequired();
        }

        (bool alreadyDeployed, address accountAddress) =
            LibClone.createDeterministicERC1967(msg.value, implementation, _getSalt(owners, nonce));

        account = CoinbaseSmartWallet(payable(accountAddress));

        if (alreadyDeployed == false) {
            account.initialize(owners);
        }
    }

From a developer perspective it would be great if this function was also overloaded with calldata instructions argument so modules could be enabled during the deployment.
function createAccount(bytes[] calldata owners, uint256 nonce, bytes instructions)
        public
        payable
        virtual
        returns (CoinbaseSmartWallet account)
    {
        if (owners.length == 0) {
            revert OwnerRequired();
        }

        (bool alreadyDeployed, address accountAddress) =
            LibClone.createDeterministicERC1967(msg.value, implementation, _getSalt(owners, nonce));

        // 1. INSERT LOGIC FOR VALIDATING DEPLOYMENT SIGNATURES
        // 2. INSERT LOGIC FOR ENABLING MODULES

        account = CoinbaseSmartWallet(payable(accountAddress));

        if (alreadyDeployed == false) {
            account.initialize(owners);
        }
    }

As far as I understand ERC-4337 transaction bundling this could also be achieved by bundling a createAccount function call and subsequently a enableModule function call on the smart wallet directly, but I do think there is something to be said about the "developer experience" in simplifying this process.
This pattern can also be observed in the Safe smart account factory smart contracts but suffers from poor documentation and confusing to data field that uses the delegatecall functionality, which has personally lead to 6+ hours wasted debugging.
function setup(
        address[] calldata _owners,
        uint256 _threshold,
        address to,
        bytes calldata data,
        address fallbackHandler,
        address paymentToken,
        uint256 payment,
        address payable paymentReceiver
    ) external override {
        setupOwners(_owners, _threshold);
        if (fallbackHandler != address(0)) internalSetFallbackHandler(fallbackHandler);

        setupModules(to, data); // <- LOGIC TO ENABLE SAFE MODULES

        if (payment > 0) {
            handlePayment(payment, 0, 1, paymentToken, paymentReceiver);
        }
        emit SafeSetup(msg.sender, _owners, _threshold, to, fallbackHandler);
    }

Considerations
Allowing modules to be enabled during smart account creation without an additional authorization step introduces a "griefing" attack by allowing a "bad actor" to create a smart account on behalf of a user with a "malicious" module already enabled.
In a world with MEV and public mempools it's easy to front-run a smart account setup process with callback data for enabling arbitrary logic if module authorization is absent from the calldata.
Because of this the first step is authorize the setup with a signature by the owner(s) before completing the deployment process, which is why the "INSERT LOGIC FOR VALIDATING DEPLOYMENT SIGNATURES" comment is included in example overloaded function.
tl;dr
The proposed changes would make available two function calls:

createAccount(bytes[] calldata owners, uint256 nonce)
createAccount(bytes[] calldata owners, uint256 nonce, bytes instructions)

One for a vanilla deployment and another for authorized deployment with pre-enabled modules adhering to the ERC-7579 standard.

alsooo i can't resist a good meme lol


raise asyncio.TimeoutError from None

Hey, please help me. I've had this problem many times while using it.
TimeoutError
Traceback:
File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 559, in _run_script
    self._session_state.on_script_will_rerun(rerun_data.widget_states)
File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/state/safe_session_state.py", line 72, in on_script_will_rerun
    self._state.on_script_will_rerun(latest_widget_states)
File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/state/session_state.py", line 542, in on_script_will_rerun
    self._call_callbacks()
File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/state/session_state.py", line 555, in _call_callbacks
    self._new_widget_state.call_callback(wid)
File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/state/session_state.py", line 277, in call_callback
    callback(*args, **kwargs)
File "/app/gui.py", line 332, in click_handler
    asyncio.run(prompt_handler())
File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
File "/app/gui.py", line 275, in prompt_handler
    await asyncio.gather(
File "/app/gui.py", line 156, in disco_request
    async for resp in client.post(
File "/usr/local/lib/python3.10/site-packages/jina/clients/mixin.py", line 346, in post
    async for result in c._get_results(
File "/usr/local/lib/python3.10/site-packages/jina/clients/base/http.py", line 141, in _get_results
    async for response in streamer.stream(request_iterator):
File "/usr/local/lib/python3.10/site-packages/jina/serve/stream/__init__.py", line 73, in stream
    async for response in async_iter:
File "/usr/local/lib/python3.10/site-packages/jina/serve/stream/__init__.py", line 202, in _stream_requests
    response = self._result_handler(future.result())
File "/usr/local/lib/python3.10/site-packages/jina/clients/base/helper.py", line 123, in send_message
    return await self.session.post(url=self.url, json=req_dict).__aenter__()
File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 1141, in __aenter__
    self._resp = await self._coro
File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 560, in _request
    await resp.start(conn)
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 894, in start
    with self._timer:
File "/usr/local/lib/python3.10/site-packages/aiohttp/helpers.py", line 720, in __exit__
    raise asyncio.TimeoutError from None

That seems like an issue from your DiscoArt server, please check if it is working properly.


feature: Update version of tree-sitter crate to the latest one

Did you check the tree-sitter docs?

[X] I have read all the tree-sitter docs if it relates to using the parser

Is your feature request related to a problem? Please describe.
The outdated version disallows proper use with latest tree-sitter version, also confuses a lot.
As the time of writing, the latest version of tree-sitter is 0.22.2 where as the crate uses ~0.20.10 version requirement.
Describe the solution you'd like
Update the Cargo.toml file =)
Additionally, tree-sitter crate has broken semver semantics. Parser::set_language function's signature was changed, but the patch was submitted as a minor update. So more changes have to be made.
Describe alternatives you've considered
None
Additional context
No response

0.21.0 is now released on git(hub), crates, npm, and pypi


feat(app): Add support for custom scope in verfication flow

Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (398e66e) 89.09% compared to head (c8a4e21) 89.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   89.09%   89.06%   -0.04%
==========================================
  Files         103      103
  Lines        4146     4150       +4
==========================================
+ Hits         3694     3696       +2
- Misses        308      310       +2
  Partials      144      144

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dump notifications

Hi! I'm getting some error messages which are outputted through the notifications.
How can I dump or copy my notifications into my clipboard?

There's a :Notifications command to a log of the history. There's also a telescope extension which can open the notifications in a new window.
If that doesn't work then you can use the require("notify").history function to create your own way to show them

That's not (really) what I meant.
Normally you would get an error message if you found a bug, as a result the error message is printed out with vim.notify. Now when I reported the bug/error message I couldn't dump the output of the error message to paste it into my the issue-ticket. I needed to create a screenshot which is mostly not as good as the error message in a code block.
So what I'm thinking (or expecting) is to have a command which opens a new window with the notificactions-history (or something like that), to be able to copy+paste some notifications.
Alternatives
Yes, using the telescope extension coud be possible (I didn't knew about it, so thank you for the information) but I think a small command wouldn't be bad as well.
Is it possible to create a provided command like :NotificationsDump for this plugin? Can this be done by creating a new window and writing there the stuff from require("notify").history()? Should I (try) help here (by doing a PR)?

The telescope notification is able to open a new window already so I don't see much point in adding another one. I don't wish to add solutions for many use cases into this repo and instead allow users to have a good interface to write their own in a simple piece of lua code. For example to dump all messages to a floating window
local history = require("notify").history()

local lines = {}
for _, notif in ipairs(history) do
  for _, line in ipairs(notif.message) do
    table.insert(lines, line)
  end
end

local buf = vim.api.nvim_create_buf(false, true)

vim.api.nvim_buf_set_lines(buf, 0, -1, false, lines)

vim.api.nvim_open_win(buf, true, {
  relative = "editor",
  width = 150,
  height = 30,
  row = 0,
  col = 0,
  border = "single",
})

Appreciate the offer for help, I'd be happy to receive a code snippet to add to the wiki for usage recipes :smile:

Hm... ok, could you please tell me the name of this telescope extension? I can't find it here if I search the keyword not

It's already built-in to nvim-notify https://github.com/rcarriga/nvim-notify#viewing-history

ah, thank you!


Add readme to all app's libs repositories

As a contributor I need to understand the scope of each lib used in the app.
Acceptance criteria:

Create a Readme.md draft in each lib repository describing what it does and its public methods.

https://github.com/tiki/app/blob/%23431-contributing/README.md


Added maximum TimeUnit to TimeSpanHumanizeExtensions.Humanize

Fixes #383
Added a parameter, TimeUnit maxUnit, to TimeSpanHumanizeExtensions.Humanize methods to prevent rolling up to the next largest unit of time.
For example, TimeSpan.FromDays(7).Humanize(maxUnit: TimeUnit.Day) outputs "7 days" instead of "1 week". The parameter is defaulted to TimeUnit.Week to preserve existing behavior.

Very well done. Thanks for the contribution.

This is now released to NuGet as v1.34.0. Thanks.


feat: yet another variant of actor class management syntax (combining features of two previous version)

Combines #3403 (placing secondary constructor in system submodule), but uses dedicated syntax (system) eto accesse.system`.
<exp_post> ++=
  '(' 'system' ')' <exp_nullary>

E.g.
await (system) Lib.Node(#upgrade n)(i);

(system) <exp> is just notation for (otherwise inexpressible)  <exp>.system and nests nicely with the dot notation and application.
(Missed the argument re-ordering of #3410 "(system (#upgrade) Lib.Node(i))" desired by @kentosugama but the desugaring here is much simpler and could be used for other functionality hidden in system modules (unlike #3410)).

superseded by #3386


Update kafka-avro-serializer, ... to 5.4.5

Updates

io.confluent:kafka-avro-serializer
io.confluent:monitoring-interceptors

from 5.4.4 to 5.4.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.confluent" } ]

labels: library-update, semver-patch

Superseded by #247.


Two issues in Chapter 11

Hi @ageron,
(1) To apply the dropout technique to the MNIST dataset, shall we set training to True in feed_dict (as in the 8th line of the 101th code block in https://github.com/ageron/handson-ml/blob/master/11_deep_learning.ipynb)?
(2) As you expected, tf.nn.selu() has already been included in the newest Tensorflow version, so probably there is no need to define a SELU function (as in the 28th code block) anymore.
Please find more information at: https://www.tensorflow.org/api_docs/python/tf/nn/selu

Thanks @andrewsun90 , I appreciate your feedback.
The book does say to set training=True when training (in the dropout section) but I somehow forgot to actually add this to the notebook, oops.  :/
Regarding SELU, I updated the comments to point to tf.nn.selu() (and tf.contrib.nn.alpha_dropout()), but I left the current use of a "home-made" selu() function just in case some users are still using a TF version < 1.4.  I'll eventually drop support for older TF versions.
Thanks again!


Can't build the project.

I can't build the project. I think it's caused by dependencies?
Build Log: https://pastebin.com/LNPt2ESS
@Elem8100

Copy from my disk. This definitely can build. mediafire.com/file/0mfaeqtjd4c88b0/MapleNecrocer.zip/file

谢谢大哥!!