Issue with supervisord "Unit supervisor.service entered failed state"

Hello, lovely tool you have here. Im trying to get it up and running on a debian install i get all the way to the supervisord part and the service just wont run.
Has anyone had this issue?
I cant get to the front page of the website.
`
-- Logs begin at Fri 2016-07-29 15:28:14 AEST, end at Fri 2016-07-29 15:31:35 AEST. --
Jul 29 15:31:21 netbox systemd[987]: Reached target Default.
-- Subject: Unit UNIT has finished start-up
-- Defined-By: systemd
-- Support: XXXX
-- Unit UNIT has finished starting up.
-- The start-up result is done.
Jul 29 15:31:21 netbox systemd[987]: Startup finished in 23ms.
-- Subject: System start-up is now complete
-- Defined-By: systemd
-- Support: XXXX
-- All system services necessary queued for starting at boot have been
-- successfully started. Note that this does not mean that the machine is
-- now idle as services might still be busy with completing start-up.
-- Kernel start-up required KERNEL_USEC microseconds.
-- Initial RAM disk start-up required INITRD_USEC microseconds.
-- Userspace start-up required 23094 microseconds.
Jul 29 15:31:27 netbox su[1001]: Successful su for root by user
Jul 29 15:31:27 netbox su[1001]: + /dev/pts/0 user:root
Jul 29 15:31:27 netbox su[1001]: pam_unix(su:session): session opened for user root by user(uid=1000)
Jul 29 15:31:35 netbox supervisor[1007]: Stopping supervisor: supervisord.
Jul 29 15:31:35 netbox supervisor[1011]: Starting supervisor:
Jul 29 15:31:35 netbox systemd[1]: supervisor.service: control process exited, code=exited status=1
Jul 29 15:31:35 netbox systemd[1]: Failed to start LSB: Start/stop supervisor.
-- Subject: Unit supervisor.service has failed
-- Defined-By: systemd
-- Support: XXXX
-- Unit supervisor.service has failed.
-- The result is failed.
Jul 29 15:31:35 netbox systemd[1]: Unit supervisor.service entered failed state.
`

i forced the service to stop and start again by using
/etc/init.d/supervisor force-stop && \ /etc/init.d/supervisor stop && \ /etc/init.d/supervisor start
but still cant get it to work, netbox works when i use the command
./manage.py runserver <IP_ADDRESS>:8000 --insecure
But thats no good for prod.

Disregard it was my bad, in the nginx setup i created "netbox" as netbox.conf

On my side, I chose to run the wsgi part with gunicorn + supervisord, and let nginx serve the static files.
Here's my supervisord config fragment:
[program:gunicorn_netbox]
directory=/opt/netbox/netbox
autostart=true
autorestart=true
stdout_logfile=/var/log/netbox.log
redirect_stderr=true
command=/home/netbox/.virtualenvs/netbox/bin/gunicorn netbox.wsgi:application
-w 4 --bind <IP_ADDRESS>:8000 --log-level=debug
user=netbox
group=nogroup
killasgroup=true
startsecs=5
stopwaitsecs=10
Hope it'll help.


Monorepo package dev dependency binary used in GitHub actions workflow reported as unlisted

Reproduction url
https://stackblitz.com/edit/github-e9sos1?file=packages%2Fclient%2Fpackage.json
Description of the issue
When the binary of a dev dependency of a package in a monorepo is used in a GitHub actions workflow (using yarn --cwd), the binary is reported as unlisted.
packages/client/package.json:
  "scripts": {
    "svelte-check": "svelte-check --workspace test"
  },
  "devDependencies": {
    "svelte-check": "^3.2.0"
  },

.github/workflows/node.yml:
      - name: Svelte Check
        run: yarn --cwd packages/client svelte-check
        shell: bash

Output:
❯ yarn knip
yarn run v1.22.19
$ knip
Unlisted binaries (1)
svelte-check  .github/workflows/node.yml
error Command failed with exit code 1.

For reference, I ran into this issue as part of https://github.com/statelyai/xstate/pull/4974. Planned workaround is to add .github/workflows/node.yml to ignore for now.
I would expect no error to be reported.

Not unfortunate, that's totally understandable! Do you think it'd be worth adding a note in the docs about this somewhere? I'd be happy to tackle that if so

Going to close with the release of v5.34.0

Thanks for everything you do @webpro ❤

Appreciate that!


takes longer to load app when cli is not aws authenticated

https://github.com/mrllama123/dyna-cli/assets/9062832/d9a3b13d-465d-4b4e-8087-845093cae143

with latest version of app i don't have this issue


Use iterable type hints

To allow the RoleInterface getChildren() and getParents() methods to return a traversable object as well as an array.
Anyone else interested in this? If so I can look at adding a test, not sure if its required though?

@internalsystemerror this is interesting. Can you provide a uni test for this new feature? Thanks!

@internalsystemerror actually a unit test is not needed, thanks to the Iterable Type Variance.

@internalsystemerror Thanks!

@ezimuel np, although i did nothing. i did check the php version that iterable types were supported. tx for the merge


explore full-text indexing in sqlite (fts3|4)

for search performance

moved to mysql, using fulltext indexing there.


Possible to apply multilingual within a bot?

Hello! Thanks for making chatterbot that helps my project a lot.
I am writing a bot that will link to various IM platforms. I want to let the users choose and set either English or Chinese in the future. I would like to know if it’s possible to apply 2 languages within a bot?
This is my very first project and my programming skill is not good. If my question is inappropriate here, please free to tell me and refer where I can ask.
Many thanks!

Hi @herboratory, I would recommend creating one bot per language as this may be simpler to implement with the current version of ChatterBot.

Note: A question similar to this recently came up (#1536) where the goal was to have a single chat bot for multiple types of users (as opposed to the multiple types of languages as described in this case). I am currently considering adding functionality to ChatterBot that would make it easier to implement the functionality that you are looking for.

OK! That would be great! Thank you so much for the reply! :)


Refactor CLI to use npm and yarn instead of third party packages

Issue: #3274 and #3060
What I did

yarn remove latest-version on the lib/cli folder
Created a new file lib/cli/lib/latest_version.js and used the has_yarn.js to check if yarn is actually available.
yarn test on root folder.

How to test
Is this testable with jest or storyshots?
I didn't touched on tests, seems that tests are already written.
Does this need a new example in the kitchen sink apps?
No.
Does this need an update to the documentation?
No.
@danielduan you're the man to contact, so can you review if everything is fine here? If not, please let me know and I am going to fix it.

@Hypnosphi this is the only obvious thing that I think could cause the linked issue. You worked with the CLI quite a bit. Does this look good?

The passing CLI tests are an extremely good sign

@Hypnosphi it's just to be safe. Because I read
https ://github.com/yarnpkg/yarn/issues/4044, and it's under investigation

@felipedeboni output without version is different in the same way:
$ yarn info @storybook/react --json
{"type":"inspect","data":{...

$ npm info @storybook/react --json
{
  "name": "@storybook/react",...

@Hypnosphi, you're right. Going to open another pull request, to actually fix NPM and also change that behavior.
Do you want to check the code first? Commit

https://github.com/storybooks/storybook/pull/3297 should already have fixed this


About the trained CMFlow (T) model trained with extra unannotated data

Hi, can you provide the training details of the trained CMFlow (T) model trained with extra unannotated data? or provide the training command in readme? Thank you very much.

Hi, unfortunately, the extra part of unannotated data is currently unavailable. You may need to contact the VoD authors for it. Training with extra unannotated data is similar to our "regular" ones. You only need to add preprocessed samples to your data path.


Table row alignment

In general text should be left aligned and data measurements (like time) should be right aligned for readability and reducing user processing.

closed by #19


depend: Update crossbeam-utils to "0.8.9" instead of "=0.8.9"

Because it require Lazy for static (essentially global variable) and after 0.8.9, crossbeam-utils 's AtomicCell can't be use in static anymore, so refactor to wrap them in a Lazy

This is adding a overhead for each visit witch is not neccesasy.
Is crossbeam denied to use AtomicCell with static by reason? should we create a pr to crossbeam?

This is adding a overhead for each visit witch is not neccesasy. Is crossbeam denied to use AtomicCell with static by reason? should we create a pr to crossbeam?

According to their comment(https://docs.rs/crossbeam-utils/0.8.10/src/crossbeam_utils/atomic/atomic_cell.rs.html#33-47)  in 0.8.10 of crossbeam-utils, yes it seems to have a reason
    /// Using MaybeUninit to prevent code outside the cell from observing partially initialized state:
    /// <https://github.com/crossbeam-rs/crossbeam/issues/833>

They add a MaybeUninit starting after 0.8.9, this is link to 0.8.9 for comparsion:
https://docs.rs/crossbeam-utils/0.8.9/src/crossbeam_utils/atomic/atomic_cell.rs.html#33-40

Ok I see, due to MaybeUninit now crossbeam::AtomicCell has to implement Drop.
Can you create a RFC so we can optimize it in the future?

https://docs.rs/crossbeam-utils/0.8.10/src/crossbeam_utils/atomic/atomic_cell.rs.html#33-47

How about this RFC?
https://github.com/RustPython/RustPython/issues/4295


Log Event

Removing options.log and adding events.log. This also provides simple support for filter, format, and sameStateWarning from #2.

@okwolf Can we introduce prettier in this codebase? Just as we are using it in hyperapp.

@JorgeBucaran I actually did run Prettier, but not using the same flags as Hyperapp. I pushed an update now.

Closing since events are old and busted now. Make way for the new hotness: hooks.


Test enhancement

Changed log

Add more tests.
Set the correct command for composer and phpunit.
Add the autoload-dev to load the related test classes automatically.
Set the current assertion API to assert the different expected and result values.

Coverage increased (+4.8%) to 81.864% when pulling 1ef9f65c340c5dc295097937f3d03a7ac672fcdf on peter279k:test_enhancement into 65b2efa612bc8250cbe0e1749c7d77176bd0c3c5 on calgamo:master.


Remove* errors are ignored

(Apologies, I'd make a PR to fix it, but I'm in the middle of something else right now)
Each of RemoveAuthorize, RemoveAccess and RemoveRefresh are defined to return an error, but the error is ignored in server.FinishAccessRequest

The question is what the correct error handling would be. As far as I can see all three Remove* calls happen in Server.FinishAccessRequest after the new access token was created. The new token can be used and the user may not actually care about the failed cleanup operations.
However at the very least the error should simply be logged by osin. When implementing the Remove* functions as developer it is reasonable to assume that if I have to return an error, then it is actually handled somehow up the call stack, so I would not normally log the error myself. In the current state those errors just disapear.

osin should be concerned with logging. I agree that it is reasonable to expect the error to be handled somehow by osin. I don't see a good way to do so, so in my opinion the solution is to remove the return value from the interface. That forces implementations to deal with errors. @RangelReale will have to decide if a BC break is acceptable.

Server could have an error handler that would allow customizing what is done with the errors. It could log by default

My comment above had an unfortunate typo. I updated it accordingly. To clarify: OSIN is a library. It should not impose its opinions about logging on its users. Users of that library should decide if and how to do logging.

I was also considering removing the return value from the interface and
would prefer that very much.
Initially I was thinking this wouldn't work for to the BC break but
actually there are BC breaks listed at the top of the current change list
so hopefully this is an option :)
Peter Schultz<EMAIL_ADDRESS>schrieb am Fr., 18. Nov. 2016,
17:52:

My comment above had an unfortunate typo. I updated it accordingly. To
clarify: OSIN is a library. It should not impose its opinions about logging
on its users. Users of that library should decide if and how to do logging.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RangelReale/osin/issues/135#issuecomment-261581446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsvTDPeXz0b4qZ9itYKR6xb5AZiZ69eks5q_dexgaJpZM4Kn5qm
.

the information is useful, don't remove it from the interface. If anything, I'd prefer a hook in server to decide what to do with non-fatal errors like that

The disadvantage I see in a hook is that there is no useful default
implementation and it is very easy to forget to implement a custom one.
Many users will probably not even be aware of it because tl;dr.
A missing return value on the other hand forces the implementing developer
to think about how to handle the error. The interface documentation should
assist at this point with some useful advice.
Jordan Liggitt<EMAIL_ADDRESS>schrieb am Fr., 18. Nov. 2016,
18:04:

the information is useful, don't remove it from the interface. If
anything, I'd prefer a hook in server to decide what to do with non-fatal
errors like that
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RangelReale/osin/issues/135#issuecomment-261584747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsvTGGHZNm4piGBvCsj2INo1jREYxORks5q_dqSgaJpZM4Kn5qm
.


vcpkg bootstrap failed on FreeBSD 13

Describe the bug
Failed to bootstrap on FreeBSD, when building CXX object files.
Environment

OS: FreeBSD 13.1
Compiler: clang 13

To Reproduce
Steps to reproduce the behavior:

./bootstrap-vcpkg.sh

Expected behavior
Building of vcpkg complete and successful
Failure logs
FAILED: CMakeFiles/vcpkg-test.dir/src/vcpkg-test/argument.cpp.o
...
...
...
error: POSIX thread support was enabled in PCH file but is currently disabled

Additional context
I'm running on bare metal FreeBSD

Duplicate of https://github.com/microsoft/vcpkg/issues/30863. It is fixed on main but not released yet.

Fixed by https://github.com/microsoft/vcpkg-tool/pull/1025.


Pre render send cookies

Hi just wondering if there is a way to send the cookie
during SSR. i notice that in the first run all cookies and identities are empty
is there a way to specify the cookie in this method
        var prerenderResult = await Prerenderer.RenderToString(
            "/",
            nodeServices,
            new JavaScriptModuleExport(applicationBasePath + "/ClientApp/dist/boot-server"),
            unencodedAbsoluteUrl,
            unencodedPathAndQuery,
            transferData,
            30000
        );

@SteveSandersonMS , @laskoviymishka  please help i just want to send my cookie browser during SSR thanks for helping

I think you can unpack the cookie data and pass it in transferData. It arrives in boot-server in params.data

Yes, @Maarten88 is correct. The docs at https://github.com/aspnet/JavaScriptServices/tree/dev/src/Microsoft.AspNetCore.SpaServices under Passing data from .NET code into JavaScript code give a specific example of passing cookies to the boot-server.ts file. From there, it's up to you to pass it to the rest of your app in whatever way you want, using the APIs provided by your chosen SPA framework, and from there you can include it in your fetch requests if you want.


Allow "rt" mode for open_resource

fixes #3163
Note that @davidism has also recommended re-architecting this helper, David, do you want to own opening the new issue to track that?

Hey, I didn't realize this at the time, but someone else also submitted PR #3174 for this. Since they added tests as well, I'm going to use theirs. Thanks for prompting the discussion with me and working at the sprints, it was helpful!

@davidism yeah, I saw that PR after I had submitted mine, so happy to defer the merge to tested code. Hopefully next year I'll be more fully productive 💯


The performances of ISP-ResNet50.

Hi, can you provide the performances of ISP-ResNet50 on Market1501, DukeMTMC, Occluded-Duke, and CUHK03-NP?
Thank you very much. I plan to compare our method with ISP-ResNet50.

Sorry, but I have to say ISP is more suitable to backbones with larger feature maps. The performance of ISP on ResNet50 is not that good as the size of its output feature maps is small.

Sorry, but I have to say ISP is more suitable to backbones with larger feature maps. The performance of ISP on ResNet50 is not that good as the size of its output feature maps is small.

I observe from Table. 6, the performance of ISP-ResNet50 is comparable to that of ISP-HRNet-W32.


Py3

Tests pass, looks like the only real issue was map being a generator in Py2.

Cool! Can you update the travis config to run Py3 tests?

I modified the tox.ini file, will that suffice? :)

Derp, I clearly don't grok travis yet.

@redapple No. It's not ideal, though, because it means you can't run multiple version checks with one invocation of tox. The way I had it at first, running tox would check both versions at once. But that didn't play well with Travis.
To test locally now, you'd do python{x} -m tox to test Python x.

In other projects, we've been using TOXENV in the matrix in Travis and it's been working well.
And local tests still use tox -e py27,py35 for example.
See https://github.com/scrapinghub/extruct/blob/master/.travis.yml for example


Plugins crash with "Methods marked with @UiThread must be executed on the main thread."

There are multiple plugins that are breaking with the error message Methods marked with @UiThread must be executed on the main thread.. (See issues: https://github.com/flutter/flutter/issues?utf8=✓&q=\%40UiThread).
I didn't find any release notes, or guides for plugin authors to handle this issue (and to be honest, I don't 100% understand when it's necessary). Do you have any plans on updating the docs?
This issue is more like a question, or docs/release notes improvement request, and the examples below could serve for people who face the same issues. Also, I'm on dev channel, so maybe the issue (docs, release notes) can be fixed before you release to stable.
Crash
E/AndroidRuntime(31031): FATAL EXCEPTION: Thread-16
E/AndroidRuntime(31031): Process: com.smaho.mobile_app, PID: 31031
E/AndroidRuntime(31031): java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: Thread-16
E/AndroidRuntime(31031): 	at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:605)
E/AndroidRuntime(31031): 	at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:515)
E/AndroidRuntime(31031): 	at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:76)
E/AndroidRuntime(31031): 	at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:151)
E/AndroidRuntime(31031): 	at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:144)
E/AndroidRuntime(31031): 	at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler$EventSinkImplementation.success(EventChannel.java:226)

Versions
$ flutter --version
Flutter 1.7.3 • channel dev • https://github.com/flutter/flutter.git
Framework • revision 362b999b90 (2 weeks ago) • 2019-06-07 12:43:27 -0700
Engine • revision 0602dbb275
Tools • Dart 2.3.2 (build 2.3.2-dev.0.1 6e0d978505)

How to solve to issue
I found some fixes already in the wild, so I just had to tweak the MethodChannel.Result solutions to be able to fix the EventSink issues.
The issues + solutions I found are here:

https://github.com/aloisdeniel/flutter_geocoder/pull/15/commits/bc34cfe473bfd1934fe098bb7053248b75200241
https://github.com/flutter/plugins/commit/c1530334f9c8aec9d7a63f86dd824eeaa37d7523

The code examples in this issue use Java and prefer clarity over lines of code. If you use Kotlin, a less verbose option might be possible.
They solved it by wrapping the MethodChannel.Result result with a "handler+looper+runnable combo":
 private static class MainThreadResult implements MethodChannel.Result {
    private MethodChannel.Result result;
    private Handler handler;

    MainThreadResult(MethodChannel.Result result) {
      this.result = result;
      handler = new Handler(Looper.getMainLooper());
    }

    @Override
    public void success(final Object result) {
      handler.post(
          new Runnable() {
            @Override
            public void run() {
              result.success(result);
            }
          });
    }

    @Override
    public void error(
        final String errorCode, final String errorMessage, final Object errorDetails) {
      handler.post(
          new Runnable() {
            @Override
            public void run() {
              result.error(errorCode, errorMessage, errorDetails);
            }
          });
    }

    @Override
    public void notImplemented() {
      handler.post(
          new Runnable() {
            @Override
            public void run() {
              result.notImplemented();
            }
          });
    }
  }

I was working with an EventChannel.EventSink eventSink, so I had to patch my plugin, too. The solution for the event sink was similar:
private static class MainThreadEventSink implements EventChannel.EventSink {
    private EventChannel.EventSink eventSink;
    private Handler handler;

    MainThreadEventSink(EventChannel.EventSink eventSink) {
      this.eventSink = eventSink;
      handler = new Handler(Looper.getMainLooper());
    }

    @Override
    public void success(final Object o) {
      handler.post(new Runnable() {
        @Override
        public void run() {
          eventSink.success(o);
        }
      });
    }

    @Override
    public void error(final String s, final String s1, final Object o) {
      handler.post(new Runnable() {
        @Override
        public void run() {
          eventSink.error(s, s1, o);
        }
      });
    }
}

Use activity.runOnUiThread

And do you know why it changed, why did it work before?

https://github.com/flutter/engine/commit/2c9e37c34e79475bbde7c8163eb5e56cdb9662a1

Thanks @ymback, the messages in https://github.com/flutter/engine/pull/8830 really helped understanding the context.

Thanks for this.  This change also broke at least one of the flutter team's own plugins (android_alarm_manager), and probably would have been immensely frustrating to figure out how to handle on my own.

rxJava devs may find the familiar
'.[subscribe/observe]On(Schedulers.from(new HandlerExecutor(Looper.getMainLooper())))`
to be helpful here.

I have to keep running some code in my plugin in a separate thread for UI not to block, but when I try to run the code, I get Methods marked with @UiThread must be executed on the main thread.
How do I fix this?

Experiencing same.. Downgrading flutter until it's fixed.

Wow @ymback, nice link; missed it the first time. @Sitiritis and @MichaelReed would likely appreciate the insight in the comments. tl;dr this change will not be reverted; it is protecting against indeterminant code that was likely crashing silently.

@AndruByrne, I don't quite get to use this insight. I am creating a thread in the Android plugin and then start it. What should I chage?

@AndruByrne, could you help me understand how I can use an isolate with UIThread execution? From my basic understanding of them, I cannot (which probably explains why the alarm manager plugin is broken as well).

I am using rxJava  and here my solution
.subscribeOn(Schedulers.newThread())
.observeOn(AndroidSchedulers.mainThread())
https://github.com/amorenew/ACS_NFC_Flutter/blob/master/android/src/main/java/com/acs/nfc/acs_nfc/AcsNfcPlugin.java

First one from @vargavince91 works like a charm, but I did slightly shorter.
Same approach, but I don't want to use it everywhere.
public class BitcoinWalletPlugin implements MethodCallHandler, ... {

  private Handler uiThreadHandler = new Handler(Looper.getMainLooper());

  @Override
  public void onListen(Object o, EventChannel.EventSink eventSink) {
    switch (this.channel) {
      ...
      case CHANNEL_NAME:
        // before
        // bitcoinWallet.setOnStartupListener(() -> eventSink.success(true));

        // after
        bitcoinWallet.setOnStartupListener(() -> uiThreadHandler.post(() -> eventSink.success(true)));
        break;
    }
  }

}

@Sitiritis

I have to keep running some code in my plugin in a separate thread for UI not to block, but when I try to run the code, I get Methods marked with @UiThread must be executed on the main thread.
How do I fix this?

Make sure you are creating handler like that new Handler(Looper.getMainLooper());
Looper.getMainLooper() is the main point which make it works in UI thread
@MichealReed

@AndruByrne, could you help me understand how I can use an isolate with UIThread execution? From my basic understanding of them, I cannot (which probably explains why the alarm manager plugin is broken as well).

You don't need isolate here, just use new Handler(Looper.getMainLooper()); as first option OR save link to activity from here, and then use activity.runOnUiThread(..) everywhere as a second option
public static void registerWith(Registrar registrar) {

  activity = registrar.activity();

}

@pavel-ismailov I'm using isolates to do work in a background thread. I cannot do execution on the UI thread as UI is a foreground process.

@MichealReed
Not sure if I understood you right, but looks like your schema is:

You go to background in Flutter (isolate)
From that thread you are calling native host
Native host do some work (maybe in own background)
Native host return it back to Flutter
As you were in background in Flutter, you wondering what the heck you need make calls events.success(result) in UI thread, because you want return result to your previous background thread (isolate)

If so - answer is I don't know, why, but you MUST do it, because if you will check that flutter source code
    private final class EventSinkImplementation implements EventChannel.EventSink {
      final AtomicBoolean hasEnded;

      private EventSinkImplementation() {
        this.hasEnded = new AtomicBoolean(false);
      }

      @UiThread
      public void success(Object event) {
        if (!this.hasEnded.get() && IncomingStreamRequestHandler.this.activeSink.get() == this) {
          EventChannel.this.messenger.send(EventChannel.this.name, EventChannel.this.codec.encodeSuccessEnvelope(event));
        }
      }

      @UiThread
      public void error(String errorCode, String errorMessage, Object errorDetails) {
        if (!this.hasEnded.get() && IncomingStreamRequestHandler.this.activeSink.get() == this) {
          EventChannel.this.messenger.send(EventChannel.this.name, EventChannel.this.codec.encodeErrorEnvelope(errorCode, errorMessage, errorDetails));
        }
      }

      @UiThread
      public void endOfStream() {
        if (!this.hasEnded.getAndSet(true) && IncomingStreamRequestHandler.this.activeSink.get() == this) {
          EventChannel.this.messenger.send(EventChannel.this.name, (ByteBuffer)null);
        }
      }
    }

You will see @UiThread annotations which force you call that methods only in UI thread.
Maybe you don't need isolates in Flutter code? Try to avoid it and only go background on native host.

I tried to implement a number of solutions from a number of threads but all show me some or the other error.
I tried both @vargavince91 and @pavel-ismailov 's methods but both give me the error that 'private' isn't a type and on removing/replacing 'private' I get 'Handler' isn't a type
I have been trying to build a music player and the plugin crashes when I play the music with Methods marked with @UiThread must be executed on the main thread.
Can anyone help me with the direction I should take. Is it a problem in the plugin's dart file or some problem in flutter itself?
If the plugin's code can help I will update the with the code.
Any assistance is appreciated

@pavel-ismailov I really feel that this is a huge oversight from the flutter development team, as mentioned before, they even broke their own example application for developing background services with flutter.
@matthew-carroll it would be great if you could chime in with some background as to why this change was made and if it will be reversed or fixed any time soon. Someone previously linked this commit https://github.com/flutter/engine/commit/2c9e37c34e79475bbde7c8163eb5e56cdb9662a1.

@matthew-carroll it would be great if you could chime in with some background as to why this change was made and if it will be reversed or fixed any time soon. Someone previously linked this commit flutter/engine@2c9e37c.

The reason that this change was made was because the engine always required that these plugin messages be sent on the main thread, but as is now apparent, few if any developers were invoking plugin method channel messages on the UI thread. This was always an error as per the engine's source code documentation, so we introduced an explicit requirement in java code. Invocations of these channels on a non-UI thread creates race conditions, which would be immensely more difficult to locate than the new guard.
As for how to handle this requirement, the post to the UI thread in the linked example from the original post looks reasonable:
https://github.com/flutter/plugins/commit/c1530334f9c8aec9d7a63f86dd824eeaa37d7523
I'm sure there are various ways to slightly reduce the code verbosity, but as long as the messages are sent from the UI thread, everything should be OK.
With regard to documenting this, what doc location would make the most sense for those of you on this thread? Where would you have expected to find this information?
With regard to reversing this change, I'm not aware of any intention to do so. As for getting it "fixed", I'm not sure which aspect you believe is broken. The threading requirement has always existed and it is not currently viewed as a bug.
We will aim to do better in the future when it comes to documenting and informing Flutter users of such changes. We certainly could have done better with this one. But we believe this guard needs to be in place to prevent flaky plugin behavior that would be difficult or impossible to root cause.

@matthew-carroll  I came to this thread to try to fix a issue with a plugin of yours. I'm constantly getting error while playing music with Fluttery_Audio, I see there is a similar issue here can you explain a relevant solution with respect to the same

@matthew-carroll what is the recommendation for those of us using isolates? I would love to see documentation regarding the new approach. I have a background process that I need to continuously run, so messages need to be sent regardless of the UI thread state. The android alarm manager uses isolates and was also broken by this change -- see https://github.com/flutter/flutter/issues/36059.
There are other challenges with isolates and flutter that prevent workarounds too -- see
https://github.com/flutter/flutter/issues/13937#issuecomment-520535822 (isolates are important)
From my searches, it seems many plugins broke from this change. More and more people seem to be popping up in this thread and I would assume it will accelerate as people upgrade their applications.
I would recommend:

An announcement in the google group for the breaking change with a migration path for all use cases outlined in this post.
A stack overflow post informing users of the new approach needed.
An effort from owners of first-party plugins to implement the new approach.

@Purukitto unfortunately, I have been unable to maintain the fluttery_audio plugin for some time. If you fork the repo then you should be able to solve the problem in that error log by posting responses back to the UI thread, as discussed in this thread previously.
@MichealReed I'll see what I can do about getting some docs prioritized.
CC @amirh for plugin fix priorities

@matthew-carroll thank you for the quick support. I am using https://github.com/rmawatson/flutter_isolate/blob/master/android/src/main/java/com/rmawatson/flutterisolate/FlutterIsolatePlugin.java#L125 and from my understanding there is an issue using activities within isolates and you cannot use context on the UIThread. Is this correct?

@matthew-carroll is there a specific plugin in flutter/plugins you're aware is still crashing with this? I believe all plugins that had this issue have been fixed.

@MichealReed unfortunately, I don't have context around the linked file, but I'm not aware of any issue with using method channels with background isolates. The UI thread is an Android concept rather than a Flutter/Dart concept, so you manage it from the Android side. If you place your messaging code within Runnables that post to Android's UI thread, I think you should be fine. If you have a specific minimal code reproduction of an issue in that area, I would recommend filing a new bug and including the specific, minimal steps that we can take on our end to replicate the issue.
With regard to Activitys, that's a complicated issue that would be very difficult to answer in general. The idea of "using activities within isolates" sounds fishy because an Activity is something that exists in Android and an isolate is something that exists in Dart, so I'm not quite sure what really means. Can you elaborate?
@amirh No, I'm not aware of any further plugin issues. I tagged you because some earlier posts on this thread seemed to indicate continuing crashes, but if all the plugins have been fixed then I assume we're good.

@matthew-carroll I will see if the maintainer of that repository can assist with a minimal code reproduction to open a new issue with. To elaborate, he found a work around using context that allowed him to wrap management of the isolates. Prior to this change, use of context was allowed, but from my basic understanding of android development, context does not provide functionality to run on the UI thread.

@MichealReed please see this guide, you should be able to run code on the UI thread from anywhere:
https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading

I have updated my flutter version, and issue got resolved.
Following is my flutter version details:
Flutter 1.7.8+hotfix.4 • channel stable • https://github.com/flutter/flutter.git Framework • revision 20e59316b8 (4 weeks ago) • 2019-07-18 20:04:33 -0700 Engine • revision fee001c93f Tools • Dart 2.4.0

I'm going to mark this issue as closed. At this point:

We have explained that this annotation is not a new restriction, but an explicit mark of an existing restriction.
Developers can read about this restriction and how to deal with it here: https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading
Flutter's 1P plugins have been updated to handle this threading constraint

If there is more work to be done on this particular issue, feel free to re-open.
If similar, but distinct problems appear, please file new issues.

Shameless plug: flutter-plugin-scaffold will protect you from this error (using the fix in OP), and other quirks when writing flutter plugins.

I'm going to mark this issue as closed. Presently:

An explanation has been provided that this annotation is not a new restriction, but an explicit mark of an existing restriction.
Developers can read about this restriction and how to deal with it here: https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading
Flutter's 1P plugins have been updated to handle this threading constraint

If there is more work to be done on this particular issue, feel free to re-open.
If similar, but distinct problems appear, please file new issues.

I'm going to mark this issue as closed. Presently:

An explanation has been provided that this annotation is not a new restriction, but an explicit mark of an existing restriction.
Developers can read about this restriction and how to deal with it here: https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading
Flutter's 1P plugins have been updated to handle this threading constraint

If there is more work to be done on this particular issue, feel free to re-open.
If similar, but distinct problems appear, please file new issues.

@matthew-carroll
I have a bluetooth button hooked up to my flutter application using an Isolate. Before this restriction it used to work fine when the phone screen was off. After this restriction was enforced the bluetooth button press started crashing the application. So I implemented the recommended method to switch to UI thread in the isolate to handle the button press. It fixed the crash but now the button presses don't work when the screen is off. Is there another work around that you can think of? This is major issue for our application. The button needs to work when the phone is in users pocket with the screen off.

@vikramkapoor it depends why the button isn't working. The UI thread still exists and still executes even when the screen is off, so long as your app is still running. In general the issue you're describing is probably about Android background execution more than it is about Flutter. Are you running a Service to keep your app alive? Have you verified that your app is receiving the Bluetooth signal before it tries to send that signal to Flutter?

@matthew-carroll thank you for that answer as it makes me wonder why I moved bluetooth to background isolate in the first place if the UI thread executes when the screen is off. I have moved the bluetooth implementation back to the UI thread and it still works with the screen off. Flutter_blue plug-in that I am using doesn't seem to be running a service for Android background execution.

这个解决方法很优雅，但是我觉得这个问题flutter框架该解决一下。

Solution:
wrap the method invocation in
runOnUiThread(() -> {
result.success(identifier);
});

Solution:
wrap the method invocation in
runOnUiThread(() -> {
result.success(identifier);
});

worked for me thanx


Update Russian translation

Please also consider adding support for grammatical numbers. For example, in Russian there are 3 forms of word "файл" (file), we say "1 файл", "2 файла" (from 2 to 4), "5 файлов" (from 5 to 9 and 0), "21 файл" (same thing with the last digit), "22 файла", "25 файлов". So the form of a word depends on the number before it a bit more than just one or multiple as it is in English.
As for now I covered only 2 of 3 forms using brackets.

Thanks for the PR! Regarding grammatical numbers - it would add a lot of complexity since not every language follows the same standard (Swedish has only two forms). I'll see if I can figure something out, but I don't see it happening in the near future, sorry.


Deferred rendering, alpha blending, and more

I need to study how to do lightings with deferred shading here.


MultiException when log-directory does not exist

The application is left in an illegal state when the log-directory does not exist.

FIxed by mentioned merge


add basic collision handling in animatedsprite

This implements the basic attributes required for handling mask/rectangle collision for animated sprites. I'll have to write some tests soon.
One thing I'm thinking about is how I wanna define the alpha for the mask (the alpha transparency threshold sets what's counted as solid or not, for pixel-perfect collision). As in, anchors are loaded from an anchor file, but where does that alpha transparency setting/config come from? The aforementioned config aspect wasn't implemented yet because I'm still thinking about how I want to do that. Tests will follow in some commits.

Coverage decreased (-1.6%) to 85.625% when pulling fa51c5cb86cf283131f8fe70fdc71c7ef090cbb1 on animatedsprite-collision into 79d8b54dfdac7b87d3ba61292e9479be52c15447 on master.


with tls set up setup.sh is failing

setup.sh was working fine. I have tear down and set up  vault many  times.,
Now I set up tls for vault and kubernetes-vault yaml file.
I started getting
Waiting for port forwarding to start
appending output to nohup.out
Error validating token: Error making API request.
URL: GET http://<IP_ADDRESS>:8200/v1/auth/token/lookup-self
Code: 403. Errors:

permission denied
Mount error: Error making API request.

URL: POST http://<IP_ADDRESS>:8200/v1/sys/mounts/root-ca
Code: 403. Errors:

permission denied
Error writing data to root-ca/root/generate/internal: Error making API request.

The setup.sh fils is only suitable for running the quick start (which sets up vault over https). You will need to modify the setup.sh file if you want to use https and other customizations.

i fix most of the issues.  Lat  issue i  see  kubernets-vault pods is crashing..
I am getting this error
time="2017-11-03T15:21:06Z" level=debug msg="Discovered 0 nodes: []"
time="2017-11-03T15:21:06Z" level=fatal msg="Could not create the vault client: could not get vault root CAs: could not read CA certificates from the file vault.pem: open vault.pem: no such file or directory"
I can setting up
vault:
addr: http://vault:8200
token: 91526d9b-4850-3405-02a8-aa29e74e17a5
tls:
caCert: vault.pem
My feeling you  are also  expecting volumeMounts for this file.

From the error, it looks like you are pointing the kubernetes-vault controller to the vault.pem CA certificate, but it does not exist. In your case, you need to mount the vault.pem CA file into the pod so that kubernetes-vault can read it.


Blazor Startup - sample environment variable name

I think demonstrating how to pass environment variables using a variable named CONFIGURE_RUNTIME in the section titled Configure the .NET WebAssembly runtime can be confusing. An inexperienced user might be puzzled about whether using CONFIGURE_RUNTIME = true activates something that allows configuring the .NET WebAssembly runtime.
cc @guardrex

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/fundamentals/startup.md
ASP.NET Core Blazor startup

WOE! We need to hold the horses 🐴🐴🐴 ... this isn't just a name ... it's a real env var for configuring the WASM runtime.
https://github.com/search?q=repo%3Adotnet%2Faspnetcore CONFIGURE_RUNTIME&type=code
I'll open an issue to follow-up with additional guidance on what it does.

@guardrex  I think you've been caught up in the confusion of that name, and even in the test project, it's used only as a test variable (the framework doesn't interact with it in any way):
https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/testassets/BasicTestApp/ConfigureRuntime.razor#L5
😇

(It seems the code snippet in the docs was just copy-pasted from the TestApp and the "not so ideal name for test environment variable" initiated there.)

BTW, I like the placeholders-style for code examples, I just didn't think of it when I was proposing this PR. 😇

I put the placeholders together and try a NOTE on Blazor.runtime to set it aside from the main concept, including an example type for the build config.

I think the reason that the PU named it that way is that they're highlighting in the name that it's an env var specifically used to configure something about the runtime. However, I totally see what you mean and agree that someone ....cough cough 🦖 cough ....... will misunderstand that the dev would then go on to use it somehow in their own custom code. Another way to handle this is to explain it out. However, I don't think it's very important. This is, after all, an advanced scenario for advanced devs.

I think we better have Mackinnon look at this. In addition to any foul description 💩  that might be present, I'd like to be able to tell readers about any typical use cases, even if it's only mentioned in text and not with a code example. Before I do that, I'll go check the PU repo issues, including on the runtime repo, to see if the team told any devs do this to solve such-and-such goal.

This one is kind'a interesting ... idk where it logs ... console I suppose ...
dotnet.withEnvironmentVariable("MONO_LOG_LEVEL", "debug");

Hidden gems... 😁
https://github.com/dotnet/runtime/blob/339443b0408f45503380558aa2cf2a9ecc2cbaa9/src/mono/browser/test-main.js#L274-L277
    // dotnet.withEnvironmentVariable("MONO_LOG_LEVEL", "debug")
    // dotnet.withEnvironmentVariable("MONO_LOG_MASK", "gc")
    // dotnet.withEnvironmentVariable("MONO_GC_DEBUG", "9")
    // dotnet.withEnvironmentVariable("DOTNET_DebugWriteToStdErr", "1")

https://github.com/search?q=dotnet.withEnvironmentVariable&type=code

It would be incredibly helpful to cross-link an article which describes all possible environment variables affecting runtime. These variables will vary between Mono and CoreCLR, but unfortunately, it seems like such a list doesn't exist yet.

Yes ... and that doesn't surprise me. Over the years, a few readers have asked them for documentation on design and configuration of the runtime. If they do have anything, it will be in markdown files on their repo. Searching for MONO_, which should turn up any such markdown content, one sees that they haven't published anything yet.

Ok ... I think that's good. I'll ping Mackinnon now for an 👁.

No list or documentation describing all of the runtime environment variables exists at this time.
Should we explicitly acknowledge this in the documentation? Personally, I'd lean towards just letting it be... 😇

Yeah, I guess that is upsetting the way I blatantly attacked them like that 😆.
The best thing for me to do is open an issue asking them if they'll create a simple markdown file with the environment vars. If they accept the issue, then I can cross-link the issue.
... and that's a lot better for heading off a stale remark. It's easier to spot that they've worked the issue via one of my long-range tracking issues that monitors such things.
I'll take care of this shortly. I've gotten myself buried ⛰⛏😅 in something else at the moment.

I opened https://github.com/dotnet/runtime/issues/98225 to ask about placing a list with descriptions in the dotnet/runtime docs or giving the content to me for publication.

/cc @maraf @akoeplinger

@maraf @akoeplinger ... When you reach this for a look 👀, a basic question is if we want to carry this coverage here at all. AFAICT, this is of no general use to the typical LOB Blazor dev, and I wonder if it would be better to reduce it down to a single cross-link to a markdown file document in the dotnet/runtime repo, where it's probably more relevant for advanced devs working on advanced scenarios. Either I or someone else can create the markdown file (or add it to an existing file).
Conversely, we can continue to keep this coverage here. However, it seems like it should have links to resources on the env vars that can be set for the runtime that make sense to tell readers about. That's why I asked on the dotnet/runtime issue if the env vars are documented. Thus far we have ...

MONO_* env vars: https://github.com/mono/mono/blob/main/man/mono.1
DOTNET_*/COMPlus_* env vars: https://github.com/dotnet/runtime/blob/f582c0b66b2b91b626ccce62ea0e37496446e79f/src/coreclr/inc/clrconfigvalues.h

... and I can add those cross-links to this if it's decided that this coverage should remain here and if you agree that the links should be added to the coverage.

NOTE TO SELF ... If we keep this and per @lambdageek's remark, add a bit on ...

... there are also other uses. for example if an app is built with a NativeFileReference in order to include some C library, the environment variable setting could be used to affect the behavior of that C library.

@maraf @akoeplinger ... When you reach this for a look 👀, a basic question is if we want to carry this coverage here at all. AFAICT, this is of no general use to the typical LOB Blazor dev, and I wonder if it would be better to reduce it down to a single cross-link to a markdown file document in the dotnet/runtime repo, where it's probably more relevant for advanced devs working on advanced scenarios. Either I or someone else can create the markdown file (or add it to an existing file).

We can remove the concrete sample for setting environment variable, but the general idea that this is the way how to configure runtime and how to use export runtime API (use API of dotnet.d.ts) is something I think should be here. Because how to get to those API is specific for Blazor.
The example with setting envvar was more about that you can set any env var and then read it in .NET. Maybe the name CONFIGURE_RUNTIME which I originally used in Blazor unit test is missleading

We can remove the concrete sample for setting environment variable

Maybe the name CONFIGURE_RUNTIME which I originally used in Blazor unit test is missleading.

Since we've generalized it with placeholders, I think we should go ahead with this PR.
I'll be back shortly to add @lambdageek's remark ...

there are also other uses. for example if an app is built with a NativeFileReference in order to include some C library, the environment variable setting could be used to affect the behavior of that C library.

... and then if Mackinnon is happy 😄 we can proceed and merge this. I'll open a tracking item for myself over here to keep an 👁 on that dotnet/runtime issue for a future update if action is taken on that issue.

MONO_* env vars<EMAIL_ADDRESS>

The man/mono.1 is for the old mono executable that shipped standalone, unfortunately we don't have a better place which documents the environment variables, ideally they'd be in some markdown doc.

@MackinnonBuck ... I think we're good here. I'm going to go ahead with this. If you have a concern, I can issue a patch PR.


Currency-converter added

this is a currency converter using html, css and javascript

@davejane25 Hey created the pull request though I was not assigned for it.


how use filters

"export 'filters' was not found in 'vue-function-api';
how use filters api in vue-function-api

There isn't a new api for filters, they are still placed inside the component options are used in the template as usual. As filters are generic utility functions, it's not worth adding an API to support them in the setup function


Fix audio decode error due to passing spread argument instead of buffer

Hi there. First time Baileys user here.
As per the README file, I followed the instructions and tried to compile the project using yarn, however, I encountered an error when compiling:
src/Utils/messages-media.ts:212:106 - error TS2556: A spread argument must either have a tuple type or be passed to a rest parameter.

Delving deeper into the code, I found out that the audioDecode function actually accepts only one buffer parameter, instead of all parameter values.

Therefore, this fix changes the passing of ...args to pass only the buffer instead.
After fixing that, I was able to compile and use Baileys. Have also tested it by trying to send myself an audio file.

Screenshots of errors and compilation attached.

I suggest defining a type for the "buffer" argument, this lack of type can cause an error

I suggest defining a type for the "buffer" argument, this lack of type can cause an error

Hi @laxeder, thanks for the suggestion! Good point. I have added the type, please do re-review. Thank you.


tests: subsys: Check zephyr os tracing functions.

Add some testcases for subsys/trace and Use
self-define backends to get tracing data
and check the output data.
Signed-off-by: Ningx Zhao<EMAIL_ADDRESS>

Hi @nashif , would you like to take a look at this PR, thanks.

Hi @nashif @andyross , I think I have addressed all comments, and the testcase is used to test tracing function by using the self-designed tracing backend on qemu_x86 platform, and you know, zephyr branch will be released on date 5.7, so I want to got merged before this deadline, so would you like to take a look at this PR, and to comment it if there are anything wrong, thanks very much.

marking as DNM, we expect some major changes to tracing subsystems coming from #33603, will revisit and integrate with new changes once they land.


Overview of activities of OK-EE

#22
Maarja-Leena: events and initiatives that we have participated in or organized.

Open Data Day in Tartu. Important, that by open data people just mean data that is publicly accessible.
Data as remedy: 24h post-truth hackathon. 60 people started. Six teams produced somethinginterdisciplinary, most participants were students; good mentoring.
Open Data Issue Tracker opening. It happened in preparation to the G48 Baltic Open and Big Data Hackaton. It will also feed into the Estonian Open Data Index. Great help from Andres Kütt. Datasets from institutions who have never thought about data sharing before: AKI, Riigikontroll etc...
MyData2017 Conference. This is the most intensive collaboration that we have with Finnish Open Knowledge. Finns are doing great work that we take as an example.
TODAY'S meeting

UPCOMING EVENTS:

Tartu University organizing Social Impact Data Hack on Nov 10-12. It's pretty fully booked, but techies are surely still welcome. Data sets will be published soon.

Q&A:

Any people we know in Latvia/Lithuania? Maarja-Leena will help.

Ülevaade anti ja sellele ei järgnenud tegevusi.


[WIP] Promote implementation in server

Add server side promote implementation and a simple sanity test.
TODO:

add more check in mayPromoteMember
add change becomeFollower

cc @jingyih  @xiang90 @jpbetz @gyuho

. Looks like using raftpb.ConfChangeAddNode to promote learner makes the validation logic in server very complicated. Sorry that I left a bunch of comments:)

yeah, I struggled to use ConfChangeAddNode to implement this. I think ConfUpdate is more fit for the etcdserver but the raft requires the ConfChangeAddNode type. Can we change the type before sending to the raft(first update then add)?

Catch your comments. I do not put much effort yet, just a poc for your guys to see what's missing. I will update a more complete implementation today.

. Looks like using raftpb.ConfChangeAddNode to promote learner makes the validation logic in server very complicated. Sorry that I left a bunch of comments:)

yeah, I struggled to use ConfChangeAddNode to implement this. I think ConfUpdate is more fit for the etcdserver but the raft requires the ConfChangeAddNode type. Can we change the type before sending to the raft(first update then add)?

Is it possible to add some logic here to check if the request is adding a member, or promoting a learner? The validation logic can diverge after the check.
https://github.com/jingyih/etcd/blob/8f121e9952439c2cd11bfe328f804160547d6c9b/etcdserver/api/membership/cluster.go#L282-L283

@jpbetz @jingyih changed according to your comment.PTAL

I think ConfUpdate is more fit for the etcdserver but the raft requires the ConfChangeAddNode type. Can we change the type before sending to the raft(first update then add)?

Don't we already have ConfChangeAddLearnerNode? Or am I missing anything?

@WIZARD-CXY

I think ConfUpdate is more fit for the etcdserver but the raft requires the ConfChangeAddNode type. Can we change the type before sending to the raft(first update then add)?

Don't we already have ConfChangeAddLearnerNode? Or am I missing anything?

ConfChangeAddLearnerNode is for adding learner member to raft. In raft implementation, promoting is done by ConfChangeAddNode request.

Thanks @WIZARD-CXY. Let's document more about the code base :)

Roger that

I found the existing codebase may not be very friendly to the new added promotion code. We may get  clean code unless we refactor the other validation functions.....

@jingyih @gyuho changed according to your suggestions, ptal.

Will try to take a look later today. Thanks:)

I found the existing codebase may not be very friendly to the new added promotion code. We may not get very clean code unless we refactor the other validation functions.....

What validation? Are you referring to checking the raft progress?

》What about raft progress check for promoting? Does the current raft implementation provide enough visibility of the progress?
I just want to check that with you. I found etcdserver can't find the learner progess now.... The progress resides in the raft.

What about raft progress check for promoting? Does the current raft implementation provide enough visibility of the progress?

I just want to check that with you. I found etcdserver can't find the learner progess now.... The progress resides in the raft.

Can you sync up with @xiang90 to see if he has any suggestion? I will also think about it later this week.

will do @jingyih

I found etcdserver can't find the learner progess now.... The progress resides in the raft.

I think we need define how we would evaluate the learner progress.
We only have replication progress in Raft layer, but nothing about the progress in follower (or non-voting learner). Maybe compare commit index?

how about this place?

how about this place?

I don't see how we can return meaningful error back to server, if the check is implemented in the place highlighted in your screenshot.

I found etcdserver can't find the learner progess now.... The progress resides in the raft.

I think we need define how we would evaluate the learner progress.
We only have replication progress in Raft layer, but nothing about the progress in follower (or non-voting learner). Maybe compare commit index?

Do we need to update the design doc accordingly?
I will go through the progress implementation in raft sometime later this week, before I make suggestion on how to evaluate the learner progress.

We have a separate task for adding sanity checks for promoting. I feel like we can merge this, and address the progress check in a separate PR.

@jingyih from @xiang90's advice we can expose progress by using softstate.

@jingyih this pr remains one flaw we can't deny the promote request with non-existing id now

I'd like to add it in the mayPromoteMember...

Merging this is ok, the client etcdctl code is ready for this to be merged. I will fix the remaining issue asap.

@jingyih this pr remains one flaw we can't deny the promote request with non-existing id now

I missed this part. Feels to me that it should be checked in ValidateConfigurationChange? Also, can we have unit tests to ensure the intended behavior (let me know if you need help on creating the tests)?

@jingyih can u help with the unresolved comment? I left issue there

@jingyih can u help with the unresolved comment? I left issue there

I see. I'll take a look.

@jingyih when this a promote change I want to check if this member is existing in the cluster, but I found it is hard checking here.

because adding a follower call and promoting learner call can both have id exists or not. Both are valid, can you give me a piece of advice?

Good question.
Fundamentally, both (s *EtcdServer) AddMember() and (s *EtcdServer) PromoteMember() use the same raftpb.ConfChangeAddNode type to propose config change. If the member ID does not exist in the cluster, it could be either a valid member add request, or an invalid promote request.
Fortunately, we might have an easy workaround... Since we do strict checking on peerURLs when adding a member (see [1]), whereas we pass empty peerURLs when promoting a member. I think we can use this to distinguish between the two cases in the very beginning of ValidateConfigurationChange().
Ref:
[1]
https://github.com/jingyih/etcd/blob/e1ca3b4434945e57e8e3a451cdbde74a903cc8e1/clientv3/cluster.go#L69-L73
https://github.com/jingyih/etcd/blob/a621d807f061e1dd635033a8d6bc261461429e27/pkg/types/urls.go#L28-L32

Let's also explore a different approach. If we use a different ConfChangeType, say ConfChangePromoteNode to indicate a promote request. It will make request validation in etcdserver much easier. But on the flip side, Raft is still using ConfChangeAddNode to promote a learner. So after validating the request, we will need to change the ConfChangeType of the request, before sending it to raft node's ApplyConfChange().
It seems that either approach has Pros and Cons.

the sencond approach looks clearer.

Just talked to @jpbetz about this. How about we add a bit more information to the config change request before sending it to raft, so that later in validation process we can use it. To be specific:

Currently this is what we send to raft
1.1 For adding member
https://github.com/jingyih/etcd/blob/e1ca3b4434945e57e8e3a451cdbde74a903cc8e1/etcdserver/server.go#L1579-L1587
1.2 For promoting member
https://github.com/jingyih/etcd/blob/ac1bcff195b026eadc98078abb0dbd882f869488/etcdserver/server.go#L1637-L1646

They are basically the same request. Therefore we are facing the issue where we cannot distinguish whether the request is for adding a member or for promoting a member in validation in server apply.

How about we add isPromote information in raftpb.ConfChange.Context. I image something like this:

type ConfigChangeContext struct {
  memb      membership.Member
  isPromote bool
}

And use the json encoding of ConfigChangeContext as raftpb.ConfChange.Context.

How about we add isPromote information in raftpb.ConfChange.Context. I image something like this:

As long as we handle the json.Marshal error (e.g. request from old versioned peer), this sounds good.

Let's finish implementing validation logic in ValidateConfigurationChange(). Then, we can send a WIP PR to the main repo, before the change in feature branch become too large.
I will open a separate issue to discuss how to evaluate learner progress.

ok

@WIZARD-CXY, please take a look at a potential solution proposed in
#8 (comment)
We will need to check if it is compatible with members with older etcd version.

If b is encoded with membership.Member, can a new server decode it using json.UnMarshal(b, ConfigChangeContext)
If b is encoded with ConfigChangeContext, can a old server decode it using json.UnMarshal(b, Member)

Case 1 is probably of less concern, server of newer version is aware of this potential issue, so it can handle it. For example, it can try to decode into ConfigChangeContext, if there is error, fall back to decode into Member.

@jingyih I think golfing can handle what you think. see this simple example https://play.golang.org/p/mQtI7Il69iD

@WIZARD-CXY sounds great! Let's use this method.

@jingyih changed ptal.

Notice I don't change the context from Member to ConfigChangeContext everywhere including the test code now. Ideally it should be two separate pr. Do we need to change them all now?

Notice I don't change the context from Member to ConfigChangeContext everywhere including the test code now. Ideally it should be two separate pr. Do we need to change them all now?

Without the change, will the test fail?

Without the change, will the test fail?

The test does not fail now. But people maybe wondering why add Member use member as context while promote Member is using another context. I think it is better change them in the same way.

@jingyih changed  ptal

@jingyih after this merged, we can finish more, make phase II almost done.

Merging this PR. Let's deal with mayPromoteMember in separate PR.

will do today


Image source sets load the wrong image size

Describe the bug
In Chrome there is a weird problem (I actually have a stack overflow opened about this) where the plain <img /> tags with source sets load the wrong image sizes. I noticed the template generates several image sizes for embedded images into a post; which is awesome; but it will load the wrong image sizes.
To Reproduce
Steps to reproduce the behavior:

Open DevTools in Chrome
Resize screen to Mobile (and/or refresh)
For a screen width of 400x the image of 1200x will be loaded

Expected behavior
Other browsers will load the correct image size based on the viewport and available size, Chrome will not. I suggest using <picture /> tags instead for embedding images into posts and problem will be solved.
Hugo version:
$ hugo v0.99.1-d524067382e60ce2a2248c3133a1b3af206b6ef1+extended windows/amd64 BuildDate=2022-05-18T11:18:14Z VendorInfo=gohugoio

Theme version:
$ 28585e20c5beda80b7a94ebe3ce33403f69d697c (HEAD -> main, origin/main, origin/HEAD) Update README.md

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Latest

Thanks, but the theme doesn't use the img's srcset attribute.


Add link to Connect Box exporter

Hi,
I wrote an exporter for Compal CH7465LG cable modems. These are marketed by several carriers across Europe under different names, most commonly under the name "Connect Box".
I wrote the exporter as a custom collector since one cannot run code on the modem itself. It's highly unlikely that users will have multiple modems running at home. I therefore read the modem IP from an external YAML config file instead of following the service discovery approach used in the IPMI or SNMP exporters. I hope that's fine for you.
I'd love to see this get accepted here, so please let me know if there is anything you would like to see fixed. :blush:

Does this work only one one specific model of modem? I'm not sure of the wisdom of listing an exporter for each individual type of network device out there that doesn't support SNMP.
connectbox_uptime_seconds_total is a gauge.
It'd be simpler to fail the scrape rather than have connectbox_scrape_success.

It'd be simpler to fail the scrape rather than have connectbox_scrape_success.

https://github.com/prometheus/haproxy_exporter/blob/master/haproxy_exporter.go#L186
Or call it connectbox_up, like we do in haproxy exporter?

Does this work with only one one specific model of modem? I'm not sure of the wisdom of listing an exporter for each individual type of network device out there that doesn't support SNMP.

Yes, it supports only one model albeit one which is owned by many cable customers. Whether it makes sense listing such an exporter in the docs is your choice.

connectbox_uptime_seconds_total is a gauge.

Ok, I'll change that.

Or call it connectbox_up, like we do in haproxy exporter?

Ok.


update moc 0.6.24

@chenyan-dfinity do you mean for moc or dfx? No dfx includes this version of moc/base yet.

I mean the moc version. Since CI passed with the moc bump, it's a good place to push the moc version tag.


list inputs to tfr functions

Reference issue
This is one step for the GSoC TFR in Source Space Project (See: Issue #6290  ).
What does this implement/fix?
This will allow tfr_morlet and tfr_multitaper to take lists or generator objects as input, which is necessary in order to process SourceEstimate types like epochs and, e.g. calculate the Inter-Trial-Coherence.
Additional information
This is a simple first solution in order to proceed with further steps of the project. Processing the list elements subsequently in order to reduce memory load will require more significant changes and will be implemented later.

I don't see the point of allowing a list epochs / evoked. You should make it work for a list or a generator of stc

That's true, there's no direct benefit in this. However, as MNE user (and using python in general), i hate functions that are too complicated because of a lot of special cases, when a is only supported for b and x only works when y=z etc... So with this wanted to do a simple start that works universally and is easily transferred for SourceEstiamte types. Just to make everything more simple for the user. Additionally, if the more data saving variant is implemented, this might even be used to save memory for generated Epochs data, since it would enable to process subdivided or single epochs consecutively.
Not sure if that's convincing enough, so if you don't approve, i will only implement list support for stcs.

every new way of doing things, every feature has a cost: review time,
testing time hence computational
ressources, code maintenance etc.
I prefer we add features when we need them.
I would stick to stc
and if you have a problem with epochs and memory usage you can use
preload=False to avoid storing
more than on epoch in memory at a time.

Okay, only stcs then!


Can not build.

I have done as https://meetecho.github.io/janus-mobile-sdk/#/getting-started, but still can not build. The log from my side:
Build command failed.
Error while executing process /Users/kienht/Library/Android/sdk/cmake/<IP_ADDRESS>88404/bin/cmake with arguments {--build /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a --target janus-android-sdk}
[1/66] Creating directories for 'json_proj'
[2/66] Creating directories for 'boringssl_proj'
[3/66] No download step for 'json_proj'
[4/66] No download step for 'boringssl_proj'
[5/66] No update step for 'json_proj'
[6/66] No patch step for 'json_proj'
[7/66] No update step for 'boringssl_proj'
[8/66] No patch step for 'boringssl_proj'
[9/66] Performing configure step for 'json_proj'
-- Check for working CXX compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++
-- Check for working CXX compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using the single-header code from /Users/kienht/janus-mobile-sdk/third_party/json/single_include/
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/json/src/json_proj-build
[10/66] Performing build step for 'json_proj'
ninja: no work to do.
[11/66] Performing install step for 'json_proj'
[0/1] Install the project...
-- Install configuration: "Release"
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/include
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/include/nlohmann
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/include/nlohmann/json.hpp
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/lib/cmake/nlohmann_json/nlohmann_jsonConfig.cmake
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/lib/cmake/nlohmann_json/nlohmann_jsonConfigVersion.cmake
-- Installing: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/lib/cmake/nlohmann_json/nlohmann_jsonTargets.cmake
[12/66] Completed 'json_proj'
[13/66] Performing configure step for 'boringssl_proj'
-- Check for working C compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang
-- Check for working C compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++
-- Check for working CXX compiler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The ASM compiler identification is Clang
-- Found assembler: /Users/kienht/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/boringssl/src/boringssl_proj-build
[14/66] Performing build step for 'boringssl_proj'
FAILED: third_party/boringssl/src/boringssl_proj-stamp/boringssl_proj-build
cd /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/boringssl/src/boringssl_proj-build && /Users/kienht/Library/Android/sdk/cmake/<IP_ADDRESS>88404/bin/cmake --build . && /Users/kienht/Library/Android/sdk/cmake/<IP_ADDRESS>88404/bin/cmake -E touch /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/boringssl/src/boringssl_proj-stamp/boringssl_proj-build
[1/416] Generating crypto_test_data.cc
FAILED: crypto_test_data.cc
cd /Users/kienht/janus-mobile-sdk/third_party/boringssl && go run util/embed_test_data.go crypto/cipher_extra/test/aes_128_cbc_sha1_tls_implicit_iv_tests.txt crypto/cipher_extra/test/aes_128_cbc_sha1_tls_tests.txt crypto/cipher_extra/test/aes_128_cbc_sha256_tls_tests.txt crypto/cipher_extra/test/aes_128_ccm_bluetooth_tests.txt crypto/cipher_extra/test/aes_128_ccm_bluetooth_8_tests.txt crypto/cipher_extra/test/aes_128_ctr_hmac_sha256.txt crypto/cipher_extra/test/aes_128_gcm_siv_tests.txt crypto/cipher_extra/test/aes_128_gcm_tests.txt crypto/cipher_extra/test/aes_192_gcm_tests.txt crypto/cipher_extra/test/aes_256_cbc_sha1_tls_implicit_iv_tests.txt crypto/cipher_extra/test/aes_256_cbc_sha1_tls_tests.txt crypto/cipher_extra/test/aes_256_cbc_sha256_tls_tests.txt crypto/cipher_extra/test/aes_256_cbc_sha384_tls_tests.txt crypto/cipher_extra/test/aes_256_ctr_hmac_sha256.txt crypto/cipher_extra/test/aes_256_gcm_siv_tests.txt crypto/cipher_extra/test/aes_256_gcm_tests.txt crypto/cipher_extra/test/chacha20_poly1305_tests.txt crypto/cipher_extra/test/xchacha20_poly1305_tests.txt crypto/cipher_extra/test/cipher_tests.txt crypto/cipher_extra/test/des_ede3_cbc_sha1_tls_implicit_iv_tests.txt crypto/cipher_extra/test/des_ede3_cbc_sha1_tls_tests.txt crypto/cipher_extra/test/nist_cavp/aes_128_cbc.txt crypto/cipher_extra/test/nist_cavp/aes_128_ctr.txt crypto/cipher_extra/test/nist_cavp/aes_128_gcm.txt crypto/cipher_extra/test/nist_cavp/aes_192_cbc.txt crypto/cipher_extra/test/nist_cavp/aes_192_ctr.txt crypto/cipher_extra/test/nist_cavp/aes_256_cbc.txt crypto/cipher_extra/test/nist_cavp/aes_256_ctr.txt crypto/cipher_extra/test/nist_cavp/aes_256_gcm.txt crypto/cipher_extra/test/nist_cavp/tdes_cbc.txt crypto/cipher_extra/test/nist_cavp/tdes_ecb.txt crypto/curve25519/ed25519_tests.txt crypto/cmac/cavp_3des_cmac_tests.txt crypto/cmac/cavp_aes128_cmac_tests.txt crypto/cmac/cavp_aes192_cmac_tests.txt crypto/cmac/cavp_aes256_cmac_tests.txt crypto/ecdh_extra/ecdh_tests.txt crypto/evp/evp_tests.txt crypto/evp/scrypt_tests.txt crypto/fipsmodule/aes/aes_tests.txt crypto/fipsmodule/bn/bn_tests.txt crypto/fipsmodule/ec/ec_scalar_base_mult_tests.txt crypto/fipsmodule/ec/p256-x86_64_tests.txt crypto/fipsmodule/ecdsa/ecdsa_sign_tests.txt crypto/fipsmodule/ecdsa/ecdsa_verify_tests.txt crypto/fipsmodule/modes/gcm_tests.txt crypto/fipsmodule/rand/ctrdrbg_vectors.txt crypto/hmac_extra/hmac_tests.txt crypto/poly1305/poly1305_tests.txt crypto/siphash/siphash_tests.txt crypto/x509/many_constraints.pem crypto/x509/many_names1.pem crypto/x509/many_names2.pem crypto/x509/many_names3.pem crypto/x509/some_names1.pem crypto/x509/some_names2.pem crypto/x509/some_names3.pem third_party/wycheproof_testvectors/aes_cbc_pkcs5_test.txt third_party/wycheproof_testvectors/aes_cmac_test.txt third_party/wycheproof_testvectors/aes_gcm_siv_test.txt third_party/wycheproof_testvectors/aes_gcm_test.txt third_party/wycheproof_testvectors/chacha20_poly1305_test.txt third_party/wycheproof_testvectors/dsa_test.txt third_party/wycheproof_testvectors/ecdh_secp224r1_test.txt third_party/wycheproof_testvectors/ecdh_secp256r1_test.txt third_party/wycheproof_testvectors/ecdh_secp384r1_test.txt third_party/wycheproof_testvectors/ecdh_secp521r1_test.txt third_party/wycheproof_testvectors/ecdsa_secp224r1_sha224_test.txt third_party/wycheproof_testvectors/ecdsa_secp224r1_sha256_test.txt third_party/wycheproof_testvectors/ecdsa_secp224r1_sha512_test.txt third_party/wycheproof_testvectors/ecdsa_secp256r1_sha256_test.txt third_party/wycheproof_testvectors/ecdsa_secp256r1_sha512_test.txt third_party/wycheproof_testvectors/ecdsa_secp384r1_sha384_test.txt third_party/wycheproof_testvectors/ecdsa_secp384r1_sha512_test.txt third_party/wycheproof_testvectors/ecdsa_secp521r1_sha512_test.txt third_party/wycheproof_testvectors/eddsa_test.txt third_party/wycheproof_testvectors/kwp_test.txt third_party/wycheproof_testvectors/kw_test.txt third_party/wycheproof_testvectors/rsa_pss_2048_sha1_mgf1_20_test.txt third_party/wycheproof_testvectors/rsa_pss_2048_sha256_mgf1_0_test.txt third_party/wycheproof_testvectors/rsa_pss_2048_sha256_mgf1_32_test.txt third_party/wycheproof_testvectors/rsa_pss_3072_sha256_mgf1_32_test.txt third_party/wycheproof_testvectors/rsa_pss_4096_sha256_mgf1_32_test.txt third_party/wycheproof_testvectors/rsa_pss_4096_sha512_mgf1_32_test.txt third_party/wycheproof_testvectors/rsa_pss_misc_test.txt third_party/wycheproof_testvectors/rsa_signature_test.txt third_party/wycheproof_testvectors/x25519_test.txt > /Users/kienht/janus-mobile-sdk/platforms/android/janus-client/.externalNativeBuild/cmake/debug/arm64-v8a/third_party/boringssl/src/boringssl_proj-build/crypto_test_data.cc
/bin/sh: go: command not found
[2/416] Generating ghash-neon-armv8.S
[3/416] Generating sha1-armv8.S
[4/416] Generating aesv8-armx.S
[5/416] Generating armv8-mont.S
[6/416] Building CXX object CMakeFiles/boringssl_gtest.dir/third_party/googletest/src/gtest-all.cc.o
ninja: build stopped: subcommand failed.
ninja: build stopped: subcommand failed.

@helloIAmPau @kefir266 please help me

Moving project folder to desktop directory, it's built.


make Bytes repr(C)?

I find it useful if Bytes is #[repr(C)] so it can pass through the FFI boundary. BytesMut cannot since it has Vec in it, but Bytes seems to be safe to #[repr(C)]. I have the little patch here: https://github.com/dovahcrow/bytes/commit/6ac9e4bb2a7b1084f7721813ffc7b816253cc4b5 and I can PR if the team wants.

This has serious backwards compatibility challenges. I'm not ready to freeze the representation forever.

I see, no worries. Shall we close this issue now?


Clickable ads

Ads which are available on https://developers.google.com/interactive-media-ads/docs/sdks/html5/tags can be clicked, which then redirects to some google website. I am wondering if it is possible to disable redirecting when clicking on ad?

From ad server point of view, if there is no "ClickThrough" or "ClickTracking" in ad server response, i think that IMA SDK display the video ad without clickable elements.
I have made a simple example VAST 2.0 tag url : https://diffusepro.com/video-ad/vast/linear/vast2_noclickurl.xml. In this VAST, i removed the <VideoClicks> xml element.
Note that some ad server (for example Google Ad Manager) require click url to be filled in order to create creative set.
From a javascript point of view, you could "intercept" mouse click on ad display container.
(or adding custom click element)
AFAIK, i did not see any option in IMA SDK to disable click through.
(most common goal of an ad is to make to user click on it)

Thanks for explanation.
From what I read in referenced issue, it is necessary to add optional param opt_clickTrackingElement. Is it already there?

It is not implemented yet in ima-ad-player sub-project.
Also, does your ad server handle audio only creative set ?
(ad server which handle audio only ad may have click through url as optional configuration parameter).

Cloud team from our department is still finalizing the specification of ad service. Therefore I'm not yet able to say if it's going to support it or not yet. For sure video creative ads will be there.

I released a new version with latest ima-ad-player with new clickTracking configuration option.

Thanks. I'll give it some testing and provide you feedback.

Works as expected. Can be closed. Thanks!


http 500 response

I cloned one of the examples to checko out the chat feature but ran into problems with the chat endpoint returning a 500 server error:
Same response using https://api.langbase.com/beta/pipes/run and  https://api.langbase.com/beta/chat

Lemme know if you need any more details
Thank you

Hi, please check and report the following:

Is streaming on or off?
What provider are you using? OpenAI?
Please share your username


AlertDialog shape not correctly applied (Surface has its own shape)

JB-Compose 1.0.1 as well as latest alpha 1.1.0-alpha1-dev550.
Related to this slack message
Surface has a RectangleShape which is not overridden by AlertDialog resulting of a MaterialTheme.colors.surface rectangle shaped background (grey in the screenshot).
(sorry for the colours 👀 )

Could you share a small reproducer for it, please? Better with not so bright colors )

Sure, any AlertDialog with a shape will reproduce the issue.
        AlertDialog(
            backgroundColor = Color.Green,
            contentColor = Color.Red,
            shape = RoundedCornerShape(16.dp),
            onDismissRequest = {},
            buttons = {
                Button(
                    onClick = {},
                    content = {
                        Text("Ok")
                    })
            },
            title = { Text("Error") },
            text = { Text("Hello alert dialog") }
        )

This always happens to me on desktop, on android it works correctly

My team is encountering this as well.

Reproduce in this repository:
https://github.com/dima-avdeev-jb/reproduce-bug-with-alert-dialog

This is a duplicate of #1269.

Duplicate of https://github.com/JetBrains/compose-jb/issues/1269

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Questions about tcnn's dim

Thank you for your attribution，but I have some questions about tcnn's dim.
Since we only use 7dim of the output of tcnn，why the net is define as 8dim？
if training_args.only_mlp:
model=tcnn.Network(n_input_dims=3,n_output_dims=8,network_config=ntc_conf["network"]).to(torch.device("cuda"))
else:
model=tcnn.NetworkWithInputEncoding(n_input_dims=3, n_output_dims=8,encoding_config=ntc_conf["encoding"],network_config=ntc_conf["network"]).to(torch.device("cuda"))

resi=self.model(ntc_inputs)
masked_d_xyz=resi[:,:3]
masked_d_rot=resi[:,3:7]

Hi,
In fact, this is a historical legacy problem. When I first started the experiments, I used the 8-dim output. Later, for convenience, I did not change the setting, but commented out the related lines instead. So that's why the NTC has 8-dim output but I only use 7 dims of them.

Thank you for your answer. Additionally, I have one more question:
May I ask if the multi-resolution hash you used is only used to estimate the transformation of Gaussian points, and did not use multi-resolution hash in the render process (it seems to store the scale, sh, and other information of all Gaussian points instead of using hash voxel interpolation)

yes, the ntc is only used to transform the gaussians

Oh, okay, thank you very much for your answer ^^


ament_cmake_clang_format not found will building. Build failed.

I am using ros2 humble in ubuntu 22. I have clang installed. I used " sudo apt install clang ". I dont know how to remove this dependency issue.
ubuntu@ubuntu-VirtualBox:~/test$ colcon build
Starting >>> mocap_msgs
Starting >>> mocap_control_msgs
Starting >>> mocap_marker_viz_srvs
Starting >>> mocap_robot_gt_msgs
Finished <<< mocap_marker_viz_srvs [1.96s]
Finished <<< mocap_control_msgs [2.04s]
Starting >>> mocap_control
Finished <<< mocap_robot_gt_msgs [2.07s]
Finished <<< mocap_msgs [2.27s]
Starting >>> mocap_marker_publisher
Starting >>> mocap_marker_viz
Starting >>> mocap_robot_gt
Finished <<< mocap_control [0.63s]
Starting >>> mocap_optitrack_driver
Finished <<< mocap_marker_publisher [0.49s]
Starting >>> rqt_mocap_control
Finished <<< mocap_marker_viz [0.53s]
Finished <<< mocap_robot_gt [0.63s]
Finished <<< rqt_mocap_control [0.49s]
--- stderr: mocap_optitrack_driver
CMake Error at CMakeLists.txt:93 (find_package):
  By not providing "Findament_cmake_clang_format.cmake" in CMAKE_MODULE_PATH
  this project has asked CMake to find a package configuration file provided
  by "ament_cmake_clang_format", but CMake did not find one.

  Could not find a package configuration file provided by
  "ament_cmake_clang_format" with any of the following names:

    ament_cmake_clang_formatConfig.cmake
    ament_cmake_clang_format-config.cmake

  Add the installation prefix of "ament_cmake_clang_format" to
  CMAKE_PREFIX_PATH or set "ament_cmake_clang_format_DIR" to a directory
  containing one of the above files.  If "ament_cmake_clang_format" provides
  a separate development package or SDK, be sure it has been installed.
---
Failed   <<< mocap_optitrack_driver [3.42s, exited with code 1]

Summary: 9 packages finished [6.61s]
  1 package failed: mocap_optitrack_driver
  1 package had stderr output: mocap_optitrack_driver
ubuntu@ubuntu-VirtualBox:~/test$

For now I have commented these lines in CMakeLists.txt where ament_cmake_clang_format  is required. Then I was able to complete the build.
#if(BUILD_TESTING)
#  find_package(ament_cmake_copyright REQUIRED)
#  find_package(ament_cmake_clang_format REQUIRED)
#  find_package(ament_cmake_cppcheck REQUIRED)
#  find_package(ament_cmake_cpplint REQUIRED)
#  find_package(ament_cmake_lint_cmake REQUIRED)
#  find_package(ament_cmake_xmllint REQUIRED)
#  find_package(ament_cmake_uncrustify REQUIRED)
#  file(GLOB_RECURSE EXCLUDE_FILES NatNetSDK/*)
#  ament_copyright(EXCLUDE ${EXCLUDE_FILES})
#  ament_cppcheck(
#    EXCLUDE ${EXCLUDE_FILES}
#    LANGUAGE c++
#  )
#  ament_cpplint(EXCLUDE ${EXCLUDE_FILES})
#  ament_lint_cmake()
#  ament_uncrustify(
#    EXCLUDE ${EXCLUDE_FILES}
#    LANGUAGE c++
#  )
#  find_package(ament_cmake_gtest REQUIRED)
#endif()

Any idea, @jmguerreroh ?

Hi @PrakritTyagi,
I have never seen this error before. First of all, make sure you have installed all the dependencies executing:
rosdep install --from-paths src --ignore-src -r -y

This package is provided as ROS Humble package so that you can install it manually:
apt install ros-humble-ament-clang-format ros-humble-ament-cmake-clang-format

And finally, you can compile using --cmake-args to deactivate the BUILD_TESTING option
colcon build --symlink-install --cmake-args -DBUILD_TESTING=OFF

Regards

Thanks your solution works.


feat: Devtools stability

Current dependencies on/for this PR:

main

PR #2577   👈

This comment was auto-generated by Graphite.


Bump frameworks

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.49%. Comparing base (c898502) to head (5236da0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   93.49%   93.49%
=======================================
  Files           7        7
  Lines         446      446
=======================================
  Hits          417      417
  Misses         29       29

Flag
Coverage Δ

unittests
93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SAML app with same issuer created in super tenant cannot be created inside a custom tenant

Describe the issue:
An issuer used to create a SAML application in the super tenant enviornment cannot be used to create an app inside a custom tenant. But this behaviour is not visible across custom tenants.
Case 1:
Super tenant :  Create saml2-web-app-pickup-dispatch.com -> Successful
Tenant 1: Create saml2-web-app-pickup-dispatch.com -> Not allowed
Case 2:
Tenant 1 :  Create saml2-web-app-pickup-dispatch.com -> Successful
Tenant 2: Create saml2-web-app-pickup-dispatch.com -> Successful

How to reproduce:

Create a SAML app with xxx.com issuer in the super tenant enviornment.
Create a SAML app with xxx.com issuer in the custom tenant enviornment.

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 6.1.0
OS: Mac
Database: Postgres
Userstore: JDBC

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Use ReadAdvice#RANDOM when appropriate.

This switches the following files to ReadAdvice.RANDOM:

Stored fields data file.
Term vectors data file.
HNSW graph.
Temporary file storing vectors at merge time that we use to construct the merged HNSW graph.
Vector data files, including quantized data files.

I hesitated using IOContext.RANDOM on terms, since they have a random access pattern when running term queries, but a more sequential access pattern when running multi-term queries. I erred on the conservative side and did not switch them to IOContext.RANDOM for now.
For simplicity, I'm only touching the current codec, not previous codecs. There are also some known issues:

These files will keep using a RANDOM IOContext at merge time. We need some way for merge instances to get an updated IOContext? We have the same problem with IOContext#LOAD today.
With quantized vectors, raw vectors don't have random access pattern, but it was challenging to give raw vectors a sequential access pattern when there are quantized vectors and a random access pattern otherwise. So they assume a random access pattern all the time.

Hi, I have some problem regarding merging with it - and a suggestion. Please hold with merging.

No worries, Uwe. Looking forward to your suggestions.

In addition, we should still look into getting the IOContexts correct when we merge. The current solution is not ideal, but somehow not really changeable. When you clone an indexinput, you can't set another read advice, as the underlying mmaped segments are the same in the clone.

About the announced comment: When we merge we want to use sequential, as the kernel may earlier free the pages. But actually I am not sure, if we really need this: After merging the file is closed and deleted later. Then the pages get freed automatically, so I don't understand the whole issue that Mike has seen.

What do you think?

I had similar thoughts is mind, so that sounds good to me.
I'm still curious about how to fix the bigger issue wrt reader pooling. Should getMergeInstance() open fresh new IndexInputs? Or maybe we avoid reusing readers across searching and merging, and we'll open a fresh new reader if we need to merge, even though the same segment may already be open for search?

After merging the file is closed and deleted later. Then the pages get freed automatically, so I don't understand the whole issue that Mike has seen.

This only happens after the whole merge is finished. So if you're merging a 5GB segment, and it takes time, it's still a fair amount of page cache that merges are taking from searches. If pages could be more aggressively reclaimed while the merge is running, this could help?

I opened #13229, is it what you had in mind?

@uschindler I'm curious what you think of this PR now that ReadAdvice#RANDOM is the default. Should we keep calling state.context.withReadAdvice(ReadAdvice.RANDOM) to be explicit about the expected access pattern (what the PR is doing now) or should we lean on the default being ReadAdvice.RANDOM? In the latter case, we would only need to keep the changes in Lucene99FlatVectorsWriter.

I'll look into porting this work to branch_9x via a separate PR.

We should maybe also port some recent changes back, too. Not sure how to best do this. The new record classes and enums make this hard.
Maybe easiest is to use a method like IOContext#withRandomAccess().

This is exactly what I'm doing. :) All in the same PR, but it shouldn't be too big.

Backport PR: #13267.


[ButtonBase] ButtonBase.d.ts seems to be missing the component prop

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
This doesn't work, it says component is not available.
                      <IconButton
                        className={className}
                        color="secondary"
                        component={Link}
                        to={{
                          pathname: '/tags/new',
                          state: {
                            tagId: '123',
                          },
                        }}
                      >

No overload matches this call.
  Overload 1 of 3, '(props: { href: string; } & { children?: ReactNode; classes?: Partial<IconButtonClasses> | undefined; color?: "inherit" | "secondary" | "default" | ... 5 more ... | undefined; ... 4 more ...; sx?: SxProps<...> | undefined; } & Omit<...> & CommonProps & Omit<...>): Element', gave the following error.
    Type '{ children: Element; className: string; color: "secondary"; component: ForwardRefExoticComponent<LinkProps & RefAttributes<HTMLAnchorElement>>; to: { ...; }; }' is not assignable to type 'IntrinsicAttributes & { href: string; } & { children?: ReactNode; classes?: Partial<IconButtonClasses> | undefined; ... 5 more ...; sx?: SxProps<...> | undefined; } & Omit<...> & CommonProps & Omit<...>'.
      Property 'component' does not exist on type 'IntrinsicAttributes & { href: string; } & { children?: ReactNode; classes?: Partial<IconButtonClasses> | undefined; ... 5 more ...; sx?: SxProps<...> | undefined; } & Omit<...> & CommonProps & Omit<...>'.
  Overload 2 of 3, '(props: { component: ForwardRefExoticComponent<LinkProps & RefAttributes<HTMLAnchorElement>>; } & { ...; } & Omit<...> & CommonProps & Omit<...>): Element', gave the following error.
    Type '{ pathname: string; state: { tagId: string; }; }' is not assignable to type 'To'.
      Object literal may only specify known properties, and 'state' does not exist in type 'Partial<Path>'.
  Overload 3 of 3, '(props: DefaultComponentProps<ExtendButtonBaseTypeMap<IconButtonTypeMap<{}, "button">>>): Element', gave the following error.
    Type '{ children: Element; className: string; color: "secondary"; component: ForwardRefExoticComponent<LinkProps & RefAttributes<HTMLAnchorElement>>; to: { ...; }; }' is not assignable to type 'IntrinsicAttributes & { children?: ReactNode; classes?: Partial<IconButtonClasses> | undefined; color?: "inherit" | ... 7 more ... | undefined; ... 4 more ...; sx?: SxProps<...> | undefined; } & Omit<...> & CommonProps & Omit<...>'.
      Property 'component' does not exist on type 'IntrinsicAttributes & { children?: ReactNode; classes?: Partial<IconButtonClasses> | undefined; color?: "inherit" | ... 7 more ... | undefined; ... 4 more ...; sx?: SxProps<...> | undefined; } & Omit<...> & CommonProps & Omit<...>'.ts(2769)
[index.d.ts(48, 5): ]()The expected type comes from property 'to' which is declared here on type 'IntrinsicAttributes & { component: ForwardRefExoticComponent<LinkProps & RefAttributes<HTMLAnchorElement>>; } & { ...; } & Omit<...> & CommonProps & Omit<...>'

Expected behavior 🤔
We should be able to have an IconButton with a router link.
Steps to reproduce 🕹
Steps:

add an IconButton
try to set the component to Link from react-router-dom

Context 🔦
https://github.com/mui/material-ui/blob/v5.4.3/packages/mui-material/src/ButtonBase/ButtonBase.d.ts#L20
Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: Windows 10 10.0.22000
  Binaries:
    Node: 16.14.0 - ~\AppData\Local\nvs\node\16.14.0\x64\node.EXE
    Yarn: 1.22.17 - ~\AppData\Local\nvs\node\16.14.0\x64\yarn.CMD
    npm: 8.3.1 - ~\AppData\Local\nvs\node\16.14.0\x64\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22000.120.0), Chromium (98.0.1108.56)
  npmPackages:
    @emotion/react: ^11.8.1 => 11.8.1
    @emotion/styled: ^11.8.1 => 11.8.1
    @mui/base:  5.0.0-alpha.69
    @mui/icons-material: ^5.4.2 => 5.4.2
    @mui/material: ^5.4.3 => 5.4.3
    @mui/private-theming:  5.4.2
    @mui/styled-engine:  5.4.2
    @mui/system:  5.4.3
    @mui/types:  7.1.2
    @mui/utils:  5.4.2
    @types/react: ^17.0.20 => 17.0.39
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.4.2 => 4.5.5

Related: https://stackoverflow.com/questions/62036213/how-to-put-routerlink-in-iconbutton-in-reactjs#comment122300614_66526876

Looks like I'm using the wrong version. I'll close for now and reopen if it's still an issue.

:heavy_plus_sign: The  Component seems to also be suffering from this problem.

I also have this issue. It used to work and broke since some day.

I am closing this issue as I confirm that this is no longer an issue. Here is a working Codesandbox: https://codesandbox.io/s/lucid-mountain-g2v0ul?file=/src/App.tsx


1.20.4

Will the datapack be migrated to the new version(1.20.4) in the near future?

Hi, sorry for the long silence
a version that supports 1.20.4 already released recently (v4.1.6)


Use the type system more for message header encode/decode sizing

Problem
We have various places where we have to pass available buffer lengths to message encode/decode methods, where we could pick those up from the type of the buffer.

Summary of Changes
Add helpers for PacketBuffer and uint8_t[N] to pick up the buffer size automatically and simplify caller logic.

@jelderton @hawk248 please take a look?


No queries being run

Hi again,
I'm trying to run queries on a small sshash index, but the program reports that zero queries were ran. What could be the issue?
niklas@phoenix:~/code/SBWT_experiments$ ./sshash/build/query index.sshash test.fna
2022-06-01 19:02:46: loading index from file 'index.sshash'...
index size: 2.13636 [MB] (7.09913 [bits/kmer])
2022-06-01 19:02:46: performing queries from file 'test.fna'...
2022-06-01 19:02:46: DONE
==== query report:
num_kmers = 0
num_valid_kmers = 0 (-nan% of kmers)
num_positive_kmers = 0 (-nan% of valid kmers)
num_searches =<PHONE_NUMBER>01184/0 (inf%)
num_extensions = 2/0 (inf%)
elapsed = 0.005 millisec / 5e-06 sec / 8.33333e-08 min / inf ns/kmer

The index and the queries are attached here. I'm not attaching the original sequences because they are over 30GB.
data.zip

Here https://github.com/jermp/sshash/blob/master/include/query/membership_query.hpp#L107
you can see all the different supported file formats.
From here https://en.wikipedia.org/wiki/FASTA_format, I see there are
.fasta, .fna, .ffn, .faa, .frn, .fa.
Should probably add the missing ones.

Anyway, running ./query without arguments, tells you what file extensions should be used:
 query_filename
Must be a FASTA/FASTQ file (.fa/fasta or .fq/fastq extension) compressed with gzip or not.

Oh yeah, sorry, it's working now.

You're welcome. Closing this then.