[adc_ctrl] Register adc_wakeup_status does not exist

Register adc_wakeup_status is mentioned a number of times in the design specification.
This register does not appear to exist in the RTL or adc_ctrl.hjson and thus UVM register model.
It seems that in the current RTL filter_status is masked by adc_wakeup_ctl to generate the wakeup signal.

that is correct, let me fix the documentation.


fix(deps): update jw-epub-parser from 1.31.1 to 1.32.1

:tada: This PR is included in version 2.28.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Doesn't work on iOS mobile devices

Works great on desktop browsers and the mobile device view in Chrome's dev tools.
On iOS Safari, Chrome and Firefox, the body scroll locks but I'm unable to scroll in the modal opened by touching. Two-finger scroll seems possible but is buggy and also scrolls in the body element.

Are you talking about the this demo?

Have you got your target element set as the element that is meant to carry on scrolling? i.e. the element with overflow: auto
I was experiencing exactly the same issue you are and it was because I was accidentally targeting the parent element to the div actually doing the scrolling.

Are you talking about the this demo?

Exactly this demo doesn't work on iOS 14.2. Once you first scroll down a bit to hide the bottom safari navigation bar and then open the modal, one can still scroll the body.

could you have a look at this pull request and see if that solves your problem?
https://github.com/willmcpo/body-scroll-lock/pull/207

Have you got your target element set as the element that is meant to carry on scrolling? i.e. the element with overflow: auto
I was experiencing exactly the same issue you are and it was because I was accidentally targeting the parent element to the div actually doing the scrolling.

mersi mult, te pwp pe pula!

Well, the last release version is beta. If you want solve the problem, a fast solution is install this version: 2.6.4, works perfect for me.
yarn add<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>

Works great on desktop browsers and the mobile device view in Chrome's dev tools.
On iOS Safari, Chrome and Firefox, the body scroll locks but I'm unable to scroll in the modal opened by touching. Two-finger scroll seems possible but is buggy and also scrolls in the body element.

Hellow, I have the same problem. Please, can you say how did you fixed this.

#207

Hi, please make sure you are testing with the branch from this pull request: https://github.com/willmcpo/body-scroll-lock/pull/229

To enable scrolling of target elements on iOS, you need to enable it in options.
disableBodyScroll(currentReference, { allowTouchMove: () => true });

@charkour This works at the expense of re-enabling body scroll behind the modal

@bradleykhan, yeah you're right. This package is a little buggy and it appears to be no longer maintained. My team is looking for a better solutions but this is the best we've found for now.
Thanks for your comment!

@charkour Did you try https://github.com/tuax/tua-body-scroll-lock?

@diachedelic, hi!
Yeah, we initially tried that too but ran into issues when trying to use multiple locks. Didn't try too long. Seemed to work better than this package in more cases so it's worth a shot in my opinion!

@bradleykhan，They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use.
npm i body-scroll-lock-upgrade

repair Changelog
Refer to the releases page.

在桌面浏览器和 Chrome 开发工具中的移动设备视图上运行良好。
在 iOS Safari、Chrome 和 Firefox 上，主体滚动锁定，但我无法在通过触摸打开的模式中滚动。双指滚动似乎是可能的，但有问题，并且还会在 body 元素中滚动。

你好，我有同样的问题。拜托，你能说说你是怎么解决这个问题的吗？
They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use.

npm i body-scroll-lock-upgrade

repair log, Refer to the releases page.


Dynamic Button creates unresponsive button in Sketch 45.1

Steps to reproduce

Update Sketch to latest Version and restart
Select any layer and hit CMD+J
Try to CMD+Click or simply click the object
Object can't be selected or moved unless layer which was used to create a Button (e.g Text) is being moved manually with keyboard shortcuts or via the inspector panel.

Video demo
https://gfycat.com/DirtyHeartyBug

Thanks for notifying, seems like this new 45.1 update seems to be causing it. I can replicate the issue you mention but I haven't had a chance to debug and verify if it is my plugin or an issue with Sketch itself. I will get back to you again once I have time to dive deeper.
Thanks again

@fbasara-loft48 Issue fixed, Update via Sketchpacks. Let me know how it goes.

Works like a charm!

Can confirm it fixes the bug, just had the bug happen to me and the updated successfully fixed it.


tab completion: make it consistent and predictable

'location' completion should be available across all commands, so fat it is only available for 'vm create'
It is slow
Print out non related lists if there are no list.

============original feedback==============
One of the wow pieces of feedback we always get is the ability to use bash completion for common parameter values, such as VM sizes, locations, etc.  The problem is that this works beautifully in some commands and not in others, so can never really trust it and rely on it for productivity.  The problem is exacerbated by the fact that statement completion is currently pretty slow and prints out a weird list in cases where there is no value completion.  For example if you type az storage account create –location we print a list of all of the parameters the create commands takes followed by all files in the current directory.  But if you type az storage account create –type you get a list of storage account types.  I think it’s prudent to flush out the model and use it consistently, such that users can intuit the behavior.

@yugangw-msft Can we close this now? Tab completion support has been beefed-up and perf. has also improved.


[Epic]: Table widget v2 stability

Epic to track and fix the v1 table issues in v2.

Maybe I'm posting in the wrong issue, since it's not a "stability" issue per se, and if so I'm sorry. But there is a bug in both v1 and v2 that I'd like to see fixed:
When the default selected row is set, the table page shown should be the one of the selected row and not the first page. As it is, default selected row is kinda useless as there's no way the user will know that the row is selected unless it's among the first few items.

@zzgvh can you help me understand the following

Is all your data on the client side? Like you are not using server side pagination?
If it's client side data, are you simply suggesting we change the page till we land on the default selected row?

Hello @dilippitchika! Thanks for taking the time. I guess I'm somewhat of an outlier. I have been using Google spreadsheets as my "database" :stuck_out_tongue:. I did this because it makes changing both data structure and data itself trivial which is very nice when you're developing and trying lots of things out. Sure it has a lot of down sides too, but it has been good when everything is in flux. It also allows my users to easily "get at" the raw data which has proven very useful. So server side pagination isn't available (AFAIK).
My main use case where I need the page of a table to be set is as follows:

I have a "switchboard" view which serves as the starting point of tasks that the user completes. See image below.
first, the user selects a row in the top, "master", table
this in turn populates a second table, the "tasks", in the same view
the user now initiates an action by pressing a button in the "tasks" table
the user is navigated to another view where the task is completed
at the end of the task, the user is navigated back to the switchboard

When the user selects a row from the "master", I store the rowIndex in the Appsmith store and the default selected row of the "master" is set to the stored row. This is because most of the time several actions from the "tasks" table are completed one after the other with the selected row of the "master" remaining the same.
And this is where the UX will break if the default selected row in "master" is not on page 1, as the table now shows page 1. The user probably won't notice this, instead, to user it seems like the selected row in "master" has disappeared!
So it all boils down to the inability to restore the "full state of a page" after leaving and then coming back to it.
Since I'm using google sheets as database my ignorance about server side pagination is more or less complete, hence the following questions. Would the use case described above be solved by using it? Could I store the Table.pageNo and use it when the user returns to the page? Will the table show the correct page in this case? I'm asking because I am considering migrating my backend to Postgres. This is a major undertaking so it'd be good to know of all the upsides!
As always, keep up the good work! What you're doing is amazing, but it could be even more so! :wink:

Hey thanks for the info, i believe if you are going to postgres then simply solving the problem on client side will not solve it well enough.
My current idea is we add a new default page along with default selected row which can contain the details of the page we can go to, however there maybe a few concerns here. I have created a new issue to track this - https://github.com/appsmithorg/appsmith/issues/15672


error[E0425]: cannot find function precise_time_ns in crate time

carte:   xml5ever-0.2.0
error[E0425]: cannot find function `precise_time_ns` in crate `time`
   --> /Users/zxj/.cargo/registry/src/github.com-1ecc6299db9ec823/xml5ever-0.2.0/src/lib.rs:51:26
    |
51  |         let t0 = ::time::precise_time_ns();
    |                          ^^^^^^^^^^^^^^^ not found in `time`
    |
   ::: /Users/zxj/.cargo/registry/src/github.com-1ecc6299db9ec823/xml5ever-0.2.0/src/tokenizer/mod.rs:235:27
    |
235 |             let (_, dt) = time!(self.sink.process_token(token));
    |                           ------------------------------------- in this macro invocation
    |
    = note: this error originates in the macro `time` (in Nightly builds, run with -Z macro-backtrace for more info)

This is an issue with that crate, not time.

precise_time_ns

this is crates  time 's bug.
if use  time="0.3.7"  this will be run successful.

That crate is trying to use a method that has existed in time in years. As you just said using the latest version of time succeeds. Therefore the issue is not here.


Use page title text for top bar title if top bar title widget is empty.

In most of the cases, we would like to show the same text as page title in the top bar title component. The page title is a Widget. If top bar title is null for a page, the behavior should be this:

Check if the page title widget exists
Check if page title widget is a Text
Use the text.data in top bar title.

Merged.


How do i make an event in dialogues?

Describe your problem here.
As example: BF says something then the HUD shakes and a sound will play. I dont get this stuff tbh
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

it's not possible in Lua as far as I know

You could probably do it with the onNextDialogue() callback and by tracking the dialogue counter to do events on specific dialogue lines

You could probably do it with the onNextDialogue() callback and by tracking the dialogue counter to do events on specific dialogue lines

yea but that’s as close as you can get it

You could probably do it with the onNextDialogue() callback and by tracking the dialogue counter to do events on specific dialogue lines

Can you send an example?

You could probably do it with the onNextDialogue() callback and by tracking the dialogue counter to do events on specific dialogue lines

yea but that’s as close as you can get it

Example?


Add new capitalization mode for pattern "aBcdefg"

CHAOS should match "aBcD" instead of "aB" like it currently does.

This was a bad idea. A much better solution to handling capitalization special cases was implemented in 7d595591d4807bd1151e1222b867d80c18f18fc2


Add transformer for picking a single item from store

Right now, zustand pick operator returns an object containing the picked keys. It is inefficient for picking a single item from the store.

Current workaround

User's code
Transpiled code

const { setUser } = useUserStore.pick();

import { shallow } from "zustand/shallow";

const { setUser } = useUserStore(
  store => ({ setUser: store.setUser }),
  shallow
);

const { name } = useUserStore.pick("user");

import { shallow } from "zustand/shallow";

const { name } = useUserStore(
  store => ({ name: store.user?.name }),
  shallow
);

Proposed transformer

const setUser = useUserStore.pickFrom();

const setUser = useUserStore(store => store.setUser);

const name = useUserStore.pickFrom("user");

const name = useUserStore(store => store.user?.name);

@ajmaln _a please assign someone to work on this.

@Calvinwilson99 _a


Use ParameterizedTest in the normalizer unit tests

ParameterizedTest will make this test much more readable
And the bigger advantage is that each URL pair (weird url and the expected-normalized url) will then be a separate test, thus having more than 50 separate tests instead of 3 tests.
So a specific failing test will show us clearly which url failed, while having the rest of the urls pass their tests

This issue was addressed at commit: 2cfddca060bb72eb19a8f9736ea45542e0eceebd


remove Foundation.Move() fixes #8724

fixes #8724
#8746
removes Foundation.Move()
only commented out as in foundation.accordion.js also only commented out

Looks good, things appear to work as expected


make cross node services work

Services need to work across nodes. That means being able to reach a pod (any namespace) from any host. The originating node's OVS rules do not handle a swift exit for return traffic (vnid != 0) meant for tun0 (port 2, IP: subnet_gateway).
This PR adds a special rule in table 2 (as all input traffic from vxlan port is directed to table 2) to send anything meant for the host/service/tun0 directly out (no need to flood the rest of the ports).
Could have put this rule in table 5 also where all the rest of ports decide on which packet is whose, but why jump an extra table.
Also add priority to rules where the matching criterion can overlap (do not assume insertion order).
@dcbw : Review please. Services from another host didnt work without this and they work with this fix.

LGTM; I guess otherwise we'd have to depend on the learn action putting a rule in table 7 for tun0, which seems pointless since we know where traffic for 10.1.x.1 should go


SelectionRangeProvider not affecting ranges

Hey,
I've implemented a selectionRangeProvider which returns the correct object and get's called, as I added it to the server capatabilities.
Is there anything more I need to do? It seems like it still defaults to the VSCode default. I'm testing via setting the cursor and Expand selection. As stated, it gets called in that case, and I can debug it. What am I missing?

@Razzeee can you debug the client side as well to see if something goes bad converting it to VS Code's API. The code is here: https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/selectionRange.ts#L59

Can you advise me on how to do that? Breakpoints in the client/node_modules folder do not seem to get picked up.

Strange. This works for me by simply setting the breakpoint into the JS file.

Do you use any form of symbolic  linking.

Sorry, tried again, it seems like it just doesn't hit the error path.
I also rechecked the ranges I return and the selectionRange implementation you linked to returns. They still seem to match at that point.

This is really strange. Do any kind of breakpoints work for you. What you can do is setting a breakpoint into your extension and then step into the constructor of the LSP client to see which path the debugger has in that case.

Yeah, debugging works fine. It just doesn't seem to leave the "happy path". The results I mentioned before are from debugging my part and https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/selectionRange.ts#L59
Now that I used that link again, I originally though you wanted me break at https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/selectionRange.ts#L61 which does not happen.

According to the debugger, I'm hitting this line https://github.com/microsoft/vscode/blob/master/src/vs/workbench/api/common/extHostLanguageFeatures.ts#L1201 and for some reason https://github.com/microsoft/vscode/blob/master/src/vs/workbench/api/common/extHostLanguageFeatures.ts#L1203
None of the below. And unfortunatly, I can't access the variables.

I digged a little deeper and this seems to be a problem in VS Code itself. See https://github.com/microsoft/vscode/issues/90214
Lets see what they come up with.

OK. I think the problem is that VS Code first selects the word. If your range is larger than the word you need to execute the command a second time. This is by design.

My range is not bigger then a word. I actually execute the command multiple times, most times the first execution is still correct (probably matches with VSCodes logic) but goes of the path thereafter.
Unrelated, vscode seems to treat testVar as two words test and Var I guess?

Yes it does because of camel case.

Can you reproduce this using a simple extension like the code in microsoft/vscode#90214 ?

I'll try to look into that over the weekend, thank you for digging into this.

I'm sorry, I found my oversight. Not sure why the compiler did not help. Sorry for the noise.
https://github.com/elm-tooling/elm-language-server/pull/213/commits/10c3c65901439d7ec38d73f0aeec8991d804623c


Update y18n

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/165495
Tests

Load the app, play around with it
The changes look like it's just addressing this vulnerability

QA Steps
None
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production in version: 1.0.62-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


New Model Request: BioMistral model?

Hi,
I wonder if you have any plan to add BioMistral in library?
Thanks

Hey @unclecode, thanks for the request. I haven't tested this upload but it someone from the community has uploaded it:
https://ollama.com/cniongolo/biomistral

Nice! I actually downloaded the quantized version last night and got it running locally. I'll give this one a shot. Thanks and VIVA OLLAMA!

Hi @unclecode , can you please guide me on how I can download the quantized bnb.4 version of BioMistral? Thanks!


Initial Github build support

Fixes #14

@pamolloy Thanks for your contribution. Changes look good to me. Good to see that makefile is renamed to Makefile, it was something I was also planning to do.
One question- We do build all our projects using the Jenkins CI/CD infrastructure and artifacts are uploaded on the ADI server. Each project consists of multiple matrix combinations (basically different macros enabled for generating different binaries). E.g. https://github.com/pamolloy/precision-converters-firmware/blob/philip/linux-build-support/projects/ad4130_iio/ci_build.groovy
The git CI support that you have added, does it take care of all matrix combinations, or does it just build the default firmware combination?

One question- We do build all our projects using the Jenkins CI/CD infrastructure and artifacts are uploaded on the ADI server. Each project consists of multiple matrix combinations (basically different macros enabled for generating different binaries). E.g. https://github.com/pamolloy/precision-converters-firmware/blob/philip/linux-build-support/projects/ad4130_iio/ci_build.groovy The git CI support that you have added, does it take care of all matrix combinations, or does it just build the default firmware combination?

Wow! I thought there were already a lot of binaries. The Github CI/CD is currently building without defining any macros, but it should be pretty easy to add. Github has support for a matrix feature that I already included, but only as a one dimensional matrix. It should be simple to add, but I just created #17 to keep this PR from getting too big.

One question- We do build all our projects using the Jenkins CI/CD infrastructure and artifacts are uploaded on the ADI server. Each project consists of multiple matrix combinations (basically different macros enabled for generating different binaries). E.g. https://github.com/pamolloy/precision-converters-firmware/blob/philip/linux-build-support/projects/ad4130_iio/ci_build.groovy The git CI support that you have added, does it take care of all matrix combinations, or does it just build the default firmware combination?

Wow! I thought there were already a lot of binaries. The Github CI/CD is currently building without defining any macros, but it should be pretty easy to add. Github has support for a matrix feature that I already included, but only as a one dimensional matrix. It should be simple to add, but I just created #17 to keep this PR from getting too big.

Got it. Let me discuss internally on this. We usually build our projects using Jenkins CI/CD and that is why we have all our CI scripts present in respective projects. It's good to have git based CI build but then we need to decide if can either use git based builds or Jenkins based builds. @mike-bradley do you have any suggestions here?

@pamolloy Are you generating artifacts for the builds as well through CI scripts? e.g. this is how daily build is creating artifacts on the no-os repo. https://github.com/analogdevicesinc/no-OS/releases/tag/last_commit

@pamolloy Are you generating artifacts for the builds as well through CI scripts? e.g. this is how daily build is creating artifacts on the no-os repo. https://github.com/analogdevicesinc/no-OS/releases/tag/last_commit

Yup, the workflow using the Mbed CLI  1 directly uploads a binary for the AD4130 while the workflow using no-OS uploads binaries for all projects.
Maintaining both build systems doesn't make sense in the longer term, but for now there is nothing blocking having both. Besides the integration with Github, one nice benefit of the Github YAML is it is very concise and serves as documentation of how to build the system. Even if documentation is out-of-date the Github YAML is a fairly concise description of how to build the project (see build-no-os.yaml).
Note you'll probably also want to develop on a separate branch internally rather than committing on main in this repo and main in your internal repo.
Also, if you haven't already you may want to configure the Github repository to not use merge commits (see Rebasing and merging your commits and Configuring commit rebasing for pull requests).

@pamolloy Are you generating artifacts for the builds as well through CI scripts? e.g. this is how daily build is creating artifacts on the no-os repo. https://github.com/analogdevicesinc/no-OS/releases/tag/last_commit

Yup, the workflow using the Mbed CLI 1 directly uploads a binary for the AD4130 while the workflow using no-OS uploads binaries for all projects.
Maintaining both build systems doesn't make sense in the longer term, but for now there is nothing blocking having both. Besides the integration with Github, one nice benefit of the Github YAML is it is very concise making it easy to maintain and serves as documentation of how to build the system. Even if documentation is out-of-date the Github YAML is a fairly concise description of how to build the project (see build-no-os.yaml). Another benefit is that people who fork the repository can run the CI/CD before opening a merge request.
Note you'll probably also want to develop on a separate branch internally rather than committing on main in this repo and main in your internal repo.
Also, if you haven't already you may want to configure the Github repository to not use merge commits (see Rebasing and merging your commits and Configuring commit rebasing for pull requests).

Thanks for the reply. Make sense to have git based build system, specially for end users. Going forward we can decide if we want to have only one or both of them (i.e. Jenkins and github). I see currently it is just building the project and not doing any hardware test. Do you have testing in mind as well? We have added jenkins scripts to test the hardware as well, which relies on Mbed CLI and CMSIS-DAP hardware link to load the binary into MCU and then running pytest based python scripts to do hardware testing. Could something similar to done with github?
E.g. https://github.com/analogdevicesinc/precision-converters-firmware/blob/main/projects/ad4130_iio/ci_build.groovy#L217
https://github.com/analogdevicesinc/precision-converters-firmware/tree/main/projects/ad4130_iio/tests
I also saw open issue about building multiple FW matrixes for single project, which is great. Thanks for that: https://github.com/pamolloy/precision-converters-firmware/blob/philip/build-config-matrix/.github/workflows/build-ad4130-iio.yaml
Let me closely review PR again and discuss with team. I see there are 16 commits added for this PR, looks like those needs to be squashed together for this initial work which can be done once this work is about to be finished and ready to merge.
Thanks for other points mentioned above as well.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@pamolloy I have deleted the commits from main branch which were added to add git action based support to our repo. The files were mainly taken from this PR that you have created. Intention was that until some work is progressed on this PR, we could have basic build support present on the repo and later once this PR is ready, it can be merged back to main branch. In my last review comment also I have mentioned that this PR looks good to merge in it's current form.
Apologies not keeping you in loop while moving these changes directly into main branch. We can merge them one you are ready. We need to fix some conflicts and fix some of the review comments provided above.

In my implementation I had the following setup, which I was able to run mbed deploy:
libraries/
  no-OS <-- submodule
libs/
  no-OS.lib

The current repo looks like:
libraries/
  no-OS <-- submodule
  no-OS.lib

Now when I run mbed deploy I run into the following:
[mbed] ERROR: Library reference "CMSIS-DSP.lib" points to a folder "/home/runner/work/precision-converters-firmware/precision-converters-firmware/libraries/CMSIS-DSP", which is not a valid repository.

I've tried building as I was and also cloning the submodules first, but they result in the same error.

By moving the lib files I was able to get the project to compile, but it currently is failing on a missing include in no-OS.

Giving up for tonight. I'm not sure what changed, but I just spent a lot of time adding parts of no-OS to .mbedignore, which I didn't need to do when I had this working initially.

Giving up for tonight. I'm not sure what changed, but I just spent a lot of time adding parts of no-OS to .mbedignore, which I didn't need to do when I had this working initially.

Not sure what is the issue. We have been able to build all the mbed projects correctly using make. I have given some comments on PR so have a look if anything is missed out.
Also we should not use any customized yaml scripts for each platform. We should leverage the existing 'make' scripts from no-os to build any platform such as Mbed, STM32, Maxim, etc. That way we don't add any extra dependency on the platform here.
*Note on STM32 build: @CMinajigi  from firmware team was exploring the adaption of make files to build our STM32 projects. He has some initial observation listed down below:
At the moment STM32 build works only on Linux system and as github actions uses linux, they should work well. However we have discovered some issues using existing no-os STM32 make script. That script is written to target only STM32F4 platform by default if you run make command to build the project based on .ioc file. There is alternate target called sdk_build which can be used to build any STM32 MCU/board as it uses .ioc file to create a new project and then do the headless build. Another catch is, .ioc file needs to be placed in root directory of project and not inside STM32 folder. But this might be avoided by making changed into STM32 make script from no-os. Just wanted to give you heads-up, so that you are aware of this.
Ultimately we don't want to create any new scripts for building the projects and just rely on make script support.

In my implementation I had the following setup, with which I was able to run mbed deploy:
libraries/
  no-OS <-- submodule
libs/
  no-OS.lib

The current repo looks like:
libraries/
  no-OS <-- submodule
  no-OS.lib

Now when I run mbed deploy I run into the following:
[mbed] ERROR: Library reference "CMSIS-DSP.lib" points to a folder "/home/runner/work/precision-converters-firmware/precision-converters-firmware/libraries/CMSIS-DSP", which is not a valid repository.

I've tried building normally and also cloning the submodules first, but they result in the same error. I've reproduced the issue in a local container as well.
Note that mbed deploy appears to create directories under libs for no-OS and precision-converters-library.

@pamolloy  let's try just using libraries folder which contains both submodules and .lib files. We have been able to build all the projects with this approach (both with make scripts from no-os repo and with online keil studio). We should create unnecessary confusion by creating another folder for .lib files.

Closing this since the series has been broken up into separate pull requests.


FFI Strategy

Strategy for exposing OpenDP Library functionality via FFI, so that bindings can be created for different languages:

[x] Work out approach for constructors, combinators and invocation.
[x] Define C-compatible data structures
[x] Decide on support for generic types and functions
[x] Specify policy around memory management
[x] Prototype a few examples
[x] Write design overview

On second thought, I think the memory management strategy (Python responsible for freeing allocations) is reasonable for now. Moving this back to OpenDP-Experimental, as that's where all the initial design issues were.
I've opened #22 for some related stuff.


Update request: hyprlandPlugins.hypr-dynamic-cursors 0-unstable-2024-11-10 → 0-unstable-2024-11-19

Package Information

Package name: hypr-dynamic-cursors
Latest released version: no current release; latest working commit = 81f4b964f997a3174596ef22c7a1dee8a5f616c7 on 2024-11-18
Current version on the unstable channel: commit a3427f2a7f1dc70236dbaa870eadead03d9807a6
Current version on the stable/release channel: commit a3427f2a7f1dc70236dbaa870eadead03d9807a6

Checklist

[x] Checked the nixpkgs pull requests

Notify maintainers
@donovanglover

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Most recent commit didn't seem to be able to compile.
The current revision being used by nixpkgs master causes hyprland to crash on my machine. The commit to which I'm requesting this package be bumped fixes this crash.


Zero Length Packets

Do we want/need the ability to send zero length packets in JACDAC?
With a size field of 8 bits, we have 255 possible values: 0 - 254. Therefore the maximum packet size is 254 bytes.
If we think it's important to support 255 bytes, we could make it so that zero length packets are not possible and that the value of size is size + 1 (i.e. 0 = 1, 1 = 2 etc.)
Thoughts?

Is there a scenario for this? Some kind of ping? Seems like control packets already do that.

I guess you could implement an ACK using a ZLP, but normally you want to know if it's an ack by having a status byte...

I would say keep it simple and allow zlp

BTW you have 256 possible values

Hahahahaha, I'm big dingus... 0 - 255 it is.


Update what-are-tabs.md

Minor change

Docs Build status updates of commit 8ae7e97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Feature request: GCP: provide toggle to disable IPv6 FW rule

Global forwarding rules are not cheap on GCP. In my case, they account for just a bit less than half the cost for a 3 n1-standard-1 premptible nodes cluster.
An extra Ipv6 address and forwarding rule was introduced in https://github.com/poseidon/typhoon/commit/5be5b261e2a6a4c7628b80a2ae3deb626ba7a945 Would you accept a PR that introduce a variable/toggle to optionally not create those resources ?

https://twitter.com/dghubble/status/1074186919087468544
I'm keenly aware GCP charges this way and I agree its annoying. I pay for my own clusters, so I get it. But I designed it this way because I believe IPv6 adoption is important enough. I have ensured only 5 global forwarding rules are created - since GCP charges for the first batch of 5, its the same cost for folks with one cluster in their project.
As for additional variables to disable IPv6, I'd prefer not to for several reasons. First, my aim is to go in the opposite direction so that Ingress is exposed via an IPv4 and IPv6 address on every platform, consistently and simply out of the box. I don't want to create a situation where someone chooses between IPv6 adoption and cutting costs. I disagree with GCP's decision to charge separately for IPv6 rules and dislike the idea of adding complexity here to accomodate their decisions (e.g. Google Cloud has the resources to be encouraging IPv6 adoption here, but instead the asks bubble up to this project to add/document special casing and possibly turn off IPv6). Finally, if any forwarding rules were to be made optional, it should be the IPv4 ones over the very long term.

Understood, fair enough.


[api] Adds NamedEntity.toString() function

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report
Patch coverage: 73.96% and project coverage change: +1.73 :tada:

Comparison is base (bb5073f) 72.08% compared to head (56e21d5) 73.81%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2468      +/-   ##
============================================
+ Coverage     72.08%   73.81%   +1.73%
- Complexity     5126     6825    +1699
============================================
  Files           473      675     +202
  Lines         21970    29786    +7816
  Branches       2351     3065     +714
============================================
+ Hits          15838    21988    +6150
- Misses         4925     6310    +1385
- Partials       1207     1488     +281

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
67.10% <0.00%> (+7.89%)
:arrow_up:

api/src/main/java/ai/djl/modality/nlp/Decoder.java
63.63% <ø> (ø)

... and 228 more

... and 342 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Put a page inside its own viewController

Hi everyone
I have a problem with the page, I want to put inside a custom view, but, I can't find a way to do it, someone who has done something similar, please with your help. I leave an image with what I want to do
Thanks
Thanks

I'm not sure how this is actually related to XCoordinator. Closing this - if you happen to have a XCoordinator-related question, feel free to open new issues or reopen this one.


IL2CPP Support?

this is tool support IL2CPP Env?

Sure.
On Wed, 21 Feb 2024 at 03:39, NicoIer @.***> wrote:

this is tool support IL2CPP Env?
—
Reply to this email directly, view it on GitHub
https://github.com/elringus/unity-console/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPWFIEF3Q4TVKGMO7S2TKDYUU62JAVCNFSM6AAAAABDSDJM4CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DKNJUGQYTAMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Push Plugin register failed - Confirmation popup is shown

Hi,
the registration event is not being triggered. In the xcode logs I see the error "Push Plugin register failed". Since I saw in this forum that it is usually due to the provisioning profiles, I generated them again and double / triple checked them. It should actually be working.
The APNS message "Do you allow this app to send you notifications..." is shown when the app is launched.
The most wierd thing is that the notifications were working perfectly (in dev and in prod) with other provisioning profiles.
Thanks and regards,
Carlos

This repo is deprecated, please go to phonegap/phonegap-plugin-push.


Add Dockerfile

This change adds a Dockerfile and a GitHub Action for building it.
The built Docker image gets pushed to the GitHub Registry. ⚠ Imortant: GitHub does not allow to delete those images! Therefore I am not sure if you want to have this here and I am fine with removing it.
An example image looks like this: https://github.com/svenwltr/syncthing_exporter/packages/556931

Hi @svenwltr, thank you for PR. I have some thoughts, since github and docker implement some restrictions.
Would it better if syncthing will be downloaded during image build?

Hi @svenwltr, thank you for PR. I have some thoughts, since github and docker implement some restrictions.
Would it better if syncthing will be downloaded during image build?

Hello @f100024. What limitations do you mean? It is not usual to have additional applications in the exporter image.

Hello @f100024. What limitations do you mean? It is not usual to have additional applications in the exporter image.

As you already said github limitations related to deletion public docker registry [link].
Some docker hub limitations on client side from docker hub [link]

It is not usual to have additional applications in the exporter image.

Sure I didn't mean that. I mean why not use Dockerfile with pre-downloaded exporter from github releases?
For example something like this:
FROM alpine:3.12.0

ENV EXPORTER_VERSION 0.2.1
ENV EXPORTER_ITEM exporter-${EXPORTER_VERSION}.linux-amd64
ENV EXPORTER_URL https://github.com/exporter/...

RUN apk add --no-cache curl

RUN curl -s -L -o ${EXPORTER_ITEM}.tar.gz ${EXPORTER_URL}
RUN tar -xzvf ${EXPORTER_ITEM}.tar.gz && mv /${EXPORTER_ITEM}/ /exporter/ && rm ${EXPORTER_ITEM}.tar.gz

EXPOSE 9093

ENTRYPOINT [ "/exporter" ]
CMD        [ "--parameter=1",  ]

Of course you wont' get latest image, but wont' be dependent from other external services.
For which cases you need to use prebuilt images, except of built images on your host? :)

As you already said github limitations related to deletion public docker registry [link].
Some docker hub limitations on client side from docker hub [link]

It is not usual to have additional applications in the exporter image.

Sure I didn't mean that. I mean why not use Dockerfile with pre-downloaded exporter from github releases?
For example something like this:
FROM alpine:3.12.0

ENV EXPORTER_VERSION 0.2.1
ENV EXPORTER_ITEM exporter-${EXPORTER_VERSION}.linux-amd64
ENV EXPORTER_URL https://github.com/exporter/...

RUN apk add --no-cache curl

RUN curl -s -L -o ${EXPORTER_ITEM}.tar.gz ${EXPORTER_URL}
RUN tar -xzvf ${EXPORTER_ITEM}.tar.gz && mv /${EXPORTER_ITEM}/ /exporter/ && rm ${EXPORTER_ITEM}.tar.gz

EXPOSE 9093

ENTRYPOINT [ "/exporter" ]
CMD        [ "--parameter=1",  ]

Of course you wont' get latest image, but wont' be dependent from other external services.
For which cases you need to use prebuilt images, except of built images on your host? :)

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

For which cases you need to use prebuilt images, except of built images on your host? :)

I am running this in a Kubernetes cluster, where I need to have all images on a registry. Of course this does not need to be public, so I always can fallback to my private one.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

For which cases you need to use prebuilt images, except of built images on your host? :)

I am running this in a Kubernetes cluster, where I need to have all images on a registry. Of course this does not need to be public, so I always can fallback to my private one.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

For which cases you need to use prebuilt images, except of built images on your host? :)

I am running this in a Kubernetes cluster, where I need to have all images on a registry. Of course this does not need to be public, so I always can fallback to my private one.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

For which cases you need to use prebuilt images, except of built images on your host? :)

I am running this in a Kubernetes cluster, where I need to have all images on a registry. Of course this does not need to be public, so I always can fallback to my private one.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

User won't locked with repository which could be deleted or something else.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

User won't locked with repository which could be deleted or something else.

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

User won't locked with repository which could be deleted or something else.

This is an argument against providing a ready-to-pull Docker image at all, or am I understanding something wrong?

I do not understand how downloading the exporter during the image build solves those limitations. Also, the Docker Hub limitations is unrelated, if the image is stored on the GitHub Registry.

User won't locked with repository which could be deleted or something else.

This is an argument against providing a ready-to-pull Docker image at all, or am I understanding something wrong?

This is an argument against providing a ready-to-pull Docker image at all, or am I understanding something wrong?

Yes. I understand you, will merge it, thanks!

This is an argument against providing a ready-to-pull Docker image at all, or am I understanding something wrong?

Yes. I understand you, will merge it, thanks!

@svenwltr Thank you for your request and contribution!
You can check image:
docker pull f100024/syncthing_exporter:0.2.3

If you have any other suggestions, feel free to create new issue.


[Bug] [AUTHZ]  masked column cannot be used as a filter condition

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
There is a table named test_student_02, which contains data of students who are around 18 years old. The "age" column has been hashed for data masking. When using the following SQL query, no data can be retrieved.
var ds4 = spark.sql("select * from user02db.test_student_02 where age > 18");
ds4.explain(true);
'Project [*]
+- 'Filter ('age > 18)
+- 'UnresolvedRelation user02db.test_student_02
== Analyzed Logical Plan ==
id: int, name: string, sex: boolean, age: string, department: string
Project [id#18, name#19, sex#23, age#24, department#22]
+- Filter (cast(age#24 as int) > 18)
+- SubqueryAlias user02db.test_student_02
+- Filter (department#22 = IS)
+- RowFilterMarker
+- DataMaskingStage0Marker HiveTableRelation user02db.test_student_02, org.apache.hadoop.hive.ql.io.orc.OrcSerde, [id#18, name#19, sex#20, age#21, department#22]
+- Project [id#18, name#19, (0 = 0) AS sex#23, md5(cast(cast(age#21 as string) as binary)) AS age#24, department#22]
+- Relation[id#18,name#19,sex#20,age#21,department#22] orc
== Optimized Logical Plan ==
Project [id#18, name#19, true AS sex#23, md5(cast(cast(age#21 as string) as binary)) AS age#24, department#22]
+- Filter ((isnotnull(department#22) && (department#22 = IS)) && (cast(md5(cast(cast(age#21 as string) as binary)) as int) > 18))
+- Relation[id#18,name#19,sex#20,age#21,department#22] orc
Affects Version(s)
master
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

This should be an expected behavior. If the user's condition is age=18, then the user can know which students are exactly 18 years old, which is unreasonable for data security.

@packyan You didn't really understand what I meant. test_student_02 contains data of students who are over 18 years old. Therefore, regardless of whether or not the 'age' column has been masked, the first step should be to query this data. Secondly, if there is masking, it should be applied to the 'age' column in the query results.
你没有真正理解我表达的意思。 test_student_02包含了“age”大于18岁的数据，所以无论有没有在“age”上进行脱敏，首先应该是要查询出来这些数据的，其次， 如果有脱敏的话，是在查询的结果集上再对“age”进行脱敏。

(cast(md5(cast(cast(age#21 as string) as binary)) as int) > 18) in the Optimized Logical Plan is completely wrong now. Its current meaning is to compare the result of the 'age' column after applying the MD5 function with the value 18.

@yaooqinn Could you please take a look at this,thx.

As @packyan explained, it's by design.
The data is masked on the leaf scan. A user can not do a filter operation on a column if the admin has set a masker on it for him/her.


Add notes to Mula commands

To be used in transaction insertion and tracking for all mula commands

Just an extra parameter


Display relevant/irrelevant random prior candidates

This PR aims to display both relevant and irrelevant random records when adding prior knowledge in Exploration and Simulation modes. Improvements are still needed on the back end to improve efficiency.

Nice step forward!


fixes #59

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #83   +/-   ##
======================================
  Coverage    95.6%   95.6%
======================================
  Files          65      65
  Lines         750     750
  Branches      103     104    +1
======================================
  Hits          717     717
  Misses         11      11
  Partials       22      22

Impacted Files
Coverage Δ

lib/annotations/validation/Length.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f8b3f...280d422. Read the comment docs.


[Merged by Bors] - Derive default for enums where possible

Objective
Fixes #5153
Solution
Search for all enums and manually check if they have default impls that can use this new derive.
By my reckoning:

enum
num

total
159

has default impl
29

default is unit variant
23

Found a couple more:
https://github.com/rparrett/bevy/blob/c27a3cff6d593e1b1220886673018a508aaa785d/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs#L39
https://github.com/rparrett/bevy/blob/fb813a3a64cdafdd75f7590a461364bcdf34bf2e/crates/bevy_reflect/bevy_reflect_derive/src/field_attributes.rs#L37

Found a couple that were missed: https://github.com/rparrett/bevy/blob/c27a3cff6d593e1b1220886673018a508aaa785d/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs#L39 https://github.com/rparrett/bevy/blob/fb813a3a64cdafdd75f7590a461364bcdf34bf2e/crates/bevy_reflect/bevy_reflect_derive/src/field_attributes.rs#L37

Thanks. Looks like I missed pub(crate) enums. Will do a sweep for those.

Of the 10 pub(crate) enums, only those two were relevant.

bors r+

Update your Rust version using rustup update :)

I've already done it:
bevy/examples/2d  main ✔                                                                   5h39m  ⍉
▶ rustup update
info: syncing channel updates for 'stable-x86_64-apple-darwin'
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: checking for self-updates

   stable-x86_64-apple-darwin unchanged - rustc 1.62.1 (e092d0b6b 2022-07-16)
  nightly-x86_64-apple-darwin unchanged - rustc 1.64.0-nightly (9a7b7d5e5 2022-07-19)

info: cleaning up downloads & tmp directories

bevy/examples/2d  main ✔

done all these steps and still(

Hmm. Perhaps you're running Bevy with an old Rust version via some project specific configuration? I would try a fresh example project, where you just define a toy enum and use this feature.
Either way, I would delete your Bevy folder and clone it again from scratch.

sounds OK, I'll try, thanks

a few commands to check your rust versions:

rustup show shows everything
rustup toolchain list shows all toolchains installed
rustup overrides list shows if there are overrides from rustup
cargo rustc -- --version shows rustc version used by cargo, but I think it needs to compile to work


Add svg maps implementation

Implements a bunch of functionality needed to visualize analysis
output data into svg maps using only reagent/re-frame as a dependency.
Client side highlights :

Implements a svg-renderer to render geojson maps with reagent
Implement a reagent animated map component, capable of rendering data
at different points in time and animate it.
Add a test page for maps under /map, to retrieve a analysis by id
and render it on a map

Server side highlights :

Add all maps encoded as geojson resources
Add functionality to upload map files to a S3 bucket
Add maps to graphql analysis schema (only continuous tree so far)

Yeah all this is just to get the map stuff merged into master so we can move from there.

my major one is that I imagined the renderer to be a separate client application (separate cljs build), running in it's own process w-out even calling graphQL

I didn't knew that but is completely possible, and probably a good idea also.
I can decouple that after the merge if you want, or I can also do it now before merge it, same for me.


Resources that start with S3 are incorrectly being parsed as empty buckets

https://github.com/awslabs/aws-control-tower-customizations/blob/8076f8feffeb0025431739df762b017a42db6470/source/manifest/manifest_parser.py#L364
I believe this should be 's3://'.
I had created a resource that was named S3BPA and the code assumed it was a bucket (which didn't exist).

Thanks for bringing this our attention. We have added this our backlog.

This issue has been fixed.


beforeAll/afterAll

Nice library!
As far as I understand, setUp and tearDown are called for each test. Most time when testing Akka code one want's to create and terminate an ActorSystem once for the whole test suite. ScalaTest facilitates this with mixing in BeforeAndAfterAll.
Do you think this is something that you also want to consider for minitest?

It would be great to have methods like setUpSuite and tearDownSuite. I've tried to play with minitest code a bit to add it, but I guess it won't be possible without breaking changes.
@alexandru would you consider adding it? - is it worth for me to clean up my changes and submit PR? 😉

@hseeberger @kkafara @MansurAshraf thanks for your patience.
Due to PR #9 it's in the latest release, version 2.1.0.


not found: key not found

Summary of Bug

An error occurs when an account that is not registered in the account state of the chain executes a transaction.
❯ lbm tx wasm execute $CONTRACT "$TRANSFER" --from operator1 --gas-prices="0.025link" --gas="auto" --gas-adjustment="1.2" -y --keyring-backend=test --chain-id=lbm
Error: rpc error: code = NotFound desc = rpc error: code = NotFound desc = account link159mhuncqw4g9dsrayzf0lq45aftmtykn886rv5 not found: key not found

Version

Steps to Reproduce

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

https://github.com/CosmWasm/wasmd/issues/925

The problem is not that the address specified in the from field is not found, but that the address that received the token when contract was executed is not registered in the chain.
Unlike another module such as bank, x/wasm does not know in advance what msg to execute in contract.
Therefore, even if parameters such as to_address and receiver exist in msg, address cannot be registered in chain.
This is not easy to solve within x/wasm, so it is handled by performing an operation to register the address in the chain with a separate command.


Opera Browser Detection not working

Hello, I am new in using this library and somehow, it is good.
But in my testing, I discovered that it cannot detect Opera. It otherwise returned Google Chrome. When I looked in my database, the agent returned "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36 OPR/27.0.1689.76" and I guessed that the library reads the "Chrome" string and not the OPR. Please fix this issue.
Thanks.

Should be fixed now.

Sorry for the late reply Sir.
It is still not working in my case. Here is the screenshot.


Set correct definition for application and project words

/cc @jodosha

I kinda like the wording project than application as it might be less confusing for users, but if we are to accept this PR, we need to update our API docs thoroughly too

I kinda like the wording project than application as it might be less confusing for users, but if we are to accept this PR, we need to update our API docs thoroughly too

@joneslee85 no problem. I can send PR with this changes to documentation too :blush:

@joneslee85 no problem. I can send PR with this changes to documentation too :blush:

@joneslee85 The next version of the guides https://github.com/lotus/lotus.github.io/pull/114 is ready with the new terminology. I asked @davydovanton to open this PR.

@joneslee85 The next version of the guides https://github.com/lotus/lotus.github.io/pull/114 is ready with the new terminology. I asked @davydovanton to open this PR.

thanks for merge, @jodosha! :+1:

thanks for merge, @jodosha! :+1:


Update README.md to fix spelling change.

Sorry it bugged me :)

Gah, I make that typo constantly! Merged as 754ba77.


Fixed uglify webpack plugin for production

Here Uglify is a class, so it's required to new it.
Original exception:
[1/2] 🖨  Copied src/manifest.json in 49ms
(node:2593) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot call a class as a function
(node:2593) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Even though it fixes exception, I didn't get minified output. But that's for another PR.
Nevermind, seems that's due to my TypeScript usage, have deal with it inside webpack.skpm.config.js.

thanks!


CLI-8 # Commands exiting with incorrect code

Fixed

CLI-8: Fixed commands exiting with incorrect code when errors are thrown

Looks Good


Add subLabel to TextInput

A little description for the TextInput.
Not available for type='outline'.

Added in 0.50.0


click on evoked.plot to get butterfly plot

currently one can click on a line of evoked.plot to get channel name.
it would be great to be able to click on an empty region to plot the topomap of this time instant.
A more advanced used case could be to be able to select a time interval in which data is averaged to produce the topomap

maybe for @jaeilepp

A more advanced used case could be to be able to select a time interval in which data is averaged to produce the topomap

I like this! +1

Sounds good, but maybe trigger it by something other than a left click in
empty space. It's pretty easy to accidentally click in space when trying to
click a line/channel, and it would be annoying to have a plot pop up due to
such a minor click miss. So maybe middle or right click instead.

fine with me


[GEP-18] Sync CA bundle to garden

How to categorize this PR?

/area security
/kind enhancement
/merge squash
What this PR does / why we need it:

sync CA bundle to garden (new secret <shoot-name>.ca-cluster)
sync CA bundle to kubeconfig secret (regressed by https://github.com/gardener/gardener/pull/5524)

This is done to decouple external components from the ShootState for retrieving the CA certificate.
Also, once CAs are rotated, there won't be a single CA cert in the ShootState anymore but multiple ones. The new dedicated ca-cluster secret will always contain the current CA bundle and is safe and easier to rely on in that sense.
(cc @holgerkoser @petersutter)
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/3292#issuecomment-1036058890
Special notes for your reviewer:
:x: I still have to check how we are going to deal with the added secret in terms of project quota (in draft until this is clarified).
Release note:

There is a new Secret for each Shoot in the corresponding Project Namespace (`<shoot-name>.ca-cluster`) which contains the current CA bundle for establishing trust to the Shoot's API server.

/test pull-gardener-e2e-kind

/cc @grolu
/assign

/retest

/test pull-gardener-e2e-kind

I found a problem with this PR. At first, I thought the e2e job flaked, as I didn't see any test output in https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/5612/pull-gardener-e2e-kind/1504868779409018880.
However, when reproducing it locally, shoots are failing to be created with:
  Warning  ReconcileError  19s (x9 over 4m29s)   gardenlet  Flow "Shoot cluster reconciliation" encountered task errors: [task "Initializing secrets management" failed: retry failed with context deadline exceeded, last error: admission webhook "seed-restriction.gardener.cloud" denied the request: object does not belong to seed "local"]

Something seems to be wrong with our ginkgo timeouts or error reporting. It would be great to enhance that, so that folks don't need to reproduce this kind of error locally.

I have also seen the following error again. I observed this multiple times already on first creation of shoots:
task "Persisting etcd encryption configuration in ShootState" failed: Operation cannot be fulfilled on shootstates.core.gardener.cloud "default-6zh2r": the object has been modified; please apply your changes to the latest version and try again

That's because there is no retry for the flow task or the actual patch in https://github.com/gardener/gardener/blob/7ac4b04feec409f3e5a5208cd06af9a10c755337/pkg/operation/operation.go#L579-L581
However, the secret handling of the etcd encryption secret is going to change with https://github.com/gardener/gardener/pull/5616. So we probably don't need to do anything about it for now.

As there is no default resourcequota, the only thing we can/should do for adapting to the new secret is to leave a release note of category "breaking" for operators.
After adapting the seed admission and auth, I marked the PR as ready accordingly.


Add support for non-numeric LangVersion in Razor code generation

I have a Preview5 project with <LangVersion>latest</LangVersion> currently corresponding to C# 7.3 and Razor code generation handles that as if it was C# 8 adding #nullable annotations to the .g.cs files which then result in compilation error CS8652 "The feature 'nullable reference types' is currently in Preview".
https://github.com/aspnet/AspNetCore-Tooling/blob/c9e0d2a60f7287d14c282555669b67a1000fef20/src/Razor/src/Microsoft.CodeAnalysis.Razor/RazorProjectEngineBuilderExtensions.cs#L53
The LanguageVersion.Latest enum member is int.MaxValue and thus numerically larger than C# 8 while meaning something below. The other two named members LatestMajor and Preview should probably be handled specifically as well.
As a workaround, I'm running with <LangVersion>7.3</LangVersion>, which fixes the code generation

Thanks for contacting us, @Tragetaschen.
@NTaylorMullen thoughts?

Just verified, this is a bug on our side where we're interpreting C#'s latest version as 8.0 but in reality it's not. I wonder if this was missed from the get-go or if this was changed after-the-fact, that will take more investigation.

I was curious about what Roslyn provides in terms of LangVersion helpers. At worst, this is old news :)
https://github.com/gafter/roslyn/blob/master/src/Compilers/CSharp/Portable/LanguageVersion.cs#L352

Ooo @Tragetaschen that's awesome! Thank you for the code link, we'll definitely use that.


fix the result of left semi join with empty right side should be false instead of null

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


Fix Introduction.html.tpl

Hi,
I found this problem when reviewing the code documentation. Especially when there are params on the description. The $param['name'] seems to be missing and frapi stops to function properly since the param['name'] is not set or missing.
This update will try to fix that.
This is the 4th Frapi installation I made, 2 of them are payment heavy API. Very good API core solution that fits my need.

Hi guys or trevor, this is a quick fix.


[Feature][Task] Delay should support second level.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
now delay just support min level, should we support second level?
Use case
DS can support delay xx seconds.
Related issues
Question: https://github.com/apache/dolphinscheduler/discussions/12188
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Amy0104 could u please add a Discussion label?
we need discuss do we need to support this level. cc @caishunfeng @ruanwenjun @SbloodyS


User roles

Is your feature request related to a problem? Please describe.
If I want to share my connectivity data with a third person I don't want them to able to alter anything. so a "view only" user class would be good.
Describe the solution you'd like
Users are already implemented, what is needed is a user level/role field in the database to only show dashboard and results.
Additional context
This is way down in the prioritization list, it was an idea that popped into my head.
And as always, I leave it to Alex to decide if/when it will be implemented.

Updated the title to reflect the ask, will introduce user roles in a future release. High level tasks...

Have 3 levels of users admin, user, and visitor
Prevent the deletion of the admin user if no other admin users exist
admin users can do everything
user users can do some basic things
visitor users can only read results and view the dashboard

A much more structured and eloquent statement of my suggestion.
Looks very good, I don't have any notes.


Can't load extensions

I'm using the lens in an air gap environment. Extensions are kept on loading and can't upload a TGZ file.

Any logs?

I found this in npm-cache folder.
43 silly fetchPackageMetaData error for<EMAIL_ADDRESS>request to https://registry.npmjs.org/react-open-doodles failed, reason: self signed certificate in certificate chain
44 timing stage:rollbackFailedOptional Completed in 2ms

No I meant https://docs.k8slens.dev/main/faq/?h=logs#where-can-i-find-application-logs

�[32minfo�[39m: [PROTOCOL ROUTER]: internal registering /cluster/:clusterId
�[32minfo�[39m: [PROTOCOL ROUTER]: internal registering /cluster/:clusterId/settings
�[32minfo�[39m: [PROTOCOL ROUTER]: internal registering /extensions
�[32minfo�[39m: [PROTOCOL ROUTER]: internal registering /extensions/install/:LENS_INTERNAL_EXTENSION_PUBLISHER_MATCH(@[A-Za-z0-9_]+)?/:LENS_INTERNAL_EXTENSION_NAME_MATCH
�[31merror�[39m: Can't find working API for the Kubernetes resource ingresses
�[32minfo�[39m: [StorageHelper]: loading finished for C:\Users\user\AppData\Roaming\Lens\lens-local-storage\app.json

We need more logs, can you run in debug mode and post the whole log file?

This is resolved. I removed .k8slens folder in the home directory and reinstalled the lens. It's working now.


Generate and review validation reports: UCLA Medicine (repository #229)

Step 2: Generate reports

[x] Generate validation reports (run validate_by_mapper DAG): https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/validate_by_mapper_type/grid?dag_run_id=manual__2024-01-31T20%3A52%3A30%2B00%3A00
[x] Add a comment (in this issue) to the output URLs
[ ] Download the validation reports locally; prepend the collection registry number to the filename
[ ] Upload validation reports to the Rikolti Data Validation folder

Step 3: Review reports

[ ] Review sample collections validation reports; leave notes in the spreadsheet
[ ] Quickly (and not very deeply) scan through other validation reports (to identify if any new metadata fields surface)
[ ] Synthesize notes at the mapper level
[ ] Share an update (and surface any anomalies) during a weekly check-in (Mondays at 3:00pm)

Step 4: Have data validation issues? Address & resolve validation issues (synthesized mapper-level):

[ ] Create a new issue (“Validation results: Rikolti mapper name“) and report/request fixes & investigations. Add to current sprint.
[ ] Add a comment to link to the new “validation results” issue.
[ ] Add a “blocked/paused” label to this issue. Include a status note in this issue title (e,g., HOLD for fixes; HOLD for code review; etc.)
[ ] Move this issue back to the “To Do” pile.
[ ] Reset tasks listed in steps 2-3 above; re-generate & re-review (repeat steps 2-3 above, as needed.)

Step 5: Have acceptable validation reports?

[ ] Move the valid (accepted) reports to the “VALID” folder in google drive.

[2024-01-31, 20:53:32 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/26853/vernacular_metadata_2024-01-31T20:53:00/mapped_metadata_2024-01-31T20:53:15/validation_2024-01-31T20:53:32.csv
[2024-01-31, 20:53:32 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#26853/vernacular_metadata_2024-01-31T20:53:00/mapped_metadata_2024-01-31T20:53:15/data/

Accepted on 2024-02-05!


[opt-remark] Add @_semantics("optremark{.$SIL_PASS_NAME}") that force opt remarks on functions.

This PR contains two commits. The first commit does a little bit of cleanup in preparation for the first by cleaning up some remarks [mainly b/c I noticed when playing with this in Xcode, they looked really bad = (, so I wanted to fix them a little].
The second commit is more interesting. I'll let its commit msg speak for itself:

More specifically, if one wants to force emit /all/ opt-remarks on a function, mark it with:
```
@_semantics("optremark")
```

If one wants to emit opt-remarks only for a specific SIL pass (like lets say
sil-opt-remark-gen), one can write:

```
@_semantics("optremark.sil-opt-remark-gen")
```

I made the pattern matching strict so if you just put in a '.' or add additional
suffixes, it will not pattern match. I think that this is sufficient for a
prototyping tool.

This is useful if one wants to play around with opt-remarks when optimizing code
in Xcode or any IDE that can use serialized diagnostics.

@swift-ci smoke test


add slides for talk 2024-06-25 Inspecting and Manipulating Running Co…

…ntainers

Thank you for the slides @strima :)


Materialize Dictionaries in Group Keys

Is your feature request related to a problem or challenge?
Currently grouping on a dictionary column will return dictionary-encoded group keys. Given that group keys inherently have few repeated values, especially when grouping on a single column, the use of dictionary encoding is unlikely to be yielding significant returns. Additionally following https://github.com/apache/arrow-datafusion/pull/7587 computing the dictionary is a non-trivial operation that could be eliminated
Describe the solution you'd like
When grouping on a dictionary column, e.g. Dictionary(DataType::Int32, DataType::Utf8), the returned schema should be the underlying value type, i.e. DataType::Utf8.
Describe alternatives you've considered
No response
Additional context
No response

Hi @tustvold
I wanted to look into this ticket, I see the TODO you've left in #7587. Could you advise me some easy way to to simulate this situation e.g. in datafusion-cli or maybe there is some similar test in the code base?

You can great dictionary encoded columns using arrow_cast
Here is an example https://github.com/apache/arrow-datafusion/blob/e23d34bae60bb2f9c496241e218bab795af3af83/datafusion/sqllogictest/test_files/aggregate.slt#L2207-L2227
(though it might be helpful to use more than a single column)

@tustvold I've spent some time getting familiar with the code for aggregations and I have a couple of questions. Maybe you could help me here?
I see that for aggregates in an initial plan we have in the base case 2 nested AggregateExecs: Partial and Final(Partitioned). And every AggregateExec uses RowConverter to convert arrays into rows for its input and back from rows into arrays for its output.
I assume that these conversions are basically inevitable because RecordBatches are sent between execution stages and aggregation internally operates on rows, not arrays, is my understanding correct here?
It looks to me that it makes sense to convert from Dictionary to Utf8 on the first AggregateExec but it doesn't look like there's no mode like AggregateInitial. What could be the proper way out here? Maybe there could be a conversion step before aggregation added if any of the fields has a dictionary type? What would you advise?

@alamb maybe you could help me here?

You should not need to do any conversion, the conversion is already being done by RowConverter. Currently there is a cast annotated with a TODO linking back to this ticket. It should just be a case of removing this TODO and updating the schema logic within the plan to account for this

@tustvold I saw the conversion in RowConverter but as I understand it happens multiple times: i.e. we convert dictionary into utf8 in AggregatePartial, then cast results back to dictionary and then we do the same in AggregateFinal.
Please let me know if I get your idea right: in the case of AggregatePartial followed by AggregateFinal, the schema for the first one should have Utf8 as its output and the second aggregate will then use Utf8 both as its input and as output.

TLDR I recommend we revert this change and reopen this ticket while we reconsider how to handle this case better.
Background
This ticket caused a functional regression for us downstream in https://github.com/apache/arrow-datafusion/issues/8738 (a query that used to run started erroring).
The cause of the issue is that the LogicalPlan and ExecutionPlans schemas no longer match. I started exploring making them match in https://github.com/apache/arrow-datafusion/pull/8766
However while working on that issue,  I thought more about this change and I am not sure the change described in this issue is good for multi column groupings at all.
Rationale
Dictionary Encoding on single column group keys is bad  because there is no repetition in the data and therefore the Dictionary encoding is pure over head. For example, given
SELECT ... GROUP BY a

Dictionary Encoding is worse than native encoding:
┌──────┐                   ┌──────┐      ┌────┐
│ foo  │                   │ foo  │      │ 0  │
├──────┤                   ├──────┤      ├────┤
│ bar  │                   │ bar  │      │ 1  │
├──────┤                   ├──────┤      ├────┤
│ baz  │  ────────▶        │ baz  │      │ 2  │
├──────┤                   ├──────┤      ├────┤
│  ff  │                   │  ff  │      │ 3  │
├──────┤                   ├──────┤      ├────┤
│  ..  │                   │  ..  │      │ .. │
├──────┤                   ├──────┤      ├────┤
│ aaz  │                   │ aaz  │      │9999│
└──────┘                   └──────┘      └────┘

 Group Values            values array   keys array
   (distinct
 values of a)

However, the story is different when there is a multi column group key, as in that case, dictionary encoding each column can be a significant performance improvement as they are applied to each column individually and each column may have substantial redundancy. For example, given this query
SELECT ... GROUP BY a,b

┌──────┐  ┌──────┐               ┌──────┐      ┌────┐         ┌──────┐      ┌────┐
│ foo  │  │ tag1 │               │ foo  │      │ 0  │         │ tag1 │      │ 0  │
├──────┤  ├──────┤               ├──────┤      ├────┤         ├──────┤      ├────┤
│ foo  │  │ tag2 │               │ baz  │      │ 0  │         │ tag2 │      │ 1  │
├──────┤  ├──────┤               └──────┘      ├────┤         ├──────┤      ├────┤
│ foo  │  │ tag3 │ ────────▶                   │ 0  │         │ tag3 │      │ 2  │
├──────┤  ├──────┤                             ├────┤         ├──────┤      ├────┤
│ foo  │  │ tag4 │                             │ 0  │         │ tag4 │      │ 3  │
├──────┤  ├──────┤                             ├────┤         └──────┘      ├────┤
│  ..  │  │  ..  │                             │ .. │                       │ .. │
├──────┤  ├──────┤                             ├────┤                       ├────┤
│ baz  │  │ tag4 │                             │ 1  │                       │ 3  │
└──────┘  └──────┘                             └────┘                       └────┘

       Group Values            values array   keys array    values array   keys array
    (distinct values of             (a)           (a)            (b)           (b)
           a,b)

This could especially impact multi-phase grouping where dictionary encoding will save significant time hashing values for low cardinality string columns.
In fact we think we may have seen a performance regression when picking up this change downstream as well, which could also be explained by the observation abive
Thus I recommend we revert this change via https://github.com/apache/arrow-datafusion/pull/8740 while we reconsider how to handle this case (maybe just for single column group by? Maybe do the dictionary encoding within the RowEncoder to avoid generating many redudant strings?

This could especially impact multi-phase grouping where dictionary encoding will save significant time hashing values for low cardinality string columns.

If anything this is precisely the case where the old behaviour was especially inefficient. It will compute the rows, expanding the dictionary, perform the grouping, convert the rows back to strings, convert the strings back to dictionaries, convert back to strings in the row format, again expanding the dictionaries, and repeat for each stage

I want to be clear that I have no particular evidence one way or the other about the performance implications of this particular change (and I probably confused the issue with speculation in https://github.com/apache/arrow-datafusion/issues/7647#issuecomment-1879161073)
So what I would like to do is:

Revert the change
Reopen this ticket
Work on getting a PR ready to put the change back in that both 1) doesn't cause a functional regression and 2) we have evidence improves performance

@alamb what could be some evidence for 3.2? Is there anything in the code base or maybe in some other ticket? The plan you show makes total sense

Thanks @qrilka

@alamb what could be some evidence for 3.2?

I think we need to create a benchmark that does aggregation queries on dictionary encoded string columns (I know the existing end to end TPCH, and ClickBench benchmarks do not do this). I will file a ticket shortly about this

I filed https://github.com/apache/arrow-datafusion/issues/8791 to track adding additional test coverage, and I plan to work on that in the next few days


U can't use command from readme

meteor add<EMAIL_ADDRESS>does not work.. So it is better to write the command that works, or remove meteor section completly?
see https://github.com/twbs/bootstrap/issues/20389

That command should work. I'll look into it.

Fixed by #21420. :)


Edge Routes infinite loading on Remix v2

I tried upgrading to Latest version 2.0.1 from 1.18.1.
All the future flags are enabled, they are working fine.
When you go to a node route, it's fine.
If you navigate to an "edge" route, it's fine.
But if you hard refresh the edge route, it will get stuck and just loads forever.
you can test on the dnb-stack which is open source.
https://dnb-stack.vercel.app/edge
We are also working on a project where we are stuck on 1.17.0 because of the infinite loading.
Could you please take also a look, thanks!

I've tried to reproduce with both a minimal test case (https://remixfun2-hdwyd3tio-chrisbarber.vercel.app/) and deploying the dnb-stack app (https://remix-dnb-stack-m9ao0cqow-chrisbarber.vercel.app/edge). In both cases, they seem finish loading successfully when doing a hard refresh. I'm testing using Chrome 117 on macOS.
What browser were you using?

FWIW, I notice there's large number of images being downloaded from S3. While there's nothing wrong with this, perhaps one of them was preventing the page from loading?

Couple more questions...
How are you deploying? From git? vc deploy? vc build && vc deploy --prebuilt?
Which package manager? Are you using a lock file? Is it committed to git? Is it up-to-date with the package.json?

@cb1kenobi  I just deployed a new with version 2 and we are getting this in logs:
ps {   status: 405,   statusText: 'Method Not Allowed',   internal: true,   data: 'Error: Invalid request method "OPTIONS"',   error: Error: Invalid request method "OPTIONS"     at (node_modules/.pnpm/@remix-run+router@1.6.3/node_modules/@remix-run/router/dist/router.js:3656:0)     at (node_modules/.pnpm/@remix-run+router@1.6.3/node_modules/@remix-run/router/dist/router.js:2651:0)     at (node_modules/.pnpm/@remix-run+server-runtime@1.17.0/node_modules/@remix-run/server-runtime/dist/esm/server.js:159:0)     at (node_modules/.pnpm/@remix-run+server-runtime@1.17.0/node_modules/@remix-run/server-runtime/dist/esm/server.js:57:0) }

@robipop22 the error stack seems to indicate you are using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>This would indicate that maybe you're not fully up-to-date and that there's a mismatch between the Remix package versions. If you're using Remix 2.0.1, then you should probably be using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Can you try running pnpm upgrade to regen the pnpm-lock.yaml, then deploy and see if that resolves the issue.

@cb1kenobi  thanks for looking also.
It seems that the lock file had that version cached, weirdly enough it did not get overwritten when manually doing upgrades, but it seems that pnpm upgrade did fix that in the end.
Thank you!
I'm going to close the issue as it was solved.

@david-crespo we looked at a few of your example pages and it's super interesting that it takes exactly 1 minute for a page to finish loading. It's also interesting that the page takes 1 minute with JavaScript disabled.
I suspect your issue is unrelated to the original reported issue. I'm tempted to suggest it's a Remix issue, possibly related to HTTP2.
When I run time curl -i https://rfd-site-izpso5nw4-oxidecomputer.vercel.app/rfd/0002, it returns most of the page immediately, but then hang before sending the last 450 bytes give or take.
This doesn't sound like a Vercel caching issue. It could be related to the Vercel proxy issue and HTTP2, but that doesn't explain why it works sometimes and not others. It's also not a browser issue or browser plugin issue.
We can't seem to reproduce in an isolated test project. If you'd like, you can go into the project settings and on the Security page, enable the "customer success code visibility" setting so we can search for clues.

Thanks for looking at it. I tried upgrading this site to Remix v2. I also couldn't repro independently and I tried pretty hard to figure out what was unique about what we're doing. Because the response size seems to determine something, I also thought it could be a Vercel proxy thing. I'll talk to my team and see if we have any issue with turning on the code visibility thing. It's probably fine. Thanks!

@cb1kenobi at great psychic cost, I have a minimal (and I mean minimal) repro for you.
https://github.com/oxidecomputer/vercel-timeout

good https://vercel-timeout.vercel.app/?size=16000
bad https://vercel-timeout.vercel.app/?size=17000
bad https://vercel-timeout.vercel.app/?size=64000
good https://vercel-timeout.vercel.app/?size=65000

@david-crespo Amazing work! I'll take a peek and share with the team.

@david-crespo the Edge Network team is investigating. Things appear to work when specifying an accept encoding:
time curl -i https://vercel-timeout.vercel.app/\?size\=16181 -sH 'Accept-encoding: gzip'

We stream in 16KB chunks, so that explains the boundary. The team will keep looking into the issue. We appreciate your patience!

Hi @david-crespo, I'm from Vercel, too.
We discussed this a bit internally, and saw that we had some problems with Remix streamings deployed on our serverless functions. That said, we've pushed some changes that should fix the reported issue. Could you try redeploying the app and test it again? Let us know how it goes
We're sorry for the trouble! and really appreciate your detailed report.

Looks good!
https://vercel-timeout-czduxzeqr-oxidecomputer.vercel.app/?size=32000
Thanks for the quick fix. Any chance you could say a little more about what it was?

@david-crespo unfortunately, we cannot disclose many details about the root cause, but we had a bug in our runtime that appears to be coming from the Node.js core itself. We've worked it around.


Whether TIGER-Lab/VLM2Vec-LLaVa-Next has been integrated with LoRA weights?

In your model card, TIGER-Lab/VLM2Vec-LLaVa-Next is fine-tuned based on LoRA, but the open source weights are the full weights rather than the adapter weights. Have the adapter weights been integrated?

@zhengbw0324
Yes, the model was trained using LoRA. I have merged the adapter weights with the full model weights to make it more convenient for people to use.


fix: a few typos

Description

Fix a few typos.
References

Review Checklist

[x] I have added documentation for new/changed functionality in this PR or in openfga.dev
[x] The correct base branch is being used, if not main

Codecov Report

Merging #67 (a624c78) into main (bac8ac7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   76.60%   76.56%   -0.04%
==========================================
  Files          72       72
  Lines        8056     8056
==========================================
- Hits         6171     6168       -3
- Misses       1468     1470       +2
- Partials      417      418       +1

Impacted Files
Coverage Δ

pkg/cmd/root.go
0.00% <0.00%> (ø)

pkg/cmd/run.go
0.00% <0.00%> (ø)

server/commands/check.go
85.58% <0.00%> (-0.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac8ac7...a624c78. Read the comment docs.


Duplicate subtree in Binary Tree

Description
Code added for Duplicate subtree in Binary Tree in C++
Fixes #1935
Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@ravikr126 Kindly review my PR under LGMSOC'21

@ravikr126 Kindly review my PR under LGMSOC'21


[1.22] AWS inspector borked when using custom AMI based on amazon-eks-node-1.22-v20220725

What happened:
AWS Inspector broke when analysing our custom AMI based on amazon-eks-node-1.22-v20220725
but it successfully passes with our other AMI based on amazon-eks-node-1.21-v20220725
both AMI are identical but the base AMI
What you expected to happen:
AWS Inspector analysis works
How to reproduce it (as minimally and precisely as possible):

Use AWS Inspector to analyse amazon-eks-node-1.22-v20220725 with rules packages with rules

Install Inspector awsagent (Copied from https://github.com/awslabs/amazon-eks-ami/issues/308#issuecomment-552989015, we use the same command in our pipeline)

    wget https://inspector-agent.amazonaws.com/linux/latest/install
    bash install
    sudo /etc/init.d/awsagent start

Anything else we need to know?:
Environment:

AWS Region: eu-west-1
Instance Type(s): t3.medium
EKS Platform version: N/A
Kubernetes version: N/A
AMI Version: amazon-eks-node-1.22-v20220725
Kernel: Linux ip-10-0-3-112.eu-west-1.compute.internal 5.4.196-108.356.amzn2.x86_64 #1 SMP Thu May 26 12:49:47 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Release information:

BASE_AMI_ID="ami-09db9da37d31787f3"
BUILD_TIME="Mon Jul 25 22:28:30 UTC 2022"
BUILD_KERNEL="5.4.204-113.362.amzn2.x86_64"
ARCH="x86_64"

Edit:
Also reported to AWS support they will be investigating the AWS Inspector side

It looks like the AWS Inspector got one step further and I've been able to run the inspector on the same AMI that caused the problem originally.
Since this looks like a transient error on the AWS side I'll close this ticket now


One Copyright Update to rule them all

TL;DR as the diff is huge:
This copyright notice:
Copyright (c) 2007-2022 Juan Linietsky, Ariel Manzur.
Copyright (c) 2014-2022 Godot Engine contributors (cf. AUTHORS.md).

changes to:
Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md).
Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur.

As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year.
It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement).
We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors).
Also fixed "cf." Frenchism - it's meant as "refer to / see".

Inspired by https://hynek.me/til/copyright-years/ which links to many examples of open source projects from big tech companies which either adopted the -present format we picked, or removed the end year, or removed all years altogether.
We discussed which format to use with @godotengine/production and agreed on using the -present format for the currently "active" copyright notice, and keeping the 2007-2014 range for @reduz and @punto-'s original open sourcing copyright notice.

Amazing!


Feature/remove blue bar

Description
Explination
Removing the blue bar in the middle of the page dividing the map section from the stats section of the page.
Fixes # (issue)
Removed stats folder and files. Removed import in Home.js to prevent any errors rendering the page.
Type of change
A simple feature removal that wasn't necessary.
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge

Checklist

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

Great last step toward a MVP! Congrats for scoring this win for the team.

https://www.loom.com/share/a477f02e685740eb91767737b2218b1a


AF_PACKET:  Adding back VLAN header optional.

Makes the adding back of the VLAN header for AF_PACKET packet data
optional and defaulted to off.  Especially for ZeroCopy, the addition of
VLAN headers is a performance hit (I clocked a 10x slowdown on a fast,
VLAN'd network).  While unfortunately it's counter-intuitive that the
kernel (or NIC, or whatever) removes the VLAN header, it's also
counter-intuitive that we return something to the user that the kernel
didn't return to us.  So, let's go for the thing that's at least fast,
while allowing for users to request the VLAN header if they'd like.

Fixes #441

Here's the performance numbers I referenced.  This is gathering 2.5M packets off a relatively fast network, with no additional processing (using the new example script).  Note that getData takes 190ms of CPU time without VLAN addition and 1.66s of CPU time with it.

Having heard no objections to this, I'm putting it in place.


Train loss problem

Hello! Thanks for your great project.
I'm training a MLLM connect with SD1.5, and I only train the adapter and Lora inject into SD1.5, freeze MLLM,
then I got this train loss, will it work?

Expect for your reply, Thanks!

It don't work, result image doesn't match the query caption.....


Create new caching implementation at the terminology service level

Resolves #1125.

I'm going to merge this so that I can deploy it and see how it behaves with some real data.


⚠ Bofrost.at has degraded performance

In ef940aa, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2688 ms

Resolved: Bofrost.at performance has improved in 656c392.


Fixed heatmap not working in mssql

Fixes #5212

Codecov Report

Merging #5248 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #5248      +/-   ##
==========================================
+ Coverage   37.61%   37.62%   +<.01%
==========================================
  Files         310      310
  Lines       46040    46042       +2
==========================================
+ Hits        17319    17322       +3
+ Misses      26242    26241       -1
  Partials     2479     2479

Impacted Files
Coverage Δ

models/user_heatmap.go
77.27% <75%> (-2.73%)
:arrow_down:

models/repo_list.go
64.55% <0%> (+1.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa16562...f2f5f66. Read the comment docs.

@kolaente please send backport to release/v1.6 branch

@techknowlogick It looks like the heatmap isn't even included in 1.6, so there's no need to make a backport.

@kolaente thanks for the reminder

@kolaente, build a docker image from the master today which is integrated with our MsSQL Database.
The database schema is Latin1_General_CI_AI.
The return code is 500 "Internal Server Error".
Do we use the wrong schema?
{
    "message":"arg timestamp as int: strconv.ParseInt: parsing \"2018-11-13T00:00:00Z\": invalid syntax",
    "url":"https://godoc.org/github.com/go-gitea/go-sdk/gitea"
}

@Cellebyte please report new issue

@kolaente, build a docker image from the master today which is integrated with our MsSQL Database.
The database schema is Latin1_General_CI_AI.
The return code is 500 "Internal Server Error".
Do we use the wrong schema?
{
    "message":"arg timestamp as int: strconv.ParseInt: parsing \"2018-11-13T00:00:00Z\": invalid syntax",
    "url":"https://godoc.org/github.com/go-gitea/go-sdk/gitea"
}

#5328


Putting column values from variable

C3 version: 0.4.22
D3 version: 3.5.17
Browser: Chrome  64.0.3282.186
OS: Windows 8.1

Hello, I'm trying to pass column data from my variable. (to generate dynamic chart)
I'm trying to do this way and dont works:
http://jsfiddle.net/p1w31uau/
I dont know how to put my values.

You can find lot's of exemples here:
http://c3js.org/examples.html
In your case you want something like:
http://c3js.org/samples/simple_multiple.html

@panthony check the fiddle, not working

I did check the fiddle and you are not following the expected format at all.
You are passing
[ 'data1', '3,2.67,2.5,2.4,3,2.57' ]

Instead of
[ 'data1', 3, 2.67, 2.5, 2.4, 3, 2.57 ]

vals should be an array of values, not a string, and you should do this:
[ 'data1' ].concat(vals) // merge both array into a single one

instead of
[ 'data1', vals ]

To have the expected format.

@panthony
Thanks, fixed. But there is another issue - look at y axis, decimal values are represented too long and it looks ugly, any way to fix that?

Yeah... JS can go funky with floating numbers.
You want this:
http://c3js.org/reference.html#axis-y-tick-format
Exemple:
http://c3js.org/samples/axes_y_tick_format.html
You should really spend some times through the samples :)

If any further help is required please use the Google Group at https://groups.google.com/forum/#!forum/c3js.
This issue queue is to be used for reporting defects and problems with C3.js.


When authentication times out, auto navigate to the login screen

[x]  if the authentication times out, auto navigate to the login screen
[x] I have noticed people getting time outs on authentication either extend it to a longer time or implement above but done let the UX allow server side challenges

I have extended AppID access token duration, let's see it that fixes the issue