Moonkin/swift ret raid buff doesnt show in char stats

Pulling from discord report:
Selecting either raid haste buff doesnt reflect in char stats

https://github.com/wowsims/wotlk/blob/eed69bff0384fbfa9224219c5039e88f864e518b/sim/core/buffs.go#L65-L67
changing these to multiplyStat instead may still accomplish same thing and show it in ui stats

@jarveson this issue is actually very similar to #2242 in that it can now be solved by exposing the pseudostat to the UI. https://github.com/wowsims/wotlk/pull/2172 is a reference for how to implement.
The PseudoStats and Spell/Melee haste are not interchangeable because the pseudostats apply multiplicatively and haste rating applies additively.

@psiven made a recent PR which is an even more succinct example of how to implement this: https://github.com/wowsims/wotlk/pull/2281

Going to close this actually; this affect shouldn't be included in haste rating, because it is calculated differently.


[task] deprecate golangci-lint task

What does this PR do?

Mark golangci-lint as deprecated
Move usage of deprecated task to the official lint task
Add missing feature to lint-go task to override build tasks

Motivation

lint-go covers golanci-lint command, golangci-lint task is deprecated and will be removed. Jobs and local calls to invoke task should use lint-go instead of golangci-lint
Additional Notes

I tested the equivalence of old and new invoke tasks locally, build tags are correctly computed and forwarded to golangci-lint command.
I will follow up to see if we can have a new AgentFlavour to cover security lint tags.
Note: arch parameter has no effect when build_tags is defined, as arch is used by the tag builder function, which is not called when build_tags is defined
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Updated tests_windows_sysprobe_x64, keeps running with same linter options
# before
golangci-lint run --timeout 20m0s  --build-tags "cri oracle gce clusterchecks kubeapiserver docker apm otlp test process npm etcd kubelet secrets containerd jmx ec2 orchestrator zk zlib consul" .\pkg/...

# after
cd C:\buildroot\datadog-agent && golangci-lint run --timeout 20m0s  --build-tags "apm clusterchecks consul containerd cri docker ec2 etcd gce jmx kubeapiserver kubelet npm oracle orchestrator otlp process secrets test zk zlib" .\pkg/...

Before
After

CI job
CI job


JavaScript certification not awarded.

Hi, I finished all the challenges and projects for the JavaScript Algorithms and Data Structures Certification, but my profile says that there are no certifications in my account. Do I need to do something else to see the certification?
I logged in FCC with the google account option and that is what I have been using. The code that I write is not kept anywhere after I finished each challenge. I started downloading my code each time for the project's part since I did not want to lose my code. Is this the way FCC works?

You have to claim each certification under the Profile.

Hey, thanks I got it! :)


Waterborne towers

This idea has been suggested a few times by now. Implementing this idea also requires modification of existing maps to contain some water for tower placement.

Resolved via commit a6e7da6ced64479df6cac9968cdfe650132de96d.


Certain Feather RP2040 (ESP32SPI) chunked responses fail

This one only manifests on Feather RP2040. It doesn't happen on PyPortal or FeatherS2. Some primitive behaves different? A timing quirk? Flash issue? Other??
This URL comes back as a chunked response, but loads fine:
https://anecdata.dev/ada/chunked2/?oc=8&ic=4&tr=28&ot=0&it=0
But this one hangs up on receiving:
https://anecdata.dev/ada/chunked2/?oc=7&ic=3&tr=17&ot=0&it=0
The parameters affect the data size. My only intuition is that round numbers seem to be fine, but less-round (odd?) numbers fail. The failures manifest as hanging on receive in line 122 of Requests:
Fetching text from https://anecdata.dev/ada/chunked2/?oc=7&ic=3&tr=17&ot=0&it=0
----------------------------------------
Traceback (most recent call last):
  File "code.py", line 34, in <module>
  File "adafruit_requests.py", line 326, in text
  File "adafruit_requests.py", line 315, in content
  File "adafruit_requests.py", line 369, in iter_content
  File "adafruit_requests.py", line 257, in close
  File "adafruit_requests.py", line 245, in _throw_away
  File "adafruit_requests.py", line 122, in _recv_into
  File "adafruit_esp32spi/adafruit_esp32spi_socket.py", line 132, in recv
  File "adafruit_esp32spi/adafruit_esp32spi_socket.py", line 172, in available
  File "adafruit_esp32spi/adafruit_esp32spi.py", line 731, in socket_available
  File "adafruit_esp32spi/adafruit_esp32spi.py", line 325, in _send_command_get_response
  File "adafruit_esp32spi/adafruit_esp32spi.py", line 281, in _wait_response_cmd
  File "adafruit_esp32spi/adafruit_esp32spi.py", line 188, in _wait_for_ready
KeyboardInterrupt:

(^c after a minute of waiting)
or in reading the chunks, as in:
Traceback (most recent call last):
  File "code.py", line 32, in <module>
  File "adafruit_requests.py", line 326, in text
  File "adafruit_requests.py", line 315, in content
  File "adafruit_requests.py", line 361, in iter_content
  File "adafruit_requests.py", line 220, in _readinto
ValueError: invalid syntax for integer with base 16

In my 'prodution' code, it's always the latter situation. I haven't been able to run Feather RP2040 + Airlift from the beginning.
I doubt it's an Apache issue since it returns fine in the browser and with curl --http1.1. Old Requests was HTTP/1.0, chunked responses are a fact of life with HTTP/1.1.
I've tried this on various versions since the board became available, most recently with Adafruit CircuitPython 6.2.0-beta.4 on 2021-03-18; Adafruit Feather RP2040 with rp2040 and Adafruit CircuitPython 6.2.0-beta.3-142-ga5c675932 on 2021-03-12; Adafruit Feather RP2040 with rp2040 (the slower flash version from https://github.com/adafruit/circuitpython/pull/4392 )
I've spend a lot of time print-debugging this and I'm baffled. By the way, this Feather (I only have one) still has the disappearing-on-reset issue, even with the slower flash version UF2. But large file copies that were a problem before are no longer a problem in the slower flash version or in beta.4. So this could be some weird flash issue, though I've seen no other issues since the slower flash commit.

Test code is a simplified Requests simpletest:
import board
import busio
from digitalio import DigitalInOut
import adafruit_esp32spi.adafruit_esp32spi_socket as socket
from adafruit_esp32spi import adafruit_esp32spi
import adafruit_requests as requests

from secrets import secrets

# Airlift FeatherWing:
esp32_cs = DigitalInOut(board.D13)  # Red LED
esp32_ready = DigitalInOut(board.D11)
esp32_reset = DigitalInOut(board.D12)

spi = busio.SPI(board.SCK, board.MOSI, board.MISO)
esp = adafruit_esp32spi.ESP_SPIcontrol(spi, esp32_cs, esp32_ready, esp32_reset)

print("Connecting to AP...")
esp.connect_AP(secrets["ssid"], secrets["password"])
print("Connected to", str(esp.ssid, "utf-8"), "\tRSSI:", esp.rssi)

# Initialize a requests object with a socket and esp32spi interface
socket.set_interface(esp)
requests.set_socket(socket, esp)

# out to lunch (line 122) or ValueError: invalid syntax for integer with base 16 (line 220)
TEXT_URL = "https://anecdata.dev/ada/chunked2/?oc=7&ic=3&tr=17&ot=0&it=0"

print("Fetching text from %s" % TEXT_URL)
response = requests.get(TEXT_URL)
print("-" * 40)

print("Text Response: ", response.text)
print("-" * 40)
response.close()

Adafruit CircuitPython 7.2.0-alpha.1-224-gac7a80753 on 2022-01-26; Adafruit Feather RP2040 with rp2040
adafruit-circuitpython-bundle-7.x-mpy-20220128
NINA 1.7.4
Rested with latest CP & libs, and it's working now. Closing.


Multistage, respect Laravel environment

Hi,
first of all, excellent package. Are you planning a extension like multistage for capistrano? How do I set the laravel env?
Cheers

It forces to use the same name for stage, is it possible to overwrite that variable in stage specific config?


Feature bone builder2

Merge changes for bone builder into Develop.

@ecurtz would you be willing to review this?

@ecurtz I was having trouble using just the tPose because it doesn't contain hierarchy data.  Instead, I changed it so the avatar is now only required to be a GameObject and now there is an input field for the UMATextRecipe that is the base recipe.  How's that?


Incorporate fixes from Jigsaw-Code fork

Add support for osx
Remove wonky MIMETYPE check in Android paste method
Add check for nil in iOS; return an empty string instead

Of these, the Android MIMETYPE check was the most annoying to us. Calling Paste() would simply not return if someone had copied some HTML from another app. This should at least convert the html to text and return it, or just return an empty string.

Should add: the changes come from https://github.com/Jigsaw-Code/outline-cordova-plugin-clipboard.


[3.2] SCons: Fix python2 compatibility after #37198 and #37248

CC @Xrayez

Sorry for the hassle, I should've tested this on python2 before suggesting cherry-picking...


nanbield chipstar experiment

@reibax-marcus FYI
It doesn't work yet.

Thanks for reporting. I currently don't have time to experiment with nanbield, but I will keep it in mind. If I have time at any point I will definitely look into it.

Thanks for reporting. I currently don't have time to experiment with nanbield, but I will keep it in mind. If I have time at any point I will definitely look into it.

Don't worry. Since chipStar seems to support LLVM 15 and up, mickledore and up can work.
Hopefully PyTorch and other stuff supporting CUDA can be convinced to use chipStar.

chipStar is not a complete CUDA replacement yet. PyTorch disqualifies it in its CMake framework:
warning: cucc is a work-in-progress. It is incomplete and may behave incorrectly.
Please, report issues at https://github.com/CHIP-SPV/chipStar/issues.
-- Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR CUDA_INCLUDE_DIRS CUDA_CUDART_LIBRARY) (found version "clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/zozo/test-yocto-4.3-gh/tmp-sicom-glibc/work/corei7-64-oe-linux/python3-pytorch/2.3.1/recipe-sysroot-native/usr/bin

.clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/zozo/test-yocto-4.3-gh/tmp-sicom-glibc/work/corei7-64-oe-linux/python3-pytorch/2.3.1/recipe-sysroot-native/usr/bin

")
CMake Warning at cmake/public/cuda.cmake:31 (message):
  Caffe2: CUDA cannot be found.  Depending on whether you are building Caffe2
  or a Caffe2 dependent library, the next warning / error will give you more
  info.
Call Stack (most recent call first):
  cmake/Dependencies.cmake:44 (include)
  CMakeLists.txt:754 (include)

CMake Warning at cmake/Dependencies.cmake:80 (message):
  Not compiling with CUDA.  Suppress this warning with -DUSE_CUDA=OFF.
Call Stack (most recent call first):
  CMakeLists.txt:754 (include)

Postponing for now.


performance issue with views and functions.

Hi, I was testing cstore_fdw against plain pg table and noticed this:
pg=# create foreign table cstore_test (time timestamp,meter_id int,data real) server cstore_server options(compression'pglz');
CREATE FOREIGN TABLE
Time: 31.434 ms

pg=# INSERT INTO cstore_test SELECT "time", FLOOR(RANDOM() * 10), 10- (RANDOM() * 20) FROM GENERATE_SERIES(NOW() - INTERVAL '1 year', NOW(), INTERVAL '1 seconds') TIME;
INSERT 0 31536001
Time: 41724.510 ms (00:41.725)

pg=#  CREATE OR REPLACE FUNCTION increment(i real) RETURNS real AS $$
pg$#         BEGIN
pg$#                 RETURN i + 1;
pg$#         END;
pg$# $$ LANGUAGE plpgsql;
CREATE FUNCTION
Time: 41.641 ms
sirate=# create view cstore_view as select time,meter_id,increment(data) from cstore_test;
CREATE VIEW
Time: 63.024 ms

pg=# select time,meter_id,increment(data) from cstore_test where time > '2018-03-16 23:55:00' and meter_id = 1;
            time            | meter_id |  increment
----------------------------+----------+--------------
 2018-03-18 04:40:57.048955 |        1 |       9.6884
 2018-03-18 04:41:21.048955 |        1 |     -4.72585
 2018-03-18 04:41:31.048955 |        1 |      2.50237
 2018-03-18 04:41:34.048955 |        1 |     -3.65364
 2018-03-18 04:41:35.048955 |        1 |     -0.16955
 2018-03-18 04:42:07.048955 |        1 |     -5.81057
 2018-03-18 04:42:13.048955 |        1 |      5.37638
 2018-03-18 04:42:23.048955 |        1 |     -2.19258
Time: 127.635 ms

pg=# select * from cstore_view where time > '2018-03-16 23:55:00' and meter_id = 1;
            time            | meter_id |     data
----------------------------+----------+--------------
 2018-03-18 04:40:57.048955 |        1 |       9.6884
 2018-03-18 04:41:21.048955 |        1 |     -4.72585
 2018-03-18 04:41:31.048955 |        1 |      2.50237
 2018-03-18 04:41:34.048955 |        1 |     -3.65364
 2018-03-18 04:41:35.048955 |        1 |     -0.16955
 2018-03-18 04:42:07.048955 |        1 |     -5.81057
 2018-03-18 04:42:13.048955 |        1 |      5.37638
 2018-03-18 04:42:23.048955 |        1 |     -2.19258
Time: 2784.645 ms (00:02.785)

And after I inserted another 31M rows the times got twice as bad: Time: 5239.377 ms (00:05.239).
If using vanilla tables it's about the same time using query or view. Time: 4424.318 ms (00:04.424)

I think that is related to how views are planned. cstore_fdw might be returning all rows instead of filtering at stripe/block level.

similar issue is reported by another user for queries inside functions. He confirmed that after marking as the function as STABLE it worked as expected.


Create calculate difference between two time periods.cpp

Why:

Closes #ISSUE_NUMBER
What's being changed:

No issue was found for this PR.
This PR will be merged later


[Jupyter] Don't jump to file browser top level while exploring /pfs/out

2.6.x PR is #8837
Fix INT-963
Basically:

we have our poller call verifyBrowserPath every time the mountedSignal is triggered (~which I think is every 2 seconds if the connection is healthy~ this is not quite correct—see below).
verifyBrowserPath resets the custom file browser to the top level if the currently open path isn't underneath any of the currently mounted repos.
However, if the path you have open is /pfs/out, verifyBrowserPath fails the above check. So if you open /pfs/out in the file browser to explore it, it'll jump back to the top level after a few seconds.

This PR fixes the above error by short-circuiting out of verifyBrowserPath if the currently-mounted path is /pfs/out specifically.

Update: I talked with @chainlink about this PR a bit (he was having a hard time reproducing the issue, and I've been wondering why the "jump to top" takes a variable amount of time to happen after navigating into /pfs/out), and I think I figured out the answer to both. The events leading up to the triggering of mountedSignal are:

dataPoll calls getData every 2-5 seconds
getData calls ListMounts and then passes the results to updateData
updateData compares the stringified new data to the stringified existing data (this._mounted). If they're different, it sets this.mounted
The setter for this._mounted triggers the mountedSignal

If the comparison in step 3 above finds no changes, then it never triggers the mounted signal. In my case, while preparing the demo, I had two repos mounted in the datum view: the model weights and the test data. Every 2 seconds, ListMounts would be called, and often, it would see that no mount had changed, and therefore mountedSignal would not be triggered. However, the existing this._mounted contained an array with both mounts, say [weights, test-data]. Some percentage of the time, ListMounts would return those mounts in the opposite order, [test-data, weights] (note that Go deliberately randomizes the order in which maps are traversed). This would cause the stringified comparison above to fail, causing mountedSignal to be triggered, causing the jump-to-top.
So, to encounter this issue, you need:

At least two repos mounted
The mount server to randomly swap the order of the mounts in its response (which means a random number of polls will occur before the bug is triggered)

I think this explains the mysteries above.

Great investigation!


In "Account--Subscriptions" pages of supplier, there only listed the subscriptions subscribed by himself, but after searching, it can display the subscription by customer.

Date: 2016/05/06
[Test category]: creative Test
[Steps to reproduce]

Login as supplier, define a service, set price model, publishing option for it, then activate this service.
Login as customer, subscribe this service named as "cu_bug", put the configuration and price model information, then assign this subscription to himself.
Login as supplier, subscribe this service named as "sp_bug", put the configuration and price model information, then assign this subscription to himself.
Go to "Account"->"subscription" page.
Search the word "bug".

[Expected result]
After step4, there are all the subscriptions listed.
After step5. there are the subscription with "bug" listed.
[Observed result]
After step4, there is only one subscription "sp_bug".
After step5, there are two subscriptions "sp_bug" and "cu_bug".

The observed result after step4 is correct, you are logged in as supplier, so you can see only your subscription sp_bug, not the one from the other organization.

Hello.
Previously, in account->subscriptions page, supplier did not see the customer's subscriptions. If you do not use subscription filter, then old query for subscriptions is used. Subscription filter is used as filter on the results returned by old query.
Query for blue portal is (was) different than for marketplace.
The question is: should supplier see the customer's subscriptions, consider the fact that before search feature has been implemented, he did not?
Regards, Dawid.

The supplier is acting as a customer in this case. So it should be exactly the same.

Supplier role should be used for managing marketable services in marketplace. All 'managing stuff' of services and such is being done on blue portal. Supplier should see his clients' subscriptions there. When supplier switches to marketplace, he is no longer admin but regular client.
Conclusion: in marketplace supplier should not see his clients' subscriptions.

The bug is related to issue #76, so set to duplicate.

Verified by FNST
[verified-version]V16.0 fix5
[verified-details]Now the supplier in the marketplace can only see his owen subscriptions, and can not search out the other organization's subscrptions, so this bug can be verified.


Introduction of the support of RAW lines/sources

This patch fixes https://github.com/StevenBlack/hosts/issues/1563#issuecomment-810688754.
Indeed, before this patch, the updater was not supporting a RAW list of domains as input.
Changes:
matches_exclusions():
    (new) Support for rule formatted as 'example.com' along with the pre-existing '<IP_ADDRESS> example.com'.

normalize_rule():
    (edit) Apply DRY.

    (new) Support the normalization of the rule formatted as  'example.com' along with the pre-existing '<IP_ADDRESS> example.com'.

strip_rule():
    (new) Complete rewrite in order to strip all possible lines.

*.py (files):
     Apply Black & isort.

setup.cfg:
     Add black recommended/related settings.

Stay safe and healthy.
Nissar

Oh well, it's the power of OSS 🎉 😜
It was fun and actually a quick-to-write patch 😉.
You're welcome ☺!


Error on native-base/fonts

Issue Description
node, npm, react-native, react and native-base version, expo version if used, xcode version
node - v12.7.0
npm - 6.10.0
react - 16.8.3
native-base - 2.13.7
expo - 3.0.10
xcode - 10.3
Actual behaviour
When I try run the project, my xcode return this error:

I saw in May a similar issue opened and fixed by an update.
Will this be needed again ?
Is the bug present in both iOS and Android or in any one of them?
Only iOS

Missed it with the last upgrade.
Will be added back in the next version.

Please @sanketsahusoft, can you release a patch update for this? I am sure a lot of people will come here with the same issue.
For those with this issue, just dowload this font file and paste it into your node_modules/native-base/Fonts folder.

Please @sanketsahusoft, can you release a patch release for this? I am sure a lot of people will come here with the same issue.
For those with this issue, just dowload this font file and paste it into your node_modules/native-base/Fonts folder.

The fix has been added to master. Please point your package.json to master till we release a new path (ETA 2 days)

Spam - but it is funny that this font has gone missing during upgrades twice now. Someone doesn't like it?😂

@colemars We copy the latest fonts from react-native-vector-icons. Must have been removed from there.

Fixed in 2.13.8


Added text "-t : sort the list of files by modification time" to the …

…article

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


Enhance setup guide for php begginers?

Hi there! Love the project!
Would love to contribute but I've been struggling with running the project in local.
I've setup my httpd in my Mac OSX ( High Sierra) to use php module and I have php 7.1 installed.
$ php -v
PHP 7.1.33 (cli) (built: Jan 18 2020 13:49:07) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies

After following the guide in the README index.php throws a 500 error (and I can't seem to find error logs or something to shed some more light into this).
Can you help me? Does the project work with the latest php versions?

Hello.
Could you please attache error log of web server? ( I think it placed in /private/var/log/apache2/error_log)
We use PHP 5.6 and I did not test php 7.1.
Also you can try web server with UI for example MAMP (https://www.mamp.info/en/downloads/). It can be easy to use for beginners. And you can easy install old PHP version: https://stackoverflow.com/questions/16783558/how-can-i-add-additional-php-versions-to-mamp

Also try to get last version of sources. I made small changes in it.

There is no activity.


Feature suggestion: 'resolve.addMissingImports' import angular modules too

System information

OS: Windows 10 Pro
TypeScript Hero version: 0.12.0
VSCode version: 1.11.2

Feature: Auto Import Angular Modules
When i use the following command: 'resolve.addMissingImports' it only import my own custom components etc.
Before:
import { Config } from 'app/app.config';
After:
import { Component, OnInit } from '@angular/core';
import { Config } from 'app/app.config';
Reason
It would be cool, if custom components etc. and angular modules are imported.

I would like to see this too. I was surprised when it wasn't finding my angular modules to import.


Apostrophe in contractions is turned into *(Aq, subsequently swallowed by pandoc

We produce manual pages using roff-rs, then render them as  HTML for our web site.  I have noticed that apostrophes in contractions and marking of possessive cases area not present in the produced HTML:
$ cat src/main.rs
fn main() {
    let mut r = roff::Roff::new();
    r.text(vec!["I've been a good boy.".into()]);
    println!("{}", r.render());
}
$ cargo run > astropof.1
    Finished dev [unoptimized + debuginfo] target(s) in 0.00s
     Running `target/debug/foobr`
$ cat astropof.1
.ie \n(.g .ds Aq \(aq
.el .ds Aq '
I\*(Aqve been a good boy.

$ man ./astropof.1|hd
00000000  49 27 76 65 20 62 65 65  6e 20 61 20 67 6f 6f 64  |I've been a good|
00000010  20 62 6f 79 2e 0a 0a                              | boy...|
00000017
$ pandoc -o astropof.txt astropof.1
$ cat astropof.txt
Ive been a good boy.

Now, I'm not an expert on roff, but one of the manual pages that I consult for advice on writing manual pages says not to use \(aq to escape ordinary apostrophes.  https://man7.org/linux/man-pages/man7/groff_man_style.7.html says:
You should not use \(aq for an ordinary apostrophe (as in “can't”)

Through experimentation I discovered that pandoc renders both ' and \(aq just fine.

To clarify: I think there are two issues here:

roff-rs unconditionally replaces apostrophes where it shouldn't (e.g. in contractions).
roff-rs uses the \*(Aq workaround which doesn't sit well with pandoc.

I have no idea what to do about either issue, but I wanted to report it.

I just noticed the documentation of Roff::to_roff says:

Without special handling, apostrophes get typeset as right single quotes, including in words like “don’t”. In most situations, such as in manual pages, that’s unwanted.

That comment gets it wrong.  In contractions, like "don't", you do want to allow renderers to use fancy glyphs, and in fact that is what rustdoc renders it to in the example:
$ echo -n don’t | hd
00000000  64 6f 6e e2 80 99 74                              |don...t|
00000007

Glyph e2 80 99 is RIGHT SINGLE QUOTATION MARK.  Where you don't want that kind of fancy glyphs is code samples, which you expect people to copy and paste and have them work right.

You probably want render or to_writer instead of this method.

In fact, I switched to using this method, and this yields perfect results for me: both Debian's man and pandoc render apostrophes as 27 i.e. APOSTROPHE both in text as well as code blocks.


[ERROR] Cannot find module './wwwroot/dist/vendor-manifest.json' in Aurelia project

Hello
Can you say, why do I run the 'webpack' command or running 'Aurelia project' with VS have an error ?
C:\Users\...\Desktop\ASP.NET Core Basics\src\Aurelia>webpack
module.js:471
    throw err;
    ^

Error: Cannot find module './wwwroot/dist/vendor-manifest.json'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\Users\...\Desktop\ASP.NET Core Basics\src\Aurelia\webpack.config.js:27:23)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at requireConfig (C:\Users\...\AppData\Roaming\npm\node_modules\webpack\bin\convert-argv.js:96:18)
    at C:\Users\...\AppData\Roaming\npm\node_modules\webpack\bin\convert-argv.js:109:17
    at Array.forEach (native)
    at module.exports (C:\Users\...\AppData\Roaming\npm\node_modules\webpack\bin\convert-argv.js:107:15)

C:\Users\...\Desktop\ASP.NET Core Basics\src\Aurelia>

Can you help me for run 'Aurelia project' ?

Try the information in this post.
The gist is basically to run this command: webpack --config webpack.config.vendor.js

@elanderson
Thanks for your answer, but I think you should change something in your 'webpack.config.js','webpack.config.vendor.js'.
after run the above command I have an error
Error: Module 'C:\Users\...\Desktop\ASP.NET Core Basics\src\Aurelia\
modules\css\index.js' is not a loader (must have normal or pitch function)

so I searched and found this
Automatic -loader module name extension removed
https://webpack.js.org/guides/migrating/#automatic-loader-module-name-extension-removed
then I added '-loader' to all loader configuration. Now Works :)
thanks

Sounds like it is time to update his project. This example is from when JavaScriptServices was using Webpack 1.

@elanderson
Can you update to webpack 2 ? after updating the project.json I have error
https://github.com/aurelia/webpack-plugin/issues/97
Anyway, Thanks

@HamedFathi I will check into it, but it may be a couple of weeks before I can get to it.

@HamedFathi  projects have been updated. Before the first run the following command must be run in both the Angular and Aurelia project directories.
webpack.js --config webpack.config.vendor.js

@elanderson Thanks


Double.NaN in data will trigger exception during segment creation

Seems like Double2IntOpenHashMap cannot handle it.

do you have a query when this happens? Is it happening in avg?

During segment creation, when my raw data has Double.NaN.

close as fixed by bump up fastutil version


Dataset slice splits can't load training and validation at the same time

Describe the bug
According to the documentation is should be possible to run the following command:
train_test_ds = datasets.load_dataset("bookcorpus", split="train+test")
to load the train and test sets from the dataset.
However executing the equivalent code:
speech_commands_v1 = load_dataset("superb", "ks", split="train+test")
only yields the following output:

Dataset({
features: ['file', 'audio', 'label'],
num_rows: 54175
})

Where loading the dataset without the split argument yields:

DatasetDict({
train: Dataset({
features: ['file', 'audio', 'label'],
num_rows: 51094
})
validation: Dataset({
features: ['file', 'audio', 'label'],
num_rows: 6798
})
test: Dataset({
features: ['file', 'audio', 'label'],
num_rows: 3081
})
})

Thus, the API seems to be broken in this regard.
This is a bit annoying since I want to be able to use the split argument with split="train[:10%]+test[:10%]" to have smaller dataset to work with when validating my model is working correctly.
Steps to reproduce the bug
speech_commands_v1 = load_dataset("superb", "ks", split="train+test")
Expected behavior

DatasetDict({
train: Dataset({
features: ['file', 'audio', 'label'],
num_rows: 51094
})
test: Dataset({
features: ['file', 'audio', 'label'],
num_rows: 3081
})
})

Environment info
import datasets
print(datasets.__version__)

2.14.5

import sys
print(sys.version)

3.9.17 (main, Jul  5 2023, 20:41:20)
[GCC 11.2.0]

The expression "train+test" concatenates the splits.
The individual splits as separate datasets can be obtained as follows:
train_ds, test_ds = load_dataset("<dataset_name>", split=["train", "test"])
train_10pct_ds, test_10pct_ds = load_dataset("<dataset_name>", split=["train[:10%]", "test[:%10]"])


license

Cargo.toml says "MIT".  The included LICENSE file is the Apache license.  Also, it doesnt have any copyright statement that I found.
  I'm just trying to follow the rules and include all the licenses of all the libs that a binary I am distributing includes (some 150 licenses!)

The MPL license could be good


Usage of Semantic Versioning

Problem Statement
Breaking changes without proper versioning
Proposed Solution
Usage of Semantic Versioning as mentioned in https://semver.org/
Additional Context
If sem ver is used, dependabots and other tools will not automatically try to update this, if sem ver is followed it becomes evident from the release version itself if it might break things.
Also, breaking thing reduces usability

Could you please state more specific details about the proposal for proper versioning?

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

A repo with major version zero should be okay with the breaking changes without changing the major version.


How to disable disallowSpacesInFunctionExpression

Hi,
I am using jscs and I want to disable disallowSpacesInFunctionExpression which is being used by my preset. The issue is I can't set any of it's children properties to false and I can't set it an empty object. If I set it to null nothing seems to change.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Do you also need to require spaces? You should be able to just null it.
{
  "preset": "airbnb",
  "disallowSpacesInFunctionExpression": null
}

or
{
  "preset": "airbnb",
  "disallowSpacesInFunctionExpression": null,
  "requireSpacesInFunctionExpression": {
    "beforeOpeningRoundBrace": true
  }
}

Ah, my mistake. I was a bit confused about the null property disabling a rule and having to explicitly set the require or disallow value depending if you want a specific rule or not.


Shared references of FutSenders should implement futures::Sink.

Similar reasoning to the fact that BroadcastFutSender::try_send etc. take &self instead of &mut self, it should be possible to use &self as a Sink.
As of now, we have impl Sink for BroadcastFutSender etc, and the generic impl from upstream: impl<S: Sink> Sink for &mut S. There is no generic impl for &S because of the requirements of the trait: start_send and poll_complete take &mut self. These provide implementations for owned values and unique references, but both of those require unique access to the sender.
This becomes problematic when, for example, I want to have an public API that creates and returns a future for sending a single value. That future would have to uniquely borrow the sender as well as its containing struct, preventing me from doing anything else (including creating other futures) until that future is dropped.

Looking at the documentation for FutReceiver types, it seems like they could also implement Stream for shared references as well.


"Mihail Kogălniceanu" is listed in the drop-down menu

Description:
When user writes "Mihail Kogălniceanu" the location appears in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mihail Kogălniceanu"
Expected results
The location appears in the drop-down menu as "Comuna Mihail Kogălniceanu, ** IALOMIȚA**"


Revert "Update exchange rate to match current average"

What
This reverts commit f0ad7e6670ac066be39020b5543d7d6d07599d22.
It turns out that the extra complexity that this adds to billing's
queries causes it to fall over.
We could consider changing the epoch exchange rate and relying on the
consolidation to keep the past consistent, but for now let's just try
and fix the thing.

How to review

Code review should be enough

Who can review
Not @richardTowers

Some more images that illustrate the effect of this change:
Burst balance:

IOPS:

CPU:


Add LinkTo component support to ANET entity links in editor

Added the ability to find, parse and display links to ANET entities as LinkTo components in the text editor.
Fixes #1773
User changes

Changes to the editor and text display fields in forms.

[ ] anet.yml needs change

[ ] db needs migration

[ ] documentation has changed

@jose-west File client/src/components/editor/LinkSource.js is no longer used, remove it?


[SPARK-37865][SQL] Fix union deduplication correctness bug

What changes were proposed in this pull request?
Fixes a correctness bug in Union in the case that there are duplicate output columns. Previously, duplicate columns on one side of the union would result in a duplicate column being output on the other side of the union.
To do so, we go through the union’s child’s output and find the duplicates. For each duplicate set, there is a first duplicate: this one is left alone. All following duplicates are aliased and given a tag; this tag is used to remove ambiguity during resolution.
As the first duplicate is left alone, the user can still select it, avoiding a breaking change. As the later duplicates are given new expression IDs, this fixes the correctness bug.
Why are the changes needed?
Output of union with duplicate columns in the children was incorrect
Does this PR introduce any user-facing change?

Unit tests

FYI @cloud-fan, @LantaoJin, and @chasingegg; this PR builds off https://github.com/apache/spark/pull/35168.

What changes were proposed in this pull request?
Fixes a correctness bug in Union in the case that there are duplicate output columns. Previously, duplicate columns on one side of the union would result in a duplicate column being output on the other side of the union.
To do so, we go through the union’s child’s output and find the duplicates. For each duplicate set, there is a first duplicate: this one is left alone. All following duplicates are aliased and given a tag; this tag is used to remove ambiguity during resolution.
As the first duplicate is left alone, the user can still select it, avoiding a breaking change. As the later duplicates are given new expression IDs, this fixes the correctness bug.
Why are the changes needed?
Output of union with duplicate columns in the children was incorrect
Does this PR introduce any user-facing change?

Unit tests

Result After should be
 a | a
 _ | _
 1 | 1
 1 | 1
 2 | 2
 2 | 3

?
 The result after this fix is
a
_
1
1
2
2
I think it should be broken because it is ambiguous, instead of choosing the first column.

Result After should be ...

Seems like a typo. Looking at the test, the result is corrected. @karenfeng can you double-check?

And why we should support select a from (SELECT a, a ...

Yea it's ambiguous but it's already supported before this PR. We can't find a way to fix this without a breaking change so claiming that it selects the first a column looks acceptable. Better ideas are welcome!
Note: we can fix this problem more completely at the master branch with a bit of breaking changes.

@chasingegg Good catch, thanks! I fixed the PR description.

thanks, merging to master/3.2/3.1/3.0!

And why we should support select a from (SELECT a, a ...

What are the behaviors of other engines such as PostgreSQL, MySQL?

And why we should support select a from (SELECT a, a ...

What are the behaviors of other engines such as PostgreSQL, MySQL?

They will fail such queries. Currently this fix will not fail such queries to avoid breaking changes as discussed above.


Visual mode and CursorLine conflicts

When I use visual mode, the cursorline won't disappear...
Then it's difficult to distinguish whether the code is selected in some color schemes.
Like:

But the vscode-vim extension works well:

This can only be fixed if the plugin produces real vscode selections from visual mode instead of fake ones. Might be possible however.
https://github.com/vscode-neovim/vscode-neovim/commit/1e1e8ce74f11c9b3b6d02cab05ef103a37aa36ca

This can only be fixed if the plugin produces real vscode selections from visual mode instead of fake ones. Might be possible however.
1e1e8ce

Thanks, now I modified this to fix it:
"workbench.colorCustomizations": {
    "editor.selectionBackground": "#B0C4DE"
  },

Should the issue be able to close?

That's a good fix. Maybe we don't need this issue to track sending vscode selections.


Screenshot tests added

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.10%. Comparing base (73265af) to head (de67b6d).
Report is 2 commits behind head on main.

Files
Patch %
Lines

...ll/presentation/topics/composables/TopicsScreen.kt
70.58%
2 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #6      +/-   ##
============================================
+ Coverage     71.92%   72.10%   +0.17%
  Complexity        3        3
============================================
  Files            56       57       +1
  Lines           684      699      +15
  Branches        127      130       +3
============================================
+ Hits            492      504      +12
  Misses          106      106
- Partials         86       89       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How can I get this working with webpack?

I got this working nicely with my react app.However, since I started using webpack, especially a webpack plugin that does a text replace on placeholders within the app code, the sitemap fails, being unable to parse the code( it's actually invalid due to the placeholders). I need to include this into a webpack plugin so that it uses the webpack processed sources instead of actual ones.Any pointers ? Perhaps someone already did this ?

@rluncasu I didn't create webpack plugin for this. Can you create simple example your case and describe more what you want? I will try implement plugin for webpack.

@kuflash I've created a repo with a minimal skeleton.
https://github.com/rluncasu/minimal-react-webpack-sitemap
I want react-router-sitemap to work with webpack.DefinePlugin which does a search & replace in /src/common/mutuals/index.js.
Currently react-router-sitemap can't parse the code in that file because it hasn't been transformed by webpack.
It does look like what is needed is building a react-router-sitemap webpack plugin.

@rluncasu if I right understood you, you want use some variables defined in DefinePlugin for generate routes for react application (for exmaple), and use generated routes for sitemap builder?

@kuflash I'm not using the variables for generating routes but in the routes controller. Anyway, the file is referenced and because it's not valid code (not until webpack DefinePlugin replaces the placeholders) sitemap builder errors out when trying to load the routes.

@rluncasu ok, I'm understood. Can you try use this plugin? It's have callback with array of paths. You can try use API method  from my modules for generate sitemap from webpack. Report the result, please.

@kuflash , I've tried the plugin you suggested but unfortunately that plugin produces the same error (the plugin itself, not react-router-sitemap).
Looking at his code, I can see the reason, instead of using the compiled sources, it loads the routes directly from file.
Webpack plugins must use of the 'compilation' object in order to access the compiled sources (react-router-path-extractor-webpack-plugin doesn't do that).

@rluncasu ok, I'm not sure that this is possible. But I will research this is question. If you can find something on this topic, then please let me know.

I figured out a solution.Posting it here so it may help others:
The base issue was that the js code wasn't valid code until it ran through webpack's DefinePlugin.
To solve this, I changed the name of the placeholders inside DefinePlugin config:
from:
        new webpack.DefinePlugin({
            DEVELOPMENT: "true",
            PRODUCTION: "false",
            NODE_ENV: JSON.stringify('testingshits'),
        })

to:
        new webpack.DefinePlugin({
            "process.env.DEVELOPMENT": "true",
            "process.env.PRODUCTION": "false",
            "process.env.NODE_ENV": JSON.stringify('testingshits'),
        })

and in my code
from:
export const isDevelopment = DEVELOPMENT ;

to:
export const isDevelopment = process.env.DEVELOPMENT || false;

This way, when webpack runs the code through DefinePlugin it will replace the entire string "process.env.DEVELOPMENT" and when running the sitemap builder through nodejs the code will still be valid because process.env.DEVELOPMENT is valid code(process.env is defined).
thanks a lot @kuflash for working through this with me !

@rluncasu cool! Thank you!


net: openthread: Add option to enable software CSMA backoff

Add option to enable software CSMA backoff in the OpenThread MAC layer.
This allows to run CSMA procedure correctly in radios that do not
support hardware CSMA backoff, and use them as RCP, where this feature
is required.
Signed-off-by: Robert Lubos<EMAIL_ADDRESS>

CC @MarekPorwisz

@edmont I've found out that enabling this option allows to run RCP with radios that do not support hardware CSMA backoff (which is the case for the upstream nRF radio driver now...). Am I right, that with RCP buid we still have the MAC implementation on the RCP side (sub_mac to be exact, as OpenThread calls it) so this had a chance to work?

@rlubos yes, SubMac layer was created explicitly for RCP support.


all: add optional close_fds feature to reproducers

Instead of always closing open fds (number 3 to 30) after each program,
add an options called EnableCloseFds. It can be passed to syz-execprog,
syz-prog2c and syz-stress via the -enable and -disable flags. Set the
default value is true. Also minimize C repros over it.

CI complains about diff:
diff --git a/executor/common.h b/executor/common.h
index 900e78b..8e23f99 100644
--- a/executor/common.h
+++ b/executor/common.h
@@ -701,7 +701,7 @@ int main(void)
 			[[SANDBOX_FUNC]]
 #if SYZ_HAVE_CLOSE_FDS && !SYZ_THREADED && !SYZ_REPEAT && !SYZ_SANDBOX_NONE && \
     !SYZ_SANDBOX_SETUID && !SYZ_SANDBOX_NAMESPACE && !SYZ_SANDBOX_ANDROID_UNTRUSTED_APP
-			close_fds();
+			    close_fds();
 #endif
 #if SYZ_PROCS
 		}
diff --git a/pkg/csource/generated.go b/pkg/csource/generated.go
index b7fa705..fb5e643 100644
--- a/pkg/csource/generated.go
+++ b/pkg/csource/generated.go
@@ -4813,7 +4813,7 @@ int main(void)
 			[[SANDBOX_FUNC]]
 #if SYZ_HAVE_CLOSE_FDS && !SYZ_THREADED && !SYZ_REPEAT && !SYZ_SANDBOX_NONE && \
     !SYZ_SANDBOX_SETUID && !SYZ_SANDBOX_NAMESPACE && !SYZ_SANDBOX_ANDROID_UNTRUSTED_APP
-			close_fds();
+			    close_fds();
 #endif
 #if SYZ_PROCS
 		}

Thinking more of this. This closing fd's is different from, say, setup of net devices.
If we don't setup a device, then expectation is that we won't trigger the bug that requires this device.
But this feature is actually to prevent bugs (namely, hangs in 9p/fuse). So if we disable it, we will start getting an unrelated bug...
I don't know what's the right answer here.

CI should be fixed; changed loop() to always do close_fds(). PTAL

Codecov Report

Merging #1112 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   67.28%   67.29%   +<.01%
==========================================
  Files         119      119
  Lines       20626    20639      +13
==========================================
+ Hits        13879    13888       +9
- Misses       6085     6089       +4
  Partials      662      662

Impacted Files
Coverage Δ

pkg/ipc/ipc.go
50.45% <ø> (ø)
:arrow_up:

pkg/csource/common.go
88.76% <100%> (+0.12%)
:arrow_up:

pkg/csource/options.go
53.75% <66.66%> (+0.5%)
:arrow_up:

pkg/repro/repro.go
25.04% <66.66%> (+0.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfb045...4c90fd3. Read the comment docs.


NoneType concat error occurs in warning statement

Indubitably! I fixed this with better handling on our active-learning branch


Remove decisions for the 1.0 release

Remove decisions and the redirect parameter in preparation for a 1.0 release.
Fixes #99.

@isaacvetter - Why did you remove that link the example in 9678739? That doesn't have anything to do with the decisions feature. Additionally, that additional link was to show that you can have multiple absolute links associated with a card.


Generate all members in namespace from nativemethods.txt

Is your feature request related to a problem? Please describe.
I want to easily generate everything within a "namespace" from the metadata, whether it by structs, methods, or interfaces.
Describe the solution you'd like
When a namespace is named in the .txt input file, generate all members of it:
CreateFile
windows.win32.ai.machinelearning.directml

Describe alternatives you've considered
A special ns:System.IO.* syntax:
CreateFile
User32.*
ns:windows.win32.ai.machinelearning.directml.*

Agreed. This would make things much easier for me. What would make it even better is being able to copy the namespaces from the win32metadata file verbatim into the output C# code, instead of just flattening everything into Microsoft.Windows.Sdk or whatever namespace the user specified. While I might run into name-collision errors in my code if I use two different namespaces both containing a PInvoke (or NativeMethods, or whatever) class, this problem would be easy to fix by adding e.g. using RibbonNativeMethods = Windows.Win32.UI.Ribbon.NativeMethods to the affected files.

Thanks for your thoughts, @wjk. In fact our latest version (in our CI feed) already generates types into namespaces.


BreathOfTheWild_CleanCameraRune removes text from map

This is what it looks like when it's activated:

I got it from this reddit thread, but I had the same problem.
I saw that there are multiple presets but I'm not sure how to change between them. I got this issue with the standard configuration, just pasting on graphicPacks and activating it.

Linking to the piracy subreddit? No thanks.


Integrating synthetic data generation with spatial testing functions

We now have a solid foundation for distance-based random generation of distance matrices, initialized directly or from centroids. Now, we can integrate this into the spatial analysis testing code.
This might require a few changes to be made to the synthetic_spaitial_datagen code. This is because it needs to be formatted so it returns a compatible type that the functions in spatial_analysis_test require. This PR will address those changes as well as general integration.

In addition to integrating synthetic_spatial_datagen with spatial_analysis_test, I've also added random seed initialization to test functions as well as added a few extra checks to synthetic_spatial_datagen's generate_random_centroids to ensure the data falls within acceptable parameters.

@ngreenwald, I agree in general.  In hindsight, having a set seed is not good practice for test functions, mostly because it opens the door to 'passing-seed hunting'.  But it's important to know the two main use cases for randomness in test functions.
If you're testing a function which should be guaranteed to work, no matter what the random input is, then unseeded is definitely better, if only for disallowing the 'oops, only this seed passes' problem.
If you're testing a monte-carlo method (e.g computing pi from the ratio of simulated dart-throws inside/outside a circle inscribed in a square), you would generally repeat an unseeded test several times, and assert something about the resulting statistics (e.g result has error < 0.01 at least 90% of the time).
From what I've heard about our test functions, a few of them sometimes pass, and sometimes fail (causing some agitation when pushing finished code).  If this is expected behavior, then setting their seed does still verify that the function logically works (syntactically, etc.), but it doesn't verify that it works as expected.  So to verify behavior, treating the function like a monte-carlo method is much more appropriate, using repeated tests for a statistic-based assertion.
TL;DR adam almost sold the cow for magic seeds.  If the function sometimes failing its individual test is ok/expected, then loop the test and just assert a statistic.  Otherwise, no seeds pls.

@ngreenwald @vacuousplanet yeah I agree with your comments about random seeding now. I'll remove those in my next commit.
@ngreenwald I can remove the point-wise distance matrix tests as well. I thought to include them at first because if in certain cases people need to generate the centroids first, then pass those centroids into a distance matrix generating function, it seemed reasonable to include a test to verify that this method of generating distance matrices was indeed correct in the first place. But I can see what you're saying about just testing on the distance matrix itself. After all, the end result is going to be a distance matrix anyway. So all we need to do is to just verify that the final distance matrix is correct and not whatever algorithms are used to generate the distance matrix if I understand you correctly.

You're totally right. It is important to be able to generate centroids with a given distribution, so that people can use them for testing. However, we want to try and keep the tests decoupled as much as possible.
If we want to know if a given function accurately extracts the relationships present in a distance matrix, we should just generate a distance matrix.
If we want to know if a function accurately extracts the relationships present in a set of centroids, then we should generate the centroids.
If we want to know if our function to generate centroids is correct in the first place, we should create a separate test specifically for the synthetic data generation function itself.
But having all of them linked together I think adds too much complexity.

The changes I've made include:

Removing the point-wise matrix tests inside spatial_analysis_test.

Parameter passing fix: prevent mutable objects from being passed.

Simpler code: because we don't need to test the point-wise matrix function inside spatial_analysis_test, I removed a lot of the complexity and now it's pretty simple.

Removing random seeding: the code now generates a completely random matrix on each run.

Okay cool, can you tag us for re-review once you're ready?
On Wed, Jul 15, 2020 at 1:38 PM alex-l-kong<EMAIL_ADDRESS>wrote:

The changes I've made include:

Removing the point-wise matrix tests inside spatial_analysis_test.
Parameter passing fix: prevent mutable objects from being passed.
Simpler code: because we don't need to test the point-wise matrix
function inside spatial_analysis_test, I removed a lot of the complexity
and now it's pretty simple.
Removing random seeding: the code now generates a completely random
matrix on each run.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angelolab/segmentation/pull/126#issuecomment-658996854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJB47JYTAPSW5564IQO7ALR3YHUHANCNFSM4OW2QBIQ
.

Sorry, totally blanked on this. Will respond later today
On Fri, Jul 17, 2020 at 6:26 PM alex-l-kong<EMAIL_ADDRESS>wrote:

@alex-l-kong https://github.com/alex-l-kong requested your review on:
#126 https://github.com/angelolab/segmentation/pull/126 Integrating
synthetic data generation with spatial testing functions.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/angelolab/segmentation/pull/126#event-3560373133, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJB47MCA5FNSGRMQT5DBQ3R4D24JANCNFSM4OW2QBIQ
.


[Feature] use like function for temporory native malloc/calloc object

It is quit easy to forget to free memory from toNativeUtf8 and toNativeUtf16
https://github.com/Sunbreak/logic_conf.dart/commit/956ac5afe23e51d24854329007bd63a6d518d560
-    var descriptor = _libc.open2(path.toNativeUtf8().cast(), O_RDWR);
+    var nativeUtf8 = path.toNativeUtf8();
+    var descriptor = _libc.open2(nativeUtf8.cast(), O_RDWR);
+    malloc.free(nativeUtf8);

Could we have some Kolin's use-like statement?
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/use.html
FileWriter("test.txt")
  .use { w -> w.write("something") }

Or similiar ones:

Java's try-with-resource: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
C# using: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/using-statement

Related: https://github.com/dart-lang/sdk/issues/32486

Hey, please take a look at the Pool: https://github.com/dart-lang/sdk/blob/master/samples/ffi/resource_management/pool_sample.dart#L24-L31
  // To ensure resources are freed, wrap them in a [using] call.
  using((Pool pool) {
    final p = pool<Int64>(2);

    // Do something with p.

    // p is automatically `free`d at the end of this scope.
  });

Please let me know if you find that sample useful, I could merge it to this package.

It helps a lot. https://github.com/Sunbreak/logic_conf.dart/pull/8
I'll appreciate if we could merge Pool to package:ffi

Done by #103?

Indeed.

Is this documented anywhere? I had to go searching through issues to find this feature. I  didn't think to look at the API reference because the README points to another website.
Perhaps a brief overview of the features provided by this package could be added to the README?


Feature/#406 conversion api client reimplementation

closes #406
Implements

call create_job with callback URL

Already implemented in #416, #417 & #430

ExtractionOrder.forward_to_conversion_service(...)
ConversionApiClient.create_boundary(...)
ConversionApiClient.create_parametrization(...)
ConversionApiClient.api_client.create_job(...)

Still to be adapted / fixed / re-implemented

#438 properly react (again) to conversion job status updates

(I've filed that as a new issue, as it isn't part of what the previous conversion API client was.)
Reviewed by

[ ] @hixi

These migration tests are skipped by default because they make other tests fail (probably due to Django bug #25251). To run (only) them, one may use

./runtests.py --transactional -k test_0019_one_export_per_file_format

I think having this in the Readme or development/testing documentation would be a good idea.

I think having this in the Readme or development/testing documentation would be a good idea.

See my comments on 03ac356.


Timeout

Hello,
Seems like a great app, but I'm currently having some "timeout"-issues...
My DB does open in the php ui, and all "readable" (title & username) data is visible.
But hitting a "Show" button will result in a "timeout" error message...
The DB itself is 2MB (changed the MAX_FILE_SIZE value), and it does open as you would expect...
Any ideas?
Thanks!

My best guess for now is that the database takes too much time to open on your server, and that either PHP at server side (depending on its configuration, I think the default max execution time for a script is 30s), or javascript at client side (ajax timeout time is hard-set to 20s currently), decides that it's too long.
Did you change the value of the number of encryptions of the master key in your database ? The default value is 6000, which PHP should handle fast enough based on my experience, but if you changed it, it may be too hard for PHP. If you did, try lowering it to see if it gets better. If it's still 6000 (or if you don't want to change it), you can try to change the ajax timeout time in js/main.js (line 201) to wait longer.
If none of those work, I'll try to dig deeper.

Thanks for your answer!
I'll change the execution time and let you know.
I did, for sure, change the encryption rounds. So yes, that can actually be the cause... But then it seems weird to me that the rest of the data is readable, only the passwords aren't? Or are they split up in the db itself?

Nope, they are not split up, so it would seem slightly weird to me as well. But the rest of the data is extracted from the database when it is uploaded, which does not occur through an ajax query, so in that case the only possible timeout would be due to PHP, or something else in the server. Whereas when you load a password, your client only waits for 20s.
Now, I did set the limit of 20s without much thinking about it, it may not be suitable for all cases. Maybe I should make it more flexible, or more customizable...

Yes, increasing the timeout values does indeed return the passwords! Perfect. Thanks!
They do come back really tiny in the interface, is that correct? Is it meant to be copy-pasted to become readable?

Yeah, that's the indented behaviour. I have guessed you would usually rather copy-paste them into a password field than try to read them...


soc: rcar_gen3: set correct NUM_IRQS for ARM64 R-Car Gen3 boards

Align number of interrupts for ARM64 R-Car Gen3 boards with the documentation.

@aaillet @firscity Could you please review these changes?


backport: #4689: feat: give service account permission to assign initial space members

CI looks like image pulling errors in drone - can someone retrigger?

Everything green :)


Is this line of code redundant ? this is already called inside of 'create_directory_structure_for_client' method

https://github.com/uptane/uptane/blob/68e49e12d3a2309a5dceda45af100f1d9064206e/demo/demo_primary.py#L130

I think you're right, yes. (:
Feel free to PR.


Differentiate between Adam and AdamW Optimizer

I have noticed that the code for the Adam Optimizer is actually implementing the weight decay in a manner similar to the one proposed in the AdamW paper. Should we write it as two different methods if someone wanted to test their models with Adam Optimizer rather than AdamW?

+1 @kamalesh0406
DeepMind's Optax library (JAX) also includes Adam and AdamW (https://github.com/deepmind/optax/blob/master/optax/init.py) and PyTorch has torch.optim.Adam and torch.optim.AdamW.

If I am correct, setting weight decay to 0 you will get back to Adam. It has been a while, I might be wrong

I think you should use an option for whether to degrade to SGD. Then it should be equivalent.

@kamalesh0406 FWIW you get normal Adam behaviour if you set weight_decay arg to the optimizer to 0 (the default) and apply L2 penalty (if desired) to the loss.
I think a pattern where weight_decay applied in the optimizer == decoupled decay (AdamW/SGDW style), otherwise apply L2 (or other) penalty to loss (TF/Keras style) would make sense. You'd have less duplication of optimizer code like you get with PyTorch where you have almost full duplication of code minus the two lines were WD is applied between W/non-W variants. However, the current Flax impl of Momentum already breaks that as it's weight_decay arg applies L2 in the optimizer.

@kamalesh0406 FWIW you get normal Adam behaviour if you set weight_decay arg to the optimizer to 0 (the default) and apply L2 penalty (if desired) to the loss.
I think a pattern where weight_decay applied in the optimizer == decoupled decay (AdamW/SGDW style), otherwise apply L2 (or other) penalty to loss (TF/Keras style) would make sense. You'd have less duplication of optimizer code like you get with PyTorch where you have almost full duplication of code minus the two lines were WD is applied between W/non-W variants. However, the current Flax impl of Momentum already breaks that as it's weight_decay arg applies L2 in the optimizer.

Closing this issue as we're moving to recommend the use of optax rather than internal optimizers (which does separate out weight decay from adam update).

Closing this issue as we're moving to recommend the use of optax rather than internal optimizers (which does separate out weight decay from adam update).

Thanks @levskaya 👍
@kamalesh0406 fyi ⬇

DeepMind's Optax library (JAX) also includes Adam and AdamW (https://github.com/deepmind/optax/blob/master/optax/init.py)

Optax repo: https://github.com/deepmind/optax
Optax docs: https://optax.readthedocs.io/en/latest/
Hope this helps


Inject test case enabled experimental features

This accidentally got omitted when I split off the experimental feature work.

@swift-ci please test


allow max 0 nodes for awsmachinedeployments

Towards https://github.com/giantswarm/giantswarm/issues/17349

Yes, I just wanted to give a heads up :)
I tested this on ginger and it works.


Show link to plate viewer on dataset page

The vizarr viewer links on the dataset page are very useful!
Currently, we only link to the individual images, e.g. the full zarr url. For example:
https://fractal.mls.uzh.ch/vizarr/?source=https://fractal.mls.uzh.ch/vizarr/data/data/active/jluethi/Fractal/20240723_23well_benchmark/20200812-CardiomyocyteDifferentiation14-Cycle1_mip.zarr/B/03/0

A thing that is also super useful is linking to the plate view. By going to this url:
https://fractal.mls.uzh.ch/vizarr/?source=https://fractal.mls.uzh.ch/vizarr/data/data/active/jluethi/Fractal/20240723_23well_benchmark/20200812-CardiomyocyteDifferentiation14-Cycle1_mip.zarr
(just removing the sub path to row, col & image)
We see:

We have metadata about whether a dataset has plates and what plates are available in the image list:

The goal would be that:
If there are plates in the image list
Show selector for which plate to load. And show a button for "view plate" that send the user to the link above.
This should be displayed above the image list for the moment. I may have additional ideas of where we expose this in the future :)

How do we get the plate url? I'd say we take the first zarr_url with the plate attribute. Given its zarr_url, we reconstruct the plate url. I see 2 ways:

We already extract the base path to avoid displaying it. We can just to base path + plate name
We could also look at the full zarr_url, find the plate name in the url & drop everything after that from the url

Example of image list
zarr_url, plate
/some/plate1.zarr/B/03/0, "plate1"
/some/plate1.zarr/B/04/0, "plate1"
/some/plate2.zarr/A/03/0, "plate2"

Check If "plate" is one of the images attributes, otherwise stop.
Write component on top of image list, with message "Detected 2 plates, choose one to view it (dropdown showing "plate1" or "plate2")
User clicks "plate1"

If no image with plate1 is currently available, make an API call filtering for plate=plate1 and asking for page-size =1
GIven the zarr_url of one plate1 image, remote the last three levels
Create vizarr link, and display a "View" button (next to the dropdown, not in the image list)

Example of View plate button (notice the URL previewed in the bottom of the screenshot):

If the zarr URL is not valid (it has less than 3 elements) an error is displayed:

This looks like a great start for this feature! 👏🏻
Minor wording suggestion:
"This dataset contains 3 plates. Select which plate you want to view"

I tested #562, and it works as expected.
I imported this dataset
{
  "name": "test-2",
  "zarr_dir": "/tmp/some/path/",
  "images": [
    { "zarr_url": "/tmp/some/path/plate1/we/ll/a", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/b", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/c", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/d", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/e", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/f", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/g", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate1/we/ll/h", "origin": null, "attributes": { "plate": "plate1" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/a", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/b", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/c", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/d", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/e", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/f", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/g", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate2/we/ll/h", "origin": null, "attributes": { "plate": "plate2" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/a", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/b", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/c", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/d", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/e", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/f", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/g", "origin": null, "attributes": { "plate": "plate3" }, "types": {} },
    { "zarr_url": "/tmp/some/path/plate3/we/ll/h", "origin": null, "attributes": { "plate": "plate3" }, "types": {} }
  ],
  "filters": {
    "attributes": {},
    "types": {}
  }
}

and got this page

The "View" button of the first image points to http://localhost:3000/?source=http://localhost:3000/data/tmp/some/path/plate1/we/ll/a.

I selected "plate2", and got

where the "View" button points to http://localhost:3000/?source=http://localhost:3000/data/tmp/some/path/plate2


Training time about Multi GPUs and Single GPU

Hi
I have a question about how many time we can save when we change from single GPU to multi GPUs?
I don't have imageNet on my server, so can anyone show me the single step time (loading data + forward time + backward time) of the multi GPUs version and single GPU?
Thank you very much!

I had trained the Cifar 10 dataset with the resnet model.
Four GPUs   about 3hours.
Single GPU about 10hours.


Non-deterministic "fuse" behavior

Should fuse behave in a deterministic manner? I've noticed that one of the fuse docs examples I previously created fails the automated tests occasionally because its output sometimes flips.
Using the Zeek TSV zq-sample-data, as of zq commit 0759cc38 this base output seems to be generated deterministically:
$ zq -t 'ts <<PHONE_NUMBER>' stats.log.gz weird.log.gz
#0:record[_path:string,ts:time,peer:bstring,mem:uint64,pkts_proc:uint64,bytes_recv:uint64,pkts_dropped:uint64,pkts_link:uint64,pkt_lag:duration,events_proc:uint64,events_queued:uint64,active_tcp_conns:uint64,active_udp_conns:uint64,active_icmp_conns:uint64,tcp_conns:uint64,udp_conns:uint64,icmp_conns:uint64,timers:uint64,active_timers:uint64,files:uint64,active_files:uint64,dns_requests:uint64,active_dns_requests:uint64,reassem_tcp_size:uint64,reassem_file_size:uint64,reassem_frag_size:uint64,reassem_unknown_size:uint64]
0:[stats;1521911720.600725;zeek;74;26;29375;-;-;-;404;11;1;0;0;1;0;0;36;32;0;0;0;0;1528;0;0;0;]
#port=uint16
#1:record[_path:string,ts:time,uid:bstring,id:record[orig_h:ip,orig_p:port,resp_h:ip,resp_p:port],name:bstring,addl:bstring,notice:bool,peer:bstring]
1:[weird;1521911720.600843;C1zOivgBT6dBmknqk;[<IP_ADDRESS>;49562;<IP_ADDRESS>;80;]TCP_ack_underflow_or_misorder;-;F;zeek;]
1:[weird;1521911720.608108;-;[-;-;-;-;]truncated_header;-;F;zeek;]
1:[weird;1521911720.610033;C45Ff03lESjMQQQej1;[<IP_ADDRESS>;40712;<IP_ADDRESS>;80;]above_hole_data_without_any_acks;-;F;zeek;]
1:[weird;1521911720.742818;Cs7J9j2xFQcazrg7Nc;[<IP_ADDRESS>;5900;<IP_ADDRESS>;58485;]connection_originator_SYN_ack;-;F;zeek;]

However, if I fuse it and turn it into CSV output, sometimes the first unique columns are the ones associated with the weird events:
$ zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz
_path,ts,uid,id.orig_h,id.orig_p,id.resp_h,id.resp_p,name,addl,notice,peer,mem,pkts_proc,bytes_recv,pkts_dropped,pkts_link,pkt_lag,events_proc,events_queued,active_tcp_conns,active_udp_conns,active_icmp_conns,tcp_conns,udp_conns,icmp_conns,timers,active_timers,files,active_files,dns_requests,active_dns_requests,reassem_tcp_size,reassem_file_size,reassem_frag_size,reassem_unknown_size
stats,2018-03-24T17:15:20.600725Z,-,-,-,-,-,-,-,-,zeek,74,26,29375,-,-,-,404,11,1,0,0,1,0,0,36,32,0,0,0,0,1528,0,0,0
weird,2018-03-24T17:15:20.600843Z,C1zOivgBT6dBmknqk,<IP_ADDRESS>,49562,<IP_ADDRESS>,80,TCP_ack_underflow_or_misorder,-,F,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-
weird,2018-03-24T17:15:20.608108Z,-,-,-,-,-,truncated_header,-,F,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-
weird,2018-03-24T17:15:20.610033Z,C45Ff03lESjMQQQej1,<IP_ADDRESS>,40712,<IP_ADDRESS>,80,above_hole_data_without_any_acks,-,F,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-
weird,2018-03-24T17:15:20.742818Z,Cs7J9j2xFQcazrg7Nc,<IP_ADDRESS>,5900,<IP_ADDRESS>,58485,connection_originator_SYN_ack,-,F,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-

Then sometimes (less frequently, it seems) the first unique columns are the ones associated with the stats event:
$ zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz
_path,ts,peer,mem,pkts_proc,bytes_recv,pkts_dropped,pkts_link,pkt_lag,events_proc,events_queued,active_tcp_conns,active_udp_conns,active_icmp_conns,tcp_conns,udp_conns,icmp_conns,timers,active_timers,files,active_files,dns_requests,active_dns_requests,reassem_tcp_size,reassem_file_size,reassem_frag_size,reassem_unknown_size,uid,id.orig_h,id.orig_p,id.resp_h,id.resp_p,name,addl,notice
stats,2018-03-24T17:15:20.600725Z,zeek,74,26,29375,-,-,-,404,11,1,0,0,1,0,0,36,32,0,0,0,0,1528,0,0,0,-,-,-,-,-,-,-,-
weird,2018-03-24T17:15:20.600843Z,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,C1zOivgBT6dBmknqk,<IP_ADDRESS>,49562,<IP_ADDRESS>,80,TCP_ack_underflow_or_misorder,-,F
weird,2018-03-24T17:15:20.608108Z,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,truncated_header,-,F
weird,2018-03-24T17:15:20.610033Z,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,C45Ff03lESjMQQQej1,<IP_ADDRESS>,40712,<IP_ADDRESS>,80,above_hole_data_without_any_acks,-,F
weird,2018-03-24T17:15:20.742818Z,zeek,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,Cs7J9j2xFQcazrg7Nc,<IP_ADDRESS>,5900,<IP_ADDRESS>,58485,connection_originator_SYN_ack,-,F

This is surprising to me so we should have a look.

@mccanne: This failure happens because a zbuf.Merger reads from each underlying zbuf.Reader in a separate goroutine, so reads don't happen in deterministic order, and consequently, the associated resolver.Context doesn't always assign the same type ID to a given type. Because type IDs determine the order in which proc/fuse.Fuser.finish mixes types into its schema, the schema will change if the relative order of type IDs changes, and that's what's going on here.

As a note-to-self for when this gets fixed and I want to verify it, here's some quick scripting that repeats the operation on the zq-sample-data until it fails. The expectation is that when we have a fix that makes the output deterministic, this should loop until the cows come home. Here's an example of it still failing as of zq commit 1e501e85.
$ zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/baseline ; CYCLES=0 ; while true; do echo "$CYCLES successful cycles"; zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/repeat; diff /tmp/baseline /tmp/repeat; if [ $? -ne 0 ] ; then break ; fi ; CYCLES=$(expr $CYCLES + 1); done
0 successful cycles
1 successful cycles
2 successful cycles
1,6c1,6
< _path,ts,uid,id.orig_h,id.orig_p,id.resp_h,id.resp_p,name,addl,notice,peer,mem,pkts_proc,bytes_recv,pkts_dropped,pkts_link,pkt_lag,events_proc,events_queued,active_tcp_conns,active_udp_conns,active_icmp_conns,tcp_conns,udp_conns,icmp_conns,timers,active_timers,files,active_files,dns_requests,active_dns_requests,reassem_tcp_size,reassem_file_size,reassem_frag_size,reassem_unknown_size
< stats,2018-03-24T17:15:20.600725Z,,,,,,,,,zeek,74,26,29375,,,,404,11,1,0,0,1,0,0,36,32,0,0,0,0,1528,0,0,0
< weird,2018-03-24T17:15:20.600843Z,C1zOivgBT6dBmknqk,<IP_ADDRESS>,49562,<IP_ADDRESS>,80,TCP_ack_underflow_or_misorder,,F,zeek,,,,,,,,,,,,,,,,,,,,,,,,
< weird,2018-03-24T17:15:20.608108Z,,,,,,truncated_header,,F,zeek,,,,,,,,,,,,,,,,,,,,,,,,
< weird,2018-03-24T17:15:20.610033Z,C45Ff03lESjMQQQej1,<IP_ADDRESS>,40712,<IP_ADDRESS>,80,above_hole_data_without_any_acks,,F,zeek,,,,,,,,,,,,,,,,,,,,,,,,
< weird,2018-03-24T17:15:20.742818Z,Cs7J9j2xFQcazrg7Nc,<IP_ADDRESS>,5900,<IP_ADDRESS>,58485,connection_originator_SYN_ack,,F,zeek,,,,,,,,,,,,,,,,,,,,,,,,
---
> _path,ts,peer,mem,pkts_proc,bytes_recv,pkts_dropped,pkts_link,pkt_lag,events_proc,events_queued,active_tcp_conns,active_udp_conns,active_icmp_conns,tcp_conns,udp_conns,icmp_conns,timers,active_timers,files,active_files,dns_requests,active_dns_requests,reassem_tcp_size,reassem_file_size,reassem_frag_size,reassem_unknown_size,uid,id.orig_h,id.orig_p,id.resp_h,id.resp_p,name,addl,notice
> stats,2018-03-24T17:15:20.600725Z,zeek,74,26,29375,,,,404,11,1,0,0,1,0,0,36,32,0,0,0,0,1528,0,0,0,,,,,,,,
> weird,2018-03-24T17:15:20.600843Z,zeek,,,,,,,,,,,,,,,,,,,,,,,,,C1zOivgBT6dBmknqk,<IP_ADDRESS>,49562,<IP_ADDRESS>,80,TCP_ack_underflow_or_misorder,,F
> weird,2018-03-24T17:15:20.608108Z,zeek,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,truncated_header,,F
> weird,2018-03-24T17:15:20.610033Z,zeek,,,,,,,,,,,,,,,,,,,,,,,,,C45Ff03lESjMQQQej1,<IP_ADDRESS>,40712,<IP_ADDRESS>,80,above_hole_data_without_any_acks,,F
> weird,2018-03-24T17:15:20.742818Z,zeek,,,,,,,,,,,,,,,,,,,,,,,,,Cs7J9j2xFQcazrg7Nc,<IP_ADDRESS>,5900,<IP_ADDRESS>,58485,connection_originator_SYN_ack,,F

I believe this is caused by the indeterminate assignment of type IDs in the readers.  The schema in the fuser is sorted by type ID so whichever has the smallest type ID goes first and there is a race as to which reader gets the type IDs when data is read from multiple inputs.
We can fix this by keeping the types encountered sorted by the order in which they were encountered rather than by type ID.

I believe this is caused by the indeterminate assignment of type IDs in the readers.  The schema in the fuser is sorted by type ID so whichever has the smallest type ID goes first and there is a race as to which reader gets the type IDs when data is read from multiple inputs.
We can fix this by keeping the types encountered sorted by the order in which they were encountered rather than by type ID.

Verified in zq commit 6f37372b.
Repeating the test from my "note-to-self" above, this now does indeed run clean indefinitely.
$ zq -version
Version: v0.27.1-13-g6f37372b

$ zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/baseline ; CYCLES=0 ; while true; do echo "$CYCLES successful cycles"; zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/repeat; diff /tmp/baseline /tmp/repeat; if [ $? -ne 0 ] ; then break ; fi ; CYCLES=$(expr $CYCLES + 1); done
0 successful cycles
1 successful cycles
2 successful cycles
3 successful cycles
...
2786 successful cycles
2787 successful cycles
2788 successful cycles
...

Thanks @mccanne!

Verified in zq commit 6f37372b.
Repeating the test from my "note-to-self" above, this now does indeed run clean indefinitely.
$ zq -version
Version: v0.27.1-13-g6f37372b

$ zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/baseline ; CYCLES=0 ; while true; do echo "$CYCLES successful cycles"; zq -f csv 'ts <<PHONE_NUMBER> | fuse' stats.log.gz weird.log.gz > /tmp/repeat; diff /tmp/baseline /tmp/repeat; if [ $? -ne 0 ] ; then break ; fi ; CYCLES=$(expr $CYCLES + 1); done
0 successful cycles
1 successful cycles
2 successful cycles
3 successful cycles
...
2786 successful cycles
2787 successful cycles
2788 successful cycles
...

Thanks @mccanne!


BaseConverter 2.0.4 submission

Could you do me a favor to change all the icon to jsdelivr so people who has issue with github can access the icon. https://www.jsdelivr.com/

Changed on #144, #145, #146 and #147


Attribute XXXX has been defined

Hi Jorge,
I use the library but when i make build, AS shows me the message:
Error:(2) Attribute "strokeWidth" has already been defined
Error:(2) Attribute "fillColor" has already been defined
Error:(2) Attribute "strokeColor" has already been defined
I think that the names of these attributes are too generic and conflict with other popular libraries and can not use yours.
I hope that solutions soon, greetings.

Hello. It is a known bug and i am going to fix it right now, but i would need to know which library is getting in conflict with those values, so i can be able to reproduce the compilation fail. Could you give me the name of the library?
Thanks in advance.

Ok, nevermind. It has been fixed and a new version has been released.
compile 'com.github.jorgecastilloprz:fillableloaders:1.02@aar'

Check out the Changelog to get more details about the new custom attribute syntax and more features that have been added to the lib.
Cheers!


Fixed formatting in helpers-testsuite

There was a small formatting error in the last commit of #473.
This commit and pull request only fixes the formatting and leaves any functions of the code untouched.
As such, bumping the version and publishing on npm is not necessary for this fix.
(My bad for missing it last time, my IDE did some code completion with wrong formatting settings when writing the tests).

Thanks @Nimelrian. Merging.


Content update to payment advice for Vietnam marriages.

Trello Card
Motivation
This change has become necessary as a result a request from FCO requesting that the Vietnam payment information be updated/changed to contain payment information below.

You can pay fees for consular services in the local currency or pounds sterling - these are shown in the list of consular fees for Vietnam.
You can pay in cash or by credit card (Visa, Visa Electron or MasterCard), but not by personal cheque.

Currently is:

You can pay fees for consular services in cash (in the local currency or pounds sterling) or by Visa or MasterCard - these are shown in the list of consular fees for Vietnam.

Factcheck Opposite sex
Expected changes;

Content change to the payment advice affecting all marriages in Vietnam.

Before

After

Factcheck Same sex
Expected changes;

Content change to the payment advice affecting all marriages in Vietnam.

Before

After

Affected pages
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/ceremony_country/partner_british/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/ceremony_country/partner_british/same_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/ceremony_country/partner_local/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/ceremony_country/partner_other/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/ceremony_country/partner_other/same_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/third_country/partner_british/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/third_country/partner_british/same_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/third_country/partner_local/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/third_country/partner_other/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/third_country/partner_other/same_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/uk/partner_british/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/uk/partner_british/same_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/uk/partner_local/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/uk/partner_other/opposite_sex
https://smart-answers-pr-2592.herokuapp.com/marriage-abroad/y/vietnam/uk/partner_other/same_sex

I don't think this implementation is quite right, @ikennaokpala.
In master, there are two partials that link to consular fees:

_consular_fees_in_cash_visa_master.govspeak.erb

This is a special case for two reasons: It's only used for Vietnam and it also includes information about how you can pay (cash, Visa or MasterCard)

_link_to_consular_fees.govspeak.erb

This is used for every other country

And there are 14 partials (in payment_information_partials) that give more information about how you can pay for the various services.
The implementation in this branch mixes these two concepts by introducing a payment information partial that also includes a link to consular fees. I think the link to consular fees should remain separate from the payment information. At least as far as this change is concerned.
I think the simplest change might be to rename "_consular_fees_in_cash_visa_master.govspeak.erb" to "_link_to_consular_fees_pay_in_sterling_or_local_currency.govspeak.erb", and update it to contain:
You can pay fees for consular services in the local currency or pounds sterling - these are shown in the list of [consular fees for <%= calculator.country_name_lowercase_prefix %>](/government/publications/<%= calculator.ceremony_country %>-consular-fees).

You can then add another payment information partial named something like "_pay_by_cash_or_credit_card_no_personal_cheque.govspeak.erb" that contains:
You can pay in cash or by credit card (Visa, Visa Electron or MasterCard), but not by personal cheque.

Note that this new partial would be very similar to "_pay_by_cash_or_credit_card_no_cheque.govspeak.erb". Hopefully we'll be able to reduce some of this duplication when we get some more information about rationalising the payment information partials.
Does that make sense?

@chrisroos Yes it does make sense

@chrisroos over to you..

This looks good to me, @ikennaokpala. Thanks for updating it :-)

LGTM 👍  Sorry for huge delay.

@sistephens thanks for letting us know.. will prepare this PR for release..


✨ useLocalStorage composable

Might be needed (#5057)
Usage
const walletProvider = useLocalStorage('wallet')

Wondering why not cone from vue-use?

Wondering why not cone from vue-use?

Forgot useStorage exist.

When using with Nuxt 3, this functions will NOT be auto imported in favor of Nitro's built-in useStorage(). Use explicit import if you want to use the function from VueUse.

I prefer to rely on simple tools rather than having to maintain package version upgrade.
Feel free to close it if not needed.

Wondering why not cone from vue-use?

Forgot useStorage exist.

When using with Nuxt 3, this functions will NOT be auto imported in favor of Nitro's built-in useStorage(). Use explicit import if you want to use the function from VueUse.

I prefer to rely on simple tools r - ather than having to maintain package version upgrade.
Feel free to close it if not needed.

If we reexport use storage to use local storage

cc @roiLeo

If we reexport use storage to use local storage


Clone student repo and clone tests and assignments only on changes; otherwise copy from local repo

Add qcm tool for cloning and testing test execution locally
Added support for merge and running tests locally
Fixed lint issue due to unhandled err when closing
Clone also assignments repo when running tests
Fixed ScanStudentRepo path argument
Updated docs with info about SUBMITTED env var
Fixed run.sh scripts to use %s
Clone now pulls if local repository already exists
Add QUICKFEED_REPOSITORY_PATH and Course.CloneDir()
Refactored UpdateFromTestsRepo to require scm.SCM instead of scm.Manager
Clone assignments repository on push event
Updated Dockerfile to golang:1.19-alpine
Pass scm.SCM instead of scmMgr.GetOrCreateSCM()
Only copy tests and assignments repos from disk

Fixes #795
Extends or superceds #788

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

27 of 209 (12.92%)  changed or added relevant lines in 12 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 24.205%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

scm/mock.go
0
1
0.0%

qf/course.go
0
3
0.0%

qf/repo.go
0
3
0.0%

internal/env/scm.go
0
6
0.0%

web/quickfeed_service.go
0
7
0.0%

assignments/assignments.go
0
13
0.0%

scm/fetcher.go
0
24
0.0%

web/hooks/push.go
0
25
0.0%

ci/clone_repositories.go
0
28
0.0%

ci/run_tests.go
0
72
0.0%

Files with Coverage Reduction
New Missed Lines
%

assignments/assignments.go
1
21.0%

web/quickfeed_service.go
1
37.05%

ci/clone_repositories.go
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
2649

Relevant Lines:
10944

💛  - Coveralls

Codecov Report

Merging #804 (9aea5cb) into master (c3ba67a) will decrease coverage by 0.14%.
The diff coverage is 12.62%.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   22.31%   22.16%   -0.15%
==========================================
  Files          88       88
  Lines       10416    10534     +118
==========================================
+ Hits         2324     2335      +11
- Misses       7819     7926     +107
  Partials      273      273

Flag
Coverage Δ

unittests
22.16% <12.62%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

assignments/assignments.go
18.00% <0.00%> (+1.33%)
:arrow_up:

ci/clone_repositories.go
0.00% <0.00%> (ø)

ci/run_tests.go
5.04% <0.00%> (-7.46%)
:arrow_down:

internal/env/scm.go
20.40% <0.00%> (-2.85%)
:arrow_down:

qf/course.go
0.00% <0.00%> (ø)

qf/repo.go
21.15% <0.00%> (-0.85%)
:arrow_down:

scm/fetcher.go
0.00% <0.00%> (ø)

scm/mock.go
3.00% <0.00%> (ø)

web/hooks/push.go
0.00% <0.00%> (ø)

web/quickfeed_service.go
30.42% <0.00%> (-0.35%)
:arrow_down:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Greyscaled tab indicator.

Black: active tab
Gray: on-hovering
/cc @mit-mit

It looks a bit odd with the blue text and black highlight bar. Can you try to make the text black?

Can you try to make the text black?

The text is already black, but we can make the rest of the tabs lighter, and the selected one bold. What about this?

Although the bolding makes the line a bit to "move" on tab switching, and it is not bad without bold either:

Last example (black, no bold) LGTM!

The indention style looks a tiny bit inconsistent in this stylesheet.

It is, as it is a mixture of an old style, a new design which was handed to us, and our additional updates. I'm trying to make it more consistent (two tabs), but looks like I've missed it this time, will fix.


1.0.0 alpha keyboard support

I'm going to do a rough pass at adding basic keyboard support to all plugins that it makes sense in.
Plugins:

[x] Collapsible
[x] Dropdown
[x] Tabs
[x] Tooltips

Collapsible keyboard support added in e6e83bdb

Tabs focus style added in d1ae3cff7a211dbebdc742ff20d566efba2299b0

Tooltips open when element is focused added in 1428c72d


bug in new sap.m.Text()

OpenUI5 version: 1.91, 1.88
Browser/version (+device/version): chrome 91.0.4472.114, safari 14.1.1
Steps to reproduce the problem:

create a new sap.m.Text in controller.
in text field place any text with { } (opening and closing curly braces)

new Text({
        text:  test text {\"message\" : \" Error occurred at API call https://abc.com \"} test text"
})

the Text is taking braces as parts and "message" is not a valid key for parts causing the issue
What is the expected result?
the bug is found in ExpandableText.js at line 277.
While clicking on more button extra text should come in a popup
What happens instead?
window reloaded to home page

This is the same kind of problem as described in #3175, #3156, #3153, #3151, #3445, #2233 or #1595. A detailed explanation of the matter can be found here.
Needs to be fixed in the ExpandableText.js.

This is the same kind of problem as described in #3175, #3156, #3153, #3151, #3445, #2233 or #1595. A detailed explanation of the matter can be found here.
Needs to be fixed in the ExpandableText.js.

so all that is need in ExpandableText.js is to use setText() function after having the object of sap.m.Text class instead of giving text in constructor.

Hello @himanshuPandey25
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Georgi

Hi,
When setting string values, any curly braces in those values need to be escaped, so they are not interpreted as binding expressions. You can use "sap.ui.base.ManagedObject.escapeSettingsValue" to do so.
new sap.m.Text({
				text:  sap.ui.base.ManagedObject.escapeSettingsValue("test text {\"message\" : \" Error occurred at API call https://abc.com \"} test text")
			})

The same for the sap.m.ExpandableText.
Best,
Teo

@TeodorTaushanov Isn't it the responsibility of sap.m.ExpandableText to fix when creating sap.m.Text internally?
https://github.com/SAP/openui5/blob/a522c97cb959b091e20b3fe10626817a4b301940/src/sap.m/src/sap/m/ExpandableText.js#L275-L276

Hi,
The issue is fixed in the master branch.
Best,
Teo


gdm install shouldn't bump version numbers

After running gdm install I noticed that the version changed even though the dependency was already installed.  Seems like only upgrade should do this.

Is this specifically referring to cases where a list of dependencies is provided? (e.g. gdm install dep_a dep_b)

I take this back, this has to have happened from running gdm upgrade for a specific dependency.  We had reason to believe that this was from a running of gdm install, but after evaluating the commands run I'm pretty sure that gdm upgraded more than the specified dependency.

I'm going to consider this a feature request to also apply the dependency filtering behavior (e.g. gdm update foo bar) to the locking of those dependency versions. Currently gdm will record all dependency versions.

@jasich @karlin This should give you the behavior you want: $ pip3 install gdm==0.7.dev1

This behavior is now available in 0.7.


Failed to connect to remote extension host server

Issue Type: Bug
Remote Development authenticates fine but shows an error and won't let me continue.
"Failed to connect to the remote extension host server (Error: Connection error: Unauthorized client refused.)
The remote server is CentOS release 6.10 (Final).
uname -a
Linux server.com 2.6.32-696.18.7.el6.x86_64 #1 SMP Thu Jan 4 17:31:22 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
bash --version
GNU bash, version 4.1.2(2)-release (x86_64-redhat-linux-gnu)

VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z)
OS version: Darwin x64 18.5.0
Fetching remote diagnostics for 'SSH: server.com' failed: Connection error: Unauthorized client refused.

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: unavailable_offsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (0.27GB free)

Process Argv

Screen Reader
no

VM
0%

Fetching remote diagnostics for 'SSH: server.com' failed: Connection error: Unauthorized client refused.
Extensions: none

Ahh, possibly a duplicate of https://github.com/Microsoft/vscode-remote-release/issues/84 and should be moved there.

@wreiske Try to check here https://code.visualstudio.com/docs/remote/troubleshooting#_enabling-alternate-ssh-authentication-methods if enabling remote.SSH.showLoginTerminal possibly gives you another hint why it fails.


include Nix package in installation docs

I was able to get drogon into the Nix package manager (nixos/nixpkgs#127117).  I feel it would be appropriate to include it in the installation section.  I'll submit a PR when I get the chance.

Yes, please! thanks so much.


[feat] built in prometheus metrics

Is your feature request related to a problem? Please describe.
Hi 👋🏼
I would like to get notified if a device battery is low, or becomes unpair / unavailable. I already use prometheus and alertmanager so if zwavejs2mqtt could support this feature out of the box I could have alerts and metrics. There's a lot of people using prometheus and alertmanager so this would not only benefit me :)
Describe the solution you'd like
Build into zwavejs2mqtt something like https://github.com/kvaster/zwavejs-prom found in this issue https://github.com/zwave-js/zwavejs2mqtt/issues/1303
Thanks!

No problem, I could add it to deps so you just have to specify it in plugins to use it

@kvaster Is the plugin pèublished to npm? If not could you publish it to npm?
I could suggest to use @zwave-js-ui/plugin-prometheus as name

@robertsLando, it's not yet published. I will do it in a one week as soon as I will settle in a new place...

Ok thanks! :)

Published to: https://www.npmjs.com/package/@kvaster/zwavejs-prom

Thanks @kvaster ! :)

@robertsLando and @kvaster much appreciated on this. Thanks for the quick turn around!

Available in 7.1.0 🚀