Java IO exception while using the library in kotlin

Hello. I used the library in my application which is written in Kotlin. I translated the code into kotlin and did some fixes but I am getting
java.io.IOException: read failed, socket might closed or timeout, read ret: -1
again and again. This post from stackEx() deals with this but I guess that deals with a different problem.
I am afixing my mainActivity which is just the java code translated into kotlin. To be precise onError is giving the error which is called onConnect
Thanks

package com.bottlerunner.bluetoothlibrabrytesting

import android.Manifest
import android.bluetooth.BluetoothDevice
import android.bluetooth.BluetoothSocket
import android.content.pm.PackageManager
import android.os.Bundle
import android.util.Log
import android.widget.Button
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity
import androidx.core.app.ActivityCompat
import com.harrysoft.androidbluetoothserial.BluetoothManager
import com.harrysoft.androidbluetoothserial.BluetoothSerialDevice
import com.harrysoft.androidbluetoothserial.SimpleBluetoothDeviceInterface
import io.reactivex.android.schedulers.AndroidSchedulers
import io.reactivex.functions.Consumer
import io.reactivex.schedulers.Schedulers
import javax.xml.transform.ErrorListener

class MainActivity : AppCompatActivity() {

    val bluetoothManager: BluetoothManager = BluetoothManager.getInstance() //Harry's bluetooth manager

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)

        connectDevice("FC:AA:B6:AA:AC:22")

        val pairedDevices: Collection<BluetoothDevice> = bluetoothManager.pairedDevicesList
        for (device in pairedDevices) {
            if (ActivityCompat.checkSelfPermission(
                    this,
                    Manifest.permission.BLUETOOTH_CONNECT
                ) != PackageManager.PERMISSION_GRANTED
            ) {
                Toast.makeText(this,"permission denied",Toast.LENGTH_SHORT).show()

            }

            Log.d("My Bluetooth App", "Device name: " + device.name)
            Log.d("My Bluetooth App", "Device MAC Address: " + device.address)
            Log.d("Debugg",device.bondState.toString())
        }

        val btn = findViewById<Button>(R.id.button)
        btn.setOnClickListener {
            connectDevice("FC:AA:B6:AA:AC:22")          //Tab
            ActivityCompat.requestPermissions(this, arrayOf( Manifest.permission.BLUETOOTH),0  )
            Log.d("Permission","Reached end of btn")
        }

    }

    override fun onRequestPermissionsResult(
        requestCode: Int,
        permissions: Array<out String>,
        grantResults: IntArray
    ) {
        if (requestCode == 1) {
            // Request for camera permission.
            if (grantResults.size == 1 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                // Permission has been granted. Start camera preview Activity.
                Log.d("Permission","Reached onRequestPermissionResult")
                ActivityCompat.requestPermissions(this, arrayOf( Manifest.permission.BLUETOOTH),0  )
                Toast.makeText(this,"Permission granted",Toast.LENGTH_SHORT).show()
            } else {
                Toast.makeText(this,grantResults.toString(),Toast.LENGTH_SHORT).show()}
        }
        super.onRequestPermissionsResult(requestCode, permissions, grantResults)
    }

    var onMessageSentListener = SimpleBluetoothDeviceInterface.OnMessageSentListener{
        Toast.makeText(this, "Sent a message! Message was: " + it, Toast.LENGTH_LONG).show() // Replace context with your context instance.
    }

    var onMessageReveivedListener = SimpleBluetoothDeviceInterface.OnMessageReceivedListener{
        // We received a message! Handle it here.
        Toast.makeText(this, "Received a message! Message was: " + it, Toast.LENGTH_LONG).show(); // Replace context with your context instance.
    }

    var errorListener = SimpleBluetoothDeviceInterface.OnErrorListener{
        Toast.makeText(this,"Durr phite muh, error" + it.message, Toast.LENGTH_SHORT).show()
    }

    lateinit var deviceInterface: SimpleBluetoothDeviceInterface

    var onConnected = Consumer<BluetoothSerialDevice>{
        // You are now connected to this device!
        // Here you may want to retain an instance to your device:
        deviceInterface = it.toSimpleDeviceInterface()

        // Listen to bluetooth events
        deviceInterface.setListeners(onMessageReveivedListener, onMessageSentListener, errorListener)

        // Let's send a message:
        deviceInterface.sendMessage("Hello world!")
    }

    var onError = Consumer<Throwable> {
        Toast.makeText(this, "How lovely error" +it.message,Toast.LENGTH_SHORT).show()
        Log.d("onError" ,it.message + "\n"+ it.cause)

    }

    fun connectDevice(mac:String) {
        bluetoothManager.openSerialDevice(mac)
            .subscribeOn(Schedulers.io())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribe(onConnected, onError)
        Log.d("Debugg","reached 114")
    }

}

Hi @shashankRanaNoidaWala where you able to solve this issue? I'm running into the same and I'm trying to know if the stack exchange that you posted helped you solving it or not. Thanks!

No it didn't help, in the end I used Android Bluetooth Standard Library, which is more fragmented and cumbersome but did the job.

Thank you. Was the device you were trying to connect a Bluetooth Low-Energy or Bluetooth Classic? I read in another issue that this library does not support BLE devices.

Bluetooth classic HC-05.

The issue still persists. sad.


chore: remove error body from connection error message

Signed-off-by: Sonia Sandler<EMAIL_ADDRESS>What does this PR do?
This PR remove the error body from the connection failed message
Screenshot / video of UI

What issues does this PR fix or reference?
Fixes https://github.com/podman-desktop/podman-desktop/issues/9942

How to test this PR?

[X] Tests are covering the bug fix or the new feature

With this PR, there will still be a lot of messages, but they will be shorter.
Based on https://github.com/podman-desktop/podman-desktop/issues/9942#issuecomment-2482883717, if it is still relevant, it looks like these messages will be changed, but if we prefer reducing their number for now, for example just showing a message on the first try, I can update this PR


Google Drive Music Player

The bar that is supposed to be able to be clicked in order to jump or revert to a specific time of an audio file is not functional so in order to replay a segment I have to completely restart the entire audio and just wait for the it to get back to the time I needed to listen to.

You are using which browser?

short story long: it's because of a bug in Google Drive. Please see issue #31 we'll update this bug :)


Fix bug with sending file to jinja2 template loader

Signed-off-by: Radu Andries<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix a bug with template loading. Jinja2 expects the dir, then just the filename.
Does this PR introduce a user-facing change?:

Fix a bug with loading the builtin kilt template

LGTM label has been added.  Git tree hash: adb473be4d4f8dba2a86a541cdfb519d6a86212e

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


code-quality wf

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f4c630). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   86.42%
  Complexity        ?      187
=========================================
  Files             ?       50
  Lines             ?      582
  Branches          ?       26
=========================================
  Hits              ?      503
  Misses            ?       68
  Partials          ?       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c630...ccdd3b3. Read the comment docs.


Text cursor not displaying when duplicating in file system (4.3)

Tested versions

Reproducible in 4.3.dev6

System information
Godot v4.3.dev6 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 (NVIDIA; <IP_ADDRESS>19) - 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 Threads)
Issue description
When duplicating assets in the file system dock, the text cursor (the | bar that flashes showing where you're selecting) doesn't display.
You can highlight chunks of text like normal:

But when not highlighting text, the flashing | doesn't show, so can't tell where text will appear when you type:

Steps to reproduce

Duplicate any asset from the file system dock
A popup opens asking you to name the duplicate. The text field here doesn't show the text cursor.
Sometimes the cursor does show, in which case closing then trying to duplicate something again will hide the cursor.

Minimal reproduction project (MRP)
N/A

This is a duplicate of #90569 and was already fixed by #91361 in master branch

Awesome, thanks!


Verify systemd_unit file during create

Fixes #5200
I realise there are no tests for this feature. That is because I wasn't able to find any pre-existing tests relating to the internal file block on which to base any new ones.

:+1: LGTM

👍


node-webkit is showing

this is what I got today, when opening LT

this is the output from trying to start it from the terminal
[32666:0413/173753:ERROR:zygote_host_impl_linux.cc(146)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Fontconfig warning: "/etc/fonts/conf.d/50-user.conf", line 9: reading configurations from ~/.fonts.conf is deprecated.
[32666:0413/173753:INFO:gpu_info_collector_linux.cc(78)] NVCtrl extension does not exist.
[32666:0413/173754:ERROR:process_singleton_linux.cc(263)] Failed to create /home/dario/.config/node-webkit/SingletonLock: No such file or directory
Fontconfig warning: "/etc/fonts/conf.d/50-user.conf", line 9: reading configurations from ~/.fonts.conf is deprecated.
[32698:0413/173754:ERROR:renderer_main.cc(179)] Running without renderer sandbox
dario@macbook ~> ls ~/.config/ | grep node
dario@macbook ~ [1]>

I've had similar issue, when running LT, it just spit
[32666:0413/173753:INFO:gpu_info_collector_linux.cc(78)] NVCtrl extension does not exist.

and returned 0, giving me the finger essentially. So I moved ~/.config/LightTable to ~/.config/LightTable.bak, re-run, and it was up, but of course I don't want to trash my config and everything. I moved it back, and inside ~/.config/LightTable removed the Singleton* links. Normality restored. I guess LT should somehow detect during startup, that the exit wasn't clean, and it should clean or re-link those nodes.


Refresh bug with profiles on opensats.org/about

@dergigi
OpenSats website>About page:
There is a bug when the page is refreshed; when a members profile is clicked after refresh, often another members profile opens. Seems to only be happening when refreshing. Recorded screen of the issue to help you duplicate the bug on your end. Click here to watch the recording. Let me know how I can help.
Thank you.

Damn. I was able to reproduce this in production.
@moteanup24 maybe you can have a look at this and try to track down the bug?

Not sure if it's related, but I noticed the order of icons changes whenever you refresh the page. If this behavior is not intentional, it could be related.

@dergigi
Update: I'm pretty sure the bug is occurring because the randomization in getStaticProps() in pages/about/index.tsx is not being propagated down through to the MDXComponents. You'll notice that the randomization is repeated in components/BoardMembers as well as ./OpsTeam and ./Volunteers. So I think multiple Math.random() calls is causing the issue.
I think what we want is to create a randomized 'master' author array as a static prop in index.tsx, and pass it through MDXLayoutRenderer to the MDXComponents so that when the {openSats} content renders, it does so with the static randomized author array. Unfortunately I haven't been able to figure out how to pass the static props through to MDX components...
Unless I'm missing a quick way to do this (I am still getting familiar with MDX) I'd be inclined to just do away with the randomization on the about page. I also tried rewriting the about/index page using more vanilla jsx which seems to allow for more straightforward passing of props, which is do-able but then would require more manual formatting.
This is probably entirely too long for your taste but I wanted to provide an update and give you a chance to weigh in.

#187


Repoint soroban-spec-tools to the moved one in stellar/soroban-rpc

What
Removal of the spec-tools crate (rm -rf ./cmd/crates/soroban-spec-tools) and repointing it to the soroban-rpc repository.
Why
This is complementary to https://github.com/stellar/soroban-rpc/pull/68 in order to resolve a circular dependency between CLI and RPC.

I made more progress after reverting #1196 (which hopefully won't be needed if https://github.com/stellar/soroban-cli/pull/1206 fixes the problem).
However, now:

we have run into https://github.com/sfackler/rust-openssl/issues/2179
The typescript tests are also failing

It only took 5 hours to get the correct version of make used but EVERYTHING PASSES NOW.


Inserting value of type byte[]

When building an insert statement with a value of type byte[], the resulting binding values exceed the designated columns. How should I be inserting a byte array into a varbinary(max) column or is this an issue? The mapping type appears to be correct according to https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql-server-data-type-mappings
Thank you

@pwkdouglas  Please use the myget nightly-- I had came across this and committed a fix #74e62659698fdfbe38f6c5bf0a7bd2927a43f3fd

Awesome. Thanks @ceastwood!

Added the nightly to my nuget.config, uninstalled & reinstalled sqlkata package via NuGet Package Manager (Wednesday, March 20, 2019 | Source: https://www.myget.org/F/sqlkata/api/v3/index.json), tested a query build and I am still getting more values than columns. I'm probably doing something wrong. I'll have to try again tomorrow.

@pwkdouglas I'll double check that build later today

@pwkdouglas  Just checked, and it looks like somehow the last CI build that ran did not run against the most recent commit when it ran. The packaged .dll is missing some of the most recent changes.

@ceastwood Thanks for looking into this. I really appreciate it!

@pwkdouglas
I've made some quick changes and pushed package 1.1.8-ci-673 to MyGet as a prerelease. That package does show that it handles the byte[].

@ceastwood
Just tested that prerelease package and it works perfectly. Thanks a lot!


New Testimonial for Eddie Jaoude

Name
eddiejaoude
Title
GOD of Open Source
Description
I just wanna say thank you. I learned about Open Source, dev rel, and some cool things in 1st year of Engineering.

Thank you 🎉


Added new sample - change SPO search box placeholder text

What's in the pull request
Added new sample - change SPO search box placeholder text using PnP PowerShell

Hey @ganesh-sanap, great sample, thank you!! 👏😊 This should be live shortly 😊

Thank you @pkbullock!


Email templates

Make a simple email template, for verification emails and unsubscribe emails.

Do you mean a service like mailchimp?


python311Packages.urllib3: 2.0.6 -> 2.0.7

Description of changes
https://github.com/urllib3/urllib3/releases/tag/2.0.7
https://github.com/advisories/GHSA-g4mx-q9vg-27p4
Fixes: CVE-2023-45803
23.05 in #264914

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Hmm tests fail for me on nixos x86_64:
FAILED test/test_poolmanager.py::TestPoolManager::test_deprecated_no_scheme - urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='evil.com', port=...
FAILED test/with_dummyserver/test_socketlevel.py::TestSocketClosing::test_connection_cleanup_on_read_timeout - urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port...
FAILED test/with_dummyserver/test_socketlevel.py::TestSSL::test_ssl_custom_validation_failure_terminates - pytest.PytestUnhandledThreadExceptionWarning: Exception in thread Thread-137
FAILED test/with_dummyserver/test_socketlevel.py::TestHeaders::test_headers_sent_with_add[GET-None] - AssertionError: assert b'A: 1\r\nA: 4\r\nC: 3, 5\r\nC: 6\r\nB: 2\r\nB: 3' i...
FAILED test/with_dummyserver/test_socketlevel.py::TestStream::test_large_compressed_stream - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[file-POST-False] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[file-PUT-True] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[file-PATCH-True] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[file-PATCH-False] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[generator-POST-True] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[generator-PUT-False] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[generator-PATCH-True] - AssertionError: assert b'\r\n\r\na\r\nxxxxxxxxxx\r\n0\r\n\r\n' in b'PATCH /...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[generator-PATCH-False] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[bytes-PUT-True] - urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetEr...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_specified[bytes-PATCH-True] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[file-PUT] - urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetEr...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[file-PATCH] - urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetEr...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[generator-POST] - AssertionError: assert b'\r\n\r\na\r\nxxxxxxxxxx\r\n0\r\n\r\n' in b'POST / ...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[generator-PUT] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[generator-PATCH] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[bytes-POST] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[bytes-PUT] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[bytearray-POST] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[file_text-POST] - AssertionError: assert 0 == 5
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_chunked_not_specified[file_text-PUT] - AssertionError: assert b'\r\n\r\na\r\nxxxxxxxxxx\r\n0\r\n\r\n' in b'PUT / H...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_framing_set_via_headers[content-length-10-: 10\r\n\r\nxxxxxxxx-lower] - urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', p...
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_framing_set_via_headers[transfer-encoding-chunked-: chunked\r\n\r\n8\r\nxxxxxxxx\r\n0\r\n\r\n-lower] - AssertionError: assert False
FAILED test/with_dummyserver/test_socketlevel.py::TestContentFraming::test_framing_set_via_headers[transfer-encoding-chunked-: chunked\r\n\r\n8\r\nxxxxxxxx\r\n0\r\n\r\n-title] - urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetEr...

Hmm tests fail for me on nixos x86_64:

Yeah, I just made them reachable via passthru.tests. I'm not sure what is going on there, but since we weren't running them for years...


Fix status bar icon

The assets for the status bar icon were being excluded by our .vscodeignore
Checklist

[ ] I have added tests

@brollin fyi for future reference

Whoops, thanks for the fix. TIL about the .vscodeignore file :)

Ah, I was wondering what that was meant to look like :sweat_smile:


Example seems incorrect

I was following tutorial section and found few issues:
1. Updating values according to a filter based on value
In below example I am getting error. Calling 'filterUpdateAllByValue' instead updateAll fixed the problem.
scala> js.updateAll( (_:JsValue) == JsString("TO_FIND") ){ js =>
  val JsString(str) = js
  JsString(str + "2")
}
res6: play.api.libs.json.JsValue = {"key1":{"key11":"TO_FIND2","key12":123,"key13":null},"key2":123,"key3":true,"key4":["TO_FIND2",345.6,"test",{"key411":{"key4111":"TO_FIND2"}}]}

Code that worked for me
scala> js.filterUpdateAllByValue( (_:JsValue) == JsString("TO_FIND") ){ js =>
  val JsString(str) = js
  JsString(str + "2")
}

2. Updating values according to a filter based on path+value
Same here: Method call thats working for me here is 'filterUpdateAll' instead updateAll
scala> js.updateAll{ (path, js) =>
  JsPathExtension.hasKey(path) == Some("key4111")
}{ (path, js) =>
  val JsString(str) = js
  JsString(str + path.path.last)
}
res1: play.api.libs.json.JsValue = {"key1":{"key11":"TO_FIND","key12":123,"key13":null},"key2":123,"key3":true,"key4":["TO_FIND",345.6,"test",{"key411":{"key4111":"TO_FIND/key4111"}}]}

Working code:
scala> js.filterUpdateAll{ (path, js) =>
  JsPathExtension.hasKey(path) == Some("key4111")
}{ (path, js) =>
  val JsString(str) = js
  JsString(str + path.path.last)
}

I would suggest also to use contains to compare the value of the option:
js.filterUpdateAll{ (path, js) =>
  JsPathExtension.hasKey(path).contains("key4111")
}{ (path, js) =>
  val JsString(str) = js
  JsString(str + path.path.last)
}


[FLINK-33652]: Fixing hyperlink on first steps page. concepts to concepts/overview, as concepts page is empty.

What is the purpose of the change
Correctly pointing the concepts hyperlink under first steps page.
Brief change log

Modified the hyperlink from concepts to concepts/overview

Verifying this change
Locally tested.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

LGTM. You should rebase on the latest master branch and pass the CI.😄

@WencongLiu Let me do that, thanks!

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


updates after review in https://github.com/thingsapi/things.py/pull/72

Codecov Report

Merging #74 (a4e39ad) into main (274ea45) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          346       337    -9
=========================================
- Hits           346       337    -9

Impacted Files
Coverage Δ

things/database.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79da68a...a4e39ad. Read the comment docs.


Why # in the URL still?

I'm submitting a ...
[ ] bug report
[ ] feature request
[X ] question about the decisions made in the repository

Still trying to wrap my head around some of this but this was the first start I have seen where the solution still uses # in the URL. Is there a reason that still has to be used? One of the nice things about Angular2 is that we no longer had to deal with # in the URL. Seems there are other features we can't use with this version like moduleId so just wondering if this is another one that can't be used.

Just change the LocationStrategy to PathLocationStrategy. You can use moduleId see here: Component Relative Paths.

Cool. Thanks for the quick response. That helped educate me.


Make sure we distribute backports.

Resolves #839.

:tada:

Good call, I need to push out v1.15.1 for this, right?

@shazow Yes. =)

Done.


support network request interception

Mode
Storybook
Feature description
would be nice if there was a config option allowing us to setup custom page routes before loading the page https://playwright.dev/docs/network#modify-requests. however, the current storybook solution uses file:// urls when loading pages which are known to be problematic with this, see https://github.com/microsoft/playwright/issues/8412.

Hey @redabacha! I am myself very keen on the idea that lost-pixel supports something like MSW out of the box so you can just write your handlers and render different pages with different responses! Could you elaborate a little bit more on your use case? I think in Storybook you'd already be able to use MSW to render different stories with different responses. You'd use msw plugin storybook.
Still, I would want to know a bit more about the problem you are trying to solve and see how we can be of help!

hi @d-ivashchuk, msw is great however since it runs in a service worker it doesn't have access to the nodejs environment which is very useful when needing to interact with the local filesystem for example and it also doesn't have a capability of being able to record / replay network requests unlike alternatives such as polly.js (which has a working playwright integration https://netflix.github.io/pollyjs/#/adapters/playwright). being able to record / replay network requests is very helpful on larger apps where the maintenance burden of writing mocks for many requests is quite high.

Okay, gotcha! So you want to have more access to native playwright integrations when it comes to working with network?

So you want to have more access to native playwright integrations when it comes to working with network?
yes exactly, that would be awesome if that could be supported! :sweat_smile:

we can definitely look into it! If you will have any idea on specific tools or maybe would want to do a PR to enable this - I'd be more than happy to assist you!


[Bug report] hf_dataset crashes when split is not given

I mistakenly didn't give split argument when I tried to load dataset "umd-zhou-lab/sRecycled_Alpaca". Then dataset object is loaded with class DatasetDict instead of Dataset.
https://github.com/UKGovernmentBEIS/inspect_ai/blob/8806522e94c5f8c73fc3a943d8974d978e9f6dec/src/inspect_ai/dataset/_sources/hf.py#L76-L83
DatasetDict({
    train: Dataset({
        features: ['data'],
        num_rows: 37114
    })
})

Dataset({
    features: ['question', 'subject', 'choices', 'answer'],
    num_rows: 112
})

When dataset is DatasetDict, it doesn't have to_list member function and the following line crashes.
https://github.com/UKGovernmentBEIS/inspect_ai/blob/8806522e94c5f8c73fc3a943d8974d978e9f6dec/src/inspect_ai/dataset/_sources/hf.py#L95
This error is too silent and subtle, so there should be more informative guide to users.

Thanks for reporting this and apologize it took so long to resolve! https://github.com/UKGovernmentBEIS/inspect_ai/pull/965


feat: ledger to use walletId instead of userId

remove the hard dependency between userId and walletId for transaction. this is necessary for having multiple wallets/account
remove the use of walletPublicId

I think the code around removing walletPublicId looks okay. But then it also changes liabilitiesAccountId which is a significant change in semantics which I do not understand and seems unrelated.

It's related. after this PR, account.id == user.id, and now the books are recorded with the wallet.id, so saying liabilitiesAccountId is no longer relevant. it's really referring to a walletId.

It's related. after this PR, account.id == user.id, and now the books are recorded with the wallet.id, so saying liabilitiesAccountId is no longer relevant. it's really referring to a walletId.

In my mind a LiabilitiesAccount within a Ledger is semantically distinct from both a galoy Account and a Wallet - which is why I'm confused. We should probably have a sync with a few engineers to get the semantics right here.
From wikipedia article on double-entry bookkeeping:

Double-entry bookkeeping, in accounting, is a system of bookkeeping where every entry to an account requires a corresponding and opposite entry to a different account. The double-entry system has two equal and corresponding sides known as debit and credit. A transaction in double-entry bookkeeping always affects at least two accounts, always includes at least one debit and one credit, and always has total debits and total credits that are equal. For example, if a business takes out a bank loan for $10,000, recording the transaction would require a debit of $10,000 to an asset account called "Cash", as well as a credit of $10,000 to a liability account called "Notes Payable".

There is no mention of wallet in that field. From my reading account is the correct word for 'a grouping of related entries. Hence LiabilitiesAccount regardless of its reference to a wallet or account or user in other parts of the galoy system.

It's related. after this PR, account.id == user.id, and now the books are recorded with the wallet.id, so saying liabilitiesAccountId is no longer relevant. it's really referring to a walletId.

In my mind a LiabilitiesAccount within a Ledger is semantically distinct from both a galoy Account and a Wallet - which is why I'm confused. We should probably have a sync with a few engineers to get the semantics right here.

This is what we talked about last Code review and we agreed upon (maybe without full understanding of what we agreed upon for everyone).
The goal with this PR is to have:
User <-> Account <-> Wallet <-> Ledger
The idea is that 1-n user have an account, and each account can have 1-n wallet. so the wallet is what needs to be register to the ledger. account and ledger have no direct relationship here because we have the level of abstraction necessary for having multiple currency/wallet per account.

From wikipedia article on double-entry bookkeeping:

Double-entry bookkeeping, in accounting, is a system of bookkeeping where every entry to an account requires a corresponding and opposite entry to a different account. The double-entry system has two equal and corresponding sides known as debit and credit. A transaction in double-entry bookkeeping always affects at least two accounts, always includes at least one debit and one credit, and always has total debits and total credits that are equal. For example, if a business takes out a bank loan for $10,000, recording the transaction would require a debit of $10,000 to an asset account called "Cash", as well as a credit of $10,000 to a liability account called "Notes Payable".

There is no mention of wallet in that field. From my reading account is the correct word for 'a grouping of related entries. Hence LiabilitiesAccount regardless of its reference to a wallet or account or user in other parts of the galoy system.

That is correct, but if you remember the discussion we had (this one some months ago), the use of wallet was intentional and reflective of the use in the bitcoin/crypto space. you say you have different "wallets", not different "accounts".

Think we need a broader discussion here.

I'm still working my way through it. I've looked at a lot of the WalletPublicId to WalletId code, but am still working my way through the ledger account(1) change from account(2) ids to wallet ids which on the surface makes sense to me if we can keep the account(2) link somehow maybe e.g. Liabilities:<account-id>:<wallet-id>.

I think that's a great idea. I'll bring a lot of optimization down the road by having the account Id readily available. I'll work on that.

I did a comparison against #814 and found just one inconsistency (fixed: https://github.com/GaloyMoney/galoy/pull/792/commits/7c0b98a7ae19f7f34f2a9e67d46362f29f1e515e). This should be good to go now.


Distribute the browserified module as part of the NPM package

Closes #309

I could be +1 on this but can you tell me why don't you use browserify in your project to rebuild the browserified version ?
@vqvu do you have an idea why we don't publish the browser package ?

That would be an option; it just feels messy to reach into my node_modules
folder and manipulate stuff there. It also means a postinstall script.
It's not a huge deal if you prefer not to ship it; I just ship a copy in
the vendor folder with the app currently.
On Tue, Jun 2, 2015, 2:45 AM jeromew<EMAIL_ADDRESS>wrote:

I could be +1 on this but can you tell me why don't you use browserify in
your project to rebuild the browserified version ?
@vqvu https://github.com/vqvu do you have an idea why we don't publish
the browser package ?
—
Reply to this email directly or view it on GitHub
https://github.com/caolan/highland/pull/310#issuecomment-107898685.

@jeromew I don't know. Maybe because npm is usually used for node applications, and the browser package is useless there.
I'm ambivalent about this, but I don't see the harm. Worst case, people download an addition ~180KB.
So I guess that's a weak +1 for me.

@sethkinast just to clear something up: you're using npm to install modules to be used in the browser, but you're not using Browserify yourself to build the browser bundle? You're just including script files from node_modules?
If so, that's a very unusual use case for npm, and not one I think we should support.
However, we don't have to publish the bundle to npm: you could install Highland with npm directly from Github, by running npm install --save caolan/highland. The bowserified file is checked in to the repo.

I'm +1 on this as well. It's more common now for people to use a loader like https://github.com/systemjs/systemjs when building a browser app.
Given that, systemjs can load modules in commonJS format, but it's not going work trying to import modules built into the node runtime.
In general it's friendlier to ship the compiled bits, and most projects that are expected to run in browser / server environments do this.

We also ship the browserified bits via bower, but most people have switched from bower to npm for browser development.

Ok. We have a +1, a -1 and two weak +1 (+0.5?). Positive number wins.
I see no obvious downside to this change either, so I'm happy to merge this.

I've released 2.7.2 to NPM. That should contain the browserified bundles.

Well thanks! That will simplify my repo.
On Wed, Mar 23, 2016, 5:26 PM Victor Vu<EMAIL_ADDRESS>wrote:

I've released 2.7.2 to NPM. That should contain the browserified bundles.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/caolan/highland/pull/310#issuecomment-200594234


MdSelect not working in universal

Bug, feature request, or proposal:
Bug
What is the expected behavior?
With universal rendering, MdSelect should work like other components.
What is the current behavior?
With universal rendering, MdSelect throws an error:
TypeError: this.trigger.nativeElement.getBoundingClientRect is not a function

What are the steps to reproduce?
Use MdSelect in any component of a universal project and try universal rendering.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4.x, Material beta.8

Our prerender test uses md-select and works:
https://github.com/angular/material2/blob/master/src/universal-app/kitchen-sink/kitchen-sink.html#L162
Feel free to reopen if you can provide more reproduction information


Regression in treaty2: cannot send files

The treaty2 client does not send files properly. The original treaty client works fine. Reproduction code:
import { Elysia, t } from "elysia";
import { edenTreaty, treaty } from "@elysiajs/eden";

export const app = new Elysia()
  .post("/upload", async ({ body: { file } }) => `Got file: ${file.name}`, {
    body: t.Object({ file: t.File() }),
  })
  .listen(0);

const treaty1Client = edenTreaty<typeof app>(String(app.server?.url));
const treaty2Client = treaty<typeof app>(String(app.server?.url));

const file = new File(["testfile"], "test body");

console.log((await treaty1Client.upload.post({ file })).data); // successful
console.log((await treaty2Client.upload.post({ file })).data); // unsuccessful

app.stop();

The regression is due to these lines: https://github.com/elysiajs/eden/blob/dab2e53ac44539611b4545d3ee5ff937fa9f6b63/src/treaty2/index.ts#L235-L240
This condition runs because body is an object, and the line fetchInit.body = JSON.stringify(fetchInit.body) wipes out the file being uploaded.

I just noticed that there's a PR for this fix already: https://github.com/elysiajs/eden/pull/73
This issue can be closed once that's merged.

Can reproduce, even after #73 merged, running Eden 1.0.12

Fixed by #90 , can be closed.


Documentation for New PowerToys Toy (Paste As Plain Text)

Pending release of PowerToys v0.68.0 (should land in March):

added paste-as-plain-text.md
updated index.md
added png

@mattwojo v0.68 was released like 10 minutes ago 🙂


Adding reset heat pump

Cause of an error in my heat pump I must reset my heat pump.
But I can't do it with your integration.
So I hope it's posible for you to integrate a reset heat pump in your STIEBEL ELTRON integration.
In the STIEBEL ELTRON modbus dokumentation I see the modbus address '1520' value '3' for it.
I hope you can implement a reset heat pump with a next update in the future.

I have added a "reset heatpump" button, but I have not tested it since it's not clear to me what it does. If you don't mind, get the latests version of the main branch and test it. I have not yet created a release with this code.

Sure, I'll be happy to do that, I know how the system should behave after a successful reset.
What exactly do I have to do with which file?
Sorry for the demand, I do not know myself here yet so well.

Ok. I have created the release v0.9.0 for testing. Just upgrade the component.

Very good !
The reset of the heat pump works perfectly.
The heat pump was restarted as expected after pressing the reset button.
However, the heat pump did not (yet) have an error message for what the reset button should then actually help.
I am now waiting for our next heat pump error and try the reset button test again.
Give then again feedback.

Great to hear. Many thanks for testing. In case you want to reset the error list, there would be another possibility: Write 2 (insted of 3) into the register 1520. Is reseting the error list what you are looking for?

Mhm, the reset of the error list should perhaps be better left before you lose important plant information.
I would rather do this directly on the system if necessary.
To get the error list also in the Home Assistant, that would be good.
However, I have not yet found a mode code that contains the error list.
More important from my point of view would be the output of the last active error.
I assume that this is in the modbus code 2507.
Should I open a separate ticket for you?

Yes, please open a separate issue for the last active error...
Thanks.

Looks like this one is solved by the implementation of the reset button. Please open a new issue in case there is something left.


#63 upgarding dependencies to work with jenkins 2.277.2

upgrading dependencies to work with jenkins 2.777.2
#63 github issue

[X ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
[ X] Ensure that the pull request title represents the desired changelog entry
[ X] Please describe what you did
[ X] Link to relevant issues in GitHub or Jira
[X ] Link to relevant pull requests, esp. upstream and downstream changes
[ X] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@vincentrussell nice job - thanks a lot!


Group Response

In normal and supper groups:
On /setprivacy Enabled - bot only responds to "/"(/start and /stop) commands and not to @username commands  - no log pulls trough.
On /setprivacy Disabled - bot responds to all messages even if not tagged or "/" command used.  - logs to server.
All messages in private gets handled correctly.

I have mine (@WalkmanBot) set with /setprivacy Enabled, and it only seems to respond to /[command]@WalkmanBot, sometimes it responds to /[command] though. But it does still work.


A problem occurred evaluating project ':WebRTCModule'. > Could not find method implementation() for arguments [com.facebook.react:react-native:+] on project ':WebRTCModule'.

Hi bro did you find the solution?


readDrawable function error

Hello,
We have a crash report spiking in Firebase, Please investigate the issue,
Thank you,
Flutter version: 2.5.3
Adivery version: 4.0.5

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.Bitmap android.graphics.drawable.BitmapDrawable.getBitmap()' on a null object reference
at com.adivery.plugin.NativeAd.readDrawable(NativeAd.java:95)
at com.adivery.plugin.NativeAd.access$200(NativeAd.java:20)
at com.adivery.plugin.NativeAd$1.onAdLoaded(NativeAd.java:57)
at com.adivery.sdk.z$a.run(z.java:8)
at android.os.Handler.handleCallback(Handler.java:809)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:166)
at android.app.ActivityThread.main(ActivityThread.java:7555)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:469)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:963)

Thanks for your report
could you please give me the steps to reproduce this Error?

It seems to be fixed in the latest version as we didn't have any report on this, lately.


Accept sort order input on get claims entry point

related to an issue on Privado app, accept credential sort order as input param

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 21.15%. Comparing base (ba76ff8) to head (9aeaca0).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #439   +/-   ##
========================================
  Coverage    21.15%   21.15%
========================================
  Files          296      296
  Lines         9136     9136
========================================
  Hits          1933     1933
  Misses        7203     7203

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make sure that mouse coordinates are correct when targeting HTML5 DOM

Not going to track TODO items as issues :smile:


Reverts DynamicResourceAllocation enablement on techpreview

Reverts https://github.com/openshift/cluster-kube-apiserver-operator/pull/1538, https://github.com/openshift/cluster-kube-apiserver-operator/pull/1536; tracked by OCPBUGS-17967
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
We believe this PR broke the techpreview "[sig-api-machinery] API data in etcd should be stored at the correct location and version for all resources [Serial] [Suite:openshift/conformance/serial]" test which is now failing on nightly payloads.
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run techpreview jobs on the unrevert:
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview-serial
CC: @bertinatto, @benluddy

/label approved
/label jira/valid-bug
/skip
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp
/override ci/prow/e2e-aws-ovn

/lgtm

/label approved

/hold

/hold cancel

/hold


Move azure-spring-boot-starter-keyvault-certificates's java code to spring-cloud-azure-autoconfigure

Context
Depends on #23483

A spring-boot-starter should include dependencies only, not contain java code. It's java code should put in related auto-configure module. So azure-spring-boot-starter-keyvault-certificates's java code should be moved to azure-spring-boot.
And the package name should consistent with azure-spring-boot-starter-keyvault-secrets. com.azure.spring.security.keyvault.certificates.starter.

Refs:

https://www.baeldung.com/spring-boot-custom-starter

Goal
Move azure-spring-boot-starter-keyvault-certificates's java code to spring-cloud-azure-autoconfigure

Closing this issue because related code already deleted in 4.0.0 version


hi .would you like to share me with how to generate the info_eplised.dat?

how to produce my info_ellipsoid.dat?how i use my face1 to generate the .dat?

@walsvid can you please be more specific what all information went in dat file creation, i could not find specifically over in data generation & utls.py. appreciate your support.

Hi,
Do you know how to download the dataset and unzip it from the link below?
https://drive.google.com/open?id=131dH36qXCabym1JjSmEpSQZg4dmZVQid


Make test case for swagger/codegen to reproduce nested referenced problem

We had issues with the generator resolving references. Need to push this upstream.

I read somewhere that this is a known issue. We should rather remodel our spec to avoid nested models.


Couldn't find an IPlatformOperations implementation

Running WPF windows app with the latest version of ReactiveUI published on  NuGet I receive the following error:
ViewModelViewHost: Couldn't find an IPlatformOperations implementation. Please make sure you have installed the latest version of the ReactiveUI packages for your platform. See https://reactiveui.net/docs/getting-started/installation for guidance.
The first attempt to fix this was to register the service using Slat within my bootstrapper code:
Locator.CurrentMutable.Register(() => new PlatformOperations(), typeof(IPlatformOperations));
But unfortunately this is not possible due to the fact that IPlatformOperations is defined as internal although PlatformOperation is public.
There seems to be no problem with the execution of my app. Everything just works fine. But I really would like to understand this error and get rid of the error in case it is not really meaningful.
The app is a netcoreapp3.1 using WPF and referencing the following ReactiveUI packages:

@markusmorawitz77

Was this an upgrade from a version to a version?

if so please identify the versions

Is there any output of the error?
What is the actual result?

does your application crash?
is this error just written to console?

Most of the time that this is caused due to the way we do scanning for things to register.
Is your issue similar to https://github.com/reactiveui/ReactiveUI/issues/2038

Closing since it's likely including ReactiveUI.WPF NuGet package.


Build SHiELD with AVX_LEVEL=-mavx instead of AVX_LEVEL=-march=native

Building SHiELD with AVX_LEVEL=-march=native can result in immediate / mysterious "illegal instruction" crashes when running on different machines than the docker image was built on, e.g.:
{"message": "", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "===================================================================================", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "=   BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "=   PID 44 RUNNING AT 18193da4617d", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "=   EXIT CODE: 132", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "=   CLEANING UP REMAINING PROCESSES", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "=   YOU CAN IGNORE THE BELOW CLEANUP MESSAGES", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "===================================================================================", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "YOUR APPLICATION TERMINATED WITH THE EXIT STRING: Illegal instruction (signal 4)", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "This typically refers to a problem with your application.", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}
{"message": "Please see the FAQ page for debugging suggestions", "logging.googleapis.com/labels": {"kind": "fortran", "model_time": null}, "severity": "DEBUG", "model_time": null}

We did not run into this when developing the wrapper in this repository, because we never tried using an image built on one machine on another.  In fv3net we use a pattern where we build an image in CI, push it to the container registry, and then use that image on various types of Google Cloud Platform machines.  This requires a less hardware-specific AVX_LEVEL.
While it is not required in this repo, I think we should switch to using AVX_LEVEL=-mavx (as we use in fv3gfs-fortran) in the Dockerfile as an example for builds in downstream repos, which I have confirmed fixes this issue in the case of SHiELD-wrapper.  Note this will require updating regression test checksums.

Resolved by #12.


Enhance Contact form, footer and social profile section of website

Turning the ui of wesbite into a mesmerizing one.

@shrishti-c  Already issue is there for footer please check

@shrishti-c Already issue is there for footer please check

yup, sorry.


estop_rx board has 24v going into microcontroller

The upstream signal from the mast gets converted to 5V and transmitted to MCU, and is not passed downstream. Control signal for relay would connect robot ground to MCU and relay itself.
Not enough to drive the solenoid.

Img from Estop circuit to explain what happens.

This has already been fixed , closing.


Card-io sdk: Application restart after camera access changed in device setting

Application restart after camera access changed in device setting. Is it officially documented anywhere in apple document?

@vijayviswas yes, I have noticed this as well. See my comments here at lines 80 and 81.
IIRC, I found some comments in Apple documentation that could be interpreted as hinting at this behavior, but I did not find any explicit documentation of the fact.

Thanks @dgoldman-ebay.


While signing ICLA User email id / name doesn't appear on Docusign

While signing ICLA User email id / name doesn't appear on Docusign and shows "Unknown"

@vinod-kadam Verify this issue looks like it's a python side and @wanyaland made a change for CCLA so it's causing the issue on ICLA. Need to support for ICLA with GitHub-email or GitHub-username.

@ashav-github ready for QA

Verified today and found working fine now, please refer screencast below:


Allow login popup window to auto close

Issue #, if available: Native support to auto close login popup window #138
Description of changes: Allow login popup window to be auto closed after sso
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Will anyone be able to merge this PR? thanks!


[Draft/WIP] test: PoC SSG

Very much a WIP - would need a lot of work to integrate with existing keycloakify features (particularly anything that accesses window.kcContext)
These changes would allow for SSG of the individual .ftl files, potentially decreasing FCP/LCP web vital metrics and allowing for more customizable html on a per-page basis.
The overview of how this works is:

Replaces the vite build with vike (previously vite-plugin-ssr)
Uses Vike's SSG support to pre-render the login.ftl page
As part of SSG, uniquely identifiable values are injected into the page contents (username - Kc_Context_Username / submitUrl - Kc_Context_SubmitUrl)
After the vite build, replace all of those usages in the html with the ftl equivalent. For example Kc_Context_Username gets translated to ${(login.username!'')}. Additionally moves the vike-created assets to be consistent with how keycloakify works.
Uses existing keycloakify cli for the rest

Note: At the moment, this PoC is not fully functional. This example includes enough to:

Load the login page
Submit the login page - There is no password field so you will get an error
When the login page reloads, you should be able to see that the initial html includes the email previously entered.

Damn sorry @willwill96,
This is very interesting.
Just now am I looking at this because for some reason I have the notification disabled for this repo.

This would be fantastic to have.
What's you though on this now is it feasable? I'd love to schedule a call with you to discuss your finding on this


Debugging support

Is your feature request related to a problem? Please describe.
Nova has debugging support, Rust has debugging support (with LLDB, GDB and CDB), so why not put them together?
Describe the solution you'd like
The  debugging functionality present in many other IDEs. Supporting just LLDB would be enough for now.
Describe alternatives you've considered
The LLDB extension, I couldn't get it to work (see the related issue), even then, I think having it directly in this extension would be good, maybe using the LLDB extension if possible.

I definitely considered providing debugger support when it launched with Nova 9. I haven't pursued it for a few reasons.
The primary reason was "because it's hard." I couldn't find a debug adapter that wasn't tightly coupled with an extension and that could be easily dropped in, like how Rust Analyzer is easy to use with any editor. I didn't have the time and energy to dive into whether forking an existing VS Code extension or rolling my own adapter would make more sense. It all seemed like more effort than what I could offer given my existing obligations.
A secondary reason is that it kind of makes sense for it to be a separate extension. Other languages like C could use gdb, lldb et al for debugging, so binding a debugger to only Rust would make it less useful for Nova users.
So I'm rooting for the LLDB extension to fix its issues since it looks like they're just getting started. Many extension developers have run out of steam, so I wish them luck!

The adapter isn't for Rust to LLDB, but for Nova to LLDB. A debug adapter is something that "wraps" a debugger and communicates with an editor via JSON messages that conform to a specific protocol. It's very much modeled after LSP.
As I described above, I couldn't find an adapter that was easy to grab and drop in, nor could I commit to making one myself.


Spongy Castle KeyPairGenerator extremely slow on Android M

Hi,
When using Spongy Castle KeyPairGenerator , the statement "keyGen.generateKeyPair();" takes extremely long time to execute on Android M.
It takes around 12-13 seconds for this line to execute on Android 6 devices . in comparison - It takes 2-3 seconds on previous Android versions using the exact same libraries.
A sample Android Studio project is attached.
any help in getting better performance
would be greatly appreciated.
sample code :
    KeyPair keyPair = null;
    KeyPairGenerator keyGen = null;
    keyGen = KeyPairGenerator.getInstance("RSA", "BC");
    keyGen.initialize(2048);

    keyPair = keyGen.generateKeyPair(); <-This is the problematic statement

    byte[] privateKeyBytes = keyPair.getPrivate().getEncoded();
    String privateKey = new String(Base64.encode(privateKeyBytes, Base64.NO_WRAP));
    PublicKey signaturePublicKey = keyPair.getPublic();

Wouldn't that have to be "SC" instead of "BC" for the provider name?

You should mention on what device you're running this from. It is often an entropy issue.

Tested on two devices - Nexus 5X  and  Nexus 5.
Changing
keyGen = KeyPairGenerator.getInstance("RSA", "BC");
To
keyGen = KeyPairGenerator.getInstance("RSA", "SC");
seems to have done the trick and the code runs faster (~1 second for the statement to run).
I guess that keyGen = KeyPairGenerator.getInstance("RSA", "SC") was calling a different provider.
Sorry for your trouble and thank you for your help.
Regards,
Dan


Added Pair Making Game

added the pair making game to the repository for the issue #741

@swapnilsparsh why didn't you merged my PR ?

@swapnilsparsh why didn't you merged my PR ?

The issue was not assigned to you.

@swapnilsparsh why didn't you merged my PR ?

The issue was not assigned to you.

Yes ik but why haven't you assigned it ? You just simply closed the issue

@swapnilsparsh why didn't you merged my PR ?

The issue was not assigned to you.

Yes ik but why haven't you assigned it ? You just simply closed the issue

Because this type of project is already there on the repo


test(repeater): add tests for repeater command

closes #438

@derevnjuk here is an example of successful workflow run:
https://github.com/lsndr/bright-cli/actions/runs/6008642855/job/16297225598

@lsndr please rebase your branch onto the next

@lsndr please run tests one more time once https://github.com/NeuraLegion/bright-cli/pull/449 is deployed


feat(jsii-pacmak): add maven and nuget support for * dependencies

For https://github.com/aws/jsii/issues/1678 in case you want to go with route (1) of supporting * dependencies.
Signed-off-by: campionfellin<EMAIL_ADDRESS>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 3fb8e3cd2a5373eaa55435a89a07c4b97730e27a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: c075eeb15bdc6c5aa76cd8ec16b518a8e2f8cbde
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 2543fa2c33fa06168268bf5fce6573d7abd4bfc0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 52253b05b5fff409b46bd16ba15935e4ab802358
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller seems that builds are just generally failing now (unrelated to this change), but this should be good to go.

Yeah looks like MyPY again started checking things it used to ignore. Duh.

@MergifyIO refresh

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 9a1d50d56e157fb88f6431848bc7a3f2dd5a5492
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


feat: Change repo config and curation to warning

A repository configuration or curation within an .ort.yml file may be purposeful. This declares a WARNING instead of ERROR for the evaluator.
Closes #7753
Please ensure that your pull request adheres to our contribution guidelines. Thank you!

Commit message:

Closes #7753

This needs a different syntax as it's supposed to close an issue in a different repo: Closes oss-review-toolkit/ort#7753.
Also, the commit message body needs to be hard-wrapped at column 75.


Genereting empty SVGS

Tested this on 30 png's sprite all of them genereted empty svg

@tomasz-rekawek-tb Thanks for the report!
Just curious if you could post one of the png images here so I can test it locally on my machine. At the same time, please let me know what version of node you're currently using and i'll do my best to re-create the issue.
I haven't used this module in a few years but I'd be happy to investigate and see if we can figure out what's going wrong!

This happens when the PNG image is entirely in black (rgba(0, 0, 0, 255)).


pop to insert

https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/1782/files originally made the focused_labels to insert the new label, but looks like it was changed to pop here : https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/1834/files#diff-b1fb3508a2b896cec3f09ffc0aa4234ef6b8972d977da9c142f8e2d3b5f71d39R466

closing in favor of https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/1983

Sorry for the snipe.


Update USD HID Report Descriptor - Keyboard.txt

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Winner of final leg isn't indicated in march statistics

Leg does not have winner assigned. As such it is not shown. Suspect that the winner isn't set during the request for checkout number of darts.


Added improved ExpectedStruct error message

Improves the error messages for ExpectedStruct (now ExpectedNamedStruct), NoSuchExtension, and UnexpectedByte by including the erroneous identifier in the message. This small change should help with #301.

[x] I've included my change in CHANGELOG.md

@torkleyy In relation to https://github.com/ron-rs/ron/issues/301#issuecomment-973997228 I did some small experimentation to ever so slightly improve the error message from Expected struct to Expected struct 'MyStruct' when the struct name is known. This would already help the case when an error message is confusing but doesn't require the complex changes that would be needed to see e.g. if a different struct name was given.

Alright, LGTM!

Ok, I'll add the Changelog entry and merge it later today :)

@torkleyy Ready to merge?


Update 404.astro

👷 Deploy Preview for famous-marshmallow-cfbd61 processing.

Name
Link

🔨 Latest commit
7e80739cf6545b07430c9c0f88152928b71d3495

🔍 Latest deploy log
https://app.netlify.com/sites/famous-marshmallow-cfbd61/deploys/64dd72f54f49430008fc281b


Gateway distr is corrupted

FYI
At the state of today link above for downloading the distributive for gateway is giving you corrupted file that can't run.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0deaa8b2-66a2-b45c-3ecd-7ea2d08503ed
Version Independent ID: 364890ed-d3ba-9e01-c40a-ce78600319f1
Content: Install on-premises data gateway - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-gateway-install.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@a-zolotukhin Thank you for reporting this issue! We will investigate and make any necessary changes.

Hi @a-zolotukhin, we've updated this article with a different alias link and mapped the link to the latest installer, which I tried installing and finished without error: https://aka.ms/on-premises-data-gateway-installer

Please try this version to see whether you can install successfully. Thanks!

Hey @a-zolotukhin Thanks again for reporting this issue and contributing an improvement towards MS Docs! I verified that the broken link is now fixed and working OK. Please test on your end and let us know if you see any issues.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Move SystemAccessControl implementations to presto-plugin-toolkit

Move SystemAccessControl implementations to presto-plugin-toolkit
Thanks to that:

they could be used to compose other Presto plugins. This is very
useful because Presto does not support multiple system access controls,
so user can merge two implementations into a single one.
This is nice because this way user manages the semantic how multiple
system access controls should work.
file based access control are placed together
implementation of file system access control no longer depends on
how system access control is used by Presto.
tests are simpler

ping


driver: display: Add support for BBC Micro:bit v2 to display driver

Yet another attempt to add support of display driver for BBC Micro:bit v2 board.
This PR uses Devicetree for pin assignment. Existing code is reused as much as possible.
Unfortunately driver initialization code looks ugly, as I don't yet fully understand how all these DT macros can be used for initialization.  Can someone consult me on it?
Tested on BBC Micro:bit v2, but not on Micro:bit v1.
Comments for further improvements and test results on v1 board are very welcome.
Signed-off-by: Alexander Chudov<EMAIL_ADDRESS>

Dear Alexander,
I have to admit that I gave up on my own contribution this summer because the processing of the PR did not go together with my own timing and I had to think about other things. This autumn, I did some practical exercises about this with my students that kind of go in your way, so here is a proposition for improvement. Or even to work together to get things right.

So please read me and give me your thoughts.
But first things first, DTS "fun" (DTS is the hardest part of Zephyr, I think).
For one, the matrix can be defined simpler in DTS using actual arrays, like so for the v2 (sorry for the indenting that looks strange here with tabs):
	matrix {

        compatible = "gpio-leds";

        rows {
				gpios=
					<&gpio0 21 GPIO_ACTIVE_HIGH>,
                	<&gpio0 22 GPIO_ACTIVE_HIGH>,
                	<&gpio0 15 GPIO_ACTIVE_HIGH>,
                	<&gpio0 24 GPIO_ACTIVE_HIGH>,
                	<&gpio0 19 GPIO_ACTIVE_HIGH>;

                label = "Matrix rows";

        };

        cols {

            gpios=
					<&gpio0 28 GPIO_ACTIVE_LOW>,
                	<&gpio0 11 GPIO_ACTIVE_LOW>,
                	<&gpio0 31 GPIO_ACTIVE_LOW>,
                	<&gpio1 5 GPIO_ACTIVE_LOW>,
                	<&gpio0 30 GPIO_ACTIVE_LOW>;
            label = "Matrix colums";

        };

    };

Then, you can define const arrays for the indexed access to each entry, like so (here obviously not parametrized for an alternative driver):

#include <zephyr.h>
#include <device.h>
#include <devicetree.h>
#include <drivers/gpio.h>
#include <devicetree/gpio.h>

#include "led_matrix.h"

const int led_matrix_rows = 5;
const int led_matrix_columns = 5;

// tables for dynamic access to pins and devices

const struct gpio_dt_spec  row_pin[5] = {
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, rows), gpios, 0),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, rows), gpios, 1),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, rows), gpios, 2),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, rows), gpios, 3),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, rows), gpios, 4)
};

const struct gpio_dt_spec col_pin[5] = {
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, cols), gpios, 0),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, cols), gpios, 1),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, cols), gpios, 2),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, cols), gpios, 3),
	GPIO_DT_SPEC_GET_BY_IDX(DT_PATH(matrix, cols), gpios, 4),
};

void led_matrix_init(void)
{
	for (int i = 0; i < 5; i++) {

		gpio_pin_configure_dt(&row_pin[i], GPIO_OUTPUT);
		gpio_pin_configure_dt(&col_pin[i], GPIO_OUTPUT);
	}

}

void led_matrix_clear(void)
{
		for (int i = 0; i < 5; i++) {
			gpio_pin_set_dt(&row_pin[i], 0);
			gpio_pin_set_dt(&col_pin[i], 0);

	}
}

Students managed to go from here to code from zero in a short time a display driver thread that would sweep over the matrix and let some time (1ms) for other activity at each pixel, and the result looks OKish.
However, the whole thing remains terribly limited and inefficient, in particular compared to the driver present in CodeMaker software (based on NRF5SDK), for instance, that driver allows for changing brightness.
Moreover, the original author of the Zephyr driver tried to be smart and use line multiplexing (showing several pixels in the same row or same column). If you think about it, that is a cause of trouble in one of two ways: Either several LEDs take their current through the same resistance, but then, the more leds you switch on, the less bright they will be, leading to an inhomogenous brightness. Or the current of all LEDs adds up and passes through a single GPIO pin exceeding the specs of that pin, and this might over time damage the pin.
That is neither the case for the CodeMaker driver, not for my own attempt in Zephyr directly using NRFX this summer. It is better to sweep over pins individually. But then, the code has to be efficient.
Using the gpio_pin_set_dt function obviously is not efficient as it inserts an actual function call in pin manipulation, although this is perfectly avoidable with the NRFX API. Secondly, the NRFX API allow to increase current limitations of the GPIO pins and that allows to obtain a brighter display when sweeping over LEDs individually.
Moreover, using Kernel scheduling is not efficient for a device driver like this. Rather, a direct interrupt timer approach puts much less load on the system.
And in the end I think, that the reuse of the code of the original driver is not such a good idea as even the API is bad. I think a from scratch development that also implements in the API brighness control, and the the brightness sensor feature would be desirable. And then, a modularisation between the basic matrix display and the contents API (text, images) is desirable. The contents can and should totally be done with Zephyr means, whereas the basic display driver should be implemented low level to be efficient.
In other PRs the discussion also turned around the topic of this modularity as zephyr already has matrix displays, but the microbit display is so tiny (5x5) that it is reasonable to give it a separate contents API.
Thanks for reading this far, please give me your thoughts!

Dear Peter,
thank you for suggestions for DTS. I'm trying to use the proposed approach... DTS, and especially all these macros are really tricky to understand :)
Loose of brightness - yes, possible. To be checked how big might be the impact. From another perspective - it is not a safety-relevant device, some small changes in brightness should not be a big issue.
It seems overcurrent is impossible with the current schematic: the current per column is limited to 3 mA. So even if all LEDs are switched on, the maximum sink current over MCU will be 15 mA, source current is 12 mA from gpio0 and 3 mA from gpio1. That is completely in allowed range.
I don't think direct usage of interrupt controller is a good idea as at the very end there is a resource consumer outside of the operating system that steals resources from it. And there is no way to control this consumer explicitly from the operating system.

Further steps for the driver implementation are:

[ ] 1. To finalize DT usage for configuration:

Eliminate col-gpios-used - this information is available in DT_N_S_matrix_REQUIRES_ORDS, just need to understand how to take and use it
Find a way to define pixel_map in device tree, not in sources
Find a way to build display_cfg.mask at build time instead of display.mask that is build at runtime

[ ] 2. To use standard Display Driver API instead of self-made API from the previous version of the driver

[ ] 3. To implement support of brightness change and other stuff that is available in the original CODAL driver

[ ] 4. To find a way to implement light detection. Perhaps it will be another driver - to be investigated.

After #40968 this MR make no sense.


Jiotv runtime error

No channel is getting played. All I can see a popup showing Runtime error. Also, having a high speed internet, ColorsTV is always lagging the speed and keeps on buffering.

Please follow the issue template so I can get the basic information.
The runtime error used to cause in older version so make sure you are on latest v2.0.14.
If you still facing the issue then please provide a debug log

Please solve this problem all channels not working

This is the error seen while playing any channel:
ERROR: [JioTV.support] play() got an unexpected keyword argument 'id'
     Traceback (most recent call last):
       File "/home/pi/.kodi/addons/script.module.codequick/lib/codequick/support.py", line 325, in run_callback
         results = route.function(parent_ins, *arg_params, **self.callback_params)
       File "/home/pi/.kodi/addons/plugin.video.jiotv/resources/lib/utils.py", line 35, in login_wrapper
         return func(*args, **kwargs)
     TypeError: play() got an unexpected keyword argument 'id'

I also tried to logout+login, just in case, there was a stale login token.


feat: improved locale support

maybe this suggestion for issue: #25 is OK?

we want to use the first valid language
we should check if the file exists
if there is no file we should give an error
if there somedays is a solution to get req.locale (https://cap.cloud.sap/docs/node.js/events#locale)

I hope this is a little bit more clear.
Im sorry but after the last changes to pnpm I'm not able to get the local test to work...
so I'm kind of editing in the dark.


added lockGestureDirection and separateGestureFromScrollView

here it goes right
added lockGestureDirection and separateGestureFromScrollView
before:

after:

before:

after:

how to use:
SlideMenuOptions.lockGestureDirection = true
SlideMenuOptions. separateGestureFromScrollView = true

in mainViewController viewDidLoad:
self.slideMenuController()?.mainScrollView = self.scrollView

in leftViewController viewDidLoad:
self.slideMenuController()?.leftScrollView = self.tableView

Closed because this pull request has conflicts that must be resolved.


Documentation: Exaustive list of all acceptable image file formats

In my applications, it makes sense to verify if the file extension is acceptable by Vix before calling Image.new_from_file, so that I would not have to download a file I already know won't be processable.
I was unable to find this information on the documentation, neither on the code.

Updated documentation in #134
Thanks!


Do not use a semicolon to end a multi-line query

Currently when editing a multiline query, we use use a semicolon+ to delineate the query should be executed.
Feedback from the MVP summit: in multiline query mode, users like to enter more that one statement, which are delineated by semicolons, so using a semicolon is a bad choice. We should consider using the 'GO' keyword to execute the query, which aligns with sqlcmd.

Tasks:

[ ] tests for multiline
[ ] update docs

Tests:

[ ] toggling multiline
[ ] use of semicolons (with, without, and mismatch)

No plans to support:

Multi-line queries with multiple GO's.

Turns out that a bug that's also affecting #393 may be blocking this effort. Various multiline queries are breaking, such as:
select 1
select 2;
go


Provide completion for preLaunchTask and postDebugTask of launch configuration

in launch.json file,  for a Launch configuration, it is possible to provide preLaunchTask and postDebugTask, it will be convenient to provide completion for tasks which are defined globally and locally.
Bonus: when providing snippets, to have a variable to access this list of tasks too.

Yep, this is actually a bug that we are discussing: https://github.com/microsoft/vscode/issues/142642

Btw @lramos15, backlog candidates bot did not show up in the 7 hours it was on that milestone


Rename LayoutModifier to Modifier

We don't want to go full Compose UI Modifier, but we also think that want to use this as a mechanism to globally attach some properties to all widgets (such as stable IDs, accessibility information, etc.). Additionally, it would let users attach metadata globally.
We talked about this back in February and agreed to do it. This is a tracking issue for following through on it.

Might want to drop it into a modifier package since we'll presumably have global modifiers like stable ID and accessibility.

I'll take this. Should be fairly quick


Unnecessary checking of isThisMyUrl

I was debugging some failover scenarios and found that the if condition below never becomes true, hence unnecessary.
for (final PeerEurekaNode node : peerEurekaNodes.getPeerEurekaNodes()) {
       // If the url represents this host, do not replicate to yourself.
       if (peerEurekaNodes.isThisMyUrl(node.getServiceUrl())) {
            continue;
        }
       replicateInstanceActionsToPeers(action, appName, id, info, newStatus, node);
 }

https://github.com/Netflix/eureka/blob/master/eureka-core/src/main/java/com/netflix/eureka/registry/PeerAwareInstanceRegistryImpl.java#L633
This is because eureka server never adds itself to peer-node collection. i.e.
https://github.com/Netflix/eureka/blob/master/eureka-core/src/main/java/com/netflix/eureka/cluster/PeerEurekaNodes.java#L140

@fahimfarookme that looks to be the case, thanks. This is likely a legacy of some optimisations elsewhere.


[WIP] Unified csp containers

Work in progress, initial work toward HPO container unification.
Note: It looks like more files have been changed than really have.
aws/azure/gcp folders moved under a top level cloud_service_providers folder, to give access to the top level docker build file.

@drobison00 I think this is a good start!
In the case of the AWS HPO demo, we do a container build from the notebook instance. Would it be possible to disable non AWS build steps, or would you suggest maintaining a minimal cloud specific version for this purpose?

@miroenev I don't think we can disable sections directly, although I can think of some possible ways to do this with multi-stage builds, or using underlying configuration scripts that can handle flow control; in either case I think if we start down that road there isn't much value left from taking a unified container approach. With the unified approach we're going to sacrifice in terms of container size to get general applicability.

For Azure, we can modify the notebook to use a Docker image by replacing environment_definition with custom_docker_image in the Estimator. AzureML will also create a snapshot of the local source_directory, where we copy the training scripts. Just tested the Dockerfile and works well without the entrypoint script (ENTRYPOINT [ "/bin/bash" ]), attached the logs
azureml-csp-container-working.txt
azureml-csp-container-failing.txt

@drobison00 the modified Dockerfile and entrypoint still fails on Azure, only the suggested version above runs successfully

@zronaghi Looking at your azure logs, they're passing some very complicated commands that relay on a handful of mounted volumes, this includes a great deal of quoted text and 'bash -c' commands. I'll need to experiment a bit and see what could be breaking the raw command pass-through.


Package for upload to PyPI

I've packaged this up for release to PyPI:
TODO left for you:

[ ] Rename to a package name you like. I've changed it to at least include "unittest" and "pytest".
[ ] Remember to rename the repo too, and include that in setup.cfg, in the [metadata] section as the url to get links from PyPI back to GitHub.
[ ] Change license in setup.cfg to one you like.
[ ] python setup.py sdist bdist_wheel
[ ] twine upload dist/*

Bump! :birthday:


go: tags should include module name

For example, for github.com/aws/constructs-go, Instead of v3.3.1 the tag should be constructs/v3.3.1.
This technically allows different modules in the same repo to be tagged with different versions.
Reference: https://research.swtch.com/vgo-module#multiple-module_repositories

In the major subdirectory convention, v2/ contains the module “my/thing/v2”. A natural extension is to allow subdirectories not named for major versions. For example, we could add a blue/ subdirectory that contains the module “my/thing/blue”, confirmed by a blue/go.mod file with that module path. In this case, the source control commit tags addressing that module would take the form blue/v1.x.x. Similarly, the tag blue/v2.x.x would address the blue/v2/ subdirectory. The existence of the blue/go.mod file excludes the blue/ tree from the outer my/thing module.

Resolved by https://github.com/aws/jsii-release/pull/27


Change unnamed related object from * to -

We just want one thing to possibly match, using "*" makes it seem like all of the things are bad. Using "-" also matches what we do for some things when we don’t know/care about the namespace
Ref: https://issues.redhat.com/browse/ACM-8782
Related: https://github.com/stolostron/console/pull/3196

/cc @JustinKuli @mprahl  @dhaiducek

/hold

/test ci/prow/pr-image-mirror

/test pr-image-mirror

/re-test pr-image-mirror

/test pr-image-mirror
/test unit-tests-sonarcloud

/retest

/retest

/restart

/retest

/retest

/unhold

/cherry-pick release-2.10

Already cherry picked to 2.10 https://github.com/stolostron/console/pull/3328


Looking for help maintaining (reviewing PRs) in arrow/parquet/object_store

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
PRs in this repository are now taking days/weeks to review, which results in

Slower velocity (how fast we can change this library)
A bad community experience (if you get no feedback for a while, it is likely you will go elsewhere to help)

This repo isn't something "we" are providing or are gate keeping. This is project is a community effort in all aspects.
Describe the solution you'd like
I would like more capacity to review PRs in this repo so that we can merge them faster and accelerate progress in this repository.
Reviewing PRs means;

Ensure all PRs are looked at in a timely manner (ideally within 24 hours) (see list here)
Ensure the PR follow the contribution guidelines.
Ensure the PR is clearly documented, and the code follows existing patterns
Ensure the new functionality is covered with tests
When it looks good, @ mention one of the committers and we'll give it a review and merge

Describe alternatives you've considered
I would like everyone who contributes code to this repository to feel both welcome and empowered to review PRs. It takes time and effort, no doubt, but you will very likely learn something and sustained help reviewing PRs is a great way to be considered for committer yourself.
If you are waiting on a review, please consider helping review other PRs -- it will reduce the time before your PR is reviewed.
People may have the idea that PRs can only be reviewed by "committers" in arrow. However, this is not the case -- committers need to do a final approve + merge, but anyone can (and should!) be reviewing other PRs.
As an example, @iffyio's work in sqlparser-rs is textbook example of how to review PRs: https://github.com/sqlparser-rs/sqlparser-rs/pulls?q=is%3Apr+commenter%3Aiffyio
Additional context
Previously @tustvold spent a significant amount of his effort on reviewing PRs in this crate and was paid to do so by InfluxData.  He has now moved on to other endeavors, and while he is still helping and InfluxData is working on backfilling his review capacity this project should not be seen as something we can afford to maintain by ourselves

BTW total kudos to @Xuanwo  for their help so far -- it has been most apprecaited

@alamb I'd be happy to chip in. Especially around the extremely older ones. Because I feel some of them have stalled to the point where they're effectively obsolete but still keeping an entry in open issues' list.

BTW total kudos to @Xuanwo for their help so far -- it has been most appreciated

Please feel free to ping me if there are object_store or storage-related PRs (such as the parquet async reader) that require my review, as I'm confident in handling them.
For other parts of this project, I'm still learning, so I can only handle the simpler ones.

@alamb I'd be happy to chip in. Especially around the extremely older ones. Because I feel some of them have stalled to the point where they're effectively obsolete but still keeping an entry in open issues' list.

That would be super helpful @ByteBaker  -- indeed some of the older ones are stalled indeed. Any help cleaning would be helpful (even if it is just a ping to me or another committer saying they should probably be closed)

@dsgibbons  asked on discord:

Is there a list of relevant committers for arrow-rs specifically? (as opposed to C++, Go etc.)

TLDR there is no such list I know of or official distinction between arrow commiters; However, clearly there are those of us who focus more on the rust implementation,
I think the easiest thing to do is look at who has merged recent PRs in this repo. Examples:  myself @alamb , @tustvold , @viirya , @Dandandan )

It might be worthwhile to include https://github.com/google/flatbuffers/issues/8150 on this list

It might be worthwhile to include google/flatbuffers#8150 on this list ( PRs google/flatbuffers#8398 #6426 )

@bkietz  what list  are you referring to?

I meant the list of PRs linked to this issue above

BTW there has been a marked uptick in review activity, thank you to @etseidl @wiedld @Xuanwo @westonpace @ByteBaker and others who I probably forgot for all their help 🙏

@alamb we don't have that much spare time to devote to reviews, but we are contributing a fair amount and using arrow-rs and datafusion a lot.
Therefore, we (Pydantic Services Inc.) could be happy sponsor individuals or organizations significantly (up to $1000/month) for helping to maintain and develop arrow-rs.
If that can help someone (or multiple people) find more time to work on arrow-rs (or datafusion), it would make me very happy. If not, feel free to ignore my comment — I know most people don't work on open source for the money, so I don't want to pollute the platonic ideals of open source with grubby 💸 if it's not wanted.

Clubbing the following together here for better tracking. These are for documenting unsafe's usage. I'll be going through each one and reporting on their respective pages. @alamb

[ ] #142
[ ] #143
[ ] #144
[ ] #145
[ ] #146
[ ] #147
[ ] #149
[ ] #150
[ ] #151
[ ] #152
[ ] #153

I'd urge others to also please go through the list above. If an item they see doesn't have a recent comment from me, please add your inputs.


Future API endpoints

In the future, we may want to have several models, and more than one version of each model.  We may also want each model to include a brief description in a separate JSON file, including info such as what the model does, author(s), source url, date released, license, etc.
my_model_v1.h5  – model file
my_model_v1.json – model info
Some suggested endpoints:

https://<api-url>/<api-version>/models GET: Lists all available models
https://<api-url>/<api-version>/<model-name>/<model-version> GET: Returns info for model-version of model-name
https://<api-url>/<api-version>/<model-name>/<model-version> POST: Upload a new model to the model library. Would have to be restricted via an api token/key or similar.
https://<api-url>/<api-version>/<model-name>/<model-version>/predict POST: Returns a task-id for the given URL/Image file
https://<api-url>/<api-version>/<model-name>/<model-version>/results/<task-id> GET: Returns a prediction for the given task-id

Interesting read on the subject of multi-model serving that is agnostic about model storage implementation and underlying ML frameworks:
https://exadel.com/news/deploying-multiple-machine-learning-models-on-a-single-server/


IMPORTANT: REPOSITORY ABANDONED

This repository has been abandoned. For more information read #81.
Ibantools is an alternative that works great!

Warning: Ibantools is NOT a MIT licensed project. Be very aware of this. Instead it's using a very restrictive license ( MPL-2.0 license).

Well

Warning: Ibantools is NOT a MIT licensed project. Be very aware of this. Instead it's using a very restrictive license ( MPL-2.0 license).

Well, it probably changed since this comment then:

Well

Warning: Ibantools is NOT a MIT licensed project. Be very aware of this. Instead it's using a very restrictive license ( MPL-2.0 license).

Well, it probably changed since this comment then:

No they didn't. It's still a dual license, thus also MPL-2.0 is very restrictive: https://github.com/Simplify/ibantools/blob/master/LICENSE.MPL-2.0

Really ?
According to https://www.tldrlegal.com/license/mozilla-public-license-2-0-mpl-2 it's pretty easy to comply with.
Most of the users will use it for an existing application and don't update the code.


Request to Allow Setting url Keyword in karate.config

Currently there seems to be no way to set a global url, without having to reference it in every feature file.  Would like to request allowing setting the url keyword in the karate.config, allowing the user to only specify url if they want to change the one currently in use.
karate.config:
karate.configure('url', "github.com");

feature file:
Feature: greeting end-point

Scenario: get default greeting

    Given path 'greeting'
    When method get
    Then status 200
    And match response == { id: '#number', content: 'Hello World!' }

I have 2 reasons why I'm against this.
Most tests will call APIs lying on more than one "host". And when you switch environments, you will need to switch all the hosts, not just one.
I agree that there could be a "primary" host. In which case this is the pattern we recommend.
Set a variable called urlBase from karate-config.js like this:
return { urlBase: 'http://localhost:8080' }

And you can default it to anything you want.
Then in all tests you will indeed need an extra line. And you can stick this in the Background if needed.
* url urlBase

Let me know what you think.

closing as wontfix but I will keep an eye on this while refactoring, reviewing tests created by others


Make ExitCodes an enum again

@BlythMeister which problem you are trying to solve now?

Reability and simplicity of the code...this was a struct that behaved like an enum.
So why not just actually be an enum.

Also this comment suggested making it an enum again...https://github.com/Topshelf/Topshelf/commit/d47f7a17312a7d35ce012eb10b3c0c7039914f67#commitcomment-30734708

Also this comment suggested making it an enum again...d47f7a1#commitcomment-30734708

This was solved shortly after.

Feel free to close this, but as someone external looking at this code for the 1st time, I was baffled as to why use a struct over an enum.
The usage syntax is exactly the same, thus, the intent is the same.
This also follows a similar usage pattern the the system.net httpstatuscode enum which does not specify every http status code, but allows for additional codes to be used.
Here are the arguments put much more elequantly than me by Jon Skeet https://stackoverflow.com/a/13429174/1780951


Updated version number from 1.2.4 to 1.2.6

Please explain your PR. A PR with no comment will be closed.

Thank you for your work, Marc.
There is no need in dependencyManagement block with rise-v2g-shared (version 1.2.4) in pom.xml if there is dependencies block with dependency rise-v2g-shared (version 1.2.6).


TypeError: Cannot read private member #context from an object whose class did not declare it

Describe the bug
Getting this error while running the npm run build command.
Reproduction
Unfortunately, I'm unable to provide links to the files for reproduction. I initially worked with Sveltekit during its beta phase, and now, as I attempt to update the website, it consistently fails during the build process.
Logs
No response
System Info
System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 467.30 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.5.0 - /opt/homebrew/bin/node
    npm: 9.8.0 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.3
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.34 => 1.0.0-next.34
    @sveltejs/kit: next => 1.0.0-next.347
    svelte: ^3.42.6 => 3.48.0

Severity
blocking all usage of SvelteKit
Additional Information
No response

There's nothing we can do to fix this if we don't have a minimal reproduction. I'm not sure whether there was ever a class with a private #context member in the SvelteKit codebase, but there isn't now.


fix wording

Three wording changes.
I think in the plain is correct but I added this change because the first read-through had me double checking. Open to interpretation.

Thanks!


Brand new SD card flash of Hassio asks for a login password when using Firefox Quantum 61.01

I just finished flashing my SD card with Hassio using Etcher for a Raspberry Pi 3. I found that trying to access the web interface using the newest Firefox Quantum (v 61.01) asks for a password to log in to the web interface as if one has been set in the config file (it has not). Leaving it blank does not work either.
It works fine on Chrome and Edge, going directly to the dashboard. It does not appear to be a cacheing issue as the same thing happens in a new private window in Firefox as well.

/move home-assistant/home-assistant-polymere

/move home-assistant/home-assistant-polymer


allowEmptyString not working

I'm getting the following error [angularx-qrcode] canvas error:  Error: No input text
I tried with different elementType but the error is persists

Thanks for the report, the underlying lib does not support it any longer (I used a different one before).
I fixed it by setting data to " " if empty strings are allowed.
Released with 12.0.1


Uninformative warning message

call paket init in empty folder
add nuget nunit 3.4.1 in paket.dependencies file
call paket install

Paket write warning like:
The profile 'portable-net45+monoandroid+monotouch+xamarinios+xamarinmac+win8+wp8+wpa81' is not a known profile. Please tell the package author..
Warning message does not contains information about package that cause problem.
Workaround: use verbose flag: in that case warning appears right after libraries found... for package with problem.

Duplicate of https://github.com/fsprojects/Paket/issues/2443


Use Type Safety of Navigation Compose for TimetableItemDetailScreen

Now we can use type safety. Can we use it for navigation to TimetableItemDetailScreen?
https://developer.android.com/guide/navigation/design/type-safety

✋🏻

Thanks! Assigned 👍