Aborting a completion request is broken because of AbortController mismatch

Package Name:
@azure/openai
Package Version:
1.0.0-beta.11
Operating system:
MacOS latest
[x] nodejs
v20.x
[x] typescript
5.3

https://github.com/Azure/azure-sdk-for-js/pull/28139
Describe the bug
Passing in a standard nodejs AbortSignal instance to a chatCompletion request is causing below error if controller.abort() is invoked:
node:internal/abort_controller:393
    abortSignal(this.#signal ??= createAbortSignal(), reason);
                    ^

TypeError: Cannot read private member #signal from an object whose class did not declare it
    at ServerResponse.abort (node:internal/abort_controller:393:21)
    at ServerResponse.emit (node:events:514:28)
    at emitCloseNT (node:_http_server:1023:10)
    at Socket.onServerResponseClose (node:_http_server:278:5)
    at Socket.emit (node:events:526:35)
    at TCP.<anonymous> (node:net:337:12)
    at TCP.callbackTrampoline (node:internal/async_hooks:130:17)

To Reproduce
Start a streaming or non-streaming chat completion request, make sure you pass in abortSignal option. Create the abort signal the standard way:
const controller = new AbortController;
const abortSignal = controller.signal;
const result = await chatclient.streamChatCompletions(...., { abortSignal })
controller.abort()

Expected behavior
The request is aborted.
Additional context
This looks relevant: https://github.com/Azure/azure-sdk-for-js/pull/28139

false report.

@PeterAronZentai Were you able to figure out the issue?


Add ARN of AWS IAM Role associated with the instance to outputs

what

Add ARN of AWS IAM Role associated with the instance to outputs

why

This might be useful in EKS aws-auth ConfigMap to allow access to private EKS API server endpoint

references

This pull request is now in conflict. Could you fix it @sturman? 🙏

Conflicts are fixed now

/terratest

/terratest


Add auto inference of host scheme in CLI

Motivation and context

Resolves https://github.com/openvinotoolkit/datumaro/issues/30

Added auto inference of host url schema in CLI, if it is provided in the url

How has this been tested?

Manual test
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage decreased (-0.01%) to 64.8% when pulling 3cbbad8858de4e503786d9ab99e684ffd7dfae00 on zm/cli-infer-host-schema into 7f73f5e3184ffa0ad1beafa4b87a38031ce65e48 on develop.


Upgrade SauceLabs. Make sure it reports Pass on success - upgrade QUnit.

SauceLabs was not reporting "Pass" at times. Easy fix. All it need is the latest grunt-saucelabs and the new QUnit. After the upgrades here is what it was and became: Picture.
Please, pull the upgrade_saucelabs branch and npm test to make sure it works for you.

Thanks!
This project needs some build config love... It's a bit too obvious that I was being hasty when I threw it together. =)

Speaking of build config.. check out Cloverfield and weigh in.


[New Feature]: No logo on the title and some buttons are not working

🎮 feature Request

There is no logo on the title I will add the logo on the title to make it look more good.
I'll implement a feature where the 'Welcome to our Discord server' message closes when users click the cross button. After closing, it'll be replaced by the Discord logo. Clicking on the logo will reopen the message.

Assign me this issue under GSSoC 24 at any level.
Thank you
Point down the features
feature points
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

@Amitesh-Mishra-AM Please raise any other issue, because someone is already working on it
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


App crash with version 3.0.0

Hi,
I'm with problem when I started the AFNetworkActivityLogger. When init the AFNetworkActivityConsoleLogger I received the message:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[AFNetworkActivityLogger loggers]: unrecognized selector sent to instance 0x7fd392e6d060'
My code is:
AFNetworkActivityConsoleLogger *logger = [AFNetworkActivityLogger sharedLogger].loggers.anyObject;
        logger.level = AFLoggerLevelDebug;
[[AFNetworkActivityLogger sharedLogger] addLogger:logger];
[[AFNetworkActivityLogger sharedLogger] startLogging];

I’m closing out old issues on this project, but if you still need help, feel free to ask on StackOverflow—and if you still get a crash, feel free to reopen this issue.


Program shortcut doesn't work in 0.2.3

The shortcut provided with the trainer is not working and has an invalid program path.

Will get fixed in the next release.


AY-7222 Make editorial package reviewable

Changelog Description
resolve #44
Make the editorial pckg intermediate media reviewable.
This PR needs to be tested alongside: https://github.com/ynput/ayon-core/pull/1041
Testing notes:

Ensure some reviewable setup is configured for Resolve

Open a timeline in Resolve and publish an editorial package from it
Ensure the intermediate media is properly processed as a reviewable

Looking good @robin-ynput - Lets enhance it even more please and add Review toggle into instance attributes and make it optional.

Looking good @robin-ynput - Lets enhance it even more please and add Review toggle into instance attributes and make it optional.

will do !


Switch default sort type to descending

Minor change referenced in issue #6 to just change the default sort to descending.

Github was having problem when this was updated.  I doubt it would fail, but I don't know how to redo the tests

Restarted the build...

Doesn't appear like it was ever restarted

Restarted again :)

Any idea as to why its being unsuccessful?

travis seems to have some issues... I merged this nevertheless. thank you


🐛 fix(bal-number-input): Validation broken

Current Behavior
The pattern passed to the input contains undefined values and min and max don't seem to have any influence
Expected Behavior
pattern should be correct format and min and max should restrict possible values
Steps to Reproduce
regular usage
Version
13.2.1
Browsers
No response
Device
No response
Code Reproduction URL
No response
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @mladenplaninicic, thanks for your reply :) So min and max are not supposed to actually do anything? And the pattern? It contains "undefined"

/cib

Hi @GinaBiondo-aperto
Found issue. PR is open will be released in the next release

There is still an error concerning the input pattern:


[w5][w16-1]Jiang Wulin

add edit command by index

Edit will be a useful command.  If have opportunity, we can update "edit by index" into "edit by name", which will be more intuitive for users.


Updated confusing line numbers on Local functions examples

Updated confusing line numbers in the code examples on the "Local functions (C# Programming Guide) page.
Comparing local-functions-iterator1.cs to local-functions-iterator2.cs and local-functions-async1.cs to local-functions-async2.cs caused confusion as to where the error was getting thrown, so I updated the line numbers in the exception messages. I couldn't find a way in the documentation to force line numbers to show, so I also added comments to the referenced lines so it was more apparent where and when the exceptions were being thrown.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: csrowell sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Feature] Generate settings panel from view model

Is your feature request related to a problem? Please describe.
Adding new entries to the Playground's settings panel is error-prone and it's really hard to change their order.
Describe the solution you'd like
The settings panel could be generated based on a view model that has a list of available settings.
Additional context
The settings panel in Nodify.Playground

Is this issue still active? I can take it

Hi! Yes, you can take it.

Hello, is the solution through Reflection suitable for the project?
It remains for me to figure out how to make bindings and place it all in a normal structure

Hey, I believe that Reflection would overcomplicate things. The real issue here is the XAML code for the settings panel. To add a new entry at the top (row 0), you'd have to manually offset all the other entries by one row. I think that having all the available settings hardcoded into a list of viewmodels would be enough. That way you could easily change the order of the items inside the list and that would reflect into the view.

Hello, list from Reflection will like sequence in PlaygroundSetting fields. If swap fields in PlaygroundSettings - list too will changed. But okay, I can implement viewmodels for settings, but I have not idea how associate settings from this list with PlaygroundViewModel (how PlaygroundViewModel will take settings? Create a separate method to find the required setting?)
I implement a way with viewmodels and share this. I apologize for possible stupidity, this is my first experience in such.

One option would be to implement IEnumerable in PlaygroundSettings and return the hardcoded list of settings (hardcoded inside the constructor most probably). Another option would be to create the list with the hardcoded items inside the PlaygroundViewModel's constructor. In both cases, the PlaygroundViewModel.Settings property will have the list of settings which will then be bound to the <local:EditorSettingsView DataContext={Binding Settings} /> view inside MainWindow.xaml.
Now you will have access to the bound settings inside the EditorSettingsView.xaml view via DataContext.
I hope that helps and feel free to ask any other questions.

Okay, I finally figured it out.
For each type settings will be created separate VM.
Base class for all them look like:
public class SettingViewModel : ObservableObject
{
    public SettingViewModel(string title)
    {
        Title = title;
    }
    public string Title { get; set; }
    protected Control _control = new();
    public Control Control
    {
        get => _control;
    }
}

Then every type settings will look like:
public class TextboxSettingViewModel : SettingViewModel
{
    public TextboxSettingViewModel(string title, double value) : base(title)
    {
        _control = new TextBox();
        _value = value;
        var binding = new Binding("Value") { Source = this };
        _control.SetBinding(TextBox.TextProperty, binding);
    }

    private double _value;

    public double Value
    {
        get { return _value; }
        set { _value = value; }
    }
}

Bindings tested and working successfully
But I have not idea how take value from settings without downcase. On this moment getting field value looks like that:
public List<SettingViewModel> Settings { get; set; } = new();
public MainWindow()
{
    Settings.Add(new TextboxSettingViewModel("Hello, world", 25));
    // If need get setting need do downcast
    if (Settings[0] is TextboxSettingViewModel)
    {
        double a = (Settings[0] as TextboxSettingViewModel).Value;
    }
}

I think there is an easier way for get setting, do you have any idea?

You could have a common interface for all the settings like this:
public interface ISettingViewModel
{
    string Name { get; }
    string? Description { get; } // This is the tooltip
    object? Value { get; set; }
}

The have a base setting class that's type safe:
public class BaseSettingViewModel<T> : ObservableObject, ISettingViewModel
{
    public string Name { get; }
    public string? Description { get;  } // This is the tooltip

    private object? _value;
    object? ISettingViewModel.Value
    {
        get => _value;
        set => SetProperty(ref _value, value);
    }

    public T Value
    {
        get => ((ISettingViewModel)this).Value is T val ? val : default!;
        set => ((ISettingViewModel)this).Value = value;
    }

    public BaseSettingViewModel(string name, string? description = default)
    {
        Name = name;
        Description = description;
    }
}

And a different sub-class for each data type so you can use DataTemplates to render the view where the value will be bound. (like a TextBox or a CheckBox, etc)
public class BoolSettingViewModel : BaseSettingViewModel<bool>
{
    public BoolSettingViewModel(string name, string? description = null)
        : base(name, description)
    {
    }
}

public class StringSettingViewModel : BaseSettingViewModel<string>
{
    public StringSettingViewModel(string name, string? description = null)
        : base(name, description)
    {
    }
}

Then you can still have a list of settings and you don't need to cast each instance to a specific type in order to access the Value property because that's available on the interface:
```csharp`
public List Settings { get; } = new List();
``

Doing this will probably work just fine but then how would you bind the settings to the editor? I think we could use the EditorSettings to do that for us and create a proxy setting that would just set properties on the EditorSettings instance.
Something like this:
    public class ProxySettingViewModel<T> : BaseSettingViewModel<T>
    {
        private readonly Func<T> _getter;
        private readonly Action<T> _setter;

        public ProxySettingViewModel(Func<T> getter, Action<T> setter, string name, string? description = default)
            : base(name, description)
        {
            _getter = getter;
            _setter = setter;
        }

        public new T Value
        {
            get => _getter();
            set => _setter(value);
        }
    }

And you could use it like this:
 new ProxySettingViewModel<double>(
                () => EditorSettings.Instance.AutoPanningTickRate,
                val => EditorSettings.Instance.AutoPanningTickRate = val,
                "Auto panning tickrate")

Wow, it is next level for me :D
I'm implement this, thank you for your attention.
It's a great experience for me

Hi @VBerman! Are you still working on this? If not, I will unassign it so others can pick it up. Thanks!

Unassigned due to inactivity.

is this feature still needed? If yes then is anyone working on it?

Yes, it's still needed. I don't think anyone is working on it. It seems to be a little bit difficult. Do you want to give it a try?

Hi Miroiu, I see that this issue is still open. If it hasn't been assigned to anyone else can I give it a try?

Hi @Riju-bak , I'd be happy if you give it a try.

Cool, I have already started. I'll share more details once I get something substantial done.

@miroiu So I basically went with your suggestion in the comments above.
We can now hardcode settings in the PlaygroundSetting.cs constructor and it will get reflected in the View. I'm using DataTemplate.Triggers to render the correct component based on data-type. Example: Textbox for uint and Checkbox for bool.
However, the triggers aren't getting triggered.
See PlaygroundSettingsView.xaml  in Settings Panel from ViewModel
I'm trying to fix this at the moment. Perhaps you could tell me what I'm doing wrong.
Apologies in advance, WPF is new to me.

Alright, I'll try this out day after tomorrow.

Thank you very much @Riju-bak for fixing this issue!

Thank you very much @Riju-bak for fixing this issue!

You're welcome @miroiu .
Also, this was my first open source contribution, so I'm feeling really good about this. :)


Serial API did not respond on Zwave-js Server with Vision Gen5 Stick

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
Serial API did not respond
What do you observe?
No
What did you expect to happen?
Run the regularly
Steps to reproduce the behavior:
I just installed Node-js 16 and npm on a new Raspberry Pi. I installed Zwave-js and Zwave-js Server with npm -g. I had to install some missing packages (@types/minimist, @types/triple-beam, ts-node, ws). I made a config.js with securitykeys and ran "ts-node src/bin/server.ts /dev/ttyACM0 --config config.js".
Device information
Manufacturer: Vision Security
Model name: Z-Wave USB Stick Gen5
Node ID in your network: 1
How are you using node-zwave-js?

[ ] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[ ] HomeAssistant zwave_js integration  (please specify version)
[X] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version:
node-zwave-js branch: 8.7.5
zwavejs2mqtt branch: not installed
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
No, it never worked anywhere
If yes, where did it work?
No response
Attach Driver Logfile
zwave_20211114.log

The driver restarts (aka. soft reset) the Z-Wave controller on startup to prevent it from being in any weird state it shouldn't be in.
For USB sticks this can cause them to restart and reconnect under a different port.
You can (and should) avoid that by using serial/by-id paths as outlined here. The link is for an application that uses zwave-js, but the steps should be the same for you.

Thanks for the feedback.
I replaced /dev/ttyACM0 by /dev/serial/by-id/usb-0658_0200-if00 but the error message is still the same.
This is what I get if I execute ls -l /dev/serial/by-id
lrwxrwxrwx 1 root root 13 15. Nov 10:15 usb-0658_0200-if00 -> ../../ttyACM0
I also checked the id with lsusb.
I also reconnect the stick and rebooted the Pi

The controller you're using, might have issues with soft reset, try disabling it.
{
  .....,
  .....,
  enableSoftReset: false
}

Thanks Marcus.
After adding enableSoftReset: false to my config
module.exports = {
  enableSoftReset: false,
  logConfig: {
      level: "silly"
  },
  securityKeys: {
  }
}

The driver crashes:
13:47:58.245 DRIVER   Failed to initialize the driver: Error: Failed to lock DB file "/usr/lib/node_
<EMAIL_ADDRESS>                          at JsonlDB.open (/usr/lib/node_modules/@zwave-js/server/node_modules/@alca
                      lzone/jsonl-db/src/lib/db.ts:229:10)
                          at async Driver.initValueDBs (/usr/lib/node_modules/@zwave-js/server/node_
                      modules/zwave-js/src/lib/driver/Driver.ts:909:3)
                          at async Driver.initializeControllerAndNodes (/usr/lib/node_modules/@zwave
                      -js/server/node_modules/zwave-js/src/lib/driver/Driver.ts:997:4)
                          at async Immediate.<anonymous> (/usr/lib/node_modules/@zwave-js/server/nod
                      e_modules/zwave-js/src/lib/driver/Driver.ts:817:5)
Error in driver ZWaveError: Failed to initialize the driver: Error: Failed to lock DB file<EMAIL_ADDRESS>    at JsonlDB.open (/usr/lib/node_modules/@zwave-js/server/node_modules/@alcalzone/jsonl-db/src/lib/db.ts:229:10)
    at async Driver.initValueDBs (/usr/lib/node_modules/@zwave-js/server/node_modules/zwave-js/src/lib/driver/Driver.ts:909:3)
    at async Driver.initializeControllerAndNodes (/usr/lib/node_modules/@zwave-js/server/node_modules/zwave-js/src/lib/driver/Driver.ts:997:4)
    at async Immediate.<anonymous> (/usr/lib/node_modules/@zwave-js/server/node_modules/zwave-js/src/lib/driver/Driver.ts:817:5) (ZW0100)
    at Immediate.<anonymous> (/usr/lib/node_modules/@zwave-js/server/node_modules/zwave-js/src/lib/driver/Driver.ts:834:6) {
  code: 100,
  context: undefined,
  transactionSource: undefined
}
Shutting down

The driver uses lock files to stop the DB from getting corrupted, normally this is an indication of the process being terminated unexpectedly  and  started again within a few second.
Could also mean, another process is running using these files, I.e 2 instances of the server.

I wonder how this can happen because it is a completely fresh setup.
How can I check whether a second instance is running?
Btw: If I remove enableSoftReset: false the error disappears

you're seeing the error - because it getting further 😄.
Wipe the cache (make sure the server is not running)
delete everything in (including cache folder)
/usr/lib/node_modules/@zwave-js/server/node_modules/zwave-js/cache

Thanks you very much, Marcus.
Now the issue is fixed.
I have to run it as root with enableSoftReset: false in the config.
Running it as root without enableSoftReset: false fails.

@AWSb24 could you post a driver log of the startup with the serial/by-id path, with and without soft reset disabled?
I want to make sure if we need to blacklist your stick aswell.
FYI, I just noticed this:

I installed Zwave-js and Zwave-js Server with npm -g

You don't want to install stuff globally, except maybe CLI utilities. This is probably also why you need to run as root.
Just create an empty directory and npm install the necessary dependencies there without the -g flag.

Without enableSoftReset=false it breaks after 3 attempts
zwave_2021-11-15-enableSoftReset_false.log
With enableSoftReset=false it seems to run smooth. I also added a Node 46.
zwave_2021-11-15-enableSoftReset_true.log

Huh, that looks like a premature exit. The driver should be waiting 2, 5, 10, then 15 seconds and each time test if the Serial API is back.
Let me fix that.

@AWSb24 can you install this version and test again with soft reset enabled?
npm install<EMAIL_ADDRESS>

@AlCalzone Sorry but it seems the error is not fixed. This is the log with 8.7.6:
zwave_2021-11.15-8.7.6.log

The error is fixed, but it doesn't help you :) The stick needs to be blacklisted for soft reset.

Danke!


XSS vulnerability

Hi, first of all, thanks for this project; it saved me a lot of time.
I've just discovered that ouput from database is not sanitized berfore rendering it in html, and as far as I know, this makes this application vulnerable to XSS attacks.
It would be nice that EXPLORER_TRANSFORMS could skip the html sanitization, but documentation should clarify that it's use with char fields can be dangerous.

This appears to be an intentional choice (autoescaping is turned off in the two templates that handle rendering of data). I would be curious what the reasoning is for this is... It's a very unsafe default, and certainly violates the "principle of least surprise" mentioned in the README.

I supposed this is true...the idea is that you can write sql like:
SELECT '' || profile_pic || '' FROM users

And, for instance, render a gallery of users' profile photos in the results area. But I do see the issue -- it just doesn't come up with the type of data we store in our main explorer target.
I think the fix you proposed @JshWright -- #286 -- makes a lot of sense.


Best configuration for finetuning

Do you have an idea for the best configuration for finetuning ? Which optimizer, which LR reduction strategy, need for dropout, regularization, need for weird learning technics?

Btw for my current configuration I'm using this LR reducer with adam optimizer, LR set to 0.001, and regular tf training :
lr_reducer = tf.keras.callbacks.ReduceLROnPlateau(
        monitor="val_classification_loss", patience=3, min_lr=1e-6, mode='min')

I didn't train much on them. Saying the optimizer, many articles and my own practices result that SGD + momentum works better than adam on finetuning. You can also check SGDW / AdamW from tensorflow-addons. It also seems better using tfa.optimizers.Lookahead when finetuning.
The lr scheduler, recently I'm mainly using tf.keras.experimental.CosineDecayRestarts for SGD, also starts from initial_learning_rate=1e-3 for finetuning.
Other weird technics like StochasticDepth also comes from tensorflow-addons may also help:model = efficientnet_v2.EfficientNetV2L(input_shape=(None, None, 3), survivals=(1, 0.8), dropout=1e-6, classes=1000)

Dropout or other regularization, I hadn't tested on them...

Thank you very much for your insights!


AAD Brute Force Hunting query

Proposed Changes

Include a new hunting query for AAD Brute Force

Hi @shainw
Not sure what is failing in this file!
Could you please let me know what is wrong to fix it?
Regards

Hey @cmaneiro, We have resolved the issue for PR Validations failure and request you to please update your PR branch with the latest changes from Azure:master so that the PR Validations can be executed.... Thanks!!!

Hey @cmaneiro, We have resolved the issue for PR Validations failure and request you to please update your PR branch with the latest changes from Azure:master so that the PR Validations can be executed.... Thanks!!!

hi @v-sabiraj
All validation pass!!! coul you please close #3634 which is a duplicated!
Regards

Hi @aprakash13 and @shainw
I've update the HQ according to comment in #3634 could you please close #3634 and keep working in this PR? the other one was a test that I'm not the owner.
Regards

Hi @shainw, @aprakash13
Any update on this PR? All the requested changes has been implemented.
Regards


omit some unnecessary

Hi , It's not a bug but a recommendation
It's better to remove type="text/javascript" from all JavaScript tags in  (js_v2_checkbox.html, js_v2_invisible.html, js_v3.html )
Because it's unnecessary
Thanks

@BamdadMeh

It's better

Why?
From MDN:

Attribute is not set (default), an empty string, or a JavaScript MIME type
Indicates that the script is a "classic script", containing JavaScript code. Authors are encouraged to omit the attribute if the script refers to JavaScript code rather than specify a MIME type. JavaScript MIME types are listed in the IANA media types specification.

"Authors are encouraged" doesn't mean "it is better" to change existing code base. You can spend your time way better than arguing about this.
Also, I believe, you are encouraged to make a PR and it will be accepted with no friction.

Sure, next time please be constructive and don't formulate your response as a personal attack.

Let's go back on topic!

@alanverresen feel free to make a PR!
95% of the sites out there use HTML according to w3techs. We don't really care for XHTML support.

Closing as #324 is merged


ACTIONS in "make_vec_envs" vs regular Actions

Hi :) Thank you again for this great resource. I have a question about the definition of actions in the manual control script vs the definition of actions in the RL training script. I hope to be able to use the "learned" policy, with defined actions --> and be able to visualize the policy learned in a "agent" point of view like the manual control script.
For this purpose (I don't know if this is a particularly dumb solution, or if there is a more miraculous and easier solution), but I imagined I would feed the actions from the trained policy --> into the manual control script, but the problem is that the actions from the RL script are integers [0], [1], [2] in the Hallway problem. How do these correspond to actions like move_forward, move_left etc.? What is the mapping?
Thank you very much for the kind help!

Hi again @sunchipsster1,
So the first thing I should mention is that there is a visualize.py script that is made for visualizing trained policies, so this probably does what you want: https://github.com/maximecb/gym-miniworld/blob/master/pytorch-a2c-ppo-acktr/visualize.py
As for the mapping of names to actions, it happens here:
https://github.com/maximecb/gym-miniworld/blob/master/gym_miniworld/miniworld.py#L437
This uses an IntEnum, so each name gets assigned an integer value. This is so we can avoid having to refer to actions by number and instead have something more readable in the code.

Hi @maximecb ,
Thank you again for your kind reply! You have a beautiful function "enjoy.py" which produces examples of the policy being played, thank you for writing this!
I tried to use visualize.py. I just wanted to confirm: in order to use visdom_plot, it is not correct to simply feed it the data from the pt files, e.g. MiniWorld-Hallway-v0.pt correct?
It seems in line 56 of visualize.py, one must have stored data into csv files to begin with, in order to load this data into visualize.py. Therefore, I want to confirm that we are meant to modify the code to collect the data they want to visualize (like saving episode_rewards into a csv) in order to then use visualize.py, correct?
Thank you again!

Right, actually, I think enjoy.py is the script that you want. The visualize.py script is for showing graphs. I've never used it. It's possible that it's broken.


OCSP pkix-ocsp-no-check extension handling

What is not working as expected?
https://github.com/notaryproject/notation-core-go/blob/453a5ebcbfdc19dfb91162b2fff8edff8b4ed083/revocation/ocsp/ocsp.go#L158-L167
I think the OCSP implementation is not quite right. The pkix-ocsp-no-check extension should be part of the certificate rather than the OCSP response.
References:

https://techcommunity.microsoft.com/t5/ask-the-directory-services-team/implementing-an-ocsp-responder-part-ii-preparing-certificate/ba-p/396524
https://www.rfc-editor.org/rfc/rfc6960#section-<IP_ADDRESS>.1

What did you expect to happen?
No
How can we reproduce it?
No real effect.
Describe your environment
Source code
What is the version of your notation-core-go Library?
v1.1.0-rc.1

Yes, it is valid.


partial vs template recommendation unclear

In https://gohugo.io/templates/introduction/#includes it says "Starting with Hugo v0.12, you may also use the partial call for partial templates".
In https://gohugo.io/templates/partials/#use-partials-in-your-templates it says "When using Hugo v0.12 and newer, be sure to use the {{ partial "<PATH>/<PARTIAL>.html" . }} syntax".
These two pieces of text gives different impressions - it's unclear whether or not you SHOULD use partial instead of template with Hugo 0.12 and forward, or if it's just an option you have but without recommendation.
In short, one of them should be clarified to match the other :)

this is a docs issue. you should close this one and open it in the docs repo.

Thanks for the pointer @vassudanagunta.


mwa: Improve how MWA exposes errors

Currently, MWA doesn't properly expose the error state when errors occur in the underlying resources that the app is showing. Our goal it to further improve how the app exposes errors to better inform users what is happening. We want it to be clear to users when there's progress being made or when something unexpected has happened. So, in this PR:
Frontend

Receive the raw YAML of each ISVC and:
a. Check for a Ready condition with status: true and if exists, it shows a :white_check_mark:.
b. Check the .status.conditions and show the first condition of the ordered list, since it has the one-liner reason and a message.
c. If there are no conditions, it shows a  :warning: with a message that explains there is no status and urges users to take a look at the events.
Show an admonition in the details page of each ISVC with a detailed message on the current status.
Extend the details page by adding an EVENTS tab that shows the events emitted for the specific ISVC, like we do for the other apps.
Remove status item from both the OVERVIEW and DETAILS tabs, as we've added the admonition to the details page.

Backend

Extend the code to also fetch the events of an ISVC.

Screenshots

Related PR: https://github.com/kubeflow/kubeflow/pull/6952

/lgtm
/approve


Autocomplete diagnostic for primary associated types fails to include them

Describe the bug
Trying to let the compiler autocomplete an endpoint that is constrained with a protocol that has primary associated types fails to do so:
Steps To Reproduce
Type the following into a Swift file:
protocol P {
  associatedtype A
  associatedtype B: P
  var b: B { get }
}

struct S: P {
  var b
}

And try to autocomplete from var b. You should get:
var b: some P 🛑

Which is not valid Swift code and even comes with a compiler error:

🛑 Property declares an opaque return type, but has no initializer expression from which to infer an underlying type

Expected behavior
I expect the primary associated type to be included. E.g.,
var b: some P

Environment (please fill out the following information)

OS: macOS 11.0
Swift 5.7
Xcode Version/Tag/Branch: 14 beta 5

Still a problem in Swift 5.9 / Xcode 15.
Would be nice for libraries to have some control over this.

+1, a library I'm developing really struggles with the lack of support of this.


feat(secrets): use kind name as default secret's prefix

Use kind name as prefix for secrets to avoid collisions.
Old secrets will be removed in future releases.

Hey @mortenlj, @jordiclariana!
Would this solution work for you?

Hi @byashimov!
My honest opinion is that this is an improvement, but it does not solve all the cases where a collision can happen. For instance, an application might need 2 redis instances (1 for cache and the other one for sessions). With this implementation, you cannot do that with aiven-operator, since the environment variables mounted into the deployment/pod, will overlap each other. Also, the new prefix in the env vars is good, but it does not avoid possible collisions with already existing env vars (it makes it more difficult, but not impossible, and most importantly, it does not provide a method to avoid it). Hence my proposal here that you already saw (allow me to link it here for visibility), which in my opinion gave way more flexibility.
In any case, thanks for the prompt response, really appreciated. And if you reconsider my implementation, maybe we can refine it to make it more aligned with your coding guidelines if necessary.

Also, this will be a breaking change in coming releases, which can be quite annoying with large setups.

We have decided to pivot slightly, so this is not important for us (we handle the secrets in our own operator), but I do think @jordiclariana has a point with how this would work when an application needs two Redis instances for instance.

Hi @jordiclariana
Thank you for your detailed response.
Nice catch with two redises case.
So we have several issues here:

var's name collision between services of different type
var's name collision between services of the same type
backward compatibility
and for postgres: some names have prefix, some do not, so it can't be solved with a custom prefix:"PGSSLMODE":    s.URIParams["sslmode"],
"DATABASE_URI": s.URI,

I've merged both solutions into this PR,
and left credits for the prefix feature to @jordiclariana in the changelog.
It should solve all the cases now.
Does it work for you?

Tests are green.

It definitely works for me! Thanks so much for the heads up and the work done.


Update filter_used.sql

Better performance since wildcard is not needed for perm_table_name = 'Internal Worktable'

Opps, sorry about that.


Screen to show no entry found

When a technician searches for a computer that does not have the result pane show 404 no entry found rather than the nothing it currently does.

Implemented in commit https://github.com/rstrom1763/AF-NCC-Scripts/commit/09ebdd7523cb0b5768ac1b244c6c1c36b63ad760


ZIP file as part of this repo?

Dan, I have a zip file within this repo - I know it is not a good practice, but it has node-modules needed to run the sample. And I know it is definitely NOT a good practice to check in node-modules. Zip file gets auto-generated during deployment script running.
Q: - Do we keep or delete this zip file?

@romankhar I think we'll do what we are now doing for the serverless-apis example. We add an npm build step.

Closing this since @krook implemented this already.


Fix several erroneous links in docs.

Fix link to apple-touch-icon.png
Fix link to "layout docs" on introduction page
Fix link to "narrow jumbotron" example
Remove line referring to documentation about .navbar-left & .navbar-right since they are no longer included in Bootstrap
Fix additional broken links.

Spawned from #17314.

:+1:
I will try to go through docs too after I clean up my branch.

/CC @mdo for feedback too.


Make it clear project is Python3 only

Thanks for a very useful library!
It might be worth adding a note to the readme that it is Python3 only - or adding something to setup.py e.g.  python_requires='>=3.5'
On Python2 there are the following errors:
ImportError: No module named lzma
import urllib.error
ImportError: No module named error

Thanks for the hint. I'll think about whether to add a note or making the library compatible with Python 2.
@geographika Do you think supporting Python 2 is still necessary?

I'd imagine the library is used for one-off devops scripts rather than as part of a larger application, which would mean py2 compatibility is less important (for info I'm using it to check Python versions available in Debian that are installed on https://live.osgeo.org).
I'd imagine py2 support would require a few changes (no lzma library, url functions not available etc.). A project description at https://pypi.org/project/apt-repo/ would maybe me of more benefit if you have time to spend on the project.
Thanks again for your work.


idea: add support for low-down

Would be great if users could request a low-down to get active SAM´s ( bullseyes ) etc.
Integration with DCS-Hound would be sweet :-)

Thanks for the idea. It'll probably wait as my current priority is https://github.com/dharmab/acmi-exporter


Conversion to internal format incomplete.

Hello,
Fields falling on the conversion-exit other than ALPHA are not converted. E.g. Unit of Measure are not converted.
Case sensitive flag is ignored. Such fields are automatically converted to upper case in SAP, unlike abap2xlsx.
Field length is ignored (Excel cell does not fit in internal field).
I have built a generic method (wrapper of standard FM RS_CONV_EX_2_IN_NO_DD) which supports literally every elementary ABAP type.
How would it best work to have this conversion in abap2xlsx and reuse it at the same time?

Please provide the minimum program in order to reproduce the case (possibly an Excel file if your program reads a file). I think that the conversion exits need to be completely reviewed, it's done from time to time, sometimes incomplete, and we must be careful to not change the behavior in case some clients prefer getting the internal value.
I guess it's best to discuss it, and you can then propose a pull request.
Thank you.


Fix circular dependency issues in rollup-core

Description
rollup-core currently depends on rollup-contracts for various L1/L2 node initialization tasks. rollup-core is used within many other packages, meaning we end up with circular dependency errors within rollup-contracts. This PR shifts these dependencies into rollup-full-node, the only package actually making use of the offending functions (will not be a dependency of rollup-contracts)
Metadata
Fixes

Fixes YAS-546

Contributing Agreement

[x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

Looks fine -- I might suggest leaving environment.ts in rollup-core though. That should just be reading env vars, and it's convenient to have all of those in one place. I could also be convinced to separate them by service, but I think we may have the same ones for a number of services, so consistency could be nice.

Sounds good. Will make that update in a sec.


How do I get a list of all instruments

Hello all,
I tried:
import configparser  # 1
import oandapy as opy  # 2
#read oanda.cfg
config = configparser.ConfigParser()  # 3
config.read('oanda.cfg')  # 4
#store token in variable
access_token_wk=config['oanda']['access_token']
account_id=config['oanda']['account_id']
print(account_id)
#print(access_token_wk)
oanda = opy.API(environment='practice',access_token=access_token_wk)  # 5
list=oanda.get_instruments(account_id)
print(list)
but I get the next error:
OandaError: OANDA API returned error code 1 (Invalid or malformed argument: accountId)
How can I solve this?

What does your account ID look like? If it's of the format 1-2-3-4 it's a v20 account and you'll have to use the v20 API/library

Where can I find that code? Or is it the same as my user name? I thought it was the latter.

https://github.com/oanda/v20-python provides an api that allows you to work with v20 accounts

To be more specific: https://github.com/oanda/v20-python-samples/blob/master/src/account/instruments.py


Where to get?

Is there source code and/or a binary for this project? Apologies if I'm missing something but I can't find any more than a README.md.

Same here..
Looks like its discontinued or something :/

Not a single soul had a interest in this until now. Since there was no rush, I never uploaded it. I certainly have some obligations to update my Github projects though. This one, and WP-OAuth could use some work. I appreciate your interest and I'll let you guys know when I post the source code.

Please push the source code

+1, please upload it, I would love to do the benchmarking!

Waiting here to test that on Windows CE devices

6 months had passed... no show...

 Really bad!!! I had to use TortoiseGit just to get the commit to work, then I had to Sync thru Github for Windows because TortoiseGit is not straightforward with the Sync (where is the Sync or OK button?). It's unacceptable for something that should be so simple.

Closing this so everyone is notified of the update.
Please start a new topic if you have any questions.


Bug: Dropdown options should not be editable

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x ] This is bug in the application 🐛
[x ] I am running the latest version
[x ] I checked the documentation and found no answer
[x ] I checked to make sure that this issue has not already been filed
[x ] I'm reporting the issue to the correct repository

Describe the bug
The options from the selection menu, can be edited, and also I noticed this was mentioned in the currently merged PR #119
To Reproduce
Steps to reproduce the behavior:

Hi, I would like to work on this, can you add the hacktoberfest label and assign it to me.

@BismeetSingh hmm, having it as a searchable is odd, but if it is a feature then this issue can be discarded

All bugs are features 😆


Support for "Virtual host" used by Kubernetes Ingress

Currently client pases original "Host" header coming from request. This way kubernetes ingress can't dispatch call to respective service.
Host header should come from target hostname and original Host could be placed in x-forwarded-host header as proxy usually do.
Suggested solution:
L50:
Object.keys(data).forEach(key => {
req.set(key, data[key])
if(key.toUpperCase() === 'HOST'){
req.set(key, target.host);
req.set('x-forwarded-host', data[key]);
}
})

Is there an alternative to smee that support this then? if smee won't fix this? I have the same issue. and I think if you have a VM running http server with virtual hosts the proxy won't work as expected... smee should provide this or a way to override the HOST header sent to the target host

Currently client pases original "Host" header coming from request. This way kubernetes ingress can't dispatch call to respective service.
Host header should come from target hostname and original Host could be placed in x-forwarded-host header as proxy usually do.
 Why not put the change and make a PR to see if it is accepted.... it is annoying having to have a customized version of smee!


Application not running in heroku

Application error
An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details. You can do this from the Heroku CLI with the command
heroku logs --tail
2018-10-31T12:13:08.838546+00:00 app[web.1]: * Serving Flask app "app" (lazy loading)
2018-10-31T12:13:08.838730+00:00 app[web.1]: * Environment: production
2018-10-31T12:13:08.841062+00:00 app[web.1]: WARNING: Do not use the development server in a production environment.
2018-10-31T12:13:08.841387+00:00 app[web.1]: Use a production WSGI server instead.
2018-10-31T12:13:08.841452+00:00 app[web.1]: * Debug mode: off
2018-10-31T12:13:11.523163+00:00 app[web.1]: Using TensorFlow backend.
2018-10-31T12:13:11.523187+00:00 app[web.1]: * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
2018-10-31T12:13:22.226579+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2018-10-31T12:13:22.226579+00:00 heroku[web.1]: Stopping process with SIGKILL
2018-10-31T12:13:22.511802+00:00 heroku[web.1]: Process exited with status 137
2018-10-31T12:13:22.530997+00:00 heroku[web.1]: State changed from starting to crashed
2018-10-31T12:13:22.533485+00:00 heroku[web.1]: State changed from crashed to starting
2018-10-31T12:14:05.139706+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=shocking-citadel-93453.herokuapp.com request_id=7fead736-998e-4eac-ba2e-1e7802a25ec3 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-10-31T12:14:07.746292+00:00 heroku[web.1]: Starting process with command /bin/sh -c python\ app.py
2018-10-31T12:14:10.722000+00:00 app[web.1]: [WARN  tini (4)] Tini is not running as PID 1 and isn't registered as a child subreaper.
2018-10-31T12:14:10.722030+00:00 app[web.1]: Zombie processes will not be re-parented to Tini, so zombie reaping won't work.
2018-10-31T12:14:10.722036+00:00 app[web.1]: To fix the problem, use the -s option or set the environment variable TINI_SUBREAPER to register Tini as a child subreaper, or run Tini as PID 1.
2018-10-31T12:14:48.668818+00:00 app[web.1]: * Serving Flask app "app" (lazy loading)
2018-10-31T12:14:48.668878+00:00 app[web.1]: * Environment: production
2018-10-31T12:14:48.674407+00:00 app[web.1]: WARNING: Do not use the development server in a production environment.
2018-10-31T12:14:48.674877+00:00 app[web.1]: Use a production WSGI server instead.
2018-10-31T12:14:48.674964+00:00 app[web.1]: * Debug mode: off
2018-10-31T12:14:50.868248+00:00 app[web.1]: Using TensorFlow backend.
2018-10-31T12:14:50.868263+00:00 app[web.1]: * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
2018-10-31T12:15:05.937244+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=shocking-citadel-93453.herokuapp.com request_id=9e325bbd-846b-451e-a336-a7c39633ccd3 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-10-31T12:15:08.174990+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2018-10-31T12:15:08.174990+00:00 heroku[web.1]: Stopping process with SIGKILL
2018-10-31T12:15:08.518134+00:00 heroku[web.1]: State changed from starting to crashed
2018-10-31T12:15:08.500982+00:00 heroku[web.1]: Process exited with status 137
2018-10-31T12:15:08.731539+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=shocking-citadel-93453.herokuapp.com request_id=c0b6e63b-8e18-459c-848a-c192d83422c2 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-10-31T12:16:54.389356+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=shocking-citadel-93453.herokuapp.com request_id=849239a0-19ca-49f6-9ca4-41355911d118 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-10-31T12:16:54.872502+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=shocking-citadel-93453.herokuapp.com request_id=76e7d4cc-4464-49d4-9f67-6197c11e6341 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https
2018-10-31T12:18:48.486029+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=shocking-citadel-93453.herokuapp.com request_id=d670a063-accc-4fa4-a2f3-e4bb9e8bdbe2 fwd="<IP_ADDRESS>" dyno= connect= service= status=503 bytes= protocol=https

I am deploying the docker container on heroku

Without modifications the container will not run on Heroku.
If you clone my modified fork https://github.com/ptitzler/MAX-Audio-Classifier and run the following commands you can get this to work (but we are not claiming official support):
$ git clone https://github.com/ptitzler/MAX-Audio-Classifier
$ cd MAX-Audio-Classifier
$ heroku login
$ heroku create
$ heroku container:login
$ heroku container:push web
$ heroku container:release web

Once released you can invoke the model's inference endpoint (replace the app name)
$ curl -F<EMAIL_ADDRESS>-XPOST https://whispering-crag-56047.herokuapp.com/model/predict

{"status": "ok", "predictions": [{"label_id": "/m/06mb1", "label": "Rain", "probability": 0.7376469373703003}, {"label_id": "/m/0ngt1", "label": "Thunder", "probability": 0.60517817735672}, {"label_id": "/t/dd00038", "label": "Rain on surface", "probability": 0.5905200839042664}, {"label_id": "/m/0jb2l", "label": "Thunderstorm", "probability": 0.5793699026107788}, {"label_id": "/m/07yv9", "label": "Vehicle", "probability": 0.34878015518188477}]}

If you inspect the log file you'll notice that the process exceeds the (500MB) memory quota.

Closing issue because there has been no activity for 2+ weeks. Re-open if needed.


CORE-20089: Use ExceptionDetails in body when exception is caught

Update exceptions to use ExceptionDetails when an exception that inherits from HttpApiException is caught. This allows for a more detailed exception with separate fields for title, exception cause and reason.
Update tests that assert certain exceptions
Reduce duplicate code where there are multiple catch blocks

build e2e


islamic dataset

Assalam o Alaikum brother i need islamic questions and answers dataset can u provide me?

Walikom alsalam bro,
Actually, I didn't work on one before, but I use Masader (https://arbml.github.io/masader/) to find Arabic datasets. They did a great effort on indexing almost all Arabic datasets with many metadata fields including "Access". Please, feel free to have a look there.
Thanks.


Removing some marshalling code for bound function

In order to fix OS14392550, I was trying to make the changes in the bound function. However with few testing it is determined that we don't need to  have this unnecessary marshalling code.
Added few test-cases to see if the marshalling does work as expected.

@curtisman have a look at this one.


Add timeout operations

Codecov Report

Merging #17 (199c720) into main (010631f) will decrease coverage by 2.07%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   79.15%   77.07%   -2.08%
==========================================
  Files           8        8
  Lines         590      615      +25
==========================================
+ Hits          467      474       +7
- Misses         82       91       +9
- Partials       41       50       +9

Impacted Files
Coverage Δ

pkg/stream/client.go
70.24% <50.00%> (-3.67%)
:arrow_down:

pkg/stream/producer.go
75.34% <50.00%> (-4.37%)
:arrow_down:

pkg/stream/consumer.go
89.74% <60.00%> (-4.86%)
:arrow_down:

pkg/stream/coordinator.go
79.41% <100.00%> (ø)

pkg/stream/utils.go
90.00% <100.00%> (+23.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010631f...199c720. Read the comment docs.


RedisTimeoutException:Unable to get connection! Node source: NodeSource

Expected behavior
Should work without any exception.
Actual behavior
Random exception I can't reproduce
Calling Rlock.ulock() after the server has been running for a period of time (days or months?) will throw the following exception:
org.redisson.client.RedisTimeoutException:Unable to get connection! Node source: NodeSource [slot=null, addr=null, redisClient=null, redirect=null, entry=MasterSlaveEntry [masterEntry=[freeSubscribeConnectionsAmount=1, freeSubscribeConnectionsCounter=50, freeConnectionsAmount=32, freeConnectionsCounter=112, freezed=false, freezeReason=null, client=[addr=redis://redis.public-app-prod.svc:6379], nodeType=MASTER, firstFail=0]]], command: (EVAL), command params: [local mode = redis.call('hget', KEYS[1], 'mode'); if (mode == false) then redis.call('publish', KEYS..., 2, lock:srm-primary:ADD_PUR_TASK, redisson_rwlock:{lock:srm-primary:ADD_PUR_TASK}, 1, 30000, f31e3332-4558-4feb-a569-0efaa6bbce11:29275:write] after 3 retry attempts
at org.redisson.command.CommandAsyncService$10.run(CommandAsyncService.java:703)
at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:672)
at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:747)
at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:472)
at java.lang.Thread.run(Thread.java:748)
The exception is that redisTemplate can still work normally to get data
Calling Rlock.ulock() or Rlock.trylock() will cause an exception
Service restarts back to normal
Redisson version
3.9.1
Redisson configuration
single node
redisson initialized via redisson-spring-boot-starter
Why does this exception occur, and how to reproduce this exception stably?
How to fix this exception?

[Did you try to increase con](https://github.com/redisson/redisson/wiki/16.-FAQ#q-what-is-the-cause-of-redistimeoutexception)


Make the button audio slightly less abbrasive

I noticed that a lot of the jam submissions kept the default button sounds which, over time, started to annoy me. Maybe we should switch to more "gentle" sounds and make them a bit more quiet?

There's something to be said about ugly UI / SFX in the template encouraging devs to replace them with their own. At the same time, I'm sure there are some users that just want to focus on building the "meat" of their game and would prefer a nicer default.

If @Instelce if okay with it, maybe we could use the buttons from https://github.com/Instelce/postman-speed-race/. I quite like those :)


UI-Tests (02-05)

TESTED VERSION: STAGING 2024-05-08T10:20:55 a0ddf4

PRIO1 ... critical bug, blocks release
PRIO2 ... bug, but doesn't block release
PRIO3 ... not nice, not critical for release

[ ] PRIO1 Network switch at wrong action for dm3 name
The network change in the wallet is triggered when the user selects the method for the dm3 name storage (at the moment: cloud or op )
EXPECTED: The network change must be executed only if the "claim and publish" button is pressed.

[ ] PRIO1 Network switch at wrong action for ens/gno name
the same as above
EXPECTED: The network change must be executed only if the "publish" button is pressed.

[ ] PRIO1 Network mismatch (related to errors above)
When I switch to op at dm3 name and later to gno and then press "claim and publish" for the op-dm3 name, the wrong network is selected (gnosis).
EXPECTED: In the moment of publishing, the correct network must be selected. ALWAYS: when I publish and need network XYZ, this network needs to be activated in this moment. (The error is valid, if the user declines a network change).

[ ] PRIO2 Copy and paste still not correct
When I copy the OTP from the email and past it to the input mask, only the first number is pasted, and the cursor jumps to position 2
EXPECTED: All numbers are added (this is common praxis at other apps)

[ ] PRIO1 Add info text to notifications
ADD: "Experimental function. Do not use in production!"
(Reason: we need to add some functions required for European regulation). see pic 01

[ ] PRIO2 No network selection at signin
When I sign in, it can happen that dm3 asks for a network change. (e.g. if I selected something in the config dialog before a refresh.
EXPECTED: at the sign-in, we don't care what network the user is connected to! No network change requests at this point because the user will be confused of this!

Pictures
01

Copy paste issue
The reason is copy clipboard not works on HTTP. This is the same issue we encountered on copying address in Rainbowkit modal. It works on localhost & on https secure context, but not on insecure context http. For more details it check this https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts


Crash when using with cocoapods

Crashes on the following line
NSLocalizedStringFromTableInBundle(key, @"DateTools", [NSBundle bundleWithPath:[[[NSBundle mainBundle] resourcePath]<EMAIL_ADDRESS>nil)

The new cocoapods now uses swift modules and embedded frameworks, so DateTools.bundle is no longer at its old location, thus causing a crash due to nil being returned.

Got the same problem too.

My quick fix is:

Find the DateTools.bundle file at the Pods/DateTools/DateTools/DateTools.bundle;
Drag the DateTools.bundle file into anywhere at the xcode project, import using relative file path.

+1 for this issue and @summerblue 's work around.

Another workaround is the following, though I probably like @summerblue's workaround better
        if target.name == 'Pods-DateTools'
            target.build_configurations.each do |config|
                config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
                config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << 'DateToolsLocalizedStrings(key)=key'
            end
        end

:+1: for this

@MatthewYork Can these bundle fixes be merged in? I'm going to have to remove DateTools before my next app build if I can't get it to compile.

Should be fixed now. https://github.com/MatthewYork/DateTools/pull/60#issuecomment-94286205

Fixed as of #84

Seeing this again now with Cocoapods 1.0; have not identified a workaround yet.

Seeing this also with CocoaPods 1.01. Anyone found a solution?

Any solutions so far? Using CocoaPods 1.01

NSLocalizedStringFromTableInBundle(key, @"DateTools", [NSBundle bundleWithPath:[[[NSBundle bundleForClass:[DTError class]] resourcePath]<EMAIL_ADDRESS>nil)
should do the trick, but still can not find the bundle, I checked the folder structure everything seems fine, confused actually.


Include cellrank in the scanpy ecosystem

Including links to cellrank, interactive-plotting and scachepy in the scanpy docs under ecosystem would be easy and effective advertisement I believe. The corresponding scanpy issue is here: https://github.com/theislab/scanpy/issues/1282

Do you really want to include scachepy and interactive_plotting? I'd foregone at least one of them (namely ipl) or both,
since I don't think any of them are stable. I have plans to improve scachepy (I'd welcome if you have any requests or new conceptual ideas), since it will be faster than changing ipl (summer project I guess). There I need to think about its philosophy/intended usage.
If you want to include both of them, I will first package them and add at least a few tests.

okay, let's just make a PR to include cellrank then for now and the others will follow once you are happy with them.

Thanks for opening the PR!


bump version of vinyl-fs

current version specified has a security vulnerability in a dependency, upgrading version should resolve the issue.

Please use the search. This is a breaking change.


Port example to use create-react-app

Hello!
I guess there's no need to explain now what create-react-app is and why it's nice to have examples using it. Hope it'll help newcomers like me to get started with react-art a bit quicker.

I noticed that this change will break gh-pages website build step. I'd like to fix that. Is it better done in another PR or this one?

Issue moved to reactjs/core-notes #41 via ZenHub

Issue moved to reactjs/core-notes #42 via ZenHub


Fixed  template syntax

Fixed to double curly brackets.

Thank you for fixing this, merged into master

Thank you for merging!


Project Manager - it does not trim entered path

Win8.1 / Godot v2.1 stable
in the Project Manager. If you put import path with 'space' character at the end, it does not import the path. It could be trimmed, right?
reproduce:
Try to import project from path like: "d:\DevGodot\Herbi-master "  (notice the space at the end)
effect:
nothing happens.

I'm using 2.2 alpha with current master head.
Create button is disabled and I can see error message if add a space at the end of project path.

ok then, but why just not trim it internally?

I can make a directory with space like "folder_name    "
I think it's more like user fault, it's not good just trimming it.

you can do it only on Linux. On Windows names are trimmed by default.


TestsListener link from Testing page is broken.

The testing page mentions TestsListener here.
But that link is broken: http://www.scala-sbt.org/1.x/api/sbt/TestsListener.html
I can see it's available in the 1.0.1 docs, but gone in 1.0.2.

nice, still broken


Set the csi-node-driver DaemonSet PriorityClass to system-node-critical

Description

It should be set the csi-node-driver DaemonSet PriorityClass to system-node-critical.
When I updated the tigera-oprator Helm chart (quay.io/tigera/operator:v1.27.1 -> v1.28.0), some csi-node-driver pods were stack in pending because they couldn't be scheduled to a node. I'd like to set the PriorityClass to system-node-critical, like the calico-node DaemonSet.
ref. https://github.com/tigera/operator/pull/1473
For PR author

[x] Tests for change.
[ ] ~If changing pkg/apis/, run make gen-files~
[ ] ~If changing versions, run make gen-versions~

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Josh-Tigera Thank you for the review! Could you merge this PR?

/sem-approve

Does this set the PriorityClass by default? Our clusters are running v1.29.1 of the tigera operator, and the csi-node-driver containers still do not have the PriorityClass set.

@jjchambl yes it should be set, the changes from this PR are in the v1.29.1 release. Are you perhaps using RKE(2) or MKE or have a mutating webhook that might be removing the PriorityClass?
I think I've seen odd behavior with those installations because they have a mutating webhook that modifies resources when they're created or updated to remove some permissions or tolerations because the service account creating them doesn't have a binding to a certain cluster role.

@tmjd thanks for the reply. We're running in EKS, but it's possible there's a mutating webhook somewhere that I'm missing. Will look into that.

On second thought, the calico-node Daemonset has and applies the priorityClassName just fine; the field is missing from the csi-node-driver Daemonset entirely. I don't think it would make sense for a mutating webhook to remove one of those and not the other.

I agree @jjchambl, I wouldn't expect that to happen. The only way I'd guess it would happen was if there was an install which included priorityClass for calico-node but not csi-node-driver, then the webhook installed, and then upgraded operator to one that added priorityClass to csi-node-driver. Still probably possible but very unlikely.
I'm not really sure how this would happen.
I just tried out in a cluster the v1.29.1 image and it had the priorityClassName, I even disabled operator, removed it from the daemonset, and then re-enabled the operator and the priorityClassName was added back.
EKS should not matter because the csi-node-driver always has the priorityClassName added.


[#112135729] Combine pipeline scripts

WARNING: Only the last four commits are of interest. This shouldn't be merged before #74. Please feel free to comment on the approach in the meantime though.
What
Combine the pipeline config scripts for Deployer, MicroBOSH and CloudFoundry.
How to review
Run the steps described in the README against an existing Bootstrap Concourse and Deployer Concourse. Observe no changes to the pipeline configurations.
Who can review
Not @dcarley

Re-opened with an actual description this time.

Tested successfully.

Note: We've agreed that #73 will be merged before this one, so please do not merge until #73 has been merged.

This needs rebasing now that #73 has been merged.

LGTM :+1:


Current build fails

Our current build fails, because of two issues:

one because of micrometer + spring-boot (that I have already fixed and will explain in the PR)
because we need the latest spring-cloud-config.

The second one is something I can't do anything about, unfortunately :(
We need the latest 4.0.0-SNAPSHOT of spring-cloud-config and I know this because I build it locally and run a test that fails in our current build and it passes. May be more verbose is this:

delete 4.0.0-SNAPSHOT of spring-cloud-config from my maven repo, refresh our project, run a failing test - it fails.
delete 4.0.0-SNAPSHOT of spring-cloud-config from my maven repo, build spring-cloud-config on my machine so that it ends up in my maven local repo, run the failing test - it passes.

I hope I make sense here.
@ryanjbaxter can you may be try to trigger a build of that project? Unless this is already known by you folks, of course.

We have a number of issues with the main builds of Spring Cloud due to some Spring Boot issues.
This is one I am working with Boot on
https://github.com/spring-projects/spring-boot/issues/32676#event-7572194478
I am waiting for the Boot build to finish to try the latest snapshot.
This one is blocking spring cloud config
https://github.com/spring-projects/spring-vault/pull/728

Excellent! I was losing my mind today. thank you soo much!
P.S. The micrometer dependency is really easy to fix in our case, but I assume spring-boot will go on a diff route

Ryan that vault issue seems to be closed, safe to trigger a spring-cloud-build build?

Everything should build now.  We found another problem with Spring Cloud Config which appears to be a problem in Spring Framework.  We commented out the tests so we could get a snapshot build of Config.  It looks like K8S is green now as well.
https://github.com/spring-projects/spring-framework/issues/29333


Can't parse type parameters containing parenthesized items

let raw = r#"
    type A = Box<(Fn(D::Error) -> E) + 'static + Send + Sync>;
"#;

let actual = parse_item(raw).unwrap(); // Fails

Found in tests/rust/src/test/ui/token/bounds-obj-parens.rs which should pass without the trailing FAIL

Fixed in 0a169d428305315bf14b033dbb15295432896b02.


Merging Slices with WithAppendSlice/WithSliceDeepCopy need extra features like de-duplication.

Hi all, we are heavily depends on terraform and we using provider named cloudposse/terraform-provider-utils their code based on mergo to provide merge capabilities of complex structures. We noticed a issue while structures which can have slices and as for us this behavior far from correct ( maybe this is a feature :) ).
Use case:
We have 2 inputs as yaml which are decoded into terraform structures.

NOTE: in some cases it may happen that we can have dups inside arrays

Config A
list:
  - value-1
  - value-2
  - value-3

Config B
list:
  - value-1
  - value-5
  - value-4

Results if we using WithAppendSlice
list:
  - value-1
  - value-2
  - value-3
  - value-1
  - value-5
  - value-4

Results if we using WithSliceDeepCopy
list:
  - value-1
  - value-2
  - value-3

Result with WithAppendSlice  and WithSliceDeduplication
list:
  - value-1
  - value-2
  - value-3
  - value-5
  - value-4

NOTE: order preserved, sort not used to ensure merged lists preserving the same or close to original order.

WithSliceDeepCopy from my understanding supposed to copy items from  both slices and merge them together, but this not happening and only Config A is seems copied.  I'm not fully sure is that a goal for WithSliceDeepCopy or not?
In a same time WithAppendSlice  almost meet our expectations, but as you can see above from result for it, we have duplicates, because both Configs include value-1.
It can be easily fixed by de-duplication of final slice, but current way of WithAppendSlice  probably desired result for some cases.
Before to do any PRs i would like to ask if we can add to version 1 of mergo a modifier like WithSliceDeduplication which then can call extra logic within WithAppendSlice scope ?
All we need add extra helper function and condition to enable this function to end of this block: https://github.com/darccio/mergo/blob/master/merge.go#L171-L175
I did locally such functionality and its behavior looks good, plus using options approach we can preserve existing behavior, while with WithSliceDeduplication we can extend it without breaking anyones experience who already using `mergo.

I can see this is PR and feature for v2 in darccio/mergo/pull/196 , but last message from 2023 and no movements about v2 since then, but deduplication feature is the one of very important part we missing with mergo


feat(export): Allow Exporting Complete Functions

I'm looking to dynamically add config schema to the autocomplete.
I want to be able to know when a user has typed a "parent" as defined by the sourceContext method so that I can then make an api call before populating the schema table with the columns returned from the api.
I should be able to do that with easy access to the methods that are written in complete.ts

I recommend you duplicate the logic required for this instead—it's not a lot, and I dislike exporting internals like this since it requires me to document them and lock them down forever.

@marijnh that works for me. I noticed that after upgrading to versions 0.19.x that the "schema" mapping no longer seems to work. It looks like the '.' is no longer being identified (resolveInner returns it as a Script) so that the parent is not matched. Is that something you see as well?


Simplified overview grafic

Please recheck text or provide the source for correction (1st [p]arty")

Will fix it tomorrow - let minute editing error


Amazon Linux 2023 proof-of-concept (Take 2)

Makefile has a converter that generates al2023 configs from existing al2 ones
Very minimal changes to other files to ensure al2023 works and does not get in the way of AL2 ongoing development.
Based on earlier work by @cartermckinnon in:
https://github.com/awslabs/amazon-eks-ami/pull/1212

@cartermckinnon if this PR is good enough, let's merge and iterate, that way i can throw a few CI jobs at the generated image to see how it fares.

@cartermckinnon thanks! applied the suggestion

I think this is fine to get us going. Some things I'd like to see in followup PR's:

A user guide entry on distro support (AL2023 being called out as experimental/in-progress).
A make var to select the distro, usage like make 1.27 distro=al2023
Static variable file for al2023 instead of modifying the one for al2 (once the wrinkles are ironed out).

I'm not sure what the right approach will be for the template file. We need to eventually move to the HCL template format, and AL2023 is an opportunity to do that.


TLS 1.3: Remove unused duplicate note 5

... which was added in https://github.com/Fyrd/caniuse/commit/1b5b664a17f65a6a8b2fc7d332cec968d126339d#diff-8b5dcbab36c24ff5f70045890ea58e253368736869231ef182373a73cb7a8ad4, not sure why 0:-)

Took care of this one manually, thanks!


Calculate the system overlay style based on the AppBar background color

As documented, the system overlay currently defaults to light for dark themes and dark for light themes. However, the app bar can also be dark in a light theme, which would require a light overlay. This patch reverts the old behavior (before #71184) if backwardsCompatibility is set to true (using ThemeData.primaryColorBrightness) and uses  ThemeData.estimateBrightnessForColor to calculate a default overlay style if backwardsCompatibility is set to false.
Making this change revealed that some tests incorrectly expected that the default theme requires a dark overlay, but as can be seen here, the default blue is already considered dark and requires a light overlay.
Another test used ThemeData.primaryColor, but the new implementation uses ThemeData.colorScheme.primaryColor instead. I changed that one to specify ThemeData.primarySwatch, so that colorScheme.primaryColor is set.
Fixes #72562.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@HansMuller may I ask you for a review?

@miDeb - I'm afraid I missed this when when you commented a few weeks ago will take a look shortly.

@HansMuller friendly ping - could you take a look if you have time?

@miDeb Can you sync with the current master, merge, and push?


ProPhoto primaries need greater precision?

The wiki shows more precise primaries for ProPhoto: https://en.wikipedia.org/wiki/ProPhoto_RGB_color_space#Encoding_primaries. Packages like Colour Science, use what we are using (4 decimal places). The question is what is actually in the spec. I need to check this. We may need to use the ones in the wiki. The change will have  a near negligible impact, but would make things more accurate if they are required.

I have no clue why CSS seems to be referencing the wiki primaries. The wiki even references documentation that does not use those primaries..., see here: https://www.color.org/ROMMRGB.pdf. Maybe there is a more official spec behind a paywall, but colour science is usually pretty good about referencing from the official source, so the fact they don't use the greater precision one found on the wiki would seem it is not the official one.


newer versions of libbpf 0.8.0 or libxdp

It appears while adding txgen latency support, the packet data offset with pktmbuf_mtod() is not pointing to the start of packet data as expected. It appears libbpf 0.6.0 behaves correctly and we need to move to libxdp to verify the problem exists.

Can we close this issue?

Yes- We can close after the testing and validation done with https://github.com/CloudNativeDataPlane/cndp/pull/189


Patch v8.5.0

Added Support for Buttons and switched poketwo prefix to mentioning Poketwo.

Fixes #259


merging latest changes from master to branch-1.6

Current coverage is 82.30%

Merging #401 into branch-1.6 will not affect coverage as of 6da4fe4

@@            branch-1.6   #401   diff @@
=========================================
  Files               45     45
  Stmts             4645   4645
  Branches           416    416
  Methods
=========================================
  Hit               3823   3823
  Partial            191    191
  Missed             631    631

Review entire Coverage Diff as of 6da4fe4

Powered by Codecov. Updated on successful CI builds.


Suggestion - Improved DX for fieldset

At the moment, if I want markup a Section, Flex or Box as a fieldset element without inheriting user agent fieldset styles I need three components:
<RadixThemes.Section asChild>
  <RadixThemes.Reset>
    <fieldset>

Would it be possible to support one of the following for the same effect? It would reduce a lot of noise in some pages without having to create my own component for handling this.
<RadixThemes.Section as="fieldset">

<RadixThemes.Section asChild>
    <fieldset>  {/*auto reset by Section, Box or Flex */}

This is just something minor I thought of during development of a large form page. I have no problem with you closing if you're not sure it's valuable  :)

It's not a canonical example of how we'd expect Section to be used (nothing wrong with that though), nor inline with how we think about resets, so we wouldn't plan to work on it.
Sounds like you might want to just abstract it into your own fieldset component?
We had some plans for providing our own fieldset element in this release, but had to back out for now because of a lot of unexpected complexity in this area. Good to see though that this seems to be a somewhat common need.

ok thanks, yes a Fieldset component is probably going to be a better end result, good to know it's being considered

What does your UI look like in this case?

I've made an example here.
This is pretty much like our UI looks like, though I've replaced the text with an explanation of the markup.


Manage labels via gitlabform

It would be nice to be able to manage labels within gitlabform, similar to how members can be managed.
This would add a new labels as well as enforce_group_labels and enforce_project_labels to the config.
Relevant API docs:

https://docs.gitlab.com/ee/api/labels.html
https://docs.gitlab.com/ee/api/group_labels.html

Hi @FlorianLudwig ! Thanks for the proposal. We are open to PRs with this feature. :)

Hi @FlorianLudwig ! Thanks for the proposal. We are open to PRs with this feature. :)

https://python-gitlab.readthedocs.io/en/stable/gl_objects/labels.html

Implemented by #751 and available from release v3.11.0


Incomplete Issuer Flow development

As the documentation says on: https://github.com/bcgov/issuer-kit/blob/main/docs/issuer-kit.md On completion, display a link to a demo site so the user can try their new verifiable credential. The test issuer has a link to CBS Audio that seems to be non existent. Thoughts? Exists some URL to test the credential?

@sebagroh we don't currently have a hosted service that can be used to verify the issued credential. We should probably remove the link to CSB Audio as it was a specific use-case.
You could potentially use https://github.com/bcgov/vc-authn-oidc (I would suggest using the 2.0-development branch as the 1.0 release is at end of support) with an appropriately-configured proof request.

Closing, please feel free to reopen if necessary


[MAISTRA-503] Fix the references to webHookName -> webHookConfigName

WebhooksConfigs were being created with the wrong name (the one in the
webHookName field), which is static. We should be referencing the
WebHookConfigName, which has a different name for each control plane.
This error was preventing the sidecar being attached to pods.

Hmm, I fixed something like this a while ago. Let me find the PR.

Ah, my PR was never was never merged: https://github.com/Maistra/istio/pull/9

@luksa :( It seems it got lost. No Jira for it, duplicated work :( :(

@knrc any thoughts here?


Incorrect format loading

Shouldn't line 227 below be config.update_format("out", "bytes")?
https://github.com/Ciphey/Ciphey/blob/a26abe0da2794efea00694fc32cd1554374f4e71/ciphey/ciphey.py#L222-L227
https://github.com/Ciphey/Ciphey/blob/a26abe0da2794efea00694fc32cd1554374f4e71/ciphey/iface/_config.py#L67

Yes, you are absolutely right!
@all-contributors please add @brignano for bug

sigh

Closed by #270


does this work when you don't have a cloudflare enterprise account?

This is a great idea and use case for a plugin, thank you for writing it!
I work on the Netlify tech support team and was wondering if it works for non-enterprise Cloudflare accounts?    I'm not a customer, but keying off this line:

The Cloudflare UI and API both prohibit setting Browser Cache TTL to 0 for non-Enterprise domains.

in their docs, I had assumed it was impossible to affect the caching below some timeout (>0 seconds), but maybe "single purge" is handled differently than "setting it to be permanently off"?  Do you have any insight as to whether this can be used at all Cloudflare account levels?
cc @bhavana-netlify @ameerbadri @rsedighi who brought this awesome work to my attention!
PS:  our team are working on a true "post deploy" hook for plugins to use which will be a better trigger for this plugin to use soon :)

Hi @fool ! Thanks for the kind words! :) We've already met on the community forum, nice to see you here too! :)
Yes, it works for all accounts. This plugin has the effect of pushing the 'purge cache' button that's available inside Cloudflare for all accounts. It doesn't affect the TTL settings for the account.
I agree, the post deploy would be better!

Yup - I really like working with you and not just because you're nice and paying us, but also because it's always fun to see another "Chris M" :D
Thanks for letting me know about those details!  I think it would make sense for our  to link your plugin from this post - it doesn't change the impact to analytics or A/B testing or certificates, but it at least does "something" around making deploys more atomic which is the most "table stakes" of those features that everyone will use.
https://community.netlify.com/t/support-guide-why-isn-t-my-ssl-certificate-provisioning-automatically-with-cloudflare-netlify-are-there-other-problems-with-using-cloudflare-in-front-of-netlify/138
Any concerns or countersuggestions before I edit that post to mention your plugin?

I definitely think it's worth mentioning. It helps to make deploys atomic - we publish several times a day, and waiting 2 hours TTL for CF to invalidate the cache is way too long.
I think there are probably people out their with good business reasons for keeping Cloudflare in their stack, so hopefully this can be a step closer to making Netlify & Cloudflare sing together.
On a separate topic, we noticed degradation in performance using Netlify's CDN vs Cloudflare (with Argo). I'd be happy to set up a more detailed performance test if it will help iron out any issues.

wow, I had no idea the default TTL was 2 hours (I think that's what you're saying?).  We set cache-control headers on our content that specify no caching (or rather, cache-but-check-on-reload), so that's a pretty big gap!
Totally appreciate the effort!
Re: performance, I think you have access to our helpdesk<EMAIL_ADDRESS>- drop the team a line there and say "hey fool said over in this github issue to escalate to him" and we'll dig in!


Rebase release/v1.32.x

Issue #, if available:
Description of changes:
Rebasing with main
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release/v1.32.x@24bfb35). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.32.x     #656   +/-   ##
==================================================
  Coverage                   ?   50.73%
  Complexity                 ?      264
==================================================
  Files                      ?       39
  Lines                      ?     1301
  Branches                   ?      141
==================================================
  Hits                       ?      660
  Misses                     ?      609
  Partials                   ?       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This is an attempt to make recent commits in main branch are present in release branch right?

This is an attempt to make recent commits in main branch are present in release branch right?

Should we wait till the main build failures are fixed.


update instruction for control plane

data plane will be in a separate PR as it needs more testing

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: linsun
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513, linsun
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Simplex cUSD integration in Valora

Description
Add Simplex to allow users to buy cUSD.
Simplex does not allow for an address to be passed as a parameter, so there is a banner with a user's address to copy within the Simplex webview
Update Cash In flow to go directly to the provider selection, as there is only one cUSD provider (Simplex) and one CELO provider (Moonpay) for now, so it is not necessary for users to enter an amount so we can display fees to them.
This UI will soon be replaced with the new Cash In / Out flow but wanted to land a minimal Simplex integration so we could allow our users to buy cUSD and to start testing Simplex as soon as possible.

Tested
The integration team from Simplex tested a mainnet APK with the production integration to confirm that the purchase of cUSD works as expected
On an emulator to ensure flow displays as expected
Related issues

Part of #5424

Backwards compatibility
Yes

Hi @annakaz , @jeanregisser  Started verifying task using v1.4.0 (28) and Android play store (internal build) v1.4.0<PHONE_NUMBER>) and found below new issue:

https://github.com/celo-org/celo-monorepo/issues/5743.

Also, in Android [Randomly] Something went wrong error message screen is shown after tapping on Simplex option from Add and Withdraw option.

Not getting verification code from mail id while adding cUSD from Simplex option.
Note:
Checked spam mail as well but we are not getting mails there as well.
Hence we are blocked to performed testing on this task can you please do the needful.


Chat API says message is too long in Codespaces

Version: 1.91.0-insider
Commit: 0da59bdde2339d6ba632524dc8f3fb6f4b8a2bcb
Date: 2024-06-14T10:11:28.580Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
Steps to Reproduce:

Create Codespace from https://github.com/burkeholland/chinook-pg-test
Run ./install.sh to create and populate the chinook database
Set the connection string for the @pg chat participant with @pg /conn postgres://postgres:postgres@localhost/chinook
Ask the participant to show tables @pg /show - this will work - confirms connection string is set correctly.
Ask the participant to list all artists @pg list all artists.

The participant will return the error message: "I can't find the schema for the database. Please check the connection string with /conn".
However, this doesn't appear to be the actual error. @brianrandell was able to narrow this down to the following error thrown in the @pg extension...

Note that this works locally when run as a dev container.

Thanks for opening this issue. This message is probably coming from the Copilot API endpoint, and it should not have an effect if you trigger the API locally or from a codespace. Are you sure the exact same request is sent? You could look at the logs to compare.
@jrieken also might have ideas.

This is our message https://github.com/microsoft/vscode-copilot/blob/20820198e92136a74846aca82bde0c7d8f216367/src/extension/prompts/node/base/promptRenderer.ts#L53
fyi @joyceerhl

Tho, it is odd that this only happens in codespaces. There are known issues with codespaces getting a bad auth token, maybe that's the actual issue and the error message is a misleading consequence

@isidorn oddly, I'm not seeing anything in the logs related to @pg. If I do a regular chat interaction, I do see the logs. But the @pg doesn't log anything anywhere as far as I can tell. Will speak to @robconery today about this.

For what it's worth, myself and a few others are seeing the same error from the latest samples: https://github.com/microsoft/vscode-extension-samples/issues/1046
I was able to repro it without using Codespaces, but just building the sample and running it locally. The same one was also working before I updated my Insiders to 1.91.0-insider.

Doesn't this just mean that the pg participant sent the chat model a bad request?

There are known issues with codespaces getting a bad auth token, maybe that's the actual issue and the error message is a misleading consequence

I hit this when I try to debug an extension inside a Codespace. For example:

Open chat-sample in codespace
Debug it -> new tab gets opened with my extension running
Chat view wants to login but it can not 🐛

Should I open a separate issue for this?
Or this might be what this issue is all about. @brianrandell is the scenario you are trying to achieve is develop and debug a local GH extension in a Codespace? Thanks!


Microsoft.dotnetRuntime.5-arm64 version <IP_ADDRESS>215

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Why is this separate from the other .NET manifests?

Because like VC++, dot net runtime dependencies can be installed side by side.


About query

Java Bean
@Data
@Document
public class Person {
  @Id
  private String

  @TextIndexed
  private String firstName;

  @TextIndexed
  private String lastName;

  @TagIndexed
  private String email;

 @Indexed
  private List<Phone> phoneList;
}

@Data
@Document
public class Phone {

    @Id
    private String phoneid;

    @Searchable
    private String phonename;

    @Indexed
    private BigDecimal price;

    @Indexed
    private String color;

    @Indexed
    private Integer test;

    @Indexed(sortable = true)
    private LocalDate date;
}

Question 1
Iterable<Person > findByPhoneList_color(String color);
or
@Query("@color:$color")
Iterable<Person > getColor(String color);
I can't get any results.
What should I do to get the result I want through color?

Question 2
Date is a localdate type.But when it is cached in redis, it is of long type.
When I query, the query log displays ‘yyyy-MM-dd’.
How can I get the corresponding date?
What should I do to filter data through date?

When I use
@Query("@date:$date")
Iterable<Phone> selectByDate(@Param("date")LocalDate now);
parameters: [2022-07-05]
queryOrParts: 0
query: @date:2022-07-05

When I code
Iterable<Phone> findByDate(Long date);
The error message :  Could not create query for public abstract java.lang.Iterable
com.redis.om.documents.repositories.PhoneRepository.findByDate(java.lang.Long)!
Reason: Failed to instantiate [com.redis.om.spring.repository.query.RediSearchQuery]:
Constructor threw exception; nested exception is java.lang.IndexOutOfBoundsException:
Index 1 out of bounds for length 1;
nested exception is org.springframework.beans.BeanInstantiationException:
Failed to instantiate [com.redis.om.spring.repository.query.RediSearchQuery]:
Constructor threw exception; nested exception is java.lang.IndexOutOfBoundsException:
Index 1 out of bounds for length 1

@BrightFutureSugar sorry just getting to this... any possibility you can send a reproducer project? But I would test again with the latest SNAPSHOT before doing so, the issue might be resolved. If it still fails, please open a new issue with the reproducer. Thanks!
Above, the only thing I see that's incorrect is that the child class is also annotated with @Document, which implies it is its own collection, which does not work with Redis, the child class (in the List/Set) is meant to be an embedded part of the document.


Discussion of new database schema

Description
As a developer, I want to meet with the team to discuss new database schema.
Acceptance criteria

[ ] meeting with @Afollet scheduled
[ ] meeting with the team

Moving to the next sprint due to focus on the release for the current one

Need to have another meeting with the team

Meeting held.


cargo runs in a wrong folder (in a parent directory where it should not run)

Problem

cargo build does not run in the current working directory but in the parent directory

Expected Behaviour

I would expect that cargo runs exactly in that folder where I started it
I would also expect that cargo runs in the folder that I specify via: --manifest-path=the/final/folder/Cargo.toml

Steps

install cargo-generate: cargo install cargo-generate
lets start in clean folder: mkdir /tmp/demo && cd /tmp/demo
clone a template: git clone https://github.com/rustwasm/wasm-pack-template.git
cd wasm-pack-template
process the template: cargo generate --silent --git . --name mytemplate
verify cargo misbehaviour: cd mytemplate && cargo build
also this does not work: cd /tmp && cargo build --release --manifest-path=/tmp/demo/wasm-pack-template/mytemplate/Cargo.toml

Note: the error message in 4. and 5. is:
error: failed to parse manifest at `/tmp/demo/wasm-pack-template/Cargo.toml`

Caused by:
  invalid character `{` in package name: `{{project-name}}`, the first character must be a Unicode XID start character (most letters or `_`)

So in the error message one can see that cargo uses /tmp/demo/wasm-pack-template/Cargo.toml and not the suppose to be used /tmp/demo/wasm-pack-template/mytemplate/Cargo.toml
Possible Solution(s)
the path traversal logic should not go up if a $PWD/Cargo.toml file is present, or should it?
Notes
When I move this mytemplate out of a folder that contains Cargo.toml it works all as expected, like:
mv /tmp/demo/wasm-pack-template/mytemplate /tmp/demo
cd /tmp/demo/mytemplate
cargo build

Output of cargo version: cargo 1.55.0 (32da73ab1 2021-08-23)

We do not have control over cargo-generate. If you want to report a bug with Cargo can you please explain the bug without the outside tool?

@Eh2406 I'm the maintainer of cargo-generate and as I tried to explain with the descriptions, this has nothing to do with cargo-generate.
cargo-generate works as desired and creates a project out of a template project.
The actual issue is that cargo as in cargo build seems to be too smart in finding the right folder where things should be executed. I suspect it has something to do with the workspace handling logic. Because in this case we have the situation of one cargo project is stored as subfolder in an other cargo project.
❯ tree
.
└── wasm-pack-template      <- the template is an invalid cargo project by definition
    ├── Cargo.toml                   <- this is the invalid file
    ├── LICENSE_APACHE
    ├── LICENSE_MIT
    ├── README.md
    ├── mytemplate                   <- this is the one and only real cargo project
    │   ├── Cargo.lock
    │   ├── Cargo.toml                <- this is the valid file
    │   ├── LICENSE_APACHE
    │   ├── LICENSE_MIT
    │   ├── README.md
    │   ├── src
    │   │   ├── lib.rs
    │   │   └── utils.rs
    │   └── tests
    │       └── web.rs
    ├── src
    │   ├── lib.rs
    │   └── utils.rs
    └── tests
        └── web.rs

So again I assume cargo scans the parent folders for Cargo.toml to figure out if the current folder is part of a workspace project and then it encounters the parent Cargo.toml that is invalid.

I found a good example to illustrate the misbehaviour without the use of cargo-generate, the following steps are illustrating it:

preparations:

mkdir /tmp/demo && cd /tmp/demo
cargo new --bin invalid_project
mv invalid_project/Cargo.toml invalid_project/Cargo.toml.orig
sed s/invalid_project/{{package_name}}/g invalid_project/Cargo.toml.orig > invalid_project/Cargo.toml

the first strange behaviour:

cargo new --bin invalid_project/valid_project
warning: compiling this new package may not work due to invalid workspace configuration

failed to parse manifest at `/tmp/demo/invalid_project/Cargo.toml`

Caused by:
  invalid character `{` in package name: `{{package_name}}`, the first character must be a Unicode XID start character (most letters or `_`)
     Created binary (application) `invalid_project/valid_project` package

final issue:

cd invalid_project/valid_project && cargo build
error: failed to parse manifest at `/tmp/demo/invalid_project/Cargo.toml`

Caused by:
  invalid character `{` in package name: `{{package_name}}`, the first character must be a Unicode XID start character (most letters or `_`)

Notes
as you can see in step 3. I enter the valid_project that is contained in the folder invalid_project then run cargo build.
But instead of building only the valid_project cargo tries to parse the parent folder (that is invalid_project) and stops with failing so.
I'll try to find the place in code where the smart logic is there (I just assume it's somewhere related to workspace project determination).

This looks to be expected behavior.  Cargo needs to walk through parent directories to find the workspace.  If it can't parse a Cargo.toml file, then cargo cannot know how to load the workspace.  If you want a standalone package/workspace that does not search through the parents, you can place an empty [workspace] table in the package's Cargo.toml file.  Otherwise, I think you may need to restructure the directory layout to avoid having broken Cargo.toml files in parent directories.

I agree and understand.
But I would argue if the parsing of the parent manifest has failed, then the current crate does definitely not belong to a workspace. Hence should be handled as a standalone crate.

Cargo needs to be able to parse a parent manifest to correctly configure a workspace. Imagine working in a workspace, and you make an error editing the root Cargo.toml, and try to build one of the member packages, and Cargo didn't alert you that the workspace was no longer working correctly.