Attachments not exporting in version 3.0.328 (latest version)

Hi Alexander,
I have noticed that the attachments are not exporting in the latest version. I am getting the same error message as was raised in issue #851.
[D][13:45:49]    No attachment to undo for 'Added 18368/Hess PO for MSrenewal 2018-19.pdf'.
[D][13:45:49]    Attachment Hess PO for MSrenewal 2018-19.pdf cannot be migrated because it was deleted.

@C-F-Palmer Could this possibly be related to https://github.com/solidify/jira-azuredevops-migrator/issues/851?

@C-F-Palmer Could this possibly be related to #851?

Hi Alexander, I believe it is the same issue as reported in #851.

OK!
Let's close this issue and continue discussion in #851


REFACTOR-#4631: Add mypy checks for modin.distributed

Signed-off-by: Rosdyana Kusuma<EMAIL_ADDRESS>
What do these changes do?

You should be able to amend your first commit with:

git rebase -i d5bd6376d5b7735c4c676e74bd73ef36edcdfdff~1
You should then get an editable list of actions for each commit. Choose "r" for reword for your first commit, then "p" for each of the other commits to keep them on top of the first one.

Save and exit the editable list of actions.
You should get an editor again asking you to reword your initial commit. Do so.

Resolve merge conflicts

@rosdyana it looks like you've added commit e90473655bdff4d082b378db4145c95ad92e5509 with the correct formatting, but your first commit still has the incorrect formatting. Your commits as they are will still fail the CI. Could you please try rewording your first commit?
Meanwhile, I'll respond to the open inline comments. Please ping this thread if I haven't responded within 24 hours from now.

@rosdyana just FYI, next time you want to accept someone's suggestion on a GitHub PR, I highly recommend using the "commit suggestion" if you want to accept one suggestion, or the "add suggestion to batch" button if you have multiple suggestions. That usually reduces the amount of work you have to do and makes it easier for everyone to track what's happening with the PR.

@rosdyana in order to pass the commit lint, you will have to amend your first commit so that it says something like, "FIX-#4631: Add mypy checks for modin.distributed."
You should be able to amend your first commit with:

git rebase -i d5bd6376d5b7735c4c676e74bd73ef36edcdfdff~1
You should then get an editable list of actions for each commit. Choose "r" for reword for your first commit, then "p" for each of the other commits to keep them on top of the first one.

Save and exit the editable list of actions.
You should get an editor again asking you to reword your initial commit. Do so.

Resolve merge conflicts

I tried to amend that commit, but it doesn't work, I have no idea. Do you mind if I re-create the PR?

@rosdyana what's the error that you got? Did you try to "reword" the first commit and "squash" or "pick" the other commits? Rebasing can be hard, but it's better for history keeping and easier for everyone involved with the PR if we can keep all the comment history in a single PR.

@rosdyana what's the error that you got? Did you try to "reword" the first commit and "squash" or "pick" the other commits? Rebasing can be hard, but it's better for history keeping and easier for everyone involved with the PR if we can keep all the comment history in a single PR.

Yes, I did "reword" for the first commit, and then choose "pick" for the other commits. Should I "squash" the other commits?

@rosdyana I'm going to remove the commit requirement in #4982. Please don't worry about the commit message or rebasing at all for now.

@rosdyana I left some more comments. Please respond here or in the comment threads if you have any questions or concerns. Also, please be sure to run mypy --config-file=mypy.ini modin/distributed/ locally from the modin root to check whether mypy is passing. If it fails and you can't fix the failures, just say so here and we'll try to come to a resolution.
Once again, there's no need to rebase or amend your first commit.

Hi @mvashishtha the mypy returns this error
modin/distributed/dataframe/pandas/partitions.py:168:5: error: Statement is unreachable  [unreachable]
Found 1 error in 1 file (checked 4 source files)

https://github.com/modin-project/modin/blob/88ef64c2ceeb921dd151906c31dba84517eddb21/modin/distributed/dataframe/pandas/partitions.py#L168
Should we ignore it? or we need to solve it?

@rosdyana I think we need some more mypy annotations before we can convince mypy that all those classes are not None-- right now I think it thinks that some of them are None, so the assertions will fail and we'll never reach the code below. Can you add  # type: ignore[unreachable] to the end of line 168 (the last assertion)?

@rosdyana @pyrito no need to rebase on master. I don't think the breaking changes are in the branch for this PR. @rosdyana you should be able to just push an empty commit to get testing working again:
git commit -sam "Empty commit to trigger CI." --no-verify --allow-empty && git push

Hey, @mvashishtha @pyrito let me know if I need to change anything else. Thanks!

@rosdyana please take a look at CI failure here: https://github.com/modin-project/modin/actions/runs/3289605374/jobs/5432602430

+1 @rosdyana thank you for your contribution. Please continue reach out on GitHub, slack, or discuss, if you would like to contribute more.


Calling ID2D1Factory.CreateGeometryGroup causes Access violation

Actual behavior
When I call ID2D1Factory.CreateGeometryGroup with a geometriesCount other than 0, I get the following access violation:
Exception thrown at 0x00007FF92F4C8F08 (d2d1.dll) in MyApp.exe: 0xC0000005: Access violation reading location 0x0000000802400011.

I suspect the problem has to do with the ID2D1Geometry[] geometries argument not being marshaled correctly. The geometries I pass to CreateGeometryGroup are all valid and can be used fine on their own.
Expected behavior
I expect it not to cause an access violation.
Repro steps
var Factory = PInvoke.D2D1CreateFactory ( ... );
var Geoms = new ID2D1Geometry[] { ... };
Factory.CreateGeometryGroup ( D2D1_FILL_MODE.D2D1_FILL_MODE_ALTERNATE, Geoms, (uint) Geoms.Length, out var D2DGeometry );

NativeMethods.txt content:

D2D1CreateFactory
ID2D1Factory
ID2D1RenderTarget
D2D1_RENDER_TARGET_PROPERTIES
D2D1_HWND_RENDER_TARGET_PROPERTIES
D2D_RECT_F
D2D1_ROUNDED_RECT
D2D1_ELLIPSE
D2D1_FILL_MODE
D2D_MATRIX_3X2_F
D2D1_STROKE_STYLE_PROPERTIES
ID2D1RectangleGeometry
CWPSTRUCT

NativeMethods.json content (if present):

{
  "$schema": "https://aka.ms/CsWin32.schema.json",
  "public": false,
  "allowMarshaling": true
}

Any of your own code that should be shared?

Context

CsWin32 version: 0.4.422-beta
Win32Metadata version (if explicitly set by project): 10.0.19041.202-preview
Target Framework: net5.0
LangVersion: n/a

When I replace the CsWin32 implementation of ID2D1Factory with my own, where I modified the signature of ID2D1Factory.CreateGeometryGroup with the following:
unsafe void CreateGeometryGroup ( D2D1_FILL_MODE fillMode, [MarshalAs ( UnmanagedType.CustomMarshaler, MarshalType = "InterfaceArrayMarshaler" )] ID2D1Geometry[] geometries, uint geometriesCount, out ID2D1GeometryGroup geometryGroup );

And the following implementation of InterfaceArrayMarshaler:
    class InterfaceArrayMarshaler : ICustomMarshaler
        {
        public static ICustomMarshaler GetInstance ( string pstrCookie ) => new InterfaceArrayMarshaler ();

        public void CleanUpManagedData ( object ManagedObj )
            {
            }

        public void CleanUpNativeData ( IntPtr pNativeData )
            {
            Marshal.FreeHGlobal ( pNativeData );
            }

        public unsafe int GetNativeDataSize ()
            {
            return sizeof ( IntPtr );
            }

        public unsafe IntPtr MarshalManagedToNative ( object managedObj )
            {
            var Source = (Array) managedObj;
            var ArrayPtr = Marshal.AllocHGlobal ( sizeof ( IntPtr ) * Source.Length );
            var pArray = (IntPtr*) ArrayPtr.ToPointer ();

            for ( int i = 0; i < Source.Length;i++  )
                pArray[i] = Marshal.GetIUnknownForObject ( Source.GetValue ( i ) );

            return ArrayPtr;
            }

        public object MarshalNativeToManaged ( IntPtr pNativeData )
            {
            throw new NotImplementedException ();
            }
        }

It works. Obviously this is nothing but a stop-gap solution but it confirmed my suspicion that the marshaling of ID2D1Geometry[] geometries is to blame.

Hi,
just like to confirm that this problem occurs in other places too, e.g. ID3D11DeviceContext:
Calling generated functions results in AccessViolation exception.
[PreserveSig()] void OMSetRenderTargets(uint NumViews, win32.Graphics.Direct3D11.ID3D11RenderTargetView[] ppRenderTargetViews, win32.Graphics.Direct3D11.ID3D11DepthStencilView pDepthStencilView);
[PreserveSig()] unsafe void IASetVertexBuffers(uint StartSlot, uint NumBuffers, win32.Graphics.Direct3D11.ID3D11Buffer[] ppVertexBuffers, [Optional] uint* pStrides, [Optional] uint* pOffsets);

Marshaling with just [MarshalAs(UnmanagedType.LPArray)] solves the problem.
The only solution for me now is to emit all of the generated sources into single file and manually add MarshalAs to interface-array arguments.

Thank you for the report and for finding the right [MarshalAs] attribute that we need to add.

The only solution for me now is to emit all of the generated sources into single file and manually add MarshalAs to interface-array arguments.

You shouldn't need to copy all generated sources into your own files. CsWin32 will happily work around individual types that you declare yourself, so you can pick and choose what to copy over.

You shouldn't need to copy all generated sources into your own files. CsWin32 will happily work around individual types that you declare yourself, so you can pick and choose what to copy over.

Didn't know that, thanks for the info. That information should probably be somewhere in the readme file.
Is that a feature of code generation mechanism or something that CsWin32 do?

@pziezio good idea. I documented it here: b1be7ba78a95d27c654def4adf7d7ed69227c8e5
It is not a general source generator feature. We have special code in CsWin32 to do it.

And the following implementation of InterfaceArrayMarshaler:
It works. Obviously this is nothing but a stop-gap solution but it confirmed my suspicion that the marshaling of ID2D1Geometry[] geometries is to blame.

We should also be able to pass null as the array parameter, InterfaceArrayMarshaler needs some checking to do that.
I think your implementation is almost equivalent to [MarshalAs(UnmanagedType.LPArray)] which does all of that.
E.g. ID3D11DeviceContext::OMSetRenderTargets requires passing nulls.

Agreed: we should just use LPArray's marshaler.


WIP: Implement dropzone and progressive JS enhancement.

Affected steps:

Grounds for appeal
Documents checklist

This is completely functional but more progressive enhancement is required to make it 'pretty'.
It includes JS to show/hide form elements and expand/collapse areas based on checkboxes or when clicking a link. Also JS to customise the Dropzone plugin.
Some rewording/markup changes to sync with prototype.

Let's see if we can get rid of the jQuery stickyjs. Otherwise looks great :+1:

@csutter yep! turned out we can use the GovUK sticky solution just fine. I've pushed the changes.


AtlasEngine: Block chars done right-er

Consolas 12pt
No ❌:

Yes ✅:

Closes #14098
Validation Steps Performed

TBD after vacation's over

before:

after:

I once again cannot profess to understand the math changes without scrutinizing them, but I will "go with it"

The DWRITE_OVERHANG_METRICS math is difficult to understand. I wrote it by picking random fonts and sizes and glyphs and painstakingly comparing my own calculations against what GetOverhangMetrics returns until it all matched up perfectly up to the last float digit. To be honest, I don't think there's any comment that can sufficiently explain that code - it simply is confusing, because it is confusing.
If some other code is difficult to understand let me know and I'll try to add some better comments!
BTW the _r.fontFaces matching is extremely bodgy and depends on the existence of the so called ActiveFontFace class (you can look it up internally). I asked the DWrite folks if we can depend on it, but I haven't heard back yet. Basically, my argument for depending on bodgy behavior is because the new-new AtlasEngine needs to hash font-face/glyph-index tuples and you can't do that if you can't hash font faces. Windows 11 22H1 now got a IDWriteFontFace5::Equals method, but as I put it: "you can't hash an equals() method".


Model Loading Fails

Model loading fails with custom layer using hdf5_format lib.
It works with keras.models.load_model or with version TF 2.5.x, but starts failing from TF 2.6+. See log for details.
Traceback (most recent call last):
  File "model_save.py", line 36, in <module>
    saved_model = hdf5_format.load_model_from_hdf5(
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/saving/hdf5_format.py", line 180, in load_model_from_hdf5
    model = model_config_lib.model_from_config(model_config,
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/saving/model_config.py", line 52, in model_from_config
    return deserialize(config, custom_objects=custom_objects)
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/layers/serialization.py", line 163, in deserialize
    return generic_utils.deserialize_keras_object(
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 674, in deserialize_keras_object
    deserialized_obj = cls.from_config(
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 667, in from_config
    input_tensors, output_tensors, created_layers = reconstruct_from_config(
  File "/opt/conda/envs/iris/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 1310, in reconstruct_from_config
    layer_output_tensors = layer._inbound_nodes[node_index].output_tensors
IndexError: list index out of range

Example standalone code:
from tensorflow import keras
import h5py
from tensorflow.python.keras.saving import hdf5_format

class CustomLayer(keras.layers.Layer):
    """combine multiple activations weighted by learnable variables"""
    def __init__(self, **kwargs):
        super().__init__(**kwargs)

    def get_config(self):
        return {}

    def build(self, input_shape):
        return

    def call(self, inputs):
        return inputs

path = 'test.h5'

x = keras.Input((5))
y = CustomLayer()(x)
model = keras.Model(x, y)
model.build(x)
model.save(path)

# this works ok
custom_objects = {'CustomLayer': CustomLayer}
model = keras.models.load_model(path, custom_objects=custom_objects)

# this fails
with h5py.File('test.h5', mode='r') as f:
    saved_model = hdf5_format.load_model_from_hdf5(
        f, custom_objects=custom_objects)

@gowthamkpr,
I was able to reproduce the issue on tensorflow v2.8, v2.9 and nightly. Kindly find the gist of it here.

@haifeng-jin The main reason I'm calling this is because I need to store some additional metadata along with the model in the h5 file. I find this API pretty neat until it broke. What should we do to store metadata in this case? A commonly used metadata is # of epochs for example. It's possible to store them in separate files, but it makes model storage less compact.

@k-w-w Any thoughts on this?

It's between 2.5.3 and 2.6.0. I haven't got time to narrow it down to a specific commit. But I guess we could do a binary search.

@rchao So 2.5.3 works but not 2.6.0. Must be some commit in between.

Thanks for the info. Yes, if you could perform a binary search on the commits it would greatly help us.


Implement list function

This is needed by remote snapshotters: once they report "already exists", containerd tries to find the snapshot via list. If it's not implemented, the "already exists" trick to prevent layer download doesn't work.
This is still missing a filtering function, but allows remote snapshotters to work.

One minor nit, otherwise LGTM

Thanks for reviewing! I've folded your suggestion in.
After this is in, I only need one more one-liner (#130) to upstream all the changes I need to build the snapshotter in https://github.com/microsoft/kata-containers/tree/wedsonaf/tardev/src/tardev-snapshotter.


Refactor process_interactions into the Mark base class, and provide bugfixes for new d3.

This PR moves the process_interactions function into Mark, in order to reduce code duplication. By calling Mark.process_interactions from __super__, this does mean that some branches are executed twice - once for the base class, and then overridden in the child, but I think this is acceptable. Most of this overriding is caused by the child class hooking into the click event, which could be removed by using a method overload instead.
I introduced a small helper function in Mark which I didn't re-use it in the other mark classes, to test for value !== null && value !== undefined. Having spoken with @maartenbreddels, a longer term solution would be to use lodash, but I thought that beyond the scope of this PR.
As well as refactoring this code, there are also some bugfixes which prevented testing along the way. Although it's bad practice to mix goals in a PR, my opinion was that they were small changes and I'm pretty sure that they're broken in master. As part of this, I've re-used the runtime resolution of d3.event with d3.getEvent. I'm under the impression that webpack is causing this bug, but I'm not proficient enough with webpack to really know how to solve it.

I'm  under the impression that webpack is causing this bug, but I'm not  proficient enough with webpack to really know how to solve it.

Indeed the problem of d3.event  resolution is due to webpack, and the getEvent workaround is the recommended way to solve it. I'm not aware of any other fix.
I'll have a look in detail at your PR on Monday

@agoose77 thanks for tackling this, we've been meaning to do it for a long time (cf issue #144).
process_interactions could also call separate functions in Mark.js (process_click, process_hover, process_legend_hover, process_legend_click ...), that way marks would only have to override the individual functions (and most, as you pointed out, would only touch process_click).
Otherwise I'm good to merge this, it really cleans the code up!

Hi @rmenegaux,
I've taken care of the changes as requested. Let me know what you think, and thanks for the feedback!

Awesome, thanks!


examples/v2/cloud_functions does not explain how the files under 'function' get deployed

In both the jinja2 and python folders the cloud-functions are referenced as gs://cloud-function-sample/function.zip. This sounds like one you need to zip whatever is in the functions dir (with or without the directory) and use gsutil to upload it.
It would be nice to change the example to have the cloud-bucket uploading step as part of the deployment manager script.

Hi Stefan,
DM doesn't execute as a script, so we actually don't have a method for creating zip files and uploading them to GCS. I've clarified this in our functions sample README. Let me know if that's not clear enough though and we can rehash it in this thread.

The function code now is deployed as part of the deployment

Thanks a lot. This is helpful.


Support IPv6 prefix already configured on node

Adjust bpf/init.sh to support running cilium-agent -n PREFIX where PREFIX is a /96 with the matching /64 already configured on the system.
Reported by Jon D on Slack

#969

Should the issue still exist after the PR, lets reopen then.


Misspelled variable name

This one's really minor, but I figured there's no reason to not report it. The word "parameters" is frequently misspelled as "paramaters" in a number of identifiers. Some quick grepping tells me this is found in internal/api/api.go, internal/events/trigger_event.go, internal/events/retrigger_event.go and cmd/events.go.

That's my bad, but will get in a PR shortly along with some other fixes.
Thanks for the flag!

Followup, this has a fix merged but isn't in a release just yet. I'll make sure that I followup once we cut a release.


Enable suppression of PSAvoidAssignmentToAutomaticVariable for specific variable or parameter

PR Summary
Enables suppression for specific variable/parameter with rule PSAvoidAssignmentToAutomaticVariable.
Fix #1589
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
[x] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Intentionally skipped it because suppression was only tested in a general test and not per rule.
Can try to add some later today if you want.

Unless it didn't show up - ready for review again 🙂


Add multiple network interfaces to VM

Create all previously defined network interfaces instead of creating only the first one and then starting the vm.

@Alexandero89  thanks
For your submission we will test and merge here soon

Merged, @chrisabruce  can you push this to crates?


All indexer runs failing on Github Actions only

Which area(s) are affected? (leave empty if unsure)
No response
To Reproduce
Github actions are all failing with:
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /home/runner/work/oso/oso/indexer/src/cli.ts
      at new NodeError (node:internal/errors:405:5)
      at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
      at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
      at defaultLoad (node:internal/modules/esm/load:101:20)
      at nextLoad (node:internal/modules/esm/hooks:864:28)
      at load (/home/runner/work/oso/oso/node_modules/.pnpm/ts-node@10.9.1_@types+node@20.6.3_typescript@5.2.2/node_modules/ts-node/dist/child/child-loader.js:19:122)
      at nextLoad (node:internal/modules/esm/hooks:864:28)
      at Hooks.load (node:internal/modules/esm/hooks:447:26)
      at MessagePort.handleMessage (node:internal/modules/esm/worker:196:24)
      at [nodejs.internal.kHybridDispatch] (node:internal/event_target:786:20) {
    code: 'ERR_UNKNOWN_FILE_EXTENSION'
  }

Describe the Bug
indexer isn't functioning
Expected Behavior
indexer should execute ts files

Fixed. This ended up taking several hours. Very slow to debug, but it's all clear now.


added input

Hello:
I have created some change that in principle works.
I have deleted the node.active state, because in principle, to activate the node from an event, it would not be necessary.
I have passed the function of runinterval () to takesnap () and I have deleted the interval part, of course.
I think that we just need to remove the activate button in the snapshot.html file.
a greeting

Any chance of this ever landing?


Allow supporting tabular Min and Max delegation for date fields for data sources that support it

Today, delegation of the tabular forms of Min and Max for dates is not enabled, even though several data sources (such as SQL and Dataverse) support it.
Add the necessary delegation infrastructure.

✅ No public API change.


Recruit System - FULLY COMPLETED

Uses it's own file separate from enemy battler.

LGTM, thanks!

It was fun doing it, makes me better at understanding how Kristal works.


Support the head parameter if pbc transport is used. [JIRA: CLIENTS-1039]

Rationale: If the key management is out sourced to other systems and huge deletes should be performed there is no need for any data to be transfered. The implementation of this parameter would greatly improve this sort of task by reducing used resources and a noticeable speed up - depending on the data size.
By the way, why is this parameter only available for the pbc api ?
Beside this implementation suggestion, I would generally love to see a much lighter interface for operations which depends only on the key. Specifically I talk about something like:
bucket.delete(key)
bucket.exists(key)
and would just return boolean as no other informations are needed.

Would it not be to hard, if I ask for the reason - why this issue was closed silently without any comment !?

@tobixx - I don't know the backstory for this issue, but I've scheduled #502 to be in 2.7.0. Thanks!

Thanks!

Fixed, or closed via GitHub issues.
[posted via JIRA by Alexander Moore]


Fix error in e2e

Issue #, if available:
Description of changes:
0.6 is different from main, in the regard that anywhere is required in the command argument prefix. Will need to backport these changes later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override eks-anywhere-attribution-files-presubmit
/override eks-anywhere-presubmit


Pagination

Great work
when can we expect pagination feature in this

Sorry for the late follow up, been busy for work for a while, will take a look


DLRM data preprocess and readme fix

fix on DLRM data preprocess and readme, @xuechendi if it is OK with you, please help to merge this PR.


Create UI Mockup for View Items Page

About the View Items Page:

Users should be able to view a list of all items, with options to search and sort the items by different criteria (e.g., name, date added, quantity).
Users should have direct options to add, edit, or delete items from this list.
Clicking on an item should redirect users to the "Item Details Page" for more detailed information.

Task:

[ ] Display a searchable and sortable list of all items with buttons for adding, editing, and deleting items. Clicking on an item should lead to the detailed view.

Tasks Done Today:

Started the product list page
Added search bar and sort button
Added sample items
Added product carousel feature
Added navigation bar


Do not trace with run_tac but do trace otherwise + fix

cc @dselsam

(we need to keep the error trace for the top-level run_tactic'' calls to get back fatal errors)


Minor updates

Various minor updates to existing patterns + support for a couple of log lines that do not get tagged with _grok_postfix_success at our cluster.

This has to wait, anchoring the regex properly is more important.


4686/improve error messaging

Description
closes : #4686
This is the message that should be shown from now on when the server cannot be reached and an HTTP call fails for one of these standard failures :
err_name_not_resolved
err_connection_refused
err_blocked_by_client
err_tunnel_connection_failed

These cannot be caught individually, they all are returning the same message when being caught: Failed to fetch.

Processing this pull request

Merged into branches master, iso6 in b06c0bff47dbc4d97707e85fb3b88505d397f87f


Fixing issue when the parent is a UserControl #15

The WizardControl assumes that the parent is always a Form. See WizardControl.OnParentChanged line 548. This prevents the ConfigureWindowFrame() from running in case the parent is a UserControl. Since the Form and the UserControl doesn't have a common base class that defines the Load event - which is triggering the previously mentioned function - we have to hook to both of those separate Load events, which makes the solution less elegant, but also fixes a nullreference exception.

Has this been tested as both a child of a Form and a child of UserControl?

Closing as duplicate with #90


Non-uniform theme background

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:1.69.2
OS Version: macOS Monterey 12.4

Steps to Reproduce:

open a file in VS Code

When I upgraded to VS Code v1.69 the theme colors seemed to change slightly and now the editor background is not uniform. Instead there are two color tones, left 2/3rds of the editor is darker than it should be. It is clear something is awry when selecting lines.
In the video below I first show the expected behavior from VS code v1.68.1 and then I switch to the same file opened in VS Code v1.69.2 and you can see the wonkiness of the non uniform background that also follows the selected line. All of the themes and settings are the same with both versions. The same behavior occurs across multiple themes. Even when the "editor.renderLineHighlight" is set to "none" there is still two colors in the background.
https://user-images.githubusercontent.com/8128628/182009753-c0318eab-500e-4e34-ac1d-a570dc9130ac.mp4

/duplicate https://github.com/microsoft/vscode/issues/152816

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Remove X-Amzn-Trace-Id from outbound http/s requests to third parties

After globally capturing the http and https native modules, all outbound requests are being instrumented with an additional X-Amzn-Trace-Id header
This is useful in some circumstances, e.g. when calling other AWS services where tracing is enabled so that the trace can continue through multiple services.
However when calling a third party external service, I would like to have this header removed, as I want to prevent this value from being delivered to the third party, but I would still like to trace the outbound call to trace e.g. errors and durations.
Here is the code I am using to setup the global http/s instrumentation:
// capture HTTP(s)
const subsegmentCallback = (subsegment, req) => {
  if (typeof req.reusedSocket === 'boolean') {
    subsegment.addAnnotation('reusedSocket', req.reusedSocket)
  }
}

const capture = lib =>
  AWSXRay.captureHTTPsGlobal(lib, false, subsegmentCallback)

capture(http)
capture(https)
AWSXRay.capturePromise()

It is not possible for the SDK to determine if the remote service is third-party or not

That's okay! I'm happy to add a flag in the spots where my application calls out to a third party service to say "Please trace this request (capture duration, return status code, etc) but do not send X-Amzn-Trace-Id header"

is there a specific reason why exposing this information to third-party may not be a good idea

I'm building a web data extraction service, and a lot of work is being done to ensure the outgoing request faithfully recreates a browser request, which wouldn't typically include tracing headers
I think it's also a good idea from a security perspective. Including this header partially reveals implementation details that are usually better kept under wraps.

@mattfysh here's where we set the header, if you'd like to make a PR to add an option to not include trace header we'd be happy to review: https://github.com/aws/aws-xray-sdk-node/blob/043be345d24dc537463a58999dd8651fefa12349/packages/core/lib/patchers/http_p.js#L127


ClassNotFoundException : de.javakaffee.kryoserializers.CurrencySerializer

From<EMAIL_ADDRESS>on April 22, 2014 14:59:12
What steps will reproduce the problem?
I'm trying to use Kyro2 + Tomcat8, but at the startup im getting ClassNotFoundException: de.javakaffee.kryoserializers.CurrencySerializer

What version of the product are you using? On what operating system?

Tomcat 8 Libs:

memcached-session-manager-1.8.1.jar
memcached-session-manager-tc8-1.8.1.jar
spymemcached-2.10.2.jar

App Libs:

msm-kryo-serializer-1.8.1.jar
kryo-serializers-0.26.jar
kryo-2.23.0.jar
minlog-1.2.jar
reflectasm-1.01.jar
asm-3.2.jar

Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=205

From<EMAIL_ADDRESS>on April 22, 2014 06:17:29
Stacktrace attached.
Attachment: stacktrace.txt

From martin.grotzke on April 22, 2014 07:16:11
You're using kryo 2, which is not yet supported. According to the SetupAndConfiguration page you must use kryo-serializers-0.11 (0.11 is needed, as 0.20+ is for kryo2) and kryo-1.0.5.
If you're using maven/ivy/gradle the correct deps should be pulled in by msm-kryo-serializer.

From<EMAIL_ADDRESS>on April 22, 2014 07:51:05
Thank you Martin,
I´m changing back to kryo-serializers-0.11. You said kryo-1.0.5 but the current version pulled by msm-kryo-serializer is kryo-1.0.4 right?

From martin.grotzke on April 22, 2014 09:51:52
Should be ok then.

From martin.grotzke on June 15, 2014 15:48:31
Closing, should be working now.
Status: Invalid


Shipping System.Memory in analyzer folder can cause other Source Generators to fail

This has been written up in two places already so I won't delve into detail here. The roslyn issue I wrote has the technical stuff.
Bringing up the issue here so it can be tracked if appropriate.
CommunityToolkit Issue: https://github.com/CommunityToolkit/dotnet/issues/493
Roslyn: https://github.com/dotnet/roslyn/issues/66104
Actual behavior
Having both CommunityToolkit.Mvvm and Microsoft.Windows.CsWin32 (since v0.2.63-beta), causes the CommunityTookit source generators to fail with a MissingMethodException in System.Memory.
Expected behavior
Generators should play nice with each other and not cause IL generation to fail.
Context

CsWin32 version: 0.2.164-beta
Target Framework: net7.0

We should review the lowest csc.exe version that we intend to support and review the version of System.Memory that it includes. If that version is one that CsWin32 can tolerate, we can drop shipping our own copy.


26 add forward helper

closes #26

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Secret Website 3 has degraded performance

In d742ee8, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2938 ms

Resolved: Secret Website 3 performance has improved in ab0835c.


ssh: fix listening tunnel on wildcard ip

Fix a part of https://github.com/golang/go/issues/33227 and https://github.com/golang/go/issues/37239 .
Future fix for domain resolve needs breaking changes or new API.

Can you please give a try to this CL? Thank you


fix: added update stmt for DataRequest

What this PR changes/adds
This PR fixes a bug in the SQL impl where a DataRequest was not persisted when updating TransferProcesses.
Further notes
.
Linked Issue(s)
Closes #1707
Checklist

[x] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndkrimbacher I cannot add you as a reviewer, but feel free to take a look.


Bugfix username and password in generic template

Fixed a bug where the wrong values of inputs were accessed for username and password in the generic template. Incorrectly the value of "artifactory.generic.password" was used as the username and the value of "artifactory.password.DUMMY" was used as the password for the loadGenericRepoKeys request.

Thank you for this fix @maxliesegang!
Can you please join our contributors community by signing JFrog's CLA so that we can merge your code?

Just signed the Agreement


[batch infer] Update batch inference template to use RayLLMBatch

Update the current batch llm inference template to use RayLLM-Batch

DON' MERGE, and don't delete the branch.

RE compute config change, the previous seems to have different variations of g5 and l4 instance types. I guess it helps with finding the gpus. Not sure if this change will make it harder to find gpu and slower to start the cluster

@shomilj to review the computer config.
@angelinalg if u want to take a look at the content.

Don't delete the branch for now.


Training on custom data

Dear @sandipan211 ,
I have one more query. I got good results for MSCOCO data. Now, I want to train in custom data. In the training steps, for MSCOCO, MSCOCO/fasttext.npy is required, and Pascal VOC also requires /workspace/arijit_ug/sushil/zsd/VOC/fasttext_synonym.npy is required in step 4 and step 5.
Is this file created during training from steps 1-3? If so, similar .npy files for class embeddings may be created for custom data. I may then be able to train steps 4 and step 5 for complete training in custom data.
Thank you for your time and consideration.

These files for semantic embeddings are not generated in the steps mentioned in README. We had taken them from another GitHub repo for previous work on ZSD. Kindly see my reply to issue #4 for more details.

Dear @sandipan211 ,
I have one query regarding class embedding. In the current repository, for MSCOCO, MSCOCO/fasttext.npy, it uses 81300 dimensional embedding , and Pascal VOC, VOC/fasttext_synonym.npy, it uses 21300 dimensional embedding. It may be because 81th in coco and 21st in voc may represent background class.
I want to create similar class embedding for custom data having 50 different number of classes. In that case, is the class embedding (for instance, in VOC/fasttext_synonym.npy) representing different categorical name of classes into numerical representation? Is using the python embedding function , such as word2vec , is only to represent the different classes with names in string to numerical value with 300 dimensions for each class ?
Thank you for your time and consideration.


Update to Schannel TLS registry entry

Changed "Enable" dword value option to "1" instead of "0xFFFFFFFF" as this is not correct.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Hi @felgar73 - thank you for this PR.
Hey @karelz - wanted to verify with you that this is accurate, if so I'll merge this PR. Thanks


Firefox Can't Open Page error on video content

Describe the bug
Error viewing video content within Firefox.
To Reproduce
Using Firefox open the site, visit any of the "Getting Started with pages", select a video.
Expected behavior
I expect the video to play.
Screenshots

Learning Pathways version number
4.1.2

I suspect that Firefox is not supported for these videos on support.office.com since we are just iFraming the content in, it's not an issue I can provide support for here. I will let the team know, and hopefully they can pass it on to that team to look into.
Thanks for reporting it.

@barryanderson same/similar issue with Edge/Chrome
https://github.com/pnp/custom-learning-office-365/issues/341
Could try changing the Firefox referrer policy https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy as a workaround.

This issue has been fixed. Thanks everyone.


⚠ Bofrost.es has degraded performance

In 228b79d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1655 ms

Resolved: Bofrost.es performance has improved in 07f7ef5.


Pull Request for adding style in Bookstore

In this branch,

styling is done for the bookstore.

ZEPLIN is used as a tool.

A lot of thanks to you.


Right-to-left language support

Hi - if a translator comes forward for Arabic, Hebrew, Persian, Urdu, or another right-to-left language, I'm open to setting up the appropriate layout / stylesheet for it
Currently the mysql2 issue is keeping me from popping up my own local instance, but I would work through or around it if there is a specific translation goal

Thanks for the offer!
I'll try and get the MySQL update tested soon to unblock you at least

Closing this as I still haven't had any translations that would allow this to be progressed


I liked your project

I would help you with your project but the project structure seems a bit complicated as there are many folders that I have not dealt with before such as the vendor and core folders
Also why you are using the scss format instead of css? what's the difference between them

The scss files are Sass files. Sass is just a way of writing CSS more efficiently. Take a look here for information:
https://sass-lang.com/guide/#variables

Thanks


Add Pin handling

I propose to add Pin handling because it is a native type in Micropython. Note that I couldn't test PinInt and PinTuple myself because of lack of hardware.
I also added a test file for umsgpack_ext.py for checking my implementation. I believe it's also good for keeping umsgpack_ext.py under control.

A reminder for myself.
At first I tried to auto-detect class Pin's first argument id. The resulting code was a bit cumbersome and prone to fail. I gave up and chose the simpler approach of a user configurable constant PIN_TYPE. The code was:
# determine what type of id Pin() wants
try:
    from machine import Pin
except ImportError:
    umsgpack.PIN_TYPE = None
else:
    try:
        Pin(("GPIO_1", 1))
    except ValueError:
        try:
            Pin(0)
        except TypeError:
            try:
                Pin('_') # there's no pin name common to all boards
            except ValueError:
                # pin doesn't exist but str() is a valid id
                pass
            umsgpack.PIN_TYPE = str
        else:
            umsgpack.PIN_TYPE = int
    else:
        umsgpack.PIN_TYPE = tuple

This could spiral out of control. If Pin why not SPI, I2C, UART and plenty more. I have these issues:

The repo already provides for adding user types as demonstrated with tuple, complex and set. Users can add types as required without changing the core library, which supports only objects defined in the official MessagePack protocol.
I'm not convinced there's any merit in packing the object rather than packing the arguments used to construct it. In general you might read a packed file on boot. Any packing scheme for (say) a Pin would have to run the constructor to instantiate it, so packing the args seems the obvious approach.
I suspect that packing objects that have a physical realisation in hardware will involve difficult use cases. I have no wish to try to support these.

I suggest you publish an extension file supporting extra types, with docs describing tested use cases.

My use case is a custom project where output pins are customizable. As such, I need to save pin configuration to a config file.

If Pin why not SPI, I2C, UART and plenty more.

Why not? If someone needs them and they're willing to share good code...

* The repo already provides for adding user types as demonstrated with `tuple`, `complex` and `set`. Users can add types as required without changing the core library, which supports only objects defined in the official MessagePack protocol.

Exactly. umsgpack_ext.py is user customizable by definition and this PR doesn't break compatibility with MessagePack. Pin will hardly see the light in MessagePack, while it could make sense for MicroPython developers. As a starting point, this PR can be further enhanched as to pack pin mode and initializing it when unpacking.

* I'm not convinced there's any merit in packing the object rather than packing the arguments used to construct it. In general you might read a packed file on boot. Any packing scheme for (say) a `Pin` would have to run the constructor to instantiate it, so packing the args seems the obvious approach.

The merit I saw in my project is that the configuration dict containing the pin can be used as-is when packing/unpacking. That is, config['pin'] is a Pin while config['pin_id'] is not and cannot be used as such by the rest of the code. Extra actions should be taken before packing (hiding config['pin']) and after unpacking (constructing config['pin'] out of config['pin_id']).

* I suspect that packing objects that have a physical realisation in hardware will involve difficult use cases. I have no wish to try to support these.

Agree. That's why I chose not to initialize the pin object.

I suggest you publish an extension file supporting extra types, with docs describing tested use cases.

I won't. I don't like source code fragmentation. Even Wikipedia states that "Python's large standard library [is] commonly cited as one of its greatest strengths".
At last but not least... I was going to contribute with a patch for timestamp support via my datetime implementation. Are you willing to accept it?

The bottom line is that I'm not prepared to assume responsibility for supporting a growing list of external types. The aim of the repo is to support a subset of official MessagePack types, and to illustrate how users may extend this.
Timestamp support would be very interesting. However for reasons of source code fragmentation this would be dependent on the micropython-lib maintainers accepting your datetime library. I do hope they accept this, as I think datetime would be a very useful addition.

Damien is very interested, too. I'm talking with him as to weather add support to microseconds. I'd be interested on your opinion, if you want to contribute. Anyhow, it just a matter of time and effort, I think.

If and when datetime is officially supported, please can we have a conversation on implementing timestamps before you invest a lot of time in coding. One thought that comes to mind is that, if its addition substantially increases RAM use, it may be best made optional for users on minimal platforms.
I'll keep a close eye on datetime development here in GitHub. I'm willing to be convinced either way on microsecond support.
I've looked at your code again and thought further about what would be needed to make Pin support suitable for general use. The more I think about it, the more sure I am that it's a support nightmare. Sorry.

Where would you like to discuss about datetime? Shall I open an issue here? Micropython forum? I'm already studying MessagePack code. I'm an embedded developer working with C/C++ on bare metal. I'm well aware of RAM scarcity.
I absolutely agree that Pin support for general use would be a nightmare. I started to implement it like that and soon realized I was going nowhere. That's why this PR touches umsgpack_ext.py only which is, in my eyes, a blueprint the developer can start from.
Again, I don't understand why this PR cannot be accepted, but I can accept it. I don't want to push on you. If you change your mind eventually, the code will be here for merging.

To clarify, I was suggesting we discuss the implementation of timestamp in this library before you spend too much time coding.
This would be after datetime is incorporated in the official code (which I hope happens soon).


Add the capability to provide an authentication token as a query parameter (MS PowerQuery compatibility)

Background
I have been experimenting with using Microsoft Powerquery in Excel as a client via the RESTful interface to extract and report on SnowOwl data.
I started off using Basic Auth which worked as expected, however when I switched to trying to use an access token instead, I hit a problem. It took quite a bit of web searching to identify the problem.
It appears-

SnowOwl currently only supports access tokens via an "Authorization" HTTP header.
Excel/Powerquery's built-in keystore solution will only deliver a token via a query parameter

Thus the two can't talk.
Preferred Solution
While this problem is basically caused by a limitation of Powerquery, the likelihood of persuading Microsoft to change their capabilities in a hurry seem low. Therefore it would be beneficial if SnowOwl could have the capability to accept auth tokens in the query string OR in an http header.
Workaround
It is possible to insert the token header directly into the query generated by Powerquery using M language code. I have tested this and it works. However this is not ideal solution as it means the access token is visible in the M source code, rather than being stored in the Excel/PQ keystore.
Other info
If the feature is added in a  future version of SnowOwl I can offer to help with testing from an Excel client.

Hi @colin-e-nhsd,
Sorry for my late reply here. It is possible to provide an authentication token via a query parameter named token.
Example:
GET /snomed-ct/v3/SNOMEDCT/concepts?token=your-auth-token

Feel free to test it out when you have the time.
I'm going to close the ticket now, but if you find something is not working feel free to reopen it.
Cheers,
Mark

Do note that web server access logs, browser history, caching proxies and possibly other components in the request chain might retain a copy of your access token if it is passed in via a query parameter. While request headers are not exempt from logging either, the URL is more likely to be retained in its entirety.


Add preset for natural=shrubbery

I would like to see natural=shrubbery to be added as a preset. The tag has the status in use and is already used more than 4000 times
https://taginfo.openstreetmap.org/tags/natural=shrubbery#overview

note that this tag is quite controversial and was rejected twice in wiki vote ( https://wiki.openstreetmap.org/wiki/Proposed_features/shrubbery )
It does not disqualify it, but it really should be mentioned when proposing to add it to presets

This tag is now being supported by a major vector tile renderer, OpenMapTiles.  Support for natural=shrubbery was added to OpenMapTiles in openmaptiles/openmaptiles#1397.
In addition, according to taginfo, the tag enjoys considerable organic popularity and growth, even without it being present as an iD preset:

I would support this tag being added to the presets despite the wiki votes, as there is a clear mapper preference for adding the tag.
natural=shrubbery solves a real mapping problem that isn't addressed by other tags such as natural=scrub, landuse=grass, landuse=flowerbed, etc.  We should recognize the ongoing organic support for this tag with a supporting preset.

I support.
42,226 uses now.

I read the proposal-statement, scrubery wiki page and some of the discussion on the scrub wiki page.
I think the question if this preset can be included should be mainly be made based on if the re-definition (change or at least modified / narrowed meaning) of natural=scrub (to only be unmaintained scrubs) has reached a status where we don't attract too much unwanted discussion on this here.
My understanding of the guidelines that Martin has for including tags here is, to have the tags officially voted/accepted. In rare cases it is enough for them to be in a state that has been rolled out ("in use") by mappers but also data consumers and editors so that we can be reasonable be sure to not have this end up on the "disputed tagging decisions by iD maintainers" wiki page. I am not sure if this is the case for this situation (yet).
One thing we can do here, I think, is to become a bit more to the point. For example by adding a PR that shows how adding this preset could look like. The main issue I see is, that we need to re-defined https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/natural/scrub.json. Probably in a similar way to the natural=wood vs. landuse=forest presets.
Another thing that should be less controversial to merge is to add this as a unsearchable preset so the existing data is visible at least.
PS: Please lets not start a discussion on the tag itself, that should happen elsewhere.

we can be reasonable be sure to not have this end up on the "disputed tagging decisions by iD maintainers" wiki page

Is this really the standard for accepting a preset?

I read the proposal-statement, scrubery wiki page and some of the discussion on the scrub wiki page. I think the question if this preset can be included should be mainly be made based on if the re-definition (change or at least modified / narrowed meaning) of natural=scrub (to only be unmaintained scrubs) has reached a status where we don't attract too much unwanted discussion on this here.

I'm not sure if these are typos or a misunderstanding.  This discussion is regarding shrubberies, not scrub. If someone types in "shrubbery" into iD, they ought to find a shrubbery preset for natural=shrubbery. It seems clear to me that there's sufficient community uptake to include this tag:

Organic mapper usage of this tag has been consistent per taginfo:

The tag has usage in two other major editors - JOSM and Vespucci, as well as several map styles:

It has been included in the OpenMapTiles schema (a leading OSM vector tile schema for two years now.

It is well documented on the OSM wiki.

My understanding of the guidelines that Martin has for including tags here is, to have the tags officially voted/accepted. In rare cases it is enough for them to be in a state that has been rolled out ("in use") by mappers but also data consumers and editors so that we can be reasonable be sure to not have this end up on the "disputed tagging decisions by iD maintainers" wiki page. I am not sure if this is the case for this situation (yet).

I've gone ahead and added a mention to that page, so there's no longer a need to worry about that. iD's reluctance to follow other projects in adopting organic tag usage is certainly a controversial decision. So perhaps it will be a controversial decision either way. In any case, when one editor takes a different stance from other editors, that would seem to be controversial. But, if we are worried about controversy, we have the Software Dispute Resolution Panel, which is specifically for these types of impasses and is also a process explicitly adopted for the iD editor.

One thing we can do here, I think, is to become a bit more to the point. For example by adding a PR that shows how adding this preset could look like.

It's unfair to ask for a PR based on the comments here. If the PR is not likely to be accepted, it would be a waste of time for a contributor to do that work. An indication that a well-crafted PR would be accepted would be a healthy first step towards inviting a community contribution.


Add const char * overloads to String class

The added function overloads, namely:
int _count(const char *p_string, int p_from, int p_to, bool p_case_insensitive) const;
int rfind(const char *p_str, int p_from = -1) const;
int rfindn(const char *p_str, int p_from = -1) const;
String replace_first(const char *p_key, const char *p_with) const;
String replacen(const char *p_key, const char *p_with) const;
int count(const char *p_string, int p_from = 0, int p_to = 0) const;
int countn(const char *p_string, int p_from = 0, int p_to = 0) const;

help avoid creating a ton of String objects and the underlying dynamic memory allocations they require by using the C-strings directly when possible.
I personally find that this patch makes the Editor feel snappier, but I have not run any benchmarks yet.
Edit: Added int String::findn(const char *p_str, int p_from).

I noticed I missed another overload I wanted and took the liberty to add int String::findn(const char *p_str, int p_from) as well, which is the last one I'll add for this PR.

Let's add some unit tests for these to ensure correctness, do they work with unicode? If so then ensure it works with non-utf8 input

It currently does break current checks, and unsure what happens with various cases using non-ascii/utf8 input

Edit: or rather, you need to rework the tests to test for the String and c-string versions, because the current tests use string literals that are now going through a different method

Indeed. I was about to ask about this -- I'm not sure if we want to duplicate the tests like this:
	CHECK(s.findn("WHA") == 7);
	CHECK(s.findn(String("WHA")) == 7);

Or maybe add a macro to test both under the same line and keep it DRY.
I don't know if there's a cleaner way to do this. There doesn't seem to be.

would be good to confirm that it doesn't break things like: str.findn(U"...")

I should clarify I intended to keep this PR unrelated to U"" and L"" C-strings. Those calls won't break due to this PR because they are on an unrelated code path. The call str.findn(U"") yields a function signature similar to findn(const char32_t*)  for which there is no implementation (this PR only implements findn(const char *)) and as a result the compiler will look for other possible function candidates it can call given the findn(const char32_t*) signature. Currently, there's only one other candidate which is str.findn(String) which the compiler knows how to call because it can convert the const char32_t* parameter to a String through the String copy constructor String::String(const char32_t*). The same happens with a str.findn(L"") function call and, again, this PR never touches either of those code paths.
Having said that, we are indeed missing some tests for U"" and L"" C-strings. I'll add the tests for the functions I've overloaded if they pass.

Agreed, just wanted to make sure the automatic overload resolution works correctly as C++ can be so messy with that some times

Tests passed for U"" and L"" C-strings on my end so I've added them.

I personally find that this patch makes the Editor feel snappier, but I have not run any benchmarks yet.

Would be nice to do some benchmarking on an optimized build to see if there is actually a significant difference. Performance optimization can have surprising results only reasoned about but not tested.
CC @Calinou

Would be nice to do some benchmarking on an optimized build to see if there is actually a significant difference. Performance optimization can have surprising results only reasoned about but not tested.

Here benchmarks of editor startup + shutdown time (I ran these twice and results were consistent):
❯ hyperfine -iw1 "bin/godot.linuxbsd.editor.x86_64.master --path /tmp/4 -e --quit" "bin/godot.linuxbsd.editor.x86_64 --path /tmp/4 -e --quit"
Benchmark 1: bin/godot.linuxbsd.editor.x86_64.master --path /tmp/4 -e --quit
  Time (mean ± σ):      3.027 s ±  0.058 s    [User: 2.075 s, System: 0.361 s]
  Range (min … max):    2.911 s …  3.132 s    10 runs

Benchmark 2: bin/godot.linuxbsd.editor.x86_64 --path /tmp/4 -e --quit           <--- This PR
  Time (mean ± σ):      2.982 s ±  0.290 s    [User: 2.074 s, System: 0.366 s]
  Range (min … max):    2.523 s …  3.537 s    10 runs

Summary
  bin/godot.linuxbsd.editor.x86_64 --path /tmp/4 -e --quit ran
    1.02 ± 0.10 times faster than bin/godot.linuxbsd.editor.x86_64.master --path /tmp/4 -e --quit

Binary size:
Editor
master: 105,335,696 bytes
    PR: 105,270,128 bytes (-65 KB)

Release export template
master: 62,385,544 bytes
    PR: 62,344,616 bytes (-41 KB)

Rebased to incorporate test changes from #89194.

Seems good to me. Could you rebase to make sure it still passes CI?

CI checks passed after rebasing.

Thanks!


[Doc]: Add TargetProxyHosts configuration as Trasport Sender Parameter

fixes: https://github.com/wso2-enterprise/wso2-apim-internal/issues/7553

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


release actions and workflows

to streamline the creation of releases and publishing (e.g. to pypi) we could look into some GH actions that are out there:

https://github.com/marketplace/actions/pypi-publish
https://github.com/spacetelescope/action-publish_to_pypi (we can't use this but maybe look into it)
https://github.com/spacetelescope/crds/blob/master/.github/workflows/release.yml
I like the idea of having a "release workflow", maybe we could create/configure an action that (when triggered) creates the release PR (similiar to the conda-forge bot) automatically using a script or similar to fill in dates etc. in places that we need them

Honestly I think it is dangerous the encode secrets for PyPI access in the cloud (owned and controlled by Microsoft). There are too many reports where patterns like this have been abused and we do have a responsibility to protect the users of our software.
It ain't too much effort to create a source archive locally from a git tag and just push it to PyPI (5 min of work). But I do feel the appeal of just pushing a button and everything is done automatically.

we can revoke the token on PyPI in case there is a problem too


Icons not fading all the away on Classic

Hello, using this on classic the CD icon does not fade all the way frequently with Frost Nova and Flame Blast.

Hey, thanks for flagging this issue. I've seen some comments about issues with HC Classic, but I don't currently have an active WoW subscription to be able to test a new version.
Others have reported having some success using the version intended for WoTLK Classic. Could you give that a try and see if it works any better for you?

Hey will do! It's like it stops fading at the last second on the classic
version
On Sun, Oct 1, 2023, 2:41 PM Andrew Duthie @.***> wrote:

Hey, thanks for flagging this issue. I've seen some comments about issues
with HC Classic, but I don't currently have an active WoW subscription to
be able to test a new version.
Others have reported having some success using the version intended for
WoTLK Classic. Could you give that a try and see if it works any better for
you?
—
Reply to this email directly, view it on GitHub
https://github.com/aduth/Doom_CooldownPulse/issues/9#issuecomment-1742210874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6WVNWJM5OOCPMTSSQUBBDX5HPSLANCNFSM6AAAAAA5OSC2WI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey I tried the WOTLK version but it seems it won't even work through curseforge.

You'll have to download and install it manually, instead of through the CurseForge app.

Download from CurseForge: https://www.curseforge.com/wow/addons/doomcooldownpulse/download/4489489
Unzip and find the folder Doom_CooldownPulse that has files in it. It might be inside the folder where you extract it to.
Move the Doom_CooldownPulse folder with the files into C:\Program Files (x86)\World of Warcraft\_classic_era_\Interface\AddOns
Restart the game

The game will probably tell you that the addon is out-of-date, but it should work.

Hey, yeah the WOTLK version works sorry for the late reply!
On Sun, Oct 1, 2023 at 4:53 PM Andrew Duthie @.***>
wrote:

You'll have to download and install it manually, instead of through the
CurseForge app.

Download from CurseForge:
https://www.curseforge.com/wow/addons/doomcooldownpulse/download/4489489
Unzip and find the folder Doom_CooldownPulse that has files in it.
It might be inside the folder where you extract it to.
Move the Doom_CooldownPulse folder with the files into C:\Program
Files (x86)\World of Warcraft_classic_era_\Interface\AddOns
Restart the game

The game will probably tell you that the addon is out-of-date, but it
should work.
—
Reply to this email directly, view it on GitHub
https://github.com/aduth/Doom_CooldownPulse/issues/9#issuecomment-1742244278,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6WVNTKA7XHRWWTKX3LFQ3X5H67DANCNFSM6AAAAAA5OSC2WI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Glad to hear it’s working! I’ll keep the issue open, since I still want to solve it for the Classic version, but good to know the workaround is an option in the meantime.

I’ve since resubscribed ahead of Season of Discovery and was able to get a new version for Classic tested and published to CurseForge, so you shouldn’t have to manually use the WoTLK version anymore.
I’m hoping this will work for Season of Discovery, but since there’s no PTR for it, I’ll have to wait and see if anything breaks once that goes live. I’ll try to get an updated version out ASAP if that happens.


Images missing from the chatbox

I have uploaded the image in the chatbox, when i open the chatbox in another session the image is not shown and shows a broken link

@afferraza Could you share some screenshost of the behaviour you're experiencing? Can you replicate it on discourse-babble.com? What is the url of the broken image link?


FIX IControllerMiddlewares needs to be exported

Currently 2.3.0+ of ts-express-decorators is failing when used.
Fixed by pull request.
Errors in my build:
node_modules/ts-express-decorators/lib/mvc/class/ControllerProvider.d.ts(95,18): error TS2304: Cannot find name 'IControllerMiddlewares'.
node_modules/ts-express-decorators/lib/mvc/interfaces/IControllerOptions.d.ts(16,19): error TS2304: Cannot find name 'IControllerMiddlewares'.

Hi @lwallent ,
Thanks you a lot for your help :)
Can you read this documentation for the next PR please: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit
The commit message syntax is use to generate the right release note in github here and it used by semantic-release for create the version number.
See you :)

Hi,
Great library you have created ;-)
I have read your the documentation you posted, but only just realised that the formatting was supposed to be used on each commit and not on the PR it self. Sorry about that :-)

No problem ;)


Dataset metadata dataset size

The dataset size (in bytes) is stored in the metadata file. This size is calculated client-side. We should do this server-side to be more reliable.

We're gonna tackle this on the universe side of things


Freeplay songs and mods crash

Describe your bug here.
Invalid char 118 at position 0
This is a new build
I investigated and it's a mod bug

Command Prompt/Terminal logs (if existing)
None

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

I changed the ModsList.txt but no luck.

you messed up one of your week jsons, check each week json in (mod name)/data/weeks

it’s an issue with your week jsons, the thing i suggest is to delete the mods in your build one by one until your engine stops crashing

I deleted literally everything and it finally stopped crashing. I deleted "the frame of wiring" last so it must be that

nope, when I put everything back, it crashed again

now try removing each mod and put them back one by one until it crashes again, make sure to reopen the engine each time you put the next mod in

ok

when I add ANY MOD, it crashes, WHAT

that’s weird but idk how to help as none of these crash for me

okay I changed some of the values in modsList and the only ones that display in freeplay are: Jordan's Large FNF Charts & The Charts

turns out, you have to delete the jsons with the links, and i did that BUT the songs just crashed the engine when I played them. No error, just crash.

it only crashes on the mod songs... not on the fnf songs.

i tweaked the settings but nothing worked. i don't get it.

oh. i’m sorry idk how to help as none of them crash for me

I've found the culprit for the week JSON crash. Git LFS apparently messed up some of the week JSONs.

A commit has been pushed to the repository hopefully fixing all the crashes. Be sure to delete the mods you currently have installed and reimport the new ones.

:O Thank you

IT WORKED


Authentication: Email Verification UI

Develop the forget password page UI appropriately
Ensure they are responsive and follow the responsive design on the Figma
Implement images properly
Follow the color guide and the appropriate colors

I am working on this Issue


Adding XGboost Python sdk

Added Python sdk for XGboost and e2e test in GHA actions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 37.01%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mpi/mpijob_controller.go
5
78.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
2312

Relevant Lines:
6247

💛  - Coveralls


Channel first issue

Where have you told pytorch that you are going to use channel first image? Previously I used channel last image with pytorch.
https://github.com/eriklindernoren/PyTorch-GAN/blob/f4c14d1daf86c6c05d8d36c53bc8e7587f00c206/implementations/cgan/cgan.py#L34

It's channel first by default. See https://pytorch.org/docs/master/nn.html


Update spring-boot-starter-test, ... to 3.2.1

About this PR
📦 Updates

org.springframework.boot:spring-boot-starter-test
org.springframework.boot:spring-boot-starter-web

from 2.7.18 to 3.2.1 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.springframework.boot" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.springframework.boot" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #1929.


friction

I need to simulate a space ship, and there is now friction in space. Is it possible to disable it in Physijs so if body started to move it would never stop?

not sure how to do this with physijs, but I think you can simply add the object to your loop and keep updating the position with a constant speed, in this way you should be able to achieve the same result.

@JSirko, I think you may try setLinearVelocity, disable gravity and set friction to minimal value.

@JSirko you can disable linear and angular damping (basically air friction) using .setDamping function in Physijs bodies:
// Disable friction in space...
body.setDamping(0, 0);


Ignore comment lines

Ignore files can contain comments starting with '#' which should be ignored.

Confused with functionality in another git plugin.

 :)


Suggestion: Allow Thermodynamic Conductors to pass IC2 heat units

If at all possible, I would love to see the Thermodynamic Conductors be able to work with IC2's heat system in a manner similar to the Universal Cable's energy conversion.

I considered this several weeks ago, but I'm afraid that the conversion technicalities and differences in our systems would make this rather difficult.  Perhaps in the future!


Profile section

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1737
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[x ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Checklist:

[x ] I have made this change from my own.
[x ] I have taken help from some online resources.
[x ] My code follows the style guidelines of this project.
[x ] I have performed a self-review of my own code.
[ x] I have commented my code, particularly in hard-to-understand areas.
[x ] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[x ] I have tested the changes thoroughly before submitting this pull request.
[x ] I have provided relevant issue numbers and screenshots after making the changes.

If you need any help contact me or any mentor

It's fine in my repo . After writing pr how can it delete css code? I tried it many times

create a new branch


Please add the "min" and "minus" to find subtract icon(s)

Is your feature request about our website? Please describe.
Website
Is your feature request about the Usage? Please describe.
Yes, about the search
Is your feature request related to a problem? Please describe.
Please add the "min" and "minus" keywords, to find the subtract icon. Was looking long for this.
Describe the solution you'd like
The keywords to be added to find minus icon

Thank for the advices, we've added the keywords in v3.4.0


Adding show all user feature in user controlpanel

Fixes https://github.com/plone/volto/issues/1719

@iFlameing I'm wondering how this feature works with thousands of users (e.g. LDAP)

@avoinea that is something we have to take into account for sure. We are about to deploy Volto in an intranet with 10k users. My plan was to go ahead with this and see what happens. :)
(we are still in pre-production mode for another two months, therefore we can live with possible problems right now and we could take the bullet here)

@tisto I see. One small issue I've notice, component state is not reset/re-initialized on exit/enter:

@iFlameing can you please look into this ^^^? And also re-run "yarn i18n"?

@avoinea can you please review this once again.

@iFlameing can you please rebase.

@avoinea done :) @tisto Why do we need this feature? Regarding showing large list we can use react-window :)

@tisto rebase is done


Add feed to project page

resolves https://github.com/NEARBuilders/gateway/issues/353
https://github.com/NEARBuilders/gateway/assets/46527178/6aa3e0ee-be06-4a01-8289-609f39b5d79e

@itexpert120 here instead of using the project ID in the heading, we can use the title of the project, since Id will always remain same but admin can change the title.

I agree with comments above, and resolve merge conflicts


Wrong drops

Datapack-Utilities v2.3.0

reload was successful

Vanilla 1.17

Since 1.17 mining iron ore with a pickaxe should drop raw iron. Instead it still drops a block of iron ore. But copper ore works correct (->drops raw copper)

Must have forgotten to update the loot tables, fun!
Will fix next update.

Fixed in 2.3.1


Created CommandFacade

📚 Description
Introducing the Facade pattern in the Command module
🔖 Changes

Created CommandFacade, and injecting it into the PhelFacade.

Facade + Factory patterns Combo
The Facade is the only entry point from a module. It will receive its factory in order to create whatever it needs and perform the actions from its "creations".
🤔 I am thinking about how to improve the current design of the project one step forward by following this pattern in all modules (if possible and if it makes sense). I will work in another branch to try some ideas 💻 🏭

Looks good. It is merged now.

Looks good. It is merged now.


Add integration tests

Changes proposal:

Adds integration test for mysql, postgres and client-server golang app.

@JU4N98 Why do you open close this pr twice?

Sorry, my mistake, the commits weren't signed as was required.

Sorry, my mistake, the commits weren't signed as was required.

you can add that to an existing pr, don't need to close.

I didn't know that, I'll take that into account. Thanks!


Javascript package includes python resource description?

In checking the code, I noticed that the JS package the tool resource description states that it's designed for Python Code. I assume that's a bug?
See:
tools: [
{
name: "run_code",
description:
"Run python code in a secure sandbox by E2B. Using the Jupyter Notebook syntax.",
inputSchema: zodToJsonSchema(toolSchema),
},
],
}));

Everything is correct here. The code interpreter runs Python code.


 Even on death it still thinks you have it in your hand.

What Bonsai Trees version are you using? This should be fixed since 3.0.3 (see #237).


Use shadowcat for oauth

Reason for change
Probably over-engineered this, but learned a ton about TypeScript and Stencil in the process!!! There are some linting errors here, but maybe new eyes on this will help us figure out a reasonable way to get the token from the iframe into the token Prop (and then update it when needed). Any way you know to do it is welcome to me.
These are the necessities of this component per @Minivera:

On load, if it has a token, give that to the manifold-connection
Start fetching a newer auth token
When it receives a auth token, update connection and trigger the dom event for the platform to get the newer token

I did successfully add manifoldco/shadowcat to the manifold-auth-token component however. :)
Testing
Ran this in Storybook and checked the console for the this.token value, which was hard.

@batgirl @davidleger95 I added a commit which I'll explain here, since I thought that would be easiest.
Overview
The main point is to raise an event that can alert a platform partner if the token has changed from null to present, or from present to null.
But Why?
This allows a Platform to save the token wherever/however they want. Global variable, local storage, cookie. Doesn't matter. It's worth mentioning that render doesn't need this. @Minivera suggested that future platforms might want control of how the token is stored so that they can feel more confident that the security of the token is in their hands. If it's easy to make that happen, we might as well do it up front. But we should keep Render's immediate needs centered here in the event that we find problems with this.
Implications
When a platform user loads the page, the platform may already have a token saved from a previous oauth dance. They can use that token as a prop to manifold-auth-token. That component will render our manifold-oauth component, which is going to result in a new token being set in the connection, but that token will not be broadcast to the platform if a token was already present. (@Minivera, I'm rethinking this part. Wouldn't it be better for the platform to always have the latest token? What's the downside?)
Because the platform may provide us with an expired token, it's possible that a component will attempt to make an authenticated call before oauth has completed and retrieved a new token. That will result in a 401, which we'll have to decide how to handle as we convert our calls to GraphQL.
Other changes in this commit
Function props must either be optional or have default values, according to our lint rules. manifold-oauth-token was previously using an optional prop for setAuthToken. I changed it to a default no-op value instead.

Also realized that we were using local storage as a backing store for our previously retrieved token, but we weren't setting it in local storage when we retrieve it! Added another commit to fix that.

That component will render our manifold-oauth component, which is going to result in a new token being set in the connection, but that token will not be broadcast to the platform if a token was already present.

When a new token is created doesn't it force older ones to expire? That was my understanding of how our auth worked. If this is the case, then we will always need the latest one.

(@Minivera, I'm rethinking this part. Wouldn't it be better for the platform to always have the latest token? What's the downside?)

I don't think there is any from our side, but I'd wonder about the load of constant oauth requests on our servers and the platform's servers. Should we only do the oauth dance if we know the token is invalid?
The token invalidity could be done in a few ways. One could be to encore the expiration in the token as suggested in DM, then if the token as expired, we redo the dance. Another could be to trigger a DOM event when an endpoint triggers a 401, in that case the platform should give us a null value as the tokens so we can redo the dance?

 Should we only do the oauth dance if we know the token is invalid?

@Minivera we might want to get advice on that. My gut says it won't be that bad, and we can adjust if it turns out to be a real problem.

Sorry I asked a few questions in https://manifoldco.slack.com/archives/CDW4B94RK/p1563569842030800

Added minor comments. LGTM ✅


ci: configure release

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

1.0.0
GitHub release

Your semantic-release bot :package::rocket:


Larger disk options and expose disk options in Portal UI

add support for 2048Gb and 4095Gb managed disk sizes
add  support for selecting disk size, number and type within the portal.

Closes #145
Closes #146

run npm run links -- --branch master before merging


Fix gradle deprecation warnings, hard-mode

This PR will replace the compile and related configurations in gradle build scripts.

Dependencies should no longer be declared using the compile and runtime configurations

This is a more complex since the shift from compile => implementation hides module dependencies from consuming modules. This means that consuming code which previously had transitive access to the dependencies of modules it consumes no longer has that access. The consuming modules will now need to explicitly include dependencies which had previously been transitively available.

The Java Library plugin configurations

One deprecation warning remains which is Legacy publication system is deprecated and replaced with the *-publish plugins. This is related to the use of the maven plugin which appears to be pulled in as part of apply(plugin: "propdeps-maven").
I believe this is used to generate the pom.xml files via the writeNewPom task. Alternatives to this plugin will need to be used before upgrading to Gradle 7.0
./gradlew help --warning-mode all

> Configure project :
The maven plugin has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the maven-publish plugin instead. Consult the upgrading guide for further information: https://docs.gradle.org/6.3/userguide/upgrading_version_5.html#legacy_publication_system_is_deprecated_and_replaced_with_the_publish_plugins
        at build_1sav6t7w25mbw9xe231myvzao$_run_closure1.doCall(~/workspace/uaa/build.gradle:34)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

LGTM.  Thanks for helping with this!


bold text is not rendered correctly

Hi Niklas,
while putting the new version into production i recognised, that bold text doesn't differ from the normal one :-( maybe the standard font-weight has to be adjusted a little bit?
Best regards, Michi.

It seems this effect depends on different screen resolution, browser, operating system.

Firefox, Chrome on Samsung Galaxy S5 Android 7 works as expected
Firefox, Chrome, Safari on macOS Mojave, LG external Display (3440 x 1440) with different browser window sizes shows only a small difference between bold and normal text
Firefox, Chrome on Arch Linux, full HD (1920 x 1080) with different browser window sizes shows no difference between bold and normal text

Thanks Michi for pointing this out - and sorry for my late response.
The fonts weights are now set to 400 (normal) and 600 (bold), this should fix the issue.
I think there should be a noticeable difference between 400 and 600 on the default fonts for every OS, but feel free to reopen if the issue persists.


make files contain html5 doctype

replaced outerHTML en jsDOM with serialize() as outerHTML strips the <!DOCTYPE>.

Very noice


TOC links no effect in Nextra3

I find in the official site https://nextra.site, the toc are links, which I can click to locate.
There are also another two feedback and edit links.
But when I create a Nextra3 project, I find all these links not working.
Here's the steps I create my test project:

npx create-next-app, and use src/pages/ with tailwindcss.
npm install nextra@alpha nextra-theme-docs@alpha.
remove src/pages/_document.js and src/pages/index.js.
create src/pages/index.mdx, src/pages/_meta.js and ./theme.config.js.

Then rewrite these files:
// ./next.config.mjs
import Nextra from 'nextra';

const withNextra = Nextra({
  theme: 'nextra-theme-docs',
  themeConfig: './theme.config.js',
})

export default withNextra({})

// ./theme.config.js
export default {}

// src/pages/_meta.js
export default {
  index: 'Home'
}

[//]: # src/pages/index.mdx
# This is a test project

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

## This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

## This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

This is a test project.

Then I run npm run dev.
The problem, all links on the right sidebar, including This is a test page TOC and Question? Give us feedback and Edit this page, are not working.

I reinstall Nextra of version 2.13.4, and the links all work, so I think it may be the problem of nextra3?

I reinstalled Nextra of version 3.0.0-alpha.22, and it worked.
Maybe version alpha points to Nextra4 or something else?
Anyway, the problem is solved.


Azure AD B2C SAML metadata url is incorrect

[Enter feedback here]
Azure AD B2C SAML metadata url should be https://your-tenant-name.b2clogin.com/your-tenant-name.onmicrosoft.com/your-policy/samlp/metadata?idptp=your-technical-profile

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e14a5d4c-5125-8ed2-7fda-38aee1296b76
Version Independent ID: 054d298b-937e-9f01-ae56-7025e47e4eec
Content: Add ADFS as a SAML identity provider by using custom policies - Azure AD B2C
Content Source: articles/active-directory-b2c/identity-provider-adfs2016-custom.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@mrvladis Thanks for your feedback! We will investigate and update as appropriate.

@mrvladis The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Add move locator to rate engine log messages

Description
Add the move locator to the log messages of the rate engine for easier debugging and searching logs.
Setup
make server_run
make client_run
create a move and when you get to the screen that has the estimator (the weight slider), look at your server output and you should see things like:
2020-02-04T17:14:10.306Z	INFO	rateengine/nonlinehaul.go:191	sit calculation: B96BKK	{ detailsHere }
2020-02-04T17:14:10.306Z	INFO	rateengine/rateengine.go:158	PPM cost computation: B96BKK	{ detailsHere }
in this case, the move locator is B96BKK
Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

I have no problem using... zap.String("LocatorID", moveID)
I addled it to the msg since I knew for we can search on that field and it worked, but I'm find putting it in the { } but I'll test first...
I also want to test on experimental before merging...

@chrisgilmerproj oh, that's much better - just tested and def. going to update this! thanks

@chrisgilmerproj oh, that's much better - just tested and def. going to update this! thanks

Oh good! Also, do you want to update the examples in the description of the PR?


Add config.py for logging and database connection

Logging and DBconnection

Connection is hardcoded.
Functions for setting a config.ini is included but not used!


No data in datasource if field required

The data will only be in the datasource if the field is fully optional. As soon as all or 1 language is required, the data will not be in the datasource. Probem is similar to the one that was in multilingual image upload

Should be fixed in 2.0.2


Add page with list of trove classifiers

For package authors, we will need to add a list of all trove classifiers.  I am not sure where this is best placed - maybe in the footer?
ping @dstufft for an opinion on this.

Note - to keep things consistent, we can again use a tree (see #1299) for rendering the classifiers on the page.

Is this really a page that belongs on the PyPI site?
PEP 301 calls them distutils trove classifiers. Maybe a better place to give more information about those to the package authors would be the Python Packaging User Guide?

Yes, sure.  I am not opposed to moving it out of the site and into the docs.  I do think we need to continue to link directly to it though, as this is something that is currently done on PyPI (so users may be accustomed to finding the list via this link).

It's valuable to have the list in a convenient plain form, not embedded in HTML docs, for tools to fetch. Flit does this, for instance. The list changes often enough (e.g. adding new frameworks) that I don't want to bundle a static copy.
At present it seems you can get this from the legacy API at https://pypi.org/pypi?%3Aaction=list_classifiers - can we rely on that URL working for the foreseeable future?

Yes that will continue to work, although ideally for automated consumption we come up with some newer, better JSON based API.

Great, thanks. There's no pressure from my side for a JSON version of this unless someone makes a classifier with a newline in.

would a file in the specifications section of the PyPUG and/or some other PyPA repo that anyone can submit a PR to be a better primary data source for this information than the PyPI database?

As an additional data point, doing this would be more transparent and would make issues like this easier to address.

I agree with @ncoghlan - we should have some canonical location for this that's easy to modify.
Could we pull these classifiers out of the warehouse database and just store them in a datafile in this repository?
Alternatively, I could see us establishing a new project that holds the canonical list that warehouse and pypug depends on.
Related: #3028

Easy to modify isn't exactly ideal here, there are a few different types of modifications you can make:

Addition: This is easy to cope with, since it's purely addition, Warehouse can simply add it.
Deletion: This is less easy to cope with, because there are really two kinds of deletion possible:

Deletion where we want to expunge the record from all releases. This is technically easy, but unlikely to actually be what we want (and it would make the PyPI metadata and the package metadata disagree, which is undesirable)
Deletion where we simply want to disallow new uploads, containing the classifier, but still want to retain it for historical record.

Rename: This is hard to deal with, because you don't want to suddenly start rejecting previous versions of the classifier, it would break people's uploads for little reason, but you want to treat the old and the new name as equivalent.

This also makes a simple text file not really well suited for it, because you can't really different between deletion to expunge from deletion to block from renames. In addition, internally in Warehouse (and legacy PyPI) the trove classifiers are represented as a rows in a database that we foreign key against, so something that we depend on isn't going to be a workable solution unless we do something janky like try to automatically reconcile our database against that dependency (which then starts to get into all of the problems I listed above with having to figure out what sort of change it was made).
Beyond all of that though, regardless of what we call the list in some other location or the list inside of the DB the "canonical" location, practically speaking, PyPI is going to be the defacto canonical location in every way that anyone actually cares about (since 99% of the time, what someone cares about when looking at classifiers, is whether PyPI will accept them or not).
Ultimately, I think the canonical location being on PyPI makes things easier to maintain and manage and it allows us to provide a better user experience for end users as well. It lets us put structured data in the database, while providing a UI to actually manage it that glosses over the details of actually managing that structured data. It also lets us tailor what the list we give people contains, based on what the context of us giving them that list is. For example, in documentation we would almost certainly exclude any legacy aliases for renamed classifiers or deleted classifiers that we still have the record for but are no longer accepting, but for an API endpoint that something like flit might call, we'd want to include all of the classifiers we are currently accepting (legacy alias or not) but none of the ones that we are not. I imagine there'd even be an API that reports all classifiers past and present and their current status.

Thanks @dstufft, given that extra information, I agree it makes sense to have the database remain the official classifier listing, with various APIs to extract the current state of the list.

So the question is now is how should we bring the legacy API forward to
provide this canonical list via both an API and UI in Warehouse?
On Sat, Mar 24, 2018, 10:06 PM Nick Coghlan<EMAIL_ADDRESS>wrote:

Thanks @dstufft https://github.com/dstufft, given that extra
information, I agree it makes sense to have the database remain the
official classifier listing, with various APIs to extract the current state
of the list.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pypa/warehouse/issues/1300#issuecomment-375945949,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUczWy8EYMBcpUIPF8DMXTneTWflFRks5thyXOgaJpZM4JB0d8
.

Since https://pypi.org/pypi?%3Aaction=list_classifiers works adequately I'm moving this out of the "Shut down legacy PyPI" milestone and into the milestone of work that can happen after April 30th. But @waseem18 and other volunteers should continue to work on this and related trove classifier display issues if they would like to!

We can change the legacy API to return JSON (or build a new API) and use that to populate the UI. So is the new UI going to be a part of PyPI or will it go under  Python Packaging User Guide?

Please do build that as a new endpoint (a different URL), and leave the legacy API returning a plain text list - there's code that fetches the list from that legacy API, and changing it to JSON would break that.
(It could be smart and look at the 'Accept' request header to decide which format to return. But I think it's better to build the modern API at a nicer URL anyway.

Yup. I'll go ahead with creating a new API.

There is an existing for getting classifiers via the JSON API: https://github.com/pypa/warehouse/issues/1244

The page is now at http://pypi.org/classifiers . Thanks @di.

@brainwane, @di and all: is there a place where the suggestion made by @ncoghlan above:

would a file in the specifications section of the PyPUG and/or some other PyPA repo that anyone can submit a PR to be a better primary data source for this information than the PyPI database?

...could be tracked, e.g. by opening a new issue? Or has that already been decided against?
FWIW, I still think that a public and collaborative ("PR-able") data source would be preferable to a private database table. At least the table definitions for recreating the database could be made available in a repo somewhere, similar to https://noc.wikimedia.org, and for similar reasons.

I withdrew the basic suggestion of a flat text file based on Donald's comments at https://github.com/pypa/warehouse/issues/1300#issuecomment-375945558
That doesn't rule out the possibility of a "classifier log" format though, that tracks the possible operations as a series of historical events:

addition of new classifiers
renaming of classifiers
prohibition of a classifier in new uploads (rare)
removal of a classifier from all published metadata records (incredibly rare due to the resulting inconsistent with the artifact's internal metadata)

The way to pursue the idea further would be as a new issue proposing to derive the contents of the classifier table from a source controlled log of classifier changes, and then after discussing a suitable design with the Warehouse devs, working on a PR to actually implement that.

@ncoghlan thanks for the detailed response. I'll open a new issue, then. Until that process is completed, though, could you clarify what process is currently in place for tackling edits like this proposed change?


Using baselines for transpile unittests

This is the change already existed in "transforms" branch. It used baselines for Transpile unittest.
There are couple reasons I am porting the change to master:

making merging between "master" and "transforms" easier as currently each test has to be manually ported which can cause some tests to be missing

making adding new Transpile tests much easier (which I will have to do to fix one of the bug)

👍


undefined method `preference' for Spree::Recurring(Table doesn't exist)

I get the following error when trying to run the install generator:
https://gist.github.com/dpmccabe/c53aeecc2b4c7b23e6c8
I'm using the 2-3-stable branch of all the Spree gems on a Rails 4.1.4 app with MRI 2.1.2 on a newly-created app. Is this a versioning issue?

+1, there is already a pull request on the queue (I did not tested it).

+1

+1 same error

New version is released for spree 2-3-stable.
Branch: 2-3-stable
version: 1.2.x

@aaronzdavis  Also released support for 2.4.
Branch: 2-4-stable
version: 1.3.x

@priyank-gupta i think we can close this issue.