Race Condition: Transaction Order Dependence in WitnetRequestBoard

Finding discovered during Red4Sec security audit.
Description
There is a Transaction Order Dependence vulnerability in the WitnetRequestBoard contract leading to a race condition.
The reportResult function implements numerous entries to verify the TallyPoi, however, none of them is related to the sender of the transaction, therefore, anyone who issues a transaction with such information to the blockchain, will be the first to execute its logic. Furthermore, on line:245 of WitnetRequestBoard.sol file, funds are sent to the sender's account, which allows obtaining an economic benefit (acquiring the response fee) by exploiting the vulnerability.
In the following image, we can see that there is no verification to confirm that the sender is legitimate.

Impact
Allows an attacker to obtain the fee reward on a recurring basis without doing any work.

Steps to reproduce
In order to exploit this vulnerability, we have developed a tool that listens for all the existing transactions in the memory pool. As soon as it detects that a transaction has been received with the following characteristics;

Destination:  0x72cf2dff1cf373ad818b37d8196c9d372a8f2ade (WitnessRequestBoard - WRB).
MethodId: 0x8a68f33e (reportResult).

it will automatically generate an identical transaction (copying all the values from the original) but using a higher gas price.
In this way we prioritize our transaction and ensure that it has more possibilities to enter before the original bridge transaction, thus receiving the result fee without having done any work.

Next, we can see how the attacker's transaction has copied all the input values of the original, except for the gasPrice that has been multiplied by 2. This allows us to gain priority and therefore our transaction will be entered before the original transaction despite being sent later.
https://goerli.etherscan.io/tx/0xdfb86100dcf4d22533d6b7a813770b8ab793d4774c375b72211d79e3a03c2799
In the following link we can check how the original transaction, despite entering the same block (2489093), is processed after the attacker's, which returns the following error: "Result already included".
https://goerli.etherscan.io/tx/0xa533545c9b930fabffb37ba466b19e45ca4ac37ed8f452633fd7880b85f1d724

Code References
https://github.com/witnet/witnet-ethereum-bridge/blob/9d1f3be651ac644056303d18c20eecc4fc490472/contracts/WitnetRequestsBoard.sol#L244
https://github.com/witnet/witnet-ethereum-bridge/blob/9d1f3be651ac644056303d18c20eecc4fc490472/contracts/WitnetRequestsBoard.sol#L245

Mitigation
To avoid this type of attack, it is necessary that the PoI validation include the sender's address to avoid this type of attack.

Mitigation: the approach is to limit the report result to the members of the active bridge set (ABS), as these nodes have already proven lately activity. Furthermore, a node is added to the ABS when reporting a data request inclusion, so it makes sense they are also in charge of reporting the result, completing the data request cycle.


Hotfix apikey travisupdate

Coverage remained the same at 51.309% when pulling 78704ff27e33a5b6f64f8b92a88ac8dcb323b3e0 on hotfix-apikey-travisupdate into 92a8650aa6874bdebe01b76d9fbdea54c43ad16d on master.

Coverage remained the same at 51.309% when pulling 78704ff27e33a5b6f64f8b92a88ac8dcb323b3e0 on hotfix-apikey-travisupdate into 92a8650aa6874bdebe01b76d9fbdea54c43ad16d on master.


Alternative for solving ipBlock problem instead of using CiliumNetworkPolicies

To summarize the problem, we can't use networkpolicies with ipBlock like this, because cilium does not support them (and won't):
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
...
spec:
  egress:
  - to:
    - ipBlock:
        cidr: <IP_ADDRESS>/8
...

In GiantSwarm apps we do this for mainly two reasons:

allow pods in giantswarm and kube-system to talk to the API server
allow pods in giantswarm and kube-system to talk to other nodes (mainly for scraping metrics)

We discussed this problem in https://github.com/giantswarm/giantswarm/issues/23014 and we decided to use CiliumNetworkPolicies alongside NetworkPolicies to cover this use case, but it's a monster job and it costs vendor lock-in.
Alternative idea: whenever we use ipBlock for egress we whitelist all egress instead, like we do for some apps (chart operator and others) already, like this:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
...
spec:
  egress:
  - {}
...

This is a little bit less secure, but allows us to avoid the vendor lock-in and be more confident about the result in our own apps.
Still to be checked: do we have the same problem for ingress as well?

Closing this ticket - we will keep our apps secured as they were with more effort and work with customers such that the upgrade is not a vulnerability. tickets will come towards customers


JOB_TIMEOUT is not used in the kube-burner e2e tests

The wait_for_benchmark function in the kube-burner common.sh does not have any timeout so it could run forever. We have an environment variable that gets set at the top of the file (JOB_TIMEOUT) but do not ever use it in the script.

CC: @rsevilla87 @chaitanyaenr

@dry923, JOB_TIMEOUT is actually used as timeout of the kubernetes job.
https://github.com/cloud-bulldozer/e2e-benchmarking/blob/master/workloads/kube-burner/kube-burner-crd.yaml#L31
However, as you mentioned, we should make use of this variable in the overall script as well to avoid getting stuck in case of failure in a previous phase, will fix that ;)


fix change scancode-toolkit version in header_cleanser

Why are these changes needed?
To fix this failing build.
Related issue number (if any).

Hi, @shivdeep-singh-ibm I was trying to fix a notebook that @ykalathiya has created for this transform in #845 and saw a problem with pip installing scancode-toolkit. The way I fixed that notebook was to pip install scancode-toolkit without any version number and it installed the latest version of scancode-toolkit for my venv and everything worked. Is there any problem if we don't specify the version number in the requirements.txt and the pyproject.toml files for this transform?


BUG: fixing TabularDataResource -> DataFrame transformer to allow for single donor in group_timepoints

A note on this PR - an additional test will need to be added within q2-FMT for this functionality. The existing test found here does not utilize the transformer since it starts with a blank dataframe (vs. starting with an artifact)


SharePoint rest api for Pages and events

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
SharePoint REST API
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Issue description
I am looking for rest apis to create Pages and events in sharepoint Online and oprem version , Could you please help me with the same. So far not able to get anything in the Documents for Pages

Events can be created/modified using the standard SharePoint REST API or with Graph (in SPO)
https://learn.microsoft.com/en-us/sharepoint/dev/sp-add-ins/working-with-lists-and-list-items-with-rest
https://learn.microsoft.com/en-us/graph/api/resources/listitem?view=graph-rest-1.0
Pages are a bit more complex. On-Premises, no API exists for working with pages. In SPO, AFAIK, I don't believe a SharePoint REST API exists directly. Microsoft Graph is working on a Page API, which is currently in Beta.
https://learn.microsoft.com/en-us/graph/api/resources/sitepage?view=graph-rest-beta


fix: Updating the Changelogs for react and web components

:tada: This PR is included in version 4.0.0-alpha.139 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.178 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.17 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Pagination

Hey, have you checked pagination? I found an issue when using this clean url module pagination is wrong. For example, im in A category where I could see: 34 products. Default pagination - 12 products/page. On second page I see only 11 products and on 3rd page - i can open it but nothing here. Any solution?

What version of PS, whar bersion of the module, any other info?
Of course pagination should habe nothing to do with id removal .. so plz
provide more info in orther to argue what is the problem in your scenario
Il sabato 19 settembre 2015, mantasl<EMAIL_ADDRESS>ha scritto:

Hey, have you checked pagination? I found an issue when using this clean
url module pagination is wrong. For example, im in A category where I could
see: 34 products. Default pagination - 12 products/page. On second page I
see only 11 products and on 3rd page - i can open it but nothing here. Any
solution?
—
Reply to this email directly or view it on GitHub
https://github.com/ZiZuu-store/zzCleanURLs/issues/15.

--
Cordialmente,
Massimo -- the ZiZuu staff

Plz tell me a real world URL I can inspect too

Hey, man,
sorry, I could answer you right now.
Module version: latest. I have reuploaded all files a day ago.
Check this live URL: http://imuperku.lt/auto/aksesuarai-ir-priedai/?p=2
Sorry for language. But you can see that in this category 34 products. But
in second page I can see only 11 products. Sum = 23 products and 3rd page -
blank.
Thanks for any help man!
2015-09-20 12:30 GMT+03:00 ZiZuu.com<EMAIL_ADDRESS>
Plz tell me a real world URL I can inspect too
—
Reply to this email directly or view it on GitHub
https://github.com/ZiZuu-store/zzCleanURLs/issues/15#issuecomment-141762778
.

What you mean with latest?
Downloaded the zip from github?
Plz gimme your PS version and any other meaningful info
Tnx

Latest: yes I downloaded all files and reuploaded to override folder. Old
files replacted to new.
My PS version: 1.6.14
What other information do you need? I gave you url with example, could you
check this? What other information could I give you?
2015-09-20 12:47 GMT+03:00 ZiZuu.com<EMAIL_ADDRESS>
What you mean with latest?
Downloaded the zip from github?
Plz gimme your PS version and any other meaningful info
Tnx
—
Reply to this email directly or view it on GitHub
https://github.com/ZiZuu-store/zzCleanURLs/issues/15#issuecomment-141767804
.

What theme are you using? .. pagination should be handled by the theme ..
Can't argue how ID removal could apply .. btw, I'm going to take a look to your link

Pagination seems not to be the root problem in your site:
http://imuperku.lt/auto/aksesuarai-ir-priedai/?id_category=87&n=34  -> only 23 products displayed
http://imuperku.lt/auto/aksesuarai-ir-priedai/?id_category=87&n=60  -> 23 products displayed even if 60 per page is selected ..
AFAICS my module should have nothing to do with this behaviour ...
Removing it makes other products appear? .. please let me see :)

@mantasl plz try the new release ..
Going to close if no news ..

Hey, ZiZu,
after classess override Link n dispatcher I got 404 error when I visit
category page.
I reuploaded a new files from GitHub.
2015-09-24 0:18 GMT+03:00 ZiZuu.com<EMAIL_ADDRESS>
@mantasl https://github.com/mantasl plz try the new release ..
Going to close if no news ..
—
Reply to this email directly or view it on GitHub
https://github.com/ZiZuu-store/zzCleanURLs/issues/15#issuecomment-142731337
.

I don't understand .. please join me on chat at https://gitter.im/ZiZuu-store/zzCleanURLs

No feedback given ... Can't reproduce
Closing


Moving a model from one library to another fails

Describe the bug
A model added in one library that you edit and try to move into another existing library displays an application error
To Reproduce
Steps to reproduce the behavior:

Open a model
Edit it
Change the library
Application error

Expected behavior
The model moves succesfully between libraries in UI, database and folder structure
Screenshots
https://github.com/manyfold3d/manyfold/assets/6213695/d50281c0-2e02-4163-a8f5-1b41417504e2
Desktop (please complete the following information):

OS: macOS
Browser: Arc (Chromium)
Version: Latest

Additional context
The logs (docker compose logs -f) do not show any relevant info:
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [a53f3fa0-99ed-4952-aac5-66b984b7d466] from DelayedJob(manyfold_production_default) with arguments: [1] (id=7) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [a53f3fa0-99ed-4952-aac5-66b984b7d466] from DelayedJob(manyfold_production_default) with arguments: [1] (id=7) (queue=manyfold_production_default) COMPLETED after 0.0611
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelScanJob [44503e55-a46c-4f70-bfe6-4a3a705efb65] from DelayedJob(manyfold_production_default) with arguments: [2] (id=8) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelScanJob [44503e55-a46c-4f70-bfe6-4a3a705efb65] from DelayedJob(manyfold_production_default) with arguments: [2] (id=8) (queue=manyfold_production_default) COMPLETED after 0.1430
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [1e1b20e5-1881-43db-bc13-316db0b310b7] from DelayedJob(manyfold_production_default) with arguments: [2] (id=9) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [1e1b20e5-1881-43db-bc13-316db0b310b7] from DelayedJob(manyfold_production_default) with arguments: [2] (id=9) (queue=manyfold_production_default) COMPLETED after 0.0249
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [f615d2cd-2fde-4048-9079-bda9b3d623ab] from DelayedJob(manyfold_production_scan) with arguments: [2] (id=10) (queue=manyfold_production_scan) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [f615d2cd-2fde-4048-9079-bda9b3d623ab] from DelayedJob(manyfold_production_scan) with arguments: [2] (id=10) (queue=manyfold_production_scan) COMPLETED after 0.0507
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] 4 jobs processed at 12.7329 j/s, 0 failed
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [325f64eb-8741-40a9-a4bb-2a1f818bd863] from DelayedJob(manyfold_production_default) with arguments: [2] (id=11) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [325f64eb-8741-40a9-a4bb-2a1f818bd863] from DelayedJob(manyfold_production_default) with arguments: [2] (id=11) (queue=manyfold_production_default) COMPLETED after 0.0613
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelScanJob [cbdb9a63-0c8b-450c-b2a4-ccb491c36eda] from DelayedJob(manyfold_production_default) with arguments: [3] (id=12) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelScanJob [cbdb9a63-0c8b-450c-b2a4-ccb491c36eda] from DelayedJob(manyfold_production_default) with arguments: [3] (id=12) (queue=manyfold_production_default) COMPLETED after 0.1588
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [5a8ec253-4a3a-456a-a593-277a5cb64cc5] from DelayedJob(manyfold_production_default) with arguments: [3] (id=13) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [5a8ec253-4a3a-456a-a593-277a5cb64cc5] from DelayedJob(manyfold_production_default) with arguments: [3] (id=13) (queue=manyfold_production_default) COMPLETED after 0.0258
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [d58214e7-6dd3-40ab-acaf-a78bb0ccc8ca] from DelayedJob(manyfold_production_default) with arguments: [4] (id=14) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job ModelFileScanJob [d58214e7-6dd3-40ab-acaf-a78bb0ccc8ca] from DelayedJob(manyfold_production_default) with arguments: [4] (id=14) (queue=manyfold_production_default) COMPLETED after 0.0224
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [3c1c2e90-84cd-429a-bc10-94958b4022fc] from DelayedJob(manyfold_production_scan) with arguments: [3] (id=15) (queue=manyfold_production_scan) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [3c1c2e90-84cd-429a-bc10-94958b4022fc] from DelayedJob(manyfold_production_scan) with arguments: [3] (id=15) (queue=manyfold_production_scan) COMPLETED after 0.0447
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [71150f63-49a9-412c-a123-53b512ebda93] from DelayedJob(manyfold_production_scan) with arguments: [4] (id=16) (queue=manyfold_production_scan) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::AnalyseModelFileJob [71150f63-49a9-412c-a123-53b512ebda93] from DelayedJob(manyfold_production_scan) with arguments: [4] (id=16) (queue=manyfold_production_scan) COMPLETED after 0.0421
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] 6 jobs processed at 14.8544 j/s, 0 failed
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [a34c295c-e8a2-47c1-bf84-2e18d7032c10] from DelayedJob(manyfold_production_default) with arguments: [2] (id=17) (queue=manyfold_production_default) RUNNING
manyfold_app    | 08:52:39 worker.1 | [Worker(host:243236280e08 pid:40)] Job Scan::DetectFilesystemChangesJob [a34c295c-e8a2-47c1-bf84-2e18d7032c10] from DelayedJob(manyfold_production_default) with arguments: [2] (id=17) (queue=manyfold_production_default) COMPLETED after 0.1289
manyfold_db     | 2024-03-06 12:02:40.370 UTC [64] LOG:  checkpoint starting: time
manyfold_db     | 2024-03-06 12:02:41.807 UTC [64] LOG:  checkpoint complete: wrote 15 buffers (0.1%); 0 WAL file(s) added, 0 removed, 0 recycled; write=1.409 s, sync=0.011 s, total=1.438 s; sync files=15, longest=0.008 s, average=0.001 s; distance=1 kB, estimate=749 kB

Thanks for reporting! I'll check this out immediately.

Interesting, it works here in dev. I note that you're running v0.57.1? I released .2 yesterday with a few bug fixes; I don't think any of them are related to this, but could you update and give it a go? In the meantime, I'll carry on trying to replicate.
There may be relevant info in the logs tab of the Advanced Admin area, too.

Same deal when I try with .2 version. This is what I found in the logs:
I, [2024-03-06T13:29:19.724323 #91]  INFO -- : [fd67224a-5f34-4940-860e-ebebd2a39ce0] method=GET path=/libraries/2/models/4/edit format=html controller=ModelsController action=edit status=200 allocations=26246 duration=227.06 view=105.81 db=58.72
I, [2024-03-06T13:29:25.935285 #73]  INFO -- : [6073742d-c37b-4f82-acf8-aa04dba90485] method=PATCH path=/libraries/2/models/4 format=html controller=ModelsController action=update status=500 allocations=18663 duration=223.25 view=0.00 db=72.28
F, [2024-03-06T13:29:25.938301 #73] FATAL -- : [6073742d-c37b-4f82-acf8-aa04dba90485]
[6073742d-c37b-4f82-acf8-aa04dba90485] Errno::EXDEV (Cross-device link @ rb_file_s_rename - (/libraries/inbox/Nest Mini Stand Model, /libraries/printed/Nest Mini Stand Model)):
[6073742d-c37b-4f82-acf8-aa04dba90485]
[6073742d-c37b-4f82-acf8-aa04dba90485] app/models/model.rb:166:in `rename'
[6073742d-c37b-4f82-acf8-aa04dba90485] app/models/model.rb:166:in `move_files'
[6073742d-c37b-4f82-acf8-aa04dba90485] app/controllers/models_controller.rb:48:in `update'

My volumes are linked like this with Docker:
volumes:
  - /mnt/nas_data/3d-print/manyfold/inbox:/libraries/inbox
  - /mnt/nas_data/3d-print/manyfold/printed:/libraries/printed

Whoa, Errno::EXDEV, that's a new one on me! Looking that up, it's because I'm using rename rather than move, and you can't do that across different disks. And because your two libraries are mapped separately, they come up as different devices. Nice edge case!
So, to solve it straight away, you could change your docker mapping so that both libraries are in the same volume - as they're both in the same place on your NAS you don't actually need to map them separately. You shouldn't need to make any changes inside Manyfold either as the paths will stay exactly the same.
volumes:
  - /mnt/nas_data/3d-print/manyfold:/libraries

Then in the longer term, I should change to move rather than rename, because having the different libraries on different devices is totally a valid thing to do!

Thanks this indeed worked by only mapping the volume once!

Gonna reopen this to remind me to make it handle the situation properly; glad you got it working!

This should be permantently fixed by the changes in v0.71.0. 👍


refactor: from superset.utils.core break down date_parser

SUMMARY

The superset.utils.core  is too large and difficult to maintain, so break down date_parser.py
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
UT to the new place
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12408 (a08944f) into master (ff7b789) will decrease coverage by 6.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12408      +/-   ##
==========================================
- Coverage   66.88%   60.71%   -6.18%
==========================================
  Files        1014      529     -485
  Lines       49513    19607   -29906
  Branches     5077     5077
==========================================
- Hits        33118    11904   -21214
+ Misses      16264     7493    -8771
- Partials      131      210      +79

Flag
Coverage Δ

cypress
?

javascript
60.71% <ø> (ø)

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7b789...9add899. Read the comment docs.

Codecov Report

Merging #12408 (a08944f) into master (ff7b789) will decrease coverage by 6.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12408      +/-   ##
==========================================
- Coverage   66.88%   60.71%   -6.18%
==========================================
  Files        1014      529     -485
  Lines       49513    19607   -29906
  Branches     5077     5077
==========================================
- Hits        33118    11904   -21214
+ Misses      16264     7493    -8771
- Partials      131      210      +79

Flag
Coverage Δ

cypress
?

javascript
60.71% <ø> (ø)

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7b789...9add899. Read the comment docs.

this is beyond my ability to review. 😅
@graceguo-supercat thanks for reviewing!
@ktmud can you take another look and merge it if everything looks ok?

this is beyond my ability to review. 😅
@graceguo-supercat thanks for reviewing!
@ktmud can you take another look and merge it if everything looks ok?

CI is green so this is probably safe.

CI is green so this is probably safe.


🚅 chore: Added an Example of Nginx gzip Settings

Summary
I have added an example gzip settings to nginx.conf.
Details
LibreChat currently requires loading nearly 4MB of JavaScript before the initial screen is displayed, causing delays, especially on slower connections. To address this, I’ve added configuration options to compress transferred files in nginx.conf.
Refer to this documentation for more details:

How To Improve Website Performance Using Gzip and Nginx on Ubuntu 20.04 - DigitalOcean

Note that this PR does not include font or image compression, as they are typically already compressed and would offer minimal benefits relative to server load.
the Lighthouse metrics without gzip enabled:

the Lighthouse metrics with gzip enabled:

Transfer size without gzip enable:

Transfer size with gzip enable:

This configuration significantly reduces transfer sizes.
In the future, we might want to consider code splitting to improve the initial loading time. For now, this configuration should significantly improve performance.
Change Type

[x] Chore - Added an example configuration
[x] This change requires a documentation update

Testing
I have confirmed that the file transfer size is reduced when this setting is enabled.
Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] I have commented in any complex areas of my code
[x] I have made pertinent documentation changes
[x] My changes do not introduce new warnings

thank you!

I agree, a more thorough review of the bundle size and how to optimize it is in order


[suggestion] Upload models to HuggingFace transformer database

The NLP startup HuggingFace is specialising in transformer models, and they've created a database full of pretrained models, to which you might be interested in uploading your models as well:
https://huggingface.co/models
It would then be simple to use your models, using their transformers python library:
from transformers import AutoTokenizer, AutoModelWithLMHead
tokenizer = AutoTokenizer.from_pretrained("botxo/danish_bert_uncased_v2")
model = AutoModelWithLMHead.from_pretrained("botxo/danish_bert_uncased_v2")

There are already a decent chunk of Swedish models and a couple of Finnish ones, but no Danish or Norwegian ones yet.
This is just a heads up in case you didn't already know about this! (I'm not affliated with HuggingFace in any way)

Thanks for the suggestion! We're still considering how to best publish these models. Training them requires significant resources, so business understandably wants to ensure that we're receiving some form of recognition. This will be an ongoing discussion on our part - but in short, it's a business decision.

To follow up on this, is there a possibility of seeing these models on HuggingFace?  It's a super convenient way to organize all of the transformers in the world, although admittedly the only exposure Certainly would get would be the name of the model

To follow up on this, is there a possibility of seeing these models on HuggingFace?  It's a super convenient way to organize all of the transformers in the world, although admittedly the only exposure Certainly would get would be the name of the model

The Danish model was published at https://huggingface.co/Maltehb/danish-bert-botxo (BotXO was Certainly's previous name). Not sure about the others.

excellent, ty!


k8s 1.19 removes basic auth but it's in use by kontainer-engine

Kubernetes 1.19 is removing support for Basic Auth. However, it looks as though kontainer-engine is actually using it: https://github.com/rancher/kontainer-engine/blob/65780a8839e471d3842580d5d9075ae9a3b70a02/drivers/gke/gke_driver.go#L901-L909 in the GKE driver. This would appear to mean that it won't be possible to use kontainer-engine to create k8s 1.19+ clusters in GCP, as it'll fail to bootstrap its service account.
E-mail from Google:

We are writing to let you know that upstream Kubernetes open source has removed support for basic authentication in version 1.19 (v1.19). Once Google Kubernetes Engine (GKE) upgrades your clusters to v1.19, you will no longer be able to use basic authentication. You will still be able to authenticate to GKE using other methods.
What do I need to know?
Kubernetes has announced that basic authentication will no longer be available starting with Kubernetes v1.19. GKE clusters will also no longer support basic authentication as they gradually upgrade to Kubernetes v1.19:

Clusters subscribed to the rapid release channel will begin upgrades on or after January 2021
Clusters subscribed to the regular release channel will begin upgrades on or after March 2021.
Clusters subscribed to the stable release channel and non-release-channel clusters will be upgraded later in 2021; a reminder will be sent before these clusters are upgraded to v1.19

This is also impacting GKE cluster edit operations in my case which are stuck in constant reconciling until I re-enable basic authentication for the cluster via GKE UI / gcloud.
Reproducible Test Scenario

Disable basic-auth as recommened via gcloud container clusters update CLUSTER_NAME --no-enable-basic-auth
In Rancher UI -> Edit Cluster (using same SA credentials as on initial cluster setup)
Trigger some operational change (e.g. update master cluster version)
Rancher will trigger the update (verified in GKE UI), but is stuck with failedSpec error-msg:
Namespaces is forbidden: User "system:anonymous" cannot create resource "namespaces" in API group "" at the cluster scope
Rancher triggers constant reconciling cluster updates which lead to unavailability of the cluster for management
Re-enable basic-auth via gcloud container clusters update CLUSTER_NAME --enable-basic-auth
Reconciliation stops and Rancher will recover to active state

Reproduced the issue with 2.5.1
repro steps.

Disable basic-auth as recommened via gcloud container clusters update CLUSTER_NAME --no-enable-basic-auth

In Rancher UI -> Edited the Cluster (using same SA credentials as on initial cluster setup)

Triggered the operational (e.g. update master cluster version)
Rancher will trigger the update (verified in GKE UI), but is stuck with failedSpec error-msg:

Enable the auth>gcloud container clusters update CLUSTER_NAME --enable-basic-auth --region=us-central1-f

It took a while for the rancher to reconcile and restored itself to the active state

Verified the fix with v2.5-7ef17a7a3c251d3e7d21f4a729edbcdff055e686-head
Steps used to verified.

Created gke cluster

disable the auth> gcloud container clusters update clustername --no-enable-basic-auth --region=region-name

Edit the cluster using the same SA value and perform master cluster update operation by updating Kubernetes verion

Notice some intermittent error

Finally the error went away and the Kubernetes version was updated to the select version.

@thedadams
Looks like the fix is working, not sure about the intermittent error, if it's a concern please let me.

Reopening to validate on master-head

Verified the issue with master-head, master-5aa39182429d810be1278b294aeb396a70fe28aa-head
Steps used to verified.

Created gke cluster
disable the auth> gcloud container clusters update clustername --no-enable-basic-auth --region=region-name
Edit the cluster using the same SA value and perform master cluster update operation by updating the Kubernetes version
Kubernetes version upgrade was successful.
After a while seeing an error message on UI that cluster health check is failing. The error message remains persistent on the cluster.

@thedadams @sadiapoddar after looking into a few things, this will need to get backported to 2.4 also.

@cbron @thedadams once you merged the fix with 2.4.x, let me know I will verify on that branch.
Thanks,
-Sadia

Tried to reproduce with the same steps, but couldn't repro
v2.5-9ee39b9 and master-a549b47

Created gke cluster
disable the auth> gcloud container clusters update clustername --no-enable-basic-auth --region=region-name
Edit the cluster using the same SA value and perform master cluster update operation by updating the Kubernetes version
Kubernetes version upgrade was successful.
Noticed this error message, not the cluster authorization

Eventually, the above error message went away and the cluster became healthy.

verified the fix on master-head, 1dbf17f and   2.5-head, be9683f

Created gke cluster
Disabled the auth> gcloud container clusters update clustername --no-enable-basic-auth --region=region-name
Edited the cluster using the same SA value and perform master cluster update operation by updating the Kubernetes version
Kubernetes version upgrade was successful.
Enabled back the auth and did auto-scaling cluster operation
Disabled the auth and created some namespaces, workload, services etc
There was no authorization error.

Closing the bug as the fix is working.

verified the fix on master-head, 1dbf17f and   2.5-head, be9683f

Created gke cluster
Disabled the auth> gcloud container clusters update clustername --no-enable-basic-auth --region=region-name
Edited the cluster using the same SA value and perform master cluster update operation by updating the Kubernetes version
Kubernetes version upgrade was successful.
Enabled back the auth and did auto-scaling cluster operation
Disabled the auth and created some namespaces, workload, services etc
There was no authorization error.

Closing the bug as the fix is working.


Deploy the NPM package from a CI box so we know exactly what commits are in it

https://rlynetworkassociation.slack.com/archives/C03UT3S83JL/p1686241343876379

https://rlynetworkassociation.slack.com/archives/C03UT3S83JL/p1686241774511409


Enable spotbugs and fix high priority bugs

What changes were proposed in this pull request?

Enable (previously experimental) spotbugs check in CI.
Set spotbugs to only check high priority bugs.
Because currently there are too many medium (default) priority bugs,
and many of them are difficult to fix.
Fix bugs reported by spotbugs.

Why are the changes needed?
To improve code quality.
Does this PR introduce any user-facing change?
One notable change is we are comparing content instead of reference of the array in ShufflePartitionedBlock#equals(), see: a994cffed033158bfbd84d5b83e900892b739c18. We can revert it if it's not desired.
Another is toString() methods will call Arrays.toString() instead of printing array reference as string now.
How was this patch tested?

mvn test-compile spotbugs:check -Pspark3
mvn test-compile spotbugs:check -Pspark2
mvn test-compile spotbugs:check -Pmr

Also by CI: https://github.com/kaijchen/incubator-uniffle/actions/runs/2634089750

Codecov Report

Merging #38 (8f0e85c) into master (37beb1f) will decrease coverage by 0.90%.
The diff coverage is 77.55%.

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
- Coverage     56.83%   55.93%   -0.91%
+ Complexity     1204     1131      -73
============================================
  Files           152      143       -9
  Lines          8401     8034     -367
  Branches        813      784      -29
============================================
- Hits           4775     4494     -281
+ Misses         3368     3290      -78
+ Partials        258      250       -8

Impacted Files
Coverage Δ

.../java/org/apache/uniffle/common/BufferSegment.java
96.15% <0.00%> (-3.85%)
:arrow_down:

...apache/uniffle/common/ShufflePartitionedBlock.java
35.29% <0.00%> (-1.07%)
:arrow_down:

.../apache/uniffle/common/ShufflePartitionedData.java
0.00% <0.00%> (ø)

...org/apache/uniffle/common/config/ConfigOption.java
60.86% <0.00%> (-2.77%)
:arrow_down:

...java/org/apache/uniffle/common/config/RssConf.java
28.37% <0.00%> (-0.59%)
:arrow_down:

...niffle/storage/common/FileBasedShuffleSegment.java
51.51% <ø> (-1.43%)
:arrow_down:

.../org/apache/uniffle/common/config/ConfigUtils.java
22.36% <60.00%> (ø)

.../java/org/apache/hadoop/mapreduce/RssMRConfig.java
85.71% <100.00%> (-5.20%)
:arrow_down:

.../org/apache/uniffle/common/config/RssBaseConf.java
91.80% <100.00%> (ø)

...rg/apache/uniffle/coordinator/CoordinatorConf.java
96.15% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37beb1f...8f0e85c. Read the comment docs.

It is better to move '3. Fix bugs reported by spotbugs' in another PRs to make this PR more independent.

It is better to decouple '3. Fix bugs reported by spotbugs' in another PRs to make this PR more independent.

If we only include 1 and 2, the CI will fail.
If we only include 3, how do you know these bugs will be reported by spotbugs (and there is nothing more)?

It is better to decouple '3. Fix bugs reported by spotbugs' in another PRs to make this PR more independent.

If we only include 1 and 2, the CI will fail. If we only include 3, how do you know these bugs will be reported by spotbugs (and there is nothing more)?

It is possible to make this checker won't  break CI?  If some changes are not what we really wanted.

All the changes in this PR is necessary to fix a problem reported by the checks.
Please refer to individual commit names to see why it is needed.

It is possible to make this checker with optional rules to avoid break CI? If some changes are not what we really wanted.

Yes, it is possible to add suppressions (by annotation) and exclusions (by config).

This checker is powered by AI, and will not be always right.

It's not powered by AI, it's just static code analysis.

Thanks @jerqi and @frankliee for the review.


Storage free size trigger on 10GB

https://github.com/Azure/azure-monitor-baseline-alerts/blob/2566ee16836a0d50bbabe2b06bf887ab2727c14d/services/DBforPostgreSQL/flexibleServers/alerts.yaml#L170
What is the reason to setup the default trigger for 10GB free space on PostgreSQL.
Is this related to some recommendations from database vendors?
I try to found the source of this requirements.
Thanks in advance.

@ChrisPolewiak, thank you for your feedback.
@JoeyBarnes, could you take a look?

Hi @ChrisPolewiak - Alerts in AMBA have 3 ways that alert details are defined.  One (verified) is through a product group verified path, which is the ultimate path.  Second (popular) is thru statistically significant data analysis based on how alerts are being deployed today.   In this case, the alerts for PostgreSQL were pulled in through the popular route.

Thanks for your comment.


Improve the memory model

The memory model is incredibly naive right now: Arena allocate everything, and only free when the entire program completes. This is passable (and fast!) for simple cases, but would scale terribly for long-running processes since no memory is almost never freed.
Maya gave some good critiques in this Zig discord thread:
https://discord.com/channels/605571803288698900/1128605557796905020

Yah.  This is a really good idea.  duck tape is nice in both its physical and software variants.   Was going to open a bug on memory usage when I saw this....  If you want your process killed,  try this increasing 20 to 100000 or so:
seq 20 | ./dt 'deq swap drop [ deq swap \d: [ d divisor? not ] filter d pl ] [ swap dup rot len ] while'
ps. Its a little pita to use 'swap dup rot ' instead of over ( a b --- a b a )...

For memory management, I'm working through exactly what I want to do in this project: https://github.com/booniepepper/dt-rewrite
Getting close to a point where I'll start incorporating it


chore: release 1.0.0

Current coverage is 100% (diff: 100%)

Merging #16 into master will not change coverage

@@           master   #16   diff @@
===================================
  Files          14    14
  Lines         255   255
  Methods        56    56
  Messages        0     0
  Branches        0     0
===================================
  Hits          255   255
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 1825857...0b03843


[api] warning to store token

A warning message (related to #85) to advise users to store their Bearer token

It depends on how much a problem it creates, I know my bot account got locked (and reopened) pretty fast for me but the warning could also just be in the docs 👍


Create annotations for generators of number values

Create annotations for generators of number values according to concept

Annotations for all suggested generators were created.


WithTheme doesn't seem to change the theme

First, thank you all for the incredible hard work and nice design of the charm.sh suite. I'm hella diggin' it!
When I attempt to change the theme of a huh Form with .WithTheme() the form style is unchanged from the default theme.
Not only colors not changing, but also any block formatting, etc.
err = huh.NewMultiSelect[*App]().
  Options(options...).
  Title("Select Apps to stop").
  Value(&selectedApps).
  WithTheme(CustomTheme()).
  Run()

In the example screenshot below, I am also printing out the theme items and see changes in those elements, but no change in the actual form theme.

@dfalgout I had the same issue and workaround was to define the form myself, set form theme then add the widget to the form

Off the cuff, I'd guess that this is only happening on one-off elements, i.e.
huh.NewMultiSelect().
    WithTheme(customTheme()).
    Run()

Whereas the following works in my testing:
huh.NewForm().
    WithTheme(customTheme()).
    Run()

my guess its a similar problem to #97

This is indeed semi-specific to using fields directly, but it's only because they use the global Run internally, which is the source of the issue.
In order from call site:
https://github.com/charmbracelet/huh/blob/355812cbc0888590f85b7df35efebb48ddd9fe68/field_multiselect.go#L425
https://github.com/charmbracelet/huh/blob/9cd22a8ef511b9531a89c76c43ea09b3a8245a28/run.go#L6
https://github.com/charmbracelet/huh/blob/9cd22a8ef511b9531a89c76c43ea09b3a8245a28/form.go#L84
https://github.com/charmbracelet/huh/blob/9cd22a8ef511b9531a89c76c43ea09b3a8245a28/form.go#L225-L227
https://github.com/charmbracelet/huh/blob/9cd22a8ef511b9531a89c76c43ea09b3a8245a28/group.go#L95-L97

I believe this issue should be solved if we simply check if the theme or keymap is already set on the field before overriding it. This will make things work individually and allow changing themes / keymaps for individual fields as part of a larger form as well.

This should be fixed by #123, let us know if this works for you!
If it doesn't please feel free to re-open this issue or create a new one!

Can confirm with 0.30.0 it's still an issue, please re-open.

Apologies! Thanks for letting us know, re-opened the issue for now.

Okay after a bunch of testing I believe I have solved it correctly this time, please do try it out and let me know if everything works correctly.

https://github.com/charmbracelet/huh/pull/219


README: description and focus

Move Advanced Cycle Finder docs to FAQ
Improve plugin description in README
Minor changes to Folder Structure

@advayDev1, @confile - these are minor changes. I will update the plugin instructions once we confirm the fixes in the 0.3.0 release.

LGTM

Lgtm if you remove string escaping from the new para in readme
On Sat, Jun 27, 2015, 7:57 AM Michael Gorski<EMAIL_ADDRESS>wrote:

LGTM
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/pull/243#issuecomment-116083333
.

Also the PR needs to be on the existing release branch not master if you
want this in .3
On Sat, Jun 27, 2015, 7:49 AM Bruno Bowden<EMAIL_ADDRESS>wrote:

@advayDev1 https://github.com/advayDev1, @confile
https://github.com/confile - these are minor changes. I will update the
plugin instructions once we confirm the fixes in the 0.3.0 release.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/pull/243#issuecomment-116080843
.

Fixed escaping. This is public documentation so it doesn't need to be in the branch.


Split Main world and Render world Entity space

Objective

Another way to get retain render world
#14449 proposes using an entity-to-entity mapping to avoid clearing all entities every frame in render world.However, it is  confusing that  main world entity may has a different entity ID to its corresponding entity in render world. It is foreseeable that it will significantly disrupt the existing rendering ecosystem and increase the maintenance burden on rendering personnel.

Solution

The idea of this PR is similar to subnet division ,it should allow people to  divide the entity space into multiple worlds, and the world default entity allocation will only be in its own entity space, unless you call get_or_spawn  to share entities across  worlds.
In this PR, just simply allocate all even entity spaces to the main world and leave the rest to the rendering world.

Advantages

Almost no burden to rendering people and break change is minimal.
May open another door for assets as entities and networks
No need to occupy any bit space in the Entity

Drawbacks

Need to adjust the entity allocation method and the interface exposed to users.
Extra memory usage , WorldCount * (20 * EntityCount + ( SparseSetComponentCount * 8 * SparseSetEntity) bytes, for example , after this PR, the memory of many_cubes  (2 worlds ,16w Entities) increased from 380 mb to 390mb
get(_mut)  and SparseSet itertaion performance will decrease due to cache locality ( no more than 10%)

Performance
TODO

Migration Guide
TODO

Entity subspace, which looks like it may meets my needs.
I want my game main logic in lockstep to have deterministic, but others like UI or windows component entities are no need to have same in every player's games. I know this is not about render just say it, thank you for contributions.
So maybe it's better not to divide it with odd and even, maybe continuous blocks (may more cache-friendly), and there can be more defined block in the future?

Can we close this?

Closed as Retained render world has been merged


Major documentation update

Hi Dev,
Amazing project. Saw a few issues with the documentation. Opened a pull request.
Please review and update. Thank you for this amazing project.
Regards,
Your Friend

Hi Frixoe,
Really appreciate your attention to detail and communication skills.
would you be interested in working for my organisation?
Regards,
me

Thank you @Frixoe , I am glad you caught this issue before it caused any major issues. Thank you .

Hi Frixoe, Really appreciate your attention to detail and communication skills. would you be interested in working for my organisation?
Regards, me

Hi @viny1ic,
I would definitely consider it.


[Question] Use of MLP in Transformer Encoder/Decoder

Tutorial: 6
Hi @phlippe,
A question regarding the use of neural nets after the multi-head attention layer inside the encoder/decoder. Instead of an MLP, could we use some other architecture, for example a shallow CNN applied over multiple elements of the sequence? We will probably loose some speed and the model is no longer permutation-equivariant, but that might improve model performance?
I tried searching for research papers exploring this idea, but could not find anything. I also could not find any solid argumentation to why this might be a bad idea. Any thoughts, links and references would be very appreciated.
Thanks!

Update:
I found this paper on text-to-speech and for their FFT module (chap 3.1.) they use an encoder with two convolutional layers as non-linearity instead of the MLP (probably modelling a depthwise separable convolution idk?).
Their argument is that nearby sequence elements are more closely related in the character/phoneme sequence in speech tasks. But with byte pair encoding in language tasks wouldn't it make sense to also use this design?

Hi @pi-tau, there exist many variations of Transformers, and you can indeed replace the MLP with a different layer like convolution. In Computer Vision, combining convolutional methods with Transformers was a hot topic for a while, e.g. https://arxiv.org/abs/2107.06263. But in general, when you go to scale, it is usually best to give the model full flexibility by only using MLPs, and have the attention as arbitrary ways of communicating. For very small datasets, such inductive biases are more important. This is why RNNs can still beat Transformers when you train them from scratch on very small NLP datasets.


[Android] Support info - Contact support

User can access support email from profile page to get more help using the application.

This functionality is already implemented in the RG app. It can be seen by tapping "Contact support" in the profile screen.
In our case, we would need to see if the copy needs to be updated for the button and also update the email-to information as we have a different support email. I think the email should be updateable in the config.

@moiz994 There was a small issue with "Contact support" on Android. It tried to send email not only with email app, but with all messenger apps also. This was fixed in https://github.com/openedx/openedx-app-android/pull/160. It is also configurable with config in the develop branch right now.

awesome, thanks for the update!


Updated playbook to use set_fact for identities to avoid fact issues

Updated playbooks to use set_fact to correctly update the identities fact / var. Since setting a fact will override any consecutive runs with vars:, we need to use set_fact to ensure the fact is set correctly between remove and add processing

Also removing the destroy.yml and null.yml playbooks as these are not in-use for anything


Add catalog index file and script to generate it

The script generate a catalog index file using the current bundle.
The bundle must be reachable from a repository, it can not only be built localy.

@OlivierCazade, you'll need to sign off on your commit to pass the DCO checks.


Fix/register sequencer not mutating array of registered proposers

I think this is PR by mistake. Gonna close


Update Kubebuilder go plugin

The operator currently uses the already deprecated go.kubebuilder.io/v2 plugin which would be good to update to at least v3, perhaps even to v4.
Relevant docs for how to update:

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.3.0/#upgrade-your-go-project-from-gokubebuilderiov2-to-gokubebuilderiov3
https://master.book.kubebuilder.io/migration/legacy/v2vsv3.html

A note on deprecation of v2:
https://master.book.kubebuilder.io/plugins/go-v2-plugin.html

Parts of this update were already done in PRs #212 and #217


Map contributors into cocina model

When done, you should see any authors and contributors added for a work mapped into descMD in Argo, with the proper role term specified.
See mapping
May require upstream mapping work, not sure. Test in QA.

See also https://docs.google.com/spreadsheets/d/1CvEd_NODprNhM2D9VfvJBFs1jfAMEUr0kDxXHe2HkL4/edit#gid=435507816 for more information on role mappings.

[ ] tests
[ ] generates model but it doesn't go through to argo (!)

PR #496 covers everything except for order, which @jcoyne and @arcadiafalcone.   I propose to close this issue after PR #496 is merged, and that we have a new one opened for any order mappings needed for contributors for H2.
Note that the contributor_generator_spec  does have some comments about order per Arcadia's mapping at this time.

This is from the h2 infrastructure-integration test run yesterday, so we're looking good:

looking better!  marcrelator role only:

From this in H2:

To this MODS in Argo

I'm calling contributor mappings from H2 to cocina done.  @amyehodge @arcadiafalcone Just notifying you of this fact.


Cannot add bootstrap sass files

Hi,
I'm trying to add the sass files from Bootstrap 4 into the seed. The seed is running fine as-is, and this is the first customization that I am attempting on top of it.
First, I added
this.ENABLE_SCSS = true;
to project.config.ts, and changed all the existing .css extensions to .scss. This works fine.
Then, after installing Bootstrap 4 via npm, I added
{src: 'bootstrap/scss/bootstrap.scss', inject: true}
under NPM_DEPENDENCIES in project.config.ts. Running npm start, everything goes fine until it just stops at the following lines:
[17:29:47] Starting 'build.js.dev'...
[17:29:50] Finished 'build.js.dev' after 2.87 s
[17:29:50] Starting 'build.index.dev'...
[17:29:50] gulp-inject 2 files into index.html.
[17:29:50] gulp-inject 2 files into index.html.
There are no errors or any debug info reported. As best as I could, I tried going through build.index.dev by adding some logs and using gulp-debug, but I was unable to find anything that hints at what might be going wrong.
Checking my dist folder, I can see that a bootstrap.css file is generated successfully in the proper location. However, nothing is injected into the index.html file.
I also tried adding
{ src: ${this.CSS_SRC}/bootstrap.css, inject: true, vendor: false }
under APP_ASSETS in project.config.ts, but this does not help either.
If I manually copy the resulting bootstrap.css file into my src folder, and add a reference to it under APP_ASSETS only, then npm start works as expected. Yet I would like to customize the bootstrap sass files dynamically - it would be rather cumbersome to compile them separately each time.
Is this a bug, or am I trying to accomplish this in the wrong way?
Thanks!

If I copy the whole bootstrap sass folder under src, and add a reference to it under APP_ASSETS, then both the sass compilation and injection into index.html is working fine. Practically, this is a good enough solution since it only requires one extra step of copying the files from node_modules folder to src folder.
Still, this is not what I would have expected to do based on the documentation. So is this a minor bug, or am I misunderstanding the approach suggested by your documentation?
Thanks!

You shouldn't have to modify the project config at all. Just leverage this all within your main sass file, via importing the actual bootstrap library in:
i.e. For the bootstrap-sass npm dependency:
@import 'bootstrap-sass/assets/stylesheets/bootstrap';;

Thanks. That is what I'm basically doing now. I also understand that I can point directly to the bootstrap installation under node_modules, so I wouldn't have to copy the folder either.
However I think accomplishing this by overriding NPM_DEPENDENCIES in project.config.ts is more consistent and much cleaner, and that is what I expected  to do based on the documentation.  Install via npm, override and it is injected for you. There is actually an example of this using bootstrap in the wiki:
https://github.com/mgechev/angular2-seed/wiki/Add-external-scripts-and-styles
So does this work with css only and we cannot handle sass in this manner?

It should work with Sass too but you should refer to the CSS file not sass since it won't be copied to the target directory.

I am struggling with this too. The main reason to use SASS bootstrap files over plain CSS files is so that you can customize them, so I think the approach to import them into your main.scss file makes more sense. You can then override variables and other things in this main file (or other SCSS files that you import into the main).
However I cannot import the bootstrap SCSS file from node_modules into my main.scss. I tried :
@import '../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap';
It does not work : the compilation fails because some bootstrap variables, used in my main, are undefined.
Any hint on how to achieve this without the additional manual copying step ? Should the path be relative to some other directory ?

@sinel hello! By the issues, so we only copy the bootstrap-sass folder to client/sass folder? i had the same problem.

oh!keep the seed config, it only add:
@import 'bootstrap-sass/assets/stylesheets/bootstrap';

to css/main.scss


Do not blow up if mapping and empty file

Not sure if we still need this. I expect the recent collection fixes will address the empty files but will leave this open for now.

Should we delete this PR @bram2000 ?


Interval Selectors with date scales are not returning datetimes on the python side

If I have an interval selector using a date scale, the 'selected' trait on the python side is returning two floats (which represent the int timestamp) instead of two date objects.
Look at the code in the 'Fast Interval Selector' section of the Interaction Layer example notebook to highlight this issue

Apparently, it has changed since binary buffers are now used. So we send dates over the wire as floating point values.
See https://github.com/bloomberg/bqplot/blob/master/js/src/Selector.ts#L81-L83
We should react on the selected change Python side, and convert floating-point values back to dates when they are received.
Problem is there is no Python equivalent of the SelectorModel TypeScript class. See #868

@martinRenou that's what I am doing as an interim fix. But it's too much to expect python client to convert the timestamps to dates IMHO.

@martinRenou @maartenbreddels any updates on this?

But it's too much to expect python client to convert the timestamps to dates IMHO

We won't have another way around this, don't you think? And it doesn't cost that much, do it?

According to @maartenbreddels this is a bug. I also agree with him. Previously,
'selected' trait returned dates but now it's returning long timestamps. Recent changes broke this.

It is a bug yes, it should be fixed. But are you saying that converting the timestamps to dates is not a fine fix?
I wanted to fix it, but I am a bit annoyed by this issue: #868. Either we do a quick and dirty fix for the dates now, or we do things correctly and first fix the other issue and then fix this one. What do you think?

I'm on it

I found the issue, the Python logic for deserializing date types is already there, it is just never called because the date type is not passed to Python, so Python did not know it had to deserialize. This should fix it #869

Awesome work @martinRenou !


s_ref assertion in geometry

Describe the bug
In geometry.py the attribute s_ref asserts if only one wing is specified.
Expected behavior
It seems that the comment is right, but the code does not reflect that.
if len(self.wings) > 1:  # If there is at least one wing
should this be:
if len(self.wings) > 0:  # If there is at least one wing
Desktop (please complete the following information):

OS: Windows 10
Anaconda Python 3.7.x

Oh whoops - great catch! Thank you so much! :)
I've just committed the change - it should make it into the next release, which will come out shortly!


Check references for paper have URLs

in particular
@techreport{fox_methodologies_2024,
title = {Final report of the joint investigation into SSD modelling and
ssdtools implementation for the derivation of toxicant guidelines values in {Australia} and {New Zealand}.
Report prepared for the Department of Climate Change, Energy, the Environment and Water},
institution = {Environmetrics Australia and Australian Institute of Marine Science},
author = {Fox, DR and Fisher, R and Thorley, JL},
month = April,
year = {2024}
}

Ideally DOIs and also ensure stable.
Might need to archive some

Also is fox_methodologies_2021 or is it 2022!

I can't even find this reference!!!
Chapman, P. R., Hart, A., Roelofs, W., Aldenberg, T., Solomon, K., Tarazona, J. L., Byrne, P., Powley, W., Green, J., Ferson, S., & Galicia, H. (2007). Methods of uncertainty analysis. In: A H (Ed) EUFRAM Concerted Action to Develop a European Framework for Probabilistic Risk Assessment of the Environmental Impacts of Pesticides, Vol 2, Detailed Reports on Role, Methods, Reporting and Validation.
Considering dropping.

Went with Newman et al 2000 instead as url.

done


feat(super-agent): Skip core bundle if installed

This pull request uses the CLI functionality to detect the presence of the Super Agent on the host. If detected, it will install OHI with the Super Agent dependency, skipping the core bundle installation. If core recipes are targeted for installation, they will be unsupported since the Super Agent is already installed. (Associated PR: https://github.com/newrelic/open-install-library/pull/1072)

Updated the status of the core bundle to NULL from UNSUPPORTED when a super agent is installed, as suggested by @sblue. This modification enables easier tracking of installs, particularly in scenarios where a super agent is present.


@primaryKey directive on API type definition does not apply to generated queries

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
v14.17.1
Amplify CLI Version
7.6.5
What operating system are you using?
Mac
Amplify Categories
storage, api
Amplify Commands
add, codegen, push
Describe the bug
According to the documentation here: https://docs.amplify.aws/cli/graphql/data-modeling/
using the @primaryKey directive will allow the user to define the primarykey used for the table. However, this @primaryKey directive does not change the autogenerated get{typename} queries, which use the id field by default. This is a departure from the behavior prior to this release, where annotating a field as a key would also allow you to get{typename via amplify query.
Current Behavior
In the output src/queries.graphql, I see the following query:
export const getTesttype = /* GraphQL */ `   query GetTesttype($id: ID!) {     getTesttype(id: $id) {       myidname       fieldnameone       fielnametwo       createdAt       updatedAt     }   } `;
When I look at the Dynamodb table, I see that myidname is successfully created as the primaryKey of the table.
HOWEVER, if I try to use this query in the Appsync console, I am not able to query on myidname  and have to query on an id field. When querying, I get the following error:
{
  "data": {
    "getTesttype": null
  },
  "errors": [
    {
      "path": [
        "getTesttype"
      ],
      "data": null,
      "errorType": "DynamoDB:DynamoDbException",
      "errorInfo": null,
      "locations": [
        {
          "line": 2,
          "column": 3,
          "sourceName": null
        }
      ],
      "message": "Query condition missed key schema element: myidname (Service: DynamoDb, Status Code: 400, Request ID: 6M6BFMT7AJT1TPICEHCLT6TRAJVV4KQNSO5AEMVJF66Q9ASUAAJG, Extended Request ID: null)"
    }
  ]
}

Expected behavior
Expected Behavior
I had assumed that, by defining the field myidname as @primaryKey, Appsync would know that I need the "get" query to query on the myidname field, not on this id field that is Appsync-generated and doesn't actually exist in the dynamo tables. In fact, by using the @primaryKey directive, I am now unable to "get" query the type. I believe this is a bug and oversight in the behavior of the @primaryKey directive.
Please help urgently, as our project is going to need to either work out a fix for this issue or revert to the previous version of amplify that allowed the "get" queries on the primary key of the table.
Reproduction steps
Create a new amplify project
amplify add api
- accept all defaults
edit the schema.graphql and add the following type:
type testtype
  @model
  @auth(
      rules: [
        { allow: all, operations: ["read", "create", "update"]},
      ]
  )
  {
      myidname: ID! @primaryKey
      fieldnameone: String
      fielnametwo: String
  }

GraphQL schema(s)
Authorization doesnt really matter - do auth however is easiest
input AMPLIFY { globalAuthRule: AuthRule = { allow: public } } # FOR TESTING ONLY!

type testtype
  @model
  {
      myidname: ID! @primaryKey
      fieldnameone: String
      fielnametwo: String
  }

Log output

# Put your logs below this line

Additional information
You should confirm that you see the following output in src/queries.graphql:
export const getTesttype = /* GraphQL */ `   query GetTesttype($id: ID!) {     getTesttype(id: $id) {       myidname       fieldnameone       fielnametwo       createdAt       updatedAt     }   } `;

@renebrandel am I doing something incorrectly here? Would appreciate any insight you can provide :)

With graphql transformer V1, when appsync generates a "get" graphql query on a type, it looks like the following (assuming the field name was primarykeyfield):
## [Start] Set the primary @key. **
#set( $modelObjectKey = {
  "email": $util.dynamodb.toDynamoDB($ctx.args.email)
} )
## [End] Set the primary @key. **
{
  "version": "2018-05-29",
  "operation": "GetItem",
  "key": #if( $modelObjectKey ) $util.toJson($modelObjectKey) #else {
  "id": $util.dynamodb.toDynamoDBJson($ctx.args.id)
} #end
}

Three things to notice: (i) It is using a "getitem" operation on the table, (ii) It sets the modelObjectKey at the beginning of the resolver, (iii) If modelObjectKey is not defined, it will default to using the id field.
Using Graphql transformer V2, it generates the following for a "get" operation:
## [Start] Get Request template. **
#set( $GetRequest = {
  "version": "2018-05-29",
  "operation": "Query"
} )
#if( $ctx.stash.metadata.modelObjectKey )
  #set( $expression = "" )
  #set( $expressionNames = {} )
  #set( $expressionValues = {} )
  #foreach( $item in $ctx.stash.metadata.modelObjectKey.entrySet() )
    #set( $expression = "$expression#keyCount$velocityCount = :valueCount$velocityCount AND " )
    $util.qr($expressionNames.put("#keyCount$velocityCount", $item.key))
    $util.qr($expressionValues.put(":valueCount$velocityCount", $item.value))
  #end
  #set( $expression = $expression.replaceAll("AND $", "") )
  #set( $query = {
  "expression": $expression,
  "expressionNames": $expressionNames,
  "expressionValues": $expressionValues
} )
#else
  #set( $query = {
  "expression": "id = :id",
  "expressionValues": {
      ":id":     $util.parseJson($util.dynamodb.toDynamoDBJson($ctx.args.id))
  }
} )
#end
$util.qr($GetRequest.put("query", $query))
#if( !$util.isNullOrEmpty($ctx.stash.authFilter) )
  $util.qr($GetRequest.put("filter", $util.parseJson($util.transform.toDynamoDBFilterExpression($ctx.stash.authFilter))))
#end
$util.toJson($GetRequest)
## [End] Get Request template. **

In this case, nothing is set into the metadata.modelObjectKey, so the fallback id is used. Also, the underlying behavior changed from a getitem to a query, which is strange and unexpected.

Looks like there is a preAuth step where the modelObjectKey is supposed to be inserted into the resolver pipeline. However, it was/is not getting inserted. I think it was my addition of a custom resolver for the init phase that made this preAuth resolver get generated. See preAuth resolver below - this was the missing piece:
## [Start] Set the primary key. **
$util.qr($ctx.stash.metadata.put("modelObjectKey", {
  "taskid": $util.dynamodb.toDynamoDB($ctx.args.taskid)
}))
## [End] Set the primary key. **
{}

Confirmed that, unless you specify the names for each query to be implemented, the queries will be generated with an "id" to identify them with instead of the specified @primaryKey field. in the example above, if you specify below in the schema.graphql, you will get an incorrect get query that tries to use id to query the item:
type testtype
  @model
  {
      myidname: ID! @primaryKey
      fieldnameone: String
      fielnametwo: String
  }

Instead, if you use the following, you will get the correct get queries:
type testtype
  @model(queries: {get: "getTesttype", list: "listTestTypes"})
  {
      myidname: ID! @primaryKey
      fieldnameone: String
      fielnametwo: String
  }

I assume this applies to update mutations as well, as these are not working by default.

Thanks for reporting this. I believe the issue should be fixed by https://github.com/aws-amplify/amplify-cli/pull/9409. Until that is released, you should be able to work around the issue by renaming your model from testtype to Testtype.


Nested router with prefix

Hi,
There seem to be an issue with nested routes when using a prefix for the routes.
Here is a minimal sample code to reproduce the issue.
'use strict';

const koa    = require('koa');
const Router = require('koa-router');

let app = koa();

let router = new Router({
  prefix: '/prefix'
});

let nestedRouter = new Router();

nestedRouter.get('/', function *() {
  this.body = 'nested';
});

router.get('/', function *() {
  this.body = 'root';
});

router.get('/nested', nestedRouter.routes());

app.use(router.routes());

app.listen(8888);

I would expect the path /prefix/nested to use the nestedRouter handler, but I get 404 instead. If I remove the route prefix, I have / and /nested working as expected.
The issue occurs with node 0.12 as well as iojs.
Thanks for your help.

It it can help, here is the output I get when I enable debugging.
  koa-router defined route HEAD,GET / +0ms
  koa-router defined route HEAD,GET / +3ms
  koa-router defined route HEAD,GET /nested +2ms
  koa-router GET /prefix/nested +565ms
  koa-router test /prefix/ /^\/prefix(?:\/(?=$))?$/i +1ms
  koa-router test /prefix/nested /^\/prefix\/nested(?:\/(?=$))?(?=\/|$)/i +0ms
  koa-router dispatch /prefix/nested /^\/prefix\/nested(?:\/(?=$))?(?=\/|$)/i +1ms
  koa-router GET /prefix/nested +1ms
  koa-router test / /^(?:\/(?=$))?$/i +0ms

This fix doesn't seem to work and even caused regression that /nested  doesn't work now.
I think the problem is not exposed by unite test code because the test used use instead of get in forums.use('/forums/:fid', posts.routes());


基础预备知识中Rust快学的链接失效了

https://github.com/Dapp-Learning-DAO/Dapp-Learning/blob/main/docs/basic-knowledge.md

do you have any links to recommend?

do you have any links to recommend?

I think https://course.rs/about-book.html is a good course to learn Rust, I learned Rust in this website. Also, I find the chapter 5 Geth of《以太坊的指南针》is out of date, it contains many mistakes, maybe the Dapp-Learning can note this in the document. Can I pull request for these two problem?
(Dapp-Learning is a good platform to learning Web3.0, now I am leanring Web3.0 with the help of Dapp-Learning, Thank you for your amazing work. I also want to work with your.)

https://course.rs/about-book.html   it is really a good course.  Of course you can fix the two problems and make a pull request.  Thank you for recognising and supporting Dapp  Learning!

do you have any links to recommend?

I think https://course.rs/about-book.html is a good course to learn Rust, I learned Rust in this website. Also, I find the chapter 5 Geth of《以太坊的指南针》is out of date, it contains many mistakes, maybe the Dapp-Learning can note this in the document. Can I pull request for these two problem? (Dapp-Learning is a good platform to learning Web3.0, now I am leanring Web3.0 with the help of Dapp-Learning, Thank you for your amazing work. I also want to work with your.)

add wechat yanyanho666 to join our developer group


Prevent an error caused by concurrent use of a cache on multiple threads

This modifies the cache's cost calculation so that determining the start time of the task never raises a KeyError. This can happen due to interleaving of the cache's _posttask method (which accesses starttimes) and the _finish method (which clears starttimes). Now, when the start time is not present, the initial duration (not including dependencies) is 0, so that the task has no extra power to evict other results from the cache, but can still be put in there when there's space. This also makes access of starttimes more consistent with durations.
This adds a parametrized test to reproduce that specific case as described in #10396. That test needs some specific concurrency control, so seems a little artificial, but it does reproduce a possible interleaving of task and callback execution. The control also means that it runs fast and should not be flaky.
This also adds implementation comments to explain the new code and some of the existing code.
Closes #10396

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

I marked this as draft initially for a few reasons.
1. I'm not very familiar with dask and I'm still unsure if one instance of Cache is intended be used across multiple threads.
2. We solved one instance of this problem over on napari in a different way (by moving all cached access to a dedicated non-main thread in https://github.com/napari/napari/pull/6008).
3. This doesn't solve all potential concurrency issues with use of Cache. I think I can see another one caused by interleaving of _start accessing the cache and _posttask modifying it.

ok to test


Slice support for FileRegion in JNI transports

Recently slice support was added to file region FileRegion for NIO and OIO https://github.com/netty/netty/pull/6997. We should do the same for KQueue and EPOLL. There are some challenges related to how FileRegion and FileChannel are handled in these JNI transports. There are assumptions made about the type of FileRegion made in order to get the integer file descriptor [1][2]. There are also assumptions made about DefaultFileRegion and its internals in JNI code [3][4]. There is some support for types other than DefaultFileRegion via EpollSocketWritableByteChannel [5], but this doesn't take advantage of sendFile. We should investigate alternative approaches which may help unify the two approaches in most cases and remove assumptions of types in JNI. For example: we should investigate moving extracting the file's FD (and the reflection involved) up to the java layer, creating a new interface for extensibility to give access to the file's FD, and pass the file's FD (and other necessary arguments) directly to JNI.
[1] https://github.com/netty/netty/blob/4.1/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java#L471
[2] https://github.com/netty/netty/blob/4.1/transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueStreamChannel.java#L307
[3] https://github.com/netty/netty/blob/4.1/transport-native-epoll/src/main/c/netty_epoll_native.c#L282
[4] https://github.com/netty/netty/blob/4.1/transport-native-kqueue/src/main/c/netty_kqueue_bsdsocket.c#L46
[5] https://github.com/netty/netty/blob/4.1/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java#L401

@Apache9 @normanmaurer - FYI

Thanks @Scottmitch , nice writing up.
I think for FileChannelBasedFileRegion, we an try to get the FileChannel and then the FD, and then pass it to JNI.


Sign and Verison 0.1.2

Current coverage is 86.66% (diff: 100%)

Merging #18 into release will not change coverage

@@            release        #18   diff @@
==========================================
  Files             6          6
  Lines            75         75
  Methods           0          0
  Messages          0          0
  Branches          5          5
==========================================
  Hits             65         65
  Misses            6          6
  Partials          4          4

Powered by Codecov. Last update 32f8386...8b8e7f9


Delete unused iot_test_i2c.c

Delete unused iot_test_i2c.c
Description
Confirmed with Qiutong, it's not needed.

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@qiutongs @vjjunnut, can you help to approve and merge this?


Support resources in cdn endpoint

Feature Request
In order to unblock https://github.com/terraform-providers/terraform-provider-azurerm/issues/398 and enable custom domains, please consider adding resources support to the Endpoint struct.

@hytao can you please comment, is this missing from the swagger?

Hey there, would appreciate any updates on this :)

@hytao ping

I am interested in this feature for the same reason as @imavroukakis it would be great to get an update on progress.

Hi, we are currently updating the cdn swagger? What do we need to do to unblock this issue?

Hi @hytao from what I can tell, the Endpoint struct is missing resources as per the API

The APIs for manipulating custom domains are in customdomains.go.

With the APIs available I believe this issue is resolved.  Please let me know if you have further questions.


Better string manipulation by ConnectionString class

4th issue so far I believe in same day :)
Any way, currently ConnectionString class splits the passed string using the '=' and ';' characters which mean that this two characters can not be used as the password of database or even in the path of the database file. But then, both '=' and ';' are valid path characters in Windows. In fact, you cant be sure which character is valid and which one is not a valid character when writing for multiple platforms. I strongly ask for a better manipulation of connection string in ConnectionString class. At least we need a way to exclude any string inside two ' " ' characters.
Above problem is about this line:
https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Utils/ConnectionString.cs#L23
And specially this one:
https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Utils/ConnectionString.cs#L21

Hi @falahati, yes, you right. I will fix this using regex, thanks.

Solved. Thanks


Update README.md

Fixed path and standardized link syntax throughout (especially with .md links)!

There's no .md extension on the license.

Apologies for that. I just saw the other file links were ending in .md, but I didn't properly check the file itself.


Unable to scroll table sideways in drift viewer in Flutter DevTools

Have a large table, with many columns, I see that I cannot scroll the table sideways too see all my columns.
Using Google Chrome as browser.

It would also have been very convenient to have a query editor where you could query all data tables in your database, more like the one in Android Studio App Inspector.
It would also been very cool if the drift databse could be connected to the Android Studio App Inspector too... ...but that might be too much to ask for...

Interesting, I can reproduce the issue as well but db_viewer is using two SingleChildScrollViews to cover both directions so it should work. I need to take a deeper look.

It would also have been very convenient to have a query editor where you could query all data tables in your database, more like the one in Android Studio App Inspector

That sounds like a lot of work, but it should be possible to port at least some of the features like the ability to run custom queries.

It would also been very cool if the drift databse could be connected to the Android Studio App Inspector too... ...but that might be too much to ask for...

That might work with drift_sqflite as a database implementation. But that uses the sqlite3 from the OS which is typically outdated on Android and is also slower due to the overhead of platform calls.

@simolus3 I reported this in january, is there any hoper for a fix before summer ?
I see it is a very handy tool.

To be honest I'm not that experienced with Flutter and I don't really understand the problem since we are using a horizontal scroll view. Contributions to fix this are welcome but I don't think I'm effective at fixing this.

Sorry. Missed this issue. This is the current one with a PR linked into it. Hope it is accepted and lands.


Crash on iOS 9.3.5 (iPod touch)

-[UICollectionView setRefreshControl:]: unrecognized selector sent to instance 0x15a51800
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UICollectionView setRefreshControl:]: unrecognized selector sent to instance 0x15a51800'

This is actually due to the fact that you can't say refresh controls on scroll views before iOS 10. It will still work fine on table view controllers.

Add*


DID Exchange - Errors

Implement of Error reports defined in Aries DID Exchange RFC https://github.com/hyperledger/aries-rfcs/tree/master/features/0023-did-exchange#errors

Part of epic #42


Base Validation Issues

In the branch Tab_Control.
Our BaseViewModel class now extends ValidatingBaseViewModel. I have seen several issues after making that change.
There have been several UI issues with components having red boxes around them that shouldn't. There are also some potention logic issues.
UI issues:

Potential Logic Issues:

When i first open the editors, it doesn't validate my "Name" rules. (name cannot be blank).
Not updating when going from one error to another. The validate doesn't update the error message if it is already in a "severe" state. Example. If i delete the name characters then tab off of the name field, we get a name cannot be blank error. Then if i type the name of a sibling element it should violate the sibling rule and show that error message tooltip on the save button.
The list of string errors wasn't getting returned correctly. I think i fixed this, but i don't think i have submitted that code yet.

I think we backed out of using MVVM base validation, no? Is this issue still relevant?


Backport: Unable to see project members after upgrade

Backport rancher/rancher#20760

The fix is available in v2.2.5-rc2

Version: v2.2.5-rc2 (fresh install)
Version: v2.2.4 -> v2.2.5-rc2 (upgrade)
I can confirm that members are now seen with a fresh install or post-upgrade (from v2.2.4). Also, groups now show up (they didn't at all before in v2.2.4).


iOS package as own git repo?

This would be great for doing simple pull requests versus manually copying files over.

We are working on a unified version together with QuincyKit where you will be able to do that: https://github.com/codenauts/HockeySDK-iOS


Opening a shortcut on Windows

This has come up in Gitter chat.
Windows has shortcut files for launching programs or opening files. They have the extension .lnk and contain a reference to the target as well as some other properties (such as icon path, working directory etc.). A similar concept in Unix land are Desktop Entries (.desktop).
It's very common to use shortcuts on Windows (e.g. the Desktop is usually full of them) and users expect that they can open a shortcut to execute whatever it points to.
Shortcut files are not directly executable with CreateProcessW, so you cannot open a shortcut with Process.run (not even with shell: true, which doesn't really do anything on Windows; ref #9030).
Process.run("shortcut.lnk") # raises File::BadExecutableError
Process.run("shortcut.lnk", shell: true) # raises File::BadExecutableError

They can be opened in cmd or powershell
Process.run("cmd /c shortcut.lnk")

So going though cmd /c provides a solution, but it feels a bit hacky.
The Win32 API has a native way to open files, which supports shortcuts: ShellExecuteA & co. These functions also provide other operations.
The following example shows how the ShellExecuteExW function can be used to open a file (which may be a shortcut):
def open_file(path)
	shell_exec_info = LibC::SHELLEXECUTEINFOW.new(
	  cbSize: sizeof(LibC::SHELLEXECUTEINFOW),
	  fMask: 0,
	  hwnd: nil,
	  lpVerb: nil,
	  lpFile: Crystal::System.to_wstr(path),
	  lpParameters: nil,
	  lpDirectory: nil,
	  nShow: LibC::SW_NORMAL,
	  hInstApp: nil
	)
	LibC.ShellExecuteExW(pointerof(shell_exec_info))
end

lib LibC
  struct SHELLEXECUTEINFOW
    cbSize: DWORD
    fMask: ULong
    hwnd: Void*
    lpVerb: LPWSTR
    lpFile: LPWSTR
    lpParameters: LPWSTR
    lpDirectory: LPWSTR
    nShow: Int
    hInstApp: Void*
    lpIDList: Void*
    lpClass: LPWSTR
    hkeyClass: HKEY
    dwHotKey: DWORD
    hIconOrMonitor : HANDLE
    hProcess: HANDLE
  end

  fun ShellExecuteExW(
    pExecInfo : SHELLEXECUTEINFOW*
  ) : BOOL

  SW_NORMAL = 1
end

I'm not sure what we could make out of this. Whether there can be a good and simple solution, or a one better than prefixing the file path with cmd /c.
Maybe this issue can draw some ideas on the matter.

Given that shortcuts can be opened in cmd and powershell, I think it makes sense to wait for #13567 to be merged so that shell: true actually works on Windows and subsequently opening shortcuts via Process.run.


Are URLs correct of global suppressions?

The GET and DELETE endpoints of the Global suppressions are correct?
It looks like that they contains "global" paths in the endpoint.
Could you please confirm?
GET
GET https://api.sendgrid.com/v3/asm/suppressions/:email_address HTTP/1.1

DELETE
DELETE https://api.sendgrid.com/v3/asm/groups/:group_name/suppressions/:email_address HTTP/1.1

It seems that it has been updated already .


Add temporary fix for CosmosDB lifecycle test

See IcM ticket in #617 . CosmosDB team is fixing the error. They suggest us "While we are working to fix this, please add a delay of 10s in between region changes succeeding and sending delete request." I make the go routine sleep for 20 seconds after all regions are created. I'll follow up on the issue after the bug is fixed by CosmosDB team.

Hi @zhongyi-zhang , could you please have a review on this? I'd like to merge this PR ASAP for not blocking our development.

Explanation of sleeping for 20s instead of 10s: tested locally, sleeping for 10s is not enough sometimes.


Update README.md

Added some missing steps

Thank you for the additions! I was curious why it is necessary to set FirebaseAppDelegateProxyEnabled. I don't see it mentioned anywhere in the capacitor docs. What does it doe and is it really needed?

Where do you get from that these steps are necessary?


Issue27

Coverage increased (+3.7%) to 96.154% when pulling be2c3ee69b274cd136c94cd260bc5d0f865fbb1b on boothby:issue27 into 91245665f339a6388016a38d7985fc5d7572202c on dwavesystems:master.


Remove the release build of the shared framework.

The project template will now strip the unwanted architectures.

See https://github.com/NativeScript/ios-runtime/pull/148#issuecomment-105153954 for more comments.


Use Travis CI

Merging as Travis technically works. A new branch needs to fix the previously uncaught build errors.


fix cluster object model inconsistence

previous com has machinetype, but new com has machine-type, will cause job-exporter unable to find gpu count

Coverage remained the same at 51.762% when pulling d4c74b49fbd73d19d4ba217ea3f6450c8fb3214b on dixu/fix-com-inconsistence into d5dfab492740741e8dafde4382b94be5126c0189 on master.


spring boot 2.0 webflux support

Is there any plan to support webflux application?

i have the same question, will support non servlet framework?


Child resource

Hi everyone,
The library is really usefull, thanks for that !
My question is the next one : I want to create child resource, how can I invoke add_resource to indicate the parent of the new resource ? Is there a process to do that ?
Thanks in advance

Hi,
thank you. To invoke the add_resource with a parent resource you should
simply specify the correct path. If the base resource is registered with
"/base" then the child should be something like "/base/child".
BR
Il giorno mar 23 apr 2019 alle ore 14:36 EmileAlbert <
<EMAIL_ADDRESS>ha scritto:

Hi everyone,
The library is really usefull, thanks for that !
My question is the next one : I want to create child resource, how can I
invoke add_resource to indicate the parent of the new resource ? Is there a
process to do that ?
Thanks in advance
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Tanganelli/CoAPthon/issues/142, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTPN6QPA223NXPY6OXYBR3PR37FLANCNFSM4HHXQV3A
.


Problem: Unable to Connect to AzureDevops Git

Issue
I have created a new Semaphore instance, and installed it using snap. All works well until i need to connect the Git from Azure Devops.
I have update git, i have setup new keys and new secrets. If i use both methods (SSH, and HTTPS) using the terminal, it works. It does not work through the semaphoreUI.
Impact
Ansible (task execution)
Installation method
Snap
Database
No response
Browser
No response
Semaphore Version
2.10.22-e44910d-1721658299
Ansible Version
No response
Logs & errors
TASK RUN Logs using HTTPS
11:06:16 AM
Task<PHONE_NUMBER> added to queue
11:06:18 AM
Started:<PHONE_NUMBER>
11:06:18 AM
Run TaskRunner with template: FortiGate_Config-Backup
11:06:18 AM
Preparing:<PHONE_NUMBER>
11:06:18 AM
Cloning Repository<EMAIL_ADDRESS>11:06:18 AM
Unable to clone repository: unexpected client error: unexpected requesting<EMAIL_ADDRESS>status code: 400
11:06:18 AM
Failed updating repository: unexpected client error: unexpected requesting<EMAIL_ADDRESS>status code: 400
11:06:18 AM
Running app failed: unexpected c

TASK RUN Logs using GIT SSH

10:48:27 AM
Task<PHONE_NUMBER> added to queue
10:48:28 AM
Started:<PHONE_NUMBER>
10:48:28 AM
Run TaskRunner with template: FortiGate_Config-Backup
10:48:28 AM
Preparing:<PHONE_NUMBER>
10:48:28 AM
Cloning Repository git@ssh.dev.azure.com:v3/demo/Ansible/Ansible
10:48:29 AM
Unable to clone repository: object not found
10:48:29 AM
Failed updating repository: object not found
10:48:29 AM
Running app failed: object not found

Manual installation - system information
No response
Configuration
No response
Additional information
No response

Hello  dag-gremache,
I first ran into the same problem as you but using your second option using git and using private/public key setup I can at least get that part to work. Maybe try that.
Tovervlag

Hello dag-gremache,
I first ran into the same problem as you but using your second option using git and using private/public key setup I can at least get that part to work. Maybe try that.
Tovervlag

Hello,
I tried that with a clean Ubuntu and snap installation but it did not work.
I ended up using docker instead and that seems to work. But it comes with it's own problems as only public key works (ssh) and not https.
There is something wrong with the snap setup.

Yeah, true, I also only have it configured via ssh atm. Glad you got something to work at least. :)

@fiftin could you check if this issue is not related to that references issue? https://github.com/go-git/go-git/issues/64
it seems this can be fixed and this would help us a lot


fixing capitalization error with updated add_opt BatchMode argument

Regarding my comment on the last commit.

Thanks for noticing @ejether!


⚠ API - Lens has degraded performance

In b30f3a5, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 585 ms

Resolved: API - Lens performance has improved in 0d3729f after 11 minutes.


[Feat] Improve APIs of the Spark library to be more concise for easily importing/exporting/transforming data at the graph level

Is your feature request related to a problem? Please describe.
as title
Describe the solution you'd like
Proposal TBF

Load GAR file format as DataFrames
object GraphReader {
     /*
      * Input:  graph yaml path
      * Output: vertex DataFrames and edge DataFrames
      * /
     def read(graph_yaml_path): Pair[Map[String, DataFrame], Map[String, DataFrame]] {}

     /*
      * Input:  graph info
      * Output: vertex DataFrames and edge DataFrames
      * /
     def read(graph_info): Pair[Map[String, DataFrame], Map[String, DataFrame]] {}
}

### Write a set of DataFrames to GAR files
```scala
object GraphWriter {
     /*
      * Input:  graph yaml path and a set of DataFrames
      * Status:  success or fail
      * /
     def write(graph_yaml_path,  vertexDataFrames: Map[String, DataFrame], edgeDataFrame: Map[String, DataFrame]): Status {}

     /*
      * Input:  graph info and a set of DataFrames
      * Status:  success or fail
      * /
     def write(graph_info, vertexDataFrames: Map[String, DataFrame], edgeDataFrame: Map[String, DataFrame]): Status {}
}

### Transform graph from one type of GAR to another type of GAR
```scala
object GraphTransFormaer {
     /*
      * Input:  source and dest graph yaml path
      * Status:  success or fail
      * /
     def transform(source_graph_yaml_path, dest_graph_yaml_path): Status {}

     /*
      * Input:  source and dest graph info
      * Status:  success or fail
      * /
     def transform(source_graph_info, dest_graph_info): Status {}
}

Solved by pull requests #113 #114


PR-based workflow does not trigger CI on tag

Probably this issue again: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

Noticed this issue again with the release of v1.2.0+2024a. I also noticed that CI didn't run on main due to a misconfiguration of ignored paths (fixed in #24). I did think that the path-ignore rule was also being applied to tags which would be problematic but:

When using the push and pull_request events, you can configure a workflow to run based on what file paths are changed. Path filters are not evaluated for pushes of tags.

– https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore


Reorganize the Language selection window

Currently, the language selection window just lists all languages alphabetically, which can be confusing and overwhelming for new players who don't know what most of the languages are. While reorganization isn't a high-priority feature, I think it can be improved if it were formatted according to rarity, as done on Archives of Nethys.
If we wanted to get even fancier, we could add a regional tag to any regional languages and a secret tag to druidic.
This post was inspired by this document  which organizes languages and other parts of the game and lore.

I feel this is close enough to what was done with languages recently by tagging with rarity to consider it closed, or as closed as it is likely to get. For data entry purposes I would like to not change from alphabetical lists, as it's generally faster to quickly scroll to the right language and many NPCs know uncommon languages.


chore: bdd-spring-1574779552 to 0.0.1

chore: Promote bdd-spring-1574779552 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[bug]: Error: Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
macOS
GPU vendor
None (CPU)
GPU model
No response
GPU VRAM
No response
Version number
5.0.0.a2
Browser
Chrome
Python dependencies
No response
What happened
(running main branch on tailscale)
I had a Control Layer loaded with an image in it, 1024x1024. I pressed Filter, then selected the Image-to-Image Model as Filter Type and it errors out every time.
What you expected to happen
No error. Expect the visual to show on the canvas
How to reproduce the problem
No response
Additional context
No response
Discord username
No response

Until the linked fix is merged, you can work around the error by installing an image-to-image model in the model manager before clicking the filter.