Error changing shell in config

Ubuntu 16.04 and Mac OS
In ~/.config/alacritty/alacritty.yml
I've tried many permutations of
shell:
  program: /bin/bash
  args:
    - --login

I always get "Error: problem with config: while parsing a block mapping, did not find expected key at line 248 column 7; Loading default config", where 248 is "shell: "
So I'm not getting the uncommented default to work (this is also how a few dotfiles I found on github were formatted). I assume I'm just missing something, but if that's the case I would humbly suggest adding a note in the readme or something since it's not clear how to set the shell from the default.
Thanks!

Okay, please try the following:

Backup your config somewhere
Put the default config into ~/.config/alacritty/alacritty.yml
(you can do this by just starting alacritty without config)
Run the following command:
echo "\n\nshell:\n    program: /bin/bash\n    args:\n      - --login\n" >> ~/.config/alacritty/alacritty.yml

I run zsh by default and following these steps allows me to start alacritty with bash as my default shell. This should definitely work.
If this does work, you can try looking into why your config doesn't work. You should remove any potential duplicate shell blocks and try just running the command on your own configuration file and see if that works. Then you can just move the shell block to wherever you want.

Thanks for the response! Adding:
\n\shell:\n...
to my alacritty.yml did indeed make the error message on start up go away, but unfortunately it doesn't start with the assigned shell on Ubuntu or Mac for me. It's not a big deal since it defaults to my normal  shell (IE, if Bash is my regular shell, but I set zsh in alacritty.yml, it will still start Bash).

 That's probably the quickest way to resolve this.

Sure. It's the default config but with the line you suggested added where the shell setting normally is (I've also put it at the top/bottom). I'm using Ubuntu 16.04 LTS and the latest version of MacOS. My default shell is fish, though I've tried setting bash as the default and putting zsh in the config with the same results.
# Configuration for Alacritty, the GPU enhanced terminal emulator
#

# Any items in the `env` entry below will be added as
# environment variables. Some entries may override variables
# set by alacritty it self.
env:
  # TERM env customization.
  #
  # If this property is not set, alacritty will set it to xterm-256color.
  #
  # Note that some xterm terminfo databases don't declare support for italics.
  # You can verify this by checking for the presence of `smso` and `sitm` in
  # `infocmp xterm-256color`.
  TERM: xterm-256color

window:
  # Window dimensions in character columns and lines
  # Falls back to size specified by window manager if set to 0x0.
  # (changes require restart)
  dimensions:
    columns: 80
    lines: 24

  # Adds this many blank pixels of padding around the window
  # Units are physical pixels; this is not DPI aware.
  # (change requires restart)
  padding:
    x: 2
    y: 2

  # Window decorations
  # Setting this to false will result in window without borders and title bar.
  decorations: true

# Display tabs using this many cells (changes require restart)
tabspaces: 8

# When true, bold text is drawn using the bright variant of colors.
draw_bold_text_with_bright_colors: true

# Font configuration (changes require restart)
#
# Important font attributes like antialiasing, subpixel aa, and hinting can be
# controlled through fontconfig. Specifically, the following attributes should
# have an effect:
#
# * hintstyle
# * antialias
# * lcdfilter
# * rgba
#
# For instance, if you wish to disable subpixel antialiasing, you might set the
# rgba property to "none". If you wish to completely disable antialiasing, you
# can set antialias to false.
#
# Please see these resources for more information on how to use fontconfig
#
# * https://wiki.archlinux.org/index.php/font_configuration#Fontconfig_configuration
# * file:///usr/share/doc/fontconfig/fontconfig-user.html
font:
  # The normal (roman) font face to use.
  normal:
    family: monospace # should be "Menlo" or something on macOS.
    # Style can be specified to pick a specific face.
    # style: Regular

  # The bold font face
  bold:
    family: monospace # should be "Menlo" or something on macOS.
    # Style can be specified to pick a specific face.
    # style: Bold

  # The italic font face
  italic:
    family: monospace # should be "Menlo" or something on macOS.
    # Style can be specified to pick a specific face.
    # style: Italic

  # Point size of the font
  size: 11.0

  # Offset is the extra space around each character. offset.y can be thought of
  # as modifying the linespacing, and offset.x as modifying the letter spacing.
  offset:
    x: 0
    y: 0

  # Glyph offset determines the locations of the glyphs within their cells with
  # the default being at the bottom. Increase the x offset to move the glyph to
  # the right, increase the y offset to move the glyph upward.
  glyph_offset:
    x: 0
    y: 0

  # Scale the font size based on the monitor's DPI. This will lead to bigger text on HiDPI
  # screens and make reading text a little easier.
  # On X11 it is possible to change the DPI for each instance of alacritty by using
  # `WINIT_HIDPI_FACTOR=1.0 alacritty` to scale the font.
  scale_with_dpi: true

  # OS X only: use thin stroke font rendering. Thin strokes are suitable
  # for retina displays, but for non-retina you probably want this set to
  # false.
  use_thin_strokes: true

# Should display the render timer
render_timer: false

# Use custom cursor colors. If true, display the cursor in the cursor.foreground
# and cursor.background colors, otherwise invert the colors of the cursor.
custom_cursor_colors: false

# Colors (Tomorrow Night Bright)
colors:
  # Default colors
  primary:
    background: '0x000000'
    foreground: '0xeaeaea'

  # Colors the cursor will use if `custom_cursor_colors` is true
  cursor:
    text: '0x000000'
    cursor: '0xffffff'

  # Normal colors
  normal:
    black:   '0x000000'
    red:     '0xd54e53'
    green:   '0xb9ca4a'
    yellow:  '0xe6c547'
    blue:    '0x7aa6da'
    magenta: '0xc397d8'
    cyan:    '0x70c0ba'
    white:   '0xffffff'

  # Bright colors
  bright:
    black:   '0x666666'
    red:     '0xff3334'
    green:   '0x9ec400'
    yellow:  '0xe7c547'
    blue:    '0x7aa6da'
    magenta: '0xb77ee0'
    cyan:    '0x54ced6'
    white:   '0xffffff'

  # Dim colors (Optional)
  dim:
    black:   '0x333333'
    red:     '0xf2777a'
    green:   '0x99cc99'
    yellow:  '0xffcc66'
    blue:    '0x6699cc'
    magenta: '0xcc99cc'
    cyan:    '0x66cccc'
    white:   '0xdddddd'

# Visual Bell
#
# Any time the BEL code is received, Alacritty "rings" the visual bell. Once
# rung, the terminal background will be set to white and transition back to the
# default background color. You can control the rate of this transition by
# setting the `duration` property (represented in milliseconds). You can also
# configure the transition function by setting the `animation` property.
#
# Possible values for `animation`
# `Ease`
# `EaseOut`
# `EaseOutSine`
# `EaseOutQuad`
# `EaseOutCubic`
# `EaseOutQuart`
# `EaseOutQuint`
# `EaseOutExpo`
# `EaseOutCirc`
# `Linear`
#
# To completely disable the visual bell, set its duration to 0.
#
visual_bell:
  animation: EaseOutExpo
  duration: 0

# Background opacity
background_opacity: 1.0

# Mouse bindings
#
# Currently doesn't support modifiers. Both the `mouse` and `action` fields must
# be specified.
#
# Values for `mouse`:
# - Middle
# - Left
# - Right
# - Numeric identifier such as `5`
#
# Values for `action`:
# - Paste
# - PasteSelection
# - Copy (TODO)
mouse_bindings:
  - { mouse: Middle, action: PasteSelection }

mouse:
  # Click settings
  #
  # The `double_click` and `triple_click` settings control the time
  # alacritty should wait for accepting multiple clicks as one double
  # or triple click.
  double_click: { threshold: 300 }
  triple_click: { threshold: 300 }

  # Faux Scrollback
  #
  # The `faux_scrollback_lines` setting controls the number
  # of lines the terminal should scroll when the alternate
  # screen buffer is active. This is used to allow mouse
  # scrolling for applications like `man`.
  #
  # To disable this completely, set `faux_scrollback_lines` to 0.
  faux_scrollback_lines: 1

selection:
  semantic_escape_chars: ",│`|:\"' ()[]{}<>"

dynamic_title: true

hide_cursor_when_typing: false

# Style of the cursor
#
# Values for 'cursor_style':
# - Block
# - Underline
# - Beam
cursor_style: Block

# Live config reload (changes require restart)
live_config_reload: true

# Shell
#
# You can set shell.program to the path of your favorite shell, e.g. /bin/fish.
# Entries in shell.args are passed unmodified as arguments to the shell.
#
\n\nshell:\n program: /bin/bash\n args:\n - --login\n
# shell:
#   program: /bin/bash
#   args:
#     - --login

# Key bindings
#
# Each binding is defined as an object with some properties. Most of the
# properties are optional. All of the alphabetical keys should have a letter for
# the `key` value such as `V`. Function keys are probably what you would expect
# as well (F1, F2, ..). The number keys above the main keyboard are encoded as
# `Key1`, `Key2`, etc. Keys on the number pad are encoded `Number1`, `Number2`,
# etc.  These all match the glutin::VirtualKeyCode variants.
#
# A list with all available `key` names can be found here:
# https://docs.rs/glutin/*/glutin/enum.VirtualKeyCode.html#variants
#
# Possible values for `mods`
# `Command`, `Super` refer to the super/command/windows key
# `Control` for the control key
# `Shift` for the Shift key
# `Alt` and `Option` refer to alt/option
#
# mods may be combined with a `|`. For example, requiring control and shift
# looks like:
#
# mods: Control|Shift
#
# The parser is currently quite sensitive to whitespace and capitalization -
# capitalization must match exactly, and piped items must not have whitespace
# around them.
#
# Either an `action`, `chars`, or `command` field must be present.
#   `action` must be one of `Paste`, `PasteSelection`, `Copy`, or `Quit`.
#   `chars` writes the specified string every time that binding is activated.
#     These should generally be escape sequences, but they can be configured to
#     send arbitrary strings of bytes.
#   `command` must be a map containing a `program` string, and `args` array of
#     strings. For example:
#     - { ... , command: { program: "alacritty", args: ["-e", "vttest"] } }
#
# Want to add a binding (e.g. "PageUp") but are unsure what the X sequence
# (e.g. "\x1b[5~") is? Open another terminal (like xterm) without tmux,
# then run `showkey -a` to get the sequence associated to a key combination.
key_bindings:
  - { key: V,        mods: Control|Shift,    action: Paste               }
  - { key: C,        mods: Control|Shift,    action: Copy                }
  - { key: Paste,                   action: Paste                        }
  - { key: Copy,                    action: Copy                         }
  - { key: Q,        mods: Command, action: Quit                         }
  - { key: W,        mods: Command, action: Quit                         }
  - { key: Insert,   mods: Shift,   action: PasteSelection               }
  - { key: Key0,     mods: Control, action: ResetFontSize                }
  - { key: Equals,   mods: Control, action: IncreaseFontSize             }
  - { key: Subtract, mods: Control, action: DecreaseFontSize             }
  - { key: Home,                    chars: "\x1bOH",   mode: AppCursor   }
  - { key: Home,                    chars: "\x1b[H",   mode: ~AppCursor  }
  - { key: End,                     chars: "\x1bOF",   mode: AppCursor   }
  - { key: End,                     chars: "\x1b[F",   mode: ~AppCursor  }
  - { key: PageUp,   mods: Shift,   chars: "\x1b[5;2~"                   }
  - { key: PageUp,   mods: Control, chars: "\x1b[5;5~"                   }
  - { key: PageUp,                  chars: "\x1b[5~"                     }
  - { key: PageDown, mods: Shift,   chars: "\x1b[6;2~"                   }
  - { key: PageDown, mods: Control, chars: "\x1b[6;5~"                   }
  - { key: PageDown,                chars: "\x1b[6~"                     }
  - { key: Tab,      mods: Shift,   chars: "\x1b[Z"                      }
  - { key: Back,                    chars: "\x7f"                        }
  - { key: Back,     mods: Alt,     chars: "\x1b\x7f"                    }
  - { key: Insert,                  chars: "\x1b[2~"                     }
  - { key: Delete,                  chars: "\x1b[3~"                     }
  - { key: Left,     mods: Shift,   chars: "\x1b[1;2D"                   }
  - { key: Left,     mods: Control, chars: "\x1b[1;5D"                   }
  - { key: Left,     mods: Alt,     chars: "\x1b[1;3D"                   }
  - { key: Left,                    chars: "\x1b[D",   mode: ~AppCursor  }
  - { key: Left,                    chars: "\x1bOD",   mode: AppCursor   }
  - { key: Right,    mods: Shift,   chars: "\x1b[1;2C"                   }
  - { key: Right,    mods: Control, chars: "\x1b[1;5C"                   }
  - { key: Right,    mods: Alt,     chars: "\x1b[1;3C"                   }
  - { key: Right,                   chars: "\x1b[C",   mode: ~AppCursor  }
  - { key: Right,                   chars: "\x1bOC",   mode: AppCursor   }
  - { key: Up,       mods: Shift,   chars: "\x1b[1;2A"                   }
  - { key: Up,       mods: Control, chars: "\x1b[1;5A"                   }
  - { key: Up,       mods: Alt,     chars: "\x1b[1;3A"                   }
  - { key: Up,                      chars: "\x1b[A",   mode: ~AppCursor  }
  - { key: Up,                      chars: "\x1bOA",   mode: AppCursor   }
  - { key: Down,     mods: Shift,   chars: "\x1b[1;2B"                   }
  - { key: Down,     mods: Control, chars: "\x1b[1;5B"                   }
  - { key: Down,     mods: Alt,     chars: "\x1b[1;3B"                   }
  - { key: Down,                    chars: "\x1b[B",   mode: ~AppCursor  }
  - { key: Down,                    chars: "\x1bOB",   mode: AppCursor   }
  - { key: F1,                      chars: "\x1bOP"                      }
  - { key: F2,                      chars: "\x1bOQ"                      }
  - { key: F3,                      chars: "\x1bOR"                      }
  - { key: F4,                      chars: "\x1bOS"                      }
  - { key: F5,                      chars: "\x1b[15~"                    }
  - { key: F6,                      chars: "\x1b[17~"                    }
  - { key: F7,                      chars: "\x1b[18~"                    }
  - { key: F8,                      chars: "\x1b[19~"                    }
  - { key: F9,                      chars: "\x1b[20~"                    }
  - { key: F10,                     chars: "\x1b[21~"                    }
  - { key: F11,                     chars: "\x1b[23~"                    }
  - { key: F12,                     chars: "\x1b[24~"                    }
  - { key: F1,       mods: Shift,   chars: "\x1b[1;2P"                   }
  - { key: F2,       mods: Shift,   chars: "\x1b[1;2Q"                   }
  - { key: F3,       mods: Shift,   chars: "\x1b[1;2R"                   }
  - { key: F4,       mods: Shift,   chars: "\x1b[1;2S"                   }
  - { key: F5,       mods: Shift,   chars: "\x1b[15;2~"                  }
  - { key: F6,       mods: Shift,   chars: "\x1b[17;2~"                  }
  - { key: F7,       mods: Shift,   chars: "\x1b[18;2~"                  }
  - { key: F8,       mods: Shift,   chars: "\x1b[19;2~"                  }
  - { key: F9,       mods: Shift,   chars: "\x1b[20;2~"                  }
  - { key: F10,      mods: Shift,   chars: "\x1b[21;2~"                  }
  - { key: F11,      mods: Shift,   chars: "\x1b[23;2~"                  }
  - { key: F12,      mods: Shift,   chars: "\x1b[24;2~"                  }
  - { key: F1,       mods: Control, chars: "\x1b[1;5P"                   }
  - { key: F2,       mods: Control, chars: "\x1b[1;5Q"                   }
  - { key: F3,       mods: Control, chars: "\x1b[1;5R"                   }
  - { key: F4,       mods: Control, chars: "\x1b[1;5S"                   }
  - { key: F5,       mods: Control, chars: "\x1b[15;5~"                  }
  - { key: F6,       mods: Control, chars: "\x1b[17;5~"                  }
  - { key: F7,       mods: Control, chars: "\x1b[18;5~"                  }
  - { key: F8,       mods: Control, chars: "\x1b[19;5~"                  }
  - { key: F9,       mods: Control, chars: "\x1b[20;5~"                  }
  - { key: F10,      mods: Control, chars: "\x1b[21;5~"                  }
  - { key: F11,      mods: Control, chars: "\x1b[23;5~"                  }
  - { key: F12,      mods: Control, chars: "\x1b[24;5~"                  }
  - { key: F1,       mods: Alt,     chars: "\x1b[1;6P"                   }
  - { key: F2,       mods: Alt,     chars: "\x1b[1;6Q"                   }
  - { key: F3,       mods: Alt,     chars: "\x1b[1;6R"                   }
  - { key: F4,       mods: Alt,     chars: "\x1b[1;6S"                   }
  - { key: F5,       mods: Alt,     chars: "\x1b[15;6~"                  }
  - { key: F6,       mods: Alt,     chars: "\x1b[17;6~"                  }
  - { key: F7,       mods: Alt,     chars: "\x1b[18;6~"                  }
  - { key: F8,       mods: Alt,     chars: "\x1b[19;6~"                  }
  - { key: F9,       mods: Alt,     chars: "\x1b[20;6~"                  }
  - { key: F10,      mods: Alt,     chars: "\x1b[21;6~"                  }
  - { key: F11,      mods: Alt,     chars: "\x1b[23;6~"                  }
  - { key: F12,      mods: Alt,     chars: "\x1b[24;6~"                  }
  - { key: F1,       mods: Super,   chars: "\x1b[1;3P"                   }
  - { key: F2,       mods: Super,   chars: "\x1b[1;3Q"                   }
  - { key: F3,       mods: Super,   chars: "\x1b[1;3R"                   }
  - { key: F4,       mods: Super,   chars: "\x1b[1;3S"                   }
  - { key: F5,       mods: Super,   chars: "\x1b[15;3~"                  }
  - { key: F6,       mods: Super,   chars: "\x1b[17;3~"                  }
  - { key: F7,       mods: Super,   chars: "\x1b[18;3~"                  }
  - { key: F8,       mods: Super,   chars: "\x1b[19;3~"                  }
  - { key: F9,       mods: Super,   chars: "\x1b[20;3~"                  }
  - { key: F10,      mods: Super,   chars: "\x1b[21;3~"                  }
  - { key: F11,      mods: Super,   chars: "\x1b[23;3~"                  }
  - { key: F12,      mods: Super,   chars: "\x1b[24;3~"                  }

So it looks like there's some explicit \ns that snuck in there.
\n\nshell:\n program: /bin/bash\n args:\n - --login\n

Try changing that whole like to be:
shell:
  program: /bin/bash
  args:
    - --login

That's the way I'd had it originally, but just uncommenting the block in the default config is what gave me the original
Error: problem with config: while parsing a block mapping, did not find expected key at line 248 column 7; Loading default config
thing.

Here I've edited the config for you. I'm not really sure what editor you're using or how this is getting messed up, but deleting the messed up line (with \ns in it) and un-commenting the shell block works fine for me.

```
# Configuration for Alacritty, the GPU enhanced terminal emulator
#
Any items in the env entry below will be added as
environment variables. Some entries may override variables
set by alacritty it self.
env:
TERM env customization.

If this property is not set, alacritty will set it to xterm-256color.

Note that some xterm terminfo databases don't declare support for italics.
You can verify this by checking for the presence of smso and sitm in
infocmp xterm-256color.
TERM: xterm-256color
window:
Window dimensions in character columns and lines
Falls back to size specified by window manager if set to 0x0.
(changes require restart)
dimensions:
columns: 80
lines: 24
Adds this many blank pixels of padding around the window
Units are physical pixels; this is not DPI aware.
(change requires restart)
padding:
x: 2
y: 2
Window decorations
Setting this to false will result in window without borders and title bar.
decorations: true
Display tabs using this many cells (changes require restart)
tabspaces: 8
When true, bold text is drawn using the bright variant of colors.
draw_bold_text_with_bright_colors: true
Font configuration (changes require restart)

Important font attributes like antialiasing, subpixel aa, and hinting can be
controlled through fontconfig. Specifically, the following attributes should
have an effect:

* hintstyle
* antialias
* lcdfilter
* rgba

For instance, if you wish to disable subpixel antialiasing, you might set the
rgba property to "none". If you wish to completely disable antialiasing, you
can set antialias to false.

Please see these resources for more information on how to use fontconfig

* https://wiki.archlinux.org/index.php/font_configuration#Fontconfig_configuration
* file:///usr/share/doc/fontconfig/fontconfig-user.html
font:
The normal (roman) font face to use.
normal:
family: monospace # should be "Menlo" or something on macOS.
# Style can be specified to pick a specific face.
# style: Regular
The bold font face
bold:
family: monospace # should be "Menlo" or something on macOS.
# Style can be specified to pick a specific face.
# style: Bold
The italic font face
italic:
family: monospace # should be "Menlo" or something on macOS.
# Style can be specified to pick a specific face.
# style: Italic
Point size of the font
size: 11.0
Offset is the extra space around each character. offset.y can be thought of
as modifying the linespacing, and offset.x as modifying the letter spacing.
offset:
x: 0
y: 0
Glyph offset determines the locations of the glyphs within their cells with
the default being at the bottom. Increase the x offset to move the glyph to
the right, increase the y offset to move the glyph upward.
glyph_offset:
x: 0
y: 0
Scale the font size based on the monitor's DPI. This will lead to bigger text on HiDPI
screens and make reading text a little easier.
On X11 it is possible to change the DPI for each instance of alacritty by using
WINIT_HIDPI_FACTOR=1.0 alacritty to scale the font.
scale_with_dpi: true
OS X only: use thin stroke font rendering. Thin strokes are suitable
for retina displays, but for non-retina you probably want this set to
false.
use_thin_strokes: true
Should display the render timer
render_timer: false
Use custom cursor colors. If true, display the cursor in the cursor.foreground
and cursor.background colors, otherwise invert the colors of the cursor.
custom_cursor_colors: false
Colors (Tomorrow Night Bright)
colors:
Default colors
primary:
background: '0x000000'
foreground: '0xeaeaea'
Colors the cursor will use if custom_cursor_colors is true
cursor:
text: '0x000000'
cursor: '0xffffff'
Normal colors
normal:
black:   '0x000000'
red:     '0xd54e53'
green:   '0xb9ca4a'
yellow:  '0xe6c547'
blue:    '0x7aa6da'
magenta: '0xc397d8'
cyan:    '0x70c0ba'
white:   '0xffffff'
Bright colors
bright:
black:   '0x666666'
red:     '0xff3334'
green:   '0x9ec400'
yellow:  '0xe7c547'
blue:    '0x7aa6da'
magenta: '0xb77ee0'
cyan:    '0x54ced6'
white:   '0xffffff'
Dim colors (Optional)
dim:
black:   '0x333333'
red:     '0xf2777a'
green:   '0x99cc99'
yellow:  '0xffcc66'
blue:    '0x6699cc'
magenta: '0xcc99cc'
cyan:    '0x66cccc'
white:   '0xdddddd'
Visual Bell

Any time the BEL code is received, Alacritty "rings" the visual bell. Once
rung, the terminal background will be set to white and transition back to the
default background color. You can control the rate of this transition by
setting the duration property (represented in milliseconds). You can also
configure the transition function by setting the animation property.

Possible values for animation
Ease
EaseOut
EaseOutSine
EaseOutQuad
EaseOutCubic
EaseOutQuart
EaseOutQuint
EaseOutExpo
EaseOutCirc
Linear

To completely disable the visual bell, set its duration to 0.

visual_bell:
animation: EaseOutExpo
duration: 0
Background opacity
background_opacity: 1.0
Mouse bindings

Currently doesn't support modifiers. Both the mouse and action fields must
be specified.

Values for mouse:
- Middle
- Left
- Right
- Numeric identifier such as 5

Values for action:
- Paste
- PasteSelection
- Copy (TODO)
mouse_bindings:

{ mouse: Middle, action: PasteSelection }

mouse:
Click settings

The double_click and triple_click settings control the time
alacritty should wait for accepting multiple clicks as one double
or triple click.
double_click: { threshold: 300 }
triple_click: { threshold: 300 }
Faux Scrollback

The faux_scrollback_lines setting controls the number
of lines the terminal should scroll when the alternate
screen buffer is active. This is used to allow mouse
scrolling for applications like man.

To disable this completely, set faux_scrollback_lines to 0.
faux_scrollback_lines: 1
selection:
semantic_escape_chars: ",│`|:"' ()[]{}<>"
dynamic_title: true
hide_cursor_when_typing: false
Style of the cursor

Values for 'cursor_style':
- Block
- Underline
- Beam
cursor_style: Block
Live config reload (changes require restart)
live_config_reload: true
Shell

You can set shell.program to the path of your favorite shell, e.g. /bin/fish.
Entries in shell.args are passed unmodified as arguments to the shell.

shell:
program: /bin/bash
args:
- --login
Key bindings

Each binding is defined as an object with some properties. Most of the
properties are optional. All of the alphabetical keys should have a letter for
the key value such as V. Function keys are probably what you would expect
as well (F1, F2, ..). The number keys above the main keyboard are encoded as
Key1, Key2, etc. Keys on the number pad are encoded Number1, Number2,
etc.  These all match the glutin::VirtualKeyCode variants.

A list with all available key names can be found here:
https://docs.rs/glutin/*/glutin/enum.VirtualKeyCode.html#variants

Possible values for mods
Command, Super refer to the super/command/windows key
Control for the control key
Shift for the Shift key
Alt and Option refer to alt/option

mods may be combined with a |. For example, requiring control and shift
looks like:

mods: Control|Shift

The parser is currently quite sensitive to whitespace and capitalization -
capitalization must match exactly, and piped items must not have whitespace
around them.

Either an action, chars, or command field must be present.
action must be one of Paste, PasteSelection, Copy, or Quit.
chars writes the specified string every time that binding is activated.
These should generally be escape sequences, but they can be configured to
send arbitrary strings of bytes.
command must be a map containing a program string, and args array of
strings. For example:
- { ... , command: { program: "alacritty", args: ["-e", "vttest"] } }

Want to add a binding (e.g. "PageUp") but are unsure what the X sequence
(e.g. "\x1b[5~") is?  As you have also mentioned this is very likely just an issue with improper configuration.
It's important with YAML to always have consistent indentation, otherwise things will get messed up. So just removing the # from the beginning of the lines would leave it with one whitespace too much for example.

Dunce hat for me, I didn't know yaml was sensitive to leading white space. Thanks for the help nixpulvis and chrisduerr, it's working properly with that edit.


[Proposal] Do not require a user session for Echo private channels to work

Laravel Version: 5.5.40
PHP Version: 7.1

Description:
I am working on an application that requires client events to be emitted/subscribed to without the user being logged in.
The problem, however, is that the framework seems to be constructed in such a way that this is not possible:
PusherBroadcaster.php auth method
if (Str::startsWith($request->channel_name, ['private-', 'presence-']) &&
    ! $request->user()) {
    throw new AccessDeniedHttpException;
}

My proposal is to remove this check, for the following reasons:

The channels.php has been created with the sole purpose of defining "Gates" for channels.
If my private channel name is defined in the channels.php, the broadcaster should evaluate it.
If $user is null, I should still be able to perform return true or false based on my own logic.

This would be a great improvement in scenarios where users are "authenticated" through a unique URL. In the application I am working on right now, the only thing I want to evaluate is whether this unique URL is valid. It has nothing to do with a "User" model, so limiting the whisper feature to authenticated users is something that should be implemented in the application, not the framework.
Would love to hear your thoughts on this.
If anyone has ideas to work around this limitation, I'm open to suggestions as well.

Issues in this repo are for bug reports only.  Please close this issue, and open an issue in laravel/ideas

Argh sorry, my bad.


Live chart is broken

Since some people starred this repo, I would like to point out that the live chart does not work because melon updated how their live chart is displayed on their welcome, I think they removed the numbering as well. I'll take a took at this this weekend.

aight should be gucci now


feat: allow parsing of Azure DevOps

Handle AzureDevOps URLs

@mcuadros @jfontan Can this merged shortly? I would like to use the module in my CLI for Azure DevOps. https://github.com/tmeckel/azdo-cli

@mcuadros LGTM. You can merge

@jfontan This was quick! ❤ 👍🏼 AWESOME!

@mcuadros any interest in merging this PR? Or shall we consider this repo dead ☠? In that case I'd create a fork of my own.


No verified traffic flows

Describe the bug
When running the bngblaster against our DUT, the sessions get setup and traffic is being sent and received ok. The bngblaster is being hosted on a server with one Intel 810-C NIC. However, the bngblaster does not appear to match the RX flows to generate the verified traffic flows view.
Sessions               1 (1 PPPoE / 0 IPoE)
Established          1 [############################################################]
...
Network Interface ( ens5f1 )
Tx Packets                         0 |      0 PPS          0 Kbps
Rx Packets                         8 |      0 PPS          0 Kbps
Tx Multicast Packets          0 |      0 PPS
Access Interface ( ens5f0 )
Tx Packets                        17 |      0 PPS          0 Kbps
Rx Packets                        14 |      0 PPS          0 Kbps
When saving the packets to the pcap file, we see that the packets look correctly formed, and the header is present as well.

Any clues on how to debug the issue further?
Version (`bngblaster -v`):
commit 8f8e53624a02d3f56631c99cca76ea0549c083ba (HEAD -> main, origin/main, origin/HEAD)
Merge: fd1a4dd 4276acc
Author: Christian Giese<EMAIL_ADDRESS>Date:   Fri Apr 8 15:16:17 2022 +0200

    Merge branch 'dev' into main

JSON configuration:
{
    "interfaces": {
        "tx_interval": 0.1,
        "rx_interval": 0.1,
        "capture-include-streams": true,
        "access": {
            "interface": "ens5f0",
            "outer-vlan-min": 400,
            "outer-vlan-max": 400,
            "inner-vlan-min": 2,
            "inner-vlan-max": 2000,
            "vlan-mode": "1:1",
            "authentication-protocol": "CHAP",
            "type": "pppoe",
            "stream-group-id": 1,
            "address": "<IP_ADDRESS>",
            "network-interface": "ens5f1"
        },
        "network": {
            "interface": "ens5f1",
            "address": "<IP_ADDRESS>"
        }
    },
    "sessions": {
        "count": 1,
        "session-time": 0,
        "max-outstanding": 1000,
        "start-rate": 400,
        "stop-rate": 400
    },
    "pppoe": {
        "service-name": "bisdn",
        "reconnect": true,
        "discovery-timeout": 3,
        "discovery-retry": 10
    },
    "ppp": {
        "mru": 1382,
        "authentication": {
                "username": "testing",
                "password": "testing"
        },
    "ipcp": {
                "enable": true,
                "request-ip": true,
                "request-dns1": false,
                "request-dns2": false
    },
    "ip6cp": {
        "enable": false
    }
    },
    "streams": [
        {
                "name": "BestEffort",
                "stream-group-id": 1,
                "type": "ipv4",
                "direction": "upstream",
                "pps": 1,
                "length": 1000,
                "destination-ipv4-address": "<IP_ADDRESS>",
                "network-interface": "ens5f1"
        }
    ]
}

Let me try to reproduce this.

Okay issue found, you need to configure a gateway IP address under your network interface. The reason is that the BNG Blaster ignores all ARP requests except those from the configured gateway IP address. Will think about changing this, but for now this should fix your issue.

On the capture shared, the destination MAC address seems to be wrong and the BNG Blaster drops all traffic that is not sent to the correct MAC address.
https://github.com/rtbrick/bngblaster/blob/1b474dc3692f4798e237912eea845821fec40b05/code/bngblaster/src/bbl_rx.c#L1910
You could remove this check from code, build and try again but in general, your BNG should send traffic to the correct MAC address.

Now everything working as expected! Thanks for the code pointer, also on the MAC address, was easy to skip that debugging.

Please close the issue if the solution is accepted!

Done, thanks.


master to live

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/NuGet/docs.microsoft.com-nuget, working directory: W:\rvsv-s, target branch: live, target branch commit: 1d1406764c6af5fb7801d462e0c4afc9092fa569, source branch: master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU3028.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-4.8-RTM.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU3028.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-4.8-RTM.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


VTOL Check body frame X velocity for back transition completion

During back transition in a cross wind the vehicle can drift sideways preventing the current velocity check from triggering.
Using control state,x_vel will only check forward velocity (body frame) and trigger if it falls below MPC cruise speed.
It is my assumption that _local_pos->v_xy_valid still needs to be true for control_state.x_vel to have a meaningful value.
@dagar @bresch please review

We're getting rid of control_state.

oh.. Anywhere where i can easily get forward velocity?

@mhkabir I see control_state being used in several places. I assume this will be replaced by something else if control_state will disappear. Considering these other placed (like rover and land detector) will have to be updated and the body velocity information will have to be published somewhere else, I propose to leave this as if for now and get it migrated to a new topic when all the other are too.
Agree?

This PR gets rid of it. https://github.com/PX4/Firmware/pull/7882


Crash on Zing while doing lock profiling

I've observed a JVM crash while doing lock profiling on Zing JVM. Here is a redacted portion of the crash log:
#
# An unexpected error has been detected by Java Runtime Environment:
#
#  Internal Error (src/share/runtime/thread.cpp:604), pid=176401, tid=177505
#  guarantee(thread == this && JavaThread::current()->jvm_locked_by_self()) failed: _ref_buffer_array without jvm_lock
#
# Java VM: Zing 64-Bit Tiered VM (1.8.0_282-zing_<IP_ADDRESS>-b3-product-azlinuxM-X86_64, mixed mode)
# If you would like to submit a bug report, please visit:
#   http://www.azul.com/support/
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

---------------  T H R E A D  ---------------

Current thread (0x62006c600000):  JavaThread "<redacted>" [JVM thread_state=_thread_in_native, locked by self running, polling bits: NONE , id=177505, stack(0x7f275a3f3000,0x7f275a5f3000), java prio=5, os prio=0, sched=SCHED_OTHER]

Stack: [0x7f275a3f3000,0x7f275a5f3000],  sp=0x7f275a5ef2b0,  free space=2032k
Native frames: (J Jn Jo=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x9fbc12]  VMError::report(staticBufferStream*)+0x972
V  [libjvm.so+0x9fcd9e]  VMError::report_and_die()+0x21e
V  [libjvm.so+0x9e1777]  report_vm_error(char const*, int, char const*, char const*)+0x57
V  [libjvm.so+0x9420c3]  Thread::set_old_gen_ref_buffer(HeapRefBuffer*)+0x1e3
V  [libjvm.so+0x33354d]  oopDesc* GPGC_LVB::lvb_oop_fixup<(OopHelper::EncodingHint)0>(oopDesc*, oopDesc* volatile*)+0x16d
V  [libjvm.so+0x80e356]  JvmtiEnvBase::get_stack_trace(JavaThread*, int, int, _jvmtiFrameInfo*, int*)+0x7a6
V  [libjvm.so+0x7ff7b4]  JvmtiEnv::GetStackTrace(JavaThread*, int, int, _jvmtiFrameInfo*, int*)+0xb4
C  [libasyncProfiler.so+0x2687f]  Profiler::recordSample(void*, unsigned long long, int, Event*)+0x26f
C  [libasyncProfiler.so+0x22073]  LockTracer::MonitorContendedEntered(_jvmtiEnv*, JNIEnv_*, _jobject*, _jobject*)+0x123
V  [libjvm.so+0x821fab]  JvmtiExport::post_monitor_contended_entered(JavaThread*, ObjLock*)+0x21b
V  [libjvm.so+0x8effec]  ObjLock::enter(JavaThread*)+0x41c
V  [libjvm.so+0x9373ac]  ObjectSynchronizer::lock(oopDesc*, MonitorInflateCallerId)+0x38c
V  [libjvm.so+0x91f876]  SharedRuntime::monitorenter(JavaThread*, oopDesc*)+0x96
v        ~StubRoutines::c2_lock
...

How often does it happen? Do you have a reliable reproducer?
I have a guess why this could happen, but it would be nice to have a test to verify the idea.

@apangin It happened twice while collecting several dozens of profiles for different event types. I assume that it happened while collecting the lock profile, because the stacktrace contains [libasyncProfiler.so+0x22073]  LockTracer::MonitorContendedEntered.
Unfortunately I no longer have access to the system where the crash was observed and so far I was not able to reproduce it locally.

Zing support is not among current async-profiler priorities, sorry. I may reconsider this, if there are customers willing to sponsor Zing-related work. Since the problem cannot be reproduced easily, I don't think it worth spending more time on it.

Hi @apangin and @vyazelenko,
This issue is in a way a manifestation of "incorrect" use of internal apis of hotspot. Let me explain.
Hotspot provided few public apis to collect stack trace. Few examples
a) AsyncGetCallTrace
b) JVMTI
What these apis expected to do are thread contract checks. for ex:
a) Is Thread qualified to collect stack trace ?
b) Is Thread in expected thread "state" and transition to correct "state" to collect stack trace and more..
Missing the contract checks can have various manifestations and can possibly run into issues in future if not now.
So why am i explaining all these for this issue ?
AsyncProfiler seems to  find an "internal" jvm function and calling it.
This direct calling of internal function lead the thread to enter hotspot code without "proper" thread state transition. If you are aware of hotspot code, there is macro called "JNI_ENTRY" which does all these for thread.
Issue manifested saying, "Thread isn't qualified to access oops (java objects) directly at this point".  Proper thread state transition would make thread to qualify for entering hotspot code.
Now why is it  happening with Zing.  Zing puts all its Classes and methods info in Perm Gen (Relocatable heap) and have explained about this here in detail.
What are our possible next steps ?
a) We should avoid calling this "internal function".  This is potential maintenance issue for the async profiler. See we have to find two different symbols by the cpp compiler "demangled" names.  Note that proper public facing apis aren't demangled and available for dlsym search.
b) For the above, we need to understand the reason for using "internal" function instead  of calling the public api. Reading the history of changes, it seems like, we used this to handle incorrect thread state. If thread is in correct state, this could be a hotspot bug too. Understanding the issue and fixing it at right place will avoid doing this. I can volunteer to help if you provide details of the original issue.
Thanks,
Leela

That was my guess as well. Thank you for the detailed explanation how it works in Zing.
My long-term plan is to get rid of internal calls altogether, including AsyncGetCallTrace.


phpstan complains about method getAddresses

Hi Zaahid,
Code in question:
            $toAddresses = $email->getHeader('To');             foreach ($toAddresses->getAddresses() as $address) {                 $toName = $address->getName();                 $toEmail = $address->getEmail();             }
phpstan complains:
Cannot call method getAddresses() on ZBateson\MailMimeParser\Header\IHeader
Adding getAddresses to IHeader.php interface file fixes the issue in phpstan but generates a different issue in the code
PHP Fatal error:  Class ZBateson\MailMimeParser\Header\GenericHeader contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (ZBateson\MailMimeParser\Header\IHeader::getAddresses)
Any way to resolve the issue and make phpstan happy??
Meint

Hi @postme ,
Aah, sounds good!  I had replied on the pull request about this instead of here, hope you saw that and it helped :)


Can't get launcher tokens

Despite my several attempts I can't get the client launcher token I can't find any address in Fiddler corresponding to /account/api/oauth/token the only other mentions I found when doing a search are this one but I don't think they are the right ones
Does anyone have a technique to access the tokens?
Thank you.

Use the ones in Readme

I tried, but it doesn't work...

Can you show your code?

here is my code :

it works for me, do you have 2 factor authentification ?

Yes, I enabled it.

I checked and it shouldn't be a problem,you could try and isable it to see if it fixes anything , when does it break, on startup? Or when I tries to get the refresh token?

It breaks at the time of the fortniteAPI.login() by putting a catch() I was able to get this information :
{ message:
   'Please enter good credentials (Login/Username/Launcher Token)',
  err:
   { Error: Request failed with status code 431
       at createError (D:\Projet\bot-fortnite-shop\node_modules\axios\lib\core\createError.js:16:15)
       at settle (D:\Projet\bot-fortnite-shop\node_modules\axios\lib\core\settle.js:17:12)
       at IncomingMessage.handleStreamEnd (D:\Projet\bot-fortnite-shop\node_modules\axios\lib\adapters\http.js:237:11)
       at IncomingMessage.emit (events.js:194:15)
       at endReadableNT (_stream_readable.js:1125:12)
       at process._tickCallback (internal/process/next_tick.js:63:19)
     config:
      { url:
         'https://account-public-service-prod03.ol.epicgames.com/account/api/oauth/token',
        method: 'post',
        data:
         'grant_type=password&username=<username>&password=<password>&includePerms=true',
        headers: [Object],
        transformRequest: [Array],
        transformResponse: [Array],
        timeout: 0,
        adapter: [Function: httpAdapter],
        responseType: 'json',
        xsrfCookieName: 'XSRF-TOKEN',
        xsrfHeaderName: 'X-XSRF-TOKEN',
        maxContentLength: -1,
        validateStatus: [Function: validateStatus] },
     request:
      ClientRequest {
        _events: [Object],
        _eventsCount: 6,
        _maxListeners: undefined,
        output: [],
        outputEncodings: [],
        outputCallbacks: [],
        outputSize: 0,
        writable: true,
        _last: true,
        chunkedEncoding: false,
        shouldKeepAlive: false,
        useChunkedEncodingByDefault: true,
        sendDate: false,
        _removedConnection: false,
        _removedContLen: false,
        _removedTE: false,
        _contentLength: null,
        _hasBody: true,
        _trailer: '',
        finished: true,
        _headerSent: true,
        socket: [TLSSocket],
        connection: [TLSSocket],
        _header:
         'POST /account/api/oauth/token HTTP/1.1\r\nAccept: application/json, text/plain, */*\r\nContent-Type: application/x-www-form-urlencoded\r\nAuthorization: basic MzQ0NmNkNzI2OTRjNGE0NDg1ZDgxYjc3YWRiYjIxNDE6OTIwOWQ0YTVlMjVhNDU3ZmI5YjA3NDg5ZDMxM2I0MWE=\r\nUser-Agent: axios/0.19.0\r\nContent-Length: 94\r\nHost: account-public-service-prod03.ol.epicgames.com\r\nConnection: close\r\n\r\n',
        _onPendingData: [Function: noopPendingOutput],
        agent: [Agent],
        socketPath: undefined,
        timeout: undefined,
        method: 'POST',
        path: '/account/api/oauth/token',
        _ended: true,
        res: [IncomingMessage],
        aborted: undefined,
        timeoutCb: null,
        upgradeOrConnect: false,
        parser: null,
        maxHeadersCount: null,
        _redirectable: [Writable],
        [Symbol(isCorked)]: false,
        [Symbol(outHeadersKey)]: [Object] },
     response:
      { status: 431,
        statusText: '',
        headers: [Object],
        config: [Object],
        request: [ClientRequest],
        data: [Object] },
     isAxiosError: true,
     toJSON: [Function] } }

431 Request Header Fields Too Large
This can be caused because one of the fields in the header is too long

what version are you using

This error is strange combined my password and email address are only 35 characters in length.

I know that sometimes, 2FA generate some problems in login. Can you try to disable it and try again ?

To check, I have run my tests, and everything is working. (https://github.com/qlaffont/fortnite-api/blob/master/test/index.js)
TOKEN_LAUNCHER="MzQ0NmNkNzI2OTRjNGE0NDg1ZDgxYjc3YWRiYjIxNDE6OTIwOWQ0YTVlMjVhNDU3ZmI5YjA3NDg5ZDMxM2I0MWE=";
TOKEN_CLIENT="ZWM2ODRiOGM2ODdmNDc5ZmFkZWEzY2IyYWQ4M2Y1YzY6ZTFmMzFjMjExZjI4NDEzMTg2MjYyZDM3YTEzZmM4NGQ=";

Can confirm, you need to disable two factor authentication of your Epic Games account, if not, the API will throw 431 Request Header Fields Too Large

Also, a tip for anyone that tried creating a alt Epic Games account to use the API (just so you didn't need to disable 2FA on your main account): You need to login into Fortnite at least once, if you don't do that, the API will throw 403 Forbidden (and some endpoints, like the player status, will return "Player not found" even if the player exists)
@qlaffont I think it would be nice if you added to the readme that:

You need to disable two factor authentication before using the API, or else it will throw errors
You need to login at least once to Fortnite to the API to work, if not it will throw 403 Forbidden errors.

Just so other people doesn't get stuck on the same issues! 😊

Yes, no problem I will edit the readme ;).

Sorry for the long absence.
I just did what you were advised and it works
Thank you very much !


Fix executehandler.js

Hello, a small bug fix: the package name was mixed up with the method name

Thanks. This has been fixed in v1.0.1.


Fixes for sql errors & incorrect config

Fixed several SELECT statements
Fixed table name typo
Fixed incorrect config being used in function.php & index.php
Fixed VIP Settings page URL regex

Thanks, kisses ;*


⚠ ClamAV has degraded performance

In 447a6d3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 211 ms

Resolved: ClamAV performance has improved in 495c184.


testnets: add an ERC20-like 10e18 asset to Pasiphae allocations.

We updated the Amount type to be 128-bits, but stalled out on eliminating all our previous uses of u64s, and on ensuring that we correctly handled 128-bit amount values in the client logic.
This commit adds a pusd denom to the testnets (a fake USDC) with a 10e18 display denomination to force the issue, adds it to the base allocations (including the test account), and updates the network integration test to send 20pusd (an amount of the base denom which is greater than u64::MAX).
To merge this PR and ship the Pasiphae allocations, we'll need to ensure that we can actually correctly handle 128-bit amounts.

We might want to let this slip into the following testnet, but I think this will be the best way to ensure that we can actually handle 128-bit note values.  In the meantime, we can poke at this PR when we have time.

Closing this out, I think we should aim to do this in the next sprint instead.


Adding costume attributes to

Is it possible to add a costume property like webkitdirectory into input element?
 <button ng-file-select ng-model="myFolder" ng-multiple="true" webkitdirectory>Upload folder</button>

Not at the moment, User input type="file" instead.

I think it makes sense to use <input type="file"... for these cases since those attributes are for that specific element.
The problem is that if you don't use input type file an invisible input type file will be created inside that element and there is no way to tell which directive/attribute is for which element. For example there might be a directive or attribute which is only for button and you don't want it to be on the input so I cannot just copy all attributes to input element.

fixed in version 2.2.1.
You can prefix the attribute with '(data-)input-file-and it would propagate it to the underlying input type file. In this caseUpload folder`


1.0.4

1.0.4

Coverage remained the same at 94.528% when pulling abf9ecd2d58acc67271ce727461d3557108d141f on development into edf61f0508f1caf38ca3406df0447b1fa2550d30 on master.


cmd/go: TestScript/cover_pkgall_multiple_mains broken at head

It's not clear to me when it regressed; it was masked in the dashboard by #31263. 😞
I'll try bisecting.
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/cover_pkgall_multiple_mains (14.06s)
        script_test.go:192:
            # This test checks that multiple main packages can be tested
            # with -coverpkg=all without duplicate symbol errors.
            # Verifies golang.org/issue/30374. (14.057s)
            > env GO111MODULE=on
            > [short] skip
            > go test -coverpkg=all ./...
            [stdout]
            ?   	example.com/cov/mainonly	[no test files]
            FAIL	example.com/cov/mainwithtest [build failed]
            FAIL	example.com/cov/xtest [build failed]
            [stderr]
            # example.com/cov/xtest.test
            2019/05/10 14:46:08 duplicate symbol main.main (types 1 and 1) in main and $WORK/b059/_pkg_.a(_go_.o)
            # example.com/cov/mainwithtest.test
            2019/05/10 14:46:08 duplicate symbol main.main (types 1 and 1) in main and $WORK/b054/_pkg_.a(_go_.o)
            [exit status 2]
            FAIL: testdata/script/cover_pkgall_multiple_mains.txt:9: unexpected command failure

FAIL

CC @jayconrod

git bisect points to CL 174657 (CC @cherrymui @aclements).

Duplicate of #31946


[fix #676] Add support for EDUPUB dc:type "education"

Fixes #676

I wouldn't expend much effort making edupub work anymore. I don't get the impression it's long for this world as a profile.

I wouldn't expend much effort making edupub work anymore. I don't get the impression it's long for this world as a profile.

Right. But it wasn't too costly a change, and was the opportunity to improve a couple things (see the first 2 commits) :-)

OPF-064 isn't covered by a test anymore.

Damned. Forgot to test the coverage test, which I usually disable in my dev setup. I'll have a look.

@rdeltour can you please have another look at this in the next 2 weeks? Otherwise I'll postpone it to the backlog.

Removing from 4.1.0 milestone. Feel free to work on it and assign it back to 4.1.0 as long as we're still working on it.

Closing this old PR, since additional support  for EDUPUB is currently out of scope.


Compile tensorflow with compile option "-xMIC-AVX512" does not work

Hi, All
I want to use AVX512 with tensorflow because vectorization can increase performance.
In addition, building any program with icpc(Intel compiler) and compile option "-xMIC-AVX512" can vectorize automatically in state-of-art Intel machine.
So, I use the command as below:
CC=icpc bazel build -c opt --copt=-xMIC-AVX512 //tensorflow/tools/pip_package:build_pip_package
But when I type the command, build does not work.
What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?

Nothing exist related my issue in GitHub or StackOverflow

Environment info

Operating System: Centos 7.2.1511
Tensorflow version: r0.10.0 source code version
Only use CPU

What other attempted solutions have you tried?
As far as I know, linear algebra library for Tensorflow is "Eigen library" and SIMD vectorizations(like SSE, AVX, etc.) are applied to the Eigen library.
So, I changed Eigen source code to apply the AVX512 and gcc compile option "-mavx512f" referring two links(eigen bug report, Benoit Steiner's Bitbucket), but I didn't apply AVX512 because there was little information about that.
If someone know the method about applying AVX512 or the date to release Eigen version with AVX512,  please tell me about that.
Thank you very much.

Few months ago I was able to compile tf for knl with gcc 6.1.0 and some gcc patches. But in the end I was unable to get good performance. I used good flags but seems like poor vectorization.
Somebody can add more info on this?

BTW, I ran all the tf tests under avx2 about 12 months ago, and there were several ops which gave incorrect answers or failed (alignment problems). At that point @benoitsteiner has fixed them in Eigen, but I'm not sure anyone tried testing advanced flags since then (it's not part of CI pipeline for sure), so there's a chance you get unexpected/incorrect results

Support for AVX512 in TensorFlow is still a work in progress. I'll link to the relevant code changes as we make them to keep everyone updated.

@tripiana @yaroslavvb thank you for attention of my question :)
@benoitsteiner I'm really happy to hear that. If you don't mind, would you tell me  approximate date(e.g. about a month) to link the relevant code? Thank you so much!

@benoitsteiner Is it still going on? I waited until a month but  I don't have any information about that. I am very appreciated if you tell me the progress, Thank you!

The code that adds support for AVX512 to Eigen is pending a review before I can merge it (https://bitbucket.org/eigen/eigen/pull-requests/235). Once it's in I'll update TensorFlow to make use of the new capability.

I think It's almost finished. Thank you for your support.

Just to confirm, is it safe to compile with avx2 or not? @yaroslavvb was mentioning possible bugs / numerical errors.

@benoitsteiner I'm keen to test this. Are you planning to update TensorFlow soon? Thanks.

@alquraishi  - it should be safe to run with avx2, yes.  (Run the tests to be sure, of course, but it gets routinely used.)
Note that in general, -mavx will probably get you a lot of the performance boosts, since what avx2 adds over avx is primarily integer support, and -mavx already has the wider vector float support.  I haven't surveyed it, but -mavx is used widely.  But you're safe using -mavx2 if you have it.

Does Eigen support AVX512 in tf now ?

@benoitsteiner  Hi, this command "CC=icpc bazel build -c opt --copt=-xMIC-AVX512 //tensorflow/tools/pip_package:build_pip_package" still can't be applied on KNL server. Is the new tensorflow merged?

@yaroslavvb Hi,I can't even build with icpc as:"CC=icpc bazel build -c opt  //tensorflow/tools/pip_package:build_pip_package".  Can you give some help?

@craftlk I overwrite the CROSSTOOL under subdir in bazel-tensorflow and that worked.
By the way  eigen said that they support AVX-512 now(Eigen3.3.0/Tensorflow0.11+/require --copt='-DEIGEN_ENABLE_AVX512)
On the other hand @benoitsteiner implemented the AVX-512 support for Fixedpoint last week. However, due to the use of AVX-512 DQ in that part, that implement cannot compiling on KNL.

@c0710204 Hi, I want to know detailed information about how you compile tensorflow with AVX 512.
When I used option '--copt=-DEIGEN_ENABLE_AVX512', compiling the source code is okay, but there was no speedup. (I think the option was not applied)
So, I want to know what is your version of tensorflow and compiling command.
Additionally, If you use further action, please tell me about that.
Thank you.

@sjlee7748 Do you also add the  the avx512 compile flag like ‘--copt=“-mavx512f”'?  You can add macro to Eigen code to check it worked or not. The version I used is before the avx-512 Fixedpoint function add into the tensorflow(because I used the Xeon-phi when i build)
The command I used is
bazel build --ignore_unsupported_sandboxing -c opt //tensorflow/tools/pip_package:build_pip_package  --copt "-mavx512f" --copt "-mavx512cd" --copt "-mavx512er" --copt "-mavx512pf" --copt "-mavx2" --copt "-fopt-info-vec-all" --copt "-DEIGEN_ENABLE_AVX512" --copt "-DEIGEN_ENABLE_AVX2"  --verbose_failures   -j 64

@c0710204 When I used your command, I had below errors.
gcc: error: unrecognized command line option '-mavx512f'
gcc: error: unrecognized command line option '-mavx512cd'
gcc: error: unrecognized command line option '-mavx512er'
gcc: error: unrecognized command line option '-mavx512pf'
I think this error related with Tensorflow , OS and GCC version, but I don't know what is the best combination. Please tell me about that.
( I have executed tensorflow 0.12.0 version with CentOS 7.2 and GCC 4.8.5)
Thank you.

Oh ,sorry.I forgot the gcc version.To use avx-512, you must use gcc 4.9+ (I suggest use latest version like gcc 6.x)
To set the gcc you can change the bazel cache file (path looks like  *****/external/local_config_cc/CROSSTOOL). It will generated by bazel after 1 build (bazel clean will delete it)

Hi @c0710204, I tried your command to build TF on Xeon Phi, but failded. Like describe in https://github.com/tensorflow/tensorflow/issues/7116, Could you help to figure out what is wrong?

Just to put the links in github form: #7116, #6349

@benoitsteiner , it looks the eigen change was merged. Could you post an update and close this if relevant?

@benoitsteiner ,  How to confirm that it's eigen that caused this problem?

@drpngx @benoitsteiner
Hello, is there any update on this issue? I am waiting your comments.

Reading the thread, it looks like Eigen was updated. @DaejinJung , @craftlk did you try?

Hi just pull the master branch. I use the command "bazel build -c opt --copt "-mavx512pf" //tensorflow/tools/pip_package:build_pip_package". The error is as fellows:
./third_party/eigen3/unsupported/Eigen/CXX11/src/FixedPoint/PacketMathAVX512.h:84:11: error: 'Packet16q16i' does not name a type
typedef Packet16q16i half;
^
./third_party/eigen3/unsupported/Eigen/CXX11/src/FixedPoint/PacketMathAVX512.h:135:11: error: 'Packet16q16i' does not name a type
typedef Packet16q16i half;
The message is same as I got before.

Did you run configure again? It needs to bazel fetch
On Feb 22, 2017 2:28 PM, "jiazhentim"<EMAIL_ADDRESS>wrote:

Hi just pull the master branch. I use the command "bazel build -c opt
--copt "-mavx512pf" //tensorflow/tools/pip_package:build_pip_package".
The error is as fellows:
./third_party/eigen3/unsupported/Eigen/CXX11/src/
FixedPoint/PacketMathAVX512.h:84:11: error: 'Packet16q16i' does not name
a type
typedef Packet16q16i half;
^
./third_party/eigen3/unsupported/Eigen/CXX11/src/
FixedPoint/PacketMathAVX512.h:135:11: error: 'Packet16q16i' does not name
a type
typedef Packet16q16i half;
The message is same as I got before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/4775#issuecomment-281825221,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT_SbcjwO2AA-XvmsvIkaXIMlycremSTks5rfLZugaJpZM4KOtrM
.

Yes, I run configure @drpngx

Looking at @benoitsteiner 's link, we merged Half support from unsupported to Core, in arch/AVX512 and some in arch/CUDA. It looks like what needs to happen is that we update our internal code to include the right headers and use the right definition if necessary, away from unsupported and using the new arch/ headers.

What happens when you go to the unsupported/FixedPoint header and replace the includes with the new ones?
#include "src/Core/arch/AVX512/PacketMath.h"
#include "src/Core/arch/CUDA/TypeCasting.h"

I've added the missing definition for Packet16q16i in https://github.com/tensorflow/tensorflow/pull/7820. That should solve the immediate compilation error. I think there are a few more primitives missing though.

Hi @benoitsteiner , there is still an error:
tensorflow/core/kernels/split_lib_cpu.cc:43:1:   required from here
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/GenericPacketMath.h:467:16: error: 'alignment' is not a member of 'Eigen::internal::unpacket_traitsEigen::internal::Packet64q8u'
if(Alignment >= unpacket_traits::alignment)
^
Target //tensorflow/tools/pip_package:build_pip_package failed to build

Hi @drpngx, I tried and the came across a fatal error:
In file included from ./tensorflow/core/framework/numeric_types.h:25:0,
from ./tensorflow/core/framework/allocator.h:23,
from ./tensorflow/core/framework/op_kernel.h:22,
from tensorflow/contrib/input_pipeline/kernels/input_pipeline_kernels.cc:16:
./third_party/eigen3/unsupported/Eigen/CXX11/FixedPoint:36:45: fatal error: src/Core/arch/AVX512/PacketMath.h: No such file or directory

@jiazhentim we have to wait for #7820 to be merged. If you want to check if that would solve your problem, you could try it locally:
git fetch origin pull/7820/head:pr7820
git checkout pr7820

#7820 was merged, please try now.

I've just checked that bazel build --copt=-march=skylake //tensorflow/tools/pip_package:build_pip_package now works with gcc 6.2 with the latest version of the codebase.

Woohoo!

Thanks, it works now.

And is there a way to compile Tensorflow with ICC on KNL? I can compile it with gcc.

@jiazhentim Try export CC=/yout/path/of/icpc, and then call bazel to build tensorflow.

Could you please let me know the exact command to build TensorFlow on Intel x86 platform (Ubuntu 16.04/18.04) with avx/avx2 and avx512 support?  And which gcc is required?


feat: add apps.gitlab.com

Extracted with the CRD extractor tools

please add a link to the repo that contains the CRDs
thanks :)

Sorry about that, here is the link of the CRD of Gitlab!
https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/blob/master/deploy/chart/crds/gitlab.yaml?ref_type=heads


Avoid null in nearnormalHemisphericalVisibleTransmittances

When I query https://igsdb-v2.herokuapp.com/graphql/ for
{
  allOpticalData(
    where: {and: [{nearnormalHemisphericalVisibleTransmittances: {some: {greaterThanOrEqualTo: 0.9}}}, {nearnormalHemisphericalVisibleReflectances: {some: {lessThanOrEqualTo: 0.01}}}, {resources: {some: {dataFormatId: {equalTo: "9ca9e8f5-94bf-4fdd-81e3-31a58d7ca708"}}}}]}
  ) {
    edges {
      node {
        componentId
        nearnormalHemisphericalSolarReflectances
        nearnormalHemisphericalSolarTransmittances
        nearnormalHemisphericalVisibleReflectances
        nearnormalHemisphericalVisibleTransmittances
        infraredEmittances
        resourceTree {
          root {
            value {
              locator
            }
          }
        }
      }
    }
  }
}

I receive
            "nearnormalHemisphericalSolarTransmittances": [
              0.8163923,
              0.8163923
            ],
            "nearnormalHemisphericalVisibleReflectances": [
              0.004783743,
              0.004784637
            ],
            "nearnormalHemisphericalVisibleTransmittances": [
              0.9774387,
              null
            ],

It would be better to see the nearnormalHemisphericalVisibleTransmittances twice as in nearnormalHemisphericalSolarTransmittances.

@christoph-maurer This issue was due to an issue in our importer. It's since been fixed, if you try again you should not see null values in nearnormalHemisphericalVisibleTransmittances

@danielmcquillen It works well, thank you!


Selectors tab in services details page does not have a title row

On 2.5-head - commit id: 2ba49cb

Go to dashboard --> Services
Create a Nodeport service
Give in the selector values Key=value
Deploy the service
Click on the Nodeport to go into details page
Go to selectors tab
It does not have a title, to indicate it is a key and value pair.

The UI now shows a header for each tab on 2.5-head (05fbcbb) and master-head (d7203b4)


Label for value

Describe the feature
To be able to add a label to the value
When we move the cursor, the label is displayed instead of the current value
Describe the solution you'd like
An array for :data with the value and the label

Show label on tooltip?
e.g. https://jsfiddle.net/NightCatSama/2xy72dod/10324/

I think I had the same issue.
This is how i solved it: https://jsfiddle.net/07j85mkg/

@lenic10 oops. I have never thought about this usage 😄

@lenic10 Thank you. That's exactly what I needed.


Address view, transactions sort order reversed

Should have newest first.

searchrawtransactions "address" (verbose=1 skip=0 count=100 vinextra=0 reverse=false ... )
Need to flip to reverse=true

bug in dcrrpcclient needs to be sorted out:  https://github.com/decred/dcrrpcclient/pull/89

if that fix isnt coming, could also reverse the list in go.

For addresses like Dcur2 we don't actually have the whole list.  The reverse flag basically says to return the N of M newest tx first (N<=M), rather than the oldest.

Ok, my PR https://github.com/decred/dcrrpcclient/pull/89 on dcrrpcclient was just merged so I can update deps and get this fixed.


token times out after x time.

I have a large form to fill in on my website.
After some time, the token times out.
Is this by design or am i missing something?
If by design, what is the best way to refresh the token before timing out?

I added this line of code to refresh the token every 2 minutes:
setInterval(function(){refreshReCaptchaV3('contact_subscribe_id','contact_subscribe');},2601000);
Any insight is appreciated.


Wrong tab order in Fixture Monitor

Describe the bug
Similar to #1637, when using the tab key to navigate through the options in the properties editor of the Fixture Monitor, the tab order is wrong: Vertical -> Horizontal -> Rotation -> Gel color -> Gel color reset.
To Reproduce
Steps to reproduce the behavior:

Start QLC+ and add some fixture(s), for example one Generic Dimmer.
Open the Fixture Monitor and switch to 2D View.
Add the fixture and click on it to open the properties editor.
Use Tab to navigate the options.

Expected behavior
I suggest the following tab order: Horizontal -> Vertical -> Rotation -> Gel color -> Gel color reset.
A patch to fix this in the same way as #1637 is attached: fixture_monitor_fix_tab_order.patch.
Desktop:

OS: Windows 10 / Ubuntu 22.04
QLC+ 4.13.1 (latest official release) / QLC+ 4.13.2 GIT (on December 28, 2024)

Fixed, thanks for reporting


lets get colorful! default to an auto palette combination random

instead of creating standard gray picture just have them be any color just random

add probability to make gradient ones sometime


T1069.001: Add SharpHound LocalAdmin attack

Details:
SharpHound3 is used by BloodHound tool to collect multiple data (https://github.com/BloodHoundAD/SharpHound3/). For this test, only the LocalAdmin collection method is executed.
This is based on the Windows binary that is provided by the author on Github, using a permalink URL.
Testing:
Local testing.
Associated Issues:
N.A.


Compiler flags notes/comments

Forwarding this here from the #wg_best_practices_compilers OpenSSF slack channel, so we don't loose it. I am going to create separate issues or PRs from the poins below in the upcomming week[s].
Hey, Dominik Czarnota from Trail of Bits here and I've been working on similar internal guide in the past; I'd like to contribute to the compiler opts hardening guide in the future, but for now, I will send here my random notes about its contents.

We should recommend explicitly setting the "separate code" linker flag: -Wl,-z,separate-code which, e.g., makes so that the ELF header is not mapped with executable rights (https://bitlackeys.org/papers/secure_code_partitioning_2018.txt). This can be easily seen/compared against a binary compiled with -Wl,-z,no-separate-code and checking out info proc mappings (or Pwndbg's  vmmap) in GDB.

I think the "When not to use?" for "3.14. Enable data execution prevention" regarding JIT apps makes not much sense? Most JIT apps would not care about -z noexecstack because they would not use stack region and would set or change memory permissions using mmap or mprotect anyway and -z noexecstack mostly influences how the memory of the program is mapped initially.

The description for 3.14 could also be more clear that if you compile a program with -z noexecstack but it requires executable code (e.g., when using nested functions, feature from GCC) the program will just crash when it will jump to the trampoline (since the generated code will put the trampoline on the stack and jump to it, and stack will be non-executable).
(I have got an example code for that fwiw)

Fwiw regarding 3.14, in Linux, before version 5.8, if a program is run with executable stack then the kernel will set all other readable pages as executable and not just its stack memory. This is because of some elf_read_implies_exec sheniganis and changes within kernel code. (I can provide more details to it)

The "4. Discouraged Compiler Options" could mention -mmitigate-rop which was there once but then was removed since it didn't provide much benefit

Re: "Enabling -fstack-protector-strong is recommended as it provides the best balance between function coverage and performance". I recommended -fstack-protector-strong + --param ssp-buffer-size=4 in the past (while =8 is the default) but yeah, would be nice to read more on that.

NOTE: https://github.com/ossf/wg-best-practices-os-developers/pull/329 pretty much resolves this

"-D_FORTIFY_SOURCE=3 (requires -O1 or higher, may require prepending -U_FORTIFY_SOURCE)" - iirc the value =1 requires -O1 and =2 or =3 requires -O2, but I'd have to double check that. I'd also recommend checking if =3 works if your compiler does not support this value, since it is a fairly new addition.

Regarding GOT, note that "bind now" options are only relevant for the given binary we compile: the libc, libstdc++ and other libs will still have writable function pointers in GOT/GOTPLT if they are not compiled with those options.
FWIW there is also a LD_BIND_NOW env var supported by ld.so, but from my tests now it seems it doesn't improve this for libc/libstdc++ at all.

In 3.16.2 the "The x86_64 architecture supports mov instructions that address memory using offsets relative to the instruction pointer" could be rephrased. This feature/thing is called "RIP-relative addressing" and its not just about mov instructions as e.g. lea (and likely some others) will also leverage that.

There are some compiler flags that were there at some point/version in time but were removed, for example:

clang had an experimental -Wlifetime which was changed to two other flags (-Wdangling-gsl -Wreturn-stack-address) (https://stackoverflow.com/questions/52662135/the-purpose-of-the-wlifetime-flag). Clang docs says the two diagnostic is enabled by default but idk if its enabled with -Wall -Wextra or, e.g., only within the scan-build tool.

There's also -ftrapv that can be used to trap overflows, but I haven't played with it much and some people says its better to use sanitizers for that (https://news.ycombinator.com/item?id=24578534)

We should probably also mention GCC's -fanalyzer flag

Thanks so much! We really appreciate the feedback!

should be addressed by #353

Has this been addressed by the C/C++ Compiler Hardening options guide?    @gkunz @thomasnyman @david-a-wheeler

I believe not. I may have some time next week to send some PRs about some
of these.
On Wed, 8 May 2024 at 20:37, CRob @.***> wrote:

Has this been addressed by the C/C++ Compiler Hardening options guide?
@gkunz https://github.com/gkunz @thomasnyman
https://github.com/thomasnyman @david-a-wheeler
https://github.com/david-a-wheeler
—
Reply to this email directly, view it on GitHub
https://github.com/ossf/wg-best-practices-os-developers/issues/330#issuecomment-2101198682,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMLWCT2WVFSPECSAN5ZUKLZBJWGHAVCNFSM6AAAAABADE6BACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGE4TQNRYGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Trying to slowly work through these. I'm trying to split of suggestions for concrete additions to separate issues to allow them to be commented on and tracked separately, currently #588 and #589.

should be address by #590

should be addressed by #611

For 7. I believe @siddhesh confirmed when the -D_FORTIFY_SOURCE recommendation was written that -O1 is the requirement, but -O2 or higher is recommended as it improves the accuracy of __builtin_object_size and __builtin_dynamic_object_size the -D_FORTIFY_SOURCE={2,3} instrumentation relies on. I've proposed some clarifying text to the corresponding "additional considerations" section in #620

should be addressed by #640

Split 10. and 11 off to #684 and #685 respectively. 12 is a duplicate of #145.
I'm proposing closing this issue as the feedback here has not either been addressed or can be tracked via the more narrowly scoped issues.

I personally like the fact of receiving notifications about the progress here but since we are moving to other cards, I am okay with closing this one. I'll schedule some time in upcomming weeks to revisit/review all the work that has been done here and see if I can fit in some gaps etc. :)

I'm closing this then in favor of the more narrowly scoped tickets to track the work on the specific options to consider.


Specification for determining which Olm Session to use if multiple are present

Currently the existing implementation (matrix-js-sdk) will use the session with the lowestID if multiple are present  (https://github.com/matrix-org/matrix-js-sdk/blob/master/src/crypto/OlmDevice.js#L377):
// Use the session with the lowest ID.
sessionIds.sort();
return sessionIds[0];

Since sessionIds are the same on both ends this seems like it is consistent as long as both clients have both sessions, but in the case of an orphaned session this may lead to errors? At the least this should be specified in the spec so that all clients may implement the same session selection method.
For reference Open Whisper Systems uses the session with the last message received:
https://whispersystems.org/docs/specifications/sesame/#overview

Yes, this needs fixing, as per https://github.com/vector-im/riot-web/issues/2330. The sesame approach seems sensible.

It looks like what we need to spec is that if a client has multiple sessions:

devices should use the session in which they last received a message when sending messages
devices should expire old sessions (it looks like sesame maintains a list of inactive sessions, ordered by when they were last active, and drops sessions off the end of the list)

Is there anything else that needs spec-ing for this?


Handbook product metrics

Description
This PR introduces a new handbook page focused on 'Product Metrics'. This page aims to provide an understanding of the key metrics we track to inform our data-driven decision-making process.

@MarianRaphael One minor note, afterwards it can be merged


[AOT] Add CreateFunctionMetadata analysis pass

Tracking issue: https://github.com/apache/tvm/issues/12548
AOT requires FunctionInfo to be defined for all the functions in the module. This stores information on how much memory the functions use. This commit adds a separate analysis pass to create all the FunctionInfos + some tests for the new pass.

cc also @ekalda
(apologies for late follow-up, have been away for a while)

@lhutton1 Andrew's on holiday for a couple of weeks, so would it be OK to merge without his approval? Think I addressed his comments :)

Thanks @mbaret @areusch!


MiniGo style pass and and minor logic enhancements.

Logic changes:

In LibertyTracker.swift, use dictionary indices to avoid force unwrapping. Removed a lot of bangs!
Make ModelConfiguration.boardSize public since the initializer takes a boardSize for better transparency. It's a little weird for an initializer to take a constant, store it and make it private.
Reduce nesting in LibertyTracker.updateLibertiesAfterRemovingCapturedStones(_:) with compactMap(_:).
Simplify assignNewGroupID() with a defer block.

Formatting changes:

Make every file end with exactly 1 empty line.
Add some minor comments.
Remove empty lines between the start of a type declaration or extension and the first declaration for consistency.
Make GoModel code fit within 100 columns.

Thanks, merging now. @xiejw, let me know if you have any comments!

Thanks @xiejw for reviewing!


Iidx hv and bistro

Missing traffic tests. I can't think of any obvious issues with the pull request in its current state though so I'm submitting as is for now. I'll do traffic tests in a bit (Already recorded packet logs for them I just need to sit down and do the rest). If you have any design objections feel free to bring them up though! :) As an aside, it might be advisable to update the bemapi spec to account for the new iidx charts...

No online arena, but local arena should work by default. I personally don't find enough of a use for online lobby to bother implementing it for any game... With games like iidx, I have to wonder if it might be more advisable to make a separate project just for scraping the musicdbs with charts, and then just having some json blobs stored in this repository with which to seed the database. Because of how much manual mangling has to be done, I just have to wonder if using the chart parser to create a unique id for each chart and using that to determine the server id would be better than what we currently do.

Having a repo that is good at one thing: scraping metadata from ANY game ANYWHERE would actually be a pretty useful thing to have. If its structured right, bemaniutils can just depend on it and have a simple wrapper or something. I have, however, shied away from any scraped or copyright data in this repo, hence why you need to seed your installation from another active one or from your own sourced game files. Wouldn't be against somebody taking the read code, putting it in its own repo, cleaning it up and also checking in per-game blobs. I just won't be the one to do that ;)

I've been running this branch for a little while. It seems okay for now, but I've spotted few issues within the code. Suggestions above are what I've found.
Also, bemani/frontend/static/iidx-options.js file needs to be updated with options for 27 and 28.

replaced by #58


Question: Only allow users to see their entries

Is there built in functionality in Serenity to allow for users to be restricted to only viewing their own entries? I've found your blog post Don't Repeat Your Permissions, which talks about restricting access by groups.
The example I would give is an application like your Movie sample but instead of being one collection, each user having their own, though without going to the extent of doing multi-tenancy.

You can do this with a simple behavior, e.g. add a IOwnedBy interface to rows, handle ApplyFilters in behavior, and add a Where to handler.Query

You can do this with a simple behavior, e.g. add a IOwnedBy interface to rows, handle ApplyFilters in behavior, and add a Where to handler.Query

Thanks for the response, I am admittedly unsure about what you meant by "handle ApplyFilters in behaviour, and add a Where to handler.Query". I ended up taking the following approach:
In Endpoint.cs I replaced the Create method with:
        [HttpPost, AuthorizeCreate(typeof(MyRow))]
        public SaveResponse Create(IUnitOfWork uow, SaveRequest<MyRow> request)
        {
            int userId;

            if (Int32.TryParse(Authorization.UserId, out userId))
            {
                request.Entity.UserId = userId;
                return new MyRepository().Create(uow, request);
            }
            else
            {
                return new SaveResponse()
                {
                    Error = new ServiceError() { Message = "You do not appear to be logged in" }
                };
            }
        }

and List method with:

        public ListResponse<MyRow> List(IDbConnection connection, ListRequest request)
        {
            int userId;

            if (Int32.TryParse(Authorization.UserId, out userId))
            {
                request.EqualityFilter.Add("UserId", userId);
                return new MyRepository().List(connection, request);
            }
            else
            {
                return new ListResponse<Entities.UserBookiesRow>();
            }
        }

If your method is preferable to my approach then I would be grateful if you could provide a little more detail.

Thanks for the response, I am admittedly unsure about what you meant by "handle ApplyFilters in behaviour, and add a Where to handler.Query". I ended up taking the following approach:
In Endpoint.cs I replaced the Create method with:
        [HttpPost, AuthorizeCreate(typeof(MyRow))]
        public SaveResponse Create(IUnitOfWork uow, SaveRequest<MyRow> request)
        {
            int userId;

            if (Int32.TryParse(Authorization.UserId, out userId))
            {
                request.Entity.UserId = userId;
                return new MyRepository().Create(uow, request);
            }
            else
            {
                return new SaveResponse()
                {
                    Error = new ServiceError() { Message = "You do not appear to be logged in" }
                };
            }
        }

and List method with:

        public ListResponse<MyRow> List(IDbConnection connection, ListRequest request)
        {
            int userId;

            if (Int32.TryParse(Authorization.UserId, out userId))
            {
                request.EqualityFilter.Add("UserId", userId);
                return new MyRepository().List(connection, request);
            }
            else
            {
                return new ListResponse<Entities.UserBookiesRow>();
            }
        }

If your method is preferable to my approach then I would be grateful if you could provide a little more detail.

Where you should set these are inside MyListHandler, overriding ApplyFilters.
See tutorials for some info on behaviors.

Where you should set these are inside MyListHandler, overriding ApplyFilters.
See tutorials for some info on behaviors.


[WIP] allow setting runtime handles

Sometimes we need to set runtime data (which cannot be written in a config file) into ORT's session options. This change introduces this RuntimeSettings type, together with internal implementation and C-API, C++-API.

Lgtm.

close this. replaced by #1002


Fix frequent Zebra hangs during syncing

Motivation
Zebra is currently hanging during about 5% - 90% of syncs, depending on the machine and network. But Zebra doesn't seem to hang after the initial sync.
This Epic contains bugs that might be causing these hangs.
But it's also possible that:

bugs we're currently working on will fix the hangs, or
other undiscovered bugs are causing the hangs.

So we don't want to add these bugs to #3096 yet.
Tasks
First, fix the bugs we are currently working on, and see if Zebra stops hanging all the time:

[x] #3168
[ ] #3234
[x] #3254
[x] #3379

If Zebra keeps on hanging frequently, implement these diagnostics:

[ ] #2112

Then use the diagnostics to:

prioritise the bugs in this epic, or
open new bugs for any issues reported by tokio-console.

Likely Causes
This code has caused hangs before:

[ ] #3288
[ ] #3263
[ ] #862
[ ] #2188
[ ] #2201
[ ] #2202
[ ] #3042
[ ] #1351

Do we need to review this issue and its associated potential fixes given that it seems we've fixed some hangs for now...

I think we can close this after https://github.com/ZcashFoundation/zebra/issues/3234 is completed

I'm not seeing any hangs after testing the latest main on 4 different mainnet and testnet instances, so I'm happy to just close this now.


added name original for stickers

After merge please update API files

 example

@vladdnepr Thanks for the contribution. Do you mind giving me some examples where this could be used?

name is unique mnemonic ID of sticker.
I think your name must be title, but I don't want to break backwards compatibility
So I put CSGO name to name_original
I can't give you example from my project. NDA

@vladdnepr Understood. Do you think it's a good idea to implement this in the rest of files?

@vladdnepr The new data is deployed.

@vladdnepr Understood. Do you think it's a good idea to implement this in the rest of files?

Maybe. I think all possible input data must be in output result. You never know what can be useful for others

@vladdnepr The new data is deployed.

Nope
Here not https://bymykel.github.io/CSGO-API/api/en/stickers.json
But in code yes https://raw.githubusercontent.com/ByMykel/CSGO-API/main/public/api/en/stickers.json

@vladdnepr I forgot to deploy to  gh pages, it should be deployed in 5-10 minutes

@vladdnepr I forgot to deploy to gh pages, it should be deployed in 5-10 minutes

Thank you


type overrides: use actual package name instead of import name

If I have this:
    "overrides": [
      {
          "go_type": "github.com/kevinburke/go-types.PrefixUUID",
          "postgres_type": "uuid"
      }
    ]

The generated Go source code is, e.g.
Get(ctx context.Context, id go-types.PrefixUUID) (Thing, error)

Which is a syntax error. In theory it would be good to determine the package import name "package types" and then use that instead.

Fixed partially by #262, closing for now


Deprecate this repository

Since this is now moved into golang.org/x/crypto/pkcs12, let's force everyone to use that version...

@ahmetalpbalkan is this the right way?

Maybe we should just delete the repo.

Having
func init() {
        log.Println("Azure/go-pkcs12: This package has moved to golang.org/x/crypto/pkcs12")
}

or equivalent is a bit nicer.

That sounds worse than a compile-time error to me. If the depending program was doing something sensitive with the output then it can potentially break users.

It's nice keeping a README around for a while. The amz package forces a compile time error with:
package error

func error() {
	`ERROR: the correct import path is gopkg.in/amz.v1 ... `
}

Though no code at all would be a compile time error as well.

the // import comment generates a error on go get using Go 1.4 and up

I think a compilation error @nathany suggested is better.

@ahmetalpbalkan @nathany better?

LGTM


Update manage-quarantined-messages-and-files.md

@chrisda  we added this button recently. so I'm updating the documentation as well

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@faoquong Please update with the feedback. Thanks.

@chrisda i have made a mistake.
it should say this instead " -Block Sender: This blocks the sender from sending emails to the Admin recipient mailbox."

@faoquong - I have updated my suggestion in accordance with your comment. If you agree, please commit my suggestion. Thanks.


Change Travis to use old infrastructure

To make this Travis configuration work it needs sudo set to false.
More info available here: http://docs.travis-ci.com/user/migrating-from-legacy/

Now I see. It looks like Travis build does not work for speakerfighter. My bad, sorry.

In fact, it worked. The problem with the build is that the fab deploy command needs a key to access the ssh through travis-ci to digital ocean, and thats key is only in my account, i don't know how to fix it yet, but i will find some day haha

Ah, ok! Is it worth a issue?


Typescript compiler fails when using react css themr with error Default export of the module has or is using private name 'TReactCSSThemrTheme'

Typescript Version : 2.4.2
React CSS Themr: 2.1.2
Replication Steps

Create a component that uses themr.
themr('Identifier')(ComponentName);
Run the Typescript compiler

It will throw the following error
 error TS4082: Default export of the module has or is using private name 'TReactCSSThemrTheme'.
error TS4082: Default export of the module has or is using private name 'ThemedComponentClass'.

Quick fix: just import it ;)

Yes @belohlavek we used that, but that is not a good solution because TS Lint will fail as we are not using them and those will be unsed imports. Also, importing is private member of a library is never good as it may change in future updates.

I've opened a request to fix issues like these in TypeScript by bringing declaration files to parity with language features. https://github.com/microsoft/TypeScript/issues/35822


support chatgpt 4

can you make this plugin support chatgpt 4 ?

Bruh I wouldn't hold my breath for this I tried to fork the repository to see if I could work on it. There is no instructions on how to even build strapi plugins so I can test it.

I've been working on this weekend because I couldn't get this working for my client. I have gotten this working for myself and am working on getting this working for dall-e. So you can create pictures using dall-e but as is you can actually use GPT-4 and GPT-3.5.


WIP: Fixup for bbd8f88c789943293680644ae8a49b5342a55575 #2334

Previously the deployment failed:
failed to overwrite default of old field type with None (string):
failed to set default value of enum type to None (string):
value: None (string) is not part of allowed enum values:
[Done Duplicate Incomplete Description Can not Reproduce Deferred Won't Fix Out of Date Verified]
file: spacetemplate/importer/repository.go
line: 91

We've updated the resolution enum to
have a new value and that is also the new default. That new value didn't
exist in the old enum type but we tried to make it the new default for
the old type anyways. That didn't work because the FieldType.SetDefault()
implementation for enums checks if the given value is part of the
allowed enum values.
The overall intention is to check if too enums are the same but ignore
the default value. That is why we temporarily make both defaults the
same before we call FieldType.Equal().
With this change we simply reverse the assignment of the new default to
the old type. Instead we temporarily assign the old default to the new
type. The result is that a call to FieldType.Equal() will return true.

Ike Plugins (test-keeper)
Thank you @kwk for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

Codecov Report

Merging #2336 into master will not change coverage.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master    #2336   +/-   ##
=======================================
  Coverage   70.17%   70.17%
=======================================
  Files         171      171
  Lines       16625    16625
=======================================
  Hits        11666    11666
  Misses       3829     3829
  Partials     1130     1130

Impacted Files
Coverage Δ

spacetemplate/importer/repository.go
73.33% <80%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd8f88...b663508. Read the comment docs.


Expose leftIcon and rightElement properties on applicable HoistFields (#463)

#463
Delegating leftIcon and rightElement where applicable. Also fixed up the css for displaying our icons inside of Blueprint input groups to match as closely as possible the Blueprint styling.
See this commit for example usage (accidentally pushed to the master branch, but doesn't cause issues as the new props are just ignored)

As noted via Slack, please see https://github.com/exhi/hoist-react/issues/475 as it relates to this ticket re.

do we want to continue the delegateProps idea
what is the standard for propTypes docs

HoistField is just a really thorny issue -- feel like we need to sit together (maybe tomorow?) and come up with a plan for it.  Need to consider relationship between Mobile and Desktop.
One thing that makes the documentation of it tricky is that we are -- for better or for worse -- using inheritance here, and it doesn't seem like  React provides a good way to document inherited props.
Want to also throw out the idea that we could use a collection of the form blueprintProps, to gather blueprint specific props.  This pattern has been useful with agGrid and others.  Perhaps helpful to clarify things?
Again -- happy to lose delegate props...

I am going to go ahead and merge this now to take support for the additional props.  I can see now that it's useful and allows us to replace some direct usages of inputGroup within the framework.
This change also includes a fix for #490 which I would like to fold in.
Would absolutely still like to revisit and focus on #475 !!


[FLIP-934 Interaction Templates] Util - InteractionTemplateAudit ID generation

[FLIP-934 Interaction Templates] Util - InteractionTemplateAudit ID generation
FLIP-934 proposes FCL be modified to perform actions on InteractionTemplateAudit.
There should be a utility that exists to easily compute an InteractionTemplateAudit ID, using the serialization and hashing process as outlined in FLIP-934.
Expected Outcome

[ ] Utility to compute InteractionTemplateAudit ID exists.

Closing due to change in FLIP-934


Remove DDK mention

@tedhudek , I'm testing the "Making simple doc edits on GitHub or DevOps" process.

Learn Build status updates of commit d1c44a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/display/display-samples.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


The program makes my PC unable to shut down

Microsoft PowerToys version
v0.59.1 and elder
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Update day. Automatic update. I try to shut down my PC. Error, unable to shut down, instead my system (Win 10) turns to log-in screen. I try to shut down again - ongoing work, like the PC has just been locked. I click shut down again. And back to log-in screen again.
I have to shut down my PC 'manually'.
After the next PC start this bug does not happen 'till the next update. The bug exist at least since v. 0.49.X.
I'm 100% sure it's PowerToys issue.
✔ Expected Behavior
PC shuts down every time I order.
❌ Actual Behavior
PC does not shut down after update.
Other Software
Win 10.

Hi @Neoros

When you say update are you referring to Windows or PowerToys update?
How can you be 100% sure this is related PowerToys?
Do you have an error message or anything that can help?

Not sure if a bugreport can be useful here, but let's try!
/bugreport


How to disable info squiggle underlines

In VS Code, info messages are marked like errors, albeit with a different color. Is there a way to turn them off?
It's hard to tell the color in some color themes, plus it's visual noise.

Have you tried configuring VSCode to remove the squiggles? https://stackoverflow.com/a/48610661/93197

Closing the issue as the severity of these messages will be reduced with the next Dafny release: https://github.com/dafny-lang/dafny/pull/1432


Fix i18n

Fix issue #30 and i18n behavior tests.

That looks very clean and semantically correct now :)


Fixed negative PE hash by reading unsigned integers.

Publishing a large number of various symbols resulted in many instances of negative hashes. Since the PE hash is never signed it should be enough to read all values as unsigned to have the hex printing already as unsigned.

Thanks for the PR Filip!
I'll take a look at, hopefully during this weekend.

Looks good, thanks for the fix!
Is it possible for you to share one of the PE files that triggered this bug? It would be nice to add a test for this fix.

Thanks for merging the change!
Apologies for the late answer. It appears that most negative hashes are actually from private files I cannot share, but I was still able to find some in public files in the end. I've uploaded them to https://halt.cz/InvalidHashes.zip

Great, thanks a lot for the files!
I'll add some tests, and then I'll make a new release of this package.


Should be possible to deploy without postgres or mysql

Summary
Currently it seems like jets expects either pg or mysql2 to be installed and properly configured. I've tried removing them both from the Gemfile but then jets seems to be unable to run basic commands.
Motivation
If I'm using DynamoDB I shouldn't need to have postgres/mysqle gems installed and configured.
Guide-level explanation
jets new demo-without-database --database=false

Reference-level explanation
??
Drawbacks
??
Unresolved Questions
Is there currently a way to do this that I'm missing?

can not repo with 3.0.7:
jets new demo-without-database --no-database
jets deploy
...
=> API Gateway Endpoint: https://filtered.execute-api.us-east-1.amazonaws.com/dev/

Be sure to use --no-database not --database=false