[analyzer] An explicitly instantiated instance method tearoff is parsed as starting with a prefix

Consider the following program:
class A {
  List<X> m<X>(X x) => [x];
}

extension FunctionApplier on Function {
  void applyAndPrint(List<Object?> positionalArguments) =>
      print(Function.apply(this, positionalArguments, const {}));
}

void main() {
  var a = A();
  a.m<int>.applyAndPrint([2]);
  a.m<String>.applyAndPrint(['three']);
}

This program is rejected (as of ef8add038fcc6d4df171d04e8946be2ae56f1631) by dartanalyzer with the following error messages:
ERROR|COMPILE_TIME_ERROR|PREFIX_SHADOWED_BY_LOCAL_DECLARATION|/usr/local/google/home/eernst/lang/dart/scratch/202107/n038.dart|12|3|1|The prefix 'a' can't be used here because it is shadowed by a local declaration.
ERROR|COMPILE_TIME_ERROR|PREFIX_SHADOWED_BY_LOCAL_DECLARATION|/usr/local/google/home/eernst/lang/dart/scratch/202107/n038.dart|13|3|1|The prefix 'a' can't be used here because it is shadowed by a local declaration.

However, a is not an import prefix, it is a local variable. Presumably, the analyzer parser (or some other early step of the analysis) assumes that with constructs of the form <identifier> '.' <identifier> <typeArguments> '.', the first identifier must be an import prefix. That may have been true before constructor-tearoffs, but it isn't true with that feature, so the analyzer will need to investigate the situation more closely before it concludes that it is looking at an import prefix.

cc @srawlins

Must handle new rewriting spelled out in @stereotype441 's Constructor Tearoff parsing strategy doc.
Analyzer's resolver gets the following from the parser:

ExpressionStatementImpl: (a.m<int>.applyAndPrint([2]);)

._expression: InstanceCreationExpressionImpl (a.m<int>.applyAndPrint([2]))

._constructorName: ConstructorNameImpl (a.m<int>.applyAndPrint)

._type: TypeNameImpl (a.m<int>)

._name: PrefixedIdentifierImpl (a.m)

._prefix: SimpleIdentifierImpl (a)
._identifier: SimpleIdentifierImpl (m)

._typeArguments: TypeArgumentListImpl (<int>)

._name: SimpleIdentifierImpl (applyAndPrint)

This must be re-written into something like:

ExpressionStatementImpl: (a.m<int>.applyAndPrint([2]);)

._expression: MethodInvocationImpl (a.m<int>.applyAndPrint([2]))

._target: FunctionReferenceImpl (a.m<int>)

._function: PrefixedIdentifierImpl (a.m)

._prefix: SimpleIdentifierImpl (a)
._identifier: SimpleIdentifierImpl (m)

._typeArguments: TypeArgumentListImpl (<int>)

._methodName: SimpleIdentifierImpl (applyAndPrint)


<EMAIL_ADDRESS>hash check failed

App:         dorado/justcolorpicker
URL:         https://annystudio.com/jcpicker.exe
First bytes: 3C 21 44 4F 43 54 59 50
Expected:    234b7ecf5c606b5a65ab6f5327e8ee53f399ff7401dc4d08dd00df9f0462d104
Actual:      3eb5bf204857cd199ba5c945efd6cf608ab6c9baa2ab8aea52391457cbdd9479

Duplicate https://github.com/h404bi/dorado/issues/106


Removing an exercise in the editor doesn't remove it in Atheneum

After removing an exercise in the editor, Atheneum looks like this:

You can see 3 exercises with the number 6: The current one and 2 previously deleted.
Example: http://mumuki.io/guides/215-tp-fun-2-sabados-manana-series-de-t2

Hi, this is a duplicate of #44


To string changes

This is my first pull request, I hope I did everything correctly.
I ran into your library when I was trying to implement something similar myself and I would like to contribute. To get familiar with the library and using GitHub correctly I started with small changes:
There are some implementation notes for implementing the IFormattable interface, see: https://docs.microsoft.com/en-us/dotnet/api/system.iformattable.tostring?view=netframework-4.7.2#notes-to-implementers, see also https://stackoverflow.com/questions/14221424/reference-implementation-for-iformattable for a summary.
In this pull request I added those implementation notes to the library and included the corresponding tests.
Also I noted different behavior for ToString when it was called with one and two arguments. As a consumer of the library would (I think) expect that ToString((string)null) would ultimately call ToString(null, null) instead of throwing an exception. Technically this is not part of the IFormattable interface, since the one-argument ToString is not part of IFormattable but to me it seems closely related.
To be in line with the behavior of the .Net framework I checked the behavior of the ToString implementation of decimal, which also has a one-argument overload. The decimal ToString does not throw an exception for a null argument. It also returns the default ToString result when using the string.Empty format
Having said that, reading the websites above I cannot find text that says that the expected behavior for string.Empty should be specified. So I did not implement that yet.
I am eager to hear whether this is helpful or not.

Sorry for the late response (private things where keeping me away ;-)).
Thanks for the pull request. Good observation about the ToString() throwing an execption!


Document how we've used domain driven design

Quite a bit of yapping but it should give beginners an idea of why we do it, how it's useful, and how we implement it

I think it was a nice introduction, some yapping is nice when you go from not knowing what it is :)

Looking good! I would like a lot more examples, but this is something we can iterate on going forward

It would be nice to include some examples of the patterns we follow in repositories and services. For example, when a delete method in a repository returns null, it means that there was no such resource to delete. This sort of stuff is important to document I think

I agree we should add stuff about "return null" and other paradigms we've used, but I think they are probably better fit in another document


⚠ Bofrost.fr has degraded performance

In 28efaeb, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1588 ms

Resolved: Bofrost.fr performance has improved in d1fe359 after 2 hours, 23 minutes.


Document escape support bug in README's known issues.

Could use an example. Something like: "For example, newlines in a string should be //n rather than /n to be recognized correctly."


chore(updates.jenkins.io): proper output name

Follow-up of #13

You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.

Self-merging to continue on the subject.


upgrade mocha

This is for '--inspect'

This is for '--inspect'

What is that?
Maybe we could update other packages as well?

@markelog --inspect lets you use the Chromium inspector for debugging

Maybe we could update other packages as well? While we at it?

Yeah but I only needed this one, didn't want to upgrade jscs etc

Yeah, jscs would be better to left alone, since we probably deal with that in https://github.com/cst/cst/pull/140
Might be tedious process to update all deps, but with https://github.com/th0r/npm-upgrade it should be fast and simple. Wanna do it?

@markelog that's the only other one that's outdated (using npm outdated)

O really? Cool then

@markelog because you're using "^6.x" version specs


Change kyrgyz to chinese

Since the revamp of the project, I changed all kyrgyz code and text to chinese.

Pleaseeeee review this


[BUG] Findings are not generated during first run of the detector

What is the bug?
After creating a detector, if data is ingested before the first execution of the detector, it does not generate any findings.
How can one reproduce the bug?
Steps to reproduce the behavior:

Create a detector with execution frequency of 1 min
Ingest log data within a minute
Ingest log data after a minute

What is the expected behavior?
There should be two set(s) of findings, one generated by the first run and one by the second run of the detector, but there is only one set of findings.
What is your host/environment?

OS: MacOS
Plugins: Security Analytics 2.10

Do you have any screenshots?
N/A
Do you have any additional context?
N/A

the issue is not Findings are not generated during first run of the detector.
the issue is it takes a little more time for JobSweeper to sweep workflow job & schedule it.
So, the delay remains same even if detector is scheduled every 1 min, 5 min, or 1 hour.


Here not returning status code when unsuccesfull call

Hi @JustinCanton , I was making some tests for the HERE connector.
I have got the error:  "The call to Here did not return a successful http status code. See the exception data for more information." but no Inner Exception is shown. This leads to that you don't know if your API key is invalid, if you exceeded the limits, if you sent a wrong parameter etc. etc. and it is impossible to debug what's going on.
Here the exampe: https://ibb.co/Y7BwsFf
Many thanks

Hi @ollie10,
I apologize. I have been off for a little while now. I will try to tackle this issue next week.
Its interesting that this is happening. I honestly believed I had all of the cases covered and they would have an inner exception. Can you send me your request data you are using?
Thank you

Hi @ollie10, I checked the code again, and I realized that for that specific error, there is no internal exception. It is in the Data object of the exception. Inside that, there should be the full uri, the status code, and the response body

This makes sense given the exception message you got: "The call to Here did not return a successful http status code. See the exception data for more information."
Can you please try to reproduce and check to see if that data is there, and if you can resolve your problem using that information.
Justin

Hi @JustinCanton you are right, that's what I see:

URL: {https://geocode.search.hereapi.com/v1/geocode?q=325 Irwin Street, Anchorage&limit=1&lang=&apiKey=_MY_HIDDEN_APY_KEY} I'm hiding the key by purpose, the key is passed correctly
Status: Bad Request
Error: "{\"status\":400,\"title\":\"Illegal input for parameter 'lang'\",\"cause\":\"Actual parameter value: ''\",\"action\":\"Value must be comma separated with non-empty parts\",\"correlationId\":\"d7e242ad-4fdc-47ea-90a8-0615096b800b\",\"requestId\":\"REQ-7c64180f-e736-42eb-a2f7-ef4ddeeac07b\"}"

It seems the call is not passing the language.
My call is made like this
GeocodeParameters parameters = new GeocodeParameters() { Query = address, Limit = 1, Language = culture };
GeocodingResponse response = await _hereGeocoding.GeocodingAsync(parameters);
return ParseResponse(response, GENERIC_ADDRESS_TYPES);

Hi @ollie10 ,
We do have a test case covering this. (https://github.com/JustinCanton/Geo.NET/blob/develop/test/Geo.Here.Tests/Services/HereGeocodingShould.cs#L206C18-L206C18)  It does seem to be working correctly.
It uses the name value of the culture:
if (parameters.Language != null)
{
    query = query.Add("lang", parameters.Language.Name);
}
else
{
    _logger.HereDebug(_resourceStringProvider.GetString("Invalid Language"));
}

What is the value of culture you are passing?
Justin

Normally it could be one between es-UY, es-AR, en-US or similar. Always Spanish or English with a country between latin america or united states

Interesting. Well can you try doing culture.Name for me and see what the value is when the request fails? Maybe using the Name property isn't the right thing to do.

I think I understood the problem, it arises when you use CultureInfo.InvariantCulture as Culture, no problem with es-ES or en-US apparently, that's becuase culture.Name of CultureInfo.InvariantCulture is empty.
But the root problem is another: both methods GeocodeAddress and ReverseGeocodeCoordinates requires a culture which is not a mandatory parameter according to their documentation

@ollie10, the Language parameter isn't required in the parameters object. It can be left as null, and it will not be sent to Here:
var parameters = new GeocodeParameters() { Query = "123 main street", Limit = 1 };
var results = await _hereGeocoding.GeocodingAsync(parameters).ConfigureAwait(false);

That said, the InvariantCulture and other empty cultures are an issue. I will fix that issue.
Justin


Issue while verifying the camera settings: invalid Content-Base

In the latest version of the agent when verifying the connection, the error "Something went wrong while verifying the camera settings: invalid Content-Base" occurs.
This works OK with the November docker release and is running on Raspberry Pi and a S3VC IP camera using H264

Thanks for reporting @CaptainCommuter, we are using a new RTSP library. Which camera are you using?

can you share the RTSP url you are using? Are there other RTSP urls you can test out?

Thanks for responding. The camera is a generic one from SV3C (www.sv3c.com) A series and the RTSP urls are:
rtsp://ipcam01/stream0 for the main stream and
rtsp://ipcam01/stream1 for the sub-stream.
None work and unfortunately that's all there is.

The error thrown happens here: https://github.com/bluenviron/gortsplib/blob/main/client.go#L73-L88
I expect the RTSP url is not able to be parsed with our new library. Can you share the full log?
if len(cb) != 1 {
    return nil, fmt.Errorf("invalid Content-Base: '%v'", cb)
}

ret, err := base.ParseURL(cb[0])
if err != nil {
    return nil, fmt.Errorf("invalid Content-Base: '%v'", cb)
}

I'm wondering if you use any special characters in the password? The RTSP url should work with following format (regex).
https://github.com/bluenviron/gortsplib/blob/main/pkg/base/url.go#L18-L45

Ok that's great news, but it should work without password as well (not advised though).


Issues with Sending Transactions to Goerli via WalletConnect connections

Describe the bug
To test my contract I'm forced to use goerli, so I faced some issues
I have a form which sends eth to contract to buy tokens
	const {
		data: hash,
		sendTransaction,
		isPending,
	} = useSendTransaction({
		mutation: {
			onError(error) {
				console.log(`Error send`, error)
			},
			onSuccess(data) {
				console.log("Success send", data)
			},
		},
	})

	const { isLoading: isConfirming, isSuccess: isConfirmed } = useWaitForTransactionReceipt({
		hash,
	})

	const onSubmitForm = useCallback(
		(e) => {
			e.preventDefault()
			sendTransaction?.({ to: contract, value: debouncedAmount ? parseEther(debouncedAmount) : undefined, chainId: 5 })
		},
		[debouncedAmount, sendTransaction]

logic is super simple and works fine when I use browser wallet (in my case Metamask for Chrome). Transactions successfully confirms
When I tried to connect my Zerion wallet with WalletConnect I get this error when sumbitting form:

https://github.com/meri-maki/goerli
Link to Minimal Reproducible Example
https://goerli-two.vercel.app/
Steps To Reproduce

open https://goerli-two.vercel.app/ on desktop or mobile
connect Zerion (for example) via WC Qr (desktop) or via Zerion wallet in modal (mobile)
enter any value in input
try sending transaction

Wagmi Version
2.5.7
Viem Version
2.7.16
TypeScript Version
No response
Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?
PS: I've also noticed that auto connect feature always works, is there a way to disable it? and let user connect from scratch on every page reload?

The "unknown RPC" error usually arises from the Wallet. Best to get in touch with WalletConnect or Zerion to resolve this issue.


Dev

Q
A

Bug fix?
[ ]

New feature?
[* ]

New sample?
[* ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
MS Teams related componens (using fluenui/northstar)

Thank you @mgwojciech for the great addition to the library!


[WIP] Refactor Cassandra domain persistence manager for later NoSQL support

WIP, still waiting for https://github.com/uber/cadence/pull/3554 to merge.

What changed?

Why?
For later NoSQL support in #3514

How did you test it?

Potential risks

close in favor of https://github.com/uber/cadence/pull/3620


Deprecated on PHP 7.1 still working as of now (not  a bug but how to fixed this warning popping sometimes on command line and page?)

PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Whois has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.main.php on line 31
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; Whois has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.main.php on line 31
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; WhoisClient has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.client.php on line 30
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; WhoisClient has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.client.php on line 30
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; idna_convert has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.idna.php on line 54
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; idna_convert has a deprecated constructor in /home/vagrant/code/pixinpics/vendor/phpwhois/phpwhois/src/whois.idna.php on line 54

im using 3.0^ version thanks sir

Well... this lib has no paths provided in your debug info.
Looks like warnings belongs to other project - https://github.com/phpWhois/phpWhois
:)

sorry and thank you I already  fixed it. btw sir may i confirm if your
service you used is related from https://www.whois.com/ ?
i scan your config files seems there are so many urls that is whois may be
its your lookup server.
im trying to  look up whois url
creativeflooring.nz
and returning null.
did I misconfigured something? some URL's are working some are not.
thank you sir and more powers
On Thu, Jun 28, 2018 at 9:20 PM, Sergey Sedyshev<EMAIL_ADDRESS>wrote:

Closed #23 https://github.com/io-developer/php-whois/issues/23.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/io-developer/php-whois/issues/23#event-1706318466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANfrPF9JqzQ_eIdZTOhgT2dlN3yNzH-0ks5uBNgggaJpZM4U6zSd
.

I see,
Thank you sir. and more powers to your package.
You are the God's blessing for us small time developers/
On Fri, Jun 29, 2018 at 6:27 AM, Sergey Sedyshev<EMAIL_ADDRESS>wrote:

This implementation works directly with whois servers (not over 3rd party
sites response parsing). No, this lib is not related to
https://www.whois.com/
im trying to look up whois url creativeflooring.nz and returning null.
Only test covered domain zones provides correct DomainInfo. Other zones
could parse or could not.
Tested zones enumerated in release chanfelogs here -
https://github.com/io-developer/php-whois/releases
Parsing tests located here - https://github.com/io-develope
r/php-whois/blob/master/tests/Iodev/Whois/Modules/Tld/TldParsingTest.php
Test data here - https://github.com/io-develope
r/php-whois/tree/master/tests/Iodev/Whois/Modules/Tld/parsing_data
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/io-developer/php-whois/issues/23#issuecomment-401192081,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANfrPElfRv2t_zvX1f34Ue5nY90jOzjlks5uBVhcgaJpZM4U6zSd
.

Thank you :)
By the way the library is open for improving and contributing (but code-style and commit-style are very strict)


chore: [release-1.3] backport github folder updates for new release branches

…ranches

Description

Which issue(s) does this PR fix or relate to

Fixes #issue_number

PR acceptance criteria

[ ] Tests
[ ] Documentation
[ ] If the bundle manifests have been updated, make sure to review the rhdh-operator.clusterserviceversion.yaml file accordingly

How to test changes / Special notes to the reviewer

/assign @nickboldt


I just wanna get on with my life

I look at the kightning channel and I have outbound 147117 sats available to withdraw. But when I try to do that I keep reducing and reducing the 1% more and more and cannot send out.
I'm done with mutiny. I already lost money.
Why can't I withdraw it

Close the channel and move the funds to a different wallet. Move on.


minor updates to init and write labels

updates to labels, fixed non multiple of 10 minlat, user defined lats for labels, init creates grid_lines attribute from plotgrid function and running write label functions will replace pre existing labels

thought of some slightly better changes will send pull request when I get the chance


[BUG] Get-PnPTeamsTeam: Exception of type 'PnP.PowerShell.Commands.Model.Graph.GraphException' was thrown.

Reporting an Issue or Missing Feature
I am reporting a bug
Expected behavior
$team = Get-PnPTeamsTeam -Identity Team.Test should not return any errors
Actual behavior
 Get-PnPTeamsTeam -Identity Team.GlobalInformationSecurity
Get-PnPTeamsTeam: Exception of type 'PnP.PowerShell.Commands.Model.Graph.GraphException' was thrown.

Steps to reproduce behavior
Connect-PnPSite $adminUrl
Get-PnPTeamsTeam -Team Team

What is the version of the Cmdlet module you are running?
Name    : PnP.PowerShell
Version : 1.11.99

Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Looks like it is missing necessary permissions.
Please ensure that the app you are using has the necessary permissions to retrieve teams data.


Update test fixtures

Addressing #213
This PR updates test fixtures to actors and providers created for the 0.50 release of wasmcloud. This better establishes functionality through unit tests that represent our first party resources.
This PR also abstracts all constants in the test code to the module HostCoreTest.Constants, which is accessible from all tests. This allows us to change resources and variables in that one module, and it will update for all of the tests. Constants are still used in individual tests to create better readability.
To keep us honest, I've left some of the tests (notably retrieves provider archive from OCI image) with some hardcoded values such as assert par.claims.version == "0.13.0". I could certainly abstract that into the Constants module, but for now it ensures we update tests appropriately. (further down in the file we assert byte size of the executables, this will likely change every time we update the httpserver provider archive anyways.)
Note
This PR depends on https://github.com/wasmCloud/examples/pull/74 in order to update the oci references for echo and kvcounter, and it depends on https://github.com/wasmCloud/capability-providers/pull/101 in order to get the most up-to-date provider code. Marking as a draft for now with a fully working test suite w/ the Constants module, and would love feedback on how it looks so far.

Tests are failing at the moment because the kvcounter_unpriv module needs to be a module that has the HTTPServer capability and attempts to invoke a capability afterwards, I'll have to custom build an actor for this test (will be essentially a clone of the kvcounter example, I'll make a custom makefile to make it easy to build)


[Bug]:  Jest not detecting hidebin from yargs helper

Version
"jest": "^27.4.7"

Steps to reproduce
package.zip

download the project  and run :
npm install
npm run test
See error : SyntaxError: The requested module 'yargs/helpers' does not provide an export named 'hideBin'

Expected behavior
yargs/helper has the hidebin export and works well with the actual index.js file if ran as node index.js, hence jest should work as expected
Actual behavior
Throws SyntaxError: The requested module 'yargs/helpers' does not provide an export named 'hideBin'
Additional context
No response
Environment
System:
    OS: Windows 10 10.0.22000
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 16.5.0 - D:\Program Files\nodejs\node.EXE
    npm: 8.3.0 - D:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^27.4.7 => 27.4.7

Tracked in #9771


How can we set per-plot color here?

The datasauRus package has a simple ggplot2 example.  We can almost do the same here with a one-liner:
> tinyplot::plt(x ~ y, data=datasauRus::datasaurus_dozen, facet = ~ dataset, pch = 18)
>

yielding a not-so-shabby

But how can we jazz it up with, say, per panel plot colors?
Asking for a "friend" sitting here updating lecture slides on base plotting with a little tinyplot as one does ...

Ah, nothing that one more minute of chin-scratching cannot solve:
> tinyplot::plt(x ~ y | as.factor(dataset), data=datasauRus::datasaurus_dozen, facet = ~ dataset, pch = 18)
>

Feel free to include this as a demo, credit appreciated.

Or prettier and more compact:
> dd <- datasauRus::datasaurus_dozen
> tinyplot::plt(y ~ x | as.factor(dataset), data = dd, facet = ~ dataset, pch = 18, legend = FALSE)
>

On vacation overlooking the beach but this should work for even more compact(er) and with less whitespace.
tinyplot::plt(y ~ x | dataset, dd, facet = "by", pch = 18, legend = FALSE, frame = FALSE)

It's more or less the same (and I by now added a title).  On the marging I find facet = ~ dataset clearer.  The frame drop is so-so as we don't have a square layout:


If autoload is off, projects cannot be exported until at least one is opened

Describe the bug

A teacher reported that projects cannot be exported from the project list if autoload is off until at least one project has been opened.
Affects

[ ] Designer
[ ] Blocks editor
[ ] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[x] Other... (please describe)  Project list

Expected behavior

If autoload is turned off, checking a project and selecting "Export Project" should export the project. Instead, project ID 0 is requested and the server returns HTTP 500 (it should probably be a 403 or 404).
Steps to reproduce

In an account with projects, disable autoload via the settings menu
Reload App Inventor
Check the box next to a project
Use export project from the project menu
Note that no project is downloaded

Repeat the steps with the network tab open to observe the HTTP 500.

Hey, I would try to look into this. Please assign me this issue.

I think I have found the bug.
First let us see what works and what does not work.
When autoload is off and no project is selected

If you select any number of projects from the list and then click on "Export selected project (.aia) to my computer", the download dialogue will not appear.
If you select "Export all projects" download dialogue will appear.

When autoload is off and a project is selected
Both options work perfectly.
When autoload is on
Both options work perfectly.
When we click on the "Export selected project(.aia)" option the following snippet of code is called (in com/google/appinventor/client/TopToolbar.java):
      if (Ode.getInstance().getCurrentView() == Ode.PROJECTS) {
        List<Project> selectedProjects =
          ProjectListBox.getProjectListBox().getProjectList().getSelectedProjects();
        //If we are in the projects view
        if (selectedProjects.size() == 1) {
          exportProject(selectedProjects.get(0));
        } else if (selectedProjects.size() > 1) {
          exportSelectedProjects(selectedProjects);
        } else {
          // The user needs to select only one project.
          ErrorReporter.reportInfo(MESSAGES.wrongNumberProjectsSelected());
        }
      } else {
        //If we are in the designer view.
        Downloader.getInstance().download(ServerLayout.DOWNLOAD_SERVLET_BASE + ServerLayout.DOWNLOAD_PROJECT_SOURCE + "/" + Ode.getInstance().getCurrentYoungAndroidProjectId());
      }
    }

The bug is due to the first if condition  if (Ode.getInstance().getCurrentView() == Ode.PROJECTS).
When the Ode is initialized, the currentView is set to DESIGNER.
(in com/google/appinventor/client/ode):
  public static final int DESIGNER = 0;
  public static final int PROJECTS = 1;
  public static final int USERADMIN = 2;
  public static final int TRASHCAN = 3;
  public static int currentView = DESIGNER;

So when autoload is off, we are in PROJECTS view but Ode incorrectly returns DESIGNER as the currentView. This causes the if condition to fail and the else clause
Downloader.getInstance().download(ServerLayout.DOWNLOAD_SERVLET_BASE + ServerLayout.DOWNLOAD_PROJECT_SOURCE + "/" + Ode.getInstance().getCurrentYoungAndroidProjectId());
to run. This is run assuming we are in the designer section of appinventor. As we are not in the designer (and no project is selected), project-id is 0. This causes the code in com/google/appinventor/client/utils/Downloader to ask the server for file(s) at link "http://localhost:8888/ode/download/project-source/0". This file(s) does not exist. Hence the server returns HTTP 500.
If we rather select "Export all projects" we avoid the bug.
private static class ExportAllProjectsAction implements Command {
    @Override
    public void execute() {
      Tracking.trackEvent(Tracking.PROJECT_EVENT,
          Tracking.PROJECT_ACTION_DOWNLOAD_ALL_PROJECTS_SOURCE_YA);

      // Is there a way to disable the Download All button until this completes?
      if (Window.confirm(MESSAGES.downloadAllAlert())) {

        Downloader.getInstance().download(ServerLayout.DOWNLOAD_SERVLET_BASE +
            ServerLayout.DOWNLOAD_ALL_PROJECTS_SOURCE);
      }
    }

As here it does not matter whether we are in DESIGNER or PROJECTS view.
Whenever a project is selected and we return to 'MyProjects' window it calls the following method:
public void switchToProjectsView() {
    // We may need to pass the code below as a runnable to
    // screenShotMaybe() so build the runnable now
    hideChaff();
    hideTutorials();
    Runnable next = new Runnable() {
        @Override
        public void run() {
          ProjectListBox.getProjectListBox().loadProjectList();
          currentView = PROJECTS;
          getTopToolbar().updateFileMenuButtons(currentView);
          deckPanel.showWidget(projectsTabIndex);
          // If we started a project, then the start button was disabled (to avoid
          // a second press while the new project wizard was starting (aka we "debounce"
          // the button). When the person switches to the projects list view again (here)
          // we re-enable it.
          projectToolbar.enableStartButton();
          projectToolbar.setProjectTabButtonsVisible(true);
          projectToolbar.setTrashTabButtonsVisible(false);
        }
      };
    if (designToolbar.getCurrentView() != DesignToolbar.View.BLOCKS) {
      next.run();
    } else {
      // maybe take a screenshot, second argument is true so we wait for i/o to complete
      screenShotMaybe(next, true);
    }
  }

This method promptly sets the currentView to PROJECTS hence the if condition does not fail and we get the expected behaviour.
In the remaining cases we avoid the bug as the initial view is designer which is same as assumed by Ode.

@ewpatton
What can be the further course of action?

Your analysis seems pretty thorough. Please try making the change and if it works submit a Pull request.
Sent from my iPhone

On Mar 12, 2021, at 16:56, Himanshu Garg @.***> wrote:

@ewpatton
What can be the further course of action?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

For solving this bug I had made the following changes:
in com/google/appinventor/client/Ode.java
public static int currentView = DESIGNER;
public static int currentView;
and
inside onModuleLoad() in onSuccess() call of OdeAsynCallBack (lines 757 - 799):
userSettings = new UserSettings(user);
userSettings.loadSettings(new Command() { .......... }

// New code added here
// Set the current view of Ode
        if(getUserAutoloadProject()) {
          currentView = DESIGNER;
        } else {
          currentView = PROJECTS;
        }

It turns out that the call to getUserAutoloadProject() always return true. This is because the default value of SettingsConstants.USER_AUTOLOAD_PROJECT is set to true and it does not change on initializatoin (found in GeneralSettings.java).
@ewpatton What should I do to know whether autoload is on or off? I was not able to find another way. I will need your help in this.
I want to ask one more thing, should I ask these type of queries here or on the community website?

@ewpatton thoughts?

@Himanshu2107 It might just be simple enough to start with currentView = PROJECTS, which is the first view that is visible anyway. The fact that it is initialized to DESIGNER when in fact the first view is not the designer seems like the correct. This wouldn't require waiting for the user settings to be loaded.

Okay.
This change fixes both #2419 and #2433.

Fixed by #2436


Java fix

Fixes #524. The TDD entries are taken care of in a seperate PR.

Good Job, but why do you rename most of the classes in contradiction to the Java Code Conventions? https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html

Ik, @tobi6112.
Do you mean the underscores?

Ik, @tobi6112.
Do you mean the underscores?

Yeah, exactly.

I, too, adhere to said Convention and exclusively use PascalCase for class names. Sonarlint already warned me about this.
Nonetheless, I decided to separate the names with _ for improved readability. Otherwise, class names would have ended up like FizzBuzzPseudoRandomCSVGen as opposed to
https://github.com/NLDev/Hacktoberfest-2020-FizzBuzz/blob/ab0f3d609fbdfb89bcdcc2fcf3f19dc521bff336/Java/FizzBuzz_PseudoRandomCSVGen.java#L10
(and I, like many others, really wanted to keep FizzBuzz in the title).

Awesome! Thanks you :D

I thank you too, @NLDev, for merging all of my PRs! 😄
If you need a co-maintainer who reviews PRs and checks them for mistakes, I will gladly help you with this.

Hey! Thank you for the offer :D
That would be pretty cool I guess but I'm not sure whether that'll work out or if it leads to mistakes.
I enforce a certain set of rules that determine if a PR should be merged or closed. Sometimes I'm even uncertain myself :/


Set interop to "compat" in client package Vite config

Set interop to "compat" in client package Vite config
Remove workaround added in #261

#315  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


scale_y_continuous label issue

I tried to use the following code to label the ticks in y axis however I got an error msg "TypeError: unhashable type: 'list'"
scale_y_continuous(breaks=range(0,800000,100000), labels=["0K","100K","200K","300K","400K","500K","600K","700K","800K"])
By looking at the source code here: https://github.com/yhat/ggplot/blob/master/ggplot/scales/scale_y_continuous.py
It looks like the code is checking if the list exists in the dictionary using
if self.labels in LABEL_FORMATS
LABEL_FORMATS = {
'comma': comma,
'dollar': dollar,
'currency': currency,
'millions': millions,
'percent': percent
}
So this means that adding a customized label is not even possible... however there's an example here that illustrate it should work: http://blog.yhathq.com/posts/ggplot-for-python.html
from ggplot import *
print ggplot(mtcars, aes('mpg', 'qsec')) +
geom_point(colour='steelblue') +
scale_x_continuous(breaks=[10,20,30],
labels=["horrible", "ok", "awesome"])

I ran into this same issue.
Your example works because it is for scale_x_continuous and scale_x_continuous and scale_y_continuous have different implementations.
Ideally the two methods would work similarly. One approach is to add a check to see if the labels are hashable as described here.

The current scales were implemented with out strict adherence to ggplot2, this will change in the future and this issue should then be gone.

I have a similar issue. The following code works:
import ggplot, pandas
df = pandas.DataFrame({'x': [0,1],'y': [1,2]})
ggplot.ggplot(df, ggplot.aes(x = 'x', y = 'y')) +
ggplot.geom_point() +
ggplot.scale_x_continuous(labels = [])
But the following code:
import ggplot, pandas
df = pandas.DataFrame({'x': [0,1],'y': [1,2]})
ggplot.ggplot(df, ggplot.aes(x = 'x', y = 'y')) +
ggplot.geom_point() +
ggplot.scale_y_continuous(labels = [])
Gives the error:
Traceback (most recent call last):
File "", line 3, in
File "/home/genovese/.local/lib/python3.4/site-packages/ggplot/scales/scale_y_continuous.py", line 28, in radd
if self.labels in LABEL_FORMATS:
TypeError: unhashable type: 'list'

I am experiencing the same issue with a facet plot. I simply wanted all the y scales to look the same and within the same range. It seems to be not possible using scale_y_continuous.
I tried with scale_y_discrete, and in that case I was able to set the ticks but not the limits.

I had the same issue. Aa @edoardovivo said, I tried scale_y_discrete to be able to set the ticks. However I added the ylim() component to my plot to make it work.
My code is the following:
p = ggplot(aes(x='m2construidos',y='preciom2'), data=aa) +
geom_point(color='#0070C0', size=25, alpha=0.4) + xlim(20,lims_rec[recamaras]) +
stat_smooth(color='gray', size=1.5, alpha=0.3, fill='steelblue') +
facet_wrap('zona', scales='fixed') + xlab('') + ylab('') +
scale_x_continuous(breaks=range(20,lims_rec[recamaras],20), labels=range(20,lims_rec[recamaras],20)) +
scale_y_discrete(breaks=[20, 40, 60, 80], labels=['20k', '40k', '60k', '80k']) + ylim(0, 60)

fixed


Checksums link on download page redirects to old 4.1.1 checksums

The link on https://dbeaver.jkiss.org/download/ pointing to https://dbeaver.jkiss.org/files/checksum-latest redirects to https://dbeaver.jkiss.org/files/4.1.1/checksum/, i.e. version 4.1.1, when it should currently redirect to https://dbeaver.jkiss.org/files/4.1.3/checksum/, i.e. version 4.1.3... :)

Fixed (it was a bug in release publishing script).
Thanks for report!


Avoiding argument_type_not_assignable, return_of_invalid_type

PTAL @sigurdm

@rakudrama I've dropped the as clause, adding return_of_invalid_type to the ignore_for_file line instead.

It would be much better to make GeneratedMessage generic.

I should go and revive https://github.com/dart-lang/protobuf/pull/180 ...

Is this safe to land?

Cool, thanks. I'll roll a follow up PR to bump version numbers in preparation for a pub push.

(I don't have rights to merge this, btw =)


PROPOSAL - Make the Timezone be channel specific

Is your feature request related to a problem? Please describe.
Today our instance of Mattermost is used across many different timezones. Having the stand up raven only have a single global timezone does not work well for all our different teams.
Describe the solution you'd like
It would be great if we can configure the timezone per channel, so the standup window would be channel/timezone specific.
Describe alternatives you've considered
Not sure what else can be done to fix this.
Additional context
N/A

@attzonko that's a great idea! Would you be willing to contribute on this one?

@attzonko that's a great idea! Would you be willing to contribute on this one?

Sounds like fun, I'll need to dive into Go, will keep you posted...

@attzonko great!

@attzonko hi, just checking in if you've made any progress on this or if you need some help.

I have started the process of learning golang :)
If you have any pointers on setting up the dev environment for developing and testing plugins please share.
Thanks!
Alex
On Jun 4, 2019, at 4:54 PM, Harshil Sharma<EMAIL_ADDRESS>wrote:
@attzonko hi, just checking in if you've made any progress on this or if you need some help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@attzonko The quickest way to setup Mattermost locally is via docker, following the instructions over here. Standup Raven setup instructions are available over here .

Let me know if you need any assistance with the issue. I'll be more than glad to assist!


samples: mesh: nrf52: removed unwanted code

Removed unwanted code which is not allowing GET response
to get send by Server to client. After removing this, there
is improvement in GATT Bearer performance while testing
with Android nRFMesh App.
Also try to removed repeated code by using #define macro at
single location.
Signed-off-by: Vikrant More<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2d38c91). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12017   +/-   ##
=========================================
  Coverage          ?   47.96%
=========================================
  Files             ?      281
  Lines             ?    43400
  Branches          ?    10403
=========================================
  Hits              ?    20816
  Misses            ?    18432
  Partials          ?     4152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d38c91...fed3fbc. Read the comment docs.

Please wait.

@jhedberg
After making changes as per 3rd commit, I could save #ResetCounter value on flash. Otherwise on every reboot it is not getting updated & remains Zero. That means changes made by https://github.com/zephyrproject-rtos/zephyr/pull/9521 have issue.


Unable to RunSpecifiedTests despite test file included in package.xml manifest file

I'm getting the below error when deploying Apex class with the associated test class defined in my package.xml file.
Example manifest file:
<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
  <types>
    <members>MyApexClassTest</members>
    <members>MyApexClass</members>
    <name>ApexClass</name>
  </types>
  <version>50.0</version>
</Package>

The error I see in github actions log:
=== deploy ===
=== getApexTestClass ===
Error: ENOENT: no such file or directory, open '/classes/ServiceUtilsTest.cls'

@manuelcortessf @manuelcortes15 - can you take a look into this if possible? Just let me know, else I can take a look.
@JasonFung6 , thank you for reporting.

@tiagonnascimento after look at the repo source files I realised the default source path was not defined, i've created a PR to update the readme: #12 - it will be good if this default path is set in the JS files rather than having to define this in the .yaml

@JasonFung6 , thank you for your contribution. I merged your PR and I'm adding the default value as suggested as well.


Change repository name / fix Binder link

The short of it
If we change the repository name back to jupyterlab-ide, the binder badge link should work again.
@Dcosthephalump could you...

[x] change the repository name to jupyterlab-ide
[x] #6
[x] make sure the Binder link works again
[x] If that fixes it, make a comment below that says such and close the issue
[x] If it is still broken for some reason, create and issue about what the error is and how you think you might fix it

Thinking behind this
The reason the binder doesn't work is because I changed the repository name and didn't update the binder badge to match. But I think we should work on the name together. I was thinking that awesome-jupyterlab already exists. Our repository is still trying to be a comprehensive list but the scope is smaller. We are only concerned with features that improve the development environment. I think the repo name needs to reflect that. If we had a ton of space, the most straight forward name would be awesome-jupyterlab-development-environment. But we also don't want a name that is too long. I used to call the repo jupyterlab-ide, but I'm concerned that not everyone will be familiar with the term. Then again, maybe we should take a step back...
Who is our audience? Is it developers or scientists.... or both? I think for any educational material it's important to figure this out before writing anything. I think it may be easier to create this tutorial for a software developer audience. That way, we can use terms like IDE, tab completion, etc., without having to explain what each of those are. If we wanted to expand the scope of this work, and include scientists, we could do that in another branch or another repository and adding the additional background info the scientists would need to digest the info.

Link is fixed!


integration tests on production is not working

It seems like two issue:

GitHub Actions
Parallel test execution

Running integration test sequentially, it finishes after 16 mins locally.
In case of parallel execution, it goes into never ending process.
//cc
@olavloite

It might very well be that reducing the number of tests that are allowed to run in parallel will also help (instead of bringing it completely back to 1 by disabling parallel execution).

This has been fixed.


Fixing issue with duplicated rows when looping through groupby object

Resolves #458
Only gets the unique values of the index
Add test to validate changes

What do these changes do?

Related issue number

[x] passes flake8 modin
[x] passes black --check modin
[x] tests added and passing

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/476/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/477/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/478/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/479/
Test PASSed.


HSM support design doc

We need to have HSM support to allow for Node Operators to protect the node keys properly.
Details
Which HSMs do we support? Do we just support PKCS11? Do we support Cloud based HSMs?
Acceptance Criteria

A design doc and work plan for getting HSM support in Ekiden are written and the epic/issues for the work is properly costed.

Support can be done by extending the remote signer.  I'm not sure what more needs to be done here.


Find a better naming for chePlugin spec reference

Currently the following syntax are used to reference the spec in a che-plugin registry or in a yaml file published on the internet respectively:
components:
  - chePlugin:
      registry:
        id: redhat/vscode-yaml/latest
        registryUrl: "external-registry-url"
  - chePlugin:
      url: https://gist.../meta.yaml

That may be confusing. We should find a better name.

In the PR https://github.com/che-incubator/devworkspace-api/pull/29, that introduces changes agreed on in issue #25, I included the following proposal which would also be useful to reference a parent devfile inside a devfile registry:
components:
  - chePlugin:
      registryEntry:
        id: redhat/vscode-yaml/latest
        baseUrl: "external-registry-url"
  - chePlugin:
      url: https://gist.../meta.yaml

To be fully consistent with the parent case, we could use uri instead of url when pointing directly to a plugin meta.yaml

Implemented


Missing "--no-scan " option ?

Is it planned to add the "--no-scan" option ?
I have a folder with many (many many... ;)) objects... causing a very (very very) long "determining size..."
Thx in advance, and many thx for the work

Currently, there is no no-scan option, but if you use no-progress, the scanning is omitted. Would you wish to have an option which doesn't scan, but still displays some progress (of course missing something like ETA and percentage, so no real progress bar)?

Exactly, having speed, and maybe file/folder currently on (i look @ /proc/../fd actually ;)), is the only "need".
I will test with no-progress to see the gain.


Planning failed with one static obstacle ahead the vehicle under SimControl mode

System information

OS Platform and Distribution  Linux Ubuntu 14.04:
Apollo installed from (source or binary): source
Apollo version (1.0, 1.5, 2.0, 2.5, 3.0):  latest master branch

Steps to reproduce the issue:

generated one static obstacle in the middle of the lane with the script "replay_perception.py"(the purple one in pictures)
start simcontrol --> start planning, routing and prediction modules --> set the start and end point in the map --> send routing request
planning started, when approaching the obstacle, the vehicle made a stop decision for a while, like in this picture:

then after about 10s the vehicle made a path planned like in this picture:

but it didn't followed the path exactly, which is to change to another lane with a big turn, but decided to turn with a smaller angle like this:

and by turning the vehicle failed to drive pass the obstacle and stopped near it, forever...

Do you guys have any idea why the vehicle acts like this? The planner used is EM-planner.
I've noticed that in this file  apollo/modules/planning/conf/lane_follow_scenario_config.pb.txt  we can change the parameters for EM-planner, but I'm not quite sure which parameter or constraint I should change for this case.
Any idea or suggestion is appreciated! Thanks a lot :)

Thanks. We also noticed this. It will get improved in the next release.

@lianglia-apollo thank you for your reply. Looking forward to your new release. But before it can you please maybe give me some hints about where the reason may come from? I´d very like to give it some try. :)

@lesun90 thank you very much for reply, really appreciate it. I'll try following your advice :)

by changing the parameter Step_length_min and step_length_max to 11, can the vehicle successfully pass the obstacle. according to my experiments 11  is the  limit value in this case. Thank you all.


Combine release and opam-publish workflows

It seems that the release created by our updated release workflow doesn't trigger our opam-publish workflow. We should be able to combine them to make it all work.

Almost finished in #69 except I need to figure out bash escaping.

Still having problems with the changelog generation. Please kill me.


Colorize abstract keyword

This fixes https://github.com/Microsoft/TypeScript-Sublime-Plugin/issues/347.
Or maybe we should use a different color?

:+1:


Further destroy the existence of "nilId" (ENG-2469)

Description
This PR furthers the destruction of nilId throughout the codebase. It does this by migrating as many dal-based identifiers from the pk! macro to the id! macro as possible. The macros are extremely similar, but the id! macro does not include the ability to create nilIds easily.
All remaining locations using the old pk! macro have been marked with a TODO comment indicating what's to come.
Reminder
This macro (id!) works for primary keys, just as the old macro (pk!) worked for identifiers in the past.
Additional Changes
In addition to these changes both the node.rs and job_failure.rs modules have been removed due to lack of use. The job failures table will still be migrated in order to not interrupt existing SI deployments, but it is effectively dead.
You may also notice that AttributePrototypeSource had its EnumIter and EnumString derived traits removed. This is because they rely on the identifiers to implement or derive Default, which the new macro does not provide an implementation for (intentionally).

Local testing succeeded including actions, authoring, creating and attaching new funcs, etc.


Resolve upgrade issues

Tested with an upgrade between 1.6.3 and 1.6.4. This will resolve #1312 and #1314.

ci check this


[AutoRelease] t2-web-2024-11-15-27956(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/5711
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=969

issue link:https://github.com/Azure/sdk-release-request/issues/5711

/check-enforcer override


Request: Wrap in Cargo watch

Currently I need to do:
[tasks.run]
install_script = [
'''
if ! [ -x "$(command -v cargo-watch)" ]; then
  cargo install cargo-watch
fi
'''
]
script = [
'''
cargo watch -c -q -x run
'''
]

What I'd like to do is:
[tasks.run]
command = "cargo"
args = ["run"]
watch = true
watch_args = ["-q", "-c"]

Taking it further I'd also like a --watch or -w from the command line to set watch = true. E.g.. cargo make -w run
Thoughts?

actually if you do command cargo and first arg watch it will install it automatically if needed.
the following is defined in the internal makefile.toml
[tasks.watch-flow]
description = "Watches for any file change and if any change is detected, it will invoke the test flow."
category = "Development"
command = "cargo"
args = ["watch", "--exec", "make dev-watch-flow"]

That's good to know. I saw that and assumed it wasn't cargo-watch for some reason.

I still think this request can be useful as it'd be more straight forward and more easily used for non cargo command tasks. A cargo make --watch foo would translate to cargo watch -x "cargo make foo".

I'm not 100% sure it belongs to the task runner itself.
I do have a way to implement it in the makefile.toml like the example I gave, but you are asking it to be integrated with the runner and i'm not sure if that's the design I want as it makes it too coupled with a specific 3rd party + it brings external functionality to the core of the tool.
I know it will be easier, just not sure if its correct approach.


Changes/fixes to messaging

[ ] As an applicant, the email notifications i'm getting are sometimes rendering uglily "We appreciate your adam's" (that should be a adam's"
[ ] Lead @mentions are not being rendered in the message and slack names for users not being used
[ ] Changes to the slack notifications (see following msgs)
[ ] Transition Notifications not firing
[ ] Changes to the email notifications (see following msgs)

Current
MESSAGES.COMMENT: 'A new comment has been posted on <{link}|{submission.title}>',
Changed to
MESSAGES.COMMENT: 'A new {private|internal|public|reviewer} comment has been posted on <{link}|{submission.title}>' by {user},
Current
MESSAGES.REVIEWERS_UPDATED: '{user} has updated the reviewers on <{link}|{submission.title}>',
Changed to
This one shouldn't really start with the @lead: etc but should start with each of the assigned reviewers. e.g. @tara @wei @blah: etc
MESSAGES.REVIEWERS_UPDATED: '{user} has assigned you as reviewers for <{link}|{submission.title}>',

In the slack msgs that show the review score, only show 0.00 dec places (not 0.000000000000)

Also see #170

The "We appreciate…" text will include the fund title so it should look ok. In one I got it says:
"We appreciate your Internet Freedom Fund application submission to the Open Technology Fund."
Lead @mentions and other Slach works now, see the #notice channel. Imported users was missing an @ in front of the slack name.
Adjusted the notification for comments, see pr.
The REVIEWERS_UPDATED notice is that not just to alert staff that updates have been done. Reviewers are alerted in READY_FOR_REVIEW when a submission is move to state "In review".
Transition notifications seems to work for me, please test and report back.
@todd-dembrey How to best fix the score formatting in NEW_REVIEW? I notice there is an get_score_display() function in the model.


remove trailing slash for default behavior.

The trailing slash is causing issues as https://api.github.com/repos/aquasecurity/tfsec/releases will return the
full list of releases where as https://api.github.com/repos/aquasecurity/tfsec/releases/ will not.
when using the INPUT_TFSEC_VERSION, prepend a slash for the path to be fully formed.
Signed-off-by: Kenny Leung<EMAIL_ADDRESS>

+1 on this PR as it has failed on a bunch of our builds as well


use absolute path for default ffmpeg/core lib

fixes #383 for me -- but I'm unsure about other side-effects of this

nvm 🤦


⚠ Bofrost.lu has degraded performance

In 450c54c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2086 ms

Resolved: Bofrost.lu performance has improved in a00f5d0 after 34 minutes.


Fix few bugs

A few bugs in updating k,J and update of noises.

So the ARD test is the only one failing. Even in master, however, this test fails when slightly changing the noise prior. I'm not sure how to proceed. Maybe you could deactivate the test and open an issue...

So the ARD test is the only one failing. Even in master, however, this test fails when slightly changing the noise prior. I'm not sure how to proceed. Maybe you could deactivate the test and open an issue...
Edit: Also nice catch of the bug with the too early return in update_noise`! How did you find that? Could you provide a test case or extend an existing one?

To your Edit. @TTitscher :
My example had several noise groups some of which were prescribed. When I checked the algorithm in debug mode, however, I realized that none of noises are updated.
I do not know if it is always possible (or wise!) to come up with tests that are able to detect ANY possible coding bug (like this one). I mean, there could be no end for that. Maybe a test could be that we observe a change of noise parameters in a problem with several noise groups, where some of them are prescribed and some are identified. Does that make any sense in your opinion ?

I do not know if it is always possible (or wise!) to come up with tests that are able to detect ANY possible coding bug (like this one).

(As always in life,) we should to our best to repeat the mistakes/bugs. So it is certainly not possible to detect any possible bug, but in this case, we exactly know the bug and could provide a test to prevent it. I mean, if I revert the bugfix, say by accident, I have no idea that I break your code.

I do not know if it is always possible (or wise!) to come up with tests that are able to detect ANY possible coding bug (like this one).

(As always in life,) we should to our best to not repeat the mistakes/bugs. So it is certainly not possible to detect any possible bug, but in this case, we exactly know the bug and could provide a test to prevent it. I mean, if I revert the bugfix, say by accident, I have no idea that I break your code.

I added a test in last commit. If it is fine now, then I merge the pull request.


Fixed bug where Viewport would be cleared with clear_mode NEVER

SubViewport would clear with the default background color even when clear_mode was set to VIEWPORT_CLEAR_NEVER.

Looks good! Could you squash the commits? See PR workflow for instructions.

Yeah, I should've done this work in a branch. Not too familiar with git. The squash seems to have become its own commit instead. Maybe I shouldn't have merged the changes from master. It's a complete mess. Let's just say me and git are not on friendly terms.

Yes you should not merge master back into your branch after rebasing. You can rebase on top of master but not merge.
If you haven't done so, start with:
git remote add upstream https://github.com/godotengine/godot
git fetch upstream

Then, on your local master branch (used for this PR):
git rebase -i upstream/master
# Replace "pick" with "fixup" for commits 2, 3, and 4, confirm
git push --force origin master

You know what, I'll start over and do it right. It'll be good for me to get an understanding of the workflow. I'm sorry for the inconvenience.

Superseded by https://github.com/godotengine/godot/pull/60705.


Refactor DocumentationTopic view to be able to reuse the navigator for other views

Bug/issue #116400979, if applicable:
Summary
Refactor DocumentationTopic view to be able to reuse the navigator for other views
Dependencies
NA
Testing
Steps:

Test that all the documentation pages in the render work well

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

I don't think we should treat the newly created component as a view. Generally, the views components are fully functioning pages that we directly render in routes.js.

Agreed. This is essentially the only thing that differentiates a "view" from a normal component with how things have been set up so far, and breaking from that could be kind of confusing for newcomers to the codebase.

I think what we are interested in is more of a versatile template for a structure of the page. This page can have some sort of nav/header across the top, potentially some sort of navigator on the left, and some sort of content component on the right. Thus, I don't think the name BaseNavigatorView is fitting either. We should bake in more flexibility on what can be rendered across the top, on the left, and on the right.

I also agree with this at a high level. It seems that you've tried to refactor things to be more generic, but the way it is presented so far seems pretty specific to the documentation pages.

@swift-ci test

@swift-ci test

@swift-ci test


Broken page in documentation for ObjectExt

The ObjectExt page currently 404's in the documentation. However, it is linked from other pages like gtk::Settings.

The link in gtk::Settings correctly points to glib::object::ObjectExt now.

Yup, looks to be fixed. Thanks.


docs: Add type information to return value of read_file reference

Where did you see the issue in our documentation?
https://docs.kurtosis.com/starlark-reference/read-file/
Issue description
It's not clear what read_file returns to me, so I don't know how to plug it in to other starlark functions

Thanks @galenmarchetti! The contents of the file are returned as a string! I'll make sure to add docs for this.


fix: use native modal dialog and use its backdrop

This uses the <dialog> element with showModal() method, so that we can leverage the browser's built-in ways to make this dialog modal, including keyboard handling (Esc), backdrop and focus trap.
Fixes the issue that it was possible to tab outside the dialog while it was open.
Rmoves the backdrop component, as the <dialog> element comes with a backdrop built-in, that is styled via CSS instead.
fixes https://github.com/facebook/docusaurus/issues/9457

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

@slorber : I'm not sure how to make that last autolintfix check run, please advise.


More libraries need to be moved to manual-link.

libhwloc and boost_unit_test both export main symbols. As such, they need to be moved to manual-link.
C:\Code\Projects\vcpkg\installed\x64-windows-static\debug\lib\manual-link>(dumpbin boost_unit_test_framework-vc140-mt-gd.lib /symbols   | findstr /c:"| main"   2>NUL )
1003 00000590 SECT5  notype ()    External     | main

C:\Code\Projects\vcpkg\installed\x64-windows-static\debug\lib\manual-link>(dumpbin libhwloc.lib /symbols   | findstr /c:"| main"   2>NUL )
042 00000000 SECT4  notype ()    External     | main
0A5 00000000 SECT31 notype       Static       | main$rtcName$0
0A6 00000004 SECT31 notype       Static       | main$rtcName$1
0A7 00000010 SECT31 notype       Static       | main$rtcName$2
0A8 0000000C SECT31 notype       Static       | main$rtcName$3
0A9 00000018 SECT31 notype       Static       | main$rtcName$4
0AA 00000040 SECT31 notype       Static       | main$rtcVarDesc
0AB 00000028 SECT31 notype       Static       | main$rtcFrameData

Personal opinion: VcpkgAutoLink should probably be deactivated by default.
Reason: It (possibly) adds a a lot of libs to be searched for symbols. It isn't even required if you use cmake to build your project. Automatic linkage is only required by VS if you are too lazy to define the linked libraries by hand... (and I am a fan of #pragma comment(lib XXX)). And i think the automatic linkage could have possible side effects if the wrong symbols are found for some reasons.

I would generally prefer to see the libs linked with pragmas, yes, and think that would be a reasonable thing for the vcpkg patches to enforce, but this is what we have right now, so any lib which defines main must be put in the manual-link directory. That's certainly the path of least resistance!

I have ever spent several hours to realize that an obscure linking issue in MSVC caused by 'VcpkgAutoLink'. That is, Vcpkg lib folder contains libmysql and libmariadb files which both have almost same symbols, that causes my app always link to one unwanted lib file regardless the one designated via #pragma or in link command.
I support the idea someone suggested earlier that command "vcpkg integration install" should have an argument to switch between auto-link and manual-link.

@haquocviet

I have ever spent several hours to realize that an obscure linking issue in MSVC caused by 'VcpkgAutoLink'.

That seems to be a serious problem with 'VcpkgAutoLink'. What exactly was the issue? Just not linking correctly and thus not generating an exectuable/library or something more serious?

I support the idea someone suggested earlier that command "vcpkg integration install" should have an argument to switch between auto-link and manual-link.

Maybe #4361 would be an option if you use vcpkg and Visual Studio?

That seems to be a serious problem with 'VcpkgAutoLink'. What exactly was the issue? Just not linking correctly and thus not generating an exectuable/library or something more serious?

Is my explanation earlier about libmysql and libmariadb not clear enough?
You see here, I get the excerpt from vcpkg.targets file:
<AdditionalDependencies Condition="'$(VcpkgNormalizedConfiguration)' == 'Debug' and '$(VcpkgAutoLink)' != 'false'">%(AdditionalDependencies);$(VcpkgRoot)debug\lib\*.lib</AdditionalDependencies>
<AdditionalDependencies Condition="'$(VcpkgNormalizedConfiguration)' == 'Release' and '$(VcpkgAutoLink)' != 'false'">%(AdditionalDependencies);$(VcpkgRoot)lib\*.lib</AdditionalDependencies>

I thought I don't need to explain about how %(AdditionalDependencies) is when $(VcpkgAutoLink) = true.
Next suppose vcpkg was installed in "e:\vcpkg" and you want to build a program "Program.exe" for x64-release, MSVC's link command should look like this:
link.exe OUT:"~\Program.exe" Link-options
	/LIBPATH:"e:\vcpkg\installed\x64-windows\lib" <-- it's correct as my assumption about vcpkg's integration
	"e:\vcpkg\installed\x64-windows\lib\*.lib" <-- this is the culprit.
	kernel32.lib user32 ...
	your-sources.obj ...

Obviously, when $(VcpkgAutoLink) = true, the linker tries to link to all lib files installed in vcpkg.
I guess when the linker finds a first lib file containing required symbols, the linker shall reject subsequent libs containing same symbols. That explains why my program always loads libmariadb.dll instead of libmysql.dll though I explicitly set the program link to libmysql.lib.
In this case, just renames libmariadb.lib to other doesn't help unless deleting it (bad method).
My solution is manually setting $(VcpkgAutoLink) = false in vcpkg.targets meanwhile waiting for better method.

I support the idea someone suggested earlier that command "vcpkg integration install" should have an argument to switch between auto-link and manual-link.

Maybe #4361 would be an option if you use vcpkg and Visual Studio?

I don't know, I didn't check it.

If it were up to me, for every vcpkg library that does not already have pragma lib comments, I would consider something along the lines of:

adding a header vcpkg.h that is #included from the project's main/primary include(s)
that header would contain the necessary pragmas to link the relevant .lib (DLL or static, debug or release)
the pragma would be guarded by a symbol such as VCPKG_NO_AUTOLINK, so if you wanted to opt out of the vcpkg behaviour, you could. The VCPKG CMake integration would define that symbol so that specifying which libs get linked is handled by CMake.

Just blindly linking every .lib as is currently done is not a good solution. It is not reliable (see the above example, where both mariadb and mysql define many symbols in common, as they're forks of the same codebase), it is already not consistently usable (see the above example where a number of libs define main).
A header of the type I suggest would obviously be a lot more work, but it would mean that every single library could be autolinked reliably, including the ones that are currently problematic.

We need to make a list for these ports.

I think we also need a way to check this after build.


Minor: consul_advertise_address not documented

The role variable exists and is used in the consul.conf.j2 template, but is not documented in the README. The property doesn't have a default value, so I'm not sure about where is the best place to add it.

@palmerabollo If you do not define consul_advertise_address it is not added to the configuration. From the Consul documentation:

-advertise - The advertise address is used to change the address that we advertise to other nodes in the cluster. By default, the -bind address is advertised.

That said, I do agree that this should be added to the README.


Fix codecov

To see result of change: https://codecov.io/gh/jdpedrie/google-cloud-php/branch/codecov
edit:

We're going to move codecov submit over to Kokoro, so I'll close this out.


Added UV sensor family si114x

Code based on the UPM project.

fixed incorrect timer return
fixed documentation
misc fixes
Signed-off-by: Tomaz Canabrava<EMAIL_ADDRESS>

Please don't refer to the past when writing commit messages. Prefer to use something along the lines of "Add UV sensor family SI114X".

closed because of v3
https://github.com/solettaproject/soletta/pull/485


Adding final to modify the utility method

Describe what this PR does / why we need it
adding final to modify the utility method
Does this pull request fix one issue?
No.

Describe how you did it
added a final key word
Describe how to verify it
checked the code
Special notes for reviews
None

Why do you want modify the method type to final?


html/template: Add support for JavaScript modules

template/html does not properly treat javascript code as javascript when using a <script type="module" tag:
<!doctype html>
<html lang="en">
	<head>
		<meta charset="utf-8" />
	</head>
	<body>
	<script type='module'>
		1 <= 2
	</script>
</html>

What did you expect to see?
<!doctype html>
<html lang="en">
	<head>
		<meta charset="utf-8" />
	</head>
	<body>
	<script type='module'>
		1 <= 2
	</script>
</html>

What did you see instead?
<!doctype html>
<html lang="en">
	<head>
		<meta charset="utf-8" />
	</head>
	<body>
	<script type='module'>
		1 <= 2
	</script>
</html>

See also: https://www.w3.org/TR/html5/semantics-scripting.html#element-attrdef-script-type
I created a pull request that fixes the issue: #27697

So, a couple of thoughts on this: module context should probably follow the same escaping rules that scripts currently have.
The only difference is for import statements. Those will likely need to sanitize the string as script src AND javascript string.
@mikesamuel  do you have more context on JS modules differences with normal scripts?

@empijei There's no significant difference.
A JS ModuleBody is just a strict mode ScriptBody that can also contain import and export declarations.
So I think we can add "module" to https://golang.org/src/html/template/js.go#L390
func isJSType(mimeType string) bool {
        ...
	switch mimeType {
	case
		"application/ecmascript",
                ...
        }
        ...
}

The only reason I created this issue is that I was asked to create it in addition to the merge request I already created: #27697. And yes, it does add a single line to this function.

@tomuta, thanks for explaining.  Now I see https://go-review.googlesource.com/c/go/+/135417

@empijei

The only difference is for import statements. Those will likely need to sanitize the string as script src AND javascript string.

This is a good point, and there're module expressions: import(...) which is only stage 3 as far as TC39 is concerned but which is widely implemented: https://caniuse.com/#feat=es6-module-dynamic-import

It sounds like we should do this (and accept CL 135417 once it is reviewed).


eclipestore guide

Do we need to update the ExecuteOn in the MicroStream guide to TaskExecutors.BLOCKING?
I guess not, as I guess that guide will be retired?

we should update every guide. I will do that.


Cannot create an outgoing connection

Screen hangs on "Loading..."
Off of dev-requirefy
From logs:
console.log: uproxy: Starting to proxy for CopyPaste
console.log: uproxy: UI sending Promise Command START_PROXYING_COPYPASTE_GET {"cmd":"emit","type":1008,"promiseId":2}
JavaScript error: resource://gre/components/PeerConnection.js, line 362: NS_ERROR_MALFORMED_URI:

Fixed in dev-requireify


Tagging

Multiple tag options from check box possible now. UX/UI can be improved in the future

We need to stub The API request tests and also write some tests for the tagging feature

This is awesome & it totally works! Thanks so much! I love the checkboxes! eeeeeeee!
A few things that I think need to be done before it can be merged:

tests (which you already mentioned above)

can you pls list the tags related to the drop on the drop#show page? It doesn't have to be anything fancy, just something like Tags: sound, tour. Perhaps below the coordinates (underneath the track/map)

can you make it possible for a user to edit the tags for their drop? If you own a drop you're able to now edit the drop's place information, and I think it should also be possible to edit the tags. To do this, I think you'll have to add the tagging stuff to the edit.html.erb and also probably the update method in the controller.

If point 3 proves to be too difficult/annoying, you can skip it. I know that it's important to each of you that you complete your individual features before the summer is up, so if that's the case just let me know & we can create a new issue for it.

@berlintam We just completed the tests and reintroduced the highcharts spec, so the PR might be ready to merge? ;) Or should we wait until the tag search is ready to merge, as it is a sub-branch of tagging?

awesome job!!! 🎆
This can totally be merged prior to the tag-search branch, in fact, it'll have to be merged before tag-search (otherwise things'll get messed up).
I can take a look at it this evening/tomorrow if that's cool?

We left the edit tags function for a later time, so @Powerglove will make an issue out of it :)


Image error when building

Hello, I have just started using this engine and I'm completely unsure of how to get the bmp spritesheets and tilesheets working. I'm assuming it has something to do with how the image is saved, as I got 2 different errors from multiple attempts.
When exporting 24-bit or 256 color from Paint or Paint.net:
lua: build.lua:196: bad argument #2 to 'pack' (unsigned overflow)
stack traceback:
        [C]: in function 'string.pack'
        build.lua:196: in function 'write_tile'
        build.lua:285: in function 'convert_tileset'
        build.lua:380: in main chunk
        [C]: in ?

When converting and exporting 24-bit from Usenti:
lua: build.lua:263: attempt to index a nil value (local 'img')
stack traceback:
        build.lua:263: in function 'convert_tileset'
        build.lua:380: in main chunk
        [C]: in ?

Tell me if more info is needed.

Sorry! As you noticed, I was not handling the errors from the image library correctly! Thanks for letting me know, I created a new release tag and patched the build script.
https://github.com/evanbowman/BPCore-Engine/commit/666a1ee97ebd89496cd64e87593c37be40e7c4a8
Some further tips:
This gba engine supports 16 color graphics. The gba hardware supports either 16 color or 256 color, and I chose 16 color because 256 color graphics use twice as much video ram, i.e. half as many sprite images. The gba hardware treats one of the color indices as a transparent color. In the build script, I hard-coded RGB(255, 0, 255) as the transparency color. See here and here
I can make the transparency color channel parameterizable when I have some free time, see those two links in the meantime if you want to change the default transparency color.


vdk-core: replace hook in connection built-in plugin

https://github.com/vmware/versatile-data-kit/blob/82756aea42c260ab23f03cbfbda6769bbcf98ae8/projects/vdk-core/src/vdk/internal/builtin_plugins/connection/connection_plugin.py#L25

This should be part of: https://github.com/orgs/vmware/projects/35/views/1?sliceBy[value]=Multiple+Databases+In+One+Job&pane=issue&itemId=56756213

Closing in favor of https://github.com/vmware/versatile-data-kit/issues/3164


Property to set version no longer works without extra quotes

Description
Previously used this snippet:
entity=${entity_prefix}-cust-gw
id=$(az network application-gateway show --resource-group $res_group --name ${entity} | jq -r '.id')
az resource update --verbose \
    --id $id \
    --set properties.webApplicationFirewallConfiguration.enabled=true \
    --set properties.webApplicationFirewallConfiguration.firewallMode=$waf_mode_customer \
    --set properties.webApplicationFirewallConfiguration.ruleSetType=OWASP \
    --set properties.webApplicationFirewallConfiguration.ruleSetVersion=3.0 \
    --set<EMAIL_ADDRESS>&

Sometime recently (past few weeks/month) this stopped working, and I now have to use:
   --set properties.webApplicationFirewallConfiguration.ruleSetVersion="'3.0'" \
(note the hard embedded quotes) or else I get this error:
RuleSetVersion '3' is unsupported for specified RuleSetType 'OWASP' for Application Gateway Firewall in context 'properties.webApplicationFirewallConfiguration'.
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: Nightly snapshot - updated to latest before reporting.
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:
azure-cli (2.0.8+1.dev20170614)
OS Version: What OS and version are you using?
Answer here: ub16.04lts x64
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here:
bash

This likely occurs because ruleSetVersion is a string and the way you were specifying it likely resulted in it being interpreted as an int.
However, is there a reason you aren't just using the az network application-gateway waf-config set command?

How do you set the ruleset version and/or enabled rules with waf-config set? If there is a better way to do the above, I'm open to it.

Command
    az network application-gateway waf-config set: Update the firewall configuration of a web
    application.

Arguments
    --enabled   [Required]: Specify whether the application firewall is enabled.  Allowed values:
                            false, true.
    --disabled-rule-groups: Space separated list of rule groups to disable. This disables the entire
                            group. To disable specifc rules, use '--disabled-rule-ids'.  Values
                            from: az application-gateway waf-config list-rule-sets.
    --disabled-rules      : Space separated list of rule IDs to disable.  Values from: az
                            application-gateway waf-config list-rule-sets.
    --firewall-mode       : Web application firewall mode.  Allowed values: Detection, Prevention.
                            Default: Detection.
    --no-wait             : Do not wait for the long running operation to finish.
    --rule-set-type       : Rule set type.  Default: OWASP.  Values from: az application-gateway
                            waf-config list-rule-sets.
    --rule-set-version    : Rule set version.  Values from: az application-gateway waf-config list-
                            rule-sets.

You would set the rule set type and version and then any disabled rules (or rule groups)

Ah, multiple terminals, and not all of them have the latest az version so didn't see the new options in the one I mistakenly checked with. You can close this if desired - above is clearly a better solution. :)


Refractor

Since development has led to some new ideas of handling things, a major refractor of Component names and functions is needed.

MAJOR refactoring is needed, especially in styles.js.

Changed AddStockItem.js to SearchResultItem.js. Still need to refractor the names in style.js.


Refactor header-cards component to use embedded snippet

Some refactoring of our "header-cards" and footer embedded snippets.

@bebatut I'm not sure who should review this, but would you be able to make me a maintainer to this repo so I can review and merge Galaxy Lab PRs?


Treemap bounding box size is faulty

Treemap: bounding box does not have same size as underlying box in treemap (1 or 2 pixels difference).
reported at the jit github project: https://github.com/philogb/jit/issues/64
Original issue by @bmesuere on Thu May 17 2012 at 18:42.
Closed by @bmesuere on Mon Nov 10 2014 at 14:14.

Twitter seems to have the same problem in their use of the treemap. Bugreport submitted at https://github.com/twitter/hdfs-du/issues/2
Original comment by @bmesuere on Thu Aug 09 2012 at 10:08.


Update percentage-columns-layout example.

c0dec0497b1aae87f27ca91617bf8d5934809963 changed percentage columns layout to accept an item count instead of the array of items. This updates the example in README.md to match the implementation.

Thanks. Meant to go back and fix this. Had a few PRs going at once :). This looks good 👍

Thanks!


[bug] pouch pull can't be run by using exec package

Issue Description
When call pouch pull in go package exec, it will panic.
Describe what happened:
pouch_cli_create_test.go:28:
    RunCmd(c, &cmd)
lib_common.go:108:
    c.Assert(ret.ExitCode, check.Equals, 0,
        check.Commentf("[FAIL]: CMD[%s %s] return %d,\n"+
            "Stdout: %s\n Stderr: %s",
            cmd.binary, cmd.args, ret.ExitCode, ret.Stdout(), ret.Stderr()))
... obtained int = 2
... expected int = 0
... [FAIL]: CMD[/usr/local/bin/pouch [pull registry.hub.docker.com/library/busybox:latest]] return 2,
Stdout:
 Stderr: panic: provided file is not a console

goroutine 1 [running]:
github.com/alibaba/pouch/vendor/github.com/containerd/console.Current(0xc420288000, 0x0)
	/home/sit/letty/src/github.com/alibaba/pouch/vendor/github.com/containerd/console/console.go:51 +0x71
github.com/alibaba/pouch/vendor/github.com/containerd/containerd/progress.(*Writer).Flush(0xc420288000, 0x0, 0x0)
	/home/sit/letty/src/github.com/alibaba/pouch/vendor/github.com/containerd/containerd/progress/writer.go:49 +0x5e
main.renderOutput(0x13aecc0, 0xc4203a6100, 0xc4203a6100, 0x7ffd71d9c538)
	/home/sit/letty/src/github.com/alibaba/pouch/cli/pull.go:93 +0x1ef
main.(*PullCommand).runPull(0xc42043dd00, 0xc420400100, 0x1, 0x1, 0x0, 0x0)
	/home/sit/letty/src/github.com/alibaba/pouch/cli/pull.go:64 +0x231
main.(*PullCommand).Init.func1(0xc42020fb00, 0xc420400100, 0x1, 0x1, 0x0, 0x0)
	/home/sit/letty/src/github.com/alibaba/pouch/cli/pull.go:38 +0x48
github.com/alibaba/pouch/vendor/github.com/spf13/cobra.(*Command).execute(0xc42020fb00, 0xc4204000c0, 0x1, 0x1, 0xc42020fb00, 0xc4204000c0)
	/home/sit/letty/src/github.com/alibaba/pouch/vendor/github.com/spf13/cobra/command.go:742 +0x49b
github.com/alibaba/pouch/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc42020f680, 0xc420549ed0, 0x1, 0x1)
	/home/sit/letty/src/github.com/alibaba/pouch/vendor/github.com/spf13/cobra/command.go:827 +0x30e
github.com/alibaba/pouch/vendor/github.com/spf13/cobra.(*Command).Execute(0xc42020f680, 0x1, 0xc420400050)
	/home/sit/letty/src/github.com/alibaba/pouch/vendor/github.com/spf13/cobra/command.go:780 +0x2b
main.(*Cli).Run(0xc420123560, 0x13ae800, 0xc42043dcf0)
	/home/sit/letty/src/github.com/alibaba/pouch/cli/cli.go:78 +0x2f
main.main()
	/home/sit/letty/src/github.com/alibaba/pouch/cli/main.go:34 +0x560

Describe what you expected to happen:
How to reproduce it (as minimally and precisely as possible):
1.
2.
3.
Anything else we need to know?:
Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

I will fix it, I think I know the reason for the panic.

this is because "pouch pull" not run in a console.  We depend on containerd's progress to implement the "pull" command, I find that the containerd's progress can work in a console only, not work via exec.
https://github.com/containerd/containerd/blob/master/progress/writer.go#L49 。
I think I will find a way to fix it.

Yes. I comment the fw.Flush() for local test. I'm curious about CI.
I think we should wrap the output and do some thing if the stdout is not pty/tty.


Piwik scripts added

Can you add the origin (link to piwik web site) of the script as a comment?

Hey @tjeerdijk
You can find the script here https://openms-web.piwik.pro/administration/apps/0f3e8416-7bda-4028-9f2e-3f1057cdb2f7/installation/sites


Document onMentioned emitter

Hello!
Thanks for putting together this wrapper for TributeJS. I've been using it recently, and today realised that it would be really useful if I could subscribe to an EventEmitter which emits when a mention is added.
...It turns out that this already exists, but isn't in the documentation. I only happened to noticeit whilst looking at the library source.
Thanks again 🙌

Thanks for pointing that out. Docs updated :)


ddev debug test may have conflicts when running sequentially (and ddev debug testcleanup have no effect)

Is there an existing issue for this?

[X] I have searched the existing issues

From Discord:
https://discord.com/channels/664580571770388500/1230114214182522922/1230114214182522922
Output of ddev debug test
Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior
Each ddev debug test should succeed.
Actual Behavior
...
Configuring a 'php' project with docroot 'web' at /home/stas/code/ddev/tryddevproject-5008/web
could not write DDEV config file /home/stas/code/ddev/tryddevproject-5008/.ddev/config.yaml: host port 60001 has already been allocated to project tryddevproject-27049
...

Steps To Reproduce
Run ddev debug test
Abort the test before ddev stop --unlist:
======== Thanks for running the diagnostic! ========
Running ddev launch in 3 seconds
Running ddev launch
Waiting 10 seconds to run ddev stop --unlist
^C

Run ddev debug test again, see an error
Anything else?
Maybe it is better to add ddev debug testcleanup at script start and script end, because when you run ddev stop --unlist, the test project cannot be removed with cleanup command.

I actually removed the cleanup function in this last round, so that's the direct cause of this. The reason for removal was that it prevented debugging the existing problem site. But obviously needs to be looked at again.
A side-note is that when ddev debug test is working it cleans up after itself now and makes ddev debug testcleanup obsolete.

host port 60001 has already been allocated to project

I wonder what's up with that, because we don't allocate ports normally for one of these. This may be a docker failure?

host port 60001 has already been allocated to project

It is hard-coded...
https://github.com/ddev/ddev/blob/56087f9f8f87ba2df0cd91b7cfec8af65df6c577/cmd/ddev/cmd/scripts/test_ddev.sh#L68

A side-note is that when ddev debug test is working it cleans up after itself now and makes ddev debug testcleanup obsolete.

No, the only thing it does is ddev stop --unlist, and that's it.

There were so many changes, I simply didn't notice these on review.

It is hard-coded...

I have no idea why I did that.

No, the only thing it does is ddev stop --unlist, and that's it.

That cleans up everything except an empty database, but you're right.


Use Ingress as an alternative to Route

Is your feature request related to a problem? Please describe.
The Helm Chart creates a Route resource to expose the application outside of the OpenShift cluster.
However this is an OpenShift-only resource and must be disabled when the chart is installed on another type of Kubernetes clusters.
The Helm Chart should allow to configure an Ingress instead of a Route for such case.
Describe the solution you'd like
Add new fields under deploy.ingress to configure an Ingress resource. This section should be mutually exclusive with the deploy.route fields.
We can add:

deploy.ingress.enabled -> enables Ingress (false by default)
deploy.ingress.hostname -> specifies the host (wildfly.local by default?)
deploy.ingress.path -> specifies the path in the rules (/ by default)

The generated resource would look like something similar to:
kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  name: <app name>
spec:
  rules:
    - host: <deploy.ingress.hostname (wildfly.local by default) >
       http:
        paths:
          - path: <deploy.ingress.path (/ by default) >
            pathType: Prefix
            backend:
              service:
                name: <app name>
                port:
                  number: 8080

There would be more tweaks related to Kubernetes vs OpenShift.
Shouldn't we detect the environment type automatically and perform those tweaks behind scenes? Users would be able to use the same Helm Chart configuration independently of the cluster; if it is running on OpenShift, a route would be created and, if it is running on Kubernetes, then an ingress, and the same for other related configurations. Not sure if that's possible, if not, maybe the user should be able to choose between the mode (Kubernetes/OpenShift) so they have to know only one configuration and the helm chart will work properly upon it.

When the app is deploy on OpenShift, it's valid to deploy it with an Ingress only (and OpenShift would automatically generate a Route for that ingress).
Please note that helm lookup allows to lookup if resource or kinds exists (https://helm.sh/docs/chart_template_guide/functions_and_pipelines/#using-the-lookup-function).  We could lookup if the Route kind exists before creating the resource.
I'm not sure on how to let users determines the configuration vs. using helm lookup to infer which resources should be created on the container platform target.


Forms-5839 datalayer wiki + schema validation testcases + refactoring getTitle function

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

resolved conflict with branch: dev

@rismehta , there are still unresolved review comments in this PR. Lets ensure to make sure that all review comments alre closed prior to merging.

@sauraku , please raise another PR for removing the wiki and creating it via github wiki.


there is a bug in this framework after the updates i.e. macOS 11.1 and iOS 14.3  Previously it was working fine on 11.01 and 14.2. i had made an app which listen to change in network connection. it was supposed to yell "network disconnected" whenever wifi is turned off instead it is doing opposite. when i turn on wifi it is yelling "network disconnected", on the other hand it is yelling network connected whenever i turn off wifi.

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.
Per our *CONTRIBUTING guidelines, we use GitHub for
bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag alamofire.
Please remove this line and everything above it before submitting.

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
ℹ Please replace this with what you did.
What did you expect to happen?
ℹ Please replace this with what you expected to happen.
What happened instead?
ℹ Please replace this with of what happened instead.
Alamofire Environment
Alamofire version:
Xcode version:
Swift version:
Platform(s) running Alamofire:
macOS version running Xcode:
Demo Project
ℹ Please link to or upload a project we can download that reproduces the issue.

d


Why is this noisy data generated?

This script generates noisy data?
https://github.com/jayaram-r/adversarial-detection/blob/master/expts/generate_noisy_data.py
Why is this done?
For which defenses is that useful?

It is used by the 'deep mahalanobis' and 'local intrinsic dimensionality' based defense methods. See this script detection_main.py on the following lines: 470 and 611.

The script generate_noisy_data.py has to be run prior to running the defense methods in order to generate the noisy data.

Thanks


Inclusion of donor information to be shown on donor portal side of aid package details

**The rationale behind this functionality is that the system helps prevent DUPLICATION of fulfillment of the need. We need to log all aid packages, even those not donated/fulfilled by the Red Cross to provide greater transparency and show the global community that the need is not being duplicated, and money is not being wasted. The Red Cross will invite these organizations to use the system using separate admin credentials. **

[ ] Inclusion of "Created by" information to be entered in on the admin portal side, and shown on donor portal side of aid package details. The Created by field should be located UNDER the title, and ABOVE the description of the aid package.

The login credential should select the "Created by" information automatically. E.g. If an aid package is "created by" the Sri Lankan Physicians of North America, when someone from that organization logs in, the admin portal should auto select this detail when they create an aid package.
Similarly, when a Red Cross admin creates an aid package, "created by" should automatically state "Red Cross".

The user from e.g. the Sri Lankan Physicians of North America should be able to:

provide an organization email to the Red Cross/LSF and obtain admin credentials
upload supplier information when e.g. the supplier name is not in the system.
create aid packages of medicines and medical supplies and record the beneficiary details.
provide details on the status of the aid packages.

hold on this. getting clarity from business stakeholders.

@NipunaMarcus do we need to reassign this issue?

@ayeshLK I merged and rolled out the changes, I am seeing following error in donor dev portal:
Error while executing SQL query: SELECT AID_PACKAGE.PACKAGEID, NAME, DESCRIPTION,
                                                                    AID_PACKAGE.STATUS, AID_PACKAGE.CREATEDBY as 'createdBy', PLEDGE.AMOUNT
                                                                    FROM AID_PACKAGE INNER JOIN PLEDGE
                                                                        ON AID_PACKAGE.PACKAGEID = PLEDGE.PACKAGEID
                                                                    WHERE AID_PACKAGE.STATUS!= ?  AND DONORID= ? . Column 'DONORID' in where clause is ambiguous.

Fixed above. @dinuka-rp frontend part can be started now.

@manuranga @ayeshLK thanks,
Was the existing API of GET aidpackage details updated to send the required info?


ci: run docker push

Automatically run docker push on main push, updating the images.
This will require running bazel.

Done.


Linear gradient on right side of file tab

Issue Type: Bug
It's affecting the display of the file name. The end looks cut off.

VS Code version: Code - Insiders 1.25.0-insider (11b0f3a40be055e02b721abbb93cb0012818f99e, 2018-06-14T05:11:13.121Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 2

Memory (System)
16.00GB (0.34GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_6260216

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

markdown-emoji
bie
0.0.7

markdown-preview-github-styles
bie
0.1.2

gitlens
eam
8.3.5

tslint
eg2
1.0.32

vsc-material-theme
Equ
2.1.0

prettier-vscode
esb
1.5.0

theme-monokai-pro-vscode
mon
1.1.8

vscode-scss
mrm
0.6.2

debugger-for-chrome
msj
4.6.0

vetur
oct
0.12.5

vscode-proun
oct
0.0.1

polacode
pnp
0.2.2

vscode-sort-json
ric
1.11.0

vscode-csstree
sme
0.7.0

language-stylus
sys
1.9.2

vim
vsc
0.12.0

(2 theme extensions excluded)

This gradient serves as a good indication when the text is longer than the space. FF's tabs have fixed width so it's good. For us our tabs expand on title length so I don't think we should do the same thing.

@bpasero I asked for opinions at Redmond. Some of us don't like it and would like an option to turn it off, if it'll be added by default. When the horizontal space is enough and the tab title is not shortened, this gradient is misleading.

@octref the gradient shadow should only appear when the space available for the label is not enough, anything else is something I would like to understand more how it happens.
The alternative of using a shadow is what we had before where labels would simply be cropped, which I am not a big fan of:

@octref I did some fixes in this area, can you still reproduce running "out of sources". What you show in the screenshots is definitely a bug.

@bpasero Looking much better from source. Thanks for the fix!