compose: Disable message and start new conversation buttons.

Implemented functionality to disable the 'Message' and 'Start new conversation' buttons when a user lacks posting permissions in the current stream context. Added tooltips for these disabled buttons, matching the behavior of the 'Send' button.
Fixes: #28410

Screenshots and screen captures:
When the user does not have posting permissions in Stream.

When the user does have posting permissions in Stream.

DM's

Self-review checklist

[X] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[X] Explains differences from previous plans (e.g., issue description).
[X] Highlights technical choices and bugs encountered.
[X] Calls out remaining decisions and concerns.
[X] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[X] Each commit is a coherent idea.
[X] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[X] Visual appearance of the changes.
[X] Responsiveness and internationalization.
[X] Strings and tooltips.
[X] End-to-end functionality of buttons, interactions and flows.
[X] Corner cases, error conditions, and easily imagined bugs.

@akarsh-jain-790 As per the PR template, please include screenshots of your changes (including tooltips) for review.

@akarsh-jain-790 As per the PR template, please include screenshots of your changes (including tooltips) for review.

@alya I have updated the PR description, you can re-review now.

Thanks! The issue doesn't say anything about making changes in a DM context -- only changes in a stream context were requested. Did you make changes for DMs as well? I can't quite tell from the PR description.

We don't want to disable the "Start new conversation" button for DMs, I think, as it would make it quite difficult to start a DM with a bot or with yourself.

These changes are not correct. If I open the compose box in a stream where I don't have post permissions, and change the destination where the message is being sent, the UI continues to indicate that I don't have permissions. This even happens with the "New direct message" button from such a stream.

Additionally, there is a clear vertical alignment issue with the disabled Start new conversation button.

Please test your changes thoroughly before asking for another round of review. Requesting review for a PR with bugs you could have easily found yourself wastes valuable reviewer time and slows down the progress of the project as a whole.

Hi @alya ,
Apologies for the oversight in the previous changes. I've thoroughly tested the modifications now and identified and resolved the issues.
I appreciate your time. Please review the updated changes, and let me know if any further adjustments are needed.

Also while working on this issue, I encountered an unexpected bug. When direct messages are not permitted, the tooltip over the "compose_reply_button" is not displayed. However, upon switching to any stream, the tooltip suddenly appears, indicating that direct messages are not allowed. I've attached a screencapture and screenshots for your reference.

https://github.com/zulip/zulip/assets/72064462/6b9f0ae9-cebb-4598-a7d7-45707ca407f2

Thanks! please post updated screenshots of all your changes in the PR description, including light theme and dark theme, and showing the tooltips.

Thanks for flagging the tooltip issue! Would you be up for posting your bug report in the #issues stream the development community?

Thanks! please post updated screenshots of all your changes in the PR description, including light theme and dark theme, and showing the tooltips.

I have updated the PR description.

Thanks for flagging the tooltip issue! Would you be up for posting your bug report in the #issues stream the development community?

Sure, I'll post in the #issues stream.

@terpimost Do we have designs for the disabled versions of compose box buttons? The colors in the screenshots above, especially for disabling "Start new conversation",  don't look great to me.

Hey @alya @terpimost, just checking in!  Been a while – any updates?

I didn't design any special state for disabled buttons, thinking that by default 0.5 opacity of the normal state is appropriate approach:

Please make buttons user-select: none; at all times. And for disabled button please make cursor: default

Hey @terpimost,
Thanks for your input. I've implemented your suggested changes and updated the PR description. Let me know if there's anything else you'd like me to adjust or if you have any further feedback!

Thanks! I tested the PR again, and the button does not get disabled as it should be in a search view or in All messages. Whether it's disabled should depend on the compose box state, not on what messages you're viewing.

Thanks! I tested the PR again, and the button does not get disabled when it should be in a search view or in All messages. Whether it's disabled should depend on the compose box state, not on what messages you're viewing.

@alya I have updated the PR, you can review now.

Sure, I can take another look when tests pass.

Sure, I can take another look when tests pass.

@alya Fixed the tests.

We should show the no permissions tooltip here, no the regular tooltip:

Otherwise looks good to me in manual testing.

Otherwise looks good to me in manual testing.

I apologize for the oversight while resolving the merge conflicts. I've now fixed the issue and made all the necessary changes.

Thanks! @N-Shar-ma are you up for reviewing this one? I haven't retested after the latest update.

@akarsh-jain-790 On hovering over the Start new conversation button when it's disabled, I expect but don't see a not-allowed style cursor. Once you fix this, I'll move onto reviewing the code

@akarsh-jain-790 Do you plan to continue this work, or would it make sense for @N-Shar-ma to take over from here?

I didn't design any special state for disabled buttons, thinking that by default 0.5 opacity of the normal state is appropriate approach:

Please make buttons `user-select: none;` at all times. And for disabled button please make `cursor: default `

@N-Shar-ma Thanks for pointing this out. Actually, terpimost originally suggested making disabled buttons have a default cursor style.

@akarsh-jain-790 Do you plan to continue this work, or would it make sense for @N-Shar-ma to take over from here?

Sorry, I took a bit of a break from development recently after GSOC results, but now ready to jump back in.

Welcome back!

Actually, terpimost originally suggested making disabled buttons have a default cursor style.

Oh okay. However, we still continue to have the not allowed cursor for disabled elements everywhere else, even the "Message ..." button right beside this "Start new conversation", which makes it seem odd. Just flagging this in case it's a concern (FYI @alya)
Another concern while testing this is that the tooltip on a disabled "Start new conversation" button appears instantly, and not with the usual delay

@terpimost Why did you suggest "And for disabled button please make cursor: default" here? Are you proposing that for all the close compose box buttons when they are disabled?

@terpimost just bringing your attention to the question posed in the last comment
@akarsh-jain-790 are you working on adding the expected delay to the disabled tooltip?

@terpimost just bringing your attention to the question posed in the last comment
@akarsh-jain-790 are you working on adding the expected delay to the disabled tooltip?

Yes, waiting on @terpimost response on the cursor style. Then I'll push the code with the expected delay for the tooltip.

OK, @akarsh-jain-790 , let's leave the disabled cursor for the button on this PR. We should have a separate design discussion / issue for changing all the cursors.

@N-Shar-ma  I've pushed the code with the expected delay for the disabled tooltip.

@akarsh-jain-790 Please also change the cursor for the "Start new conversation" to look disabled. The delay works fine now!

@akarsh-jain-790 is this ready for another look from @N-Shar-ma ?

He did inform me that this is ready via DMs, it's me who needs to get around to reviewing the code now


GD-104: Add support for snapshot testing

Is your feature request related to a problem? Please describe.
On a stable version i expect always the same data output for a certain function.
It would be nice to have a snapshot of produced data to be used to compare by each test run.
The snapshot data should be generated during the first test iteration and saved automatically.
Describe the solution you'd like
The API should provide functionality to create/delete snapshot data during test execution.

create a snapshot on first test run

the snapshot should be auto created and managed by the API

use existing snapshot on each next test run

no extra arguments should be need, the snapshot should be autoloaded identified by test suite and test case
allow to customize snapshot by override temporary the snapshot data

if the current data differs from the snapshot data the test should fail with an error report.
allow to manage snapshots

recreate by a precondition
delete by a precondition
auto delete unused snapshots (deleted test cases)

Describe alternatives you've considered
The alternatives would be to manage this kind of snapshot data manually.
Additional context
GdUnitSnapShotAssert
# An assertion tool to verify <data> against existing snapshot data
# If no snapshot data exist it will be created on first usage
assert_snapshot( data : {object | dictionary | array | json | image}) : GdUnitSnapShotAssert

# Verifies the current value against an existing snapshot for equality. If no snapshot exists, it is created and used on the next test cycle.
func is_equal() -> GdUnitSnapShotAssert:

# Modifies an existing snapshot before it is used for comparison. The change is not saved and is purely temporary in this context. Only existing key-value pairs are overwritten, unmatched keys are ignored and reported as warnings.
func modify(<Dictionary | json>) -> GdUnitSnapShotAssert:

# Allows to exclude values from snapshots by key from comparison.
func exclude({Dictionary | json}) -> GdUnitSnapShotAssert:

# Overrides an existing snapshot, the snapshot will be persist. It is only useable in combination with modify()
func override() -> GdUnitSnapShotAssert:

# Deletes an existing snapshot. This can be used to manually delete a snapshot for some reasons, by default snapshots will be managed by GdUnit
func delete() -> GdUnitSnapShotAssert:

# Allows to reset a snapshot. The snapshot will be recreated from current value.
func reset() -> GdUnitSnapShotAssert:

image snapshot
# Builds a snapshot from current screen as Image. You can specify optional a region by the <rect> argument
func screen_snapshot(<Rect>) -> Image:

put on the ice box, no real need yet


Update documentation for "user flow for self-service sign-up" for Entra ID tenants of type 'customer'

The documentation clearly describes how to enable users to sign-in/sign-up using their microsoft account to your directory. If your Entra ID tenant is of type 'workforce'. Which, to my understanding, is the type you'll be using for accounts internal to your company.
I would like to use Entra ID with tenant type 'customer'. And I would like the end customer be able to sign-in/sign-up using their private microsoft/outlook account to login to apps we're building. There is no clear documentation on this.

The documentation says I need to enable self-service sign-up, in order to use the Microsoft account in a user flow. This is possible when the entra ID tenant type is workforce, but not when it's customer!
External collaboration settings for type 'workforce':

External user flow creation for type 'workforce':

External collaboration settings for type 'customer' (note the lack of enabling self-service!):

External user flow creation for type 'customer':

Registered identity providers for type 'customer':

How to enable Microsoft account for entra ID tenant type customer? Please expand documentation on this.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2c05d9cd-275d-4585-f25f-fa5b88f1ec10
Version Independent ID: a3d263e6-20a6-9cea-f60c-a9f772a7f444
Content: Add a self-service sign-up user flow - Microsoft Entra
Content: Add Microsoft account (MSA) as an identity provider - Microsoft Entra
Content Source: articles/active-directory/external-identities/self-service-sign-up-user-flow.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

Update: perhaps this feature is not yet implemented for type customer (please add to documentation if it is so). Because when I use the menu from Entra admin then I see the following screen:

However, when I follow the route via 'user settings' (as described in the docs), I get this result:

Is this is a bug or am I just confused?

@msmimart
Can you please check and add your comments on this doc update request as applicable.

Hi @sethsnel, please find the documentation for Microsoft Entra ID for customer tenants here: https://learn.microsoft.com/en-us/azure/active-directory/external-identities/customers/overview-customers-ciam. You're correct that External Collaboration Settings apply to workforce tenants. Under the How-to guides section you can find info for creating a sign-up and sign-in user flow for customers.  I hope this helps. Thanks again!

@msmimart Thanks for looking into this!
The link to the documentation describing the configuration for customer tenants is very felpfull. It would be nice if azure documentation clear mentions whether it is applicable to either Workforce or Customer tenants!
One more question though, as the main cause for me reaching out via this gh issue is confederation with Microsoft personal account. The second link you've provided do mention federating with either Google or Facebook. But it doesn't mention how to configure federation with Microsoft/Outlook personal accounts as social sign-in/up. Do you have documentation on this?

@sethsnel Yes, you can configure federation with Microsoft/Outlook personal accounts as social sign-in/up. You can follow the steps mentioned in the following documentation to configure this:
https://docs.microsoft.com/en-us/azure/active-directory/external-identities/customers/how-to-user-flow-sign-up-sign-in-customers#configure-microsoft-as-a-social-identity-provider
This documentation provides step-by-step instructions on how to configure Microsoft as a social identity provider for your user flow. It also includes information on how to customize the user experience and collect additional user attributes during sign-up.

@SaibabaBalapur-MSFT The documentation you referenced does indeed explain how to add a user flow for login/signup and how to add social provider and/or custom attributes.
It does not explain, however, why I'm able to select Microsoft social provider during the creation of a user flow when my entra tenant is of type workforce. Whilst I'm not able to select Microsoft social provider when my Entra tenant is of type customer.
Please  closely review the screenshots I've attached in my initial post. (and notice the Microsoft social provider missing when Entra tenant type is customer, but available for workforce)
Is this either:

Me just not understanding the documentation/Entra ID?
A bug?
Not supported yet for type customer?

With this being the described discrepancy between Entra tenant type workforce vs customer.

@msmimart
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@sethsnel you're correct, the customer configuration is in preview and there are feature differences between customer and workforce tenants - please see this comparison chart. The auth methods and identity providers that are currently supported in a customer configuration are these:

Local account (Email and password)
Email one-time passcode
Google federation
Facebook federation

Thanks much for your feedback, it will help us clarify the documentation.

I'll close this issue for now, but let me know if you have any related questions. Thanks again! #please-close

Thanks for the clarification, I missed that article in the docs. I'll keep a watch on it for developments on the customer tenant!


CVE-2019-6250 - libzmq is vulnerable.

Description:
A pointer overflow, with code execution, was discovered in ZeroMQ libzmq (aka 0MQ) 4.2.x and 4.3.x before 4.3.1. A v2_decoder.cpp zmq::v2_decoder_t::size_ready integer overflow allows an authenticated attacker to overwrite an arbitrary amount of bytes beyond the bounds of a buffer, which can be leveraged to run arbitrary code on the target system. The memory layout allows the attacker to inject OS commands into a data structure located immediately after the problematic buffer (i.e., it is not necessary to use a typical buffer-overflow exploitation technique that changes the flow of control).
Exploit details
Now that msg_size_ has been set to a very high value, the attacker is allowed to send this amount of bytes, and libzmq will copy it to its internal buffer without any further checks.
This means that it's possible to write beyond the bounds of the allocated space.
However, for the exploit this is not necessary to corrupt memory beyond the buffer proper.
P.o.C
Remote code execution vulnerability #3351
how to fix it:
Update zmq to 4.3.1
libzmq 4.3.1
References:
CVE-2019-6250
Notes:
Please check, but do not act unethical, again.
other times. 1, 2

no need to thank, just continue with my work:
my smart address is:
SibkbBa63AeUHaEEqdodeKjZptHYSW4tRQ

Description:
A pointer overflow, with code execution, was discovered in ZeroMQ libzmq (aka 0MQ) 4.2.x and 4.3.x before 4.3.1. A v2_decoder.cpp zmq::v2_decoder_t::size_ready integer overflow allows an authenticated attacker to overwrite an arbitrary amount of bytes beyond the bounds of a buffer, which can be leveraged to run arbitrary code on the target system. The memory layout allows the attacker to inject OS commands into a data structure located immediately after the problematic buffer (i.e., it is not necessary to use a typical buffer-overflow exploitation technique that changes the flow of control).
Exploit details
Now that msg_size_ has been set to a very high value, the attacker is allowed to send this amount of bytes, and libzmq will copy it to its internal buffer without any further checks.
This means that it's possible to write beyond the bounds of the allocated space.
However, for the exploit this is not necessary to corrupt memory beyond the buffer proper.
P.o.C
Remote code execution vulnerability #3351
how to fix it:
Update zmq to 4.3.1
libzmq 4.3.1
References:
CVE-2019-6250
Notes:
Please check, but do not act unethical, again.
other times. 1, 2


rootless: fix joining namespaces with container:NAME and ns:PATH

Support joining existing namespaces with container:NAME and ns:PATH.
$ podman run --name foo --rm -it alpine nc -l -p 8080
$ echo hello | podman run --name foo --rm \
    -it --network container:foo alpine nc localhost 8080

Closes: https://github.com/containers/libpod/issues/1453

LGTM
@mheon @baude @umohnani8 @vrothberg @TomSweeneyRedHat PTAL

LGTM but would like a head nod from @mheon before merging.

@rh-atomic-bot r+


more cache hits for getMaxTickWidth

This PR:

removes withoutRecompute and always return cached version if exists
reuse addToCache and getFromCache instead of custom property
add call to resetCache when redraw is called.

This way we have  more cache hits and the cache is dropped each time we want to redraw the chart (thinking of resize etc.) which should be, hopefully, kind of same.

Codecov Report

Merging #2687 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   81.02%   81.03%   +0.01%
==========================================
  Files          59       59
  Lines        4633     4636       +3
==========================================
+ Hits         3754     3757       +3
  Misses        879      879

Impacted Files
Coverage Δ

src/core.js
90.74% <100%> (ø)
:arrow_up:

src/size.js
93.75% <100%> (ø)
:arrow_up:

src/axis.js
97.6% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb80e7...b5183d6. Read the comment docs.

Codecov Report

Merging #2687 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   81.02%   81.03%   +0.01%
==========================================
  Files          59       59
  Lines        4633     4636       +3
==========================================
+ Hits         3754     3757       +3
  Misses        879      879

Impacted Files
Coverage Δ

src/core.js
90.74% <100%> (ø)
:arrow_up:

src/size.js
93.75% <100%> (ø)
:arrow_up:

src/axis.js
97.6% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb80e7...b5183d6. Read the comment docs.


Consul DNS Package

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes
[x] Rebases cleanly onto the latest master

Fixes #1230

provisioned on top of 1.0.3 rc1 AWS cluster. installed cleanly, no problems so far

Looks like the build failed, but because Docker hub timed out on one cloud. The others worked fine. Should we consider that a green or retry it? @sehqlr

I would say retry it once.

Right, I'll rebase and then we can get this merged! :thumbsup:

As of right now, it would be a fast-forward merge. So we're good here.

lgtm, successfully tested on aws. automated digitalocean build failed due to unrelated problem


IE 8 chart not getting displayed

When i change the browser mode from ie 10 to ie8 the chart is not coming
I have included the excanvas.js in the html file

This appears to be fixed in the latest version. Please reopen if this can be confirmed broken in the latest version and a test case can be added.


Use custom Comunica config

Currently, the default Comunica config is being used,
which is fine, but may introduce some unneeded overhead.
I suggest to create a custom config (like we do in the jQuery widget),
so that unneeded modules can be excluded, such as the RDF and SPARQL serializers.
This will reduce the bundle size in browsers,
and will also make it easier to use the fetch-based HTTP actor
to enable the solid-auth-client to be used later on.

Done in #5.


Convert form-encoding body to model-based version.

Update the Multipart version as well to match some conventions.
Closes #2064.

This currently exposes the user-supplied String in the model API. We probably should behave more like HttpUrl.

LGTM
I think we might want to follow-up with handy map-like access to the parameters

Renamed to FormBody, encode on the way in, JIT decode on the way out, expose encoded accessors.


Correction for raw affiliation King's University College at Western University, London, Ontario, Canada

Correction needed for raw affiliation King's University College at Western University, London, Ontario, Canada
raw_affiliation_name: King's University College at Western University, London, Ontario, Canada
new_rors: ;02grkyz14
previous_rors: 048f5b183;02grkyz14
works_examples: W4377096773;W4390342238
contact: eab649d20a6ccc31232738424fbddfb1:3475f88275792fd1 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


Add --non-interactive flag which limits spinner output for non-interactive terminals (Ex: CI)

Description
CI or otherwise logged terminal sessions end up with a huge amount of output with stuff like Build Building sim-x86_64 which various number of dots. For non-interactive sessions this loading spinner isn't as useful and bloats the output.
References
N/A
Checklist

[ ] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

❤ Thanks for contributing to the 🏈 Rugby!

Please, rebase on actual main branch I fixed spelling there


Does the README need an update?

Today we stumbled upon the fact that the README claims you'd need to add the factory for the UrlHelper while it already get's added manually in here.
Since the mentioned UrlHelperFactory has been removed in PR #13 i guess this part can be removed?

The README no longer references the UrlHelper; closing.


Can't install CLI

I'm upgrading the CLI since the warning of unsupported kubernetes version.
The latest exe doesn't work. It start but nothing happens
I've uninstalled, the CLI the same happens if i try to install from scratch

@ciacco85 what OS are you using? Are you able to see any logs in the log folder ($TMPDIR/Azure Dev Spaces on Mac/Linux, %TEMP%/Azure Dev Spaces on Windows)?

Windows 10
Azure Dev Spaces.zip
All Errors come from the stdout of "azds up"
No sign of failed install log  #416

@ciacco85 Can you also share the logs files matching the pattern %TEMP%\Azure_Dev_Spaces_*.log to confirm the issue with installer?

@ciacco85 No need for further logs from you. We have found the issue and should release a fix soon.

@ciacco85 We fixed the CLI release. Could you please confirm it works for you as well? Thanks for reporting this issue!

New version is working fine
Azure Dev Spaces CLI 1.0.20201219.2 API v3.2


Configure owner of files in Ubuntu Bionic

In Ubuntu 18.04 /var/lib/snmp is owned by user Debian-snmp and group Debian-snmp instead of snmp:snmp used in former releases.

There must something wrong with you CI. I'm pretty sure my change has nothing to do with these fails.

I've got the same issue with my PR  #128  @razorsedge can you please help us ?

This module seems to have been orphaned, @razorsedge is active on github but not responding to anything to do with this module anymore.
Great shame!

This seems to be a duplicate of https://github.com/voxpupuli/puppet-snmp/pull/130, I'm closing it.


Fix import of validateVmName()

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1711136
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1711858

The bug evinced in production build only, development setting of webpack worked well.
Root-cause: copy&paste of code and lack of import/export.

Pull Request Test Coverage Report for Build 1626

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 84.002%

Totals

Change from base Build 1624:
-0.004%

Covered Lines:
3958

Relevant Lines:
4515

💛  - Coveralls


Bot unable to provide SS of target PC.

Describe the bug
Bot unable to send SS of PC (ss is selected in builder). When typed in any channel under the specific category, the message will send then be deleted with nothing else following.
To Reproduce
Run pysilon on a pc, go to host discord and type " .ss ".
Expected behavior
Host will type .ss in host discord server in respective channel to target pc, your " .ss " message will be deleted and nothing else will happen.
Screenshots
(impossible deletes right after sent)
Desktop (please complete the following information):

OS: [Windows 10]
Python Version: [e.g. 3.10.11]

Add me on discord: kebabislife420, I'll try to help you.

probably because if it's a laptop it's probably because the lid is closed or it's in sleep mode check if your bot is online or if an av has messed with it

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


Anisotropic filter doesn't work

Godot version:3.2.stable
OS/device including version:Ubuntu 20.04
GPU:Nvidia Geforce GTX 750Ti
Driver:nvidia-driver-460
GLES3
Issue description:Anisotropic texture filtering doesn't seem to work no matter the level used
Steps to reproduce:
Go to project settings, rendering quality, filters and change the settings.
Changing the filter level doesn't have any effect on the textures

Minimal reproduction project:
It seems to happen on all projects

I figured out that apparently you have to enable anisotropy when importing the textures otherwise it doesn't work. Closing the issue

I figured out that apparently you have to enable anisotropy when importing the textures otherwise it doesn't work. Closing the issue

This will be resolved by https://github.com/godotengine/godot/pull/37847 if it's merged.

This will be resolved by https://github.com/godotengine/godot/pull/37847 if it's merged.


Downloading Pretrained Model

Hi, I was trying to download the resnet101 pretrained model, but have been unable to do so from the Baidu link. Is there any other way I could get the pretrained model?

I have uploaded the pre-trained model to Google Cloud and updated the link.


Lera Tormashova

@LeraTormashova
Please, rename your Pull Request. Use this template – Laboratory work #1, Fedorov Makar - 19FPL1

Unfortunately, the deadline is not that far. Please, push changes so that we can review them.

Open another PR with the second lab


docs(RELEASE_TEMPLATE): clarify publishing steps

This improves the current publishing steps:

updates to latest blog publishing flow
simplifies getting started with the blog by using a tailored template

Squashed the changes via https://github.com/camunda/camunda-modeler/pull/3454/commits/026a7d79090035a88c11b1d173e7adb7a836e6b8.


Fix for models without rope_scaling config

Fix AtrtibuteError when accessing config.rope_scaling for models without this attribute.

in v1.15.0-release,

Already in main as it was cherry-picked from https://github.com/huggingface/optimum-habana/pull/1625


Update to Chromium 131.0.6778.69

This PR Updates to Chromium 131.0.6778.69.
Notes:

There were new additions to the extensions-manifestv2 patch for [588911] and [5870920]

The pruned-binaries patch had removals for [5894450] and new additions for [5739036]

The safebrowsing patch had changes for [5875189], [5878090], [5903969], and [5914754]

remove-unused-preferences-fields.patch had changes for [5913162], [5860535], and [5878090]

The close window with last tab patch had a section moved due to [5898348]

Due to [5915452] and the issue that necessitated #3081 I have moved the changes in add-flags-for-referrer-customization.patch from chrome/common to services/network/public/cpp so that now no longer requires any gn exemptions.

The first run page patch has been updated to use a webui config setup since that has finally been affected by the migrations in (40222519)

The remove ui patch had some changes for [5900076]

I've added a new upstream fix for the changes in [5922801].  They removed the glue_core_pools flag but didn't clean up everything.  I'm honestly not sure how they are building like this, but judging by the state of the tarball builder they may not be...

I've added a small change to the cloning script to checkout gn at the commit specified in the DEPS file rather than HEAD.  This should make things easier for some platform setups.

Change log
Blog post

Side-note:  The tarballs for 130 were delayed due to failures of tarball builds for 131.  The failure was fixed in 132, so as far as I can tell this means that there may not be any tarballs available at all for 131.

I already fixed that platform patch and I am waiting for compiling to complete.

@teeminus would you mind sharing the updated patch? Mine just blew out after 6h building :/

@Ahrotahn
I got the following linking error:
FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb
..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe "/OUT:./chrome.dll" /nologo -libpath:..\..\third_party\llvm-build\Release+Asserts\lib\clang\20\lib\windows "-libpath:../../../../../Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.39.33519/ATLMFC/lib/x64" "-libpath:../../../../../Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.39.33519/lib/x64" "-libpath:../../../../../Program Files (x86)/Windows Kits/10/lib/10.0.22621.0/ucrt/x64" "-libpath:../../../../../Program Files (x86)/Windows Kits/10/lib/10.0.22621.0/um/x64" /MACHINE:X64  "/IMPLIB:./chrome.dll.lib" /DLL "/PDB:./chrome.dll.pdb"<EMAIL_ADDRESS>lld-link: error: undefined symbol: public: __cdecl enterprise_connectors::ContentAnalysisDelegate::Data::Data(void)
>>> referenced by ../../chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
>>>               obj/chrome/browser/ui/tab_contents/impl/chrome_web_contents_view_handle_drop.obj

lld-link: error: undefined symbol: public: static bool __cdecl enterprise_connectors::ContentAnalysisDelegate::IsEnabled(class Profile *, class GURL, struct enterprise_connectors::ContentAnalysisDelegate::Data *, enum enterprise_connectors::AnalysisConnector)
>>> referenced by ../../chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
>>>               obj/chrome/browser/ui/tab_contents/impl/chrome_web_contents_view_handle_drop.obj

lld-link: error: undefined symbol: public: __cdecl enterprise_connectors::ContentAnalysisDelegate::Data::Data(struct enterprise_connectors::ContentAnalysisDelegate::Data &&)
>>> referenced by ../../chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
>>>               obj/chrome/browser/ui/tab_contents/impl/chrome_web_contents_view_handle_drop.obj

lld-link: error: undefined symbol: public: __cdecl enterprise_connectors::ContentAnalysisDelegate::Data::~Data(void)
>>> referenced by ../../chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
>>>               obj/chrome/browser/ui/tab_contents/impl/chrome_web_contents_view_handle_drop.obj

lld-link: error: undefined symbol: public: static void __cdecl enterprise_connectors::ContentAnalysisDelegate::CreateForWebContents(class content::WebContents *, struct enterprise_connectors::ContentAnalysisDelegate::Data, class base::OnceCallback<void __cdecl(struct enterprise_connectors::ContentAnalysisDelegate::Data const &, struct enterprise_connectors::ContentAnalysisDelegate::Result &)>, enum safe_browsing::DeepScanAccessPoint)
>>> referenced by ../../chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
>>>               obj/chrome/browser/ui/tab_contents/impl/chrome_web_contents_view_handle_drop.obj

I fixed it by excluding chrome_web_contents_view_handle_drop.cc from the list of files to compile but I am not quite sure if this is the correct approach or if my patch is correct/complete:
--- a/chrome/browser/ui/tab_contents/BUILD.gn
+++ b/chrome/browser/ui/tab_contents/BUILD.gn
@@ -50,7 +50,6 @@ source_set("impl") {
   if (is_win || is_mac || is_linux || is_chromeos) {
     sources += [
       "chrome_web_contents_menu_helper.cc",
-      "chrome_web_contents_view_handle_drop.cc",
     ]
   }

That's correct, we had that removed previously but [5903969] moved it and I forgot to add a removal for the the new location.  We had the header removed as well but I guess that wasn't necessary.
I'll update the PR with the change in a bit.

Problem solved, thank you very much 😃

@teeminus the update for windows-fix-building-without-safebrowsing.patch is still required?

Builds and runs fine on windows.

@teeminus the update for windows-fix-building-without-safebrowsing.patch is still required?

Yes, the patch needs to be updated. Iirc the patch does not apply completely because there are some minor changes in the source files which were straight forward to adapt.

Is the updated Windows patch available? I'm working on a build restoring some JS APIs and this piece is missing to complete M131 build for me.

I usually push my changes for for windows repo once the PR in this repo has been merged. Otherwise there would be an inconsistency as patches and submodule do not match.
In a few days, this PR will we merged. If that's to late I can push my changes without updating the submodule so you would have to manually replace it with the state of this PR.

I already have ungoogled-chromium and ungoogled-chromium-windows forked with the submodule in the Windows repo pointed to my fork. It would be appreciated if you could share the updated patch as Gist or just in a comment. 🙏🏻

clones, builds and runs fine for portable linux

@lofcz I pushed the patches for .69 to my update branch.

I'm seeing
ninja: error: '../../chrome/browser/resources/media/mei_preload/preloaded_data.pb', needed by 'phony/chrome/browser/resources/media/mei_preload/component_bundle', missing and no known rule to make it

when building for macOS.

It seems they added a new dependency for macOS in [5906628].  See if this change is all that's needed, if so then we should add that to disable-mei-preload.patch:
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1212,7 +1212,6 @@
       ":optimization_guide_library",
       ":swiftshader_binaries",
       ":widevine_cdm_library",
-      "//chrome/browser/resources/media/mei_preload:component_bundle",
       "//components/privacy_sandbox/privacy_sandbox_attestations/preload:component_bundle",
     ]

It seems they added a new dependency for macOS in [5906628]. See if this change is all that's needed, if so then we should add that to disable-mei-preload.patch:
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1212,7 +1212,6 @@
       ":optimization_guide_library",
       ":swiftshader_binaries",
       ":widevine_cdm_library",
-      "//chrome/browser/resources/media/mei_preload:component_bundle",
       "//components/privacy_sandbox/privacy_sandbox_attestations/preload:component_bundle",
     ]

Another error came up:
ninja: error: '../../components/privacy_sandbox/privacy_sandbox_attestations/preload/privacy-sandbox-attestations.dat', needed by 'phony/components/privacy_sandbox/privacy_sandbox_attestations/preload/component_bundle', missing and no known rule to make it

so I changed the patch to
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1212,8 +1212,6 @@ if (is_win) {
       ":optimization_guide_library",
       ":swiftshader_binaries",
       ":widevine_cdm_library",
-      "//chrome/browser/resources/media/mei_preload:component_bundle",
-      "//components/privacy_sandbox/privacy_sandbox_attestations/preload:component_bundle",
     ]

     if (is_chrome_branded) {

Currently building [18966/51341], will come back if have other issues.

It seems they added a new dependency for macOS in [5906628]. See if this change is all that's needed, if so then we should add that to disable-mei-preload.patch:
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1212,7 +1212,6 @@
       ":optimization_guide_library",
       ":swiftshader_binaries",
       ":widevine_cdm_library",
-      "//chrome/browser/resources/media/mei_preload:component_bundle",
       "//components/privacy_sandbox/privacy_sandbox_attestations/preload:component_bundle",
     ]

Another error came up:
ninja: error: '../../components/privacy_sandbox/privacy_sandbox_attestations/preload/privacy-sandbox-attestations.dat', needed by 'phony/components/privacy_sandbox/privacy_sandbox_attestations/preload/component_bundle', missing and no known rule to make it

so I changed the patch to
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1212,8 +1212,6 @@ if (is_win) {
       ":optimization_guide_library",
       ":swiftshader_binaries",
       ":widevine_cdm_library",
-      "//chrome/browser/resources/media/mei_preload:component_bundle",
-      "//components/privacy_sandbox/privacy_sandbox_attestations/preload:component_bundle",
     ]

     if (is_chrome_branded) {

Currently building [18966/51341], will come back if have other issues.

Can confirm that the change above (that removes two depedencies) is all changes needed to make it build on macOS (arm64). /cc @Ahrotahn

Good to know!  I guess the easiest route for now would be to include those changes as a platform patch.  Next time we do an update those changes should probably be moved into the disable-mei-preload and disable-privacy-sandbox patches in the core repo.

Another issue appeared on GitHub Action runner:
[10171/50939] OBJCXX obj/ui/events/events_base/keyboard_code_conversion_mac.o
FAILED: obj/ui/events/events_base/keyboard_code_conversion_mac.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/events/events_base/keyboard_code_conversion_mac.o.d -DEVENTS_BASE_IMPLEMENTATION -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_XCODE_VERSION=1501 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=6a68fd412b9aecd515a20a7cf84d11b598bfaf96 -DTEMP_REBUILD_HACK -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCR_CXX_INCLUDE=\"third_party/rust/chromium_crates_io/vendor/cxx-1.0.128/include/cxx.h\" -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n  -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-cast-function-type -Wno-thread-safety-reference-return -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -mllvm -inlinehint-threshold=360 -fwhole-program-vtables -fcomplete-member-pointers --target=x86_64-apple-macos -Wno-unknown-warning-option -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../../../Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -mmacos-version-min=11.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 -Wimplicit-retain-self -Wobjc-missing-property-synthesis -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fobjc-arc -fno-objc-arc-exceptions -fvisibility-inlines-hidden -c ../../ui/events/keycodes/keyboard_code_conversion_mac.mm -o obj/ui/events/events_base/keyboard_code_conversion_mac.o
../../ui/events/keycodes/keyboard_code_conversion_mac.mm:150:8: error: use of undeclared identifier 'kVK_ContextualMenu'
  150 |       {kVK_ContextualMenu, DomKey::CONTEXT_MENU},
      |        ^
1 error generated.

(ref. https://github.com/ungoogled-software/ungoogled-chromium-macos/actions/runs/11861115111/job/33059598542)
and it was not there when building locally...

It seems that kVK_ContextualMenu wasn't added until macOS 15, so you would either need to update the action to use a newer version or include a new patch that reverts the change in [5894764].

It seems that kVK_ContextualMenu wasn't added until macOS 15, so you would either need to update the action to use a newer version or include a new patch that reverts the change in [5894764].

Thanks for the information, I am super busy during these days, I'll take a closer look later.

I can't test this but __MAC_OS_X_VERSION_MAX_ALLOWED should be set to the version of the SDK you're building with.  So as an alternative, if you want to support older versions, you could handle the problem by adding a patch with something like this:
--- a/ui/events/keycodes/keyboard_code_conversion_mac.mm
+++ b/ui/events/keycodes/keyboard_code_conversion_mac.mm
@@ -48,6 +48,11 @@
   return base::IsValidCodepoint(c) && !base::IsUnicodeControl(c);
 }

+#if (__MAC_OS_X_VERSION_MAX_ALLOWED < 150000)
+constexpr int kVK_RightCommand = 0x36;
+constexpr int kVK_ContextualMenu = 0x6E;
+#endif
+
 bool IsKeypadOrNumericKeyEvent(NSEvent* event) {
   // Check that this is the type of event that has a keyCode.
   switch (event.type) {


Don't update ConfigMaps/Secrets if nothing has changed

ESO updates ConfigMaps and Secrets according to the refreshInterval in the ExternalSecret. While it is desired to check for changed secrets by this interval, it may not desired to actually modify the ConfigMap/Secret in K8S if nothing has changed in the secret source/store or the ExternalSecret. In fact at least the resourceVersion gets incremented on each update interval by ESO (tested with v0.8.1).
There are several processes which trigger a reload of their configuration or even restart pods on updates of their depending resources. And if they are not "smart" to detect actual changes in the data the frequent updates of the K8S objects can "stress" them. For example nginx ingress detects changes in referenced secrets for BasicAuth credentials and triggers a reload of its configuration even if the credentials haven't changed.
To avoid this stressful situation for depending workloads - and K8S in general - ConfigMaps and Secrets shouldn't be updated/touched if nothing has changed. This will significantly reduce "update pressure" in all K8S components.
So instead of updating the objects and increment the resourceVersion, the "reconcile.external-secrets.io/data-hash" annotation should be reconciled (as the name indicates ;-) ) and only if it is different, perform the update of the object. This should significantly improve the stability of the cluster when dealing with hundreds or thousands of ExternalSecrets with low refreshInterval setting.

I read the code a bit and maybe this is issue isn't a feature request but a bug. In https://github.com/external-secrets/external-secrets/blob/main/pkg/controllers/externalsecret/externalsecret_controller.go#L343 the comparison of the existing object and the new one should skip the update:
	if equality.Semantic.DeepEqual(existing, obj) {
		return nil
	}

So I think this comparison fails even if the actual data is equal.
Requires deeper investigation to understand why the objects are different or at least the method considers them as different.

Think I found the problem: We are using htpasswd in the secret template:
auth: '{{ htpasswd .basic_auth_username .basic_auth_password }}'

This generates always a new string which is different from the previous one. Therefore the comparison fails and the update of the secret is processed. Probably htpasswd should be avoided then.
Issue can be closed, maybe this helps someone else to identify issues.

@phoenix-bjoern thank you! My long time googling finally points to this issue, that helped me understand my exact problem.
I still this is bug in external-secrets and there should be a workaround for solve it. Because this is really nice that I can use supported htpasswd function in my templates.

@werwolfby actually I don't think it is possible to solve the problem in ESO. htpasswd returns a new string on every call. So the comparison of existing and newly generated secret will always trigger an update of the K8S secret. IMHO, although available in the string library, htpasswd should be omitted in ExternalSecrets - at least for frequent updates and/or in clusters with many secrets.

@phoenix-bjoern I agree with you. But if instead of compare secret data itself ESO could compare secrets and template string itself (by comparing hash for simplicity and for not storing secrets themself).
And this would solve the issue. As you did I didn't expect such behavior. As developer I understand why it happened and would implemented it in the same way on first implementation as most obvious solution. We didn't own this functions.
So as I proposed in my issue it could be solved. Or at least should be mentioned in docs, because removing it from supported funcs will be a breaking change. Thought it should be done initially, because it already removes few funcs:
func init() {
	sprigFuncs := sprig.TxtFuncMap()
	delete(sprigFuncs, "env")
	delete(sprigFuncs, "expandenv")

@werwolfby True, but then ESO would have to save hashes of the secrets and templates and AFAIK this is not the case. ESO uses its' CR and the K8S Secrets as "storage". So hashes of the values would have to be stored as annotations but that requires additional business logic just for that specific case...

@phoenix-bjoern to some degree this would be possible, but I think this would cause problems when reconciling. We're further discussing this specific issue in here https://github.com/external-secrets/external-secrets/issues/2699

@phoenix-bjoern hash already stored as annotation in target secrets: reconcile.external-secrets.io/data-hash. And it is used to find changes.


executeQuery toPromise never resolves but executeMutation does

pipe(client.executeQuery(....), toPromise) never resolves
pipe(client.executeMutation(...), toPromise) resolves as expected

toPromise converts a lazy stream to an eager promise. But since promises are defined for a single value and the completion of a stream, the toPromise operator waits for the last event.
So you'll also have to use the take operator to complete the stream immediately after the first value was emitted.
E.g.
import { pipe, take, toPromise } from 'wonka';

pipe(
  client.executeQuery(/*...*/),
  take(1),
  toPromise
)


Video Doorbell support - question

With video doorbell in HomeKit simulator is there anything comparable to create the same service composite of services: ip cam, doorbell, motion sensor? But something that will work eg doorbell does not work as a service on its own

Doesn't Doorbell service match your need?

Nope, that service doesn't really work with notifications - stopped working as a supported plugin a few months ago, needs to be part of a composite
I have a doorbird device which exposes all apis; for ip cam (rtsp stream), a doorbell, motion sensor and lock opening control (also night vision) it fits with the new video doorbell but I haven't seen this created as a service yet.
Would you consider the video doorbell as a type in the service library as seen in the HomeKit sim or doesn't fit?
I'm already combing plugins to provide the same thing but it's not as tight as the working one with supported doorbell service - had to use a motion service for the doorbell activation.
Also I don't benefit from two way intercom which you get with the new service.
Sent from my iPhone

On 17 Apr 2017, at 21:16, Khaos Tian<EMAIL_ADDRESS>wrote:
Doesn't Doorbell service match your need?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@brownad the components are already implemented here. For support for specific accessory, you will have to do add support using those components.

how to create _accessory.js for doorbell ?

Doorbell doesn't work for anyone that I've seen so not sure combing all of the implemented services works just yet - might be missing something ?
Sent from my iPhone

On 17 Apr 2017, at 21:30, Maxmudjon<EMAIL_ADDRESS>wrote:
how to create _accessory.js for doorbell ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@brownad Are you sure you implemented doorbell correctly? When someone press the doorbell, HomeKit expects accessory to send a ProgrammableSwitchEvent with value 0. Make sure you call the setValue or updateValue on the characteristic.

Yes I had it working for quite a while until iOS changed the rules it stopped working
Others reported the same
Sent from my iPhone

On 17 Apr 2017, at 21:35, Khaos Tian<EMAIL_ADDRESS>wrote:
@brownad Are you sure you implemented doorbell correctly? When someone press the doorbell, HomeKit expects accessory to send a ProgrammableSwitchEvent with value 0. Make sure you call the setValue or updateValue on the characteristic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

"until iOS changed the rules it stopped working", do you remember when is that? I can't remember this from happening and as long as simulator's doorbell works, doorbell service should still work here.

Approx February
Sent from my iPhone

On 17 Apr 2017, at 21:49, Khaos Tian<EMAIL_ADDRESS>wrote:
"until iOS changed the rules it stopped working", do you remember when is that? I can't remember this from happening and as long as simulator's doorbell works, doorbell service should still work here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

If you create a simple doorbell device it will show up as 'not supported' in iOS home app
Sent from my iPhone

On 17 Apr 2017, at 21:49, Khaos Tian<EMAIL_ADDRESS>wrote:
"until iOS changed the rules it stopped working", do you remember when is that? I can't remember this from happening and as long as simulator's doorbell works, doorbell service should still work here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Then I don't think it's related to iOS changes. iOS 10.2 was released on December 12, 2016 and iOS 10.3 was released on March 27, 2017. In between there is no way for Apple to change behavior of HomeKit.
For your "not supported" problem, Home app always show that if that's the only service an accessory has. If you add another service (err ... like a motion sensor service), that "not supported" tile should disappear. And here I think Home app did a terrible job showing that. Doorbell notification is displayed by HomeKit, not Home app. So even in case Home app shows "not supported", HomeKit should still show notification if a doorbell event happens.

i can create _accessory.js for doorbell ?

@Maxmudjon you can. Read the documentation here.

I do not know English well and it's difficult for me to create an accessory doorbell. Except the doorbell, all the accessories I created))

@Maxmudjon then what are you trying to do... I already pointed out all the resources you need to solve your problem, I can't write code for you.

FAN, GARAGE_DOOR_OPENER, LIGHTBULB, DOOR_LOCK, OUTLET, SWITCH, THERMOSTAT, SENSORS, ALARM_SYSTEM, DOOR, WINDOW, WINDOW_COVERING, PROGRAMMABLE_SWITCH

I already created these accessories

Only the doorbell is left

Ok makes sense what you said about combing with motion sensor, think it has same limitations in simulator. Thanks
Was approx about feb give or take a month but it was something that worked for a while then just stopped
Sent from my iPhone

On 17 Apr 2017, at 22:10, Maxmudjon<EMAIL_ADDRESS>wrote:
Only the doorbell is left
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Likely the doorbell was introduced before camera now it assumes to be a composite service with an ip camera thus a video doorbell is achieved. Standalone it won't work. Which has stumped a few people along the way...
I guess this can be done as you say combine and make it happen.
Thanks again please close the query 👍
Sent from my iPhone

On 17 Apr 2017, at 22:10, Maxmudjon<EMAIL_ADDRESS>wrote:
Only the doorbell is left
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@KhaosT does the update to include VIDEO_DOORBELL mean anything or just additive for the lib?
https://github.com/KhaosT/HAP-NodeJS/blob/d808656e29390f6934c36bd9b51d1338e63b4597/lib/Accessory.js

@brownad This is just for category, Home app uses that to display icon for unpaired accessory.

Cool. thanks @KhaosT  👍

Finally I created an accessory video doorbell, yeahh))

Awesome !!!!!
Sent from my iPhone

On 20 Apr 2017, at 02:57, Maxmudjon<EMAIL_ADDRESS>wrote:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Need to standardise inputs to read_csv and read_json

Weirdly pyarrow has Converter options for CSV but not JSONL.
For context:
csv reader function
json reader function
You can pass an explicit schema to the json reader so we should test this to see if that works. If it does then we should see if we can apply the same thing to csv for consistency. It would actually be quite nice to have a converter in mojap-metadata that returned a pyarrow schema that we could just pass into these functions.
Otherwise jsonl conversion types can be a bit lossy i.e. reading in a jsonl date string will return a timestamp[s] more details here

@green-digger dno if you have any thoughts on the above

Might also be solved by #32


Permissions always returned denied even though user approved

Describe the bug
I'm having issues with the permissions. The users are prompted with the approve permissions to share read access to their StepCount, Workout, DistanceWalkingRunning and FlightsClimbed data. Even though they approve all I get status denied. All of them are set to approved when checking the Apple Health app and sharing tab.
To Reproduce

Initialize AppleHealthKit.initHealthKit ... when navigating to that component
Approve all read permissions when that is prompted
Checking auth status is status 1 (SharingDenied)

Expected behavior
Once user approved permissions auth status should be set to 2 (SharingAuthorized) and data should be fetched from Apple Health.
Screenshots

Smartphone (please complete the following information):

Device: iPhone 11 Pro Max
OS: iOS16.1
Version: 2

Additional context

Latest react-native-health version is being used
Same issue occurs when testing on multiple devices (e.g iPhone 13 Pro, iOS 16.1.1)

did you solved it?

I'm also getting this, currently on 1.14.0


Test new checks for deprecated packages

!!!Do not commit this change, it is for testing CI changes only!!!

The checks worked properly, closing this PR.


findService() returns incomplete object

Hello,
i am trying to use hydra in my project. I wanna get ip address and port of service.
hydra.findService('test-service') returns an object with only 3 properties:
{"serviceName":"test-service","type":"","registeredOn":"2017-07-21T11:25:14.530Z"}
How can I get ip and port?
Thx

@tolik93 see: getServicePresence : https://www.hydramicroservice.com/docs/hydra-core/hydra-methods.html

@cjus Thank you. I missed this method


[ie/ORFTVthek] Remove extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

The ORF TVthek has been entirely decommissioned and replaced by ORF ON. https://www.derstandard.de/story/3000000220844/orf-dreht-tvthek-endgueltig-ab
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

orf:on is listed in supportedsites.md, so I assume this new site is already supported?

@Hrxn Yes. You might need to update to nightly for the latest improvements to the orf:on extractor.
If you experience any issues, please do not comment on already merged PRs, but open a new issue.


New guide for making addon

new guide for making an addon
self signed helm repo and OCI registry

Signed-off-by: 楚岳<EMAIL_ADDRESS>Description of your changes

I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Update sidebar.js if adding a new page.
[ ] Run yarn start to ensure the changes has taken effect.

Special notes for your reviewer

I suggest add some cue command introduction for rendering in addon-cue.md. Like cue eval *.cue resources/*.cue -e output -d yaml.

please update sidebar.js


[WIP] Implement food

Some food ItemType need changes

Sorry for pom changes :/ I used auto reformat code

Updated

Nice work so far, but the eating time is a bit too long, and cooked porkchops don't feed you. That's all I got from the limited time I had to test, I'll have to test more things later, when I have time.

I couldn't find on wiki how much time it should take.

play around with the values until the animation and server response are aligned.

Cooked porkchops still do not work.


Question: private modules

I want to have some private modules, such as my own :lang myhaskell, but I don't want to maintain my own fork. Is there any way to load modules from ~/.doom.d/modules/lang/myhaskell. As far as I know, doom-modules-dir is defined as a constant. Is there any way around it?

Doom supports modules in ~/.doom.d/modules. It follows the same structure as ~/.emacs.d/modules/CATEGORY/MODULE/. e.g. ~/.doom.d/modules/lang/haskell.
If a private submodule has the same name as a Doom module, like ~/.doom.d/modules/lang/haskell, then that effectively replaces Doom's.
Otherwise, if you want to put it in ~/.doom.d/modules/lang/myhaskell, you'll have to add :lang myhaskell to your doom! block.


redis can't bind ipv6 address on new bosh stemcells, fails to start

stemcell: bosh-stemcell-3363.20-openstack-kvm-ubuntu-trusty-go_agent
cf-redis-release: 429.0.0
routing-release: 0.152.0
appears as though redis processes fail to bind, due to attempting to bind to both ipv4 & ipv6, but I'm guessing ipv6 networking has been disabled as of https://github.com/cloudfoundry/bosh/releases/tag/stable-3363.19
because of this, deployment fails with Failed: 'dedicated-node/0 (ab055142-1184-4533-b26c-4c2065df3ae2)' is not running after update. Review logs for failed jobs: redis (00:03:49)
from dedicated-node/0's /var/vcap/sys/log/redis/redis.log
Creating Server TCP listening socket *:6379: unable to bind socket

nothing else is listening on this port:
dedicated-node/ab055142-1184-4533-b26c-4c2065df3ae2:/var/vcap/sys/log/redis# netstat -anp |grep LISTEN
tcp        0      0 <IP_ADDRESS>:54321         <IP_ADDRESS>:*               LISTEN      11952/agent
tcp        0      0 <IP_ADDRESS>:33331         <IP_ADDRESS>:*               LISTEN      851/bosh-agent
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN      1805/sshd
tcp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*               LISTEN      12017/nginx.conf
tcp        0      0 <IP_ADDRESS>:55937           <IP_ADDRESS>:*               LISTEN      666/rpc.statd
tcp        0      0 <IP_ADDRESS>:2822          <IP_ADDRESS>:*               LISTEN      2258/monit
tcp        0      0 <IP_ADDRESS>:2825          <IP_ADDRESS>:*               LISTEN      851/bosh-agent
tcp        0      0 <IP_ADDRESS>:111             <IP_ADDRESS>:*               LISTEN      629/rpcbind

I believe the shared-node's redis processes had the same issue, I just didn't realize it til after I nuked my deployment and tried to recreate fresh... then encountered the same on dedicated-node as it was deployed first.
It doesn't seem like the redis bind address is configurable in the job params.
edit: confirmed that adding bind <IP_ADDRESS> to /var/vcap/store/redis/redis.conf allows redis to startup successfully

Can you please use cf-redis-release v429.1.0? We've addressed this issue there.


New chip dependecy Load System

I wrote a ricorsive handler for component dependencies, changed some fields in save file. I also implemented some code to ensure compatibility.

Ups, wrong upstream.

Great feat btw!


Flow 0.13.1 issue with short-circuit operator

This snippet type checks in Flow 0.12.0, but not in Flow 0.13.1:
/** @flow */

class PairOfNumbers {
  a: number;
  b: number;

  compareTo(other: PairOfNumbers): number {
    return this.a - other.a || this.b - other.b;
  }
}

The error is that it's returning a boolean and not a number:
$ cat toy.js | flow check-contents
Old server has exited
Flow server launched for /Users/danvk/github/pileup.js
Spawned flow server (child pid=23569)
Logs will go to /private/var/folders/sc/1vw6pyfs1q100brbf7vmqxdh0000gn/T/flow/zSUserszSdanvkzSgithubzSpileup.js.log
The flow server will be ready in a moment.
flow server still initializing. If it was just started this can take some time. Retrying... |
-:10:12,27: boolean
This type is incompatible with
-:9:36,41: number

Found 1 error

This is a spurious type error. The type of number || number in JavaScript is number, not boolean.

Thanks for the report, @danvk. @mroch: do you think there is any way https://github.com/facebook/flow/commit/32bb69984037caae3b4589fc2722651d3b89a6f8 caused the regression?

Here's the snippet from the other issue:
/** @flow */

function foo(): number {
  var num = '123',
      v = +num;
  // Test for wraparound & roundoff
  if (v < 0 || 1 + v == v) {
    throw new RangeError(`Number out of precise floating point range: ${num}`);
  }
  return v;
}


dialog noCancelOnEscKey is broken

Regardless of whether or not this boolean value is set to true or false, the dialog can always be canceled with ESC.

This should be reported in the GitHub repo of the element. If you look up an element in https://elements.polymer-project.org/ it has a link to the source repo.

This issue was moved to PolymerElements/iron-overlay-behavior#50


Adding a PR checklist to add guidance/reminders for authors to check for recurring PR review feedback.

It is generally useful for PR authors to go through their own PR first to make sure that commonly occurring feedback and issues have already been addressed. This checklist should help remind contributors what to look out for and is a living doc that we can modify and add to.
I ask these questions to myself before submitting a PR, when looking through my changes in the "pre-PR-submit-view".
Where possible leverage linter tools and CI gates to help address some of these. For example, for spell-check, here are some solutions to make things easier within the developer inner-loop:

VS Code extension: Code Spell Checker
VS Code extension: Markdown linter
Browser extension: Site Spell

This is a good list but I don't like the requirement that folks click each box.

I intentionally didn't mention anywhere that this is a requirement. This isn't a requirement and the contributor doesn't have to add that in the PR description or click each box. It is only meant as a reminder to start PRs off with. This can be removed from the description when submitted.

These steps should be in the contributors guide and the PR review has a single reference to that location.

That's what I initially had in mind, but things that are out-of-sight tend to be out-of-mind and having this checklist as a reminder right there is helpful. I prefer to start this as a PR template and only move it to the contributor guide after giving it a shot for a couple of weeks and see how it feels, in practice.
This type of approach (checklist in PR template) has precedence in other Azure SDK repos already:
https://github.com/Azure/azure-sdk-for-net/blob/master/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md
https://github.com/Azure/azure-sdk-for-java/blob/master/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md
https://github.com/Azure/azure-sdk-for-go/blob/master/.github/PULL_REQUEST_TEMPLATE.md

I'd say if we expect this to be read more than EULAs, shorten sentences to an aviation-style checklist? :)

[ ] Guidelines?

[ ] Issue/spec/doc?

[ ] Doxygen?
[ ] Unit tests?
[ ] Unintended changes?
[ ] Descriptive title, description ("Closes ")?

[ ] Unrelated changes can be separated to another PR?

[ ] Comments to explain complex code?
[ ] Spelling errors?
[ ] Can it start off as a draft PR?
[ ] Needs update other docs or exiting markdown files?
[ ] Any breaking changes?

The .NET PR template is a nice hybrid of pointing back to the contributing for the definitive list while also calling out the greatest hits.
https://github.com/Azure/azure-sdk-for-net/blob/master/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md


Do not use hardcoded directory for tests

The hardcoded /tmp/js-beautify-mkdir directory path is used for tests,
and this directory it not removed after tests.
This can cause multiplie issues on a build server:

if multiple builds are running js-beautify tests concurrently, they may try
to manipulate the directory at the same time, and step on each other's toes
if multiple users are using the same build machine, since
/tmp/js-beautify-mkdir is not removed after tests, the permissions on
/tmp/js-beautify-mkdir will prevent another user to run tests

Great contribution.  Just a minor tweak, please, and I'll merge it.

@blino - Ping?

Hi,
Sorry, I did not find time to respond with a better fix.
Thanks for finalizing this, and also for the "touch -A" fix!

You had it mostly done.
No problem.  :smile:


Kafka: add advanced health checks

This PR

Exposes all configuration for livenssProbe and readinessProbe for the k8skafka container
Adds two ways of doing health checks (livenssProbe) for the k8skafka container:  a simple port based health check using a TCP liveness probe, and an advanced producer-consumer functional check based on a custom heartbeat topic.
Updates release notes and configuration documentation.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: shubhanilBag
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fabianbaier
If they are not already assigned, you can assign the PR to them by writing /assign @fabianbaier in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @shubhanilBag. Thanks for your PR.
I'm waiting for a kudobuilder member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/assign zmalik

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: shubhanilBag
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zmalik
If they are not already assigned, you can assign the PR to them by writing /assign @zmalik in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kensipe, shubhanilBag
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kensipe, shubhanilBag, zmalik
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kensipe,zmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


objmode error in IR legalization

Reporting a bug

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

Looks like IR legalization is called on objmode IR, potentially throwing error for valid code. Is IR legalization pass needed for objmode IR in general?
import numba
import numpy as np

@numba.njit
def f(A):
    with numba.objmode(B="int64[::1]"):
        B = A.view("int64")
    return B

f(np.ones(11, np.int64))

  File "/Users/ehsan/dev/numba/numba/core/typeinfer.py", line 1071, in propagate
    raise errors[0]
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: Handle with contexts)
Failed in nopython mode pipeline (step: nopython frontend)
Failed in object mode pipeline (step: ensure IR is legal prior to lowering)
'view' can only be called on NumPy dtypes, try wrapping the variable 'A' with 'np.<dtype>()'

File "../tmp/objmode_ir_legal.py", line 7:
def f(A):
    <source elided>
    with numba.objmode(B="int64[::1]"):
        B = A.view("int64")
        ^

During: resolving callee type: type(ObjModeLiftedWith(<function f at 0x10180d040>))
During: typing of call at /Users/ehsan/dev/bodo/../tmp/objmode_ir_legal.py (6)

File "../tmp/objmode_ir_legal.py", line 6:
def f(A):
    with numba.objmode(B="int64[::1]"):
    ^

@ehsantn thank you for reporting this! I can confirm I am able to reproduce this.

This should be easy enough to fix over the RC period.


[zh] Add anchors and tweak lines in style-guide.md

Fix #5267

Add anchors
Wrap long lines

Hi @chalin , got it. Those two lines have been dropped in this PR.


Refactor add_biosample endpoint for partial updates

Codecov Report

Merging #47 (8cb66bd) into stable (2c37753) will increase coverage by 0.33%.
The diff coverage is 86.23%.

@@            Coverage Diff             @@
##           stable      #47      +/-   ##
==========================================
+ Coverage   48.72%   49.06%   +0.33%
==========================================
  Files         226      226
  Lines        6500     6557      +57
==========================================
+ Hits         3167     3217      +50
- Misses       3333     3340       +7

Impacted Files
Coverage Δ

majora2/fixed_data.py
87.50% <ø> (ø)

majora2/form_handlers.py
15.35% <ø> (-23.92%)
:arrow_down:

majora2/api_views.py
21.75% <75.58%> (+3.77%)
:arrow_up:

majora2/forms.py
76.35% <86.17%> (+2.07%)
:arrow_up:

majora2/models.py
54.27% <100.00%> (ø)

majora2/test/test_basic_api.py
100.00% <100.00%> (ø)

majora2/test/test_biosampleartifact.py
99.46% <100.00%> (+1.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c37753...8cb66bd. Read the comment docs.


update pivot_longer notebook

update to the pivot_longer notebook

@samukweku i'm on mobile right now, should we consider merging this? Especially since this is a pretty old pull request.

Hmmmm, this is pretty old. I'll close it instead. There would have more recent updates for the notebook

I'll have a look again and update it


Proposal: Binary stream support on multiplexed ws

Currently binary streams are not available on multiplexed ws.
My proposal is to allow subscriptions to binary streams and have the data returned as the data field as a base64 string per chunk received. Data queries wouldn't be applied. Limits could either be applied per chunk (could be ambiguous) or applied to data length. eg give me 1kb then stop.
Eg.
{
  "type": "event",
  "topic": "Detroit/camera/a5cb1a72-c3e7-47b6-818d-6d81b16e9ed4/video-feed",
  "subscriptionId": 1,
  "timestamp":<PHONE_NUMBER>135,
  "data": "ewogICJhcHBOYW1lIZW5kbGUiOiAiLi9hcHAvbWFpbi1idWlsZC50cyIKfQ=="
}

Would there be a limit per data field?
Would there be syntax to ask for things in megabytes, kilobytes, and bytes?

Other than those questions 👍

I don't think so.
I don't think that's necessary, the 1kb was just an example. I assume you would represent it as bytes.


RNNT training

WIP, I tried to reproduce the results of this Nvidia PyTorch 2xA30 implementation: https://github.com/mlcommons/training_results_v2.0/tree/main/NVIDIA/benchmarks/rnnt/implementations/pytorch
The Nvidia implementation trains in fp16 (with fp32 master weights and loss scaling) in around 45 epochs (+- 5 epochs deviation), one epoch had 278528 data samples. To train in 24 hours means around 6.9 ms/sample.
For this tinygrad version, currently one 4090 can train in fp32 (batch size per gpu 32) in around 14 ms/sample, 2x4090 did only around 10 ms/sample and the gpu usage didn't get to 100%. Hopefully the python part can be optimized to get full multigpu usage. Need to test running in fp16.
To try to have an overview and to time and optimize some steps, I wrote out the backward manually. Also at some point I started writing it without using MultiLazyBuffer, so it would need to be rewritten to use MLB, autograd etc and other standard tinygrad features without doing things manually.
The preprocessing I mostly copied from the pytorch implementation and it currently uses Nvidia DALI and pytorch.
I changed some pointer values myself by hand to have a kind of setitem/getitem and to reuse the same kernels without having to run beam again on the same kernels with offset buffers.
Also dropout was slow and currently I just call cuRAND.
Some later stage kernels use a lot of memory, so I prerun some of them in the beginning to get the beam search cached, otherwise it would run out of memory and I would have to decrease the batch size.
I have run it for 6 epochs and it behaves similarly to the pytorch implementation. With pytorch in 6 epochs the loss went from 1500 to 42, word error rate from 100% to 13.6%. For the tinygrad run the loss went from 1700 to 50, wer from 100% to 14.6%.
I run it with just python model_train.py

Why is the model reimplemented? Isn't there already an RNN-T for inference?

It is just the current state of various experiments I ran to try to get an overview of everything and to try to improve speed.
In the end I would try to do only minimal changes to the existing implementation.

no progress for a week, closing


Improve tablet layout for footer

@dobri1408 I think we should reduce the space if there is no action visible in contact / contact extra:

This is the case of https://biodiversity.europa.eu/
Also, not so important as I couldn't find a website using DS, but:

What happens if you add more actions via ZMI - http://localhost:8080/www/portal_actions/contact_actions/manage_main


Update forms-validation.md

PR of #15739
Internal review URL

@guardrex  I don't understand how your commits got in this.

Sorry about that ... I hit the 🛌💤 sack a little early last night.
Notwithstanding that one commit there for Options (that is a little strange), I grouped the Blazor docs issues by PR for each document so that they would be easy for engineering to review and merge clean 🤞. We'll save a few 💵 in the process. It's all part of my Beat Apple Docs!:tm: program. 🚀:smile:
I recommend that you let me take your text here (along with any other changes that @pranavkm has on #15739, if present) and roll those onto my existing PR for this topic.

I recommend that you let me take your text here (along with any other changes that @pranavkm has on #15739, if present) and roll those onto my existing PR for this topic.

Agreed.

Cool ... I'll take care of this very soon ... this afternoon for sure.
This content (this PR) is cross-linked, so I'll be able to find it. I'll close this and work your language here in on my PR.


tests: add run_all param for js tests

need this so that the CI tests in https://github.com/tilt-dev/tilt-example-nodejs/pull/12 actually do anything useful

Good catch, I had glossed right over the flag name when I first found it. Changed.


New design: Course page layout changes

What are the relevant tickets?
Part of #1773
Description (What does it do?)
This does a lot but is focused on the course page redesign:

Adds feature flagging for all new designs - this will expect a PostHog flag called jkachel-new-design if you want to see the changes
Incorporates the new design for course pages, including:

Updates to the global style sheet (site has a white background now)
Adds info box for the relevant course details on the right side
Displays related program information (with links, though they don't go anywhere right now - program pages aren't in this PR)
Adds a tab bar to the course info
Adds expandable About This Course section - text after the first paragraph is hidden (and it supports splitting on a tag with a specific class name, which isn't exposed in Wagtail right now)
Adds instructor cards with more info modals according to the redesign
Adds redesigned upsell message dialog

Adds some new data to the APIs to allow for these changes

Course API now provides for pulling a single course
Doing this pulls in some additional data (including program info) that it didn't before
Adds API for pulling instructor page details

Refactors the feature flag code in the Django app to look at Posthog as well as the existing .env based feature flags
Removes the faculty members block from the resource page Wagtail model - this will result in any faculty member data in there being lost so make sure you've converted them to instructor pages first.

Screenshots (if appropriate):
Note that this doesn't include mobile layouts - that will be in a separate PR. This is just the desktop view and the feature flag stuff.
Top half:

Bottom half:

Instructor modal:

New upsell modal:

How can this be tested?
To test, you'll need a Posthog account. (There's a free tier if you're creating one.) Once you have that set up, you will need to put your API token and the host in your .env file:
POSTHOG_API_HOST=https://app.posthog.com
POSTHOG_API_TOKEN=get your own

Then, create a new feature flag called mitxonline-new-product-page. The payload can be anything (I set it to True) and make sure to set the Release Condition to roll out to 100% of users:

(I changed the feature flag but have not updated this screenshot so the flag name won't match.)
Finally, before testing, make sure you have some courses set up with a variety of settings - some should be in programs, some should be in more than one program, some shouldn't be in a program, some should have products, some should have financial assistance, etc. Also, make sure your ad blocker is disabled for your local instance - it will likely not be happy about Posthog being there and will then block API calls to it. (This was very much the case for uBlock Origin for me.)
To test: You can toggle between the old and new designs by enabling or disabling the flag. (You just need to enable/disable, not adjust the payload.)
With the flag enabled, you should see the new design. With it disabled, the old design should appear. The new design should match the Figma layout for the course about page (as much as possible - some elements may not appear on a given course depending on what settings they have). The old design should match RC or production.
Note that switching the flag on or off may not take full effect until you reload a time or two - the React app itself looks for the flag and sometimes browser caching flummoxes that.

FYI changed the feature flag name to mitxonline-new-product-page which is what it's (currently) called in the more real Posthog.

I managed to add meet your instructors twice to the course page:

Doubling up of the instructors section is fixed in https://github.com/mitodl/mitxonline/pull/1816/commits/4d1499fbe668736a93b335c78e58ba42d07039f3 (this was more than that; a rebase error pulled in a bunch of old code into the template so a bunch of stuff was getting duplicated).


(PDB-4385) update lein-ezbake version for FIPS

Update lein-ezbake to 2.0.3 to support FIPS

CLA signed by all contributors.

We should rebase this and get some more Travis tests to pass before merging

Wondered if the latest docker test failure was transient, so I restarted it (though I suspect it might be something ruby-related wrt the xenial upgrade).


Add binlog documentation

Description

Adds the steps explained by @stevenbrix in this comment to the repo for easier reference.
Motivation and Context

Closes #2893
How Has This Been Tested?

Screenshots (if appropriate):

Thanks @chingucoding for sending this out!
Do you think you could add some information on how to capture binlogs from the command line as well as visual studio? Those binlogs are generally more helpful and easier to diagnose.
Here's a helpful command for capturing a binlog that simulates the appx package upload to the store if you're having problems with Publish->Create App Packages
msbuild /p:AppxBundlePlatforms=x86 /p:Platform=x86 /p:Configuration=Release /p:BuildAppxUploadPackageForUap=true /bl

I've added a few words regarding the CLI, but I have to admit that I sort of just copied your steps from your comment into this file. I'm not an expert on this, and you definitely have more knowledge here than me.

/azp run

/azp run


Several easy TODO tasks are done

Fixed sized arrays are replaced with graphics::Color.
Some parts of 'Scenario' struct are renamed.
Ability cooldown is wrapped into structure.

Merged, thanks for the PR! (and sorry for the slow response)


destroy method

Hi,
if I destroy the controller in my destroyed() method, there doesn't
seem to be a possibility to reinit the scrollmagic instance.
        destroy (resetScenes = false) {
          return this.controller_.destroy(resetScenes)
        },

Hi.
Yes, according to the ScrollMagic documentation, this method destroys everything.
So use it with caution.
This method will be advantageous for temporary controllers.


Fixes the sent_at attribute not accounting for timezone.

I noticed the sent_at attribute was showing a different value than what it was showing in my gmail inbox. I used the information found here to make sure the timezone is properly accounted for. I am assuming this was the original intention because parsedate_tz() is used rather than just parsedate().

I am maintaining a fork of this project if you are interested in adding this change here https://github.com/girishramnani/gmail


Do not allow to remove a level if there are achievements for that level

Right now dashboard simple directs to an error page

PR https://github.com/NationalSecurityAgency/skills-service/pull/585

:+1:


New DomainTools Integration Docker Image

Status
Ready
Related Content Pull Request
N/A
Related Issues
N/A
Description
Create Docker image for use in DomainTools Integration

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Wesley Agena seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @eyalpalo! There is no content contribution PR to go along with this yet. We are starting work on an update to this pack: https://github.com/demisto/content/tree/master/Packs/DomainTools_Iris
Our plan was to get the dependencies added in this PR squared away before starting work on the corresponding updates to the DomainTools_Iris pack. Is that okay? Thank you!

Hi @eyalpalo, I saw that I had a new failed workflow for native_docker_image_labeled.  I read through the The Native Image Docker Validator docs but wasn't sure what I needed to update in my PR to get that passing. Do you have any further details on what I need to update? Or a link to an example of what's needed here?
I also saw that merging was blocked until I pulled in the latest from master, I pulled that in which hid the failed workflow. Here's a link to the failed job in case it helps: https://github.com/demisto/dockerfiles/actions/runs/5060142397/jobs/9210617269?pr=16869

@wesleya hey, lets wait to merge this PR until the content PR is ready for merge, in case the docker will need to change for any reason
Regarding the failing workflow, you can ignore it for now. Seems like theres an issue with it. @YuvHayun could you check that out?

@YuvHayun the following dockers were updated: oauthlib, tidy, winrm, ami-management, xml-feed, py3-native, crypto, azure-kusto-data, oci, boto3py3, akamai, ansible-runner, ssl-analyze, taxii-server, keeper-ksm, google-api-py3, axonius, domaintools, pydantic-jwt3, pyjwt3, teams, flask-nginx, demisto-sdk, py3ews. Please consider updating their verify script accordingly.
From verify check. Looks like they used a bad diff somehow (maybe related to the fact that its a  fork.)


Iris versions not appearing in list

What happened?
Versions 1.4.5, 1.4.6, and 1.4.7 do not appear in the Iris versions dropdown list.
What should happen?
I don't want to fill like I'm filing my taxes every time I want to report a bug
Biome
No response
Minecraft Version
1.17
Iris Version
1.4.4
Relevant log output.
No response
Checklist

[X] I am using an unmodified version of the overworld. (If you modified the overworld and see an issue, contact support)
[X] I am using the latest version of the overworld OR I have made sure this issue was not already resolved on the latest version.
[X] I am using Spigot, Paper, Tuinity, or Purpur. (If you are not, and still think it is a valid issue, contact support)

The reason for it is that i have people using iris 1.4.4 reporting bugs on 1.16 overworld. this just adds that extra step to ensure i can actually help and its not people being dummies


Refactoring framework

Since the framework refers to elements of the plugin, namely the catalog-dita.xml file, I propose to move the framework to the root of the plugin.
This way the whole plugin can be imported to Web Author and still work as a plugin when adding it to oXygen XML editor.
I also separated the topics and maps into two distinct folders and removed templates that had nothing to do with terminology.

Thank you for your contribution, @lionelmoi.
Please delete test.dita and test.ditamap.

done


Consider a JUnit Reporter

Is your feature request related to a problem? Please describe.
Many CI systems offer first-class support for summarizing or displaying test reports provided they are in the JUnit format (or another standard format). The existing XML reporter outputs a custom XML format that other tools do not support.
Describe the solution you'd like
Change the XML reporter output format to output in the JUnit format.
Describe alternatives you've considered
Keep the XML reporter as-is for backwards compatibility, but introduce a new JUnit reporter. I have little context on how many projects depend on the format of the existing XML reports.
Additional context
See CircleCI's built-in support for displaying test reports or this GitHub Action for examples of tools that would be able to leverage this reporter, and boost jscpd's visibility on projects that use it.

Hi Kurt, as I understand JUnit is for unit testing report, but here we don't have test suites or test cases, that is why I'm not sure that we can use it for copy/paste report? Do you have any examples how we can use it for duplications?

I was envisioning one test suite (e.g., "duplication", "copy/paste detection") with one test case per file checked that succeeds if there were no duplicates and maybe reports the number of clones detected (or possibly the full source of all the clones) as a test failure otherwise?

I'm sorry, I didn't find good solution for the request, that is why I'm going to close it


[QKM Docker image] Support for arm64 platform - Apple M1 Silicon

Summary
Create docker images compatible with linux/arm64 platform to run QKM in Apple M1
Technical Notes
Current images linux/amd64 throw the following error:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped

It looks to be due to a bug in qemu. Official docker team recommendation is to build arm64 images.
similar issue
I was able to create an image that could run on Apple M1 Pro (no performance or exhaustive testing) by removing the option GOARCH=amd64 in the Dockerfile. The created in Apple M1 Pro machine as well.
Business Value
Apple Silicon processors are becoming mainstream, specially among developers. It would be good to run this in new Apple M1 computers for development in project that use QKM as part of its stack.
Acceptance Criteria

[ ] Publish an image that runs on linux/arm64 platform

Hi @pedronfigueiredo
we recently added to our CI/CD a task to build and publish arm64 compatible images. The first one of the round it is this one
https://hub.docker.com/layers/consensys/quorum-key-manager/v21.12.1-arm64/images/sha256-02cbbe1593716ce939b2bdcb5a74c7241f5c6ced7455c04c61a5e92785c018fc?context=explore


Add a functional test for the new searchPath option

As a community, we are doing a great job adding Unit and Integration tests.
However, when adding a new feature or capability, we need to start creating a higher-level functional test that ensures the capability continues to work as the codebase evolves.
This ticket is a request to add a functional test for the searchPath option.

Test setting serarchPath using:

liquibase.properties liquibase.searchPath: path/to/your/resource/root
CLI 'liquibase --search-path=path/to/your/resource/root'
POM.xml
ENV vars (for LB Pro) 'LIQUIBASE_SEARCH_PATH=path/to/your/resource/root' (Mac/Linux)
JAVA system property

changelog present outside of working directory where commands are running, LIQUIBASE_HOME/lib, liquibase_libs, and any classpath settings
run liquibase validate without setting searchPath
expected result: error, cannot find changelog location
add searchPath
run liquibase validate
no errors in locating changelog

There are some existing searchPath scenarios already added in SearchPathRegressionTests, but there some other from the requested ones here are not. We have created this ticket to keep track of that work.


How to expose carbon port?

Wish the carbon port was exposed. That would be awesome so uwsgi can be used to send data to it.

:+1:

docker run
--detach
--publish=8080:80
--publish=81:81
--publish=8125:8125/udp
--publish=2003:2003
--publish=8126:8126
--name grafana-dashboard
kamon/grafana_graphite

--publish=2003:2003/udp


Consecutive queries using GPT-4-Vision produces error

It appears that image urls are not correctly added to the collection of messages after an image-attached query. When using the gpt 4 vision model, any query that follows a query with an image produces the error "Invalid image URL". Here is what it looks like:

To reproduce the error:

Select OpenAI gpt-4-vision model.
Send a query with an image attached.
Send another query with, or without, an image attached in the same chat.
"Invalid image URL" error occurs.
(If the page is refreshed at this point, and the same chat is accessed, then further queries DO NOT produce the error).

Looking at the messages print to the console, the error occurs when image_url is an empty string when it should be a base64 representation of the image. The problem may exist in the buildFinalMessages function in lib/build-prompts.ts, where the messages are constructed. I wasn't able to fix the error, but hopefully this issue helps someone else fix it.

There's some serious spaghetti code throughout the entire chat process. Working over the next 2 days to completely refactor that and it should completely clear up this issue!

Fixed.


Watch requested failed for channel

Hello,
I've been running into this more and more lately, and I'm struggling to determine the cause of it. If the miner watches a channel, but the channel ends up going offline, there's a "switching" message printed out, that isn't followed by "watching" message - the channel switch triggers, but it should've entered the idle state, which stops the watching process. Instead, the miner somehow does not switch into the idle state, and instead continues to watch the channel that just went offline, printing "Watch requested failed for channel" over and over, until the next reload resolves everything.
All of this is only visible if the miner is launched in CALL verbose mode: -vvv, so a general user won't see a problem. It isn't really a problem on it's own either, but I'd rather not bother Twitch trying to watch an offline channel like that.
Has anyone else seen or encountered this?  I need more diverse testing subjects to determine the cause of this. Even stating "I have not seen it" helps, as long as you share your priority list setup to it, and ensure you're running it in CALL verbose mode (otherwise it's impossible to spot).

I"m so confused.

Okay, so the issue is gone. My suspicion is that either https://github.com/DevilXD/TwitchDropsMiner/commit/c7b89cae2f7515bfa961952ddd5ff4b5ca057d06 or https://github.com/DevilXD/TwitchDropsMiner/commit/0551f49a3d165e19b97554035d03174f48b50368 were causing this, but it's not happening anymore. A channel going offline correctly switches to the IDLE state, and removes a channel from watching.


After upgrading to 0.1.14 version, url is no longer being updated on route change

After upgrading solid-app-router from "0.1.7" to "0.1.14", the url is no longer updated on path change.
I'm using "solid-js": "^1.3.5"

There was a small breaking change in Solid 1.3 which affected the router. The 0.2.x version of the router account for this. I will add something to the readme to indicate the version change

thank you. I didn't know there was 0.2 version when trying to upgrade