Can't add card to the right of card with multiple parents

When adding a card to the right of a card that has multiple parents we get the following error message
https://github.com/equinor/flyt/assets/35768833/db90b002-510d-45d1-91c9-877740366419

Works good, the user can add card to the right side of card.

@nesadrian By following the video, I still cannot add neighbor cards to one of the leaf node card. I shared process 2403 with you in qa-graph-poc. It is in the Tobe page.

@QiJin-Bouvet After doing some testing it looks like the backend issue has been fixed. I'm no longer getting error responses when trying to add cards in this scenario. The missing "add neighbour" buttons is a frontend bug so I have made a new issue here #680

OK. Then we close this issue and continue working on #680.
Reopen this issue when necessary.


Conformance Tests: No implicit test runs without features

What type of PR is this?
/kind cleanup
/kind test
/area conformance
What this PR does / why we need it:
In #1890 we removed implicit support for HTTPRoute, and created #1891 as a follow up to do this for all types. With #1878 bringing Mesh conformance tests soon this patch makes it cleaner for implementations which ONLY support mesh to simply not run any unrelated conformance tests.
Which issue(s) this PR fixes:
This doesn't completely fix, but does support #1891.
Does this PR introduce a user-facing change?:
No conformance tests run by default anymore, including tests for GatewayClass and Gateway. A new
SupportGateway feature must be opted into in order to run those tests (similar to what we've done
previously for ReferenceGrant and HTTPRoute).

WIP: waiting on another PR before this will be out of draft DONT REVIEW YET

/test all

@shaneutt could you add a quick update to the conformance docs in https://github.com/kubernetes-sigs/gateway-api/blob/main/site-src/concepts/conformance.md ?

curious will EnableAllSupportedFeatures run Gateway and Mesh tests going forward ?

EnableAllSupportedFeatures already runs mesh before this change. If you don't want mesh, then you don't want all features I think. maybe we should have AllGatewayFeatures helper though?

thanks for the clarification, in that case a release note mentioning this would be good to have.
and maybe that EnableAllSupportedFeatures can be replaced with just enabled SupportGateway feature suite, to retain previous intent ?

@shaneutt could you add a quick update to the conformance docs in https://github.com/kubernetes-sigs/gateway-api/blob/main/site-src/concepts/conformance.md ?

Good call! changed in 2acae499bc45d585bb240cfe48fdd1047bbde763 :+1:

EnableAllSupportedFeatures already runs mesh before this change. If you don't want mesh, then you don't want all features I think. maybe we should have AllGatewayFeatures helper though?

thanks for the clarification, in that case a release note mentioning this would be good to have.

I had already had a release note in the PR description, let me know if you feel it needs to be expanded upon.

Release notes updated as requested, thank you! :+1:


Add option to select and provision pretrained text embedding models

Description
This PR adds the ability to select existing models, or select from available pretrained models, in the text embedding processor component. Specifically:

adds and updates several ML commons interfaces and constants
enhances search model logic on server-side to parse out more details from the API responses
adds some pretrained model constants to be optionally used when building flows
adds a ModelField field type to process all of the logic around model selection, including only showing valid deployed models, and available pretrained models. Note: the final props and how customizable this field will need to be is TBD. For example, we can customize it to be tailored towards text embedding models vs. other types of models in the future
updates form state and form validation to persist more model info instead of just model ID (now model ID + model type (pretrained vs. existing/deployed) + open door for more)
updates toTemplateNodes to dynamically handle the template node creation based on a pretrained vs. existing/deployed model. If a pretrained model is selected, we add a previous step to register and deploy that model, and use the produced model ID in the downstream create_ingest_pipeline step. Else, use the existing logic and just use the user/form-supplied model ID directly in a single create_ingest_pipeline step.

Misc:

cleans up routing and URL logic when navigating to the plugin from the global sidebar, in addition to the default rerouting to the workflows page
removes hyperlink in the base Flow Framework breadcrumb
changes the provisioned workflow state slightly by removing the readonly guardrails and allowing the components to be selectable to see the details. Adds a warning callout when values are changed but the workflow is provisioned, and still enforces the workflow to be deprovisioned before changes can be saved. Adds TODOs if we want to revert this change
enforces uniqueness on resource ID list to prevent duplicates which can happen on backend in certain edge cases (comments in code about it)

Demo video:

creates workflow with pretrained model
provisions workflow to create the model and use it in the downstream creation of an ingest pipeline
views the workflow resources, including the newly created model

screen-capture (29).webm
Issues Resolved
Makes progress on #73
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Might have missed it in the code but also if its a pretrained model it has the info like dimensions in the model metadata for further steps that need that

Might have missed it in the code but also if its a pretrained model it has the info like dimensions in the model metadata for further steps that need that

Right. I have this in line 196 in common/interfaces. Now that we have it persisted, we can utilize it dynamically during template construction later on. I still have it hardcoded atm, but there's a TODO tracker for it


Incomplete JSON buffer after composite value containing an empty dict fixed

When the last value of a decoded object item was an empty object, the next object item failed to decode, because the opening { was missing in the buffered to-be-decoded JSON item.
Solves #41

@ideea, can you please check if it works for you? Thanks.

@halaxa hey. it works now :)

Released in 0.6.1.


remove duplicate starter dependency

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     40.17%   40.17%
  Complexity      140      140
=========================================
  Files            58       58
  Lines           779      779
  Branches         45       45
=========================================
  Hits            313      313
  Misses          436      436
  Partials         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e66129...aafa5bb. Read the comment docs.


Cleanly use Eloquent alongside OAuthUserWrapper

Hey,
So it'd be really cool if I could have the same kind of object returned from Auth::user() also inherit from Eloquent\Model (to be able to have a hasMany relation for example).
What's clean way to have my wrapper inherit from Eloquent\Model?
I can't do that at the moment because AuthFromRequest currently does
$wrapperClass = config('oauth2login.authWrapper');
return new $wrapperClass($resourceOwner);

and this conflicts with the constructor signature of Model because it takes in an array rather than a ResourceOwnerInterface.
I'd like to be able to simply do Auth::user()->some_has_many_relation for example.
How do you suggest I accomplish this?
The simplest (and very hacky) way I found is to inherit from Model and make a constructor that takes a single parameter, if that parameter is an array (in which case my instance is initialized through Eloquent) simply call the parent constructor with it, if it gets a ResourceOwnerInterface (which I don't use that much because I actually use a JWT access token that has everything I need) instead then it's been initialized from laravel-oauth2-login. This method is quite brittle and I'd prefer to find a cleaner way.
I apologize again if I'm flooding you with questions, still finding my way through Laravel after years of not using it.

Just for clarification, the User model in your consumer application can be filled from both, an users table and via OAuth2-Login? Designing the package I assumed that the user-data would always only be stored on the side of the IP.
However I acknowledge that even then you could have tables with a FK on the user_id and it would be nice to utilize relations for that.
I don't think there are many other solutions than the one you found, because of the design of this package. Hardwiring that the wrapper-class gets the ResourceOwnerInterface as param1 is bad style, this should be abstracted somehow.
My current approach for that would be to allow a factory/invokeable for the creation of the object to be specified in config and then:
return app(config('oauth2login.authWrapperFactory'))($resourceOwner);

In this factory you could obv. get the data as an assoc-array and construct/return the Eloquent model.

You mentioned you have relevant data in the JWT payload - have you managed to access that? Currently it (the raw AccessToken) is only saved in session I think. But probably decoding the JWT / injection the data to Auth/Request attributes should be done in your code. I don't think that concern fits in this package, as the AccessTokens are not necessarily JWTs.

The factory approach seems like a good solution to the problem.
Yes I do use a JWT and I agree this library shouldn't concern itself with that, I got the JWT out of the session and decoded it myself.

Yes, this has solved all my issues! Thank you so much @kronthto!


EPG Data is max 2 hours in front.

So I stumbled across this, when checking my old xml's from i.mjh.nz and the data on the pluto website they are in line with 5-7 hours epg data where I'm now getting 1½ to 2hours max data with this script, the xml file is also around 3 times smaller than usual using mapping dk.
I made sure to check pluto website as of today and it's still a consistent of 5-7 hours of epg showing in their guides too, so what can the issue be here?
I noticed this when using my shield and could see right away that it said no information in the end of all channels in guide mode.

Thanks for that. 1.1.12 gets 24 hours of epg.


[Feature][Task Plugin] Add mlflow task plugin for MLops scenario.

Purpose of the pull request
Add MLflow task plugin to enable Dolphin users to schedule MLflow.

support basic algorithm (lr, svm, lightgbm, xgboost)
support automl tool (autosklearn, flaml)

This PR relates to #9725.
Because I want to continue enriching the capabilities of this plugin, leave the issue open for now.
Brief change log

Verify this pull request

Verified by unit test.

Codecov Report

Merging #10036 (cc63932) into dev (359cbe2) will decrease coverage by 0.02%.
The diff coverage is 33.58%.

@@             Coverage Diff              @@
##                dev   #10036      +/-   ##
============================================
- Coverage     40.87%   40.84%   -0.03%
- Complexity     4628     4653      +25
============================================
  Files           839      844       +5
  Lines         33986    34120     +134
  Branches       3765     3778      +13
============================================
+ Hits          13891    13937      +46
- Misses        18765    18848      +83
- Partials       1330     1335       +5

Impacted Files
Coverage Δ

...nscheduler/plugin/task/mlflow/MlflowConstants.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/mlflow/MlflowTaskChannel.java
0.00% <0.00%> (ø)

...r/plugin/task/mlflow/MlflowTaskChannelFactory.java
0.00% <0.00%> (ø)

...olphinscheduler/plugin/task/mlflow/MlflowTask.java
16.32% <16.32%> (ø)

...scheduler/plugin/task/mlflow/MlflowParameters.java
53.62% <53.62%> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359cbe2...cc63932. Read the comment docs.

Please run the prettier directive to format the code

I have dealt with the problems above.  Please take a look

LGTM

I have rebased the upstream dev, PTAL, thanks.


BUG: stats: fix discrete .isf to work at boundaries when loc != 0

Reference issue
closes gh-14236
What does this implement/fix?
The .isf method of discrete distributions has been changed to incorporate location shift for quantiles 0 and 1 as explained in gh-14236. Appropriate tests have also been added. This PR closely resembles gh-11248.
Additional information
N/A

Thanks, looks good to me


Hello my friend, do you have any idea why this is happening?

Launching lib\main.dart on Android SDK built for x86 in debug mode...
Built build\app\outputs\apk\debug\app-debug.apk.
I/Choreographer( 1502): Skipped 34 frames!  The application may be doing too much work on its main thread.
D/EGL_emulation( 1502): eglMakeCurrent: 0xef97f2e0: ver 3 0 (tinfo 0xe8273cd0)
I/OpenGLRenderer( 1502): Davey! duration=729ms; Flags=1, IntendedVsync=55229025141473, Vsync=55229591808117, OldestInputEvent=9223372036854775807, NewestInputEvent=0, HandleInputStart=55229594840430, AnimationStart=55229595609460, PerformTraversalsStart=55229595819700, DrawStart=55229622915100, SyncQueued=55229641538330, SyncStart=55229649316520, IssueDrawCommandsStart=55229649994050, SwapBuffers=55229719895430, FrameCompleted=55229762241850, DequeueBufferDuration=26679000, QueueBufferDuration=2305000,
D/        ( 1502): HostConnection::get() New Host Connection established 0xe7cfde40, tid 1559
D/EGL_emulation( 1502): eglMakeCurrent: 0xef97f400: ver 3 0 (tinfo 0xe8273970)

Do you think it is the emulator I am running on?? I git cloned your app but it does not build fully. Please and thank you

Hmmm... works fine on my computer...
Can you add more info like flutter doctor output?


ENH: integrate: support ILP64 in quadpack

Reference issue
Part of gh-11193
The first commit is gh-12090
What does this implement/fix?
Support 64-bit Fortran integers and BLAS in quadpack.
Again, the old hand-written C wrappers make the conversion more involved.

LGTM, and MKL build is happy too. Merging, thanks @pv


Laravel 5.6 support

Easy fix I think, should just update composer.json

@poncianodiego Laravel 5.6 update was performed. You can install Larasap-V1.1.2


[1.12.x] Move StreamConfig out of runconfig

StreamConfig carries with it a dep on libcontainerd, which is used by
other projects, but libcontainerd doesn't compile on all platforms, so
move it to github.com/docker/docker/container/stream

LGTM


Length for single item array behaves incorrectly

The following example does not work correctly:
Json:
[{"verb": "TEST"}]

Jsonpath:
<EMAIL_ADDRESS>== 'TEST')].length()

Result of this query will be Null, while correct result should be 1 as one item was found.
It looks like this happens because if length of result is 1 we can not determine if we should return length of the object of length of the result array: https://github.com/besok/jsonpath-rust/blob/master/src/path/top.rs#L99

I attempted to fix it here: https://github.com/besok/jsonpath-rust/pull/28
I tried to add as many tests as possible, not sure if I covered everything.

Thanks Yuriy!


Traefik 1.7.16 stucked, won't serve request with --logLevel=DEBUG

Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[x] No

What did you do?

Running traefik 1.7.16:

inside docker container with --logLevel=DEBUG
use Docker provider

There are around 36 containers started/stopped during 19 hours period.
It is working normally, until Traefik stopped forwarding request to any containers:
When the issue occurred, I can access traefik dashboard normally.
What did you expect to see?
Request to docker containers work correctly.
What did you see instead?
Connection established. But no response from traefik.
curl -v -k https://container.domain.com
* About to connect() to container.domain.com port 443 (#0)
*   Trying <IP_ADDRESS>...
* Connected to hello.test (<IP_ADDRESS>) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
* skipping SSL peer certificate verification
* SSL connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
> GET / HTTP/1.1
> User-Agent: curl/7.29.0
> Host: container.domain.com
> Accept: */*
>

Output of traefik version: (What version of Traefik are you using?)

Version:      v1.7.16
Codename:     maroilles
Go version:   go1.12.9
Built:        2019-09-13_01:12:20PM
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
defaultEntryPoints = ["http", "https"]

[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
    entryPoint = "https"
  [entryPoints.https]
  address = ":443"
    [entryPoints.https.tls]
      [[entryPoints.https.tls.certificates]]
      certFile = "/opt/some.crt"
      keyFile = "/opt/some.key"
  [entryPoints.api]
  address = ":5566"

[api]
entryPoint = "api"

[docker]
exposedByDefault = false

Using docker image: traefik:v1.7.16-alpine
If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2019-09-19T11:19:38Z" level=debug msg="Filtering disabled container /container.hello.com_1_f673ec0b96a5"
time="2019-09-19T11:19:38Z" level=debug msg="Filtering disabled container /container2.hello.com_1_abba792ef6b0"

I have try running traefik again with debug = true and got following
full goroutine stack dump

pprof001.zip

Hi @nattster , thanks for reporting! Could you share a reproduction case, or at least the full docker-compose / docker build command to help us please?
If possible, sharing the lables of the backends containers could help us as well.
Also: did you have the same behavior with 1.7.14 or 1.7.15 version?

I did not use docker swarm. Just docker-compose.
Full docker-compose for traefik:
version: '3'

services:
  reverse-proxy:
    image: traefik:v1.7.16-alpine
    command: --logLevel=DEBUG
    ports:
      - "80:80"
      - "5566:5566"
      - "443:443"
    networks:
      - traefik-net
    environment:
      - http_proxy=http://someproxy:3128
      - https_proxy=http://someproxy:3128
      - no_proxy=localhost,<IP_ADDRESS>,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,.local,<IP_ADDRESS>/12
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - ./traefik.toml:/etc/traefik/traefik.toml
      - /opt:/opt
    restart: always

networks:
  traefik-net:
    external: true

Backend containers: (container.domain.com, container2.domain.com, ...)
version: '3.4'

services:
  nginx:
    image: nginx
    restart: always
    expose:
      - "80"
    networks:
      - internal
      - traefik-net
    labels:
      - "traefik.enable=true"
      - "traefik.docker.network=traefik-net"
      - "traefik.frontend.rule=Host:container.domain.com"

networks:
  internal:
  traefik-net:
    external: true

I also face this issue with 1.7.14, and before upgrading to 1.7.16.
I don't have exact reproduction steps.
But I just realized that I have been using traefik with --logLevel=DEBUG for quite sometime.
Recently, when I got more containers added/removed, this problem start to occur more frequently (everyday).

Hi @nattster , would you mind switching this discussion to the community forum?
It would get more attention and knowledge sharing on this specific case, as we do not consider this behavior as a bug without being able to have a reproduction case. We might be wrong (and then in this case we'll come back here to file a bug with all reproduction elements to helps the maintainers), but it feels like there is something specific in your environment that blocks the systems calls, which is outside the scope of Traefik. The community could help!
(Tip: check the number of open file and tcp sockets on your kernel, or even better: restart the server and lower the log level for production usage as debug should only be there for punctual diagnosis).

@dduportal After lowering log level, traefik has been running 7 days without issues now. Thanks!


In swagger-ui endpoints are not visible in version > 2.4

Hi,
I am using swagger 2.6.1. I had basic auth in my application. And I recently added outh2 to my application. Since then Swagger-UI doesn't show any endpoints.
This is what I have in my security config
http
    .csrf().disable()
                .requestMatchers().antMatchers("/swagger-ui.html", "/swagger-resources",
                "/configuration/ui", "/configuration/security",
                "/v2/api-docs", "/webjars/**")
                .antMatchers("/product/**")
                .and()
                .authorizeRequests()
                .antMatchers("/swagger-ui.html", "/swagger-resources",
                        "/configuration/ui", "/configuration/security",
                        "/v2/api-docs", "/webjars/**", "/product/**").hasRole(API_ROLE)
                .and()
                .httpBasic()
                .and()
                .sessionManagement().sessionCreationPolicy(SessionCreationPolicy.NEVER);

so when I open swagger-ui in the browser, it ask for authentication. And when I authenticate, I expect to see all the endpoints.
I know only the endpoints starting with /product/ will work. and others will not work(That is expected behaviour)
This works in version 2.4.0 but not with any version after 2.4.0. I cannot see the endpoints itself.
Can you please suggest.Do I need to include any other patterns?

Try changing "/configuration/ui", "/configuration/security" to "/swagger-resources/configuration/ui", "/swagger-resources/configuration/security"`

Hi,
Thanks for the reply, I got it work by doing this
   .requestMatchers().antMatchers("/swagger-ui.html", "/swagger-resources/**",
                "/configuration/**",

Thanks


Copy Icons not showing up in Logseq 10.1

I was using Copy Code 1.2.0 quite a while. Currently in at least Logseq 10.1 it stopped showing the icons in line and on code blocks.

I already restarted Logseq and rebuild the Logseq Cache already.
The Plugin Settings are only reachable from the Plugin Marketplace Installed Plugins Page as JSON, not from the Plugin Settings.
The Plugin is enabled

Settings JSON
{
  "IconTopPosition": "-1em",
  "IconRightPosition": "0em",
  "AlwaysShowInlineCopyButton": true,
  "disabled": false
}

After the update to , fixed in Logseq 10.2 the effect is gone and both copy icons are working again.
The effect seems to be related to Logseq 10.1 itself.
Thank for patience. I close this issue myself.


Quantum channels

Summary
Adds quantum channel package to quantum_info. This package contains classes for representing quantum channels (CPTP maps, and also general Non-CPTP operator maps) and is essentially an implementation of the paper:
Tensor networks and graphical calculus for open quantum systems
Wood, Biamonte, Cory, Quant. Inf. Comp. 15, 0579-0811 (2015)
Open access: arXiv: arXiv:1111.6950v3
Details and comments

Contains classes for channel representations:

Choi: Choi-Jamiolkowski process matrix
SuperOp: Linear superoperator
Chi: Pauli-basis Chi matrix
PTM: Pauli transfer-matrix superoperator
Kraus:  Kraus / operator-sum operators
Stinespring: Stinespring / system-environment insometry
UnitaryChannel: single-matrix Kraus representation (not generic operator map like other reps, and not exposed to user by default)

The classes can be converted into each other using their init methods eg: SuperOp(Kraus([k1, k2]))

All classes contain methods for

is_cptp: check if map is completely positive trace preserving
evolve: evolve a quantum state by the channel
adjoint: compute to the adjoint channel
conjugate: compute the conjugate channel
transpose: compute the transposed channel
compose: compose with another channel B(A(rho))
tensor: tensor product with another channel A \otimes B
expand: expand with another channel B \otimes A (reverse order tensor product)
power: compose channel with itself n times
add: linear addition of two channels
subtract: linear subtraction of two channels
multiply: scalar multiplication of a channel

Operator overloads:

+,-,* for add, subtract, multiply
@ for compose
^ for tensor

Closes #1193
Tests

[x] Tests for Choi class
[x] Tests for SuperOp class
[x] Tests for Chi class
[x] Tests for PTM class
[x] Tests for Stinespring class
[x] Tests for Kraus class
[x] Tests for UnitaryChannel helper class
[x] Equivalence tests for evolution
[x] Equivalence tests for tensor, expand
[x] Equivalence tests for compose
[x] Equivalence tests for conjugate, transpose, adjoint
[x] Equivalence tests for add, subtract, multiply

Future PR:

Integrate with Ericks Unitary class in PR #1961
Integrate with Qiskit Aer noise model

I think this closes #1193

@jaygambetta @ajavadia this is finished and ready for review

also chris can we make an issue to make the PTM change order depending on the order a user gives it. Ie I should be able to put in a Pauli group.

Changed order of tensor product and removed the front kwarg to swap order. The reverse order tensor product is now done with a seperate method called expand

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

isn't there a bunch of duplication between the UnitaryChannel here and the one that derives from Gate in #1774 ?

@ajavadia yeah it  can be removed once Ericks is finished, but its needed here internally for tests.

Nice work, especially writing all those unit tests.
This generally looks good to me. I have one concern however: what is the actual use case of the inplace args? At first I liked the idea, but as I was working on #1816 I realized this is not as easy to do, since:

we don't want to allow modifying the fundamental objects (say H gate).
it becomes a bit ambiguous in hierarchical setting (modifying circuit A in place, when it contains circuit B; does B get modified?).
it complicates the code a lot, as you have if inplace: checks all over.
we open up circuit/channel objects to being modified, which may potentially cause hard-to-track bugs later.

So what do we lose if we just said every operation returns a new circuit or channel? I'm mainly talking about the end user scenario, not internal implementation (cc'ing @kdk).


FIX : fixed tuples in hashing, by converting them to lists

List of Changes

Fix #491

Explanation for Changes
Generally, scene caching iteratively check in every iterables for circular references. If one is found, then the value in the iterable causing the circular reference is replaced. Same if an element has already been processed.
The issue is, if the iterable is a tuple, as tuples are immutable, it is impossible to modyuf it
Testing Status

Added a test for this case.

Acknowledgement

[x] I have read the Contributing Guidelines

LGTM, but not sure why tests are failing.

Windows tests are curently failing on the whole repo ;/


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
[ ] Write a short description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @jiaxiangc, wanted to send a small nudge and ask if you had any questions!

@jiaxiangc, wondering if there's any way we can support you on this PR!


Fix OpenBSD build docs

OpenBSD 7.2 installs go 1.19 by default
Doubt you can run nix on OpenBSD so skip the makefile/nix build and just go build directly

(this is only an auxiliary docs change so none of the checklist seems relevant)

Thanks!


bots: Allow empty bot queries.

This commit allows bots to be adressed with empty queries,
that is, by just @-mentioning them. @-mentioning is now the
only way to adress a bot.
@robot-dreams

Automated message from Dropbox CLA bot
@derAnfaenger, it looks like you've already signed the Dropbox CLA. Thanks!

This change mostly looks good, though I have a two small concerns:

This does much more than what the commit messages says
Is it safe to no longer strip the leading space?  If this is the message,

@**the-bot** hello

the old code would send hello to the bot, while the new code would spend <space>hello to the bot.  Will this cause issues with any of the bots?

@robot-dreams leading whitespaces will get stripped now. Regarding the commit message, I think this is comprehensive enough.

Merged, thanks @derAnfaenger and @robot-dreams!


Transition for open and close cookie options

🚀 Feature Request
Is your feature request related to a problem? Please describe.
When you click at options the checkboxes appear using v-if. Please add a smooth opening and closing transition.

Describe the solution you'd like
Klick in options
Checkboxes appear with a smooth animation.

Describe alternatives you've considered

Additional context

@alkhimch here

@Gismo1337  thank you 🙏

@Gismo1337  Can i create new checkbox component ?

yes. but please try to keep it small and simple. no oversize and no more dependencies.

@Gismo1337 https://github.com/Gismo1337/vue-cookie-consent-banner/pull/27

@alkhimch merged. nice feature. but the root of this issue was to make a transition for the checkbox overall. if you click @ options, the checkboxes appear. they could appear with a smooth transition =)

@alkhimch  do you working on this?

After adding the checkbox description, we should add a "opening animation"

Hey @Gismo1337
I'll take this if no one's on it. Thanks!

@alexjharrison assigned to you. have fun with this!

Hey @Gismo1337
I couldn't get it to work among all screen sizes consistently.  You can unassign me and have someone else try it out.


Cannot add big resources to Keptn

Environment

Client OS (e.g., Linux, macOS, Windows): Linux
Keptn Version (keptn version): 0.13.1
Kubernetes Cloud Provider (e.g., GKE, AKS): k3d
Kubernetes version (kubectl version): Client: v1.23.5; Server: v1.22.6+k3s1

Affected Component

[ ] Approval
[ ] Bridge
[x] CLI
[ ] Datastore
[ ] Docs
[ ] Distributor / Event Broker
[ ] Helm
[ ] Istio
[ ] Jmeter
[ ] Kubernetes Integration
[ ] Openshift Integration
[x] REST API
[ ] Webhook

Describe the bug

It is not possible to add bigger resources to Keptn via the Keptn CLI or the go-client.
All resources seem to be limited to around 768KiB and will be rejected with the following message:
Adding resource random-ascii.txt to all stages of project test-project
Error: Resource random-ascii.txt could not be uploaded: invalid character '<' looking for beginning of value
-----DETAILS-----
<title>413 Request Entity Too Large</title>

413 Request Entity Too Large

nginx

To Reproduce

Steps to reproduce the behavior:

Create a random file, I used the following command to generate a random ascii file:
base64 /dev/urandom -w0 | head -c $((1024*1024)) > random-ascii.txt
Add the generated file to a already existing keptn project: keptn add-resource --project=test-project --service=test-service --all-stages --resource=random-ascii.txt --resourceUri=random-ascii.txt
See error

Expected behavior

Adding bigger resources to a Keptn project should work and not display an error.
Current behavior

Adding big resources yields an error
Additional context

We have a use-case for the job-executor-service which requires us to upload multiple bigger (>1MiB) files to Keptn, such that they can be used in the defined jobs. With the current behavior this is not possible.

Thank you for the report @Raffy23. For the moment, I would suggest changing the nginx.conf configMap adding client_max_body_size 5M; to the server directive of Nginx.  Please change the size according to your requirements.


performance of QAT with openssl-3.0 / 3.1 vs. openssl-1.1

Has anyone compared performance of ssl offloading using  openssl-3.0 ?
we run test using  ECDHE-RSA-AES128-GCM-SHA256 and observe at least 30% degradation in transactions/second in comparison with same software based on openssl-1.1.
can you please advise where to look for the sourse of the problem?
thank you!

Is the ECDH curve used is X25519 ? If yes, drop is expected as X25519 is not accelerated in OpenSSL3.0 engine due to known issue https://github.com/openssl/openssl/issues/19047

i would like to ask about PRF offloading, please.
i see this code in e_qat.c:
ifndef QAT_OPENSSL_3
 if (!ENGINE_set_pkey_meths(e, qat_pkey_methods)) {
      WARN("ENGINE_set_pkey_meths failed\n");
      goto end;
 }

endif
i also see that in my test, functions such as qat_tls1_prf_ctrl are never called.
can you please tell why qat_pkey_methods are disabled in openssl v3 ?
Thank you!

It is disabled due to known issues. We are working on fix in the qatengine and in the openSSL PR below to enable pkey methods in OpenSSL3.0 Engine.
https://github.com/openssl/openssl/pull/20680

when we compared performance of openssl 1.1 and 3.0 , we noticed  a significant degradation, and the most obvious possible explanation is that PRF is not done in hardware. Therefore we are looking for this feature.
The  curve (X25519/X448) is not in our focus at the moment.
when you say "it might be possible PRF will still be not enabled", does it mean it is not going to be available is 3.0 / 3.1 at all?
can we do antything about it?  where we can learn  more about  these "known issues" with PRF offloading?
many thanks,
Vitaly

We are working on the fix/workarround at qatengine. I will keep you posted.
Below is the limitation at openSSL that I am talking about
https://github.com/openssl/openssl/issues/19047

Thank you very much for your reply.
I read in this thread  that you said "There is provider and engine implementation in hardware. Our intention is to get OpenSSL default methods for fallback scenario".
does it mean that we may get full QAT functionality (including PRF offload) if we load "qatengine" provider (instead of "default" or "legacy")  rather than load ENGINE "qat"?
thank you!

@vitalyk-radware Yes Provider supports full functionality but we didnt test with any real time application apart OpenSSL's S_Server as we don't have any application (Nginx, Haproxy) that supports provider yet.

curious, does qat engine support both openssl 1.1 and openssl 3.0/3.1?
or openssl 1.1 only support qat engine while openssl 3.0 has to switch to qat provider?

We use openssl 3 with Engine.
It is deprecated perhaps, but it works.
From: Zhangfei Gao @.>
Sent: Thursday, May 23, 2024 12:54 PM
To: intel/QAT_Engine @.>
Cc: Vitaly Kroivets @.>; Mention @.>
Subject: Re: [intel/QAT_Engine] performance of QAT with openssl-3.0 / 3.1 vs. openssl-1.1 (Issue #236)
CAUTION:External Email, Do not click on links or open attachments unless you recognize the sender and know the content is safe.
curious, does qat engine support both openssl 1.1 and openssl 3.0/3.1?
or openssl 1.1 only support qat engine while openssl 3.0 has to switch to qat provider?

Reply to this email directly, view it on GitHubhttps://github.com/intel/QAT_Engine/issues/236#issuecomment-2126697370, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6ECPGOLPRDSWWOVVAS4VL3ZDW4C5AVCNFSM6AAAAAAWCJFSU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGY4TOMZXGA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

We use openssl 3 with Engine. It is deprecated perhaps, but it works.

Thanks @vitalyk-radware

Hi vitalyk,
May I ask have you fix the issue that PRF not offload for qatengine  api ?
we are facing the same issue that when apply Openssl3 + QAT Engine:

if choosing provider, but provider no support engine ctrl message , so no external polling etc.
if choosing engine api, the performance issue (prf not offload)

Thanks

Hi ,
No , we have not solved these problems.
Regards,
Vitaly
From: wangzhaohui_sfsh @.>
Sent: Tuesday, August 6, 2024 8:14 PM
To: intel/QAT_Engine @.>
Cc: Vitaly Kroivets @.>; Mention @.>
Subject: Re: [intel/QAT_Engine] performance of QAT with openssl-3.0 / 3.1 vs. openssl-1.1 (Issue #236)
CAUTION:External Email, Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Hi vitalyk,
May I ask have you fix the issue that PRF not offload for qatengine api ?
we are facing the same issue that when apply Openssl3 + QAT Engine:

if choosing provider, but provider no support engine ctrl message , so no external polling etc.
if choosing engine api, the performance issue (prf not offload)

Thanks

Reply to this email directly, view it on GitHubhttps://github.com/intel/QAT_Engine/issues/236#issuecomment-2271763172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6ECPGJQD5AR6NUV3OLN7O3ZQD76DAVCNFSM6AAAAAAWCJFSU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRG43DGMJXGI.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Append UPC/EAN Extension to barcode

Appends the UPC/EAN extension to the scanned barcode.

AVFoundation doesn't support scanning barcodes with extensions like EAN3/5. Therefore, i see not the possibility to implement this in the iOS version.


use demands to select OS for azure pipelines

https://docs.microsoft.com/en-us/azure/devops/pipelines/process/demands?view=azure-devops&tabs=yaml
because this is ugly
https://github.com/swharden/ScottPlot/blob/6c2bb50cfa6f7caef2d08983003da1158ac5addc/dev/devops/azure-pipelines.yml#L42

abort! these goes in the pool, not tasks


Add legend to gradient plot

While adding legend to gradient plot, the issue #8 arose. Pausing work on this style (stat_gradientinterval) for now and moving forward with stat_interval and/or geom_interval to have more manual control over the confidence levels plotted.
If this stat_gradientinterval gets picked up, I was working to add legend as a second ggplot2 with cowplot. Left to be done:

Fix "mean" label in legend
Add bracket for CI in legend
Resize legend and all text
Add label for Temp threshold in legend
Other general cleanup and scaling
Maybe change alpha back to 0,1?

Current plot:

(the "merge in CI dataiMerge..." commit was the weird one that took the :wq to fix.)

Ok, I reworked the pipeline so that the data are processed upstream, the plotting function is generalized, and then one plotting function actually creates the png with plot and legend.
I'm stuck though on one weird issue - the mean and threshold line are not showing on top of the gradient in the legend, and I cannot figure out why.

I will continue to refine annotation, including adding the min/max bracket, in the future.


Allow entering shorthand repository url

Hello,
As well as inputting https://github.com/microsoft/vscode-remote-repositories-github to Open remote repository, allow writing microsoft/vscode-remote-repositories-github.

If you select the 'Open Repository from GitHub' option,

the next step is a search picker where you can enter a repo name, optionally prefixed with the repo owner:

@joyceerhl
You are right. I had to wait a bit for the search feature to boot up.

We have had many similar issues where people want to put in a repo URL in the search picker, or enter a search in the repo URL. Wondering if we should reconsider the picker UX here
Currently the first step in the remote repository picker displays 'Open Repository from GitHub', 'Open Pull Request from GitHub', and then a cached list of recently-opened workspaces (various repos and various PRs, etc). We could merge those two steps, though it might make the queries slower.
/cc @lszomoru

@joyceerhl
Another idea. I have a file with a bunch of repo names like;
react-workspaces/react-workspaces-playground
bahdcoder/testingreact.dev
bradtraversy/vanillawebprojects

Is there a way to have vscode read line in from that file? Another solution would be to copy/paste a multiline string and it'll parse each line.
I would use that.


Can't tap cell in token cards screen near the bottom

Probably because the currently 0 button ButtonBar is trapping them? Check again after #1832 is merged

Check after #1832 is merged

@hboon can u tell me what ViewController it is, because for now its not clear what i need to check?

meybe u mean this one?

I probably mean TokensCardViewController.

Closed by #2132


Add .dart_tool to default .gitignore

See:
https://github.com/dart-lang/site-www/issues/444
Dart picked this up, but it's not part of the default .gitignore for flutter create.
This means that packages that are run during development time create crud in these folders that gets checked in, for example:
https://github.com/timsneath/dadjokes/tree/763d72bf0da6fe5c37db5c9aedc7420ec92d7927/.dart_tool/pub/bin

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/.gitignore.tmpl#L25
It is already added to the default .gitignore for flutter create

Doh! Rookie mistake from an experienced PM :) thanks - I somehow missed this.


Board View should be able to group by List (tags)

What would you like to be added?
When adding a Board view, we should be able to group notes by tags.
Why is this needed?
AS tags can be easily used to mark related notes, they should be used as a grouping option.

Could you elaborate on how you'd expect the feature to work?
If I understand correctly, you'd like to group by a list field instead of a string field?
For example, a note can have multiple tags. Would you expect the note to be present in all the columns?

Correct, didn't think with that constraint in mind. Would it make sense to present the note in both columns?

Whether it makes sense would depend on the use case. Might be better as a separate view.

I'm available to help with this feature and I will have a look on other features also 😊
On 9 Nov 2022 at 08:03 +0000, Marcus Olsson @.***>, wrote:

Whether it makes sense would depend on the use case. Might be better as a separate view.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Maybe not grouping by ANY tag, but if we use #story/idea #story/draft #story/final #story/published, being able to group by #story and have a separate lane for each subtag would be great.

Another benefit of including non-text fields is the ability to leverage the links in Obsidian.  For instance, in a text field it seems only one [[file]] can be linked, whereas in a list type, multiple obsidian links can be used.  This could be leveraged for sorting features.  In my use cases, this is superior to tags.  However, the general idea would be similar I think.
An example would be for a sales lead database (similar to a CRM database functionality).  Perhaps I have a number of meetings with different customers and make a note for each meeting. I would have a "customer name" and a "product" property field with type = list.  I track the "customer name" interested in products within my portfolio.  Most of these customers would be interested in more than one "product." So, I use a list-type and include each product name as its obsidian [[link]].  Ideally, I'd then like to be able to sort the board status by the "product" property field by the product name in a board view.  This would then give me columns of each product and the customers interested.
I'm an in-experienced programmer and thus can offer little support in this manner, but I'm happy to help support evaluation if some fresh eyes would be helpful.
Thanks for your work on this plugin, it is very useful.

I've just start to use Obsidian and Projects so maybe this will be wrong assumption but when I seen status as a text field I immediately changed to the list because then I can choose from all statuses when editing note.
I was surprised that board columns are gone by changing filed type. I think that note should appear in column by first item of the list but I think that user just can pay attention to have one value in the field. Both ways would work for me.

Could you elaborate on how you'd expect the feature to work?
If I understand correctly, you'd like to group by a list field instead of a string field?
For example, a note can have multiple tags. Would you expect the note to be present in all the columns?

I have all my properties lined up as lists:
Examples:
[[Natural planning model|NPM]]-StatusList - Anstehende Aktion - gewählt ohne Tag aufgrund von Projects Arbeitsweise:
toProcess
toBrainstorm
toOrganize
toPlan
toExecute
done
cancelled
Projektstatus
01-new
02-icebox
03-backlog
04-inProgress
05-inReview
06-done
Dringlichkeit: == zeitbezogen
21-someDay
13-thisYear
8-thisQuarter
5-thisMonth
3-thisWeek
2-Today
1-now
Wichtigkeit: == einflussreich
13-lowest
08-low
05-normal
03-medium
02-high
01-highest
So having lists available, would solve a lot of pain points for me. Would be huge if this could be included.
I think #849 mentions the same thing.

#853 also mentions this apparently.
And the change could be marginly small?
https://copilot-workspace.githubnext.com/marcusolsson/obsidian-projects?shareId=884ad9ac-1ec0-46fe-bc15-76414caab273
Or am I missing something? @Acylation

I am also interested in solving this problem.  Of course, I would prefer the note to be in only one column. You can select the first value in the multiple list. Ideally, when dragging, replace the previous first value with the new one.


collectible-996 missing

Hey, the collectible-996(Global Offensive Badge) is missing from https://bymykel.github.io/CSGO-API/api/en/collections.json
Also i noticed, that the provided links items_game.txt and csgo_english.txt are not existing anymore, i think they've changed the repository structure.

Yeah I need some free time to add the new CS2 items, I will add this one quickly cause is only one item.
Also I need time to update de README and docs. I got the items_game.txt and languages from this repo.

Thanks!

Deployed https://cs2-api.vercel.app/api/items?id=collectible-996

Do you also have different resolutions of the image? And what is the new item path? The old one was C:\Program Files (x86)\Steam\steamapps\common\Counter-Strike Global Offensive\csgo\scripts\items iirc

Do you also have different resolutions of the image?

No

And what is the new item path? The old one was C:\Program Files (x86)\Steam\steamapps\common\Counter-Strike Global Offensive\csgo\scripts\items iirc

items_game.txt is inside Steam/steamapps/common/Counter-Strike Global Offensive/game/csgo/pak01_dir.vpk and the translations in Steam/steamapps/common/Counter-Strike Global Offensive/game/csgo/resource. I haven't found the images in game files yet.

Thanks. Found it.

If you find the images let me know 😅

I'll do. I only found the images in the .vpk file.

In what vpk file have you wound the images?

In what vpk file have you wound the images?

Under C:\Program Files (x86)\Steam\steamapps\common\Counter-Strike Global Offensive\game\csgo\pak01_dir.vpk

You are right.
With ValveResourceFormat you can export them.
decompile and export:

Image i got:

Yes. How do you automate these tasks for your github repo if i may ask?

The tool VRF has also a CLI. So you can do this:
C:\Users\name\Desktop\Decompiler-windows-x64\Decompiler.exe --input "D:\Steam\steamapps\common\Counter-Strike Global Offensive\game\csgo\pak01_dir.vpk" --output D:\csgo_images -e "vtex_c"

This is an example on how to export them, the CLI should have something to also decompile them to .png.
In this issue I explain how to get de CDN url from the image (this might not work in CS2, i haven't test it)

Thanks!

This is the command


feature/AOAF-347-add-cookies-banner

Enable cookie banner again.
Have english and welsh wording on the cookie banner.
single test to see if it present on page

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


Exporting children (paranted objects) of linked objects dosn't wokr

Describe the bug
If you have objectes (dosn't matter if they are linked, append or not eather) paranted to a linked object in the scene when you export it dosn't export them. It dosn't matter what check box you check for the "include" setting on export the same problem is present on all or non of them. I did notice that if the parent is an appended object it works as it should.
To Reproduce
Steps to reproduce the behavior:

Make a blend file with a cube in a collection.
Make another blend file and link that object.
Make a cube and parented it to that linked object.
Export the file as glTF and see that it only exports the linked object not it's child.

Expected behavior
I would expect for all the childer of a linked object to be exported, the same way is works if the object is appended.
.blend file/ .gltf
BTest.zip i added some animation to the cubes, but the probelm is the same without it
Version

OS: Windwos 10
Blender Version 3.5.0 blendeer 3.5 relese version.

Additionly information
It dosn't exort consecituve childer eather, so if you have an object paranted to another object paranted to a linked one.

Confirmed.
I will check it soon


"apt preferences" recommendations to exclude distribution packages won't work internationally

The text currently says:

Make sure to replace  with your distribution's package source, for example, on Ubuntu you would use archive.ubuntu.com.

This probably works in the US, but elsewhere the origin might be different.  In the UK it is "gb.archive.ubuntu.com", and "archive.ubuntu.com" on it's own doesn't work.  Setting "*archive.ubuntu.com" as the origin does seem (at this stage) to work:
Package: dotnet* aspnet* netstandard*
Pin: origin "*archive.ubuntu.com"
Pin-Priority: -10

I'd also suggest mentioning that:
apt policy dotnet-host

(or similar) can be used to verify the priority that has been set.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1287004d-fed0-7cf8-e9ac-c4529bd7e010
Version Independent ID: 73ed52b3-4e26-9840-ae78-14983c6a07c5
Content: Troubleshoot .NET package mix ups on Linux - .NET
Content Source: docs/core/install/linux-package-mixup.md
Product: .net
Technology: dotnet-installation
GitHub Login: @omajid
Microsoft Alias: dotnetcontent

@mirespace Can you help us verify this suggestion?

cc @adegeo

Hi!
I've been researching a bit to double-check the use of wildcards in the Pin field because, to my knowledge, it was allowed only for the Package field (https://wiki.debian.org/AptConfiguration#line-138). I didn't find anything else specific to this, and the fact is that the wildcard works (maybe only in bash).
Therefore, to play it safe, I would suggest replacing <your-package-source> with the output of
apt-cache policy '~ndotnet.*' | grep archive.ubuntu | cut -d"/" -f3 | sort -u
(I'm using  '~ndotnet.*' because it works both zsh and bash).
I really like the suggestion about the use of apt-cache policy for checking the preferences have been set properly (good point!)

Sorry to throw another spanner in the works, but something that I hadn't thought about until now is that Cloud service providers will typically apply a cloud config that defines a mirror rather than anything "archive.ubuntu".
An example line from an apt sources.list might be:
deb https://mirror.hetzner.com/ubuntu/security jammy-security main restricted

Perhaps a text caveat might work, or the (suggested elsewhere in bug reports external to this github project) option of making microsoft sources a very high priority, rather than ubuntu sources a low one?

Nothing to sorry about!
Mmm... in that case, and because with the above command we are only checking for sources that contain dotnet packages, it would be safe to filter by '/ubuntu' instead of 'archive.ubuntu', without taking into account the packages from microsoft. So, the command according to these changes would be the following one:
apt-cache policy '~ndotnet.*' | grep -v microsoft | grep '/ubuntu' | cut -d"/" -f3 | sort -u
And create entrances in the apt_preferences file accordingly (i.e., in the case he/she has the security pocket available -set on source.list- , maybe two urls can come on the output).


Major refactoring and new API (among others for compat with Julia v0.5 and above)

Dear Abe,
since the code before this pull request did not work with Julia 0.5 and above, I spent the better part of my holidays recreating the library design. The new design does not hook into julia's own parsing logic (via macros) anymore and is - I believe - more clearly structured.
After having done quite a lot of work on this, I came to realize that the license file was actually just a copy-paste from Cairo.jl and thus didn't even apply to PEGParser.jl. I believe however that it was your intent to put the code under MIT license (as Cairo.jl is). I have updated the license file accordingly. If I am mistaken on this, please let me know and don't accept the pull request. While being at it I allowed myself to add my name as well as yours to the license file (because I feel that my work is a considerable contribution to the code base :) ). You are very welcome to integrate all of my work into the code base (i.e. accept this pull request) under the premise of keeping my name in the license file.
As the API has changed rather drastically by this refactoring I suggest one of two ways to go:

accept the pull request (including updated readme, examples, tests,...) and tag the HEAD as a new major release to inform users of the library about the possibly breaking changes (in this case tagging to 0.2.0 or even 1.0.0 as you see fit)
do not accept the pull request and I will register the code as a new Julia package

The second options may seem to have the advantage of not requiring any code update to packages using PEGParser. Let me just note in passing: These can only be comparably old codes which have not yet updated to j0.5 or j0.6, anyways. But feel free to decide and let me now which of the two works best for you.
Have a nice day,
Henry

Hi Henry,
I'm more than happy to accept any changes (especially ones that keep PEGParser current, as much of my time is currently being spent on other projects). However, I think one of the biggest strengths of PEGParser over other similar libraries, is the use of the macros over the strings. It has the advantages of: (1) the grammar can be checked at compile time; (2) no separate grammar parser is required; (3) macros (and multi-dispatch) are one of the core strengths of Julia.
If you wanted to commit changes that kept the macros, but still upgraded things for v0.5, that would be a clear path forward for PEGParser. If you rather keep the string-based approach, it probably makes more sense to start a new projects.
Thanks for all the work!
A

Hey Abraham,
Thank you for clarifying. I see your points. I guess it does make sense to have both designs/packages then. If you agree, I will publish the rewritten code as a new package under the MIT license naming both of us. Is that ok with you?
Best regards,
Henry

I hope you can also cherry pick your commits that fix the licensing info for PEGParser.jl and make it work for v0.5 (Maarten [Heremans, my coworker] and I had previously provided a few fixes and made it work for v0.4).
Also, when/if you make your own version (after squashing that huge number of commits ;-) ), what would you name it (since it is incompatible with the original PEGParser.jl)?
Note: I think at least one of Abe's concerns can be addressed by simply adding:
macro grammar_str(str)
    Grammar(str)
end

so that the grammar checking is done at compile time.

I agree with @ScottPJones, it would be really appreciated if you could do a PR just for the changes to get PEGParser compatible with v0.5 of Julia.
Also, if people are using the library, I can devote a little time this weekend to getting the library upgraded. I haven't used Julia for a while now, so unless an Issue or PR comes along, I won't know things need to be fixed.

I think we are still using the library (at work, not me personally), but we're still on v0.4.7, which is why we haven't made a PR for moving to v0.5 or the dev v0.6 yet.

Abe, what do you think about moving it to the JuliaString org (I don't know if another org would be more applicable), if you currently are not using Julia (I hope that changes in the future ;-) ), so that that sort of maintenance can be done without you having to get involved. (I think you'd still have commit access on that repo, or I could add that, if it doesn't happen automatically)

@ScottPJones That sounds like a good idea. I'll likely come back to Julia and happy to continue to support my current libraries, but right now Swift currently has most of my attention.

First of all, thanks to @ScottPJones for the macro idea. Also, @abeschneider thanks for allowing me to put up the rewritten code as a new library. I will of course cite PEGParser at the top of the readme and in the license.
I'm very sorry that I haven't made myself clear enough in my previous posts. I will try to do better now:
Explanation:
In any of the two designs one first needs to convert a legible grammar-declaration into a Grammar-object. Then this Grammar object and the String are given to parse() for the actual parsing step. The main difference between the two approaches is what to use for the first step.
The orginal approach uses the julia language parser itself during the first step by first having the declaration parsed as an expression (begin ... end) and then modifying this by the @grammar-macro.
This was no problem when switching from j0.3 to j0.4, so only String had to be replaced with AbstractString everywhere. But this time something in the principal parsing logic of julia seems to have changed (probably due to the introduction of "all functions having their own type"). This means that I wasn't able to find what had to be changed in a reasonable amout of time.
The new design in contrast builds a grammar from the low-level functionality of the library once. This is then used to parse declarations into Grammar-objects for all further grammars. Because this low-level functionality only depends on functions and types and not on how julia itself parses its expressions this is much more robust against changes of the language. E.g. I rewrote the design on j0.4 and when I tried it with j0.5 it just worked.
Conclusion:
It is not possible to cherry-pick the things that fix the original design for j0.5 from my code, because I didn't ever get that design to work in j0.5. Maybe @abeschneider can fix it, but for me it seemed much easier to simply take an approach which is not so deeply nested with the julia-internals.
I hope you will manage to fix the current code for j0.5 (for an example of where it fails, simply try the examples in the readme). While I understand the elegance of using the julia-parser, I believe there will always be a need for easily maintainable code, too. So I will put the new code up as a separate library. As it is a String-based parser for Strings I will probably name it "StringParser.jl". Any better suggestions? Also, I will link this discussion in the beginning of the readme, so people can better decide which code to use.

I think the name "StringParser.jl" might be a bit too general.  Maybe "StringPEGParser.jl"?
(since PEG parsers can't handle CFG grammars, for example)

OFF-TOPIC: @abeschneider I'd be interested to hear about your explorations into Swift.  I'm also interested in it (I based my StringUtils.jl string literal syntax off of Swift's string literals, much cleaner than C's, IMO, which Julia copied pretty much without change, except for the $ interpolation (which I dislike enormously!))

@vonDonnerstein Okay that makes sense. When I originally wrote PEGParser, there wasn't much in the way of tools for working in macros. I suspect this has changed, so one option is to switch to using a well defined library.
@ScottPJones I really like Swift.  The major plus sides: (1) also built on the LLVM so can be both an interpreted and compiled language; (2) Unlike Java, takes many of the powerful features of C++ and simplifies them in a nice way (e.g. generics in Swift are much closer to Templates, but have constraints [whereas c++ still doesn't have Concepts]); (3) It has really nice operator-overloading semantics; (4) While it doesn't allow for multiple inheritance, a mix of Protocols and Extensions are a nice alternative.
Most of my free time has been spent writing a Tensor library in Swift (https://github.com/abeschneider/stem)

Hi! I'm sorry it took me so long, but I have finally published the String based variant as discussed. I've called it StringParserPEG - similar to ScottPJones' suggestion. This pull request is therefore no longer necessary and I'm closing it now. Thanks again everyone!

:clap:


OCPBUGS-4983: Regenerate client certificate on subject change

MicroShift uses this library to generate certificates, including the kubelet certificates.
The subject part of the certificate is used to authenticate the kubelet and limit the permissions on what can access. On a host name, the client certificate was not being regenerated, so the kubelet could not create a new entry for the new hostname, and blocked on a loop.
This commit forces the regeneration of the client certificate when the subject field on the disk file differs.
(cherry picked from commit bf4ec512c632fc58304927448bac6c34d744d882)

@stlaz here is the backport

/jira refresh

/retitle USHIFT-573: Regenerate client certificate on subject change

/jira refresh

/bugzilla refresh

@benluddy this is still asking for a bugzilla. OCPBUGS created. Is it possible to merge now?

/jira refresh

/jira refresh

/jira refresh

/jira refresh

/lgtm


Amend tests

Select 500 employees from the Employees database, for each of them show all of their salaries and all the departments they belong to.

It would be also interesting to know number of queries queried (especially useful when doing nested loops on the entities).


[C++] single quotes in numeric literals are parsed incorrectly

VSCode Version: 1.6.1
OS Version: Ubuntu 16.04.1 LTS

Steps to Reproduce:
Open a .cpp file with a literal with a single quote in it:
constexpr int a = 100'000;

int main() {}

Expected result: The main function should be highlighted as normal.
Actual result: Everything after the single quote is formatted as if it was in a string literal.
See integer literal (and floating point literal) on cppreference for the details about numeric literals in C++.

This issue was moved to Microsoft/vscode-cpptools#312

In the future please file extensions specific issues against the corresponding extension itself and not against VS Code.


depthai-core deadlocked in semaphores with OAK-D-Pro-PoE after 100+ connections,

See https://github.com/luxonis/depthai-core/issues/415
When that repro case is run with depthai-core v2.27.0 for hundreds of connects, the app will eventually hang and not respond.
This is an improvement from #415 when the test failed with only 6 connects.
One test deadlocked in 135 connects. Another test it took 402 connects to deadlock.
The OAK-D-Pro-PoE responds to pings. The device itself could be ok.
The problem appears to be a deadlock in XLink semaphores. By running the test in a debugger I can see 6+ threads and they are all infinitely waiting on XLink semaphores in sem_wait(). Something is not signaling them.

I have isolated and fixed a group of XLink bugs within its Windows implementation for semaphores, pthread conditions, and clocks. After applying multiple fixes, OAK PoE failures declined by a magnitude 🌠
A test run with fixes was able to make 2897 connections in 6.5 hours before failure. At the point of failure, VSCode itself failed and therefore I did not have access to the debugger. I am unclear if VSCode failed and killed the test process, or if the test process died and affected VSCode. Still, the test wrote a CSV log and I see its results...2897 successful test runs in 6.5 hours.
The OAK-D-Pro-PoE in the test has the recent bootloader 0.0.28 from https://github.com/luxonis/depthai-core/releases/tag/v2.26.0. Applying this firmware alone did not have any measureable affect in connection reliability. The magnitude improvement was due to Xlink bug fixes.
There may still be an OAK firmware/bootloader problem. The OAK-D-Pro-PoE after the test failure did not pass spot testing, even after it having no client communicating to it for 2 hours.

can be IP pinged and responds to that ping
XLink example list_devices reports status: X_LINK_SUCCESS, name: <IP_ADDRESS>, mxid:<PHONE_NUMBER>8EF50800, state: X_LINK_BOOTLOADER, protocol: X_LINK_TCP_IP, platform: X_LINK_MYRIAD_X
But it may not be healthy. depthai-core test xlink_roundtrip_test fails withC:\njs\depthai-core\build\tests>xlink_roundtrip_test.exe
Randomness seeded to:<PHONE_NUMBER>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xlink_roundtrip_test.exe is a Catch2 v3.4.0 host application.
Run with -? for options
-------------------------------------------------------------------------------
Test XLinkIn->XLinkOut passthrough with random 4000x3000 frame
-------------------------------------------------------------------------------
C:\njs\depthai-core\tests\src\xlink_roundtrip_test.cpp(60)
...............................................................................
C:\njs\depthai-core\tests\src\xlink_roundtrip_test.cpp(60): FAILED:
due to unexpected exception with message:
  No available devices (1 connected, but in use)
===============================================================================
test cases: 3 | 2 passed | 1 failed
assertions: 3 | 2 passed | 1 failed

I repeat that "may not" because the xlink_roundtrip_test test itself has a bug. The depthai device search method occassionally fails with an OAK PoE device. The OAK PoE can not always complete its reboot fast enough for this roundtrip test. I can readily reproduce random failures of this roundtrip test on my OAK PoE sensor even after power-cycling it. Changing envvar DEPTHAI_SEARCH_TIMEOUT=10000 does seem to help...I was not able to readily reproduce a fail of this roundtrip test with the longer timeout.

That's great to hear @diablodale!
Would you be willing to open a PR to XLink repository with the changes you've made, so we can verify&mainline the fixes?

No PR. Same answer as in March

I don't provide code or detailed bug reports to Luxonis anymore. Your team didn't move on my high-quality PRs and bugs so I retracted/closed many of them and not doing that anymore. themarpe can bring you up-to-speed if you need details.

Fixes are passing my reliability tests. Last test ran 4126 iterations of continuous connect, get data, disconnect, repeat with an OAK-d-pro-poe. Zero delays, errors, faults, or freezes. All data streams valid. The sensor also continued correctly with manual testing after this 4k run with a few casual tests.

fixed a few more bugs in the xlink platform-wide semaphore code
added an xlink TRACE log level, and moved the env var read of XLINK_LEVEL from depthai-core to xlink itself.
tidyed some xlink log levels and text to use TRACE to make the logs more usable in deep work like I did this week
xlink is very bad at returning correct result values from functions. Often incorrectly mix xLinkPlatformErrorCode_t, XLinkError_t, POSIX, and native OS result codes. They are not the same integer values and can not be mixed without conversion. Zero and non-zero is not good enough -- xlink branches based on specific error int values. I found dozens of these bugs when I re-wrote the xlink USB code. And found more this week in the semaphore code.

This issue should give your team enough info to look and fix your code.


Change nsinit root to /var/run/nsinit

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

LGTM

@crosbymichael @avagin
LGTM.  Although now I understand how it works, it's a good idea to change the default value so others won't be confused.
By the way, I think the Checkpoint() and Restore() APIs will be more flexible if the CRIU images directory was passed in.  If nil is passed in, it can use filepath.Join(c.root, "checkpoint").  But if it's set to a particular path, that would be the images directory to use.


Example Game

Hello!
Love the project, bravo!
I was wondering if there are any example games / boilerplate for seeing this plugin in action / something to kickstart my own game prototype?
I'm new to phaser but I've been ruined by yeoman, bower and npm for how easy it is in my job to start a new angularJS application.
Thanks,
Lewis

Hi,
Did you check out the examples on the website ? http://rotates.org/phaser/iso/examples/
They will get you started :+1:

Good call, thanks for reminding me.
I did check those out, I was just fishing for something like what you have on the website's home screen to get a big step closer to prototyping a tactics ogre / final fantasy tactics advance -esque game I've had on my to do list for a long time..
Would this library fit that kind or role or have I missed something when I've read through some of the docs.
Lewis

The examples demonstrate most of the features of the plug-in - there're also some tutorials such as the following:

https://developer.tizen.org/documentation/articles/creating-isometric-world-phaser.js-using-isometric-plugin
https://developer.tizen.org/documentation/articles/using-easystar.js-implement-pathfinding-tizen-game-projects

Finally, the source of the homepage example is unminified and reasonably well commented, though the implementation is pretty specific. You can view it here: http://www.rotates.org/phaser/iso/test.js
I'd suggest you brush up on other more generic Phaser tutorials (of which there are way too many to list) if you're not familiar with it, as the plug-in closely follows the way native Phaser features work - the physics being just a modified 3D version of the standard built-in 2D Arcade physics system.

That was fantastically useful, thank you very much!
I've got a basic version of a 3d tile map working, its just not registering the cursor location properly.
But I think its coming from having to change the syntax of the cursor demo so drastically, I'm using generator-phaser and it separates everything into separate files and uses this. syntax.