[pwrmgr] Don't lock CONTROL until observing core_sleep

To avoid race conditions with WFI and locking the CONTROL CSR prematurely, wait until the transition out of FastPwrStateActive that begins low power entry before locking the CONTROL CSR.
This allows software to clear CONTROL.LOW_POWER_HINT if an early interrupt caused the "core_sleep" pulse to be too short for pwrmgr to capture. Then, subsequent WFI instructions may still choose between full power and a low power mode.
When software wakes up, it must attempt to clear CONTROL.LOW_POWER_HINT, then busy-poll until it reads its value as 0. If pwrmgr triggered low power entry, the CPU will poll until pwrmgr completes the low power sequence. If pwrmgr did not trigger low power entry, the CPU's write will succeed, and the read will immediately return 0.
Also add a test that causes Ibex to decode WFI with an IRQ pending and not issue core_sleep (modified from a submission from @ecgh0). Check for correct recovery of the CONTROL CSR and that software can clear LOW_POWER_HINT.

@johannheyszl @vogelpi I tagged you because this modifies the behavior of the PWRMGR.CTRL.CONFIG.REGWEN countermeasure. Instead of locking immediately upon writing a 1 to CONTROL.LOW_POWER_HINT, the lock now happens when pwrmgr begins the low power entry sequence.

Thanks, @matutem, for the great idea to defer the locking!

Nice work @a-will.
I'd just like to double check my understanding of the scenarios.
When you set the lower power hint and then execute the WFI you have two possibilities:

low_power_entry_i in pwrmgr_fsm is asserted for at least one cycle (low power hint has set and Ibex indicated sleep for enough cycles for a high value to make it over the CDC), so you transition out of FastPwrStateActive and clocks will be disabled. The hint will be cleared as part of this process. You then make your way back to FastPwrStateActive either due to a fall through or because you've actually slept.

low_power_entry_i in pwrmgr_fsm has not yet been asserted and will not be asserted until you execute another WFI. The hint will still be set as we haven't gone through the FSM path that clears it and there's no lock so software can instantly clear the lower power hint.

The tricky bit is in 1. after leaving FastPwrStateActive we begin to disable clocks but it is possible that Ibex could leave sleep before this is done and begin executing code following WFI. In this case we've got a fall through so the clocks will disable briefly and then re-enable. It's this the busy-poll deals with. If we've hit this case then the hint clear after WFI will be a no-op (it will be locked at this point) however we're going to fall through so it'll clear itself. The busy poll then effectively waits until the fallthrough has occurred and we're back to Active with no hint set.
Have I got that right?

Nice work @a-will.
I'd just like to double check my understanding of the scenarios.
When you set the lower power hint and then execute the WFI you have two possibilities:

low_power_entry_i in pwrmgr_fsm is asserted for at least one cycle (low power hint has set and Ibex indicated sleep for enough cycles for a high value to make it over the CDC), so you transition out of FastPwrStateActive and clocks will be disabled. The hint will be cleared as part of this process. You then make your way back to FastPwrStateActive either due to a fall through or because you've actually slept.
low_power_entry_i in pwrmgr_fsm has not yet been asserted and will not be asserted until you execute another WFI. The hint will still be set as we haven't gone through the FSM path that clears it and there's no lock so software can instantly clear the lower power hint.

The tricky bit is in 1. after leaving FastPwrStateActive we begin to disable clocks but it is possible that Ibex could leave sleep before this is done and begin executing code following WFI. In this case we've got a fall through so the clocks will disable briefly and then re-enable. It's this the busy-poll deals with. If we've hit this case then the hint clear after WFI will be a no-op (it will be locked at this point) however we're going to fall through so it'll clear itself. The busy poll then effectively waits until the fallthrough has occurred and we're back to Active with no hint set.
Have I got that right?

Yup! That's right on all counts. :smile:

Oh and we should have a follow PR that updates the pwrmgr docs to explain the proper sleep proceedure


moe_decoder.decoder has no attribute decoder

In train_transitionNet.py line 105
def training_style100_phase():
from src.Datasets.StyleVAE_DataModule import StyleVAE_DataModule
from src.Net.TransitionPhaseNet import TransitionNet_phase,Application_phase
prefix = "Transitionv2"
data_set = "style100"
prefix += "_" + data_set
args, trainer_dict, ckpt_path = create_common_states(prefix)
moe_net = torch.load(args.moe_model)
here torch.load returns a dict object but in TransitionPhaseNet.py line 240 here directly access the decoder in a dict object
        self.decoder = moe_decoder.decoder
which raise the error

After executing "python train_styleVAE.py --test --version YOUR_VERSION --epoch YOUR_EPOCH", the program generates a model by torch.save() in the same folder as the *.ckpt. Could you please try to load this model first?

Yes I do load it from a ckpt file but  the problem is  by using torch.load this function returns a dict object which has no decoder attribute

Try to load the model named by m_save_model_xxx. It located the same folder as **.ckpt

I check the folder and there is no m_save_model_xxx, I use the pytorchlightning load_from_checkpoint instead of torch.load and this worked

It's ok for using load_from_checkpoint.
The m_save_model_xxx is generated by running
python train_styleVAE.py --test --version YOUR_VERSION --epoch YOUR_EPOCH

you may miss the validation step.

Thanks for this information, I do skip this validation step for quicker running the whole process


Preparation: understand files and directories

This isn't installation but some sort of preparation / shell practice.
People should have some understanding of file and directory structure.  mapping terminal to file browser.  Being in or not in a directory.  etc.
I'm not sure if this should go here or somewhere else (like the shell crash course)

Dropping this issue. We will recommend beginners to not follow in the terminal if they are completely new to the terminal.


Adding typehints

What do you think about adding PHP 7.2 native parameter/return typehints?

Added in 1.2.0. Thank for your suggestion.

You're welcome.


Decouple state objects from the reactive graph

Closes #205, first steps towards #161 and #220. This PR will convert the reactive graph away from being represented by edges between state objects, and convert it into a full data structure in memory. The idea is that individual state objects can create multiple nodes in the reactive graph for more granular response to changes.

Nice! This PR might need to update the docs once finished because of the removed types (i.e. Dependent)

Closing this for now. I'll revisit this at a later date.


Release on npm ?

Unless I'm missing something, this component is not on npm (https://www.npmjs.com/package/emberx-file-input), while the other emberx-* (or at least x-select) are. It would be nice to have it there too : )
Thanks for the component !

It's sort of intentional, we're not entirely ready for the public to use this, yet.
We should (hopefully) have a release out sometime next week :)

Good to know! Those helpers have been useful to me, so if you need help on some level (technical or doc, anything), please let me know. Have a nice day !

Annnnd it's happened! :D :tada: v1.0.0 is on NPM now.


export != zip

reflex export --no-zip skips sitemap generation

I think this is covered by PR #3462, can you check ?


User should be able to create a comment on comment

Implement functionality to comment on other comments on front-end as on backend we can just use the comment API with parent Id set as the comment Id on which the child comment is made.

@tatirajurishabh For this functionality what will you be more comfortable with 1) I send you to array containing all child comments and you build the comment hierarchy tree in the frontend or 2) I send you the tree in form of nested JSON and you just write the logic of displaying it?

@R3dIO Ideally the second option, nested comments inside the JSON itself.

Got you! will start implementing it and update the current issue with relevant details.


cli: Interactive release update

I would like to able to do an interactive update of a release on the command line which would fetch the current release, open the JSON representation using $EDITOR, then on save / exit would update the release with my changes.
This workflow will probably be less of a requirement once we have a Flynnfile (#1084).

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


VM Console for oVirt provider stuck in connecting state

Issue description:

VM Console for VMs in oVirt platform stuck in connecting state

When issue occur:

Always when try to open VM console

Is the VM console works directly from oVirt:

With noVNC console options it works

Errors:

Uncaught ReferenceError: RFB is not defined from browser console . File remote_consoles_vnc.js

System information:

Version petrosian-1.20230912222549_a07cb46
oVirt Provider 4.5.6-1.el8

@DavidResende0 Do you recognize this error?  it sounds familiar and we may have already fixed it for quinteros.

@DavidResende0 Do you recognize this error? it sounds familiar and we may have already fixed it for quinteros.

I do recognize it, but I never got around to looking into it (https://github.com/ManageIQ/manageiq-ui-classic/issues/8600)

Thanks. Closing as duplicate of https://github.com/ManageIQ/manageiq-ui-classic/issues/8600


Correctly calculate the elementSize when cache alignment is configured

Motivation:
We need to take the cache alignment into account when we pre-calculate the ementSize otherwise we fail later.
Modifications:

Fix pre-calculation
Add unit test
Fix incorrect unit test

Result:
Fixes https://github.com/netty/netty/issues/11955

In the main branch, the new Buffer API has a copy of the SizeClasses class, where the memory overhead is reduced. That needs to get fixed as well. That can be done in the forward merge, or it can be done as a separate PR if it's too complicated, since it does have a couple of changes to reduce heap memory usage.

I think this should be done in another PR .

@chrisvest PTAL again


⚠ Bofrost.at has degraded performance

In cef3a10, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1215 ms

Resolved: Bofrost.at performance has improved in c7316c0 after 6 minutes.


TypeError: SyncHook is not a constructor on Webpack 5.40.0

Upgrading to 5.40 got:
npx webpack serve
[webpack-cli] TypeError: SyncHook is not a constructor
Package              Current  Wanted  Latest
webpack               5.39.0   5.40.0      5.40.0

node v12.16.0

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.


How to play csgo on the gaming platform after cleaning osiris

Hello, I used osiris to play the official csgo game before, and now I want to play games on the game platform, is it safe to just delete files and clean up the registry?

what?

什么？

Sorry, machine translation is not very accurate.
I want to play csgo, on the game platform because the game platform scans the hard drive, just like Faceit. I used osiris, before to ask how to clean the computer, delete the files, clean the registry, will the computer be safe? thank you.

when u unhook or restart csgo u are safe.

当您解开或重启csgo时，您是安全的。

VAC probably scans your hard drive (I can't confirm that tbh). but it will never convect you for just having the cheat itself without injecting.

i am not sure that VAC scans your hard drive because from scanning hard drive it should also be able to confirm cheat injection ?
and it will a bit too resource consuming ?

i am not sure that VAC scans your hard drive because from scanning hard drive it should also be able to confirm cheat injection ?
and it will a bit too resource consuming ?

The VAC barely scans for modules loaded in the game.


Add ability to test imported columns

Similar to DBT:

unique
not_null

for all the columns of interest

I really really love the idea! Definitely going to put this on the roadmap for the next release (or subsequent patch of it).
If you feel like helping, I'm happy to support you on how you can do that!


What can cause the live activity to not be displayed?

Hey!
Thanks for the great work!
I've tried the example app and it works fine. I also tried to go through the steps on a new project and it worked. But when I try to go through the steps in an existing project. The activity doesn't show up. The activity id gets created normally and If I hooked the creation function call to a button and pressed multiple times I get that the maximum number of activities is reached (as an error).
So is there a unique reason to this?
I've some background modes enabled like remote notification and background fetch. I'm also using Firebase Messaging. Notifications permissions are all setup.
Thank you.

could be a lot of things.

Did you name your attributes LiveActivitiesAppAttributes and have a typealias LiveDeliveryData?
Did you add an app group?
does your Info.plist have "Supports Live Activities" to YES
are you testing on a real device? Does that device support live activities?
It sounds like the createActivity function is being called and ID is being generated so it's probably something to do with the Swift code. Maybe provide some snippets of your widget?

I have gone through your checklist on other issues so yes I have done all that.
I am using the generated example which displays a hello world text in cyan background. And as I mentioned it's working on a dummy project.

@ahmdaeyz did you get an activity id after createActivity ?

@phuchuynhStrong Yes I did get it.

@ahmdaeyz To be clear, are you talking about live activities on dynamic island or lock screen ?

@phuchuynhStrong  Both of them. I'm interested in both. I don't have a 14 pro myself but I have tested the example on the simulator and it was actually working.

@ahmdaeyz can you show the code of ActivityConfiguration ? The place where you did the Ui of dynamic island and lock screen

Have you tried on a real device? What version of iOS? Needs to be at least 16.1

Yes I'm testing on a real device.
The version is 16.3.1
Here's my widget extension in xcode

Here is my code using the ActivitiyConfiguration

Here is the bundle:

I think your WidgetConfiguration is missing compactLeading, compactTrailing, and minimal see:
https://developer.apple.com/design/human-interface-guidelines/components/system-experiences/live-activities/
and
https://developer.apple.com/documentation/activitykit/displaying-live-data-with-live-activities

might be good to wrap the WidgetBundle like so:
    if #available(iOS 16.1, *) {
      WatchlistPriceUpdatesLiveActivity()
    }

other than that the widgetconfiguration looks good. Flutter side did you init with appGroupId?
      _liveActivitiesPlugin = LiveActivities();
      _liveActivitiesPlugin.init(appGroupId: "[YOUR APP GROUP]");

Okay I will add that.
Yes. I initialize the plug-in and then create the activity. And to make sure the problem isn't related to initiation I created a button to create the activity. Still no exceptions. And the id is returned. But no UI on the Lock Screen. Or any sign of a live activity whatsoever.

@ahmdaeyz your code looks fine. Can you make sure Live Activity is enabled in app setting ? (Go to your phone setting -> your app)

@phuchuynhStrong It is indeed enabled. I check several times after creating an activity. Can there be some kind of conflict causing the activity not to be shown?

Do you have added the entry in the info.plist file ?
https://raw.githubusercontent.com/istornz/live_activities/main/images/tutorial/enable_live_activities.gif

@istornz Yes I have added it both to the widget extension and my Runner's info.plist. If I haven't I think an exception will be thrown.

@ahmdaeyz I can't think of any other reason, why it's not working. Make sure you're testing on an iPhone

@phuchuynhStrong Not sure if you are being sarcastic. But be assured I've been testing on an iPhone all along :).

@ahmdaeyz no. I made a mistake by testing the live activities on iPad so I just give you another clue to identify your problem

@ahmdaeyz I'd break down the problem and see where it's failing. So take away all the variables you can and start adding them back. So I'd start with removing Flutter aspect of it and just try adding any native live activity to your project. Can follow some of these instructions https://ohdarling88.medium.com/update-dynamic-island-and-live-activity-with-push-notification-38779803c145 if this fails then you know this plugin isn't the problem and there is something in your project that needs addressed.

having the same issue, everything enabled..
also enabled remote notification
other extension that i have is one signal extension
testing on a new project working fine, but not working on existing projects

@ahmdaeyz @istornz @jolamar
I found a solution, if you have it checked, uncheck "Copy Only When Installing" for Embed App Extension or similar on build phase of main target runner.
Prob need to add that to the readme

Does anyone have any solution?
I have check what @Arepeel said, but mine wasn't not even checked. So, still looking for some help here

I have found the problem.
The problem was the use of images, when I integrate on my project, I've used another images to shown, but they had high resolution compared to the example ones.
Using the resizeRefactor property fix the issue
e.g: teamALogo: LiveActivityImageFromAsset('assets/images/psg.png', resizeFactor: 0.3),

@ahmdaeyz @istornz @jolamar
I also encountered this problem, and as far as I understand, this problem does not depend on specific factors in the iOS module, because I tried the following options: I added live activity to my project, to a newly created (clean) project, and also in a project that attached to the example, I deleted the "target" that was created and tried creating my own new one - my own new one doesn't work.
The steps were carefully followed to those described in the README.md file. (Also, as far as I understand, this is not a problem of this plugin, since this problem also occurs when we do not use this plugin, but try to integrate from live activity directly into AppDelegate)

hi, I was using version 1.7.5, and that version worked well, but when I updated it to 1.9.0, it doesn't work. I don't know why yet
1.9.0 Is there no problem?

hi, I was using version 1.7.5, and that version worked well, but when I updated it to 1.9.0, it doesn't work. I don't know why yet 1.9.0 Is there no problem?

1.8.0 worked well.
Test results indicate that a new installation should not be made in the simulator
My guess is that 1.9.0 is problematic

Hi @soulwawa, could you try to implement multiple notification key system like said on the doc?
This is just to test if this is the problem or not 👍

@istornz It works well if you follow your guide.
I'm worried that there are people who make the same mistake as me.
Thank you for your kind reply.

@soulwawa Thanks for your reply, I will add breaking change in the README.md & CHANGELOG.md file.
This fix was intented to allow multiple notification to work 👍

For clarification and anybody who debugged as long as we did without success:
While migrating to the new version, we forgot to read the instructions carefully.
In our case following code (mentioned in the Readme) did it:
extension LiveActivitiesAppAttributes {
  func prefixedKey(_ key: String) -> String {
    return "\(id)_\(key)"
  }
}

This is used to extract the params:
ActivityConfiguration(for: LiveActivitiesAppAttributes.self) { context in
      // create your live activity widget extension here
      // to access Flutter properties:
      let myVariableFromFlutter = sharedDefault.string(forKey: context.attributes.prefixedKey("myVariableFromFlutter"))!

      // [...]
}

I was dealing with this issue as well. I found in some cases all you need to do is turn your device all the way off and turn it back on

For me it was the issue of versioning in the build settings and mobile version.
My iOS device version was 17.5.1 but the iOS Deployment Target of the widget extension was more than that (18.0.1).
I have changed the extension version to 16.2

+1
PlatformException(LIVE_ACTIVITY_ERROR, can't launch live activity, The operation couldn’t be completed. Maximum number of activities for target already exists, null)


fix downloadlist ip ban because of missing sleep function

Should fix #88

Thanks for submitting a PR!
Please check these off before asking @josephrcox for review.

[ ] I have checked that my code works for downloading text posts.
[ ] I have checked that my code works for downloading image posts.
[ ] I have checked that my code works for downloading link posts.
[ ] I have checked that my code works for downloading posts from more than just 1 subreddit.
[ ] I have checked that my code works with a brand new user_config.json file.
[ ] I have checked that my code does not cause rate limiting when downloading >100 posts in a short period.


Add ability to add new movies

While this is completed, it should have been developed to reload the page with the same query as prior to clicking the add button. Also, the added movie should show as in queue on reload after being added.


Quote paths to handle filenames with spaces for #136

This adds quotes around path names in shell commands, so that files with spaces in their names will not explode.

Merging this should resolve #136

Merging this should resolve #136

Coverage decreased (-2.4%) to 92.857% when pulling f9bbf4407fccf8218c11d10c9787fd2d1b1bb0c7 on BrumfieldLabs:quote-paths-for-shell into bdfa710375711536a49b1d2b616c9c8b51998088 on curationexperts:master.

Coverage decreased (-2.4%) to 92.857% when pulling f9bbf4407fccf8218c11d10c9787fd2d1b1bb0c7 on BrumfieldLabs:quote-paths-for-shell into bdfa710375711536a49b1d2b616c9c8b51998088 on curationexperts:master.


[RFC] Worker unit tests

Requires #38.
[RFC] Added unit tests of Worker, testing multiple functionalities of Worker:

TaskState saving to Transport
Handling of exceptions
Reading back TaskStates from Transport
Trimming generations based on TTL

This is a draft PR, I will work on additional tests (for example: handling of exception within a CQL batch - currently the library handles this incorrectly) and cleaning up the code further.

Not in scope of this PR, but an exciting possibility in the future: In this PR I've made some effort to write mock WorkerCQL, mock WorkerTransport, mock RawChange, which allows us to simulate a simplified version of Scylla CDC (without actually having to run a real Scylla).
We could write a stress tester of Worker, that would randomly generate mock RawChanges and randomly inject exceptions into WorkerCQL or WorkerTransport. It would run for X minutes and check if Worker correctly read all those generated changes. It would be a variant of @kbr- proposal (https://github.com/scylladb/scylla/issues/8350), but without a real Scylla. Comparing to the "unit" tests in this PR, such a test would run much longer (minutes vs <1s), generate more changes (thousands/millions vs 10s) and rely on randomness instead of coming up with very deliberate scenarios (as the tests in this PR).

Other way it will be extended in the future:
Currently I am writing a higher-level API, which reinterprets RawChange into higher-level changes, which sometimes require a bit complex logic (is column frozen? if it is frozen and it is an UPDATE and it is a map, then look at the deleted elements column but only if deleted column is null - you get the point). Having good tests for such logic would be great - so maybe making MockRawChange should be simplified further - currently it is quite tedious to construct MockRawChange (as you can see in this RFC/PR).


allow chat evaluations using LLM-as-a-judge

This PR contains:

[x] New features
[ ] Changes to dev-tools e.g. CI config / github tooling
[ ] Docs
[ ] Bug fixes
[ ] Code refactor

What is the current behavior? (You can also link to an open issue here)
It's not possible to use model-based scorers model_graded_fact and model_graded_qa  to evaluate chats, since they suppose the task solved is defined by state.input_text.
Issue: #685
What is the new behavior?
Using a new parameter, it's possible to specify a solver to concatenate the whole chat history into state.user_prompt, which is then used by the scorers. The solver can also do other transformations of course.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Apart from using user_prompt instead of input_text, there's not breaking change.
Other information:
Does it make sense? I'm open to suggestions of course. :-)

Thanks for this PR! I ended up not wanting to handle this with a passed solver -- I agree this is more flexible, but it's a somewhat unconventional use of solvers and I think perhaps might not be easy for users to discover how to get the desired outcome. I am going to close this PR in favor of:
https://github.com/UKGovernmentBEIS/inspect_ai/pull/738/files
This takes the more straightforward approach of adding an include_history option to model graded scorers. Note that more flexible approach as always possible by just writing your own scorer (which is often what people who are into creating very flexible/powerful custom scorers that use models end up doing).

@jjallaire-aisi
Thank you, yes, your solution is definitely more straightforward to use, and in most cases it's sufficient. I only miss the possibility to customize chat_history function.

I could just make the include_history optionally take a function? Let me try that.

PR for this here: https://github.com/UKGovernmentBEIS/inspect_ai/pull/741


Ini handling broken when passed via output parameter

First, let me please thank you for this action! I think it's awesome and very much appreciate all the work on it!
Describe the bug
I think this is related to the fix which was committed in response to issue #392.
Short version:
Setting ini parameters in a separate step and passing them to the setup-php action using step.stepid.outputs.outputname no longer works.
Long version:
For a project which has to support a large number of PHP versions as well as a large range of versions for a "framework", some PHP/framework combinations will generate PHP deprecation notices.
These do not break the actual product, but do cause a lot of noise in the output of the unit tests, so when running the tests via GH Actions against older versions of the "framework", error_reporting is set to E_ALL & ~E_DEPRECATED, while when testing against the current version of the framework, it is set to E_ALL.
As this needs some logic, the ini-value string is created in a separate step and saved as an output parameter. This output parameter is subsequently used in the next step to call setup-php.
This was working fine until about a month ago (last good run), but started to fail about three weeks ago.
The failing tests were all of the Failed asserting that exception of type "PHPUnit\Framework\Error\Warning" is thrown. kind and could not be reproduced locally, no matter what PHP/framework/PHPUnit combinations were used.
After various test runs and debug trial & error, I can only conclude that it is related to how the ini-values are handled by the setup-php action.
Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
ubuntu-latest
PHP versions
PHP 5.4 up to 8.1
To Reproduce
This is the relevant part of the script:
      - name: Setup ini config
        id: set_ini
        run: |
          # On stable PHPCS versions, allow for PHP deprecation notices.
          # Unit tests don't need to fail on those for stable releases where those issues won't get fixed anymore.
          # Also set the "short_open_tag" ini to make sure specific conditions are tested.
          if [ ${{ matrix.custom_ini }} == "true" ]; then
            if [ "${{ matrix.phpcs_version }}" != "dev-master" ]; then
              echo '::set-output name=PHP_INI::error_reporting=E_ALL & ~E_DEPRECATED, short_open_tag=On'
            else
              echo '::set-output name=PHP_INI::error_reporting=E_ALL, short_open_tag=On'
            fi
          else
            if [ "${{ matrix.phpcs_version }}" != "dev-master" ]; then
              echo '::set-output name=PHP_INI::error_reporting=E_ALL & ~E_DEPRECATED'
            else
              echo '::set-output name=PHP_INI::error_reporting=E_ALL'
            fi
          fi

      - name: Install PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: ${{ matrix.php }}
          ini-values: ${{ steps.set_ini.outputs.PHP_INI }}
          coverage: none

The full script can be found here: https://github.com/PHPCompatibility/PHPCompatibility/blob/43b2b058b7875b249661ce23c62402c72067fa64/.github/workflows/test.yml
Expected behavior
That the ini-values are handled correctly, allowing for the tests to pass.
Screenshots/Logs
See links above in the description for relevant action logs.
Are you willing to submit a PR?
Would love to, but have too much on my plate right now and the hours spend trying to figure out what was going wrong here didn't help.... 😒

@jrfnl
Sorry about this, I missed accounting for error constants. It should not quote them now.
Fixed in https://github.com/shivammathur/setup-php/commit/1686147b24d176ca416781e2af1576dc3ed05ef0
Let me know if the issue is still there.

@shivammathur Thanks for this really quick turn-around on the issue! I'll start a build on our default branch now to confirm the fix.

The builds are turning green again. Fix confirmed. Thanks so much!


List sections in CSFG for NCEA Encryption RSA Cryptosystem guide

Description
The list for sections in the CSFG relating to this curriculum guide is empty and has TODO listed. The TODO should be removed with relevant sections added.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the issue.

[x] I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number)
[x] I have applied relevant labels

This assessment guide is not finished, hence the reason that it has TODO(s) in it.
Consider closing this issue, as it isn't really helpful.


t.Numeric should not convert empty string to 0

I have an HTML <select> that looks something like
<select name="opponent">
<option value="">— Select —</option>
<option value="1">option 1</option>
<option value="2">option 2</option>
</select>

Which I serialize to JSON and sent to the server.
t.Numeric() is converting the values to JS numbers like I want, but it also allows the empty string to go through. It converts it to a 0 instead of rejecting the request.
Can this be disallowed?

Fix with eabe264, available on 0.7.27.
Feels free to reopen if the issue still persists.


YouTube interface acting weird with AmbiLight on

Bug description
Some elements on youtube appear weird (white text on white bg)
Steps to reproduce the behavior
without ambilight on

with ambilight on

after scrolling down

Browser
Chrome
Operating system
Windows
Extension version
2.37.29
The bug still happens in these conditions

[X] The bug still persist when I disable all other extensions (ex. in incognito mode with only this extension enabled)
[X] When I logged out of my YouTube account (ex. in incognito mode)
[X] In incognito mode

Additional context and/or screenshots
No response

@harsharora08 This is probably happening to you because you have set the "Buttons & boxes background opacity" setting to 100%. This causes the background of those boxes to be fully white:

alright got it. fixed.
this happened abruptly today so i thought it was something to do with youtube's rework from the server end.
thank you for the response.

same happened to me out of nowhere. it was the background opacity, eventhough i didnt change it.

Hmm, if there are so many people with this issue then there might be a bug in my migration code between updates.
I'll take a look this weekend to see what could cause this.


function takes only 3 arrays as arguments, last test gives 4 though

Challenge Sorted Union has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function uniteUnique(arr1, arr2, arr3, arr4) {
  //take arr 1 and put it into new arr
  //compare arr2. if item in arr 2 doesn't exist in new arr push it in else ignore it
  //do the same for arr3

  var newArr = arr1;

  for(var item in arr2){
    if(newArr.indexOf(arr2[item]) === -1){
      newArr.push(arr2[item]);
    }
  }
  for(var thing in arr3){
    if(newArr.indexOf(arr3[thing]) === -1){
      newArr.push(arr3[thing]);
    }
  }
  for(var s in arr4){
    if(newArr.indexOf(arr4[s]) === -1){
      newArr.push(arr4[s]);
    }
  }

  return newArr;
}

uniteUnique([1, 3, 2], [5, 2, 1, 4], [2, 1]);

The original function only takes the arguments arr1, arr2, arr3. The last test however looks like this:
uniteUnique([1, 2, 3], [5, 2, 1, 4], [2, 1], [6, 7, 8])

As you can see, those are 4 arrays. I had to add another argument to the function and add another for loop for the last array to get my code to pass.

@Erody
Thanks for reporting this, however this is not a bug and is intentional.
You are expected to derive a a logic using the arguments object.
While your code is technically passing the challenge but it is not Generic (you have fixed no of input args).
Please consult the JavaScript Chat Room for any further assistance to Coding.
Happy Coding!

I had a similar objection to that of Erody.
I realized that the object of the exercise is to force the student to derive a logic using the arguments object, as it is confirmed by raisedadead.
However, it would probably beneficial to have a more generic initial function statement such as :
"function uniteUnique(arr) {" --- (note only one argument, vs three!)
followed by a comment such as
"// Change the code only below this line"
This should force the use of the arguments object.

Yup I do agree with your analogy @DanRom624
/cc @FreeCodeCamp/issue-moderators thoughts? I am in favor of having one input argument.
Any second opinions on this?

@raisedadead it does seem counterintuitive to suggest using the arguments objects but then simultaneously imply to use "just" three input arguments. I'm all for the only one input argument in the function 👍

For those wanting to help, you need to change this line and this line to have just one argument:
function uniteUnique(arr) ...

@erictleung I would like to work on this issue.

@arun1595 go ahead and make a PR, Please, check our Guidelines for Contributing.

@raisedadead I submitted a PR. Can you have a look at it?


Do not enter lightsleep when USB is plugged in

This prevents calls to tidal.lightsleep(...) from actually entering lightsleep if any bytes have been received over the USB interface since the  last reset.

Do we want this check available in upy?

Should tidal.lightsleep give some feedback (either throw or return false) if it’s not actually entering sleep
but yeah also a way to check in python before calling lightslepp sounds goid

Do we want this check available in upy?

I think we might, if tidal_helpers.lightsleep() returns immediately we'll end up spinning in a tighter loop than if we disabled light sleep by calling Scheduler.set_sleep_enabled(False) - roughly 20mA higher power consumption by my very rough estimate.
I was thinking we should maybe have a Scheduler.can_sleep() API which checks that both USB is not being used, and that WiFi is not started, and if either is true fall back to the time.sleep() logic?

if we exposed tud_connected() in tidal_helpers we could have the whole of can_sleep implemented in Python couldn't we? Since we can get time-since-boot from time.ticks_ms(), and I prefer that to using time() anyway (since we aren't configuring the RTC using that seems a bit dodgy to me) and we aren't needing to call tidal_helpers_inhibit_sleep() from any other native code?
Also that makes it easier to temporarily re-enable USB sleep on the devboard (by a quick hack to scheduler.py, I don't need to rebuild a ROM!) which is something I can see myself wanting to do.

@tomsci Moved the logic into Python


Update test vendor with up to date hcsshim and containerd/containerd/log

Fixes issue in package building where building cri-containerd tests causes an error due to not being able to find test/vendor/github.com/containerd/containerd/log.
Updates hcsshim files in test/vendor to be up to date

Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>

Did we just not have everything vendored that needed to be in /test before?

Yep, we were specifically missing containerd/containerd/log

So is this PR basically just running go mod vendor?

We're going to have to be good about remembering to run go mod vendor now that the tests vendor the shim also.

Yes, running go mod vendor in test dir

Great :)


Add And Update .git-blame-ignore-revs

Explain the changes

Add .git-blame-ignore-revs file with the commit hash of the changes (for more information, see here).
Update .git-blame-ignore-revs with commit number from #7264 that contains all file changes (but unfortunately also eslint.js change...).

Issues: Fixed #xxx / Gap #xxx

none

Testing Instructions:

none

[ ] Doc added/updated
[ ] Tests added

@shirady
Can you explain the motivation?

@shirady Can you explain the motivation?

Of course, since I change the files without adding content (formatting them) adding the commit to the file .git-blame-ignore-revs will not show those lines as changed.
I created a repo to demonstrate:
With .git-blame-ignore-revs blame.
Without .git-blame-ignore-revs blame.

The only flaw is that I added eslint.js to the commit...

@shirady Can you explain the motivation?

Of course, since I change the files without adding content (formatting them) adding the commit to the file .git-blame-ignore-revs will not show those lines as changed.
I created a repo to demonstrate: With .git-blame-ignore-revs blame. Without .git-blame-ignore-revs blame.

The only flaw is that I added eslint.js to the commit...

I am not convinced it is actually necessary...
and what if a change to immutable is leading to an issue, why should we ignore it in the blame?

I am not convinced it is actually necessary... and what if a change to immutable is leading to an issue, why should we ignore it in the blame?

There is an assumption that this change should create an issue. I'm fine with leaving it, and maybe creating it in the future (if we would like to).


Is it possible to pass hooks around?

This is my favorite react state management lib, so I decided to try and create a custom halogen hook which does the same thing.
Now the thing is, that lib involves passing state, useState and promap to the child component. Sure, I can pass the actual state, but if I pass the state token and the child uses it to modify the state will it change the state of the parent who passed the token down or will it just error out cause there's no state with that token?
And if it will error out, how could I implement this using outputs & queries instead?

Maybe you could create a bus in your root component, the setState function that you pass to your child could write the new state to the bus and your root component could then update the state inside an useLifecycleEffect handler. Not sure but it might be that https://github.com/thomashoneyman/purescript-halogen-hooks/issues/5 needs to be solved first.

Maybe you could create a bus in your root component, the setState function that you pass to your child could write the new state to the bus and your root component could then update the state inside an useLifecycleEffect handler. Not sure but it might be that https://github.com/thomashoneyman/purescript-halogen-hooks/issues/5 needs to be solved first.

Thanks :D

@Mateiadrielrafael Sorry, I missed this!

Now the thing is, that lib involves passing state, useState and promap to the child component. Sure, I can pass the actual state, but if I pass the state token and the child uses it to modify the state will it change the state of the parent who passed the token down or will it just error out cause there's no state with that token?

The token should associate properly. When you interpret nested Hooks they ultimately all end up in the same component, so the state token should still be associated with the right cell in state.

And if it will error out, how could I implement this using outputs & queries instead?

You can't use outputs and queries in Hooks. Those are specific to parent / child components.
You can replace outputs (which notify a parent component of an event, which the parent can handle) by instead accepting a callback to run when the event happens internally. You can replace queries by returning HookM functions from your Hook, so the user of the Hook can call those functions when they'd like -- either just performing some action, or also returning some data as a query could.
For example (not tested, but basically this):
myHook
  :: forall m
   . (Int -> HookM m Unit)
  -> Hook m (UseState Int) { count :: Int, increment :: HookM m Int }
myHook onIncrement = Hooks.do
  count /\ countToken <- Hooks.useState 0
  Hooks.pure
    { count
    , increment: do
        n <- Hooks.modify countToken (_ + 1)
        onIncrement n
        pure n
    }

Someone using this hook can replace getting an "Incremented" message by passing in a callback "onIncrement" to run when the state is modified. And this hook returns an action, "increment", which both modifies internal state and returns a value, which is a replacement for a query.

Maybe you could create a bus in your root component, the setState function that you pass to your child could write the new state to the bus and your root component could then update the state inside an useLifecycleEffect handler.

This is also an option! If you start to accept a lot of callbacks and return a lot of actions you might want to move to this kind of approach instead to keep things clean especially as you start to get lots of recursively-called functions.

I'm going to close this issue, as I believe the question has been answered, but please feel free to re-open or follow up here if you have more.


Do want the selected text color be black

Seems no way to make this color to be black and also keep the dropdown items in different colors

I can't seem to print the selected item, I set in value my state but it won't show any text

Thanks for question and sorry for delayed reply. Different colors for dropdown items are definitely possible, please use itemColor and selectedItemColor props to override default values.


Repo

When this forks will make it to official linux (opensuse) repo instead of the old 0.4 version from "MrS0m30n3" ?!
The 0.4 is from 2017... It would be about time to make yours the official one....

You are right, it is time to create an RPM-based system version.  It would be helpful to create a specification for openSUSE.  You can check this comment and the packaging for Mageia

@MetaStazz can try and test the home repository for openSUSE Tumbleweed and let us know is work?
sudo zypper ar -cfp 90 https://download.opensuse.org/repositories/home:oleksis.fraga/openSUSE_Tumbleweed/home:oleksis.fraga.repo
sudo zypper install python38-yt-dlg
yt-dlg


webdriver has a build failure with aeson-<IP_ADDRESS>

The build fails due to the removal of Data.Aeson.Parser.
src/Test/WebDriver/Firefox/Profile.hs:33:1: error:
    Could not find module ‘Data.Aeson.Parser’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
33 | import Data.Aeson.Parser (jstring, value')
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Perhaps a Hackage package revision can be made adding an upper bound?

Okay, I added the revision to release <IP_ADDRESS>.
FWIW I got it building in this branch: https://github.com/haskell-webdriver/haskell-webdriver/tree/aeson-2.2-support
Aeson 2.2 moves some functionality to the attoparsec-aeson package. Not sure if we can conditionally require that or something with Cabal.

Let's merge this if it works?

Released in <IP_ADDRESS>

@thomasjm it's not on master yet, it seems, is that on purpose?

Oops, that was a master/main confusion. Done now


Question: Version the C++ implementation under a dedicated repository

Dear @yixuan and @statmlben,
Thank you for this truly magnificent piece of work.
Currently, both https://github.com/softmin/ReHLine-r and https://github.com/softmin/ReHLine-python vendor the C++ implementation.
I think having a third repository (for instance https://github.com/softmin/ReHLine-cpp) version the C++ implementation separately would allow it to:

evolve without having to duplicate contributions on both https://github.com/softmin/ReHLine-r and https://github.com/softmin/ReHLine-python
be packaged as a minimal stand-alone package

What do you think of this proposal?
Best Regards,
Julien.

Hi Julien, you can check out our ReHLine-SVM repository, which is a basically a single-header C++ library. Although it is tagged as an SVM solver, its core part is the function rehline::rehline_solver(), and the SVM solver is a simple wrapper of it. I'll try to add more documentation on the C++ interface, but most of the arguments should be straightforward.

Thank you for your encouragement toward ReHLine! As you pointed out, we share the same rehline.h for both R and Python. Yixuan and I had a quick discussion on incorporating your comments: we are considering to update/expand the current ReHLine-SVM, containing only a single C++ header, into a version as ReHLine-cpp.

Thank you for your prompt answers!
What do you think of having ReHLine be distributed on conda-forge?
It might be possible to distribute it under several packages, for instance:

rehline-cpp (or librehline or just even rehline) for the core C++ implementation
rehline-python for the Python bindings which would depend on rehline-cpp
rehline-r for the R bindings which would also depend on rehline-cpp

If you find it valuable, I can help when I get some time.

Yeah, thanks for the kind help. We are still considering how to refactor the code and repository to make them more structured. Some current considerations are as follows:

The core of rehline-cpp may be just one header file. Not sure if it is an overkill to distribute rehline.h as a separate package.
Python and R packages have their own building system, so I feel that rehline-python and rehline-r do not need to depend on rehline-cpp. It would be easier to just include rehline.h in the Python/R source package.
The Python and R packages are still in their early stages, and APIs may change a lot. It might be more responsible to first stabilize the interface before formally submitting to Conda/PyPI/CRAN.

If you have any thoughts or suggestions, feel free to leave comments here, and we really appreciate that.

The core of rehline-cpp may be just one header file. Not sure if it is an overkill to distribute rehline.h as a separate package.

This would allow people to use it via package manager's distribution.

Python and R packages have their own building system, so I feel that rehline-python and rehline-r do not need to depend on rehline-cpp. It would be easier to just include rehline.h in the Python/R source package.

They indeed do not need to indeed. It might help having the implementation evolve independently from the interface, but this is slightly more involved from a packaging and maintenance point of view.

The Python and R packages are still in their early stages, and APIs may change a lot. It might be more responsible to first stabilize the interface before formally submitting to Conda/PyPI/CRAN.

I agree.
I let you close this issue if you think it is resolved.


Why "followSystemLocale" is not true by default?

I was quite surprised when I realized that isFollowingSystemLocale is false by default. Let me explain my use case, maybe I'm missing something. I want my app locale to match system locale, unless the user specified otherwise explicitly in the app settings. So if the user just launches the app, then changes the system locale, I want the app to automatically change the locale to the system one. If the user then changes the app locale to a different one in settings, I want that locale to stick, so now system locale doesn't matter anymore.
If isFollowingSystemLocale was 'true' by default, everything would work naturally. I would use Lingver.setLocale() only when the user changes the locale in app settings. But since isFollowingSystemLocale is false by default, the first call to Lingver.init() on the first app run persists the locale, and subsequent system locale changes don't have any effect. So to achieve what I want, I need to call setFollowSystemLocale(true), but only on the first app run. Which is doable, but a bit annoying.
At the same time I realize that you probably can't change the default value now, because all apps with Lingver that didn't change followSystemLocale explicitly would start behaving differently.
And thank you for creating the library and publishing that blog post!

Hi, @smokxx
I totally understand your concern and agree that your expectations are natural.
However, isFollowingSystemLocale API was introduced recently and we didn't change this behavior to keep backward compatibility.
I plan to set setFollowSystemLocale to true by default along with the next breaking changes. No ETA, unfortunately.
Until then you have to use the mentioned workaround to achieve this behavior.
Thanks for the great feedback and your interest in the library.
This question will definitely come in handy for other users that face a similar issue.

just a suggestion, I think its possible to check the preference store for the absence of all of the below preference keys as in indication that Lingver has been initialised on a freshly installed app.
        private const val LANGUAGE_KEY = "language_key"
        private const val FOLLOW_SYSTEM_LOCALE_KEY = "follow_system_locale_key"
        private const val LANGUAGE_JSON_KEY = "language"
        private const val COUNTRY_JSON_KEY = "country"
        private const val VARIANT_JSON_KEY = "variant"

This is what i am thinking of doing.
private fun initMultiLanguage() {
       val localeStore = PreferenceLocaleStore(this)
       Lingver.init(application = this, store = localeStore).run {
           with(getSharedPreferences("lingver_preference", Context.MODE_PRIVATE)) {
               // check if Linver is init on a fresh install
               if (
                   !contains("follow_system_locale_key") &&
                   !contains("country") &&
                   !contains("language") &&
                   !contains("variant")
               ) {
                   setFollowSystemLocale(this@App)
               }
           }
       }
   }
   ```

Maybe to both preserve backward compatibility, Lingver can provide a function/method to check if the `store` is a fresh store by doing something like the above and lets dev decide if they wan to manually set the `setFollowSystemLocale(true)`?

just a suggestion, I think its possible to check the preference store for the absence of all of the below preference keys as in indication that Lingver has been initialised on a freshly installed app.
        private const val LANGUAGE_KEY = "language_key"
        private const val FOLLOW_SYSTEM_LOCALE_KEY = "follow_system_locale_key"
        private const val LANGUAGE_JSON_KEY = "language"
        private const val COUNTRY_JSON_KEY = "country"
        private const val VARIANT_JSON_KEY = "variant"

This is what i am thinking of doing.
private fun initMultiLanguage() {
       val localeStore = PreferenceLocaleStore(this)
       Lingver.init(application = this, store = localeStore).run {
           with(getSharedPreferences("lingver_preference", Context.MODE_PRIVATE)) {
               // check if Linver is init on a fresh install
               if (
                   !contains("follow_system_locale_key") &&
                   !contains("country") &&
                   !contains("language") &&
                   !contains("variant")
               ) {
                   setFollowSystemLocale(this@App)
               }
           }
       }
   }
   ```

Maybe to both preserve backward compatibility, Lingver can provide a function/method to check if the `store` is a fresh store by doing something like the above and lets dev decide if they wan to manually set the `setFollowSystemLocale(true)`?


Sources API

Nice work Quentin, good foundation so far I'd say!
My review comments are going to be in line with the following understanding of how it works:

User imports desired Source with whatever settings needed

User inits a SDF with given Source (I see you mostly set up support for >1 SDF with SourceManager)

User runs app with given SDF which inits the following under the hood:

register produce topic (uses Source.default_topic() if not provided)
configure/finalize setup of Source (hands each its producer and produce topic)
sets up threading of Sources (SourceManager registers each Source as a SourceThread)
starts all threads

once running:

Sources produce messages
eventually the consumer (reading from produce topic) hits a checkpoint, where it flushes Source producer at the end of the checkpoint

stopping:

SourceManager gracefully handles stopping SourceThreads


Finer tuning of split separator?

Currently change-case parses (splits) multiple types of casing in one pass like:
Using capitalCase():
Hello from Sn_ake's iPhone => Hello From Sn Ake S I Phone
Check out: 101 iAndroid => Check Out 101 I Android ## We are also missing the colon here
It would be amazing if we could have some / an option to finer tuning to achive results like:
Hello From Sn_ake's IPhone ## white space only
Hello From Sn_ake's iPhone ## detect common noun styling ([a-z][A-Z])
We could also think about export the factory functions so that user could use custom split functions, or accept a split function as an option.

Can you describe more about what you’re actually trying to do?

Hi Blake,
TL;DR of what I'm trying to achieve is a way to make the split function less agressive, or being able to pass a custom split function to it 😄
The library is awesome but sometimes too agressive in some cases as mention in the first post, that's all.

The issue with your example is it still won’t work as expected, the case changing functions also lower case other characters.
It seems like what you really want is just the existing title case library? It doesn’t do any splitting or white space changes and avoids messing with words like iPhone.

Kk thank you for your time,
My network have been a pain to browse around and I didn't actually visit the factory functions,
It seems like a new package is easier to fit my case than commitings


Confused about DateTime

I have entities with DateTime fields e.g.
        public DateTime StartDate { get; set; }
        public DateTime? EndDate { get; set; }

I have read https://www.npgsql.org/doc/types/datetime.html and of course now I see that NodaTime is the recommended way. I'll look at that, but still will ask as it seems DateTime should work.
Note, my postgres is running from the postgres docker image, timezone should be UTC.
I am running dotnet locally in +10.
I set a date - entity.EndDate = DateTime.Now and I get a UTC time in the DB (although reading the docs it seems DateTime is meant to be written "as is"
e.g I made a change at 10am my time (+10) and in the DB I get 00:00 (UTC) (when I just select the data with sql).
But If I query the data like entities.Where(e => e.EndDate > DateTime.Now) I expect it not to include the entity. But it does... If I run that query 10 hours later it correctly filters that entity.
What am I missing here? It seems like, well I don't really know what is happening. But I thought out of the box DateTime would just "work"?
I will look at NodaTime now too.

Hmm if I change the sql it generates to use my timezone like > now() AT TIME ZONE 'AEST' I get the results I expect. It doesn't feel like the DateTime is be written "as is"?

The driver writes any DateTime as is and as a timestamp, but the EF provider translates an expression tree to a corresponding query and it doesn't pass DateTime.Now or DateTime.UtcNow as parameters. As you can see they are replaced by now function calls. So this means that if you have different time zones for your application and your database, you will get wrong results.
By the way, Microsoft is stopping to use DateTime in their API and switching to DateTimeOffset. You may want to use it too if there is no need in all features of NodaTime.

Ahhh thanks for that. DateTimeOffset works with npgsql I assume?

Sure. Its value is converted to UTC on the client and sent as timestamptz to the backend. A timestamptz is stored as UTC time internally by PostgreSQL. The offset is added back when the value will be read by the driver, and it will be taken from the current client time zone.

Thanks. Looks like DateTimeOffset doesn't get translated to SQL and will run locally

The LINQ expression 'where (Not(([p].EndDate != null)) OrElse (Convert([p].EndDate, DateTimeOffset) >= DateTimeOffset.Now))' could not be translated and will be evaluated locally

Ah, it looks like the is no translation for these two methods (see #873). So as workaround you can save the current value into a variable and use it instead of Now or UtcNow so they should be passes as parameters.

ah thanks. That is unfortunate. Thanks for the help

The driver writes any DateTime as is and as a timestamp, but the EF provider translates an expression tree to a corresponding query and it doesn't pass DateTime.Now or DateTime.UtcNow as parameters. As you can see they are replaced by now function calls. So this means that if you have different time zones for your application and your database, you will get wrong results.

Sorry I'm still confused. In the DB the value was UTC, I.e not the local machines +10 time. And since postgres is running in UTC wouldn't now() in the sql generate a UTC time which would be after the stored value?

OK this just seems weird to me. And maybe unrelated to Npgsql (or related to the column types it sets up?).
select start_date, end_date, now()
from sensor_installation
where end_date > now()

Results
"2019-04-17T03:42:30.269Z"         "2019-07-04T11:16:41.360Z"          "2019-07-04T11:24:36.651Z"

end_date is clearly not > now() yet the results are returned...

There was another conversation about the same problem in the main repo - npgsql/npgsql#2209.

OK, thanks. Testing in the deployed environment where the dotnet code is running in UTC and the DB is too. It works as I would expect.
The above still confuses me though.

What column type is? timestamptz?

It is the default of whatever Npgsql.EntityFrameworkCore.PostgreSQL uses with DateTime. Which looking at postgres is a timestamp without time zone column.


Definitions which hang the parser/resolver - infinite loop?

Seems to affect both the v3.4 and v4 branches.

https://api.swaggerhub.com/apis/rftrein/site-express_s_mark_api/v1
https://api.swaggerhub.com/apis/rthiney/test/1.0.0
https://api.swaggerhub.com/apis/vkszn/smart-web_web_api/v1

Each seem to have quite deeply nested circular references (I used a topological sorting algorithm to check).

Thanks for letting me know.  I'll try to reproduce the problem locally and look into the cause

I encountered this today, and I have made a minimal reproduction case here: https://github.com/BigstickCarpet/json-schema-ref-parser/issues/36

Otherwise, maybe try settings the option $refs.circular to false....?
https://github.com/BigstickCarpet/swagger-parser/blob/master/docs/options.md#options


Add setting attribute to medication order

Setting code attribute was added to MedicationOrder in QDM5.4
Pull requests into CQL QDM Patient API require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1657
[x] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[ ] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA test links: NA
[x] Justification for using JIRA tests: NA
[x] JIRA tests have been added to sprint NA

Reviewer 1:
Name: @edeyoung

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

more applicable once we actually have an example

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

I am ok with tests here (they may catch unexpected issues), however, we should also add a TODO here for additional tests. I don't want us to have a false sense of security since we are not really testing real input (input from Bonnie front-end).


@conda-forge-admin please rerender

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/qt-webengine-feedstock#5.


[Components section] Content coming soon message implementation

Problem to solve
Currently, we have "Design and functional specifications, Development documentation, and Feedback" sections as the base content for the website page. The development team populated the page when a new component developed.
However, when adopters visit the website, they see a simple page without guidelines they are looking for and have no idea when DDS Team will provide the guideline or additional information about the component. We need to create a treatment to inform the adopter the rest of the guidance is in work progress to set the right expectation.
Steps:

Review the "More content coming soon" design with Jenny
Work on the implementation via Code.
Review PR with Jenny

Acceptance criteria

[ ] Notification treatments are updated and live on the website

Issue moved to carbon-design-system/carbon-for-ibm-dotcom-website #886 via ZenHub


perf(es/codegen): Use scoped allocator

Description:
Main:

new:

Closing in favor of https://github.com/swc-project/swc/pull/9245


[valijson] Update to version 0.6

Update valijson to version 0.6

What does your PR fix?
Fixes #20257

Which triplets are supported/not supported? Have you updated the CI baseline?
All, Yes

Does your PR follow the maintainer guide?

Yes

Thanks @misirlou-tg !


Data source

Hello,
I was wondering the exact source of the Alertwildfire data used in your paper. Was it : https://youtube.com/@nvseismolab ?
Thanks for your work,
Simon

Partially,
For training the model, I used the videos from the YouTube channel your referred to plus a lot of other videos that ALERTWildfire had captured and shared with us separately which includes 1300+ videos. We then extracted a lot of frames from these videos.
For testing, we used a non-overlapping group of frames plus brand new data that I collected from the fires that were raging on as I was working on the experiments. I would go on AlertWildfire website, find cameras close to the regions where fire was currently burning and capture some images from live feeds and use it for testing. We also used HPWREN database for testing and evaluation plus some fire images from the internet. I also manually collected images from the internet to create the collage images and also for the challenging negative test set. For the negative test set, I would also go to AlertWildfire and HPWREN cameras live, and find images containing smoke-like objects that would trick me into believing it is a smoke and use those as challenging negative test set.
So in short, the training set was from Videos that our collaborators (University of Nevada's NVseismo @ AlertWildfire) had shared with us that included the YouTube videos.
But the validation/test sets were from variety of sources to make it challenging.
I hope I have answered the question and thus, be able to mark this issue as solved.

Thanks for this very detailed answer :)


Build broken for esp32

After 6e9cd9cc
/project/deps/libpeer/src/stun.c: In function 'stun_set_mapped_address':
/project/deps/libpeer/src/stun.c:71:41: error: 'struct in6_addr' has no member named 's6_addr16'
   71 |         addr16[i] = addr->sin6.sin6_addr.s6_addr16[i] ^ *(uint16_t*)(mask + 2 * i);

Do you know if this is an easy fix @sepfy I haven't looked at it closely yet!

fixed!
264c59f992f78bbd721974389e67282da9ed7a3f


MSOnline cmdlet map update

Learn Build status updates of commit c88305d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoftgraph/docs-conceptual/azuread-msoline-cmdlet-map.md
:white_check_mark:Succeeded
View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 2778c92:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoftgraph/docs-conceptual/azuread-msoline-cmdlet-map.md
:white_check_mark:Succeeded
View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 58303d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoftgraph/docs-conceptual/azuread-msoline-cmdlet-map.md
:white_check_mark:Succeeded
View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit fd1ab1d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoftgraph/docs-conceptual/azuread-msoline-cmdlet-map.md
:white_check_mark:Succeeded
View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Hello @DerrickJKimani, please review this.

@msewaweru changes are okay.

Hi @CelesteDG - Please merge this for me.


Will this repo and the npm package be maintained ?

I found this repo through the awesome article  the author made.
It's easy to copy the code of the package in my repo but I would prefer if it was maintained. I have a project running an older version of next so this package fits me well.
Is it going to be maintained and could other contribute ?
@KolbySisk

Yes, it will be maintained. I use it for all of my projects.
I'll happily review any PRs if anyone else wants to contribute.


Any option without TOKEN ?

First of all I want say Thanks for nice project !!
I want to use with clusterrole "view" mode so want to skip TOKEN authentication and I want use manage RBAC internally.
Similar like in default Kubernetes Dashboard, you can skip by passing parameter --enable-skip-login

Thanks for the request @prasenforu. Let me think about how we might be able to accomplish this. What if we allowed you to configure a "default login token" to be used. Then you could create an account/token with whatever permissions you'd like your users to have. Would something like that work?

"default login token"  with read only view OK.
But skip TOKEN authentication button would be nice similar like in default Kubernetes Dashboard, where you can skip by passing parameter --enable-skip-login.

This would be a fantastic feature!
In the meantime, if you have a reverse proxy like Nginx between your service & the end user, I've come up with a (very hacky) way to bypass end-user authentication by handling it in the proxy. Here's an excerpt from my nginx.conf file:
server {
    # ...

    location /apis {
        proxy_set_header Authorization "Bearer YOUR_SECRET_TOKEN_HERE";
        proxy_pass http://YOUR.SERVICE.URL.HERE;
    }
    location =/ {
        add_header Set-Cookie "Authorization=YOUR_SECRET_TOKEN_HERE";
        proxy_pass http://YOUR.SERVICE.URL.HERE;
    }
    location / {
        proxy_pass http://YOUR.SERVICE.URL.HERE;
    }
}

I should note that this is far from an ideal solution, and I wouldn't be surprised at all if the next update breaks it, but it seems to be working for now.

Any update on this?


Class resilience part 3

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - 959b6e7873bfe4b6f4a374e5667a8253b690a13f

@swift-ci Please test

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 959b6e7873bfe4b6f4a374e5667a8253b690a13f

Build failed
Swift Test OS X Platform
Git Sha - 959b6e7873bfe4b6f4a374e5667a8253b690a13f

@rjmccall I realized I forgot to tag you for review here as well. Let me know if anything looks suspect.


not wroking

hey, when i try to run the ps1 script, I get the following error:
Exception calling "PickAsync" with "1" argument(s): "Element not found. (Exception from HRESULT: 0x80070490)"
At C:\Users\winman\Desktop\leaker.ps1:69 char:9
$creds = Await ([Windows.Security.Credentials.UI.CredentialPi ...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : Exception
what should I do?
Running on: windows 10, powershell 5.1.19041.1320

Encountering the same, confirmed that his is not a problem with the script but some recent update has caused it.

seems like the pickasync method was not found in the credentials.ui.
will be checked


revise the problem of makefile in the ch12

I have seen the makefile written by pezy ! It had a little problem , I modified it !

do you make for the makefile ???

ex12_20 ex12_27_30_TEST both don't compile ! I already test it on my computer!

I'm sorry for ignoring the all in GNU_makefile_template!

I will revise it by move all in makefile of ch** to the GNU_makefile_template!

ex12_20 ex12_27_30_TEST both don't compile ! I already test it on my computer!

yes, I miss it. sorry for that.

Great~


Preprocessing dictionary

Hello
I am opening this issue to get access to your dictionary pre-processing code.
Regards
Shyama

Hi @saha-shyamasree
The dictionary pre-processing code can be found in https://github.com/dmis-lab/BioSyn/tree/master/preprocess.
If you have any difficulties running the code, please feel free to leave further questions here.


Add Contribute.md

Done !

Hi @alwibastomi thanks for your PR! We've had a few people misunderstand this request so I've edited #78 for clarity. If you could have a look at that and edit your PR to suit I'd be happy to merge it 🙂

Hi @alprestedge, we actually have an existing PR that deals with this #82 and your PR doesn't actually match what the issue outlines, so I'm going to close this.
Thanks for your contribution though 🙂


Semantic Highlighting: Self should semantically be a type alias

The semantic highlighting currently considers Self a type parameter, not a type alias.
This is likely caused by this line: https://github.com/rust-analyzer/rust-analyzer/blob/30eb458b4fa8adcecd8cbf731bd1cfa9a7a8b88b/crates/rust-analyzer/src/conv.rs#L59

Tricky! Self is a type parameter in traits, but it is a type alias in impls.

Triage: now it's a type parameter in traits:

But a type in impls:

Triage: now it's a type parameter in traits:

But a type in impls:

Isn't that correct?

Isn't that correct?

matklad said it should be a type alias in impls.

matklad said it should be a type alias in impls.

Ok, I wasn't sure whether there's a difference between type and type alias in semantic tokens.

Ok, I wasn't sure whether there's a difference between type and type alias in semantic tokens.


fix: eliminate a SIGSEGV from test

This change is

The builds are failing because of an unrelated bug: #3032


Advice to use GlobalOpenTelemetry is misleading

The library instrumentation page says that "libraries should obtain tracer from global TracerProvider by default". It goes on to say that "its useful for libraries to have an API that allows applications to pass instances of TracerProvider explicitly".
This isn't necessarily wrong, but the advice is flipped in java and the code snippet (along with another that shortly follows) use opentelemetry-java as an example. See language in the java manual instrumentation page which directly contradicts this advice:

if you are writing library instrumentation, it is strongly
recommended that you provide your users the ability to inject an instance of
OpenTelemetry into your instrumentation code. If this is not possible for some
reason, you can fall back to using an instance from the GlobalOpenTelemetry
class

Options:

Clarify that the preference for global versus providing instances TracerProvider may vary by language
Use an example language that isn't java, and maybe add a footnote that at least in java the behavior is flipped

Yeah, that page is fairly dated, needs some love :)


[NNVM] Bugfix operator fusion for residual block with layout transform

This is a fix for the issue found by @kevinthesun.
In #1608, I added a logic to prevent fusing injective ops with convolution or other non-broadcast ops. To do that, we detect a node which has both injective ops and non-broadcast ops as parents, and assigning group and master node ids appropriately.
But I failed to address a case where the detected node has children nodes in the same group. In that case, we need to reassign master node id to children nodes as well, since otherwise they might still be pointing to a master node in a different group.
This issue could arise in a residual block with layout transform. There, layout transform, elemwise add, and relu ops can be fused, but not conv2d because layout transform is an injective op.  Before this PR, the correct fusion was happening, but relu op's master id was pointing to a conv2d op, which caused the issue @kevinthesun reported. This is hard to describe in words, but the test case added may clarify a bit.
@kevinthesun @tqchen please review.

Thanks @masahi this is now merged


doc: should be .cargo-ok

It was a mistake. Should be .cargo-ok. .cargo-lock is a file lock holding for target/debug when compiling stuff.

@bors r+

:pushpin: Commit 0dcf5063416307dabd818ce3ac21f2fd7aada8af has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 0dcf5063416307dabd818ce3ac21f2fd7aada8af with merge be42872358db9c2a073fe161fcddb3d7caf2f247...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing be42872358db9c2a073fe161fcddb3d7caf2f247 to master...


Google API system changed

How find the serviceClientId and serviceAccountName in the new Google API system?

Id will be given to you after you create credentials by following the readme section. They removed the serviceaccountname requirement.
Ozan Kurt

On 27 Jul 2016, at 15:48, Lucas Mellos<EMAIL_ADDRESS>wrote:
How find the serviceClientId and serviceAccountName in the new Google API system?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Remove duplicated code in feed pkg

This PR remove duplicated code.
I personally don't like too much of the use of a package utils but I understand its use here.
But what do you think if we split the file utils.go in two or maybe 3? Most of its logic seems to be related with hex manipulation. So we could have hexutil, xor and crypto, maybe?
And maybe also rename the package utils to something like common?

@r0qs Thanks for the PR. The coverage is failing but it is not related to the PR.
I am merging it.

@r0qs Thanks for the PR. The coverage is failing but it is not related to the PR.
I am merging it.


Console log in script node

Hi, I am having a hard time debugging my pupeteer script, console.log() doesn't seem to print anything in the browser console, like i would expect with the code nodes.
Am i doing something wrong or is this not a feature?

Hi @riekusr - v1.1.0 was released and supports console.log and many other features of the Code node:
https://github.com/drudge/n8n-nodes-puppeteer/releases/tag/v1.1.0


Fix examples metastore issues

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/608/


Check for camera availability before switching

With devices having only 1 camera, pressing "Switch camera" icon will crash the app with the following exception:
Could not find requested camera.

This make sure the desired camera is available before the switch.
I didn't make the changes for iOS, because all devices running iOS have both front & back camera.

@AmolGangadhare any feedback?

@AmolGangadhare Can you give feedback about this merge? I think this should already be in the codebase


Not compatible with recent versions?

Hi,
I absolutely love the way this looks and am curious if you'd have any interest in updating it to work with current Obsidian versions?
Thank you!

The new obsidian was way more cleaner than old, so I wasn't much interested to update, even though I like this more.
If I get time, I'll consider updating this, thanks for showing interest.


feat(chunk): add chunk typing support

What kind of change does this PR introduce?
Refactoring, Type Annotations

Did you add tests for your changes?
N/A

If relevant, link to documentation update:
N/A

N/A
Summary
This adds more (but not complete) typing to Chunk.js.

Chunk is one of many base Types that could value from being completely typed and referenced in other modules, etc. It is also heavily used across plugins in our ecosystem, and having these annotations will assist in authoring of plugins and other integrations.

Does this PR introduce a breaking change?
No

Other information
Also helped discover the following TypeScript bugs:

https://github.com/Microsoft/TypeScript/issues/23375
https://github.com/Microsoft/TypeScript/issues/23384
https://github.com/Microsoft/TypeScript/issues/23385

I have corrected import() statements with the new xx24 update of TypeScript nightly and the bug @weswigham mentioning being fixed last night.

This looks ready now.

Rebased to remove noise, tests rerunning, and removed two more stray comments. Should be good now.

Alright had to rebase, going to correct these now

All checks pass going to merge.


The tooltip on the parameter of the interface method is wrong

Description:
I define interface method and give same name for the parameter that defined by another place.
Put mouse cursor to the parameter that I defined.
Tooltip displays another definition what I don't expect.
Repro Steps:
type Foo = interface
  abstract Bar: query: string -> int
end

Expected:
The tooltip displays nothing.
Actual:
The tooltip displays Core.ExtraTopLevelOperators.query.
Version: Language, compiler, library, platform version
VS2013
Link:
https://twitter.com/htid46/status/419240351107256320

I can repro on VS2013.
When I define the Class.Bar method that accepts a string named query which has already defined in the core library, the named parameter query shows unexpected information when mouseover:

Here's another sample:

Can't see it anymore


Use of Raw AQL Queries

First, thank you for maintaining this driver.
I'm new to Elixir/Phoenix (currently using NodeJs) and considering migrating to Elixir.
The ArangoDB JavaScript driver API allows to write raw AQL queries. Does this driver allow to write raw AQL queries? If so, is there a documentation on this?

If you use Ecto it is generally better/easier to use the built-in DSL based queries. However, there are limitations to what you can express in these queries. If you find yourself in a situation where the Ecto queries are too limited, you can resort to raw AQL queries like this:
ArangoDB.Ecto.query(MyRepo, "<raw AQL>")

Thanks @mpoeter. That's very helpful.
Since I haven't settled on a particular language/framework, I prefer to keep the AQL query in raw form.
But I sure will use Ecto's DSL where appropriate.


community: Replace pypdf2 import with pypdf

Replace the dependency PyPDF2 with PyPDF. PyPDF2 is an old fork from PyPDF which hasn't been updated for 11years.

It makes sense. But Don't we need to validate it somehow?

What do you think we should validate? I don't think we want to test that external packages work as expected, no?

Where PyPDF2 coming in the first place? I couldn't find it as dependency.

Hey there! This PR is against a deprecated community integration that has moved to a dedicated integration package.
I'll close it, and feel free to reopen against the integration package! https://github.com/langchain-ai/langchain-google
Fwiw I think this is a good change. Although PyPDF's docs don't make it easy to figure out which import to use!


double.nan has a platform specific bit pattern

main.dart:
void main() {
  final data = ByteData(4);
  data.setFloat32(0, double.nan, Endian.little);
  print(data.buffer.asUint8List());
}

running dart main.dart prints:

[0, 0, 192, 127] on macOS arm64
[0, 0, 192, 255] on macOS x64 (using rosetta)

Both are valid double.nan representations but I would expect the result to be platform independent. It makes writing tests for a binary format like protobuf much more difficult.
Dart version: 2.17.3

tl;dr: It comes from divsd 0.0, 0.0 on X64 giving a negative NaN.
The double.nan value should preferably be the positive zero-payload QNaN Float64 value.
It seems to be the sign bit which differs here, when it's written as Float32.
I get the same [0, 0, 192, 255] result on Linux x64, so it's not just macOS.
The sign bit is also set when doing setFloat64, so not just a Float32 issue.
I can't directly see whether the double.nan value itself is negative, other than by writing its bits, but this result suggests that it is.
We have one operation which changes the sign even of a NaN, but it doesn't tell us what the original bits were.
print(identical(double.nan, -double.nan)); // false

and if I try to write -double.nan, I do get the 127 MSB.
So, either writing the bits of double.nan changes the sign bit (would be weird), or 0.0/0.0 is, for some reason, -QNaN instead of QNaN. Let's assume the latter.
Could we define double.nan in a different way that 0.0 / 0.0 to get a positive result?
Let's try the other operations specified to give NaN:
var zdz = 0.0 / 0.0;
var ifmif = double.infinity - double.infinity;
var ifdif = double.infinity / double.infinity;
var ztif = 0.0 * double.infinity;

print(identical(zdz, ifmif)); // true
print(identical(zdz, ifdif)); // true
print(identical(zdz, ztif)); // true

So, no help, they're all negative. We could do static const double nan = -(0.0 / 0.0);, but that would likely give a negative NaN on other platforms which don't have this issue. (And (0.0 / 0.0).abs() propagate the NaN value, it doesn't change its sign. Every operation other than unary - does.)
Checking the intel divsd operation specification doesn't help much. It doesn't specify the behavior. The IEEE-754 (2008) standard allows "some diagnostic information" on the QNaN of division(0, 0), but doesn't say which. So it's not wrong for it to be negative, just weird an unexpected.
It does seem that divsd on 0.0 and 0.0 yields -QNaN on intel/AMD x64 platforms.
Other have https://stackoverflow.com/questions/66295777/any-reason-why-0-0-0-0-makes-negative-nan-in-c too.
(It's not the compiler, as someone suggests, it's just that clang does better inlining and decides that 0.0/0.0 is +QNaN at compile-time, but if it gets to runtime and executes divsd, it gets -QNaN too.)
See also this compiler comparison.
So, what can we do?
Maybe we can make nan an "external constant" and let the compiler provide the value as a reinterpret_cast<double>(0x7FF8000000000000ull).
Or just accept that NaNs are weird and live with it. I'd prefer to not do that. At least, if we can provided a non-negative zero-payload QNaN as double.nan, we can better live with 0.0/0.0 giving a negative QNaN, because we can get to the non-negative value somehow.

It's a known ARM vs X86 difference. If an operation would produce NaN and has no NaN as an input X86 will produce 1 in the sign bit and ARM produces 0.

Since any user created 0.0/0.0 will give the same signed NaN, we can't prevent the signed NaN from showing up.
On second thought, it might actually be safer to have double.nan be identical to the NaNs you get from standard NaN-generating operations.
So, leaning towards doing nothing here.

So, leaning towards doing nothing here.

Should we close this then? I am also in the do nothing camp for this one. (Maybe add a documentation line into the double.nan that is has a platform specific bit pattern).

I think at least documenting this behavior is a good idea. Here is a quote from the Rust docs:

Note that IEEE-745 doesn’t define just a single NaN value; a plethora of bit patterns are considered to be NaN. Furthermore, the standard makes a difference between a “signaling” and a “quiet” NaN, and allows inspecting its “payload” (the unspecified bits in the bit pattern). This constant isn’t guaranteed to equal to any specific NaN bitpattern, and the stability of its representation over Rust versions and target platforms isn’t guaranteed.

Shall I open a PR with a doc line?

I'd add documentation to double.nan for all things related to NaN.
All other places that need to say something about NaN should then refer to that.
Not sure setFloat32/setFloat64 need to say anything, they are dutifully storing the correct bit pattern.
We could mention on /, - and * that a NaN result from non-NaN inputs is not guaranteed to be any specific pattern,
or just say that it'll be the same as double.nan (which I think it is on all platforms).


Support dual averaging for HMC and NUTS

This pull request implements dual averaging versions for HMC and NUTS. We can implement Algorithms 5 and 6 of NUTS paper directly but I found it a little bit counter-intuitive when looking at the pseudo-code. So I created a separate DualAveraging class to make things easier to follow (the implementation based on Nesterov's paper on primal-dual subgradient methods). In addition, it can be used for both HMC and NUTS. So in my view, this separation is useful.

[x] Implement DualAveraging
[x] Implement find_reasonable_epsilon method for HMC
[x] Use DualAveraging for HMC
[x] Use DualAveraging for NUTS
[x] Create tests.

@eb8680 @neerajprad It seems that with duo averaging, if the model is sensible to step_size, then it is easy to get NaN. The reason seems lie at mu = log(10 step_size). With this setting, early steps of duo averaging scheme will give big step_size. I don't know how to solve this problem. :(

@eb8680 @neerajprad It seems that with duo averaging, if the model is sensible to step_size, then it is easy to get NaN. The reason seems lie at mu = log(10 step_size). With this setting, early steps of duo averaging scheme will return big step_size, which in turns causes NaN due to the sensibility of the model. I don't know how to solve this problem without modifying it. :(

Replied in #740. I'll take a look at this PR in detail today.

@neerajprad this is ready to review. Travis failed due to an unrelated issue (cannot download a file).

@eb8680 @neerajprad I will address your reviews after lunch. Just a quick reply for some points:

@eb8680 find_reasonable_stepsize is used in stan with target_accept_prob = 0.8. It seems that pymc3 doesn't use it (they might just set some initial stepsize). It is mainly used for setting mu (x0) for DualAveraging.
@neerajprad related to API, it is my intention to make them all _foo. Most of them should be moved into a better place (for example: self.config or self.defaults). I let these decisions for pyro's devs ^^. For the test, if we set trajectory as default (2pi) then it is slow (the tests pass anyway). HMC with dual averaging uses trajectory_length instead of num_steps.

@neerajprad @eb8680 Thanks for your reviews! I have addressed your comments and the code turns out to be cleaner. The tests are identical to those of the previous version (on the non-transformed model: logistic regression). I added an additional mechanism for setting default parameters:

step_size=None will be set to 1
trajectory_length=None will be set to num_steps x step_size. If num_steps is None then set it to 2pi.
num_steps=int(trajectory_length/step_size). In Stan, they don't have num_steps in HMC's parameters.

@eb8680 - Any other comments before we get this merged?


Feature api interface

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@370c278). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   70.33%
=========================================
  Files             ?        6
  Lines             ?      209
  Branches          ?        0
=========================================
  Hits              ?      147
  Misses            ?       41
  Partials          ?       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370c278...67f45f9. Read the comment docs.


Keytar missing for Docker-extension

code-server version: 1.408-vsc1.32.0
OS Version: Ubuntu 16.04 container
Extension: https://marketplace.visualstudio.com/items?itemName=PeterJausovec.vscode-docker

Description
When i try to use the Docker-extension above it throws this error;
Activating extension 'PeterJausovec.vscode-docker' failed: Internal error: Could not find keytar module for reading and writing passwords.
Where and how can i install keytar?
Steps to Reproduce

Install Docker extension from marketplace
Click the Docker icon in the left hand toolbar

Will fix! Keytar is an interesting one since it uses the system keychain.

I am wondering of you all made any progress on this? It seems like libsecret, which is the Linux implementation that this is using doesn't support any type of headless or CLI mode, it wants X11 to be functioning.

Does libsecret really need X11? I understand it uses Dbus but I didn't think it required a running X11 server.

I'm also checking in on this one as I've run into this as well. Any progress here? Or has anyone found a workaround?
I've tried to just install npm and then keytar in the docker container, but it doesn't seem to be working (though I didn't really dive into why that didn't work, yet)

No workaround or solution at the moment, the issue is that libsecret requires Dbus (a message bus) and possibly X11 (a desktop environment) to be running and accessible to code-server.
I'm not completely sure, but the easiest solution seems to be writing a "fake" keytar that stores passwords by some other method instead of using those dependencies.

Could be helpful: https://wiki.archlinux.org/index.php/GNOME/Keyring#Using_the_keyring_outside_GNOME

I use this library for accessing keyrings in Go: https://github.com/99designs/keyring
It has a list of backends that it supports. pass may be a good one for writing a fake keytar.


transfer_learning with custom datasets

Refs to the Transfer Learning in the README.md,  If I trained with the custom datasets(for example, with 5 classes)
There would be a shape mismatch in detectron2/modeling/roi_heads/fast_rcnn.py
                if clip_cls_emb[1] is not None: # it could be None during region feature extraction
                    pre_computed_w = torch.load(clip_cls_emb[1])  # [num_classes, 1024] for RN50
                    self.cls_score.weight.copy_(pre_computed_w)

So, How do I generate a custom MODEL.CLIP.TEXT_EMB_PATH file with the pretrained models.

Please refer to our guidance for generating the custom concept embeddings: https://github.com/microsoft/RegionCLIP#extract-concept-features


empty mobile push template page

separate email template into its own dedicated page

This PR is the first incremental step towards implementing mobile push notifications, as described here,
https://github.com/dittofeed/dittofeed/issues/206


Add missing 'connect' in the production-start.js error handler

Pre-Submission Checklist

[X] Your pull request targets the staging branch of FreeCodeCamp.
[X] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[X] You have only one commit (if not, squash them into one commit).
[X] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[X] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[X] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

I noticed a word was missing from a file. It looks like a small change, but I wanted to get started contributing to the main repo. Because once we start building in-browser challenges for Python and other languages, I would need to contribute more and more. This is the first step towards that.
I have changed an error message in a file, production-start.js

:sparkles: :sparkles: LGTM. :sparkles: :sparkles:
Thanks @alayek .
Welcome aboard! :wink:


Random Loop

One of my old wish is to have a loop sequence option that is a totally randomized order.

Hi Cysteve
This should be achievable.
TimothyLuke

On 7 Mar 2018, at 8:48 am, cysteve<EMAIL_ADDRESS>wrote:
One of my old wish is to have a loop sequence option that is a totally randomized order.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi CySteve,
Im still working on this

Released as part of GSE 2.2.07


[TF] Change APIs to use Int instead of Int32.

Let TensorShape store [Int].
Let Tensor subscripts take Int and Range<Int>.
Reduce explicit calls to Int32.init in user code.

Notably, initializers taking TensorShape no longer need Int32.init.

Added two shims:

Tensor(_: [Int]) creates a Tensor<Scalar>, where Scalar
conforms to BinaryInteger.

This is useful for Tensor<Int32>(shape.dimensions).

Overload Tensor subscripts for Int32 and Range<Int32>.

This is useful for tensor[0..<x.rank].
I chose not to change rank and scalarCount to Int for now.

This is just a start - there are definitely more usages of Int32 in Tensor APIs.
Examples include:

Axes (for expansion/squeezing/reduction).
Strides (for convolution/pooling).
Tensor.rank and Tensor.scalarCount.

Changing these to Int is consistent with TensorShape.rank and TensorShape.contiguousSize.
However, it breaks callers like Tensor<Int32>(rangeFrom: 0, to: rank, stride: 1).

his is just a start - there are definitely more usages of Int32 in Tensor APIs.

I saw those places.  It would be much nicer to incorporate those changes in this exact PR instead of changing them and reverting some changes made here in a separate PR.

It would be much nicer to incorporate those changes in this exact PR instead of changing them and reverting some changes made here in a separate PR.

All user-facing APIs now use Int. Ready for re-review.

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please clean test tensorflow