[Bug]: vLLM crashes with larger context sizes on TPUs

Your current environment

The output of `python collect_env.py`
Collecting environment information...
INFO 09-10 05:05:28 importing.py:10] Triton not installed; certain GPU-related functions will not be available.
PyTorch version: 2.5.0
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: Debian GNU/Linux 11 (bullseye) (x86_64)
GCC version: (Debian 10.2.1-6) 10.2.1 20210110
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31

Python version: 3.10.14 (main, Aug 13 2024, 02:16:06) [GCC 10.2.1 20210110] (64-bit runtime)
Python platform: Linux-6.1.85+-x86_64-with-glibc2.31
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Byte Order:                           Little Endian
Address sizes:                        48 bits physical, 48 bits virtual
CPU(s):                               224
On-line CPU(s) list:                  0-223
Thread(s) per core:                   2
Core(s) per socket:                   56
Socket(s):                            2
NUMA node(s):                         2
Vendor ID:                            AuthenticAMD
CPU family:                           25
Model:                                1
Model name:                           AMD EPYC 7B13
Stepping:                             0
CPU MHz:                              2449.998
BogoMIPS:                             4899.99
Hypervisor vendor:                    KVM
Virtualization type:                  full
L1d cache:                            3.5 MiB
L1i cache:                            3.5 MiB
L2 cache:                             56 MiB
L3 cache:                             448 MiB
NUMA node0 CPU(s):                    0-55,112-167
NUMA node1 CPU(s):                    56-111,168-223
Vulnerability Gather data sampling:   Not affected
Vulnerability Itlb multihit:          Not affected
Vulnerability L1tf:                   Not affected
Vulnerability Mds:                    Not affected
Vulnerability Meltdown:               Not affected
Vulnerability Mmio stale data:        Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed:               Not affected
Vulnerability Spec rstack overflow:   Mitigation; safe RET
Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:             Mitigation; Retpolines; IBPB conditional; IBRS_FW; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                  Not affected
Vulnerability Tsx async abort:        Not affected
Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single ssbd ibrs ibpb stibp vmmcall fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 clzero xsaveerptr arat npt nrip_save umip vaes vpclmulqdq rdpid fsrm

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] pyzmq==26.2.0
[pip3] torch==2.5.0
[pip3] torch-xla==2.5.0+git17a4ef5
[pip3] torchvision==0.19.0a0+d23a6e1
[pip3] transformers==4.44.2
[conda] Could not collect
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.6.0@1447c97e753919709b613590d7267c93d07d9382
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
Could not collect

🐛 Describe the bug
I am trying to deploy llama3.1 8B instruct on GKE 2x4 v5e TPUs. The vLLM server boots up normally and works properly if max-model-len is very low (ie 1024), but crashes with higher context sizes (tried 16k and above). I'm using the Dockerfile.tpu, and the command python3.10 -u -m vllm.entrypoints.openai.api_server --host <IP_ADDRESS> --model meta-llama/Meta-Llama-3.1-8B-Instruct --tensor-parallel-size 8 --swap-space 16 --disable-log-requests --max-model-len=32768
Here is my full log file:
vllm-llama31-tpu.log
Here is my full k8s manifest:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: llama3-8b-instruct-vllm-deployment
  namespace: default
  labels:
    app: llama3-8b-instruct-vllm
spec:
  replicas: 1
  selector:
    matchLabels:
      app: llama3-8b-instruct-vllm
  template:
    metadata:
      labels:
        app: llama3-8b-instruct-vllm
    spec:
      nodeSelector:
        cloud.google.com/gke-tpu-topology: 2x4
        cloud.google.com/gke-tpu-accelerator: tpu-v5-lite-podslice
      hostIPC: true
      hostNetwork: true
      containers:
      - name: llama3-8b-instruct-vllm
        image: us-central1-docker.pkg.dev/project-lighthouse-403916/lighthouse-production/vllm-server/vllm-tpu-image:latest
        command: ["/bin/sh", "-c", "python3.10 -u -m vllm.entrypoints.openai.api_server --host <IP_ADDRESS> --model meta-llama/Meta-Llama-3.1-8B-Instruct --tensor-parallel-size 8 --swap-space 16 --disable-log-requests --max-model-len=32768"]
        env:
        - name: HUGGING_FACE_HUB_TOKEN
          value: <hf-token>
        - name: VLLM_LOGGING_LEVEL
          value: "DEBUG"
        - name: VLLM_TRACE_FUNCTION
          value: "1"
        securityContext:
          privileged: true
        ports:
        - containerPort: 8000
          protocol: TCP
        resources:
          requests:
            google.com/tpu: 8
          limits:
            google.com/tpu: 8

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

RuntimeError: Bad StatusOr access: RESOURCE_EXHAUSTED: XLA:TPU compile permanent error. Ran out of memory in memory space smem. Used 1.00M of 1.00M smem. Exceeded smem capacity by 1.7K.

looks like some TPU compilation error.

Seem like a smem OOM compiler time error. Given that v5e per chip HBM is only 16G OOMing at 16k seq length is kind of expected.

What's the largest seq len that you can run?

@miladm Was able to get it running with  --max-model-len 8192, but 16k crashed it

Hey @francescov1
can you use
XLA_IR_DEBUG=1 XLA_HLO_DEBUG=1 XLA_SAVE_TENSORS_FMT="hlo" XLA_SAVE_TENSORS_FILE="/tmp/save1.hlo"

and share the /tmp/save1.hlo(i think it will be /tmp/save1.hlo.0 in this case)  with us? The error here is that XLA compiler complains that it doesn't have SMEM space(we need to move parameter from HBM to SMEM before executing each op) for this HLO. We can open a bug to the XLA compiler team and see if there is anything we can do about it.

@JackCaoG Here you go. File was too big to upload so put on gdrive https://drive.google.com/file/d/1oSY7QqCIsQTZS2tGxJbFV-R_rOepDwHl/view?usp=sharing

Thanks @francescov1
I downloaded the HLO, from the HLO it seems like that VLLM is warming up the cache and throw a compilation error in the last compilation. And that compilation error is the RESOURCE_EXHAUSTED: XLA:TPU compile permanent error. Ran out of memory in memory space smem. Used 1.00M of 1.00M smem right? If so I can just take the last HLO and open a bug to the XLA team.

Yep @JackCaoG that's what i saw too. Sounds good, let me know if you need anything else from me

This must be fixed by #9350.


Support correct schema for currency

Loot sheet uses the schema for currency like so:
{
  currency: {
    cp: { value: 10 }
    // ..etc
  }
}

This is a request to support the schema that the Actor sheet in DND5E system uses, like so:
{
  currency: {
    cp: 10
    // ..etc
  }
}

I thought I had already done that…. I must be imagining things.

On Jul 19, 2021, at 8:57 PM, DFreds @.***> wrote:

Loot sheet uses the schema for currency like so:
{
currency: {
cp: { value: 10 }
// ..etc
}
}
This is a request to support the schema that the Actor sheet in DND5E system uses, like so:
{
currency: {
cp: 10
// ..etc
}
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


[UX] Associate alerting monitor with a visualization on Dashboards

As a user who has found a problem area that they want to monitor (e.g. setting up a new service), I want to setup an alert from the visualization that I’m looking at, so I don’t have to go to the alerts plugin to setup an alert.
Meta-issue
Describe the solution you'd like
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/458
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/457
See also Create alerting monitor from visualizations
User story:
User associates existing monitor to a time series visualization to receive alerts on a dashboard.

Associate existing monitor to a visualization:
User wants to create an association between a time series visualization and an existing monitor (which could look at the same data source or another one) in order to overlay the events from the monitor on a visualization's timeline.
https://user-images.githubusercontent.com/105245012/224581676-eb245b5b-32e6-4f5d-bd8a-99fd9f8cb4c8.mp4
Screen 1: User selects a visualization on a dashboard and selects "Alerting" from the visualization context menu OuiContextMenu:

Screen 2:  User selects "Add alerting monitor" from the context menu:

Screen 3a: "Add alerting monitor" opens a flyout OuiFlyout with "Create alerting monitor" option prefilled with the information from the visualization (including data source information and suggested monitor name):

Screen 4: User selects "Associate existing monitor" (OuiCheckableCard, OuiRadio)

Screen 5: An alternative path to open "Associate existing monitor" flyout is to select Alerting -> Associated monitors -> Associated monitors flyout -> click on "Associate monitor" button.
Note on the flyouts behavior - in order to open a new flyout ("Associate monitor"), the previous one should be closed ("Associated monitors")

Screen 6: User selects a monitor from the list (Single item OuiComboBox):

Screen 7: After selecting a monitor user sees a summary of monitor's details to review the choice.

Screen 8: After selecting alerting monitor user clicks on "Create monitor" button. The flyout closes, user returns to the dashboard.

Done


Documentation: Fix Container.PatchItemAsync Example

Description
The example for the Container.PatchItemAsync<T> Method had a few errors and this PR addresses them.
Resolves Azure/azure-sdk-for-net#29253
Type of change

[x] This change requires a documentation update

Closing issues
Resolves Azure/azure-sdk-for-net#29253

/azp run


kernel/manual-config: prevent chmod errors when there is no arch specific Makefile

stab at fix https://github.com/NixOS/nixpkgs/issues/107346
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

ah the 501+ rebuild is because manual-config.nix is used by all kernels?
Should I target staging instead of master?

Yeah, IMO an improvement with no direct benefit for the user that causes a significant amount of rebuilds should go to staging.
This way it's bundled with all the other rebuilds that would have to happen anyways.

replaced by https://github.com/NixOS/nixpkgs/pull/107525 (against staging)

For future reference, you can just change the base the PR is supposed to be merged to using "Edit" button in the top right.

For future reference, you can just change the base the PR is supposed to be merged to using "Edit" button in the top right.

I have had issues with that in the past where the github messed up the rebase and the whole world was pinged for review..


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on<PHONE_NUMBER> for 19921923e6bb287b5600f192441af8f27d7c975d
https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1035384916

Pipeline Succeeded on<PHONE_NUMBER> for 19921923e6bb287b5600f192441af8f27d7c975d
https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1035384916


Add ComponentActivity support

Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist

[ ] I have read the “Pull requests” section in the contributing guidelines.
[ ] I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

@anhquan291 Could you update the PR description explaining this change and rational. 🙏

Explain your changes
The changes address a compatibility issue with the Kinde SDK initialization in Android applications using Jetpack Compose. The customer faced a problem where the Kinde Login screen failed to open when the MainActivity class extended ComponentActivity instead of AppCompatActivity.
Changes made:
Modified KindeSDK to support ComponentActivity:
Replaced the use of AppCompatActivity with ComponentActivity in the KindeSDK class.
Updated the result handling to check for ComponentActivity.RESULT_CANCELED and ComponentActivity.RESULT_OK instead of AppCompatActivity equivalents.
Background:
AppCompatActivity extends FragmentActivity, which in turn extends ComponentActivity. This hierarchical relationship means that ComponentActivity is a more fundamental class that doesn't include all the additional functionality provided by AppCompatActivity and FragmentActivity.
These changes ensure that the Kinde Login functionality works correctly when the MainActivity extends ComponentActivity, accommodating the customer's need to switch from AppCompatActivity due to other library dependencies.
Checklist:
✅ Updated KindeSDK to support ComponentActivity.
✅ Ensured result handling uses ComponentActivity constants.
✅ Tested Kinde Login functionality with ComponentActivity.
✅ Confirmed no regressions with AppCompatActivity.


sdist.exclude should not be overridden by .gitignore

My .gitignore file uses the following trick to ignore (most) files without extensions:
*
!*.*
!*/

Unfortunately, the way that sdist.exclude is implemented is by prepending the listed rules to these. These are then overridden by the * in the file.
I believe that sdist.exclude should be implemented similarly to sdist.include; in a separate pathspec that is checked after sdist.include and which gets final say.

Slightly related: https://github.com/scikit-build/scikit-build-core/issues/858

I think that makes sense. Would you like to attempt it?


 Add Ticks

bug fix:
1.1. incorrect note.timeStamp in case BPM (Beats Per Minute) is not equal to 60
1.2 incorrect unit tests
add refactoring:
2.1. remove redundancy in property names
2.2. move "magic data" to constants and enums
2.3. reorganize code
add new feature:
3.1. add ticks
unit tests:
4.1 add new unit tests

Comments:

add ticks as it is more convenience way to work with note start time instead of timestamp. Moreover,  the AudioToolbox framework provides note timestamp using BPM = 60 and TPB (Ticks Per Beat) = 480. As a result timestamp for diff BPM is incorrect

Please verify changes and push them to master. You can reach me in the Telegram in case any further discussion required. My contact in Telegram is Belfast.  Thank you.

Sorry for my too late response…
Thank you for your contribution.


Cursor does not follow input when scrolling with $ionicScrollDelegate on iOS

This is the same problem as described in #26 and #1063. It seems that it was fixed for scrolling by the user, but if the scroll is done programatically the problem still occurs.
here is a snippet from a directive:
var scroller = $ionicScrollDelegate.$getByHandle('my-handle'),
      setTop = function(){
        var top = element[0].getBoundingClientRect().top;
        if ( top > 62){ scroller.scrollBy(0, top - 62, true); }
      };

When setTop is called, the scroll happens, but cursor stays in the original position (no longer over the input).

I agree with @sloops77, I have a chat-based app and have the exact same problem with this fix

@sloops77 can you please share the solution in codepen?

Unfortunately the way i've fixed this is by using a fork of ionic (or hack your copy of ionic).
see this commit on my own fork https://github.com/sloops77/ionic/commit/c96af221a7c4edb68a91a867c4663c1efa23fb4e. you can cherrypick it if u like.
Note that my fork of ionic also contains commits for trigger.io support which you probably dont want

@AgDude Would you be able to put together a codepen replicating the issue? Thanks

Greetings @AgDude!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.

I am facing the exact same issue. Is there a solution for this yet?

I am facing this same issu in android. Any solutions?

Any update on this??? I am facing the exact same issue...

Same here with ionic 1.3 and iOs 9.3...

Hi there!
Just to say that the issue also exists on Android with overflow-scroll set to false

same issue with iOS 10 and ionic 1.3

I faced same issue in ios all devices in ionic 1

Looks like it's a bug from webkit in Safari mobile:
https://bugs.webkit.org/show_bug.cgi?id=138201#c5
(http://openradar.appspot.com/18819624)
It will probably never be fixed (lasting since iOS 7).
The only workaround (given by the community) seems to consist in hiding the cursor by triggering blur(), and then focusing again (focus()) when scroll is done...

I am facing the same issue.The input field cursor scroll with screen in IOS device.
Unable to find any solution.Please help as soon as possible.
Thanks in advance.


Grid samples with IgbPaginator do not show total pages initially

All samples that have an IgbPaginator included when loaded initially do not show 1 of [total pages count] until you hover over the grid.
When loaded initially it shows either 1 of NaN or 1 of.
Both could be observed in the Paging topic.
https://staging.infragistics.com/products/ignite-ui-blazor/blazor/components/grids/lob-grid/paging
Scroll until the paginator is visible without hovering over the grid.
The first sample shows 1 of NaN.
The second sample shows 1 of.

I cannot reproduce
https://www.infragistics.com/products/ignite-ui-blazor/blazor/components/grids/grid/paging


Add OutputDirectory property for Chocolatey Aliases

Once 0.10.0 is released:
https://github.com/chocolatey/choco/issues/598#event-751163113

@gep13 This seems like a duplicate of #510 which was fixed with https://github.com/cake-build/cake/commit/b9183974d51c9fbb1b9e13cfa0e4b560fb73c502

@pascalberger yes and no.
That commit is really tricking chocolatey into thinking that it is running in the specified output directory, hence, that is where the output file goes.
Now in the chocolatey client there is an option to specify the output directory.  The chocolatey aliases within Cake should correctly use that setting.

i.e. within the ChocolateyPackRunner, set the --outputdirectory command line option.

@gep13 Ah, missed this :)
I can create a PR for this. Can we expect users to have Chocolatey >= 0.10.0 installed?

@pascalberger that is a difficult one.
The stance I personally take on this is that the aliases should work against the current latest version of the underlying tool, however, we should probably do a check in this instance to make sure that the version is high enough before attempting to run that command.
Or, I wonder, would an earlier version of chocolatey just ignore it?  Perhaps worth a quick investigation.

Any news on this?


Update request: libredwg <IP_ADDRESS>13 → 0.13.2

Package name: libredwg
Latest released version: 0.13.2
Current version on the unstable channel: <IP_ADDRESS>13
Current version on the stable/release channel: <IP_ADDRESS>13
[x] Checked the nixpkgs pull requests

Notify maintainers
@thorstenweber83
Tag: https://github.com/LibreDWG/libredwg/releases/tag/0.13.2
Changelog : https://github.com/LibreDWG/libredwg/blob/0.13.2/NEWS

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

ping @thorstenweber83


Can't add Aqara TVOC after updating Sensor to 0027

Adding the sensor was possible with version 0024

Unrelated to docker. Try the deCONZ repo.


new settings UI: possible to undo a setting change?

when one accidentally clicked some where in the new settings UI, thus made an unexpected change, allow user to undo that change, by pressing ctrl-z or cmd-z

https://github.com/microsoft/vscode/issues/58021#issue-357454753

@ryenus. Likewise. When using @modified, changing settings causes the GUI to jump around, making it easy to misclick.


Add private DNS zone and CPO record management for AWS private clusters

create infra aws creates a $name.hypershift.local private DNS zone attached to the guest VPC.
CPO creates records in this zone for api.$name.hypershift.local and *.apps.$name.hypershift.local that point to the apiserver and ingress Endpoints respectively.
destroy infra aws removes the DNS zone
AWSEndpointService type changed to include new status fields: DNSName and DNSZoneID primarily for tracking for removal because the HCP might already be deleted by then.  Also nice from a UX/debuggability standpoint.

Thanks! Orthogonal question to the PR:
Is there any reason for the awsprivatelink controller to be life-cycled with the CPO? Seems to me it should be a Hypershift top level controller that the HostedController would run on each control plane namespace, like e.g ignition-server, autoscaler or CAPI

True, there might be a case for breaking this into a separate component at some point before we get it into the release payload.  We already have so many I didn't want to add another.  The size of our image is ballooning.
I would like to refactor our binaries into a single binary that has each component as a subcommand, then it would be easier to break this out I think.

/test e2e-aws

/test e2e-aws

/lgtm


Turn off fragment cache logging on production

This is a config that logs reads and writes to the fragment cache. Can be quite noisy.

coverage: 94.607%. remained the same
when pulling fae177f59291f03dd3253ae83b3185dc5077762d on nimmo-production-turn-off-fragment-cache-logging
into a803d4ab61666275e92397ad31e5c021f95218a4 on main.


Mini window does not respect --title none

This is for 1.11.2 preview 2 (2988).
When you create a mini window with --title none the window title will be a literal 'none'

It would be better if this showed no title, like with the normal window size.

@scriptingosx how does this look?
in addition to accepting --title none, I've re-done how the mini window is displayed entirely so you now get more lines of text. It is slightly taller as a result (128 instead of 125)
Here's some screenshots of how the mini window looks with various text and modes

small update to the button position so it's not so close to the text (if it ever gets that long)

and another for the text padding

Looks great, thank you!


Access Find reset via the eventBus

I'm looking for an API to clear the current search results for a Find operation through the eventBus.
I've been looking at the PDFFindController. I see the reset() function. It would be ideal if there was an event to reset the search. Would anyone know if there is one already? Perhaps a full event-driven API should be supported?

I've been looking at the PDFFindController. I see the reset() function.

That function, which is now marked as "private" (since its name is _reset), is/was only ever intended to be called when a new document is opened in the default viewer and not in other situations.

It would be ideal if there was an event to reset the search. Would anyone know if there is one already?

If I were to guess, I'd say that what's actually being asked here is for a way to cancel a running search operation and remove any active highlights. In that case, in the default viewer, it should be as simple as dispatching a find event with suitable parameters provided (i.e. query set to an empty string); please see e.g. the PDFFindBar implementation in https://github.com/mozilla/pdf.js/blob/ece6a31a442d8d2489817579dfc57ed371135d3a/web/pdf_find_bar.js#L94-L103
@timvandermeij Should the issue simply be closed as answered, since it's already possible to achieve this using existing events?

Yes, I don't see a need at this point to implement this.


MRTK SDK UX - ObjectCollection

Overview:
Porting ObjectCollection to the vNext branch. Allow users to easily arrange items in a grid in various volumes (planes, spheres, cylinders).
Changes:
Abstracted original ObjectCollection to a BaseCollection class. This makes for a good pattern to extend from in the future. Additionally, the custom editor script is now inherited by all children.
To use BaseCollection:
Inherit BaseCollection and override the abstract method LayoutChildren(). Easy as that.

Updates made. Left CollectionNode is a class -> had some value assignment issues with structs being immutable. Left the public Action alone as well as the protected virtual method LayoutChildren. The base class approach will give more for free (not needing to implement UpdateCollection() etc) vs an interface.

Okay, sorry about the crazy merge history. We should be good now. I might have missed something as I rolled WAY back to get to a clean spot. Notable change: added the ...Enum suffix to any enum I'm modifying or adding.

Let's be sure to make all the icons the same for the collection components.

Also please be sure to assign the editor inspector icon and rename this class to BaseCollectionInspector

Okay, I think I addressed everything. @StephenHodgson as far as the icon inconsistency, it makes sense to me for the actual UX component script to have the UX icon. Everything else is a back end script (and has the script icon). but the GridObjectCollection script is what you actually apply in a unity scene. I would expect the icon to reflect that.

@SimonDarksideJ added a demo scene! Hopefully we're good to go. Your columns warning was actually a symptom of a larger bug - at some point I deleted the line that sets columns, kinda problematic considering its required for layout... 😄

@Ecnassianer scatter is arguably still a "grid" layout, but its always felt like the odd man out. I've gone ahead and moved it to its own script, to minimize the amount of refactoring and duplicate code, I have it extending the GridObjectCollection and changed a few of the access modifiers in GridObjectCollection to make that work. Other than that, I'm with you on the suffixes, I prefer enum over type.

@Ecnassianer I just reread your comment - you're suggesting type over enum! @davidkline-ms @StephenHodgson @SimonDarksideJ what is the call here? I'm happy to go with either.

How come you approved this @davidkline-ms with a reported warning and your "nit" comment?
Especially can't have PR's generating warnings in the project at this stage

because an extra blank line or two is a nit-pick and not, in my book, a merge blocker.  I didn't notice the missing initialization, besides that is far less of a concern than breaking changes at this point in the project.

@radicalad We've typically been using Type as the suffix for enums in vNext. Not sure where/when/if an official decision was made (@davidkline-ms?), but I believe that's been case.

'Type' it is then. Just want to be consistent.

Not sure where/when/if an official decision was made (@davidkline-ms?), but I believe that's been case.

I honestly do not recall. I believe we are not 100% consistent (not all enums have Type or any other suffix)

Seems like this thread has critical mass to make an official decision?
Enum Suffix: 0
Type Suffix: 5 (David, Kurtis, Eric, Stephen Addison)

Just some nitpicky stuff but looks good.


Consider adopting the functional options pattern for advanced relayer configuration

Currently, there is an interface RelayerOption which defines an unexported function which is a no-op in in the implementations (I believe to narrow the set of types which implement this interface).
This implementation means that the exact types need to be known already before being able to apply configuration.
I think the functional options pattern would greatly simplify the workflow of configuring custom fields and also be more flexible in that it does not require the implementation (DockerRelayer) to specifically know about each type of configuration option.
package relayer

import (
	"github.com/strangelove-ventures/interchaintest/v6/ibc"
)

type RelayerOpt func(relayer *DockerRelayer) // could act on docker relayer directly or some additional options type to be more flexible with non-docker implementations.

func CustomDockerImage(repository string, version string, uidGid string) RelayerOpt {
	return func(r *DockerRelayer) {
		r.customImage.Repository = repository
		r.customImage.Version = version
		r.customImage.UidGid = uidGid
	}
}

func HomeDir(homeDir string) RelayerOpt {
	return func(r *DockerRelayer) {
		r.homeDir = homeDir
	}
}

Sample usage could look like
func NewDockerRelayer(ctx context.Context, log *zap.Logger, testName string, cli *client.Client, networkID string, c RelayerCommander, options ...RelayerOpt) (*DockerRelayer, error) {
	r := DockerRelayer{
           // default options
	}
        // any arbitrary configuration can happen here.
	for _, opt := range options {
		opt(&r)
	}
        //  rest of setup ...
}

Thanks @Reecepbcups! Changes look great 👍


chore: replace (Algebra.ofId R A).toLinearMap with Algebra.linearMap R A

A tiny bit of clean up, with the aim of increasing awareness of Algebra.linearMap

Thanks!
bors merge


ActiveMQ - "Unable to complete command: unable to create client: unable to create activemq client"

I'm running an ActiveMQ 5.16.0 instance, and I can't make plumber connect to it. The queue is protected by a username and a password.
telnet <IP_ADDRESS> 61616
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
;ActiveMQ
           )
              TcpNoDelayEnabledSizePrefixDisabled	CacheSize
                                                                  ProviderName ActiveMQStackTraceEnabledPlatformDetails	Java
                                                                                CacheEnabledTightEncodingEnabled
                                                                                MaxFrameSize@MaxInactivityDurationu0 MaxInactivityDurationInitalDelay'ProviderVersion	5.16.0^C^Z^CConnection closed by foreign host.

./plumber-linux read activemq --address="<IP_ADDRESS>:61616" --queue=myqueue --debug
INFO[0000]
█▀█ █   █ █ █▀▄▀█ █▄▄ █▀▀ █▀█
█▀▀ █▄▄ █▄█ █ ▀ █ █▄█ ██▄ █▀▄
FATA[0000] Unable to complete command: unable to create client: unable to create activemq client: EOF

@magnus-longva-bouvet
Thank you for reporting on this. Will take a look today and report back here!

Hi @magnus-longva-bouvet plumber currently only supports the STOMP protocol. We will work on getting JMS support added


Ensure that all sockets are connected after kernel restart

This will considerably slow down the kernel restart, but ensures that all sockets are connected after restarting. We still keep our old connection file though.
This fixes https://github.com/nteract/hydrogen/pull/877#issuecomment-309189724

I checked. And result is NOT good.
First of all, are you able to reproduce issue with the steps I explained?
This is super easy steps to reproduce issue(just keymap then hit several time on ijavascript kernel).
If this is not easy, that mean my environment specific issue, so we might not need to FIX this issue.
Anyway, this PR changes how issue be appear.
Here is the gif when issue was happened.

This means, let a is evaluated twice in same context.
This should not happen since command is restart-and-re-evaluate(not might-restart-and-re-evaluate).
I imagine something complex/confusing is happening like 2nd request goes to kernel just restarted and evaluated 1st request of restart-and-re-evaluate.
What I want is

Reproduce issue then see if we can fix some additional changes.
If not, just revet to previous implementation.
If reverting means also revert other fix, but it should be OK, better to retry fix based on correctly working behavior.

This means, let a is evaluated twice in same context.
This should not happen since command is restart-and-re-evaluate(not might-restart-and-re-evaluate).

I investigated what is happening in this situation.
I added debug output to restart function and reproduced.
  restart(onRestarted: ?Function) {
    // This guard is SUPER important to prevent simultaneous restart processing.

    // if (this.executionState === "restarting") {
    //   console.log('return ');
    //   return
    // }

    console.log('------------------');
    console.log('called restart');
    if (this.kernelProcess) {
      console.log('execution_state', this.executionState)
      this.setExecutionState("restarting");
      this.shutdown(true);
      this._kill();
      const { spawn } = launchSpecFromConnectionInfo(
        this.kernelSpec,
        this.connection,
        this.connectionFile,
        this.options
      );
      this.kernelProcess = spawn;
      this.monitor(() => {
        console.log('restarted');
        if (onRestarted) onRestarted(this);
      });
    } else {
      log("ZMQKernel: restart ignored:", this);
      atom.notifications.addWarning("Cannot restart this kernel");
      if (onRestarted) onRestarted(this);
    }
  }

This is output when "let a evaluated same context" issue happened.

What is happening here is "processing 2nd request before 1st restart yet not finished", so  "1st request's restart callback is evaluated in same environment of 2nd request".
To say simply both 1st and 2nd request is evaluated in same envorment where it should be separated.
We can prevent simple guard at restart entry point.

@lgeiger  I checked, with last commit and it's OK. I'm not sure who merge this? not me right?
As reviewer, I can say it's OK, ready!

Thanks a lot for investigating and the review!
I did test with both Python and Javascript and this PR fixes the issues. The only thing I didn't test was calling restart so fast that multiple restarts were run. In that case multiple execution requests are sent to the socket. Since we reuse the old connection config, the kernel then receives two execution calls and the second one fails with the error message above.
For me 475e6261b637989f2f65fc96f949f63efd499e10 fully fixes the issue described above.
I'm sorry for the many restart issues I introduced in my last PRs 😇
If there are still issues with this we can change this line to use launchSpec and call this.connect instead of this.monitor. This will effectively revert to the old restart mechanism without breaking the UI.

I checked, with last commit and it's OK. I'm not sure who merge this? not me right?
As reviewer, I can say it's OK, ready!

Awesome that's great! 🎉
Don't hesitate to go ahead merge this PR. As a maintainer and member of the nteract org you have the power 👍

WOW I'm happy, with this fix, the workflow I wanted for hydrogen finally perfectly work!

preset mark by toggle-bubble
then evaluate from top to bottom with cleanly started kernel environment by restart-and-re-evaluate

Yes no longer strange multi restart issue(I hope so this time again!!)

🆒  We've fixed quite a few bugs since our last release! We should ship a new minor version soon.


[scale-ts] better error handling for enums

When decoding an Enum, there should be a check on the idx such that idx <= entries.length. Otherwise, you get a bad error message when trying to destructure entries[idx] because it returns undefined.
Something like "Enum index exceeds Enum member size" ... basically a descriptive enough message such that I don't need to dig into the internals of scale-ts.
/home/ryan/Documents/Projects/capi2-playground/node_modules/.pnpm/scale-ts@1.3.0/node_modules/scale-ts/src/codecs/Enum.ts:39
    return {
           ^

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at <anonymous> (/home/ryan/Documents/Projects/capi2-playground/node_modules/.pnpm/scale-ts@1.3.0/node_modules/scale-ts/src/codecs/Enum.ts:39:12)
    at <anonymous> (/home/ryan/Documents/Projects/capi2-playground/node_modules/.pnpm/scale-ts@1.3.0/node_modules/scale-ts/src/internal/toInternalBytes.ts:60:5)
Node.js v20.3.1

When decoding an Enum, there should be a check on the idx such that idx <= entries.length. Otherwise, you get a bad error message when trying to destructure entries[idx] because it returns undefined.

I understand why you feel like this. However, please keep in mind that this library is very unapologetic about not dealing with input validations (for both: encoders and decoders). This is something that should be properly explained in the README, though, as I can see how this can be quite shocking. So, I will open an issue about that.


fix: removes DynamoId to Dynamoid typos in README.md

Starting with this project by checking the documentation in the README.md, there are some typos that could lead to debugging why the gem is not being loaded.

Looks great. Thank you.


Update json4s-core, json4s-native to 3.6.11

Updates

org.json4s:json4s-core
org.json4s:json4s-native

from 3.6.7 to 3.6.11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.json4s" } ]

labels: library-update, semver-patch

Superseded by #173.


Rhoda operator

Added manifests for Red Hat Openshift Database Access Operator
The same have been working fine when tested manually

Hi @veniceofcode .  Thanks for the contribution.  Can you please remove the .idea directory, and update the README.md file to describe the operator that is being installed (right now it's just copy/paste of the ACM README).

I also discussed this with @veniceofcode separately but I would recommend breaking the install.yaml file down into separate files for each component to keep it consistent with the rest of the catalog.

@strangiato , good points.  Once those little things are taken care of, it'll be a nice addition.  I will be AFK for about an hour.  I can merge then, or someone else can hit the button once it's ready :)

@pittar @strangiato Done, please review, i believe i removed the .idea in one of the commits

@veniceofcode - unless there's a caching issue on my end, it still looks like the README describes the Advanced Cluster Management operator, not RHODA.

@pittar I think issue was on my side, the commit has not picked up readme file before, i did again now , please check

Thanks for the contribution!


Module not found: After npm install styled-content-loader

Module not found: Can't resolve 'styled-components' in '/Users/Pritam/Documents/multiWeb/node_modules/styled-content-loader/dist'

@indventures styled-components is a peer-dependency of this package, you have to install it yourself.


ng-repeat and dburles:collection-helpers

I have an issue with collection-helpers inside an ng-repeat. It works fine when working with a single object e.g.: book.author() but the same does not work inside of an ng-repeat. This behaviour is already described here: https://forums.meteor.com/t/does-dburles-collection-helpers-work-with-angular-meteor/12800/5 but as far as I can tell there is no solution for this yet.

the same problem in this issue: #1142

@bartvanremortele Can you check if this helps

after upgrading to 1.3.5 meteor add<EMAIL_ADDRESS>this issue seems to be resolved. Thank you.


Add comments to CBL0006 and CBL0007

Since the Chapter 11.2.3 Conditional names isn't covered in the Labs, i changed the program in a way that the logic is different, but the task and results are the same. I also left the extra dot in the code, so you still have to search the error and correct it.

@klausmelcher Thanks for adding this! Do you think the comments can be added in the *.md file?
@MikeBauerCA What do you think?

@klausmelcher Thanks for adding this! Do you think the comments can be added in the *.md file?
@MikeBauerCA What do you think?
@jellypuno
I don't know how to obtain the same Syntax highlighting colors as used in the images of the *.md file

@jellypuno
I don't know how to obtain the same Syntax highlighting colors as used in the images of the *.md file

You can install COBOL Bitlang in your VSCode extension

@jellypuno I made an update to my pull request. I did not succeed in matching the colors exactly. If it is good enough, I can add further figures in my next pull request.

@klausmelcher I see you have added an image in this PR but do not reference it in the course. Where would you like to add the image?

@klausmelcher I see you have added an image in this PR but do not reference it in the course. Where would you like to add the image?

@MikeBauerCA The reference is in line 2895 of the COBOL Programming Course #1 - Getting Started.md file. I would like to replace the image which is already referenced with a new one with comments, as suggested by @jellypuno.


Fix CodeQL alert SM01507: Client-side URL redirect

Fixes #6537 #6521 #6514 #6500 #6499 #6498 #6497 #6496 #6495 #6494 #6493 #6492 #6491 #6490 #6489 #6488 #6486
Description
This PR fixes de CodeQL SM01507 alert related to open redirects by implementing a fixed domain for the script's src param.
Specific Changes

Updated build/AnalyzeDeps/InterdependencyGraph.html to append the domain URL to the data param.

Testing
We tested the changes locally rendering the HTML with and without the data query parameter.

Pull Request Test Coverage Report for Build 327818

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.009%) to 79.015%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
1
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
1
90.91%

/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs
1
90.0%

Totals

Change from base Build 327679:
-0.009%

Covered Lines:
25597

Relevant Lines:
32395

💛  - Coveralls


[Research] Usage of package nodegit in OUI

Research the usage of package nodegit in OUI and determine if we can get rid of this dependency.
Reason: nodegit depends on request which is deprecated and causing #630

@joshuarrrr,
May I take this issue?


Purge database

Hi,
I use the SQLite database, but it seems to be indefinitely growing (currently almost 100mb). It would be great if you could clear old data at server start or stop.
Also don't forget to call vacuum to actually reduce file size.

Well, calling VACUUM isn't enough, you need to remove some rows first to actually reduce database's size.
Maybe remove logs older than X months ?


No method to handle url escape characters

Special characters are represented as url escape from the html form. For example, ! is changed %21. This change prevents connecting to my wifi. I tried to correct this with urllib.parse.unquote, but that method used a particular string split that is not implemented in micropython, returning a NotImplemented error.

Hi @jlmontie, thanks for submitting this and sorry it's taken a while for me to get back to you. I took a look at Python's unquote_to_bytes() function in urllib, and implemented a stripped-down version that should take care of what you need. Please let me know if you run into any issues with it.

Hi @jlmontie, thanks for submitting this and sorry it's taken a while for me to get back to you. I took a look at Python's unquote_to_bytes() function in urllib, and implemented a stripped-down version that should take care of what you need. Please let me know if you run into any issues with it.


Asus R9290x-DC2-4GD5 support

Hi, can you verify that program displays data correctly?
Everything looks sane except  PowerTable content.
Bios link.
http://www.techpowerup.com/vgabios/157203/asus-r9290x-4096-140407.html

sure :)

its ok powertable content is only for visual control :D ill remove this in next itteration


Swagger tags (as opposed to operation tags)

The SwaggerTags attribute does it's job by leveraging operation tags.
What about the tags section in the Schema Object defined in the spec which is an Array Of Tag Object?
As this section in most cases is a summary of operations tags, shall this be defined by using an extended version Of the SwaggerTags attribute? E.g. A SwaggerTags which also leverage a description field.
What is your opinion on this topic?

Options:

Add new attribute: SwaggerTag("MyTag", "MyDescription")

How to define the External Documentation Object? Is it needed?

Add new constructor: SwaggerTags(params SwaggerTag[] tags)

Question: Is this even possible in an attribute (i.e. is it allowed to new new instances in an attribute ctor)?
Should we reference NSwag.Core in NSwag.Annotations (ugly, dependency should be avoided) or copy the classes (also ugly)

What do you think?

I would go with the first option.
The pluralized versions can be left as a quick way to specify multiple tags or deprecated.
Second option cannot be done because of impossibility to new objects in attribute ctors.

Is this ok?
https://github.com/NSwag/NSwag/blob/78e58ae639ae7043325f6f7d34fea12154feb7e1/src/NSwag.CodeGeneration.Tests/WebApi/Attributes/TagsTests.cs

It seems ok to me.
If I am not getting wrong however, document tags can be added by using one of the two attributes at the controller level while adding these to action methods leverages operation tags.
I would have done something more: that is, adding a tag at action method level would add those tags also at document level by merging these with properly defined ones. Example:
[SwaggerTag( "Basic", "Basic usage notes" )]
[SwaggerTag( "Advanced", "Advanced usage notes" )]
public async Task<HttpResponseMessage> Create( InputViewModel model ) {
    [...]
}

would produce the following swagger
{
  "swagger": "2.0",
  "info": {
    "title": "xxxx",
    "description": "xxxxx module",
    "version": "1.0"
  },
  "host": "api.myserver.com",
  "basePath": "/",
  "tags": [
    { "Basic", "Basic usage notes" },
    { "Advanced", "Advanced usage notes" }
  ],
  [...]
  "paths": {
    "/cp": {
      "post": {
        "tags": [
          "Basic", "Advanced"
        ],
      }
    }
}

This is because most of the times the tags at operation level are used to group operations in the generated docs while the referring group is elsewhere defined (document level).
This should only impact the generations phase where you it should be taken care of merging the resulting tags. Do you see any drawback in this?

The only problem: When operation tags are automatically added to the document tags, then you cannot add tags only to operations (which may be a use case).
What about if we support the SwaggerTagAttribute on operations and add an option "AddToDocument" (default: false) so that you can specify if it should also be added to the document?

Yes. That will be great.

Check the tests: https://github.com/NSwag/NSwag/blob/master/src/NSwag.CodeGeneration.Tests/WebApi/Attributes/TagsTests.cs
Is this as expected?


TOS-554 Minor UI issue - Data driven testing fields order is incorrect

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[DEVOPS-107]  Travis: resource diagnostics, cosmetic resource usage improvement

@int-index @georgeee so now we could try to enable haddock.


MINOR: exchanged addAll/putAll with parametrized constructor

Basic static analysis was done here.
I've exchanged all addAll/putAll methods that were stand right after creation of each particular HashSet/HashMap with parametric constructor of HashSet/HashMap.

Can you please resolve the merge conflict?

@ijuma yes, sure! now it's ready

@ijuma any updates regarding this PR? I can not merge it now anymore, because I've removed the branch for it.
If it possible that you can merge it, that would be very nice!

@guozhangwang @mjsax hey, sorry for inconvenience, but the branch for this issue was already removed. Thus, I cannot make a merge with current trunk. I've created another issue from current trunk.
Please check this ticket https://github.com/apache/kafka/pull/4521


Is there a step for having numpy in windows?

I'm trying to build on windows with python 3.11 and windows 11 but getting the following error after running script from the app. Is there an extra step to make it work that I'm missing? I couldnt find it in the documents
my requirements.txt
opencv-python==<IP_ADDRESS>
numpy==1.24.3

Install it via command:
    pip install numpy
Running Python program synchronously...Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\numpy\core\__init__.py", line 23, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\numpy\core\multiarray.py", line 10, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\numpy\core\overrides.py", line 6, in <module>
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'

many reasons, often due to issues with your setup or how NumPy was
installed.
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\main.py", line 2, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\bot.py", line 1, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\cv2\__init__.py", line 11, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\numpy\__init__.py", line 141, in <module>
  File "C:\Users\user\AppData\Local\Temp\serious_python_tempdc757e66\__pypackages__\numpy\core\__init__.py", line 49, in <module>
ImportError:

IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!

Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.
We have compiled some common reasons and troubleshooting tips at:

    https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

  * The Python version is: Python3.11 from "C:\Users\user\Documents\-\ui\-\build\windows\x64\runner\Debug\feribot.exe"
  * The NumPy version is: "1.24.3"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.

Original error was: No module named 'numpy.core._multiarray_umath'

Can you check if you have .pyd files inside __pypackages__ of packaged app?

Can you check if you have .pyd files inside __pypackages__ of packaged app?

I see a pyd file in cv2 folder. I dont see any in numpy folder or general pypackages


Drafts sidebar menu

Resolves #19360
This resolves the second part (adding a sidebar menu) of the issue mentioned above.
The first part (adding a feature to bulk delete drafts) of the issue is resolved by pull request https://github.com/zulip/zulip/pull/19943

I think this is looking pretty good now and could probably be merged!

This bug where the popover is still visible was caused by a copy-paste-o (referencing starred_messages_popover_elem instead of drafts_popover_elem).  I fixed that before squashing and merging.

Thanks @juliaBichler01!  For future pull requests, please use the git rebase -i upstream/main tool to clean up your work before submitting it for review.
Check out our GitHub guide and commit guidelines for more details.

The 3-dots menu added here is colored very differently from the others (although the others were already somewhat inconsistent):

#20600


updating completion time and removing outdated image

What was changed
Updating the completion time estimate and removing an outdated picture

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Complete Flutter 3.10.5 support also Add Material You 3.0

Adding material 3.0 inside the priject will help a lot

how can i help you?

as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design.
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

// This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

Thanks, I already did, but is this package using material 3.0? In other
words
On Mon, Jul 17, 2023, 8:51 AM yoer @.***> wrote:

as i knows, just set useMaterial3: true inside ThemeData of YOUR
MaterialApp, this will change the regular Material Design of your app to
the latest Material 3 design.
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
useMaterial3: true,
primarySwatch: Colors.blue,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637337303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Thanks, I already did, but is this package using material 3.0? In other words
…
On Mon, Jul 17, 2023, 8:51 AM yoer @.> wrote: as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design. import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({Key? key}) : super(key: key); // This widget is the root of your application. @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true, primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY . You are receiving this because you authored the thread.Message ID: @. com>

To support Material 3.0, is there anything I can do to help?
I noticed that the zego_uikit_prebuilt_call_flutter package does not use the MaterialApp widget internally.
Could you let me know if there's anything I can do to support Material 3.0?

No just keep the project updated with latest depedencies

The Ui kit Icons should match the material UI guidelines, for instance,
just look at the new Google home app(irrelevant) but thats the UI google
recommends to use
On Mon, Jul 17, 2023 at 9:02 AM yoer @.***> wrote:

Thanks, I already did, but is this package using material 3.0? In other
words
… <#m_-7603209726621074222_>
On Mon, Jul 17, 2023, 8:51 AM yoer @.> wrote: as i knows, just set
useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change
the regular Material Design of your app to the latest Material 3 design.
import 'package:flutter/material.dart'; void main() { runApp(const
MyApp()); } class MyApp extends StatelessWidget { const MyApp({Key? key}) :
super(key: key); // This widget is the root of your application. @OverRide
https://github.com/OverRide Widget build(BuildContext context) { return
MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true,
primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo
Home Page'), ); } } — Reply to this email directly, view it on GitHub <#15
(comment)
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637337303>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY
https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY
. You are receiving this because you authored the thread.Message ID: @.
com>
To support Material 3.0, is there anything I can do to help?
I noticed that the zego_uikit_prebuilt_call_flutter package does not
use the MaterialApp widget internally.
Could you let me know if there's anything I can do to support Material 3.0?
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637343564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSCTSLSS6T4J3EQQZ23XQS2MRANCNFSM6AAAAAA2JAWPDY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Which icons do you want to replace? Give me a list and we will provide you with the configuration.

I meant in general, material you look and feel. Kindly see material
guidelines
On Tue, Feb 6, 2024, 9:16 AM yoer @.***> wrote:

Which icons do you want to replace? Give me a list and we will provide you
with the configuration.
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1928756276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSHOU3WOPTNS4MEH3ZLYSGVDHAVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYG42TMMRXGY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Do you mean to set our interface to material style by default?
But, different users have different needs, and we currently have no plans to invest more in design manpower.
So overall, providing more configuration about styles is the optimal solution.
So if you have any needs, you can let us know.

Thanks your services are already amazing, but kind of complex..... kindly
make the process faster and simpler and remove useless extra stuff needed
for the first time.
On Tue, Feb 6, 2024 at 12:45 PM yoer @.***> wrote:

Do you mean to set our interface to material style by default?
But, different users have different needs, and we currently have no plans
to invest more in design manpower.
So overall, providing more configuration about styles is the optimal
solution.
So if you have any needs, you can let us know.
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1928946276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSDZEI6UHV2G5I7CPIDYSHNP3AVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYHE2DMMRXGY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Thank you very much for your compliment. We have been working hard to simplify our customers' work.
There are two aspects of known complexity.
One is the most complex offline call configuration, which we currently provide with videos and documents for guidance.
The other is because call invitations require page navigation, while in Flutter, you know, context needs to be used.
On the above two points, we will try to consider using APIs with more simpler designs.
Also, if you say complex about other aspects, please provide more detailed examples, we would be very grateful to you.

Thanks :) Good Luck. Hope to see more updates and easier functions soon!
On Thu, Feb 8, 2024 at 11:07 AM yoer @.***> wrote:

Closed #15
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#event-11741157505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSEE4K23OUXV6VLMOETYSRTSVAVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG42DCMJVG42TANI
.
You are receiving this because you authored the thread.Message ID:
<ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issue/15/issue_event/11741157505
@github.com>


URL trace "Custom date range"

Hello,
When running a URL trace with start date more than 7 days ago and not changing the end date, an error will be thrown.
This article should mention that the date-range cannot be more than 7 days.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc5522e1-7041-205a-7a97-1622118d9d58
Version Independent ID: 0e5702db-abe5-9172-cab6-676952313b66
Content: Get-UrlTrace (exchange)
Content Source: exchange/exchange-ps/exchange/advanced-threat-protection/Get-UrlTrace.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@chrisda can you help me to confirm this?
Thank you

Hi @JeroenDronkers thanks for your feedback, we will improve the article based on your suggestion.
Thank you

@chrisda please merge this PR, if you find it suitable.

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @JeroenDronkers Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close

This document really needs some description around the Output values. I can advise on some of these (as they are sometimes confusing). Please reach out to me if necessary.

Hello @aldoug I see that you opened another issue https://github.com/MicrosoftDocs/office-docs-powershell/issues/3338 we will handle your inquiry in that one. This one will stay closed. thanks.


SaveChangesAsync does not save changes made in the context to the database.

SaveChangesAsync does not save changes made in the context to the database.
Exception message:
System.InvalidOperationException: The connection was not closed. The connection's current state is connecting.

Stack trace:
Exception thrown: 'System.InvalidOperationException' in System.Data.SqlClient.dll
Exception thrown: 'System.InvalidOperationException' in System.Private.CoreLib.dll
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\sdk\NuGetFallbackFolder\system.text.encoding.codepages\4.5.0\runtimes\win\lib\netcoreapp2.0\System.Text.Encoding.CodePages.dll'. Cannot find or open the PDB file.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.2.4\System.Diagnostics.StackTrace.dll'. Cannot find or open the PDB file.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.2.4\System.Reflection.Metadata.dll'. Cannot find or open the PDB file.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.2.4\System.IO.FileSystem.dll'. Cannot find or open the PDB file.
Microsoft.EntityFrameworkCore.Database.Connection:Debug: An error occurred using the connection to database 'mydb' on server 'xxxxxx'.

System.InvalidOperationException: The connection was not closed. The connection's current state is connecting.
   at System.Data.ProviderBase.DbConnectionClosedConnecting.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.OpenAsync(CancellationToken cancellationToken)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenDbConnectionAsync(Boolean errorsExpected, CancellationToken cancellationToken)
Exception thrown: 'System.InvalidOperationException' in Microsoft.EntityFrameworkCore.Relational.dll
Exception thrown: 'System.InvalidOperationException' in System.Private.CoreLib.dll
Exception thrown: 'System.InvalidOperationException' in System.Private.CoreLib.dll
Exception thrown: 'System.InvalidOperationException' in System.Private.CoreLib.dll

efcore_sqlserver_trace.txt
I have attached the trace files.
Steps to reproduce
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Debug;
using System;

namespace CodeFirstAsync
{
  class Program
  {
    static void Main(string[] args)
    {
      Console.WriteLine("Hello World!");
      Program p = new Program();
      p.Run();
    }

    public void Run()
    {
      try
      {
        using (var db = new BloggingContext())
        {
          db.Database.EnsureDeletedAsync();
          db.Database.EnsureCreatedAsync();
          var blog = new Instructor { Name = "async" };
          db.Instructors.Add(blog);
          db.SaveChangesAsync();
        }
      }
      catch (Exception error)
      {
        Console.WriteLine(error.ToString());
      }
    }
  }

  public class BloggingContext : DbContext
  {
    public static readonly LoggerFactory MyLoggerFactory
    = new LoggerFactory(new[] { new DebugLoggerProvider((_, __) => true) });

    public DbSet<Instructor> Instructors { get; set; }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
      base.OnModelCreating(modelBuilder);
    }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
      optionsBuilder.UseSqlServer(@"YOUR CONNECTION STRING").UseLoggerFactory(MyLoggerFactory);

      optionsBuilder.EnableSensitiveDataLogging();
    }
  }

  public class Instructor
  {
    public int Id { get; set; }
    public string Name { get; set; }
  }
}

Further technical details
EF Core version: 2.1.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Microsoft Windows 10
IDE: Visual Studio 2017 15.9.11

You did not await the async call so DbConnection is closed before SaveChangesAsync finishes. Feel free to re-open issue if you hit error after awaiting the async method properly.

@smitpatel , thanks for pointing out the issue with the test case.
Now after adding the await keyword,I do not see any error's while executing the test case. However I am noticing that the table is NOT getting created in the database.
So I have created another github issue, since I am not able to re-open this one. #15961


Add Support for Merging Unstable Pull Requests

This adds support for merging unstable pull requests; particularly useful in the case where users want to merge pull requests generated from this app but fails in their Github workflows (for example due to lack of credits).
Fixes #173

Since I was not granted write permission to the original branch, i'm creating a new branch to resolve the conflicts.


latest rancher-compose, default.go -> os-config.yml

First, rancherio/rancher-compose#26 should be merged.
Then, Godeps in this PR should be updated w/ rancher-compose master.

@ibuildthecloud good to merge

addressed in #392


Slayer Streak Bonus point notifier

Added a chat notification when you are on a slayer streak ending with 9.
This allows the player to easilier switch to duradel for max slayer points
https://github.com/runelite/runelite/issues/5396

This could be improved to compare the local players combat level and slayer level to recommend their highest slayer master available to them and not just recommending Duradel.

This could be improved to compare the local players combat level and slayer level to recommend the highest slayer master available to them and not just recommending Duradel.

Yeah i have a checkstyle error anyway. Ill implement it when i get home.

It should not reccomend any slayer master imo, just send notif that you are on close to 10th slay task

It should not reccomend any slayer master imo, just send notif that you are on close to 10th slay task

Ok, ill do that.


Broken links for binary download

Component
Other (please describe)
Have you ensured that all of these are up to date?

[ ] Foundry
[ ] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
None
Describe the bug
In the release section, quick links to binary download are broken, only the asset section works for downloading.
https://github.com/matter-labs/foundry-zksync/releases/tag/v0.0.1-alpha.2

@dymayday thanks this is expected behaviour as a result of how github handles pre-releases. Will update to remove for pre-releases in future releases.

Removed in latest pre-release, as seen here: https://github.com/matter-labs/foundry-zksync/releases/tag/v0.0.2-alpha.3


Add exception for Mage Training Arena items

Mage training arena items are always bad alchs, so the items are hidden. However, this can be confusing, as these items aren't typical items and the failsafe that this plugin acts as is often not consciously being considered, leading to people unaware that this plugin is blocking the entire MTA alchemy room.

Good callout! I'll update that ASAP.

Thanks for the report! It's currently pending RuneLite Plugin Hub approval. You can track that here: https://github.com/runelite/plugin-hub/pull/5472


Implement did url deferencing

The query_did rPC need to implemented based on the spec. See the spec to understand how did resolution should happen
https://www.w3.org/TR/did-core/#did-resolution
Implement did URL
https://www.w3.org/TR/did-core/#did-url-syntax
A user should be able to query the didDoc using these params

[ ] did query
[ ] did path
[ ] did fragment

Example of DID Resolution: https://w3c-ccg.github.io/did-resolution/#example

Source: https://www.w3.org/TR/did-core/#did-resolution

Narrative Description:
The upper middle part of the diagram contains a rectangle with dashed grey outline, containing two blue-outlined rectangles, one above the other. The upper, larger rectangle is labeled, in blue, "Core Properties", and contains the following INFRA notation:
«[
"id" → "example:123",
"verificationMethod" → « «[
"id": "did:example:123#keys-1",
"controller": "did:example:123",
"type": "Ed25519VerificationKey2018",
"publicKeyBase58": "H3C2AVvLMv6gmMNam3uVA"
]» »,
"authentication" → «
"did:example:123#keys-1"
»
]»
The lower, smaller rectangle is labeled, in blue, "Core Representation-specific Entries (JSON-LD)", and contains the following monospaced INFRA notation:
«[ "@context" → "https://www.w3.org/ns/did/v1" ]»
From the grey-outlined rectangle, three pairs of arrows extend to three different black-outlined rectangles, aligned in a horizontal row side-by-side, in the bottom half of the diagram. Each pair of arrows consists of one blue arrow pointing from the grey-outlined rectangle to the respective black-outlined rectangle, labeled "produce", and one red arrow pointing in the reverse direction, labeled "consume". The first black-outlined rectangle in the row is labeled "application/did+ld+json", and contains the following JSON-LD data:
{
"@context": ["https://www.w3.org/ns/did/v1"],
"id": "did:example:123",
"verificationMethod": [{
"id": "did:example:123#keys-1",
"controller": "did:example:123",
"type": "Ed25519VerificationKey2018",
"publicKeyBase58": "H3C2AVvLMv6gmMNam3uVA"
}],
"authentication": [
"did:example:123#keys-1"
]
}
The second rectangle in the row is labeled "application/did+json" and contains the following JSON data:
{
"id": "did:example:123",
"verificationMethod": [{
"id": "did:example:123#keys-1",
"controller": "did:example:123",
"type": "Ed25519VerificationKey2018",
"publicKeyBase58": "H3C2AVvLMv6gmMNam3uVA"
}],
"authentication": [
"did:example:123#keys-1"
]
}
The third rectangle in the row is labeled "application/did+cbor", and contains hexadecimal data.
In the left part of the diagram, in the middle, there is a box, with black outline and light gray background. This box is labeled "VERIFIABLE DATA REGISTRY" and contains a symbol representing a graph with nodes and arcs. From this box, one arrow, labeled "resolve()", extends upwards and points to the top half of the diagram where the grey-outlined rectangle is located. Another arrow, labeled "resolveRepresentation()", extends downwards and points to the bottom half of the diagram, where the row of three black-outlined rectangles is located.

Source: https://www.w3.org/TR/did-core/#did-resolution

Narrative Description: https://www.w3.org/TR/did-core/#resolve-resolverepresentation-longdesc

this should be in the #82 right?

Dereferencing is part of DID Resolver. Hence, moving this card to hs-ssi-js-sdk for now


Tailwarden

Their main repo is https://github.com/tailwarden/komiser.
Licensed under ELv2.
Advertised as open source in their repo, website and marketing.
Raised in https://github.com/orgs/tailwarden/discussions/864.

Further continued promotion as open source:
https://www.producthunt.com/posts/komiser-v3
https://www.reddit.com/r/SideProject/comments/179sz07/side_project_turned_opensource_tool_launch/


how can I give guest or having *  level users insert access .

I am building application where guest users can add data to collection but getting access denied (403) error , is there any way to do same ?

please use stable version and simply add the access from mugen role menu


extension cord

Extension cord is needed to reduce the number of electrical connects that have to be made to a wall outlet. This will also reduce the stress of the cords that are connected to the Pi and the relay board.

Cord has been purchased and installed.


Make Client a Context Manager

Describe the solution you would like
I would like Client and AsyncClient to have __exit__ (and __enter__ of course) methods that automatically call .close upon being done with the client context.
Describe alternatives you've considered
I've considered creating a subclass myself that does this but to write it from scratch in every bot/app is not optimal.

Feel free to assign me.

Hi, thank you for the feature request! I would be more than happy to implement this for Client (and Async client).
But, quick question - Won't this enable making multiple instances/instantiating the client everytime you use it through context managers, making it kind-of repetitive?
It would be great if you can show me an example, and I can assign you if you're interested, or I'll integrate that through my PR #305.

Yay!
As I told you on discord you can initialize it before and reuse the object between contexts like this.

client = Client(..., ...)

with client:
    ...

async with client:
    ...


#230 - temp directory for meta

Draft for #230.

Codecov Report

Merging #238 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
- Coverage     80.17%   80.16%   -0.01%
- Complexity      214      215       +1
============================================
  Files            37       37
  Lines          1175     1180       +5
  Branches         52       52
============================================
+ Hits            942      946       +4
- Misses          224      225       +1
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/artipie/rpm/ModifiableRepository.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

src/main/java/com/artipie/rpm/Rpm.java
44.89% <75.00%> (+1.23%)
25.00 <2.00> (+1.00)

src/main/java/com/artipie/rpm/Repository.java
100.00% <100.00%> (ø)
6.00 <2.00> (ø)

...rc/main/java/com/artipie/rpm/pkg/MetadataFile.java
93.33% <100.00%> (ø)
8.00 <0.00> (ø)

...n/java/com/artipie/rpm/pkg/ModifiableMetadata.java
88.23% <100.00%> (ø)
5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d2b30...cbe2a5a. Read the comment docs.

This pull request #238 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@sereshqua/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

Pull request #238 was not merged, no payment for ARC, see §28

@0crat quality bad

Quality is low, no payment, see §31


Update lottery contract

Updated code and tests

You can also add message for admin to restart the lottery if necessary. And you also need to test the states

Added


HoverDetail shows info for wrong bar

Using a bar chart with 2 bars only, adding the HoverDetail feature.
If I move the mouse from left to right I observe the following:
at left of 1st bar, correct information shown
at right of 1st bar, incorrect: info for 2nd bar is shown
at left of 2nd bar, incorrect: info for 1st bar is shown
at right of 2nd bar, correct information shown
There also seems to be issues on the Y axis - the label doesn't change immediately as you move into a stacked segment.

	<link rel="stylesheet" href="lib/rickshaw-1.5.1.css">

Hi. I've seen a similar issue as well, and implemented a fix. The symptoms I've seen weren't quite the same as yours, as moving the mouse to the right of the last bar for me resulted in the bar to the left of the last one being active. The fix addresses that behavior, although it's not perfect as the first bar now is only active if the mouse floats over the left half of that bar.
The change is made within the file, "rickshaw.js". Search that file for the following line:
if (data[i + 1].x <= domainX) { i++ } else { i— }
Then try replacing that line with the following code:
if (data[i + 1].x <= domainX) {
i++;
if(i == (data.length - 1))
dataIndex  = i;
} else { i-- }
Hope this helps

Could reproduce as well, @RashidClark code fixed it so thank you for that !

I'm running into this now as well. Still an issue on Chrome 55 ... but works just fine on Firefox 50.1.0.
Turns out this is a known issue in how Chrome handles certain types of elements like SVG:
https://bugs.chromium.org/p/chromium/issues/detail?id=592316


Provide safe wrappers for thread notification API

Furi provides access to FreeRTOS Task Notification feature which can be used for syncronization between threads.
Task notifications act as u32 bitmask, so can be used to signal multiple potential interesting states on the target thread.

@JarvisCraft Thanks for the review. I've accepted your suggestions and added the repr(transparent) annotation.


chore(main): release taiko-alethia-protocol 1.11.0

:robot: I have created a release beep boop
1.11.0 (2024-12-27)
Features

protocol: add DevnetTaikoL1 (#17900) (d864cea)
protocol: add lastProposedIn to slotB (#18379) (96b380a)
protocol: add proposeBlocksV2 method to ProverSet (#18115) (0743a99)
protocol: add proveBlocks method to ProverSet (#18025) (36a2ae5)
protocol: add proveBlocks to TaikoL1.sol (fe687b3)
protocol: add TIER_ZKVM_RISC0 tier and HeklaTierProvider (#17913) (64ed666)
protocol: add a batch proposing block function (#17864) (3649785)
protocol: add aggregated sgx verify test (#18160) (8dda47b)
protocol: add ComposeVerifier, TeeAnyVerifier, and ZkAnyVerifier (ee464ca)
protocol: add EIP-2612 (permit extension) to bridged ERC20 tokens (#17818) (185ef91)
protocol: add Hekla Ontake hardfork upgrade scripts (#18103) (a3436e8)
protocol: add preconfirmation support based on https://github.com/taikoxyz/taiko-mono/pull/17654 (with some renaming) (https://github.com/taikoxyz/taiko-mono/issues/14793) (17d67d7)
protocol: add proposeBlock2 in TaikoL1.sol and approve2 in GuardianProver.sol (17d67d7)
protocol: add proposer address to getMinTier func (#17919) (d6ea6f3)
protocol: add SP1 verification support (#17861) (2936312)
protocol: add withdraw eth function to proverset (#17800) (bb2abc5)
protocol: adjust gas excess once the gas target has changed (a1e217e)
protocol: adjust the zk ratio(risc0 & sp1) (#18613) (431435e)
protocol: allow local.params.parentMetaHash to remain as 0 (#18451) (94185fe)
protocol: allow a grace period (4h) to defer proof submission to reduce cost (fe687b3)
protocol: allow any address to withdraw token to the recipient address (#17843) (3d89d24)
protocol: allow any ERC20 tokens or Ether to be used as bonds (#18380) (1920521)
protocol: allow contract proposers to use calldata for DA (17d67d7)
protocol: allow msg.sender to customize block proposer addresses (#18048) (22055cc)
protocol: allow owner to update recipient in TokenUnlock (#18184) (773ae1b)
protocol: change HeklaTaikoToken's clock mode to timestamp to test the DAO (#18597) (ccc9500)
protocol: check-in HeklaTaikoToken (#18189) (60c38d8)
protocol: decrease the rate of risc0 in Hekla (#18553) (57d20db)
protocol: enable sp1 batch aggregation (#18199) (038cd32)
protocol: enhance nextTxId logics in  DelegateOwner (#17718) (85b2cad)
protocol: improve getTransitions (#18181) (868d733)
protocol: improve L2 basefee calculation (920bd68)
protocol: increase risc0 frequency in Hekla (#18407) (350264c)
protocol: Increase the probability of sgx proof for lab proposer (#18288) (fd0dbbb)
protocol: increase zk(risc0 & sp1) rate in mainnet (#18481) (f24a908)
protocol: introduce getTransitions in TaikoL1 (#18154) (273bf53)
protocol: introduce ForkManager to improve protocol fork management (#18508) (ff5c196)
protocol: introduce risc0 proof (#17877) (bcb57cb)
protocol: make TaikoL2Deprecated ABI go-ethereum compatible (#18659) (05594cf)
protocol: make sure init() covers logics in init2(), init3().. (#18292) (9d06958)
protocol: measure gas per block using a debug event (#18470) (e84e472)
protocol: propose a batch blocks conditionally (#18570) (e846f62)
protocol: protocol monitors (#18002) (45b2087)
protocol: relocate L2 base fee parameters to L1 configuration (17d67d7)
protocol: rename B_BLOCK_PROPOSER to B_PRECONF_REGISTRY (#18255) (bf3caf7)
protocol: request zk proofs(risc0 & sp1) in mainnet (#18467) (1fab427)
protocol: return verification timestamp in getLastVerifiedBlock (#17868) (1998288)
protocol: revert removing time as input for L2 base fee calculation (a1e217e)
protocol: script of UpgradeRisc0Verifier (#17949) (fc12e04)
protocol: scripts to deploy new mainnet implementation contracts (#18356) (269759b)
protocol: support backward-compatible batch-proof verification (#17968) (c476aab)
protocol: tolerate invalid BaseFeeConfig on L2 (#18338) (f9f5d15)
protocol: update B_TIER_ROUTER in RollupAddressCache (#18370) (9748ae5)
protocol: update HeklaTierProvider to introduce sp1 proof (#18022) (76b6514)
protocol: update ontakeForkHeight to Sep 24, 2024 (#18046) (30c9316)
protocol: update RollupAddressCache with new MainnetTierRouter address (#18619) (b2ca63c)
protocol: update Hekla ontakeForkHeight (#17983) (8819e3a)
protocol: update Hekla deployment (#17795) (cadaef8)
protocol: update mainnet ontakeForkHeight config (#18252) (7550882)
protocol: update ric0 & sp1 verification contract (#18269) (684a909)
protocol: update script of deploying sp1 (#18019) (9464967)
protocol: update sp1 contracts (#18097) (6f26434)
protocol: update sp1 to 3.0.0 prod version (#18465) (0b11101)
protocol: upgrade script (#18334) (2c41dd1)
protocol: use SP1 1.2.0-rc with more proof verification tests (#18001) (f7bcf1d)
protocol: user smaller cooldown windows (#18345) (63455f9)

Bug Fixes

protocl: check blockId in getBlock and getBlockV2 (#18327) (4288fb6)
protocol: avoid invocation in Bridge message processing if calldata is "" and value is 0 (#18137) (10c2972)
protocol: correct the wrong router address for mainnet (#18291) (ae0a9da)
protocol: fix chainId in HeklaTaikoL1 (#17912) (8f31dd0)
protocol: fix a new bug in LibProposing (#18328) (7436bae)
protocol: fix an issue in same transition check (#18254) (233806e)
protocol: fix BridgedERC20V2.sol initializer logic (#17823) (d538d99)
protocol: fix bug in adjustExcess (920bd68)
protocol: fix DCAP configuration script (#18088) (e8618c5)
protocol: fix debitBond bug and add additional tests (#18443) (75ff1f8)
protocol: fix issue in mainnet deployment script (#18283) (5c371a1)
protocol: fix LibAddress.supportsInterface to handle undecodeable return data (#18286) (299b4c9)
protocol: fix permission in ComposeVerifier (#18302) (4c45d8b)
protocol: fix proposeBlock()'s block id check (#18227) (3a9d6c1)
protocol: fix test related to SendMessageToDelegateOwner.s.sol (#18300) (65daa3e)
protocol: fix tier id conflicts (#18004) (0df1ad4)
protocol: fix wrong Bridged ERC20 address cache (#18287) (49267ab)
protocol: make sure new instance is not zero address in SgxVerifier (#17918) (d559ce8)
protocol: revert B_TIER_OPTIMISTIC back to "" (#18446) (9549e7f)
protocol: revert a change to maintain taiko-geth compatibility  (#18331) (9d18d59)
protocol: revert changes related to proposedIn and proposedAt to fix a bug (#18333) (5cb43ab)
protocol: reward non-assigned prover 7/8 liveness bond (#18132) (9f99099)
protocol: small fix to 1559 error check (#18339) (4428661)
protocol: use block header's extraData for basefeeSharingPctg (#17889) (5f3cbc9)

Chores

docs: redirect the contribution.md path (#18316) (0607ef7)
main: fix misspelled (#18581) (3687c4e)
main: release protocol 1.10.0 (#18077) (3d12cb2)
main: release protocol 1.10.0 (#18365) (9345f14)
main: release protocol 1.11.0 (#18433) (75359cc)
main: release protocol 1.9.0 (#17783) (7bfd28a)
main: release protocol 1.9.0 (#18051) (2547ba9)
main: release protocol 1.9.0 (#18052) (bf45889)
protocol: add functions to ITaikoL1 for Nethermind Preconf (#18217) (e349d22)
protocol: change bond amounts, proving windows, and cooldown windows (#18371) (fac5c16)
protocol: change Hekla gas issuance per sec to 100000 (#18335) (3d448d4)
protocol: change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 (#18322) (75feb5b)
protocol: delete gas debug event (#18620) (06128e8)
protocol: deploy MainnetTierRouter and update RollupAddressCache (#18359) (aa351ab)
protocol: fix lint issue in SP1Verifier (#18213) (7874dd3)
protocol: fix typos in documentation files (#18490) (8d1f9ea)
protocol: improve the usage of initializer and reinitializer (#18319) (13cc007)
protocol: make two state variables in TaikoL2.sol public and add adjustExcess (#17891) (ba21f68)
protocol: move two files to simplify folder structure (#17929) (9dca4fa)
protocol: optimize Taiko L1 gas cost (#18376) (ea0158f)
protocol: re-generate layout files with diff order for comparison with new PR (#18067) (078d336)
protocol: remove TIER_ZKVM_ANY in MainnetTierRouter (#18357) (500a8bb)
protocol: remove repetitive words in audit report (#18584) (8092ee5)
protocol: restore proving window changes (#18368) (9182fba)
protocol: revert TAIKO_TOKEN name changes in DeployOnL1 (#17927) (cf1a15f)
protocol: revert Hekla baseFeeConfig updates (#18340) (ae8ac3c)
protocol: revert releasing protocol 1.9.0 (#17783) (#18049) (c033810)
protocol: set mainnet Ontake fork height (#18112) (8812eb2)
protocol: shorten imports in solidity files (#18221) (9b2ba6a)
protocol: undo 1.10.0 release (#18363) (116578e)
protoco: remove unused delegate owner deployment (#18290) (63ba863)
repo: improve documentation and changelog (#18489) (c7b9b4f)

Documentation

docs-site: address docs and scripts friction points (#17815) (c74968b)
protocol: add L2 DelegateOwner address in Hekla deployment docs (#17925) (fdec8db)
protocol: add mainnet zkVM verifiers deployment (#18454) (3481b68)
protocol: add Ontake fork audit report from OpenZeppelin (#18491) (e83adc0)
protocol: fix invalid links in docs (#18144) (c62f3f6)
protocol: update tier_router in hekla (#18352) (7c91a7d)
protocol: update tier_routerwith compatibility modifications (#18028) (c43cb0c)
protocol: update code4rena-2024-03-taiko-final-report.md (#18062) (fd68794)
protocol: update hekla change log about tier_router (#18023) (11e27d6)
protocol: update hekla change log about sp1 (#18020) (434bf3c)
protocol: update Hekla deployment (#17845) (d95cc36)
protocol: update Hekla deployment (#17924) (46a3e00)
protocol: update Hekla deployments (#17975) (c96627f)
protocol: update Hekla deployments (#18152) (6c7ff61)
protocol: update Hekla deployments (#18257) (fbb1c82)
protocol: update Hekla deployments (#18598) (a095c69)
protocol: update L1 deployment (#17789) (a889f1a)
protocol: update L1 deployment (#17804) (25ace9b)
protocol: update L1 deployment (#17812) (5b43df1)
protocol: update L1 deployment (#17817) (311c948)
protocol: update L1 deployment (#18299) (f60ce3e)
protocol: update mainnet deployment (#17846) (ba6bf94)
protocol: update mainnet deployment (#17847) (92344df)
protocol: update mainnet deployment (#18258) (eeeb4af)
protocol: update mainnet deployment docs (#18366) (bbd69ca)
protocol: update mainnet deployment docs (#18482) (9da8499)
protocol: update mainnet deployment docs (#18621) (eb542bf)
protocol: update mainnet deployment docs (#18645) (59d4f10)
protocol: upgrade protocol version in hekla to 1.10.0 (#18343) (4805024)
protocol: upgrade sp1 plonk verifier 2.0.0 (#18098) (cfd0e9e)
protocol: upgrade sp1 remote verifier in Hekla (#18469) (051b619)
protocol: upgrade sp1 verifier in hekla (#18027) (de27e6e)
protocol: upgrade verifiers to support proof aggregation in Hekla (#18453) (bfb0386)
protocol: upgrade zk verifiers in Hekla (#18279) (e98a1d5)
repo: improve grammar and readability (#18501) (61994ff)

Code Refactoring

protocol: add MainnetGuardianProver (#17805) (6f68316)
protocol: add MainnetSgxVerifier (#17803) (a4be247)
protocol: added cached version of the bridge and vaults (#17801) (b70cc57)
protocol: avoid writing livenessBond, proposedAt, and proposedIn to storage (17d67d7)
protocol: convert metadata from V2 to V1 only once (#17842) (55ced31)
protocol: delete packages/protocol/contracts/compiled (#17849) (1fd907c)
protocol: extra a new function in LibProposing (#18456) (5b4b0cd)
protocol: extract an IBlockHash interface from TaikoL2 (#18045) (bff481e)
protocol: improve MainnetSgxVerifier (#17811) (4e7a421)
protocol: introduce BlockV2 for client-side compability (#17935) (e46cf29)
protocol: name address manager param clearer (#17806) (1d5a6ff)
protocol: refactor TierProvider implementations (ee464ca)
protocol: remove ProposerAccess for easier composability (#17994) (80176a1)
protocol: remove the receive function from TaikoL1.sol (#17865) (3542420)
protocol: remove uncessary init2() from TaikoL2 (#17973) (4e08881)
protocol: remove unused code post Ontake fork (#18150) (8543cec)
protocol: restructure solidity code to match compilation targets (#18059) (adc47f4)
protocol: simplify mainnet address caching (ee464ca)
protocol: simplify some protocol code based on OpenZeppelin's recommendation (#18308) (fbad703)
protocol: slightly change defender monitors (#18086) (b93d056)
protocol: slightly improve EssentialContract (#18445) (3d077f8)
protocol: use npm to manage third-party solidity dependency (#17881) (d524e69)

Tests

protocol: add test case of risc0 groth16 (#17904) (90bc01d)
protocol: check LibEIP1559 function results in fuzz tests (#18475) (06e190c)
protocol: fix another L2 test failure (#18304) (b3dd4dc)
taiko-client: use env names which defined in flag configs (#17921) (196b74e)

Workflow

protocol: make the storage layout table clearer (#18633) (7394458)
protocol: revert releasing protocol 1.11.0 (#18662) (29ce093)
protocol: trigger patch release (1.10.1) (#18358) (f4f4796)
protocol: upgrade to use solc 0.8.27 (#18037) (3a56b57)

Build

deps: bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (#18539) (79f3fab)
deps: bump golang.org/x/sync from 0.9.0 to 0.10.0 (#18560) (3d51970)
deps: bump merkletreejs from 0.3.11 to 0.4.0 (#17942) (1624b71)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

taiko-alethia-protocol-v1.11.0
:sunflower:


Fix missing colors in action messages

This was heavily inspired by https://github.com/erming/shout/pull/664 (and discussion on https://github.com/erming/shout/pull/663) so kudos and credits go to @bews! \o/
This is also the last missing piece of https://github.com/thelounge/lounge/issues/31. I don't know why I didn't fix that earlier, really...
A few screenshots to illustrate this:

(We can't really see on this last one but `astorije` has a slightly different color.)

Looks all good to me. 👍
I think we were waiting to have a better way to deal with colors before we did this, but since that can take a while still I vote to merge this and deal with the colors as a whole separately.


Relation to bevy_pkv?

Hey, I think we might be trying to solve the same problem?
Just wondered if you looked at bevy_pkv? And if so, how is persistent different?

Hey, I've created https://github.com/umut-sahin/bevy-persistent/pull/12 to answer this in the README and I'd love to have your review before merging it. If you have time of course!


Determine what operational metrics we need to capture and track for SDK health

For this task, we need to determine what metrics are important for us to consume (from somewhere) and monitor (alarms, dashboards) such that we are able to assess the health of the Kotlin SDK.  This would be both for general usage/updates as well as service-specific changes (trebuchet).
Some ideas (not necessarily what we want to track but here for examples):

SDK published to public artifact repo (discrete event over time)
SDK build time in Trebuchet
Number of downloads from public artifact repositories (if available)

Resolving in favor of aws-sdk-kotlin#416.


Reflect Canada in the README

The README says that the service is limited to U.S. addresses. But an April 2016 email signals that the service now includes Canadian addresses.

Thanks for catching this, do you have a pull request to fix this?