Running ionic package release android fails after upload

I get this error message:
Error upload callback: TypeError: Cannot read property '0' of undefined (CLI v1.3.3)

After running ionic package release android:
X:projectname Robin$ ionic package release android
Loading projectname...
Android Keystore File (.keystore): /full/path/to/projectname.keystore
Keystore Alias: projectname
Keystore Password:
Key Password (optional):

Uploading app...
Successfully uploaded (e6b4980d)

Error upload callback: TypeError: Cannot read property '0' of undefined (CLI v1.3.3)

@rvanbaalen I've seen this when some have an invalid config.xml document or ionic.project file.
I'm trying to lock down which it is. Could you look at those files and see if they are ok? Id love to help you figure this out.

Thanks @jbavari
How am I supposed to verify if I have an invalid config.xml or ionic.project?
When I build locally, with cordova, there is no problem.

Thats a good question, ha! A user before had same error as you with some invalid characters in their config.xml, which is why I asked.
Ah, ok, that helps. Let me dig around a bit more.

Ok keep me posted. And let me know if you need anything.

I'm having this same issue as well, checked the config.xml or ionic.project files and they don't appear to have an issue (visibly).

@dallasclark @rvanbaalen - I've found the error with the help of @jeff-french.
I'll be trying to patch it up today or tomorrow and get another release out.

That would be great. By now Ive written my own bash scripts for building signing and deploying with Cordova but Im always keeping an eye on the Ionic tools.

This email was sent from my iPhone and therefore subject to typos and other inaccuracies.

On 15 feb. 2015, at 12:03, Josh Bavari<EMAIL_ADDRESS>wrote:
@dallasclark @rvanbaalen - I've found the error with the help of @jeff-french.
I'll be trying to patch it up today or tomorrow and get another release out.
—
Reply to this email directly or view it on GitHub.

@rvanbaalen or @jbavari can someone share a build sh scipt?
I've been trying to create my own to get an ad-hoc ipa crated but had no luck.
Here is my apptempt: https://gist.github.com/781bccbd8a581a21b888.git

@softBarbarian As far as building for iOS goes, I stop when Cordova created the xcode project. The tools out there that create an IPA from the command line are somewhat buggy in my experience (ios-deploy). They crash for unknown reasons. Therefore, my build script stops when Cordova created the xcode project file and opens that file. From there on the only thing I have to to is click 'Product -> Archive' to build the IPA. That's not so hard ;-)
On the Android side if things, I've fully automated the process from building the release-ready APK to signing it. I only have to upload the output APK to Google Play Store when the script is done.
I'll see if I can share anything soon.

@rvanbaalen cool, thanks a lot.
the gist that i posted actually uses OS X's tools to archive and sign the IPAs (if i get it to work)

Unfortunately, we will be suspending this feature and removing it currently from the CLI until some time in the future.
Sorry for the inconvenience.

Not production ready yet?


Improve Keyvault module load time

Similar to the fix in the batch module, delay load the operation handler.

View a preview at https://prompt.ws/r/Azure/azure-cli/5154
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.


Handle data mapper codeaction failing use cases

Purpose
To handle data-mapper code-action failing use cases
Fixes #27831
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Please get a sync from the latest master I have added diagnostic-api change into code-actions

Please get a sync from the latest master I have added diagnostic-api change into code-actions


Replace "Thread.exclusive" by "Mutex.synchronize"

Thread.exclusive is deprecated in Ruby 2.3 and "Mutex.synchronize" can be used instead.

Changes Unknown when pulling 49a93d67f3edf2ee55115ba933d1a093dcc7cf86 on VAGAScom:update_to_ruby_2_3_1 into ** on veny:master**.


Clean all of the data

We discovered through user testing that the data from twofactorauth.org needs lots of TLC for it to be actionable for users of 2FAN. This issue is to document some of those current issues and brainstorm ways to manually or automatically clean up the data. Where possible, improvements should be shared upstream with twofactorauth.org

[x] change linkedin.com to www.linkedin.com
[ ] add all of the subdomains for Google services. For example, there is no entry for mail.google.com
[x] chase.com and several other sites have a doc entry that is actually a local path. This points to a page on twofactorauth.org, but the doc field should be a FQDN. Fix these entries.
[ ] identify existing URLs that redirect to some other domain. The data includes both a service name and a service URL. The URL should be the fully resolved domain where possible so that tools like 2FAN can take action on it. The service name (not the URL) should be displayed in the UI, so the fact that the URL might point somewhere "weird" looking isn't really a problem if that is the true destination of the redirects.
[ ] Think about automated ways of identifying URLs that break. For example, sites that don't responsibly redirect links and they end up 404'ing

This is the commit that changed the URLs to Notes from FQDN to relative paths: https://github.com/2factorauth/twofactorauth/commit/146fa92b79a98f5dbf7b4900bb7a3666390cd989

I did not add entries for all Google subdomains, but did update the existing entry for gmail.com to mail.google.com instead

This issue should be decomposed into issues specifically for each remaining bullet item.

Reopened because I realized that I hadn't created PRs for twofactorauth.org to share the changes upstream.


Failure to configure all-in-one using AWS Marketplace AMI

Following the "all-in-one" instructions, when I attempt to create an all-in-one instance using the AWS AMI found in the Marketplace and authored by Stackstorm I encounter the following:

I cannot access the setup UI at "https://[PUBLIC_IP]/setup"
SSHing into the box is required after first boot to start services that were not started by default
After attempting a restart the UI at "https://[PUBLIC_IP]/setup" is still not reachable however "http://[PUBLIC_IP]:8080" is (this address is given after the restart completes). Unfortunately when I enter in the default admin credentials (as per the docs) I receive the following error: Unable to reach auth service. [auth:https://:9100]

Any help would be much appreciated!

It seems you looked up the AMI from AWS marketplace if I am not mistaken.
Did you follow instructions from http://docs.stackstorm.com/install/all_in_one.html#amazon-web-services-aws by any chance and ended up with these issues?

Correct. I actually tried both:

Starting from the recommended ubuntu AMI and then following the all-in-one instructions (this actually resulted in an error caused by a timeout on a key fetch)
Provisioning the StackStorm AMI available in the AWS EC2 marketplace

I was unable to get it working with either method unfortunately.
I'm really just trying to evaluate the product at stage so whatever help you could provide in standing up the all-in-one would be amazing!

Thanks for the clarification.
Lets try getting the ubuntu AMI + all-in-one installer to work. The StackStorm AMI in AWS EC2 marketplace is not recommended any longer and I am not certain it works.

this actually resulted in an error caused by a timeout on a key fetch

Please share the full log stored in /var/log/puppet.log to help debug this further.
Take a look at http://docs.stackstorm.com/install/all_in_one.html#installation-fails-oh-no. Not sure if you had a chance to try any of the retry steps.
Also, do join our community channel https://stackstorm.typeform.com/to/K76GRP. Often it is easier to help with issues via community channel a lot quicker.

I must have missed something the first time! My fault!
I tried a clean all-in-one installation from scratch again on a clean AWS Ubuntu 14.04 image and it worked!
Sorry to bother you with this! I really appreciate the rapid responses!

Closing issue. Please re-open if you are blocked. Alsom hope to see you on slack community!

Sorry to bother you with this! I really appreciate the rapid responses!

Not an issue :)
Glad it got resolved for you. Also, now that you have StackStorm running do join the slack community!


Error on Creating an action Tutorial

https://index.ros.org/doc/ros2/Tutorials/Actions/Creating-an-Action/
On the last step shows the command:
ros2 action show action_tutorials_interfaces/action/Fibonacci
But the correct command is:
ros2 interface show action_tutorials_interfaces/action/Fibonacci

Oh, ok.
Thanks!!!


cli: add --ignore-errors flag to 'popper run'

Currently, when the popper run command executes multiple pipelines (i.e. when no PIPELINE argument is given), the command exits as soon as a pipeline fails. For this issue, we will add a boolean --ignore-errors flag so that, when given, all pipelines are executed regardless of whether there is a failure.

Working on this one :)


refactor!: modify AccountAPI.sign_transaction to return TransactionAPI

BREAKING CHANGE: This is done to ensure account plugins have the ability to modify the transaction they are signing, i.e. for Gnosis Safe plugin.
What I did
fixes: APE-388
How I did it
When working on ape-safe, it became apparent that there needs to be a way for an account plugin that wraps some more complex processes with other accounts to be able to mutate the transaction to a different type.
This is also handy if the account plugin wants to make adjustments to things like gas, etc. of the transaction it is giving over to the signing process.
How to verify it
All tests pass, check with other account plugins (Trezor, Ledger)
Checklist

[x] All changes are completed
[x] All 2nd party plugins updated
- [ ] New test cases have been added
[x] Documentation has been updated

Note: considering adding **signer_options to sign_transaction


Dev4

abeg no vex say e been take so long, i am a rubbish boy lol. abeg check for corrections, so i round it up tomorrow

I'd look at it by the weekend and revert. As you can imagine, this NYSC final clearance is stressing my life out and eating my hours.

chieee


AccountInfoRequest validation connection support

A new inspection was created.

Hello @devpreview thanks for the PR.
Can you please clarify why this is needed ? Why use the connection name (mysql, sqlite, mongodb) to get the table name ?
If you use prefixes in your tables you should add that prefix to your database.php config file in your connection: 'prefix' => 'your_table_prefix'.
If you need the same connection with/without prefix just duplicate it and set the $connection property on model to use the one you need.
Don't forget to clear your config cache php artisan config:clear
Let me know,
Pedro

The inspection completed: No new issues

Hello @pxpm
I will refactor legacy project and
I have two connections:
mysql (default, with prefix 'v2_') connection for new models
'mysql' => [
  'driver' => 'mysql',
  'host' => env('DB_HOST', '<IP_ADDRESS>'),
  'port' => env('DB_PORT', '3306'),
  'database' => env('DB_DATABASE', 'forge'),
  'username' => env('DB_USERNAME', 'forge'),
  'password' => env('DB_PASSWORD', ''),
  ...
  'prefix' => 'v2_',
  ...
],

and mysql_compat (without prefix) connection for old models
'mysql' => [
  'driver' => 'mysql',
  'host' => env('DB_HOST', '<IP_ADDRESS>'),
  'port' => env('DB_PORT', '3306'),
  'database' => env('DB_DATABASE', 'forge'),
  'username' => env('DB_USERNAME', 'forge'),
  'password' => env('DB_PASSWORD', ''),
  ...
  'prefix' => '',
  ...
],

And Backpack Admin model Administrator with mysql_compat connection:
class Administrator extends Authenticatable
{
  ...
  protected $connection = 'mysql_compat';
  ...
}

On update /admin/edit-account-info I have error:
Illuminate\Database\QueryException
SQLSTATE[42S02]: Base table or view not found: 1146 Table 'sr111.v2_administrators' doesn't exist (SQL: select count(*) as aggregate from `v2_administrators` where `email` =<EMAIL_ADDRESS>and `id` <> 10)

I think need specifying the connection is necessary for such cases

Indeed, to use a different connection we need to add the connection to the string.

I'm not sure if this issue will pop in other places of backpack.

I think it will. What do you guys think about doing this inside getTableWithPrefix() - would that solve it everywhere? Good/bad idea?

@pxpm please check my last comment above, https://github.com/Laravel-Backpack/CRUD/pull/3687#discussion_r626128841
@tabacitu I tested, and we don't need to "hack" into getTableWithPrefix 🙌 😅
Using a different connection everything seems to work. Lists, Creates, Updates, probably only minor stuff may appear, things like what this PR fixes (profile update).


Tutorial/Documentation Papermerge on Windows

I was kindly asked to create a tutorial/documentation on how to run papermerge on windows.
Well, I never done that... And I don't see it as necessary. However, just as proof of concept will try that :).

Tesseract can be installed using Chocolatey; this might be the easiest way. This installs the alpha version of v5 right now.
The website starts, but errors when I try to upload anything. Following that I ended up here.

To provide Windows support, it may be helpful to use Python libraries where possible, rather than assuming command line programs are available (see https://github.com/papermerge/mglib/issues/1 for one such example).

To be honest, I don't use Windows platform - it is not that I don't like it - I just don't have access to one! Installing a windows instance and handling it is just too much for me (apart from licensing issues).
Papermerge DMS is designed to run on Unix compatible OS (Linux flavour or probably Mac OS).
I close this ticket as I find it irrelevant.


EOS Fix Scale on GiANT products

Fix the scale  from cm to mm and flip colorbar
1.) The color bar has been flipped.
- Blue is now subsidence (+ve. increase dist wrt Sat LOS)
-  Red is uplift  (-ve, decrease dist wrt Sat LOS). However, the sign of the values shown remain the same.
2.) Corrected time-series displacement unit in graph. (cm --> mm) Thanks to Cheryl’s investigation.
Same PR as:
https://github.com/earthobservatory/displacement-ts-server/pull/1

EOS Displacement TS server:
https://<IP_ADDRESS>/ts/?id=displacement-time-series-sbas_S1-TN69-20170813T095721Z-20190622T095804Z-8d993-v0.1/LS-PARAMS.h5

@pymonger @torresal

Great updates and fixes @shitong01. @torresal, please review and merge.


Unable to use DNS entries in Hue components

Home Assistant release with the issue: 0.77.1

Last working Home Assistant release (if known): probably never
Operating environment (Hass.io/Docker/Windows/etc.):  Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux

Component/platform: https://www.home-assistant.io/components/hue/

Description of problem: When adding manually a hue bridge (without discovery components enabled) the configuration cannot use DNS entries for Hue host.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# Doesn't work
hue:
  bridges:
    - host: hue_gw.infra

# Work well
hue:
  bridges:
    - host: <IP_ADDRESS>

# DNS entries work well
$ ping -c1 hue_gw.infra
PING hue_gw.infra (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from hue_gw.infra (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.428 ms

Traceback (if applicable): When verifying hue configuration with IP it works well, when setting a DNS entrie here is the parsing error :
  hue:
    - Invalid config for [hue]: not a valid value for dictionary value @ data['hue']['bridges'][0]['host']. Got 'hue_gw.infra'. (See /srv/homeassistant/conf/configuration.yaml, line 37). Please check the docs at https://home-assistant.io/components/hue/

Additional information:
DNS entries work for other components like yeelight, camera, ...

According to the documentation an IP address must be provided and not a host name: https://www.home-assistant.io/components/hue

one component does not mean that all others need to be identical to it, this is actually sounding more like a feature request and not a bug report

After more research (with hostname and not DNS entries) I found that it's a bug :

This is a feature request. My comment from the linked topic still stands: https://community.home-assistant.io/t/use-dns-names-instead-of-ip-address/48804/3?u=balloob


add content type for compatibility issue

Codecov Report

Merging #559 into master will decrease coverage by -0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
- Coverage     46.34%   46.33%   -0.01%
  Complexity     1359     1359
============================================
  Files           325      325
  Lines          8778     8779       +1
  Branches        841      841
============================================
  Hits           4068     4068
- Misses         4416     4417       +1
  Partials        294      294

Impacted Files
Coverage Δ
Complexity Δ

...al/spi/defaultimpl/DefaultSsoHeartbeatHandler.java
16.66% <0%> (-3.34%)
1 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8fa03...4a31a8f. Read the comment docs.


Javascript was a mistake

examine what you're doing

Reported and blocked due to harrasment.

Blocking is a good move.
If I may quote #Hacktoberfest from https://hacktoberfest.digitalocean.com/ :
"
Hacktoberfest® is open to everyone in our global community. Whether you’re a developer, student learning to code, event host, or company of any size, you can help drive growth of open source and make positive contributions to an ever-growing community. All backgrounds and skill levels are encouraged to complete the challenge.
"
But more specifically, this:
" ...and make positive contributions..."
This does not mean going around making headaches for developers. We work hard. Too hard to have to deal with script kiddies thinking its okay to use a public event meant for "...positive contributions..." to destroy or degrade someones hard work.
@qorg11 , until you shape up, I hope you never get that free T-shirt.


[Dynamic DAG] Replacing processor could fail if user config cannot be simply passed in

Even if we allow user to pass in config when replacing processor (#1366), some user configs are generated at client side and cannot be simply passed in. In that case, the replacing processor will throw exceptions since the required configs cannot  be found.

For example, Storm over Gearpump translates Storm Topology to Gearpump DAG at client side and set SpoutId/BoltId into Task config. On replacing processor, SpoutId/BoltId is  lost without keeping the config or redoing the translation.

We do not provide Dynamic DAG for Storm applications for now. Please open a jira at https://issues.apache.org/jira/browse/GEARPUMP if this feature is required.


Check location is set correctly on parse test

Codecov Report

Merging #115 (4f6c875) into main (8d79a7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   99.95%   99.95%
=======================================
  Files          49       49
  Lines        2281     2281
  Branches      113      113
=======================================
  Hits         2280     2280
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d79a7c...4f6c875. Read the comment docs.


Updated: Prop core to match E2 autocomplete description

Updated prop core wiki using API documentation auto-generator:
https://github.com/wiremod/wire/wiki/Prop-core

Looks good, but I'm wondering what this changes since the helper seems to already work without this.

Better and more accurate description


DSpace 7: Submission forms input-type "tag" - value with a comma is split into two values

Describe the bug
DSpace 7.6, Firefox
The submission forms contains a field with input-type tag and a controlled vocabulary. When the value contains a comma, e.g. "University xyz, Institute z", the value is split into two values.
To Reproduce
Steps to reproduce the behavior:

During submission, select a value with a comma for your field with input-type tag.
There are now two tags instead of one.

Expected behavior
The value (tag) should not be split into two values (tags).
Related work
Link to any related tickets or PRs here.

The same happens when I enter freetext in the tag field. A comma and semicolon mark the end of one value and start an new value. That's inconvenient, since some values may include a comma or semicolon. I cannot enter these.
We chose "tag" for our institutions, for example, because we like the handling better than the lookup option. So tags are sometimes more than just one word and may include a comma or a semicolon.


Provide example of json request using jq and -lazy

Question
Can you provide example of generating json targets using jq or other generator, I can't find out in which format vegeta expects body field to be.
Example what I'm tying to do:
jq -ncM '1 | while(true; .+1) |  {method:"POST", url:"http://:8080/v1", body:{fileId:. |tonumber|(.%5)|tostring|(.+"id"), thumbnailId:.|tostring|(.+"id")}, "header":{"Content-Type":"application/json;charset=UTF-8"}}'| vegeta attack -rate=50/s -lazy -format=json -duration=30s |  tee results.bin |  vegeta report
basically I'm creating new id for every thumbnailId and fileId is looping between 1 and 5
EDIT: forgot to mention, example above  returns
parse error: expected string near offset 49 of 'body'

I figured it out, haven't noticed that body must be base64 encoded. This is how it looks like now
jq -ncM '1 | while(true; .+1) | {method:"POST", url:"http://:8080/v1", body:{fileUrl:. |tonumber|(.%5)|tostring|(.+"id"), thumbnailUrl:.|tostring|(.+"url")} | @base64, "header":{"Content-Type":["application/json;charset=UTF-8"]}}'| vegeta attack -rate=50/s -lazy -format=json -duration=3s |vegeta encode| tee results.bin | vegeta report


Httpyac tests in Vscode Test Explorer

I have been using vscode-httpyac for a while now, and I love it!
But there is one thing I miss, and that's running my tests, the CLI supports running test and also the httpbook supports it.
I would like to use the native VS Code test explorer to run all of my httpyac tests.
PR is on its way 😉

Hello!
It's good idea! This is my some advices:

If the test icon is always show will be better when I write new http request.

Test explore may have other language result, such as go/python. Maybe http tests can be in a directory.

@li1234yun

If the test icon is always show will be better when I write new http request.

Yes I would have planned for the test icon to appear immediately when changes are made to a file. The necessary event registrations are still missing in the current state. I have broken the implementation of BramManual. I would have also built in the special case that when executing a test it behaves like when you press the CodeLens (directly show response in separate editor)

Test explore may have other language result, such as go/python. Maybe http tests can be in a directory.

Do you mean that the root folder should be something like httpyac Test Provider? I would have used the folder structure of the workspace directly. Similar to Jest Extension. Go Extension or Java Test Runner uses a language specific representation (packages, modules). Do you have a good idea, how to create a useful folder structure? The idea that I use information from .http files, I have discarded, because in large projects the performance suffers.

Hello @AnWeber

Do you mean that the root folder should be something like httpyac Test Provider?

Yes, becasue same workspace maybe exists multiple tests result, such as Go/Python etc. It will be better in one folder.

Do you have a good idea, how to create a useful folder structure?

Python use the project file layout.

Go use package module name and test file name.
AnWeber, you can refer them.  I think I would have used the folder structure of the workspace directly. is fine.

@AnWeber Do you have an idea when this will be released?
Thanks for all the refactoring, I learned allot from it 👍

@BramManuel Sorry that it takes longer. I stumbled across https://github.com/microsoft/vscode/issues/156925 and still had thought about using FileSystemWatcher and added more and more features. I will publish it the next days. I try today. Just one more small feature:-)

I have published the test controller support. Please test once and more suggestions. And thanks again for the PR @BramManuel


⚠ Bofrost.de has degraded performance

In 97fa9ff, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1192 ms

Resolved: Bofrost.de performance has improved in 39c3bc2.


mom5: use a more accurate name for an environment variable

While debugging an issue, I found that the variable name $SPACK_BUILD confusing because we use Spack to build MOM5 regardless of whether that variable is set to true of false.

Before merging this to main, I have to commit the following to MOM5's development branch:
diff --git a/exp/MOM_compile.csh b/exp/MOM_compile.csh
index b095b22..272054a 100755
--- a/exp/MOM_compile.csh
+++ b/exp/MOM_compile.csh
@@ -156,7 +156,7 @@ if ( $cosima_version ) then
     set cppDefs = "$cppDefs -DCOSIMA_VERSION"
 endif

-if ( ! $?SPACK_BUILD ) then
+if ( ! $?SPACK_FMS_EXTERNAL ) then
     echo "Building type=$type with internal FMS"
     source ./FMS_compile.csh
     set includes = "-I$code_dir/shared/include -I$executable:h:h/lib_FMS -I$executable:h:h/lib_ocean"
@@ -264,7 +264,7 @@ if( $type == ACCESS-OM || $type == ACCESS-ESM) then
     set srcList = ( $srcList access/shared )
 endif

-if ( ! $?SPACK_BUILD ) then
+if ( ! $?SPACK_FMS_EXTERNAL ) then
     set libs = "$libs $executable:h:h/lib_FMS/lib_FMS.a"
     if( $type == ACCESS-CM || $type == ACCESS-ESM || $type == ACCESS-OM || $type == ACCESS-OM-BGC) then
         set includes = "$includes -I$executable:h:h/lib_FMS"


opencv_perf_objdetect test "OCL_HOGFixture_HOG.HOG": unsupported call to function reduce_smem in normalize_hists_kernel

When running "bin/opencv_perf_objdetect" it gives the following warning/error you find below.
Deinlining the function "reduce_smem" like with the following patch fixes that, but i don't know if there is a more proper fix:
diff --git a/modules/objdetect/src/opencl/objdetect_hog.cl b/modules/objdetect/src/opencl/objdetect_hog.cl
index 4fae320..b43fe70 100644
--- a/modules/objdetect/src/opencl/objdetect_hog.cl
+++ b/modules/objdetect/src/opencl/objdetect_hog.cl
@@ -207,7 +207,7 @@ __kernel void normalize_hists_36_kernel(__global float* block_hists,
//-------------------------------------------------------------
//  Normalization of histograms via L2Hys_norm
//
-inline float reduce_smem(volatile __local float* smem, int size)
+float reduce_smem(volatile __local float* smem, int size)
{
unsigned int tid = get_local_id(0);
float sum = smem[tid];
Time compensation is 0
CTEST_FULL_OUTPUT
OpenCV version: 3.1.0-dev
OpenCV VCS version: 3.1.0-315-gecf65a0-dirty
Build type: release
Parallel framework: pthreads
CPU features: mmx sse sse2 sse3
OpenCL Platforms:
Clover
iGPU: AMD TAHITI (DRM 2.43.0, LLVM 3.7.1) (OpenCL 1.1 MESA 11.1.2)
Current OpenCL device:
Type = iGPU
Name = AMD TAHITI (DRM 2.43.0, LLVM 3.7.1)
Version = OpenCL 1.1 MESA 11.1.2
Compute units = 28
Max work group size = 256
Local memory size = 32 kB
Max memory allocation size = 256 MB
Double support = Yes
Host unified memory = Yes
Has AMD Blas = No
Has AMD Fft = No
Preferred vector width char = 16
Preferred vector width short = 8
Preferred vector width int = 4
Preferred vector width long = 2
Preferred vector width float = 4
Preferred vector width double = 2
[==========] Running 28 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 1 test from OCL_HOGFixture_HOG
[ RUN      ] OCL_HOGFixture_HOG.HOG
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
.
OpenCL program build log:  -D AMD_DEVICE
unsupported call to function reduce_smem in normalize_hists_kernel
[ PERFSTAT ]    (samples = 13, mean = 15608.84, median = 15618.32, stddev = 72.35 (0.5%))
[       OK ] OCL_HOGFixture_HOG.HOG (204664 ms)
[----------] 1 test from OCL_HOGFixture_HOG (204664 ms total)

Hmm this seems to happen with more inlined functions in .cl kernels, in features2d perf test i get:
[ RUN      ] OCL_Matcher/BruteForceMatcher.Match_Single/3
OpenCL program build log: -D T=float -D TN=float -D kercn=1 -D T_FLOAT -D DIST_TYPE=2 -D BLOCK_SIZE=16 -D MAX_DESC_LEN=128 -D AMD_DEVICE
unsupported call to function reduce_multi_block in BruteForceMatch_Match

Could you make check with addition before this line (define "inline" to nothing):
buildflags += " -D inline";

No that didn't work out, neither does:
buildflags += " -fno-inline";
but what did workout is:
buildflags += " -fkeep-inline-functions";


Handle disabled activities better

In systray, do not display disabled activities
In comboboxes, show enabled activities, then disabled ones.

Already implement, unsure when


App crash during keyboard is appearing after app active back from background

Produce the crash
During on the steps for FPX payment process and click on any textfield and the keyboard is appearing, then just put the app into background and click back to the app again the crash may happen. But this crash is only happen on real phone device, if i tried on Xcode 12 simulator and reproduce the step above the app is no crash but the keyboard is freeze.
Here the situation below i test using iPhone 12 Pro on simulator
https://user-images.githubusercontent.com/18119268/135122403-c212ba70-1337-4f67-bfe8-73bc6cd4d0f3.mov

Hi @tekjau @hisyamadzha @AfiqRazer sorry for disturb, may i ask if they're any solution for this.


Why do I need to populate a Group with Users to add a new user?

After about an hour of work, I am finally able to successfully add a new user and then add them to an existing group. However, I was perplexed by receiving an error about the Group not being populated:
My initial code:
with server.auth.sign_in(auth):
user = TSC.UserItem('stone_cold', 'Publisher')
new_user = server.users.add(user)
gs, pi = server.groups.get()
for g in gs:
if g.name == 'Ballers':
server.groups.add_user(g, new_user.id)
Working code:
with server.auth.sign_in(auth):
user = TSC.UserItem('stone_cold', 'Publisher')
new_user = server.users.add(user)
gs, pi = server.groups.get()
for g in gs:
if g.name == 'Ballers':
server.groups.populate_users(g)
server.groups.add_user(g, new_user.id)
Why do I need to use the populate_users() method on the Group just to add a user to it? As a second issue, why is populate_users() a Groups endpoint method and not a method of the GroupItem itself, where it could be called automatically prior to the attempt to add?

I'll have to investigate why we need the populate_users call (not familiar with this code)
but I can answer the part about why we do not do it automatically prior to attempting to add.
This is a conscious design choice.  We do not want to make calls that you do not specifically ask for.  Yes it means there is a little bit of extra code, but we feel like it's better to be specific about why we are making calls to the api.

Okay quickly looking over the code, this is a side-effect of trying to keep the user list accurate, so it made an assumption that the user list was already populated.  This is a bug.


Some data types are missing in data type list

System information:

OS : Windows 10 pro 18362.778
DBeaver version : 7.0.3

Connection specification:

Database is not published.

Describe your question:
Hi, dbeaver team.
I'm developing JDBC Driver for some database (which is privately published and under secure policy) to support dbeaver.
I connected to the database via general type driver.
When I check the database's data type list, everything was fine but 2 specific types were missing; NUMBER and NUMERIC.

As I understand, data type list using JDBC getTypeInfo() method to get the information, but my jdbc driver dump prints information of NUMBER and NUMERIC.

Why dbeaver data type list not shows NUMBER and NUMERIC?
Can I get any hints?

I found the code that ignoring NUMBER and NUMERIC data types in dbeaver code.

🥰 thnks.


feat: adds dependabot terraform support

What
feat: adds dependabot terraform support

:tada: This PR is included in version 0.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Question about Block Template Lookup Order

Hi! Newbie of Hugo here. I've come up with some questions, hope someone could help me. Here is my repo, please use it if you wanna reproduce the issue.
First downloaded Hugo (v0.18.1), applyed hugo_theme_robust, and added a post as the tutorial did.
Then I wanted to try if the Block Template worked or not, so I did these:

Duplicated /themes/hugo_theme_robust/_default/baseof.html, added something different from the original file (In my repo was
Hello baseof.html!!!
), renamed to post-baseof.html, and move to /themes/hugo_theme_robust/layouts/section/
Duplicated /themes/hugo_theme_robust/_default/list.html, added something different from the original file (In my repo was
Hello post.html!!!
), renamed to post.html, and move to /themes/hugo_theme_robust/layouts/section/

Now I wanna know if the Block Template Lookup Order worked or not. If it worked, when I visit http://base_url/post, the page should showed "Hello baseof.html!!!" and "Hello post.html!!!".
The docs page described the order. After some experiments, and it's the result (Checked means worked, unchecked means not):

[ ] /layouts/section/post-baseof.html (Moved post-baseof.html to this path)
[ ] /themes/exampletheme/layouts/section/post-baseof.html (Moved post-baseof.html to this path)
[ ] /layouts/section/baseof.html (Rename post-baseof.html to baseof.html)
[ ] /themes/exampletheme/layouts/section/baseof.html (Rename post-baseof.html to baseof.html)
[x] /layouts/_default/post-baseof.html (Moved post-baseof.html to this path)
[x] /themes/exampletheme/layouts/_default/post-baseof.html (Moved post-baseof.html to this path)

(Didn't try the last two because it will override the original baseof.html)
So, is it a bug, or I just misunderstood something?

Thanks for getting in touch, but it feels like this is a question  that would be better suited to the Hugo Discussion Forum.  We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.


non-target input sources should be dependencies

if A -> B where B is a target and A is not, then the drake line for B will currently look like:
B/dump <- B/step, B.py
but A.py should be a dependency.

This is already fixed in master and has been since at least 5d6c88b7.


Electron 9 EOL was 3 years ago

Electron version 9 reached EOL 3 years ago. Since this project uses it, doesn't it mean Nault is vulnerable to all kinds of security issues? Maybe it should be announced that this project needs a maintainer, it might help this project get the support it needs

Maybe you can reach the maintainer more easily since he's Finnish? 😇
https://github.com/Joohansson


React Group Project

A Link to the GitHub Project

In this react group Project we are a team of 2 ( @RichardChileya  and @MohamedCK  )

Hi Team👋,

Highlights💡

A link is specified.✔
The team member size is stated.✔
All required columns are present.✔
Cards are distributed fairly.✔

Good job so far coming so far with the progress you've made! 💪💪
However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

Kindly point the link to the kanban board, it currently points to the project README.

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Please, remember to tag me in your question so I can receive the notification.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @brytebee  thank's for pointing that out we updated :smile:

Project ready to start


Challenge 1 wagmi 2 backmerge

[ ] TODO: fix notification after update. Looks like we need to rewrite se-2 getParsedError function. But probably I'm wrong

fixed by locking viem version

Added last changes, updated useBalance to useWatchBalance, tested. Working fine.

Just did a final test and looking fine to me 🙌


refactor: rewrite vendor chunk to handle redirect exports

Description

fix #3731
I decided to not open a discussion, but this implementation should be more tested. I have no idea if it actually solved that kind of issue, but tested it solved that particular issue.
Before:

After:

And yes, performance is not great on large size projects, but I only have a medium size project, and here is the result:

Additional context

The real problem is the current implementation of vendor doesn't handle redirect exports, dependencies like framer-motion provided a combined export kinds of like this:
// index.js
export { foo } from "./foo.js"
export { bar } from "./bar.js"

and the import looks like:
// main.js
import { foo } from "./index.js"

In the current implementation of vendor, the file index.js is considered to be a vendor file, so every import to index.js is put inside vendor chunk.
But rollup handles this situation just fine, when vendor chunk is disabled, rollup splits dynamic import to bar seperately.
This implementation scans all redirect exports. Instead of marking index.js as a vendor file, this pr detects foo import from main.js and only marks foo.js as a vendor file, fixes the issue.
#6318 probably should be based on this implementation.
Side note: this implementation still allows setting manualChunks to undefined to disable vendor chunk.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann could you help me test this on that SvelteKit issue?

@benmccann could you help me test this on that SvelteKit issue?

I didn't test it, but to be very blunt, my first reaction is that this is insanity. Rollup has built-in code splitting, so why build some very complicated thing to replace it? At the very least there needs to be some explanation of what this is doing and what its benefits are. My initial reaction is that I would be much happier to just rip it all out and not deal with the added complexity and issues caused by this feature, but maybe I would feel differently given some explanation

added tests, but the tests are very barebone. I have no idea what edge cases to cover since I just ignored exports in traceImport in the last commit and it results in  305 -> 203 vendor files decrease with no change in vendor chunk. But it seems to be working for all projects I personally tested with no node_modules in source chunk and a decrease (or none for some) in vendor chunk.

My initial reaction is that I would be much happier to just rip it all out and not deal with the added complexity and issues caused by this feature, but maybe I would feel differently given some explanation.

Started a discussion about this, we should talk about it with more users to decide whether we implement it or just get rid of vendor chunk.


[AutoPR storage/resource-manager]  [SRP] Add Support for File Service and File Shares

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6892

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6382


Dependency joberrors

This pull request includes:
Reporting that there has been an issue with a dependency job does not provide enough information about the dependency
failure. It makes more sense to bubble up the original error since this will tell us the information we need. It also has the added benefit of ensuring consistency of the status codes for metrics.

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

I'm not sure if this approach is correct. Generally speaking, a job can have multiple dependencies and each of them can fail. With this approach, we would have to have an array of JobErrors which sounds complicated. Also, we already have a job (koji-finalize) that does some stuff (and thus can fail) even though its dependency failed - so we have to communicate its status back somehow.
Since the api servers are the ones who are responsible for queueing jobs in the correct order, I think they should be ultimately responsible for inspecting the whole job chain and cherry-picking errors from it.

I'm not sure if this approach is correct. Generally speaking, a job can have multiple dependencies and each of them can fail. With this approach, we would have to have an array of JobErrors which sounds complicated. Also, we already have a job (koji-finalize) that does some stuff (and thus can fail) even though its dependency failed - so we have to communicate its status back somehow.
Since the api servers are the ones who are responsible for queueing jobs in the correct order, I think they should be ultimately responsible for inspecting the whole job chain and cherry-picking errors from it.

Didn't consider the koji case in this. In that case is it fine to consider all dependency failure errors as 4xx in metrics? That way it'll only the dependency shows up (in case of 5xxs).

Okay, will have to re-think this a bit then, I also hadn't considered the koji side of things properly.

Didn't consider the koji case in this. In that case is it fine to consider all dependency failure errors as 4xx in metrics? That way it'll only the dependency shows up (in case of 5xxs).

I guess technically if a dependency failed, it's bad input for the next job (my two-cents)

@Gundersanne @ondrejbudai  I dropped the commit for propagating the dependency errors. I'll do that in a follow up.
For the meantime I changed the status codes for the metrics when we encounter a dependency error (assuming we're happy to go ahead with that change).


fix(column): :recycle: remove ErrorWhisker and Tooltip when error is null

It was requested to remove the Standard Errors from the column visualization (#589) so that the ErrorWhiskers component does not show for these columns.
While I was able to filter the chartDatum for any values where the getYError was null, I was also able to remove the getError from the getAnnotationinfo when null
Before

After

Nice! There is only one caveat: we can also have standard error whiskers for grouped column charts, I think the logic needs to be applied there too 😁
Nit: you can also add a relevant bullet point to the CHANGELOG, so at the end we have a nice list of all the changes made to the app ✨


fixed rendering bug

If there is no entity, the client will crash when rendering Big Axe and Thalleous sword. Implementation is minimal conditional check added to where entity is referenced in the renderers.

Thanks for contributing :)

Fixes https://github.com/Globox1997/MedievalWeapons/issues/69


Dockerfile builds: config variables not available at build time

When using a Dockerfile build all config variables set with dokku config:set are nether available at build time nor while the container is running. Is this intentional? If yes how would I work around that?

I don't think it was necessarily intentional. Dockerfile support is quite new however and definitely could use some more eyes on it. Feel like making a PR?

I would've already sent one if I had fixed it – I'm just getting started with Docker and dokku so I'm not yet as familiar with it as I would like to be. I played around with it a bit yesterday though and tried copying
the build-env pre-build hook to a plugin as the pre-build-dockerfile hook and it didn't work, I figured it's because docker build overwrites previous docker commits to an image. If you could point me in the right direction I'd gladly submit a PR.

Oh actually I did this....this is supposed to work
https://github.com/progrium/dokku/blob/48eca101f119392809411e17c7c8838b4c6c071a/plugins/config/docker-args-deploy#L8-L13

Interesting. I tried using some of the config vars in a node script (via process.env) and it didn't work. After that I tried RUN env directly and it didn't print them either. Could it be possible that they are only available in the finished container but not while building the image?

I guess it makes sense that they're not available in the build because the aren't sourced anywhere and I'm using FROM node:0.12.

There's definitely no way they would be available during the build phase as there is no docker-args-build pluginhook in the config plugin. That can be added easily. However, I'm not clear why its not working for you.

I guess I should rephrase my original claim then, they aren't available at build time (that's where I need them), I actually haven't tested the running container. Sorry, should've checked that first.

Ah ok! Now I remember why. This was done to maintain functional parity with buildstep based apps. I'm definitely open to a discussion around including them in dockerfile builds. Anybody have thoughts on this?

Sidenote: I verified this do get included in the running container and when you use dokku run app cmd. (There's a test for this as well :smile:)

@michaelshobbs docker made this not possible on purpose to have consistent images. The whole concept of passing an env variable to the build process is against the purpose of building the image itself, which needs to be consistent. Everything that needs customization needs to be run as CMD or have a buildimage docekrfile.
I stumbled with this myself months ago, where I was trying to pass NODE_ENV=dev/stag/prod to a statically built website at build time.
I ended up having 3 dockerfiles one per env. You can specify the dockerfile to use in dokku using the build phase container options if I am not wrong.
for ref: https://github.com/docker/docker/issues/6822

I see but how would I then go about implementing the "real" build the application needs? Like precompiling assets and uploading them to S3? I suppose I could write a plugin and use docker run and then docker commit after the image was built.

That depends on what you need to do, you need to have a static website where the build is ENV dependent? I suggest you create multiple dockerfile with different ENV directive in it. Not really DRY but it's the best I got so far.

Also you can have a builder image.

No, it's not really dependent on any ENV vars. It just need my AWS credentials (which are saved as config vars on the dokku app) when I run the S3 script. And also the git rev-parse HEAD for a different script. Anyway, I'll try the workaround I suggested above and see if that works for me now.

I wanted to follow-up on this: I solved my problem by using a plugin which commits a modified version of the image in a post-build-dockerfile - it's not optimal but it works. I guess what I'm saying is that it would be nice if dokku could make this easier. (modifying the image post build and commiting it)

-1 on having dokku doing it. It's a Docker design issue that they are trying to fix. For the time being this is best in userland. You should publish a post build commit plugin to help others.

You could have the static assets be built during buildtime, but uploaded to S3 during execution time. You need to modify the CMD command in your Dockerfile. During execution time, environment variables are available. I feel like this is a cleaner option as docker would be able to build your image wherever you want.

@mixxorz Wouldn't that approach upload them every time the container is restarted? I agree that it would be the cleaner solution.

You're right, I didn't think of that. Maybe you could set an environment variable with docker run -e that your upload script looks at?

Closing this as the OP has a solution and there's been no movement on further discussion.


[oneDNN] fuse gelu subgraph with MatMul and Biasadd

This PR fuses gelu subgraph with MatMul and BiasAdd. This pattern is found in official bert base, bert large etc models. And gives significant performance improvement. This fusion is also enabled for bfloat16.

Original sub-graph

After fusion

Hi @ezhulenev Can you please review this PR ? Thank you!

@elfringham : do you know why ARM CI failed for this PR also?

@penpornk : thanks for the review and the recommendations. I did the review rework for all except 1 change for Cast in the test. Also resolved the merge conflict.

Adding @ezhulenev back to the review, not sure how he was removed


revised certificate handling

no new root cert/key pair is created if files exist
node cert/key creation is skipped if cert/key pair exists (behaviour per node).

Right now first it gets checked that there is a CA Cert present if not we create it, otherwise all good, anyways continue.
Then we check if node certs are already present (on a per node basis). If a nodes cert is not there we use the CA from step 1 to generate them. If it exists just use it.
I can imagine someone wants to only provide externally managed certs, so we would need to be able to disable the CA generation.
Whats your opinion here?
Other question:
If there is a CA cert present do we want to validate that the node certs are issued by the CA cert? Oder do we not care; there is a file available, go and use it.

Thanks @steiler
will check your PR tomorrow CET time
As to the user provided certificates I was thinking maybe to make use of node Labels for that. Something like that:
nodes:
  node1:
    labels:
      node_cert_path: a/b/cert.pem
      node_priv_key_path: a/b/key

@karimra do you have a view on that?

why is it a label, why not a field under the node ?

I am struggling between bloating the node structure with many fields and making a right choice with this particular one
Maybe key/cert are generic enough to be promoted to all nodes structures as a field. whereas labels can be seen as a generic way to provide metadata to nodes

I don't see why this needs to become a label or anything specifically defined, to be honest.
We are creating the folder structures anyhow and when creating certs they will be stored in that folder structure.
So whats the benefit of having the freedom to drop them $somewhere?

valid claim
maybe a first start could be indeed with asking users to provide certs by the path in the lab directory

That's exactly how it is implemented right now.
If certs exist use them, if not generate them. This is the case for CA as well as Node certs.
Haven't checked if the actual implementation does follow symlinks. But if it should be possible to store the certs somewhere else symlinking them in the scenario specific lab directory would be my advice.

@steiler I have made a few changes in the last 3 commits, specifically I moved the logic of checking if rootCA is needed into the clab package, out from cmd package

I think eventually we would need a flag in the topo file that will tell containerlab to generate node certificate/key for non-srl nodes.
The need is basically to create TLS files for other nodes which do not require them per se, but may use them for use cases which can leverage TLS certificates. I.e. we might want to have certs for ceos/vmx/xr nodes as we can import them via CLI/other_means and demonstrate/test how it works.
the question becomes to choose a right flag for a node config to signal that we want containerlab to generate certificates. I think this must be done outside of this PR

another comment for history: it might still be desirable to make cert location configurable.
The reason is to make user-provided certs less challenging to configure. With the current approach if a user wants to make containerlab use custom certificates the user needs:

to know where containerlab will create lab directory with TLS files
create directories knowing all node names
copy files there

My biggest problem with step No2. If you change any node name you need to change the directory structure and that is irritating.
If we expose certificates location via topo file, the code will put those files over to the necessary directories on users' behalf.
Something that we can add later if there is a pressing need for that.


TxInfo for PlutusV3

Describe the feature you'd like
Here is the spec for all of the Conway related changes in the Ledger that affect TxInfo:

newtype ColdCommitteeHash = ColdCommitteeHash Credential
  deriving (Show, Eq)

newtype HotCommitteeHash = HotCommitteeHash Credential
  deriving (Show, Eq)

newtype DRepHash = DRepHash Credential
  deriving (Show, Eq)

data DRep
  = DRepCredential DRepHash
  | DRepAlwaysAbstain
  | DRepAlwaysNoConfidence
  deriving (Show, Eq)

data Delegatee
  = DelegStake PubKeyHash
  | DelegVote DRep
  | DelegStakeVote PubKeyHash DRep
  deriving (Show, Eq)

-- | There is probably no need for Plutus Scripts to even know about all this data in Anchors,
-- but it is here for completeness. So we might wanna omit them, especially since urls are a
-- bit tricky, since we can't guarantee their validity, not even that they are utf8-encoded.
data Anchor = Anchor
  { anchorUrl :: String -- Arbitrary Url
  , anchorDataHash :: Hash -- Blake2b_256 of some off-chain data
  }
  deriving (Eq, Show)

-- | Note taht it no longer is caled DCert, since certificates are no longer all about
-- delegation, they are also about governance.
--
-- Notable changes:
--
-- * Pool certificates are unchanged
-- * Addition of deposits and refunds. Those values are validated according to respectful
--   PParams. Certificates that where present before get their deposit/refund as
--   optional. This is done for graceful tarnsition, since next era after Conway will require
--   deposit/refund amount
-- * New DRep entity
-- * New Constitutional Committee entity
data TxCert
  = -- | Register staking credential with an optional deposit amount
    TxCertRegStaking StakingHash (Maybe Value)
  | -- | Un-Register staking credential with an optional refund amount
    TxCertUnRegStaking StakingHash (Maybe Value)
  | -- | Delegate staking credential to a Delegatee
    TxCertDelegStaking StakingHash Delegatee
  | -- | Register and delegate staking credential to a Delegatee in one certificate. Noter that
    -- deposit is mandatory.
    TxCertRegDeleg StakingHash Delegatee Value
    -- | Register a DRep with mandatory deposit value and an optional Anchor
  | TxCertRegDRep DRepHash Value (Maybe Anchor)
    -- | Update DRep's optional Anchor
  | TxCertUpdateDRep DRepHash (Maybe Anchor)
    -- | UnRegister a DRep with mandatory refund value
  | TxCertUnRegDRep DRepHash Value
    -- | Authorize a Hot credential for a specific Committee member's cold credential
  | TxCertAuthHotCommittee ColdCommitteeHash HotCommitteeHash
  | TxCertResignColdCommittee ColdCommitteeHash
  deriving (Eq, Show)

data Voter
  = CommitteeVoter !HotCommitteeHash
  | DRepVoter DRepHash
  | StakePoolVoter PubKeyHash
  deriving (Eq, Show)

data Vote
  = VoteNo
  | VoteYes
  | Abstain
  deriving (Eq, Show)

-- | Similar to TxOutRef, but for GovActions
data GovernanceActionId = GovernanceActionId
  { gaidTxId :: TxId
  , gaidGovActionIx :: Integer
  }
  deriving (Eq, Show)

data VotingProcedure = VotingProcedure
  { vpVote :: Vote
  , vpAnchor :: Maybe Anchor
  }
  deriving (Eq, Show)

data Committee = Committee
  { committeeMembers :: Map ColdCommitteeHash Integer
  -- ^ Committee members with epoch number when each of them expires
  , committeeQuorum :: Rational
  -- ^ Quorum of the committee that is necessary for a successful vote
  }
  deriving (Eq, Show)

data Constitution = Constitution
  { constitutionHash :: Hash -- Balke2b_256 of some off-chain data
  , constitutionScript :: Maybe ScriptHash
  }
  deriving (Eq, Show)

data GovernanceAction
  = -- | Proposed updates to PParams. This is a very tricky one, since PParamsUpdate is pretty
    -- big and changes from one era to another. However, it could be very important for the
    -- governance scripts to be able to see the values in the PParamsUpdate, but I am not
    -- sure how to go forward about this, so for now I leave it as empty.
    ParameterChange -- Should contain: (PParamsUpdate era)
    --
  | -- | proposal to update protocol version
    HardForkInitiation ProtocolVersion
  | TreasuryWithdrawals !(Map Credential Value)
  | NoConfidence
  | NewCommittee
      [ColdCommitteeHash]
      -- ^ Old committee
      Committee
      -- ^ New Committee
  | NewConstitution Constitution
  | InfoAction
  deriving (Eq, Show)

data ProposalProcedure = ProposalProcedure
  { ppDeposit :: Value
  , ppReturnAddr :: PubKeyHash
  , ppGovernanceAction :: GovernanceAction
  , ppAnchor :: Anchor
  }
  deriving (Eq, Show)

data ScriptPurpose
  = Minting CurrencySymbol
  | Spending TxOutRef
  | Rewarding StakingCredential
  | Certifying TxCert
  | Voting Voter GovernanceActionId
  | Proposing -- For now this will only be used by Constitution, thus might turned out to be
              -- unused.
  deriving (Show, Eq)

-- | TxInfo for PlutusV3
data TxInfo = TxInfo
  { txInfoInputs :: [TxInInfo]
  -- ^ Unchanged
  , txInfoReferenceInputs :: [TxInInfo]
  -- ^ Unchanged
  , txInfoOutputs :: [TxOut]
  -- ^ Unchanged
  , txInfoFee :: Value
  -- ^ Unchanged
  , txInfoMint :: Value
  -- ^ Semantics changed:
  -- In Conway for PlutusV3 translation is different from previous Plutus versions, since we no
  -- longer add a zero ADA value to the mint field during translation.
  -- Fixes: https://github.com/input-output-hk/plutus/issues/5039
  , txInfoTxCert :: [TxCert]
  -- ^ Certificate type has changed
  , txInfoWdrl :: Map StakingCredential Integer
  -- ^ Unchanged
  , txInfoValidRange :: POSIXTimeRange
  -- ^ Unchanged
  , txInfoSignatories :: [PubKeyHash]
  -- ^ Unchanged
  , txInfoRedeemers :: Map ScriptPurpose Redeemer
  -- ^ Semantics changed
  --
  -- ScriptPurpose is now different in Conway
  , txInfoData :: Map DatumHash Datum
  -- ^ Unchanged
  , txInfoId :: TxId
  -- ^ Unchanged

  , -- New in Conway ===========================================================
    txInfoVotingProcedures :: Map Voter (Map GovernanceActionId VotingProcedure)
  -- ^ This is Map with all of the votes that were included in the transaction
  , txInfoProposalProcedures :: [ProposalProcedure]
  -- ^ This is a list with Proposals that will be turned into GovernanceActions, that everyone
  -- can vote on
  , txInfoCurrentTreasuryAmount :: Maybe Value
  -- ^ Optional amount for the current treasury. If included it will be checked to be equal
  -- the current amount in the treasury.
  , txInfoTreasuryDonation :: Maybe Value
  -- ^ Optional amount for donating to the current treasury. If included, specified amount
  -- will go into the treasury.
  }
  deriving (Show, Eq)

Describe alternatives you've considered
No response

@zliu41, here is the promised TxInfo for PlutusV3. There is a small chance we'll need to make some minor changes to this over the next few months, but I hope we actually got it right.
@WhatisRT, could you please double check that it seems right, whenever you get a chance.

Thanks! We'll start working on it soon.

I found two things: ppReturnAddr should be a Credential (since a reward address can be locked by scripts), and the Proposing constructor of ScriptPurpose should probably include a GovernanceAction since we want to run the script once for each proposal.

Is the spec update nearly done also? That's also super helpful as a reference.

@zliu41 In the issue I said "Pool certificates are unchanged", but totally forgot to include them in the actual type, so here are the two missing constructors for PlutusV3 context:
data TxCert
  = -- | A digest of the PoolParams
    TxCertPoolRegister
      PubKeyHash
      -- ^ poolId
      PubKeyHash
      -- ^ pool VFR
  | -- | The retirement certificate and the Epoch in which the retirement will take place
    TxCertPoolRetire PubKeyHash Integer -- NB: Should be Word64 but we only have Integer on-chain


Add a warning/confirmation to wallet creation

Maybe we should add something similar to Elrond:

This has been added in the form of an information page at the end of wallet creation:


[Gekidou MM-39733] Port Create Channel from V1

Summary
Follow up on https://github.com/mattermost/mattermost-mobile/pull/5867
Ticket Link
https://mattermost.atlassian.net/browse/MM-39733
Screenshots

Release Note
None

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/21122
https://circleci.com/gh/mattermost/mattermost-mobile/21121

Artifact links:
https://21122-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://21121-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

@matthewbirtch I was mainly focusing on getting the PR back to shape "technically", but all your changes seem reasonable. Will make sure they enter in this PR.

@matthewbirtch Beeing looking at this, and I have almost ready most of your requested changes. The only thing that may be better for a different PR is the ones changing the style of the header.
The header is not controlled by the components, but it is more general (the same for all components). Let me know if you see anything different between this and other headers (I should be able to fix that) but changes in general would be something to deal in a different PR.

The header is not controlled by the components, but it is more general (the same for all components). Let me know if you see anything different between this and other headers (I should be able to fix that) but changes in general would be something to deal in a different PR.

Yep, understood. I think @enahum already updated the header component in the 'Edit post modal' PR, so that's why I was surprised to see that it was not right in this PR.

@enahum Regarding changes to Floating Text breaking other places, I discovered some issues in the original PR in the add server screen that are already addressed. Would be nice to do further testing, but just wanted to let you know that I already looked there.

@larkox conflicts after merging #5984

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/21195
https://circleci.com/gh/mattermost/mattermost-mobile/21194

Artifact links:
https://21195-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://21194-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk

@avinashlng1080 Just to make sure, the autocomplete should only show on the Header. Name and purpose should not show the autocomplete. Is the autocomplete not showing for you in the header field?

@avinashlng1080 Just to make sure, the autocomplete should only show on the Header. Name and purpose should not show the autocomplete. Is the autocomplete not showing for you in the header field?

Yes I'm testing the 'header' field.

Conflicts

@avinashlng1080 I don't see any obvious reason why it won't work on iPhone. It is working fine on Android emulator. I still cannot develop on iOS, so it would be great if you could take a look.


Homozygous variant called as heterozygous

Dear Jared,
For one variant Nanopolish is calling a Hom position as het. Below the INFO
155205331 | . | T | C | 1794 | PASS | BaseCalledReadsWithVariant=188;BaseCalledFraction=0.817391;TotalReads=222;AlleleCount=1;SupportFraction=0.900699 | GT | 0/1
Any idea of why this might be happening?
Thank you!

Just to add some details to this issue, this is not related to strands filtering, as Nanopolish behaves the same way on the original bam file (before splitting in strands).

I found a closed issue (#423 ) that was reporting a similar problem, but it hasn't been resolved as far as I can see. In my run, I have other variants with lower SupportFraction that are called as homozygotes, so I don't get why this one is called as heterozygote.

I'd like to add another finding:
take the variant below:
155208183 | . | T | C | 30230.1 | PASS | BaseCalledReadsWithVariant=3422;BaseCalledFraction=0.651313;TotalReads=5059;AlleleCount=2;SupportFraction=0.613717 | GT | 1/1
I think in this case the support fraction is a bit misleading: the bam file on that position has 1267 deletions, so the total number of reads is actually around 3900, rather than 5059 (which is the total number of reads, including the deletions).
However, when calculating the support fraction, Nanopolish uses 5059, so the support fraction is 0.61. Although this is not a bug, I feel that the it might be misleading somehow.

Hi @marcotoffoli,
Sorry for the slow response. The genotypes are set based on the likelihoods that nanopolish's HMM calculates, rather than SupportFraction. This can lead to (hopefully rare) cases where the genotype and SupportFractions seem inconsistent, as you show here. In the first case, there is probably a small population of reads that (erroneously) strongly support the reference allele which pushes the best genotype to be 0/1.
Can I see an IGV screenshot of the second case? Is the deletion real, or an alignment artifact? Nanopolish doesn't take the alignment into consideration, so the fact that some reads show a deletion doesn't matter, it re-scores all reads against the candidate sequences with its HMM.

Dear Jared,
Thank you for your reply!
Regarding the first example (supposedly hom variant called as het), I found this happening on 4 intronic variants on 4 samples (in total 16 times) in a batch of 37 samples. I'm fairly sure these are hom as they are part of a common haplotype and the other variants of the haplotype are hom. Moreover, another variant caller confirms they are hom.
Is there anything I can do to prevent this from happening? I was thinking of using a script to change to hom all het variants for which support fraction is above 0.75, do you think this would make sense?
Regarding the second example (hom variant called correctly, but with low support fraction), I think the deletions are an artifact, as the alt allele creates a polyG sequence and all samples show a high number of deletions in this same position. This is less of a problem, as I believe Nanopolish is calling the variant correctly.
Below screenshot of the variant.

Thank you!


Support for creation of snapshots - Part 1

The idea is to support creation of snapshots by creating a VolumeSnapshot CR and creation of PVC/PV using the snapshot as the source.
This is a part of a set of PRs to achieve the same.
Changes

CreateSnapshot support for storage_drivers.
CreateVolumeSnapshot backend handler.
CreateVolumeSnapshot orchestrator handler.
Unit test to test CreateVolumeSnapshot on a fake driver.
Add/Get snapshot state from the persistent store and corresponding unit tests.

Testing

CreateSnapshot using a fake driver

=== RUN   TestSnapshotVolumes
time="2019-03-07T16:20:42-08:00" level=warning msg="Trident is bootstrapping with no frontend."
time="2019-03-07T16:20:42-08:00" level=warning msg="Couldn't retrieve volume transaction logs: Unable to find key"
time="2019-03-07T16:20:42-08:00" level=info msg="Trident bootstrapped successfully."
time="2019-03-07T16:20:42-08:00" level=info msg="Storage driver initialized." driver=fake
time="2019-03-07T16:20:42-08:00" level=info msg="Created new storage backend." backend="&{0xc0001cd600 fast-a true online map[fast-small:0xc000164b80 fast-thin-only:0xc000164bc0] map[]}"
time="2019-03-07T16:20:42-08:00" level=info msg="Newly added backend satisfies no storage classes." backend=fast-a
time="2019-03-07T16:20:42-08:00" level=info msg="Storage driver initialized." driver=fake
time="2019-03-07T16:20:42-08:00" level=info msg="Created new storage backend." backend="&{0xc0002e8420 fast-b true online map[fast-thin-only:0xc0002e4e00 fast-unique-attr:0xc0002e4e40] map[]}"
time="2019-03-07T16:20:42-08:00" level=info msg="Newly added backend satisfies no storage classes." backend=fast-b
time="2019-03-07T16:20:42-08:00" level=info msg="Storage driver initialized." driver=fake
time="2019-03-07T16:20:42-08:00" level=info msg="Created new storage backend." backend="&{0xc0002e91e0 slow-file true online map[slow-snapshots:0xc0003149c0 slow-no-snapshots:0xc000314980] map[]}"
time="2019-03-07T16:20:42-08:00" level=info msg="Newly added backend satisfies no storage classes." backend=slow-file
time="2019-03-07T16:20:42-08:00" level=info msg="Storage driver initialized." driver=fake
time="2019-03-07T16:20:42-08:00" level=info msg="Created new storage backend." backend="&{0xc0002e9ef0 slow-block true online map[medium-overlap:0xc00034e5c0 slow-no-snapshots:0xc00034e600 slow-snapshots:0xc00034e640] map[]}"
time="2019-03-07T16:20:42-08:00" level=info msg="Newly added backend satisfies no storage classes." backend=slow-block
time="2019-03-07T16:20:42-08:00" level=info msg="Storage class satisfied by 2 storage pools." storageClass=slow
time="2019-03-07T16:20:42-08:00" level=info msg="Storage class satisfied by 4 storage pools." storageClass=fast
time="2019-03-07T16:20:42-08:00" level=info msg="Created fake snapshot." backend=fast-b physicalPool=fast-unique-attr requestedPool=fast-unique-attr snapshotName="file_snapshot2019-03-08T00:20:42Z" sourceVolume=trident-file
time="2019-03-07T16:20:42-08:00" level=info msg="Created fake snapshot." backend=slow-block physicalPool=slow-snapshots requestedPool=slow-snapshots snapshotName="block_snapshot2019-03-08T00:20:42Z" sourceVolume=trident-block
--- PASS: TestSnapshotVolumes (0.01s)
PASS
ok  	github.com/netapp/trident/core	0.023s

Unit tests for persistent store operations

=== RUN   TestEtcdv2Snapshot
--- PASS: TestEtcdv2Snapshot (0.01s)

=== RUN   TestEtcdv3Snapshot
--- PASS: TestEtcdv3Snapshot (0.01s)

Hi, @pavannd1.  I'm reading through this PR, and it looks pretty good so far.  Were you planning to add any more commits here?  I don't see any snapshot deletion code; is that coming separately?

@clintonk Thanks. Yes, I was planning to do that as a follow up.

Updated this to use snapshot.ID as the key to store the state in the persistent store. This is in line with the approach taken on the K8s side in the other PR.


Update OWNERS

Adding reviewers who have spent time and contributed significantly to the repository as reviewers. I'd like to promote them to approvers as they come to understand the code base more deeply, but this gives agency to work with individual PRs.

Retroactive lgtm


readOnly: true property not hidden in REQUEST SAMPLES for nested objects

It's great that the readOnly: true property allows you to use the same definitions for read (GET) and write (POST, PATCH, PUT) operations. However, the readOnly: true property is being ignored when generating REQUEST SAMPLES that include nested objects (e.g., the names array):

The REQUEST BODY, however, is correctly rendered:

See: https://ato-team.github.io/business-registries-rest-api-specification

@Robinyo thanks for issue report!
I will check it asap and will get back to you!


config: remove need for pre-existing .invenio.private per team member

closes #130
To summarize: as part of a team I want to clone the instance repository and run invenio-cli install ... without having to artificially create a .invenio.private with a path to a virtualenv that I also need to create. This had to be done before because these steps were done by invenio-cli init which isn't run because my teammate already ran it (I am cloning the result of that command afterall). This is also handy even without teammates, if one is cloning the repo on a different computer.
This PR addresses that by relying on the in-memory project directory directly (no need to look-up the .invenio.private file) and the fact that invenio-cli install sets the instance location. Even though we technically still rely on .invenio.private for it, it should really be thought as a cache that is primed before use by invenio-cli install.

not ready yet

ready for review


Add name as intern

Hello,
I added my name to the team as intern. The change is in pages/team.
I hope everything is correct.

@DanielaIgRo , please rebase your branch on top of the upstream main.
ping me if you need any help

Yes please, could you help me tomorroy morning?
Maybe at 9:30?

@DanielaIgRo , sure thing. please send me an invitation to my google calendar please.

Thanks, I've already sent you the invitation


Fixes OpenSSL for qt5

This provides two things:

Remove the hardcoded 1_1 in the dll copy, and change it to * so that the v3 dlls are copied for the qtdeploy script.
Add the link-openssl feature flag to qt5-base so that it can me manually forced in cases that you wish to link to it even when not static.  This was suggested in the meta-qt5 layer of the yocto project#437

What does your PR fix?
Fixes  #25212

Which triplets are supported/not supported? Have you updated the [CI baseline]
No change

Does your PR follow the maintainer guide?
I think so.  Not sure if Do not use features to control alternatives in published interfaces applies here.  While not exposed in the consumer API, it does cause the linkage to openssl to be more concrete vs a lazy dlopen at runtime.

Yes

cc @Neumann-A for review this.

@JackBoosY I really don't care about the vcpkg qt deploy script. The question here thus is if windeployqt correctly deploys openssl. Maybe cc @Osyotr instead.

@Neumann-A My impression from the yocto project is that it doesn't work properly.  That being said they work specifically in embedded cross compile environments, so that might be  a different beast.   To be honest though, I don't see Qt5 getting much love as really it needs to be replaced by Qt6 at this point.  So the less that these packages need to be touched the better the use of time.  The only reason I am using it is that this product is on security updates only phase.

Since there's no distinct feature for openssl in Qt5, I think setting QT_OPENSSL_LINK unconditionally is the right thing to do.
Qt5 only looks for OpenSSL 1.1 if configured without it.
Related code: https://github.com/qt/qtbase/blob/v5.15.4-lts-lgpl/src/network/ssl/qsslsocket_openssl_symbols.cpp#L670

@Osyotr I will update the PR to have it always link then.

@Neumann-A Do you agree the changes?

Ping @Neumann-A

@JackBoosY since it does exactly what I said in https://github.com/microsoft/vcpkg/pull/25242#discussion_r897679390 I don't get why you are even asking? ;)
So you probably should ask the author of https://github.com/microsoft/vcpkg/commit/9a01ec282e7e1ebe8d901cd08d245e72e2d9a274 (couldn't find the PR for it; maybe there is discussion there. )

In 9a01ec2 they force it only for static builds only since you can't dlopen in that case.  In my PR's case, I just force it always to link.

@JackBoosY is this proper now?


Exclude directory argument in --no-git mode

Is your feature request related to a problem? Please describe.
slscan now use gitleaks in --no-git mode by default. This is currently parsing all the directories including .venv, node_modules etc that can be safely ignored.
Describe the solution you'd like
By supporting an argument such as --exclude-dir, --exclude-regex tools such as slscan can ignore known directories to speed up the analysis
Describe alternatives you've considered
Iterating the directories and invoking gitleaks multiple times is not elegant.
Additional context
Add any other context or screenshots about the feature request here.
cc @zricethezav

@prabhu There is the ability to exclude regexes and directories using the config toml file. I like the separation of scanning options and rule configuration. This encourages folks to write their own gitleaks configuration files and not rely on the default config.

@zricethezav Thank you. Will explore the config file further. However, would it offer performance benefits by completely ignoring those directories or only used for suppressing findings? node_modules, venv are large in modern apps so an option to entirely ignore them is preferable. I have users reporting that gitleaks is currently taking over 2.5 hours for certain apps which is not ideal.

However, would it offer performance benefits by completely ignoring those directories or only used for suppressing findings?

@prabhu the former. Gitleaks prevents scanning and files/paths founds in the global allowlist.

I have users reporting that gitleaks is currently taking over 2.5 hours for certain apps which is not ideal.

If those repos are public I'd be happy to take a look 😄

I'm seeing something similar. I've tried various different regexes to exclude all node_modules directory and the .git directories but I can't get anything to work. Do you have any suggestions of what regex to use here?
MacOS 11.4
gitleaks 7.5.0
$ gitleaks -v --config-path=gitleaks.toml --no-git --path=./
ERRO[0000] open node_modules/.cache/babel-loader/6d8063beb61e7aeac6d81316036a7468.json: too many open files
INFO[0000] scan time: 59 milliseconds 48 microseconds
ERRO[0000] open node_modules/.cache/babel-loader/6d8063beb61e7aeac6d81316036a7468.json: too many open files

gitleaks.toml
title = "gitleaks config"

[[rules]]
description = "JSON Web Token"
regex = '''eyJ[A-Za-z0-9-_=]+\.[A-Za-z0-9-_=]+\.?[A-Za-z0-9-_.+/=]*?'''
tags = ["key", "jwt"]

[allowlist]
description = "Allowlisted files"
files = [
  '''.*node_modules.*''',
  '''\.git''',
]


New Video Tagging Tool | New Tool

yolo_mark is indeed a good tool to tag images but its quite laborious.
If can simply use an object tracking algorithm on top of a video and drag an object and play/pause the video we would be easily able to create dataset. on a large scale faster.

I added o button that tracks all objects from current image to next image by using Optical Flow.
Do you mean this or something else?
Do you want more stable tracking algorithm (like cv::TrackerCSRT() (CSRDCF++) - OpenCV-contirb)?
Or do you want Kalman-filter algorithm for tracking occluded objects?

Well image based tagging takes a lot of time as you have see each image.
I have 3 people sitting and tagging for a week. Big waste if you ask me.
User can draw the box after pausing the video. This way i just have to make and video and tag and write the frames. So i think this approach requires a new tool.
https://www.youtube.com/watch?v=BiLNKkfW88s
CSRT.

 Just try.

Yes, I will add CSRT.

@AlexeyAB
Please see this video
https://www.youtube.com/watch?v=vbydG78Al8s

@dexception It looks very useful. Do you have a link to this tool?

I just saw the tool by accident as i was looking for a substitute.

The link to the tool (from the video description on yt): https://darkpgmr.tistory.com/16


Federate the api/v1/status/tsdb endpoint from Prometheus

Is your proposal related to a problem?
It would be great if Thanos Query could federate the api/v1/status/tsdb endpoint from Prometheus instances. This will allow users to analyze cardinality on the fly.
Describe the solution you'd like
Thanos Query could fanout to Prometheus sidecars and return a federated result from all endpoints.
Describe alternatives you've considered
We currently run https://github.com/thought-machine/prometheus-cardinality-exporter, but this requires ingesting metrics which further increases cardinality :)

Yes, I would see that as a potential gRPC API for our endpoints that Querier could merge.

We currently run https://github.com/thought-machine/prometheus-cardinality-exporter, but this requires ingesting metrics which further increases cardinality :)

Not if you use separate meta-monitoring which is a best practice (:
I think the main questions is to nail down exact API - what we want to people use it for and if a nice metric exposed by the receiver to meta-monitoring cannot fulfil the same purpose.
Why not

Metrics exposed by receiver could hold the same information?
Is this data for admin / operator of Thanos or for Thanos user?

@fpetkovski Any next step for this issue?

Unfortunately I don't have capacity to work on this right now, I am primarily focused on the new engine. If no one has stepped up to tackle this, maybe we can close it for now?


Not working with PDM 2.5.0b0

pdm init -v with pdm-vscode installed:
% pdm init -v
Creating a pyproject.toml for PDM...
Please enter the Python interpreter to use
0. /usr/local/bin/python3.10 (3.10)
1. /usr/local/bin/python3.9 (3.9)
2. /usr/bin/python3 (3.9)
3. /usr/local/bin/python3.8 (3.8)
4<EMAIL_ADDRESS>(3.11)
Please select (0): 4
Using Python interpreter<EMAIL_ADDRESS>(3.11)
Using __pypackages__ because non-venv Python is used.
Traceback (most recent call last):
  File "/usr/local/bin/pdm", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/core.py", line 253, in main
    return Core().main(args)
           ^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/core.py", line 191, in main
    raise cast(Exception, err).with_traceback(traceback) from None
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/core.py", line 186, in main
    command.handle(project, options)
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/cli/commands/init.py", line 55, in handle
    python = actions.do_use(
             ^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/cli/actions.py", line 659, in do_use
    hooks.try_emit("post_use", python=selected_python)
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm/cli/hooks.py", line 54, in try_emit
    pdm_signals.signal(name).send(self.project, hooks=self, **kwargs)
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/blinker/base.py", line 263, in send
    return [(receiver, receiver(sender, **kwargs))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/blinker/base.py", line 263, in <listcomp>
    return [(receiver, receiver(sender, **kwargs))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/pdm/2.4.9/libexec/lib/python3.11/site-packages/pdm_vscode/hook.py", line 51, in generate_vscode_settings
    if env.is_global:
       ^^^^^^^^^^^^^
AttributeError: 'PythonLocalEnvironment' object has no attribute 'is_global'. Did you mean: 'is_local'?

Thanks, this will be resolved in the PDM project.


Permission fixes

Please, test this first.

Coverage decreased (-0.9%) to 68.683% when pulling 9dac1e89e020173f58a20f78f586d8ff65768d9d on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage remained the same at 69.543% when pulling 9ac46e2e01230989c28e21c1247a7af18423300f on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage increased (+0.02%) to 69.564% when pulling 3a1168712a7bac7572c6fc6a989e41920f96744d on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage decreased (-3.0%) to 66.571% when pulling fdd2b1d98506a028fc4d418a60c1df71df392697 on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage increased (+0.03%) to 69.575% when pulling 08e01ff4f8138102141ea0e98083753aa8eb216e on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage increased (+0.03%) to 69.575% when pulling a95ee6fe08c71c660a1db06e1f773dfd723be5f2 on permission-fixes into d6ff1a207e499b87affdfac4d93f5dc5c2b9ac23 on master.

Coverage increased (+0.02%) to 69.566% when pulling 6f2cc37c768e9a1c83fa1b445e5ffe83620814b2 on permission-fixes into 6a026f876459ddbd0d323a89dbbf7289b8fc0387 on master.

Coverage increased (+0.02%) to 69.566% when pulling 6f2cc37c768e9a1c83fa1b445e5ffe83620814b2 on permission-fixes into 6a026f876459ddbd0d323a89dbbf7289b8fc0387 on master.

Coverage decreased (-0.07%) to 69.473% when pulling db9e8ff591539943748c7940cbda31fd43cd8ff4 on permission-fixes into 6a026f876459ddbd0d323a89dbbf7289b8fc0387 on master.

Coverage decreased (-0.1%) to 69.436% when pulling 5e7eee6faa252f60014314c7594e0ff67c50b07f on permission-fixes into 6a026f876459ddbd0d323a89dbbf7289b8fc0387 on master.

Coverage decreased (-0.1%) to 69.436% when pulling 760c7772a093f9b6f051a102be1666b63fd7cb50 on permission-fixes into 6a026f876459ddbd0d323a89dbbf7289b8fc0387 on master.


Typed percentage is gone when using NTI?

@dimvar My build scripts stopped reporting typed percentage after 52194cf080a8363b250b8f6c0fcb88c11e639122. Is it intended?

I don't know if I'd consider that a very important feature but it is potentially good information to have. How do you use it (for instance, do you have a goal of keeping it above 90%)?

My goal is keeping it as high as possible. My largest project (currently 50 000+ lines) is having 99.97% typed. I've found the percentage very useful in some scenarios where Closure Compiler didn't emit any warning but I could see the percentage drop. From what I remember:
Undefined property
Very common for me. This usually means that I have misspelled property name.
/**
 * @record
 * @struct
 */
function MyRecord() {};

/** @type {boolean} */
MyRecord.prototype.prop;

/**
 * @param {!MyRecord} record
 */
function DoSomething(record) {
	if (record.porp) {    // property name misspelled
		console.warn('!!!');
	}
};

Missing annotation
/**
 * @return {void}
 */
function DoSomething_1(prop1) {
	DoSomething_2(prop1);    // missing prop1 annotation, type safety is broken
};

/**
 * @param {string} prop1
 * @return {void}
 */
function DoSomething_2(prop1) {
	console.warn(prop1);    // prop1 is number!
};

/**
 * @param {number} prop1
 * @return {void}
 */
function DoSomething_3(prop1) {
	DoSomething_1(prop1);
};

DoSomething_3(1);

Or
/**
 * @param {string=} prop1
 */
function ReturnTypeNotDefined(prop1) {
	return true;
};

/**
 * @return {void}
 */
function DoSomething() {
	if (ReturnTypeNotDefined()) {    // missing @return annotation
		console.warn('!!!');
	}
};

The conformance framework is a better way of finding some of those things but it's more work to get it up and running, especially on a large existing codebase. I don't know how much work it would be to add the percentage on NTI but I think it's worth considering. In fact we could even get more specific and emit a per-file report (80% of the code in file1.js is typed, 90% in file2.js is typed...) and then users could decide they want a higher threshold for some files than others.


Use shallow clone to improve performance when cloning huge repos

Cloning a big repository like Kibana can be very slow and take several minutes. To improve this it might make sense to shallow clone the repository
git clone https://github.com/elastic/kibana.git --depth=100

This will only fetch the most recent commit from the default branch and is thus much faster than cloning the entire history for all branches.
git fetch --update-head-ok origin 7.x:7.x --depth=1

Another option would be using the existing repository. E.g. wherever you're making a copy first do git clone /home/user/folder.. and then you can change the origin. This way it's much faster to clone.

@ankush that's a great idea too 👍


Fix build Project file does not exist.

Fix
MSBUILD : error MSB1009: Project file does not exist.
Switch: ./build/Build.csproj

@microsoft-github-policy-service agree


Is it possible to show indetermination view without overlay, so users can interact with some special logic views?

Sometimes we want to show some indetermination views to tell user something is loading but you can interact with the app.

You can just use the indeterminate activity indicator separately without the full dialog. Alternatively you can show the dialog just above a specific view, which doesn't hide the controls, your users should be still able to interact with.

Thanks for your suggestions. I will try that.