Restructure the plugin scripts for clarity of functions and intents

Summary
As we added commands as something that can be extended, the terms -- plugin, command, script -- got a bit muddy. This PR intends to distinguish between those plugin commands and plugin scripts. The command group is called "plugin", and the option is called "--plugin".

Self-merging to avoid slowing Ayushi and Rad down because of timezone difference.


feature: next tokens example

Codecov Report

Merging #104 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files          21       21
  Lines        1082     1083    +1
  Branches       60       60
=======================================
+ Hits         1079     1080    +1
  Misses          2        2
  Partials        1        1

Impacted Files
Coverage Δ

src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01fa1f9...980cab4. Read the comment docs.

Hey @moltar, just thought of adding an example for using next tokens. This feels weird to me though
https://github.com/ScaleLeap/amazon-mws-api-sdk/blob/cc7b99eacc0b95b8295cc92a7c3d9921bfad9f9b/examples/using-next-tokens.ts#L53
https://github.com/ScaleLeap/amazon-mws-api-sdk/blob/980cab4ad65904ec1dc037a783ecf5e3335aaabd/src/index.ts#L15
As far as I know the NextToken is only used internally for double checking with purify-ts codec (just a smart guess, I'm still not sure). So it doesn't make sense to me that we'd need to expose it to the public. I could look into adjusting the codec to decoding it to string instead and adjusting affected APIs. Thoughts?

I think the idea was that tokens should be encapsulated, and also be unique for each end point. So that you cannot accidentally use one token for another endpoint.
But these tokens should definitely be able to be instantiated by the end user. Because they may come from a queue, rather than directly from the method.
E.g. think of a distributed system that is fetching 1000s of orders. We'd get a response with a next token, then add the token to the queue. Then a worker picks up the token and passes it to a method, and so forth in a loop, until no more data left. But when the token is picked up from the queue, it needs to be converted back into whatever shape the method excepts.

merging this now, let me know if there's anything that seems wrong with the examples


Added version check, un-installation commands

Added version check, un-installation commands. these commands are already tested.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dikadali sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

OPS Build status updates of commit 8ecd4be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2014866:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 406fc44:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the fixes, @dikadali.
While verifying the commands on Ubuntu 18.04 in a fresh venv, I'm getting several package incompatibility messages on pip install azure==3.0.0. I'm concerned that these incompatibilities might cause issues with those packages. Are you not seeing the incompatibility warnings in your environment? Here are some examples:

Another issue is that pip uninstall azure removes the azure meta-package but leaves the individual azure-* packages behind (and others, like adal and msrest).

This is a Python and pip limitation, however, and not a limitation of the Azure SDK (see issue #1497). Recommend that you do one of the following to accommodate this:

Note this limitation clearly in your Uninstall section
Provide additional information about removing the azure- and supporting packages, something like pip freeze | grep 'azure-' | xargs pip uninstall -y (and then individual uninstalls for adal, msrest, and msrestazure).
Remove the Uninstall section

@mmacy -Thanks for your inputs. Please see the points below.

I haven't seen any incompatibility warnings/errors. I've uninstalled Azure 4.0 SDK and installed Azure 3.0.0 SDK with pip install azure==3.0.0. It worked on windows 10, centos 7. Also tested with ubuntu 19.4.

Yes, I too see below.

Another issue is that pip uninstall azure removes the azure meta-package but leaves the individual azure-* packages behind (and others, like adal and msrest).

But when we install Azure SDK 3.0 it is uninstalling existing each individual modules like below and installing all required modules automatically.

Thanks for your inputs on this, we shall add additional info to uninstall section.

Provide additional information about removing the azure- and supporting packages, something like pip freeze | grep 'azure-' | xargs pip uninstall -y (and then individual uninstalls for adal, msrest, and msrestazure).

Docs Build status updates of commit 44d9503:
:clock10: Full build: the average full build time is 210 min(s) 36 sec(s), this is based on the last 16 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit 44d9503:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9e1e145:
:clock10: Full build: the average full build time is 213 min(s) 2 sec(s), this is based on the last 17 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit 9e1e145:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit fc2b3fd:
:clock10: Full build: the average full build time is 216 min(s) 53 sec(s), this is based on the last 22 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit fc2b3fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

LGTM, thanks @dikadali
@sptramer please review when you have a minute, thanks!

Ping @sptramer

@sptramer - Could you please review and update this pull request.

Ping @sptramer

@dikadali Showing merge conflicts, please resolve them and I'll review and merge.

Docs Build status updates of commit 41b5fbe:
:clock10: Full build: the average full build time is 222 min(s) 44 sec(s), this is based on the last 34 build(s) for this repository.

Docs Build status updates of commit 41b5fbe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/python-sdk-azure-install.md
:white_check_mark:Succeeded
View (azure-python)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sptramer - Merge conflicts are resolved, please check.

Ping @sptramer

@dikadali This PR is going to require additional work to copyedit to match the dominant article and site style before it can be merged. I'll take a closer look this week and submit another review with the required copy changes.


Configuration window multi-editing feature.

There is no need SET ALL button. just set the selected keys is enough.
Multiple selection with COMMAND and SHIFT keys,  something like this;

or
press COMMAND+A to select all keys then press SET button

Thanks for the suggestion, I think it is a nice addition.
The current design decision is to make setting a universal delays explicit, with the combination of "set all" and "enabled" checkboxes.
Holding Command/Shift to multi-select or shortcut like Command A are great idea, and they can do more things than the current interfaces. But they are implicit, and requires users to try before knowing the function is there.

Maybe you can do that the button says "Set all" if no rows are selected but as soon as selectedRows.count > 0, you change it to "Set selected". Obviously with matching behavior.
(I know that the table view doesn't work that way, but it was easier to explain.)

what is difference beetween "0 delay" and "disabled" checkbox? also there is need a "disable all" checkbox, One by one make it very hard to mark.


cherrypick-release0.15-PLUGIN-475

Cherrypick for PR: https://github.com/data-integrations/google-cloud/pull/432
JIRA Ticket: https://cdap.atlassian.net/browse/PLUGIN-475

Please cherrypick the latest fix.


New gallery identity

Theme is now lightBlue
Updated appbar background
Updated Launcher icon
Reduced the size or many of the image assets
Updated the about box icon
Disabled landscape mode

Fixes #5087
Fixes #5147

Note: IOS icons and landscape mode configuration is still TBD


OpenCensus page 404s

OpenCensus link here:
https://github.com/Azure/azure-sdk-for-java/#client-ga-november-2019-releases
Points here:
https://github.com/Azure/azure-sdk-for-java/blob/azure-core-tracing-opencensus_1.0.0-preview.4/sdk/core/azure-core-tracing-opencensus/README.md
And that README has many 404s

@jongio Thanks for informing.
I believe this has been corrected in the new release azure-core-tracing-opencensus_1.0.0-beta.5.
Please try accessing https://github.com/Azure/azure-sdk-for-java/blob/azure-core-tracing-opencensus_1.0.0-beta.5/sdk/core/azure-core-tracing-opencensus/README.md#azure-opencensus-tracing-client-library-for-java for the most updated version of the package.
Do let us know if you are still having issues.

Still broken on master - I updated first link in the issue.  That points to the branch referenced above, but the master readme still points to preview.4

@jongio That is correct. Root-level readme's are pending updates for the latest releases. They will soon be updated when all the packages are released. Have created this issue to track it.
Meanwhile,  you can use this https://github.com/Azure/azure-sdk-for-java/blob/azure-core-tracing-opencensus_1.0.0-beta.5/sdk/core/azure-core-tracing-opencensus/README.md#azure-opencensus-tracing-client-library-for-java for OpenCensus tracing.
Thanks!

@jongio The root level readme has been updated and you can now access it  https://github.com/Azure/azure-sdk-for-java/#client-ga-december-2019-releases. OpenCensus page https://github.com/Azure/azure-sdk-for-java/blob/azure-core-tracing-opencensus_1.0.0-beta.5/sdk/core/azure-core-tracing-opencensus/README.md


Offline rendering

I know this is a WIP on the website - could we get an ETA on when this is likely to make it in?

Short answer is no.  We tried and came up against some roadblocks.  We can discuss it in the Google groups.


how to write a mermaid plug?

please tell me how to write a mermaid plug? thanks

@ats1999 ,would you please past the code of your jscode? thanks

@zsanhong  you can have a look at the embed
// in customHtmlRenderer
import { mermaidAPI } from "mermaid";
 mermaid(node) {
        let html = "";
        mermaidAPI.render("mermaid", node.literal, (h) => {
            html = h;
        })
        return [
            { type: 'openTag', tagName: 'div', outerNewLine: true, classNames: ["mermaid-block"] },
            { type: 'html', content: html },
            { type: 'closeTag', tagName: 'div', outerNewLine: true }
        ];
    },


Fixed #24139 -- Evaluate reason_phrase on demand based on status_code.

buildbot, test this please.

Can we have that as a comment then, please.

Added comment as suggested. Let me know if you had something else in mind.

Rebased after the merge of #3902 and resolved conflicts.

Perhaps we can use a similar approach for status_code and status attributes, too.

Do you mind expanding on what you're requesting?
Are you saying status_code should not be a class attribute on HttpResponseBase? The other classes in this file rely on this behavior: HttpResponseRedirect, HttpResponseNotFound, etc.
Or are you saying the __init__() kwarg status should be renamed to status_code?
Sorry, but I'm not sure precisely what "status attributes" is referring to.
I'm happy to cleanup whatever needs it, I'm just not sure exactly what you're asking me to change.
I suppose one potential fix would be to fix the Content-Type header to evaluate based on the current value of self._charset. Is this along the lines of what you mean?
Version in master (if charset changes outside the constructor, the Content-Type header is wrong):
    def __init__(self, content_type=None, status=None, reason=None, charset=None):
        ...
        self._charset = charset
        if content_type is None:
            content_type = '%s; charset=%s' % (settings.DEFAULT_CONTENT_TYPE,
                                               self.charset)

Sorry for being unclear.

Or are you saying the init() kwarg status should be renamed to status_code?

That's what I meant to say. However, adding a new status_code keyword argument would be better for backward compatibility.

That's what I meant to say. However, adding a new status_code keyword argument would be better for backward compatibility.

Thanks. Will do.

I believe I have implemented what you had in mind. Let me know how you feel about the results.

This change seems to have gotten a bit unwieldy as far as the scope of the original ticket goes. Is there really a need to deprecate status in favor of status_code? I'd try to keep solving this ticket more minimal unless all these changes are really necessary to do together.

This change seems to have gotten a bit unwieldy as far as the scope of the original ticket goes. Is there really a need to deprecate status in favor of status_code? I'd try to keep solving this ticket more minimal unless all these changes are really necessary to do together.

I think I agree. In my opinion, there is no pressing need to deprecate status in favor of status_code (although I agree it is a nice to have for consistency). Shall I discard the 2nd commit? If still preferred I can move the 2nd commit to a different PR.
I originally went down this path at the request of @berkerpeksag. As a core contributor and Django Fellow I interpret his review as authoritative.
If there is disagreement about the 2nd commit, please let me know how to proceed.

OK, I've dropped the rename kwargs commit. If that is still desirable I can move it to another ticket. This will change will simply cover the goals of the original ticket.

merged in d861f95c445652e4269c9015836d14dcf8b9a587, thanks!


Links in Configuring SAML2 Single-Sign-On Across Different WSO2 Products are redirected to wrong pages.

Links for 'Managing the Feature Repository" and "Installing Features" which are mentioned in [1] are redirected to wrong pages.
[1] (https://docs.wso2.com/display/IS560/Configuring+SAML2+Single-Sign-On+Across+Different+WSO2+Products#)

Fixed [1].
[1] (https://docs.wso2.com/display/IS560/Configuring+SAML2+Single-Sign-On+Across+Different+WSO2+Products#)


nim: 1.0.2 -> 1.0.4

Motivation for this change
https://github.com/nim-lang/Nim/blob/version-1-0/changelogs/changelog_1_0_4.md
Things done
Bumped version.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build nim


Numpy support for string related functions

When the spice function requires the use of the Python string method, it does not currently work to provide a numpy array with the strings, e.g.:
scid = -64
arr = np.array(['3/0597205898.09324', '3/0597205898.09952', '3/0597205898.10580',
       '3/0597205898.11836', '3/0597205898.12464'])
spice.scencd(scid, arr)

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-62-71689f28cd51> in <module>
----> 1 spice.scencd(scid, arr)

~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/spiceypy.py in with_errcheck(*args, **kwargs)
     75     def with_errcheck(*args, **kwargs):
     76         try:
---> 77             res = f(*args, **kwargs)
     78             checkForSpiceError(f)
     79             return res

~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/spiceypy.py in scencd(sc, sclkch, MXPART)
  10984     """
  10985     sc = ctypes.c_int(sc)
> 10986     sclkch = stypes.stringToCharP(sclkch)
  10987     sclkdp = ctypes.c_double()
  10988     libspice.scencd_c(sc, sclkch, ctypes.byref(sclkdp))

~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/utils/support_types.py in stringToCharP(inobject, inlen)
    195     if isinstance(inobject, int):
    196         return stringToCharP(" " * inobject)
--> 197     return c_char_p(inobject.encode(encoding='UTF-8'))
    198
    199

AttributeError: 'numpy.ndarray' object has no attribute 'encode'

That's because a Python string has the encode method build in, but the spiceypy function does not reach it via the numpy array.
Describe the solution you'd like
Above call should work. ;)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
My work around is:
encodedSclk = [spice.scencd(scid, item) for item in arr]

So although numpy arrays have the ability to contain string and object data types I have never anticipated a user to use numpy for strings. Numpy is synonymous with numerical arrays, I’ll research this more but is this significantly better than using lists instead?
-Andrew Annex

On Oct 31, 2019, at 7:14 PM, K.-Michael Aye<EMAIL_ADDRESS>wrote:

When the spice function requires the use of the Python string method, it does not currently work to provide a numpy array with the strings, e.g.:
scid = -64
arr = np.array(['3/0597205898.09324', '3/0597205898.09952', '3/0597205898.10580',
'3/0597205898.11836', '3/0597205898.12464'])
spice.scencd(scid, arr)

AttributeError                            Traceback (most recent call last)
 in
----> 1 spice.scencd(scid, arr)
~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/spiceypy.py in with_errcheck(*args, **kwargs)
75     def with_errcheck(*args, **kwargs):
76         try:
---> 77             res = f(*args, **kwargs)
78             checkForSpiceError(f)
79             return res
~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/spiceypy.py in scencd(sc, sclkch, MXPART)
10984     """
10985     sc = ctypes.c_int(sc)

10986     sclkch = stypes.stringToCharP(sclkch)
10987     sclkdp = ctypes.c_double()
10988     libspice.scencd_c(sc, sclkch, ctypes.byref(sclkdp))

~/miniconda3/envs/py37/lib/python3.7/site-packages/spiceypy/utils/support_types.py in stringToCharP(inobject, inlen)
195     if isinstance(inobject, int):
196         return stringToCharP(" " * inobject)
--> 197     return c_char_p(inobject.encode(encoding='UTF-8'))
198
199
AttributeError: 'numpy.ndarray' object has no attribute 'encode'
That's because a Python string has the encode method build in, but the spiceypy function does not reach it via the numpy array.
Describe the solution you'd like
Above call should work. ;)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
My work around is:
encodedSclk = [spice.scencd(scid, item) for item in arr]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

It is, in the context of using pandas as a data container.
When one is reading large XML data files, for example from OREX OLA, using pds4_tools the return is a pandas DataFrame.
And some of this columns simply are strings, there's no way around that.

Let me correct myself: I am using pds4_tools like that, although it does not directly return pandas:
df = pd.DataFrame(pds4_read(str(self.l0_path))[0].data)

However, I think pandas is immensely productive in dealing with raw instrument data, due to its immediate table view and efficient array manipulation, so I think this should be supported.

I will put in PR's for the other 2 functions, if you could have a look how to do this with strings, would be great?

this function will need to be vectorized to handle the numpy array as given in the example code above, fyi to myself

also as a fyi to myself there are a few different ways strings are used in cspice, typically parameters are given as a 1d strings but in some cases 2d string arrays are parameters not used in loops.

I'm closing this issue as #310 supersedes it now that underlying issue for support of strings in numpy arrays has been fixed


JUnit5 assertThrows EmailTest

Codecov Report

Merging #106 (9eab161) into master (881928e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #106   +/-   ##
=========================================
  Coverage     65.71%   65.71%
  Complexity      304      304
=========================================
  Files            18       18
  Lines          1053     1053
  Branches        138      138
=========================================
  Hits            692      692
  Misses          282      282
  Partials         79       79

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

-1 does not compile.


Private EC2

Currently, our EC2 instances are publicly available.

Create Private Subnets: Move our Docker Swarm nodes to private subnets. Private subnets don't have a route to the internet by default and their instances can't be accessed directly from the internet.
Set Up NAT Gateway: Create a NAT Gateway in a public subnet. This NAT Gateway allows instances in the private subnet to initiate outbound connections to the internet while hiding their private IP addresses.
Update Route Tables: Update the route tables of your private subnets to route outbound traffic to the NAT Gateway.
Security Group Configuration: Ensure that your security groups only allow necessary inbound and outbound traffic. For example, you might allow inbound traffic only from specific IP addresses or subnets that need to access your services.

By setting up the Docker Swarm nodes in private subnets and routing their outbound traffic through a NAT Gateway, we effectively hide them from direct access from the internet. This setup adds an additional layer of security to our infrastructure.
### Done in stages
- [x] Master --> https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/664
- [ ] Stag --> https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/672
- [x] [Prod] AWS TIP --> https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/674#e7d14d429f898757a423156de0e8c49d75240694
- [ ] [Prod] NIH
- [ ] [Prod] Sim4life --> https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/689

connected to https://github.com/ITISFoundation/osparc-ops-environments/issues/195

Private docker swarm cluster machines
It seems that managers have to be on a public subnet. We can still have worker nodes private though

Before you begin, ensure that the virtual private cloud (VPC) for your load balancer has at least one public subnet in each Availability Zone where you have targets.

source: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/create-network-load-balancer.html

The instances need to be on a public subnet with their default route pointing to the Internet Gateway in order to work with an outside-facing NLB

source: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/create-network-load-balancer.html

Progress

[ ] Make sure AWS NLB + private EC2 setup is feasible
[ ] Configure ansible to work with Bastion host
[ ] Prepare terraform
[ ] Migrate data

Blocked by https://github.com/ITISFoundation/osparc-ops-environments/issues/716

Also blocked by https://github.com/ITISFoundation/osparc-ops-environments/issues/718


UI BUG?

This is the first time I tried this mod and I think this is the UI bug.

There is no bug here, I just haven't given the new items their icons yet. Nothing to worry about.


can't access dead object

Our Bugsnag is reporting the following error:
TypeError can't access dead object
    ../node_modules/@bugsnag/browser/dist/bugsnag.js:2262 init/t.onreadystatechange

Unfortunately that's all we have, it's the full stacktrace which led me to believe it's an issue with this package.
Currently I don't know of any way to reproduce this so I can't cook up an example.
Is this a known issue?

Hi @jordyvandomselaar
That error is explained in more detail here:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Dead_object
Is your project a browser extension?

Hey @mattdyoung,
Thanks for replying! It's not a browser extension =), it's a react app running in the browser

Hi @jordyvandomselaar
Actually, we think this could happen just due to an extension installed on the web browser where the code was run.
Is this something you've seen yourself when testing or only from one of your users? Are you able to find out about any installed browser extensions?
It would be good to find a way to reproduce to confirm the root cause.

Hi @mattdyoung ,

Actually, we think this could happen just due to an extension installed on the web browser where the code was run.

We came to the same conclusion initially but because the stacktrace only showed Bugsnag we figured it could also have to do with Bugsnag =)

Is this something you've seen yourself when testing or only from one of your users? Are you able to find out about any installed browser extensions?

I am unable to reproduce this myself, Bugsnag has been reporting this error a number of times and we're investigating what might be the cause.
Unfortunately, I am unable to see what extensions our users have installed

Hi @jordyvandomselaar
We've seen some other instances of this error now but the line of code and stacktrace reported appears to differ although all occurrences are in Firefox browsers.
We're fairly confident this is due to a misbehaving Firefox add-on. We'd like to try and reproduce to be sure, but are also struggling to find a way to reproduce or find an occurrence from someone where we know which addons are installed.
If you find any way to reproduce please let us know, and similarly we'll report back here if we find more info.

Hi @mattdyoung,
You're the best! Thanks for thinking with me and I'll keep you posted if something pops up! =)


Formally spec an API for interacting with integration managers

Background
Integration managers are applications that help clients bring integrations (bridges, bots, etc) to users. This may be for things like setting up bridging to an IRC channel, adding Giphy to your room, or sharing a document with a widget. Integration managers were popularized by Riot, however other clients are starting to bring in support for the concept as well.
There are 2 integration managers at the time of writing this, each with different goals and APIs. Scalar (aka Modular) is the proprietary manager that ships with Riot and is developed specifically for Riot. Dimension (a project of mine) is open source and caters towards self-hosted integrations. As mentioned, both of these managers have different APIs once getting past the (very) basic client interaction. A formal spec should be documented so that future managers, and the existing ones, can adhere to a common standard for clients to use.
Components to consider for the spec
Although clients are encouraged to just nest an iframe (or similar) in their application, it can be difficult or undesirable to do so. A client with an objective for rich integration support may not want to use an iframe and instead opt to interact with the manager directly, providing their own UI/UX. Fractal, for example, is currently doing this with stickers: they have their own sticker picker which reaches out to the API directly instead of using an iframe.
The components available today are:

The widget postMessage API - https://github.com/matrix-org/matrix-doc/issues/1089
The integration manager postMessage API (unspecced, informal documentation here: https://github.com/turt2live/matrix-dimension/blob/master/docs/reference/scalar_client_api.md)
The API used by clients (Riot) to get information (namely /register, /account, and /widgets/title_lookup)

Some additional things that should be documented in my opinion are:

The API the manager uses to power its UI. Scalar's is informally documented here: https://github.com/turt2live/matrix-dimension/blob/master/docs/reference/scalar_server_api.md while Dimension's isn't formally documented (however, it does differ). The motivation for having a common spec for this is for those clients which do not want to (or can't) embed an iframe and instead want their own UI.
Inter-manager APIs. These currently don't exist, and it'd be nice if there was a way for managers to 'share' integrations. For example, using Giphy as supplied by Scalar and using a self-hosted IRC bridge. Full disclosure: this is on the roadmap for Dimension.

ftr this is on my personal todo list, although I wouldn't object if someone beat me to it (hence documenting it publicly).

ftr,  we absolutely need this - the only reason this ticket hasn't been progressed by the core team (including @turt2live :) is lack of tuits.

Things to definitely include are:

https://github.com/matrix-org/matrix-doc/issues/1089
https://github.com/matrix-org/matrix-doc/issues/1236
https://github.com/matrix-org/matrix-doc/issues/1354
https://github.com/matrix-org/matrix-react-sdk/pull/1342 (or a variation thereof)
https://github.com/vector-im/riot-web/issues/7153

Things to definitely reference are:

https://github.com/matrix-org/matrix-doc/issues/1256


Does racher Cattle only support dnsrr mode for service?

Rancher Version:
1.2.1
Docker Version:
1.12
OS and where are the hosts located? (cloud, bare metal, etc):
ubuntu
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
service:nginx   scale=3  and a busybox
Results:
when i in busybox run command: wget -O- nginx  it worked well but then
stop  the container of nginx service which busybox used ,  wget -O- nginx will timeout until rancher start the container again  the dnsrr mode couldn't support  load balancing well
Expected:
will you plan to support vip mode in Cattle

#3495


⚠ Bofrost.de has degraded performance

In 3d52e09, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2358 ms

Resolved: Bofrost.de performance has improved in 1f74852 after 10 minutes.


:bucket: Bump minimum NodeJS version

c.f. #1151

I think that we could drop node 16 actually and start testing 22. We should do that in another PR and update a few parts of the docs and the min version.

Originally posted by @rowanc1 in https://github.com/executablebooks/mystmd/issues/1151#issuecomment-2077122162

There is another place in the session that compares npm and node versions. On my phone at the moment. I think also the install node pages might need an update?

Thanks, found the remaining items I think :crossed_fingers:

A few more places:

https://github.com/executablebooks/mystmd/blob/main/packages/mystmd-py/src/mystmd_py/main.py#L17
https://github.com/executablebooks/mystmd/blob/main/packages/mystmd-py/src/mystmd_py/main.py#L30
https://github.com/executablebooks/mystmd/blob/main/packages/mystmd-py/src/mystmd_py/main.py#L32
https://github.com/executablebooks/mystmd/blob/main/docs/installing-prerequisites.md#L12

Next commit should've done those I think.

Ok, I think this is good - a changeset of a minor for the CLI?
If we turn this into a warning rather than an exit, maybe that is better, but then we would need to test in 16 and not sure how to do that if we can't build in it.

Yeah I think we just make a minor bump. Now's the time to make these kind of changes vs in a year's time (i.e., we can move a bit fast and break some things).

Ok - can you add the changeset! :)

Works well locally:


Inconsistent page navigation when zoomed in on Kobo devices

When using the nextPage command on a Kobo device, the page navigation doesn't account for the current zoom level. This results in skipping content when the zoom level doesn't correspond exactly to one page.

@tsowell Can you please help me here, do you have a list of possible commands other than Page or Chapter to move considering the zoom. When I use nextPage it skips a some kobo pages since it doesn't consider the zoom. Thank you very much


Add additional convenience methods for Neo4j containers

This change adds the following methods for the Neo4j container
• public S withDatabase(MountableFile graphDb)
• public S withPlugins(MountableFile plugins)
• public S withNeo4jConfig(String key, String value)
• public S withoutAuthentication()
Those have been described in the readme of Neo4j.
For being able to test withDatabase, I have added a very small Neo4j graph.db store to the test-resources. This is our native format.
For testing withPlugins I wanted to avoid adding a binary jar, so I added a submodule being build before the test. My Gradle foo is not that good, maybe there's a better way to do this.
Thanks for taking the PR into consideration. The Neo4j container has been a great success with some of our partners and customers so far.

@michael-simons great job, thank you!

Released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.10.7!


Integrate Sysinternals' ZoomIt

Description of the new feature / enhancement
would be awesome to have ZoomIt as part of PowerToys - useful tool for presenters
Scenario when this would be used?
all presenters especially now where we work remotely, sharing screen and be able to mark/point out things/zoom in and out on our screen while sharing screens
Supporting information
https://learn.microsoft.com/en-us/sysinternals/downloads/zoomit
might want to ask permission/discuss with Mark Russinovich :)

/dup #149


[Light Switch Widget] Featur request: Save brightness to setting.json

@storm64
I'd like it if Light Switch Widget updated the global brightness setting when releasing from sliding to change the brightness level. Maybe it would be best to add it as an option.
I tried implementing this, but it was harder than I expected.
This is what I tried to add at a couple of places:
        let storage = require("Storage");
        let settingJs = storage.readJSON("setting.js");
        settingJs.brightness = value;
        print(settingJs.brightness); // to see if the code executes
        storage.writeJSON("setting.js",settingJs);

If I remember correctly the boot code is rewritten when a change in the settings.js is recognized. And to prevent this to happen quite frequently, I chose to use a separate position to store the brightness value.

Ah, I see. That makes sense. I'll close this as not planned.


bug nginx /etc/nginx/sites-available/default  for none ipv6 host

I have found a bug
both are linked with  /etc/nginx/sites-available/default
here the original container file:
##
# You should look at the following URL's in order to grasp a solid understanding
# of Nginx configuration files in order to fully unleash the power of Nginx.
# https://www.nginx.com/resources/wiki/start/
# https://www.nginx.com/resources/wiki/start/topics/tutorials/config_pitfalls/
# https://wiki.debian.org/Nginx/DirectoryStructure
#
# In most cases, administrators will remove this file from sites-enabled/ and
# leave it as reference inside of sites-available where it will continue to be
# updated by the nginx packaging team.
#
# This file will automatically load configuration files provided by other
# applications, such as Drupal or Wordpress. These applications will be made
# available underneath a path with that package name, such as /drupal8.
#
# Please see /usr/share/doc/nginx-doc/examples/ for more detailed examples.
##

# Default server configuration
#
server {
        listen 80 default_server;
        listen [::]:80 default_server;

        # SSL configuration
        #
        # listen 443 ssl default_server;
        # listen [::]:443 ssl default_server;
        #
        # Note: You should disable gzip for SSL traffic.
        # See: https://bugs.debian.org/773332
        #
        # Read up on ssl_ciphers to ensure a secure configuration.
        # See: https://bugs.debian.org/765782
        #
        # Self signed certs generated by the ssl-cert package
        # Don't use them in a production server!
        #
        # include snippets/snakeoil.conf;

        root /var/www/html;

        # Add index.php to the list if you are using PHP
        index index.html index.htm index.nginx-debian.html;

        server_name _;

        location / {
                # First attempt to serve request as file, then
                # as directory, then fall back to displaying a 404.
                try_files $uri $uri/ =404;
        }

        # pass PHP scripts to FastCGI server
        #
        #location ~ \.php$ {
        #       include snippets/fastcgi-php.conf;
        #
        #       # With php-fpm (or other unix sockets):
        #       fastcgi_pass unix:/var/run/php/php7.4-fpm.sock;
        #       # With php-cgi (or other tcp sockets):
        #       fastcgi_pass <IP_ADDRESS>:9000;
        #}

        # deny access to .htaccess files, if Apache's document root
        # concurs with nginx's one
        #
        #location ~ /\.ht {
        #       deny all;
        #}
}

# Virtual Host configuration for example.com
#
# You can move that to a different file under sites-available/ and symlink that
# to sites-enabled/ to enable it.
#
#server {
#       listen 80;
#       listen [::]:80;
#
#       server_name example.com;
#
#       root /var/www/example.com;
#       index index.html;
#
#       location / {
#               try_files $uri $uri/ =404;
#       }
#}

here the first error message
nginx_1        | *** Running /etc/my_init.d/setup.sh...
nginx_1        | Saving debug log to /var/log/letsencrypt/letsencrypt.log
nginx_1        | Error while running nginx -c /etc/nginx/nginx.conf -t.
nginx_1        |
nginx_1        | nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx_1        | nginx: [emerg] socket() [::]:80 failed (97: Address family not supported by protocol)
nginx_1        | nginx: configuration file /etc/nginx/nginx.conf test failed
nginx_1        |
nginx_1        | The nginx plugin is not working; there may be problems with your existing configuration.
nginx_1        | The error was: MisconfigurationError('Error while running nginx -c /etc/nginx/nginx.conf -t.\n\nnginx: the configuration file /etc/nginx/nginx.conf syntax is ok\nnginx: [emerg] socket() [::]:80 failed (97: Address family not supported by protocol)\nnginx: configuration file /etc/nginx/nginx.conf test failed\n')
nginx_1        | *** /etc/my_init.d/setup.sh failed with status 4
nginx_1        |
nginx_1        | *** Killing all processes...

seems to be linked to ipv6
workaround removing ipv6 listening:
insert the following line at line 17 on the nginx docker file
run sed -i 's/listen [::]:80 default_server;/#listen [::]:80 default_server;/g' /etc/nginx/sites-available/default

@MuruganChandrasekar please take a look....

Ok. I'll check and let you know. But this is not a bug it seems.

@MuruganChandrasekar, I take it you mean that you've not encountered the problem. Neither have I.
Given that we don't see this in our deployments, I suspect that there are "environmental interactions". @keiser1080, we deploy this typically on Ubuntu 20 servers on Digital Ocean. We normally have IPv6 enabled on the base server. How and where are you deploying?

Yes Terry. We haven't faced the issue since both the IPv4 and IPv6 address enabled automatically. We have checked it on Microsoft Azure and Digitalocean cloud as well.

@MuruganChandrasekar, I take it you mean that you've not encountered the problem. Neither have I.
Given that we don't see this in our deployments, I suspect that there are "environmental interactions". @keiser1080, we deploy this typically on Ubuntu 20 servers on Digital Ocean. We normally have IPv6 enabled on the base server. How and where are you deploying?

yes it's seems to be related on the host os.
ipv6 is disabled
cat /sys/module/ipv6/parameters/disable
1


(19-m1-implement-parse-function-from-query-to-json):created parseQuer…

…yToJson function in parseFunctions.js file. Also created constants.js to store useful constants

@arrivillagaTomas i've created #29 for the linter.


Factory reports

Summary
Factory methods can be used to simplify the process of creating more common reports. For example, the current method of getting the daily performance for a specific video is:
client = YouTubeAnalytics("secrets.json")
client.retrieve(
    dt.date(2021, 1, 1),
    dt.date(2021, 6, 30),
    dimensions=("day",),
    filters={"video": "videoID"},
)

The proposed method would look (something) like this:
factory = YouTubeAnalyticsFactory("secrets.json")
factory.video_performance("videoID", by="day", since=dt.date(2021, 1, 1))

A better example would be getting the daily performance channel wide:
factory = YouTubeAnalyticsFactory("secrets.json")
factory.daily_performance(since=dt.date(2021, 1, 1))

The idea
It will make it quicker and easier for users to make more common requests.
The ideal implementation
A separate YouTubeAnalyticsFactory class.
Contribution
Do you want to contribute this feature yourself?
Yes

I'm changing the proposed implementation.

The factory methods will be part of the YouTubeAnalytics class -- creating a new class for them seems a bit silly.
There'll be three methods:

Daily stats
client.daily_stats(of=None, since=None, last=28, metrics="all")

where of is a video ID, since is the date to start collecting data from, last is the number of days to get data from (ignored if since is provided), and metrics is a series of metrics.
Monthly stats
client.monthly_stats(of=None, since=None, last=3, metrics="all")

where of is a video ID, since is the date to start collecting data from, last is the number of months to get data from (ignored if since is provided), and metrics is a series of metrics.
Regional stats
client.regional_stats(of=None, for_provinces=False, metrics="all")

where of is a video ID, for_provinces is whether data should be collected for provinces (states), and metrics is a series of metrics.
Top videos
client.top_videos(by="views", since=None, last=28, metrics="all")

where by is how to sort videos, since is the date to start collecting data from, last is the number of months to get data from (ignored if since is provided), and metrics is a series of metrics.
Tasks

[ ] daily_stats
[ ] monthly_stats
[ ] regional stats
[ ] top_videos

Closed by 49928a4.


8: roboter did not leave playing field when solving the lvl

The error can be reproduced in Task 3:

Robot x position jumps from 4 to 2 to 1 to 0.
I think the bug is related to #55


len(type) -> type.bit_width

Makes it more explicit and then we can have Bit.bit_width return 1

I thought we decided to have only len on Array types. the .size property is already implemented which gives you the raw size (bit width) of the signal.

@cdonovick use type.size to get the bit width instead of len.


Add 3steam.edu.pl

@aleksy3steam Regrettably, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Makes the SG unable to make point-blank shots

About the PR
Didn't notice that the SG inherited from the base rifle when making the accuracy PR.
Why / Balance
Bug.
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog
:cl: Sigil

fix: The smartgun is no longer able to PB.

I did do that. The PB couldn't hit a marine though so I dont think it was a true PB.

I did do that. The PB couldn't hit a marine though so I dont think it was a true PB.

PBs respect IFF regardless, so it wouldn’t hit a marine.

I did do that. The PB couldn't hit a marine though so I dont think it was a true PB.

PBs respect IFF regardless, so it wouldn’t hit a marine.

They don't and it would. Which is intentional.


VanillaCallbackWrapper might cause a leak

It seems that if I assign a method of a class that is a subclass of NSObject to a callback of a EditText than VanillaCallbackWrapper is storing a strong reference to that object (in initWithCallback_). Using self.callback = weakref.ref(callback) fixes it for me. I’m not sure if that would cause any trouble elsewhere.
I’m not sure if the python garbage collector is clever enough to find that loop (object retains the text field and the text fields VanillaCallbackWrapper is retaining the object) and break it so this might leak in pure python, too.

Can you post a complete example? You can't create a weakref to a method of an NSObject subclass, so I don't understand your suggested fix.
Creating a weakref to a Python bound method is problematic, as it will go away immediately if you don't keep a hard reference.
In vanilla, cycles like this usually get cleaned up when the window closes, and it seems that should be done in this case, too:
https://github.com/robotools/vanilla/blob/04af4a5c1627ca810dd46b83d92cc354a4ddcbf8/Lib/vanilla/vanillaBase.py#L69-L71

Thanks for you comments.
When you can add objc.python_method to the method to prevent the conversion into a selector. That is needed a lot in python 3 as it is more strict and will fail when the method name is not a valid signature (number of underscores != number of arguments).
In this occasion, the window part is not used because we only use the main view as UI inside Glyphs (e.g. in the sidebar). So the window is never shown and never closed and thous will not call _breakCycles.
Shouldn’t a method reference be valid until the object it came from is deallocated? Where else would you get a method reference from?

That's not how method references work in Python. A bound method object keeps a reference to the object and it is not cached. Each time you ask for a bound method you get a new bound method object. This is to avoid cyclic references. So yes, the lifetime of the bound method object can be shorter than the lifetime of the underlying object.
class Example:
    def method(self):
        pass

e = Example()
print(e.method == e.method)  # sure, they're equivalent/equal
print(e.method is e.method)  # but they are distinct objects

_breakCycles() is an essential piece of vanilla machinery. If you use vanilla objects in non-vanilla contexts, it is your responsibility to call it at the appropriate time.

This is very good to know. Thanks.


New angularfire2 version 4.0.0-rc.1 : .take(1) on db.list fail

@davideast   I upgraded my Angular 4 app to work in conjunction with angularfire2 4.0.0-rc.1 and have run into an issue when executing .take(1) on db.list. This worked fine in the previous version but not in v4. Any ideas?
 this._db.list('$keygoeshere/clients').take(1)         .subscribe(results => {             this.clients = results         })
Debug output
Error: Uncaught (in promise): TypeError: this._db.list(...).take is not a function
TypeError: this._db.list(...).take is not a function
at ClientsListComponent.webpackJsonp.167.ClientsListComponent.ngOnInit
Version info

Angular: 4.0.0
Firebase: 4.1.2
AngularFire: 4.0.0-rc.1

@jamesamuel Are you importing the operator?
import 'rxjs/add/operator/take';

Thanks! One of those days!
p.s. you're the king 💪


multiple chart.AppendDataAsync(newData); will freeze the browser

I was testing the line chart example mentioned in https://apexcharts.github.io/Blazor-ApexCharts/methods/append-data. When having an update every second or so, the browser (Chrome) will use a huge amount of resources and the page will not or very slow respond. Have I created a memory leak or something like it?

Hi,
Not sure I'm missing something here but if you append data more memory will be used.


Very low GPU usage when training on 8 GPU in a single machine

Hi, I am currently pretaining the BERT on my own data. I use the alpha0.0.1a5 branch (newest version). I found only 20% of the GPU is in use.
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 384.81                 Driver Version: 384.81                    |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  Tesla V100-SXM2...  On   | 00000000:3F:00.0 Off |                    0 |
| N/A   40C    P0    58W / 300W |  10296MiB / 16152MiB |     32%      Default |
+-------------------------------+----------------------+----------------------+
|   1  Tesla V100-SXM2...  On   | 00000000:40:00.0 Off |                    0 |
| N/A   37C    P0    55W / 300W |   2742MiB / 16152MiB |     23%      Default |
+-------------------------------+----------------------+----------------------+
|   2  Tesla V100-SXM2...  On   | 00000000:41:00.0 Off |                    0 |
| N/A   40C    P0    58W / 300W |   2742MiB / 16152MiB |      1%      Default |
+-------------------------------+----------------------+----------------------+
|   3  Tesla V100-SXM2...  On   | 00000000:42:00.0 Off |                    0 |
| N/A   47C    P0    61W / 300W |   2742MiB / 16152MiB |     24%      Default |
+-------------------------------+----------------------+----------------------+
|   4  Tesla V100-SXM2...  On   | 00000000:62:00.0 Off |                    0 |
| N/A   36C    P0    98W / 300W |   2742MiB / 16152MiB |     17%      Default |
+-------------------------------+----------------------+----------------------+
|   5  Tesla V100-SXM2...  On   | 00000000:63:00.0 Off |                    0 |
| N/A   38C    P0    88W / 300W |   2736MiB / 16152MiB |     23%      Default |
+-------------------------------+----------------------+----------------------+
|   6  Tesla V100-SXM2...  On   | 00000000:64:00.0 Off |                    0 |
| N/A   48C    P0    80W / 300W |   2736MiB / 16152MiB |     25%      Default |
+-------------------------------+----------------------+----------------------+
|   7  Tesla V100-SXM2...  On   | 00000000:65:00.0 Off |                    0 |
| N/A   46C    P0    71W / 300W |   2736MiB / 16152MiB |     24%      Default |
+-------------------------------+----------------------+----------------------+

I am not familiar with pytorch. Any one konws why?

I think you should adjust the batch_size for full gpu usage. -b or --batch_size option can let you change the batch_size. :)

Wow. 8 V100...
I think the problem is with this line:
    device = torch.device("cuda:0" if cuda_condition else "cpu")
Only one gpu is used in this situation

@mapingshuo BTW... what a beautiful experimental device.. V100x6...

@jiqiujia well DataParallel automatically distributed to each GPU as you can see the 1-7 gpu memory usage

@codertimo I modified the batch_size from 64 to 128, this helps a little. When I tried a bigger batch_size (192), I get the Out Of Memory error. I'm trying to figure out the OOM problem now :)

hah @mapingshuo sounds like your adding new GPU device

1 GPU is quicker than 8 GPU in parallel, funny.

Oh, I found my vocab is too big (300,000) and I got 160 million parameters. Then I tokenized my original text and set min_freq as 5 when generating vocabulary. Now, the vocab_size became 30,000 and  the parameters num became 22 million. The training is much quicker, because I can modified the batch_size from 128 to 1024.
Maybe you can warn people not to generate vocabulary with plain text, haha.
Still, only 10% ~ 20% of the GPU is in use. Confused.

@mapingshuo maybe it's time to increase the batch_size as fully as possible to fit in GPU memory

Try to move the criterion function in the forward function in bert.py and just return the loss of masked language model. （the output of the encoder is not used in the back），The speed will be more than doubled. and the use of gpu will be more than 70%-90%

I know the trick from a newbee colleague.

1 GPU is quicker than 8 GPU in parallel, funny.

hi can you pls reply on how to overcome that because it is the problem that i have been  facing as well

1 GPU is quicker than 8 GPU in parallel, funny.

hi can you pls reply on how to overcome that because it is the problem that i have been facing as well

Sorry, I forgot...

Try to move the criterion function in the forward function in bert.py and just return the loss of masked language model. （the output of the encoder is not used in the back），The speed will be more than doubled. and the use of gpu will be more than 70%-90%

I know the trick from a newbee colleague.

Sorry, I met OOM problem, but I don't understand what you meant exactly, is there something different between your screenshot and the author's origin code?


calc Pi & convert

No, BigDecimal / BigMath is not needed
You should check required precision within loop for (double i = 1; i < numberOfIterations+1; i++) (line 313) and make additional break.
You may use piOld and pi variables within calcPi for checking required precision.
Also you may use array int[] targetNumCounts = new int[precision], where you firstly place zeros. Then when positioned number (after dot) will be changed within Pi iteration, replace targetNumCounts[numberPos] = 0; when positioned number will not be changed, just increase targetNumCounts[numberPos]++. So you will have desired precision, when every element of targetNumCounts array is non-zero and e.g. more than 20.


Fix msrv check by pinning home dependency

What changes are proposed in this pull request?

hdfs-native depends on which which depends on home. home recently updated and bumped their msrv to 1.81. This pins us to the previous version.

How was this change tested?

Check that the msrv test now passes

Seems like we'd need to manually update this if we want to stay up to date with hdfs/home. Is this a problem if we forget or leave it at this version?

LGTM! also is there a way to get better output in the CI job? failing was just showing 'exited with code 1'

Yeah, there are some options. I didn't enable them here since I think in general checking locally should repo things as long as we remember to cargo update

LGTM! also is there a way to get better output in the CI job? failing was just showing 'exited with code 1'

Yeah, there are some options. I didn't enable them here since I think in general checking locally should repo things as long as we remember to cargo update

Lol yea the 'remember to cargo update' is what i didn't do..

Yeah, if hdfs-native updates and needs a newer version of home we'll either have to pin an older version of that crate or bump our msrv. We can deal with that as needed.

Ahh so it will fail compilation and tell us we need to update home. That's good. thx!


Error to Create or Extract USM file 2nd

I'm trying to create a USM without encryption .,But there's a problem.
I have already copied files ffmpeg.exe and ffprobe.exe to wannacri.exe folder.
command:wannacri createusm 666.mp4
666.mp4 is a video，My computer can play normally

The format of the USM file I want to convert is vp9 and not encrypted。
What should I do next？

Still wrong.
My aaa.mp4 is converted using ffmpeg, and the command line is:
ffmpeg - i test.mp4- c copy aaa.mp4

Sorry for the late reply. Can you show a screenshot of the error?


Not able to add eMotion Max to Home Assistant

Hey there,
for me it´s not possible to add the Linknlink eMotion Max to home assisten. The sensor is correctly integrated in my home network und works fine with the linknlink app on iPhone. But every time I try to add the sensor to home assistent I got this erreor message:
"Unknown error occurred"

Same here, it seems the eMax is still not integrated nor described in the readme. Is there any progress? @xuanxuan000

I was able to get it to work through mqtt.  Set it up in the app and it will instantly recognize in hass.


Add libyaml-parser-error.t to test invalid YAML

Add script to update test lists

Hi @perlpunk,
Could you comment about what problem you are solving here?
ie What's the current state of things, what are the problems, and what features does your solution provide.
I took a look at the code, but waas not able to get the problem/solution clear in my head.
Thanks!

Currently, make test-suite tests valid cases from yaml-test-suite.
I added yaml-parser-error.t to test that invalid YAML is correctly parsed as invalid.
This helps to ensure that future development does not introduce bugs.

the update-test-list.sh is just a utility to put all current tests into the yaml-{parser,emitter,parser-error}.list to check if there are new tests passing that didn't pass before.

Hmm. The problem here is that keeping the list in the master branch of yaml/libyaml means that we are going to have new commits for every change to the test-suite. I would like to see only solid change commits go into master.
I would propose that we keep the list on a separate branch. The relatively new git worktree command lets you checkout a branch as a subdir. The test suite could then checkout that branch before running tests.
If you are concerned about the master and test-suite-data branches being in sync, Id add a file to the test-suite-data branch that contains 2 sha1s:

the commit of the yaml-test-suite synced from
the HEAD of yaml/libyaml master at time of commit

Then the test suite can easily report when things are not up to date.
If we do this right, then we only add one commit to master to set this up.

I don't understand the problem. The update script has to be called manually.
There are already existing lists libyaml-{parser,emitter}.list. I'm not sure why adding a list for invalid tests now should be a problem.

@perlpunk This list was added by me, but I am realizing that it was not a good idea to add this to master, at least during a time when I expect a massive influx to the test suite.
make test-suite is really just a dev only thing, and to flood (I'm imagining this would happen) master with commits that are only test related, feels wrong to me now.
So far we have only update the list twice. I think it would be a good idea to move the list to a branch.
This was my fault for setting it up badly, and I can make the correction. @perlpunk if you want to do it, I could help you spec it out more, if needed.
Cheers, and sorry for the confusion.

@perlpunk while I'm thinking of this, probably the best thing to do here is move all the logic that deals with testing the test-suite to a branch called test-suite and then in master all we have is a Makefile rule that looks like this:
test-suite:
        git worktree add test/suite test-suite
        make -C test/suite test

The branch could assume that it would be checked out under the test/suite subdir, when referencing the libyaml code in the main directory.

I won't have time for this in the next weeks.

@perlpunk ok, I'll give it a shot. I can use this PR and just change it over to keep the content on a new branch.
Thanks!

After taking a look at the code, it's almost set up perfectly already. All that needs to happen is to move the tests/run-test-suite to a branch called run-tests-suite and then add a dependency to the test-suite Makefile rule for tests/run-test-suite.
@perlpunk I'll make these changes on a branch and then let you decide if you want to add them to this PR (instead of making a new PR that includes this one).

@perlpunk https://github.com/yaml/libyaml/tree/issue-81 adds one commit to master, removing the tests/run-test-suite/ dir (now on branch run-test-suite). The new branch has your fixes from this PR.
Let me know if this works for you. After this you can update the run-test-suite branch without needing to go through this PR process, since it is now decoupled from master development.

On a fresh clone I get this:
% git checkout issue-81
% ./bootstrap
% make
% make test
% make test-suite
git worktree add tests/run-test-suite run-test-suite
fatal: invalid reference: run-test-suite
Makefile:899: recipe for target 'tests/run-test-suite' failed
make: *** [tests/run-test-suite] Error 128

@perlpunk, fixed in b556cfb.

and to flood (I'm imagining this would happen) master with commits that are only test related, feels wrong to me now

just wanted to note that it was not my plan to "flood" libyaml with commits.

@perlpunk I wasn't being accusatory. It's inevitable that for every set of changes we make to the test suite, we'd want to update libyaml. Now we can do that without having a steady (whatever rate that implies) of commits like https://github.com/yaml/libyaml/commit/61dd999bfe57a18873358a6b78c7832d5bed3a41#diff-ff771719d73db4188f03896a66c1f045

make test-suite runs now, confirmed by travis-ci.
Some notes...

This adds another level of indirection: worktree add run-test-suite -> clone yaml-test-suite
In the future we want to pin yaml-test-suite releases, so that older libyaml commits can be tested reliably
Now we also have to pin run-test-suite commits to the master branch for the same reason
Having the test list in a branch is one thing, but why also have the .t scripts there?

Alternative:

Keep test lists in master
Pin yaml-test-suite release in master like we planned
Regularly update yaml-test-suite and the test lists in a normal branch
From time to time, when necessary, squash and merge this branch into master

just wanted to note that it was not my plan to "flood" libyaml with commits.

I wasn't being accusatory.

I simply wanted to point out that it wasn't my plan to commit every yaml-test-suite change in libyaml (master).
(I do this regularly for YAML::PP which is in development, because often the new test cases are about the feature I develop.)

As an example, take the invalid escaping of a doublequote \" in single quoted strings.
There had not been a specific test for that. I added a test for it to the test-suite.
Ideally, we would have a skip list, and when fixing such a bug, we remove the test id from the skip list. This serves also as a documentation which exact problem was solved.
So I think, we should also go back to a black list instead of a white list in the future. When pinning yaml-test-suite releases, this shouldn't be a problem anymore.
Thoughts?

This is resolved by #82.
The code for this PR is now in the run-test-suite branch and gets run by one
of:

make -f .makefile test-all
make test-suite
./tests/run-tests.sh (called by .travis.yml)


Clean up advanced method explanation. Fixes #146

Let me know if you want me to make any tweaks on this.


Add layer filesystem changes to exported json

One of the best features of dive is showing which files changed between the layers in the tree view. However this data is currently not exported to json when using the -j flag. To the best of my knowledge, dive is the only tool able to achieve this today.
Inspired by this post, I really wish for tools that will attempt to recreate docker files from the docker image. This is very important for inspecting docker images for on prem environments in terms of security. To achieve this, a user would copy the files of interest outside of the container as a first step: so the exact files need to be identified. This can be achieved today with dive, but only via the tree view. This is manual and inefficient for complex images and has a huge potential for automation and scaling this process to multiple images.
In short, it would be really useful if for each layer in the json, the paths of the modified files, added files and removed files can be exported as well.

YESSSSS to this!

YESSSSS to this!

I would love to see this as well. I'm not sure what other tools might be consuming this right now, but I'd anticipate the sudden addition of the layer filesystem changes could be quite large, depending on the size of the image. I'd be open to the idea of yet another flag to include these extra pieces as well.
My use case is looking at providing a browser-based UI and help folks see how to better their images.

PR https://github.com/wagoodman/dive/pull/458 is for adding this feature to the Dive tool.


NO MRG: Try skipping CircleCI builds

This is a test only PR. Do not merge it.
Try to skip CircleCI builds by adding a .ciignore file that tells CircleCI to ignore changes to all files when building.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Looks like we have a winner. Omitting all branches via regex works.
Note this very important line from the docs regarding how this affects branches. In short, one could re-render to remove this section.

circle.yml is per-branch configuration file, and the branch ignore list in one branch will only affect that branch and no other one

This has already demonstrated the best way forward. So, am closing this one out.


 Darwin 14.3.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "syntaxhighlighter"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code E404

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/opts-parser
npm ERR! 404
npm ERR! 404 'opts-parser' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'syntaxhighlighter'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Ingwie/Work/BIRD3/npm-debug.log

My goal was to use this project through WebPack. It gives modules a NodeJS like environment; commonly referred to RequireJS or CommonJS. That allows me to use most NPM and/or Bower packages.
An alternative to the non-available opts-parser is minimist.

Sorry, 4.0.0-alpha is in very poor state. I'm about to merge #dev branch, it's currently about 95% complete, has fully passing tests and build system. I'm updating the wiki with full instructions now.


Updates to reflect changes in CLI commands

lots of changes around request, remote, connection, DID and terms that seem to have changed with CLI evolution
some typos

Hi, this is a project archive. Active development of Indy is taking place over here: https://github.com/hyperledger?utf8=✓&q=indy&type=&language= thank you


Leave a discussion?

Especially a discussion with multiple recipients, how would a participant leave?
Could they retain a copy of the messages thus far?
And could they be added back in?
Is it better to make this simple (move your feet, lose your seat; aka when you leave it's all gone) or complex to preserve ownership of messages?

Very good question, food for thought.

I'd like to suggest a "leave this discussion" with the following challenges:

user was part of a group, we can't remove the group

I'm wondering whether the Ignore function of the Subs extension already implements this feature to satisfaction.

I might have a solution for this. The recipients table holds information when a recipient was removed (removed_at). If I would prioritise the state of a removed user of his access from a group state, he should not be able to participate anymore. That's the backend side of the solution, the frontend side is way more complex because the interface supports adding recipients, not blocking them.. A solution for that would be to add another autocomplete recipient search based on whether the recipient autocomplete has any groups.
Thoughts?

In case of blacklisting a user (groups doesn't make too much sense). We could create another column on the table called blacklisted_at, a button on the PD that says "Blacklist recipient" and re-use the recipient modal to select a user to blacklist.

Given the scenario that a user leaves a discussion voluntarily, we set a column value left_at.

This will remove the discussion for that user without giving any feedback to the other participants of the PD in case the user was part of any of the groups set as recipient.

In addition to allowing someone to leave a private discussion, how are we going to undo that when that user cannot see the private discussion anymore?

@luceos any progress? Last feature which is needed to make this extension perfect ;)

In my opinion, there are several questions to be answered.
a) Who can add or remove recipients of a private conversation? If it's only the admin it's quite easy, we just need to add a special case for a recipient wanting to leave a private discussion. This right will be given in addition to the right of the admin.
b) If the right to add and remove recipients of a private conversation is given to non-staff usergroups as well, one should be aware, that a breach of confidence might result, if posts older than the time of the change of recipients become accessible to new recipients. This needs to be avoided to protect a forum owner from legal implications. The right to leave such a discussion voluntarily would apply in this case as well.
c) If users are allowed to leave and reenter a private discussion, we may need more than one entry date and / or more than one leave date. The database query to filter out the posts that should be shown to such a user may become quite complex. What should be done with quotes from posts, that are not supposed to be shown to a certain user?
My suggestion: Don't let the list of recipients be altered after the start of a private discussion: The only exception should the case of a user leaving such a discussion voluntarily. Even in this case one should favor a solution, where the given recipient is not removed from the list but instead the discussion can be ignored by any recipient (and the ignoring can be revoked without legal consequences, because the user never really left).
If participants of a private discussion want to expell a certain user, they can simply start a new discussion without the given user.
One last question remains:
d) Who should have the right to close a private discussion? The original poster? Any participant? And who should have the right to reopen a closed discussion?

@pflstr you have questions, I understand. But these are unrelated to this issue, feel free to open a new issue? I'll be deleting your reply once you did. I sadly can't do this for you.
@Cu8eeeR as soon as we get to it. I'm sorry I can't give you any indication yet.


Abi errors RFC

Rendered

I deliberately didn't want to use "derive", but I'm not opposed to renaming the trait to Error and finding a better name for the type annotation.
Maybe #[error_type]?

Looks good and makes sense. Fix the typo and I'm happy to approve :)

Really great work on this.

Great work, this is going to be a huge improvement! Just left a couple of suggestions/questions.


Avoid branch in half2float in gl_compatibility renderer

Fixes: https://github.com/godotengine/godot/issues/73320
This is a regression from https://github.com/godotengine/godot/pull/72914.
For some reason the radeon drivers really don't like the h_e == uint(0x0000) comparison. Replacing it with (h_e >> uint(10)) == uint(0) works though.
Also, when running it through Radeon GPUAnalyzer I noticed that this was actually generating a branch. So I made the code branchless. Logically this code does almost exactly the same thing as the old code (it can now return -0 but couldn't before) but it works on more hardware, so oh well.
CC @JonqsGames you may be interested in this

Looks good ! Should we also avoid branch in float2half ?
uint float2half(uint f) {
	uint e = f & uint(0x7f800000);
	return ((f >> uint(16)) & uint(0x8000)) |
			uint((e > uint(0x38000000))) * (((e - uint(0x38000000)) >> uint(13)) & uint(0x7c00)) |
			((f >> uint(13)) & uint(0x03ff));
}

Looks good ! Should we also avoid branch in float2half ?
uint float2half(uint f) {
	uint e = f & uint(0x7f800000);
	return ((f >> uint(16)) & uint(0x8000)) |
			uint((e > uint(0x38000000))) * (((e - uint(0x38000000)) >> uint(13)) & uint(0x7c00)) |
			((f >> uint(13)) & uint(0x03ff));
}

We could. I wasn't able to detect any issues with that code on the same device. So my preference is to not touch it. I don't want to risk triggering another driver bug

Thanks!


chore: Export create topic page in index.ts

:tada: This PR is included in version 2.11.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


transformer does not work on null fields

fixed the issue. pls merge in my pull-request

Is the issue that the transformer doesn't work if NULL values are provided?

well, yes and no. I use typeorm-encrypted with typeorm and mysql. And when there is null in column, typeorm sends '' (empty string) to the 'to' method. Then encryptor fails.

Hmmm so I just tested null and undefined values out for the transformer. It works as it should. Basically, any null or undefined value in the entity shouldn't be transformed. Empty strings should be transformed/encrypted.
Just to be sure, are you passing null or undefined as the value for that column in the entity?
Otherwise, this could be an issue specifically with the MySQL handler in Typeorm rather than typeorm-encrypted.
I'll follow up with them as well... stay tuned :).

are you passing null or undefined

well, I am passing null, then save the entity with typeorm, then see the entity record in my sql with the NULL, then read the entity with typeorm and typeorm-encrypted gets '' into the to method. Yes probably it is typeorm + mysql issue, that it passes '' when there is actually NULL, but in any case typeorm-encrypted does not work on ''.

Oh, if it's on the read side, then that should be fine.

@andreo-k I added a couple of notes. Basically, on the save side, no changes are needed. On the read side, your change works.

@generalpiston I removed changes from 'save' side, pushed to same branch

Merged. Thanks @andreo-k . I'll create a new release too.

Version 0.5.6 has this patch @andreo-k .


fix: create cli bin alias

Current dependencies on/for this PR:

main

PR #2   👈

This comment was auto-generated by Graphite.


Flang updates for May 2022

Thank you, @AlexisPerry!

Thanks for the fix to the meta tag.  I was not aware of that issue.


fix: update-deps target (#112)

This pull request fixes the update-deps(?) targets and adds additional targets for printing debug information. It is also releasing a new version.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
190

Relevant Lines:
190

💛  - Coveralls


Infinite Scroll

Is it possible to add infinite scroll to the carousel?

Hi Charles @Charuru,
Do you have an example of infinite scroll so I can better understand your expectations? I would also like to know if you're interested in a vanillaJS or React example?
Kindly
David

Hi @davidcetinkaya thanks for replying. Would that be an example of a non-carousel infinite scroll or a carousel in my usecase which currently has limited content / not infinite scroll. If the latter do you mind if I DM you with the link? Thanks.

Hello again Charles @Charuru,
Sorry, I got confused. You're still interested in an infinite scroll solution right 😊?

Yes I am still interested. I was asking what type of example you were looking for.
I don't have an infinite scroll carousel example. But I can show you

Infinite scroll non-carousel
My current embla implementation which has non-infinite scroll, but should help you see why infinite scroll would be useful.

@Charuru I see, thanks for clarifying.
So another thing I would like to know is if you're expecting that the carousel should be able to load slides dynamically while still in motion/scrolling?

I think so? But if that's very hard to do, so long as further slides are loaded and the overall experience doesn't look strange I'm okay with it loading the slides whenever.  Thanks again.

Thank you for the additional information. I'll see if this is achievable with the current state of Embla Carousel and let you know when I've done so.
Cheers
David

Hello Charles (@Charuru),
I've been testing this a bit and came to the conclusion that it isn't possible to load new slides while the carousel still is in motion. The current state of Embla stops any animation as soon as you re-initialize the carousel in order to pick up added slides/removed slides.
Do you want me to treat this issue as a feature request?
Best
David

Yes please, it makes sense as a feature request, thank you.

Thank you Charles (@Charuru),
Seems like more people want to see this implemented (for example @etozhkirill and @khannea mentioned this in issue #103). I'm going to look into implementing this when possible. But in order to do that I need a clear picture of how this is supposed to work.
I think the feature of adding/removing slides should be completely separate from the embla.reInit() method. The intended use of the reInit method is and has since its introduction been a hard reset (meaning that any ongoing animation will stop and the carousel will be initialized from scratch). In addition, the reInit method allows for changing the carousel options, which would make adding slides while animating complex and probably quite messy.
So I'm thinking a method that only checks for slide count changes. Something along these lines:
// This method name is just a draft, feel free to suggest a better name

embla.checkForSlideChanges()

How it should work:

It should be possible to add slides when the carousel is in motion.
What should happen when the user removes slides and the carousel is in motion outside its scroll boundaries?

@khannea, you mentioned the following in issue #103:

If I ReInit() the carousel after slides added, the prevent click if isMove is no more working.

I'm not quite sure what you mean by this. isMove is not an Embla method. Would you mind explaining this further?
Kindly,
David

As far as I am concerned, I have a homepage with many caroussels and each caroussel can have "ilimited" images.
The problem is that caroussels start lagging when there is too many things in it (like 5 caroussels with 300 items).
So what I would love is to load more data only when an user arrive near or at the end of the set of data in the caroussel.
What could fit me, ordered by satifaction, would be:

Loading more data dynamically with no motion stop when I arrive near the end of carrousels (but I understand that it is complicated)

Stop at the end of caroussel with a "loading panel", then when it s loaded user can swipe more (That would be also perfect. The stopping caroussel is not a big issue. But caroussel have to stay where it was, and not start at the beginning)

Have a "Load more" panel at the end of caroussel, and if you click on it, more data is loaded and user can continue to swipe the caroussel.

My usecase is similar to khannea's. 1 and 2 would be acceptable to me, but 3 would not be.
My usecase doesn't involve removing slides. Not reusing reInit makes sense to me.

Thanks for your additional thoughts @Charuru and @khannea.
I'm aiming for an implementation where appending slides dynamically will be possible while the carousel is scrolling/animating. But I also want to handle the case when you remove slides, so if you don't have an idea how this should work, I will have to come up with something. I'm going to look into this further and will give you an update when I have something.
Kindly,
David

@Charuru would you mind sharing a link to an infinite scroll example you think is acceptable? I need this in order to understand the expectations of how new slides should be loaded.
Thanks in advance.

I can't find a good example of infinite scroll carroussel...
I imagine it a bit like this infinite scroll site https://infinite-scroll.com/demo/masonry/ , but with the carroussel.
I hope it help, but I am not sure of that...

Yeah I don't have an example either of carousel + infinite scroll, only have them separately.

Will this infinite scroll work like this example? https://react-slick.neostack.com/docs/example/dynamic-slides where the extra slides can be added either on a button click like on this example or via a event like a network request resolving. I think so long as you can add slides and the scroll position persists it should cover most use cases where dynamically adding slides is required.

Thank you for the example link Romain (@khannea), that helps 👍.
Hello Callum (@callumbooth), and welcome to the conversation. I checked out the react-slick link you shared, thanks! From what I can see, the Slick carousel instantly stops if it's scrolling when changing the slides dynamically, while preserving the current slide index if possible. This is already achievable with Embla Carousel. The way to do it with Embla when the slide count changes (whether its triggered by a button click or network request resolving), you just have to call:
embla.reInit() // re-initializes the carousel

This method will pick up any changes whether you've removed slides or added new slides. However, if I'm not mistaken, this request is about adding a method that allows for a fluid infinite scroll feature. So any slides added should not stop the carousel while scrolling.
Let me know if this explanation helps.
Best,
David

Hi again Callum (@callumbooth),
Did this help your use case?
Thanks in advance,
David

It did but ideally we would like to be able to avoid stopping the carousel if it is in motion which this feature request will hopefully solve.

It did thanks.

@davidcetinkaya is this still being worked upon? If yes, I'd like to help in any way possible. For starters, do you still need an example for carousel infinite scroll where motion doesn't stop when slides are added? If yes, I could rummage through and try to find something.
Last point of discussion in this thread was this https://github.com/davidcetinkaya/embla-carousel/issues/89#issuecomment-692877410. Let me know how I can be of assistance and contribute in any way possible - research, brainstorm, discuss, or implement.
This is a use case for us at Goibibo ( India's leading Online Travel Agency ) as well, where we want to dynamically update ( load ) carousel list items in our react page, and still give the user the freedom to keep scrolling.
I'd like to to help think and implement removal of slides as well.
Really excited for this and I have never contributed to open source or collaborated before 😅
Arihant

Hello Arihant (@arihantverma),
Thank you for your question. I like the spirit and positive energy. Thanks 🙂.
Yes I'm still working on this. I think the example mentioned in this comment will suffice. So no additional examples are needed unless you think I should consider another example that you have in mind?
Although I'm making good progress on this request, I can't give an ETA for it yet. Public feature requests are currently progressing quite slow right now because of my lack of motivation. This is because of the very low visitor count and star count progression lately, as well as lack of this lib being promoted by others than me on social media (like Reddit for example).
I hope you understand.
Best,
David

Hey @davidcetinkaya
Thank you for the clarifications. I think I was not as clear as I wanted in my burst of energy 😅 .
I'd like to help you ship it, work on it with you, if you are open to it and if it's feasible for you.
Let me know what's your preference/want/take on it. It'd be cool both ways :)
Best
Arihant

Hi @davidcetinkaya. Been a while :) so I thought I'd comment again to ask the above 👆🏼

Hello @arihantverma,
No harm in asking! I'm close to finishing my draft for this feature so I don't know if it makes sense if we start collaborating at this stage. But I could setup a CodeSandbox with a temporary solution, if that would help you? Note that the temporary solution won't be as fluid as the feature I'm working on, but maybe it will be good enough until it's finished?
Best,
David

Yes @davidcetinkaya, it'll definitely help, thank you! If you could set up a codesandbox that's be awesome 🎊

Hello Arihant (@arihantverma),
Update: Release 4.1.2 enables me to finish the CodeSandbox example I mentioned here. I have a little left to do but I'm hoping to finish it soon.
Stay tuned.
David

Hello all,
I have an update for React users (@arihantverma, @khannea, @callumbooth). The CodeSandbox demonstrating how to achieve infinite scroll is finished:

Demo
CodeSandbox

I have done some testing on my own but I would appreciate if you guys could take a moment to test it. I hope that it will work as expected for you.
For VanillaJs users: I'm working on a vanilla JS example right now. Stay tuned.
Best,
David

Hi @davidcetinkaya,
I've taken a look and it seems to work well, thank you. I noticed that your using useState for the isPointerDown state but since we don't need to re render the component when this value changes you can probably use useRef instead.

Hello Charles (@Charuru),
Here are the links to the Vanilla implementation of infinite scroll:

Demo
CodeSandbox

Let me know if it helps.
Best,
David

Thanks a lot for testing it Callum (@callumbooth). I'm glad to hear that it's working as intended.

I noticed that your using useState for the isPointerDown state but since we don't need to re render the component when this value changes you can probably use useRef instead.

Maybe I'm not understanding you correctly, but the pointerDown state is intentional. Because I'm delaying the reload of the Embla engine until the user releases the pointer (if the pointer is down when new slides are injected). This is because I don't want to interrupt the user when dragging. And when the pointer is released I want to trigger a state change, that reloads the Embla engine for it to pick up the new slides.
I don't know if my explanation makes sense?
Kindly,
David

Hello again all (@Charuru, @callumbooth, @arihantverma, @khannea, @etozhkirill).
So I've decided to not build this into the Embla core. Instead, I've created CodeSandboxes that demonstrate how to achieve infinite scroll by extending Embla. I've added these examples to the documentation page.
The reason for my decision is that different implementations are needed for VanillaJS or ReactJS. And who knows. Maybe in the future, a VueJS implementation will be added to Embla. Covering all these cases would significantly increase the bundle size and burden users that don't need this feature.
I hope this makes sense. I'm going to give everyone a chance to test this out a little bit and I will close this issue in a couple of days if I don't get more feedback.
Thanks!
David

Great job, thanks!

eeee

Hi @davidcetinkaya ,
I tried adding new slides to the carousel and call embla.reInit() to reset the carousel and be able to scroll to the new slides, but if you try to scroll to the new slide is not posible, here is the reproduction with using the basic example. Do you know if I'm missing something?
Thanks

Hi Cristian (@CristianCucunuba),
Thank you for your question. The issue you're experiencing is because of the asynchronous nature of react useState. React will update the state asynchronously because of performance reasons:
const addSlide = () => {
  setSlides([...slides, 1]); // There's no guarantee that setSlides will finish here
  embla.reInit(); // Before you call embla.reInit() on the next line
};

What you need to do is to create a useEffect that will trigger as soon as the slides prop changes like so:

const addSlide = () => {
setSlides([...slides, 1]);
};
useEffect(() => {
if (embla && embla.slideNodes().length !== slides.length) { // Run this when slide count has changed
embla.reInit(); // Make Embla pick ut the changed slide count
onSelect(); // Update button states
}
}, [
embla,
onSelect,
slides /* add slides prop as a dependency that will trigger this function when it changes */
]);
If you're looking for a fluid infinite scroll example that doesn't reset the carousel you can take a look at the Infinite Scroll example on the documentation page.
Let me know if it helps.
Best,
David

yes that was the error, thank you so much @davidcetinkaya  for the quick help and for the awesome library

I'm glad it helped @CristianCucunuba. Thanks a bunch for supporting Embla ❤!

Hey @davidjerleke, thanks for all your input here.
I am very interested in a infinite scroll solution as well and noticed the slider is flickering when i update the state while the slider is in motion.
The links you posted (React demo and sandbox) both do not work for me. Could you take a look?
I am talking about the links in this comment: https://github.com/davidjerleke/embla-carousel/issues/89#issuecomment-746122982
Again, thanks for your work! :)

@felixmpaulus have you seen this example in the docs?

@felixmpaulus have you seen this example in the docs?

Somehow missed that. Thanks 🙏🏼

Got it to work. Thanks again! 😊


card icon in cardNumber element instead of single line card

Hi,
Is it possible to include the card icon in a cardNumber element instead of have to use single line card element? I am trying to add it and is not possible.
I prefered the way you can customize the payment form in the previous version. This new way has more restrictions :(
I hope your answer. Thank you

Hey there! Thanks for the feedback. Unfortunately, we do not intend to support this use case. You can listen to the 'change' event which contains the card brand in the event payload:
https://stripe.com/docs/stripe-js/reference#element-on
You can use this change event to show your own icons.
Since this repo is just for examples of Elements usage (and bugs in these examples), I'm going to close this issue.
If you're having general trouble with Stripe.js or your Stripe integration, please reach out to us using the form at https://support.stripe.com/email or come chat with us at #stripe on freenode! We're very proud of our level of service, and we're more than happy to help you out with your integration.


GHPRI does not render images in comments on vscode.dev

Extension version:
VSCode Version:
OS:

Sample comment with image in GHPRI

On GitHub:

Can you share a link to the PR you're seeing this with? I'm not able to reproduce it.

Got a link offline.  We only support markdown images, so these images don't render. The next question is: how did these end up as img tags and not markdown images.

I inserted the image via paste (Ctrl+V) after taking a screenshot. I do this with the all GitHub PRs and Issues (including this one) and see that it was also inserted with the  tag.
img appears to be supported in the description which is why I assumed we supported in the comments as well. Example pr with img in the description https://github.com/microsoft/vscode/pull/173128

The PR description page directly uses GitHub's HTML for the comment so it renders fine there. The comment only supports makrdown though, and img isn't included in that support.
I wonder if GitHub changed something here. I've never seen an img inserted before, only the markdown syntax for an image. I'll follow up with them to see what's changed.

Hit the same thing today. Would be great to have this fixed, please 🙄

Fix will go into pre-release next week, but it will only work for public repos.

To verify:

Add a code comment, not just a comment in the PR timeline, to a public PR with an img tag in it, where the img points to a file that was uploaded to github by pasting.
Open that comment in GHPR and verify you can see the img.

Not working, e.g. https://insiders.vscode.dev/github/microsoft/vscode/pull/223104

Looks like this is a COI issue. The fix is still good on desktop.


I can't join the zksync era discord channel

Did you follow the steps outline in the README?

[ ] Yes I did

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This has nothing to do with zkSync!! The only server this thing is affiliated, is the one on the main page of this github.
Jcsumlin can't help you. The people that used his software, didnt congifure it properly. You're wasting your time posting stuff in here.


Useless checks in raw_hash_set_test.cc

Why all these setting and checking the max_load_factor() in raw_hash_set_test.cc, when the set function is a no-op and the get function returns a constant?
    StringTable t;
    t.max_load_factor(.321f);
    const float lf = t.max_load_factor();
    ...
    EXPECT_EQ(lf, u.max_load_factor());

and the implementation is:
  float max_load_factor() const { return 1.0f; }
  void max_load_factor(float) {
    // Does nothing.
  }

This seems like a legacy thing from when load_factor could actually be set. We probably could remove them.


Make autoGameArea configurable

Some devices have weird notch logic like the Samsung Galaxy A50 in this example:

The widths are as follows:
notch: 77px
left blue bar: 133px
right blue bar: 172px
right white bar: 39px
Seems like FGO treats the notch and the white bar as usable area. On my device, FGO does not use the notch area, so the blue bars on the left and right are the same size.
The app will only work for this device if you can set autoGameArea to false.

Actually, it's related to a Samsung-only setting, Full screen apps
Here's a screenshot of FGO with full screen set to auto:

The app may work if you disable fullscreen mode.

AutoGameArea is a pretty weird name.
If we're going to give an option for this to the user, we should think of a better name too.


[Feature] Add a new animated background

Description
I want to add a background that will zoom in and out. It also has a fading effect. It works something like this:
Please assign the issue to me. I want to work on it for GSSOC'24
Screenshots
https://github.com/Rakesh9100/Beautiify/assets/147652780/8cee7a0e-4623-4e51-bfd7-fde8ac8b885b
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

What will be the name of your background @sandy-queen

What will be the name of your background @sandy-queen

I think "Zoom and Fade" should be a suitable name


7.0 rails update

I discovered this amazing gem, but it was not working on the 7+ rails. I found monkey patch in issues and decided to include it in gem, why not? So that's it.

Found out this PR https://github.com/jesseduffield/lazy_migrate/pull/38


Header properties

Hello please what are the propeties for the header option
auth: {
 headers: {
}  }`

```json``