Add retry functionality to SiteApi

After adding a default timeout to the HTTP class in this PR: https://github.com/HaxeFoundation/haxe/pull/8646, we noticed that case number 2 and 3 described in this PR: https://github.com/HaxeFoundation/haxelib/pull/462 was still an issue as when the socket times out, it fails the command instead of triggering a retry. I have added changes to implement a retry and tested this locally and it seems to work fine on our repo's.
I do understand this is a big change to merge in, as every call to the SiteApi class is now going to infinitely try and make a connection. And if the connection never succeeds it could get stuck. If you guys have a different suggestion for this, I will happily reimplement the change - Or perhaps hide this change behind a flag? Either way, I would need some direction as to what you guys think will be cool to get merged in :)
Also - the pipeline seems to be failing with some dirty source error - How do I fix this? I built run.n using the latest nightly build.

Some remarks:

A retry is reasonable, but doing it infinitely is not. Typically you would have a var numTries = 3; and then loop with while (numTries-->0).
With the catch(e:Dynamic) we run the risk of retrying for the wrong reasons. That is, if the called function throws an exception that has nothing to do with connection timeouts, we would keep retrying. @Aurel300 Do you know if we can catch something more specific here?
Having all these WithRetry functions is a bit of an unnecessary abstraction. Consider a pattern like this:

class Main {
	static public function main() {
		retry(failRandomly.bind("myArgument"), 3);
	}

	static function failRandomly(argument:String) {
		trace('Trying failRandomly($argument)');
		if (Math.random() > 0.3) {
			throw "fail";
		}
		return 'result: $argument';
	}

	static function retry<R>(f:() -> R, numTries:Int = 1) {
		while (numTries-->0) {
			try {
				return f();
			} catch(e:Dynamic) {
				trace('Failed because $e');
			}
		}
		throw 'Failed after multiple tries';
	}
}

Also I'm checking with the team what that dirty source is about (cc @andyli).

Thanks :) I have implemented the changes - Will make more changes to fix the CI and to catch something more specific when we get the feedback on those. In the mean time, let me know if there's more changes i should make :)

Please delete run.n from the commit. I'm not sure why you have commits that delete it immediately followed by re-uploading it. I believe that it is what is causing the CI failure.

Ahh sorry - I have deleted it now, do i need to commit the original run.n back? Or does it get automatically created?

So I figured out what dirty source means - The "dirty" string is added to the haxelib version if you build run.n with uncommitted changes 😛 I have commited everything then built my run.n - It should be fine now

Right, I somehow thought this was a git error... CI looks good now.
I still want to check the catch(Dynamic) before I merge.
Also, I suppose a retry function which defaults to 1 try is a bit silly. We can change the default value to 3 and remove the 3 from all the calls to make it look a bit nicer.

Cool I've made the update to change the default retries to 3 and removed the second parameter from the function calls :)

Nice, the diff looks good to me now!
Our CI seems to be having some networking problems at the moment which is somewhat ironic.

Assigning for the catch-question.

I have added better logging as per @RealyUniqueName's request. Could you verify that this new change is acceptable? I also added an if statement to only allow for retries if a HTTP timeout occured. I think that should cover the problem the "catch-question" was trying to solve? Let me know if there's anything else I should change :)

LGTM

Cool - thank you. I've resolved your discussion. Does anyone know why the pipeline seems to be failing?

The build passed after I restarted it. So it was most likely network problem.

Ah thats great :) @Simn is there any other change you would like to add here?

We're good, thanks for looking into this! Let me know if there's anything else we can do to help.
I'm also still interested in why you guys are having these networking problems in the first place and if there's something we can do about that long-term (e.g. different hosting).


sensors: vl53l1: build_all without the default Kconfig

the vl53l1x driver doesn't compile in case the default Kconfig is not used, see action
Specifically, when one of this config is set to n
CONFIG_VL53L1X_INTERRUPT_MODE
CONFIG_VL53L1X_XSHUT

This branch aims to fix it

too bad this didn't make it into 3.4 😬

@nashif pinging you to merge this one :)

Fixes https://github.com/zephyrproject-rtos/zephyr/issues/61281

@avisconti will you please take a look?

@avisconti will you please take a look?

@avisconti @erwango ping

@fouge this needs a rebase

@fabiobaltieri done


Bug: Emit doesn't update 2 way bound props

We may revisit and revert this @nandi95. Based on https://github.com/vuejs/vue-test-utils-next/issues/440#issuecomment-790538633
In that case, you'd need to just change to use a vModel mounting option.


Command '(Internal) Build a Target by Name' resulted in an error - command 'cmake.buildNamedTarget' not found

Brief Issue Summary
Attempt to run "(Internal) Build a Target by Name" command which is available from Command Palette:

...results in an error:

Command '(Internal) Build a Target by Name' resulted in an error
command 'cmake.buildNamedTarget' not found

I understand, that this command is "internal" and is not supposed to be invoked by users, but it is strange that the command is listed in extension's manifest without any implementation under the hood. Looks like implementation was removed, but the manifest and translations were not cleaned up properly.
CMake Tools Diagnostics
{
  "os": "linux",
  "vscodeVersion": "1.86.2",
  "cmtVersion": "1.17.15",
  "configurations": [
    {
      "folder": "/home/dev_user/dev_project",
      "cmakeVersion": "3.27.1",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": true,
      "compilers": {
        "CXX": "/usr/bin/c++"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": null
    }
  ]
}

Debug Log
No response
Additional Information
No response

@i-ky Thank you for posting this issue! This is almost certainly simply an error on our part. I've confirmed that this isn't a regression from our most recent release, so we will plan to get this fixed in our 1.18 release. Thanks!


picker for date/date-time allows invalid entires

Manually editing the dat/date-time field allows entring invalid values.

When passing the dat/date-time as a string, APEX does not validate the values.
Solution: convert the string with the dat/date/time into a date.

No validation for valid dates

Reason:
The functioncall
apex.date.parse('2023-09-ww 00:00, 'YYYY-MM-DD HH24:MI') returns the date 2023-09-01, but
apex.date.parse('2023-09-99 00:00, 'YYYY-MM-DD HH24:MI') returns  Uncaught Error: Date Parsing Error: DD not valid.
With a native DATE-columns the error fpr the invalid date is returned by the Save-Request from the server.

Idea for Workaround: use apex.item.setCustomValidity:
Result: Works only for "simple fields", but date, datetime and do not have this function, input-tag with names like 'P11_DATE_input** have this function, but message is ignored.

Ther is already an open bug in oracle-support
Bug 35141562 : APEX.DATE.PARSE: SOME NOT PARSABLE INPUT STRINGS LEAD TO SUCCESSFUL DATE PARSING

Works fine, when an for picker date/date-time
Format with MON is used, like DD-MON-YYYY.

Fixed with new date/date-time picker of APEX-23.2


Fix issue 14801: OS X installer not compatible with OS X 10.11

In the upcoming OS X 10.11 /usr is not writable. Instead the compiler
is installed in /Library/D/dmd and symlinked to /usr/local.

Thanks a lot Jacob.
It seems that the symlinks make things more complex w/o any benefit, why not use the classical UNIX folders?
If we'd want to use a single dmd folder, I'd prefer /use/local/dmd over /Library/D b/c the library folder contains all the Apple frameworks.

Short answer: the is only a fix for the installer not working on OS X 10.11, this was easiest to do. /Libraries contains other things as well, Ruby and Perl for example.

/Libraries contains other things as well, Ruby and Perl for example.

Aren't those the versions preinstalled by Apple. Let's go on with this though.
OS X Mavericks: What is the Library folder?

Should have targeted the stable branch btw.

Should have targeted the stable branch btw

Ah, sorry. I'm not familiar with how the stable branches are used in the D projects.

Did you actually test this change?
https://issues.dlang.org/show_bug.cgi?id=14801#c12

see #133

Now when you mention it. I never ran the compiler, I only ran the installer and verified that it placed the correct files in the correct locations.


Unable to edit or view signatures

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.
Please confirm the following:

I have upgraded to the latest GAM release from https://git.io/gamreleases and I still have this issue.
I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki

Full steps to reproduce the issue:

When I try to edit a users signature as a test, using the command gam user miked signature file C:\Users\miked\Desktop\miked.html html I get the error ERROR: User<EMAIL_ADDRESS>unauthorized_client: Client is unauthorized to retrieve access tokens using this method.

Expected outcome (what are you trying to do?):
Be able to edit signatures
Actual outcome (what errors or bad behavior do you see instead?):
I get the error ERROR: User<EMAIL_ADDRESS>unauthorized_client: Client is unauthorized to retrieve access tokens using this method.
This seems to happen with all users

What does the following show:
gam user miked check serviceaccount
Ross
On Wed, Jul 11, 2018 at 8:24 AM routeski<EMAIL_ADDRESS>wrote:

The issue tracker is for reporting product deficiencies. "How do I?"
questions should be posted to the discussion forum at
https://groups.google.com/group/google-apps-manager. When in doubt, start
at the discussion forum and return here only when instructed to do so.
Please confirm the following:

I have upgraded to the latest GAM release from
https://git.io/gamreleases and I still have this issue.
I am typing the command as described in the GAM Wiki at
https://github.com/jay0lee/gam/wiki

Full steps to reproduce the issue:

When I try to edit a users signature as a test, using the command gam
user miked signature file C:\Users\miked\Desktop\miked.html html I get
the error ERROR: User<EMAIL_ADDRESS>unauthorized_client: Client is
unauthorized to retrieve access tokens using this method.

Expected outcome (what are you trying to do?):
Be able to edit signatures
Actual outcome (what errors or bad behavior do you see instead?):
I get the error ERROR: User<EMAIL_ADDRESS>unauthorized_client: Client is
unauthorized to retrieve access tokens using this method.
This seems to happen with all users
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/issues/759, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIU8L5ALqP9BDxRJPuC6oPwTRRcX5vfpks5uFhi-gaJpZM4VLWvF
.

--
Ross Scroggs
<EMAIL_ADDRESS>

Hi Ross
Thanks for the response. I get all scopes passed and service account fully authorised


Default styles is wrong.

It's not rendering all points, but when applying other style it shows everything.

this bug is for DI


[Question]: Are there any files building correspondence between the kernels and their dispatching functions?

Feature Request Type
Documentation
Have you searched existing issues?
Yes
Is your feature request related to a problem?
In libspu/mpc/ab_api.cc,  Value a2p(SPUContext* ctx, const Value& x) actually need a kernel named “a2p” to handle the data.
(1) Where is the definition of the kernel named “a2p”?  Are there any files building correspondence between the kernels and their dispatching functions?
(2) What do “a”, “p” mean? Moreover, what do “s”, “v” mean?
I guess from api.h that “p” is public, “s” is secret, and “v” is private. But what is “a”?
Describe features you want to add to SPU
Files building correspondence between the kernels and their dispatching functions.
Describe features you want to add to SPU
Files building correspondence between the kernels and their dispatching functions.

The kernel is dispatched by name. Take ABY3 as an example, its "a2p" kernel is defined here.
"a" means that kernel processes arithmetic shares.

Does "a2p" mean that the arithmetic shares are open?

Yes


catalog: support more methods

Some methods are currently not supported for Table, Variable, etc. For such cases, we need to convert Tables to DataFrames, and then come back to the 'Table' world and ensure no metadata is lost.
List of methods (wip)

[x] VariableGroupBy.rolling
[x] TableGroupBy.rolling

VariableGroupBy.rolling
tb = Table(pd.DataFrame({
    "country": [1, 1, 2, 2, 3, 3],
    "value": [4,5,6,7,8,9]
}))

tb.groupby("country")['value'].rolling(7)

Error: NotImplementedError:
TableGroupBy.rolling
tb = Table(pd.DataFrame({
    "country": [1, 1, 2, 2, 3, 3],
    "value": [4,5,6,7,8,9]
}))

tb.groupby("country")[['value']].rolling(7)

Error: ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (6,) + inhomogeneous part.

I just thought maybe we want to have a function dframe which we could use with context managers:
with dframe(tb) as df:
    df = some_ops(df)

something along those lines, that converts tb into a DataFrame and on exit it should try to (i) convert df back to a Table and bring the 'lost' metadata back.

After talking with Pablo, my understanding is that the current recommended way of doing the 'Table →  DataFrame → Table' hack would be:
df = pd.DataFrame(tb)

df = some_operations(df)

tb = Table(df).copy_metadata(tb)

Operation pd.to_numeric does not propagate metadata, and it's quite useful (see, e.g. this discussion).

We could create a decorator for functions working with dataframes & series that would preserve metadata. Something like this
from typing import Callable, Any

def keep_metadata(func: Callable[..., pd.DataFrame | pd.Series]) -> Callable[..., Table | Variable]:
    def wrapper(*args: Any, **kwargs: Any) -> Table | Variable:
        tb = args[0]
        df = func(*args, **kwargs)
        if isinstance(df, pd.Series):
            return Variable(df, name=tb.name, metadata=tb.metadata)
        elif isinstance(df, pd.DataFrame):
            return Table(df).copy_metadata(tb)
        else:
            raise ValueError(f"Unexpected return type: {type(df)}")
    return wrapper

@keep_metadata
def rolling_mean(df: pd.DataFrame) -> pd.DataFrame:
    return df.rolling(window=1).mean()

# create sample table
df = pd.DataFrame({
    "a": ['1','2','3']
})
tb = Table(df)
tb.a.m.title = 'my variable'

# use pd.to_numeric while preserving metadata
tb.a = keep_metadata(pd.to_numeric)(tb.a)
assert tb.a.m.title == 'my variable'

# apply a function that only works on dataframes
tb = rolling_mean(tb)
assert tb.a.m.title == 'my variable'

All suggestions from above comments were implemented. Should we keep this as a tracking issue?

All suggestions from above comments were implemented. Should we keep this as a tracking issue or close?

Thanks! The likelihood of having such missing methods is going to be smaller and smaller over time, so maybe it's better to close it and open other issues if needed. But I also don't mind having it as a tracking issue, if you prefer.


feat(eslint): loosen eslint peer dependency

What & Why
As opposed to restricting the eslint version to v1.x, we really should be allowing everything above v0.8.0 (which is the version that introduced the plugin API) since that's what's recommended in the documentation. There haven't been any plugin breaking changes throughout eslint so everything should be compatible.
I'd like to update the eslint version that's actually included in the repo (from v1.10.3 to the latest), but there's a slight chicken and the egg problem here because eslint-plugin-lob requires eslint v1.x and depends on eslint-config-lob and eslint-config-lob also requires eslint v1.x and depends on eslint-plugin-lob. So if I try to update the version of eslint in plugin, it'll complain because config isn't compatible, but if I try to update config, it's complain that plugin isn't compatible. So I'll be releasing a new version of this repo with just the peer dependency lifted and then I'll be able to update config to work with the eslint v3.x (which will require changes) which will then allow the dev dependency of plugin to be updated.

So I'll be releasing a new version of this repo with just the peer dependency lifted...

I'm not too familiar with how peer dependencies worked (read this post to brush up) but I think I understand why lifting the peer dependency would break the deadlock between the two plugins. However, I'm not too clear why the peer dependency needs to be redefined first (this PR).

Looking at the documentation it says that this is the recommended version constraint for eslint for a peer dependency. This is mostly because, even though there are breaking changes throughout the major version of eslint, they were only breaking for the configs part of eslint, not the plugin API. Any plugin that was written to work for eslint v1.x should work for v2.x and v3.x as well. Thus, making the peer dep version constraint less strict only allows more versions (doesn't remove any existing version so we can just do a minor version bump for this plugin). There are people who want to use this plugin (#8), but can't because of this (unnecessary) constraint.


Update normal calculation for labels isosurface rendering

References and relevant issues
From discussion on image.sc forum:
https://forum.image.sc/t/napari-labels-layers-borders-displays-with-weird-shading/105499/1
Description
This modifies the 3D isosurface shader for the Labels layer in a few ways. The goal is to improve appearance of the 3D rendered labels. Specifically it should be improved at the boundaries of the volume (for both fast and smooth gradient modes) and for 1px thin labels (for smooth gradient mode).
Changes include:

A new uniform to toggle what happens when sampling outside the volume:

clamping to the edge (default, current behavior)
returning the background value

Update code to prevent dark surfaces in very thin (1px) labels

Add check for adjacent background pixels to the smooth gradient function
Update the gradient calculation to include an estimate of the local gradient instead of setting a default lambert term

The configurable clamping behavior has the effect of giving labels "dark" (almost hollow-looking) or "filled" faces at the borders of the label volume. Currently this is controlled by a property on the Volume visual, but toggling is not exposed in the UI. I think at least @jni is requesting to be able to toggle this in the UI. In the animation below this is what the floating magicgui widget is toggling. I'm happy to wire that up in this PR if there's agreement, but I could use input on a name. We also need to choose a default.

I did a quick benchmark test on my machine and did not see significant performance hit. I will try to do a longer test as well.
Finally, I need to look a bit into what the "background value" is. Right now it's hard-coded in the shader, but it sounds like perhaps the Labels layer may be able to have a non-zero background. I want to make sure to support that or at least not cause a regression.

@aganders3 if the background value is already hardcoded at 0 then I think probably what is happening is that we remap non-zero background values to 0 in the CPU code. So I don't think this would be a regression, and as far as I can tell this would be ready to go!
Do you mind annotating the diff about where the changes in the shader are happening? Since the shader has been broken up/moved it's hard to tell what's different.

I ran the benchmarks for LabelRenderingSuite3D comparing to main and the results look pretty mixed to me, but ultimately not too different. I was using my computer while running these, so I'm not sure how valid the results are.

I was using my computer while running these, so I'm not sure how valid the results are.

Ashley! The first rule of benchmarks club is you don't use your computer while running benchmarks! 😂 I'll try to run them locally and also I'm trying the CI version (Though that can also be pretty mixed.)

I don't have anything intelligent to say on this, but I pulled this down and 3d labels look fantastic with this PR!
I've always wanted them to look like this, but didn't realize it was possible!
Doesn't feel any slower than main using Balls (3D)?


Import an existing certificate failure: Unable to assign an existing policy

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az keyvault certificate import
Errors:
Unable to build a model: Unable to deserialize response data. Data: 2020-04-30T21:43:42+00:00, unix-time, TypeError: an integer is required (got type str), DeserializationError: Unable to deserialize response data. Data: 2020-04-30T21:43:42+00:00, unix-time, TypeError: an integer is required (got type str)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
You should be able to get the policy with the ‘az keyvault certificate show’ command, download the file as you did below, and import it specifying the -p or --policy parameter to the ‘az keyvault certificate import’ command.
CERT_POLICY=$(az keyvault certificate show --vault-name $SOURCE_FIRST_PARTY_KEY_VAULT_NAME  -n azds1sp --query policy)
az keyvault secret download --vault-name $SOURCE_FIRST_PARTY_KEY_VAULT_NAME --file ./azds1SP -n azds1sp  --encoding base64
az keyvault certificate import --vault-name $FIRST_PARTY_KEY_VAULT_NAME --file ./azds1SP -n azds1sp -p “$CERT_POLICY”
But the above does not work. I had to explicity remove the date attributes in the policy that I got in $CERT_POLICY and I saved it as policy.json
I tried to run the below command:
az keyvault certificate import --vault-name $FIRST_PARTY_KEY_VAULT_NAME --file ./azds1SP -n azds1sp -p<EMAIL_ADDRESS>It worked after I had explicitly deleted the date attributes: "created" and "updated"
Expected Behavior
These commands should have worked:
CERT_POLICY=$(az keyvault certificate show --vault-name $SOURCE_FIRST_PARTY_KEY_VAULT_NAME  -n azds1sp --query policy)
az keyvault secret download --vault-name $SOURCE_FIRST_PARTY_KEY_VAULT_NAME --file ./azds1SP -n azds1sp  --encoding base64
az keyvault certificate import --vault-name $FIRST_PARTY_KEY_VAULT_NAME --file ./azds1SP -n azds1sp -p “$CERT_POLICY”
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Installer: DEB

azure-cli 2.5.1

Additional Context

@bim-msft please take a look

@s-tuli Thanks for the report, this is a bug on our side. I will make a patch to fix this.


Document key bits of SimpleSmt

Currently, the key bits are documented as 63-bit
https://github.com/0xPolygonMiden/crypto/blob/398af59045efe16181140475742c7535618a9c75/src/merkle/simple_smt/mod.rs#L9-L13
However, we take u64 as arguments. This difference might create a confusion downstream.
https://github.com/0xPolygonMiden/crypto/blob/398af59045efe16181140475742c7535618a9c75/src/merkle/simple_smt/mod.rs#L153-L154
One option is to, instead, take a Felt as argument. But then, we also need to rework the rpo module documentation that also mentions 64-bit - and it is important we keep consistency between these, as RPO is the backend of SimpleSmt
https://github.com/0xPolygonMiden/crypto/blob/398af59045efe16181140475742c7535618a9c75/src/hash/rpo/mod.rs#L60-L65
Originally posted by @grjte in https://github.com/0xPolygonMiden/crypto/pull/64#discussion_r1109714741

Closing as no longer relevant after #245.


Q2.0.5 Installation issue on linux cluster [SOLVED]

This issue has been solved, but I am posting the solution in case others encounter this during installation.
When installing on a linux HPC following the 2.0.5 release installation instructions, qiime2 and plugins would install, but plugins were not detectable, e.g., qiime info would not list any installed plugins. When qiime2 would cache the deployment, I would get the following exception:
ImportError: /home/nab336/.conda/envs/qiime2-05/lib/python3.5/site-packages/PyQt4/QtCore.so: undefined symbol: _ZN7QLocale14scriptToStringENS_6ScriptE
@thermokarst solved this issue, as a related problem with this issue. After installing matplotlib, set the backend parameter with:
echo "backend: Agg" > ~/.config/matplotlib/matplotlibrc
Now qiime info detects all plugins and, e.g., qiime diversity --help works as expected.
Thanks @thermokarst !

Thanks @nbokulich! This unfortunately is a conda matplotlib package issue. Maybe to "resolve" this issue we can add a troubleshooting / common problems section to the install docs with these sorts of details as they come up?

I like the idea of a troubleshooting section on the install document.
Thanks @nbokulich and @thermokarst!
On Sun, Oct 16, 2016 at 8:03 AM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

Thanks @nbokulich https://github.com/nbokulich! This unfortunately is a
conda matplotlib package issue. Maybe to "resolve" this issue we can add a
troubleshooting / common problems section to the install docs with these
sorts of details as they come up?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/qiime2/qiime2/issues/169#issuecomment-254052067, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AALvdDnai1z1zH3btNIhVdsFpo-no_dgks5q0jyrgaJpZM4KWEbS
.

Closing this. We don't have a troubleshooting section on the docs (but there is an issue). For this specific problem, we do have a relevant topic on the forum.


Fix TestRBACV1Group and TestRBACV2Group

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
The test is broken by https://github.com/istio/istio/pull/15224, not sure why it passed the tests and get merged in the first place. I filed https://github.com/istio/istio/issues/15315 for this issue.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To complete the pull request process, please assign nmittler
You can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lint will be fixed by https://github.com/istio/test-infra/pull/1414

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-lint-master

prow/integ-new-installer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-lint-master
linter fix should be merged

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-lint-master

prow/integ-new-installer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-new-install-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-lint.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-lint-master

prow/integ-new-installer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-new-install-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-new-install-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
I'll check manually to make sure the prow/integ-security-k8s-presubmit-tests.sh pass in this PR

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-new-install-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
5570e9da694622202b7b48ea437c213af9ff0e78
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
fc0ad1659037ef2cf95455c7415e178d3c3616e5
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test istio-lint-master

prow/integ-new-installer-k8s-presubmit-tests.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tests/common/jwt/jwt_token_test.go:58: File is not `gofmt`-ed with `-s` (gofmt)

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test istio-lint-master

prow/integ-new-installer-k8s-presubmit-tests.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

but looks like it does fix security

New changes are detected. LGTM label has been removed.

@howardjohn Yes, I think the test is fixed in this PR.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
a27aa3b72ab98e1ebc20078ed69029820453a51d
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-new-installer-k8s-presubmit-tests.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
9e8b6ec2d7087a73b1f02e0b2c3fc603cc9cc91e
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Events too small to appear with large time scale

Hi,
Transitioning from the email to this issues tab on GitHub, as requested :)
Let's start with a small (pun intended) issue.
When dealing with a large time scale, very short or small events tend to disappear.
As the following example (in the section "Troisième guerre de religion en France", the event "Siège de Poitiers" is hard to see, even with the second level of zooming) :

For now, my only solution is to deal with it manually by setting only the end date of the event, to have it considered as a "point" and not a block. That way I have my line to locate it with the x axis. That's what I did for the Siege of Chartres in the same images, with keeping only the end date for the event and having it as a point, not a block.
But it is not really what I hoped for, as I am losing the precision of having the start date and the end date both embedded.
Proposed solution (if feasible) : under a certain threshold of width when displayed, the block should be dynamically changed to appear as a single date event (maybe using half the duration between the two dates given). If the threshold could be directly manageable in the plugin parameters, that would be awesome.
Not saying that it is easy, but the value would be there for some use cases like mine.
Keep up the good work !

Suggestion: Maybe add an overflow flag at timeline level ?
And of course, implement the overflow flag 😆

I'm not sure if this is related, but I have events that have an obvious gap between them, but as I zoom out, the end up jumping onto separate lines. For my part it seems to do this separating a little to enthusiastically. If the text is going to be truncated within the box anyways, I don't need the items to jump to separate lines to see them, when there would still be a visible space between them.


Is there way to Stream to request instead of saving in directory?

There Please!
Is there a way to steam the created workbook directly to request, instead of saving to the directory first?
var workbook = excelbuilder.createWorkbook(DIRECTORY_PATH, 'file_name.xlsx');
...
 workbook.save(cb)

Answer is much appreciated!

use 0.1.0 by linking directly to github, instead of npm.  use generate function.  im still figuring out how to get the file correctly, but this seems like it should work (it doesn't open correctly though on my Macintosh, still figuring things out):
     res.writeHead(200, {
                     'Content-Type': 'application/octet-stream',
                     'Content-Length': buffer.length,
                     'Content-Disposition': 'attachment; filename=acceptable.zip'
                   });
                   res.write(buffer);
                   res.end();

Thanks for your reply, I've managed it saving first on drive upload to cloud then remove from drive :)
workbook.save(function (err) {
    if (!err) {
      var stream = fs.createReadStream(tempDir + '/' + excelFileName);
      //code to upload to cloud
      fs.unlink(tempDir + '/' + excelFileName);
    }
});

i cannot use the file system because i might host in a PAAS environment.  however, i will try downloading the file using AJAX in browser, then use unzip it using same utility from this app, then use filesaver.js to present the file for saving, since regular html5 download + unzipper generates a folder.


fix: Resolve EC label errors

Add missing labels which should be present in Dockerfile for the integration tests to pass.

Please rebase to see if the latest code builds

/retest


LFS paths not working on downloads

It appears that GitHub pages doesn't support LFS paths. We need to use the absolute path to the raw data.

Fixed in https://github.com/OpenDRR/data/pull/21

Fixed in https://github.com/OpenDRR/data/pull/21


Bump prometheus-adapter and Grafana versions

This brings (at least):
External metrics support (prometheus-adapter)
Elasticsearch as a source for logs (Grafana).
Fixes #267

These files are auto genreated. The Grafana version comes from the kubernetes-grafana dependency (we need to bump there and then update the dependency here), and the prometheus-operator version needs to be set here: https://github.com/coreos/kube-prometheus/blob/3d5fc3e38d8d8fdc6699f113908dd04f6e026c3d/jsonnet/kube-prometheus/prometheus-adapter/prometheus-adapter.libsonnet#L8

@brancz Now CI is failing due to unrelated issue (./manifests/grafana-rawDashboardDefinitions.yaml is missing on repo).

Checks passed, but I don't know if the above commit is revealing a pre-existing problem.

Thanks!


use etcd HTTP JSON RPC to get PD leader

Now Etcd supports HTTP JSON RPC now, we can get PD leader from Etcd directly, not using PD list now.
We can use hyper client.

Fixed.


Default to P-256 in absence of supported_groups extension

As was discussed on the devel mailing list, defaulting to X25519 curve for ECDHE is likely to cause interoperability issues.
both master (928933f92fa214f) and OpenSSL_1_1_0-stable (d257b86caadb) branches exhibit the same problematic behaviour

Please see https://github.com/openssl/openssl/pull/1597

Ping @richsalz. Can this be closed?


Gadgetbridge: move config to settings menu

Not happy about having to leave {"name":"gbridge.app.js"}, under apps.json storage, but otherwise its left behind when updating...

Travis isn't happy about it either :-(
> node bin/sanitycheck.js

ERROR: App gbridge file gbridge.app.js has no contents

I think it's still referenced at {"name":"gbridge.app.js"}, in apps.json? If you take that out it'll be ok?

Ok, just spotted the top comment. I still think it should be removed.
Your https://github.com/espruino/BangleApps/issues/216 should fix it though?

Thanks!


Pcell error for klayout in sky130A pdk

Hi @donn
Several of the klayout pcells for sky130 pdk sourced from $PDK_ROOT/$PDK/libs.tech/klayout/pymacros/cells gives error in klayout during instantiation. This is shown in attached screenshot. Can you please see if these klayout pcells can be updated so that complex layouts with sky130 pdk can be done using KLAYOUT.

What is the exact PDK version you're using?

PDK version captured in screenshot

If the issue persists, can you re-open this issue at https://github.com/rtimothyedwards/open_pdks? Thanks


Refactor dumpRawDoc in IndexUtils

Context: I encountered file quota issue when dumping too many docs.
The new design discards the support for dumping as archival.
Instead, we leverage multi-threading to dump docs to a directory with each thread dump one doc.
Users can then feel free to archive and/or compress by themselves.

This seems like a good use case for io.anserini.util.MapCollections? I've been refactoring that to make more useful... perhaps opportunity to try out?
Processing collections in parallel on multiple threads requires boilerplate... we shouldn't write more than once?

Oh actually, I take it back. You're mapping over the index, not the collection. nm.


default sorting does not work

reference #15 by @markmus

@AllenFang
Here is my code
Variables
    let listOperator = {
      "operators": [
        {
          "creator": "TEST_USER",
          "created": "2015-08-14T05:37:35",
          "modifier": "TEST_USER",
          "name": "dbm",
          "modified": "2015-08-14T05:37:35",
          "links": [
            {
              "method": "GET",
              "rel": "self",
              "href": "http://localhost:8080/api/operators/55da7bd03411511f7a0a6351"
            }
          ]
        },
        {
          "creator": "TEST_USER",
          "created": "2015-08-27T07:21:13",
          "modifier": "TEST_USER",
          "name": "ABCDEFG",
          "modified": "2015-08-27T07:21:13",
          "links": [
            {
              "method": "GET",
              "rel": "self",
              "href": "http://localhost:8080/api/operators/55deba6940faef1b3adf3203"
            }
          ]
        }
      ]
    }

Table
<BootstrapTable data={listOperator.operators} sortName={ 'name' } sortOrder={ 'asc' } striped={ true } bordered={ true } condensed={ true } hover={ true } styles={ tableStyle }>
    <TableHeaderColumn dataField="name" dataAlign="center" isKey={ true }  dataSort={true}> Operator </TableHeaderColumn>
    <TableHeaderColumn dataField="creator" dataAlign="center" dataSort={true}> Group/Owner </TableHeaderColumn>
    <TableHeaderColumn dataField="created" dataFormat={ this.dateFormatter } dataAlign="center" dataSort={true}> Date Added </TableHeaderColumn>
    <TableHeaderColumn dataField="modified" dataFormat={ this.dateFormatter } dataAlign="center" dataSort={true}> Date Modified </TableHeaderColumn>
    <TableHeaderColumn dataField="links.href" dataFormat={ this.actionFormatter } dataAlign="center" dataSort={true}> Actions </TableHeaderColumn>
</BootstrapTable>

I also try sortName='name' sortOrder='asc' and it doesnt work as well.

hello @markmus , you should make default sorting as follow:

var options = {
  sortName: "name",  //default sort column name
  sortOrder: "desc",  //default sort order
};

%lt;BootstrapTable data={products} options={options}>
......
%lt;BootstrapTable>

@AllenFang, nice!
I just have the wrong implementation of it.thanks! :)

@AllenFang
sorting method is not working upon loading. maybe its because of this warning:
Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of TableHeader. It was passed a child from MyConponent. See https://fb.me/react-warning-keys for more information.

but when I click again the headers to sort it works fine.

I'm sorry, would you explain the problem detail(what's loading)? sorry for my poor english ;(

@AllenFang
What I'm doing is i'm fetching the data from the server
  componentDidMount() {
    ActionsOperator.fetchTableData()
  }

then
on render
render() {
    const options = {
      sortName: 'name',
      sortOrder: 'asc',
    }

    return (
        { operators.length !== 0 && (
            <BootstrapTable data={ operators } options={ options } striped={ true } bordered={ true } condensed={ true } hover={ true } styles={ tableStyle }>
              <TableHeaderColumn dataField='name' dataAlign='center' isKey={ true }  dataSort={true}> Operator </TableHeaderColumn>
              <TableHeaderColumn dataField='creator' dataAlign='center' dataSort={true}> Group/Owner </TableHeaderColumn>
              <TableHeaderColumn dataField='created' dataFormat={ this.dateFormatter } dataAlign='center' dataSort={true}> Date Added </TableHeaderColumn>
              <TableHeaderColumn dataField='modified' dataFormat={ this.dateFormatter } dataAlign='center' dataSort={true}> Date Modified </TableHeaderColumn>
              <TableHeaderColumn dataField='id' dataFormat={ this.actionFormatter } dataAlign='center'> Actions </TableHeaderColumn>
            </BootstrapTable>
          )
        }
    )
}

here is sample result

It's seem like a bug for you update the table states after a fetching, so it's a another problem I didn't found. But if you just give data and render table, I think it will be find. Anyway I'll fix it in next version.

hi @AllenFang it works fine now, when i use
'let dataSet = new TableDataSet( datas )`
my bad.
Thank you very much for this very useful library. Keep it up! :)

@AllenFang is there any way how I could update data in tables when the state or props is updated?
I have let dataSet = new TableDataSet( this.props.data )
when props is updated from store I dont know how I could update or call dataSet.setData(this.props.data)
is there any way we could bind the this.props.data without even calling .setData function?

hey, that said, if you data persisted in props and you use TableDataSet to store data and if you want to update data, the only way is .setData. If you dont want use it or your data may persist in state, you can just assign the state's data to BootstrapTable, but it will cause the problem that you encounter before (default sorting). And I've fix this problem and will release it tonight or tomorrow. And again sorry for you suffer these problem, however thanks your feedback :)

I have released newest version for fixing the bug. You can try it without TableDataSet :)


[ui] Replace single redeploy request with update + deploy requests

Blocked on https://github.com/epinio/epinio/issues/2363
The redeploy api request will be removed
We need to replace this with two requests now. update and deploy
Affects two places (need to check for other places)

adding / removing instances using the + / - buttons

any requests here should be debounced such that if the user clicks multiple times we only deploy once they have stopped. Split out to https://github.com/epinio/ui/issues/287

editing application source

before starting we should discuss offering the user the choice on whether they want to deploy the app following the changes.

this could be a checkbox in the edit app source flow somewhere

We don't need the two API calls because in the end I've kept the original behavior adding a flag to skip the restart, so we just need to provide this flag during the push.
See: https://github.com/epinio/epinio/issues/2363#issuecomment-1633928534

@torchiaf unfortunately we don't have the same bot from dashboard running here, so we need to make sure issues that are automatically closed by PRs are reopened and moved to test

@richard-cox could you please give some hints on how to test this?
thanks

@mmartin24 This will fix this issue.
Area that should be covered by tested:

Edit a faulty app .
Scale applications (regressions check).

The last point in the description is actually not covered, possibly we may want to address it in a new issue.

Checked in Epinio Server Version: v1.9.0-26-g21ef05bd with latest Epinio UI.

Checked faulty up can be sourced to a working one.
Checked once sourced to a valid one, it can scaled up and down 3 instances

https://github.com/epinio/ui/assets/37271841/c3825b69-e9df-4a1b-8896-cd6ccba0f764
(Testing note: use make appchart when deploying testing cluster if local)

@mmartin24 This will fix this issue.
Area that should be covered by tested:

Edit a faulty app .
Scale applications (regressions check).

The last point in the description is actually not covered, possibly we may want to address it in a new issue.

Thanks @torchiaf .
Tested accordingly and working.
I think the last point you mentioned regarding application scaling is covered here: https://github.com/epinio/ui/issues/287
Closing issue


docs: Fix trailing slash problem when reloading the API docs Table of Contents page

@adi-wan-askui This may brake in production in an unforeseen way as Github pages is different then localhost.
I tested with a production build on localhost and there I could not find broken links 🤞


Define MSRV

A minimal supported Rust version needs to be defined for this library. It can be established when enough features are added that it can be reasonably evaluated.

When the MSRV is defined, it also needs to be tested in CI. It wasn't included in #1.

Note that MSRV will likely be at least 1.58.0, since that is the MSRV of msd, now a dependency of this library (once #41 is merged).


Support for the experimental syntax 'classProperties' isn't currently enabled

Compare
https://unpkg.com/haunted@4.8.1/lib/create-effect.js?module
import { Hook, hook } from "./hook.js?module";
function createEffect(setEffects) {
  return hook(class extends Hook {
    constructor(id, state, ignored1, ignored2) {
      super(id, state);
      setEffects(state, this);
    }
    update(callback, values) {
      this.callback = callback;
      this.values = values;
    }
    call() {
      if (!this.values || this.hasChanged()) {
        this.run();
      }
      this.lastValues = this.values;
    }
    run() {
      this.teardown();
      this._teardown = this.callback.call(this.state);
    }
    teardown() {
      if (typeof this._teardown === 'function') {
        this._teardown();
      }
    }
    hasChanged() {
      return !this.lastValues || this.values.some((value, i) => this.lastValues[i] !== value);
    }});

}
export { createEffect };

with
https://unpkg.com/haunted@4.8.2/lib/create-effect.js?module
Cannot generate module for<EMAIL_ADDRESS>
SyntaxError: unknown: Support for the experimental syntax 'classProperties' isn't currently enabled (4:17):

  2 | function createEffect(setEffects) {
  3 |     return hook(class extends Hook {
> 4 |         callback;
    |                 ^
  5 |         lastValues;
  6 |         values;
  7 |         _teardown;

Add @babel/plugin-proposal-class-properties (https://git.io/vb4SL) to the 'plugins' section of your Babel config to enable transformation.

undefined

Ostensibly some babelrc work is needed?

I get a similar problem with private class fields:
SyntaxError: unknown: Unexpected character '#'
@bennypowers You can also add to PR:
https://www.npmjs.com/package/@babel/plugin-proposal-private-methods
and here the dependencies for plugin are not specified:
https://github.com/mjackson/unpkg/blob/a7ebffaa4928e95e14dc467979860779bcdcd8a7/package.json#L17

That plugin is included in babel preset-env

That plugin is included in babel preset-env

Here's an example, it doesn't work
https://unpkg.com/@notml/core@0.1.0-pre.7/lib/style.js?module


Unable to install node 18.12.1 with the cypress/factory

I am trying to build image cypress factory image with the following configurations:
14:08:44  Building cypress
14:08:44  Step 1/8 : ARG CHROME_VERSION='107.0.5304.121-1'
14:08:44  Step 2/8 : ARG EDGE_VERSION='100.0.1185.29-1'
14:08:44  Step 3/8 : ARG FIREFOX_VERSION='107.0'
14:08:44  Step 4/8 : ARG CYPRESS_VERSION='9.7.0'
14:08:44  Step 5/8 : ARG NODE_VERSION='18.12.1'
14:08:44  Step 6/8 : FROM cypress/factory.
The following error occurs:
14:09:04  + gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys 61FC681DFB92A079F1685E77973F295594EC4689
14:09:05  gpg: key 973F295594EC4689: new key but contains no user ID - skipped
14:09:05  gpg: Total number processed: 1
14:09:05  gpg:           w/o user IDs: 1
And as a result the following command fails and image could not be build:
14:09:08  + gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc
14:09:08  gpg: Signature made Fri Nov  4 20:12:23 2022 UTC
14:09:08  gpg:                using RSA key 61FC681DFB92A079F1685E77973F295594EC4689
14:09:08  gpg: Can't check signature: No public key
Using gpg locally I could not download the key from keyserver hkps://keys.openpgp.org:
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys 61FC681DFB92A079F1685E77973F295594EC4689
gpg: key 973F295594EC4689: new key but contains no user ID - skipped
gpg: Total number processed: 1
gpg:           w/o user IDs: 1
Buit it is okay to download it from keyservice - hkps://keyserver.ubuntu.com:
gpg --batch --keyserver hkps://keyserver.ubuntu.com --recv-keys 61FC681DFB92A079F1685E77973F295594EC4689
gpg: key 973F295594EC4689: public key "Juan José Arboleda<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1

I'm able to recreate this issue with just the node version set to 18.12.1
ARG NODE_VERSION='18.12.1'

FROM cypress/factory

I'm not seeing an issue with node 18.14.1 which is our default node version. For a work around would it be possible for you to use this newer version of node?
ARG CHROME_VERSION='107.0.5304.121-1'
ARG EDGE_VERSION='100.0.1185.29-1'
ARG FIREFOX_VERSION='107.0'
ARG CYPRESS_VERSION='9.7.0'

FROM cypress/factory

Same thing happening here with node version 16.0.0. My team is not able to upgrade to a newer version of node.

@hollyfoxx i was able to successfully install node 16.0.0 with:
ARG NODE_VERSION='16.0.0'

FROM cypress/factory:latest

@opidhorna-dh-nf
Are you still encountering this issue and / or do you still need Node.js 18.12.1 released Nov 3, 2022?
The Node.js 18.x LTS maintenance version is now v18.20.3 according to Node.js releases.

I can also reproduce this issue, also following the Node.js Verifying binaries documentation. To resolve, the issue would need to be addressed through https://github.com/nodejs/node/issues.
I suggest however not to follow this up because 18.12.1 is an old Node.js 18.x version and the signing process for later 18.x releases seems to be working without issue.

I'm going to close this issue as the problem with Node.js 18.12.1 does not affect currently used versions of Node.js 18.x. The workaround is to use another Node.js version.
Cypress 13.11.0 bundles Node.js 18.17.1 internally and the latest Node.js 18.x version is 18.20.3.


Add Sean's photo

Adding Sean's photo so that he can show that he is a contributor to the tp.

LGTM


Instrument OpenSSL tracing to detect validity of assumptions for new tls tracing method

Summary: Instrument OpenSSL tracing to detect validity of assumptions for new tls tracing method
After discussing #1123 with @oazizi000 and @etep, we decided that invest in stronger validation that the assumptions for that PR and our future tls tracing are valid. Instead of relying on struct offsets of user space data structures, the new tracing method will access a connection's socket fd from the underlying socket syscalls during SSL_write / SSL_read calls.
This technique should only be compatible with "BIO native" OpenSSL use cases, which are the OpenSSL use cases Pixie supports today. BIO native means that a compatible application uses a BIO provided by OpenSSL (via SSL_set_fd) and results in OpenSSL issuing read/write syscalls on your behalf for the underlying socket.
There are two situations we wanted to understand prior to proceeding with #1123: how custom BIO implementations behave (netty, nodejs, etc) and detecting unrelated (non socket) syscalls while SSL_write and SSL_read are on the stack. The former was verified with an experiment based on this change and is described in the Test Plan section below. We believe the latter should not occur, but the changes in this PR instrument this situation in order to detect if doest occur. Assuming this condition isn't encountered, we will proceed with #1132 (with the minor changes learned from this experiment).
Relevant Issues: #692
Type of change: /kind feature
Test Plan: Verified the following:

[x] DCHECK added to socket_trace_connector does not detect mismatched file descriptors for openssl_trace_bpf_test and netty_tls_trace_bpf_test (P345 -- openssl_trace_bpf_test is still disabled - #699)
[x] Verified with a BPF histogram that the number of active syscalls within SSL_write/SSL_read are non zero for BIO native use cases and zero for non BIO native cases (nodejs, netty). See more details in #1160

@pixie-io/maintainers can you review this and also trigger another jenkins build? The most recent build failure is unrelated (my latest commit only changed a comment and previous build passed).

@pixie-io-buildbot test this please

/perf nightly

/perf nightly


Add removal of environment variable logging to release notes

@pioterj I addressed you comments and rebased on release. Can you take another look?


Generating JWT for SignalR Service Rest API

I am trying to create a serverless implementation of a Azure SignalR Service I have been a bit lost about how I should approach it.
The main 'broadcasts' will be from a .NET Framework project that will need to call the SignalR Service from C# code. I will also need to broadcast directly from the clients (JavaScript).
I have created a Azure Function App with a 'negotiate' function which works in terms of getting the clients connected.

To make them able to broadcast messages would I then create a second function?
Same for adding them to a group?

I have read about the SignalR Service REST API, would this be the best way of sending messages from back-end C# code in my web app? From the documentation I am a bit unsure about the best way to consume the API in .NET Framework, is it just a case of sending Http requests or is there a .NET Framework nuget package?
I terms of authenticating with the API, can I use the response of by my Azure Function app negotiation function?

Try the Management package, it is .NETStandard 2.0 and it should work for your .NET Framework project. Here is the details on how to use it : https://github.com/Azure/azure-signalr/blob/dev/docs/management-sdk-guide.md
Make sure to use ASP.NET Core SignalR JavaScript client https://docs.microsoft.com/en-us/aspnet/core/signalr/javascript-client?view=aspnetcore-2.2 because for serverless cases, Azure SignalR only supports the ASP.NET Core SignalR protocol

We don't support REST API for ASP.Net.
For ASP.Net Core:
Different functions for different purposes. Recommend to use Azure Functions Bindings for Azure SignalR Service. Samples can be found here.


updated workflows

Codecov Report

Merging #110 (ad120d4) into main (916b92c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #110   +/-   ##
=====================================
  Coverage   6.74%   6.74%
=====================================
  Files         33      33
  Lines       3615    3615
=====================================
  Hits         244     244
  Misses      3371    3371

Flag
Coverage Δ

tests
6.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


code for hsv_tester

Hello- I am getting an error on line 5 import cv2 and on line 3. I was wondering if there was an update to the code. I amenjoying thebook. Thanks.

Hi there! Glad you're enjoying the book.
I am not currently in a position to easily test the code at the moment - would you mind sharing some information about the error you are seeing? Screenshots and as much details as possible would be great - thanks for bringing this to my attention!

Same problem. I went through the sequence of the library installs, then I see this when I run hsv_tester.py:

%Run hsv_tester.py
Traceback (most recent call last):
File "/home/pi/robot/hsv_tester.py", line 5, in
import cv2
File "/usr/lib/python3/dist-packages/thonny/backend.py", line 305, in _custom_import
module = self._original_import(*args, **kw)
File "/usr/local/lib/python3.7/dist-packages/cv2/init.py", line 3, in
from .cv2 import *
File "/usr/lib/python3/dist-packages/thonny/backend.py", line 305, in _custom_import
module = self._original_import(*args, **kw)
ImportError: /usr/local/lib/python3.7/dist-packages/cv2/cv2.cpython-37m-arm-linux-gnueabihf.so: undefined symbol: __atomic_fetch_add_8

I finally found out how to solve this problem, you have to open the linux terminal and execute the following code :

cd path_to_the_folder_with_the_code
LD_PRELOAD=/usr/lib/arm-linux-gnueabihf/libatomic.sol python3 name_of_the_code.py

Hi Gregoire,
Thanks for the fix with this - I have been snowed under at University and unable to try to resolve this myself. Would you be able to post also where you figured this out from? It would be good if I could do some overall reading so that I can then make an update to be included on the book's retail page, and in this GitHub repo.
My apologies for not being able to also debug. I'm hoping things will have cleared up by the weekend and then should be able to get my Pi and have a go :)

A coworker of mine solve this problem, I think he found it on the opencv's issues page on github. But he just came up with the solution three days after the problem was declared so I don't really know how he found the solution.

Thanks for the fix - I have pinned this so others can find it :))

Thanks for the fix - I have pinned this so others can find it :))

No problem! Thanks again for addressing the issue. Good luck with your studies!
Jonathan D. Taylor
Technology and Engineering Teacher
Central Bucks High School WEST
267-893-2500 xt. 7550
From: Matt Timmons-Brown (Raspberry Pi Guy<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 5:28 PM
To: the-raspberry-pi-guy/raspirobots<EMAIL_ADDRESS>Cc: TAYLOR, JONATHAN<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [the-raspberry-pi-guy/raspirobots] code for hsv_tester (#1)
WARNING: This message originated from OUTSIDE the Central Bucks School District.
Thanks for the fix - I have pinned this so others can find it :))

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthe-raspberry-pi-guy%2Fraspirobots%2Fissues%2F1%23issuecomment-762496834&data=04|01|jtaylor%40cbsd.org|ec2dd84f5ead4f3d9ceb08d8bc006064|aa0b488ffc9e4185a5e3384220df23ca|0|0|637466057096840784|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RcfOOWn4lfLPYzBUVxt3Pff0O%2FGz7LqzT0rWiuk4j78%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJAWR7WUUQX2DK7SJF74BLDS2SYYVANCNFSM4JZQW36Q&data=04|01|jtaylor%40cbsd.org|ec2dd84f5ead4f3d9ceb08d8bc006064|aa0b488ffc9e4185a5e3384220df23ca|0|0|637466057096840784|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sWhvl4%2Bvou%2FdUDnQZa70VBEGgFao12sFRvsDpNRH%2FHA%3D&reserved=0.
CONFIDENTIALITY: This e-mail (including any attachments) may contain confidential information. Unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.

No problem! Thanks again for addressing the issue. Good luck with your studies!
Jonathan D. Taylor
Technology and Engineering Teacher
Central Bucks High School WEST
267-893-2500 xt. 7550
From: Matt Timmons-Brown (Raspberry Pi Guy<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 5:28 PM
To: the-raspberry-pi-guy/raspirobots<EMAIL_ADDRESS>Cc: TAYLOR, JONATHAN<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [the-raspberry-pi-guy/raspirobots] code for hsv_tester (#1)
WARNING: This message originated from OUTSIDE the Central Bucks School District.
Thanks for the fix - I have pinned this so others can find it :))

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthe-raspberry-pi-guy%2Fraspirobots%2Fissues%2F1%23issuecomment-762496834&data=04|01|jtaylor%40cbsd.org|ec2dd84f5ead4f3d9ceb08d8bc006064|aa0b488ffc9e4185a5e3384220df23ca|0|0|637466057096840784|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RcfOOWn4lfLPYzBUVxt3Pff0O%2FGz7LqzT0rWiuk4j78%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJAWR7WUUQX2DK7SJF74BLDS2SYYVANCNFSM4JZQW36Q&data=04|01|jtaylor%40cbsd.org|ec2dd84f5ead4f3d9ceb08d8bc006064|aa0b488ffc9e4185a5e3384220df23ca|0|0|637466057096840784|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sWhvl4%2Bvou%2FdUDnQZa70VBEGgFao12sFRvsDpNRH%2FHA%3D&reserved=0.
CONFIDENTIALITY: This e-mail (including any attachments) may contain confidential information. Unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.


Update readme

Pull Request Test Coverage Report for Build 14

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.013%

Totals

Change from base Build 11:
0.0%

Covered Lines:
134

Relevant Lines:
137

💛  - Coveralls


Feature adui 4849 up down arrow key change value numericinput

Proposed Changes
I have added the up and down arrow to increment or decrement NumericInput

Potential Breaking Changes

Acceptance Criteria

[x] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[x] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1309 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   99.44%   99.44%   +<.01%
==========================================
  Files         362      362
  Lines        9081     9087       +6
  Branches     2145     2146       +1
==========================================
+ Hits         9031     9037       +6
  Misses         50       50

Impacted Files
Coverage Δ

.../components/numericInput/NumericInputConnected.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c434fcf...ff7dbee. Read the comment docs.


Info: Everything we do on 1.0.6 to minimise 503s

I've had several chats with people recently so I'm putting there here to capture everything we do on 1.0.6 to deal with 503's, and then people can tell me what shouldn't be required as of 1.1.x.
The combination of all these things we see little 503's in the mesh, and basically none at the edge.
On the VirtualService for every service, we configure the envoy retry headers:
spec:
  http:
  - appendHeaders:
      x-envoy-max-retries: "10"
      x-envoy-retry-on: gateway-error,connect-failure,refused-stream

On the DestinationRule for high QPS (3k/sec over 6 pods) applications, we configure outlier detection, this would result in 400-500errors to 2-5, during a pod restart.
spec:
  trafficPolicy
    outlierDetection:
      maxEjectionPercent: 50
      baseEjectionTime: 30s
      consecutiveErrors: 5
      interval: 30s

On the pods, we configure the application container to have a preStop sleep, which gives time for the unready state of the pod (during termination) to populate to other envoys and the traffic to drain:
    lifecycle:
      preStop:
        exec:
          command:
          - sleep
          - "10"

On envoy, we have a custom pre-stop hook that waits for the primary application to stop listening:
#!/bin/bash
set -e
if ! pidof envoy &>/dev/null; then
  exit 0
fi

if ! pidof pilot-agent &>/dev/null; then
  exit 0
fi

while [ $(netstat -plunt | grep tcp | grep -v envoy | wc -l | xargs) -ne 0 ]; do
  sleep 3;
done
exit 0

In the istio config we do policyCheckFailOpen: true

How do you add the pre-stop hook to Envoy? Can it be done in the injection webhook config?

Yeah I build a custom image for the sidecar with the pre stop script in it,
and then I modify the injector template to have the preStop hook
On Sat, 2 Mar 2019, 9:33 am Stefan Prodan<EMAIL_ADDRESS>wrote:

How do you add the pre-stop hook to Envoy? Can it be done in the injection
webhook config?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/12183#issuecomment-468904212, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABaviUvUVH-ftcl7NVVH669VkrKJJ4A4ks5vSkVogaJpZM4bZdzt
.

Hello @Stono thanks for the info. We are afraid of adding the retry policy in all services because of the worries if the apps will handle duplicate transactions in case of envoy sending the request again for whatever reason he wants to.
However, in istio 1.0.5 we are not seeing 503' anymore as we were seeing on versions <= 1.0.2 we only have 503/404 errors when pilot starts to have problems.
Now for clarifications, what does the outlierDetection part means? It will affect envoy circuit break definitions?

Hey the retry I use is only for gateway unavailable etc, a real transaction
should not get through (which is why I specify the criteria explicitly).
The outlier detection is envoys circuit breaker.  We found when a pod was
going down, upstream envoys would still try and send traffic to it until
they got updated mesh config, the circuit breaker for us quickly excluded
those terminating pods (rather than loads of 503s).  This was particularly
useful on very high qps pods.
Karl
On Sat, 2 Mar 2019, 10:58 am Stocco<EMAIL_ADDRESS>wrote:

Hello @Stono https://github.com/Stono thanks for the info. We are
afraid of adding the retry policy in all services because of the worries if
the apps will handle duplicate transactions in case of envoy sending the
request again for whatever reason he wants to.
However, in istio 1.0.5 we are not seeing 503' anymore as we were seeing
on versions <= 1.0.2 we only have 503/404 errors when pilot starts to have
problems.
Now for clarifications, what does the outlierDetection part means? It will
affect envoy circuit break definitions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/12183#issuecomment-468910061, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABavie8IdZ6kL1znMBNRB_0GYobHf-Bjks5vSllGgaJpZM4bZdzt
.

@Stono Hey! Thanks for sharing this. Really helped me shape the general direction I should go.

On the VirtualService for every service, we configure the envoy retry headers:

Sounds great. If I add one thing, we should ensure that only idempotent requests are retried.
Instead of:
spec:
  http:
  - appendHeaders:
      x-envoy-max-retries: "10"
      x-envoy-retry-on: gateway-error,connect-failure,refused-stream

We should probably do:
spec:
  http:
  - match:
    - method:
        exact: get
    appendHeaders:
      x-envoy-max-retries: "10"
      x-envoy-retry-on: gateway-error,connect-failure,refused-stream
    route:
    - destination:
        host: ratings.prod.svc.cluster.local
  - route:
    - destination:
        host: ratings.prod.svc.cluster.local

Sry if you've already done this/and my suggestion didn't work in any way. I just couldn't help leaving a note :)

@mumoshu I actually think for gateway-error,connect-failure,refused-stream you're safe to retry POST, PUT etc too, as those errors mean the request never made it to the target application anyhoo.
It's all a bit moot in 1.1.0 anyway as this retry stuff happens transparently!

Also, I agree that the prestop sleep is a must-have, and it isn't actually Istio or workload specific as far as I can say. I even hope we can extend the Istio's Sidecar resource it accept prestop sleep length.
Envoy, hence Istio, is eventually consistent. To make our Envoys/Istio sidecars and ingress gateways NOT to accidentally send traffic to "just-stopped" endpoints, we need a special care.
The "special care" here seems to be a "grace period", to prevent the envoy sidecar and the app container from exiting, after your pod receives SIGTERM, until other envoys stops sending traffic to it.
Probably the only way to implement this "grace period" today is to build your own sidecar image and add the prestop sleep?
Then I think Sidecar resource should better enhanced to accept the sleep length for ease of use. Just my two cents.

@Stono Thanks for clarifying. Maybe you're correct!
But my impression was that, if gateway-error stands for 502, you still have a chance to receive it after envoy transferred your POST request to the upstream, the upstream processed it and prepared a response, but then the connection between the envoy and the upstream failed. We won't like envoy to retry the POST request in this case, though?
I hope I'm thinking too much and this doesn't happen in reality :)

@mumoshu Hello. I've sent a PR to add the preStop to gateway deployment.

@iandyh Hey! Just took a quick look at your PR #12342 - I think we need to consider two cases,
The one is sidecar -> gateway, and the another is gateway -> sidecar, sidecar -> sidecar.
Your workaround of adding sleep 30 to the gateway should work, only in a way that all the other sidecars who wants to talk to the gateway has a grace period of 30 seconds until it stops traffic to the gateway.
That is, we may also need to add sidecars prestop sleeps, for gateway -> sidecar and sidecar -> sidecar cases.

@mumoshu sidecar actually does not talk to gateway since gateway only route the traffic into the cluster.
We are actually going to add the preStop hook to all the deployments in our cluster because regardless using istio or not, there is a chance of request drop during rolling update of these deployments.

@iandyh Thanks for confirming! Probably you're talking about the sidecar -> gateway case, right? I believe you're correct on that then 👍
I'd rephrase my idea to this: for cases like gateway -> sidecar and sidecar -> sidecar, we need prestop sleeps.

We are actually going to add the preStop hook to all the deployments in our cluster because regardless using istio or not, there is a chance of request drop during rolling update of these deployments.

@iandyh I haven't encountered it yet myself but to confirm - you're talking about the case when kubeproxy + iptables + Service Endpoints not catching up pod terminations fast enough?

We are actually going to add the preStop hook to all the deployments in our cluster because regardless using istio or not, there is a chance of request drop during rolling update of these deployments.

@iandyh I haven't encountered it yet myself but to confirm - you're talking about the case when kubeproxy + iptables + Service Endpoints not catching up pod terminations fast enough?

The issue we are discussing actually is entirely different from the main thread. You can read the details here: https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/

@iandyh Thanks! I agree on you about what you're considering is described in https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/.
Can you agree on, not only your app containers, but also istio-pilot/sidecar containers need prestop sleep? 😃
My understanding is that (1)all the containers in a pod, hence your app and the sidecar, receive SIGTERM concurrently (2)envoy(without prestop sleep) stopping before the app container(with proper prestop sleep) still results in intermittent errors in the following architecture in my mind:
your app pod A ---> sidecar for A ---> sidecar for B ---> your app pod B

@mumoshu yes, the only correct way of doing this is Envoy(sidecar) still receives traffic even it's being killed by the cluster(at the same time, no more new requests being send to this Envoy), drain some time, can be a perfect drain, can be a timed drain(what Lyft is doing). After draining, SIGKILL .
According to this PR: https://github.com/istio/istio/pull/11630/, Envoy will still reject the new connections, which means we still need a preStop hook.

@iandyh Fully understood.
If you don't mind paraphrasing - Yes, I agree that even after #11630 our sidecar need a preStop sleep, so that it won't reject new reqs arrived after SIGTERM but before other envoys actually stop sending.
Thanks for sharing your insight ☺

For those following this thread, we've removed pretty much everything we've done apart from the lifecycle preStop (so no headers or outlier detection now), implemented Sidecar to massively limit the scope of pushes (our push durations have dropped from 30s to 2s) and in 1.1.1 and we're not seeing any 503s.

Gonna close this with the summary of "Update to 1.1.1".

@Stono can I ask for a bit of clarification?  Sorry if this clear to everyone else but there are enough moving parts that I'd like to make sure I get this right.  When you say you did lifecycle preStop does that mean that you added the preStop to all of your app containers?  Or does that go somewhere else?

@Stono Thanks for this!

Yeah I build a custom image for the sidecar with the pre stop script in it, and then I modify the injector template to have the preStop hook
…
On Sat, 2 Mar 2019, 9:33 am Stefan Prodan, @.***> wrote: How do you add the pre-stop hook to Envoy? Can it be done in the injection webhook config? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12183 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaviUvUVH-ftcl7NVVH669VkrKJJ4A4ks5vSkVogaJpZM4bZdzt .

Hi @Stono , thanks for this writeup!
We have installed using the IstioOperator - how do you manage the changes to the istio-sidecar-injector config?

If anyone is still reading this and wondering how to create a preStop hook without building their own images, this is how you do it if you are installing Istio with istioctl:
istioctl upgrade \
   --set 'meshConfig.defaultConfig.holdApplicationUntilProxyStarts=true' \
   --set 'values.global.proxy.lifecycle.postStart.exec.command[0]=pilot-agent' \
   --set 'values.global.proxy.lifecycle.postStart.exec.command[1]=wait' \
   --set 'values.global.proxy.lifecycle.preStop.exec.command[0]=sleep' \
   --set 'values.global.proxy.lifecycle.preStop.exec.command[1]=10s' \
   --verify

The pilot-agent wait postStart hook has to be there explicitly, because once you create a hook yourself the holdApplicationUntilProxyStarts=true option gets overwritten by your new hooks. So basically the holdApplicationUntilProxyStarts=true option does nothing in my command, I just leave it there for reference.

https://github.com/istio/istio/issues/34855#issuecomment-975280088 in 1.12 might be of interest to you as well.

#34855 (comment) in 1.12 might be of interest to you as well.

Yup, we're also using this one with istioctl:
--set 'meshConfig.defaultConfig.terminationDrainDuration=30s'

but that option you referenced might change that, thanks.


Polymer binding to input range is not updated when using the keyboard

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Bind an <input type="range"... to an observable field.
Use the keyboard to move the slider

What is the expected output? What do you see instead?
If the arrow keys or page up/down are used to move the slider then the bound field is not updated and yet a function bound to on-change will still fire.
What version of the product are you using? On what operating system?
Dart SDK version 1.1.1
Polymer 0.9.4
Linux (Kubuntu 13.10)
Please provide any additional information below.

This issue has been moved to dart-lang/polymer-dart#113.


[PORT] Set up key vault for slack functional tests secrets

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3478

BotBuilder-Dotnet-Slack-Functional-Tests-yaml

functional tests


Textarea missed :)

I've installed doxter but there is no textarea there. Any Ideas?

Maybe incompatible with the newest Craft Version.

Might have to download the repo instead of the official release until I cut a new one.
See https://github.com/selvinortiz/craft.doxter/issues/23

@davidhellmann Just cut a new official release to address this without cloning the trunk: https://github.com/selvinortiz/craft.doxter/releases/tag/v1.2.0


Error: memory_efficient_attention() got an unexpected keyword argument 'scale' with textToImage method

I am using last version "@huggingface/inference": "^2.3.0"
This code snippet (default in docs) works:
const imgBlob = await hf.textToImage({
  inputs: 'award winning high resolution photo of a giant tortoise/((ladybird)) hybrid, [trending on artstation]',
  model: 'stabilityai/stable-diffusion-2',
  parameters: {
    negative_prompt: 'blurry',
  }
})

But this other fails:
const imgBlob = await hf.textToImage({
    inputs:
      'award winning high resolution photo of a tortoise/((ladybird)) hybrid, [trending on artstation]',
    model: 'stabilityai/stable-diffusion-2',
    parameters: {
      negative_prompt: 'blurry',
    },
  });

The only difference is that I removed giant word.
I am receiving this error:
Error: memory_efficient_attention() got an unexpected keyword argument 'scale'

How can I fix it?
Thank you!

hi @tomi-mercado , sorry this error was introduced earlier today with a diffusers upgrade, it will be fixed as soon as this PR is merged

@radames Amazing! Thanks for fast answer 👍

actually idk why prompthero/openjourney-v4 is only working even with this issue

hi @Borismartirosyan it's back to normal for a while, which model are you referring?

hi @Borismartirosyan I'm sorry this is not related to this repo or original issue


refactor: change the proof.proto path to third_party/proto/confio

Description

This PR has following changes.

change the proof.proto path to third_party/proto/confio

closes: #767
Motivation and context
#767
How has this been tested?

Screenshots (if appropriate):
Checklist:

[x] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It seems like this PR is good because fixed path is the same path of cosmos-sdk. https://github.com/Finschia/finschia-sdk/pull/651 is irrelevant as it is for ibc-go.


Document how to set the "Max Message Length" of a message (default set at 2048)

Please could you include this in your documentation if possible.
I tried to set it as follows - but it still seems to be truncating still
 <appender name="RollingFileAppender" type="log4net.Appender.RollingFileAppender">
      <file value="logs"xxxxlogs />
      <appendToFile value="true" />
      <rollingStyle value="Date" />
      <staticLogFileName value="false" />
      <maxSizeRollBackups value="10" />
      <maximumFileSize value="1GB" />
      <layout type="syslog4net.Layout.SyslogLayout, syslog4net">
        <structuredDataPrefix value="xxxx" />
        <maxMessageLength value="10000"/>
      </layout>
    </appender>

Thanks

The Max Message Length is hard-coded in the SyslogLayout to 2048 and it appears to be by design.
https://github.com/merchantwarehouse/syslog4net/blob/master/src/main/dot-net/syslog4net/Layout/SyslogLayout.cs#L20
For testing purposes only I suggest you use another Layout. Something like this would not trim the message:
<layout type="log4net.Layout.PatternLayout">
   <conversionPattern value="%date [%thread] %-5level %logger [%property{NDC}] - %message%newline" />
</layout>

Hi if you check this commit https://github.com/merchantwarehouse/syslog4net/commit/01f7065687a9e355a9a5c00dddcc5d8e1ebb9ec1
it seems this was made configurable - so therefore I assume can be amended. Can this be confirmed. Thanks

You are right, it looks like the Layout class is overriding the hard-coded value.
Although the latest release version 1.0.9 seems to be older than the commit
https://github.com/merchantwarehouse/syslog4net/releases
If you compiled syslog4net locally then try this instead:
<layout type="syslog4net.Layout.SyslogLayout, syslog4net">
  <structuredDataPrefix value="MW@55555"/>
  <param name="MaxMessageLength" value="10000" />
</layout>

Thanks - appreciate it.  I would prefer a new release created if possible (as use nuget to manage all my dependencies) with this enhancement included but if the author is no longer maintaining this project - will pull a copy down locally as there are some modifications I would like to make anyway to code base - I will see what happens over the next week. Thanks again.

Code is merged. New release is being worked on.


fmod(): toFixed() digits argument must be between 0 and 100

fmod(10, 1) causes the error:
Uncaught RangeError: toFixed() digits argument must be between 0 and 100
Possible solution:
else {
     return parseFloat(tmp2.toFixed(Math.abs(p))); // instead of (toFixed(-p))
}

Sorry for the late response, but this is fixed now in the referenced commit 🙌


Issue in an external link

There is a problem for the link in the "File Structure" section. Can you fix it? Thank you ^^
Another thing, is it possible to be in contact with a Q# developer? Because I need help to do something in relation with Q# in Visual Studio. Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 481eac22-8023-4ff2-d349-a3f42597d3bc
Version Independent ID: 564ca910-6a5a-9885-1fba-0f9a9c250382
Content: The Q# Programming Language
Content Source: articles/language/index.md
Product: quantum
GitHub Login: @QuantumWriter
Microsoft Alias<EMAIL_ADDRESS>

Thanks for filing the bug, @Nathire! If you have a question about Q# and using the Quantum Development Kit more generally, we recommend that the q# tag on https://stackoverflow.com/questions/tagged/q%23 and the [https://quantumcomputing.stackexchange.com/questions/tagged/q%23](Quantum Computing StackExchange) communities, or the qsharp.community site. We're also happy to help with bugs and suggestions filed on any of our various open source repositories. Please let us know if there's something we can do to help, thanks for your interest in quantum development 💕!


Optionally suppress submodules and activate in Xcode builds

Problem
Xcode build environments vary, some don't need to update submodules or run activate, but xcode_build_connector.sh runs these commands unconditionally

Summary of Changes
Added code to conditionally skip these steps for environments where they're unnecessary

@jelderton @hawk248 @bzbarsky-apple ?


How would one go about running embedding as a service using something like vLLM?

I would like to run embedding as a service using something like vLLM on a Docker container on different host. How would one go about doing this?

I think it should be easy to serve GritLM using vLLM or similar and providing access to its embedding capability / its language modeling capability or both in one single model / endpoint. But I'm not sure about the details of vllm etc.

would we just need to get the last hidden states for the embed token and return it from vllm at inference time?

the last hidden state for the entire seq to be embedded & then mean pool it

vllm seems to support encode method(which we need for embedding model) after vllm 0.4.3. But I am running into some issues. When I run gritlm on unified mode, vllm doesnt seem to consider gritlm an embedding model and doesnt allow it to call encode() func(according to this issue https://github.com/vllm-project/vllm/issues/6015), and I get the error
  File "/miniconda/envs/dg_venv/lib/python3.10/site-packages/vllm/model_executor/sampling_metadata.py", line 116, in prepare     ) = _prepare_seq_groups(seq_group_metadata_list, seq_lens, query_lens,   File "/miniconda/envs/dg_venv/lib/python3.10/site-packages/vllm/model_executor/sampling_metadata.py", line 208, in _prepare_seq_groups     if sampling_params.seed is not None: AttributeError: 'NoneType' object has no attribute 'seed'
anyone has the same problem / is working on embedding model with vllm?

I would like to run embedding as a service using something like vLLM on a Docker container on different host. How would one go about doing this?

have you solved the problem


[RESOLVED] S100-Primario has been restarted (uptime < 10m)

Problem started at 07:48:29 on 2023.06.20
Problem name: S100-Primario has been restarted (uptime < 10m)
Host: S100-Primario
Severity: Warning
Operational data: 00:06:28
Original problem ID: 28942
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23452&eventid=28942

Problem has been resolved in 4m 0s at 07:52:29 on 2023.06.20
Problem name: S100-Primario has been restarted (uptime < 10m)
Host: S100-Primario
Severity: Warning
Original problem ID: 28942


Request: add DOI to cite this package

I want to cite this package in my article.
As well as TensorOperations.jl, DOI with ZENODO is helpful.

I have used OptimKit.jl in the research for my doctoral thesis. I have not yet published this part as a research article. I will let you know when I post the article to arXiv!

Hello, I also want to cite your package. Could you please suggest how I should do it? Thanks.

For now I would recommend just linking to the github URL. I can ask for a Zenedo DOI, but do not feel very comfortable given that this package is not very mature yet (in comparison to e.g. my own TensorOperations.jl).


(bug) DontDestroyOnload object is destroy when use folders

Hi,
When i'm using Hierarchy Folder for DontDestroyOnload object. It is still destroy my object when load new scene.
I think it is a bug?
Unity have warning when use folder for DontDestroyOnLoad too:
DontDestroyOnLoad only works for root GameObjects or components on root GameObjects.

Was this fixed?


The meaing of the terminology DSL used in README.md.

In this project's README.md, the terminology DSL has been used twice:
Cask installs packages using the package.el protocol, based on a Cask file written in the Cask DSL. straight.el eschews package.el entirely, and clones packages from source based on how you invoke straight-use-package in your init-file.
[...]
In spite of this, the :files directive supports an almost comically powerful DSL (with nested excludes and everything!) that allows you full flexibility on how the links are made; see the docstring of straight-expand-files-directive for the full details.

But I'm still very confused on the exact meaning of the terminology DSL in this context.
Any hints will be highly appreciated.
Regards,
HY

Domain-specific language.