armTrustedFirmwareTools: 2.4 -> 2.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/arm-trusted-firmware/versions.
meta.description for armTrustedFirmwareTools is: "A reference implementation of secure world software for ARMv8-A"
meta.homepage for armTrustedFirmwareTools is: "https://github.com/ARM-software/arm-trusted-firmware"
meta.changelog for armTrustedFirmwareTools is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5/bin/fiptool passed the binary check.

/nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5/bin/cert_create passed the binary check.

/nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5/bin/sptool passed the binary check.

3 of 3 passed binary check by having a zero exit code.

3 of 3 passed binary check by having the new version present in output.

found 2.5 with grep in /nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5

found 2.5 in filename of file in /nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5

directory tree listing: https://gist.github.com/383d69108acc26d9e5a00a7cd75ee052

du listing: https://gist.github.com/0e2b26c964e77e2501f12bfd7e2b8c50

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

19 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
18 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
armTrustedFirmwareAllwinner
armTrustedFirmwareQemu
armTrustedFirmwareRK3328
armTrustedFirmwareRK3399
armTrustedFirmwareS905
armTrustedFirmwareTools
ubootBananaPim64
ubootNanoPCT4
ubootOdroidC2
ubootOrangePiZeroPlus2H5
ubootPine64
ubootPine64LTS
ubootPinebook
ubootPinebookPro
ubootROCPCRK3399
ubootRock64
ubootRockPi4
ubootRockPro64
ubootSopine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A armTrustedFirmwareTools https://github.com/r-ryantm/nixpkgs/archive/8ac72be1ab74ae4e710d71c2bed691c7f8ab0769.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5
ls -la /nix/store/n0iwv2rn30ji139fxr4ls3xqr3jyw18m-arm-trusted-firmware-2.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

armTrustedFirmwareTools

Maintainer pings
cc @lopsided98 for testing.

Result of nixpkgs-review pr 123996 at 8ac72be1 run on x86_64-linux 1

1 package built successfully:

armTrustedFirmwareTools

2 suggestions:

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/misc/arm-trusted-firmware/default.nix:13:5:
   |
13 |     name = "arm-trusted-firmware${lib.optionalString (platform != null) "-${platform}"}-${version}";
   |     ^

Near pkgs/misc/arm-trusted-firmware/default.nix:14:12:
   |
14 |     inherit version;
   |            ^

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/misc/arm-trusted-firmware/default.nix:1:33:
  |
1 | { lib, stdenv, fetchFromGitHub, fetchpatch, openssl, pkgsCross, buildPackages }:
  |                                 ^


How could I print canvas?

Hello, thank you for this plugin
Maybe this is a dumb question, but I wanna print some chart that is inside a canvas and has a ID.
However, I'm getting a blank page if I use: var obj = document.getElementById('myChart');
Is it possible to do that or should I look for another solution?
Thanks a lot.

Would you be better off converting the canvas to an image and printing the image instead?

Oh, ok. I'll look for how to do it.
Thanks.

Do you recommend any plugin to do that? I found this one: org.devgeeks.Canvas2ImagePlugin, but it is not supported anymore
Thanks a lot.

Ok! It worked!
`    $scope.print = function(cnvs) {
    var canvas = document.getElementById(cnvs),
    ctx = canvas.getContext('2d');

    var image = canvas.toDataURL("image/png");
    var imgCode = '';

    var doc = "TEST";
    doc = doc + "'" + imgCode + "'";
    doc = doc + "";

    console.log(doc);

    if($cordovaPrinter.isAvailable()) {
        $cordovaPrinter.print(doc);
    } else {
        alert("Printing is not available on device");
    }
}`

Cheers!


[PoC] Offer unsafe push/pop APIs for task-locals, for easier macro use

We could offer these APIs, which would make it possible to write a "traced" macro like this:
@SpanPreamble
func hello() {
  print("Hello")
}

->
@SpanPreamble
func hello() {
  // let span = Tracing.startSpan(...)
  // ServiceContext.$current.unsafePushValue(span.context)
  // defer { ServiceContext.$current.unsafePopValue() }
  print("Hello")
}```

@swift-ci please smoke test

@swift-ci please smoke test

We may need to make these calls builtins before this can be safely introduced.
rdar://108266857

Note: Hopefully won't be needed if we get proper "wrapper" macros.

Closing it for now, we can revive when necessary


Value for custom date field isn't migrating correctly in AzDO

While trying to migrate a custom date field from jira to custom date/time field in AzDO, values aren't migrating correctly.
In the export JSON, the value for this date field is as below:

However, when this field is migrated , the date and time value gets imported as below:

The time zone settings in Azure organization and in Profile settings are same as in JIRA server. Values for standard date fields are migrated correctly on the UI. The difference is observed only for custom fields.
Kindly help.

What does the mapping look like in the config file? And what is the type of the Custom.InQADate field?

Mapping done in config file is as below:
{
"source": "customfield_12010",
"target": "Custom.InQADate"
},
The API call gives below values
{
"expand":"renderedFields,names,schema,operations,editmeta,changelog,versionedRepresentations",
"id":"317717",
"self":"https:///rest/api/latest/issue/317717",
"key":"NWNA-13651",
"fields":{
"customfield_12010":"2020-07-06",
"customfield_13220":null,
"customfield_13102":null}
Custom.InQADate field type in AzDO is Date/Time.

Not sure, but it sounds like the date format is wrong, Azure DevOps uses ISO 8601 UTC, with "YYYY-MM-DD" accepted, for example.
As per #408, try the following and see if any of them work:

Try adding "type": "datetime" to your mapping
Try adding "source-type": "id" to your mapping

@Alexander-Hjelm do you mean like this?
{
		"source": "customfield_12010",
		"source-type": "id",
                "target": "Custom.InQADate",
		"type": "datetime"
    }

With this the tool doesn't pick the value at all in the export json.
Without "type": "datetime" the value is picked but still facing the same issue.

@rambaliga Not sure but I think source-type should be "name" in your case.

Is the error systematic? Is the date always being offset by 21.5 hours as in your example? If so, then it's an indicator that it could still be due to the time zone settings in your TFS or Jira.
Does mapping the custom field to a String field in AzDO give better results? If not, what value gets stored on the AzDO side? Is it a ISO 8601 UTC-string or just YYYY-MM-DD?

Hi @Alexander-Hjelm , sorry I missed to update here- this was fixed by setting the time zone in Azure Devops same as that of JIRA. Although after changing the time zone settings it took quite a while for the changes to reflect correctly across projects.

Ok, glad to hear that it worked :)


Run dbt models as full-fledged jobs (not one-time job submission)

Describe the feature
Dbt Cloud's job management features are pretty weak compared to Databricks. Ex: natively, they don't offer retries, timeout warnings, they timeout after 24 hours, notifications are abysmal, there's no run history, you can't configure runs to skip if the job is already running (instead it queues up), etc. All things that Databricks has nailed down pretty well.
I'd like to leverage Databricks' job running functionality but still use dbt. So, instead of running my jobs using the one-time submission API, I would want a full-fledged Workflow Job to be created for certain dbt python models. This would be a new submission_method.
I imagine that one-time submission was chosen partly because the code can change from run-to-run. However, if we leverage the dbt-databricks python create_notebook functionality [link], we can create a job based on the notebook path, and dbt can upload the current version of a model for each run.
Permissions-wise, I imagine the dbt user would need to be the only one with edit permissions. Not sure how it works currently.
In the yaml, job_cluster_config could continue to be the cluster configuration, and we could add another attribute at the same level - job_config or something - where we could configure notifications, run schedule, timeouts that supercede dbt timeouts, etc.
Describe alternatives you've considered
The current setup
Additional context
Please include any other relevant context here.
Who will this benefit?
Anyone using python models in dbt-databricks
Are you interested in contributing this feature?
Let us know if you want to write some code, and how we can help.
Yes - I'd be happy to help. I've got some time I could set aside for this in late August/september

What is the advantage of doing it this way, over using Databricks Workflow with dbt task type?

Hey @benc-db good point, I forgot about the dbt task type. What I'm proposing is to be able to integrate a Databricks Workflow job into the rest of the DAG, even if other models are being run via dbt Cloud. In which case, if a model were created with dbt task type, that would be great, too (assuming you can use more than just a SQL Warehouse). However, my impression is that the dbt task type isn't meant for an individual model - it's more for the whole workflow. But I haven't used it, tbh.
Having to use Databricks Workflows for all dbt models wouldn't be ideal, as we wouldn't be able to hook into features from dbt cloud.


Feature/react16

Add react 16 support

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@72bbccd). Click here to learn what that means.
The diff coverage is 80%.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   75.71%
=========================================
  Files             ?        3
  Lines             ?      140
  Branches          ?       37
=========================================
  Hits              ?      106
  Misses            ?       34
  Partials          ?        0

Impacted Files
Coverage Δ

src/components/Marker.ts
100% <100%> (ø)

src/components/Alert.ts
100% <100%> (ø)

src/components/Map.ts
73.22% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bbccd...9e44df5. Read the comment docs.


tls: fix error handling of no error code.

On Windows WSAGetLastError() in some cases returns no error even though tls got SSL_ERROR_SYSCALL. This was causing unexpected client disconnection, maybe once every 20-30 times. This fix treats this situation as blocking and retry.
@akallabeth @mfleisz

The SSL_ERROR_SYSCALL error code doesn't seems accurate at all when we see all the cases where we choose to ignore it and retry.
What about setting retry in all cases when we catch a SSL_ERROR_SYSCALL ?
Because looking at the last error in errno or WSAGetLastError() seems totally wrong when OpenSSL could have used BIOs that don't do any I/O operation (and so don't modify errno).
Perhaps we should give a try with SSL_ERROR_SYSCALL => always retry. If someone has an example that would break...

I have not reproduced a case yet that SSL_ERROR_SYSCALL happens and WSAGetLastError returns a critical error, but this is according to the OpenSSL document:
--- quote ---
SSL_ERROR_SYSCALL
Some I/O error occurred. The OpenSSL error queue may contain more information on the error. If the error queue is empty (i.e. ERR_get_error() returns 0), ret can be used to find out more about the error: If ret == 0, an EOF was observed that violates the protocol. If ret == -1, the underlying BIO reported an I/O error (for socket I/O on Unix systems, consult errno for details).

--- unquote ---

I am ok to set it to always retry for SSL_ERROR_SYSCALL if others have no objection.

OK changed as suggested. Please take a look.

@llyzs Is there really no error set by SSL_read and SSL_write or does WSAGetLastError simply not handle that specific errno value? WSAGetLastError is missing a default statement in the switch, so maybe we are just hiding something here...

@akallabeth I think OpenSSL's man with SSL_ERROR_SYSCALL is wrong. It doesn't make any sense to look at errno or WSAGetLastError() as the underlying transport is always done by BIOs that can be not socket / file descriptor based. Even worse, if the BIO do some debug printing after having read, errno really won't have the expected value. Today we don't understand clearly what lead openSSL to return a SSL_ERROR_SYSCALL.
@llyzs if you can reproduce the case easily perhaps you could try to add some debug infos with read() and write() calls (underlying socket), so that we could have a clue of what's going on...
If we can't find a situation where it bugs, I think we should take @llyzs's version that just ignore SSL_ERROR_SYSCALL.

@hardening that is certainly not easily reproducible but I don't have a clue how to debug this since when this happens, a retry always works.
I suggest we just take this fix. If we find something in the future, we will be more likely to come back here with better clue.

+1


[Change Request] Codeunit 22 "Item Jnl.-Post Line" – Existing function “ItemQtyPosting”

Could we please have the existing function “ItemQtyPosting”, Codeunit 22 " Item Jnl.-Post Line”, be set to global?

*** start old code ***
    //local procedure ItemQtyPosting()
*** stop old code ***
*** start new code ***
    procedure ItemQtyPosting()
*** stop new code ***
    var
        IsReserved: Boolean;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Get Phone Number Information using Python

Aim

What is the objective of the Script

using this python script the phone number's country of origin and the service provider can be known
Details

What the features will your script have

using phonenumbers python library, this script will be able to get the country of origin and the  service provider of a phonenumber.
like - India, JIO

@avinashkranjan Can I work on this issue?

Sure Go ahead @Sloth-Panda


add theme change how-to

cc @spboyer

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/client-side/bootstrap.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Leave a comment

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/client-side/bootstrap.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@spboyer  please review


added: grafana dashboard

Grafana Dashboard Updated

coverage: 67.892%. remained the same
when pulling 6aebdfd31d31f150984f97c0d63b42b692d4fbf6 on add/grafana-dashboard
into 07c38a3ab53890f9ea2fc270301540d53ff4354a on main.


"Contains" rules filter for fields with more than one value?

👋 Let's say you have a "chat" collection with more than one "participants" (MAX SELECT = 100) and you'd like people to be able to see the chat collection only if they are participating in it.
Is it safe to make a rule query such as participants ~ @request.user.id? Will PocketBase internally use a LIKE %userId% query, and is there a risk that it will evaluate incorrectly? (For example if one user has the id 1 and another has the id 11)?

Yes, when ~ or !~ operators are used we are converting then to LIKE and NOT LIKE expressions.
The user id is not incremental, it is a 15 chars unique random string and there are no plans for now to change that, so in general it should be safe to use the "~" operator in your case.
For your example, I would only add a check that there is actually an authenticated user, eg.:
@request.user.id != '' && participants ~ @request.user.id

In future versions I may consider making the filter a little more smarter and in case a relation field is checked it'll be converted to a json_each or other similar SQLite function.
I'll move the issue to Q&A discussion since the format is more suitable for that.


Set-Value 3.0.3 dependency has CVE-2021-23440

Hi,
The dependency set-value-3.0.3.tgz is blocked within my company due CVE-2021-23440.
Has this been mentioned before and can we install a newer version and skip 3.0.3 installation?

Sorry i realize this is gulp that has this dependency. I'll close this issue.


Fix caption and link.

Fix typo in dotnet-restore.

@matkoch,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


add unit tests, docs related to available log level names

This PR adds some unit tests and freshens up docs related to logging levels.
This work started as an effort to provide unit tests that exercise simple scenarios in which a single logging level is specified for the entire application (without any more specific logging directives). It grew into a bit of a doc updating effort, too.
The unifying theme behind the individual commits in this series is the surfacing of simple facts about the env_logger crate. These changes help provide answers to some fairly basic questions such as:

"What log levels are available?"
"Is INFO allowed in addition to info?"
"How do I configure it?"
"Does it have a config file?"
"How do I make it write to a log file?"
"How do I completely disable logging?"

The doc changes also include fixes to some contradictory statements about what the default behavior is.
Most of this is just gathering data from elsewhere else and putting it where people are already looking (info from the README.md file that wasn't in the crate-level API docs (or vice versa); info that can be guessed at from glancing at the log crate's API docs, but which are important for using env_logger with confidence; and so on). The idea is that the user reading the crate-level API docs on crates.io should get roughly the same sense for the crate as does the person reading the project's 'README.md' file on GitHub.
The newly added unit tests exercise functionality in a way that is more basic than the existing tests (that involve more sophisticated logging directives). These new tests also serve as easy to locate in-tree examples of simple use.
All in all, these changes help make the documentation of env_logger more self contained -- able to stand better on its own, and with less reliance on the user's familiarity with the log crate.

Heads-up: The failed CI check is unrelated to this PR.
The "Check formatting" check is complaining about a trailing comma on an existing line of code, not something introduced here.

@jplatte Thanks for the review!

Thanks for the PR, I like the improved docs!
I've now fixed the rustfmt issue on the master branch, could you rebase?

Sure; I'll do that as soon as I make the adjustments outlined below.

Also, why do your commit messages all start with [N of 9]: ? I've seen this before but don't really understand what value it provides.

It's mainly a way of organizing work informed by experience reviewing patch series in email threads. It attaches to a commit useful metadata that will live with the commit indefinitely (unless it gets removed in a future rebase or "squash and merge"). Having that small bit of metadata handy avoids the need to re-derive it, and provides a number of small benefits that can make things easier to manage, especially when working with a large number of projects and branches within those projects.

Personal commit management during development: While working on a change (always on a dedicated branch), the numbering helps with managing the individual commits across rebases, of which I do tons.
I don't usually sit down to write a patch series, but rather "just one small patch...". While trying to keep commits small and self-contained, one change grows into to two, two grows into three, and so on, and they almost never flow out in the same order as the final sequence. They continually get split apart, squashed together, and rearranged via rebases throughout.
Because Emacs and Magit make interactive rebases so easy, I do tons of them. Most never get pushed anywhere; they're just cyclical refinements made on my local branch leading up to the thing that eventually gets pushed.
Those interactive rebases involve nudging individual commits "up" and "down" in the order, inserting "fixup" and "squash" merges in between them, and similar things. That type of activity is more difficult for me to screw up when the commit messages have numbers on them.
I can also do the rebases more quickly when I can focus on the locality of the sequence numbers, which I already thought through at some earlier time when assigning the numbers. I do not have to again get my head into the context of each of those individual commits and redo the total sequencing.
The numbers help to tell at a glance how the change series is sizing up. As it evolves, I frequently inspect the output of:
    $ git log --pretty=oneline --no-decorate --reverse ${COMMIT}..

It is more convenient (and less error prone) to just run that one command than to run that command and then run it again to pipe to ...| wc -l to get the patch/commit count. And if I mis-specified the "since" commit hash, the numbers in the summary lines make that obvious.

Reviewing changes: When I'm reviewing somebody's changes, seeing "n of m" on them is a hint that the person has thought through the sequencing of the changes -- it is less likely to be "just a clump of changes". It's a small quality indicator heuristic.
Though GitHub does not directly support a workflow in which commits can be reviewed in email, it does include the commit summary in the email messages it sends out. I, for one, prefer to read that first before reading the (potentially much longer) PR description. I think the "n of m" number makes the commit summary easier to digest. Here's what it looks like in the email message I received for this PR:
    -- Commit Summary --

      * [1 of 9]: filter::parse_spec(): add more parse_spec_global* tests
      * [2 of 9]: filter::parse_spec(): add more parse_default* tests
      * [3 of 9]: update docs to note that level names are case insensitive
      * [4 of 9]: markdown now shows 'RUST_LOG'; in bold (first mention only)
      * [5 of 9]: update crate-level docs to note non-env-var configuration
      * [6 of 9]: docs: clarify default enabled/disabled log level behavior
      * [7 of 9]: docs: show log levels in bulleted list
      * [8 of 9]: document 'OFF' pseudo log level feature
      * [9 of 9]: docs: term "logging directives" emphasized (first mention)

When reviewing patches in email, seeing the collective "[PATCH n of m]" subject line would let the reader know at a glance whether they even have all of the pieces. This isn't a concern on GitHub, of course, but depending on how a commit series ultimately gets merged back into the main project there could be an analogous benefit when reviewing the Git history of a project (more on this below).
Finally, if I'm on the fence about whether or not to go get a coffee refill before reviewing a series of commits, seeing "n of 27" nudges me toward a different decision than does "n of 3" :-)

Commit history: The "n of m" messages make it easy to quickly inspect the 'git log' output while reviewing a pull request locally (e.g., after doing git fetch ${REMOTE_NAME} pull/${ID}/head:${LOCAL_BRANCH_NAME}). And that makes it easy to find the commit from which to start reading a la: $ git log -p --reverse d4606a33b38d..
The "n of m" message are also useful when it comes time to merge the changes from a branch. There are different schools of thought on what types of merges to perform in different circumstances, but the "n of m" helps with a couple of common scenarios when doing a "recursive" merge (the Git (and GitHub) default):

If --no-ff (also the GitHub default) or --ff-only options are used, then the individual commits will live on in the Git history as independent entities. Having the "n of m" on the commit message shows that the commit was part of a broader context, which may be useful to consider when reading the commit history.

If doing a "Squash and merge", then the combined commit messages from the series will be grouped together in the "starter commit message" presented, which the person performing the merge will (typically) then massage (hopefully with the help of a good text editor, in non-trivial cases). In this content the "[n of m]:" tokens can be used within one's editor (assuming a programmable editor) to partially automate the task of editing the message. For example, they facilitate landmark parsing while building up an editing macro interactively.

@jplatte By the way, thanks for fixing the rustfmt issue!

@jplatte By the way, thanks for fixing the rustfmt issue!

I only re-ran cargo fmt :sweat_smile:
(although I would really prefer the formatting as it was too)

Also, why do your commit messages all start with [N of 9]: ? I've seen this before but don't really understand what value it provides.

[...]

I was not expecting such an elaborate reply! Doing a lot of rebases myself I don't really get the benefits for that, but I can see how it would be nice to see when reviewing large change sets as a quick gauge for how far into the review one is.
I'll be doing the default GitHub "merge", i.e. with a merge commit, if that matters.

I was not expecting such an elaborate reply!

Yeah, I kinda got on roll there...  :-)

I'll be doing the default GitHub "merge", i.e. with a merge commit, if that matters.

I generally prefer that , too, because it keeps a more perfect record of the already-massaged history.
I just pushed my rebased update. It's identical to the previous set with two exceptions:

Commit 8is tweaked as we discussed above (for the "OFF" -> "off" changes)
I added a commit 10 to the end to explain the use of lowercase for consistency, and that the handful of exceptions are not typos

Please take a look when you can. I'm happy to refine it further, too.


code contribution guide

do you have any guides about how to debug it and understand  the API  for contributing new features

@maty21 yeah sure i will share the details

and how decript object js webapp ?
Thanks.


[Relay][Docs] Relay Language Reference

Here is an attempt at revising @jroesch's old Relay documentation for #2212. There have been large changes to the language since the initial version of those comments (see the first commit, which preserved them), so there was a lot to adjust.
Organization of these documents was a tough point, so I would especially appreciate feedback on that. Any feedback on content and clarity (or other relevant points) would be welcome as well.
One change @tqchen recommended on the previous documentation PR was keeping Relay language reference docs in the same directory as the other language reference documents, so I did that here rather than having it in a subdirectory. I also would be interested in discussion as to whether this is a good format.

Thanks for the suggested changes, @jroesch, I will incorporate them all later

@slyubomirsky @tqchen could you tag all the people who reviewed the original one to review this and then we can try and upstream

@junrushao1994 @zhiics @yzhliu @ZihengJiang @MarisaKirisame Tagging reviewers from original docs PR

@junrushao1994 @zhiics @yzhliu @ZihengJiang @MarisaKirisame Please comment, I will merge this in 48 hours if there is no additional comments

Thanks for putting so many details together. Another topic which is not expanded here but may be of interest to many people from NNVM background is subgraph. While there is a hacky way of supporting subgraphs in NNVM, seems Relay can naturally and gracefully achieve the same purpose. Maybe it deserves a full page of explanation in the future.

It might be helpful to add a section about graph semantics besides the let binding as in https://docs.tvm.ai/dev/relay_intro.html

Good idea, I'll see where I can fit that in

@tqchen @slyubomirsky  The first sentence of the first paragraph of the second section reads: "Traditional deep learning frameworks use computational graphs as their intermediate representation. ". Could you expand that with a ", because ....". If it is so important to use this representation, it is not unreasonable to have a good description of the reason in introductory documents like https://docs.tvm.ai/dev/relay_intro.html

@Ravenwater That's a good point, and there are a few reasons to list there.

@Ravenwater opened a separate PR regarding the changes to the other Relay doc

@zhiics @jroesch @joshpoll @reminisce please take another look and https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

meta: common binary operators have syntactic suger in the text format, e.g. add, multiply, equal are +, *, ==, resp.

Ah, good, I will use that.

Decided to go through with a large reorganization in relay_expr: The issue of function calls made the distinction between the dataflow and control fragments a little messy, so I put the discussion into a subsection by itself and let each expression be its own subsection.

I think it is fine to mention TempExpr, IncompleteType in a developer facing Expr section to explain the design philosophy. We don't need to mention TypeReporter as it is an implementation detail.

Very well, I'll add a brief subsection for TempExpr.

@joshpoll @jroesch @zhiics @reminisce please take another look and https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@joshpoll @zhiics @reminisce please take another look, if there is no further comments, I will merge this PR in 24 hours

@slyubomirsky once you fix if-then-else and the reordering suggestion I will approve.

Thanks to @slyubomirsky for the hard work on proposing and improving the PR, thanks to @jroesch @joshpoll @zhiics @reminisce for informative reviews, this is now merged!


Hi friend, could you please update for osx-arm64?

I need tkinterdnd2 for osx arm64 on my M1 Max Mac. I have built an arm64 version from the petasis/tkdnd repository, which can be found in the runtime-arm64.zip file. Alternatively, you can build it yourself on your M1 Mac by following the instructions provided in my issue opened on petasis/tkdnd#54.

The OP ended up building binaries themselves and making the repository tkinterdnd2-universal. They deleted the github repo but left the PyPI package. Binaries from the PyPI package have now been included in this repository. The logic was also updated to support ARM Windows, ARM MacOS, and ARM Linux.
Someone else forked tkinterdnd2-universal before its deletion and it now exists solely for ARM support: https://github.com/escoolioinglesias/tkinterdnd2-osxarm64
However, these binaries have been included with an aim for supporting those architectures now and into the future.


feat: (Draft) add yaml Draft build pack support for Helm quickstarts

This PR adds Yaml Draft build pack to enable  Jx create quickstart and jx import for Helm chart projects
Fixes jenkins-x/jx#2391

@jstrachan Please, review the when you have time. It would be awesome to be able create quickstarts from Helm charts templates.


Tap firing twice

I am using Angularjs, for events I am using hammer.js . I have a new version on hammer.js on my application. The tap is binded my directive, when I tap or touch on my mobile device its firing twice.

@MadhuSudhanBhaskar I'm the maintainer of Angular Hammer and have been encountering a similar problem. When you get a chance, take a look at my issue (#742) , which details what we believe to be the problem, and compare with your own code/experience. If you find it to be the same I would recommend closing this issue and watching my issue.

@RyanMullins Did you miss the part of the docs that suggests preventGhostClicks?
http://hammerjs.github.io/tips/
https://gist.github.com/jtangelder/361052976f044200ea17

Nope. Please read the details of my issue. It's a very different problem related to capturing both TouchEvents and MouseEvents fired from a single click but milliseconds apart.

@runspired Unless I'm completely misinterpreting the point of PreventGhostClicks, which I view as a way to stop other handlers from being fired when after a Hammer handler responds.

@runspired this may even be a problem particular to Angular. If it is, it's because of the Angular execution context where it effectively adds a second run loop inside of the JavaScript run loop, so it could be that the secondary mouseup event is being triggered before the PreventGhostClicks functionality in the Angular context has a chance to respond. If that is the case, then the solution I want will eliminate the need for PreventGhostClicks.

@Ryan Sure I will check your issue and close mine.
On 08-Jan-2015 3:53 am, "Ryan S Mullins"<EMAIL_ADDRESS>wrote:

Sounds like I know what I'm working on tomorrow afternoon then.
—
Reply to this email directly or view it on GitHub
https://github.com/hammerjs/hammer.js/issues/727#issuecomment-69129009.

Closing in favor of the meta issues for this.


update _missing_traslation_vi.json

Update missing translation for Vietnamese #345
Note: Please help to run slang update. I don't have Dart on my current computer. Thanks!

No worries


"az network vnet peering list": Unexpected whitespace significance in query parameter

Describe the bug
I was trying to list vnet peerings filtering by a prefix using the following command:
az network vnet peering list --resource-group my-rg --vnet-name my-vnet --query "[?starts_with(name,'prefix-')].name".  This failed for me with the following error: ].name was unexpected at this time..  I initially asked a question about this on Stack Overflow here: https://stackoverflow.com/questions/59154106/filtering-with-azure-cli-and-jmespath .  It turns out that if you add a space in various places in the query, this command works fine, but if there are no spaces it does not.
This does not work:
--query "[?starts_with(name,'vnet')].name"
These work:
--query "[?starts_with(name, 'vnet')].name"
--query "[?starts_with (name,'vnet')].name"
--query "[?starts_with(name,'vnet') ].name"
--query "[?starts_with(name,'vnet')] .name"
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az network vnet peering list --resource-group my-rg --vnet-name my-vnet --query "[?starts_with(name,'prefix-')].name"

Expected Behavior
Command returns query results successfully.
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.77

Extensions:
aks-preview 0.4.17
application-insights 0.1.1

Additional Context
This was also tested on azure-cli 2.0.72 and 2.0.73 with the same result.

@MyronFanQiu Please take a look

This is a Windows PowerShell issue. We have doc'ed it at https://github.com/Azure/azure-cli/blob/dev/doc/use_cli_effectively.md#argument-parsing-issue-in-powershell. To workaround it, please insert --% after az to force PowerShell to treat the remaining characters in the line as a literal.

@csuzw Hello. Is your problem solved? like @jiasli said, this is a windows PowerShell issue. We have encounter this issue before so the current workaround should work for you.

@MyronFanQiu we worked around it by putting a random space in the query.  The suggested solution is lacking in that as far as I can tell it prevents the use of variables.  I guess as this is a powrshell rather than azure cli issue this issue should closed.  However it is very non-obvious behaviour and very difficult to search for/find the problem/solution so I feel like something needs to be changed somewhere, even if it's just better warning/error messages.

@csuzw Hello. We updated our doc. https://github.com/Azure/azure-cli/blob/dev/doc/use_cli_effectively.md#quoting-issues


AnimationBehavior enhancements

Description of Change

Addition of AnimateCommand to the AnimationBehavior class which lets the animation be triggered from a read-only Command.
Bugs Fixed

Fixes #1175

API Changes

Added:

ICommand AnimationBehavior.AnimateCommand { get; }

Behavioral Changes

The AnimationBehavior class can have it's animation be triggered from a read-only Command.
PR Checklist

[x] Has a linked Issue, and the Issue has been approved
[x] Has tests (if omitted, state reason in description)
[x] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR I merged from xct/main into my main, is that good enough?
[x] Changes adhere to coding standard I think so

[ ] Updated documentation Not yet but I do intend to

@bijington can you sign-in into the microsoft-cla ?

@bijington also, you should rebase your PR against the develop branch

@pictos I have signed the Microsoft-cla, not sure why it isn't showing that I have.
Damn sorry about the main / develop mix up.

It's ok (:

I have tried rebasing locally but git is complaining about some merge conflicts with pipeline yaml files. I am tempted to close this PR and and just start the changes off develop again

I have tried rebasing locally but git is complaining about some merge conflicts with pipeline yaml files. I am tempted to close this PR and and just start the changes off develop again

Go for it

Replaced by PR #1180 which is on the correct branch


Implement a unified index.yaml entrypoint service to support namespace isolations

replace the helm package from github.com to k8s.io
implement /index.yaml service API

Pull Request Test Coverage Report for Build 7582

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 64.707%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
2
81.87%

Totals

Change from base Build 7581:
0.02%

Covered Lines:
11107

Relevant Lines:
17165

💛  - Coveralls


Cesium 3dtiles inspector refactor

The knockout usage in Cesium3dTilesInspector was not correct.  There was an incorrect separation of the view and viewmodel.  I also cleaned up the code because there were a ton of unnecessary subscriptions and bad use of private properties.  No functionality changed, but I apparently changed so much of the code that GitHub can't do a proper diff.
@austinEng can you test to make sure all of the functionality is there?
@mramato do you want to do a code review?

No functionality changed, but I apparently changed so much of the code that GitHub can't do a proper diff.

The problem isn't the amount of code that changed or GitHub, it's that Git did not pick up the rename automatically (which is a weakness of Git in general).  In either case, I can code review it as if it's new since you changed a bunch of stuff and I haven't looked to closely at this yet anyway.
Any other testing @austinEng or any of the other 3D Tiles team can provide is greatly appreciated.

I tested a little bit and it seems to work like normal.
:thumbsup:

Great work here @hpinkos!  Thanks for cleaning this up.  That's all I have.

@mramato ready

Thanks again @hpinkos, good work here.


Remove the access and opening times table

https://trello.com/c/lA84xqw5
We added a “pending“ migration to remove the access_and_opening_times table as the data has been migrated to fields on the Worldwide Organisation and Worldwide offices (#7611)
Now that we are confident that the change is working as expected, we can perform the pending migration.

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

I think the migration's name (i.e. the timestamp) will need updating, as it is older than the latest migration, meaning Rails won't run the migration automatically (you should expect to see the version update in db/schema.rb).

Rails maintains a table of migrations that have been performed in the table associated with ActiveRecord::SchemaMigration.all.
We can test this if you would be happy to pull down this branch, Rails should raise a PendingMigrationError (I think)
I also believe it's best practice to select the later timestamp when resolving conflicts in the schema (even if it's not the migration you added)

Link explaining it here https://stackoverflow.com/a/36608615


Import Razer Chroma profiles

Is there anyway to enter those files into aurora? if there isn't could u enter this feature please? Tnx
https://s3.amazonaws.com/razer-assets/downloads/chroma/profiles/keyboards/blackwidow/Poicenz/Poicenz_heart%20shape.razerchroma

Duplicate of #429


Request: Add support for Python Pipenv to read packages from Pipfile/Pipfile.lock

Today component detection is not able to detect any packages in the Pipfile/Pipefile.lock manifests.

@felickz I'm not too familiar with this, but I briefly looked over the spec and it seems like parsing the file to generate a flat list of dependencies would be fairly straightforward, but there isn't a good mechanism included for generating a dependency graph (which packages brought in which dependencies).
If you have any additional context here such as how frequently this is used in Python builds, I would appreciate it.


Don’t build mapping/setting requests on empty parted tables.

Altering an empty partitioned table must only result in updating the template as no indices exists yet.
Fix the ArrayIndexOutOfBoundsException which is raised otherwise while accessing the empty indices array.

retest this please
java.lang.AssertionError: still open connections: {{<IP_ADDRESS>:53307}{rMHW4___T_-whVZyAAAAAA}{<IP_ADDRESS>}{<IP_ADDRESS>:53307}=[org.elasticsearch.test.transport.StubbableTransport$WrappedConnection@e7ea37c]}


Update expensify-common to skip rendering invalid markdown

Details
Please note that this PR doesn’t need to be merged because PR https://github.com/Expensify/App/pull/18994 is going to update newer commits. It's created to record test and PR checklist.
Fixed Issues

$ https://github.com/Expensify/App/issues/17785
PROPOSAL: https://github.com/Expensify/App/issues/17785#issuecomment-1526892819
Tests

Go to a chat and add a comment, _*test_*
Verify that text test is displayed in italic and is not formatted in bold style.
Click to edit the comment and verify the initial draft is same as the input.

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@eh2077 You've got merge conflicts.

@eh2077 You've got merge conflicts.

@deetergp Yes, I know. So I added the note in the PR description

Please note that this PR doesn’t need to be merged because PR https://github.com/Expensify/App/pull/18994 is going to update newer commits. It's created to record test and PR checklist.

Ah, gotcha. Since the hash in that PR is the latest/greatest commit in this repo, yes, it makes sense and should include your change.


Add a way to uniquely identify tests, and filter based off of these.

We have several different options to only run specific tests, but we have no way to uniquely identify a test.  When specifying a test case with --test-case=Foo, it will run all test cases named Foo.  Since there is no requirement that test case names be unique, this could run several tests.
We can of course filter it down to a specific suite with --test-suite=Bar, but that is still not unique, and it also doesn't work well with the --exclude variety of filtering options.  For example, suppose I want to exclude exactly one test case whose suite is S and whose test case name is T.  I believe this to be impossible with the current version of doctest.  If you pass --test-case-exclude=T --test-suite-exclude=S then this excludes test cases that match either the suite or the case name.
I think there are two "elegant" ways to fix this:

Test case names can be arbitrary strings.  You could change this so that some character is reserved, for example perhaps the / character is reserved.  Then you could uniquely identify a test case by the name <suite>/<case>/<subcase>, and the filter options could accept this syntax.
You could add a command line option called --require-unique-test-names (or -rutn), which would error if the same test name was given twice within a single program.  This way we could just rely on --test-case-exclude.

Sounds reasonable! Cannot promise a date however...

Under what circumstances does simultaneous test suite and test case filtering not uniquely identify your test case?
I see why this becomes a problem in the exclusion case. Creating some form of UUID for each test case / subcase could be a useful feature (though if you have access to the source code you are testing I would just change the test case name if there is something I want to exclude).
Some comments on the suggested feature additions

Reserving / for suite/test/subtest distinction breaks existing clients. One could of course add a feature flag --reserve-slash or something to enable this feature. Implementation would then join the suite/test/subcase names with slashes such that they become unique. This might introduce other problems, needs to be considered carefully or new bugs can be introduced. Also introduces a maintenance burden since the developer always have to keep in mind that this flag can be turned on. Adding a new UUID field instead of changing the test case / subcase names could be a solution here, since old code does not rely on the new UUID feature.

Adding --require-unique-test-names would break your own code so you wouldn't be able to run your tests at all unless it is applied after the suite/testcase filtering is done. Chicken egg problem, so not a solution.


gRPC-cpp and gRPC-Core Value conversion build warnings

After clean build there are 131 warnigns from this dependences

Hi @artembolotov, please provide the required information from the issue template to investigate the issue. Thanks.

[REQUIRED] Step 1: Describe your environment

Xcode version: 13.3.1
Firebase SDK version: 8.15.0
Installation method: Swift Package Manager
Firebase Component: AppCheck, Firestore, Messaging, Storage
Target platform(s): iOS

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
After updating to the latest Firebase SDK version, Xcode shows 392 gRPC-Core issues when compiling.
gRPC is on version 1.44.0-grpc
No prior issues, only after appeared after the update. Cleaning the build folder did not help.
Xcode states:
Value conversion issue - Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int')
Relevant Code:
  if (_upb_isle()) {
    return val;
  } else {
    return ((uint64_t)_upb_be_swap32(val) << 32) | _upb_be_swap32(val >> 32);
  }
}```

Thank you!

Thanks for the info. I was able to reproduce the issue using the latest version. I'll inform the engineer about this, and we'll see what we can do.

I have this issue in latest version

Having the same issue. I think it happens only after adding FirebaseFirestore dependency.

We've had discussions with the Firebase dependency -  gRPC team and they are working to fix it in their next release. We'll update here when that gRPC release is available.

This should now be fixed with an update to 1.44.2-grpc

Hi Paul,
I just update all packages including to 1.44.2-grpc. While the number of warnings have reduced for me from >300, there are still see 124 warnings generated.
Xcode 13.4, Ios 15.5.
Sample screenshot attached. What info can I provide to help?

Thanks @kennedycraig. I'll reopen and we'll follow up with the gRPC team and let you know.  cc: @dennycd

Forgive me if I'm "not doing it right" because I'm new to this type of posting.
I just opted to switch to a Firebase implementation using XCode Package Manager. Now, when I build (for Swift), I have a slew of warning related to this library. Since I'm clueless about protocol, I figured I would just start with this screenshot from XCode.
Are these libraries safe to use in a Production app? Or, should I revert back to the Frameworks upon which I was relying? What is the preferred way of reporting these issues?
I am using XCode 13.4

@RiverboatGambler The only difference between the different installation methods is whether or not build warnings are suppressed. As noted above, the fixes for the warnings are in progress.

Thanks, Paul. I'll take that as "nothing to worry about". Appreciate you and the amazing job the folks out here have done. Firebase has been a treasure trove for me on my first IOS app. Kudos to all of you for the great work!

@paulb777 may I kindly ask whether there is any update? Fully aware that it's only warnings, just love to see no issues when compiling haha

Three of the Firestore dependencies were updated today to address warnings in SPM builds. Update to 0.20220203.2 for https://github.com/firebase/abseil-cpp-SwiftPM, 0.9.1 for https://github.com/firebase/boringSSL-SwiftPM, and 1.44.3-grpc tag for  https://github.com/grpc/grpc-ios/
Note that these repos still have analyzer issues and build warnings remain for leveldb.

I'm going to close since the gRPC build warnings are now addressed. Please open another issue if you'd like to track the remaining gRPC/abseil/BoringSSL analyzer issues (in progress) or the leveldb build warnings(not currently planned).


[Bug] Shows empty app name error in edit mode itself

Description
In app edit mode if user tries to change the app name, and in doing so removes the complete string- they get an error right away; even if they are not trying to save an empty string. Error should be shown only if user tries to save the empty app name.
Steps to reproduce the behavior:

Open any app in edit mode
Try to edit the app name
Remove the complete string
On top right you'll see an error toast

Important Details

Version: Cloud

https://user-images.githubusercontent.com/13262095/118106331-1f67ed80-b3fb-11eb-80a3-587e3d84744a.mp4

Stats

Stat
Values

Reach
25

Effort (months)
0.25

Closing since this is a consistent experience even on APIs/Queries


Extract CI code to separate repo

What would you like to be added:
Pipeline code from ci/ should be in a separate repository.
Pipeline code used in .github/workflows/ should also be in a separate repository.
Pipeline definitions may stay in the current repo gardenlinux/gardenlinux.
Why is this needed:
Changes in CI must not change git HEAD of Garden Linux repository.
Separation of product related code and ci/cd code.

the folder /ci contains two parts:
the standard build pipeline (replaced by github actions meanwhile)
the publishing pipeline (that pushes the garden linux images to the various cloud probiders)
the change here reduces the amount of changes on the main repo because publishing is separate.
And as soon as the standard build pipeline is fully github actions we do not need this folder anymore.


support target framework 4.5

We are still at .net framework 4.5. Can you please add support of framework 4.5 besides 4.5.1 and .NETStandard 1.3? Thanks.

.NET Framework 4.5 (and 4.5.1) are no longer supported by Microsoft so I'm not going to prioritize looking into this unless lots of other people ask for it. We'll look at PRs or any investigation people might do into the viability of this though :-). The decision is inherited from rdkafka-dotnet and I don't know what @ah-'s reasons were. By default I assume there were reasons (but it may be somewhat arbitrary).

I don't quite remember, I think it was due to some bug and/or .net standard incompatibility in 4.5.0.

The project I am working on are also still on .NET 4.5 and updating this is not an option for at least a couple of months (maybe next year). Currently I am using kafka-net (https://www.nuget.org/packages/kafka-net/ ) producer. It would have been great to also validate this to find the best performance and stability on throughput. I need to be able to push at least 3000 to 4000 messages per second.

Had also this problem when working first with rdkafka but could update my packages, made a quick PR as it doesn't to introduce any issue
I assume it's not an uncommon case - in our company, introduce kafka in a legacy project before to move to new projects in .net core or other languages
@combrinckd : i would advise you to check that your production server run under net framework 4.5.2 (or 4.6+) and not 4.5, as it's not supported anymore by microsoft. You don't have to change your project at all, just the framework installed on the servers. There are very rare breaking change doing this upgrade that you can find here : https://msdn.microsoft.com/en-us/library/dn458358(v=vs.110).aspx
If possible update your projects, it's not that long ;)

ok - there seems to be sufficient demand for this, and @treziac worked out all the details and submitted a PR.. so it's in!

As a note, we may want to add a net45 and net451 reference and not just net45 and maybe even other moniker
(everything which is noted as obsolete in an upper .NET Framework version should target a new version. I don't think there will be any breaking changes in future but yet. There should be no obsolete warnings when targeting any framework)
Will do this later, no urge as long as it's only obsolete and not removed :)


Add delete secrets permission for addon

Add delete secrets permission for submariner-addon clusterrole so it can delete broker secrets created by it.

/cc @skitt @tpantelis

The verify job failed - looks like you need to commit changes to deploy/olm-catalog/manifests/submariner-addon.clusterserviceversion.yaml.

/lgtm

/approve

/cherry-pick release-2.10

/cherry-pick release-2.9


feat(MessageFlags): Add failed_to_mention_roles flag (1 << 8).

Summary
I failed to test this flag, so if anyone could test this, I appreciate it. Also, I didn't want to make the flag name long, failed_to_mention_roles_in_thread might be good to avoid confusions, but it's too long :/
ref:
https://github.com/discord/discord-api-docs/pull/4282

Checklist

[ ] If code changes were made, then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running pre-commit run --all-files

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

As far as I know, the original name is FAILED_TO_MENTION_SOME_ROLES_IN_THREAD which is kind of ridiculous but I don't think we can shorten it without making it misleading

Oh wait you mentioned it in the description

I fee like failed_to_mention_roles is too confusing

Yeah, I agree, how about failed_to_mention_roles_in_thread?

Sounds good to me


[AVM Module Issue]: Virtual Network Links are not uniquely named

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/network/dns-forwarding-ruleset
(Optional) Module Name if not listed above
No response
(Optional) Module Version
No response
Description
DNS Forwarding Ruleset does not create unique naming when creating the vNetLinks and provides no alternative for providing a name with the current vNetLinks parameter. In the example below I have two virtual networks called 'spoke-network' in two different subscriptions.
Error Produced:
Frontend service lock could not be acquired.
Pseudo Example:
module TestRuleset 'br/public:avm/res/network/dns-forwarding-ruleset:0.2.4' = {
  scope: ResourceGroup
  name: 'TestDnsRuleset'
  params: {
    name: 'TestDnsRuleset'
    forwardingRules: []
    vNetLinks: [
      '/subscriptions/<sub-a-redact>/resourceGroups/Network/providers/Microsoft.Network/virtualNetworks/spoke-network'
      '/subscriptions/<sub-b-redact>/resourceGroups/Network/providers/Microsoft.Network/virtualNetworks/spoke-network'
    ]
    dnsForwardingRulesetOutboundEndpointResourceIds: [
      '${DnsResolver.outputs.resourceId}/outboundEndpoints/Outbound-Resolver'
    ]
  }
}

Each resource id in vNetLinks will default to "spoke-network-vnetlink" causing the error from above.
https://github.com/Azure/bicep-registry-modules/blob/938fb7c3531e251c4e3f42023329bcc133452862/avm/res/network/dns-forwarding-ruleset/main.bicep#L105-L113
https://github.com/Azure/bicep-registry-modules/blob/938fb7c3531e251c4e3f42023329bcc133452862/avm/res/network/dns-forwarding-ruleset/virtual-network-link/main.bicep#L22
(Optional) Correlation Id
No response

Hey @ChrisSidebotham, please take a look once you have a moment to triage the issue :)

@coolhome - PR Opened, care you review?


[Feature]: Add to chip content: Name + State

Is your feature request related to a problem?
I wanted to display battery levels from blinds on chips but either it can only display value or name, so having 2 chips side-by-side each other with value :battery: 45% :battery: 32% is not really "intuitive" (I will know since I created those chips, but others family members not really will know what those refer to)...
Describe the solution you'd like
So basically I'd like to display in chip a Name and entity state glued together. e.g.:

Name=Blind left ,
entity=sensor.cover_battery_precent_1 (e.g. value 45%) ,

This would display on chip:
:battery: Blind left 45%
Describe alternatives you've considered
No response
Additional context
No response

You can do it with template chip


support direct lbry:// URL linking

For whatever reason @ symbols are stripped when trying to paste in to the safari workaround
This should even work for blacklisted words like covid

The problem seems to stem from the fact that the lbry:// URI format is not acceptable as a URI, so browsers don't seem to handle it properly.
Working with an example LBRY URI of lbry://@Odysee:8/Odysee-Android-App:1, we can see the following violations of the standard (looking at https://en.wikipedia.org/wiki/URL#Syntax)

There is the start of an authority component, which is meant for userinfo+host+port, but is being used as:

An empty userinfo
Followed by an @, which is supposed to be part of the userinfo
The channel name where the host should be
The claim id where the port should be, in this case a number but it can also be a letter, which would be even more in violation of the standard

This gets parsed as the following by browsers:

Browser
Result

Safari on iOS Simulator
lbry://odysee:8/Odysee-Android-App:1

Safari on macOS
lbry://Odysee:8/Odysee-Android-App:1

Firefox (on macOS)
lbry://@Odysee:8/Odysee-Android-App:1 - This is the only one that shows the original URL

Qutebrowser (QTWebEngine aka Chromium) on Linux
lbry://@odysee:8/Odysee-Android-App:1 - Note the lowercase host, as is the standard for a hostname

Epiphany (WebKitGTK, same engine as Safari) on Linux
lbry://Odysee:8/Odysee-Android-App:1

Using lbry:@Odysee:8/Odysee-Android-App:1 works correctly on all browsers (except that the LBRY/Odysee apps can't handle this format), as URIs without an authority can have any characters in any order.

The issue probably wasn't clear enough, sorry. Want to be able to post these urls with and without Lbry:// into the search bar in the app, and go directly to the claim (vs running a search). Not sure if there's a nice way to detect via regex, and it could lead to a direct link when someone was intending to search, but if the regexes are specific enough , maybe it won't happen too often. Probably need to replace # with : also, so both work.
I..e @channel:1 / @channel#1
@channel:1/claim:2 / @channel#1/claim#2
Claim:2 / claim#2 (probably the biggest chance for false match).
Can leave this one for now , not super important.

Ok, although it's worth noting that LBRY URIs aren't really spec conforming.

Somewhat related: https://github.com/OdyseeTeam/odysee-ios/issues/277#issuecomment-1229199510.


Fix broken null handling logic

This PR started out as a two-liner in one file, but grew slightly due to unrelated issues in branch. Summary of all changes:

Backport fix for regression in handle_nulls() introduced in #5106
Backport unit test fix from #5313
Backport select parts from #5460 of tox.ini and requirements-dev.txt to avoid false positive regression in current stable pylint (fires E1101 incorrectly in viz.py for missing members in geopy.point.Point)
Fix a few linting errors

Thanks for fixing this. LGTM apart from the build errors.

Codecov Report

Merging #5619 into 0.27 will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             0.27    #5619      +/-   ##
==========================================
- Coverage   61.39%   61.28%   -0.11%
==========================================
  Files         369      369
  Lines       23536    23530       -6
  Branches     2724     2720       -4
==========================================
- Hits        14449    14421      -28
- Misses       9075     9097      +22
  Partials       12       12

Impacted Files
Coverage Δ

...t/assets/src/dashboard/reducers/getInitialState.js
0% <ø> (ø)
:arrow_up:

...rset/assets/src/dashboard/actions/sliceEntities.js
32.25% <ø> (+1.95%)
:arrow_up:

...c/dashboard/components/dnd/AddSliceDragPreview.jsx
61.9% <ø> (+2.81%)
:arrow_up:

superset/utils.py
87.92% <ø> (-0.03%)
:arrow_down:

superset/models/helpers.py
87.7% <100%> (-0.07%)
:arrow_down:

superset/viz.py
79.98% <100%> (-1.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef096da...a125ca1. Read the comment docs.

ping @mistercrunch WRT the release today of 0.27.0, this PR was pending review for rc1.


Fix URL for raw files in GitLab

RAW files are not programmatically accessible buy '/raw' endpoint anymore.
Behaviour discovered after upgrade from v11 to v13.
Fix is aimed to use repository API instead of /raw endpoint.
Signed-off-by: kostyapenkov<EMAIL_ADDRESS>

@kostyapenkov - thanks for doing this. I wasn't expecting that!

deployed. fix confirmed - a development/sdk-images build was triggered.


npm start is not firing automatically after npm install

Describe the bug:
I have an app:
https://stackblitz.com/edit/sfrontend-devbox-20210623
It successfuly installs dependensies, but then:
npm start is not happening automatically,
and if i am running it manually, webpage on the right side of container - is not opening.

Open:
https://stackblitz.com/edit/sfrontend-devbox-20210623
Wait until npm intall finishes
First bug - nothing happens.
Executing npm start
Console says successfully compiled, but page is not appearing
Link to the blitz that caused the error
https://stackblitz.com/edit/sfrontend-devbox-20210623?file=src%2Ftest.ts
Steps to reproduce:

https://stackblitz.com/edit/sfrontend-devbox-20210623
Wait until npm intall finishes
First bug - nothing happens.
Executing npm start
Console says successfully compiled, but page is not appearing
Expected behavior:

Version of webcontainer:
Hash: 82080794cabf87e5630cd7deb9f8d7067a2f5758
Screenshots:
Desktop (please complete the following information):
Browser name  = Chrome
Full version  = 91.0.4472.106
Major version = 91
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.106 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 158418581,
  "usedJSHeapSize": 148617229,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context:

Update: I see in half of cases when opening in new tabs - issue is dissapearing, and sometimes appearing again.

Hi @fedir-indutnyi. If you want to start your project automatically, you can add a .stackblitzrc file with the following contents:
{
	"startCommand": "npm start"
}

The reason you might experience this behaviour is if you have StackBlitz open in another tab or window which is running an application (or that specific application) on the same port. That doesn't work. We have an internal ticket to address this and notify users if that's the case.
That could also explain why you sometimes see it and sometimes you don't. So if you test it again, make sure you aren't running the same application in another tab/window.

Thank you very much @SamVerschueren  that helps. You can mark issue resolved.
Have a great day.


How to test TrustedHosts

I'm wondering if there is an easy way to test the fingerprint associated with a TrustedHost ( Get-SSHTrustedHost ).  I have systems that I connect to where the IP Address can move between systems and will therefore fail on connecting.  If I could easily validate the fingerprints I could more easily verify if those system have moved to a valid host and can be removed/re-added to the TrustedHosts list.
Thanks.

have you tried usiing hostnames instead of IPs so those are saved in the registry associated to the host?

Uploaded 1.7.5 to the gallery and added a -Force parameter that will not verify the host key.


version 0.7.2 breaks your model validations using activity_logging module

since version 0.7.1 you are using update_attributes instead of save(false), this will trigger the validations in your model and the login will fail with an record invalid exception.
Is it possible to revert to the old method user.save(false) or update_attribute since your are updating only one attribute and this method will not trigger model validations.
Thanks

Yes, I will try to move to update_attribute.
On Tue, Oct 25, 2011 at 1:53 PM, developers-mobillion <
<EMAIL_ADDRESS>
since version 0.7.1 you are using update_attributes instead of save(false),
this will trigger the validations in your model and the login will fail with
an record invalid exception.
Is it possible to revert to the old method user.save(false) or
update_attribute since your are updating only one attribute and this method
will not trigger model validations.
Thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/NoamB/sorcery/issues/108

Thanks very much!

Yes, this would be very nice. I'm having the same problem.

I have submitted pull request #112 that takes care of the problem

Fixed in another issue


Support for EntityFramework persistence

Would it be useful to have an EntityFramework persistence package?
I might be able to look into developing one on my next project if it would be useful.
That would then enable various persistence options out of the box.

I'll add it to my TODO list! I was thinking of tackling CosmosDB first, but I can switch.

I'll add it to my TODO list! I was thinking of tackling CosmosDB first, but I can switch.

@izzycoding what do you mean by EntityFramework, specifically? Would a "standard" SQL persistence library work for you? OpenSleigh is abstracting away all the implementation details, do you specifically need it to use EF instead?

@izzycoding what do you mean by EntityFramework, specifically? Would a "standard" SQL persistence library work for you? OpenSleigh is abstracting away all the implementation details, do you specifically need it to use EF instead?

Ideally my use would need EntityFramework as our build system is already geared for building and deploying migrations. Also, we use MSSQL, SQLite, PostgreSQL and MySQL as potential database providers and we already have a framework for selecting and configuring the relevant EF provider at runtime.

Ideally my use would need EntityFramework as our build system is already geared for building and deploying migrations. Also, we use MSSQL, SQLite, PostgreSQL and MySQL as potential database providers and we already have a framework for selecting and configuring the relevant EF provider at runtime.

For an EntityFramework implementation I would expect part of the service registration builder to allow the relevant EF serviceBuilder extensions to inject the provider. The DbContext is then an EF one which is registered similar to:
cfg.UseEntityFrameworkPersistence(options => options.UseSqlServer(connString));
Doing this would enable my code and CI/CD to work as it already does with minimal changes.

For an EntityFramework implementation I would expect part of the service registration builder to allow the relevant EF serviceBuilder extensions to inject the provider. The DbContext is then an EF one which is registered similar to:
cfg.UseEntityFrameworkPersistence(options => options.UseSqlServer(connString));
Doing this would enable my code and CI/CD to work as it already does with minimal changes.

Also, noticed that EF has some providers being developed for MongoDB:
https://github.com/BlueshiftSoftware/EntityFrameworkCore
And CosmosDB:
https://docs.microsoft.com/en-us/ef/core/providers/cosmos/?tabs=dotnet-core-cli
A single implementation to cover 90% of use cases.

Also, noticed that EF has some providers being developed for MongoDB:
https://github.com/BlueshiftSoftware/EntityFrameworkCore
And CosmosDB:
https://docs.microsoft.com/en-us/ef/core/providers/cosmos/?tabs=dotnet-core-cli
A single implementation to cover 90% of use cases.

well, as I wrote before, OpenSleigh would abstract all the implementation details, so it doesn't really matter what library it is using to access the persistence layer. It could be EF, Dapper, raw ADO, whatever.
From your perspective, you just have to feed the connection string when configuring the library in your Composition Root.
That said, EF is a valuable tool and would allow several different database technologies to be supported in (potentially) one go. I started already a PoC in a feature branch, I'll link this issue with the PR when I'm done.

well, as I wrote before, OpenSleigh would abstract all the implementation details, so it doesn't really matter what library it is using to access the persistence layer. It could be EF, Dapper, raw ADO, whatever.
From your perspective, you just have to feed the connection string when configuring the library in your Composition Root.
That said, EF is a valuable tool and would allow several different database technologies to be supported in (potentially) one go. I started already a PoC in a feature branch, I'll link this issue with the PR when I'm done.

Brilliant. I am happy to help when I get time if that would be of any use?

Brilliant. I am happy to help when I get time if that would be of any use?

it would be nice, thank you. I'm still in the design phase (for the whole library actually...) and this is a fairly complex area to be fair.
Anyways, feel free to fork and then raise a PR :)

it would be nice, thank you. I'm still in the design phase (for the whole library actually...) and this is a fairly complex area to be fair.
Anyways, feel free to fork and then raise a PR :)


⚠ Bofrost.be has degraded performance

In 667f637, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1855 ms

Resolved: Bofrost.be performance has improved in 4328a0d.


chore(openapi): update rhose-mgmt/v1 OpenAPI document

This pull request was auto-generated
This PR adds the latest version OpenAPI document version for rhose-mgmt/v1.
Actions:
1. Review changes on the OpenAPI file and validate if it is correct.
2. Perform manual changes if needed or apply local patches for the OpenAPI files.
3. Merge this pull request only when the API has been released.

Changes

we need to create templates folder to fix build.


[Feature Request] Allow to disable console logging or allow to provide custom logger

Hey!
In my Nest project I have a custom Logger implementation which is optimized for SumoLogic format. In case of errors I use my logger to print logs and @ntegral/nestjs-sentry to send error to Sentry. The problem is that lib by default also prints logs in default Nest format because of SentryService extends ConsoleLogger.
I would to have an ability to disable that default behaviour in order to keep my logs clean and without duplication.
Or, as another solution, would be great to have an ability to provide own custom logger to @ntegral/nestjs-sentry.
What do you think about that?

I was just looking to solve the same problem. It would be nice to be able to separate these concerns.

@holm for now I have a temp workaround in my project:

manually edited source code in /node_modules and simply disabled super.log, super.error etc calls inside SentryService.
created a patch using npx patch-package @ntegral/nestjs-sentry
added a post-install hook into package.json file which will run patch every time.

Definetely worth a try to fork the repo, get rid of inheritance and do a PR.

@ntegral @holm created PR for that FR, hope it looking not bad:
https://github.com/ntegral/nestjs-sentry/pull/54

Awesome. Thanks for doing that. Added a few comments on the PR, just from my perspective, although of course this is not my library at all :)

Looks like by using the instance directly, it doesn't log into the console. So using: this.sentry.instance().captureMessage() instead of this.sentry.log().


horizontal scrolling

horizontal scrolling.

it is probably happening because of this

horizontal scrolling issue resolved by hidding the overflow content of x axis


[Wasm] Pointer input is incorrect when the browser window is moved from one monitor to another with different scaling levels (on Windows)

Describe the bug
Pointer input is incorrect when the browser window is moved from one monitor to another with different scaling levels.
Reproduced on Windows, not sure about macOS and Linux.
Just like the video says:
https://github.com/JetBrains/compose-multiplatform/assets/17331698/eee90cbe-6f03-441f-b05e-2462d5334c11

0:00~0:10: Everything works on monitor 1
0:10~0:25: Pointer input is incorrect on monitor 2

(My OS language is Chinese, anyway it doesn't matter much)
Affected platforms

Web (K/Wasm) - Canvas based API

Versions

Kotlin version*: 1.9.22
Compose Multiplatform version*: 1.6.0-rc02
OS version(s)*: Windows 10
OS architecture (x86 or arm64): x86
Browser: Microsoft Edge 121.0.2277.83, and Chrome 121.0.6167.86

To Reproduce
To reproduce this bug, multiple monitors are required. Monitors should have different scaling levels. (In my case, I have two monitors, whose scaling levels are 150% and 125%)

Create a new project from https://kmp.jetbrains.com/

Add these piece of code

import androidx.compose.foundation.layout.ExperimentalLayoutApi
import androidx.compose.foundation.layout.FlowRow
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.material.MaterialTheme
import androidx.compose.material.OutlinedButton
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier

@OptIn(ExperimentalLayoutApi::class)
@Composable
fun App() {
    MaterialTheme {
        FlowRow(Modifier.fillMaxWidth()) {
            repeat(30) {
                OutlinedButton({ }) {
                    Text(it.toString())
                }
            }
        }
    }
}

Build and run wasm. Run a brower in one monitor, open the page, then move the browser to the other monitor.

Expected behavior
Pointer input should work normally.

After upgrade to compose 1.6.11 it seems to work correctly now :)

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Enderio vibrant capacitor banks only output what there receiving input is

What happens:
Vibrant capacitor banks only output what there receiving input is.
What you expected to happen:
It to output however much power is needed for the block
Steps to reproduce:

Place a full vibrant capacitor bank
Connect it to another power consuming block
See it out puting 1 iu/t

Affected Versions

EnderIO: 5.0.46
EnderCore: 5.0.59
Minecraft: 1.12.2
Forge: <IP_ADDRESS>38
SpongeForge?: no
Optifine?: yes
Single Player

Your most recent log file where the issue was present:
latest.log

how was it connected to the other block?  Directly touching it or conduit?  if conduit which one?  What was the block that was consuming power?  Was it running at the time?  If it was an ender IO machine what kind of capacitor was in it (if it wasn't a simple machine)?  How full was the machine's buffer?

The conduit is a Cryo-flux one from thermal dynamics that can carry infinite rf and it's a full vibrant capacitor bank connected to a empty one and the max output is 25,000.

can you try with one of EIO's conduits?  I understand that it will instead, be limited to the conduit's max.  The ender one being around 20k.  the Cryo ducts tend to have unusual side effects due to how they're coded.

Ok i will try that.

With ducts you WILL get feedback loops. They prefer to dump the energy back into the block they got it from instead of sending it somewhere else.

The ender conduits work with the vibrant capacitor bank at full transfer but other block still go at 1 ui/t and I have tried it on an older version of minecraft and all the blocks go at full transfer.
Im mainly trying it on the flood lights mod and thut's elevators.

Ok it seems to have fixed itself with most mods so im going to close this issue. Thanks for the help.


Created a Twitter list of apps in Podcast 2.0 land and added the list itself to the Apps page.

I also fixed a www. issue with antennapod.org (they might want to look at their website config as they probably don't have an HTTPS cert configured to allow www.).

Also - I added in a "TagLine" field which I think we should probably have as this list grows and allows apps a short space to sell their USP?
        "tagline": "Twitter list of active devs and apps for Podcasting 2.0",
I don't have the skilz to surface this in the UI @ComicStrip ?

Can you pull the latest code and merge the conflicting files? server/data/apps.json

Can you pull the latest code and merge the conflicting files? server/data/apps.json

I'm very much a beginner with Git. I'll try to figure out what I need to do.

I'm very much a beginner with Git. I'll try to figure out what I need to do.


[CSL-1059] Add update version script

I also bumped some <IP_ADDRESS> -> 0.3.0 so they all look the same.
cc @gromakovsky

I also bumped some <IP_ADDRESS> -> 0.3.0 so they all look the same.
@volhovM it doesn't make sense. After 0.4 merge it will be same everywhere. Why introduce extra conflicts?

@gromakovsky you're right to some extent, but current master is not 0.4 yet, so we don't have any merge problems.

There will be conflicts between this PR and #273. It's not a disaster, but it was unnecessary change.

Someone will have to manually resolve which is inconvenient, etc.


Public docs update (e110) - VEP

Sandbox test urls -
http://wp-np2-11.ebi.ac.uk:7070/info/docs/tools/vep/script/vep_cache.html
http://wp-np2-11.ebi.ac.uk:7070/info/docs/tools/vep/script/vep_plugins.html
http://wp-np2-11.ebi.ac.uk:7070/info/docs/tools/vep/script/vep_download.html#new

Hey @nakib103, the previous PRs were already merged. However, PR Ensembl/VEP_plugins#601 also impacts VEP plugin docs. Maybe we can wait until this is merged to update plugin docs, but tell me if you think otherwise. Thanks!

Yes, I will wait for that PR to be merged and re-generate the plugin docs.


C#: Fix NOTIFICATION_PREDELETE does not trigger ExitTree

Fix #82279
It tests okay on Windows, and it tests using the program from #78634 and Godot.exe --test pass.

Despite the title this is a core change which can have significant implication for all languages, not just C#.
What's the problem with C# specifically that wouldn't affect GDScript or GDExtension? Or is there a more generalized problem?

In C#, QueueFree doesn't trigger ExitTree,this is a serious bug for C #, but it does work in GDS.
I've been testing for a while, and so far, I haven't found this change affecting other languages.
For the functionality in PR #78634, I have tested it with the provided test cases, and they all passed the tests.

I tested again,  #78634 sorting in GDE is broken.

@Sauermann @akien-mga
I changed the implementation method, only modifying C#.
Now, the reversed postpones CallDispose until NOTIFICATION_EXIT_TREE.
can now remove the regression tag.

Possibly related issues:

https://github.com/godotengine/godot/issues/80834
https://github.com/godotengine/godot/issues/6784

csharp_script.cpp instance_create()
	return _create_instance(nullptr, 0, p_this, Object::cast_to<RefCounted>(p_this) != nullptr, unchecked_error);

Here the code shows that the RefCounted type sets base_ref_counted to true.
So in CSharpInstance::notification, the old code would not execute CSharpInstanceBridge_CallDispose.
Maybe I misunderstood the above?

So I've looked a bit more into this, and this is what I've gathered.
NOTIFICATION_PREDELETE is sent when an Object is about to be deleted (called by memdelete). Then, Node overrides _notification and when it receives that notification it removes itself from its parent, thus sending NOTIFICATION_EXIT_TREE. Both notifications are sent with p_reversed set to true.
Since NOTIFICATION_PREDELETE is sent reversed, in a hierarchy like: Object > Node > Node2D the _notification method will be called first on Node2D, then Node. This means that NOTIFICATION_EXIT_TREE will be sent after the derived classes have received NOTIFICATION_PREDELETE. So in this case Node2D cleans up before receiving NOTIFICATION_EXIT_TREE.
I can imagine this being a problem. For example, if Node2D had some state that it clears when receiving NOTIFICATION_PREDELETE, then it won't be able to use it when receiving NOTIFICATION_EXIT_TREE. This looks backwards to me, I think NOTIFICATION_PREDELETE should always be the last one. Maybe we shouldn't send notifications inside NOTIFICATION_PREDELETE.
In the case of CSharpInstance, this means it will dispose the script before Node has a chance to send NOTIFICATION_EXIT_TREE, so by the time the notification is received there's no script to send it to. We want to make sure the C# script class is disposed always after all the classes in the hierarchy have received NOTIFICATION_PREDELETE and cleaned up (to ensure Node has sent NOTIFICATION_EXIT_TREE before disposing).
The current PR implementation is not good because it relies on receiving another notification after NOTIFICATION_PREDELETE which may work for Node because we know it will send NOTIFICATION_EXIT_TREE after, but I don't think we can rely on this behavior working for every class. Also, since it disposes the script in the next notification, if there are other notifications only the first one will be received.
Maybe we could not dispose at all when receiving NOTIFICATION_PREDELETE and let the CSharpInstance destructor take care of it. But I think this is a risky change for 4.2, there may be consequences to this that I'm not able to see right now.
Alternatively, we could change Object::notification so that it calls ScriptInstance::notification always after _notificationv. This would mean for a hierarchy like Object > Node > Node2D > ScriptA > ScriptB, the notifications will be sent in the order Node2D > Node > ScriptB > ScriptA. Unfortunately, as mentioned earlier, this would reintroduce https://github.com/godotengine/godot/issues/52325.
We could also add a new notification that is sent by memdelete right after sending NOTIFICATION_PREDELETE and it would be used by CSharpInstance to dispose C# scripts, or by any other class that needs to ensure the cleanup happens after everything else. It feels weird because I think that's already the purpose of NOTIFICATION_PREDELETE, but the idea is that we wouldn't send any notifications inside the new one to ensure it really is the last notification. And this seems easier than refactoring all the existing code that uses NOTIFICATION_PREDELETE to not send notifications (like Node does now with NOTIFICATION_EXIT_TREE).

The inability to trigger "ExitTree" has already seriously affected the continued use of Godot. If the current PR's solution is not suitable, hope that others can provide a better one.


Dedupe Example Mongo DB

Example for mongo database

Hi @condorpiedra. This needs code and data that sets up the database. You also need to update the comments of the script where they refer to the mysql example.


Loader helper fixes

Just two small fixes for MessageLoaderHelper:

don't leak Context, FragmentManager and LoaderManager after detach (see #782)
check that callbacks we get actually relate to our MessageReference before processing them

d80a1d415a40241021eb70d8cae6ed539275b381


[RFC] dts: bindings: uart-controller: Add detailed flow control options

Add options to configure all hardware flow control mechanisms provided by the UART API.
This enables user to configure their desired flow control mechanism via device tree. Like the options for parity and stop bits, this one matches the enum provided by the UART API header uart_config_flow_control and can be used in a similar way.
As for the RFC: hw-flow-control should be marked as depricated but I'm not sure what the correct way would be to do so

Rebased and fixed a type. Sorry for the inconvenience @dcpleung.

Rebased

rebased

Rebased

@casparfriedrich will you be able to address @galak 's comments?

Thanks for the heads up! I'm quite busy at the moment but I I'll try. Not sure though if I add something ti this pr. I'm working on A driver that would make use of this.


Confluence upload doesn't work with vanilla markdown/wiki syntax

As it turns out, the confluence upload doesn't work with normal Markdown - the rendered output is incorrect (look below)
We need to either

use Confluence wiki syntax
use Confluence XHTML

Possible solutions already exist to convert markdown to Confluence XHTML

https://pypi.org/project/md2cf/
https://pypi.org/project/confluence.md/

Markdown uploaded
## main heading

[/Basteln]

[main#next]

### h3 heading

[main#top]

#### h4 heading

### Lists
 * some
 * bullet
   * list
 1. and
 3. some
 10. ordered
   1. with
   2. sub-items
 201. list
   * and
   * some
   * mixed

### Character Formatting

Some *bold* text.
Some _italic_ text.

### horizontal lines

horizontal
---
line

### tables

| row 1 | cell | cell | cell |
| -- | -- | -- | -- |
| row 2 | cell | cell | cell |

resulting page

using md2cf and uploading Confluence XHTML directly now produces a desired output: