User defined memory allocator for different purposes

Some issues that related with memory fragmentation, which may cause the linear memory cannot be allocated.  In WAMR, the memory managed by the system is often trivial, but linear memory usually directly allocates a large block and often remains unchanged for a long time. Their sensitivity and contribution to fragmentation are different, which is suitable for different allocation strategies. if we can control the linear memory's allocation, do not make it from system heap, the overhead of heap management might be avoided.

@dongsheng28849455 the code adds control for the behavior of both wasm_runtime_malloc and wasm_memory_enlarge, but they are not so relevant, using a flag to control them may make the source code a little strange. I guess in your application the os_mmap uses the same allocator as the allocator of wasm_runtime_malloc, but it seems you just want to control the allocation of linear memory, so is it better to redirect os_mmap to use other allocator? Or add a flag for os_mmap?

hi, @wenyongh,
I used to want to modify it in os_mmap, but from the semantics of os_mmap, it seems more suitable for scenarios that require mapping virtual memory and setting properties such as rwx for it. For the allocation that only applies to linear memory, the only available attributes currently are map_prot and map_flags, which are difficult to correspond to the purpose of memory unless a new attribute type is added.
In our current application scenario, we hope to further customize memory allocators, distinguishing between linear memory and regular runtime managed memory. Compared to os_mmp with more abstraction, a customized memory allocator seems more suitable for this user specific usage scenario.

hi, @wenyongh, I used to want to modify it in os_mmap, but from the semantics of os_mmap, it seems more suitable for scenarios that require mapping virtual memory and setting properties such as rwx for it. For the allocation that only applies to linear memory, the only available attributes currently are map_prot and map_flags, which are difficult to correspond to the purpose of memory unless a new attribute type is added.
In our current application scenario, we hope to further customize memory allocators, distinguishing between linear memory and regular runtime managed memory. Compared to os_mmp with more abstraction, a customized memory allocator seems more suitable for this user specific usage scenario.

OK, a concern is that the aot code and some aot data sections are also allocated by os_mmap, will they cause memory fragmentation?

OK, a concern is that the aot code and some aot data sections are also allocated by os_mmap, will they cause memory fragmentation?

The feature's purpose is not to eliminate the memory fragmentation, it's focuses on processing linear memory separately from system normal heap. so as reduce the probability of being unable to allocate in the pool when fragmentation exists.

OK, a concern is that the aot code and some aot data sections are also allocated by os_mmap, will they cause memory fragmentation?

The feature's purpose is not to eliminate the memory fragmentation, it's focus on processing linear memory separately from system normal heap. so as reduce the probability of being unable to allocate in the pool when fragmentation exists.

OK, thanks.

@dongsheng28849455 Could add essential document to docs instead leave them in commit message? It's not easy for end user to fetch these informations.

@dongsheng28849455 Could add essential document to docs instead leave them in commit message? It's not easy for end user to fetch these informations.

good point, I have added some info in the doc:
user-defined-linear-memory-allocator


7 add detailed info page

Partly resolves #7

Current dependencies on/for this PR:

main

PR #9

PR #15
PR #10

PR #12

PR #13

PR #16

PR #18

PR #19

PR #20

Current dependencies on/for this PR:

main

PR #9

PR #15
PR #10

PR #12

PR #13

PR #16

PR #18

PR #19

PR #20


fix(sec): upgrade org.apache.cxf:cxf-rt-transports-http to 3.5.5

What happened？
There are 1 security vulnerabilities found in org.apache.cxf:cxf-rt-transports-http 3.0.16

CVE-2018-8039

What did I do？
Upgrade org.apache.cxf:cxf-rt-transports-http from 3.0.16 to 3.5.5 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How can we automate the detection of these types of issues?
By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.
The specification of the pull request
PR Specification from OSCS

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Plugin dependencies only affect tests. There is no security impact.

Plugin dependencies only affect tests. There is no security impact.

Plugin dependencies only affect tests. There is no security impact.


Non text files and large file upload with chunking is not working with AWS V4 auth.

After the change in auth from V2 to V4 text files are getting uploaded. Any other file type is getting uploaded but the uploaded content is corrupt.
Files larger than 5MB (current chunk size) do not get uploaded. The browser starts reading the file and after a while it crashes.

This will get fixed in PR #335

Closing since #335 is merged and this now works.


How do I test next/link using Jest? I get an error in Link.prefetch

[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Links can be used in tests that are run with Jest.
Current Behavior

 at throwIfNoRouter (node_modules/next/dist/lib/router/index.js:107:11)
      at Object.SingletonRouter.(anonymous function) [as prefetch] (node_modules/next/dist/lib/router/index.js:69:5)
      at Link.prefetch (node_modules/next/dist/lib/link.js:143:24)
      at Link.componentDidMount (node_modules/next/dist/lib/link.js:148:12)
      at commitLifeCycles (node_modules/react-dom/cjs/react-dom.development.js:8770:24)
      at commitAllLifeCycles (node_modules/react-dom/cjs/react-dom.development.js:9946:9)

Steps to Reproduce (for bugs)

"next": "^5.0.1-canary.15",

Create a component with a render method like that returns: (partial):

import Link from 'next/link';
...
render() {
...
    return (

{messages.LABEL}

                <Link prefetch href={messages.LINK1_URL || ''}>
                  {messages.LINK1_LABEL || ''}
                </Link>

3.
import React from 'react';
import Enzyme from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';
import enzymify from 'expect-enzyme';
import IndexPage from '../../pages/index';

const {shallow, mount} = Enzyme;
Enzyme.configure({adapter: new Adapter()});

describe('Index', () => {
  it('Renders', () => {
    const messages = {
        LABEL: 'Maguffin'
    };

    const indexPage = mount(
      <IndexPage
        country="us"
        language="en"
        path="/"
        messageBases={messages}
      />
    );

 jest -t Index

Context
I'm trying to write a Jest test for a page that has a next/link on it.
Your Environment

Tech
Version

next
^5.0.1-canary.15

node
9

OS
OSX 10.12

browser
n/a

etc

I've been using something like this to avoid that error:
jest.mock("next/link", () => {
    return ({children}) => {
        return children;
    }
});

Not sure if it would be feasible for next to detect that process.env = "test", and skip prefetch ?

So I added
import * as jest from 'jest';

jest.mock("next/link", () => {
  return ({children}) => {
    return children;
  }
});

before my describe call and that fixed it.
Thanks so much!


clone fails due to IO error

@rultor release, tag is 0.5.9

@rultor release, tag is 0.5.9

@yegor256 Done! FYI, the full log is here (took me 7min)


cmd: Add --track flag to deployment commands

Description

Adds the --track flag and resource tracking after a plan change to the
deployment subcommands which incur plan changes: create, update and
shutdown.
Related Issues

Resolves #78
How Has This Been Tested?

Manually
Types of Changes

[x] New feature (non-breaking change which adds functionality)

I'll rebase after #79 is merged to use the common function introduced there.


Azure: Dapr fails to obtain the authentication token when using Managed Identity of Azure Web App

In what area(s)?

/area runtime

What version of Dapr?

1.11.0

Expected Behavior
On startup of the sidecar Dapr will get the authentication token using System Assigned Managed Identity of the Azure Web App and generate components that will communicate with Azure services.
Actual Behavior
Fails to obtain the auth token:
level=fatal msg="process component binding-azure-storage-my-component error: [INIT_COMPONENT_FAILURE]: initialization error occurred for binding-azure-storage-my-component (bindings.azure.blobstorage/v1): failed to create Azure Storage container myContainer: ChainedTokenCredential: failed to acquire a token.\nAttempted credentials:\n\tmanaged identity\n\tAzureCLICredential: Azure CLI not found on path" app_id="$Default" instance=<redacted> scope=dapr.runtime type=log ver=1.11.0
After encountering this error I tried to have workaround by installing the Azure CLI in the docker image of the Azure Web App, but then Dapr times out when creating the component:
level=fatal msg="process component biding-azure-storage-my-component error: [INIT_COMPONENT_FAILURE]: initialization error occurred for biding-azure-storage-my-component (bindings.azure.blobstorage/v1): init timeout for component biding-azure-storage-my-component exceeded after 5s" app_id="$Default" instance=<redacted> scope=dapr.runtime type=log ver=1.11.0
Steps to Reproduce the Problem

Create an Azure Web App with System Assigned Managed Identity.
Build a docker image with your app and Dapr.
Inject Dapr component to the Web App, make sure that this component will use System Assigned Managed Identities to authenticate in Azure e.g.:
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: binding-azure-storage-my-component
  namespace: default
spec:
  type: bindings.azure.blobstorage
  version: v1
  metadata:
  - name: storageAccount
    value: <storageAccountName>
  - name: container
    value: <containerName>

Start the application.
*Issue is not existing in the previous Dapr version (1.10.7).
Release Note

RELEASE NOTE: FIX Dapr to obtain authentication token when using Managed Identity of Azure Web App.

Maybe the timeout needs to be increased here: https://github.com/dapr/components-contrib/blob/master/internal/authentication/azure/auth.go
Or we have to look into how to proceed even if the Azure CLI returns an error.
This only impacts slow environments where the MSI endpoint responds slowly.
If the CLI is not available it should actually retry MSI again. I'll take a look at why that isn't occurring. May need some help from the Azure SDK team here as I am largely limited by their SDK.

I am not 100% sure as this started happening since 1.11.0 and was fine in 1.10.7. Did something change at the MSI side of things making it respond more slowly now?

I am not 100% sure as this started happening since 1.11.0 and was fine in 1.10.7. Did something change at the MSI side of things making it respond more slowly now?

In 1.11 we added support for Workload Identity and Azure CLI Credential. As part of this we standardized our implementation to match the DefaultAzureCredential implementation from the official Azure SDK for Go / Azure Identity SDK.
In that implementation a default Managed Identity time out of 1 second is used so that quick fall-through to the CLI credential is possible. However, it appears that in App Service 1 second is insufficient.
Removing the timeout completely breaks the use of the CLI credential has the MSI attempt would hang indefinitely.
Of course increasing the timeout is a bad experience for local development, and arbitrary running in App Service too.
I have now come up with a solution that disables the timeout only in an environment which appears to be using certain managed identity mechanisms.

For reference, here is the managed identity client code from the default azure credential in the official Azure SDK for Go:
https://github.com/Azure/azure-sdk-for-go/blob/fb99a64943cb1d4594ce1e1bc0c0feeb90d083a8/sdk/azidentity/default_azure_credential.go#L102-L108

Fixed in the release-1.11 branch by #2916


New VSCode doesnt recognize textmate scope for params/args inside the function

Does this issue occur when all extensions are disabled?: Yes/No
yes

VS Code Version: 1.63.1 (user setup)
Commit: fe719cd3e5825bf14e14182fddeb88ee8daf044f
Date: 2021-12-14T02:13:54.292Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS Version: Windows_NT x64 10.0.19042
Steps to Reproduce:
after updating vscode, my params/args inside functions are no longer the color of the argument itself because the textmate scope for them was removed perhaps? in the screenshot you can see the arguments in the function are colored properly (in magenta) since they have textmate scope of variable.parameter.js, but inside the function they are no longer considered params like in last version

Also the the semantic token section (turned on if "semanticHighlighting": true,) no longer shows for me in the inspect tool, and consequently its set colors no longer work either

139220 Sent from Mail for Windows From: TamirCodeSent: Wednesday, December 15, 2021 10:48 PMTo: microsoft/vscodeCc: SubscribedSubject: Re: [microsoft/vscode] New VSCode doesnt recognize textmate scope for params/args inside the function (Issue #139220) Also the the semantic token section (turned on if "semanticHighlighting": true,) no longer shows for me in the inspect tool, and consequently its set colors no longer work either—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

even worse, here it colors a normal variable as a parameter

after restarting vscode it seems to have fixed all the above issues however it still has bugs for example the else keyword is sometimes not giving the proper scope. but ill give it a few more days of playing around to see if i still have issues


Updated panda description

This PR updates the panda description & moveit config. Before this, the collision geometry is a cylinder/sphere encasing the hand. The collision area might be too big and the panda hand could not get close to certain object (for example, when we want the robot to grasp a can). Most of the files are copied from moveit_resources package.
https://github.com/ros-planning/moveit_resources/tree/master/panda_description
https://github.com/ros-planning/moveit_resources/tree/master/panda_moveit_config

Please double check which files are still needed in the description (the xacro URDF/SRDF files in particular). Remove them if they are no longer needed. Also, please open a pull to update resources_visualization.cpp in the main Robowflex library so the script properly loads the Panda. Also double check which geometry files (the new STLs + the modifications to the existing DAE) are required.

Thx for the reminder! I just deleted the unused xacro urdf/srdf and also updated the panda.yml file.

this is screenshots of running rosrun robowflex_library resources_visualization panda


Multiple instances, meta data, control of the iOS device, album art

Does shairport support multiple instances?  If not, any workaround to this?  What about with virtual machines?  And why not?

Does shairport have access to meta data - album/artist/song/duration?

Can shairport be used to control the iOS device that's sending music to it - example play/pause/skip/back/rew/ff/browse?

Can shairport be used to get album art?

As far as I understand it, shairport emulates the AirPlay protocol, which is purely for audio (and now video) transport. Therefore, the client (AirPort receiver/shairport) is set up as no more than an audio receiver using the Remote Audio Output Protocol. You can read more here: http://en.wikipedia.org/wiki/AirPlay#Protocols.


build: bump version to 1.1.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.30%. Comparing base (d51cab4) to head (106e6fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   24.30%   24.30%
=======================================
  Files          78       78
  Lines        6800     6800
=======================================
  Hits         1653     1653
  Misses       5147     5147

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Alert Policy for KubeArmor

Feature Request
As a User I want an alert
when

ppid = 0
tty != null

Is your feature request related to a problem? Please describe the use case.
As a User I want to identify kubectl exec calls
Describe the solution you'd like
TBD

/assign @Ayush9026 i will solve this issue.

/assign

@daemon1024 shoudn't the PPID=1, as the container entrypoint process (pid=1 wrt the container) starts the kubectl exec process?


Overlay tracks the wrong window

Sometimes when the overlay starts it is a 1 pixel tall window instead of correctly covering the game
Might be using EnumWindowsProc wrong:
https://github.com/Scaless/HaloTAS/blob/d2588b64f2988f4c872ced79f4a298075aafcc56/HaloTAS/TASDLL/main.cpp#L47

There's now a callback that handles this more effectively here:
https://github.com/Scaless/HaloTAS/blob/master/HaloTAS/TASDLL/halo_engine.cpp#L5


Porcupine Issue:

Have you checked the docs and existing issues?

[X] I have read all of the relevant Picovoice Porcupine docs
[X] I have searched the existing issues for Porcupine

SDK
React
Porcupine package version
3.0.3
Framework version
React
Platform
Web (WASM)
OS/Browser version
mac os
Describe the bug
Here is my code
import model from './lib/model_file.js'
import keyword from './lib/hello-ravi_en_wasm_v3_0_0/keyword_file.js'

console.log(model);
console.log(keyword);
const porcupineKeyword = {
  // publicPath: "./lib/hello-ravi_en_wasm_v3_0_0/alexa_wasm.ppn",
  base64: keyword,
  label: "alexa"
}

const porcupineModel = {
  // publicPath: "./lib/porcupine_params.pv",
  base64: model
}

...

const initEngine = useCallback(async () => {
    console.log(BuiltInKeyword);
    await init(
      "jPTQx+....",
      [porcupineKeyword],
      porcupineModel
    );
  }, [])

Here is my react package:
"@picovoice/porcupine-react": "^3.0.3",
"@picovoice/web-voice-processor": "^4.0.8",

I am getting this error
PorcupineInvalidArgumentError: Initialization failed: [0] Keyword file (.ppn) file has incorrect format or belongs to a different platform. [1] Picovoice Error (code 00000136) [2] Loading keyword file at alexafailed withINVALID_ARGUMENT.
Wasted a whole day to get the demo up and running but i am unable to. Any help would be awesome.
Steps To Reproduce

Download the react demo folder
train a wake word on console
run the demo with the files and api keys

Expected Behavior
The demo should have run smoothly.

hey mohsintariq, two questions:

is the original react demo working for you?
it looks like you're trying to use the base64 version of the model and keyword. Could you provide the exact steps you took to create these files?


Refactor split valuation kernel

Increases split evaluation kernel throughput on my V100 from 150 GB/s to 400 GB/s.
These gains come from:

using cuda fast division operations
avoiding shared memory broadcasts, instead using warp shuffle.
not computing parents gain for every possible split (this is constant per node)

The fastest possible throughput I have achieved is 700 GB/s, however it becomes a little complicated to get this fast. Current version I think is fast enough, placing the bottleneck entirely on histogram computation.

Depth 8 benchmarks:

dataset
master
eval

airline
90.88661192
89.93374479

bosch
12.88504644
12.46627029

covtype
18.01187677
17.60098921

epsilon
46.48386218
43.91058178

fraud
1.315704659
1.237399099

higgs
17.19260674
17.27932671

year
7.047273015
6.841409724


Update Docs on Setup for using Docker on Windows

Thanks! We didn't have any windows users on our team, but this will be helpful for others who want to use the pipeline.
Can I ask, mostly just out of curiosity what you are interested in using the data/pipeline for? We are always looking for interesting collaborations!

Hi! So I honestly was just lazy and didn't use Linux for this since I had Windows set up on my work machine. But I thought it would be helpful for other Windows users! :) So we are currently doing a hack at work just to see how we can improve on the tool you all have built such as identifying ways to help onboard new cities, process the raw data quicker, etc.
For the hack our larger goal was to explore ways to make law enforcement and 911 data more transparent and insightful to help drive community-based reforms. Since we only have about a week for this, we decided to focus on:

Provide a recommendation on how to automate the data mapping and categorization of 911 data
Add a new city to the existing 911 data and see if there's any optimizations that can be done to make this quicker and easier for new users


Issues with reading PNG and JPG files

I recently deployed Chat with Your Data and have been uploading various file types to the Admin UI. I'm encountering challenges with PNG, JPEG and MD files. Some are being ingested successfully, others are not, despite all containing text. For instance, I saved a file as both .PNG and .JPG. The .JPG file uploads without issue, but the .PNG file does not. Although all files appear in the storage account, those that are not working do not show up in the "explore data" dropdown, and I can't retrieve any information from them. All the images I tested are read correctly in document intelligence studio. Additionally, I can upload an MD file without any errors, but it too does not appear in the "explore data" dropdown.

Hi @veronicahorgan - As part of the deployment, there is an Azure Workbook. Were any errors displayed on any of the tabs?

Hi @veronicahorgan - We have fixed as part of 1170 & 1172. Please retry and let us know if any issue. Thanks

Closing this issue.


simple 'Ambiguous occurrence' error crashes build

I get this error when installing sevant-purescript.
src\Servant\PureScript.hs:248:9:
    Ambiguous occurrence `List'
    It could refer to either `Control.Lens.List',
                             imported from `Control.Lens' at src\Servant\PureScript.hs:14:1-29
                             (and originally defined in `Control.Lens.Iso')
                          or `Servant.JQuery.List',
                             imported from `Servant.JQuery' at src\Servant\PureScript.hs:19:1-31
                             (and originally defined in `servant-jquery-<IP_ADDRESS>:Servant.JQuery.Internal')
cabal: Error: some packages failed to install:
servant-purescript-0.0.1 failed during the building phase. The exception was:
ExitFailure 1

Hi,
Anchor is no longer actively maintaining this code. I believe the servant project may be adopting and taking over maintainership (see https://github.com/haskell-servant/servant/issues/268), although they are yet to publish code to their repo.
In any case, Anchor will not be taking any further action to resolve this issue.


insertion and deletion in singly, doubly and circular linked list at beginning, end and index position

@Arisha2902 fir se tag krna bhul gayi tu -_-

@Anuraj-IND ,thanks for help

@Anuraj-IND ,thanks for help

Um who were you again ?

Thanks sir , for helping me


Turfs

Turf war paused message is spamming..

Hello CubicDEVs,
What turf war pause message? If it is something that isn't a bug, you're more than welcome to edit the turf script to remove the messages.

if ( isOwnerInTurf and isGangInTurf ) then
exports.NGGroups:outputGroupMessage ( "The turf war in "..getZoneName ( x,y,z )..", "..getZoneName ( x,y,z, true ).." is paused due to both gangs in the turf", turfLocs[id].attackers, 255, 255, 255 )
exports.NGGroups:outputGroupMessage ( "The turf war in "..getZoneName ( x,y,z )..", "..getZoneName ( x,y,z, true ).." is paused due to both gangs in the turf", turfLocs[id].owner, 255, 255, 255 )
This message is spamming till the "paused situation" is gone (on killing other gang player) till that its spamming the whole chat


fix the incorrect cli command

semantic-release setup will not work:
$ semantic-release setup

  Usage: semantic-release [options]

  Run automated package publishing

  Options:

    -b, --branch <branch>                Branch to release from
    -r, --repositoryUrl <repositoryUrl>  Git repository URL
    --verify-conditions <paths>          Comma separated list of paths or packages name for the verifyConditions plugin(s)
    --get-last-release <path>            Path or package name for the getLastRelease plugin
    --analyze-commits <path>             Path or package name for the analyzeCommits plugin
    --verify-release <paths>             Comma separated list of paths or packages name for the verifyRelease plugin(s)
    --generate-notes <path>              Path or package name for the generateNotes plugin
    --publish <paths>                    Comma separated list of paths or packages name for the publish plugin(s)
    --debug                              Output debugging information
    -d, --dry-run                        Dry-run mode, skipping verifyConditions, publishing and release, printing next version and release notes
    -h, --help                           output usage information

semantic-release-cli setup works:
$ semantic-release-cli setup
? What is your npm registry?

Coverage remained the same at 100.0% when pulling e5e62923bd9864f2ea7848437009e1a5d10082ba on winguse:patch-1 into c72d3a82f5a5bcf038539ae0b1b6d91940ace97b on alexjoverm:master.


[Bug] misc errors with the add a new word feature

adding a new word is buggy as previous input (when the console was busy) would get tagged along with the input, causing mistyped insertions.
also, the shift / control key would remain depressed after insertion, which further causes issues.
as it is now it is more convenient to just edit the file directly and then reload the application.

adding words will be more important as the frequency dictionary comes into play, as users may not know what frequency to use with their new words.


OPCACHE_MAX_FILES only 4000

In the standard SCL PHP 7.3 runtime, max accelerated files is set to 4000 and hardcoded.
Need to override and set to 10000.

Have created PR to allow customization: https://github.com/sclorg/s2i-php-container/pull/310


Feature/adm 272

What type of PR is this?
fix
What this PR does / why we need it:
Adds getBatch & deleteBatch methods
Add final adjustments & refactors
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., usage docs, etc.:

:tada: This PR is included in version 1.6.0-rc.7 :tada:
The release is available on:

npm package (@rc dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Readthedocs ordered list HTML bug

In the recent push to 0.4.2, readthedocs is having issues rendering some of the example notebooks.  In particular, the problem happens at the <ol> ordered list, which renders as a code block instead of an ordered list.
It looks like this:

Instead of this:

This appears to be correct for the latest release 0.4.3


Moving GI and Sky code from RendererSceneRenderRD into separate classes

This will take a few days to complete but Reduz asked us to see if we could move the GI and Sky shader code into separate classes to make it easier to maintain.
It was originally planned to do these as two separate PRs but seeing there were a bunch of links between the two I've done both together.
Anyway the approach I'm taking here is following the following steps:

Move all data into a class making all members public for now, change the code in RendererSceneRenderRD to point to the new class but keep the methods unchanged otherwise (finished for GI).
Start moving methods related to GI from RendererSceneRenderRD into RendererSceneGIRD and adjust them where needed (in progress)
Evaluate members that should be private and make them private, further tidy up work (might do this in separate PRs)

Pretty much finished the first pass of moving all data and code into RendererSceneGIRD. There are a few things left in RendererSceneRenderForward that may need to move.
Also I haven't done much in changing the code so there are some weird dependencies here and there. That should be cleaned up as time goes by.
Working on extracting skyshader at the moment.

Note - currently broken, something in the changes of project settings broke sky, commiting to get more eyes on it :)

I've removed the draft status. While I think there is room for improvement I think the initial goal has been met.
We can start improving on this as we start sharing code between a low end (mobile) and high end vulkan renderer

I have only reviewed the Sky stuff so far. I think we need to make some more changes to untie Sky from SceneRender a little bit more. Needing to access the singleton and pass in the instance of SceneRender is a little bit gross and I'm sure we can improve it a little bit. Maybe if the relationship is changed to be more like the relationship between SceneRender and Storage?

The problem I've been having is that it calls back into the rendering code and I'm unsure about how much we can or can't move into the sky class (same with GI). My gut feeling says we should move more but this would also require a number of data variables that are currently in the render buffer struct into the Sky struct.
Ideally I wouldn't want to pass SceneRender at all.
The GI code is worse here btw, the Sky code was pretty clean to begin with. GI jumps around alot more.

After talking to @clayjohn we are going to split out environment into its own class so we can more easily send pointers to sky and GI instead of calling back into the render class.
I'm trying to remove all the dependencies in these two classes where we need to send it a pointer to the render class

@reduz @clayjohn @JFonS I think I'm pretty much at the end of this. There are still a few places where Sky and GI have to call back into the forward renderer and there is that ugly singleton access in setting up the shader. Those were always working that way so not a fault of this PR.
There might be a little bit more cleanup possible by looking at unused methods now that I've moved environment settings into a class that is accessible thats just nitpicking.

I'm not super happy with the callbacks into RenderSceneRenderRD.

Neither am I but most are gone and they were there to begin with, sortof.
I think this can be improved but it will take gaining a little more experience. The same btw with everything now being public members, seeing these classes are internal anyway I think thats a good start but in the long term we need to evaluate which member can and should become private

Other than the comment I left on the weird singleton access, I went over the code and all looks good.
I agree it would be best to completely separate the classes from RenderSceneRenderRD but it can be done in the future.

yeah my take on it is that this has already been a huge undertaking. Best to do things in steps. I think a lot will become clearer once we do the mobile renderer and see how all these things end up working together.

It looks OK to me! I am thinking that RendererSceneRenderFoward maybe should be a a separate, virtual class implementing a renderer instead of inheriting RendererSceneRender, but I am unsure how it would look.

It looks OK to me! I am thinking that RendererSceneRenderFoward maybe should be a a separate, virtual class implementing a renderer instead of inheriting RendererSceneRender, but I am unsure how it would look.

Let me know which of your remarks you'd like me to do before merging and I'll pick them up tomorrow. Else I suggest we merge this monster and deal with additional cleanup in smaller PRs :)

Thanks!


[IO-808] better handling when source is unexpectedly deleted during move

@garydgregory I think this is roughly what's required to address IO-808. Inlining the various validations makes the flow much more obvious and avoids double null checks.
There's no way I know to lock an file so it can't be deleted after we check that it exists and before we move it, but given that we can distinguish between source files that don't exist and ones that are deleted later. The key is to do the exists check after the file type check. Not obvious in the PR, but this is the reverse of how the checks were performed previously.
Now if the source file is a directory an IllegalArgumentException is still thrown. However the new feature is that in all cases where the method fails because the source file doesn't exist an IOException is thrown, no matter whether the source file was deleted while the method was executing.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9bcaf43) 86.24% compared to head (6391f48) 86.25%.

:exclamation: Current head 6391f48 differs from pull request most recent head 27fecb3. Consider uploading reports for the commit 27fecb3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #527   +/-   ##
=========================================
  Coverage     86.24%   86.25%
- Complexity     3437     3440    +3
=========================================
  Files           229      229
  Lines          8159     8164    +5
  Branches        959      962    +3
=========================================
+ Hits           7037     7042    +5
  Misses          839      839
  Partials        283      283

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Incorrect WAVE results recorded

The following test case results are incorrectly coded as "Not found" for WAVE (my comments in parentheses):

Large text does not have a contrast ratio of at least 3:1 so does not meet AA (you must select the Contrast tab in WAVE to see these identified)
Large text does not have a contrast ratio of at least 4.5:1 so does not meet AAA (you must select the Contrast tab in WAVE to see these identified)
html element is missing a lang attribute (identified at top of the page)
Missing page title (identified at top of the page)
Missing H1 (identified at top of the page)
Table with column headers and double row headers (WAVE alerts to the presence of the headers)
Links to a sound file, no transcript (WAVE identifies the media link with documentation to verify transcript)
Empty label found

All of these cases are clearly identified by WAVE and should be corrected in the results and the summary descriptions/blog post.

Hey @jared-w-smith !
Thanks for the report, we'll try and address this as soon as possible.
In the meantime feel free to open a pull request if you want. 👍
Thanks again 😸


REPL fixes and improvements

Summary
Sorry for the second pull request. I just discovered a bug and some other opportunities for improvements, so I wanted to get some changes in. Everything is mainly about when and how to close tabs.
Changes

Bug fix: opening a repl while one was already open in the second row got rid of the layout and reverted to a single-cell layout due to the close event. The intended behavior is to keep the row there, close the existing repl, and open a new one in its place. To fix this, change the setting to avoid running the close event during the Open REPL command.
Only close repl tabs in the second row, ignore other files
Only remove second row if repl is still in that group on close
Put new repl in same spot as old repl if one exists, in case there were multiple files in the group

Thanks for the fixes. Regarding the opening a RELP if one already exsits, I think that a new REPL should open in another tab. This would mimic the behavior or SublimeREPL.

Also, I think we should default to Python syntax in the REPL rather than plaintext. This would also be the same behavior as SublimeREPL.

Another thing is that the Packages portion of the syntax selection should be a part of the path in the file. That way the user only needs to write Text/Plain text.tmLanguage or Python/Python.tmLanguage. Or, you could simply let the user chose plaintext or python and select the corresponding syntax accordingly.

I noticed another bug. If you have a file open and repl open on the bottom row from a previous session, when opening a new file, the file opens in the second row. It should open in the first row.

Thanks for the notes. For your last comment, I think that's default sublime behavior. When I have a repl open, if my focus is on the main file and I open a new file, it shows up in the top row, but if I open a file while my focus is in the bottom row repl, the file opens in the bottom row. Sublime opens files in the group where your focus is I'm pretty sure. Is this what you're experiencing? Or are you saying it opens new files in the second row no matter where your focus is?

You're right, it's based on focus so don't worry about it. :)

Thanks for taking the time to make the changes. One last thing I forgot to mention is that the new repl settings in the settings file should come after the pythonw setting. As we add new settings they appear last in the file.

Thanks @gseastream for all your work on this!


Docker compose create script fails

Description
Following the documentation here, I'm getting an unexpected log output while patching the docker-compose.yaml file:
patch: **** '<' followed by space or tab expected at line 16 of patch
Full output:
~/TSN-Testbench/docker/mqtt-composer$ ./create_docker_compose.sh
Cloning into 'docker-compose-mosquitto-influxdb-telegraf-grafana'...
remote: Enumerating objects: 19, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 19 (delta 2), reused 2 (delta 2), pack-reused 11 (from 1)
Receiving objects: 100% (19/19), 8.45 KiB | 2.82 MiB/s, done.
Resolving deltas: 100% (4/4), done.
~/TSN-Testbench/docker/mqtt-composer/docker-compose-mosquitto-influxdb-telegraf-grafana ~/TSN-Testbench/docker/mqtt-composer
Note: switching to '1f873f2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1f873f2 Merge pull request #1 from akaJuliaan/master
patching file docker-compose.yml
patch: **** '<' followed by space or tab expected at line 16 of patch
~/TSN-Testbench/docker/mqtt-composer

Background Information / Reproduction Steps
To reproduce run the create_docker_compose.sh script.
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 12 (bookworm)
Release:	12
Codename:	bookworm

$ uname -a
Linux debian12-vm-a 6.1.0-28-rt-amd64 #1 SMP PREEMPT_RT Debian 6.1.119-1 (2024-11-22) x86_64 GNU/Linux

Checklist
Please provide the following information:

[ ] Hardware and NIC(s) being used
[ ] Configuration files being used
[x] Linux kernel version being used
[x] Linux distribution being used

Thanks, I know what went wrong. I'll fix it soon.


on location not being called when app has been forcefully killed (android)

When I have my react native app open and the location updates, BackgroundGeolocation.on('location' get's called fine, but when I forcefully kill the app, it is no longer called.
I am running with debug mode on, so I can see that the plugin is still getting updates (toasts and sounds are being activated)
Your Environment

Plugin version: 0.4.1
Platform: Android
OS version: 4.3 and 7.1.1
Device manufacturer and model: Samsung Galaxy S3 and Nexus 5 (emulated)
React Native version: 0.52.0
Plugin configuration options:
locationProvider: BackgroundGeolocation.DISTANCE_FILTER_PROVIDER,
desiredAccuracy: 100,
stationaryRadius: 1,
debug: true,
distanceFilter: 1,
stopOnTerminate: false,
startOnBoot: true,
interval: 1000,
fastestInterval: 1000,
activitiesInterval: 1000,
stopOnStillActivity: false,
startForeground: false
Link to your project: No

Context
When I have my react native app open and the location updates, BackgroundGeolocation.on('location' get's called fine, but when I forcefully kill the app, it is no longer called.
I am running with debug mode on, so I can see that the plugin is still getting updates (toasts and sounds are being activated)
Expected Behavior
The on location function get's called even after the app is forcefully terminated
Actual Behavior
The on location function does not get called after the app is forcefully terminated
Possible Fix
Recreate React Native context if it is not present when a location update is registered
Steps to Reproduce

Install and configure plugin in React Native app (plugin debug: true)
Launch App
See location updates and on location being called
Forcefully kill app
See debug toasts and sounds but on location not being called

Context
I am trying to periodically track user's location even if app is forcefully killed by user
Debug logs
Lot's of the following, can provide more logs upon request
2-03 13:07:38.171 27474-27497/com.myapp D/com.tenforwardconsulting.bgloc.DistanceFilterLocationProvider: Location change: Location[gps -26,095993,28,025247 acc=6 et=+1d17h34m30s646ms alt=1538.010931396014 vel=0.0 {Bundle[mParcelledData.dataSize=44]}] isMoving=true
02-03 13:07:38.241 27474-27497/com.myapp D/com.marianhello.bgloc.LocationService: New location BGLocation[gps -26,095993,28,025247 id=null acc=6 t=1517656057999 et=+1d17h34m30s646ms alt=1538.010931396014 vel=0.0 {Bundle[mParcelledData.dataSize=44]} locprov=0]
02-03 13:07:38.336 27474-27497/com.myapp D/com.marianhello.bgloc.LocationService: Persisted location: BGLocation[gps -26,095993,28,025247 id=62 acc=6 t=1517656057999 et=+1d17h34m30s646ms alt=1538.010931396014 vel=0.0 {Bundle[mParcelledData.dataSize=44]} locprov=0]

This is normal behaviour. When you kill app there also js callback are destroyed. You need to set options url or `syncUrl to send locations to your server.

Just being curious here @mauron85: so when I reboot my phone this won't work either right?

@tugorez you mean reboot with option startOnBoot: true? if so, then answer is yes, it won't work. App (activity) must be running to receive location events.

@mauron85 thank you very much for your quick answer.

@mauron85 is there any possible way to listen to location events even after the app is killed from the background

@GrishmaM on Android using headless task only. https://github.com/mauron85/react-native-background-geolocation#android-headless-task-experimental

@GrishmaM thank you for the above info, I'm facing one more issue
In Android when the app is running in background location event is nor rasing, it works only in forground


Explore/document source map support for raven-node/Node projects

e.g. for users using TypeScript, CoffeeScript, Babel, etc.

See also getsentry/sentry/issues/2632

See also: https://github.com/evanw/node-source-map-support

Would love to see this added. I am using Babel with node and this would help tremendously trying to track down node-sentry errors. FYI I currently inline my node sourcemap, but do not have to do that. Not sure if that is helpful information.

Would like to see this as well. We run an isomorphic react app and because the client is webpacked with file-loader for generating asset hashed filenames, the easiest thing to do is just webpack the server before deployment.
Just verified 2.1.0 fixed the issue so that errors can be reported now, but source map support would make them much more useful.
Really neat service so far.

I'm using Webpack with the devtools: source-map option and load my source maps using source-map-support explicitly, i.e. just like this:
"use strict";
require("source-map-support").install();

// ... regular javascript code ...

This does indeed work well. For some reason Raven/Sentry isn't able to show the source code itself, but the file names and line numbers are correct. Not sure why this isn't working but due to this I actually switched to devtools: nosources-source-map to save a couple of Kbytes in my upload. But the results are the same. It works fine and gives me accurate call stack information.


Decide on architecture for complex relations

This is a critical issue as its design choice will have lasting impacts on our deeper architecture.
We often have the need to model complex relations - i.e. where a relation between several entities has attributes on its own.
As we have discussed, there are two ways to do this:
option A: subclassing triples.
We could create subclasses of triples by defining them in a respective apis-ontology. We would need to refactore the UI layer to be adaptable to this by checking for subclasses of given relations. The advantage of this approach would be in it being closer to classical ERM and hence to django and SQL. Slightly increased performance probably too compared to the other approach.
option B: reficiated properties
This approach would align closer with RDF modelling and hence any apis ontology defined this way can be serialized and deserialized to pure RDF in a more straightforward manner than with the other approach. The downside of this would be slightly decrease performance - probably - as more triples are needed to model complex relations and with that more joins.
Either way: the UI obviously needs to adapt in a such a way that once there is some kind of complex relation, all the necessary data of such a relation is delivered in one view, saving the user from clicking through a more complex RDF path.

Reification was implemented in https://github.com/acdh-oeaw/apis-core-rdf/commit/e8bb50a17eb108f9427cd77c5fed156b570da8df
The implementation effort of it was probably the same as subclassing would have been, because most work was spent not into the underlying DB architecture, but into the dynamic form and tables via ajax ( https://github.com/acdh-oeaw/apis-core-rdf/issues/70 ).
Also Subclassing would have introduced a bulk of problems such as the question on how to correlate them correctly with properties and also how to define cases when there would be a need for multiple relations.
Reifications are a cleaner solution with the added advantage of being more rdf-y.


LogstashFormatter record[level_name] is is mapped to message[level], record[level] is not mapped at all

Shouldn't a mapping from monolog-record to logstash-message be as accurate as possible?
// ...
if (isset($record['level_name'])) {
    $message['level_name'] = $record['level_name'];
}
if (isset($record['level'])) {
    $message['level'] = $record['level'];
}
// ...

At the moment the content of $record['level_name'] is just written to $message['level']. IMHO this might be a little misleading because most loggin-systems consider level an interger and level_name a human-readable string.

This was done when logstash V1 was added, before we used the level alone for V0.. I guess the problem is that while a lot of systems treat levels as integers, the exact numbers used vary. Names are at least non ambiguous. And well changing this at this point would break things for existing users that built tooling around these messages, so not sure it's worth it..

Concerning existing solutions, you're right of course.
Maybe it would be an option to just map the (int)$record[level] to some extra field in $message so that this value is at least present in the message, too.

Sure that'd be an option.

How can I add a pull-request?

https://help.github.com/articles/creating-a-pull-request/


can you add a demo to show how to use this napari-3d-ortho-viewer

I have spent a long time and still didn't figure it out how to call this plugin. Btw when I tryied to use napari_plugin_manager.register(napari_3d_ortho_viewer, name="3D Ortho viewer") and it says napari_plugin_manager doesn't contain register function. It is very confusing.

hi there,
does this help?
https://github.com/gatoniel/napari-3d-ortho-viewer/assets/40384506/4296dc11-ea37-40a0-8b17-eeb77480672f
Also, maybe you need to download a newer version of the plugin for newer napari versions. It will come soon.

Please install version 0.1.5 in case you have troubles reproducing the above video.

There was no further user request / input.


Improve documentation menu

Fixes a issue where the menu is out of sync with the content on-screen.

@hacksparrow PTAL - I think you wrote this code originally..?

@ambrosechua can you elaborate on the issue? Maybe a GIF image showing the behavior?

Figured it out. The menu headers jump to the right location when clicked. Thanks @ambrosechua.


Possible error in rejection

In current (0.3.1) code, at line 58, I see the same test than in the resolve part:
if (!$rootScope.$broadcast('$stateChangeStart', toState, toParams, fromState, fromParams).defaultPrevented)
This can lead to reject the state change on the basis we want to go to toState, while we want the check to be done on the redirectTo state.
[EDIT] I am no longer sure of the validity of my issue...
Sorry for the noise, this probably should be closed.

No worries!


Issue : Can't read some books. #38 Fixed

I found that we can solve this issue by adding IllegalArgumentsExpection.
I checked with the both books which i reported in this issue. Its working fine. Please review this request.

@jskcse4 I appreciate your efforts to fix that bug. But there was better way to fix that bug. Please check v0.2.3 which is released just now..


fix: sets previousValue for afterChange hook in nested fields correctly

Fixes: #4643
Description

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[ ] Chore (non-breaking change which does not add functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to the templates directory (does not affect core functionality)
[ ] Change to the examples directory (does not affect core functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
--> only test\plugin-search\int.spec.ts fails locally but this seems to be a setup issue, as this doesn't seem to be related to my changes. The error is: Cannot find module '../../packages/payload/dist/utilities/wait' from 'test/plugin-search/int.spec.ts'
[ ] I have made corresponding changes to the documentation

No worries, I'm happy to contribute to this amazing project and appreciate all the work and efforts you guys put into payload. (:
This being said, I hope to create another commit this weekend.

@DanRibbens I added a small commit now.
I also deleted the block field test entirely and hope this is what you meant.
Please let know if there is something else missing.

@DanRibbens what's the status on this? Is something blocking this from getting merged?

@DanRibbens just a reminder.

This is a pesky one - I spent way more time than I'll admit experiencing this issue last evening. It applies to nested afterChange hooks, and even in tabs. The previousValue just doesn't behave as expected.


chore: release 1.2.99

:robot: I have created a release *beep* *boop*
1.2.99 (2022-05-11)
Bug Fixes

helm-for-werf: detailed error message for "current release manifest contains removed kubernetes api(s) ..." error (8e8e5df)
stapel-to-buildah: added missing ssh-auth-sock and commit related envs, labels and volumes (3835e62)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.99 :sunflower:


Drop Mac Firefox

On 6/20/19 we decided in dev meeting that we would drop support for Firefox on Mac devices (not Windows) due to the usage being less than 1%.  This means that I nee to change the test matrix and QA book.  In addition, for awhile at least, we will treat it a bit like the iOS 9 and iOS 10 devices.  We will make sure the sim opens and runs acceptably, but not dig for bugs.

Help center updated.

https://docs.google.com/spreadsheets/d/1jl8z3MjmGBeU_Z5voMIN-rBF9al6LNyey9ZIuOpoUzA/edit#gid=1953870942 is tentative Matrix.  Needs to be tested.

I feel slighted.

I made some tweaks to the test completion percentage cell formulas. Let me know if you think everything is OK, @KatieWoe. I also dropped the HTML download test for iPad 2.

Test matrix done

QA book updated as well.  Closing


appgw.ingress.kubernetes.io/health-probe-status-code does nothing in application gateway

Hi there,
We have image 1.4.0 of the ag-k8s-ingress running in our cluster, and have setup multiple ingress rules using this setup. For most of our endpoints, we add a health-probe path with the appgw.ingress.kubernetes.io/health-probe-path: annotation, and this leads to the correct health probe settings. So far everything is good.
For some of our endpoints, we want to allow certain additional response codes, say 404. To implement this, we added the following annotation:
appgw.ingress.kubernetes.io/health-probe-status-code: 200-299, 404
While the configuration is accepted by aks, this does not lead to any change in the related health probe's settings.
Ingress setup extract:
Name:             pivt-demo-backends-ingress-azure
Namespace:        ingress-azure-allowlisted
Address:          <redacted>
Default backend:  default-http-backend:80 (<error: endpoints "default-http-backend" not found>)
TLS:
  pivt-demo-backends-azure-tls terminates <redaceted-url>
Rules:
  Host                        Path  Backends
  ----                        ----  --------
  <redaceted-url>
                              /   uat-ag-allowlisted-ingress-nginx-controller:80 (<IP_ADDRESS>:80)
Annotations:                  appgw.ingress.kubernetes.io/backend-protocol: http
                              appgw.ingress.kubernetes.io/health-probe-interval: 20
                              appgw.ingress.kubernetes.io/health-probe-path: /api/health
                              appgw.ingress.kubernetes.io/health-probe-port: 80
                              appgw.ingress.kubernetes.io/health-probe-status-code: 200-299, 404
                              appgw.ingress.kubernetes.io/health-probe-timeout: 2
                              appgw.ingress.kubernetes.io/health-probe-unhealthy-threshold: 5
                              appgw.ingress.kubernetes.io/request-timeout: 20
                              appgw.ingress.kubernetes.io/ssl-redirect: true
                              cert-manager.io/cluster-issuer: cluster-issuer-<redacted>
                              kubernetes.io/ingress.class: azure/application-gateway
                              kubernetes.io/tls-acme: true

part of agic config:
apiVersion: v1
kind: Pod
metadata:
  annotations:
    checksum/config: 5755a388347f1aad9099bfd5cb90d9b0631043ae7d7a9a5bbf0b5b7d00331d09
    prometheus.io/port: "8123"
    prometheus.io/scrape: "true"
  creationTimestamp: "2021-06-30T12:28:20Z"
  generateName: prd-ag-allowlisted-ingress-azure-67b6c59db5-
  labels:
    aadpodidbinding: prd-ag-allowlisted-ingress-azure
    app: ingress-azure
    pod-template-hash: 67b6c59db5
    release: prd-ag-allowlistedspec:
  containers:
  - env:
    - name: AZURE_CLOUD_PROVIDER_LOCATION
      value: /etc/appgw/azure.json
    - name: AGIC_POD_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.name
    - name: AGIC_POD_NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    envFrom:
    - configMapRef:
        name: prd-ag-allowlisted-cm-ingress-azure
    image: mcr.microsoft.com/azure-application-gateway/kubernetes-ingress:1.4.0
    imagePullPolicy: Always
<...>

Screenshot of health probe:

Note that the 'use probe mathcing conditions' is not set to allow at all. I expected this to be set to the range 200-299, 404.
I needed, I can provide additional information.
We can manually edit the health probes to allow the 404, but after each update to the application gateway endoints, all of them are reset all the time.
I checked if there is a v.1.4.1 or similar available to fix this, but I could not find it.
Help and suggestions are very welcome!!

change annotation from health-probe-status-code -> health-probe-status-codes


[pylint] throw error if same named type importable from multiple namespaces

We shouldn't have the same model exported from more than one place, for example:
from azure.foo import PasswordCredential
from azure.foo.bar import PasswordCredential

We should check the dunder all at each level to make sure a library doesn't violate this rule. Special case for clients, who should have the same name between sync and async namespaces.

Hello @kristapratico @l0lawrence !
Is this up for grabs?

I believe this issue is being worked on, however there are other pylint issues if you want to try one out :) For example: https://github.com/Azure/azure-sdk-for-python/issues/32318


PowerToys Run does not run batch files or vbs scripts or shortcuts

Microsoft PowerToys version
0.65.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
PowerToys Run
Steps to reproduce

Create windows batch file (.bat) or .vbs script. Put it into the folder that is included into user %PATH%
Create standard windows shortcut (.lnk) pointing to this batch file or script
Try to open this shortcut with PowerToys Run

✔ Expected Behavior
The script or batch file is executed
❌ Actual Behavior
Nothing - PowerToys Run does not recognize my input ". <shortcut_name>" as executable. It offers me to run installed program with similar name.
This was working on previous release (0.64.1) and is now broken on release 0.65.0.
Any other mean other than creating shortcut to execute a .vbs script from PowerToys Run is acceptable.

Other Software
Windows run (Win+R) continues successfully executing my shortcut (.vbs script)

naliSourceCodeReleaseBuildSecured
naliSourceCodeReleaseBuildUnsecured

Started working again after system restart. Closing issue


Visium hd cancer colon

Closes #305

Hi Jieran, do you mean observation level metadata?
10x didnt supply cell types or similiar for this dataset.
As the bins are not really "single cell" level I am not sure how to best annotate those.
How was this done for other Visium flavors?

Oh I simply mean the google sheet we use to track the metadata on the "Annotate how?" column.
I found the information from that column very helpful when writing up my thesis. I think we might need to use it in the future for writing.

Ah gotcha, yeah I will fill it in.
Btw how is the thesis going? Did you defend yet?

Yesss...Will be this thursday haha! It'll be on zoom 12:15-13:00. Come join if you have time! (Finger crossed XD)


Issues when add GitLab group URL with forwards slash

Steps :

Login Admin portal
Navigate to EasyCLa GitLab Group tab
Connect GitLab group URL with forwards slash (https://gitlab.com/veergitlabe2egroup2/)
Click on " Install GitLab EasyCLA App " button
See-Installation issue appears
Close the window and return to this page.
Actual results : "The GitLab app is no longer installed or the GitLab group has been deleted" appears

Refer Video clip :
https://images.zenhubusercontent.com/194341141/6c8f4369-457a-4ea5-8575-1e8eb871af0e/pcc_1624.mp4

Issue is tested on Dev site & found following behavior
Case 1. Installation Successful appears when try to add new GitLab Group URL
https://images.zenhubusercontent.com/194341141/6b328d51-c371-4da3-b036-18260c89e15d/installation_successful.mp4
Case 2. Installation Issue appears for already registered GitLab Group

Issues on Case 2

installation of GitLab Group and Repositories error is not user friendly
alerady is spell mistake at error message it should be already
https://images.zenhubusercontent.com/194341141/06da0799-4947-4dca-8221-583b0049cb49/has_alerady_been_registered_.mp4


[BUG] missing parent objects at end of file

Found a bug that was causing the initial parent tmos abstraction regex to miss the last object in the file.
Updated the regex and added '---end---' to the end of the file just prior to parsing.

completed


No autorepeat on windows 11 with kmonad-0.4.1

Kmonad version: 0.4.1 prebuilt binary
windows version: 11
sympton: key combinations work well, but no auto repeat, even those keys that is not mapped does not have auto repeat.
To be sure this is not a problem of config file, I created a blank config file which has no alias.   Still same behavior.
Also tried both user mode start and start as administrator still get the same.
Config file used.
(defcfg
  ;; For Windows
   input  (low-level-hook)
   output (send-event-sink)

  ;; Comment this if you want unhandled events not to be emitted
  fallthrough true

  ;; Set this to false to disable any command-execution in KMonad
  allow-cmd false
)

(defsrc
  grv  1    2    3    4    5    6    7    8    9    0    -    =    bspc
  tab  q    w    e    r    t    y    u    i    o    p    [    ]    \
  caps a    s    d    f    g    h    j    k    l    ;    '    ret
  lsft z    x    c    v    b    n    m    ,    .    /    rsft      up
  lctl lmet lalt           spc            ralt rmet cmp  rctl left down rght
)

(deflayer default
  grv  1    2    3    4    5    6    7    8    9    0    -    =    bspc
  tab  q    w    e    r    t    y    u    i    o    p    [    ]    \
  caps a    s    d    f    g    h    j    k    l    ;    '    ret
  lsft z    x    c    v    b    n    m    ,    .    /    rsft      up
  lctl lmet lalt          spc             ralt rmet cmp  f11  left down rght
)

Fwiw, did you have a look at this and this this?

Just wanted to drop some extra info that will save anyone doing this a fair bit of time:
The guide in the post above (The last link) works great on Windows 10. You'll want to build and use the master branch, it fixes key repeat on windows.
You'll need to add two numbers to your defconfig as shown here:

In send-event-sink 300 20 as shown, 300 means wait 300ms before starting to repeat and 20 is ms between repeated chars. You might like 500 before repeat start better, but I want mine shorter.
It is absolutely a terrible idea to download exe's from strangers, but here's the build I made from the main branch, today:
https://www.dropbox.com/scl/fi/twmhfidcsaftf5dnmd2vt/kmonad-key-repeat-fixed.exe?rlkey=t2bbk2dl8etrwd06hz9n1wfz6&dl=1
Algorithm : SHA256
Hash      : 17E1E1808B12536D4263B9BAD75330437C701346116F1C351D484D32570535BA
Path      : Kmonad-Windows\kmonad-key-repeat-fixed.exe
Of note, the keycode-refactor branch looks stale, and although it builds, it does not work when you try to launch it.


Nested groups

Hello,
With this plugin, is it possible to create hierarchical table with more than 1 collapsible level?

Hi, each collapsing group can have only 1 collapsible level. It can have multiple groups that collapse independently of each other, but the groups should not overlap. You can check out https://andrewhackley.com/super-table/demo for a full demo of how the collapsing row or column groups work. While it doesn't sound like this plugin is exactly what you're looking for, thanks for reaching out and hopefully that helps!


configure: error: please install magic library

checking for libpcap... /home/elastic/moloch-master/thirdparty/libpcap-1.9.1
checking for nl_socket_alloc in -lnl-3... no
checking for nl_socket_alloc in -lnl... no
checking for nl_handle_alloc in -lnl... no
checking for yara... thirdparty/yara/yara-3.10.0
checking for maxminddb... thirdparty/libmaxminddb-1.3.2
checking for glib2... thirdparty/glib-2.56.2
checking for curl... thirdparty/curl-7.66.0
checking for lua... thirdparty/lua-5.3.5
checking for magic... checking for main in -lmagic... no
configure: error: please install magic library
make: *** No targets specified and no makefile found.  Stop.
MOLOCH: make failed

install moloch ，configure: error: please install magic library。

Need to install the libmagic/libfile library


Warning on MacOS: Secure coding is automatically enabled for restorable state

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
When invoking drawio from the CLI on MacOS, an WARNING is thrown. I'm not quite sure where it's coming from, but it's Apple related for sure. For example se https://github.com/python/cpython/issues/110950
To Reproduce

Only MacOS
When ever invoking drawio from the CLI, following warning is shown:

2024-05-16 12:19:42.855 draw.io[95937:13418976] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

For example the version:

> /Applications/draw.io.app/Contents/MacOS/draw.io --version
2024-05-16 12:19:42.855 draw.io[95937:13418976] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.
24.4.0

Or some export

drawio -x -f png does-not-exist.drawio
2024-05-16 13:18:43.217 draw.io[5251:13472341] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.
Error: input file/directory not found

Expected behavior
NA
Screenshots
NA
draw.io version (In the Help->About menu of the draw.io editor):
> /Applications/draw.io.app/Contents/MacOS/draw.io --version
2024-05-16 12:19:42.855 draw.io[95937:13418976] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.
24.4.0

Desktop (please complete the following information):
> sw_vers
ProductName:		macOS
ProductVersion:		14.4.1
BuildVersion:		23E224

Smartphone (please complete the following information):
NA
I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:
NA
Additional context
Add any other context about the problem here.

Installed via homebrew.

Looks like https://formulae.brew.sh/api/cask/drawio.json.

I've uninstalled the homebrew version and directly installed the releases published on github. On all versions 20.7.4, 24.2.5 and 24.4.0 this issue is present.

Does this still happen in 24.4.6?


failure when using non-square 2d kernel for AveragePool

I get the following errors when using a 40x16 kernel with the AveragePool operator.  Note in the second error message 'ints' not 'i' is used as the key for the 'kernel' arg .  I see that in your test code all tests for this operator use the same width and height for 2d kernels.  Is this a bug or incorrect usage on my part?
E1229 18:54:49.191588  6048 operator.cc:461] Shape inference error: [enforce fail at proto_utils.cc:295] arg_map_.at(name).has_i(). Argument kernel does not have the right field: expected field i
E1229 18:54:49.191951  6048 operator.cc:462] Operator: input: "gpu_0/comp_3_concat_0" output: "gpu_0/comp_4_avgp_1" name: "" type: "AveragePool" arg { name: "kernel" ints: 40 ints: 16 } arg { name: "ws_nbytes_limit" i: 67108864 } arg { name: "cudnn_exhaustive_search" i: 1 } arg { name: "stride" i: 1 } arg { name: "pad" i: 0 } arg { name: "order" s: "NCHW" } device_option { device_type: 1 cuda_gpu_id: 0 } engine: "CUDNN"

This was caused by using kernel=[40, 16] rather than kernel_h=40, kernel_w=16 when specifying the kernel dimensions to AveragePool.


GPU not found - but is up-to-date and installed

When I try to start SciView from Fiji (up-to-date) i get stuck with the following error message (see below). But my GPU works and the driver is up to data. Any ideas what to check?

[ERROR] No SciJava display available. Use getOrCreateActiveSciView() to automatically create a display if one does not exist.
11:58:05.670 [SciJava-7dbe2ebf-Thread-4] INFO  SciView - imagej-launcher version bigger that non-working version (5.0.2 vs. 4.0.5), all good.
11:58:05.795 [Thread-4] INFO  SciView - NodePublisher listening on tcp://<IP_ADDRESS>:6666
11:58:07.469 [SciJava-7dbe2ebf-Thread-4] WARN  Renderer - Vulkan unavailable (java.lang.IllegalArgumentException: Parameter specified as non-null is null: method graphics.scenery.backends.RenderConfigReader$RendertargetConfig.<init>, parameter size, Instantiation of [simple type, class graphics.scenery.backends.RenderConfigReader$RendertargetConfig] value failed (java.lang.IllegalArgumentException): Parameter specified as non-null is null: method graphics.scenery.backends.RenderConfigReader$RendertargetConfig.<init>, parameter size
 at [Source: (sun.net.www.protocol.jar.JarURLConnection$JarURLInputStream); line: 11, column: 3] (through reference chain: graphics.scenery.backends.RenderConfig["rendertargets"]->java.util.LinkedHashMap["GeometryBuffer"])), falling back to OpenGL.
11:58:07.478 [SciJava-7dbe2ebf-Thread-4] INFO  OpenGLRenderer - Initializing OpenGL Renderer...
11:58:07.490 [SciJava-7dbe2ebf-Thread-4] ERROR Renderer - Could not instantiate renderer. Is your graphics card working properly and do you have the most recent drivers installed?

This would need to be tested again. A huge amount has changed since this issues was filed. In particular, we do not use OpenGL at all anymore.


pkg/trace/api: ensure media-type gets extracted correctly

This change ensures that media type gets parsed correctly in the
"Content-Type" header. Previously having a header with the (correct)
value "application/json;charset=utf-8" would fail to be parsed
correctly.
Updates #3172

Codecov Report

Merging #3203 into master will decrease coverage by 1.77%.
The diff coverage is 80.95%.

@@            Coverage Diff            @@
##           master   #3203      +/-   ##
=========================================
- Coverage   56.07%   54.3%   -1.78%
=========================================
  Files         412     544     +132
  Lines       30897   39217    +8320
=========================================
+ Hits        17326   21297    +3971
- Misses      12683   16653    +3970
- Partials      888    1267     +379

Flag
Coverage Δ

#linux
57.39% <77.77%> (?)

#windows
56.06% <80.95%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/trace/api/api.go
77.11% <80%> (+1.62%)
:arrow_up:

pkg/trace/api/responses.go
75.67% <85.71%> (+0.67%)
:arrow_up:

pkg/forwarder/transaction.go
78.63% <0%> (-4.28%)
:arrow_down:

pkg/util/hostname_nix.go
0% <0%> (ø)

pkg/util/kubernetes/apiserver/diagnosis.go
18.18% <0%> (ø)

pkg/util/containers/cri/diagnosis.go
28.57% <0%> (ø)

pkg/clusteragent/custommetrics/store.go
65.04% <0%> (ø)

...g/util/kubernetes/apiserver/metadata_controller.go
55.3% <0%> (ø)

pkg/util/docker/global.go
0% <0%> (ø)

pkg/util/pipe_nix.go
0% <0%> (ø)

... and 146 more


[bug] crash when planting rainberry bush

I got this crash when i tried to replant this berries into the ground.

CrashIllegalArgumentException: Cannot set property class_2754{name=type, clazz=class net.minegate.fr.moreblocks.block.enums.FernType, values=[default, plant]} as it does not exist in Block{bodaciousberries:rainberry_bush}

Full Error Details Link : https://bytebin.lucko.me/DNzw6jeKtI

This issue is caused by moreblocks, and can't be fixed on my end.
You can see the report at https://github.com/MrFantiVideo/MineGate/issues/26
In that issue there's a preview version which should fix your issue

@Poooppy can you please verify that this is fixed with the preview version?

@Poooppy can you please verify that this is fixed with the preview version?

I just test with Preview version of minegate-moreblocks and it still not fixed yet.
Thank you so much for your reply ♥
And I apologies for my trouble.

thank you so much for the compliments!
would you mind if I closed this issue, because it's up to minegate to fix?

@Poooppy ping: could this be closed?


Encountered error "status code: 422" many times while importing data.

I tried to use weaviate to construct inverted indices of tens of millions of levels of corpus. Just for keyword retrieval.
But I encountered the following error SO many times in the process of importing text corpus after loaded about millions items:
weaviate.exceptions.UnexpectedStatusCodeException: Create objects in batch! Unexpected status code: 422, with response body: {'error': [{'message': "invalid param 'objects': cannot be empty, need at least one object for batching"}]}.
I can make sure that the machine resources are sufficient and the data is successfully read and entered into the function  client.batch.add_data_object.
I wonder if i use wrong methods of importing or there's something wrong in python client.
Here my code of importing:
    def import_as_batch(self, bs, data, id_list):
        print(len(data), len(id_list))
        self.client.batch.configure(
            # `batch_size` takes an `int` value to enable auto-batching
            # (`None` is used for manual batching)
            batch_size=bs,
            # dynamically update the `batch_size` based on import speed
            dynamic=True,
            # `timeout_retries` takes an `int` value to retry on time outs
            timeout_retries=9,
            # checks for batch-item creation errors
            # this is the default in weaviate-client >= 3.6.0
            callback=weaviate.util.check_batch_result,
            consistency_level=weaviate.data.replication.ConsistencyLevel.ALL,  # default QUORUM
            )

        with self.client.batch as batch:
            batch.batch_size = bs
            for idx, d in enumerate(data):
                self.client.batch.add_data_object(d, self.table_name, id_list[idx])

And my weaviate version is 1.17.5. Hope can help me analyze the problem, or tell me the direction of investigation. Thanks a lot.

This sounds like a client problem. Do you have  a lot of timeout errors?

Yes!  When this error occurs, it is always accompanied by a timeout retry for the current batch.
After the amount of data in the class reaches close to a million, the error will occur every few tens of thousands of imports.  And I can continue importing after I restart my python program immeadiately but soon comes the error.
In addition, I once tried to skip the batch with the error using try-catch statement and found that none of the subsequent data could be successfully imported.

Hi @wyzhangyuhan,
where you able to test the version I posted?

Thanks for your timely repair! 👍
I've tried the version you posted the other day. It seems that my data was imported normally and no error was reported.
During this time,  I tried calling with_meta_count() to check the total number and found that the number was not updated synchronously.
Because I was busy with something else these days, I didn't have time to check the problem carefully. But judging from the final result, my data might have been successfully imported.
My only explanation for the above phenomenon:

The data entry I enter has its own unique id.
During the previous import with old client version, some data was successfully imported despite the 422 error.
Therefore, the data entries already exist when using new version, so the total does not change.  :D


fix URL after previous sfnet overhaul

This fixes a regression in a recent commit. Can it be merged please?

Thank you @Alexpux!


Tests fail when run fast, but work when stepping over.

I've run the Karma Debug and it seems that when I added a delay to the tests they work. So when the tests are run too fast, they generate an error, even though they don't fail - they generate an unhandled exception.
The problem is here: getAnimatableElement. When the tests are executed, there seems to be a race condition in that the tests expect firstChild to be there, while it is not there yet.
Tests that cause this behavior:

Repeat array (pure) direct expression handles pop
Repeat array (pure) direct expression handles shift

More details on this:
The problem appears to be with these two doubled lines:

double pop()
double shift()

Commenting out one of the pairs solves the problem.

Works correctly with latest aurelia-binding.


Fixed the Broken link of Language/general_web_fundamental/hitesh choudhary youtube

The Broken link of the Language/general_web_fundamental/hitesh choudhary youtube is been fixed
Changes made is
Before fix link is : https://www.youtube.com/@HiteshChoudharydotcom
After Link fix : https://www.youtube.com/@HiteshCodeLab

@akashchoudhary436 why have you closed it?

@akashchoudhary436 there is 3 failing checks. So, update your pr with all the changes.

@rupali-codes the link had been fixed kindly review it and merge the PR

@rupali-codes the link had been fixed kindly review it and merge the PR

Is there any issue to be closed with this PR?

@rupali-codes  No issue

@rupali-codes No issue


Fetching page as Googlebot displays an error

So I'm currently using "next": "^4.1.4", on a nginx server on production. When trying to optimize the website's SEO, I discovered that crawling the pages as googlebot is causing some errors.

As you can see, on the right the page is rendered normally and on the left, some error was displayed. The page response returned looks good, though:

So I am wondering is this an issue with next.js itself or this may be caused by some other elements?

Tech
Version

next
4.1.4

node
6.10.2

OS
Ubuntu

browser
Googlebot

I've encountered the same problem when attempting to analyze a static export from Next.js using PageSpeed Insights.

Also, if I am trying to copy and save all the code from the response (second screenshot) into an HTML file, the googlebot renders it absolutely fine. That is really weird.

https://github.com/zeit/next.js/pull/3181
please read about this problem and solution here.

@iamsoorena How to solve this with npm, though?

the only solution for now :
https://github.com/zeit/next.js/pull/3181#issuecomment-341293645

probably you should use yarn as a workaround here,  I know that it makes a lot of problems itself :D

I've tried the Yarn resolution suggestion, and that doesn't seem to do the trick.
https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fdeploy-preview-38--candidco.netlify.com%2F
Can't really tell if yarn is actually doing the right thing, as I still see 4.x versions of strip-ansi in there:
https://gist.github.com/i8ramin/e3d6c8addd934c17f91b05b64f3bd1e4
Any other suggestions or updates on this?

Closing as we are looking it in a different place.

What place?

@DominikLevitsky it's actually fixed in 4.2.1 👍

@timneutkens Thank you!

FYI, the only way I was able to get things working on IE11 (and Google PageSpeed for some odd reason) was the following:
Added to package.json to lock a few modules. Main issue is ansi-regex. Version 3.x starts using arrow functions.
"resolutions": {
    "ansi-regex": "^2.0.0",
    "pretty-format": "20.0.1",
    "string-width": "2.0.0",
    "table": "3.7.9"
  }

Include this in page head
(polyfill service to include things like Object.assign and Array.from in IE11)
<script src="https://cdn.polyfill.io/v2/polyfill.min.js" defer async />

I am still getting this error on next 4.3.0-canary.1 on production.

Still getting this issue on 5.1 in production.

I've created https://github.com/sheerun/targets-webpack-plugin to target this issue
Maybe zeit would like to use it in next.js itself for "next build", hm? @timneutkens

Had issues with Googlebot / Chrome 41 rendering, because of using react-native-web and Apollo.
https://github.com/zeit/next.js/issues/3205#issuecomment-384673971 solution works great.

Is fetching page as googlebot issue still a problem in Next 7 for anyone?  I am curious if most people probably have the issue and don't realize it or if there is some specific dependency that causes this that users could be warned about.  Is the remaining cause something that could be solved by nextjs or is it recommended for everyone to use targets-webpack-plugin?

I've re-checked my app that uses next 7.0.2 and I can confirm that google fails to render it:
https://imgur.com/a/AVhQFQ5
I cannot provide the source because it's proprietary. I'm pretty sure the error happens when imported code needs some native builtins that are not available in chrome 41. In this case next.js fails to include these in bundles. I think good candidate to check is includes:
https://caniuse.com/#search=includes

Also it's the node_modules dependency that needs to use it, not the app itself

@Enalmada @timneutkens I managed to reproduce this error with this repository that uses newest next.js: https://github.com/sheerun/with-apollo The app is available at https://sheerun-with-apollo.now.sh/ though you need to deploy it by yourself if you want to test it with https://www.google.com/webmasters/tools/googlebot-fetch-details
The error happens when app imports https://github.com/sheerun/awesome-includes package I've created that uses [].includes internally (there are other npm packages that do similar things).
Could you reopen this issue?

You can also test with Chrome 41 locally, that's what google uses.

It's next to impossible to download one :)


Feature request: auto importing components

PhpStorm has a nice feature of auto importing components when typing it's name inside template tag. Is it possible to add such functionality?
Examples:
<script lang="ts">
import { defineComponent } from 'vue';

export default defineComponent({
   name: 'Placeholder'
});
</script>

<template>
    <test-c... <-- picking suggestion
</template>

After picking:
<script lang="ts">
import { defineComponent } from 'vue';
import TestComponent from<EMAIL_ADDRESS>
export default defineComponent({
   name: 'Placeholder',
   components: {
      TestComponent
  }
});
</script>

<template>
    <test-component>
</template>

Would be great if it also worked with script setup!
But I wonder how it will be handled with default typescript behavior? Because for example, if you store components inside folder like so:
- TestComponent
  - types.ts
  - index.ts
  - TestComponent.vue

and try importing component from index, will it handle it correctly? Because right now importing defineComponent imports it from @vue/runtime-core and not from vue (which actually breaks our Vite application, but it's whole another story). I try not to open issues if Volar's behavior matches default.

I personally don't like this feature... It introduces some DX conventions outside TS. And it will increase many component item in completion list for a large project.
As I know Vetur also has this feature, have you used one of them for a while? Does this feature bring substantial DX improvements?

But I wonder how it will be handled with default typescript behavior?

Considering performance, we may only be able to handle auto-import from *.vue files.

I wrote a project using PhpStorm and the main drawback of switching to VSCode was the loss of auto-importing components (and initial responsiveness). In fact some of our coworkers stay on Storm because of this.
But I haven't used Vetur with this feature.

Thanks for shared! "initial responsiveness" mean language server initialization speed, or first LSP request (like hover info) response speed? Will take a look for improve.

In fact some of our coworkers stay on Storm because of this.

I don't think your coworkers will switch to VSCode when we add this feature. 🤣
Anyway I will try to implement this feature as experiment first.

Thanks for shared! "initial responsiveness" mean language server initialization speed, or first LSP request (like hover info) response speed? Will take a look for improve.

LSP requests can be quite long. I mean hover info, reference window and go to definitions (this ones can be reeeeeealy long). It really throttles if I make edits in multiple files at once (I mean > 10). This workflow happens very rarely tho.

I want to improve it if possible, will be helpful if you can provide profiling.

I started debugging, and I so far I can say I see a lot of these errors:

By the way maybe we should discuss this in another thread? Where should we switch?

@sheremet-va Sorry for missing the message!
You can open a new Issue / Discussion or ask on Discord anyway is ok.
Please post how and where to get this error.

Supported in 0.25.15.


PLNSRVCE-1598: update sprayproxy repository with konflux-ci org

@Roming22

/ok-to-test

/test appstudio-upgrade-tests

@enarha do yo have an idea why the yaml check is failing ?

@enarha do yo have an idea why the yaml check is failing ?

The container "sprayproxy" is using an invalid container image, "ko://github.com/redhat-appstudio/sprayproxy". Please use images that are not blocked by the BlockList criteria : [".:(latest)$" "^[^:]$" "(.*/[^:]+)$"]
object: sprayproxy/sprayproxy apps/v1, Kind=Deployment

@jkhelil Please split that PR into two. One to update staging, wait for it to be merged and deployed and verify the change before opening another PR to update production (this is a practice we follow within the team).

@hugares We are using standard kustomization construction https://github.com/redhat-appstudio/infra-deployments/blob/main/components/sprayproxy/staging/kustomization.yaml#L8-L11 where the name is actually replaced by the newName:newTag. ko://github.com/konflux-ci/sprayproxy is just a placeholder replaced by the actual name and tag. We can workaround that by changing that name both in infra-deployments and the sprayproxy repo, by appending some dummy tag, but that will make it more confusing for other people who will look at it. A comment could help, but the preferred workaround for me will be a comment on the problematic line to make the linter skip that error.

I know what is the issue, the kustomize replacement is no longer working... let me put a comment in the diff about it

/hold

/retest

/retest-required

/retest

/retest

/retest

I can see this error on e2e
oc apply -f deploy/member-operator/appstudio-dev/ -n toolchain-member-operator || true
error: the path "deploy/member-operator/appstudio-dev/" does not exist
oc apply -f deploy/crds/
I think it is not related to the change
I am retrying the test again
/test appstudio-e2e-tests

/test appstudio-e2e-tests

@enarha @hugares @Roming22
I think we can approve this now ?

@zregvart @mmorhun Can you aprove this please ?

/lgtm

/unhold


Add optional feature to guarantee better service continuity in case of worker node failure in the remote cluster

Description
This PR add the possibility to ensure that offloaded pods running on a failed node are evicted and rescheduled on a healthy node, preventing them to remain in a terminating state indefinitely.
Use case: this feature can be useful in case of remote worker node failure to guarantee better service continuity and to have the expected pods workload running on the remote cluster.
Downside: it could produce zombies in the worker node, in case the node returns Ready again without a restart.
Implementation: a controller in the liqo-controller-manager checks for all offloaded pods (i.e. managed by a shadowpod) that are Terminating and running on a node marked as NotReady. These pods are then force deleted. The shadowpod reconciler will then take care of rescheduling a new pod on a healthy node.
How Has This Been Tested?

Locally, with 2 running clusters.

Offload an application
On the remote cluster, stop one worker node (hosting offloaded pods) to make it NotReady

@aleoli

Where should we add a better description of what exactly happens in the system? Here in the PR description?
Should we add a patch to the documentation here in this PR, or in a separate one, dedicated to the documentation?

Hi @frisso,

Where should we add a better description of what exactly happens in the system? Here in the PR description?

Yes, we can add it here. @Fra98 can you add to the description some lines about how you addressed the problem "ensure that offloaded pods running on a failed node are evicted and rescheduled on a healthy node, preventing them to remain in a terminating state indefinitely"

Should we add a patch to the documentation here in this PR, or in a separate one, dedicated to the documentation?

We also need a second PR on endpoints reflection to correctly handle service continuity, I would wait for it to have a full example for this scenario

@frisso, @aleoli

Yes, we can add it here. @Fra98 can you add to the description some lines about how you addressed the problem "ensure that offloaded pods running on a failed node are evicted and rescheduled on a healthy node, preventing them to remain in a terminating state indefinitely"

PR description expanded

/build

/test

/rebase test=true


hotpot.lua:33: module 'hotpot.hotterpot' not found

Running into this issue after a full system upgrade (NixOS and home-manager). Issue doesn't seem to be related to neovim's version, as I didn't have this issue with both neovim 0.6 stable and 0.7 nightly before upgrading all packages in my environment.
Here's the messages I get immediately after starting neovim:
Error detected while processing /home/harrison/.config/nvim/init.vim:
line    5:
E5108: Error executing lua .../home-manager/start/vimplugin-hotpot.nvim/lua/hotpot.lua:33: module 'hotpot.hotterpot' not found:
	no field package.preload['hotpot.hotterpot']
	no file '/home/harrison/.cache/nvim/hotpot//nix/store/6gncbnhp95g4vr1504jsp6ffnr1ldizc-vimplugin-hotpot.nvim/fnl/hotpot/hotterpot.lua'
	no file '/nix/store/jxz9x9xp1ss6w06022c2dljjnhqqmck1-luajit-2.1.0-2021-10-27-env/share/lua/5.1/hotpot/hotterpot.lua'
	no file '/nix/store/jxz9x9xp1ss6w06022c2dljjnhqqmck1-luajit-2.1.0-2021-10-27-env/share/lua/5.1/hotpot/hotterpot/init.lua'
	no file '/nix/store/jxz9x9xp1ss6w06022c2dljjnhqqmck1-luajit-2.1.0-2021-10-27-env/lib/lua/5.1/hotpot/hotterpot.so'
	no file '/nix/store/jxz9x9xp1ss6w06022c2dljjnhqqmck1-luajit-2.1.0-2021-10-27-env/lib/lua/5.1/hotpot.so'
stack traceback:
	[C]: in function 'require'
	.../home-manager/start/vimplugin-hotpot.nvim/lua/hotpot.lua:33: in function <.../home-manager/start/vimplugin-hotpot.nvim/lua/hotpot.lua:29>
	[C]: in function 'require'
	[string ":lua"]:1: in main chunk

# all of my fennel modules also not found ...

Error detected while processing /nix/store/6gncbnhp95g4vr1504jsp6ffnr1ldizc-vimplugin-hotpot.nvim/plugin/hotpot.vim:
line    2:
E5108: Error executing lua [string ":lua"]:1: loop or previous error loading module 'hotpot'
stack traceback:
	[C]: in function 'require'
	[string ":lua"]:1: in main chunk

Here's my neovim config for home-manager as well. Its parent directory is the rest of my home-manager config.
Any ideas? Let me know if I can help at all :) Thanks!

Likely Hotpot thinks you have it compiled in cache but the cache has been deleted or moved.
Could you post a tree of /home/harrison/.cache/nvim/hotpot?
I would bet you have
hotpot/
  canary -> /some/path/to/hotpot/clone/canary/<checksum>
  /nix/store/<something-that-isn't-6gncbh...>

You can just delete the canary link or probably better off the whole hotpot folder in nvim's cache and it should all start working again. I am interested to see the top level cache dir structure you have though.
Some context on why it's probably failing:
Hotpot checks inside the cache root for a canary symlink. If it exists and resolves (i.e. the linked file exists too), it assumes that hotpot has been compiled to lua and is in cache and will try to load it.
When a new version of hotpot is pushed online/cloned down, the previous canary file is deleted (it's a checksum of the repo state, so each new version gets a new canary file). This means the link wont resolve and hotpot is supposed to recompile itself.
I am betting that the canary file still exists, points to the current clone of your hotpot plugin (so hotpot doesn't think the compile is needed), but nix has swapped the contents of the cache so the require fails.
I don't have experience with nixOS/nix pm yet (on the todo list ...) so not 100% on all its internals but I assume when you bumped your config, the old config got deleted and the new one, since they're checksummed, doesn't match the old location.
Not sure if that is something I can reasonably handle with Hotpot. I guess it could do a one-time "canary existed but load failed, try compile" for these kinds of cases. Bit ugly though. Not sure if nix provides some "do this too" steps for when you upgrade, that could clear hotpots cache.

Here's the tree, seems like you're right! :)
Nix/home-manager does have a way of running extra commands after a profile generation, so I will see if I can get that working and then report back here.
Thank you! 😁

Not a problem! Removing the cache definitely worked! Now to get Nix to do it automatically...

Interesting that you seem to have lots of cache stores from each nix iteration but this is the first time you've seen the issue? Wonder what was different.

I think what was different was actually upgrading my packages/package registry on my system (via home-manager switch --flake <flake_path> --recreate-lock-file, as opposed to just home-manager switch --flake <path>)

Though I guess nix is supposed to just let you roll back, theoretically?

Indeed! No need to apologize about the downtime :)

Update: Somebody on Reddit gave me a super helpful solution to the Nix issue. Link to that.
Assuming this is just a NixOS-related issue, I will consider all the information here enough for a solution to the issue I was having. Thank you for the help, @rktjmp !
Love this plugin by the way! It's really cool. I hope you also have fun learning Nix if you get around to it. It's a joy to use 😁


Prepare for 0.16.4 release

I've been also fixing locally tests and stuff for next release... there are some bugs still to be fixed before the release.

@elhigu Are these new bugs that would be regression compared to 0.16.3?

Yep. All tests were working on 0.16.3

@elhigu Merging the changes, but will wait with release for now.

Can be released already, I can push those test related changes in later on 👍


Fancy Zones

Description of the new feature / enhancement
To recognize monitor layout and recall default Fancy zone for that monitor layout.
Scenario when this would be used?
Moving from office workstation to home  workstation, both workstations having different monitor configurations.
Supporting information
No response

Hey there! Thanks for the feedback. It seems to me that this functionality already exists - you can read more about it in the thread I'm referring to below. If I misunderstood, please feel free to re-open and let me know!
/dup #29855


In the Replace window tab from Find goes to Replace. Shift-tab from Replace goes to Close

I do a lot of navigation with my keyboard and find myself constantly closing find and replace. It can be really frustrating when I have typed out a long string of regex in find because upon opening it again the find field is trimmed/erased. I am not sure if this is intentional or not but it doesn't seem intuitive at all.

+1

This has been fixed in 0.10.8. Shift-Tab from replace field now goes to the find field


Istio v0.2 auth: node agent

@wattli is this done? Can you link related PRs here and have this issue closed?

PRs are linked:
https://github.com/istio/auth/pull/207
https://github.com/istio/auth/pull/176
We can claim as 'code completed', but i believe there will be some bugs. Let's keep it open until next week.


(fix)ScrollWrapper: Adding focus ring on scrollwrapper

Description

References

Testing

Automation

Checklist

[ ] all commented code has been removed
[ ] any new console issues have been resolved
[ ] code linter and formatter has been run
[ ] test coverage meets repo requirements
[ ] PR name matches the expected semantic-commit syntax

b'## Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Lightning-UI-Components/539/rdkcentral/Lightning-UI-Components

Commit: 6280b55b8d7e5e0ed3d9b3286e9ca7f83c729fe6

Report detail: gist'

b'## Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Lightning-UI-Components/539/rdkcentral/Lightning-UI-Components

Commit: 6280b55b8d7e5e0ed3d9b3286e9ca7f83c729fe6

Report detail: gist'

b'## WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: OK

Commit: 6280b55b8d7e5e0ed3d9b3286e9ca7f83c729fe6
'

Tested it, working for me! Thanks

Can we just update the title to "fix(Knob): rename _updateCircleLayout to _updateLayout"? We can include the ScrollWrapper and FocusRing info in the description, but since this PR will get squashed and merged, it'd be nice to have the changelog show that this is a Knob, which is something that then propagates to the ScrollWrapper.


feat: Display index thru GUI

When index is set through the config file, it is not displayed in the GUI.  Is it possibel to add this to be displayed/updated through the GUI?
  Cadvisor:
    options:
      semantic_versioning: false
    latest_version:
      type: url
      url: https://github.com/google/cadvisor/tags
      url_commands:
        - type: regex
          regex: releases\/tag\/v([0-9.]+)
          index: 8

Ah, missed this! Adding now

Working as expected.  Thanks.


Fix issue where draft releases could not be found by tag

If a draft is updated a new untagged-* id is generated in Github. To make PRacticle work in CI we now fetch and filter releases by tag_name so we no longer need to directly reference the release by draft id.

 Bug - Fetch release notes by x.x.x tag

Conflicts here @pe4cey

Rebased