How does the iam_role_arn get injected into the application template?

In bootstrap/control-plane/addons/aws/addons-aws-csi-fsx-driver-appset.yaml there is a line of code eks.amazonaws.com/role-arn: {{metadata.annotations.aws_fsx_csi_driver_iam_role_arn}}. I know the metadata comes from the secret created by the gitops-bridge-bootstrap module, but I'm unclear on how argocd knows to use that secret when templating out metadata.annotations.aws_fsx_csi_driver_iam_role_arn.

It is from the cluster generator. The cluster generator will use the secret object for the cluster it is generating the application from. If you have cluster A and cluster B both have the label saying they want this addon, it'll generate out the application with that context. You can read more about it here https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/Generators-Cluster/

Ahhh, thanks. So the flow is like this, in order from top to bottom:
main.tf generates metadata with ISRA ARN's, and passes that to...
gitops-bridge-metadata, which creates the secret contents with "argocd.argoproj.io/secret-type" = "cluster" and a default of argocd namespace. The contents are passed to ...
gitops_bridge_bootstrap, which creates the secret. Then...
ArgoCD automatically picks up the secret via the Cluster generator.
The generator templates out ArgoCD Applications.
Is there any other way to template out custom values into ArgoCD applications that you know of? I'm curious if the Cluster Generator is the only way or if I have other options.
Relevant: https://github.com/argoproj/argo-cd/issues/7189

Hi @Almenon,
Thanks for looking at the gitops-bridge project
Currently the argocd secret that stores the metadata in annotations, and triggers in labels is done from terraform, it really doesn't matter how the data is added to the cluster secret.
You can also take the secret and have argocd deployed it if you put the argocd secret as yaml file in this location with the cluster name as folder if will be deploy then you can edit in git https://github.com/gitops-bridge-dev/gitops-bridge-argocd-control-plane-template/tree/main/clusters
You can also store the metadata in git and extract with git generator.
There are other methods people have use like a argocd plugin and the recent applicationset plugin
For example using the argocd vault plugin or helm-secret
For the first implementation of examples I wanted to use the most basic method that doesn't required a 3rd party plugin (enterprise customers sometimes can't use 3rd party dependencies)
There is proposal to implement in argocd Proposal to introduce dynamic application parameter this is will be similar to the current method of extracting from cluster secret but instead from any secret/configmap

The main question was answered


add mycloudfulfillment and talented and bee scm

What happened

Add MyCloudFulfillment, Talented and Bee sponsors.

Insight
Proof Of Work

https://deploy-preview-221--bangkokrb-rubyconfth.netlify.app/sponsors/

don't merge yet, may have a third sponsor to add and need to fix the columns

ok ready for review


Fix import dependencies.

The CLI can't be installed via normal methods anymore since it's importing dependencies when fetching the version.  This should fix: https://allspark.dev.data.humancellatlas.org/HumanCellAtlas/data-store/-/jobs/54102

@amarjandu It removes it.  I realized that removing that import won't work and am fixing it now with a different solution.

@amarjandu Changed.

@amarjandu If you run setup.py (like we do in smoketest) before you install dependencies (setup.py is intended to be run before dependencies so this is unexpected) it will import __version__ from version.py which also imports __init__.py implicitly and pulls in the tqdm dependency.
This is why it's always good to have blank __init__.py files.  I don't think it's a good idea to change now because this would create breaking changes (users could no call hca.get_config()) if we completely blanked __init__.py.
So the solution is either putting the tqdm import in the function or importing the version in a way that doesn't import hca.__init__.py (storing it somewhere else or hard-coding the version in setup.py rather than importing version.py).  It was hard-coded before, which is why it didn't break.


FeedMeError - Columns and data did not match, could be due to malformed feed

I'm trying to run an import but i keep getting this error. Even when i tell the system to only import the title and the slug and ignore all other fields. Have also tried eliminating all the other fields in the XML, with no result.
Could you point me in the right direction?
Log	Date
"Started importing node: 0"	14 mei 2015 18:43:32
{"feed":[],"items":1,"logsId":"15"}	14 mei 2015 18:43:32
"FeedMeError - Columns and data did not match, could be due to malformed feed."	14 mei 2015 18:43:32
XML feed = http://www.calco.nl/development/export
Bas

@ginkelb happy to have a look, sorry for the delayed response. Would you mind posting a screenshot of your current mapping and field settings? Happy to chat directly through Slack if that suits you as well.
From what I can tell, it may just be an issue of the primary element being incorrect, as it's working fine in my tests. Have a look at the attached screenshots.

@ginkelb Have you had any luck with the settings I've provided? Happy to help :smiley:

Hi John,
i solved the issue via another route. So i haven’t been able to test this.
Met vriendelijke groet,
Bas van Ginkel
Bas van Ginkel
Online Strateeg
030 8200 271 | 06 29 51 69 00
http://www.ditiserg.nl |<EMAIL_ADDRESS>Grebbeberglaan 15, 3527VX Utrecht (routebeschrijving)
Op 19 juni 2015 bij 16:59:01, Josh Crawford<EMAIL_ADDRESS>schreef:
@ginkelb Have you had any luck with the settings I've provided? Happy to help
—
Reply to this email directly or view it on GitHub.


Support non-default GPUs

https://github.com/locuslab/qpth/blob/ead299eb363b552de6626da470a688d16d27f661/qpth/solvers/pdipm/batch.py#L11-L17
Not a big issue. See above lines. Simply change the .cuda() to .to(x.device) will allow the the non-default gpu.
Many thanks.

Thanks! I just fixed this and pushed a new version to pypi


code of conduct.

Authenticator-07e77f5382a33291fabe5fb9d2362fd7f946abb7 (1).zip
Authenticator-07e77f5382a33291fabe5fb9d2362fd7f946abb7.zip
 @ @ @ @

README.TXT
[``]( @url)


Option (or default) to lock upsampler seed to image seed

Title. The use case for this is if an image were generated with a random seed, but then I want to re-generate that image with different parameters, but using the same image seed. Currently, doing this will generate a new image entirely, as the seed used for upsampling tags is randomized again. This behavior doesn't align with other extensions like sd-dynamic-prompts, which (by default) randomizes the prompt based on the image seed.

I though the same, this should do: #24


Add letterboxd defaults

Description
Adds
- default: letterboxd                           # 16 possible collections based on Letterboxd

In two places
Type of Change

[X] New feature (non-breaking change which adds functionality)

this isn't going to nightly fyi

I don't know what you're referring to


WIP : more general convert function

This is a work in progress following a discussion in #566 .
I've added the meters <-> feets example (and tests to prove the behavior).
For the moment, I don't have other targets (would we like km? cm?) so I'm cheating and ignoring "from".
Will work on a cleaner way (and with less if/else).
Also, next on the line : timestamp / date / etc.
Waiting for your input on the wanted possibilities of conversion. ;)

Hi Olafleur,
Sorry for not getting a chance to have a look earlier. Been one of those weeks :-) My open source time is limited.
Comments

"feet" is the plural of "foot" in the archaic measurement system. There is no such word as "feets" :-)

You are declaring a "from" attribute. This is then never used.

I assume when you talk of removing all the if statements and the declaration of the from attribute that you are intending the convert function to wrap a general data structure that holds from,to and conversion factor information. This is certainly the way I would go.
You may want t take a look at the Frink programming language, the guy behind that has put a huge amount of work into correctly converting from one thing to another. And his data file is fun to read for geeks :-) , I'm sure I saw it mentioned in some way Eve related.
Regards,
Cormac.

Ha! Ha! You are right. Will fix feets -> feet. :)
Yes, for the moment I'm not using the "from" attribute because with the possibilities that I have, I can alway infer what it is. However, the day that we will have conversions from feet to kilometers, for example, a "from" is essential.
Yes, my intent is to have a more general structure. Not sure what is the better way though.
Maybe an abstract class with childs implementing each concrete possibility?

@olafleur great work, this is the kind of interface we're looking for with a convert function, and I'm glad to see it works in practice.
We had a discussion about this in the office today about the best way to do convert, since it seems like such a natural fit to be implemented in Eve itself. Let's say a user wants to implement a custom conversion. If we implement convert[] in Eve, the user would just add a record to the database specifying the units and the conversion ratio. Awesome. But if convert[] is implemented in TypeScript, the user would have to add a line to a probably very large if-statement in the source code, and then rebuild the entire Eve runtime. Not so great (as an aside, this is a perfect example of how Eve makes something incredibly simple compared to other languages).
Of course this is problematic, since we don't yet have a way for users to define functions in Eve. We spent some time talking about that as well, and we've agreed that UDFs have some tricky implications and edge cases we need to think about more before we can feel safe about committing to any one implementation.
So I think for the time being at least, you should hold off working on this more, at least until we reach a proposal for UDFs. In the meantime, I'll leave this PR open, at least to track discussion on this topic.
Any other thoughts?

You are right. It would be a lot more awesome if we find a way to implement it in Eve itself ! :)
Also, I'm not sure what UDF means. (Universal Dynamic Functions ? ;) )

Sorry, user defined function.

I'm going to close this PR. and we'll track the progress of the convert function here: https://github.com/witheve/Eve/issues/610


feat(CDK): Tabs for CDK

Feature Description
Tabs are a common UI on the web, but not in the CDK. It is a bit disappointing that we have to install @angular/material for this.
Please Upvote if you want it!
Use Case
anywhere

Could you specify what CDK should include to support tab components?

Would be happy to get it too, like here, for instance


requestFailedWithStatusCode is hiding progressView

According to the documentation about 'requestFailedWithStatusCode' we should see an endless progress view/spinner.
From MKL: This is patch that the author submitted to the main turbolinks-android repo that hasn't been merged. It's from git@github.com:lazaronixon/turbolinks-android.git

@EvanSafford this is ready for review. Tested locally and working well. If you approve I will merge this and create a release.


Sometimes pick_state.top() returns None for large Planes

Something weird happens sometimes, where a pick_state.top() returns None even if there is a Plane there. The issue occurs when the Plane is large, like size 50.0. I don't have the problem with size 10.0.
The Plane is created like this:
    commands.PbrComponents {
            mesh: meshes.add(Mesh::from(shape::Plane { size: 50.0 })),
            material: materials.add(Color::rgb_u8(222, 184, 135).into()),
            ..Default::default()
        })
        .with(PickableMesh::new(camera_entity));

I've recorded a couple gifs of this happening, with the same system used in the example:
fn get_picks(pick_state: ResMut<PickState>) {
    println!("All entities:\n{:?}", pick_state.list());
    println!("Top entity:\n{:?}", pick_state.top());
}

It seems like the example completely breaks when the Plane size is set to 50.0.

The plane is only highlighted when the mouse goes outside.
Any ideas why this might be happening?

Thanks for reporting this! I'm almost certain this is related to #5 and #6 . I'd have to do some debugging with the triangle area calculation code however.

The vertices being used by the function look a bit odd. The first two numbers are tri area, and cursor tri area (hit if equal), and the three pairs that follow are the x/y coordinates of the vertices in ndc.,t his is with a plane size of 18:
No Hit: 493.499  743.078  0.359,0.710  70.805,139.869  2.939,-1.200
Hit: 182.905  182.905  0.359,0.710  -1.089,0.445  70.805,139.869
After plotting the points, they don't make a ton of sense compared to what I see on screen.
After dropping the plane size to 17, picking behaves as expected. Points look like this:
No Hit: 96.096  135.051  0.349,0.690  -14.860,-29.355  2.651,-1.082
Hit: 37.960  37.960  0.349,0.690  -1.047,0.427  -14.860,-29.355
It appears that one of the points, after being transformed to ndc space, is flying up to +++x and +++y.

I've been looking into it, and it doesn't seem like the issue is with objects being partially off the screen, at least not for small ones. After moving the camera so that a cube is halfway off the screen, selecting it still works fine.
I've also tried with a simple barycentric implementation kindly stolen taken from StackExchange, but the example still breaks with a Plane of size 30.0. I think we can discard the point_in_tri function as being the issue.
Here's the code I used, it's also here:
/// Checks if a point is inside a triangle, using barycentric coordinates
fn point_in_tri(p: &Vec2, a: &Vec2, b: &Vec2, c: &Vec2) -> bool {
    // https://stackoverflow.com/questions/2049582/how-to-determine-if-a-point-is-in-a-2d-triangle
    let s = a.y() * c.x() - a.x() * c.y() + (c.y() - a.y()) * p.x() + (a.x() - c.x()) * p.y();
    let t = a.x() * b.y() - a.y() * b.x() + (a.y() - b.y()) * p.x() + (b.x() - a.x()) * p.y();

    if (s < 0.0) != (t < 0.0) {
        return false;
    }

    let area = -b.y() * c.x() + a.y() * (c.x() - b.x()) + a.x() * (b.y() - c.y()) + b.x() * c.y();

    return if area < 0.0 {
        s <= 0.0 && s + t >= area
    } else {
        s >= 0.0 && s + t <= area
    };
}

It looks like the issue might be with the transformation into ndc coordinates then, I'll try to look a bit into it.

Yup, that's what I was getting at with the highlighted coordinates; for some reason at some threshold, some of the points are shooting of into space when transformed into NDC.

Is it possible that the points that are behind the camera get multiplied by -1? I'm not too confident with projections and stuff, but I remember reading about this somewhere. The tests I have been doing seem to suggest this, but I'm not really sure.
Here is the information for when the mouse is outside of the plane, the black circle in the following screenshot:

Mouse ndc coordinates are [-0.9342407, 0.953928].
Ndc coordinates for the detected triangle are:
a: [0.4486993, 0.8863647], b: [-1.5006784, 0.61249065], c: [1.7613124, 3.4793124]
Real coordinates for the detected triangle are:
a: [15, 0, -15], b: [-15, 0, -15], c: [-15, 0, 15]
The c point in ndc coordinates checks out in magnitude, but should be negative.
I have no idea if this is what's actually happening or how to go about fixing it if it is, any ideas?

Another thing that makes me think this is the issue is that when initializing the Camera in the example with
Camera3dComponents {
    translation: Translation::new(0.0, 20.0, 0.0),
    rotation: Rotation(Quat::from_xyzw(-0.5, -0.5, -0.5, 0.5).normalize()),
    ..Default::default()
},

and setting the Plane to size 50.0, everything works correctly.
The code above makes the camera be top down with most of the plane still off screen, but all of the vertices are in front of the camera.

Is it possible that the points that are behind the camera get multiplied by -1?

I'm thinking it might be happening in the /w part of the projection transformation. My initial suspicion was that it seemed related to going offscreen, but I think you're right, it's specifically cases where the vertices go behind the camera.

Yes! Adding .abs() to w fixes it!
let transformed = projection_matrix.mul_vec4(vertex_pos.extend(1.0));
let w = transformed.w().abs();
triangle[i] = Vec3::from(transformed.truncate() / w);

I should have thought about that sooner!
I'll have to check if this fixes my initial issue, but I have the feeling that it's something else, as in my game the plane is entirely in front of the camera.

Looks like we had the same thought! I did (basically) the same thing in the PR, let me know if this fixes your initial issue. I played around with a few plane sizes and it seems to resolve that problem. The picking doesn't seem to be exact for the plane (there is some dead space by the edge of the plane) which concerns me. Knowing that the current point_in_tri implementation method is susceptible to floating point error, I think this is acceptable, and we can look at picking accuracy when we merge in the barycentric PR you have in draft.

It does fix it! I used to have dead spots all over the place, and it works perfectly now. Thanks for all the help!


Problem with devcontainer.json

devcontainer.json does not build in JetBrains IDE 2024.1 and VSCode.
JetBrains IDE Welcome screen -> DevContainers -> New DevContainer (from VCS Project, Docker must be installed.) Insert the git@ link of the repository with devcontainer.json. -> "Build container and Continue"

Hi @trukhinyuri
Sorry for noticing so late the issue.
I checked with lastest builds in VSCode and worked OK.
PHPStorm is still in tests, as in the spring they were forcing with root to install different packages and some binaries and messed the dev container. They make many assumptions on how a devcontainer should work, and mostly looks like against the developer expectations.
I'll look further on PHPStorm, although I did not bother with it too much last months to use it.
If you modified .devcontainer.json or docker-compose.yaml, would you share the modifications?

Back with PHPStorm information.
It starts, and looks to work.
But there is one thing I can't understand on Jetbrain's use of devcontainers.
They don't respect the defined workspace volume, so Windows and MacOS people would be able to get perfect performance. They override and mount the path from Windows/Macos where the directory with the .devcontainer.json and docker-compose.yml file exist.
For me this is a no-no, as working with Magento, Docker and some other projects that the "vendor" directory is pretty big and php working with dozens of thousands of files, becomes extremly slow on Windows, and on MacOS also.
Maybe the new dev drive thing from Microsoft saves the day, but I have not yet used it, as it always failed for me to make a dedicated partition for it, and worked only in loop mode (virtual disk in file).
If you have a chance to test, let me know.


[FEATURE] Pattern for Airflow starting EMR Clusters / kicking off Spark Applications

Describe the solution you'd like
Part of the Image Pipeline requires Spark applications. Therefore we need a module to spin up an EMR cluster in the Airflow Dag, or to leverage EMR Serverless.

Need to run latest version of EMR with Spark 3+ and Iceberg Support
Ability to spin up and terminate cluster in Ros-Image Airflow dag
Extend Rosbag-Image Dag with steps to spin up cluster and terminate
Use existing EKS module, potentially use the Airflow EMR on EKS operator and see if this works
Easy way to pass in EMR / Spark Configurations like:

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/awslabs/autonomous-driving-data-framework/pull/60


Check for permissions in Vue-Router

I can be able to check for permission using v-if-thing. But if I try to add beforeEach hook in app.js, the this.$can() become undefined.
How can I use this library to test in beforeEach as router must be defined before the Vue() is initialized

Just use Ability instance directly.
import { ability } from '...'

const router = new Router(....)

router.beforeEach(...)

You are amazing

@stalniy when i do that and access page through button click (menu item, for example), it works. But when i access page directly (adding relative link to the end of root url, e.g. i'm on localhost and i paste /page1 in the end and hit Enter) ability.cannot('access', 'page1') returns 'true' even though i have permission to access that page. Any idea why that can happen?


Erik the Outgolfer: Watch metascan.ru

Erik the Outgolfer requests the watch of the watch_keyword metascan.ru. See the MS search here and the Stack Exchange search here.

metascan.ru has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Coverage remained the same at 65.027% when pulling 38cc5c5a70cdc88c49a87737f1c2ae043edd935f on auto-blacklist-1531759626.8563428 into 9d050ee85c6b64dd3683b7d9201c3d8ebee2dae1 on master.

Replaced by #2335 due to the syntax.


Update aws-core, http-client-spi, ... to 2.17.225

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.104 to 2.17.225.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #204.


Change watch ignore times from constants to properties.

Allow the 5 and 10 minute watch ignore times to be altered via properties.  Defaults are from the original constants.
Forum discussion here:  https://forums.sagetv.com/forums/showthread.php?t=66005

Thanks!


in InitDoc, validate input or return error

There is no format checking. It helps to indicate when there is an error in the date format for example.

Partially implemented (date OK, IBAN OK)...
Need some work on BIC Emiter !


Add What we value section

This addresses #43.

add a "What we value" section from homepage
remove the "Open positions" section
minor updates: spell out WGFAST

I'll self-merge so we have up to date info on the website. Feel free to PR more changes to the Values page.


[FEATURE] - Add current network to trusted

I like the feature connecting to VPN if inside a not trusted network.
But some network names are hard to write down without looking at them, also it would be much faster if there is a button to add the current network to the list of trusted networks.
That said, I am not sure about the requirements of permission for this.

Hello! I can see this being useful. I'll look into it.

Hey Zaneschepke,
Thanks for the answer. I really love to see this kind of features integrated into an App. The automatic mode is missing in the official App.
But back to a more on topic topic.
What happens if the SSID is hidden? I have never done this myself, so I am not sure how this affects the devices connected. Is there a name for the network anyway, or is it more about Mac address?
Oh and also there should maybe be a mention of hotspot hijacking. Since the app is only checking the name of the network, this could be an attack vector again.
But this only as things maybe to consider and not directly related to the feature request. It should be common knowledge not to connect to any open hotspot anymore.

Hey Zaneschepke, Thanks for the answer. I really love to see this kind of features integrated into an App. The automatic mode is missing in the official App.
But back to a more on topic topic. What happens if the SSID is hidden? I have never done this myself, so I am not sure how this affects the devices connected. Is there a name for the network anyway, or is it more about Mac address?
Oh and also there should maybe be a mention of hotspot hijacking. Since the app is only checking the name of the network, this could be an attack vector again.
But this only as things maybe to consider and not directly related to the feature request. It should be common knowledge not to connect to any open hotspot anymore.

Even if the SSID is hidden, once you connect to the network the phone gets the real SSID so this would not be a problem. The wifi hijacking should not be a concern because the user would still have to actively connect their phone to that network. If they are connecting to a dangerous network, there are bigger issues.


v2 Sign - converting circular structures error

Reported by a user - will review internally and identify issue

Transaction a is an app creation call with args passed and has a signers: [] and signed separately by logisic, hence no need to sign by user via algosigner but i still provide it for group validation and to avoid (part of unknown transaction group warning)
Transaction b is a simple pay transaction that needs signing by user

Here is what i experience when i use the v2 algosigner methods.
If i encode the args array in app create transaction into a string - i get an error from algosigner that its a part of an unknown transaction group
If i don't encode it an leave as uint8array, i get the fancy new signer screen where i click sign for each transaction in a group, when i click sign for the last transaction in a group i get converting circular structures error.
Hence, this blocks me from upgrading to v2 algosigner and i have to continue sending individual transactions for signing via v1 methods

Fixed by #272


add socks5 proxy  support

What is the purpose of the change
add socks5 proxy support for dubbo-remoting-netty4.
Brief changelog
Check the system property 'socks5ProxyHost' in org.apache.dubbo.remoting.transport.netty4.NettyClient#initChannel, if it exists, use the system property socks5ProxyHost and socks5ProxyPort to create a Socks5ProxyHandler and add it to the first location of the ChannelPipeline
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #3624 into master will decrease coverage by 0.13%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master    #3624      +/-   ##
============================================
- Coverage     64.28%   64.14%   -0.14%
  Complexity       71       71
============================================
  Files           666      666
  Lines         28984    28989       +5
  Branches       4814     4815       +1
============================================
- Hits          18632    18596      -36
- Misses         8103     8140      +37
- Partials       2249     2253       +4

Impacted Files
Coverage Δ
Complexity Δ

...e/dubbo/remoting/transport/netty4/NettyClient.java
70.58% <20%> (-4.02%)
0 <0> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-8.7%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

...dubbo/remoting/exchange/support/DefaultFuture.java
69.59% <0%> (-5.41%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

...exchange/support/header/HeaderExchangeHandler.java
55.81% <0%> (-2.33%)
0% <0%> (ø)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
76.47% <0%> (-2.21%)
0% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
65.78% <0%> (-1.13%)
0% <0%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42646d7...0ef0c95. Read the comment docs.

just wondering what's situation we need use socket proxy? if it's common usage, do we need apply similar change to other remoting module?

@zonghaishang replace System.getProperty to ConfigUtils.getProperty. please review again


check for cs op and odlm to be scaled after failure

Always check to see if the common service operator and odlm pods have been scaled back up after a failed isolate attempt.
Scenario:
On first attempt, the isolate script successfully scales down the cs operator and odlm deployments to 0 and uninstalls cert manager. However, the script fails before it can rescale cs operator and odlm deployments so cert manager is not deployed again either. The subsequent attempt at running the isolate script will then fail immediately because no cert manager is deployed. This failure is also very obtuse as the error handling of this function is not strong enough.
What this pr does:

makes the early failure due to a lack of cert manager more clear
ensures cs operator and odlm are scaled to 1 before proceeding with the script. Wait for CS CR after scaling

Testing:

deploy common services
run isolate script, make sure to exit sometime after uninstall singletons
verify cert manager is not installed, cs op and odlm are scaled to 0
run this version of the isolate script
verify script completes

I have run the test I outlined above three times in a row successfully so I think this pr is ready for review

@bluzarraga
hmmm I doubt that we do actually need echo "none"?
My assumption is that we will always have Kind CSV existing in the cluster, there is no non-zero status returned from first command
➜  csv_count=$(oc get csv -A | grep "cert-manager"| wc -l | tr -d " ")
➜  echo $?
0
➜  echo $csv_count
2
➜  csv_count=$(oc get csv -A | grep "cert-manager-xxxx"| wc -l | tr -d " ")
➜  echo $?
0
➜  echo $csv_count
0

Steps for test:

ran isolate.sh, exited prematurely before cs and odlm were rescaled
verify no cert manager and odlm and cs scaled to 0
switch to scripts branch to run isolate.sh and get the quick error
switch back to this branch to run fixed isolate.sh
verified script completed and cert manager deployed
Logs from latest full problem recreation and test:

<EMAIL_ADDRESS>ibm-common-service-operator]# ./isolate.sh --original-cs-ns ibm-common-services --control-ns cs-control -v 1
/usr/bin/oc
/usr/local/bin/yq
[INFO] Checking for common service operator and odlm pods
[DEBUG] cs op scaled output: ibm-common-service-operator            1/1     1            1           17m
[INFO] Common Service Operator already scaled, skipping.
[DEBUG] odlm scaled output: operand-deployment-lifecycle-manager   1/1     1            1           16m
[INFO] ODLM already scaled, skipping.
[INFO] Verifying cert manager is deployed
[DEBUG] cert manager csv count output: 1
[✔] Cert manager deployment verified.
No resources found
No resources found in openshift-operators namespace.
# Pausing Common Services in namespace ibm-common-services
-----------------------------------------------------------------------
deployment.apps/ibm-common-service-operator scaled
deployment.apps/operand-deployment-lifecycle-manager scaled
operandregistry.operator.ibm.com "common-service" deleted
operandconfig.operator.ibm.com "common-service" deleted
[✔] Common Services successfully isolated in namespace ibm-common-services
[INFO] Deleting podpresets in namespace ibm-common-services...
podpreset.operator.ibm.com "ibm-common-service-webhook" deleted

[INFO] Deleting existing Deployment ibm-common-service-webhook in namespace ibm-common-services...
deployment.apps "ibm-common-service-webhook" deleted
[INFO] Deleting MutatingWebhookConfiguration...
mutatingwebhookconfiguration.admissionregistration.k8s.io "ibm-common-service-webhook-configuration" deleted

[INFO] Deleting ValidatingWebhookConfiguration...
validatingwebhookconfiguration.admissionregistration.k8s.io "ibm-cs-ns-mapping-webhook-configuration" deleted
#  Creating empty common-service-maps configmap
configmap/common-service-maps created
[✔] Empty common-service-maps configmap created in kube-public namespace
configmap/common-service-maps configured
[INFO] The provided map-to-common-service-namespace: ibm-common-services, does not exist in common-service-maps
[INFO] Adding new map-to-common-service-namespace
[DEBUG] map ibm-common-services namespace ibm-common-services tmp "ibm-common-services"
[DEBUG] ns ibm-common-services mapto: ibm-common-services
[DEBUG] ns_delimited: "ibm-common-services"
configmap/common-service-maps configured
#  Verify all namespaces exist
-----------------------------------------------------------------------
[INFO] Creating namespace ibm-common-services
Error from server (AlreadyExists): namespaces "ibm-common-services" already exists
[INFO] ibm-common-services already exists, skipping...
[INFO] Creating namespace cs-control
namespace/cs-control created
[✔] All namespaces in common-service-maps exist
#  Removing ODLM managed Namespace Scope CRs
-----------------------------------------------------------------------
[INFO] deleting namespace scope nss-managedby-odlm in namespace ibm-common-services
namespacescope.operator.ibm.com "nss-managedby-odlm" deleted
[INFO] deleting namespace scope odlm-scope-managedby-odlm in namespace ibm-common-services
namespacescope.operator.ibm.com "odlm-scope-managedby-odlm" deleted
[INFO] deleting namespace scope nss-odlm-scope in namespace ibm-common-services
namespacescope.operator.ibm.com "nss-odlm-scope" deleted
[INFO] deleting namespace scope common-service in namespace ibm-common-services
namespacescope.operator.ibm.com "common-service" deleted
[✔] Namespace Scope CRs cleaned up
# Uninstalling Singleton Operators
-----------------------------------------------------------------------
certmanager.operator.ibm.com "default" deleted
[DEBUG] Cert Manager marked for migration.
subscription.operators.coreos.com "ibm-cert-manager-operator" deleted
clusterserviceversion.operators.coreos.com "ibm-cert-manager-operator.v3.25.3" deleted
# Copying over Licensing Configmaps
-----------------------------------------------------------------------
^C
<EMAIL_ADDRESS>ibm-common-service-operator]# oc get pods -A | grep cert
openshift-marketplace                              certified-operators-z9rzn                                         1/1     Running                      0             8h
openshift-marketplace                              ibm-cert-manager-catalog-glbd4                                    1/1     Running                      0             17h
openshift-marketplace                              ibm-cert-manager-operator-catalog-nphcj                           1/1     Running                      0             17h
<EMAIL_ADDRESS>ibm-common-service-operator]# oc get deploy | grep '0/0'
ibm-common-service-operator            0/0     0            0           17m
operand-deployment-lifecycle-manager   0/0     0            0           17m
<EMAIL_ADDRESS>ibm-common-service-operator]# git checkout scripts
Switched to branch 'scripts'
Your branch is behind 'origin/scripts' by 1 commit, and can be fast-forwarded.
  (use "git pull" to update your local branch)
<EMAIL_ADDRESS>ibm-common-service-operator]# git pull
Updating f59fa7e..992e16e
Fast-forward
 isolate.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
<EMAIL_ADDRESS>ibm-common-service-operator]# ./isolate.sh --original-cs-ns ibm-common-services --control-ns cs-control -v 1
/usr/bin/oc
/usr/local/bin/yq
<EMAIL_ADDRESS>ibm-common-service-operator]# git checkout 10076
Switched to branch '10076'
Your branch is up to date with 'origin/10076'.
<EMAIL_ADDRESS>ibm-common-service-operator]# ./isolate.sh --original-cs-ns ibm-common-services --control-ns cs-control -v 1
/usr/bin/oc
/usr/local/bin/yq
[INFO] Checking for common service operator and odlm pods
[DEBUG] cs op scaled output: false
deployment.apps/ibm-common-service-operator scaled
[INFO] Common Service Operator scaled back to 1
[DEBUG] odlm scaled output: false
deployment.apps/operand-deployment-lifecycle-manager scaled
[INFO] ODLM scaled back to 1
[INFO] Waiting for IBM Common Services CR is Succeeded
-----------------------------------------------------------------------
[✔] Ready use
Error from server (NotFound): configmaps "namespace-scope" not found
#  Wait for Cert Manager pods to come ready
-----------------------------------------------------------------------
[INFO] Checking for cert manager deployed in scope.
[INFO] Cert manager requested in scope, moving on...
No resources found in null namespace.
[INFO] Waiting for deployment cert-manager-operator to be running ...
[INFO] RETRYING: Waiting for deployment cert-manager-operator to be running ... (20 left)
[INFO] RETRYING: Waiting for deployment cert-manager-operator to be running ... (19 left)
[INFO] RETRYING: Waiting for deployment cert-manager-operator to be running ... (18 left)
[INFO] RETRYING: Waiting for deployment cert-manager-operator to be running ... (17 left)
[✔] Deployment cert-manager-operator is running.
[INFO] Waiting for pod cert-manager-webhook to be running ...
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (20 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (19 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (18 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (17 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (16 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (15 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (14 left)
[INFO] RETRYING: Waiting for pod cert-manager-webhook to be running ... (13 left)
[✔] Pod cert-manager-webhook is running.
[✔] Cert Manager ready. Cert Manager operands deployed in cs-control
[INFO] Verifying cert manager is deployed
[DEBUG] cert manager csv count output: 1
[✔] Cert manager deployment verified.
No resources found
No resources found in openshift-operators namespace.
# Pausing Common Services in namespace ibm-common-services
-----------------------------------------------------------------------
deployment.apps/ibm-common-service-operator scaled
deployment.apps/operand-deployment-lifecycle-manager scaled
operandregistry.operator.ibm.com "common-service" deleted
operandconfig.operator.ibm.com "common-service" deleted
[✔] Common Services successfully isolated in namespace ibm-common-services
No resources found in ibm-common-services namespace.
[INFO] Deleting existing Deployment ibm-common-service-webhook in namespace ibm-common-services...
[INFO] Deleting MutatingWebhookConfiguration...
mutatingwebhookconfiguration.admissionregistration.k8s.io "ibm-common-service-webhook-configuration" deleted
mutatingwebhookconfiguration.admissionregistration.k8s.io "ibm-operandrequest-webhook-configuration" deleted

[INFO] Deleting ValidatingWebhookConfiguration...
validatingwebhookconfiguration.admissionregistration.k8s.io "ibm-cs-ns-mapping-webhook-configuration" deleted
#  Creating empty common-service-maps configmap
[INFO] The common-service-maps already exists, skipping
configmap/common-service-maps unchanged
[DEBUG] map ibm-common-services namespace ibm-common-services tmp "ibm-common-services"
[DEBUG] ns ibm-common-services mapto: ibm-common-services
[DEBUG] ns_delimited: "ibm-common-services"
configmap/common-service-maps unchanged
#  Verify all namespaces exist
-----------------------------------------------------------------------
[INFO] Creating namespace ibm-common-services
Error from server (AlreadyExists): namespaces "ibm-common-services" already exists
[INFO] ibm-common-services already exists, skipping...
[INFO] Creating namespace cs-control
Error from server (AlreadyExists): namespaces "cs-control" already exists
[INFO] cs-control already exists, skipping...
[✔] All namespaces in common-service-maps exist
#  Removing ODLM managed Namespace Scope CRs
-----------------------------------------------------------------------
[INFO] deleting namespace scope nss-managedby-odlm in namespace ibm-common-services
[INFO] deleting namespace scope odlm-scope-managedby-odlm in namespace ibm-common-services
[INFO] deleting namespace scope nss-odlm-scope in namespace ibm-common-services
namespacescope.operator.ibm.com "nss-odlm-scope" deleted
[INFO] deleting namespace scope common-service in namespace ibm-common-services
namespacescope.operator.ibm.com "common-service" deleted
[✔] Namespace Scope CRs cleaned up
# Uninstalling Singleton Operators
-----------------------------------------------------------------------
# Copying over Licensing Configmaps
-----------------------------------------------------------------------
[INFO] No licensing configmaps to migrate
[INFO] Licensing marked for backup
configmap/ibmlicensing-instance-bak created
[INFO] Deleting existing Deployment secretshare in namespace ibm-common-services...
deployment.apps "secretshare" deleted
[✔] Singletons successfully uninstalled
[DEBUG] patch string {"name": "INSTALL_SCOPE", "value": "namespaced"}, {"name": "ISOLATED_MODE", "value": "true"}, {"name": "OPERATORCHECKER_MODE", "value": "true"}
subscription.operators.coreos.com/operand-deployment-lifecycle-manager-app patched
[INFO] Waiting for OLM to update Deployment operand-deployment-lifecycle-manager
[✔] Deployment operand-deployment-lifecycle-manager is updated
ibmlicensing.operator.ibm.com/instance configured
# Scaling up ibm-common-service-operator deployment in ibm-common-services namespace
-----------------------------------------------------------------------
deployment.apps/ibm-common-service-operator scaled
deployment.apps/operand-deployment-lifecycle-manager scaled
[INFO] Waiting for IBM Common Services CR is Succeeded
-----------------------------------------------------------------------
[✔] Ready use
[✔] Common Service Operator restarted.
#  Wait for Cert Manager pods to come ready
-----------------------------------------------------------------------
[INFO] Checking for cert manager deployed in scope.
[INFO] Cert manager requested in scope, moving on...
[INFO] Waiting for deployment cert-manager-operator to be running ...
[✔] Deployment cert-manager-operator is running.
[INFO] Waiting for pod cert-manager-webhook to be running ...
[✔] Pod cert-manager-webhook is running.
[✔] Cert Manager ready. Cert Manager operands deployed in cs-control
[INFO] Waiting for configmap namespace-scope in namespace ibm-common-services to be created ...
[✔] Namespace-scope configmap created in ibm-common-services.
[DEBUG] expected ns list: ibm-common-services
[DEBUG] actual ns list: ibm-common-services
[✔] Namespaces in namespace-scope configmap match expected output.
[✔] Isolation complete
<EMAIL_ADDRESS>ibm-common-service-operator]# oc get pods -A | grep cert
cs-control                                         cert-manager-cainjector-5c9db88f64-v7v6r                          1/1     Running     0             7m43s
cs-control                                         cert-manager-controller-64bcf4cbdc-rfj4v                          1/1     Running     0             7m44s
cs-control                                         cert-manager-webhook-8b48ffc5b-r2m68                              1/1     Running     0             7m43s
cs-control                                         ibm-cert-manager-operator-57b44fd654-9stnq                        1/1     Running     0             8m58s
openshift-marketplace                              certified-operators-z9rzn                                         1/1     Running     0             8h
openshift-marketplace                              ibm-cert-manager-catalog-glbd4                                    1/1     Running     0             17h
openshift-marketplace                              ibm-cert-manager-operator-catalog-nphcj                           1/1     Running     0             17h
<EMAIL_ADDRESS>ibm-common-service-operator]#

@bluzarraga hmmm I doubt that we do actually need echo "none"? My assumption is that we will always have Kind CSV existing in the cluster, there is no non-zero status returned from first command
➜  csv_count=$(oc get csv -A | grep "cert-manager"| wc -l | tr -d " ")
➜  echo $?
0
➜  echo $csv_count
2
➜  csv_count=$(oc get csv -A | grep "cert-manager-xxxx"| wc -l | tr -d " ")
➜  echo $?
0
➜  echo $csv_count
0

I agree, we should not be outputting none because I was seeing the csv_count var equal to 0\nnone which is not what we are looking for. I have changed it to echo "" instead. I still think we should echo something because the quick error we are seeing means that that command is failing and immediately exiting instead of getting a 0 value and then failing the subsequent check. That's why we aren't seeing the error message. I added the debug statement right below csv_count=$(${OC} get csv -A | grep "cert-manager"| wc -l | tr -d " ") while running on one of the environments from the issue and it did not output anything before failing.

Tested changes on my cluster, and everything seemed good


Tf 12805/Implement End-to-End Testing for Felony Calculator Class B (No Pros) Branch Second Section

Ticket(s)
Airtable Ticket #12805

Type of change

Testing

Description
This pull request implements end-to-end testing primarily for the second section of the Felony Calculator's Class B (No Pros) branch. The Class B calculator is divided into three sections: Offense, Surrounding Circumstances, and Terms of Offense, with this PR specifically targeting the second section. You can find the link to the Figma File here.
1. Test Structure:

Directory Organization:

Test files are structured within the e2e/felony/class-b/ directory, reflecting a clear hierarchy. Subdirectories represent the two main paths of the Felony Class B calculator: "pros" and "no pros." Additionally, each subdirectory encompasses subdirectories of the sections. The tests in this PR are located in e2e/felony/class-b/no-pros/surrounding-circumstances/pages.

2. Test Criteria (if applicable to page):

Selective Content Testing: Due to the dynamic nature of content updates, testing focuses on essential elements to minimize test breakage. Priority is given to testing:

Correct display and functionality of the Revised Code of Washington (RCW) links.
Verification of "not eligible to vacate" text presence for ineligible pages.

Redirection Validation: Testing includes validation of redirections for user interaction options such as "Yes," "No," and "Continue." Test descriptions may refer to textual cues for clarity, but actual implementations target unique selectors to accommodate future text updates.
Modal Behavior Validation: Expected behavior validation is conducted for the "I'm not sure" modal, ensuring consistent and intuitive user interactions.

Overall PR Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings in the console
[x] There are no new linting errors/problems in my code
[x] I have added tests that prove my fix is effective or that my feature works (if applicable)
[x] I have filled this PR out fully, and cleaned up any extraneous items so that it is clear and easy to understand

Hi @e-papanicolas, I've applied the ESLint fixes to the pull request we discussed earlier. Could you take another look when you have a moment? Thanks in advance!


Unable to reach maximum download speed

I have an image dataset of about 250 1GiB tars on GCS, which I'm loading by using urls = f'pipe:gsutil cat {urls}'.
I tested the maximum download speed with gsutil -m cp ... and got about 750MiB/s with 96 processes (on a 96 vCPU GCP VM), which would amount to about 15000 images/s. I'm testing the data I/O only, no accelerators.
However, using wds.MultiDataset (96 workers) with basic decode, to_tuple etc steps (and minimal cropping with albumentations) and batching to 256 results in much slower download & processing, about 2500 images/s (this is actually already really fast but I'd like to try to get it even faster :D ).
So I'm not bottlenecked by download speed, and CPU utilization for the 96 processes shows <30%, so I'm not bottlenecked by the CPU either...
I profiled the code with pyinstrument and the bottleneck seems to be somewhere in the batching:

I'm working on non-public data, but basically same thing happens with the docs openimages example.
So given that gsutil -m results in fast download speeds but webdataset doesn't, and both use python (?) multiprocessing, maybe gsutil doing something more efficiently here? I don't really know the multiprocessing etc. libraries well at all so I'm at a bit of a loss here...

Although the profile shows batched_ at the top of the stack trace, if you look further down, the actual overhead is in multiprocessing/queues.py; the reason this is attributed to batched_ is because of the use of iterators. The batching itself takes place in default_collation_fn, which has fairly little overhead.
Is there any reason you are using MultiDataset rather than DataLoader? Have you tried DataLoader? DataLoader uses shared memory for large transfers, so it is more efficient in many cases. MultiDataset is useful in special cases, but it's still marked experimental.
Please let me know whether using DataLoader fixes the performance problem.
For really high performance, it's better to use github.com/nvlabs/tensorcom. That performs multithreaded I/O and will eventually support direct-to-GPU data transfers. It's a little different in that you separate the input pipeline from the training code; that actually helps debugging, scaling, and testing, but it's a somewhat bigger change than just dropping in webdataset.Dataset.

Oh I somehow thought Multidataset was the preferred approach! OK will try a Dataloader ASAP.
OK tensorcom sounds interesting too! I'll give the standard Dataloaders a spin first...

OK getting the max download speed of 12000 img/s with PyTorch Dataloader! :smile:
Using a .shuffle(10000) slows it down to 9800 img/s, which is still blazing fast, but then batch "diversity" is about 10% (only 10% of frames are from different clips). I remembered that I was using MultiDataset because of the inter-batch shuffling mechanism, which really helped with the diversity issue... maybe that's also what's slowing down MultiDataset compared to Dataloader?
Using shuffle buffer of 100k => no further slowdown and diversity is about 40% eventually, but then I get RuntimeError: DataLoader worker (pid 26180) is killed by signal: Bus error. It is possible that dataloader's workers are out of shared memory. Please try to raise your shared memory limit.. That's a bit weird, because I'm seeing about 45G of shm used out of 180G... Increasing shm to 300G also doesn't help - crashes at about same iteration.
shuffle buffer = 1M doesn't seem to change anything...
Anyway, I'm tempted to drop the entire frame sampling thing, because I'm definitely not going to give up using Webdataset! :smile:

Great news on the speed. I've tried to add a bit more explanatory text on MultiDataset.
Some additional comments:
While MultiDatset makes .unbatch().shuffle(100000).batch(...) particularly concise, you can just compose the output of a DataLoader with the filter functions in webdataset.filters to get the same effect.  I'll try to make this a little simpler in upcoming versions of the code; filters.py will get IterableDataset as an API, and there may also be a MultiDataset-like wrapper for DataLoader.
For the shared memory, I'm not sure what limit you are setting. The default limit is 18 petabytes. Perhaps you're running out of shared memory segments?

hmm I meant just the OS shared memory, /dev/shm... my working machine has max. 360GB RAM, shared mem default seems to be half of that on GCP and I tested setting that to 300GB. Not sure about shm segments...
Anyway, the OOM doesn't seem to occur if I don't do the frame sampling, so probably something there. Also I think I'll be trying out another dataset so I won't have to worry about the sampling/shuffling thing for now.

You only get 4096 shared memory segments, and DataLoader may be using one per tensor. It's possible that you run out of segments rather than out of memory (the error message would likely be the same). Have you tried using ipcs to see actual limits and usage?
https://datacadamia.com/os/linux/shared_memory
I don't know what your code does in detail, but generally, it's much more efficient to transfer large batches to the DataLoader and then rebatch and reshuffle after the DataLoader (in fact, that's the way you get good performance out of MultiDataset as well).
(Incidentally, Tensorcom avoids all this by doing all the data transfers multithreaded in the background, and it can even use on disk I/O buffering if you want to pre-buffer very large amounts of data.)

Oh didn't know that, I'll take a look. Thanks for the tip! Yeah tensorcom is looking pretty interesting... maybe I'll give that a try too.

Oops forgot to close (max dl speed is reached).

hmm can't see anything with ipcs -a etc. Also tried setting /proc/sys/kernel/shmmni from 4096 to 8192 but that changed nothing...
Anyway, didn't realize batching should be done in the dataset as well! So I'm now trying that with PT DataLoader. I guess I need to use batch_size=1 in dataloader kwargs, and of course the default collate function can't really handle already batched inputs so I'm just using an idendity collate function.
So I'm doing this (using the keys for the sampling part):
dataset = (wds.Dataset(urls)
           .decode('rgb8')  # dict with keys: __key__, jpeg, json
           .pipe(filter_nones)
           .to_tuple('__key__', 'jpg', 'json', handler=wds.warn_and_continue)
           .map_tuple(identity_fn, transform_fn, identity_fn)
           .batched(100)
           .pipe(generate_pairs)
           .shuffle(10000)  # apparently need both shuffles
           .pipe(batched(batchsize=256, partial=True, collation_fn=collate_webdataset))  # NOTE: DataLoader collate_ytbb_wds expects UNBATCHED inputs
           )

then
def collate_id(x_): return x_
dataloader = DataLoader(dataset, num_workers=96, batch_size=1, collate_fn=collate_id)

Speed is really good for 96 workers (won't necessarily need that many, but testing with that now), but I still get the shm OOM issue.
I think I'll give tensorcom a try next!

I'm trying out tensorcom, but having some compatibility issues... zcom.py is using old_div which apparently doesn't exist anymore on py3.7 or something.
Also, the data loading logic seems exactly same as what I was doing above, except for the serve.send([x, y]), so probably the OOM issue will persist here too.
FYI the OOM issue was not due to the frame sampling. I'm getting it all the time now. Takes a lot longer to occur with fewer dataloader workers, but it's still there.
ipcs doesn't show anything for me about which PID is using which shm etc. I had some luck with lsof /dev/shm, which shows something like following:
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF  NODE NAME
python3 12515 heka  DEL    REG   0,22           816675 /dev/shm/pym-8888-edivz7ql
python3 12515 heka    3u   REG   0,22      4096 816675 /dev/shm/pym-8888-edivz7ql (deleted)
python3 12515 heka    4u   REG   0,22      4096 816675 /dev/shm/pym-8888-edivz7ql (deleted)
python3 12527 heka  DEL    REG   0,22           854274 /dev/shm/pym-8893-7iyu0rvh
python3 12527 heka    3u   REG   0,22      4096 854274 /dev/shm/pym-8893-7iyu0rvh (deleted)
python3 12527 heka    4u   REG   0,22      4096 854274 /dev/shm/pym-8893-7iyu0rvh (deleted)
python3 12574 heka  DEL    REG   0,22           841651 /dev/shm/pym-8937-vrtoo0m6
python3 12574 heka    3u   REG   0,22      4096 841651 /dev/shm/pym-8937-vrtoo0m6 (deleted)
python3 12574 heka    4u   REG   0,22      4096 841651 /dev/shm/pym-8937-vrtoo0m6 (deleted)
python3 12640 heka  DEL    REG   0,22           841651 /dev/shm/pym-8937-vrtoo0m6
python3 12640 heka    3u   REG   0,22      4096 841651 /dev/shm/pym-8937-vrtoo0m6 (deleted)
python3 12640 heka    4u   REG   0,22      4096 841651 /dev/shm/pym-8937-vrtoo0m6 (deleted)

the number of these entries seems to saturate to about 16k when using 96 workers (results in OOM after 1450 iterations), and to about 4800 for 48 workers (results in OOM after 3450 iterations). Not sure what this has to do with the shm segments...

aargh I was actually out of RAM, not shared memory! Somehow only up to 10% of shm is utilized... looking into it.


Mods arent working with the new update.

hello first time on here, love your mod. im having issues with the new update you released today, im using a bunch of texture mods from nexusmods and right now they arent working.
they were working before the update so i figure that might have something to do with it. if you could either let me know what i can do or possibly tell me how to downgrade to the previous update.
let me know if i need to submit anything that can help and again love your work man thanks.

Please run SKIM64.exe and do an uninstall / install.
I just pushed 0.8.5 to the update servers, but you'll be waiting 6-11 hours for that to have any affect on you unless you just uninstall and re-install.
I believe 0.8.5 fixes this problem for people affected by it.

confirmed, works just like you said, thanks Kaldaien :D :1st_place_medal: :+1: :100:


Implement ShenangoAsyncUDPSocket

The ultimate test for this implementation would be similar to AsyncUDPSocketTest. Cannot use AsyncUDPSocketTest exactly as it is because IPC (using <IP_ADDRESS> i.e. localhost) is not supported by UDP sockets in Shenango.
Leaving out features like GSO, GRO, ZeroCopy*, TXTime, BSD socket flags like SO_*, fragmentation support, max reads per event.


Feature request: Promise.retry

It would be really great if bluebird would have retry functionality built in. I have built this a few times and I have heard the same from colleagues.
Proposing a new top-level API Promise.retry. Would you be willing to have this in bluebird? If so, I am willing to contribute this.
Promise.retry(() => {
  // Will internally call Promise.resolve(resultOfThisFunction)
  // and potentially Promise.timeout() when a duration is specified
}, {
  // either retries or duration is required, a combination is possible
  retries: <number>,
  duration: <number, millis>,
  // optional, to support exponential backoff and randomized intervals
  getTryDelay(attempt: number): number {
    // exponential backoff
    return Math.pow(attempt, 2);
  }
})

Is something like exponential backoff and randomized interval necessary?

@kontrafiktion: This could be an extension point. Maybe via an option which would allow the user to configure a delay until a next retry. I updated the API proposal to include this via getTryDelay

Promises are composable, unless you can prove a performance benefit - this can be in a library:
let retry = async (fn, retries = 3, backoff = () => 100) => async (...args) => {
  for(let i = 0; i < retries; i++) {
    try {
      await fn(...args);
    } catch (e) {
      if(i === retries - 1) throw e;
      await backoff();
    }
  }
};

You might find p-retry useful.


feature[next]: Allow passing grid_type to field operator

This PR allows specifying the grid type of a field operator, i.e.
@field_operator(..., grid_type=GridType.UNSTRUCTURED)
def foo(...):
   ....

Exactly. Thanks!


Updated peerDependency of react to minimum 16.3.0

getDerivedStateFromProps has been added only for react 16.3.0 and up. Downloading the package and running it on a version < 16.3.0 emits console errors

Published as 6.0.1 - thanks.

@contra no problem! Thanks for the awesome project! 👍


add binary_search and friends

This is a start on fixing #281.
I copied the implementation of these methods from std, except for binary_search_by where I used std directly. Alternatively we could have all implementations directly forward to .as_slice().foobar or .entries.foobar,  if you would prefer that.
I left off the plane binary_search{_keys} on set and map, because they already provide a O(1) way to look up the index for a key. I left them in on Slice because they do not.
For documentation I adapted the first sentence of std, and provided a link to std.
how would you like to see these tested?

Alternatively we could have all implementations directly forward to .as_slice().foobar or .entries.foobar, if you would prefer that.

I would, yeah, at least for partition_point since that's less trivial. The rest can go either way.

I left off the plane binary_search{_keys} on set and map, because they already provide a O(1) way to look up the index for a key. I left them in on Slice because they do not.

That's an interesting point! I wonder if small enough maps/sets might still win by binary search, but if you're too small then even a linear search might be fastest. But anyway, if someone really wants it they can use binary_search_by the same way our impl would, and we could choose to add it later.

how would you like to see these tested?

We haven't been great about that, but let's at least add sanity checks to map/tests.rs and set/tests.rs. But we don't need to be very thorough when it's relying directly on the standard library, and then type checking already proves the remaining differences.

I will work on it. I have PackagingCon for then next few days a may not have much time.

If I had been more awake you would have gone shorter tests. :-P I was not up to determining interesting test cases. So instead you got tests from STD copied in and adapted. They may be more thorough than you asked for.

Same vibe as "If I had more time, I would have written a shorter letter." :)
It's a lot, but that's fine.

I left off the plane binary_search{_keys} on set and map, because they already provide a O(1) way to look up the index for a key. I left them in on Slice because they do not.

That's an interesting point! I wonder if small enough maps/sets might still win by binary search, but if you're too small then even a linear search might be fastest. But anyway, if someone really wants it they can use binary_search_by the same way our impl would, and we could choose to add it later.

Actually, there's still a gap there because binary search also finds the insertion point for missing items. So I think it's good to have the doc comment about scalability, but we should still want the map/set methods for the Err case.
I'll go ahead and add this myself while I'm thinking about it...

Thanks again! I'll put together a release soon.

FYI, I did publish this as 2.1.0 the other day.
I'd be interested to see where you use this, if that code is open.

It is for https://github.com/pubgrub-rs/pubgrub, although the particular performance experiments where this would be useful have not yet pulled their weight. Many data structures have to "backtrack" to reset their state as of some previous point in time. For each individual data structure there are many ways this can be achieved.

The data structure can be "cleared" and reconstructed from other data sources.
Items in the data structure can include a "timestamp" and then the reset is .retain(|_, v| v.timestamp < reset_to_timestamp)
The data structure can be maintained in an ordered fashion and reset by truncating newer modifications. If you need to scan the entire data structure to decide where to cut, then this is the same as the previous. You can have an auxiliary data structure recording timestamp -> cutpoint, for O(1) time reset but additional allocations. Using partition point to make a cut, gives O(ln(size)) reset with no additional space. Which sure seems tempting.

The particular example of this pattern that inspired the PR was contradicted_incompatibilities, which currently uses the first strategy but could easily use the last one. I will definitely drop you a link when/if progress toward using this PR is achieved.


How / whether to handle tests that come with some software

Often the source for some piece of software comes with a set of tests of some sort.  It can be meaningful to execute these tests to get some evidence that the build results function appropriately.
Running tests takes time + resources and sometimes the tests depend on things that are not necessary for building or executing the software.
It is unclear what to do about these types of tests.

I would love to be able to choose per package whether to build & run tests (incl. all the extra deps) or not. This is kinda how it works in Nix now.

I encountered this text about ncurses at LFS:

This package has a test suite, but it can only be run after the package has been installed. The tests reside in the test/ directory. See the README file in that directory for further details.

I found that surprising -- my memories of testing things I've just compiled are before running something like make install.  May be this doesn't happen too often.


new bitcoin.bin How?

Is it possible somehow to create a new .bin file from my own list of btc addresses
so it can get ripemd160 and then the binary 20bytes format. thanks a lot .

Good afternoon, who can tell me how to build this program make does not work.


add 2.5 release notes

Signed-off-by: YANGDB<EMAIL_ADDRESS>Description
add 2.5 release notes
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[x] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1268 (04b0139) into 2.5 (92b7681) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.5    #1268   +/-   ##
=========================================
  Coverage     98.35%   98.35%
  Complexity     3609     3609
=========================================
  Files           346      346
  Lines          8939     8939
  Branches        562      562
=========================================
  Hits           8792     8792
  Misses          142      142
  Partials          5        5

Flag
Coverage Δ

sql-engine
98.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


YAML Templates in Create Resource dock tab

Create resource controls area should contain Template dropdown selector with list of predefined workloads. Clicking any of them would paste yaml template into editor.

That one would be so convenient ! Will this enhancement considered in a next release ?

I'll take the task

An implementation update. YAML templates should be configured in app preferences page by selecting package (or folder) containing all needed templates. Also, there's need to mix packages together, add or remove them. For example, we might have k8s workloads package available by default, and user might want to add AWS resources so they should be active together.
If more that one package active, they should be grouped by the name in the React-Select dropdown. See https://react-select.com/home#getting-started


Run hack/run-gendocs.sh to fix issue, otherwise shippable is failed f…

…or all prs.
cc/ @ArtfulCoder

I think I narrowly beat you with #11474 :)

waiting for shippable

I should totally beat you if Brian didn't stop me at the first place.

Oh, sure, merge her version. ;)


Remove support for deleting subvolume tree

Referencing https://github.com/concourse/concourse/issues/3739 we do a lot of work for deleting volumes (~40% of total cpu resources). Syscall on everything in the subvolume. Lets not do this.
Signed-off-by: Krishna Mannem<EMAIL_ADDRESS>

This is necessary for cleaning up after containers that have run Docker daemons; they leave subvolumes around in the graph directory.
Can we make the subvolume detection cheaper? Is there a btrfs command we can run to list them instead of walking the whole tree? 🤔

@vito yeah after you mentioned this last week, I was working on redoing this. Will play around with
 btrfs subvolume list [options] [-G [+|-]value] [-C [+|-]value] [--sort=gen,ogen,rootid,path] <path>


Register the commands and deploy the code on CFW

Discord provides us with an endpoint to register all our commands to our bots.
The register.ts file runs on our pipeline and hist that endpoint with all the commands that we want to register.
Created a few files to register all the commands given in commands.ts to the bot.
Added a pipeline to deploy code to register the commands and deploy code to the Cloudflare workers for the staging environment.
For this pipeline to work we must set up the environment variables in the GitHub environment.

Everything looks good @RitikJaiswal75 , added a comment. I believe all the tokens are added and github actions are proof tested. Good work

Yes Harshith, I reviewed them over a POC

Everything looks good @RitikJaiswal75 , added a comment. I believe all the tokens are added and github actions are proof tested. Good work

Yes Harshith, I reviewed them over a POC
I am still waiting for the variables to be added to the GitHub environment by @prakashchoudhary07

Have added the env secrets


Opening up the REPL Window has DocumentSite error

Config: Dev12 Update 4
Tried to open up REPL Window from the Quick-Launch window

After trying to open it again, the following entry is added to the activity log:

1207
2015/02/05 21:33:28.740
Error
Editor or Editor Extension
    System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.Repl.PromptMargin..ctor(IWpfTextViewHost wpfTextViewHost, IEditorFormatMap editorFormatMap)
   at Microsoft.VisualStudio.Repl.PromptMarginProvider.CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin parent)
   at Microsoft.VisualStudio.Text.Utilities.ContainerMargin.<AddMargins>b__2(IWpfTextViewMarginProvider mp)
   at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[TExtension,TMetadata,TExtensionInstance](Object errorSource, Lazy`2 provider, Func`2 getter)

I'm getting that activity log error too (but not that dialog).  Dev12 Update 4 too.

For me, only when PTVS is installed


feat: Add prompt flow deployment

This deploys a basic version of the orchestration as a prompt flow end
point
It's not possible to create a flow just using bicep, so also leverages
azd hooks to run a script to create the required resources
Does not support features such as RBAC, advanced image processing,
integrated vectorization etc
Does not currently integrate with the applications, work for this is
ongoing

Required by https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/issues/915

I tried deploying this fresh and it failed
Seems like there are multiple errors inside:
Creating prompt flow
pfazure.flow.create failed with FlowRequestException: Calling create_flow failed with request id: fa856bd9-d8f9-4e3d-ab53-b24ad9f5c596
Status code: 401
Reason: This request is not authorized to perform this operation using this permission. Please grant workspa
Error message: (UserError) This request is not authorized to perform this operation using this permission. Please grant workspace/registry read access to the source storage account.
Code: UserError
Message: This request is not authorized to perform this operation using this permission. Please grant workspace/registry read access to the source storage account.
Target: Storage

, stderr: WARNING: Default enabled including preview versions for extension installation now. Disabled in May 2024. Use '--allow-preview true' to enable it specifically if needed. Use '--allow-preview false' to install stable version only.
Non-retryable server side error: Operation returned an invalid status 'Bad Request'.
[2024-05-30 10:34:00 +0000][promptflow.azure._entities._flow][WARNING] - Failed to resolve environment due to [Errno 2] No such file or directory: '/workspaces/chat-with-your-data-solution-accelerator/infra/prompt-flow/cwyd/requirements.txt'.
Non-retryable server side error: Operation returned an invalid status 'Bad Request'.
Non-retryable server side error: Operation returned an invalid status 'Bad Request'.

@cecheta Can you confirm if you deployed using keys or rbac? I'll try and reproduce it!

I think flow.dag.yaml needs to be added to a gitignore?

@cecheta Can you confirm if you deployed using keys or rbac? I'll try and reproduce it!

I ran:
azd env new pf
azd env set ORCHESTRATION_STRATEGY prompt_flow
azd provision

I think flow.dag.yaml needs to be added to a gitignore?

I tried this, unfortunately it causes the pfazure command to ignore it too :(


[Feature]: custom:mushroom-climate-card HVAC modes to custom values

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Is your feature request related to a problem?
Kind of
Describe the solution you'd like
Love the mushroom cards, is there are way to change the HVAC modes to custom values so the icon changes colour within mushroom-climate-card? I have Domestic Hot Water controls on my heat pump and the options are off, heat pump and performance.  thanks

Describe alternatives you've considered
No response
Additional context
No response

We should have a water heater card. Climate card is only for climate entity.


buildDirname.ts not working well for monorepos + bundlers

Bug description
I'm using prisma + esbuild in a monorepo with serverless framework and am getting the error
Prisma Client could not find its `schema.prisma`. This is likely caused by a bundling step, which leads to `schema.prisma` not being copied near the resulting bundle. We would appreciate if you could take the time to share some information with us.

I traced the issue down to buildDirname.ts, or at least indirectly that's the issue
Effectively it ends up looking for schema.prisma in either:

<awsRootDir>/path/to/handler.js
<awsRootDir>/../../node_modules
<awsRootDir>/../node_modules

The ../../ comes from the fact that in most monorepos node_modules are hoisted two levels up (eg. <monorepRootDir>/packages/myPrismaPackage), but when deployed/bundled the ../../ are meaningless (or inaccessible). I'm not sure what a great solution would be, but I think it would help to add the current working directory as one of the alternative paths
config.dirname = __dirname
if (!fs.existsSync(path.join(__dirname, 'schema.prisma'))) {
  const alternativePaths = [
    ${JSON.stringify(pathToPosix(relativeOutdir))},
    ${JSON.stringify(pathToPosix(relativeOutdir).split('/').slice(1).join('/'))},
    '.',     // <-- Suggested improvement
]

  const alternativePath = alternativePaths.find((altPath) => {
    return fs.existsSync(path.join(process.cwd(), altPath, 'schema.prisma'))
  }) ?? alternativePaths[0]

  config.dirname = path.join(process.cwd(), alternativePath)
  config.isBundled = true
}`

I was able to solve it this way using esbuild-plugin-copy, but it definitely feels like a hack.
const { copy } = require("esbuild-plugin-copy")

...

plugins: [
  copy({
  resolveFrom: "out",
  assets: [
    {
      from: ["../../node_modules/.prisma/client/schema.prisma"],
      to: ["."],
    },
    {
      from: ["../../node_modules/.prisma/client/libquery_engine-rhel-*"],
      to: [".."],
    },
  ],
}),

How to reproduce

Set up a monorepo with at least 2 packages
Set up serverless with esbuild
Install prisma in one of repos
Try to deploy (serverless deploy)
Notice that it can't find the schema.prisma

Expected behavior
Prisma should look for node_modules in the current working directory
Prisma information
Serverless.js
const serverlessConfiguration = {

 ...

 plugins: [
    "serverless-offline",
    "serverless-plugin-monorepo",
    "serverless-esbuild",
  ],

  custom: {
    serverlessOffline: {
      httpPort: 4000,
    },
    esbuild: {
      config: "./esbuild.config.cjs",
    },
    serverlessOfflineSns: {
      port: 4002,
      debug: false,
    },
  },

esbuild.config.js
module.exports = () => {
  return {
    minify: true,
    bundle: true,
    sourcemap: true,
    sourcesContent: false
    keepNames: false,
    exclude: ["aws-sdk"],
    outputFileExtension: ".cjs",
    plugins: [],
  }
}

generator client {
  provider      = "prisma-client-js"
  binaryTargets = ["native", "rhel-openssl-1.0.x"]
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Account {
...
}

import { PrismaClient as PrismaClientBase } from "@prisma/client"

Environment & setup

OS: macOS (locally) and AWS Lambda
Database: PostgresSQL
Node.js version: 18

Prisma Version
prisma                  : 5.5.0
@prisma/client          : 5.5.0
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 475c616176945d72f4330c92801f0c5e6398dc0f (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 475c616176945d72f4330c92801f0c5e6398dc0f (at ../../node_modules/@prisma/engines/schema-engine-darwin-arm64)
Schema Wasm             : @prisma/prisma-schema-wasm 5.5.0-19.475c616176945d72f4330c92801f0c5e6398dc0f
Default Engines Hash    : 475c616176945d72f4330c92801f0c5e6398dc0f
Studio                  : 0.494.0
✨  Done in 0.87s.

Hey @chrisfougner,
Would you mind trying with the latest version to see whether the bug still exists for you? Thank you 🙏


test-branch/execute-job/wrong-commit-sha-on-pr/0377b4a1-6d9a-4e65-bdaa-a6d574bac98b

PR for testing c40d7dd1f7bd138a1a5355d21f9698f6d9e50659

/canonical/self-hosted-runners/run-workflows 3e30a7ed715a852f044529ceccbeb015d323e120


Add EM Stress test using multithreading

Signed-off-by: Pridhiviraj Paidipeddi<EMAIL_ADDRESS>

@stewart-ibm Now I have added source code for tlbie_test. Thanks @npiggin for sharing the source code.

Rebased and tested with latest changes. So merged the PR.


stupid psychengine wont compile correctly cuz the main.hx gives me errors

Describe your problem here.
la error is:
source/Main.hx:14: characters 8-25 : Type not found : states.TitleState
source/Main.hx:89: characters 19-22 : Type not found : Lua
source/Main.hx:90: characters 12-20 : Class has no field instance
source/Main.hx:90: characters 23-37 : Not enough arguments, expected name:String, scheme:KeyboardScheme
source/Main.hx:100: characters 33-37 : Class has no field data
source/Main.hx:154: characters 21-28 : String has no field replace
source/Main.hx:155: characters 21-28 : String has no field replace
source/Main.hx:181: characters 3-16 : Type not found : DiscordClient
source/Main.hx:119: characters 3-16 : Type not found : DiscordClient
source/Main.hx:123: characters 3-7 : Type not found : FlxG
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no sirrebob

remove states. in initialState

where exactly..?

here, replace all your imports in main.hx with these ```haxe
package;
import flixel.graphics.FlxGraphic;
import flixel.FlxG;
import flixel.FlxGame;
import flixel.FlxState;
import openfl.Assets;
import openfl.Lib;
import openfl.display.FPS;
import openfl.display.Sprite;
import openfl.events.Event;
import openfl.display.StageScaleMode;
import lime.app.Application;
#if desktop
import Discord.DiscordClient;
#end
//crash handler stuff
#if CRASH_HANDLER
import openfl.events.UncaughtErrorEvent;
import haxe.CallStack;
import haxe.io.Path;
import sys.FileSystem;
import sys.io.File;
import sys.io.Process;
#end
using StringTools;

and don't paste 0.7 code into your mod unless you know what you're doing

ok so it did fix some errors but there are still some errors,
the errors i got are:
source/Main.hx:90: characters 19-22 : Type not found : Lua
source/Main.hx:91: characters 12-20 : Class has no field instance
source/Main.hx:91: characters 23-37 : Not enough arguments, expected name:String, scheme:KeyboardScheme
source/Main.hx:101: characters 33-37 : Class has no field data
source/Main.hx:120: characters 17-22 : Class has no field start

and don't paste 0.7 code into your mod unless you know what you're doing

any ideas?


[Snyk] Upgrade debounce from 1.2.0 to 1.2.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade debounce from 1.2.0 to 1.2.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago, on 2021-03-09.

Release notes

Package name: debounce

1.2.1 - 2021-03-09Release 1.2.1

1.2.0 - 2018-08-14Release 1.2.0

    from debounce GitHub release notes

Commit messages

Package name: debounce

8be734c Release 1.2.1
133fffd Add CONTRIBUTORS and MIT LICENSE file. (#28)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Base: 83.58% // Head: 83.49% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (01be911) compared to base (bac82ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   83.58%   83.49%   -0.09%
==========================================
  Files         223      223
  Lines       33244    33232      -12
==========================================
- Hits        27786    27747      -39
- Misses       5458     5485      +27

Flag
Coverage Δ

ui-tests
37.49% <ø> (-0.07%)
:arrow_down:

unitexamples-tests
74.62% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

panel/tests/ui/io/test_jupyter_server_extension.py
47.82% <0.00%> (-52.18%)
:arrow_down:

panel/tests/pane/test_base.py
84.00% <0.00%> (-12.00%)
:arrow_down:

panel/tests/util.py
87.25% <0.00%> (-4.01%)
:arrow_down:

panel/tests/ui/io/test_convert.py
92.92% <0.00%> (-2.66%)
:arrow_down:

panel/io/reload.py
69.56% <0.00%> (-2.18%)
:arrow_down:

panel/tests/command/test_serve.py
83.95% <0.00%> (-1.42%)
:arrow_down:

panel/tests/conftest.py
87.50% <0.00%> (-0.92%)
:arrow_down:

panel/pane/base.py
87.91% <0.00%> (-0.84%)
:arrow_down:

panel/io/state.py
69.46% <0.00%> (-0.35%)
:arrow_down:

panel/io/jupyter_server_extension.py
0.00% <0.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Send pigeon version with keepalive message

Related Github tickets

https://github.com/VolumeFi/paloma/issues/462

Background
We want to start enforcing a minimum version of Pigeon running against Paloma.  To do this, Pigeon needs to send its current version along with the keepalive messages.
There is also a bit of unrelated test updates to clean up nearby tests
Testing completed

[x] test coverage exists or has been added/updated
[x] tested in a private testnet

Breaking changes

[x] I have checked my code for breaking changes

@byte-bandit That definitely warrants some further discussion.  Most chains separate these two, likely because not all nodes need to run a Pigeon.  Only validators do.  We should definitely weight the pros and cons of merging the two.

But to the question of monorepo, I think most OTHER cross-chain cosmos chains keep their relayer and cosmos-sdk in the same repo. I think only Sommelier split it out because it's relayer/orchestrator was written in Rust.

@ToasterTheBrave @taariq
Just to be clear, organising Code in a mono repo does not mean ending up with one binary. Deployment wise, nothing would have to change. But both binaries are easily tracked down to one shared git version/commit hash if needed. You start to think of a distributed system more like a global snapshot as opposed to individual fully autonomous units.
But yeah, it's a bigger discussion. We can move it to Notion.


Firebase deprecating direct channel API

Firebase has stated they will deprecate their direct channel API from V7 and that within the next year they will remove the backend features for this. It seems like this plugin forces direct channel to be true:
[FIRMessaging messaging].shouldEstablishDirectChannel = true;

Is this required for all apps to receive push notifications in the foreground? Can it be set to false by some configuration in the plist of the application?

I was same issue

Firebase has stated they will deprecate their direct channel API from V7 and that within the next year they will remove the backend features for this

Please can you provide a link to the documentation which states this.

@dpa99c I'm not the original poster but here's the email I received from Firebase today:

Hi company
We are writing to let you know that Firebase Messaging iOS Direct Channel API support is marked for deprecation. Firebase Messaging iOS SDK version 7.0 will be a breaking change where the SDK will no longer support iOS Direct Channel API.
What do I need to know?
Firebase Messaging iOS Direct Channel has been used for sending data to apps when they are in the foreground and for upstream messages. The Firebase Messaging iOS SDK v7.0 (slated to be released in September 2020) will no longer support the iOS Direct Channel API**. Your app will break if you update to the Firebase Messaging iOS SDK v7.0 without migrating off the iOS Direct Channel API.**
We are removing this feature in favor of natively supported messaging features provided by Apple Push Notification Service.
To prevent disruptions to your users, we recommend that you discontinue use of the iOS Direct Channel API as soon as possible. Please note that for the time being, your existing users can still continue to receive messages via the iOS Direct Channel API. However, within the next year, we will follow up this announcement with plans to deprecate the backend service support which may break your app with older versions of the Messaging iOS SDK (prior to v7.0).
What do I need to do?

To prevent disruptions to your users, we recommend that you discontinue use of the iOS Direct Channel API and use an alternative such as FCM’s APNs interface for downstream data message delivery.

If you are not using FCM HTTP v1 API. FCM HTTP v1 API provides full APNs support. If you need to continue using FCM Legacy API, you can:

Add the `content_available` key to your payload if you continue to use the legacy sender API.

For upstream messages, make arrangements to send messages directly from your app to your servers.

For real time updates, you can use Cloud Firestore, or other services.

You are an owner of the following Firebase project(s) that uses Firebase Messaging iOS Direct Channel API:

** (my projects) **

As always, if you have any questions or need any assistance, feel free to reach out to support for more assistance.

Can confirm - I got the same email

Got the same e-mail but never specified which one to use.
Is there any way to verify if the app uses APN or Direct Channel?

@dpa99c Thanks for the quick turn around on this, I see that you've merged the changes to master, but I don't see a new plugin/package version - is one required?

@znewsham this will go out in the next release (hence the label "ready for release").
Until then, if you want this functionality, you can install the plugin directly off the master branch.
However given the Firebase Messaging iOS SDK v7.0 is slated to be released in September 2020 and backend support will only subsequently be disabled "within the next year", I don't see any urgent rush to integrate this immediately.

Awesome, thanks for the response - I just wanted to get a rough timeline!


ENDOC-438 First draft config profiles tutorial

Please check for accurate language.

I added another note on https://entando.myjetbrains.com/youtrack/issue/ENG-3245. I'm not sure yet that this feature is usable as-is.


Fehler beim einsammeln in FireFlay

Version
2.0.3
Description
Sehr geehrte Damen und Herren,
Leider kann ich trotz anschließen meines Ledger meine Auszahlung der "iota Belohnung" nicht einsammeln. Anbei ein foto von der Fehlermeldung.
Was kann ich machen damit ich diese einsammeln kann?

Expected behaviour
Einsammeln meiner iotas
Actual behaviour
Fehlermeldung siehe anhang
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
No response
Operating System
Windows
Diagnostics
No response
Developer Profile
No
Profile Type
Software (Stronghold)
Staking
None
Crash Status
None of the above
Error Messages
No response
Error Logs
No response
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You dont really need to collect your rewards, once they are unlocked they compute as part of your available balance. What happens behind the scenes is what we call "output consolidation" which needs at leads 2, and it seems like you only have 1, so until the next payout you wont be able to press "collect", but that doesnt mean that you cant spend those funds, you can. We improved the user experience in https://github.com/iotaledger/firefly/pull/7609 the improvement will be included in the next release


ActionView::Template::Error in admin/communication/websites/pages#preview

Error in Osuny
ActionView::Template::Error in admin/communication/websites/pages#preview
undefined local variable or method `heading_level' for an instance of #Class:0x00007f559a45d840
View on Bugsnag
Stacktrace
app/views/admin/communication/blocks/templates/posts/layouts/_carousel.html.erb:12 - block in _app_views_admin_communication_blocks_templates_posts_layouts__carousel_html_erb___123833119490798207_269500
app/views/admin/communication/blocks/templates/posts/layouts/_carousel.html.erb:4 - _app_views_admin_communication_blocks_templates_posts_layouts__carousel_html_erb___123833119490798207_269500
app/views/admin/communication/blocks/partials/_layout.html.erb:6 - _app_views_admin_communication_blocks_partials__layout_html_erb__486456909539946228_261660
app/views/admin/communication/blocks/templates/posts/_show.html.erb:23 - _app_views_admin_communication_blocks_templates_posts__show_html_erb___3260567288668226024_266000
app/views/admin/communication/blocks/headings/_show.html.erb:5 - block in _app_views_admin_communication_blocks_headings__show_html_erb___2589187803691700654_259480
app/views/admin/communication/blocks/headings/_show.html.erb:4 - _app_views_admin_communication_blocks_headings__show_html_erb___2589187803691700654_259480
app/views/admin/communication/blocks/content/_show.html.erb:6 - block in _app_views_admin_communication_blocks_content__show_html_erb___2213526896871432192_259460
app/views/admin/communication/blocks/content/_show.html.erb:5 - _app_views_admin_communication_blocks_content__show_html_erb___2213526896871432192_259460
app/views/admin/communication/websites/pages/preview.html.erb:6 - _app_views_admin_communication_websites_pages_preview_html_erb__620187116771555470_259440
app/controllers/admin/communication/websites/pages_controller.rb:59 - preview
app/controllers/application_controller/with_locale.rb:19 - switch_locale

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
ActionView::Template::Error in admin/communication/websites/pages#preview


Report Dockerfiles that appear to be running as root

Would it be appropriate and/or feasible to report on Docker images that do not set a non-root user?

https://pythonspeed.com/articles/root-capabilities-docker-security/

Closing issue, not going to maintain project anymore with so many other tools available.