nvcc error: string_view.h: constexpr function return is non-constant

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): This is what the bug is about, see below.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: no
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v1.11.0-0-gc19e29306c 1.11.0
Python version: 3.6.3
Bazel version (if compiling from source): none
GCC/Compiler version (if compiling from source): 5.4.0
CUDA/cuDNN version: 8.0, 9.0, 9.1
GPU model and memory: doesn't matter
Exact command to reproduce: See below.

Describe the problem
Compiling some custom native op with nvcc fails, with basically this error:
absl/strings/string_view.h(501): error: constexpr function return is non-constant

Compiling the same code with g++ does not have this issue. This seems specifically related to the CUDA frontent cudafe.
Source code / logs
Example code test.cpp:
// For Eigen::GpuDevice.
#define EIGEN_USE_GPU 1

// For Eigen::ThreadPoolDevice.
#define EIGEN_USE_THREADS 1

#include "tensorflow/core/framework/op.h"
#include "tensorflow/core/framework/shape_inference.h"
#include "tensorflow/core/framework/op_kernel.h"
#include "tensorflow/core/common_runtime/device.h"

#include <cuda.h>
#include <cuda_runtime.h>
#include <cublas_v2.h>
#include <math_constants.h>

#include "tensorflow/core/platform/stream_executor.h"

Compile command:
/usr/local/cuda-8.0/bin/nvcc -shared -O2 -std=c++11 -I /u/zeyer/py-envs/py36-tf111/lib/python3.6/site-packages/tensorflow/include -I /u/zeyer/py-envs/py36-tf111/lib/python3.6/site-packages/tensorflow/include/external/nsync/public -I /usr/local/cuda-8.0/include -L /usr/local/cuda-8.0/lib64 -x cu -DGOOGLE_CUDA=1 -Xcompiler -fPIC -D_GLIBCXX_USE_CXX11_ABI=0 -g test.cpp -o test.so -lblas -lf77blas -L/u/zeyer/py-envs/py36-tf111/lib/python3.6/site-packages/numpy/.libs -lopenblasp-r0-8dca6697.3.0.dev -L/u/zeyer/py-envs/py36-tf111/lib/python3.6/site-packages/tensorflow -ltensorflow_framework -v -Xcompiler -v
The full compile output (including some more warnings) can be seen here in the StackOverflow question.

A workaround is to add the flag -DNDEBUG .

Hm, yea, although I would want that my asserts will fail.
Maybe -Dconstexpr= would be another option (did not try), although not sure if that has other drawbacks.

Same error compiling a custom op.
Environment:
Ubuntu 16.04
GCC 5.5.0
CUDA 9.0 9.2 / cuDNN 7.1
Python 2.7.12
Tensorflow 1.11.0
Fixed by adding the flag -DNDEBUG.

@albertz Did the workaround help to solve your issue?

A workaround is to add the flag -DNDEBUG .

@ymodak As I said:
I want that my asserts will fail, so -DNDEBUG is not an option for me (and anyway, this is an ugly workaround, and doesn't really solve the problem itself).
Maybe -Dconstexpr= would be another option (did not try; not sure if less ugly), although not sure if that has other drawbacks.

I second @albertz: the problem can be masked as suggested by @ppwwyyxx, but it's not addressing the source of the issue.
In my environment, I can get past this error by replacing the call to ABSL_ASSERT() in tensorflow/include/absl/strings/string_view.h:501 by 0 (but it is arguably just as ugly as -DNDEBUG).

Nagging Assignee @gunan: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Also seeing this on Ubuntu 18.04, GCC 7.3, Python 3.5, CUDA 9.2.
I worked around by just commenting out the offending line in tensorflow/include/absl/strings/string_view.h:501.

Another hack is to remove the ABSL_ASSERT from the offending line. wfm, ymmv.

I'm also affected by this issue and similar problems when attempting to compile in debug mode (normal compilation works fine). #27744
It seems to me like the TF community has found some workarounds like defining NDEBUG and commenting out a string_view line and making it work.
But what is the root cause of this issue? #28091 seems to suggest to just quit CUDA debugging altogether. Looking at this thread and related issues  it looks like there's a large amount of people still affected by this.

I am also affected by this issue cuda 10.2 and the -DNDEBUG flag workaround seems to work for me .

Another hack is to remove the ABSL_ASSERT from the offending line. wfm, ymmv.

Hello, I'm compiling cuda code using NVCC command, and also met this issue, simply add -DNDEBUG doesn't slove all related errors(I've 5 errors related). Just curious when is the ABSL_ASSERT? Can you explicitly tell me?

Another hack is to remove the ABSL_ASSERT from the offending line. wfm, ymmv.

Hello, I'm compiling cuda code using NVCC command, and also met this issue, simply add -DNDEBUG doesn't slove all related errors(I've 5 errors related). Just curious when is the ABSL_ASSERT? Can you explicitly tell me?

Look at the error:
absl/strings/string_view.h(501): error: constexpr function return is non-constant

It says, in file absl/strings/string_view.h, in line 501, there is some error.
When you look into that file, in this line, you will find ABSL_ASSERT. The suggestion was to just remove that.
But as you say, -DNDEBUG doesn't work for you, I suspect that you actually have some different error. You should write what error you get exactly (and what CUDA version, what TF version).

Another hack is to remove the ABSL_ASSERT from the offending line. wfm, ymmv.

Hello, I'm compiling cuda code using NVCC command, and also met this issue, simply add -DNDEBUG doesn't slove all related errors(I've 5 errors related). Just curious when is the ABSL_ASSERT? Can you explicitly tell me?

Look at the error:
absl/strings/string_view.h(501): error: constexpr function return is non-constant

It says, in file absl/strings/string_view.h, in line 501, there is some error.
When you look into that file, in this line, you will find ABSL_ASSERT. The suggestion was to just remove that.
But as you say, -DNDEBUG doesn't work for you, I suspect that you actually have some different error. You should write what error you get exactly (and what CUDA version, what TF version).

Thank you. Well, my CUDA=8.0, TF=1.15.0,
one of my error says:
site-packages/tensorflow_core/include/absl/strings/string_view.h(495): error: constexpr function return is non-constant,
So I checked it out.
static constexpr size_type CheckLengthInternal(size_type len) {
    return ABSL_ASSERT(len <= kMaxSize), len;
  }

So, should I change this block of code to:
static constexpr size_type CheckLengthInternal(size_type len) {
    return 0, len;
  }

? 0 or 1?

Another hack is to remove the ABSL_ASSERT from the offending line. wfm, ymmv.

Hello, I'm compiling cuda code using NVCC command, and also met this issue, simply add -DNDEBUG doesn't slove all related errors(I've 5 errors related). Just curious when is the ABSL_ASSERT? Can you explicitly tell me?

Look at the error:
absl/strings/string_view.h(501): error: constexpr function return is non-constant

It says, in file absl/strings/string_view.h, in line 501, there is some error.
When you look into that file, in this line, you will find ABSL_ASSERT. The suggestion was to just remove that.
But as you say, -DNDEBUG doesn't work for you, I suspect that you actually have some different error. You should write what error you get exactly (and what CUDA version, what TF version).

Another error which appears twice is:
/include/absl/strings/str_cat.h(269): error: expression must have a constant value

I go to that file, and found that it's an template, how to comment this out, I have no idea, can you help me to check it out?
Here is the 269 line:
// Normal enums are already handled by the integer formatters.
  // This overload matches only scoped enums.
  template <typename T,
            typename = typename std::enable_if<
                std::is_enum<T>{} && !std::is_convertible<T, int>{}>::type>
  AlphaNum(T e)  // NOLINT(runtime/explicit)
      : AlphaNum(static_cast<typename std::underlying_type<T>::type>(e)) {}

return len; should do the trick, no zero or one needed.
As for your second question, you could try to remove the enable_if:
template <typename T> AlphaNum ...

@albertz We are checking to see if you still need help on this issue, as you are using an older version of tensorflow(1.x) which is officially considered as end of life. We recommend that you upgrade to 2.6 which is latest stable version of TF and let us know if the issue still persists in newer versions. please check https://github.com/tensorflow/tensorflow/issues/22766#issuecomment-679909377  Thanks!

I just tried with GCC 9.3.0, CUDA 11.0 and TF 2.3.1 and I don't see the problem anymore.
I'm not exactly sure since what (TF?) version that problem is gone.

@albertz  if it is resolved then please feel free to move this issue to close status ? Thanks!


Zookeeper, etcd support multiple IPs but datastore.newClient only takes one.

Zookeeper, etcd support multiple ips but datastore.newClient only takes one.
This can cause inability to restart docker if the Zookeeper or etcd peer specified in kvstore argument goes down -- even if the other n-1 are up.
Further it appears that this list is the complete list of alternate backends that go-zookeeper/etcd client libraries will try in the event of a failure, meaning that if only one is specified it constitutes a single point of failure.

Thanks for reporting the issue. we will take a look at this

@alfredr It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926


provide rustfmt.toml

For better style consistency, this introduces a rustfmt.toml.

@LeoniePhiline I'd like to introduce a rustfmt.toml to encourage consistency with imports and comment line wrapping. If this is too noisy, that's okay, it's not super important.

I think these are a good set, matching my own preferences.
I would like to also propose a rather linting configuration, as detailed here: https://github.com/zslayton/cron/pull/117#issuecomment-2444128976

I am done reviewing.

Does imports_granularity also summarize self:: and super:: under crate::?

It does not. There may be some way to configure that, but I haven't looked into that.

Ah, I see.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_strings = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_strings = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.

Alright. :D

Do we benefit from +nightly?

Unfortunately, yes:
cargo +stable fmt --all -- --check
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_strings = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_strings = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.


Fix failing tests on Windows

Since we now have Appveyor integration, we should make all tests green as well on Windows.

Since this issue was created from the roadmap, do I need to add the 'Closes #xyz' directive or will it be closed automatically?

@sudo-suhas it would be cool to reference the issue from commit so it's automatically closed here. Has no relation to the roadmap AFAIK.


238 Major release: Summer '22 :sun_with_face: :sunglasses: :beach_umbrella:

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below:

[ ] Any net new LWC work has JEST test coverage 50% or above
[ ] Default Sa11y tests pass for all LWC components
[ ] 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
[ ] 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
[ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
[ ] Make sure that ACs are updated (if any gaps)
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer

[ ] Pull Request contains draft release notes
[ ] Labels, help text, and customer facing messages are reviewed by Docs
[ ] QE story level testing completed

No 238 changes.


Temporarily fix remux

Binaries in this package that are being stripped are failing with the following error: remux: remux: no version information available (required by remux)
When they aren't stripped there is no error, and when manually stripping a non-stripped binary, the following warning is raised: warning: allocated section .dynstr' not in segmen`. The binary will then segfault if you run it on device.

Superceded by #898


Add my contribution in ASCII art coding challenge

Video: https://youtu.be/fJMaec6zi9k

Community Contribution
Link to live project, video, or image:

Sharing

[x] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

Did I do something wrong? The worflows says waiting for approval

This is great, thank you for sharing!!


Flows Using ECS Task infrastructure block crash when paused if using reschedule=True

When using the pause_flow_run function with argument reschedule=True on a flow with an ECS Task infrastructure block the expectation is that when paused the ECS task will be deprovisioned and the flow will remain in a Paused state.  When resumed a new ECS task will be provisioned and run the remaining flow tasks (similar to raise PAUSE in 1.0).
What I am seeing is that when the flow hits the Paused state the ECS task deprovisions and then the flow moves from a Paused state to a Crashed state.  The final State Message is "Flow run infrastructure exited with non-zero status code -1.".  The last log message on the ECS task is "21:55:46.456 | INFO | prefect.engine - Engine execution of flow run '09d19369-66ad-4f96-837a-09b713e3ff46' is paused:"
I am using a ECS Task infrastructure block on Fargate.  There doesn't seem to be any error other than that cloud is expecting the infrastructure to still be present and it is not.
Simple example flow code I am using:
from prefect import get_run_logger
from prefect import flow, task, pause_flow_run

@task(name="First Task", persist_result=True)
def first_task():
    logger=get_run_logger()
    logger.info('first task')
    return None

@task(name="Second Task", persist_result=True)
def second_task():
    logger=get_run_logger()
    logger.info('second task')
    return None

@flow(name="Test pause", result_storage='s3/prefect-results')
def test_pause_flow():
    first_result = first_task()
    pause_flow_run(reschedule=True, timeout=64800)
    second_result = second_task(wait_for=[first_result])

The ECS task definition was created using this terraform:  https://github.com/PrefectHQ/prefect-recipes/tree/main/devops/infrastructure-as-code/aws/tf-prefect2-ecs-agent

Thanks for opening an issue @jbnitorum! This appears to be a bug. I'll start investigation in our environment so that I replicate and formulate a fix for this issue.


feat: Automatic configuration of file system ACL.

This feature ensures the otel container will have read access to /var/log while running in nonroot mode by default. It also ensures the container will have rw access to its checkpoint directory.
Fixes #47
Whats new:

Use FS ACL rather than chown to append the new user/group to file system permissions this is safer as a patch/update on the node is less likely to undo it.
Apply the guidance originally provided in README.md as an init container so its always applied in the case of node scale out
Change the UID/GID to one that is not the most common example on the internet.

Alternatives considered:

Do nothing: Keep the changes required for the node as customer responsibility. Customer feedback was consistent this wasn't a desirable outcome.
Kind: JOB Can't ensure run once per node
Run container as root by default. While this would work its not needed and could have consequences.

@rfaircloth-splunk hmm. I tried a several variation from this PR but this isn't working. I get permission denied error no matter what i do.
I will keep looking into how to make it work.
please share if you have any more info on it.

@rockb1017 has there been any update on this? I am currently working with a customer who is looking to utilise the solution after GA but have raised security concerns and also spotted this issue and are looking for updates.

Hello, yes. I have made updates and pushed commit to https://github.com/signalfx/splunk-otel-collector-chart
This repo will go away and GA will be at above repo.

@rockb1017 Thanks for the update. Can you please point me to the exact commits in the above repo so that I can share with the customer?

oh i just realized it hasn't been merged.
https://github.com/signalfx/splunk-otel-collector-chart/pull/263


Validate we're not using the old testing stuff

Signed-off-by: Doug Davis<EMAIL_ADDRESS>

maybe this could be appended to test-integration-cli instead of a validation on its own, because it only applies to that right

@jfrazelle  I can do that if you want but then I think it would need to check all files instead of just the ones changed by under the current commit.  Is that ok?

janky happy now

I still kinda think it should just be an extra test before running integration-cli but this is good too LGTM
ping @tianon

I agree with @jfrazelle that this feels like a heavyweight solution to the problem of "don't use testing.T in new _test.go files", but it's probably good enough for now anyhow.
Maybe we could adjust @GordonTheTurtle to do this check in the future instead. :innocent:

@tianon got all of your edits in there

@tianon you ok with the edits?

LGTM

LGTM


ttf-carlito-kagayaki: several errors

ttf-carlito-kagayaki: don't pass validity check
After solve this:
cd: carlito: No such file or directory

ok, the problem is the change of URL for source of font from http://mirrors.ctan.org/fonts/carlito.zip to http://commondatastorage.googleapis.com/chromeos-localmirror/distfiles/crosextrafonts-carlito-20130920.tar.gz

#5

Fixed in 6b261ce58d66a225f5a27367f5bfc5825e793880


The returns of mcmc_lc should store the chisq or lnlikelihood values corresponding to samples

Unlike sncosmo.nestlc, sncosmo.mcmc_lc does not store the chisq or log likelihood values values of the samples. While this can be easily done using the sncosmo.chisq function, this information must be getting calculated during the run, so it should be possible to keep this information and not have to recalculate it. And, I suppose,  it would be good to give it the same attribute name as in nest_lc
logl: 1-d ndarray (length=nsamples); log(likelihood) for each sample.

There is a good reason for this, of course: the density of MCMC samples is proportional to the posterior, whereas in nested sampling, you need the value of the posterior at each sample to properly weight the samples.

True, this makes it essential for logl be there for nest_lc, but there are applications to mcmc_lc where this is also useful like Importance sampling the results to a slightly different likelihood. Also, it would be useful to use this in calculating the returned parameter results differently.
I would like to set up tests on how well importance sampling works for adding model covariance to the cases without model covariance.

I'd be OK with adding this, but we have to clear up the terminology. MCMC (specifically emcee) samples the posterior, so it's not the same as logl in nest_lc.
logprob might be a good name. emcee provides this as flatlnprobability.

Ok maybe I am confused about terminology. But I am not looking for the posterior distribution. As you said, that is already there as the number density of samples. What I am looking for is the likelihood for each of the samples, or chisq for each of the samples (equivalent to likelihood if the likelihood is gaussian and the covariance constant), which were evaluated during the run and provided to the sampler.

The only thing provided to the emcee sampler is a function that calculates the posterior (see the docs), and so emcee only stores posterior samples.

You don't really need to know likelihoods to carry out importance sampling though. You just need to know the ratio of the prior to the fiducial prior at each sample. The nominal sample weights are one and the new sample weights are that ratio.

Ok. We are definitely trying to use different terminology.
Let us try to forget about terminology for a minute and take a step back:
In the usual problem:
We want to calculate $ P(\theta \vert data) $ where $\theta$ are a set of parameters for the light curve model like ${t_0, x_0, x_1, c}$ for the SALT model where the redshift is known, and data is the photometric data as expressed in sncosmo as a set of mjd, flux, fluxerror, (and let us keep model covariance out). To do this with an MCMC, we need to supply a prior function $P(\theta)$ and a function that calculates the chisq for each point $\theta$. For us this is the sncosmo.chisq function, that is evaluated. These evaluated  values for the samples are what I am looking for.
Using the likelihoods: Now, suppose someone said that the data is the same, the priors on the model parameters are the same, but the chisq function was (slightly) different (as would be the case due to a model covariance), and you have the samples from an MCMC run whose densities are the posteriors with the first chisq function. This can be done by reweighting the samples with ratios of the likelihood values. That is what I was calling importance sampling.

If the prior is the same, then the the ratio of likelihood values is the same as the ratio of posterior values, so just store the posterior values and reweight by new posterior values.
I think the terminology is pretty clear here: posterior = likelihood * prior. You can't store the likelihood values from emcee, because emcee never sees them; it only gets the product of likelihood * prior.
What's the point of using importance sampling to reweight by the likelihood values though? Usually people use importance sampling to reweight by the prior when the prior is cheap to calculate but the likelihood is expensive. If you are going to recalculate likelihood values, why not just run another MCMC?

If the prior is the same, then the the ratio of likelihood values is the same as the ratio of posterior values, so just store the posterior values and reweight by new posterior values.

Yes, that would work for what I am thinking of... I guess you would be storing un-normalized posteriors and that is fine.

I think the terminology is pretty clear here: posterior = likelihood * prior.

Agree on the definition ... but I will defer agreement on terminology being clear :) .

You can't store the likelihood values from emcee, because emcee never sees them; it only gets the product of likelihood * prior.

Because it is calculated from two different functions the likelihood and prior (and by the way feeding the values as a product is not essential in an MCMC sampler in general, even though you need information from both the prior and the likelihood), you really have both the values before handing it off to emcee. Now, maybe emcee hands back the list of samples at the end but does not have a way of interacting and telling us that a sample has been accepted: That could make it technically difficult to do this.
Incidentally, if my prior is the posterior from a different experiment for which I have samples but not a numerical formula, how does this work?

What's the point of using importance sampling to reweight by the likelihood values though? Usually people use importance sampling to reweight by the prior when the prior is cheap to calculate but the likelihood is expensive. If you are going to recalculate likelihood values, why not just run another MCMC?

That is a good point. Obviously, it goes without saying that you certainly could, but then you go through burn-in, rejected samples, correlated samples etc, whereas you could do an MCMC, thin your samples and apply the weighting on the thinned samples to re-evaluate the posterior. On the flip side, you do have to worry about whether it is accurate enough, and so for a one time deal, it is probably not worth it. But if you are going to repeat similar exercises, and can convince yourself that it accurate enough(by testing on some cases if you are pedantic enough)  it could be a time saver.

Agreed. Seems like the action item here is to pass emcee's flatlnprobability to a Result.logprob attribute in the result from mcmc_lc().

Incidentally, if my prior is the posterior from a different experiment for which I have samples but not a numerical formula, how does this work?

You'd have to approximate those samples with a continuous function.

Yes, that sounds like the action item, but let us sit on it a bit. I plan to play a bit with emcee a bit to make sure that these quantities are what I think they are.

You'd have to approximate those samples with a continuous function.
I see.

Should we close this issue or do you still think logprob would be useful?

I think we should close this issue for now. In the meantime I talked to @dfm about this, and he said he had a hack to get the likelihood values. So, I think it would be productive to implement his hack, but am kind of swamped at the moment.

I imagine the hack is something like
loglike = sampler.flatlnprobability - np.array(map(lnpriorfn, sampler.flatchain))

where lnpriorfn gives the log prior for a given point in parameter space.
Closing this for now. Feel free to reopen later.


top-level webpage for dahak-metagenomics?

This page does not contain anything:
https://dahak-metagenomics.github.io/
Someone who is curious might be interested to learn what the top-level organization is?

Thanks for opening this issue! We've got some content in the dahak-metagenomics/dahak repo so I think we can turn that into an HTML page.
Also see dahak-metagenomics/dahak#76

done - see dahak-metagenomics.github.io/ and corresponding repo.


fix: invalid all require.cache in watching

I found if some lib depends on vue or vue-router, require.cache cannot remove completely #2288 , so it's better to remove all caches.

Codecov Report

Merging #2316 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2316      +/-   ##
==========================================
- Coverage   98.36%   98.36%   -0.01%
==========================================
  Files          15       15
  Lines         981      980       -1
==========================================
- Hits          965      964       -1
  Misses         16       16

Impacted Files
Coverage Δ

lib/builder/builder.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704e7cd...5ece712. Read the comment docs.

I'm ok and it's only for dev mode.
I don't know if we can add a test for this case? (Adding a mixin and removing the file afterwards? this file will be in .gitignore)

Yes, test is necessary, I will figure it out 😼


High cpu usage of Kap website

Once I open and scroll the webpage, the CPU usage of https://getkap.co raise to 18.x% to 19.x%, I think it's unnormal.

macOS: macOS Big Sur 11.2.3
Safari: Version 14.0.3 (166<IP_ADDRESS>.7)

Thanks for pointing this out! Would you mind testing this again? We've release some performance improvements today. 🙏🏼

Testing this again, it seems this is still an issue due to (I think) the CSS animation, which is strange. I'll try to do some tests for this and if there's a way to lower the usage.

It's still the same, maybe it doesn't matter, it seems this is happening in any webpage when you scrolling them, the only difference is some take up more cpu and some take up less. 19% or 20% is just more than common webpage take up, say this github page which I'm replying you.

Going to close this since we can't reliably test it and no other reports


[test] PrgEnv checks for HIP

This PR adds a test that builds the HIP ecosystem around the existing nvcc compiler, and another hello world test that checks that the build was successful.
The second test makes obvious the need for the changes to be introduced with #1868. However, the dependency of the hello world test on the build test would be better explained through fixtures (#1577).

Codecov Report

Merging #1880 (f010823) into master (247c7f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   87.90%   87.90%
=======================================
  Files          50       50
  Lines        8620     8620
=======================================
  Hits         7577     7577
  Misses       1043     1043

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247c7f0...f010823. Read the comment docs.

It seems that the test now fails on Dom.

It seems that the options for some env vars were updated during a minor release ... 😭

@jenkins-cscs retry dom


fix grammar & typos

Hey @tiangolo,
These change are to correct grammar and typos.

Many of these changes take existing correct grammar and make it worse.

Hey @acnebs,
Thanks for review the PR. Could you please inline comment on those so that it would easy to look which one are you referring to and amend or co-contribute.🙂

The title is just categorised to grammar & typos, without going through specifics for each. No Grammerly used, but definitely few things need correction. Thank you for bring it to my notice, @acnebs.


About HWCursor and BZ#1919947

The VirtioGPU driver disabled the HWCursor by default.  It's maybe caused by  BZ#1919947.
After install VirtioGPU driver,  and enable HWCursor by setting reg value HWCursor,  it would show incorrect cursor.
The root reason maybe is that m_CtrlQueue and m_CursorQueue is not a same queue.  When update cursor and QueueCursor,  the cursor pic data is processed after cursor update cmd by virtiogpu device sometimes,  so,  the cursor is still show old cursor pic data.
By adding some delay between UpdateCursor and QueueCursor, the cursor will show correctlly.
@@   @@NTSTATUS VioGpuAdapter::SetPointerShape(_In_ CONST DXGKARG_SETPOINTERSHAPE* pSetPointerShape, _In_ CONST CURRENT_MODE* pModeCur)
    if (UpdateCursor(pSetPointerShape, pModeCur))
    {
        PGPU_UPDATE_CURSOR crsr;
        PGPU_VBUFFER vbuf;
        UINT ret = 0;
        crsr = (PGPU_UPDATE_CURSOR)m_CursorQueue.AllocCursor(&vbuf);
        RtlZeroMemory(crsr, sizeof(*crsr));

+     m_VioDev.system->vdev_sleep(&m_VioDev, 1);

        crsr->hdr.type = VIRTIO_GPU_CMD_UPDATE_CURSOR;
        crsr->resource_id = m_pCursorBuf->GetId();

But,  the solution is too LOW.
Has any better solution?
Maybe it's better to moving SetPointerShape QueueCursor cmd to m_CtrlQueue,  but, it is need qemu supporting.

hi @gang929 ,
Thank you for your patch.
I do keep HWCursor disabled at the moment for the following reason - both SetPointerPosition and SetPointerShape calls are not synchronised and even more - they are initialised from different threads (actually even from different processes).
Your solution may work for some cases, but I would prefer a more robust solution, which will require some sort of serialisation of these two calls by adding some queue and a kernel thread.
The issue described in https://bugzilla.redhat.com/show_bug.cgi?id=1919947 is not related to the HW cursor, because all tests were done with the HW cursor disabled at that time.
All the best,
Vadim.

Reviewed


Function and dynamic nodes are missplacing the extmarks

local ls = require("luasnip")
local s = ls.s
local t = ls.t
local i = ls.i
local f = ls.f
local function date()
  return {os.date("%Y-%m-%d")}
end
ls.snippets = {
    all = {
        s({trig = "date", wordTrig = true}, {f(date, {}), i(0)}),
        s({trig = "date2", wordTrig = true}, {f(date, {}), t({" "}), i(0)})
    }
}

date renders to
␣2021-05-24
instead of 2021-05-24␣.
while date2 renders to
2021-05-24 ␣

Oh no, I'll take a look at it later. Did this behavior start recently/can you pinpoint which commit it was?

Okay, I think I know what's causing this, I'll get a fix up soon.

I was bisecting the repo and seems like this was the commit
d14c737bb10b180efaccf39c2c8424962786897b

By the way, can you provide a way to render the snippet without having to jump to another node, for instance changing to normal mode, to preview the changes when using a snippet with a single input?

By the way, can you provide a way to render the snippet without having to jump to another node, for instance changing to normal mode, to preview the changes when using a snippet with a single input?

Just so I get you right, when expanding date this way, it would be 2021-05-24 and you'd be in normal mode? I'm not sure what this would be useful for tbh, could you elaborate?

Sorry I was far from my computer, the idea is:
Going to normal mode (by pressing <esc>,  <c-c> or any other) makes the snippet to be rendered. One use case:
Having a snipped composed of an input node and function node that merely renders that node with a complex filter, having that feature will allow previewing the function result. Other implementations render the snippet on each keypress but I suppose rendering it when changing mode to normal could be a good tradeoff.

Ahh, that's a great idea, shouldn't be too hard to implement as well...

Whoops.
Thanks for the suggestion!

Okay, 50de33a should do it.

Unfortunately, it does not work, going to NORMAL does not render, and going to the input(0) shows:
5108: Error executing lua [string ":lua"]:1: attempt to index global 'ls' (a nil value)

Stupid mistake, I'll fix it soon. Try :lua ls = require'luasnip' as a temporary fix.


Reimplement TextProperty

Reimplemented TextProperty to use FText and be compatible with more serialization variants.

Issue 44 is not fixed by this commit completely, there are some more problems with NameProperty so this is just one step


just a question on tcgapi_tests.py

my experience with pytest is such that if you don't name a pytest test file starting with test_ then you break the pytest automation or you have to adjust the pytest configuration file -- which is extra work.  WHY did Seagate change test_tcgapi.py to tcgapi_test.py?

Hi Greg, the file name can either start with "test_" or end with "_test" for the pytest framework to be able to discover the tests. https://docs.pytest.org/en/reorganize-docs/new-docs/user/naming_conventions.html
The reason we changed the name is to increase readability by grouping the source code and the corresponding test file below it.


Core scheduler changes

Before
Reported from handler:

current speed
Was used in heuristics:
clone removing:    as vector of speeds for all number of clones, removed clone is current is less than saved
really unstable heuristic
clone adding:      as speed for +1 clone. Do not add clone if saved increased speed is less than current
instance removing: usage was wrong
instance adding:   no usage

After
Reported from handler:

current speed
Is used in heuristics:
clone removing:    as "decreased speed". If current speed right after addition is less than saved - remove
clone adding:      as "increased speed" in above - no changes

Reported from handler:

current number of zero attempts to get packets from input ring
Is used in heuristics:
clone removing:    if "summ of all zero attempts" * "time per attempt (previously calculated)" > "schedtime" - remove
instance removing: 1) get number of zero attempts from the ring with less number of them at each instance
2) convert this number to time by multiplying each instance number to corresponding time per attempt
3) get two instances with the biggest times
4) if summ of thier times is bigger than schedTime - combine them at one core
Logic for removing is the following. Each core has useful time and vacant time.
Vacant time is determined as time for zero attempts. If summ of vacant times of two cores is more than summ of their
usefull times then one core will be able to handle tasks of both cores. They can be combined.
We need to measure "time per attempT" before using it - it is quite flexible.

No performance changes

Solved issue: https://github.com/intel-go/nff-go/issues/434

As Gregory pointed average time measure functionality can be replaced by easier and more accurate time measurements of every loop iterations. Tests shows that this is true with no performance degradation. However due to some problems with calculating real time it can't be done on the fly. So I will merge this and then change to accurate time measurements.


[Bug] customlayout.text max limit show error

Version
develop
Link to Minimal Reproduction
none
Steps to Reproduce
like image bellow

Current Behavior

Expected Behavior
show rightly
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

maxLineWidth should rename

请问这个在VTable.CustomLayout.Text目前需要怎么实现截断呢

@Nyx2022


IA-2655 Fix migration for the feature flag MOBILE_ORG_UNIT_REGISTRY

Fix migration for the feature flag MOBILE_ORG_UNIT_REGISTRY.
Related JIRA tickets: IA-2655
Notes
The MOBILE_ORG_UNIT_REGISTRY feature flag has already been manually created in the prod DB.
Since the code column has a unique constraint,  we have to fix the migration to avoid a UniqueViolation error and a failed deployment:
Running migrations:
  Applying iaso.0258_orgunitchangerequest_old_closed_date_and_more... OK
  Applying iaso.0259_alter_orgunitchangerequest_created_at_and_more... OK
  Applying iaso.0260_auto_20240118_0948...Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "iaso_featureflag_code_52a8f1f9_uniq"
DETAIL:  Key (code)=(MOBILE_ORG_UNIT_REGISTRY) already exists.

@kemar I sitll got this message
DETAIL:  Key (code)=(MOBILE_ORG_UNIT_REGISTRY) already exists.

@kemar I sitll got this message DETAIL: Key (code)=(MOBILE_ORG_UNIT_REGISTRY) already exists.

@mbayangdiop95 that's strange, did you git switch fix-migration before launching the migration?


Input field: Extra leading space causes "Invalid package query" error

Description
When pasting text into the input field, there's a risk of accidentally including an extra space at the beginning. This leads to an "Invalid package query" error.
Steps to reproduce:

Copy some text.
Paste the text into the input field, ensuring there's a leading space.
Submit the form.
Observe the "Invalid package query" error.

Expected behavior:
The input field should either:

Automatically trim leading and trailing whitespace.
Provide clear feedback to the user about the invalid input, suggesting how to correct it.

Sure, trim sounds reasonable.
Feel free to PR or I can take a look at it within the next few days, schedule permitting.

setPkgQuery(/** @type {HTMLInputElement} */ (e.target).value.trim()

<input
autocorrect="off"
autocapitalize="none"
enterkeyhint="search"
class="py-2 px-4 w-full text(xl md:3xl center [#111]) bg-input(& dark:dark) drop-shadow-lg rounded-lg hocus:(outline(2 & primary))"
placeholder="Provide a package name"
value={pkgQuery}
onInput={(e) =>
setPkgQuery(/** @type {HTMLInputElement} */ (e.target).value)
}
/>

Sure, trim sounds reasonable.
Feel free to PR or I can take a look at it within the next few days, schedule permitting.

remote: Permission to rschristian/deptree.git denied to aerda.
fatal: unable to access 'https://github.com/rschristian/deptree.git/': The requested URL returned error: 403

You need to fork the repo and make the changes there, you can't push directly to projects you do not own/haven't been invited to.
Here's some instructions if you're new to GitHub:

Fork a repository
Creating a pull request from a fork

Fixed in 4631b961bb827afba702bbee7a17b171f95b7415


prevent ghinja from running when dock isn't open or allow some other method to disable

It would be nice to have ghinja only enabled some of the time. Right now the only way to do that is to totally disable/enable the entire plugin. It would be nice if it either didn't run if the dockwidget was hidden, or if there's problems with that implementation a setting to disable/enable would be nice since plugin disabling requires a restart whereas a setting wouldn't.

Will be changed in the next release :)

With release 1.1 the Ghidra decompiler starts only after you open ghinja window and click inside it. Closing :)


Disable Insert Adjustment Setting and Limit Insert to once

Fixes #196
Fixes #187
This PR fixes a couple of issues we were running into this week.

Inserting code causes the tour step line numbers to get out of sync with the step selection.
The line adjustment that is done can cause inappropriate updates to the tour files.
Code can be inserted multiple times potentially causing an issue.

To fix these things, the following updates were made.

added a new setting codetour.adjustOnInsertCodeSnippet.
command codetour.insertCodeSnippet checks setting prior to doing any adjustments.
command codetour.insertCodeSnippet checks the line of text at the insert location to see if the code block already contains that line. If so, it early outs due to the code already being inserted prior.

@lostintangent take a look at this method of detecting duplicate inserts. I think it works as expected. But I am unsure if pulling the entire contents of the doc to do a comparison is the best approach.

Looking forward to this functionality!

Would love to see this functionality integrated into the plugin


Circular stylebox border has visual artifacts when using anti aliasing

Godot version
v3.5.1.stable.official [6fed1ffa3]
System information
Windows 10, GLES3
Issue description
There are minor visual artifacts when using anti aliasing on a circular stylebox border, these appear on all 4 'sides', and I have circled the top artifact in red:

These seem to be caused by anti aliasing, as without anti aliasing, they appear to be absent:

At normal viewing distances, and control node size, this is not very noticeable, however when the anti aliasing size is turned up the effect becomes much more prominent:

(Anti Aliasing size set to the max of 10)
Please note this issue only seems to affect the stylebox border, and not its center!
Steps to reproduce

Create a stylebox flat resource
Make the stylebox circular:
Set all the corner radii to the max value (1024)
Set corner detail to 20
Apply to a panel node
Make sure the panel node is square (its rect size in x and y should be the same)
The effect is more noticeable when the panel is small (and when the anti aliasing size is turned up)

Minimal reproduction project
CircularStylebox.zip

Looks like it might be the same as this issue in Godot 4: https://github.com/godotengine/godot/issues/68514 basically the downscaling of corner radius when it's too large doesn't correctly take anti-aliasing into account.


v1.0.0 Checklist

[x] #9 – terse-webpack binary.
[x] #10 – Embed webpack@2
[x] #5 – Remove .babel as a default.
[x] 45db434ad1a886eb3e553769a4be2e21c93d68ea – Remove react alias.
[x] #3 – Include eslint-loader if .eslintrc is present.
[x] 88c52a71390c437adf403969f619e471c1ac399d – Include babel-loader if .babelrc is present.
[x] #2 – Add npm-install-webpack-plugin.
[x] #5 – Add .defaults() option
[x] #14 – Replace HMR with latest beta: gaearon/react-hot-boilerplate#61
[ ] Fully functioning example.

// .babelrc
{
  "presets": ["es2015", "stage-1"]
}

// webpack.config.babel.js
import client from "./webpack.config.client.babel.js";
import server from "./webpack.config.server.babel.js";

export default [
  client,
  server,
];

// webpack.config.defaults.babel.js
import { Config } from "@terse/webpack";

export const babel = {
  cacheDirectory: true,
  presets: ["es2015-webpack", "react", "stage-1"],
  plugins: [
    "react-html-attrs",
    "transform-class-properties",
    "transform-decorators-legacy",
  ],
};

export default new Config()
  .alias("react")
  .loader("json", ".json")
  .loader("style", ".css")
  .loader("css", ".css", {
    query: {
      localIdentName: "[name]-[local]--[hash:base64:5]",
    },
  })
  .loader("style", ".less")
  .loader("css", ".less")
  .loader("less", ".less")
  .loader("url", [".woff", ".woff2"], {
    query: {
      mimetype: "application/font-woff",
    },
  })
  .loader("url", ".ttf", {
    query: {
      mimetype: "application/octet-stream",
    },
  })
  .loader("file", ".eot")
  .loader("url", ".svg", {
    query: {
      mimetype: "image/svg+xml",
    },
  })
  .loader("url", [".jpg", ".png"], {
    query: {
      limit: 8192, // Inline base64 URLs for <= 8K images
    },
  })
  .modules("./lib") // @TODO Convert to "paths"
  .when("development", (config) => config
    .devtool("cheap-module-eval-source-map")
    .plugin("webpack.HotModuleReplacementPlugin")
    .preLoader("eslint", ".js", {
      exclude: /node_modules/,
    })
  )
;

// webpack.config.client.babel.js
import { ClientConfig } from "@terse/webpack";

import {
  babel,
  default as defaults,
} from "./webpack.config.defaults.babel";

module.exports = new ClientConfig()
  .apply(defaults)
  .entry("src/client.js", "src/widgets.js")
  .loader("babel", ".js", {
    include: "./node_modules/qs",
  })
  .loader("babel", ".js", {
    exclude: /node_modules/,
    query: {
      ...babel,
      env: {
        development: {
          plugins: [
            ["react-transform", {
              transforms: [{
                transform: "react-transform-hmr",
                imports: ["react"],
                locals: ["module"],
              }],
            }],
          ],
        },
      },
    },
  })
  .when("development", function(config) {
    return config
      .plugin("webpack.NoErrorsPlugin")
    ;
  })
  .toWebpack()
;

// webpack.config.server.babel.js
import { ServerConfig } from "@terse/webpack";

import {
  babel,
  default as defaults,
} from "./webpack.config.defaults.babel";

module.exports = new ServerConfig()
  .apply(defaults)
  .loader("babel", ".js", {
    exclude: /node_modules/,
    query: babel,
  })
  .toWebpack()
;

Wow.  Having .babelrc and babel-loader both is a PITA.
Until ericclemmons/npm-install-webpack-plugin#57 is resolved, I think the best practice should be:

.babelrc with es2015-webpack that's specific for the builds.
ES5 version for the webpack.config.js files.

And of course, now I realize that I need to have the API work entirely different.

The base API (e.g. .entry, .loader, etc.) should not have any extra features such as adding hot plugins, DefinePlugin, etc.
The base API should be created via .api(reducers) (merged into default reducers) which should really just create a fluent interface for building up the history.
The reducers themselves should export a terse and webpack reducer.
The reducers will have access to the full state tree, but should normally only operate on the part it's named after. (e.g. entry.terse(...) would modify state.entry accordingly, but possibly read from state.env.

Sorry for how much is happening here.

Moved from class to an entirely immutable, functional approach.
Went out of town for nearly two weeks.
Architecturally decisions between features & reducers knowing interdependencies (nope).
Repeating examples to ensure desired output is created.

So, here's a sneak peak:
// webpack.config.client.js
var api = require("@terse/webpack").api()
  .entry("./src/client/js")
  .loader("babel", ".js", { exclude: /node_modules/ })
;

// See the normalized, serializable state of the api
// (this is what the reducers operate on to generate the webpack config)
console.log(api.getState().toString());

// Config for webpack
module.exports = api.getConfig();

// Or, if you want to copy/paste it into your file so there's no magic
console.log(api.getConfig().toString());

Ok, so I think the best path to ensure this all works as expected is:

[ ] Test all features.
[ ] Test all reducers.
[ ] Get a the "kitchen sink" example functioning.
[ ] Port this back for use in the work project.
[ ] Fix any remaining bugs.
  Activity is wrapping up on it very soon for v1, so here's the synopsis:

The "best" way today to merge webpack configs means deep-merging objects.  This is complicated to say the least, and when it comes down to adding additional entries for, say, HMR, you have to support various object schemas.
This project came from a work project that tried to do smart object merging.  We learned the hard-way that object-merging is poor architecture and doesn't scale, especially when trying to decipher how the final config is made.
The architecture decisions of this project are:

A fluent, gulp-like API interface for defining the features of a config (e.g. .entry, .alias, .hot, .autoinstall).
The API internally builds an immutable history so that you can build defaults and then build the API on top of it (without mutating the original config).  (Think of this like replaying Flux "actions".)
The API is used primarily for building a state object (via .getState()) internally.  This is meant to describe the webpack features in a single, standardized way.  This is important because...
The actual webpack config is created via .getConfig(), where the state is passed through reducers to create entry, module, resolve, plugins, etc. based on this state object.
The core design decision also allows for having an escape hatch via .getConfig().toString(), which outputs a copy/paste-able webpack config.  This, to me, is crucial for ditching @terse/webpack when you want to get down to the "metal", or get rid of any perceived magic.

Initially, this project can be used as nearly a 1-to-1 replacement for the config (with less confusion about object formatting), as can be seen here:

https://github.com/ericclemmons/terse-webpack/tree/v1/test/fixtures/examples/kitchen-sink

But very soon it'll be easiest to say:
module.exports = require("@terse/webpack").presets.react().target("web");

Haven't had time to take a proper look under the hood, but this sounds amazing. Defaults, standardised way to change config, escape hatch :+1: :+1: :+1:
Particularly interested in checking out what you do with plugins.


Pass the config_path to the Downloader

Context
Actually executing graphs when using mTLS was not working because the graphs could not be downloaded.
What
This PR passes the config_path so mTLS is enforced for download requests.
Testing
This was tested in prod.
Contribution Checklist

[ ] If the python-sdk was changed, please run make fmt in python-sdk/.
[ ] If the server was changed, please run make fmt in server/.
[ ] Make sure all PR Checks are passing.

+1

Merged before tests completed since they completed on the previous commit before the version bump.


rustic-rs: 0.5.0 -> 0.5.1

Description of changes

https://github.com/rustic-rs/rustic/releases/tag/v0.5.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 226087 run on aarch64-darwin 1

1 package built:

rustic-rs


ProgressMonitor: support Datadog-style tags

Datadog's java-dogstatsd-client is a backwards-compatible extension to
java-statsd-client which works with normal statsd servers as well as Datadog's
dogstatsd server. This change is backwards compatible.

Here's an example of another project we use making a similar change (just to demonstrate that this library swap isn't completely unreasonable): https://github.com/apache/incubator-druid/pull/6605

Looks good.


Feat/add vite env variables and modes

Env Variables and Modes added to Vite.
.env              # loaded in all cases
.env.development  # only loaded in development mode
.env.production   # only loaded in production mode

Added the tokens to .env. They are still exposed, but can later maybe be added to .env.local, which is ignored by git.
Authentication can be now enabled via the environment variable. This is set to false in dev mode. If authentication is required, it can be set to true in .env.development.
start development mode:
npm run dev

start production  mode:
npm run build
npm run preview

For Django and PostgreSQL, it would also make a lot of sense to use .env  files. Then the question arises, if we should use separate env files or use some globally? :thinking: @lniehaus @Anafabula

The others need to look at the typescript stuff, no idea about that 🪄

@jarkenau I marked you as a reviewer because you asked how to bypass the login. So now you don't have to change anything in the code directly for that. You could validate the dev mode so that you can now work with it directly without the login.


Better organize list of adapter-specific model config in sidebar

https://github.com/dbt-labs/docs.getdbt.com/blob/94f1e771c82771ae4da663fd02c7d5ea77014353/website/sidebars.js#L394
The sidebar for adapter-specific model configs lists adapters in no discernible order.
Perhaps we could alphabetize them?

Exhibit A: Chaos


ORC-1496: Use iterator to suggest backporting branches

What changes were proposed in this pull request?
This PR aims to use iterator to suggest backporting branches.
Why are the changes needed?
Previously, only branch-1.9 was suggested. After this PR, the script will suggest branch-1.9 and branch-1.8 and so on.
How was this patch tested?
Manually.

I tested this manually when I merged #1602 .
Since this is a dev infra script for committers only, let me merge this.


Added Installation for Linux

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@VishalDas95 Could you follow the style guide as the formatting in your file is wrong.

Oh! I am so sorry I couldn't follow up! I will do the needful asap!
On Thu 1 Nov, 2018, 10:02 PM Niraj Nandish<EMAIL_ADDRESS>wrote:

@VishalDas95 https://github.com/VishalDas95 Could you follow the style
guide
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/docs/style-guide-for-guide-articles.md
as the formatting in your file is wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/19738#issuecomment-435094126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiMxJkHUH8GiPOo0FGZv46KCbrmwuJY7ks5uqyIxgaJpZM4XtPW8
.

@Asjas What does "other: decayed" label mean?

It means the ticket is stale (no activity in more than 7 days).


Link from number of mentions to cgit list of those mentions.

This creates a link in the number of mentions back to cgit for those mentions.
You can see it working in http://jcnventura.github.io/

Can you explain what is the benefit of doing this change because I'm not sure?

The first time I saw drupalcores.com, my name was already there (with 1 contrib). There was a patch I worked on for D7 that only made it to D8.
The main benefit of this change is to allow a fast link back to the list of commit mentions, so it's possible to figure out where you helped build D8.
It's not perfect, due to the way that cgit works. Clicking on the list for 'sun' will also show commit mentions for 'suntog', 'esunger', etc. But it's good enough as it is, IMHO.

Thanks!

We need to update these links to https://git.drupalcode.org/search?group_id=&project_id=59858&scope=commits&search=[username] I believe.


Can't override {silent: true} on create

I'm trying to force validation on model creation.
We're bootstrapping the data into the models when the page loads to cut down on XHR traffic and speed up the interface and while our back-end is good now, there was a time when there was no checking on input data, which means we have invalid data stored in our database.
I've got my own validation framework set up, which works AFTER the model has been validated, but when I try to pass {silent: false} when creating a new object, validation doesn't occur.
This seems because line 185 is:
this.set(attributes, {silent: true});

So no matter what my options are for create, set always receives {silent: true} which means I can't for validation on create, which creates some oddities.    (Using http://github.com/toddself/Backbone.Validator to perform validation)
Example:
var TestModel = Backbone.Model.extend({
	validators: {
		title: {
			min_length: 5,
			is_type: 'string'
		}
	},
        initialize: function(){
            this.on('error', this.log);
        },
        log: function(model, error){
            console.log(error);
        }
});

// unable to set bad titles
var t = new TestModel({title: 'this should work'});
t.get('title');
"this should work"

t.set('title', false);
['Expected false to be of type string for title']

t.get('title');
"this should work"

// can create when silent: true
var t2 = new TestModel({title: false});
t2.get('title');
false

t2.isValid();
true

t2.set('title', 'this is a good title as well');
t2.get('title')
"this is a good title as well"

t2.set('title', false);
['Expected false to be of type string for title']

t2.get('title');
"this is a good title as well"

// but can still create when silent: false
var t3 = new TestModel({title: false}, {silent: false});
t3.get('title');
false

t3.isValid();
true

t3.set('title', 'this is a good title as well');
t3.get('title')
"this is a good title as well"

t3.set('title', false);
['Expected false to be of type string for title']

t3.get('title');
"this is a good title as well"

Is this by design?  I see the change logs had forcing validation on new objects for a while, but it was reverted in 0.9.1.  Will we be able to override the hard coded {silent: true} or am I just missing something really obvious and I can force validation on create?
Any help is appreciated!

This is indeed correct -- because of the following line of code:
var book = Books.create(attrs);

... even if attrs are invalid, the variable book has to contain a valid book model reference after that line of code has run. So unless we're willing to allow exceptions here, you need to create valid models. To accomplish what you're looking for, use:
var book = new Book;
if (book.set(attrs)) { ... };

Excellent.  That's the work around I had implemented in our system but wanted to know if I was just missing something more obvious there.
Thanks!


warn Package ramda has been ignored because it contains invalid configuration.

When I run yarn ios, it gives me this prompt:
yarn run v1.22.11
$ react-native run-ios
warn Package ramda has been ignored because it contains invalid configuration. Reason: Package subpath './package.json' is not defined by "exports" in ...../node_modules/ramda/package.json

node: v14.17.6
ramda: 0.28.0
@types/ramda: 0.28.15

What should I do?

I have the same warning after 0.27.0 -> 0.28.0 update


Add docker file to create and run the examples in a docker container

To aid running XIOS demo test cases on a wider range of platforms, this PR adds a Dockerfile to build XIOS in a container which can then be used run the test examples.

hello @ricky-lv426
a couple of inputs from me:

Could the Dockerfile and the associated readme content be put into a separate directory, rather than be held at the top level of the repository?
Please may you check the contents of   CONTRIBUTING.md and add your name and affiliation to this as part of the Pull Request?

thank you
mark

thanks for pushing those change @ricky-lv426
looking at the new run_test_cases.sh script within /xios_examples/:
this looks to have quite a bit of logic that is specific to the docker container, and that is handled in other places for other run options, including managing paths, symlinks, altering source.
it also looks to be calling the python test discovery by the name of the folder it's in, so I'm guessing it's not to be run here.
could this run script be moved into the docker container folder as well?
failing that, if it needs to be held at exactly this location, could it be renamed and commented to highlight it's only targeting the container environment?
I think it's current name and location suggest that it could be used in all run cases, from it's current location, and i don't think that works for most of the platforms we've tested on so far
thank you, mark


chore(format): run prettier format

Summary
😄 I can't stand it.

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

😄


Nothing happens when deleting a folder via keyboard under one ADLS Gen1 account

Storage Explorer Version: 1.10.0
Build: 20190916.5
Platform/OS: Windows 10/ Centos Linux release_7.6.1810(core)/ macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Open one ADLS Gen1 account -> Create a new folder.
Try delete the created folder via keyboard.
Check the result.

Expect Experience:
The delete dialog pops up.
Actual Experience:
Nothing happens.
More Info:
This issue also reproduces when using 'Ctrl + V' & 'Ctrl + C'.

Let me investigate to make sure it's not a localization bug. If not, I'll transfer to @southpolesteve.

ADLS Gen1 used a lot of the blob's code, but I don't think it has all the latest fixes we made in blob's accessibility.  Steve doesn't own ADLS Gen1 so please don't assign the bug to him.  The ADLS team strongly recommends users upgrade to ADLS Gen2 as Gen1 is in the process of being deprecated.  ADLS Gen1 eventually will be removed from Storage Explorer at some point.

@v-limu Can you verify that delete still works using the mouse?

Hi @craxal It works well when using the mouse to delete.

@Jing I don't believe ADLS Gen 1 affects our accessibility grade, does it? If not, and since users can still use the mouse, I propose we don't fix.

hmm...i actually vote to fix this one. Not necessarily for accessibility, more for productivity.

Fix merged into master.


sync: release 0.17.x

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Cherry picks #1884 from master.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 7.2.1+driver

Close and reopen to trigger CI.
/close

@FedeDP: Closed this PR.

In response to this:

Close and reopen to trigger CI.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/reopen

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

driver/OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Fixed scroll to top icon for small devices

Fixes Issue🛠

Closes #856
Description👨💻

I have changed the icon to bootsrap icon in all the four pages, as bootstrap icons are visible in both mobile as well as desktop whereas some fontawesome icons are not visible in mobile.
Type of change📄

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How this has been tested✅
I have run it locally.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @sharmi4590


Event 'discovery_document_loaded' is triggered twice, possibly causing nonce validation to fail

To reproduce
The issue can be verified very simply by editing the sample app in this repo, adding a couple of lines at the beginning of AppComponent.constructor() to log the event
   this.oauthService.events
      .pipe(filter((e) => e.type === 'discovery_document_loaded'))
      .subscribe((e) => console.log( e.type, e['info'] ));

and adding a call to oauthService.initCodeFlow() to AppComponent.configureCodeFlow():
    this.oauthService.configure(authCodeFlowConfig);
    this.oauthService.initCodeFlow();   // ADDED
    this.oauthService.loadDiscoveryDocumentAndTryLogin().then((_) => { ... }

The net effect is, the user cannot login and is redirected to the login page over and over.
Analysis
In oauth-service.ts the discovery_document_loaded event gets published twice, once by loadJwks(), and then again by its caller, loadDiscoveryDocument().
This is probably inefficient but harmless, unless you call initCodeFlow() before invoking loadDiscoveryDocumentAndTryLogin(), as suggested in the "Logging in" section of the README.md file.
The code flow init method (see lines 2706-2708 in oauth-service.ts) subscribes to the discovery_document_loaded event, invoking initCodeFlowInternal() when upon reception.
The nonce is created in the course of the execution of this last method.
If the event is thrown twice:

(first event received) A nonce is created
The login URL is created, including that nonce
The browser is redirected to the login page
(second event received) A new nonce overwrites the previous one in the session storage
The browser is redirected to the app; the URL includes the previous nonce
Nonce validation fails: nonce in the session storage does not match what came back from the Identity Provider

I suggest that the discovery_document_loaded event gets published only once.

See also #1125 and #810, which triggered the creation of this ticket.

Removed from problem description:

, or initCodeFlow() is removed: interestingly, calling that method is mentioned in the documentation, but both example applications avoid calling it.

Method initCodeFlow() is indeed called by the sample app, not directly, but by way of initLoginFlow().
While the documentation seems to imply that initCodeFlow() should be called before loadDiscoveryDocumentAndTryLogin(), the samples invert that order, avoiding nonce corruption.

With "the documentation" you mean above-linked README, right? I think it might technically suggest that it's an "either / or" choice, but the way it says so might not be immediately obvious especially to non-native speakers:

After this, you can initialize the code flow using:
this.oauthService.initCodeFlow();

There is also a convenience method initLoginFlow which initializes either the code flow or the implicit flow depending on your configuration.
this.oauthService.initLoginFlow();

The "there is also" part implies that it's an alternative.
It might be good to clarify that point?

It's pretty clear (to me, at least) that initLoginFlow() is an alternative to initCodeFlow().
But right after that, the README continues:

Also -- as shown in the readme -- you have to execute the following code...

...which (to me, at least) implies: "after you have initialized the code flow, you'll need to configure the OAuth2 client code and load the discovery document".  That's what got me.
Minor note: it may be worth it to remove that "-- as shown in the readme --" fragment, since we are in the README file.
Minor suggestion: it may be worth it to combine configuration and initialization in a single method, something like
public configureAndInitLoginFlow( config: AuthConfig ) { ... }

will be fixed in next version.


Document responsibilites & processes for TAG + WG leadership

Document how to:

create a project meeting

every occurence where our meetings are documented so we know where to change when we switch times
To add a new meeting for a project (not a one-off event), make sure to use the Project Meeting type.
Additionally, remember to add RSVP options on the RSVPs page. Recomended option: Title: RSVP (Optional) Quantity: 1000

get access to & post on linkedin
get access to & post on twitter
upload videos to youtube

Please add more missing explanations you come across

When creating meetings
To add a new meeting for a project (not a one-off event), make sure to use the Project Meeting type.
Additionally, remember to add RSVP options on the RSVPs page.
Recomended option: Title: RSVP (Optional) Quantity: 1000

Open question: Is it possible to disable the announcement emails temporarily? If we need to cancel multiple events in order to replace them (example: the WG Platforms meetings that were scheduled as one-off events), it could create confusion.

Starting a doc here https://docs.google.com/document/d/1AmSijK5gYnpVo0lIg_tFMTOSnleNmhE6ektDN05nVi8/edit?usp=sharing


Add OME files docs to Support page

See https://trello.com/c/Wc4plStF/41-content-nitpicks-to-fix
staged at https://snoopycrimecop.github.io/www.openmicroscopy.org/support/

Looks good. Link is correct etc. Good to merge.


joystick events not detected

Hi,
I have now an issue with my gamepads.
I have 3 of them and they all pass the joystick and controller test of pygame's tests.
I tried the examples.evenlist, all 3 are ok (axis and buttons detected).
When I start joyptz, for one of them it gives me an error :
[...]
File "C:\python\joy-ptz-cam-main\env\lib\site-packages\joyptz-0.1-py3.10.egg\joyptz\joystick.py", line 156, in _read_joystick_axes
    zoom = -(axes_vals[2] + 1) / 2.0 + (axes_vals[5] + 1) / 2.0
IndexError: list index out of range

This one is an old model and has a "on-off" trigger, it could explain this problem.
For the other two, a joy PTZ window opens (screen capture joined) but all axis and buttons values stays at 0 when the gamepad is used. No other window.
Keyboard keys actions are detected though.
I have no error in the terminal.

Any idea of what colud be my problem?

Hi,
here are some updates:
I've been testing and looking for similar issues and found something :
If I had the line pygame.event.pump() in _read_joystick_axes between joystick.init() and the unindent at the and of for i in range(axes): then the get_axis instruction works but in a very instable way. As if the connection was not good (it works and stopped permanently when i maintain the stick in a position)
With one of my gamepads it works better if I place the pump instruction just before axis = joystick.get_axis(i) but it's not as fluid as if I test pygame.examples.joystick which react in real time.
The camera responds to the mooves when the coordinates changes in the display window.
Any idea of the reason of this erratic behavior?
Thanks

Hi there. Oh sorry about that, yeah that code is slightly too hard-coded for my gamepad rather than any other joysticks.
The zoom line that's erroring out there is grabbing the 3rd and 6th values in a list (indexing starts at 0) and the list is not 6 long in your case. I can try to update the code to be more forgiving in this case. In my case, this is the triggers on my gamepad sending zoom in and out commands, which you may or may not even want.
You can try playing around too if you want. I just pushed a code change that may make it more forgiving that basically just skips over the zoom control if the axes values length isn't long enough. Does it help?

Hi,
no preblem, I managed the zoom question testing if the joystick have 4 or 6 axes, and if there is 4, the zoom is managed by axes 2-3.
Adding the pump line to make it work (as descripted above), the problem now is that events are not listened permanently (or at least does not seems to be listened permanently). Pushing a joystick or a button is sometime detected sometimes not.
Do you want me to send you a video of the display so you can see the behavior of the script?


Cannot debug in VS 2019 when TimerTrigger invokes due to IsPastDue UnscheduledInvocationReason

I ran the debugger by pressing Debug in VS and also alternatively followed the guidance at here to debug locally.
On both occasions I receive the same timeout error when a TimerTrigger is invoked due to a CRON expression (see TimerTrigger C# declaration in image below) which means it runs to catch up on a missed invocation.

If I just run the functions using func host start command then the trigger runs successfully.
See image below for error messages when running Functions from CLI.

My version of VS 2019 is as follows.

I have since deployed application to Azure (Windows, Consumption plan) and it even fails there. Any timer trigger times out after 5 minutes.

If I create a new Function project using latest version of VS 2019 at time of writing (16.10.1) with a TimerTrigger using the VS template, with a CRON expression of 0 */10 * * * *, I get the same issue so I feel that rules out the issue being within my codebase.

Thanks @DavidGodbold! Tracking these debugging timeout issues in #434.


opposite margin is not respected

If set, for example, element's styles
position: sticky;
top: 0;
margin-bottom: 100px;

it should not be able to overlap this 100px bottom gap being in fixed position. You can compare polyfill with native behavior in FF, Safari: http://codepen.io/ThiRaBrTNK/pen/gPjVyy

The issue is fixed and it'll be available in the next release. Thank you for the feedback.

Man, you are doing fantastic job! Thank you so much!


Add item hash as data tag on image element

Currently, the user selects image items and an array of indexes is stored. The image hash should instead live on the image element as a data attribute.

Not necessary as hashes are already present in onClick function for items.


Change to 'de' language

Hello,
as explained in the last version changelog,  I tried to set Options.Language = 'de'
However, it doesn't work, I get theses error in the logs :
07/06/2018 18:31:37: Info: cacb: BrowserConsole: Uncaught TypeError: Cannot read property 'OnLogEvent' of undefined (Source: file:///C:/Advanced%20Combat%20Tracker/OverlayPlugin/cactbot/ui/raidboss/timeline.js, Line: 700)
07/06/2018 18:31:37: Info: cacb: BrowserConsole: Uncaught TypeError: Cannot read property 'OnLog' of undefined (Source: file:///C:/Advanced%20Combat%20Tracker/OverlayPlugin/cactbot/ui/raidboss/popup-text.js, Line: 470)
07/06/2018 18:31:38: Info: cacb: BrowserConsole: Uncaught TypeError: Cannot read property 'OnPlayerChange' of undefined (Source: file:///C:/Advanced%20Combat%20Tracker/OverlayPlugin/cactbot/ui/raidboss/popup-text.js, Line: 461)

Did I missed something ?
Regards,
moon.

I've deleted the raidboss.js file and used notepad++ to recreate the file. It works fine now.
Conclusion : don't use standard notepad :D

Glad you got it sorted!


Update custom_sdxl_ksampler.py

Support ComfyUI updates from https://github.com/comfyanonymous/ComfyUI/commit/036f88c62166a750ecfc88175d2f6836c5707e3b

Thanks for you PR. Unfortunately I only noticed it after I made those exact changes for the v4.3.1 update, otherwise I would've merged it.

Thanks for you PR. Unfortunately I only noticed it after I made those exact changes for the v4.3.1 update, otherwise I would've merged it.

No worries, I was just inconvenienced after updating comfy, and figured I'd fork and pr the fix. Thanks!


modified a couple of misspellings

Hi! I corrected the http (it was correcting wrongly ":http:" (note the : in front)
and deleted 2 lines of "alot" because it's essencially the same and those 2 follow up lines were unnecessary

Hi! I corrected the http (it was correcting wrongly ":http:" (note the : in front)
and deleted 2 lines of "alot" because it's essencially the same and those 2 follow up lines were unnecessary

Thanks ;)
Merged


F ansible iosxe labs update

Updates for the intro-ansible lab

@vvaliapa It's possible I've chosen the wrong config when doing the merge, so here's the old one just in case:
ansible_user: developer
ansible_ssh_pass: C1sco12345
ansible_port: 8181
netconf_port: 830


vesta: Add version 3.5.7

VESTA is a 3D visualization program for structural models, volumetric data such as electron/nuclear densities, and crystal morphologies created and maintained by jp-minerals.org
VESTA is a successor to two 3D visualization programs, VICS and VEND, in the VENUS (Visualization of Electron/NUclear and Structures) software package.

VESTA runs on Windows, Mac OS X, and Linux. It is contributed free of charge for non-commercial users.
More about it can be read here

[X] I have read the Contributing Guide.

/verify

I am not getting what is wrong. Can someone help me please?

Thanks. :smile:


IntDiv return empty args

The IntDiv extension breaks in some cases dse as IntDiv().args = []

can you fix it? should be fairly trivial

I am looking into it yes, but not fairly trivial no,


improve readme and docs

You should mention explicitly that you implement the diagonal transition algorithm (/WFA). This has expected runtime O(d^2).
Only saying the runtime is O(nd) makes it look like you implement band doubling instead.

Also explain the name editdistancek maybe while you're at it. I don't seem to get it.


After installed azure-cli, some users' pip is down

Description
Outline the issue here:
After installed azure-cli, some users' pip is down.
In the screenshot, you may see we are trying to install pip, however, you can see the error is thrown when we call pip --version, and pip has been already broken.
I'm not sure if it is related, but I find a similar issue in one of Google's projects https://github.com/GoogleCloudPlatform/google-cloud-python/issues/1570

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here:
pip install -r https://github.com/Azure/azure-cli/blob/master/packaged_releases/pip_requirements/0.2.5_python27.txt
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:
azure-cli 2.0.3
As azure-cli is not installed correct, and pip is down, we cannot know modules' version on users' machine
OS Version: What OS and version are you using?
Answer here:
Microsoft Windows [Version 10.0.15063]
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here:
cmd.exe

@Sneezry this should be fixed in more recent versions of the CLI.
This error occurred during a transition in how we created the Python packages.