Do not erase Cargo diagnostics from the closed documents

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6850
The LSP specification at https://microsoft.github.io/language-server-protocol/specifications/specification-3-14/#textDocument_publishDiagnostics states that

Diagnostics notification are sent from the server to the client to signal results of validation runs.
Diagnostics are “owned” by the server so it is the server’s responsibility to clear them if necessary. The following rule is used for VS Code servers that generate diagnostics:

if a language is single file only (for example HTML) then diagnostics are cleared by the server when the file is closed.
if a language has a project system (for example C#) diagnostics are not cleared when a file closes. When a project is opened all diagnostics for all files are recomputed (or read from a cache).

When a file changes it is the server’s responsibility to re-compute diagnostics and push them to the client. If the computed set is empty it has to push the empty array to clear former diagnostics. Newly pushed diagnostics always replace previously pushed diagnostics. There is no merging that happens on the client side.

So for projects we should not clear any diagnostics from cargo/json projects.
Our "standalone file" mode is in a way a project too, with sysroot attached and a potential support for dynamic standalone files.

It just dawned on me that maybe there are two different issues here?
There's cargo check from "checkOnSave", and there's also cargo check from "Rust Analyzer: Run". Can it be that we want to clear diags in one case, but not the other?

let's land this: I haven't thoroughly investigated this, but, looking at the code as it exists today, this should be fine: we send "checkOnSave" diagnostics for every file, and for native diagnostics, the correct behavior is recompute them when a new file is opened.
bors r+

I also don't understand why our publish diagnostics does anything to cargo check diagnostics, that seems to be upstream bug?

here's the explanation:
https://github.com/rust-analyzer/rust-analyzer/pull/5500#discussion_r459223769
we do in fact try to merge rust-analyzer and problem matchers diagnostics.

On the client side that's true but publish diagnostics is supposed to return the current diagnostic list for the file. It's up to the server to keep track.

Sorry to be late to the discussion, but looks like almost all questions had been resolved?

There's cargo check from "checkOnSave", and there's also cargo check from "Rust Analyzer: Run". Can it be that we want to clear diags in one case, but not the other?

Sounds interesting.
In my case, I don't use "checkOnSave" feature, only running the checks manually and this erasure is very much notable.

Yeah, I've also sent #9701 to handle the "files are opened or closed" in a more principled way.


CDD-1977: Implement WeatherAlertButton type in cms

Description
This PR includes: The implementation of a WeatherAlertsButton type for the cms
Fixes #CDD-1977

Type of change
Please select the options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests at the right levels to prove my change is effective
[ ] I have added screenshots or screen grabs where appropriate
[x] I have added docstrings in the correct style (google)


Inconsistent recursive put behavior when running an identical command twice successively

Thank you for your work on this library !
The problem
I am using put with recursive=True to copy the content of a local folder to a remote path. If I run it twice successively, the first time, the behavior is as expected, i.e, all the files were copied to the expected path. The second time however, I would expect it to either overwrite the already existing objects, or throw an error because it doesn't overwrite by default. Instead, what I am getting is a suprising behavior where a nested duplicated path is added at the remote path.
The equivalent local shell command I would run would be cp -R my-folder my-other-folder.
Expected behavior
The second time put runs, I would expect either an overwrite or an error
Actual behavior
A duplicated nested path is created with new copies of the files.
Minimum reproducible example
In this example, we want to recursively copy 'my-test-path/my-test-dir/' to 's3://my-test-bucket/my-test-prefix/my-test-dir/. The first time this runs, if one checks on the CLI with aws s3 ls s3://my-test-bucket/my-test-prefix/my-test-dir/, one finds as expected the copied files. If this runs a second time however, one then can run aws ls again and find the following nested duplicated path with all the files again
's3://my-test-bucket/my-test-prefix/my-test-dir/my-test-dir/'
Code (replace paths with your test local paths / test bucket)
import s3fs

local_path_to_dir = 'my-test-path'
dir_name = 'my-test-dir'
bucket = 'my-test-bucket'
prefix = 'my-test-prefix'

s3_fs = s3fs.S3FileSystem()

s3_fs.put(f'{local_path_to_dir}/{dir_name}', f's3://{bucket}/{prefix}/{dir_name}', recursive=True)

Is this an expected behavior ?

This is expected bevahiour and what you would get if using the command line for local files and directories. Whether the target exists or not matters.
If you explicitly want to synchronise two directory trees (possibly including deleting files that have disappeared in the source), you may try fsspec.generic.rsync.


Support for OAuth

A number of folks have been requesting OAuth support through the forum.  The HTTP node currently has support for basic auth but there is no solution for OAuth without developing a node (ie - the Twitter node).  I hope this is the right place to be opening this request.

To be clear, do you mean the http request node (using oauth to make requests of other services) or to be able to secure

Oops - that'll teach me to reply to issues with baby on my lap - she'll hit any button she sees.
Was going to say.... Or to secure HTTP in nodes with oauth?
There are reasons why we don't yet support oauth in either of those cases, something I'm sure I've explained on the mailing list in response to those couple of requests.

Thanks for the reply.  Sounds like I should join the mailing list.  This request is around using the HTTP request node to make requests to OAuth services (rather than securing HTTP in nodes using OAuth).
For example, I wanted to be able to issue Twitter API requests from within NodeRED, but ended up doing this instead (see below) given it would be difficult to do things like generate an OAuth signature/nonce/etc from within NodeRED.
http://flows.nodered.org/flow/162cd122fcdeb2c0f1c6

@knolleary is it possible to reconsider this now that the HTTP request node uses the popular request library under-the-covers in #1736?
the request library supports OAuth out-of-the-box
https://github.com/request/request#oauth-signing
If we want to keep it minimal we don't have to expose it via the HTTP request dialog, but only configuring it using the incoming msg. If msg includes a oauth property, simply copy it to the opts that we pass to request.
Would be happy to submit a PR.

@cowchimp yes - the move to the request module was a prerequisite for this and a couple other feature requests on the node.
I think your proposal of passing msg.oauth straight through is sensible at first glance, but I suspect we need to do something slightly different. There is a risk it will break an existing flow that passes in that property for unrelated reasons.
Another request we've had is to be able to passing username/password credentials for Basic auth - so they don't have to be hardcoded into the node. Currently users can only do that by hand crafting the Authentication http header and passing that in.
Given user/password and oath all fall into the same  category, I wonder if there should be a single message property that can be used to pass either/or/both of those things in - with a name that minimises the chance of breaking existing flows (although that risk always exists when nodes start responding to new msg properties).
How about:
msg.requestAuth = {
   username: 'fred',
   password: 'sekret',
   oauth: { ... }
}


Benchmark integration with the CI system

This PR adds jobs to the CI system which will run Ginkgo's benchmarks on a regular schedule (can be set up here, currently once a day, at 2am) and publish the results to ginkgo-project/ginkgo-data. This data can then be viewed in the Benchmark explorer.

Don't merge it yet, still want to do a commit.

Tried to do something about the code to make it easier to understand, take a look again.
I'm still not sure what to do about the CI scripts, as I feel that them being hard to understand is just a symptom of a bigger problem: there's no good way to write reusable pieces of code (functions, macros, etc.) in the YAML file. I'll open an issue so we have a place to discuss it.


chore: add tf version variable

@symeonmanis you still need to add the with to the Setup Terraform job to include the version

@symeonmanis you still need to add the with to the Setup Terraform job to include the version

@daverichards-ellogroup added now


How to skip validation for the field not exists in form using Formik + Yup?

I want to add validation if a particular field exists in the form, otherwise, there should not be any validation or skip validation for that field.
How can I achieve this?

use
object({}).test()

By using Yup, you can use when.
For example, add a "required" validation on foo if bar is present :
foo: mixed().when("bar", {
is: value => !!value,
then: mixed().required()
}),

so what i  just did
<Formik
onSubmit={actualSubmitFunction}
. .
<button  onClick={vales.valueExists? submitForm(): actualSubmitFunction(values)}>submit


Floating point arguments bug

Issue
There is a bug related to @Method parameters, when user declares a method with floating type doesn't matching godot's real_t size (double by default), this conversion produces incorrect result.
https://github.com/godot-dlang/godot-dlang/blob/40d849d8fc77f9bcbf0b6276b840c3a44fabb880/src/godot/api/wrap.d#L320-L322
Example:
@Method _process(float delta) {
 // delta here contains garbage
}

@Method update(double delta) {
 // here delta is correct
}

How to fix
Suggested fix is to cast to godot real_t pointer first and cast to target type, also double ptr was probably due to mistake or an older godot4 alpha quirks.
return cast(A[ai]) *cast(real_t*) &va[ai];

From gd4 release notes in c# section:

One of the most notable changes is the use of 64-bit types as scalar values. This means many APIs that used int or float now use long and double with the most noticeable being the _Process method. A Variant type is also now implemented in every API that takes variants where System.Object was used in the past. This brings some improvements such as avoiding boxing the values.

So it's pretty much easy to assume they want everyone to use it
Question is to cast or not to cast
If to cast then we arent really loosing anything, but there must be hardcoded assert before that check if delta is floating point (which if i remember correctly should be in std.traits module)

It is not about to cast or not to cast, it is low level C ABI interface and how they design parameter passing in engine code/GDExtension interface.
In our case it is not a variant despite being variant[]* being used, it is pointer to caller arguments location.
Even though in this case we might just abuse private implementation details that we shouldn't rely on - it could be that such construct on our side works only because Godot Variant implemented as union and we are lucky to have pointer landed upon it, otherwise we would have garbage.
As this was done in early alpha days I can't even tell the reasoning behind this design decision, back then there was no info at all, no docs, no examples, nowhere to look for a reference.

Closing issue as fixed.


Unable to compute your documentation diff

We have been using the GitHub action for a few weeks with no issues. How we are getting the following error consistently:
We were unable to compute your documentation diff. Sorry about that. Please try again later

Any way to get more information from this error?

Hi @calexander3,
Sorry for the inconvenience. We have had some performance issues at Bump yesterday and you must have been affected by this.
Would you mind sending us both previous and next specification versions you were trying to diff please?
You can send both files to<EMAIL_ADDRESS>We will do our best to investigate and restore the feature as you have been using for the past few weeks!
Many thanks for your help and understanding 🙇♂
Paul - from the Bump team

Thanks @paulRbr! It looks like it starting working about 4 hours ago. The odd thing is that the cli continued to work even when the action was not.

It looks like it starting working about 4 hours ago.

Hi @calexander3,
We have fixed an important performance bug last friday (16th september) so I'm happy to hear it helped to solve your issue. Thanks for your patience!


Wrote first draft of my quickstart guide.

Check a look on the first draft of this quickstart guide for using Prisma ORM

Looks great! Excellent job @vyknight all the issues and concerns I had are resolved now


stroke for images/svg particles?

Is there anyway to give stroke to images? like stroke is working in circular particles not custom images path.
also i want to know if i can change stroke/color/shadow values on the fly without refreshing the whole particle canvas?
thanks
Which version are you using?
1.22.1
Which library are you using?

[ ] jQuery (jquery-particles)

Hi @thewayur,
Probably you are trying to achieve something like this: https://github.com/matteobruni/tsparticles/blob/main/demo/main/public/presets/svgReplace.json
    "shape": {
      "image": {
          "src": "/images/canine.svg",
          "width": 32,
          "height": 32,
          "replaceColor": true
        },
        "type": "image"
    }

This is what you need, the replaceColor for the image shape options, this will replace every color with the particle color value. Actually is not possible to replace only a subset of colors.

@matteobruni  much much thanks for the reference. now u have provided more examples for experiments :)
ok fine, i m getting that library still have limitations, its fine. I LOVE THIS LIBRARY (i m very new to canvas too)
now 2 big ques:

how to  add stroke to them?
how to change color on fly(without refreshing whole canvas). please i m new to canvas!

For stroking the particles you can see this sample: https://codepen.io/matteobruni/pen/XWbBxEm
Changing the color on the fly can be done with the animation like here: https://codepen.io/matteobruni/pen/NWRPKQW
But... If you want to replace the images color it's not supported since the image needs to be loaded for every color and I think the stroke will be a square around the image.
If you need a more complex shape you can draw it yourself, something like this: https://github.com/matteobruni/tsparticles/tree/main/shapes/heart or this https://codepen.io/matteobruni/pen/vYOMmGr but it require some canvas drawing skills

@matteobruni omg, beautiful examples! you are such a lovely person. thanks a lot for such an adorable library.
this is my most fav lib, you are my hero... love from India!!!!!


NAN loss with your network on your data

Hi, I'm trying to reproduce your results on pixel-level adaptation. So, I'm trying to train the FCN-8s model on the dataset you shared (cyclegta5), but after around 100 iterations, the loss goes nan. This is happening for a 768x768 crop and batch size 2. What can I do to reproduce your results using FCN-8s? Thanks in advance

Solved setting the right value of the momentum (0.9). For anyone else having my same problem, please note that in the train_fcn.sh file the parameters should be modified following the paper.


Are we handling occtypes in error state during compute?

We made a decision a while back that we would allow occtypes to save with certain errors. In the pic below you can see these errors. We allow non monotonic curves and we allow rule violations in the uncertainty values. Are we handling these correctly during the compute? Probably we need to message the user and not even try the compute?

validation has been added to handle errors among the occ types during the compute.


Unable to complete cluster provisioning on vSphere

What happened:
I am unable to complete cluster provisioning process on vSphere, the build process hangs at control plane node provisioning
Instead of 3 CP nodes, I only get 1 created, and kubectl get machines -A shows no resource.
I am using bottlerocket-vmware-k8s-1.26-x86_64-1.14.0-9cd59298
The insecure setting is set to "true" and we using the vCenter thumbprint because my co-worker was able to successfully build the cluster.
What you expected to happen:
Build success instead of time out
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment: vCenter 8.2

EKS Anywhere Release: v0.18.1
EKS Distro Release:

The error I am getting is
"cmd": "/usr/bin/docker exec -i eksa_1699672917204074551 kubectl get machines.cluster.x-k8s.io -o json --kubeconfig eks-sandbox-cluster/generated/eks-sandbox-cluster.kind.kubeconfig --selector=cluster.x-k8s.io/cluster-name=eks-sandbox-cluster --namespace eksa-system"}
"2023-11-10T22:30:12.710-0500	V5	Error happened during retry	{"error": "nodes are not ready yet", "retries": 28}
2023-11-10T22:30:12.710-0500	V5	Sleeping before next retry	{"time": "6s"}"

Turns out the CP node IP address (or the DHCP scope of the K8s cluster) needs to be whitelisted on the vCenter, because CP node needs to make API calls to vCenter for worker nodes scaling up and down.


Improve Error Message on deleting members of groups

Hi UAA team,
when we get errors on deletion of member of groups, we get a very generic exception:
landscape_tools.uaa.UAAException: UAA replied error '[no error provided]' (500) on '/Groups//members/': [no description provided]
While the error itself was mostlikely caused by DB connection issues, the error message is extreme generic and could be enhanced in my opinion.
Best regards,
Christian

@ChristianWilhelmSAP
Do you have a callstack or more insights?

@ChristianWilhelmSAP I could not found the "no error provided" and from text it must be a client tool , so a tool in-between you and UAA.
However I created the PR to map generic DB issues into HTTP 422
Here is an example branch with a change
https://github.com/cloudfoundry/uaa/tree/scimMoreGenericExceptionHandling-example
Using
uaac member add internal.superuser marissa
uaac member delete internal.superuser marissa
show the new error using branch scimMoreGenericExceptionHandling-example


Error while launching run and debug: Build process failed - wso2 micro integrator with visual studio

Description
Hi Team,
I have installed WSO2 MI and Visual studio by follows WSO2 official site https://mi.docs.wso2.com/en/latest/install-and-setup/install/installing-mi/
I am trying the simple "Helloworld" service as instructed in WSO2 Quick reference https://mi.docs.wso2.com/en/latest/get-started/quick-start-guide/
After designing the project, I am trying "Build and Run" to deploy the created service to the WSO2 MI Server.
However it always throws an ERROR saying "Error while launching run and debug: Build process failed"
[MI Debug] [ERROR] Error executing BuildTask: Build process failed
I updated visual studio by navigating to Help --> check for update and restart also done as per this reported issue https://github.com/wso2/mi-vscode/issues/379
However this issue is still persists. not able to resolve this. Can I get any guidance to resolve the same?
Steps to Reproduce
Install WSO2 MI  by follows https://mi.docs.wso2.com/en/latest/install-and-setup/install/installing-mi/
Install Visual studio and add MI extension by follows https://marketplace.visualstudio.com/items?itemName=WSO2.micro-integrator
Open Visual studio and created project as per this link https://mi.docs.wso2.com/en/latest/get-started/quick-start-guide/
after designing, click "Build and Run"
Version
WSO2 MI 4.3.0 , Visual studio code: 1.95.3
Environment Details (with versions)
OS: Windows 11
WSO2 MI 4.3.0
Visual studio code: 1.95.3

Closing this issue as it is a duplicate of https://github.com/wso2/mi-vscode/issues/534


Fix CI build errors

We noticed some CI build errors in https://github.com/dora-rs/dora/pull/489.

The python being called is not the one from the virtual env where dora-rs is installed. By default, it is using the one from the dora-daemon which has been spawned before activating the virtual env. I would recommend either:
dora destroy
dora up

Or changing the order in which the installation is done.

Thanks a lot for the explanation!
I split up the CLI job into a Rust job and a Python job and used separate dora up commands.

I think in the future we should probably do something like
dora run

Good idea!


Add documentation for collection-level metadata

It's possible to add arbitrary key/value metadata to collections, but this isn't mentioned in the Usage Guide.

I think this will be handled best by the python and JS autogenerated API docs which will cover this. closing this b/c those will land soon. (this week)


UI support cloud storage

Motivation and context

Dependent on PR
Dependent on PR
Related issue: #863
How has this been tested?

TODOs

[x] fix search
[x] cards with equal size
[x] update query (when creating storage and go to the page of all storages there is no update, need update page manually)
[x] add support for an access key, secret key pair for AWS S3 (instead of/or access key, secret key, session token set)
[x] clear task form after the task was created
[x] cloud storage creating a page
[x] cloud storage updating page
[x] cloud storage listing page
[x] new tab on creating task page
[x] manually tested creating && updating cloud storages (S3 and credentials, S3 and anonymous access, Azure Blob container and credentials) && creating tasks with images from a cloud storage
[x] correctly updating credentials
[x] fix e2e test
[x] modernize the structure of the data tree
[x] fix all comments after team demonstration

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

[ ] Cansel -> Cancel
[ ] Icon for AWS should be adjusted by the middle of the provider field
[ ] When I click credentials and don't update them, probably it is intuitive to show "dummy" values (as in the beginning). Now they become empty always.
[ ] Need to add some hint (or link to documentation) for "Manifests" field. Nobody knowns that it is.

I tried to add the same storage with a different display name and got the error below. Why do you think we should prohibit that?

[ ] When a cloud storage is created, we need to check that the provided manifest files exist.

[ ] It will be great to distiguish between two typical cases: cannot find a file on the cloud storage and cannot access the storage with provided credentials. I deactivated my keys for the first cloud storage and got the following error when I try to access the storage:

@Marishka17 , but overall the functionality works fine. Great job!

@Marishka17 , when are you going to support export task feature?

@Marishka17 ,
Select all files feature is missing and it can be pain if there are a lot of images in the root directory.

@Marishka17 , in many cases it is a good idea to choose first manifest file by default. I believe in many cases users will have only one. Now users have to choose a manifest explicitly.

@Marishka17 , is it possible to adjust the icon below?

All mentioned problems are not critical. I will create a separate issue and describe them. Thus I'm fine with the PR.
@ActiveChooN , could you please review it ASAP?

@Marishka17 , when are you going to support export task feature?

I think this should be implemented in a separate PR

Can manifest files be detected automatically? I guess just searching in the root directory and its subdirectories can cover most of the cases.

Surely this can be accomplished by filtering using the corresponding SDK, but manually specifying the required manifests was discussed in the last demo of the solution.

Can a custom S3 server be selected, for example as it did in Cyberduck for example?

I'm not really sure about this, I'll check

@nmanovic , @ActiveChooN

[x] default selected manifest on the task creating page
[x] select all files on a task creating page

@Marishka17 , probably an item to investigate after the PR is merged. A list of storages (I have only one) is loading longer than list of tasks (~10 tasks).

@Marishka17 , probably an item to investigate after the PR is merged. A list of storages (I have only one) is loading longer than list of tasks (~10 tasks).

I think it might be related to getting storage status. I added making "dynamic" loading to do for the future, but for this, I would like to consult with @bsekachev  (by the way, I implemented this at the beginning, but it was not entirely correct), so I corrected this moment and did it by analogy with loading previews.

@aschernov  Hi, could I ask you to add documentation for this feature?

@Marishka17 , sure. We'll update the documentation

I found that the cloud storage element on the cloud storage page has an image that has the wrong cropping:

if the page width <1366 px:

The image is displayed after creating a task using this cloud storage. Similar items on the projects page are displayed correctly
I used "azur blob container" I managed to create a task using images, but I can't create a task using video. In process creating a task appears:
"Could not fetch cloud storage data"
In the console:

I found that the cloud storage element on the cloud storage page has an image that has the wrong cropping:

Thanks. Could you please create a issue?

I used "azur blob container" I managed to create a task using images, but I can't create a task using video.

For this functionality can be used only dataset with images


Transformation not working when using :hover ?

Hello there,
I got an issue when using ":hover" css transformation animations :
the animations that don't transform the text work (for example "flash" is working) but not the ones using transformations like "pulse".
I've made a jsfiddle to explain this:
https://jsfiddle.net/7ngtwfrL/3/
Do you have any idea ?
Thanks a lot !

Hey You See There Add This IntoYour Editor

Welcome To pulse

OK I understand my mistake, thank you :)

welcome again
On Wed, Jul 13, 2016 at 5:27 PM, lokiiiii<EMAIL_ADDRESS>wrote:

OK I understand my mistake, thank you :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/daneden/animate.css/issues/603#issuecomment-232333647,
or mute the thread
https://github.com/notifications/unsubscribe/ATaZWJRjbFE5ysNvq7eu8jd5EjMQFKXCks5qVNKogaJpZM4I8m_Y
.


clone with --force arg

im trying to clone a repo by force into an existing one
            let repo = Repository::clone(
                package_template_repo_url,
                clone_destination.clone(),
            );

apparently there is no args method for builder pattern.
how can i specify arguments to clone method ?
such as:

force ? does this exist ?
--branch
--depth
and many more

You can use RepoBuilder to control the clone options (FetchOptions, CheckoutBuilder, etc.).  libgit2 does not support shallow clones, though.

yeah. but that example is very minimal ...

thats all the documentation for that ? ...

That is the documentation available. Is there something that seems to be missing?  The FetchOptions and CheckoutBuilder contains documentation for each option.

okey, i'll read the docs and come back later.


Improve documentation of additions to the generic test cases

As ...
P.D. - Plugin Developer
I want ...
better documentation of the additions and changes made to the generic tests.
So that ...
I can understand better what changes I need to make to my tests and code to support new Nautobot releases.
I know this is done when...
I test my plugin against new Nautobot release and my tests pass without errors.
Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[ ] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[X] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[X] Documentation
[ ] Other (not directly a platform feature)

Database Changes
No response
External Dependencies
No response

Examples from the 1.4 release would include:

GetObjectNotesViewTestCase added in #1984
NotesURLViewTestCase added in #2120
Filtering tests added in #1794
others?


TableView/GridView

Some resources:

Chameleon UITableView _layoutTableView()
RAD.js list view layoutItems()
This article (Infinite scroll) by the RAD.js team has some good advice
Ember list view _scrollContentTo()
React ListView onScroll()
React Native Issue #499 has a very good explanation by vjeux on the differences between iOS UITableView and React Native ListView.

How can I help with this issue further? Should I create a new branch 'tableview-component', try to put a first version together, and create a PR so we keep discussing there? Or are you thinking on tackling it yourselves as it's a big one?


Feature/support non gps devices

To appear on the playstore even if they don't have a gps device.

Current coverage is 99.43% (diff: 100%)

Merging #40 into develop will not change coverage

@@            develop        #40   diff @@
==========================================
  Files            35         35
  Lines           883        883
  Methods           0          0
  Messages          0          0
  Branches         91         91
==========================================
  Hits            878        878
  Misses            0          0
  Partials          5          5

Powered by Codecov. Last update 5caad3c...47a91e1


is it confusing that some hex colors have 6 vs 8 digits?

I don't know what the distinction/importance of this is, or if I can use either rgb or argb anywhere. Thought I'd just mention that it's something I don't understand (but it hasn't been a problem).

Yeah, I don't think I actually need ARGB values anywhere now. (ideally beginners should never see hex colours anyway). Will go through the library and make sure they're all RGB format.


Distinguish host attributes from listeners.

Migrate listeners out of on-* attributes on .
Fixes #20.

LGTM with nits

Thanks for the review!


Print to stderr, not stdout

Apple XCTest prints to stderr, whereas Swift XCTest prints to stdout. Some users expect stderr output, so print to stderr. Also, update the tests to capture stderr output.
Haven't run these tests locally yet, I'm expecting some initial failures.

@swift-ci please test

Thanks for opening this @modocache. This seems like a good change to make. The test failures look to be due to output scripts mixing stdout and stderr output. Tests that are using print to do output aren't flushing the way the XCTest output does, so the stdout lines all end up at the end of the script.
@ddunbar @aciidb0mb3r Do you know if swift test depends on the current behavior at all? I'm not sure how the parallel execution mode parses output from each the test runner processes?

TL;DR It doesn't depend on current behaviour
It shouldn't matter where (stdout/stderr) the output goes because swift test  just shell out the XCTest binary. For parallel we just display the output (again either stream) of tests which failed.

Excellent. I've let this languish a bit. @briancroom (or anyone else!) if you'd like to get this in sooner feel free to commandeer it. I'll probably update this by Monday or so. :)

Hmm, two months is too long to keep a pull request open, I think. If anyone still wants this done, please create a task on https://bugs.swift.org.


fix(dependabot): ignore docs folder

Current dependencies on/for this PR:

main

PR #84   👈

This comment was auto-generated by Graphite.


Suggested enhancement: Snap-and-drag behavior

For my needs, the user should be able to click (or touch) anywhere on the slider, have the handle snap to that position, and continue dragging from there without releasing the mouse button (or finger).
Pull request #14 is my suggested implementation. Future work may include a prop to configure the various behaviors (perhaps similar to noUiSlider's behaviour option).

Thanks.


Additional args to img? (build-args, env, etc.)

Hello! At @wireapp we're trying to cut down our docker build times in concourse and think this builder may help; I have it rigged up in my pipeline; but I need to pass additional arguments at build time such as:

--env blah=val
--build-args blah=val

Taking a quick look at the build script looks as though there isn't a way to do this currently;
Am I missing a way to do this? If not; do you have plans to implement this, or a suggestion for how you'd like it to be done so I can submit a Pull request? Thanks!
Cheers 🍻

Incidentally it looks like I can actually pass additional args as part of CONTEXT which isn't expanded inside quotes e.g. "$CONTEXT"; but that's probably not a great idea haha.

@ChrisPenner Ha, yeah probably not a good idea.
How about a PR to just add "$@" to the args here?:
https://github.com/concourse/builder/blob/f1c9f1770069c5b09af0c07df316d0e14d51fff4/build#L83
That way any args passed to build would just be forwarded along.

I was just about to propose adding --target and --build-args, but indeed, perhaps allowing any flags is more ideal as @vito mentioned, giving more flexibility to folks use whatever they want from img 👍

ATM all I really need is (multiple) --build-arg and --env; but I suspect I might have other needs as time goes on. I'm currently held up by bugs in build-kit; but apparently those are fixed; so I'll take another look at this once there's a release available.

Hi :wave:
As I don't really see any objections to this feature, I have opened a PR to add this ability in #12. I agree with @cirocosta, that rather than having a 'generic' option to pass any option, it is better to be specific. If there is a need to include other options, I think they should just be added to params.
I would really appreciate this getting looked at, I also have a requirement for this and don't particularly want to maintain my own fork :smiley:
Thanks

After submitting a PR that I hadn't properly tested, I have now opened a new PR #13. This works as expected and allows you to specify build args. I agree with the point made by @cirocosta regarding it being an anti-pattern to have a 'catch all' option that gets passed through. If new options are required, I think it is better to update the build script to support them.

fixed by https://github.com/concourse/builder-task/pull/13 - thanks! I'll build and publish a new version shortly.


Document convert types safely

Related issues:

https://github.com/microsoft/botbuilder-dotnet/issues/4773 - tracking
https://github.com/microsoft/botbuilder-dotnet/issues/4615#issuecomment-705960670 - closed

Possible new functions:

tryParseToJson
tryParseToFloat
tryParseToBool
tryParseToBase64
tryParseToXml
tryParseToBinary

Updates to existing functions:

int
string
json
float
bool
base64
xml (C# only)
binary

Closing due to age. If this is still an issue, please re-open this request with updated details.


ABI problem

struct S {
    int a, b;
};
void bar(struct S);
void foo() {
    struct S s;
    bar(s);
}

According to the amd64 ABI，the whole s is passed by register rdi. 😒

yes, I passed its address~~~~~

It is tooooooooo complicate of AMD64 ABI to pass a struct......


Suffix match operator

What would you like to be added:
we have operator pmatch works really well on the prefix match against a list of strings, similarly, I would like to have smatch (suffix-match) to do suffix match against a list of string.
Why is this needed:
This works well in the scenarios of image matching, for example, we have quay.io/sysdig/agent and docker.io/sysdig/agent, if we have the suffix match operator, we can create a condition like container.image.repository smatch [sysdig/agent] without caring about the image hub.

cc @mstemm ^^

👍 ⬆

Would be useful to avoid things like this https://github.com/falcosecurity/falco/blob/03fbf432f1fddc8e4708271e18cd79aada31d615/rules/falco_rules.yaml#L2388-L2400

🆙

I'm not sure that having this kind of operator will be a good use case for docker images.
if you don't put the FQDN of the image one can bypass the image check by pushing their malicious image on another registry or with a prefix.
E.g
container.image.repository smatch [sysdig/agent]

matches

docker.io/sysdig/agent

but also

docker.io/myevilsysdig/agent
quay.io/anothersysdig/agent

Clearly it depends on how you use such operator while composing your rules.
By the way the situation you describe is possible also without this operator.


Fix recessive and filtered variants issue

Project https://mosaic.chpc.utah.edu/#/projects/371/samples example that @AlistairNWard found

Project with id 371 is no longer there, but I think this was A677 project.
Here is the note:

I'm going to improve the label on Edit Filter so this is more obvious.

Ok cool. I just added a comment in Mosaic. The label doesn't mention GnomAD, or popmax. Is the filter just on popmax AF, or the gnomAD AF?


Calling Card Data

This PR should add all the calling card data I current have available (everything but prestige), which should make the addition of calling cards much quicker.
(Github didn't like me, hence the closing and reopening stuff and lack of description)


Minorfix for Speaker Detail

Codecov Report

Merging #1058 into development will increase coverage by 0.02%.
The diff coverage is 75%.

@@               Coverage Diff               @@
##           development    #1058      +/-   ##
===============================================
+ Coverage        66.39%   66.42%   +0.02%
===============================================
  Files                7        7
  Lines             1122     1123       +1
  Branches           175      176       +1
===============================================
+ Hits               745      746       +1
  Misses             377      377

Impacted Files
Coverage Δ

src/backend/fold.js
84.98% <75%> (+0.03%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde930c...20edb27. Read the comment docs.


added @SafeVarargs to methods that perform save operations on varargs parameters

thanks

Actually, the tests don't pass because soft assertions requires method to proxy not to be final.
This had a positive outcome to remove all the @SafeVarargs ffrom the API class to make soft assertions work.

Shame. :/


Implement standard pauser with temporary pausing support

OIP-1: Pause Guardian
Refers to issue: #984
Summary
This PR includes an implementation of a standard Pauser contract that enables a single-use (per user) temporary pause feature to speed up the response in case of attacks. The users are a whitelist of security researchers granted access by the governor or strategist in the OUSD system. The users have authorization for temporary pausing that can be confirmed by the governor or strategist, or canceled by any user. The users might be incentivized to correctly use this feature to help prevent attacks but that is beyond the scope of the implemented solution.
Contract change checklist:

[ ] Code reviewed by 2 reviewers. See template and example.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Hi! I will be look at this tomorrow morning. Apologies for the delay, I've been out of office.

Thanks @DanielVF

Thanks for writing this, @staa99! Overall, it's good code that's easy to follow. Great work figuring out our deployment and tests setups.
I'll write individual notes as separate comments.

Since we are changing to always pausing both vault rebasing and capital at the same time, and unpausing them together, we can just use single pause variable do both. (rename old vars as deprecated, add new var to end of storage.  We can also change to using a stand pause events from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/security/Pausable.sol .
This should let us have less code in the vault contracts.

Thanks for the review @DanielVF. I'll update the contracts and tests accordingly.

Hi @DanielVF,
I have just made the necessary updates. Please review when you're available.
Thank you.


Incorrect prerequisites for developing tasks

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Question
Enter Task Name: CmdLineV2
list here (V# not needed):
https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/CmdLineV2
Environment

Server - Azure Pipelines or TFS on-premises?
Azure Pipelines

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Ubuntu 18.04
Issue Description
CmdLineV2:
https://github.com/microsoft/azure-pipelines-tasks/blame/master/Tasks/CmdLineV2/task.json#L72 refers to Node14. However, the prerequisites documentation refers to Nod10 as the Production execution environment.
https://docs.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#prerequisites
Is this line of code bug, or intended to be that that way and the custom tasks created must work both in Node10 and Node14?
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Hi @vairakkumar-vairaperumal, sorry for the delay: we faced with some issues due to Node14 migration, so it's reverted currently - I updated related docs as well.


RKE2 Provisioning: Cluster Options - Pod Security Policy

apiVersion: provisioning.cattle.io/v1
kind: Cluster
metadata:
  name: #string
  annotations:
    {}
#    key: string
  labels:
    {}
#    key: string
  namespace: fleet-default
spec:
  cloudCredentialSecretName: do
  kubernetesVersion: v1.21.0-alpha2+rke2r1
  defaultPodSecurityPolicyTemplateName: null

Reopening in order to re-define expectations here.

Issue #1: Default PSPs in UI are not populating the Default PSP template drop down in the RKE2 provisioning UI. Note: This works in RKE1 (Ember) UI.
Issue #2: Currently, we only remove the permissive PSP, but we need to remove any PSPs that are auto created by RKE2. RKE2 creates additional restrictive PSPs when cis-mode is turned on. Rancher needs to clean up all PSPs so that any PSP to be used on the cluster is managed/maintained by Rancher.

How Rancher and RKE2 will work together for PSPs
When provisioning a RKE2 cluster through Rancher, Rancher will default to "RKE2 default" PSPs and RKE2 will automatically deploy the PSPs into the cluster.
If the default PSP template is chosen through Rancher, Rancher will delete the Global Unrestricted PSP and Global Restricted PSP (created by RKE2) from a RKE2 cluster.
Rancher will require a PSP template to be chosen during provisioning, but the "RKE2 default" option is essentially passing no PSPT to the cluster.

UI Changes needed:

[ ] Update "None" to "RKE2 Defaults", which will represent not setting the PSP templates.
[ ] Consolidate Security section in Basics with the CIS profile so that CIS profile and PSPs are in the same tab

@ibuildthecloud We need to add the ability to delete the global Restricted PSP as well if we use a PSP template.
So if you pick a CIS profile and a PSP template, then it will use the template from Rancher..

@vincent99 Can we default to RKE2 Default instead of "unrestricted" for PSP?

https://github.com/rancher/rancher/pull/33857

Note: the global unrestricted and global restricted policies will get created initially and eventually get deleted.

Currently, Rancher was assuming that there would be annotations on the global restricted and global unrestricted PSPs created by RKE2 so that it could be identified and deleted, but the annotations that Rancher was looking for are actually on the namespace, not on the actual PSPs.
Instead of Rancher updating to delete specifically named PSPs (as we are using generic names), @ibuildthecloud is asking the RKE2 team to add the annotations onto the actual PSPs.
Rancher is looking for these PSPs so that we could delete them if a PSPT from Rancher has been selected as the default PSP.
psp.rke2.io/global-restricted or  psp.rke2.io/global-unrestricted
This request has been made in RKE2: https://github.com/rancher/rke2/issues/1512

https://github.com/rancher/kontainer-driver-metadata/pull/628

v2.6-head 88a46bd
Validated that when a PSP is selected from Rancher ("unrestricted"), which is a PSPT in Rancher, that is deployed in the cluster and the global PSPs deployed by RKE2 (global-unrestricted and global-restricted) are removed from the cluster.
Need QA to validate that the PSPT deployed through Rancher is applied on the cluster.

v2.6-head (4b6af95)
Validated that if passing a PSPT (restricted), then that PSP is applied to the entire cluster. Even with a restricted PSP applied to the cluster, the global policies created by RKE2 are removed and the system-unrestricted-psp PSP remains, which is required to allow the RKE2 system components to work.


Remove disabling auth and set created_by for nodes, namespaces, and tags

Summary

DISCLAIMER: Once this PR is merged, there could be implications to some custom oauth flows, specifically if you do not save the DataJunction user object for users coming through oauth. As nodes, namespaces, and tags are created, it's expected that the user object passed in through the auth plugin has a user ID that exists in the datajunction metadata database and can be directly linked to the entities.

This PR does two main things:

Removes the ability to disable auth, making current_user no longer optional
Sets a created_by parameter when nodes, namespaces, and tags are created that links to a user by their ID

A few extra things in this PR:

Updated the demo database
Updated the roads notebook to use a requests session so that the login cookies can be used to authenticate the requests
Add an optional username and password for the DJClient init for servers that use basic auth (optionally a DJ_PWD env var for the password)

Test Plan
Wrote tests and also ran docker compose --profile=demo up to test running the notebook and validating that created_by is being set in the metadata database.

[x] PR has an associated issue: #836
[x] make check passes
[x] make test shows 100% unit test coverage

Deployment Plan
N/A

Closing this since this has been implemented in #1101 and #1113


Remove reference to libraries.source.api.init

Remove reference to libraries.source.api.init at https://docs.frontity.org/api-reference-1/wordpress-source#libraries-source-api-init
Luis thinks it should not be there. https://community.frontity.org/t/make-the-backend-url-a-global-setting/2381/50

Done! 👍


Feature request: support Fountain syntax

Fountain is a markup language based on Markdown, but customized for screenwriting. Would it be possible to add this as a doctype? A lot of screenwriters are moving to it. Thanks!
http://fountain.io/syntax

Hello @MarinaMichaels, do you need only fountain to html converter ?
Which tool do you use for now?
Thanks

@rahmanusta
I'm using AsciiDoc to transcribe a screenplay using Fountain syntax. (Information on the syntax: http://fountain.io/syntax). In AsciiDocFX, I have the language set to Markdown, which Fountain is similar to. I'd like to set it to Fountain.
After saving the AsciiDoc file, I make a copy of the file with a .txt extension, then import the .txt file into WriterDuet (https://writerduet.com). WriterDuet recognizes the Fountain syntax and formats the file properly as a screenplay. Final Draft and several other screenwriting software packages also recognize the Fountain syntax. A lot of screenwriters are using Fountain because it makes it easier to write a screenplay anywhere.
Is it also possible to see a preview of the screenplay (formatted as a screenplay in the preview pane) in AsciiDocFX?
Thanks again for such an awesome editor!


build: Update Python dev version to 3.9.5

As well as bump pre-commit hooks and project dependencies.

Coverage remained the same at 97.145% when pulling c91c5dc604537fce10c3d444465c70b6d7e11ad2 on build/python-3.9.5 into c33b547c480ae7a019b3c38155cbd32e84b26558 on master.


[move core modules] remove use of Transaction::sender in association …

…module

Motivation
Working on deprecating Transaction::sender() and move_to_sender
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Existing tests pass.

:umbrella: The latest upstream changes (presumably da181a64b0dd354a177089787730a637f5671c8e) made this pull request unmergeable. Please resolve the merge conflicts.

:pushpin: Commit 5f3c042 has been approved by tzakian

@bors-libra r=tzakian

:hourglass: Testing commit 5f3c04240f9d252bee5ba076f83e7aa87d4ee2bb with merge a1d1715a65156bf51fb5b05ca73dd3de06a8ff32...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=tzakian

:pushpin: Commit 1f864e5 has been approved by tzakian

:hourglass: Testing commit 1f864e5290e0e7b2196f2f60d89c44e638771f06 with merge 6344c36ac91794fba322e3c1d60c4beedb28944f...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing 6344c36ac91794fba322e3c1d60c4beedb28944f to master...


Fix: vulnerability in request dependency

<EMAIL_ADDRESS>has a dependency of<EMAIL_ADDRESS>which has a reported vulnerability (see https://nodesecurity.io/advisories/598).
This PR upgrades the dependency of request to latest, in which tunnel-agent also have been fixed.

Closing this as request is deprecated, so the proper solution would be to use another lib altogether.


Extract a function to check whether to diagnose a self-conformance failure

Noticed by inspection; I couldn't find a simple test case which ended up with obviously bad diagnostics without this.

@swift-ci Please smoke test.

Eh... I'm not sure this is a good change.  Closing.


Added features under Chargeback Rates

Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen.
Follow up PR for https://github.com/ManageIQ/manageiq-ui-classic/pull/7016
Fixes #6996
Should be merged after https://github.com/ManageIQ/manageiq/pull/20129 & https://github.com/ManageIQ/manageiq-ui-classic/pull/7016
before

after

Existing feature(no change)
New feature

chargeback_rates

chargeback_rates_copy

chargeback_rates_delete

chargeback_rates_edit

chargeback_rates_new

chargeback_rates_admin

chargeback_rates_show_list

chargeback_rates_show

chargeback_rates_view

Need a data migration to give user access to chargeback_rates_view feature if they have any of these features allowed chargeback_rates, chargeback_rates_copy, chargeback_rates_edit, chargeback_rates_delete, chargeback_rates_new

@skateman i need some guidance on:

Data migration part for feature changes in this PR
Need to discuss how to proceed with start page shortcut changes(that's a messy one, we will need data migration for those twice, first once we split a single explorer into multiple explorers and then again as we convert explorer screens into non-explorers) Just trying to think if there is a better way to handle that, any advice/suggestions?

So as far as I understand, the migration has to go through the features and if all are enabled, also enable the new parent.

I kinda have the migration for the features, just need to finish the reverse ones. Regarding the start page, I guess it's already broken now without the migration as we no longer have the main explorer. We have to make a choice with a single page that would repace Overview/Chargeback. My suggestion is to go with the Reports, but I'm okay to do it with any other.

Jansa backport details:
$ git log -1
commit 4d162e53c2218c84380654394603a7723040a1f8
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Tue May 19 13:30:10 2020 -0400

    Merge pull request #20156 from h-kataria/cb_rates_non_explorer_features

    Added features under Chargeback Rates

    (cherry picked from commit 53dae01b24de45815e6760741cb8c5e8f905ebbb)


Update package-lock version

Because running npm install on a clean checkout is putting
the git repo in a dirty state.

Wow, thank you for the PR!


openlp: init at 2.4.6

free church presentation software
The package is split in two parts: The main python package to build (lib.nix) and a wrapper package pulling in configurable runtime dependencies (default.nix), so that rebuilds are unnecessary when changing runtime deps/features.
Review notes

The critical parts to test are: Video playback (manual) via the 3 backends (system, webkit, vlc) and presentation support (manual) via mupdf and libreoffice (uno).
All these tests require the package openlpFull. In openlp they aren't used, as they are optional.
When switching the video backend, it is best to restart OpenLP afterwards to make sure only the right one is initialized. To switch, select only one backend in Settings → Configure OpenLP → Players.

Things done

(na) means “not applicable”

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] (na) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] (na) Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
package openlp: 676.1 MB, package openlpFull: 3.0 GB.
[ ] (na) Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Additionally:

[x] Tested in a pure nix-shell. There, audio does not work, as pulseaudio cannot be connected, but this is also the case using plain vlc.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/qt-plugin-path-unset-in-test-phase/6962/2

adapted qt 5.14
This PR now depends on #98185 as it is based on d63977883deadcddb4752526d87132134c0a368c.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 91291 run on x86_64-linux 1

2 packages built:

openlp
openlpFull

In the last push (63ff41b2be8a6f6aa432e4e0bde257ea8ce38890) I added meta.hydraPlatforms = [ ] to the wrapper, because only the baseLib derivation needs to be built by Hydra.

Anything preventing this from being merged?

fails to build:
  Using setuptoolsBuildPhase
  Using setuptoolsShellHook
  Sourcing pip-install-hook
  Using pipInstallPhase
  Sourcing python-imports-check-hook.sh
  Using pythonImportsCheckPhase
  Sourcing python-namespaces-hook
  qtPreHook
  Error: wrapQtAppsHook is not used, and dontWrapQtApps is not set.
  builder for '/nix/store/cj3pjcndim4sp3b72f0i7jdqwdfy8ms8-python3.8-openlp-2.4.6.drv' failed with exit code

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 91291 run on x86_64-linux 1

2 packages failed to build and already failed to build on hydra master:

openlp: log was empty
openlpFull: log was empty

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

openlpFull:

warning: unused-argument
Unused argument: mock.
Near pkgs/applications/misc/openlp/lib.nix:7:49:
  |
7 | , alembic, beautifulsoup4, chardet, lxml, Mako, mock, nose, pyenchant
  |                                                 ^

warning: unused-argument
Unused argument: nose.
Near pkgs/applications/misc/openlp/lib.nix:7:55:
  |
7 | , alembic, beautifulsoup4, chardet, lxml, Mako, mock, nose, pyenchant
  |                                                       ^

openlp:

warning: unused-argument
Unused argument: mock.
Near pkgs/applications/misc/openlp/lib.nix:7:49:
  |
7 | , alembic, beautifulsoup4, chardet, lxml, Mako, mock, nose, pyenchant
  |                                                 ^

warning: unused-argument
Unused argument: nose.
Near pkgs/applications/misc/openlp/lib.nix:7:55:
  |
7 | , alembic, beautifulsoup4, chardet, lxml, Mako, mock, nose, pyenchant
  |                                                       ^

Fixed the failure due to the introduction of the new qtPreHook.
Result of nixpkgs-review 1

2 packages built:

openlp
openlpFull

Still building and running:
Result of nixpkgs-review pr 91291 run on x86_64-linux 1

2 packages built:

openlp
openlpFull

@ofborg eval

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 91291 run on x86_64-linux 1

2 packages built:

openlp
openlpFull


Feature: enable typechecking exercise templates

The exercise templates I create are always intended to be well-typed, with NotImplemented exceptions raised wherever the student is expected to provide their own solution. Sometimes these templates contain significant starter code. To verify it's well-typed, I have to build the exercise, run the server, open the exercise, and hit compile. It would be nice if I could get feedback in the build step.

This looks like a sensible suggestion, thanks.
but I'm pretty sure not all people would like to typecheck the template.ml files as well.
what about a CLI option (disable by default) that also typechecks this file, and triggers a global failure in case of a syntax/type error?

BTW you might be interested in the learn-ocaml-editor webapp (statically deployed at https://pfitaxel.github.io/pfitaxel-demo/#activity%3Deditor ; soon to be integrated in learn-ocaml master so that any Test_lib improvement is taken into account):
In particular, there is a Check button in the Template tab:
Screenshot

And import/export of an exercise as a .zip file.

Would it work to run something like ocamlc -i prelude.ml prepare.ml template.ml from the exercise directory ?


1.0.85 (jquery/select2): select2 dropdown value missing

plunk for version 1.0.60:
https://plnkr.co/edit/Apqo32Wead3wfprmrSxO?p=preview
plunk for version 1.0.85:
https://plnkr.co/edit/GQl2e5rpFj1ugMZmRKUK?p=preview
steps in both plunks to reproduce the problem

search for "sql" (without "")
select value from dropdown, ideally the same
click complete

result is empty in version 1.0.85, result is present in 1.0.60.
didn't try other versions betwen .60 and .85.

We've fixed the issue
Fix will be available in the nearest update

Thx for your fast help!

Problem is here again, Last working version is 1.0.89, since 1.0.90 value is empty.
not working, please look at actual version of plunk (using 1.0.95):
https://plnkr.co/edit/msMbPudJFNgUF0NxyZV4?p=info
working, please look at previous version of plunk (using 1.0.89)

Hello,
We've fixed the issue
Fix will be available in the nearest update
Thanks, Dmitry
SurveyJs Team

thx!


Add types declaration file

Resolves #3. Let me know if there are any issues.

👍 thanks for your contribution @geopic


Add a new transformer for decimals to improve efficiency

Decimals are currently serialized via
    private static string FormatG30(decimal d) {
      return d.ToString("g30", CultureInfo.InvariantCulture);
    }

and decimal.TryParse().
It should be possible to stored decimals more compactly.

Done


Optimize "ORDER BY + LIMIT" queries for speed / memory with special TopK operator

Which issue does this PR close?

Closes #7196
Closes https://github.com/apache/arrow-datafusion/pull/7250
Rationale for this change
Adding TopK to DataFusion limits the resources (memory, CPU) needed for SELECT .. ORDER BY [..] LIMIT N type of queries.
@alamb implemented most of the changes necessary, this PR does some final update / clean up of the code.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thank you @Dandandan  -- let me know if you would like help finishing up this PR. It has been on my list but I haven't had a chance yet.
Maybe I could make a PR that changed the display of plans to show when topk was being used 🤔

FYI @gruuya -- it is finally happening

Thanks @alamb for the review - I plan to test it at our side (Coralogix) and see if there's some follow-up necessary.

The only query it gets slower for is large N with multiple files. I believe this is because reconstructing the 10,000 row outputs for each of the partitions, merging them, and then reconstructing the heap is fairly expensive. It would be better in this case to avoid the sort and doing a final topK.

This sounds like a good idea, although probably in for distributed usage (e.g. Coralogix) might not be beneficial as we'll need to fetch all partitions instead of doing TopK + merge in a distributed manner.

Filed

https://github.com/apache/arrow-datafusion/issues/7749 to track adding fuzz tests
https://github.com/apache/arrow-datafusion/issues/7750 to track making it clearer when TopK is used in the plans


Example of severity mapping

Add an example showing how to extract from a json log record its severity level and map it to a severity mapping

@aurbiztondo-splunk please review


Add error checking in output options list

If a user gives an output channel that has an incorrect object number, MD will seg fault. Example: requesting FairTen4 from a system with 3 lines.
Corresponds with:
https://github.com/FloatingArrayDesign/MoorDyn/blob/0a9a8aac08b67f37cba4a0073c0d5250b9cc9a76/source/MoorDyn2.cpp#L1260

Duplicate of #165


refacotry and update readme

Codecov Report

Merging #17 (438d599) into main (cb7be45) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          396       394    -2
=========================================
- Hits           396       394    -2

Impacted Files
Coverage Δ

chunksum/cli.py
100.00% <100.00%> (ø)

chunksum/mp.py
100.00% <100.00%> (ø)

chunksum/iter.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support for "ignore" comments

Is your feature request related to a problem? Please describe.
Some officially supported Python Markdown extensions (like admonition use non-standard Markdown syntax. These cases are not properly handled by the parser currently. For example:

# Some title

!!! note
This will render as a tooltip box.

Back to normal markdown content.

Describe the solution you'd like
It would be useful if there was an "ignore" comment that could be added to a markdown file to skip formatting specific sections. The prettier library uses <!-- prettier-ignore --> and <!-- prettier-ignore-end --> for this purpose.
Describe alternatives you've considered
Plugins could be written for to handle cases like this, but it would be useful if there was a global way to disable formatting in specific sections of a document.
Additional context
It looks like there's a similar discussion happening on an existing PR about how to ignore blocks of code. I'd be fine with a solution where I could wrap certain sections in a div that sets a class that's globally ignored, but I feel like a plain comment would be a better interface for this use case, as it wouldn't require modifying the AST of the markdown.

Hi @jamescurtin and thanks for the issue!
I like the feature.
Some notes/thoughts regarding implementation already :smile:

reference links (spanning in and out of the ignored block) could be problematic
I think deciding what to ignore has to happen in renderer. Doing so before parser/renderer is problematic because, e.g. there is no ignore block in the MD below, and it's difficult to know that without parsing:<!-- mdformat ignore start -->
```
<!-- mdformat ignore end -->
```

The token stream the renderer currently receives is abstract, not concrete syntax. The renderer doesn't know the original formatting. One way or the other it would have to I guess.

I'm expecting a bug free implementation could be quite hard to come up with. A plugin that brings formatting support for admonition (that you mentioned) might be easier (although not as general solution ofc).

It looks like there's a similar discussion happening on an existing PR about how to ignore blocks of code.

This discussion is related to ignoring stuff from a safeguard that ensures mdformat does not alter markdown AST. All markdown is still formatted, so it's not really the same thing.

Hi @jamescurtin and thanks for the issue!
I like the feature.
Some notes/thoughts regarding implementation already 😄

reference links (spanning in and out of the ignored block) could be problematic
I think deciding what to ignore has to happen after parsing. Doing so before parser is problematic because, e.g. there is no ignore block in the MD below, and it's difficult to know that without parsing:<!-- mdformat ignore start -->

The token stream the renderer currently receives is abstract, not concrete syntax. The renderer doesn't know the original formatting. One way or the other it would have to I guess.

I'm expecting a bug free implementation could be quite hard to come up with. A plugin that brings formatting support for admonition (that you mentioned) might be easier (although not as general solution ofc).

It looks like there's a similar discussion happening on an existing PR about how to ignore blocks of code.

This discussion is related to ignoring stuff from a safeguard that ensures mdformat does not alter markdown AST. All markdown is still formatted, so it's not really the same thing.

Hi @hukkin , is there any progress to support the feature?

@rmorshea did you use mdformat-mkdocs or mdformat-admon? If not, please try, if yes, maybe file an issue in the plugin's issue tracker?

I gave those two a try and had no luck. I'll file an issue, but I suppose the point is that if ignore comments existed I'd be able to work around the problem.


Matching any child with NodePattern

From @Drenmi :

there's a long standing request to add an "any child" matcher. This would be especially helpful when matching on hashes. Consider:
ruby-parse -e '{ foo: 1, bar: 2 }'

(hash
  (pair
    (sym :foo)
    (int 1))
  (pair
    (sym :bar)
    (int 2)))

We may be interested in hashes that have a foo: 1 pair, but the pairs can appear in any order, so we can't reliably match that in a pattern. 🙂
What is needed is a suggested extension to the syntax, and the actual implementation.

Suggested syntax extension would be <...> as it seems the easiest remaining "brackety" symbol left.
Simple:
(hash <(pair (sym :foo) (int 1)) (pair (sym :bar) (int 2))>)

This would match {bar: 2, foo: 1} and {foo: 1, bar: 2} but nothing else. To match hashes containing these two value-key pairs, use ...:
Ellipsis:
(hash <(pair (sym :foo) (int 1)) ...>)

This would match any literal hash with a foo: 1 key-value pair. Ellipsis must be at end of <> sequence.
Note: Patterns are attempted to be matched in the order given. <(pair _ (int 1)) (pair (sym :foo) _)> would match {bar: 1, foo: 1} but not {foo: 1, bar: 1}. Captures are always returned in the order of the pattern.
Comments?

Description edited to match #6965


986 Replace xpubs with privateKeys

The Problem

The Solution

Checklist:

[ ] I am making this PR against staging, not master
[ ] My code follows the code style of this project.
[ ] I have described any backwards-incompatibility implications above.
[ ] I have highlighted which parts of the code should be reviewed most carefully.
[ ] If my change requires a change to the documentation, I have updated it accordingly.

closing, replacing with #1003


Export annotation

Hello,
I'm currently working on sparsification/quantization of yolov5 using sparseml. I have my optimized model. I would like to run inference on images and to export the result in a txt file like yolo does. Is it possible with deepsparse.object_detection.annotate ?
Thank you

Hey @Ahuriste
Good question.
The easiest thing to do would be running inference using the deep sparse server. The request basically holds all the relevant output, that you'd probably like to then dump into a text file.
If you insist on using the annotate script, what I can currently suggest to you is slightly tweaking the source code to accommodate your needs. See those three variables here: boxes, scores, labels here: https://github.com/neuralmagic/deepsparse/blob/main/src/deepsparse/yolo/utils/utils.py#L447
This is the data that should interest you in every inference pass. It should be quite easy to modify the script so that in every inference pass all this data gets saved/appended to a text file.
Hopefully, this helps. If you need more detailed information, feel free to ping me here.


[FEATURE] Linked Cameras and Zones

Would be helpful to link or group cameras for triggering of recording. ATM I use this type of feature  to record all cameras if a fire is detected.
I’d like to improve further on this by being able to link zones and record zones specifically.
The grouping of cameras I think is more important, but being able to see that a zone had an “event” happen in HA might be useful for others as well.

Just to clarify, you would like to link cameras together, so when one starts recording, another one will record as well?
What do you mean by linking zones/record zones?

The grouping of cameras I think is more important, but being able to see that a zone had an “event” happen in HA might be useful for others as well.

Objects detected in zones are sent to Home Assistant using specific zone binary sensors. Or is there something else that you are after?

Actually found another thread about this so closing this :)


Include index length information for MySQL on connection#indexes

The index information returned by ARJDBC from connection#indexes is missing lengths.
This has some implications. For example, rails can't properly reconstitute a database using db:schema:dump followed by db:schema:load if the database include indexes on columns that require length (mostly, text columns). This is not really ARJDBC fault, since JDBC itself doesn't includue this information on its metadata.
This commit fixes that, for MySQL at least, by overriding #indexes and using a MySQL-specific query to discover indexes on a table (SHOW KEYS) instead of querying JDBC metadata.
The SQLBlock.call() access attribute was modified to protected to allow implementing subclasses outside its package -- I had to do that to use it from MySQLRubyJdbcConnection.

@cmsd2 can you file a separate issue with some details? Thanks.


Update README installation instructions when package is added to PyPI

The README is currently written to install from GitHub. Change to install from PyPI

Completed in 84526223a7537e1788eb97de684b19512241ccf8


Difference to commonmark with tight list and fence

I found that the following code is interpreted differently in common mark and markdown-it:
   - a
     > b
     ```
     c
     ```
   - d

While common mark will interpret it as tight list with a fenced code block markdown-it will issue an inline code element instead. Is this a bug or intended this way?
markdown-it demo
commonmark demo

That's not indended, markdown-it pass all 0.27 spec tests and we resync with latest spec from time to time.
Need to check what'up. Thanks for report.

Is this a bug or intended this way?

Definitely a bug (blockquotes inside indented lists hadn't been terminated correctly).
Thanks for reporting!


dart2js crash when using super mixins with private names

When run on the program below, dart2js crashes with the stack trace also included below.  This is triggered by a new nonfunction type alias test out for review here, but seems to be unrelated to the new feature given the repro case below.
// lib1.dart
class PublicClass {
  int _privateInstanceMethod() => -1;
}

mixin PublicSuperMixin on PublicClass {
  int _privateMixinMethod() => super._privateInstanceMethod();
}

// main.dart
import "package:expect/expect.dart";

import "lib1.dart";

class Derived2 extends PublicClass with PublicSuperMixin {
  int _privateMixinMethod() => 1;
}

void test2() {
  // Test that the super-mixin methods resolve correctly.
  var p = Derived2();
  Expect.equals(1, p._privateMixinMethod());
}

void main() {
  test2();
}

cc @sigmundch @rakudrama @fishythefish

I can't repro with the given files. What stack did you see?

Sorry forgot that part.  Interestingly, it seems to require the --test-mode flag to reproduce.  Enclosed below is a command line and the resulting stack trace.  If I remove the --test-mode then the error goes away.
leafp-macbookpro:sdk leafp$ sdk/bin/dart2js_developer --test-mode  /Users/leafp/tmp/test.dart --libraries-spec=sdk/lib/libraries.json --platform-binaries=xcodebuild/ReleaseX64/  --out=/Users/leafp/tmp.js
../../../tmp/test.dart:
Internal Error: The compiler crashed when compiling this element.

The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

* the name and version of your operating system,

* the Dart SDK build number (build number could not be determined), and

* the entire message you see here (including the full stack trace
  below as well as the source location above).

The compiler crashed: NoSuchMethodError: The getter 'node' was called on null.
Receiver: null
Tried calling: node
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:54:5)
#1      AbstractDataSource.readMemberNode (package:compiler/src/serialization/abstract_source.dart:309:30)
#2      DataSourceMixin.readStringMap (package:compiler/src/serialization/mixins.dart:245:18)
#3      new JClassEnvImpl.readFromDataSource (package:compiler/src/js_model/env.dart:254:16)
#4      new JClassEnv.readFromDataSource (package:compiler/src/js_model/env.dart:182:20)
#5      new JsKernelToElementMap.readFromDataSource.<anonymous closure> (package:compiler/src/js_model/element_map_impl.dart:359:27)
#6      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:397:8)
#7      _EntityLookup.forEachClass (package:compiler/src/js_model/element_map_impl.dart:2561:14)
#8      new JsKernelToElementMap.readFromDataSource (package:compiler/src/js_model/element_map_impl.dart:358:18)
#9      new JsClosedWorld.readFromDataSource (package:compiler/src/js_model/js_world.dart:135:13)
#10     deserializeClosedWorldFromSource (package:compiler/src/serialization/task.dart:104:14)
#11     BytesInMemorySerializationStrategy.deserializeGlobalTypeInferenceResults (package:compiler/src/serialization/strategies.dart:94:33)
#12     Compiler.globalTypeInferenceResultsTestMode (package:compiler/src/compiler.dart:457:21)
#13     Compiler.compileFromKernel.<anonymous closure> (package:compiler/src/compiler.dart:500:13)
#14     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#15     Compiler.compileFromKernel (package:compiler/src/compiler.dart:469:14)
#16     Compiler.runInternal (package:compiler/src/compiler.dart:304:13)
<asynchronous suspension>

Yeah, --test-mode adds extra serialization/deserialization between the phases, which is where this NPE is coming from.

https://github.com/dart-lang/sdk/blob/master/pkg/compiler/lib/src/serialization/member_data.dart#L37 seems to be responsible.

To be clear, this isn't blocking me.  I'll approve the test with this issue and land it.


JS runnable browser

This PR adds support for running the full browser (for chapters 2-8) in the browser, with demo browsers for chapters 2, 3, and 4. Besides some bug fixes, the main changes are:

Support for bind in the runtime. All the keys used in the chapters to date are implemented, and extending this shouldn't be too painful. This also required special-casing bind in the compiler to deal with "with".
Support for using fetch to fetch real web pages. The main change here is special-casing makefile to be an async function, so that it can make async requests. Naturally the web page needs to allow CORS to be fetchable.

I believe this is ready to merge


Duplicated logic when performing D20 rolls

For example, Actor5e#_prepareSkill prepares each skill object (this shows on the sheet), yet when performing a skill "check", the whole logic is redone and the skill object is not actually used.
Actor5e#rollSkill should use the relevant skill object, not calculate the bonus each time.

The issue is that _prepareSkill merges all bonuses together into one final value, while rollSkill displays them separately. What we'd need to do for this is to store the different bonus parts and prepared data within each skill object.


reflect: undeprecate StringHeader, SliceHeader?

CL https://go-review.googlesource.com/c/go/+/401434 marked these as deprecated, but if you want to do something like extract the pointer inside a string or a slice, it is unclear what you should use instead. We need to have an available answer before we ship a release with them deprecated.
See also #53003.

Within std we currently have the internal/unsafeheader package, which defines String and Slice structs, but they're only marginally safer and not very ergonomic either.

CC @ianlancetaylor.


Cleanup all and enable pylama

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

@napalm-automation/council please review


Remove deprecated command groups/commands/arguments in Azure CLI 2.37.0

Azure CLI 2.37.0 will be released for Microsoft Build 2022 as a breaking change window.
There are some command groups/commands/arguments that will be deprecated in Azure CLI 3.0.0, but since there is no plan to bump Azure CLI to 4.0.0, https://github.com/Azure/azure-cli/pull/16380 has been closed. As an alternative, all deprecated command groups/commands/arguments should be removed in Azure CLI 2.37.0.
Additional information
Microsoft Graph migration will be made in this version: https://docs.microsoft.com/en-us/cli/azure/microsoft-graph-migration

vm @zhoxing-ms
https://github.com/Azure/azure-cli/blob/07f12f95f0b5d4159cf837216f75d0d62e3ed7b1/src/azure-cli/azure/cli/command_modules/vm/commands.py#L391

appservice @panchagnula @jsntcy @zhoxing-ms
https://github.com/Azure/azure-cli/blob/9ae79579509ca623207413b524469c6772850400/src/azure-cli/azure/cli/command_modules/appservice/_params.py#L197

monitor @jsntcy @kairu-ms
https://github.com/Azure/azure-cli/blob/dc77a8cc2b57dfabb2e074cd0a4270da83a6bb45/src/azure-cli/azure/cli/command_modules/monitor/_params.py#L338

network @jsntcy @kairu-ms @wangzelin007 @necusjz
https://github.com/Azure/azure-cli/blob/90e6f75514cec2d5dfd2df7526007105c6d207ba/src/azure-cli/azure/cli/command_modules/network/_params.py#L1959


Duplicate system tray Icons in W11 -> Settings -> Personalization -> Taskbar

Microsoft PowerToys version
0.69.1
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
Duplicate system tray Icons in W11 -> Settings -> Personalization -> Taskbar
Every time I update PowerToys, I've to switch on the system tray icon in taskbar settings again so it always shows up by default in my taskbar without clicking the '^' icon. This is because every time I update PowerToys it creates a new & duplicate system tray icon in taskbar settings.
See screenshot:

✔ Expected Behavior
No duplicates
❌ Actual Behavior
Duplicates
Other Software
No response

/dup #24502


Define builtin types (size_t, ptrdiff_t, etc)

After discussion in https://gitlab.com/cznic/cc/-/issues/126 it's clear that cxgo must define types like size_t, ptrdiff_t, etc.

Isn’t it already defined in stddef.h?

They are, but the problem is that they actually need to be defined as builtins (without any includes).


AWS service icons missing

Was going to make an identical issue in https://github.com/mingrammer/diagrams only to see 200+ issues and 70+ PRs. 😞
The current list of aws services is pretty outdated, do you have an issue with me submitting a PR to add several service icons?
I can make an exhaustive list of what I plan to add, I just don't know everything that's missing yet. 😅

Was going to make an identical issue in https://github.com/mingrammer/diagrams only to see 200+ issues and 70+ PRs. 😞
The current list of aws services is pretty outdated, do you have an issue with me submitting a PR to add several service icons?
I can make an exhaustive list of what I plan to add, I just don't know everything that's missing yet. 😅

of cause, i added a few icons i needed, base on the assets from https://aws.amazon.com/architecture/icons/.
you can feel free to list the service : icon-url, or raise a PR. 😄


Transport overview page

Draft pull request for discussion.
I would like to streamline the process to work with feature branches based on transports in abapGit. Currently you either use the transport-to-branch feature or manually fiddle with branches and committing the correct objects.
I added a page that groups objects by the transport they are currently locked in. If there is no branch on the remote that has the same name as the transport you can click a button to create that branch. If that branch already exists you can commit changes to it. The stage screen is filtered so only objects of that transport show up. The diff is calculated against that branch. If the branch does not exist yet master is used for comparison (this should lead to all uncommitted changes being displayed).

In my opinion this could provide a somewhat missing link between CTS and Git. I however am not sure if this belongs in core abapGit (as it kind of forces a specific branching model) and if it does to what extend. Building this outside of abapGit also seems weird and difficult though.
Opinions?
(Proof of concept, for merging performance needs to be optimized, syntax backported, CSS adjusted etc.)

perhaps add it in the view dropdown instead of the menubar?

perhaps add it in the view dropdown instead of the menubar?

You mean as a toggle to switch the main repo page into this layout or just move the link?
At a previous attempt I had in the main page but noticed that I basically had to remove all other UI elements as they don't make sense for this.

Update:

I added a local repo setting "CTS target branch" which indicates the branch transport-based branches get merged into (in most cases master). If it is set it controls which branch is taken as a base for the "create branch" button. If it is not set the actions for commit and create branch are not shown and the currently checked out branch is used for diffs.
I figured this way you have to first enable the workflow and get a chance to read some documentation. If you don't enable it you can still see all changes grouped by transports that are not yet in the current branch.

I'd probably suggest defaulting it to HEAD or master, or let the user specify in a popup, but this is a minor issue

this is getting quite old, can we close the PR for now, and reopen when its ready?

Sure, no problem

I'm looking into a similar integration with CTS for streamlining our change process with AbapGit. Where you able to finish it?
Our process requires a TL to create a Transport Request and Change requests for the developers.
To enforce, it could be done when creating a branch (creating TR and linking it with Branch).
Commits to the branch would also release the Change Request.
Pull Request would release also the Transport Request.
This way the abapGit would enforce the process.

this pull request is closed, feel free to open new issues with questions/suggestions/comments/feature requests 😄

@ed-holland
One of the main problems with this was the relation between objects in transports and files in abapGit. For example abapGit does currently not determine the correct transport for LIMU-objects in function groups (#2961) and for other things it is simply impossible to create the correct relation (for example if two developers change two methods of the same class in two different transports).
I worked around some of the problems by implementing the CTS BAdIs and syncing transport state with GitLab merge requests (https://github.com/flaiker/ci-lib) but in the end it is a lot of work with lots of edge cases and technical limitations.


Rethink when to store and reset state

From the feedback of Vassil after one of the trainings:
"We need to revisit what is stored in the state of each "page" and when is this state reset. For example, users do a search, then click to calendar, go to a specific month, then day view of one day, then select one of the reports. They read the report, then go back to read another one of that day, but they have to re-navigate again. I suggest to go over the UI and define for each page which state properties are reset and how depending on navigation path. Might be a good opportunity now that we have hooks."

We need to define this per component, not per page.


rafthttp: build transport inside pkg instead of passed-in

rafthttp has different requirements for connections created by the
transport for different usage, and this is hard to achieve when giving
one http.RoundTripper. Pass into pkg the data needed to build transport
now, and let rafthttp build its own transports.
This prepares for big snapshot transfer in v3 snapshot case.
This also fixes #3568 (manually tested). Originally it always drops request after 5s and may lead to forever snapshot sent failure. Now it could send the full snapshot out.

Refreshed with new comments. Ready for a new round of review.

LGTM


Improved localization

Hello, first of all thanks for this awesome app! 🙂
I've initially added an Italian translation for my own purposes; I then thought I could contribute it back if you like it. I've added the Italian localization of the Finder context menu, plus I've also localized (fr/it) the help messages. I noticed there was a French localization of the main help message, but it was unused.
I've no experience in GUI development and my French is also a bit rusty, so I could have messed something up. So far, though, this modified version is running smoothly on my Mac. 🙂

Great contribution! Thanks a lot


Why file explorer button on the left side, bellow extension button should be disappear when hide file explorer

VSCode Version: 1.14.0-insider Commit 5cb4570007af28b5e0c0b4177e0283dc961ebbb8
OS Version: Ubuntu 16.04

Steps to Reproduce:

File explorer button shouldn't be disappear when click to hide file explorer view, that way we don't have to select to show it again from view menu
Launch vscode insider
View the behavior when try to hide file explorer view from explorer button

Reproduces without extensions: Yes/No

You managed to remove the explorer from the activity bar, just bring it back via context menu:

You can drag and drop it to the top to reorder its position.

If I reorder it's position to top, and click to hide it, and bring it back via the context menu, it will appear at bottom, not at the top.


Turn server setup

I have a server A that is open to internet. And server B under a strict firewall that only allow outbound connection. Clients on the same network on server B can only connect to server B, there is no internet connection.
Based on documentation and discussion, I can setup a TURN server on server A. Expose 3478. I can also setup a livekit server on server A and server B. The config file of both livekit server will point to the TURN server .
Is there some other ports I need to open on server A ? Other than 3478 , 7880, 7881 ?  Is this setup right ?

Or the turn server should be run inside server A. livekit server on server B. Livekit server points to turn server on server A via port 3478
Client connect to server A via TURN.
But how to specify the turn server on client?
there is a lack of documentation on how to connect via turn server

external TURN servers are configured here.
you are asking for a very specific use case that we do not officially support. you are welcome to still try to make it work though! but do keep in mind that this is the road less traveled, and you'd likely not find docs to guide you through.
Also, LiveKit cannot be used as a standalone TURN server.


Questions about the keypoint numbers and loss functions on KITTI dataset

Hi, thanks for the great work. I came across a problem when trying to reproduce the performance on KITTI dataset. I tried different combinations of keypoint numbers (from 64 to 1024) and loss functions (both circle_loss and desc_loss). However, none of my test was able to converge given more than 256 keypoints. Can I have any suggestions on this? Cuz I notice in the paper, the model is able to train even with 5000 keypoints.

UPDATE: I checkout from the previous commit and trained with the default parameters, but the problem is still there.


How to correctly set-up .gitlab-ci-local-variables.yml for proper CI_REGISTRY_IMAGE

At first awesome project! Many thanks for sharing and the lot of help and support you're doing.
Is your feature request related to a problem? Please describe.
I'm trying to set-up a local docker:dind workflow including push to a local running registry
Describe the solution you'd like
Currently docker push stucks as $CI_REGISTRY_IMAGE looks as follows:
local-registry.gitlab.com/typoworx-gmbh/development-stack/my-test-app

I think it is derived from my .git/config remote URI which looks as follows:
url = git@gitlab.com:typoworx-gmbh/development-stack/my-test-app.git

Describe alternatives you've considered
I've defined CI_REGISTRY in .gitlab-ci-local-variables.yml and expected that the tagging will follow this rules. I'm somehow confused at first time what was failing.
I didn't find an example what an variables-setup should look like to emulate local registry for local-ci runner. Could you help me or provide one in examples/ of your project pls?
Additional context
This is how my current .gitlab-ci-local-variables.yml looks like:
CI_PROJECT_PATH: ""
CI_PROJECT_NAME: "my-test-app"
CI_JOB_NAME: "gitlab-ci-local"

CI_REGISTRY: "registry-api.my-test-stack.docker:5000"
CI_REGISTRY_USER: "*****"
CI_REGISTRY_PASSWORD: "****"
CI_JOB_TOKEN: "${CI_REGISTRY_PASSWORD}"
CI_COMMIT_REF_SLUG: local-build

Docker login already seems to suceed:
 $ echo "$CI_REGISTRY_PASSWORD" | docker login --username "$CI_REGISTRY_USER" "$CI_REGISTRY" --password-stdin
> WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
> Configure a credential helper to remove this warning. See
> https://docs.docker.com/engine/reference/commandline/login/#credentials-store
> Login Succeeded

I've been trying to extend my .gitlab-ci-local-variables.yml as follows:
CI_REGISTRY_IMAGE: "$CI_REGISTRY/$CI_PROJECT_PATH/$CI_PROJECT_NAME"

But obviously the varibles referenced are not substituted by gitlab-local-ci?!
> invalid argument "$CI_REGISTRY/$CI_PROJECT_PATH/$CI_PROJECT_NAME:local-bild" for "-t, --tag" flag: invalid reference format: repository name must be lowercase

Would be awesome if that would be possible in syntax $VARIABLE and ${VARIABLE} or I am doing something wrong?

After updating to more recent gitlab-ci-local this seems to work now by using this line in .gitlab-ci-local-variables.yml
CI_REGISTRY_IMAGE: "$CI_REGISTRY/$CI_PROJECT_PATH/$CI_PROJECT_NAME"


Error: Bad CPU type in executable (os error 86) on Mac Intel

I'm facing bad cpu type when running ambient new <name> after following the guide https://ambient.run/docs/user/installing.
While using the advanced method, the binary seems compiled correctly. cargo install --git https://github.com/AmbientRun/Ambient.git --tag v0.3.0 ambient

Hi there! Thanks for reporting this - we don't have Intel/universal macOS builds yet ( #1074 ). We're planning on fixing this at some point, but I'm glad to hear that the advanced method worked for you 🙂


Moving to Kraken

Based on the comments in https://github.com/samsung-cnct/k2/pull/741 we have decided as a team to name k2cli Kraken and K2 will be Krakenlib.
This issue will take care of moving all references of k2cli to Kraken and k2 to krakenlib.

Fixed in: https://github.com/samsung-cnct/k2cli/pull/139


Support gcov coverage reports

We need to verify test coverage and increase it using existing tools designed for this. Gcov does provide this and relies on data generated by the compiler. Supporting this in an RTOS is not as easy as with a program running on the host system, so some work needs to be done on Zephyr to allow data collection from the target devices:
For reference, see:

https://www.thanassis.space/coverage.html
https://mcuoneclipse.com/2014/12/26/code-coverage-for-embedded-target-with-eclipse-gcc-and-gcov/
https://github.com/reeteshranjan/libgcov-embedded

Hey all,
Adding support for code coverage on the targets sounds very interesting. I would like to work on it.
Is there anybody I could discuss it further?

@xasc if you want to discuss things related to this feature, this is the right place.


[SPARK-39803][SQL] Use LevenshteinDistance instead of StringUtils.getLevenshteinDistance

What changes were proposed in this pull request?
This pr just use LevenshteinDistance in commons-text instead of StringUtils.getLevenshteinDistance in commons-lang3 to cleanup following compilation warnings:
[WARNING] /basedir/spark-source/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala:79: [deprecation @ org.apache.spark.sql.catalyst.util.StringUtils.orderStringsBySimilarity.$anonfun | origin=org.apache.commons.lang3.StringUtils.getLevenshteinDistance | version=] method getLevenshteinDistance in class StringUtils is deprecated

Why are the changes needed?
Cleanup deprecation api usage related  to commons-lang3, only this one case.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

https://github.com/apache/commons-lang/blob/105a350b154eac7c3f3a6bac94ec2cfb0fbe232b/src/main/java/org/apache/commons/lang3/StringUtils.java#L2309-L2336

https://github.com/apache/commons-text/blob/0cd901c387cf766e8869598632c80d9d72d3ab9d/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java#L363-L388

thanks @dongjoon-hyun


Add closing jsx tags to examples in readme

This had me confused for way longer than I'd like to admit after copy & pasting your examples to try out.

Thanks! And sorry for the trouble...