Issues "rerendering" state on navigate event.

RE: Netman issue #154
I am having some issues understanding how sources are "meant" to rerender their tree on a navigate event.
I am currently having navigate called for all open events and it turns out that is incorrect and bad behavior (which is why my state is constantly being reset). Taking a look at how other sources manage this, they seem to have their own open function that is called with the various open commands.
Cool, makes sense to me. However, I cannot seem to figure out how to rerender the tree state as it was "previously" when a user left the source.
The wording here might not make a ton of sense so pictures are good.
A user navigates to something within the Netman source.

They change sources

And then they navigate back to the Netman source.

Of course this is my code doing this, but I don't understand the "proper" way to rerender the tree back out, so I just have it redoing the entire start of the tree again. What is most frustrating is I can see the tree has the nodes still in it from the previous state. In fact, attempting to add one of those nodes back to the tree with the same ID throws a fun error stating its already in the tree (because of course, it is). However, I cannot get the tree associated with the state to render back into the buffer.
I have attempted the following things

Extracting the nodes from the tree and readding the entire tree

Ended up with the fun above error of "This node is already in the tree"

Simply calling require("neo-tree.ui").renderer.redraw(state)

This just closed the Neo-tree buffer and left me with an empty buffer

Calling state.tree:render()

This throws an error stating the buffer ID is invalid.

I'm sure this is simple but god help me if I can't figure this out. What am I missing?

Actually, the other sources just start from scratch every time and don't really have any state to worry about. The only exception is the filesystem source which just remembers what folders were opened and reapplies those open folders as it's loading. There is no attempt to save and restore the Nui TreeNodes though.

Got it, so this isn't a solved problem. Or rather, this isn't a problem for any other sources within Neo-tree. Fun! Well I will close this out and bang my head against the wall for a bit :joy:

Where I would go with this is to make it so the existing buffer is reused instead of discarding it like may be happening now. That combined with the existing state is all you really need to pick up where you left off. If you use position = "current" and just manually switch buffers using plain vim methods (like :b#) you'll probably find it works fine and your state is saved. The source selector is a little bit of a hack and should be re-worked to just switch buffers instead of recreating the whole thing.

Where I would go with this is to make it so the existing buffer is reused instead of discarding it like may be happening now

My checking into this, the buffer is indeed discarded after source switch. Which seems expensive.  At worst though, if I can figure out how to clear the tree out, I do have the full serialized tree I can re-render. The main issue with this is that the nodes will have the same ID and for some reason the tree seems to maintain the nodes even with nilling the tree out, setting the nodes to {}, etc. Likely some closure shenanigans making my changes void but still lol.


Candidate Release Comments (Project Popularity)

This issue was created to collect comments about the upcoming metrics release.
This thread is for comments about Popularity
GitHub location: https://github.com/chaoss/wg-value/blob/master/focus-areas/living-wage/project_popularity.md
Release candidate: https://chaoss.community/metric-project-popularity
See all release candidates of metrics are at:
https://chaoss.community/metrics-rc/
Important Dates
Release Freeze: June 21st, 2019
Candidate Release: June 24th, 2019
Comments Close: July 24th, 2019
Release Date: August 1st, 2019

This was noted in the community meeting on July 9th, 2019.
Requesting more information on sections 3 to 6.

Programming language[1][2] can also influence the popularity of a project.

Popularity, Interoperability, and Impact of Programming Languages in 100,000 Open Source Projects
What Attract Newcomers to Onboard on OSS Projects? TL;DR: Popularity

Following are other proxy measures used to measure project popularity.

Number of source code download
Number of subscriber
Number of stars
Number of watchers
Number of followers
User ratings
Appearance on the top list of google search or other blogs

@andyl, I suggest that this metric is also table this composite metric until a later Metrics version release.

At the CHAOSS level, we have not fully worked out how composite metrics will be expressed. This metric is a trailblazer in that regard. I also suggest postponing it until the next release to make sure we have the source metrics in place and can think about how to represent composite metrics.

Perhaps the v-index is another potential measure: https://opensource.com/article/18/5/metrics-project-success

@klumb @andyl @GeorgLink Please remove this as a candidate metric for Version 1 as discussed in the Value call on Friday, July 19. This metric will be readdressed in a future metrics release.

#197 removes this from release

Thanks @klumb

closing issue, because Project Popularity is no longer a release candidate


Failure loading google avatar images.

I got the avatar picture from Google login, then I am using that URL on Avatar library.
I am using it as:
<Avatar name={user.name || user.email} src={user.picture} size={props.size} round={props.round} />
Where user.picture is:
https://lh3.googleusercontent.com/a-/AOh14GhPQpoU8p7dup-XNsukdZPROPc4ygZc89J4epO9sw=s96-c
This causes loading an avatar with letters from user.name. But if I remove "=s96-c" part of the src url it works. The URL as is can be open on a browser an it works without any issues..

Hi @forlayo ,
I'm unable to reproduce your issue, could you set up a codesandbox example which demonstrates the issue?

Hi @JorgenEvens  I am now unable to reproduce the issue following the same steps; it's just working as expected.
Apologizes and thanks for your quick review.


[BUG] BlobClient.uploadFromFileWithResponse() continues to saturate network after send timeout

Describe the bug
BlobClient.uploadFromFileWithResponse() accepts a timeout parameter, and if timeout is elapsed before upload is complete a java.lang.IllegalStateException ("Timeout on blocking read for xxxxxxxxx NANOSECONDS") exception is thrown.
However on my Windows 10 environment if you use Resource Monitor you can see that even after the exception has been thrown javaw.exe continues to saturate the outbound network connection until the remaining buffer has been transferred.
To Reproduce
Have a slow internet connection.  If you connection is naturally fast you can use tools to artificially slow it.
Open Windows Resource Monitor.  View the Network tab and sort by the Send (B/sec) column.
See that javaw.exe is not sending anything.
  You'll get a java.lang.IllegalStateException when the timeout is elapsed.
Return to Windows Resource Monitor.  See that javaw.exe is still saturating your outbound internet connection.  This continues until the current block has been sent.  On a slow connection this might take a long time.
Code Snippet
String largeFilePath = ......................;
BlobClient blobClient = ......................;
blobClient.uploadFromFileWithResponse(
new BlobUploadFromFileOptions(largeFilePath),
Duration.ofSeconds(1),
(Context) null
);
Expected behavior
Network traffic should stop when unploadFromFileWithResponse() function exits..
Setup (please complete the following information):

OS: Windows 10
Library/Libraries: com.azure:azure-storage-blob:12.14.4

My initial impression is that the contents of the request are put on to the send queue in the HttpClient but when the timeout occurs and cancels the internal reactive stream the request connection associated with the request isn't closed/cancelled.

I see. The latter seems more likely to me in this case. And it's a matter of the reactive stream being cancelled but not the http client. Is there any way to propagate that cancellation to the client?


Not working with hangul(korean language)

When i use thie  with hangul(korean language) highlight is disabled.
For example,
// ANCHOR This is a anchor   -> highlight is enabled
// ANCHOR This is a anchor 이것은 앵커입니다.  -> highlight is enabled but just displayed english text in sidebar.
// ANCHOR 이것은 앵커입니다. -> highlight is disabled.
please check this one.

Thank you for bringing this issue to light!
Since this seems like a technical limitation of RegEx, it was challenging to find a nice solution for this problem. I've fixed this by allowing comment anchor comments to be surrounded by double quotes, allowing you to specify what belongs to the anchor.

Even though this means you may have to add two more characters, this fix should support all non-English characters, including symbols and emojis. This functionality will be available in a few days time in version 1.6.1.
Hopefully this helps you!


Should patch be shared with reporter before release?

Hello,
currently the guide and the runbook mention that the reporter can assist with developing the patch if they want to. However, if they do not assist in developing the patch, would it be reasonable nonetheless to share the patch with the reporter before the release so they can verify that it covers all corner cases? Though on the other hand that could further delay publication of the release, so that would be an optional thing to do.
Unfortunately I cannot provide specific examples but I remember vaguely that there have been situations in the past where developers thought their patch fixed all issues, created a release but then it turned out that the patch was incomplete.

inviting @u269c into this conversation :)


Great work!

It's not done yet!!! I think it will be a WIP the rest of my live ;). But I just needed a place to store everything that I find, and that is shared :).


Assignment ballots (and refactoring motion ballots)

A bit WIP, because the old (2.3) definitions don't fit exactly; we might need to recalculate the ballots per page, and maybe redesign the header of a ballot.

state here: with some long names, we cannot print identical ballots with the old ballot amounts per page; thus the ballots per page are slightly reduced (and there might still be cases where that is too high). Else, it is reviewable (especially the 'refactoring ballots' part)

@tsiegleauq for request, as you're the most experienced in pdf wonderland

@tsiegleauq I changed ballots per page back to 8 for two-option + 'no'  ballots.

I rebased it and resolved the new merge conflict.


Remove "experimentally" from TEST section in README

WHY
Because of there is nothing wrong with testing at present .

/cc @dtan4

LGTM


Add editable tip and docs typo fix to README

To help contributors out who don't understand why they don't see their changes taking effect, I've added a tip about how to install in editable mode. I didn't include the extras, but that should okay if they're not changing the extras (i.e. the extras will be there from the example installation).
I also added backticks as the Markdown lint VS Code extension recommends it, and it leads to better syntax highlighting in VS Code. But I can remove if you prefer indented style. The README currently uses a mix.

Changed to [all], that's what I've been doing myself now too.


Terminal hideen caracters

Type: Bug
Just I open the terminal and an lunch some process caracters won't be visible
VS Code version: Code 1.86.0 (05047486b6df5eb8d44b2ecd70ea3bdf775fd937, 2024-01-31T10:27:46.147Z)
OS version: Linux x64 5.15.0-92-generic snap
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 1800)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 2, 1

Memory (System)
15.34GB (10.24GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch --crash-reporter-id 8bab254c-4d86-4dd8-9805-c5cf41895c5a

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (25)

Extension
Author (truncated)
Version

simple-react-snippets
bur
1.2.7

vscode-eslint
dba
2.4.4

gitlens
eam
14.8.0

react-native-react-redux
EQu
2.0.6

prettier-vscode
esb
10.1.0

flow-for-vscode
flo
2.2.1

auto-rename-tag
for
0.1.10

vscode-lottie
lot
1.0.5

rainbow-csv
mec
3.11.0

vscode-language-pack-fr
MS-
1.85.2024020709

vsliveshare
ms-
1.0.5905

vscode-react-native
msj
1.12.3

emoji
Per
1.0.1

material-icon-theme
PKi
4.33.0

fabric8-analytics
red
0.9.2

java
red
1.27.0

vscode-xml
red
0.26.1

LiveServer
rit
5.7.9

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.2.30

vscode-java-debug
vsc
0.56.0

vscode-java-dependency
vsc
0.23.4

vscode-java-pack
vsc
0.25.15

vscode-java-test
vsc
0.40.1

vscode-maven
vsc
0.44.0

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyonecf:30548226
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
dsvsc019b:30953937
3ef8e399:30949928
bg6jg535:30958357
ccp2r3:30958157

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!
/label info-needed

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Error while loading the page in google cached version

What is the location of your example repository?
https://github.com/Shopify/hydrogen.git
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
2023.4.5
What version of Remix are you using?
1.19.1
Steps to Reproduce

open hydrogen.shop in a browser
add "cache:" as prefix in the current URL and load the page.
Then it is throwing an error that "Initial URL (/) does not match URL at time of hydration (/search), reloading page...".
And page goes into infinite loop of reloading process.
As I was following it earlier, It was showing diffrent error, around 10 days back, I am attaching the screenshot of that here.

Expected Behavior
While opening the google cached version of webpage , The page should get loaded without any error, and must not reload again and again.
Actual Behavior
Page continously gets reload and showing error , while opening the google cached version of webpage.
Currently it's showing: "Initial URL (/) does not match URL at time of hydration (/search), reloading page...".
Earlier it was showing:

Can you try again with the latest version, I think this was related to the instagram redirect bug.


ZeroDivisionError: division by zero

Python 3.10.11 (main, Apr 20 2023, 19:02:41) [GCC 11.2.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.17.2 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from transformers import AutoTokenizer, TextStreamer
   ...: from intel_extension_for_transformers.transformers import AutoModelForCausalLM
   ...:
   ...: model_name = "Intel/neural-chat-7b-v1-1"     # Hugging Face model_id or local
   ...: model
   ...: prompt = "Once upon a time, there existed a little girl,"
   ...:
   ...: tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True)
   ...: inputs = tokenizer(prompt, return_tensors="pt").input_ids
   ...: streamer = TextStreamer(tokenizer)
   ...:
   ...: model = AutoModelForCausalLM.from_pretrained(model_name, load_in_4bit=True)
   ...: outputs = model.generate(inputs, streamer=streamer, max_new_tokens=300)
None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.

---------------------------------------------------------------------------
ZeroDivisionError                         Traceback (most recent call last)
Cell In[1], line 2
      1 from transformers import AutoTokenizer, TextStreamer
----> 2 from intel_extension_for_transformers.transformers import AutoModelForCausalLM
      3 model_name = "Intel/neural-chat-7b-v1-1"     # Hugging Face model_id or local model
      4 prompt = "Once upon a time, there existed a little girl,"

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/intel_extension_for_transformers/transformers/__init__.py:19
      1 #!/usr/bin/env python
      2 # -*- coding: utf-8 -*-
      3 #
   (...)
     15 # See the License for the specific language governing permissions and
     16 # limitations under the License.
---> 19 from .config import (
     20     WEIGHTS_NAME,
     21     AutoDistillationConfig,
     22     BenchmarkConfig,
     23     DistillationConfig,
     24     DynamicLengthConfig,
     25     FlashDistillationConfig,
     26     NASConfig,
     27     Provider,
     28     PrunerV2,
     29     PruningConfig,
     30     QuantizationConfig,
     31     TFDistillationConfig,
     32 )
     33 from .distillation import (
     34     SUPPORTED_DISTILLATION_CRITERION_MODE,
     35     DistillationCriterionMode,
     36 )
     37 from .mixture.auto_distillation import AutoDistillation

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/intel_extension_for_transformers/transformers/config.py:22
     20 import yaml
     21 from enum import Enum
---> 22 from neural_compressor.conf.config import (
     23     Distillation_Conf, Pruner, Pruning_Conf, Quantization_Conf
     24 )
     25 from neural_compressor.conf.dotdict import DotDict, deep_set
     26 from .utils.metrics import Metric

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/__init__.py:28
     20 # we need to set a global 'NA' backend, or Model can't be used
     21 from .config import (
     22     DistillationConfig,
     23     PostTrainingQuantConfig,
   (...)
     26     MixedPrecisionConfig,
     27 )
---> 28 from .contrib import *
     29 from .model import *
     30 from .metric import *

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/contrib/__init__.py:18
      1 #!/usr/bin/env python
      2 # -*- coding: utf-8 -*-
      3 #
   (...)
     15 # See the License for the specific language governing permissions and
     16 # limitations under the License.
     17 """Built-in strategy for multiple framework backends."""
---> 18 from .strategy import *

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/contrib/strategy/__init__.py:25
     23 for f in modules:
     24     if isfile(f) and not f.startswith("__") and not f.endswith("__init__.py"):
---> 25         __import__(basename(f)[:-3], globals(), locals(), level=1)

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/contrib/strategy/tpe.py:26
     22 from pathlib import Path
     24 import numpy as np
---> 26 from neural_compressor.strategy.strategy import TuneStrategy, strategy_registry
     27 from neural_compressor.strategy.utils.tuning_sampler import OpWiseTuningSampler
     28 from neural_compressor.strategy.utils.tuning_structs import OpTuningConfig

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/strategy/__init__.py:19
      1 #!/usr/bin/env python
      2 # -*- coding: utf-8 -*-
      3 #
   (...)
     15 # See the License for the specific language governing permissions and
     16 # limitations under the License.
     17 """Intel Neural Compressor Strategy."""
---> 19 from .strategy import STRATEGIES
     20 from os.path import dirname, basename, isfile, join
     21 import glob

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/strategy/strategy.py:35
     32 import numpy as np
     33 import yaml
---> 35 from neural_compressor.adaptor.tensorflow import TensorFlowAdaptor
     37 from ..adaptor import FRAMEWORKS
     38 from ..algorithm import ALGORITHMS, AlgorithmScheduler

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/adaptor/__init__.py:26
     24 for f in modules:
     25     if isfile(f) and not f.startswith("__") and not f.endswith("__init__.py"):
---> 26         __import__(basename(f)[:-3], globals(), locals(), level=1)
     28 __all__ = ["FRAMEWORKS"]

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/adaptor/pytorch.py:43
     40 torch_utils = LazyImport("neural_compressor.adaptor.torch_utils")
     41 ipex = LazyImport("intel_extension_for_pytorch")
---> 43 REDUCE_RANGE = False if CpuInfo().vnni else True
     44 logger.debug("Reduce range is {}".format(str(REDUCE_RANGE)))
     47 def get_torch_version():

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/utils/utility.py:129, in singleton.<locals>._singleton(*args, **kw)
    127 """Create a singleton object."""
    128 if cls not in instances:
--> 129     instances[cls] = cls(*args, **kw)
    130 return instances[cls]

File ~/.virtualenvs/intel-transformers/lib/python3.10/site-packages/neural_compressor/utils/utility.py:254, in CpuInfo.__init__(self)
    252 self._sockets = self.get_number_of_sockets()
    253 self._cores = psutil.cpu_count(logical=False)
--> 254 self._cores_per_socket = int(self._cores / self._sockets)

ZeroDivisionError: division by zero

Hi, the error you met, I thought it was the neural compressor issue recently.
https://github.com/intel/neural-compressor/blob/master/neural_compressor/utils/utility.py#L255C34-L255C55

Please install the ITREX from the source code~
I have run the whole installation process. It's ok if you follow the commands.
git clone https://github.com/intel/intel-extension-for-transformers
cd intel-extension-for-transformers
pip install -r requirements.txt
pip install transformers==4.33.1
python setup.py install

Please put your script outside of the intel-extension-for-transformers root directory to make sure the script calls API from the conda env you installed rather than local ITREX directories.
from transformers import AutoTokenizer, TextStreamer
from intel_extension_for_transformers.transformers import AutoModelForCausalLM
model_name = "Intel/neural-chat-7b-v1-1"     # Hugging Face model_id or local model
prompt = "Once upon a time, there existed a little girl,"

tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True)
inputs = tokenizer(prompt, return_tensors="pt").input_ids
streamer = TextStreamer(tokenizer)

model = AutoModelForCausalLM.from_pretrained(model_name, load_in_4bit=True)
outputs = model.generate(inputs, streamer=streamer, max_new_tokens=300)

Inference screenshot:

Traceback (most recent call last):
File "/home/kangyuhan/finetuning/intel-transformers/intel-extension-for-transformers/demo.py", line 2, in
from intel_extension_for_transformers.transformers import AutoModelForCausalLM
File "/home/kangyuhan/finetuning/intel-transformers/intel-extension-for-transformers/intel_extension_for_transformers/transformers/init.py", line 19, in
from .config import (
File "/home/kangyuhan/finetuning/intel-transformers/intel-extension-for-transformers/intel_extension_for_transformers/transformers/config.py", line 22, in
from neural_compressor.conf.config import (
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/init.py", line 28, in
from .contrib import *
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/init.py", line 18, in
from .strategy import *
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/strategy/init.py", line 25, in
import(basename(f)[:-3], globals(), locals(), level=1)
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/strategy/sigopt.py", line 21, in
from neural_compressor.strategy.strategy import TuneStrategy, strategy_registry
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/strategy/init.py", line 19, in
from .strategy import STRATEGIES
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/strategy/strategy.py", line 35, in
from neural_compressor.adaptor.tensorflow import TensorFlowAdaptor
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/adaptor/init.py", line 26, in
import(basename(f)[:-3], globals(), locals(), level=1)
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/adaptor/pytorch.py", line 43, in
REDUCE_RANGE = False if CpuInfo().vnni else True
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/utils/utility.py", line 129, in _singleton
instances[cls] = cls(*args, **kw)
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/utils/utility.py", line 257, in init
self._cores_per_socket = int(self._cores / self._sockets)
ZeroDivisionError: division by zero
I encountered the same problem. My cpu is  Intel Xeon Platinum 8358

回溯（最近一次调用最后一次）：
文件“/home/kangyuhan/finetuning/intel-transformers/intel-extension-for-transformers/demo.py”，第 2 行，来自
intel_extension_for_transformers.transformers import AutoModelForCausalLM
文件“/home/kangyuhan /finetuning/intel-transformers/intel-extension-for-transformers/intel_extension_for_transformers/transformers/ init .py"，第 19 行，来自
.config import (
文件 "/home/kangyuhan/finetuning/intel-transformers/intel-extension- for-transformers/intel_extension_for_transformers/transformers/config.py"，第 22 行，来自
neural_compressor.conf.config import (
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor / init .py”，第 28 行，来自
.contrib import *
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/ init .py”，第 18 行，在
from .strategy import *
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/strategy/ init .py”，第 25 行，在
import (basename( f)[:-3], globals(), locals(), level=1)
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/contrib/strategy/ sigopt.py”，第 21 行，来自
neural_compressor.strategy.strategy导入TuneStrategy，strategy_registry
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/strategy/ init .py ”，第 19 行，来自
.strategy import STRATEGIES
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/strategy/strategy.py”，第 35 行，来自
neural_compressor .adaptor.tensorflow import TensorFlowAdaptor
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/adaptor/ init .py”，第 26 行，导入
( basename(f)[ :-3], globals(), locals(), level=1)
文件 "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/adaptor/pytorch.py",第 43 行，在
REDUCE_RANGE = False if CpuInfo().vnni else True
File "/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/utils/utility.py"，第 129 行，在 _singleton
实例中[cls] = cls(*args, **kw)
文件“/home/kangyuhan/.conda/envs/llama_factory/lib/python3.10/site-packages/neural_compressor/utils/utility.py”，第 257 行，在init
self._cores_per_socket = int(self._cores / self._sockets)
ZeroDivisionError：除以零
我遇到了同样的问题。我的CPU是Intel Xeon Platinum 8358 操作系统为Linux
lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                128
On-line CPU(s) list:   0-127
Thread(s) per core:    2
Core(s) per socket:    32
座：                 2
NUMA 节点：         2
厂商 ID：           GenuineIntel
CPU 系列：          6
型号：              106
型号名称：        Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz
步进：              6
CPU MHz：             800.000
CPU max MHz:           3400.0000
CPU min MHz:           800.0000
BogoMIPS：            5200.00
虚拟化：           VT-x
L1d 缓存：          48K
L1i 缓存：          32K
L2 缓存：           1280K
L3 缓存：           49152K
NUMA 节点0 CPU：    0-31,64-95
NUMA 节点1 CPU：    32-63,96-127

@KangkangStu Thanks for detailed information! I believe this is because your system is non-english. I will let you know after fixing this problem.

@ei-grad , should work after https://github.com/intel/neural-compressor/pull/1514 is merged. Please re-install neural compressor from source (https://github.com/intel/neural-compressor/blob/master/docs/source/installation_guide.md#install-from-source) and check. Let me know if you have any further problems!


The YouTube video on the Accessibility testing page does not work because it is marked as private

The YouTube video on the Accessibility testing page does not work because it is marked as private.  Here are the repro steps for this bug:
Repro Steps

Open Edge
Go to https://docs.microsoft.com/en-us/windows/apps/design/accessibility/accessibility-testing

Expected:
The YouTube video under the Run accessibility testing tools heading is shown.
What Actually Occurs
The screen says the video is marked as private.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7311500-9e32-4558-8108-728a9dfbff8a
Version Independent ID: c466a80f-93b9-b58b-317d-72217a17e5b6
Content: Accessibility testing - Windows apps
Content Source: hub/apps/design/accessibility/accessibility-testing.md
Product: reunion
Technology: design
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

@BenjaminEllett - thanks for letting us know about this. There appear to be a number of videos that have gone private recently. I've updated the link to a valid video for now. I'll update the overall topic as well.


Add reserving of IP range

Some users run OpenStack cloud for test purposes. For such they need "floating IPs". Having a way to reserve part of address space would be handy to not reuse same ones.

This has nothing to do with the provisioned HW, does not belong on this app.


feat(snacks): zen mode

Description
A bunch of new plugins:

animate: fast & efficient animations with 45 included easing functions (library)
scope: scope detection based on treesitter or indents (library)
indent: fast indent guides and scope highlighting

uses window-local extmarks (= decoration provider + ephemeral extmarks)

dim: better twilight.nvim (uses scope)

window-local extmarks

zen: better zen mode and integrates with toggle

zoom mode expands the current buffer like there would be no splits
exiting the zen/zoom window closes the zen/zoom window
when the zen/zoom window buffer changes, so does the buffer in the original window
Zoom with lua Snacks.zen.zoom()

Testing
return {
	{ "indent-blankline.nvim", enabled = false },
	{
		"snacks.nvim",
		opts = {
			indent = {},
		},
    -- stylua: ignore
    keys = {
      { "<leader>z", function() Snacks.zen() end, desc = "Toggle Zen Mode" },
      { "<leader>Z", function() Snacks.zen.zoom() end, desc = "Toggle Zoom" },
    },
	},
	{
		"snacks.nvim",
		opts = function()
			LazyVim.on_load("which-key.nvim", function()
				Snacks.toggle.indent():map("<leader>ug")
				Snacks.toggle.dim():map("<leader>uD")
			end)
		end,
	},
}

lua Snacks.zen.zen()

lua Snacks.zen.zen({backdrop = {transparent = false, blend = 70}})

Not sure if that's me having a very specific requirement for dimming but the defaults (using treesitter) look incorrect, I know it's not a bug, more like the treesitter for js/ts losing itself in complex multi-language files.
In this video I show how the defaults look like and then I disable the treesitter to demonstrate that the dimming look more like what one would expect:
https://github.com/user-attachments/assets/b11e814f-fae3-4db8-808d-4c8e3bdc5920
But it's still not perfect (apart from the fact that the treesitter is not disabled...)
I still think you should give an option for using to choose the dimming strategy:

treesitter (actually the default)
indentscope (how it behaves when the treesitter is disabled, dim only the code between the vertical bright indent line)
indentscope-cursor (same as indentscope but relative to cursor position)

In the following video, I use "indentscope-cursor" strategy (using mini-indentscope + twilight):
https://github.com/user-attachments/assets/976e5688-6848-4ac3-8a69-cd0c99ee976a
imho, at least treesitter and indentscope should be two options to choose from, to be able to dim the current indentation while retaining treesitter capabilities.

The whole dimming is highly configurable. There is no correct way of dimming.
Wait till I finished the docs.

btw, I'm reworking the whole scroll plugin, so better not to use it for now.

btw, I'm reworking the whole scroll plugin, so better not to use it for now.

When I tried to use it it wasn't working at all :smile:

The scroll plugin should work as it should now :)
It also properly deals with mousescroll. That's something I had to hack in mini.animate before in LAzyVim.
If you want to test the scroll plugin, make sure to disable mini.animate, or at least its scrolling module.
Would love to hear some feedback on this plugin, since it's pretty tricky to get it work under all circumstances.
It should pretty much work exactly the same now as if it would not be enabled. Things like scrolloff, mousescroll etc should all work correctly.

I've been using it since yesterday with default settings and the only problem I had found was the mouse scrolling. After latest pull this also works as expected. I just increased step to 20 for smoother transition for my own preferences. If I find anything weird I will report back.

Really like the scroll feature, and the default speed is good. I just had this problem, If I have
opts = {
  scroll = { enabled = false }
},
init = function()
  vim.api.nvim_create_autocmd("User", {
    pattern = "VeryLazy",
    callback = function()
      Snacks.toggle.scroll():map("<leader>uS")
    end,
  })
end

And restart nvim, the scroll feature is off as expected but but pressing <leader>u and I get this odd state:

iow, snack thinks the feature is on.. pressing S will disable it even though it's already disabled.

That's just disabling the plugin. The toggle for state checks the variable vim.g.snacks_scroll for the state. So, set that to false if you want it disabled by default and then it will get the correct state.

@dpetka2001 What I mean is that, isn't Snacks supposed to do this checking on startup and set the toggle accordingly whether the feature is on or off?

I understand yes but in the example I provided Snacks "thinks" it's activated. If the module is not loaded can it just set it to false by default?

You should just guard your mapping with
if LazyVim.opts("snacks.nvim").scroll ~= nil and LazyVim.opts("snacks.nvim").scroll.enabled ~= false then
  Snacks.toggle.scroll():map("<leader>uS")
end

That way your mapping will not be available when the scroll snack is not enabled. It can't read the state if the snack is not loaded.

@folke When using
terminal = {
  win = {
    position = "top" -- or any other value except "float"

lazygit will open in specified position:

LazyGit should always open afloat I think

Use this instead: styles = { terminal = { position = "top" } }.
Otherwise you are indeed overriding the options for all terminals, including lazygit.
lazygit has its own style you can change as well.

Last suggestion of the day:
when renaming a file, can the cursor be before the extension at start?

It's more rare to change extension of a file, and using arrow keys to go left when renaming (because there is no normal mode available in the input) does not feel right in vim.

Nope, vim.ui.input does not have a way to specify the position.

Too bad. That's a recent update? I haven't noticed when it changed but when I was using <leader>gc to rename objects in my code, the input had normal mode capability, could use h and l to travel inside the input, could even use gu or gU a selection. It was superior imo.

You'll be able to do that soon. Finishing my snacks.input plugin. Forgot I had most of that ready :)

I don't know if that's practical but I share this idea,
Snacks.toggle.dim():map('<leader>uD'):persist()

So the toggle will persist upon restarts.


"test exited without ending"

Hi!
Probabilistically, I get the following:
not ok 95 test exited without ending
  ---
    operator: fail
  ...
not ok 96 test exited without ending
  ---
    operator: fail
  ...

(more of the same)

    operator: fail
  ...
not ok 112 test exited without ending
  ---
    operator: fail
  ...
not ok 113 test exited without ending
  ---
    operator: fail
  ...

1..113
# tests 113
# pass  94
# fail  19

19 out of 20 runs are OK.
I am mostly annoyed by the fact I can not localize/attribute the error.

@gritzko Is this on Node, or in the browser?

This means your test did not call assert.end().
Probably a race condition in your own code.

I am seeing a similar issue. I have tests split across multiple files. When I run the tests using Istanbul
$  istanbul cover tape -- ./test/*.js

some runs all complete (no errors) and others return an operator: fail error due to test exited without ending. In my case, the failed test resides in the last test file.
The tests are all synchronous, so no async race conditions. And all tests explicitly call t.end().

Are you certain your tests are idempotent and that the state of some tests
aren't affecting the state of other tests?
What happens if you run the tests individually? Do they work every time? If
so, the issue could be state related.
On Tue, Dec 29, 2015 at 3:51 PM, Athan<EMAIL_ADDRESS>wrote:

I am seeing a similar issue. I have tests split across multiple files.
When I run the tests using Istanbul
$  istanbul cover tape -- ./test/*.js
some runs all complete (no errors) and others return an operator: fail
error due to test exited without ending. In my case, the failed test
resides in the last test file.
The tests are all synchronous, so no async race conditions. And all tests
explicitly call t.end().
—
Reply to this email directly or view it on GitHub
https://github.com/substack/tape/issues/223#issuecomment-167761436.

@joshrivers node, AFAIR
@kgryte yes, looks like my case, there was explicit t.end() and the case was synchronous
I switched to tap, so I can not provide any more feedback.

@Marak If I run each test file individually, the tests always pass. No tests share state.

@kgryte -
Can you describe the nature of the tests? If they are all synchronous tests I'm assuming they are performing no file-system or network based i/o? Or are they using synchronous file-system methods?
What I'm trying to ascertain is if you are accessing any shared resources across the tests which could be causing conflicting state.

The tests are of the variety:
test( 'awesome test', function ( t ) {
  t.ok( 5 === 5, 'numbers are equal' );
  t.end();
});

In the last file which occasionally fails, I added additional (synchronous) dummy test cases to see what happens. The result is that either all tests pass or all fail due to the test exited without ending error.

@kgryte - Maybe the issue is with istanbul?  What happens if you try using the tape test runner?

@Marak Here is a link to the tests. To run the tests with istanbul => make test-cov.

What happens if you change up this require statement:
https://github.com/kgryte/utils-copy-error/blob/master/test/test.ctors.js#L6
var CTORS;
Then inside the first test put:
CTORS = require( './../lib/ctors.js' );

Same result. Did the same for the test.js file. Tests only seem to be indeterminate for the last file (here, test.js).

@marak If I run the tests without istanbul, the tests pass; although, I cannot guarantee this is forever true, as I am not sure if tape has a race condition which is only apparent for longer load times (e.g., due to instrumentation).

@kgryte -
The thing is, I have some faith that tape is working right.
If the issue only comes up using istanbul, it might be in there, or it could be the structure of your tests.
Simple question, are you certain you are using the latest stable versions of all projects involved?

@marak Yes, I have the latest versions of all projects. So I did the following
# Instrument files beforehand and output to temporary directory...
$ istanbul instrument ./lib --output ./tmp

# Run the tests on the instrumented files...
$ tape ./test/*.js

I ran into the same issue. When tape runs over the instrumented code, I encounter occasional failed tests.

@kgryte - Did you try opening an issue in instanbul?

@marak I am not convinced that the issue is istanbul, especially now that I have used tape to run tests which directly require instrumented code in place of the raw files. In which case, istanbul is a non-factor as it is removed from the equation. I see the same probabilistic results.

@marak So, I put a console.log here https://github.com/substack/tape/blob/master/bin/tape#L31 . Here is what I see...
test/test.copy.js
test/test.ctors.js
TAP version 13
# file exports a function
ok 1 export is a function
# if not provided an error instance, the function throws an error
ok 2 throws when provided a string
ok 3 throws when provided a number
ok 4 throws when provided a object
ok 5 throws when provided a number
ok 6 throws when provided a undefined
ok 7 throws when provided a boolean
ok 8 throws when provided a object
ok 9 throws when provided a object
ok 10 throws when provided a function
# generic <Error> object
ok 11 separate instances
ok 12 instance of Error
ok 13 equal messages
ok 14 equal names
ok 15 equal stack trace
# <TypeError>
ok 16 separate instances
ok 17 instance of TypeError
ok 18 equal messages
ok 19 equal names
ok 20 equal stack trace
# <RangeError>
ok 21 separate instances
ok 22 instance of RangeError
ok 23 equal messages
ok 24 equal names
ok 25 equal stack trace
# <SyntaxError>
ok 26 separate instances
ok 27 instance of SyntaxError
ok 28 equal messages
ok 29 equal names
ok 30 equal stack trace
# <ReferenceError>
ok 31 separate instances
ok 32 instance of ReferenceError
ok 33 equal messages
ok 34 equal names
ok 35 equal stack trace
# <EvalError>
ok 36 separate instances
ok 37 instance of EvalError
ok 38 equal messages
ok 39 equal names
ok 40 equal stack trace
# <URIError>
ok 41 separate instances
ok 42 instance of URIError
ok 43 equal messages
ok 44 equal names
ok 45 equal stack trace
# error constructors are exposed via an exported object
ok 46 export is an object
test/test.js

Notice that the last file appears after the tests have run.

@marak The race condition belongs to tape on this one. I inserted a setTimeout statement into one of the other test files and now all tests always pass.
My running hypothesis is as follows: without the setTimeout, the first two files are loaded and completed in the same event loop before the third file is loaded. By the time tape is "ready" for the third file and has begun running the tests, tape prematurely ends pending tests and claims that they failed to exit without ending. By inserting, the setTimeout into one of the earlier files, earlier tests are pushed off to later event loops, allowing the third file to process and complete.

Similar issues have been created before: https://github.com/substack/tape/issues/160

Update: if I use t.plan() instead of using t.end(), the tests will always pass. So it seems like tape is prematurely ending tests before t.end() can be called.

@marak I added a console.log statement in the process.on( 'exit', clbk) handler https://github.com/substack/tape/blob/master/index.js#L80 . As can be seen from the logs below, the first two files are run and complete before the third file loads. The exit handler is called, thus causing the exitHarness to call t._exit() before the remaining tests have completed, and thus leading to failed tests.
test/test.copy.js
test/test.ctors.js
TAP version 13
# file exports a function
ok 1 export is a function
# if not provided an error instance, the function throws an error
ok 2 throws when provided a string
ok 3 throws when provided a number
ok 4 throws when provided a object
ok 5 throws when provided a number
ok 6 throws when provided a undefined
ok 7 throws when provided a boolean
ok 8 throws when provided a object
ok 9 throws when provided a object
ok 10 throws when provided a function
# generic <Error> object
ok 11 separate instances
ok 12 instance of Error
ok 13 equal messages
ok 14 equal names
ok 15 equal stack trace
# <TypeError>
ok 16 separate instances
ok 17 instance of TypeError
ok 18 equal messages
ok 19 equal names
ok 20 equal stack trace
# <RangeError>
ok 21 separate instances
ok 22 instance of RangeError
ok 23 equal messages
ok 24 equal names
ok 25 equal stack trace
# <SyntaxError>
ok 26 separate instances
ok 27 instance of SyntaxError
ok 28 equal messages
ok 29 equal names
ok 30 equal stack trace
# <ReferenceError>
ok 31 separate instances
ok 32 instance of ReferenceError
ok 33 equal messages
ok 34 equal names
ok 35 equal stack trace
# <EvalError>
ok 36 separate instances
ok 37 instance of EvalError
ok 38 equal messages
ok 39 equal names
ok 40 equal stack trace
# <URIError>
ok 41 separate instances
ok 42 instance of URIError
ok 43 equal messages
ok 44 equal names
ok 45 equal stack trace
# error constructors are exposed via an exported object
ok 46 export is an object
test/test.js
EXIT false
not ok 47 test exited without ending
  ---
    operator: fail
  ...

1..47
# tests 47
# pass  46
# fail  1

This does sound like a bug given the following conditions:

use tape binary and the globs
All tests are synchronous.

Looks the race condition is here: https://github.com/substack/tape/blob/master/bin/tape#L28-L34
We really should "resolve" all globs in parallel; and then loop over ALL the files once instead of doing multiple loops.
As a temporary workaround @kgryte can do tape "./test/*.js". By wrapping the expression in quotes bash wont expand them to all of the files.

@Raynos workaround works. All files are resolved before tests are run. Thanks.

@kgryte -
Thank you for the detailed bug report.
Also thanks to @Raynos for figuring it out!

@marak is there a patch forthcoming?

@kgryte Could you try with github:kl0tl/tape#fix/globby instead of tape ? It should work if @Raynos is right. I’ll open a PR if this fixes the issue.

@Kl0tl Based on my observations thus far, your patch seems to fix the issue. Thanks for the patch!

@Kl0tl would you mind opening up that PR? :-)

any news on a fix? Travis jobs failing randomly, requiring a restart is getting tiresome now..

Can you point me to a barebones test for this that I can run on my machine?
There's another solution. Note that the .only feature requires that all tests have loaded before the first test ever runs. We could modify the tape executable:
opts._.forEach(function (arg) {
    glob(arg, function (err, files) {
        files.forEach(function (file) {
            require(resolvePath(cwd, file));
        });
        tape.begin(); // NEW LINE
    });
});

This requires getting a reference to the tape module that the test files load. This can be done as follows within the executable:
var tape;
try {
    tape = require(resolveModule("tape", { basedir: cwd }));
}
catch(err) {
    tape = require("../"); // assume testing tape module itself
}

Instead of launching the run of tests using setImmediate(), tape.begin() would launch the first tick for running tests.

Is there an update on this? I have two test files now that fail when run using my test runner file. If I run the tests on their own they pass.
Here is the test runner file: https://github.com/grantcarthew/node-rethinkdb-job-queue/blob/master/tests/test-runner.js
Recent changes to my Queue.spec test are causing it to fail also.
Due to the test runner, I can't use the quote fix.
It is also possible I am doing something wrong.

I've just been using the new node --inspect debugger and can confirm my issues are related to this issue. process.on('exit'... is being called if I run multiple tests using the test runner.
It is possible node is exiting for some other reason than tape.

Tape globs through all the files asynchronously, loading each in turn. If the last to load runs before glob loads the next file, tape will report errors for any remaining tests.
I solve the problem by switching over to functionally-equivalent program called tap, which is well-documented at this site. The creator and CEO of NPM wrote and maintains tap. tap is also quite a bit more flexible.

@jtlapp tap also doesn't work in browsers, which is part of why tape was originally created.

@ljharb Any prospect of resolving issues in substack/tape#278, so that this can be fixed once and for all?

@kgryte if someone wants to build on top of that PR in order to complete it, that's fine with me

Couldn't you just run a setTimeout with a 10 minute delay (or higher),  then clearTimeout after the glob finishes?

Ok, so I gave tap a try. When running my tests using tap it reported errors in my tests I had not seen before. After fixing those errors the tests all ran perfectly. I switched back to tape and got the same error as before: 'test exited without ending'.
For now I am going to switch to using tap.
Thanks @jtlapp for the suggestion.
Keep up the good work here guys. I'll keep watching it.

And you might look at subtap for debugging tap tests.

Nice plug there @jtlapp  :)
I'll watch subtap also. Thanks.

Issue can be related to calling process.exit instead of actually closing the process down safety.
If you have any process.exit in tests, remove it. If the test isn't shutting down, try leaked-handles module to find open handler ( which needs to be closed for process to exit )
require('leaked-handles').set({
    fullStack: true, // use full stack traces
    timeout: 5000, // run every 30 seconds instead of 5.
    debugSockets: true // pretty print tcp thrown exceptions.
});

@ljharb @substack @Raynos -
I'm consistently getting errors and reports of errors from other developers trying to use the tape CLI to run multiple tests at once. Seems to be a race condition / timing issue. Could be due to user errors in the test code, but that's unavoidable.
If we switch to the tap binary on the same glob of tests, everything just works. Let me know if you have any idea or solution outside of dropping tape CLI for tap.

@Marak can you elaborate on "at once"? One of the primary benefits of tape over tap is that it's lightweight and can also run in a browser. If those aren't concerns, and encouraging bad code to be written properly isn't an option, I think switching libs might make sense.

@ljharb
I mean to say when running tests with globs like tape test/*.js. I tried the recommendation of running  tape "test/*.js", but that didn't help either.
It's just odd to me that these two commands are yielding much different test results:
 tape test/*.js
 tap test/*.js

Noted about primary benefits of tap versus tape and might choose to use tap for our server-side testing.

I believe in that case tap may run each file in its own process, whereas tape runs them all in the same one? Just guessing tho.
Personally I usually node test/index.js and explicitly require in all my test files, so I don't use the tape binary at all - and never run into this problem. It might be something fixable in that tape binary code, perhaps.

@ljharb -
Are you saying that you require all your test files in one index.js file like found here: https://github.com/ljharb/object-keys/blob/master/test/index.js ?
One of our developers wanted to do the same and I'm not sure that would scale well for a project with many suites. Going to switch to tap here and see if it helps. Process-per-test seems fairly important, and makes sense why tap is doing better than tape for these server tests.

@Marak yes, precisely that. My general sense is that when that doesn't scale, the project is too large, and thus must be split into smaller projects in their own repos.

i'm pretty sure i've been fighting this issue all day. here's a barebones test that'll show it up:
const test = require('tape').test;

function _test(identifier) {
	console.log(`starting test ${identifier}`);
	test(`_test ${identifier}`, assert => {
		assert.true(true);
	});
}

function _runAsyncTests() {
	setTimeout(_test, 1000, `A`);
	setTimeout(_test, 3000, `B`);
}

_runAsyncTests();

here's the output:
Debugger listening on [::]:64845
starting test A
TAP version 13
# _test A
ok 1 should be truthy
starting test B
not ok 2 test exited without ending
  ---
    operator: fail
  ...
not ok 3 test exited without ending
  ---
    operator: fail
  ...

1..3
# tests 3
# pass  1
# fail  2

npm ERR! Test failed.  See above for more details.

Process finished with exit code 1

i've traced it through into tape with the debugger. node is trying to exit before the last test has been scheduled.

@simonhac I trust that you realize that if you added an assert.plan(1) at the beginning or assert.done() at the end, that it would all work perfectly?

thanks @ljharb -- do you mean that i should change my code to the following?
const test = require('tape').test;

function _test(identifier) {
	test(`_test ${identifier}`, assert => {
		assert.plan(1)
		assert.true(true);
		assert.end();
	});
}

function _runAsyncTests() {
	setTimeout(_test, 1000, `A`);
	setTimeout(_test, 3000, `B`);
}

unfortunately, that still fails:
TAP version 13
# _test A
ok 1 should be truthy
not ok 2 test exited without ending
  ---
    operator: fail
  ...

1..2
# tests 2
# pass  1
# fail  1

but i've worked out why -- will post in next comment.

ok, i think i've worked this out.
as soon as the list of executing tests is empty tape starts to shut down. any test 'scheduled' after the list becomes empty will generate a test exited without ending failure.
check out this simple example:
const test = require('tape').test;

function _test(name) {
	test(`test ${name}`, t => {
		t.plan(1);
		t.pass(name);
		t.end();
	});
}

_test(`huey`);
_test(`dewey`);

setTimeout(function () {
	_test(`louie`);
}, 100);

the runtime gets to the bottom of the script before the deferred task to schedule the 'louie' test is executed, and we get the following failing test report:
TAP version 13
# test huey
ok 1 huey
# test dewey
ok 2 dewey
not ok 3 test exited without ending
  ---
    operator: fail
  ...

1..3
# tests 3
# pass  2
# fail  1

if i add the following statement to the bottom it works just fine!
test(`afterTests`, t => {
	setTimeout(function () {
		t.end();
	}, 1000);
});

it is not immediately intuitive to the casual reader why this might make it work, but this supports my theory above. it would be nicer if tape didn't exit until the script and all deferred tasks had executed.
ps. you may ask why i have delayed tests -- i have a test harness that generates tests only once it has asynchronously read in a file. i can code around this (by loading the file in a dummy test at the top of the script), but i thought it was worth explaining what i found because it looks like this issue frequently bites others.

Because you want var test = require('tape'), and to invoke that.

@ljharb i didn't think there was a difference between:
const test = require('tape').test;

and:
let test = require('tape');

i've tried your suggestion, and it still fails. does it work for you?

.plan(count) is how tape supports asynchronous tests. Without this, no test could be known to have finished until the program exits; but then at exit tape won't know whether all the intended tests actually ran. Besides, it's not clear that all test output could be generated during the exit process.

Tests must all be scheduled synchronously - for your use case I'd recommend wrapping the entire file in a single test call so that tape knows to wait.

thanks @jtlapp my example above does use .plan(count).
@ljharb, thanks for your response:

Tests must all be scheduled synchronously

i asynchronously schedule tests when use data driven test suites. i've found that this works so long as the scheduling is done within a synchronously initiated 'dummy' test. ie. your suggestion of wrapping the test scheduler in a good workaround.
from searching the issues in this project, it looks like this problem has caught quite a few and is difficult to track down. (with async calls there's always the chance of non-determinism.) i'd suggest the following:

update documentation to prominently explain the issue and the work around, or
modify tape so that it doesn't exit until all tests have completed, or failing that,
modify tape to fail any test that's scheduled asynchronously when there are no running tests.

the second option is my preferred.

I was trying to explain why your options 2 and 3 are not possible.

thanks @jtlapp -- i don't understand why options 2 & 3 are not possible. at least with option 3, couldn't tape detect that it has already exited and print out an explanation for failing the async'ly scheduled test?
the current behaviour feels obscure for someone not into the implementation details.

I just tried to write a lengthy explanation and found you correct and myself incorrect, @simonhac. I was actually defending tap's behavior, not tape's behavior. (I stopped using tape a while ago.) tap hangs until the test completes, which I find more reasonable, since you never know if a SIGINT or something is supposed to fire out of the blue to complete the test. It also ensures that tests run sequentially, should each be setting up and tearing down the same database or directory -- no test is done until the plan count is reached or end() is called.
I'm now siding with you, @simonhac. This appears to be another artifact of tape's attempt to support a test runner that can run multiple test files simultaneously. (The tape command can complete running a test suite before all the tests have run, because the program will exit if all loaded tests have finished, even if all test files have not yet been loaded.)

I think I'm having this problem as well.
tape "*.test.js" "lib/*.test.js"

Every few times I run it, some of the tests don't run and it says some tests exited without ending. I need the multiple globs to avoid running tests under node_modules. Is there another way?

Try replacing glob with glob.sync at this line.
Change from...
glob(arg, function (err, files) {
    files.forEach(function (file) {
        require(resolvePath(cwd, file));
    });
});

...to...
glob.sync(arg).forEach(function(files) {
    files.forEach(function (file) {
        require(resolvePath(cwd, file));
    });
});

(I just threw that together now, so there may be a bug in there.)

Close! This did the trick:
    glob.sync(arg).forEach(function(file) {
        require(resolvePath(cwd, file));
    });
``

So... should that be a PR? I don't know what else that might affect.

It'll slow down test suites that do manage to run in parallel.

PR to fix this issue: https://github.com/substack/tape/pull/374


Simplify gift taste lists

The gift tastes list for an NPC can be pretty overwhelming:

Use the following rules to simplify it:

For an item:

If everyone likes an item (with up to 2 exceptions), say "everyone" or "everyone (except A and B)" instead of listing them. For example: everyone (except Abigail and Harvey).

For an NPC:

If an NPC likes an entire category (with up to 3 exceptions), say "all " or "all  (except A and B)" instead of listing the items. For example: all crops (except parsnips).

I would like this to be a separate mode you can enable. My reason for this, is I've made it so that owned items are in green text, which suits my needs better than this feature suggestion.

Ooh, that sounds useful. Would you be willing to submit a pull request for that?

Done via pull request #36, merged into develop for the upcoming 1.9 release.
I also revamped custom field rendering so formatting support is built-in (so the lookup menu is simpler and more robust), and further extended this to highlight carried items:

Oh wow, that's pretty cool and much better than what I did. Did I spark this idea? lol Cause that makes me glad I contributed.

Yep. Thanks! 👍


Add clock bindings to org agenda

I don't feel strongly about any of these bindings. Feel free to tweak them as you wish.

Thanks again for your help!


SimplifyCFG: limit the number of jump threading through a basic block.

So far we did this only for loop headers, but there are cases where we need it for all blocks to prevent infinite loops in SimplifyCFG.
rdar://problem/34576609

@swift-ci smoke test and merge


feat(ingest/presto-on-hive): Extracting all the table properties from Hive Metastore

Extracting all the table properties from Hive Metastore  and not just the description

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es looks like there's a bunch of conflicts on this PR


io.openim:client-sdk:1.4.4@aar CAN NOT FOUND

GOT ERROR WHEN I TRY TO RUN DEMO

What went wrong:
Could not determine the dependencies of task ':app:processDebugResources'.

Could not resolve all task dependencies for configuration ':app:debugRuntimeClasspath'.
Could not resolve io.openim:client-sdk:1.4.4.
Required by:
project :app > project :flutter_openim_sdk
Could not resolve io.openim:client-sdk:1.4.4.
Could not get resource 'https://dl.bintray.com/aweme-open-sdk-team/public/io/openim/client-sdk/1.4.4/client-sdk-1.4.4.pom'.
Could not GET 'https://dl.bintray.com/aweme-open-sdk-team/public/io/openim/client-sdk/1.4.4/client-sdk-1.4.4.pom'. Received status code 502 from server: Bad Gateway

GOT ERROR WHEN I TRY TO RUN DEMO

What went wrong:
Could not determine the dependencies of task ':app:processDebugResources'.

Could not resolve all task dependencies for configuration ':app:debugRuntimeClasspath'.
Could not resolve io.openim:client-sdk:1.4.4.
Required by:
project :app > project :flutter_openim_sdk

Could not resolve io.openim:client-sdk:1.4.4.
Could not get resource 'https://dl.bintray.com/aweme-open-sdk-team/public/io/openim/client-sdk/1.4.4/client-sdk-1.4.4.pom'.
Could not GET 'https://dl.bintray.com/aweme-open-sdk-team/public/io/openim/client-sdk/1.4.4/client-sdk-1.4.4.pom'. Received status code 502 from server: Bad Gateway

gradle配置或版本的问题

  maven {
            allowInsecureProtocol = true
            url 'http://<IP_ADDRESS>:8081/repository/maven-releases'
        }


Replace CRC32 with BLAKE3  Hash Function

Description
This pull request updates the hashing method for the ResourceId struct, replacing CRC32 with BLAKE3 hash function.
Related Issue: #65
Changes
The changes include:

Addition of benchmarks for the ResourceId::compute_bytes method using the criterion crate with the html_reports feature enabled. Run cargo bench to generate benchmarks in the /target/criterion folder
Removing collision handling as BLAKE3 is a cryptographic hash function

Refer to individual commit messages and bodies for detailed information

Let's finish the benchmarks first:

#74

After we have index benchmark, we'll be able to judge better about performance penalty of Blake3. Collision tracking, necessary for CRC32, could eat some performance up, too.

This PR should be rewritten when https://github.com/ARK-Builders/arklib/pull/90 is merged here and into ark-rust as well.
I can re rewrite the logic in ark-rust directly so that it implements ResourceIdTrait

Closing this in favor of https://github.com/ARK-Builders/ark-rust/pull/32


Define Access Management process for Operate First migrated services

see also https://github.com/os-climate/os_c_data_commons/issues/270

How do we give permissions to ArgoCD, Vault, etc.  for administration or otherwise?  Plus grant of permissions for various apps. [Establish groups for this purpose - admin,] - leverage openshift with namespace admin capabilities to control app admin level permissions.  @ryanaslett to move forward with global admin process.

ArgoCD is managed thru openshift groups - we will keep this structure for now until keycloak is established for lower level access.

@MightyNerdEric to talk to @redmikhail on setting up / defining access for hash corp vault

Vault is set up and admin permissions granted.  But don't have a process documented.  Once keycloak is installed - remap permissions from github to keycloak.  Blocked until install complete.


Is IP the correct abbreviation for Identity Provider

According to Wikipedia https://en.wikipedia.org/wiki/Identity_provider identity provider abbreviated as IdP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 01f91bc6-9650-142c-49c4-a40ad8a7aeee
Version Independent ID: d902aad7-681f-5f05-426e-10385f2ab7af
Content: Claims-Based Identity Model
Content Source: docs/framework/security/claims-based-identity-model.md
Product: dotnet-framework
GitHub Login: @BrucePerlerMS
Microsoft Alias: dotnetcontent

I don't think so. I would just remove the abbreviation, it's not really saving any space in those three bullet points.


Review changes to code base

What does this PR do?
Implements LFA feedback on code base.
Description of Task to be completed?
Add new line spaces.
Add JsDoc comment and rules.
Change double quotes to single quotes.
Use an || operator instead of && operator to validate for both title and description.
How should this be manually tested?

Clone the repo using git clone https://github.com/fejiroofficial/stackOverflow-lite.git.

run git checkout deploy

run npm install and npm start.

To test for error

npm test

Pull Request Test Coverage Report for Build 66

18 of 18 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.4%) to 97.0%

Totals

Change from base Build 34:
3.4%

Covered Lines:
79

Relevant Lines:
80

💛  - Coveralls


Move autorest client to java sdk central repo

First, move the entire package without changes.
This commit is to finish the first step.
Then, we will cleanup the pom file, spotbugs and checkstyle.
Last, we will run the live tests.

Need to pull the recent changes before Pull request


feat: provide remote IP address to external auth script

Summary
This PR provides the remote client IP address to the auth script under the --remote-ip flag.
The auth script can use this to track abuse and apply rate-limiting using external mechanisms.

I can't review this but this looks perfectly fine to me.


WPS button appears in another interface

The button is enabled in the guest interface (Invitados), but appears in the WDS interface.

@castillofrancodamian I need some info to fix this.
Can you confirm that you have WPS disabled on all the other interface?

@Ansuel So is. Only enabled in guests.


Get Senders

Hello! I'm trying to get availible senders. But I didn't found solution fot it. Thank you in advance)

At the moment that API isn't available in this Python wrapper, but it wouldn't be difficult to add

Hi there, would love to see if this Spout Senders Discovery feature could be implemented. Any pointer would be appreciated, thanks!

I added getSenderList() and a couple other APIs related to listing senders. Let me know if there's anything else needed?
https://github.com/jlai/Python-SpoutGL/releases/tag/v0.1.0

Wow that was fast thank you so much! This will be useful to the blender texture streaming addon, for spout texture sharing. I'll tell the maintainer about these added API.


Firewalld issue

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Once we deploy the microservices within podman with selinux and firewalld (both activated)...services start not responding requests properly. If you connect to the container and try to ping, dig any internal or external domain, any action to verify the connection, the pod is not able no do nothing, if we restart the pod but first with firewalld and selinux disabled...everything is ok and all back to normality.
Steps to reproduce the issue:

Activate Firewalld

Deploy two containers:
podman run --name nginx01 -d -p 8080:80 nginx
podman run --name nginx02 -d -p 8081:80 nginx

Stop firewalld

Try to make internal DNS query or external such as google or something...

Describe the results you received:
root@4d01a46cd8c7:/# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
From <IP_ADDRESS> icmp_seq=10 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=11 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=12 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=13 Destination Host Unreachable
root@8d9d9097cc6e:/app# ping subdomain.domain.com
ping: subdomain.domain.com: Temporary failure in name resolution
When the microservice try to connec to SQL Server:
SqlExceptionHelper","message":"The connection attempt failed."
Describe the results you expected:

The possibility to make dns querys and connect to other services such as sql

Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
podman version 1.4.4

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.10.3
  podman version: 1.4.4
host:
  BuildahVersion: 1.9.0
  Conmon:
    package: podman-1.4.4-4.el7.centos.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 0.3.0, commit: unknown'
  Distribution:
    distribution: '"centos"'
    version: "7"
  MemFree: 553943040
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    package: runc-1.0.0-65.rc8.el7.centos.x86_64
    path: /usr/bin/runc
    version: 'runc version spec: 1.0.1-dev'
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  hostname: test-podman-01
  kernel: 3.10.0-1062.1.1.el7.x86_64
  os: linux
  rootless: false
  uptime: 594h 16m 31.05s (Approximately 24.75 days)
registries:
  blocked: null
  insecure:
  - 172.16.x.x:8087
  - 172.16.x.x:8089
  search:
  - registry.internaldomain.com
  - registry.access.redhat.com
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.centos.org
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 16
  GraphDriverName: overlay
  GraphOptions: null
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 16
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.4.4-4.el7.centos.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):

@mheon PTAL

I don't think this is an SELinux issue, but I am willing to be proven wrong?  If you put the machine in permissive mode, does it still fail with the file wall rules up?
Are there any AVC messages in the audit.log.
This issue looks a lot like a firewall rules.
From the podman info this looks like it is happening with root.
BTW There should be a newer version of podman available for centos.

check out it's not the same I had a while back, confusion between iptables and firewalld: https://github.com/containers/libpod/issues/5335

I have updated the main issue with more information and also the title, this issues is focused in firewalld.
I've talked yesterday with @mheon and he asked me to do some tests and here's the output:
[root@test-podman-01 ~]# podman exec -it nginx02 bash
Error: cannot exec into container that is not running: container state improper
`[root@test-podman-01 ~]# iptables -nvL
Chain INPUT (policy ACCEPT 256 packets, 18390 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain FORWARD (policy ACCEPT 16 packets, 920 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain OUTPUT (policy ACCEPT 153 packets, 17604 bytes)
pkts bytes target     prot opt in     out     source               destination`
`[root@test-podman-01 ~]# iptables -t nat -nvL
Chain PREROUTING (policy ACCEPT 20 packets, 1262 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain INPUT (policy ACCEPT 12 packets, 802 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain OUTPUT (policy ACCEPT 9 packets, 2232 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain POSTROUTING (policy ACCEPT 17 packets, 2692 bytes)
pkts bytes target     prot opt in     out     source               destination
`

I have found this links about the same issue in the same env:
https://github.com/containers/libpod/issues/348
https://github.com/containers/libpod/pull/1431#issuecomment-579939112

I feel like we may have fixed this on master, but I'm not precisely sure as to when...
@JuSt19 There's a Centos virt-sig repo that distributes more up-to-date Podman packages; would you be willing to give those a shot and see if a more recent version is fixed? @lsm5 where did that repo live, again?

@mheon that's perfect for me, could you please share to me this repo and then i'll test if it's already fixed.
Awaiting!

I feel like we may have fixed this on master, but I'm not precisely sure as to when...
@JuSt19 There's a Centos virt-sig repo that distributes more up-to-date Podman packages; would you be willing to give those a shot and see if a more recent version is fixed? @lsm5 where did that repo live, again?

I don't maintain the virt-sig repo anymore. All non-fedora and non-rhel is on OBS now. 1.8.2 should be available for centos 7 via the OBS stable repo. See the Kubic project section under CentOS at https://podman.io/getting-started/installation for installation instructions

I feel like we may have fixed this on master, but I'm not precisely sure as to when...
@JuSt19 There's a Centos virt-sig repo that distributes more up-to-date Podman packages; would you be willing to give those a shot and see if a more recent version is fixed? @lsm5 where did that repo live, again?

I don't maintain the virt-sig repo anymore. All non-fedora and non-rhel is on OBS now. 1.8.2 should be available for centos 7 via the OBS stable repo. See the Kubic project section under CentOS at https://podman.io/getting-started/installation for installation instructions

Still failing after update to 1.8.2 and doing the same thing to reproduce the same with the old version.

Hello, is there any progress on this? I am experiencing the same issue on CentOS 8. When firewall is enabled. Basically name resolution does not work whereas routing works fine when using Its directly.

@mccv1r0 Any thoughts on this one?

This may be related to #5335. I am currently not using the kubic repos but with the version provided in AppStream repos for CentOS 8
podman-1.6.4-2.module_el8.1.0+272+3e64ee36.src.rpm
a wrong CNI configuration is created containing iptables as backend for the firewall plugin.
This is easy to reproduce using:
$ podman network create newnetwork
$ podman network inspect newnetwork | grep backend
				"backend": "iptables",

this is a known issue and is fixed upstream ... both the network create code and default cni config

any chance getting this into the releases shipped with the base/appstream repos on rhel?

Is it fixed in podman-1.16.4?  Which should be released in rhel8.2 release.

We will release podman-1.9.* in RHEL8.2.1 in the summer time.

Looking forward to see this and hopefully dnsmasq plugin in the next release. Meanwhile I can workaround this by myself.
Thanks a lot.

Can you confirm whether there is a firewall block in the base network we ship (87-podman-bridge.conflist)?

For podman-1.6.4-2.module_el8.1.0+272+3e64ee36.src.rpm there is the following block:
        {
            "type": "firewall",
            "backend": "iptables"
        }

Alright. So we are at least shipping a vaguely working config, here.

@mheon Is this still an issue with the upstream?

This should be fixed on upstream CNI configs.


Updates to Getting Started, Jupyter & Python pages

Docs Build status updates of commit ccd8081:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/quantum-docs-pr, working directory: W:\xddl-s, target branch: master, target branch commit: 893874a97d8856f0b8c57546c58d7aa6f7cc8678, source commit: ccd8081e91e653f951bb1b1881e2785f5c9f886f.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9f10f68:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3d3a4a5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit f29cb46:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3aa9f0a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 898bbba:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3ac703c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ddb60fb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/install-guide/index.md
:warning:Warning

Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit fd5e3a6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/relnotes/index.md
:warning:Warning

Details

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md

Line 15: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.
Line 111: [Warning] Illegal link: `<a href="install-guide/index.md#updating-iq">these instructions</a>` -- missing bookmark. The file install-guide/index.md doesn't contain a bookmark named updating-iq.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ffea3b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How do drivers decide the ethX name?

Currently it is expected that driver.CreateEndpoint() returns back the sandbox.info structure that needs to include ip, gateway, veth_inside and veth_outside information. (Where veth_inside is "The name that will be assigned to the interface once moved inside a network namespace.")
As I see it, the driver cannot return back that information because it does not know how many other endpoints will be added to the container in question. What is the thought process of the designers here?

@shettyg Was busy integrating libnetwork with docker hence the delay in answering some of your earlier questions. Getting back to this question, the interface SrcName, DstName being present as part of the return value of the CreateEndpoint is an artifact of an earlier design where endpoint was a local resource and a container joined it during CreateEndpoint. With the goal of Endpoint being a service abstraction and hence a universal resource, it makes no more sense to keep interface names as part of information returned during CreateEndpoint. The IP addresses still will remain as part of CreateEndpont info. But expect a few adjustments in what needs to be returned during endpoint create and join which will hopefully clarify all these question. I will probably push a PR tomorrow to fix this. Please take a look and comment.

@mrjana Any update on this? This sounds like quite a significant change to the API. If you're not ready to push code for it, could you at least update the design doc (on a branch)?

@tomdee I am getting back to working on this. Our first priority was settle down the libnetwork northbound apis so that we can get it integrated with docker core for which we have a PR in progress. It should probably not be that much of a change in driver API other than only IP addresses required to be returned during CreateEndpoint and everything else during Join. I will try to push a PR today and update the doc. If not I will try to see if we can send a doc update PR.

@mrjana Thanks for the quick response. That all sounds good.

Is this (or rather, the analogous problem with Join) addressed by #193, which changed the meaning of DstName to be a prefix to which libnetwork appends an index?

@squaremo Yes, and I think we should close this issue


Implement async threadpool

The coroutine primitive is running concurrently -- for now. It would be ideal to implement a parallel threadpool to schedule event processing in parallel. That would allow us to run much more complex workflows efficiently, and probably get better performance.
See e.g. https://github.com/lewissbaker/cppcoro#async_generatort

Very interesting! A million years ago I put together a simple threadpool that had some nice features (such as dynamic resizing). I have been thinking about refactoring it to take advantage of coroutines. One feature that might be beneficial here is that it is a header-only library (and I would like to keep it that way if possible). I'd be happy to work on it if you think it might be useful!

All very good points. I am not very well versed in the art of measuring performance in a multi-threaded environment, but I am keen to learn. At any rate, I think that a generic coroutine-based threadpool would be immensely useful anyway for all sorts of scenarios, so maybe we could keep them as separate projects and include the threadpool as a git submodule (should be trivial, especially if it's a header-only library).
Let's schedule a dedicated call about this!

I think that a generic coroutine-based threadpool would be immensely useful anyway for all sorts of scenarios, so maybe we could keep them as separate projects and include the threadpool as a git submodule (should be trivial, especially if it's a header-only library).

I think that's a great idea. The current implementation also uses a type parameter, so it should generalize well. Unfortunately, I have to be honest and say that I won't have much time to invest in developing a generic library. But I would love to provide input, feedback, and integrate it into AEStream.

No worries, that would be a good incentive for me to dust off the old code. It would probably still make sense to chat briefly about what features you expect from the threadpool so I can make sure to implement them.


Enable all tests in CI

WHAT
WHY
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

Tests only - landing.


RFP - SkyMPC

SkyMPC is a simple MPD (Music Player Daemon) client, powered by Qt5.
http://www.soramimi.jp/skympc/

Meh...
cantata is alraedy available

Status: Review
https://chocolatey.org/packages/skympc

Status: Published

https://chocolatey.org/packages/skympc

Can be closed.


[WIP] Add more training data

This PR provides:

additional training data for full-text and segmentation
new models for full-text and segmentation, trained with all available data
end 2 end evaluation using both PMC and bioxiv

@kermitt2 At this stage, I'm looking for feedback on the added training data. We could continue to iterate over this PR before merging it until we reach a satisfying improvement.
I'm setting this as a draft for the time being.

In fact, I just realised that by creating this training data with mac there are some missing numbers... therefore I will correct these files again

Coverage decreased (-0.05%) to 38.223% when pulling 4fdb92c9e7a085f80fbfca1fc6f8fcd45bf2a6f5 on feature/add-training-data into 506c00afad2bfc93d8b8820857b1c3756cab7cad on master.

Coverage decreased (-0.05%) to 38.223% when pulling 3d8876b299bc8af0cb12189e4be315c218221be3 on feature/add-training-data into 506c00afad2bfc93d8b8820857b1c3756cab7cad on master.

Adding the bioxriv fulltext data indeed improved the results on the e2e both bioxirv and pmc.
Compared with the last official result from Patrice (PMC_sample_1943.results.grobid-0.6.2-SNAPSHOT-Glutton-DeLFT-WAPITI-MIXED-SciBERT-31.10.2020) we've got:

soft matching from 65.45 to 68.28 micro avg F1 score
strict matching from 60.25 to 65.13 micro avg F1 score

I close this as it's obsolete


Investigate migration of external endpoints when upgrading to 2.0

Is your feature request related to a problem? Please describe.
When changing to 2.0 image Portainer won't start due to the --external-endpoints flag being removed. Removal of this flag will lead to Portainer starting, but endpoints will still show in the UI and won't be usable, and need to be re-added. Leading to the loss of accesses if any are set.
Describe the solution you'd like
Migrate the external endpoints so they are usable.
Describe alternatives you've considered
Delete them if they cannot be migrated.

This one is on my radar. :)  We currently use --external-endpoints, so a combination of this issue, and trying to figure out the best route to automatically add the local Docker host (/var/run/docker.sock)on fresh install, have kept us from migrating to 2.x currently.  In our case I don't mind nuking all the Portainer config and starting fresh as long as I have some automated route to add the local Docker host again, but I imagine others use the external endpoints in a much larger way.

@Codelica have you tried to use the -H unix:///var/run/docker.sock command when deploying Portainer? This will automatically add the local Docker environment as the local endpoint in the Portainer instance.

I actually just did and got the "primary" endpoint added successfully.   What just trying to think through how to deploy for existing installs now, which used --external-endpoints previously.  I can obviously dump the command argument and file, but am thinking it would be best to clear out the existing endpoint from that as well -- hopefully without tossing all the existing portainer config.  So I was looking to the API.

We do have some examples on our documentation website on how to use the Portainer API to create endpoint: https://documentation.portainer.io/v2.0/endpoints/api/
Might be of use to you.

Thanks.. found the API docs on Swaggerhub.  I think I see the route.  Thanks again.

An observation and an a question...
It looks like 1.x endpoints we have set (which are all local Docker sockets) all have a Type set to 0 and, as this issue says, are not functional in 2.x.   Newly created endpoints in 2.x (via -H to a local Docker socket in our case) seem to have a Type set to 1 which appears to be correct per the docs:

Environment type. Value must be one of: 1 (Local Docker environment), 2 (Agent environment), 3 (Azure environment), 4 (Edge agent environment) or 5 (Local Kubernetes Environment)

Total guess, but perhaps a Type migration is the hangup here.
Question re: the -H argument.  It appears that only creates the endpoint if there are no endpoints defined yet.  Is that the case?
Thanks..

We did not investigate the potential migration of the externally defined endpoints yet.

Question re: the -H argument. It appears that only creates the endpoint if there are no endpoints defined yet. Is that the case?

Yes, it is meant to be used when deploying Portainer for the first time.

I just ran into the same issue. It looks like it's simply an enum type flag or something similar. I have a bunch of stacks in my old endpoint, but I can't get to them. :/

The image shows that it doesn't have the endpoint type set like it should.
Is there some SQL I can run or something to migrate the old endpoint?