HBASE-24211: Create table is slow in large cluster when AccessController is enabled.

HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Previous PR for this issue is https://github.com/apache/hbase/pull/1546. Changes were merged and reverted back. Submitting few more changes on top of the previous changes.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

49m 38s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux ec68adfa0214 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4f9eecbe61

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 53s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-zookeeper in the patch failed.

-0 :warning:
javadoc
0m 43s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-zookeeper in the patch passed.

-1 :x:
unit
139m 27s
hbase-server in the patch failed.

173m 13s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2572b95b8bab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4f9eecbe61

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/testReport/

Max. process+thread count
3971 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
5m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
5m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
189m 30s
hbase-server in the patch passed.

216m 29s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5f4d9238af5c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4f9eecbe61

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/testReport/

Max. process+thread count
3235 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Could you please check the failed test result locally?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 56s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
checkstyle
1m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

38m 30s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux af708957f6be 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d59e328c8

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 22s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-zookeeper in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
195m 27s
hbase-server in the patch passed.

224m 56s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3cbe928f6db7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d59e328c8

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/testReport/

Max. process+thread count
2861 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
1m 18s
master passed

+1 :green_heart:
shadedjars
5m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 54s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
5m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
205m 10s
hbase-server in the patch passed.

233m 34s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1631

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 278c468cb78b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d59e328c8

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/testReport/

Max. process+thread count
3377 (vs. ulimit of 12500)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Created PR for branch-1
https://github.com/apache/hbase/pull/1658


Error when uploading to s3 presigned urls

Problem description
I get an error trying to write to an s3 presigned url using smart_open.
Steps/code to reproduce the problem
Create a presigned s3 url:
   s3 = boto3.client('s3')
    s3_url = s3.generate_presigned_post(
        s3_bucket,
        s3_key,
        ExpiresIn=604800
    )

Try to write something to it:
with open(s3_url, 'wb') as fout:
    fout.write(content)

Error:
TypeError: don't know how to handle uri {'url': 'https://s3_bucket.s3.amazonaws.com/', 'fields': {'key': 's3_key', 'AWSAccessKeyId': 'xxxxxxxxxxxxxxxxxxxxxx', 'policy': 'yyyyyyyyyyyyyy', 'signature': 'zzzzzzzzzzz'}}

Versions
Python version: 3.8

This isn't a use case that we currently support. I'm not sure where to implement support for it, either. It's not really an S3-specific thing - you're expecting to do a simple HTTP POST, right?

@snabar I'm thinking of a reason to implement this, but I'm unsure if it's worth it. What's the benefit of writing via HTTP POST instead of going via boto3? In other words, instead of this:
s3 = boto3.client('s3')
post_params_dict = s3.generate_presigned_post(s3_bucket, s3_key, ExpiresIn=604800)
smart_open.open(post_params_dict, ...)

why not just do this:
smart_open.open('s3://%s/%s' % (s3_bucket, s3_key), ...)

What is your use case?


Remove deploying detection logic from drift detector

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

/lgtm

🚀
/approve

🚀
/approve


Add support for CORS origins

Web client apps, such as the InitializrWeb project, may need to forward requests to API server while honoring CORS policies.
see: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
The InitializrApi needs to set the Access-Control-Allow-Origin header so that client can access its resources.

We want to be able to lock this down just to our client.


Please help me with my Apache log

Hi,
I just can't get it run with my Apache log I downloaded. Can somebody help me with the right format? This is an example line:
<IP_ADDRESS> www.mydomain.com - [05/May/2019:11:24:32 +0200] "POST /path/index.php?api-call=test HTTP/2.0" 503 299 "https://www.mydomain.com/path/index.php?page=demo" "Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36" 61 299

Could you please describe what are the last two fields? Thanks.

Hey... I asked the hosting provider and he sent me the log file format config:
"%v:#:%h %l %u %t "%r" %>s %b "%{Referer}i" "%{User-agent}i"
%I %O"
I guess this is something with I/O ... and btw this is probably the same string or at least parts to use for goAccess settings, right?

I tried the following. But I always get this Token '././.' doesn't match specifier '%d'. I am on Mac/Mojave - any known issues here? I also tried '%d/%b/%Y' (in quotation marks)... same thing.
goaccess access.log --log-format='%h %U %^ [%d:%t %^] "$m %q %^" %s %b "%R" "%u" %^ %^' --date-format=%d/%b/%Y --time-format=%T
Parsed 1 linesproducing the following errors:

Token '05/May/2019' doesn't match specifier '%d'

Format Errors - Verify your log/date/time format

Hey... found it... the local setting (German) was the reason. Entering
export LANG="en_US.UTF-8"
before you call GoAccess does the job. Is there a need to reset it after to the German setting? Or is this just a temporarily set for the current terminal session?

Closing this, feel free to reopen it if needed.


Fabric: some options look broken

Versions

lootr <IP_ADDRESS>
cloth-config 8.2.88
modmenu 4.0.6
fabric-api 0.64.0+1.19.2
minecraft 1.19.2

Issues
Some options do not look right (translation string is missing). Unsure if toggling the options has an effect or not.
Some matching errors appear in the log when interacting with the config screen.
Visual

Log
[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.DECAY_MODS'!
[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.DECAY_TABLES'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.REFRESH_MODS'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.REFRESH_TABLES'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.DIM_WHITELIST'!
[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.DIM_BLACKLIST'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.DECAY_DIMS'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.REFRESH_DIMS'!

[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.LOOT_BLACKLIST'!
[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Map net.zestyblaze.lootr.config.LootrModConfig.replacements'!
[13:08:19] [Render thread/ERROR]: No GUI provider registered for field 'private static java.util.Set net.zestyblaze.lootr.config.LootrModConfig.LOOT_MODIDS'!

Thanks for updating to 1.19.3, this defect is still present in <IP_ADDRESS>.

Hm this might be a cloth config issue, I've been meaning to update the config anyway so I'll mark that for the next update

@ZestyBlaze Was this completed?

I think I did it but forgot to commit. I'm currently in the middle of a healthcare emergency so I'll have to commit it later when I get back from the hospital

No pressure! Take care of yourself.

Latest push should fix this, just need nooby to compile it

The config screen texts are now correct, however the log warnings are still present. Not sure if they indicate a real problem or are just noise.

I'll try to look into this some time this week.

The log warnings would seem to be irrelevant as these are internal values that don't require a configuration element. I'll look into adding an ignore line to these.


Event OrderInvoiceAvailable is dispatched multiple times

I have created a Listener which send a mail with the Invoice to the user. I use this Listener now about a year.
Last week i have added a new listener to the same event (OrderInvoiceAvailable), but since then, the mail is send multiple times. Even when i remove the new listener.
I don't have a glue how to debug this. Can someone help me to debug this or is this a known bug?
I have installed the latest version of cashier in combination with laravel spark.

Hi @GertTimmerman,
Have you tried clearing the cache?


[PORT] Add additional null check in Telemetry

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3452

Fixes: #3442
Similar to this PR, but adds a null check I missed (plus an additional test).
From
if (items.ContainsKey(TelemetryBotIdInitializer.BotActivityKey))

To
if (items != null && items.ContainsKey(TelemetryBotIdInitializer.BotActivityKey))

Changed projects

integration

Port not needed. Already contains appropriate null checks:

https://github.com/microsoft/botbuilder-js/blob/master/libraries/botbuilder-applicationinsights/src/telemetryInitializerMiddleware.ts#L62
https://github.com/microsoft/botbuilder-js/blob/master/libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts#L129


Refocusing visual studio code is sluggish - 1-5 seconds lagg

Issue Type: Bug
I just started noticing that whenever I switch window forcus from VSC til something else and back it takes several seconds for the VSC to "recover".
Say I switch back to VSC and start by selecting any text or click anywhere to place the carret/cursor, this takes 1-5 seconds before it completes every time. I am on a pretty fast PS with 64GB ram so I am not sure what made this change. It started today - I remember I did upgrade just now aswell.
Hopefully this is helpful for someone.
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3970X CPU @ 3.50GHz (12 x 3500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
63.91GB (56.29GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

markdown-preview-github-styles
bie
0.1.2

bracket-pair-colorizer
Coe
1.0.59

githistory
don
0.4.2

gitlens
eam
8.5.4

php-debug
fel
1.12.3

vscode-auto-open-markdown-preview
hnw
0.0.4

smarty
imp
0.3.0

vscode-apache
mrm
1.1.1

vscode-docker
Pet
0.1.0

markdown-checkbox
PKi
1.3.0

material-icon-theme
PKi
3.5.2

sass-indented
rob
1.4.9

html-preview-vscode
tht
0.1.1

(2 theme extensions excluded)

Can you also reproduce this behavior with vscode insiders https://code.visualstudio.com/insiders/
If yes here are some more steps on how to file a good performance issue https://github.com/Microsoft/vscode/wiki/Performance-Issues
Thanks!

Thank you for that tip on vscode insiders, I downloaded it and installed all the plugins that I have currently on the other vscode. At the moment I am not able to reproduce theese problems, the vscode insiders seems to work as I would expect when changing windows.
I will try to go through the steps on the performance link you posted, it should be a good lesson aswell into debugging stuff something I havnt been very up to date with. Great tip, thanks!

Cool. Let us know if you find something.

@steinhaug Since its been a week and we havent heard back from you, we are assuming that things are going well, and closing this issue.
The current Insiders will be released as stable early next week.
Happy Coding!


Isolate Ewelink Homes for separate Homebridge setups

Please explain your feature request in a one or two sentences.
I have 2 homes with Ewelink items and Homebridge running. I would prefer not to have all devices show up in HomeKit for each location.

Is your feature request related to a problem? Please describe.

No, other than HomeKit showing devices from another home

Any particular eWeLink devices that this relates to?
not in particular, more a general thing

Anything else?
nope

That works great, thanks!


Pilot DNS certificate provisioning must be guarded by a feature flag

Bug description
All alpha features must be guarded by a feature flag and must meet specific requirements to exit alpha:
https://github.com/istio/community/blob/master/FEATURE-LIFECYCLE-CHECKLIST.md#alpha
Please add a feature flag guard for this feature.
  There appears to be a nasty circular dependency with Pilot resulting in an inability of Istio to start if certificate provisiioning fails.
See https://github.com/istio/installer/blob/00cff16c25affcea4d43dea4204c15b9c4aca33e/istio-control/istio-discovery/templates/configmap.yaml#L145-L147 for more details.
Version (include the output of istioctl version --remote and kubectl version)
1.4.0-dev
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)

When the DNS cerfificate configuration is empty, dns certificate provisioning is turned off. I have created a PR https://github.com/istio/installer/pull/471 to set the DNS cerfificate configuration to be empty such that dns certificate provisioning is turned off.

The investigation of this issue is in https://github.com/istio/istio/issues/18458.

@sdake I have the following in the ICP
values:
    global:
      certificates: []

but still seeing 2 dns.... certificates being created in istio-system

@lei-tang @ostromart can you PTAL at the assumptions around this change?  It appears the values yaml passthrough is not working to disable this entry.
Cheers
-steve

I am not aware of ICP. For diagnosis purpose, can you provide instructions on running ICP to reproduce the problem?

ICP is the Operator IstioControlPlane resource, which has the values to use to customize istio.

Where is the code of ICP?

istio operator https://github.com/istio/operator/blob/master/data/profiles/default.yaml

Found it: https://github.com/istio/operator/blob/master/data/profiles/default.yaml#L312. I will create a PR to set the certificate configuration to be empty to turn off the certificate provisioning.

PR created to turn off DNS certificate provisioning on ICP: https://github.com/istio/operator/pull/500

Can we close this then?


Add support for flutter desktop linux

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.366%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
380

Relevant Lines:
407

💛  - Coveralls


Color Changing Not Working on H605B

What issue do you have? Please be as thorough and explicit as possible.
I have 2 tv backlight sets, the H6199, & the H605B with the added bars, but color changing is only working for the H6199.
When I ask Siri to change the color of the H605B she says “Hmm. That’s not a supported feature” but changes the color of the H6199 perfectly when I ask her to.
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?

Homebridge UI-X

Which version of Homebridge/HOOBS do you have?

Latest

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.

Raspberry Pi (4)

Which version of this plugin (homebridge-govee) do you have? Has the issue started since upgrading from a previous version?

Latest (not beta)

Which Govee devices do you have that are causing issues? Please include product models if applicable.

H605B
Please paste any relevant logs below.

I updated to the beta and the color changing seems to be working now (Siri no longer says not supported) but I am getting this message in the log so I wanted to let you know… H605B immersion strip w/bars
<device supports 'colorwc' command. let me know on Github with model number H605B>

New version of the plugin will use this new code for sending colour updates via AWS. You may find it's a little faster and also this log message won't appear anymore.

Thank you so much. This set is working great now. I really appreciate it.


Proxy support

I tried using a proxy to download via another IP, but couldn't get it to work via the http_proxy or HTTP_PROXY environment variables:
First, check "normal" public IP, then set a proxy, I tried some from this list until one worked: https://freeproxylists.net/
Check if the proxy works with the curl command (should return proxy IP).
Lastly, run suckit with the proxy and observe that the IP in the downloaded webpage is still the "normal" IP without the proxy.
curl ifconfig.me
prox=<IP_ADDRESS>:80
http_proxy=$prox curl ifconfig.me
http_proxy=$prox suckit -v http://ifconfig.me

Still, something is done with the proxy, since an invalid IP leads to an timeout or connection failure, and the latency is increased compared to a non-proxy run.

Beside this bug, a feature idea could be to offer multiple proxies to suckit, and the requests are split across the different proxies. This can further speed up downloading since less traffic is issued from a single IP.

Reqwest seems to support this. https://docs.rs/reqwest/latest/reqwest/struct.Proxy.html
We could read the environment variable before creating the Downloader

What I find strange, the environment variable is already read and processed somehow:

the download takes significantly longer with a proxy
bad proxy strings lead to failed downloads
running strings on the binary shows that the strings http_proxy and HTTP_PROXY are contained

But, the downloaded page does not show the proxy ip for the ifconfig.me website.

Have you try to use proxy in your browser then go to ifconfig.me? Does the ip displayed is different
My knowledge on proxy is quite limited but from what I remember, behind a proxy your real ip is not hidden as with a VPN

From what I read here it should "just works"™

This works for me:
https_proxy=<IP_ADDRESS>:9300 suckit https://ifconfig.me

The ip I get is not my real ip

Nice catch, I can confirm it works with https_proxy and http_proxy.
It seems suckit makes https content retrieval and additional http requests for something else.
If I had to guess, there is some code that resolves URLs, which is responsible for the http requests. (I remember some unit test which try to resolve an invalid lwn.net URL and looks for a redirect.)
My public server IP got blocked from scraping a particular website, so I can tell it needs both kinds of proxies to circumvent the block.

My public server IP got blocked from scraping a particular website

Typical SuckIT
Should we close this?

As far as I am concerned, yes.
Except you want to keep to open for the multiple proxy feature. This was just an idea, nothing where I would contribute personally.


[BUG] In version 3.2 S3StorageClient expects PROTEUS__AWS_SECRET_ACCESS_KEY

Previously I could run:
storage_client = S3StorageClient.create(auth=auth)
with
s3_client = AwsClient(
    aws_credentials=ExplicitAwsCredentials(
        access_key=secrets["sa_secret_access_key"],
        access_key_id=secrets["sa_access_key"],
        region=region,
        endpoint=endpoint,
    )
)

But after upgrading to 3.2, it is giving me this error:
File "/home/hfj/.cache/pypoetry/virtualenvs/omni-channel-crystal-solver-BUzSMOZ0-py3.11/lib/python3.11/site-packages/IPython/core/interactiveshell.py", line 3553, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in <cell line: 0>
runfile('/home/hfj/PycharmProjects/omni-channel-crystal-solver/examples/main_local.py', wdir='/home/hfj/PycharmProjects/omni-channel-crystal-solver/examples')
File "/opt/pycharm-2023.1.2/plugins/python/helpers/pydev/_pydev_bundle/pydev_umd.py", line 198, in runfile
pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/pycharm-2023.1.2/plugins/python/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/home/hfj/PycharmProjects/omni-channel-crystal-solver/examples/main_local.py", line 132, in
args = mock_arguments(file)
^^^^^^^^^^^^^^^^^^^^
File "/home/hfj/PycharmProjects/omni-channel-crystal-solver/examples/main_local.py", line 102, in mock_arguments
test_uri = _get_test_data_sas_uri(payload_data, auth=s3_client)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hfj/PycharmProjects/omni-channel-crystal-solver/examples/main_local.py", line 31, in _get_test_data_sas_uri
storage_client = S3StorageClient.create(auth=auth)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hfj/.cache/pypoetry/virtualenvs/omni-channel-crystal-solver-BUzSMOZ0-py3.11/lib/python3.11/site-packages/adapta/storage/blob/s3_storage_client.py", line 63, in create
auth.initialize_session(session_callable)
File "/home/hfj/.cache/pypoetry/virtualenvs/omni-channel-crystal-solver-BUzSMOZ0-py3.11/lib/python3.11/site-packages/adapta/security/clients/aws/_aws_client.py", line 106, in initialize_session
self._session = session_callable()
^^^^^^^^^^^^^^^^^^
File "/home/hfj/.cache/pypoetry/virtualenvs/omni-channel-crystal-solver-BUzSMOZ0-py3.11/lib/python3.11/site-packages/adapta/security/clients/aws/_aws_client.py", line 115, in _default_aws_session
self._credentials = EnvironmentAwsCredentials()
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hfj/.cache/pypoetry/virtualenvs/omni-channel-crystal-solver-BUzSMOZ0-py3.11/lib/python3.11/site-packages/adapta/security/clients/aws/_aws_credentials.py", line 64, in init
raise ValueError("PROTEUS__AWS_SECRET_ACCESS_KEY must be set")
ValueError: PROTEUS__AWS_SECRET_ACCESS_KEY must be set

We updated the constructor argument from aws_credentials to credentials, can you try
s3_client = AwsClient(
    credentials=ExplicitAwsCredentials(
        access_key=secrets["sa_secret_access_key"],
        access_key_id=secrets["sa_access_key"],
        region=region,
        endpoint=endpoint,
    )
)


SQL Console can be opened for public schema only

System information:

Operating system (distribution) and version Win10
DBeaver version 21.0.5

Connection specification:

Database name and version PostgreSQL, Greenplum, other PostgreSQL forks?

Steps to reproduce, if exist:
Open SQL Console for a non-public schema
Expected: SQL Console is opened for the selected schema
Actual result: SQL Console is opened for public schema
Workaround: open SQL Editor
https://user-images.githubusercontent.com/51405061/117973721-67244180-b335-11eb-9bf2-cfaf3cc62eda.mp4

I've reproduced this bug on Snowflake, which suggests that this problem is specific for all DBMS' with catalogs and schemas.

Actually, the problem is relevant for databases with schemas only.

Fixed.

Verified


Fix: Code Server notebook sha digest on the params.env file

Fix: Code Server notebook sha digest on the params.env file
Quay.io

Fixed with #112
Thanks for the PR
closing it.


Update installation instructions in README.md

While running the ember install:addon sl-ember-components does install this add on there are additional steps you must take in your application to fully utilize it.  These include:

Need to run npm install --save-dev ember-cli-less
Need to modify the Brocfile.js file to add:

app.import({
    development : 'bower_components/bootstrap/dist/js/bootstrap.js',
    production  : 'bower_components/bootstrap/dist/js/bootstrap.min.js'
});

Create the app/styles/app.less file and add to it:

@import 'sl-ember-components';

Add these additional steps to the README.md file.
This also relates to https://github.com/softlayer/sl-ember-components/issues/47

For the 2nd bullet point, can we possibly use app.import in "included" in index.js to remove needing to do this in the consuming application?

Created https://github.com/softlayer/sl-ember-components/issues/281 to capture the comment above about using "included"

I know this is closed, but not sure of the appropriate place to ask for help. I was already using SASS stylesheets in my app (and the broccoli-sass package for compiling app.scss). When I follow the instructions above, then I have app.less in addition to app.scss. But when I run ember server I get a broccoli error saying it can't find the app.less file.

@jdhines Unfortunately we have done any work with SASS with Ember CLI yet, and certainly not a combination of both of them in the same application.  At the moment I do not have any helpful information I can pass along.  Completely un-researched thoughts here but I wonder if the new Addon Nesting support of Ember CLI 0.2.0 would lead to a resolution of this issue.  We are planning on updating this Addon to 0.2.0 in the very near future (assuming any incompatibilities with Ember 1.10 does not delay the work)

Is there any ETA on update to 0.2.0 and addon nesting? This problem with sass+less is breaking my app as well.

@deafff @jdhines - @joshforisha Currently has a non-published branch he's working on that upgrades this repo to Ember CLI 0.2.1 that we are putting through it's final paces.  I anticipate being able to release it next week sometime.

@deafff @jdhines - @joshforisha has been working on the upgrade to Ember CLI 0.2.3 and has completed most of it but during the upgrade we have determined that we need to re-tool the implementation of the grid to be compatible with HTML Bars, which is what is currently holding up the upgrade and release.  Just wanted to give you an update.

@deafff @jdhines https://github.com/softlayer/sl-ember-components/pull/344 has been merged in, which upgrades this repository to Ember CLI 0.2.7.  We will be tagging a new release of this repository very soon.

@deafff @jdhines The https://github.com/softlayer/sl-ember-components/tree/v0.11.0 branch of this repo contains changes that isolates the repo's use of LESS from the consuming application so that all that the repo provides to the consuming application is compiled CSS, allowing the exact configuration you were asking for.  See https://github.com/softlayer/sl-ember-components/blob/v0.11.0/README.md for more information and https://github.com/softlayer/sl-ember-components/issues?q=is%3Aopen+is%3Aissue+milestone%3A"v0.11.0+(Bootstrap+Styling)" to track when all the issues in this milestone are resolved and v0.11.0 is released.


More info, tips etc. to Cloud front page

Taking a look at the Cloud documentation for the first time and see a few items that could be added to the front page right away:

Discuss the other two tabs besides Instances. For Org Settings there is some good information in the popup menu that can go in here nearly verbatim, while the Payment tab has some info especially on the sudden Link website, which is owned by the well-known Stripe but which visitors at first sight might not know is the same company. IOW adds a bit of reassurance
Hint on the bottom for users with problems that they can also set RUST_LOG and use the CLI if they want to see more inner workings when something goes wrong
Small rewording

This part though is puzzling:
your EdgeDB Cloud account. You do this by running the CLI command ``edgedb
cloud login``. This will make all of your EdgeDB Cloud instances accessible via
the CLI. You can manage them just as you would other remote EdgeDB instances.

Is it just me or are there no instructions when logged in to the Cloud web UI? I don't see any linking instructions anywhere.

Went ahead and applied those suggestions so I can merge. I'll do that once the build completes.

Thanks!


How to delete a message through SendAppState (only delete it for me)

patch := appstate.BuildDeleteForMe(chatJID, msgID.ID, false, senderJID)
err := instance.Client.SendAppState(patch)

How to implement the BuildDeleteForMe method? 🥺

No idea, its a new method it seems... not sure if I will find the time to develop, you are welcome to submit pull requests.


Requesting new language addition for Spanish translation in Crowdin.

Did you find a doc bug or broken link that needs to be fixed?

What is the file name(s) where you found the bug?
None. Requesting translation addition for Spanish.

What is the current text that needs to be fixed or removed? (You can copy and paste)
No fixes rather requesting translation addition for Spanish.

What should the documentation say instead?
Should expand to Spanish.

Are there other related issues or pull requests about this bug?
No.

Does existing documentation need to be updated with new content?

Which files need to be updated?
All files for translation as defined by Crowdin.

What content needs to be updated or replaced? (You can copy and paste)
All files for translation as defined by Crowdin

What new content needs to be added?
Spanish language content for Spanish speakers. This can be the basis for other Spanish derivatives like Castillian or further language particularizations.

Hi @joseluisrg Thanks for your request. We're starting to discuss what it takes to start up a new language. We started with Japanese, where we had a community leader who recruited about 10 or so volunteers who all use Qiskit. Do you know where (online or in-person) most people who would be interested in a Spanish translation of Qiskit congregate / read / publish? Do you think you could gather them to comment on this thread to show their interest in helping?

Hello Paul, I touched base with our local IBM Q Ambassador and she has gathered 10 Spanish speakers (including me and her), so yes we can help. We will ask them to join this thread. Thanks.

Hi Paul, we are about 14 Qiskit users interested in helping (counting me and Jose Luis). I have asked them to comment in this thread, so that you can identify us... Thank you.

Hello!
you can count me in on this one.

Hi!
I'm interested too.
Regards.

Spanish, Mexico translations have been enabled in CrowdIn. Please follow the steps for contributing to documentation localization. Thank you.

I spoke with @sita158 off-thread. She is going to continue to organize the community around Spanish (Mexico).

@SooluThomas I recommend publishing the Spanish, Mexico localization after the community translates

[ ] https://qiskit.org/documentation/
[ ] https://qiskit.org/documentation/install.html
[ ] https://qiskit.org/documentation/getting_started.html

@derivation Sounds good!

Hi,
I am in!
regards.

I'm all in for this one
Cheers
Balta

Count me in! Regards

@terebikun @balo215 @liobas @marmotae @juanmontalvog Please follow the steps for contributing to documentation localization. Here's a sample PR (https://github.com/Qiskit/qiskit/pull/580). Thank you.

I'd like to join

Since we have added Spanish(Mexico) in Crowdin, I'm closing this issue. Reopen if need be.

@SooluThomas keep this open until Spanish can be displayed in the live doc web page.

Hi

Count me in! Regards

+1 Me too

Can you please move this issue here: https://github.com/Qiskit/qiskit-translations if needed


[Bug]: Modal overlaps with nav bar in smaller screens

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When i open a large modal in the view mode for small screens it overlaps with the nav bar.

When a modal is open it should take the highest priority
Steps To Reproduce

Add a large modal
Deploy the app
Open the modal
Observe it is blocked by nav bar

Public Sample App
No response
Version
Cloud 1.7.5

@rohitagarwal88 @rahulramesha please get this prioritized

Have verified with button on click action to open modal widget, made the Modal larger till the limit


Compile multiple run conditions into one

Objective
When multiple run conditions are attached to a system, they should be compiled together as one function.
Solution
Add a variant of System{Set}Config that preserves the types of run conditions and combines them with any newly-added ones. This allows the compiler to inline them into one function.
This optimization is performed opportunistically -- run conditions that have already been boxed and type erased are not combined, as there is no benefit to doing so. This means that structs that perform type erasure such as SystemConfig present a barrier for this optimization. Resolving this should be possible in the future, but it would require a much higher-impact change that involves preserving the type data for all SystemConfig instances.

Add a matching Either combinator (to avoid mangling Or from queries).

I'm assuming you want this in order to satisfy #7584 -- however the And combinator I've added here intentionally doesn't short-circuit, so it won't resolve that issue. Instead of building on the And type by adding Either, I think it would be better to keep And an implementation detail and make it #[doc(hidden)].
I am working on another PR that would satify #7584, though.

Okay great, I'm fine to cut 1 from this PR :)

I'm taking this off of the milestone if that's okay, since 0.10 is so close and this is just a nice-to-have optimization.

Closing this since it's out of date, and I don't consider this to be high enough priority to get it working again.


Rotation issue after keyboard was shown iOS 7.1

Hi,
I'm working on iPad app and it uses only landscape mode. I was trying to show a HUD and it was appearing sideways, version 0.9 seemed to fix it. But now I've faced another issue - HUD appears in the right orientation until the keyboard is shown. After it was shown, even if I hide it - the HUDs will appear sideways. App is running on iOS 7.1
The way I'm showing the HUD is
'MBProgressHUD *HUD = [MBProgressHUD showHUDAddedTo:[[[UIApplication sharedApplication] windows] lastObject] animated:YES];

Sorry for the long delay. Forgot about this one. If it's still any help - you're using it wrong. Adding the HUD to [[[UIApplication sharedApplication] windows] lastObject] means it will be added to the keyboard window when the keyboard is visible (that's a private UITextEffectsWindow instance).
Add it to [[UIApplication sharedApplication] keyWindow] or a view and you should be good.


Update Deno Deploy github app description?

Went to sign up for Deno Deploy, and the permissions it asked for included the all-encompassingAct on your behalf permissions.
I clicked Learn more about Deno Deploy which did not give any additional information.
Is this repository the correct place to request explaining (and hopefully reducing) the permissions needed?

Act on your behalf is not an all-encompassing permission. It just means that if we asked for any permissions which allowed us to act as your user account (which we do not, we only request readonly email access), we would be able to act as your account. This is the minimal set of permissions you can request from GitHub as a GitHub App.
More info: https://github.community/t/why-does-this-forum-need-permission-to-act-on-my-behalf/120453
A description has now been added to the GitHub App.

TLDR:

We can only read-only access your email (read-only), and status checks and source code for repos your explicitly add the app to.

Thanks for the pointer to that thread, though it kind of raised more questions than it answered.
So you are saying even though the wording is Act on your behalf, trust the app will only request

read-only email address access (presumably to send email alerts?)
status checks (what is a status check? like, reading the state of PRs?)
the ability to ask to read a repositories source code

I guess if you only request read-only email access, its a bit confusing why it should be a github app at all. Especially after skimming https://docs.github.com/en/developers/apps/about-apps where there is an explicit callout:

Don't use a GitHub App if you just need a "Login with GitHub" service. But a GitHub App can use a user identification flow to log users in and do other things.

We also allow you to install the app on repositories. That is why it is a GitHub App. The 'can act on your behalf' wording is rather dubious - not sure what GitHub means with that. We specifically only request read only email access during signin. It is not possible for us to do things like post comments, or push to repos as your user account.

I'll close this as unactionable then.


[Feedback] Contextual styling with custom properties

We actually did the something like this with SCSS. There was a layout module, which defined the structure of the component (padding, size, animation) and defined a lot of color variables it used inside (for like border color) and their state-dependant variables (like hovered background color) and defined the basic color inheritances.
$color-button-default-background: #000 !default;
$color-button-default-text: #fff !default;
$color-button-hovered-background: $color-button-default-background !default;
$color-button-hovered-text: $color-button-default-text !default;
.button {
  color: $color-button-default-text;
  background: $color-button-default-background;
  &:hover {
    color: $color-button-hovered-text;
    background: $color-button-hovered-background;
  }
}

Next to it there was a color module for each color scheme, which defines the basic colors of the scheme and maps it to the component color variable.
/// raw colors
$schema-bright-red: #f00;
$schema-bright-blue: #00f;
$schema-bright-green: #0f0;

/// mapping
$color-button-default-background: $schema-bright-red !default;
$color-button-default-text: $schema-bright-blue !default;
$color-button-hovered-text: $schema-bright-yellow !default;

And then when you wanted to use a component with the color scheme, you have to import the two files in the proper order:
.theme-bright {
  @import "schema-bright";
  @import "component-layouts";
}

And because of the use of !default not just in the layout, but in the schema as well, you can override basic colors of component colors at the import level:
.theme-bright--custom {
  $color-bright-red: #e11;
  $color-button-hovered-text: aquamarine;
  @import "schema-bright";
  @import "component-layouts";
}

Thanks for the feedback. 🙇 Seems a good alternative if custom properties are still to early to use. 👍


💡[FEATURE]: Predicting COVID-19 from Chest X-Ray Images

Is your feature request related to a problem? Please describe.
The prediction of COVID-19 from chest X-ray images using Convolutional Neural Networks (CNNs) has several critical use cases in the healthcare sector. Firstly, it enhances diagnostic accuracy and speed in clinical settings, especially in regions with limited access to PCR testing facilities. By rapidly analyzing X-ray images, CNNs can assist radiologists in identifying COVID-19-related abnormalities, enabling timely isolation and treatment of infected individuals. Secondly, CNN-based models can serve as valuable tools in emergency departments, where quick decision-making is essential. They help in triaging patients, determining the severity of lung involvement, and prioritizing those needing immediate medical attention.
Describe the solution you'd like
Built and trained a convolutional neural network in Keras with TensorFlow as backend from scratch to predict patients if they were infected with COVID-19 or not using their chest X-ray images. Matplotlib was used for data visualization. Data preprocessing and data augmentation was carried out using tensorflow 2.0 The model used was sequential with a combination of convolutional layers, pooling layers, dropout layers, dense layers with relu activation and output layer with sigmoid activation. The dataset contained the lungs X-ray images of both groups i.e non-covid and covid infected patients. The dataset was obtained from kaggle. Metrics chosen for model evaluation were Training set, test set and validation set accuracy. Adam optimizer with learning rate of 0.001 was choosed for gradient descent The entire project was carried out on the Google Colab environment Results of the model were following:
Training Set Accuracy : 98.41 %
Training Set Loss : 0.0490
Validation Set Accuracy : 97.51 %
Validation Set Loss: 0.0759
Test Set Accuracy : 94.83 %
Test Set Loss : 0.1141
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context

@Akshat111111 please assign it to me

this is a  financial repo


How to programatically stop the automatic loop?

Hello,
First of all, thank you very much for developing this component.
I would like that, when the user changes tab in the browser, that the automatic loop stops temporarily.
This is because when I spend a lot of time on another tab and go back to the tab that contains the carousel, I see it slide through many slides quickly. In addition to the fact that I don't like the effect, I am afraid that this could cause some problems for the browser.
I tried to do the following, but it didn't work:
document.addEventListener("visibilitychange", function() {
    if (document.getElementById("my-carousel-id")){
        let selector = document.getElementById("my-carousel-id");

        if(selector.hasAttribute("data-embla")){
            let attrib = selector.getAttribute('data-embla');
            let obj = JSON.parse(attrib);

            if(obj.hasOwnProperty("loop")){
                obj["loop"] = !document.hidden;
                attrib = JSON.stringify(obj);
                selector.setAttribute("data-embla", attrib);
            }
        }
    }
});

When I leave the tab containing the carousel, the "loop" property is successfully changed to false, within the "data-embla" attribute, but this has no effect. I believe that the "data-embla" is used only when the component is initialized.
Would there be any way for me to stop the automatic loop programmatically through javascript?
Observation: I use it this way:

I figured it out. Sorry!
And thanks for this wonderful carousel.


Simplify and clean up the $NEON_AUTH_TOKEN stuff in compute

Simplify and clean up the $NEON_AUTH_TOKEN stuff in compute

Remove the neon.safekeeper_token_env GUC. It was used to set the
name of an environment variable, which was then used in pageserver
and safekeeper connection strings to in place of the
password. Instead, always look up the environment variable called
NEON_AUTH_TOKEN. That's what neon.safekeeper_token_env was always
set to in practice, and I don't see the need for the extra level of
indirection or configurability.

Instead of substituting $NEON_AUTH_TOKEN in the connection strings,
pass $NEON_AUTH_TOKEN "out-of-band" as the password, when we connect
to the pageserver or safekeepers. That's simpler.

Also use the password from $NEON_AUTH_TOKEN in compute_ctl, when it
connects to the pageserver to get the "base backup".

Rebased. @MMeent can you review the pgxn parts here, please?


Not Saving

Error Code
Error: Precondition Failed

require<.superagent</Request/<@https://homebrewery.naturalcrit.com/homebrew/bundle.js:76373:19
require<[9]</Emitter.prototype.emit@https://homebrewery.naturalcrit.com/homebrew/bundle.js:1966:20
require<.superagent</Request.prototype._end/xhr.onreadystatechange@https://homebrewery.naturalcrit.com/homebrew/bundle.js:76682:10

{
  "status": 412,
  "method": "PUT",
  "url": "/api/update/GjIpqjJU_2S2"
}

### Your description of what happened:

Won't save my work

You have an old version of the Homebrewery site that is missing a recent update. This should only happen once, and then in the future you will receive a better error message explaining what is going on.
To get the update, go ahead and copy your brew text elsewhere temporarily as a backup, then reload the page. Your brew should be back to where you left it, and the website should now say "v3.6.0" in the upper left.
If reloading the page didn't work, try Hard Reloading the page. You can do this by pressing CTRL + SHIFT + R at the same time while at the Homebrewery.  Alternatively, you can open up the Chrome Developer Console (Right-click on the page and choose "inspect"). This will add some options to the refresh button if you right-click it. Again, choose "Hard Reload".

That should force Chrome to check for an update to the Homebrewery. Let us know if that doesn't work.

Thanks a lot. Recently found something I had been working really hard on that I thought was deleted. Love this site.


Use absolute path for mktemp

Fix #403.
This prevents the GNU mktemp to be used if the user installed the coreutils package on their machine with brew.

:+1: thanks @guillaume-algis :)

Also, do you think it would appropriate to apply the same absolute path correction for other binaries we are calling, such as defaults, pgrep, mkdir, curl`, etc.?

I'm not sure if it always makes sense, what if someone is using a different binary for (for example) security reasons? Most of the times different versions should be compatible right?
I'm actually wondering if we should maybe ask people to just install manually if they don't have the default system utils installed, as this indicates that they're a power user and they would probably be comfortable with the manual install anyways.

I'm actually wondering if we should maybe ask people to just install manually if they don't have the default system utils installed, as this indicates that they're a power user and they would probably be comfortable with the manual install anyways.

Hmm, this prompted me to go read the coreutils formula, and sure enough it's the user's choice to shadow the default BSD binaries:

All commands have been installed with the prefix 'g'.
If you really need to use these commands with their normal names, you can add a "gnubin" directory to your PATH from your bashrc like:
PATH="#{opt_libexec}/gnubin:$PATH"

So I tend to agree with you and begin doubting merging this PR is a good idea. After all @tianxiewuhua and @thor-the-norseman explicitly chose to use the GNU binaries.

I think a lot of Homebrew users actually miss out on the subtle fact that adding that path isn't required to be able to run Homebrew binaries without a path prefix. That was the reason I added it. Now that I know that removing the path element won't stop any binaries from working, I might just remove it and use the 'g' prefixes instead (that I discovered on my own a few months ago, but merely used to explicitly pick GNU tools in cases where they didn't properly shadow the Darwin tools).

I vote for "won't fix" as this is actually caused by a non-standard user system setup.
If you agree @jurre, I think we can close this and #403.

Yeah I agree @guillaume-algis


Tx not being sent - requires update to bitcoinj-alice

Seen a few times:
Tx does not appear to broadcast and no feedback from the Bitcoin network.
Tx not appearing in your block explorer.
In log:
[2015-03-02 09:34:44,932] DEBUG [safe-fixed-bitcoin-network-1] o.m.h.c.s.BitcoinNetworkService - Initiated broadcast of transaction: '01000000018fa292ffd949404c19bda80832c1e83bda16d7418f7176de320d872d0d02434d010000006b483045022100dcf831178cd00bfaac229ad906cebadf9e73c9ad2bd6cb14e47b300da6ccb7eb02200ac47305d79ee505b52077ec352898fc873bef3ce192d9dd93f51c618c30474d012102d701893ae39ff0ff43d24c65685f6b433f8f902f95f2c7dc1fb80e3361fef86dffffffff02f8a70300000000001976a9148dd0267f0b618732b83c4e7808b499f58cc72f9b88ac15f90100000000001976a9147d1065bbc56bfee5c4d882d48a0d4dd38bb0747388ac00000000'
[2015-03-02 09:34:44,932] DEBUG [safe-fixed-bitcoin-network-1] o.m.h.c.s.BitcoinNetworkService - Forgetting last SendRequest and Wallet
[2015-03-02 09:34:45,098] DEBUG [safe-fixed-core-events-5] o.m.h.c.s.WalletService - Writing payments completed
[2015-03-02 09:35:00,576] DEBUG [bitcoinj user thread] o.m.h.c.n.MultiBitPeerEventListener - (disconnect) Number of peers = 6
[2015-03-02 09:35:00,576] ERROR [NioClientManager] o.b.n.NioClientManager - Failed to connect with exception: java.nio.channels.ClosedChannelException: null

If you 'bounce' the network by doing a switch back into the same wallet the tx gets sent/ resent (by a new peer).

Relevant google groups:
https://groups.google.com/forum/#!msg/bitcoinj/ze6qh622Y5s/DQFnF5hb_TQJ
We probably need to rebase bitcoinj-alice to 0.13-SNAPSHOT

Yes, we should have a general tidy up of Bitcoinj-Alice and issue an upstream pull request to get BIP44 support into Bitcoinj. This would greatly simplify code moving forward.

The BIP44 support code in bitcoinj-alice is not very general - I don't think it would be accepted into bitcoinj as is. It would need refactoring out with a definition of what's in a wallet. I don't particularly want to do this before the Release 0.1

OK. Created #441 to cover it. Currently scheduled for Release 0.2.

Integration work is being done with:

bitcoinj-alice devleop branch
MBHD issue-440 branch

I have updated the bitcoinj-alice branch and now use the TransactionBroadcast which improves the SendReport screen.
Awaiting review and closing

I have hooked up the 'broadcast progress' information that bitcoinj provides in a listener.
The 'bullhorn' icon partially fills up as the peers report seeing a transaction.

I have increased the max number of connections MBHD makes to 8.
Thus on a send it will broadcast to 4 peers and be 'officially' sent when it sees it on an inv from 2 of the others. This gives some headroom against slow/ broken peers.

Not working for me. I did a Maven install of the latest develop of Bitcoinj Alice and used the latest code (ded1d42160...)

Saw this exception:
[2015-03-08 12:50:04,668] DEBUG [AWT-EventQueue-0] o.m.h.c.s.BitcoinNetworkService - Not adding client fee output due to !sendRequest.emptyWallet = true or sendRequestSummary.isApplyClientFee() = false
[2015-03-08 12:50:04,668] DEBUG [AWT-EventQueue-0] o.m.h.c.s.BitcoinNetworkService - Completing send request...
[2015-03-08 12:50:04,677] ERROR [AWT-EventQueue-0] o.m.h.c.s.BitcoinNetworkService - Could not complete the transaction without signing ! java.lang.IllegalArgumentException: Given SendRequest has already been completed.
! at com.google.common.base.Preconditions.checkArgument(Preconditions.java:125) ~[guava-16.0.1.jar:na]
! at org.bitcoinj.core.Wallet.completeTx(Wallet.java:3520) ~[bitcoinj-core-0.13-alice-develop-SNAPSHOT.jar:na]
! at org.multibit.hd.core.services.BitcoinNetworkService.completeWithoutSigning(BitcoinNetworkService.java:844) [classes/:na]
! at org.multibit.hd.core.services.BitcoinNetworkService.prepareTransaction(BitcoinNetworkService.java:755) [classes/:na]
! at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.prepareTransaction(EmptyWalletWizardModel.java:262) [classes/:na]
! at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.showNext(EmptyWalletWizardModel.java:109) [classes/:na]
! at org.multibit.hd.ui.views.wizards.AbstractWizard$5.actionPerformed(AbstractWizard.java:349) [classes/:na]
! at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018) [na:1.7.0_51]
! at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341) [na:1.7.0_51]
! at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402) [na:1.7.0_51]
! at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259) [na:1.7.0_51]
! at javax.swing.plaf.basic.BasicButtonListener$Actions.actionPerformed(BasicButtonListener.java:303) [na:1.7.0_51]
...

You also need to build multibit-hardware as the bitcoinj-alice is now transitive

Yep. Done that too (although simply building Bitcoinj Alice would install the required bitcoinj-alice-develop-SNAPSHOT into the shared Maven repo). Are you sure you've pushed everything?

I don't have anything local.
To make progress and see the new snazzy send report screen you might want to:
Go into bitcoinj-alice Wallet#completeTx and remove the check that throws the IllegalStateException 'Given SendRequest as already been completed'.
The MBHD code also has to make sure that it removes the txInputs on an Empty otherwise they get added twice but that's in MBHD code and you'll have that.

Just wanted to double check we are both using the same repo.
My alice remote is:
origin git@github.com:bitcoin-solutions/bitcoinj-alice.git (fetch)
origin git@github.com:bitcoin-solutions/bitcoinj-alice.git (push)

Here's some progress. I was able to use the Send screen to create a transaction. Saw the bullhorn filling up (like it) so that's all good.
However, it's still failing on the Empty panel with the same exception:
[2015-03-10 21:24:41,610] ERROR [AWT-EventQueue-0] o.m.h.c.s.BitcoinNetworkService - Could not complete the transaction without signing ! java.lang.IllegalArgumentException: Given SendRequest has already been completed.
! at com.google.common.base.Preconditions.checkArgument(Preconditions.java:125) ~[guava-16.0.1.jar:na]
! at org.bitcoinj.core.Wallet.completeTx(Wallet.java:3520) ~[bitcoinj-core-0.13-alice-develop-SNAPSHOT.jar:na]
! at org.multibit.hd.core.services.BitcoinNetworkService.completeWithoutSigning(BitcoinNetworkService.java:844) [classes/:na]
! at org.multibit.hd.core.services.BitcoinNetworkService.prepareTransaction(BitcoinNetworkService.java:755) [classes/:na]
! at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.prepareTransaction(EmptyWalletWizardModel.java:262) [classes/:na]
! at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.showNext(EmptyWalletWizardModel.java:109) [classes/:na]
...

I'm using Maven: org.bitcoinj:bitcoinj-core:0.13-alice-develop-SNAPSHOT installed using the HEAD of develop branch. Fingerprint: f93875a3f8640198e5783c75669876841fe22e80. When doing the Maven install I manually deleted the original entries in the repository and verified that new ones had been created.
I'm certain that there is an issue in the Empty wallet code that isn't present in Send Bitcoin.

As you've got a tx sending ok I'll close this one and put a comment on the 'Empty wallet not working issue'.

Your code and my code are not the same !
In my bitcoinj-alice Wallet line 3520 is:
// ALICE - allow a send request to be completed twice - used in Empty wallet
This is exactly the change I made to replace the precondition that is firing and is shown in your exception stack trace.
Here is my git status and log:
jims-macbook-91:bitcoinj-alice jim$ git status
On branch develop
nothing to commit, working directory clean
jims-macbook-91:bitcoinj-alice jim$ git remote -v
bitcoinj-canonical	https://github.com/bitcoinj/bitcoinj.git (fetch)
bitcoinj-canonical	https://github.com/bitcoinj/bitcoinj.git (push)
origin	git@github.com:bitcoin-solutions/bitcoinj-alice.git (fetch)
origin	git@github.com:bitcoin-solutions/bitcoinj-alice.git (push)
jims-macbook-91:bitcoinj-alice jim$ git log
commit 698c12d5fa861898cdce4f91586d2190d397cc87
Author: Jim Burton<EMAIL_ADDRESS>Date:   Sat Mar 7 16:16:21 2015 +0000

    relaced check on double complete (used in MBHD empty wallet)

commit f93875a3f8640198e5783c75669876841fe22e80
Author: Jim Burton<EMAIL_ADDRESS>Date:   Thu Mar 5 12:22:08 2015 +0000

    added 'develop' into artifact name to distinguish it from the one created by bitcoinj-alice master branch

commit 7757463d845972b8625cca916c0042b0c39a48d6
Author: Jim Burton<EMAIL_ADDRESS>Date:   Wed Mar 4 16:25:32 2015 +0000

    removed Java 8 modules

commit a020b2b9dd8cdb74a57a2f8e9a9e41024cfad352
Author: Jim Burton<EMAIL_ADDRESS>Date:   Wed Mar 4 15:49:05 2015 +0000

    removed examples as uses Java 8

commit 306ccba832ad12f14a88677187afe851b845bfcd
Author: Jim Burton<EMAIL_ADDRESS>Date:   Wed Mar 4 15:34:39 2015 +0000

    turned off date check has to be at root as not the case with trezor wallets

commit cb8473f98d7ad911f47ccb6fc7aadcfb4b5f6eb0
Merge: 4732aee 6c733b2
:

Can you just go into the Wallet class and see what you have on line 3520, that will be quickest.
Also, can you make sure that you are picking up the correct artifact in your MBHD pom.
It should be bitcoinj-alice-develop-SNAPSHOT

Also worth checking that the multibit-hardware POM is picking up bitcoinj-alice-develop-SNAPSHOT.

I've reopened this as we are still commenting on it

I just checking on:
https://github.com/bitcoin-solutions/bitcoinj-alice/blob/develop/core/src/main/java/org/bitcoinj/core/Wallet.java

And did not see my change on Wallet#3520.
I have touched the file and repushed and see it now.
Not sure what happened there.

Try updating your bitcoinj, building it and retrying.

It works! After I did the pull and a diff it showed no difference between the files. I invalidated my local Intellij caches, deleted any trace of bitcoinj-alice from my local repo, rebuilt bitcoinj-alice on develop, verified the correct code was present in External Libraries and performed an Empty wallet.
Verified working so closing.


[MRG] Sphinxing

First part of #640.
Scope

[x] Tooling and prerequisites: Cherry pick as much as possible from betatim's existing setup.

[x] Building the documentation and creating a html version should behave correctly.
[x] Include the napoleon plugin so that we can stay with the Numpy docstring style.
[x] Have the first examples show up correctly in the new sphinx docs (to verify that everything is set up correctly). (*)

(*): Restrict this to the section Top level minimization functions, mainly dummy_minimize.
Update:
Almost finished. I need to look over all the changes again, then i set it to MRG. All aesthetical, content-related or structural changes are not yet done and will be processed in further PRs.

Codecov Report

Merging #641 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage    86.6%   86.59%   -0.01%
==========================================
  Files          23       23
  Lines        1777     1776       -1
==========================================
- Hits         1539     1538       -1
  Misses        238      238

Impacted Files
Coverage Δ

skopt/utils.py
91.07% <ø> (-0.06%)
:arrow_down:

skopt/__init__.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691959d...44af81a. Read the comment docs.

I thought about changing the circleci setup so that we can build the old and new docs in parallel. In the end i decided it's probably not worth the hassle, and since this does not really break anything i'd rather invest the time in the actual sphinx migration.

Currently testing nbsphinx. It seems to have problems whenever the notebooks are not in a subdirectory of the docs directory. (Short: scikit-optimize/examples causes problems, scikit-optimize/docs/examples works fine.) Any ideas / opinions about this?

I ran into the problem with nbsphinx as well and didn't find a solution that worked except for moving things to docs/examples/. I'd do that. Maybe we can make scikit-optimize/examples/ a soft-link to scikit-optimize/docs/examples/ to send visitors to the new location.

I spent a few hours yesterday investigating lib2to3 to see if we can reuse its infrastructure to automatically rewrite doc strings from markdown to rST. I think the answer is yes, but it might be one of these projects where you spend more time building a tool than it would take to do it manually. I'll keep people posted.
👍  to not spending time trying to build the docs in parallel.
Can you see the "artefacts" that Circle CI produces? For example https://1096-54340642-gh.circle-artifacts.com/0/tmp/circle-artifacts.pVMZdSQ/index.html

Thanks for sharing your thoughts and experiences! Now i feel better moving the examples.
How will a soft-link behave for Windows users? I thought of that at first too at first, but discarded it due to that.
I can't see the artifacts on circleci. The link you posted, however, works for me.

I can't see the artifacts on circleci. The link you posted, however, works for me.

Ok, that is a bit annoying. You will have to keep building the docs locally to see if it works :(

soft-link on Windows

I have no idea what happens on Windows with soft-links. Do we know someone who has access to a windows machine?

From a quick google it seems that symlinks aren't a thing at all on windows. My next best idea would be to place a README.md in the examples directory containing a short explanation where the examples have moved to and a link to them.

More complicated than i expected. I just realized this needs to work for python 2 and 3. Will update my progress later on.

Hello @chschroeder! Thanks for updating the PR.

In the file skopt/optimizer/optimizer.py, following are the PEP8 issues :

Line 54:80: E501 line too long (93 > 79 characters)

The basic stuff should be working now. Obviously the resulting documentation is everything but complete. I refrained myself from making changes to the structure, contents or layout of the documentation.
(There are warning during the build of the docs because some parts are references but still have the old docstring. These warning will disappear when the rest is migrated.)

Last thought, when we merge this too early, will the current state of the docs be deployed to https://scikit-optimize.github.io/ ?
Then we should probably keep this at a separate branch.

We could disable for the time being the automatic deployment of the doc, maybe?

Not sure about disabling doc deployment.
We already have parts of the docs which are "broken" in terms of layout because we use a mixture of markdown and reST in the doc strings.
If we auto-deploy this we end up with partially broken docs which annoys users.
If we do not auto-deploy this we will forget about it and end up with out-of-date docs.
Neither solution seems particularly good :-/

This is what the docs currently look like when using this PR: https://1104-54340642-gh.circle-artifacts.com/0/tmp/circle-artifacts.wqEdI82/index.html

That's not bad to be fair. We should populate the left menu a bit, e.g. by having direct links to the minimize functions and find a way to add back the notebooks.

Let's move the example notebooks as discussed.

We could also do the work on a separate branch (with auto deploy disabled). There haven't been that many merges during the last few days, so i think we could keep up with the changes in the master branch.

The notebooks' files have already been moved. I only added one as an example to the docs, the rest can be easily added as well. Still, everything else would be missing in these docs.

By the way, did you change the output of https://scikit-optimize.github.io? This style from pdocs is really nice. As far as i remember, i only saw the sphinx alabaster style at the docs page before.

I reincluded the notebooks (i.e. linked to them in the docs). I had to change some heading levels because they were displayed as top-level items (# -> ##).
@betatim For the "Strategy comparison" notebook, there was a different top-level heading and sphinx took that instead of the label. I changed it to match the notebook's filename for now. This is your notebook, do you agree here? Or should this be solved differently.

I am -1 on any kind of parallel branch strategy. In my experience this almost always leads to a lot of pain when you do try to merge.
I think if we can make a issue that lists the things that need to be done "quickly" after we merge this to get to a good state and each of us tackles one of them we can make the switch fairly quickly without having to have a parallel universe. We could even start on the things that are missing in new PRs now (building on this branch and then rebasing once it is merged).

Thanks for the review! If i understand correctly you would prefer if this PR was somewhat more complete. I have no strong opinion here, so i can live with this either way. I tried to keep it as small as possible for easier reviewing, but i understand the argument against branching as well.
To do for this task:

Adopt the structure from the old docs (https://scikit-optimize.github.io)
Check / Update links to the notebooks

Besides, it would be easier for me to know, what is specifically excluded here, i.e. what do we need to do in the next PR.

Correct the markup of existing docs.
Styling? (I think in terms of visuals, the current sphinx style is not on par with the old docs :P). Do you agree here?

I think the effort you put into this PR as it is is already huge! Last time I tried to get this switch made I wanted to convert "all the docs" in one go (and failed). So this time I think we should get "a large chunk" changed and then merge it. Then make more small PRs to fix up the things that are broken. The downside is that the docs will be partly broken. If there are other ideas please mention them :)
What do you mean with "adopt structure of old docs"? What is where and TOC entry wise?

Alright, then let's finish as much as possible here. I was just afraid to produce too many changes at once.
I don't see any other options where we would not break anything (except a big merge that unrealistically fixes everything).
With "structure" i was referring to the TOC. Basically, every page that has been present before should be visible and reachable (regardless of some broken markup).

In the meanwhile i got the hang of most of the sphinx stuff. I am struggling to insert some special links (e.g. Module Index) in the Navigation. Besides, the structure of most of the sub pages is too cluttered as it is right now. Put it back to WIP for now.
Somewhat offtopic:
I really like the style from pdoc (https://github.com/BurntSushi/pdoc) that you chose for the current docs. Unfortunately, it does not seem there is a sphinx template for this.
Would you be interested in having this as a sphinx theme? Not sure to what extent this is possible (not familiar with the limits of sphinx templates) though.

This has stalled right now. Unfortunately i have neither had much time lately, nor was i happy with the resulting docs (produced in this branch).
I haven't gotten a reply, but i think we need a suitable sphinx theme in the long run.
This is probably focusing at the wrong place, yet i feel regardless what i change at the docs now, it just looks "unfinished" and not as good as the current docs do.


Define the boundary on what projects should be in our database

The set of Open Source projects is too extensive to realistically load into augur. We need to define a strict definition of projects that will be automatically loaded into our data base. The first bound is the repos must have an open source license, the others need to be determined:
Current ideas going around:

strict boundary of amount of contributors, last "activity", stars etc
define what having a "community" means and cut along those lines
designate a "score" on the oss scorecard for acceptance

Other ways projects can designed to be loaded in:

query to our dashboard
direct request (process to be determined)

Update: will be hosting a discussion around the top of "what do you consider an active open source community?" with the hopes to get more guidance on this

From CoP meetings, some great conversations for the project as a whole as come out. The conclusion at this time for this specific question is to start with filtering on time since last commit and number of contributors. There will need to be a manual load of "dead" or extremely mature projects to be able to have enough data for the seasonality of community problem


Mergeback release to dev

What it solves
Mergeback version changes to development

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.556%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
787

Relevant Lines:
985

💛  - Coveralls


Implement versioning policy contract (GEP-5)

GEP-5 (https://github.com/gardener/gardener/blob/master/docs/proposals/05-versioning-policy.md) is a proposal for making the Kubernetes and operating system versioning policy more predictable for operators and end-users.
Mainly, it classifies versions into four categories, preview, supported, deprecated, and expired.
As the proposal has been accepted we should implement it now.

Please review this PR first.

As discussed out-of-band, we agreed to first document our "ideal versioning policy" (technical representation) and break down the functionality into 3 components:

CloudProfileHelper: A binary that uses the policy and helps an operator to manipulate a cloud profile as file/stream (not as Kubernetes resource).
CloudProfileAdmissionController: An admission controller that uses the policy and that, if switched on/configured, prevents mistakes in the live system from happening.
ShootMaintenanceController: Modifications to the Gardener shoot maintenance controller that implements general (not policy-sensitive) operations.

E.g. a document with these 4 sections (content is just an example/not a proposal/final/matching the https://github.tools.sap/kubernetes/kube-docs/wiki/Versioning-Policy):
# VersioningPolicy
kubernetesVersionManagement:
  maintainedKubernetesVersions: 3
  expirationDurationForMaintainedVersions: 2880h
  expirationDurationForUnmaintainedVersions: 720h
machineImageVersionManagement:
  expirationDuration: 2880h

# CloudProfileHelper Tasks
- When a preview version is marked as supported
- ...

# CloudProfileAdmissionController Tasks
- Previews only newer than latest supported minor/patch versions
- Expiration dates within allowed timerange according to policy
- ...

# ShootMaintenanceController Tasks
- Do not roll into preview OS versions (even if previews newer than supported versions)
- Roll expired OS into latest supported OS version
- Do not roll into preview K8s versions (even if previews newer than supported versions)
- Roll expired K8s into oldest supported or deprecated minor Kubernetes version and latest patch version
- ...

/close
as the related PRs have been merged


Add character counter into Captive Portal

#117

@nfeuer currently set characters to max 130 which should be enough to fill a portal but we can put that higher if needed. Wanted to leave some room for Big DuckID's and hopping


0.29

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Rakibul Asheeque:x: RakibulAsheequeRakibul Asheeque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Error: Body Already Used in github function CD

I have trouble in my CD since last update (0.7.2 to 1.1.2) , bun test works fine locally but wont pass in github. I have another old branch on 0.7.7 that doesn't have this issue either
Run cd server
  cd server
  bun install
  bun test
  shell: /usr/bin/bash -e {0}
  env:
    PORT: 3000
    MONGO_URL: mongodb://localhost:3[2](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:2)768/mytestdb
    JWT_SECRET: JWT_SECRET
    ALLOWED_DOMAINS: ["http://localhost:417[3](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:3)"]
bun install v1.1.26 (0a37[4](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:4)23b)

+ typescript@[5](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:5).5.4
+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+ portfolio-common@workspace:common

3[6](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:6)2 packages installed [954.00ms]

Blocked 1 postinstall. Run `bun pm untrusted` for details.
bun test v1.1.26 (0a3[7](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:7)423b)

tests/auth.test.ts:
  Running at http://:::3000 CORS allowed: "[\"http://localhost:4173\"]"
  (pass) login > Should create new user [150.26ms]
  (pass) login > Should return existing user [3.49ms]

tests/eden.test.ts:
  Service is healthy!
  (pass) edenTreaty > edenTreaty should have correct methods [1.1[8](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:8)ms]

  Error:
        at /home/runner/work/portfolio/portfolio/node_modules/@elysiajs/eden/dist/index.js:1:[9](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:9)150
  1 | "use strict";var P=Object.defineProperty;var ne=Object.getOwnPropertyDescriptor;var re=Object.getOwnPropertyNames;var se=Object.prototype.hasOwnProperty;var ae=(e,t)=>{for(var n in t)P(e,n,{get:t[n],enumerable:!0})},ie=(e,t,n,r)=>{if(t&&typeof t=="object"||typeof t=="function")for(let s of re(t))!se.call(e,s)&&s!==n&&P(e,s,{get:()=>t[s],enumerable:!(r=ne(t,s))||r.enumerable});return e};var oe=e=>ie(P({},"__esModule",{value:!0}),e);var be={};ae(be,{edenFetch:()=>te,edenTreaty:()=>ee,treaty:()=>z});module.exports=oe(be);var T=class extends Error{constructor(n,r){super(r+"");this.status=n;this.value=r}};var ce=/(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d\.\d+([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))/,fe=/(?:Sun|Mon|Tue|Wed|Thu|Fri|Sat)\s(?:Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec)\s\d{2}\s\d{4}\s\d{2}:\d{2}:\d{2}\sGMT(?:\+|-)\d{4}\s\([^)]+\)/,de=/^(?:(?:(?:(?:0?[1-9]|[[12](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:13)][0-9]|3[01])[/\s-](

  error: Body already used
   code: "ERR_BODY_ALREADY_USED"

        at /home/runner/work/portfolio/portfolio/node_modules/@elysiajs/eden/dist/index.js:1:9150
  (fail) edenTreaty > edentTreaty should return correct responses [1.12ms]

 3 pass
 1 fail
 [14](https://github.com/lomithrani/portfolio/actions/runs/10538541982/job/29201159241?pr=56#step:5:15) expect() calls
Ran 4 tests across 2 files. [675.00ms]

Actual test :
import { test, expect, describe, beforeAll, afterAll } from 'bun:test'
import { edenTreaty } from '@elysiajs/eden'
import type { Portfolio } from '..'
import { ErrorLike, Subprocess, fetch } from 'bun';

let appInstance: Subprocess<"ignore", "inherit", "inherit"> | undefined = undefined;

const api = edenTreaty<Portfolio>("http://localhost:3000");

describe("edenTreaty", () => {
  beforeAll(async () => {
    appInstance = Bun.spawn({
      cmd: ['bun', 'run', 'index.ts'],
      env: process.env,
      stdout: 'inherit',
      stderr: 'inherit',
    });
    await waitForHealthCheck()
  });

  afterAll(() => {
    if (appInstance) {
      appInstance.kill();
    }
  });

  test("edenTreaty should have correct methods", async () => {
    expect(api).toBeDefined()
    expect(api.login.post).toBeDefined()
    expect(api.domain[':name'].get).toBeDefined()
  })

  test("edentTreaty should return correct responses", async () => {
    const mySelfDomainResponse = await api.domain['louis.gentil'].get()
    expect(mySelfDomainResponse).toBeDefined()
    expect(mySelfDomainResponse.status).toBe(200)
    expect(mySelfDomainResponse.data).toBeDefined()
    expect(mySelfDomainResponse.data).toBeObject()
  })

})

async function waitForHealthCheck(url = "http://localhost:3000/health", maxAttempts = 10, interval = 1000) {
  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
    try {
      const response = await fetch(url);

      if (response.status === 200) {
        console.log("Service is healthy!");
        return true;
      } else {
        console.log(`Attempt ${attempt}: Received status ${response.status}. Retrying in ${interval / 1000} seconds...`);
      }
    } catch (error) {
      console.log(`Attempt ${attempt}: Error occurred - ${error}. Retrying in ${interval / 1000} seconds...`);
    }

    if (attempt < maxAttempts) {
      await new Promise(resolve => setTimeout(resolve, interval));
    }
  }

  console.log("Failed to receive a 200 status after max attempts.");
  return false;
}

I'm wondering if it can due to my changes:
const domainObject = JSON.parse(JSON.stringify(populatedDomain)) as Omit<Domain, 'experiences'> & { experiences: Experience[] };
This JSON.parse of JSON.stringify is definetly a code smell but It's the only way I managed to not break eden and not have plain text returned

Yeah! I receive it in tests with eden too


Unhandled Exception: type 'Transition' is not a subtype of type 'bool'

When i use this version in master channel show this error and not show next page.
pubspec.yml:

get: ^1.14.0-dev

Screen:

Code:
    Get.to(FirstLoginScreen(),transition: Transition.fade,duration: Duration(milliseconds: 100));

Flutter doctor:
[√] Flutter (Channel master, v1.18.1-pre.3, on Microsoft Windows [Version 10.0.17134.1365], locale en-US)
    • Flutter version 1.18.1-pre.3 at D:\java\flutter\flutter
    • Framework revision e3e189219b (19 hours ago), 2020-04-06 14:31:38 -0700
    • Engine revision df257e59c2
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at E:\Android\sdk
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = E:\Android\sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] IntelliJ IDEA Community Edition (version 2018.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.2.4
    • Flutter plugin version 34.0.1
    • Dart plugin version 182.5215

[√] VS Code, 64-bit edition (version 1.28.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 2.21.1

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.0 (API 24) (emulator)

• No issues found!

Error:
ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: type 'Transition' is not a subtype of type 'bool'
E/flutter (25785): #0      Get.to (package:get/src/get_main.dart:59:32)
E/flutter (25785): #1      _SplashScreenState.goToNextPage.<anonymous closure> (package:amack_v4_backend/ui/screens/splash_screen.dart:57:9)
E/flutter (25785): #2      _rootRun (dart:async/zone.dart:1180:38)
E/flutter (25785): #3      _CustomZone.run (dart:async/zone.dart:1077:19)
E/flutter (25785): #4      _CustomZone.runGuarded (dart:async/zone.dart:979:7)
E/flutter (25785): #5      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
E/flutter (25785): #6      _rootRun (dart:async/zone.dart:1184:13)
E/flutter (25785): #7      _CustomZone.run (dart:async/zone.dart:1077:19)
E/flutter (25785): #8      _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:1003:23)
E/flutter (25785): #9      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:23:15)
E/flutter (25785): #10     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)
E/flutter (25785): #11     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
E/flutter (25785): #12     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
E/flutter (25785):

When i use this version in master channel show this error and not show next page.
pubspec.yml:

get: ^1.14.0-dev

Screen:

Code:
 Get.to(FirstLoginScreen(),transition: Transition.fade,duration: Duration(milliseconds: 100));
Flutter doctor:
[√] Flutter (Channel master, v1.18.1-pre.3, on Microsoft Windows [Version 10.0.17134.1365], locale en-US)
    • Flutter version 1.18.1-pre.3 at D:\java\flutter\flutter
    • Framework revision e3e189219b (19 hours ago), 2020-04-06 14:31:38 -0700
    • Engine revision df257e59c2
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at E:\Android\sdk
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = E:\Android\sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] IntelliJ IDEA Community Edition (version 2018.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.2.4
    • Flutter plugin version 34.0.1
    • Dart plugin version 182.5215

[√] VS Code, 64-bit edition (version 1.28.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 2.21.1

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.0 (API 24) (emulator)

• No issues found!

Error:
ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: type 'Transition' is not a subtype of type 'bool'
E/flutter (25785): #0      Get.to (package:get/src/get_main.dart:59:32)
E/flutter (25785): #1      _SplashScreenState.goToNextPage.<anonymous closure> (package:amack_v4_backend/ui/screens/splash_screen.dart:57:9)
E/flutter (25785): #2      _rootRun (dart:async/zone.dart:1180:38)
E/flutter (25785): #3      _CustomZone.run (dart:async/zone.dart:1077:19)
E/flutter (25785): #4      _CustomZone.runGuarded (dart:async/zone.dart:979:7)
E/flutter (25785): #5      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
E/flutter (25785): #6      _rootRun (dart:async/zone.dart:1184:13)
E/flutter (25785): #7      _CustomZone.run (dart:async/zone.dart:1077:19)
E/flutter (25785): #8      _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:1003:23)
E/flutter (25785): #9      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:23:15)
E/flutter (25785): #10     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)
E/flutter (25785): #11     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
E/flutter (25785): #12     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
E/flutter (25785):

Thanks for your issue, I checked this out this morning.
This is a problem with the latest version of Dart and ternaries.
transition: GetPlatform.isIOS? Transition.cupertino: Transition.fade,
In any programming language in the universe, upon finding a Boolean, the instruction checks that there is nothing in front of it before treating the response as a Boolean. A Boolean is only a Boolean if at the end of the line (with a comma or semicolon) it still remains a Boolean.
It turns out that when it finds GetPlatform.isIOS, the compiler just stops, and treats it as an answer instead of checking if it is a ternary.
It's a behavior that shouldn't happen in any language, it didn't happen in Dart until the last development version, but I'll fix it on my own now, and I'll open an issue in dart: lang.

fix on version 1.14.1-dev

Firstly Thank you very much for this awesome plugin , thank you for replying very fast in this issue.
i see this problem in dart in this line :
   transition: transition ?? GetPlatform.isIOS
            ? Transition.cupertino
            : Transition.fade,

fix on version 1.14.1-dev

I will check it nw and tell you 👍

fix on version 1.14.1-dev

I Test it nw and its work very good Thank you for fast fix.  ❤


Avoid having to return anything in StartupBase.ConfigureServices

This is more a proposal than anything else, as it's a breaking change. Maybe it could go in as part of 2.0?
For the vast majority of the time, when deriving from StartupBase you don't need or want to provide a custom IServiceProvider. You usually just call (and return) base.ConfigureServices(services) or services.BuildServiceProvider(). This is just noise and should be handled by the framework IMO.
This proposal makes the IStartup.ConfigureServices implementation explicit and adds a method, CreateServiceProvider to StartupBase that the user can override if they want to customize the provider.
It also aligns StartupBase and StartupBase<TBuilder> by having the latter derive from the former and override the new CreateServiceProvider method.
// @davidfowl

@khellang,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

I like it.

The only special thing we need to do it register the service collection in the container like this:
https://github.com/OrchardCMS/Orchard2/blob/3d77b2184e3bc4774aba0b42e5a5a2219db94cd4/src/OrchardCore/Microsoft.AspNetCore.Modules/Extensions/ModularServiceCollectionExtensions.cs#L20
So as long as we still have access to it we should be good. We actually don't even use the default StartupBase base class in the modules, we still use our own which has the same method names.

So as long as we still have access to it we should be good. We actually don't even use the default StartupBase base class in the modules, we still use our own which has the same method names.

That's not confusing at all 😄

It's not confusing they explicitly implement our IStartup or inherit from StartupBase. In a standard web app it's more confusing as it's convention based.
https://github.com/OrchardCMS/Orchard2/blob/master/src/OrchardCore/Microsoft.AspNetCore.Modules.Abstractions/Startup.cs
But I want to change it to the way the standard Startup files are used (by convention, not our own implementation).

@sebastienros It's confusing because there's another StartupBase in Hosting that doesn't match.

@davidfowl Any word on this making it into 2.0?

Also, if you decide to pull this, it would be cool if you reconsidered including this as part of the templates as well. I think It's a much better default to steer people away from magic convention based methods. Especially now that a lot of the drift of the 1.x templates has been removed (like ILoggerFactory and IConfiguration setup).


docs(optimization): clarify deterministic value for moduleIds

Fixes #3420
deterministic value is implemented in webpack 5. but it is not mentioned anywhere hence clarifying its reference.

Thanks!