[hipclang] Adding the "-x hip" hipcc option to use when compiling HIP source files with hipclang

/cc @sunway513

Can one of the admins verify this patch?

LGTM, let's wait for the CI, thanks @deven-amd.
CC @yxsamliu


Make narrator read variable explorer and package manager

Will bind AutomationProp.Name in XAML for package manager as well.

👍


cnct: add resolver constructors

This PR makes the instantiation of resolvers stricter and thereby opens up the path to also add initialization logic to a resolver.
Spin off of #3644

Now the resolvers are really ready to get their reports initialized in their (new or decode) constructors


QV for each ccs reads

Hi,
Many thanks for the amazing tool !
I just wonder it is possible to output the QV for each deepconsensu ccs reads?
Here is the pbccs output : @m64079_220112_082130/103153878/ccs np=19 rq=0.999962, it contains the np and rq information for each reads.
However, for deepconsensus output: @m64079_220112_082130/103153878/ccs, no other information contained, except for reads name.
I want to obtain the Q20 reads , Q30 reads and Q40 reads seperately. Can you point me how to deal with instead of running deepconsensus three times.
Best,
Wenfei

Hello @Wenfei-Xian ,
Really sorry for such a late reply. We had a long chat about what exactly to do to support this. Finally, we have decided to provide a command line option to filter reads at any given Q-point.
With the latest DeepConsensus release of 1.2.0 you can run:
deepconsensus filter_reads --help

Filter reads based on the base qualities.
Flags:
    --input_seq            Path to input fastq or bam file.
    --output_fastq         Path to output fastq file.
    --quality_threshold    A quality threshold value applied per read.  Reads with read quality below this will be filtered out.

And see the option to filter your fastq at any given q-value. Please give it a try.

Many thanks !!!!!


Chore: Version Catalogs

This changeset cleans up and refactors the build structure to work with Gradle Version Catalogs, and integrates the Elide Plugin for Gradle into the main build.
Changes enclosed:

[x] Assemble main catalog and fixup all deps/plugins to use it
[x] Embed protocol buffers for page/media/semantic use (Elide v2)
[x] Embed Gradle plugin as sub-build

Codecov Report

Merging #17 (782c644) into v3 (aabe77a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                 v3      #17   +/-   ##
=========================================
  Coverage     59.45%   59.45%
  Complexity      166      166
=========================================
  Files            33       33
  Lines          1349     1349
  Branches        132      132
=========================================
  Hits            802      802
  Misses          526      526
  Partials         21       21

Impacted Files
Coverage Δ

...alvm/src/main/kotlin/elide/server/SSRExtensions.kt
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb92412...782c644. Read the comment docs.


Video is not recorded for mobile devices with odd screen resolution

This is because of h264 codec particularity.

https://stackoverflow.com/questions/20847674/ffmpeg-libx264-height-not-divisible-by-2

Fixed.


Demo URL gives Server Not Found

Hi, I wanted to take a look at the Demo of your theme from here: https://getgrav.org/downloads/themes
The link in that page, http://grav.matthewblode.com.au/  gives Server Not Found error

I have changed the link to http://medium.matthewblode.com.au/ in blueprints.yaml


Building wifi hal code with WIFI_HAL_VERSION_3

REFPLTB-1457: Building wifi hal code with WIFI_HAL_VERSION_3
Reason for change: wifi_hal3.0 compilation for Turris-Omnia
Test Procedure: Build and test
Risk: low
Signed-off-by: KaviyaKumaresan<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/12993/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/45058/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/7928/ started

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/107056/

Smoke tests for ['build-tur-bb'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/107057/

Job started https://jenkins.code.rdkcentral.com/job/manual-verification-rdk-next/2153/

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/45111/ started.

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/107160/

Smoke tests for ['build-tur-bb'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/107161/


feat: update logo

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ ] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

the new logo has been modified slightly.
This pr brings the changes in and adjusts, puck, 404 and main logo accordingly.


[bug]  libc++abi: terminating with uncaught exception of type NSException

Describe the bug
2022-08-11 16:59:57.804 tauri-demo[21190:7222319] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[15]'
*** First throw call stack:
(
0   CoreFoundation                      0x00000001871d41cc __exceptionPreprocess + 240
1   libobjc.A.dylib                     0x0000000186f257b8 objc_exception_throw + 60
2   CoreFoundation                      0x00000001872a4488 -[__NSCFString characterAtIndex:].cold.1 + 0
3   CoreFoundation                      0x00000001872b10c4 -[__NSPlaceholderDictionary initWithCapacity:].cold.1 + 0
4   CoreFoundation                      0x00000001870dbed0 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 320
5   CoreFoundation                      0x00000001870dbd64 +[NSDictionary dictionaryWithObjects:forKeys:count:] + 60
6   VisionKitCore                       0x00000001fddb3e08 -[VKAnalyticsAnalyzerEvent coreAnalyticsDictionary] + 1208
7   VisionKitCore                       0x00000001fdd76b00 -[VKAnalyticsProcessor processAndSendEvent:] + 92
8   VisionKitCore                       0x00000001fdd6c7d8 __69-[VKImageAnalyzer _processRequest:progressHandler:completionHandler:]_block_invoke_2 + 1200
9   libdispatch.dylib                   0x0000000186ec8e60 _dispatch_call_block_and_release + 32
10  libdispatch.dylib                   0x0000000186ecabac _dispatch_client_callout + 20
11  libdispatch.dylib                   0x0000000186ed2330 _dispatch_lane_serial_drain + 672
12  libdispatch.dylib                   0x0000000186ed2ea4 _dispatch_lane_invoke + 392
13  libdispatch.dylib                   0x0000000186edd708 _dispatch_workloop_worker_thread + 656
14  libsystem_pthread.dylib             0x0000000187085304 _pthread_wqthread + 288
15  libsystem_pthread.dylib             0x0000000187084018 start_wqthread + 8
)
libc++abi: terminating with uncaught exception of type NSException
when I use Tauri and vite to create a demo app.
This crash was happening to me when I clicked on an image.
I'm on macOS 12.1 M1
Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
› OS: Mac OS 12.1.0 X64
› Node.js: 16.14.2
› npm: 8.5.0
› pnpm: 7.0.0-rc.6
› yarn: Not installed!
› rustup: 1.25.1
› rustc: 1.62.1
› cargo: 1.62.1
› Rust toolchain: stable-aarch64-apple-darwin
Packages
› @tauri-apps/cli [NPM]: 1.0.5
› @tauri-apps/api [NPM]: 1.0.2
› tauri [RUST]: 1.0.5,
› tauri-build [RUST]: 1.0.4,
› tao [RUST]: 0.12.2,
› wry [RUST]: 0.19.0,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:5173/
› framework: React
App directory structure
├─ node_modules
├─ public
├─ src-tauri
└─ src
Stack trace
No response
Additional context
No response

Duplicate of #2934 the only way to fix this is to update your macOS version to 12.3. This won't affect your users, only development.

for me, just run cargo tauri build, the error just disappears
Here are my steps to reproduce:
cargo install create-tauri-app
cargo create-tauri-app --template vue
cargo install tauri-cli

cargo tauri dev # Exception occurs shortly after app launch

cargo tauri build # error disappears

This looks like another bug @lucasfernog
2022-09-04 17:05:25.190 tiny-img[78957:1526941] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[15]'

In the tauri main file: src-tauri/src/main.rs:


Outdated cask: sling

Outdated cask: sling.
Info:

version: <IP_ADDRESS>8.
appcast url: http://webapp.movetv.com/config/desktopupdate/sling/osx/production/Sling-snowleopard-sparkle.xml.

Updated in #18417.


Fix typos

Summary of changes
I'll review the commits, so I mostly want to understand the "why" rather than the "what"
Checklist

[ ] New functions have typespecs, changed functions were updated
[ ] Same for documentation, including moduledocs
[ ] Tests were added or updated to cover changes
[ ] Commits were squashed into a single coherent commit
[ ] Notes added to CHANGELOG file which describe changes at a high-level

@bitwalker Any updates on this?

Thanks!

:+1: :tada:


Improve podEvictor statistics

As suggested in https://github.com/kubernetes-sigs/descheduler/issues/501#issuecomment-781967812, it would be nice to improve the pod evictor type to report eviction statistics for individual strategies. Some suggestions were:

Number of evicted pods (in this strategy): XX
Number of evicted pods in this run: XX
Total number of evicted pods in all strategies: XX

x-ref this could also be reported as Prometheus metrics (https://github.com/kubernetes-sigs/descheduler/issues/348)

I prefer to report the statistics in metrics. So we don't have to cumulative much in the pod evictor itself.

I am just suggesting that, since those metrics will have to be calculated somewhere, doing it in podEvictor makes sense because it already has access to the information. Metrics can then use the podEvictor instance to report them when requested.

@damemi I would be happy to contribute to this. Any docs highlighting the decision made to-date?

@a7i nothing concrete, though if you would like to put some ideas together and share a doc that would be a great place to start the discussion. Right now we have 1 metric pods_evicted that's reported by the PodEvictor after a run.
As suggested above, it would be good to have some similar reports on a per-strategy basis. From there we could probably even come up with some additional meta metrics that are specific to the different strategies themselves.

/remove-lifecycle rotten

/reopen

/remove-lifecycle rotten

I'd like to work on this issue if someone is working on it already 🙂  @damemi @ingvagabund

Not aware of anyone working on this atm. Although, this requires some design and probably starting some discussion (e.g. in a google doc). @damemi wdyt?

Yeah I think we have some good patterns started in the code for metrics reporting already that could be fleshed out more. @pravarag feel free to take this on if you'd like

It would be great to have the following:

pods evicted success
pods evicted failed
pods skipped
total pods under consideration

Overall and per strategy.

/assign

@damemi @ingvagabund I'm trying to replicate the eviction of pods in a local cluster for better understanding of the way statistics are currently being represented. I have a 3 node cluster with the resources not that much heavily utilized for the three nodes cluster, the stats stand here:
NAME            CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
<IP_ADDRESS>   161m         4%     3460Mi          26%
<IP_ADDRESS>   182m         4%     3849Mi          28%
<IP_ADDRESS>   149m         3%     4002Mi          30%

And here are the logs from descheduler pod,
->  k logs descheduler-7bdbc8f9b7-d9r46 -nkube-system
I0920 14:27:38.995798       1 named_certificates.go:53] "Loaded SNI cert" index=0 certName="self-signed loopback" certDetail="\"apiserver-loopback-client@1632148058\" [serving] validServingFor=[apiserver-loopback-client] issuer=\"apiserver-loopback-client-ca@1632148058\" (2021-09-20 13:27:38 +0000 UTC to 2022-09-20 13:27:38 +0000 UTC (now=2021-09-20 14:27:38.995739889 +0000 UTC))"
I0920 14:27:38.995912       1 secure_serving.go:195] Serving securely on [::]:10258
I0920 14:27:38.996045       1 tlsconfig.go:240] "Starting DynamicServingCertificateController"
I0920 14:27:40.554774       1 node.go:46] "Node lister returned empty list, now fetch directly"
I0920 14:27:40.973812       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:41.225473       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:41.500405       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:41.717340       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:41.823705       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:41.879063       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:27:42.198284       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1172m memory:1327634Ki pods:20] usagePercentage=map[cpu:29.974424552429667 memory:9.74255252448638 pods:18.181818181818183]
I0920 14:27:42.198333       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1044m memory:1137170Ki pods:12] usagePercentage=map[cpu:26.70076726342711 memory:8.344874004635447 pods:10.909090909090908]
I0920 14:27:42.198354       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1355m memory:1552914Ki pods:15] usagePercentage=map[cpu:34.65473145780051 memory:11.395720666245547 pods:13.636363636363637]
I0920 14:27:42.198369       1 lownodeutilization.go:100] "Criteria for a node under utilization" CPU=20 Mem=20 Pods=20
I0920 14:27:42.198380       1 lownodeutilization.go:101] "Number of underutilized nodes" totalNumber=0
I0920 14:27:42.198392       1 lownodeutilization.go:114] "Criteria for a node above target utilization" CPU=50 Mem=50 Pods=50
I0920 14:27:42.198403       1 lownodeutilization.go:115] "Number of overutilized nodes" totalNumber=0
I0920 14:27:42.198415       1 lownodeutilization.go:118] "No node is underutilized, nothing to do here, you might tune your thresholds further"
I0920 14:27:42.198439       1 descheduler.go:152] "Number of evicted pods" totalEvicted=0
I0920 14:32:42.198973       1 node.go:46] "Node lister returned empty list, now fetch directly"
I0920 14:32:42.261831       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.295166       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.336749       1 pod_antiaffinity.go:81] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.479844       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1172m memory:1327634Ki pods:20] usagePercentage=map[cpu:29.974424552429667 memory:9.74255252448638 pods:18.181818181818183]
I0920 14:32:42.479892       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1044m memory:1137170Ki pods:12] usagePercentage=map[cpu:26.70076726342711 memory:8.344874004635447 pods:10.909090909090908]
I0920 14:32:42.479914       1 nodeutilization.go:170] "Node is appropriately utilized" node="<IP_ADDRESS>" usage=map[cpu:1355m memory:1552914Ki pods:15] usagePercentage=map[cpu:34.65473145780051 memory:11.395720666245547 pods:13.636363636363637]
I0920 14:32:42.479930       1 lownodeutilization.go:100] "Criteria for a node under utilization" CPU=20 Mem=20 Pods=20
I0920 14:32:42.479941       1 lownodeutilization.go:101] "Number of underutilized nodes" totalNumber=0
I0920 14:32:42.479953       1 lownodeutilization.go:114] "Criteria for a node above target utilization" CPU=50 Mem=50 Pods=50
I0920 14:32:42.479963       1 lownodeutilization.go:115] "Number of overutilized nodes" totalNumber=0
I0920 14:32:42.479982       1 lownodeutilization.go:118] "No node is underutilized, nothing to do here, you might tune your thresholds further"
I0920 14:32:42.480009       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.516420       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.549396       1 duplicates.go:99] "Processing node" node="<IP_ADDRESS>"
I0920 14:32:42.595868       1 descheduler.go:152] "Number of evicted pods" totalEvicted=0

I wanted to check if I decrease the threshold values to 10 here, will that be a good way to replicate the pod evictions so that I can look at the current statistics log?

@pravarag in your logs you don't have any underutilized nodes, so lowering threshold won't help (there is already no nodes with all 3 below the set values). Instead, you want to raise the threshold values, so anything with usage under those values will be underutilized.
You also don't have any overutilized nodes, so you should lower the targetThresholds as well. For replicating evictions, cordoning certain nodes while you create test pods will help create the uneven distribution you want.

Thanks @damemi for the above suggestions. Also had few doubts about adding newer metrics. I've identified the changes will mainly take place in these files:

metrics.go - which will mainly include newer metrics that we want to put.
evictions.go - where the calculation of newer metrics will happen just like for pods_evicted

Now, do we also want to modify the logging w.r.t the new metrics that are to be added? Something to include in every strategy like this log?
And one more question: I could see that for the metric pods_evicted, the help says that we can calculate number of pods evicted per strategy and namespace as well. And I'm guessing the code for calculation needs to be added so, do we need an extra metric per strategy like pods_evicted_per_strategy ?
So far, I'm working on adding few new metrics like, pods_evicted_success, pods_evicted_failed, pods_skipped.

@pravarag I think that all sounds good, except we probably don't need a new log line for every new metric. An extra metric per strategy would be good to get pods_evicted_per_strategy, but you can probably just make that 1 metric with different labels for each strategy (that might be what you meant though)

@damemi,  I've created a draft pull request while I continue to make few more changes for the same.

/remove-lifecycle stale

/remove-lifecycle stale

It would be great to have the following:
* pods evicted success

* pods evicted failed

* pods skipped

* total pods under consideration

Overall and per strategy.

We would like to help to implement the following above metrics! @eminaktas
There is closed PR https://github.com/kubernetes-sigs/descheduler/pull/648 that submitted by @pravarag And I think it closed in favor of new descheculing framework as also discussed in https://github.com/kubernetes-sigs/descheduler/issues/753#issuecomment-1150133689.
How should we help/proceed here to implement these metrics? Are there any example to create a  plugin from scratch using the new descheculing framework?

/remove-lifecycle stale

Kind ping @pravarag 🤞 Any ongoing work on this?

it sounds like we've come back around to not needing single-run metrics. I think per-strategy metrics could be a good option though. ^1

I think this is a really cool idea! Any implementation idea on your mind? Are we supposed to create metrics per strategy? Like pods_evicted_STRATEGY etc.
Solution 1: Without duplication (use map)
func registerForStrategy(strategy string) {
	metric := metrics.NewCounterVec(
		&metrics.CounterOpts{
			Subsystem:      DeschedulerSubsystem,
			Name:           fmt.Sprintf("pods_evicted_%s", strategy),
			Help:           "Number of evicted pods, by the result, by the namespace, by the node name. 'error' result means a pod could not be evicted",
			StabilityLevel: metrics.ALPHA,
		}, []string{"result", "namespace", "node"})

    podsEvicted[strategy] = metric

	legacyregistry.MustRegister(metric)
}

Solution 2: With duplication (create CounterVec for each strategy)
PodsEvictedHighNodeUtilization = metrics.NewCounterVec
PodsEvictedLowNodeUtilization = metrics.NewCounterVec
PodsEvictedPodLifeTime = metrics.NewCounterVec
...

Waiting your thoughts!

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/reopen


Namespace Models

This pull request includes changes for namespacing models under App\Models. Feel free to commit any additional changes to the shift-27361 branch.
Before merging, you need to:

Checkout the shift-27361 branch
Review all pull request comments for additional changes
Thoroughly test your application

:warning: While Shift updated model references within your application code, you may reference models outside the code. Be sure to review your environment configuration, database, and queues for additional references.


Log a warning when repeat_interval is less than group_interval

This commit updates Alertmanager to log a warning when repeat_interval is less than group_interval for an individual route.
When repeat_interval is less than group_interval, the earliest a notification can be sent again is the next time the aggregation group is flushed, and this happens at each group_interval.
Fixes #3370

You can find more information about this in a blog post I wrote called Group wait, Group interval and Repeat interval.


[Feature Request] Container Sheets with similar design to Player Inventory and option to make party containers

Is it possible to make the Container Sheets have a similar design as the Player Inventory and add a search and sorting options. It would make it so much more friendly to manage and visually more appealing.
Also, an option to make party containers would be great. For example, if the party has a Carriage or a Bag of Holding that everyone frequently access, being able to make lets say a proxy character sheet accessible by everyone via a linked container item in their inventory like the backpack manager module once did would be great.

Eventually all sheets will be getting a redesign that includes the improved inventory sorting, grouping, and filtering system.
There is already group actors that can store items to act as a party container, or vehicle actors if they are storing their items in vehicles.

I second @SirAron111's request.
The group actor is a great start.  It would be nice to be able to add custom categories for improved organization.  One of the uses would be able to have PCs names as separate categories.  The usage model is to maintain a full list of party inventory and see what's available and which PC has different items.  My party uses D&D Beyond and currently have to maintain a spreadsheet to track who has what.  Integrating into Foundry Vtt would provide a lot of value.
A huge first step would be to integrate the Category capability that the module Inventory+ provided but is no longer maintained nor work with 3.0.
A further enhancement would be to have a Container that multiple Actor's sheets could link to and show as a Container in their Actor sheet.  This would avoid the need for a user to stay within their PC's sheet and not have to go find the group actor to open.
Thanks for all the great work and listening to this request.


[LIBSTELL] Use a more direct (i.e. no loops) implementation of mpi_calc_myrange

This is a further iteration of #240.

This is a fundamental and substantial change to a piece of code used by many routines.

I agree and therefore, I would say that it would be valuable to have this routine very well documented and almost obvious to understand.
In the suggested change, the assumptions and the approach are (I hope) quite explicitly documented and reasoned about. Please let me know if you think differently about this.
I also attached a stand-alone test program (test_mpi_calc_myrange) now that I used to verify that the computed mystart and myend are identical (for the probed parameter value ranges) to what the old implementation produced:
test_mpi_calc_myrange.zip
It is compiled with gfortran test_mpi_calc_myrange.f -o test_mpi_calc_myrange
and then run with ./test_mpi_calc_myrange and should then print all tests passed successfully.
I understand that it was not obvious from the previous iteration of this PR that the outputs are identical. Sorry for that.

Thanks! The use of integer math is intended, as the remainder of the division is explicitly handled via the work_remainder variable. Do you know a way to make it more explicit in the code that integer division is intended? (I assume that you are concerned about the division in work_per_rank = total_work / local_size, right?)


Fix 404 URLs in README.md

Hi there!
It looks like some of the URLs in the README.md file are 404ing. This PR removes missing links or updates them to new URLs where appropriate.

Thanks, will go through all the examples and clean things up in the next release.


fix: resize episode preview image

Description
Fix a bug where the episode preview images where not correctly sized and positioned.
Screenshot (if UI-related)
Before: the episode preview is not in its row and is displayed at the top of the page

After: the episode preview is at its right position

To-Dos

[x] Successful build yarn build
[ ] Translation keys yarn i18n:extract
[ ] Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

v2.0.0
GitHub release

Your semantic-release bot :package::rocket:


Allow CommitteeHotKey to be ScriptHash

Description
Resolves #3509
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[x] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

You'll also have to add this to the scriptWitsVKeyNeeded calculation

Sorry, I meant to say scriptsNeeded, since scripts don't have witnesses :s

@Soupstraw I may be mistaken but it looks like getConwayScriptsNeeded already accounts for these credentials by the use of credScriptHash on the CommitteeVoter? Please correct me if this is not the case.

@Soupstraw I may be mistaken but it looks like getConwayScriptsNeeded already accounts for these credentials by the use of credScriptHash on the CommitteeVoter? Please correct me if this is not the case.

yeah, looks good


Switching to riemann 2 from riemannjs

Brings back https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/1082 and uses tcp transport explicitly.

Pull Request Test Coverage Report for Build 4820

0 of 0   changed or added relevant lines in 0 files are covered.
15 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 89.23%

Files with Coverage Reduction
New Missed Lines
%

data-access-layer/event-logger/src/EventLogRiemannClient.js
1
90.48%

applications/operators/src/docker-operator/DockerService.js
14
82.72%

Totals

Change from base Build 4815:
-0.01%

Covered Lines:
9394

Relevant Lines:
10159

💛  - Coveralls


AZURE STACK AZURE ACTIVE DIRECTORY APPLICATION CREATION

Team, as per https://azurestack.blog/2019/01/lesson-learned-azure-stack-azure-active-directory-application-creation/ you need to add the required parameter “-AzureStackAdminCredential" when executing "Create-AADIdentityApp.ps1"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c085e86-242e-ac36-a611-3d379d3dcfb0
Version Independent ID: 4d455fad-dc6a-ed4f-75c0-f8a6118aa07a
Content: Before you deploy App Service on Azure Stack
Content Source: azure-stack/operator/azure-stack-app-service-before-you-get-started.md
Service: azure-stack
GitHub Login: @BryanLa
Microsoft Alias: anwestg

@jonathan-vella Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thanks @jonathan-vella.
This particular parameter ($AzureStackAdminCredential) is showing as Mandatory=$false in the Create-AADIdentityApp.ps1 script, with a help message of Scripts will prompt for credentials if not provided. I'd like to bring @apwestgarth into the conversation to comment before making any doc changes, as he owns the install script.
I was able to test the script far enough that it worked for me. Ie: to the point where Get-AzureRmUserRefreshToken() was called with an empty $AutomationCredential parameter, which calls the Add-AzureRmAccount() cmdlet cited as failing in the post. The comment for that call also says Prompts the user for interactive login flow if automation credential is not specified. When I ran it, it successfully prompted me for admin creds, and returned the refresh token.

I've discussed this with engineering as well, and they've confirmed my analysis. Please let me know though, if you feel there is something that needs to be updated in the article, or feel free to submit a PR against the article and I can review for merge. Thanks!
CXP #please-close.


Update to the latest core-graphics-rs and add a binding for CTFontCreatePathForGlyph()

This is needed for Pathfinder.
r? anyone

This change is

https://github.com/servo/core-graphics-rs/pull/100 must land first.

@bors-servo r+

:pushpin: Commit 5783a1b has been approved by emilio

:hourglass: Testing commit 5783a1bb7565482aab147f3f433207c0b2d5c37b with merge 270557d54452f51cd25f3cc2e641f62448602750...

:broken_heart: Test failed - status-travis

@bors-servo: retry

published

:hourglass: Testing commit 5783a1bb7565482aab147f3f433207c0b2d5c37b with merge c9c689be9ece12eb8899387aa690c8be8960c79d...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing c9c689be9ece12eb8899387aa690c8be8960c79d to master...

Thanks!


Datepicker: dependencies and issues

Starting from 6b8af5d6940f22b58119e6a735cdbe36c12f1bb5 the npm package is simply flowbite, but the datepicker plugin still relies on the old themesberg/flowbite package.
I know that this issue is related to the plugin rather than this repo, but the issues on that repository are disabled: I suggest you to enable them in the settings, and move this issue (and the others related to the plugin) there.

Hey @lrusso96,
I'll look into the matter.

@lrusso96 renamed to flowbite-datepickerstarting v1.4.6.


Update path to env, remove git command

Fixes for running in an Ubuntu Docker container where $JOSHUA is not a git repo

thx James for your PR, did you also try running the script with a "usual" $JOSHUA dir being a git repo?

Running it like that would work fine, but my use case is running inside a
container where just the Joshua runtime binaries have been copied over.
On Thu, Jun 13, 2019, 11:22 AM Tommaso Teofili<EMAIL_ADDRESS>wrote:

thx James for your PR, did you also try running the script with a "usual"
$JOSHUA dir being a git repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/joshua/pull/88?email_source=notifications&email_token=AAQUE2LCUPAJVMX7FTYWXGDP2JQ2XA5CNFSM4HXQGG32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUBT7Y#issuecomment-501750271,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQUE2PAT6AVIJ2U4NUOFK3P2JQ2XANCNFSM4HXQGG3Q
.

thanks @jamesewoo it's merged :)


Add a function to translate the MDL chiral flag into enhanced stereo groups

The "chiral flag" is a feature that was used in MDL v2000 mol files, but was superseded by Enhanced Stereo Groups, which are much more flexible, in the v3000 format.
It would be useful to have some infrastructure that allows us to "translate" the stereochemistry read from a v2000 mol block into Enhanced Stereo Groups. If my understanding of the related documentation is correct, this code should do the following:
For all atoms which are not already included in an Enhanced Stereo Group (these might have been defined at some point after reading the original v2000 input),

if the RDKit::common_properties::_MolFileChiralFlag property is set to "1", find or create the "ABS" Enhanced Stereo Group on the mol (which must be unique), and add the atoms to it.
if the RDKit::common_properties::_MolFileChiralFlag property is set to "0", create a new "AND" Enhanced Stereo Group, and add all atoms to it.

LGTM


Safe navigation operator and/or null coalescing operator not supported

Not sure if I should report this issue on the Haxe repo or here...
I'm using some new features from Haxe 4.3.0 in a project: safe navigation and null coalescing operators.
public function new(?options: CacheOptions) {
	defaultDuration = options?.defaultDuration ?? 0;
	keyPrefix = options?.keyPrefix ?? "";
	serializer = options?.serializer ?? {
		serialize: #if php Lib.serialize #else Serializer.run #end,
		unserialize: #if php Lib.unserialize #else Unserializer.run #end
	};
}

When instrumentation is disabled, the project tests work fine. Here is the PHP code that is generated by the Haxe compiler:
public function __construct ($options = null) {
	$tmp = ($options !== null ? $options->defaultDuration : null);
	$this->defaultDuration = ($tmp !== null ? $tmp : 0);
	$tmp = ($options !== null ? $options->keyPrefix : null);
	$this->keyPrefix = ($tmp !== null ? $tmp : "");
	$tmp = ($options !== null ? $options->serializer : null);
	$this->serializer = ($tmp !== null ? $tmp : new HxAnon([
		"serialize" => Boot::getStaticClosure(Lib::class, 'serialize'),
		"unserialize" => Boot::getStaticClosure(Lib::class, 'unserialize'),
	]));
}

But when instrumentation is enabled, I get errors on Java and PHP targets. The generated code has a different behavior:
public function __construct ($options = null) {
	CoverageContext::logExpression(1538);
	CoverageContext::logExpression(1539);
	$tmp = $options->defaultDuration;
	$this->defaultDuration = ($tmp !== null ? $tmp : 0);
	CoverageContext::logExpression(1540);
	$tmp = $options->keyPrefix;
	$this->keyPrefix = ($tmp !== null ? $tmp : "");
	CoverageContext::logExpression(1541);
	$tmp = $options->serializer;
	$this->serializer = ($tmp !== null ? $tmp : new HxAnon([
		"serialize" => Boot::getStaticClosure(Lib::class, 'serialize'),
		"unserialize" => Boot::getStaticClosure(Lib::class, 'unserialize'),
	]));
}

Notice how the $options argument is not checked anymore for a possible null value.
It triggers this kind of error:
# Java
Exception in thread "main" java.lang.NullPointerException: defaultDuration
        at haxe.jvm.Jvm.readField(C:\[...]/haxe/versions/4.3.0/std/jvm/Jvm.hx:347

# PHP
PHP Fatal error:  Uncaught ErrorException: Attempt to read property "defaultDuration" on null in C:\[...]\Cache.php:49

thanks for reporting!
my latest commit changed quite a few things (hopefully for the better!). those changes most likely come with a change in coverage results. please take a minute to go through your coverage report / source code to check for places where you disagree with new coverage results.
I plan to release version 1.2.0 soonish, so any feedback before that would be great!! - if time permits, if not there is always 1.2.1:).

Thanks for your efforts but it still doesn't work. Unfortunately I can't give you access to the initial code (it's a private project), but I have 3 other projects where you can see the problem appear.
https://github.com/cedx/cookies.hx (target: js)
https://github.com/cedx/webstorage.hx (target: js)
https://github.com/cedx/which.hx (targets: hl, java, js and php)
To reproduce the bug:

clone the repo
lix Install (or lix download if you get an error about the Install class not found)
lix install gh:AlexHaxe/haxe-instrument
remove the @:ignoreInstrument metadata from the code
lix Test (generated files go into the var directory)

On my private project, the initial issue was solved, but new problems appeared.
This worked very well:
abstract Errors(Map<String, String>) from Map<String, String> to Map<String, String> {
	public function new(?errors: Map<String, String>) this = errors ?? [];

	@:from static function ofError(error: Error) {
		final data: {details: Array<Array<String>>} = try Json.parse(error.data) catch (e) {details: []};
		return new Errors([for (entry in data.details) if (entry.length == 2) entry[0] => entry[1]]);
	}
}

But now the code does not compile anymore (unless I add the @:ignoreInstrument meta):
return new Errors([for (entry in data.details) if (entry.length == 2) entry[0] => entry[1]]);
// characters 67-71 : haxe.ds.Map<String, String> has no field push

sorry, for my inactivity.
I've been looking at the issues every now an then, trying to fix them. and I think at least for one of them I have a working solution.
for the other issue I've encountered there is currently no solution other then not add coverage instrumentation to safe navigation operations - at least until there is a fix / workaround for https://github.com/HaxeFoundation/haxe/issues/11246.


balena-yocto-scripts: Update to v1.17.0

Update balena-yocto-scripts from v1.16.3 to v1.17.0
Change-type: patch
Changelog-entry: Update balena-yocto-scripts to v1.17.0
Signed-off-by: Alex Gonzalez<EMAIL_ADDRESS>

@balena-ci I self-certify!


PR: Clear code_analysis_underline extra selections before painting new ones (Editor)

Description of Changes
This prevents a memory leak and sluggishness in the editor after some time.
Issue(s) Resolved

Fixes #15631
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@sphh, could you help me to see if this PR solves the sluggishness in the editor when underlining warnings and errors? Thanks!

I just added that line. I'll report back after I used Spyder for some time!

@ccordoba12: I now worked on Spyder 5.1.1 with this patch applied for a longer time. I have not experienced any increase in sluggishness over time. Looks like you squashed that bug! Thanks!!

Thanks for the confirmation @sphh!


Docode404 bean configuration

Adds the ability to set decode 404 globally by providing a bean in configuration.
Defaults to false
Fixes gh-124

Closing this because the reporter can not remember the use case.


Prepare for release v1.12.5

Prepare for release v1.12.5
Summary of Changes
Minor Changes:

bpf: Implement downgrading path from v3 to v2 backend map (#22416, @YutaroHayakawa)

Bugfixes:

Clear stale CNP status nodes if updates have been disabled (Backport PR #22500, Upstream PR #20366, @pippolo84)
docs: Update Cilium Sphinx RTD Theme reference (Backport PR #22500, Upstream PR #22321, @kimstacy)
Fail validate-cnp preflight check if a CiliumClusterwideNetworkPolicy is using an empty toEndpoints/fromEndpoints selector (Backport PR #22500, Upstream PR #21990, @thorn3r)
Fix bug that could lead to inconsistent pod IP information between agents, sometimes leading to a failure to decrypt IPsec traffic. (Backport PR #22308, Upstream PR #22127, @aanm)
Fix bug where configuring the API rate limiter options could fail when providing multiple options (Backport PR #22696, Upstream PR #22299, @thorn3r)
Fix Cilium fatal "Could not create or update CiliumNode resource, despite retries" on environments with enable-ipv4-egress-gateway (Backport PR #22308, Upstream PR #22298, @aanm)
Fix forwarding of the security identity by the DNS proxy which could cause random policy denials (Backport PR #22407, Upstream PR #22361, @aspsk)
Fix GC of CEPs that were not GCed by kube-apiserver (Backport PR #22308, Upstream PR #22213, @aanm)
fix: some tofqdn flags not being parsed (Backport PR #22500, Upstream PR #22346, @carloscastrojumo)
helm: Add relabelings config to ServiceMonitors and re-introduce node label on cilium/hubble metrics (Backport PR #22506, Upstream PR #22297, @chancez)
Improve garbage collection for FQDNs particularly with high-churn IP names such as Amazon S3. (Backport PR #22730, Upstream PR #22510, @joestringer)
Prevent cilium operator crash in AWS region with IPv6-only ENIs without subnet filters. (Backport PR #22308, Upstream PR #22075, @bimmlerd)

CI Changes:

.github: Explicitly set build-commits job runner image version and install libtinfo5 (Backport PR #22328, Upstream PR #22315, @chancez)
.github: fix bpf-checks on ubuntu-latest runner (Backport PR #22328, Upstream PR #22322, @julianwiedmann)
Fix CODEOWNERS (#22292, @michi-covalent)

Misc Changes:

.github/workflows: split the image tag update in two steps (Backport PR #22260, Upstream PR #22268, @aanm)
Add automatic creation of Cilium base images (Backport PR #22260, Upstream PR #22179, @aanm)
bpf: Remove FIB lookup for IPsec (Backport PR #22308, Upstream PR #22069, @pchaigno)
build(deps): bump actions/setup-go from 3.3.1 to 3.4.0 (#22486, @dependabot[bot])
build(deps): bump actions/setup-go from 3.4.0 to 3.5.0 (#22715, @dependabot[bot])
build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.1 (#22271, @dependabot[bot])
build(deps): bump github/codeql-action from 2.1.32 to 2.1.35 (#22497, @dependabot[bot])
build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#22632, @dependabot[bot])
build(deps): bump helm/kind-action from 1.4.0 to 1.5.0 (#22716, @dependabot[bot])
build(deps): bump KyleMayes/install-llvm-action from 1.6.0 to 1.6.1 (#22595, @dependabot[bot])
chore(deps): update base-images (v1.12) (#22167, @renovate[bot])
chore(deps): update docker.io/library/golang:1.18.8 docker digest to 0936e74 (v1.12) (#22198, @renovate[bot])
chore(deps): update docker.io/library/golang:1.18.9 docker digest to c492f6b (v1.12) (#22728, @renovate[bot])
daemon/cmd: Fix error handling for getting proxy port (Backport PR #22500, Upstream PR #22296, @christarazi)
doc: add section to show how to customize cilium-agent metrics (Backport PR #22308, Upstream PR #22178, @ArthurChiao)
docs: add instructions to build the base images from external forks (Backport PR #22500, Upstream PR #22304, @aanm)
docs: clarifications about CNCF maintainer status (Backport PR #22500, Upstream PR #22351, @lizrice)
docs: Clarify wildcards and subdomains in FQDN policies (Backport PR #22308, Upstream PR #22206, @felfa01)
docs: describe Cilium Feature Proposals (Backport PR #22500, Upstream PR #22443, @lizrice)
docs: Fix kubectl create output in docs after some deployments have moved from K8s "extensions" to "apps". (Backport PR #22500, Upstream PR #22002, @cleverhu)
docs: update roadmap for graduation application (Backport PR #22500, Upstream PR #22422, @xmulligan)
fix 'egressIP' field indentation (Backport PR #22500, Upstream PR #22303, @yulng)
gha: Pin ubuntu-20.04 for conformance-test-ipv6 (Backport PR #22328, Upstream PR #22324, @sayboras)
Google Season of Docs is now over so it is removed from the docs (Backport PR #22500, Upstream PR #22442, @xmulligan)
Include DeleteNetworkInterface in ENI Required Privileges Docs (Backport PR #22500, Upstream PR #20472, @espringsteen)
k8s: don't consider 4xx a successful interaction (Backport PR #22500, Upstream PR #22393, @bimmlerd)
mtu, node: fix build on all non-linux platforms (Backport PR #22308, Upstream PR #22232, @tklauser)
pkg/datapath: return specific error message (Backport PR #22308, Upstream PR #22137, @aanm)
Update documentation related to metrics; fix incorrect FQDN metrics reference (Backport PR #22308, Upstream PR #22300, @christarazi)
v1.12: Update Go to 1.18.9 (#22599, @tklauser)

Other Changes:

install: Update image digests for v1.12.4 (#22238, @michi-covalent)
v1.12: Update k8s versions in tests and vendored libraries (#22581, @tklauser)

Failing smoke test is https://github.com/cilium/cilium/pull/22774. Prior tests OK. Merging.


Remove native docker tests that no longer apply

We no longer process create events, so remove tests that explicitly
tested create events.

LGTM

LGTM


ListView Component

See #70
This task is to track the implementation of a ListView component, similar to React Native's FlatList. In particular I'm interested in providing a ListView implementation that can handle rendering large lists efficiently by only rendering visible content and not allocating thousands of blueprint::View's that are not shown. I anticipate this involving a ScrollView somehow and may need some clever native component

Coming back to lay down some more thoughts on this. Generally, my view on this component is: let's do the simplest thing first.
In my head, ListView could really essentially be just a ScrollView with a bunch of Views inside of it. For example...
class ListView extends Component {
  render() {
    return (
      <ScrollView>
        <ScrollView.ContentView>
          {this.props.children}
        </ScrollView.ContentView>
      </ScrollView>
    );
  }
}

and the user of such a component would just do
<ListView>
    {this.props.items.map(function(item) { return <View><Text>{item.text}</Text></View> })}
</ListView>

or whatever they want.
In practice, if that were our only goal here, I would maybe push for not even adding a ListView component to the core library, since it's easy enough for a user to write themselves. Of course, that's not the only goal.
My intention for a ListView component is for the case where the above implementation crumbles under load. Imagine a sample browser implemented above with thousands of samples. Can the above implementation handle it? What does it cost us from a performance perspective? In the above implementation, we would be rendering thousands of View's that the user can't look at at one time. Is there a need for performance optimization there?
So, what I envision is something like this:
<ListView>
  {this.props.samples.map(function(sample) {
    return (
      <ListView.Item><Text>{sample.name}</Text></ListView.Item>
    );
  });
</ListView>

Internally, ListView is maybe a composition over a ScrollView, or maybe it's a native component with an implementation quite like the native ScrollView component. ListView.Item is likely just a View.
With that, let's render a list of 10k items and see how it feels, measure the CPU. I suspect (1) the js side of that will be sluggish, and a shouldComponentUpdate will become extremely important. (2) Drawing all those views out of bounds of the parent will be sluggish. Maybe there's a win there to just only addAndMakeVisible the child views that we know to be within the bounds of the scrollview (+ a little extra on either side for smooth scrolling).
If these hunches are wrong, or if that don't get us reasonable rendering for 10k elements, we might have to go back to the drawing board. I have some ideas for this case as well, but I don't want to go down this path until we know we need to.

@nick-thompson, This is excellent thanks for the ideas. OK.  Then I can look at the state of the world with large object lists and have a look at the second implementation approach. Leveraging addAndMakeVisible based on child View sizes and scroll position sounds like a nice first attempt.
Will tackle this over the weekend and let you know how things go.

@nick-thompson, I'm going to look at this in my next sprint from Monday.  I suspect this is going to become important for us as we'll have cases where I may switch between 2 reasonably large lists of elements based on some category filter or similar. i.e. get all samples from library A, get all samples from library B. In this instance a virtualized list is going to be really important.
I have a simple scroll view implementation at the moment so I'll render 10k items rather than my current 500 and get some metrics and then imitate a "category switch" to render the list again with an alternate set of items. I suspect performance will crumble at this point.
Could you just clarify where you envisage the use of shouldComponentUpdate helping here? On the List.Item components?

Awesome, yea, this will be a good test :)
I think shouldComponentUpdate on the top ListView will be ideal: best not to even try rendering/reconciling 10k children if the props at the ListView level haven't changed.
Another thought that I'm just having right now– it might be best, at the time that you switch from A to B or vice versa, to only re-render with the first ~50 items. Maybe the new this.props.samples is only 50 items at that point. Then the render-on-switch cost will be mitigated, and you could do something like in componentDidUpdate check if you just made a switch and only have 50, and if so, do a setState to load the next batch. Still might get really sluggish as that list of children gets into the thousands, but wonder if it would help

@nick-thompson , another one that probably doesn't need to be beta. Will remove and correct if you think it should be.

Right that makes total sense. @JoshMarler I'm going to mark this as assigned to you while you're on it to hopefully prevent duplicate work. And I'll add a CONTRIBUTING.md file shortly to clarify that workflow!

Adding this to the beta milestone as we're already almost there #192 !

Done in #192!

Done in #192!


Duplicate events in Splunk - aligns with context deadline exceeded (Client.Timeout exceeded while awaiting headers) error timeline

Describe the issue you're reporting
Description
We are seeing duplicate events in Splunk.
logging method : GKE container logs > otel > Splunk cloud  via HEC
Otel Version : 0.70.0
Updates made so far but no luck

Increased queue size for HEC inputs to reduce server errors
Upgraded Otel Collector to 0.70.0 ( few months back )
Increased timeout to 20s  on Otel collector
Upgraded Splunk Cloud to latest version 9

We are seeing a lot of "exporting failed", context deadline exceeded. These errors aligns with our duplicate events timeline in Splunk. PFA.
2023-05-07T04:38:43.999Z	info	exporterhelper/queued_retry.go:426	Exporting failed. Will retry the request after interval.	{"kind": "exporter", "data_type": "logs", "name": "splunk_hec/platform_logs", "error": "Post "https://.splunkcloud.com/services/collector": context deadline exceeded (Client.Timeout exceeded while awaiting headers)", "interval": "6.098075932s"}
Expected Result
No duplicates in Splunk
Actual Result
Many duplicates in Splunk, specially when indexer cluster going under rolling-restart

@dbhojani is the splunk hec healthy? have you noticed anything strange in splunkd logs? The exporter is saying that HEC is not responding

@VihasMakwana We have very large environment with 135 indexers and 40+ TB of day per day. So it could be possible that sometimes it become unresponsive throwing "server busy error" , we did work with Splunk support & they suggested increasing HEC queue size, that we already did few weeks back. That has reduced the "server busy errors" in internal logs. However, specially during cluster restarts , we are still getting some "server error" when HEC is busy.
My concern is, we get duplicate events which aligns time same time when we get "client timeout" in otel logs ?

@VihasMakwana
Thanks for the quick response.
We have very large environment with 135 indexers and 40+ TB of data per day. So it could be possible that sometimes it become unresponsive throwing "server busy error" , we did work with Splunk support & they suggested increasing HEC queue size, that we already did few weeks back. That has reduced the "server busy errors" in internal logs. However, specially during cluster restarts , we are still getting some "server error" when HEC is busy.
We have had timeout settings updated to 20s in Otel configurations as per Splunk team's suggestion.
My concern is, we get duplicate events which aligns time same time when we get "client timeout" in Otel logs ? Could this be a bug ?

Maybe, I'm looking for any bugs right now, are you using default values.yaml?

Sorry for the delay.
Yes, most configs are default. We do have some index based routing configured but nothing specific other than that.
Also, we recently upgrade otel to 0.76.0 version but no luck. Don't see much improvement in duplicates.

We are seeing the same on ROSA version 4.13.
On the agent pods:

2023-06-13T17:41:01.990Z error prometheusexporter/prometheus.go:139 Could not get prometheus metrics {"kind": "receiver", "name": "receiver_creator", "data_type": "metrics", "name": "smartagent/coredns/receiver_creator{endpoint="[REDACTED]"}/k8s_observer/720f4fee-c514-4900-9ffc-e302508f85a4", "error": "Get "https://[REDACTED]/metrics": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)", "monitorID": "smartagentcorednsreceiver_creatorendpoint[REDACTED]k8s_observer720f4feec51449009ffce302508f85a4", "monitorType": "coredns"}

On the cluster receiver pod:

2023-06-13T17:39:31.664Z error dimensions/dimclient.go:246 Unable to update dimension, retrying {"kind": "exporter", "data_type": "metrics", "name": "signalfx", "error": "error making HTTP request to https://api.[REDACTED].signalfx.com/v2/dimension/container.id/[REDACTED]//sfxagent: Patch "https://api.[REDACTED].signalfx.com/v2/dimension/container.id/[REDACTED]//sfxagent": net/http: invalid header field value for "X-Sf-Token"", "URL": "https://api.[REDACTED].signalfx.com/v2/dimension/container.id/[REDACTED]/_/sfxagent", "dimensionUpdate": "{name: "container.id"; value: "[REDACTED]"; props: {container.status: "running"}; tags: map[]}", "statusCode": 0}
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/dimensions.(*DimensionClient).handleDimensionUpdate.func1

@dbhojani I don't feel like this is a bug, the error context deadline exceeded (Client.Timeout exceeded while awaiting headers) seems to be related to with networking.
I have a thing to confirm, is duplication correlated to server error" when HEC is busy??

Is duplication correlated to server error" when HEC is busy??  -- Yes.

If the events are duplicated and you're not sending the same event twice then this seems like an issue with the server or network, could be anything.
The above error means that the client i.e. our collector can't reach the server for whatever reason (DNS, firewall, etc)

Hey @dbhojani can you check if these duplicated events are really the duplicated events or are they a little different based on its _time? My idea here is that sometimes events look like they're duplicated, but in fact they're a little bit different based on the time it originated. An example:
I run the query in Splunk to check the duplicated logs: index=em* | stats count by _raw, index, sourcetype, source, host | where count>1
And get some results:

They look like duplicates:

But in fact their timestamps are a little bit different:
splunker@i-0205459173e833a3f:~$ sudo cat /var/log/pods/kube-system_calico-node-rwtzd_17114d78-197d-40dd-a25d-1c1b37bf6756/calico-node/0.log | grep "2023-08-07 08:59:27.216" | grep "tunnel-ip-allocator/watchersyncer.go 209: Received InSync event from one of the watcher caches"
2023-08-07T08:59:27.217196627Z stdout F 2023-08-07 08:59:27.216 [INFO][80] tunnel-ip-allocator/watchersyncer.go 209: Received InSync event from one of the watcher caches
2023-08-07T08:59:27.217207676Z stdout F 2023-08-07 08:59:27.216 [INFO][80] tunnel-ip-allocator/watchersyncer.go 209: Received InSync event from one of the watcher caches

In splunk you can see it under time field:

Can you confirm this is not the case?

@dbhojani please open a support case to follow up so we can engage with you. I am closing this issue as inactive.


✨ Feature Suggestion |

Description
Two factor authentication section.
I see alot of people asking what to use for two-factor auth, or most of the time they are talking bout TOTP. I think there should be a section under Software for this.

We are working on something for this, that will soon be revealed.


[SourceControl] Allow overriding git URL during cloning

~ rdar://problem/33243973 Investigate SwiftPM solutions to better interop with private-mode GHE
Will add tests after review

Don't think we're doing this. We need to re-evaulate this problem.


Connecting the "finished" signal to "queue_free" on a particle system crashes the editor after a one-shot

Godot version
4.2.dev5.mono
System information
macos 12.6.8 - vulkan
Issue description
I'm attempting to create one-shot particle VFX (explosion bursts) that clean themselves up so all you have to do is instantiate them. If you connect the "finished" signal to "queue_free" on the root, this crashes the editor after triggering the one-shot bool to visualize it. I'm guessing it's attempting to free the root, but since this isn't an instance in a runtime game, something weird happens.
Steps to reproduce

Create a scene that inherits from GPUParticles2D.
Set the lifetime to 1s and enable one-shot mode
Connect the signal "finished" to "queue_free" on the root node
Turn the "emitting" bool on

Minimal reproduction project
N/A

Duplicate of #81320


default sjsconfig to {}

This has bug me for a while. :p
Handle case where typescriptOptions is not set in System.config({...}).

Thank you!


Py3

[Current coverage][cc-pull] is 100%

Merging [#68][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #68   diff @@
===================================
  Files           7     7
  Lines         312   320     +8
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits          312   320     +8
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [50f1057...c195b7d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ascribe/transactions/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ascribe/transactions/compare/50f1057c59c94f3dce98fbd16303ba13bc0fcf72...c195b7d5009b5e2d751a54ac83af72fa937fa75e
[cc-pull]: https://codecov.io/gh/ascribe/transactions/pull/68?src=pr


Nested repositories handling regression.

Seems it is related to 'Handling outside ignore rules (.gitignore global file)'.
If you have git repository at /some_dir/repo_a with .gitignore file containing the only line 'repo_b', then
if you have another repository at /some_dir/repo_a/repo_b, all files in repo_b are marked as ignored.
In version 1.0.2 this was working as I expected and only files listed in /some_dir/repo_a/repo_b/.gitgnore were marked as ignored.

If you have a project in which project base dir points to the /some_dir/repo_a/ it's quite natural that it will mark repo_b inside it as ignored - isnt' it ?

No it isn't. At least since there is another repo in that dir. For example, we have a project which uses a shared component. Both of them are stored in the separate git repositories. Project requires the shared component to be somewhere inside (i.e ./modules/shared_component).
When I make changes in files inside and outside that dir, IntelliJ is smart enough to understand that files inside that dir don't belong to the project itself but only to the shared component. So when I press commit/push button, it splits changes between these repositories correctly and prepares pushes to both repositories.
At the same time, .ignore-plugin did the same until the latest update.
I hope it is possible to do one of:

leave the previous behavior at least for nested repositories (seems that the added functionality is useful for someone in case of nested directories, not repositories. Otherwise, why was it added?)
add an option to disable that path inheritance functionality completely.

I am encountering the same issue. I have several sub-modules included in the main project's git. The sub-module directories are sub-directories of the main project but these directories are not included in the main project's git repository. Instead, they are added as sub-modules in IntelliJ under "version control" VCS directory mapping. I have defined these submodule repositories so that IntelliJ handles commits and pushed properly.
All the files in sub-modules show up as ignored even through they are part of VCS operations. Disabling file status coloring in .gitignore plug-in is a simple work-around.

+1
Looking forward for a hotfix.

Ok, I've made a change that introduces for each module a separated ignore scope. Quick preview below:
Ignore rules:
.gitignore
*
!.gitignore

Submodule/.gitignore
foo.txt

What do you think ?

Looks good to me and I've also hit this issue and am eager to get my colors back :-)
Thanks for the nice plugin!

Thanks hsz for such a quick response. This sounds great.
I hope there won't be any bad impact on existing logic.

If it respects intellij's vcs source roots, then it's totally ok for me. Thanks!

@Grief
Ok, I've switched from submodules to VCS roots as you've mentioned - that's better case.
@CodingAspect
There will be no bad inpact - it's additional feature. I just reset the ignore scope when any sub-VCS root appears in the project.
I'll release it in a few days.

Fix has ben released just right now with v1.1.2

Thanks @hsz ! It works.


Wiki

The wiki does not seem to load, i,e, it keeps saying "(loading icon) Loading wiki"

Wiki restarted


Upignore precedence

need to dig into this, in go-archive everything seems fine, however with up you can't do the following to ignore ./node_modules
!node_modules/** ## added by Up by default
node_modules

false alarm

Is this bug closed in 0.2.4? I still seem to be having a problem!
https://github.com/kaihendry/count/blob/master/.upignore

@kaihendry you're ignoring everything on line 2

@hhsnopek your suggestion still doesn't appear to work.. https://github.com/kaihendry/count/commit/b2aece3276264705c07a42c4a2979c6c098adb6f

hmm, can you tell me which files are suppose to upload and the output of the deployment is? up -v

~/go/src/github.com/kaihendry/count$ git rev-parse HEAD
b2aece3276264705c07a42c4a2979c6c098adb6f
~/go/src/github.com/kaihendry/count$ up build -v

     23ms    DEBU up version 0.2.4
     0s      DEBU region from aws shared config "ap-southeast-1"
     0s      DEBU track "Build" map[os:linux arch:amd64 version:0.2.4]
     0s      DEBU event platform.build map[]
     0s      DEBU event hook map[name:build]
     1.043s  DEBU hook "build" command "GOOS=linux GOARCH=amd64 go build -o server *.go"
     0s      DEBU event hook.complete map[name:build duration:1.04307339s]
     135ms   DEBU injecting proxy
     0s      DEBU open
     0s      DEBU filtered .git – 4096
     0s      DEBU filtered .travis.yml – 345
     0s      DEBU filtered .upignore – 18
     0s      DEBU filtered Dockerfile – 248
     0s      DEBU filtered Makefile – 301
     0s      DEBU filtered README.md – 90
     1ms     DEBU add _proxy.js: size=931 mode=-rwxr-xr-x
     0s      DEBU add byline.js: size=4710 mode=-rwxr-xr-x
     0s      DEBU filtered count.service – 316
     0s      DEBU filtered docker-compose.yml.template – 141
     0s      DEBU filtered ecs – 4096
     232ms   DEBU add main: size=11325129 mode=-rwxrwxr-x
     0s      DEBU filtered main.go – 3505
     0s      DEBU filtered out.zip – 6920020
     205ms   DEBU add server: size=8295059 mode=-rwxrwxr-x
     0s      DEBU filtered static – 4096
     1ms     DEBU add up.json: size=43 mode=-rw-rw-r--
     0s      DEBU stats dirs_filtered=3 files_added=5 files_filtered=9 size_uncompressed=20 MB
     4ms     DEBU close
     0s      DEBU event platform.build.zip map[duration:577.007983ms files:5 size_uncompressed:19625872 size_compressed:6920020]
     2ms     DEBU removing proxy
   ⠦ 0s      DEBU event platform.build.complete map[duration:1.622202502s]
~/go/src/github.com/kaihendry/count$ cat .upignore
*
!static/main.js
~/go/src/github.com/kaihendry/count$

Found a workaround, but is this the way .gitignore works too?! Seem non-intuitive to me..
$ cat .upignore
*
!static
!static/main.js


Windows. eval $(ssh-agent)

Hello, I'm working on Windows and have to make in each git-bash session commands:
eval $(ssh-agent)
ssh-add
Just then I have access for repo.
How can I execute this commands in Atom?
Now I have no access to repo with git-plus :-(

I have solved it with .bash_profile
Put into that file (located in home directory ~/)
evalssh-agent -s  ssh-add


Make test_eye more efficient

Part of #197

Thanks – I wonder how you'd feel about using from_dlpack to convert the output to numpy and then use something like np.testing to assert that the elements are equal? From what I can tell, from_dlpack is not an optional part of the API, so this should be better all around. What do you think?

OK, I removed references to nonzero – I opted for a fast path in cases that the tests succeed, falling back to a slow element-by-element test to generate an appropriate error message in case the test fails. What do you think?

Hmm, it looks like the more recent approach fails to correctly error on mismatched signed zeros.
It looks like the array API standard doesn't have anything akin to signbit, so I don't think there's any way to express the required logic efficiently via the array API. Seems like an oversight in the array API design, if I'm being honest.

It looks like the array API standard doesn't have anything akin to signbit, so I don't think there's any way to express the required logic efficiently via the array API. Seems like an oversight in the array API design, if I'm being honest.

xref https://github.com/data-apis/array-api/issues/670 - a stronger use case would help move that along, and also it looked like it wasn't available in JAX (maybe that was wrong?).

jax.numpy.signbit is implemented: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.signbit.html

Thanks for the link @rgommers! That would help to express this efficiently.
That said, I still think the best solution for the test suite would be to convert things to numpy via dlpack and use existing utilities in np.testing throughout. I understand the desire to make this not depend on numpy, but if that purity prevents the test suite from even being usable in some cases, the purity is not worth the cost.

Converting to numpy via DLPack only works well for CPU implementations though, there's no generic way to do it without introducing library-specific code for CuPy, PyTorch CUDA, etc. Of course there would be if x.to_device('cpu') would work, but that method is unfortunately one of the least likely to be available, nor is it guaranteed to accept the 'cpu' string.
That said: performance matters for this test suite. I also noticed last week that it was way slower than I had expected, and it makes it harder to use and contribute to. The numpy.testing utilities don't do anything particularly magical. We already generalized them for SciPy's needs: https://github.com/scipy/scipy/blob/ca135ae16ec6c8870f16b08d1a8eaca50418b1ac/scipy/_lib/_array_api.py#L277. I assume JAX has the same functionality too. How about we extend that and include such a function in the test suite here?

The numpy.testing utilities don't do anything particularly magical.

Understood, but numpy is a solid reference implementation, and numpy.testing already has the logic we're recreating here to print useful errors when arrays mismatch. Seems easier to just use that than to re-invent the whole thing, no?

I assume JAX has the same functionality too.

No, JAX uses numpy.testing for the reasons I mentioned above.

I think the core issue here is

A requirement of the test suite is to ensure that signs of float zeros match in some cases
There is no way to check that within the array API

...and so

The only way to implement these tests is via eager python iteration over array elements, which is sort of slow in numpy and prohibitively slow for other packages.

I don't think the lack of signbit should be a blocker here - and if so, let's add it to the standard asap. The signed zeros and other special cases can be separate tests, but should not impede vectorized checking a la assert_allclose for a large majority of test cases. @honno mentioned an issue dealing with nan comparisons too, which should also not be blocking - we can use isnan, ensure all present nan's are in the same locations, and then fill them.

No, JAX uses numpy.testing for the reasons I mentioned above.

Good to know. In SciPy we can easily add JAX support that way (and I assume we'll get to adding JAX support in SciPy at some point in the first half of next year).

Seems easier to just use that than to re-invent the whole thing, no?

I think using it unconditionally is tricky for the non-CPU cases, but if there's no better option than we should. We need vectorized checks. I think we can make it non numpy specific without too much trouble.
Also, as a data point, the SciPy xp_assert_close has led to several recent improvements to numpy.testing, because it turned out that the PyTorch version of assert_close was more strict than the NumPy one (e.g., it checks if .dtype's match), so it can be useful for things to be independent of numpy.

I had a closer look at assert_allclose and assert_array_compare, and while it's ~200 lines of code, I think it's doable to write that with array API standard primitives only. Which will also make the code quite a bit shorter, more readable and possibly faster, because we don't have to deal with ndarray subclasses, object, datetime and other non-numeric dtypes, strict/non-strict flavors, or non-default equal_inf.
We probably need only a couple of functions. In SciPy we found so far that we needed assert_allclose, assert_array_less and assert_equal. I'm tempted to take the relevant parts of https://github.com/numpy/numpy/blob/main/numpy/testing/_private/utils.py and array-api-ify them. Did anyone already try an exercise like that?

We just need to be careful that we minimize the number of array functions that we actually use in a test helper. Because

Any array library that doesn't implement one of the function wouldn't able to use the test suite at all.
The tests for those functions themselves will need to be implemented in the more naive way to avoid circularity.

If we are adding something like signbit as a new function, we may need to add conditions that fallback to handle the case where it isn't implemented yet. Doing that may be a good idea for other functions as well, especially if they aren't universally implemented (e.g., if there is a helper for it for some libraries in the compat library).

Thanks @asmeurer, that makes sense.
If you're worried about circular reasoning and/or complexity in the testing utilities, I think the natural solution would be to find a strategy to export the data to numpy and use numpy.testing in this test suite. That would sidestep all the concerns you have about building the evaluation tools from the building blocks you're trying to evaluate!

We need to take a pragmatic approach. Weird corner cases where the tests would technically pass aren't that interesting.
But helper functions using an array function that isn't implemented, causing every single test to fail is a very real concern. This sort of thing has already happened and it's why the test suite has some affordances for things like not every dtype being implemented (because pytorch doesn't implement uint64). We want to maintain the ability to use the test suite to produce reasonable results for the main NumPy or Pytorch namespaces (i.e., not just run against the compat library). Some functions, like asarray, are absolutely required, but we want to minimize that set of functions.
Similarly, a test function that just uses itself to test itself would pass with any possible implementation, not just weird corner cases. For example, https://github.com/numpy/numpy/issues/10322, is a wrong result from < (it comes from NumPy's value-based type promotion). We wouldn't be able to catch it except by having a test that actually tests the numerical values in a non-circular way.
But if there's only a handful of these base functions, we can test everything else indirectly using them.

I think we’re advocating for the same thing: an “export to numpy” function seems like it would be sufficient for all existing tests, and probably represents the minimum possible requirement in order to validate the API in a way that doesn’t lead to poor performance.

I'm tempted to take the relevant parts of https://github.com/numpy/numpy/blob/main/numpy/testing/_private/utils.py and array-api-ify them.

I have half an implementation and will complete it, but it does use a fair amount of API surface, so it doesn't quite meet the requirements @asmeurer and @honno have.
@jakevdp the current diff in this PR looks quite good. If you add signbit to it, can it pass all CI checks? If so, I think that's a good way to go here. If with that plus using --max-examples=1 as commented on in https://github.com/data-apis/array-api-tests/issues/197#issuecomment-1809955849 we can unblock all current development needs, I think we should be in good shape.

Thanks! With the addition of signbit (and some use of isnan) I think I could update this PR in a way that would replicate the previous behavior of the check without having to loop over array elements. How soon would a decision about adding signbit propagate to this package?

How soon would a decision about adding signbit propagate to this package?

I think we should be able to sort the decision on that out by Thursday evening, and then we can immediately add it.


Allow unauthorized preflight requests

A preflight request is done by browsers to determine if a server
accepts cross-origin requests and what the capabilities are in general.
If auth is required to access the Serrano resources, then the preflight
cannot require auth otherwise the subsequent POST would not happen to
actually do the authorization.
Signed-off-by: Byron Ruth<EMAIL_ADDRESS>

@chop-dbhi/harvest @chop-dbhi/harvest-collaborators Looking for a quick review by anyone.


Update with PSA Crypto 1.0.0 interface

Parsec service needs to be updated to use parallaxsecond/parsec-interface-rs#4.
The new interface introduced the alg parameter for sign/verify operations. The algorithm used for signing/verifying needs to be checked against the key policy (which has to be stored somewhere).

If the underlying API doesn't offer the option to retrieve said algorithm, we can probably repurpose the KeyIDManager to cover more key-related information (and potentially change it to KeyInfoManager)

About modification in the Key ID Manager and checking for policy I am thinking of the following things to do:

add integration tests, per provider, checking that PsaErrorNotPermitted is returned if:

the algorithm is not compatible with the type of the key
the operation is not permitted by the usage flags
the algorithm is not the permitted algorithm in the policy

modify the Key ID Manager trait and implementors to use a KeyInfo structure (instead of just the key ID):

/// Information stored about a key
#[derive(Serialize, Deserialize, Debug, PartialEq, Clone)]
pub struct KeyInfo {
    /// Reference to a key in the Provider
    pub id: Vec<u8>,
    /// Attributes of a key
    pub attributes: KeyAttributes,
}

for each operation, providers need to check if it is permitted and return PsaErrorNotPermitted if not. For that implements the following method on the KeyAttributes structure:

fn permits(&self, op: NativeOperation) -> bool

to check if the key permits the operation, ie the conditions on the first point are respected. That way, providers get the key attributes from the KIM, directly call this method and return PsaErrorNotPermitted if it's false.

I will also add here two things to check as part of this task:

[ ] ResponseStatus: check when it is adequate to return service ones or PSA ones
[ ] For each operation: check if the behaviour is as described in the API and update the book

Tests have been merged in #135

All updates are done! Last PR


HDDS-6265. Add arm64 architecture support for ozone-runner docker image

What changes were proposed in this pull request?

Improve Dockerfile to select the right dependencies based on build architecture.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6265
How was this patch tested?

[x] Test on x86_64
[ ] Test on arm64 (M1)

Thanks for working on this @smengcl. I have checked out this branch locally, built the image and ran a simple 5 DN cluster. So far it seems to be working well, and much faster on the M1 Mac.


fix(buffer): bufname conflict when creating a new buffer

Remove buffers for disposed editors before creating new buffers to avoid naming conflicts.
Fixes https://github.com/vscode-neovim/vscode-neovim/issues/1651
Before the fix
https://github.com/vscode-neovim/vscode-neovim/assets/16840190/f8188db1-2e18-4eab-9422-21c6a02a7fba
After the fix
https://github.com/vscode-neovim/vscode-neovim/assets/16840190/3bef4d45-a0fa-4b5e-a9bd-bfce1b606c9f

nice, I also encountered this error recently

Tested, it works.

This seems to break <c-^> - so jumping between the two last open buffers stopped working after installing 1.1.4. Installing 1.1.3 makes <c-^> work again normally. However, I'm not sure if it's related to my setup. I've configured it with nnoremap <Leader><Leader> <c-^> in my init.vim. Does this happen for you guys as well?

@fiddler You mean <C-^> was normal before?

Yup! It works for me on 1.1.3, but after updating to 1.1.4, it no longer works. It looks like it jumps inside the buffer instead of jumping to the other buffer - see the attached video.
https://github.com/vscode-neovim/vscode-neovim/assets/477113/5e591155-8984-4aac-929b-f34947a29210
PS. I noticed that directly using <c-^> in my VS Code does not work at all, but using it via the nnoremap <Leader><Leader> <c-^> binding works fine on 1.1.3 as shown in the video.

Not sure. From the internal implementation of vscode-neovim(The management and switching of window and buffer should be performed by vscode), C-^ should not work properly. It was a coincidence that it worked normally before.

Possibly relevant code:
https://github.com/vscode-neovim/vscode-neovim/blob/50e3692ec40fe9edb42f6bef02f5de23dfe607f0/vim/vscode-neovim.vim#L101
https://github.com/vscode-neovim/vscode-neovim/blob/50e3692ec40fe9edb42f6bef02f5de23dfe607f0/src/buffer_manager.ts#L306-L310


Add a basic sinatra webfrontend

Create a basic webfrontend to serve this to the web.
The frontend should contain a small form to set the variables (with, height, borders etc.) and an preformated outputarea for copy & paste.

Hi I would like to work on this for hacktoberfest. Could you please assign it to me?

Done :)

@dragonchaser Added a PR to Add the features requested.

Awesome work thx!


If you navigate the music mini-video using the seek bar inside the Youtube Embed, it breaks next song behavior

Reproduction
Be playing something using music feature
Navigate to somewhere on the YT Embed, but maybe within the song still
When the playback hits the end of the song,
Expect: navigate to next song
Actual: nothing happens.
Navigate to elsewhere on the YT embed, possibly AFTER the song that's currently playing
Expect: something to happen
Actual: seek % reaches 100%, nothing happens.
Reason:

we don't actually use progress to advance music, instead, we tell the YT Player { start:123 end: 412 } and rely on the @end event when YT playhead hits 412s. (incidentally, this should also save bandwidth since the player won't download more than video at 123~412 seconds)

However, navigating on the player's SEEK bar causes the YT player to forget "end:412" is a thing.

We probably should use progress to advance music in addition to this @end event emitted by YT player
watch out for double advancing.

Done


Add mygreatlearning.com for DSA tutorial

@avinash201199 here is the PR https://github.com/avinash201199/Free-courses-with-Certificates/pull/50


Mix multiple bar and line

Feature Proposal
I tried mix bar and line chart
What i want

I Created

Give me some solution. Thanks
Possible Implementation
No response

@CuongSofi have a look to SO: https://stackoverflow.com/questions/76060933/aligning-linechart-with-grouped-barchart-using-chart-js/76061773#76061773

@CuongSofi have a look to SO: https://stackoverflow.com/questions/76060933/aligning-linechart-with-grouped-barchart-using-chart-js/76061773#76061773

Thanks so much.


Default (or preferred) file extension for mimetypes

Hi there!
I was just using mimemagic to write a tool which fixes incorrect file extensions using MimeMagic's by_magic method, and it works quite well. There was one hitch though: MimeMagic doesn't contain the information about which file extension is most commonly used for the given mimetype.
This pull request is a quick hack where I moved the preferred extension to the beginning of the extensions array in TYPES, but I'm thinking that a better way to do this would be to create a new method/field for "preferred extension".
What do you think?

The table is generated. I won't add additional data on top of the data present in the freedesktop database, except for the overlay.


Observable Measurement - 1 - Settings

Part 1 of #2781

CI is happy. Any code review issues?

ptal!


Service Definition item (SustainmentReporting) exists without an associated hosted service

Hosted service SustainmentReporting/FeatureServer no longer exists, but associated service definition item exists; please delete the following item:
id: e952877f189145c88dff75024ea566fa
type: Service Definition
service: SustainmentReporting/FeatureServer

@helyx-rterry I deleted this item.


Use canonical name for changelog

Thanks so much for this useful library – and for extracting it from sinon!
Purpose (TL;DR) - mandatory
Give the changelog its canonical name so tooling picks it up.
Background (Problem in detail)  - optional

It's the name recommended by Keep a Changelog.
It's parsed automatically by tools like Dependabot and Greenkeeper.
It's automatically included in npm pack.
It's easier for developers to spot (see #216).

This looks very reasonable to me. Since it's what sinonjs/sinon does I'm going to go ahead and merge it.
Thank you for you contribution 🙏

For future reference the changelog is also referenced in the version build script at https://github.com/sinonjs/lolex/commit/53e32d410e3c0e6d18958b174394eb541d8aa71d

Thanks!

I already did this three years ago, but it basically got rejected as I didn't have any proper reasons for it, other than "it seems right". Finally the planets have aligned! :heart:


UI: Change position of stye and region menu

Style information should be placed below the video and subtitle area. User can either insert style information or position (region).

Fixed in release 0.4.0


Merge duplicates (same channel)

Duplicates appear in the list of available programmes. Unlike #228, however, I am referring to identical programmes on the same channel.
Example:
MaiThink X - Die Show - Sternstunden der Neolution - Teil 1
https://rodlzdf-a.akamaihd.net/none/zdf/21/10/211004_neolution_mai/2/211004_neolution_mai_3360k_p36v15.mp4

Mediathekviewweb 1x listed.
Zapp 2x listed.

Another example:
MaiThink X - Die Show
Kritisches Denken - mit Lutz van der Horst & Fabian Köster
https://rodlzdf-a.akamaihd.net/none/zdf/21/10/211022_kritisches_denken4_mai/1/211022_kritisches_denken4_mai_3360k_p36v15.mp4

Mediathekviewweb 1x listed.
Zapp 2x listed.

I can only find/see both programs once in Zapp.

I can't reproduce this issue either.

I'll close this for now. Feel free to open a new issue if this ever happens again.

This is an old one, but I could reproduce this issue and fixed it. There was an issue with the paging keys, so some entries (number 60 to 90 in the list) were loaded two times.


Apple ID with Daikin Cloud

Hi,
How it works with the Apple ID for Daikin Cloud ?
Thanks

I don't think Daikin provides a social login via Apple?
You should use the same credentials as you use to log into the Daikin app: https://apps.apple.com/be/app/onecta/id1474811586?l=nl
FYI: this plugin will only work if you can also log in to this app or the Android equivalent.

Yes, i use this app. And it provide the social login for Apple, Google, Facebook, Twitter and linkedIn.

In that case it would probably be best to also create a email/password based login for the same account and use that.
I don’t think social login works via the Daikin API or I would have to investigate.

It would be nice if you can investigate and integrate the social login into the code. In the meantime, I will see how to migrate my apple account to a Daikin account.

I don't think integrating social login into a Homebridge plugin is remotely possible nor easy to achieve. Having to log in with email and password stored in plaintext (current method of doing things) is also not recommended but a hell of a lot (1) easier to implement and (2) easier to manage.
I, personally, would suggest an API token approach if Daikin/Onecta offers this.

I have to agree with @Terabyte1385, there is AFAIK now easy way to implement social login via a Homebridge plugin to reach the Daikin API.
I'm going to close this for now. If new information/possibilities would arise to connect to the Daikin API we can create a new ticket.


Update ActiveDirectory Jespa integration sample

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


stream settings: subscribed-filter state is stickier than subscribed-filter UI state

1. Hover over any stream in the left-hand list. Click the dropdown arrow and select Stream settings.
2. Change the stream filter (upper left iOS-style radiobutton-group) from "Subscribed" to "All Streams".
3. Hit Esc.
4. Repeat step 1.
The stream-list within the settings dialog will show all streams, but the segmented-control will be reset to "Subscribed".
This was not reproduced on using the gear-dropdown in the upper right to enter the Stream settings dialog.

@zulipbot claim


Jump To Opened File Tab instead of Duplicating across Split Views

Type: Bug
I work in split view and view two files simultaneously. I jump around these file views like crazy and if I try to open a file I recently already opened, but in the other split view, Instead of switching view and selecting the opened tab of the file I want to jump to, VsCode opens a new duplicated tab on the split view I am currently at.
However, if the file tab I wish to open is in fact in the same split view I am currently at, the behavior is as expected, the file tab is jumped to without duplication.
I want the same behavior across several split views.
Over a session's work I have duplicated every single file tab across both views e.g. 32tabs (16 on each split view instead of 8 on each side). I often need to clean the tabs by closing all tabs manually just to clear my head.
I have the workbench.editor.enablePreview and workbench.editor.enablePreviewFromQuickOpen set to false as they are the only settings I've read that affect these behaviors but to no success..

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Error when running user is a Guest User

Describe the bug
I'm running into a INSUFFICIENT_ACCESS_ON_CROSS_REFERENCE_ENTITY error that is getting triggered from the context user. The user is a Guest User (it's a user that is used for a Stripe-Salesforce integration). I have set the rollups to run as a System user, but it still seems to be causing an error. I've also confirmed that the Guest User has permission to create and edit the objects.
I currently have the rollups running in Process Builder mode. The Process Builder and rollups work fine when I'm the running user, but fail when it is a guest user.
To Reproduce
Steps to reproduce the behavior:

I create a CO record, Stripe Event, from our website
The Stripe Event records are created, but the next process to create a Contact, and some COs fails because of the error above.

Expected behavior
The DLRS rollups to run as the system user and not the context user.
Screenshots
Additional context

I am experiencing a similar issue -- a client of mine has a self-registration visualforce page in which a Guest user creates a Contact as well as a CampaignMember for that Contact. There is also a Rollup Summary that rolls up information from the CampaignMember to the Contact. This is set as "Scheduled" (Calculation Mode) and "System" (Calculation Sharing Mode).
In the debug logs I can see that a future method is throwing an "insufficient access rights on cross-reference id" exception. It seems like it is happening right after the insert call on the "dlrs__LookupRollupSummaryScheduleItems__c" record.
This error goes away if I give the Guest user "update" access on the dlrs__LookupRollupSummary__c object. However, that is not a long term solution, since Salesforce appears to be retiring the ability to give the Guest Site user "edit" access on anything (https://releasenotes.docs.salesforce.com/en-us/winter21/release-notes/rn_networks_reduce_object_perms.htm).
Any advice on this?
Here is an excerpt from the debug log.
21:00:18.858<PHONE_NUMBER>)|FATAL_ERROR|System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, dlrs_CampaignMemberTrigger: execution of AfterInsert
caused by: System.DmlException: Upsert failed. First exception on row 0; first error: INSUFFICIENT_ACCESS_ON_CROSS_REFERENCE_ENTITY, insufficient access rights on cross-reference id: []
Class.dlrs.RollupService.updateMasterRollupsTrigger: line 977, column 1
Class.dlrs.RollupService.handleRollups: line 873, column 1
Class.dlrs.RollupService.triggerHandler: line 301, column 1
Trigger.dlrs_CampaignMemberTrigger: line 7, column 1: []

Follow-up on this. Another client of mine is experiencing the same issue. A guest site user creates a record (custom object). There's a Scheduled lookup that is set to run in System context, but an exception is thrown unless the guest site user has "edit" access to the Lookup Rollup Summary object:
11:11:57:000 FATAL_ERROR caused by: System.DmlException: Upsert failed. First exception on row 0; first error: INSUFFICIENT_ACCESS_OR_READONLY, insufficient access rights on object id: [a1I54000000SeQb]: []
(Note that a1I54000000SeQb is the id of a Lookup Rollup Summary Schedule Item record)

One of my clients has this as well. Using the Guest User account to submit a simple form by creating a record, which then should trigger the roll-up.  I tried adding the various permission set object permissions without any change. So long as the trigger was on the child object, it failed.  I tried setting to "System". I set  the rollup calculation mode to process builder, and which presumably turns off the trigger, but when I invoked it from within the process builder - it failed with the permission error again.
Is this a bug or a configuration issue?

@billerama @dnawas
FYI I changed my rollup from "Scheduled" mode to "Realtime" mode and this seemed to fix the problem for us. There is some custom @future apex code that runs for us, so not sure if that affects things.

Duplicate of #375


transcode uploads

High bit rate videos should be down-scaled before being uploaded. Here are notes on how to achieve that:

It's not necessary to deploy FFmpeg on Android. The Android APIs already have all the necessary functionality for analyzing and transcoding video. All modern phones have hardware-accelerated video transcoding built in. (This assumes that videos being uploaded from the phone were made on the phone and not elsewhere.)
The Android v10 API (level 28+) has a very nice video API. We assume that we cannot use this.
Any transcoding needs to be done on a background thread so that the UI can update progress. File analysis may also need to be done on a background thread; we are unsure at this point.
Things that the SDK presently verifies on a video file:
    A. Container is MP4 or WebM or OGV.
    B. Video encoding is H264 or VP8 or VP9 or AV1 or Theora.
    C. If Video is H264 we verify that the pixel format is yuv420p.
    D. Audio encoding is AAC or MP3 or FLAC or Vorbis or Opus.
    E. Faststart flag is set if container is MP4.
    F. Bit rate is below a customizable max, currently 8.4Mbps.
    G. Max volume is greater than -5 db and mean volume is greater than -22 db.
For now, make an assumption that none of the above are a problem except F. G will be difficult to test without FFmpeg, and modern phones should not produce videos outside any of the other parameters.
From the Android API we have MediaMetadataRetriever. The Retriever should be used to get the video resolution and duration and bit rate. The resolution and duration are needed by the Stream.update method in the SDK. (Don't let the SDK use Hachoir to get the width/height/duration.) The bit rate obtained there should be used for check #F above.
One way of lowering the video bit rate would be to lower the FPS. Some phones record video in 60 FPS or more. We can lower that to 30 FPS as one option. Another option is to reduce resolution to 1080p (or 1440p). In fact, you probably need both to get the bitrate down to a reasonable amount. 1080p@30FPS should be the target if the resolution is 1080p or more. 720p@60FPS should be the target if the resolution is 720p@120FPS or more. You need to use the MediaExtractor API to get the frames per second. That data is not available on the MediaMetadataRetriever (in the earlier Android API versions).
To transcode the video you need to use the MediaFormat and MediaMuxer APIs. Open the "video/avc" mime for the video encoder, set the max bitrate, possibly the average bitrate, the frame interval to 5, the frame rate to 30 or 60, the color format to COLOR_FormatYUV420Flexible. "avc" is phone-talk for H264. Almost all phones have a hardware-accelerated avc encoder (for the onboard camera). For the MediaMuxer, add all the tracks that are in the original video but replace the video track with the new one made from the MediaFormat object. Essentially, you want to copy all tracks but the video. For the video, you copy the old data into the MediaFormat object (one buffer-full at a time).
You're going to have to read through a lot of the examples on the web to see how to copy data into the MediaMuxer.

The Codec Info app is a useful comparison, and it will show you which encoders are hardware-accelerated. See https://github.com/Parseus/codecinfo

Transcoding implemention done using mobile-ffmpeg (https://github.com/tanersener/mobile-ffmpeg) in native app publish interface.

Did you verify that the mobile-ffmpeg implementation uses the hardware encoders? It's important that the transcoding doesn't happen on the phone's CPU.

As far as I could tell, ffmpeg does make use of MediaCodec on Android which is hardware accelerated.
ffprobe was pretty instantaneous as it returns media info in less than a second, and I was able to test the transcode using the ultrafast preset with pretty good results


Progress bar CSS snippet broken with Minimal 4.4.8

I have a custom CSS snippet for progress bars enabled.
However, with the new Minimal it seems like the theme's style is prioritized higher than my snippet.
How do I make my snippet work?

You will need to add more specificity, e.g. adding body at the beginning of the CSS rules
Please use #minimal channel on Discord for support questions


Remove deprecated server config keys

The following server config keys are removed:

pinot.server.starter.enableSegmentsLoadingCheck
pinot.server.starter.timeoutInSeconds
pinot.server.instance.enable.shutdown.delay
pinot.server.instance.starter.maxShutdownWaitTime
pinot.server.instance.starter.checkIntervalTime

Codecov Report

Merging #4903 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4903      +/-   ##
============================================
- Coverage     56.54%   56.48%   -0.07%
  Complexity       53       53
============================================
  Files          1178     1178
  Lines         62900    62885      -15
  Branches       9227     9225       -2
============================================
- Hits          35569    35520      -49
- Misses        24693    24731      +38
+ Partials       2638     2634       -4

Impacted Files
Coverage Δ
Complexity Δ

...pinot/server/starter/helix/HelixServerStarter.java
41.17% <ø> (-2.38%)
0 <0> (ø)

...org/apache/pinot/common/utils/CommonConstants.java
32.69% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../org/apache/pinot/client/PinotClientException.java
33.33% <0%> (-33.34%)
0% <0%> (ø)

...he/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

...pinot/broker/api/resources/PinotClientRequest.java
23.8% <0%> (-19.05%)
0% <0%> (ø)

...ller/validation/OfflineSegmentIntervalChecker.java
56.41% <0%> (-16.67%)
0% <0%> (ø)

...inot/client/JsonAsyncHttpPinotClientTransport.java
58.69% <0%> (-15.22%)
0% <0%> (ø)

...impl/dictionary/FloatOffHeapMutableDictionary.java
51.61% <0%> (-6.46%)
0% <0%> (ø)

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
44.08% <0%> (-5.38%)
0% <0%> (ø)

...ng/builder/DefaultRealtimeRoutingTableBuilder.java
61.9% <0%> (-4.77%)
0% <0%> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf7f64...951a12e. Read the comment docs.


Correcting metrics and adding tests

Modifications

Add additional testing for function stats
Corrected stats related to processLatency and lastInvocation to return null when appropriate such as when no messages have arrived yet

rerun integration tests