set onfido web full height

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/37622
PROPOSAL: https://github.com/Expensify/App/issues/37622#issuecomment-1979059438
Tests
Pre-requisite: user must be logged in and have created a workspace

Go to Workspace > Bank account
Select Connect manually, using the testing credentials
On Personal information, enter "First" and "Last" as first name and last name respectively
Enter any data on the other fields
On the double check page, confirm. It will take you to the Onfido page
Verify onfido show full remaining height (on web)
Accept the terms and continue
Select Passport option
Verify the button to take the photo is visible (on mobile web)

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Workspace > Bank account
Select Connect manually, using the testing credentials
On Personal information, enter "First" and "Last" as first name and last name respectively
Enter any data on the other fields
On the double check page, confirm. It will take you to the Onfido page
Verify onfido show full remaining height (on web)
Accept the terms and continue
Select Passport option
Verify the button to take the photo is visible (on mobile web)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
css file only affects on web

Android: mWeb Chrome
https://github.com/Expensify/App/assets/11959869/ff933484-2a6b-4d8d-b294-fc8e6668d47c

iOS: Native
css file only affects on web

iOS: mWeb Safari
https://github.com/Expensify/App/assets/11959869/53ea836e-1ad4-47b8-9813-0836248895cd

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/11959869/6c458914-7bcf-4b31-985f-1f80666c8784

MacOS: Desktop
https://github.com/Expensify/App/assets/11959869/cf5dddb8-d79b-49f5-b695-902d1275565f

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@akinwale have we got any feedback for this PR

I've done some testing on a physical Android device. Will test later today on an iPhone.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.69-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[BUG] using path param of type union breaks swaggerui

Describe the bug
Noticed this bug after 0.46 -> 0.47.1 update. Endpoint using a path parameter of type Union[int, str] causes Swagger UI 'try it out' to break emitting error in system.js:464 and showing spinner indefinitely:
Error: Required parameter param is not provided
    at index.js:3893
    at Array.forEach (<anonymous>)
    at Object.jn [as buildRequest] (index.js:3863)
    at actions.js:415
    at utils.js:137
    at bindActionCreators.js:3
    at wrap-actions.js:33
    at Object.r (system.js:174)
    at Object.executeRequest (system.js:461)
    at actions.js:458

To Reproduce
Steps to reproduce the behavior with a minimum self-contained file.
Replace each part with your own scenario:

Create a file with:

from typing import Union
from fastapi import FastAPI

app = FastAPI()

@app.get('/{param}')
def test(param: Union[int, str]):
    return param

Open the browser and call the endpoint /docs.
Press 'Try it out' of your endpoint.
Press 'Execute' without filling in the parameter.

Expected behavior
Notification about empty required parameter.
Environment

OS: Ubuntu 19.10, google chrome 79.0.3945.130
FastAPI: 0.47.1
Python: 3.8.1 installed with pyenv

Oh! That's fun. I was able to reproduce it. That's strange. But it's actually not an issue with FastAPI but with Swagger UI.
I added the issue here: https://github.com/swagger-api/swagger-ui/issues/5831
I'll close this issue as it is not really on the FastAPI side. We can track it there.


ci, setup: Switch remaining defaults to Bionic / Python 3

Remove Xenial / Python 2

This change is

Will merge if circleci passes, and Travis CI + Jenkins fail the same as in master.

It failed the same way as the other platforms, so this PR works in that respect.


Changing values of variables in an existing object

Hi,
I have an object  (instance of Actor class) in the scene that has some variables.
I would like to change the value of the variables AFTER the object is already created in the editor.
In the Python script, I have a reference to this actor via actor = ue.get_editor_world().actor_spawn(bp.GeneratedClass)
How should I proceed?
Thanks,
Yan

You just assign them normally, e.g. if your BP exposes a variable called 'foo' that is a string, then you'd do:
actor.foo = 'bar'

in Python.


DF Curvy Walls v3.3.1: walls cannot be drawn

Module
DF Curvy Walls v3.3.1
Describe the issue
Walls can't be created while the module features are enabled.
To Reproduce
Steps to reproduce the behavior:

Go to 'Wall Controls'
Click on 'Draw Walls with any feature active'
Try and draw a wall
See error

Expected behavior
Walls should be drawn while using Cubic Bézier Curve, Quadratic Bézier Curve or any module feature.

I assume this is for V10. This is fixed in pre-release


chore: add msteams destination support

:tada: This PR is included in version 0.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


allow segment details page to load without indices

This is a ui bugfix.
calling keys on segmentMetaData.indexes when that field was unavailable causes the whole page to fail. now we effectively skip the indices if they aren't available without a null error calling Object.keys

Codecov Report

Merging #10398 (05657c8) into master (52761fc) will decrease coverage by 38.19%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #10398       +/-   ##
=============================================
- Coverage     70.23%   32.05%   -38.19%
+ Complexity     6025      273     -5752
=============================================
  Files          2049     2049
  Lines        110869   110869
  Branches      16851    16851
=============================================
- Hits          77873    35539    -42334
- Misses        27540    72148    +44608
+ Partials       5456     3182     -2274

Flag
Coverage Δ

integration1
24.31% <ø> (-0.23%)
:arrow_down:

integration2
?

unittests1
?

unittests2
13.85% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/user/RoleType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/stream/StreamMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/config/table/TableType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/pinot/spi/data/DimensionFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1269 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Profile highly-used model fields to see if they should have indexes added.

Proposed Changes

Scan code base in how the field is commonly used in queries
Perform similar queries using the field in scope and call .explain() on the queryset
Take the output from .explain() and paste it into https://explain.depesz.com/
See what, if anything, it suggests. If it is doing a table scan and not using an index, we might want to add index=True to the field
We also might want to use Meta.index_together for other fields with which it is commonly queried.

Fields in scope:
$ grep -A1 -r "rofile filter.*index" nautobot
nautobot/dcim/models/cables.py:    # TODO: Profile filtering on this field if it could benefit from an index
nautobot/dcim/models/cables.py-    path = JSONPathField()
--
nautobot/dcim/models/devices.py:    # 2.0 TODO: Profile filtering on this field if it could benefit from an index
nautobot/dcim/models/devices.py-    u_height = models.PositiveSmallIntegerField(default=1, verbose_name="Height (U)")
--
nautobot/dcim/models/devices.py:    # 2.0 TODO: Profile filtering on this field if it could benefit from an index
nautobot/dcim/models/devices.py-    position = models.PositiveSmallIntegerField(
--
nautobot/dcim/models/devices.py:    # 2.0 TODO: Profile filtering on this field if it could benefit from an index
nautobot/dcim/models/devices.py-    vc_position = models.PositiveSmallIntegerField(blank=True, null=True, validators=[MaxValueValidator(255)])

Cable.path
DeviceType.u_height
Device.position
Device.vc_position

Justification
Scalable performance on commonly-used field lookups.

So we had #1639 which resulted in #1793 and has a follow-up story #1861. How is this different?

Dupe of #1861


DNF Times

Hello,
I would like a feature request if is possible. I saw that on the results of the drivers that DNF we don't get their times on stages and overall.
Is there a way to also have their times and not just a DNF ?
I want to simulate the RALLY 2 regulations on my rallies so i need to have the times of the drivers on all stages even from those who are DNF.

The way it works now it is that there should only be a DNF instead of a time when the "default stage time" is detected. That is 8 min on short stages and 15 min on long stages. The driver would no longer be able to continue, so rest of the rally would then either have 8 / 15 min stage times or no times at all for that driver.
There is an exploit where a driver can Alt+F4 right after a DNF and be able to continue driving the rally, this is the only way they would have non-default stage times (this is what the DNF system was designed to catch).
I should be able to output the raw data from the Racenet API without the DNF processing, I will take a look at this but it may be a few weeks before I have a chance to look at it.

As i understood the DNF system will give the 8/15 min stage time on every stage after the DNF.
That's too bad because it doesn't simulate the real rallies.
I think that we should have the time of every stage if is that possible with or without the 8/15 min stage time i'm ok with that.


operator: update ARCHITECTURE

Signed-off-by: Xiang Dai<EMAIL_ADDRESS>[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

Hi @daixiang0. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@daixiang0 thanks for the improvement. We have not met on Slack. It's a pleasure to see more contributors!
Cheers,
-steve

@daixiang0: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@daixiang0: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test gencheck_istio

unit-tests_istio
3a4e671a9bea0a608c02b02b346f1a5f6e382986
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Feat/162/add wallet endpoints

closes #162

@blu3beri I need to go over a few things still mainly the naming of some vars and the help strings. I'll tag you when done, but feel free to leave comments otherwise (but be aware it's unfinished)

Thanks for the contribution @morrieinmaas! Was there a specific reason why you needed this, or just resolving some of the open issues?

Thanks for the contribution @morrieinmaas! Was there a specific reason why you needed this, or just resolving some of the open issues?

TBH a mix of reasons. as you (correctly) suggested closing open issues, wanted to not get rusty/rustier in Rust and train being rusty... other reasons... and also thought that since there is an intention to wrap the entire cloud agent eventually, which would be quite handy to have thought this was an alright step to take in that direction.

Some small nit picks (I assume every endpoint and all options work).
I think it would be good to, somewhere in the future, do a small rewrite for modules. It is getting a bit messy everywhere and we are doing some odd things.

Sure, if you explain a bit what you have in mind I'm happy to help


How long will the incomplete object be deleted?   Can I set a timeout?

Issue was moved to server.


New batch of CV term requests, category: ESI stability

Name:
"MS1 signal jump (10x) count"
Definition:
"The count of MS1 signal jump by a factor of ten or more (10x) between two subsequent scans"
Proposed value type:

[ ] single value

Name:
"MS1 signal fall (10x) count"
Definition:
"The count of MS1 signal decline by a factor of ten or more (10x) between two subsequent scans"
Proposed value type:

[ ] single value

Please add comments (i.e. descriptions on how to interpret the values) for the metrics.

@mwalzer please add comments (explanations for interpretation)

@julianu proposal updated with comments and synonyms.

Actually, I think a consecutive stretch of low signal would be more robust to ESI instability detection. The detection with counts here is only possible relative for a group of runs with the same gradient settings and sample contents.


Add SPDX headers

Only for Rust files.
Signed-off-by: Ry Jones<EMAIL_ADDRESS>

I've rebased the branch and removed duplicate lines


Setting for front matter fields

Bumping as I also would like a feature to customize the front matter on imports.
Thanks


Changes to bump support to Flutter Map v6

Changes required for Flutter Map v6, including migrating away from deprecated properties.
Fixes https://github.com/tlserver/flutter_map_location_marker/issues/87

Thanks you for contributing. I found some problems in this PR.

Custom layers need to define their behaviour
The way custom layers are defined has changed. Mobile/moving layers should now use MobileLayerTransformer at the top of their widget tree.

For this change, NonRotationContainer is not needed and can be removed.

nonRotatedChildren has been removed
The approach to 'mobile' and 'static' layers has been changed. Mobile layers now wrap themselves in a MobileLayerTransformer which uses the inherited state, instead of FlutterMap applying the affects directly to them. Static layers should now ensure they use Align and/or SizedBox.expand.

For this change, in the 4 examples used nonRotatedChildren, the widgets in nonRotatedChildren should be wraped in Align, otherwise Position widget throw an error.
Fix these in 5f49fc53.


When I execute the command npm run watch everything compiles well but in the browser when I enter with app.dev it does not pass I do not see my app

Hey I need help with compunets vue. I started a new project with laravel and vue.
I configured my project according to a video tutorial that I am following but when I execute the command npm run watch everything compiles well but in the browser when I enter with

app.dev

nothing happens I searched for many solutions but none with success help please
my system is window 7
This is my webpack.mix.js file

let mix = require('laravel-mix');
//const BrowserSyncPlugin = require('browser-sync-webpack-plugin');
/*
|--------------------------------------------------------------------------
| Mix Asset Management
|--------------------------------------------------------------------------
|
| Mix provides a clean, fluent API for defining some Webpack build steps
| for your Laravel application. By default, we are compiling the Sass
| file for the application as well as bundling up all the JS files.
|
*/
mix.js('resources/assets/js/app.js', 'public/js')
.sass('resources/assets/sass/app.scss', 'public/css')
.version();

Here is what the console throws when executing the command npm run dev

$ npm run watch

@ watch C:\Users\JoseM\Desktop\Webs\recipe-box
cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
10% building modules 1/1 modules 0 active
Webpack is watching the filesâ¦
95% emitting
DONE  Compiled successfully in 1833ms16:03:20                                                                                Asset       Size  Chunks                    Chunk Names
/js/app.380a5bd858b26595419e.js     264 kB       0  [emitted]  [big]  /js/app
/css/app.d41d8cd98f00b204e9800998ecf8427e.css    0 bytes       0  [emitted]         /js/app
mix-manifest.json  144 bytes          [emitted]

We would need more information than you've given here. It looks like Mix compiled properly for you, so I'm assuming your issue is related to something else.


Cannot Run Quick Start - error 404 during download

Electron version:
Operating system: OSX 10.10.5

I tried the quick start but i've got an error during npm install when it tried to download a file:
><EMAIL_ADDRESS>postinstall /Users/sergio/Documents/Test/electron-quick-start/node_modules/electron-prebuilt
> node install.js

Downloading electron-v0.36.9-darwin-ia32.zip
Error: GET https://github.com/atom/electron/releases/download/v0.36.9/electron-v0.36.9-darwin-ia32.zip returned 404

/Users/sergio/Documents/Test/electron-quick-start/node_modules/electron-prebuilt/install.js:22
  throw err
        ^
Error: GET https://github.com/atom/electron/releases/download/v0.36.9/electron-v0.36.9-darwin-ia32.zip returned 404

@sergiotomasello are you on a 32-bit Mac OS X machine?
It looks like it generated a 32-bit download link and unfortunately only 64-bit builds are available for Mac OS X.

@kevinsawicki thanks for the quick reply. I have a mac book pro with an Intel Core i5, so 64bit.
Model Name:	MacBook Pro
Model Identifier:	MacBookPro11,1
Processor Name:	Intel Core i5
Processor Speed:	2,6 GHz
Number of Processors:	1
Total Number of Cores:	2
L2 Cache (per Core):	256 KB
L3 Cache:	3 MB
Memory:	8 GB

my node version is v0.10.38
running the process command with node I've got that my architecture is ia32:
sergio@MacBook-Pro-di-Sergio build (development) $ node
> process
{ title: 'node',
  version: 'v0.10.38',
  moduleLoadList:
   [ 'Binding evals',
....
....
     modules: '11',
     openssl: '1.0.1m' },
  arch: 'ia32',
  platform: 'darwin',
  argv: [ 'node' ],
  execArgv: [],
  env:
   { TERM_PROGRAM: 'Apple_Terminal',
     SHELL: '/bin/bash',
....
....

any ideas?

Could you try installing the latest node LTS version and see if it reports a different arch? Not really sure what is going on here, really strange.

I downloaded 0.10.38 32-bit on Mac and it appears to report ia32 for os.arch() which is what electron-download uses.
If you download any version of 64-bit node this problem should go away.

Closing this out.
The error message in future releases will be more specific about what failed to download.

I was running a 32bit node version. Changing it to a 64bit version I solved the problem. Thank you @kevinsawicki :+1:


[bug]: NTP Server Doesn't Always Sync Following Setup

Prerequisites

[X] I have searched for existing issues that already report this problem.

embassyOS Version
0.3.3
Device
Laptop/Desktop
Device OS
Linux
Device OS Version
6.0
Browser
Firefox
Browser Version
102
Current Behavior
Time defaults to the year 2061 for reasons unknown.  Timedatectl is unable to get a response from NTP servers, even when added manually.  @dr-bonez is familiar
Expected Behavior
Timedatectl syncs to NTP server
Steps to Reproduce

Setup embassyOS
You'll know you hit it because nothing that needs a cert works

Anything else?
No response

Related https://github.com/Start9Labs/embassy-os/issues/267

If date is > 2038, set date to hardcoded date.
If NTP does not sync after 60 seconds, issue notification


Add pyarrow floatingpoint in Python bindings

Description
Add the missing floatingpoint pyarrow data type inside the Python bindings
Related Issue(s)

closes #192

we still have this check above elif type_class == "int" or type_class == "float" or type_class == "date":, should we remove that float check as well?

Good catch.
type_class == "float" is not relevant, we should remove it, right?

Yeah, I think we should remove that.


More options for covariances of subsets of keys

Perhaps add these to the optimization example along with how to compute metric scale for them.

Hi I adhere to this.
Since SLAM is relative but all is expressed in absolute reference, it is interesting to recover the relative variance between variables. Say we are interested in the variable of var2 wrt. var1, that is, in the covariance of var2-var1. To do so, we need the cross-variance between var1 and var2.
In particular, I would like to have either of these in symforce:
# 1. compute the cross-variance explicitly
cross_1_2 = compute_cross_variance(key1, key2)
#2. compute the covariance of a subset of keys
cov_some = compute_co_cross_variances(List(keys))
# and then
cross_1_2 = cov_some[key1][key2]
# 3. compute all the covariance
cov_all = compute_full_covariance(...)
# then:
cross_1_2 = cov_all[key1][key2]

where I guess option 2 is the most interesting

Thanks that's a good callout - (2) should work nicely I think.  Actually we should probably just expose (3) also, since what we already have is computing the full covariance anyway and then we're just pulling out and returning the diagonal blocks

Oh, then if the computations are done, to implement 3. we only need the correct accessors!
This would be very interesting for my current project since I have to provide the relative accuracy between two estimated entities

Yep exactly, (3) should be a quick change

Did (3) in 1d870c1e9c756be5dbea483208918cb9e282b510, which is in main now

Will check it out asap! Thanks!

I see the full covariance is computed and returned as a single large Matrix.
What is the method of accessing a particular off-diagonal block, using the keys {key1, key2} of the block?

The block you want should be:
index = optimizer.linearization_index()
cov = optimizer.compute_full_covariance(values)

cov[index[key1].offset : index[key1].offset + index[key1].tangent_dim,
    index[key2].offset : index[key2].offset + index[key2].tangent_dim]


Reformat source with no changes, and the method template (3.0.78)

I tried reformatting the method template.  It changed.  I think our method template should conform to our formatting rules.
Then, I reformatted it again.  It turned green. Since there was no change, it would have been nice for it not to have turned green.

The default method template shouldn't change or dirty the source pane if a reformat is done.

If you format a method that is already correctly formatted and there are zero changes, it still marks it green.  An extension of the original complaint but still should be fixed.


Revert "Add full_fee_amount column (#1173)"

Forgot to disable automerge. I've rebased that PR ad added some significant changes that weren't reviewd, so it wasn't ready for merge.

Ok I've realised that I can't merge this because sql migration is already applied on staging. Ok, we will go with post-commit review then...


How does GreenTunnel compares to Stubby?

Hey, this is not a feature request, but more of a series of question/inquiries about this cool utility.
I don't know if you know about Stubby ( https://github.com/getdnsapi/stubby )... It seems like both utilities have somewhat similar scopes, but it also seems like GreenTunnel might be "sneakier" (better) in its approach to DNS requests... Although, Stubby seems to be a more mature and developed project.
I am a relative ignorant when it comes to DNS stuff and privacy/anti-censorship tools (I'm not a programmer, but I live in a very censorship-heavy Country)... so I'm just guessing things after reading about how both tools work. I've used Stubby for more than a year now and I'd like to test GreenTunnel to see how it works and performs.
I haven't made any test, but it seems like GreenTunnel and Stubby wouldn't (couldn't) work together (have them running both at the same time), since both seem to channel traffic through <IP_ADDRESS>, so I guess I would have to use one or the other (especially because it seems like there's significant redundancy in the use cases of these tools).
The concrete questions I have are:

Does GreenTunnel solves the same "problems" of Stubby, just in a more clever way?

If the answer to the previous question is "yes", I would like to have GreenTunnel running as a Systemd service, but I couldn't understand the "instructions" in the related issue ( https://github.com/SadeghHayeri/GreenTunnel/issues/65 )... So if I could do a "feature request", that would be to have GreenTunnel as a Systemd service (just by running the usual "sudo systemctl enable GreenTunnel")

Thank you in advance!

In the context of DNS resolution:
Stubby resolves DNS using DoT (DNS-over-TLS) but it doesn't do much more than that. In my experience, anyone on the wire can still see the SNI (Server Name Indication) field. Some ISPs (such as mine) do that hence we can't bypass the censorship just using Stubby.
Whereas in the case of GreenTunnel (from the FAQ):

Server Name Indication (SNI) is an extension to TLS (Transport Layer Security) that indicates the actual destination hostname a client is attempting to access over HTTPS. For this Web Filter feature, SNI hostname information is used for blocking access to specific sites over HTTPS. For example, if the administrator chooses to block the hostname youtube using this feature, all Website access attempts over HTTPS that contain youtube like www.youtube.com in the SNI would be blocked. However, access to the same hostname over HTTP would not be blocked by this feature. GreenTunnel tries to split first CLIENT-HELLO packet into small chunks and ISPs can't parse packet and found SNI field so bypass traffic!

For your second question:
Check how to run a program at startup in the documentation of your operating system. For example in Ubuntu, just add a new item in the "Startup Applications" menu with the command "green-tunnel".

Thank you for responding my questions!
I have a few more questions, though... I hope to explain myself clearly, since my questions might be difficult to express from a tech-savvy point of view and English is not my native language.
My first question is:
How can I check if GreenTunnel is working properly? (tunneling DNS requests and splitting SNI packets)... I run GreenTunnel CLI with the  "-v" or "--verbose" argument but I don't see any extra info.
My second (and rather complicated) question is:
In the case of Stubby, I have to change in Network IPv4 settings and my systemd-resolved config file to <IP_ADDRESS> in the DNS sections (more info in https://www.linuxbabe.com/linux-mint/dns-over-tls-stubby )... Just in case, I don't use Mint, I use Manjaro... So... do I have to do the same setup for GreenTunnel if I want to use it globally on my system?... Or does GreenTunnel automatically (somehow) does that for me?... If GreenTunnel automatically sets itself to be used globally on my system, does it affect its behavior even if I leave my Network and systemd-resolved settings to <IP_ADDRESS>?... I stopped and disabled Stubby on my system, of course. I only have GreenTunnel running.
BTW, I managed to create a systemd .service file and make it work!... For those interested:
1.- Create a plain text file (with ".service" extension instead of ".txt", of course).
2.- fill it with the following text:
[Unit]
Description=GreenTunnel

[Service]
Restart=always
RestartSec=5
User=[YOUR USERNAME]
ExecStart=/usr/bin/green-tunnel --verbose

[Install]
WantedBy=multi-user.target

3.- Name the file e.g.: GreenTunnel.service and copy or move it to "/etc/systemd/system/"
4.- Enable the systemd service with "sudo systemctl enable GreenTunnel"
5.- Start the service with "sudo systemctl start GreenTunnel"
6.- You can check if the service is running with "systemctl status GreenTunnel".
Greets!

Hi!
I checked Stubby and found it's a cool tool to have secure DNS and send DNS queries over TLS.
before I answer your questions, let's explain a little about the basics! We have two concepts here, DNS and DPI.

DNS is a protocol to convert domain names to IP addresses. it's an old protocol and doesn't support encryptions, fully plane text!
DPI is a type of data processing that inspects in detail the data being sent over a computer network and usually takes action by blocking, re-routing, or logging it accordingly.

Ok now lets talk about Stubby and GreenTunnel.

Stubby: It's a tool to add encryption support to the default system DNS service, it's run as a local DNS server (listen on <IP_ADDRESS>:53) and get DNS queries from clients (like Firefox), it connects to DoT providers (like <IP_ADDRESS>) with TLS encryption layer and then answer the clients.
GreenTunnel: it's an HTTP proxy server, it gets HTTP/HTTPS request from a client, find the IP address using DoH or DoT and bypass DPI using packet splitting.

If Stubby works for you, I recommend to do not use GreenTunnel. GreenTunnel encrypts only HTTP/HTTPS requests but Stubby is a system-wide secure DNS solution. Also, you can use both at the same time, use GreenTunnel to bypass censorship and use Stubby to secure all other queries.
NOTICE: Do not use GreenTunnel for a critical situation, check Tor Project.

Thanks again for your feedback... I've done some more testing and at least in my opinion, GreenTunnel is indeed a more basic (but great) utility to circumvent censorship, it is especially useful for novice users that don't want (or don't know how) to fiddle with more complex setups like Stubby or dnscrypt-proxy.
A few years ago I tried dnscrypt-proxy and it worked for awhile, but shortly after, it stopped working and at that time I couldn't manage to make it work. Yesterday I followed their much improved help wiki and this time I managed to make it work again and I could even activate some of the fancier features, like ESNI, which is another way (still in its early stages) of solving what GreenTunnel solves.
But I repeat, GreenTunnel is still a great tool and a MUCH EASIER one to set up!
Keep up your great work!

Thanks again for your feedback... I've done some more testing and at least in my opinion, GreenTunnel is indeed a more basic (but great) utility to circumvent censorship, it is especially useful for novice users that don't want (or don't know how) to fiddle with more complex setups like Stubby or dnscrypt-proxy.
A few years ago I tried dnscrypt-proxy and it worked for awhile, but shortly after, it stopped working and at that time I couldn't manage to make it work. Yesterday I followed their much improved help wiki and this time I managed to make it work again and I could even activate some of the fancier features, like ESNI, which is another way (still in its early stages) of solving what GreenTunnel solves.
But I repeat, GreenTunnel is still a great tool and a MUCH EASIER one to set up!
Keep up your great work!

As far as I can tell the ESNI with dnscrypt-proxy only works with firefox (https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Local-DoH). Have you got it to work system-wide? I don't have deep knowledge about TLS etc. but GreenTunnel is the only tool I've tried so far that has actually managed to circumvent censorship based on DNS hijacking

Hey... You're right that currently, ESNI only works with Firefox (hopefully in the middle/long term this will be implemented by other browsers and applications and will become the de facto way of circumventing censorship)...
I've been doing more digging and I've found a program called "PowerTunnel" ( https://github.com/krlvm/PowerTunnel ), which seems to do VERY similar things to what GreenTunnel does to DNS requests, and it looks like its in a more advanced development state. I'm actually thinking that both projects could benefit from each other, and who knows, they could be merged and work together or something like that.


feature: Implement reading mask data

Hey,
Over the past month we implemented some features in our fork for the upcoming OpenDesign new release. We didn't have time to discuss them with you properly, so let me know if you want these features or not - in case you do, I'll properly refactor the code and add tests :)
This is PR 3/3; implementing layer mask properties and decoding.
mask.psd comes from psd-tools tests (https://github.com/psd-tools/psd-tools/blob/main/tests/psd_files/masks.psd): Python package, released under MIT license.

We are definitely interested. Keep up the good work!

Do you think we should add a test to ensure that rendered user mask image is ok? This'd require most likely simply having rendered png in repository and comparing against that, as I don't see any other way of testing it.

I don't think we need an actual PNG file. It would make managing tests easier, but we'd have to decode the PNG file when running the test to compare the raw image data.
Alternatively, you could dump the expected return value of userMask() and/or realUserMask() to a file (e.g. tests/unit/fixtures/user-mask.bin). We could then load and compare its contents when running the tests. Effectively a simple snapshot test.

Alternatively, you could dump the expected return value of userMask() and/or realUserMask() to a file (e.g. tests/unit/fixtures/user-mask.bin). We could then load and compare its contents when running the tests. Effectively a simple snapshot test.

Good idea! Implemented it using sha256 checksum - I think it's just as useful as binary dump but lighter on Git :)

IMO computing a hash is less preferable to decompressing a PNG in memory, because a test failure doesn't tell you anything. At least with a compressed stream, we can compare the contents to see how and where the code failed.
If the size of the bin is a concern, we could double back on the PNG idea; or simply GZIP the bin file using zlib.gzip() and zlib.gunzip().

Good point on the OOM problem. I remember using weird tricks to prevent test failure messages from spilling all over the terminal. I wish there was a test reporter that can concisely summarize binary diffs. But in the meantime, your approach is completely valid. 👍
Feel free to merge this PR. I'm waiting for the other PRs as well.
P. S. I'm planning a new release soon--as early as this Friday. Do you want to have all your PRs in the new release? If not, I can arrange your PRs to be included in another release (hopefully also published before 2023).

Only you can merge the PR, I don't have write rights to your repo :)
As for the releases - don't worry, in current setup we don't need them, as we have this repo in git submodule which we build on our own :)


Block: Quality pipeline for devon4net

User Story:
As a Developer (setting up the quality pipeline), I want to have a detailed guide and scripts for setting up .NETenvironment, so that I can get it done fast and without errors.
Details:
Modify existing blocks related to pipelines with .NET related information. This includes updating guide and scripts related to "Setup Quality pipeline"
Acceptance Criteria:
TBD

Since I have not been able to finish this in time, here is what I've come to know so far:
According to the official sonar documentation, the correct way to trigger an analysis is the use of SonarScanner.
These are the working commands to trigger this locally from the SonarScanner source folder:
dotnet SonarScanner.MSBuild.dll begin -k:<Project key> -d:sonar.host.url=<sonarUrl> -d:sonar.login=<sonarToken>
dotnet build <ProjectPath to .sln file>
dotnet SonarScanner.MSBuild.dll end -d:sonar.login=<sonarUrl>
The Project key would also have to be extracted from the .sln file, to be inserted into the -k tag.
There is also instructions on how to manually set up an analysis pipeline.
My issue was how to combine this, to actually have this whole step automated.
The last issue I received was my pipeline failing, because it could not find the SonarScanner command.

My chain of thought originated from being able to integrate the SonarScanner into the repo somehow. But in order to achieve this in the hangar environment, this would also have to be automated.
I am unaware if this is possible without setting up the sonar project manually first.
In my testing attempts, I also had to remove most of the pipeline steps, including the artifact download, since this was failing most of the time. I'm not sure if this was part of the problem.


Empty output with 0 (zero)

Running ./bashids -e 0 or ./bashids -e '0' returns an empty string.
According to feature 1 on hashids' website it should handle zeros:

Create short unique ids from numbers (positive numbers & zero).

The JavaScript version handles zero correctly.
Am I doing something wrong?

Encoding 100, 200, ..., 1000, 2000, etc. also outputs nothing.

@sirotopr thanks for the report!  The fix is on master.


How to change the table style?

Dear:
I am using the python-pptx to genarate the slides automaticly  which is very powerful,  and some issues make me confused.
firstly, I want to change the table style with below codes, but it does not work,  can anyone help me to figure out?? Thank you very much.
table = table.insert_table(rows, cols,).table
#table = slide.shapes.AddTable( Left, Top, Width, Height)
#table.apply_style = '5C22544A-7EE6-4342-B048-85BDC9FD1C3A'
table.apply_style = 'Light Shading Accent 1'
even if I use the code, the style of  output table is just default style.
just like the below image, I also do not know how to find the style_id of table.

hi guys,
the issue had been sloved , and the solution is in the link :https://github.com/scanny/python-pptx/issues/27.


Secret stored in PList File

The secret is stored in the iOS Plist File. It can easily be extracted by creating a backup. Sensitive data, such as Secrets, Keys, Passwords should never be stored in PList. A Keychain Mechanism should be used.

This is related to #36


Deprecated tests & Adding missing tests from RHEL7 STIG v2r4

Merging in PR #114 and #113
Pulled in latest updates from Master of Simp.
Rebased depracatedTests with Simp master.
Merged updates.
Resolved all merge conflicts.
Cleaned up controls.
Made various fixes.

@aaronlippold Looks like we're still having an issue, do you know what might be causing this?
https://travis-ci.org/github/simp/inspec-profile-disa_stig-el7/jobs/658905934#L1472

It looks like a parsing issue of the outcoming JSON file. The only change
they made to the JSON structure was when they added the waivers data.
On Wed, Mar 11, 2020, 9:52 AM Trevor Vaughan<EMAIL_ADDRESS>wrote:

@aaronlippold https://github.com/aaronlippold Looks like we're still
having an issue, do you know what might be causing this?
https://travis-ci.org/github/simp/inspec-profile-disa_stig-el7/jobs/658905934#L1472
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/simp/inspec-profile-disa_stig-el7/pull/142#issuecomment-597647246,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALK42CCIVBVPIQVH2VG24TRG6JRXANCNFSM4LBLDKIQ
.

I ran the test without these updates on a different repo and didn't have any issues so I think it's something related to this change but there's not really enough to go on.

Oh, this is an issue with running the inspec command. Nothing has touched the JSON yet.

I see that inspec is now running but we're not getting a report. Can you see if there is any valid output coming from this new data set?

There seems to still be something wrong:
[root@el7 inspec]# inspec exec inspec_profiles/CentOS-7-disa_stig/CentOS-7-disa_stig --chef-license accept
Unable to parse inspec.yml: line 437, did not find expected key while parsing a block mapping

This identified a bug in simp-beaker-helpers which was not providing adequate reporting when inspec failed.
Fixed in https://github.com/simp/rubygem-simp-beaker-helpers/pull/121 and will be released soon

For anyone tracking this PR: simp/rubygem-simp-beaker-helpers#121 was released on April 07.
However, we've recently migrated our org's Travis CI from travis-ci.org to travis-ci.com, so restarting the previous Travis PR checks  to pick up the new gems won't clear the failed travis-ci.org checks (and we can't get rid of them).
As a workaround, we can push up a trivial change to the PR, which will prompt all CI PR checks rerun on the new commit from scratch.

Closing. Maintenance has been moved to https://github.com/mitre/redhat-enterprise-linux-7-stig-baseline

Closing. Maintenance has been moved to https://github.com/mitre/redhat-enterprise-linux-7-stig-baseline


typescriptServiceClient using up cpu on mac

VSCode Version:1.4.0
OS Version: 10.11.1 (OS X El Capitan)

Steps to Reproduce:

Open up the editor (all third-party extensions are disabled).
And simply open files and navigate.

Closing the higher cpu using Code Helper process gives the following log:-
[Extension Host] Error: Service died.
    at /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:236:46
    at Array.forEach (native)
    at TypeScriptServiceClient.serviceExited (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:235:37)
    at ChildProcess.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:176:31)
    at emitTwo (events.js:105:20)
    at ChildProcess.emit (events.js:185:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

Haven't had the chance to debug the issue in depth. But typescriptServiceClient seems to be responsible for the cause.
Hope this helps. Love VSCode.

ping @dbaeumer
who would be best to talk to on the team about this?

@waderyan I am pretty sure this is the tsserver and not the extension host which contains the typescriptServiceClient.
@vegetableman if you can reproduce this can you provide use with the command line of the Code Helper that is causing high CPU. That helps understand what the process is actual for.

Some more comments: closing the extension host hard closes the tsserver. This is why you see Error: Service died. So the whole CPU eating has IMO nothing to do with the typescriptServiceClient. It is only a consequence of killing these progresses.
As long as the tsserver has no high CPU usage or we can profile the extension host it is unclear if this is really TS related.

@vegetableman this has fallen through the cracks. Are you still seeing this issue with the latest VS Code? Can you share your workspace if you are?

Closing as we need more information to investigate this
@vegetableman Please let us know if you are still seeing this in VSCode 1.8.1 with TS 2.1.4+
Thanks.


multi_thread support

Tracking issue for support for multi_thread runtime.

Is there any limitation in implementing this that doesn't let us just use the multithreaded equivalents of the currently used types in the library? (e.g., Rc => Arc, RefCell => Mutex, etc.)

@Alonely0 Its possible to configure io_uring such that it invalid for a submission to come from more than 1 thread. I suspect there are other things to consider also.
tokio_uring::builder().uring_builder(
   tokio_uring::uring_builder().setup_single_issuer()
)

I think multi-thread support is essential
I use tokio to write a VPN program, when using rt-multi-threaded feature and tokio::spawn, in the test environment, iperf3 TCP can reach 600Mbps, however when using tokio_uring to handle IO, the single thread tokio_uring only have 120Mbps, and 1 CPU usage reach 100% on the iperf3 server
tokio

tokio_uring

I have set sqpoll to try to reduce the submit_and_wait syscall

I notice the Op has a weak reference of the TLS RuntimeContext, and when polling the future, it will check the lifecycle in Ops, and the Ops is in the RuntimeContext
if Op can have an arc weak reference of the RuntimeContext, no matter which thread the RuntimeContext is in, that may make multi-thread support easily

when creating an Op, it uses the current thread RuntimeContext to submit the sqe
when polling the future, Op will use the arc weak reference to find out the RuntimeContext to check if work is done or not, no matter Op is on the same thread when submitting the sqe or not
we can create multi threads to run the io_uring instances, so we can use more CPU

So, in general the easiest path to doing this is going to be to do something similar to what @Sherlock-Holo described, however it isn't clear to me that this will perform terribly well. Contention on the squeue may be an issue, so there would be a bit of "wait and see" with respects to what means of doing this ultimately stick.
For now I'd recommend a runtime-per-core model of some sort. Depending on what you are doing, that is probably going to work quite well.


lfs_filebd.c seems to assume errno values

functions in lfs_filebd.c (eg. lfs_filebd_read) returns a negative errno. (eg. -errno)
it doesn't necessarily match with enum lfs_error values.

Hi @yamt, thanks for creating an issue.
Ah yes, I can see where this could be an problem.
The exact solution though seems a bit unclear. We really shouldn't be mapping all OS errors into littlefs errors in the bd since 1. littlefs doesn't define all OS errors and 2. this can mess up littlefs internals.
These should probably all be mapped to LFS_ERR_IO, though it's a shame to lose the extra error info. At least lfs_filebd_create can return some of the more useful errors, which is where we call open.

I'm curious, did you run into an actual error during use? From what I understand most modern OSs read/write/lseek don't really ever error unless you yank the harddrive out of the machine.

Hi @yamt, thanks for creating an issue.
Ah yes, I can see where this could be an problem.
The exact solution though seems a bit unclear. We really shouldn't be mapping all OS errors into littlefs errors in the bd since 1. littlefs doesn't define all OS errors and 2. this can mess up littlefs internals.
These should probably all be mapped to LFS_ERR_IO, though it's a shame to lose the extra error info. At least lfs_filebd_create can return some of the more useful errors, which is where we call open.

i guess leaving the original errno in LFS_FILEBD_TRACE is good enough.

I'm curious, did you run into an actual error during use? From what I understand most modern OSs read/write/lseek don't really ever error unless you yank the harddrive out of the machine.

no. i was just reading the code.


Add js search to table component

What
Updates the table component to add a With filter option.

Why
This was previously existing functionality that requires restoration. See Add JS Search to Table Component
Visual Changes

The new component is added to the table section of the Component Guide and appears as below.

The component displays results in response to user input as shown below

I've approved the visual changes to this PR. One was the thing that's being added (which is fine, obviously) and the other is a slightly weird one to do with the image card component, which is unrelated to this change and is occurring on a few other PRs at the moment.


Export metrics

Proposal
Ability to export metrics (number of banned ips, ...) like traefik.

Hello @aqos156,
I don't think it is possible to have a dashboard for plugins in traefik. This may need a feature request on traefik itself.


Improve the moduledoc for the Tortoise module

The documentation of this project is lacking, and boy are my ears red. In this PR I will attempt to improve the documentation to the point that this project is useful to others.
When applied this should fix #26

Pull Request Test Coverage Report for Build 257

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.849%

Totals

Change from base Build 255:
0.0%

Covered Lines:
487

Relevant Lines:
595

💛  - Coveralls


Are there any ways to force TextLayout not to trim the string when calculating its size?

I'm making word-by-word desktop lyrics software with druid.
To do this, I've split the whole sentence into different tokens depending on the key time ( e.g. Oh (100ms), spill (128ms)me (160ms)the (182ms)tale (204ms).
Now I want to draw the lyrics word by word on my custom widget, but then I found that TextLayout would automatically trim the string so that the result is now like this.

( the gray part is drawn directly by draw_text and the white part is drawn word by word )
So, is there any way to prevent this behavior or any other approach to my target?

What do you mean by trim the string? The Size returned by layout or does it actually modify a String object? For the layout case, you could just wrap the TextLayout in your custom widget and then have the custom widget's layout return a custom size, perhaps with some padding.

What do you mean by trim the string? The Size returned by layout or does it actually modify a String object? For the layout case, you could just wrap the TextLayout in your custom widget and then have the custom widget's layout return a custom size, perhaps with some padding.

The size. I don't think it's a good idea to add some custom paddings cuz it would make the render result different from the one which directly use draw_text. but  anyway, now I'm adding some custom paddings as it's the only way that can resolve my problem

it would make the render result different

Different in some way other than padding? Generally speaking, I wouldn't expect a widget's paint to run differently if the parent's size is larger.

uh, I cannot reproduce now. I'll reopen the issue when I reproduce it again.


feat: allow filter to have JavaScript specific regex features in development

Fix #12
This PR makes filter in development (esbuild) behaves the same when building (rollup)
It tests the JavaScript filter directly instead of passing to esbuild.
Esbuild uses Go Regex which is pretty limited compared to JS engine: https://github.com/evanw/esbuild/issues/1634#issuecomment-927204088

I think its a good idea. I've had issue with complex filtering options, babel runned but changed did not applied

Closed in favor of #23


Test multiple requests, CqlMsg -> enum and fixes

Removed unused stuff (mio::Token was used at client which is not correct).
Added a test with multiple requests.
CqlMsg is an enum so we can shutdown the event loop from the client sending a Shutdown message. (Remember we only keep event loop channel in the client).
Use of 'pub type CassFuture = Future<RCResult,()>' to make the code clearer.

This PR cannot be merged automatically. Please, merge first the latest changes in mio branch into yours, and then issue de PR

I merged the last changes and created another pull request on -> https://github.com/neich/rust-cql/pull/8


Naming issue

The base uv tool now has a tool-runner called uvx (which caused all kinds of issues when i just ran uvx upgrade-all so, might need to rethink something. I had to revert back to pipx in the mean time.

See https://github.com/robinvandernoord/uvx2/issues/2


TypeNodes.def -> TypeNodes.inc because of a random open-source request

React to the abstract serialization merge.

Please test with following pull request:
https://github.com/apple/llvm-project/pull/490
@swift-ci Please test.

Build failed
Swift Test OS X Platform
Git Sha - 208ac454383374488825af639a13079301ff8cfe

Please test with following pull request:
apple/llvm-project#490
@swift-ci Please smoke test.

Please test with the following pull request:
https://github.com/apple/llvm-project/pull/500
@swift-ci Please smoke test.


WebSocket error - Connection failed: [object Object] or Request failed with status code 401

Hi, could you please help me find out what is going wrong here:

Got IP and port

request:
dns.loxonecloud.com/?getip&snr={my-SNR}&json=true
response:
{"cmd":"getip","Code":200,"IPHTTPS":"{my-IP}:{my-PORT}","PortOpenHTTPS":true,"RemoteConnect":true,"DNS-Status":"registered","DataCenter":"loxonecloud.com"}

Providing those (e.g. 123-132-21-43.{SNR}.dyndns.loxonecloyd.com) in homebridge plugin config results with 401 (confirmed that user credentials work OK in browser)

[7/23/2023, 3:53:53 PM] [homebridge-loxone-proxy] Loaded homebridge-loxone-proxy v1.1.0 child bridge successfully
[7/23/2023, 3:53:53 PM] Loaded 0 cached accessories from cachedAccessories.0E3112CECBAC.
[7/23/2023, 3:53:53 PM] [homebridge-loxone-proxy] Trying to connect to Miniserver
[7/23/2023, 3:53:54 PM] Homebridge v1.6.1 (HAP v0.11.1) (homebridge-loxone-proxy) is running on port 49045.
[7/23/2023, 3:53:54 PM] [homebridge-loxone-proxy] Connection failed: Error: Request failed with status code 401

Trying with local IP in above format (443 as port) with result:

[7/23/2023, 3:58:28 PM] [homebridge-loxone-proxy] Loaded homebridge-loxone-proxy v1.1.0 child bridge successfully
[7/23/2023, 3:58:28 PM] Loaded 0 cached accessories from cachedAccessories.0E3112CECBAC.
[7/23/2023, 3:58:28 PM] [homebridge-loxone-proxy] Trying to connect to Miniserver
[7/23/2023, 3:58:28 PM] Homebridge v1.6.1 (HAP v0.11.1) (homebridge-loxone-proxy) is running on port 49045.
WebSocket: ERROR: websocket error
WebSocket:  socket failed! WS Close Code: -unknown-
[7/23/2023, 3:58:28 PM] [homebridge-loxone-proxy] Connection failed: [object Object]

Have I missed something?

I have only tested the code against an v1 miniserver which does not use TLS on port 443, but it is using Loxone's lxcommunicator under the hood, so it should work.
For internal communication you should use ip4 notation. So for example (<IP_ADDRESS>). Port should be 443. (not sure if a v2 miniserver accepts port 80)
Does it work using this notation?

Thank you for your feedback.
https://github.com/rudyberends/homebridge-loxone-proxy/commit/f03c6867261313db0b8b5c1335afb78 Should fix your issues. It's in the latest beta. Perhaps you can test it?

Thanks for testing. To answer your questions;

The code on the homebridge side for 2 way audio is already in place. That is why you see the microphone. However on the Loxone side this still needs to be implemented. For intercomV1 this should be easy to implement as there is a SIP connection available. On the V2 it should be also available, but I don't think Loxone has already implemented it (documentation claims SIP is available.) It should still be possible using webrtc, but it requires some more research. The Loxone implementation uses a websocket for the WebRTC signaling, so I need to figure out how this works.

I will try to implement Homekit secure video. It should be possible as other plugins already use it.


Fixed shortcut conflict in config.def.h

Terminal spawn & zoom were mapped to the same key combination.
Moved zoom to Win + Shift + Return.

thanks for this


fix: create Python symlink only during builds, and clean it up after

Checklist

[x] npm install && npm test passes
[ ] tests are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Not really sure how to automatically test this fix, since the whole idea is that the symlink is leaves no trace, and I don't think there's any documentation required here.
Description of change
Fixes #2713
Previously in b9ddcd5bbd93b05b03674836b6ebdae2c2e74c8c this python symlink was created during configuration, and the symlink persisted indefinitely. This causes problems with many tools (including Electron Builder, Electron Forge, and Apple's codesign tool) that do not expect a codebase to ever include symlinks to external absolute paths.
This PR largely reverts that commit, and instead just writes the path to link to into the config, and then creates the symlink only temporarily during the build process, always deleting it afterwards.

@pimterry @cclauss This is still causing problems for a lot of people. Is this fix going to be merged soon?

Any change of getting this merged?

Please rebase to fix git conflicts.

Please rebase to fix git conflicts.

@cclauss done - the build is just waiting approval

@StefanStojanovic @lukekarrys Your reviews, please.

The visual-studio error (a test after-all timeout) that's failing here seems ignorable too - that's been failing in other unrelated changes already, including this docs-only PR: https://github.com/nodejs/node-gyp/actions/runs/5412919694/jobs/10135897829

Also keen for this to get merged. FYI the python lint error that is failing has been fixed upstream, can this be rebased? Maybe it has more chance of getting merged if the status checks pass.

The failing Visual Studio tests are fixed elsewhere.

Thank you @cclauss 🙇


Incorrect validation of variable names (and possible vulnerability)

Currently the variable validator actually tries to parse the given string to determine if it's a valid variable name.
What this means is that it actually doesn't answer the question "Is this a valid variable name" but rather, "Does this compile"
Case in point. According to this validator, the following is a valid variable name:
raise Exception('Foo')\nxyz

To recreate:
>>> import validator_collection
>>> invalidVarName='raise Exception("Foo")\nxyz'
>>> validator_collection.is_variable_name(invalidVarName)
True
>>>

Thanks for the heads up. I've added regex validation to the variable_name() validator and released a new version.
Still checking compilation as well, but first the code needs to get a full match on a fairly restrictive regex. Hopefully this resolves the issue!


Updated 🇨🇿 Czech translation

@Unknwon Hi, could you please update Czech (cs-CZ) locale with approved strings from Crowdin? I went through the whole CZ translation again and improved, united and approved a lot's of changes. Thank you.

Hi, should be updated in https://github.com/gogits/gogs/commit/a11044f78954f5c173d686cd46833386cc43bc16#diff-8d7e6724b1d4111cbb1ef2e5fa7a414c.
Ping me if something is still missing.


Add WebAIM Link

From the accessibility guide:
https://github.com/ucsb-wsg/web-accessibility/blob/master/web-accessibility-guidelines.md#resources
The W3C link is already on the Web Accessibility page:
http://webguide.ucsb.edu/web-accessibility/
Just need to add the WebAIM link as well.

@loganfranken Should this be closedsince WebAIM is no longer an UCSB option?

Hey @garster, were you thinking of the AMP accessibility scanning tool? WebAIM should still be a viable general resource.

@loganfranken yes I think you are correct and I am mistaken.


Correction for raw affiliation Haihe Laboratory of Sustainable Chemical Transformations, 300192, Tianjin, China.

Correction needed for raw affiliation Haihe Laboratory of Sustainable Chemical Transformations, 300192, Tianjin, China.
raw_affiliation_name: Haihe Laboratory of Sustainable Chemical Transformations, 300192, Tianjin, China.
new_rors:
previous_rors: 03q99v794
works_examples: W4388666725;W4367669235;W4323652175;W4366962880;W4323661194;W4388460543;W4375866129;W4367680746
contact: be69426b3b3a26232fed262454c738a3:3627d3a7cac2cb9293e120b0aa62 @ univ-lille.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


TypeError: Cannot read property 'rawRows' of undefined

Hi 👋 I've upgraded the library from 7.3.0 to 8.0.1 and changed the database execution call from db.executeAsync to db.execute.
Running into the following error: [op-sqlite] SQL execution error: not an error
Then I've wrapped the following line in enhanceDd to a try/catch:
let intermediateResult = await db.execute(query, sanitizedParams);
which fails with: TypeError: Cannot read property 'rawRows' of undefined
Query I'm trying to run:
      CREATE TEMP TABLE temp_localDate AS
      SELECT
        startTimestamp,
        DATETIME(
          startTimestamp,
          'localTime'
        ) AS localStartDate,
        (strftime('%s', endTimestamp) - strftime('%s', startTimestamp)) AS duration
      FROM point_track;

Happy to provide more details.

Latest version is 8.0.3, try that one

Thanks for the bug fix, 8.0.3 addresses the issue.
Feel free to publish the release on GitHub:

You can just hover over the dependency in vscode and it will show you the latest published version


remove travis as compiling takes too long

Backport of https://github.com/arangodb/arangodb/commit/03fe0fdcb44e0cd8c6d58dc21866906373528a11

LGTM


feat: add coin distribution page

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Module Slicing

Experimental support for slicing modules. e.g:
x = jnp.zeros((2, 224, 224, 3))
resnet = elegy.nets.resnet.ResNet18()
submodule = elegy.module_slicing.slice_module_from_to(
            resnet,
            start_module=None,
            end_module=["/res_net_block_1", "/res_net_block_3", "/res_net_block_5", "/res_net_block_7" ],
            sample_input=x,
        )
outputs = elegy.Model(submodule).predict(x)
assert outputs[0].shape == (2, 56, 56, 64)
assert outputs[1].shape == (2, 28, 28, 128)
assert outputs[2].shape == (2, 14, 14, 256)
assert outputs[3].shape == (2, 7, 7, 512)

This currently requires the additional package networkx. This could be removed with some more work if you don't want to introduce another dependency.
Limitations:

All operations between start_module and end_module must be performed by modules
i.e. jax.nn.relu() or x+1 is not allowed but can be converted by wrapping with elegy.to_module()
Only one input module is supported
All modules between start_module and end_module must have a single input and a single output
Resulting module is currently not trainable: .get_parameters() does not return any weights. Need some hints how to fix that.

I don't understand poetry. How can I add an additional package?

Codecov Report

Merging #115 (c525614) into master (3494cc7) will increase coverage by 2.50%.
The diff coverage is 97.58%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   76.94%   79.45%   +2.50%
==========================================
  Files         102      104       +2
  Lines        4746     4910     +164
==========================================
+ Hits         3652     3901     +249
+ Misses       1094     1009      -85

Impacted Files
Coverage Δ

elegy/nets/resnet.py
74.64% <87.50%> (+2.34%)
:arrow_up:

elegy/module_slicing_test.py
97.40% <97.40%> (ø)

elegy/module_slicing.py
99.09% <99.09%> (ø)

elegy/model/model_base.py
89.72% <100.00%> (+15.41%)
:arrow_up:

elegy/module.py
90.90% <100.00%> (+3.27%)
:arrow_up:

elegy/data/data_adapter.py
57.14% <0.00%> (-6.28%)
:arrow_down:

elegy/data/generator_adapter.py
41.30% <0.00%> (-4.70%)
:arrow_down:

elegy/data/data_handler.py
70.00% <0.00%> (-1.63%)
:arrow_down:

elegy/metrics/metric.py
68.18% <0.00%> (-1.39%)
:arrow_down:

elegy/losses/loss.py
78.18% <0.00%> (-0.77%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3494cc7...c525614. Read the comment docs.

The resulting module can now be retrained.

Hey @alexander-g ! This is amazing 😃 Can you share a bit about what strategy you are using to construct the new model?
I think this is a key feature to enable easier Transfer Learning and thus making Elegy more appealing for real use-cases.

cc @charlielito

I collect information about the main module and its submodules from the summaries feature. Then I construct a directed graph with the modules representing the edges and the inputs/outputs of the modules representing the nodes. If the outputs of module A are the same as the inputs of module B (as returned by id() ^1) then they are connected.
Then I simply search for the shortest path between start_module and the end_module and finally go along this path and execute the corresponding edges/modules.
^1: luckily this seems to work well in JAX, even when you do a x+=1, the value returned by id() changes, whereas in numpy it stays the same.

Modules with multiple inputs between start_module and end_module should now work too (e.g. skip connections in ResNet or U-Net). However this is getting more complex than I initially thought. I try to add as many comments as possible and cover everything with test cases but I sometimes get confused by this code myself.
What would be a good API for this functionality? Maybe add this as a method: Module.slice()?

I'll try to test this out so I can give a better opinion about toe API. In previous version we actually had something in the spirit of slice but it was only for the parameters dictionary, Module.slice seems more intuitive IMO.
We will have to

Added the Module.slice() method

One ugly detail: I import the module_slicing python module inside the function in module.py:line 622 because of a circular dependency. Was not able to fix that.
Moreover, because Module is the parent class of many other Modules like Conv, BatchNorm etc. mkdocs wants to add this method to the docs although it doesn't really make sense. Can I prevent that? Or should I add them anyway?
Apart from that, I think this is usable and can be merged. I'd like to use it in #126

One ugly detail: I import the module_slicing python module inside the function in module.py:line 622 because of a circular dependency. Was not able to fix that.

I ended moving all hooks like add_loss, add_summary, etc from elegy.hooks to module because of this. An alternative strategy is to set a dummy reference of module_slice on module and patch it on creation:
# module.py
module_slice = None
...

# modole_slice.py
import sys
from . import module

current_module = sys.modules[__name__]
module.module_slice = current_module
...

Not sure this pattern is strictly better.

Requesting review/testing @cgarciae
This is usable and #126 depends on it.

Requesting review/testing @cgarciae
This is usable and #126 depends on it.

Updated to 0.6.0
@cgarciae What is your opinion on this PR? Shall we continue or do you have other ideas on how to do transfer learning

My current opinion about this feature is this.
Pros

When it works its really simple
You can potentially use any intermediate layer

Cons

Can be brittle / silently fail if the author of the Module is not careful.
Currently only properly supported in Elegy Modules.

The only alternative I can think right now is to have an optional flag (e.g. return_multiple) that return return a dictionary with multiple outs that you would like to expose for the user e.g:
def call(...):
    if self.return_multiple:
        return dict(layer1=out1, layer2=out2, ...)
    else:
        return out

This solution is framework agnostic and easy to implement but is not automatic and requires effort from the author of the Module.

The only alternative I can think right now is to have an optional flag (e.g. return_multiple) that returns a dictionary with multiple outs that you would like to expose for the user e.g:

This is exactly what I want to avoid. This requires too much ahead-thinking, which is difficult to do especially if the module was written by another author. Say, I want to inspect an arbitrary inner layer of a ResNet, then I'd need to rewrite the call() of this Module

Can be brittle / silently fail if the author of the Module is not careful.

Could you explain what you mean with this or give an example? What should the author take care of? It is indeed brittle but rather because of the inner graph logic which is not yet fully "battle-tested".

This is exactly what I want to avoid. This requires too much ahead-thinking, which is difficult to do especially if the module was written by another author. Say, I want to inspect an arbitrary inner layer of a ResNet, then I'd need to rewrite the call() of this Module

I think we can add this feature as a show-case of want can be done even if only certain Modules support it.

Could you explain what you mean with this or give an example? What should the author take care of? It is indeed brittle but rather because of the inner graph logic which is not yet fully "battle-tested".

If I remember correctly this works with the hooks.add_summary feature and only works properly if all intermediate operations are properly added to the summaries, so a causal call to e.g. relu will not be registered and might give an incorrect slice if the author doesn't manually use add_summary.

I was told that in Pytorch you do this by taking a slice from Sequential. I like this API because its simple, and easy to implement since Sequential already has all the machinery to do this.

I was told that in Pytorch you do this by taking a slice from Sequential.

Sounds limited.
torchvision creates an additional class IntermediateLayerGetter to extract intermediate feature maps from a ResNet. I don't like this approach at all, it's not simple for the user.
I've started experimenting with a new method based on jax.make_jaxpr. This would allow using arbitrary JAX code like jax.nn.relu(x) or x+1, but start and end targets still need to be Elegy modules.

I've started experimenting with a new method based on jax.make_jaxpr. This would allow using arbitrary JAX code like jax.nn.relu(x) or x+1, but start and end targets still need to be Elegy modules.

This seems super useful, can you show how it cloud look?
My main worry with something so raw is that the names might be difficult to find (I am just guessing).


Fix build errors with codegen discovery flag enabled

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
Although fabric is not supported on RN Desktop, the codegen aspect of turbomodules should work correctly.
Building RNTester with the USE_CODEGEN_DISCOVERY=1 flag was throwing errors.
build command: USE_CODEGEN_DISCOVERY=1 bundle exec pod install;
[Codegen] Done.
TypeError [ERR_INVALID_ARG_TYPE]: The "args" argument must be of type object. Received type string ('/Users/shawndempsey/src/...)
    at new NodeError (node:internal/errors:372:5)
    at normalizeSpawnArguments (node:child_process:515:11)
    at execFileSync (node:child_process:854:13)
    at /Users/shawndempsey/src/shwanton_react-native-macos/scripts/generate-artifacts.js:238:7
    at Array.forEach (<anonymous>)
    at main (/Users/shawndempsey/src/shwanton_react-native-macos/scripts/generate-artifacts.js:211:15)
    at Object.<anonymous> (/Users/shawndempsey/src/shwanton_react-native-macos/scripts/generate-artifacts.js:322:1)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}

There was a change made to generate-artifacts d68d2095e92cf7b29113d40bef68ab05568a1884 that refactored usage to execFileSync. The error is thrown because execFileSync expects an array as it's second argument.
Changelog
[macOS] [Revert] Revert "Use execFileSync over execSync when messing with file paths in generate-artifacts.js"
[macOS] [Fix] Don't try and build Fabric example when USE_CODEGEN_DISCOVERY=1
Test Plan
Build RNTester w/ flag
USE_CODEGEN_DISCOVERY=1 bundle exec pod install
ScreenshotManager Native TurboModule should work from JS
https://user-images.githubusercontent.com/96719/182487353-a97f4252-beb4-4e74-abc3-c3e64bac6bba.mp4

@Shwanton Do you know if this change would work on RN-macOS 0.68? Considering whether it's worth back porting.

@Saadnajmi I tested this on the 0.68 branch so will work fine.

@amgleitman Could you take a second look at this? I worry about the changes of execFileSync -> execSync because security.

@shwanton execSync is more vulnerable to malformed input moreso than execFileSync, which is why we made the original change. Any chance you can refactor this to use execFileSync?

Yes, I'll refactor to use execFileSync & call w/ correct args.

@Saadnajmi Updated to use execFileSync!


read-through caching using docker on wsl

I'm trying to run BaGetter as a docker container using docker compose on wsl.
I can't seam to mount the appsettings.json file to a volume and so I tried as a temporary solution to enable read-through caching in the appsettings.json file. When I do that and restart the docker container I still can't find any nuget.org packages in the web interface.
volumes:
  data:

services:
  bagetter:
    image: bagetter/bagetter:latest
    environment:
    - ApiKey=APIKEY
    restart: unless-stopped
    volumes:
    - data:/data
    ports:
    - 5000:8080

For docker use it would be very convenient to have the settings files in a separate settings folder and not inside the app folder.
Is it possible to enable read-through caching with an environmental variable?
With the docker compose code above should the read-through caching work after enabling it in the appsettings.json or am I missing something?

Hi, first: the read-through cache does not mirror the search index, only downloads and caches specific packages that you request. You set up BaGetter as primary package source and nuget.org as secondary, then search/install your nuget.org packages from nuget.org. Any time you restore packages in a project, nuget will first request the packages from BaGetter, which will return them from the cache.
For configuration, you can use environment variables for that, which will work for any asp.net core application like that.
This will set the database type to Sqlite for example:
Database__Type=Sqlite

Database is the outer object you can see in the appsettings file (same level as ApiKey), Type is the property inside that. Note that they are connected using two underscores (_).
So read-through caching to nuget.org would look like this in an env file:
Mirror__Enabled=true
Mirror__PackageSource=https://api.nuget.org/v3/index.json

So add those to your environment array and you should be good to go.
You can get more specifics about configuration via environment variables from the official documentation.
You can see a simple example for running the docker image with an env file in the BaGetter documentation.
We're still working on the helm chart, so maybe there'll be an example for that soon too.


Removed redundant text-transform instances

This PR fixes "Refactor Code" and "Configure Tailwind" part of #8121.

I have removed all redundant text-transform instances from the stylesheets.
Disabled the text-transform Tailwind plugin.

I think there is one minor typo, looks good otherwise.

Can you point it out?

I have fixed the typo as mentioned.

@lb- have a look

Did not add this to changelog as already included in there (related to text transform)


Set msi as env variable

[ ] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
[ ] The pull request is targeting the dev branch.
[ ] The code has been validated to compile successfully by running go vet ./....
[ ] The code has been formatted properly using go fmt ./....

Directing jfrog-cli-core and jfrog-client-go to the following branches (for tests purposes):
https://github.com/jfrog/jfrog-client-go/pull/883
https://github.com/jfrog/jfrog-cli-core/pull/1094

@orz25,
If this pull request is solely for testing purposes, kindly consider creating it as a draft next time. This helps prevent accidental merges by ensuring it's not merged.


feat: Support caching of responses with Vary header, and fix browser caching of adjacent pages/endpoints

(fixes #9780)
Expand below to see recorded GIF of the issue - notice that on "forward" navigation the browser renders the endpoint response from cache, instead of the expected HTML response.
Before/after

Before

After

fix: Include Vary: Accept header on responses to GET requests
feat: Allow caching of requests with Vary (as long as it's not Vary: *)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This change broke an app of mine. When returning a fetch-response (via node undici) directly to SvelteKit, undici will throw TypeError: immutable, because the change in this PR tries to modify the (immutable) undici-header.
Is there a good fix for this or do I have to clone the response-object so that the headers are immutable again? 🤔
Example for reproduction
+server.ts
import type { RequestHandler } from './$types';

// Proxy requests to API
export const GET = (async ({ request, url, locals }) => {
	const headers = new Headers({ Authorization: `Bearer xyz` });

	return await fetch('https://api.test/', {
		method: request.method,
		headers,
		body: request.body,
		// @ts-ignore: https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1483
		duplex: 'half'
	});
}) satisfies RequestHandler;


OSF-5761 update GD provider to check for name duplication when creating new folder

Purpose
OSF-5761
Update GoogleDrive provider to check for name duplication when creating folder or uploading a file
Changes
Update def create_folder to check for existing folder with validate_path
Update def upload to check for existing folder with validate_path
Side effects
Most calls to create_folder and upload will now require an additional call to Google API.
While fixing a test for upload I had to change the call to validate_path in "def upload" from path.path to path.raw_path . After discussing with Fitz, I opened OSF-5769 to change all calls to validate_path in GoogleDrive provider to use path.raw .
#OSF-5761

This was fixed by d45391ddc22ec55baa12e4e63c7ee4660cc1e136 with a different approach.  Closing without merging


banner is funky!

replace with edited version:

@keelyjay What’s the difference?

the word christmas was too far upward. my stupid design program does that sometimes when I’m downloading.

On Nov 15, 2018, at 3:03 PM, Adam Garrett-Harris<EMAIL_ADDRESS>wrote:
@keelyjay https://github.com/keelyjay What’s the difference?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/lifestonechurch/lifestonechurch.net/issues/542#issuecomment-439206789, or mute the thread https://github.com/notifications/unsubscribe-auth/AXfBrUH8rJXiTydVSXVWdUQv7_y4JXJJks5uveTKgaJpZM4YjJwy.

Keely Williams
Lifestone Church Riverton
817.598.9567
lifestonechurch.net

Oh ok.

are you able to replace?


chapter extraction as segmentation

This pr extends the VideoSegmenter with the ability to extract available chapter information from video tracks and use this information for the track segmentation.

Any progress on this?

@Arnei Sorry, I had little time to come back to this.
I still have a patch that makes the title field optional (but parses it if it is present). I could push it if you want. However, it's still completely untested.

Pushed it. Hopefully, it works. Looking it over, I am unsure of the continues of the changed states. The force push adds one to state 7.

Sooo, I tried to create a FFMETADATA file with a chapter without a title, looking like this:
;FFMETADATA1
major_brand=isom
minor_version=512
compatible_brands=isomiso2avc1mp41
encoder=Lavf58.76.100

[CHAPTER]
TIMEBASE=1/1000
START=1
END=6000
title=The Pledge

[CHAPTER]
TIMEBASE=1/1000
START=6001
END=12000

[CHAPTER]
TIMEBASE=1/1000
START=12001
END=20000
title= The Prestige

Trying to add this file to a video results in wrong chapter information:
;FFMETADATA1
major_brand=isom
minor_version=512
compatible_brands=isomiso2avc1mp41
encoder=Lavf58.76.100
[CHAPTER]
TIMEBASE=1/1000
START=0
END=12001
title=The Pledge
[CHAPTER]
TIMEBASE=1/1000
START=12001
END=20000
title= The Prestige
[CHAPTER]
TIMEBASE=1/10000000
START=120010000
END=647000000
title= The Prestige

So maybe the title field is required after all? :')

Interesting, I looked at my test files, and one file produces the following ffmetadata:
;FFMETADATA1
encoder=Lavf60.3.100
[CHAPTER]
TIMEBASE=1/1000000000
START=1000000
END=10000000000
[CHAPTER]
TIMEBASE=1/1000000000
START=10001000000
END=40000000000
title=Middle\
Test
[CHAPTER]
TIMEBASE=1/1000000000
START=40001000000
END=60000000000
title=End

The title field is missing. Maybe it depends on the chosen container format (this one is webm), or it only "works" for the first chapter, which would indicate a bug in FFmpeg (either by accepting/processing corrupt ffmetadata files or by incorrectly setting the chapter information in the video files when missing titles are present). VLC displays the first chapter as Chapter 0.

Maybe it depends on the chosen container format (this one is webm)

Interesting. My original test was with a mp4 container. Another test I did with mp4 also failed. But with a webm it works (at least the title information is preserved correctly, webm seems to default to changing the timebase back to nanoseconds for whatever reason)

Are there already chapters defined in your input file?

All files I tried to add chapter information to did not previously have chapter information.


vertico: require embark in +vertico/embark-export-write

needed now that embark is lazy loaded

[X] It targets the develop branch
[X] I've searched for similar pull requests and found nothing
[X] This change is NOT in Doom's do-not-PR list: https://doomemacs.org/d/do-not-pr
[X] If I've bumped any packages, I've done so according to https://doomemacs.org/d/how2bump
[X] I've linked any relevant issues and PRs below
[X] All my commit messages are descriptive and distinct

Thanks!