Update distributed.py

update from https://github.com/NVIDIA/apex/blob/master/apex/parallel/distributed.py
to resolve https://github.com/NVIDIA/tacotron2/issues/32
it works well
root@a3404eef091b:/scratch/github/tacotron2# python -m multiproc train.py --output_directory=outdir --log_directory=logdir --hparams=distributed_run=True,fp16_run=True
['train.py', '--output_directory=outdir', '--log_directory=logdir', '--hparams=distributed_run=True,fp16_run=True', '--n_gpus=2', '--group_name=group_2018_07_04-043620', '--rank=0']
['train.py', '--output_directory=outdir', '--log_directory=logdir', '--hparams=distributed_run=True,fp16_run=True', '--n_gpus=2', '--group_name=group_2018_07_04-043620', '--rank=1']
FP16 Run: True
Dynamic Loss Scaling True
Distributed Run: True
cuDNN Enabled: True
cuDNN Benchmark: False
Initializing distributed
Done initializing distributed
/scratch/github/tacotron2/layers.py:35: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
  self.conv.weight, gain=torch.nn.init.calculate_gain(w_init_gain))
/scratch/github/tacotron2/layers.py:35: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
  self.conv.weight, gain=torch.nn.init.calculate_gain(w_init_gain))
/scratch/github/tacotron2/layers.py:15: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
  gain=torch.nn.init.calculate_gain(w_init_gain))
/scratch/github/tacotron2/layers.py:15: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
  gain=torch.nn.init.calculate_gain(w_init_gain))
Unexpected end of /proc/mounts line `overlay / overlay rw,relatime,lowerdir=/var/lib/docker/overlay2/l/N6KCJX53ZVFWPET6ANNB4G56TA:/var/lib/docker/overlay2/l/G45VXV2Q54CPZUAQL4LAGVMRNP:/var/lib/docker/overlay2/l/M66R6H36GKZBE6AJWO5XJT3WIN:/var/lib/docker/overlay2/l/Y3XCCSYU6OVYBAIFNMGDAJZK63:/var/lib/docker/overlay2/l/H4PMK5AXHM5Y3JQ62TNK6DU3XH:/var/lib/docker/overlay2/l/JZCXYXHRGEUZXQGQSF6YCGSSEO:/var/lib/docker/overlay2/l/TCNLFR6VQ6HLJS7RA73PHY6BPV:/var/lib/docker/overlay2/l/HEBHZMRUQRLODUD4FFXPR3QP55:/var/lib/docker/overlay2/l/C3HEY6CTKTDCB'
Unexpected end of /proc/mounts line `A53EKSMIG2CEV:/var/lib/docker/overlay2/l/VAYDIRS7RFDOWIACB6J55PIYCS:/var/lib/docker/overlay2/l/BE3VT6TJ3P4KLEMGEN62MQ77XU:/var/lib/docker/overlay2/l/OHFQX43BUCGRCPPB4AIKZZYGKM:/var/lib/docker/overlay2/l/6SKGKRFLXPUL3I4K73RNHTRJMI:/var/lib/docker/overlay2/l/WKUMSBR3ANKVVQNS4DNPKQ6Y2I:/var/lib/docker/overlay2/l/5VUVEPRQK7C5U3J7QHXRUDNS4R:/var/lib/docker/overlay2/l/TLGGZBFT3X2KJAO6CNIBPQAAVK:/var/lib/docker/overlay2/l/Z7F3AU7FEUUYMPZL5HMACWSCK2:/var/lib/docker/overlay2/l/OR2LHQCQNBIJCLNNSRS22AVQQR:/var/lib/do'
Unexpected end of /proc/mounts line `cker/overlay2/l/JXI5BOZPURCRDR7435WGUEE4YL:/var/lib/docker/overlay2/l/K72IUKSJE6CWH6NQIBZBHVLEEF:/var/lib/docker/overlay2/l/MZLD3BFR2FR7IIGUGEBAFUCZCB:/var/lib/docker/overlay2/l/DNRBNLILCVOG7O4Z33CY56N2ZB:/var/lib/docker/overlay2/l/7KMW2HAHUEQDD3YXCMSVWEMRF3:/var/lib/docker/overlay2/l/IWWISFRWP76WKCZZWVL7K3WWSS:/var/lib/docker/overlay2/l/H6JI6HY6GHWBCGLHDO5DFX7AER:/var/lib/docker/overlay2/l/OSAI5JM7ADXEEPEPQ2RU5744Z6:/var/lib/docker/overlay2/l/KNRKD7BXTAMSVT47YBIPHJY7V5:/var/lib/docker/overlay2/l/K2MS2FUDS'
Unexpected end of /proc/mounts line `Q2XSWMONGEF2OIXYY:/var/lib/docker/overlay2/l/FWATL67YTWL2TYXRQ4X5XGO7YL:/var/lib/docker/overlay2/l/LPOBTG2MZDRFUIED5G7VCHHGAD:/var/lib/docker/overlay2/l/LLJZJ3EZZQGPN6WKKO5BGX27BM:/var/lib/docker/overlay2/l/Z5SXBCKEGSFAPNTWQKBAY654JP:/var/lib/docker/overlay2/l/WK6EL2UGKFSULWXZOC77HYBYZC:/var/lib/docker/overlay2/l/5DCUE5SKFG7QN5M5T7KAO63Z6Y:/var/lib/docker/overlay2/l/UFJAPPR5TPCJI5OU64EJOWQLVO:/var/lib/docker/overlay2/l/UFV5HHWWX2RV2PATQYZXSMDBHE:/var/lib/docker/overlay2/l/OJZXT4SPS5M7GDV3Z7RTCPEKNS:/var/li'
Unexpected end of /proc/mounts line `overlay / overlay rw,relatime,lowerdir=/var/lib/docker/overlay2/l/N6KCJX53ZVFWPET6ANNB4G56TA:/var/lib/docker/overlay2/l/G45VXV2Q54CPZUAQL4LAGVMRNP:/var/lib/docker/overlay2/l/M66R6H36GKZBE6AJWO5XJT3WIN:/var/lib/docker/overlay2/l/Y3XCCSYU6OVYBAIFNMGDAJZK63:/var/lib/docker/overlay2/l/H4PMK5AXHM5Y3JQ62TNK6DU3XH:/var/lib/docker/overlay2/l/JZCXYXHRGEUZXQGQSF6YCGSSEO:/var/lib/docker/overlay2/l/TCNLFR6VQ6HLJS7RA73PHY6BPV:/var/lib/docker/overlay2/l/HEBHZMRUQRLODUD4FFXPR3QP55:/var/lib/docker/overlay2/l/C3HEY6CTKTDCB'
Unexpected end of /proc/mounts line `A53EKSMIG2CEV:/var/lib/docker/overlay2/l/VAYDIRS7RFDOWIACB6J55PIYCS:/var/lib/docker/overlay2/l/BE3VT6TJ3P4KLEMGEN62MQ77XU:/var/lib/docker/overlay2/l/OHFQX43BUCGRCPPB4AIKZZYGKM:/var/lib/docker/overlay2/l/6SKGKRFLXPUL3I4K73RNHTRJMI:/var/lib/docker/overlay2/l/WKUMSBR3ANKVVQNS4DNPKQ6Y2I:/var/lib/docker/overlay2/l/5VUVEPRQK7C5U3J7QHXRUDNS4R:/var/lib/docker/overlay2/l/TLGGZBFT3X2KJAO6CNIBPQAAVK:/var/lib/docker/overlay2/l/Z7F3AU7FEUUYMPZL5HMACWSCK2:/var/lib/docker/overlay2/l/OR2LHQCQNBIJCLNNSRS22AVQQR:/var/lib/do'
Unexpected end of /proc/mounts line `cker/overlay2/l/JXI5BOZPURCRDR7435WGUEE4YL:/var/lib/docker/overlay2/l/K72IUKSJE6CWH6NQIBZBHVLEEF:/var/lib/docker/overlay2/l/MZLD3BFR2FR7IIGUGEBAFUCZCB:/var/lib/docker/overlay2/l/DNRBNLILCVOG7O4Z33CY56N2ZB:/var/lib/docker/overlay2/l/7KMW2HAHUEQDD3YXCMSVWEMRF3:/var/lib/docker/overlay2/l/IWWISFRWP76WKCZZWVL7K3WWSS:/var/lib/docker/overlay2/l/H6JI6HY6GHWBCGLHDO5DFX7AER:/var/lib/docker/overlay2/l/OSAI5JM7ADXEEPEPQ2RU5744Z6:/var/lib/docker/overlay2/l/KNRKD7BXTAMSVT47YBIPHJY7V5:/var/lib/docker/overlay2/l/K2MS2FUDS'
Unexpected end of /proc/mounts line `Q2XSWMONGEF2OIXYY:/var/lib/docker/overlay2/l/FWATL67YTWL2TYXRQ4X5XGO7YL:/var/lib/docker/overlay2/l/LPOBTG2MZDRFUIED5G7VCHHGAD:/var/lib/docker/overlay2/l/LLJZJ3EZZQGPN6WKKO5BGX27BM:/var/lib/docker/overlay2/l/Z5SXBCKEGSFAPNTWQKBAY654JP:/var/lib/docker/overlay2/l/WK6EL2UGKFSULWXZOC77HYBYZC:/var/lib/docker/overlay2/l/5DCUE5SKFG7QN5M5T7KAO63Z6Y:/var/lib/docker/overlay2/l/UFJAPPR5TPCJI5OU64EJOWQLVO:/var/lib/docker/overlay2/l/UFV5HHWWX2RV2PATQYZXSMDBHE:/var/lib/docker/overlay2/l/OJZXT4SPS5M7GDV3Z7RTCPEKNS:/var/li'
FP16_Optimizer processing param group 0:
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([149, 512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024, 512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024, 256])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024, 512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024, 256])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([256, 80])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([256, 256])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096, 768])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096, 1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([128, 1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([128, 512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1, 128])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([32, 2, 31])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([128, 32])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096, 1536])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096, 1024])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([4096])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([80, 1536])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([80])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1, 1536])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([1])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 80, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([512])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([80, 512, 5])
FP16_Optimizer received torch.cuda.HalfTensor with torch.Size([80])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([80])
FP16_Optimizer received torch.cuda.FloatTensor with torch.Size([80])
Epoch:     0
train.py:200: UserWarning: invalid index of a 0-dim tensor. This will be an error in PyTorch 0.5. Use tensor.item() to convert a 0-dim tensor to a Python number
  if hparams.distributed_run else loss.data[0]
train.py:200: UserWarning: invalid index of a 0-dim tensor. This will be an error in PyTorch 0.5. Use tensor.item() to convert a 0-dim tensor to a Python number
  if hparams.distributed_run else loss.data[0]
OVERFLOW! Skipping step. Attempted loss scale:<PHONE_NUMBER>
OVERFLOW! Skipping step. Attempted loss scale:<PHONE_NUMBER>.0
OVERFLOW! Skipping step. Attempted loss scale:<PHONE_NUMBER>.0
OVERFLOW! Skipping step. Attempted loss scale: 536870912.0
OVERFLOW! Skipping step. Attempted loss scale: 268435456.0
OVERFLOW! Skipping step. Attempted loss scale: 134217728.0
OVERFLOW! Skipping step. Attempted loss scale: 67108864.0
OVERFLOW! Skipping step. Attempted loss scale: 33554432.0
OVERFLOW! Skipping step. Attempted loss scale: 16777216.0
OVERFLOW! Skipping step. Attempted loss scale: 8388608.0
OVERFLOW! Skipping step. Attempted loss scale: 4194304.0
OVERFLOW! Skipping step. Attempted loss scale: 2097152.0
OVERFLOW! Skipping step. Attempted loss scale: 1048576.0
OVERFLOW! Skipping step. Attempted loss scale: 524288.0
OVERFLOW! Skipping step. Attempted loss scale: 262144.0
OVERFLOW! Skipping step. Attempted loss scale: 131072.0
/scratch/github/tacotron2/fp16_optimizer.py:173: UserWarning: torch.nn.utils.clip_grad_norm is now deprecated in favor of torch.nn.utils.clip_grad_norm_.
  return torch.nn.utils.clip_grad_norm(fp32_params, clip)
Train iter       16 loss 49.316841 Grad Norm 10.800460 3.22s/it
/scratch/github/tacotron2/fp16_optimizer.py:173: UserWarning: torch.nn.utils.clip_grad_norm is now deprecated in favor of torch.nn.utils.clip_grad_norm_.
  return torch.nn.utils.clip_grad_norm(fp32_params, clip)
OVERFLOW! Skipping step. Attempted loss scale: 65536.0
Train iter       18 loss 40.572620 Grad Norm 24.962288 3.18s/it
Train iter       19 loss 23.865871 Grad Norm 18.794416 3.18s/it
Train iter       20 loss 13.441618 Grad Norm 15.939060 3.23s/it
Train iter       21 loss 7.951932 Grad Norm 8.706021 3.25s/it
Train iter       22 loss 6.590442 Grad Norm 6.689472 3.16s/it
Train iter       23 loss 6.191196 Grad Norm 6.757519 3.13s/it
Train iter       24 loss 5.509645 Grad Norm 6.079108 3.19s/it
Train iter       25 loss 5.355157 Grad Norm 7.703736 3.02s/it
Train iter       26 loss 4.984959 Grad Norm 5.296627 3.18s/it
Train iter       27 loss 4.464544 Grad Norm 4.186379 3.20s/it
Train iter       28 loss 4.435464 Grad Norm 4.557209 3.27s/it
Train iter       29 loss 4.334722 Grad Norm 8.194729 3.17s/it
Train iter       30 loss 4.163740 Grad Norm 3.329817 3.18s/it
Train iter       31 loss 3.863928 Grad Norm 3.288409 3.16s/it
Train iter       32 loss 4.195742 Grad Norm 10.788541 3.10s/it
Train iter       33 loss 3.772189 Grad Norm 1.974833 3.23s/it
Train iter       34 loss 4.499164 Grad Norm 11.733442 3.14s/it
Train iter       35 loss 4.278608 Grad Norm 7.804421 3.24s/it
Train iter       36 loss 4.177848 Grad Norm 5.837828 3.10s/it
Train iter       37 loss 3.894197 Grad Norm 5.884570 3.17s/it
Train iter       38 loss 3.733924 Grad Norm 2.546655 3.22s/it
Train iter       39 loss 3.920209 Grad Norm 9.012811 3.21s/it
Train iter       40 loss 3.944991 Grad Norm 8.163858 3.22s/it
Train iter       41 loss 3.694589 Grad Norm 3.208256 3.19s/it
Train iter       42 loss 3.463051 Grad Norm 2.812034 3.13s/it
Train iter       43 loss 3.742120 Grad Norm 3.808256 3.27s/it
Train iter       44 loss 3.648834 Grad Norm 1.847008 3.19s/it
Train iter       45 loss 3.873199 Grad Norm 6.838338 3.29s/it
Train iter       46 loss 3.941565 Grad Norm 6.975150 3.23s/it
Train iter       47 loss 3.706520 Grad Norm 2.846996 3.24s/it
Train iter       48 loss 3.709265 Grad Norm 4.831077 3.03s/it
Train iter       49 loss 3.582793 Grad Norm 1.885498 3.22s/it
Train iter       50 loss 3.525973 Grad Norm 0.910370 3.39s/it
Train iter       51 loss 3.470527 Grad Norm 3.723825 3.25s/it

works well


compile error

I have met an error when I was trying to compile it.
My os is the ubuntu subsystem in  Windows10
I type the  "./autogen.sh",but I got the following result:
Updating build configuration files for rnnoise, please wait....
./autogen.sh: 10: ./autogen.sh: autoreconf: not found
Can anyone help me?

try cmake. cmake works in windows (visual studio), mac (xcode), linux (make, ninja)
CMakeLists.txt example
cmake_minimum_required(VERSION 3.9)

project(rnnoise C CXX)

include_directories(
  include
  src
)

file(GLOB RNNOISE_SOURCES src/*.c)
message("RNNOISE_SOURCES: ${RNNOISE_SOURCES}")

add_executable(rnnoise_demo ${RNNOISE_SOURCES} examples/rnnoise_demo.c)
target_compile_definitions(rnnoise_demo PRIVATE TRAINING=0)

add_executable(denoise_training ${RNNOISE_SOURCES})
target_compile_definitions(denoise_training PRIVATE TRAINING=1)

Install autoreconf in Ubuntu WSL, and probably build-essentials too.

I had the same error, the solution was this: sudo apt-get install autoconf

brew install autoconf libtool automake
that my solution


Pixel3 xl

I did all the actions in the photo the action in the script was use the NP
Doesn't start the script , doesn't click in the screen
An old version used to click in wrong places
Last Version. 1327
**Device Info

Device model: [Pixel3 xl]
Screen size: [1440x2960]
Android Version: [ Android 11]
RAM: [4GB]

The troubleshooting Guide pretty clearly mentions that FGO should take up the whole screen for FGA to work. There should be no black areas except a notch. There's a black region on the right side of the image you provided. Unless you get rid of that, FGA won't work properly.


There are several errors in this docs

[10:03 AM] Max Guo
let me count,

miss default variables in variables.tf
need to set virtual-network and subnet previously
VM size wrong
helm install ingress-azure error

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20f12c89-40e2-076e-6135-64773551e673
Version Independent ID: c2d6ac4a-fad9-dbc1-d125-b267bcd2a566
Content: Tutorial - Create an Application Gateway ingress controller in Azure Kubernetes Service
Content Source: articles/terraform/terraform-create-k8s-cluster-with-aks-applicationgateway-ingress.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@gsxmax Thanks for your Feedback. I am assigning the issue to content author for checking on this and updating the document as applicable.

@TomArcherMsft Requesting you to review the feedback and add your comments on updating the document as appropriate.

Hi I am currently getting the following error
Unexpected ARM status code on GET existing App Gateway config: 403
E1218 00:30:26.825527       1 auth.go:49] Failed fetching config for App Gateway instance. Will retry in 10s. Error: network.ApplicationGatewaysClient#Get: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxxx' with object id 'xxxx' does not have authorization to perform action 'Microsoft.Network/applicationGateways/read' over scope '/subscriptions/xxxx/resourceGroups/xxx/providers/Microsoft.Network/applicationGateways/xxx' or the scope is invalid. If access was recently granted, please refresh your credentials."
this is after following the above tutorial.  I have verified the identity has the correct permisions.. and the aks SP has the correct rights on the identity.  As well the aadIdentity pod has the correct values
any help is appreciated

Thanks for your reply. Let me specify the issues I listed.

miss default variables in variables.tf , we have to set the default value for these variables
variable "resource_group_name"  "location"  "aks_service_principal_app_id" "aks_service_principal_client_secret" "aks_service_principal_object_id"
need to set virtual-network and subnet previously, need to create vnet aksVirtualNetwork <IP_ADDRESS>/8 with subnets kubesubnet <IP_ADDRESS>/16 and appgwsubnet <IP_ADDRESS>/16 before start the plan process. If not will meet an error called
"Error: pod_cidr and azure cannot be set together."
usually the default location would be central US, but the VM size Standard_D3_v2 is not supported in that location
4 this link https://appgwingress.blob.core.windows.net/ingress-azure-helm-package/ did not exist any more
Please correct these if possible. Thanks

This article was updated, but we forgot to close the GitHub Issue as we moved repos. Please let us know if the problems still exist. #please-close


ignore the workflow finished state and just run selection

Just run the selection for the user and don't test if the workflow is finished as the postgres selector will deal with retired / empty selection sets and show the user something.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

the postgresql selector will return some data if the selector returns nothing.

LGTM


[Bug] iceberg sink test lack of hadoop-client dependency

What happened

What you expected to happen

How to reproduce
run iceberg sink test
Environment
No response
InLong version
master
InLong Component
InLong Sort
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

we now only support test running on hadoop built by users

we now only support test running on hadoop built by users


NOISSUE - Remove domain from token

What type of PR is this?
This is a refactor because it changes the following functionality: it removes domain from token since it is passed with the URL.
What does this do?
It removes domain from token.
Which issue(s) does this PR fix/relate to?

Related Issue: N/A
Resolves: N/A

Have you included tests for your changes?
Yes.

Did you document any new/modified feature?
No

Notes

CLI suggestion: (This can be done in separate PR)
We can add context management to the CLI, allowing users to manage multiple sessions with domain_id and token.
Users can: Add a context with mg-cli add-context <DomainID> <token> <contextName> List all contexts using mg-cli list-context Switch contexts with mg-cli use-context <contextName>
This setup helps manage multiple sessions seamlessly.
LGTM

I agree. I have created a reference issue. I was thinking of something similar recently, like nats CLI command, or even kubectl.


Processing model

Blogify
In this milestone,I have done the following

Create custom methods

Users

A method that returns the 3 most recent posts for a given user.

Posts

A method that updates the posts counter for a user.
A method which returns the 5 most recent comments for a given post.

Comments

A method that updates the comments counter for a post.

Likes

A method that updates the likes counter for a post

@VICTOR-CHUKWU Thank you


Stop producing .packages

We added logic to produce the new packages file: .dart_tool/package_config.json, however we now generate both that and .packages. I think we should stop generating .packages, so that there is a single master, and less room for confusion.
Known dependants of the .packages file that will need to get fixed first:

[x] dart.dev docs: https://github.com/dart-lang/site-www/issues/3422
[ ] IntelliJ plugin: https://github.com/flutter/flutter-intellij/issues/5614

I moved this to the SDK tracker as it's such a cross-cutting issue.

In my personal workflow on small code snippets (often copy/paste from bug reports) I use
dart/sdk$ sdk/bin/dart --packages=.packages  /some/path/foo.dart
dart/sdk$ sdk/bin/dart2js_developer --packages=.packages  /some/path/foo.dart

What would this look like if .packages was removed?
I have over 1200 of these small programs, so creating some kind of project for each one would cumulatively have been quite a burden.

Can't you just pass a package_config.json file instead?
dart/sdk$ sdk/bin/dart --packages=package_config.json /some/path/foo.dart
dart/sdk$ sdk/bin/dart2js_developer --packages=package_config.json  /some/path/foo.dart

Yes, we'd have to replace our current .packages file with a package_config.json file, but that is an SDK specific issue.

Yes, we'd have to replace our current .packages file with a package_config.json file, but that is an SDK specific issue.

@rakudrama - this issue refers to the .packages file created by dart pub get in packages. I think you're referring to doing development directly in the SDK repo. That .packages file removal is tracked at https://github.com/dart-lang/sdk/issues/48275
We already have a replacement file it the SDK repo, you can change --packages=.packages to --packages=.dart_tool/package_config.json. This should work today.

An issue we discovered today that is worth tracking before we stop generating .packages files:

[ ] https://github.com/dart-lang/sdk/issues/48939

PR for this: https://github.com/dart-lang/sdk/issues/47431
I'll move the VM issue discussed in https://github.com/dart-lang/sdk/issues/47431#issuecomment-1115115928 to https://github.com/dart-lang/sdk/issues/48272

Roll is https://dart-review.googlesource.com/c/sdk/+/244621

Roll is https://dart-review.googlesource.com/c/sdk/+/244621

Actual roll is: https://dart-review.googlesource.com/c/sdk/+/244623


require() issue

Can anyone explain this?
> require('node-chartist')
Error: ENOENT: no such file or directory, open '/Users/willlyrob/projects/therms/node_modules/node-chartist/node_modules/chartist/dist/chartist.js'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.fs.readFileSync (fs.js:397:15)
    at Object.<anonymous> (/Users/willlyrob/projects/therms/node_modules/node-chartist/lib/chart.js:14:26)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)

This is the culprit: https://github.com/panosoft/node-chartist/blob/master/lib/chart.js#L14

Hello @crobinson42,
Thank you for posting this issue. This is most likely related to the following: https://github.com/panosoft/node-chartist/issues/2#issuecomment-174591453
Please feel free to reopen this issue if that does not resolve it for you.
Best,
Alex

In other words, the "culprit" should be:
var chartistSource =  fs.readFileSync(path.resolve(__dirname, '../../chartist/dist/chartist.js'));
in stead of:
var chartistSource =  fs.readFileSync(path.resolve(__dirname, '../node_modules/chartist/dist/chartist.js'));

Hello all,
This has been resolved in +<EMAIL_ADDRESS>Best,
Alex


chore: release 0.18.0

:robot: I have created a release *beep* *boop*
0.18.0 (2019-10-09)
Bug Fixes

make JwtClaims.newBuilder() public (#350) (6ab8758)
move autovalue into annotation processor path instead of classpath (#358) (a82d348)

Dependencies

update Guava to 28.1 (#353) (f4f05be)

Documentation

fix include instructions in google-auth-library-bom README (#352) (f649735)

This PR was generated with Release Please.

The release build has started, the log can be viewed here. :sunflower:

The release build failed! Please investigate!

The release build has started, the log can be viewed here. :sunflower:

The release build failed! Please investigate!

The release build has started, the log can be viewed here. :sunflower:

The release build failed! Please investigate!

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Add hook points to allow for a proper NoGap plugin

This is just a subset of changes from #5290.
Motivation is @mourner's comments in https://github.com/Leaflet/Leaflet/pull/5290#issuecomment-286386260 , about the tile gap not being a core issue. This PR just allows plugin authors to run some code whenever a GridLayer  creates or deletes a tile zoom-level container, and whenever a tile becomes fully opaque. That, in turn, will allow much cleaner code for L.TileLayer.NoGap, since right now it reimplements the whole tile pruning logic.

Once/if this is merged, then the NoGap plugin can finally take form. See https://github.com/Leaflet/Leaflet.TileLayer.NoGap/pull/3


io.swagger.v3.jaxrs2.integration.SwaggerLoader.setSortOutput(java.lang.Boolean)

Hi,
When trying to execute resolve task.
The following error is displayed:
Cause: io.swagger.v3.jaxrs2.integration.SwaggerLoader.setSortOutput(java.lang.Boolean)

build.dependsOn(resolve)

resolve {
  outputFileName = 'Swagger'
  outputFormat = 'YAML'
  prettyPrint = 'TRUE'
  classpath = sourceSets.main.runtimeClasspath
  resourcePackages = ['com.test.controller']
  outputDir = file('doc/')
  openApiFile = project.file("openapi-config.yml")
  readAllResources = true
  alwaysResolveAppPath = true
  buildClasspath = configurations.swaggerDeps
}

JAVA 11

I had the same issue. It turned out that the project dependencies has "org.apache.cxf:cxf-rt-rs-service-description-openapi-v3" that pulled an older version of "io.swagger.core.v3:swagger-jaxrs2" into the classpath.


Visual Test for crosshairs not working as designed

In playing with the css for the multi series I noticed the visual test for crosshairs is trying to set the colour of the paths:
        .decorate(function(sel) {
            sel.style('fill', function(d) { return color(d.date.getDay()); });
        })

The style gets applied on the g rather than the path within it.
The current css applies the default colour on .bar>path.
Could be fixed by change the css to apply to g.bar instead. The change to a series class I was trying for the multi series also fixed it.
Old output:

Expected output:

Alternatively could change the visual tests to decorate the path with the fill:
        .decorate(function(sel) {
            sel.select('path').style('fill', function(d) { return color(d.date.getDay()); });
        })

This looks like a hangover from the original implementation of the bar
series that was not updated when the series was updated. I suppose the fix
depends upon the resolution of the #629.
On Mon, 19 Oct 2015 at 21:45 James Dunkerley<EMAIL_ADDRESS>wrote:

Alternatively could change the visual tests to decorate the path with the
fill:
    .decorate(function(sel) {
        sel.select('path').style('fill', function(d) { return color(d.date.getDay()); });
    })

—
Reply to this email directly or view it on GitHub
https://github.com/ScottLogic/d3fc/issues/637#issuecomment-149342148.

This can be closed as fixed by #642

Thanks @jdunkerley


Testing UE-IoT-non3GPP with free5gC

Hello!
I would want to know if there is anyone who has tested this project with the free5gC? If yes it has worked fine?
We're working on the deployment of free5gC on top of Kubernetes. Furthermore, we've deployed the UERANSIM and all works fine when enabling the ULCL feature and when not. I'd like to add the UE-IoT-non3GPP simulator to my project so anyone has already tested it?
Thank you in advance!

@raoufkh,
Firstly, i'm sorry for the late reply.
I didn't tested non3GPP-access with free5GC, directly. However, non3GPP-access is built over my5G-core that is currently a fork of the free5GC project, with some extensions to facilitate the deployment.
We recently added a use case using an wifi connection as a non-trusted access network and works successful with my5G-core and non3GPP-access. Maybe it might be interesting for you.

Hello!
I would want to know if there is anyone who has tested this project with the free5gC? If yes it has worked fine?
We're working on the deployment of free5gC on top of Kubernetes. Furthermore, we've deployed the UERANSIM and all works fine when enabling the ULCL feature and when not. I'd like to add the UE-IoT-non3GPP simulator to my project so anyone has already tested it?
Thank you in advance!

@raoufkh,
Firstly, i'm sorry for the late reply.
I didn't tested non3GPP-access with free5GC, directly. However, non3GPP-access is built over my5G-core that is currently a fork of the free5GC project, with some extensions to facilitate the deployment.
We recently added a use case using an wifi connection as a non-trusted access network and works successful with my5G-core and non3GPP-access. Maybe it might be interesting for you.

Hello!
First of all, thank you for response!
If I understand correctly, the use of an AP is an extra usecase? If this is the case, we'll try first to establish the simpler one from the Usage section in the WIKI in order to simulate a non3gpp access. For that, can you provide more information on the parameters to pass to the script, please?

What do ue_addr and ue_port refer to?
Is n3iwf_address the IP address used by the N3IWF for the IKE daemon?
Is ike_bind_addr the IP address which should be used by the my5G-non3GPP-access? If true I guess that it must be in the same network as the one used by the **N3IWF" for the same purpose.

Best regards,
Raouf

Hello!

If I understand correctly, the use of an AP is an extra usecase? Yes! The non-3GPP-acess wifi use-case uses an wifi connection instead of virtual ethernet (veth) between UE (User Equipment) and N3IWF, directly. The simpler use of non3GPP-access uses a veth (generic conection) to connect UE and N3IWF. Note that i refer UE instead of non3GPP-access because non-3GPP-access uses an UE NAS signalling.

What do ue_addr and ue_port refer to? This parameters indicates the ipv4 address of UE (User Equipment) and the port  which the UE is listening to trigger procedures. This material can be usefull for more informations.

Is n3iwf_address the IP address used by the N3IWF for the IKE daemon? Yes, the n3iwf_address is the IPv4 address used  by N3IWF to communicate directly with UE. In the material that I mentioned in above question, the ip address of N3IWF for IKE daemon is <IP_ADDRESS>/24.

Is ike_bind_addr the IP address which should be used by the my5G-non3GPP-access for the IKE daemon? If true I guess that it must be in the same network as the one used by the N3IWF for the same purpose. Yes, ike_bind_address is the ipv4 address of UE to communicate directly with N3IWF component. As in previous answer, the ip address of UE for IKE daemon is <IP_ADDRESS>/24. Therefore, UE and N3IWF are in the same subnet (<IP_ADDRESS>/24).

For our deployment of the Free5gc, the N3IWF has 3 interfaces (the first with AMF, the second with UPF and the third for connection with UPF), exactly as mentioned here. Is the same configuration. N3IWF has 3 interfaces: the first connects to the AMF, the second connects to the UPF, and the third is for IKE daemon (connect with UE).

Best regards,
Mario

Hello Mario
Thank you very much for this clear explanation!
Regards,
Raouf


Question About Annotations

Hi,
Thanks for releasing such a great dataset!  I have two questions about the anntations:

Is it possible to get the type of the task as well as the instructional manual (e.g. the recipe for cooking) for each video?
Is there a plan to also release the coarse-level language annotations as mentioned in the paper?

Thanks

Hi,
Thank you for your interest in our dataset! Here are the responses:

We will release the type of the task and update the video meta within this week. For the instructional manual, there is in fact no instructional manual but only the exo-view videos as instructions.
Yes, the coarse-level annotations will be released within the next week.

Thanks for the prompt response. It's great to hear that the annotations will be released soon!
If the task type is associated with a video, can we use its example procedure listed in Table S10 from the supplementary material as the instructional manual? Is there much deviation between that and the actual procedure carried out by the task performers?

It is okay to use Table S10 for Tasks 1-6, for tasks 7 and 8 there may be many repetition steps however now shown in the table.

Thanks for the information!

Thanks for the information!

Hi, the task for each video has just been updated in the metafile. Feel free to re-open this issue if you have further questions!


YouTube - url parse failed

新的视频地址像 https://www.youtube.com/watch?v=SFfpK3FoNSg 会报错  url parse failed

Same issue. please fix it,

对比分析了一下，发现是数据格式变了，我试着修复一下，数据格式有点复杂……

youtube.go line 162 returns nil
utils.MatchOneOf(streamType, (\w+)/(\w+);)
after that
exts := utils.MatchOneOf(streamType, `(\w+)/(\w+);`)
			if exts == nil || len(exts) < 3 {
				return nil, extractors.ErrURLParseFailed
			}

annie https://www.youtube.com/watch?v=E2_1y_9zGQs
Downloading https://www.youtube.com/watch?v=E2_1y_9zGQs error:
url parse failed

Something goes wrong while parsing that json

Same issue

There is no url_encoded_fmt_stream_map in the html string. Youtube probably changed something again

@iawia002
There is a problem with the youtube download. It's probably something with the signature.
Would be great if you could look into this if you have time.
Also happy New Year :)

Sorry for the delay, please try 0.9.7


add some customization hints to the readme.md

Is your feature request related to a problem? Please describe.
Add some basic customization hints into the readme.md also where at the BBB documentation it is clarified and how to extend tasks (greenlight) or application instance customization.
Additional context
Also clarify how updates will be processed via Amazon Cloudformation

Also add aws iam create-service-linked-role --aws-service-name ecs.amazonaws.com

solved with #39


Should typeahead_suggestions return locations for which there is no associated data sources?

Shoutout to @joshuagraber for bringing this to my attention
Currently, the /typeahead_suggestions endpoint retrieves locations based solely on whether those locations (counties, states, localities, etc.) exist within our database. They don't take into account whether the state, county, etc. exists, but we don't have any agencies or data sources associated with it.
So there are some scenarios, such as the below, where no results are returned:
http -A bearer -a $VITE_ADMIN_API_KEY GET http://localhost:5000/search/search-location-and-record-type \state==Kansas county==Dickinson locality==Abilene --print=b

{
    "count": 0,
    "data": []
}

So do we want the typeahead endpoint to suggest locations, even if we don't have data associated with them?
Will modifying this logic affect the speed of the endpoint?
Nope! The typeahead suggestions are derived from what is called a "Materialized View", meaning a view that runs the underlying view query ahead of time and stores the result as a kind of pseudo-table that is retrieved as easily as regular tables (while non-materialized views must rerun the underlying query every time and are thus slower). While the logic for generating the Materialized View will need to be modified, the speed at which we pull data from the materialized view after its initial generation wouldn't be affected.

The short answer is "yes", but we could also reorder them to serve places with the highest number of sources first! That could happen in the materialized view, perhaps?
None of our places is truly empty because they have agencies with homepages, and are fertile grounds for data requests.

The short answer is "yes", but we could also reorder them to serve places with the highest number of sources first! That could happen in the materialized view, perhaps?

Yep, that could happen! I could add a means to count how many sources are in each category, and add that to the materialized view. Perhaps we may even want that on display in the Typeahead Suggestions as well -- they see the suggested location, as well as how many sources are associated with that location 🧠.

The short answer is "yes", but we could also reorder them to serve places with the highest number of sources first! That could happen in the materialized view, perhaps?

I like this idea. Most sources first makes sense.

Perhaps we may even want that on display in the Typeahead Suggestions as well -- they see the suggested location, as well as how many sources are associated with that location 🧠.

I like this idea, too. May want to think about a clever UI case on the search results page for when there are no results (or even redirect to the request page instead?) but yeah, I like the idea of giving the user as much info up front as possible.

@joshuagraber @maxachis ok, I think the simplest solution which still helps folks is to show some copy on search results like:
"We don't know about data in this area yet, but we can help you locate it. .
You can also  we should know about.
Here are aggregated sources which may contain information about the place you searched:"
then, we show the federal/state/county sources as already planned.
Fortunately, we are already planning to show "upstream" results for the county and state which contain the locality, plus federally aggregated ones. This increases the chances we will show them something.
Does this scratch the itch?

Fortunately, we are already planning to show "upstream" results for the county and state which contain the locality, plus federally aggregated ones. This increases the chances we will show them something.

@josh-chamberlain Yes, I see your point, but, that's not how it currently works.
I.e. a search for Cleveland, GA shows no county/state/federal results, while a search for Georgia shows quite a few.
But yeah, I'm sure that's just a matter of some API logic that @maxachis can solve for.
Could I ask for a refinement on the "no results" copy you shared above? Then I can work it into the client once the API changes are also made.

But yeah, I'm sure that's just a matter of some API logic that @maxachis can solve for.

It is indeed!
First things first, though, to update this, I'll need to make sure the agency-data source link is kosher, so I'm working on an issue for that in #457 .
Once that's complete, I can then update this.

@joshuagraber roger that. I updated my comment—it had eaten everything inside < > which are intended to be links to our new forms.
Just to keep the links to related issues flowing, https://github.com/Police-Data-Accessibility-Project/data-sources-app-v2/pull/94 is the previous work on this. However, I think that PR addresses the formatting and not the returning of additional upstream sources. I could have caught that before but I played fast and loose with the approvals. @maxachis
btw, it's so cool that we can just pass links to searches back and forth. I don't take that for granted 🎉

@josh-chamberlain @joshuagraber So here's a wrench I've been noodling over -- when we talk about how many data sources are associated with a location, it's not immediately clear what "associated" means.
Does it mean how many data sources are associated with

Agencies whose jurisdiction matches that location only? (e.g., for locality return locality_num
Agencies in that jurisdiction or in higher order jurisdictions  (e.g., for locality return locality_num + county_num + state_num)
Agencies in that jurisdiction or in any lower order locations within that jurisdiction (e.g., for county return county_num + locality_num for each locality in county).

Maybe it makes sense to return all three, although at that point this becomes quite a wordy typeahead suggestion.

So here's a wrench I've been noodling over -- when we talk about how many data sources are associated with a location, it's not immediately clear what "associated" means.

@maxachis  My thinking is that we can solve for all of this.
For each location level, we return:

That level's results, any more-specific results, and any less-specific results, with the counts applied to each locality level. The web app auto-scrolls to the level for which the user searched (or the most-specific level that has results, if no results appear at the level for which they searched).
To determine which more-specific results to render, that's easy. If a searched-for locality is contained within a county, we return those results. If a searched-for county is contained with in a state, we return those results.
To determine which less-specific results, that gets a little more hairy.
Consider: User searches for Gulf Breeze, Santa Rosa County, Florida. There are no results for Gulf Breeze. But there is one result for Santa Rosa County, and plenty of results for Florida.

So then, do we return all county-level and state-level results for the Gulf Breeze search, even though the agencies in question are not headquartered in Gulf Breeze? Or do we only return higher-level results for agencies that are contained within the location level searched?
Wyt @josh-chamberlain?

So then, do we return all county-level and state-level results for the Gulf Breeze search, even though the agencies in question are not headquartered in Gulf Breeze? Or do we only return higher-level results for agencies that are contained within the location level searched?

My thinking, and @josh-chamberlain can contradict me on this, is that the end user is more likely to be interested in agencies with jurisdictional, rather than purely locational, relevance, to the location in question.  I want to learn about what regulations impact my Alpaca farm, so I go to adap.io for information about Alpaca Data, and search for Pennsylvania, Allegheny County, Carnegie. There is an "Allegheny County Alpaca Regulations Board" whose regulations would impact my mom and alpopca farm, but it is headquartered in Pittsburgh rather than Carnegie. Even though it's not located in Carnegie, I as an Alpaca farmer probably still care about it, because it would have info relevant to my own farm. 🦙

the end user is more likely to be interested in agencies with jurisdictional, rather than purely locational, relevance, to the location in question

Good point, yeah, that makes sense to me.

@maxachis ah, for our purposes, for now, I think we must pretend that location and jurisdiction are the same. In your example, that agency would be listed in Allegheny County in our database, with no mention of where it is headquartered (other than maybe lat/lng for mapping).
Our search is indeed intended to reveal additional higher order and lower order sources, for the reasons mentioned above and in the body of #409. However, for the purposes of this question, we are choosing which locations to list first in the typeahead. The idea is to help people find the location they are most likely searching for, because places with more people have more data.
I believe this can be very simple: A location has "associated data sources" if the agencies which belong to that specific location have data sources. When the person makes their search, we will show them more stuff—but we don't necessarily need the typeahead ordering logic to respect all that, too.
In the typeahead, most of the time, counties and localities inside them aren't going to appear in the same list unless they have the same name (which does happen, especially in smaller counties).
I appreciate your alpaca puns, but I'm kind of speechless.


Add async support

There are lots of async libraries. Add support for an implementation-agnostic way of doing catui operations. These would be documented so that someone using an async library like boost asio or libuv which manage descriptors could very easily hook this up to their runtime

Seems like adding synchronous functions for different stages of asynchrony will suffice


[stable/rabbitmq] Support config file or extra environment variables

Is this a request for help?: no

Is this a BUG REPORT or FEATURE REQUEST? (choose one):  FEATURE REQUEST
Version of Helm and Kubernetes:

helm v2.7.2
kubernetes v1.8.3

Which chart:
stable/rabbitmq
What happened:
Could not configure all rabbitmq parameters. Only a subset of parameters are exposed in values.yaml, limited to what the docker image documents as environment variables (https://github.com/bitnami/bitnami-docker-rabbitmq#environment-variables).
What you expected to happen:
I expected to be able to configure any rabbitmq parameter (https://www.rabbitmq.com/configure.html#config-items).
Anything else we need to know:
It could be done by allowing an extra rabbitmq.conf file (https://github.com/bitnami/bitnami-docker-rabbitmq#configuration-file), or by exposing the RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS env var (see in https://www.rabbitmq.com/configure.html#define-environment-variables and https://hub.docker.com/_/rabbitmq/).

@thomas-riccardi Is it possible to configure SSL for rabbitmq helm chart, and if so what is the config parameters?

@alseddnm I don't have a solution for your scenario; this seems to be another use-case for supporting extra config files indeed.

/remove-lifecycle rotten


Integrations: upstage LLM and Embeddings

Description
Upstage is one of the most up-and-coming LLM providers, and many of users want to use their LLM and Embeddings api, so in this PR, we've added an Upstage LLM and  Embeddings integration.
Also we deprecated and added warning on solar LLM integration which will not be managed anymore.
Fixes #13192 (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[x] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[x] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

Thanks for detailed instruction.

@logan-markewich tests failed. But when I test it it success. do i need something to do additionally?
✕ llama-index-integrations/embeddings/llama-index-embeddings-upstage/tests/integration_tests/test_integrations.py:tests failed in 6.16s.
✕ llama-index-integrations/embeddings/llama-index-embeddings-upstage/tests/unit_tests/test_embeddings_upstage.py:tests failed in 6.48s.

@logan-markewich Would you check this action?, 3.10 passed but 3.8 and 3.9 were canceled because of long running tasks.

Can you merge main again? There was some issues that were recently fixed

@logan-markewich action unit test failed with
==================================== ERRORS ====================================
_________ ERROR collecting tests/unit_tests/test_embeddings_upstage.py _________
ImportError while importing test module 'llama-index-integrations/embeddings/llama-index-embeddings-upstage/tests/unit_tests/test_embeddings_upstage.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
llama-index-integrations/embeddings/llama-index-embeddings-upstage/tests/unit_tests/test_embeddings_upstage.py:4: in <module>
    from llama_index.embeddings.upstage import UpstageEmbedding
E   ModuleNotFoundError: No module named 'llama_index.embeddings.upstage'
------------------------------- Captured stderr --------------------------------

I think I have pyproject set up correctly, all tests pass on my local as well, is there anything else I need to set up?

@JuHyung-Son For the life of me I can't figure out why the embedding tests are failing. I've noticed that any class that inherits openai embeddings, pants (our cicd tool) does not properly detect dependencies.
My advice is we can keep the tests (since they are nice for local dev), but we need to wrap the import in a try/except in the tests, and skip if not found

Also just and fyi, the embeddings pyproject.toml is missing the llama-index-embeddings-openai dependency (adding it doesn't fix tests, but is needed to publish the package properly)


Why is property Getter playing true after I make a Player?

Expected behaviour
Right after I create an instance with new Plyr('#plyrjs')
plyr playing property should be false, unless there is a movie/media playing?
Actual behaviour
playing is returned as true instead of false.
Environment
Using plyr  v3.1.0

Browser: Chrome
Version: v65
Operating System: Windows 7
Version: 7 :)

Steps to reproduce
Here is my HTML...  I removed the default video key thinking that was causing playing to be true.

Here is my plyr Setup routine

Here is the output of above as seen on the Chrome console...

I also tried in my Setup() above calling .stop() or setting .source to {} but playing remains true.
How to specify the progressive Enhancements in the HTML without specifying a video at startup ??
Thank you.

This should be resolved in v3.2.0 👍

One final point
How can I specify the "Progressive Enhancements" in the HTML without specifying a video at startup ??
Thank you.

How can I specify the "Progressive Enhancements" in the HTML without specifying a video at startup

It's the same thing, so you can't.


https leads to an error

The 2022 internet uses https-by-default.
But not here:
http://hprc-browser.ucsc.edu/ works, https://hprc-browser.ucsc.edu/ does not. Has this never come up before?

this still does not work


wireguard.sh -r fails under Debian 10

Failure info:
root@vultr:~# /opt/wireguard.sh -r
[Mon Oct 12 01:33:59 UTC 2020] Check OS version
[Mon Oct 12 01:33:59 UTC 2020] Install dependencies for wireguard
[Mon Oct 12 01:33:59 UTC 2020] apt-get update
[Mon Oct 12 01:34:05 UTC 2020] apt-get -y install qrencode
[Mon Oct 12 01:34:06 UTC 2020] apt-get -y install iptables
[Mon Oct 12 01:34:07 UTC 2020] apt-get -y install bc
[Mon Oct 12 01:34:08 UTC 2020] apt-get -y install gcc
[Mon Oct 12 01:34:26 UTC 2020] apt-get -y install make
[Mon Oct 12 01:34:27 UTC 2020] apt-get -y install libmnl-dev
[Mon Oct 12 01:34:28 UTC 2020] apt-get -y install libelf-dev
[Mon Oct 12 01:34:29 UTC 2020] Install wireguard from repository
[Mon Oct 12 01:34:29 UTC 2020] apt-get update
[Mon Oct 12 01:34:35 UTC 2020] apt-get -y install wireguard
Extracting templates from packages: 100%
[Mon Oct 12 01:34:49 UTC 2020] Create server interface: /etc/wireguard/wg0.conf
[Mon Oct 12 01:34:49 UTC 2020] Create client interface: /etc/wireguard/wg0_client
[Mon Oct 12 01:34:49 UTC 2020] Generate a QR Code picture with client interface
[Mon Oct 12 01:34:49 UTC 2020] qrencode -s8 -o /etc/wireguard/wg0_client.png < /etc/wireguard/wg0_client
[Mon Oct 12 01:34:49 UTC 2020] Enable IP forward
[Mon Oct 12 01:34:49 UTC 2020] Setting firewall rules
[Mon Oct 12 01:34:49 UTC 2020] Starting WireGuard via wg-quick for wg0
[Mon Oct 12 01:34:49 UTC 2020] systemctl daemon-reload
[Mon Oct 12 01:34:49 UTC 2020] systemctl start wg-quick@wg0
Job for<EMAIL_ADDRESS>failed because the control process exited with error code.
See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details.
[Mon Oct 12 01:34:49 UTC 2020] Execution command (systemctl start wg-quick@wg0) failed, please check it and try again.

root@vultr:~# systemctl status<EMAIL_ADDRESS>●<EMAIL_ADDRESS>- WireGuard via wg-quick(8) for wg0
   Loaded: loaded<EMAIL_ADDRESS>disabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2020-10-12 01:34:49 UTC; 38s ago
     Docs: man:wg-quick(8)
           man:wg(8)
           https://www.wireguard.com/
           https://www.wireguard.com/quickstart/
           https://git.zx2c4.com/wireguard-tools/about/src/man/wg-quick.8
           https://git.zx2c4.com/wireguard-tools/about/src/man/wg.8
  Process: 8158 ExecStart=/usr/bin/wg-quick up wg0 (code=exited, status=1/FAILURE)
 Main PID: 8158 (code=exited, status=1/FAILURE)

Oct 12 01:34:49 vultr.guest systemd[1]: Starting WireGuard via wg-quick(8) for wg0...
Oct 12 01:34:49 vultr.guest wg-quick[8158]: [#] ip link add wg0 type wireguard
Oct 12 01:34:49 vultr.guest wg-quick[8158]: RTNETLINK answers: Operation not supported
Oct 12 01:34:49 vultr.guest wg-quick[8158]: Unable to access interface: Protocol not supported
Oct 12 01:34:49 vultr.guest wg-quick[8158]: [#] ip link delete dev wg0
Oct 12 01:34:49 vultr.guest wg-quick[8158]: Cannot find device "wg0"
Oct 12 01:34:49 vultr.guest systemd[1]<EMAIL_ADDRESS>Main process exited, code=exited, status=1/FAILURE
Oct 12 01:34:49 vultr.guest systemd[1]<EMAIL_ADDRESS>Failed with result 'exit-code'.
Oct 12 01:34:49 vultr.guest systemd[1]: Failed to start WireGuard via wg-quick(8) for wg0.

Fixed.


Give default for mandatory attributes when not present in cluster

Problem

Fixes #17275
Many cluster instances are giving 0x86(unsupported attribute) for mandatory attributes.

Change overview
Certain attributes like ClusterRevision and FeatureMap are mandatory for every cluster instance, but there are many instances where these mandatory fields are missing. We will give default safe values when attributes are missing from cluster instance and we
Testing
How was this tested? (at least one bullet point required)

Manual - Using examples/lighting-app which doesn't have ClusterRevision in DiagnosticLogs Cluster, confirmed I am getting the default value of 1. FeatureMap give default value of 0

Just to telegraph my latest thinking on here:
With this first approach/attempt, I don't think it is that bad to add in a default roughly where I am putting this in if we only need to read a value, but when you factor in adding things so that it is populated in the AttributeList and taking into account wildcards (to be spec compliant), it starts to look a little hacky to me which is a sign I am venturing down the wrong path.
I am starting to explore a different approach all together. I am thinking about modifying the script that generates attributes. I think the script should populate the mandatory missing attribute entries for each cluster with a default value. I still haven't dug deep enough to know where exactly this code generating section is. If someone has pointers in the next hour, feel free to comment here and let me know, or just message me on slack. For now I am venturing down the path of seeing how ./scripts/tools/zap_regen_all.py produces the generated files. Feel free to let me know if you already know this path is likely even worse then the first path
Feel free to comment if there are other approaches that I am missing, or if I am being naive in some way for the new approach I am starting to venture down.

which is a sign I am venturing down the wrong path

It's a tradeoff.
We could change the codegen to generate these things always, with 0/1 as a value if not specified otherwise, at some RAM cost.
Or we could pay some codesize cost and not have the RAM cost...

It's a tradeoff.
We could change the codegen to generate these things always, with 0/1 as a value if not specified otherwise, at some RAM cost.
Or we could pay some codesize cost and not have the RAM cost...

I was under the impression that these defaults that I could inject would be in NVM memory. I meant to confirm this assumption earlier in the day with some experimentation, but I ended up spending my day looking at how .zap files are translated and thinking of possible solutions thinking about possible paths to implement this.


Solve #115 - Add Shared Storage Abstraction

Description
On this PR, the shared storage abstraction was defined. Also, the implementation of the bot will be removed from the gem and only the specification of the bot structure and some utils will be kept.
Closes #115

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

224 of 230 (97.39%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 98.75%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/bas/shared_storage/base.rb
14
16
87.5%

lib/bas/bot/base.rb
22
26
84.62%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.9%

Covered Lines:
474

Relevant Lines:
480

💛  - Coveralls


Bump version of github.com/aws/jsii-runtime-go

Issue #, if available: https://github.com/aws/jsii/pull/2786
Description of changes:
<EMAIL_ADDRESS>had some issues that caused dependency download failures, which were fixed in v1.27.1
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>verifying go.mod: checksum mismatch
        downloaded: h1:+9t6P1aXlPO0lXa8LtXGBUTcf5tbUekFFFQ4ewFIqAk=
        sum.golang.org: h1:9ddMDdGQwew6pQrfuTID/LxDDrpyrybwsWN84etzjQ8=

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cristim the contents of this repo are generated by JSII, upgrading the version of jsii in aws-cdk is what will update the go.mod file here. This should happen as part of the CDK's normal deploy process over the next few days.


Automatic PR from RestAPI-PR1707

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/1707

Codecov Report

Merging #1457 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1457   +/-   ##
=======================================
  Coverage   54.62%   54.62%
=======================================
  Files        3142     3142
  Lines       79379    79379
=======================================
  Hits        43362    43362
  Misses      36017    36017

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592f178...a8e0cb7. Read the comment docs.

Released part of https://github.com/Azure/azure-sdk-for-python/pull/1575


should we use black for code formatting?

@luiztauffer Should we use "black" for code formatting?

Personally, I dislike it, and never felt advantage using it. Some of the enforced formatting becomes actually less legible, imo, and most of good practices for legibility are not difficult to be followed without it anyway. At the end of the day, it's a matter of taste I guess. Have you tried it?

I haven't tried it. I would like to conform to recommended formatting though. I just installed pylint and it picks up a lot of issues. Some I want to ignore, but others are helpful - like not allowing exceptions that are too general. Trailing whitespace is something I'd like to get rid of on lines. And should we enforce newline at the end of a file? Maybe we could have a script that does that. IDK, what do you think?

there are a couple of strict rules that actually makes the code look quite bad, and one simply can't control that after adopting black.
e.g., something nicely formatted like this:
def myfunc(
    arg1: type = default_value,
    arg2: type = default_value,
    arg3: type = default_value,
):
    ...

could be enforced by black into a monster like this, based only on the number of characters inside the myfunc definition:
def myfunc(
    arg1: type = default_value, arg2: type = default_value, arg3: type = default_value):
    ...

a good linter should be enough imo


Help rst man

Changes

fix #346

Other warnings
@junghans  locally I can only see a remaining warning:
votca/build/sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent.

That warning is due to the equation in the description:
Calculates the orientational correlation function
    <3/2*u(0)*u(r) - 1/2>
for a polymer melt, where u is the vector pointing along a bond and
r the distance between bond segments (centered on middle of bond).

Any suggestions about it?

Can we escape the equation?

The warnings are in https://github.com/votca/votca/runs/1825836103?check_suite_focus=true as well.

My guess is that fedora has a newer version of sphinx than your local machine.
You coild use the ghcr.io/votca/buildenv/fedora:lastest container to get the same environment.

My guess is that fedora has a newer version of sphinx than your local machine.
You coild use the ghcr.io/votca/buildenv/fedora:lastest container to get the same environment.

I have sphinx 3.4.3 (latest release). I use a conda environment for developing in Python. I would like to have a look at the generated files to check the errors.
I am also having the following problem when trying to build the documentation locally:
[ 71%] Building cma_processor.py rst doc (from cma precede_state)
cd /home/felipe/Primer/C++/votca/build/csg/scripts && /usr/bin/cmake -E env VOTCASHARE="/home/felipe/Primer/C++/votca/csg/share" PATH="/home/felipe/Primer/C++/votca/build/csg/scripts:/home/felipe/Primer/C++/votca/build/csg/src/tools:/usr/lib/nvidia-cuda-toolkit/bin:/home/felipe/miniconda3/envs/xtp/bin:/home/felipe/miniconda3/condabin:/usr/lib/nvidia-cuda-toolkit/bin:/home/felipe/.cargo/bin:/home/felipe/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/felipe/.fzf/bin" VOTCA_CSG_DEFAULTS="/home/felipe/Primer/C++/votca/build/csg/share/xml/csg_defaults.xml" /home/felipe/Primer/C++/votca/build/tools/scripts/votca_help2doc --name /home/felipe/Primer/C++/votca/build/csg/scripts/csg_call\ cma\ precede_state --format rst --out /home/felipe/Primer/C++/votca/build/sphinx/csg/scripts/cma_processor.py.rst
cma module could not be imported, please make sure to cma.py in your PYTHONPATH.

CI error:
[ 49%] Building cma_processor.py rst doc (from cma precede_state)
cd /__w/tools/tools/builddir/csg/scripts && /usr/bin/cmake -E env VOTCASHARE="/__w/tools/tools/votca/csg/share" PATH="/__w/tools/tools/builddir/csg/scripts:/__w/tools/tools/builddir/csg/src/tools:::/usr/lib64/ccache:/usr/lib64/openmpi/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" VOTCA_CSG_DEFAULTS="/__w/tools/tools/builddir/csg/share/xml/csg_defaults.xml" /__w/tools/tools/builddir/tools/scripts/votca_help2doc --name /__w/tools/tools/builddir/csg/scripts/csg_call\ cma\ precede_state --format rst --out /__w/tools/tools/builddir/sphinx/csg/scripts/cma_processor.py.rst
Traceback (most recent call last):
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 274, in <module>
    main()
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 270, in main
    convert_help_message(args)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 257, in convert_help_message
    sections = parse_help_message(msg.decode(), name)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 96, in parse_help_message
    description, usage = search_for_usage(description)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 116, in search_for_usage
    desc, usage = desc.split(key)
ValueError: too many values to unpack (expected 2)

CI error:
[ 49%] Building cma_processor.py rst doc (from cma precede_state)
cd /__w/tools/tools/builddir/csg/scripts && /usr/bin/cmake -E env VOTCASHARE="/__w/tools/tools/votca/csg/share" PATH="/__w/tools/tools/builddir/csg/scripts:/__w/tools/tools/builddir/csg/src/tools:::/usr/lib64/ccache:/usr/lib64/openmpi/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" VOTCA_CSG_DEFAULTS="/__w/tools/tools/builddir/csg/share/xml/csg_defaults.xml" /__w/tools/tools/builddir/tools/scripts/votca_help2doc --name /__w/tools/tools/builddir/csg/scripts/csg_call\ cma\ precede_state --format rst --out /__w/tools/tools/builddir/sphinx/csg/scripts/cma_processor.py.rst
Traceback (most recent call last):
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 274, in <module>
    main()
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 270, in main
    convert_help_message(args)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 257, in convert_help_message
    sections = parse_help_message(msg.decode(), name)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 96, in parse_help_message
    description, usage = search_for_usage(description)
  File "/__w/tools/tools/builddir/tools/scripts/votca_help2doc", line 116, in search_for_usage
    desc, usage = desc.split(key)
ValueError: too many values to unpack (expected 2)

I have managed to get the docker container running. I am going to fix the errors and check in the container

Now there only remains the following 2 warnings:
/home/votca/votca/build/sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent.
../../sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent

Now there only remains the following 2 warnings:
/home/votca/votca/build/sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent.
../../sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent

that is great!!!!
Would it help if csg_orientcorr prints `<3/2*u(0)*u(r) - 1/2>` instead <3/2*u(0)*u(r) - 1/2>?

@felipeZ I merged this thanks for the updates!
Can you make a suggestions how to escape the formular?

Now there only remains the following 2 warnings:
/home/votca/votca/build/sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent.
../../sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent

that is great!!!!
Would it help if csg_orientcorr prints `<3/2*u(0)*u(r) - 1/2>` instead <3/2*u(0)*u(r) - 1/2>?

I have tried the quotations and it doesn't work but what it works is to put the equation in the beginning of the line like:
Calculates the orientational correlation function
<3/2*u(0)*u(r) - 1/2>
for a polymer melt, where u is the vector pointing along a bond and

Now there only remains the following 2 warnings:
/home/votca/votca/build/sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent.
../../sphinx/csg/csg_orientcorr.rst:19: WARNING: Definition list ends without a blank line; unexpected unindent

that is great!!!!
Would it help if csg_orientcorr prints `<3/2*u(0)*u(r) - 1/2>` instead <3/2*u(0)*u(r) - 1/2>?

I have tried the quotations and it doesn't work but what it works is to put the equation in the beginning of the line like:
Calculates the orientational correlation function
<3/2*u(0)*u(r) - 1/2>
for a polymer melt, where u is the vector pointing along a bond and

Thanks, please see https://github.com/votca/csg/pull/648


No colors using lsd on Konsole with Bash

Using the packaged lsd-musl_0.16.0_amd64.deb on Ubuntu 19.04.
echo $TERM
xterm-256color

In Konsole, with Bash neither lsd nor lsd --color always print colors.
In Konsole, with Zsh, lsd prints colors.
In Alacritty, with either Bash or Zsh, lsd prints colors.

I had the same issue. But then I copied https://github.com/jwilm/alacritty/releases/download/v0.4.0/alacritty.yml to $HOME/.alacritty.yml
then, I set
env:
  TERM: xterm-256color

and now lsd is outputting colors as intended.

@ngirard make sure you have a proper TERM set.
Check if the $TERM value is something like xterm.... or screen....

My TERM is xterm-256color.
Le ven. 17 avr. 2020 à 16:02, Abin Simon<EMAIL_ADDRESS>a
écrit :

@ngirard https://github.com/ngirard make sure you have a proper TERM
set.
Check if the $TERM value is something like xterm.... or screen....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Peltoche/lsd/issues/274#issuecomment-615261856, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAX6MXYJLA2TCAHOEU4ZXLRNBOP5ANCNFSM4ITILSZA
.

--
Nicolas Girard
Tél: 07 77 82 21 74
Nicolas Girard fait partie de Coopaname, SCOP-SA à capital variable
RCS Paris : 448 762 526 - APE: 7022Z - Nº Intracom: FR49 448 762 526
37/ rue Albert Marquet - 75020 Paris

Oh, wait. You had the term mentioned in the issue. My bad. I got a bit careless.
Could you show the output of $LS_COLORS and the lsd version.

Oh, wait. You had the term mentioned in the issue. My bad. I got a bit careless.

Hey, no problem !
And there's a god news: I installed the latest release, and the problem seems to be gone ! Yay !
I think this issue can be closed as fixed, I'll just leave it to you since there was another person in this thread reporting the same issue.
Cheers and take care!

@ngirard Awesome!
Looks like in his case it was a term issue which he fix after the config update to alacritty.


Application Component: VoiceFocus

Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.
Describe the solution you'd like
App.js
module.exports = Application({
    url: function url (url) {
        this.startFocus('series-voice', url)
    }
})

series-voice-focus.js
module.exports = (url) => Focus({
    created: function created () {
        this.type = AudioFocus.Type.TRANSIENT
        // create player
    },
    started: function started () {
        // start playback
    },
    paused: function paused (mayDuck) {
        // pause or duck playback
    },
    resumed: function resumed () {
        // resume playback
    },
    stopped: function stopped () {
        // stop playback
    },
    destroyed: function destroyed () {
        // destroy player
    }
})

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.

Application and AudioFocus has been landed on master in package @yodaos/application. Closing.


Source compilation

What is your question?
When I compile the source via test_x64-debug.bat, Windows Defender keeps saying that it's a trojan. I didn't compile anything today and it still gave me that notification saying that it's a trojan. Is it a false detection or something?

it is a false positive, defender does this because the compiler starts to create files.


Add juniper_warp/examples/Cargo.toml, so example server can be run easily

I added a Cargo.toml file to juniper_warp/examples, so I could easily compile and run the example server.

@noamraph you don't need a separate Cargo.toml for that, just run:
cargo run -p juniper_warp --example warp_server

You can read about Cargo's CLI more here.


Option for tests added

The tests can be disabled now
To build without tests:
cmake -DUNITTESTS=OFF ..

Per default they are ON, so the option is optional.

Thanks again @offa :+1:

You're welcome! :smiley:


Mandarin lip synchronization

Hello, thank you very much for opening up this excellent work. When using your code for rendering, we found that the lip synchronization effect in Mandarin is not very good, and there may be unnatural synthesis effects on the face. Do you have any suggestions for optimization? Thank you.

Hello, thank you very much for opening up this excellent work. When using your code for rendering, we found that the lip synchronization effect in Mandarin is not very good, and there may be unnatural synthesis effects on the face. Do you have any suggestions for optimization? Thank you.

https://www.vipazoo.cn/CMLR.html 这是我找到的中文数据集 期望你能进行微调 并给与我微调结果进行参考 谢谢

i can


MESA: error: ZINK: failed to choose pdev glx: failed to create drisw screen Exception in thread Thread-2 (_init_and_start_app): Traceback (most recent call last):

device :[WSL2]
PyOpenGL==3.1.7
the error is
MESA: error: ZINK: failed to choose pdev
glx: failed to create drisw screen
Exception in thread Thread-2 (_init_and_start_app):
Traceback (most recent call last):

I running the example script :
import genesis as gs
gs.init(backend=gs.cpu)
scene = gs.Scene(show_viewer=True)
plane = scene.add_entity(gs.morphs.Plane())
franka = scene.add_entity(
gs.morphs.MJCF(file='xml/franka_emika_panda/panda.xml'),
)
scene.build()
for i in range(1000):
scene.step()

and my WSL2 is Ubuntu 24.04.01

same error

fixed in Ubuntu
sudo add-apt-repository ppa:kisak/kisak-mesa   sudo apt update   sudo apt upgrade


Only pull in campaigns from taxonomy get function

What's this PR do?
Only pull campaigns in the taxonomy get function, not all content types
How should this be reviewed?
Visit a taxonomy page, check the only content is campaigns
Any background context you want to provide?
Wasnt happening locally, Jen saw it happening on thor (so blocking deploy now). Wasnt able to reproduce locally until i saved an image, very strange...
Relevant tickets
Fixes #no

@DFurnes updated, I think this is what you had in mind

@angaither got it down to two lines, still had to extract the NID's from the query

hm, i should probably flip those variable names now

🚀


how to set language for date??

how to set language for date??

You need to add the locale files for your language and then everything should just work.

I  add the locale files  but not:
`
`

Ah right, if you're using moment then you need to use moments date formatter:
calendarConfig.dateFormatter = 'moment';

It still doesn't work ( ▼-▼ )

Works for me: http://plnkr.co/edit/nDXuFEpIVeU7CGG7uRKN?p=preview (I included the locale file, and called calendarConfig.dateFormatter = 'moment';)

I tell you exactly, but I do not know why not. There may be some mistake, I'll look for mistakes. Thank you in advance. My English is to use software translation, HA HA

I tell you exactly, but I do not know why not. There may be some mistake, I'll look for mistakes. Thank you in advance. My English is to use software translation, HA HA

ti's ok. thank you so much! i add moment.min.js again.only add moment.js is ok

Glad you got it sorted 😄


feat: change users

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1142518) 38.39% compared to head (7f90d48) 38.39%.

Files
Patch %
Lines

...rvice/adapter/out/user/MockUserProfileAdapter.java
0.00%
9 Missing :warning:

...egacy/user/domain/service/MockUserServiceImpl.java
0.00%
4 Missing :warning:

Additional details and impacted files
@@                 Coverage Diff                  @@
##             showcase/doXisign      #22   +/-   ##
====================================================
  Coverage                38.39%   38.39%
  Complexity                1309     1309
====================================================
  Files                      600      600
  Lines                     8701     8701
  Branches                   424      424
====================================================
  Hits                      3341     3341
  Misses                    5222     5222
  Partials                   138      138

Flag
Coverage Δ

unittests
38.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Team SealedSecrets

WHY
Current team secrets solution relies on Hashicorp Vault, vault-operator from BanzaiCloud and external secrets. This solution  is quite complex and not GitOps compatible. Moreover the HashiCorp Vault license may limit its usage of Otomi.
User Story
AS A A team member
I WANT TO to create and modify secrets in Otomi console
SO I can provide secrets to my applications
We would like to leverage Sealed Secrets and ArgoCD Application to deploy secrets in a GitOps fashion.
The values repo is going to have a new manifests directory.
values/
└── env
    └── teams
        └── sealed-secrets.<team>.yaml

The Sealead secrets operator is using a public key to encrypt the secrets. The public key will be stored in values repo at manifests/otomi/sealedsecrets-pk.yaml, so otomi-api can read user data encryption.
Values schema
definitions:
  team:
    properties:
      sealedsecrets:
        items:
          $ref: '#/definitions/sealedSecret'
        type: array
  sealedSecret:
    properties:
      encryptedData:
        additionalProperties:
          type: string
        type: object
      template:
        description: Template defines the structure of the Secret that will be created from this sealed secret.
        properties:
          metadata:
            description: 'Standard objects metadata.'
            properties:
              annotations:
                additionalProperties:
                  type: string
                type: object
              finalizers:
                items:
                  type: string
                type: array
              labels:
                additionalProperties:
                  type: string
                type: object
              name:
                type: string
              namespace:
                type: string
            required:
            - name
            type: object
          type:
            description: Used to facilitate programmatic handling of secret data.
            type: string
            enum:
              - kubernetes.io/service-account-token
              - kubernetes.io/dockercfg
              - kubernetes.io/dockerconfigjson
              - kubernetes.io/basic-auth
              - kubernetes.io/ssh-auth
              - kubernetes.io/tls
          immutable:
            description: 'Immutable, if set to true, ensures that data stored in the Secret cannot be updated (only object metadata can be modified). If not set to true, the field can be modified at any time. Defaulted to nil.'
            type: boolean
        required:
          - metadata
          - type
        type: object
    required:
    - encryptedData
    - template
    type: object

Acceptance criteria
GIVEN otomi console AND the old secrets page
WHEN a user enters that page
THEN he is notified about Hashicorp Vault being deprecated
GIVEN otomi console
WHEN a team user enters new secrets page
THEN a user can see a list of all sealed secrets that are defined in the sealed-secrets.<team>.yaml file.`
AND a user can see the synch state of each SealedSecret
GIVEN the new Secrets page
WHEN clicks create button
THEN user can define new sealed secrets according to schema (See: the Values Schema section)
GIVEN the new Create Secret page
WHEN clicks the submit
THEN the secret is encrypted with SealedSecret public key AND send to otomi-api
WHEN user clicks the Deploy Changes button
THEN encrypted secret is stored in the sealed-secrets.<team>.yaml file
GIVEN the new Secrets page
WHEN clicks on a given secret
THEN user can obtain unsealed secret AND edit it
WHEN user clicks the Submit button
THEN the secret is encrypted with SealedSecret public key AND send to otomi-api
GIVEN existing secrets stored in HashiCorp Vault
WHEN Otomi is upgraded
THEN All the existing secrets from HashiCorp Vault are stored in the values repo at corresponding files sealed-secrets.<team>.yaml
Definition of done

[ ] Relevant PRs are merged
[ ] Tested by peer
[ ] Updated documentation reviewed by peer
[ ] Short demo video recorded and stored on google drive (if applicable)

Hey team! Please add your planning poker estimate with Zenhub @Ani1357 @dennisvankekem @ElderMatt @ferruhcihan @srodenhuis

Obtaining sealed-secrets key
sealed-secrets-keyxt6rb   kubernetes.io/tls   2      42m
# k get secret -n sealed-secrets -l sealedsecrets.bitnami.com/sealed-secrets-key=active
NAME                      TYPE                DATA   AGE
sealed-secrets-keyxt6rb   kubernetes.io/tls   2      42m

Added chart and corresponding files at jeho-sealed-secrets branch in otomi-core

There is still work to be done in the team-ns chart. In this chart we need to parse team sealed secrets and generated SealedSecret compatible manifest.


Trouble understanding how to utizilize this library

Hello! I have been following Neovim issue #19624 (Async stdlib in neovim), and I saw that you mentioned you broke your work into this repo for testing and such.
I pulled the code down to poke about with (in an attempt to understand the general direction async is moving for Neovim core), but I cannot seem to get it to work "as expected".
 However this appears to instead be executing synchronously?
This could be a misunderstanding of how to create the proper Async_t handles (I am unsure if I should use async.create, async.void or async.wrap, I was hoping to get a bit of guidance. Alternatively, given that you are developing this as a POC, feel free to tell me off :) I am mainly looking to get a sort of "compatibility" layer in my plugin so I can deploy async "now" with the goal of being able to relatively "seamlessly" convert it to whatever is put into stdlib when it gets to that point.
I appreciate you and your work!

This is an async library for use with callback style functions in Neovim. It does not support any kind of multithreading, and all code runs on a single thread. This means there is no notion of foreground or background, more like blocking and non-blocking ... sort of.
The reason you are seeing that output is because you don't ever call a callback-style function (which should be wrapped in async.wrap).
The library uses Lua coroutines to implement the async behaviour. For this to work, something needs to yield the coroutine. This is done in async.wrap.
If you replace the while loop for a timer of different durations, it should behave the way you were expecting.
Also note currently join must be called in an async context.
Something like the following should work.
local async = require("async")
local luv = vim.loop or require("luv")

local sleep = async.wrap(function(duration, callback)
  vim.defer_fn(callback, duration)
end, 2)

local func1 = function()
  sleep(1000)
  print('func1 complete')
end

local func2 = function()
  sleep(10)
  print("func2 completed")
end

local func1handle = async.create(func1)
local func2handle = async.create(func2)

print("Starting background operations")
func1handle()
func2handle()
print("Running long operation in foreground while we wait")

async.run(function()
  sleep(100)
  print("Completed foreground operation")
  print("Waiting for background operations to complete")
  async.join({func1handle, func2handle})
end)


How can i change the urls of the database?

I am running the app in localhost. I have changed the exports.site = 'https://rickandmortyapi.com/api' to exports.site = 'http://localhost:8080/api' but its only changes the next/prev page in the info section. Is there a way to change all the url of the api to localhost instead of rickandmortyapi.com?

Hey,
since the urls are written in the database, there is no "easy" way to do it
In any case, the solution would be to run the database locally and update the urls.
You could update the urls in different ways:

With MongoDB: You could use the $rename operator with updateMany()
Use any MongoDB interface (like Studio 3T) and do it there.
Go to the /data folder and in every .bson file, just select all https://rickandmortyapi.com/apiand replace for http://localhost:8080/api

Hope this helps.

If you go to the /data folder and in every .bson file, just select all https://rickandmortyapi.com/apiand replace for http://localhost:8080/ you will get an error. I converted the .bson files to .jsons, chnaged the urls and imported them manually later. (But if you converted them later to .bson files and run npm run data doesn't work) Is there a way to import the json files into the database automatically with json files? (like the chars.metadata.json) when you run npm run data.

I asume you already solve this. 👍


Add vertical splitting

I finally figured out that the appearance of Vertical Example 2 is actually correct, given the CSS.
Some Day I may know enough CSS to make another Vertical Example, in which there are no margins around the inner, vertically-split panes of the left horizontally-split pane.

So, I'm thinking about this approach, and not sure it's the best to have two functions (Split and SplitV) with lots of overlap. Instead, the better way would be to have an option called direction:
Split(['one', 'two'], {
    direction: 'vertical'
}

Then in the code, use options.direction to choose behavior between the two. What do you think

I don't understand "with lots of overlap".
Certainly the structures of the two functions are parallel -- indeed, at one point I thought about writing a function that converts the source program for one into the source program for the other -- but I don't see how to write a single function that handles both directions, without making it either a nasty mess of evals or an even more nasty mess of if(direction == 'vertical') { ... } else { ... }
I also noticed that the vertical splitting has a bottom-edge-creeping-upward problem that is the exact counterpart of the right-edge-creeping-left problem you fixed. This, despite that I copied the pattern of your properly-working horizontal-splitting code exactly! Hmmm... I wonder whether the margins around the inner panes are causing the creeping? The purely-vertically-split Vertical Example 1 does not creep.

Figured out what's going on with Vertical Example 2. The reason for the strangeness is that the CSS sets padding for .split and .vsplit, to move the text in from the edge. Works fine as long as the only thing inside is text, but when there's another split inside, the padding messes up the size calculations -- see http://www.w3schools.com/css/css_boxmodel.asp and http://www.w3schools.com/css/css_dimension.asp for details.
The fix is to remove the padding from .split and .vsplit and put padding on p elements instead.

This looks great.

Still thinking that since the functions are almost identical, except for the direction the operate on, something like a direction option should be used instead.

Still not seeing how to do that in readable code. :frowning:

Ok, just merged your changes in. Only needed 5 more if statements (8f9deb6) once I generalized the variable names (035f0ea). Going to close this since I couldn't merge directly, but adding you as a contributor for your work on this. Thanks!


remove old TODO

Hi, we saw two TODO in instructions.rb related to the update of the island progress, they say that it has to be set on moving around but in game it actually does it. Is it an oversight or maybe I misunderstood something ?

Nope you're absolutely right, I forgot to remove these. Thanks!


Faker::Time.forward() not working properly

Hi!! I was working with Faker::Time.forward to generate a departure date and a arrival date, and as you imagine arrival should be later than departure. But in some cases Faker::Time.forward works and in some other it fails. I leave some examples.
Here it works,  since it returns the 5 days forward earlier than the 6 days forward
2.2.2 :003 > Faker::Time.forward(5, :day)
 => 2015-08-21 16:48:40 -0300
2.2.2 :004 > Faker::Time.forward(6, :day)
 => 2015-08-22 13:35:38 -0300

Here it does not work, it returns the 5 days forward later than the 6 days forward
2.2.2 :005 > Faker::Time.forward(5, :day)
 => 2015-08-24 17:39:47 -0300
2.2.2 :006 > Faker::Time.forward(6, :day)
 => 2015-08-24 14:47:35 -0300

It happens even if I use :night for the 6 days forward faker and :day for the first one.

This is because Time.forward generates a random time between now and up to as many days as you specify. If you want to generate an arrival date, you will need to use Faker::Time.between, and specify your departure date as the beginning time. I went ahead and wrote a function that sort of does what you are looking for, returning a hash with a departure and arrival time. Note: This is broken if you set any of the variables to 0.
Just specify the maximum amount of days you want to pass before leaving, and max amount of days you want the trip to take. (There is an optional minimum trip length, set to 1 by default, since you can get the same issue you are describing if it is set to 0.)
def create_itinerary(max_time_to_depart, max_trip_length, min_trip_length=1)
	departure = Faker::Time.forward(max_time_to_depart)
	earliest_arrival = departure.to_date + min_trip_length
	latest_arrival = departure.to_date + max_trip_length
	arrival = Faker::Time.between(earliest_arrival, latest_arrival)
	return { departure: departure, arrival: arrival }
end

Example:
# generate a trip that leaves at least a day from now,
# and returns at most 7 days from now
create_itinerary(1,7)

Awesome, thanks @danmakenoise!!! :+1:


Detox build fails RN 0.71.2

Added detox to the app, followed their config, but when running ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release or ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug, the build fails (normal build not for detox passes no prob):
> Task :react-native-mmkv:mergeDebugAndroidTestNativeLibs FAILED
> Task :react-native-random-values-jsi-helper:mergeDebugAndroidTestNativeLibs FAILED

-----------
* What went wrong:
Execution failed for task ':react-native-mmkv:mergeDebugAndroidTestNativeLibs'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.MergeNativeLibsTask$MergeNativeLibsTaskWorkAction
   > 2 files found with path 'lib/arm64-v8a/libc++_shared.so' from inputs:
      - app/node_modules/react-native-mmkv/android/build/intermediates/library_jni/debug/jni/arm64-v8a/libc++_shared.so
      - /Users/username/.gradle/caches/transforms-3/4e096e25fdaa838536961cc2c37ab060/transformed/jetified-react-android-0.71.2-debug/jni/arm64-v8a/libc++_shared.so
     If you are using jniLibs and CMake IMPORTED targets, see
     https://developer.android.com/r/tools/jniLibs-vs-imported-targets

./gradlew clean and node_modules ceanup doesn't help, using latest v2.7.0
and the same for react-native-random-values-jsi-helper. @mrousavy  How can I get rid of duplicating?

Same stuff

Well, adding it to android.packagingOptions.excludes array like so "**/**/libc++_shared.so" (maybe the first glob is excessive) in node_modules/react-native-mmkv/android/build.gradle does the thing making it build. Whether it works or not I need some detox errors and I have no idea how it influences the production build of the app, it's for me to see yet. Meanwhile I saw it was present there some time ago and @mrousavy removed it, maybe he can shed some light on why.

For now, I've just added
android {
  // ...
  packagingOptions {
    pickFirst 'lib/x86/libc++_shared.so'
    pickFirst 'lib/x86_64/libc++_shared.so'
    pickFirst 'lib/armeabi-v7a/libc++_shared.so'
    pickFirst 'lib/arm64-v8a/libc++_shared.so'
  }
}

to this lib's build.gradle and used patch-package to make it consistent through npm installs.
It's a workaround but it works.

For now, I've just added
android {
  // ...
  packagingOptions {
    pickFirst 'lib/x86/libc++_shared.so'
    pickFirst 'lib/x86_64/libc++_shared.so'
    pickFirst 'lib/armeabi-v7a/libc++_shared.so'
    pickFirst 'lib/arm64-v8a/libc++_shared.so'
  }
}

to this lib's build.gradle and used patch-package to make it consistent through npm installs. It's a workaround but it works.

Yeah, but I really need some stuff from 0.71, btw on MacOS machines there's no such error, only on Linux/Windows

What i posted here works for 0.71 (for me at least).


Subscription criteria wrong for multi-value criteria

I think the syntax currently used in the subscription criteria for NEMS may be incorrect. The criteria attribute is supposed to use the same syntax as standard FHIR searches. In a FHIR search if you want to search on a field and specify that the field should be one of two values, this is done using a comma separated list after the =. So, for example to search for events with either event type A or B you would use this syntax:
MessageHeader.event=A,B
However, the current spec says you should specify the criteria twice like this:
MessageHeader.event=A&MessageHeader.event=B
This would actually be treated as an AND in FHIR, meaning it would only match events with a code of both A and B (which is impossible)..
I realise this may actually have originally been my error, but I thought I should bring it to your attention in any case...

I agree this should be done as a comma separated list and currently does not logically make sense. I will add it to our list of things to look at changing.


🎨 Ui tweaks

Closes #55.

Build succeeded!
Built with commit b86ea7cf0762ce4936bf364a4a376ff265df423a
https://deploy-preview-56--padpad.netlify.com


RSpec/ReturnFromStub throws error when block is empty

We somehow had an allow with an empty block in one of our specs which caused an error in the RSpec/ReturnFromStub cop.
The relevant code looked like this:
  before do
    allow(Player).to receive(:some_method) {}
  end

The error message:
An error occurred while RSpec/ReturnFromStub cop was inspecting /app/test_spec.rb:3:21.

1 error occurred:
An error occurred while RSpec/ReturnFromStub cop was inspecting /app/test_spec.rb:3:21.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
Mention the following information in the issue report:
0.51.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-linux)

The solution was to remove that empty {} block.
To reproduce, run this Dockerfile:
FROM ruby:2.4-slim

RUN gem install rubocop -v 0.51.0
RUN gem install rubocop-rspec -v 1.19.0
WORKDIR /app
RUN echo "describe Test do\n  before do\n    allow(Object).to receive(:some_method) {}\n  end\nend" > test_spec.rb
RUN touch .rubocop.yml # to avoid tons of errors
RUN rubocop --debug --require rubocop-rspec

This is fixed in master, see #487 or the changelog
A new version will be released soon to address the issue


chore: released binaries refer correct tekton task yamls

Changes

:broom: The ./hack/release.sh script builds binaries that refer to correct tekton tasks. Without this changes binaries refer task from main branch, not the release branch.

Now the unit-tests_func_main test is failing because npm is not available, why?

/retest

PTAL @jrangelramos

/lgtm