Better intellisense for unions of tuple types

VSCode - Version 1.45.1
Typescript - Version 3.8.3
Search Terms
intellisense tuple
Suggestion
Have the suggestions of unions of tuple types only suggest valid things
Use Cases
I have a function which takes a 'path' to a property in a fixed object, say the object is like { a: { b: 1 } }, allowed paths are ["a"], or ["a", "b"].
I have some type which generates for me the union of allowed tuples, which is to be the type of the 'path'.
The fixed object the function takes paths in is very large and I don't want to have to remember the names of things, when I use the union, the intellisense correctly identifies if a path is invalid, but when using ctrl + space to get the suggestions, it suggests strings which if used are immediately afterwards recognised as invalid.
Examples
Consider a type like
type X = ["A"] | ["A", "B"]
Then if I write something like const x: X = [], when pressing ctrl + space in the array I would like to just be suggested "A" (in fact this is already the behaviour), after filling in "A", if I try to add another element it would just suggest "B", not "A", "B"
Checklist
My suggestion meets these guidelines:

[x ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x ] This wouldn't change the runtime behavior of existing JavaScript code
[x ] This could be implemented without emitting different JS based on the types of the expressions
[x ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x ] This feature would agree with the rest of TypeScript's Design Goals.

I found this question needing exactly the same thing for a tuple representing a method name (a string) and parameters to be passed to that method (object). So clearly I was hoping that once I'd typed the method name that the corresponding parameters would be shown. It didn't.
The problem is that this same thing already doesn't work as expected with objects.
For instance:
type Animal = { animal: 'cat', sound: 'meow' }  | { animal: 'dog', sound: 'bark' };

You might expect when typing the following that VSCode would suggest only 'bark' but it also shows 'meow'.
const myCat: Animal = { animal: 'dog', sound: '

So it's not just about tuples, and the change is wider in scope.
I'm sure there are many other issue for the same issue for objects.

Just cross-linking a related issue: it looks like #43068 is about the non-tuple case that @simeyla mentioned.


Allow multiple pools per subnet

Hello,
I have modified the dhcp module to allow multiple pools per subnet and I'd like to propose it for inclusion in your module.
I'd be glad if you could have a look at the fork geof77/puppet-dhcp and give me feedback on the modifications.  The README has also been modified to reflect the improvements and give usage examples.
I hope you find this useful, at least it is very useful for me :-)
Use case:
I want to change the pxefilename for clients matching a filter, e.g. the hostname (dhcp::host definition) begins with "ppc".

create dhcp::host definitions
create "ppc64" dhcp::class, match if hostname begins with 'ppc'
create subnet with common attributes (network, mask, gateway, pxeserver,...)
create two pools with different ranges within this subnet (previously not possible)
through the "(pool_)parameters" attribute, pass
'allow members of "ppc64"' and 'filename "ppcxyz"' to the first pool
'deny members of "ppc64"' to the second pool

Implementation:
Note: I did not care about backward compatibility yet.
Split dhcp::pool in two:

A 'dhcp::subnet' definition containing only network-related attributes
A 'dhcp::subnet::pool' definition containing the range (and pxefilename overrides)
Split templates in two:
A 'dhcpd.subnet.erb' template
A 'dhcpd.pool.erb' template
Replace pool.pp manifest with subnet.pp containing "dhcp::subnet" and "dhcp::subnet::pool"
Modify init.pp to create subnet  and pool resources.

Other improvements in my fork:

Allow pxefilename and pxeserver overrides in the subnet and/or pool instances
Add allow_class and deny_class parameters to the pools to avoid using plain text "parameters" (i.e. "allow members of ...")

Best regards,
Geof

It would be easier if you could submit this as a pull request.
Some notes initial notes:

I'd prefer to maintain dhcp::pool (even if with a deprecation notice) so we don't break existing deployments.
Tests would help a lot. Especially where you pass in parameters and verify the generated config because there are quite a few conditionals.

@geof77 what's the status? Anything we can do to move this in the right direction?

This would be useful to me too (for different reasons)!
@geof77: any chance for you to submit that PR?

Hi, maybe but it's been a while since I had a chance work on this.  I need
to have a look at it.
Cordialement,
--
Geoffroy Stévenne
2017-05-20 21:36 GMT+02:00 Elisiano Petrini<EMAIL_ADDRESS>
This would be useful to me too (for different reasons)!
@geof77 https://github.com/geof77: any chance for you to submit that PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theforeman/puppet-dhcp/issues/80#issuecomment-302894138,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATQHLUmi_qlozmSPiVMJqZQfmmIlw9U6ks5r70DYgaJpZM4JXKmw
.


Releases missing signatures

Please add checksum and signature files for releases.

Sorry. The checksum file is available inside the compressed package.


Add symbols for BDS terms

drafting first, probably need a look through to standardise things a bit more

#gogoeditdiff

Not sure why, but it isnt importing IAO_0000028 (symbol) in despite it being present in the term file.
Don't think its a bit deal for now, but we should defs look into it down the road if people are going to be using that AP

IAO annotations are all on OMO. It needs to add to the import list.

hmmm @anitacaron I've added OMO and all but doesn't seem to want to import IAO_0000028 (symbol) still

Does the import system work for APs?  Has never been clear to me.

Does the import system work for APs? Has never been clear to me.

that is a good question, don't think I've imported an AP before hmmm - if we cant import it, how do we use it? just with a label?

I'm updating this issue to try to merge it if it's still pertinent.

Symbol is not in OMO
Symbol is not an annotation property, but a class https://www.ebi.ac.uk/ols4/ontologies/iao/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FIAO_0000028
If still needed, should import IAO instead of OMO.

I can fix the many conflicts if this is still relevant.

I think these are still useful, though honestly at this point, I think its easier to just reopen a new PR and use the diff here to add those symbols in. Happy to do it, but ODK is hard for me to access here, so would much prefer it if someone could create a branch with symbol being imported from IAO, and I can work from there. Thanks :)

Would like symbol added ASAP.  Anyone know if we can legally pun class -> AP?

class-AP punning is allowed https://www.w3.org/TR/owl2-new-features/#F12:_Punning
class-datatype punning and punning among different property types are not allowed.

@shawntanzk, we can always update the PR, no need to create another one. I'll update this PR.

class-AP punning is allowed https://www.w3.org/TR/owl2-new-features/#F12:_Punning

Seems like we need a dedicated make goal that adds AP declaration for IAO classes (although I think OMO was meant to solve this)

Can it be declared in the cl-edit.owl file?

@shawntanzk, we need to redefine it as an annotation property because it's officially a class.

@shawntanzk, we need to redefine it as an annotation property because it's officially a class.

oh yeah, that totally makes sense :) Thanks @anitacaron, youre the best!

Ok really didnt have to gogoedit diff lol, looks good, merging in to make next release :) thanks all!


rt upload always returns exit code 0

Hi, it appears that the rt upload command always returns an exit code 0 even when the command reports an error such as a missing file or invalid destination.
CLI Version: 1.29.1
Reproduce
jfrog rt u invalid_file invalid_dest

What happens?
I get the following output indicating an error, but the exit code is 0.
{
  "status": "failure",
  "totals": {
    "success": 0,
    "failure": 0
  }
}

What should happen
The terminal should return an exit code 1 to indicate that an error occurred.
This is fairly important since our build script will continue processing even if the upload has failed.

Fix for this issue: https://github.com/jfrog/jfrog-cli/pull/474

Thanks for the quick fix! Should this issue be closed now?

Sure. The fix is included in version 1.30.0.
Thanks for fixing this @Postyy and thanks for reporting it @dquist!


Piecewise linear trees

I recently discovered this paper which was submitted earlier this year showing impressive results of GBDTs utilizing piecewise linear trees. It's claimed that PL trees converge faster and are more accurate than the constant trees xgboost & lightgbm uses, and that optimizations exist to make GBDT-PL competitive speed-wise.
The repo for the paper can be found here. Is there any chance of adding this feature?

Closed in favor of being in #2302. We decided to keep all feature requests in one place.
Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

I'd like to work on this issue.

Thanks @kruda ! I'll re-open and assign to you. Let us know if you have any questions.

@jameslamb I believe we should re-open a feature request issue only after any evidence of active work on it. Otherwise, we may fall down into dozens of open stale issues like it was before #2302, e.g. here https://github.com/microsoft/LightGBM/issues/261#issuecomment-436995220.
@kruda You can submit a PR any time you want marking it [WIP] so that it will be easier to discuss implementation aspects and ask related questions.

@jameslamb I believe we should re-open a feature request issue only after any evidence of active work on it. Otherwise, we may fall down into dozens of open stale issues like it was before #2302, e.g. here #261 (comment).
@kruda You can submit a PR any time you want marking it [WIP] so that it will be easier to discuss implementation aspects and ask related questions.

ok fair enough!

Hi @kruda How is your process going?

Implemented in #3299.


Phal pwm timer

Timer control for PWM input capture. Capture as well as overflow counting is interrupt based. When TIM2 is implemented, psched will require the use of a different timer (it currently uses TIM2). There is also a rough implementation for PWM output.

@DMoore12 could we switch PSCHED to use the SysTick timer?


Cursor is lingering in task list when creating or editing a task

When editing a task, the blinking cursor lingers in the task list for about a second before it moves to the correct position in the edit box.

Fixed in 2.1.0


Adds loader icon to index.html along with the CSS that goes with it.

Reviewer: @kennyt

tests failing

Looks good! A few small stylish comments, but I'd ⛵ after that!

don't think the CSS is being applied.

I'm hitting the same issue

Fixed it. See what happens when you make me rename things?


Remove package dependecies to CodeQuality

Getting the project via nuget a lot of different packages will be installed in addition and results in time consuming uninstall and fixing things.
Remove CodeAnalysis and every other QA stuff (if possible) to have a smoother startup after nuget installation.

Great suggestion. Will do ;)

FIxed in 1.1.0


Determine the ghostscript command on windows

Addresses issue #43.
If the platform is Windows, tries to determine the GhostScript command name by checking for the GSC environment variable, then trying the different possibilities.

@adamchainz it does run on my windows machine. I'll add a link to the documentation on the command names. Unfortunately, gs becomes either gswin32c or gswin64c depending on which version is installed.

Oh yes, please also add an entry in HISTORY.rst

Fixed the tests 3e121fb.
============================= test session starts =============================
platform win32 -- Python 2.7.11 -- py-1.4.25 -- pytest-2.6.3
Ghostscript version: 9.14

collected 6 items

tests/test_treepoem.py ......

========================== 6 passed in 5.24 seconds ===========================

I realised PIL must be doing the same thing as _gs_command, so I'm using their method now.

Ah, smart!

Merged in 43835c7a29a75a5e8a1f3d760fba97f06043ca13, thanks!

🎉 Version 1.1.0 out: https://pypi.python.org/pypi/treepoem
Also I added some tests in 8aa9d4bd8f29e88d5ca397cff2da26d72486ab74 - they mock sys.platform to pretend we're on windows since Travis does not have windows support.

Nice! Appveyor is a ci service, like Travis, on windows.

If you've ever set it up, a PR with an example config would be useful. Otherwise I don't have time to do it.


TINKERPOP-1126

Check the value of reconnectionAttempt and create scheduled task as a 2 step process.
Surely there is a more JDK-1.7 way of doing this, but this is working for me.

I've merged this PR to a TinkerPop branch called TINKERPOP-1125-to-1127 for internal code review.   it covers this PR and #211 - please see the VOTE there.


Transaction creation for swap from ERC20 fails with smart account connected

When smart account is connected, the transaction is posted to the transaction service API. When this happens, the transaction gas is calculated making the swap transaction fail because it needs the allowance of the amount to be swap

Closing this since it's fixed


Invalid FillValue in the individual sensor's AVGTAU

@rlevy1109 @jwei-openscapes @pawanpgupta @VP Kiliyanpilakkil
zeros are used instead of the fill value in the individual sensor's datasets. Attached is the example case using only one ABI16 input file.
fillvalue_issue.pptx
I have created the branch fix/fillvalue_zzu to fix all the fillvalue realted issues.

Yes, this needs to be fixed.

Dr. Robert C. Levy  (he/him)
GOES-R Project Scientist
Dark Target Web: https://darktarget.gsfc.nasa.gov/
Bio: https://science.gsfc.nasa.gov/sed/bio/robert.c.levy
NASA Goddard Space Flight Center
O:<PHONE_NUMBER>  C:<PHONE_NUMBER>

From: Zhaohui @.>
Reply-To: zhaohuizhangnasa/aerosol-data-fusion @.>
Date: Thursday, February 1, 2024 at 9:28 AM
To: zhaohuizhangnasa/aerosol-data-fusion @.>
Cc: "Levy, Robert C. (GSFC-6130)" @.>, Mention @.***>
Subject: [EXTERNAL] [BULK] [zhaohuizhangnasa/aerosol-data-fusion] Invalid FillValue in the individual sensor's AVGTAU (Issue #4)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
@rlevy1109https://github.com/rlevy1109 @jwei-openscapeshttps://github.com/jwei-openscapes @pawanpguptahttps://github.com/pawanpgupta @vphttps://github.com/vp Kiliyanpilakkil
zeros are used instead of the fill value in the individual sensor's datasets. Attached is the example case using only one ABI16 input file.
fillvalue_issue.pptxhttps://github.com/zhaohuizhangnasa/aerosol-data-fusion/files/14126647/fillvalue_issue.pptx
I have created the branch fix/fillvalue_zzu to fix all the fillvalue realted issues.
—
Reply to this email directly, view it on GitHubhttps://github.com/zhaohuizhangnasa/aerosol-data-fusion/issues/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXONJTGXIFNEQONKLA6D5WDYROQ4TAVCNFSM6AAAAABCVACQHOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTENRWGE2DCNI.
You are receiving this because you were mentioned.Message ID: @.***>

@rlevy1109 @jwei-openscapes @pawanpgupta @vp Kiliyanpilakkil
Rob, Pawan, Praju, I already fixed the fillvalue and scale factor related issues in the fix/fillvale-zzh branch. Can you check out this branch, run a case and  let me know if everything looks good for you? If there is no further issue, I am going to merge the codes to the main and make the release.
Although I tried to fix the issues in a more generic way, the current codes are still a little bit DT L2 oriented. I will update the codes later for the applications to other data products.

Yay!
So what is next step?
Regards,
-Rob

Dr. Robert C. Levy  (he/him)
GOES-R Project Scientist
Dark Target Web: https://darktarget.gsfc.nasa.gov/
Bio: https://science.gsfc.nasa.gov/sed/bio/robert.c.levy
NASA Goddard Space Flight Center
O:<PHONE_NUMBER>  C:<PHONE_NUMBER>

From: Zhaohui @.>
Reply-To: zhaohuizhangnasa/aerosol-data-fusion @.>
Date: Tuesday, February 13, 2024 at 10:07 AM
To: zhaohuizhangnasa/aerosol-data-fusion @.>
Cc: "Levy, Robert C. (GSFC-6130)" @.>, Mention @.***>
Subject: [EXTERNAL] [BULK] Re: [zhaohuizhangnasa/aerosol-data-fusion] Invalid FillValue in the individual sensor's AVGTAU (Issue #4)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
Closed #4https://github.com/zhaohuizhangnasa/aerosol-data-fusion/issues/4 as completed.
—
Reply to this email directly, view it on GitHubhttps://github.com/zhaohuizhangnasa/aerosol-data-fusion/issues/4#event-11790116325, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXONJTCCA57FFBCGPNTP4V3YTN6UBAVCNFSM6AAAAABCVACQHOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG44TAMJRGYZTENI.
You are receiving this because you were mentioned.Message ID: @.***>


add commit to json,bugs

{
//Current UrlPrefix
"urlPrefix": "/App",
//Current Module CookiePrefix
"cookiePrefix": "App_",
//Current Module SessionPrefix
"sessionPrefix": "App_",
}
SimpleJson.DeserializeObject(json);//bugs here!

@xiaolu6t did you mean comment? If so we have no plans to support comment since it is not part of json spec.

no plans to add this as it is not part of the spec


Explore integration of Accessible Autocomplete library

Docs: https://alphagov.github.io/accessible-autocomplete/
States
Searching:

Searching with selection:

Selection, focused:

Selection, not focused:

@cherylhjli is this in Figma somewhere? Can you link it here?


Update portal search index to support ontology querying

As per the discussion in the Semantic searching breakout at the November DCP meeting, the HCA ontologists and the Orange team will work towards injecting additional ontology info into Azul index using OLS python client https://pypi.org/project/ebi-ols-client/. This will allow semantic querying (eg parent/child relationships, partonomy) of ontology-annotated terms in the data browser.
┆Issue Number: HCAB-306

Obsolete


chore(sequencing): remove ConsensusMessage from context

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2533  👈 (View in Graphite)
#2532
#2528
#2526
#2525
#2524
#2518
#2517
#2512
#2510
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Feature Request - Asynchronous Call Integrity

DataService and Data layers do not currently include async/await keywords for generated code. this leaves a break in the async flow and can cause some unintended threading issues.
Can Beef generation be changed to have "public async Task" for Async methods and await Data[Svc]Invoker.Current.InvokeAsync for the invoker calls of Data and DataSvc classes please?

async/await are only added (this is the intension, please advise if it doesn't) where the result is needed in the context of that method; otherwise, the Task is returned to avoid the overhead of the compiler adding a state machine, etc. See StackOverflow: https://stackoverflow.com/questions/35201881/should-i-use-async-await-for-every-method-that-returns-a-task?msclkid=fe4d3b87d0ab11ecadb637dc8c754314

I concur. Did a bunch of reading and also looked properly and the invoker implementations.
The articles I was reading that lead me to wonder about Task usage was this one.
https://medium.com/@deep_blue_day/long-story-short-async-await-best-practices-in-net-1f39d7d84050
I then found a very similar article to the one you've shared and .
https://stackoverflow.com/questions/33054199/can-we-turn-async-methods-into-expression-body
In the end what I was really wondering about was the difference in invoker usage between the manager invoker and the data and datasvc invoker implementations.


Expose configuration options

I'd like to use ember-lokijs with different LokiJS storage adapters (namely: https://github.com/cosmith/loki-cordova-fs-adapter). However there is no way to pass config options to ember-loki.
Ideally the ["new Loki"]](https://github.com/null-null-null/ember-lokijs/blob/a5e4f0716e2a863de061ba98418f62056891d8d4/addon/adapters/ember-lokijs/lokijs.js#L19) would pass some externalized config options.

Just made a new commit. Let me know if it works for you! You can find documentation on it here.

That looks great. My only additional request would be the ability to pass in the various options to the db. See http://lokijs.org/#/docs#db
In particular the ones I need are autosave and autosaveInterval.

That seems like a better pattern for specifying the adapter, as well. You can find the new docs here. Let me know if that works!
Also, I checked out your site. It's always good to see engineers applying their skills to causes they believe in. Best of luck, @Ramblurr!


Anaconda wrongly installs message-ix=1.0.0 from arch-specific channel

At one point Anaconda started to install version message-ix=1.0.0 instead of the latest, e.g 3.4.0.
Forcing conda install message-ix">1" leads to the correct installation of message-ix, however with a very high memory usage/runtime (up to 45 minutes) of the conda solver on Windows. Due to that, the GitHub Actions workflow, to check this installation process, runs out of memory and cannot complete on the windows-latest actions runners (see here for an example). Locally this results in an installation time of up to 45 minutes (https://github.com/iiasa/message_ix/issues/562).
The issue was discussed (at length) in conda-forge/admin-requests#385, where conda-forge staff:

identified it as “a solver issue”.
offered suggestions for debugging that did not yield direct information on the cause.

At https://github.com/conda-forge/admin-requests/pull/385#issuecomment-1030871656, the following were further suggested:

conda/conda-build#4104.
conda/infra#514

…however, experimentation at #554 shows that the suggested workaround (--repodata-fn repodata.json) does not solve the problem.
This issue is to accumulate information and track efforts to get this resolved upstream.

A brief comment on this. When trying to re-install message-ix (which did not work for me, see #584), I initially also tried with conda install message-ix">1". This, however, installed only version 1.0.0. Only when forcing the installation of a specific version, like conda install message-ix"=3.4", the newest/specified version got installed.
(I'm running everything in the Anaconda prompt on a Windows machine)

When trying to re-install message-ix (which did not work for me, see https://github.com/iiasa/message_ix/issues/584), I initially also tried with conda install message-ix">1". This, however, installed only version 1.0.0. Only when forcing the installation of a specific version, like conda install message-ix"=3.4", the newest/specified version got installed.

This is also what we discovered in #541 and #554, and you can see this reflected on the main branch in the daily check that installation from conda works:
https://github.com/iiasa/message_ix/blob/2045b07c13322ce0224ce809ca1c64c1e5f64398/.github/workflows/conda.yaml#L70
#545 updated to the documentation, but only to the earlier ">1", which turned out not to be the final workaround.
With conda-forge/admin-requests#385 merged, we can now do #585, after which none of these should be necessary.


Resolution limitations does hardware accelerated decoding

Does Intel publish h264/h265 profile and resolution limitations for hardware accelerated decoding? The MediaSDK (https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk_release_notes.md) has a section on this, but given that repository is archived I'm not certain that those limitations are up to date.

Found in the processor datasheets: https://www.intel.com/content/www/us/en/content-details/743844/13th-generation-intel-core-and-intel-core-14th-generation-processors-datasheet-volume-1-of-2.html?wapkw=raptor lake


Cant Send Post Request To API Resource Route

Laravel Version: 5.8.16
PHP Version: 7.2.13
Database Driver & Version:

Description:
I Cannot Make A Post Request To The Resource Route. Error Says "The POST method is not supported for this route. Supported methods: GET, HEAD."
Steps To Reproduce:

Fresh Laravel Installation
Define API nested resource routes
Send a post request using PostMan or Insomia

Update: this only occurs when i use a form request.

To which route are you sending the request?

Sorry I Did Not Specify. I Am Sending The Request To The Store Method
POST http://testsite.test/api/showcase/1/comments

Ensure you set Accept: application/json in your request header
Even if the error is unrelated, this solved my issue

@BenQoder Hi, am getting this same error. sorry I don't understand what you mean am still new to Laravel.
this is my form
<form class="form-horizontal" method="POST" action="{{url('/admin/update-pwd')}}" name="password_validate"                                 id="password_validate" novalidate="novalidate">@csrf
                                     Current Password
                                         <input type="password" name="current_pwd" id="current_pwd" />

                                     New Password
                                         <input type="password" name="new_pwd" id="new_pwd" />

                                     Confirm password
                                         <input type="password" name="confirm_pwd" id="confirm_pwd" />

                                     <input type="submit" value="Update Password" class="btn btn-success">
                             </form>
my Route:
Route::group(['middleware' => ['auth']], function () {     Route::match(['get','post'],'/admin/update-pwd','AdminController@updatePassword'); });
controller:
public function updatePassword(Request $request){         echo "true"; die;     }
will appreciate any help thanks

@steco17, my case was different but try it like
Route::middleware([“auth”])->group(function () {
    Route::match(['get','post'],'/admin/update-pwd','AdminController@updatePassword');
});

@BenQoder thanks it worked.


undefined reference in tensorflow-lite shared library generated by cmake

System information

OS Platform and Distribution: macOS
TensorFlow installed from (source or binary): source
TensorFlow version: 2.5.0 (from git clone latest)
Python version: Python 3.8.6
Installed using virtualenv? pip? conda?:
CMake version (if compiling from source): 3.18.0
GCC/Compiler version (if compiling from source): Android ndk r21
CUDA/cuDNN version:
GPU model and memory: Radeon Pro 555X 4 GB

Describe the problem
I compiled tensorflow-lite with cmake on android. I created an android JNI project. In this application I tried to link together all .a files (compiled by tensorflow-lite) into an .so shared library. In the cpp code I just get the version of the tensorflow-lite lib.
I got this linker error:
libtensorflow-lite.a(platform_profiler.cc.o): In function `tflite::profiling::MaybeCreatePlatformProfiler()':
tensorflow/tensorflow/lite/profiling/platform_profiler.cc:30: undefined reference to
`tflite::profiling::MaybeCreateATraceProfiler()'

Provide the exact sequence of commands / steps that you executed before running into the problem
git clone --recursive git@github.com:tensorflow/tensorflow.git
cd tensorflow
mkdir tf_build
cd tf_build
cmake -DCMAKE_TOOLCHAIN_FILE=~/Library/Android/sdk/ndk-bundle/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a ../tensorflow/lite
cmake --build . -j

In the cpp source I just get the version of the lib:
#include <tensorflow/lite/c/c_api.h>

printf("TensorFlow C library version %s\n", TfLiteVersion());

Any other info / logs
I think the problem is in the tensorflow/tensorflow/lite/CMakeLists.txt:
# TFLite library
add_library(tensorflow-lite
  ${TFLITE_CORE_API_SRCS}
  ${TFLITE_CORE_SRCS}
  ${TFLITE_C_SRCS}
  ${TFLITE_DELEGATES_FLEX_SRCS}
  ${TFLITE_DELEGATES_GPU_SRCS}
  ${TFLITE_DELEGATES_NNAPI_SRCS}
  ${TFLITE_DELEGATES_SRCS}
  ${TFLITE_DELEGATES_XNNPACK_SRCS}
  ${TFLITE_EXPERIMENTAL_RESOURCE_SRCS}
  ${TFLITE_EXPERIMENTAL_RUY_PROFILER_SRCS}
  ${TFLITE_EXPERIMENTAL_RUY_SRCS}
  ${TFLITE_KERNEL_INTERNAL_OPT_INTEGER_OPS_SRCS}
  ${TFLITE_KERNEL_INTERNAL_OPT_SPARSE_OPS_SRCS}
  ${TFLITE_KERNEL_INTERNAL_OPT_SRCS}
  ${TFLITE_KERNEL_INTERNAL_REF_INTEGER_OPS_SRCS}
  ${TFLITE_KERNEL_INTERNAL_REF_SPARSE_OPS_SRCS}
  ${TFLITE_KERNEL_INTERNAL_REF_SRCS}
  ${TFLITE_KERNEL_INTERNAL_SRCS}
  ${TFLITE_KERNEL_SRCS}
  ${TFLITE_NNAPI_SRCS}
  ${TFLITE_SRCS}
  ${TFLITE_SOURCE_DIR}/profiling/platform_profiler.cc
  ${TFLITE_SOURCE_DIR}/schema/schema_utils.cc
  ${TFLITE_SOURCE_DIR}/tools/optimize/sparsity/format_converter.cc
)

It includes ${TFLITE_SOURCE_DIR}/profiling/platform_profiler.cc and this file uses MaybeCreateATraceProfiler function. But the implementation of this function is not added to the tensorflow-lite library.
I think a solution can be adding  ${TFLITE_SOURCE_DIR}/profiling/atrace_profiler.cc to the tensorflow-lite library.

Just verified. I'm working on this.

It's fixed now.

Same problem happens with the Makefile build (``tensorflow/lite/tools/make/Makefile). profiling/atrace_profiler.cc is not being built when building for android. But I guess the Makefile build should not support android builds?

same thing could/should be added to the "iOS" macro, in the tflite CMake Line 444 under:
if(CMAKE_SYSTEM_NAME MATCHES "Android")   list(APPEND TFLITE_PROFILER_SRCS     ${TFLITE_SOURCE_DIR}/profiling/atrace_profiler.cc   )
Similarly a "iOS" loop needs to be added
elseif(CMAKE_SYSTEM_NAME MATCHES "iOS")   list(APPEND TFLITE_PROFILER_SRCS     ${TFLITE_SOURCE_DIR}/profiling/atrace_profiler.cc   )


net: connecting to <IP_ADDRESS> fails on windows

What steps will reproduce the problem?

run this program on windows

package main

import (
	"log"
	"net"
)

func dial() error {
	l, err := net.Listen("tcp", ":0")
	if err != nil {
		return err
	}

	go func() {
		c, err := l.Accept()
		if err != nil {
			return
		}
		c.Close()
	}()

	c, err := net.Dial("tcp", l.Addr().String())
	if err != nil {
		return err
	}
	c.Close()
	return nil
}

func main() {
	err := dial()
	if err != nil {
		log.Fatal(err)
	}
}

What is the expected output?

Should output noting.

What do you see instead?

2013/08/30 16:43:22 dial tcp <IP_ADDRESS>:1406: ConnectEx tcp: The format of the specified
network name is invalid.

Please use labels and text to provide additional information.

The problem seems to be that l.Addr().String() returns '<IP_ADDRESS>', but connecting to that
address is not allowed on windows. From
http://msdn.microsoft.com/en-us/library/aa923167.aspx

" ... If the address member of the structure specified by the name parameter is
all zeroes, connect will return the error WSAEADDRNOTAVAIL. ..."

Let's at least remove that example from the docs on the Dial func. It's weird to connect to <IP_ADDRESS>.

The doc says: If the host is empty, as in ":80", the local system is assumed. I interpret that local system as localhost (<IP_ADDRESS>) instead of <IP_ADDRESS>. It will be nice if this is clarified.

#10624 will update the documentation; It will probably have a section about "Network and host/address arguments."

I think we should fix this. We advertise that Dial(":80") connects to the local system's port 80. It should do that on Windows too. I'll send a CL with a test and a fix; criticisms welcome.


Doesn't work under OSX 10.13.2

npm install fails
$ npm install drng

><EMAIL_ADDRESS>install /Users/u/Developer/rnrand/node_modules/drng
> node-gyp rebuild

  ACTION binding_gyp_drng_target_generate_config_h src/libdrng-1.0/config.h
bash: ./configure: Permission denied
make: *** [src/libdrng-1.0/config.h] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:159:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
gyp ERR! System Darwin 17.3.0
gyp ERR! command "/usr/local/Cellar/node/9.3.0_1/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/u/Developer/rnrand/node_modules/drng
gyp ERR! node -v v9.3.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok

If I git clone the repository and ./configure, it would generate config.status, Makefile and config.h
However make all fails:
$ make all
make: *** No rule to make target `main.o', needed by `test'.  Stop.

Makefile.txt

Same issue on OSX 10.11.6


Is there a way to setup SLUG_PRESERVE_UNICODE like in the svelte.dev website?

Describe the problem
I am on work of translating the svelte kit documentation into Portuguese,
but I am without a way to preserve the slugs in the pages generated.
What can I do to set up SLUG_PRESERVE_UNICODE like in the svelte.dev website?
Describe the proposed solution
export const SLUG_PRESERVE_UNICODE = false;
export const SLUG_SEPARATOR = '_';

Alternatives considered
https://github.com/sveltejs/svelte/blob/master/sites/svelte.dev/config.js
Importance
would make my life easier
Additional Information
No response

From what I can tell it originally came from https://github.com/sveltejs/action-deploy-docs - not sure if it's still even being used. Maybe @PuruVJ will know


WIP: CCO-325: add support for workload identity

Driver controller deployment should load workload identity values to injector env to enable workload identity authentication.
The following keys need to be flagged as optional because their presence now depends on authentication method used:

azure_client_secret
azure_tenant_id
azure_federated_token_file

Depends on: https://github.com/openshift/cluster-cloud-controller-manager-operator/pull/245

/retest

/retest

/retest

/retest

/hold until https://github.com/openshift/azure-disk-csi-driver-operator/pull/78 is merged

/retest

/unhold

CI failures should be resolved by https://github.com/openshift/cluster-storage-operator/pull/372 - we need to merge that first.

cc @openshift/storage  for review

/retest

/lgtm


Removed Git Basics section from contributing.md

Referencing issue #45
This time I left the heading up and referred to the documentation folder. If/when the git basics file gets merged, I can edit the link to refer to the actual file. Also, there's a little section at the bottom, I wasn't sure what to do with that...

there's a little section at the bottom, I wasn't sure what to do with that...

Leaving it alone in this PR is probably the right thing to do, it's not related to Git basics.

It's useful if you link to the new location of the text you are removing in the pull request description.
(Even if the location does not yet exist because the other PR has not been merged.)

Everything else looks good. 👍 :heart:

Hi. I may have ran into some issues... I tried to edit the previous commit using git commit --amend  before I pulled the last changes. I got a bunch of conflicts! I hope I resolved them correctly. If you could help me out I would really appreciate it. Thanks!

We are getting a little meta here (Git help in the PR that removes Git help)!!!
$ git log --graph master..pr819 --oneline                                                                                (06-02 22:56)
* 65b4cd2 (HEAD -> pr819) Merge branch 'master' into docs-rm-git-basics
*   eaade38 Resolving merge conflict
|\
| * 95b77b1 Removed Git Basics section from CONTRIBUTING.md
* c027bdd Removed Git Basics section from CONTRIBUTING.md

There are two copies of the "Removed Git Basics section from CONTRIBUTING.md" commit in this PR which do different things (one before Insti's feedback and one after), and the two copies got merged together, and conflict as you would expect. It should instead be the case that there is only one copy.
So the conflict was resolved "correctly", but shouldn't be there in the first place. I recommend only including the changes from c027bdd. The various ways I can think of to achieve that are:

git rebase -i, delete all lines except for c027bdd
git checkout docs-rm-git-basics; git reset master; git add CONTRIBUTING.md; git commit (and enter the commit message).
substitute your preferred way of achieving the goal if you have one
do nothing, maintainers please use Squash and Merge button when merging this PR

So the conflict was resolved "correctly"

I should remove scare quotes around "correctly". It was resolved correctly, no question about it, since the final product is the desired state.

git rebase -i

fine, I suppose I should say that should be git rebase -i master instead, otherwise it tries against the upstream tracking, which should obviously have no change

Honestly I would consider git reset --hard c027bdd a reasonable way of doing this too, since none of the other commits matter.

@petertseng Thank you for that wonderfully detailed explanation! As you can see I'm still a git newbie. :-) That git log --graph command is pretty cool. This has been a valuable experience and I appreciate being given the chance by @kytrinyx and @Insti. I will make whatever changes they see fit

@aosdab How about you pick one of @petertseng's suggested approaches to fixing it—not the do nothing :-)—and see if you can get it sorted. It's totally worth the git practice!
You'll need to git push -f up to your branch to update the pull request at the end of it.
Good luck ✨ 💓 ✨

Oh, I forgot to say that no matter what you do, we can help recover if it goes sideways.

Should be good to go. Thanks @kytrinyx :-)

Usually I would fix this myself, but since we've been going meta on this one, here's one more thing that I'd like to suggest.
Notice how there are two commits, one is the change, and one is a merge commit from master?
Ideally, the PR would have just the first commit. The way to achieve that is:

git checkout master
git pull upstream master (this assumes that the exercism/x-common remote is named 'upstream' and that your own fork is called 'origin')
git checkout docs-rm-git-basics
git rebase master
git push origin docs-rm-git-basics

This will put the commits from master before your commit in this branch, thereby eliminating the merge commit.
Does that make sense?

Yeah that makes sense. Thank you! So did this happen because I did not pull from master first before pushing? I was worried that if I pulled from master I would lose all the changes on this branch.

But since we're merging branches into master, it doesn't seem to make sense to merge master into other branches.

(I do think that they would produce the same result in the files, so the difference is just what the history looks like)

the difference is just what the history looks like

Yepp—that's the only difference. Some people don't care about the history, and some people do. There's no right or wrong, really, it's more about how the project works and the culture, and how people tend to need to use the history. On Exercism we care quite a lot about the history, because so many people are involved, and we're always trying to hunt down how some decision was made, or the history of some change. Getting rid of the extraneous merge commits from master to a branch keeps things a teensy bit more readable.

💛 🌻 ✨ 🌻 💛 thank you 💛 🌻 ✨ 🌻 💛

Hey @kytrinyx I appreciate the work you put into keeping this tidy. It's taught me not to be sloppy with my commits... and work :p I learned a lot doing this


Longest path in a Directed Acyclic Graph

Hi, My name is Yogesh Yogendra and i am a GSSoC'21 Participant. I want to code this problem in C++.
Please assign me this task.
@tarun26091999  @rudrakshi99  @plazzy99  @nakul-19

Hi, My name is Jai Mehta and I am a GSSoC'21 Participant. I want to code this problem in C++.
Please assign me this task.

@tarun26091999 @rudrakshi99 @plazzy99 @nakul-19

I compiled the cpp file and it is perfectly running .I eagerly to contribute in this issue please assign me the task.
@tarun26091999 @rudrakshi99 @plazzy99 @nakul-19


docs: Rename package

Renamed a couple of labels

@gmartinsribeiro needs to fix the lint test other than that :rocket:


Published crates should include LICENSE file

I'd like for published crates to include the text of the LICENSE along with the code. For our use case (making a repo of vendored crates), the cargo-vendor tool is populating the vendor directory with lots of packages that are missing LICENSE. There are basically two reasons for this:

The LICENSE file is present in the source repository, in the same directory as the Cargo.toml config file, but the config file doesn't include the LICENSE in the list of files to be uploaded (because of an explicit "include" keyword). Examples include dtoa and serde.

The LICENSE file is present in the source repo (typically in the repo root), but the crate is published from a subdirectory. Examples include num-traits and xi-core-lib.

There are (at least) two things "cargo publish" could do to mitigate this problem:

The publish tool could do a lint check that an appropriate license file is present. There's a small amount of client-side sanity-checking now (checking that a license file exists if specified), and I believe the crates.io server also checks the spdx string.

Automatically including LICENSE files from the repo root if publishing from a subdirectory.

I'll get around this for the time being by making my vendoring script do the latter at vendoring time, but I think it would be better if every stage in the chain precisely matched the exact contents.

This issue still exists.
Would someone be interested in contributing to this? In particular, making cargo package check for a file named "LICENSE" or "COPYING" (or a few other patterns) and automatically including it in the .crate file?

cargo publish does do this doesn't it - but cargo package doesn't?


DbFunctions: instance functions on entities

Consider the scenario originally described at https://github.com/aspnet/EntityFrameworkCore/issues/9213#issuecomment-324115344 (about why instance functions on DbContext can be compelling):
db.Posts.Where(p => db.PostReadCount(p.Id) > 5);

It could actually be even more compelling to be able to do this:
db.Posts.Where(p => p.ReadCount() > 5);

This could work for instance methods, computed properties or even extension method defined over the entity type.
It would be convenient for the translation to automatically map the "this" entity instance to the key of the entity when invoking the database implementation of the function.

@pmiddleton Let us know if you're interested in working on this.

Yes

Please also consider an scenario like the following: I need to efficiently check some information that is encrypted by a symmetric key in the database, across several tables.
It would be nice if  we could do something like _dbContext.IsEmailAvailable(email) given the mapping of scalar function in the DB to the context:
[DbFunction("IsEmailAvailable", "dbo")]
public static bool IsEmailAvailable(string Email) => throw new NotImplementedException();

You don't always need to execute the function over an specific Entity.
Thanks

@regul4rj0hn - Is email bound to an entity in your example?  If so then you can already do that today.
If email is just a string coming in from the application then you can't.  Support for use case is included in #11129 but that is on hold pending the query redesign in 3.0

Yeah, it's coming from the app that's the issue. Currently calling the scalar function the old-fashioned way as a work around. I guess that refactor will have to wait then. Thanks for the help, @pmiddleton !


Virtual Machine SSH Public Key Authentication

Allow SSH public key authentication
aws_instance.key_name
azurerm_linux_virtual_machine.admin_ssh_key
Tasks:

[ ] AWS
[ ] Azure
[ ] Tests
[ ] Docs

Azure requires password or SSH key
AWS does not allow password and SSH key is optional
Solution:
Add ssh_key param
If ssh key is not used, omit AWS auth and use random_password resource for Azure


l-smash: init at 2.4.15

Motivation for this change
Needed this library.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

tested with nix-review, binaries show help if I run them, which is expected.


[bug] Signature decoding error

Describe the bug
I've follow everything on the updaters doc and yet stuck at the very final parts, yes I've look answer but still the answer is not really helping. Anyone experience this and able to guide me step by step? I even regenerate the key and still no idea what went wrong
Reproduction
No response
Expected behavior
Update works
Full tauri info output
Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 124.0.2478.80
    ✔ MSVC:
        - Visual Studio Build Tools 2019
        - Visual Studio Build Tools 2022
    ✔ rustc: 1.76.0 (07dca489a 2024-02-04)
    ✔ cargo: 1.76.0 (c84b36747 2024-01-18)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.12.2
    - npm: 10.5.0

[-] Packages
    - tauri [RUST]: 1.4.1
    - tauri-build [RUST]: 1.4.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: 1.4.0 (outdated, latest: 1.5.4)
    - @tauri-apps/cli [NPM]: 1.5.9 (outdated, latest: 1.5.13)

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist/v-frame
    - devPath: http://localhost:1420/
    - framework: Angular
    - bundler: Webpack

Stack trace
No response
Additional context
Tauri are able to detect new updates, but it just failed at some point.
updater json
{
"version": "1.1.3",
"pub_date": "2024-05-09T12:29:53+01:00",
"notes": "Updater Modifications",
"platforms": {
"windows-x86_64": {
"signature": "https://v-sing-malaysia-picture.s3.ap-southeast-1.amazonaws.com/v_frame/v-frame_1.1.2_x64_en-US.msi.zip.sig",
"url": "https://v-sing-malaysia-picture.s3.ap-southeast-1.amazonaws.com/v_frame/v-frame_1.1.2_x64_en-US.msi.zip"
}
}
}
tauri.conf.json
"updater":{
"active" : true,
"endpoints":[
"https://v-sing-malaysia-picture.s3.ap-southeast-1.amazonaws.com/v_frame/updater.json"
],
"dialog":true,
"pubkey":"dW50cnVzdGVkIGNvbW1lbnQ6IG1pbmlzaWduIHB1YmxpYyBrZXk6IDRBM0U4Mjk2NDUzQTZDNEMKUldSTWJEcEZsb0krU3JONHNPZk02MnRXS1ZHWTJOK2FmWUYvVkZQaG8xODlOSWd0OThsOGpPUlkK",
"windows": {
"installMode": "passive"
}
}

your updater.json includes the signature as a URL to the signature file but it expects the contents of the signature file not a URL to it.

your updater.json includes the signature as a URL to the signature file but it expects the contents of the signature file not a URL to it.

Thx but how do I actually can get the content, or how the updater.json should looks like 😵

it should look like this, notice the signature field is set to the contents of the .sig file not a URL to it
{
  "version": "1.1.3",
  "pub_date": "2024-05-09T12:29:53+01:00",
  "notes": "Updater Modifications",
  "platforms": {
    "windows-x86_64": {
      "signature": "dW50cnVzdGVkIGNvbW1lbnQ6IHNpZ25hdHVyZSBmcm9tIHRhdXJpIHNlY3JldCBrZXkKUlVSTWJEcEZsb0krU3JUUGxXdGxxT0dNVmJUMTF5Z1ZrWjdTZmR5VmVWd0huVG42SzVOa0w2VytFODVrelVUNSs4aUhUa0VFQ2xOd0gwbEVEZ2wyQlRycVJYZ1pQRTJoMkFZPQp0cnVzdGVkIGNvbW1lbnQ6IHRpbWVzdGFtcDoxNzE1MjQ2MDI1CWZpbGU6di1mcmFtZV8xLjEuMl94NjRfZW4tVVMubXNpLnppcApNQyszaTdvcmsvc1BueVVxaUJLeUJ2ZDI0THBmM0ZEek50aW8wNHJQcVptK3hTeE91QTFCM1hzVXpaVkNRVlZ1alZlUmxyeTRmdnM4V0VDMndYR1pEUT09Cg==",
      "url": "https://v-sing-malaysia-picture.s3.ap-southeast-1.amazonaws.com/v_frame/v-frame_1.1.2_x64_en-US.msi.zip"
    }
  }
}

Thx so much for correcting me on the path, instead of just enter URL, I have to open the sig file and paste the content inside. Maybe I was confused by the doc


python3 for support

I use pip install on python3.5, but it filed.

@decacent Seems like you fixed the issue (https://github.com/decacent/mlab/commit/2c423c43b183c7faf27d01b85e2c5662f3c9165d), thank you. Please consider doing a Pull Request to give your patch some visibility.


[RFC] Is it possible to be both const generic and dynamic size

Const generics and no-std are great features, both for performance and for interoperability.
The down side is that some protocols require a dynamic moduli, and maybe even dynamic sizes, for example RSA sizes(2048/3072/4096/8192 etc), or DSA moduli sizes, and more.
This gets more obvious with something like #28, which makes the type generic over the field, then you have to support a dynamic field to be able to support RSA, dynamic DSA moduli, groups with unknown order etc.
My question is is it possible to win both worlds, and somehow both allow const generics for arrays, but also allow dynamic generation over vectors?

It sounds like you want heap-backed, arbitrary precision integers in addition to the fixed-sized const generic ones?
If so, I'd say there aren't any plans to add that sort of thing any time soon. Maybe down the road, but it isn't on the radar right now. I'd also point out that if this is really what you want, there are many, many libraries in the Rust ecosystem to select from which provide heap-backed arbitrary precision big integers.

dynamic sizes, for example RSA sizes(2048/3072/4096/8192 etc), dynamic DSA moduli,

If you want to select from different sizes at runtime, use an enum with variants for your acceptable alternatives. This is a solution that works not just for different sizes of RSA, but for whatever ciphers happen to fulfill a particular role.

If so, I'd say there aren't any plans to add that sort of thing any time soon. Maybe down the road, but it isn't on the radar right now. I'd also point out that if this is really what you want, there are many, many libraries in the Rust ecosystem to select from which provide heap-backed arbitrary precision big integers.

Well, even when using a heap based arbitrary precision integer, I'd want it to have a specific size determined in runtime, and not allow it to alloc any more than that. it's possible now if you prealloc + only use modular operations, but I'd rather have in enforced in the type system.

If that's all you want, it sounds like Box<UInt<N>> would suffice?

Not quite, it doesn't allow you to write the follwing:
fn get_integer(moduli: &str) -> Box<Uint>

(such that it will determine the size of the uint depending on the moduli)
It can probably also be done with a custom allocator that prohibits the reallocation.

Then you really need something like an enum to provide the type-level glue between a const-generic N and runtime selection of its size.
const N: usize needs to be fixed at compile-time, so there's no way to "select" it at runtime other than picking a fixed set of N values (e.g. your 2048/3072/4096/8192 above), placing those in something like an enum, and then picking the appropriate one at runtime.


Add Leeds Gaming and Leeds Werewolves, update the meetup days on Leeds Netrunner

Add two new events, update one.

Thanks, will be live soon.


Add rule prefer-const in eslint

Adding eslint-plugin-react to eslint instead of prefer-const. This allows the direct implementation of the arrow-function rule.


cmd/go: go get -d fails with "no go-import meta tag"

Hello, I've noticed that occasionally our CI builds have been failing during go get. It doesn't seem to be one package that's causing this to happen, and the issue usually resolves itself quickly, but the flakiness is causing alerts in our environments. I was asked to create a new issue in https://github.com/golang/go/issues/27622#issuecomment-420312891
Two examples follow:
package golang.org/x/crypto/pbkdf2: unrecognized import path "golang.org/x/crypto/pbkdf2" (fetch https://golang.org/x/crypto?go-get=1: no go-import meta tag)

package golang.org/x/net/html/charset: unrecognized import path "golang.org/x/net/html/charset" (parse https://golang.org/x/net/html/charset?go-get=1: no go-import meta tags ())

What version of Go are you using (go version)?
go version go1.9 linux/amd64
Does this issue reproduce with the latest release?
It's hard to say because it's flaky. I'm currently updating our CI servers to 1.10.
What operating system and processor architecture are you using (go env)?
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/rcapo/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build837121565=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
Ran go get -d ./... 2>&1 as part of a jenkins job.
What did you expect to see?
Nothing. Successful update
What did you see instead?
Errors above (both are golang.org/x/ packages)
package golang.org/x/...: unrecognized import path "golang.org/x/..." (parse https://golang.org/x/...?go-get=1: no go-import meta tags ())

go version go1.9 linux/amd64

Note that go1.9 is not longer supported per the release policy. Can you reproduce the failures on 1.10 or 1.11?

It's only happened for golang.org/x paths so far. Only running one go get at a time.
I think it may just be flakiness on the servers.

Sure, I'm updating go on the build servers now. I'll report back if I notice the issue again.

I just saw this issue on my CI, on Go 1.11, using docker image golang:1.11-alpine. A rerun seems to "fix" it.
package golang.org/x/crypto/pbkdf2: unrecognized import path "golang.org/x/crypto/pbkdf2" (parse https://golang.org/x/crypto/pbkdf2?go-get=1: no go-import meta tags ())
The full log from the job below:
Running with gitlab-runner 11.3.0-rc1 (861c565e)   on docker-auto-scale ed2dce3a Using Docker executor with image golang:1.11-alpine ... Pulling docker image golang:1.11-alpine ... Using docker image sha256:233ed4ed14bff3bd26934c973cc89ed04078ac95143fa741c3fbe1602fe20df9 for golang:1.11-alpine ... Running on runner-ed2dce3a-project-3575820-concurrent-0 via runner-ed2dce3a-srm-1537729575-628cda11... Cloning repository... Cloning into '/builds/drakonka/gosnaillife'... Checking out e1d1bcce as master...  Closing as duplicate.

Seeing the same issue via bitbucket pipelines on all "golang.org/x/.." dependencies

Please subscribe to https://github.com/golang/go/issues/30619.


:button_css: option seem to not only affect the current button.

my understanding was that :
.. try_examples::
    :button_css:
        background-color: red;

Would only make the current button red, though it seem to affect at least all the buttons on the page.
Maybe related to #122, but I suggest we have a single :example-class: <str>, that can be styled by the custom css. Even the button-top/button-bottom can be styled using custom flex-column/flex-reverse-column.

Yeah, I think an :example-class: or :example-id: as technically if something is unique in css you should use ID, but I think class + custom css should be able to do anything if we put the class on the outer try-example div.

I think this is closed by #129.


join / leave commands

commands to run when a user joins or leaves the server. config option

Include option for first join commands as well as maybe individual player and console commands


Unable to link to partial interfaces

Title: Test
Status: WD
TR: http://www.w3.org/TR/SpecName/
ED: http://www.w3.org/TR/SpecName
Previous Version: http://www.w3.org/TR/SpecName
Shortname: SpecName
Level: 1
Editor: John Doe, AnOrg<EMAIL_ADDRESS>Abstract: Abstract sentence

<dfn attribute for=Foo>bar</dfn>
<dfn attribute for=Foo>baz</dfn>

{{Foo!!interface}}
{{Foo}}

partial interface Foo {
    attribute DOMString bar;
};

interface Foo {
    attribute DOMString baz;
};

maybe we can link like this {{Foo!!partial-interface}}
The IDL index doesn't seem to link correctly either in this case. I would expect the IDL Index, partial interface to link to the partial interface definition.

This is correct and intentional - partial interfaces don't <dfn> a new interface-type term, they just link up to the base definition.  You can link to the new things you're actually defining, tho.


Use query endpoint for demos

One we have a live endpoint which proxies requests through the agent, incorporate that into the demo site

Addressed by #22


Using $vs.loading in router

Hello,
Is there a way to use $vs.loading in router hook beforeEach ? I have tried with Vue.prototype.$vs.loading but it is not working

did you manage to do that?

I'm using version 4 and got it that way
router.app.$vs.loading()
var loading;
const routes = [
{
....
router.beforeResolve((to, from, next) => {
if (to.name) loading = router.app.$vs.loading()
next()
})
router.afterEach((to, from) => {
loading.close()
})

I'm using version 4 and got it that way
router.app.$vs.loading()
var loading;
const routes = [
{
....
router.beforeResolve((to, from, next) => {
if (to.name) loading = router.app.$vs.loading()
next()
})
router.afterEach((to, from) => {
loading.close()
})


Type error when route's beforeLoad contains a throw without a return

Describe the bug
When using throw redirect inside a route's beforeLoad, Typescript complains that the options on that route are not compatible with RouteOptions type (with the error located in the rootRoute.addChildren method). When the routeTree is in this complaining state, useSearch (and friends) doesn't infer any types.
In my local environment, returning anything at all from the beforeLoad makes the error go away. So does leaving beforeLoad completely empty. Types on useSearch come back instantly when I do this.
I've set up a codesandbox that shows the type error, but for some reason I can't get any type inference on useSearch there no matter what I do.
This is not a newly introduced bug, it has been around since the version number was 2 digits I think, but not certain.
Your Example Website or App
https://codesandbox.io/s/sad-easley-gc4csx
Steps to Reproduce the Bug or Issue

Examine error on line 57 of index.tsx
Return anything from beforeLoad after the throw redirect on line 47 of index.tsx and the error goes away

Expected behavior
I expect that throwing is sufficient to correctly type the beforeLoad. The docs on Authenticated routes show this exact usage of throw redirect as an example.
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Firefox
Version: 104.0b7

Additional context
No response

Yeah, this is problematic because a function that always throws is typed as returning never, which will send more than just TanStack Router into a tizzy :)
To solve this, you would need to return something other than never. When you filed this issue, that wasn't possible, but as of 5 minutes ago, it is now :)
beforeLoad: () => {
  return redirect(...)
}

FYI this is now possible as of https://github.com/TanStack/router/releases/tag/v1.1.11


[refactor] environment for swhkd

This change introduces similar changes as #243 for swhkd.
The following were the changes made:

Added a new environ.rs which is central to the environment management system
Refactored env::var uses across the daemon.rs
Removed unsafe env uses

looks good. lgtm

Thanks!

Hi, I didn't get a chance to test this pr @zubairmh Did you do so?

Added some stuff that would enable the environ.rs to check if the path provided is valid or not

This looks good to me. I haven't gotten around to testing it yet. @newtoallofthis123 Have you tested the PR?

I did test it a while ago and everything seemed to work fine 😄
However, I'll test it again tomorrow and let you know just to be safe :)

@newtoallofthis123 looks good to go, have you tested this?

Yep! tested it and it works :)


PooledStreamingEventProcessor - Start fails after Stop invocation

Hi,
This is a new ticket as #1806 has been closed. I took a look at the implementation (especially at the pull request https://github.com/AxonFramework/AxonFramework/pull/1823) and I think I see two major flaws.
I couldn't use the 4.5.x-Branch due to some weird compiler issue, but I switched to the tag 4.5.1 and cherry-picked the pull request.
First issue:
The AxonAutoConfiguration.configureEventHandling makes a call to builder.workerExecutor(workerExecutor) which in turn sets shutdownWorkerServiceOnStop to false. Therefore only the coordinator service is stopped when I close the Spring context - but not the worker service. So the original issue (that the services are not stopped) remains.
Second issue:
It is not possible to reset the PooledStreamingEventProcessor. One would usually do something like the following to reset the processor:
StreamingEventProcessor eventProcessor = eventProcessingConfiguration.eventProcessor( "MyProjector" , StreamingEventProcessor.class).orElseThrow( );
eventProcessor.shutDown( );
eventProcessor.resetTokens( );
eventProcessor.start( );

However, doing this with the applied pull request leads to a RejectedExecutionException, because the coordinator service has been shut down. I encountered the same issue while trying to fix the original issue myself. Stopping the execution services is easy. Restarting them on the other hand...
I would recommend to revert the commit for the moment.
Best regards
Nils

Thanks again for filing this issue with us @nils-christian.
It's always very helpful to have users try out what we've provided ASAP, simply to iron out potential issues.
Without further ado, let me move to the named concerns:

This issue should be resolved by commit https://github.com/AxonFramework/AxonFramework/commit/4722b86ecac9a1f7d29ddead5871f1daf715f308.
Allard and me spotted the same misser after some additional tests, but decided not to open a PR simply to add the constructed ScheduledExecutorService to the shutdown process of Axon's Configuration.
Just cherry-picking the PR would indeed not have shown this solution. Please give it a try with a snapshot build of axon-4.5.x if you want to try it out.

Great point here @nils-christian. I'll take on this issue number to construct a PR to fix that described problem.

Hi Steven,
I can confirm that the first issue does not occur when using the current 4.5.2-Snapshot.
Best regards
Nils

Closing this issue since it has been resolved in pull request #1829
@nils-christian, feel free to check it out if you want!

Hi @smcvb,
With the current snapshot everything seems to work fine. I cannot reproduce the issues. Thank you very much.

Thanks for the heads-up Nils! You can expect the release of framework 4.5.2 somewhere next week, by the way :-)


feat: Merge jsx symbols into lsp tree

Addresses #153.
The idea is to first deeply sort the jsx and lsp trees, then merge the two by iterating through the symbols in order of symbol start position, deeply reconstructing the tree as we iterate.

I tried out your fork (and confirmed packer has the correct commit at ddc379b) but I can't seem to get it working in JSX or TSX, it still just shows the symbols for the JSX markup and not local variables defined before.
Not sure what debug output you might need, but let me know and I can comment it here. I'm on nvim nightly.

Not sure what debug output you might need

Can you send an example jsx file where this happens?

https://gist.github.com/CallumHoward/07fc4604443363d6e917d0b324998b97

@CallumHoward

I am not able to reproduce. Are you absolutely sure you have the PR loaded? You can check by adding a print statement somewhere like in this function.

Ah yes, it's my mistake, I was on master, not on merge-jsx-tree. Sorry for the trouble, it works great!

it works for me, thanks for your contribution. well done

Anything missing to get this merged? A feature many would appreciate

@TheodorRene
It looks like @simrat39 is not be actively maintaining this project anymore (which is understandable - they are a student!) Not sure what that means for the future of this project though :(

I'm having the same problem.

@TheodorRene
It looks like @simrat39 is not be actively maintaining this project anymore (which is understandable - they are a student!) Not sure what that means for the future of this project though :(

Very understandable. Anyone know a good alternative, or maintained fork?

I'm sorry, I was super busy with stuff, but I should be back now, so I'll look into it


Page indicator should be below imageview

It looks odd to have indicator above imageview. Is there any method to push it down

It worked for me by setting the custom carousel and changing the setIndicatorGravity to Gravity.BOTTOM. Like this:
customCarouselView.setIndicatorGravity(Gravity.CENTER_HORIZONTAL|Gravity.BOTTOM);
In case you need the code tell me and I'll share it with you.

Share the code if possible. I am using it in recycler view. Will it have any effect.

I tried it's not reflecting anything.

Hi, please share the code to try to replay de error you are having.


"data-trigger= focus" restrict any click event within popover when use laptop's trackpad in bootstrap 3

Bootstrap 3 is essentially in maintenance mode as we focus on working on v4. As such, we're only accepting changes to v3's code on a case-by-case basis, usually only for critical bug fixes or docs improvements.


Re-enable wasm tests

What was wrong?
How was it fixed?
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #430 (e6c68b8) into master (1e45350) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   86.09%   86.09%
=======================================
  Files          71       71
  Lines        4637     4637
=======================================
  Hits         3992     3992
  Misses        645      645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e45350...e6c68b8. Read the comment docs.


Link server to kafka in compose

Status
READY
JIRA Ticket
N/A
Description
Adds Kafka environment variables to docker-compose.yml so that docker-compose up spatialconnect-server starts without exception. Also changes the Kafka service's KAFKA_ADVERTISED_HOST_NAME to kafka to match the container name.
Todos

[ ] Tests
[ ] Documentation
[ ] License

Steps to Test or Reproduce
git fetch --all
git checkout link-server-to-kafka-in-compose
docker-compose up spatialconnect-server

Expected behaviour is that the server starts and responds to requests at localhost:8085.
Actual behaviour is an exception in stdout (fails to create Kafka producer), server process remains running (container does not exit) and does not respond on port 8085.
@boundlessgeo/spatial-connect

@martinwilkerson-scisys thanks for the fix 😎


Data for Job V2 should support URL list

Currently data URL is separated by "," which is not user friendly.

support now.


Create a website

Create a website based on this screenshot. Please make it as close as possible.

Forgor to send in ui-gen


Add nix packaging

Nice! Coincidentally, I've finally pushed the nixpkgs package + NixOS module, including some integration tests. Feedback is welcome in case you have any. https://github.com/NixOS/nixpkgs/pull/351678


add spec for #1620

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?

Create a spec as requested by @denelon at https://github.com/microsoft/winget-cli/issues/1620#issuecomment-1206565768
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

@denelon can you review it?

My "meta" feedback is this seems to work well for installing a single package.
We shouldn't have ambiguity with import since the source and the ID need to be specified in the packages.json file.
I wonder if we should have a "default" behavior and settings to change the default behavior. It may not be necessary, but this is a departure from the current behavior.
I'm also not sure what this is going to "sound" like with narrator running.
Our telemetry needs to be reasoned about as well. If a user runs winget install <something> and we're not able to narrow it down to a single package, I don't want to have some "false" increased concept of "success".

@yao-msft what are your thoughts here?

This package selection mechanism could be extended to winget upgrade <single package>, winget uninstall <single package> and winget show <single package> as well, since these use the same worflow to pick a package internally.
Regarding default behavior, I think it'd be better to make this one opt-in from a specific argument since most automated systems, script writers will not be compatible with this change. Or we should announce this "breaking" default behavior well ahead before we make this the default behavior. In the early winget design principal, winget tries not to prompt for user input unless it has to(i.e. accepting agreements, missing arguments, etc), and the prompt can be disabled in many ways.
Regarding installing multiple packages in one command, it requires further thinking and framework changes are likely required to support this. Command line syntax may also need to be revisited.

@yao-msft
So maybe something like adding "--prompt" could prompt if the results are ambiguous, and a setting could be added to make the setting default and "--no-prompt" could override the setting via the CLI?

@yao-msft So maybe something like adding "--prompt" could prompt if the results are ambiguous, and a setting could be added to make the setting default and "--no-prompt" could override the setting via the CLI?

We already have a cli arg and user setting both called "DisableInteractivity" to indicate "no prompt", it's opted in for com callers(can not be overriden) but not from cli. So I guess the current default in cli is already "allow prompt". But currently only very few packages will trigger a prompt. With this feature, we'll see prompts a lot more, so I'm wondering if we should have a specific opt in for this(from settings), we may change the default behavior in future. In another thought, if existing scripts work, they should already be able to point to a specific package, so it might not be that "breaking" for existing scripts and automated systems. I think a setting for opt in is enough. And I'm open to other suggestions as well.

This package selection mechanism could be extended to winget upgrade <single package>, winget uninstall <single package> and winget show <single package> as well, since these use the same worflow to pick a package internally.

Yes this can/should be extended to those as well. Will make that change in the spec.

Regarding default behavior, I think it'd be better to make this one opt-in from a specific argument (or settings?) since most automated systems, script writers will not be compatible with this change. Or we should announce this "breaking" default behavior well ahead before we make this the default behavior. In the early winget design principal, winget tries not to prompt for user input unless it has to(i.e. accepting agreements, missing arguments, etc), and the prompt can be disabled in many ways.

Can you please elaborate on this more? As I feel it will only come in if there are multiple matches and we get a table of packages in current implementation.
Everyone would write a script using Id's which are a unique to each package and if they get the selector they will get the current table in current implementation.
Only difference would be that in current implementation the command would return and not wait for an user input.

Regarding installing multiple packages in one command, it requires further thinking and framework changes are likely required to support this. Command line syntax may also need to be revisited.

Yeah, that is not the goal of this spec. I added that because if in future we plan to add that this is how selector should work.

With this feature, we'll see prompts a lot more

How? This will only come into picture if there are multiple matches in current implementation.
For example.
winget install Powershell

It currently gives you 2 packages and after this it will also give you 2 packages just will a easy selector.

I'm also not sure what this is going to "sound" like with narrator running.

Yeah I'm also not sure about that but if it reads it line by line then there shouldn't be a big problem.
Maybe I can try implementing a dummy one and see.

Our telemetry needs to be reasoned about as well. If a user runs winget install <something> and we're not able to narrow it down to a single package, I don't want to have some "false" increased concept of "success".

I haven't thought about this. Can you help me out with it?

I wonder if we should have a "default" behavior and settings to change the default behavior. It may not be necessary, but this is a departure from the current behavior.

I think this is a necessity, especially for this feature. As was mentioned in the original issue and I touched upon in my review, there are users who will not want this feature at all - even outside of a scripting perspective. I would be a strong advocate for including user settings.

Our telemetry needs to be reasoned about as well. If a user runs winget install  and we're not able to narrow it down to a single package, I don't want to have some "false" increased concept of "success".

I think this is as "simple" as adding a context flag that gets set whenever the interactive selector gets called, and sending that flag along with the telemetry. I would still count it as a success if the user was able to manually disambiguate, but I can understand if the internal needs differ here.

This package selection mechanism could be extended to winget upgrade , winget uninstall  and winget show  as well, since these use the same workflow to pick a package internally.

I think implementing this for upgrade would conflict with #2627. It may be a good feature in the meantime though. I agree with adding it for uninstall and show.

With this feature, we'll see prompts a lot more, so I'm wondering if we should have a specific opt in for this(from settings), we may change the default behavior in future. In another thought, if existing scripts work, they should already be able to point to a specific package, so it might not be that "breaking" for existing scripts and automated systems. I think a setting for opt in is enough. And I'm open to other suggestions as well.

I go both ways on this. On one hand you have people like me who are technically inclined that would prefer to see and work with CLI output directly rather than have any form of interactivity in a CLI application, except that which is strictly necessary. On the other hand you have people who are using winget to install their favorite application and want it to be as quick and seamless as possible, and having interactivity would help. I think opt-out is easiest to implement from the DisableInteractivity perspective, and keeps the same current default behavior as other interactivity, but I prefer the original design principal of not asking for input unless we have to. I say that opt-in would be my final preference. (Apologies for long section, had to write my thoughts down for me to understand them myself)

Regarding default behavior, I think it'd be better to make this one opt-in from a specific argument (or settings?) since most automated systems, script writers will not be compatible with this change

I agree. Not only because of the points mentioned above, but I know that some scripts like marinet101/WingetUI actually use the table output and parse the text. Adding in an additional column here or making it so that the feature is opt-out would be a breaking change for them.

Everyone would write a script using Id's which are a unique to each package and if they get the selector they will get the current table in current implementation.

Id's aren't always guaranteed to be unique to a package. The item which is guaranteed to be unique is the Source-ID pair. It is entirely possible that two sources have the same identifier for different packages.

In another thought, if existing scripts work, they should already be able to point to a specific package, so it might not be that "breaking" for existing scripts and automated systems.

The more I think about this, I believe that the dynamic nature of sources would make this a breaking change. It is entirely possible that a script which is working today could be broken tomorrow by someone adding a new package to the repository, assuming the script was pointing at a volatile field like a package name; Or even in cases where a sub-package is added and there is potential for a moniker conflict that we aren't aware of. I would suspect that a sysadmin would rather have 1 package that failed to install with a very clear log about why as opposed to coming back several hours later just to find that the script hung because they weren't aware of the --disable-interactivity flag, and thought there would be no issues since the script was working fine before.

I think the default behavior should not change. This would certainly be breaking. I would expect to have a setting for "disambiguation". maybe "prompt" and "no-prompt". Then if one had the default they could override with "--prompt" or "--no-prompt".
The default setting would be "no-prompt"
Overriding the default setting would look like:
winget install PowerToys --prompt
Changing the default setting would look like:
"packageDisambiguation": {"prompt"}

Overriding the "prompt" setting would look like:
winget install PowerToys --no-prompt

Changing this behavior to be the default would require:

#2128

Hey @denelon, @yao-msft and @Trenly for your suggestions. I have updated the specs from suggestions you have given.

How it will handle --disable-interactivity
How it will handle invalid inputs
How user can refine their search results
Added how the settings should look like
Added a compatibility issue with MinTTY (#2013)
Added a limit on the number of packages shown
Made it an opt-in feature

Tho there are a few things where I don't have much knowledge about and would be great if you can help me out in those parts.

I think implementing this for upgrade would conflict with https://github.com/microsoft/winget-cli/issues/2627. It may be a good feature in the meantime though. I agree with adding it for uninstall and show.

@Trenly I'm not sure how this will conflict it

I think this is as "simple" as adding a context flag that gets set whenever the interactive selector gets called, and sending that flag along with the telemetry. I would still count it as a success if the user was able to manually disambiguate, but I can understand if the internal needs differ here.

I don't have any knowledge how telemetry and localization work and hence couldn't add anything about it in spec.
It would be great if you can point be where I can get to know about those.

I tried by printing an example on terminal with screen reader on. It read me the whole thing correctly but read No. (abbreviation of number) as No (as in answer to question).
Is there a way where we can get to know that the screen reader is on and print Number instead of No. or we should stick with Number?

I need your suggestions on how refine search should work. Should it refine results on the basis of exact match or match pattern?
I'm inclined towards matching patterns, but it may result into extra steps for users. Like if there are 2 packages with name Example and a package with name Example2 pattern matching will result in to retaining all three if user types Example to refine them. But at the same time, it will help users to type less to refine results.
Again, I would like it to be as pattern matching thing instead of exact match.

As previously discussed in review comment to have tab selection.
I'm not sure if it will be intuitive for users to use Tab to cycle through number. But if we are going with this, I want your opinion on if it should only cycle through number or package names as well? It doesn't make much sense to me to have both, cycling through numbers is more than enough in my opinion.
Also, if we are having Tab to cycle forward then we should have Tab + Shift to cycle backwards.

@Trenly I'm not sure how this will conflict it

If a user were to type winget upgrade Microsoft - there are multiple packages that match. The conflict would be whether the selection menu is shown, or if all packages matching Microsoft would be upgraded

Is there a way where we can get to know that the screen reader is on

I'm certain this is possible, it would just be a matter of how big the change would be to support this. It's probably better to use the full text Number all the time, or an alternate name like Index

I need your suggestions on how refine search should work. Should it refine results on the basis of exact match or match pattern?

I would suggest this be implemented as a temporary source. Essentially, the results in the table (including those that are truncated), would become a local source, and the default query behavior would be used. I believe this is a substring match, but I'd leave it up to whatever the current default search behavior is

I want your opinion on if it should only cycle through number or package names as well

My interpretation of denelon's comments is that tab completion would be most beneficial for cycling through Package Identifiers, and wouldn't be as helpful / necessary for numbers.

Also, if we are having Tab to cycle forward then we should have Tab + Shift to cycle backwards.

I agree. This is the current implementation of the tab completion used in the client, and the behavior should be carried forward.

If a user were to type winget upgrade Microsoft - there are multiple packages that match. The conflict would be whether the selection menu is shown, or if all packages matching Microsoft would be upgraded

So that should be added in potential issues section, right?

I'm certain this is possible, it would just be a matter of how big the change would be to support this. It's probably better to use the full text Number all the time, or an alternate name like Index

Number feels a better user-friendly word.

I would suggest this be implemented as a temporary source. Essentially, the results in the table (including those that are truncated), would become a local source, and the default query behavior would be used. I believe this is a substring match, but I'd leave it up to whatever the current default search behavior is

I feel default one is pattern matching by looking at the winget upgrade Microsoft example.

My interpretation of denelon's comments is that tab completion would be most beneficial for cycling through Package Identifiers, and wouldn't be as helpful / necessary for numbers.

Perfect, will make the necessary changes in next iteration.

@Trenly should we also rename of file to Query refinement.md?

@Trenly should we also rename of file to Query refinement.md?

Probably a good idea

@denelon, @yao-msft can you have a look?

@denelon, @yao-msft can you have a look?

Hi @SirusCodes,
Thanks for your contribution and continued refinement of the spec. We are currently in the process of getting a release candidate of winget v1.4.0. We will get back to the spec when this feature work is scheduled.
Usually the spec will be checked in around the time implementation is done. And the spec might need to be modified and extended to match the actual implementation. I.e. features actually done, features moved to be considered in the future, a little description on the technical implementation like data schema, and expected behaviors and known issues, etc.
Thanks,
Yao

It appears this has been stagnated since Dec '22
Is this still on the cards for future implementation?

Yes, we still want to offer an "interactive" mode for WinGet. We've been discussing several scenarios internally. This is one of the topics most likely to lead towards a WinGet 2.0.
Ideally, the default behavior for that version of WinGet will support better interactive experiences for users. We're also very aware of the desire to have non-interactive scripted experiences. We've been discussing the impact for automated scenarios and how we would have the client respond so scripted behaviors could more easily isolate the failures encountered by interruptions caused by interactive prompts expecting a user to respond.
If we offer the interactive experience as an option a user could "opt-in" we would need to figure out the best way to help them discover this new mode. We would certainly need settings and command-line arguments to toggle the behavior as a default mode as well as an override option.

what's the latest update on this?

Hi all, I'm a bit busy. Will try to look at the PR this weekend.

@Trenly @denelon I have updated the spec.
I thought disambiguating each package separately would be a better idea because it will leave out edge cases where a user might filter out the package they wanted to install and go back through this whole process.

@SiriusCodes, I've done a readthrough. The spec looks fairly thorough to me. At this point I'd like to get one of the engineers to perform a bit of a sanity check 😊
I'm also thinking we need to reason about what this would imply with the PowerShell way of doing things. I'm not sure it makes sense to have this kind of treatment in PowerShell though, so I'll see if I can get a few folks to look at it and give feedback.
@JohnMcPMS


Adding Identity Module to the blocks.

Hello,
I love using your library, however, I find it missing a feature that I need for my implementation. Namely, the package does not support different sizes of consecutive columns and so in order to solve this I want to add identity layers as place holders so each column is of the same size.
Would you instruct me on how to do this?
Thanks!

Hey Ivangvozdanovic!
You could define one like this:
`class ProgIdent(ProgInertBlock):
def init(self):
super().init()
def runBlock(self, x):
    return x

def runActivation(self, x):
    return x`

this would define a new inert block (no laterals) that just passes through.
Alternatively, you can use the existing ProgLambda with an identity function.
Hope this helped!


JaveScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Added to main code, looked at variables and control flows


Prevent exception when legacy accounts have >50k contacts. Issue #2436

Critical Changes
Changes

Charles Koppelman has contributed an NPSP fix to handle deleting Contacts from an Account with over 50,000 contacts in it.  Thank you Charles!

Issues Closed
Fixes #2436

@ckoppelman


Remove sra-report link since its removal for v2

sra-report was removed after v2 was released and it wasn't updated.

Thanks @liamzebedee!


[Bug]: not able to stream due to lost packages at end of last stream

Client version
latest
Node version
all
Operating System type
Other
Operating system version
all
Describe the bug
If packets are lost at the end of a stream the client cannot keep track of the correct sequence number. Therefore any attempt at streaming after that will fail, since the client always expects a sequence number which will 'never' be reached (until the sequence numbers were reset and it all starts again at zero).
You can see this in the log with the sequence number 37040 which was lost right when the stream was closed.
It only is received after the stream is already closed and then it is ignored. The next stream attempt fails, since the client waits on this sequence number.
To reproduce

Go to '...'
Click on '...'
Scroll down to '....'
See error

Screenshots & Logfiles
squence_number_loss.log
Additional context
No response

Fixed in version 2.3.0.

Thx!
Will test with new version and see if it happens again.
Seems like I'll have to look into my network performance with all those lost packets, but at least it helped finding a few minor bugs. :-)

Hi! Not exactly the same issue, but could you have a quick look at the log output here: https://github.com/homebridge-eufy-security/plugin/issues/229 ?
It seems that the new Homebridge version (1.6.0) breaks something with the network and the sequence number jumps wildly back after streaming a couple of seconds. Have you seen something like this before?
Still waiting for confirmation that this is not just me - but have already reproduced this on 1 Debian VM and 1 Windows machine.

Unfortunately did just experience this with Homebridge 1.5.1 also. This version worked fine until now.
I thought 1.6.0 fails much sooner, but could also have been coincidence. Will have to look into this.
Now I wonder if this has something to do with the latest changes.
For now it seems that the station begins to spam 'old' packets - maybe because it did not get the ACKs in time. But it seems odd to me that this spamming should overshadow really every 'new' packet for 5 seconds. Because after this timeout the stream should end:
2022-11-26 19:37:45.962  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - received from host <IP_ADDRESS>:19548 - Processing sequence 38357...
2022-11-26 19:37:45.963  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - Received already processed sequence (expectedSeqNo: 38478 seqNo: 38357 queuedData.size: 0)
2022-11-26 19:37:45.985  INFO  [Timeout._onTimeout] Stopping the station stream for the device T8210P0020441DD5, because we haven't received any data for 5000 seconds
2022-11-26 19:37:45.994  WARN [EufySecurity.stopStationLivestream] The station stream for the device T8210P0020441DD5 cannot be stopped, because it isn't streaming!
2022-11-26 19:37:45.994  WARN [EufySecurity.stopStationLivestream] The station stream for the device T8210P0020441DD5 cannot be stopped, because it isn't streaming!
2022-11-26 19:37:45.995  WARN [EufySecurity.stopStationLivestream] The station stream for the device T8210P0020441DD5 cannot be stopped, because it isn't streaming!
2022-11-26 19:37:46.023  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - received from host <IP_ADDRESS>:19548 - Processing sequence 38415...
2022-11-26 19:37:46.023  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - Received already processed sequence (expectedSeqNo: 38478 seqNo: 38415 queuedData.size: 0)
2022-11-26 19:37:46.053  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - received from host <IP_ADDRESS>:19548 - Processing sequence 38357...
2022-11-26 19:37:46.054  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - Received already processed sequence (expectedSeqNo: 38478 seqNo: 38357 queuedData.size: 0)

But here's the other thing: the stream is not closed. And after a while it gets to packets it can process eventually and just ignores theses packets:
2022-11-26 19:37:49.839  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - Received expected sequence (expectedSeqNo: 38494 seqNo: 38493 queuedData.size: 0)
2022-11-26 19:37:49.842  DEBUG [P2PClientProtocol.handleMsg] Station T8010P232045197D - DATA VIDEO - received from host <IP_ADDRESS>:19548 - Processing sequence 38494...
2022-11-26 19:37:49.842  DEBUG [P2PClientProtocol.parseDataMessage] Station T8010P232045197D - DATA VIDEO - Stream not started ignore this data

I can provide a full log if you'd like.
I'll try to improve my network and see if this helps with it also.

For now it seems that the station begins to spam 'old' packets - maybe because it did not get the ACKs in time.

yes I think so too.

Because after this timeout the stream should end

After the 5 seconds timeout, the stream is currently only terminated internally, i.e. no more video data is accepted, but no stop livestream command is sent.
This is still on my to-do list, see here:
https://github.com/bropat/eufy-security-client/blob/4d2684e56757b60c2c8afa1ff5c4df75016c6fac/src/p2p/session.ts#L983
Therefore, the behaviour described above is correct at the moment.

After testing a few days I would say this works now as expected. At least I didn't experience any stream related hiccups anymore since I improved the network performance.
I am curious though if there is something that can be done about the errors I've encountered, since I properly won't be the only user with bad connection issues. And to some it might not be that obvious that this is a network issue on their side and not directly related to this client.

I didn't experience any stream related hiccups anymore since I improved the network performance.

Hey @thieren, if you don't mind sharing, what did you do? I'm constantly experiencing lost packets, which suddenly interrupts downloads and live streams every few minutes.

I didn't experience any stream related hiccups anymore since I improved the network performance.

Hey @thieren, if you don't mind sharing, what did you do? I'm constantly experiencing lost packets, which suddenly interrupts downloads and live streams every few minutes.

@azavisha I just connected the Homebase to my wired network. Wireless was also working fine until I changed the location of some of my access points. After that the Homebase constantly had a bad signal and switched continuously from one AP to another. That was why I had  a lot of lost packets. Therefore the wired connection is much better now. I also made sure that the Homebase is not that far away from my doorbell, so that their connection is fine.
So if your experiencing lost packets I'd recommend checking the wifi signal.

Thank you @thieren!
Based on the logs, it definitely looks like some packets are lost and the timeout stops the stream. Although, I'm not sure why the station doesn't resend the packet when it doesn't receive an acknowledgment...
What's interesting is that the mobile eufy app somehow manages to show live streams without any noticeable interruptions almost indefinitely over the same network connection. It does get interrupted but much less often – probably two orders of magnitude. Perhaps their mobile app has some built-in error correction algorithm.
It appears that they have some error


Include more examples

Add an example with explanation. The example is: If both the Subscription and Resource Group have values for a tag, and different values, which one will be used on the Usage record if using tagging inheritance?
Also add examples to cover all the possible permutations and combination scenarios.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d6c6583a-09ae-b057-a173-82f8841dc535
Version Independent ID: 1bb6c9e9-a4b6-47bd-f70f-a53dd0de1421
Content: Group and allocate costs using tag inheritance - Microsoft Cost Management
Content Source: articles/cost-management-billing/costs/enable-tag-inheritance.md
Service: cost-management-billing
Sub-service: cost-management
GitHub Login: @bandersmsft
Microsoft Alias: banders

Assigning to content owner @bandersmsft for visibility, review and to enhance the document as required. Thanks.

@KrishnaG-MSFT I'm closing this issue here and will pick up through company email.
Let's handle internal doc requests outside of this public forum.
#please-close


Ensure matched is false if field does not exist

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


avoid dust outputs

do not select LBTC coins that will create under dust limit change output, if not possible below the dust limit it should be added to the miner fee for both convenience and privacy.

Won't fix


Completed Loads table's Status column showing "Filestatus.loaded"

Status column on vendor interface view should have "loaded", "loading_error", etc rather than "FileStatus.loaded"

fixed by #486?

@justinlittman @aaron-collier did #486 fix this?

I think so. Closing.


Fix TestNoProxyHeaders and TestNoProxyHeadersHttps tests

When the original request has a Connection: close header Go sets r.Close to true. When this is true Go adds the Connection: close header to the outgoing request even if the header was removed.
Fixes https://github.com/elazarl/goproxy/issues/92
This does mean that there is currently no way to make goproxy set a Connection: close header for its outgoing requests. I guess this could be made an option in ProxyCtx so you can change it in a request handler.

@elazarl no?

Tests are still failing...

Tests are not failing anymore, closing this PR


Post parameters are lost in the filter chain

The security filter attempts to read request parameter to sanitize the request. The read will nullify the request input stream. As a result, POST parameters that are available in the body of the request are lost when the request is handed off to downstream components. An example of this is the CAS REST API where POST parameters get lost in transition.

Confirmed that the filter is handling the parameters per the spec. Combing this filter with any other downstream systems that attempt to reach into and read the input stream will cause unpredictable side effects. see the javadoc for the request.getParameter() for more info.