Add syslog for rep_windows job

A/C: As an operator I should be able to see logs from rep_windows in
syslog destination syslog_daemon_config defined in my cf manifest.
The support for the new environment variables has been added to AWS stemcell version 0.0.73 and above.
[#133698951]
https://www.pivotaltracker.com/story/show/133698951
Signed-off-by: Natalie Arellano<EMAIL_ADDRESS>

Thanks, @aminjam! Sounds reasonable, and thanks for the acceptance criteria. Prioritizing for the Diego team to evaluate.
Best,
Eric

Great, thanks!

@jenspinney && @nimakaviani


Process attachments before they are sent to Gmail Servers

I need to remove the metadata from the attachments.
We have developed a Web Service that receives the files and returns them without metadata.
The following function intercepts when a user attaches a file:

gmail.observe.before("upload_attachment", function(file, xhr) {
var body_params = xhr.xhrParams.body_params;
console.log("file", file, 'xhr', xhr);
})

How do I replace the original file with the processed one?
Regards,

I haven't done anything like that myself. If you can't find any API to do what you want in the README, it's probably not there.
In that case, you will have to reverse-engineer the gmail.js DOM, and try to come up with a solution of your own.


White screen after switch tabs

os:
iOS
version:

react-native-swiper v1.5.13
react-native v0.48.3

When react-native-swiper used with tab navigatiotr (react-navigation), after switch  to other tabs a few time and switch back, the swiper turns out a white screen.
It is a problem only on iOS, while it works well on Android. I found if I set "removeClippedSubviews: false" in index.js of react-native-swiper, the problem seems solved. However I have not done further test yet.

os:
win 10 x64
version:

react-native-swiper v1.5.13
react-native v0.50.4

Hello, I have same issue on physical android device while Remote JS Debug is enabled . I have found that this issue is related to styles.
For example:
var stylesForSwipper = StyleSheet.create({
    wrapper: {},
    slide1: {
        flex: 1,
        backgroundColor: '#9DD6EB',
    },
    slide2: {
        flex: 1,
        backgroundColor: '#97CAE5',
    },
})

And here is render() method:
<Swiper style={stylesForSwipper.wrapper} showsButtons={true}>
   <View style={stylesForSwipper.slide1}>
      ...
   </View>
   <View style={stylesForSwipper.slide2}>
      ...
   </View>
</Swiper>

This leads to white screen but navigation buttons are visible.
This issue occurs for me only if Remote JS Debug is enabled.

set this attribute on swiper removeClippedSubviews={false}
you should not use this attribute for large listViews.

@borvelt removeClippedSubviews={false} work for me

@borvelt removeClippedSubviews={false} work for me, thank you

@borvelt wrok for me too, thank you very much!


From Codacy to something else?

There seems to be constantly issues with Codacy, about not finding the dependencies used within our several repositories.
I have been using for similar activities SonarCloud.
Here are some search results for comparing those two and others:

https://www.gartner.com/reviews/market/application-security-testing/compare/codacy-vs-sonarsource
https://www.adservio.fr/post/best-tools-for-continuous-code-quality-and-automated-code-review

Problems with dependencies can be seen here https://app.codacy.com/gh/Visual-Regression-Tracker/frontend/pullRequest?prid=12222875

Now the backend repo has been setup at SonarCloud, at the readme shows two sets of badges for comparison
https://github.com/Visual-Regression-Tracker/backend
At the moment, rest of the repos are using the "automatic" config which does not evaluate code coverage.
Anyone wanting to continue for other repositories?

Codacy removed from backend and frontend project


enhancement change tablet search algorithm from random  to round-robin for random distribution table

fix race condition problem when get tablet load index
change tablet search algorithm from random  to round-robin for random distribution table when load_to_single_tablet set to false

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

Do you have any performance result or anything else to prove that round robin is better than random?

data will distribute more even, random can not ensure that.

run buildall

run buildall

run buildall


Is Naver LINE supported?

I've tried a few games with archon and they work fine. However, for LINE, it stucks at "loading" in the homescreen, regardless what button is pressed there. Since no log produced, I have no idea what's wrong. Can you help?

It crashed.


Already informative references not noticed

Checker finds two inline references, but fails to notice that these are in the informative references section.
https://labs.w3.org/normative-references/check?url=https%3A%2F%2Fwww.w3.org%2FTR%2FWOFF2%2F

actually, I see that the 2 refs appear in the internet media type definition and that section isn't marked as informative as far as I can tell. Am i missing something?


R2000 Driver produces corrupt data under high load

We experienced an issue during field testing a week ago where the system was unable to keep up with the log data rate for whatever reason, and this appears to have led to corrupt data logged from the R2000 sensor attached.  Missing data would obviously be expected if the system is unable to keep up, however in this case it appears that data is incorrectly assigned to points in the wrong laserscan or something, leading to things like the ground plane of the scan being duplicated and mis-aligned.
I haven't had time to reproduce this in the lab yet, but it appears to me that the current driver code (e.g. here) doesn't do any validation that packets are arriving and being parsed in order without missing packets, and so if packets are out of order or dropped, the subsequent scan points end up being incorrectly assigned to the wrong angular slots in a ScanData object.  I am hoping to have time later this afternoon to do some further testing of this in the office.
Of interest: the R2300 we were logging at the same time doesn't appear to have any issues with corrupt data - unclear to me exactly why that is; maybe each scan fits entirely in one packet or something?

@bk-mtg thanks for reporting the issue. Please update the thread once you have more information. I'll try to include packet validation.

I have these problems also and added a quick fix for not publishing corrupt data.
But I don't know what triggers this.  This should help in debugging the problem.

Sorry, missed your question.
I don't think we have a "high load" scenario.
It just happens under "normal" usage, although we have another scanner ( Sick microscan ) on the bus.
But we are not maxing out network bandwidth.
To sum it up, I can't really tell you what leads to these errors or how to reproduce them other than starting the laser node.

Wonder if maybe this is somehow related to TCP retransmissions or something?  e.g. if a second device is sending on the network, you may occasionally get packet collisions and the R2000 may re-send packets, which could arrive out of order or similar?
Unfortunately, I won't be able to reproduce this for the foreseeable future, as our project involving R2000/R2300 is on hold.
@maxlein if you are able to reproduce this reliably, maybe a packet capture with wireshark or tcpdump might be helpful for debugging?

I have recently added quite a few commits. Could you please pull the latest master and try this again and report back your finding?

Don't currently have a ROS/R2000 setup handy, but it looks to me like #14 addresses the core bug I thought I saw in the older version of the code.
That said (based on a quick read-through of the code, so I may have missed some things), I think there are still some issues when packets go missing or arrive out of order:

No data is ever written in to the slots in the LaserScan message corresponding to a missing packet (as far as I can tell)
If the scan never receives its final packet, it never gets published; could add that someplace like here for example
If the first packet of a scan never arrives (or arrives late), a new message is not started and any other packets from that scan are discarded

I think the correct behavior when 100% of packets arrive (and are in order) is pretty easy, but things get a little more difficult if packets go missing.  Should partial scans be returned at all? (I suspect yes.)  If there are missing packets in a scan, should we give up on them immediately (when we start receiving the next scan) or wait a while to see if they turn up? (I'd be inclined to be lazy and not wait.)  So then, the algorithm might be something like:

instead of checking for packet 1 in a scan, watch for the scan number to increment.  Probably want to look for it to be increasing by a small amount (or decreasing substantially when the counter rolls over), rather than just looking for it to change, since it will occasionally do that if packets arrive out of order.
publish scan messages when a scan is complete (as is done currently) OR if the next packet of a new scan is received (this is where life would get complicated if you wanted to try to wait around on older scans for a while in case their packets show up)
Maybe (?) fill scan messages with empty data before starting so that missing packets will leave appropriate NaN or other missing data, instead of (I assume) zeros.  Though maybe zeros are going to get filtered out anyway?

If I get some time in the next week or two, I'll try to spin up a copy of ROS so that I can do some testing.

Been doing some more thinking about this, and I'm not sure my suggestion of waiting for the scan number to increment is a good one.  Raises all sorts of tricky questions like what if you get unplugged and miss all the packets from one or more scans.  Or what if the lidar gets unplugged and resets its scan number/timestamp.  And so on and so forth.  Hm...  Maybe it doesn't matter too much, since any scan that has all its packets should work fine anyway.

Got a test setup for this this evening.  For future reference, a good way to induce fun packet orders seems to be to connect to the lidar via a wifi link.
Seems like the original issue where after some time the entire data stream tends to become corrupt is fixed, but that there's still some weird things going on.  Specifically,

I seemed to be getting quite a lot of missing data
The rviz plot shows lots of spurious data points dancing around the outside; they seem to show up at one or two radius values, which makes me think they're bad data rather than
With the older version of the driver, rviz was able to do rainbow coloring based on intensity, but the new version seems to break that somehow?
Loads of messages in the console about Received data smaller than header size.

In addition into an issue with something in the build.  I'm not familiar enough with ROS to fix this properly (I assume it involves re-ordering CMakeLists.txt?) but when I did the upgrade, it was complaining about not being able to find PFR2000Header.h, which AFAICT is generated from the corresponding .msg file.  I manually invoked cd build && pf_driver_generate_messages and after that I was able to catkin_make successfully.
I'll see if I can do a little troubleshooting (and I'll try to take a tcpdump or something at least), but I'm likely going to need to turn in the lidar I'm borrowing for this sometime early next week, so I wanted to ping you about it now with the hope that you might have some time to look at it soon.

Submitted #24 to fix the issue I had with missing PFR2000Header.h.

I have fixes for several of the other protocol issues I've seen; will submit a PR for them sometime in the next day or so (have one more issue I want to track down first).

Just submitted #26 with fixes for most of the outstanding issues here.   I think the core issue (assigning points the wrong angles) has already been fixed, so I'm going to go ahead and close this issue, but definitely take a look at that PR.


Make can/util/fixture work with new Steal

This makes can/util/fixture work with the new Steal by replacing a call to the join Steal URI mapJoin with the new  steal.joinURIs.

@matthewp is this relevant for latest minor? If so can you fix and resubmit?

This is fixed in latest minor.


Improve input validation on windows_package

Make sure the correct installer_type symbol is passed and provide a useful error message when a bogus value is provided instead of just saying it needs to be a symbol and hoping a user eventually stumbles onto the docs
Add descriptions fields to all the properties and update them since the ones on the docs site right now aren't the best
Coerce the provided checksum value to lowercase. Right now if it's uppercase, but valid the resource will fail and the message provided is not useful. See https://github.com/chef/chef/issues/6682

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Ping @chef/docs-team for the descriptions. These end up on the docs site


README suggestion

I'm wondering why this project is needed instead of using the official vercel package. I gather from other sources that the official vercel package doesn't work, but it's not exactly clear to me why that is and if there's someplace we should track whether it might get fixed

There isn't an official vercel package for Sapper apps, they simply push you to export a static app, and use their static builder.
I've discussed with them ever since the launch of now v2 about either adopting this builder, creating a builder, or providing any sort of support for real Sapper apps on now, and they initially made some promising noises, but haven't expressed any interest since, so I can only assume that it's not something they are interested in doing.

I'd still like to know what exactly this builder does and how it works :-)  Does it create files matching their expected interface and put them in the api directory?  Does it do server-side route splitting?

@benmccann all it does is handle building a lambda using Vercel's tools, as long as you export the polka handler so that it can serve requests.
It then does some fancy stuff with static files, but underneath it's fairly simplistic in what it actually does.
It doesn't do route splitting. It should. We would love a PR ;)

I'm targeting Kubernetes, so probably won't send a PR for this one :smile:  I'm just trying to understand why this project is necessary to help review the documentation PR

It's pretty basic:
It runs the build command: https://github.com/thgh/now-sapper/blob/9fe8017f0c555d256a40225e352acbe75bf110f8/index.js#L37
Gathers all build files: https://github.com/thgh/now-sapper/blob/9fe8017f0c555d256a40225e352acbe75bf110f8/index.js#L51
Serves as much statically as possible: https://github.com/thgh/now-sapper/blob/9fe8017f0c555d256a40225e352acbe75bf110f8/index.js#L66-L72
And falls back to the server for everything else: https://github.com/thgh/now-sapper/blob/9fe8017f0c555d256a40225e352acbe75bf110f8/index.js#L73

Thanks! That's super helpful!
I'm somewhat surprised because there are several people saying that sapper doesn't work on lambda, but you've somehow not run into this problem!

Well, there were some issues with the port https://github.com/thgh/now-sapper/issues/8 which meant you couldn't use this.fetch for local urls but it's seems to work now. It should be doable to run sapper on lambda, replace @now/node-bridge by aws-serverless-express and it will probably work.


Uncaught TypeError: Cannot read property 'results' of undefined

[Enter steps to reproduce below:]
Used ctrl + l on several text snippets in a row, suddenly got error for one that refuses to convert. May be that there is a - in the text.
Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: markdown-helpers package, v0.3.0
Stack Trace
Uncaught TypeError: Cannot read property 'results' of undefined
At /Users/me/.atom/packages/markdown-helpers/lib/main.coffee:40

TypeError: Cannot read property 'results' of undefined
    at GoogleWebConvertor.handleResponse (/Users/me/.atom/packages/markdown-helpers/lib/main.coffee:40:39)
    at Request._callback (/Users/me/.atom/packages/markdown-helpers/lib/main.coffee:35:14)
    at Request.self.callback (/Users/me/.atom/packages/markdown-helpers/node_modules/request/request.js:121:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (/Users/me/.atom/packages/markdown-helpers/node_modules/request/request.js:985:14)
    at emitOne (events.js:82:20)
    at Request.emit (events.js:169:7)
    at IncomingMessage.<anonymous> (/Users/me/.atom/packages/markdown-helpers/node_modules/request/request.js:936:12)
    at emitNone (events.js:72:20)

Commands
     -1:01.7.0 core:move-down (atom-text-editor.editor.is-focused)
     -1:00.9.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
  2x -1:00.6.0 core:move-right (atom-text-editor.editor.is-focused)
  2x -0:59.7.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:55.2.0 markdown-helpers:convert-link (atom-text-editor.editor.is-focused)
     -0:48.4.0 core:save (atom-text-editor.editor.is-focused)
     -0:37.6.0 core:undo (atom-text-editor.editor.is-focused)
     -0:36.5.0 core:move-down (atom-text-editor.editor.is-focused)
  4x -0:36 core:move-right (atom-text-editor.editor.is-focused)
     -0:35.1.0 editor:select-to-first-character-of-line (atom-text-editor.editor.is-focused)
  2x -0:34.9.0 core:select-right (atom-text-editor.editor.is-focused)
     -0:33.4.0 markdown-helpers:convert-link (atom-text-editor.editor.is-focused)
     -0:31.8.0 core:move-down (atom-text-editor.editor.is-focused)
  2x -0:26.5.0 markdown-helpers:convert-link (atom-text-editor.editor.is-focused)
     -0:20.2.0 core:undo (atom-text-editor.editor.is-focused)
  4x -0:16.7.0 markdown-helpers:convert-link (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "whitespace",
      "spell-check",
      "metrics",
      "autosave",
      "autocomplete-snippets",
      "autocomplete-plus",
      "minimap",
      "color-picker"
    ],
    "openEmptyEditorOnStart": false,
    "audioBeep": false
  }
}

Installed Packages
# User
emmet, v2.3.16
emmet-snippets-compatibility, v1.0.1
ever-notedown, v0.2.16
markdown-helpers, v0.3.0
markdown-mindmap, v0.2.4
markdown-writer, v2.0.1
sync-settings, v0.6.0

# Dev
No dev packages

Also have the same issue. I guess this repo is not maintained anymore?


Make Date constructor conform to the latest spec

Based on #3829, it should be merged first.

@ossy-szeged Please rebase the PR after #3829.


simple_fields inside simple_fields ?

Is it possible to user the simple_fields method inside another simple_fields ?
I have a Brief model, qhich has a InvoiceQuoteElement, which has many Categories, which have many Expenses. Following the simple_fields tutorial, I came up with this :+1:
        <%= f.simple_fields_for :invoice_quote_element do |iqe| %>
        <input type="hidden" value="<%= @brief.invoice_quote_element.id %>" name="quote_id">

          <%= iqe.simple_fields_for :expense_categories do |category| %>

                    <%= category.input :title, label: false, class: 'text-right' %>

                    <%= link_to_remove_association('Delete Category', category,
                  { wrapper_class: 'category' }, class: 'btn btn-danger') %>

                  <%= category.simple_fields_for :expenses do |expense| %>

                        <%= expense.input :title, label: false %>
                        <%= expense.input :days, label: false %>

                        <%= expense.input :price, label: false %>

                          <%= link_to_remove_association('Delete Expense', expense,
                          { wrapper_class: 'expense' }, class: 'btn btn-danger') %>

                  <% end %>

                      <%= link_to_add_association 'New Expense', f, :expenses,
                      partial: 'briefs/expense_fields', class: 'add-expense-link btn btn-success' %>

          <% end %>

              <%= link_to_add_association 'New Category', iqe, :expense_categories,
          partial: 'briefs/expense_category_fields', class: 'add-category-link btn btn-success' %>

        <% end %>

But this raises me a undefined method `expense_categories' for nil:NilClass, which makes me wonder, is it even possible to make a cascade of simple_fields ?

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.


SYS.3.C: The Raspberry Pi 4 shall forward the data from the Arduino Nano BLE Sense (7) to the Data Server (1) via the Router (8)

After I am able to successfully send the audio data, I will work on integrating the router.

After I am able to successfully send the audio data, I will work on integrating the router.


feat(autoware_adapi_v1_msgs): add heartbeat

Description
Add heartbeat message.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

If this is related, could you add it to the PR description?

https://github.com/orgs/autowarefoundation/discussions/4561

https://github.com/autowarefoundation/autoware.core/blob/5ab56d1b560dfce85fb7d272e4ecb42022af32cc/common/autoware_control_center_msgs/msg/Heartbeat.msg#L1-L10
Maybe we could also add a similar uint16 sequence_number 0 for the listener to detect if a heartbeat was missed.
Related PR:

https://github.com/autowarefoundation/autoware.core/pull/73


Implement tab completion for tags.

Here's my initial attempt at implementing tab completion for tags (Issue #108).  It doesn't yet recognize trying to complete using "tags/" like described in the issue, but cycles through a combined list of branches and tags similar to how this is handled in the bash prompt implementation.

Modified my commit to use the simpler git tag rather than manually reading the refs.

Thank you!
For future reference, watchers won't get a notification on push to a PR, so you may want to bump a thread to which you've pushed a fix. :sparkles:


Losing the 65534th character

Hello,
I'm trying to get a csv file on a SFTP server but when i'm comparing it to the file downloaded with my ftp client manually, it seems that every 65534th character is losed...
The file is encoded in UTF8, i have tried every possibilities with that but always the same at the end.
I can't figure out if it's the writing stream or the data transfert that cause this issue.
Thanks!

This sounds like a similar issue I ran into when using the library with node v10.x. It was not a problem with node 8.x. Looking into it, the problem seemed to be with the underlying ssh2 library. I did log an issue, but have not revisited the problem for a while.

I had a very abrupt concatenation of csv data on upload that is not in the original file. This happens unpredictably from what I can tell. The data changes at character 262144 and has caused major pricing problems for us on upload.

@smulder It would really help if you also provided some specific details e.g. version of node, version of this package, which methods were being used to transfer the files, what platforms and OS etc. In order to fix, it is first necessary to reproduce the issue and without being able to narrow down versions, platforms etc, that is nearly impossible.
I suspect that if there is an issue, it is a problem with the underlying ssh2 module as this module is largely just a wrapper around the functionality in that module. See for example https://github.com/mscdex/ssh2/issues/739
It would be useful to know which methods were being used when data is lost or concatenated. For example, the fastPut and fastGet methods do multiple streams and I can imagine this could result in data corruption if the streams are not re-assembled in the right order. However, the slower get/put methods only use a single stream, so such problems are less likely.
Note that the issues I previously encountered where data transfer for larger files would hang or truncate the data when using node 10.x seems to have been resolved. I have been testing with much larger files this week (i.e. 6Mb+) without any issues using node 10.x. We have been using this module for 12 months to download large data sets and apart from the previously mentioned node 10.x issue, have not encountered any data corruption issues.

I am having data "Rearranging" for both the put and fastPut methods. I will work to get more information right away

I am using Node Version 9.11.1
latest version of this package 2.4.3
OSX 10.12.3
I am uploading to the eBay MIP FTP server: mip.ebay.com
I have verified that uploading the identical file via forklift FTP works fine and the integrity is still there
I would be happy to send a file directly to you, but would rather not post it publicly.
What other information would you be interested in?

If it helps anyone, I am optimistically reserved that using fastPut with the options setting as {concurrency:1} the mangled / rearranged file data is not there... I will monitor and post back if it resurfaces. Is this something that helps resolve things on your end?
Thanks, Scott

@smulder Yes, that information is useful. The initial aim is to try and reproduce this issue - for all we know, it may be some incompatibility with the remote server you are using, so being able to narrow down things is important. If I can find the time, I might see if I can reproduce the issue and if I can, then see if it can be reproduced just with ssh2 and eliminate ssh2-sftp-client. This is going to take some time though.

Let me know what I can do to help!

I'm seeing the same issue currently - it's only happening with a specific server (I have no access to that servers configuration) I've downloaded the same file from different server using exact same code/client and the file downloads correctly.

I do suspect it is a server specific issue. From issues logged against ssh2 and ssh2-streams, it seems that some servers fail to honour the chunk size and/or highWaterMark requests AND ssh2 does not adjust to whatever size the server does use.  As a result, you end up with a mismatch between what the server understands the packet sizes are and what the client thinks.
There are people far more talented than me looking at this in the ssh2/ssh2-streams community - the big problem they are having is being able to reliably reproduce the problem. If you cannot reliably reproduce the issue, you cannot verify the fix. What is needed is access to a server where this can be reliably reproduced - so far, it seems all reported instances are either on servers which are not open to testing or servers where the issue is only intermittent. My guess is that ssh2/ssh2-streams will need to become more 'liberal' in what it will accept i.e. allow user to request chunk size and/or highWaterMark, but actually use whatever the server does.

I can definitely reproduce this issue every time but I can't share the server... If it helps here is the server version: SSH-2.0-CerberusFTPServer_10.0

I have added some checksum tests to my fork at https://github.com/theophilusx/ssh2-sftp-client. It would be interesting to see what results anyone seeing data corruption get if they try and run the tests against the server they are using.
To do this, just create a .env file in the root directory with the following properties
SFTP_SERVER=<sftp host>
SFTP_USER=<username>
SFTP_PASSWORD=<password>
SFTP_URL=<path to dir where we can read/write files/dirs>

Then just execute
npm test

or
npm test test/checksum-tests.js

to run just the checksum tests.
So far, I've tried 2 different sftp servers, both have passed with no failures.

My concern here is that I can use FileZilla to download this file just fine so their code somehow handles this weird server config just fine.  Because of that I can't complain to server owner about this issue.

@wmagda I don't think anyone would deny that filezilla is a more mature bit of software which undoubtedly includes a number of checks and workarounds for various sftp server quirks. That software has been around for longer than nodejs has existed and has a lot more contributors and developers both testing and working on it.
Note also that I'm not suggesting that this issue can or should only be fixed at the server issue. The problem is, in order to fix it, we have to reliably reproduce it in an environment where which can be used for testing. I personally have not been able to find such an environment. I don't think complaining to server administrators will achieve anything. A more constructive approach may be to ask the server administrators if they would be willing to provide an account for testing (or access to a testing server with the same configuration). This would then allow the ssh2 developers access to an environment where they can test and debug the problem and hopefully find a solution.

Are you using an encoding option? Have you tried setting encoding to null in the .get() invocation?

In the end I found a "workaround"? (or is it a fix?)
https://github.com/jyu213/ssh2-sftp-client/issues/37
That  { highWaterMark: 65535 } fixes the issue for me and I don't see any side effects so far.

I would say it is a workaround.
This adds further weight to my suspicion the problem is related to the underlying SSH2 module issue I referenced earlier. Basically, client and server are not correctly negotiating the same values. Seems some servers don't indicate when they are going to ignore requested values, so things get out of sync.
Would probably be best to only apply this to server connections where you know it is an issue and watch out for updates which include updates to the underlying SSH2 module as I expect this will be addressed once someone works out the best approach.
Gald you at least have a workaround.

I cannot reproduce this issue. Have tried against a number of different servers. Have added tests which perform checksums for both upload and download of data. As there have been a number of changes since the original issue, together with the known issues logged against the ssh2 and ssh-streeams libraries. I think this issue can be closed.  If others experience similar problems, we can open a new issue (or reopen this one).


build-conventions caching

Hi!
Just tried out Gradle 8.6 with gradle/actions/setup-gradle@v3 and it seems like a build-conventions (https://docs.gradle.org/current/samples/sample_sharing_convention_plugins_with_build_logic.html) related task input change is preventing my configuration-cache from being reused.
They do seem to cache fine on local builds.
Calculating task graph as configuration cache cannot be reused because
an input to task ':build-conventions:generatePluginAdapters' has changed.

Sample job that I run:
- name: Run ktlint
  uses: gradle/actions/setup-gradle@v3
  with:
    gradle-home-cache-cleanup: true
    cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
    arguments: ktlintCheck

Is there any chance this might be related to gradle-home-cache-cleanup https://github.com/gradle/gradle-build-action/issues/1037 ?
If not, is there anything else that we should cache?
I suppose build conventions falls under this category:

caches/<version>/kotlin-dsl and caches/<version>/scripts: These are the compiled build scripts. The Kotlin ones in particular can benefit from caching.

Thanks for the report. The configuration-cache hasn't been designed to be reused on different machines, but with gradle-build-action and the Gradle User Home fully restored we've found that it often works. Unfortunately you seem to have found a case where it doesn't.
The error message indicates that GRADLE_ENCRYPTION_KEY is being set correctly and the configuration-cache is being properly restored. But something in the project state isn't as expected after restore, invalidating the cache entry.
I suspect that this is due to the following process:

When your project is configured, you have an included build build-conventions that must be built in order to provide some build logic.
This results in the inputs to task :build-convention:generatePluginAdapters being marked as configuration-cache inputs.

The generatePluginAdapters task likely has some inputs that are actually the outputs of other build-conventions tasks, and are located in the build-conventions/build directory.

When your workflow runs, the gradle-build-action will restore the Gradle User Home together with the configuration-cache entry. But it will not restore the build-conventions/build directory. This results in the "configuration cache cannot be reused" message you see.

You could validate this locally by:

Run the build locally, storing the configuration-cache entry
Clean the local build, including any included-builds. This might require manual deletion of the build directories.
Run the build again and see if the configuration-cache can be reused.

Thank you for clarifying this @bigdaz.
I did play with cleaning up parts of the project in order to further investigate this.
Perhaps there's a smarter way to do it but I did try removing directories one by one.
Removing build-conventions/build results in:
Calculating task graph as configuration cache cannot be reused because
an input to plugin 'org.gradle.groovy-gradle-plugin' has changed.

Just build-conventions/build/pluginDescriptors:
Calculating task graph as configuration cache cannot be reused because
an input to task ':build-conventions:processResources' has changed.

build-conventions/build/resources:
Calculating task graph as configuration cache cannot be reused because
an input to task ':build-conventions:jar' has changed.

build-conventions/build/classes:
Calculating task graph as configuration cache cannot be reused because
an input to task ':build-conventions:compileGroovyPlugins' has changed.

And finally build-conventions/build/groovy-dsl-plugins/output/plugin-requests gives me the message that I'm seeing on CI:
Calculating task graph as configuration cache cannot be reused because
an input to task ':build-conventions:generatePluginAdapters' has changed.

Is this something could perhaps be cached on the side? Not sure if setup-gradle action takes care of local build files other than those located in Gradle home dir?

The setup-gradle task doesn't (currently) take care of any of this, so you'll need to configure this yourself. The simplest way is probably using actions/cache to save/restore the build-conventions/build directory.
If you get this working, please share the configuration for others.

Didn't get this to fully work yet, but thought it might be worth sharing what I've tried already.
- name: Cache build logic
  uses: actions/cache@v4
  with:
    path: build-conventions/build/groovy-dsl-plugins/output/plugin-requests
    key: build-logic-${{ hashFiles('build-conventions/**/*.gradle', 'gradle/libs.versions.toml') }}

Results in:
Calculating task graph as configuration cache cannot be reused because an input to task ':build-conventions:compileJava' has changed.

Changing path to build-conventions/build/ either successfully reuses the configuration or fails with:
Calculating task graph as configuration cache cannot be reused because an input to plugin 'org.gradle.groovy-gradle-plugin' has changed.

I have also encountered an error right now when trying to run a build, but I suppose this could be a separate issue?
* What went wrong:
Could not load the value of field `parameters` of `org.gradle.api.internal.provider.DefaultValueSourceProviderFactory$DefaultObtainedValue` bean found in field `obtainedValue` of `org.gradle.configurationcache.fingerprint.ConfigurationCacheFingerprint$ValueSource` bean found in Gradle runtime.
> com.android.build.gradle.internal.services.AndroidLocationsBuildService$AndroidDirectoryCreator$Params

The best way to solve this is likely to experiment locally. Something like:
./gradlew help
rm -rf build-conventions/build
./gradlew help

The second build should reproduce the configuration cache issue you're seeing on CI. You can then experiment to see exactly what needs to be restored. I suspect the entire build-conventions/build directory will be required.
Also, the cache key should probably include all source files under build-conventions. Any change to these sources could change the outputs in build, and these are required to reuse the configuration cache.

Another option to solve this would be to add a separate ./gradlew :build-conventions:assemble --no-configuration-cache step prior to your main build step. This should ensure that all included build logic is available when reusing the configuration cache.


Attributes with hyphen are dropped with OutputSettings.Syntax.xml in 1.18.2

Hello!
We tried to upgrade our application today to 1.18.2. But many tests fail. Looks like hyphens are not working anymore.
To reproduce:
import org.jsoup.Jsoup;
import org.jsoup.nodes.Document;
import org.jsoup.nodes.Element;

public class JsoupTest {
    public static void main(String[] args) {
        Document doc = Jsoup.parseBodyFragment("
Hello world!
")
                .outputSettings(new Document.OutputSettings().syntax(Document.OutputSettings.Syntax.xml));
        Element a = doc.selectFirst("a");
        a.attr("target", "_blank");
        a.attr("data-first-test", "1");
        a.dataset().put("second-test", "2");
        System.out.println(doc.body().html());

        // 1.18.1 =>
Hello world!

        // 1.18.2 =>
Hello world!

    }
}

Hi!
Arg, sorry about that. Looks like the cause is 27e7d5f03d85bea15fbfe5432c37c6de94965a82. I missed including the allowed - when converting this regex: "[a-zA-Z_:][-a-zA-Z0-9_:.]*"

Fixed - had also missed digits and .. Also improved the coverage, I thought we had included better coverage initially.
Will keep this issue open for visibility until released in 1.18.3.

(Closing now that 1.18.3 is released.)

I can confirm it works in 1.18.3. Thanks for the fix and a great html lib. :)


welcome card: update style, copy, and behavior

This brings the welcome card up to date with the copy and styling in Figma. Adapts it to be shown on desktop views as well, positioned above the activity feed on the home screen.
Closed status is no longer stored locally on the frontend, instead its tracked in the settings agent. This means closing the card once will hide it on all clients.

Fixes LAND-1399

Added that affordance for any curious clickers :~)


Auto build doesn't include packs.

Expected
When building, the output jar contains the config packs
Actual
When building for the first time, the output jar does not contain the config packs.
Steps to reproduce

clone repo
run shadowJar task
open output jar in luyten
there are no config packs.

Current workaround is to run ./gradlew shadowJar twice, aka ./gradlew shadowJar && ./gradlew shadowJar on the first build.


Need to be printed once:  Please note that your wallet will only listen to one address at a time.

User don't want ot see the same dialog  when "Next Address" pressed.

Changes are trivial, no need to test


feat: add user impersonation to all commands

What this PR does / why we need it:
Fixes # https://github.com/kudobuilder/kuttl/issues/547
Working configuration after adding the --as flag for user impersonation.
./bin/kubectl-kuttl test --config ... --as admin
=== RUN   kuttl
    harness.go:464: starting setup
    harness.go:255: running tests using configured kubeconfig.
    harness.go:278: Successful connection to cluster at:...
    harness.go:363: running tests
    harness.go:75: going to run test suite with timeout of 30 seconds for each step
    harness.go:375: testsuite: ...
=== RUN   kuttl/harness
=== RUN   kuttl/harness/00-check-deploy
=== PAUSE kuttl/harness/00-check-deploy
=== CONT  kuttl/harness/00-check-deploy
    logger.go:42: 19:45:28 | 00-check-deploy | Creating namespace: kuttl-test-engaged-cockatoo
    logger.go:42: 19:45:28 | 00-check-deploy/0- | starting test step 0-
    logger.go:42: 19:45:29 | 00-check-deploy/0- | test step completed 0-
    logger.go:42: 19:45:29 | 00-check-deploy | skipping kubernetes event logging
    logger.go:42: 19:45:29 | 00-check-deploy | Deleting namespace: kuttl-test-engaged-cockatoo
=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- PASS: kuttl (7.71s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/00-check-deploy (7.16s)
PASS

Without having user impersonation
❯ ./bin/kubectl-kuttl test --config ...
=== RUN   kuttl
    harness.go:464: starting setup
    harness.go:255: running tests using configured kubeconfig.
    harness.go:278: Successful connection to cluster at:...
    harness.go:363: running tests
    harness.go:75: going to run test suite with timeout of 30 seconds for each step
    harness.go:375: testsuite:...
=== RUN   kuttl/harness
=== RUN   kuttl/harness/00-check-deploy
=== PAUSE kuttl/harness/00-check-deploy
=== CONT  kuttl/harness/00-check-deploy
    logger.go:42: 19:47:44 | 00-check-deploy | Creating namespace: kuttl-test-awaited-dingo
    case.go:357: namespaces is forbidden: User "" cannot create resource "namespaces" in API group "" at the cluster scope
    logger.go:42: 19:47:44 | 00-check-deploy | Deleting namespace: kuttl-test-awaited-dingo
    case.go:117: namespaces "kuttl-test-awaited-dingo" is forbidden: User "" cannot delete resource "namespaces" in API group "" in the namespace "kuttl-test-awaited-dingo"
=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- FAIL: kuttl (0.84s)
    --- FAIL: kuttl/harness (0.00s)
        --- FAIL: kuttl/harness/00-check-deploy (0.31s)
FAIL

Ah, 💩
I applied my nitpicks to save some back-and-forth and forgot that this will break the DCO check 🤦🏻
And now I cannot fix it easily because I cannot push to your fork. Please help! 😅

@porridge I will apply these and sign them

@porridge all of your comments have been added to the latest commit 🤝


Paste using Windows Clipboard doesn't work if ctrl+v unbound

If I try to use Windows Clipboard manager to paste text into Windows Terminal 1.7.1033.0 I can't do it if I { "command": "unbound", "keys": "ctrl+v" }
I need to unbound crtl+v because I need ctrl+v in some shell programs. Paste works fine with crtl-shift-v, but not with Windows Clipboard manager, which then inserts inserts a literal ctrl-v instead of pasting text.
This is a problem for all people that prefer and/or need to used ctrl-shift-v instead of ctrl-v to paste text, and then can't use clipboard manager to keep a cut+paste history.

What would you like us to do about it? If your clipboard software can’t be reconfigured to use something other than Ctrl+V, and you need Ctrl+V to work in your connected client application... you may need new clipboard software.
We have been discussing the options with the Windows clipboard team, and they don’t seem to have any ideas.

Oh it actually sends WM_KEYDOWN messages for Ctrl+V 😮 If I turn off "Enable Ctrl key shortcuts" in conhost of Windows 10 version 20H2 (OS Build 19042.928), then Windows+V cannot paste to that either.
Doesn't UWP support anything equivalent to WM_PASTE, which would indicate the intent regardless of key bindings?

We're actually tracking this discussion over in #322. It started as a discussion about "ditto", but expanded to a discussion of the Windows 10 "Cloud Clipboard" as well.
/dup #322


Internal server error in galaxy using over 30 samples in SNVPhyl pipeline

Hello,
I am attempting to run a data set of over 100 paired-end WGS samples.
I have successfully installed the DOCKER container and ran the example-data provided on Github. I have also been successful in running a smaller subset of my data (10 paired-end samples in total).
I have come across an internal server error when attempting to run my full data set. After 30 samples the connection fails during the fastq upload to galaxy. Below are the details of my failed run:
Command: python ./Software/snvphyl-galaxy-cli/bin/snvphyl.py --deploy-docker --copy-fastq-files-to-docker --fastq-dir ./Sequences/ONT_2019 --reference-file ./Sequences/Reference_Fasta/Ngo_FA1090.fasta --min-coverage 2 --output-dir rawReads_ONT2019
Standard Output with Error at bottom:
Deploying Docker Container
/==========================
Running 'docker run --detach --publish 48888:80 phacnml/snvphyl-galaxy-1.0.1:1.0.1b'
Docker id 01dc62e7bc8c69d8a3d14bdc47713a9c7802915d216ba8e3b83fb52ef7da2f66
Waiting for docker to complete launching Galaxy on port 48888 .....finished.  Galaxy in Docker has (hopefully) started successfully.
Took 0.26 minutes to deploy docker
Examining input fastq files
/===========================
Structuring data in directory './Sequences/ONT_2019' like:
19-NG0027: paired {forward: ./Sequences/ONT_2019/19-NG0027_R1.fastq.gz, reverse: ./Sequences/ONT_2019/19-NG0027_R2.fastq.gz}
...
19-NG0160: paired {forward: /NetDrive/Users/rtullio/NIH_Grant/PilotA/Sequences/ONT_2019/19-NG0160_R1.fastq.gz, reverse: /NetDrive/Users/rtullio/NIH_Grant/PilotA/Sequences/ONT_2019/19-NG0160_R2.fastq.gz}
Set up workflow input
/=====================
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/consolidate_vcfs/consolidate_vcfs/1.8.0, snv_abundance_ratio, 0.75}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/consolidate_vcfs/consolidate_vcfs/1.8.0, coverage, 2}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/verify_map/verify_map/1.8.0, mindepth, 2}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/consolidate_vcfs/consolidate_vcfs/1.8.0, mean_mapping, 30}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/find_repeats/findrepeat/1.8.0, length, 150}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/find_repeats/findrepeat/1.8.0, pid, 90}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/consolidate_vcfs/consolidate_vcfs/1.8.0, use_density_filter.threshold, 2}
setting parameter {irida.corefacility.ca/galaxy-shed/repos/nml/consolidate_vcfs/consolidate_vcfs/1.8.0, use_density_filter.window_size, 500}
Upload files to Galaxy
/======================
Creating history in Galaxy name 'snvphyl-Ngo_FA1090-2020-12-22-run'
Uploading reference file /NetDrive/Users/rtullio/NIH_Grant/PilotA/Sequences/Reference_Fasta/Ngo_FA1090.fasta
Uploading fastq files in history 'snvphyl-Ngo_FA1090-2020-12-22-run'
Uploading as copy ./Sequences/ONT_2019/19-NG0027_R1.fastq.gz
...
Uploading as copy ./Sequences/ONT_2019/19-NG0058_R2.fastq.gz
Undeploying and cleaning up Docker Container
/=============================================
Running 'docker rm -f -v 01dc62e7bc8c69d8a3d14bdc47713a9c7802915d216ba8e3b83fb52ef7da2f66'
01dc62e7bc8c69d8a3d14bdc47713a9c7802915d216ba8e3b83fb52ef7da2f66
Traceback (most recent call last):
File "./Software/snvphyl-galaxy-cli/bin/snvphyl.py", line 1302, in
main(snvphyl_version_settings, **dic)
File "./Software/snvphyl-galaxy-cli/bin/snvphyl.py", line 974, in main
repeat_minimum_length, repeat_minimum_pid, filter_density_window, filter_density_threshold, invalid_positions_file, output_dir)
File "./Software/snvphyl-galaxy-cli/bin/snvphyl.py", line 1084, in main_galaxy
fastq_id=upload_fastq_collection_paired(gi,history_id,fastq_paired)
File "./Software/snvphyl-galaxy-cli/bin/snvphyl.py", line 576, in upload_fastq_collection_paired
paired_elements=upload_fastq_history_paired(gi,history_id,fastq_paired)
File "./Software/snvphyl-galaxy-cli/bin/snvphyl.py", line 545, in upload_fastq_history_paired
reverse_galaxy=gi.tools.upload_file(reverse,history_id, file_type='fastqsanger')
File "./Software/miniconda3/envs/PilotA/lib/python3.6/site-packages/bioblend/galaxy/tools/init.py", line 214, in upload_file
return self._post(payload, files_attached=True)
File "./Software/miniconda3/envs/PilotA/lib/python3.6/site-packages/bioblend/galaxy/client.py", line 173, in _post
files_attached=files_attached)
File "./Software/miniconda3/envs/PilotA/lib/python3.6/site-packages/bioblend/galaxyclient.py", line 132, in make_post_request
body=r.text, status_code=r.status_code)
bioblend.ConnectionError: Unexpected HTTP status code: 500:
As it fails at the point of uploading 30 paired-end samples to galaxy, I also attempted the same command above but using a limited number of my total data set (the 30 paired-end samples- the amount it originally failed at) it still fails however I receive a more detailed error (see below).
Error:
bioblend.ConnectionError: Unexpected HTTP status code: 500:
Internal Server Error
Internal Server Error
Galaxy was unable to successfully complete your request
An error occurred.
This may be an intermittent problem due to load or other unpredictable factors, reloading the page may address the problem.
The error has been logged to our team.
I am reaching out to see if there is a limitation to the total number of samples I can use in the SNVPhyl pipeline and if there are any recommendations to my problem.
Thank you in advance for your help.
Have a great day!

Thanks for the issue report.
I'm not exactly sure of the cause of the issue, but a few things I can think of:

Since you are uploading copies of the fastq files into Docker, you will need a lot more space on your hard drive. Is it possible you are running out of space and this is causing the error? You could try getting rid of --copy-fastq-files-to-docker so that it doesn't create complete copies of the fastq files in Docker (but this requires the original files to have the correct permissions, the easiest being world-readable so they are visible within Docker).
There could be a timeout issue in Galaxy when uploading so many files. But it's hard to debug such an issue without looking at the Galaxy log files. To monitor the Galaxy logs, when you see the message Docker id 01dc62e7bc8c69d8a3d14bdc47713a9c7802915d216ba8e3b83fb52ef7da2f66 you can run the command docker logs -f 01dc... in a separate terminal and this will print out all the information recorded by Galaxy, which can help out with further diagnosis.

Thanks @apetkau for the quick response!
I will look into your suggestions and reach out again with hopefully an update of the solution.


Define ON/OFF in fan feature list

This PR in hass-core (https://github.com/home-assistant/core/pull/121447) stipulates that fan entities need to set ON/OFF feature flag if on/off operation is supported (milestone 2024.8.0b0). This PR just adds those two feature values and would address https://github.com/ollo69/ha-smartthinq-sensors/issues/783.
Closes #783

@ollo69 Please review

We must change minimum required HA version to apply this CR.

We must change minimum required HA version to apply this CR.

I think you are referring to the version in hacs.json ? Should the version in requirements.txt also be updated? It currently doesn't match hacs.json

I think you are referring to the version in hacs.json ?

Everything should match the minimum required version for this change:

requirements.txt (homeassistant version to use)
requirements_test.txt (pytest-homeassistant-custom-component version)
hacs.json
const.py

Should the version in requirements.txt also be updated? It currently doesn't match hacs.json

requirements.txt contains the exact version to use with dev-container, hacs.json the minimum ha version allowed for installation. They don't match just for minor version.
Best way to make PR is using proper dev tools:

install docker desktop and VSCode
open the dev-container using VSCode
work on the code
run in dev-env to test changes

Thanks 👍


Don't validate on change

Validating the entire form on every change was making the form very laggy. Now it will validate on blur and form submission, and the form is responsive again.

 Finish new case manual entry page


Feature Request : get candles data

Hello
The data scraped is really useful, but creating candles from it (or even with exchange websockets) are not reliable... A really nice improvement, for me, could be to get candles (or the last closing candle for a specific timeframe).
Thanks anyway

Are we able now to get candles data?

@ProgrammingLife it is still not possible, but you're welcome to work on this feature and submit a PR. Currently I'm focused on polishing the new version of tradingview-scraper, which is currently available on next branch.

It may well be possible, this pyton script also using websocket seems to do it.
rushic24/tradingview-scraper

If anyone still looking for that, I created an npm package to  fetch candles from Tradingview endenwer/tradingview-ws.


GH-2: Update linting and add initial CI configs

@klown I updated the linting to use fluid-lint-all and added some CI configs to run linting and tests in CI. However, I wasn't able to get the tests to run locally, so CI will likely fail on the tests as well. They fail with the error: "createdb: error: could not connect to database template1: FATAL:  role "admin" does not exist" from ./src/database/scripts/startDockerPostgres.sh
Regarding linting, if you merge this PR I had to fix up some comments and JSDoc. Please review these as I only fixed the errors but didn't make any other changes to the contents, which may need to be updated.
Regarding dependencies, I removed what appeared to be unused dependencies from package.json and updated the others, with the exception of Infusion.

Thanks for this, @jobara.  Regarding the FATAL: role "admin" does not exist ... error, @cindyli also noted that, which is shame since none of the 259 tests actually ran.  I have a fix, but I'm not going to push it just yet because I think I may have found a related issue where a docker container of the same name is present but stopped.  docker run complains of a duplicate name and eventually quits.  I'm thinking of just restarting the container.

@jobara I've updated my pull request with a number of changes.  If it's possible, could you just include the changes for just the new linting regime, that would be great.

@klown do you want just the new linting infrastructure without the lint fixes?

@klown do you want just the new linting infrastructure without the lint fixes?

Yes, please.  I'm assuming that's less work for you, right?

@klown yes, it should be less work for me. I'll see if I can get to it today.

@klown I rebased from your branch. Other than for the package.json file, if there were conflicts, I just accepted your changes. This means that files that didn't have conflicts will still have their linting updates. Let me know if this work.

I got these warnings from npm install.  Are these something to worry about?  Especially the "You must install peer dependencies yourself".  If so, where are the peer dependencies installed from?
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.

There are a number of errors for .DS_Store.  I suspect the .gitignore needs an update.

There are a number of errors for .DS_Store. I suspect the .gitignore needs an update.

You should probably add .DS_Store to your global .gitignore file. After that, you can go through and just delete those files from within this repo's directory structure.

I got these warnings from npm install. Are these something to worry about? Especially the "You must install peer dependencies yourself". If so, where are the peer dependencies installed from?
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^9.0.0 || ^10.0.0 but none is installed. You must install peer dependencies yourself.

Unless you're getting errors running the linting, I wouldn't worry about it.

There are a number of errors for .DS_Store. I suspect the .gitignore needs an update.

You should probably add .DS_Store to your global .gitignore file. After that, you can go through and just delete those files from within this repo's directory structure.

It turns out that .DS_Store was in the project root's .gitignore already.  In addition, there are no .DS_Store files in the github repository; they are only on my local hard drive.  So, I'm baffled.

It turns out that .DS_Store was in the project root's .gitignore already. In addition, there are no .DS_Store files in the github repository; they are only on my local hard drive. So, I'm baffled.

macOS will generate those files. If you created the repo on your machine they'll be there, so you can just go through and manually delete them.

Thanks for the help, @jobara.  It made my life easier.


Update to alpha.32

[x] change ion-search-bar to ion-searchbar
[x] update webpack.config.js
[x] remove ion-pane from modal
[x] update segment to use ng-model instead of a form which will fix the app on iOS 8.x but not the underlying problem: #49
[x] update the item-sliding
[x] hack segment so the button in the toolbar is clickable

Needs some Sass updates.


How to render webdriver events in iframe?

I want to mimic the following functionality in real time using watir-webdriver, I want to attach watir-webdriver events to my existing tab, I analyzed about watir-classic but it's only for windows machines I am using ubuntu 14.04, firefox
Is it possible to render webdriver events in already opened window?
Ref: http://3.bp.blogspot.com/-VhPbMbIjfME/VOte4du-sBI/AAAAAAAADIU/gE6xZERTFnU/s1600/Inbox3.gif

No, a webdriver implementation can only send commands to a browser that it has opened.


📄 Add report details route

Add the report details page.

Your Render PR Server URL is https://voicedeck-pr-27.onrender.com.
Follow its progress at https://dashboard.render.com/web/srv-cn2np3acn0vc73fik84g.

This live preview URL is throwing an error and I wonder if its because the CMS env variable is wrongly configured. @baumstern please check and let me know!


Update to support blazor preview 7

Hello Piotr,
Thank you for creating this blazor package!  Very helpful.
I've recently updated a project using the package to asp.net core preview 7 which has some breaking changes.  I've updated this package to work with preview 7.
Hope you find it helpful!

Zac

Zac,
Thanks a lot!
🚢

pushed Nuget update, thanks!


The https://mran.microsoft.com/documents/what-is-r link is broken in this page.

The https://mran.microsoft.com/documents/what-is-r link is broken in this page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a4253d0e-7a9f-a0a7-edee-4cbd387ec98d
Version Independent ID: 14a7818e-43ac-86ca-a4a1-d4da38441e42
Content: Use R in Power Query Editor - Power BI
Content Source: powerbi-docs/connect-data/desktop-r-in-query-editor.md
Service: powerbi
Sub-service: powerbi-ai
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for reporting this -- that resource is no longer available, so I've removed the link. Thanks!


Efficient dataframe.convert_string support for read_parquet

Use pyarrow strings in dd.read_parquet with pyarrow engine and dataframe.convert_string config option set to True.

Part of https://github.com/dask/dask/issues/9946.

[x] Closes https://github.com/dask/dask/issues/9978
[x] Tests added / passed
[x] Passes pre-commit run --all-files

@rjzamora I made changes according to your review feedback, please take another look.

@rjzamora I made changes according to your suggestions, see if that works.


Convert to NCNN

How to convert the model to ncnn? If there is no WARP layer in ncnn, then how can it be converted with a dimension of not 3 channels? in the inference function, the flow dimension has 2 channels instead of the required three to replace, as they do here - https://github.com/TNTwise/REAL-Video-Enhancer/wiki/Convert-Rife-Models

You can refer to ncnn Implementation of IFRNet. It may be helpful.

@ltkong218 I have seen this solution, but it does not describe the conversion process, but only gives the already converted models :(


I should be able to import an encrypted seed (recovery process hangs at 'Importing wallet' screen)

Have build a fresh BTC-LND and LTC-LND setup and successfully created new wallets with ZAP for both chains; now adding a 3rd wallet with using the recovery seed from a older (BTC only) setup/installation (thus different node LNDdb and bitcoindDB)...
while doing so, the wallet hangs on the msg "Importing wallet..."
when I use the cancel/return function...
I suddenly am seeing 2 extra lines in my ZAPwallet:
Under "Your Wallets" I see the imported (but failed) seed shows twice named
and the 2 wallets which I had initially setup moved down to "more"...
When selecting the added CoDaInLND entry, then I am asked for the password... which is not accepted (I am sure that I am entering it correctly ;-)
I am wondering if what I attempt can be done... importing a wallet by seed from a different installation; i hope so, as I assume it is loaded/retrieved from mainnet and not local ;-)
Using the existing wallets (BTC-LND and LTC-LND) still works.
Environment:

Zap version: 0.4.1
Operating System and version: WindowsServer2016

Further to above: I have completely removed the ZAPwallet and did afresh install, then directly into recover wallet with seed... the msg "importing wallet" is still showing now ;-) but no further progress.
As mentioned: this is now not linked to a private LND chain.
My simple mind says: if a seed can not be used to recover.... then what is the purpose ? ;-)

Became tired of looking at the "importing wallet" spinning wheel  and thus cancelled that with X ;-)
Now have the same outcome: two entries CoDaInLND (and obvisouly not the other 2 "more" wallets as those have not been added in the clean install.

@P0u1us

when I use the cancel/return function... I suddenly am seeing 2 extra lines in my ZAPwallet:

If you are seeing 2 entries after a single failed wallet import attempt, that sounds like a bug. There should only be one wallet created.

Under "Your Wallets" I see the imported (but failed) seed shows twice named and the 2 wallets which I had initially setup moved down to "more"...

The sidebar separates your wallets into 2 groups. Internal wallets (which show at the top under Your wallets), and External wallets (which show under the More heading). See https://github.com/LN-Zap/zap-desktop/issues/1969#issuecomment-485251527 for some details about the differences.

When selecting the added CoDaInLND entry, then I am asked for the password... which is not accepted (I am sure that I am entering it correctly ;-)

You should be using the password that you entered during the Recover wizard.

I am wondering if what I attempt can be done... importing a wallet by seed from a different installation. i hope so, as I assume it is loaded/retrieved from mainnet and not local ;-)

Yes, all data re on-chain funds is loaded from the blockchain, by lnd, during the import process. If the wallet was created on a different lnd instance, then you should be able to import it into Zap. Can you confirm it was created with lnd? If so, what version of lnd?

Further to above: I have completely removed the ZAPwallet and did afresh install, then directly into recover wallet with seed... the msg "importing wallet" is still showing now ;-)

Can you provide a screenshot please?

As mentioned: this is now not linked to a private LND chain.

I'm unsure what you mean by this. Can you clarify please?

Became tired of looking at the "importing wallet" spinning wheel and thus cancelled that with X ;-)
Now have the same outcome: two entries CoDaInLND (and obvisouly not the other 2 "more" wallets as those have not been added in the clean install.

Definitely sounds like a bug, though I tried to reproduce and it didn't happen for me (duplicate wallet entries).

And when selecting the wallet it asks for a password, after which is shows the msg "wallet not found"

It sounds like it may be failing to start lnd properly, and thus it's not actually creating the wallet. Can you run with debugging enabled please, and see of there is some clues in the log output about what it's doing whilst the UI is hanging?
DEBUG=zap* DEBUG_LEVEL=debug /Applications/Zap.app/Contents/MacOS/Zap

(adjust as needed for Windows)
Also, Please can you confirm:

Was the seed you are trying to import created with lnd?
If so, what version of lnd?
Can you provide a screenshot that shows where it's stuck?
Do you have any other instances of lnd running on your machine?

@P0u1us please can you confirm for me - with regards to the seed that you are trying to import, how and where was this seed created? Did you set up a passphrase on the seed when you created it?

Hi, in reverse order of Qs:
Yes, I have set a passphrase pswd, as well as a normal password, using the same pswd.
In the clean install the password was accepted, then kept hanging with "importing wallet".
I have build 2 environments: 1st a BTC+LND installation and created the seed (which I am trying to import), and now a 2nd system with both BTC-+LND and LTC+LND (latest git build versions).
Will have to put in some more effort with debugging; will do that tomorrow, now its easter ;-)

Ok, great. Then that confirms the issue...

Yes, I have set a passphrase pswd, as well as a normal password.

The password and passphrase are two different things.
password: used to lock/unlock the wallet.
passphrase: used to encrypt the seed
Since your seed has been encrypted with a passphrase it can not be imported into Zap as we don't currently support this, but will look to add that support.
In the meantime, you should import your seed directly into a standalone lnd instance.

Uhh...? is there mayby a standalone utility to decrypt it?

Possibly, though I'm not aware of one;. Let me know if you find something.

Hmmm.. peculiar!
It is LND (lncli) that requests the option for seed encryption, but it does not offer the possibility to decrypt or remove it; that would be the place I have expected it to be?
That means by definition for anyone using to encrypt their seed: it can never be recovered!!!
Suggestion to you: put a warning around this in the docs.
Thus: I will report this as a bug with the LND team?

@P0u1us you can recover the seed directly into lnd. You just use lncli create and provide the seed and passphrase when prompted. This will create a new wallet in lnd using your seed.
We don't yet provide a wrapper for this functionality as part of the restore process in Zap but this will be added in a future release.

Ok, thanx for the advise: I am pursuing this further, think you have done what you could ;-)

Q: there still is the remaining issue of recovering from a seed and then 2 wallets being created;
should this go to a new issue listing and do you need more info on that?
a screenshot of that is in the beginning of this trail.

Both issues are related and have been fixed in https://github.com/LN-Zap/zap-desktop/pull/2088.
We will close this issue out once that PR has been merged.

Closed via https://github.com/LN-Zap/zap-desktop/pull/2101


Fix typos in tutorial 4-2

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

Fix typos in tutorial 4-2.

@EEP-Benny Ah, good catch! I also have fixed another one in https://github.com/withastro/docs/pull/3732/commits/9c82b7d11a75ca79ab9850b961ce746d6aad6e69. Hopefully this is the last one😅


Move classes

Move classes to be completed:
Move
CastleMove
EnPassantMove
MoveManager
MoveTryer
PromoteMove

Marked as draft for now (doesn't look like there are any significant changes to be merged)


Improve Mongo backend query efficiency

The current backend stores manifests and objects separately (they are separate collections).  Several types of queries require "joining" those two collections together, to match each object to its corresponding manifest.  The way this is done is complicated and quite inefficient, owing to the fact that Mongo's "$lookup" pipeline step can only join on one property, and matching an object to its manifest requires checking both ID and version.  An additional complication is that an object's version isn't in a fixed property, e.g. it may come from either the "created" or "modified" properties.
Since manifests and objects map 1:1 in TAXII 2.1, one suggestion is to store an object and its manifest within the same Mongo document.  That way, no join is required to match them up.

closed by #117


Handle json parse error

I've tried to fix the error when there is broken config json.

Great one!
Thank you!


Toggle breakpoint at right-click position

Currently it toggles the breakpoint at the line the cursor is (editing line).
https://github.com/daveleroy/SublimeDebugger/assets/109356759/9753f067-768f-45ac-b2e4-5fc26df4b997

I don't this its possible to change this and this is also how other packages like LSP behave

I think it is possible to get the x, y positions of the mouse from the Event object, if you specify a want_event method in the toggle breakpoint command , see https://www.sublimetext.com/docs/api_reference.html#sublime.Event

If someone wants to support this they can look into it but I don't have any plans to do it.
The commands that would use want_event would need to support calls with and without the event dict since anyone can call the commands directly or from the command palette.


Ability to use current git?

Would it be possible to make builds based off of the current git of ghidra?, for bleeding edge nightlys etc?

sorry, I'm afraid it's out of scope. this tools is more like testing or building your own Ghidra Script or Ghidra Plugins, not building Ghidra itself. I hope I've answered your concern.


Feat add SetLogMode

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
Add logger.SetLogMode, that will replace logger Config LogLevel, not return new logger config instance.
User Case Description
db, err := gorm.Open(mysql.Open(dns), &gorm.Config{
	Logger: logger.Default.SetLogMode(logger.Silent),
})

Hello @gsxhnd
Thank you for your PR, your issues was caused by callbacks are not using db's logger but using logger.Default
Honestly, I am not a fan for adding this API, and the above commit should fixed your issue, thank you.


[BUG] Create Domain from Template (SOA Serial)

Hi,
if you Create a domain from template, you get a SOA Serial of YYYYMMDDnn
(where nn is random, i dont see any logic there)
If you Create a domain without template its perfect, you get YYYYMMDD01
Cheers :-)

I think nn will end up matching the number of operations the create process is going through, so should probably never be more than 02 or perhaps 03 in some special case. Which numbers are you seeing?
When creating from template, the domain is created first, then data is added. This should give 02.
I've seen 03 myself, but not sure why. Adding a custom SOA to the template might cause an extra operation to happen, to replace the one created with the domain.

AAH !!! Makes sense!!!
Sry, ive didnt seen it from this point!!!
Ive see sometimes 04 and seen once 06 (but cant reproduce 06)
its 99% 03 or 04.
But yes, it creates the domain with 01 and applys the template 02,03,04 ...
So not a bug, its just how it works....
Thanks!!!
Can i close this then?


reward change chart

How do I get the final reward change chart?

Hi,  the average reward of each robot is saved in the list:  ep_ret_list_mean.  (https://github.com/hanruihua/rl_rvo_nav/blob/main/rl_rvo_nav/policy_train/multi_ppo.py#L256), you can plot the mean at each epoch to see the reward change chart.

嗨，每个机器人的平均奖励保存在列表中：ep_ret_list_mean。（https://github.com/hanruihua/rl_rvo_nav/blob/main/rl_rvo_nav/policy_train/multi_ppo.py#L256），您可以绘制每个时期的平均值以查看奖励变化图。

Thank you. Please ask which file is required for the example with moving obstacles？

Ok thanks. I'm going to close this issue.


Add support for bat for markdown rendering

bat can render markdown to terminal. It is also more probable to be installed on user's system.
Nevertheless, this PR prioritizes glow for markdown rendering, if it is not found it tries to use bat.
Also add a newline to log HELP to increase readability.

Hi, thank you very much!
In my testing, bat's output wasn't as clear as glows, so I added a disclaimer when falling back to bat.
Merged this with 77a170c54a920a715ab92957be308814a662d8ae and 18d848aaf63e169f92602686cd59ad17c0b3c6de.


As a developer of the batch server I would like to understand how to implement it securely

What problem does the story solve? Please describe.
We have a prototype batch server linked from issue #1860, but it has some security issues related to signal requirements for ownership of the batch server process.
Describe the tasks that will be required to complete the story
Determine which approach is safe:

[x] #1970
[x] #1971
[x] #1972

Describe alternatives you've considered
Use DBus interface to pass vectors of values instead of using a batch server.
Additional context
https://man7.org/linux/man-pages/man2/kill.2.html
https://man7.org/linux/man-pages/man2/setpgrp.2.html
https://man7.org/linux/man-pages/man2/setsid.2.html
https://man7.org/linux/man-pages/man2/pidfd_getfd.2.html

We have settled on the FIFO implementation for both sides of the communication between the batch server and the client.  This is implemented using mkfifo(3), and mirrors the naming requirement that already exists for the shared memory interface.
Other option:
Use a FIFO to pass requests from the client to server, but have the server send SIGCONT to client when the request is completed.  This has the advantage of avoiding any possible deadlock, but if BatchServer and BatchClient are implemented with paired messages, this can be avoided.
The signal solution could be used if we wanted the read or write requests to be non-blocking, but until a non-blocking solution is needed, the FIFO solution should provide a solution without modifying the application's signal handler for SIGCONT.


KOGITO-7260: Patch PR for KOGITO-7250 with doc improvements in input schema guide

JIRA: https://issues.redhat.com/browse/KOGITO-7260

Description: Patch PR for KOGITO-7250 with doc improvements in input schema guide

https://github.com/kiegroup/kogito-docs/pull/151
Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to setup automatic cherry-pick to another branch ?

The cherry-pick action allows to setup automatic cherry-pick from main to a specific branch.
To allow it, you will need to add the corresponding label with pattern: backport-{RELEASE_BRANCH}.
For example, if a backport to branch 1.26.x is needed, then the label should be backport-1.26.x.
Once the PR is merged, the action will retrieve the commit and cherry-pick it to the desired branch.
NOTE: You can still add label after the merge and it should still be cherry-picked.

@VaniHaripriya Can you please review the changes in this PR and share your comments?


[WIP] Feature/syntax highlight hover

This PR will eventually add syntax highlighting to the hover tool tip other changes include:

Adding deep merges to the config so it supports sub object fields
Adding an adhoc highlighter to generate tokens for given lines as well as fn to generate vim highlights for a line
Added a function to get vim highlights actual color values
Added functionality to pull token colors from the json theme, user config and set defaults based on available vim highlights.
I've removed splitting up the hover info on every new line and now only render the docs and the titles differently.

Todo

[x] Set highlight colors for various tokens or so tokens such as variable.other.object render with a color

[x] Fix formatting for code block and add highlighting to code blocks in tooltip

[ ] Fix failing test due to config changes

[ ]  Get json theme input as an array

[ ] Fix Regex quirks re .| characters

Screenshots

@bryphe 👍 thanks for the feedback its good to get some input re the implementation.
I've made changes as per your request so

removed the vimhighlight fn from the editor to the instance.
renamed the vimhighlight fn in the themeManager
specified a list of highlights to use.
Re. being able to read in themes like vscode's I've made the scopes an array and am working on converting theme scopes specified by an array internally to a dictionary.

Summary of other changes

On load the theme config is populated with vim highlight colors based on a fallback vim id specified in the config this part is essential for highlighting if not specified in theme or user config
Merge user, theme and vim colors respectively based on priority
created a separate enhanced theme for the hover tool tip which uses a wider array of tokens than the syntax highlighting

Thanks for all the work on this @Akin909 !

On load the theme config is populated with vim highlight colors based on a fallback vim id specified in the config this part is essential for highlighting if not specified in theme or user config

I had a comment on this in the file too - I'm wondering, is it not possible to have a default map like this:
const VimHighlightGroupToDefaultScopes = {
"Identifier": ["variable.language", "variable.parameter", ....],
...
}

And then we use that to map the vim highlight groups to a set of token colors that we return from getVimHighlights w/o a fallback property? That means that, the only part of the code that has to worry about vim highlights is the getVimHighlights call - the whole rest of the pipeline can be agnostic of it and just deal with ITokenColors.

created a separate enhanced theme for the hover tool tip which uses a wider array of tokens than the syntax highlighting

Just curious - why does there need to be a different theme? Can we use the wider array of tokens for syntax highlighting, too, and get more fidelity there?

@bryphe re.

created a separate enhanced theme for the hover tool tip which uses a wider array of tokens than the syntax highlighting

Just curious - why does there need to be a different theme? Can we use the wider array of tokens for syntax highlighting, too, and get more fidelity there?

I found that having all highlighting for tokens centralised meant that any change or restructure that I wanted to make to highlight the tooltip necessarily impacted the syntaxHighlighting and I soon discovered that what I wanted re highlighting the hover didn't always correspond to syntax highlighting and meant compromising on both.  For example if based on the original theme I wanted to restructure colors or the layout of the theme It would have the side-effect of breaking syntax highlighting in some unexpected way.
Also I found trying to co-ordinate syntax highlighting the hover with sensible colors and having to also deal with the way they impacted the syntax highlighting overwhelming as a choice to color a specific type one way in the hover could end up cascading into a bunch of often unexpected/undesired color changes all over the place in the syntax highlighting for vim
Also I very much wanted to keep this PR and in general any highlighting of ui based on tokens flexible so that that in other components like the hover or later maybe codelens windows wouldn't be dependent on the structure of the central theme. I plan/planned on generalising the quick info container's functionality into a Render Prop to be used in other components so they can all inherit the theme but restructure it or use it as needed without influencing the central theme object.
Re. consolidating/ removing the fallbacks i've had some success implementing this although in this case it creates the following issues:

invalidates the above plan or rather is a spanner in the works as without access to what highlights are available in vim I'd not be able to create a component that has fallbacks as the original theme is the only one that knew anything about vim's highlights as they aren't saved anywhere, so in order to color anything else it would have to come through the theme.

This also means that if we wanted to say specify a different initial color for the hover tool tip say highlight this kind of operator as red since it occurs rarely in the hover or makes it look better then we would also have to have the fallback be the same color in the editor (not sure i've elaborated this concern well)

A bigger issue is that with a centralised theme with no reference to vim , so far oni has been dependent on vim colors in the config to syntax highlight, trying to color the hover ui is now linked to syntaxHighlighting which increases complexity a bit now and tbh I was hoping not have to tweak the already present colors as figuring out how to color the hover box has been proving challenging on its own

Apologies for the enormous wall of text this PR has proven far more time/labour intensive than I intended/hoped 🙍♂

An issue is that with a centralised theme with no reference to vim , so far oni has been dependent on vim colors in the config to syntax highlight, trying to color the hover ui is now linked to syntaxHighlighting which increases complexity a bit now and tbh I was hoping not have to tweak the already present colors as figuring out how to color the hover box has been proving challenging on its own

Ah ya, this is a deficiency in the existing syntaxHighlighting implementation. Ideally, it shouldn't reference the highlight groups by name either, for the same reasons that fallback. I did it as a shortcut to get the highlighting working, but I think t hat we should fix it before building on top of it, before the coupling becomes intractable. Once syntaxHighlighting no longer needs the highlight group, I think we'll be able to get rid of fallback on the whole stack.
I can see breaking it up in the following way.

Add the getHighlights method and make the ThemeManager of the initial set of highlights, come from Vim
Consolidate the tokenColors from configuration + themeManager and make a unified place (like the Colors class today).
Update the syntax highlighting to use the ITokenColor and not the vim highlight group. This means tweaking the Buffer implementation so that it creates ad-hoc highlight groups. This means that we break our dependency on the vim highlight group and no longer need a fallback.
Add in the hover implementation + the enhanced tokens specific to it. There's a lot of work you did here in terms of parsing, hooking up the textmate highlighting, etc!

Also I found trying to co-ordinate syntax highlighting the hover with sensible colors and having to also deal with the way they impacted the syntax highlighting overwhelming as a choice to color a specific type one way in the hover could end up cascading into a bunch of often unexpected/undesired color changes all over the place in the syntax highlighting for vim

Makes sense, I can see where you may want to override them specifically for hover.
I'll put together some PRs for 1-3 to break our dependency on the highlight groups for syntax highlighting (building on the work you did!)... And then, hopefully we can apply this change, just without needing fallback anymore!

@bryphe just a heads up I've just pushed some changes almost exactly as you posted. I've removed the fallback and have added the functionality to generate tokens which are then feed into the theming. The dependency on vim highlights still exists and as work around I use the map of highlight to color to resolve that in SyntaxhighlightReconcilier as a work around

FYI - I implemented 1 & 2 in #1484, and 3 in #1485 . I hope you don't mind me stepping in with those changes - I'm still working hard to stabilize the syntax highlighting to get it on by default and I'm concerned that if we don't address some of those issues up front it will be more challenging to untangle later. There's still a couple of to-dos on each but the 'plumbing' is there in terms of how I envisioned the system behaving. Let me know if you have feedback or if you'd rather integrate them into your changes here.
I really appreciate the work you've done here though - the hover looks awesome with syntax highlighting and I'm stoked to get that in! 👍 Thanks for working with me on this!

@bryphe If at the end of the day oni ends up with syntax highlighting in the buffer and in the hover menu then thats well worth it 👍 I appreciate your helping re advice and the PRs.
One thing that this brings to mind though is that I think some issues there are sometimes considerations that someone contributing might not be aware of, for example in this case, breaking the dependency from vim highlights as that led to quite a few tweaks which i'm happy to do to get some ** color in the hover box** 🤣 I think with issues that are mission critical or have specific implementation requirements there should be a label to indicate that the strategy re implementation might need to be discussed first? I tend to be a bit impetuous personally so a label against an issue that indicated it wasn't one to rush and implement willy nilly would be helpful.
Granted this wasn't so much a standalone issue as new thing which I should probably have raised an issue for and discussed implementation first given that it wasn't a stretch to imagine there'd be many discussion points
Not sure what you think but I think it might save contributors from falling into traps they might not even know to look for or creating or worsening dependencies they didnt consider.
re ongoing work on this PR I will wait till #1485 and #1484 are completed merge those in or merge master if you merge them and see what needs to be changed in this PR to work with those and continue from there.

UPDATE: I've merge both of your PR's into mine, and will focus on remaining highlight quirks, regexp tweaks and will need to add more tokens to the default list as those generate all the tokens and there currently arent enough there to provide good levels of highlighting.

One thing that this brings to mind though is that I think some issues there are sometimes considerations that someone contributing might not be aware of, for example in this case, breaking the dependency from vim highlights as that led to quite a few tweaks which i'm happy to do to get some color in the hover box

Definitely! I really appreciate that you're willing to work with me and take feedback 😄

I think with issues that are mission critical or have specific implementation requirements there should be a label to indicate that the strategy re implementation might need to be discussed first? I tend to be a bit impetuous personally so a label against an issue that indicated it wasn't one to rush and implement willy nilly would be helpful (exaggeration for effect I try never to be willy nilly.

This is challenging because it can be dependent on the approach and developer taking on the issue - for example, there might be cases where I have a solution in mind that doesn't need an in-depth architecture change, but it turns out that's not accurate... or what i thought was a big change ends up being simple, etc. In other words, two developers might look at the same issue but come out with very different ideas in terms of the implementation plan, so it's tough to know ahead of time, and not realistic for me to break down every issue to that level of detail anyway.

Not sure what you think but I think it might save contributors from falling into traps they might not even know to look for or creating or worsening dependencies they didnt consider.

My preference is that if there are any unknowns, it's good to discuss them before embarking on the work. It can be hard to know ahead of time all the unknowns, and it's different for each developer too depending on what areas they are comfortable with - so there has to be some impetus on the developer to proactively voice these and get feedback on approaches. For example, I really like what @TalAmuyal did for #1415 - put together a sketch of the plan/interface, made sure we're on the same page, and then moved forward with it. Taking an incremental approach and breaking the PR into smaller chunks can be helpful here, too.
I tweaked our contributing guidelines in #1495 a bit and added a line here to that effect:
* If there is ambiguity in terms of design, architecture, or implementation, it's best to get feedback before implementing, to save both you and the maintainer time. If you're not sure, feel free to ask!

Let me know if you have feedback!
Another thing that I'd like to do is document our architecture more thoroughly, especially some of the design principles like orthogonality, minimizing coupling, single responsibility principle, etc. Some of these things are implicit or not obvious in the codebase so it'd be worth calling them out!

UPDATE: I've merge both of your PR's into mine, and will focus on remaining highlight quirks, regexp tweaks and will need to add more tokens to the default list as those generate all the tokens and there currently arent enough there to provide good levels of highlighting.

Sweet, sounds good! Thanks @Akin909 - looking forward to having this 👍

Coverage remained the same at ?% when pulling 84061879f27b6ab8cdd7a225e049098ce7cfa070 on Akin909:feature/syntax-highlight-hover into b9365dd26a83e8e8eaf67a94b21bda8954d44808 on onivim:master.

Coverage remained the same at ?% when pulling 84061879f27b6ab8cdd7a225e049098ce7cfa070 on Akin909:feature/syntax-highlight-hover into b9365dd26a83e8e8eaf67a94b21bda8954d44808 on onivim:master.

Update: I've added some unit tests for the markdown functions (though tbh those aren't really linked to  marked I've just called it that) and will come back to it re. enzyme tests once I've pushed an enzyme PR I'm working on

Further update managed to fix the outstanding bug (that I'm aware of tm) which was that code blocks weren't highlighting which was actually not a commonly encountered issue as most of the markup is being rendered in p tags by marked but it was an issue with marked trimming whitespace from the text passed to the custom renderer which I've resolved. So believe this is good to go.


crash on method  SETextView replaceRange:withText

Exception:
NSMutableRLEArray replaceObjectsInRange:withObject:length:: Out of bounds
0x00139b71 -[SETextView replaceRange:withText:] + 544

can you solve the problem above?


Added GitHub Repo checklist with localStorage functionality

Description

Added GitHub.js component to src/componts folder
Import GitHub to App.js component
Create an Array of Object with id, checked, and item properties and write all the tasks given in the image of the issue
Add Local Storage functionality to save the checked/unchecked items
Used HTML Semantic tags for better accessibility
Used dangerouslySetInnerHTML to render HTML inside of a string property

Related Issue

#3
Acceptance Criteria

[x] Create a component called GitHub.js and save it in a folder called components in the src directory
[x]  Heading: GitHub Repositories
[x] Input fields must be editable
[x] Input fields are accessible
[x] No stylings but plain html
[x] The new component is imported and displayed in the App.js component
[x]  Only the new component is displayed
[x]  Save data in localStorage

Type of Changes

Type

:bug: Bug fix

✓
:sparkles: New feature

:hammer: Refactoring

:100: Add tests

:link: Update dependencies

:scroll: Docs

Updates
Before

After

Testing Steps / QA Criteria

To check the code visit src/components/GitHub.js
Clear your Local Storage
After clearing Local Storage , visit the preview link to test live.

Thank you for another great contribution 🥳


ext_ prefix does not work with VS2019

I'm trying to create a boilerplate template for a series of web applications my team needs to create - they are structured in the 3-tier (data access/business logic/ui) style.
The solution template works apart from the references. For example, when I create a new solution with this template (call it "MyAPI"), I get my three projects: "MyAPI.Data", "MyAPI.Business" and "MyAPI.UI", which is great - but instead of MyAPI.Business having the expected reference to MyAPI.Data, I am seeing "$ext_projectsafename$.Data" in the references.
If I replace remove the "ext_" (ie: use "$projectsafename$"), then the substitution works as expected, and I end up with a reference to "MyAPI.Business.Data" - which is wrong, but it shows that $safeprojectname$ is being replaced with "MyAPI.Business", which is the expected behaviour. But the reference needs to be to "MyAPI.Data".
Can anyone advise on this? Thanks.

@Ben-P-Leda -- thank you for your question. It looks like you're having an issue with the product itself, rather than an issue with the documentation. Here are a few options where you might consider asking your question:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

As well, you might also consider using the Report a Problem tool to report the issue.


Wenlei branch

the vertical line in wiggles plotting is removed by using
plt.fill_betweenx

remove the vertical lines in wiiggle plot

Nice fix Wenlei.


Consider moving to Google Cloud Build

Benefits would include:

Speed up tests by configuring Dockerfile to use an image with everything preinstalled
Use an SSD or an extra fast CPU
Build everything in a RAM disk

Closes #676
Closes #677
Closes #638

I am willing to help with the issue. How do I start?

Sorry, we should update the issue. We tried using Google Cloud Build and found that it was missing one feature we wanted. We're waiting for that feature to be released publicly and then we'll make the switch. Thank you for offering to help. We'll ping you again when the GCB feature is out.

Closing as we're moving to Github Actions for CI.

Closing as we're moving to Github Actions for CI.


As a user I should be able to invite other users so they can also add items to the todo list

Invitation is by adding an email address to which a link will be sent.
User will have to sign up before they can add to the todo list.

As a user
I can invite other users to do.it
so they can also add items to the todo list


Support for iOS SDK v4

The Firebase iOS SDK v4.0.0 was released earlier this month and has quite a few breaking changes.
I've tried upgrading already (using pod update) and most things still seem to work just fine, except for one crash on startup described in this issue: https://github.com/evollu/react-native-fcm/issues/419 (-[RNFIRMessaging messaging:didRefreshRegistrationToken:]: unrecognized selector sent to instance).
This library should be updated to support FCM v4, and in the meantime the README should probably also be updated to recommend staying on v3 for now (I'd be happy to submit a PR later next month to help with this, but currently am quite busy). Thanks for the great library!

Looks like there's a PR up already to fix the crash mentioned: https://github.com/evollu/react-native-fcm/pull/421

Solved in https://github.com/evollu/react-native-fcm/releases/tag/v7.0.0, thanks!

I just upgraded to v7 (I was concern to upgrade to latest since it's a project that must be delivered) and it fixed the crash we had at startup.


[a11y] Trap keyboard focus in DialogModal

Asana Task
When the DialogModal is open, we should lock the focus inside of the modal to make it easy for keyboard users to interact with. This PR accomplishes this by using the FocusScope component from react-aria. We automatically trap focus inside the modal when it opens, and return focus to the last focused element when it closes. In addition, if a close icon is present, we allow the user to dismiss the modal using the Escape key.

In addition, if a close icon is present, we allow the user to dismiss the modal using the Escape key.

Is this informed by any sort of WCAG or WAI-ARIA spec, or just our own flavor?

@michaeljaltamirano - just our own flavor. I haven't seen a spec that explicitly requires that the Escape key dismisses modals, and I can imagine cases where we might require an explicit confirmation before returning to the rest of the page. If that seems too restrictive, definitely happy to apply the escape key behavior for all instances.

@michaeljaltamirano - just our own flavor. I haven't seen a spec that explicitly requires that the Escape key dismisses modals, and I can imagine cases where we might require an explicit confirmation before returning to the rest of the page. If that seems too restrictive, definitely happy to apply the escape key behavior for all instances.

I'm not too familiar with the DialogModal development but I would venture to guess that the more restrictive version requires an explicit yes/no from a patient, so I think it's fine as is. Great use of the tool.

Super interesting! The component felt so intuitive to use and solved such an important problem that I almost cried 😂


Install via bower shows "description too long", although the description in that bower.json just has 138 characters

What's wrong with my installation or in bower?
I tried to install https://github.com/PolymerElements/iron-elements/blob/master/bower.json

It seems that another git progress was open (or watching changes). That caused the problem and now it works. Sorry for issuing ;)