cmake: string quotes are removed from extra_kconfig_options.conf

Describe the bug
When string configuration options are passed via west build and prj.conf changes, the necessary quotes get removed from
build/zephyr/misc/generated/extra_kconfig_options.conf.
To Reproduce
cd samples/bluetooth/peripheral_hids
west build -b nrf52840dk_nrf52840 -- -D'CONFIG_BT_DEVICE_NAME="hello world"'

echo >> src/main.c
west build # builds correctly

echo >> prj.conf
west build # no longer builds

This results in the following error message:
zephyr/samples/bluetooth/peripheral_hids/build/zephyr/misc/generated/extra_kconfig_options.conf:2: warning: malformed string literal in assignment to BT_DEVICE_NAME (defined at subsys/bluetooth/host/Kconfig:579). Assignment ignored.

Expected behavior
I would expect the string quotes to remain extra_kconfig_options.conf.
Impact
Minor annoyance as it requires the build directory to be manually deleted.

@xudongzheng thank you for the detailed report.
Honestly, I initially thought this must be user error, but I can reproduce and I think we should adjust priority and reassign.
With this patch:
--- a/cmake/modules/kconfig.cmake
+++ b/cmake/modules/kconfig.cmake
@@ -182,6 +182,10 @@ foreach (name ${cache_variable_names})
   if("${name}" MATCHES "^${KCONFIG_NAMESPACE}_")
     # When a cache variable starts with the 'KCONFIG_NAMESPACE' value, it is
     # assumed to be a Kconfig symbol assignment from the CMake command line.
+    message(STATUS "
+
+    eval(name)=${name} eval(eval(name))=${${name}}
+")
     set(EXTRA_KCONFIG_OPTIONS
       "${EXTRA_KCONFIG_OPTIONS}\n${name}=${${name}}"
       )

I see the following on the first west build:
eval(name)=CONFIG_BT_DEVICE_NAME eval(eval(name))="hello world"

and this after touching prj.conf and re-building:
eval(name)=CONFIG_BT_DEVICE_NAME eval(eval(name))=hello world

Further, in build/CMakeCache.txt, I see:
CONFIG_BT_DEVICE_NAME:STRING=hello world

so for some reason, cmake itself seems to be:

stripping the quotes from the string literal in the cache file
preserving the quotes in memory for the first cmake run
using the cache file in subsequent re-runs, which has discarded the quotes

I am tempted to call this a bug in cmake itself, but let's call it high for now and see if there is a known fix. I'm surprised no one has seen this before. We may need to document this as a limitation if there's no way around this. Nothing I tried seems to force cmake to keep the quotes in the cache file.

I am tempted to call this a bug in cmake itself, but let's call it high for now and see if there is a known fix. I'm surprised no one has seen this before. We may need to document this as a limitation if there's no way around this. Nothing I tried seems to force cmake to keep the quotes in the cache file.

It's been known for a long time, I've certainly seen it for as long as I can remember. It becomes very annoying with sysbuild however because any change to via menuconfig will break the project and you won't be able to build or configure it again, you have to delete the whole build folder and start over. This was very much a hacky bit of code I threw together to work around the issue in cmake/modules/kconfig.cmake on line 182:
# Support assigning Kconfig symbols on the command-line with CMake
# cache variables prefixed according to the Kconfig namespace.
# This feature is experimental and undocumented until it has undergone more
# user-testing.
unset(EXTRA_KCONFIG_OPTIONS)
get_cmake_property(cache_variable_names CACHE_VARIABLES)
foreach (name ${cache_variable_names})
  if("${name}" MATCHES "^${KCONFIG_NAMESPACE}_")
get_property(result CACHE ${name} PROPERTY TYPE)
message(STATUS "${name} = ${${name}} = ${result}")
if(${result} MATCHES "STRING")
if(${${name}} MATCHES "y" OR ${${name}} MATCHES "n")
    set(EXTRA_KCONFIG_OPTIONS
      "${EXTRA_KCONFIG_OPTIONS}\n${name}=${${name}}"
      )
else()
string(REPLACE "\"" "" varout ${${name}})
    set(EXTRA_KCONFIG_OPTIONS
      "${EXTRA_KCONFIG_OPTIONS}\n${name}=\"${varout}\""
      )
endif()
else()
    set(EXTRA_KCONFIG_OPTIONS
      "${EXTRA_KCONFIG_OPTIONS}\n${name}=${${name}}"
      )
endif()
    # When a cache variable starts with the 'KCONFIG_NAMESPACE' value, it is
    # assumed to be a Kconfig symbol assignment from the CMake command line.
  endif()
endforeach()

Is there some way that we can ask kconfiglib if a particular option has string type at cmake time, before we generate extra_kconfig_options.conf? If so, then we could manually add quotes each time they are missing.

@xudongzheng please find a fix here: https://github.com/zephyrproject-rtos/zephyr/pull/49267

This seems to still be an issue on Windows?
west build -b nrf5340dk/nrf5340/cpuapp ..\zephyr\samples\hello_world\ -d build_hello -- '-DCONFIG_BOOTLOADER_MCUBOOT=y' '-DCONFIG_MCUBOOT_SIGNATURE_KEY_FILE="bootloader/mcuboot/root-rsa-2048.pem"'
gives Kconfig malformed string literal warning, where the command is stripped of the quotes
FATAL ERROR: command exited with status 1: 'C:\Program Files\CMake\bin\cmake.EXE' -DWEST_PYTHON=C:/Users/andre/.pyenv/pyenv-win/versions/3.9.13/python.exe '-BC:\Users\andre\ws_samples\sample_usbfull\build_hello' -GNinja -DCONFIG_BOOTLOADER_MCUBOOT=y -DCONFIG_MCUBOOT_SIGNATURE_KEY_FILE=bootloader/mcuboot/root-rsa-2048.pem '-SC:\Users\andre\ws_samples\zephyr\share\sysbuild' '-DAPP_DIR:PATH=C:\Users\andre\ws_samples\zephyr\samples\hello_world'


Add pitchEnabled property to MapView

@lelandrichardson @christopherdro Any chance on getting this merged in? :)

@jadnco Sorry for the late response, will check on that tonight?

@jadnco Looks good. Could you squash your commits before we merge this in?

@jadnco what is the meaning of the center coordinate of the region when tilt is enabled?

@lelandrichardson Nothing would change from what it already means. Tilt only changes when users start interacting with the map (swiping up/down with two fingers). That feature is already enabled by default, so adding the pitchEnabled property just allows developers to disable it.
Does that answer the question?

👍 Thank you.

how to set the pitch of the map when the map was loaded?


Suggestion for MoreMapPins mod compatibility

Hi there !
Just installed you mod and it is pretty cool, especially in nomap mod.
I also have the MoreMapPins mod installed and some text is overlapping. Would it be possible to slightly move your toggle options a bit or to make it repositionnable via the .cfg file ?
Here is a screenshot :

Thanks a lot and have a nice day.

Hey, merci pour ton retour 😄
Considering the UI there, I think it would make more sense if MoreMapPins's UI would be the one being repositioned, since my toggles (which are the public and guild toggles) are aligned with the vanilla toggles (which are the public position and shared exploration toggles). It looks like MoreMapPins is actually already incompatible with vanilla, considering it overlaps the shared exploration one... 😅
As an aside, I was under the impression this mod was incompatible anyhow because it uses custom pin types and those are not shareable with BetterCartographyTable. Does it actually work? 🤔


bugfix/feat:Allow other LDAP field besides "mail" to map to email adress, or fallback to made up email

Summary
if the userinfo of LDAP does not return a mail field, librechat will not authenticate even if ldap authenticated succesfully.
Change Type
Please delete any irrelevant options.

[x] Bug fix (non-breaking change which fixes an issue)

Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] My changes do not introduce new warnings
[x] A pull request for updating the documentation has been submitted.

https://github.com/LibreChat-AI/librechat.ai/pull/128

Replaced by https://github.com/danny-avila/LibreChat/pull/4177
lgtm overall but I added a warning for the new fallback behavior


Current SQL schema version could not be resolved.

Getting following error with latest code.
info: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[105]       Executed action Microsoft.Health.Dicom.Api.Controllers.QueryController.QueryForStudyAsync (Microsoft.Health.Dicom.Api) in 753.3386ms warn: Microsoft.Health.Dicom.Api.Features.Exceptions.ExceptionHandlingMiddleware[0]       Service exception.       Microsoft.Health.Dicom.Core.Exceptions.DataStoreNotReadyException: Current SQL schema version could not be resolved.          at Microsoft.Health.Dicom.SqlServer.Features.Schema.VersionedCache1.ResolveAsync(CancellationToken cancellationToken)

Are you updating an existing service? If so, what schema version was previously referenced?
Or are you creating a new service?

I am running it as a new service, no database exists, so when I run the project it creates db but in further steps it fails.

Im currently running it locally in dev environment.
tables are not getting created on initial run, only database is created.
some lines from logs.
warn: Microsoft.Health.SqlServer.Features.Schema.SchemaInitializer[0]
      Could not find stored procedure - dbo.SelectCurrentSchemaVersion
info: Microsoft.Health.SqlServer.Features.Schema.SchemaInitializer[0]
      Initial check of schema version is NULL
...
...
...
info: Microsoft.Health.Dicom.Core.Features.Partition.PartitionCache[0]
      Cache miss. Initializing the row.
info: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[105]
      Executed action Microsoft.Health.Dicom.Api.Controllers.QueryController.QueryForStudyAsync (Microsoft.Health.Dicom.Api) in 931.399ms
warn: Microsoft.Health.Dicom.Api.Features.Exceptions.ExceptionHandlingMiddleware[0]
      Service exception.
      Microsoft.Health.Dicom.Core.Exceptions.DataStoreNotReadyException: Current SQL schema version could not be resolved.
         at Microsoft.Health.Dicom.SqlServer.Features.Schema.VersionedCache`1.ResolveAsync(CancellationToken cancellationToken) in

may be default stored procedures are not getting created from shared health package and Initial check of schema version is NULL error is coming.

Have you been through these instructions if you are running the service locally? https://github.com/microsoft/dicom-server/blob/main/docs/development/setup.md

Have you been through these instructions if you are running the service locally? https://github.com/microsoft/dicom-server/blob/main/docs/development/setup.md

Yes, I'm following the guidelines.

I have resolved the issue by following steps in SqlServer readme.md file. We can close this issue.


improve deployment guide

Answer @maxamillion questions from rel-eng of fedora:

[ ] Does OSBS need a Project inside of OpenShift?
[ ] What kind of access to OpenShift does the OSBS builder need?
[ ] Can OSBS share an OpenShift environment with other projects/users?
[ ] How to configure the above

Thank you! :)


Disabling drop down options inside array type: not disabling the element options but background field config is showing with disabled attribute

I have to disable the selected items in the array or items in formly (JSON schema powered). I added functionality in mapFunction and I achieved. but the previous select item is not disabling the option we disabled.
  public mapFun(
       mappedField: FormlyFieldConfig,
     mapSource: JSONSchema7 & MySchema
    ): FormlyFieldConfig {

mappedField.hooks = mappedField.hooks || {};
mappedField.hooks.onInit = (field?: FormlyFieldConfig): void => {

  const countryCodeField= field.key == "countryCode" ? field : null;
  if (countryCodeField) {
    countryCodeField.hooks = countryCodeField.hooks || {};
    countryCodeField.formControl.valueChanges
      .pipe(distinct((v) => v))
      .subscribe(selectedItem => {
        // Disable the country  code in MASTER ITEMS
                    field.options.formState.MASTERITEMS.map((f: { label: string, value: number, disabled?: boolean }) => {

          f.disabled = selectedItem == f.value ? true : f.disabled;
        });

      });

  }

JSON FILE:
              "templateOptions.options": "formState.MASTERITEMS",

Image attached:

Hi, could you please provide a reproduction using stackblitz starter example
Thanks!


fixes-27350

Add shorturi method back to UriReport. This method is used in Jelly script which displays the uri used for test.
Removed sample values need to be added back for the uriReport page.
URI column is redundant on the uriReport page.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

This looks good. I verified by manually installing the plugin from the [build] (https://jenkins.ci.cloudbees.com/job/plugins/job/performance-plugin/92/org.jenkins-ci.plugins$performance/artifact/org.jenkins-ci.plugins/performance/1.14-SNAPSHOT/performance-1.14-SNAPSHOT.hpi).

@jugalps I removed the URI column so I am not sure why the URI column is showing. What page are you looking at?
I am looking at the uriReport page: ../119/performance/uriReport/some-test.jtl%3Asome_uri.endperformanceparameter/

@manolo any chance to have this fix released soon ?

Is there any progress with this? Would really appreciate if this fix would be released as binary.

Any updates on when this PR would be merged?

Please add
report.setReportFileName(reportFile.getName());
to AbstractParser.java line 67


Deploy only consul clients

Hi
Please correct me if I am wrong:
ATM the role is only usable when all consul servers and clients are part of the hostgroup “cluster_nodes/consul_instances (latest)”. Therefore I have to be a server admin also when I only want to deploy a client.
-> I cannot use the role out of the box as a consul client admin.
My quick and dirty solution was:
Playbook:
- hosts: "consulclients.com"
  remote_user: centos
  become: true
  become_user: root
  become_method: sudo
  gather_facts: yes
  roles:
    - consul
  vars:
    consul_node_role: "client"
    consul_acl_agent_token: "MyClientToken"
    consul_tls_enable: "true"
    consul_join_servers:
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
    ...

config.json.j2:

    {## LAN Join ##}
    "start_join": [
			{% for server in consul_join_servers %}
					"{{ server }}",
			{% endfor %}
        {% for server in _consul_lan_servers %}
            "{{ hostvars[server]['consul_bind_address'] | ipwrap }}",
        {% endfor %} ],

Is it possible to add a “clients only mode” in one of the next releases?

You could always add some dummy hosts to fix this problem.
I'll have a look at supporting this use-case in the future.
@brianshumate you can assign this issue to me

Thank you. @groggemans
Current solution:
    {## LAN Join ##}
    "retry_join": [
			{% if consul_join_servers is defined %}
			{% for server in consul_join_servers %}
					"{{ server }}",
			{% endfor %}
			{% endif %}
        {% for server in _consul_lan_servers %}
            "{{ hostvars[server]['consul_bind_address'] | ipwrap }}",
        {% endfor %} ],

I also changed start_join to retry_join, because i had problems with leader election.

FYI I am also trying to get the same functionality. I want to deploy just the consul agents in client mode but I keep getting depedencies errors on the need for the consul_raw_key which seems to be only need for the `gossip encryption key for servers that require it, so I don't see why clients would need it.

Actually my mistake, consul_raw_key is needed by all agents - the server put me off the track. The one issue I am now debugging is the config template var hostvars[server]['consul_bind_address'] is missing.

The project has always been more about forming clusters of Consul servers and has not had much thought or work at all into deploying client only instances, but it is certainly a valid use case and would be nice to have so I hope it can be hashed out here and a PR done for the feature.
Let me know how I can help.
Thanks!

Hi. I am in holidays the next week's. I changed the role for me  but it was not really compatible. Like Brian said the role is usefully to deploy servers and I will not try to include the client solution here. I think I will write a native bash and docker script for the client users. So they can use it within their deployment scripts.

I'm willing to help make this happen.
I can test, or even start to work on implementing it, given some directions, maybe a task list.

Currently running tests for a PR adding this feature and fixing #102

Feature added in #116

Hi @groggemans
I use the feature now and am able to deploy clients only. Thank you.
There is one issue that you still need a (dummy) “consul_instances” hostgroup with consul_node_role: “server” entries, so that the role can complete without errors.
- name: "Create consul server tenant group"
  add_host:
    name: "{{ item }}"
    groups: "consul_instances"
    consul_node_role: "server"
  with_items:
    - “foo”

For the rejoin from the client to servers I am than using only the new “consul_join” list and it works.
Thank you again for implementing it.


tree gas flux

Hi TEMPEST data team!
Who's excited for TEMPEST III? I know I am!
In preparation, I'm hoping to look at tree gas flux data from all previous events. Seems like it is missing from the repo, is that intentional?
Here is where the raw data lives in the gdrive: https://drive.google.com/drive/folders/13uyYcX7DcjTMkdLPoPpuu1Y8KMQV4RK_
I can spend some time working on a data processing pipeline, but want to make sure I'm starting in the right place.

Hi TEMPEST data team! Who's excited for TEMPEST III? I know I am! In preparation, I'm hoping to look at tree gas flux data from all previous events. Seems like it is missing from the repo, is that intentional?
Here is where the raw data lives in the gdrive: https://drive.google.com/drive/folders/13uyYcX7DcjTMkdLPoPpuu1Y8KMQV4RK_
I can spend some time working on a data processing pipeline, but want to make sure I'm starting in the right place.

Requesting write access to address the topic above @bpbond or @stephpenn1 , thanks in advance!

Hi Kendal, just gave you write access to this repo.
The google drive link you sent gives me a 404 error, are you planning to move those raw data into this repo?
If so, I'll also point out you can use the google drive R package to pull files in your script without having to put them in two places.


Added PrimeChecker.jl mini project

PrimeChecker takes number input and returns whether it's a prime number or not.  🤘

Thank you for this! A few things:

[ ] Can you add comments on the code for clarity, whatever you think a new user might need to know
[ ] Please update the code to have consistent spacing
[ ] Use lowercase file names and "_"'s between the words
[ ] Add this to the list of problems in the README

Thanks for adding this and happy to merge after these are addressed

Please also think of a good emoji to use with the problem for the README, maybe: 🔢

Okay, Logan. I am fixing right now.

[x] Added comments to clarify what is project structure. f85b7041dc3f632c71f88c30b430b356e8122341
[x] Deleted spacing in function d2d53786a47a8493e329fd3e54ea020d61412c55
[x] Changed file_name with base on contribution rules -same commit with first one f85b7041dc3f632c71f88c30b430b356e8122341
[x] Added readme and resolved-conflicts 9939f9835590fc90f992e4b41ffa8e2b9c332d4c

Also, it is the 10th project in this repo 🎯

Thank you for this!!


Project Filters or Status type

Allow user to filter by project type (ie if user would like to only see Bike projects, one can select 'Funded>Bike' or 'Funded>First/Last Mile'.  Also need filter for projects that are re-occurring such as CicLAvia (routes will generally be the same but dates are only 'active' or 'funded' for time of event) or in cases where the project status has changed and is on hold. Project Managers will want to place on 'HOLD' or 'HIDE'.

Added Funded/Unfunded buttons and additional functionality for dropdown checkbox list filtering.


Wait for ThreadImport to finish before we initialize the initial chain tip

This should fix the infinite hangs we observe on Jenkins. The reason is that there is a race between ThreadImport finishing and the call to InitializeCurrentBlockTip.
While ThreadImport is running, fImporting is true, which makes IsInitialBlockDownload return true. If InitializeCurrentBlockTip is called while ThreadImport is not finished yet, InitializeCurrentBlockTip will call UpdatedBlockTip with fInitialDownload=true. As UpdatedBlockTip is then never called again (as no block are generated while waiting for mnsync), mnsync will never finish.
This should fix the hangs, but it's not a proper fix for the underlying problem. The underlying problem is the use of mocktime in most of our tests. It results in IsInitialBlockDownload to return false (but only if ThreadImport has finished) even though no block has been generated/received yet, which also means it returns false in a multi-node test BEFORE nodes are connected.
Interestingly, this doesn't cause real problems in the tests...except this one, but this is related to Dash-specific functionality only. The hangs are not happening on Travis as timing seems to be different there. It started to happen on Jenkins after the recent fixes to regtest-mnsync, which implicitely removed calls to SwitchToNextAsset when nRequestedMasternodeAssets is MASTERNODE_SYNC_INIT. This made the mnsync fully dependent on the call to UpdatedBlockTip with fInitialDownload=false. EDIT: Which is actually fine and shouldn't be changed IMHO. UpdatedBlockTip should just be more reliable, which should be the case after this PR.
A possible solution would be to start nodes with a mocktime that is nMaxTipAge seconds after the genesis block.

I just realized that this fix would block the whole init process until an import/reindex is finished. I'll think about another fix for this...


Add ability to set SMTP envelope addresses

I am working on a program that is called from a mail server, and re-injects the message back into the mail queue to be sent to multiple recipients (using a Postfix content filter).  The problem is that this library forms the RCPT TO: information from the message headers, which in this case, will not work (the goal is for the message to arrive untouched).  There should be an option to pass SMTP-level message options to the transport to handle situations like this.
I currently have something like the following:
$email = file_get_contents("php://stdin");
$headers = $body = '';
Zend\Mime\Decode::splitMessage($email, $headers, $body);

// Setup SMTP transport
$transport = new Zend\Mail\Transport\Smtp();
$options = new Zend\Mail\Transport\SmtpOptions(
        array(
    'name' => php_uname('n'),
    'host' => '<IP_ADDRESS>',
    'port' => 10025,
        )
);
$transport->setOptions($options);

$message = new Zend\Mail\Message();
$message->setHeaders($headers);
$message->setBody($body);
$transport->send($message);

This pull request will allow you to do:
    $message = new Zend\Mail\Message();
    $message->setHeaders($headers);
    $message->setBody($body);
    $envelope = new Zend\Mail\Transport\Envelope(array(
        'from' =><EMAIL_ADDRESS>        'to' =><EMAIL_ADDRESS>            )
    );
    $transport->setEnvelope($envelope);
    $transport->send($message);

This PR is still requiring tests before being mergeable

Ping @ameir — I'd love to merge this for 2.4, but we need tests for the new functionality. Would you be able to do that in the next 2 weeks?

@weierophinney I'll see if I can find time to knock this out in the next few days.  My apologies for the delays; my schedule has been hectic.  I have a number of other changes to perform PRs against as well (https://github.com/ameir/zf2/tree/mail-improvements), but they'll also need tests.

@weierophinney @Ocramius I wrote tests and updated the code accordingly.  I had to reintroduce the setters and getters due to a separate test failing that checked for existence of those.  I then updated the code to use the setters/getters.  Let me know if this needs further modification.

Incorporated feedback from @Ocramius and merged to develop for release with 2.4.


ValueError: this loader cannot find files for ansible.plugins, only ansible_collections.ansible.builtin.plugins

ansible-core 2.13.0
ansible 6.0.0b1
ansible-compat 2.1.0
mitogen from Git master branch ( 89c0cc94d16218e2647bb8bb32b011231def0fd7)
Controller OS: Fedora 36, Python 3.10
Host OS: CentOS 7, Python 3.6
Works without mitogen strategy. Error happens with Python 2 and 3 in the host (set through ansible_python_interpreter)
[mux  49590] 18:58:01.502846 D mitogen.responder: sending ansible.module_utils (0.50 KiB) to ssh.server
[mux  49590] 18:58:01.502918 D mitogen.io: Router(Broker(1900))._async_route(Message(2, 0, 0, 107, None, b'\x80\x02(X\x14\x00\x00\x00ansible.module_utilsq\x00]q\x01(X\x05\x00\x00\x00_textq\x02X\x0f\x00\x00'..515), None)
[mux  49590] 18:58:01.502990 D mitogen.io: MitogenProtocol(ssh.server)._send(Message(2, 0, 0, 107, None, b'\x80\x02(X\x14\x00\x00\x00ansible.module_utilsq\x00]q\x01(X\x05\x00\x00\x00_textq\x02X\x0f\x00\x00'..515))
[mux  49590] 18:58:01.549921 D mitogen: PkgutilMethod(): <_frozen_importlib_external.SourceFileLoader object at 0x7fb2db7937c0>.get_file_name('ansible.module_utils.distro') failed: ImportError('loader for distro cannot handle ansible.module_utils.distro')
[mux  49590] 18:58:01.550039 D mitogen: SysModulesMethod(): <module 'distro' from '/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/distro.py'>.__name__ is 'distro', aborting
[mux  49590] 18:58:01.550287 D mitogen: ParentEnumerationMethod(): 'ansible.module_utils.distro' is PKG_DIRECTORY: '/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/ansible/module_utils/distro/__init__.py'
[mux  49590] 18:58:01.585593 D mitogen: While importing 'ansible.module_utils.basic'
Traceback (most recent call last):
  File "/home/user/code/mitogen-master/mitogen/master.py", line 1134, in _send_module_and_related
    tup = self._build_tuple(fullname)
  File "/home/user/code/mitogen-master/mitogen/master.py", line 1087, in _build_tuple
    for name in self._finder.find_related(fullname)
  File "/home/user/code/mitogen-master/mitogen/master.py", line 959, in find_related
    names = self.find_related_imports(name)
  File "/home/user/code/mitogen-master/mitogen/master.py", line 910, in find_related_imports
    modpath, src, _ = self.get_module_source(fullname)
  File "/home/user/code/mitogen-master/mitogen/master.py", line 858, in get_module_source
    tup = method.find(fullname)
  File "/home/user/code/mitogen-master/mitogen/master.py", line 538, in find
    path = loader.get_filename(fullname)
  File "/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/ansible/utils/collection_loader/_collection_finder.py", line 516, in get_filename
    raise ValueError('this loader cannot find files for {0}, only {1}'.format(fullname, self._fullname))
ValueError: this loader cannot find files for ansible.plugins, only ansible_collections.ansible.builtin.plugins
[mux  49590] 18:58:01.586228 D mitogen.io: Waker(fd=6/8).defer() [immediate]

Which leads to this error:
The full traceback is:
Traceback (most recent call last):
  File "/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/ansible/executor/task_executor.py", line 157, in run
    res = self._execute()
  File "/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/ansible/executor/task_executor.py", line 630, in _execute
    result = self._handler.run(task_vars=vars_copy)
  File "/home/user/code/mitogen-master/ansible_mitogen/mixins.py", line 146, in run
    return super(ActionModuleMixin, self).run(tmp, task_vars)
  File "/home/user/tmp/ansible-2.13/lib/python3.10/site-packages/ansible/plugins/action/gather_facts.py", line 100, in run
    res = self._execute_module(module_name=fact_module, module_args=mod_args, task_vars=task_vars, wrap_async=False)
  File "/home/user/code/mitogen-master/ansible_mitogen/mixins.py", line 376, in _execute_module
    self._set_temp_file_args(module_args, wrap_async)
  File "/home/user/code/mitogen-master/ansible_mitogen/mixins.py", line 355, in _set_temp_file_args
    self._connection.get_good_temp_dir()
  File "/home/user/code/mitogen-master/ansible_mitogen/connection.py", line 832, in get_good_temp_dir
    self._connect()
  File "/home/user/code/mitogen-master/ansible_mitogen/connection.py", line 854, in _connect
    self._connect_stack(stack)
  File "/home/user/code/mitogen-master/ansible_mitogen/connection.py", line 801, in _connect_stack
    dct = mitogen.service.call(
  File "/home/user/code/mitogen-master/mitogen/service.py", line 126, in call
    return call_context.call_service(service_name, method_name, **kwargs)
  File "/home/user/code/mitogen-master/mitogen/core.py", line 2314, in call_service
    return recv.get().unpickle()
  File "/home/user/code/mitogen-master/mitogen/core.py", line 977, in unpickle
    raise obj
mitogen.core.CallError: builtins.ModuleNotFoundError: The Mitogen master process was unable to serve 'ansible_mitogen.target'. It may be a native Python extension, or it may be missing entirely. Check the importer debug logs on the master for more information.
  File "<stdin>", line 3698, in _dispatch_one
  File "<stdin>", line 3685, in _parse_request
  File "<stdin>", line 682, in import_module
  File "<stdin>", line 1521, in load_module

fatal: [server]: FAILED! => {}

MSG:

Unexpected failure during module execution.

This will likely be fixed by https://github.com/mitogen-hq/mitogen/pull/933 (since I see similar errors in the CI logs).

Yiou shouldn't have been able to even attempt it with ansible-core 2.13, using that revision. It should have been prevented by this code https://github.com/mitogen-hq/mitogen/blob/89c0cc94d16218e2647bb8bb32b011231def0fd7/ansible_mitogen/loaders.py#L50-L83.
Did you make any modifications to you copy of mitogen?

Did you make any modifications to you copy of mitogen?

Yes

duplicate of #933


Upload Privacy Manifest

Hello,
At WWDC23 Apple announced that apps and SDKs that make use of certain "required reason" APIs etc will need to provide a privacy manifest.
Does QRCode need to include this manifest?
Is this update on the roadmap for the team? I appreciate that enforcement won't happen until Spring 2024 but I wanted to make contact so that we can plan our app releases to take this into account.
Here are some useful references:
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
https://developer.apple.com/videos/play/wwdc2023/10060/
Thanks

Hey @harshil-vyas08,
Privacy manifests were added in 18.2.0. You can find them in the Sources/ subfolders (one for each target)
See:
• https://github.com/dagronf/QRCode/blob/main/Sources/QRCode/PrivacyInfo.xcprivacy
• https://github.com/dagronf/QRCode/blob/main/Sources/qrcodegen/PrivacyInfo.xcprivacy
• https://github.com/dagronf/QRCode/blob/main/Sources/QRCodeDetector/PrivacyInfo.xcprivacy

@harshil-vyas08 did that answer your question?

Closing due to lack of feedback


Not showing intermediate values when used with stack

Hi,
first let me thank you for this amazing tool. Regarding the quicksort example,
if I use this inside a stack setup the intermediate values like lt, gt are not shown.
With cabal they will be shown. Is this a matter of configuration or
is it not possible to show the intermediate values inside a stack setup?

I don't think stack vs cabal will make any difference, unless you are changing version? I assume you are referring to stack setup as the Stack package management tool?

I did not used stack setup, I created a new project with the stack new command and tried it with ghci version 8.0.2 (resolver lts-9.23) and ghci 8.2.2 (lts-11.9) and in this cases I do not get displayed gt, lt, x and xs but the call stack is displayed.

I confirm I see the same thing as you do, and furthermore I see it with the latest version combined with GHC 8.2. My guess is something changed and you no longer get the intermediates? Not really sure - I'm not using this package actively at the moment so will leave it for a coauthor to look at - but it might be a reasonable wait...


Revamping of the user interface

Proposal for a revamping of the user interface (much cleaner than the first PR).

Thank you for this PR! The design looks really clean. I have to trust your CSS, but what I'm seeing impresses me.
A few comments on the code that I've made directly on the separate commits (also thank you for that, the splitting is really nice and helped me to review your changes a lot). Are you willing to address them? If not, I can merge your PR and take care of them myself later. Cheers!

Thank you for the changes @AwYiss ! Is there anything else you wanted to change, or should I merge your PR now?

(I am asking because maybe you wanted to have a look at the brand new Emails section, which might need some changes as well?)

I noticed some display issues on mobile. Fixing them right now.

Nice :+1:
What about the menu in mobile mode? Will it be easier to handle?

FYI, the last commit fixes the following issues in mobile display:

wells not stacking ;
title in the mobile navbar having different font and size than the title in the desktop navbar
list of operations overflowing ;
menu and content not stacking in the settings section ;
menu not responsive in the settings section.

I also changed the email section icons to stay in line with my recent changes.

@ZeHiro : which menu are you refering to?

@AwYiss
In mobile mode, the main menu (left side in desktop mode) is hidden behind a burger icon. In the current version, switching between accounts or "pages" is quite hard (don't no why, but it seems the "clickable zone" is small)

Well I did some testing on my side and the mobile menu seems to be working fine (I didn't compare with the pre-revamped UI, though).

Nice then. :)

Thank you @AwYiss. I need to test on my mobile and then I'll merge it. If you're willing to address the two aria-label nits and squash together your last two commits, that'd be great ;)

Wow, you manage to fix #103, it seems! Cheers

Looks great! Thank you for sticking, and don't hesitate to send other PR like this, or even smaller ones ;)
That being said, I think I am going to split the frontend files into several smaller ones, as they tend to get a big fat, these days.

I set up a Trello board to keep track of all the small UI issues/improvements that didn't make it in this PR : https://trello.com/b/KlNwlofs (work in progress).


Added Java Anagrams Finder

Hey there thanks for the contribution. Would be great if you could star the repo so that it will be helpful for future contributors also. Thanks!


Keep file open even when moved from outside

VSCode Version: Version 1.13.1
OS Version: macOS 10.12.5 (16F73)

When a file gets moved on the file system without vscode performing the moving action directly, for example with git mv in the built-in Terminal, the file in the current workspace is closed. Can the editor keep track of the file and follow it, without closing it?
Steps to Reproduce:

create a file, open it, and save it
from the built in terminal, move the file to another name, or to another folder while keeping the same file name.

Reproduces without extensions: Yes

@Tyriar fyi this is an example where we could maybe leverage the nsfw file watcher with the move event.

Yes we could probably do that, but the new file watcher only fires the rename event when the file is renamed/moved in the same directory.


Show stable inscription sequence number when listing inscriptions (both wallet and website)

Show the number of the inscription as shown on the website when listing inscriptions from the wallet.
Planning to work on this.

One concern with surfacing the inscription number right now is that inscription numbers depend on knowing all inscriptions before a given inscription, and when we update the protocol, there will be new inscriptions which old clients ignore, which will give different clients a different view of inscription numbers.
So for example, we haven't made a endpoint that lets you look up inscriptions by number, because those URLs might be unstable.
So given that numbers are unstable, should we surface them in the CLI?

As just discussed - having a stable sequence numbering scheme would be high value and should be doable. We need to make sure to also count inscriptions that are invalid from a perspective of the current client version to make this stable across future upgrades.
We should get the multiple inscriptions per transaction changes implemented before working on this issue.

Executive decision by @casey to keep existing numbers stable: https://twitter.com/rodarmor/status/1626621385618628608
Details to be worked out.

Where can I find details about the original bug?

I think this ship has sailed in the sense that people are attached to the existing inscription numbers, so in true Bitcoin fashion, we now how to work around our past mistakes.
Context:
1. The degens at rug radio like stability: https://twitter.com/rodarmor/status/1626620947691356161

2. Inscription with perfect number that would change: https://ordinals.com/inscription/8d740dbfeb7da687b772dc343848b933dfecb3c29b16891c77df2e2c587097fbi0

We are now committed to the existing numbers. New priorities:
* Fixing the original bug

* Hard-coding the hidden inscriptions by inscription id so that when the bug is fixed, those specific inscriptions stay hidden

* Surfacing the hidden ordinals one day as an easter egg, maybe as nega inscriptions with negative numbers that count down from 0.

Where can I find details about the bug?

I think this ship has sailed in the sense that people are attached to the existing inscription numbers, so in true Bitcoin fashion, we now how to work around our past mistakes.
Context:
1. The degens at rug radio like stability: https://twitter.com/rodarmor/status/1626620947691356161

2. Inscription with perfect number that would change: https://ordinals.com/inscription/8d740dbfeb7da687b772dc343848b933dfecb3c29b16891c77df2e2c587097fbi0

We are now committed to the existing numbers. New priorities:
* Fixing the original bug

* Hard-coding the hidden inscriptions by inscription id so that when the bug is fixed, those specific inscriptions stay hidden

* Surfacing the hidden ordinals one day as an easter egg, maybe as nega inscriptions with negative numbers that count down from 0.

Where can I find details about the bug?

I think this ship has sailed in the sense that people are attached to the existing inscription numbers, so in true Bitcoin fashion, we now how to work around our past mistakes.
Context:
1. The degens at rug radio like stability: https://twitter.com/rodarmor/status/1626620947691356161

2. Inscription with perfect number that would change: https://ordinals.com/inscription/8d740dbfeb7da687b772dc343848b933dfecb3c29b16891c77df2e2c587097fbi0

We are now committed to the existing numbers. New priorities:
* Fixing the original bug

* Hard-coding the hidden inscriptions by inscription id so that when the bug is fixed, those specific inscriptions stay hidden

* Surfacing the hidden ordinals one day as an easter egg, maybe as nega inscriptions with negative numbers that count down from 0.

Is this bug related to https://github.com/casey/ord/issues/1841 or is it a different issue? 🤔


Add Downloader::content_length(&self)

And make request at Downloader::new(). Resolves #6.

I published v0.9 with your changes. See<PHONE_NUMBER>7b34335e5d6c49e551742197e95ba5.


Export cronjob

Exporting the cronjob command for use without websync

@ohaal can you clearify? Do you want the rsync command or the whole cronjob command so you can use it in for instance crontab?

cronjob would contain both so that should be enough for most uses.


[Improve] Using code style & quality rules to improve org.apache.streampark.console.base.util package of streampark-console module.

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Using code style & quality rules to improve org.apache.streampark.console.base.util package of streampark-console module.
Usage Scenario
No response
Related issues
https://github.com/apache/incubator-streampark/issues/2986
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@wolfboys @RocMarshal Roc

Please see https://github.com/apache/incubator-streampark/issues/2986 for more details about change and adjust the current issue title.

This issue was deprecated.


Add nvim-treesitter-textsubjects

I've added to the syntax category to the other nvim-treesitter plugins as I think they fit. Alternatively, it could be put under "Editing-Support".

Thank you!


Error does not implement std::error::Error

Several error handling libraries in the ecosystem like anyhow depend on this.
Happy to send a PR for this!

I would ack that PR

Nvm, was already fixed in https://github.com/bitcoindevkit/rust-electrum-client/commit/efdc7d224354384359cf7615ad56c2b86c981274.


Removed umbraco-marketplace tag from core project

Thanks for marking up this package for inclusion in the Umbraco marketplace.  I noticed though we were bringing in two entries - on for the installable component of the package, and one for this "core" project, which likely shouldn't be listed.  So I've suggested this update so we can just include the main package that developers will usually choose to install.

Ah I understand!


Cannot run analysis for "spain valencia"

Bug report

Trying to run an analysis for the city of Valencia, in Spain, in the Valenciana community.
Current Behavior

It seems like the analysis is failing because the city is composed of several polygons.
❯ poetry run bna run spain valencia
/Users/rgreinhofer/projects/PeopleForBikes/brokenspoke-analyzer/.venv/lib/python3.10/site-packages/geopandas/_compat.py:112: UserWarning: The Shapely GEOS version (3.10.2-CAPI-1.16.0) is incompatible with the GEOS version PyGEOS was compiled with (3.10.1-CAPI-1.16.0). Conversions between both will be slow.
  warnings.warn(
2022-08-07 10:24:00.967 | DEBUG    | brokenspoke_analyzer.core.analysis:retrieve_city_boundaries:125 - Query used to retrieve the boundaries: valencia, spain
/Users/rgreinhofer/projects/PeopleForBikes/brokenspoke-analyzer/brokenspoke_analyzer/core/analysis.py:130: UserWarning: Column names longer than 10
characters will be truncated when saved to ESRI Shapefile.
  city_gdf.to_file(output / f"{slug}.shp")
[10:24:01] Boundary files ready.                                                                                cli.py:100
           OSM Region file downloaded.                                                                                cli.py:106
           OSM file for valencia ready.                                                                                cli.py:115
2022-08-07 10:24:01.834 | DEBUG    | brokenspoke_analyzer.core.processhelper:run:13 - cmd='docker run --rm -e PFB_SHPFILE="/data/valencia-spain.shp" -e PFB_OSM_FILE="/data/valencia-spain.osm" -e PFB_STATE=al -e PFB_STATE_FIPS=91 -e NB_OUTPUT_DIR=/data -e PFB_DEBUG=1 -v "/Users/rgreinhofer/projects/PeopleForBikes/brokenspoke-analyzer/data":/data azavea/analyzer:13-3.1'
"docker run --rm -e PFB_SHPFILE="/data/valencia-spain.shp" -e PFB_OSM_FILE="/data/valencia-spain.osm" -e PFB_STATE=al -e PFB_STATE_FIPS=91 -e
NB_OUTPUT_DIR=/data -e PFB_DEBUG=1 -v "/Users/rgreinhofer/projects/PeopleForBikes/brokenspoke-analyzer/data":/data azavea/analyzer:13-3.1" failed to
execute with error code 1 for the following reason:
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
initdb: warning: enabling "trust" authentication for local connections
You can change this by editing pg_hba.conf or using the option -A, or
--auth-local and --auth-host, the next time you run initdb.
NOTICE:  empty string is not a valid password, clearing password
2022-08-07 15:24:36.862 UTC [14] LOG:  starting PostgreSQL 13.7 (Debian 13.7-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6)
10.2.1 20210110, 64-bit
2022-08-07 15:24:36.868 UTC [14] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2022-08-07 15:24:36.868 UTC [14] LOG:  listening on IPv6 address "::", port 5432
2022-08-07 15:24:36.872 UTC [14] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2022-08-07 15:24:36.900 UTC [276] LOG:  database system was shut down at 2022-08-07 15:24:36 UTC
2022-08-07 15:24:36.921 UTC [14] LOG:  database system is ready to accept connections
+ '[' ./scripts/import.sh = ./scripts/import.sh ']'
+ '[' /data/valencia-spain.shp = --help ']'
+ '[' -z /data/valencia-spain.shp ']'
+ ../import/import_neighborhood.sh /data/valencia-spain.shp 91
+ '[' ../import/import_neighborhood.sh = ../import/import_neighborhood.sh ']'
+ '[' /data/valencia-spain.shp = --help ']'
+ '[' -z /data/valencia-spain.shp ']'
+ NB_BOUNDARY_FILE=/data/valencia-spain.shp
+ NB_STATE_FIPS=91
++ mktemp -d
+ NB_TEMPDIR=/tmp/tmp.KM5HwdqedT/import_neighborhood
+ mkdir -p /tmp/tmp.KM5HwdqedT/import_neighborhood
+ NB_BOUNDARY_BUFFER=2680
+ update_status IMPORTING 'Importing boundary shapefile'
+ echo 'Updating job status: IMPORTING' 'Importing boundary shapefile'
+ '[' -n '' ']'
+ import_and_transform_shapefile /data/valencia-spain.shp neighborhood_boundary 4326
+ IMPORT_FILE=/data/valencia-spain.shp
+ IMPORT_TABLENAME=neighborhood_boundary
+ IMPORT_SRID=4326
+ echo 'START: Importing neighborhood_boundary'
+ shp2pgsql -I -p -D -s 4326 /data/valencia-spain.shp neighborhood_boundary
+ psql -h localhost -U gis -d pfb
Field bbox_north is an FTDouble with width 24 and precision 15
Field bbox_south is an FTDouble with width 24 and precision 15
Field bbox_east is an FTDouble with width 24 and precision 15
Field bbox_west is an FTDouble with width 24 and precision 15
Field place_id is an FTDouble with width 18 and precision 0
Field osm_id is an FTDouble with width 18 and precision 0
Field lat is an FTDouble with width 24 and precision 15
Field lon is an FTDouble with width 24 and precision 15
Field importance is an FTDouble with width 24 and precision 15
Shapefile type: Polygon
Postgis type: MULTIPOLYGON[2]
+ shp2pgsql -I -d -D -s 4326 /data/valencia-spain.shp neighborhood_boundary
+ psql -h localhost -U gis -d pfb
Field bbox_north is an FTDouble with width 24 and precision 15
Field bbox_south is an FTDouble with width 24 and precision 15
Field bbox_east is an FTDouble with width 24 and precision 15
Field bbox_west is an FTDouble with width 24 and precision 15
Field place_id is an FTDouble with width 18 and precision 0
Field osm_id is an FTDouble with width 18 and precision 0
Field lat is an FTDouble with width 24 and precision 15
Field lon is an FTDouble with width 24 and precision 15
Field importance is an FTDouble with width 24 and precision 15
Shapefile type: Polygon
Postgis type: MULTIPOLYGON[2]
Unable to convert data value to UTF-8 (iconv reports "Invalid or incomplete multibyte or wide character"). Current encoding is "UTF-8". Try "LATIN1"
(Western European), or one of the values described at http://www.postgresql.org/docs/current/static/multibyte.html.
+ psql -h localhost -U gis -d pfb -c 'ALTER TABLE neighborhood_boundary ALTER COLUMN geom             TYPE geometry(MultiPolygon,32630) USING
ST_Force2d(ST_Transform(geom,32630));'
2022-08-07 15:24:43.351 UTC [353] ERROR:  relation "neighborhood_boundary" does not exist
2022-08-07 15:24:43.351 UTC [353] STATEMENT:  ALTER TABLE neighborhood_boundary ALTER COLUMN geom             TYPE geometry(MultiPolygon,32630) USING
ST_Force2d(ST_Transform(geom,32630));
ERROR:  relation "neighborhood_boundary" does not exist
2022-08-07 15:24:43.556 UTC [14] LOG:  received fast shutdown request
2022-08-07 15:24:43.559 UTC [14] LOG:  aborting any active transactions
2022-08-07 15:24:43.570 UTC [14] LOG:  background worker "logical replication launcher" (PID 285) exited with exit code 1
2022-08-07 15:24:43.573 UTC [278] LOG:  shutting down
2022-08-07 15:24:43.678 UTC [14] LOG:  database system is shut down
.

it may actually be because of the display_name column.
The value for valencia is "Valencia, Comarca de València, Valencia, Valencian Community, Spain'" which contains a UTF-8 character.


add option to disable crawling the global scope

This PR adds an option to disable the crawling of the global scope.
I ran into issues because lave was unexpectedly adding references like process.mainModule.children.1.children.0.children.5.children.3.children.0.exports.arguments.0 to the generated code. I assume this was a side-effect of using babel-register in my code, but even in other scenarios (when transferring data between systems) I think we can't assume a shared global context and need an option like this.

rather than provide a boolean, would you be cool with providing a default global object? right now i just slurp in the whole global context, but perhaps that would be better done in a vm context that is limited to  the standard JS globals like Array and friends?

+1


add a download button for the database entry also in the entry page itself, so that if a user is interested in one particular stock, can just click on the link on the online advice, and then download the entry content, without going to the list of stocks. (dowload csv for cach scenarios and add download button in individual entry)

@cmspinto @LApetre


Version 1.0.3 only partially extracts my archive

I just found out that upgrading the tar.gz package to 1.0.3 broke the extracting functionality of my app.
It starts extracting and does a partial job, but it only extracted a small amount of files (in my case 47MB of 3GB). No errors are displayed.
I have tried to create a test case for it but I haven't yet succeeded to reproduce it with another archive. I can't share the archive I'm working on as it contains sensitive data. All I know is that it reverting to 1.0.2 made it work again.

Same issue here, looks like it doesn't extract file above a certain size

+1
Also downgraded to 1.0.2 after noticing that – sometimes, not always – extracting an archive failed (1.0.5).

Same issue here.


nixos/tor: allow AF_NETLINK address family

Motivation for this change
Tor attempts to detect what external IP address a machine is using by
listing addresses on all network interfaces on the system. This listing
is done using getifaddrs(3), which relies on netlink in order to get
IPv6 address information.
This change fixes Tor not finding the relay's IPv6 address unless
explicitly configured via either an ORPort directive or via DNS
resolution of the machine hostname.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/402


Cache the currently loaded Scenario, instead of re-reading it from the filesystem or (shudder) web. #377

@michaelkirk, any thoughts on the odd lifetime of scenario? I considered carefully cleaning it up, similar to the calls of app.set_prebaked(None), but I think this way is a little simpler.

Not sure if I'm missing something, but this seems straight forward.
Is your concern that,  since it's now globalish state, you could access app.primary.scenario even though it's no longer the "current" scenario?
I suppose we could lock down the API more - like make it private, and have the getter verify the name, or some kind of "get cached else run this block to fetch it" API.
Or you could trust your programmer to not make that mistake. It's only used in this one spot (for now anyway).

Is your concern that, since it's now globalish state, you could access app.primary.scenario even though it's no longer the "current" scenario?

Yeah, exactly. I think the current approach is fine for now. But it makes me re-evaluate the approach of having globalish state in App at all. Things like Map and DrawMap being in there make sense; legitimately pretty much every state of the game will use that. But prebaked data and the scenario are only valid under SandboxMode and its children. suspended_sim is another good example -- it only makes sense once you jump into edit mode. I initially stuck it in EditMode and plumbed it to child states, but there wasn't a natural way to pass it between states there. Logically, exactly one state owns it at a time. If each state has it as a field, then when doing Transition::Push, you actually have to make a full clone, since fn event(&mut self doesn't consume self. One hack around that is wrapping it in an Option so you can do .take(), but then the State technically has this weird broken state, where somebody accidentally takes the suspended sim, but doesn't immediately destruct the state.
In other words, we have at least 3 lifetimes for game state:

the stuff in App that should pretty much last the whole program (maybe getting overwritten when a new map is loaded)
local fields in a particular State
this in-between stuff that's scoped to a few States

I don't think there's anything we should change now, just wanted to get an opinion how maintainable this third category is


[Bazel CI] Error: no native function or rule 'java_proto_library'

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4264#019323b6-0235-4d23-9341-d5deb434f9e4
Platform: Ubuntu
Logs:
Error: no native function or rule 'java_proto_library'

Culprit:
Steps:
git clone https://github.com/bazelbuild/rules_android_ndk
git reset cb776db8e671084669f141d2003e1b61c1a7d21b  --hard
export USE_BAZEL_VERSION=471aca124968977ecf1920711811c37ce19c1aa7
bazel build --incompatible_disallow_empty_glob --incompatible_enable_android_toolchain_resolution --android_platforms=//:arm64-v8a,//:x86 --enable_bzlmod=False --enable_workspace=True  //java/com/app:app

CC Greenteam @fweikert

This will be fixed in the near future, once rules_android 0.6 is out and we can bump up other dependencies simultaneously.


ci(cacti) - Proof of concept using lerna in matrix job

Proof of concept to demonstrate a matrix test job which can be used for all cacti packages.
Intention is to simplify monorepo ci by pushing package logic to the individual packages and make use of the lerna toolset to identify changes and run a shared set of lifecycle targets defined in the package, for instance:

test
build-docker
deploy
etc

This way, CI can be agnostic to the internals of each package, simplifying logic considerably and ensuring new packages do not further complicate CI.
The existing ci.yaml file can be refactored via a script to ensure no changes are lost, please see included parsing file for an example python script which (for now) just reports which jobs are redundant.  This script can be a base for pushing logic to the component packages by adding commands to the package.json.  The 80+ ci.yaml file jobs really follow only 5 or 6 basic patterns which can be handled by parsing.
Since the branch is a proof of concept and not for commit, the pull request requirements are ignored.
Please see here for an example output CI:
https://github.com/jenniferlianne/cacti/actions/runs/9615156170
Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Closing proof of concept PR.


online ldap test server

I am a linux developer and I know how to set up windows server to start active directory and I tried to find a way to test it.
Do you think this can be suitable for testing?
https://www.forumsys.com/2022/05/10/online-ldap-test-server/

Hi @vahidalvandi,
It depends on the type of testing you’d like to perform.
If you’re looking for simply connectivity testing, then that service will work fine.
If you’re looking for more in-depth testing, such as creation of objects, I’d recommend using LdapRecord-Laravel that includes a suite of test tools:
https://ldaprecord.com/docs/laravel/v2/testing
If you want to test against a real LDAP server, you can use an OpenLDAP docker image that you can get up and running inside of GitHub actions. I use this to test LdapRecord against a real LDAP server:
https://github.com/DirectoryTree/LdapRecord/blob/master/.github/workflows/run-integration-tests.yml

I wish you could show the same method that you test yourself in the form of a video for us Linux, the things we want to test Windows..

I think that’s a good idea, but there just isn’t enough of a demand for it for me to spend the time in making such a production.
You can take a look at some of the integration tests here:
https://github.com/DirectoryTree/LdapRecord/tree/master/tests/Integration
I also have written some other tests in the past with the LdapRecord directory emulator here:
https://github.com/DirectoryTree/Watchdog/blob/master/tests/WatchdogRunTest.php
Hope this helps!


Don't let Qt require a minimum kernel of 3.17+ (even if we're building against headers satisfying that requirement)

Fixes #38832.
Fixes use of qt 5.10 on many distributions not shipping 3.17 or newer.
I believe even kernels with these features --if such exist-- won't work since
the check is specifically for version and not for the features in question.
This is especially "unfortunate" since libraries requiring versions newer
than what is available are silently overlooked during searches,
resulting in messages indicating that "libFoo.so" cannot be found
(instead of "libFoo.so found but requires kernel X.Y, you're running A.B" or whatever).
As indicated in the commit, someone checking this situation would be appreciated :).
And to be completely clear, this compatibility is achieved by disabling use of
the renameat2 and getentropy syscalls (even if they are supported);
this does not seem problematic to me but is something to be considered.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

I'm confused. The code at http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/io/qfilesystemengine_unix.cpp?h=dev first tries renameat2 and then if that fails due to not being supported, falls back to the same code that would be executed if renameat2 was disabled at compile time. What does strace say for that renameat2 call?

Ah now I get what you mean:
$ file result/lib/libQt5Core.so.5.10.1
result/lib/libQt5Core.so.5.10.1: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /nix/store/27x7pinqdsl9f3rpbm8bsszd9fhwq266-glibc-2.27/lib/ld-linux-x86-64.so.2, for GNU/Linux 3.17.0, stripped
                                                                                ^^^^^^^^^^^^^^^^^^^^

Well that's crazy. I wonder what's causing the kernel version tag to be emitted.

If no libc wrapper is detected (not avail in our glibc, unsure what version adds it), but SYS_renameat2 is defined (new kernel headers), qt emits its own syscall wrapper and sets kernel version requirement (non-standard, glibc-only).  Handling ENOSYS instead might be better, but that's not really the point. The real problem is that our Qt is imposing a kernel requirement unexpectedly and significantly newer than we currently require.
I also found the logs a bit confusing at first, since they report that checks for these functions (renameat2, etc.) fail but don't mention they'll be invoking them as syscalls and whatnot.
I didn't track down where the version is set, would be curious how they manage to tie that into their build system.  (understanding this isn't important, just curious)

IMHO this should be backported to 18.03 as well. Perhaps sent to staging-18.03 first, if we're doing that? :)

Qt emits its own syscall wrapper and sets kernel version requirement (non-standard, glibc-only)

Right, that should be reported as a Qt bug. There is no reason to do anything like that, checking for ENOSYS is the way to handle this.
But yes, in the meantime, let's merge this.

Applied in 39696b6d56fbe93834a8997057b3507e8cd2a234. I added some comments.

Should we wait to hear from @ttuegel?

No :wink: applying this was the right thing to do. Is this backported to 18.03 yet? (It doesn't look like it, to me.) If not, I'm happy to take care of it.

@ttuegel if it's no trouble, please do so if you haven't already!
Also can we pick this to master too? :3. Or do we think staging will be merged soon-ish?

@ttuegel Could this be backported to 18.03?

Applied in a7b6a9199e8db54a798d011a0946cdeb72cfc46b.


[Bug] Performance: Slugify calculations causing significant slowdown in medium/large document initial paste and editing

Initial checklist

[X] I agree to follow the code of conduct
[X] I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions
@milkdown/crepe 7.5.7
Link to runnable example
No response
Steps to reproduce
Create or open a large document (~150kb)
Try to paste content or edit any node in the document
Open performance tab in dev tools to observe the slugify method calls
Expected behavior
Document loading and editing should be fast and responsive
Slugify operations should only run when necessary (e.g., for headings)
Performance should not significantly degrade with larger documents
research:
An important note - these method calls were occurring when editing any node, not just headings. For testing, I patched the library's slugify method (@sindresorhus/slugify/index.js) so that instead of its calculations, it would simply return the string 'slugify'. And this immediately solved 2 problems - the initial document loading (paste) happened instantly instead of taking 15 seconds. Document editing began to occur without noticeable delays.
Actual behavior
Initial document loading (paste for 150kb markdown) takes around 15 seconds (MacBook pro M1)
Editing has noticeable delays
Performance tab shows excessive calls to @sindresorhus/slugify/index.js
Slugify is being called on every node change, not just headings
When patched to return a static string 'slugify', performance immediately improves
Document loading becomes instant
Editing becomes responsive without delays
Runtime
Chrome
OS
macOS
Build and bundle tools
Vite

This fixed the issue:
import { headingIdGenerator } from '@milkdown/preset-commonmark';
// ...
  this.crepe.editor
    .config(ctx => {
      ctx.set(headingIdGenerator.key, value => value.textContent);
      // ...

Slugify significantly impacts performance, what was the idea behind using it? Why are heading IDs being regenerated in the document on every keystroke, and how are these IDs being used?


Create CODE_OF_CONDUCT.md

i think this would be nice to have

I totally agree with the code of conduct. However, this repo is not for a community. The repo hosts a personal collection of clarity contracts.


[Request]See other players mass

This can be done easily with Agar Expose.

How? And add a option to turn on/off

Ik now

@Lukkez if you have it done make a pull request to add it, don't open/close issues for nothing.

Ok, it's much easy but ok


Fixed spacing issue with note at top, title text and YouTube video

OPS Build status updates of commit 1894e77:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 1894e77:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 1894e77:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holograms-101.md
:warning:Warning
View
Details

mixed-reality-docs/holograms-101.md

Line 119: [Warning] Illegal link: pair it with Visual Studio -- missing bookmark. The file using-visual-studio.md doesn't contain a bookmark named pairing-your-device-hololens.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature]: New multi pane layout

This task is about the new multi pane layout where each entity can be opened/viewed in tab like view.
Sub task/things to consider under this task would include the following

Back button design

Remove existing back buttons from action pane(api/datasource/query)
How will browser back button behave here

Sidebar

Settings
Explorer
Datasources
Library (discuss with FE coders sooner rather than later)
Search (keep it a button, and then make it a panel later)

Tabs
Dynamic property pane
create action pane
Performance testing
What to show when a user opens an app for the first time
Onboarding and signposting needs to be considered for the new layout.
Help is the same as the ? icon in the editor
documentation screenshots need to updated, and if required rewording (and probably figure a way of automating for this)

won't fix - project cancelled


Preview LinkByIDs

As a user, I want to be able to preview LinkByID hyperlinks, and access the object linked to within the workbench instead of visiting the external resource.

Currently, LinkByIds will result in hyperlinks to external resources (e.g attack.mitre.org) even if the corresponding object is within the Workbench. Since we have the ATT&CK ID of the LinkByID destination, we should be able to instead link to the page of the workbench corresponding to the LinkByID, even if the data in the external_references would direct us to an external resource.
In addition, we should allow the user to preview the object at the other end of the LinkById without leaving the page, either via dialog or via popover:

If the object is not in the knowledge base, the popover should tell the user that the corresponding object could not be found and the link will lead them to the original location of the object.

Superseded by #280


[BUG] - Error in GraphLQL data

Briefly describe the bug.
For space "xeo4.eth" , private is None and hence it results in an error when returning results
How can we reproduce the bug?

Go to https://hub.snapshot.org/graphql
Run the below query:

query Spaces {
  spaces(
    orderBy: "followersCount",
  where:{
    id:"xeo4.eth"
  }
    orderDirection: asc

  ) {
    private
  }
}

see error:

{
  "errors": [
    {
      "message": "Boolean cannot represent a non boolean value: \"true\"",
      "locations": [
        {
          "line": 11,
          "column": 5
        }
      ],
      "path": [
        "spaces",
        0,
        "private"
      ]
    }
  ],
  "data": {
    "spaces": [
      {
        "private": null
      }
    ]
  }
}

What is the expected behaviour?
There should be no error. Basically, a default value needs to be set.
Can you attach screenshots?
No response
Can you provide your device specific details below?
GraphQL API hosted at : https://hub.snapshot.org/graphql?

@imshashank This should be true instead of "true" we've run some code to fix this error, it should work fine now.

Works now, thanks for fixing.


BE button enhancement

The BE button should consist of all the branches like EE, ME, CE which is right bow inactive
Assign me this issue under GSSOC'23 label

I was thinking to have mete! To discuss on further improvements. Please join the channel!.


Rust/Rust_rayon: use indexes of tag values rather than strings

This means we can implement "look up the posts for this tag" as indexing into a list, rather than a hashmap lookup.

This is now slower than the latest version so I'm closing this. Feel free to reopen if your test shows otherwise


listrow  module not found

"react-native": "0.61.5",
"teaset": "^0.7.1"，
bundling failed: Error: Unable to resolve module react-native/Libraries/Pressability/Pressability.js from node_modules/teaset/components/ListRow/TouchableOpacity.js: react-native/Libraries/Pressability/Pressability.js could not be found within the project.

同样的错误  如何解决呢

Error: Unable to resolve module `react-native/Libraries/Pressability/Pressability.js
react-native-cli: 2.0.1
react-native: 0.61.4
应该没法解决 组件里面写的依赖

yeahh I also found it like that..
please repair this bugs, because it really helped me, Thanks.

Is this fixed? I am getting the same problem and I am unable to run the project
@finghtingjie @csdwd @silentzone @royhanrahim
Thanks in advance!


Leaderboard: hit the API

In this opportunity, I did the following:

Create a new game using the API.
Implement the "Refresh" button that will get all scores for a game created by me from the API (receiving data from the API and parsing the JSON).
Implement the form "Submit" button that will save a score for a game created by you (sending data to the API).
Use arrow functions instead of the function keyword.
Use async and await JavaScript features to consume the API.

Thank you for your suggestions, all are included in this new version. 👍🏼


Move module_name parsing into the Parser

Coverage increased (+0.3%) to 24.906% when pulling 62da75ac94256d4a5ff469f2ed8960aed3902614 on dhollinger:module_endpoint_parser into 4f64fa07a8c8b1273e13374f512c57203fa84877 on voxpupuli:master.

Coverage increased (+0.3%) to 24.906% when pulling 292786ab2ef1d72976c7d671c900e1afbebee565 on dhollinger:module_endpoint_parser into 4f64fa07a8c8b1273e13374f512c57203fa84877 on voxpupuli:master.

Coverage increased (+0.3%) to 24.904% when pulling 9c40195995320aec86761db8ed40f3f5e9377e25 on dhollinger:module_endpoint_parser into 4f64fa07a8c8b1273e13374f512c57203fa84877 on voxpupuli:master.

Coverage increased (+0.3%) to 24.904% when pulling ce2723bdcc56de7061b4fc6f046b40f0ec8b1d98 on dhollinger:module_endpoint_parser into 4f64fa07a8c8b1273e13374f512c57203fa84877 on voxpupuli:master.


[Bug]: Full names shown incorrect

The full-names shown on the donor list do not match the address they are applied to

fixed here: https://github.com/GoodDollar/GoodCollective/commit/e1825c05914a8e15c369bca736725dfb037f38e5

fixed here: e1825c0

Thanks!

Not fully fixed as it still not maps correctly. Working on that now

@L03TJ3 does this still need QA?

@vldkhh can you verify that this was resolved?

@decentralauren works for me


The notification template for fcm is incorrect

The notification template for FCM provided in the code is incorrect. It fails with error message body is null

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e5b2d7d-fac3-149c-12a9-d0bd80d28838
Version Independent ID: 526fb7f3-49d6-7e0d-f802-f0d718e2ade1
Content: Send localized push notifications to iOS using Azure Notification Hubs
Content Source: articles/notification-hubs/notification-hubs-ios-xplat-localized-apns-push-notification.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@dd09
Thanks for the feedback! We are currently investigating and will update you shortly.

@dd09 The doc that you filed the feedback under appears to be about iOS. Can you please share the URL of the doc that you are referring to so we can investigate it further?
We look forward to your reply.

Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


High RAM usage

This process using lots of ram for messenger and whatsapp... windows 10 x64

"C:\Users\Administrator\AppData\Local\Programs\ferdi\Ferdi.exe" --type=gpu-process --field-trial-handle=1436,16238204240825743630,1749530962674224545,131072 --enable-features=WebComponentsV0Enabled --disable-features=SpareRendererForSitePerProcess --gpu-preferences=KAAAAAAAAADgAAAwAAAAAAAAYAAAAAAAEAAAAAAAAAAAAAAAAAAAACgAAAAEAAAAIAAAAAAAAAAoAAAAAAAAADAAAAAAAAAAOAAAAAAAAAAQAAAAAAAAAAAAAAAFAAAAEAAAAAAAAAAAAAAABgAAABAAAAAAAAAAAQAAAAUAAAAQAAAAAAAAAAEAAAAGAAAA --mojo-platform-channel-handle=1484 --ignored=" --type=renderer " /prefetch:2

Thank you for reporting this. This is a known issue that mostly lies in us using ElectronJS for Ferdi, which is known to be resource-hungry. We are still exploring new ways we can reduce RAM usage from our side over at #62

does franz also have this bug ?

This is not really a "bug". Ferdi is based on chromium, which itself is known for being resource-hungy - Franz, Rambox etc. all have to deal with the same problem.

wow I didn't know it was like that...


LocalDatastoreHelper unable to download Datastore emulator

The Datastore Emulator URL in LocalDatastoreHelper no longer seems to work.
It resolves to this link:
http://storage.googleapis.com/gcd/tools/cloud-datastore-emulator-1.2.0.zip
However, we get the error when trying to access it:
<Error>
AccessDenied
<Message>Access denied.</Message>
Anonymous caller does not have storage.objects.get access to the Google Cloud Storage object.
</Error>

@lnealan @cjwang18 -- fyi, looks like the emulator url works again. Gonna close.


Feature/pages/landing page

resolves #71 .

@bernardbaker Informational carousel looks really cool. A bit confused about the loss of the start-game input fields like phone number / Tik Tok. Also, is this still David's task for this sprint or did you guys realign?

Hi Brandon,
We haven't lost those details.
This is the landing page which has information about the game.
When a visitor clicks the "get started" button. They are navigated to the
"start game" page.
On Sat, 25 Apr 2020, 05:04 un7c0rn<EMAIL_ADDRESS>wrote:

@bernardbaker https://github.com/bernardbaker Informational carousel
looks really cool. A bit confused about the loss of the start-game input
fields like phone number / Tik Tok. Also, is this still David's task for
this sprint or did you guys realign?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/pull/83#issuecomment-619316118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTH6DYVGIDTRK5NIJ2TROJONTANCNFSM4MQJJWXA
.


Added additional information to instructions

Installation doesn't require building the project. The instructions in the current README.md are all you actually need to do if you just want to run the latest build of the mod framework. Maybe split the sections so that there is one for installation and a separate one for building.

So the only step that needs to be removed is the  install_vs2017.bat by double clicking on it*, correct?
I was initially confused, but the instructions don't explain which files need to be included, where to place the files after unzip, or what the mod framework .dll does.
I had to find a video on YouTube which explained instructions, and it said to run the install file.

No. All you need to do is download the zip from AppVeyor which just includes dinput8.dll. That's all you need to run the Mod Framework you do not need to download the repository unless you plan on building it (install_vs2017.bat is only necessary for building the project not installing the prebuilt AppVeyor binary).

Ah OK, thank you for clarifying.
Could we add that to the instructions? I think many people will come here, thinking they have to download and unzip these files as well.


Fixed the opened files regexp to also match files that have type modifiers

I noticed some files didn't appear in the vscode-perforce changelists. This was happening because the opened files are checked against a regexp which was discarding some of the output.
Example from p4 opened:
"//depot/path/to/a/script.sh#99 - edit default change (text+x)"
This was discarded because text+x doesn't match to \w. Replaced \w with [\w\+]+.
Perforce docs for type modifiers: https://www.perforce.com/perforce/doc.current/manuals/cmdref/file.types.html

Nice catch, thanks!


Add more relevant fonts

Description

I would like to add more relevant fonts to the project. @dhruvkb please suggest if I should go for it? I'm new to the project and would like to contribute.
Want to take up?

Yes

@Dishebh this repo only contains fonts that are currently in use in at least one CC project. Before we decide to add more fonts, we should discuss which fonts and why.

@dhruvkb makes sense, thanks for clarifying. Since I'm new to the project and would like to participate as a technical writer under CC, I was naturally looking for some beginner-friendly issues to get started with. As to which font to add and why? I'm not really sure about that and so that's why asked you. Kindly let me know if you feel there's a need to add an extra font, and I would be glad to take up the issue. Feel free to close the issue if you feel there's no need for it now. Thanks!

@Dishebh I appreciate the initiative. Let's ask @panchovm which monospaced font we're finally going with and we can add that to our collection.

For now, the fonts selected solve all content needs. We are using JetBrains Mono for code, in two styles: code big, code normal.

@panchovm @dhruvkb So I have to add JetBrains Mono font to the repo, right?

Yes. Exactly


Plugin extension 'enabled' not respected in OpenAPI config

To Reproduce
Add a plugin extension similar to the following to an OAI spec:
      x-kong-plugin-cors:
        enabled: false
        config:
          origins:
            - "*"
          credentials: false
          preflight_continue: false

Then run inso generate config path/to/file.yml. Type is not important, as both output formats have the same issue.
Expected
Since enabled: false is present, it would either be present and disabled or not present in the generated output at all.
Actual
The same output is generated, regardless of whether enabled is true or false.

Hey 👋🏼, I was just looking into fixing this. I think I have fixed it with my PR #4235. This is my first contribution to insomnia/related packages so let me know if I've done something wrong.

Hi @HarryET, thanks for the PR!

Since enabled: false is present, it would either be present and disabled or not present in the generated output at all.

@Tieske, do you have an opinion on which of these we should go with - present and disabled, vs not present at all?

since this is a valid property for Kong, I think it should be valid to set it in the OAS doc as well. Which then results in the plugin being added to the generated config, with the property set to false.
My 2cts

since this is a valid property for Kong, I think it should be valid to set it in the OAS doc as well. Which then results in the plugin being added to the generated config, with the property set to false.
My 2cts

That sounds good to me too. @HarryET could you please update your PR to still generate the plugin but set the enabled property to false? Once that's done I'll go ahead and review 😊

Okay! Have you got a file I could use to test? @develohpanda

Unfortunately I'm not at a computer right now but I can send one through in the next 24h!

Unfortunately I'm not at a computer right now but I can send one through in the next 24h!

That would be awesome, thanks. I'll try make one myself but if that fails ill wait for yours :)

Hmm, so I've been preparing an input/output example @HarryET, but I think this has actually been fixed somehow already 🤔

Using this input
openapi: 3.0.1
info:
  description: Description
  version: 1.0.0
  title: API
servers:
  - url: 'https://api.insomnia.rest'
x-kong-plugin-cors:
  enabled: false
  config:
    origins:
      - "*"
    credentials: false
    preflight_continue: false
paths:
  /path:
    x-kong-plugin-oidc:
      name: oidc
      enabled: false
      config:
        key_names: [api_key, apikey]
        key_in_body: false
        hide_credentials: true
    get:
      description: 'test'
      responses:
        '200':
          description: OK

I currently get this output
_format_version: "1.1"
services:
  - name: API
    protocol: https
    host: API.upstream
    port: 443
    path: /
    plugins:
      - enabled: false
        config:
          origins:
            - "*"
          credentials: false
          preflight_continue: false
        name: cors
        tags:
          - OAS3_import
    routes:
      - tags:
          - OAS3_import
        name: API-path-get
        methods:
          - GET
        paths:
          - /path$
        strip_path: false
        plugins:
          - name: oidc
            enabled: false
            config:
              key_names:
                - api_key
                - apikey
              key_in_body: false
              hide_credentials: true
            tags:
              - OAS3_import
    tags:
      - OAS3_import
upstreams:
  - name: API.upstream
    targets:
      - target: api.insomnia.rest:443
        tags:
          - OAS3_import
    tags:
      - OAS3_import

Showing that the plugin exists in the final output, but is marked as disabled as per the input OpenAPI spec. Unless I'm mistaken I think we can close this issue and PR!
I really appreciate the time you put into this and I'm sorry we didn't follow-up and close this issue when it was resolved :( If you'd like to find another issue, tag me and I'll double check before you start. Alternatively I can find and good one to start with!


Ensure @noir-lang/types will get published on release

can this be closed?

Closed with https://github.com/noir-lang/noir/pull/2989 per @kobyhallx's advice.


[BUG] Path of the original image is inaccessible on Samsung devices

Hey,
Firstly thank you for the amazing library, it has been quite useful.
I'm working on building a gallery that organizes images by their folders. On most Android devices that I've tested, (assetEntity.originFile).path returns the full-path of the file within the device, which I then use to calculate the parent folder name.
But on Samsung devices, this returns something alone the lines of /data/user/0/package.name.of.myapp/cache/random_name.jpg.
Please find attached screenshot displaying the same issue on the example app within this project.

Maybe I'm using the API in the wrong way. If yes, could you please tell me how I can find the location of a file denoted by an AssetEntity?
Thanks again.

The api in android sdk has changed after androidQ.
The path corresponding to each entity is marked as obsolete and is no longer recommended.
android document

You should not use this method to organize assets.

Thanks for the response CaiJingLong.
I see that RELATIVE_PATH has been added. Is there a way for me access this with the help of flutter_photo_manager?

I can export it as a flutter.
But this property is not valid in iOS.

The 0.5.1-dev.5 add the properties.

Much appreciated!


S3Event Types

Noticed some types where not playing nice so made them more accurate

Thanks for your patience, I just got back from my holiday. This change looks really good, thanks @Ankcorn!

Released under 1.13.0


Missing property state_topic, Property access_key is not allowed, Property rig_name is not allowed

I'm implementing the below code in configuration.yaml but it shows errors.

platform: hacs-minerstat
name: "Thunderbird"
access_key: "samplekey"
rig_name: "Thunderbird"

Erros:
Missing property state_topic
Property access_key is not allowed
Property rig_name is not allowed
@gilsonmandalogo

rig_name needs to be all CAPITAL !!!
dont worry about error reports in the editor, i have them too and it works just fine.


Cannot open load file: No such file or directory, auth-store-pass

I just cloned and tried to follow your readme. I am getting the following error when trying to make compile, make core, or even run emacs:
(doom-initialize-packages) file-missing in modules/tools/password-store/config.el: Cannot open load file: No such file or directory, auth-store-pass
make: *** [autoremove] Error 255

Emacs Version:
➜  .emacs.d (master) ✔ emacs --version
GNU Emacs 26.0.50
Copyright (C) 2017 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

which emacs
➜  .emacs.d (master) ✔ which emacs
/usr/local/bin/emacs

I installed using homebrew using the instruction for installing emacs-plus on the Spacemacs page. Should I perhaps try re-installing? Do you suggest a certain repo or version of emacs?
OS:
macOS Sierra
Version 10.12.5

I dug into this as much as I can. I'm kind of new to emacs in general, but have used Spacemacs quite a bit. It appears emacs 26+ has this included and has special load instructions. I looked at the config.el file in the module directory and it looks correct. So, I'm kind of at lost at the moment debugging until later tonight.
For now since I don't need the package and have never even heard or used it I have commented it out. Hoping you can help me figure out what's up though.
DOOM Doctor
Running Emacs v26.0.50, commit 38f842f186cc625e3f62795be90891f7feb924fe

Compiled with:
  JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB
  TOOLKIT_SCROLL_BARS NS MODULES
uname -a:
  Darwin Alucard 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14
  16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

----

peculiar error
make: *** [doctor] Error 255

If anyone else has a problem I uninstalled and installed using the default homebrew emacs. It seems to work now.

The tools/password-store module assumed that the auth-store-pass package was built into Emacs 26+, but it turns out not to always be the case. Switching back to Emacs 25 would fix this, but I've added a fix in a recent commit so that future Emacs 26 users don't experience this error.

@hlissner Im still seeing this error on 25.3

@ShashankaNataraj I cannot reproduce this. Does make autoloads (And if you've byte-compiled, make clean) resolve the issue?

@hlissner Hi, I havent byte compiled.
I just checked out a fresh copy of the doom config. I still see the same error.

@ShashankaNataraj Are you on Doom's develop branch?

@hlissner

Ah, that explains it. Please switch to the develop branch. master is currently very outdated (by ~7 months and 2800+ commits). Many of these issues have been resolved there. I'm currently cleaning up the new documentation branch and will be merging it as soon as I'm back home travelling (at the end of this week).

I just encountered this issue. Would it be possible to switch the default branch from master to develop?
That way, a git clone would already have the develop branch checked out.


Enhancement: Reponsiveness of contributors grid

This PR

[x] improves the responsiveness of the contributors grid

See http://bootply.com/d08bOti6Zs.
Examples

@snapshotpl
Regarding the last view, what do you think, can we increase the limit (or increase it to 100) so everyone has their place?
Also see #456!

Merging for now :-)

Thank you, @Ocramius!


Fix PostgreSQL bug when creating new admins

When creating a new admin the value of request('admin.id') is NULL, which means the email validation rule becomes "required|email|max:255|unique:admins,email,".
This results in the SQL select count(*) as aggregate from "admins" where "email" =<EMAIL_ADDRESS>and "id" <> '', which causes an exception in PostgreSQL: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type bigint: "".
This change first checks that request('admin.id') is not NULL before adding it to the email uniqueness check.
Fixes #86 and fixes #114

The Travis CI build is failing due to reasons unrelated to this pull request (cc @sarthaksavvy)

Amazing, thanku for this contribution

you can just do it with using Rule class:
use Illuminate\Validation\Rule;

'required|'.Rule::unique('admins','email')->ignore($this->admin),


error messages returned from auth plugins not included in the responses

I just started a registry:2 container with htpasswd auth plugin. So when password authentication fails, auth plugin returns ErrAuthenticationFailure which reads "authentication failure".
So when I make a request with bad credentials:
curl -iv http://localhost:5000/v2/ --user "alp:alp"
*   Trying <IP_ADDRESS>...
[...]

HTTP/1.1 401 Unauthorized
Content-Type: application/json; charset=utf-8
Docker-Distribution-Api-Version: registry/2.0
Www-Authenticate: Basic realm="foo"
X-Content-Type-Options: nosniff
Date: Thu, 15 Sep 2016 20:39:39 GMT
Content-Length: 87

{"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":null}]}

the string "authentication failure" is not presented in the response.
I hit this issue basically because I'm writing an auth plugin that would respond to auth problems with a specific error string, say "incorrect username/password".
However this string is never sent back to the user, instead it is only logged in the registry logs.
Is this by design or am I missing something? I think there should be a way to provide some custom "messsage" and "detail" to the user in this response.

@RichardScothern any ideas?

I'll have a dig.  I'm unsure if it is intentional; but the null detail doesn't look right

I dug.
The detail that gets put into the error is the access record.  For the /v2/ endpoint there is no access record, so you get null.  If you try and hit a repo, you would see something like:
{"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"repository","Name":"hello-world","Action":"pull"}]}]}

The error returned from the htpasswd auth package is ErrInvalidCredential which is what you see in the logs.  The top level distribution error is ErrorCodeUnauthorized and this must be general enough to cover all types of authentication failure (token & htpasswd).
Given this error message from your auth method, can there be another reason that authentication failed?  If not could you assume from this message that the username / password are incorrect?

can there be another reason that authentication failed

@RichardScothern hmm, yes, like I failed to connect to the database to check whether username/password are correct, in this case I'd love to send the user
{"errors":[{"code":"UNAUTHORIZED","message":"cannot authorize credentials, please try again later" ...

Understood.
Unfortunately there is no way to pass back more specific information given the hard coded error value.  If you want to make a PR to make this possible, @dmcgowan and I would be ok with it.

I succeed on this request for https:
curl -vi --cacert /home/username/docker/registry/certs/localhost.crt https://test:test@localhost:5000/v2/_catalog
The crt should match with the name of the FQDN (localhost in this case)
For http:
curl -X GET http://localhost:5000/v2/_catalog


quantization: process tensors on meta device directly, maybe implement CPU quantization (if it is easy)

Currently the BitsAndBytesLinearQuant4bit for submodule always calls bitsandbytes.functional.quantize_4bit. This is somewhat touchy for CPU tensors because quantize_4bit only works on GPU tensors but it is outright not so nice for meta tensors, where we only would need to get the right shapes.
https://github.com/Lightning-AI/lightning-thunder/blob/e64d347def39bb47101efafe4177adf9f77a63ec/thunder/transforms/quantization.py#L93-L103

@t-vi
Should we reshape meta into two dimension tensor with torch.uint8 like GPU result?
Should we execute PyTorch's 8-bit quantization for CPU?

Should we implement dedicated QuantState class for meta and cpu to return tensor along with its corresponding quantization state as for gpu?

Hi @tombawor , thank you for your interest.
I don't think we need a new class, just functions to complement bitsandbytes.functional.quantize_4bit(w, quant_type="nf4") for meta and cpu inputs (to return a tensor on w.device and a quant state with tensors in w.device).
Ideally, the quantize_weight function should have exactly the same inputs and outputs, except that all tensors stay on the device they are at, so same shape and quant state as if we called bitsandbytes.functional.quantize_4bit.
We could also offer it to bitsandbytes if they're interested.

There’s a multi-backend effort under way which is currently in alpha release for bitsandbytes.
This is cpu implementation from bitsandbytes.