Change listkeys pipe to fail when send_output fails

The listkeys pipe that sends listkeys results into downstream pipes did not check if send_output failed. This change checks for failed send_output, as well as propagates the failure up the pipe call-chain. This pull-request also ensures that the listkeys pipe correctly sets up error tracing when calling riak_pipe:exec.
For error propagation to work correctly, this must be used with the following changes to riak_pipe:
https://github.com/basho/riak_pipe/pull/43
The easiest way to test these changes is use the following branch that generates send_output failures for the listkeys fitting:
https://github.com/basho/riak_pipe/tree/jdb-pipe-listkeys-test

+1 merge


fix(multi_object_tracker): fix unintended perturbation in tracking estimation via non initialized eigen vector (#3651)

add initialize for anchor point vector
Description
trackerで初期値が未初期化されていた問題の修正
https://github.com/autowarefoundation/autoware.universe/pull/3651 と同じ内容
Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report
Patch coverage: 19.02% and project coverage change: +10.37 :tada:

Comparison is base (63ca797) 3.44% compared to head (ae648c0) 13.82%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@               Coverage Diff                @@
##           beta/v0.8.0     #423       +/-   ##
================================================
+ Coverage         3.44%   13.82%   +10.37%
================================================
  Files               99     1395     +1296
  Lines             7485    98041    +90556
  Branches          4099    29122    +25023
================================================
+ Hits               258    13551    +13293
- Misses            7033    69840    +62807
- Partials           194    14650    +14456

Flag
Coverage Δ

*Carryforward flag

differential
0.00% <0.00%> (-3.45%)
:arrow_down:

total
13.82% <19.40%> (?)

Carriedforward from 6dafaf4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

...nterface/include/osqp_interface/osqp_interface.hpp
0.00% <ø> (ø)

common/osqp_interface/src/csc_matrix_conv.cpp
66.03% <ø> (ø)

...ommon/osqp_interface/test/test_csc_matrix_conv.cpp
9.70% <ø> (ø)

common/osqp_interface/test/test_osqp_interface.cpp
15.00% <ø> (ø)

...rviz_plugin/src/pose_history_footprint/display.cpp
0.00% <ø> (ø)

...ier4_planning_rviz_plugin/include/path/display.hpp
0.00% <ø> (ø)

...planning_rviz_plugin/include/path/display_base.hpp
0.00% <ø> (ø)

...on/tier4_planning_rviz_plugin/src/path/display.cpp
0.00% <0.00%> (ø)

...viz_plugin/src/velocity_steering_factors_panel.cpp
0.00% <0.00%> (ø)

...ht_rviz_plugin/src/traffic_light_publish_panel.cpp
0.00% <0.00%> (ø)

... and 54 more

... and 1235 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How To calculate a text item's bounding box ?

Is there a way to calculate a text's real bounding box?

@wantsjean you can try below codes.
from photoshop import Session

with Session() as ps:
    doc = ps.active_document
    layer = doc.activeLayer
    print(layer.textItem.size)
    print(layer.bounds)

@wantsjean If you're trying to get the dimensions of the bounding box of the text item, you can do:
height, width = layer.textItem.height, layer.textItem.width

This is for the bounding box, but if you want the bounds of JUST the text without the spacing of the bounding box:
def get_layer_dimensions(layer):
    """
    Compute the width and height dimensions of a layer.
    @param layer: A layer object
    @return dict: Height and width of the layer.
    """
    return {
        'width': layer.bounds[2]-layer.bounds[0],
        'height': layer.bounds[3]-layer.bounds[1],
    }


When I click on "Copy Module", POST mysite/API/Blog/Modules/Add 500 ()

Hi!
I'm using Dnn v. 09.00.02.
When I click on "Copy Module", I complete the form and I click on "Add" I see the following error in the console. "POST mysite/API/Blog/Modules/Add 500 ()". Attached the next captures.
https://drive.google.com/file/d/0B_UqlWlFcWZ0M3AxNkJ4QnRWRFU/view?usp=sharing
https://drive.google.com/file/d/0B_UqlWlFcWZ0VEI1NnZOMGhWQkU/view?usp=sharing
Also when I change template of module to "latestPosts" I see the next error in the next capture.
https://drive.google.com/file/d/0B_UqlWlFcWZ0ZEt5Z3g1QU0yeDA/view?usp=sharing

I can reproduce this issue, will look into it.
In the meantime, a workaround is to not use the copy module option but just add one more time the blog module onto the page, then change the template used.


[DOCS] add "build from source" documentation

Part of #3901.
Tried self digging to understand how to build client app (server is good, just need to run ./build/build_binary.sh), but what about webpack? It is actually need to make simple and tiny guide how to do it.

I will add some clear contribution/build instructions to the Readme as well as updating our contribution documentation here


Use predictable names in Remote Sessions started in VS Code have GUIDS for names and paths

Today we use GUIDs
Benefits of using predictable names:

Inline with Jupyter Lab, Notebook and AzNb
Links to sessions in the above applications work
Single session per notebook+kernelspec

Challenges/Drawbacks

Users might be expecting VS Code to always create new sessions (not entirely sure why)
Assume we open two instances of VS Code and create two untitled files and run a cell against the same kernel.

What is the name of the kernel session in both cases?
Surely we cannot use untitled.ipynb for both,
We could possibly have untitled-<GUID>.ipynb for both.
However we still end up with GUIDs, still not perfect.
I do not think this is an issue.
If the user saves the notebook, at that point we can change the kernel session information to match the new notebook path.
This is what Jupyter Lab/Notebook does

Assume we open two different workspace folders in VS Code and create two files named sample.ipynb and run a cell against the same kernel

What is the name of the kernel session in both cases?
Surely we cannot use sample.ipynb for both,
In this case, we use the absolute path of the ipynb as the path for both kernel sessions.
This way we have a unique way to identify the kernel sessions and the notebooks they belong to.
The only exception is when a user connects to this same remote jupyter server with a machine having th exact same paths, thats unlikely.

All IW kernel sessions will have GUIDs as they are not always backed by files and there's no point keeping the *.py file as the name of the session (at least not for now).

We can use the *.py file name just as with the ipynb, but thats neither here nor there, as this isn't a problem today.
For consistently we could however use the *.py name

For remote Jupyter contributors like AzML, we can get the path of the remote jupyter server root directory and whether the server is localhost to the current extension host, if it is and if the workspace maps to that remote root, then all files are going to exist on the jupyter application as well, hence the paths can all be relative.

[x] Jupyter Servers provided by 3rd party extensions.
[ ] Jupyter Servers entered manually by users


scala-cli setup-ide generates files in latin-1 instead of utf-8

Version(s)
v1.1.0
Describe the bug
scala-cli setup-ide generates .bsp/scala-cli.json in latin-1, while it should be encoded in UTF-8 (I was unable to check the other files).
This breaks the integration with metals for users with a home on a non-ASCII path.
To Reproduce

Set your scala-cli instalation directory to somewhere with a non-ASCII character (in my case: C:\Users\João\AppData\Local\Coursier\data\bin\.scala-cli.aux.exe)
Run scala-cli setup-ide
Check the .bsp/scala-cli.json file (in my case, the ã was encoded as 0xe3)

Expected behaviour
I would expect the file to be encoded in UTF-8.
In my case, I would expect the ã to be encoded as either 0xc3 0xa3 (LATIN SMALL LETTER A WITH TILDE) or 0x61 0xcc 0x83 (LATIN SMALL LETTER A with COMBINING TILDE).

I imagine the answer to https://github.com/VirtusLab/scala-cli/blob/9385014b9a0207f3234cd1d4cf378aba5f46555e/modules/cli/src/main/scala/scala/cli/commands/setupide/SetupIde.scala#L167C1-L167C66 is "yes"


[DISCO_L476VG] Add platform

First delivery.
Status:

build.py: PASS with ARM_STD, ARM_MICRO, IAR and GCC_ARM
singletest.py: PASS with ARM_MICRO and IAR only. Tests executed: all common tests + MBED_A5, A6, A7 and A8.

Issue:

Cannot execute singletest.py with ARM_STD and GCC_ARM. The program does not start (???).
Note: an STM32CubeL4 example with uVision5 project and ARM_STD works fine. An mbed basic example using also uVision5 and ARM_STD does not start. Tried different startup files options without success.

Hi,
Please tell me what need to be done for the ci/circleci test.

Don't mind that circleci, someone enabled it again without defining a test. It's disabled. I'll look at the changes soon.


Kick start the process of adding type definitions

Beginnings of #647
Why is this needed?
Python type annotations are a great way of documenting the APIs, as well as improving the developer experience when using this library.
I find the actual type checking to be an added benefit than a necessity.
Proposed Changes

type the election, lock, lease, counter, barrier and party recipes
configure and add mypy to CI

Does this PR introduce any breaking change?

I hope not, but there are some real code changes along side the annotations

Hi @a-ungurianu,
Awesome that you started that work!!
Full disclosure, I haven't reviewed all the changes but one thing I wanted to mention is trying to minimize imports at runtime.
In most of my projects, i am able to only import TYPE_CHECKING and occasionally cast like so:

from typing import TYPE_CHECKING

# ... other imports

if TYPE_CHECKING:  # pragma: nocover
    from typing import...
    from typing_extensions import...
    T = TypeVar(...)

I have seen numerous other projects doing that as well.
What do you think?

I think I agree. I've just been adding any new modules inside the TYPE_CHECKING check, but adding all imports used for typing and repeating module imports makes sense.

Codecov Report
Base: 94.38% // Head: 93.59% // Decreases project coverage by -0.79% :warning:

Coverage data is based on head (755c416) compared to base (4b13135).
Patch coverage: 87.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   94.38%   93.59%   -0.80%
==========================================
  Files          57       57
  Lines        8388     8446      +58
==========================================
- Hits         7917     7905      -12
- Misses        471      541      +70

Impacted Files
Coverage Δ

kazoo/recipe/election.py
82.60% <63.63%> (-17.40%)
:arrow_down:

kazoo/recipe/barrier.py
95.19% <80.00%> (-4.81%)
:arrow_down:

kazoo/recipe/counter.py
94.54% <86.36%> (-5.46%)
:arrow_down:

kazoo/client.py
97.78% <87.50%> (-0.63%)
:arrow_down:

kazoo/recipe/lease.py
90.62% <89.47%> (-1.97%)
:arrow_down:

kazoo/recipe/party.py
96.15% <90.62%> (-3.85%)
:arrow_down:

kazoo/recipe/lock.py
97.26% <92.30%> (-1.68%)
:arrow_down:

kazoo/protocol/states.py
100.00% <100.00%> (ø)

kazoo/tests/test_cache.py
52.72% <0.00%> (-4.09%)
:arrow_down:

kazoo/tests/test_gevent_handler.py
76.76% <0.00%> (-3.53%)
:arrow_down:

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This is ready for a proper review now.
The history log in the PR is a bit of a mess for this due to me fighting with Hound and with making sure the stuff used from typing is available from 3.7 upwards

@a-ungurianu any chance this would get merged?

I'm considering declaring bankruptcy on this PR and re-openning so that it looks a bit more approachable for review.
Also, if there's anything in the structure that makes it hard to review, lemme know and I can amend

Would it be possible to exclude the if TYPE_CHECKING: lines from the test coverage? So that codecov can give us a "true" coverage. (see https://coverage.readthedocs.io/en/latest/excluding.html#advanced-exclusion)


'React/RCTBridgeModule.h' file not found

I have this problem, any idea how to solve this? 🙏

Hi Manuel,
This does not seem to be caused by our SDK in particular.
You can try re-installing the pods and also check this thread:
https://stackoverflow.com/questions/53541573/build-failed-react-rctbridgemodule-h-file-not-found
https://stackoverflow.com/questions/41663002/react-rctbridgemodule-h-file-not-found

@nzagorchev Thanks for your response:
I follow the first article but I received this error 😢
Any idea about this?
Thanks.

Hi Manuel,  this looks like after installing those dependencies that you opened up the xcode project w/o those dependencies rather than the workspace with those.   otherwise you can try reinstalling the dependencies in your project

I added the library manually but the Leanplum.h file not exist

thanks. did you follow the manual setup in our docs or how did you go about set up?

try installing the pods directly in your project and open the workspace

Please refer to this issue for a fix https://github.com/Leanplum/Leanplum-ReactNative-SDK/issues/30

Please refer to this issue for a fix #30


Example Shortcode Call in .md file

Looking thru shortcodes/ folder (i.e. bundle-content.html, content-strip-center.html, etc.). Not clear on how to invoke from md content file. Possible to clarify with example?
Showing something like:
{{ < bundle-content "foo" "bar" > }}
tx

located example under content/pages/about/index.md


Remove unneeded xarray version pin

Closes #495.

It looks like there are a few things going on here.
For the Python 3.8 build on Ubuntu, it looks like we're getting sphinx 7, which is causing this error: https://github.com/executablebooks/sphinx-book-theme/issues/749
And this is not a problem, but worth noting - currently we don't have Python 3.8 version of geocat-comp so the Python 3.8 builds here are grabbing an older version of geocat-comp (and thankfully xarray).

In the other builds it's not making it that far and failing instead on the contour labeling in this example: gallery/Contours/NCL_coneff_8
I haven't sorted out why this is the case yet.

Confirming this is only failing because of our known RTD issue.  @jukent we can probably merge whenever.


fwdinghistory lost

Executing lncli fwdinghistory --start_time 0 yielded results a few days ago, with 10 records, now it's empty.

Duplicate of https://github.com/lightningnetwork/lnd/issues/3357.


adding option to force reboot, ignoring active allerts

we have a kubernetes cluster running on Azure, sometimes we see high values for softIRQ, we resolve this issue by rebooting the nodes, we want to performe this action even if active prometheus alerts exists. when we see this high values for softIRQ we touches a separate file on the host and the node should restart (despite active alerts exists in prometheus)

@lunarfs It might be worth just supporting the word "force" inside the existing sentinel file? It looks like this covers issue #110 I just filed

@SerialVelocity that might indeed be simpler, as only the reboot blocked function would need changing by checking the content of the file.

I would be also interested to have this merged.
@bboreham  / @awh do you think we can have that merged soon?


When I blow Anything My game Crashes on its Own

crash-2023-12-24_12.00.21-client.txt

Your crash report was not uploaded to GitHub.

Closing: please upload the crash report correctly!


Infinispan state transfer never completes

If a node joins the cluster during a state transfer, it may happen that the state transfer never ends which makes it impossible for the joiner to join the cluster.
See https://issues.redhat.com/browse/ISPN-14982 for more details.

This corresponds with the following issue in the Keycloak project: https://github.com/keycloak/keycloak/issues/21256

Included in 14.0.12


Add logic to declaratively drive Job.SetState.

Adds job_helpers.go; includes both helper funcs and state transition
configurations.
Job.SetState uses these to make the transition code more idiomatic.
Possibility: rename job_helpers.go to job_config.go?
This has been successfully tested with TestJob_SetState.

job_state.go instead of job_helpers.go or job.go?  I'm fine with either.

instead of job_helpers.go I mean.

I amended the last commit so there wouldn't be a ton of j -> job lines.


cmd/validate-krew-manifest: initial implementation

This tool takes a manifest file and runs certain validation steps. It's meant
to test plugin manifests added to krew-index install correctly (so far it has
found one broken manifest).

Codecov Report

Merging #151 into master will decrease coverage by 1.99%.
The diff coverage is 37.63%.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
- Coverage   52.91%   50.91%   -2%
=======================================
  Files          12       13    +1
  Lines         618      711   +93
=======================================
+ Hits          327      362   +35
- Misses        240      297   +57
- Partials       51       52    +1

Impacted Files
Coverage Δ

pkg/index/validate.go
94.11% <ø> (ø)
:arrow_up:

cmd/validate-krew-manifest/main.go
37.63% <37.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8466d44...46a1e67. Read the comment docs.

Fixes #148.
Fixes #149.

cc: @juanvallejo
this is currently hacky but it'll help us validate issues in submitted manifest files.

@ahmetb trying this out locally. Currently running into the following error:
$ go run cmd/validate-krew-manifest/main.go --manifest="~/gopaths/plugins/src/github.com/GoogleContainerTools/krew-index/plugins/change-ns.yaml"
I0204 13:36:44.913634   15279 main.go:57] structural validation OK
I0204 13:36:44.913756   15279 main.go:65] all spec.platform[] items are used
I0204 13:36:44.913850   15279 main.go:71] no overlapping spec.platform[].selector
I0204 13:36:44.913857   15279 main.go:75] installing spec.platform[0]
F0204 13:36:44.990111   15279 main.go:39] spec.platforms[0] failed to install: plugin install command failed: Error: unknown command "krew" for "kubectl"
        Run 'kubectl --help' for usage.
        unknown command "krew" for "kubectl"
        : exit status 1
exit status 255

@juanvallejo you need to install krew first. The validator runs kubectl krew install with KREW_OS, KREW_ARCH for each spec.platform[] and with a temp KREW_ROOT dir to see if installation goes through.
For example, the install failed to symlink "change-ns" on windows, because the bin field for windows was lacking the .exe suffix.

@ahmetb yep thanks, had some path issues with kubectl. Appears to be working now

Ideally we'd take some of the validation here (like "has overlapping platform selectors", "all selectors map to at least one supported os/arch") and put it in pkg/index#Validate() method in the future.

lgtm


Content-Type for POST request without a body?

An API that I'm working with has a POST request that includes some parameters in the URL, but does not include a body. When I try sending the request through RapiDoc, I get back an error that says that the request needs to set the Content-type to application/json. I know that's a little odd because the service shouldn't care what the content-type is if there is no body, but that's how the service works for now.
Is there a way to set a default content-type to be used in all POST/PUT/PATCH requests?

hmm, not sure how other renderers are dealing with this, do you know what swagger-ui would do for this ?

Swagger UI seems to do the same thing: no content-type if no body. I'll check with the API developers and see what they think, and then I'll update this issue.

can you provide me a minimal spec where I can recreate this issue, I can give it a try

Hopefully this is enough snippet:
paths:
  '/customers/{orgid}/sites/{siteid}/nodes/{nodeid}/schedule_push':
    post:
      x-lighting: true
      tags:
        - Nodes
      summary: Resend schedule to a node
      description: Resend a schedule to a node.
      operationId: resendScheduleToNode
      parameters:
        orgid:
          in: path
          description: Customer account ID
          required: true
          schema:
            type: string
            format: UUID
          example: 47d5ed30-bdd7-11e7-95af-b3b0c15ebf90
        siteid
          in: path
          description: Site ID
          required: true
          schema:
            type: string
            format: UUID
          example: 78520930-bdd7-11e7-95af-b3b0c15ebf90
        nodeid
          in: path
          description: Node ID
          required: true
          schema:
            type: string
            format: UUID
          example: N313098
      responses:
        '204':
          description: Success

RapiDoc did not had any issue in submitting that request. Most likely the validation/response is coming from your API
I created a  fake POST endpoint using Mockable
and it had no issues in submitting the POST request without a body
openapi: 3.0.2
info:
  version: '1.0'
  title: POST with no request-body
  description: POST with no request-body
servers:
  - url: 'http://demo1373839.mockable.io'
paths:
  /sample-post:
    post:
      summary: Resend schedule to a node
      description: Resend a schedule to a node.
      operationId: resendScheduleToNode
      parameters:
        - orgid:
          in: query
          schema:
            type: string
      responses:
        '204':
          description: Success


ERROR: : YouTube said: This video has been removed by the user. program halts

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.09.03. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2016.09.03

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

Passing list of youtube URL's in a file, invoking youtube-dl -a
One URL fails with ERROR: : YouTube said: This video has been removed by the user. program halts.
I expect youtube-dl to proceed to next url in the file, but it won't. It halts after the above error.

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl -v -a 3
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'-a', u'3']
[debug] Batch file urls: [u'https://www.youtube.com/watch?v=<video-id>', u'https://www.youtube.com/watch?v=<video-id no. 2>']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.03
[debug] Python version 2.7.6 - Linux-3.13.0-93-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 9.18-6, avprobe 9.18-6, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] <video-id>: Downloading webpage
[youtube] <video-id>: Downloading video info webpage
[youtube] <video-id>: Extracting video information
[youtube] <video-id>: Downloading MPD manifest
WARNING: Your copy of avconv is outdated and unable to properly mux separate video and audio files, youtube-dl will download single file media. Update avconv to version 10-0 or newer to fix this.
[debug] Invoking downloader on u'https://r2---sn-5jucgv5qc5oq-cags.googlevideo.com/videoplayback?mime=video%2Fmp4&key=yt6&pl=24&initcwndbps=2117500&ipbits=0&ratebypass=yes&expire=1472951545&lmt=1471162428825977&sparams=dur%2Cei%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&source=youtube&upn=JSPvyeGELTk&sver=3&dur=60.162&id=o-AIy3M45nGrdeagmImy51PjI1qAv9IcClH2iy6pxrMj0H&mn=sn-5jucgv5qc5oq-cags&mm=31&signature=777000A35A87A9028316B6B4079A67CC7501861C.2AA3FFDFA56BD15DFFA3EBC4EFD698E8DBEC0818&ms=au&mv=m&mt=1472929278&ip=<IP_ADDRESS>&requiressl=yes&ei=mSDLV87vEdapogO35IiYDw&itag=22'
[download] <Video Description>-<video-id>.mp4 has already been downloaded
[download] 100% of 11.91MiB
[youtube] <video-id no. 2>: Downloading webpage
[youtube] <video-id no. 2>: Downloading video info webpage
ERROR: <video-id no. 2>: YouTube said: This video has been removed by the user.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 691, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 347, in extract
    return self._real_extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 1327, in _real_extract
    expected=True, video_id=video_id)
ExtractorError: <video-id no. 2>: YouTube said: This video has been removed by the user.

<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information

Passing list of youtube URL's in a file, invoking youtube-dl -a
One URL fails with ERROR: : YouTube said: This video has been removed by the user. program halts.
I expect youtube-dl to proceed to next url in the file, but it won't. It halts after the above error.

Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.

Passing list of youtube URL's in a file, invoking youtube-dl -a
One URL fails with ERROR: : YouTube said: This video has been removed by the user. program halts.
I expect youtube-dl to proceed to next url in the file, but it won't. It halts after the above error.

Use -i.

Thank you for the swift reply. My mistake, that I didn't explore -i option.


Typescript error in custom turn config

Upgrading to version 0.39.5 leads to the following typescript error:
Property 'next' is missing in type '{ first: (g: WizardState, ctx: Ctx) => number; }' but required in type 'TurnOrderConfig'.

I am using a custom turn configuration for a phase where the first player does not follow the normal turn order. The next function is not needed in my use case and it worked fine so far without it.
Is there a reason why the next field should always be set when using a custom turn configuration? (I think the same question applies to the first field). Or can we just make these fields optional?

Currently if turn.order is not set, it is set using the default order:
https://github.com/nicolodavis/boardgame.io/blob/f34f46b78a8018cce313f8cae698bf0ea403039f/src/core/flow.ts#L125-L127
But, if you only set first, as far as I can tell, there are no guards to prevent the game flow then trying to call next, which would be undefined, so I think the type is correct (even if in your game, next will never be called if I’ve understood correctly.)
Perhaps there’s an argument for having the default above set as:
conf.turn.order = {
  ...TurnOrder.DEFAULT,
  ...conf.turn.order,
}

to allow users to progressively modify the turn order.

But, if you only set first, as far as I can tell, there are no guards to prevent the game flow then trying to call next, which would be undefined, so I think the type is correct (even if in your game, next will never be called if I’ve understood correctly.)

Ah, indeed, in my case, the phase has only a single turn, so next will never be called. Hence, the types are correct and just revealed a potential source of error in my project.

Perhaps there’s an argument for having the default above set as
conf.turn.order = {
 ...TurnOrder.DEFAULT,
 ...conf.turn.order,
}

to allow users to progressively modify the turn order.

Yeah, this sounds like a good idea to me!


enhance: remove redundant indices from submission_defs table

Improves submission throughput by 20% without any impact on select queries.
What has been done to verify that this works as intended?
Performed load testing with jmeter.
Used 250_questions form. For every run, I kept only 20K submissions in the database (having 0 existing submission doesn't truly reflect impact of indices).
Parameters:
Threads: 300
Total test duration: 60s
Precise throughput target: 1500 per 10 sec. Release 40 threads in a batch
(I run tests with various parameters to find out what is the maximum throughput that can be achieved with no index on submission_defs table)
Result:
95/sec throughput with 4% failed submissions without this change
115/sec throughput without any failure with this change
Why is this the best possible solution? Were any other approaches considered?
I want this change to be reviewed under the microscope.
Thinking to delete submissions_draft_index, submissions_formid_index and submissions_formid_instanceid_index from submissions table as well
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to really make sure that there is no negative impact of this change on submission retrieval (odata, csv, zip)
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
NA
Before submitting this PR, please make sure you have:

[ ] run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
[ ] verified that any code from external sources are properly credited in comments or that everything is internally sourced

Really great to see some throughput numbers and ideas for increasing it.
A couple of high-level thoughts:

It's hard to weigh tradeoffs between submission throughput and export speed and it's too bad that they're linked (but of course they are if we use the same store for both). Export performance is important because that's where the row count can get really significant and it's common to request the full data frequently.
It might be beneficial to look at some real query plans. I feel like some of these we can reason about but others we might be surprised by. Maybe you have?

Performed load testing with jmeter.

This was on the dev server, right? 2 vCPUs and 2GB RAM
I believe the only read operation with performance requirements is data export. There are different variations:

Format: CSV (zipped or not), OData
Attachments: submission attachments and client audit export
Extras: split select multiple, repeats

I believe we know that these are typically RAM-bound.

make sure that there is no negative impact of this change on submission retrieval (odata, csv, zip)

As far as I can tell, there will have to be some amount of negative impact on the queries for all of these, right? In particular, they all include joins on submissionId and several of them have current=true conditions. I believe createdAt only comes up for submission attachments. What about id, "submissionId", does that come into play when the submissionId is known and the id is needed (so in some of the joins)? That said, all of the conditions are pretty deep in complex queries so I imagine the working set is already quite small when they are evaluated, does that sound right? Maybe that means the indexes don't make much of a difference, if any.
How did you pick these specific indexes to target? Was it only based on the impact on submission processing time or also on some estimate of impact on exports (e.g. something like the high-level reasoning I went through above).

Thinking to delete submissions_draft_index, submissions_formid_index and submissions_formid_instanceid_index from submissions table as well

It would be helpful to get a quick narrative on how you think about these as well.
submissions_formid_index - this one is the one that seems the riskiest to me. It feels like if we have a lot of submissions across a lot of different forms not having this index could slow things down noticeably. We already do have an issue in that area so the tradeoff might not be worth it. This is where looking at some real query plans might be helpful.

From @sadiqkhoja: there are still multicolumn indexes that cover the same cases as the removed ones.
From postgres docs:

A multicolumn B-tree index can be used with query conditions that involve any subset of the index's columns, but the index is most efficient when there are constraints on the leading (leftmost) columns. The exact rule is that equality constraints on leading columns, plus any inequality constraints on the first column that does not have an equality constraint, will be used to limit the portion of the index that is scanned.

I did not know this.
I can confirm the following indexes remain on submission_defs:

id
"submissionId", current
"submissionId", "instanceId"

I believe that leaves submission attachments without index support because they use createdAt. Could they use the index instead? Or maybe it's deep enough in the query that it doesn't matter.
I verified with explain that read queries with just submissionId equality are cheap. Queries with just instanceId or current equality are at least half as expensive as linear searches (still pretty expensive). That looks ok to me given my understanding of the export-related queries.
For submissions, with the proposed changes there would remain:

id
"formId", "instanceId", draft
"formId", "createdAt"

All of the removed ones are subsets of those. We only use equality conditions against any of those fields. According to the experimentation I did above and my understanding of the queries on submissions, removing draft, formId, formId, instanceId) are very likely to be covered by the remaining indexes. In fact, this looks more unambiguously safe than the submission_defs changes.

I believe that leaves submission attachments without index support because they use createdAt. Could they use the index instead? Or maybe it's deep enough in the query that it doesn't matter.

I don't see createdAt being used in the where clause of submission attachments

I don't see createdAt being used in the where clause of submission attachments

I'm sorry, I meant client audits: https://github.com/getodk/central-backend/blob/master/lib/model/query/client-audits.js#L41
My understanding is that the createdAt index would make a difference for the sorting and that the size of the working set could be fairly large. Do we have a good way to estimate what that impact would be?

ah! there will be significant impact definitely.
Q: Do we really need to order by createdAt here? Isn't sorting by id sufficient?
A: No, concurrent requests can create submission_defs that have different order of id and createdAt :(
-- in test.getodk
SELECT count(1) FROM
(
  SELECT id, "createdAt", ROW_NUMBER() OVER (ORDER BY id) rownum FROM submission_defs sd
) orderbyid
JOIN (
  SELECT id, "createdAt", ROW_NUMBER() OVER (ORDER BY "createdAt") rownum FROM submission_defs sd
) orderbycreatedat ON orderbyid.rownum = orderbycreatedat.rownum
WHERE orderbyid.id != orderbycreatedat.id

-- output
-- 19692

I am going to create composite index on (createdAt, id)

concurrent requests can create submission_defs that have different order of id and createdAt

That's interesting and intersects with discussions we've been having about entity updates through submissions, I think. Does this have to do with postgres transaction rules or something? Like is the id assigned at the beginning of the transaction and createdAt at the end or something like that? Or am I thinking along the wrong lines?
That said, maybe sorting by id still is ok. I don't know that the specific order matters, only that it's relatively stable. My understanding is that order is meaningful only because sometimes humans manually look at the audit export and it's helpful in that case to be able to relate that order to the submission table. The order of the individual log entries within a submission is the most important thing for that. The absolute ideal would be that it be sorted by date/time that the submissions were created on the client but we know that's literally impossible (because clients could be offline and who knows how their clocks are set).

Does this have to do with postgres transaction rules or something? Like is the id assigned at the beginning of the transaction and createdAt at the end or something like that? Or am I thinking along the wrong lines?

Values for id and createdAt are generated in the same SQL statement. Even then it is possible that both get out of order because same statement can be executed by concurrent transactions independently. DB will call nextval() and clock_timestamp() for each statement without knowledge of each other.

DB will call nextval() and clock_timestamp() for each statement without knowledge of each other.

Fascinating.
What did you think of my reasoning for submission_defs.createdAt not actually being needed? I'm fine with going with what you have for now but also if you find that reasoning compelling it would be nice to leverage an existing index.
Do users need to run analyze explicitly after indexes change or will they be rebuilt automatically as part of either the migration process or routine vacuum?

For client audit logs, sorting by just id is fine. But we are sorting submissions by createdAt, id as well and since we don't return id in the response, users may get confused about the order. May be it's not a big deal, you have more experience with the users, I think you should make the call.
We haven't put analyze in the migrations up till now, I guess routine vacuuming should be enough for this case as well.

I'm satisfied by the answers to my latest questions and the analysis I wrote up above. I think it can be merged without another pair of eyes but also happy for you to loop in another reviewer if you still find this risky, @sadiqkhoja.


Altona: Initial Sync suspends with missing requests

Describe the bug
Sync Altona and the initial sync suspends with below logs:
2020-07-22 15:11:59  [SYNC]             info: Fetching blocks for 14356...14419 slot range
2020-07-22 15:11:59  [SYNC]          verbose: updating block target 14419
2020-07-22 15:11:59  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmV2BjFPcY4QYRuWE5DxpS2KpfLogiSmVKe9Lp9mTt3XBU requestId=a6c33fc97dd05c77, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm11SEWpDeBdRVnher3mA1bH8Vqz4E9NnsveYRguSpvkeW requestId=49b192b6c0186441, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmKvyXP7YTcKfyKHfssLVQDKbCSEMSnf6RnAbwynuBmkE5 requestId=59c294d93b1c3ebc, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm4E6fMnRfmREDFCmFTcU7AHD2RwTnETSQL3pqVNQx8dQf requestId=806fda07ed81e459, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm1gPDqPY4qkMvyjSjXWESF8U9S72KesxRxENSYw3QViBD requestId=04816d332943c143, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm5ZUgecTiQ3qvxBmwT8WGuZead9UKzVKpzcVM563jMsVy requestId=8ab12da36c68bff4, encoding=ssz_snappy
2020-07-22 15:12:00  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmShssfcjghFfXKZZxUnw4Wq5t3thxGpRyU9d2pHfjhQWK requestId=638c1a80d005b33c, encoding=ssz_snappy

2020-07-22 15:12:00  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAmV2BjFPcY4QYRuWE5DxpS2KpfLogiSmVKe9Lp9mTt3XBU requestId=a6c33fc97dd05c77, encoding=ssz_snappy, body={"startSlot":14372,"step":1,"count":8}
2020-07-22 15:12:00  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAm11SEWpDeBdRVnher3mA1bH8Vqz4E9NnsveYRguSpvkeW requestId=49b192b6c0186441, encoding=ssz_snappy, body={"startSlot":14404,"step":1,"count":8}
2020-07-22 15:12:01  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAmKvyXP7YTcKfyKHfssLVQDKbCSEMSnf6RnAbwynuBmkE5 requestId=59c294d93b1c3ebc, encoding=ssz_snappy, body={"startSlot":14380,"step":1,"count":8}
2020-07-22 15:12:01  [NETWORK]       verbose: receive beacon_blocks_by_range response with 7 chunks from 16Uiu2HAm4E6fMnRfmREDFCmFTcU7AHD2RwTnETSQL3pqVNQx8dQf requestId=806fda07ed81e459, encoding=ssz_snappy, body={"startSlot":14364,"step":1,"count":8}
2020-07-22 15:12:01  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAm5ZUgecTiQ3qvxBmwT8WGuZead9UKzVKpzcVM563jMsVy requestId=8ab12da36c68bff4, encoding=ssz_snappy, body={"startSlot":14356,"step":1,"count":8}
2020-07-22 15:12:01  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAmShssfcjghFfXKZZxUnw4Wq5t3thxGpRyU9d2pHfjhQWK requestId=638c1a80d005b33c, encoding=ssz_snappy, body={"startSlot":14396,"step":1,"count":8}
2020-07-22 15:12:02  [NETWORK]       verbose: receive ping request from 16Uiu2HAmShssfcjghFfXKZZxUnw4Wq5t3thxGpRyU9d2pHfjhQWK requestId=e3cd4fba8e92feef, encoding=ssz_snappy
2020-07-22 15:12:02  [NETWORK]       verbose: Sent response for request e3cd4fba8e92feef
2020-07-22 15:12:03  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAm1gPDqPY4qkMvyjSjXWESF8U9S72KesxRxENSYw3QViBD requestId=04816d332943c143, encoding=ssz_snappy, body={"startSlot":14412,"step":1,"count":8}

Analyse

I see that we have 7 beacon_block_by_range requests and receive back 7 beacon_block_by_range responses
Requests for blocks from 14356...14419
There are 7 requests: {"startSlot":14356,"step":1,"count":8}, {"startSlot":14364,"step":1,"count":8}, {"startSlot":14372,"step":1,"count":8}, {"startSlot":14380,"step":1,"count":8}, {"startSlot":14396,"step":1,"count":8}, {"startSlot":14404,"step":1,"count":8}, {"startSlot":14412,"step":1,"count":8}
Seems like missing a request starting with 14388

We should not have an issue with our chunkify work when fetching a block range.
I think this call block us in case of unresponsive peers: const {stream} = await libp2p.dialProtocol(peerId, protocol) as {stream: Stream};, that's why we don't see sending beacon_blocks_by_range request log for block 14388 and our timeout handler does not have a chance to run.

I tried to print sending beacon_blocks_by_range request log before libp2p.dialProtocol and got another suspend case:
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm5ZUgecTiQ3qvxBmwT8WGuZead9UKzVKpzcVM563jMsVy requestId=7ece04f5b6ca5895, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmShssfcjghFfXKZZxUnw4Wq5t3thxGpRyU9d2pHfjhQWK requestId=8abd4153afa6cffd, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmV2BjFPcY4QYRuWE5DxpS2KpfLogiSmVKe9Lp9mTt3XBU requestId=7c8158459eeb5c49, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm6GkAadd3KgQDQrsfGqyDWWktwxEmjXiHQX7giutJ8oQT requestId=738345b175bb3625, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAm6FBad3xnXj4WkkjpjaQQedn4rCmh8jCww2uw6MSSFNs2 requestId=174cb7311e456662, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmEkiNky4neUPnbdMaRXLrYJaombgHiWehf4yHN4G3mBb4 requestId=74771eea27bd64a2, encoding=ssz_snappy
2020-07-23 09:48:38  [NETWORK]       verbose: sending beacon_blocks_by_range request to 16Uiu2HAmPUFvEyKLUecPg3kdZS5RJ27G8K5TwHz3PAe6eFBvgnJF requestId=e7d612097f70fd3f, encoding=ssz_snappy

2020-07-23 09:48:39  [NETWORK]       verbose: receive beacon_blocks_by_range response with 5 chunks from 16Uiu2HAmEkiNky4neUPnbdMaRXLrYJaombgHiWehf4yHN4G3mBb4 requestId=74771eea27bd64a2, encoding=ssz_snappy, body={"startSlot":153340,"step":1,"count":9}
2020-07-23 09:48:40  [NETWORK]       verbose: receive beacon_blocks_by_range response with 6 chunks from 16Uiu2HAm5ZUgecTiQ3qvxBmwT8WGuZead9UKzVKpzcVM563jMsVy requestId=7ece04f5b6ca5895, encoding=ssz_snappy, body={"startSlot":153295,"step":1,"count":9}
2020-07-23 09:48:40  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAm6FBad3xnXj4WkkjpjaQQedn4rCmh8jCww2uw6MSSFNs2 requestId=174cb7311e456662, encoding=ssz_snappy, body={"startSlot":153331,"step":1,"count":9}
2020-07-23 09:48:40  [NETWORK]       verbose: receive beacon_blocks_by_range response with 7 chunks from 16Uiu2HAmShssfcjghFfXKZZxUnw4Wq5t3thxGpRyU9d2pHfjhQWK requestId=8abd4153afa6cffd, encoding=ssz_snappy, body={"startSlot":153304,"step":1,"count":9}
2020-07-23 09:48:40  [NETWORK]       verbose: receive beacon_blocks_by_range response with 8 chunks from 16Uiu2HAmPUFvEyKLUecPg3kdZS5RJ27G8K5TwHz3PAe6eFBvgnJF requestId=e7d612097f70fd3f, encoding=ssz_snappy, body={"startSlot":153349,"step":1,"count":9}
2020-07-23 09:48:44  [NETWORK]       verbose: receive ping request from 16Uiu2HAmT4wy4fcHbmS8xo1kfEdcWwMUjPF2PaRpKYtqFTcKQaSQ requestId=88095310d533b8c1, encoding=ssz_snappy
2020-07-23 09:48:44  [NETWORK]       verbose: Sent response for request 88095310d533b8c1
2020-07-23 09:48:45  [NETWORK]         error: failed to send request 738345b175bb3625 to peer 16Uiu2HAm6GkAadd3KgQDQrsfGqyDWWktwxEmjXiHQX7giutJ8oQT Error: response timeout

This time we sent out 7 requests, received 5, 1 was timed out and then it's suspended, 1 for sure was timed out and we did not handle it.
So we have to start our timer before connecting to the other node, i.e. before libp2p.dialProtocol

Opening this again as it happened in my local environment: it's a dialProtocol timeout issue as we don't receive a connection/stream after timing out, no error was thrown, and this does not always happen, then sync gets suspended.
Need to confirm if it happens in other environments as well.

Thats impossible, if we dont receice anything from dial it returns error explicitly

Do you have logs?

I didn't keep it, will do it next time. But its like
logger.verbose(sending ${method} request to ${peerId.toB58String()}, {requestId, encoding});
without
logger.verbose(got stream to ${peerId.toB58String()}, {requestId, encoding});
and the sync is suspended

also run with wtf node so you can see if libp2p has some open handle so we can report bug to them


Add formatter for XML files

I'm currently working on Java project and doing quite a bit of editing in pom.xml files. It would be nice to automatically fix indentations and other formatting issues when saving the files.

Added to Sprint 22.08

I noticed that prettier failed to format an XML file when I was using <relativePath/> in a pom.xml file. Replacing this line by <relativePath></relativePath> enabled prettier to successfully format the file.

There is a plugin for prettier to format XML files but I couldn't get it to fix indents, so I used a workaround where Prettier is asked to format XML files as if they were HTML files.

The option "xmlWhitespaceSensitivity": "ignore" is important for the XML plugin for Prettier, otherwise indents are not formatted.


Allow b.external() to accept an array of files

I have several external dependencies I don't want to include in the main bundle; would be great if b.external() took an array of files/modules to leave out.

Currently this is working for me in v8.1.0 -- both for external() and require(). Has it been fixed?

works for me in v9

Stopped working from 9.0.1 to 9.0.4

This can be closed. Array support was added in https://github.com/substack/node-browserify/commit/b94b20da0d039f79c14bc361e7aaf6b4958e14a9.


feat: ensure that all assignees get a value

Closes partially #543
Summary of Changes
Show an error if an assignee might not get a value.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Double to_timestamp_seconds produces abnormal result

Describe the bug
To Reproduce
❯ select to_timestamp_seconds(a) from (select to_timestamp_seconds(1) as a)A;
+-------------------------+
| totimestampseconds(a.a) |
+-------------------------+
| 1969-12-31 16:00:01     |
+-------------------------+
1 row in set. Query took 0.000 seconds.

while to_timestamp_millis will make it crash
❯ select to_timestamp_millis(a) from (select to_timestamp_millis(1) as a)A;
thread 'main' panicked at 'invalid or out-of-range datetime', /Users/willy/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.19/src/naive/datetime.rs:117:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
it should return 1970-01-01 00:00:01 . I feel like that timezone conversion is applied somewhere. (I'm in UTC+8)
Additional context

the subquery return something like 1970-01-01T00:00:00 (without the endding Z as utc ) which will be deem as local-time (UTC+8) while parsing by https://docs.rs/arrow/19.0.0/arrow/compute/kernels/cast_utils/fn.string_to_timestamp_nanos.html#timezone--offset-handling


Added Redbubble to README

Added Redbubble to list of adopters in README.

Current coverage is 78.39% (diff: 100%)

Merging #711 into master will increase coverage by 0.75%

@@             master       #711   diff @@
==========================================
  Files            34         34
  Lines           662        662
  Methods         636        636
  Messages          0          0
  Branches         26         26
==========================================
+ Hits            514        519     +5
+ Misses          148        143     -5
  Partials          0          0

Powered by Codecov. Last update 082e39c...c47acac

This is amazing! Thanks a lot @tomjadams!


Popup related tests fail / time out randomly.

Like stated here the selftests for popup functionality fail randomly.
This needs investigation and it should be checked if this is related to some of the other issues filed against popup functionality (#963, #978, #1095, #1174, #1303).

I can't manage to reproduce this bug : could you help me with a code, a version of browser or anything else.

I'm consistently getting a popup test failure with released PhantomJS 2.1.1. Interestingly, I consistently do not get the failure when I build PhantomJS in debug mode. This is on OS X 10.11.3 with Xcode 7.2.
Release:
Test file: /Users/marc/Projects/NewStuff/casperjs-me/tests/suites/casper/popup.js
# popup tests
PASS popup tests (22 tests)
PASS "popup.created" event is fired
PASS "popup.created" event callback get a popup page instance
PASS "popup.loaded" event is fired
PASS "popup.loaded" is triggered when popup content is actually loaded
PASS Casper.waitForPopup() waits for a popup being created
PASS A popup has been added
PASS A popup is a WebPage
PASS Casper.withPopup() found a popup with expected title
PASS Casper.withPopup() found a popup with expected text
PASS Casper.withPopup() switched to popup as current active one
PASS Casper.withPopup() has client utils injected
PASS Casper.withPopup() can perform assertions on the DOM
PASS Casper.withPopup() can perform assertions on the DOM using XPath
PASS Casper.withPopup() has reverted to main page after using the popup
PASS "popup.closed" event is fired
PASS Popup is removed when closed
PASS Casper.waitForPopup() waits for a popup being created
PASS Casper.withPopup() can use a regexp to identify popup
PASS Casper.withPopup() has reverted to main page after using the popup
FAIL Popup is removed when closed
#    type: assertEquals
#    file: /Users/marc/Projects/NewStuff/casperjs-me/tests/suites/casper/popup.js
#    subject: 1
#    expected: 0
PASS Casper.waitForPopup() waits when clicked on a link with target=_blank
PASS Page title is: "CasperJS test form"

Debug build:
Test file: /Users/marc/Projects/NewStuff/casperjs-me/tests/suites/casper/popup.js
# popup tests
PASS popup tests (22 tests)
PASS "popup.created" event is fired
PASS "popup.created" event callback get a popup page instance
PASS "popup.loaded" event is fired
PASS "popup.loaded" is triggered when popup content is actually loaded
PASS Casper.waitForPopup() waits for a popup being created
PASS A popup has been added
PASS A popup is a WebPage
PASS Casper.withPopup() found a popup with expected title
PASS Casper.withPopup() found a popup with expected text
PASS Casper.withPopup() switched to popup as current active one
PASS Casper.withPopup() has client utils injected
PASS Casper.withPopup() can perform assertions on the DOM
PASS Casper.withPopup() can perform assertions on the DOM using XPath
PASS Casper.withPopup() has reverted to main page after using the popup
PASS "popup.closed" event is fired
PASS Popup is removed when closed
PASS Casper.waitForPopup() waits for a popup being created
PASS Casper.withPopup() can use a regexp to identify popup
PASS Casper.withPopup() has reverted to main page after using the popup
PASS Popup is removed when closed
PASS Casper.waitForPopup() waits when clicked on a link with target=_blank
PASS Page title is: "CasperJS test form"

Hi @istr ,
I schedule 10 times the command "casper selftest tests/suites/casper/popup.js" :  3 crashs.

this bug was not difficult to find.
This random bug comes from a garbage collector event.
I don't know how to show it directly in source code .
So here is a wonderful copy-paste from "pagestack.js":
/**
 * Cleans the stack from closed popup.
 *
 * @param  WebPage  closed  Closed popup page instance
 * @return Number           New stack length
 */
Stack.prototype.clean = function clean(closed) {
    "use strict";
    var closedIndex = -1;
    this.forEach(function(popup, index) {
        if (closed === popup) {                        <==== bug
            closedIndex = index;
        }
    });
    if (closedIndex > -1) {
        this.splice(closedIndex, 1);
    }
    return this.length;
};

we compare objects that could be destroy or re-allocated so popup is never clear from the list.
The next list browsing will crash because list contains an object without reference.
Here is a possible resolution :
/**
 * Cleans the stack from closed popup.
 *
 * @param  WebPage  closed  Closed popup page instance
 * @return Number           New stack length
 */
Stack.prototype.clean = function clean(closed) {
    "use strict";
    var closedIndex = -1, closedIndexSecond = -1;
    this.forEach(function(popup, index) {
        if (closed === popup) {
            closedIndex = index;
        } else if (closed.title === popup.title && closed.windowName === popup.windowName) {
            closedIndexSecond = index;
        }
    });
    if (closedIndex > -1) {
        this.splice(closedIndex, 1);
    } else if (closedIndexSecond > -1) {
        this.splice(closedIndexSecond, 1);
    }
    return this.length;
};

I schedule 1000 times this solution with command "casper selftest tests/suites/casper/popup.js" : no crash at all.

I will make a PR if this solution is acted

Hi @jefleponot,
thanks a lot for this complete explanation, I confirm that your code works well :)
ping @n1k0 can you take a quick look at it ? Sounds like a little but pragmmatic hack.
Mickaël

:clap: Thanks @jefleponot. Great we have the root cause. Probably there will be a less "hacky" solution to handle this, simply checking if the reference still is valid...

LoL
I let you write a prettiest code. Javascript Object reference is outside my skills...sorry.
Is there any annoying :bug: to resolve before adding new features ?
jef

@istr I've got this duplicated in my local environment.  Looking into doing a cleaner implementation.

@istr @mickaelandrieu @n1k0 - See PR #1490

The PR looks good.

@jefleponot Can you confirm the latest build fixes your issue?
@istr I think we are good to mark this issue resolved now.

@BIGjuevos I'll wait for @jefleponot s confirmation before closing this, but I guess it is resolved now.

Hi @Istr, @BIGjuevos
Great Job, your code is Brilliant.
Please merge it @istr .

@jefleponot This was merged by @mickaelandrieu some days ago. Closing.


Problems with config

Hi, I am new using SF bundles,
You know how can get this info:
endpoint: "https://login.salesforce.com/"
client_id: ""
client_secret: ""
security_token: ''
I allways make sistem with username and password login.
Thx

Hey, you got some info  in salesforce rest api documentation here https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_defining_remote_access_applications.htm
You probably could read some more, to understand better how it works too.


ppx_irmin: strengthen the tests to compile and run the output

... and use this to catch a bug in the passing/nonrec.ml test.
Also adds a (broken) test case witnessing the bug described by https://github.com/mirage/irmin/issues/923 (cc. @pascutto). I couldn't find an easy way to assert that this bug exists as part of dune runtest (doing so would likely require something like janestreet/toplevel_expect_test).

Unfortunately, it seems the workflow proposed here isn't supported by OCaml-CI.
We'd like to be able to test ppx_irmin by compiling the resulting code against the irmin API. Neither depends on the other, but they have cyclic test dependencies:

irmin → ppx_irmin (with-test), though at some point this may be a true dependency
ppx_irmin → irmin (with-test)

TravisCI doesn't have the same problem since it handles each package independently.

irmin → ppx_irmin (with-test)

Maybe we should not depend on ppx_irmin in irmn's tests then, and just commit the generated code.

Maybe we should not depend on ppx_irmin in irmn's tests then, and just commit the generated code.

I'd rather not go with that as a solution here, since it becomes another reason not to use ppx_irmin in irmin itself.
If @talex5 thinks the issue can be fixed CI-side, let's do that instead.

As pointed out by @talex5, this is now unblocked with the new solver branch of the CI (currently deployed).
I'll rebase tomorrow, then we should wait until https://github.com/ocurrent/ocaml-ci/pull/167 is merged before merging here.

CI failure in irmin-http unrelated. Merging.


Modify name: hgcalTrigPrimValidation to L1THGCalTrigPrimValidation

Change a name to insure compatibility with hgcalRunEmulatorValidationTPG_cff.py

Correctly fixes issue in 12_5_2_patch1 (see #57 )
Here the checks don't pass because they are based on V11 samples while the V11 geometry doesn't exist any more in 13_X


Using Store in GeoRadiusQuery results in can't parse array reply error

While Store is in the GeoRadiusQuery struct, including it doesn't seem to work and instead results in an error when GeoRadius is called:
can't parse array reply
This field is never set to a value in any of the existing tests, but I don't think I'm doing anything fishy myself.

Please add a reproducer.

@vmihailenco here's your reproducer https://github.com/go-redis/redis/issues/1083


Allows customized request construction by exposing Request.create()

Users may wish to override percent encoding of query parameters.
closes #227

NetflixOSS » feign » feign-pull-requests #97 SUCCESS
This pull request looks good

NetflixOSS » feign » feign-pull-requests #98 SUCCESS
This pull request looks good


getModelForClass() does not use options in its cache; move the options somewhere else ?

The getModelForClass() function takes a GetModelForClassOptions argument, but this argument is never used in the cache mechanism.
Hence, if you call getModelForClass with different options, the cache will not notice it and the returned Model won't be the one expected.
I guess it doesn't much make sense to create two different Model from the same class. I suggest that the GetModelForClassOptions should be placed somewhere else.
The ideal thing for me would be something like this :
@modelOptions({
    existingMongoose: /* ... */,
    existingConnection: /* ... */,
    schemaOptions: /* ... */,
})
export class Entity extends Typegoose { /* ... */ }
export const Model = new Entity().getModelForClass(Entity); //No more option allowed here

This way, you cannot use differents options anymore on the same class and you can use getModelForClass() multiple times without fear.
The alternative would be to use the options as keys in the cache. But it seems useless from my point of view.
What do you think ? I'm willing to write a PR if this makes sense to everyone.

as with version 6.0.0 model options are moved to the @modelOptions decorator
@Ben305 This can be closed


[question] How to handle chained methods

Forgive me if I didn't see this in the example section;
How should I handle chained methods? Below is a mongoose example.
Story
.findOne({ title: 'Once upon a timex.' })
.populate('_creator')
.exec(function (err, story) {
...
}

I tried something like this, but that doesn't seem to work...
Story.findOneAsync(({ title: 'Once upon a timex.' }))
.populateAsync('_creator')
.exec(function (err, story) {
...
}

Saved my life @uschen . I don't know why but it's not documented anywhere that you do limit / populate etc like normal then do an execAsync after to get it all working... Appreciate it

@uschen You rock!

Saved my day too, @uschen
Thanks!

mine too @uschen


option to avoid stopping on entry with the debugger

Start debugger without stopping on entry

implemented in debugger - you can now set it in JSON, but needs UI

Typically one needs to edit launch.json.

From: Michał Moskal @.>
Sent: Thursday, March 16, 2023 5:28:40 PM
To: microsoft/devicescript @.>
Cc: Peli de Halleux @.>; Assign @.>
Subject: Re: [microsoft/devicescript] option to avoid stopping on entry with the debugger (Issue #231)
Assigned #231https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdevicescript%2Fissues%2F231&data=05|01|jhalleux%40microsoft.com|42ff1c1ad2834525e8b908db267e8f38|72f988bf86f141af91ab2d7cd011db47|1|0|638146097235867380|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=AaRYo4mdaNFgOdQjirfvQ9r9dXB7LNdxjEvuNrmDJkQ%3D&reserved=0 to @pelikhanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=05|01|jhalleux%40microsoft.com|42ff1c1ad2834525e8b908db267e8f38|72f988bf86f141af91ab2d7cd011db47|1|0|638146097235867380|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=3TY%2Fl41J3lG3IalJ%2FRnarUoEMMUzPyaSkHmk0WKof3Y%3D&reserved=0.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdevicescript%2Fissues%2F231%23event-8773168071&data=05|01|jhalleux%40microsoft.com|42ff1c1ad2834525e8b908db267e8f38|72f988bf86f141af91ab2d7cd011db47|1|0|638146097235867380|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=07J6A3rHyYcYeLKvijTbvc1XybwSKGNCxWdk5NENg48%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKLC3RVWTSFCJVB675DW4OV3RANCNFSM6AAAAAAV52N4NQ&data=05|01|jhalleux%40microsoft.com|42ff1c1ad2834525e8b908db267e8f38|72f988bf86f141af91ab2d7cd011db47|1|0|638146097235867380|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=T%2FrSYXBaAOfDsThBC22uklZuoRLMcuwiS5MM91lyx6A%3D&reserved=0.
You are receiving this because you were assigned.Message ID: @.***>


JMLL-911 Send reminder emails on working days

Codecov Report

Merging #203 (0d70dcf) into main (ff16a8d) will decrease coverage by 0.68%.
The diff coverage is 65.34%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   75.06%   74.38%   -0.69%
==========================================
  Files         179      185       +6
  Lines        6428     7225     +797
==========================================
+ Hits         4825     5374     +549
- Misses       1603     1851     +248

Impacted Files
Coverage Δ

config/settings/base.py
93.60% <ø> (-0.65%)
:arrow_down:

core/people_finder/client.py
39.74% <0.00%> (-1.51%)
:arrow_down:

core/people_finder/interfaces.py
65.11% <0.00%> (ø)

core/uksbs/client.py
84.93% <ø> (ø)

core/uksbs/interfaces.py
75.00% <ø> (+3.12%)
:arrow_up:

core/uksbs/types.py
100.00% <ø> (ø)

core/urls.py
100.00% <ø> (ø)

leavers/views/security_team.py
33.21% <0.00%> (-2.67%)
:arrow_down:

leavers/utils/emails.py
18.70% <12.85%> (-2.10%)
:arrow_down:

core/utils/staff_index.py
38.73% <20.00%> (+0.34%)
:arrow_up:

... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Feature/bump yes argument

Codecov Report

Merging #22 into master will increase coverage by 2.73%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage    77.5%   80.23%   +2.73%
==========================================
  Files          24       24
  Lines         520      501      -19
==========================================
- Hits          403      402       -1
+ Misses        117       99      -18

Impacted Files
Coverage Δ

commitizen/cli.py
86.2% <ø> (+35.22%)
:arrow_up:

commitizen/commands/bump.py
15.62% <0%> (-0.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbdaf07...87ffb0a. Read the comment docs.


Child User Story #12

As a user, I want to see the website when I visit its address so that I can view its contents.
Acceptance criteria pending.

@jriggall

When the dev server starts up, every localhost:3000 request will be routed to our website
append any invalid route e.g. localhost:3000/nothing to have the 404 page appear


I want to contribute

Recently, I started making open-source contributions. I made some contributions to Flutter and Android apps. Now I want to make a contribution to some libraries. I have used Appwrite personally for one of my Flutter projects, so it will be great if I can contribute to this library. Let me know if there is anything for me (bug fix, feature, improvement, or unit test).

Welcome! Make sure to check out https://github.com/appwrite/appwrite/discussions/4899


Support format 'yyyyMMdd HH:mm:ss' for legacy mode [databricks]

closes #11657
Support format 'yyyyMMdd HH:mm:ss' for legacy mode
Similar to this PR: https://github.com/NVIDIA/spark-rapids/pull/11493
Signed-off-by: Chong Gao<EMAIL_ADDRESS>

build


Update use-remote-desktop.md

more consistent if you are using systemctl (systemd) everywhere...

@mattmcinnes
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@mattmcinnes
Can you review this old PR and determine whether it needs to be closed or merged?

@mattmcinnes
Can you review this old PR and determine whether it needs to be closed or merged?

I sent an email to the content owner today.

I sent a Teams message to the content owner today.

Thank you for your interest in contributing to our documentation. Unfortunately, the changes in this pull-request cannot be accepted because our Content group is migrating content for the "virtual-machines", "virtual-machines-scale-set", "container-instances", and "service-fabric" folders to a new repository: azure-compute-docs.
Short-term, if there are changes in this PR for other folders, you can move forward with those by removing the change(s) to all the above mentioned folders' content.
In the meantime, we are closing this PR and tagging it so that when the content is available in the new repo, we can follow up with the new location information.
#please-close
#label:"migrate-followup"

I am disappointed that a simple correction has taken more than five months to review, particularly given that everything has been migrated. This is not the first time I have had a disappointing experience with MS (SQL Server BDC, SQL Server ml services etc.). I was here to help as a community member, but it seems MS is still more like a slow-moving company than an inspirational group of people.
I wish you the best You guys are here!

@mattmcinnes  @kesadae11
The virtual machines content set has completed migration and contributions to are once again possible in the new repo: https://github.com/MicrosoftDocs/azure-compute-docs.
@mattmcinnes -This seems like a change you'd like to consider. If so, can you or @kesadae11 open a PR in the new repo to submit your changes.
We appreciated your patience during this migration.

I made a new PR in the mentioned repo. You can find here: https://github.com/MicrosoftDocs/azure-compute-docs/pull/3.
No problem, migration is never simple.


Fix setup in transformed class

setup was called outside of transform
which made parameters inside setup
misbehave.
See test case for example

Codecov Report

Merging #696 (6e63bb8) into master (3a5db4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   80.66%   80.67%
=======================================
  Files          56       56
  Lines        4267     4269    +2
=======================================
+ Hits         3442     3444    +2
  Misses        825      825

Impacted Files
Coverage Δ

flax/linen/transforms.py
94.33% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5db4d...6e63bb8. Read the comment docs.


Advance DatabaseDownloder unittest

High Level Overview of Change
This pull request aims to fix spurious failures in the DatabaseDownloader unit test by increasing a timeout value that purports to be the source of the false positives.

Context of Change
A timeout value that determines how long the test waits before indicating failure was increased. The error is not reproducible so, lest the issue recur, this PR introduces additional logging information that would hopefully shed some light on the cause.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Future Tasks
Should the failure persist, consult the log output to assist in diagnosing the issue.

Squashed PR commits and rebased onto HEAD of develop

One nit: we should improve the commit message. "Advance DatabaseDownloader unittest" doesn't describe what's in the patch or the motivation for the patch.

Done


Use TObjectPtr when possible

Also fixes compile issues with upcoming Unreal 5.5 update.

Oh, are they finally requiring TObjectPtr in 5.5?

Oh, are they finally requiring TObjectPtr in 5.5?

Yes, as long as they don't change their mind, 5.5 throws compile errors for non TObjectPtr pointers in header files.


updating nic ip-config results in error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network nic ip-config update
Errors:
pop from empty list
Traceback (most recent call last):
Temp\pip-install-ygnynjtx\knack\knack\cli.py, ln 206, in invoke
azure\cli\core\commands\__init__.py, ln 560, in execute
azure\cli\core\commands\__init__.py, ln 618, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 611, in _run_job
Local\Temp\pip-install-ygnynjtx\six\six.py, ln 693, in reraise
azure\cli\core\commands\__init__.py, ln 588, in _run_job
azure\cli\core\commands\__init__.py, ln 297, in __call__
azure\cli\core\commands\arm.py, ln 523, in handler
azure\cli\core\commands\arm.py, ln 804, in set_properties
azure\cli\core\commands\arm.py, ln 966, in _get_name_path
IndexError: pop from empty list

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network nic ip-config update --nic-name {} --ids {} --set {} {} {}

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.66

Additional Context

What are the inputs you are actually using (redacted in the initial report)? I see a usage error in that you should not be specifying --ids and --nic-name. What are you trying to set?


queue processors: Add coverage for SlowQueryWorker.

The first commit replaces #7284.
I manually tested both queues with print statements in my dev server.

Yeah, the regex I used seems to only work locally.

Updated, should work now.

Merged, thanks @derAnfaenger!  queue_processors.py is now at 89% coverage, which is awesome!


iOS 13.1 - iPad/iPhone contextmenu/longtap issue on Markers

This is linked to #6817 fixed by  #6855.
How to reproduce: http://www.mappite.org/tap/testTap.html
Leaflet Version: Leaflet master as of yesterday (with #6855 in)
Long tap on map: works thanks to #6855, alert appears highlighting a contextmenu/longtap has been detected
Long tap on marker: user gets screen to save/share Marker icon, after closing it the alert appears
Expected behavior: when long tap on Marker OS menu to save image should not appear
Relevant code:

var map = L.map('map', { center: [44.22253, 11.77083], zoom: 4, maxZoom: 18, layers: [ L.tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png')` ], attributionControl: false, tap: true});
map.on('contextmenu', function(e) {alert("MAP: contextmenu/longtap detected"); });
var m = L.marker([44.22253, 11.77083]);
m.on('contextmenu', function(e) {alert("MARKER***: contextmenu/longtap detected"); } );
map.addLayer(m);

(It's probably more appropriate to post here, instead of on the closed issue)
Hi @eliboni,
It seems you need to use -webkit-touch-callout: none; (or similar... I'm bad at this 😅) on the elements. Unsure on which, though. Adding * { -webkit-touch-callout: none; } worked on my test (contextmenu event triggered on a marker, using an iPhone).
Adjust as you need.
Maybe leaflet can have a class with that CSS for when contextmenu events are listened on by markers? Otherwise, it might best to fix on the page using leaflet?

@filcab many thanks. It worked by adding this to just the leaflet-marker-icon class:
.leaflet-marker-icon { -webkit-touch-callout: none; }
Test URL: https://www.mappite.org/tap/testTap2.html
I agree on your suggestion. I wander why this was not needed in the past, is this really linked to #6817?

I think iOS13 might have changed something.
But I don't think this is 6817, as that bug was about events not triggering at all due to PointerEvents being available.
These aren't triggering due to webkit features for long tap, which have to be disabled.

I see similar issue on Android, with Firefox Preview 4.0.0

Any news on this one? Also with 1.8.0, when long tapping on a marker (iOS 15.5), the event is properly handled by leaflet but the marker then gets magnified with teh option to close it. I'm wondering if this is connected with @1926 , anyway  "-webkit-user-select: none" does not seem to have solved the issue.
https://imgur.com/J8DE8bQ.png

@eliboni does it also happens when you make a long click on the zoom control and while making a long click on the shadow of the marker?

When clicking on shadow the behaviour is different, the "+" of the zoom
control gets selected! The same happens when long tap anywhere else on the
map
On Fri, May 20, 2022, 17:43 Florian Bischof @.***>
wrote:

@eliboni https://github.com/eliboni does it also happens when you make
a long click on the zoom control and while making a long click on the
shadow of the marker?
—
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet/issues/6865#issuecomment-1133052250,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEGPNA5K3TY72HBYVXCBY53VK6XIRANCNFSM4JCJUJ7Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Re https://github.com/Leaflet/Leaflet/issues/6865#issuecomment-1133030697:

added to default leaflet.css
.leaflet-marker-icon { -webkit-touch-callout: none; }

Sure, but that would only fix the issue in Safari.
Re https://github.com/Leaflet/Leaflet/issues/6865#issuecomment-1133116467:

When clicking on shadow the behaviour is different, the "+" of the zoom
control gets selected!

That's about text selection, separate issue: https://github.com/Leaflet/Leaflet/issues/6872.
(However, even the <a href="#"> controls (e.g. zoom controls) can prompt the URL "touch callout", that issue would be fixed by either https://github.com/Leaflet/Leaflet/issues/7821 or https://github.com/Leaflet/Leaflet/issues/7368.)

Re #6865 (comment):

added to default leaflet.css
.leaflet-marker-icon { -webkit-touch-callout: none; }

Sure, but that would only fix the issue in Safari.

Well, the issue is only with Safari

@eliboni No, see https://github.com/Leaflet/Leaflet/issues/6865#issuecomment-599536458. I can also reproduce on Android.

EDIT: corrected jsfiddle.net link above, the issue does not appear with older leaflet versions (1.0 for example).


Make the room creation password protected by default to ensure security

It will be better to make the password protection as be default to make sure the user makes use of password secure rooms easily.


Replace type assertion/explicitly typed expressions with the type cast expression

Opening a new PR in place of #13161.
Purpose
This PR replaces type assertion and explicitly typed expressions with the type cast expression as specified in the v0.990.0 spec.
To Do:

[ ] update balo version
[x] update type assertion BBE as the type cast BBE - changes on https://github.com/MaryamZi/ballerina/tree/fix-type-cast-BBE, will send a separate PR.
[ ] rename method names - assertion to cast
[ ] rename conversion nodes as cast nodes

Codecov Report

Merging #13479 into master will increase coverage by 0.05%.
The diff coverage is 91.8%.

@@             Coverage Diff              @@
##             master   #13479      +/-   ##
============================================
+ Coverage     63.99%   64.04%   +0.05%
  Complexity      659      659
============================================
  Files          2148     2148
  Lines         94305    94430     +125
  Branches      12414    12429      +15
============================================
+ Hits          60347    60478     +131
+ Misses        29062    29053       -9
- Partials       4896     4899       +3

Impacted Files
Coverage Δ
Complexity Δ

.../ballerinalang/compiler/codegen/CodeGenerator.java
91.69% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../ballerinalang/util/codegen/PackageInfoReader.java
90.96% <ø> (ø)
0 <0> (ø)
:arrow_down:

...java/org/ballerinalang/util/codegen/Mnemonics.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../org/wso2/ballerinalang/programfile/Mnemonics.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...llerinalang/compiler/semantics/analyzer/Types.java
76.26% <100%> (+1.07%)
0 <0> (ø)
:arrow_down:

...g/ballerinalang/util/exceptions/RuntimeErrors.java
89.58% <100%> (ø)
0 <0> (ø)
:arrow_down:

...alang/compiler/semantics/analyzer/TypeChecker.java
86.18% <100%> (ø)
0 <0> (ø)
:arrow_down:

.../java/org/ballerinalang/model/values/BDecimal.java
78.67% <100%> (+2.67%)
0 <0> (ø)
:arrow_down:

.../java/org/ballerinalang/model/values/BInteger.java
83.33% <100%> (-3.04%)
0 <0> (ø)

...ain/java/org/ballerinalang/model/values/BByte.java
60.86% <100%> (+1.77%)
0 <0> (ø)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50aef30...f19e9d9. Read the comment docs.


Neuer JS Controller Update

Nach dem Update auf js 4.0.15 kam dieser Fehler

Müsste in der nächsten Version berichtigt werden.

Any update on this?

Same issue here. I use the adapter to set GPIO pin.
Seems to be related to this [https://github.com/frankjoke/ioBroker.radar2/issues/43] from same author

In controller 4 this warning will throw, so could you please ensure, that it gets fixed and create a new release. You can simply replace
ioBroker.radar2/fjadapter-core.js
Line 327 in f3708e9
this.c2p(adapter.objects.getObjectList).bind(adapter.objects);
by adapter.getObjectList

I have exactly the same issue after updating ioBroker and the JS controller.
What helped in my case:
in file /opt/iobroker/node_modules/iobroker.systeminfo/myAdapter.js
change line 44 from
this.getObjectList = this.c2p(adapter.objects.getObjectList).bind(adapter.objects);
to
this.getObjectList = this.c2p(adapter.getObjectList).bind(adapter.objects);
(The change proposed by @Tottback seemed to solve some problems, but that only led to error messages a little bit later in the process. My change solves the issue completely - at least for my setup.)
I'd love to see a fix release soon, even if it's just this tiny change :smiley:

The Issue seems allready be fixed. If i installad the "github-master" version, this adapater works fine again.
@frankjoke: Can you please publish a new release?

please verify with release 1.0.0

should be fixed with 1.0.0
Please create new issue if problems persist.


Add ZeroNet

Right format?

Closing as this didn't get any traction. I encourage you to create such a list though.


Add support for prometheus metrics

In order to monitor the parts of the real-time stack, it would be very beneficial to have a way to monitor each step of the pipeline. For example, how many requests got into the collector, how much got out to kinesis, how many instances are running in each stage? I know we can send some metrics into the collector itself, but it feels wrong to send data to an endpoint, that i actually want to monitor itself.
I would really like to see support for prometheus for collector, enricher and storage sinks. All it requires is a http server listening to a given port and expose some metrics in pre-defined text format.
What do you think?
https://github.com/prometheus/prometheus

Yes good idea, we have had customers asking for this... Any suggestions on the metrics?

For the collector, i think the usual suspects for any http endpoint:

http_requests_total{path, code, method}
http_request_duration_seconds_count
http_request_duration_seconds_sum
http_request_duration_seconds_bucket
http_request_size_bytes
http_request_size_bytes_count
http_request_size_bytes_sum

Also for all parts reading from and writing to kinesis/kafka

kinesis_events_write_total{type,format,retry,failure/success}
kinesis_events_read_total{type,format,retry,failure/success}

For all parts in common:

build_info{scalaversion,javaversion,version,gitsha}

Add anything that the parts send as data metrics to the collector right now.


Small tweaks to Aqara P1 motion sensor

Codecov Report

Merging #1587 (bc4e7f2) into dev (c64695a) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #1587      +/-   ##
==========================================
- Coverage   80.29%   80.26%   -0.03%
==========================================
  Files         231      231
  Lines        6927     6933       +6
==========================================
+ Hits         5562     5565       +3
- Misses       1365     1368       +3

Impacted Files
Coverage Δ

zhaquirks/xiaomi/aqara/motion_ac02.py
60.78% <50.00%> (-1.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64695a...bc4e7f2. Read the comment docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 6 (50.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 80.268%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/xiaomi/aqara/motion_ac02.py
3
6
50.0%

Files with Coverage Reduction
New Missed Lines
%

zhaquirks/xiaomi/aqara/motion_ac02.py
1
60.78%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
5565

Relevant Lines:
6933

💛  - Coveralls


$\text{somthing}$ crashes Obsidian

How to reproduce:

In the sandbox vault, in a blank line,
Use mk to get $$
type \text{t}
Hit Tab to tabout }
Hit another letter

Thank you for reporting this! I've fixed it in 1.2.1.


Removed event on account creation

During account creation on Goerli testnet I have an error during the deployment because of this  line in initializer
This error is not caught with the test in python.
I past below the error I have. This error is thrown deploying through both UDC and deployAccount
GatewayError: Error at pc=0:89:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:336)
Unknown location (pc=0:312)

Error in the called contract (0x7052d555b167b3a6f2e8a17d86939a7a8263368178a7b3db7922a2239a5e62e):
Error at pc=0:50:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:1276)
Unknown location (pc=0:1256)
Unknown location (pc=0:519)
Unknown location (pc=0:463)
Unknown location (pc=0:440)

Traceback (most recent call last):
  File "<hint7>", line 3, in <module>
AssertionError: normalize_address() cannot be used with the current constants.
    at SequencerProvider.fetchEndpoint (file:///Users/thomas.brillard/Documents/Starknet/deployer/node_modules/starknet/dist/index.mjs:3185:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Account.estimateAccountDeployFee (file:///Users/thomas.brillard/Documents/Starknet/deployer/node_modules/starknet/dist/index.mjs:4403:22)
    at async Account.getSuggestedMaxFee (file:///Users/thomas.brillard/Documents/Starknet/deployer/node_modules/starknet/dist/index.mjs:4602:23)
    at async Account.deployAccount (file:///Users/thomas.brillard/Documents/Starknet/deployer/node_modules/starknet/dist/index.mjs:4541:49)
    at async file:///Users/thomas.brillard/Documents/Starknet/deployer/deploy.js:87:48 {
  errorCode: 'StarknetErrorCode.TRANSACTION_FAILED'
}

Hm that is weird, since we've been using the contract with it for awhile now. I wonder why might have changed? Could be worth escalating to the starkware team

Hm that is weird, since we've been using the contract with it for awhile now. I wonder why might have changed? Could be worth escalating to the starkware team

I've check before creating the issue OZ and Argent's current deployed contracts and they are not using this event.
It seems you are with cartridge like here
Can you share me your deploying script?

We deploy using caigo and the udc like:
{
				ContractAddress:    types.HexToHash(UDCAddress),
				EntryPointSelector: "deployContract",
				Calldata: []string{
					ProxyClass,
					types.UTF8StrToBig(salt).String(),
					"0",
					"12",
					AccountClass,
					types.GetSelectorFromName("initialize").String(),
					"9",
					ControllerClass,
					"7",
					limbs.x0.String(),
					limbs.x1.String(),
					limbs.x2.String(),
					limbs.y0.String(),
					limbs.y1.String(),
					limbs.y2.String(),
					signer,
				},
			}
			```


Avoid lib symlink

Export realm_dart.dart from realm package

There should be no user visible change, so I have skipped the CHANGELOG entry.

Looks good. So now the realm package in pub.dev will have a dependency on realm_dart for the dart source code and just add some native sources that pull the binaries automatically rather than relying on an install command?

Yes, and we just re-export all that is exported by realm_dart. It should not make a difference to our users.


Can turn on but cannot turn off DSP-W110

I stumbled across this code from another site that referred to this Gitbug project. I have the presumably older DSP-W110 1.22 firmware. Using the code here while I can turn on a device attached to the Dlink it won't respond to turn off commands. I can't see any way to see what commands the device responds to since the /HNAP1 produces a message saying
This XML file does not appear to have any style information associated with it. The document tree is shown below.
and there is no  XML below.
Any ideas how to find out what the OFF command string might be?
Thanks

solved - got the wrong code to send to the device

@laurence7 Were you able to able get it to work? I'm trying the same thing, can you elaborate a little how did you manage to get this to work?

I did but that was 4 years ago and since then I have lost the code I did. Plus I moved away from that solution over 3 years ago when Amazon Alexa and Google Assistant supported the D-Link device natively.


[Docenhancement][Invokepayloadsize][4135]

Updated the invoke payload size.

Docs Build status updates of commit 8dd22f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
95
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
95
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0feff48:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


pyload-ng: add 'meta.mainProgram'

Description of changes
nix run nixpkgs#pyload-ng works now.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ruby0b pinging you on this PR, as I couldn't find a better way to contact you. How did you configure the webui to change the user/password?
If you've got Matrix, or another way of contacting you, please reach out outside of GitHub (you can find my contact info on my profile) so that I can pick your brain :-)


Cannot resolve ./runtime/envConfig

If I run
node ./node_modules/klassi-js/index.js -s [path to my step definitions]
I get:
    throw err;
    ^

Error: Cannot find module './runtime/envConfig'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/wolas/sensotransel/sensotransel-vision/node_modules/klassi-js/index.js:51:17)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Function.Module.runMain (module.js:694:10)
    at startup (bootstrap_node.js:204:16)
    at bootstrap_node.js:625:3```

By the way - why klassi-js is not registered as an executable as any other npm package so I can use it as:

`klassi-js -s [path]` in my npm package.json scripts ?

Hi wolass,
Thanks for the spot, I have updated the command as it should read " node ./index.js -ds ./step_definitions "
As for your question I am not following can you give me an example of what you are trying to say please


Some items missing images

Some items (notably some mega stones) don't have the images on the site, here's a list
Abomasite
Aggronite
Altarianite
Ampharosite
Audinite
Banettite
Beedrillite
Blazikenite
Cameruptite
Diancite
Galladite
Gardevoirite
Heracronite
Houndoomite
Latiasite
Latiosite
Lopunnite
Manectite
Mawilite
Pidgeotite
Sceptilite
Steelixite
Swampertite
Tyranitarite
As well as the image of Custap Berry that's missing, noticed it when i wanted to put some old gen teams

and oh didnt check if Mewtwonite X and Mewtwonite Y had their images

Thanks so much for this! I'm going to be pretty flat-out with school stuff for the next week or so, but I'll try to add these as soon as I can.

yw

Also, King's Rock doesn't have an image either

remind

Sorry I took so long about this - I really need to regenerate all the item databases (hence why I'll leave this issue open), but this should do as a stopgap solution at least.

Ow, thanks =D

Ow, noticed that you forgot the Medichamite ;)

With the new codebase, I think this should all be taken care of.


[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Follow-up of https://github.com/Homebrew/brew/pull/11977#discussion_r702993165 . The only issue I couldn't figure out is how to have the --commit switch have multiple depends_on arguments. Otherwise this should be backward compatible.

Thanks @Moisan!


Explicit size for integer types

I predict that in long run implicit size of integer types will cause us a headache. I propose to introduce a kernel source wide policy to adopt int*_t and uint*_t types among others available in stdint.h.

FreeBSD provides sys/_stdint.h header file.

Convention adopted. Nothing to do here.