[bug 1146686] Fix triggerrule testing

The triggerrule testing thing was sending [''] for fields like locale
which are \n delimited textareas. That now causes an HTTP 400 error.
This fixes that by filtering out empty strings before generating the
request to send to the API.
Note: This commit was buried in the django-1.8 pr. I cherry-picked it and removed it from the Django 1.8 pr.
r?

This isn't covered by the unit tests. The smoketests don't cover the analyzer stuff, either. I re-tested it by hand and verified that it's broken in master and works with this patch.
Given that, I'm going to self-r+ this.


Does not open games blocked in the region

I live in a region where titanfall 2, fallout 4, helldivers, borderlands, etc are blocked.
And when trying to open these games in the launcher it just returns to the window back.

Have you tried to disconnect your computer from the internet before launching the game?
You can also try to use a VPN and connect to another country to try to bypass the blockade.

You can also try to use a VPN and connect to another country to try to bypass the blockade.

I can open games with vpn, I hope to be able to open games without regional difficulties later on

not an hydra issue i guess

Not an Hydra issue at all. Closing this.


Adds a .editorconfig

Description of the Change
Adds a .editorconfig file which will make some editors automatically follow the formatting rules outlined in CONTRIBUTING.md
Benefits
Can't hurt and it saves headaches from having to reconfigure editors.
Sample Usage
http://editorconfig.org/

Cool. We'll need someone on VS 2017 to verify this since native editorconfig support was added in 2017 as far as i know.

Looks like you're gonna need a plugin for VS2017 pre rc1, but higher versions come with automatic support:
https://github.com/editorconfig/editorconfig-visualstudio#vs-2017

Can't see any issues with this, feel free to augment as it evolves


suggestion: better monorepo setup

Currently all overlays leverage some form of React, you could just move the "overlays" folder up and have this set up initially as a template repository - this would improve awareness and discoverability for your projects, enabling some users to test your set up more easily and potentially contribute !

looking back at it, Lerna seems like a good idea as well - can contribute some helpful workflows if you want to give it a try in the future !


Docs: Added documentation for .retry and .timeout for helpers

Added documentation for .retry and .timeout for helpers as found in the following locations:

Internal Fleet.dm Code
Sails Changelog
.timeout in Parley

Hi @rachaelshaw and @eashaw, was wondering if this needed any further review, hoping to get this merged out to the docs site at some point since this was a cool feature not documented anywhere except in some release notes.

@rachaelshaw @eashaw @mikermcneil bump for help merging improved docs on undocumented features (helpers .retry() and .timeout()

Hey @eashaw do you think we can move this forward for merging?

I have been looking for this. Thank you so much @DominusKelvin for pointing it out. I wonder why it's not merged yet


Put Changes.rst updates in tag

Hiya!  This is just a pedantic request!  I've noticed that in the last two tags, the update to the CHANGES.rst for the changes in the tag arrived in a commit to master after the tag was made.  This confused me for 2.1.0, as I was only looking at the CHANGES.rst file for that tag, and wasn't sure what had made it in.
In the future, could you modify the CHANGES.rst file before that tag is made?  In my own projects, I've done this by updating the changelog in the commit that actually made a change.  E.g., you could maintain a 2.1.1 (SNAPSHOT) (or (ALPHA) or (WHATEVER)) tag at the top of CHANGES.rst, and then change it so it says the date of the tag when you make the tag.
Or do whatever you want! :)  Thank you!

@ottomata Thanks for the input. My method has been to tag the latest commit, then write and commit changes to the changelog and version number. Now that I think of it, my original reason for doing it this way doesn't make any sense - it doesn't actually keep the /compare view any cleaner since the changelog updates from the previous version leak in. I think i'll start including the changelog commit in future versions.

Thanks! :)


Typo in seeds.rb

There is line https://github.com/refinery/refinerycms-news/blob/master/db/seeds.rb#L19 with
default_page_part[:slig]

Probably, there should be "[:slug]" key?

Thanks @sintro, it's fixed


find a way to distinguish replayed reexecute notebooks from replayed without reexec

four possible states:
A) plain old new tab
B) replayed notebook with reexec
C) replayed notebook without reexec
D) ibid but after user reexecutes at least one block
Suggestion: maybe A and D can have the same UI, since D implies an explicit grabbing of ownership by the user.
Possible ways to visually distinguish these states:

change status stripe color
add a status stripe parenthetical text, e.g. (showing pre-recorded output)
graying/obscuring Output elements

/remove-lifecycle rotten
/reopen


Re-enable VFS retention soak test

now that the crashes are fixed.

@bot-gradle test QuickFeedbackLinux plz

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle help

Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.

@bot-gradle help to display this message


Host Ionic v1 Software

I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request

URL:

Current behavior:

Expected behavior:

Steps to reproduce:

Other information:

Issue moved to USER.


[now-cli] Remove now update from --help output

Fixes #2940.

Codecov Report

Merging #2951 into canary will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           canary    #2951      +/-   ##
==========================================
+ Coverage   11.36%   11.84%   +0.47%
==========================================
  Files         267      267
  Lines       10177    10242      +65
  Branches     1257     1249       -8
==========================================
+ Hits         1157     1213      +56
- Misses       8931     8937       +6
- Partials       89       92       +3

Impacted Files
Coverage Δ

src/util/dev/builder-cache.ts
77.44% <0%> (-3.43%)
:arrow_down:

src/util/metrics.ts
68.18% <0%> (-2.41%)
:arrow_down:

src/commands/deploy/args.js
0% <0%> (ø)
:arrow_up:

src/util/projects/get-project-by-id-or-name.ts
28.57% <0%> (+3.57%)
:arrow_up:

src/util/get-files.ts
91.66% <0%> (+3.88%)
:arrow_up:

src/util/prefer-v2-deployment.ts
61.9% <0%> (+5.65%)
:arrow_up:

src/util/output/create-output.ts
43.58% <0%> (+12.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e033e5e...ef8b90f. Read the comment docs.


Increment and decrement overclock value buttons don't work properly

The increment and decrement buttons, aside from being quite small, don't seem to allow more than one single click between movements of the mouse i.e. you must click, move the mouse slightly, then click again. Click and hold works as expected, though it's a bit less useful without the calculations updating live so you know about when to release.

I know the cause of this, at least: Each time you change that value, it recomputes the solution, which causes it to re-render the whole page. The element you click on the first time is an entirely different element than the one you click on the second time.
It is worth noting that this problem does not occur in Firefox.
I had this same problem in the Factorio calculator, and the solution here is the same as what I did there: Make the elements persistent when possible, and update their values, rather than regenerating the whole thing every time. I implemented it this way first (both times) because it is much more expedient.

It turns out this wasn't quite as painful as I thought it would be. Score one for d3. Fixed in ba048b624c4448312606765b5cb28d2a84a0cfe6.

I am using Chrome. I notice that the buttons now affect the input number upon successive clicks, but the solution does not update until a mouse move followed by another click. The mouse doesn't have to leave the button entirely now, which is nice, but it still requires a little "wiggle". Is it possible to recalculate just the item page's numbers on every input value change without incurring updates that require redrawing the page?

971e01c96ae830ff9c53ee2103d05ce097463ef7 changes the input from using a "change" event to using an "input" event, which will take effect more frequently.
However, it is worth noting that these arrows are merely the browser's native arrows from using an <input> field with type="number". There is apparently an outstanding bug in Chrome which affects such fields; there isn't much I can do about that.

I wasn't seeing anything related to that Chrome bug you linked, as far as I can tell. Update #971e01c seems to have fixed every issue I saw and it's working as expected now.


RE command error

Enter recipe_exporter instruction indicating that this command cannot be found.
The re command could not be entered.
Command prompts such as recipe_exporter export items Error: Console may not execute this command

Yeah as the error says console cannot run the command you have to run it as a player, I'll be changing it soon but that's not a big priority atm

Can you confirm if the latest push  resolved this?


Update Vue's docs

Adds info to docs about a necessity of using a unique :key when using the library with Vue.js.

Thanks!


MyVariantInfo

Errors in MyVariantInfoServiceImpl, likely from MyVariantInfoDataFetcher getForObject method.

Codecov Report

Merging #203 into master will decrease coverage by 0.87%.
The diff coverage is 25.47%.

@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
- Coverage     39.89%   39.02%   -0.88%
- Complexity      208      216       +8
============================================
  Files            98      113      +15
  Lines          1589     1694     +105
  Branches        210      216       +6
============================================
+ Hits            634      661      +27
- Misses          862      936      +74
- Partials         93       97       +4

Impacted Files
Coverage Δ
Complexity Δ

...genome_nexus/web/mixin/VariantAnnotationMixin.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...bioportal/genome_nexus/service/mixin/VcfMixin.java
0% <0%> (ø)
0 <0> (?)

...portal/genome_nexus/service/mixin/SnpeffMixin.java
0% <0%> (ø)
0 <0> (?)

...us/service/remote/BaseExternalResourceFetcher.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...bioportal/genome_nexus/service/mixin/AnnMixin.java
0% <0%> (ø)
0 <0> (?)

...cbioportal/genome_nexus/web/mixin/SnpeffMixin.java
0% <0%> (ø)
0 <0> (?)

...tal/genome_nexus/web/mixin/MyVariantInfoMixin.java
0% <0%> (ø)
0 <0> (?)

...xus/service/cached/CachedMyVariantInfoFetcher.java
0% <0%> (ø)
0 <0> (?)

...nexus/service/remote/MyVariantInfoDataFetcher.java
0% <0%> (ø)
0 <0> (?)

...vice/enricher/MyVariantInfoAnnotationEnricher.java
0% <0%> (ø)
0 <0> (?)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44efc8f...78b874e. Read the comment docs.


The fields we're using for the json are not final

Are there other fields that would be useful to have in the response?

Adding total_pages soon

We need to add next_page

I think we are done with this for now. What do you think @icoluccio @alanhala ?


Is the blank page app icon broken?

Issue Type: Bug
details
What is going on with this:

VS Code version: VSCodium 1.48.0 (db40434f562994116e5b21c24015a2e40b2504e6, 2020-08-13T19:51:58.435Z)
OS version: Darwin x64 20.0.0 - macOS Big Sur beta (20A5343i)

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1060NG7 CPU @ 1.20GHz (8 x 1200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.51GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.5

synthwave-vscode
Rob
0.1.5

rewrap
stk
1.11.1

lorem-ipsum
Tyr
1.2.0

markdown-all-in-one
yzh
3.0.0

vscode-asciiflow2
zen
0.2.0

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

@mjbvz no it doesn't, but it is reproducible in latest build of vscodium with extensions disabled.

Ah jeez I'm sorry, it seems that VSCodium has changed their app logo in general with their latest release, I didn't notice it anywhere but the blank document page previously. Closing this, sheepishly.


seccompIter: allow blocking calls

If a syscall isn't rejected after 100ms, it's allowed and is just
blocking.
In particular MSGRCV will block on a message entering the queue - https://linux.die.net/man/2/msgrcv
This leaks 1 goroutine per allowed-but-blocking syscall, which is probably OK from main.go.
Closes https://github.com/genuinetools/amicontained/issues/18

CI failure does not look related.

If the seccomp program returns SECCOMP_RET_TRACE, the decision will be deferred to an external tracer and it can block for longer. But container runtimes don't use that facility yet, so it should be good :)

awesome, thanks!


Mangadex setting resets (actual app issue)

Steps to reproduce

Have enable delegated sources on
change settings in mangadex
create backup
clean data and restore backup

Expected behavior
The settings changes should be kept
Actual behavior
The settings get reseted
Crash logs
N/A
Komikku version
r9643
Android version
Android 14
Device
Samsung Galaxy A55
Other details
Mihon doesn't have this issue. haven't tested in SY
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.12.1.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Just noticed that it actually happens with other sources, specifically the delegated ones.


Release Zip does not contain main.js

Apologies if this is not in a great format.
Environment

OS Windows 10, latest service pack
Obsidian Version v1.1.16
Installer Version v0.14.6

Issue
After installation, I cannot enable the plugin in Obsidian.
Process
Following the instructions from the README.md file, I did the following:

Followed the link to the latest release of the repository, and downloaded the zip file attached (as I had read ahead slightly to "...downloaded zip file...").
Extracted the zip into (vault)/.obsidian/plugins directory
Restarted Obsidian
Located the plugin in the Installed Plugins list

However, I could not enable it.  I received only a very generic "Plugin could not be enabled" error from Obsidian, and was in the process of locating any internal log files.  It occurred to me to check the plugin folder for one (fruitless, of course).  This led me to check the other plugin folders and notice each had a main.js and manifest.json basically.  Checking the whisper-obsidian-plugin-0.1.0 directory however, only main.*ts* was present.
Quick Fix
Returning to the Releases page, one of the additional listed files was main.js, which when placed in the plugin folder (and restarting Obsidian again) solved the problem and allowed me to enable the plugin.
Solution
I considered opening a pull request to suggest removing main.js from the ignore list, the "poor practice" simply being a hazard of simplicity in releases.  However, there are several approaches that could all solve the slight instruction issue, so it was best left to your preference.  I'll share a few options I briefly considered in case they are useful.
Additional Instruction
Add additional clarification to Steps 1 and 2 in README.md.

...the latest release of Whisper plugin (both the source zip and main.js) from the...
...within your Obsidian vault, and then move the main.js file you downloaded inside of it.

Update Release method
I'll be honest that I'm not overly familiar with Release structures (more experience in monorepos, etc) but it seems as though it may be possible to compress main.js along with the manifest and styles and add that to the release list as well.  This would allow a simpler instruction set with only a minor clarification as to which zip file to download.
Remove main.js from the .gitignore file
A bit of a compromise on code practice, but by far the least effort.

Thank you for catching this. I have added clarifications to the README.md file. To ensure that Obsidian can utilize the plugin, it is essential to add the build separately to the release. So, no need to change the .gitignore file.


[UI][Registry] Edit and Information page are going to blank page

v0.15.0
Steps:

Create new registry
Click on name
Edit registry

Results:
Both actions take you to a blank Registry page
Expected:
Edit should take you to edit page and Information should take you to info page for that particular registry.

Fixed in rancherio/ui@b366f25

v0.15.1
Verified fixed


fix(package.json): add "type": "module"

hono did not work with ESM project.
Added type field to package.json.
import { Hono } from "hono";
         ^^^^
SyntaxError: Named export 'Hono' not found. The requested module 'hono' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'hono';
const { Hono } = pkg;

Hi @taishinaritomi !
This line has been removed in this PR #669 , but you are right, it is needed.
Thank you. I'll merge it.

Hi @taishinaritomi !
If you can figure it out, I would like to know.
Since accepting this PR, and adding "type": "module", the errors below occur. If we set "moduleResolution": "NodeNext" in tsconfg.json, VScode can't load types of Hono.
https://github.com/honojs/hono/issues/668#issuecomment-1365355811
I'm also looking into this, but if you know how to solve it, please let us know how.

I will check now

Thank you!

We have found ways to improve it, but it's a lot of work!
"tsconfig.json.compilerOptions.moduleResolution = NodeNext" option seems to require that .d.ts files also have the extension
Before

After

Ah, extension! We have a lot of work to do, but it's good to know we've found a solution.
I'll try it soon. Thank you very much!


Make sure git is executed in the right dir

Just saw this fail when I attempted to build a project...

Doh. Thanks!


RSpec Expectation syntax

While trying to complete the exercise I ran into a deprecation warning:
Using `should` from rspec-expectations' old `:should` syntax without explicitly
enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly
enable `:should` with`config.expect_with(:rspec) { |c| c.syntax = :should }` instead.

This is not a big deal but I then tried went down the road of trying to write the test using the expect syntax, and I'm having trouble with accessing instance variables.
For example:
# Card Class
0 class Card
1
2     attr_reader :suit, :value
3     def initialize(suit, value)
4         @suit = suit
5         @value = value
6     end
7
8 end

# Test case
0 describe Card do
1
2     it "expect to accept suit and value when building" do
3         card = Card.new(:clubs, 10)
4         expect(card).to eq(:clubs)  #<-- I'm unable to use card.suit or card.new.suit(:site, :value)
5         #expect(card).to eq(10)
6     end
7 end

How would I write this test using the expect syntax?
error message from Rspec:
F

Failures:

  1) Card expect to accept suit and value when building
     Failure/Error: expect(card.value).to eq(10)
     NoMethodError:
       undefined method `value' for #<Card:0x007fa902915c00 @suit=:clubs, @value=10>
     # ./blackjack.rb:18:in `block (2 levels) in <top (required)>'

Finished in 0.00137 seconds (files took 0.16479 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./blackjack.rb:15 # Card expect to accept suit and value when building

Failures:

  1) Card expect to accept suit and value when building
     Failure/Error: expect(card).to eq(:clubs)

       expected: :clubs
            got: #<Card:0x007fc89a8363e0 @suit=:clubs, @value=10>

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -:clubs
       +#<Card:0x007fc89a8363e0 @suit=:clubs, @value=10>
     # ./blackjack.rb:17:in `block (2 levels) in <top (required)>'

Finished in 0.02727 seconds (files took 0.15817 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./blackjack.rb:15 # Card expect to accept suit and value when building

@hicksca  here you go:
expect(card.suit).to eq(:clubs)

I'm not sure why that didn't work when I was trying it last night but thank you.


Add region and country names

Alongside a toggle or checkbox to choose whether too see it or not

There's no need for a toogle. Only country names remaining to add

Closed in version 3.0.2


Nation-wide data for Canada available

Statistics Canada has released a nation-wide address database. Data available here: https://www150.statcan.gc.ca/n1/pub/46-26-0002/462600022022001-eng.htm. Licence is open (https://www.statcan.gc.ca/en/reference/licence). Release December 2023.
The data is provided in 2 seperate files - one for addresses and one for locations. These two share a common LOC ID field. Files are provided by province and territory (i.e. 13 address files, 13 location files). I've joined these files into one single address database, with 16 million records. Not familair with json so much but I can provide you what I have - or you can get it directly form the source.

Thanks for the suggestion!
In situations like this, we usually build a script to do the work, document it thoroughly so we can run it in the future, and then put it in https://github.com/openaddresses/openaddresses/tree/master/scripts. We don't have automation to run these scripts at this point, so someone runs the script manually, we post the output data somewhere (we can store it in our S3 bucket) and add a source JSON to this repository to incorporate the data into our overall output.
If you're up for it, can you write a pull request to add the script+documentation? You can upload the output data you have to https://www.dropbox.com/request/rUcmasTnxZkiDR6rJc4l and I will move it over to S3, too.

i could have done this wrong, but does this look right @pheersink

Pretty much what I get so yes it is ok. Coverage is inconsistent but there should be around 16.5 million addresses on the map.

Nice, looks like Canada!

@iandees you mean it looks like Canada 'eh!
@pheersink in the past we have collaborated with statcan to fill in gaps. I'd love to explore that option for them as well as ESRI and openaddresses. Little tricky with different municipal legal hoops, but we do this stuff a lot, so not hard, but takes effort. Thoughts about trying to fill in gaps up there 'eh?

I work with @pheersink on some of the address work.
I built a script to download and process the National Address Register data and opened PR https://github.com/openaddresses/openaddresses/pull/7224 with a script for it. It joins the address and locations files together on the LOC_GUID field and adds the REPPOINT_LATITUDE and REPPOINT_LONGITUDE fields to the addresses, and zips that up. I uploaded the result file to the Dropbox link that @iandees posted above with file canada-nar-combined.csv.gz

Thanks @jwass

Awesome @jacob
Sent from my iPhone
On May 11, 2024, at 12:43 PM, Justin Meyers @.***> wrote:

EXTERNAL
Thanks @jwasshttps://urldefense.com/v3/__https://github.com/jwass__;!!G_POQyfmwzJ5ZCxH!EUt_ltgIUcRi_CeX9ePNSFpTLwmvnHoX6-G7xLDb8GzMXXKBJpeQNs6betIWHpDaq3CpQQJQ-AZh9-FDafvKbrix$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/openaddresses/openaddresses/issues/7192*issuecomment-2105950832__;Iw!!G_POQyfmwzJ5ZCxH!EUt_ltgIUcRi_CeX9ePNSFpTLwmvnHoX6-G7xLDb8GzMXXKBJpeQNs6betIWHpDaq3CpQQJQ-AZh9-FDaWcaOkUJ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB5DDHLEMBGFV7327YBAKOLZBZDCZAVCNFSM6AAAAABHCH5C3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHE2TAOBTGI__;!!G_POQyfmwzJ5ZCxH!EUt_ltgIUcRi_CeX9ePNSFpTLwmvnHoX6-G7xLDb8GzMXXKBJpeQNs6betIWHpDaq3CpQQJQ-AZh9-FDabUcLM95$.
You are receiving this because you were mentioned.Message ID: @.***>
Confidentiality Notice: This message may be confidential and is intended only for the named recipients. If you received this in error, please notify the sender and delete the message.
Avis de confidentialité: Ce message peut être confidentiel ; il est destiné uniquement pour les destinataires qui y sont désignés. Si vous avez reçu un message par erreur, nous vous prions d'en aviser l'expéditeur et d’effacer le message.
If you no longer wish to receive emails from Esri Canada, unsubscribe herehttps://www.esri.ca/en-ca/communications/unsubscribe. Privacy Policyhttps://www.esri.ca/en-ca/legal/privacy
Si vous ne désirez plus recevoir de courriels d’Esri Canada, veuillez vous désinscrire icihttps://www.esri.ca/fr-ca/communications/unsubscribe. Politique de confidentialitéhttps://www.esri.ca/fr-ca/legal/privacy
Esri Canada | 12 Concorde Place | Suite 900 | Toronto, ON | M3C 3R8

The data is available at https://data.openaddresses.io/cache/uploads/iandees/760039/canada-nar-combined.csv.gz


Update calculation of light and historic demand in westeros_baseline tutorial

This PR updates the calculation of the light_demand and historic_demand in the westeros_baseline tutorial. Closes #522
How to review

Read the diff and note that the CI checks all pass.

PR checklist

[x] Continuous integration checks all ✅
[x] Update release notes.

Thanks @LauWien for opening this and resolving inconsistencies. As for the MACRO, I'd suggest you update the Excel file and make the tests pass. Because the layout of data in that Excel file is being used by different modeling streams (global, national, tutorials) for doing MACRO calibration. There are also some suggestions for improving the Excel layout in PR #327. Later, we can decide what to do with that Excel file.

Thank you for your review! I'll do as suggested :)

Looks great, thanks for this clean-up. Only a few minor items to tidy.

Thank you for your review :)

There are two more places where we could have also reduced the numbers of figures: test_macro.py around line 138, and test_reporting.py.
However, LGTM! Those can be tidied the next time a test change requires adjustment to those values.

Oh yes, I'll do it in this PR https://github.com/iiasa/message_ix/pull/524, where I need to update them again, anyways :) Was maybe not the best idea to open two PRs with changing the same tutorial.


Circe EntityEncoder without intermediate String allocation

Something fishy is going on on CI lately

Could you copy/paste that code to the argonaut one too?

There is no such feature in argonaut :(

I've made a PR to release-0.16.x #1138. circe in release-0.15.x doesn't have this function

Note to whoever merges release-0.16.x into master: there will be a merge conflict. Keep this one.


listener.isOpen() returns always false

https://github.com/nemtech/symbol-sdk-typescript-javascript/blob/2b18ca2f991aa692dd4384e93b7377954faed695/src/infrastructure/Listener.ts#L200
I want to use listener.isOpen() on browser WebSocket, but  it returns always false.
because WebSocket.OPEN is always undefined.
I think it should be corrected as follows.
return this.webSocket.readyState === this.webSocket.OPEN;

please check this, thank you.

Please check if other places are behaving as expected.
https://github.com/nemtech/symbol-sdk-typescript-javascript/blob/2b18ca2f991aa692dd4384e93b7377954faed695/src/infrastructure/Listener.ts#L103
https://github.com/nemtech/symbol-sdk-typescript-javascript/blob/2b18ca2f991aa692dd4384e93b7377954faed695/src/infrastructure/Listener.ts#L210

@xembook good catch. it is a bug on injected ws listener. 👍


Docker tag v1

Added basic functionality of docker tag, without the involvement of docker registries / repositories.
Also fixed a bug regarding git repo folders with spaces.
All functionalities include associated Pester tests.

:pray: It's time for review.

Splitting into smaller PRs.


Direct2D1 RenderTarget Ambiguous Methods

I am trying to use Direct2D from VB.NET, and the RenderTarget.FillRoundedRectangle method is giving me ambiguity problems. Visual Studio says that there are 2 FillRoundedRectangle methods with the same signature differing only in passing the roundedRect parameter by value or by reference. This conflict is a difference between C# and VB.NET, and I think might be related to #456.  When would the caller want the method to change the value of the roundedRect, necessitating byref?
I went looking at the source on GitHub to understand what each overload is doing, but not only is each function just calling another overload of the same function, the byref version of FillRoundedRectangle (and the other drawing functions) doesn't exist in the RenderTarget file. Well, I can see that the RenderTarget class is declared as partial, but GitHub search doesn't find any other definition of a "RenderTarget" class. How then can each function definition in RenderTarget.cs just call another overload of the same function? How is that not a stack overflow?
Where is the actual code that defines the byref version of the method?
Where does the RenderTarget drawing code - not just the FillRoundedRectangle, but all of it - actually go? Does SharpDX call into native Direct2D, or are the RoundedRectangle functions just helpers implemented in C#? If they are just helpers, I would be happy to copy the implementation myself.

Screenshot of peeking the definition of RenderTarget:

Please don't just write this off with a "SharpDX is just a C# thing" like #456.

It is not to change the value but for performance reason when you don't want to bloat the stack with unnecessary copies (unfortunately, we don't have an equivalent for a const keyword)
You don't see the code because most of SharpDX code is auto-generated from DirectX C++ headers when compiling the project
see 2)
These methods are direct calls to Direct2D COM objects

And yes, SharpDX has been designed mainly with C# in mind, and I realized too late these VB language issues.

I have this problem all over the place because I too use VB.net, so far I have just gone in each time and made a change to sharpDX.
I don't use any of the direct2D stuff but most of the boundingXXXX.intersect  and contain have this problem as well as a few other bit here and there.
Best bet would be to fork it and make the changes u need, so far this has worked for me.... I use a custom toolkit(3.0.2) build for all my 2D stuff.


koord-descheduler: add evict event/metric for Pod during migration

Signed-off-by: Joseph<EMAIL_ADDRESS>Ⅰ. Describe what this PR does

Add eviction event with reason/pluginName for Pod during migration.
Update eviction metric after eviction

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in make test

/hold

/hold cancel
TBR

/lgtm

/approve


Make examples/storage/littlefs support for ESP-IDF versions below 5.2 (IDFGH-11806)

In ESP-IDF 5.2, littlefs became a valid sub-type for the partition table, with the value of 0x83, and this example uses it. However, before that, this sub-type was not recognized by default. Therefore, I updated the CMakeLists.txt file to set it as a custom sub-type for ESP-IDF versions lower than 5.2, in order to make this example compatible with older ESP-IDF versions.

Hi, thank you for contribution. Changes look good to me except for changes in tools/ci/check_public_headers_exceptions.txt file - are those necessary to pass tests?

Yes, the pre-commit tool automatically added this annoying change for me. I tried to delete it that day, but it would still be automatically added after deletion. Next, I will try to pull origin/master and rebase it to the latest master, hope everything goes well. Thank you!

Hi, @adokitkat. I updated my commit, removed the changes of annoying tools/ci/check_public_headers_exceptions.txt and used git rebase to make my commit history look clear. It has passed the test now.

sha=d68b3c3b2f2e97d0b9ea7a182914e13d3d47605a

sha=d68b3c3b2f2e97d0b9ea7a182914e13d3d47605a

Hi @Augtons. Once again thank you for the contribution. After some consideration we decided it would be better to just backport LittleFS example with appropriate commits instead of merging this PR, which is kind of work-around. I am sorry about this. I have created the backports for release/v5.0 and release/v5.1 branches (however there is one blocker issue for v5.0 branch right now so it needs to wait for another MR right now).

littlefs example is now present in IDF v5.0 and newer.


Simplify update-versions script with --use-json

This should work, but the M58 release lead should confirm.

Adding --sources would be a good follow up. We need to verify it does what's expected.


docs(action-sheet): Make property names match component

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (npm run build) was run locally and any changes were pushed
[ ] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

N/A
Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

Updated property names and removed an option that doesn't appear to exist.

Thanks a lot for the PR!


(HTTP code 404) unexpected - {"message":"manifest for netflixoss/eureka:latest not found"}

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

Go to https://hub.docker.com/r/netflixoss/eureka/tags/
Observe no latest tags were created for that image
Select a different tag in Kitematic (if one exists)
🎉  enjoy container running.

Ideally you open an issue with the repo owner to let them know how frustrating it is that they don't have a latest image tagged

@FrenchBen, maybe this is another case for error handling UX? Like whenever we get this response from Docker, we instead tell the user that there's no image for the specific tag and to try downloading a different tag or open an issue with the maintainer of the image?

@mhelmetag Yes, it would be really good - Although there are times when the image has no tags at all, in which case no other tag can be selected.
Happy to see some UX improvements on that front if you're up to it :)

Possibly 😄 we'll see what I'm feeling some weekends.


[WFLY-9213]: Implement the Pause method for a Topic via Management APIs

Adding a pause method on JMS Topics
Adding a resume method on JMS Topics
Adding a paused runtime attribute on JMS Topics

Jira: https://issues.jboss.org/browse/WFLY-9213
Proposal: https://github.com/wildfly/wildfly-proposals/pull/269

My minor comment re RuntimeException aside, this LGTM.

/retest


feat: package up the dist folder

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Tiny bug related to text prediction

https://github.com/awslabs/autogluon/blob/28f5df3a9366b2224bebd7f4a3a81307662378eb/autogluon/task/text_prediction/modules/basic_prediction.py#L248-L249
This action only occurs if len(field_proj_features) is equal to 1. Adding some proper test cases that cover basic layers used for prediction would be great.
@sxjscience

Thanks for reporting this. I find that we can safely remove the len(field_proj_features) branch. Because when the number of inputs is 1, stack + mean, and concatenate just becomes identity.

Thanks for reporting this. I find that we can safely remove the len(field_proj_features) branch. Because when the number of inputs is 1, stack + mean, and concatenate just becomes identity.

This is also a good solution

@sxjscience is this fixed at this point?

Yeah, it has been fixed.


How to train and evaluate policy models with unified dataset format?

Hi there, I noticed that there are APIs to load NLU, DST, Policy and NLG data in unified data format. Besides, I found the training and evaluation guide for NLU/DST/NLG with unified data in $model/README.md or NLU/DST/NLG/evaluate_unified_datasets.py. However, I did not find a guide for how to train and evaluate policy models with unified data format. Specifically, I have the following questions:

Training: I did not find support for training with unified data format in $policy_model/train.py, such as ppo/train.py and mle/train.py, it seems that they will use MultiWozEvaluator by default.
Evaluation: I did not find support for evaluation with unified data format in policy/evaluate.py, it seems that it will also use MultiWozEvaluator by default.
My Training Experiment: I have tried to train a PPO policy with this config file base_pipeline_rule_user.json (which has been initialized with a MLE policy weight trained with default config), and get the result: Best Complete Rate: 0.95, Best Success Rate: 0.5, Best Average Return: 4.5.  It is a good start for me, but still worser than
BERTNLU | RuleDST | PPOPolicy | TemplateNLG evaluation in ConvLab2 ReadME (75.5 completion rate and 71.7 success rate). How does this gap come from?
My Evaluation Experiment: I evaluated  my previously trained PPO model policy/evaluate.py, but get a much worser result: "Complete 500 0.372 Success 500 0.228 Success strict 500 0.174".  During the evaluation, there are two warnings: "Value not found in standard value set: [dontcare] (slot: name domain: restaurant)", "Value [none] invalid! (Lexicalisation Error) (slot: name domain: hotel)". They seem to be the dataset format mismatch between training and evaluation process, because I am not sure whether I have used original Multiwoz format or unified data format to train and evaluate my policy model.
For user simulator: I have found that tus, emoUS and genTUS could be trained and evaluated with unified data format. However, I did not found unified data format support in rule-based user simulator. Does that mean if I trained my models(NLU/NLG or Policy) with unified data format, I could not evaluate them with rule-based user simulator?

Looking forward to your reply,
James Cao

Another question is I found that my trained PPO policy will give tens of system act output in every turn, is it expected?

@ChrisGeishauser could you give some guidance?

Hi @JamesCao2048, thanks a lot for all your questions! I hope I can answer them sufficiently for you:

For MLE training, this is explained in the README: https://github.com/ConvLab/ConvLab-3/tree/master/convlab/policy/mle
So when you execute train.py, you just pass --dataset_name=sgd and it should work. For the DDPT model (in folder vtrace_DPT), it is also explained how to specify the dataset, namely in the pipeline configuration under "vectorizer_sys" you set "dataset_name" = "sgd". For PPO, it should be the very same as for DDPT (even though I have not checked it yet). But as you found out, there is at the moment only an evaluator for MultiWOZ unfortunately, so currently RL training is only possible for MultiWOZ. We are working on an SGD evaluator and hope to finish that soon.
You are right, there is only a multiwoz evaluator at the moment unfortunately, but we are working on an SGD evaluator.
If the policy is loaded correctly, there should be an output in the terminal at the beginning like "dialogue policy loaded from checkpoint ...". If you do not see that, it is not loaded correctly. You have to be a bit careful here because you should not set the "load_path" as "save/best_ppo.pol.mdl" but "save/best_ppo" because the policy tries to load both policy and critic. Sorry for that confusion! Please check whether the model is loaded correctly and otherwise contact me again! This hopefully closes the gap then.
This is definitely the performance of a randomly initialised policy. Please check if the policy is loaded correctly (see point 3 above)
This is correct, unfortunately the rule-based simulator only supports Multiwoz at the moment.

Another question is I found that my trained PPO policy will give tens of system act output in every turn, is it expected?
This is an indicator that you used a random policy, in this case the output is expected: the architecture of the policy has an output dimension that is equal to the number of "atomic actions" (e.g. hotel-inform-phone or restaurant-request-price). For every "atomic actions" there is a binary decision wether to use it or not. In case of a random policy, there is roughly a chance of 50% to take an atomic actions, which will lead to a lot of actions.
I hope I could help you with the answers! Let me know if something is unclear.


Fix jnilib files not signed

You can see here that only dylib files are signed:
https://github.com/openjdk/jdk/blob/f7814c120bf84d7e9b459f81a6ce19b44fa122ec/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java#L673-L677
So that means that jnilib files still need to be signed manually.

Without the PR you get the following:

These libs were added using fromFiles in Gradle compose configuration.

I don't think the fix works ATM, because jnilib extension is checked, after a file is determined to have a dylib extension:
if (source.name.isDylibPath) {
    // ...
            if (source.name.endsWith(".jnilib")) {
                signer.sign(target)
            } else {
                signer.unsign(target)
            }
        }
        else -> {
            if (source.name.endsWith(".jnilib")) {
                signer.sign(target)
            }
        }
    // ...
}

Overall, the idea looks good to me, but I would prefer something like:
if (source.name.isDylibPath) {
     // ... same as before
} else if (source.name.isJnilibPath) {
    signer.sign(target)
}

@AlexeyTsvetkov actually the fix does work, because the isDylibPath function (which already existed), checks for both extensions. See:
https://github.com/JetBrains/compose-jb/blob/a1c4c8a41ee37c2f56ced2598ffb124decc28c6d/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/files/MacJarSignFileCopyingProcessor.kt#L76-L77
However, I can change it because I agree that it is not that clear.

@Thomas-Vos whoops, my bad :) LGTM


Pathfinder for SEM diverges on all iterations

Hello again. I was trying out pathfinder algorithm for SEM model and my code works for different methods (HMC, Variational inference), however it always fails when using Pathfinder algorithm.
My code with generated data:
# library(cmdstanr)
library(rstan)
#tryCatch({cmdstanr::set_cmdstan_path('/home/cmdstanr/cmdstan-2.28.2')})
library(cmdstanr, lib.loc ='/home/pathfinder/pathfinder_testing/cmdstanr')
set_cmdstan_path('/home/pathfinder/pathfinder_testing/cmdstan')

y <- rnorm(n = 100, mean = 0, sd = 2)
x <- rnorm(n = 100, mean = y, sd = 2)
z1 <- rnorm(n = 100, mean = x, sd = 0.5)
z2 <- rnorm(n = 100, mean = x, sd = 0.5)
z3 <- rnorm(n = 100, mean = x, sd = 0.5)
d <- data.frame(y = y, x = x, z1 = z1, z2 = z2, z3 = z3)
rm(x, y, z1, z2, z3)

# add empty latent variable to data frame
d$X <- as.numeric(NA)

bf1 <- bf(z1 ~ 0 + mi(X)) # factor loading 1 (constant)
bf2 <- bf(z2 ~ 0 + mi(X)) # factor loading 2
bf3 <- bf(z3 ~ 0 + mi(X)) # factor loading 3
bf4 <- bf(X | mi() ~ 0)   # latent variable
bf5 <- bf(y ~ 0 + mi(X))  # added regression

fit3 <- brm(bf1 + bf2 + bf3 + bf4 + bf5 + set_rescor(FALSE), data = d,
            prior = c(prior(constant(1), coef = miX, resp = z1),
                      prior(normal(1, 1), coef = miX, resp = z2),
                      prior(normal(1, 1), coef = miX, resp = z3),
                      prior(normal(0, 1), coef = miX, resp = y)),
            backend = 'cmdstanr',
            iter = 2000,
            warmup = 1000,
            chains = 3,
            cores = 3,
            threads = threading(threads = 4),
            # jei diverguoja gali padėti regis adapt_delta pakėlimas
            #control = list(adapt_delta = 0.999, max_treedepth = 15)
            control = list(adapt_delta = 0.99, max_treedepth = 15))
summary(fit3)

# cmdstanr way

bf0 <- bf1 + bf2 + bf3 + bf4 + bf5 + set_rescor(FALSE)
data0 <- d
prior0 <- c(prior(constant(1), coef = miX, resp = z1),
            prior(normal(1, 1), coef = miX, resp = z2),
            prior(normal(1, 1), coef = miX, resp = z3),
            prior(normal(0, 1), coef = miX, resp = y))

my_stan_code <- make_stancode(
  formula = bf0,
  data = data0,
  prior = prior0,
  autocor = NULL,
  data2 = NULL,
  cov_ranef = NULL,
  sparse = NULL,
  sample_prior = "no",
  stanvars = NULL,
  stan_funs = NULL,
  knots = NULL,
  #threads = threading(threads = nthreads),
  normalize = getOption("brms.normalize", TRUE),
  save_model = '/home/rstudio/user_projects/Mantas/Pathfinder/psc_20220208.stan'
)

# make a native stan data structure from brm objects
my_stan_data <- make_standata(
  formula = bf0,
  data = data0,
  # !!!!! šeimos čia nereikia nurodyti, nes modelis yra multivariate tipo
  #family = gaussian(),
  prior = prior0,
  autocor = NULL,
  data2 = NULL,
  cov_ranef = NULL,
  sample_prior = "no",
  stanvars = NULL,
  #threads = threading(threads = nthreads),
  knots = NULL
)

# create cmdstan model object
ex_mod = cmdstan_model(stan_file = '/home/rstudio/user_projects/Mantas/Pathfinder/psc_20220208.stan',
                       compile = FALSE)

# compile
ex_mod$compile(
  quiet = FALSE,
  dir = NULL,
  pedantic = TRUE,
  include_paths = NULL,
  cpp_options = list(stan_threads = TRUE),
  stanc_options = list(),
  force_recompile = TRUE
)

# NUTS (HMC)
ex_fit_sample = ex_mod$sample(data = my_stan_data,
                              iter_sampling = 1000,
                              chains = 3,
                              parallel_chains = 3,
                              threads_per_chain = 4,
                              # pridėjau parametrus
                              adapt_delta = 0.99,
                              max_treedepth = 15,
                              output_dir = '/home/rstudio/user_projects/Mantas/Pathfinder/')

# meanfield variational inference
nthreads = 12
ex_fit_vb <- ex_mod$variational(
  data = my_stan_data,
  seed = NULL,
  refresh = 5,
  init = NULL,
  save_latent_dynamics = FALSE,
  output_dir = '/home/rstudio/user_projects/Mantas/Pathfinder/',
  output_basename = 'psc_variational',
  sig_figs = NULL,
  threads = nthreads,
  opencl_ids = NULL,
  algorithm = NULL,
  iter = 10000,
  grad_samples = NULL,
  elbo_samples = NULL,
  eta = NULL,
  adapt_engaged = NULL,
  adapt_iter = NULL,
  tol_rel_obj = 0.0000001,
  eval_elbo = NULL,
  output_samples = 10000
)

ex_fit_sample$summary()
ex_fit_vb$summary()

#pathfinder

ex_fit = ex_mod$pathfinder(algorithm = "single", data =my_stan_data,
                           refresh = 6, threads = num_cores, iter = 10000,  num_elbo_draws = 1000,
                           history_size = 6, init_alpha = 0.0000000001,
                           num_draws = 10001, init = 3,
                           num_eval_attempts = 5,tol_rel_obj = 0.0000001
                           )#, tol_obj = 0, tol_grad = 0, tol_param = 0, tol_rel_grad = 0, tol_rel_obj = 0)

ex_fit$summary()

And while fitting with pathfinder I get errors:

Pathfinder Failure: None of the LBFGS iterations completed successfully

Maybe I shall change some of my parameters ant that is why all iterations diverge? Or is it some deeper problem, i.e. pathfinder can not be used for Structual Equation Modelling (SEM)? Where could I read documentation or maybe see Raw code in order to know what each parameter does?
Thanks for help!

Hey, @SteveBronder, how are you doing? Did You have an opportunity to look into this issue?

Hi sorry I meant to get to this during the week but had to work on the laplace approximations. I should have some time next week to take a look at this

Hello just to update looking at this now. It seems odd, but also optimize also gives back wonky results so it may be just because the pathfinder schema is based on lbfgs. Another issue here is that the program spends a looong time just generating error log messages which is the main cause of the slowdown.
@bob-carpenter right now in pathfinder we log an error for each approximate sample if we go over the number of evaluation attempts. Would it be okay if we only log an error only if we are unable to sample any approximate samples?

Yes, I think it's fine to cut down on the logging.  The point is to get a message to the user so they can diagnose their code.
We can't really do anything if optimize is giving wonky results other than use better optimizers.

Sorry, I didn't get You. Is it a bug in my code? Because this code works with different inference methods (i.e. HMC). Are You going to look deeper into this problem?

Is it a bug in my code?

Idk, but your code works for HMC so this could very well just be a problem that LBFGS cannot do well.

Are You going to look deeper into this problem?

Yes I'm sending this over to Lu to look at as well. It's good to have models that break so this is very appreciated!


investigate kyverno post-deploy diff

Describe the problem/challenge you have
After first deploy with below yaml, try changing audit => enforce and see diff on the next deploy.
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: require-ro-rootfs
  annotations:
    policies.kyverno.io/title: Require Read-Only Root Filesystem
    policies.kyverno.io/category: Best Practices
    policies.kyverno.io/severity: medium
    policies.kyverno.io/subject: Pod
    policies.kyverno.io/description: >-
      A read-only root file system helps to enforce an immutable infrastructure strategy;
      the container only needs to write on the mounted volume that persists the state.
      An immutable root filesystem can also prevent malicious binaries from writing to the
      host system.
spec:
  validationFailureAction: audit
  background: true
  rules:
  - name: validate-readOnlyRootFilesystem
    match:
      resources:
        kinds:
        - Pod
    validate:
      message: "Root filesystem must be read-only."
      pattern:
        spec:
          containers:
          - securityContext:
              readOnlyRootFilesystem: true

how can we improve this flow?
Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX (ex: new CLI argument name, the behavior expected).]
Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

On replicating this issue. In the diff we can see two objects on the rules  list that was not added by us:
 75     -   - exclude:
 76     -       resources: {}
 77     -     generate:
 78     -       clone: {}
 79     -     match:
 80     -       resources:
 81     -         kinds:
 82     -         - DaemonSet
 83     -         - Deployment
 84     -         - Job
 85     -         - StatefulSet
 86     -     mutate: {}
 87     -     name: autogen-validate-readOnlyRootFilesystem
 88     -     validate:
 89     -       message: Root filesystem must be read-only.
 90     -       pattern:
 91     -         spec:
 92     -           template:
 93     -             spec:
 94     -               containers:
 95     -               - securityContext:
 96     -                   readOnlyRootFilesystem: true
 97     -   - exclude:
 98     -       resources: {}
 99     -     generate:
100     -       clone: {}
101     -     match:
102     -       resources:
103     -         kinds:
104     -         - CronJob
105     -     mutate: {}
106     -     name: autogen-cronjob-validate-readOnlyRootFilesystem
107     -     validate:
108     -       message: Root filesystem must be read-only.
109     -       pattern:
110     -         spec:
111     -           jobTemplate:
112     -             spec:
113     -               template:
114     -                 spec:
115     -                   containers:
116     -                   - securityContext:
117     -                       readOnlyRootFilesystem: true
118     -   validationFailureAction: audit
     69 +   validationFailureAction: enforce
119, 70

Kyverno seems to generate additional rules when we define a rule for a Pod so that it applies to pod templates in Deployment, DaemonSet, StatefulSet, Job, and CronJob resources. This behaviour is documented here.
Both of the two autogenerated names have the autogen- prefix.
A potential solution for this  would be to exclude items in a list as per a user-defined ytt rule before diffing. Something similar to what we have in place here. We could allow the user to deal with cases like this in a declarative manner.
There seems to be a noisy diff due to the resource being restructured and the addition of default values by Kyverno:
57, 56     rules:
 58     -   - exclude:
 59     -       resources: {}
 60     -     generate:
 61     -       clone: {}
 62     -     match:
     57 +   - match:
 63, 58         resources:

In addition, Kyverno adds an annotation listing the resources it created autogen rules for:
annotations:
  4     -     pod-policies.kyverno.io/autogen-controllers: DaemonSet,Deployment,Job,StatefulSet,CronJob


[DOC] Add a link to the Contributing.html  page in the Readme.rst

Currently, it is not very easy  for a contributor looking for setup instructions to find the contributing.html via the readme .
I would like to propose adding a link to the Contributing.html file in the readme.rst under "Contributing"
I would like to work on this fix.
(https://github.com/ericmjl/pyjanitor/README.rst)

Totally agree that the setup instructions could use more help :D
Could you explain in more detail what the link would contain?

i would just add a hyperlink to -
https://pyjanitor.readthedocs.io/contributing.html#

Ok! Sounds good! marking this as "being worked on"

@suchetaBan, wanted to check in with you on this. Would you like to submit a PR with your contribution to the README? If so, do let us know via this issue tracker! If not, no worries - I'll just release the issue back into the pool of issues that are "available for hacking".

Hi Eric,
Apologize for the delay but i have had not time to look into that Issue
after returning from SciPy. Please go ahead and release the issue back into
the available for hack pool.
Thanks.
Sucheta
On Mon, Aug 19, 2019 at 6:09 PM Eric Ma<EMAIL_ADDRESS>wrote:

@suchetaBan https://github.com/suchetaBan, wanted to check in with you
on this. Would you like to submit a PR with your contribution to the
README? If so, do let us know via this issue tracker! If not, no worries -
I'll just release the issue back into the pool of issues that are
"available for hacking".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ericmjl/pyjanitor/issues/403?email_source=notifications&email_token=AMMHRVX3HPITKGZ5Y7TH6T3QFM74ZA5CNFSM4IC62YD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UXP6I#issuecomment-522811385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMMHRVVI6WHZTXTUQZEBZU3QFM743ANCNFSM4IC62YDQ
.

Thanks @suchetaBan!

@ericmjl can I work on it?


unable to get passed mojang initial loading screen only displays for one to two frames then crashes

just delete this, the mod list is 50+ i dont want to write it


Add Commands for New Bookmark V2 Endpoints

On March 24, 2022, Twitter announced the addition of new endpoints to provide functionality for Bookmark management.
Create object classes as required and create new commands to support the new endpoints.

This requires OAuth 2.0 User Context.
Endpoint     : https://api.twitter.com/2/users/{:id}/bookmarks
OAuthVersion : OAuth1a
Status       : Forbidden
Error        : Authenticating with OAuth 1.0a User Context is forbidden for this endpoint.

Endpoint     : https://api.twitter.com/2/users/{:id}/bookmarks
OAuthVersion : OAuth2Bearer
Status       : Forbidden
Error        : Authenticating with OAuth 2.0 Application-Only is forbidden for this endpoint.

No new development will occur for this project.


Make the code coverage pretty

Right now it's grouped by file, and not by libraries.
This likely implies some XML manipulation, to get the what we want from ADO

Done


Drag property with CTRL generates code to get the property

This pull request implements and closes: https://github.com/godotengine/godot-proposals/issues/8017
Supercedes https://github.com/godotengine/godot/pull/82946

One caveat is that node.property  is not equvalent to node.get("property"). The former can act as setter too.

Yes. but:

I rather not have a call to get if it is not necessary. Which also aligns this with https://github.com/godotengine/godot-proposals/issues/8014 in the simple case.
It didn't make sense to me to generate a setter.

Seems to be working well 👍
If you manage to make subresources work, I hope shader parameters get some special attention, as those require the most writing/remembering. Could be a follow up though.
I think for set though, shift modifier could be used. In that case, caret should be moved to before closing bracket.


Menu

basic setup of ui

This branch has conflicts that must be resolved - please pull from master before pushing


Update to 3.8 native SDKs

Update the Dolby.io Flutter SDK to use the 3.8 native SDKs.
Tasks:

#294
#295

Release


Click-Through Rate Prediction With Machine Learning

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #5643

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Hey! Welcome to Section EngEd. @Wazecky

This article is light on substance.
The structure is quite off.

I'm going to close this PR. I recommend taking this course: https://developers.google.com/tech-writing before re-writing this article.


Error: Cannot use soft decisions during evaluation.

Hello,
thanks for publishing the code along with your paper. While reading your paper, I tried to run the demo notebook from this repository. I modified it slightly for colab to use the pip package instead of the local repository. However, I run into this issue:
ValueError                                Traceback (most recent call last)
<ipython-input-6-809883d6966a> in <cell line: 10>()
     32         testing_accuracies = []
     33         for batch_images, batch_labels in tqdm(dataloader_testing):
---> 34                 output = model(batch_images.view(-1, 784))
     35                 loss = criterion(output, batch_labels)
     36                 accuracy = (output.argmax(dim=1) == batch_labels).detach().float().mean()

1 frames
/usr/local/lib/python3.10/dist-packages/fastfeedforward/fff.py in forward(self, x, return_entropies, use_hard_decisions)
    332                                 raise ValueError("Cannot return entropies during evaluation.")
    333                         if not use_hard_decisions:
--> 334                                 raise ValueError("Cannot use soft decisions during evaluation.")
    335                         return self.eval_forward(x)
    336

ValueError: Cannot use soft decisions during evaluation.

Here is the notebook to reproduce the error:
https://colab.research.google.com/drive/1apDlwbJPGMMoNodTOUx5m8Klnp8zE7T-?usp=sharing

I'm getting the same error.
I'm getting a "Need access error" for the above Colab notebook.
So here is a short script to reproduce.
Versions used:

fastfeedforward - 0.2.0
torch - 2.0.1

import torch.nn as nn
from fastfeedforward import FFF
import math
import torch

print(torch.__version__)

input_width = 512
hidden_width = 512
output_width = 10
dropout = 0.5
depth = 5
leaf_width = math.ceil(hidden_width / 2**depth)
region_leak = 0.2  # your choice of the region leak probability (0 - 0.5) to encourage generalisation in very deep FFFs

my_fff = FFF(
    input_width,
    leaf_width,
    output_width,
    depth,
    activation=nn.ReLU(),
    dropout=dropout,
    region_leak=region_leak,
)

class FFFNeuralNetwork(nn.Module):
    def __init__(self):
        super(FFFNeuralNetwork, self).__init__()
        self.flatten = nn.Flatten()
        self.linear_relu_stack = nn.Sequential(
            nn.Linear(28 * 28, input_width), nn.ReLU(), nn.Dropout(dropout), my_fff
        )

    def forward(self, x):
        x = self.flatten(x)
        logits = self.linear_relu_stack(x)
        return logits

model = FFFNeuralNetwork()

test_tensor = torch.randn(1, 1, 28, 28)
model.eval()

output = model(test_tensor)

print(output)

The output:
2.0.1
Traceback (most recent call last):
  File "/home/ubuntu/projects/feedfast-pg/small.py", line 47, in <module>
    output = model(test_tensor)
  File "/home/ubuntu/projects/feedfast-pg/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ubuntu/projects/feedfast-pg/small.py", line 38, in forward
    logits = self.linear_relu_stack(x)
  File "/home/ubuntu/projects/feedfast-pg/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ubuntu/projects/feedfast-pg/.venv/lib/python3.10/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/home/ubuntu/projects/feedfast-pg/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ubuntu/projects/feedfast-pg/.venv/lib/python3.10/site-packages/fastfeedforward/fff.py", line 334, in forward
    raise ValueError("Cannot use soft decisions during evaluation.")
ValueError: Cannot use soft decisions during evaluation.

I have found a workaround, but I still think this is a bug.
In my example above the model class code:
my_fff = FFF(
    input_width,
    leaf_width,
    output_width,
    depth,
    activation=nn.ReLU(),
    dropout=dropout,
    region_leak=region_leak,
)

class FFFNeuralNetwork(nn.Module):
    def __init__(self):
        super(FFFNeuralNetwork, self).__init__()
        self.flatten = nn.Flatten()
        self.linear_relu_stack = nn.Sequential(
            nn.Linear(28 * 28, input_width), nn.ReLU(), nn.Dropout(dropout), my_fff
        )

    def forward(self, x):
        x = self.flatten(x)
        logits = self.linear_relu_stack(x)
        return logits

becomes
class FFFNeuralNetwork(nn.Module):
   def __init__(self):
       super(FFFNeuralNetwork, self).__init__()
       self.flatten = nn.Flatten()
       self.linear_relu_stack = nn.Sequential(
           nn.Linear(28 * 28, input_width), nn.ReLU(), nn.Dropout(dropout)
       )
       self.fff = FFF(
           input_width,
           leaf_width,
           output_width,
           depth,
           activation=nn.ReLU(),
           dropout=dropout,
           region_leak=region_leak,
       )

   def forward(self, x):
       x = self.flatten(x)
       logits = self.linear_relu_stack(x)
       logits = self.fff(
           logits, use_hard_decisions=True if not self.fff.training else None
       )
       return logits

i.e. I make the FFF class its own parameter in the class and call it explicitly in the forward method, with the keyword parameter use_hard_decisions=True if not self.fff.training else None

Hi @oliverguhr @smpurkis ,
Great issue, thanks for pointing it out! I believe this was fixed in v0.2.1, which went live on PyPI today.
Could you please pip install fastfeedforward --upgrade and confirm?

Thanks a lot @pbelcak! Version 0.2.1 fixed it, so I am closing this issue.


feat: Add new config option: ConvertNullToZeroValues

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
Add new config option: ConvertNullToZeroValues.  When enabled, ConvertNullToZeroValues will convert SQL null values to zero values for model fields which are not pointers.
If the new option is not enabled, the change has no affect on performance or semantics of gorm's handling of nulls.
User Case Description
This change will support the following use cases:

Support teams that need to use protobufs for declaring models.
Support teams that need to explicitly rely on gorm V1s style of converting SQL null values to zero values for non-pointer model fields.

Background
Our app (HashiCorp Boundary) uses Protobufs to represent our models for a variety of reasons.   When we started using gorm V1, it converted Nulls to zero values for basic types which are not pointers.
There are significant blockers to changing to our models are this point.   A few prominent reasons are: Protobufs do not support pointers for scalar types directly.   Changing our Protobuf types for existing fields would mean a breaking change across our SDK and public API.

Happy to open a PR in the documentation repo if this PR is accepted.

Hi @jimlambrt
Maybe we could change the default behavior and also make it works for the slice.

good！
------------------ Original ------------------
From: Jim @.>
Date: Wed,Oct 13,2021 7:36 AM
To: go-gorm/gorm @.>
Cc: heige @.>, Comment @.>
Subject: Re: [go-gorm/gorm] feat: Add new config option:ConvertNullToZeroValues (#4710)
Now that I've merged from master locally, the sqlserver test failure is reproducible.
Also, this commit on master has the same failed tests: #4771
Perhaps something in this PR is the issue?  When I have time tomorrow, I'll do some more digging.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

for idx, field := range fields {
values[idx] = field.ReflectValueOf(db.Statement.ReflectValue).Addr().Interface()
if field.FieldType.Kind() == reflect.Ptr {
values[idx] = field.ReflectValueOf(db.Statement.ReflectValue).Addr().Interface()
} else {
reflectValue := reflect.New(reflect.PtrTo(field.FieldType))
reflectValue.Elem().Set(field.ReflectValueOf(db.Statement.ReflectValue).Addr())
values[idx] = reflectValue.Interface()
resetFields[idx] = field
}
} this code should be optimized.i will adjust it.
发自我的iPhone
------------------ Original ------------------
From: Jinzhu @.>
Date: Wed,Oct 13,2021 9:02 PM
To: go-gorm/gorm @.>
Cc: heige @.>, Comment @.>
Subject: Re: [go-gorm/gorm] feat: Convert SQL null values to zero values for model fields which are not pointers. (#4710)
Merged #4710 into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Add missing "group" for Gradle, Fix compile errors and a typo on row.g("name").

The instructions for Using gradle is missing a 'group' key.

Thanks for the contribution!
Have you signed the RethinkDB CLA yet? If you have, just leave a note here -- otherwise, please leave a note after it's signed.

Yes. I've signed the CLA.


Redesign TagHelper content modes.

Removed ContentBehavior

Removed all tests and instances of ContentBehavior in preparation for moving to a non-ContentBehavior based design.
Removed ContentBehavior specific CodeGeneration.

Re-design TagHelperOutput and runtime dependencies to allow all content modes.

Added PreContent, PostContent and ContentSet properties to TagHelperOutput.
Added GeneratePreContent, GeneratePostContent and SupressOutput methods to TagHelperOutput.
Added multile ExecuteChildContentAsync and GetChildContentAsync to the rendering phase, ultimately only exposing GetChildContentAsync to a TagHelper author.
Added more knowledge of StartWritingScope and EndWritingScope to the TagHelper runtime components. This is to enable the runtime components to utilize the RazorPage's infrastructure to render a delegate to a writer and retrieve its value to ultimately expose it to the user.

Modify tests to allow new content mode design for runtime components.

Added a new internal ctor for TagHelperExecutionContext since it's used in multiple tests to allow for less friction testing.

Added CodeGen for TagHelper content mode redesign.

Modified the CSharpTagHelperCodeRenderer to understand a single line of TagHelper rendering (instead of doing different things based on ContentBehavior).
Modified existing CodeGen output to reflect new content changes.

#221
/cc @dougbu @pranavkm

Looks good. :shipit: once the (mostly) minor comments are addressed.

Will merge this once the Mvc reaction change is signed off on.

:watch: mostly about apparent differences between null and empty

Reopened so comments update. Updated.

:shipit: with small fixes mentioned above

Will merge in once reaction PRs have been signed off on.


feature(page-sections) Add links to individual page sections

What: Adds links to the headings of page sections.

Why: Makes it easier to share specific parts of the documentation.

How: Added a basic function to page-sections that converts the section title to a lowercase string with dashes.

@tdeschryver Would you like to take a look at this? Thanks!
Anyone else who wants to review and give a 👍  or 👎  that'd be helpful, then I can merge it in.

Looks good for me!
Later on we can make it a bit fancy with an icon when you hover over it (like the github readme)?

@tdeschryver good call on the :hover state. I'll get that in soon.

A few updates:

Merged in master
Added in slugify to create slugs instead of the fn I had before
Added in a link svg and used that to make a nice :hover effect. (see below)

Love it! Thanks! I think the link svg looks a little big. How about the same size ratio that we see on GitHub README links?

How's this change I pushed?


Add editorconfig for formatting

The current indentation of the project is messy. Editorconfig will provide a minimum requirement

The added file is picked up by the rat plugin and flagged as invalid. It needs to be excluded or have the license header set on it.


Slow matching with nested repeats.

Matching Repeat { e: Group { e: Repeat { e: AnyChar, r: Range { min: 5, max: None }, greedy: true }, i: Some(1), name: Some("n") }, r: Range { min: 42, max: None }, greedy: true } against a long chunk of unicode like
"\u{56473}\u{63a75}\u{107c79}\u{7c030}\u{8a7f6}\u{a4f7b}\u{4eea6}\u{ad928}\u{12675}\u{6323f}\u{794a4}\u{817ec}\u{6f713}\u{7914a}\u{10e550}\u{6dc6f}\u{4a8e4}\u{f7a07}\u{231d0}\u{a7e2e}\u{ddb5d}\u{a9ec7}\u{ee178}\u{e5e77}\u{35d57}\u{421c4}\u{d30ce}\u{61027}\u{1052e3}\u{d473a}\u{997e0}\u{3b93d}\u{4596d}\u{983ab}\u{e9363}\u{6d87f}\u{35d63}\u{dbfd6}\u{790b}\u{1097ec}\u{375c6}\u{76e}\u{d3616}\u{25e80}\u{a1544}\u{49aa}\u{fa8e1}\u{f498b}\u{278c3}\u{a6567}\u{9a253}\u{ccff6}\u{7f363}\u{788e4}\u{68c96}\u{b092a}\u{21d45}\u{70377}\u{bdc9d}\u{7c7f7}\u{b05e1}\u{a9abc}\u{91ffb}\u{2496b}\u{309f7}\u{9ff19}\u{1019dc}\u{8ee5}\u{61bed}\u{6eb4}\u{9d7a0}\u{3e68}\u{b8bb3}\u{b23b2}\u{8b706}\u{e72a0}\u{2f0da}\u{9f644}\u{7d228}\u{b1e47}\u{9b255}\u{ad2c1}\u{1a85e}\u{f9380}\u{8d222}\u{85a31}\u{22243}\u{7a07f}\u{336b0}\u{50709}\u{d3c71}\u{35812}\u{1f110}\u{17dc9}\u{1043a7}\u{20eec}\u{dd02d}\u{1825b}\u{786b9}\u{68a4c}\u{2649f}\u{e3f54}\u{2b56c}\u{eefae}\u{c39de}\u{fd8d6}\u{14bea}\u{c1743}\u{562d0}\u{5d75f}\u{8c31d}\u{10e84}\u{c9393}\u{1ea94}\u{609dc}\u{ecfdd}\u{109bdb}\u{c76c0}\u{5a0d8}\u{a6009}\u{36936}\u{8fe4f}\u{2e417}\u{5e762}\u{66cdc}\u{cd361}\u{8a8a3}\u{54ff1}\u{3e58b}\u{5c8e5}\u{8726a}\u{293b}\u{5c096}\u{7f6a4}\u{b30b7}\u{bff6b}\u{ac951}\u{256de}\u{ee51c}\u{c5b5a}\u{cbdbd}\u{7e56c}\u{abf38}\u{80042}\u{10e603}\u{4972b}\u{f3b08}\u{46ab2}\u{e516f}\u{72552}\u{d1320}\u{c1a6c}\u{37379}\u{a97bf}\u{b4b37}\u{13191}\u{9c786}\u{12cba}\u{b75f5}\u{580ae}\u{106904}\u{5a658}\u{35548}\u{220eb}\u{e5322}\u{fba80}\u{5d3b5}\u{55c04}\u{c033a}\u{1028e4}\u{d7d6c}\u{e74e0}\u{8292b}\u{b16bc}\u{c9296}\u{d7f16}\u{da943}\u{3441}\u{b885f}\u{c5286}\u{ac736}\u{b0c0d}\u{8e090}\u{bf655}\u{76a7f}\u{105076}\u{d366b}\u{3bf1b}\u{bf678}\u{b2845}\u{44ab5}\u{1695f}\u{512f1}\u{641ac}\u{524f4}\u{da86e}\u{5e766}\u{7aa16}\u{6c089}\u{980fd}\u{ee174}\u{1f992}\u{4a706}\u{35303}\u{9e036}\u{104df9}\u{ade5b}\u{e08a0}\u{2a022}\u{5f937}\u{61c67}\u{5c583}\u{67900}\u{29fbd}\u{5a651}\u{101721}\u{c65a2}\u{d3c10}\u{47369}\u{353f9}\u{3f28c}\u{67e9b}\u{cac74}\u{c05f9}\u{92962}\u{e0f4e}\u{ca97f}\u{c1755}\u{d5051}\u{7fd5b}\u{a93b0}\u{f37bf}\u{4917}\u{2506e}\u{3d14b}\u{e9117}\u{278b1}\u{71d9f}\u{70e66}\u{44502}\u{fc996}\u{8e759}\u{ce17f}\u{f59e6}\u{1017f1}\u{ecdcf}\u{d7146}\u{255c3}\u{767}\u{f467b}"

takes a long time (about 2 seconds for 250 characters on my machine). I'm not certain that this is superlinear behaviour, but it seems very slow. This structure of repeat-group-repeat seems to be necessary to reproduce this problem.

Could you please provide the actual pattern that's being used? It's too hard to read the AST. (The AST is good to provide to reduce ambiguity, thank you, but please also include the actual pattern.)
If you do indeed have nested repeats, then I don't see how that results in superlinear behavior. A regex like a{1000} is equivalent in every way to a repeated 1,000 times, so the size the of regex is proportional to a 1,000 times as opposed to the literal string a{1000}. If you nest repeats, then you end up with multiplicative explosion. i.e., (a{100}){100} is equivalent to a{10000}.
In any case, repeats are precisely the case where DFAs perform poorly, because they typically require many states. Lots of states means more memory. If you have enough states, the DFA will fall over and you'll revert to the Pike VM NFA, which is already about an order of magnitude slower than the DFA.

Here's a similar regex with the same behaviour: "((?su:.){5,}){42,}?".

So you're right that a regex like (.{5,}){42,} is slow. DFAs do really badly on big repeats because it needs to build lots of states. With this regex, by the time it's done searching 2GB of text, it has 349 states and every state has a huge number of instruction pointers in it. Here's a small sample, where the number on the left is the state index and the number on the right is the number of NFA states (i.e., instruction pointers) in the DFA state:
  0: 3
  1: 5
  2: 7
  3: 9
  4: 11
  5: 15
  6: 17
  7: 19
  8: 21
  9: 23
  10: 27
  11: 29
  12: 31
  13: 33
  14: 35
  15: 39
  ...
  331: 435
  332: 441
  333: 443
  334: 447
  335: 449
  336: 451
  337: 453
  338: 461
  339: 463
  340: 465
  341: 467
  342: 479
  343: 483
  344: 485
  345: 489
  346: 491
  347: 495
  348: 499
  349: 501

This is made a lot worse because of ., which matches any character, so the states keep building and building. Remember, in the lazy DFA, the haystack can influence the size of the DFA, which is why we bound it . For example, if we change the regex to (a{5,}){42,}, then searching the same text results in the creation of only 10 states:
  0: 2
  1: 3
  2: 4
  3: 5
  4: 6
  5: 8
  6: 9
  7: 10
  8: 2
  9: 11

This is probably because the input never has more than 10 consecutive as in a row (indeed, I confirmed that it has one match for a{9} but none for a{10}), so the DFA never needed to build more states to match more than 10 consecutive as. In contrast, using . will all but guarantee getting a number of DFA states roughly proportional to the number of times . is repeated because it matches everything.
Let's bring this back to reality. Consider GNU grep, a known fast regex implementation. We'll search that same 2GB of text:
$ time xrep -c '(.{5,}){42,}' all
55223

real    0m4.008s
user    0m3.907s
sys     0m0.097s
$ time LC_ALL=en_US.UTF-8 egrep -a -c '(.{5,}){42,}' all
55223

real    0m9.529s
user    0m9.227s
sys     0m0.297s

Lest we believe this crate is just better at Unicode, let's do byte based matching too:
$ time xrep -c '((?-u:.){5,}){42,}' all
59350

real    0m3.932s
user    0m3.810s
sys     0m0.117s
$ time LC_ALL=C egrep -a -c '(.{5,}){42,}' all
59350

real    0m7.933s
user    0m7.677s
sys     0m0.250s

So despite this crate being slow on these regexes, it is still faster than GNU grep on the same regexes. To me, that implies we aren't doing too badly.


Grammar docs in code blocks and linked to online grammar

Private comments using /* */ style comments are ignored because they are not intended for the html docs.

Thanks for working on this!


Qiskit documentation for characterization

Summary
Addressing #88
Details and comments
This is a WIP. So far I wrote the section "Generating Coherence Circuits", but I have to write an additional section "Analyzing the Results".
@dcmckayibm I appreciate if you can:

Already review what's done so far.
Write about ZZ.

Thanks!

I wrote the Analyzing the Results section. Still need to fill in a few placeholders and fix rst syntax, but the main text is essentially ready.

Ready for review.
Note that :math: is not working, also in https://github.com/Qiskit/qiskit/blob/master/docs/aer/device_noise_simulation.rst.

I fixed a few typos, please check that it's OK.
A couple of unfixed comments:

"a single qubits data" - not sure if it's correct.
The Latex/Python expressions towards the end of the document do not display well, at least not in GitHub. Also there is some inconsistency between the expressions, for example one expression has Latex \cos while the other one has Python np.cos.

@yaelbh I'll look into these

@yaelbh please review my changes to make sure the last section is still technically valid.

I took the liberty of writing the last two equations in a simpler form. Were there reasons why they were written in the prior form, or is the new form alright?

@dcmckayibm please check the equations.
:math: is totally not working for me, and from raw I can't figure what e.g. a \, e^{-t/{T_2}^*} \, \cos(2\pi ft + \phi) + c means.

@yaelbh for now, https://quicklatex.com/ will let you render the latex code

@yaelbh do you think users would benefit from any references to published research these tools were based on?

@dcmckayibm please see https://github.com/Qiskit/qiskit/pull/160#issuecomment-469382678, thanks

I can't think of a simple reference off the top of my head because these functions are kind of an amalgamation of different sources. We will have some community notebooks with more detail.

Are the equations correct?

@yaelbh I rewrote the equation in simpler forms by grouping terms and using trig identities. Are you asking about the mathematical correctness, or the fact that they're not rendering in that screenshot? The doc is rendered in HTML

Looks ok


Fix slider minimum value

should be drop if #3167 is merge

Closing since PR #3167 is merged.
Please reopen if I missunderstood.

No that was it. Thanks


Does not highlight

When I use Codesnap , there is no syntax highlighting.

@ProudRabbit can you verify if this happen in other codes with other languages?

@ArthurLobopro I've tested both C and Python, and neither has syntax highlighting.

@ProudRabbit I tested in python and the extension is working correctly for me. The syntax highlight is made copying the styled text from vscode editor using "editor.action.clipboardCopyWithSyntaxHighlightingAction". This command copy the text as HTML with all syntax highlight.  It looks like your vscode is not doing this command well.

@ProudRabbit if you have a google account you can made a simple test:

You can select a code and use Ctrl + Shift + P and use the command Copy With Syntax Highlight
So you can create a Google Docs document and paste te code there.

Here is the code pasted in my google docs. If you made this you can test if the vscode command is working well.

@ArthurLobopro I re-installed vscode and tested it. When I did not log in to the account to sync settings, I copied the code to word. The syntax highlight was still there. After I logged in to the account, the syntax highlight was gone. Disable all extensions and the problem persists.   "editor : copy with syntax highlighting" always on.

@ProudRabbit it look like some VSCode setting you have sync is breaking the Highlight. Are you using experimental GPU rendering. I saw something a VSCode project to render the code using a canvas to use the GPU. If you are using this feature, maybe the text will not be stylized when you copy

@ArthurLobopro I have found the reason. The issue is caused by the setting editor.experimentalEditContextEnabled:true . Thank you for your help. 😄  👍

@ProudRabbit nice! If you have any problems don't hesitate to open a issue to solve the problem!


How to return html of the page to variable?

Sorry for a noob question.
In php it is CURLOPT_RETURNTRANSFER, 1
How to return html of the page to variable using your lib?

CURLOPT_RETURNTRANSFER was invented by the PHP binding. :(
you can hava a look at https://github.com/andelf/go-curl/blob/master/examples/channal_callback.go.

thanks :)


Multi Field (Nested Properties)

Hi,
I need to use multi fields, that is I have a property that has sub-properties, what should I do in order of:

Property creation
-mapping
-indexing
-searching

After that I need to create a query that search the path ( I already created path tokenizer) thanks to
@Mpdreamz
@KodrAus
along with the properties I have in my class, which are normal properties and nested properties.
Thanks,

A quick example can be found here
This .Fields() method is available for all property types e.g inside String() Number() etcetera and allows you to introduce multi-fields.
In the linked example we create a NotAnalyzed multi-field called sort that we can use the sort on the name as it was passed in.

Thank you for your example, I have read it but  I wonder how the value of "sort" can be set while indexing, so we can search for it later , also how the classes design of the Parent-child look like?
Thank you very much

The multified takes it value from its parent
e.g
public MyClass {
    public string Name { get; set; }
}

We can create N multifield mappings for Name but we only ever have to supply it once during indexing.

I think the point of the Multi field type is that the data that goes in is the same, but what changes is the analyzer and type, so you can index / query over the same data in different way.
In the example Elastic gives, you have this property:
"name" : {
  "type" : "string",
    "index" : "analyzed",
      "fields" : {
        "raw" : {"type" : "string", "index" : "not_analyzed"}
    }
}

Which could look like this when indexed with the value "My property value":
"name" : [ "my", "property", "value" ]
"name.raw" : "My property value"

So you can use name.raw for exact matching. You could perhaps also use it to do something like this:
"isbn" : {
  "type" : "number",
    "index" : "not_analyzed",
      "fields" : {
        "autocomplete" : {"type" : "string", "index" : "my_ngram_autocompleter"}
    }
}

Which, if you pass in<PHONE_NUMBER>890 could give you:
"isbn":<PHONE_NUMBER>890
"isbn.autocomplete": ["978", "9781", "97812", "978123", "9781234", "97812345", "978123456", "9781234567", "97812345678", "978123456789", "9781234567890"]

I'm not certain if that's how the casting works though.
So if you want fields with different values, you can just use a plain old C# object, and NEST's mapping will automagically figure it out for you.