Refactor MeasurableElemwise and its use

This PR refactors the design of MeasurableElemwise and the rewrites that use it (i.e. the changes mostly introduced by https://github.com/aesara-devs/aeppl/pull/26).
These changes make it easier for others to extend the coverage of measurable Elemwise transforms using basic rewrite DB registration.  They also put each transformation rewrite under the management of Aesara's rewrite system independently, which means that they can be applied more efficiently (e.g. hash-based lookups on distinct Op instances) and their application can be enabled/disabled and tracked with more granularity—among other things.
The additions in #144 have also been added.

[x] Consider replacing the negation and subtraction rewrites with direct transform-constructing rewrites to avoid breaking canonicalization (see the comments in #144)

Closes #170

This looks great, and now that it's cleaned up it looks more obvious to me what can be further improved.
Do you want to also go ahead and include the changes in #184 or do you want to leave it for future work?
More general comment
I am not convinced that in the simple situations AePPL currently supports we need to rewrite the graph at all. That could be useful to have a "canonicalization" phase where we could rewrite transforms of RandomVariable when they return a known distribution (ratio of StandardNormalRV for instance). Here, the model graphs contain all the information we need. To be able to compute the model's logdensity without rewriting the graph we would need:

To register every RandomVariable's logdensity.
To register the inverse transform of Aesara operators to compute the upstream value variables;
To register the way transforms act on logdensities.

However, pushed a little further, rewriting the graph could be very interesting for AeMCMC. We would need to replace every random and observed variable in the graph by their corresponding measure, including their domain and logdensity graph. That means starting from the known measures and pushing them through the transforms, thus getting a graph of Measures; transforms are then irrelevant if we also keep track of the relation between value variables in parallel. This is probably what we should be aiming for in these rewrites, instead of replacing Aesara operators with RVTransforms

Do you want to also go ahead and include the changes in #184 or do you want to leave it for future work?

Let's do that one in a follow-up.

More general comment

Yes, there's a lot to rework here.  I'm going to merge this one so that—in the meantime—our existing functionality is preserved and better designed.  At the very least, it should be a lot easier to rewrite/redesign in this form compared to the current.


Refactor DependencyUtils so that distToRoot can be reused

The inner functions distToRoot and countSteps have been pulled out so that they can be reused elsewhere.  There is also a distToRootOpt that makes it more obvious that the root may not be reachable.

This refactoring was added so that Masha doesn't need to do something the hard way next time.


Source refactor

Love the project!  I hope I'll be able to contribute.  Here's a PR to move things into a project structure that I hope will be more accessible and maintainable than the single large conv.py file in your original repo.
For easier maintenance, this checkin just moves things around;
Splits into multiple source files, and adds 'setup.py' to make
an installable package with a command-line entrypoint 'z80conv'.
Also adds setup.cfg settings for pycodestyle and pylint,
and an explicit license file with the GPLv2 text.
For development, it will be convenient to install using
pip install -e <directory>
then you can run the current code using z80conv < FILE.ASM.

Thank you for the PR!  This indeed looks more maintainable.


Log funding txid

refs: #676
Unlike the redemption TX ID, the funding TX ID is not logged in events.

got some commits mixed up in here


Strange response time and lack of spotter functionality for Assetto Corsa v1.12 (64-bit)

In AC v1.11 at the start of the race CrewCheif would tell me the track temps and such before leaving the car-setup menu.  Currently, the application waits until 30 seconds (or so) into the race before talking about track temps--which isn't really an issue, but as far as I know this is not intended behavior.  Likewise, the spotter utility seems to be totally nonexistent with AC's latest build.

Hi Stewie,
You may want to join and post in AC section of http://thecrewchief.org/ for higher visibility.
Vytautas

So you're not getting any 'car left' / 'car right' calls with 1.12? They added some data to one of the shared memory blocks but I thought it was at the end. I'll investigate later and update here

Just to check... The crew chief python app hasn't been disabled by the update (in the assetto UI) has it?

Nope--that was the first thing I checked was whether or not the app hadn't been disabled (in Settings>General).  Checked the in-game UI and saw that the UI element had been disabled--I reenabled the in-game UI element, restarted AC (and CC) and did some test races to see what all happened.  The spotter seems to be running, though things still seem out of sync initially, then it will correct itself.
Actually, I the last test race I did ended with me spinning out and quickly closing the game--and now both all "still there" clips continue to repeat while the game is closed and CC remains running; not a big deal, and it could be a one-off exception.
The "track temps" and other pre-green messages still seem to be delayed as well; not entirely sure what all was in the new update that could have changed that, though.
~So, re-enabling the UI element seems to have brought the spotter back, though there still seems to be a bit of lag in the playing of the audio files at the start of the race, including the spotter function.  Attached are two logs of instances of "lag" in CC's audio clips at the start of a race--the first taking place at Brands Hatch GP with no modded-cars being used, and the latter at the Fort Wayne Oval modded track.  Both locations produced similar results, with the slight variant of the race and Brands Hatch GP's (which I exited shortly after spinning out) which resulted in a indefinite loop of audio playback--as shown in the log file.
BrandsHatchGP_OddBehavior_CCv4.5Log.txt
FortWayneOval_OddBehavior_CCv4.5Log.txt

closing this one as it should be fixed in next week's update


Little typo fix

I just found a typo in the demo.
Hope this is not a problem for creating a PR for such a small thing :)

Thanks :)


#18131 Fix auto-convert keyword case, refix blocks case on auto-insertion

Please, test also #15266 part 4 about keyword case on block auto insertion.

Case preference doesn't influence auto format when the word is written in full, it looks inconsistent and can be very frustrating for user.

It used to work this way, I just returned the previous behaviour and provided another fix for #15266


JsonSerializerSettings are null by default on HubOptions

It should be set by default so that code like this works:
services.AddSignalR(options =>
{
    options.JsonSerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
});

@BrennanConroy could you take a look at this today?

I'll take it.


Inspector dispays file content instead of map.sourcesContent

Inspector dispays file content instead of map.sourcesContent when using inline source map and map.sources[name] with name===filename
if name differs from real filename then map.sourcesContent displayed

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29771044-inspector-dispays-file-content-instead-of-map-sourcescontent?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

and it works as expected with --no-preload flag

Also if filename and name defined in map.sources are equals breakpoint can't be set at runtime  (even with --no-preload flag)
When names are different all works as expected

Are you using babel?

Actually i'm using require.extensions callback, inside it i'm reading file contents and modify it (replace some lines) then pass modified source to the babel.transform method and then perform module._compile
I expected that I would see the modified file, but the inspector displays the original file from disk or even sometimes transpiled file without sourcemap applied
here simplified gist example
read comment there


fix(api): treat POLYX as a divisible asset when transferring

:tada: This PR is included in version 6.0.0-beta.8 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use faraday 2

Use the newer way of basic auth, to use the latest faraday gem
https://github.com/lostisland/faraday/blob/main/docs/middleware/request/authentication.md

Resolves https://github.com/kanet77/togglv8/issues/32


Fixing paths for apache error and access logs

Paths were saved to:
/var/log/apache2helloapp-error.log
/var/log/apache2helloapp-access.log
Instead, it should be:
/var/log/apache2/helloapp-error.log
/var/log/apache2/helloapp-access.log

@dotnet-policy-service agree

@selvinfehric, thanks for the contribution!  You are correct, it should have followed: ErrorLog ${APACHE_LOG_DIR}/example.log.


fix scene_cut inaccuracy bug

cut videos by seconds rounded to two decimal places (i.e., 0.01 sec). Previously rounded to the nearest integer (i.e., 1 sec), which causes inaccuracy up to 0.5 sec.

Glad to help.
line 107 max_duration = FrameTimecode(max_seconds, fps=fps)
The maximum duration is 15 seconds, and the frame rate is 100, so the max_duration is "00:00:00.150".
The max_seconds might lose its effect.

I tried
t = FrameTimecode(14.989, fps=100)
print(t.get_seconds())
and the output is 14.99, which is expected.

Now I understand why. When inputting an integer, it is represented as the number of frames rather than seconds.

exactly


cargo doc fails

error: unused extern crate
 --> /home/dpc/.cargo/registry/src/github.com-1ecc6299db9ec823/base64-0.9.2/src/line_wrap.rs:1:1
  |
1 | extern crate safemem;
  | ^^^^^^^^^^^^^^^^^^^^^ help: remove it
  |
note: lint level defined here
 --> /home/dpc/.cargo/registry/src/github.com-1ecc6299db9ec823/base64-0.9.2/src/lib.rs:59:57
  |
59|     missing_docs, trivial_casts, trivial_numeric_casts, unused_extern_crates, unused_import_braces,
  |                                                         ^^^^^^^^^^^^^^^^^^^^

error: Compilation failed, aborting rustdoc

error: Could not document `base64`.

With which version of rustdoc?

Your nightly is quite out of date, so an update should get you running again. Both stable and current nightly work for me; current beta still has the issue that was recently fixed in https://github.com/rust-lang/rust/issues/51661. Feel free to re-open if needed.


Lodash 1.8.3 fails to draw the example

The error
sequence-diagram.js:1069Uncaught TypeError: Cannot read property '_actors_height' of undefined

I added this:

Kind of defeats the point though

Hi,
I use meteor 1.3, and also when I load your suggested module, I still get the error
TypeError: Cannot read property '_actors_height' of undefined
    at sequence-diagram-min.js:7
    at arrayEach (modules.js?hash=a266233…:7137)
    at Function.forEach (modules.js?hash=a266233…:15225)
    at HandRaphaelTheme.layout (sequence-diagram-min.js:7)
    at HandRaphaelTheme.draw (sequence-diagram-min.js:7)
    at Diagram.drawSVG (sequence-diagram-min.js:7)
    at HTMLDivElement.<anonymous> (sequence-diagram-min.js:7)
    at Function.each (jquery.js:384)
    at jQuery.each (jquery.js:136)
    at jQuery.undefined.$.fn.sequenceDiagram (sequence-diagram-min.js:7)

my code
import { Template } from 'meteor/templating';
import { Session } from 'meteor/session';
import '/imports/ui/UIHelpers';
import { APILogs } from '/imports/api/APILogs';
import '/imports/ui/external/raphael-min';
import '/imports/ui/external/sequence-diagram-min';
import '/imports/ui/external/underscore-min';

Template.APILogs.onRendered(function() {
    $(".diagram").sequenceDiagram({theme: 'hand'});
});

html

                Sequence diagram

In this schema you will see the flow from the user requesting the demo page, though the source code of this demo platform to Qlik Sense and back

Andrew->China: Says Hello Note right of China: China thinks\nabout it China-->Andrew: How are you? Andrew->>China: I am good thanks!

Also see https://forums.meteor.com/t/sequence-diagram-in-meteor-cannot-read-property--actors-height-of-undefined/27956/6

Sorry for the delay here. You say "Lodash 1.8.3 " but your example shows "lodash.js/4.13.1/lodash.min.js". Anyway I now test against Lodash 4.17.x, and after a few fixes ebb8987325d6d49287c8672f9b94aae90b03ca01 it all seems to work. Please wait for a v2.0.2 release.

Thanks @bramp,  looking back,  I have no idea where 1.8.3 came from.
Thanks for the hard work. :+1:


RFC: mutual structures

Proposal
I think structures should work in mutual blocks. #2587 reports an error message related to this feature, and everyone commented in the issue expected this to work (I expect this to fulfill the "community feedback" requirement), but the issue is closed as it's not about making it work.
A simple example use case can also be found in #2587.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

Lean (kernel included) considers an inductive type to be "structure-like" iff it is non-recursive, not indexed, and has a single constructor. Because structure types benefit from special treatments such as having primitive projections and eta-conversion, it would be unwise to blindly adopt that RFC. In particular, eta-conversion on recursive/mutual structures leads to a form of undecidability of defeq that's quite hard to deal with.
One possibility to handle this feature would be to allow the structure syntax to construct inductive types which are not structure-like. This would require no change to the kernel. However, such "structure but not structure-like" types would lose both eta-conversion and primitive projections, and would only really benefit from having the notations that are exclusive to structures such as {foo := ...}. I am not certain of the added benefits of this feature, but I am all for having better error messages when using structures in mutual blocks.

I felt silly once having had to write the projection functions for a almost-structure (it was recursive) by hand because I couldn't see structure syntax, so I think there is some added benefit.

Perhaps Lean could benefit from dissociating between structures and non-recursive structures then, including in the kernel. In particular, a recursive structure , could still benefit from having primitive projections, which are great for performance, without having eta-conversion.

Also, I believe some lean libraries already offer a way to automatically generate "projections" on non-structures, notably this one

@arthur-adjedj can you enlighten me on how does structure eta conversion gets undecidable?

Consider the following (recursive) structure:
structure Foo where
  foo : Foo```

 When comparing two arbitrary neutral terms, i.e variables `x =? y : Foo`. The type-checker might want to eta-expand those values recursively, checking against `x.1 =?= y.1 : Foo`, then `x.1.1 =?= y.1.1`, so on and so fourth. Two things to note:
 - Such eta-expansion on i.e variables can be desirable. A (proof-relevant) structure might only contain proof-irrelevant fields for example
 - I don't think such an infinite loop would trigger in Lean in practice currently. Because conversion is untyped in the system, Lean has no way to trigger eta-conversion on two neutrals, and only triggers it when one of the two sides is already built from the constructor. All I am saying is that eta on recursive records is tricky/non-trivial to handle, and might not be necessarily worth the risk.

 I believe Agda supports recursive records, as well as eta-expansion, and also uses typed conversion, which allows it to have eta-conversion on neutrals. Does anyone know how it handles this issue ?


MOPEX needs

@dtarb @aphelionz @pkdash
After conferring with Rick Hooper (@rphtufts) and @Lizabrazil ,  there are several limitations of the current HydroShare that are preventing -- or at least greatly impeding -- publication of the MOPEX data through HydroShare. This is a multi-dimensional issue with deficiencies in three areas:

[ ] Composite resource doesn't yet handle geographic features or referenced time series.
[ ] REST API doesn't allow editing of composite resource metadata and populating composite resources.
[ ] Discovery doesn't react usefully when faced with composite resources.

This is an ideal scenario. We have considered utilizing collection resources instead, and faced almost identical problems:

[ ] REST API doesn't allow populating collection resources or referenced time series?
[ ] Discovery doesn't react usefully when faced with collections of resources (or collections of collections of resources).

At a more detailed level,

A "MOPEX site" contains six related resources, including a shapefile (geographic feature) and five reference time series (referencing a server at CUAHSI.org).
A "MOPEX network" is a series of "MOPEX site"s.
It makes sense to us to populate 500 "MOPEX sites" as composite resources, and then organize them into a "MOPEX network".
Alternatively, we could create "MOPEX time series" and "MOPEX shapefiles", and bind these into collections called "MOPEX sites" and then make an overall collection called "MOPEX network" that contains these.
Neither of these solutions is currently practical.

The MOPEX time series server has been built already, but automatically populating the resources that point to it is currently not possible due to unimplemented parts of the REST API.

Using either solution, we face serious limits in terms of discovery and data interpretation.

There is no current way to navigate from a resource to the collections in which it appears.

Thus, there is no way to relate a "MOPEX site" to the set of "All MOPEX sites" = "MOPEX Network".

Collections come up after instances of collections in discovery, based upon the way things are weighted when searching.

Thus, there is no way in discovery to discover and depict that one is matching a hierarchy of things rather than a single thing. Nor is there an easy way to move from the hierarchy to the individual and from the individual to the hierarchy.

@xuezhaokun We have some work to do on this one. The most obvious thing we can do is to boost text matching by placing all of the metadata from a collection or composite resource into the SOLR text field. This will make the collection naturally come up before the individual resources in SOLR order.

@danames can you let me know if your group can work on the reference time series and geographic feature file types.  @pkdash could give guidance.

@alvacouch @dtarb Where ware we at on this?

@dtarb can we close this? I think we are good except i do not know about the REST API issues.

I believe that composite as currently deployed meets the needs of this case so am closing, while mentioning @alvacouch and @rphtufts.  If there are MOPEX needs not met, please reopen and indicate what the problem is.


Add doc comment to String method to explain its output isn't stable

Is your feature request related to a problem? Please describe.
I wrote code as part of an Example style test that used the generated String() method, forgetting about issue #1121. While it shouldn't have taken me long to figure out this, it did! (I was focused on trying to understand the code that caused instability, and didn't read the doc comment on the Format() method, until much too late.)
Describe the solution you'd like
It would help if a doc comment had surfaced this from the generated messages' String() methods.
// String returns the message as a string.
// This method is only intended for human consumption and ignores errors.
// Do not depend on the output being stable. It may change over time across
// different versions of the program.

I guess the doc comment could be written more briefly if the number of comment lines is a concern.

In addition to concerns about duplication of this same messaging on every generated message, I suspect that most calls to the String method do not happen directly, but indirectly through fmt.Printf and another functionality that understand the fmt.Stringer interface.


feat: Adding print columns for v1 NodePool

Fixes #N/A
Description

Old Printer Column

NAME     NODECLASS   WEIGHT
default  default     100

New Printer Column

NAME              NODECLASS   NODES   READY   AGE   WEIGHT   CPU   MEMORY
default-v1        default     10              22h   45       20    19297984Ki

Adding Node count to the NodePool status for both v1 and v1beta1
Readiness condition will be added with the following PR: https://github.com/kubernetes-sigs/karpenter/pull/1248
v1 RFC: https://github.com/kubernetes-sigs/karpenter/pull/1222

How was this change tested?

manually tested

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 78.3%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/nodeclaim.go
2
89.13%

pkg/controllers/node/termination/terminator/eviction.go
2
89.09%

pkg/controllers/node/termination/controller.go
2
59.81%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
8667

Relevant Lines:
11069

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 78.818%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
8603

Relevant Lines:
10915

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 78.754%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
8596

Relevant Lines:
10915

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 6 (66.67%)  changed or added relevant lines in 1 file are covered.
22 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.07%) to 78.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/nodepool/counter/controller.go
4
6
66.67%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
93.69%

pkg/controllers/provisioning/scheduling/nodeclaim.go
2
89.13%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

pkg/controllers/nodepool/counter/controller.go
11
65.08%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
8591

Relevant Lines:
10912

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 78.825%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
8599

Relevant Lines:
10909

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
173 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.2%) to 78.639%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/controller.go
2
59.81%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

pkg/apis/v1/nodepool.go
20
67.86%

pkg/apis/v1/zz_generated.deepcopy.go
144
24.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8585

Relevant Lines:
10917

💛  - Coveralls


when I'm setting the bubble color programmatically it lose its shape

Hi! Do you use Styling via attributes?

mBubble.setBackgroundColor(mContext.getResources().getColor(R.color.mRed));
no I'm using this line, I'm using it when a message is not delivered to the user

Unfortunately, you can't just set bg color without change the shape of a bubble.
MessageListStyle use this method to set bg color of a bubble:
 private Drawable getMessageSelector(@ColorInt int normalColor, @ColorInt int selectedColor,
                                        @ColorInt int pressedColor, @DrawableRes int shape) {

        Drawable drawable = DrawableCompat.wrap(getVectorDrawable(shape)).mutate();
        DrawableCompat.setTintList(
                drawable,
                new ColorStateList(
                        new int[][]{
                                new int[]{android.R.attr.state_selected},
                                new int[]{android.R.attr.state_pressed},
                                new int[]{-android.R.attr.state_pressed, -android.R.attr.state_selected}
                        },
                        new int[]{selectedColor, pressedColor, normalColor}
                ));
        return drawable;
    }

You could use something similar to it.

how is the above drawable you defined, set on the MessageList?


Nuget for the framework

hello Tolis,
I see that the last build is : 18.2.301.34
Any chance to get the 18.2.4 by the begining of next week ?
Is there any plan to deploy nuget for the framework ?
BR
ISA

Hi,
Unfortunately there are many works and tests to pass, probably by the end, sorry about the delay.
Until then you can always compile the source after running project converter so u can generate all assemblies.

Well i tried but it seems that is not working like it I excpected.
I had a first error when i tried to convert the solution "Xpand.ExpressApp" :

Then i tried to open the solution AllModules and convertit. After the build i had this :

It seems that i passed to fast to 18.2.4. Next time i'll have a look into you builds before.
Best regards and Merry Christmas
Isa

Merry Xmas Isa,
Looks like next XAF minor has breaking changes, however I do not have the resources to pursue this case separately. I am working on integrating the DX nuget and simplifying the build scripts. In addition if you noticed there is an on going integration of the new Packages project and its modules and extensions.
This puts me in an overload state at the moment.
Thanks for the understanding.

Hello Tolis,
Do you have any date for the 18.2.4?
BR
Isa

I am working on it, hope soon

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


On https://prod-preview.openshift.io/ - multiple edit user profile options all link to email field

See attached screenshot - trying to edit the bio or URL result in the email field being highlighted:

This was intentional as this page has not been fully implemented.
Fix by https://github.com/fabric8io/fabric8-ui/pull/1263

As of today, the latest profile page is available in prod.

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[?????] Server Corruption?

1.0.15; I just installed it on my server Fabric server running API v0.24.1 build412 and loader version 0.10.1 build209
I also installed it on my client. I joined the server, everything seemed fine, but when my partner, who does not have TinyTweaks installed (I've used it only serverside before with no problems?), but is using Fabric, joined, for some reason all of the Path blocks had been converted to Repeating Command Blocks on her end. She was even able to pick-block them in creative. Whenever I placed a path she saw it and could use it as a command block, while I had no issues.
Upon closing the server, removing Tinytweaks from the server, and re-opening it, I was able to see the problems too. Now all the path blocks were converted to planted beetroot seeds, and every single block in the game with blockstates has been screwed up horribly. I have absolutely zero idea what the hell happened, and can only assume TinyTweaks is the culprit since none of the issues were present on my client until I removed TinyTweaks. The server is destroyed now, and this is the only place I can think to turn to.

Your world should be fine, this issue only happens when the client and server are out of sync. Versions 1.0.12-1.0.15 of TinyTweaks are required to be installed on both the client and the server. This seems to have caused some confusion, so from 1.0.16 forward, I'll make sure it works passably when installed on only the server. That being said, are you sure the server world is entirely broken? Could you send me your server directory in a zip file?

Update: Put the mod back in the server's mods folder. With the mod enabled clientside, I started the server and joined it. All blocks were back to normal. Removed it again, problems again, put it back, back to normal. So yeah, it's TinyTweaks doing this.

Ah. I'm unsure. I'll try removing the mod from both the server and my client and see if the world is destroyed.

Alright, thanks. Feel free to message me on Discord if you'd like (Haven King#2890).

Sorry for the overreaction. Removing it from serverside and clientside both fixed it, and the world seems to be undamaged.
That said... Maybe a big red notification on the top of the front page would be a good idea, as I can imagine I'm not the only one who used to use TinyTweaks as solely a serverside mod back when you could >.>;;

Yep, that's why I'm going to be changing it back to being able to be used server-side only. Sorry for the confusion!


[feature] #3324: Add client cli burn checks and refactoring

Description

Linked issue

Closes #3324

Benefits

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[x] I replied to all comments after code review, marking all implemented changes with thumbs up

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4716 unchanged lines in 87 files lost coverage.
Overall coverage decreased (-1.9%) to 57.514%

Files with Coverage Reduction
New Missed Lines
%

cli/src/main.rs
1
0%

cli/src/torii/pagination.rs
1
98.9%

config/base/src/runtime_upgrades.rs
1
51.72%

config/src/torii.rs
1
96.67%

core/src/smartcontracts/isi/block.rs
1
87.5%

core/src/sumeragi/network_topology.rs
1
96.76%

crypto/src/merkle.rs
1
96.23%

data_model/derive/src/partially_tagged.rs
1
99.67%

data_model/src/account.rs
1
52.21%

data_model/src/domain.rs
1
47.37%

Totals

Change from base Build<PHONE_NUMBER>:
-1.9%

Covered Lines:
19947

Relevant Lines:
34682

💛  - Coveralls


Show detial info for an event

When an event is opened in the Web-UI the information from the custom dictionary and all the other detailled information would be nice.
I would like to use this for example to gather information about the parameters that are used to call a function. THis helps to decide if the offered parameters are used or not and which parameter combinations should be tested most thoroughly.

@dhindrik is this sort of thing something you would prefer to implement yourself, or are you potentially looking for contributors? Don't want to start looking at this if you're potentially working on it already.

It is something I have planned to do. But I have not started. Contributions are very welcome!


test: scenarios-feature_branch_happy_path (2024-02-08 06:46:50.689017+00:00)

automatic test cleanup


Creating cluster using python docker image never returns or assigns master

Running:
aztk spark cluster create --id oldsparky --vm-size standard_a2 --size 2  --wait --docker-repo aztk/base:spark2.2.0-python3.6.2-base
hangs with the following output:
-------------------------------------------
spark cluster id:        oldsparky
spark cluster size:      2
>        dedicated:      2
>     low priority:      0
spark cluster vm size:   standard_a2
custom scripts:          None
file shares:             0
docker repo name:        aztk/base:spark2.2.0-python3.6.2-base
wait for cluster:        True
username:                spark
-------------------------------------------

Moreover when I run:
aztk spark cluster get --id oldsparky
I can see that no master has been assigned:
Cluster         oldsparky
------------------------------------------
State:          active
Node Size:      standard_a2
Nodes:          2
| Dedicated:    2
| Low priority: 0

Nodes                               | State           | IP:Port              | Master
------------------------------------|-----------------|----------------------|--------
tvm-2164905317_1-20171210t094410z   | idle            | <IP_ADDRESS>:50001  |
tvm-2164905317_2-20171210t094410z   | idle            | <IP_ADDRESS>:50000  |

If instead I run:
aztk spark cluster create --id oldsparky --vm-size standard_a2 --size 2  --wait
then the command returns and a master IS assigned. Is it just that creating a cluster using the python image is slow? I waited for 10-15 mins.

The docker repository you specified for the Python image seems to be misconfigured. Try using: aztk/python:spark2.2.0-python3.6.2-base
All python images live under the aztk/python repository so I believe when the node is being set up, it is failing to find the docker image in the aztk/base repository.

Thanks, I should have checked the repo directly. I'm pretty sure the version I was trying worked on Friday evening. Is there no error message anywhere that would tell me about the misconfigured docker image? I poked around the portal when this was going on but couldn't see any error messages relating to the image. The version you suggested works find.
Btw, the documentation here is incorrect.

Thanks for pointing out incorrect doc, we will get that fixed right away.
And you are absolutely right -- there should be a check for the existence of the docker-image before the cluster is spun up. I raised an issue so you can track that feature (#266).

Closing this since it was fixed in #265


Name Added

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Ashimdevnath there seems to be no final changes, please can you take a look at the files changed tab


Layout broken on mid-width screens

I couldn't recreate this later, I think it was just a temporary hiccup...


Docs are not totally generated prefix $CONDA_PREFIX

Description
Apparently this is is a problem related to the use of $CONDA_PREFIX when building the docs in readthedocs
Reproduce
The issue is related to the CI automation so it does not appear when building manually. Logs from readthedocs indicate the correct package installation.
Expected behavior
Notebooks from the linked cell should be producing the good output.
Current behavior
Check link for current error details

Partially explored on a248766a71dc9e6aedb66d5fb50b70b19cb101f5 and fbd0275e1e7b45ecc54d92abd7eb828276fce3fb
Default paths are exhausted. It considers CONDA_PREFIX, RTD_ENV, .

Last advice here https://github.com/readthedocs/readthedocs.org/issues/4067 was implemented in c575fff0a08bf663e2bf8bf02265f5bcd6344569

Readthedocs environment is now explored as optional in  d4b182d66869e4c919b5973a9e66a18d9fc076f6 and b37ebe6642e17ca0324950269e89658e580204ac


Change localization handling

@lauraluiz I've updated localization. I am following current contentful localozation handling.
It means that I've added query for locale with first of the list locale value.
If locale is supported by contentful space it will return value with fallback to default locale.
Current implementation was wrong, because in raw fields there is only one localization.
Multiple localizations are fetched only using syncing API.
It is possible to use syncing API, and choose correct localization, but using sync API means I would fetch all data from contentful (Or all data of one type. And in our case all of main type - eg. 'page'- which means all data anyway).

@dariuszor looks good! 👍
Is the Contentful's PR for locale fallback for the Sync API too?

@lauraluiz I think yes, there is some test in PR:
https://github.com/contentful/contentful.java/pull/122/files#diff-40f795aa79105c79e04360805895ae02R16
(did I answer your question?)

My bad, space is something different than sync. I didn't spot any changes for sync yet.

@lauraluiz how should I release this package?

@dariuszor I need to release it myself. Do you want me to release it now?

@lauraluiz I am heading home soon. Is it possible to release it today, so I can start working on it tomorrow morning?

@dariuszor 0.1.1 version released


Documentation improvement

I think it would be necessary to start thinking about structuring the documentation the same way as the project documentation is managed JSON for Modern C++

Hi I think that would be a good idea in order to improve adoption for SQLiteCpp, maybe this should be done on some smaller Issues/PRs like:

readme cleanup, and moving additional documentation to a docs directory
make a script in order to generate the proper documentation(and choose which system to use)
document properly the files which are not documented

after that

make a CI for the selected documentation generator
add sections for the library usage so we have something to show

and maybe as an additional step, add a translated version of the documentation(or just the readme)


Is it possible to change where test_bundle.dart file can be generated through pubspec.yaml?

I want to organized my project and move all the test into different folder. But as of right now, If i run
 patrol develop -t test/integration_test/home/home_integration_test.dart

My expectation is that Patrol will generated a new test_bundle.dart inside test folder. Which is the top-most folder inside my given parameter.
What will happen instead is Patrol will created a new folder named integration_test on the project root folder, along with file named test_bundle.dart and the file will attempted to point the import line to the given parameter -t path above. which will result in a failed test No such file or directory.
Looking at --verbose, Apparently this command sort of force running build APK and reference to this specific folder.
flutter build apk --config-only -t integration_test/test_bundle.dart
So i'm wondering if it's possible to specify where test_bundle.dart should be generated. For instance, Flutter_Gen package allow output parameter inside pubspec.yaml. Which allowed me to move all the generated asset string reference inside one specific folder upon generation through CLI and never have to worry about it again.
flutter_gen:
  output: lib/generated
  integrations:
    flutter_svg: true

  assets:
    outputs:
      package_parameter_enabled: false

Here's full log

Verbose mode enabled. More logs will be printed.
Received test target: /Users/myMac/Documents/trade_in_mobile_app/test/integration_test/home/home_integration_test.dart
Generated entrypoint /Users/myMac/Documents/trade_in_mobile_app/integration_test/test_bundle.dart for development
Received iOS flavor: Techswop
$ flutter --no-version-check --suppress-analytics devices --machine
No device specified, using the first one (adb-SWVOFYZ9PVBAEY75-tt3xKO._adb-tls-connect._tcp.)
$ flutter doctor --verbose
$ flutter --suppress-analytics --no-version-check pub deps --style=list
Received device: adb-SWVOFYZ9PVBAEY75-tt3xKO._adb-tls-connect._tcp.
Received 10 --dart-define(s) (0 custom, 10 internal)
Received internal --dart-define: PATROL_WAIT=0
Received internal --dart-define: PATROL_APP_PACKAGE_NAME=com.myapp.myapp
Received internal --dart-define: PATROL_APP_BUNDLE_ID=com.myapp.myapp
Received internal --dart-define: PATROL_ANDROID_APP_NAME=Techswop
Received internal --dart-define: PATROL_IOS_APP_NAME=Techswop
Received internal --dart-define: INTEGRATION_TEST_SHOULD_REPORT_RESULTS_TO_NATIVE=false
Received internal --dart-define: PATROL_TEST_LABEL_ENABLED=true
Received internal --dart-define: PATROL_HOT_RESTART=true
Received internal --dart-define: PATROL_TEST_SERVER_PORT=8081
Received internal --dart-define: PATROL_APP_SERVER_PORT=8082
$ flutter build apk --config-only -t integration_test/test_bundle.dart
$ flutter doctor --verbose
• Building apk with entrypoint test_bundle.dart...
$ ./gradlew :app:assembleDebug -Ptarget=/Users/myMac/Documents/trade_in_mobile_app/integration_test/test_bundle.dart -Pdart-defines=UEFUUk9MX1dBSVQ9MA==,UEFUUk9MX0FQUF9QQUNLQUdFX05BTUU9Y29tLnRlY2hidXNpbmVzcy50ZWNoc3dvcA==,UEFUUk9MX0FQUF9CVU5ETEVfSUQ9Y29tLnRlY2hidXNpbmVzcy50ZWNoc3dvcA==,UEFUUk9MX0FORFJPSURfQVBQX05BTUU9VGVjaHN3b3A=,UEFUUk9MX0lPU19BUFBfTkFNRT1UZWNoc3dvcA==,SU5URUdSQVRJT05fVEVTVF9TSE9VTERfUkVQT1JUX1JFU1VMVFNfVE9fTkFUSVZFPWZhbHNl,UEFUUk9MX1RFU1RfTEFCRUxfRU5BQkxFRD10cnVl,UEFUUk9MX0hPVF9SRVNUQVJUPXRydWU=,UEFUUk9MX1RFU1RfU0VSVkVSX1BPUlQ9ODA4MQ==,UEFUUk9MX0FQUF9TRVJWRVJfUE9SVD04MDgy -Papp-server-port=8082 -Ptest-server-port=8081
	: > Task :gradle:compileJava NO-SOURCE
	: > Task :gradle:compileGroovy UP-TO-DATE
	: > Task :gradle:pluginDescriptors UP-TO-DATE
	: > Task :gradle:processResources UP-TO-DATE
	: > Task :gradle:classes UP-TO-DATE
	: > Task :gradle:jar UP-TO-DATE
	: > Task :app:preBuild UP-TO-DATE
	: > Task :app:preDebugBuild UP-TO-DATE
	: > Task :app:mergeDebugNativeDebugMetadata NO-SOURCE
	: > Task :android_id:checkKotlinGradlePluginConfigurationErrors
	: > Task :android_id:preBuild UP-TO-DATE
	: > Task :android_id:preDebugBuild UP-TO-DATE
	: > Task :android_id:generateDebugResValues UP-TO-DATE
	: > Task :android_id:generateDebugResources UP-TO-DATE
	: > Task :android_id:packageDebugResources UP-TO-DATE
	: > Task :android_id:parseDebugLocalResources UP-TO-DATE
	: > Task :android_id:generateDebugRFile UP-TO-DATE
	: > Task :android_id:compileDebugKotlin UP-TO-DATE
	: > Task :android_id:javaPreCompileDebug UP-TO-DATE
	: > Task :android_id:compileDebugJavaWithJavac NO-SOURCE
	: > Task :android_id:bundleLibCompileToJarDebug UP-TO-DATE
	: > Task :app:checkKotlinGradlePluginConfigurationErrors
	:
	: > Task :app:compileFlutterBuildDebug
	:
	: > Task :app:compileFlutterBuildDebug FAILED
	:
	: Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
	:
	: You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
	:
	: For more on this, please refer to https://docs.gradle.org/8.4/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
	: 15 actionable tasks: 3 executed, 12 up-to-date
✗ Failed to build apk with entrypoint test_bundle.dart (Gradle build failed with code 1) (7.5s)
#0      AndroidTestBackend.build.<anonymous closure> (package:patrol_cli/src/android/android_test_backend.dart:77:9)
<asynchronous suspension>
#1      DisposeScope.run (package:dispose_scope/src/dispose_scope.dart:46:7)
<asynchronous suspension>
#2      AndroidTestBackend.build (package:patrol_cli/src/android/android_test_backend.dart:47:5)
<asynchronous suspension>
#3      DevelopCommand._build (package:patrol_cli/src/commands/develop.dart:266:7)
<asynchronous suspension>
#4      DevelopCommand.run (package:patrol_cli/src/commands/develop.dart:237:5)
<asynchronous suspension>
#5      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#6      PatrolCommandRunner.runCommand (package:patrol_cli/src/runner/patrol_command_runner.dart:348:18)
<asynchronous suspension>
#7      PatrolCommandRunner.run (package:patrol_cli/src/runner/patrol_command_runner.dart:292:18)
<asynchronous suspension>
#8      patrolCommandRunner (package:patrol_cli/src/runner/patrol_command_runner.dart:70:20)
<asynchronous suspension>
#9      main (file:///Users/myMac/.pub-cache/hosted/pub.dev/patrol_cli-3.1.0/bin/main.dart:6:20)
<asynchronous suspension>

Hi @famasf1 ! Currently we assume that all your tests are in integration_test folder, which is placed in root folder of your project. We made this simplification a while ago, but maybe we should get back to this again. Let's treat this issue as feature request


Avoid NullPointerException when calling unregisterMBean

@anistor wdyt

Where did the problem appear? Why does somebody call unregisterMBean if there's no mbeanserver (which basically means jmx is not enabled) ?

@anistor I just saw that in the code where the check was everywhere (working on something related to quarkus) and I thought it might be good to be coherent with the check in every method, but not mandatory to merge. we can close it if you consider there is no real danger of nullpointer


Add ability to use C# callback result in js, add .ConfigureAwait(false) #58

@redradist can you check in Extension.razor that I understood you well ?

@RemiBou Yeah, that exactly what I wanted !! Cool !!
Will it work with all return types that could be converted in Json ?
I mean C# string, float, custom objects and so on ?

Yes I think so
Le mer. 29 juil. 2020 à 22:39, Denis<EMAIL_ADDRESS>a écrit :

@RemiBou https://github.com/RemiBou Yeah, that exactly what I wanted !!
Cool !!
Will it work with all return types that could be converted in Json ?
I mean C# string, float, custom objects and so on ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RemiBou/BrowserInterop/pull/59#issuecomment-665914351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKLY6SPVZO4AOF4AHSTW7DR6CCHPANCNFSM4PL66HEA
.

Deployed in https://www.nuget.org/packages/BrowserInterop/1.1.0


Docs: useMutation's returned data property description

Describe the bug
I am reading the docs for useMutation and one of the returned properties is data.
useMutation docs
This is the description:

data: undefined | unknown

Defaults to undefined
The last successfully resolved data for the query.

The last part mentions a query - what query would that be?
If it's a typo, what does the data property actually contain?
Your minimal, reproducible example
https://tanstack.com/query/latest/docs/framework/react/reference/useMutation#:~:text=data%3A undefined | unknown
Steps to reproduce
Read the docs for data returned by useMutation
Expected behavior
Better description of what the property means
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
--
Tanstack Query adapter
None
TanStack Query version
v.5
TypeScript version
No response
Additional context
No response

I tried it and the data property basically contains the resolved value that mutationFn returns.
So would the correct phrasing be The last successfully resolved data for the mutationFn?

it's a typo.The last successfully resolved data for the mutation. Please make a PR to the docs.


Fabio confi help with multiple proto

My consul services is having multiple services with different protocols, some use http and other tcp.  Now I'm trying to populate the fabio routing table with all these services with the following command.
The issue is my http services are not available since fabio is being exposed as a TCP proxy at port 2302.
fabio-1.5.8-go1.10-windows_amd64.exe -registry.consul.addr 10.XXX.XXX.XX:8500 -proxy.addr :2302;proto=tcp, :/;proto=http

@magiconair Do you think it is possible to expose my TCP services at 2303 and HTTP services at 9999.
Fabio Routing table

Is this can be done in Fabio? Or do we need to configure separate fabio instances per Protocol?

If you need a TCP listener and also an HTTP listener to enable the HTTP features you will need to define multiple listeners on different ports and/or different IPs.
Example from our lab configuration:
proxy.addr = <IP_ADDRESS>:80;proto=http;rt=60s;wt=30s,\
             <IP_ADDRESS>:443;proto=https;rt=60s;wt=30s;cs=all;tlsmin=10, \
             <IP_ADDRESS>:8443;proto=tcp+sni

This binds to <IP_ADDRESS> on three different ports 80, 443, and 8443 using three different protocols for each listener.

Thanks that worked perfectly. What I have seen is we need to define TCP first and then HTTP.
Thanks again.

Thanks, @leprechau , I looked for some time for how to chain protocols. The documentation seems to omit this.

Np, I'll see about adding a more complete example to the documentation.

Agreed, adding a couple of examples would be awesome! :)

Sorry, I forgot about this ... I'll add to the docs today.

Better late than never I guess.  Sorry for the delay.

No worries :)


chore(cd): remove EOL distros

remove CentOS 7, RHEL 7 and Debian 10.
KAG-4847

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

full matrix without aws2:
https://github.com/Kong/kong/actions/runs/9806722588?pr=13342
https://github.com/Kong/kong/actions/runs/9806722613?pr=13342


Metrics for message bytes received/sent per cg (outputhost)

I moved code around a bit in 'consconnection'; if you prefer I did this in a separate change, please let me know ..

Coverage increased (+0.03%) to 69.168% when pulling 476d5c2f1d82251190195f6ad1a822f6e81edfba on metrics-output-bytes into 2e5e6dc2b02d6b30932609496f5e818b470be804 on master.


Organize 3Box Devcon/Retreat

I have a session I'm planning currently. It will be "crypto ceremonial magic" and will likely take 1-3 h

any more details on this "ceremonial crypto magic" :) ?

As any serious magic it can only be revealed it to initiates 😜 You'll get more info when needed 🙂

haha I will ponder it till then


Documentation lime_base.explain_instance_with_data incorrect

Here is the problem in question:  https://github.com/marcotcr/lime/blob/master/lime/lime_base.py#L142
It states it returns 3 values. But in actuality, it returns 4 values. I'm fairly sure it used to return 3 values, so this caused a script to break. But that is not that important to me since it's easy to fix. Still, would be nice the documentation would be updated, so others won't have to dig around in the source code to see why they get unexplained errors.

Thanks for noticing this, fixed in be535b0


JAVA-8709: Extract commons-collections4.version property to the main …

…pom.xml

retest this please

retest this please


To avoid needlessly parsing markup, component templates should be cached in some manner

This will help mitigate one of the weaknesses that Knockout suffers.  Component templates should be cached as compiled DOM structures wherever possible, so that they do not need to be repeatedly parsed from string markup.
In a large application, many templates may be in use, and so any caching mechanism will need some form of strategy for evicting stale items (say, templates which have been cached but not used for a long time).  This will prevent overuse of RAM, keeping unused DOM nodes beyond their useful lives.

The parsing of markup should also be evaluated for security concerns.


Function tags are not allowed.

:tada: This issue has been resolved in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


fix(drawer-demo): remove drawer.scss

fixes #2138

Deploy preview for pf-next ready!
Built with commit 574674646bcdde01891bad103ef1166ad5d1ff36
https://deploy-preview-2139--pf-next.netlify.com

PatternFly-Next preview: https://patternfly-next-pr-2139.surge.sh

:tada: This PR is included in version 2.25.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Frontend ci

build and lint CI set up for the frontend Closes #11

now only runs on Ubuntu and the npm packages are cached,


http://<IP_ADDRESS>/api/online sort by height

Hello,
Can you sort:
http://<IP_ADDRESS>/api/online
By height?
Cheers,

What means Hight?

http://pastebin.com/AWsCJQdw my script

+1

@alphaonex86 What is the Hight Value for?

The height is the indice of drive space shared

Thx

@alphaonex86 Will be in the next update.


town文件夹中文件是覆盖的。。。


Missing createContext

React libraries that use the new Context API will have import {createContext} from 'react', and that
doesn't work with preact-compat
Should we just re-export https://github.com/valotas/preact-context while we wait for createContext to be added to preact https://github.com/developit/preact/pull/963?

There's some funky bitmask stuff in preact-context that I'm not super sure we need in preact-compat (it doesn't seem to be part of the officially supported React API).  Perhaps we could just add something like this?
function createContext(initialValue) {
  const key = `$ctx-${++counter}`;
  class Provider {
    getChildContext() {
      let ctx = this.ctx || (this.ctx = {});
      if (ctx[key]!==this.props.value) {
        for (let i=0; i<subs.length; i++) subs[i].setState(null);
      }
      ctx[key] = this.props.value;
      return ctx;
    }
    render(props) {
      return props.children[0];
    }
  }
  class Consumer extends Component {
    componentDidMount() {
      consumers.push(this);
    }
    componentWillUnmount() {
      consumer.splice(consumers.indexOf(this), 1);
    }
    render(props, state, context) {
      return this.props.children[0](key in context ? context[key] : initialValue);
    }
  }
  return { Provider, Consumer };
}

I've been thinking a bit about this while I've been working on different projects using both React and preact and I'm not sure that I really want this feature into preact anymore.
What I really fell for with preact/React is the inspiration of functional programming and it's "simplicity", in the meaning that without side effects it's really easy to isolate, debug and understand the web clients. Compared to for instance Angular it's, in my opinion, a huge difference in the complexity. My picture is that React now is moving away from this approach and starts to implement side effects in the framework (context), and what I've heard there's more new features to come.
Of course side effects can make web apps easier to build, and also remove complexity. But I think that with the tools to create side effects developers will tend to use those as shortcuts in cases where pure functional programming can solve the same issue. The price for the developers (and the projects) is technical debt.
With the background of this I can really see a purpose with preact not following this trend. I guess the purpose of creating a preact API similar to React was easy migration between those frameworks, but now preact is pretty big and maybe this can be a start for a diverge between those two frameworks where it's not longer obvious that preact should try to follow Reacts pattern.
What do you think?

@kontrollanten side-effects is not the only use for this - I'm using it simply as a means of sharing state between related components, e.g. a <TabList> with <Tab> panels, where the panels can share the selected tab state, which is provided by the parent tab-list. (even works fine for nested tabs.)

I guess the purpose of creating a preact API similar to React was easy migration between those frameworks, but now preact is pretty big and maybe this can be a start for a diverge between those two frameworks where it's not longer obvious that preact should try to follow Reacts pattern.

Isn't that why we have preact-compat?
@developit most likely we're talking about an addition to that, not an addition to the framework itself?
I think it's very important to have that feature in preact-compat - the whole point of that package existing, is to provide API-compatible React idioms, and I think there's no doubt the new context API is already a popular idiom in React?

yeah, the more I look at preact, the more I think preact should just do its own thing.
Even react regrets the move from createClass to es6 classes, so they are not infallible.
I would love to see preact do its own thing and continue with ideas like having props/state as params in render and simplifying children.
I want preact to be different enough that we won't expect compat at all

@kontrollanten side-effects is not the only use for this - I'm using it simply as a means of sharing state between related components, e.g. a  with  panels, where the panels can share the selected tab state, which is provided by the parent tab-list. (even works fine for nested tabs.)

That's true, but I think my reasons applies for those cases also; it's no longer functional and my opinion is that this behaviour will in many cases increase application complexity.

Isn't that why we have preact-compat?

I was mainly thinking about implementing context API into preact, maybe I should've created this discussion on preact project but I guess that a decision like this will affect both preact and preact-compat.
One way could be to keep preact-compat up to date with latest React features and keep preact slimmed. I'd love a clear distinguish between those projects; where preact strives for a petite, functional rendering framework and preact-compat makes preact easier to use for those who needs React's features, being able to import them one by one.

For those finding this issue, please use styled-components@3 for now.

@developit I think that we should let the bundlers with the tree-shake functionality to save more bytes when removing createContext and other methods and focus on making this package simple and easy to use.
Right now I'm using the following "pollyfill" for React 16:
$ npm i create-react-context create-react-ref

// preact-compat.js
import React from 'preact-compat';

export default React;
export * from 'preact-compat';

const createContext = require('create-react-context');
const forwardRef = require('create-react-ref/lib/forwardRef');
const createRef = require('create-react-ref/lib/createRef');

export { createContext };

React.createContext = createContext;
React.forwardRef = forwardRef;
React.createRef = createRef;

Then, on webpack:
  resolve: {
    alias: {
      react: path.join(__dirname, 'preact-compat.js'),
      'react-dom': path.join(__dirname, 'preact-compat.js'),
    },
  }

createContext is available in Preact X. An alpha is already out on npm. Even more exciting is that we moved compat into the core repo. Changing preact-compat to preact/compat in your require or import statements is all that's needed to be able to use createContext.

Can we use the styled component 4.0.0 in preact?
@FYI,
it working perfectly on 3.4.9.
can anyone suggest me the approach?

For styled-components V4 to work with Preact you need to upgrade to the upcoming Preact version (currently in the release candidate phase).

Is there anyway achieve in preat 8 version?

No.


Fixups for running in switch mode

I needed to make the following changes to get a VPN up and running in switch mode

Actually set the mode in tinc.conf
Skip errors on the initial check for an RSA key already being present. For leaf nodes the host file will not have been created yet, so the awk command fails. There may be a better way to accomplish this.

FYI, for context, I didn't use the switch mode for a while.
Maybe it would be good to have this covered by molecule :)

@leigh-thg would you mind giving a look to a PR that rewrites a bunch of this?

As you seem to care about this role, I spent some time refactoring it in https://github.com/evrardjp/ansible-tinc/pull/59 .
github actions can now test it properly.
It would be great if you could rebase your work on top of this.
As it will be conflicting, just keep the template change (good catch btw!), and I would love to see a new molecule scenario for switch. If you add it into github actions, it's even better, as we can all see it working.
Thank you in advance.

I have updated the role to make it simpler, and increase the test coverage. Can you test if the current role works better for you? If there is something missing, please feel free to update this PR.

Hi,
Apologies for not getting back to this quicker. I can confirm with #69 that things work as expected.
Many thanks! Leigh


net: add back Buffers implementation

This PR is to add back the Buffers implementation originally added to the main repo in https://github.com/tinygo-org/net/commit/c954718d79c8ad220f30fe5d2cc67fab185a2c66 which got lost along the way to the switchover to this package.
Should fix https://github.com/tinygo-org/tinygo/issues/4166 and other similar issues.

Thanks for quick review @bgould :heart:


docs(toh-3/dart): copyedits and new snake_case glossary entry

Copyedits made to glossary as well.
Note that "Scoped Package" has been removed from the Dart glossary.

Contributing to #1628.

What is the state of this? It is difficult for me to review when there is a mix of Dart and TS changes.
The TS changes LGTM.  Maybe it is better if Kathy merges this one.

Sorry, the TS-side change was for the glossary: I originally needed to add a new #docregion tag to use in the Dart-side glossary file. While in there I made some minor copy edits related to the "*-case" entries.
@kwalrath @thso : ready for your review.

Taking a look now...

LGTM. Merging now.


[MINOR][SQL]remove unuse import class

What changes were proposed in this pull request?
this PR describe remove the import class that are unused.
How was this patch tested?
N/A

Can one of the admins verify this patch?

On the one hand, we don't normally just make a change to remove unused imports. But it's a good idea once in a while to clean up. Would you actually try to find all of them? at least, in several whole modules rather than part of one.

ok, i will do it.

Jenkins, test this please.

Test build #3913 has started for PR 19131 at commit e7ce4e5.

Test build #3913 has finished for PR 19131 at commit e7ce4e5.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

What about other components, here you only fixed sql and core module.

wait, I'm still looking for it.

Personally I'm not fond of such fix, this will break lots of existing PRs and force them to rebase again. Usually this could be addressed when fixing other issues. IMHO I don't encourage such PRs.

I'm neutral. Once in a while a cleanup seems helpful, not all the time. I am a little more receptive to people without much contribution history. But yeah I do not want to review things like this regularly. We have a lot of really minor PRs coming through

@srowen, @jerryshao several other components, Include spark streaming, launcher,graphx,core,mllib,mllib-local， except for their tests.
thanks.

Jenkins, test this please.

retest this please

ok to test

Test build #81541 has started for PR 19131 at commit 648ed11.

Test build #81541 has finished for PR 19131 at commit 648ed11.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81541/
Test FAILed.

Test build #81553 has started for PR 19131 at commit bdc1bcf.

Test build #81553 has finished for PR 19131 at commit bdc1bcf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81553/
Test FAILed.

Merged build finished. Test FAILed.

Test build #81563 has started for PR 19131 at commit ee0d848.

Test build #81563 has finished for PR 19131 at commit ee0d848.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

A check for unused imports should be added to scalastyle to prevent these from creeping back in.  If this PR was accompanied with that check (failing before, now passing) I think the merge conflicts are worth it to permanently fix the problem.

I didn't think scalastyle could do that? didn't see a rule at http://www.scalastyle.org/rules-dev.html

I'm going to merge it as a cleanup but yeah let's not do these often.
I would favor adding a style check for this if one can be found, but don't see it in scalastyle.


(#365) Update top banner text

Description Of Changes
This updates the top banner to point to the upcoming webinar on
Chocolatey Central Management.
Motivation and Context
The webinar is coming up soon and we want everyone to know about it.
Testing

Run this PR on chocolatey.org: https://github.com/chocolatey/chocolatey.org/pull/297
Ensure the top banner is shown and looks similar to the below image.

Operating Systems Testing
n/a
Change Types Made

[ ] Bug fix (non-breaking change).
[x] Feature / Enhancement (non-breaking change).
[ ] Breaking change (fix or feature that could cause existing functionality to change).
[ ] Documentation changes.
[ ] PowerShell code changes.

Change Checklist

[ ] Requires a change to the documentation.
[ ] Documentation has been updated.
[ ] Tests to cover my changes, have been added.
[ ] All new and existing tests passed?
[ ] PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

https://github.com/chocolatey/choco-theme/issues/365
https://github.com/chocolatey/chocolatey.org/issues/296
https://github.com/chocolatey/home/issues/291
https://gitlab.com/chocolatey/community-infrastructure/community.chocolatey.org/-/issues/1242
https://github.com/chocolatey/docs/issues/929
https://github.com/chocolatey/blog/issues/256

Putting this into draft to include another item before release.


kernel: userspace: API to check the permissions.

A thread can now check if it has access to a specific k_object.
This can also be called from userspace. If called from the user
thread it needs to have access to the both the k_object and the
thread id.
Signed-off-by: Adithya Baglody<EMAIL_ADDRESS>

@AdithyaBaglody any update on this one?

I want to get the test cases of userspace merged first. I already have a patch on top of mem_protect for it so i don't want to add it obj_validation . Hence I haven't got around to getting this done yet.

@lpereira has a good point.
What is the use-case for this??
For example, if the thread doesn't have permission on the k object being checked, the handler will fail and the thread will be KILLED.
I don't see the point either.
NACK for now.

@andrewboie is this still relevant? Should we close this?

I don't think this is a good idea for the reasons stated.  Since nobody brought any counter argument, I'm just closing this issue; feel free to reopen to restart the discussion.


Using the ELECTRUM_NETWORK call instead.

Using the ELECTRUM_NETWORK environmental variable nsterad of the TESTNET variable. As it works better in avoiding docker-compose errors.

/rebase

/rebase

/rebase


Potential OIT optimization

Consider using OES_draw_buffers_indexed extension on supported platforms to reduce the number of render passes.

Sounds like a pretty cool extension indeed :-)
@CraigFeldspar do you think it would be simple to add ? (assuming support in the engine)
@Popov72 do you know if the same is available in WebGPU ?

Yes in WebGPU you can have these settings per color target:
https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/LibDeclarations/webgpu.d.ts#L519-L528

See #13003 which would require the support of the same extension.


mx.sym.SVMOutput breaks LR toy example

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Ubuntu 16.04.2 LTS
Installed with pip according to http://mxnet.io/get_started/install.html
Error Message:
Please paste the full error message, including stack trace.
(64700, 300) (64700, 1) ([(1024, 300), (1, 300), (1,), (1024,)], [(1024, 1)], []) infer_shape error. Arguments:   target: (1024, 1)   data: (1024, 300) Traceback (most recent call last):   File "svmexample.py", line 33, in <module>     label_shapes= [mx.io.DataDesc(name='target', shape=(batch_size, 1), layout='NC')])   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/module/module.py", line 388, in bind     state_names=self._state_names)   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/module/executor_group.py", line 205, in __init__     self.bind_exec(data_shapes, label_shapes, shared_group)   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/module/executor_group.py", line 301, in bind_exec     shared_group))   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/module/executor_group.py", line 548, in _bind_ith_exec     arg_shapes, _, aux_shapes = self.symbol.infer_shape(**input_shapes)   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/symbol.py", line 747, in infer_shape     res = self._infer_shape_impl(False, *args, **kwargs)   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/symbol.py", line 871, in _infer_shape_impl     ctypes.byref(complete)))   File "/home/martin/.local/lib/python3.5/site-packages/mxnet/base.py", line 84, in check_call     raise MXNetError(py_str(_LIB.MXGetLastError())) mxnet.base.MXNetError: Error in operator svmoutput0: Shape inconsistent, Provided=(1024,1), inferred shape=(1024,)
Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
import mxnet as mx
import mxnet.ndarray as nd
import numpy as np
import logging
import sys
import os
logging.basicConfig(stream=sys.stdout, level=logging.DEBUG)  # Config the logging
np.random.seed(777)
xy = np.loadtxt(os.path.join('w8a.csv'), delimiter=',', dtype=np.float32)
x_data = xy[:, 0:-1]
y_data = xy[:, [-1]]
print(x_data.shape, y_data.shape)
sample_num = x_data.shape[0]
dimension = x_data.shape[1]
batch_size = 1024
data = mx.sym.Variable("data")
target = mx.sym.Variable("target")
fc = mx.sym.FullyConnected(data=data, num_hidden=1, name='fc')
pred = mx.sym.SVMOutput(data=fc, label=target)
print(pred.infer_shape(data=(batch_size, dimension)))
net = mx.mod.Module(symbol=pred, data_names=['data'], label_names=['target'], context=mx.cpu(0))
net.bind(data_shapes = [mx.io.DataDesc(name='data', shape=(batch_size, dimension), layout='NC')],
label_shapes= [mx.io.DataDesc(name='target', shape=(batch_size, 1), layout='NC')])
net.init_params(initializer=mx.init.Normal(sigma=0.01))
net.init_optimizer(optimizer='sgd', optimizer_params={'learning_rate': 1E-2, 'momentum': 0.9})
train_iter = mx.io.NDArrayIter(x_data, y_data, batch_size, shuffle=False, label_name='target')
feval=lambda labels, pred : ((pred > 0.5) == labels).mean()
metric = mx.metric.CustomMetric(feval=feval, name="acc")
net.fit(train_data=train_iter, eval_metric=metric, num_epoch=1000)
Hello,
I was able to successfully run the code above using LogisticRegressionOutput, however when I change the output to SVMOutput using the same configuration I get the Inconsistent shape error shown above. Printing the inferred shape is the same in both cases of SVM and LR, however SVM complains and throws an error. I believe the error is thrown by Symbol.py after calling svm_output-inl.h. I compared the implementations between SVM and LR, and it looks like the SVM implementation has an extra check that throws the error. Here is the code for LR: (starts at line 48 in regression_output-inl.g)
CHECK_EQ(in_data.size(), 2U) << "RegressionOutputOp Input: [data, label]";     CHECK_EQ(out_data.size(), 1U) << "RegressionOutputOp Output: [output]";     Stream<xpu> *s = ctx.get_stream<xpu>();     Tensor<xpu, 2> data = in_data[reg_enum::kData].FlatTo2D<xpu, real_t>(s);     Tensor<xpu, 2> out = out_data[reg_enum::kOut].FlatTo2D<xpu, real_t>(s);     Assign(out, req[reg_enum::kOut], F<ForwardOp>(data));
While the SVM implementation looks like this:
CHECK_EQ(in_data.size(), 2U) << "Expecting [data, label]";     CHECK_EQ(out_data.size(), 1U) << "Expecting [output]";     CHECK_EQ(req.size(), 1U) << "Expecting output.size() == req.size()";     Stream<xpu> *s = ctx.get_stream<xpu>();     Tensor<xpu, 2, DType> data = in_data[svm_enum::kData].FlatTo2D<xpu, DType>(s);     Tensor<xpu, 2, DType> out = out_data[svm_enum::kOut].FlatTo2D<xpu, DType>(s);     Assign(out, req[svm_enum::kOut], F<mshadow_op::identity>(data));
My question is, why does the SVMOutput and LogisticRegressionOutput differ in the inferred shape and is there a solution to run this example using SVMOutput?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


positions in decimals causes blurry popover contents

sometimes, the popover position gets set in decimals of pixels. this causes the popover to be blurry on chrome browser (i did not check other browsers).
image attached to demonstrate.

Facing the same issue.
Will it be possible to round off the translateX and translateY values before applying transform?


export ACK_GENERATE_OLM env var for olm-bundle

Description of changes:

ole-bundle creation requires ACK_GENERATE_OLM variable in sub shell, so exporting it now.
Reproduced locally and exporting variable fixes the issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merging this simple PR to retry ole-bundle generation for ecr-v0.0.11
Please leave comment and I will address in following PR


Fix --wait-interval pg:wait flag

Fixes #1434.

this would leave it as 0 if the wait interval wasn't specified. Closing in favor of #1436

Ah right; I forgot about the nil case. Good catch! :)


Add  composite disposable ext

Extension function to add disposable into composite disposable

This is already available in RxKotlin
And since Rx kotlin is exposed through API
implementation (api "io.reactivex.rxjava3:rxkotlin:$rx") it's already available

A better idea would be an extension function for a list/vararg of disposable instead of one, iterate them as sequence and add them to the composite disposable

Since there's no activity on this pr I'll close it


How to use resource string within an Electron app

Could you please explain how to use a resource-string within an Electron app?
Thanks in advance!

You can use modules like electron-builder.


Not working/ strong enough

i tried on my ip and nothing changed

Did you use 2.4Ghz or 5Ghz?

Did you use 2.4Ghz or 5Ghz?

2.4Ghz

Did target is 2.4Ghz/5Ghz/lan?
If host is 5Ghz/lan and target is 2.4Ghz, that will be perfect.
Also my laptop is broke right now, if I come back I gonna try development to make it better.

I come back again and seems like it code is kinda old, i will push new one soon if i have some free time.

How can I download Ddos apk🧐


Question: About HIPAA Compliance

Is Uploadthing HIPAA compliant? Is there potential to sign a BAA to certify HIPAA Compliance?
I'm building a health-fin-tech app that needs the ability to upload/ingest PII and PHI . If this uses S3 in the background then I think it should be possible bc AWS signs BAAs with companies to certify. I'll be building out the upload functionality for my app soon and was starting to research solutions, I'd much rather use Uploadthing than S3 directly.

Uploadthing is not HIPAA compliant at this time. It is something that we may consider for the future, but given our current size, the required effort is currently to great for us to be able to justify.


Schematics does not prompt for input from user in git bash.

🐞 Bug report
Command (mark with an x)

[x ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[x] add for custom Schematics
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
No
 No
 Yes, the previous version in which this bug was not present was: ....
Description
Either it is custom Schematics or angular Schematics, when I try to run this in git bash it does not prompt for values and runs the whole workflow with default values and if no default value is set it either fail if require flag is true otherwise set the empty value for the input.
even though somebody previously raised this issue
https://github.com/angular/angular-cli/issues/14938
But it was marked closed
I see this as a bug because it behaves differently in a different terminal. the behaviour should be the same across all the terminal. otherwise, some information must be given BCS of which it is happening.
One observation if you create schematics and test it locally by
npm link path to schematics
and then try to run the schematics with command
schematics path:schematic-name
then it works in git bash as well.
 A clear and concise description of the problem...
🔬 Minimal Reproduction

ng new appName
It works fine in command prompt
on mac terminal
vs code terminal
but with git bash it causes problem it do not ask for user input and run the whole workflow with default values
🔥 Exception or Error

🌍 Your Environment

Angular CLI: 9.0.6
Node: 12.16.1
OS: win32 x64
Angular:
...
Ivy Workspace:
Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.900.6
@angular-devkit/core         9.0.6
@angular-devkit/schematics   9.0.6
@schematics/angular          9.0.6
@schematics/update           0.900.6
rxjs                         6.5.3

Anything else relevant?

Git Bash is a non-interactive terminal which means our prompt library doesn't work with it.
See: SBoudrias/Inquirer.js#570

Why does it work when i run it with schematics path:schematic-name @alan-agius4

That is an interesting deal.

That is an interesting detail. Will need to investigate this a bit more.

What version of windows is being used?

What version of Windows is being used?

Its window 7 enterprise

@alan-agius4 you can have a look at the screenshot attached

In the Schematics CLI, the prompts are being displayed because unlike in the Angular CLI we are not checking whether the terminal is TTY.
Schematics CLI
https://github.com/angular/angular-cli/blob/111e9cc38372620656685752a392b46fa1b68336/packages/angular_devkit/schematics_cli/bin/schematics.ts#L272-L273
NG CLI
https://github.com/angular/angular-cli/blob/f4127b5b4356b7966a058b118335b7857922d613/packages/angular/cli/models/schematic-command.ts#L321-L322.
Can you try to run  node --eval "console.log({stdin: process.stdin.isTTY, stdout: process.stdout.isTTY})"?

Here is the output @alan-agius4

Hi @darpankumar, myself and @clydin had a chat around the issue that you are experiencing and unfortunately this is not something that we can easily replicate as this would require some debugging on your system.
I am going to leave the issue open for a couple of days maybe someone else can replicate this debug and be able to find the root cause of the problem.

Hello,
I have the same problem in git bash on Windows 10 Enterprise Edition, with a custom schematics I have.
There is an interesting behavior I have seen.
If I run yarn ng generate @my/generator:component the promt does  not appear and the schema validation fails on the properties that should have been completed in the prompt.
If I run  node ./node_modules/@angular/cli/bin/ng generate @my/generator:component the promt appears and everything works as expected.

This is working as expected.
See: https://github.com/nodejs/node/issues/39673


how to run .flow on windows

I followed the steps at https://maestro.mobile.dev/getting-started/installing-maestro/windows
but I connected my android device with use debugging, the maestro is not finding my device,I think it is the same when I run the android emulator on windows.
the issue I cannot install android studio or run android emulator on Linux subsystem
please help

Hi @periva101
I came across the same issue and please check if this discussion helps you.
https://stackoverflow.com/questions/62145379/how-to-connect-android-studio-running-inside-wsl2-with-connected-devices-or-andr/63530375#63530375

Thanks for taking the time to raise this issue! There has been a lot of improvements and fixes to our Windows installation documentation since this was raised so we’ll go ahead and close this one out as part of an issue cleanup - if you still experience issues after upgrading to the latest version of Maestro, please open a new issue with reproduction steps. Thanks again for using maestro!


fixed the dateTooltip test where compared date were not the same

Proposed Changes
the date of reference was few minutes late from the date in the test since they were not made in the same scope. Fixed it
Potential Breaking Changes

Acceptance Criteria

[x ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1380 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   99.22%   99.22%
=======================================
  Files         474      474
  Lines        9851     9851
  Branches     2268     2268
=======================================
  Hits         9775     9775
  Misses         76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577bbe6...85da951. Read the comment docs.


PHP 8 new with arbitrary expressions leads to a syntax issue

PHPMD version: 2.12.0
PHP Version: 8.0.2
Installation type: composer
Operating System / Distribution & Version: Not relevant

Current Behavior
This (valid) code:
$myObject = new (SomeArbitraryCode::class . 'loremIpsum' . trim(' Hello '))($arg1, $arg2);

Leads to the following error:
Unexpected token: (, line: xx, col: xx, file: xxxxxxxxxxx.php.
#0 xxxxxxxxxxx\vendor\pdepend\pdepend\src\main\php\PDepend\Source\Language\PHP\AbstractPHPParser.php(7844): PDepend\Source\Parser\UnexpectedTokenException->__construct(Object(PDepend\Source\Tokenizer\Token), Object(PDepend\Source\AST\ASTCompilationUnit)
)

Expected Behavior
No error, dynamic class instantiation has been introduced as of PHP 8:
https://www.php.net/manual/en/language.oop5.basic.php
Steps To Reproduce:
Just analyses the piece of code above.
Checks before submitting

[x] Be sure that there isn't already an issue about this. See: Issues list
[x] Be sure that there isn't already a pull request about this. See: Pull requests
[x] I have added every step to reproduce the bug.
[x] If possible I added relevant code examples.
[x] This issue is about 1 bug and nothing more.
[x] The issue has a descriptive title. For example:  "JSON rendering failed on Windows for filenames with space".

@Geolim4 Thanks for your report!
If I check the error this is in fact an error in PDepend. That is why I have created a new issue: https://github.com/pdepend/pdepend/issues/601

Thank you @tvbeek !


Lab 5 UK/US mixed usage ("tokenization" / "tokenisation")

In the introductory paragraph of the lab, "tokenisation" is used once whereas "tokenization" is used everywhere else (4 occurrences).

Yep, fixed this. Thanks. 1 point


Deprecate undocumented propagate_traces option

The option is not documented and it is True by default. We should deprecated it and remove in the next major.
This option was later superseded by trace_propagation_targets.

Hi @antonpirker. I see there is already a PR to delete the flag, but should we start triggering a DeprecationWarning? Could I create a pull request for that? I haven't found how to do a deprecation on the Sentry contribution guidelines. Thank you!

@mgaligniana we usually just use DeprecationWarning directly, along with a message stating that the option is deprecated. We also need to make sure we remove any usages of the deprecated item from the SDK codebase, to avoid triggering the warning ourselves.

@mgaligniana we usually just use DeprecationWarning directly, along with a message stating that the option is deprecated. We also need to make sure we remove any usages of the deprecated item from the SDK codebase, to avoid triggering the warning ourselves.

Thank you @szokeasaurusrex! So if I understood well the only thing missing here is add the warning in the current pull request.
I was just trying to contribute! If there is anything I can contribute, let me know! Thanks and have a great new year! 🌟


cannot list local dir contents because ...known_hosts does not exist

(similar issue to #347)
Suppose you're using the library for the first time. You have no ~/.ssh/known_hosts on your system, nor do you have a ~/.ssh. Let's say you write the following Java code to list the directory contents of the current directory. You're passing file:$PWD as an argument to DirectoryListing, as follows: java -cp 'build/libs/Xenon-examples-all.jar' nl.esciencecenter.xenon.examples.files.DirectoryListing file:$PWD
then that won't work. The INFO level output is here:
time   : 11:57:02.959 (+242 ms)
thread : main
level  : ERROR
class  : nl.esciencecenter.xenon.examples.files.DirectoryListing:110
message: DirectoryListing example failed: ssh adaptor: Could not set known_hosts file

nl.esciencecenter.xenon.XenonException: ssh adaptor: Could not set known_hosts file
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.setKnownHostsFile(SshAdaptor.java:218)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.<init>(SshAdaptor.java:171)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.<init>(SshAdaptor.java:156)
	at nl.esciencecenter.xenon.engine.XenonEngine.loadAdaptors(XenonEngine.java:180)
	at nl.esciencecenter.xenon.engine.XenonEngine.<init>(XenonEngine.java:167)
	at nl.esciencecenter.xenon.engine.XenonEngine.newXenon(XenonEngine.java:90)
	at nl.esciencecenter.xenon.XenonFactory.newXenon(XenonFactory.java:57)
	at nl.esciencecenter.xenon.examples.files.DirectoryListing.main(DirectoryListing.java:61)
Caused by: com.jcraft.jsch.JSchException: java.io.FileNotFoundException: /home/daisycutter/.ssh/known_hosts (No such file or directory)
	at com.jcraft.jsch.KnownHosts.setKnownHosts(KnownHosts.java:57)
	at com.jcraft.jsch.JSch.setKnownHosts(JSch.java:317)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.setKnownHostsFile(SshAdaptor.java:216)
	... 7 more
Caused by: java.io.FileNotFoundException: /home/daisycutter/.ssh/known_hosts (No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:146)
	at java.io.FileInputStream.<init>(FileInputStream.java:101)
	at com.jcraft.jsch.KnownHosts.setKnownHosts(KnownHosts.java:53)
	... 9 more

However, if you first do
cd ~
mkdir .ssh
touch .ssh/known_hosts

then it does work.
It is counter-intuitive that you need to set up known_hosts, or SSH for that matter, if all you want to do is look at the current directory.

This should be fixed with pull requests #350 and #353, could you check?

Here's what I did:
# clear any old cached version of xenon and its dependencies (and gradle itself)
rm -rf ~/.gradle/

# clear ~/.ssh
rm -rf ~/.ssh

# clone the examples repo
git clone https://github.com/NLeSC/Xenon-examples.git xenon-examples2

# cd into the new dire
cd xenon-examples2

# compile stuff and make a fat jar
./gradlew

# (wait for downloads to finish)

# make the command line call to DirectoryListing using the local file adaptor (``file``)
java -cp 'build/libs/Xenon-examples-all.jar' nl.esciencecenter.xenon.examples.files.DirectoryListing file:$PWD

et voila the output
time   : 14:54:45.578 (+251 ms)
thread : main
level  : ERROR
class  : nl.esciencecenter.xenon.examples.files.DirectoryListing:110
message: DirectoryListing example failed: ssh adaptor: Could not set known_hosts file

nl.esciencecenter.xenon.XenonException: ssh adaptor: Could not set known_hosts file
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.setKnownHostsFile(SshAdaptor.java:218)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.<init>(SshAdaptor.java:171)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.<init>(SshAdaptor.java:156)
	at nl.esciencecenter.xenon.engine.XenonEngine.loadAdaptors(XenonEngine.java:180)
	at nl.esciencecenter.xenon.engine.XenonEngine.<init>(XenonEngine.java:167)
	at nl.esciencecenter.xenon.engine.XenonEngine.newXenon(XenonEngine.java:90)
	at nl.esciencecenter.xenon.XenonFactory.newXenon(XenonFactory.java:57)
	at nl.esciencecenter.xenon.examples.files.DirectoryListing.main(DirectoryListing.java:61)
Caused by: com.jcraft.jsch.JSchException: java.io.FileNotFoundException: /home/daisycutter/.ssh/known_hosts (No such file or directory)
	at com.jcraft.jsch.KnownHosts.setKnownHosts(KnownHosts.java:57)
	at com.jcraft.jsch.JSch.setKnownHosts(JSch.java:317)
	at nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor.setKnownHostsFile(SshAdaptor.java:216)
	... 7 more
Caused by: java.io.FileNotFoundException: /home/daisycutter/.ssh/known_hosts (No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:146)
	at java.io.FileInputStream.<init>(FileInputStream.java:101)
	at com.jcraft.jsch.KnownHosts.setKnownHosts(KnownHosts.java:53)
	... 9 more

and now for the magic solution
mkdir ~/.ssh
touch ~/.ssh/known_hosts
# same call to java as before:
java -cp 'build/libs/Xenon-examples-all.jar' nl.esciencecenter.xenon.examples.files.DirectoryListing file:$PWD

and the output:
time   : 14:58:18.140 (+253 ms)
thread : main
level  : WARN
class  : nl.esciencecenter.xenon.adaptors.ssh.SshAdaptor:242
message: OpenSSH config file cannot be read.

time   : 14:58:18.154 (+267 ms)
thread : main
level  : INFO
class  : nl.esciencecenter.xenon.engine.XenonEngine:169
message: Xenon engine initialized with adaptors: [Adaptor [name=local], Adaptor [name=ssh], Adaptor [name=ftp], Adaptor [name=gridengine], Adaptor [name=slurm], Adaptor [name=torque]]

time   : 14:58:18.162 (+275 ms)
thread : main
level  : INFO
class  : nl.esciencecenter.xenon.examples.files.DirectoryListing:93
message: Directory file:/home/daisycutter/github/nlesc/xenon-examples2 exists and contains the following:
         .travis-ssh.sh
         run-examples.sh
         .gitignore
         doc
         build
         .git
         gradlew.bat
         gradlew
         .travis.yml
         gradle
         build.gradle
         LICENSE
         src
         .gradle
         README.md

@blootsvoets If you go through these steps, does it work on your system?

Aha so after f2f with @blootsvoets it turns out it was due to Xenon dependency not (automatically) being the latest version.

For the record, here is the workaround I'm using. I create a link Xenon-1.1.0-beta1.jar next to Xenon-examples-all.jar in Xenon-examples/build/libs/. The link points to the local copy of the Xenon jar, which I made by going to the Xenon project and running ./gradlew assemble. I then added the (linked) jar to the classpath before the fat jar, as follows:
java -cp 'build/libs/xenon-1.1.0-beta1.jar:build/libs/Xenon-examples-all.jar' nl.esciencecenter.xenon.examples.files.DirectoryListing file:$PWD

And then it works, yay!


⚠ Fortnite has degraded performance

In b122fe1, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1620 ms

Resolved: Fortnite performance has improved in c51aa04.


Remove binder links from docs

Fixes #53
Changes made in this Pull Request:

Removes binder links from docs and points out Google Colab links instead.

PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG updated?
[ ] Issue raised/referenced?

Codecov Report

Merging #74 (66e68f2) into main (aa41fcf) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files


Examples

The component looks like it should work.  We need to add examples.

I have one requirement - that we don't add any dependencies to package.json. I like the idea behind this: https://github.com/bvaughn/react-virtualized/tree/master/playground

Maybe we should close this issue.  I think unit tests will be sufficient.
Example code can be in the readme or wiki, IMO.

We definitely need an example. I'll take that on

Sounds like a plan.
The thing is, you don't want to add any dependencies (but maybe you can have a package.json in the examples (in each if you have multiple).
Plus, I don't know how someone is going to notice the example is actually working :)


UX: implement rotating keys api in ux-backend server

Implement rotating keys by deleting the secret containing onboarding public key. Creation of new private & public key pair when public key is deleted is already implemented in #2385.
The expectation is this new api endpoint be called via CLI or UI and get the existing private & public key pairs rotated if both the keys are being managed by us.
Part of [RHSTOR-5489]

/hold
testing in progress.

/retest-required

/unhold
tested, working as expected
# ===== Existing
# ko get secret onboarding-private-key -ojsonpath='{.metadata.creationTimestamp}'
2024-02-28T05:20:07Z

# ko get secret onboarding-ticket-key -ojsonpath='{.metadata.creationTimestamp}'
2024-02-28T05:20:07Z

# ===== Invoked rotation
# ko exec -it deploy/ocs-operator -- bash -c 'curl -H "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)"  https://ux-backend-proxy:8888/rotate-keys -k -X POST -s'
Successfully rotated keys

# ko logs ux-backend-server-5b7478645c-gbwpn -f
I0228 05:53:09.151963       1 handler.go:34] POST method on /rotate-keys endpoint is invoked
I0228 05:53:09.166107       1 handler.go:65] onboarding keys are rotated successfully

# ===== Rotated
# ko get secret onboarding-private-key -ojsonpath='{.metadata.creationTimestamp}'
2024-02-28T05:53:26Z

# ko get secret onboarding-ticket-key -ojsonpath='{.metadata.creationTimestamp}'
2024-02-28T05:53:26Z

it would be good to update the commit message

done.

/lgtm

/retest


Explicitly require a C++11 capable toolchain when building Kyua

While it's true that C++11 isn't strictly required with ATF/Kyua, in order to move forward and leverage new C++ language features, the project needs to require newer C++ standards.
This will also allow Kyua to shed backwards compatibility code for std::regex, std::shared_ptr, etc, further streamlining the project.

Have you seen utils::text::regex?
Not saying requiring C++ is a bad idea (in fact, I wanted to do that at some point and then clean up things like utils/shared_ptr.hpp), but I have to question why this would be a prerequisite for googletest support.

Have you seen utils::text::regex?
Not saying requiring C++ is a bad idea (in fact, I wanted to do that at some point and then clean up things like utils/shared_ptr.hpp), but I have to question why this would be a prerequisite for googletest support.

I hadn't seen that. I was trying to stick to what was provided upstream and I completely missed that... hmmm.

Do we really need three commits to add this? Looks like a single one would be sufficient...

I was trying to break down the work in terms of individual commits (out of habit), but I can squash them together.

Breaking stuff into individual, smaller commits, is great -- but stuff should be grouped semantically. And in this case, the three modified files were changed to achieve the same thing. Thanks for merging them.

By the way, for these little nits, I could just pull your commit, squash the minor edits myself, and then merge the change. I think this would mess the GitHub UI in that it wouldn't show the PR as merged, but if you are OK with it, I can do that to avoid roundtrips.

By the way, for these little nits, I could just pull your commit, squash the minor edits myself, and then merge the change. I think this would mess the GitHub UI in that it wouldn't show the PR as merged, but if you are OK with it, I can do that to avoid roundtrips.

I'm totally fine with that. It should show the merged commits as a joint effort with us both contributing :).

@jmmv: could you please merge this change?

Ugh, the implementations for std::regex in both libc++ and libstdc++ are buggy, so the original reason for moving to C++11 is diminished a bit. However, it makes sense to move forward with this change.

Yep, I think it makes sense to move forward too. It's 2019.
Interested in killing shared_ptr next and thus putting this to use? :)

Yep, I think it makes sense to move forward too. It's 2019.
Interested in killing shared_ptr next and thus putting this to use? :)

Will do :).