It would be helpful if Safari 11 data could be added

It would be helpful if Safari 11 data could be added, either based on the most recent beta, or soon when it actually ships.

Specifically, this would make the "failure to ship" data more useful since Safari 11 likely ships many of the mentioned APIs.

We're using BrowserStack to collect the data, do you know if new releases normally show up there quickly? @mdittmer are there any cases where you've done ad-hoc runs on physical machines to get new data in there? Is there any issue for automatically finding and running new releases that show up in BrowserStack, or does that already happen?

Yeah definitely we need to get Safari 11 data added ASAP.  It seems like it can sometimes take awhile for Browserstack to update (they have a STP build under El Capitan, but it's an old Safari 9 STP!).  Perhaps it's worth doing a one-off manual run on one of our macs if it's not too difficult and won't cause problems down the line when we re-generate data from Browserstack?

Per https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html it looks like it's already released. I agree that doing a one-off manual run just to get the data in would be great!

I tried installing the latest Safari Technology Preview for MacOS 10.12.6, but I got this:
/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview
2017-09-21 15:57:52.214 Safari Technology Preview[1235:9010] +[SimServiceContext sharedServiceContextForDeveloperDir:error:]: unrecognized selector sent to class 0x10aa908c8
2017-09-21 15:57:52.226 Safari Technology Preview[1235:9010] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[SimServiceContext sharedServiceContextForDeveloperDir:error:]: unrecognized selector sent to class 0x10aa908c8'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fffa43232cb __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00007fffb913348d objc_exception_throw + 48
	2   CoreFoundation                      0x00007fffa43a4e44 +[NSObject(NSObject) doesNotRecognizeSelector:] + 132
	3   CoreFoundation                      0x00007fffa4295755 ___forwarding___ + 1061
	4   CoreFoundation                      0x00007fffa42952a8 _CF_forwarding_prep_0 + 120
	5   WebInspector                        0x000000010414adb4 -[RWIManager init] + 671
	6   WebInspector                        0x000000010414aae9 +[RWIManager sharedManager] + 255
	7   Safari                              0x00000001020817bd -[DevelopMenuController installMenu] + 2654
	8   Safari                              0x0000000101e747da -[AppController awakeFromNib] + 1827
	9   CoreFoundation                      0x00007fffa429bff9 -[NSSet makeObjectsPerformSelector:] + 217
	10  AppKit                              0x00007fffa1d608bb -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 1442
	11  AppKit                              0x00007fffa1d57af0 loadNib + 375
	12  AppKit                              0x00007fffa1d5703a +[NSBundle(NSNibLoading) _loadNibFile:nameTable:options:withZone:ownerBundle:] + 308
	13  AppKit                              0x00007fffa1d56df2 -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 201
	14  AppKit                              0x00007fffa1d56baf +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 414
	15  AppKit                              0x00007fffa1d51b2b NSApplicationMain + 498
	16  libdyld.dylib                       0x00007fffb9a19235 start + 1
	17  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
zsh: abort

😿

Did you use https://secure-appldnld.apple.com/STP/091-33444-20170919-603056FA-9D74-11E7-929D-F7CEFCD6B433/SafariTechnologyPreview.dmg ? You may be using the High Sierra STP build on Sierra.

Got this link from:
https://developer.apple.com/safari/download/
"Safari Technology Preview for macOS Sierra" link since you're using 10.12, not 10.13.

Also note that this bug is about Safari 11, not Safari Technology Preview. To get Safari 11, you would need to upgrade to MacOS 10.13 "High Sierra".

I did follow the "Sierra", not "High Sierra" link from https://developer.apple.com/safari/download/, and I am running Sierra. Am I doing something wrong? Do I need to update some libraries (XCode perhaps?)

@mdittmer Ok, then I do not know what the problem is, sorry.

@mdittmer I pinged some people about this internally. Will follow-up when they come back to me.

@mdittmer This is apparently a known issue :/ Updating Xcode / SDK should work. You can also try again with the next STP (41).

Note that the current STP has a significantly newer WebKit than Safari 11. Having STP data would be kind of neat but it's not a good substitute for Safari 11.

Was Safari 11 released for MacOS 10.12.6 or do I need to get my hands on a machine with High Sierra to try Safari 11? My experience with official releases has been that I only get them when Apple decides to push an update to my machine (i.e., for my OS version).

According to rumor sites, macOS 10.3 High Sierra will be available on September 25. We usually ship major Safari versions to previous major OS versions. In the meantime, the best option to get a very close approximation of Safari 11 is to install a High Sierra public beta.
This page claims to point to a Safari 11 beta for macOS Sierra or OS X El Capitan, but I was unable to get an actual download; I'll look into why https://developer.apple.com/safari/download/

Correction: Safari 11 has already shipped for Sierra and El Capitan. You can update to it via the Mac App Store app in the Updates tab.

Thanks for looking into it. Not sure why it isn't listed as an update for me. I'll try a different machine.

@mdittmer, if you're using a Google-issues MacBook it's possible updates are held back to provide for some kind of controlled rollout, at least for full OS upgrades that seems to happen. I also don't have the option to upgrade to Safari 11 yet, on macOS Sierra.

I've audited Safari 11 removals from a preview, and almost all changes make sense and could be tracked down to recent WebKit changes, often by @cdumez.
The only one that does not make sense is Navigator.hardwareConcurrency, which the data claims is removed but is still listed in https://webkit.org/status/#feature-navigator.hardwareconcurrency
@mdittmer, can you check if it's really removed?

I've also gone over the additions, and they all make sense, notable additions are WebRTC (yay @youennf) and WebGL, a really impressive set of new features I have to say.
@mdittmer, other than hardwareConcurrency, I think the changes for Safari 11 are probably correct.

hardwareConcurrency was genuinely removed per https://bugs.webkit.org/show_bug.cgi?id=174400

(We need to update the feature status page I guess)

From spot-checking the list of claimed "failure to ship" for Safari 11, I don't see anything obviously wrong, but I didn't do any testing or study of the code to confirm (yet).

Great!  I've also done a pass over the Safari 11 failure to ship and found just a couple issues (see https://github.com/GoogleChrome/confluence/issues/163#issuecomment-332282297).  Let's call this done and open new bugs for anything else we discover.


mark tasks preview

don't forget to move the ref in VSO to pick up the package.  ping eric if you need any help


Lens cannot find aws binary on /usr/local/bin on MacOS

I’m running Lens on MacOS, and I have a weird problem: I do have some k8s clusters from aws on my kubeconfig. If I open the app from spotlight, those clusters are not detected, but if I open the app from terminal, it works as expected.
On previous versions I got an error message stating that the aws binary is not found (the file is at /usr/local/bin) .
If I paste my kubeconfig file on 'add cluster' dialog, I get the same error (binary aws note found).
Lens seems to be the only app having this problem
I'm running

MacOS Big Sur
dmg file downloaded and installed from Lens website
version: Lens: 5.1.3-latest.20210722.1
zsh (with oh-my-zsh)
sdkman
brew

Found the problem.
The cause was that oh-my-zsh had tmux plugin enable, and configured to always open / attach to tmux automatically.
After disabling tmux plugin on oh-my-zsh, everything started working.


Implement gsym parser to load symbols from standalone gsym files.

Parse standalone GSYM file.
Find symbols of addresses from GSYM.
Query inlined functions.

I have made some changes.

Just fixed all issues mentioned above.

Just fixed all issues mentioned above.

I still see six or so open and at least some are entirely unaddressed to the degree I can tell, unfortunately.

Handle multiple sources covering a region.
Some resolvers may provide only a part of information. We may need to
combine the result of several resolvers.  For example, we can use a
GSYM file to translate addresses to symbol names in an efficient way,
but use an ELF symtab to lookup the addresses of symbols.

This commit description explains what seems to be the problem solved. That is great. But can it also detail the solution, please?

In general, I think this pull request cannot be reviewed properly given its size. It's some 1600 lines of code. Would it be possible to split it up into smaller chunks and send them out independently? It's mostly a deficiency of GitHub's UI, but we will have to make do with it somehow, I suppose.

Ok! Let me close this one.  And, open more PRs.


[docs-infra] Remove copy button from the DemoToolbar

[x] I have followed (at least) the PR section of the contributing guide.

This PR is a follow-up to https://github.com/mui/material-ui/pull/41827. What motivated this one is a reflection around multi-tab demos where I initially thought that the demo toolbar's copy button copying the content from both tabs was a valuable thing to support. However, in discussing it with @colmtuite & @zanivan, I realized this is actually a non-intuitive UX. Here's why that is:

The PR I linked above introduced somewhat of an inconsistency: if there's a demo toolbar, the copy button will appear on it. If there's not, the copy button is inside the code block. A better approach for managing the user's expectations is for this button to always be in the same place.
It seems way more intuitive to have the copy button closer to the content it will copy (i.e., the code block).
In the case of multi-tab demos, there's no affordance for users that lets them know the copy button on the toolbar will copy content from both tabs; this can get them surprised and create frustration, because we expect that, more often than not, you want to copy only  what you're seeing, and not what it's hidden in a separate tab.

On a more logistical note, I know we already have the code block copy button wired in GA, but I'm not sure if we want to do anything differently here if we're removing the button and its respective eventAction from the code. I considered swapping the eventAction from the remaining button to the toolbar's one, but I'm not sure — y'all let me know.
Preview: https://deploy-preview-42115--material-ui.netlify.app/material-ui/react-autocomplete/#combo-box

We should remove the opposite button no? https://github.com/mui/material-ui/pull/41827#issuecomment-2046026830

That is what is currently live in next, that I pushed in https://github.com/mui/material-ui/pull/41827. However, in this PR, the thought process is (as I tried to cover in the description):

the one within the toolbar is more distant from the code, which could be less intuitive. The GA events might illustrate the opposite, which is interesting, but it could be that the copy button within the code block is a bit too opaque (as you mentioned, it can be hard to see), and improving that would help boost its usage
particularly in the case of multi-tab components, the toolbar one is confusing because it currently copies content from both tabs. Being in the toolbar doesn't immediately communicate it will copy from both tabs, but maybe it does more than being in the code block. However, we're parting from the thinking that copying from both tabs is, in the end, a non-desired UX because you'd be more likely to want to copy what you're seeing rather than the full content spanning multiple tabs. Additionally, what will frequently stored in the second tab is data that will likely be replaced by contextual data from the developer's project (e.g., Autocomplete data set)

Does that make sense?

@danilo-leal Ok, got it. I guess It's that I'm mostly blind to the problems with the current version of HEAD. I see maybe the copy button is hard to see, but I don't see the other problems.

Yeah, well, there's a world where, as Olivier said, this is a non-issue. Or maybe the only substantial issue here is when it's a multi-tab demo, and the copy button secretly copies content from the two tabs? If we just changed that so it copied the content from only the visible tab, that could be progress (although the layout feels a bit weird, still).

If we just changed that so it copied the content from only the visible tab, that could be progress (although the layout feels a bit weird, still).

I think it works, given that users seems to prefer the toolbar button, and it'll suit the UX for copying only what you can see.
We can keep monitoring feedbacks about it, and review this decision if users aren't finding the copy button or if they want a solution to copy the code from both code blocks at the same time.

We haven't yet used the multi-tab demo feature extensively, so if we grew that first, I'd expect to see more feedback pouring in. That could also be a way to go before what we have going on here — I'd be happy to temporarily close this PR, expand that feature's usage, and wait to see what folks think.

maybe the only substantial issue here is when it's a multi-tab demo, and the copy button secretly copies content from the two tabs?

This was my main concern, I'm concerned people are mostly using this button specifically because it copies code from both tabs? If that's not the reason they use this button, then I guess it doesn't really matter. It's probably just a matter of visual prominence in that case.

If that's not the reason they use this button

I'd say it isn't because very few demos (if any, honestly!) currently use the multi-tab demo feature, so they mostly use the toolbar button to copy the code block content. I don't think we have had feedback yet about whether copying content from both tabs through the button they'd usually use to copy the code content is intuitive/good or not. So, I guess maybe the course of action here is to really do nothing, use the multi-tab demo feature more, and wait for feedback? I'd expect some folks to point out that they'd like to copy just what they see, but I'm willing to be proven wrong! Does that resonate?

I'd expect some folks to point out that they'd like to copy just what they see

Yeah this was my expectation too. If it's recently implemented behaviour and can't account for much of the GA data, then I still feel confident about this.
I think it's weird/bloated/confusing to have two copy buttons, so I'd be in favour of trying something. Maybe a good path forward is to try to get more data by making the code block button more prominent. Perhaps changing from an icon to "Copy" and increasing the opacity. Then reassess the data in a month or so.

Just to recap a bit.
The current state of the docs looks generally fine to me. We don't have two buttons going on anymore — in the case of a demo container, the only copy button is the one from the toolbar, whereas, in a code block case, the copy button is within the block.
Intentionally said "anymore" because that was the reality a few weeks ago before https://github.com/mui/material-ui/pull/41827. And even then, the GA data showed that on demo containers that had the two buttons, folks were clicking more on the one from the toolbar.
The issue trigger is really the multi-tab demos. It seems we're all on the same page that copying content from both tabs is not great, and the solution to that in terms of affordance would be what this PR does: it moves the button to inside the block, so it's clearer what will be copied is that particular code content. However, folks seem to be pretty used to clicking the button on the toolbar, and this positioning change is a risk. We could move on with this PR's changes and counter the risk by making the button within the block more visible, but we could also do nothing, scrap the PR, extend the use of the multi-tab demos, and see if folks will agree with us that copying content from both tabs is bad. If they do, we can come back here and push forward. If they don't, the button on the toolbar for that use case sort of makes sense (i.e., seems more "global" than within the block)?!
Long-winded answer just to make sure we're aligned 😅

Ok gotcha, thanks for the context. I think I understand the backstory/issue better now.
First, a couple of assumptions to qualify my suggestion below:

see if folks will agree with us that copying content from both tabs is bad

It seems clear to me that this is a surprising/confusing/undesirable UX. But who knows, I'm just guessing. I just can't imagine how you'd expect that behaviour, or why you'd want it.

the GA data showed that folks were clicking more on the one from the toolbar

I'm guessing that the reason most people are clicking the toolbar button is because the one inside the code block is difficult to see. Olivier mentioned this visibility issue too.
So here are my current thoughts based on the above assumptions:

I think having the copy button in different places at different times is confusing.
I think having a 50% opacity icon button is problematic.
I think having one button copy inactive tabs is unexpected/undesirable.

And here are my current thoughts in a bit more depth:
I think placing the copy button in the toolbar creates an issue, because we have some code blocks that don't have a toolbar and we don't want to have two copy buttons in two different places for the same demo. So that creates an issue where sometimes the copy button is in the toolbar, and other times it's in the code block. I think that's confusing/disorienting. I think we should have just one place where the copy button always exists. That way it's consistent, and people can learn where it is.
Since we need to have code blocks that don't have a toolbar, the only way to achieve this consistent button location would be to always have the copy button inside the toolbar, on all demos and code blocks.
So my suggestion is this:

Remove the button from the toolbar.
Always place the button in the code block
Change it from an icon to "Copy", and increase the opacity.
Have it copy the active file/tab only.

I agree with @colmtuite's reasoning. I’d like to add that if we proceed with the proposed changes—removing the toolbar button and enhancing the code block button—we can still monitor usage as a health metric and keep an eye on the docs-feedback channel for any issues that arise. If we notice a decrease in copy events, we can iterate on it, similar to what we did with the API table layout.

I edited my previous comment.

I'm on board with the suggestions and the reasoning — we were on the same page already! 😬 The above-pushed commit experiments with refining the copy button design towards suggestion one.
One thing that could make the first iteration of this PR (and which is close to suggestion 2) more appealing is that we have instances where the demo container renders with the code block hidden, requiring a click on the "Show code" button to show it. Given that the copy button would live inside the code block in this iteration, visitors would need to expand the demo to get the copy button, whereas today, even if it's closed, they can click copy on the toolbar and get the code. All in all, though, not sure if it's a strong enough reason to give up on this path.

Adding some slight context on the why behind having the Toolbar Copy button copying content from multiple tabs:
In most scenarios, people who copy content from demos intent to paste it into files and expect to see those changes work for them instantly; the idea with the Toolbar copy button (as being separate from the "local" copy button inside the editor) was that it would allow us to have this behaviour of a single copy action allowing a developer to copy everything they need for the demo to work when pasted in their local editor.

expect to see those changes work for them instantly

@bharatkashyap I'm confused how that work though, because is it not the case that the files/tabs need to be pasted into different local files? For Base UI, we will use the multi-tabs feature for a JSX file and a plain CSS file. You can't paste both these tabs into the same local file...it will throw an error.
We will also use the multi-tabs feature for Tailwind examples. We will have a JSX tab and a TW config tab. Again, you don't want to paste these tabs into the same local file.

Given that the copy button would live inside the code block in this iteration, visitors would need to expand the demo to get the copy button, whereas today, even if it's closed, they can click copy on the toolbar and get the code.

@danilo-leal This is a good point I overlooked. This makes me lean towards the "Alternatively" part of my suggestion above.

expect to see those changes work for them instantly

@bharatkashyap I'm confused how that work though, because is it not the case that the files/tabs need to be pasted into different local files? For Base UI, we will use the multi-tabs feature for a JSX file and a plain CSS file. You can't paste both these tabs into the same local file...it will throw an error.
We will also use the multi-tabs feature for Tailwind examples. We will have a JSX tab and a TW config tab. Again, you don't want to paste these tabs into the same local file.

In certain use cases – for instance when a large number of utility functions and some datasets are placed in multiple tabs – copying the content from a single tab would result in the pasted content not compiling since a few referenced variables would be undefined. However, I agree with you that this use case might be less common in the future compared to having .css files or Tailwind styles defined in separate tabs, where copying all content together would not make sense.
I agree with your proposal in the "Alternatively" section save for point 3., where I think the copy button can attempt to be smarter and copy content from either all tabs when there are only .js/.jsx files in the demo, or only the active tab when there are .css files involved.

Thanks @bharatkashyap. Sounds like the "alternatively" section above makes sense. I don't have a strong opinion on the smart/conditional button approach.

Thanks for chiming in, @bharatkashyap! 🙏
I was about to suggest that we could have some sort of config where, instead of assuming from the file extension, we could manually select whether the toolbar button copies the content from all tabs vs. copying just from the visible tab (which seems to be the Data Grid/Autocomplete vs. Base UI demo examples, respectively) but it sounds too complex, and ultimately, for the user, non-predictable (times does X, times does Y). It should be better to lean towards a heuristic here and go for it — I'd choose to copy just the content visible. As I described in the PR's description, I'd expect folks to replace dummy Autocomplete/Data Grid data with their own data anyway, so it seems fine if the copied content doesn't run immediately (and they can always copy manually from the other tab, too, no biggie).
Seems like we have a way to go, then! I'll push the rest of the changes in a bit and request another review!

Okay, can y'all double-check if what I'm pushing on this last commit makes sense? Here's a rundown:

I figured that in order for the toolbar copy button to copy the content just from the active tab, it needed to have access to which tab is active, which the DemoToolbar component doesn't. So, I added props so we could handle that on the Demo component instead.
with that, I then placed the handleCopyClick function in the Demo component, which accesses the active tab and determines which content the copy button should grab. Also, I thought it'd be nice/consistent to change the icon (which we weren't doing), so I'm also treating that in the Demo component via the newly added copyIcon prop.

Does this solution make sense (ergonomic, organized, etc.)? On my end here, everything seems to be working as expected. You can check the changes here after the deploy preview is done. Try copying content from the first demo, and then the last (that uses the multi-tab).

Here's what I see, just for double-confirmation (and I'll also update the PR's title & description to match the latest state of the discussion):
https://github.com/mui/material-ui/assets/67129314/6dccecd2-2943-4114-8015-77c71073840a


Update OAuth2API with new version and add submission games

@tomasmazzocchi this looks good
Let's add a note that they are able to test their integration by logging into their game using the same Quarters account they used to set up their app. When they are approved to go live, other accounts can then send Quarters to their registered wallet too.


Generalize recipe, clean up API, introduce eeg specific recipe

[x] add more tests
[x] clean up interpolator API quite a bit
[x] generalize core topoplot recipe to make it work for different use cases
[x] add EEG recipe
[x] add more docstrings
[ ] load default montage positions from file (implement labels2positions)
[ ] actually test things with Percy and setup sane CI, clean up tests + add more
[ ] write docs + clean up docstrings

Enables:
labels = string.(1:length(positions))
TopoPlots.eegtopoplot(data[:, 340, 1], labels; positions=positions, axis=(aspect=DataAspect(),))

great!
what I wondered, why is position required for recipe-topoplot, but label required for recipe-eegtopoplot?
Could one multiple dispatch on position::string->label vs position::Float -> positions? (feels too smart, so maybe not a good idea).
I just want to be sure, that label is the right default and not positions.
some pro / con regarding label

often 10/20 system is used => convenient if such a system

labels are not strictly necessary, only positions
individual positions

Other plotting libraries have a chanloc object / struct that contains both
Will give it a spin this week, this is just from inspecting the code!
one other thing: the topoplot_series, should that go into here, or stay in UnfoldMakie?

great!
what I wondered, why is position required for recipe-topoplot, but label required for recipe-eegtopoplot?
Could one multiple dispatch on position::string->label vs position::Float -> positions? (feels too smart, so maybe not a good idea).
I just want to be sure, that label is the right default and not positions.
some pro / con regarding label

often 10/20 system is used => convenient if such a system

labels are not strictly necessary, only positions
individual positions

Other plotting libraries have a chanloc object / struct that contains both
Will give it a spin this week, this is just from inspecting the code!
one other thing: the topoplot_series, should that go into here, or stay in UnfoldMakie?

ok. just a clarification: positions cannot always be looked up, e.g. custom locations, custom caps etc. - but o.c. for that the position argument exists. I'm ok with it.
I will keep plot_topoplot_series in UnfoldMakie for now

I will keep plot_topoplot_series in UnfoldMakie for now

Ah forgot to answer that... I think it's perfectly well placed in TopoPlots.jl

some first observations:
topoplot(position,data)
whereas
eegtopoplot(data,label)

[ ] I prefer the later - shall I change it?
[ ] include("eeg.jl") is missing right now
[ ] any reason the eegtopoplot recipe is not in recipe.jl?

Just changed it :)
Changed it already this morning ;)
Wanted to rename recipes.jl going forward, but didn't have a good name yet... Just in case we end up having more recipes, it's nicer to have them in separate files

can you push it? ^^

Ended up debugging some weird Cairo artifact: https://github.com/JuliaPlots/Makie.jl/pull/2093
This will pop up in the refimages until we tag a new release with this.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@72d47c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   91.34%
=========================================
  Files             ?        4
  Lines             ?      104
  Branches          ?        0
=========================================
  Hits              ?       95
  Misses            ?        9
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d47c4...c7f5356. Read the comment docs.

It would probably be good to point users to hidedecorations! and hidespines! for "naked" head plots. (Speaking of... should we define a method for those with FigureAxisPlot? Right now, they're only defined on Axis.)

I noticed this back then, especially for many plots, hidedecorations&splines is slow: https://github.com/JuliaPlots/Makie.jl/issues/1335
right now i do:
axisOptions = (aspect = 1,xgridvisible=false,xminorgridvisible=false,xminorticksvisible=false,xticksvisible=false,xticklabelsvisible=false,xlabelvisible=false,ygridvisible=false,yminorgridvisible=false,yminorticksvisible=false,yticksvisible=false,yticklabelsvisible=false,ylabelvisible=false,
   leftspinevisible = false,rightspinevisible = false,topspinevisible = false,bottomspinevisible=false,)

which is much faster, but not very userfriendly (no merging of options as of now)


[Localization]Type Drop-down column is selected by val

If i select px-dropdown as column type the data in it is selected by 'val' and not by 'key' thus not letting localization work as options will change according to the localization language thus not letting tabledata array bind to the column.
Expected behavior:
px-dropdown to be selected by key and not by val
Steps to reproduce the problem:
px-data-table-cell.html
 <px-dropdown               class="px-dropdown-content"               selected="{{cellValue}}"               select-by="val"               display-value="{{cellDisplayValue}}"               on-px-dropdown-selection-changed="saveCell"               allow-outside-scroll="true"               button-style="bare"               items="{{dropdownItems}}"               disable-clear>             </px-dropdown>

Closing due to age and release of https://www.predix-ui.com/#/elements/data-grid/px-data-grid


dot multiplication go wrong in pytorch 0.2 in attention module

there is some problem regarding to the attn module
energy = self.attn(encoder_output)
energy = hidden.dot(energy)
it seems dot function in pytorch 0,2 only support vector

I have the same issue. Here is the stack trace
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-21-153451c5590c> in <module>()
      9
     10     # Run the train function
---> 11     loss = train(input_variable, target_variable, encoder, decoder, encoder_optimizer, decoder_optimizer, criterion)
     12
     13     # Keep track of loss

<ipython-input-17-9703d5331834> in train(input_variable, target_variable, encoder, decoder, encoder_optimizer, decoder_optimizer, criterion, max_length)
     31         # Teacher forcing: Use the ground-truth target as the next input
     32         for di in range(target_length):
---> 33             decoder_output, decoder_context, decoder_hidden, decoder_attention = decoder(decoder_input, decoder_context, decoder_hidden, encoder_outputs)
     34             loss += criterion(decoder_output[0], target_variable[di])
     35             decoder_input = target_variable[di] # Next target is next input

/usr/local/lib/python3.5/dist-packages/torch/nn/modules/module.py in __call__(self, *input, **kwargs)
    222         for hook in self._forward_pre_hooks.values():
    223             hook(self, input)
--> 224         result = self.forward(*input, **kwargs)
    225         for hook in self._forward_hooks.values():
    226             hook_result = hook(self, input, result)

<ipython-input-15-1e8710146be2> in forward(self, word_input, last_context, last_hidden, encoder_outputs)
     30
     31         # Calculate attention from current RNN state and all encoder outputs; apply to encoder outputs
---> 32         attn_weights = self.attn(rnn_output.squeeze(0), encoder_outputs)
     33         context = attn_weights.bmm(encoder_outputs.transpose(0, 1)) # B x 1 x N
     34

/usr/local/lib/python3.5/dist-packages/torch/nn/modules/module.py in __call__(self, *input, **kwargs)
    222         for hook in self._forward_pre_hooks.values():
    223             hook(self, input)
--> 224         result = self.forward(*input, **kwargs)
    225         for hook in self._forward_hooks.values():
    226             hook_result = hook(self, input, result)

<ipython-input-14-3c700c5b6bb1> in forward(self, hidden, encoder_outputs)
     22         # Calculate energies for each encoder output
     23         for i in range(seq_len):
---> 24             attn_energies[i] = self.score(hidden, encoder_outputs[i])
     25
     26         # Normalize energies to weights in range 0 to 1, resize to 1 x 1 x seq_len

<ipython-input-14-3c700c5b6bb1> in score(self, hidden, encoder_output)
     35         elif self.method == 'general':
     36             energy = self.attn(encoder_output)
---> 37             energy = hidden.dot(energy)
     38             return energy
     39

/usr/local/lib/python3.5/dist-packages/torch/autograd/variable.py in dot(self, other)
    629
    630     def dot(self, other):
--> 631         return Dot.apply(self, other)
    632
    633     def _addcop(self, op, args, inplace):

/usr/local/lib/python3.5/dist-packages/torch/autograd/_functions/blas.py in forward(ctx, vector1, vector2)
    209         ctx.save_for_backward(vector1, vector2)
    210         ctx.sizes = (vector1.size(), vector2.size())
--> 211         return vector1.new((vector1.dot(vector2),))
    212
    213     @staticmethod

RuntimeError: Expected argument self to have 1 dimension(s), but has 2 at /pytorch/torch/csrc/generic/TensorMethods.cpp:23020

torch=(0.2.0.post1)

you can try:
energy = torch.squeeze(hidden).dot(torch.squeeze(energy))

You can also use mm() if you make sure both items have 2 dimensions

Thanks for this. It looks like PyTorch devteam removed implicit flattening of matrices for dot product, which is what causes this glitch. Here's the discussion:
https://github.com/pytorch/pytorch/issues/2313

@dhpollack can you explain mm() ?

The mm() function is normal matrix multiplication of 2d matrices. So if A is 5x3 and B is 3x5 then mm(A,B) is a 5x5 matrix and mm(B,A) is a 3x3 matrix.
But ultimately I think that bmm() should be used because it's the same thing but allows for batches. I reworked the example on my computer. I'll post a snippet tomorrow.

I'm wondering about speed, is there an easy way to invert one of the
matrices? If it's two nx1 matrix, shouldn't that be a quick fix?
On Sun, Oct 22, 2017 at 5:41 PM, David Pollack<EMAIL_ADDRESS>wrote:

The mm() function is normal matrix multiplication of 2d matrices. So if A
is 5x3 and B is 3x5 then mm(A,B) is a 5x5 matrix and mm(B,A) is a 3x3
matrix.
But ultimately I think that bmm() should be used because it's the same
thing but allows for batches. I reworked the example on my computer. I'll
post a snippet tomorrow.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spro/practical-pytorch/issues/51#issuecomment-338511447,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxGKTe-SB32IMCHxH6SbUu9L_l1hfnvks5su7aRgaJpZM4O5_Km
.

yes, that is an easy fix, but it's more efficient to avoid for loops.  I was playing with this code for a different application, but you can see below how I don't have for loops in the Attn class
https://gist.github.com/dhpollack/c4162aa9d29eec20df8c77d9273b651b#file-pytorch_attention_audio-py-L314

thanks so much for this snippet, super helpful to see.
so, just to be clear, your method reshapes the matrix, then conducts batch
matrix multiplication, correct? that's what I previously meant by
invert--should have said transpose!
On Mon, Oct 23, 2017 at 7:01 AM, David Pollack<EMAIL_ADDRESS>wrote:

yes, that is an easy fix, but it's more efficient to avoid for loops. I
was playing with this code for a different application, but you can see
below how I don't have for loops in the Attn class
https://gist.github.com/dhpollack/c4162aa9d29eec20df8c77d9273b65
1b#file-pytorch_attention_audio-py-L314
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spro/practical-pytorch/issues/51#issuecomment-338623728,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxGKRhT-t2SQdc-ssYzu3BCwQ5GB-D1ks5svHITgaJpZM4O5_Km
.

yes, you could transpose a Nx1 vector and then use the for loop.

@dhpollack
Last question, promise: is there a major difference between your solution and using <torch.squeeze(vector1).dot(torch.squeeze(vector2)> ?

I was attempting to all the multiplications in one shot and trying to avoid using squeeze/unsqueeze/view/cat operations as much as possible.  I think avoiding those should make things faster but I haven't tested it.


Inconsistent model labels in the molprobity report

From Monica:

In the full validation pdf report for 2-WGSG, in the Too-close contacts section the first table is fine (shows models 1-10 as expected), but the extended table after the sentence "All 374 close contacts within the same asymmetric unit are listed below, sorted by their clash magnitude" has many rows that refer to model 0 instead of model 10.  Is this a table formatting issue?  You can see it starting on page 21 here:
<...>
I also see the same thing on pages 23-25 in the corresponding validation pdf report on the public site:
https://pdb-dev.wwpdb.org/Validation/PDBDEV_00000185/pdf/PDBDEV_00000185.cif.pdf
For both the test site and the public site, the Torsion angles: Protein backbone section which starts on page 38 and the Torsion angles: Protein sidechains section which starts on page 46 look fine.

Indeed, the models in the table seem to be renumbered from 0 instead of 1.

c26fc1b also fixed this issue.


Tracking issue for supporting shard level replay

Describe This Problem
Table level replay is too slow, so we try to support shard level replay to relax this problem.
It is a big work, so I split it into some phases and track its progress here.
Proposal

[x] complete unimplemented scan method in all wal implementations.
https://github.com/CeresDB/ceresdb/pull/400
[ ] implement wal adapter to keep the reading view of table level while using(and the actual reading work is doing in shard level).

[ ] implement the read buffer.
[ ] implement the wal adapter.

[ ] refactor the original recovering process to make use of the wal adapter.

[ ] refactor the original recovering process in standalone mode.
[ ] add Replayer to carry out the  recovering work.

[ ] bug fixs:

[ ] recover by flushed_sequence in manifest.
[ ] modify RegionId to a struct including ShardId and its version.

Additional Context
No response

Fixed in https://github.com/apache/incubator-horaedb/issues/799


Clustered Cache Configuration

XML and Programatic.  In my head this wants to be a natural extension of the current resource set approach without pulling clustering specific code in to the impl module.

Closed as it has been replaced with a more specific set of tasks now in the backlog.


Wait-Event does not time out on Raspberry Pi

The following test fails on Raspberry Pi in release automation:
https://github.com/PowerShell/PowerShell/blob/5b82b767558f682fef3ec53b5e5955981c2183ec/test/powershell/Modules/Microsoft.PowerShell.Utility/Wait-Event.Tests.ps1#L14
Error message:
Expected the actual value to be less than 1500, but got 2105.

Things are sometime slower on RPi. This should be be a blocker.


Fyne gui

Implement base-level fyne gui module.

Also got a panic when I quit the app using the Quit button.
And the navigation menu buttons expand/contract in width in response to window resizing, should keep the navigation area of fixed width.

Can we monitor the Changed event of the window and redraw the interface accordingly? Some part of the app doesn't when you maximize the window.

With Fyne the window resize will cause the layout to be adjusted accordingly. If the layout is not changing correctly then correct change is to use a different layout rather than listening to events to change layout positions.


Firefox:      can’t be installed

This add-on could not be installed because it appears to be corrupt

将根目录下manifest_firefox.json替换为manifest.json
在火狐中打开about:debugging#addons
启用附加组件调试
临时载入附加组件
打开manifest.json

虽然重启浏览器后就要重新加载，不过至少凑合能用（火狐版本号57.0.3 )
我尝试过用web-ext打包以后签名，结果报了6个错误

"/background/presistent" is not a valid key or has invalid extra properties

错误: Your JSON file could not be parsed.
2. "/background/scripts" is not a valid key or has invalid extra properties
错误: Your JSON file could not be parsed.
3. "/background/page" is a required property
错误: See https://mzl.la/1ZOhoEN (MDN Docs) for more information.
manifest.json
4."/background" should match some schema in anyOf
错误: Your JSON file could not be parsed.
5.Banned 3rd-party JS library
错误: Your add-on uses a JavaScript library we consider unsafe. Read more: https://bit.ly/1TRIyZY
js/vendor/angular.min.js
6.Banned 3rd-party JS library
错误: Your add-on uses a JavaScript library we consider unsafe. Read more: https://bit.ly/1TRIyZY
js/vendor/jquery-1.12.2.js

https://github.com/yfdyh000/listen1_extension


Unrecognized Font Familiy Roboto

I'm having the same issue. Any luck fixing it?

The offending code is theme={VictoryTheme.material}.

I am experiencing a similar and possibly related issue.
I am running Expo, and after upgrading to SDK35 I can no longer pass in custom fonts to tickLabels. Doing so results in an "Unrecognized font family" error. The font loads fine for the rest of the app, I only get the error when trying to pass it into victory-native.

@mortenc Did you resolve the issue, same thing happening with Expo SDK35

@FH-Hersey Unforunately not yet – still not able to use my custom font. I'm unsure if the issue is with victory-native, or if it's actually to do with react-native-svg. But I haven't been able to resolve the problem yet.

This error happen to me , too. Can anyone solve this problem ?

Please, any idea how it could be solved?

I ran into this issue while updating dependency versions of my app. I wound up going back to the earlier versions (rnsvg - 9.0.2 and victory-native - 31.0.0). The issue is with the react-native-svg package, so perhaps using older versions of both would be a temporary workaround.

I commented out all instances of VictoryTheme.material and my app runs fine.

Have this problem too

Same

I have expo sdk 35 and i have this problem.
I made a copy of the theme 'VictoryTheme.material'
origin file  - 'node_modules > victory-core > es > victory-theme > material.js'

and removed the font from there
35 fontFamily: sansSerif,

now works with default fonts

the default theme has Roboto on it
like this
const sansSerif = '\'Roboto\', \'Helvetica Neue\', Helvetica, sans-serif';

it worked well on 0.30.*
but breaks on 0.33.*

The offending code is theme={VictoryTheme.material}.

Removing this fixed it for me.

It's not pretty, but I'm able to use the material theme in iOS by removing the Roboto font family:
const theme = Object.assign({}, VictoryTheme.material, {
    axis: {
      ...VictoryTheme.material.axis,
      style: {
        ...VictoryTheme.material.axis?.style,
        tickLabels: {
          ...VictoryTheme.material.axis?.style?.tickLabels,
          fontFamily: "'Helvetica Neue', Helvetica, sans-serif",
        },
      },
    },
  });

I'd appreciate any feedback on how to make it smaller. TypeScript complains "The left-hand side of an assignment expression may not be an optional property access." when I try to set the font family directly on a local copy of the material theme.

The offending code is theme={VictoryTheme.material}.

Thats worked for me, thanks

If you don't want to remove theme={VictoryTheme.material}, you can use the following:
function replaceRobotoWithSystemFont(obj: any) {
    const keys = Object.keys(obj);
    keys.forEach(function(key) {
        const value = obj[key];
        if (key === 'fontFamily') {
            obj[key] = obj[key].replace(/'Roboto',/, "'System',");
        }
        if (typeof value === 'object') {
            replaceRobotoWithSystemFont(obj[key]);
        }
    });
    return obj;
}

const themeWithSystemFont = replaceRobotoWithSystemFont({...VictoryTheme.material});

<VictoryChart theme={themeWithSystemFont}></VictoryChart>

This issue is still happening.
Expo SDK 40.0.1
victory-native 35.3.1
Neither of the solutions suggested above work for tick labels specifically. I'm not sure why this issue was closed in the first place, since there was never a real fix implemented?

Also same issue here using a custom font. The app becomes laggy for a few seconds and then the error appears. The font works fine in the other parts of the app.
If I remove fontFamily: 'my-font' everything works fine.  'my-font' is a custom font (ttf) loaded when first opening the app.
<VictoryBar
	labelComponent={<VictoryLabel style={{ fill: Colors.text, fontFamily: 'my-font' }} />}
	tickLabelComponent={<VictoryLabel style={{ fill: Colors.text, fontFamily: 'my-font' }} />}
/>

Expo SDK 42.0.0
victory-native 35.5.4


Invoke-DbaQuery.ps1: Parameter documentation

Fixes a dead link and adds some useful reference info for -CommandType. Fixes #7359.

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[x] Documentation
[ ] Build system

Awesome, thank you so much @NReilingh! Will merge once tests re-run.

Thank you so much! The failure is with an unrelated command that's having an issue on appveyor.


How to correctly implement plugins

Taking Profile plugin as the example, how do you attach correctly the plugin implementation?
https://github.com/rdkcentral/Lightning-SDK/blob/82b8948ca0e7efe7afe5a94ba5700d21a9cc880c/src/Launch/index.js#L45
https://github.com/rdkcentral/Lightning-SDK/blob/82b8948ca0e7efe7afe5a94ba5700d21a9cc880c/src/Profile/index.js#L32-L35
As I've seen in the above code, you can provide your implementation of the plugin interface for the getInfo/setInfo.
What is the correct approach to create the platformSettings.plugins object, since the getInfo / setInfo are functions, we can't simply create those in the settings.json file.
One of the approaches I took was something like this before the Launch is called, but seems very dirty to me:
export default function () {
  arguments[1].plugins = {
    profile: {
      getInfo: (key) => { },
      setInfo: (key, params) => {},
    },
  }
  return Launch(App, ...arguments)
}

After some talking with @mauro1855, came to the conclusion that these wrappers are useful when you deploy your app through the Metro store. We'll think about the best approach to this, either we simulate what the Metro store does or we'll create our own wrappers.


SSH authentication error

Describe the bug
Pyinfra is unable to connect to a server over ssh.
To Reproduce
$ pyinfra --debug server.example.com exec -- ls
--> Loading config...
--> Loading inventory...
    [pyinfra_cli.inventory] Creating fake inventory...
--> Connecting to hosts...
    [pyinfra.connectors.ssh] Connecting to: server.example.com ({'allow_agent': True, 'look_for_keys': True, 'hostname': 'server.example.com', '_pyinfra_ssh_forward_agent': None, '_pyinfra_ssh_config_file': None, '_pyinfra_ssh_known_hosts_file': None, '_pyinfra_ssh_strict_host_key_checking': None, '_pyinfra_ssh_paramiko_connect_kwargs': None, 'timeout': 10})
    [pyinfra.connectors.sshuserclient.client] Loading SSH config: None
    [server.example.com] Authentication error () (Authentication failed.)
    [pyinfra.api.state] Failing hosts: server.example.com
--> pyinfra error: No hosts remaining!

# ~/.ssh/config
Host *.example.com
    User [...]
    IdentityFile [...]

Expected behavior
Pyinfra should display additional error information when unable to connect.
Meta
    System: Darwin
      Platform: macOS-12.3.1-arm64-arm-64bit
      Release: 21.4.0
      Machine: arm64
    pyinfra: v2.4
    Executable: /Users/pikeas/repo/code/py/.venv/bin/pyinfra
    Python: 3.10.7 (CPython, Clang 14.0.0 (clang-14<IP_ADDRESS>))

[pyinfra.connectors.sshuserclient.client] Loading SSH config: None

This line looks very suspicious to me! Could you try again but explicitly set the config file:
pyinfra --debug server.example.com --data ssh_config_file=/Users/pikeas/.ssh/config exec -- ls

I'm not sure why it doesn't automatically pick it up, if we confirm the above works then at least we know where the problem is!

The cause of my issue was that my SSH agent hadn't loaded keys into memory. I've just removed the keys from memories to share a repo and...of course there's a proper error now:
$ ssh-add -D
$ pyinfra server.example.com exec -- ls
--> Loading config...
--> Loading inventory...

--> Connecting to hosts...
    [server.example.com] Authentication error () (Private key file is encrypted)
--> pyinfra error: No hosts remaining!

I haven't made any changes to my client (MacOS laptop) since opening the issue, especially not removing my SSH config file. The only thing I can think of is that MacOS has different handling on "first" (post-reboot) use of the agent, which may bubble up differently.


fix: ghcr.io/.../zeebe-simple-monitor:2.7.1 does not exist

The docker compose file does not work, because the image
ghcr.io/camunda-community-hub/zeebe-simple-monitor:2.7.1
does not exist in ghcr.io

Thank you for your contribution.


test: add firefox esr to test matrix

Closes #1028
What I did

add a test matrix in ci for firefox esr and latest
check for CI env var, and launch ff and webkit

Testing Instructions

check CI output for presence of ff latest and esr

Notes to Reviewers

see issue. this won't work


error code 2512 again

absolutely the same as #11588
BEGIN KEYBASE SALTPACK SIGNED MESSAGE. kXR7VktZdyH7rvq v5weRa0zkUZHIPc 5vyOfClafXfMXXc BPZryxCdA8glB6c Fz1D3sGtP0Mv3dR bjNkG31b0j9Hq6H zRZQ5ifILwCmRgP Sfjjuh1mgXEZeyJ DZX3nDR0ZQbwKaT 7QFii19acnboztc ZByubuUhAanbqcE IcidT36lWl4iCEV MoUzJyZE8BbJJgu 9I9xZjg6nooMV9j EpisdHoVRphzcy1 HsbtgvoLmk3CQcM OCc0dvi3e2mG27T 8rxNKP0Ss2D3ic4 AgfQZ8QXQn3LQOO T8b9yA7mLTFcwn5 AOkpHO6K3ckl6VW ft6BeaT4sYI0jb1 S5zGqPnq1NfLQz3 aE3FLt9Vhr6Y9Yp rEE. END KEYBASE SALTPACK SIGNED MESSAGE.

I reset the folder.  Please check it out and close this if everything seems ok.  (Might require a Keybase restart.)


require autoload gives fatal error

In /jgrossi/corcel/src/Password/PasswordService.php at line 7 is a (left-over) require_once to the /vendor/autoload.php, which breaks since the path to the file does not exist.
I've added PR #145 to solve this issue (and added the error and reason with it).

Has been fixed in PR #148 in dev-branch (now waiting for release ;) )

Thanks @Grezvany13 ;-)

Release at v.1.0.8 @Grezvany13 thanks!


Should provide more guidance on how to just consume windows apis

For those that use the windows contracts nuget package, they just simply need to update their TFM to get the new windows apis. This should be mentioned in this doc, since the build error points to this doc. I'd imagine the 95% case of people don't need to worry about running this tool themselves.

I opened this on my phone, and it clearly lacked the info needed to be relevant.
Closing as dup of #2662


Images are zoomed in

How it's supposed to look like:

How it looks like in 3.1.1:

Reason
When I added #2, I had to change how the background works. Instead of using document.body.style.backgroundImage = 'url('+data.body.item.album.images[0].url+')';, we had to use document.getElementById("bg").innerHTML = `<img src="${data.item.album.images[0].url}"> due to not being able to fade in/out the background. With the new CSS trying to replicate a background image, this caused the side effect of making the album art zoomed in.

Fixed in #13


Exclude .afdesign file from ZIP?

@BernhardBaumrock Hi Bernhard!
Curious about the https://github.com/baumrock/RockFrontend/blob/main/RockFrontend.afdesign file - presumably this is an affinity designer save that's been included in the download zip.
Could this be excluded from the installed files as things like this really don't need to end up in live sites when the module is installed?

Yes, it's a 30kB source file that I can use to create logos for my modules. It's just easier for me to have it in the dedicated modules and not somewhere else, but I could also move those files into my cloud. I'll go ahead and do so even though I don't think it does any harm?


[ODS-4707] Support Configuration to Drive Reverse Proxy Support

Redid the commits and force pushed to ensure they were all signed.

Redid the commits and force pushed to ensure they were all signed.


Evolution: Some of these tests pass with swift_test_mode_optimize_none_with_implicit_dynamic

The remaining failures still warrant investigation.

@swift-ci Please smoke test

Thank you. The ones that are still failing might just be failing because -enable-private-import makes non external symbols external and then the symbol comparison fails. At least that was what was happening with the one failing that I have looked at so far. My plan is to only enable implicit dynamic for public symbols under enable-library-evolution. I can either do this under another flag for testing or always after clients of the feature have adopted something like https://github.com/apple/swift/pull/25246.

@aschwaighofer How about we just skip the symbol comparison step when implicit dynamic is on? As long as we still run the tests with implicit dynamic off as well we should get the right amount of test coverage.

Yes that would make total sense.

Ok, I can try that in a follow-up PR. Thanks!

@swift-ci Please smoke test


Configurable workers manager timeout

My initial attempt at closing https://github.com/edgurgel/verk/issues/41
I wasn't sure if the configuration should happen in the WorkersManager module or if it should be passed in from the supervisor as I did.  Credo is also not happy that the number of args is up to 6 for Verk.WorkersManager.start_link.

Coverage decreased (-0.2%) to 81.503% when pulling a04e26b088d6ed86f716492c540bfadba7aae45d on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

Coverage decreased (-0.2%) to 81.503% when pulling a04e26b088d6ed86f716492c540bfadba7aae45d on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

Coverage decreased (-0.5%) to 81.268% when pulling 8dfdfe39d762457221785d63d8b853c0b1ac6452 on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

Thank you for another contribution!
I would simplify your PR to grab this application env from inside the WorkersManager. We don't need to pass around as it's accessible from anywhere.
I would probably have a private function inside the WorkersManager module to always fetch from the Application env as it is cheap to get this data.
What do you think?

I'm not sure.  ETS is super fast, but checking every time shouldn't be necessary either.  I considered doing it at compile time as well.  A branch showing what that would look like is here.
Would something like that be workable?  If not, I would probably prefer something that fetched from env on the init.

Yeah maybe the best solution is to fetch on init then keep it on the State? I think this shouldn't be a compile time change cause it feels pretty useful for runtime configuration. What do you think?

Coverage decreased (-0.2%) to 81.556% when pulling 8912a33b66a91fc2fe2426a08953b08698430576 on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

I think that makes a lot of sense.  As far as runtime configuration, I'm not quite sure.  My use cases wouldn't necessarily need it, but probably better to err on the side of flexibility.

Coverage increased (+0.05%) to 81.792% when pulling 4050c779fade2f58dbfcc7687953f139d64df3f6 on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

Coverage increased (+0.05%) to 81.792% when pulling 4050c779fade2f58dbfcc7687953f139d64df3f6 on mitchellhenke:configurable-worker-manager-timeout into 2b0180d1816741fb74a75613d80276b4d0032735 on edgurgel:master.

I've updated the PR to pull timeout from env and put it in State during init

Amazing! :tada: :heart:
Thank you once again!

I'll probably have a go at https://github.com/edgurgel/verk/issues/38 shortly


K-largest elements from array

Given an integer array nums and an integer k, return the kth largest element in the array.
Note that it is the kth largest element in the sorted order, not the kth distinct element.
Can you solve it without sorting?
Example 1:
Input: nums = [3,2,1,5,6,4], k = 2
Output: 5
Example 2:
Input: nums = [3,2,3,1,2,4,5,5,6], k = 4
Output: 4

I can resolve this issue. @Kushal997-das, please assign it to me under Hacktoberfest 2024.

Hi there!
I am the Mentor of this project.
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:

Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.

Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!

I want to contribute in this , please assign it to me


Docs page for stylelint rules applicable to SCSS?

As the list of our rules grow, we'll of course move it to a separate docs page. But what I thought is maybe we shoud also list all the rules from stylelint core that can be used with SCSS syntax (and some other parties plugins)?
E.g.:

max-nesting-depth - can be used to limit the depth of nesting inside the rulesets;
at-rule-blacklist - can be uset to forbid @extend, @mixin and other Sass elements;
rule-nested-empty-line-before,

etc.
The good thing about having such a list would be having a reference on linting SCSS via stylelint and its plugins in one place. The downside - we'll have to be constantly monitoring stylelint rules (along with the wild, for the plugins), the changes in them and review the list accordingly.
Possible options:

Make a separate docs page for this.
Put this list on the main docs page with our rules, after them, properly delimited and highlighted.

Like you said, I see pros and cons for each approach.
You could also argue that every stylelint rule and plugin can be used to lint SCSS. I think it'll be a very arbitrary line that divides rules for SCSS and rules for CSS.
Also, I'm a fan of reducing any documentation burden. Perhaps a non-definitive list of examples of how certain stylelint plugins can help with specific SCSS-like language extensions e.g.
"stylelint has many rules which can be used on SCSS language extensions that conform to standard CSS syntax (i.e. function and at-rule based language extensions) e.g. at-rule-blacklist can be used to disallow @debug commands"

Perhaps a non-definitive list of examples of how certain stylelint plugins can help with specific SCSS-like language extensions

I think that this is a good idea. We could pick a few good examples and have those documented.

Another use case, the following stylelint config contains two configurations, the second of these is a SCSS config that extends the initial configuration:
https://github.com/niksy/stylelint-config-niksy/blob/master/index.js
'at-rule-no-unknown': [true, { severity: 'warning' }],

Then in this SCSS config, the above rule is extended to add the SCSS at rules:
https://github.com/niksy/stylelint-config-niksy/blob/master/scss.js
at-rule-no-unknown': [true, {
			ignoreAtRules: ['extend', 'at-root', 'debug', 'warn', 'error', 'if', 'else', 'for', 'each', 'while', 'mixin', 'include', 'content', 'return', 'function'],
			severity: 'warning'
		}],


perf(double max length value): double Max Length Value

Double Max Length Attr Value

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Breaking of code embedded in raw strings with string interpolation

Input:
See output.
Output:
var v = $"""
    abcde abcde abcde abcde abcde {string.Join(
        ", ",
        new[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 }
    )}
    """;

Expected behavior:
Not sure :). Maybe this?
var v = $"""
    abcde abcde abcde abcde abcde {
        string.Join(", ", new[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 })
    }
    """;

or
var v = $"""
    abcde abcde abcde abcde abcde {
        string.Join(
            ", ",
            new[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 }
        )
    }
    """;

I just don't think the current formatting is ideal.
Btw this is changed behavior from 0.26.0. I think until the current version it wouldn't even warp this code, not sure.

Right now there is no formatting applied to expressions that appear within a raw interpolated string.
From what I recall, the original interpolated strings did not allow line breaks in any expressions within them. So CSharpier was forcing those expressions to be flat. When raw interpolated strings were first supported in CSharpier, they were treated the same way which would have resulted in
var v = $"""
    abcde abcde abcde abcde abcde {string.Join(", ", new[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 })}
    """;

And then when I was getting raw strings to indent correctly, the side effect was that I removed all formatting from the expressions in them.
Long story short, I believe it should be possible to get expressions within raw strings to format.

Raw string literals, by their multiline nature, are currently the largest unformatted (well, manually formatted) pieces of code in our codebase. I briefly looked into the current implementation but I'm afraid the logic for raw literals is quite beyond my expertise to implement this formatting myself in a PR. @belav is this something still on your radar?


Loom

What is the vendor's name?
Loom
What is the vendor's pricing site?
https://www.loom.com/pricing
What is the base pricing? Use the lowest tier that looks sane for a small business customer, not free or personal tiers.
$12.50 per user/month
What is the minimum pricing for SSO support?
Information not made public
Does this pricing info come from a quote or other non-public source?
Are there any caveats we should list in the footnotes?

Hey @perrier8800 ,
as this repository was not maintained for a long time, I decided to start a new initiative under https://ssotax.org/. The data is already way more up2date than in this repository! Loom is already available there. Moreover I integrated feedback from the community like a Friends of SSO page.


Hash and encryption

Medication should be encrypted. Look into methods for this.

Completed basic for now. Will revisit.


New token type: Visibility (show/hide layer)

An interesting feature is the visibility boolean used for hiding and showing elements inside a component.
Well, we have styled elements who are quite complex. Brands choose compositions based on the options they have. Without the visibility boolean every branded header, as seen in the images, needs to disable the bullet manually when brand A is activated. And I can't use the 0.001px hack in Figma tokens because it doesn't work

I'd suggest we change this to Boolean which will allow us to set this not just for visibility but for many other applications as well.


Agenda list of TODO's clears itself if I refresh the TODO list

Describe the bug
If I bring up the list of my TODO's, and then without saving the document or changing any TODO items, I refresh the TODO list, all the entries go away and I have to save my agenda file, close the TODO list window, and then re-open it in order to get my list of TODO's back
To Reproduce
Steps to reproduce the behavior:

Open Agenda file with TODO's
Open list of TODO's with < leader > oat
refresh list with 'r' binding
See error

Expected behavior
I don't expect the list of TODO's to clear itself if I refresh the list without making any changes to the existing TODO's
Emacs functionality
If this functionality exists in Emacs Orgmode, explain how it works there.
Screenshots
If applicable, add screenshots to help explain your problem.
System information:

OS: Windows 10
Neovim version/commit: nvim-qt v0.5.0

Additional context
Add any other context about the problem here.

I'm not able to reproduce this (on Linux).
Do you get any error message? If yes, can you paste it here (or screenshot it)?
Also, while in the buffer with list of all TODO's, what does this command return:
:map r

There aren't any errors message when I refresh the TODO list.
The :map r returns:
"*@lua require("orgmode").action("agenda.redo")"
It looks like it might be thinking "r" is redo instead of refresh/redraw? This is my orgmode config in my init.vim:
require('orgmode').setup({
org_default_notes_file = '~/Documents/Notes/Notes.org',
org_hide_leading_stars = true,
org_indent_mode = 'noindent',
})

map looks fine, it's agenda.redo. Naming is just confusing.
I don't see org_agenda_files in your config. Did you remove that on purpose here in the comment or?

Aha!
That was the issue. I must have removed that line during configuration accidentally and didn't realize it. I added back that line with it pointing to the right directory and now the bug is gone. Well it wasn't really a bug, it was my own mistake.
Thanks for the troubleshooting help!

You're welcome.
One unrelated question. Is everything working fine on Windows? I didn't test it yet on Windows to see how everything behaves, so any feedback on this is appreaciated.

Yup! It's working very well on Windows. I actually came from Emacs (doom emacs) and fell in love with the workflow, but at work I use windows and Emacs doesn't work very well on Windows, especially with all the configuration and packages included in Doom. I decided to try to recreate as much functionality as I could with Nvim, and your orgmode plugin was the first thing I needed. I was very happy to stumble across it and even happier when it worked very well.
The only issue I regularly run into is for what ever reason sometimes I try to orgmode specific stuff (like the < leader > < enter >) to continue a list, it'll throw this random lua error and won't let me do it. It's not consistent though so it's most likely either a weird quirk with windows or a mis-configuration on my end. All and all the process was the same to set it up on windows (after I tinkered with getting git to work) like to get it set up on Linux.

Also I don't know if this is possible, but how would I call the < leader > < enter > continue list feature from insert mode? I don't like having to keep going into normal mode to continue the list and then go back into insert mode. If this should be a separate ticket just let me know. @kristijanhusak

@goosebill Thanks for the Windows info. I'm glad it works fine.
Lets have a separate issue for that. I'll probably introduce an Enter mapping for it, since I'm having the same pain point. I wanted to avoid it because most of people have Enter mapped to something for autocompletion or auto pairs, but I'll write some documentation how to use it with custom mapping.


New Decks UI breaks some elements

New deck UI has several sections that overlap each other or break entirely once activated:
When in Decks layout, I am unable to scroll through all of my columns (currently have 6) as the scrollbar stops partway through.
If I click a column's icon from the sidebar to navigate to it, the entire window gets a second horizontal scroll bar at the bottom, above the main window one. At the same time, a new header UI appears, which overlaps the decks themselves at the top.
https://github.com/spuithori/tokimekibluesky/assets/108703223/97babe38-f5a8-4f9d-9f4f-64fb0dbc2cba

@xenianth
I think I have probably fixed the problem, but the problem may continue in some environments due to different scroll bar specifications on different operating systems. Please check!

everything is working properly again, thank you!


Enhancement: Remove inconsistent single select prop names

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Remove the ifx prefix from single-select prop names to match the naming of the multi-select
Related Issue
#1021

📦 Published PR as canary version: 21.14.1--canary.1295.464e5d767778515421c552b4696ef0975ecdf6a7.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

@pfafffabian-ifx
Can you also change the props in the example apps?

@pfafffabian-ifx Can you also change the props in the example apps?

@tishoyanchev done

@pfafffabian-ifx
Please make sure to properly examine every instance where the select component is being used, and correct the props. For example, I noticed that the props are not correctly on the Select when it's nested inside the Pagination component.

@tishoyanchev good catch, I fixed it now


Update parameter name

Fixed linkageGroupDbId parameter name to match the standard

related to #51

Not merging this. See comments in #51
@martinbaste don't worry about fixing this branch. I'll make the necessary change in #134


Some tests seem to get stuck or stop receiving logs on macOS 13

Is there an existing issue for this?

[X] I have searched the existing infra issues

Type of Request
bug
Infrastructure Environment
LUCI
What is happening?
I've only seen in 2 tests so far but seems like sometimes the test/logs gets stuck, you can see the test took 30 minutes but if you look in the log, it only shows a few minutes worth of logs before it cuts off. It's unclear to me if the test got stuck or if the logs stopped being collected or what.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac plugin_test_ios/11544/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac plugin_test_ios/11537/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac plugin_test_ios/11541/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac module_test_ios/15507/overview
Steps to reproduce
No response
Expected results
I expect test to run and logs to show

Can we run these tests on a devicelab mac machine with a vnc session? in the past we've seen this behavior when xcode tries to do something that requires elevated permissions or when it opens windows that require manual intervention.

Taking a look.

FYI it only happens sometimes so if we test against a devicelab bot probably need to test multiple times

So it can on any bot but it happens irregularly? And is the failure a valid failure? It is odd that it hung around for 28 minutes or so and the run really only took 2.

I have modified the test configuration to run in the devicelab and have VNC setup. I am going on 8 attempts on flutter-devicelab-mac-46 and it has not failed yet.

@vashworth These tests have run since. please reopen if this is problem is encountered again.

This is still occurring. FYI, it does not seem to happen on devicelab bots, only chromium bots. Here's some recent examples:
https://luci-milo.appspot.com/ui/p/flutter/builders/prod/Mac_x64 hot_mode_dev_cycle_ios_simulator/729/overview
https://luci-milo.appspot.com/ui/p/flutter/builders/prod/Mac module_test_ios/15750/overview

Just a guess, but maybe it has something to do with simulators. All of the tests that I've observed so far having this behavior use simulators

I've also only observed it on bots https://chromium-swarm.appspot.com/bot?id=build800-m9 and https://chromium-swarm.appspot.com/bot?id=mac-476-g140 so far.

Did a little more debugging, so the issue is most likely due to something with Xcode and simulators. It only happens on bot build800-m9 and mac-476-g140.
I trying clearing the Xcode cache on mac-476-g140 and the next time the test ran, it ran fine and did not time out. Example:

https://chromium-swarm.appspot.com/task?id=663a53e5350d7b10 - Test times out (technically I killed it once it was obviously taking longer than expected).
https://chromium-swarm.appspot.com/task?id=663a5d5eafaf5410 - Cleared the cache
https://chromium-swarm.appspot.com/task?id=663a60f5d6330410 - Ran same test and it passes

I'll continue monitoring mac-476-g140, but I don't expect it to fail on that bot anymore.
We should see if we can identify the problem and then automatically try clearing the xcode cache if it is

@ricardoamador I'll leave it up to infra on if you all think it's worth adding a recipe process to try and detect the issue and automatically clear the cache.
We could also just handle this manually as it occurs by manually clearing the cache.
If you do decide to do the automation process, if you do steps like the following below and if the launch step times out after say 5 minutes, then you know it's this problem.
xcrun simctl create "Verify-Xcode-iPhone" com.apple.CoreSimulator.SimDeviceType.iPhone-14
xcrun simctl boot Verify-Xcode-iPhone
xcrun simctl launch Verify-Xcode-iPhone com.apple.mobilesafari
xcrun simctl delete Verify-Xcode-iPhone
I left build800-m9 in it's corrupted state in case we do want to do the automated process so we can have a bot to test with, but probably should do it soon or quarantine the bot since it is affecting prod tests.

@vashworth sorry I meant to follow up earlier. You mentioned that this is something with the simulator/Xcode integration? I am trying to catch up to you on this one... for my information, does this happen after the test has started or is this during the setup process for test?
If it is during the test when we are booting a simulator do we verify that it is up and ready? I have experience with Android and we do this to make sure the simulator is actively ready for testing or the next command after it has booted. Or is that possible? I am not too familiar with the apple side of things.
If this is on Mac OS13 is it reasonable to take a hit clearing the cache each and every time before this is run?
Not for me: it does not happen on devicelab only chromium bots.

So this happens during the test. We have tests that will create, boot, launch a simulator, and run tests on a simulator. From what I can tell, it's booting correctly. When it launches the app, though, it gets stuck. I'm assuming macOS is showing a UI dialog that's preventing the launch from happening. Since we can't VNC to the bot, though, this is just a guess.
I don't think we should clear the cache every time this is run. I think we could do a new setup process before the test runs that basically creates, boots, and launches a simulator (see https://github.com/flutter/flutter/issues/138224#issuecomment-1834559913 for commands) and if the launch times out, then clear the cache. So only clear the cache if we've detected that this problem is going to occur when the test runs. Does that make sense?

@vashworth okay I remember this one now!! I remember running tests before your most recent posts on devicelab with VNC enabled and you are right. It did not fail there.
Yeah I understand what you want to do here. I am trying to land the cache cleanup shortly and can take a look at this in a day or two... Feel free to adjust the priority if this is having a big impact on testing.

FYI looks like this issue isn't exclusive to macOS 13, found it also happens on macOS 12 https://ci.chromium.org/ui/p/flutter/builders/try/Mac plugin_test_ios/24994/overview

@ricardoamador Are there any updates to this bug that can be shared here, or is this resolved?

No, no further updates yet.

@vashworth I have no experience with IOS simulators but do they have popups that you need to interact with? I know we get dialogs with the regular devices when changing versions and such, do the simulators have anything similar?

Simulators can have popups, but seems unlikely that was the issue since clearing the Xcode cache and reinstalling seemed to fix. It was only happening on those 2 bots and now that those bots have had Xcode cache cleared, this will be difficult to validate. (See comment https://github.com/flutter/flutter/issues/138224#issuecomment-1834391082)
I think the steps I described in https://github.com/flutter/flutter/issues/138224#issuecomment-1834559913 would have worked, but again hard to tell now that the issue has gone away.

Removing from ticket queue as this is not a blocker. The flake bot should be able to catch if any new flakes.


Carousel drag issues when used in a react-google-maps InfoWindow or InfoBox

Issue Description
react-google-maps/api provides both the standard Google Maps InfoWindow component as well as a customizable InfoBox component which should mimc InfoWindow's functionality but it "supports several additional properties for advanced styling [see docs]."
I'm trying to display an embla-carousel in an InfoBox but having issues when dragging the carousel. It seems to get stuck dragging back and forth until you click somewhere else (on the map, another marker, etc). On a touch device, this same dragging behavior happens if you slide the carousel and then move the map around while the InfoBox is open.
Test Cases

When carousel is used inside an InfoBox if I try to drag a carousel with the mouse, the carousel continues to drag even after mouse click is released.
When used in an InfoWindow, it seems that the slider works as expected, although you need to resize the browser window to get it to slide (happens in both cases). I've tried calling reInit() in the carousel's useEffect and that does seem to help after resizing the window.

Test URL
CodeSandbox: https://codesandbox.io/s/react-google-mapsapi-infowindowinfobox-embla-carousel-8rgwg

This demo has two markers: one renders with an InfoWindow and one with an InfoBox.

Reproduction steps

Click on marker to trigger popup.
Resize the viewport to get the dragging to respond.
See InfoWindow with bubble and close [x] button will drag and stop when mouse is released.
See InfoBox will get stuck when dragging and mouse is released.

I pulled in embla-carousel's "Basic" example code for this test. It seems like this may be an issue with the InfoBox component, which I've brought up in the react-google-maps slack channel but I thought you might be able to provide some insight on the usage of embla-carousel here. It is possible that it's a poor implementation on my part. I appreciate any help or feedback. Thanks in advance!
Related documentation

Infobox on github
react-google-maps/api docs

Hi Ryan (@hexagoncircle),
Thank you for the well described issues and the CodeSandbox. Regarding the resize and initialization issue, I think some sort of race condition is going on here. Are you sure that the HTML has mounted inside the boxes by the time you initialize Embla Carousel? Because you shouldn't have to call embla.reInit() if the HTML is already in place when initializing Embla the first time. Additionally, when you resize the window, Embla calls reInit() automatically.
For example, there's a domready event listed in the events section (in the docs link you provided). Maybe you could try to pass a boolean prop like isReady to the EmblaCarousel component when the InfoBox is ready? Something along these lines could do the trick:
const EmblaCarousel = ({ slides, isReady }) => {

  return (
    <div className="embla__viewport" ref={isReady ? viewportRef : null}>
      ...
    </div>
  );
};

See InfoBox will get stuck when dragging and mouse is released.

I'm not sure what's happening here. Is the InfoBox preventing the touchend and mouseup event from firing 😕? I'll look into this when I have the time to do so.
Let me know how it goes!
Kindly,
David

I have passed a boolean prop into the carousel as recommended, setting it in the onDomReady prop, and the carousel mounts correctly, transitioning as expected. I'll be sure to update this ticket if I find a way to solve the InfoBox drag issue.
Thank you so much!

Hi again Ryan (@hexagoncircle),
Looking at the documentation, i found the following properties:
disableAutoPan | boolean
Disable auto-pan on open. The default value is false.
enableEventPropagation | boolean
Propagate mousedown, mousemove, mouseover, mouseout, mouseup, click, dblclick, touchstart, touchend, touchmove, and contextmenu events in the InfoBox (default is false to mimic the behavior of a google.maps.InfoWindow). Set this property to true if the InfoBox is being used as a map label.
Maybe one of these are of interest?
Kindly,
David

Hi David,
Thanks for these recommendations. I've tried them both previously in relation to:

See InfoBox will get stuck when dragging and mouse is released.

disableAutoPan is necessary to move the map so that the InfoBox can be pulled fully in view. Setting to false turns it off and the drag issue persists.
enableEventProgagation defaults to false for an InfoBox and mimics the InfoWindow behavior. When set to true, it allows map events beneath the box, so the map will move when I drag the carousel. Although, when doing this, the carousel drag no longer gets stuck! One thought I had was to disable events on the map while hovering an InfoBox. That does feel a bit hacky, though.

Since the carousel works in the InfoWindow, maybe this is more of an issue with the InfoBox implementation and how it handles certain events (maybe it has fallen behind some of the InfoWindow updates).
If you don't have any other ideas and you don't see this being an issue with the Embla implementation, feel free to close this issue. I can report on a workaround should I figure one out.
Thanks again for the amazing work you put into this library!

Hi Ryan (@hexagoncircle),
Thank you for taking time to share that.

Since the carousel works in the InfoWindow, maybe this is more of an issue with the InfoBox implementation and how it handles certain events (maybe it has fallen behind some of the InfoWindow updates).

I think this could be the case, that the InfoBox kills touchend and mouseup events outside its boundaries. But I don't know why 😕.
I'm closing this issue for now, but feel free to open it again if you find something that indicates that this is a potential bug, and we'll take it from there.
Best,
David

Hi @davidcetinkaya - Adding a follow-up comment for anyone else that may stumble on this issue. This bug is not related to embla-carousel as we have confirmed.

I think this could be the case, that the InfoBox kills touchend and mouseup events outside its boundaries. But I don't know why 😕.

You are correct about that. I'm not sure why those particular two are squashed either.
One way to resolve this issue would be to remove touchend and mouseup from the "cancel event propagation" array on this line in the infobox.js file.
To anyone that attempts to do this, approach with caution and test thoroughly! My guess is that it's possible some other touchend or mouseup listener on the map underneath may get triggered when interacting within the Infobox but I haven't experienced issues in my initial testing. It would be great to see google-maps-api welcome container style customizations to their Info Window someday.
If I discover anything else, I'll be sure to update my comment. Thanks!

Hi Ryan (@hexagoncircle),
Thanks a lot for sharing this. Nice digging 👍. Out of curiosity, have you created an issue to discuss why the infobox has these listeners that are causing this?
On a side note
Check out the latest releases if you haven't done so yet. I think they turned out pretty well:

v4.2.0
v4.3.0

Best,
David

No problem, @davidcetinkaya! This isn't so much an issue with that React library as much as it is with the original Infobox implementation. The project has been archived in the v3-utility-library but its README states:

This library is community supported. We're comfortable enough with the stability and features of the library that we want you to build real production applications on it.

I could try opening an issue against it to see if anyone can provide feedback.

This issue is the only one I came across that is related to my issue here but it went stale and was closed automatically.
This issue discusses an old conflict with the map dragend event while hovering an Infobox.

My guess was correct: If you click + drag the carousel and let go of it outside of the Infobox, it will trigger the map mouseup event.

This click + drag experience also happens with the InfoWindow so I think this interaction is expected. Try it again in my demo sandbox. Drag the carousel and release the mouse outside of the popup container.
I don't love the following idea since it's a bit hacky, but you could track a boolean that only allows the map click callback if a mousedown event reaches the map. I assume the same could be done with a touchstart if necessary (I have not tested this on a touch device yet)
let enableMapClickCallback = false;

map.addListener('mousedown', () => {
  enableMapClickCallback = true;
});

map.addListener('click', () => {
  if (enableMapClickCallback) {
    // Do some neat stuff...
    enableMapClickCallback = false;
  }
});

So yeah... that's an option 😬

Check out the latest releases if you haven't done so yet. I think they turned out pretty well

v4.3.0 breakpoint options – That's a great addition! Does this replace default options or only update the ones declared in the media query? Honestly, if drag on desktop isn't entirely necessary and assuming you have buttons to slide the carousel content, you could make the carousel in an Infobox drag-free on non-touch devices. I think something like this might work:
@media (any-hover: hover) {
  .infobox .embla:before {
    content: '{
      "draggable": false
    }';
  }
}

Hi Ryan,
I see. Nice digging from your side 👍. I just tested the following and can confirm that this is the case as you mention:

This click + drag experience also happens with the InfoWindow so I think this interaction is expected.

Regarding the pseudo options
From the docs:

The pseudo options object is always given the highest priority. It will be merged with the options passed to the EmblaCarousel initializer, and if any options are in conflict, the pseudo options will have precedence.

I hope this helps 🙂. Thanks for your efforts!
Cheers
David


[WebUI] Accommodate long free-form text in InputBarComponent

Perhaps enlarge the InputBarComponent to two rows when there is text overflow.

This is now fixed in the [webui-2] branch (https://github.com/caisq/SpeakFaster/tree/webui-2/webui)


Incorrect requirement listed

https://github.com/boneskull/midnight-smoker/blob/1beeec26fa716e7bec30602d00b19c7c0e5bf480/README.md?plain=1#L48
This is incorrect. It seems to me that midnight-smoker does not work with Node v14 because it requires npm@7 starting in https://github.com/boneskull/midnight-smoker/compare/v1.1.1...v1.2.1
The version of npm that ships with Node 14 is "6.14.18". Node 16 ships with npm "8.19.4".

Well, it's right and it's wrong.  We need Node.js v14.17.0 or greater.  But the version of npm is not locked to the Node.js version (barring anything npm no longer supports, like node <v14.17.0).  It will run fine with a newer version of npm under Node.js v14.17.x.
That said I'm probably going to drop support for Node.js v14.x soonish.

Also, unsure what version of README.md you're quoting from, since it's updated in the current main branch.

I was probably viewing an old tag tree because I was finding where the npm requirement was added.
In my view, the npm version should be tied to the Node version. The two ship together to form one LTS bundle.
I agree that 14 should be dropped soon. But it was effectively dropped in a minor/patch release with the npm engine requirement.


Test numpy indexing on numpy branch(DO NOT MERGE)

Description
Adding numpy indexing and fixing NDArray indexing.
Work still in progress and this PR aims to use CI to expose potential bugs.

Closing this PR now since #15942 has been merged.


#538 Automatically check if node_modules/typescript/lib exists

Fixes #538

Tested on macOS Mojave, can't test it on anything else
Inputs are welcome 😄

This would be a great improvement.

Yeah, I agree - I'd like to get this in.
I'm a tad apprehensive about it being prioritized over the bundled version. vscode, vs and flow-for-vscode for example all have an option which lets you choose to have this version be prioritized.
Any chance we can have this as a setting somehow? The gaol being specifically to make people in to a project's arbitrary code being executed when they open the editor.

Make this feasible please!

After manually cloning my typescript package in packages folder after deleting it completely made it working seamless now!!
react jsx works all good for me as on this date, happy to have this plugin thanks team!!

Yikes!!!!!!!!!!!!

almost forgot about this, problem is that I have little to no knowledge on how to do this, but just want to confirm, only issue atm is that it needs to be added as a configurable option and not as a default behavior right ?

Yeah, allow this to be opt-in and it's reasonable to me 👍🏻

almost forgot about this, problem is that I have little to no knowledge on how to do this, but just want to confirm, only issue atm is that it needs to be added as a configurable option and not as a default behavior right ?

It juat works like that way, like simply cloning the way its mentind in docs..., and no need to configure anything by hand.., if u want i can show my settiglngs file like how its configured right now in my sublime.., should i ?.

Yeah, allow this to be opt-in and it's reasonable to me 👍🏻

sorry now that I remember what was being achieved here, this doesn't need an opt-in configuration, as the current configuration only allow to pass an absolute path to typescript, so I think since people that are already using the plugin are split into two groups:

using the plugin typescript (not specifying tsdk_path) -> will be using local tsdk if it exists and if not they will use the plugin tsdk
using a specified tsdk_path -> not affected at all by the PR
and it falls back to the one fetched inside the plugin itself, and I think most people would think that it goes.

I think your concern is about group number 1, but I was one of those people and thought that this work like other editors it uses:

project(local) node_modules
if not found -> global node_modules
if not found -> plugin typescript

I am not saying your point is not valid but just that with how the users are currently using the plugin, and maybe there is something else I am missing but I think this is an improvement, as users would expect their project/local typescript to be used by the plugin, as they either specifically installed it for tooling or building the code, and I think in both cases the plugin should use that typescript version, and again maybe I am missing something or the whole point actually

I don't disagree with the idea that someone could expect that, but I'm more worried from a security perspective. You could clone a repo with a poisoned version of the TypeScript dependency and simply opening that repo in Sublime would trigger the eval of whatever code they want.
If a user intentionally decides they think this trade-off is worth it, that is OK. It's not really OK by default.
I believe how this works in vscode is that if a downloaded project declares it wants to to use a local version of TypeScript in its settings, then you get a popup asking if you want to switch from the bundled version to the local copy.

Amazing..!.
On Thu 27 May, 2021, 3:51 PM lastthyme, @.***> wrote:

@.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TypeScript-Sublime-Plugin/pull/720#pullrequestreview-670006465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHQAJY22LB2P5YAJLRXBE4DTPYMLJANCNFSM4HOEO7LQ
.


Adjust doc title

This will remove the  Quarkus  prefix in the documentation title

Motivation? Should all the other instances (README, etc.) be changed?

@kdubb the motivation is to make the left menu look nicer in https://docs.quarkiverse.io/. There is no immediate need to change the other instances.


Rene Seghaye 25/10/2022

Initially, our software publisher will only integrate access to the LOINC codification into our environment (excluding the SNOMED codification). Is this solution sufficient for the current project?

Loinc -> need to support Retam (Belgian LOINC edition)
For this standard all SNOMED codes are part of the standard, so no own SNOMED replication/access is necessary


The default implementation of PSR7 disappeared

Hey 👋🏻
https://github.com/shopware/recipes/pull/125 introduced a custom recipe nyholm_psr7.yaml that overrides original one.
Original recipe copies yaml with aliases that create services with default PSR implementations
(https://github.com/symfony/recipes/blob/main/nyholm/psr7/1.0/config/packages/nyholm_psr7.yaml)
I use these aliases in Shopware's plugin, and they are the default PSR implementation Psr\Http\Message\RequestFactoryInterface Psr\Http\Message\StreamFactoryInterface
Is there a chance to revert this back?
Cheers!

Thank you 🙇🏻


delay in clearing diagnostic with quick fix

When applying a quick fix in response to an inline compiler warning/error, the warning/error isn't immediately cleared even though the edit is applied immediately:

Is there a way to specify in the quick fix which diagnostic is resolved.

Agreed.


UI: Model Gallery: indicate trust_remote_code

Absolutely nothing against @fakezeta , but when I saw #2249 it occurred to me that we need to be indicating to users somehow in the model gallery user interface routes which models have trust_remote_code on, as that's a distinct security difference that may matter to some people.
I think we just need to add some code to core/http/routes/ui.go to check for that specific property on a model, and add a css class of some type if so.

(Bug tagged because I consider this a security flaw?)

I agree with @dave-gray101: In the meanwhile I can add the tag Remote Code Enabled.
What do you think of it as a workaround?

I created this issue because I don't think that this is even worth holding your PR up - it's something that needs to get added before the gallery grows too large to fix it with stuff like that :)

But I completely agree with you.
Sadly Phi-3 requires this flag and downloads the file configuration_phi3.py directly from HF.
It has the Model Configuration code and the Rope Scaling validation (this is how it reaches 128k of context).
By the way I'm too tired today and Yaml got my head.