Move "Continue Setup"/"Start Over" confirmation to ReimbursementAccountPage

@nkuoch
cc @tgolen @MariaHCD
Details
Moves the "Continue" or "Start Over" to ReimbursementAccountPage, where we do the VBBA fetch.
Solves two bugs:

Race condition between "RestartBankAccountSetup" and Fetching VBBA before Connect Bank Account flow
Even if you have a VBBA in SETUP, we won't show the Continue/Start-Over confirmation if you first log in.

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/238317
Tests / QA Steps

Create workspace
"Connect Bank Account" - Verify that you immediately go to Bank Account Step

Use SO to get to the "Personal Information" step
Exit flow
Return to Workspace -> Connect Bank Account
Verify that you now see the "Continue/Start-Over" confirmation modal

Click "Continue Setup" and verify it takes you back to the Personal Information step
Exit flow
Go to Workspace -> "Pay Bills"
Click "Connect Bank Account" and verify that you see the "Continue"/"Start-Over" confirmation
This time click "Start Over"

Verify that you are optimistically (quickly) navigated to BankAccountStep

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web
https://recordit.co/GI7RlTtLeg
Mobile Web - Chrome
https://recordit.co/J70EQUkLMA
Mobile Web - Safari
https://recordit.co/DJ085bSVzs
Desktop
https://recordit.co/KTb5Sk6yN5
iOS
https://recordit.co/siZkfFLH4E
Android

I know the file name is bad. Thinking about renaming it to ContinueSetupStep

Updated! Should be ready for final review

We need a c+ review, right?

This isn't 100% necessary, but someone else will need to fill out a PR Reviewer Checklist if there is no C+.

someone else will need to fill out a PR Reviewer Checklist if there is no C+.

I can do it

Thanks @MariaHCD . So in the future what label do I add to get a C+ assigned?

iOS / native
https://user-images.githubusercontent.com/12268372/200607966-683ce187-1409-4b5e-937f-9eabbf79a0ad.mp4
Android / native
https://user-images.githubusercontent.com/12268372/200604001-13410fc8-a13d-49b2-a157-be69550555c6.mov
iOS / Safari
https://user-images.githubusercontent.com/12268372/200607944-db9c4395-36ef-4b59-9ce2-b75f8afe21d4.mp4
Android / Chrome
https://user-images.githubusercontent.com/12268372/200603987-062c3036-88c9-4583-a5d5-46869a26f30a.mov
MacOS / Chrome
https://user-images.githubusercontent.com/12268372/200603966-288bdafc-f0f5-4ac4-bb29-a7b81b1e05a0.mov
MacOS / Desktop
https://user-images.githubusercontent.com/12268372/200608827-e9453e75-107d-44f1-a0c2-ac1fc11b8a4d.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @MariaHCD in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

So in the future what label do I add to get a C+ assigned?

If you use pullerbear, then it should assign a C+ automatically.

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Removing Emergency label. It's old


Confuse/Suggestion

Why not use this method on node to read download files？

it's ok. close it.

@link89 maybe should also add method to delete file


Prefer where {T} to where T?

As far as i can am aware, BlueStyle has no opinion on this.
even the example code in this style guide itself is inconsistent, sometimes using where {T} and othertimes where T (or where {T <: Int} and othertimes where T <: Int).
We could stick with having no preference, however, for the sake of running a formatter (https://github.com/domluna/JuliaFormatter.jl/issues/283, #7 ), what should a formatter do?
We have four options (to my mind, anyway)

always prefer braces: where {T} to where T
always prefer NO braces: where T to where {T} (when valid)
sometimes prefer NO braces (in a subset of cases of the valid cases, based on some rule)
do nothing

Option (4) is "do nothing". This isn't a great option for 2 reasons: (1) stylistically, we probably want a code-base to be consistent on this, it's one thing to say "either is fine", and another to say "both is fine". (2) effort-wise, the formatter can/does already fix these cases, so i see no reason to add functionality to leave a code-base less consistent.
I see no reason to come up with a subtle rule here (we've survived without it so far), so let's not do option (3), which is the most complicated.
This leaves options (1) and (2). Since we have no strong preference here (based on the current style guide), i say we stick with the decision made in https://github.com/domluna/JuliaFormatter.jl/issues/53 and go with option (1) -- it's the more common pattern in Julia Base, and it's what JuliaFormatter does right now -- so for the sake of the formatter,  prefer where {T} to where T.

My personal preference when writing code is no braces for long-form functions with a single typevar, and braces otherwise. But for the purposes of this decision, I vote Option (1).
Also Option (2) would lead to some cases I consider unfortunate:
Option 1:
function foo(::Type{A}) where {T <: Integer, A <: AbstractArray{T}}
    return A
end

Option 2:
function foo(::Type{A}) where A <: AbstractArray{T} where T <: Integer
    return A
end

I don't know anyone who uses the latter form in that scenario.

I typically use Option (3) which is to prefer braces but exclude braces when only defining a single type parameter.

prefer braces but exclude braces when only defining a single type parameter

To clarify this would be:
# Yes
f(x::T) where T = ...

# No
f(x::T) where {T} = ...

# Yes
f(x::T) where T<:Integer = ...

# No
f(x::T) where {T<:Integer} = ...

# Yes
f(x::T, y::S) where {T,S} = ...

# No
f(x::T, y::S) where T where S = ...

I could be onboard with that... i think that's how i tend to write things :)

I wouldn't say using curly braces all the time is wrong just not preferred:
# Yes
f(x::T) where T = ...

# Ok
f(x::T) where {T} = ...

# Yes
f(x::T) where T<:Integer = ...

# Ok
f(x::T) where {T<:Integer} = ...

# Yes
f(x::T, y::S) where {T,S} = ...

# No
f(x::T, y::S) where T where S = ...


Incorrect namespace defined across documentation.

The namespace for importing accord project files is specified as 'ord.accordproject' in many places rather than 'org.accordproject'
One example is here:
https://docs.accordproject.org/docs/ergo-stdlib.html

Hello, can I take this one for Hacktoberfest for a pair programming session?
Also, thank you for creating very detailed issues and a highly descriptive contributing guide. 🎉 ✨

hi can i take this up?
i'll be sending a PR in a while

@carolinaknoll oh! i couldn't see activity on this issue the past week so i thought of making a PR.
i already completed it though. let @adrianffletcher merge your PR and just leave mine as is.

@carolinaknoll very sorry I didn't see your post! Feel free to put in a PR for this issue, or take on another one. Let me know which you'd prefer, and I'll assign you to the issue.

Fixed by @oorjitchowdhary in #97


Can not login after rake service:all

Issue Description
Follow the READEM, deploy the all services via rake service:all, but can not login on www.<domain> with the default seeds user/password, it reports error message Oups! Error occurs, please try again later.

Version
0.1.19

Check Browser console logs. May be you have not setup ssl correctly

@lsethi Yes, you are correct, it reports:
xhr.js:173 Mixed Content: The page at 'https://www.<domain>/login' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://www.<domain>/api/v2/barong/identity/sessions'. This request has been blocked; the content must be served over HTTPS.

But, how can I setup ssl correctly?

@mengzyou  You need to edit  following config files and https instead of http.
microkube/config/frontend/env.js
microkube/config/frontend/tower.js
window.env = {   API_URL: 'https://www.<domain> };

@lsethi-xoriant Thank you! I tried to edit those 2 files, but after I executed rake service:all[start] it will re-render those 2 files, so finally I changed files under microkube/templates/config/frontend/, it works.

hello I have this problem to but i notice ( 'https://www. }; ) and i have some problems with editing /etc/hosts because  www.domain.local confuses me ( .local ) part, can u help me? my domain is www.myttcoin.com I am not sure what to put in the /etc/hosts or here


Feat:Social Integration

Describe the feature
Reader can share his favourite book on social media this will helf in marketing of website. Also rating features could be added.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hello!! @anuragverma108 please assign me this task..

Assigned!
Make sure to attach before & after screenshot in your PR.
Make sure to star the repo before working on it! Happy open-source contributing!


Add rubocop to rake default task.

Since we are at a more evolved stage of the code, we can start running rubocop as part of the default rake task.
Note that this will now cause Travis CI to fail if there is a rubocop violation.

Coverage remained the same at 100.0% when pulling cb3f8cbdfc160d07289c3bbf4ae86526e7ebcf5b on add_rubocop into 799c2ec18135a8117501339d69df4ec805e0dd7f on master.

 Great just fixed 1 issue,  1 to go.
 Consider refactoring this complex block. Optioneer::Optioneer#find_option


Port request: LLVM

The addition of a port for LLVM Core would be splendid - personally I'm not too bothered about the other projects (LLVM, LLDB etc), but other people might be?

Please do not forge about Clang too.
And may be even Cling ?

C:\Program Files (x86)*Microsoft Visual Studio\2017\BuildTools*\VC\Tools\ClangC2\14.10.25903\bin\HostX64/\X86 *clang.exe*
arm  clang.exe  x64  x86
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\ClangC2\14.10.25903\bin\HostX64>clang.exe --version
clang with Microsoft CodeGen version 3.8.0
Provided as - is without support
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\ClangC2\14.10.25903\bin\HostX64

fixed by #1388 @ras0219-msft

OP wanted the LLDB package, could it be included as well?


Module datastore (from "terraform-aws-modules/rds/aws") does not support Terraform version 0.12.2

I got an error in the very first step listed below when trying to terraform init,
Initializing modules...
Downloading terraform-aws-modules/rds/aws 2.14.0 for datastore...
- datastore in .terraform/modules/datastore
- datastore.db_instance in .terraform/modules/datastore/modules/db_instance
- datastore.db_option_group in .terraform/modules/datastore/modules/db_option_group
- datastore.db_parameter_group in .terraform/modules/datastore/modules/db_parameter_group
- datastore.db_subnet_group in .terraform/modules/datastore/modules/db_subnet_group

Error: Unsupported Terraform Core version

Module datastore (from "terraform-aws-modules/rds/aws") does not support
Terraform version 0.12.2. To proceed, either choose another supported
Terraform version or update the module's version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.

I pinned version = "~> 2.0" in the module, does anybody know there is any obvious reason causing this?
Thanks!

Hi @dukelv ,
Module version 2.14.0 has been downloaded due to your pinned requirements correctly.
The module requires Terraform 0.12.6 or newer as specified here - https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/versions.tf#L2
Make sure that you upgrade Terraform and try it again.

I see thanks for the quick response @antonbabenko !


clean up enum and comma in annotation

when there is more than one enum in the annotation and it's being separated by comma piranha is keeping an extra comma after the cleanup.
code to do the cleanup by STALE_FLAG as treated:
@ToggleTesting(treated = {TestExperimentName.STALE_FLAG, TestExperimentName.OTHER_FLAG})
current output:
@ToggleTesting(treated = {, TestExperimentName.OTHER_FLAG})
expected output
@ToggleTesting(treated = {TestExperimentName.OTHER_FLAG})
The enum to be removed could be at the beginning, in the middle or at the end. For the first two cases we should remove the comma that is present after the enum and for the third case we should remove the comma that is present before the enum.
For the scenario when there is only one enum we shouldn't do anything else that what the code is currently doing.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks a lot for your contribution :)
I am merging the PR.

@valulucchesi I was wondering if this new implementation could also handle something like this ?


⚠ Bofrost.be has degraded performance

In d06fd81, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1454 ms

Resolved: Bofrost.be performance has improved in fa703ad after 2 hours.


NaN equality tests for GEOS 3.10

See #233 for a discussion. For GEOS 3.9 and before, we were able to construct a POINT (nan nan). In GEOS master, this is not possible anymore and it transforms to a POINT EMPTY. This caused some of our tests to fail.
These tests just use a point because it is the simplest geometry. Now I updated the tests so that they use linestrings and everything passes on my machine.

I added the test as you suggested.
Also I used preprocessor !GEOS_SINCE_3_10_0 directives to disable my self-built POINT EMPTY to POINT (nan nan) conversion on GEOS >=3.10. Everything still checks out.

I'm having a little bit of a hard time following the logic for version-guarding (via !GEOS_SINCE_3_10_0) some things but not others.
For example, why are geometrycollection_has_point_empty and has_point_empty version-guarded but not multipoint_has_point_empty?  Perhaps more can be added to their individual docstrings to indicate that they are only needed for GEOS < 3.10.0?  The leading comment above the version-guard is about conversion of points, so it isn't as obvious as to how that applies to these conditional tests.

I'm having a little bit of a hard time following the logic for version-guarding (via !GEOS_SINCE_3_10_0) some things but not others.
For example, why are geometrycollection_has_point_empty and has_point_empty version-guarded but not multipoint_has_point_empty? Perhaps more can be added to their individual docstrings to indicate that they are only needed for GEOS < 3.10.0? The leading comment above the version-guard is about conversion of points, so it isn't as obvious as to how that applies to these conditional tests.

These functions are also used for fixing an issue with empty points in WKT strings, which has not been fixed in GEOS master yet. So that is why I pulled multipoint_has_point_empty outside of the version conditional.


Trying to import CSV file into label studio

Hello, I just discovered label-studio today and I am currently stuck.
I have a csv file with the columns = [col1, col2, ..., col13] and about 36000 rows. Now, each row needs to get classified based on the values in the columns (either pass or fail). The cell values are all either text or boolean. I read through the docs but couldnt really find how to do that. I tried adding each column as a text field, but I think the interpretation in label-studio of columns is different (Not sure though, I don't really understand the docs there). Everytime I tried using a template or custom template I get an sql- too many variables error.
I hope somebody can help me, thank you all so much :)

@Cheaterraptor Hello, please show your labeling config and sample of CSV data.

Thank you for your answer :)
A sample of the csv data is:
sample.csv
I don't have a labeling config because I did not manage to import it the way I wanted to. I just want each row as a task and then display the different values in a table. If I see the information of the row (task) to label it either 1 (accept) or 0 (decline).

Looks a little bit weird.
It works well with your sample.csv and this labeling config:
<View>
  ,,identity verified,keywords,budget_min,budget_max,type,upgrades,bid_count,bid_avg,status

  <Text name="text1" value="$rating"/>
  <Text name="text2" value="$payment verified"/>
  <Text name="text3" value="$identity verified"/>
  <Text name="text4" value="$keywords"/>
  <Text name="text5" value="$budget_min"/>
  <Text name="text6" value="$budget_max"/>
  <Text name="text7" value="$type"/>
  <Text name="text8" value="$upgrades"/>
  <Text name="text9" value="$bid_count"/>
  <Text name="text10" value="$bid_avg"/>
  <Text name="text11" value="$status"/>

  <View style="box-shadow: 2px 2px 5px #999;                padding: 20px; margin-top: 2em;                border-radius: 5px;">
    <Choices name="sentiment" toName="text1" choice="single" showInLine="true">
      <Choice value="Positive"/>
      <Choice value="Negative"/>
      <Choice value="Neutral"/>
    </Choices>
  </View>
</View>

If you have this error only using a large import file, it might mean two things:

your file is corrupted
you need to use postgres instead of sqlite (https://labelstud.io/guide/storedata.html#PostgreSQL-database)

Wow, that works perfectly. Thank you so much!! I think my fault was that my file was too big :)


unable to set temp directory when save dir and temp dir not in same partition, because os.replace doesn't support

unable to set temp directory when save dir and temp dir not in same partition, because os.replace doesn't support.
Exception in thread Watcher-3---(--):
Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/home/--/workspace/github/showroom/showroom/core.py", line 487, in run
    self.download.wait()
  File "/home/--/workspace/github/showroom/showroom/downloader.py", line 187, in wait
    self.move_to_dest()
  File "/home/--/workspace/github/showroom/showroom/downloader.py", line 269, in move_to_dest
    destpath = self._move_to_dest(self.outfile, self.tempdir, self.destdir)
  File "/home/--/workspace/github/showroom/showroom/downloader.py", line 287, in _move_to_dest
    os.replace(srcpath, destpath)
OSError: [Errno 18] Invalid cross-device link: '/tmp/active/200621 Showroom - Oshi 180426.mp4' ->
   '/home/--/Downloads/Showroom/2020-06-21/Oshi/200621 Showroom - Oshi 180426.mp4'

i'm using seperated partitions and wish to set temp dir on /tmp on sda1 and save dir on /home on sdb1, but i couldn't do that, cuz of what i wrote above.
hope to be changed shutil.move rather than os.replace, then it will be fixed i think, if you don't mind, please.

Honestly, you should probably just make sure your temp and save dir are the same. Yes, changing os.replace to shutil.move would be easy and is probably what I should have been doing anyway, but same device moves are near-instantaneous. Copying from one device to another is not. The recording thread will be held up during this transfer, and if it's a false stop that means you're missing part of the recording while it copies over.

I've gone ahead and implemented this with #3f1a509d5d525add37f922fc72b2f319a5d60bd3 , but I'm going to leave the issue to remind myself both to address it on the hls-python branch, and to do something to avoid the copy blocking.

I've gone ahead and implemented this with #3f1a509d5d525add37f922fc72b2f319a5d60bd3 , but I'm going to leave the issue to remind myself both to address it on the hls-python branch, and to do something to avoid the copy blocking.


Follow up from CMSIS-NN Pooling failure

The PR addresses comments by @ekalda and @manupa-arm  from  https://github.com/apache/tvm/pull/9682 and https://github.com/apache/tvm/pull/9531. Those issues were about Pooling support in CMSIS-NN and fix for a network failure in Conv2D partitioning.

Could you folks @ekalda @manupa-arm take a look at it?

Thanks! @ashutosh-arm


colormap Remove render method from each image/slice.

The logic of render (to decide which method to use) will be handled by cornerstone instead.

Looks good to me.


Add Shuttle multithreading test infrastructure

Problem
The program cache has multiple synchronization mechanisms without any systemic test infrastructure. Although PR #1471 introduced an adhoc test for program cache, it is insufficient for finding issues in the code.
Summary of Changes
I want to adopt shuttle to run specialized multithreaded test in the CI. In order for it to work, all sync, rand and thread imports must come from shuttle. These are the changes:

I created another create in the monorepo called solana-type-overrides, which has a CFG feature to override the default imports.
In the necessary crates for the program cache test (except for rBPF), I changed the imports to those from solana-type-overrides.

@pgarg66 and @Lichtso Can I have your approval again? I just removed the publish=false flag from Cargo.toml.

Hi I'm here to bikeshed the new crate name. Someone in a similar situation down the line is going to see solana-type-overrides and think that they should pile their stuff into this crate, when they should probably make a new crate.
I vote for solana-shuttle instead

I would encourage just making a new crate when you add Loom instead of agglomerating different dependencies in one crate


Bug: Unable to send event to child when using respond after invoking Promise in child machine

Description
I tried using the respond action from a spawned machine, that itself invokes a promise. This results in an error Unable to send event to child 'invokedPromiseOfChildMachine' from service 'child-machine'.
Thus using sendParent works.
Expected result
Same as when using sendParent.
Actual result
Unable to send event to child 'invokedPromiseOfChildMachine' from service 'child-machine'.
Reproduction
https://codesandbox.io/s/xstate-child-machine-promise-respond-cijipq
Additional context
No response

respond responds to the actor that has sent an event - it's not the same as sendParent. You are receiving a done event from that invokedPromiseOfChildMachine and you are trying to respond to it (and not to the parent of the child-machine. This doesn't make sense because that promise actor is already done itself and has been removed from the internal data structures of the child-machine. As a promise actor it also doesn't really accept any events to responding would be a noop anyway.

Thanks for the clarification!
Makes perfect sense now, once I managed to understand it.


Use task actions to fetch used segments in MSQ

https://github.com/apache/druid/pull/15220 Introduced a new RetrieveSegmentsToReplace action to be used in the DruidInputSource.
This PR lets the MSQ Controller use this action in ControllerImpl#makeDataSegmentTimelineView, to allow a consistent set of segments to be returned, especially with a REPLACE lock.

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

@AmatyaAvadhanula , are more changes pending in this PR?

@kfaraz, yes, there are several failing tests which need to be fixed.


libsvm/svm not found

here is what I try:
base) brentp@lorax:~$ rm -rf ~/.nimble/pkgs/libsvm-0.1.3/
(base) brentp@lorax:~$ nimble install libsvm
Downloading https://github.com/genotrance/libsvm using git
Setting up Git repo: https://github.com/cjlin1/libsvm
Pulling repository
Processing libsvm/svm.h
Generating libsvm/svm.nim
  Verifying dependencies for<EMAIL_ADDRESS>   Warning: No nimblemeta.json file found in /home/brentp/.nimble/pkgs/mosdepth-0.2.8
      Info: Dependency on nimgen@>= 0.4.0 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on c2nim@>= 0.9.14 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on regex@>= 0.10.0 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on unicodedb@>= 0.7.2 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on unicodeplus@>= 0.5.0 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on unicodedb@>= 0.7 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS> Installing<EMAIL_ADDRESS>   Success: libsvm installed successfully.

(base) brentp@lorax:~$ cat x.nim
import libsvm
echo LIBSVM_VERSION

(base) brentp@lorax:~$ nim c -r x.nim
Hint: used config file '/home/brentp/src/nim/config/nim.cfg' [Conf]
Hint: used config file '/home/brentp/src/nim/config/config.nims' [Conf]
Hint: system [Processing]
Hint: widestrs [Processing]
Hint: io [Processing]
Hint: x [Processing]
Hint: libsvm [Processing]
/home/brentp/.nimble/pkgs/libsvm-0.1.3/libsvm.nim(1, 15) Error: cannot open file: libsvm/svm

works for me now. thanks.


Fix broken link.

Hi, I was reading the README and found a RubyForge link. Since it doesn't exist anymore, I changed the link to point to rubydoc.info instead.

Thanks!

No problem, thank you for merging!


chore: Update from _rust/main template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.005%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
3700

Relevant Lines:
5522

💛  - Coveralls


Improve the CommandHelper class

Question
Answer

Issue or Enhancement
Enhancement

License
MIT

What's in this PR?
Includes a new improved and fully documented CommandHelper class inside the src/Helpers folder. Summary:

New src/Helpers/CommandHelper class in replacement of src/Http/Helpers/CommandHelper.php.
The new class is fully covered by tests.
All the artisan commands where changed to use the new class.

Checklist

[x] I tested these changes.

The new CommandHelper class is fully covered by a new set of tests. Also, I have quickly tested the artisan commands on a fresh installation of Laravel without any problem. Anyway, it will be nice that someone give a test to these changes.
Scrutinizer Summary
Notes
The next two methods from the CommandHelper class:

copyDirectory()
compareDirectories()

accepts an array $ignores of patterns to files to ignore. These patterns can be fully file names (file.ext), use wildcards (file.* or *.ext) or even use regular expressions (regex:@file[1|2].*foo@). With this feature there is no need to use extra parameters as the old $ignore_ending. The next method contains the logic to decide if a file should be ignored:
/**
 * Check if a file is included in a set of ignored file patterns.
 *
 * @param string $file The file to check
 * @param array $ignores Array of file patterns to be ignored
 * @return bool
 */
protected static function isIgnoredFile($file, $ignores)
{
    foreach ($ignores as $pattern) {
        $match = Str::startsWith($pattern, 'regex:') ?
                 preg_match(Str::substr($pattern, 6), $file) :
                 Str::is($pattern, $file);

        if ($match) {
            return true;
        }
    }

    return false;
}

@Shidersz travis throws an error, because the method Illuminate\Filesystem\Filesystem::ensureDirectoryExists does not exist in Laravel 6.x.
https://travis-ci.org/github/jeroennoten/Laravel-AdminLTE/jobs/702751012
Can you please fix that issue?

@lacodimizer Yea, sure, I'm going to fix that tomorrow. For some reason I don't see any more the Travis build checks on the Pull Requests. Since some time ago I only see Scrutinizer and StyleCI checks only.


Fix issue #1096

This is a fix for #1096

FWIW this code should be deprecated to use locking_resource using hadoop_service is not recommended.


integration: fix the two-images-one-manifest test

Hello @maiamcc,
Please review the following commits I made in branch nicks/skip:
f2d1edf8f86a53ec42b8b4a7bb6a6bc8dc1d996f (2019-10-30 16:00:01 -0400)
integration: fix the two-images-one-manifest test

can you explain what the bad behavior was that you fixed?

sure, this comment has the deets
https://github.com/windmilleng/tilt/pull/2464/files#diff-037d59c9984c9789852b0cef0c6f8ca9R61

ya, exactly. "Pod is ready" != "tilt knows the pod is ready"


Improve stopDev robustness when the dev server is stuck

Try fix #280

@alexkolson I've tried to improve the algo if you could give it a try when I release


Precicts remove invalid violation and precinct data

This commit removes invalid violation code and precinct data
Updates graph to timing analysis
Signed-off-by: Sudhakar M K<EMAIL_ADDRESS>

Looks fine to me


v1.0.3

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@fd7b627). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage        ?   81.25%
=======================================
  Files           ?      353
  Lines           ?     3303
  Branches        ?      492
=======================================
  Hits            ?     2684
  Misses          ?      618
  Partials        ?        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Nil essentials

nil.sol file, nil library and functions like async_call were renamed according to Solidity naming conventions. So now it is Nil.sol, Nil and asyncCall.


Extend nickname expiration to 20 weeks

Update our nickname expiry policy from 10 to 20 weeks in the routine
case.

For those following along at home, this PR should land 4 Dec 21.


catkin build err:PointVisual.cpp:9: /usr/include/OGRE/OgreVector3.h: In member function 'Ogre::Vector3 Ogre::Vector3::perpendicular() const': /usr/include/OGRE/OgreVector3.h:582:20: error: implicitly-declared 'constexpr Ogre::Vector3::Vector3(const Ogre::Vector3&)' is deprecated [-Werror=deprecated-copy]

ROS:noetic
ubuntu:20.04
when catkin build -j3
[ 50%] Linking C shared library /home/taimi/ref/ws_quad_ctrl/devel/lib/libosqp.so
In file included from /usr/include/OGRE/OgreMatrix3.h:33,
from /usr/include/OGRE/OgreNode.h:34,
from /usr/include/OGRE/OgreSceneNode.h:33,
from /usr/include/OGRE/OgreSceneManager.h:37,
from /home/taimi/ref/ws_quad_ctrl/src/whole_body_state_rviz_plugin-master/src/PointVisual.cpp:9:
/usr/include/OGRE/OgreVector3.h: In member function 'Ogre::Vector3 Ogre::Vector3::perpendicular() const':
/usr/include/OGRE/OgreVector3.h:582:20: error: implicitly-declared 'constexpr Ogre::Vector3::Vector3(const Ogre::Vector3&)' is deprecated [-Werror=deprecated-copy]
582 |             return perp;
|                    ^~~~
/usr/include/OGRE/OgreVector3.h:134:25: note: because 'Ogre::Vector3' has user-provided 'Ogre::Vector3& Ogre::Vector3::operator=(const Ogre::Vector3&)'
134 |         inline Vector3& operator = ( const Vector3& rkVector )
|                         ^~~~~~~~
/usr/include/OGRE/OgreVector3.h: In member function 'Ogre::Quaternion Ogre::Vector3::getRotationTo(const Ogre::Vector3&, const Ogre::Vector3&) const':
/usr/include/OGRE/OgreVector3.h:661:27: error: implicitly-declared 'constexpr Ogre::Vector3::Vector3(const Ogre::Vector3&)' is deprecated [-Werror=deprecated-copy]
661 |             Vector3 v0 = *this;
|                           ^~~~
/usr/include/OGRE/OgreVector3.h:134:25: note: because 'Ogre::Vector3' has user-provided 'Ogre::Vector3& Ogre::Vector3::operator=(const Ogre::Vector3&)'
134 |         inline Vector3& operator = ( const Vector3& rkVector )
|                         ^~~~~~~~
/usr/include/OGRE/OgreVector3.h:662:26: error: implicitly-declared 'constexpr Ogre::Vector3::Vector3(const Ogre::Vector3&)' is deprecated [-Werror=deprecated-copy]
662 |             Vector3 v1 = dest;
|                          ^~~~
/usr/include/OGRE/OgreVector3.h:134:25: note: because 'Ogre::Vector3' has user-provided 'Ogre::Vector3& Ogre::Vector3::operator=(const Ogre::Vector3&)'
134 |         inline Vector3& operator = ( const Vector3& rkVector )
|                         ^~~~~~~~
/usr/include/OGRE/OgreVector3.h:670:36: error: implicitly-declared 'constexpr Ogre::Quaternion::Quaternion(const Ogre::Quaternion&)' is deprecated [-Werror=deprecated-copy]
670 |                 return Quaternion::IDENTITY;
|                                    ^~~~~~~~
In file included from /usr/include/OGRE/OgreVector3.h:33,

it's ok now ,by use https://github.com/loco-3d/whole_body_state_rviz_plugin
you can close the issue

Hello! I met the same issue, but this does not work for me.
Do you do any other thing to fix it?

it's ok now ,by use https://github.com/loco-3d/whole_body_state_rviz_plugin you can close the issue

Paste this line to CMakeList.txt in the node whole_body_state_rviz_plugin:
set(CMAKE_CXX_FLAGS "-std=c++14 -Werror -Wall -Wextra -Wno-unused-parameter -Wno-deprecated-copy -Wno-unused-but-set-parameter" CACHE STRING "" FORCE)

Paste this line to CMakeList.txt in the node whole_body_state_rviz_plugin: set(CMAKE_CXX_FLAGS "-std=c++14 -Wno-unused-parameter -Wno-deprecated-copy -Wno-unused-but-set-parameter" CACHE STRING "" FORCE)

really helpful!Thank you!


Route.php file in subfolder

Hello,
I tried to move the route.php in a subfolder outside of Http folder but is not working, it returns 404 page.
Is not possible to do that ?
Thanks
D

It is, you need to tell laravel that file has changes location.
check the module.json if you're loading the routes file there.

Could you be more explicit on how Can I do that? I have now in the modules folder a new folder Route and inside of it, I moved the route.php. Then what should I do?
Thanks

That's the error I get :
"Nwidart\Modules\Module::main(): Failed opening required

I tried to change the start.php as well but nothing.
That's the error I get:

Nwidart\Modules\Module::main(): Failed opening required
Thanks

strange, maybe you're loading those routes somewhere else too.

But which is the process that I should follow to achieve that? Maybe I can do it again.
Thanks

There is no process. You're free to load your routes however you like. This package doesn't do anything with with it.

Okay, Sorry. I didn't pay attention to what I was doing. I was calling the file route.php with the wrong path as I show in the pic. The path wasn't require DIR . '/Http/Routes/routes.php' but require DIR . '/Routes/routes.php' !
Thanks anyway for the support and well done with this package it saves me lot of time, you got my star.

Good to know, no worries happens to all of us!
👍


bookmyshow cities  doesn't show err for non-existing city

bookmyshow cities <city> which random  name should give an error for which the city doesn't exist as :
 throw new Error('Oops! City not found');  in cities.ts
but it only giving table like

@rishavanand can you clarify this behavior,  this should be a bug or feature tag ?

@rohanprasadofficial For me it should be a feature. A feature that will clearly clarify that the city entered by the user could not be found.

@rishavanand  Great


Clean up Monomer EVM chain config

Context
Berlin and London hardforks primarily introduce gas-related changes. Since Monomer doesn't currently account for gas, these forks may be unnecessary for the Monomer EVM.
Changes

Remove commented Berlin and London fork activations in Monomer EVM
There is also no need for shared EVM config variable between RPCMarshalBlock and Monomer EVM, since RPCMarshalBlock needs both Berlin and London fork activations but Monomer EVM doesn't

Fixes #104

cc @natebeauregard


[Hotfix] Fix column menu not scrollable

DO NOT MERGE
Need to work out hotfix release mechanism
#3581

/release-pr


How to make CodeGPT for pycharm fonts larger or zoom in?

It's a great tool. I'm wondering if there is a way to make CodeGPT larger and easy to read in pycharm?

Hi, at the moment the ToolWindow's text isn't relative to IDE's font sizes, I will try to fix it in the upcoming days.

Hi, the relative fonts are available in version 1.6.1.


adding interview simulator tutorial

Adding the code for Smart Interview Simulator using Streamlit and Llama 3.1 70B.

please remove this folder __ pychache __  and push again, rest looks good to me!


Make it easy to get function working directory and other context

Today, getting environment information in managed functions (like the current directory) is very cumbersome. We need to investigate a way to make this more convenient.

+1 on this. I had to use some really hacky workarounds in order to write code that works both locally with the CLI and on Azure. I ended up creating an environment variable SITE_PATH where I set to "." when running locally and site\wwwroot on Azure.

Customer asking for function name:
https://social.msdn.microsoft.com/Forums/en-US/aa67dbf0-7e02-46b1-80a1-27d278b14ec0/simple-way-to-get-name-of-function-app?forum=AzureFunctions

@lindydonna @christopheranderson I'm clearing the milestone on this so we can chat about this item on the next triage meeting.

Dup of #415?

Another customer asking for function name here.


Bug in analyse_text()

(Original issue 737 created by ziangsong on 2012-02-09T06:42:10.976728+00:00)
For this C# code, the method only return 0.001 for <class 'pygments.lexers.dotnet.CSharpAspxLexer'>
{{{
#!C#
[DataContract]
public class Answer
{
    private Int32 _answerId;
    private String _answerTitle;
    OsqarSQL getData;
    DataTable DT;

    // Constructor Logic
    public Answer(int AnswerID)
    {
        getData = new OsqarSQL();
        DT = getData.GetAnswerTitleWcf(AnswerID);
        _answerTitle = DT.Rows[0][1].ToString();
    }

    // Define DataMembers for XML output
    [DataMember]
    public String AnswerTitle
    {
        get { return _answerTitle; }
        set { _answerTitle = value; }
    }
}

}}}

(Original issue 737 last updated on 2012-02-12T07:19:11.638017+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2012-02-12T07:19:11.636028+00:00)
Closes #737: CSharpASP: remove unconditional 0.001 from analyse_text
→ <>


Add SecondaryKey to UpdateAuthorizationRuleAsync

In NamespaceOperations.UpdateAuthorizationRuleAsync, there is no
handling for the secondary key of the
ServiceBusSharedAccessAuthorizationRule, which causes it to be set to
NULL.
This patch adds handling for the SecondaryKey, mimicing how the
PrimaryKey is being added.
This commit is related to issue #1553:
https://github.com/Azure/azure-sdk-for-net/issues/1553

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hi @morandy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@azuresdkci add to whitelist

Can one of the admins verify this patch?


Findbugs support for Java 9

The first preview of Findbugs supporting Java 9 has just been released: https://github.com/findbugsproject/findbugs/releases/tag/3.1.0_preview1
All of our code quality plugins (including the FindBugs plugins) resolve the FindBug dependency as external dependency via GAV. Currently, the FindBugs version 3.1.0 (supporting Java 9) is not available on Maven Central/JCenter yet. I asked about an ETA for the publish date but it looks like it is going to take a while as it also relies on ASM 6 and BCEL 6 preview builds.
At the moment I don't think it's worth trying out the SNAPSHOT version of FindBugs as it would require additional changes to the FindBugs plugin to be able to point to local library files. Also we'd need to provide those libraries with the Gradle distribution which we definitely do not want to do.
As part of this FindBugsIntegrationTest needs to be fixed for Java 9

Looks like this could never happen: I'm really sorry to say, but FindBugs project in its current form
is dead.

I'm the one that started that thread on fb-discuss, and I'm also the one pushing forward a hard fork, called SpotBugs. The community is already getting behind it, and even devs from the original FindBugs team are already onboard
The fork vows to keep binary compatibility for at least a logical timeframe for people and integrations to switch before even considering breaking changes. So once we make a release, just swapping the dependency should be enough.
Right now, our priority is sorting out naming issues / website, and getting together a 3.1.0 release with proper Java 8 and Java 9 support (some detectors still don't report on lambdas, 'though they don't break when finding them). Once ready we will publish in mavenCentral and jcenter, under com.github.spotbugs:spotbugs, and we will gladly help you integrate.

Nice @jsotuyod!

There's also https://github.com/amaembo/huntbugs
I don't know if spotbugs/huntbugs collaborate in some way. Maybe @jsotuyod and @amaembo can chime in about this. Just mentioning it for the sake of completeness.

HuntBugs is @amaembo's personal project (he is an inactive FindBugs team member). It's not a fork, but a complete rewrite upon a different set of libraries, and is therefore incompatible with existing integrations / plugins. It has been able to reproduce ~40% of FindBugs' detectors. It's development is dormant at the moment as he is focusing his efforts on writing detectors for IntelliJ IDEA's analyzer. There are no concrete plans AFAIK to resume development in the short-term.
All this is taken from @amaembo's email on that same topic: https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2016-November/004324.html

I asked about this again it looks like FindBugs will never support Java 9. SpotBugs is the replacement. I am going to close this issue. If FindBugs should ever support Java 9 then we can reopen this issue.


Cannot update a component (Component) while rendering a different component (OtherComponent).

Getting this error in any component where I'm using useQuery. Using React and the following exchanges:

@urql/devtools
dedupExchange
@urql/exchange-graphcache
@urql/exchange-auth
@urql/exchange-multipart-fetch
subscriptionExchange

The stack trace points to this line:
https://github.com/FormidableLabs/urql/blob/47eaff17fcf72684eb12bd1009d3014f91a81c86/packages/react-urql/src/hooks/useQuery.ts#L149

Hiya :wave:
Just a quick note, we recognise this issue from a previous fix we had to do on a prior implementation of our React hooks bindings. That being said, usually we'd ask for more details that follow our bug template and possibly provide a reproduction: https://raw.githubusercontent.com/FormidableLabs/urql/main/.github/ISSUE_TEMPLATE/Bug_report.md
To give you more information on what's going on here; because the hooks have the option to use React suspense and suspend on any changes, they perform checks during render to determine whether their state is out-of-date and whether they need to request a change. When that change happens they briefly poll the client for a synchronous check on whether the new state is already ready without fetching against the API. When this result comes back all useQuery hooks with the same input see this result and will trigger an update. This is something that the React team has put an explicit warning into the reconciler for.
That being said, this will only happen when:

useQuery is mounted (or updated) with a query and set of variables
A second useQuery hook is mounted (or updated) elsewhere with the same query and same set of variables

Hence, I do have to warn you, while we will mute this warning in a patch with the PR that's linked, this is a slight problem in GraphQL apps, since it shouldn't be necessary to create multiple query hooks with the same inputs and its more advisable to hoist as many data requirements as possible to the top of a page and to let the rest of the components reuse this same data (passing and splitting it via props)
So that's just a side note on the issue in general ✌

Still seeing this issue in latest urql version. Stack points to the following line:
https://github.com/FormidableLabs/urql/blob/ef4b5b002d31e17d84fb41e5feb24d2200c9656f/packages/react-urql/src/hooks/useQuery.ts#L156
So, #1383 does not fix this for me. I will follow the tipp to hoist the query, but this somewhat goes against what React hooks are invented for.

Yeah, I'm still getting this error occasionally. I agree that this is against the point of react hooks

@danbeneventano I'm sorry you're still having trouble with this. Curiously we do have several apps that also use shared hook state extensively. Can you point to a reproduction with the latest version of urql and React? If not, we'll have to see whether it occurs in the apps we have, but I haven't seen this for several versions

@danbeneventano I'm sorry you're still having trouble with this. Curiously we do have several apps that also use shared hook state extensively. Can you point to a reproduction with the latest version of urql and React? If not, we'll have to see whether it occurs in the apps we have, but I haven't seen this for several versions

I'll see if I can produce a reproduction, but it's been happening very unpredictably (maybe related to network speed)

Just two comments:
@danbeneventano Don't think this is related to network as the issue occurs in my local development environment.
@kitten: This is "just a warning", so it can be overlooked easily.
Unfortunately the issue occurs in a larger code base that I cannot share, so I cannot promise a reproduction. The general pattern in my case:

2 identical(!) useQuery
the second useQuery is in a child of the first useQuery but many levels down the React tree
problem is triggered, when I call the query re-execution function of the hook
it does not matter, if I call the re-execution function in the parent or the child, problem is present in both cases

I hope this description at least gives some hints on how this may be reproduced.

@kitten Same error here as @danbeneventano, without any duplicate query. I simply have something like this :
export default function List({ project, principles, renderItem }: Props) {
  const [filters, setFilters] = useListVariables({});
  const [{ data, fetching }] = useEngineeringArticlesQuery({ // generated by codegen
    variables: {
      ...filters,
      principles,
      projectId: project?.id
    }
  });
  return (
    <ListView
      loading={fetching}
      content={data?.engineeringArticles}
      renderItem={renderItem ?? (article => <Item.Admin article={article} />)}
    />
  );
}

When props change, thus variables changes :
index.js:1 Warning: Cannot update a component (`Page`) while rendering a different component (`List`). To locate the bad setState() call inside `List`, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
    at List
    at div
    at div
    at Card
    ......

@kitten: Could you please re-open this issue (or shall we make a new one?). The issue is hard to debug and makes using urql hooks a nightmare in larger code-bases.

@ostrebler @styxlab We have urql active in a lot of projects that are sufficiently large where we haven't encountered this, so I'd actually guess on a mis-use of executeQuery or a separate hook that isn't in urql causing this, so without a reproduction I won't open an issue since that'd mean taking a stab in the dark 😅
We also don't reopen old issues, since the cause will never be the same and they wouldn't track resolution correctly anyway. So if you have a reproduction please feel free to open an issue.

@kitten  What do you mean by misuse of executeQuery? It's not another non-urql hook causing this, I made sure of that. It's a fact that it comes from useQuery, and without a duplicate query in my case. So there is something to investigate here.
It seems very hard to reproduce in a demo, because when the codebase is extremely large, the multiple factors causing this could be in a million places...

@kitten: Okay, I will try to make a reproduction and open a new issue if I succeed.

@ostrebler that's just one example of what could cause this: Running any Client operations during render. Our hooks actually shield themselves from this since only one cause can be attributed to our hooks: mounting. So if we don't have a repro (which actually after the fix for this issue was never again attributed to our hooks 😅) we're in the dark since any update from one component during rendering of another triggers this warning.
One thing that you could look at is the Page component, since there's seemingly an update there that's caused by List. Maybe a runaway state change during render?

@kitten Hello. I wasn't able to find the cause of the error back then. I'm commenting here because I'm getting it again, this time I can pinpoint a specific code modification that leads to it.
When I have two queries like this :
const [resultA] = useQuery({ query: QueryADocument });
const [resultB] = useQuery({ query: QueryBDocument });

I don't get the error. However, pausing the second to wait for the first triggers the error :
const [resultA] = useQuery({ query: QueryADocument });
const [resultB] = useQuery({ query: QueryBDocument, pause: !resultA.data });

Btw I'm sorry I'm in a rush, I don't have time to setup a proper reproduction. I might do it in the futur if I don't find another cause for this error.

FWIW I was seeing this error and this was fixed by 2.0.4 for me: https://github.com/FormidableLabs/urql/pull/1722

I'm seeing this in 2.0.5. It seems like two different components are fetching the same query, but with different fields. As a result, one is updating the other. A bit hard to reproduce, since it feels like a race condition, but I'll try if no one else has reproduced.

I am seeing this issue even with one hook (e.g. when switching between pages):
Warning: Cannot update a component (`Navbar`) while rendering a different component (`Navbar`).

with
export default function Navbar(): ReactElement {
   const [plan] = usePlanQuery()
}

I suspect this issue is due to missing garbage collection when the component gets out of scope. I managed to find a workaround as follows:
export default function Navbar(): ReactElement {
   const ref = useRef()

   const [plan] = usePlanQuery({ pause: !ref.current })
}

@kitten @JoviDeCroock this is still happening after switch to use-sync-external-store https://github.com/FormidableLabs/urql/pull/2164

So, since some people have been missing this, I'll cross-post it here for awareness. This is basically a pinned announcement re. us reverting the useSyncExternalStore refactor: https://github.com/FormidableLabs/urql/issues/2309


Make a refkey but dont use it to witness perf impact

Openign this to measure perf

@typescript-bot perf test this once you get a chance.

@typescript-bot perf test this once you get a chance, now with less lint warnings.

@typescript-bot perf test this

Just setting the cache flag (without changing it to cache cross-call) is enough to make angular have an almost 6% perf regression? Oh no. Caching the input is precisely what we need to do... hmmmm... maybe I'll try a separate multilevel cache?

@typescript-bot perf test this once more

@typescript-bot perf test this once more

@typescript-bot perf test this again

@typescript-bot perf test this again

Just a speculative get penalized perf a lot less than just a set (but still made some scenarios regress by 7%). Lowat. Does this mean if I only cache one in N calls the perf is somewhere between the two? Hm.

@typescript-bot perf test this again - if this isn't toooooo bad I can probably do a conditional set once every few calls without incurring the full 9-18% penalty from the original PR.

OK, that's not so bad - now to add in periodic calls to actually set the cache.

@typescript-bot perf test this again - 100 should hopefully be too high and I'll be able to tune it down to 10 or so.

@typescript-bot perf test this again - trying cache partitioning (by flow container) & a separate flowflag to indicate caching has occurred (so we never even try a cache lookup on a flow node which has never before been cached)

@typescript-bot perf test this again - let's see if making the actual implementation of getFlowTypeOfReference monomorphic and separate from the cache layer helps any.

@typescript-bot perf test this again cache sharding intensifies

Nope extra heirarchy is absolutely not helpful.

@typescript-bot perf test this again - only assignments cached this time

@typescript-bot perf test

@typescript-bot perf test this once more, iteration 10 or something


Convert the path to a SVG  element as a html element

I added a function, that returns an svg path as an html element, so you can add your newly rendered path straight into specific DOM element, without struggling with string parsing.
Codepen Demo here.

Hi @afternoon2,
this is a good idea.
The automated tests fail because of the indentation (please run npm test before committing).
The name toHTML suggests the function returns HTML code. Since it returns an SVG element, maybe it should have another more explicit name ?
Note also that opentype.js is intended to work also in non-browser environments (e.g. Node.js).

I agree regarding the naming. Perhaps Path.toElement or Path.toDOMElement are more appropriate names.

Yes, the name might be misleading. Path.toDOMElement is much better. My intention was to make a method that would be helpful while coding svg animations (live rendering svg from font), so it's not useful outside the browser.
I have some problems with npm test. I mean -after I corrected indentation, in git-bash I'm still seeing some linebreak issues (49):
validateLineBreaks: Invalid line break at <filepath>
And here's a dummy question: how to fix it without opening each broken file?

Yes, this is a pain if you are not using Linux.
To avoid this, I locally add the following line to the .jscs file before running npm test:
"validateLineBreaks": "CRLF",

Then I get only 1 error for ./bin/server.js
Line break errors don't matter since they will be automatically and silently corrected when you commit on github (don't commit .jscs). You just have to make sure you don't have other types of errors.
Maybe jscs offers the possibility to disable linebreak checks but I don't know how.

That works, thank you!

Thanks!


配置了kerberos之后不生效

(you don't have to strictly follow this form)
Bug Report
在byconity-server.xml 、byconity-worker.xml、byconity-worker-writer.xml 配置了 kerberos 不生效

Briefly describe the bug

The result you expected
How to Reproduce
Version
发布的release的 byconity-server-0.1.0.x86_64.rpm

Hi @wordhardqi , could you help to take a look at this?

please check your hdfs3.xml，If you are not sure, please keep the configuration consistent with HDFS configuration.
and add
<property>
    <name>dfs.use.internal.credential.format</name>
    <value>false</value>
</property>

add conf in hdfs3.xml like
<property>
    <name>hadoop.security.authentication</name>
    <value>KERBEROS</value>
</property>
<property>
    <name>dfs.use.internal.credential.format</name>
    <value>false</value>
</property>
<property>
    <name>dfs.data.transfer.protection</name>
    <value>authentication</value>
</property>
<property>
    <name>dfs.block.access.token.enable</name>
    <value>true</value>
</property>

ok，thanks，Is it enough to add the hdfs3. xml file to the/etc/bicity/directory and add the configuration you just sent？

please check your hdfs3.xml，If you are not sure, please keep the configuration consistent with HDFS configuration. and add
<property>
    <name>dfs.use.internal.credential.format</name>
    <value>false</value>
</property>

add conf in hdfs3.xml like
<property>
    <name>hadoop.security.authentication</name>
    <value>KERBEROS</value>
</property>
<property>
    <name>dfs.use.internal.credential.format</name>
    <value>false</value>
</property>
<property>
    <name>dfs.data.transfer.protection</name>
    <value>authentication</value>
</property>
<property>
    <name>dfs.block.access.token.enable</name>
    <value>true</value>
</property>

ok，thanks，Is it enough to add the hdfs3. xml file to the/etc/bicity/directory and add the configuration you just sent？

ok，thanks，Is it enough to add the hdfs3. xml file to the/etc/bicity/directory and add the configuration you just sent？

You also need to modify libhdfs3_config path to your hdfs3.xml abd keep the configuration consistent with HDFS configuration. And add
<property> <name>dfs.use.internal.credential.format</name>
<value>false</value>
 </property>

in your hdfs3.xml

dfs.use.internal.credential.format

Just now, I tried and still reported an error. I configured the content you just sent on the HDFS of CDH

Hi, can you enable trace log in worker by set yandex.logger.level to trace in configuration file and paste the entire log for query here by grep {query_id} byconity-worker.log

btw, in byconity, the config key for libhdfs3.xml is yandex.hdfs3_config rather than yandex.libhdfs3_config. can you change the config key and retry again?

logger.level to trace

I have tried it according to your request, but it still doesn’t work. I don’t know what is wrong with me.

btw, in byconity, the config key for libhdfs3.xml is yandex.hdfs3_config rather than yandex.libhdfs3_config. can you change the config key and retry again?
thanks ,The problem is finally solved, I didn't notice, the label hdfs_conf of the configuration file needs to be changed to hdfs_config

btw, in byconity, the config key for libhdfs3.xml is yandex.hdfs3_config rather than yandex.libhdfs3_config. can you change the config key and retry again?
thanks ,The problem is finally solved, I didn't notice, the label hdfs_conf of the configuration file needs to be changed to hdfs_config

Hi, did you solve the problem ?


tf.linalg.triangular_solve different behaviour on CPU vs GPU

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
https://colab.research.google.com/drive/1uTUzEQXDR6JvCkFQyS-3n2pAUKAH-TLk?usp=sharing#scrollTo=BcSb0SDQ5nI0
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04 (also Colab)
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4.3 (also Colab)
Python version: 3.7.10

Describe the current behavior
When trying to apply tf.linalg.triangular_solve on an invalid input matrix (in my case I included np.nan in the matrix) - different behaviour is observed when running on CPU vs GPU. On CPU - the functions returns NaNs, whereas on GPU an InvalidArgumentError occurs
Describe the expected behavior
Consistent behaviour between CPU & GPU
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1uTUzEQXDR6JvCkFQyS-3n2pAUKAH-TLk?usp=sharing#scrollTo=BcSb0SDQ5nI0

@qiq208,
As per the colab link provided, with CPU we get InvalidArgumentError and with GPU, it returns NaNs whereas in the issue description you have mentioned in the opposite way.

I am able to reproduce the issue reported, in colab with both TF 2.6.0 and nightly 2.8.0-dev20211101. Please find the gist here


lazy-load connections (#1584)

Fixes #1584
Lazily open database connections when connections are acquired. It's a little tricky as we have to defer the opening call until connection time, so we stash that in a special object, and if that's what the "handle" is, we call the stored method, which in turn sets the handle.

/azp run


How can I get the number of model parameter?

Hello.
How can I get the number of model parameter?
In Kaldi, I can use "nnet-am-info" for checking the number of model parameter in my LSTM-RNN model.
but, I cannot find a program like "nnet-am-info" in EESEN.
In this case, I have to make a program like "nnet-am-info" for a model in EESEN?
Best Regards

I don't know what nnet-am-info does, but by and large, the size of your model file expressed in "floats" (4 bytes) should be a good approximation to the number of model parameters, unless we store doubles, which I don't think we do.


ArgumentNullException deferred

Argument validation exceptions thrown within iterator methods will not be
thrown until the MoveNext method is called. For example:

IEnumerable<string> list = null;
Func<string, string> selector = null;
IEnumerable<string> newList = list.Select(selector);
// With System.Core, ArgumentNullException is thrown here.

// Some other code...

foreach (string item in newList)
// With LinqBridge, ArgumentNullException is thrown here.
...

The public method should validate the arguments, and then call a private
iterator method:

public static IER Select<S,R>(this IES source, FSR selector)
{
  if (null == source) throw new ArgumentNullException("source");
  if (null == selector) throw new ArgumentNullException("selector");
  return SelectIterator(source, selector);
}
private static IER SelectIterator<S,R>(IES source, FSR selector)
{
  // Implementation here...
}

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 Oct 2008 at 3:39

Original comment by<EMAIL_ADDRESS>on 17 Oct 2008 at 9:41

Changed state: Accepted

Fixed in r215.

Original comment by azizatif on 3 Oct 2009 at 1:32

Changed state: Fixed


[IOTS-313] Add geo fencing support for particular device

Reference: https://wso2.org/jira/browse/IOTS-313

Fixed with following PRs
https://github.com/wso2/carbon-device-mgt/pull/755
https://github.com/wso2/carbon-device-mgt/pull/806
https://github.com/wso2/carbon-device-mgt-plugins/pull/687
https://github.com/wso2/carbon-device-mgt-plugins/pull/718
https://github.com/wso2/product-iots/pull/708
https://github.com/wso2/product-iots/pull/1020


Dist: Add macOS entitlements files for editor code signing

These are the entitlements we define for official macOS editor builds since
Godot 3.3.
Users making custom builds of the engine can use those files with codesign to
sign their own builds. E.g.:
codesign --force --timestamp \
  --options=runtime --entitlements editor.entitlements \
  -s <your key> -v osx_template.app

Note: Now that there's a misc/dist/osx folder, I'd like to move misc/dist/osx_tools.app and misc/dist/osx_template.app to misc/dist/osx/*.app. But I don't want to change this in the 3.3 and 3.x branches to avoid breaking user scripts, and I don't want to change it in master now since the updated latest docs would also confuse users... so I'll do it closer to the 4.0 release.

Cherry-picked for 3.4.

Cherry-picked for 3.3.2.


Improve part delimiters

I think there are a few issues with how mdx delimits parts:

They are not clearly identified as being interpreted by mdx and that can be confusing. [@@@mdx.part ...] would be better
They aren't actual delimiters and its not very user friendly. Separate begin and end markers for a given part would be better than having to introduce [@@@part 2] to mark the end of the part 1 even though no part 2 is ever used anywhere.
The fact that they are attributes can be slightly confusing as those usually have meaning. One could think they are interpreted by a PPX and expanded into something. Is there any reason why this isn't done using comments instead?

It was done using attributes to reuse as many bits from https://github.com/realworldocaml/topexpect/tree/master/lib as possible, I agree it may be confusing from a user perspective.

Parts are not always defining valid sub-ast do I’m not even sure using attributes is a good idea. We are now even using regexps to identify them...

What would you think about adding clearer begin/end delimiters using comments?
In a first iteration we could support both those and the old parts attributes to avoid making a huge breaking change. We could then get rid of the attributes when bumping the major version!

Something like:
(* mdx-part-begin <part_name> *)
...
(* mdx-part-end *)

No objections from me.
On Wed, Oct 23, 2019, 8:29 AM Nathan Rebours<EMAIL_ADDRESS>wrote:

Something like:
(* mdx-part-begin <part_name> )
...
( mdx-part-end *)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/realworldocaml/mdx/issues/165?email_source=notifications&email_token=AAFOUJRDE4O3X6X3KSFT7CLQQA7SFA5CNFSM4IU4VBQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBHEGA#issuecomment-545419800,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOUJVLUQ3FKLWIS6MDPC3QQA7SFANCNFSM4IU4VBQA
.


framework receives less than master offers

Im not entirely sure if this is related to pymesos, but im seeing a case where if i schedule lots of jobs that only need 0.2 cpu (.1 for task, .1 for executor) on a 2 core agent, the resources offers supplied to the framework gradually contain fewer and fewer cpus until the jobs cannot be scheduled.
(As a note: Im running mesos on debian, and launching jobs inside docker containers)
For example, here is the first offer i receive (with hostname misc removed):
'framework_id': {'value': 'e06e2242-4f76-450d-9153-4616dc03e913-0044'}, 'allocation_info': {'role': '*'}, 'id': {'value':
 'e06e2242-4f76-450d-9153-4616dc03e913-O185'}, 'resources': [{'role': '*', 'type': 'SCALAR', 'name': 'cpus', 'scalar': {'value': 2.0}, 'allocation_info': {'role': '*'}}, {'role': '*', 'type': 'SCALAR', 'name': 'mem', 'scalar': {'value': 12031.0}, 'allocation_info': {
'role': '*'}}, {'role': '*', 'type': 'SCALAR', 'name': 'disk', 'scalar': {'value': 24987.0}, 'allocation_info': {'role': '*'}}, {'role': '*', 'type': 'RANGES', 'name': 'ports', 'ranges': {'range': [{'begin': 31000, 'end': 32000}]}, 'allocation_info': {'role': '*'}}],
 'agent_id': {'value': 'e06e2242-4f76-450d-9153-4616dc03e913-S0'},

and then, after scheduling jobs eventually my final resource off looks like:
'framework_id': {'value': 'e06e2242-4f76-450d-9153-4616dc03e913-0044'}, 'allocation_info': {'role': '*'}, 'id': {'value':
 'e06e2242-4f76-450d-9153-4616dc03e913-O192'}, 'resources': [{'role': '*', 'type': 'SCALAR', 'name': 'cpus', 'scalar': {'value': 0.1}, 'allocation_info': {'role': '*'}}, {'role': '*', 'type': 'SCALAR', 'name': 'mem', 'scalar': {'value': 32.0}, 'allocation_info': {'ro
le': '*'}}, {'role': '*', 'type': 'SCALAR', 'name': 'disk', 'scalar': {'value': 32.0}, 'allocation_info': {'role': '*'}}], 'agent_id': {'value': 'e06e2242-4f76-450d-9153-4616dc03e913-S0'},

At this point, I checked the mesos master, which reports 2 cpus offered, and there is nothing else running. Notably, mem/disk offer also seems to decrease. Is it possible that pymesos may not be relinquishing resources?

Hmm，did your script actrually launch tasks with the offered resources？
If no tasks found in your framework UI，you may check Offers tab. All the offered resources should be displayed there.
PyMesos just a bridge for mesos and framework，and should not modify the allocation behaviour of mesos.

got it - i can see jobs launching, and completing, but it seems like the resources requested are never released for some reason

ok, looking closer, in the mesos web ui the tasks show up as completed, but the offer still containers the executor ids for past (completed) tasks. It seems to continue to count their resource usage as well. Is there something I should specifically do to terminate the executor and have mesos collect it?

it looks like i needed to make sure to call driver.abort() to actually stop the driver - doing this fixes the problem

Thanks for your share. Typically we just re-use the existing executor when possible, and the executor is running till framework ends. If you actually need short-lived executors, you may write a custom executor and let it exit when the task is finished. and you may receive a executorLost message to notify you the premature exit of the executor.


Spurious Restarting App?

Has anyone noticed that at times Marathon spuriously restarting a docker container (docker v1.7.1, mesos 0.23, marathon 0.91) .
Most deployments go well, but from time to time, I would get see multiple containers on the same docker instance  for the same image.  The failed container does not have an "Exit" code.  The app definition specified only 1 instance.
Not sure what logs to collect that may help.

Hi @coderlol , could you tell a little bit more about the docker container configuration?
And how many nodes are you running?

docker containers all use bridge networking.  Number of containers about 3-4.  All containers share common layers "from".  The containers have different images, but the images share based images via "from"
I think the issue may occur when posting the apps to Marathon in quick succession and Marathon decides to push the containers to the same slave.  The same slave would use docker to pull the images.  If there is a problem pulling images (perhaps race condition), it is not recoverable.  Destroying the apps, via Marathon and/or at Docker, won't help.  A redeployment would see the same error.
Deleting all images from docker and re-deploying have helped.
I will see if I can get better observations

I have marathon, chronos, mesos master on a 3 nodes cluster.  There are 2 different types (attributes) of slaves.  Each type has 2 slave nodes.

Hey @coderlol It is hard to find the problem just by this description. Could you please

send the app definition you send
the logs from Marathon
the logs from Mesos master and slave
So we are able to reproduce the problem. Thanks!

Sure.  I have not seen it again, but will do if it comes back.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3597. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3597. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Looping with slidesPerView: auto does not work with variable size images

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/swiper-centered-auto-forked-po4oq6?file=%2Findex.html
Bug description
As described in issue https://github.com/nolimits4web/swiper/issues/6559, it is not possible to use looping with slidesPerView: auto unless all images are the same size.
The below issue was closed and locked without really addressing the user’s question – will the documentation be updated to reflect this limitation, or will the issue be addressed in a future release?
It would be really good if different width images could be supported but if it’s beyond the scope of the project then it would still be super helpful to have documented as something that is unfeasible.
Thanks so much for your work on this.
https://github.com/nolimits4web/swiper/issues/6559
Expected Behavior
No response
Actual Behavior
No response
Swiper version
9.2.0
Platform/Target and Browser Versions
All browsers
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

I reviewed the code sandbox and to me it seems that loop:true works perfectly with slidesPerView: auto. Can you elaborate a little more on this issue.

The slides jump/jitter about because the different widths are not taken into account. It might seem like it is working from a quick glance but in practice is very unsettling.

You can't use nth-child to set the width since the order of the slides will be rearranged dynamically

https://codesandbox.io/p/sandbox/swiper-react-centered-auto-forked-y1pnir?file=%2Fsrc%2FApp.jsx%3A25%2C1
Always use latest Swiper version before opening the issue


Release v0.6.1

(PR #40, 2019-05-08) dte.data_models: fix bug in DteDataL2

Codecov Report

Merging #41 into master will increase coverage by 0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage    71.7%   71.78%   +0.07%
==========================================
  Files          16       16
  Lines         767      762       -5
  Branches      101      100       -1
==========================================
- Hits          550      547       -3
+ Misses        174      173       -1
+ Partials       43       42       -1

Impacted Files
Coverage Δ

cl_sii/dte/data_models.py
57.55% <0%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4789ec0...1b26dee. Read the comment docs.


Very high CPU usage (at some point) with Postgres' capture

Hi there,
We have been using X-Ray for a few weeks now and we have had a few issues with some of our Node processes using 100% of CPU usage for no apparent reason.
Details of the issue

CPU and memory usage increases abruptly.

Even after stopping any request to go to this container, the CPU stays at 100%, up until a certain point. Once it took 23 minutes, in the example above it's been more than an hour and is still at 100% CPU.

There are *many* `Segment too large to send` warning logs at the moment where the load starts to spike.

In the logs, the `trace_id` of the log itself (that we get with X-Ray's `getCurrentSegment()`) is different from the one in the log.

Profiling the Node process, we can see that X-Ray functions are the ones taking all the CPU. On a ~11seconds profile, this is the result.

Questions

Do you have any idea of what might be the root cause?
Do you have any idea of where to investigate next?

Digging more in the problem, it seems like we are able to reproduce it when a request is producing many many segments.

Hi @sroze,
Thank you for raising this issue, it definitely seems to be the result of a high load of (sub)segments. Regardless, it should not be consuming the amount of memory or CPU that it is.

Digging more in the problem, it seems like we are able to reproduce it when a request is producing many many segments.

Do you mean there are many subsegments (e.g. several downstream subsegments being recorded on a single segment) or actually several top-level segments? Based on the Segment Too Large errors I believe it would be the former.
 Not really sure if this would cause the CPU usage, maybe that's the repeated attempts to serialize a bunch of 64kb segments into JSON?
The trace ID discrepancy is VERY interesting, that gives further evidence for an error in cls-hooked as well. I'll investigate the SegmentTooLarge failure mode some to see if memory leaking is possible. The auto-context function mentioned in the profiler also manipulates the cls-hooked context.

Do you mean there are many subsegments (e.g. several downstream subsegments being recorded on a single segment) or actually several top-level segments? Based on the Segment Too Large errors I believe it would be the former.

Indeed, the former. Maybe subsegments on a single top-level segment.

Not really sure if this would cause the CPU usage, maybe that's the repeated attempts to serialize a bunch of 64kb segments into JSON?

Is there any sort of process that tries to re-send (more specifically re-serialize) sub-segments if somehow they failed to be sent maybe? This could explain why it's consuming that much CPU because it would attempt many times to serialise the same thing over and over.
It seems like it happens when there is a lot of SQL requests in, this might help your investigation. Worth noting that we have a query logger that does attach the SQL string using the following wonderful strategy:
  try {
    const segment: any = await AWSXRay.getSegment();
    if (segment.subsegments) {
      // get latest subsegment
      const sqlSub = segment.subsegments[segment.subsegments.length - 1];

      sqlSub.sql.url = query;
    }
  } catch (e) {
    log.warn({ query }, 'Unable to attach query to trace', e);
  }

This might contribute to a larger payload, obviously as some queries can be pretty long given we are using an ORM which would list all the fields.

The trace ID discrepancy is VERY interesting, that gives further evidence for an error in cls-hooked as well

I can also confirm that this happens for the 5 cases we have seen so far.
We also have seen that the "streaming threshold" configuration mentions this error. We have configured it to 5 so I guess this is fairly low already; shall we attempt to lower it down even further?
Also, to give you slightly more context, we do capture more or less everything:
  capturePostgres(require('pg'));
  AWSXRay.captureHTTPsGlobal(require('http'), false);
  AWSXRay.captureHTTPsGlobal(require('https'), false);
  AWSXRay.capturePromise();

If the CPU profile dump can help you, happy to send it over email.

Is there any sort of process that tries to re-send (more specifically re-serialize) sub-segments if somehow they failed to be sent maybe?

There's no retries for sending or serialization, since the segments are sent via UDP and sampled anyway we accept some lossiness over the cost of retries. The segment_emitter is where we stream them and this is how we serialize them. Just from the profiler output it seems like we might unknowingly be doing some unnecessary double serialization, but that shouldn't impact
How many of these subsegments are you creating for a single request? If you could also send or attach an example trace that couldn't get sent, or even just one of its subsegments, that could be very useful. It would also be nice to see the hierarchy of the subsegments to understand how useful the streaming threshold would be.

We also have seen that the "streaming threshold" configuration mentions this error. We have configured it to 5 so I guess this is fairly low already; shall we attempt to lower it down even further?

Unfortunately as pointed out in #283, the setStreamingThreshold has a bug for streaming subsegment trees right now so I don't think it would assist.
Do you know if you or any packages you depend on are doing any long-term polling processes in the background? Sometimes with captureHTTPsGlobal enabled those processes can accrue lots of subsegments over time which occasionally causes segmentTooLarge errors. If all/vast majority of the subsegments are SQL (as opposed to HTTP) related though, this is likely not the issue.

If the CPU profile dump can help you, happy to send it over email.

That would be great, you can reach me at: armiros (at) amazon.com.

How many of these subsegments are you creating for a single request? If you could also send or attach an example trace that couldn't get sent, or even just one of its subsegments, that could be very useful. It would also be nice to see the hierarchy of the subsegments to understand how useful the streaming threshold would be.

Far too many, clearly. In the latest instance where we managed to reproduce the issue, 3,700 SQL requests were sent to X-Ray, I suspect many more to have happened but not sent because of the numerous Segment too large issues. Note that this clearly should not have been engineered this way but because we create segments for workers too, so we expect such things to happen elsewhere. It seems like this amount of sub-segments is way over what X-Ray's user interface can cope with it too (it takes 30s+ to render), so maybe we should stop X-Ray'ing after a certain amount of sub-segments?

Do you know if you or any packages you depend on are doing any long-term polling processes in the background? Sometimes with captureHTTPsGlobal enabled those processes can accrue lots of subsegments over time which occasionally causes segmentTooLarge errors. If all/vast majority of the subsegments are SQL (as opposed to HTTP) related though, this is likely not the issue.

No, we don't have such things.

That would be great, you can reach me at: armiros (at) amazon.com.

Just did, with the raw X-Ray trace I mentioned above.

because they fail to send they're somehow left stale in cls-hooked, our context management system, causing memory leaks.

Your intuition is probably confirmed by the following graphs. We have isolated the faulty container (in orange) at 15:50 UTC (i.e. did not receive new HTTP traffic) and the 100% CPU usage continued until 23:25 UTC. This is also when the memory usage dropped by ~0.5G. Equally, we can see that there is still plenty of memory being used which probably should have been garbage collected.

Again, if that could help your investigation, we also took a Memory heap snapshot.

We will continue to investigate this. As a shot in the dark, are you using the AWS_NODEJS_CONNECTION_REUSE_ENABLED environment variable, and if so could you try disabling it and seeing if the same behavior is exhibited?

@willarmiros no, we don't have this environment variable enabled actually, sorry.

We will continue to investigate this. As a shot in the dark, are you using the AWS_NODEJS_CONNECTION_REUSE_ENABLED environment variable, and if so could you try disabling it and seeing if the same behavior is exhibited?

Hi again @willarmiros, I also work with @sroze - we do actually have this AWS_NODEJS_CONNECTION_REUSE_ENABLED setting enabled (I added it as part of an unrelated exercise, when we moved to using IAM roles for svc accounts on our Kubernetes cluster). We'll run some tests with it disabled and let you know how it goes.

Hi @artysidorenko  - Have you had a chance to look into this yet?

We are seeing a similar issue where we are seeing many Segment too large to send errors and subsequently our CPU is averaging around 60%. When we set the setStreamingThreshold to 1, the errors are gone and we have a normal CPU % again.
I'm not sure if this is the proper long term solution but it's at least getting us by for now. For some insight, we have an Express application where we kick off a 5 second setInterval to run a process indefinitely from within one of our routes. So I'm wondering if that has to do with the error messages we are seeing.

Hi @jmattiace,
It seems like that route with the indefinite process is probably not a good candidate for automatic tracing - so maybe you should define that route outside of the openSegment and closeSegment middleware, or manually call segment.close() segment.flush() to avoid it never closing.
However even with the segment too large errors, you should not be seeing that kind of CPU usage either.

Apologies for the super-late reply. I had moved teams and wasn’t really working much with Xray anymore.
I ran a couple of tests myself last week - locally, so the environment wasn’t exactly the same, though still using a daemon connected to AWS etc - but didn’t find that changing the TCP re-use env variable made any difference to the CPU consumption. (I did notice CPU and memory consumption shot up when the connection to the daemon gets dropped while processing traces, but I don't think that happened in the original issue).


test-branch/execute-job/comment-from-wrong-user-on-pr/3bedbae6-34e9-4821-8b64-e951a7b14bfc

PR for testing df1d706db41e2d82c7a80905dc1f338024ff365b

/canonical/self-hosted-runners/run-workflows df1d706db41e2d82c7a80905dc1f338024ff365b


FAQ: Does Kubeflow Support Helm

We should start an FAQ for Kubeflow.
One of the questions we get most often is do we support helm.
The answer to this should be something along the lines of:
You don't need to use ksonnet to use TFServing, TFJob, etc... You can define those resources using whatever K8s tooling you want; raw YAML, helm, kustomize, ksonnet.
We provide ksonnet mostly as convenient syntax sugar. The arena CLI might have helm charts if that's the route you prefer.

@jlewi Is it still true to say that people can define their resources using whatever K8s tooling they want? We seem to be pretty heavily invested in kustomize. Do we still get the question about helm support?

@sarahmaddox People can use whatever resourcing they want to create Kubeflow resources (e.g. TFJob, Seldon Deployments, Notebooks, they want).
Kubeflow's deployment infrastructure is closely tied to kustomize.

/area doc
/kind feature

Hello @sarahmaddox Would you please assign this issue to me? I will take care this.

Thanks @Swikar!
/assign @Swikar

Fixed by PR https://github.com/kubeflow/website/pull/1681
/close


Validation

I was wondering is there a way to do a list of validators with its corresponding error messages ?
So instead of doing this snippet of code on every input field:
<Control.text
validators={{
required: (val) => val && val.length,
emailValid: (val) => val && /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.test(val)}}/>

<Errors
messages={{
required: 'Required',
emailValid: 'Please enter a formatted email address'}}
/>

Basically group all of the validator on an external file then import it once and pass in what validators option I want to use per each Field? Etc one input field may just have maxLength of character and is required, and another field is just required. The error messages are pretty much going to be the same and just wanted to streamline that process.
Thanks

Sure, and this is a JavaScript solution not specific to RRF:
// validatorCreators.js
const validatorCreators = {
  maxLength: (len) => {
    const fn = (val) => val && val.length <= len;
    fn.message = 'Length is too long. Max: ' + len;
    return fn;
  },
  required: () => {
    const fn = (val) => val !== undefined;
    fn.message = 'Value is required.'
    return fn;
  }
}

export default validators;

And then in RRF:
import validators from './validatorCreators';

const maxLength = validators.maxLength(14);
const required = validators.required();

<Control.text
  validators={{ maxLength, required }}
/>

<Errors
  messages={{ maxLength: maxLength.message, required: required.message }}
/>


Fixes to the Trusted Types article

What's changed, or what was fixed?
In the Trusted Types help prevent Cross-Site Scripting article,

Added backticks around templateId where missing.
Added a missing "an" determiner before "arbitrary number of policies".
Removed an unnecessary "a" determiner before "source code".
Removed unnecessary comma.
Specified that the Trusted Types origin trial is available in Chrome 73 to 78, rather than Chrome 73 to 76. (See https://developers.chrome.com/origintrials/#/view_trial/171136785840078849.)

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


NVM not prescribed for shared develper boxes or build servers with multiple build agents

NVM works by using a symbolic link.  The problem is the link is pointed to a user's app data folder.  So if user x runs nvm use lts they will point node for the whole box to their app data folder.  If user y runs node or npm they will be directed to run files under x's user account and in the case of npm -g they will be modifying x's files which by default is not allowed.  So nvm is only prescribed for one developer box.  This goes for build servers too.  If two build agents on same vm/box, they can compete and cause odd behavior in the builds.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 745b8a68-b43b-83d2-54b6-32b3d2a35491
Version Independent ID: 599d0cee-8710-86ef-8093-fe1b08e4aa90
Content: Set up NodeJS on native Windows
Content Source: hub/dev-environment/javascript/nodejs-on-windows.md
Product: dev-environment
Technology: windows-javascript
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

Thanks for pointing this out @vbjay! I'm adding a warning note to the doc to help raise awareness of this issue. Really appreciate the contribution! <3

Commit with your update > https://github.com/MicrosoftDocs/windows-dev-docs/commit/85819734ddc1b96ad74e6ab715faae28f07c4767
Closing as resolved. Thanks again!


Black theme AMOLED

Add black theme "AMOLED" for save the battery

It is not important for his app as long as you don't stay long times using it.


TOML v0.5.0 support

Has anyone started working on it already?

Slight bump.
This looks like most popular PHP toml package. I hope once toml reaches 1.0 (currently RC) library will get in sync with the standard. :)

I would like to do that and as I said, any contribution is welcome

I support this, as 0.5.0 adds better date support:
https://toml.io/en/v0.5.0#local-date

TOML v1.0 is now a thing: https://toml.io/en/v1.0.0

I'd love to see 1.0 support. But, even getting up to 0.5.0 support would add the following:

number formats

hex
octal
binary

local date, local time, local date-time

They aren't a lot of new features between 0.5.0 and 1.0, but there are some stricter definitions in the spec.