EDS Enabled cart doesn't clear sessions when browser is closed

The normal way a cart is used in Koha is as temporary storage - its contents are cleared when the window is closed.
With EDS enabled and the files patched, the sessions are no longer cleared - closing the window and reopening it and then clicking on the "0 items in your cart," there will still be discovery things there.

I've noticed this as well. If EDS is enabled, the cart won't be cleared even for regular Koha items.
It looks like the cart info is being stored in bib_list cookies AND in local storage, but I don't think they're consistently updated.
At the moment, my cart says there are 18 items in it when there are actually 2. And even those two were actually from a previously cleared session...

After doing an "Empty and clear", I now have "-1" items in my cart... although after I tried to open that -1 item, it reset everything seemingly correctly...

Ahhh, I see the problem with the "18" items.
It's because of "jbib_list.length-1" (https://github.com/ebsco/edsapi-koha-plugin/blob/master/Koha/Plugin/EDS/js/EDSScript.js#L102). That's not getting the length of an array. It's getting the length of the string. So jbib_list is "12345678/901234567/" with a length of 19 - 1 = 18.
This goes back to wizzyrea's original problem... the cart shouldn't preserve data from previous sessions.
I assume local storage is needed for using the cart with Discovery, but perhaps another cookie should be used to determine if it's a new session or an on-going session...

Going to open some new issues and stop hijacking wizzyrea's...

Related to this problem... if you remove all items from the cart using the "Remove" link from within the cart, you'll always have 1 item left in local storage.
The cart will say there are 0 items if you click on it, and the search results will look OK, but if you re-open the cart or close the window and re-open it, the cart will re-gain that 1 item.

The more I think about this, the more I don't understand why "bib_list" is stored in local storage... will chat to Alvet about this today...

Apparently these 2 lines caused the problem.
//if (basketcount != jbib_list.split('/').length - 1)
//updateBasket(jbib_list.length -1);
This should be fixed in the latest versions of the plugin but will keep this open to allow for testing and confirmation.

Sorry, Alvet, but that wasn't the problem in this issue. I hijacked this issue with the count, but the actual problem is that the local storage is preserved between browser sessions. Typically, the Koha cart is emptied when a browser session ends because the cookie is destroyed, and that's the desired behaviour especially in regard to user privacy.
I think it would be wise to consider using sessionStorage instead of localStorage: http://stackoverflow.com/questions/18633715/remove-localstorage-on-closing-browser-javascript

You are right; data should be removed on unload. I am using jStorage as it manages cross-browser and it is set to retain for 30 minutes (by default but configurable) after which it expires but I’ll look at something that clears this data on unload or something similar.
$.jStorage.set('edsKnownItems',JSON.stringify(data),{TTL:edsConfig.cookieexpiry601000})

The default isn't 30 minutes. The default is eternity because the default value of cookieexpiry is an alphanumeric string and not a number. The name cookieexpiry seems to be a misnomer as well, since it's really local storage expiry rather than cookie expiry...
I've been looking at the TTL value more...
If the bib_list expires and then you close the browser, the cart will be empty when you re-open it because you won't have anything in local storage.
Otherwise, it looks like EDSScript.js will stuff the contents of localStorage's "bib_list" into the document cookie... whether that's for /cgi-bin/koha or /plugin/Koha/Plugin/EDS/opac depending on what page is visited.
By the way, if you set the expiry value too low, the cart won't work, because the local storage "bib_list" is only being set when in the opac-basket.pl.
The following lines should be used in the search results but they're only called in the opac-basket.pl specific block.
$('.addtocart').click(function () {
$.jStorage.set("bib_list", $.cookie("bib_list"), { TTL: edsConfig.cookieexpiry * 60 * 1000 });
});
$('.cartRemove').click(function () {
$.jStorage.set("bib_list", $.cookie("bib_list"), { TTL: edsConfig.cookieexpiry * 60 * 1000 });
});

Actually, sorry, that bit about the cart not working because of the expiry isn't quite right.
What I meant was... the local storage "bib_list" doesn't get set without visiting the basket. So if you add a few items to the cart, and then go to "Home" or any regular Koha page, your items won't appear in the cart because they weren't in local storage to be sucked up and stuffed into the cookie.
They'll only appear elsewhere in Koha if you visit the opac-basket.pl... and then only if the expiry doesn't destroy them first.

Personally, I'm starting to wonder if the regular "bib_list" cookie has a path of "/cgi-bin/koha" by intention or by accident. My guess would be that it's unintentional.
The majority of cookies in Koha use the root path, as they're set by CGI.pm which uses a default root path. The cart uses basket.js which uses window.document.cookie which uses the path of the document by default... which is "/cgi-bin/koha". If we change that to use the root path instead... we could spare a lot of grief.

This has been fixed in the newer version of the plugin.
I've updated to make sure that cookies set are Path cookies, and stopping the use of jStorage for the cart.


Error running csi_data_read_parse.py (AEGHB-259)

I was trying to run csi_data_read_parse.py using 2 ESP32-S3-WROOM-2 (one flashed with csi_recv and the other with csi_send) and these messages multiple times in the terminal:
element number is not equal
data is incomplete
As instructed in the README.md, I tried higher baud rates to avoid this issue, but I still get these messages. Is there another way to avoid this error?

Sorry, I couldn't successfully reproduce your problem. Is the information you mentioned appearing all the time or occasionally? The default baud rate is 961200, but it can be increased to 2MHz, you can also try it. Please feel free to let us know if you have any further questions or need further support.

Hello, @ge419
Closing this issue, feel free to reopen with more updates. Thanks.


Potential security issue: Possible SQL injection in the SQLx implementation

The current version of the tower-sessions-sqlx-store crate is vulnerable for sql injections as it uses format! on user provided potentially untrusted inputs:
https://github.com/maxcountryman/tower-sessions/blob/763133104290abb3fc4af6bbfd7a19609cb9fc39/sqlx-store/src/postgres_store.rs#L91

Thanks for flagging this.
Somewhat orthogonal, but there's also an open issue related to how the database URL is parsed: https://github.com/maxcountryman/tower-sessions/issues/27
I'm open to reworking this entirely to ensure better security and UX.


Change binary detection to also support umlauts and other special cha…

The previous implementation flags non-ASCII characters as binary, such as umlauts.
The new solution takes a different approach to recognizing whether it is a binary string.
Source: https://stackoverflow.com/a/76816100

hey there, thats super cool
i didnt know that
so basically i would love to merge it, could you maybe add a unit test to it? there are some existing, and it would be great to see how the change makes a new test green
and the changelog would also be nice to add
but i would also merge it without additional changes on your side
just if you would be happy to do so :)

Hi,
I have now extended the existing test and added a changelog entry.

hi @mjosef89
thats perfect thank you so much,
so I think I know get the impact, because you were just adding negative tests for umlaute, that means that strings with umlaute were accidentally recognized as umlaute TRUE? is that correct?
....because unit tests tell a story haha
if you could fix the pipe, i would merge it
also, there is a "make pr" command, if you run that in your dev-environment, that would ensure that everything is green
so it starts the fixer (you might need to commit this again in your git) and run all tests for you

Hi @boxblinkracer,

so I think I know get the impact, because you were just adding negative tests for umlaute, that means that strings with umlaute were accidentally recognized as umlaute TRUE? is that correct?
....because unit tests tell a story haha

Strings containing umlauts were previously recognized as binary, so the isBinary() function would return true in this case.
I added a few strings, some with umlauts/Non-ASCII chars to test that the method now always returns false in these cases, so they are indeed not binary.
I hope that fits, otherwise please let me know what I should change.

also, there is a "make pr" command, if you run that in your dev-environment, that would ensure that everything is green so it starts the fixer (you might need to commit this again in your git) and run all tests for you

Sorry, I didn't know that, but it's done now too


CFE-182: Add GCP e2e test

This PR adds test suit for GCP provider

/assign @alebedev87
/assign @lmzuccarelli

/retest

@alebedev87 I have added a GCP step in the ci pipeline https://github.com/openshift/release/pull/23923

@Elbehery - good work

/retest

/label tide/merge-method-squash
/lgtm

/approve

Premature LGTM, CI should have been added first. See https://github.com/openshift/external-dns-operator/pull/76 for the fix.


Tractor Startup Issue

Upon turning on electronics, Tractor turns over but does not start

Fixed, was a problem with the Estop . . . Carl.


Find string literals as a part of BinaryExpressions in jsx-no-literals

Fixes #1511

There exists tests for <Foo bar={`Test`} /> and  <Foo>{\`Test\`}</Foo>, but we could add one for <Foo bar={`Test ${baz}`} /> to be explicit(?)

@jaaberg that'd be great; also {foo + 'bar'}, {foo+bar} and {'foo' + bar}?

@ljharb Great, the tests actually uncovered another bug. The rule should find all strings/literals, so {`foo` + 'bar'} should actually give two errors, one for foo and another one for bar.
Added tests in f27ebc2 and fixed in 28581df.


MSID: 91540 Version: 3 DOI: 10.1101/2<IP_ADDRESS>5894

MSID: 91540
Version: 3
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>5894
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=91540
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5894

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/91540v3
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>5894
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/91540/v3/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

error: [junk-character-presence-3] p element contains a junk character '□' which should be replaced or deleted.


apc gateway availability

Hello, I'm trying to check out the apc gateway and see if we can integrate it into our Teams app that consume network performance and qod Camara APIs. Logged in with our corporate azure account but "apc gateway" is not available as service. Is it not available to public yet?
Thanks,
Olav

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 136ed942-a8e4-3e2a-65ee-4153f03446f6
Version Independent ID: 3eada061-2b33-8b51-cd63-8ec79be3ebbf
Content: Create an Azure Programmable Connectivity Gateway
Content Source: articles/programmable-connectivity/azure-programmable-connectivity-create-gateway.md
Service: azure-programmable-connectivity
GitHub Login: @anzaman
Microsoft Alias: alzam

Currently APC is in limited preview, but we are working on opening the preview to public shortly.

@olavnedrelid
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Always update shared folder from git

Right now deployer shared would install the shared directory
once; when the first deployment of e.g. a branch is running.
Adding items to a shared resource in git will not update the
deployments shared folder. This is often confusing for our devs
who are required to add some assets sometimes.
I'd suggest this simple "fix" to always update the shared folder
from the git repository.
Signed-off-by: Mark Kusch<EMAIL_ADDRESS>#####################################################################
I'm working on first LTS release of Deployer.
Please, consider supporting Deployer development on Patreon page:
https://www.patreon.com/deployer
#####################################################################

Q
A

Bug fix?
Yes and No

New feature?
Yes and No

BC breaks?
Yes or No

Deprecations?
Yes or No

Fixed tickets
N/A or xx

Do not forget to add notes about your changes to CHANGELOG.md
Easiest way to do it, by running next command:
php bin/changelog

This solution seems more practical and proper by default to me.
Normally the shared files are provided by GIT repository which means a user manages them and they may are expected to change and thus synced.


error while loading shared libraries: libpng16.so.16: cannot open shared object file: No such file or directory

Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.2 LTS
Release:	20.04
Codename:	focal
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.2 LTS
Release:	20.04
Codename:	focal
5.4.0-67-generic #75-Ubuntu SMP Fri Feb 19 18:03:38 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
executing
sh -x ./daedalus-3.3.2-mainnet-16919.bin
.
.
.
.

sed s|&&|%|g ; s|&_|&|g
head -c 1165601
true
. ../env
exec ../run
./nix/store/apzfc51a2aki7xdyzifldp1nm4w8a1am-nix-user-chroot-2c52b5f/bin/nix-user-chroot: error while loading shared libraries: libpng16.so.16: cannot open shared object file: No such file or directory
rm -rf /tmp/tmpx-20210319T111844Z-ba767b25

might be due to running out of disk space during the initial install, try rm -rf ~/.daedalus/ and then reinstall

@whosystem please let us know if what @cleverca22 suggested helped you to resolve the issue 🙏


Warm clothing

Here are some clothes from other mods that should have an insulation value associated with them.

Better Animals Plus

Wolf Capes
Bear Capes

Tinkers' Compendium

Wool Armor

Construct's Armory

Wool Armor

Not exactly as you wanted, but it is now doable. You can now specify armor material <=> conductivity bindings in the config under Heat category. This way, you can define the bindings you described yourself without adding optional dependencies for the mod. As such, I am closing this issue.


HMR doesn't work for Client Components loaded by Server Components

Instead, we see a full page reload:
2:22:14 PM [vite] page reload src/components/ProductDetails.client.jsx
2:22:14 PM [vite] hmr update /src/index.css?direct

My guess is that as far as Vite knows, the component has no importers because it is loaded dynamically from our hydration syntax.
Not sure how to resolve this one, other than to teach Vite that it's OK to hot reload it.

I guess vite knows that the .client. modules have importers, for example see:
      console.log(file, modules.map(module => module.importers));

/home/bagher/hydrogen/packages/dev/src/components/ProductDetails.client.jsx [
  Set(1) {
    ModuleNode {
      id: '/home/bagher/hydrogen/packages/dev/src/pages/products/[handle].server.jsx',
      file: '/home/bagher/hydrogen/packages/dev/src/pages/products/[handle].server.jsx',
      importers: [Set],
      importedModules: [Set],
      acceptedHmrDeps: Set(0) {},
      isSelfAccepting: false,
      transformResult: null,
      ssrTransformResult: [Object],
      ssrModule: null,
      lastHMRTimestamp: 0,
      url: '/src/pages/products/[handle].server.jsx',
      type: 'js',
      info: [Object]
    }
  },
  Set(1) {
    ModuleNode {
      id: '/home/bagher/hydrogen/packages/dev/src/components/ProductDetails.client.jsx',
      file: '/home/bagher/hydrogen/packages/dev/src/components/ProductDetails.client.jsx',
      importers: [Set],
      importedModules: [Set],
      acceptedHmrDeps: Set(0) {},
      isSelfAccepting: false,
      transformResult: null,
      ssrTransformResult: null,
      ssrModule: null,
      lastHMRTimestamp: 0,
      url: '/src/components/ProductDetails.client.jsx',
      type: 'js',
      info: undefined
    }
  }
]

And there's another reason for the deadEnd, that I need to look into! I'm gonna debug with vite itself tomorrow!

The deadEnd is because of ` entry-server.jsx, which vite says has no importers!

The deadEnd is because of ` entry-server.jsx, which vite says has no importers!

Ooh interesting solution! I'd love to see a PR if you're ready!

I'll propose a PR soon when I get it working correctly! Thanks for the opportunity!

I'll propose a PR soon when I get it working correctly! Thanks for the opportunity!


Support for bc-fips

Hello Team -
Is there a way to use this jar in fips mode ?
Following is what I currently have working in my gradle project but am unsure if this is the correct way to do it.
    implementation('org.c02e.jpgpj:jpgpj:1.1')
    implementation('org.bouncycastle:bc-fips:<IP_ADDRESS>')
    implementation('org.bouncycastle:bcpg-fips:<IP_ADDRESS>')

Security.addProvider(new BouncyCastleFipsProvider());

// I had to add this else the initialization fails
CryptoServicesRegistrar.setSecureRandom(
				FipsDRBG.SHA512_HMAC.fromEntropySource(
						new BasicEntropySourceProvider(
								new SecureRandom(), true))
						.build(null, false)
		);

I took a look at some of the classes being used like PGPSignatureGenerator and there look to be two implementations of it, one from bcpg-fips and another from bcpg-jdk15on which looks confusing.
I tried doing this in my build.gradle
implementation('org.c02e.jpgpj:jpgpj:1.1') {
        exclude group: 'org.bouncycastle', module: 'bcpg-jdk15on'
    }

But it fails with the following
Exception in thread "main" java.lang.NoClassDefFoundError: org/bouncycastle/openpgp/bc/BcPGPObjectFactory
	at org.c02e.jpgpj.Ring.parse(Ring.java:301)
	at org.c02e.jpgpj.Ring.load(Ring.java:273)
	at org.c02e.jpgpj.Ring.load(Ring.java:260)
	at App.readKeyRingUsingJPGPJ(App.java:35)
	at App.main(App.java:26)
Caused by: java.lang.ClassNotFoundException: org.bouncycastle.openpgp.bc.BcPGPObjectFactory
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	... 5 more

I would really love some help in figuring out what would be the best way to use this library in fips mode

Thanks for raising this issue! I don't think it's currently possible to use the BC FIPS jars with JPGPJ -- JPGPJ is hardcoded in a number of places to use the default (non-FIPS) BC implementation of various crypto primitives. JPGPJ would have to be refactored a bit to lookup the implementation of those primitives through JCA (which would then allow you to configure it to use the FIPS JCA provider).

Thanks for the quick response


[$250] [HOLD for payment 2024-11-14] [Custom feeds] Feed details explanations are missing

Reported here - find more details in the slack thread
BUG: Feed details pages for Visa/Mastercard/Amex are all missing the explainers that link to where to find the fields
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021857093201326774795
Upwork Job ID:<PHONE_NUMBER>326774795
Last Price Increase: 2024-11-14

Issue OwnerCurrent Issue Owner: @

No payments needed

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

The PR has been opened for the review.

Only payment is $250 to @allgandalf for C+ via Upwork

@allgandalf offer sent for $250!

Ah, I see. So you're being paid in bulk?

@joekaufmanexpensify Yes I have talked with @allgandalf @DylanDylann @dukenv0307 so we are going to collect all the issues and manage the payment in the end as that will be easier than handling this on individual issues. We also agreed that the base price will be $125 since there is plenty of these and they are often small and we can change to $250 on case by case basis
Once the checklist is complete, we can close

Makes sense! Will look out for the checklist then and close after

I actually don't think we need the checklist here. This wasn't introduced anywhere, it just got missed during implementation. Further, I already have this case covered in the manual test script, so it will be codified into a regression test when I pass those off to Applause. We should be all set here. TY!


The Game Service should have automated tests to make sure the functionality is tested

1240cff1aed0a3a82b5132f70811d8ad0bd6089e

https://github.com/sopra-fs23-group-20/server/commit/cef1fd006cc0ecc852429b4c662c9671fb38f9e6


Add timeout for running pytest (resolves #1735)

This amends the call to pytest in run_test.py by adding the option --timeout=600 which gives any particular test 10 minutes to run. I imagine this may be enough time for all of the tests. If it is not, we can increase the overall timeout by adjusting the option above, or any particularly lengthy tests can be given their own timeout by adding the decorator @pytest.mark.timeout(XXX) where XXX is some number of seconds.
This passes tests locally, but pytest-timeout may need to be installed on Jenkins for this to work.

Jenkins, test this please.

Boto throws 400 error. Let's try again. Jenkins, test this please.

@ejacox I moved this to sprint 7. It is essentially done—just waiting for tests to pass since boto has been throwing 400s. Getting this in the next release will make future development much easier.

@ejacox this is ready to merge!


colab demo

someone be so kind as to make a google colab to test this thanks :)

You can use the command line in this one, need to change the paths in the YAML to your own.
https://colab.research.google.com/drive/1e_LpbLCcgHEuvKXiw9G2XNTho3xB6ceK#scrollTo=DJxzTyuKbIX1

Thanks @G-force78

The gradio demo is giving Unexpected token '<', "<html> <h"... is not valid JSON error


CB-16240 When the user detaches a subnet from the env but that subnet…

… is used in a datahub or datalake and only one subnet added to the AZ the upscale failed with inrelevant message. The message added
See detailed description in the commit message.

retest this please


[FLINK-5852] Move handler JSON generation code into static methods

This PR is part of the History Server implementation. It is opened separately to make the review easier.
The primary change is that the JSON generation of job-specific REST responses was moved from various handleRequest methods into static methods. This will allow easier re-use. In addition several refactorings have been made and tests were added.
Other changes include:

added a utility method JsonUtils#addIOMetrics to aggregate IOMetrics
added a utility method JsonUtils#writeIOMetrics to write IOMetrics
added a utiltiy method JsonUtils#writeMinMaxAvg to write MinMaxAvgStats (checkpointing related)
added utility MutableIOMetrics class for easier IOMetrics aggregation in handlers
replaced job-related hard-coded JSON keys with static constants, defined in JsonUtils#Keys
added an additional constructor to the ArchivedExecutionConfig class for easier generation in tests
added BuilderUtils class for easier generation of Archived* classes in tests
modified IOMetrics to allow sub-classing without requiring usage of Meters
added a test for every introduced static method

@uce Thank your for the review. I've addressed all issues that you raised, either with further comments or changes.

@uce I've removed the JsonUtils class.

Thanks for addressing the comments. 👍
I had two last trivial inline questions. Could you go ahead an merge this and decide whether it makes sense to address the questions.

@uce I will address your final comments while merging.


Create Installing Catalyst

New Install page, linking to the windows / Linux / Mac installation pages with Anaconda.
Also writing about the alternativ installs with pip and pipenv.

Pull Request Test Coverage Report for Build 75

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 62:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 75

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 62:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Update README.md

Formatting changes.
Slash command list changed
General terminology cleanup

The README could have some screenshots to make things easier
Also for this piece:

Update the integration name and access. Finish the API integration set up clicking the Save Integration button.

We should specify which pieces of access are required for the integration

After generating the Opsgenie API key, you also have to press "Save Integration" in order for the key to be active


Next: Synchronize Product Page with Storefront UI

Related Issues
closes #4666
Short Description and Why It's Useful
Before these change we had Product Gallery as a SfImage component. Now Product Gallery is it SfGallery. I also fixed type AgnosticMediaGalleryItem and getter getProductGallery for better compatibility with SfGallery.
Screenshots of Visual Changes before/after (if There Are Any)
Before:

After:

Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey! i think there are far more changes in here than just a gallery. I suggest comparing 2 files I mentioned in the issue side by side to see what has changed. Product page is exactly the previous version of SFUI example so all you have to do is just copy paste the code without losing business logic and test ids

how it should look vs how it look like after changes


feat(webAPI): Remove filtering of empty collections when serializing response

Description

Related Issue(s)

#1355

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

Bug Fixes

Enhanced serialization logic for nullable collections, ensuring only non-nullable collections are serialized when containing elements.

Tests

Updated assertion logic in integration tests to require closer matches for DateTimeOffset types.
Modified dialog retrieval tests to no longer exclude missing members in assertions, improving accuracy in test validations.
Refined response handling in dialog search tests for better clarity and accuracy in expectations.

https://github.com/digdir/dialogporten/issues/1355#issuecomment-2451656524

Hm, hvis vi gjør om en List til å være nullable, gir det da ikke mening å initialisere den til null i stedet for [], slik at den da blir fjernet med Serializer.Options.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull som vi allerede bruker? Eller mener du noe annet?

@oskogstad


Update AESARadar to avoid mutating measurement model

The AESA radar measure function was previously written so that saved a reference to a measurement model with each detection that is later mutated. This code change it to use a deepcopy instead.

Codecov Report

Merging #191 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   91.93%   91.93%
=======================================
  Files         111      111
  Lines        3806     3808    +2
  Branches      548      548
=======================================
+ Hits         3499     3501    +2
  Misses        225      225
  Partials       82       82

Impacted Files
Coverage Δ

stonesoup/sensor/radar/radar.py
95.90% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1adcb3e...b0e9cac. Read the comment docs.


Incorrect reference to VM Availability Alert

I was looking at setting up an alert on my VM for when it becomes unavailable. Step 4 above references setting up alert based on metrics and shows selecting a VM in the picture.  In step 5 is shows "platform availability" as a metric that can be selected.  This option does not exist in the portal when creating an alert based on metrics for the VM.  I could not find one as well in the OMS agent extension.  Please let me know if there is another option.  Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c310132b-22c6-8d12-8986-a11d470bb140
Version Independent ID: d77c28b5-7cb4-26c6-6a78-36a5aede6054
Content: Create, view and manage alerts Using Azure Monitor
Content Source: articles/monitoring-and-diagnostics/monitor-alerts-unified-usage.md
Service: azure-monitor
GitHub Login: @msvijayn
Microsoft Alias: vinagara

@hcsmith1111 Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@hcsmith1111 - the screenshot used in the doc are samples, and indicative of the options/values will show up; will vary from each resource to another. As indicated in step 5, please refer to the linked doc to understand all the metrics supported for alerts; including those for Log Analytics.

For your reference, the image in step 5 shows the metrics shown for a Azure Storage Account (Microsoft.Storage/storageAccounts) and as stated before its there as a sample to show how the Azure portal will list out various supported metrics in the signal page.

#please-close

Thanks for your prompt response!


2819/get assistance page

Pull Request Template
Issue Overview
This PR addresses #2819

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have added QA notes to the issue with applicable URLs
[x] I have performed a self-review of my own code
[x] I have reviewed the changes in a desktop view
[x] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[x] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
QA Notes:
Entry point: http://localhost:3000/ - any page

Notice Get Assistance page in navigation bar instead of Resources
Visit page (/get-assistance) and compare layout to Figma mockup
Click through links and ensure they link correctly

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Adrien and I did an in-person PR review. There are few questions for Jesse and a few minor code cleanups and then LGTM!

@emilyjablonski Good call. I removed the section padding bc it was doubling the component padding on some screen widths, and since the Contact aside is used on multiple pages and has built-in padding (and so do other reusable components i.e. MarkdownSection) - I figured this would be a better solution for now. LMK if that works for you!


请问代码什么时候可以开源？尝试过中文效果吗

属于是没活儿硬整了！

Hi, thank you for your interest in our work, and apology for the late reply. We plan to release the code upon acceptance and sorry for the inconvenience.
We have not tried Bridge-TTS on Chinese datasets by ourselves yet. We are happy to address questions regarding the technical details of Bridge-TTS if there are any :-).


Add Google Search process as an activity

The process of "googling" an organization strategically to identify staff, partners, locations, and sites needs to be added to the remote section as an example. We only have the automated and technical searches currently.
e.g.
link:site.org
related:site.org
site:site.org filetype:pdf (for metadata)
site:site.org filetype:doc  (for metadata)
filetype -> xml, xlsx, docx, etc...

423bb55 (to test) adds basic instructions for this exercise

Pushed to master


Laravel 10.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:

Checkout the l10-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/torchlight-laravel.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "torchlight/torchlight-laravel": "dev-l10-compatibility",
    }
}

Finally, run: composer update


How are skillshots decided?

Currently, skillshots.json lists out Mirana arrow, Pudge hook, Clockwerk hook, and Invoker sun strike. I suppose these are some of the hardest skills in the game to hit, and they're listed there for that reason.
However, I do think that in terms of analysis for a greater pool of heroes, it would make sense for each hero to measure their own efficiency in terms of missable skills, instead of the globally hardest skills. For example, a Batrider would like to know if he hit his flamebreak efficiently, and a Lina would want to know if she hit her Light Strike Array well.
At the very least, I do think there are a few skills missing from this list. Ancient Apparition's Ice Blast comes to mind.
Perhaps more data could be added as well, so we know the ideal ratio of hits to uses for each ability added.

It's manually determined, and we just picked some abilities that cause single instances of damage and are skill-based. We could definitely add more detail via additional curation, maybe in a separate file?


Igore compiler output formatting directives like EJECT, SKIP1

An almost trivial issue, but currently such occurrences in source code lead to parsing-errors.
I think it's an IBM extension only and no real standard - well you know, COBOL ... -
but output formatting commands like the following should be recognized (and ignored) by the parser:

EJECT
SKIP1
SKIP2
(maybe even SKIPn n=3,4...?)

typically these listoutput formatting commands are written on a single line, everywhere in the code and have no semantic meaning at all.
SUPPRESS - like mentioned in https://github.com/uwol/cobol85parser/issues/15 falls into the same category, though this output suppressing command is typicall written following a copy xxx statement.

Yes, the parser indeed should be able to cope with these real-world imperfections. Fixed in 0112a1549dc7b6e45d6ed7a33f5be30c4460b763 and added to the ASG, in case anyone wants execute these statements :-)
Thanks!


Challenge 1 decentralized staking

Could you please provide a description of what you are accomplishing with this PR?

The code snippet is duplicated on the readme. Just removing one.


Duplicates

Need to think of a way to handle duplicates properly.
One idea is that in the frontend we can have a duplicate filter that does a search for licensedTo being on more than one customer row in the database and allow you to merge those. The key here is showing when the one was last updated.

This logic on the backend needs a bit of work also. The big question, what if a customer changes their siteURL. How do we handle it?


Create VDC chatflows for the blockchain solutions

Description

[ ] DigiByte
[ ] Dash

this is blocked and to be continued once  https://github.com/threefoldtech/vdc-solutions-charts/issues/49 and https://github.com/threefoldtech/vdc-solutions-charts/issues/13 are done

this is blocked and to be continued once  https://github.com/threefoldtech/vdc-solutions-charts/issues/49 and https://github.com/threefoldtech/vdc-solutions-charts/issues/13 are done

move to project sdk 11.2 / grid 2.5

move to project sdk 11.2 / grid 2.5

new issue on digibyte helm chart only for 2.4 #66

close this issue
we make 1 issue per 1 blockchain node solution from now on.
new issue on next bc widget:
https://github.com/threefoldtech/js-sdk/issues/2566


Create separate formatUnit and formatNumberAndUnit function

This is to make it possible format value and unit differently.
Also cleaned up the formatNumberFn args as it is not used anymore.

I ended up reverting creating two separate functions but use translateUnit for i18n for the unit formatting only.


pull optimistic locking up into store features

also cleaned up a bunch of unused import

Let's talk about it in #1135.
Also, please don't combine import cleanups with other changes.  It's all one commit, so there was no easy way for me to see just a diff of your optimistic locking feature tweak -- I had to scroll through a wall of banal import changes to find it.  Import cleanups are okay, but they're easier to handle in a separate commit (and preferably in its own PR).


Add support for cluster-level registry(rke) for shell and helm

Need dependency of https://github.com/rancher/steve/pull/15

https://github.com/rancher/rancher/issues/30735

https://github.com/rancher/rancher/issues/31618

This PR adds an Enviroment variable(setting) to cluster agent so that the system-default-registry or cluster-level registry is passed into steve agent. The steve agent will use this variable to launch shell images used in helm and kubectl, instead of copying setting from management rancher.


Add missing content

Hi @charliethinker, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@charliethinker  thanks!


Expose rodio feature

Just a quick expose of the feature, so that external crates can rely on the rodio integration.

module was private, so I'm not sure this is the way to go


dagster: support dagster 1.5.x

Problem
The dagster integration needs to get event records by calling DagsterInstance.get_event_records() method with a EventRecordsFilter. The current dagster integration has been broken since Dagster version 0.15.0 due to API change on EventRecordsFilter which requires a DagsterEventType.
Closes: #2043
Solution
In the factory method openlineage_sensor, an additional argument concerned_event_types is added with default value including events in PIPELINE_EVENTS and STEP_EVENTS. When getting event records, the dagster integration constructs EventRecordsFilter for each DagsterEventType embraced in the given concerned_event_types argument. The results will be consolidated and sorted against timestamp of event record.

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
One-line summary: get event records for each target Dagster event type to support Dagster version 0.15.0+
Checklist

[X] You've signed-off your work
[X] Your pull request title follows our guidelines
[X] Your changes are accompanied by tests (if relevant)
[X] Your change contains a small diff and is self-contained
[X] You've updated any relevant documentation (if relevant)
[X] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Codecov Report

Merging #2220 (7bf9a08) into main (5399e56) will increase coverage by 18.61%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@              Coverage Diff               @@
##               main     #2220       +/-   ##
==============================================
+ Coverage     81.38%   100.00%   +18.61%
==============================================
  Files            90         5       -85
  Lines          3799       173     -3626
  Branches         33         0       -33
==============================================
- Hits           3092       173     -2919
+ Misses          668         0      -668
+ Partials         39         0       -39

Files
Coverage Δ

integration/dagster/openlineage/dagster/sensor.py
100.00% <100.00%> (ø)

integration/dagster/openlineage/dagster/utils.py
100.00% <100.00%> (ø)

... and 85 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@tsungchih  would you like to rebase to HEAD origin/main? Current CI process detects changes between latest main and dev branch so it runs pipelines for Spark, Airflow etc.

@JDarDagran Allow me to make myself clear. Do you mean to execute git rebase HEAD origin/main?

# Make sure your local branch is up to date with the remote main branch
git fetch origin

# Rebase your local commits on top of the latest commits from the remote main branch
git rebase origin/main

# Push rebased commits
git push my-branch --force-with-lease

Many thanks for the guidance. I ran the following commands and there's nothing changed. Am I missing something??
❯ git fetch origin
❯ git rebase origin/main
Current branch dagster/support-dagster-1.5.x is up to date.
❯ git push --force-with-lease origin dagster/support-dagster-1.5.x
Everything up-to-date

@JDarDagran I saw the CI pipeline is failed. Did I mess up something? Wanna know where the problem is for my operation (pull -> merge -> commit -> push) so that I won't make mistake again.

@tsungchih main was broken. branch needed rebase, I let myself do it.
Merging it, thank you so much for you cooperation and contribution! 🚀

@JDarDagran Many thanks! Do you mean I should perform rebase instead of merge when I was pulling changes from the remote branch??

Rebase/merge is quite the same in this case for me. I've applied changes from origin/main so the CI doesn't fail.


German App Name

Would it be possible to give the App another name for german users?
I always forget the name "Character Map UWP". I would love to find it as "Zeichentabelle UWP" instead.

tracked in #258


[5.5] Add Eloquent Features: withSum,withMax,withMin,withAvg etc.

#18303
Add feature to 5.5.

`    Example:
$row = Post::withSum('comments|like')
    ->withMax('comments|like')
    ->withMin('comments|like')
    ->withAvg('comments|like')
    ->first();

$row->toArray()

like data: 1,2,3,4,5
expect:
[
    ...
    'comments_sum' => 15,
    'comments_max' => 5,
    'comments_min' => 1,
    'comments_avg' => 3,
];`

A pipe is an interesting character to be using for such a thing :expressionless:

I was thinking the same. A comma might make more sense in this case.

Why isn't dot applicable here?

@decadence the dot is used for nested relationships

Which is not supported by withCount and these methods.

Maybe use the colon name:column
This is also used in the rules for example unique:posts - rule:column

@decadence
dot(.) is used in nested relation
any better suggestion?

I don't understand how it conficts here if these methods don't support nested relations.
Anyway I'm fine with any separator.

I don't think I'm going to add this for now. It may be macroable?

Not sure why this issue didn't reference #16815.  That seems to solve the problem with a more sensible , to separate the arguments, rather than combining them on a pipe.
Unfortunately all three PRs (#16815, #18303, and #19363) seem to lack decent unit tests (all I see are assertions on the final generated queries).

Actually, if separating out the relation and property names into two separate arguments is a problem (for example, when you want to apply constraints), what about the ~ character as a separator?  There is precedent to using it for parent-child relationships, for example in CSS.
I do believe that : would be the best, but unfortunately that already appears to have special meaning, at least in Laravel 5.4: https://github.com/illuminate/database/blob/5.4/Eloquent/Builder.php#L1067

Just one more comment: it might also be worth implementing a withNumericAggregate method to parallel the numericAggregate method in Query\Builder: https://github.com/illuminate/database/blob/5.4/Query/Builder.php#L2032-L2059
This converts null sums/averages/etc to 0 and casts all aggregates to an appropriate int or float.


The calendar view should show the email address of students to teachers

In that way would be easier to contact students in relation with the meeting.

this has been added, will be live in the next update


DOCKER_BUILDKIT requirement.

Followed the instructions to get WAS and with the "build" received this message:
Step 4/8 : RUN --mount=type=cache,target=/root/.cache pip install -r requirements.txt
the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled
I did the:
bert@ubuntu-willow:~/willow-application-server$ sudo DOCKER_BUILDKIT=1 docker build .
[+] Building 40.2s (10/10) FINISHED
=> [internal] load build definition from Dockerfile                                                                                0.1s
=> => transferring dockerfile: 252B                                                                                0.0s
=> [internal] load .dockerignore                                                                                0.1s
=> => transferring context: 2B                                                                                0.0s
=> [internal] load metadata for docker.io/library/python:3.11.4-slim-bookworm                                                                                0.0s
=> [internal] load build context                                                                                0.2s
=> => transferring context: 238.39kB                                                                                0.0s
=> [stage-0 1/5] FROM docker.io/library/python:3.11.4-slim-bookworm                                                                                0.4s
=> [stage-0 2/5] WORKDIR /app                                                                                0.1s
=> [stage-0 3/5] COPY requirements.txt .                                                                                0.1s
=> [stage-0 4/5] RUN --mount=type=cache,target=/root/.cache pip install -r requirements.txt                                                                       35.6s
=> [stage-0 5/5] COPY . .                                                                                0.2s
=> exporting to image                                                                                3.6s
=> => exporting layers                                                                                3.6s
=> => writing image sha256:ba9622daee85ebe568e86ed098b9b83a0217883e12663035f5cd284b6ead2b1a
But  when I tried to run the ./utils.sh build - I got the same error message:
bert@ubuntu-willow:~/willow-application-server$ sudo ./utils.sh build
Using configuration overrides from .env file
WAS IP is <IP_ADDRESS>
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 11807  100 11807    0     0  67806      0 --:--:-- --:--:-- --:--:-- 67468
Sending build context to Docker daemon  290.3kB
Step 1/8 : FROM python:3.11.4-slim-bookworm
---> be2470db10f7
Step 2/8 : WORKDIR /app
---> Using cache
---> 27388a12e556
Step 3/8 : COPY requirements.txt .
---> Using cache
---> a5257dcd5a13
Step 4/8 : RUN --mount=type=cache,target=/root/.cache pip install -r requirements.txt
the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled
Where do I go from here? What am I missing?

LOVE IT!
I could not do the build from scratch (as above) - but I did the docker run and flashed all the ESP_BOXes (and one-lite) I have.
Really, truley LOVE this - it is SO much easier.
I think we are ready for Home Assistant integration!
THANK you!

I ran this command, and not it seems that the build went a little further:

DOCKER_BUILDKIT is a pretty standard and reasonable requirement for anywhere near recent docker installations - it's been the default in docker for quite some time.


Unknown option --from-git= ...

this http://tonsky.me/blog/disenchantment/ (scroll to bottom) made me curious, but:
error message:
Option parsing failed: Unknown option --from-git=https://github.com/eyelash/xi-gtk.git

reproduce:
Debian https://flatpak.org/setup/Debian/
had to manually change it to sudo apt install flatpak flatpak-builder
flatpak --version; flatpak-builder --version
Flatpak 0.8.9
Flatpak 0.8.9

flatpak-builder --from-git=https://github.com/eyelash/xi-gtk.git --install-deps-from=flathub --install ~/.xi-gtk-build flatpak.json

looks like the Debian included flatpak version is too old for your command?  How to upgrade? Thanks.

Yes, it looks like your version of Flatpak is too old. There's a much newer version of Flatpak in the Debian backports repository.

Thanks a lot! Yes, looking good:
I did this
sudo nano /etc/apt/sources.list.d/backports.list
         deb http://deb.debian.org/debian stretch-backports main
sudo apt update
sudo apt -t stretch-backports install flatpak flatpak-builder
flatpak --version; flatpak-builder --version

Flatpak 1.2.4
flatpak-builder 1.0.5

in the end I got this
flatpak-builder --from-git=https://github.com/eyelash/xi-gtk.git --install-deps-from=flathub --install ~/.xi-gtk-build flatpak.json
...
error: Flatpak system operation ConfigureRemote not allowed for user
Install failed: Child process exited with code 1

so I redid it with sudo and force-clean
sudo flatpak-builder --force-clean --from-git=https://github.com/eyelash/xi-gtk.git --install-deps-from=flathub --install ~/.xi-gtk-build flatpak.json

was that right?

was that right? or is there a better way?

You shouldn't need sudo for running flatpak-builder but I'm not sure what happened here.

small usability problem: I can just press X and it closes a file even if there were recent changes. One is not asked to save the file before exit.

There is #25 and xi-editor/xi-editor#913 for that.


Add new Fast Reconnect related properties

Basic or Enhanced Fast Reconnect can be enabled by third party stacks to dictate the method by which sessions are reconnected to. Added documentation of these new properties.

@kalakshm : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Sass: Adding Bootstrap with a Custom Theme

Hi!
I started playing with React and I thought "Create React App" was the right Kit. I wasn't wrong because the kit is really good and well documented. Simple and efficient!
But there is one thing that I really miss: sass integration within the project for bootstrap stylesheets.
Now, I understand the reasons why sass is not integrated: in theory we might use composition and perfectly encapsulate all the components. But the way you suggest to customize a bootstrap theme is really inconvenient.
I mean, don't get me wrong but creating an npm package for changing bootstrap sass-variables doesn't fit in the normal workflow development of a demo / application. Say my designer wants to change the primary color just to see how bootstrap-components look like: I think it should be one line of code (on the fly), not a new package.
I know I might use npm-link to speed up the workflow... But I feel it is really not the case.
So I wonder: is there any plan to integrate sass? I think the angular-cli approach (a parameter --style) would be perfect.
Composition is great, but sass is a standard de facto for many popular libs.
My 2 cents,
Maurizio

I was able to get this working in our app which is based on create-react-app. Hopefully this is useful...
I found this to be helpful, but it requires you to eject: https://medium.com/@Connorelsea/using-sass-with-create-react-app-7125d6913760
We chose not to eject, which was nice because I could then upgrade react-scripts over time.
Instead of ejecting, I used npm-run-all. The one issue is that I can't add sass-loader, but I found this to be a reasonable alternative.
The general approach I took:

npm install --save-dev node-sass
npm install --save-dev npm-run-all
Add the following to package.json

    "build-css": "node-sass --precision 10 src/ -o src/ --include-path src/",
    "watch-css": "npm run build-css && node-sass --precision 10 src/ -o src/ --include-path src/ --watch --recursive",

Convert or add at least one sass or scss file.
Modify start and build scripts to build css:

    "start-react-scripts": "export NODE_PATH=src/ && react-scripts start",
    "start": "npm-run-all -p watch-css start-react-scripts",
    "build": "export NODE_PATH=src/ && npm run build-css && react-scripts build",

Bring in the sass files from bootstrap and import as appropriate.
Bring in Bootstrap Sass, etc...

This works well for us, giving live-reload, etc.
I tested this example on GitHub as a new create-react-app build. This is a minimal change to demonstrate bootstrap sass integration.
Hopefully this helps as an alternative.
Ideally, of course, we'd be able to modify webpack config and bring in sass-loader, etc. This would allow better sass integration.

Windows users
"scripts": {     "build-css": "node-sass --precision 10 src/ -o src/ --include-path src/",     "watch-css": "npm run build-css && node-sass --precision 10 src/ -o src/ --include-path src/ --watch --recursive",     "start-react-scripts": "set NODE_PATH=src/ && react-scripts start",     "start": "npm-run-all -p watch-css start-react-scripts",     "build": "set NODE_PATH=src/ && npm run build-css && react-scripts build",     "test": "react-scripts test --env=jsdom",     "eject": "react-scripts eject"   },

Integrating sass-loader and CSS Modules together would be the best way to work with .scss files and also customizing Bootstrap SASS

@jazeee thank you very much for sharing your experience (and sorry for the huge delay in answering you!).
Well, I thought about the approach you propose, but I'm still not 100% I like it: you end up having double the files with potential issues related to imports (say by mistake you import the *.sass instead of .css). But, there is no other way...
In the end, I think I will (sadly)

eject and modify the webpack.config.js
or fork react-scripts following 682.

I would also like to have typescript / css-modules / ... Something like d3-starter-kit, a simple project I setup some days ago.
I hope they will improve the situation very soon. Right now you cannot use it (as it is) for a real project!

This is the approach I took to be able to control the customization of Bootstrap by overwriting the bootstrap sass variables.
Summary

Install and copy the assets from bootstrap-sass into src/bootstrap
In App.scss, import your own _variables.scss or just overwrite certain variables, set $icon-font-path: 'bootstrap/fonts/bootstrap/'; then import bootstrap with @import 'bootstrap/stylesheets/_bootstrap.scss';

Detailed steps
Per the SASS preprocessor instructions here.
npm install --save node-sass-chokidar

Now you can rename src/App.css to src/App.scss

Add sass version of bootstrap to control sass preprocessing to customize your theme.
npm install --save bootstrap-sass
Add cross-platform cp ability to npm-script to copy boostrap assets to src/bootstrap.
npm install --save shx
   "scripts": {
+    "prebuild-css": "shx cp -R node_modules/bootstrap-sass/assets src/bootstrap",
+    "build-css": "node-sass-chokidar src/ -o src/",
+    "watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive",
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test --env=jsdom",

Then in App.scss overwrite $icon-path-path to avoid this error:
Failed to compile.

./src/App.css
Module not found: You attempted to import ../fonts/bootstrap/glyphicons-halflings-regular.eot which falls outside of the project src/ directory. Relative imports outside of src/ are not supported. You can either move it inside src/, or add a symlink to it from project's node_modules/.

In App.scss
/* Bring in your custom variables */
@import '_variables.scss';

/* or just overwrite a variable */
$headings-color: #F00;

/* Set $icon-font-path from sass-loader issue #40, https://github.com/webpack-contrib/sass-loader/issues/40#issuecomment-70269553 */
$icon-font-path: 'bootstrap/fonts/bootstrap/';
@import 'bootstrap/stylesheets/_bootstrap.scss';

@willhlaw when you mention "Install and copy the assets from bootstrap-sass" -- Which bootstrap-sass are you referencing? The bootstrap-sass here: https://github.com/twbs/bootstrap-sass -- it is still using Bootstrap 3 not Bootstrap 4. I'm trying to solve the same problem but with Bootstrap 4

@bhellman1, above instructions are for Bootstrap 3. Below works for 4.
This is the approach I took to be able to control the customization of Bootstrap 4 by overwriting the bootstrap sass variables.
Summary

Install and copy the assets from<EMAIL_ADDRESS>into src/bootstrap
In App.scss, import your own _variables.scss or just overwrite certain variables, then import bootstrap with @import 'bootstrap/bootstrap.scss';

Detailed steps
Per the SASS preprocessor instructions here.
npm install --save node-sass-chokidar

Now you can rename src/App.css to src/App.scss

Add sass version of bootstrap to control sass preprocessing to customize your theme.
npm install --save<EMAIL_ADDRESS>Add cross-platform cp ability to npm-script to copy boostrap assets to src/bootstrap.
npm install --save shx
   "scripts": {
+    "prebuild-css": "shx cp -R node_modules/bootstrap/scss src/bootstrap",
+    "build-css": "node-sass-chokidar src/ -o src/",
+    "watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive",
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test --env=jsdom",

Then in App.scss
/* Bring in your custom variables */
@import '_variables.scss';

/* or just overwrite a variable */
$headings-color: #F00;

@import 'bootstrap/bootstrap.scss';

Very good answer @willhlaw thanks a lot. For this purpose, it's clearly better than use npm eject


Unable to see options for install and instantiate for smart contract

VS Code version:- Version: 1.60.2
IBM Blockchain Platform version:- 2.0.4
There is no option for install and instantiate for smart contract at IBM Blockchain platform after packaging. Please see the attached screenshot. Instead of install and instantiate option there is a Deploy smart contract option is there. But deployment failed with error :-
Failed to install on peer Org1 Peer with reason: Error: Could not install smart contact received error: failed with status:500 ::failed to invoke backing implementation of 'InstallChaincode': could not build chaincode: external builder failed: external builder failed to build: external builder 'node' failed: exit status 1 [10/1/2021 12:43:58 PM] [ERROR] Failed to deploy smart contract, Error: Package was not installed. No packageId was returned

I failed to find what's wrong with this, any help?

exact same issue here.
@raviatri, @saki-osive solved this issue?


[16.8.6] Aggressive cleanup to assist garbage collection

At Discord, we were experiencing serious memory leaks when upgrading to React with Fiber internals. We spent a lot of time investigating but ultimately ended on this fork to unblock us. These changes are made on top of the tagged 16.8.6 release.
If you want to try this build, you can use use "react-dom": "discordapp/react#cfda84f6b3c49a1398709cf43b3b959366f7e01a" to your package.json.
I still don't know whether the root cause of the memory leak is in userland or framework design. I do know the node-to-node pointers and fiber <-> host pointers make big memory leaks possible. See associated discussion in https://github.com/facebook/react/pull/15157.
Changes
b0194a0
Clear the Fiber node's nextEffect pointers when finishing effect processing. This helps alleviate the long fiber chains that we saw in the profiler.
d28ee48
This clears the stateNode (pointer to DOM node and class instances) described above when unmounting. It appears it's easy to keep references to detached DOM nodes from leaking fiber nodes.
2e5ee2f and c31cc03
At this point, we're desperate. On unmount, I clear the host node's pointer to the Fiber node. This is most definitely a hack but with this change, we are no longer seeing memory leaks.

@paulshen We're seeing basically the same issues you guys at discord are observing! Will give this patch a shot tomorrow. Just here to thank you for digging into this!

@paulshen  this patch save my day!

Thanks @paulshen! Our app memory footprint decreases to 300mb from almost 5gb using this patch.


Fix misplaced key in TableOfContents plugin

#3786 includes this fix, if merged.

Thank you zignis, https://github.com/facebook/lexical/pull/3786 is ready to go and also bundles in some additional fixes, would be OK with merging his that would save him from merge conflicts?


Inline edit component updates

@jirikavi have a look at these modifications. this would bring your component more inline with how the other generic components operate. Below is a list of the modifications made:

Minimal style modifications
view templating
HTML props
Enter/Esc key handling
auto focus & select all on edit
bootstrap input group
generic value typing (view model)
view model commands for each action

ok @jirikavi I think this one is good to go. Give it a once over and let me know if you have any questions or concerns before we get these updates into develop

Thank you @patsissons  for the review. It looks much more consistent. There are few code constructions or methods I didn't know about and are useful.
one of those can be:
  private renderEditor() {
    const { className, props, rest } = this.restProps(x => {
      const { controlId, inputType, keyboard, template, editTemplate } = x;
      return { controlId, inputType, keyboard, template, editTemplate };
    });

I was also looking for this:
Observable.of(this.value())
I am fine with merging it except one thing which I might miss but it doesn't seem to me that it is possible to achieve. I need to pass a command function after saving the new value (mainly due to calling DB update). Is is possible in the current code?

this.restProps(...) is a custom function in this framework, a stop-gap until rest/spread is possible in typescript 2.1.3.
There isn't much good info on doing React stuff, but check out the TypeScript Handbook and RxJS API Docs (though note these are for the newer version so might not be completely compatible).

So the existing strategy for on save callback was to simply attach to the results of the save command (as seen in the demo. This, however, introduces an issue in that the save operation is a side effect of the save command execution, which means that the result of the save is not a dependency of the command's execution.
My proposal to fix this is to add a new optional param to the constructor to handle the async save operation, in the form onSave: (value: T) => Observable<T> (which would default to x => Observable.of(x)). This strategy permits both my existing (side effect) saving as well as async dependency saving.

Ok then I will try to implement your proposal. Thank you for the links Pat.
I will look at them.
po 14. 11. 2016 v 11:29 odesílatel Pat Sissons<EMAIL_ADDRESS>napsal:

So the existing strategy for on save callback was to simply attach to the
results of the save command (as seen in the demo
https://github.com/marinels/webrx-react/pull/3/files#diff-12e8c90f614c7a70f5ae86bf69d5ecb2R196.
This, however, introduces an issue in that the save operation is a side
effect of the save command execution, which means that the result of the
save is not a dependency of the command's execution.
My proposal to fix this is to add a new optional param to the constructor
to handle the async save operation, in the form onSave: (value: T) =>
Observable (which would default to x => Observable.of(x)). This
strategy permits both my existing (side effect) saving as well as async
dependency saving.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/marinels/webrx-react/pull/3#issuecomment-260436375,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5iDCCveTYE2U2yj642fIAnt2qHWL3hks5q-LaLgaJpZM4KvmkW
.

@jirikavi i should mention I'm already half done the proposal :)


changed "has" to "had"

When read as "has" it makes an ambiguous argument that JGroups currently "has" these deficiencies, which is the opposite point of what the statement is trying to make

Alex
Thanks for the corrections to the text.
Generating one PR for changing a few characters at a time is expensive. A lot of manual work has to be done to process these PRs: reviewing, merging, closing. How about combining all your typographical changes for the docs into one large PR and submitting it instead?

Sure, sorry I've just been making PR's as I'm reading through the whole set
of documentation.
I will close the individual PR's and make one PR
On Wed Jan 07 2015 at 1:32:56 PM Richard Achmatowicz <
<EMAIL_ADDRESS>wrote:

Alex
Thanks for the corrections to the text.
Generating one PR for changing a few characters at a time is expensive. A
lot of manual work has to be done to process these PRs: reviewing, merging,
closing. How about combining all your typographical changes for the docs
into one large PR and submitting it instead?
—
Reply to this email directly or view it on GitHub
https://github.com/belaban/JGroups/pull/192#issuecomment-69067835.


Manager is not installing the apk

So I gave manager install app from unknown source permission but it's still showing me failed to install the apk.
Here's the log:
05-18-2024 8:39:10pm [I] Done. Output APK: /storage/emulated/0/Android/data/io.github.pyoncord.manager/cache/229020/patched/lspatched/config.en-229020-407-lspatched.apk 05-18-2024 8:39:10pm [I] Installing apks 05-18-2024 8:39:28pm [E]  05-18-2024 8:39:28pm [E] INSTALL_FAILED_INTERNAL_ERROR: Permission Denied

Relevent to https://github.com/vendetta-mod/VendettaManager/issues/73
Also include device info

Alright disabling MIUI optimization worked while installing the app.
Thanks.


WTF facebook.What is wrong with you.COPYRIGHT

so when i saw this script i was amazed by the work of the developer and i respect him for making such an awesome script .i shared it on my facebook profile and look today what i got
http://image.prntscr.com/image/16ad0cd0327c433abc53e7e7f5b3537a.png
http://prnt.sc/en6zoz
I mean like wtf.how does this includes in copyright?

Ha ha.. Looks like someone reported this repo to facebook.
And it doesn't seem to be reported by some Kiss* website but by some other website/download tool author who won't like this script to become popular. 😂

Generally the anime websites provide download links which is attached with some advertising sited through which they make money. In our case(i.e using the script) we are using another downloading tool and hence some of the reported this issue.
By the way It is an awesome script Avi and I loved it and  tend to use most of the time.


the format of ./data/image_list.txt in CelebA-HQ

Can you tell me the format of  ./data/image_list.txt in CelebA-HQ?

It looks like this:
idx         orig_idx    orig_file   proc_md5                          final_md5
0           119613      119614.jpg  0be7e162e25c06f50dd5c1090007f2cf  d76ed3e87c8bc20f82757a2dd95026ba
1           99094       099095.jpg  1e2d301e9b3d1b64b2e560243b5c109c  c391ae358c1a00e715982050b6446109
2           200121      200122.jpg  99aa914661dc10dfbaf14579757f6ab8  a131f037e52aa1011a90cf78f7b0cd88
3           81059       081060.jpg  ff2a42ed253c393c3cebe37c456c47fb  9908aba4e7dbee68224726dd97ee21fa
4           202040      202041.jpg  8a249cfe4671d3f53eba90c6f1762005  464440733a22e53073575cd4081f5501
5           614         000615.jpg  b7a5764aa444aa2751055847dd09f0bc  017ae5a8bf65cf7350dd4683795191ae
6           50915       050916.jpg  c2a912357074ac7209cc2227bf9ca35d  30958d171935bc5fd5dc4cbfacbd9ebb
7           166545      166546.jpg  b0b48c4849c077b28fb13f51825a6eec  8d03e6ff3d927db8fad64e600ba4628b
8           143861      143862.jpg  ef679abb4540e36bf86753d754fe6bb2  5e4466bd00d2b8c3240d1a6e6bc0ddc9
...

If you follow the instructions here, you will get image_list.txt along with all CelebA-HQ images.

Thanks! I found this network structure a bit strange, the paper said that they used the unet, but only used a layer of shortcut, and used Concat 1024 with 512. But in general, it should be Concat 1024 with 1024, Concat 512 with 512. Is this more effective?

There is only one shortcut (512) because I trained the model with --shortcut_layers 1, as the author did in his repo. And --shortcut_layer 0 means we don't use any shortcut layer. If you want a fully U-Net architecture, please train with --shortcut_layers 5. As long as the number of shortcut layers is equal to number of layers of encoder and decoder, you will get a U-Net.
For example, you can train with the following commands:
CUDA_VISIBLE_DEVICES=0 \
python train.py \
--data CelebA-HQ \
--img_size 256 \
--shortcut_layers 5 \
--inject_layers 1 \
--experiment_name 256_shortcut5_inject1_none_hq \
--gpu

The more shortcut layers you use, the larger GPU memory it costs. However, the encoder-decoder reconstruction will be better since the decoder can see less compressed latent information. It's kind of a trade-off between performance and efficiency.

Thank you for your analysis and let me have a better understanding. @elvisyjlin

No problem.


How to annotate the AVA dataset?

Hi, any suggestion on annotation tool to label active speaker detection datasets?
Thank you!

Sorry I do not know that. From what I know there is no open source toolkit for asd (NOT SURE)


Added a gulp watcher to automate the build process

Watches the source directory for changes and if some are found the build process runs. Useful in rapid deployment for testing so that the gulp build command doesn't need to be run each time.

Slate has been superseded by Clay.


Feature Request: Support for Snowflake

Snowflake is a hosted data warehousing solution.
Home: https://www.snowflake.net/
Driver:  https://repo1.maven.org/maven2/net/snowflake/snowflake-jdbc/
Currently get: ERROR: Unsupported Database: Snowflake 2.5

Added support for Snowflake to a fork of v4.2.0 and submitted a pull request #1776. We've put it through its paces in development, but it would be great to get some more feedback. Please review.

Any update on this? Would be great to have Snowflake support.

I took over ownership of pr #1776 when alex left the company.  We've been using this feature branch ever since and it's working flawlessly.  Please re-consider it for inclusion.
If I were to port this code to the V6 branch would it have a better chance?

We're going to talk to Snowflake about the commercial details of a testing account for us. I'll let you know the outcome of that; if good, then a port to v6 would be very welcome.

Hi @juliahayward Do you have an ETA of Snowflake support?

Not yet, we're still setting up a meeting with them.

We're now working on Snowflake for 6.1. I have a question for people who are using it; in a new database connection without a schema specified in the URL, SELECT CURRENT_SCHEMA() returns null; what would you all expect Flyway's behavior to be:

you would specify a current schema in the connection URL
you would expect Flyway to default to PUBLIC until specified otherwise by USE SCHEMA xxx
you would fully qualify all object names in migration scripts?

The second option, always assume public unless specified on the URL or by a use schema command in a migration script.
From: Julia Hayward<EMAIL_ADDRESS>Reply-To: flyway/flyway<EMAIL_ADDRESS>Date: Thursday, November 7, 2019 at 8:03 AM
To: flyway/flyway<EMAIL_ADDRESS>Cc: Russell Jungwirth<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [flyway/flyway] Snowflake support (#1735)
We're now working on Snowflake for 6.1. I have a question for people who are using it; in a new database connection without a schema specified in the URL, SELECT CURRENT_SCHEMA() returns null; what would you all expect Flyway's behavior to be:

you would specify a current schema in the connection URL
you would expect Flyway to default to PUBLIC until specified otherwise by USE SCHEMA xxx
you would fully qualify all object names in migration scripts?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/flyway/flyway/issues/1735?email_source=notifications&email_token=AHVIEDVYCD5UVRCUYSVMT43QSQN2RA5CNFSM4DV3A5CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDMP7XY#issuecomment-551092191, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHVIEDWF4CXWAHCCTW3DT2LQSQN2RANCNFSM4DV3A5CA.

This is what we've done to get this to work:

/**
 * Snowflake implementation of a Flyway Connection.
 */
@SuppressWarnings("rawtypes")
@SuppressFBWarnings("SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING")
public class SnowflakeConnection extends Connection<SnowflakeDatabase> {

    private static final Log LOG = LogFactory.getLog(SnowflakeConnection.class);

    private final String originalRole;

    public SnowflakeConnection(Configuration configuration, SnowflakeDatabase database, java.sql.Connection connection, boolean originalAutoCommit) {
        super(configuration, database, connection, originalAutoCommit);
        LOG.debug("Creating new SnowflakeConnection");

        try {
            this.originalRole = jdbcTemplate.queryForString("SELECT CURRENT_ROLE()");
        } catch (SQLException e) {
            throw new FlywaySqlException("Unable to determine current role", e);
        }
    }

    //
    // NOTE: the following methods are overridden to provide an implementation
    //

    @Override
    protected String getCurrentSchemaNameOrSearchPath() throws SQLException {
        String result = jdbcTemplate.queryForString("SELECT CURRENT_SCHEMA()");
        LOG.debug("Current Snowflake schema is " + (result != null ? result : "none"));
        return requireNonNullElse(result, "PUBLIC");
    }

    @Override
    public Schema getSchema(String name) {
        return new SnowflakeSchema(jdbcTemplate, database, name);
    }

    //
    // NOTE: the following methods are overridden to change the implementation
    //

    @Override
    protected void doRestoreOriginalState() throws SQLException {
        // Reset the role to its original value in case a migration or callback changed it
        jdbcTemplate.execute("USE ROLE " + originalRole);
    }

    @Override
    protected void doChangeCurrentSchemaOrSearchPathTo(String schemaNameOrSearchPath) throws SQLException {
        LOG.debug("Switching to Snowflake schema " + schemaNameOrSearchPath);
        jdbcTemplate.execute("USE SCHEMA " + database.quote(schemaNameOrSearchPath));
    }

}

Also note the need to consider CURRENT_ROLE

Yeah, that’s understandable.  SF doesn’t have a global default for user role.  Most logins are associated with a default role but it is not required.
Default warehouse is somewhere in between.  have a DEMO_WH warehouse provisioned by default.  Most migrations will not require a warehouse as DML commands don’t need a warehouse.   Any migrations that have non-dml statements like inserts, deletes, selects etc. will require a warehouse to execute.
From: Bob Tiernay<EMAIL_ADDRESS>Reply-To: flyway/flyway<EMAIL_ADDRESS>Date: Thursday, November 7, 2019 at 8:13 AM
To: flyway/flyway<EMAIL_ADDRESS>Cc: Russell Jungwirth<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [flyway/flyway] Snowflake support (#1735)
This is what we've done to get this to work:
/**

Snowflake implementation of a Flyway Connection.

*/
@SuppressWarnings("rawtypes")
@SuppressFBWarnings("SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING")
public class SnowflakeConnection extends Connection {
private static final Log LOG = LogFactory.getLog(SnowflakeConnection.class);

private final String originalRole;

public SnowflakeConnection(Configuration configuration, SnowflakeDatabase database, java.sql.Connection connection, boolean originalAutoCommit) {

    super(configuration, database, connection, originalAutoCommit);

    LOG.debug("Creating new SnowflakeConnection");

    try {

        this.originalRole = jdbcTemplate.queryForString("SELECT CURRENT_ROLE()");

    } catch (SQLException e) {

        throw new FlywaySqlException("Unable to determine current role", e);

    }

}

//

// NOTE: the following methods are overridden to provide an implementation

//

@Override

protected String getCurrentSchemaNameOrSearchPath() throws SQLException {

    String result = jdbcTemplate.queryForString("SELECT CURRENT_SCHEMA()");

    LOG.debug("Current Snowflake schema is " + (result != null ? result : "none"));

    return requireNonNullElse(result, "PUBLIC");

}

@Override

public Schema getSchema(String name) {

    return new SnowflakeSchema(jdbcTemplate, database, name);

}

//

// NOTE: the following methods are overridden to change the implementation

//

@Override

protected void doRestoreOriginalState() throws SQLException {

    // Reset the role to its original value in case a migration or callback changed it

    jdbcTemplate.execute("USE ROLE " + originalRole);

}

@Override

protected void doChangeCurrentSchemaOrSearchPathTo(String schemaNameOrSearchPath) throws SQLException {

    LOG.debug("Switching to Snowflake schema " + schemaNameOrSearchPath);

    jdbcTemplate.execute("USE SCHEMA " + database.quote(schemaNameOrSearchPath));

}

}
Also note the need to consider CURRENT_ROLE
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/flyway/flyway/issues/1735?email_source=notifications&email_token=AHVIEDWJBC6YED6QDYD4DHDQSQO7VA5CNFSM4DV3A5CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDMQ6AQ#issuecomment-551096066, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHVIEDT6X5N66SVQ67HD5STQSQO7VANCNFSM4DV3A5CA.

Agree with option 2

So with CURRENT_ROLE(), is that not a local property of the connection? I'm just working through some test cases and it appears to me that a migration which calls USE ROLE Foo doesn't affect anything outside its own session.

That is true.  Roles are assigned at the session level.  I haven’t confirmed myself, but it may be safe to assume that a user will always be assigned a role.
From: Julia Hayward<EMAIL_ADDRESS>Reply-To: flyway/flyway<EMAIL_ADDRESS>Date: Friday, November 8, 2019 at 5:53 AM
To: flyway/flyway<EMAIL_ADDRESS>Cc: Russell Jungwirth<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [flyway/flyway] Snowflake support (#1735)
So with CURRENT_ROLE(), is that not a local property of the connection? I'm just working through some test cases and it appears to me that a migration which calls USE ROLE Foo doesn't affect anything outside its own session.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/flyway/flyway/issues/1735?email_source=notifications&email_token=AHVIEDQSCZCXCCCDGT5GVIDQSVHJDA5CNFSM4DV3A5CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDQ2EJA#issuecomment-551658020, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHVIEDW3A3OJ7XAHACI7XQDQSVHJDANCNFSM4DV3A5CA.

Closing this issue as we're releasing imminently. Please start new issues for any problems that arise!


Use the go list command to gather list of packages

Hi Dominik,
I wasn't able to import the "unsafe" package.
Besides simplifying  the implementation of go-packages, this also
allows the import the special "unsafe" package.

go list is too slow. It is 10 times slower than original code.
(benchmark 1 '(go-packages))

Result is here
Original: Elapsed time: 0.060883s (0.008502s in 1 GCs)
go list : Elapsed time: 0.676046s

Environment

go version go1.6rc2 linux/amd64
Ubuntu 15.10
Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz
Memory 8GB

I agree that the current solution has its issues, but syohex is point on for why we aren't using go list: it is far too slow. Our current solution has far less overhead, and once it's been run once, it caches a lot better.
At the moment, I'm more inclined to address your visible issue, the lack of "unsafe" (and "C"), by adding these two items to the list manually.

I see the new implementation is slower than the original. But for me its not too slow.  To be honest I didn't even notice its slower, because it is an interactive command and the completion list is most likely finished before entering the first character.
New Implementation:
ELISP> (benchmark 1 '(go-packages))
"Elapsed time: 0.363932s"

Old Implementation:
ELISP> (benchmark 1 '(go-packages))
"Elapsed time: 0.064390s"

Using a medium size project  (prometheus) on on old Celeron:
Intel(R) Celeron(R) CPU G530 @ 2.40GHz
I would prefer a clean implementation using the "go" tools to an Elisp implementation (depending on the go compiler internals) when speed is not a real issue. Beside the Cygwin problem, I expect that there are other issues when using the Elisp implementation (vendor directories, error handling).

To demonstrate the underlying performance issues, both for cold and hot file system caches:
[cold cache] $ /usr/bin/time -v find $GOPATH/pkg /usr/lib/go/pkg -name "*.a" >/dev/null
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:03.48
[hot cache] $ /usr/bin/time -v find $GOPATH/pkg /usr/lib/go/pkg -name "*.a" >/dev/null
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:00.01

[cold cache] $ /usr/bin/time -v go list -e ... >/dev/null
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:56.89
[hot cache] $ /usr/bin/time -v go list -e ... >/dev/null
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:01.39

The performance of the current elisp implementation is comparable to that of find. The hot cache performance of go list is already too slow for auto-completion, but the real issue is that of the cold-cache performance. Having to wait almost a minute the first time go-packages is called is not acceptable.

Wow, how did you get these numbers? You cleared the filesystem cache by usingecho 3 > /proc/sys/vm/drop_caches ?
I never got this performance on a real running system. I suspect the user has other performance issues when he clears his cache for any reason :cry:  I suspect go build. has the same performance characteristics in this case.
BTW: Another neat feature would be Tramp support. But this also depends on this commit. I dont think an Elisp implementation would be feasible for this feature, because Tramp would have to traverse the remote paths (quite slow).
@dominikh
Maybe we could introduce a new custom variable like go-mode-use-external-go-list, which is turned of by default and turned on in Tramp directories?

Wow, how did you get these numbers? You cleared the filesystem cache by using echo 3 > /proc/sys/vm/drop_caches?

Yes.

I suspect the user has other performance issues when he clears his cache for any reason

Anybody who just rebooted his machine will not have his GOPATH cached yet. Anybody who works on machines with relatively little memory may have GOPATH purged from the cache regularly, especially if they're working with other large media.

I suspect go build. has the same performance characteristics in this case

Only if you manage to build something that depends on every single package in your GOPATH.
I'll admit that my storage isn't the fastest. It's a RAID 5 of 5x5400 RPM disks, so its latency is quite high, compared to that of, say, an SSD. go list only has to traverse about 4000 directories in my GOPATH. However, at the same time, I don't want to design go-mode for people with fast machines only, and other people may have significantly larger GOPATHs than me.

Maybe we could introduce a new custom variable like go-mode-use-external-go-list, which is turned of by default and turned on in Tramp directories?

I don't like the name of that variable, but we can paint that shed later. I'm fine with the idea in general, though. The variable should probably specify a function that returns a list of packages. We'd have two implementations – the current one, and one based on go list – and people could write additional ones if they need to, for whatever reason (maybe they use a custom build system that has a different way of iterating packages.)

How about:
(defcustom go-packages-function 'go-packages
  "The function called to determine the list of available packages.

Set to `go-packages-external' if you use Cygwin or Tramp filenames."
  :type 'function
  :group 'go)

I'll implement this change next week.


Be responsive when minemeld WebAPI are not responding

When engine API restarts or system is starting WebUI just "hangs", loading bar is stuck and no message is shown. This should be modified to show a message to the user.

With the upgrade to Angularjs 1.5 we have introduced timeouts on the API calls to be more responsive. Also new streaming status updates in 0.9.26 have solved this.


Event hooks

Greetings,
A proof of concept of event hooks. This is in addition to the existing --onchange hooks.
Discussions

What is the right place for the Events enum?
How do we want to expose these events?
Any more events required?
Should we consolidate these events along with --onchange ones?

PS: Rust infant - double check the implementation please!
Edit: I will clean it up the comments, run rustfmt after you guys think it's useable!

Travis is having some issues atm, will review tomorrow.

So a couple of thoughts on this:

It strikes me that having an Events and a PlayerEvent enum is somewhat inefficient. I wonder if we could perhaps merge the two, though it's unclear where that would be stored, perhaps in core?

For now, I think the events should just be present - we don't need to expose them at the moment. In due course, the events can be exposed via librespotd. I plan on having a look at Spotifyd first, as I believe they implemented a few other features, before writing anything for librespotd.
Not that I can think of at the moment. We can always add them later.

Would be interested on hearing anyone else's thoughts on where the Events/PlayerEvent enum should go, and whether we should merge them. Also, for the sake of consistency, we should probably also change the Events enum to just Event.

Could someone test this? I can currently only test on piped device that has timing issues with the Playback events.

Ok, have tested it a bit, and here are my thoughts:

There is some latency in the event outputs. I'm not too sure why this is the case, but what appears to happen is the most recent event is not pushed until another event is triggered.
The SinkActive and SinkInactive events seem to trigger at exactly to opposite moments of when they should, most likely due to point 1. Same is true for Next/Seek events.
The previous event doesn't seem to work/ever get fired.

I have a feeling that pinpointing the cause of 1) will resolve 2) and 3).
Other things to consider:
The track ID's should be resolvable spotify URIs, like spotify:track:2LawezPeJhN4AWuSB0GtAU. This is easy to do with the to_base62() method provided for SpotifyId.
For the final commit, consider changing the Event logging to debug!, since it's useful for testing, but it's console spam for most people.

@ashthespy did you ever make any progress on tracking down what was blocking events from triggering?

@sashahilton00 well, I believe that there is some issue flushing the pending messages in the sender from the PlayerEvent thread. What I feel is missing is some kind of method in the Player.run() loop to flush the event_sender buffer.  The behaviour right now is that when a new PlayerEvent comes along, the last pending item seems to be sent to the receiver.  Unfrortunately, my knowledge of rust makes solving this a bit of trial and error. If someone with a better understanding of this (plietar maybe?) could point me in the right direction, I'd be grateful!  For the rest of your points, I already have it implemented in my local branch.

@plietar any inputs on this? I finally have some time, but fear I am out of ideas on why this doesn't work as it should.

FWIW: I have a working implementation by switching from the futures aware mpsc to the std::sync::mpsc.
The main issues is that I don't completely understand the spirc's and main's event loop -  the future would be polled only when the next action came along, thus causing the latency in receiving the events.
My current workaround is to spawn a new thread and let it handle events and the associated tasks - this would also give you more flexibility for the on-event task we could wait for it to finish.
Either way, if there is still interest in it, shall clean it up and rebase, and push for review!

@ashthespy i think we should probably revisit this in librespotd. Or at the very least, revisit after we start publishing versions on crates.io, as this PR was made a while back. I feel like events are something that should be developed in conjunction with librespotd, when we get around to it.

Fair enough! :-)


[Map] CTF-janes bone Orbital

The author of this version of Orbital is  wings jane
according to the readme.  Obviously it is a modified version of the stock map by Dave Ewing.

URL: https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/J/ctf-janes-bone-orbital_72e40720.html
Hash: 72e407201d85aecc71e58a68de0ecb6efda172d9
Current name: CTF-janes bone Orbital

The 'modification' is awful - retexturing the entire map with a single pirate's head texture in green - lurid and really awful - not something one wants to look at for more than 10 seconds, let alone play.


Add Backpack wallet support

The Backpack wallet 🎒 extension does not inject a solana object into the window, so at this moment, it's incompatible with Lit Protocol.
This checks for the presence of the backpack object into the window to support backpack users.
Here's the signature of the window.solana object using the Phantom wallet:
isConnected: boolean;
isPhantom: boolean;
publicKey: PublicKey | null;

Here's the signature of the window.backpack object using the Backpack wallet:
connection: Connection;
isBackpack: boolean;
isConnected: boolean;
isXnft: boolean;
publicKey: PublicKey | null;

Update
I still need to push some code to comply with backpack's internals, will push it tomorrow.

Update
I still need to push some code to comply with backpack's internals, will push it tomorrow.

Done.

@bntzio Thanks for the PR! Do you have a short video of this being used?

Sure!
Here's a demo showing the changes I made in this PR.
https://github.com/LIT-Protocol/js-sdk/assets/3136873/b4e4d4dc-1369-48c7-aa99-067180026106
This is the original error:

@bntzio Awesome!

Published version 2.2.39


brackets doesn't delete after cursor moved.

Environment data

Language Server version: 2021.7.3
OS and version: Windows 10.0.19042 64bit
Python version (& distribution if applicable, e.g. Anaconda): 3.6.1 32bit

Expected behaviour
| supposed as cursor:
print("|")

after press right then left, then press back button it shoud be this:
print

Actual behaviour
but it shows this:
print')

Code Snippet / Additional information
https://user-images.githubusercontent.com/26390254/125720645-a0b99f3e-f6bb-40d4-9db4-566e46709baa.mp4

This is implemented by VS Code's cursor; Pylance has no control over this behavior.
If you disagree with this choice, you should file an issue on the VS Code tracker, though I believe that this behavior is intended (as otherwise you have no way to remove just those characters).

i found editor.autoClosingDelete. this should set to always.
Thanks.


Changed inspire.json format and made changes to index.js

Hi, I am running the test using "npm test" command and I am getting syntax error. I am new to testing. Is there anything i am missing?

@gitaalekhyapaul can help!

@AnirudhPanda The "data.Json" file was not properly formatted, which was causing the tests to fail. I have fixed data.json file and now all the tests are running successfully

ly


Chart Viewer doesn't update when query is reexecuted

SQL Operations Studio Version: master

Steps to Reproduce:

Run a query such as SELECT 1
Show the Chart Viewer
Re-execute the query with a change such as SELECT 2

Expected: Either the Chart tab does away or the chart is updated for resultset from step 3
Actual: Chart shows content from step 1.

It looks like Query Plan tab has a similar issue where it doesn't update when the query is reexecuted.

This has never been the behavior, it's just hid them before. I suppose I can restore that behavior

@anthonydresser yes, we should either restore the previous behavior or correct the new behavior.  Having stale query plan and chart content that is out of sync with the resultset is confusing I think.

 However we should probably keep a bug open to revisit this behavior to see if it makes more sense to just update the data.

This is fixed in 0.33.7