Attempting to sign up when email is already registered loses "personal device" checkbox

This whole flow could be reworked - should we just send the email?
We could have a useful message like "That email has already been registered. Check your email for a link to log in. In the future, you can log in directly by clicking "login" in the top navigation."

Yeah minimizing the email back and forth will be critical for student
involvement (who mostly view Weave on phones). I like the dialogue to tell
people that they are already registered. Is there a way to retain the
"personal device" status so that when they put in a recognized email it
just logs them right in?
On Tue, Oct 1, 2019 at 2:59 AM Razzi Abuissa<EMAIL_ADDRESS>wrote:

This whole flow could be reworked - should we just send the email?
We could have a useful message like "That email has already been
registered. Check your email for a link to log in. In the future, you can
log in directly by clicking "login" in the top navigation."
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/129?email_source=notifications&email_token=ABIH43KWEIWYJ47XGJML5YTQMLYORA5CNFSM4I4FJ622YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOYES3A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIH43OGTOETR4RI6PDJOKLQMLYORANCNFSM4I4FJ62Q
.

It would be a helpful feature for students, so it's about the user email
and not the device that recognizes and keeps them logged in. For security
reasons though, I think we should keep recognition with the device and not
the email.
One concern is if people are accessing Weave on a hospital computer in the
workroom that may be on for long periods of time. That would be an issue if
students logged in and if the computers didn't log out afterward.
Faculty, for the most part, will have their own computers in their offices
so it would be less of a concern and could enhance fluidity if they access
Weave in the hospital and then want to edit their profile at home.
On Tue, Oct 1, 2019 at 11:07 AM JonKusner<EMAIL_ADDRESS>wrote:

Yeah minimizing the email back and forth will be critical for student
involvement (who mostly view Weave on phones). I like the dialogue to tell
people that they are already registered. Is there a way to retain the
"personal device" status so that when they put in a recognized email it
just logs them right in?
On Tue, Oct 1, 2019 at 2:59 AM Razzi Abuissa<EMAIL_ADDRESS>wrote:

This whole flow could be reworked - should we just send the email?
We could have a useful message like "That email has already been
registered. Check your email for a link to log in. In the future, you can
log in directly by clicking "login" in the top navigation."
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/razzius/hms-weave/issues/129?email_source=notifications&email_token=ABIH43KWEIWYJ47XGJML5YTQMLYORA5CNFSM4I4FJ622YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOYES3A
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABIH43OGTOETR4RI6PDJOKLQMLYORANCNFSM4I4FJ62Q
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/129?email_source=notifications&email_token=AKOFUUJBCIJE5VPJP5BM6FLQMNRRJA5CNFSM4I4FJ622YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABTJNQ#issuecomment-537081014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKOFUUKOPF7SA2J4NBFVWLTQMNRRJANCNFSM4I4FJ62Q
.

I'm going to implement this with an "already registered, check your email" approach.

@Chronowork1 this could be a good one for you to work on.


CZ mutation

@ClaudeROSSI
please find correctly named and validated files.

I'll connect your new PRs to the issue #2511


Fix Navbar Bug closes #621

I've fixed the bugs in Navbar. Earlier the active link was not visible when the user switched the themes, but it's visible now.
Also when the home page loads for the first time earlier it was not marked as active but it is fixed now.

please add the issue number to the description

please add the issue number to the description

I've added it in the title itself.

please add the issue number to the description

I've added it in the title itself.

I noticed also, you have to add it to the description

please add the issue number to the description

I've added it in the title itself.

I noticed also, you have to add it to the description

Done.

Done


Clarify certain NetworkPolicy behavior

We never documented podSelector+namespaceSelector.
We never clearly documented ipBlock's semantics.

I don't know if the formatting is ideal.
@kubernetes/sig-network-pr-reviews

Updated the text:

Cluster ingress and egress mechanisms often require rewriting the source or destination IP
of packets. In cases where this happens, it is not defined whether this happens before or
after NetworkPolicy processing, and the behavior may be different for different
combinations of network plugin, cloud provider, Service implementation, etc.
In the case of ingress, this means that in some cases you may be able to filter incoming
packets based on the actual original source IP, while in other cases, the "source IP" that
the NetworkPolicy acts on may be the IP of a LoadBalancer or of the pod's node, etc.
For egress, this means that connections from pods to Service IPs that get rewritten to
cluster-external IPs may or may not be subject to ipBlock-based policies.

/milestone 1.12

@zparnold The changes here are not 1.12 specific; the features discussed have existed (in beta) for several releases, and the clarifications here apply to the beta implementations. So according to https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use this should be against master, not release-1.12

Ok

OK, changed the description of ipBlock to say that it selects "particular IP CIDR ranges" rather than "particular IP addresses". Other than that, there isn't really a lot to say about syntax, since most of the other fields are more obviously constrained.
I also rewrote the description of the sample NetworkPolicy to more clearly emphasize what the ipBlock section was doing (and to remove some redundancy that I think hurt readability).

/retest


Changed the color of the navbar to contrast.

I have made the changes to the color of the navbar in dark mode.

Hey @pushkaraj2007 ,
I have made the changes.


Local example prototype

This merge contains a first prototype of a local execution GUI that allows users to execute the Devito examples from a browser, similar to the benchmark.py script. Not all options are included at this point, since they currently have to be added manually and a smarter configuration mechanism is required to do this generically. Most importantly though, this merge provides the following basic features:

Basic bootstrap and flask templates and engine to drive a simple application from a local browser GUI
On pressing Execute the backend populates a parameters dictionary similar to the benchmark.py script and executes the respective example code
Local backend execution is driven through a separate multiprocessing.Process allowing us to live-stream the execution log from the Devito logger into a separate output window.

Notes: The Look-And-Feel might be a bit clunky here and there and more work is needed to make the GUI look a bit nicer in places. But most importantly, this now highlights the need for a generic "Application API" design to allows app developers to define their configuration parameters generically so that they can be populated from the GUI and handled/validated by the backend to later provide generic remote execution.

Flask and logutils should be added as compulsory requirements

I get the following trace when I try to run with the default values:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "opescigui/opescigui.py", line 107, in execute
for i in range(3)]
ValueError: invalid literal for int() with base 10: ''

You also might consider adding an auto-opener.
Everything is otherwise OK


custom base url support

Hello, I come from a region where OpenAI services cannot be used, but there are people here who provide proxy services. The domain name of their provided interface is different from that of OpenAI, so I wonder if you could provide a version that exposes the BaseAPI? Thank you.

Hi) you want to add a custom url?
For example msg.url = "https://yourapi.com/v1/images/generations"


Not installing in angular 17

Please provide the environment you discovered this bug in.
Angular 17.3.0
Which area/package is the issue in?
accordion
Description

I'm trying to install spartan ui in angular 17 and it giving me error. I know if i update angular cdk to 18 it will work but my requirement is to work in angular 17. I also tried,
npm i<EMAIL_ADDRESS>but it doesnt have this version.
I read docs but didnt find anything related to angular 17!
Please provide the exception or error you saw
No response
Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[X] No

Hey @huzaifah-here unfortunately we require Angular 18 as a minimum version for now.


Reconstruction comparison with ElasticFusion and InfiniTAM

Have you guys done reconstruction comparisons with ElasticFusion and InfiniTAM. There was a tool called SurfReg that the ICL-NUIM dataset creators made to allow you measure the quality of a reconstruction.

Hi @apache8080,
Tbh, I have never managed to get ElasticFusion or InfiniTAM working :sweat:
We actually use ground-truth 3D meshes when evaluating a run in simulation, and pointclouds for the Euroc dataset.
We don't have a way to evaluate the quality of unmapped scenes though, but I guess there is not much you can say about it beyond some qualitative inspection.

I feel your pain.
Our lab has been able to get ElasticFusion running but InfiniTAM hasn’t been the easiest thing to setup. I got it running eventually but we are still running into quality issues. Right now we are trying to recreate the results from the InfiniTAM paper where they compare reconstruction quality with ElasticFusion.
If you guys have a way of exporting the reconstruction as a PLY or STL file then I could also try adding Kimera to our comparisons.

I guess one challenge is the SurfReg tool seems to only work well with the ICL-NUIM dataset and that dataset doesn’t contain an IMU.

@apache8080 sorry I just read your last comments.
It is very easy to get the PLY: just call at the end of the run:
rosservice call /kimera_semantics_node/generate_mesh

I would be very interested to know your results! Thanks!

I've got my data running on ElasticFusion which doesn't look amazing...(have been trying to get Kintinuous up and running to no avail...)
Just discovered Kimera and am excited to give it a shot with my RGBD data!


Clean up README.md and tests

Let's make this a bit more professional for you.
This closes #10.

Ha ha, it was funny going through those texts again.
2 years passed...

Anyway, thx, your PR has been merged.
Not sure if this project has any future (most likely it has fulfilled its task in 2016 and can retire now).
Still it was kinda fun.

My beautiful porn quotes.
Fare Thee Well.


Google.Apis assebmlies are not FxCop clean

Google.Apis.dll is not FxCop clean

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 9 Aug 2011 at 8:54

Duplicate of issue #120


fix(devtools): devtools selector in the ESM builds

Fixed the issue with @aliemir/dom-to-fiber-utils not being correctly interpreted as ESM in ESM environments, causing @refinedev/devtools to throw an unexpected error. Latest release of @aliemir/dom-to-fiber-utils (0.5.0) now correctly exports ESM and CJS builds fixing the issue.
Resolves #5831

Putting this on hold and this issue will be fixed without requiring an additional release from @refinedev/devtools.


[Bug] Click on video not pausing.

Did it. Is in zipfly version. Will merge soon


INTULocationManager crash App in Simulator

Well when run app in xcode7 (ios 9.0/swift 2) works normally. But if I run just in iOS simulator the app crashes.

Could you supply more details (like any crash log? what LocationManager version are you using)? Because I could not reproduce it on my local machine.

Unfortunately I downgrade my xcode, because broke all my code. I don't have the log any more
Version:
pod 'INTULocationManager', '~> 4.0'

Hi @tenaz3,
Are you still experiencing this crash? As @sunkehappy requested, we'll need more details to help debug the issue you're seeing. Specifically, if you can provide details on the Xcode version, iOS Simulator version, and INTULocationManager version that can reproduce this crash. A crash log and any other details would also help.
If we cannot reproduce the crash and you don't have any other details to share, then we won't be able to help.


Installation not working through memflowup

do you want to build packages from source? [y/N]:
Running in interactive mode. You can always re-run memflowup to install additional packages, or to different paths.
do you want to install the initial packages system-wide? [Y/n]:
[sudo] password for gbaru:
which channel do you want to use? [STABLE/development]:
Available packages in stable channel:
0. memflow-win32 - CorePlugin
1. memflow-native - CorePlugin
2. memflow-qemu - CorePlugin
3. memflow-coredump - CorePlugin
4. memflow-kcore - CorePlugin
5. memflow-pcileech - CorePlugin
6. memflow-kvm - CorePlugin

Type packages to install by number, name, or type * for all:
*
Installing memflow-win32
12739312 / 12739312 [===========================================================================================] 100.00 % 21709470.31/s Installing memflow-native
Error: "Runtime error: unable to download file (line 25, position 21)\nin call to function 'install'

└─$ memflowup install memflow-kvm
Installing memflow-kvm:
Error: "Function not found: github_latest_release (memflowup::scripting::ScriptCtx) (line 39, position 20)\nin call to function 'install'"

Thanks for the issue. Seems to be related to the binary build of memflow-kvm. I'll try and reproduce it locally and fix it.
In the meantime you can build memflow-kvm from source as a workaround:
memflowup install memflow-kvm --from-source


prompt: Skip optional fields on empty submit

From @fahrradflucht
It would be great if one wouldn't have to write :skip every time to submit optional fields. I think submitting an empty input field should be enough to skip a section.

This is tied to the current implementation of @commitlint/prompt using vorpal - I could not find a way to do this.
I'm leaning towards reimplementing @commitlint/prompt with something like vadimdemedes/ink at some point, will address this then.

Huge +1! I’m really loving commitlint, but this proposal would definitely improve he usability of prompt, as a replacement for commitizen.

is this actually intended behavior? i'm in process of updating/refactoring promp, and this can be easily implemented after my refactoring


copy paste of MIT license

I'm not receiving notification from this thread

I'm having trouble with my xbox I


Added support for Percentages

Coverage remained the same at 100.0% when pulling 7d939c69aed1db11e63a0a196802fbc0c2777811 on percentage into 4f0a3a2bb54c9cbe9d88d19e6568010bd722c0f1 on master.


Also allow loan amount filtering in participations

FYI @jhrcek One final teeny tiny change to the strategy.

@triceo ack, please confirm that my understanding of the change is correct:

amountCondition (previously only usable for primary marketplace) can now be used also for secondary and for selling configuration too (=> will be changed in the web tool).

remainingAmountCondition was just renamed to remainingPrincipalCondition in the parser and rozobonky source code, but no change in how the strategy should be rendered and parsed (=>  no change in the web tool required)`

@jhrcek Correct on both points.


fix parameters when link comes from federation

Description
due the support to navigateProp the federate validation was wrong and the detail page and image wasnt working properly.
This fix changes the validation and pass the correct url

Fixes # (THEEDGE-3488)
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report
Patch coverage: 50.00% and no project coverage change.

Comparison is base (abeb979) 27.06% compared to head (d7d9164) 27.06%.

:exclamation: Current head d7d9164 differs from pull request most recent head f4e7e52. Consider uploading reports for the commit f4e7e52 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   27.06%   27.06%
=======================================
  Files         130      130
  Lines        3470     3470
  Branches     1220     1220
=======================================
  Hits          939      939
  Misses       2277     2277
  Partials      254      254

Files Changed
Coverage Δ

src/Routes/Devices/DeviceTable.js
30.76% <50.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add e2e-simple circleci

update of PR #31 to pull istio and run e2e-simple (with istio TAG=nightly-master)

Contains content from #32.  Will rebase this after #32 merges.
The current e2e-simple failure looks like the single step kubectl apply -f istio.yaml problem (galley isn't ready to validate webhooks fast enough).  I think the istio/istio circleci tests pass because they always build the docker images for istio so they come up very fast (no pull because images is already in docker).  Since this job is just grabbing istio nightly images and not building I think it needs to explicitly docker pull galley for now.  Will update and try.

Pretty close to ready... need to fix the istio/istio deployment to allow for the following:

bin/testEnvRootMinikube.sh -- add arg for CNI
allow for setting istio-cni hub and tag via make e2e_simple
pull in patch for making e2e_simple use istioctl kubeinject with configmap for sidecar inject to not inject initContainer

The status of this is that there's still something not quite right about the minikube setup for CNI added under

Update--the minikube script starts minikube with vm-driver=none which doesn't automatically setup any CNI plugin when network-plugin=cni.  So, there is no primary CNI plugin setup by default.  This seems to cause all of the istio pods to not make it to running.
Updated github.com/tiswanso/istio.git to configure the bridge CNI plugin.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tiswanso
If they are not already assigned, you can assign the PR to them by writing /assign @tiswanso in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Closing this as the e2e strategy changed to use https://github.com/kubernetes-sigs/kubeadm-dind-cluster for test kubernetes clusters with a CNI plugin (flannel).  See PR #62


Update README.md and .swiftlint.yml

I'm not sure whether we should keep code examples for Objective-C, since DarkModeManager's setup code is Swift only at the moment.

I think we should add an explicit warning about the significant differences between 0.39.x and 0.40.0 on iOS 13. It has many breaking changes.

I think we should add an explicit warning about the significant differences between 0.39.x and 0.40.0 on iOS 13. It has many breaking changes.

yeah, I just added a migration section to README


plugin 'info8fcc-greptimedb-datasource' has an invalid signature

can't install greptime db grafana plugin
even with
GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=info8fcc-greptimedb-datasource

How did you installed the plugin? Using grafana cli or docker?
Does the error threw at installing time or running in grafana?
We have release the docker image for quick start, you can try this way.
docker pull greptime/grafana-greptimedb:latest docker run -p 3000:3000 greptime/grafana-greptimedb:latest

I was recently running into a similar issue. Here are my findings.

My grafana setup was behind a subPath URL like https://dashboards.mycompany.com/grafana/
The MANIFEST.txt file in the plugin zip file has following contents

  "rootUrls": [
    "http://localhost:3000/"
  ]

The plugin is signed as a private plugin and expects the properties to match exactly the way they are listed in MANIFEST.txt
Note that the error you are getting is NOT saying that there is no signature. So, it is not exactly UNSIGNED. Its just that Grafana is looking at the MANIFEST.txt and finding Signature that does NOT exactly matching the runtime conditions
So we used docker to create a custom grafana image and below is part of our custom Dockerfile:

FROM grafana/grafana:11.4.0-ubuntu
RUN grafana cli --pluginUrl https://github.com/GreptimeTeam/greptimedb-grafana-datasource/releases/latest/download/info8fcc-greptimedb-datasource.zip plugins install info8fcc-greptimedb-datasource
# Delete the MANIFEST.txt as it enforces a strict check for root_url in the
# signature which does not match with our requirements of serving from a subPath
RUN rm -f /var/lib/grafana/plugins/info8fcc-greptimedb-datasource/MANIFEST.txt

Perhaps the signature file should not specify the root url because people often run grafana through subPath options
Hope this helps

Thank your feedback @arikhi14.
We have publish an unsigned version to solve the install problem.
please try this

grafana cli --pluginUrl https://github.com/GreptimeTeam/greptimedb-grafana-datasource/releases/latest/download/info8fcc-greptimedb-datasource-unsigned.zip plugins install info8fcc
or use our latest docker image, it use unsigned version by default.


Setup failed for lutron_caseta: Could not install all requirements

Home Assistant release : 0.50.2
Python release :3.4.2
Component/platform: lutron_caseta/HASSBIAN
Description of problem: ERROR (Thread-11) [homeassistant.util.package] Unable to install package pylutron-caseta==0.2.6: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-43979x0x/pynacl/
Not initializing lutron_caseta because could not install dependency pylutron-caseta==0.2.6
Setup failed for lutron_caseta: Could not install all requirements.
**Expected: Component setup and use of Lutron Caseta Hub
Problem-relevant configuration.yaml entries and steps to reproduce:
lutron_caseta:
host: IP_ADDRESS
Additional info:
Not sure why it's looking for 0.2.6 when the requirements show 0.2.7
https://github.com/home-assistant/home-assistant/blob/dev/requirements_all.txt#L627
*********Tried to manually install component which resulted in an error:
**pi@hassbian:~ $ sudo su -s /bin/bash homeassistant**
**homeassistant@hassbian:/home/pi $ source /srv/homeassistant/bin/activate**
**(homeassistant) homeassistant@hassbian:/home/pi $ pip3 install pylutron-caseta==0.2.6**
Collecting pylutron-caseta==0.2.6
  Using cached pylutron_caseta-0.2.6.tar.gz
Collecting paramiko (from pylutron-caseta==0.2.6)
  Using cached paramiko-2.2.1-py2.py3-none-any.whl
Collecting cryptography>=1.1 (from paramiko->pylutron-caseta==0.2.6)
  Using cached cryptography-2.0.3.tar.gz
Requirement already satisfied: pyasn1>=0.1.7 in /srv/homeassistant/lib/python3.4/site-packages (from paramiko->pylutron-caseta==0.2.6)
Collecting pynacl>=1.0.1 (from paramiko->pylutron-caseta==0.2.6)
  Using cached PyNaCl-1.1.2.tar.gz
    Complete output from command python setup.py egg_info:
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    c/_cffi_backend.c:15:17: fatal error: ffi.h: No such file or directory
     #include <ffi.h>
                     ^
    compilation terminated.
    Traceback (most recent call last):
      File "/usr/lib/python3.4/distutils/unixccompiler.py", line 116, in _compile
        extra_postargs)
      File "/usr/lib/python3.4/distutils/ccompiler.py", line 909, in spawn
        spawn(cmd, dry_run=self.dry_run)
      File "/usr/lib/python3.4/distutils/spawn.py", line 36, in spawn
        _spawn_posix(cmd, search_path, dry_run=dry_run)
      File "/usr/lib/python3.4/distutils/spawn.py", line 162, in _spawn_posix
        % (cmd, exit_status))
    distutils.errors.DistutilsExecError: command 'arm-linux-gnueabihf-gcc' failed with exit status 1

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/lib/python3.4/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/usr/lib/python3.4/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/usr/lib/python3.4/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/bdist_egg.py", line 161, in run
        cmd = self.call_command('install_lib', warn_dir=0)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/bdist_egg.py", line 147, in call_command
        self.run_command(cmdname)
      File "/usr/lib/python3.4/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/usr/lib/python3.4/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/install_lib.py", line 11, in run
        self.build()
      File "/usr/lib/python3.4/distutils/command/install_lib.py", line 109, in build
        self.run_command('build_ext')
      File "/usr/lib/python3.4/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/usr/lib/python3.4/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/build_ext.py", line 75, in run
        _build_ext.run(self)
      File "/usr/lib/python3.4/distutils/command/build_ext.py", line 339, in run
        self.build_extensions()
      File "/usr/lib/python3.4/distutils/command/build_ext.py", line 448, in build_extensions
        self.build_extension(ext)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/build_ext.py", line 196, in build_extension
        _build_ext.build_extension(self, ext)
      File "/usr/lib/python3.4/distutils/command/build_ext.py", line 503, in build_extension
        depends=ext.depends)
      File "/usr/lib/python3.4/distutils/ccompiler.py", line 574, in compile
        self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)
      File "/usr/lib/python3.4/distutils/unixccompiler.py", line 118, in _compile
        raise CompileError(msg)
    distutils.errors.CompileError: command 'arm-linux-gnueabihf-gcc' failed with exit status 1

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 158, in save_modules
        yield saved
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 199, in setup_context
        yield
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 254, in run_setup
        _execfile(setup_script, ns)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 49, in _execfile
        exec(code, globals, locals)
      File "/tmp/easy_install-pbsmgtbg/cffi-1.10.0/setup.py", line 232, in <module>
        "Programming Language :: Python :: 3.6",
      File "/usr/lib/python3.4/distutils/core.py", line 163, in setup
        raise SystemExit("error: " + str(msg))
    SystemExit: error: command 'arm-linux-gnueabihf-gcc' failed with exit status 1

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 1104, in run_setup
        run_setup(setup_script, args)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 257, in run_setup
        raise
      File "/usr/lib/python3.4/contextlib.py", line 77, in __exit__
        self.gen.throw(type, value, traceback)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 199, in setup_context
        yield
      File "/usr/lib/python3.4/contextlib.py", line 77, in __exit__
        self.gen.throw(type, value, traceback)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 170, in save_modules
        saved_exc.resume()
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 145, in resume
        six.reraise(type, exc, self._tb)
      File "/srv/homeassistant/lib/python3.4/site-packages/pkg_resources/_vendor/six.py", line 685, in reraise
        raise value.with_traceback(tb)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 158, in save_modules
        yield saved
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 199, in setup_context
        yield
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 254, in run_setup
        _execfile(setup_script, ns)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/sandbox.py", line 49, in _execfile
        exec(code, globals, locals)
      File "/tmp/easy_install-pbsmgtbg/cffi-1.10.0/setup.py", line 232, in <module>
        "Programming Language :: Python :: 3.6",
      File "/usr/lib/python3.4/distutils/core.py", line 163, in setup
        raise SystemExit("error: " + str(msg))
    SystemExit: error: command 'arm-linux-gnueabihf-gcc' failed with exit status 1

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-c3dg1ocw/pynacl/setup.py", line 232, in <module>
        "Programming Language :: Python :: 3.6",
      File "/usr/lib/python3.4/distutils/core.py", line 108, in setup
        _setup_distribution = dist = klass(attrs)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/dist.py", line 325, in __init__
        self.fetch_build_eggs(attrs['setup_requires'])
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/dist.py", line 446, in fetch_build_eggs
        replace_conflicting=True,
      File "/srv/homeassistant/lib/python3.4/site-packages/pkg_resources/__init__.py", line 855, in resolve
        dist = best[req.key] = env.best_match(req, ws, installer)
      File "/srv/homeassistant/lib/python3.4/site-packages/pkg_resources/__init__.py", line 1127, in best_match
        return self.obtain(req, installer)
      File "/srv/homeassistant/lib/python3.4/site-packages/pkg_resources/__init__.py", line 1139, in obtain
        return installer(requirement)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/dist.py", line 518, in fetch_build_egg
        return cmd.easy_install(req)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 672, in easy_install
        return self.install_item(spec, dist.location, tmpdir, deps)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 698, in install_item
        dists = self.install_eggs(spec, download, tmpdir)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 879, in install_eggs
        return self.build_and_install(setup_script, setup_base)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 1118, in build_and_install
        self.run_setup(setup_script, setup_base, args)
      File "/srv/homeassistant/lib/python3.4/site-packages/setuptools/command/easy_install.py", line 1106, in run_setup
        raise DistutilsError("Setup script exited with %s" % (v.args[0],))
    distutils.errors.DistutilsError: Setup script exited with error: command 'arm-linux-gnueabihf-gcc' failed with exit status 1

    ----------------------------------------
**Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-c3dg1ocw/pynacl/**

Master branch has pylutron-caseta==0.2.6. 0.2.7 is only on dev.
The trace look similar to this issue with a solution:
https://github.com/home-assistant/home-assistant/issues/8799#issuecomment-320058826

Am I interprieting this correct?

sudo apt-get install build-essential libssl-dev libffi-dev python-dev

sudo apt-get install libffi-dev

pip3 install pylutron-caseta==0.2.6


Is it possible to reload fzf input?

Category

[x] fzf binary
[ ] fzf-tmux script
[x] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

I’d like to use fzf for filtering data that takes some time to fetch from a server. To improve user experience, I’d like to use a cache as the initial input (so that the user can start typing the pattern and see how it matches against the cached data) and replace the input with actual data when it finishes downloading.
I’ve looked at the man page but I don’t see any such feature and I’m not sure if this can be done. Is it possible? How should I go about it?

No, it's not possible.

Ok, I understand. Do you think it would be hard to add such a feature to fzf? Maybe I could contribute it. Would you accept such contribution?
Thanks!


yii\base\FileHelper should follow symlinks

The Yii2 FileHelper (https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseFileHelper.php#L254) should follow symlinks or ist there any reason it should not follow symlinks?
if (is_link($src)) {
$src = readlink($src);
}

something like this should do the trick.

How to reproduce ths issue?

I'm closing the issue unless further information provided.

I am not sure how to setup a test with symlinks to reproduce this issue, but in order to recreate:

Create symlink "foo" which is related to folder "storage" which contains some files
run FileHelper::copyDirectory('foo', 'path/to/where/you/want/to/copy/foo');

As foo is a symlink to storage it will not "follow" the symlink, which could be fixed with something like:
if (is_link($src)) {
    $src = readlink($src);
}

Expected:
copyDirectory should copie a directory even its a symlink.

I don't think that method must follow symlinks by default, but it makes sense to introduce additional option followSymlinks in order to have controlled behavior

An additional option to force following symlinks would be a good solution i guess, this way current implementations do not have an unexpected behavior but people who like to enable.

Exactly :) Would you like to submit a PR?

Sure, but first i have to understand how you are runing file tests in phpunit (https://github.com/yiisoft/yii2/blob/master/tests/framework/helpers/FileHelperTest.php#L616).

https://github.com/yiisoft/yii2/blob/master/.travis.yml#L58

Cannot reproduce


A question：Does the LVM support io_ring IOPOLL?

Recently，I tested io_uring IOPOLL on an LVM device. However, the submitted request cannot be completed, and the program is always blocked in the io_uring_cqe_wait() function. So I want to ask whether the LVM supports io_ring IOPOLL。

Not yet, some folks are working on it though. This isn't an io_uring/liburing deficiency, it's the driver in the kernel lacking support.


Use Amber -V flag to collect device info

We can now rely on the -V flag of Amber to get device properties, we should use this to report the worker info.

Done in gfauto.


Test/auth

I got this error while trying to log in. Could you please verify whether it also happens on your local machine?
{
    "error": "(0 , http_errors_1.createError) is not a function"
}


ISSUE-1277 exclude slf4j-log4j12 dependency

@arunmahadevan Can you please take a look at?

@ghajos , the changes looks good. But is it an issue only with 3.1-maint branch ? Recently there has been no changes to this branch.
How about the master branch ?

@arunmahadevan Probably the dependency is arrived with the new builds of HDF stack and independent of Streamline's code as it occurs only when source patch is applied. Checked it on master/HDF-<IP_ADDRESS> and it is not an issue there.

@arunmahadevan The problem occurs after applying the source patch. Please update the dependencies to those HDF-3.1-maint has
$ wget http://s3.amazonaws.com/dev.hortonworks.com/HDF/centos7/3.x/PATCH_FILES/<IP_ADDRESS>-56/patch_files/streamline-source.patch
$ git apply streamline-source.patch
$ mvn clean install

@arunmahadevan Thank you!


Is the algorithm testing the derived child point is at infinity right?

https://github.com/btcsuite/btcutil/blob/06f32abe079c0670ea6adf08f41754ef36063a72/hdkeychain/extendedkey.go#L304
According to the BIP32, should we test the childX and childY instead of the above code?
I don't know much about the secp256k1 curve, I am  confused about how to testing whether or not the point is at finity, in btcec pkg, it's tested by X.Sign() == 0 && Y.Sign() == 0, but here, it's tested by X.Sign() == 0 || Y.Sign() ==0, why the OR logic not AND?

The new version of this routine looks like: https://github.com/btcsuite/btcd/blob/master/btcutil/hdkeychain/extendedkey.go#L343


Deprecate old dashboard and hamburger menu design related code.

Description
LEARNER-4141
Please refer to Jira story for the changes implemented in this story.

cc: @staubina

Following classes should also be marked as deprecated:

CourseOutlineFragment
OldMyCoursesListFragment
CourseOutlineAdapter

A TODO needs to be added when we deprecate CourseOutlineAdapter, to rename NewCourseOutlineAdapter to CourseOutlineAdapter once the deprecated class is deleted.

CourseDashboardFragment
BaseVideosDownloadStateActivity

Another thing that needs to be highlighted here is that we also need to deprecate/update all the tests related to the classes we are deprecating.

@miankhalid test cases will be removed/updated in its code removal story.

@farhan Why the weird branch name? 🤔

Due to some story 😉

@miankhalid ready for next pass.

@miankhalid squash the changes, approved may be.


Unable to escape code fences

I need to write an example of markdown with code fencing, so I assumed that adding a backslash before the 3 backticks would work, but it doesn't (compare output with RAW: https://gist.github.com/jordanryanmoore/5136446).

In my case, i am trying to write an example of how to use fenced code blocks.. so, my markdown looks something like this (which does not render correctly):
```js
/**
A simple example
@example
```js
var result = one();
```
*/
function one() {}
```

if i indent the nested code block, i get this.. it renders but it breaks my example (there is no need to indent a code block, as shown)
/**
A simple example
@example
    ```js
    var result = one();
    ```
*/
function one() {}

:+1:  to @hagenburger's suggestion

One cool trick: use Zero Width Space

I'm using your solution @solidsnack, thanks!

Yep, for documentation about documentation, readme generators and readme example testing modules, it will be helpful to be a bit more flexible. For example like @slang800 suggested, escaping with more backticks. Thanks.

The easiest way I've found to get the Zero Width Space is from a web browser developer console
http://superuser.com/questions/156640/how-can-i-type-u200b-character/1072509#1072509

When using recent versions of Chrome/Chromium, you can use its console to copy the character to clipboard:
copy(String.fromCodePoint(0x200B))

robin850 removed this from the 3.3.0 milestone on 22 Jun 2016

@robin850 I believe I've resolved it, any chance to get it in 3.5.x?


Install script doesn't complete and gives "Python 3.6 or greater required" error

During installation on a Jetson Nano running Ubuntu 18.4, the install script gave this error. Collectively, a group of us worked around it by editing the install script to remove lines that seemed to cause the problem that weren't relevant to our project.

Here is our edited install file:
#!/usr/bin/env bash

set -e

source /opt/ros/$(dir /opt/ros)/setup.bash

sudo cp files/49-teensy.rules /etc/udev/rules.d/

ROSDISTRO="$(rosversion -d)"
BASE=$1
SENSOR=$2
ARCH="$(uname -m)"
echo $ARCH
echo "
______ _____________   _________ ________ _______ ________ _______ ________
___  / ____  _/___  | / /__  __ \___  __ \__  __ \___  __ )__  __ \___  __/
__  /   __  /  __   |/ / _  / / /__  /_/ /_  / / /__  __  |_  / / /__  /
_  /_____/ /   _  /|  /  / /_/ / _  _, _/ / /_/ / _  /_/ / / /_/ / _  /
/_____//___/   /_/ |_/   \____/  /_/ |_|  \____/  /_____/  \____/  /_/

                            http://linorobot.org
"
if [ "$3" != "test" ]
    then
        if [ "$*" == "" ]
            then
                echo "No arguments provided"
                echo
                echo "Example: $ ./install.sh 2wd xv11"
                echo
                exit 1

        elif [[ "$1" != "2wd" && "$1" != "4wd" && "$1" != "mecanum" && "$1" != "ackermann" ]]
            then
                echo "Invalid linorobot base: $1"
                echo
                echo "Valid Options:"
                echo "2wd"
                echo "4wd"
                echo "ackermann"
                echo "mecanum"
                echo
                exit 1

        elif [[ "$2" != "xv11" && "$2" != "rplidar" && "$2" != "ydlidar" && "$2" != "hokuyo" && "$2" != "kinect" && "$2" != "realsense" ]]
            then
                echo "Invalid linorobot sensor: $2"
                echo
                echo "Valid Options:"
                echo "hokuyo"
                echo "kinect"
                echo "lms1xx"
                echo "realsense"
                echo "rplidar"
                echo "xv11"
                echo "ydlidar"
                echo
                exit 1

        elif [[ "$ARCH" != "x86_64" && "$2" == "realsense" ]]
            then
                echo "Intel Realsense R200 is not supported in $ARCH architecture."
                exit 1

        fi

        echo
        echo -n "You are installing ROS-$ROSDISTRO Linorobot for $BASE base with a $SENSOR sensor. Enter [y] to continue. "
        read reply
        if [[ "$reply" != "y" && "$reply" != "Y" ]]
            then
                echo "Wrong input. Exiting now"
                exit 1
        fi
fi

echo
echo "INSTALLING NOW...."
 Press Enter to skip (Serial Based LIDAR): "
            read hokuyoip
            echo "export LIDARIP=$hokuyoip" >> $HOME/.bashrc

    elif [[ "$SENSOR" == "kinect" ]]
        then
            cd $HOME/linorobot_ws/src
            git clone https://github.com/ros-drivers/freenect_stack.git
            sudo apt-get install -y \
            ros-$ROSDISTRO-depthimage-to-laserscan \
            ros-$ROSDISTRO-camera-info-manager
            git clone https://github.com/OpenKinect/libfreenect.git
            cd libfreenect
            mkdir build
            cd build
            cmake -L ..
            make
            sudo make install

    elif [[ "$SENSOR" == "lms1xx" ]]
        then
            cd $HOME/linorobot_ws/src
            git clone https://github.com/clearpathrobotics/lms1xx.git
            echo ""
            echo -n "Input your LMS1xx IP: "
            read lms1xxip
            echo "export LIDARIP=$lms1xxip" >> $HOME/.bashrc

    elif [[ "$SENSOR" == "realsense" ]]
        then
            sudo apt-get install -y ros-$ROSDISTRO-realsense-camera
            sudo apt-get install -y ros-$ROSDISTRO-depthimage-to-laserscan

    elif [[ "$SENSOR" == "rplidar" ]]
        then
            sudo apt-get install -y ros-$ROSDISTRO-rplidar-ros

    elif [[ "$SENSOR" == "xv11" ]]
        then
            sudo apt-get install -y ros-$ROSDISTRO-xv-11-laser-driver

    elif [[ "$SENSOR" == "ydlidar" ]]
        then
            cd $HOME/linorobot_ws/src
            git clone https://github.com/EAIBOT/ydlidar.git
    fi

    if [[ "$BASE" == "ackermann" ]]
        then
            sudo apt-get install -y ros-$ROSDISTRO-teb-local-planner
    fi
fi

cd $HOME/linorobot_ws/
catkin_make

cd $HOME/linorobot_ws/src
git clone https://github.com/linorobot/linorobot.git
git clone https://github.com/linorobot/imu_calib.git
git clone https://github.com/linorobot/lino_pid.git
git clone https://github.com/linorobot/lino_udev.git
git clone https://github.com/linorobot/lino_msgs.git

cd $HOME/linorobot_ws/src/linorobot
TRAVIS_BRANCH="echo $TRAVIS_BRANCH"
if [ "$TRAVIS_BRANCH" = "devel" ]; then git checkout devel; fi

echo "source $HOME/linorobot_ws/devel/setup.bash" >> $HOME/.bashrc
echo "export LINOLIDAR=$SENSOR" >> $HOME/.bashrc
echo "export LINOBASE=$BASE" >> $HOME/.bashrc
source $HOME/.bashrc

cd $HOME/linorobot_ws
catkin_make

echo
echo "INSTALLATION DONE!"
echo

You guys are amazing, thank you.


Curate lipid pools

Main improvements in this PR:
This PR implements changes in the way that HumanGEM handles many of its lipid pools, such as fatty acid-LD-PC pool, 1-acylglycerol-3P-LD-SM pool, acyl-CoA-LD-PS pool, etc.
These pools are currently formulated in such a way that their composition differs, as described in the original HMR2 paper (specifically in Supplementary Data 4). The original motivation was to have the pool compositions reflect those from plasma and liver tissue measurements. In practice, this leads to stoichiometric inconsistencies, because the model incorrectly treats these pool metabolites have having equal mass.
To address this problem, the pool metabolites involved in the lipid pool formation and degradation reactions were simply renamed to a specific "liver" lipid pool, which will essentially disconnect them from other reactions in the model. New lipid pool formation/degradation reactions are then added, whose compositions represent an average fatty acid composition of these different pools.
These pool compositions now enable a more generic treatment of the pool metabolites, resulting in a more stoichiometrically consistent model that still utilizes experimental fatty acid composition data.
The changes are implemented in the curateLipidPools script, which updates HumanGEM and the metabolite and reaction annotation files accordingly.
I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected devel as a target branch

This PR should not be merged until after #123.

Ok, after some small revisions and re-checking, this PR is now ready.

I completely agree to remove these four fields. But for the moment it might be better to keep this priorCombiningGrRules, which could be useful in some validation analysis.

@Hao-Chalmers Ok, I have revised to maintain the priorCombiningRules field, but this field should be removed very soon.


bug: address & connector from useAccount are undefined

When I test our connection button with v3 of starknet-react, the value of account from useAccount is defined correctly, isConnected is true,  but address is undefined and connector is undefined.
Here is how I connect :
import { InjectedConnector } from "starknetkit/injected";
import { Connector } from "@starknet-react/core";

 const connectors = [
    new InjectedConnector({ options: { id: "argentX" } }),
    new InjectedConnector({ options: { id: "braavos" } }),
  ];
 <StarknetConfig
              chains={chains}
              provider={providers}
              connectors={connectors as Connector[]}
              autoConnect
            ></StarknetConfig>

import { Connector, useConnect } from "@starknet-react/core";

const { connectAsync } = useConnect();
const connectWallet = async (connector: Connector) => {
    await connectAsync({ connector });
}

I'm testing with
"@starknet-react/chains": "^3.0.0-beta.1",
"@starknet-react/core": "^3.0.0-beta.1",
"starknetkit": "^2.2.15",
"starknet": "^6.11.0",

Thank you for the report! I will check what's going on and fix it.

Hey @jrmncos if you are able to reproduce and can open a PR with a fix I'm happy to review it. Notice this is with the code in the develop branch.

Is someone working on it? I'm currently debugging this issue, might send a patch PR later if I figure what's going on.

I couldn't reproduce the issue. If you can and can submit a fix I'll be happy to review it!

I couldn't reproduce the issue. If you can and can submit a fix I'll be happy to review it!

I got the issue in my work project and this sandbox here for reference. I'm still investigating the issue, but so far I understand that the address is set when connected, but then reverts back to an empty string, while the connector is always undefined.
Tested with the following wallet versions:
Argent X: v5.17.8
Braavos: v3.69.2

I couldn't reproduce the issue. If you can and can submit a fix I'll be happy to review it!

I got the issue in my work project and this sandbox here for reference. I'm still investigating the issue, but so far I understand that the address is set when connected, but then reverts back to an empty string, while the connector is always undefined.
Tested with the following wallet versions: Argent X: v5.17.8 Braavos: v3.69.2
Chromium Engine Version 127.0.6533.100

That's super helpful thank you!

I'm currently debugging this issue. Can anyone help me?

hey @fracek can you help me?

Hey @irisdv @kseikyo , this issue has been fixed in the latest beta release. Please update the starknet-react and starknet packages to the latest versions. Here's the updated sandbox if it helps.
Also thank you @NGUYENDANGVU-coder  and @jrmncos  for offering to help with this issue. it's already been resolved now, so no further action is needed. : )


[Compression] wrapper refactor

Description
Test Options

[ ] fast test
[ ] full test - HPO
[ ] full test - NAS
[ ] full test - compression

Checklist

[ ] test case
[ ] doc

How to test

/azp run full test - compression


fix a bug in _convert_output_type_range

Motivation
The calculation in rgb2ycbcr and bgr2ycbcr is based on data with range [0, 255].
Modification
Keep the data with range [0, 255] when dtype=np.uint8.
Enlarge the data with range [0, 1] when dtype=np.float32.
BC-breaking (Optional)
No
Use cases (Optional)
Two function calls : rgb2ycbcr , bgr2ycbcr.
Checklist
Before PR:

[x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

I need some help to fix the inverse function of rgb2ycbcr  and bgr2ycbcr.
It seems they have already work with data range [0, 1], so the fix should be remove * 255. in the line img = _convert_input_type_range(img) * 255 (line 236 and line 268) ?


Codefix SA1642: single summary line split into 2 lines

Hi,
I face with code fix a minor problem when single line summary is corrected. For example class declaration:
		/// Initializes a new instance of the DatePickerTheme class.
		public DatePickerTheme()
Using CodeFix the first Summart opening tag becomes on own line and rest stays on second line instead keeping as original in same line:
		///
		/// Initializes a new instance of the <see cref="DatePickerTheme"/> class.
		public DatePickerTheme()
Additional question: why new StyleCop does not accept the first sample as valid since this was accepted in StyleCop Classic?

why new StyleCop does not accept the first sample as valid since this was accepted in StyleCop Classic?

The linked reference is the preferable form, and the code fix provided by StyleCop Analyzers makes it easy to update old code to the preferred form. This change in behavior is listed under the Known Changes for SA1642.

Marking up-for-grabs for fixing the new line insertion. The new line should not be added when the only part changing is the reference.

I would be interested in looking at this if no one has already.


Specific emoji not displaying correctly on ios

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Focus input box
Input 0⃣ emoji

Expected results
correct display
Actual results
not displayed correctly
Code sample
Code sample
SizedBox(
            height: 120,
            child: TextField(
              decoration: InputDecoration(
                fillColor: const Color(0xfff5f5f5),
                filled: true,
                border: OutlineInputBorder(
                    borderRadius: BorderRadius.circular(8),
                    borderSide: const BorderSide(color: AppColors.dividing_line, width: 0.7)),
                hintText: widget.replyUserName != null<EMAIL_ADDRESS>: '写评论',
                contentPadding: const EdgeInsets.all(10),
                focusedBorder: OutlineInputBorder(
                    borderRadius: BorderRadius.circular(8),
                    borderSide: const BorderSide(color: AppColors.dividing_line, width: 0.7)),
              ),
              onTap: () => onTextFieldTap(),
              cursorColor: AppColors.f333,
              cursorHeight: 18,
              keyboardType: TextInputType.multiline,
              maxLength: widget.count,
              maxLines: 6,
              style: const TextStyle(fontSize: 14, color: Colors.black),
              textAlign: TextAlign.start,
              controller: controller,
              autofocus: true,
            ),
          ),

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Hi @kaisar945, this is a known issue and it's being tracked in https://github.com/flutter/flutter/issues/115517.
Kindly follow up in the original issue for updates.
Closing from here as duplicate.
Thank youj


Landing page and other some other minor things

Adds a landing page
Adds hover/disabled effects to buttons
Adds a footer to the site
Updated navbar logo
Added a share button to RoomRoute that displays current room ID and the page link, and instructions to invite people to work on the room
Added ability to remove vertices.
Fixed bug where bounds were being modified even if "Update" wasn't clicked
Fixed bug where bounds with a width/height of 0 would break the editor because of a divide by zero issue
Added a message that is displayed when an invalid room ID is entered/visited (In the future we really do need to have pre-defined error types. The current methods being used to determine what kind of error has occurred are messy)
Made some other minor changes

Everything looks good and works as expected. I agree with you on the error handling, I also feel like it would nicer if we could have (in the case of the home page) the error appear beneath the text box, but then again that is a little more involved compared to the current solution. We could probably come up with quick route, room/verify?id=XXXXX to verify if an ID is real but this is okay for right now. I think these changes help make everything look really polished.


Advanced semantic highlight for JSX

Note : they would be happy with JSX attribute and text classifications as well : https://github.com/Microsoft/TypeScript/pull/5583 :rose:

not really need to keep this open

Would be great to get better colors for:

member function green

they would be happy with JSX attribute and text classifications as well :

Done :rose:

member function green

function defs and calls are now green :rose:


Add contracts submodule

This is used to build and deploy an OS contract to the fleet.
Changelog-entry: Add contracts submodule
Signed-off-by: Alex Gonzalez<EMAIL_ADDRESS>

Automation error.


The appliance supports more than server 2016

Step 8 talks about windows server 2016

Copy the appliance setup file and key file to the Windows Server 2016 machine you created for the appliance.

The migration appliance article talks about windows server 2022.
https://learn.microsoft.com/en-us/azure/migrate/migrate-appliance#appliance---physical
If step 8 said "windows server 2016 or later" you would be good.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7f3d7cc0-ecf8-a48f-3c6e-8e18c7787c41
Version Independent ID: 31b358bd-1ee6-a058-8590-802941350e90
Content: Migrate machines as physical server to Azure with Azure Migrate. - Azure Migrate
Content Source: articles/migrate/tutorial-migrate-physical-virtual-machines.md
Service: azure-migrate
GitHub Login: @vijain
Microsoft Alias: vijain

@jonwbstr
Thanks for your feedback! We will investigate and update as appropriate.

Hi @jonwbstr,
Please find the response from the SME:
The OS version reflected in the article https://learn.microsoft.com/en-us/azure/migrate/migrate-appliance#appliance---physical is to show that the Azure Migrate appliance used for physical server discovery is now supported on Windows Server 2022 but the ask has been created for another article https://learn.microsoft.com/en-us/azure/migrate/tutorial-migrate-physical-virtual-machines which is for physical server migration that uses a replication appliance which would continue to be supported only on Windows Server 2016, therefore no change needed there.

Hi Karthigasree, please translate.
I did not create an ask for another article. I referenced another article with conflicting information
The article my ask is for:
articles/migrate/tutorial-migrate-physical-virtual-machines.md
The content in the above article states

Copy the appliance setup file and key file to the Windows Server 2016 machine you created for the appliance.

The article with conflicting information:
https://learn.microsoft.com/en-us/azure/migrate/migrate-appliance#appliance---physical
The content in the above article states:

The appliance should run on server with Windows Server 2022, 16-GB RAM, 8 vCPUs, around 80 GB of disk storage.

As you can see, one article says 2022 and the other says 2016. I am suggesting the article which reads 2016 (the one I opened this feedback for) be updated to reflect the newer version number of 2022.
I am not sure how the SME misunderstood my original request but hopefully re-explaining the same thing with more words will help!

I'm sorry, you're right. The article I referenced is for the discovery appliance. Here is the article for the replication appliance which also supports windows server 2022.
https://learn.microsoft.com/en-us/azure/migrate/migrate-replication-appliance

Deploy on an existing server running Windows Server 2022 using PowerShell installer script.

@jonwbstr , Thank you for pointing it out. The correct version has been updated at https://learn.microsoft.com/en-us/azure/migrate/migrate-replication-appliance.

#please-close


Implement the onLoggedOut hook and add unit tests

Implemented the onLoggedOut hook for logout
Updated the onLoggedIn hook to only append data.extra when a non-empty object was returned (instead of always appending data.extra)
Added unit tests for onLoggedOut hook
Moved onLoggedIn hook tests to same file as onLoggedOut hook tests
Updated README for onLoggedOut hook data.extra

@kahmali let me know if you see any issues with this PR or need anything else done to get this merged.
Thanks!

I'm so sorry for the delay on this. I'm the worst. I'll get this reviewed (and hopefully merged in) tonight.

@kahmali Exactly right. I didn't feel like always returning an empty object was the right thing to do, hence the empty obj check. I think the adjusted approach suggested is better, though.
So to summarize:

Remove function declarations from constructor (where they return an empty obj by default)
Change extraData check back to just check if something was returned and remove empty obj check (so anything can be returned)

Simple enough and makes sense to me. Let me know if I should just create a new PR and close this one or just push to this one with an updated commit, or ?.
Thanks!

Your summary is accurate, except one more thing:
3. Do an existential check to make sure the function is defined before trying to call it (you may just be implying this as it would cause an error during testing once you removed my stupid functions in step 1)
You can follow any PR strategy that's easiest to you. I personally like to rebase and force push to the same branch. It keeps the conversation all in a single thread, and doesn't create "dead end" PRs. Just my personal preference, though. There are worse things in the world than a few dead PRs.

Here's what I'm referring to, in code form (from my code example above):
extraData = self._config.onLoggedIn?.call(this)

Notice my sneaky existential check of the onLoggedIn function there.

Alrighty. I just pushed that change to not force data.extra to return an object. I also added that null check on the hook calls so it doesn't throw any errors after removing the function definitions from the constructor. Let me know if all this looks good! Thanks

This looks great! I'm gonna go ahead and merge this in and publish the update. I'll let you know when it's all set.
Thanks for taking care of this!

I updated the change log and published this in v0.8.10.
Thanks again for all your help with this!


Chest groups

Create groups of chests which can be customizable (also trim chest names)

Actually this is a bad idea, wontfix


Example doesn't run. 400 Bad Request.

Hello,
I've tried to get this example working in several different ways using an existing okta preview account, a fresh okta developer account, and even the account info supplied in this source code. In all cases, the GetNewAccessToken method of the TokenService class fails. The TokenUri, ClientId, and Client Secret are all populated for the request, but the response that comes back fails with a 400 bad request status code.

Ok. I've worked through this example and got it working. It does not work as provided for some basic reasons. Here is what I had to fix:

The default authorization server created by my fresh developer okta does not have access_token as a default scope out of the box. This caused the 400 error above. The blog doesn't mention this.

The client app is trying to access the /api/Values endpoint to get the Journal logs. This is incorrect. It should be pointed to /api/JournalLogs

The client home controller fetches the journal logs and returns them to a view, but the view was never set up to accept them or display them. This would be obvious if the blog showed a final screen shot where it mentions "Your default browser should now open and show a page like this:". Instead it shows another picture of the okta setup results from earlier.

4)There really should be a 3rd project that contains the JournalLogs class because this is needed for both the api and client app (once you try to display the proper results in the view).


Counts is getting the same number of comments for each post

Lets say im showing a list of posts with each corresponding number of comments. For some reason i get the same number of comments for each post when ever i add or remove comments. This is happening when i do return Counts.get("comments-count") but it works fine if i do return Comments.find({postId: postId}).count();
This is my code so far:
post_item.html
<template name="postItem">

{{name}}  {{commentsCount}}

</template>

post_item.js
Template.postItem.onCreated(function() {
  return this.subscribe('comments', this.data._id);
});

Template.postItem.helpers({
  commentsCount: function() {
    return Counts.get('comments-count'); // This works: Comments.find({postId: this._id}).count();
  }
});

comments.js
Meteor.publish('comments', function(postId) {
  Counts.publish(this, 'comments-count', Comments.find({postId: postId}));
  return Comments.find({postId: postId});
});

I believe this is answered here.  Let me know if it doesn't.

Excelent. Just what i needed.


Expand the diagnostic message for dfdl:checkConstraints(.)

The diagnostic message only displays "." as the error.
This commit adds the full expression text to the diagnostic message
for the case of test_checkConstraintsComplexTypeFails.
This case does not invlolve inputValueCalc.
The case of test_assertFailShowsValue2 indicated in the ticket
invloves inputValueCalc and is addressed in Daffodil-1035 Lone "."
in a dfdl:inputValueCalc expression should be an error
Daffodil-1043

Yes, I believe this is complete. Just waiting on comments and approvals. The case of test_assertFailShowsValue2 indicated in the ticket invloves inputValueCalc and is addressed in Daffodil-1035 Lone "." in a dfdl:inputValueCalc expression should be an error.

Squashed and rebased.
Thanks John


Build NuGet Package

This PR contains adjustments to the Makefile and the secrethub.csproj files so that we can easily create a Nuget package, as well as publishing it.
Note: The PR is dependent on #7

Let's merge this as is and simplify the Makefile in a separate PR.


How to Create Multiple Entries for Assurance Levels

Hello, I'd like to have the SAML request RequestedAuthnContext section generated like this.
<RequestedAuthnContext Comparison="exact">
    <AuthnContextClassRef>
	http://idmanagement.gov/ns/assurance/ial/1
    </AuthnContextClassRef>
    <AuthnContextClassRef>
	http://idmanagement.gov/ns/assurance/aal/2
    </AuthnContextClassRef>
</RequestedAuthnContext>

When I add two entries in the advanced_settings.json file
{
  "security": {
    "authnRequestsSigned": true,
    "logoutRequestSigned": true,
    "requestedAuthnContext": ["http://idmanagement.gov/ns/assurance/ial/1"],
    "requestedAuthnContext": ["http://idmanagement.gov/ns/assurance/aal/2"],
    "signatureAlgorithm": "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256",
    "digestAlgorithm": "http://www.w3.org/2001/04/xmlenc#sha256"
  }
}

I only get the second one for aal.
Thanks.

The settings are wrong, try:
{
  "security": {
    "authnRequestsSigned": true,
    "logoutRequestSigned": true,
    "requestedAuthnContext": ["http://idmanagement.gov/ns/assurance/ial/1", "http://idmanagement.gov/ns/assurance/aal/2"],
    "signatureAlgorithm": "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256",
    "digestAlgorithm": "http://www.w3.org/2001/04/xmlenc#sha256"
  }
}


js installation from development branch is broken

Installation information

jumpscale version: development
operating system: ubuntu 16

Detailed description
  export ZUTILSBRANCH=development
  export JS9BRANCH=development
  curl https://raw.githubusercontent.com/Jumpscale/bash/${ZUTILSBRANCH}/install.sh?$RANDOM > /tmp/install.sh;bash /tmp/install.sh
   . ~/.bashrc
   ZInstall_host_js99

Error

    Installed /opt/code/github/jumpscale/core9
    Running post install task
    /usr/local/lib/python3.5/dist-packages/setuptools/dist.py:398: UserWarning: Normalizing '9.4.0-rc4' to '9.4.0rc4'
      normalized_version,
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/opt/code/github/jumpscale/core9/setup.py", line 95, in <module>
        'cmds/js9_doc',
      File "/usr/local/lib/python3.5/dist-packages/setuptools/__init__.py", line 129, in setup
        return distutils.core.setup(**attrs)
      File "/usr/lib/python3.5/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/usr/lib/python3.5/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/usr/lib/python3.5/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/opt/code/github/jumpscale/core9/setup.py", line 34, in run
        self.execute(_post_install, (libname, libpath), msg="Running post install task")
      File "/usr/lib/python3.5/distutils/cmd.py", line 336, in execute
        util.execute(func, args, msg, dry_run=self.dry_run)
      File "/usr/lib/python3.5/distutils/util.py", line 301, in execute
        func(*args)
      File "/opt/code/github/jumpscale/core9/setup.py", line 9, in _post_install
        from JumpScale9 import j  # here its still the boostrap JumpScale9
      File "/opt/code/github/jumpscale/core9/JumpScale9/__init__.py", line 132, in <module>
        from .data.text.Text import Text
      File "/opt/code/github/jumpscale/core9/JumpScale9/data/text/Text.py", line 9, in <module>
        from unidecode import unidecode
    ImportError: No module named 'unidecode'

    ----------------------------------------
Command "/usr/bin/python3 -c "import setuptools, tokenize;__file__='/opt/code/github/jumpscale/core9/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" develop --no-deps" failed with error code 1 in /opt/code/github/jumpscale/core9/

[-] something went wrong: Could not install core9 of js9

fixed on development: https://travis-ci.org/Jumpscale/core9/builds/399481310

export ZUTILSBRANCH=development
export JS9BRANCH=development
curl https://raw.githubusercontent.com/Jumpscale/bash/${ZUTILSBRANCH}/install.sh?$RANDOM > /tmp/install.sh;bash /tmp/install.sh
 . ~/.bashrc
 ZInstall_host_js9_full


Is there a no-daemon mode?

E.g., inside of a Docker container, if I want to use guvnor as command, then the Docker container exits as soon as the application has been started, since guvnor itself exits.
pm2 has a --no-daemon parameter for this.
How do I do this with guvnor?

Right now it's not possible, sorry!  It's a valid use case though, I'll make sure there's something in a release really soon.

Thanks, that's very nice :-))

Since we need this feature … is there anything we can do to help?
I don't know whether we are able to do it, but could you point out where things need to be done? Then we might create a PR (I can't promise anything, but we at least would like to have a look at it).

This is in 3.2.0 - there's a relevant section in the readme.
PRs are very gratefully received - please do pitch in if you spot any problems.

Just that I get the point: It's fixed by 3.2.0, but you are still looking for a PR?
Is there anything else that needs to be done before this issue can be closed?

No, I meant that in general PRs are gratefully received ;)
I think this issue can be closed.  Usually I'd let the opener close it when they feel that the issue has been resolved.


Added only-throw-errors rule

PR checklist

[x] Addresses an existing issue: #1465
[x] New feature, bugfix, or enhancement

[x] Includes tests

[ ] Documentation update
[x] Enable CircleCI for your fork (https://circleci.com/add-projects) (I think)

What changes did you make?
If something is being thrown whose type is known, its type and base
types must contain the "Error" class.
Is there anything you'd like reviewers to focus on?
Not feeling great about what I named the utils functions.

Having problems with the e in catch (e), otherwise works...

we already have no-string-throw... this needs to be reconciled with that rule. is there a significant advantage to using the type checker here?

Oh, missed that rule! The comments from you, @andy-hanson and @nchen63 are relevant.
This is a situation where the rules do basically the same thing, but one is more powerful because it can use the type checker. There are four options I can think of:

Only have the weaker, easier-to-use rule (current)
Have both rules
Only have the stronger, harder-to-use rule
Allow for rule logic that only gets activated

Option 4 is interesting, and could be really useful in situations like this. It'd give the best of both worlds without requiring extra user configuration. Think I should file a separate issue?

"unknown" is the type you get when there's a compile error that prevents you from getting the type.
If I copy-paste that code into VSCode I get correct information on hover, so maybe there's a compile error somewhere else that effects that? Try copying your test code into a '.ts' file and seeing what errors show up.

I think option 4 would be ideal but the details might get messy since this would be the first dual rule. Also, the name no-string-throw isn't quite right and changing it would be a breaking change.

Moved issue to new thread.


Add upper/lower limit of detection terms

Not urgent, but 'upper limit of detection' and 'lower limit of detection' are useful terms to add to OBI. They are also interesting examples of value specifications: they are somewhat like settings and predictions, because they have the same "shape" as a measurement datum but mean something very different.

Indeed! Similar to the maximum load specification for an elevator. Or 'use
by dates' for food. Not settings. Not measurements. How about 'use
specifications' as a parent class?
On Tue, Jan 18, 2022, 7:08 AM James A. Overton @.***>
wrote:

Not urgent, but 'upper limit of detection' and 'lower limit of detection'
are useful terms to add to OBI. They are also interesting examples of value
specifications: they are somewhat like settings and predictions, because
they have the same "shape" as a measurement datum but mean something very
different.
—
Reply to this email directly, view it on GitHub
https://github.com/obi-ontology/obi/issues/1485, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJX2ISBJEWDTD3LZ4BOG6LUWV67VANCNFSM5MHNPRVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

would this work for 'lower limit of detection'?
lower limit of detection: a value specification that specifies the smallest concentration/amount of a substance that can be measured with a sufficient degree of confidence or statistical significance.
I can't find a good definition for upper limit of detection. Any suggestions?

lower limit of detection: a value specification that specifies the
smallest concentration/amount of a substance that can be detected in an
analyte assay
upper limit of detection: a value specification that specifies the
largest concentration/amount of a substance that can be quantified in an
analyte assay
I can't find a good definition for upper limit of detection. Any
suggestions?
On Wed, Apr 26, 2023 at 9:39 PM Hector Guzman-Orozco <
@.***> wrote:

would this work for 'lower limit of detection'?
lower limit of detection: a value specification that specifies the
smallest concentration/amount of a substance that can be measured with a
sufficient degree of confidence or statistical significance.
I can't find a good definition for upper limit of detection. Any
suggestions?
—
Reply to this email directly, view it on GitHub
https://github.com/obi-ontology/obi/issues/1485#issuecomment-1524689545,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJX2IXH5K53QCP3QHDURUDXDH2AJANCNFSM5MHNPRVQ
.
You are receiving this because you commented.Message ID:
@.***>

--
Bjoern Peters
Professor
La Jolla Institute for Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters


Update BridgeDB to BridgeDb

I intend to write a patch to rename BridgeDB to BridgeDb. Following the contributor guidelines, I hereby announce that intention.

I do not have a full fledged conda installation yet, so not eager to rename the code base/method, but here's a patch for the documentation: https://github.com/RECETOX/MSMetaEnhancer/compare/main...egonw:MSMetaEnhancer:update/docsBridgeDb?expand=1
Plz let me know how to proceed.

The docs are auto generated - we will fix it in the codebase and also fix the name in the paper.


fix(deps): update module github.com/ibm/go-sdk-core/v5 to v5.12.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/go-sdk-core/v5
require
minor
v5.11.0 -> v5.12.0

Release Notes

IBM/go-sdk-core
v5.12.0
Compare Source
Features

utils: add helper for creating a byte array pointer (#173) (df9dcc6)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.3.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Stuck at analyzing in background ...

Environment data
Version: 1.40.0-insider
Commit: 82ca6ba87f450245f665ab7a5f3a686e2cd00045
Date: 2019-10-21T05:33:43.061Z
Electron: 6.0.12
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-29-generic snap

Language Server version:  Microsoft Python Language Server version <IP_ADDRESS>
OS and version: Ubuntu 16.04
Python version (& distribution if applicable, e.g. Anaconda): 3.7

Expected behaviour
Finish analysis
Actual behaviour
Stuck at "Analyzing in background, 8145 items left ...". Always at item 8145.

Logs
PLSlog.txt
I assume one of the python packages causes the problem. Any ideas?

Dupe of one of #1502 or #1601.

Try disabling caching.
"python.analysis.cachingLevel": "None"

#1601 seems to be the same issue.

Try disabling caching.
"python.analysis.cachingLevel": "None"

Did help in the beginning but after saving the file or switching to another file it gets stuck again.
BTW, I am using the remote SSH extension.


Jon Wood's team icon is not appearing white

Go to liferay.design/team
Look at Jon's icon
Notice that it's not the same color as the others

Just changing the icon fill property from currentColor to white in icons.js, it works. But I'm not sure if this is what we want.
Another solution could be adding the color property to Icon class and stating the color in each case. Probably @plhnk  has a better solution for this issue.

I like how @victorvalle responds to gh issues, but not my whatsapp messages 💔

but he's right — changing the fill property in the icon itself will fix it, but he's also right in that it's not a scalable solution as it hardcodes a value (white) in something we might want to change.
It looks like if we move the fill property up a level (to the svg instead of at the path) this would solve it — and also maintain the future flexibility.
I suggest we take this ticket and do the following things:

Make this fix across the board for all icons (set fill="currentColor") — note we'll need to adjust should icons use the stroke property instead
Add this requirement to the icon documentation
Test all places where  is used to make sure no colors are broken

fixed in #768


CraftTweaker intergration

Test:

Adjusting spell costs
Adjusting spell properties
Adjusting modifier costs
Disabling modifiers
Adjusting ritual properties

Only thing that hasn't worked so far is removing recipes from Chrysopoeia.


Query is not returning expected results -- or I don't understand what it's supposed to do.

Describe the bug

I edited three stars.  In the "fictional" tab I set the polity to 1, 2, and "Human".
I went to the query form, and checked the Polity box and the Human box.  85 stars were returned, all but the three I edited had "NA" in the Polity field.
This seems wrong.

TRIPS version

[ ] 0.52
[X] 0.53
[ ] 0.54
[ ] 0.55

Desktop (please complete the following information):
<!- Move the X to the right line ->

[ ] IOS
[X] Windows 10
[ ] Windows Vista, 7 or 8
[ ] Windows XP
[ ] Linux (add distribution and version to this line)

**Additional info **
Add any other context about the problem here.

looking at this now. The query is broken. I'll try fix tonight

fixed


Prevent browser tabs from auto-reloading on manual extension load or code changes

Feature Request
My content script runs across <all_urls>. Currently, when I manually load my extension or update the content or background scripts, all open browser tabs automatically reload. This wasn’t an issue with the Plasmo framework.
Is your feature request related to a bug?
N/A
What are the alternatives?
A more flexible approach would be to reload only the currently active tab, rather than refreshing all tabs. If a developer needs to reload other tabs, they can manually do so as needed.
Additional context
I recently migrated my extension from Plasmo to WXT. Plasmo didn't have this reload issue. While I had an important process running in another tab, manually loading my extension caused every tab to refresh, and the ongoing process was lost. It would be helpful if we could prevent automatic reloading for all tabs. Amazing framework, by the way! 💯

This really depends on what you use your content scripts for, I don't think everyone would want this behavior changed.

If a developer needs to reload other tabs, they can manually do so as needed.

In some of my extensions, which run content scripts in *://*/*, I need all the tabs to reload immediately for the new code to run everywhere, and their UIs are minimal enough that I don't lose any state during the reloads.

While I had an important process running in another tab, manually loading my extension caused every tab to refresh, and the ongoing process was lost

What URL is this "important process" running on? Is it an HTML page that's apart of your extension? Or is it unrelated to the the extension, like watching a youtube video while you code?
In the first case, switching to *://*/* would only reload tabs with http:// and https://, not chrome-extension://. For the second, this is the main reason why WXT defaults to using a brand browser profile during development, so it doesn't effect your usual browser and processes.
I'm not opposed to adding a feature like this, but I want to make sure you've tried out the existing solutions for this problem before introducing another one.

I agree with @arnab710 . I just started working with WXT, and the behavior where all tabs in the browser are reloaded was unexpected. I waited several minutes for all the tabs to fully reload.
I’m fine with reloading just one tab when I need to refresh the UI code, but reloading all the tabs seems strange to me. Maybe using the “Alt+R” reload command to refresh the extension would be a better option?

There's actually a rare edge case that I need content scripts to not reload the page @aklinker1. For example if you want to test the behavior when the content script can't be injected into the page as the page needs a reload and for example having your popup icon show something like an exclamation mark for example.

@aklinker1 would really like to have the option to only reload the currently active tab instead of all tabs.
My Chrome extension is an AI tool. It shows a modal when activated so that users can chat with AI on any page.
Here's my development flow:

I keep a persistent browser (defineRunnerConfig {disable true}) as it is faster and allows me to maintain my saved logins.
I use a single tab to test my extension; if it works on that tab, it should work on all sites.
Sometimes I open multiple tabs to read documentation and do research while developing the extension. However, when I save changes in VSCode, it reloads all tabs instead of just the single tab I'm working on. I would prefer to reload only the active tab because that's where I'm doing the development.

Hmm, OK, you guys have convinced me that we need some way to customize reloading behavior during development. I'm not convinced that the default behavior of reloading all tabs should change, I think that's preferred in the majority of cases.
So how to implement this... In general, it would be good to have some kind of hook system for runtime events, letting you configure WXT's runtime behavior, like handling reloads.
export default defineBackground((wxt) => {
  wxt.hook("reload:tabs", (tabs) => {
    // remove tabs from array here
  });
});

That could be a solution. Another might be to allow another export from the background entrypoint with a callback function like shouldReloadTab.
export const devOptions = defineBackgroundDevOptions({
  shouldReloadTabOnChange(tab) {
    return tab.active
  },
})

export default defineBackground(() => {});

Anyone else have suggestions for what you want this to look like? Just started brainstorming, open to any idea.
Between those two options, I would prefer to implement a hooks system than have one-off exports, which stays inline with WXT's design.

sweet! is it possible to detect currently active tab and reload that instead of all tabs in the hook method?

Yes, it would be.

hi @aklinker1 I need this so much!
Is this under development? otherwise I'm willing to help based on your API design 🙌🏻

Hey Aaron,
I just came here to say that I was going to file the same "bug" in that WXT killed my entire Mac a few weeks ago by trying to reload 200+ tabs in my main Chrome profile when I run the dev version in my main profile (vs the temp profile WXT seems to create).
At first I wasn't sure what was happening, but every app on my machine froze, had redraw issues, etc, etc because Chrome was reloading everything. At one point I panicked and thought it might be a virus!
Just letting you know the impact.

You're doing God's work!
New docs are also 🔥🔥🔥 btw 🥳


Set Up Integration Suite Trial Feedback

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-isuite-onboard-subscribe.html
Please specify the step you are referring to:

All: I noticed that the screenshot resolution is too high (I know this sounds weird at first). But the tutorial looks really strange when you look at it on a large screen. I'd would be great if you could make then smaller.

4.3 According to the screenshot, the user should only select "Design, Develop, and Operate..." but later we see API Management has been selected. Which is it now?

Thanks

Hi @IObert,
I tried reducing the resolution of screenshot and you will see the changes shortly. on or after 3rd Dec.
Regards,
Vikram

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


pine64-pinephonePro: add smbios data

Adds smbios data for the PinePhone Pro, tested on actual hardware with it running from SPI.
This should allow fwupd to function since it uses this data to generate unique device IDs

Hi!
Sorry it took this long to finally look into this. It's because I really needed to investigate whether we could provide the data implicitly to any Tow-Boot builds.
Turns out we can!
But, good news, this PR is still valid and good!!
The data should be part of the actual U-Boot source code, so this is a good example of how to do it correctly for a specific device.
I still have to test this patch with #158 applied, but I have strong reasons to believe this is all good.

Oh curse me... It should have targeted development and not released.


HowTo install elemental

I would really like to try out elemental, but I have trouble with the docs. It is currently not clear to me what I have to do to use elemental on an existing machine. I'm sure this is also due to your current restructuring. Should I wait a little longer or can someone give me some step-by-step instructions?
When do you think everything will be updated and consistent?

Florian, please give us another week or two to have everything settled.
If you're only interested to deploy a k8s cluster (and not creating your own, derived image), there's a getting started documentation based on the older stack.

This is fixed. See https://rancher.github.io/elemental/


When running on Windows and

On Windows Server 2008 R2, when using letsencrypt.exe in an administrator console, I get:
...
Which host do you want to get a certificate for: 15
Authorizing Identifier www.mydomainhere.com Using Challenge Type http-01
Unexpected error
ACME Server Returned:
Error
An error occurred while processing your request.
Reference #179.81474317.1448542572.bafba3d

That's pretty odd. Is domain whitelisted? Try with the --test option to use test server.


Add descriptive section for search portal homepage

Fixes

Fixes #175 by @PreciousOritsedere

Description

This pull request adds a descriptive section to the homepage of the search portal. The section provides an overview of the search functionality and highlights the use of Creative Commons licenses. The descriptive text is added to the index.html file, and the styles for this section were applied using the appropriate design system colors, adhering to the style guide.
The descriptive text used was suggested by the issue author @PreciousOritsedere here. It's open to review and can be updated.
Technical details

The new section was inserted in the index.html file above the form section.
Styling was done in the style.css file using existing color schemes.
Responsive design considerations were made to ensure the section looks good on various screen sizes.

Tests

Navigate to the homepage
Verify that the new descriptive section appears correctly and above the form
Ensure that the section is responsive on smaller screens

Screenshots

Before

After

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Fixed by:

#299

Closing


Installing git feature is slow

Is it normal that git feature takes about ~10 minutes to install? It's even building some kind of translations...

Win11
Wsl2
Docker for desktop
Dell XPS 9570, Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 2208 Mhz, 6 Core(s), 12 Logical Processor(s), 64 GB ram

Are you using the default options for the git Feature? If not, then can you paste the values in here?
With default options, it takes 12.7 sec - action run
With ppa:false, git is built from source and it takes ~4.5 mins - action run

Screenshot is taken having this configuration
"ghcr.io/devcontainers/features/git": {
      "version": "latest",
      "ppa": false
}

However, I had try also with ppa: true, I stopped the installation when there was ~800 seconds and counting - that takes even more time on my machine than ppa: false.

Alright "version": "latest" is culprit. With it deleted and ppa: false it is done in 0.5 seconds. Thank you for help! I don't know what is wrog with "version": "latest" however It seems to me that it can happen to lots of devs.

@mataslib Linux distributions ship git inside them, but only one version. The PPA option on Ubuntu allows the use of pre-built versions of git other than the one in the distro.  In other cases, it has to be compiled to be installed, which takes a while.
You can pre-build your image if you really want the latest version of git to avoid this problem. https://containers.dev/implementors/reference/#prebuilding

With ppa:true It hangs on => => # (*) Downloading GPG key...

ℹ  This is a separate issue tracked in https://github.com/devcontainers/features/issues/323

@samruddhikhandale Should we keep this open to track potentially pre-building git ahead of time?

Yep, sounds good 👍

@Chuxel Thank you kindly for clarification. 👍


Move weight computation from propose to traced_evaluate.

Also regarding the notebooks. A wanted to make that a new PR but accidentally pushed the changes to the same branch. Would it be better to still remove them and make a new PR?

Yes, it's better to put it in a separate PR.