Unclear use of this library?

Hi, I'm not quite sure what the point of this library is, but it seems like it might be what I need. Adding a better description in the README would be nice.
My Q though: this essentially allows offloading the Nx cache to a third party? I.e. instead of using a local folder say within node_modules you can upload/download it from a HotStorage container somewhere?
What are the performance impacts of this library?

Yes, it allows you to implement your own custom nx cache. I'd you're looking for implementations, packages like nx-remotecache-azure etc. should be for you.


CSS expressions are modified and become invalid during compilation

The problem
Some CSS values are modified during compilation.
How to reproduce
const styles = stylex.create({
  host: {
    margin: `max(0px, (48px - ${vars.iconSize}) / 2)`,
  },
});

is compiled to:
.x1luk75g:not(#\#) {
  margin: max(0,(48px - var(--x16dnrjz))/2);
}

Which is incorrect, because 0 must have a unit in px for that expression to be valid.
Expected behavior
Compile exactly as asked:
.x1luk75g:not(#\#) {
  margin: max(0px, (48px - var(--x16dnrjz)) / 2);
}

Also, with no var:
const styles = stylex.create({
  host: {
    margin: 'max(0px, 28px)',
  },
});

The `margin` css property is purely and simply missing in compiled css.

Thanks for the report will investigate.

not sure about the second example (with no var), but not specifying px or any other unit near 0 is valid CSS, because all units at 0 represent the same measurement. examples of using 0 without measurement unit are all over the official MDN documentation, and evaluating an expression like height: max(0, -21px) would result in height: 0, which is a completely valid CSS.

@nedjulius The 0 isn't the problem. The problem is that CSS expects spaces around / in expressions. Our CSS minifier is being a bit too aggressive!

Did some digging and 0 without the px doesn't work as reported. This is possibly a browser bug, but we need to support this pattern anyway.

Fixed in 0.5.0


Address axum integration compilation error with non-Sync body

This fixes an error I'm seeing when compiling a project that uses async-graphql-axum with axum 0.7. The issue and fix was brought up in https://github.com/async-graphql/async-graphql/pull/1431#pullrequestreview-1758338145 but not implemented.
Without this change, we get the following when running cargo clippy --package async-graphql-axum:
    Checking async-graphql-axum v7.0.0 (/home/alden/async-graphql/integrations/axum)
error: future cannot be sent between threads safely
   --> integrations/axum/src/extract.rs:101:86
    |
101 |       async fn from_request(req: Request, _state: &S) -> Result<Self, Self::Rejection> {
    |  ______________________________________________________________________________________^
102 | |         if let (&Method::GET, uri) = (req.method(), req.uri()) {
103 | |             let res = async_graphql::http::parse_query_string(uri.query().unwrap_or_default())
104 | |                 .map_err(|err| {
...   |
131 | |         }
132 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `std::marker::Sync` is not implemented for `(dyn axum::body::HttpBody<Data = bytes::Bytes, Error = axum::Error> + std::marker::Send + 'static)`
note: future is not `Send` as this value is used across an await
   --> integrations/axum/src/extract.rs:128:18
    |
102 |         if let (&Method::GET, uri) = (req.method(), req.uri()) {
    |                                       --- has type `&axum::http::Request<axum::body::Body>` which is not `Send`
...
128 |                 .await?,
    |                  ^^^^^ await occurs here, with `req` maybe used later
...
132 |     }
    |     - `req` is later dropped here
help: consider moving this into a `let` binding to create a shorter lived borrow
   --> integrations/axum/src/extract.rs:102:39
    |
102 |         if let (&Method::GET, uri) = (req.method(), req.uri()) {
    |                                       ^^^^^^^^^^^^
    = note: required for the cast from `std::pin::Pin<std::boxed::Box<[async block@integrations/axum/src/extract.rs:101:86: 132:6]>>` to `std::pin::Pin<std::boxed::Box<(dyn futures_util::Future<Output = std::result::Result<extract::GraphQLBatchRequest<R>, R>> + std::marker::Send + 'async_trait)>>`

error: could not compile `async-graphql-axum` (lib) due to previous error

After the change, this is no longer a problem.
Separately, I'm not entirely sure why it is not being flagged in CI.

Hey @Miaxos any chance this could get merged and published in a 7.0.1 version?

released in 7.0.1


[Sema] SR-2176: Add warning for ambiguous enum value assignment

This PR fixes an issue with ambiguous enum value assignment when using an optional enum.
Resolves SR-2176.

cc @jrose-apple @xedin

A warning is our only choice since an error would create a source compatibility issue. Here's a test case demonstrating that it needs to happen in CSApply's ExprRewriter and not when checking the initial value of a property:
enum E {
  case none
}

func foo(_: E?) {}

foo(.none) // should be the same warning?

@slavapestov @xedin done 👍

Thanks a lot for the detailed feedback @brentdax :) I have addressed them, does it look good to you now?


Choppy playback on Aether Cone

Sorry to report that I've uncovered another problem while testing for #15. When I try to use SpotConnect to play to an Aether Cone, the audio is very choppy. In the log I don't see any actual errors, but  appears to me that SpotConnect is constantly restarting the connection (and I could be reading it wrong).
The only difference with the Cone from my Apple devices is that it's on my IoT VLAN, however I have firewall rules in place that allow all communication from the Cone to the Raspberry Pi, and all devices from the main network are free to talk to the IoT network without restriction. I'm also able to AirPlay to the Cone from any Apple device on the main network as well as OwnTone hosted on the same Pi as SpotConnect without issue.

📃 Debug log of playback attempt
$ ./spotraop-linux-aarch64-static -x ./spotraop-config.xml -d all=debug
[21:27:55.575498] main:1134 Starting spotraop version: v0.1.2 (Jul 26 2023 @ 18:40:52)

[21:27:55.585064] Start:903 Binding to [Main Network IP]
[21:27:55.586050] StartActiveRemote:788 DACP port: 50707
[21:27:55.674113] AddRaopDevice:514 [0xa56e10]: creating MAC
[21:27:55.674284] AddRaopDevice:528 [0xa56e10]: adding renderer (DEVF6GT4QEDWK3TEFQNZ@[IOT Network IP]) with mac AAAA-XXXXXXXX
[21:27:55.674584] raopcl_create:713 [0x7f84009610]: using ALAC coding
I BellHTTPServer.cpp:191: Server listening on port 0
I spotify.cpp:359: Server using actual port 35075
I MDNSService.cpp:181: using built-in mDNS for Shop Cone+
I spotify.cpp:381: Spotify client connected for Shop Cone+
D Session.cpp:63: Connecting with AP <ap-gue1.spotify.com:4070>
D PlainConnection.cpp:101: Connected to spotify server
I Session.cpp:39: Received APHello response
D Session.cpp:44: Received shannon keys
D Session.cpp:82: Authorization successful
I MercurySession.cpp:42: Received packet, command: 4
D TimeProvider.cpp:15: Time synced with spotify servers
I MercurySession.cpp:42: Received packet, command: 2
I MercurySession.cpp:42: Received packet, command: 118
D MercurySession.cpp:251: Executing Mercury Request, type SUB
D spotify.cpp:416: keepAlive Shop Cone+
I MercurySession.cpp:42: Received packet, command: 27
D MercurySession.cpp:153: Received country code US
I MercurySession.cpp:42: Received packet, command: 80
I MercurySession.cpp:42: Received packet, command: 31
I MercurySession.cpp:42: Received packet, command: 105
I MercurySession.cpp:42: Received packet, command: 181
I AccessKeyFetcher.cpp:99: Access token expired, fetching new one... 238
I MercurySession.cpp:42: Received packet, command: 74
I MercurySession.cpp:42: Received packet, command: 179
D MercurySession.cpp:174: Received mercury packet
D MercurySession.cpp:251: Executing Mercury Request, type SEND
D SpircHandler.cpp:59: Sent kMessageTypeHello!
I MercurySession.cpp:42: Received packet, command: 181
I MercurySession.cpp:42: Received packet, command: 181
D SpircHandler.cpp:67: Received subscription response
D SpircHandler.cpp:124: Notify frame
D SpircHandler.cpp:67: Received subscription response
D SpircHandler.cpp:124: Notify frame
I MercurySession.cpp:42: Received packet, command: 181
D SpircHandler.cppI MercurySession.cpp:67: Received subscription response
D SpircHandler.cpp:124: Notify frame
:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I AccessKeyFetcher.cpp:114: Access token sucessfully fetched
I MercurySession.cpp:42: Received packet, command: 181
D SpircHandler.cpp:67: Received subscription response
D SpircHandler.cpp:170: Load frame 3!
D MercurySession.cpp:251: Executing Mercury Request, type SEND
I TrackPlayer.cpp:94: Resetting state
D MercurySession.cpp:251: Executing Mercury Request, type GET
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I TrackQueue.cpp:158: Track name: Pergola
I TrackQueue.cpp:159: Track duration: 928143
D TrackQueue.cpp:161: trackInfo.restriction.size() = 1
D TrackQueue.cpp:212: File format: 2
D TrackQueue.cpp:212: File format: 1
D TrackQueue.cpp:212: File format: 0
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I MercurySession.cpp:42: Received packet, command: 13
I TrackQueue.cpp:252: Got audio key
I TrackQueue.cpp:275: Received access key, fetching CDN URL...
I TrackQueue.cpp:301: Received CDN URL, https://audio-fa.scdn.co/audio/c27f1826de3352b32952421744cd944675183a79?1691285283_mYyPHMIuCtNSfOjA1R60sZKT2K32GeFPNBT8ure2UZ4=
D MercurySession.cpp:251: Executing Mercury Request, type GET
I TrackPlayer.cpp:167: Got track ID=c27f1826de3352b32952421744cd944675183a79
I CDNAudioFile.cpp:43: Opening HTTP stream to https://audio-fa.scdn.co/audio/c27f1826de3352b32952421744cd944675183a79?1691285283_mYyPHMIuCtNSfOjA1R60sZKT2K32GeFPNBT8ure2UZ4=
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I TrackQueue.cpp:158: Track name: Ornamental Plants
I TrackQueue.cpp:159: Track duration: 907000
D TrackQueue.cpp:161: trackInfo.restriction.size() = 1
D TrackQueue.cpp:212: File format: 2
D TrackQueue.cpp:212: File format: 1
D TrackQueue.cpp:212: File format: 0
I MercurySession.cpp:42: Received packet, command: 13
I TrackQueue.cpp:252: Got audio key
I TrackQueue.cpp:275: Received access key, fetching CDN URL...
I CDNAudioFile.cpp:70: Header and footer bytes received
D MercurySession.cpp:251: Executing Mercury Request, type SEND
I spotify.cpp:235: new track will start at 0
[21:28:04.194216] shadowRequest:219 [0xa56e10]: spotify LOAD request
[21:28:04.297419] raopcl_connect:996 [0x7f84009610]: local interface [Main Network IP]
[21:28:04.298270] exec_request:614 [0x7f8400d9b0]: ----> : write POST /auth-setup RTSP/1.0
Content-Type: application/octet-stream
Content-Length: 33
CSeq: 1
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>

ŦB��%���q���=>��7:3���M O)�
I TrackQueue.cpp:301: Received CDN URL, https://audio-fa.scdn.co/audio/3545d5438c8e299f480ade315f657e455958f9d3?1691285284_fMCs1W-NsVkWdmknb5mafnChXVEZhHyDK8zVJxT2o74=
D MercurySession.cpp:251: Executing Mercury Request, type GET
[21:28:04.601102] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:04.601550] exec_request:650 [0x7f8400d9b0]: <------ : Content-Type: application/octet-stream
[21:28:04.601798] exec_request:650 [0x7f8400d9b0]: <------ : Content-Length: 1076
[21:28:04.602056] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:04.602185] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 1
[21:28:04.602262] exec_request:691 [0x7f8400d9b0]: Body data len 1076
0000  fc b2 40 66 bf e7 96 50 52 3b e6 a2 3f c4 37 83   @f   PR;  ? 7
0010  ba 60 5c 2b d1 90 03 a6 c8 03 ce 41 ba 96 70 3b  `\+       A  p;
0020  00 00 03 8c 30 82 03 88 06 09 2a 86 48 86 f7 0d     0     * H
0030  01 07 02 a0 82 03 79 30 82 03 75 02 01 01 31 00       y0  u   1
0040  30 0b 06 09 2a 86 48 86 f7 0d 01 07 01 a0 82 03 0   * H
0050  5d 30 82 03 59 30 82 02 41 a0 03 02 01 02 02 0f ]0  Y0  A
0060  12 12 aa 13 11 03 aa 06 aa 12 94 aa 96 69 51 30              iQ0
0070  0d 06 09 2a 86 48 86 f7 0d 01 01 05 05 00 30 81    * H        0
0080  83 31 0b 30 09 06 03 55 04 06 13 02 55 53 31 13  1 0   U    US1
0090  30 11 06 03 55 04 0a 13 0a 41 70 70 6c 65 20 49 0   U    Apple I
00a0  6e 63 2e 31 26 30 24 06 03 55 04 0b 13 1d 41 70 nc.1&0$  U    Ap
00b0  70 6c 65 20 43 65 72 74 69 66 69 63 61 74 69 6f ple Certificatio
00c0  6e 20 41 75 74 68 6f 72 69 74 79 31 37 30 35 06 n Authority1705
00d0  03 55 04 03 13 2e 41 70 70 6c 65 20 69 50 6f 64  U   .Apple iPod
00e0  20 41 63 63 65 73 73 6f 72 69 65 73 20 43 65 72  Accessories Cer
00f0  74 69 66 69 63 61 74 69 6f 6e 20 41 75 74 68 6f tification Autho
0100  72 69 74 79 30 1e 17 0d 31 33 31 31 30 33 30 37 rity0   13110307
0110  35 31 31 32 5a 17 0d 32 31 31 31 30 33 30 37 35 5112Z  211103075
0120  31 31 32 5a 30 70 31 0b 30 09 06 03 55 04 06 13 112Z0p1 0   U
0130  02 55 53 31 13 30 11 06 03 55 04 0a 0c 0a 41 70  US1 0   U    Ap
0140  70 6c 65 20 49 6e 63 2e 31 1f 30 1d 06 03 55 04 ple Inc.1 0   U
0150  0b 0c 16 41 70 70 6c 65 20 69 50 6f 64 20 41 63    Apple iPod Ac
0160  63 65 73 73 6f 72 69 65 73 31 2b 30 29 06 03 55 cessories1+0)  U
0170  04 03 0c 22 49 50 41 5f 31 32 31 32 41 41 31 33    "IPA_1212AA13
0180  31 31 30 33 41 41 30 36 41 41 31 32 39 34 41 41 1103AA06AA1294AA
0190  39 36 36 39 35 31 30 81 9f 30 0d 06 09 2a 86 48 9669510  0   * H
01a0  86 f7 0d 01 01 01 05 00 03 81 8d 00 30 81 89 02             0
01b0  81 81 00 aa a3 77 e5 3f 4f e6 08 9f c9 61 b1 5e      w ?O    a ^
01c0  b2 45 fa c0 e6 aa b9 62 63 cc 8c 5e e8 fd a7 43  E     bc  ^   C
01d0  29 4b 79 86 f3 d5 f3 ec ee 42 73 e9 1b 07 aa 26 )Ky      Bs    &
01e0  07 65 8e d0 14 47 c8 5f 7f 23 92 ea 81 27 d6 ce  e   G _ #   '
01f0  fe 61 d2 14 c3 69 52 7b 4d 50 7b fe 77 86 92 54  a   iR{MP{ w  T
0200  7f 3b d3 fa c8 f5 c6 c2 53 94 b0 e6 bd 6e 45 3f  ;      S    nE?
0210  e6 69 41 df 74 03 2c c8 fa 68 b2 45 ac 83 6c 6e  iA t ,  h E  ln
0220  cd 89 85 bb 9b b9 31 c8 74 82 6f 73 82 80 8d 8b       1 t os
0230  f4 d1 d7 02 03 01 00 01 a3 60 30 5e 30 1d 06 03          `0^0
0240  55 1d 0e 04 16 04 14 2a be 69 4e 08 d7 3f 9c be U      * iN  ?
0250  88 9a 11 e7 3a f5 54 1b 3c c1 c1 30 0c 06 03 55     : T <  0   U
0260  1d 13 01 01 ff 04 02 30 00 30 1f 06 03 55 1d 23        0 0   U #
0270  04 18 30 16 80 14 ff 4b 1a 43 9a f5 19 96 ab 18   0    K C
0280  00 2b 61 c9 ee 40 9d 8e c7 04 30 0e 06 03 55 1d  +a  @    0   U
0290  0f 01 01 ff 04 04 03 02 03 b8 30 0d 06 09 2a 86           0   *
02a0  48 86 f7 0d 01 01 05 05 00 03 82 01 01 00 19 0c H
02b0  bc 8d 27 ff bd c1 a7 9d b3 49 93 fe 38 41 a7 39   '      I  8A 9
02c0  75 30 41 38 03 86 5e ec d2 6e 93 1d 26 81 cb 8c u0A8  ^  n  &
02d0  05 04 91 70 bd 87 b5 67 85 15 5f 29 c6 3d e4 56    p   g  _) = V
02e0  1d db de ff c6 92 27 f5 42 ce 5a 64 0f ee 73 9b       ' B Zd  s
02f0  a0 99 4c d9 03 89 b6 1b 12 00 11 b6 68 dd f3 9a   L         h
0300  2a ca 34 f3 81 36 35 af 95 dd 73 bf df 62 af 2f * 4  65   s  b /
0310  f0 8d 8b eb bb 35 79 9c 33 57 49 ca 5e a7 7d 48      5y 3WI ^ }H
0320  90 d8 d9 d3 f4 45 c2 29 82 df 0d 9e ad af 87 47      E )       G
0330  61 f9 e2 c3 e5 f7 ec 2e a2 8b 44 51 a5 21 04 81 a      .  DQ !
0340  7f 60 7a 6b 9c 62 69 52 58 d1 f6 34 f8 dc c1 84  `zk biRX  4
0350  ba 0f 83 98 c2 1c 85 eb 2d 6f ca c1 1e ad 61 62         -o    ab
0360  33 05 d3 09 49 fb bc 06 3c 88 ba 53 53 c5 21 f1 3   I   <  SS !
0370  f1 09 86 ef 11 b0 fd df 53 90 04 5b 73 ac c1 b2         S  [s
0380  b4 f3 5a 34 1d 37 d4 a1 79 b4 6c 91 69 21 b5 46   Z4 7  y l i! F
0390  b8 1f a5 1d 20 92 25 14 e8 d0 37 83 07 23 58 a8       %   7  #X
03a0  85 a9 cc bc 11 74 ee bb 5b 65 8f 89 26 1f 31 00      t  [e  & 1
03b0  00 00 00 80 a9 06 1f 29 0d 72 79 6d 3d 0b 23 ff        ) rym= #
03c0  d3 93 82 f6 d3 51 54 4d 00 1d 58 40 15 d7 4b f7      QTM  X@  K
03d0  66 43 2c 37 42 74 21 e7 d8 43 31 f9 6b 06 8a 89 fC,7Bt!  C1 k
03e0  de e1 f9 49 01 56 af 7d 5d 91 06 c8 e0 a9 ec b4    I V }]
03f0  b9 c1 84 ca 69 3d 41 bb d4 dd 6d ed a7 2f 71 df     i=A   m  /q
0400  97 82 b8 d2 2a a4 cf df 49 59 72 35 2c fc 30 c7     *   IYr5, 0
0410  40 c0 cc c0 38 dc db c5 fb eb 90 2d 37 d5 18 0b @   8      -7
0420  a5 8f 15 cc a5 6f fb e2 81 32 37 04 17 f3 4d 3a      o   27   M:
0430  92 21 cb 8d  !
[21:28:04.645279] exec_request:614 [0x7f8400d9b0]: ----> : write ANNOUNCE rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Content-Type: application/sdp
Content-Length: 178
CSeq: 2
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>

v=0
o=iTunes<PHONE_NUMBER> 0 IN IP4 [Main Network IP]
s=iTunes
c=IN IP4 [IOT Network IP]
t=0 0
m=audio 0 RTP/AVP 96
a=rtpmap:96 AppleLossless
a=fmtp:96 352 0 16 40 10 14 2 255 0 0 44100

[21:28:04.648285] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:04.648547] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:04.648677] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 2
[21:28:04.648829] exec_request:614 [0x7f8400d9b0]: ----> : write SETUP rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Transport: RTP/AVP/UDP;unicast;interleaved=0-1;mode=record;control_port=49886;timing_port=43285
CSeq: 3
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>

[21:28:04.655436] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:04.656349] exec_request:650 [0x7f8400d9b0]: <------ : Transport: RTP/AVP/UDP;unicast;mode=record;server_port=34139;control_port=33160;timing_port=33028
[21:28:04.656505] exec_request:650 [0x7f8400d9b0]: <------ : Session: 1
[21:28:04.656923] exec_request:650 [0x7f8400d9b0]: <------ : Audio-Jack-Status: connected; type=analog
[21:28:04.657194] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:04.657323] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 3
[21:28:04.657393] rtspcl_setup:239 [0x7f8400d9b0]: <------ : session:1
[21:28:04.657445] raopcl_connect:1058 [0x7f84009610]:opened audio socket   l:48516 r:34139
[21:28:04.657491] raopcl_connect:1059 [0x7f84009610]:opened timing socket  l:43285 r:33028
[21:28:04.657534] raopcl_connect:1060 [0x7f84009610]:opened control socket l:49886 r:33160
[21:28:04.657618] exec_request:614 [0x7f8400d9b0]: ----> : write RECORD rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Range: npt=0-
RTP-Info: seq=9159;rtptime=4058685655
CSeq: 4
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

[21:28:04.661339] _rtp_timing_thread:1296 [0x7f84009610]: NTP remote port: 33028
[21:28:04.661560] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.2841125161 (ref<PHONE_NUMBER>.1107725339)
[21:28:04.664119] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.2852257716 (ref<PHONE_NUMBER>.2849415967)
[21:28:04.667223] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.2865589294 (ref<PHONE_NUMBER>.2862643737)
[21:28:04.766220] ActiveRemoteThread:634 raw active remote: get /ctrl-int/1/setproperty?dmcp.device-volume=-20.7525749 http/1.1
host: [raspberry pi].local
active-remote:<PHONE_NUMBER>
user-agent: airplay/190.9

I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I TrackQueue.cpp:158: Track name: Reincarnation At The End Of The World
I TrackQueue.cpp:159: Track duration: 1364000
D TrackQueue.cpp:161: trackInfo.restriction.size() = 1
D TrackQueue.cpp:212: File format: 2
D TrackQueue.cpp:212: File format: 1
D TrackQueue.cpp:212: File format: 0
I MercurySession.cpp:42: Received packet, command: 13
I TrackQueue.cpp:252: Got audio key
I TrackQueue.cpp:275: Received access key, fetching CDN URL...
I TrackQueue.cpp:301: Received CDN URL, https://audio-fa.scdn.co/audio/409a5d22214777ad7587b0da207285c00a387eae?1691285285_306omyX4yqozYDOfAh5rxiCqF8Yc4Dz9AnsWnDlJu70=
[21:28:05.452728] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:05.453309] exec_request:650 [0x7f8400d9b0]: <------ : Audio-Latency: 0
[21:28:05.453871] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:05.454150] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 4
[21:28:05.454601] raopcl_connect:1080 [0x7f84009610]: setting volume as part of connect -30.00
[21:28:05.454815] exec_request:614 [0x7f8400d9b0]: ----> : write SET_PARAMETER rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Content-Type: text/parameters
Content-Length: 20
CSeq: 5
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

volume: -30.000000

[21:28:05.477135] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:05.477796] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:05.478122] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 5
[21:28:05.478333] ActiveRemoteThread:668 [0xa56e10]: remote command setproperty?dmcp.device-volume=-20.7525749
[21:28:05.478511] ActiveRemoteThread:726 [0xa56e10]: volume feedback 0 (-20.75)
D MercurySession.cpp:251: Executing Mercury Request, type SEND
D MercurySession.cpp:251: Executing Mercury Request, type SEND
[21:28:05.479385] exec_request:614 [0x7f8400d9b0]: ----> : write SET_PARAMETER rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Content-Type: text/parameters
Content-Length: 20
CSeq: 6
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

volume: -20.752575

[21:28:05.521547] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:05.522231] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:05.522557] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 6
[21:28:05.523027] shadowRequest:223 [0xa56e10]: spotify play request
[21:28:05.601976] ActiveRemoteThread:634 raw active remote: get /ctrl-int/1/setproperty?dmcp.device-busy=0 http/1.1
host: [raspberry pi].local
active-remote:<PHONE_NUMBER>
user-agent: airplay/190.9

[21:28:05.602385] ActiveRemoteThread:668 [0xa56e10]: remote command setproperty?dmcp.device-busy=0
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I TrackPlayer.cpp:200: Playing
I spotify.cpp:133: trackUniqueId update  => c27f1826de3352b32952421744cd944675183a79
[21:28:05.934767] raopcl_accept_frames:416 [0x7f84009610]: begining to stream hts:0 n:1691198885.4014767924
[21:28:05.935150] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198885.4014669824 (ts:74581870869722)
[21:28:05.935222] raopcl_accept_frames:424 [0x7f84009610]: restarting w/o pause n:1691198885.4014767924, hts:74581870869722
[21:28:06.455771] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198886.1845166080 (ts:74581870891546)
[21:28:06.886847] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.3808570839 (ref<PHONE_NUMBER>.3798241758)
D MercurySession.cpp:251: Executing Mercury Request, type SEND
I spotify.cpp:249: Got next track id 1cb15c0187f740ddb46ebd3c2c263261 => <Pergola>
[21:28:07.074198] exec_request:614 [0x7f8400d9b0]: ----> : write SET_PARAMETER rtsp://[IOT Network IP]/3344080965 RTSP/1.0
RTP-Info: rtptime=4058791610
Content-Type: application/x-dmap-tagged
Content-Length: 91
CSeq: 7
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

mlit
[21:28:07.081482] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:07.081747] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:07.081878] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 7
I spotify.cpp:169: Setting track position 420947 / 928143
[21:28:07.111256] exec_request:614 [0x7f8400d9b0]: ----> : write SET_PARAMETER rtsp://[IOT Network IP]/3344080965 RTSP/1.0
Content-Type: text/parameters
Content-Length: 44
CSeq: 8
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

progress:<PHONE_NUMBER>/4058793852/4081161195

[21:28:07.113592] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:07.113831] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:07.113937] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 8
D MercurySession.cpp:251: Executing Mercury Request, type SEND
[21:28:07.180390] exec_request:614 [0x7f8400d9b0]: ----> : write SET_PARAMETER rtsp://[IOT Network IP]/3344080965 RTSP/1.0
RTP-Info: rtptime=4058796186
Content-Type: image/jpeg
Content-Length: 24124
CSeq: 9
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

����
[21:28:07.189601] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:07.189845] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:07.189952] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 9
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
I MercurySession.cpp:42: Received packet, command: 178
D MercurySession.cpp:174: Received mercury packet
[21:28:07.457212] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198887.1903951872 (ts:74581870936250)
[21:28:08.458349] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198888.1791361024 (ts:74581870979194)
[21:28:08.769560] raopcl_send_chunk:588 [0x7f84009610]: check n:3276741441 p:3276742674 ts:74581870994330 sn:9512
               retr: 0, avail: 0, send: 0, select: 0)
[21:28:09.143013] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.614103013 (ref<PHONE_NUMBER>.610267064)
[21:28:09.459484] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198889.1850212352 (ts:74581871023898)
[21:28:10.460601] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198890.1806172160 (ts:74581871067546)
[21:28:11.461743] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198891.1796472832 (ts:74581871111546)
[21:28:11.600790] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.2580235962 (ref<PHONE_NUMBER>.2576740375)
[21:28:12.462945] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198892.1820983296 (ts:74581871155898)
[21:28:13.464149] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198893.1982660608 (ts:74581871201658)
[21:28:14.010107] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.43276090 (ref<PHONE_NUMBER>.38555406)
[21:28:14.465285] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198894.1938620416 (ts:74581871245306)
[21:28:15.466418] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198895.1963196416 (ts:74581871289658)
[21:28:16.064293] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.275998893 (ref<PHONE_NUMBER>.271382123)
[21:28:16.467562] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198896.1953431552 (ts:74581871333658)
I MercurySession.cpp:42: Received packet, command: 181
D SpircHandler.cpp:67: Received subscription response
D SpircHandler.cpp:124: Notify frame
[21:28:17.468702] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198897.1806565376 (ts:74581871376250)
D spotify.cpp:416: keepAlive Shop Cone+
[21:28:18.168598] exec_request:614 [0x7f8400d9b0]: ----> : write OPTIONS * RTSP/1.0
CSeq: 10
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

[21:28:18.172062] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:18.174467] exec_request:650 [0x7f8400d9b0]: <------ : Public: ANNOUNCE, SETUP, RECORD, PAUSE, FLUSH, TEARDOWN, OPTIONS, GET_PARAMETER, SET_PARAMETER, POST, GET
[21:28:18.175057] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:18.175339] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 10
[21:28:18.469920] _raopcl_send_sync:1254 [0x7f84009610]: sync ntp:1691198898.1831141376 (ts:74581871420602)
I MercurySession.cpp:42: Received packet, command: 181
D SpircHandler.cpp:67: Received subscription response
D SpircHandler.cpp:124: Notify frame
D SpircHandler.cpp:129: Another player took control, pausing playback
I TrackPlayer.cpp:94: Resetting state
I TrackPlayer.cpp:249: Playing done
I spotify.cpp:104: Disconnecting Shop Cone+
[21:28:18.872004] _rtp_timing_thread:1328 [0x7f84009610]: NTP sync:<PHONE_NUMBER>.3744769100 (ref<PHONE_NUMBER>.3739876832)
[21:28:19.873379] exec_request:614 [0x7f8400d9b0]: ----> : write FLUSH rtsp://[IOT Network IP]/3344080965 RTSP/1.0
RTP-Info: seq=10737;rtptime=4059297435
CSeq: 11
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

[21:28:19.876443] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:19.876759] exec_request:650 [0x7f8400d9b0]: <------ : RTP-Info: rtptime=4059297082
[21:28:19.877018] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:19.877184] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 11
[21:28:19.877287] exec_request:614 [0x7f8400d9b0]: ----> : write TEARDOWN rtsp://[IOT Network IP]/3344080965 RTSP/1.0
CSeq: 12
User-Agent: iTunes/7.6.2 (Windows; N;)
Client-Instance: 5ca4b754d44c9e31
DACP-ID: 1A2B3D4EA1B2C3D4
Active-Remote:<PHONE_NUMBER>
Session: 1

[21:28:19.943297] exec_request:640 [0x7f8400d9b0]: <------ : 200: request ok
[21:28:19.943569] exec_request:650 [0x7f8400d9b0]: <------ : Server: AirTunes/190.9
[21:28:19.943708] exec_request:650 [0x7f8400d9b0]: <------ : CSeq: 12
I TrackPlayer.cpp:94: Resetting state
I MercurySession.cpp:128: Disconnecting mercury session
I PlainConnection.cpp:197: Closing socket...
E PlainConnection.cpp:146: Connection lost, will need to reconnect...
E MercurySession.cpp:53: Error while receiving packet: Reconnection required
I spotify.cpp:441: disconnecting player Shop Cone+
exit
[21:28:22.872647] main:1252 stopping cspot devices ...
[21:28:22.872716] main:1254 stopping Raop devices ...
[21:28:22.872742] Stop:926 terminate search thread ...
[21:28:22.906509] Stop:935 flush renderers ...
Segmentation fault

As always, I'm happy to provide more information!

Thanks for reporting that as well and thanks for taking the time to test (and I know it can be painful...)

Oh, can you try the read_ahead parameter in the config file and set it to 2000?


Preserve boundaries option

I have added preserveBoundaries option which doesn't allow sidenotes to move through the boundary.
Usage:
setup(store, { padding: 15, preserveBoundaries: true });

Would be great to have your contribution if it is in a state to be public / useful to other projects!


But FWIW on main, for duct ls I have
10 runs real:0.10+-1.19e-02 user:0.04+-8.43e-03 sys:0.02+-9.18e-03
and here
10 runs real:0.24+-5.66e-01 user:0.03+-9.94e-03 sys:0.10+-2.78e-01
so I guess adding a threads adds an overhead, but not large and because
❯ duct -l DEBUG sleep 1
2024-08-20T14:08:50-0400 [INFO    ] con-duct: duct is executing 'sleep 1'...
2024-08-20T14:08:50-0400 [INFO    ] con-duct: Log files will be written to .duct/logs/2024.08.20T14.08.50-3349561_
2024-08-20T14:08:50-0400 [DEBUG   ] con-duct: Starting monitoring of the process <Popen: returncode: None args: ['sleep', '1']> on sample interval 1.000000 for report interval 60.000000
2024-08-20T14:08:50-0400 [DEBUG   ] con-duct: Checking NVIDIA GPU using nvidia-smi
2024-08-20T14:08:51-0400 [DEBUG   ] con-duct: Process ended, setting stop_event to stop monitoring thread
2024-08-20T14:08:51-0400 [DEBUG   ] con-duct: Waiting for monitoring thread to finish
2024-08-20T14:08:51-0400 [DEBUG   ] con-duct: Breaking out because stop event was set
2024-08-20T14:08:51-0400 [DEBUG   ] con-duct: Monitoring thread finished

so we did start checking nvidia before sleep finished, I think it is all good and as desired.


Complete example fails to plan

Description
Update the vpe gateway module inputs to match 4.x.x variables in the complete example
Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

It may be necessary to skip upgrade test, since the base code on the main branch is broken.
Before doing this I am running tests locally.

/run pipeline

/run pipeline

Local tests were successful following a plan, apply, plan, destroy cycle for the complete example.
Due to the issues on the main branch this commit should be merged as one off without upgrade testing. Future PRs should then work with upgrade testing.

:tada: This PR is included in version 3.9.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tour stops working after loading page for next step

I'm running into issue where the tour disappears as soon as I add a step to my tour that goes to another page. Steps within the page where the tour was started from work fine. Only steps that go to new pages are giving me this issue. The new page is loaded but their are no popovers and no error messages in the chrome console. Here's my code for implementing the tour. The tour stops on step 3 when the tour moves to a different page and looks for a h1 tag which is present.
class window.ManagerTour
  constructor: ->
    @tour = new Tour()
    @step1()
    @step2()
    @step3()
    @step4()

  start: ->
    @tour.start(true)

  restart: ->
    @tour.restart()

  step1: ->
    @tour.addStep(
      path: "/users/edit"
      element: "h2"
      title: "Something"
      content: "Good"
      placement: "left"
    )

  step2: ->
    @tour.addStep(
      path: "/users/edit"
      element: "#user_email"
      title: "Enter your new email address"
      content: "Enter a new email address."
      placement: "right"
    )

  step3: ->
    @tour.addStep(
      path: "/employees"
      element: "h1"
      title: "Enter your h1"
      content: "Enter a new email address."
      placement: "bottom"
    )

  step4: ->
    @tour.addStep(
      path: "/users/edit"
      element: "h2"
      title: "Enter your h2"
      content: "Enter a new email address."
      placement: "bottom"
    )

start_tour_on_click = (tour) ->
  $('#tour_link').click (e) ->
    e.preventDefault()
    tour.restart()
    tour.start()

jQuery ->
  manager_tour = new ManagerTour()
  start_tour_on_click(manager_tour)

i also have same kind of problem . all pages my header and footer are same only content is different. when go to next page tour getting started again. so i am not able to move from first step. first step is header only.


Newline in link refs to fix them

...

r? @alercah or @matthewjasper

Looks good to me!

Thanks!


[Alien Roleplaying Game] Added ship tab

Changes / Comments
Ship tab was requested some time ago but no one responded, so I created a tab according to the request here: https://app.roll20.net/forum/post/7781132/sheet-request-thread-consolidated-mk-ii/?pageforid=9272741#post-9272741.
Added tabs at the top right, one for character and one for ship. The ship tab uses mainly the same graphics as the character tab.
Also

included a background image for later, need to be on /Roll20 github to use.
Counting successes and stress in the roll template.

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Notification from project updates

would it be possible to add a Watch function to the roadmap software,so that when you watch a project category... you'll be notified on the new topic that is created in that project.
https://roadmap.ploi.io/items/95-roadmap-request

For now, doesn't seem that popular. If someone still likes to see this feel free to send in a PR.


Security improvements

(See commit messages.)

Hi, @nepella
Thanks for your contribution.
Could you please run go mod tidy to add the new requirement github.com/gorilla/securecookie to the go.mod file and commit?
This will make the workflow pass.

Thanks much for getting this merged so quickly and for writing this plugin. I'd been using the Nginx-ldap-auth proof-of-concept with the forwardauth middleware for some low-risk internal sites. This is better written and easier to use, and, with bind mode, I don't even have to store a secret.


Fix issue where invocations are not read properly when not the party leader

Think of some alternatives: keep track of invo's per party leader?


Improved support for OpenGL ES 3.0 and added support for OpenGL ES 3.1

Improved OpenGL ES 3.0 Support (some missing functions)
Added OpenGL ES 3.1 Support (for LWJGL3 and Android)
API addition: added Lwjgl3ApplicationConfiguration.useOpenGL31() for OpenGL ES 3.1
API addition: added Graphics.isGL31Available() and Graphics.getGL31() for OpenGL ES 3.1

More details here:
http://www.badlogicgames.com/forum/viewtopic.php?f=17&t=25868

closing, now that #6945 has been merged


[Bug] $h.provideHover: ERR Cannot read properties of undefined (reading 'property')

Describe the bug
I'm getting this strange error when trying to hover over a variable.
Autocomplete is also not working. Only have the Svelte extension, the PostCSS extension and this extension enabled.
The error leads me to believe that it is indeed this extension that is failing:
ERR Cannot read properties of undefined (reading 'property'): TypeError: Cannot read properties of undefined (reading 'property')
	at $h.provideHover (/Users/s0001325/.vscode/extensions/phoenisx.cssvar-2.4.1/out/extension.js:68:519)

I would be very happy to provide more info/context but I don't know where to start. I have attached a small screen recording of what is happening.
To Reproduce
Steps to reproduce the behavior:

Enable extension
Hover on css variable

Expected behavior
Autocomplete and hover should work
Screenshots
https://user-images.githubusercontent.com/31876997/197547077-6e4d1625-30d7-4a32-b983-2c1a75b14943.mov
Details (please complete the following information):

OS: macOS Monterey 12.6
VSCode version: 1.72.2
Extension version 2.4.1

Thanks, @ollema for raising this issue.
Your attached video file is in .mov format unsupported on Firefox 😅
Anyways I tried replicating this issue in examples/css-in-node-modules example, but couldn't.
I think this issue happens only in .svelte files with .postcss styles in it.
Can u help me with the following:

Are you using any postcss plugins/syntax parsers for your styles?
What happens if you change style lang to css?

Anyways it would be great if you can share a repro of this issue. Or else give me some time to setup and recreate this bug to figure out the issue 👍🏽

for some reason, this started working today. I have closed and reopened vscode a dozen time but today it started working. I will close this for now and re-open with a repro if it happens again

There was a recent release v2.4.0 which had a bug, that I fixed in v2.4.1. There's a high possibility that the error you got relates to a previous bug.
I will open a new issue, pointing to this one, to handle such errors more gracefully 👍🏽
Thanks for your support!


Roll Flutter Engine from 7665ae51846f to c0ca450e03c8 (18 revisions)

https://github.com/flutter/engine/compare/7665ae51846f...c0ca450e03c8
2022-11-28<EMAIL_ADDRESS>Revert Dart to 2.19.0-431.0.dev (flutter/engine#37934)
2022-11-28<EMAIL_ADDRESS>Roll Skia from 9d3726a26123 to 556e08aa5354 (1 revision) (flutter/engine#37933)
2022-11-28<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 7hM0w3gBLnY1eZM2G... to CUPWWG1rEmonxuLpv... (flutter/engine#37932)
2022-11-28<EMAIL_ADDRESS>Roll Skia from f0a2e2a08ee7 to 9d3726a26123 (2 revisions) (flutter/engine#37929)
2022-11-28<EMAIL_ADDRESS>Roll Skia from 79f890c4ba92 to f0a2e2a08ee7 (1 revision) (flutter/engine#37928)
2022-11-27<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from vt3S3a_dnaqNTkO0x... to 7hM0w3gBLnY1eZM2G... (flutter/engine#37922)
2022-11-27<EMAIL_ADDRESS>Roll Skia from 2618d380def4 to 79f890c4ba92 (1 revision) (flutter/engine#37921)
2022-11-27<EMAIL_ADDRESS>Roll Dart SDK from 4851720b30d2 to 3ed1fc1c344d (1 revision) (flutter/engine#37920)
2022-11-27<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from E3Fd0hvwiXVfn7egS... to vt3S3a_dnaqNTkO0x... (flutter/engine#37917)
2022-11-26<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from lYAPXiPJ9RcPGLUqb... to E3Fd0hvwiXVfn7egS... (flutter/engine#37915)
2022-11-26<EMAIL_ADDRESS>Roll Dart SDK from ae4b643d2a4b to 4851720b30d2 (1 revision) (flutter/engine#37914)
2022-11-25<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from ejjE2o60iiA3_agab... to lYAPXiPJ9RcPGLUqb... (flutter/engine#37911)
2022-11-25<EMAIL_ADDRESS>Roll Dart SDK from eb65e5cd48e9 to ae4b643d2a4b (1 revision) (flutter/engine#37910)
2022-11-25<EMAIL_ADDRESS>Roll Dart SDK from ae7042bf53ff to eb65e5cd48e9 (1 revision) (flutter/engine#37909)
2022-11-25<EMAIL_ADDRESS>Roll Skia from a01af64f5cec to 2618d380def4 (4 revisions) (flutter/engine#37907)
2022-11-25<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from NvafPMjJLQ0fBSSAc... to ejjE2o60iiA3_agab... (flutter/engine#37906)
2022-11-25<EMAIL_ADDRESS>Roll Dart SDK from 962cd6e0d20a to ae7042bf53ff (1 revision) (flutter/engine#37904)
2022-11-25<EMAIL_ADDRESS>Roll Dart SDK from eddf73d66119 to 962cd6e0d20a (1 revision) (flutter/engine#37900)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from NvafPMjJLQ0f to CUPWWG1rEmon
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Updated Travis to remove allow_failures

Removed allow_failures to help Travis run 3.x tests

Hi @souravsingh - the reason for permitting 3.x failures at this stage in Halotools development is that the current code fails 3.x compatibility, but I want to continue being able to use Travis while I work towards 3.x compatibility, and I don't want to halt all development until this is resolved. Is there a particular reason you submitted this PR?

I saw the open issue at #266 which mentioned about removing the section in Travis.

I can close the PR if it isn't needed

Ahh, ok, yes, thanks. #266 actually comments that this PR should only be made and merged after 3.x compatibility is achieved. If this PR were merged in now, then Travis would fail until compatibility goes through, which is not currently a pressing priority.
I could leave this PR open since you are correct that this is exactly what needs to be done once Halotools is 3.x compatible, but #266 is already serving as a marker to help me remember to do this, so I'll go ahead and close this for now but reopen it and go through with the merge whenever Halotools is 3.x compatible. Thanks for submitting the PR though.


update reference.yml for 1.20 reference docs

Remove cloud-controller-manager component (not building)
Add copy of kubectl cmd package

@annajung , I retested these changes. I think the kubectl command pages look okay.

Hi @kbhawkey I tested the changes and I do not see any error running the following command
python update-imported-docs.py reference.yml 1.20.0-rc.0

For me, these are the files that were changed/created as a result. Could you compare with your result and see if this looks correct?
        modified:   content/en/docs/reference/command-line-tools-reference/kube-apiserver.md
        modified:   content/en/docs/reference/command-line-tools-reference/kube-controller-manager.md
        modified:   content/en/docs/reference/command-line-tools-reference/kube-proxy.md
        modified:   content/en/docs/reference/command-line-tools-reference/kube-scheduler.md
        modified:   content/en/docs/reference/kubectl/kubectl.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_alpha_kubeconfig_user.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_certs_generate-csr.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_control-plane_all.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_control-plane_apiserver.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_control-plane_controller-manager.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_control-plane_scheduler.md
        modified:   content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_upload-certs.md
        new file:   static/docs/reference/generated/kubernetes-api/v1.20/index.html
        new file:   static/docs/reference/generated/kubernetes-api/v1.20/js/navData.js

/approve
/hold
@kbhawkey please unhold at will

/kind cleanup

@annajung , I don't see the kubectl command reference in the list of generated pages.
PR #25355 generated 31 files?

You may want to remove the cloud-controller-manager page (v1.19) in the same PR when you regenerate the files?
I am not sure if a decision was made about this component.
https://kubernetes.io/docs/reference/command-line-tools-reference/cloud-controller-manager/

Ran it again and I actually must have missed this the first time, but I am getting the following error
cp gen-kubectldocs/generators/build/index.html /Users/antheaj/workspace/website/static/docs/reference/generated/kubectl/kubectl-commands.html
cp: gen-kubectldocs/generators/build/index.html: No such file or directory
make: *** [copycli] Error 1

I don't have the gen-kubectldocs/generators/build/index.html file to be copied over.
Any tips on what could be missing?
I created a branch out of dev-1.20 and made changes to reference.yml file based on changes in this PR. Then ran the python command.

You may want to remove the cloud-controller-manager page (v1.19) in the same PR when you regenerate the files?
I am not sure if a decision was made about this component.
https://kubernetes.io/docs/reference/command-line-tools-reference/cloud-controller-manager/

There is a discussion going on in slack https://kubernetes.slack.com/archives/C0EG7JC6T/p1606929363248600. I'm waiting to hear back from SIG api machinery and will take action based on the outcome of the discussion :)

There must have been more errors. The kubectl command build failed.
I would double check your version of reference.yml. You can copy the raw version of the file to your clone.
You can check the temporary install (build sandbox) to see if the kubectl cmd package was copied over (line 21).

I confirmed that src/k8s.io/kubernetes/pkg/kubectl/ is there
reference.yml was copied using a raw version of the file
No other errors that I can see... I could have missed something, attaching the whole output.txt if you want to take a look

I will try again with a fresh repo!

I looked. Can you check if there are files generated under /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes and /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build/
I am wondering if the docker command failed (UI) or the build of the files?
go run gen-kubectldocs/main.go --kubernetes-version v1_20
docker run -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes:/source -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build:/build -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/:/manifest brianpursley/brodocs:latest
navData.js saved!
index.html saved!
cp gen-kubectldocs/generators/build/index.html /Users/antheaj/workspace/website/static/docs/reference/generated/kubectl/kubectl-commands.html
cp: gen-kubectldocs/generators/build/index.html: No such file or directory
make: *** [copycli] Error 1

Both /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes and /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build/ do contain multiple .md files
are you thinking the docker command must have failed? docker run -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes:/source -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build:/build -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/:/manifest brianpursley/brodocs:latest

oh wait! SORRY, bad copy/paste
/tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build/

build directory does not exist for me

sudo rm -f main
Password:
sudo rm -rf /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes
sudo rm -rf /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build
sudo rm -rf /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/manifest.json
go run gen-kubectldocs/main.go --kubernetes-version v1_20
docker run -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes:/source -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build:/build -v /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/:/manifest brianpursley/brodocs:latest
navData.js saved!
index.html saved!
cp gen-kubectldocs/generators/build/index.html /Users/antheaj/workspace/website/static/docs/reference/generated/kubectl/kubectl-commands.html
cp: gen-kubectldocs/generators/build/index.html: No such file or directory
make: *** [copycli] Error 1

so there is a command here
sudo rm -rf /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/build

but I assume
go run gen-kubectldocs/main.go --kubernetes-version v1_20

should create the directory again(?)
but I am guessing go run gen-kubectldocs/main.go --kubernetes-version v1_20 is failing for me

OK. Your includes directory is empty?
/tmp/tmpbi795jq3/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes$ ls
_app_management.md                                 _generated_cluster-info.md  _generated_exec.md          _generated_replace.md
_generated_alpha.md                                _generated_completion.md    _generated_explain.md       _generated_rollout.md
_generated_annotate.md                             _generated_config.md        _generated_expose.md        _generated_run.md
_generated_api-resources.md                        _generated_cordon.md        _generated_get.md           _generated_scale.md
_generated_api-versions.md                         _generated_cp.md            _generated_kustomize.md     _generated_set.md
_generated_apply.md                                _generated_create.md        _generated_label.md         _generated_taint.md
_generated_attach.md                               _generated_debug.md         _generated_logs.md          _generated_top.md
_generated_auth.md                                 _generated_delete.md        _generated_options.md       _generated_uncordon.md
_generated_autoscale.md                            _generated_describe.md      _generated_patch.md         _generated_version.md
_generated_category_cluster_management.md          _generated_diff.md          _generated_plugin.md        _generated_wait.md
_generated_category_kubectl_settings_and_usage.md  _generated_drain.md         _generated_port-forward.md  _getting_started.md
_generated_certificate.md                          _generated_edit.md          _generated_proxy.md         _working_with_apps.md

includes/ directory is there but my content looks different than yours.
I also have the manifest.json just not build/
(base) /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators/includes (master ✘)✹✭ (minikube) ᐅ ls
_app_management.md                         _generated_category_kubectl_settings_and_usage.md  _generated_describe.md   _generated_logs.md          _generated_set.md
_generated_alpha.md                        _generated_certificate.md                          _generated_diff.md       _generated_options.md       _generated_taint.md
_generated_annotate.md                     _generated_cluster-info.md                         _generated_drain.md      _generated_patch.md         _generated_top.md
_generated_api-resources.md                _generated_completion.md                           _generated_edit.md       _generated_plugin.md        _generated_uncordon.md
_generated_api-versions.md                 _generated_config.md                               _generated_exec.md       _generated_port-forward.md  _generated_version.md
_generated_apply.md                        _generated_cordon.md                               _generated_explain.md    _generated_proxy.md         _generated_wait.md
_generated_attach.md                       _generated_cp.md                                   _generated_expose.md     _generated_replace.md       _getting_started.md
_generated_auth.md                         _generated_create.md                               _generated_get.md        _generated_rollout.md       _working_with_apps.md
_generated_autoscale.md                    _generated_debug.md                                _generated_kustomize.md  _generated_run.md
_generated_category_cluster_management.md  _generated_delete.md                               _generated_label.md      _generated_scale.md

(base) /tmp/tmpn3fyfb6k/src/github.com/kubernetes-sigs/reference-docs/gen-kubectldocs/generators (master ✘)✹✭ (minikube) ᐅ ls
Dockerfile  includes       read_cmd.go   types.go  v1_12  v1_14  v1_16  v1_18  v1_20  v1_6  v1_8
gen.go      manifest.json  templates.go  v1_11     v1_13  v1_15  v1_17  v1_19  v1_5   v1_7

If the includes directory contains files, then I would check Docker.

I think this change can go in.
/hold cancel

@annajung , Would you LGTM/approve this PR? I think the changes work.

/lgtm
/approve


Migrate cron jobs to supported batch/v1 API  [COMP]

Explain your changes:
Update cron jobs definition to support batch/v1 API
Explain how you tested your changes:
run CI
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me


adding additional disk to existing server

System Information
Linux distribution
Ubuntu 18.04.4 LTS
Terraform version
Terraform v0.12.29
Provider and libvirt versions
./terraform-provider-libvirt 0.6.2+git.1585292411.8cbe9ad0
Compiled against library: libvirt 4.0.0
Using library: libvirt 4.0.0
Running hypervisor: QEMU 2.11.1
Running against daemon: 4.0.0

main.tf - works fine, applied this and was using VM in prod
provider "libvirt" {
  uri = "qemu:///system"
}

resource "libvirt_volume" "example-1-volume" {
  name = "example-1-volume.qcow2"
  pool = "default"
  source = "http://cloud-images.ubuntu.com/releases/bionic/release-20200908/ubuntu-18.04-server-cloudimg-amd64.img"
  format = "qcow2"
}

# Define KVM domain to create
resource "libvirt_domain" "example-1" {
  name   = "example-1"
  memory = "10240"
  vcpu   = 4
  autostart = "true"

  disk = [
    {
      volume_id = libvirt_volume.example-1-volume.id
      scsi = "false"
      block_device = ""
      file = ""
      url = ""
      wwn = ""
    }
  ]
  network_interface {
    bridge = "br0"
    mac    = "00:01:00:00:00:01"
  }

  boot_device {
    dev = ["hd", "network"]
  }

  console {
    type        = "pty"
    target_type = "serial"
    target_port = "0"
  }

  console {
    type        = "pty"
    target_type = "virtio"
    target_port = "1"
  }

  graphics {
    type        = "spice"
    listen_type = "address"
    autoport    = true
  }

  video {
    type = "vga"
  }
}

When I add additional HD data disk:
resource "libvirt_volume" "example-1-volume-hd" {
  name   = "example-1-volume-hd.qcow2"
  pool   = "hd"
  format = "qcow2"
  size   =<PHONE_NUMBER>800
}

  disk = [
    {
      volume_id = libvirt_volume.example-1-volume.id
      scsi = "false"
      block_device = ""
      file = ""
      url = ""
      wwn = ""
    },
    {
      volume_id = libvirt_volume.example-1-volume-hd.id
      scsi = "false"
      block_device = ""
      file = ""
      url = ""
      wwn = ""
    }
  ]

terraform plan wants to destroy virtual machine which is not desired behaviour:
  # libvirt_domain.example-1 must be replaced
-/+ resource "libvirt_domain" "example-1" {
      ~ arch        = "x86_64" -> (known after apply)
        autostart   = true
      - cmdline     = [] -> null
      ~ disk        = [ # forces replacement
            {
                block_device = ""
                file         = ""
                scsi         = false
                url          = ""
                volume_id    = "/app/prod/kvm/storage/example-1-volume.qcow2"
                wwn          = ""
            },
          + {
              + block_device = ""
              + file         = ""
              + scsi         = false
              + url          = ""
              + volume_id    = (known after apply)
              + wwn          = ""
            },
        ]

How can I add additional disk to the system which cannot be rebuilt?
Many thanks

thx @laimison  for issue.
I think we need a way to update the domains without forcing its recreation.

For now I have added this block:
# Attach HD
resource "null_resource" "example-mount-hd" {
  provisioner "local-exec" {
    command = "virsh attach-disk server-1 --target vdx --source /apphd/prod/kvm/storage/example-1-volume-hd.qcow2 --persistent --driver qemu --subdriver qcow2 --targetbus virtio"
  }
}

So it confirms that only attachment is missing if that option can be used in provider's logic.


npm run generator not functioning as intended

First of all I apologize if I've missed an already existing issue regarding this.
When running npm run generate in Win10 command prompt and Webstorm terminal I get the same behavior which is a list with option to choose from, but navigation through them does not work. So basically I can initially choose components or containers by specifying it in the initial command, but I can't choose between stateless function or es6 class (it's always stateless func).
Running the generate command in Git Bash throws an error:
$ npm run generate

><EMAIL_ADDRESS>generate C:\www\allstr
> plop --plopfile internals/generators/index.js

? [PLOP] Please choose a generator. (Use arrow keys)
> component - Add an unconnected component
  container - Add a container component
  route - Add a route
  language - Add a langauge

C:\www\allstr\node_modules\rx-lite\rx.lite.js:75
    throw e;
    ^

SyntaxError: Invalid regular expression: /.{1,0}/: numbers out of order in {} qu                                                                     antifier.
    at new RegExp (native)
    at breakLines (C:\www\allstr\node_modules\plop\node_modules\inquirer\lib\uti                                                                     ls\screen-manager.js:108:15)
    at ScreenManager.render (C:\www\allstr\node_modules\plop\node_modules\inquir                                                                     er\lib\utils\screen-manager.js:55:22)
    at Prompt.render (C:\www\allstr\node_modules\plop\node_modules\inquirer\lib\                                                                     prompts\list.js:103:15)
    at Prompt._run (C:\www\allstr\node_modules\plop\node_modules\inquirer\lib\pr                                                                     ompts\list.js:74:8)
    at Prompt.run (C:\www\allstr\node_modules\plop\node_modules\inquirer\lib\pro                                                                     mpts\base.js:57:8)
    at Object.<anonymous> (C:\www\allstr\node_modules\plop\node_modules\inquirer                                                                     \lib\ui\prompt.js:84:12)
    at module.exports (C:\www\allstr\node_modules\run-async\index.js:15:21)
    at AnonymousObservable.__subscribe (C:\www\allstr\node_modules\plop\node_mod                                                                     ules\inquirer\lib\utils\utils.js:16:7)
    at AnonymousObservable.tryCatcher (C:\www\allstr\node_modules\rx-lite\rx.lit                                                                     e.js:63:31)

I'm also on Windows 10 (anniversary update) but don't experience this bug:

Maybe it's because of your node version? This is what I use:
>node -v
v4.4.6

Also 'legacy console' is unchecked in settings:

This seems to be a problem with your environment, nothing specific to the boilerplate @mnemanja. Hope you figure it out soon!

I've noticed that @mnemanja uses 3.0 version and I use master branch so maybe there is an error after all.

master is always the newest version, so if this bug is fixed in the newest version there's nothing really for us to do here 😊

I've switched to the master now. This is the pre-anniversary version and the legacy mode was not on.
I wrote to the plop package because this is is the part that is not working for me https://github.com/amwmedia/plop/issues/35
Thanks guys for the quick response :+1:

@mnemanja, did you see any errors while running npm i? What is your node.js' version?
Another suggestion is to put your project on a disk D with empty node_modules and run npm i there in case it's some sort of file permission issue.

@Dattaya
Basically went fine except these few warn and pre-commit lines.
npm is 3.6.0
Unfortunately i only have one disk here :)
npm WARN deprecated<EMAIL_ADDRESS>This package is deprecated in favor of                                                                                istanbuljs/babel-plugin-istanbul
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead!
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

><EMAIL_ADDRESS>install C:\www\test\react-boilerplate\node_modules\pre-commit
> node install.js

pre-commit:
pre-commit: Failed to symlink the hook file in your .git/hooks folder because:
pre-commit: EPERM: operation not permitted, symlink '..\..\node_modules\pre-commit\hook' -> 'C:\www\test\react-boilerplate\.git\hooks\pre-commit'
pre-commit: The hook was not installed.
pre-commit:

...

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^2.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

npm 3.6.0 could mean that you have node 6.x installed. I switched to it, installed dependencies again (got exact same errors as yours; 'Failed to symlink' error could be prevented when the console is in administrator mode but it's unrelated to the current issue).
It seems like I'm out of ideas, you can update your old npm to npm 3.10.3 with npm i -g npm but the chances of solving this problem with it are close to zero. I don't think it's related to the anniversary update being installed either but during the weekend I'll try to install react-boilerplate on my laptop that hasn't been updated and will see what the result is.

My Node is 5.7.0.
I've fixed the problem by changing the node version to 6.2.
https://github.com/amwmedia/plop/issues/35

I am just posting this here because maybe someone could face the same problem again. I 'm using windows 10 home edition and node 6.9.1. I don't know why, but generator command does not work on github bash shell, but it does on default windows cmd shell. Weird, I don't know why, but at least it works.
Regards

@danielo515 - that worked a treat for me, running from Windows CLI instead of Git Bash.  On Windows 7, with Node v7.2.0 and npm v3.10.9 I had the same regex error as you from Git Bash.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
10 seconds
label-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
10 seconds
label-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
10 seconds
label-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary


Replace the pools with concurrent.futures

There's no reason to write use them if you have a ThreadPoolExecutor built into the python standard and backported to run on Python 2.x.
This will allow us to remove some code which is always good.
What do you think?

I don't understand how ThreadPoolExecutor replaces our pooling helpers. Also this is six years old.


fix: use filepath to get dev image path

see linked issue

Codecov Report

Merging #97 (883cce0) into develop (4462649) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    37.44%   37.44%
========================================
  Files           39       39
  Lines         2812     2812
========================================
  Hits          1053     1053
  Misses        1655     1655
  Partials       104      104

Flag
Coverage Δ

unittests
37.44% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/build/build.go
36.36% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4462649...883cce0. Read the comment docs.


fix(push): fixes push notifications not showing (#100)

📋 Description

Fixes push notifications not showing on any desktops by checking whether target has image_url when retrieving iconChat, avoiding an exception thrown as described in #100.
🗂 Type

[ ] 🍾 Feature
[x] 🚨 Bugfix
[ ] 📒 Documentation
[ ] 👷 Internals

🔥 Severity

[x] 💎 Non-Breaking Changes
[ ] 💔 Breaking Changes

🖥 Platforms

[x] 🍏 macOS
[x] 💾 Windows
[x] 🐧 Linux

🛃 Tests

[x] My changes have been tested manually.
[ ] My changes are covered by automated testing methods.

👨🎓 Miscellaneous

[x] My changes follow the style guide.
[ ] My changes require updates to the documentation.

@btaens Thank you, this will be in the next release as well.


The SCIM multi-valued attributes with primary:true and defined type do not behave as the primary attribute

Describe the issue:
The improvement https://github.com/wso2/product-is/issues/3823 has given the capability to store primary sub-attribute of complex multi-valued properties such as
emails,
addresses,
phoneNumbers, etc
But IS functionality wise, the attribute value marked as the primary:true won't get used.
For example,
flows such as password recovery, all notification sending via emil the email address defined as "primary":true will not be taken into consideration. Instead, the email address available at http://wso2.org/claims/emailaddress will be used.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix calls to va_start, va_end etc using ... vararg

Describe the bug / feature request
When decompiling a routine with varargs (i.e. uses ... as last parameter), the command to convert them to a va_list isn't really understood leaving results like:
_vsprintf(local_414,pszFormat,&stack0x00000008);
completely removing the local variable assigned in the usage of va_start, va_end etc. implementations and thus any hope of recreating those calls.
To Reproduce
Steps to reproduce the behavior:

Load the attched gzf file
Goto function void HookLogError(char * pszFomat, ...)
Scroll down to _vsprintf
See last parameter and corresponding assembly:

      100017b5 8d 45 0c       424              LEA          EAX=>Stack[0x8],[EBP + 0xc]
      100017b8 89 85 ec fb    424              MOV          dword ptr [EBP + local_418],EAX
               ff ff
      100017be 8b 85 ec fb    424              MOV          EAX,dword ptr [EBP + local_418]
               ff ff
      100017c4 50             424              PUSH         EAX
      100017c5 8b 45 08       428              MOV          EAX,dword ptr [EBP + param_1]
      100017c8 50             428              PUSH         EAX
      100017c9 8d 85 f0 fb    42c              LEA          EAX=>local_414,[EBP + 0xfffffbf0]
               ff ff
      100017cf 50             42c              PUSH         EAX
      100017d0 e8 4b 07 00    430              CALL         _vsprintf                                                int _vsprintf(char * _Dest, char * _Fo
               00
      100017d5 83 c4 0c       430              ADD          ESP,0xc
      100017d8 c7 85 ec fb    424              MOV          dword ptr [EBP + local_418],0x0
               ff ff 00 00
               00 00

local_418 is the missing link as this would be the va_list local_418; and created by lines at 100017b5 & 100017b8 and ended by the line at 100017d8 with the respective code/macros va_start(local_418, pszFormat) & va_end(local_418).
Expected behavior
To see the wrapping calls to va_start(local_418, pszFormat) & va_end(local_418).
Screenshots
N/A
Attachments
Created by Visual C++ 4.1
vc4.1.Dd25Hook.dll.zip
Environment (please complete the following information):

OS: Windows 11
Java Version: <IP_ADDRESS>
Ghidra Version: 11
Ghidra Origin: official GitHub distro

Additional context
FYI this routine is using try / catch which also need some help (see #2477).

Btw, the definition of function _vsprintf states that the 3rd parameter is a va_list.  Surely that could help in the identification and ensure the creation/dimise isn't ignored!


Cold fear dont render correctly (light issue?)

Cold fear dont show any texture but when use a lantern some things appear but as transparent in my case (change light settings dont affect)

GPU: Intel UHD 630 CFL-GT2
Driver: Mesa Oibaf
Wine version:  Staging 8.4
DXVK version:  2.1-git

Log files
coldfear_retail_d3d9.log

Please provide an apitrace.
https://github.com/doitsujin/dxvk/wiki/Using-Apitrace

Added trace
https://drive.google.com/file/d/12dzV9tBALOR5yrTmJAjAYMUW_VsWsuh3/view?usp=share_link

FF_FS_ed95124a53eb473131462fe45cb6b82357b29a05.spv has the following validation error:
error: line 291: Vector access is out of bounds, vector size is 4, but access index is 6
  %108 = OpCompositeExtract %float %49 6

FF_FS_ed95124a53eb473131462fe45cb6b82357b29a05.spv.zip

Many thanks issue fixed

Thanks for testing, good to see you still around @mrdeathjr28 :smile:

Thanks for testing, good to see you still around @mrdeathjr28 smile


feat: add OIDC configuration and general improvements

Description of the changes
This PR adds the necessary configuration to make MinIO work with OIDC for accessing the web interface.
I also added the flag necessary to activate the ServiceMonitor after the first deployment.
Besides, I took the opportunity to do a patch upgrade of the Helm chart.
Breaking change

[x] No - Because the OIDC configuration won't be required although it is preferred and because the chart upgrade is only a patch upgrade (5.0.7 -> 5.0.9).

Tests executed on which distribution(s)

[x] KinD

A general comment about devops stack PRs: since we're using "squash & merge" when merging PRs, please create separate PRs for differents things (otherwise we end up with single commits that change many unrelated things which is not good practice) :
* adding a `enable_service_monitor` variable

* upgrading the minio chart

* adding the OIDC configuration

* general improvements / cleanup (this one could maybe be done within one of the other PRs)

I was actually thinking of doing a Rebase and Merge on this branch, that's why you see so many force pushes on the history of the PR, I was trying to keep the commit history clean in order to do a proper merge.


Recolor xp bar number doesnt either for me and my friend

Hey! So I tried to implement your shader that allows us to change xp bar number color in 1.21 but it doesnt seem to load at all, it displays this errors in the logs:
Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
And
Caught error loading resourcepacks, removing all selected resourcepacks
java.util.concurrent.CompletionException: java.lang.RuntimeException: could not reload shaders
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)
at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:722)
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
at auk.a(SourceFile:69)
at bph.d(SourceFile:162)
at bpl.d(SourceFile:23)
at bph.B(SourceFile:136)
at bph.bB(SourceFile:121)
at fgo.c(SourceFile:1240)
at fgo.f(SourceFile:882)
at net.minecraft.client.main.Main.main(SourceFile:256)
Caused by: java.lang.RuntimeException: could not reload shaders
at ges.c(SourceFile:537)
at ges$1.a(SourceFile:419)
at ges$1.a(SourceFile:396)
at auj.a(SourceFile:13)
at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718)
... 9 more
Caused by: aku: Invalid shaders/core/rendertype_text.json: Couldn't compile vertex program (file/Test, rendertype_text) : 0(29) : error C1102: incompatible type for parameter #1 ("pos.12")
0(29) : error C7623: implicit narrowing of type from "vec3" to "int"
0(29) : error C1104: too many parameters in function call
at aku.a(SourceFile:48)
at gfn.(SourceFile:172)
at ges.c(SourceFile:516)
... 13 more
Caused by: java.io.IOException: Couldn't compile vertex program (file/Test, rendertype_text) : 0(29) : error C1102: incompatible type for parameter #1 ("pos.12")
0(29) : error C7623: implicit narrowing of type from "vec3" to "int"
0(29) : error C1104: too many parameters in function call
at faw.b(SourceFile:69)
at faw.a(SourceFile:51)
at gfn.a(SourceFile:210)
at gfn.(SourceFile:157)
... 14 more
Is there a way to fix this on my side?

This shader hasn't been updated since 1.18 so it will likely need some updating. Possibly some of the parts that come from vanilla have changed and need updating. To do this you could check the vanilla 1.18 shader, see which lines in the shader here are added/modified, and then apply these modifications onto the 1.21 version of the shader.
I plan to update these shaders to a newer version at some point, but it probably won't be very soon.


Config.js ignored on master

Don't know if it's intended, but on master, my yet-to-be-converted configs arenp loaded.
Works fine with v0.3.1.
Tried on MacOS.
Can't do more that log it right now...

This is likely due to #1792 - I think you'll have to move the config.js to ~/.config/oni .

Yes, this is not documented at the moment.
@bryphe Should we wait for the release or go ahead and change README.md and the wiki?

Thanks, will verify and close this issue.

Verified, thanks!

BTW (for reference), solved using ln -s ~/original-path/config.js ~/.config/oni/config.js.
Should work for all non-Windows OSs.


VS Code Fails to Recognize AZ-3166 IoT Devkit Module When Connected to PC

I am following the instructions on the web at: https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-arduino-iot-devkit-az3166-get-started
Everything works fine up to the point where VS Code is supposed to recognize that the module has been attached to the computer and automatically open to the intoruction page. But even though the PC (running Windows 10) recognizes the module, and even though I can connect the Arduino IDE to the module, and even though no error is indicated, VS Code fails to recognize the presence of the module and fails to open to the introduction page as stated. There is no indication of what to do if VS Code does not automatically recognize the module. (No manual work-around)
How to debug this or work around it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0cf9b53c-0438-f23c-fd2e-d57481d57e85
Version Independent ID: f01afd66-d093-ac44-2b20-df225530b39e
Content: IoT DevKit to cloud -- Connect IoT DevKit AZ3166 to Azure IoT Hub
Content Source: articles/iot-hub/iot-hub-arduino-iot-devkit-az3166-get-started.md
Service: iot-hub
GitHub Login: @rangv
Microsoft Alias: rangv

@IoTSolutionsArchitect thank you for your feedback! What is the step in the document that you are blocked with the described issue? Did you check your firmware version  and upgraded to the latest version if needed?
Thank you!

Also can you check what is the status of Visual Studio code on the bottom right?
It should be like this:

Thank you!

Blocked at the section titled "Open the Project Folder". I did check the firmware version and upgraded to the latest (1.4.1). I do not see the "MXCHIP AZ3166" or COM port as I never get to the page displayed. That's the point... it never comes up when the 3166 is connected. The PC signals by audio when the AZ3166 is connected and shows the AZ3166 as a memory device. And if I separately open the Arduino IDE, it recognizes the AZ3166. But VS Code never does.

@IoTSolutionsArchitect  If MXChip is not selected in the Picture above shown by Antonio and you see . Click on it and search for MXChip and select it like shown below

Then type Control+P and type in >Arduino:Examples as shown below

You will see MXChip Examples and you can select the GetStarted sketch

Let me correct that... I just hooked up the AZ3166 and it DOES show "MXCHIP AZ3166" and "COM4" in the lower right corner. But the intro page does not display.

It also shows  to the left of "MXCHIP AZ3166" in the lower right corner of the screen.

Can you now type ControlP and enter >Arduino:Examples and press enter. You should see Examples for MXChip folder

Yes, I am able to see Arduino:Examples. But I get an error that "Cannot find Arduino IDE. Specify arduino.path in user settings. But the arduino.path is already set in user settings to "C:\Program Files (x86)\Arduino" and that is the correct arduino base directory. I have also tried opening and closing the Arduino IDE several times as suggested in the text, but that doesn't help.

I have also tried several variants of the arduino.path specification with left and right slashes and double slashes, always with the same resulting error.

Does it look like this? with \
"arduino.path": "C:\Program Files (x86)\Arduino",

Ah!!! Alas, it works! After setting the arduino.path variable to "C:/Program Files (x86)/Arduino" and restarting VS Code from scratch, it somehow works now. Not sure why it didn't work before, but apparently the changes that I was making to the User Settings for arduino.path weren't taking hold until I saved User Settings and completely restarted VS Code.

I still don't get the introduction page, but at least I can now get to the examples and hopefully proceed forward.

And yes, in reply to your earlier message, originally that was the structure of the arduino.path setting. The final setting that seems to get me to the examples was to use:
"arduino.path": "C:/Program Files (x86)/Arduino"
Still no introduction page, but by hitting Ctrl-Shift-P, I can get to "Arduino Examples" and the "Examples for MXCHIP AZ3166" now shows up.

Have you tried using Azure IoT Workbench extension in VSCode. You should try it if you have not yet. You get an introduction page and can select different samples from the introduction page

I tried using Azure IoT Workbench. Thought it would have been automatically installed as part of the installation script run earlier, but apparently not. Introduction screen is now working. (But now I'm chasing a new set of problems when the module couldn't program correctly under "Getting Started". Will have to keep plowing ahead. May have more questions later, but I think you can consider this particular item closed. Thanks.

Thank you for reporting all the steps @IoTSolutionsArchitect it will help others for sure :).
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

I also had a lot of similar issues - I could not download the code to the mxchip - but after many attempts and variations - the windows firewall popped up with a message that I "allowed" and the the code was able to be downloaded
I was able to view the data from the cloud using the sample app
node ReadDeviceToCloudMessages.js
but the terminal program reports errors when I try to use it
[Starting] Opening the serial port - COM5
[Error]Error: Opening COM5: Access denied


Make sure CI Fails when notebook execution fails

https://github.com/xarray-contrib/xarray-tutorial/pull/76#pullrequestreview-1009721167
Seems the exit code doesn't pick up failed notebook execution so CI passes even if notebooks don't execute correctly https://github.com/xarray-contrib/xarray-tutorial/blob/cdb4b6a237caa8725bc1b0db623dbfb158a73c72/.github/workflows/main.yaml#L35

related https://github.com/executablebooks/jupyter-book/issues/1320


Remove remaining references to suffix and output in modules guidelines

It would be nice to change the if error message too, but I'm not sure what should go there. Can make another pull request later

It would be nice to change the if error message too, but I'm not sure what should go there. Can make another pull request later

I think also there is a bit of inconsistency now in modules, would be worth going back through thos at the same time


Read MIT Annotations

Reference issue (if any)
Fixes #12660.
What does this implement/fix?
Adds the ability to read WaveForm Database (wfdb) annotations using the already existing library. My proposed API adds two new parameters to mne.read_annotations() fmt and suffix. fmt and suffix are used in combination to read an annotation whose file suffix is not strictly defined.
If mne.annotations(fmt='wfbd'...) is called with no suffix, then the function will check to see if the suffix matches a default list of suffixes.
If mne.annotations(fmt='wfbd', suffix='seizures'...) is called, then the function will bypass the default list of suffixes.

Hi @drammock and @larsoner, I know you mentioned reading the annotations using a predefined list of suffixes in #12660, but I thought it would be useful to also allow for the option to read files using any suffix. Let me know if you prefer otherwise.

Do you know a good place for the suffix mappings @larsoner? The WFBD library mentions a few that I would also like to include besides .seisuzes.

Where is the best place to list the suffix mappings @larsoner?

Looks like the mapping currently lives here https://github.com/mne-tools/mne-python/blob/b38385ef90d0fd8214d54b15c5fd91333c3bc032/mne/annotations.py#L1203


gazebo demo fail

I am following the tutorial of turtlebot3.
running the simulation with cartographer.
roslaunch turtlebot3_gazebo turtlebot3_world.launch
and
roslaunch turtlebot3_slam turtlebot3_slam.launch slam_methods:=cartographer
The terminal outputs SUMMARY like parameters, nodes, bla bla bla then a FATAL
`ROS_MASTER_URI=http://localhost:11311
process[robot_state_publisher-1]: started with pid [30707]
process[move_base-2]: started with pid [30708]
process[cartographer_node-3]: started with pid [30710]
process[cartographer_occupancy_grid_node-4]: started with pid [30716]
process[flat_world_imu_node-5]: started with pid [30723]
process[rviz-6]: started with pid [30741]
[ INFO] [1580949011.982558804]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/turtlebot3_slam/config/turtlebot3_lds_2d.lua' for 'turtlebot3_lds_2d.lua'.
[ INFO] [1580949011.983794964]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/map_builder.lua' for 'map_builder.lua'.
[ INFO] [1580949011.984031932]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/map_builder.lua' for 'map_builder.lua'.
[ INFO] [1580949011.985031161]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/pose_graph.lua' for 'pose_graph.lua'.
[ INFO] [1580949011.987864916]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/pose_graph.lua' for 'pose_graph.lua'.
[ INFO] [1580949011.988713678]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder.lua' for 'trajectory_builder.lua'.
[ INFO] [1580949011.989251727]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder.lua' for 'trajectory_builder.lua'.
[ INFO] [1580949011.990035275]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder_2d.lua' for 'trajectory_builder_2d.lua'.
[ INFO] [1580949011.990485842]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder_2d.lua' for 'trajectory_builder_2d.lua'.
[ INFO] [1580949011.991215193]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder_3d.lua' for 'trajectory_builder_3d.lua'.
[ INFO] [1580949011.991636905]: I0206 00:30:11.000000 30710 configuration_file_resolver.cc:41] Found '/home/bingxin/catkin_ws/install_isolated/share/cartographer/configuration_files/trajectory_builder_3d.lua' for 'trajectory_builder_3d.lua'.
[ INFO] [1580949012.046640156]: I0206 00:30:12.000000 30710 submap_2d.cc:187] Added submap 1
[ INFO] [1580949012.047447874]: I0206 00:30:12.000000 30710 map_builder_bridge.cc:130] Added trajectory with ID '0'.
F0206 00:30:12.316486 30710 sensor_bridge.cc:126] Check failed: sensor_to_tracking->translation().norm() < 1e-5 The IMU frame must be colocated with the tracking frame. Transforming linear acceleration into the tracking frame will otherwise be imprecise.
[FATAL] [1580949012.317711049, 21.874000000]: F0206 00:30:12.000000 30710 sensor_bridge.cc:126] Check failed: sensor_to_tracking->translation().norm() < 1e-5 The IMU frame must be colocated with the tracking frame. Transforming linear acceleration into the tracking frame will otherwise be imprecise.
*** Check failure stack trace: ***
@     0x7f62702135cd  google::LogMessage::Fail()
@     0x7f6270215433  google::LogMessage::SendToLog()
@     0x7f627021315b  google::LogMessage::Flush()
@     0x7f6270215e1e  google::LogMessageFatal::~LogMessageFatal()
@           0x572142  cartographer_ros::SensorBridge::ToImuData()
@           0x54ad2e  cartographer_ros::Node::HandleImuMessage()
@           0x55a74e  boost::detail::function::void_function_obj_invoker1<>::invoke()
@           0x567e89  ros::SubscriptionCallbackHelperT<>::call()
@     0x7f626d6fed8d  ros::SubscriptionQueue::call()
@     0x7f626d6a4838  ros::CallbackQueue::callOneCB()
@     0x7f626d6a623b  ros::CallbackQueue::callAvailable()
@     0x7f626d702e39  ros::SingleThreadedSpinner::spin()
@     0x7f626d6e7e9b  ros::spin()
@           0x543974  cartographer_ros::(anonymous namespace)::Run()
@           0x541234  main
@     0x7f626c0f4830  __libc_start_main
@           0x543499  _start
@              (nil)  (unknown)
**[cartographer_node-3] process has died [pid 30710, exit code -6, cmd /home/bingxin/catkin_ws/install_isolated/lib/cartographer_ros/cartographer_node -configuration_directory /home/bingxin/catkin_ws/install_isolated/share/turtlebot3_slam/config -configuration_basename turtlebot3_lds_2d.lua /imu:=/flat_imu __name:=cartographer_node __log:=/home/bingxin/.ros/log/bf654fbc-4877-11ea-ac1d-000c296a6d1a/cartographer_node-3.log].
log file: /home/bingxin/.ros/log/bf654fbc-4877-11ea-ac1d-000c296a6d1a/cartographer_node-3*.log**
[ WARN] [1580949024.360317350, 26.861000000]: Timed out waiting for transform from base_footprint to map to become available before running costmap, tf error: canTransform: target_frame map does not exist.. canTransform returned after 0.1 timeout was 0.1.
I am new to the cartographer so totally have no idea what does is means.
Any ideas?
Thanks

solved
there was a bug on turtlebot3_lds_2d.lua


HTTP: Support for other operations

Currently the HTTP service only supports GET and HEAD. Are there plans to add support for POST and PUT. It would be great to be able to also send data, instead of only reading.

Most plain HTTP Serve doesn't define the POST and PUT behavior. Maybe you want to take a look over our webdav service?

@Xuanwo I will take a look. I was looking into using OpenDAL to replace some code running with aiohttp in Python. Still not sure if it's the the right tool though.

I was looking into using OpenDAL to replace some code running with aiohttp in Python.

Very happy to hear that! I'm willing to provide help for this!

@Xuanwo We were able to use HTTP/WebDAV to do GET/HEAD, one thing that was confusing is that these servives only support the AsyncOperator.
Another thing I noticed is that WebDAV is missing POST, even though it's mentioned in the RFC (https://datatracker.ietf.org/doc/html/rfc4918)

one thing that was confusing is that these services only support the AsyncOperator.

Yes. We depends on reqwest now and still seeking ways to support blocking operations.

Another thing I noticed is that WebDAV is missing POST,

OpenDAL is not a one-to-one mapping of storage services' API. Can you share more details on the operation you want to do over storage service? For POST on webdav, you want to create a new dir?

one thing that was confusing is that these services only support the AsyncOperator.

Yes. We depends on reqwest now and still seeking ways to support blocking operations.

That makes sense, it was only confusing at first since libs like Request let do blocking HTTP operations.

Another thing I noticed is that WebDAV is missing POST,

OpenDAL is not a one-to-one mapping of storage services' API. Can you share more details on the operation you want to do over storage service? For POST on webdav, you want to create a new dir?

I'm trying to upload files, the server has a POST route. I could add a PUT route because I manage the server code, but if it was a third party server, I wouldn't be able to POST data.
Another thing I want to try is Streaming Upload big files. Mainly so that they don't get loaded into memory. I noticed some of the methods support FilePath's but I havent tested if they get loaded into memory or streamed.
I currently to this with aiohttp using this: https://docs.aiohttp.org/en/stable/client_quickstart.html#streaming-uploads
Or with requests using this: https://docs.python-requests.org/en/v1.2.3/user/advanced/#streaming-uploads
Main difference being that requests is a blocking operation, while aiohttp doesn't block.

Another thing I want to try is Streaming Upload big files. Mainly so that they don't get loaded into memory. I noticed some of the methods support FilePath's but I havent tested if they get loaded into memory or streamed.

Thanks for pointing out! We are working on this now: https://github.com/apache/incubator-opendal/issues/2084. By adding sink support, we can upload a big file without reading all it's content into memory first. I'm hoping the new copy_from() API will address this.

Another thing I want to try is Streaming Upload big files. Mainly so that they don't get loaded into memory. I noticed some of the methods support FilePath's but I havent tested if they get loaded into memory or streamed.

Thanks for pointing out! We are working on this now: #2084. By adding sink support, we can upload a big file without reading all it's content into memory first. I'm hoping the new copy_from() API will address this.

Good to know, I will hold off testing streaming files for now.
Not sure if adding POST is in the timeline or out of scope for WebDAV

Not sure if adding POST is in the timeline or out of scope for WebDAV

There are many ways to upload a file via POST. Could you share the detailed method or service for posting it? OpenDAL is willing to add support for a service or API Specs (like webdav or Upload API).

Yes. We depends on reqwest now and still seeking ways to support blocking operations.

Maybe we can use block_on(async_op) to support blocking operations?

Maybe we can use block_on(async_op) to support blocking operations?

Yes, it's possible. However, the process is more complex as we also need to convert AsyncRead to Read.

I just have a custom REST server that supports uploading files.

Sorry, OpenDAL cannot be used in this case. It is designed to connect with storage services instead of a custom API that may not be general enough and could be difficult to work with accurately.

I just have a custom REST server that supports uploading files.

Sorry, OpenDAL cannot be used in this case. It is designed to connect with storage services instead of a custom API that may not be general enough and could be difficult to work with accurately.

How about adding a service named "REST", and having OpenDAL be able to do rest operations like GET, HEAD, PUT, POST, DELETE ?

How about adding a service named "REST", and having OpenDAL be able to do rest operations like GET, HEAD, PUT, POST, DELETE ?

Thanks for the advice. However, file uploading involves more than a simple POST or PUT. There are edge cases that need to be handled, such as:

Does this service support content-type?
What status code will the service return for successful operation?
What status code and error response will the service return for errors?

Therefore, OpenDAL can only connect with services that have clear API specifications covering all these details. We are willing to implement such a service if you need it.

How about adding a service named "REST", and having OpenDAL be able to do rest operations like GET, HEAD, PUT, POST, DELETE ?

Thanks for the advice. However, file uploading involves more than a simple POST or PUT. There are edge cases that need to be handled, such as:

Does this service support content-type?
What status code will the service return for successful operation?
What status code and error response will the service return for errors?

Therefore, OpenDAL can only connect with services that have clear API specifications covering all these details. We are willing to implement such a service if you need it.

i see what you mean, thanks for your help. I will close this as solved. For now aiohttp/requests work fine