Giving a custom name to an Autoloaded script will not let you print

Godot version
4.1 beta (any)
System information
Linux Mint 21.1 Cinnamon
Issue description
When you give an Autoloaded Script a custom name (using self.name), the IDE cannot decide what to do and won't print anything.
Replication success: 100%
Engine: Any (Compatibity, Mobile or Forward+)
Tested on: Godot 4.1 -> All beta versions
Related to: Autoload and Script name
Language: GDscript
Issue pushed away by: Removing the Autoload Script
Additional info: It might be weird, but the Autoloaded script won't run either, so you cannot just print anything, but the Autoloaded script itself won't work for me. I wouldn't be able to find the root of the issue inside the Godot's source code, so I suggest someone to look into it. I would appreciate it.
Steps to reproduce

Have an Autoloaded Script ready
Set the Script's name to any word inside an _enter_tree() function, using "self.name" -> for example: self.name = "example"
Have a Scene with any object in it and attach any Script in it, which is not Autoloaded
Write print("example") function inside _ready(), _process(delta) or _physics_process(delta) function
Run the Scene with the attached Script in it
See the results. You should be able to see "example" once, or every frame, however following these steps, it'll not be the case. It should print nothing at all.

Minimal reproduction project
Test Project.zip

Related to/duplicate: #77610

There's issues at the moment with setting the name of things at certain times, see there for details


Malformed Rewrite Rule when building PenguinGraphs

Description

Compiler about when compiling PenguinGraphs: https://github.com/saeta/penguin
Steps to reproduce

Clone repo
swift test on the latest trunk toolchain
Get the following crash:

Building for debugging...
&&& Malformed rewrite rule: τ_0_0._Storage.[Sequence:Element].[_AdjacencyListPerVertex:EdgeData].[_AdjacencyListPerEdge:VertexId] => τ_0_0.[DirectedAdjacencyListProtocol:RawId]
&&& symbol.getKind() != Symbol::Kind::Name

...

1.	Apple Swift version 5.8-dev (LLVM 767c0998bcfdab1, Swift 1f3397ac116fada)
2.	Compiling with the current language version
3.	While evaluating request TypeCheckSourceFileRequest(source_file "/Users/proffan/Projects/Development/VISION/SwiftFusion/penguin/Sources/PenguinGraphs/AdjacencyList.swift")
4.	While type-checking 'DirectedAdjacencyListProtocol' (at /Users/proffan/Projects/Development/VISION/SwiftFusion/penguin/Sources/PenguinGraphs/AdjacencyList.swift:212:8)
5.	While evaluating request RequirementRequest(PenguinGraphs.(file).DirectedAdjacencyListProtocol@/Users/proffan/Projects/Development/VISION/SwiftFusion/penguin/Sources/PenguinGraphs/AdjacencyList.swift:212:17, 0, interface)
6.	While evaluating request ResolveTypeRequest(while resolving type , _AdjacencyList_DirectedVertexEdgeCollection<_EdgeData>, (null))
7.	While building rewrite system for generic signature <τ_0_0 where τ_0_0 : DirectedAdjacencyListProtocol>

Full crash: https://gist.github.com/ProfFan/1dd2c15b57d0558934ba97f9a7674367
Expected behavior

Compiles or emit error message.

Environment

Apple Swift version 5.8-dev (LLVM 767c0998bcfdab1, Swift 1f3397ac116fada)
Xcode version  14C18
Deployment target: macOS 13.0

tagging @BradLarson


dataview example with user roles

Thank you for MK. Really enjoying it. I want to use the dataview example but add user roles such that an admin can edit and delete customer fields but other users can only toggle the "Active" field in their accounts. The data will be loaded once at startup. What do I need to add to the json file to make this happen? (I have successfully added user accounts but they are not interacting with the data.)

Lance, you need application with user account system. Maybe to merge
example-admin with example-dataview. Copy collections array from dataview
example and pages array from dataview into public_zone. Let me know how
goes it.
On Jun 13, 2015 01:32, "Lance Barker"<EMAIL_ADDRESS>wrote:

Thank you for MK. Really enjoying it. I want to use the dataview example
but add user roles such that an admin can edit and delete customer fields
but other users can only toggle the "Active" field in their accounts. The
data will be loaded once at startup. What do I need to add to the json file
to make this happen?
—
Reply to this email directly or view it on GitHub
https://github.com/perak/kitchen-site/issues/110.

Petar, I'm back and still stuck with this.  Here is what I've done so far:
https://github.com/lancefb/TestAdmin
I want the admin to be able to add new users and edit the database example, and the normal users to be able to view the database but only modify part of the database (click on and off Active, in this case).
Thanks so much for this.

Hey dude, I answered (made pull request with comments to your https://github.com/lancefb/TestAdmin repository). Closing this issue here.

Dude!  You're the best!
L.
On Fri, Jul 17, 2015 at 3:14 PM, Petar Korponaić<EMAIL_ADDRESS>wrote:

Hey dude, I answered (made pull request with comments to your
https://github.com/lancefb/TestAdmin repository). Closing this issue here.
—
Reply to this email directly or view it on GitHub
https://github.com/perak/kitchen-site/issues/110#issuecomment-122432525.


Maintain "history" on state update

I've noticed that anytime the state is updated, regardless of the property, the undo/redo history is lost. Is there a way to prevent this?

Hi @jamesckemp
what do you mean by state? Can you share any scenario that I can take to replicate the issue?

Hey, take this for example:
https://codepen.io/jamesckemp/pen/PQQeVN?editors=0010
Every 2 seconds some new data is added to the table. If you update any data while this process is happening, as soon as more data is loaded in, the undo/redo abilities are lost.
If you wait until the end (31 rows) and then start modifying data, undo/redo works again.
Does that make sense?

Thank you, now it's clear. I got the same result and you're right that it can be a problem. Especially when you build an app with multiple-user access.
I have checked a similar scenario with Vanilla version at http://jsfiddle.net/8zj86Lrk/ but you've used setTimeout and I took setInterval which allowed me (as a user) to perform additional steps while the script is running on the background.

Just to clarify - it doesn't matter what part of the state I update, it'll wipe the undo/redo history. Take this for example:
https://codepen.io/jamesckemp/pen/ZrrRPN?editors=0010
You can make changes and undo/redo them with no issues. But make some changes, then click the "Update State" button and all of the undo/redo history is lost.
The state in this example has nothing to do with the table data that is displayed.

Hi @jamesckemp
sorry for keeping you waiting. I have asked one of our developers to investigate this case.
Can you check this demo https://codepen.io/handsoncode/pen/bLMKpp?editors=0010
It has been updated to by the settings to block history erasement.

Hey,
I'm afraid that made no difference. To further explain the issue I have added an undo button to the pen, and attached a gif of the undo working, then not working after updating the state (using the pen you just provided)
https://codepen.io/jamesckemp/pen/RQJgOZ?editors=0010

I hope that these time we can fix it, but feel free to let me know if still, something is missing.
So the demo with state does work https://codepen.io/handsoncode/pen/gvKGbJ?editors=0010 but without the actualization, undoRedo works https://codepen.io/handsoncode/pen/gvKGbJ?editors=0010
and here https://codepen.io/handsoncode/pen/gvKGbJ?editors=0010 and https://codepen.io/handsoncode/pen/MQXrra?editors=0010 it looks like the setState is cleaning the undo history (the doneAction and undoneActions are empty)

I think a problem i see, as far as i understand, is that the moment you update state, it basically re renders the whole grid, so its losing everything it had, including its history.

@coljung That's right!
@AMBudnik I'm not seeing a solution based on what you provided there - have I missed something?

Yes, but there is no way (currently) to rerender only the changed cell.
We are planning to change that but the project may take a month or more and it is planned to start in March/April.


fix: sanitize <TradeAmountInput /> precision

Description
This PR ensures:

crypto inputs properly honor their asset precision as a maximum allowed dp
percent option change doesn't result in input amounts with dp greater than their asset's precision
Tested in:

[x] RFOX
[x] DeFi PairDeposit (e.g UNI-V2)
[x] DeFi Deposit (e.g Cosmos, THORChain savers)
[x] DeFi Withdraw (e.g ETH/FOX)
[x] Savers
[x] Send details
[x] Lending
[x] THORChain LP

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/7125

Risk

High Risk PRs Require 2 approvals

Low, mostly related to fiat amounts and send modal without initial asset selection

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Send Modal

Amount input is still happy on dashboard send click (no need to broadcast the Tx, only verify that amount input is still happy)
QR code scanning which prompts for asset selection (e.g ETH receive) is still happy - same thing here, no need to test until broadcast, only ensuring amount input is happy

Amount Withdraws
Test in:
- RFOX
- Savers
- THOR Lending
- THOR LP
- DeFi PairDeposit (e.g UNI-V2)
- DeFi Deposit (e.g Cosmos, THORChain savers)
- DeFi Withdraw
- Send details amount input
For each of these, ensure that:

Percent option click doesn't result in an amount with more decimal places than the asset's precision (e.g 8 for BTC, 6 for USDC and ATOM, 18 for ETH)
Amount inputs do not allow entering an amount with more decimal places than the asset's precision
Toggling fiat does not produce any input regression

Engineering

^

Operations

^

Screenshots (if applicable)
Tested against develop (right)

Amount input is still happy on dashboard send click

https://jam.dev/c/aca1f59b-da64-4278-857d-aa80595ee17c

QR code scanning which prompts for asset selection (e.g ETH receive) is still happy

RFOX

DeFi PairDeposit (UNI-V2)

DeFi Withdraw (ETH/FOX)

DeFi Deposit (THORChain savers)

THOR Lending

THOR LP

Send details

Testing

[x] RFOX
[x] Savers
[x] THOR Lending
[x] THOR LP
[x] DeFi PairDeposit (e.g UNI-V2)
[x] DeFi Deposit (e.g Cosmos, THORChain savers)
[x] Send details amount input

Send
Doesn't allow to enter more than 18 decimals for ETH

Doesn't allow to enter more than 6 decimals for USDC

rFOX

Probably unrelated to the PR but switching to fiat is chaning the FOX amount which feels weird but can't probably be changed due to fiat precision:

Unstake is happy with 18 precisions

Savers
BTC:

Happy and fiat switch happy too, 8 precisions
ETHEREUM:

18 precisions, fiat switch happy
Thor lending
BTC:

Can't test repay as I don't have any amounts
ETH:

Same for repay
Thor LP

Both BTC and RUNE are happy with max 8 precisions
ETH+RUNE

Both are happy, ETH accepts 18 precisions while rune is stuck at 8, fiat switch ok
Defi pair deposit univ2
Deposit

Withdraw

Defi deposit

Fiat switch happy too with 6 precisions


Reuse HttpClient

Reason: https://aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/
Readme: Follow the CommonMark spec
These changes are untested, since I don't have an API key.

Looking good, thanks a lot! 👌


Determining which builds to run

So I’ve been thinking about how we should determine which builds to run for every package. It’s complicated, because swift build will only work for pure Swift packages with no dependencies on Apple platforms.
If we’re using a successful swift build result to determine Swift version compatibility, we can’t know that compatibility unless we also understand what platforms that package requires.
I think I’ve come up with the logic that’ll work though:

We determine the Swift tools version declared in the manifest. (By running swift package tools-version)
We look for the platforms key in the manifest. This key is reasonably widely supported (much more so than swiftLanguageVersions).
Before we determine Swift version compatibility, we first need to determine platform compatibility by:

If the platforms key exists, run swift build using the version of Swift specified in the tools version for each platform specified in the platforms. (See note below on excluding platforms).
If the platforms key does not exist, run swift build for  all four (or five, if we include a version of linux).

Store platform compatibility in our database.
Then, for one of the supported platforms, determine Swift version compatibility. (See note below on which platform)

Run swift build with the relevant platform flags on each version of Swift that we want to determine compatibility with.

Store swift version compatibility in our database, and maybe associate which platform it was tested on as well. It would be interesting to tell people what versions.

OR…
We just build up a full matrix of Swift versions and platform versions and run builds across all combinations. The logic for gathering the data is much simpler, obviously with much more building to do. But the trade off might be worth it in simplicity.
Of course, the logic for displaying version information becomes a little more complex with this method, but I think it might still be simpler than the first option overall.

Note:

If the platforms key is specified, and Apple platforms are excluded from it we should take that as a sign that the package author does not desire compatibility with that platform. It may, or may not work, but we should declare it as incompatible.

Note:

If we see a tools version change in the manifest, we should wipe all stored build data for that package and start again.

Note:

In terms of which platform to choose for Swift version compatibility, they should be prioritised. If iOS is supported, use iOS. Then macOS, then watchOS and tvOS in that order.

Finally, how do we actually build the platform versions?
Two options:

xcodebuild.
swift build with extra parameters to specify SDK locations.

This works for building an iOS version:
swift test -Xswiftc "-sdk" -Xswiftc "`xcrun --sdk iphonesimulator --show-sdk-path`" -Xswiftc "-target" -Xswiftc "x86_64-apple-ios13.0-simulator"

That only uses xcrun to report the location of the platform SDK does not run xcodebuild. Of course, if we want to run with multiple platform SDKs then we need them installed, which I believe is possible.

Also... 😬

I've just run some test builds with Gala on macOS 10.15 and I think this will work.
swift build

seems to be have the same as
swift build -Xswiftc "-sdk" -Xswiftc (xcrun --sdk macosx --show-sdk-path) -Xswiftc "-target" -Xswiftc "x86_64-apple-macosx10.15"

and I can target other platforms as described above, with iphonesimulator, and appletvsimulator. What doesn't appear to work is the watch sdk:
sas@Ceres  ~/D/Gala  ⎇ main  swift build -Xswiftc "-sdk" -Xswiftc (xcrun --sdk watchsimulator --show-sdk-path) -Xswiftc "-target" -Xswiftc "x86_64-apple-tvos13.0-simulator"
<unknown>:0: error: Swift does not support the SDK 'WatchSimulator6.2.sdk'

I guess we can live with that for now.
The -target parameter will allow us to crawl over the platform versions. One thing to figure out is how to get them onto the runners but I believe this is a simple download in Xcode settings - at least for iOS. I'm not so sure about macOS.

NB: yes, the target doesn't match on the watchos build but I don't think that matters in this case. When I mixed this in other cases to test behaviour the error was specific to the target.

One thing to figure out is how to get them onto the runners

Get what onto the runners? The SDKs should all be pre-installed

I've been plauing with this and I also couldn't get it working with a watchOS target. However, I just tried with the Xcode 12 beta and it worked like a charm!
swift build -Xswiftc "-sdk" -Xswiftc "`xcrun --sdk watchsimulator --show-sdk-path`" -Xswiftc "-target" -Xswiftc "x86_64-apple-watchos7.0-simulator"

Works great 👍

Ah, that's great! I was hoping it's just due to watchOS being a bit behind the rest.
Re: the runners: I'm referring to getting additional SDKs on the machine or updating to new ones. For instance, iOS, tvOS, watchOS are simple enough to do via Xcode (although CLI would be nice):

but I'm not sure about macOS. Would be need to bump the whole OS to get new SDKs? Can we copy them from another machine? How about past versions? Ceres only has 10.15 and I'm wondering how to get 10.13 etc for building against those.

Heh, internet FTW https://github.com/phracker/MacOSX-SDKs

Do we want to get into compiling with different versions of the SDK? That matrix is going to be 4 dimensional. Or, do we just use the SDK based on the platforms key in the manifest?

I thought we wanted to probe if there's a platform cutoff at some point? Something like this, to find the earliest supported version:
for sdk in "10.11 10.12 ..." ; do
   build.sh $sdk
done

Starting with the oldest one, because they'll fail fast and we can stop once we have the first success.

The problem with that is that we're testing with different SDKs there, which gives no guarantee of the platform required when executing the code on a device.
For example, Apple usually requires everyone to compile with the latest SDK (for the App Store) at least, a few months after the first final release of that version. But with that latest SDK, you can still support platforms many versions prior to that.
I think all we'd be testing here is SDK support, not platform support.

This may be a bad idea after all: https://swiftpm.slack.com/archives/C14QU6CUU/p1591533004419300

Ankit proposes an alternative which I’ll check now.

Closing. Obsolete as we are processing the entire matrix.


Fix SelectedValueBinding with items defined in XAML

What does the pull request do?
As described in #11220, there was a problem with SelectingItemsControl.SelectedValueBinding and null values. This PR simply removes the check for a non-null value in BindingHelper.Evaluate as the binding system handles them fine.
Fixed issues
Fixes #11220

You can test this PR using the following package version. 11.0.999-cibuild0037724-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Do not use bind with a maybe macro

After https://github.com/bazelbuild/bazel/commit/c7e391cc422d9069e6cbf24a09807638d352c4b0, Bazel interprets the actual parameter of a bind call in the context of the repo where it happens.
Unfortunately, this means that wrapping native.bind in a maybe macro loaded from @bazel_tools causes the actual parameter to be interpreted in @bazel_tools's context, which is obviously wrong.
This is amazingly hard to fix at the root and is more evidence that bind needs to go.
Fixes https://github.com/kythe/kythe/issues/5921.

/gcbrun


main instructions don't cover dual IP stack

Following the instructions at https://github.com/cri-o/packaging/blob/main/README.md#distributions-using-deb-packages works for an IPv4-only configuration, but isn't the best for dual-stack, according to the more general configuration instructions. Reference to those instructions should be made, like as found at https://github.com/cri-o/cri-o/blob/main/install.md#setup-cni-networking, so that dual-stack users get the correct setup.
Specifically, the deb package includes /etc/cni/net/11-crio-ipv4-bridge.conflist, but not 10-crio-bridge.conflist. It might be nice to include the latter into /etc/cni/net/, perhaps in some disabled state, non-included file name, etc.

It also seems like the documentation would benefit from pointing out that these particular subnets (<IP_ADDRESS>/16, 1100:200::/24) are being used on the CNI bridge, to prevent conflict with CIDRs being used in the host or cluster spaces. (I guess no one should be using 1100:200::/24.)

Hey, we switched to the dual stack config 2 weeks ago in https://github.com/cri-o/packaging/pull/197. The next set of patches should have them or you use one of the pre release streams, which require the fix from  https://github.com/cri-o/packaging/pull/198

@performantdata the latest prerelease streams should have the dualstack change now.


This is going to require publishing some beta versions to test unfortunately >.<

Fantastic :sparkling_heart:


implementation of has_ipv4, has_any_ipv4, has_ipv4_prefix, and has_an…

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added Kusto functions has_ipv4(), has_any_ipv4(), has_ipv4_prefix(), and has_any_ipv4_prefix()

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@bemitc in general, I think you could have more interesting functional tests. Feel free to experiment with edge cases (eg. empty strings, near-miss cases like '<IP_ADDRESS>1' or '127.0.0.a') and try to break your own implementation as much as you can. For starters, you could always include any test cases that the KQL specification of a given function contains.
I think you could also use just a single functional test case file, since the functions you are implementing are very much related and could benefit from the same test data. If you'd prefer to split it into multiple files though, that's also fine, just make sure to use the 02366_kql prefix as @kashwy also mentioned.

@ltrk2 can you verify ? if all good , please re-base and merge. thanks

@kashwy sure, I'll take a look and discuss any remaining items with @bemitc.


#249: Long posts should have the see more feature

Description

This PR solves issue #249

Long posts take a lot of space on the screen, sometimes a lot of scrolling as well

Implementation

Added a feature to expand or truncate post content.
Created a state variable isContentExpanded and toggleExpandedContent  function to manage content expansion.
Updated the UI to show  "See more" / "See less" on the same line if the content is too long.
Added logic to handle truncation and toggling when content exceeds 200 characters.

Screenshots

JM! This is ready for review!


RHIDP-3084: Document RHDH theme customizations

Version(s):
1.2.2
Issue:
https://issues.redhat.com/browse/RHIDP-3084
https://issues.redhat.com/browse/RHIDP-3319
Link to docs preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-389/getting-started-rhdh/#assembly-customize-rhdh-theme
Reviews:

[ ] SME: @jerolimov
[ ] QE: TBD
[ ] Docs: TBD

@jerolimov Thanks for your thoughts  and feedback.

Since we have default themes available that can be used as-is, slightly customized, or totally changed, it makes sense to me to introduce the default configurations first, but I will consider reorganizing some of these sections to prioritize the elements that users are most likely to want to change.

You caught a metadata issue - there is supposed to be a heading above You can customize the header color that makes it a separate section; that has been fixed.

We say You can change or disable particular parameters in a default theme or create a fully customized theme by modifying the app-config-rhdh.yaml file. in three different places, including the chapter intro. Do we need to change the language to clarify this statement or put it in even more places in the doc?

We mention app-config-rhdh.yaml 32 times in the GS guide and app-config.yaml 11 times. I am not sure what is correct, but will confirm with another SME and update accordingly.

Both of those are existing content files and changing existing content is not part of the scope of this PR, but it looks like a quick fix, so I will go ahead and make that change.

@jerolimov thank you! I agree with your feedback on the existing content and will create a separate PR to apply it.

/cherrypick 1.2.x


dbt 'info' command

We've been discussing the ability to provide certain information from the rpc server about the current project. Since the rpc server runs on dbt commands, it would need a command line command to provide this information.
An 'info' command could provide lists of macro names, lists of test names, and information about files in the project. Performance would probably not be acceptable until after the partial parsing improvement work is finished, but implementation would not need to wait until then.
It could set the 'partial parse' flag by default, but then we'd probably need a '--no-partial-parse' flag, so it might not be worth the confusion.
Initially at least the information could only be provided from a successful parsing run, so if the dbt user is in the middle of development some things might be outdated.

We're definitely going to accomplish this by other means. Tthe next-gen dbt Server will have to have flexible entrypoints into manifest information (project context) and core classes/objects ("language" context)


Xiaomi Gateway: Allow static configuration of a gateway without discovery

Description:
A few people using hassio are unable to discover the local xiaomi gateway. Depending on the setup and/or infrastructure the multicast broadcast needed for discovery cannot be received at the docker container. This does not affect every docker setup.
This feature introduces an optional host parameter for a static configuration of the gateway.
Pull request in home-assistant.github.io with documentation (if applicable): TBD.
Example entry for configuration.yaml (if applicable):
xiaomi_aqara:
  gateways:
    - mac: 34ceeeeeeeee
      key: fasdfasdfasdfasd
      host: <IP_ADDRESS>
      port: 9898
    - mac: 34ceffffffff
      key: asdfasdfasdfasdf
      host: <IP_ADDRESS>
    - mac: 34ceddddddddd
      key: sdfasdfasdfasdfa

@Danielhiversen I would be happy about a review.


[MODINVOICE-240] Testing vendor address is added to batched vouchers

MODINVOICE-240
Checking vendor primary address is added to batched vouchers.


Max & Min page size feature

The configuration in zf-rest features a custom page size set on the client side. Then I think it would also be useful to be able to set a valid range for the page size. If there are a lot of records in the database the client can still overload the server by demanding a huge (undesirable) page size in the request.
The proposed solution is to allow configuration for minimum and maximum page sizes in the controller config like this:
'min_page_size' => 5,
'page_size' => 10,
'max_page_size' => 20,
'page_size_param' => 'page_size',

So if the client sends a request with http:api/v1/example.com/collection?page_size=1 or http:api/v1/example.com/collection?page_size=10000 there will be an ApiProblem response saying that the page size is out of range. Like this we have better control over our server load.
note: Renaming the page_size parameter to default_page_size could be desirable.

I added two tests to the existing RestControllerTest:
https://github.com/zfcampus/zf-rest/pull/57
Hopefully this is sufficient.
Best regards,
Wouter

@Wilt If you cherry pick your tests into this branch then push the branch again the tests will show up on this PR

I merged both this and #57 in one go, and fixed the CS issues.
BTW, @Wilt -- love the avatar -- huge fan of Foster's!


Fix popover position for payment buttons

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/26070
PROPOSAL: https://github.com/Expensify/App/issues/26070#issuecomment-1705678038
Tests

You can test this using 2 of your accounts or you can also create a new workspace with only 1 member (logged in user) and request money. As you are the only member, request money button will be visible.

Use 2 of your accounts for testing. Login with account 1, request money in the chat by going to chat with account 2 > click on + button > Request money > Enter details and click on request money button. Afterwards login with account 2 and follow the steps below -

In the chat, click the pay button in Report Preview. The popover should open above the button.
See screenshot to see what it should look like.

Now, click on the report preview and in the header try clicking on the caret (dropdown icon) and the main button and make sure both popovers open below the button.
See video to see what it should look like.

https://github.com/Expensify/App/assets/31413407/3bba69f1-c598-499d-85b4-7ff467fa7ac3

Now, go to settings > wallet. Click on transfer balance and verify that the popover opens below the transfer balance button.
See video to see what it should look like.

https://github.com/Expensify/App/assets/31413407/3cb3326d-3a71-4d16-9db8-c95f703bfbae

[x] Verify that no errors appear in the JS console

Offline tests

Same as above.
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/31413407/401d98bb-ef78-4e5b-810d-8990967e8709

Mobile Web - Chrome
https://github.com/Expensify/App/assets/31413407/f58ee93e-8d98-4c80-bfdd-331a6db965b7

Mobile Web - Safari
https://github.com/Expensify/App/assets/31413407/5cde65c2-118d-4633-8edd-a178ebcf8a00

Desktop
https://github.com/Expensify/App/assets/31413407/30d2128d-d1e8-48da-aec3-78225d391d57

iOS
https://github.com/Expensify/App/assets/31413407/91ed0b79-e3f6-4e2c-8259-5afdd7371e92

Android
https://github.com/Expensify/App/assets/31413407/6ec0f875-749f-444e-bfff-f921aebf2d0e

LGTM, thanks guys!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@marcochavezf @aimane-chnaif Step 4 is failing. We have silver wallet accounts only. I remember it requires gold wallet for "transfer balance" to appear. Could you confirm?

@aimane-chnaif , this will be validated internally?

Click on transfer balance and verify that the popover opens below the transfer balance button.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Parameterize sample name

https://github.com/genome/analysis-workflows/blob/a3e26136043c03192c38c335316d2d36e3e67478/definitions/pipelines/immuno.cwl#L741
All files in this workflow should be modified to allow specifying sample names; currently they are hardcoded in multiple places as just 'TUMOR' and 'NORMAL'

@johnegarza is this still an issue, or has it been fixed in the latest and greatest?


Update v7 to Node.js 20

Hi, we are still using v7. We will appreciate if v7 branch is updated to latest Node.js 20 to avoid disruption of our build actions.
Thanks.

@magnesj yes, could you please try using and report back: run-vcpkg@dev/node20-v7.

Thanks for the quick response, appreciate it.
The fix works as expected, now with no warnings.
https://github.com/OPM/ResInsight/actions/runs/8324185531

@magnesj thanks, I released a v7.6 from run-vcpkg@v7 : https://github.com/lukka/run-vcpkg/releases/tag/v7.6

Thank you so much.


Combining multiple columns while keeping the column headers

It would be great with a possibility to combine the values of multiple consecutive columns into a single column, while keeping the column headers and sorting options. For example, names are easier to read when being displayed like {Firstname} {Surname} in one column, rather than being in two columns. But by combining the values, you miss the possibility to sort by both Firstname and by Surname in DataTables.
My request is that, through some smart initialization options, DataTables could render a table with separate information in each column:

      Firstname
      Surname

      Donna
      Summer

      Quincy
      Jones

as a table where the information from multiple columns are combined in a single column:

      Firstname
      Surname

      Donna Summer

      Quincy Jones

In other words, DataTables should render the two columns into a colspan="2"-column for the rows in
 but not in
.
In the above example, the table could then be ordered by Firstname, where Donna Summer would come before Quincy Jones, while ordering by Surname, would show Quincy Jones before Donna Summer.

Its a really nice idea - thanks! However, colspan and rowspan are not supported in the table body at this time and to be honest, I can't see that chance any time in the short or medium term. That would be required for this to work, so I'm afraid I don't think this is likely to happen.

I would like to +1 this.
Maybe there is a way to do away with colspans by using a single cell to display the firstname and surname and have 2 sorting options in the header that somehow are 'intelligent' enough to sort on either first or surname when clicked?
Just thinking out loud.


Android version is not available on HUAWEI Harmony OS phones.

Android version is not available on HUAWEI Harmony OS phones. Is it possible to support HarmonyOS?

@OriWang Do you wanna to try downloading the APK from here and see if you are able to install it on your HarmonyOS device?


fix: Add LOGDNA_REDACT_REGEX to redact secret values from logs

Description
Add LOGDNA_REDACT_REGEX to redact secret values from logs
Here is the result:

Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[x] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] The PR references a GitHub issue.
[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

Failing due to known bug with CRA (CRA fix coming today I am told)

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve usability of the Koans

Motivation

Get koans into a state where programmers can quickly jump into them during a workshop environment (where messing around with installation is not desirable).
Provide hints around hot-reloading not being present as this is a common feature of koan repos
Remove elm-test as an option since it can confuse rather than assist.

We use privileged on the docker container to workaround SELinux issues.
Download packages outside of reactor (saw an issue that required 2 refreshes on some machines).

Some discourse over at https://github.com/craigjbass/elm-koans/pull/1#discussion_r173308574

Hello @craigjbass! Sorry for letting this PR sit for so long without a response. Unfortunately, the Koans have been upgraded to 0.19 in the meantime.
I think the point about reloading is a good one. I may look in to suggesting elm-live or something similar as a better experience.
I wouldn't be against Docker as an option, but I wouldn't want it to be the only option.
Thank you again for the PR! If you want to reopen with an updated Dockerfile I won't let it sit so long again.


[1.33.0-beta1] Typing "#" is currently broken in the beta

In 1.32.0, Typing # within double quotes would just enter #. Now, it does more than that, and for some reason inserts #{} with the cursor moved between the {} instead. This is mildly infuriating when trying to write out an expression like so:
eprintln!("{:#?}", value);

@mmstick I tried it just now in a new blank file, but could not reproduce. Please fill out the issue template that is given when creating an issue completely, so we know what steps to follow.

@mmstick For now, you can work around it by toggling Settings -> Core -> Use Tree Sitter Parsers, or alternatively disable the bracket-matcher package.

Wow, that's awful. It looks like a features associated with Ruby, that's happening all the time for some reason.

@maxbrunsfeldSee this

Oh yeah, of course; the bracket-matcher has all of this language-specific stuff baked into it. I want to make bracket-matching work completely differently now that we have Tree-sitter, but haven't had the chance yet. I'll just fix this by keeping with the "bunch of hard-coded languages" approach in bracket-matcher.

@Aerijo It's happening for me with Rust files.

I can reproduce that in ver. 1.32.1 too, with Javascript files (for example writing a css selector like #my-element produces #{my-element}).
Disabling bracket-matcher plugin alone doesn't seem to do the trick, while disabling the Tree Sitter Parsers restores the desired behavior.

This fix will go out in 132.2 and 1.33.0-beta2.

Just installed the update, and this issue is fixed. Thank you!


Update and improvement in README

CONTRIBUTING.md

Aggregation to the word 'issues-bug' the link to the Issues with 'Bug' label
Improvement of the format

Moving 'Contributing.md' from the main directory to the '.github/' folder
README.md

Image of the focused logo
Badges centered.
Division of the text in new sections
Aggregation of the section :

'License'
'Contributing'
'Social media'

'Mailing Lists'

Creation of '.github / code_of_conduct.md'

@nicolasalarconrapela For the code of conduct page, see my proposal on the ComDev mailing list

For the README, consider these guidelines:

Keep it minimal; only show basics, and defer to the project website for more
Keep it readable in both plain text Markdown and in the Markdown-rendered HTML
Make it look nice on GitHub, with badges, but don't go overboard so that it hurts plain text readability
Use footnote links instead of inline links so that the reader doesn't have to interrupt reading to view a URL
Don't use relative links to files not present in the tarball distribution
Don't use links to resources whose address is likely to change
Don't link to the source code repository
Avoid emojis, unnecessary graphics, and unnecessary special characters

I see fit that these guidelines should be saved or mentioned somewhere in case some other user decides to modify the README.

I see fit that these guidelines should be saved or mentioned somewhere in case some other user decides to modify the README.

To be clear, these aren't official guidelines. All of these are subject to change, based on future community decisions. Nothing is set in stone, and we don't want these to be set in stone. We certainly don't want to have more documentation about how to maintain the README than the actual content contained within it. These are just my attempt to compile and share a list of relevant concepts from a decade of project history, in order to help guide you. Others in the community may have different opinions, values, and suggestions to offer.


Running init.sh in the root directory will prevent the priompt package from using the up-to-dated tiktoken_node lib

After running init.sh the priompt package cannot be built due to napi cannot find the up-to-dated tiktoken_node lib.
Reproduce
./init.sh
cd priompt && pnpm build

Rationale
init.sh would make the root dir to be the cargo workspace root, which would cause the libanysphere_tiktoken_node.so and libanysphere_tiktoken_node.so files to be built in the target folder of the root directory.

Thanks for reporting! I believe this is fixed now, but please re-open if you're still seeing this.


Invalidate a query when using router.query

How do we invalidate a query when using router.query
router.query is not accepting queryKey as parameter, it is accepting queryHash, but when using queryHash as value to
queryClient.invalidateQueries
it is not making the API call again.
Please help

is this?
queryClient.invalidateQueries({
      queryKey: post.byId.getKey(),
 })

yes @liaoliao666 . This did not work

can you show me a reproduce example?

This is my router query
getRoadmapCards: router.query({
    fetcher: () => axios.get(`${pubUrl}/pub/api/task-board/cards`, { withCredentials: true }),
  }),

And i am trying to invalidate it using
queryClient.invalidateQueries({
      queryKey: roadmapCardsApis.getRoadmapCards.getKey(),
    })

Seems it is no problem, maybe you should inspect your code. or provide a codesanbox example to me.


Add Reddit API class and Direct API functionality

Add a class which uses the reddit API[1] rather than Parsing the comments from the web. This will be added for both the user and listing functions. The API paths are as follow:

GET /user/username/comments
GET [/r/subreddit]/comments/article

Requirements:

Add CLI option to choose between Scraper and Reddit-API
Add way of using OAuth2 Credentials (ENV variables)
Add Oauth Documentation[2]

[1] https://www.reddit.com/dev/api/
[2] https://github.com/reddit-archive/reddit/wiki/OAuth2

Added in 2.0 Commit. Need to add Unit Tests as well before a release can be made. See https://github.com/diazjf/reddit-sentiment-analyzer/commit/703dc71709d943957dd8e1d0652a38327a5f63ef

Taking different direction after refactor.


fix : changed Path3D first normal discovery to get a more human expected behavior

To solve this question : http://www.html5gamedevs.com/topic/14475-unexpected-rotation-when-using-extrusion/ in a more human expectation.
If no direction vector given as parameter, the Path3D computes its first normal by itself, searching for intersections with world axis.
The search order is now changed so it fits the BJS rotation axis order (y, x, z) so the path3D behavior seems more coherent to human head movements.

thank you
and congratulation for your new commiter function ! :-D


Fix Longhorn volumes degraded state

Adding a worker node resolved this: https://github.com/heywoodlh/flakes/commit/a220a5e1b635f30daddafb74d7275ac7f992dc64


Xclim not using np.random.seed

Setup Information

Xclim version: 0.41.0
Python version:. 3.9.15
Operating System: Ubuntu 18

Context
We upgraded from xclim 0.24.0 to 0.41.0 and now suddenly I am seeing failing tests with data has been freshly generated. We were fixing the random seed with np.random.seed(42) before my suspicion is that that's not working anymore?
We are using the QuantileDeltaMapping in our test and I assume that the randomness is introduced there?
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi again,
QuantileDeltaMapping should not depend on randomness itself. Are you using functions like jitter_under_thresh ?
In our tests, we try to get away from needing to fix the random seed as it is not very resilient and also seems to be not recommended by numpy. But I also don't remember using np.random.seed in sdba testing...
Finally, maybe the change comes from packages upstream of xclim ? Changes in dask? numpy ?

Ok turns out the problem was coming from somewhere else. Closing


SEA Upgrade: Run full regression test after upgrade

Describe the issue
Execute the test plan in CPFScrumTeam/QA/Test Plan/
Additional context
Add any other context, attachments or screenshots
Acceptance Criteria

A report (or collection of reports) with found problems (in the same folder as above)
A report indicating the differences between the current SEA version and the previous version (Note: some of the changes may be expected or by design, not due to bugs)

Test plan executed and completed for Forge and Assembly
Upgrade has not been deployed yet in Live. This task is covered by #2156


validate routing uuid and active node id to avoid 500 error

Before

After

All checks have passed 🎉 @TomasVotruba I am merging it ;)


⚠ Thumbnails API Endpoint has degraded performance

In c20ea30, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1379 ms

Resolved: Thumbnails API Endpoint performance has improved in 8c2f92e after 26 minutes.


added ceph url in resource.json

This should also make it possible to work with an offline repository containing the cephs packages.

@ryadav88 this looks good to me


Fixed hard-coded bib files in templates

The bibliography filename papers.bib is hard coded in templates, and the equivalent setting in _config.yml is not used anywhere. So changing the bib filename in _config.yml won't have any effects.
This PR replaces hard-coded filenames with the value from _config.yml.

Lgtm. Thanks for the contribution.


add inference case for bloom and update readme

Signed-off-by: Wang, Yi A<EMAIL_ADDRESS>Type of Change
feature or bug fix or documentation or others
API changed or not
Description
detail description
JIRA ticket: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

@hshen14 @yao-matrix


Several fixes to CodeMirror event registration

Fixed problem with the chord display only keeping track of one CodeMirror instance.
Previously, chords would only be tracked in one CodeMirror instance.
Fixed problem with surround command surrounding text in incorrect locations (related: #39).
Previously, selections wouldn't update in any other instance than the main CodeMirror instance, causing the surround excommand to surround incorrect text. Now the selections are updated across multiple CodeMirror instances.
Both fixes applied by wrapping the CodeMirror event registers in registerCodeMirror() so that all future CodeMirror instances will be registered to the events (cursorActivity, vim-mode-change, vim-keypress, and vim-command-done when applicable).

Closing as no longer relevant.


Provide a method to navigate to the gist online

Provide a method for users to navigate to the gist online, so that users can access advanced features there. (Get embedded link, Star, etc.)

@hackjutsu
Will it conflict with #74 ?

@wujysh There will be an extra button for collapse/expand :)

@hackjutsu
What about change the #raw to #more or something else? Does #raw page have any meaning now?

@wujysh
That is a good point. I like to use the #raw to perform a non-rich text copy for a fraction of the snippet, especially when the snippet is long.
Sorry for keeping some personal preference in the app... Maybe we can either

change #revisions to #more
or change filename to a link to the online gist

I changed the #revisions to #starred, which navigate the user to their starred gists online.

@hackjutsu
I don't think #starred should be placed on gist view panel, because it's irrelevant to specific gist.
IMHO, it should be placed on the left panel.

@wujysh
Good thought:) Might move it to the left panel once I get https://github.com/hackjutsu/Lepton/issues/55 done.


Format Check-in files vol.2

Summary
This PR contains the following changes:

Add new line before and after "markdownlint" tag
Remove "mailto" link
Remove forgotten bracket in entitlement syntax
Remove unnecessary indent
Continue numbering in numbered lists
Use production endpoints in examples

@gwarf You are right, I'm reverting the change about numbering


Update notifications to be easier to work with

Finishes #138262095
Fixes #139491427
#120143319

          1 Warning

:warning:
Big PR

          1 Message

:book:
Nice, more deletions than insertions :red_circle:

  Generated by :no_entry_sign: danger


docs: add simple column pinning example

close https://github.com/radix-vue/shadcn-vue/issues/288
Very simple column pinning example
Can someone create these packages for Vue? 😭

https://www.mantine-react-table.com
https://www.material-react-table.com

Maybe we can create 1! 😉


[Bug]: ValueError: Not possible to determine the import path for object typing.Iterable[pytorch_lightning.loggers.logger.Logger].

Describe the bug
Brand new user here. I was trying to follow: https://anomalib.readthedocs.io/en/latest/markdown/get_started/anomalib.html
I'm getting the following error when I run anomalib fit -h:
raise ValueError(f"Not possible to determine the import path for object {value}.")
ValueError: Not possible to determine the import path for object typing.Iterable[pytorch_lightning.loggers.logger.Logger].

Dataset
N/A
Model
N/A
Steps to reproduce the behavior

pip install anomalib
pip install -U pip
anomalib -h
anomalib fit -h

OS information
OS information:

OS: Ubuntu 20.04.6 LTS
Python version: 3.8.5
Anomalib version: 0.7.0
PyTorch version: 2.3.1
CUDA/cuDNN version: V12.4.131
GPU models and configuration: 10x A40
Any other relevant information: bran clean virtualenv made with pyenv

Expected behavior
Same as what the getting started shows.
Screenshots
~/dev/anomalib$ anomalib -h
usage: anomalib [-h] [-c CONFIG] [--print_config[=flags]] {fit,validate,test,predict,tune} ...

pytorch-lightning trainer command line tool

optional arguments:
  -h, --help            Show this help message and exit.
  -c CONFIG, --config CONFIG
                        Path to a configuration file in json or yaml format.
  --print_config[=flags]
                        Print the configuration after applying all other arguments and exit. The optional
                        flags customizes the output and are one or more keywords separated by comma. The
                        supported flags are: comments, skip_default, skip_null.

subcommands:
  For more details of each subcommand, add it as an argument followed by --help.

  Available subcommands:
    fit                 Runs the full optimization routine.
    validate            Perform one evaluation epoch over the validation set.
    test                Perform one evaluation epoch over the test set.
    predict             Run inference on your data.
    tune                Runs routines to tune hyperparameters before training.

Does not include the install option
Pip/GitHub
pip
What version/branch did you use?
No response
Configuration YAML
just following the getting started. I have not learned about configuration files yet.

Logs
?

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @joehays, I see that you are using python 3.8. Can you use 3.10+? With pyenv you could run the following:
pyenv install 3.11
pyenv virtualenv 3.11 anomalib
pyenv local anomalib

pip install anomalib
anomalib -h
anomalib fit -h

@samet-akcay
That helped get passed the initial problem but now I get the following error when I run CUDA_HOME=/usr/local/cuda-12.0 anomalib install,
[07/19/24 13:52:14] Invalid requirement: 'torch>=2+cu120': Local version label can only be used with `==` or
                    `!=` operators
                        torch>=2+cu120
                             ~~~^
⠹ Installing packages...  This may take a few minutes.
ERROR: Invalid requirement: 'torch>=2+cu120': Local version label can only be used with `==` or `!=` operators
    torch>=2+cu120

I'm now using python 3.11.1
Thoughts?

Looks like the duplicate of https://github.com/openvinotoolkit/anomalib/issues/2156. You could fix this issue by either

reverting pip to 24 or lower. (pip v24.1+ has some breaking changes)
install anomalib via pip install[full]

@samet-akcay
Downgrading pip to 24.0 does infact get past that bug. The anomalib install command now runs and completes successfully. Now, I expect anomalib -h to show other options aside from install but I don't. It gives an error,
Could not find anomalib. To use this feature, ensure that you have anomalib installed.

but pip freeze shows anomalib installed, the installation claimed to be complete/successful but it's acting as if it isn't.
I've duplicated this problem in two different virtual environments: one installed from source, and one from PIP.
Didn't find any ISSUES similar to this problem.


Implement core-metadata PATCH device and GET device

Fix https://github.com/edgexfoundry/edgex-taf/issues/218
Signed-off-by: Ginny Guan<EMAIL_ADDRESS>

failing testcases: patch device with non-existent deviceprofile and patch device with non-existent deviceservice
issue: https://github.com/edgexfoundry/edgex-go/issues/2860


Update ID3 info in file when changing them in Koel

Description
When updating track information in Koel (title / artist / album), ID3 information should be written to the file as well.

One of the unspoken rules of Koel is to not commit destructive actions. Maybe in the future, this can be an option, but I don't really see a need right now.

Alright, I have no problem with that :) Thanks for the answer !

@phanan Also as a lead for future dev, you could write the ID3 tags only when downloading the file (not saving to the actual file, just the downloaded one)


WIP re-documentation + etc.

Issues/Remaining

IBC bash tests has a funny output which I think should be explained or not output:

/home/riger/go/src/github.com/tendermint/basecoin/tests/cli/shunit2: line 1058: 21687 Killed
${SERVER_EXE} relay start --chain1-id=$CHAIN_ID_1 --chain2-id=$CHAIN_ID_2 --chain1-addr=tcp://localhost:${PORT_1} --chain2-addr=tcp://localhost:${PORT_2} --from=$RELAY_KEY > ${BASE_DIR_1}/../relay.log

IBC Docs need to be reviewed
under go-basics consider using something other that GO-P2P in the example because that lib is depreciated

Completed:

minor changes to install
basecoin-basics
basecoin-tool requires just a few small changes
basecoin plugin page has been updated

I thought I wrote this in the docs issue, but I guess not.
Bucky and I agreed on slack to remove the example plugin and just use counter for that purpose. It was a duplication of effort with no real reward. We can make counter plugin simpler if that is what is wished, but important to have a tested app with client and server

Roger thanks for the hot tip!

The only issue I had with using the counter as the example application was the filestructure of the counter app being fully mixed in with the basecoin file structure, this type of thing really confused me when I was working through the examples of ABCI many moons ago. So I've made an improvement. Everything is functionally the same, but the whole counter plugin is now located in docs/guide/counter Much easier to reference, much easier to copy and paste if you were going to program off of it. Downside is that it introduces one more line into make install. Overall I think having this plugin be separated makes the whole tutorial more succinct, and cleans up the main repo too, don't need to see all that counter jargon 90% of the time.

Good idea with the counter reorg

Okay, I managed to suppress the "killed" messages.  Took me a deep dive into bash though, cuz it is not going to the stderr of any command, but rather the script itself.
https://stackoverflow.com/questions/5719030/bash-silently-kill-background-function-process
In the end, managed to disown these background processes, so the job messages don't print out.

Closes #114


crtfrmstmf: error: argument --ccsid: expected one argument

BOB Version 2.4.25.
When running build all from VS Code, for the payroll-bob example, the compile of MSTDSP is failing with the following error in MSTDSP.log:
crtfrmstmf: error: argument --ccsid: expected one argument
The build log contains:
=== Creating DSPF [MSTDSP.DSPF] in BOBOBJ /QOpenSys/pkgs/lib/bob/src/scripts/crtfrmstmf --ccsid -f /home/SIMONSEA/builds/payroll-bob/QDDSSRC/MSTDSP.DSPF -o MSTDSP -l BOBOBJ -c CRTDSPF -p "ENHDSP(*YES) RSTDSP(*YES) DFRWRT(*YES) AUT() OPTION(*EVENTF *SRC *LIST) TEXT( )" ✕ Failed to create MSTDSP.FILE!

It seems that a tgtccsid of empty string was specified in the  .ibmi.json or the iproj.json
Can you please show me what those files contain for this failure?
It looks like BOB should handle that more graciously and default to the Job CCSID if there is an empty string by accident

Due to the ModuleNotFoundErro issue 304 I had switched back to version 2.3.9-1.
I am just trying to build the unmodified payroll-bob project from GitHub, and it's ibmi.json file contains 37 as tgtccsid.
Build all gives me now the result below. But perhaps that is not representative since it is not the same bob version as the error initially occured on.
`
Action: Build all (11:26:19 PM)
Working directory: /home/simonsea/builds/payroll-bob
Commands:
OPT=*EVENTF BUILDLIB=QGPL /QOpenSys/pkgs/bin/makei build

make -k BUILDVARSMKPATH="/tmp/tmp0a0g83w3" -k BOB="/QOpenSys/pkgs/lib/bob" -f "/QOpenSys/pkgs/lib/bob/mk/Makefile" all
make: Nothing to be done for 'all'.
Objects:             0 failed 0 succeed 0 total
Build Completed!

Fetching errors from .evfevent.
Downloaded files as part of Action: .logs, .evfevent
`

In the scenario above it seems that nothing was out of date, so nothing needed to be built.

So I just test the https://github.com/edmundreinhardt/payroll-bob
with bob 2.4.26
and I get

Notice that everything built cleanly but there seemed to be an issue with downloading the event file for MSTDSP.  But it had no errors.

I introduced an error for MSTDSP and it showed the error correctly

@arco400 Are you using the IBM i Project Explorer VS Code Extension. It really makes it so much easier.

@edmundreinhardt I have even deleted the target build folder to be sure that I would build from scratch. But it gives me the same result.
I have the IBM i project explorer extension installed. What would that help for this situation?
I do not see an "IBM Deployment" tab as in your screenshots. How can I activate that?

Go to the Output tab and select 'IBM i Deployment'

@arco400 What type of deployment are you using?

to trigger a full build you could clear the target objects in the library or touch all of the source

to trigger a full build you could clear the target objects in the library or touch all of the source

@edmundreinhardt sorry I did not mention, but I had emptied that as well. My target lib is BOBDTA (and set as *CURLIB)
I am deploying by the "build all" command, and then deploy "all files".

The IBM i deployment window reports:
`Deployment started using method "compare"
Remote directory is empty; switching to 'deploy all'
Created deployment tarball C:\Users\Simonsea\AppData\Local\Temp\tmp-19140-gwbNBLYMW3yi-.tar
Uploaded deployment tarball as /tmp/deploy_O_if49o18r.tar
15 file(s) uploaded to /home/simonsea/builds/payroll-bob
.ibmi.json
.vscode/actions.json
.vscode/rpglint.json
QDDSSRC/MSTDSP.DSPF
QDDSSRC/Rules.mk
QPROTOSRC/ERRORTABLE.RPGLEINC
QRPGLESRC/PAYROLL.pgm.RPGLE
QRPGLESRC/Rules.mk
QSQLSRC/.ibmi.json
QSQLSRC/EMPMST.TABLE
QSQLSRC/PRJMST.TABLE
QSQLSRC/RSNMST.TABLE
QSQLSRC/Rules.mk
Rules.mk
iproj.json
/tmp/deploy_O_if49o18r.tar deleted
C:\Users\Simonsea\AppData\Local\Temp\tmp-19140-gwbNBLYMW3yi-.tar deleted
Deployment finished at 3:25:34 PM`
And the Terminal window reports:
`Running Action: /QOpenSys/pkgs/bin/makei build (3:25:35 PM)
Working directory: /home/simonsea/builds/payroll-bob
Commands:
/QOpenSys/pkgs/bin/makei build

make -k BUILDVARSMKPATH="/tmp/tmp56_2k7bo" -k BOB="/QOpenSys/pkgs/lib/bob" -f "/QOpenSys/pkgs/lib/bob/mk/Makefile" all
make: Nothing to be done for 'all'.
Objects:             0 failed 0 succeed 0 total
Build Completed!

Fetching errors from .evfevent.
Downloaded files as part of Action: .logs, .evfevent`


Can old storage in XML repositories be cleaned up?

Apologies if this has been covered in earlier issues, but I couldn't find a good reference in the docs or here. If one is implementing IXmlRepository (I'm writing one to use AWS S3), it essentially has two calls - GetAllElements and StoreElement.

What's the right thing to do as this operates over time, to avoid unbounded disk/database/storage usage?
When can old elements be cleaned up, if at all?
Is this better done in GetAll or Store or asynchronously?

Thanks in advance.

@blowdart Something we should consider. I don't think we have a clean-up story. Files are not huge so shouldn't be a big problem in the short-medium term.

No we shouldn't. This is on purpose. If you delete keys then any data that is encrypted with them can no longer be decrypted. As we don't know what users have done with keys, and any data is still available we cannot do this.
So, no cleanup.


Browse function overloads with the up/down arrow keys (with no other stuff)

This just adds the browsing functionality, let's leave the parameter highlighting for another PR.
Note the usage of mdpopups.update_popupnow.

Thanks for the fixes, works great for me in javascript / typescript!
I did some cleanups, please let me know if I missed your intentions somewhere.
Otherwise I'll merge this tonight.

LGTM


set Int MaxValue

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review https://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thank you for your contribution. Could you update title and description appropriately?

Please review https://spark.apache.org/contributing.html before opening a pull request.

Ping @wangbin0227


Allow configurable update interval and backoff

In #28 an issue was encountered with exceeding API rate limits. This was attended to with PR #29 where the update query interval was increased to 30s, and handling was added for rate exceeded error.
30s interval also has the effect of adding a 0-30s overhead to each action, depending on when the CodeBuild job happens to complete. For some use cases this overhead can be quite noticeable and unnecessary. E.g. for a singular/small group of short CodeBuild build(s), where we have little danger of hitting the rate-limiting. Some use-cases may also involve running CodeBuild builds in sequence, where this overhead is multiplied by the number of sequenced builds.
Offering a way to configure the update interval and backoff, rather than have them hard-coded as they are now, allows for a more fine-grained way to tune the API call rate to fit the use-case. This makes it possible to limit the unnecessary time overhead involved and enable a faster turn-around time. The current values could be kept as default.

Is there anymore news on this one if configurable interval and backoff is in the future?

Is there anymore news on this one if configurable interval and backoff is in the future?

The CI run for #76 was approved after I had already moved on from a client, so I didn't see what happened with the CI run and do not have access to that account anymore. Apparently there was some error in CI run but alas those logs are long lost now. The codebase has seen very few changes so I created #77 with the same changes on top of the current master-branch here 👍🏻  Hoping that it will chug along a bit more swimmingly 🤞🏻

This can be closed, as the implementation was merged in #116 and released with v1.0.8.


Add GitHub meta files for contributing policy and Code of Conduct.

This PR adds GitHub meta files for the contributing policy and code of conduct. The information for these meta files has been copied from the README file of the project. You can find more information, and test this PR by checking here.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: darkhax sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Declaration Shadows a Field of USpudStateCustomData

Hello,
I was having issues compiling under clang for PS5 receiving these errors:
...\Plugins\SPUD\Source\SPUD\Public/SpudState.h(371,2): error : declaration shadows a field of 'USpudStateCustomData' [-Werror,-Wshadow]
On line 371 of SpudState.h:
UCLASS() class SPUD_API USpudStateCustomData : public UObject { --->	GENERATED_BODY()
Any help with this issue would be much appreciated.
Thanks!
Andrew

Sorry I don't have this environment to test in. Is there anything else in the output, it seems like it's missing the part where it tells you which variable is doing the shadowing.

Looking into this, it looks like the FArchive* Ar  delcared on 373 could be to blame.
The UObject source uses FArchive Ar as an argument in a couple of functions, which could lead to this issue.

@Aj-Jones thanks for the suggestion, @renardmf could you try changing the name to see if that helps in your env?

Took a look at this today(I'm working with @renardmf ), although changing the name does fix that issue, the compiler then has an issue with the SpudTypeInfo<> declared in SpudProprertyUtil.h. Each of the various EnumTypes is shown as a duplicate symbol, and thus throws an error.

Having not really had to deal with it since Ogre 10+ years ago, I'd forgotten how much of a pain C++ compiler inconsistencies can be 😑 I assume this is some nuance of template specialisation syntax between MSVC and Clang.
I've been told the best way to test Clang without a console devkit is to use the Linux cross-compilation path so I'm going to try to get that set up, although I might not get to it for a week or two.

I believe I was actually able to fix this error.
By placing the templates that exist in SpudPropertyUtil.h into an un-named namespace, it prevents it from violating ODR.
https://stackoverflow.com/questions/64610024/duplicate-symbols-with-global-template-variable-using-clang
I opened PR #18 with the fixes in place.
Thanks a bunch for the plugin!

Awesome, thanks!


Combine nodes issue

@lasalvavida could you check this out?
For the below model some nodes may be combined unnecessarily. Is this a bug or just a side effect of the current optimization pipeline?
test.gltf.txt
test-optimized.gltf.txt
More discussion here: https://groups.google.com/forum/#!topic/cesium-dev/2LStvibUv2Y

I think the solution here is custom pipelines. combineNodes is greedy by design; it tries to create a hierarchy with the minimum number of nodes to create the smallest possible asset. Maybe some people need the node hierarchy preserved. For the online converter an optimize checkbox may be the way to go for now.

Ok that's what I figured as well. We do have a plan for an optimize checkbox.


chore: fix pointer types and macro usage based on XCode warnings

Description
Fix iOS build issues - there were two incompatible pointer types, and we were not following convention in a macro usage
This makes it so when you include this module it builds cleanly
This should be backwards compatible and just a patch version
Compatibility

OS
Implemented

iOS
✅

Android
❌

Windows
❌

Checklist

[x] I have tested this on a device/simulator for each compatible OS
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typings files (deviceinfo.d.ts, deviceinfo.js.flow)
[ ] I updated the web polyfill (web/index.js)

I am an XCode/iOS novice so review here would be nice
In particular, I changed pointer types added by @hemantasapkota  and @fjtrujy
The changes seem obviously correct but that's when I make mistakes ;-)

I did integrate this changes (by altering my package.json entry to github.com:mikehardy.net/react-native-device-info#fix-xcode-issues and now my project builds without any react-native-device-info XCode warnings, which makes me happy :muscle:

this issue still persist on iOS, your PR is not working

@cinder92 please check with the example app in the repo
Also as an open source "how can you help" note: if you were the maintainer, how exactly could you help someone that posted a comment such as yours? What details would you need? Probably all the ones on the issue template, right? Open new issues, and post all the details you can - that's how you can help the open source projects you depend on


[WIP] Refactoring and stanardizing secondary menus

See #275
This PR is probably 33% complete

Coverage decreased (-0.6%) to 84.571% when pulling 7eefa74e2c38a457a7505e964df4f411a54782d9 on secondary-menu-redesign into c1e483a18ce2e9b37de81bab4a0b09b0eade2ff3 on develop.

Coverage decreased (-3.7%) to 81.425% when pulling c0aaf12fe75a1e8a2d89bc85e430799c36f61688 on secondary-menu-redesign into c1e483a18ce2e9b37de81bab4a0b09b0eade2ff3 on develop.

Coverage decreased (-50.4%) to 34.744% when pulling c56203c92801e276c99555f5129e99fee7753716 on secondary-menu-redesign into 6df08f4c525acaa9cb2d0b5cb289e5bd9336a56c on develop.


Platform IO

I'd like to see Roc-style platform IO in HVM (esp. for compiled programs), which has already been suggested several times.
Here's what I think needs to be done:

[x] Naively split runtime.c
[x] Solve the constructor-pinning problem
[x] Implement a ~line-based~ character-based IO platform
[x] Split platform/runtime features
[x] API design
[x] Update old tests (use no_io platform)
[x] Write examples for other platforms
[x] Convert examples to automated tests
[x] Debug failing tests
[ ] Write documentation
[ ] Update interpreter

Notes:

You chose a platform at compile-time, e.g.
hvm c examples/echo.hvm -P platforms/console.c
The default platform implements the previous behavior (print normal form + stats)
The constructor-pinning problem:

IO platforms may need to know the ids of certain constructors (e.g. IO.do_output)
But the constructor <-> id mapping is currently generated per program
~Possible solution: at compile time, pass list of n constructors to pin to first n ids~
Current plan: append platform to runtime, so it can use generated #defines

Platform/runtime feature split

Before, the runtime implemented everything
After, it may be more portable to make some features platform-specific (e.g. normal form printing)
There are several fine points to be decided here:

Which features stay in the runtime / get bumped to platforms?
Current plan: target-independent utilities (e.g. evaluator, read-back) go into main, everything else either
goes into platforms (e.g. main, file descriptor handling), or can be disabled by a flag (e.g. pthreads)
Who combines the platform + runtime (hvm / user)?
Current plan: hvm (so building simple programs stays simple)
How are the platform + runtime combined (concatenation / #include header-file)?
Current plan: concatenation (so that generated #defines are visible in platform)
~What API will the runtime expose to platforms?~
~How do we keep generated code out of the API?~

Differences to interpreter IO:

The interpreter's IO interface is big -- none of the platforms fully implement it
The interpreter's console IO is line-oriented, whereas console.c is character-oriented

I've made a start in this branch, but am new to the codebase (and to C programming), so feedback is very welcome

I'm leaving the last two tasks as future work, because

updating the interpreter is a big job (we may need to JIT-compile platforms)
documentation for platforms is about as complete as the rest of the codebase
(there doesn't seem to be a a 'user manual' or similar place to put detailed user-facing documentation)

this is great @lawcho!

Oh lord, this is nice. Wish I could help with it rn

@lawcho btw, I forgot to mention.
@VictorTaelin is working on porting everything to Rust on the V2 branch.

Thanks for the heads-up @steinerkelvin -- I'll try to write platform code with porting to Rust in mind.

I'm closing this PR because:

It's become big & hard to review
I have some ideas for a simpler design
It will need re-implementing in Rust soon

Yes, sorry, this will become easier on the next version, we'll get rid of the C runtime. It would be insane to maintain IO on both back-ends. That version will include major simplifications and code quality improvements across the codebase, as well as bugfixes and much greater stability. It will make contributions much easier and allow HVM to grow into many directions.

@VictorTaelin what is the plan for IO in the Rust rewrite?
I'd like to use the generated runtime as an evaluator only, and implement my own domain-specific IO functions.
This approach has worked quite well for me so far (spread across this PR, and https://github.com/lawcho/rpphp).
Will a similar setup be possible with the new Rust-generating backend?


github: investigate merge queues

We currently use the setting "Require branches to be up to date before merging":

This ensures pull requests targeting a matching branch have been tested with the latest code. This setting will not take effect unless at least one status check is enabled.

This is good because it ensures that commits in master always pass the status checks, i.e. CI runs. However, it makes it somewhat cumbersome and slow to merge multiple PRs in sequence, as the branches need to be updated manually and the CI checks occur entirely sequentially.
Github has a feature called "Merge Queue", that essentially automate this process. See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
Investigate if this can be used with our workflows and the integrated tools, i.e.

buildkite
readthedocs
reviewable
viper/gobra code verification

Update: reviewable now supports merge queues explicitly (https://changelog.reviewable.io/changelog-june-273797)


API does not respond when trying to create purchase orders with incorrect account id

Hi! I wanted to post this bug report in the community portal, but I seems like I need additional permissions to do so, so I'll post my report there, since it's partially about spec too.
While doing the integration with xero I encountered an easily reproducible behavior that doesn't look correct, especially given that it behaves different for different content type.
Here is an xml payload:
<PurchaseOrders>
  <PurchaseOrder>
    <Contact>
      <ContactID>BROKEN</ContactID>
    </Contact>
    <Date>2020-04-28T14:00:00</Date>
    <LineAmountTypes>Exclusive</LineAmountTypes>
    <LineItems>
      <LineItem>
        <Description>Coffee Cup</Description>
        <Quantity>4.3400</Quantity>
        <UnitAmount>395.00</UnitAmount>
        <AccountCode>300</AccountCode>
      </LineItem>
      <DeliveryDate>2020-04-30</DeliveryDate>
      <Reference>1234</Reference>
      <DeliveryAddress>Hamburg</DeliveryAddress>
      <AttentionTo>John Doe</AttentionTo>
      <Telephone>+88885</Telephone>
    </LineItems>
  </PurchaseOrder>
</PurchaseOrders>

Since contact id is invalid I get a response with status 400 and body:
<ApiException xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <ErrorNumber>14</ErrorNumber>
    <Type>PostDataInvalidException</Type>
    <Message>Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).</Message>
</ApiException>

If I switch to json and send a body like this:
{
	"PurchaseOrders":
	[
		{
			"Contact":
			{
				"ContactID":"BROKEN"
			},

			"LineItems":[
				{"Description":"Tomatoes","Quantity":1,"ItemCode":"DevD"},
				{"Description":"Potatoes","Quantity":1,"ItemCode":"GB1-White"},
				{"Description":"Water","Quantity":1,"ItemCode":"PMD"}
			],
			"DeliveryDate":"2020-04-30",
			"Reference":"1234",
			"DeliveryAddress":"Hamburg",
			"AttentionTo":"John Doe",
			"Telephone":"+888885"
		}
	]
}

api responds with 500 status and body is never sent, hence a client that was generated base on openapi spec hangs forever. Given a correct account number the same payload works fine.
Unfotunately, json is the only format mentioned in the spec, so it's not possible to work it around by generating a client using a different content type.
One more note. It appears that purchase orders endpoint supports not only arrays but individual objects as well. So it's possible to send a payload like this:
{
	"Contact":
	{
		"ContactID":"BROKEN",
		"PaymentTerms":{"Bills":{},"Sales":{}},
		"BatchPayments":{},
		"Balances":{
			"AccountsReceivable":	{},"AccountsPayable":{}
		}
	},

	"LineItems":[
		{"Description":"Tomatoes","Quantity":1,"ItemCode":"DevD"},
		{"Description":"Potatoes","Quantity":1,"ItemCode":"GB1-White"},
		{"Description":"Water","Quantity":1,"ItemCode":"PMD"}
	],
	"DeliveryDate":"2020-04-30",
	"Reference":"1234",
	"DeliveryAddress":"Hamburg",
	"AttentionTo":"John Doe",
	"Telephone":"+888885"
}

In case of correct payload purchase orders are created, otherwise a correct error is returned:
{
  "ErrorNumber": 14,
  "Type": "PostDataInvalidException",
  "Message": "JSON for post data was invalid,Error converting value \"BROKEN\" to type 'System.Guid'. Path 'Contact.ContactID', line 4, position 23."
}

Unfortunately this payload is not described in openapi and hence generated clients do not provide a way to submit this payload.
Expected behvaior: I would expect to get a 200 status code with an array of purchase orders. For the ones with incorrect account number I would expect to see an error as describe in the documentation:
If you are entering many purchase orders in a single API call then we recommend you utilise the summarizeErrors parameter which provides a response format that shows validation errors for each purchase order. Note that each Purchase Order is returned with a status element which will either contain the value OK or ERROR. If a purchase order has an error then one or more validation errors will be returned.

@can3p - Thanks for the feedback.
I've tested this with our Java and PHP SDKs.  The Java SDK catches the invalid string before posting to the API, but the PHP does throw 500 error when you use a ContactId = "BROKEN".
I'm not sure this is a valid test case.  I tried a second time with our PHP SDK and used a properly formatted, but invalid GUID ContactId= "00000000-0000-0000-0000-000000000000" and received a 200 response with a validation error for the Purchase Order.
Nonetheless, I'll be sharing this bug with our API team so they can prioritize fixing it.  This isn't an issue with the OpenAPI spec per se but with the API.   Client SDKs we generate from these spec only support JSON as we felt supporting serialization for both JSON and XML was not necessary and between the two JSON is the preferred req/resp format.
While the API supports both an Object OR an Array of Objects when creating a Purchase Order, OpenAPI specs only allow for a single path/verb combination. For this reason, we've chosen to include the plural create as you can create a single or plural objects using this method.


How to specify smokescreen custom ACL

The documentation on customizing the outgoing http proxy states:

Optionally, you can also configure the Smokescreen ACL list. By default, Smokescreen denies access to all non-public IP addresses, including <IP_ADDRESS>, but allows traffic to all public Internet hosts.

Could you please describe how to do that? The puppet class does not seem to care about ACLs and the supervisor template does not include the required parameters such as --config-file or --egress-acl-file.
Zulip: 4.8

Tagging as a priority since we just made changes to smokescreen configuration.  @alexmv can you take this one?

Our deployment has no direct internet connection (also using zulip 4.8) and requires the use of an internal proxy server (which has an internal ip of course). But we would like to keep smokescreen and let it use our proxy. smokescreen seems to honor the proxy env variables but the ACL is preventing it to connect to the intenal proxy.
It would be nice to be able to configure the ACL at least. Even better would be proper support for a proxy between smokescreen and the internet.

I'm trying to develop an outgoing webhook using a dockerized Zulip 4.11 installation. The bot is running on my host.
I've tried following the instructions on how to disable Smokescreen altogether by modifying the zulip.conf file:
# cat /etc/zulip/zulip.conf
[machine]
puppet_classes = zulip::profile::docker
deploy_type = production

[http_proxy]
host =

the configuration seems to be correct, example:
# /home/zulip/deployments/current/scripts/zulip-puppet-apply
....
 directory=/home/zulip/deployments/current/
 [program:zulip_events_outgoing_webhooks]
 command=nice -n10 /home/zulip/deployments/current/manage.py process_queue --queue_name=outgoing_webhooks
-environment=HTTP_proxy="http://localhost:4750",HTTPS_proxy="http://localhost:4750"
+environment=HTTP_proxy="",HTTPS_proxy=""
 priority=300                   ; the relative start priority (default 999)
 autostart=true                 ; start at supervisord start (default: true)
 autorestart=true               ; whether/when to restart (default: unexpected)
....

but I'm still being denied when trying to use webhooks opinting to forbidden IPs/addrs
Any suggestion?
Adding this info in case it helps.

In case it helps, a workaround for the moment seems to be manually changing the configuration of Smokescreen for local development. The file should be /etc/supervisor/conf.d/zulip/smokescreen.conf and should be edited by adding --unsafe-allow-private-ranges, the final result will look (more or less) like this:
[program:smokescreen]
command=/usr/local/bin/smokescreen-dc403015f563eadc556a61870c6ad327688abe88-go-1.17.3 --listen-ip <IP_ADDRESS> --unsafe-allow-private-ranges
priority=15
autostart=true
....

Update the service configuration and restart Smokescreen
# supervisorctl update
# supervisorctl restart smokescreen

The workaround above removes all SSRF provided by Smokescreen -- hence the "unsafe" in --unsafe-allow-private-ranges.  Do not blindly add it to the command line without understanding the risks.
If there's only a single IP address which is required, you can add --allow-ip <IP_ADDRESS> to the command line.
This isn't a sufficient solution in general; we still need to develop such.  That will probably take the form of adding a non-puppet-controlled Smokescreen configuration file in /etc/zulip which Smokescreen respects.

@alexmv probably a typo, the correct parameter in to allow an ip is --allow-address <IP_ADDRESS> (at least in the dockerized Zulip installation I have)

You're 100% correct -- it's --allow-adress <IP_ADDRESS>.


Add JosepSampe, revit13, and roytman to Kubeflow org

@JosepSampe, @revit13, and @roytman from IBM Research have done a great job contributing to the Kubeflow pipelines community. I would like to sponsor them into the Kubeflow org.
@JosepSampe PRs:
https://github.com/kubeflow/pipelines/pull/10427
https://github.com/kubeflow/pipelines/pull/10410
@revit13 PRs:
https://github.com/kubeflow/pipelines/pull/10417
https://github.com/kubeflow/pipelines/pull/10416
@roytman PRs:
https://github.com/kubeflow/pipelines/pull/10483
https://github.com/kubeflow/pipelines/pull/10400

/cc @terrytangyuan
/assign @zijianjoy


Config parameter not passed in

In the "Create cluster: Configuration object" section for the last statement "New-AzHDInsightCluster".  The -config value using the $config object variable is not passed in.  It should be passed in correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2700c253-d5ff-d166-7338-d9238044e210
Version Independent ID: c4dc47e3-2a10-0ee3-1d39-bebf3ed77b51
Content: Create Apache Hadoop clusters using PowerShell - Azure HDInsight
Content Source: articles/hdinsight/hdinsight-hadoop-create-linux-clusters-azure-powershell.md
Service: hdinsight
GitHub Login: @hrasheed-msft
Microsoft Alias: hrasheed

Hello @haveyoumetcp and thank you for your question.  We will review the document and get back to you when we have more information.

@haveyoumetcp , I am assigning this to the author.
@hrasheed-msft , coud you please take a look at this?

@MartinJaffer-MSFT Looks like one line got chopped off in the sample snippet. Sorry about that.
I'll adjust the code block to show the last line which contains the -Config $config switch.
The origin PowerShell code is here if you need it
https://github.com/Azure/azure-docs-powershell-samples/blob/master/hdinsight/create-cluster/create-cluster-with-config.ps1
CC: @dagiro @hrasheed-msft for awareness. This kind of doc bug happens when someone edits the .ps1 file in the samples repo, but they didn't know to change the line numbers on the doc that references it.
Katherine introduced the bug in https://github.com/Azure/azure-docs-powershell-samples/commit/f1dfb8b0ba00b5360369a16be280b27482899295#diff-dc83e6dd75aca8bca3004d3e617908fa by accident when a new line 81 was added to the source file, shifting the whole sample down a line.
Thanks, Jason

This is merged. Waiting for publication Monday morning #please-close

@JasonWHowell Thank you for the fix and the education on how the docs work.


fix: Hide single stat optional ticks

Closes #16565
Describe your proposed changes here.

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

New changes, now single stat does not have the optional prefixes


Prometheus metrics for RPC calls

Middleware with Prometheus counter added for RPC calls over HTTP and WS.
Attempt to analyze https://github.com/paritytech/stakingops-issues/issues/34

@bkchr right now 0.8.23 build, deployed on rpc node, shows very low memory footprint. Previously we saw, that the most consumers of the memory were rpc handlers. So without metrics it's difficult to say, it was fixed in 0.8.23 (i don't see in the changelog PRs, that could do that) or it's just the lower traffic.

@grbIzl think you probably want to merge master.


11/13/2018 21:07 : Create Pull Request for branch master -> prTesting1_2018111321

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Nothing happens in frontend when search query returns zero results

Exception is raised: Uncaught TypeError: orderedItems is undefined

Closed by #188


allow order source to be passed into auth requests

We need to change the order source for ApplePay transactions

👍 once the it block description is fixed

@ChrisVoxland Updated.


Update index.js

Add the ACL option to specify the ACL policy of the files uploaded.
Defautl: 'private'
In my case I needed my pictures to be seen by everyone, but by default AMAZON ACL is private, so I had to go through all the pictures and change their permissions which you can understand was a nightmare.

I think we should either let acl silently default to private (as it is now I believe) or throw an error when it's not provided (like the other options).
Which one do you prefer @badunk?
Let's get this in for 2.0 as well.

I actually think we shouldn't specify the default ourselves or default to "{}" according to the s3 documentation - basically let s3 handle whatever default it wants to in their library:
http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html

params (Object) (defaults to: {}) —
ACL — (String) The canned ACL to apply to the object. Possible values include:
"private"
"public-read"
"public-read-write"
"authenticated-read"
"aws-exec-read"
"bucket-owner-read"
"bucket-owner-full-control"

Since we moved to using the official s3 for javascript, perhaps we should just pass/merge the entire config object along and only validate what's necessary.  But we can do that in another PR :)
Do you see any problems with that @LinusU?

Oh, well I see what you mean, and sounds good, doing another PR then :)

That sounds good

Check out 1.5.0


Undefined string data variable gets recreated if the function that references it get re-analyzed

Repro steps:

Open the helloworld binary from https://github.com/Vector35/debugger/blob/dev/test/binaries/Darwin-arm64/helloworld
Navigate to 0x100003f90, undefine the data variable
Navigate to main function, re-analyze it
Observe the data variable gets recreated

This is not very surprising since the function analysis always create the string data variable when it sees fit. However, this is previously never noticed, probably because of https://github.com/Vector35/binaryninja-api/issues/5818

This will make working with Rust/Go binaries less miserable