Update global-helpers-unit-test call syntax

Background
This patch fixes a make/unittest failure when additional files are added matching the glob global_helpers/*_test.py.
When globbed filenames are passed directly to python, and there are two or more matched files, the 2nd+ filenames are considered an argument to the first file.
For example: pipenv run python global_helpers/*_test.py works when there is one file, but in the case of a second, it becomes:
pipenv run python global_helpers/a_test.py global_helpers/global_helpers_test.py

In this invocation, global_helpers/global_helpers_test.py is interpreted as argv[1] to global_helpers/a_test.py, resulting in an error like the following:
======================================================================
  ERROR: global_helpers (unittest.loader._FailedTest)
  ----------------------------------------------------------------------
  AttributeError: module '__main__' has no attribute 'global_helpers'

  ----------------------------------------------------------------------
  Ran 1 test in 0.000s

However, if multiple filenames from a glob are passed to python -m unittest, then all the intended test cases are run.
This matters, because we want to add test cases for our helpers in a dedicated file.  Adding them to global_helpers_test.py results in unnecessary merge conflicts.
Changes

Update global-helpers-unit-test unittest call syntax

Testing

I added global_helpers/a_test.py in my branch with a couple test cases and ran make ci before and after.  With this change in place, the tests run to completion. Without the change, I get the error mentioned above.

@edyesed: it looks like this is code you've worked on before.  Since I can't request you as a reviewer using the native UI, I'll do it in a comment. 😄

Nice catch @wadells!
I also verified this locally:
$ pipenv run python -m unittest global_helpers/*_test.py
............................................................................................................................................
----------------------------------------------------------------------
Ran 140 tests in 9.106s

OK


NumberPrompt Locale Not Fully Implemented

Version
v4.5
Describe the bug
Found this bug while investigating for parity with regards to this NumberPrompt bug filed in the dotnet repo

in constructor, default_locale attribute is set, but never used in NumberPrompt's implementation (not in on_prompt() nor on_recognize()

on_recognize() does allow you to pass in locale via Activity, however locale will not be used if only default_locale is specified

"English" is used as string to specify locale, when we should be using the constants provided by the python recognizers-text repo

Separately, there's definitely a lack of unit test coverage for this feature (only 2 tests written)

Expected behavior

implement use of default_locale
implement use of recognizers-text constants to specify locale

[bug]

Update: looks like python actually never parses the value from str to float/int in NumberPrompt, which deviates from the behavior in dotnet repo.
This bug should be fixed as well


Unresponsive script

From @luebken on June 1, 2017 9:32
Trying to open with Firefox on a Mac I got the following error:
Warning: Unresponsive script
A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue.

Script: https://openshift.io/_assets/l…f49acb8aeb061f0c40eb.bundle.js:1

Copied from original issue: openshiftio/openshift.io#188

From @maxandersen on June 1, 2017 11:21
I don't get unresponsive script - I just don't get it loading at all on Firefox. Very weird.
Works for me in Chrome and Safari which would be the workaround.
Can you tell me if that works for you ?
also, I just used openshift.io - did you try another url ?

From @luebken on June 1, 2017 12:7
I was able to reproduce it: I opened the pipeline history in a new tab.

@mindreeper2420 can you reproduce this? (since you have a Mac)

@luebken it looks like you tried to access https://openshift.io/_error. Did you get this error on that page or were you redirected to it?

@joshuawilson I get this:

Did you click on something to get there? Or did you manually type in the URL

I clicked on the 'View Pipeline Runs' link, but by using cmd+click to open it in a new tab in the background. Just clicking on the link (no new tab) works fine.

@luebken are you creating a new tab?
@mindreeper2420 we have an issue for new tab #1539

This issue was moved to openshiftio/openshift.io#908


aloconnor/Updated-Main-Status-Badge

Updated readme

          1 Message

:book:
undercover: ✅ No coverage is missing in latest changes
Undercover finished in 0.0049s

  Generated by :no_entry_sign: Danger


Prepare for qt515 migration

There are still some migrations that need to be done before this feedstock can be migrated to qt515:

https://github.com/conda-forge/qjson-feedstock/pull/14
https://github.com/conda-forge/qca-feedstock/pull/26

@ceholden is the sole maintainer of both those feedstocks, but he hasn't been active lately. Anybody here want to adopt those @conda-forge/qgis ?

@izahn I guess we can close this one. Please reopen in case I am not understand it well


Fixed majority of checkstyles across all files again

Fixed majority of checkstyles across all files again

You are so good


Code availability

Congrats on the super interesting paper! I was wondering if you're planning to release the code. Thanks!

@andreaboscutti Thanks so much for your interest! I will release the code soon and let you know.


Signing for 'enterprise' using match

It appears to me, like there's a missing fastlane/match type 'enterprise' (iTC-less).
Should i use 'appstore' for retrieving enterprise distribution certificates? It might require re-using existing identity.
  Commands:
    adhoc             Run match for a adhoc provisioning profile -- possible typo: an addhoc or a profile?
    appstore          Run match for a appstore provisioning profile -- possible typo: an appstore or a profile?
    change_password   Re-encrypt all files with a different password
    decrypt           Decrypts the repository and keeps it on the
filesystem
    development       Run match for a development provisioning profile
    ...
   enterprise     Run match for an enterprise provisioning profile

Glad to hear you're giving match a whirl! Omitting enterprise was a conscious decision; please take a look at https://github.com/fastlane/fastlane/tree/master/match#enterprise-profiles for more information. Thanks!

Also, if you really want to use it, you might want to check out https://github.com/fastlane/fastlane/blob/master/match/lib/match.rb#L29

+1


FlutterPluginRegistrar should expose FlutterViewController

I am updating the image_picker plugin to the newest plugin API and there doesn't see, to be a way anymore to access the FlutterViewController: https://github.com/flutter/image_picker/commit/733d3317646e928c781809fe2648c4ba89f7f53e#diff-5899d28b4e39af8fd863d004b30d690eR20
Can a getter be added to FlutterPluginRegistrar?

I'm not sure there will always be just one FlutterViewController in any Flutter-based app. Maybe expose the UIWindow property from FlutterAppDelegate via the plugin registrar. That way, plugins can access view controllers during registration in the same way that FlutterAppDelegate currently does, e.g.:
UIViewController* viewController = registrar.window.rootViewController;

I'm not sure there will always be just one FlutterViewController in any Flutter-based app.

Agreed we should avoid that assumption.

Maybe expose the UIWindow property from FlutterAppDelegate via the plugin registrar.

It's theoretically possible to have multiple FlutterViewControllers in the responder chain for a given UIWindow, so you'd probably want to assume that when you go to find the one you want.

We just want to presentViewController: on "the" UIViewController.
If [UIApplication sharedApplication].keyWindow.rootViewController is a reliable source of a UIViewController` for such use, we should let plugins use that instead, and close this PR.
cc @szakarias

Closed per comment above.

I'm reopening this bug because this change is causing crashes when signing in on iOS.
[UIApplication sharedApplication].keyWindow.rootViewController is nil at the time it is read.
(UIViewController *)registrar.messenger works fine.

In case anyone runs into the crash, here are the logs for it. The problem seems to be that keyWindow isn't set up yet. I'm running the firebase_auth sample app which uses google_sign_in.
Jun 13 16:49:50 jackson-macbookpro Runner[25579]: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'uiDelegate must either be a |UIViewController| or implement the |signIn:presentViewController:| and |signIn:dismissViewController:| methods from |GIDSignInUIDelegate|.'
	*** First throw call stack:
	(
		0   CoreFoundation                      0x000000010406cb0b __exceptionPreprocess + 171
		1   libobjc.A.dylib                     0x00000001084e4141 objc_exception_throw + 48
		2   CoreFoundation                      0x00000001040d5625 +[NSException raise:format:] + 197
		3   Runner                              0x0000000103a654e4 -[GIDSignIn signInWithOptions:] + 88
		4   Runner                              0x0000000103a61f50 -[GIDSignIn signIn] + 64
		5   Runner                              0x00000001039a38ff -[GoogleSignInPlugin handleMethodCall:result:] + 1295
		6   Flutter                             0x000000010489e6b8 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 118
		7   Flutter                             0x00000001048ab6b8 _ZN5shell21PlatformMessageRouter21HandlePlatformMessageEN3ftl6RefPtrIN5blink15PlatformMessageEEE + 166
		8   Flutter                             0x00000001048aec0b _ZN5shell15PlatformViewIOS21HandlePlatformMessageEN3ftl6RefPtrIN5blink15PlatformMessageEEE + 35
		9   Flutter                             0x00000001048cf099 _ZNSt3__110__function6__funcIZN5shell6Engine21HandlePlatformMessageEN3ftl6RefPtrIN5blink15PlatformMessageEEEE3$_1NS_9allocatorIS9_EEFvvEEclEv + 59
		10  Flutter                             0x00000001048b5d37 _ZN3fml15MessageLoopImpl15RunExpiredTasksEv + 1007
		11  Flutter                             0x00000001048b8454 _ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0_ + 26
		12  CoreFoundation                      0x0000000104000454 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
		13  CoreFoundation                      0x00000001040000e3 __CFRunLoopDoTimer + 1011
		14  CoreFoundation                      0x0000000103fffcaa __CFRunLoopDoTimers + 266
		15  CoreFoundation                      0x0000000103ff79ec __CFRunLoopRun + 1916
		16  CoreFoundation                      0x0000000103ff7016 CFRunLoopRunSpecific + 406
		17  GraphicsServices                    0x000000010a830a24 GSEventRunModal + 62
		18  UIKit                               0x00000001067490d4 UIApplicationMain + 159
		19  Runner                              0x000000010394cadf main + 111
		20  libdyld.dylib                       0x00000001091fa65d start + 1
	)

[UIApplication sharedApplication].delegate.window.rootViewController may be more obvious than casting the messenger.

@mravn-google yep, that's what I ended up doing. Thanks for the suggestion!

[UIApplication sharedApplication].delegate.window.rootViewController
How do we do this in swift?

In swift code
let viewController = UIApplication.shared.delegate!.window!!.rootViewController!


Improve codecov for agent/installer

At the moment, we have 69% coverage for installer. Identify more test cases to improve the coverage. To look at the detailed codecov report - https://app.codecov.io/gh/vmware-tanzu/cluster-api-provider-bringyourownhost

I can take a stab at this

/assign @NilanjanDaw

cli.go is difficult to test and hard to mock. Recommending it to be added to the code-coverage report exclusion list PR 344
Some bundle_downloader paths need to be tested via integration tests through reconciler PR 340.
Other paths have acceptable code coverage. Closing the issue.


Announcement: Introducing the RealSense D455 Depth Camera

Hi everyone,
The official RealSense store has now opened pre-orders for a new member of the RealSense 400 Series depth camera family: the RealSense D455, which increases range and accuracy over the D435 by a factor of two.
https://store.intelrealsense.com/buy-intel-realsense-depth-camera-d455.html
The official Intel Newsroom press release about the D455 can be found here:
https://newsroom.intel.com/news/intel-realsense-depth-camera-d455-twice-range-better-performance/
The data sheet document for the 400 Series has been updated to the June 2020 edition that includes the D455.
https://dev.intelrealsense.com/docs/intel-realsense-d400-series-product-family-datasheet
The official information page for the D455 is here:
https://www.intelrealsense.com/depth-camera-d455/
The official CAD model of the D455 is here:
https://dev.intelrealsense.com/docs/cad-files

Wow quick  surprise !!
Any sample data available ?
and when is the shipping date for preorders ?

Awesome! So many well thought out improvements, I can wait for the preorder to arrive and to work with these devices moving forward.
The language in the white paper seems to say this, but just to confirm explicitly; can the Global Shutter RGB camera in the D455 also be controlled through the new genlock mode?
And is the D455 maximum framerate in genlock mode also limited to half the target frame rate (e.g. 30fps is limited to 15fps and 90fps is limited to 45fps)?

Hi @devshank3   Glad you're excited for the D455!
The official RealSense store's listing for the D455 states that pre-orders will be shipped in the week of July 20 2020.
There is not a D455 sample file available yet, though when one is available it should be posted on the sample data page.
https://github.com/IntelRealSense/librealsense/blob/master/doc/sample-data.md
Regarding an IMU-less model: Intel test a wide range of camera configurations, and do not discuss future possible products.

hi @sam598   The opening paragraph of Intel's white paper document on external synchronization states that the feature is "for all Intel RealSense depth cameras that are based on Global Shutter imagers".  This would implicitly include the D455.
https://dev.intelrealsense.com/docs/external-synchronization-of-intel-realsense-depth-cameras
@dorodnic  Could you provide advice please about the question below:
Is the D455 maximum framerate in genlock mode also limited to half the target frame rate (e.g. 30fps is limited to 15fps and 90fps is limited to 45fps)?

I'm not sure, but @agrunnet is likely to know

Correct. Same feature. Same limitation.

The official CAD model of the D455 has been added to the RealSense CAD file archive.
https://dev.intelrealsense.com/docs/cad-files

We just received this camera yesterday after a long pre-order wait and was expecting everything Intel's promotional material conveys and more. Unfortunately, it has been a huge disappointment. Using the Realsense Viewer program, this unit only achieves a fluid frame rate of 30fps. Taking it up to 90fps or higher will create video freezes and eventually crash a computer (and we have tested it on several, including a 32-core CPU, 64Gb RAM, GeForce NVIDIA RTX 2070 video card, and high-speed USB 3 ... so it's not the computer).
We were hoping to use it for robotics and 3D scanning applications but once it is connected to such a device (we used a Samsung A30S since it is portable), the frame rate drops down to 15fps and resolution to 640x480 -- and even at that stepped down quality, it cannot track depth and RGB images in a synchronized manner. That's the least of the problems, unfortunately --- as it also cannot properly relay depth for nearly 80% of the surroundings. There are the expected black shadows behind objects not 5 meters away due to occlusion but there are also huge black spots ** on ** objects or, in some cases, entirely covering them. And yes -- we have have performed on-chip calibration. Here is a sample extraction with the camera on a tripod (in a well-lit room during the day) https://imgur.com/9oA3YQQ
So it marginally works tethered to a powerful computer, but using it as Intel markets it? I am highly doubtful. The Realsense SDK 2.0 has eliminated many useful features the original SDK contained and it does not yet fully support D455 --- clearly, given these preliminary tests. I would never, in a million years, attach this to a robot that requires proper obstacle avoidance or even space sensing. It could be dangerous! With this level of performance and quality, how can it be used for anything whatsoever? Is the purpose of the camera merely for hobbyist tinkering?
We will run some additional tests -- but with the amount of stereo IR warping, point cloud distortion, and inability to synchronize high-resolution RGB, we will likely be shipping this straight back. I have reached out to support, and they have gone silent. I presume they are aware of these problems. Hopefully, this comment will remain here so as to provide a more balanced view. Intel is welcome to refute anything I have said here, within reason.

Thank you for the feedback.  We would like to learn more about your configuration and experience.  We will be in contact with you.
Thank you from the RealSense™ Customer Support Team.

D455 is the first camera that consists all global shutter cameras (including RGB sensor). Does GenLock option work for all cameras (including RGB) or only for Depth Module sensors?

D455 is the first camera that consists all global shutter cameras (including RGB sensor). Does GenLock option work for all cameras (including RGB) or only for Depth Module sensors?

Hi @michaelvorobiev   The discussion in the link below addresses the subject of color sync with genlock on D455.
https://github.com/IntelRealSense/librealsense/issues/7502
As far as I am aware, it is a feature that is still being worked on at the time of writing this.
https://github.com/IntelRealSense/librealsense/issues/7502#issuecomment-724784638

Hi @michaelvorobiev   The discussion in the link below addresses the subject of color sync with genlock on D455.
https://github.com/IntelRealSense/librealsense/issues/7502
As far as I am aware, it is a feature that is still being worked on at the time of writing this.
https://github.com/IntelRealSense/librealsense/issues/7502#issuecomment-724784638

@VisionaryMind I wonder whether you still find the D455 less robust than previous models, or have these aspects ironed out by now. A supposed inability to track color and depth in a synchronized manner might sound prohibitive to any application to me, as I would kind of assume that to always work in order to enable any depth enabled application.

@matanster One of my colleagues in Sweden had a conversation with the Realsense director of engineering along with at last one other Intel technical lead. They point blank told her that these cameras are not suited to photo-realistic re-construction of 3D environments, which was our original goal. The language used, if I recall was "such a goal would be possible with a great investment of resources". This sentiment is echoed throughout the forums globally, and I frequently encounter agreement that the data coming out of the Realsense cameras, at last for now, is too noisy.
That being said, I have seen very good SLAM results using a D455 + T265 paired, and if accuracy of pointcloud / 3D mesh is not a concern, this is one of the areas where Realsense actually shines. They may also be used, to a degree, for body tracking but again, the noise (which is not manageable with configuration adjustment) confounds results. Even the Azure Kinect, which has shown 10x less noise and cleaner depth boundaries than its Realsense contemporaries, nonetheless suffers from extreme latency and data overload --- similar to all things Microsoft in general. Overly bloated and inefficient data payloads.
Nonetheless, we have found K4A (Azure Kinect) to yield better 3D pointclouds and textured meshes with far less noise but --- nonetheless --- it still falls quite short of the higher-end LiDARs and / or photogrammetry. All depth cameras do. So it all depends on your context. Realsense depth cameras are fast but noisy and inaccurate, well-suited to SLAM but not viable in contexts where either photo-realism or cm-accuracy is a hard mandate. I would also venture to say clean, consistent-quality volumetric capture would also be problematic due to this shortcoming.

Thanks for the wide exposition @VisionaryMind, really helpful. I wonder what noise to expect with body tracking, as my main scenario is fine hand gesture recognition. The colorized depth official photo images looked fairly clean to me IIRC . Is it anything that a convolution/interpolation with the neighboring pixels won't solve?


[ 3° ] - Release/v1.4.0 Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id

Why we create this PR?
There is a bug related to the search of the digital twin registries, sometimes there is coming no contract id and the backend enters in a loop without retrying the negotiation of contract.
What we want to achieve with this PR?
We want to fix the bug by implementing the necessary changes in the DTR Search Logic
What is new?
Added

Fixed the timeout time for each negotiation
Added check for empty or null contractIds with retrial
Added descriptive logs to search and create methods

Issues Fixed

Fixed the long waiting time by implementing timeout when doing the negotiation
Fixed the null contract ids creation

PR Linked to:

Tickets

cmp-983

Here we need to add the change logs

The ip chceks are executed and nothing was found


Fix indexing

The indices of the errors are sequential, starting from 0. This creates problems when adding the errors back into the original DataFrame. For example,
import numpy as np
import pandas as pd
from photerr import LsstErrorModel

x = pd.DataFrame(np.arange(21, 30).reshape(-1, 1).astype(float), columns=["u"])

errM = LsstErrorModel()

errM(x.iloc[2:5], random_state=0)

yields
           u     u_err
2  22.998142  0.077355
3  24.004532       NaN
4  24.947432       NaN
0        NaN  0.014667
1        NaN  0.033837

rather than the expected
           u     u_err
2  22.998142  0.014667
3  24.004532  0.033837
4  24.947432  0.077355

I will fix this so that the errors have the correct indexing.

Fixed in release v0.2.1


Fix refactoring when the hint contains noParen

yes = f ((,) (2 + 3))

Before:
yes = f (_noParen_ (2 + 3),)

After:
yes = f (2 + 3,)

Thanks! After looking at your patch I decided _eval_ can die since it's not used anywhere and is somewhat odd as hints go - so I've removed that entirely.


Patch 4

attempt to address https://forum.pfsense.org/index.php?topic=100232.0

That looks good :+1:


typo fixed

@youhonglian can you also change  ImageBuilder is a tool for building an optimized k8s images to  ImageBuilder is a tool for building optimized k8s images ?


Caching

So here's some experimental caching I implemented for biome and heightmap. I also ran some tests that turned out to be interesting:
Summary for pregenerating 700 radius with Chunky (i7-6700K@4GHz):
No caching: 2min 55sec
HeightMap caching: 1min 57sec
HeightMap and Biome caching: 1min 57sec
Vanilla: 1min 46sec

Now, about the biome caching. Only getBiomeBank(int x, int z) uses cache, getBiomeBank(int x, int height, int z) does not. This is because I didn't want to break anything by caching the 3d getBiomeBank function to 2d cache, although it probably could've been done. getBiomeBank(int x, int z) also uses cached HeightMap values to calculate the biome.
I changed some NMS functions to call the 2d biome function instead of 3d, but the NMS functions themselves still take x, y and z as parameters. For now it would have been too much work to change every getBiome function in the plugin to use the 2d version, so that has to be fixed. Because of that, a lot of biome populators still calculate redundant y height values for the getbiome function.
TLDR; biome caching is not used effectively by nearly every getBiome call, a lot of optimization can be done. Everything seems to be working fine, but don't merge yet.
Any thoughts, suggestions? I'd like to also confirm that I can basically replace all 3d getBiome calls with cached 2d calls because the biomes are 2d for now right?

Be careful regarding the ChunkCache file's method of finding chunk coords from block coords and vice versa. It may be better to use Mojang's way (bitshifting 4 units). Check MegaChunk.java for examples. It's pretty tricky and has many edge cases. Plus whatever custom math operation can't get faster than a bitshift anyway.
Other than that, looks fine. If the testing shows a clear improvement in performance, it should be okay.

Be careful regarding the ChunkCache file's method of finding chunk coords from block coords and vice versa. It may be better to use Mojang's way (bitshifting 4 units). Check MegaChunk.java for examples. It's pretty tricky and has many edge cases. Plus whatever custom math operation can't get faster than a bitshift anyway.
Other than that, looks fine. If the testing shows a clear improvement in performance, it should be okay.

Currently I'm just relying on java garbage collector, although I have to test with a lot bigger radius for Chunky to see if it's actually working. If not then I'll flush it (probably have to do it that way since technically the objects are always referenced in the caches hashmap). So what do you say, would it be safe to transform all the getBiome functions to only take x and z as parameters?

Currently I'm just relying on java garbage collector, although I have to test with a lot bigger radius for Chunky to see if it's actually working. If not then I'll flush it (probably have to do it that way since technically the objects are always referenced in the caches hashmap). So what do you say, would it be safe to transform all the getBiome functions to only take x and z as parameters?

Might not be very future proofed tbh, the update itself will probably make its debut in summer.
I’m not fully sure if we should try and do 3D biomes, or just 2d biomes with height to regulate the vertical biomes like what’s being done now.
What do you think?

Might not be very future proofed tbh, the update itself will probably make its debut in summer.
I’m not fully sure if we should try and do 3D biomes, or just 2d biomes with height to regulate the vertical biomes like what’s being done now.
What do you think?

I think optimizing everything and using 2d biomes everywhere would make sense for now. Since the plugin is completely separated from vanilla generation, the fact that they will implement 3d biomes in summer doesn't mean that this plugin has to. Or, technically it's already possible to implement 3d biomes if we'd like to, nothing stopping us form doing that API wise.
So I'd say everything to 2d biomes for now, if the plugin switches to 3d at some point it can be re-implemented. It's not so dependent on Mojang after all, right? Update to 1.17 doesn't have to include 3d right away.
Oh and also, I think the best solution would be to pass all the necessary info like biomes and heighmap down to the populators when generating a chunk, so for example HeightMap would be calculated only once per x/z coordinate and no caching. Not sure how this would be implemented though, I think the whole world generation api structure is kind of against that.

I think optimizing everything and using 2d biomes everywhere would make sense for now. Since the plugin is completely separated from vanilla generation, the fact that they will implement 3d biomes in summer doesn't mean that this plugin has to. Or, technically it's already possible to implement 3d biomes if we'd like to, nothing stopping us form doing that API wise.
So I'd say everything to 2d biomes for now, if the plugin switches to 3d at some point it can be re-implemented. It's not so dependent on Mojang after all, right? Update to 1.17 doesn't have to include 3d right away.
Oh and also, I think the best solution would be to pass all the necessary info like biomes and heighmap down to the populators when generating a chunk, so for example HeightMap would be calculated only once per x/z coordinate and no caching. Not sure how this would be implemented though, I think the whole world generation api structure is kind of against that.

Alright, ignore this. The code was changed I didn't check the new one.

Alright, ignore this. The code was changed I didn't check the new one.

Alright, ignore this. The code was changed I didn't check the new one.

Alright, ignore this. The code was changed I didn't check the new one.

My worry is the possibility that stuff like Lush Caves would be marked as a different biome, so mob spawning and other biome specific mechanics get tied in

My worry is the possibility that stuff like Lush Caves would be marked as a different biome, so mob spawning and other biome specific mechanics get tied in

Ready to merge on my side

Ready to merge on my side


Add data-testid to all components that don't have one

Is your feature request related to a problem? Please describe.
It is difficult to identify northstar components that have no "data-testid" for ui automation testing using tools like Cypress.
Is your feature request related to a specific component? Please add.
Describe the solution you'd like
Add data-testid to all components.
Describe alternatives you've considered
Additional context

It'd be nice if data-testid could be passed as a prop to all the components and get added to the appropriate underlying component, eg:
<Button onClick={...} data-testid="my-button-that-i-reference-in-tests">Click Me</Button>


Reports folder must be created only if there are no tests

Check if reports folder already have tests.

Already working, closing issue.


Readonly modifier doesn't work with type aliases for tuple or array

TypeScript Version:  3.5.1

Search Terms:
readonly, type alias, tuple, array
Code
type A = number[];
type T = [number, number];

type RA = readonly A;
type RT = readonly T;

Expected behavior:
There is no errors, like in the following example:
type RA = readonly number[];
type RT = readonly [number, number];

Actual behavior:
Compile errors:
test.ts:4:11 - error TS1354: 'readonly' type modifier is only permitted on array and tuple literal types.

4 type RA = readonly A;
            ~~~~~~~~

test.ts:5:11 - error TS1354: 'readonly' type modifier is only permitted on array and tuple literal types.

5 type RT = readonly T;
            ~~~~~~~~

Found 4 errors.

Playground Link:  http://www.typescriptlang.org/play/index.html#code/C4TwDgpgBAglC8UB2BXAtgIwgJwNoF0BuAKFEigBUEpdVMcAaZdLbI408aAJTkWwgBDACYB7JABsQsEmR5V+QsZOkVCQA
Related Issues:
https://github.com/microsoft/TypeScript/issues/12

array and tuple literal types

A and T are not array or tuple literals, they're type constants.  What you want is:
type RA = Readonly<A>;
type RT = Readonly<T>;

In the wiki readonly modifier is proposed as new syntax for read-only arrays.
With current restrictions need to mix readonly modifier and Readonly type:
type Position = [number, number];

function takeCoordinates(coords: readonly Readonly<Position>[]): void {}

On the page you linked it shows that you can't use it with type aliases:
let err1: readonly Set<number>; // error!
let err2: readonly Array<boolean>; // error!

let okay: readonly boolean[]; // works fine

And in your example, you would still need to repeat yourself even if this were supported:
function takeCoordinates(coords: readonly (readonly Position)[]): void {}

This is the current design. We have special syntax and semantics for these types only.
This might change in the future, but the most likely change is that readonly could be applied to any type.


Files in the release zip archive

Some files in the release zip archive, currency-converter.zip v1.0.1, is unnecessary:

PowerToys.Common.UI.dll
PowerToys.ManagedCommon.dll
PowerToys.Settings.UI.Lib.dll
Wox.Infrastructure.dll
Wox.Plugin.dll

Thanks for the input. I have removed all the unwanted files from the build. 🎉


CMake: Improve support to build python bindings

Refactors iree_pybind_cc_library()
Adds iree_py_extension()
Updates and CMake targets for python bindings

The bindings are still not complete and currently only implements support for Linux.
Depends on #693 and #694. I will drop these commits and rebase if these patches get merged separately into master.

I am gladly awaiting your feedback :) We might need an iteration before this can be merged, but I hope it is the right step to enable building the python bindings with CMake.

Looking now...

This broke the cmake build. To run kokoro on PRs and ensure we avoid a breakage, a repository collaborator needs to tag the PR with "kokoro:run"

TIL
Ok - sorry about that. I assumed the presubmits were authoritative...
On Thu, Feb 6, 2020 at 1:12 PM Geoffrey Martin-Noble <
<EMAIL_ADDRESS>wrote:

This broke the cmake build. To run kokoro on PRs and ensure we avoid a
breakage, a repository collaborator needs to tag the PR with "kokoro:run"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/iree/pull/695?email_source=notifications&email_token=AADYVACVEJVWLZ5OLLJSFETRBR4NFA5CNFSM4KRCQWY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAZRMI#issuecomment-583112881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYVAE537HNI7XMJ3KNS3TRBR4NFANCNFSM4KRCQWYQ
.

Yeah it's not a great situation :-/ They are somewhat authoritative, but we have to give them permission to run for contributions from outside the organization and nothing blocks on them on import. That's why I wanted to use GitHub required checks because it gives you a nice UI that indicates "hey this isn't ready to merge", but unfortunately it breaks copybara's ability to push directly to master.

CI build fix is at https://github.com/google/iree/pull/700. We also discussed ways to make "this hasn't run presubmits yet" blocking or more obvious, but don't yet have a concrete plan.

My apologies. I probably have missed to do a full rebuild and only checked if the incremental build succeeds. Will send a patch to fix the bindings.


Please change picture example to be more neutral

Could we please change the picture example in the README? This currently reads:
// "Asians took pictures of food 3 times"

This is a great library I have started to integrate into my company. When it comes to the documentation that people will be reading it would be nice to have neutral examples that don't potentially call on stereotypes - especially if there are similar examples that suffice.
Happy to make a pull request for you.

I've gone and made a pull request that I hope keeps with the nice lighthearted nature of the docs.
Cheers


VSCode extension not showing annotations for variant groups

VS Code will not show annotaions for variant groups, to profit from the extension, one has to type out each single classname.
I know there is complexity involved with correctly recognising these, as well as transforming both ways to generate the required tooltip information, and then back to generate the correct editor decorations (e.g. the tooltip for border should end up with ~ in the end, and border-2 with 2.)
Please see an attached example of where the plugin fails: (border-(~ 2) vs border border-2)

I would perferally suggest to use attributify over variant groups.

Attributify is a mixed bag for me.
Unlike the screenshot suggests, I actually use pug most of the time for html / templates, it’s much more comfortable to use and refactor. However, when working with web frameworks and components, much of the actual html I end up writing is just divs for layouting and structure - where I hugely benefit from pug’s shorthand for divs with classes .max-w-25rem.w-full e.g. instead of div(class="max-w-25rem.w-full").
I know the VSCode extension doesn’t work with pug at all (at least for me), so in that case this whole issue does not matter.
Another problem I have with attributify is the visual clutter it introduces. Being able to organise attributes instead of having one large class string is great, until you end up with seven lines of attributes per element, plus the functional ones (binding props, events, etc. in Vue, e.g.) I much prefer being able to visually quickly differentiate between what is functional and what is styling, which I feel like attributify doesn’t offer, especially with pug.
Thirdly, since I work with bootstrap and use UnoCSS to fill the gaps (like replacing all bootstrap utilities to be more flexible regarding sizing and positioning), I use classes anyway, and many additional stylings just sparingly - same goes for variant groups, it’s not often I need them. In that case, attributify no longer offers any advantage for me.
I realize this turned into quite a long text, and I want to assure you this is not a rant - I think attributify is awesome for people who use UnoCSS or Windi in the “traditional” way, but just not the right tool for me.
Anyway, I’ll take a look at the code and familiarise myself with the way the extension generates the annotations, maybe I can provide an implementation for this. Thank you for your work with UnoCSS, and all the other open-source projects you created and/or contribute to!


New-DbaCredential

Adjusting examples to be more accurate for creating objects for Backup To URL.
Formatted variables to standard.

thank you! 💯


UNO: give notifications for highlights

only |c:| notifies, |c| apparently doesn't

??? Really?

That seems like a client bug.

i think it's because highlights in battle arent supposed to notify, hence they use the |c| format as opposed to chatrooms which always always use |c:|

Highlights in battle are supposed to notify...


Broken image for default developer pictures.

For developers who do not have a Meetup picture the developer cards display a default img/picture_not_found.png which is not in the repo. Also the link to the attribution leads to a dead site.

We should find a should discuss a suitable replacement and attribution.

Suggested default image?

:trollface:

Actually, hilariously, I was just shopping for climbing shoes, and came across this pretty awesome we-have-no-image-here image:

small, card-styled version of the newhaven.io logo? or maybe just something simple like a silhouette? @maxx1128 @alexwilkinson what do you think?

@treznick Something that simple would be pretty easy to make, plus it'd be a bit more consistent with the site's design. Could make something along those lines.

that sounds like an awesome option!

Yeah I think just a simple silhouette works! Many repetitions of a logo starts to look tiring on the eyes ^_^. If you're down to make that @maxx1128 that would be amazing!

I'm deep in the weeds of refactoring the events and developer code. But if you save the file to img/picture_not_found.png both the old and new code will use it.

Gotcha, will tackle that later today. Should be a quick fix.

I love it when a plan comes together
On Monday, August 1, 2016, Max Antonucci<EMAIL_ADDRESS>wrote:

Gotcha, will tackle that later today. Should be a quick fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/newhavenio/newhavenio.github.io/issues/9#issuecomment-236709559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlwAweW-IQ3I4-vGKRkG67mRcEp13qfks5qbmFggaJpZM4JZJDa
.

--
Sent from a small rectangle

How's this one?

I like the lighter one. I'd maybe even gray-in the next a bit, but not a blocker. Nice job!

Didn't look like anyone had any objections, so I just added the lighter one in. Can be seen in the live site.

It looks good!
On Wed, Aug 3, 2016 at 8:29 AM, Max Antonucci<EMAIL_ADDRESS>wrote:

Didn't look like anyone had any objections, so I just added the lighter
one in. Can be seen in the live site.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/newhavenio/newhavenio.github.io/issues/9#issuecomment-237223604,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAzFcA5CSUuhdvEjgqzjDRghc4C_wieks5qcInEgaJpZM4JZJDa
.

--
twitter @danbernier
http://wordcram.org | http://newhaven.io


Getting an EWS Failure error - unable to obtain callback token

I know this is similar to other issues, but I didn't see any resolution on them.
I'm the Exchange admin.  New 2016 install. No proxy between workstation and server.  Same error from Outlook for Windows and OWA.
Requirement set = 1.6
API used = EWS
contentLanguage = en-US
displayLanguage = en-US
hostname = Outlook
hostVersion = 16.0.11425.20204
itemId = true
itemType = message
itemClass = IPM.Note
permissions = 3
ERROR: Unable to obtain callback token.
Fallback to EWS.
{
  "value": null,
  "status": "failed",
  "error": {
    "name": "InternalServerError",
    "message": "The Exchange server returned an error. Please look at the diagnostics object for more information.",
    "code": 9042
  },
  "diagnostics": {
    "ErrorText": "The token for this extension could not be retrieved."
  }
}
Anonymous function()@https://mha.azurewebsites.net/Scripts/GetHeadersRest.js:37:17
Anonymous function()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:183743
Anonymous function()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:175387
agaveResponseCallback():1:6425
window.agaveHostCallback():1:8327
ERROR: Async Response
{
  "value": "",
  "status": "succeeded"
}
callbackEws()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:80:17
Anonymous function()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:47:13
t.onreadystatechange()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:189638
r.EwsRequest.prototype._callOnReadyStateChangeCallback$i$1()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:307185
Anonymous function()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:315041
ERROR: Original Response
{
  "wasProxySuccessful": true,
  "errorMessage": null,
  "body": "",
  "error": false
}
callbackEws()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:84:17
Anonymous function()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:47:13
t.onreadystatechange()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:189638
r.EwsRequest.prototype._callOnReadyStateChangeCallback$i$1()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:307185
Anonymous function()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:315041
ERROR: EWS callback failed : Failed to retrieve headers.
callbackEws()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:75:17
Anonymous function()@https://mha.azurewebsites.net/Scripts/GetHeadersEWS.js:47:13
t.onreadystatechange()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:189638
r.EwsRequest.prototype._callOnReadyStateChangeCallback$i$1()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:307185
Anonymous function()@https://appsforoffice.microsoft.com/lib/1.1/hosted/outlook-win32-16.02.js:15:315041```

It looks like the error is coming from the server. Could you get a fiddler and locate the failing EWS call in there?

I don’t know what that means, but I’ll take a look when I am back in the office.
Thanks.
Mark Mahacek
Sent from my iPhone.
On Apr 16, 2019, at 7:34 PM, Stephen Griffin <notifications<EMAIL_ADDRESS>wrote:
It looks like the error is coming from the server. Could you get a fiddler and locate the failing EWS call in there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/stephenegriffin/MHA/issues/108#issuecomment-483914016, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZMiLgeoOJ4XhpR43KXFdHT-lGR4NKUlks5vhogEgaJpZM4czz7T.
EXTERNAL EMAIL This message came from outside Merced COE. Please be sure it is really “from a trusted” sender before responding, clicking links or opening attachments.

I'm brand new to Fiddler.  I got it installed and can see traffic, but am not sure what you want me to pull.

I've run fiddler against my client while trying to replicate, however I am not seeing any related traffic show up in Fiddler.

I have verified the plugin is fine with our 365 hosted mailboxes, but does not work with any of our on-premise 2016 users.

@mmahacek, check that you don't have expired Microsoft Exchange Server Auth Certificate
If this is the case - you just need to update it. See this post for how-to: http://byronwright.blogspot.com/2018/05/expired-microsoft-exchange-server-auth.html
Cheers!

😲
I updated the auth certificate for another issue and hadn't checked the plugin since.  Via on-prem webmail, it appears to be working!!  Outlook client is giving an Add-in error and continuously prompts to restart the add-in.  Will be looking into that next.  Thanks for the tip.

@mmahacek, I'm glad that your main issue is solved. Now you need to troubleshoot Outlook. First try to setup clean environment (OS with Office) and check if MHA work on it. I believe that your issue is related to host environment. Good luck!

Good call @tivrobo . Thanks for jumping in! I wonder if I/MHA could have deduced this was the problem and put up appropriate text for the user...


Invalidate Correct Edited Range

Description
In the highlight state, invalidates the correct range when performing an edit.
Sometimes tree-sitter doesn't invalidate the ranges that were edited, so we need to add that edited range in. This ensures that a non-empty range is always invalidated.
Related Issues

Related pr: #273

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots
https://github.com/user-attachments/assets/9e4d9b35-1e2d-44b8-9c2e-ffbfde69c8e4
Previously:
https://github.com/user-attachments/assets/4b572c31-0320-4f90-ac52-6f911713bc75

Fix the failed test first and then we can merge.

Fix the failed test first and then we can merge.

Fixed! Had to update a test for that method that used different range/delta semantics than NSTextStorage


Add button - open in google maps

Enable to see places (markers) in google map app on web and mobile. Preferably on click on button "Open in Google Maps".

Please refer to Getting Help section in the README (or #469). Close now


wallet sync progress stuck at height 3506122

I am using NEO-GUI 2.9.0. Downloaded the bootstrap data file (1st May). After about 24 hours the block data sync-ed to the latest height, and I was trying to open my wallet.
The sync of wallet data stuck at height 3506122. I have tried to rebuild the index, and delete the index folder but it repeated at same height, even I create a new address.

I deleted the chain data and re-synced. Now the problem is gone.
I recalled that in the middle of sync I tried to rename the offline-sync data filename (the file name downloaded is different from the documentation so I was not sure which one is the correct one). Maybe the chain data was corrupted at that time.

Did you compare both files?

Hi @raymanyoung ,is this problem resolved?

Closed because we have not answer since May.


left and right side

Would be nice to have left and right sided refresh, for example for UIPageviewcontroller

As soon we can use it's scrollview like this:
    private var scrollView: UIScrollView {
        return view.subviews.first(where: { $0 is UIScrollView }) as! UIScrollView
    }

it shouldn't be very hard to implement


Add DMA APIs for count modes

There is no ability to configure the Count Modes field of the DMA`s CHx_TRANS_COUNT register for RP2350 - its processing is missing in the SDK API version 2.0.0.
From RP2350 datasheet:

File "~\.pico-sdk\sdk\2.0.0\src\rp2_common\hardware_dma\include\hardware\dma.h"
Actual code:
static inline void dma_channel_set_trans_count(uint channel, uint32_t trans_count, bool trigger) {
    if (!trigger) {
        dma_channel_hw_addr(channel)->transfer_count = trans_count;
    } else {
        dma_channel_hw_addr(channel)->al1_transfer_count_trig = trans_count;
    }
}

Expected code example:
static inline void dma_channel_set_trans_count(uint channel, uint32_t mode, uint32_t trans_count, bool trigger) {
    assert(mode == DMA_CH0_TRANS_COUNT_MODE_VALUE_NORMAL || mode == DMA_CH0_TRANS_COUNT_MODE_VALUE_TRIGGER_SELF || mode == DMA_CH0_TRANS_COUNT_MODE_VALUE_ENDLESS);
    assert(trans_count < (1 << DMA_CH0_TRANS_COUNT_MODE_LSB));
    if (!trigger) {
        dma_channel_hw_addr(channel)->transfer_count = trans_count;
    } else {
        dma_channel_hw_addr(channel)->al1_transfer_count_trig = trans_count;
    }
    dma_channel_hw_addr(channel)->transfer_count |= mode << DMA_CH0_TRANS_COUNT_MODE_LSB;
}

Also running into this issue — any workarounds for the time being? Or is this working on the development branch yet?
Or alternatively, is this something that needs help?

For what it's worth, this didn't work for me outside of the SDK:
 dma_channel_hw_addr(channel)->transfer_count |= mode << DMA_CH0_TRANS_COUNT_MODE_LSB;

I found that reading dma_channel_hw_addr(channel)->transfer_count (or dma_hw->ch[dma_chan].transfer_count in my code) always returned zero until after the channel was started / triggered, at which point updating the transfer count had no effect. I needed to set it before dma_channel_start(), but I couldn't read it until after dma_channel_start().
To avoid this issue, I ended up with something that just directly wrote the final value to transfer_count:
dma_channel_hw_addr(channel)->transfer_count = trans_count | mode << DMA_CH0_TRANS_COUNT_MODE_LSB;

Happy to write a PR for this, but it would be good to know if people think we should update dma_channel_configure too, since that is another common route for setting transfer_count?


CXBOX-397 Added JacksonConfig

Moved to core https://github.com/CX-Box/cxbox/pull/35, so this MR is cancelled


Add context with a simple builder

Built off of @meanphil's PR https://github.com/rbCAS/CASino/pull/126. Rather than use a request param, simply build the context using a Proc or lambda. This allows us to authenticate based on the requested host, because we use subdomains to silo users.

Closing because @meanphil merged my changes into his PR https://github.com/rbCAS/CASino/pull/126

Coverage increased (+0.02%) to 97.124% when pulling 8798094a015ef58436541c5bbbbcf782ec916c3b on identification-io:add_context into 41d71cd52a423730e5bdeedd9405f35aaaf0d435 on rbCAS:master.


Fix racy batching on the dispatcher

TIL that go timers are racy from #2669.   I noticed the dispatcher also calls Reset without ensuring that it's stopped or expired first, so added a similar fix.  (See https://github.com/golang/go/issues/11513)
dispatcher/heartbeat.go also has a Reset without calling Stop first, but this seems ok?  If an extra heartbeat gets triggered, that seems inexpensive and fine?

@cyli
Good catch! this is the second instance https://github.com/docker/swarmkit/pull/2669 where go timer messes up our logic.
We probably need to review every usage of timer in swarmkit

LGTM.
The code as-is should not be a major disruption. The worst case, as far as I can tell, is that we'll call Reset too late and end up immediately launching into another batch processing routine.


Upgrade Symfony to 3.4.35

This security release will protect us against the following vulnerabilities:
CVE-2019-18887: https://symfony.com/cve-2019-18887
CVE-2019-18888: https://symfony.com/cve-2019-18888
CVE-2019-18889: https://symfony.com/cve-2019-18889

Build fails on #814


How does hub get the git cached username and password?

Sorry to bother, but I want to do the exact same thing in a script of mine and I don't know how to. I'm using SSH, and I used the MacOSX keychain to store my credentials.

Hub uses your username & password to exchange it for an OAuth token using GitHub's "Authorizations" API. The process is made more complex because it needs to support two-factor authentication too. However, then it's done, it stores the OAuth token in ~/.config/hub. It never stores the actual password.


Release ipyelk 0.2.0

It's time for another ipyelk release!

[ ] bug fixes

[ ] #17 sprotty duplicate ID

[ ] merge features

[ ] #15 text resizer (bumps versions to 0.2.0 because of API changes)

[ ] infrastructure

[x] #20 🤖

[ ] update changelog
[ ] pick a funny new deer species
[ ] tag
[ ] release on

[ ] pypi
[ ] npm

[ ] handle conda-forge update
[ ] update release procedure with lessons learned

At the bottom of the page there are a list of deer species: https://animalsake.com/list-of-different-types-of-deer

In memoriam of the recent unpleasantness, perhaps from wikipedia:

Colombian red brocket (M. zetta; sometimes considered to be a subspecies of the red brocket)

Hope everybody's okay!

Hooray :shipit: https://github.com/jupyrdf/ipyelk/releases/tag/v0.2.0


Cannot open the SAPUI5 Visual Editor

Issue description

Feedback Type (Optional)
other
Page Title on SAP Help Portal (prefilled)
Access SAP Business Application Studio from VS Code
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/bas/sap-business-application-studio/working-remotely

I sent on information from the developers who are working to fix this issue in the upcoming weeks.


Errors in PowerShell 7+ for Form Dialogs

ShowDialog (Modal) in PowerShell 7+ for Common Dialogs is operating as Show, causing the function timer to overflow, causing an index error.
This is technically a trouble with PowerShell 7, but it won't hurt us to pause the timer.

My initial prognosis was incorrect, it also impacts opening projects as well. Should be able to cope with the trouble through errortrapping, but it will require a minor change to dependencies.ps1

My 2nd prognosis is also incorrect.
What's happening is that Microsoft.PowerShell.Utility and Microsoft.PowerShell.Management contain different functions between 5.1 and 7+, so the dependency list is incorrect.

I think we're going to switch methodologies to unchecked, I was already considering this.
"Considering unchecking imported functions, part of me says 'check, because they can be used without export',
the other part of me says 'uncheck, because they take up space in the xml data'."
The fact of the matter is they aren't truly dependencies, but rather functions that are normally available, but are only available because the module is loaded by default. They will work if they are checked or unchecked, but with the unchecked change users should consider checking the function when it is going to be used in the script more as a 'style guide' issue rather than a requirement.


UI bug : Pannel Led Output/Led Layout parameter Load/Edit/Save

[x] I confirm that this is an issue rather than a question.

Bug report
When i try to configure my led layout, UI Crash but parameter are stored,
when i reopen this pannel, "LED Layout Preview" is correct,  but when when click on "Classic Layout (LED Frame)" only basic information are correctly displayed (top, bottom,left,right) and pannel "LED Layout Preview" is resetted.
i must re-enter all time, values : "Gap length", "Gap position", "Input position" and "reverse direction"
Steps to reproduce

click on "Classic Layou"

What is expected?
to store and edit parameters.
What is actually happening?
System

Hyperion Server:

Build:           (HEAD detached at 2.0.0-alpha.10) (Paulchen-Panther-975f969/b1a4e95-1626550299)
Build time:      Jul 17 2021 21:50:25
Git Remote:      https://github.com/hyperion-project/hyperion.ng
Version:         2.0.0-alpha.10
UI Lang:         en (BrowserLang: fr-FR)
UI Access:       default
Avail Capt:      dispmanx,v4l2,framebuffer,qt
Database:        read/write

Hyperion Server OS:

Distribution:   Raspbian GNU/Linux 10 (buster)
Architecture:   arm
CPU Model:      ARMv6-compatible processor rev 7 (v6l)
CPU Type:       Raspberry Pi Zero W Rev 1.1
CPU Revision:   9000c1
CPU Hardware:   BCM2835
Kernel:         linux (5.10.52+ (WS: 32))
Qt Version:     5.11.3
Python Version: 3.7.3
Browser:        Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

@spiderjn Did this happend only once, or can you reproduce it?
In case the later, could you do a screenshot before you save the configuration and share it please?
Does a removal of cookies help?

it's reproductible, with 2 diff browser.
this is my configuration before click on SAVE

when i click on "save layout", UI restart on Hyperion splash screen and i'm back on this screen

but configuration is correctly generated.

@spiderjn Thanks for providing the additional details, with that I was able to reproduce the issue too.
We will have a look into it.


playlist sort popup doesn't remember selected sorting method

aural 2.2.0:

load a playlist
open the sort popup, select any method except "Track name"
reopen sort popup, "Track name" is selected.

Hi, thanks for the bug report.
The behavior you pointed out is how it was intended to behave. I didn't think it would be much of an inconvenience for users, because I assumed that sorting doesn't occur very often.
But, I'm guessing you find that inconvenient, so I will consider this a bug and keep it in mind for when I return to working on the project.
Cheers :)

This issue has been fixed in release v2.3.0.
Thanks again.


Use grid descriptors for workbench grid layout

[x] Create the grid based on descriptors
[x] Use moveView instead of addView and removeView.
[x] Clean up that huge overloaded layout() call. Layout should always be as cheap as possible. Currently it is doing much more, like adding views when they aren't there or updating their visibility.
[x] Make sure all view visibilities work
[x] Make sure all state is saved and restored

The layout call was way too overloaded with visibility state management. Lots of code pieces are calling layout() just because of that: eventually the grid state converged to what it should be. But there are many other code pieces which eventually call layout(), such as setEditorHidden(), so skipLayout was introduced.
Whenever a view toggles its visibility, we should never need to call layout at all. This is just extra unnecessary work. All these skipLayout flags should be deleted, simply because layout should never be called in these methods.

@joaomoreno totally agree on the layout calls, I had just been thinking on that this morning

@joaomoreno I pushed a commit. It works well. I think we can merge without regression but the grid still has some issues with cachedViewSizes.

Nice :ok_hand:
Feel free to merge


Reintroducing StringIndexOutOfBoundsException as the bug is fixed

This test should now run and pass on all JDK versions it's meant to
run against, as the upstream OpenJDK bug (JDK-8267773) is resolved
and backported, with the code fully propagated.
Signed-off-by: Adam Farley<EMAIL_ADDRESS>

Fix verified: https://ci.adoptopenjdk.net/job/Grinder/5550/console
That link proves that the test was reintroduced with this fix, and also verifies that the test now passes.

If this is reintroducing the test for all implementations, we need a Grinder to verify openj9 impl is also green.

FYI @llxia @Mesbah-Alam


Implement async data import with Django-Q

Setup instructions here.
Make load_data an asynchronous method, and schedule it to be run every 15 minutes in addition to whenever a device's data is requested.
Include a “downloading” field on the device to act as a lock so multiple refresh requests cannot be made simultaneously

UPDATE: Using Django-Q instead of Celery, because it's better suited for this task


HDDS-2272. Avoid buffer copying in GrpcReplicationClient

What changes were proposed in this pull request?
Eliminate BufferedOutputStream, write ByteString directly to FileStream to avoid a buffer copy.
Also, use ByteString.writeTo(OutputStream), although it still seems to copy the byte array internally.
https://issues.apache.org/jira/browse/HDDS-2272
How was this patch tested?
Tested closed container replication manually with a 300MB container.  Verified that container is correctly replicated to other datanode.

@szetszwo please review

+1 the change looks good.

@bharatviswa504 can you take a look at the TestOzoneManagerDoubleBufferWithDummyResponse failure? Does the test need to be fixed?

Committing it to the master. Thanks @adoroszlai the patch and @szetszwo the review.

Thanks @szetszwo for reviewing and @elek for committing it.  Also thanks @arp7 and @bharatviswa504 for checking the test issue.


Upgrade Byte Buddy 1.15.10 -> 1.15.11

This PR contains the following updates:

Package
Type
Update
Change

Byte Buddy (source)
compile
patch
1.15.10 -> 1.15.11

Release Notes

raphw/byte-buddy (Byte Buddy)
v1.15.11

Avoid dependency of CachedReturnPlugin on precompiled class files.
Add NOP instruction when Advice is used on void methods as those might be empty which results on a frame being written to the same offset, causing an exception.
Allow Plugin.Enging to link files instead of copying.
Adjust validator code to avoid compiler bug that was reported by multiple users.
Allow injection of class path as File[] to Plugin constructors.
Allow for configuring variants when using the Android Gradle plugin.

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Byte Buddy 1.15.10 -> 1.15.11

See:
- https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.15.11
- https://github.com/raphw/byte-buddy/compare/byte-buddy-1.15.10...byte-buddy-1.15.11


Add mobile-bert f16 version to Mako benchmark.

This only runs on S20 GPU. The batch_size=1 because the current benchmarking mechanism does not reflect real performance. See https://github.com/google/iree/issues/5248

~80 ms looks like a wrong number. It seems that there is a bug on ToT. @ThomasRaoux will investigate it (and probably add more tests).
https://buildkite.com/iree/iree-android-benchmark/builds/2137

Tested in https://buildkite.com/iree/iree-android-benchmark/builds/2220
The result can be found in log


App crashes silently when screenshot is taken

Environment
App version:  1.2.2
Android version:  Android 9.0 API 28
Device information:  Pixel 3 XL
Description
when webpage https://haikusushi.pl/products.html is loaded and I want to take screenshot of it, app crashes without any information
Steps to reproduce

Open https://haikusushi.pl/products.html using  InAppWebView by passing the url as initialUrl
Take screenshot using controller

I get the same error on:
Pixel 3 XL API 28 - Adroid 9.0 x86
Pixel 3 XL API 29 - Adroid 10.0 x86
The problem doesn't appear on
Pixel 3 XL API 25 - Adroid 7.1.1 x86

The same problem appears on:
https://www.pyszne.pl/tandoori-flame#kategoria_Najpopularniejsze_dania
However everything is fine for:
http://www.restauracjawarsztat.pl/pl/ul.-miodowa-20/menu-miodowa.html

Try the latest version of the plugin 2.0.0 and let me know. Thanks

Can you share also the code that you are using, please? I have tested your URL and I can take screenshots.

Thank you for your response. I will check it in next week and if it doesn't work with the newest version I will share the code with you.


[delegate-registry-v2] Add the delegate registry v2 startegy

Add the delegate-registry-v2 strategy.

@manboy-eth We need to add this strategy to src/strategies/index.ts

@manboy-eth Can take a look at failing test cases, try running `yarn test --strategy=delegate-registry-v2 in your local

@manboy-eth Can take a look at failing test cases, try running `yarn test --strategy=delegate-registry-v2 in your local

I appreciate your help, @ChaituVR.
I am a little unsure how to proceed. Here's how the voting strategy is supposed to work:

Our backend (https://delegate-registry-backend.vercel.app) will return the amount that is delegated to an address, provided the address is not delegating further.
This result is merged with other strategies in the Snapshot space, such as erc20-balance-of.
We plan to add a validation strategy that ensures only addresses that are not delegating can vote.

Does this approach make sense, or should we structure it differently? Is there a way to automatically force a space to enable a validation strategy if a voting strategy is enabled?
Also, since the strategy has to return at least one address with a score, is it possible to select what snapshot space should be used in the test? If not, could someone send some tokens (the ones referenced in the yam.eth's voting erc20 strategy) to 0xD028d504316FEc029CFa36bdc3A8f053F6E5a6e4? This would allow me to make a delegation for the yam.eth space.

Hi @manboy-eth

Does this approach make sense,

Makes sense, but also you could return 0 voting power from this strategy itself and use this strategy in basic validation and check min score. https://docs.snapshot.org/user-guides/strategies/validation-strategies#voting-validation-in-space-settings then we don't need separate validation

is there a way to automatically force a space to enable a validation strategy if a voting strategy is enabled?

There is no way to force, spaces should enable validation if they want to (maybe you can add this in README)

since the strategy has to return at least one address with a score, is it possible to select what snapshot space should be used in the test?

You can easily create one on demo.snapshot.org, using goerli. it should be free :)

Makes sense, but also you could return 0 voting power from this strategy itself and use this strategy in basic validation and check min score. https://docs.snapshot.org/user-guides/strategies/validation-strategies#voting-validation-in-space-settings then we don't need separate validation
I am not sure how I can make that work, since we need to be able to distinguish token holders who have delegated and token holders who have not delegated (but still has a score, from other strategies). In both cases, one or more other strategies in the space will return a non-zero value.

I need a validation strategy that can make it possible to vote as long as the delegation registry strategy does not return "0".
I think we have three scenarios (numbers 2 and 3, can probably be counted as the same):

When the strategy returns 0 it should not be possible to vote - the address has delegated
When the strategy returns undefined  it should be able to vote merging all the scores in the space - the address has not delegated and has no delegators delegating to it.
When the strategy returns a number it should be able to vote merging all the scores in the space - the address has delegations to it and possible a score from other strategies in the space.

There is no way to force, spaces should enable validation if they want to (maybe you can add this in README)
Okay.

You can easily create one on demo.snapshot.org, using goerli. it should be free :)
I meant the space used in the tests when I run yarn test --strategy=delegate-registry-v2 it looks like it is hardcoded to use the yam.eth space.

I created and added the required validation strategy.

Hi @manboy-eth I meant adding basic validation directly to your space 😅 Don't have to create a seperate validation

Hi @manboy-eth I meant adding basic validation directly to your space 😅 Don't have to create a seperate validation

But the problem is that basic validation does not work for our requirements (check the comment above: https://github.com/snapshot-labs/snapshot-strategies/pull/1205#issuecomment-1658076977).
Because of this, we had to create a new validation strategy.

oh i get it now, thanks!
But what will be the voting power if delegate-registry-v2 returns 0 ? 🤔

Can't depend on undefined from strategies, better if strategy can decide on who got voting power or who don't have voting power

@manboy-eth it seems like we should just encapsulate everything in the delegation strategy, perhaps?
So rather than the current setup, where there is a delegation strategy alongside any number of other strategies...
"strategies": [
    {
      "name": "gno"
    },
    {
      "name": "delegation",
      "params": {
        "strategies": [
          {
            "name": "gno"
          }
        ]
      }
    },
]

Perhaps everything should be encapsulated by the delegation strategy. This way there is no need for additional validation outside of the strategy.
"strategies": [
    {
      "name": "delegation",
      "params": {
        "strategies": [
          {
            "name": "gno"
          }
        ]
      }
    },
]

oh i get it now, thanks!
But what will be the voting power if delegate-registry-v2 returns 0 ? 🤔

Then the address has delegated its voting power and should not be able to vote.

This is the way it currently works:

undefined means "address not in the registry",
0 means, address have delegated and
a positive number is the number of votes delegated to the address.

Regarding @auryn-macmillan 's suggested approach:

@ChaituVR: Can you make the UI for setting up and managing strategies handle this?
@ChaituVR: Does this have any impact on your caching systems etc.?
Just to make sure I understand, then we would compute everything like we do today but with two adjustments:
a. When retrieving strategies during the creation of a snapshot, we will get it from the internal strategy settings.
b. When returning the vote weight, we get our snapshot of vote weights from the delegation registry, then we get the vote weight from each strategy, merge the vote weights as intended, and return the results.

undefined means "address not in the registry",
0 means, address have delegated and
a positive number is the number of votes delegated to the address.

Better to handle this in strategy itself

@ChaituVR: Can you make the UI for setting up and managing strategies handle this?

Sure, create a ticket on https://discord.snapshot.org/ will get in touch to create a test space for you

@ChaituVR: Does this have any impact on your caching systems etc.?

Using a delegation strategy won't have any impact on caching

Just to make sure I understand, then we would compute everything like we do today but with two adjustments:
a. When retrieving strategies during the creation of a snapshot, we will get it from the internal strategy settings.

Correct, whenever a proposal is created - we copy strategies to the proposal so it will use these strategies for ever

b. When returning the vote weight, we get our snapshot of vote weights from the delegation registry, then we get the vote weight from each strategy, merge the vote weights as intended, and return the results.

didn't get it sorry 🙈

It sounds like we might have some miscommunication, so I just have to make sure we are on the same page before I start working on this:
So if I create a ticket in Discord, you will make the user interface for configuring any snapshot strategy inside of our strategy settings like Auryn proposes here: https://github.com/snapshot-labs/snapshot-strategies/pull/1205#issuecomment-1705795709. This seems like a potentially big and complicated task to me 🤔
After you work on the user interface, users will be able to manage strategies (add, remove, or edit settings) nested inside our strategies params. This setting will not be at the normal strategy configuration location strategies but will rater be located inside of our strategy configuration like this strategies[0].params.strategies (the index is 0 because it will always be only one top-level strategy when the delegation registry strategy is added - the delegation registry strategy).
In other words, you will handle all these special cases (only applicable to the delegation registry strategy):

When the delegation registry strategy is added to a space, the preexisting strategies will be moved inside of the delegation registry's params settings.
When the delegation registry is removed, all the strategies inside of the delegation registry's params settings will be placed back in the top-level strategy location.
When a strategy is added to a space with the delegation registry strategy already added, it will be added under the delegation registry's params. strategies`?
and so on.

This way we will be able to do all the vote weight computations for all strategies in the space, inside of our strategy.

I am sorry but i am having a hard time understanding your requirements, What interface you are talking about? Can you explain me an example situation of how you want to calculate your voting power?

I am sorry but i am having a hard time understanding your requirements, What interface you are talking about? Can you explain me an example situation of how you want to calculate your voting power?

We wonder if we can have all the strategies inside of our strategy like @auryn-macmillan suggested (look at the strategy configuration he has suggested in his comment here: https://github.com/snapshot-labs/snapshot-strategies/pull/1205#issuecomment-1705795709).
I am talking about the user interface / GUI / frontend at "https://snapshot.org", and what I think would be required if we were going to do it as @auryn-macmillan suggested.

I don't think this necessarily requires UI changes in order to function as intended.
With the existing UI, you should already be able to configure the delegation strategy.

I think that works for the time being, we can improve on it in a subsequent PR.


Mismatch between tutoriel and doc

Describe the bug
In the "Process text data" tutorial, map has return_tensors as kwarg. It does not seem to appear in the function documentation, nor to work.
Steps to reproduce the bug
MWE:
from transformers import AutoTokenizer
tokenizer = AutoTokenizer.from_pretrained("bert-base-cased")

from datasets import load_dataset
dataset  = load_dataset("lhoestq/demo1", split="train")

dataset = dataset.map(lambda examples: tokenizer(examples["review"]), batched=True, return_tensors="pt")

Expected results
return_tensors to be a valid kwarg :smiley:
Actual results
>> TypeError: map() got an unexpected keyword argument 'return_tensors'

Environment info

datasets version: 2.3.2
Platform: Linux-5.14.0-1052-oem-x86_64-with-glibc2.29
Python version: 3.8.10
PyArrow version: 8.0.0
Pandas version: 1.4.3

Hi, thanks for reporting! This line should be replaced with
dataset = dataset.map(lambda examples: tokenizer(examples["text"], return_tensors="np"), batched=True)

for it to work (the return_tensors part inside the tokenizer call).

Can I work on this?

#self-assign


test-branch/execute-job/comment-from-wrong-user-on-pr/d6475952-a074-4a9b-93eb-d08d5aedd6cf

PR for testing 2eca5a2190f13b49651eb06408bc8b9c30b78cc6

/canonical/self-hosted-runners/run-workflows 2eca5a2190f13b49651eb06408bc8b9c30b78cc6


Added summary for entries' size

Entries could be rather different in size between projects. This is why it's a summary instead of a histogram.

Squashed and landed this change on the master branch.


Remove skrifa from vello's public API

The motivation for this is two-fold:

To align vello's representation of "normalized coordinates" with that of swash/parley (avoiding a boilerplatey conversion when integrating parley with vello)
To make skrifa version bumps in vello non-breaking changes.

Note this type is still visible from vello_encoding: https://github.com/linebender/vello/blob/e6ead09604d9b64229577f039883dfb4df598997/vello_encoding/src/encoding.rs#L548
This is a bit more tricky because skrifa actually wants a &[NormalizedCoord] type. We can either keep an internal buffer in the resolver and do a copy or just use bytemuck to cast the slice (font_types::F2Dot14 impls the necessary traits)

@nicoburns Can we wrap this one up and land it? I'd like to make sure this is in our upcoming release.

How much do we still care about this being public in vello_encoding? Seems to me that it's probably less important to do semver compatible releases there? It's easy enough to change everything to i16, but it involves changing a lot of the internal uses of NormalizedCoord into i16 which seems like somewhat of a code quality regression from a readability / type safety point of view.

I don't hate making vello_encoding intentionally not follow semver, but we'd need to do two things:

Document that being the case
Use an = dependency specification on it from Vello.

I don't hate making vello_encoding intentionally not follow semver, but we'd need to do two things:

Document that being the case
Use an = dependency specification on it from Vello.

My suggestion would be for vello_encoding to continue to follow semver, but to aggressively bumping it's version number beyond that of the main vello crate's (as required). I feel like "you're using the low-level API, so you have to deal with breaking changes more often" is kinda reasonable, especially if the "breaking change" is just a dep bump. Also, I believe most users of vello_encoding are unlikely to have large crates.io dep trees. So conflicting versions is likely to be less of an issue.

Looking again, I'm not sure that would be practical; Vello itself exposes vello_encoding as public API. I don't know the right answer here

I'd probably suggest making our own NormalizedCoord type, and then as Chad says, using bytemuck as/when needed.


[Key paths] Map Hashable conformances for subscript indexes out of context

SILGen et al were expecting interface types, so make sure that's how we
record them. Fixes rdar://problem/46632723.

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please smoke test and merge


2/26/2024 2015 FRQ Connections

In Progress

FRQ 1
FRQ Grade
.9/.9
Completed all parts of FRQ, showed me personally that parts of it ran on computer. Used interesting method for final FRQ using a hashset to store integers, allowing him to just add to the set which has a built in check to see if the integer is unique. Minimal reflection on FRQ topics.
Association Grade
N/A
FRQ 2
FRQ Grade
.8/.9
Completed all parts of FRQ, showed me personally that parts of it ran on computer but missing outputs on blog. Minimal reflection on FRQ topics.
Association Grade
N/A
FRQ 3
FRQ Grade
.8/.9
Completed all parts of FRQ, showed me personally that parts of it ran on computer but missing outputs on blog. Minimal reflection on FRQ topics.
Association Grade
N/A
FRQ 4
FRQ Grade
.9/.9
Completed all parts of FRQ, showed me personally that it ran on his computer. Minimal reflection on FRQ topics.
Association Grade
N/A
Total Grades:
FRQ: 3.4/3.6
Associations: N/A

Frq grading
Question 1
0.9/0.9 You meticulously craft a succinct overview of the solutions, ensuring they meet the criteria outlined in the FRQ. Your response reflects a thoughtful analysis of the task at hand, with a discernible reflection evident in your conclusion. Furthermore, by showcasing a heightened level of insight and understanding, you may be eligible for additional credit, demonstrating a mastery of the subject matter.
Question 2
0.9/0.9 Same as question 1. You have effectively articulated your insights gained from this FRQ and demonstrated your growth throughout the process.  The code you've presented is well-structured and exhibits a depth of understanding, suggesting minimal reliance on ChatGPT for assistance. However, it would be advantageous to include the essential concepts relevant to this FRQ for a more comprehensive response.
###Question 3
0.9/0.9. you have completed all of the requirements like the previous questions. The outcome for the code matched the requrirments on this frq. But I don't know what getNumCols() and getNumRows work for the entire code. I think it would be much better if you writes the explanation for that.
Question 4
He did what the FRQ asked, but didn't do extra. I wish he had explained the key algorithm and FRQ type better, but we had a good discussion, even though we were confused at first about the type. I think he should get slightly more than 90% because he communicated well about the FRQ and we had a good discussion.
Association Grading
Overall point

Good explanation of code
Decent examples, expected a little bit more maybe
Not enough context of the FRQ code itself
Should be making more direct comparisons between PBL and CB.

I like how you applied array tasks in both contexts and the code snippet demonstrates your understanding of arrays, JSON parsing, and HTTP communication, highlighting practical usage within your application for handling structured data from APIs, but there should have been more emphasis on what the FRQ is about, not veering a little too much off course. You also showed good ideas in class design and database mapping, I like how you talked about the Chat class for JPA mapping and its methods for JSON conversion. The controller methods showcase your ability to implement RESTful API endpoints for managing chat history, employing techniques such as deleting and retrieving data based on specific criteria, but you did not explain the . Your explanation of control structures and techniques used in your project, like preventing indefinite loops, indicates thoughtful consideration of program flow and error handling for a robust application.


Modify websocket definition

Change the web socket definition so it can work in Liberty and on Spring.

LGTM


TypeError: object of type 'NoneType' has no len() while using shap on keras

Hi,
I am using Keras and my model is LRCN (a combination of CNN + LSTM).
You can see my code here:
https://github.com/AmirHoseinSafari/LRCN-drug-resistance/blob/master/models/Bayesian_optimizer.py
I am trying to run it this way:
    X_train2 = tf.cast(X_train, tf.float32)
    X_test2 = tf.cast(X_test, tf.float32)
    X_val2 = tf.cast(X_val, tf.float32)
    y_train2 = tf.cast(y_train, tf.float32)
    y_test2 = tf.cast(y_test, tf.float32)
    y_val2 = tf.cast(y_val, tf.float32)

model.compile(
    loss=masked_loss_function,
    optimizer='Adam',
    metrics=[masked_accuracy]
)

history = model.fit(
    X_train2,
    y_train2,
    epochs=epochs,
    batch_size=128,
    verbose=2,
    validation_data=(X_val2, y_val2)
)

shap.initjs()

explainer = shap.DeepExplainer(model, X_train2[:100])
shap_values = explainer.shap_values(X_test2[:10])
shap.summary_plot(shap_values, X_test2, plot_type='bar')`

My model is something like:
model = Sequential()
model.add(Dropout(dropout2_rate))
model.add(Conv1D(filters=filterCNN1, kernel_size=kernelCNN1, activation='relu', padding='same'))
model.add(MaxPooling1D(pool_size=poolCNN1, padding='same'))
model.add(LSTM(LSTM1, return_sequences=False, recurrent_dropout=0.3))
model.add(Dropout(dropout2_rate))
model.add(Dense(dense_1_neurons))
model.add(Dropout(dropout2_rate))
model.add(Dense(12, activation='sigmoid'))

I am getting this error and I couldn't find any way to resolve it. Could you please help me with this?
Here is the error:

keras is no longer supported, please use tf.keras instead.
Traceback (most recent call last):
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/pipe_line_gene.py", line 31, in
train()
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/pipe_line_gene.py", line 14, in train
model_gene_based.run_bayesian(df_train, labels)
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/models/model_gene_based.py", line 578, in run_bayesian
Bayesian_optimizer.BO(X_train, X_test, X_val, y_train, y_test, y_val, limited, portion)
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/models/Bayesian_optimizer.py", line 343, in BO
<IPython.core.display.HTML object>
fit_with_partial(dropout2_rate=0.2, dense_1_neurons_x128=1, dense_2_neurons_x128=1, dense_3_neurons_x128=1,
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/models/Bayesian_optimizer.py", line 192, in fit_with
return run_one_fold(model)
File "/Users/amir/PycharmProjects/Lab/LSTM-DR/LSTM-drug-resistance/models/Bayesian_optimizer.py", line 250, in run_one_fold
explainer = shap.DeepExplainer(model, X_train2[:100])
File "/Users/amir/venv/p3/lib/python3.8/site-packages/shap/explainers/_deep/init.py", line 84, in init
self.explainer = TFDeep(model, data, session, learning_phase_flags)
File "/Users/amir/venv/p3/lib/python3.8/site-packages/shap/explainers/_deep/deep_tf.py", line 97, in init
self.model_output = _get_model_output(model)
File "/Users/amir/venv/p3/lib/python3.8/site-packages/shap/explainers/tf_utils.py", line 83, in _get_model_output
if len(model.outputs) > 1:
TypeError: object of type 'NoneType' has no len()

Hello @AmirHoseinSafari.
Full disclosure: I'm not working in the development of this library, so take what I say with a grain of salt.
I've been following this for a little while now, and, assuming you're using TF >= 2.0, as far as I can tell (see: https://github.com/slundberg/shap/issues/885, https://github.com/slundberg/shap/issues/1198, https://github.com/slundberg/shap/issues/1581),  DeepExplainer has not supported TF/Keras >= 2.0 for a year.
In the meantime I found this: https://stackoverflow.com/questions/47940040/how-to-set-input-shape-of-a-trained-model-in-keras , and it might "fix" it, but I haven't tried yet. If you do, please let me know how it went.
I hope this clarifies.
Best regards,

Hello @AmirHoseinSafari.
Full disclosure: I'm not working in the development of this library, so take what I say with a grain of salt.
I've been following this for a little while now, and, assuming you're using TF >= 2.0, as far as I can tell (see: #885, #1198, #1581), DeepExplainer has not supported TF/Keras >= 2.0 for a year.
In the meantime I found this: https://stackoverflow.com/questions/47940040/how-to-set-input-shape-of-a-trained-model-in-keras , and it might "fix" it, but I haven't tried yet. If you do, please let me know how it went.
I hope this clarifies. Best regards,

Hi  I was passing a tf.keras subclassed  model to the explainer and getting the same error. I tried the solution from stackoverflow you suggested and in my case is working :). Thanks a lot !


go1.18: Preserve trailing tabs while massaging go version -m output

Allows ko on both go v1.17 and v1.18 to parse go version -m output that contains a local replace directive. For example:
./main: go1.18
	path	command-line-arguments
	dep	secret.dev/api	v0.0.0-00010101000000-000000000000
	=>	../api	(devel)

The issue is that ParseBuildInfo assumes there is a 3rd column that contains a checksum, which is not applicable to local replace directives. This patch inserts the extra tab, allowing it to have an empty checksum.
Fixes #666

https://github.com/google/ko/blob/main/internal/sbom/sbom.go#L29

Ooh, I didn't notice massageBuildInfo before. Not only is the perfect place to implement this, but uhh.. it apparently the source of the bug too! I'll revise the patch.

Ooh, I didn't notice massageBuildInfo before. Not only is the perfect place to implement this, but uhh.. it apparently the source of the bug too! I'll revise the patch.

Oh no. 😭

Thanks again for the massageBuildInfo tip. This PR has been updated to address the root cause rather than putting lipstick on the pig. :)

Codecov Report

Merging #668 (256f31a) into main (327a88f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   51.62%   51.62%
=======================================
  Files          44       44
  Lines        3268     3268
=======================================
  Hits         1687     1687
  Misses       1371     1371
  Partials      210      210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327a88f...256f31a. Read the comment docs.


busybox: patching CVE-2022-28391.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

Patching CVE-2022-28391 in busybox.
Change Log

Ported CVE-2022-28391 fix from 1.0-dev.

Does this affect the toolchain?

No.
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-28391

Test Methodology

Local package build.

Adding reference to 1.0's commit - https://github.com/microsoft/CBL-Mariner/commit/73d36e8beb0e50d3c403073132b2940d123a85ec


Explorer DC balance for router show invalid value

As it has been detailed in this router issue - https://github.com/helium/blockchain-core/issues/763
The explorer does not report the right DC balance for the router wallets.
basically, when a state channel is closed, the blocked DC amount is released but not in the explorer DC balance.
The Packet transfer operation does not update the explorer DC amount also
exemple for 11awcuSbVURPkXX3FbKC7KF6bgEPRZqqPzv1FTEYABMLttUr13E
on April 7th, explorer DC balance is 15,563,887 DC but the real wallet is 15,663,698 DC
Difference between two numbers (99811)  explained by:

100 000 corresponding to the DC_CHANNEL_AMOUNT free by state channel not counted
189 corresponding to the DC consumption due to communications

It seems that the DC balance is resync on token burn transactions

This is an etl/api issue. Moving there


Malware in scrypt-shim dependency used here.

Security Threat
In the current verison of  Trader Joe sdk there is a dependency called<EMAIL_ADDRESS>which is no longer being developed and needs to be upgraded urgently. The reason is that it has dependencies that result in the installation of scrypt-shim@github:web3-js/scrypt-shim . This package   contains malicious code and presents a high risk security threat and should be removed as soon as possible.
scrypt-shim : npmjs has flagged this as well.

Addressed in this PR https://github.com/traderjoe-xyz/joe-sdk/pull/40


[BUG] missing short echo door recipe

Thank you for reporting!
For issues:

If the issue seems to affect only one mod, report to them instead of here.
Remove Dramatic Doors to see if they are causing the issue before reporting.
If you crashed, please paste the crash log to gist and link it here.

Important Information
Minecraft Version: 1.20.1
Mod Loader System: Fabric
DramaticDoors Version: 1.20.1-3.0.3
Describe the bug
with Deeper and Darker installed, there is a missing stonecutter recipe for a short echo door added by this mod, created from Deeper and Darker's normal echo door.
To Reproduce

Load the game with Deeper and Darker installed
place an echo door from that mod into a stonecutter, or inspect it or the short echo door in a mod like REI, and note the missing recipe

Expected behavior
the short echo door would be craftable
Screenshots
n/a

Fixed as of version 3.1.0 of Dramatic Doors for 1.19.2. Fix will be ported over to 1.20.1.


Add ERC721 diamond

[ ] Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
[x] Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
[ ] This PR is just a minor change, like a typo fix.

Please update 2 package.jsons versions. Let's use 2.6.5


CI: PANIC  package: github.com/cilium/cilium/daemon/cmd

CI failure
saw this failure in travis CI: https://app.travis-ci.com/github/cilium/cilium/jobs/589683447
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃   PANIC  package: github.com/cilium/cilium/daemon/cmd • Test   ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

panic: send on closed channel

goroutine 723 [running]:

github.com/cilium/cilium/pkg/identity/cache.(*localIdentityCache).release(0x4000624d80, 0x4000710340)
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/identity/cache/local.go:139 +0x148
github.com/cilium/cilium/pkg/identity/cache.(*CachingIdentityAllocator).Release(0x400051daa0, {0x325eb40, 0x4001126660}, 0x4000710340, 0x6f?)
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/identity/cache/allocator.go:427 +0x2bc
github.com/cilium/cilium/pkg/ipcache.(*IPCache).releaseCIDRIdentities(0x4000fd5300, {0x325eb40, 0x4001126660}, {0x4000710600, 0x2, 0x400171ee00?})
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/ipcache/cidr.go:220 +0x208
github.com/cilium/cilium/pkg/ipcache.(*asyncPrefixReleaser).run(0x4000783270, {0x325eb40, 0x4001126660}, {0x400171edf0, 0x1, 0x1})
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/ipcache/gc.go:103 +0x1ac
github.com/cilium/cilium/pkg/ipcache.newAsyncPrefixReleaser.func1({0x400171edf0, 0x1, 0x1})
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/ipcache/gc.go:53 +0x84
github.com/cilium/cilium/pkg/trigger.(*Trigger).waiter(0x4000a15c20)
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/trigger/trigger.go:201 +0x45c
created by github.com/cilium/cilium/pkg/trigger.NewTrigger
        /home/travis/gopath/src/github.com/cilium/cilium/pkg/trigger/trigger.go:122 +0x1b8

FAIL    github.com/cilium/cilium/daemon/cmd     11.814s

it's from this pull request: https://github.com/cilium/cilium/pull/22409 this pull request only touches hubble L7 parser, so i don't think the failure is caused by this change 🤔

Dup of https://github.com/cilium/cilium/issues/21852.


Refactor  into a  component that encapsulates both existing styles

Right now we have two styles for out <blockquote>'s:

Default

Centered:

They are controlled via the is--centered class. Let's move this into a <Quote> component that changes styles based on prop values.

Done!


Added visual examples of ampeg_attack_shape

Intended to better stimate and understand how these values work.

Can you fix the url links please? (sin -> sine)

Thanks and sorry for the delay, I'll apply only some change later to make the images smallest.


Add zIndex prop

@nikitabuyevich I think it would be better if a style prop is added instead of a lone zIndex prop. With this, users can add more style to the component as a whole instead of having to specify each style property as a different prop...


Add button to copy the result

Add button to copy the result

Created. (temporary solution). Because the final solution uses flash :(

Done !


征集 Scrcpy Mask 的图标设计稿 Seeking App Icon Design Contributions

Hello everyone,
I'm currently in the process of developing this app and seeking contributions for the design of our app icon.
I believe that a captivating and distinctive icon is essential for making a lasting impression in today's crowded app marketplace.
I'm look forward to seeing your creative ideas and thank you in advance for your contributions!
Best regards,
AkiChase

总之就是征集 Scrcpy Mask 的图标设计稿，有想法的欢迎联系我

Thanks for your contribution! I prefer the first icon and I have used it for Scrcpy Mask v0.6.0.
Of course, if you have any better solutions for icons, feel free to keep talking!


Fix INTERFACE_INCLUDE_DIRECTORIES

Fix #319 .
This patch also updates testing document.
It turns out to be a mistake I made in https://github.com/KjellKod/g3log/pull/312 .
In that PR, I changed these lines:
   INSTALL( TARGETS g3logger
            EXPORT g3logger-targets
               ARCHIVE DESTINATION ${CPACK_PACKAGING_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
               LIBRARY DESTINATION ${CPACK_PACKAGING_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
               COMPONENT libraries)

to:
INSTALL( TARGETS g3logger
   INSTALL( TARGETS g3logger
            EXPORT g3logger-targets
            ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
            LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
            INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
            COMPONENT libraries)

but I forgot to take of COMPONENT .
COMPONENT libraries  should be together with LIBRARY/ARCHIVE/RUNTIME, but not with INCLUDES.
And this mistake causes INTERFACE_INCLUDE_DIRECTORIES to be set incorrectly in g3loggerTargets.cmake:
set_target_properties(g3logger PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_variable_templates"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/COMPONENT;${_IMPORT_PREFIX}/libraries"
  INTERFACE_LINK_LIBRARIES "Threads::Threads;dbghelp"
)

which, instead, should be set as:
set_target_properties(g3logger PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_variable_templates"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "Threads::Threads;dbghelp"
)

The COMPONENT is useful when you want to create a package that give the users some options to choose which components should be installed and which should not. For example, when I create a NSIS package of g3log on Windows and run the installer, I will get this:


Reset Ready condition when update failed

This ensures the Ready Condition is reset when CR becomes once ready but something fails during reconfiguration.

/retest

/retest

/test cinder-operator-build-deploy-kuttl

/retest


Upgraded to Stickyfill 1.1.3

Upgraded to the latest Stickyfill script. Fixes #1

Would love to see this as well :-)

Good to see this.

:+1: and the latest version is now 1.1.4

1.1.4 only has upstream packaging changes that do not affect the npm package. @coreh can we get 1.1.3 published on npm please?

I published a scoped 1.1.4 package here: https://www.npmjs.com/package/@rq/stickyfill


Update test instructions and build

Adding things to the README which I needed to do in order to run the full test suite

Create test database
Copy some scripts from .travis.yml to the README

Also, this moves phpunit.xml to phpunit.xml.dist, and gitignores phpunit.xml. Doing that allows local customization of the phpunit configuration in phpunit.xml. The explicit specification of the config file in .travis.yml is also not needed
More info on the config file names and fallback is here; unfortunately there is no link directly to that option

Thanks @yitznewton!