iOS privacy manifest required

This plugin is listed on https://developer.apple.com/support/third-party-SDK-requirements/ as requiring a privacy manifest. Some action will be required, either to clarify with Apple whether this plugin should be on the list, or to add a privacy manifest.
See https://github.com/flutter/flutter/issues/131940 for context.

Ok thanks a lot! Not yet but I’m replying to them right now to ask more about it! I will let you know if I have any news 👍

@pichillilorenzo
Nice to meet you, I have always been a fan of this plugin. Thank you very much.
This plugin uses OrderedSet, and OrderedSet seems to be included in the list that needs to be addressed.
https://developer.apple.com/support/third-party-SDK-requirements/
After the PrivacyManifest support is completed on the OrderedSet side, do we need to incorporate it into flutter_inappwebview as well?
If so, please let me know.
Please let me know if my understanding is incorrect.
I have created an issue on OrderedSet. I would like to create a PR if I have time...
https://github.com/Weebly/OrderedSet/issues/41

@ueman yes, I think it should be that.
Did the Flutter team already made an example for their plugins?

Yes, see https://github.com/flutter/packages/pull/5846

Thanks, I will look to that as soon as possible 👍

@pichillilorenzo Is there really a pressing need to use the OrderedSet plugin?

hello, the deadline is approaching, Is there any new development?

Hi @pichillilorenzo any update from your side for this issue? thank you for your time.

Hello, @pichillilorenzo I hope you're doing well. Any updates? Thanks for your great work on this project!

OrderedSet just released new version with PrivacyInfo, so the version of dependency could be raised also

Is this actually a screening process if it is not addressed?

Will this actually be rejected by Apple in the review process if it is not addressed?
Please let me know if you have any actual experience.

Individual experience on this is likely to vary:

Anyone building their Pod dependencies statically won't have issues, because this plugin and OrderedSet won't appear as frameworks in the final binary in that case.
In this update there is new language about the enforcement saying that it applies to "new or updated apps that have a newly added third-party SDK", so it doesn't sound like anyone already shipping an app using this plugin would be affected.

(It's also not actually clear that the plugin currently needs a privacy manifest, or if just updating the OrderedSet dependency will be enough. https://developer.apple.com/support/third-party-SDK-requirements/ lists flutter_inappwebview, not flutter_inappwebview_ios, whereas for most other plugins with a federated iOS implementation it is the implementation package that is listed. Given that, it's possible that only older versions of the plugin with the iOS implementation inline would currently trip the validation check, since for a build with a current version there would never be a flutter_inappwebview.framework in the build.)

Has this issue been resolved yet?

Thus far, my product has been successfully released without any rejections or further requirements from App Store Connect. We can address this issue only if it becomes relevant during the review process or if App Store Connect requests changes.

@phuc-tranh-otsv phu
I meet an issue about the 'Missing privacy manifest' of flutter_inappwebview
App Store Connect
Hello,
We noticed one or more issues with a recent submission for App Store review for the following app:
'App Name'
Version 2.2.24
Build 216
Although submission for App Store review was successful, you may want to correct the following issues in your next submission for App Store review. Once you've corrected the issues, upload a new binary to App Store Connect.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseAuth.framework/FirebaseAuth”, which includes FirebaseAuth, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseCore.framework/FirebaseCore”, which includes FirebaseCore, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseCrashlytics.framework/FirebaseCrashlytics”, which includes FirebaseCrashlytics, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseDynamicLinks.framework/FirebaseDynamicLinks”, which includes FirebaseDynamicLinks, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseMessaging.framework/FirebaseMessaging”, which includes FirebaseMessaging, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/Flutter.framework/Flutter”, which includes Flutter, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/OrderedSet.framework/OrderedSet”, which includes OrderedSet, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/connectivity_plus.framework/connectivity_plus”, which includes connectivity_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/device_info_plus.framework/device_info_plus”, which includes device_info_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/file_picker.framework/file_picker”, which includes file_picker, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/flutter_inappwebview.framework/flutter_inappwebview”, which includes flutter_inappwebview, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/flutter_local_notifications.framework/flutter_local_notifications”, which includes flutter_local_notifications, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/nanopb.framework/nanopb”, which includes nanopb, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/package_info.framework/package_info”, which includes package_info, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/package_info_plus.framework/package_info_plus”, which includes package_info_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/share_plus.framework/share_plus”, which includes share_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/video_player_avfoundation.framework/video_player_avfoundation”, which includes video_player_avfoundation, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/wakelock_plus.framework/wakelock_plus”, which includes wakelock, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
Apple Developer Relations
Thank you. Have a nice day!

I believe it is relevant, or at least it will be after November 24th. This is the email I received from Apple following the submission of my app that utilizes flutter_inappwebview.

Good day @rs-huannd1 @thisisjaymehta,
From my experience, I think you can follow these step to fix this issue:

Step 1: Upgrade Flutter SDK to 3.24 to get support from flutter sdk to fix issue: Your app includes “Frameworks/Flutter.framework/Flutter”, which includes Flutter
Step 2: Upgrade version of all dependencies in your pubspec.yaml
Step 3: In iOS project, create PrivacyInfo.xcprivacy

For @thisisjaymehta , Your image doesn't inform about the flutter_inappwebview. Please check the ordered_set pub. You can fork it. Update privacy manifest  for fork repo and use fork repo in your project if owner have no idea.

Your image doesn't inform about the flutter_inappwebview. Please check the ordered_set pub. You can fork it.

@phuc-tranh-otsv The ordered_set package isn't a plugin, and is unrelated. The issue is the OrderedSet pod, and specifically the fact that flutter_inappwebview depends on an old version of it that doesn't have a privacy manifest.

Hi @stuartmorgan,
Thank for your comment. I think we should open issue for OrderedSet before. Because the flutter_inappwebview depend it. If OrderedSet no yet upgrade they version for privacy manifest, we still stuck here.
But in my app, I use the flutter_inappwebview: 6.0.0 still pass the review privacy manifest. I think you should follow my previous comment and re-submit your app for review to check my solution work or not work for you.

The PR upgrade OrderedSet to 6.0.3 still open.
https://github.com/pichillilorenzo/flutter_inappwebview/pull/2161

As stated in the comment above, this does not affect apps that have already been published to the store using flutter_inappwebview.

Will this actually be rejected by Apple in the review process if it is not addressed?
Please let me know if you have any actual experience.

Individual experience on this is likely to vary:

Anyone building their Pod dependencies statically won't have issues, because this plugin and OrderedSet won't appear as frameworks in the final binary in that case.
In this update there is new language about the enforcement saying that it applies to "new or updated apps that have a newly added third-party SDK", so it doesn't sound like anyone already shipping an app using this plugin would be affected.

(It's also not actually clear that the plugin currently needs a privacy manifest, or if just updating the OrderedSet dependency will be enough. https://developer.apple.com/support/third-party-SDK-requirements/ lists flutter_inappwebview, not flutter_inappwebview_ios, whereas for most other plugins with a federated iOS implementation it is the implementation package that is listed. Given that, it's possible that only older versions of the plugin with the iOS implementation inline would currently trip the validation check, since for a build with a current version there would never be a flutter_inappwebview.framework in the build.)

But in my app, I use the flutter_inappwebview: 6.0.0 still pass the review privacy manifest.

As explained above, different people will have different enforcement experiences.

I think you should follow my previous comment and re-submit your app for review to check my solution work or not work for you.

I don't have an app. I'm a member of the Flutter team, helping the ecosystem adapt to the rollout of the privacy manifest requirements.
However, since I am very familiar with the way the requirements are currently enforced and how that enforcement interacts with different Flutter build configurations, I can definitely say that the steps in your comment will not resolve the situation for someone whose build configuration is such that they receive an enforcement warning about OrderedSet as a result of depending on the current version of flutter_inappwebview.

@phuc-tranh-otsv phu I meet an issue about the 'Missing privacy manifest' of flutter_inappwebview
App Store Connect

Hello,
We noticed one or more issues with a recent submission for App Store review for the following app:
'App Name'
Version 2.2.24
Build 216
Although submission for App Store review was successful, you may want to correct the following issues in your next submission for App Store review. Once you've corrected the issues, upload a new binary to App Store Connect.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseAuth.framework/FirebaseAuth”, which includes FirebaseAuth, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseCore.framework/FirebaseCore”, which includes FirebaseCore, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseCrashlytics.framework/FirebaseCrashlytics”, which includes FirebaseCrashlytics, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseDynamicLinks.framework/FirebaseDynamicLinks”, which includes FirebaseDynamicLinks, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/FirebaseMessaging.framework/FirebaseMessaging”, which includes FirebaseMessaging, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/Flutter.framework/Flutter”, which includes Flutter, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/OrderedSet.framework/OrderedSet”, which includes OrderedSet, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/connectivity_plus.framework/connectivity_plus”, which includes connectivity_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/device_info_plus.framework/device_info_plus”, which includes device_info_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/file_picker.framework/file_picker”, which includes file_picker, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/flutter_inappwebview.framework/flutter_inappwebview”, which includes flutter_inappwebview, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/flutter_local_notifications.framework/flutter_local_notifications”, which includes flutter_local_notifications, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/nanopb.framework/nanopb”, which includes nanopb, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/package_info.framework/package_info”, which includes package_info, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/package_info_plus.framework/package_info_plus”, which includes package_info_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/share_plus.framework/share_plus”, which includes share_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/video_player_avfoundation.framework/video_player_avfoundation”, which includes video_player_avfoundation, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/wakelock_plus.framework/wakelock_plus”, which includes wakelock, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
Apple Developer Relations

Thank you. Have a nice day!

Hi @phuc-tranh-otsv
I have just updated all libs. Now I want check privacy of libs. how to check it. I wan't up app to app store, because my project is outsource project. I want check privacy by myself. Thanks, have a good day

Hi @rs-huannd1,
Apple has informed us: "When you upload a new or updated app to App Store Connect that utilizes an API requiring approved reasons, we'll send you an email if your app's privacy manifest is missing any required details. This will be in addition to the existing notification in App Store Connect."
I recommend uploading the new version of your app to App Store Connect and submitting it for review. This will help you receive the guidelines necessary for your app. Unfortunately, I am unable to check the privacy details myself.
Have a great day!

for me , I just modify the orderedSet version in file:
project/ios/Podfile.lock
`yaml

flutter_inappwebview_ios (0.0.1):

Flutter
flutter_inappwebview_ios/Core (= 0.0.1)
OrderedSet (~> 6.0.2)

flutter_inappwebview_ios/Core (0.0.1):

Flutter
OrderedSet (~> 6.0.2)

OrderedSet (6.0.3)
`

and then run pod update OrderedSet in project/ios
finally ,use xcode to build app,then it works


Get-ContainerID returns null

Hi, I have been testing it (the latest version of the module) and don`t have any problem. I have used autocompletion to evaluate automatically the container name:

What does docker ps return?

I have recreated the container and now it works. Thanks for the help.


can not save wifi config on ESP32

I use example of thi libraryto compile and run. When I configged wifi parameters done,then click save button,but nothing was happened,why?

I have the same problem, so the library compiles ok, i can upload it and the config site is reachable at <IP_ADDRESS>, i can select wifi networks, enter the password but then the esp fails to connect in client mode. I'm using a Nina W-102 module(esp32) and that runs at 240 mhz. Can that be a problem<


fix for issue 24 (failing test with python 3.5)

I can confirm this works for me. In addition to passing the test suite, I can successfully read in the NDFD gridded version of the SPC outlooks (which I could not before this fix).


[text analytics] Enable Opinion Mining by default

Closing this for now until we can have a discussion about the interaction of this change with language support for OM.


chore(ci): Update renku actions to v0.4.1

Automated changes by create-pull-request GitHub action
/deploy

The setup is as follows:

if you do not provide #persist in the PR description (i.e. like  /deploy #persist) then the CI deployment is deleted after the acceptance tests complete
if you provide #persist the deployment is kept until the PR is closed.
when the PR is closed the namespace of the deployment is also deleted
when the acceptance tests complete AND #persist is not used the CI deployment is deleted but the namespace is not deleted in k8s - this makes it possible to reuse the TLS secret and not hit the limits for requesting certs with letsencrypt - when the acceptance tests for the same PR are run many times
artifacts from the acceptance tests are managed by the single (composite) test-renku action

You can access the deployment of this PR at https://renku-ci-nb-872.dev.renku.ch


WIP: clean: remove const definition available in upstream package

Describe what this PR does
Removes a const definition now available in the upstream:
https://github.com/kubernetes/cloud-provider/blob/master/volume/helpers/rounding.go#L25
Is there anything that requires special attention
This should be backward compatible and can safely be removed now :)

This fails to build with errors like
--- testing: github.com/ceph/ceph-csi/cmd ---
# github.com/ceph/ceph-csi/pkg/util
pkg/util/util.go:39:16: undefined: MiB
pkg/util/util.go:49:18: undefined: GiB
pkg/util/util.go:50:38: undefined: MiB
pkg/util/util.go:51:10: undefined: MiB
pkg/util/util.go:53:38: undefined: GiB
pkg/util/util.go:54:10: undefined: GiB

This should be a trivial correction, please let us know if you want someone else to take this over from you, @wilmardo

@nixpanic Fixed it :)
It think some of the logic can be improved by using the RoundUpTo* functions from upstream but I have no time to look into it at the moment. Golang is still very new to me so everything is a challenge ;)
I had something like this working but the logic was off, leaving it here for future reference.
q := resource.NewQuantity(size, resource.BinarySI)
return helpers.RoundUpToMiB(*q)

Hi @wilmardo, I have updated your PR so that CI should pass. The commit message now mentions the purpose of the change a little better too. Your authorship has been kept ,FWIW.
I re-considered asking you going through the modify/test/push process, hope you don't mind!
Thanks for the contribution!
Niels


Support maximum roll values on d20 rolls

Akin to #1350 (and #1599), I think it would be good to support this in the exact same way. The use case for maximums is much narrower of course, but would allow users to easily implement detrimental effects such as curses.

Minimums and maximums are now fully supported!


RObject.rename() method doesn't work in cluster

Redis version
any
Redisson version
any
Redisson configuration
Cluster
What is the Expected behavior?
RObject.rename() method is executed without errors
What is the Actual behavior?
RObject.rename() method throws an exception
Additional information
No response

Fixed

Fixed in 3.34.1


FEAT-#6838: Prefer lazy execution for binary operations.

Depends on #6836.
What do these changes do?
Multiple binary operations are faster to execute lazy, in a single batch. Here is an example:
import ray
ray.init()

import time
import modin.pandas as pd
from modin.utils import execute

df = pd.Series(range(100000))
start = time.time()
for i in range(100):
    df = df + i
execute(df)
print(f"Time: {time.time() - start}")

Time: 2.4991016387939453
Time on master: 5.286777019500732

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #6838
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko, #6836 is merged. Can we continue this?


Update FAQ entry about helper for recording violation entries

The FAQ states that there is no cargo vet record-violation as an analogue to cargo vet certify, and gives reasons why. However, cargo-vet as installed from this repository has a cargo vet add-violation command that appears to be precisely this helper.
The FAQ entry should be either removed, or updated with the relevant context for cargo vet add-violation.

add-unaudited and add-violation are both "plumbing" commands I added for testing/experimentation, it's unclear if they should be visible/exposed longterm

I think this is a fair point. The FAQ entry predates both our switch to semver's VersionReq for violation entries, and @Gankra's addition of the command which turned out to be much less of a hassle than I expected (seems like as long as you quote the VersionReq no other special escaping is needed).
I'll go ahead and remove the FAQ entry.

I also renamed add-violation to record-violation here: https://github.com/mozilla/cargo-vet/commit/88c6957699ecf08b2d9985edea9fa2b02cc6e8eb


Aligning lint rules with dart-pad

This LGTM, but it might be a good one to hold off for a couple weeks until Devon is done with his changes, just to avoid slowing him down.

I can work around this, so no problems w/ landing it while I'm still working on my PR.

SGTM, then!


Cannot write Mustache syntax in template

Did the vue init command itself result in an error?

No.

Actual result:

I try to write mustache syntax {{ ... }} at my .vue component file. the hbs render engine will transform it as hbs element. and even if the var is not defined, vue-cli will not throw error:

{{ a.b }}  <!-- Will be transformed to empty, and doesn't throw error -->

Expected result:
vue-cli should rewrite the transform function to add extra syntax to distinguish hbs-mustache token and vue-mustache token. And when customized template try to use non-existed variable, vue-cli should throw error.

We are currently not planning to mess with the handlebars defaults, at least not in the 2.* version of vue-cli. There's alreadya request for this though: https://github.com/vuejs/vue-cli/issues/546
So for now:

You can escape those easily:

  <h1>\{{message}}</h1>

We do that in our templates as well, see here.

You can make the vue-cli skip interpolation for some files in your own templates: https://github.com/vuejs/vue-cli#skip-rendering


Cow: Watch epsiloan.xyz

Cow requests the watch of the watch_keyword epsiloan\.xyz. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by cigien in Charcoal HQ


Fix README output copy for 2.6 section

I'd like to start off thanking you for all your work on this beautiful gem:
well written, documented and readable code that provides a sweet API.
:bow: :bow: :bow:
I've noticed a tiny mistake on the wording for a snippet output in section
2.6 yes?/no?. It reads like instead of hate as it is in the input code.
That's pretty much it. I haven't spotted anything wrong anywhere else in
the docs or the code. :smile:
Again, thank you for your work!

Thank you for your kind words Rafael and the correction. I've agonised over the API too much and probably will in the future but I hope it will be intuitive for devs to use. I have big plans for the library going forward, including the already posted issues/ideas. Please take a look and get involved.


Is there an official fork that is being heavily used and actively maintained?

Hi all,
JSGrid's last release version was 6 years ago.  The last time code made it to master was 2020.  Is there an official fork that is being heavily used and actively maintained?

Hi,
My fork is not official but some features were added for my company project.
https://github.com/harimac/jsgrid


Update annotations list

Add gce annotations related to creating HTTPS load balancers.
Formatted tables to show a column for defaults and a column for applicable controllers.

This change is

Coverage increased (+0.03%) to 44.674% when pulling a27a873d21c614bb7c02dc249a5edd1ad0d30a8c on tonglil:update-annotations-list into 36cf018a71569fe33ebd01b6b8e29984765c4351 on kubernetes:master.

/lgtm

@tonglil thanks!


Improve Readability of Conversation Bubble on Gita Storyline Page

Description:
Improve Readability of Conversation Bubble on Gita Storyline Page
Reason for Change:
There appears to be an overlapping issue where Krishna's image is positioned in front of his speech bubble.
Current Styling:

Proposed Styling:
I'll adjust the positioning of Krishna's image to ensure the conversation bubble is fully visible.

Priority Level (optional):

[ ] Low
[x] Medium
[ ] High

@akshitagupta15june Could you please assign this issue to me under WOC'24?


Expression tag incorrectly treats boolean parameter values as strings

Summary
What happened/what you expected to happen?
When the parameter value is true, Argo Workflow treats it as string "true", which is incorrect and should be boolean instead.
Reproducible YAML:
This will print "yes":
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: hello-world-expression-
spec:
  serviceAccountName: argo
  entrypoint: hello-world
  arguments:
    parameters:
    - name: flag
      value: true
  templates:
    - name: hello-world
      container:
        image: docker/whalesay
        args:
          - cowsay
          - "{{=workflow.parameters.flag == 'true'? 'yes' : 'no'}}"

And the following workflow (using ternary operator) would print out the unevaluated expression:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: hello-world-expression-
spec:
  serviceAccountName: argo
  entrypoint: hello-world
  arguments:
    parameters:
    - name: flag
      value: true
  templates:
    - name: hello-world
      container:
        image: docker/whalesay
        args:
          - cowsay
          - "{{=workflow.parameters.flag ? 'yes' : 'no'}}"

 ______________________________________
/ {{=workflow.parameters.flag? 'yes' : \
\ 'no'}}                               /
 --------------------------------------
    \
     \
      \
                    ##        .
              ## ## ##       ==
           ## ## ## ##      ===
       /""""""""""""""""___/ ===
  ~~~ {~~ ~~~~ ~~~ ~~~~ ~~ ~ /  ===- ~~~
       \______ o          __/
        \    \        __/
          \____\______/

Before we start, around 2/3 of issues can be fixed by one of the following:

Have you double-checked your configuration? Maybe 30% of issues are wrong configuration.
Have you tested to see if it is fixed in the latest version? Maybe 20% of issues are fixed by this.
Have you tried using the PNS executer instead of Docker? Maybe 50% of artifact related issues are fixed by this.

Diagnostics
👀 Yes! We need all of your diagnostics, please make sure you add it all, otherwise we'll go around in circles asking you for it:
What Kubernetes provider are you using?
k3d
What version of Argo Workflows are you running?
v3.2.0-rc1
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
PNS
Did this work in a previous version? I.e. is it a regression?
Haven't checked.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Parameters are always strings. The first workflow is the correct way to write the ternary.

That's inconsistent with the current support of AnyString for parameters and the correct underlying type should be inferred.

Ooh, I was unaware of AnyString, so I might just be Wrong about this one. Will look through the code some more.

Parameters are always strings.

@alexec I remember at one point we did support AnyString though. See https://github.com/argoproj/argo-workflows/pull/4490

Because of backwards compatibility, we try, but not very hard. Bools and ints always cause problems.


Repo sync for protected CLA branch

The pull request is created from master637534334939754409 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fix K.match() on regex filter

Issue
Prevent the regex filter from returning an object instead of a boolean
re.match return an object if match, None else
Demonstration
In this case, K.match() return a re.match() object instead of a boolean:
assert K(['=~', 'f', '^hi$']).match({'f': 'hi'}) == True # Fail.

Tests also broken.  False positive here, object is not None so you got True:
def test_basic_regex_true(self):
    self.assertTrue(K(['=~', 'f', '^hi$']).match({'f': 'hi'})) # Success => False positive!
    self.assertIs(K(['=~', 'f', '^hi$']).match({'f': 'hi'}), True) # Fail as expected before the fix

This fix include a little class helper that shortcuts self.assertIs(exp, true) to self.assertIsTrue(exp) following your conventions. Tests are also updated with assertions helpers that follows Python AssertIs recommendations for booleans strict checking.
Fix
Changed this line:
'=~': lambda match_str, regex: regex.match(match_str) if match_str is not None else False,

By this line:
'=~': lambda match_str, regex: regex.match(match_str) is not None if match_str is not None else False,

is not None explicit convert re.match() to boolean as K.match() should work.

thanks for this pr @XavierBrassoud sorry i didn't see it sooner. i can circle back around to this and get it merged in


Getting started: A clean skeleton

I try to create a frontless app with a clean skeleton.  The application does not run.
Steps to reproduce the behavior:

$ npx create-frontless myapp --clean
$ cd myapp
$ yarn start

Expected behavior
The application should not crash.  I am guessing that a near empty app should launch.
Actual behaviour
I see the following output in my terminal:
$ yarn start
yarn run v1.17.3
$ cross-env NODE_ENV=development gulp
[21:48:55] Using gulpfile ~/lrn/myapp/gulpfile.js
[21:48:55] Starting 'default'...
DEV: development bus is started on ::8998
DEV: waiting for building events
[21:48:55] Finished 'default' after 151 ms
[21:48:55] running tasks...
[21:48:56] Using gulpfile ~/lrn/myapp/gulpfile.js
[21:48:56] Starting 'worker'...
[21:48:56] Starting 'boot'...
[21:48:56] Starting 'scss'...
[21:48:58] Finished 'boot' after 2.3 s
[21:48:58] Finished 'scss' after 2.32 s
[21:48:59] Finished 'worker' after 2.34 s
DEV: status -> building
DEV: status -> frontend
DEV: status -> finished
DEV: status -> started
[21:48:59] [nodemon] 1.19.1
[21:48:59] [nodemon] to restart at any time, enter `rs`
[21:48:59] [nodemon] watching: *.*
[21:48:59] [nodemon] starting `node index.js ./config/environ.env`
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'examples/chat.riot'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/gburnett/lrn/myapp/pages/examples/chat.riot:8:36)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Module._compile (/home/gburnett/lrn/myapp/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Object.newLoader [as .riot] (/home/gburnett/lrn/myapp/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:653:32)
[21:49:03] [nodemon] app crashed - waiting for file changes before starting...

Environment:

OS: Arch linux
node: v10.16.0
yarn: v1.17.3

Thanks for reporting it. The command works as expected now.


Fix type qualifier warning during compile (ModelArray.hpp #includes)

When compiling any target that depends on a source which includes ModelArray.hpp when using compiler 'mpiicpc' you get a warning.

Syndrome:
[ 22%] Building CXX object CMakeFiles/nextsim.dir/core/src/DevGridIO.cpp.o
In file included from /home/jbloggs/nextsim/xios_write/core/src/include/ModelState.hpp(11),
from /home/jbloggs/nextsim/xios_write/core/src/include/IDevGridIO.hpp(12),
from /home/jbloggs/nextsim/xios_write/core/src/include/DevGridIO.hpp(11),
from /home/jbloggs/nextsim/xios_write/core/src/DevGridIO.cpp(8):
/home/jbloggs/nextsim/xios_write/core/src/include/ModelArray.hpp(241): warning #858: type qualifier on return type is meaningless
const Type getType() const { return type; }
^

Reproduction Steps:
Repeat install steps but replace the cmake line with
cmake . -DCMAKE_CXX_COMPILER="mpiicpc"
make step should trigger the warnings

Severity & Frequency:
Low impact. UX and only at compile (but for many many files). Have not investigated compile speed impact. Remove bug label at triage if inappropriate (readme isn't specific).

Either Type or const Type& would work. Is either preferred?


Redeploy on new Domain, test, then make public.

Now that we have the tunnel set up and the new domain which no longer requires VPN access, redploy, test that it works, then publish and share on astropy with a PR.

Deployed on GCP. basic health check so far. Close when this is transferred to domain.

Deployed with TLS (HTTPS) on GCP and DNS on my website tnsquery.darkdata.ml/api/


feature request: glob patterns

Hi, this is really a great plugin, thanks for making it!
I have one feature request...
It would be so powerful if you could watch glob patterns.
// webpack.config.js
import ExtraWatchWebpackPlugin from 'extra-watch-webpack-plugin';
......
{
  plugins: [
    new ExtraWatchWebpackPlugin({
      files: [ 'path/*/file/*.js' ]
    }),
  ],
}

A very short feature request, but not sure what else I can say about it :) Thoughts?

Hi @ronkorving it's a good idea. PR is welcomed.
If you do not have the time I would like to work on it this weekend.

@pigcan As you may have noticed, I haven't had the time yet, and I don't expect that to change really soon. Feel free to pick it up :)

Supported


Prisma Client Postinstallation Script stuck (npm)

Bug description

By a random chance, on any operating system (Linux & MacOS), npm i as well as npm ci both get stuck occasionally.
I first thought some servers of npm were just stuck or blocking, but I found out, by running npm -v ci, the postinstallation script of the prisma client is the actual problem.
It would just go stuck like this:

I did not know why it just breaks off at first, but then I noticed prisma/client is the last package to installed, and this exact package was always the package to get installed after prisma/engines. When it looks like the above image, there's no help but to kill npm - the script is stuck, and with it the whole command run.
Use the following Docker environment to have a glance on your own:
FROM alpine:latest

RUN apk update
RUN apk add --update nodejs npm git
WORKDIR /usr/src/

Copy some project with prisma and NextJS into the container and install the dependencies of the project the following way:
RUN npm ci --verbose

It occasionally happens, however to me, especially in that Docker environment, the installation failed multiple times in a row sometimes.
How to reproduce

Install @prisma/client with npm.
Expected behavior
Installs
Prisma information
I doubt that matters in this case. The command prisma regenerate has to be run after that, anyway? I've got a few models and MariaDB.
Environment & setup

OS: Preferred: alpine:latest
Database: MariaDB
Node.js version:

npm verb cli /usr/bin/node /usr/bin/npm
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>
Prisma Version
seen above

same problem here, have you found a solution for this?

I also have this issue, however it works but takes 5 minutes or more. No idea when and why this started to happen


Add movies watchlist sensor

Is it possible to add a watch list sensor for movies?
https://trakt.docs.apiary.io/#reference/sync/get-watchlist/get-watchlist
I've notice that can be sorted by multilple values, but not to filter unrealesed movies, is that possible too?

I'm confused.
The watch list is there... if you read the readme it says the upcoming sensors are retrieved rom the watchlist...
If you mean you want a sensor for movies you already watched... Then i asked the same here: https://github.com/dylandoamaral/trakt-integration/issues/87
But its closed without correct reason, i replied again there but couldnt reopen.
IF i'm mistaken about watchlist, then the readme isnt clear enough :)

I'm confused. The watch list is there... if you read the readme it says the upcoming sensors are retrieved rom the watchlist...
If you mean you want a sensor for movies you already watched... Then i asked the same here: #87
But its closed without correct reason, i replied again there but couldnt reopen.
IF i'm mistaken about watchlist, then the readme isnt clear enough :)

What I mean is a sensor of movies that are on my watchlist but have already been released. I think the current sensor only shows unreleased movies.

I have same question. I have a list of movies that are already released but added on my watchlist.
Would be great to have a 'sensor.trakt_my_watchlist' so I can see what movies I have left to watch. And not only the upcoming. :)
p.s. //Keep up the good work!!
I love the integration!

Would love to have this too

Hi I would like that too. So i will be able to see my tv show watchlist. upcoming don't show the tv shows I have yet to watch but already released . thank you


limiting access to swagger ui and json to authenticated users needed

I found two closed threads but no actual answer that will work for most users.
the json and html need to be protected from unauthenticated users.
it needs to work with OWIN
I have oauth / identity server working to pass tokens to the api calls and it seems like a small change would finish the work.
the user needs a key or a token before they can access the json doc
if they do not have one then redirect to a login page.   this is happening now but at too late of a stage to block access.
I would offer to do the code but I just do not know this code to even start. wish I could help but only so much time to spend.

This is not something that I'm going to support out-of-the-box.
As described in other threads, this can be done by injecting your own middleware earlier in the pipeline that checks if a Swagger resource (JSON or HTML) is being accessed and then redirecting or delegating to the next middleware as appropriate.

I figured out the way to do this. Use the latest swashbuckle version and add the below div tag in the injected index.html

This will show an Authorize button in the swagger UI which can be used for authentication and once Authenticated, for all the requests to the API, the JWT token will be passed from the swagger UI


Automatic invocation of const constructors in const constructors.

I would like to propose an extension of the language for Dart 2.0 related to const constructors.
The Problem
With the current version of Dart the constraint of defining explicitly new or const during the declaration of an object creates a huge limitation for nested constructors.
A basic example:
class Rectangle {
  final int p1;
  final int p2;
  const A(this.p1, this.p2);
}

class C2 {
  final C1 p3;
  const C2(this.p3);
}

given this cose the following invocation is valid.
const C2 o1 = const C2(const C1(1, 1));

There are some situations in which this nesting can become tedious and reduce readability.
A first attempt to reduce the clutter could be:
class Rectangle {
  final int p1;
  final int p2;
  const A(this.p1, this.p2);
  const A.same(this.p1, this.p2);
}

class C2 {
  final C1 p3;
  const C2(this.p3);
}

const C2 o1 = const C2(const C1.same(1));

still we can do better.
An interesting solutions is:
class Rectangle {
  final int p1;
  final int p2;
  const A(this.p1, this.p2);
  const A.same(this.p1, this.p2);
}

class C2 {
  final C1 p3;
  const C2(this.p3);
  const C2.same(int p)
    : this.p3 = const C1.same(p);
}

const C2 o1 = const C2.same(1);

this solutions though is not valid Dart and we obtain the following error.
expression is not a valid compile-time constant
 : this.p3 = const C1.same(p);

Even though in that situation p is a compile time constant because it is invoked from a const expression.
Right now the only solution is avoid constants and in this case just allocate the object at runtime.
 C2.same(int p)
    : this.p3 = new C1.same(p);

A real world example of the effect of this limitation can be seen in:
https://github.com/flutter/flutter/blob/8a88e2efca39694d2603bb760fea6bac28dbf266/packages/flutter/lib/src/painting/box_painter.dart#L47
where, for readability, the framework is missing a possible optimization.
The Proposal
Would it be possible to have a context dependent allocation operator? like
const C2.same(int p)
    : this.p3 = const/new C1.same(p);

or
const C2.same(int p)
    : this.p3 = const|new C1.same(p);

or make new context dependent and automatically identify if the constantness can be forwarded.
const C2.same(int p)
    : this.p3 = new C1.same(p);

The proposal for optional const and optional new (https://github.com/dart-lang/sdk/issues/30341) could also be extended with this case.
const C2.same(int p)
    : this.p3 = C1.same(p);

See also

https://github.com/dart-lang/sdk/blob/master/docs/language/informal/optional-const.md
https://github.com/dart-lang/sdk/blob/master/docs/language/informal/optional-new.md
https://github.com/dart-lang/sdk/blob/master/docs/language/informal/optional-new-const.md

I read them and I think that this explicit case, even though it looks like a simple extension, is not explicitly considered.
I'm possibly wrong, if it is already in there can you help me understand where?

Your proposal is explicitly considered in the last link above.
It's the fourth feature mentioned, under the heading "Optional new/const in potentially const expressions", and that also lists the major complication introduced by allowing more general expressions in const constructor initializer lists: You can now have infinite recursion using const constructor calls. This needs to be detected and prevented (infinite recursion at compile-time is usually not desired), and it's the major reason this feature isn't as trivial as one would hope.


mat1 and mat2 shapes cannot be multiplied (2x1024 and 768x320)

mat1 and mat2 shapes cannot be multiplied (2x1024 and 768x320)

Did you download the image_encoder weights and config file from this link: https://huggingface.co/lambdalabs/sd-image-variations-diffusers/tree/main/image_encoder ?

Did you download the image_encoder weights and config file from this link: https://huggingface.co/lambdalabs/sd-image-variations-diffusers/tree/main/image_encoder ?

many thanks
I pretended to be clever and used the ipadapter image_encoder


Missing sampler parameters

Changes

Bug: repeat_y was returning repeat_x in context.py. Added tests for this.
Bug: glError on sampler creation
Added repeat_z, min_lod, max_lod and border_color
Added Context.clear_samplers

Adding the last three parameters quickly as well.

The only wonky part with border color is that it requires a different texture wrap having to override repeat_. When the border color is set I simply override it for now.
Testing with yellow border color:

Done for now. I have tested the new parameters.

Also added Contect.clear_samplers unbinding samplers from all texture units. When you for example draw a GLTF scene (that uses samplers for all textures) you really have no idea what state the texture units are currently in and you have no way to efficiently clean them up.
It's probably not ideal, but MUCH more efficient than unbinding samplers for every mesh.

Doing some more detailed testing. I see a glError triggering somewhere I have to find as well.

What do you think about having the sampler as an optional parameter to Texture.use(...)?
Currently:
sampler.use(location=0)
texture.use(location=0)

Sampler parameter:
texture.use(location=1, sampler=sampler)

It may give the impression that a sampler belongs to the bound texture and not the texture unit as a whole? .. or we assume people know the sampler will stick to the unit?

Is it common to create a few samplers and use with multiple textures?
What do you think, should samplers be created like vao's? (Vaos store a program object. When you call vao.render it will bind the program object that vao internally knows. Sampler.use could bind the texture to a texture unit)
I think it could be more convenient to have samplers as the only option to bind a texture to a texture unit (in the next major). Textures would store the texture's data only. Samplers would be responsible for handling the sampler parameters and binding the texture to its unit when requested.
This could ensure not to have invalid sampler, texture pairs bound.
This could also ensure that build_mipmaps cannot affect the filter parameters.
This would force the user to create similar samplers for different textures.

I moved my question about sampler binding to #227

I will merge this. Can we make a release when this one is merged?

Yup. Release 😄


Error in finetune_video.sh when using deepspeed scripts/zero3_offload.json

Hi,
I use finetune_video.sh with deepspeed scripts/zero3_offload.json, it show error -9 and exit. Can i use finetune_lora to finetune video?

Yes you could. I think -9 is caused by oom so, you could adjust your fps and pixel sizes too.
Also, You could traing with 8bit too.

Thank you for yours response. Can I use the chat template

like this for video? I see the sec/training/data.py, look like not supported the image?

Yes this code only supports the video in mp4, avi, mov or something like that.
However I've inspeceted the model code itsel, it uses as the same as multiimage. So it wouldn't matter if you use the multi-frame video data with multi image.
I'll try to cover up the multi-frame video soon.

Thank you. I modify finetune_lora_vision to finetune_lora_video, if I use "Qwen2-VL-2B-Instruct", everything pass. When I use "Qwen2-VL-7B-Instruct", it struct in merge_lora.sh. It show the error message "ValueError: Trying to set a tensor of shape torch.Size([151936, 1536]) in "weight" (which has shape torch.Size([152064, 3584])), this looks incorrect."
How to solve this error?

@xjohnxjohn I think you are merging the 2B model weight to the 7B model.
torch.Size([151936, 1536]) this is the embed_token weight of 2B model and torch.Size([152064, 3584])) this is the embed_token wegith of 7B model.
Check if you had changed the output directory name when fine tuning 7B after 2B.

Thank you for you suggestion.


Xcode 8 compatibility? Instruments' Automation support has been replaced by Xcode's UI Testing infrastructure.

https://forums.developer.apple.com/thread/48936
Instruments' Automation support has been replaced by Xcode's UI Testing infrastructure.
@jonathanpenn How to deal with this problem, Thx

I wrote a tool similar to ui-auto-monkey using Xcode's UI Testing infrastructure. Please have a look:
https://github.com/donaldhu/xc-auto-monkey


Added Chinese localization to the module

rough work, not elegant translation but nice and concise.
Updated module.json and tesed the translation, works fine.

Thanks for that, will add it to the next release. I appreciate the work.


Add Option to set serach panel by default

Hello,
is there a way to set the search panel shows by default?
Similar to pdfjs.sidebarViewOnLoad?
Best Regards

is there a way to set the search panel shows by default?

No, there's no way of doing what you ask by default (you'd have to implement opening of the PDF.js findbar when the viewer loads yourself).
Since the Firefox versions of PDF.js uses the native browser findbar, which we don't want to trigger programmatically, I don't think that implementing such a preference would be a good idea since it would not behave consistently in the various PDF.js build targets.
Closing as answered.


Feature/epub generation

Description

Added epub generation ( needs design improvement. )
Moved some files in renderer/pdf to renderer/

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

@PuruVJ @proful I hope it is okay now

this looks good. Can be merged
A question though. We have set up prettier config, and according to it, the indentations should only 2 spaces, but your code has 4 of those.
Can you check if you have the prettier config in the package.json? Send a screenshot.

Good catch @PuruVJ
@tolgaerdonmez please format as per prettier configuration defined in package.json

Here's the .prettierrc file. Paste it in twindle folder, so we can have equal formatting everywhere.
{
  "trailingComma": "es5",
  "tabWidth": 2,
  "semi": true,
  "singleQuote": false,
  "printWidth": 100,
  "arrowParens": "always"
}

@PuruVJ why this is needed?
We already have this configuration in package.json
@johnjacobkenny

@PuruVJ why this is needed?
We already have this configuration in package.json
@johnjacobkenny

vscode don't recognize the package.json prettier config I believe

It does for me.
You may have to try some settings


Bug: Modifier toggles are blocked when selecting an unmodifiable key character

Just a small bug I noticed:
Pick the character "A" for a key and toggle a modifier e.g. LSHIFT. Then Attempt to re-pick a non-modifiable character e.g. "~". The mod toggles become uninteractable but still in the same phase as you left them. You must select a modifiable character to untick the modifier. Otherwise you are left with something like LSHIFT(TILDE) on the key, which won't have an effect but is a bit of a cludge.
Should the correct behaviour be to automatically untick all modifiers before blocking them?

Hey, thanks for catching this!
Unless I'm misunderstanding, only the modifier that's being applied implicitly is non-toggleable. Since ~ is sent (in a US QWERTY layout) as LShift+` that particular toggle is disabled.
You're not wrong that the shift modifier should be cleared for the sake of elminating redundancy, but that can/should happen in a controlled manner instead of removing all modifiers. It shouldn't be terribly complicated to fix this but I haven't looked at that in a little while now and would need to double check on how this affects keycodes pulled from zmk-locale-generator.

Just pushing a small fix for this now, it strips implicit modifiers when selecting a keycode (any other active modifiers are preserved but you can still toggle those at will). This should work well for keycodes coming from zmk-locale-generator but I'm actually using a hardcoded list of "shifted" keycodes for the standard ZMK set. If you run into something that might have been missed by that list feel free to reopen or create a new issue.
Thanks again!


Add show method to python execution results

Summary
Be able to print out results without needing to call to_polars or to_pandas first.
Specifications

Rationale

Impact

Tasks

Blocked on #1279
Possibly someone pair with @adhish20

should we implement show() that prints the output directly or to_string() that returns a string as output? @scsmithr


[Vulnerability] Upgrade packages to resolve security vulnerability

Vulnerability updates

Bump aiohttp from 3.8.4 to 3.8.5 - aiohttp.web.Application vulnerable to HTTP request smuggling via llhttp HTTP request parser
Bump certifi from 2023.5.7 to 2023.7.22 - Removal of e-Tugra root certificate
Bump cryptography from 41.0.1 to 41.0.3 - cryptography mishandles SSH certificates
Bump langchain from 0.0.188 to 0.0.264 - langchain Code Injection vulnerability

Enhancement

Bump Uvicorn from 0.20.0 to 0.22.0 - Latest Unicorn has a feature to specify timeout when shutdown doesn't complete
https://www.uvicorn.org/settings/#timeouts

@isafulf will you review please? Also, what do you think about installing dependabot on this? I can send out a PR for it if you'd like.


Images are not loading in deployed version using Docker

I copied the docker file from the original one except that it is now pulling the app code from my forked repo. Everything else is the same.
The logo and product images are not loading. I have tried changing the domain to use localhost:3000, localhost:4000, and the VM ip but nothings seems to work.

Issue fixed here https://github.com/cezerin/cezerin/commit/aaf5171e0fe294ea0cf27da627a383e77eca9c6a
Now domain can be empty. Product image will be relative.


Support the EG 1.0 spec

We're currently supporting EG 0.95. We need to:

enumerate the changes from EG 0.95 to EG 1.0
support write-ins (hashed ElGamal stream cipher?)

Get started on these:
Section 3.3.4: Contest overvote information
Section 3.3.5: Contest write-in data

Section 4.1: Election manifest

work your way through the spec and make sure we're compliant
eventually, do the same thing for ElGamalCiphertext, the Chaum-Pedersen proofs, etc.

you should only have to change the serialization code in json.ts


Client unable to reconnect after Modbus Server goes offline and back online

Problem
Modbus client (read/write/flex-getter) does not reconnect if modbus server is powered off/disconnected from the network and  then powered on/connected on the network again. I have checked the option "Reconnect on timeout" with the default time of 2000 ms. The only way to reconnect the client is to restart the flows or the entire node-red system.
Thank you for any advice!
node-red -v logs:
13 Feb 15:50:31 - [warn] [modbus-client:Modbus Server] Client -> fsm connected after state init Get More About It By Logging TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
13 Feb 15:51:20 - [warn] [modbus-client:Modbus Server] Client -> fsm failed state after sending Get More About It By Logging TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
13 Feb 15:51:20 - [warn] [modbus-client:Modbus Server] Client -> fsm broken state after failed Get More About It By Logging TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
13 Feb 15:51:20 - [warn] [modbus-client:Modbus Server] Client -> fsm reconnect state after broken Get More About It By Logging TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
13 Feb 15:51:22 - [warn] [modbus-client:Modbus Server] Client -> fsm init state after reconnecting TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
13 Feb 15:51:22 - [warn] [modbus-client:Modbus Server] Client -> fsm init in 2000 ms TCP@<IP_ADDRESS>:5020 default Unit-Id: 1
Environment
I am using just the Node-RED package and got modbus-serial package installed with it. Version of node-red-contrib-modbus: 5.13.3 (latest). I experienced this issue with various servers and using different devices as client (Windows 10 PC, Raspberry Pi with latest buster release). Node-RED version: 1.2.9 (latest).

node-red-contrib-modbus version: v5.13.3

nodejs version: v15.8 for Windows, v12.x for Pi

Same exact issue, has been going on for a while. Have to stop using this module for now.

After various tests with differente machines and OS the only way I could solve the issues was to:
1 - unistall nodejs and reinstall version 12.20.2 (which by the way is the version automatically installed with the "official" Pi script from nodered.org)
2 - reinstall node-red-contrib-modbus (latest version) - simply reinstalling the module without touching nodejs didn't work out
Note that upgrading nodejs could break again the modbus nodes. I think that's what could have generated the issue for me so I didn't take the chance again.

hi,
i have the same problem, but with only 1 modbus connexion (i have 8 other modbus connexion working fine).
i'm running nodered on ubuntu 20.04
I upgraded nodejs to 12.20.3 (10.19.0 before), nodered to 1.2.9 (1.2.7 previously), and reinstall node-red-contrib-modbus but the problem is still here. do you have additionnal informations to communicate about the way you resolve the problem ?
do you have a idea of what is going on ?
thx

Hi, Did the 7 other connections work with the previous nodejs version? have you tried to delete the client configuration node and recreate it? If one connection works and the others don't I think you should be able to fix them by cancel the relative configuration nodes and recreate them from zero.

Yes the connexion work with the previous version, exept the last one, and that is why I try to resolve it by changing the version of nodejs.
Yes i try to delete client configuration  many time and recreate with many configurations. increasing timeout, reconnect timeout , queue delay, uncheck or check boxes but nothing resolve the problem.
All connexion work exept 1. I have deleted all modbus configuration , uninstall node-red-contrib-modbus, reinstall it and reconfigure only the connexion that didn't work and  i always have the problem.
I did some test today with modbus and nodered. i copy/paste my project into a nodered under Windows10 and it's working fine with it.
An other thing  that i have in ubuntu  is on every flow restart, i have the following :

this is not happenning on Windows10.
Do you have the same thing ?
When you test it on W10, do you find a configution where it's working fine ? or the only way you find is  to change nodejs version on your Raspberry.
thx.

In the screenshot you posted I see logs of the various client operations, 8 different clients as you already said. I think you see the logs in the debug window because you checked the relative option in the client nodes (probably in windows it is not checked). With that option checked you get to see what the finite state machine is doing.
I'm not sure about Ubuntu but in windows10 I have no issues and I am using nodejs 12.20.2 and the latest modbus nodes version. With later versions of nodejs I experienced issues.

Same Probleme here - no reconnect!

You're right @MountainKing91  , my problem is not solved on W10, the logs are just hidden. so I enable log errors and activities on Node configation and I found an othe aspect of my problem : a "PortNotOpenError: Port Not Open" message when i send a request.
After a few days of testing, I found the solution. Nodered is not the cause of this problem, it's come from a PLC which disrupts all modbus communication to another PLC.
@sniicker, try to activate log errors and activities on your modbus node, maybe the problem is just hidden.

Glad u guys were able to solve. At this point the bottom line is: do NOT upgrade nodejs past version 12.2.20. I couldn't get it done with the latest nodejs version.

@seb976 Yes i also get this msg port not open, but this is the truth. When i unplug the lan cable there is no Port open :) But after i reconnect - the status stays at init. I think not thats because of the port.

nodejs V14.15.4 is not supported yet

Boa tarde. Eu desenvolvi uma solução temporária para o problema, utilizando os seguintes nós: Catch , Delay, Function e Modbus Flex Connector.
[{"id":"166e9137.258aaf","type":"tab","label":"Siren Act","disabled":false,"info":""},{"id":"49cc8c84.19a0f4","type":"inject","z":"166e9137.258aaf","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"1","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":110,"y":80,"wires":[["9e27f0d3.a686d"]]},{"id":"9e27f0d3.a686d","type":"modbus-getter","z":"166e9137.258aaf","name":"","showStatusActivities":true,"showErrors":true,"logIOActivities":false,"unitid":"1","dataType":"Coil","adr":"5","quantity":"1","server":"9896a43e.0450d8","useIOFile":false,"ioFile":"","useIOForPayload":false,"emptyMsgOnFail":false,"keepMsgProperties":false,"x":320,"y":80,"wires":[["7e59772f.8888c8"],[]]},{"id":"7c86b41f.80ba1c","type":"inject","z":"166e9137.258aaf","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"10","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":110,"y":160,"wires":[["1461453.ca1e9bb"]]},{"id":"1461453.ca1e9bb","type":"modbus-getter","z":"166e9137.258aaf","name":"","showStatusActivities":true,"showErrors":false,"logIOActivities":false,"unitid":"1","dataType":"HoldingRegister","adr":"4","quantity":"1","server":"9896a43e.0450d8","useIOFile":false,"ioFile":"","useIOForPayload":false,"emptyMsgOnFail":false,"keepMsgProperties":false,"x":320,"y":160,"wires":[["2f51bb91.9f9c04"],[]]},{"id":"7f9b3178.ed9c9","type":"modbus-flex-connector","z":"166e9137.258aaf","name":"","maxReconnectsPerMinute":4,"emptyQueue":false,"showStatusActivities":false,"showErrors":false,"server":"9896a43e.0450d8","x":890,"y":300,"wires":[[]]},{"id":"77400a24.a29a24","type":"catch","z":"166e9137.258aaf","name":"","scope":["9e27f0d3.a686d"],"uncaught":false,"x":130,"y":300,"wires":[["65bceb85.711204"]]},{"id":"d7d4c279.34d04","type":"modbus-write","z":"166e9137.258aaf","name":"","showStatusActivities":false,"showErrors":false,"unitid":"1","dataType":"Coil","adr":"3","quantity":"1","server":"9896a43e.0450d8","emptyMsgOnFail":false,"keepMsgProperties":false,"x":880,"y":220,"wires":[[],[]]},{"id":"5f906dda.dfd2f4","type":"eth-ip out","z":"166e9137.258aaf","endpoint":"c51db702.7f4008","variable":"LG1","program":"","name":"","x":910,"y":80,"wires":[]},{"id":"822457c8.c97238","type":"eth-ip in","z":"166e9137.258aaf","endpoint":"c51db702.7f4008","mode":"single","variable":"RTN1","program":"","name":"","x":130,"y":220,"wires":[["8e6c2bad.109c78"]]},{"id":"7e59772f.8888c8","type":"function","z":"166e9137.258aaf","name":"","func":"if(msg.payload[0] == true)\n{\n    msg.payload = 1\n}\nif(msg.payload[0] == false)\n{\n    msg.payload = 0\n}\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":580,"y":80,"wires":[["5f906dda.dfd2f4"]]},{"id":"8e6c2bad.109c78","type":"function","z":"166e9137.258aaf","name":"","func":"if(msg.payload == true)\n{\n    msg.payload = 0\n}\nelse\nif(msg.payload == false)\n{\n    msg.payload = 1\n}\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":580,"y":220,"wires":[["d7d4c279.34d04"]]},{"id":"2f51bb91.9f9c04","type":"eth-ip out","z":"166e9137.258aaf","endpoint":"c51db702.7f4008","variable":"RSSI","program":"","name":"RSSI","x":910,"y":160,"wires":[]},{"id":"65bceb85.711204","type":"delay","z":"166e9137.258aaf","name":"","pauseType":"rate","timeout":"5","timeoutUnits":"seconds","rate":"1","nbRateUnits":"20","rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":true,"x":380,"y":300,"wires":[["482badee.aae8d4"]]},{"id":"482badee.aae8d4","type":"function","z":"166e9137.258aaf","name":"","func":"msg.payload = \n{ 'connectorType': 'TCP','unitId': 1 } \nreturn msg","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":640,"y":300,"wires":[["7f9b3178.ed9c9"]]},{"id":"a1ef58fe.777a78","type":"debug","z":"166e9137.258aaf","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":900,"y":380,"wires":[]},{"id":"9896a43e.0450d8","type":"modbus-client","name":"ESP01","clienttype":"tcp","bufferCommands":true,"stateLogEnabled":false,"queueLogEnabled":false,"tcpHost":"<IP_ADDRESS>","tcpPort":"502","tcpType":"DEFAULT","serialPort":"/dev/ttyUSB","serialType":"RTU-BUFFERD","serialBaudrate":"9600","serialDatabits":"8","serialStopbits":"1","serialParity":"none","serialConnectionDelay":"100","unit_id":1,"commandDelay":1,"clientTimeout":1000,"reconnectOnTimeout":true,"reconnectTimeout":2000,"parallelUnitIdsAllowed":true},{"id":"c51db702.7f4008","type":"eth-ip endpoint","address":"<IP_ADDRESS>","slot":"0","cycletime":"500","name":"","vartable":{"":{"LG1":{"type":"BOOL"},"RTN1":{"type":"BOOL"},"RSSI":{"type":"REAL"}}}}]

Should be fine now, without workarounds.
From node-red-contrib-modbus homepage: Node.JS 14.x is supported with v5.14.+

in my application the problem persists

Node.JS v14.16.1 with npm v6.14.12 and NR v1.3.1, maybe the npm not compatible in my case.

I gave it a retry with NR V2.0.6 and JS V14.18.0 but reconnect wont work
so i go back to JS V12.20.2

You mean you gave a try to the PR above? Can you share debug logs?

From what I see, this PR was merged into dev branch. There hasn't been a release yet since then. You'll have to wait for the next release for it to be included.

Do you know if this fix was included in version 5.15 just released? Thanks.

It should be included

I updated the node to version 5.15.0 and at the moment it works fine and it no longer stays disconnected.
I have:
25 Nov 16:49:39 - [info] Node-RED version: v2.1.3
25 Nov 16:49:39 - [info] Node.js version: v14.18.1


Allow selecting options by value

@david It looks like this is possible now. Can we close this issue?

This has been implemented https://github.com/mojotech/dill/commit/98e270a9b8ca4acb4ff69b3c2d364bfd2fb345f1.


Crypto fails

Traceback (most recent call last):
  File "./test.py", line 32, in <module>
    print(v.controls.flash_lights())
  File "/usr/local/lib/python3.7/dist-packages/tesla_api/controls.py", line 22, in flash_lights
    return self._api_client.post('vehicles/{}/command/flash_lights'.format(self._vehicle_id))
  File "/usr/local/lib/python3.7/dist-packages/tesla_api/__init__.py", line 85, in post
    raise ApiError(response_json['error'])
tesla_api.ApiError: Tesla API call failed: verify failed: crypto/rsa: verification error for txid `2xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx0`

Closing this, as it's a year old. If this is still reproducible, please reopen (and include any information that might help reproduce).
I've seen this error myself in the past, but I'm not sure I've seen it recently. It also seemed like an intermittent issue on Tesla's side, so I'm not sure there's anything we could fix here (i.e.


Fix bug in flexible_config.md

There was missing curly bracket "}" in krakend.json example.

I didn't see there is another pull request with the same bug fix

Thanks for reporting @tomaszprasolek


Adds support to run queries with group by over a column with null values

Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
ICM#315541374
Describe the problem that is addressed by this PR
When attempting to run  query like
SELECT COUNT(c.source) AS '_COUNT', c.source FROM c WHERE c.referenceNumber IN ('AAAAGDD', 'AAAAHGM')
GROUP BY c.source

over a data set that contained documents where source==null an error Failed to query item for container xxx: Cannot convert undefined or null to object was thrown. Instead it should return the aggregation for the value null.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
n/a
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
n/a
Command used to generate this PR:**(Applicable only to SDK release request PRs)
n/a
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Add FLARE-ON challenge

Details
I would like to have the binaries and solutions of the FLARE-ON challenge. My proposal is to:

Add a new category, something like Binaries, where we could also move the current PMA labs.
Add a flare-on.vm package which adds a FLARE-ON folder inside the new category with a subfolder per year with the binaries and solutions of that year.

Does someone know how big the binaries are? If the size if considerable, I would propose to have a package per year (flare-on.<date>.vm) and also add a README.txt to the FLARE-ON folder with short instructions about how to install the rest of the years. In the FLARE-VM default configuration we would then have only the last year.
In order to download the binaries and solutions, we need to make then available via a download URL, or is there such a URL in flare-on.com already? :thinking:
I thought we had already an issue for this, but It doesn't look like there is one already (or at least I was not able to find it). In case this is a duplicate, please let me know.

IMHO it's not really useful or worth the effort to add these


Added code for daily temperatures

Description
Fixes #2294
Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

Added in the beginning @sameeksharl


Is it possible to add comick.app?

Btw the bot looks very helpful. An embed system will make it cooler.

Hey!
I'll look around and contact the owner first to see if they have an API I could use. If they don't I'll try scraping and praying that the Cloudflare security level isn't too high for the website.
By the way, can you explain in more detail what you meant by embed system?

I sent an email to the owner/team at comick.app and am now waiting for a response.
Additionally, I looked around the website and it seems that scraping the website will be possible, but I cannot make any guarantees.
Thank you for leaving this suggestion!


ci: add tool to check for Cargo features

When running tests from .travis.yml, the passed in features are first checked locally for support in the current simulator. The list of supported features was manually maintained, allowing newly implemented features to be skipped, also skipping the related test (without warnings). This adds a new tool that parses and prints the list of features directly from the given Cargo.toml.

@d3zd3z Should be all fixed up now.


Clarify docker compose file for plugin developers

Fixes #82

Codecov Report

Merging #83 (85d7288) into master (2b33b2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   68.11%   68.11%
=======================================
  Files          15       15
  Lines         414      414
=======================================
  Hits          282      282
  Misses        132      132

Flag
Coverage Δ

pytest
68.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b33b2f...85d7288. Read the comment docs.


After running rake reset_statistics, Minitest::Reporters::MeanTimeReporter breaks Minitest

The :reset_statistics Rake task from the project Rakefile is mentioned numerous times in the source for Minitest::Reporters::MeanTimeReporter as doing what it says, and the Rake task itself looks too simple to fail.
However, after running the Rake task and then running rake, I see the following error output:
gemset/gems/minitest-reporters-1.3.5/lib/minitest/reporters/mean_time_reporter.rb:251:in `block in create_or_update_previous_runs!': undefined method `[]' for false:FalseClass (NoMethodError)
	from .../minitest-reporters-1.3.5/lib/minitest/reporters/mean_time_reporter.rb:250:in `each'
	from .../minitest-reporters-1.3.5/lib/minitest/reporters/mean_time_reporter.rb:250:in `create_or_update_previous_runs!'
	from .../minitest-reporters-1.3.5/lib/minitest/reporters/mean_time_reporter.rb:79:in `report'
	from .../minitest-reporters-1.3.5/lib/minitest/minitest_reporter_plugin.rb:26:in `each'
	from .../minitest-reporters-1.3.5/lib/minitest/minitest_reporter_plugin.rb:26:in `report'
	from .../minitest-5.11.3/lib/minitest.rb:808:in `each'
	from .../minitest-5.11.3/lib/minitest.rb:808:in `report'
	from .../minitest-5.11.3/lib/minitest.rb:141:in `run'
	from .../minitest-tagz-1.6.0/lib/minitest/tagz.rb:56:in `run'
	from .../minitest-5.11.3/lib/minitest.rb:63:in `block in autorun'

# Running tests with run options --seed 62125:

.........

Finished tests in 0.002525s, 3564.3564 tests/s, 3564.3564 assertions/s.

9 tests, 9 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to .../tmp/coverage. 26 / 26 LOC (100.0%) covered.
rake aborted!
Command failed with status (1)

Tasks: TOP => default => test
(See full trace by running task with --trace)

If I run the specs using any other reporter, there's no problem.
How to reset statistics safely for MeanTimeReporter?

Fixed by #296

Fixed by #296