“counter is atomic” test fails

Building unagi-chan-<IP_ADDRESS>...
Preprocessing library unagi-chan-<IP_ADDRESS>...
[ 1 of 14] Compiling Utilities        ( src/Utilities.hs, dist/build/Utilities.o )
[ 2 of 14] Compiling Data.Atomics.Counter.Fat ( src/Data/Atomics/Counter/Fat.hs, dist/build/Data/Atomics/Counter/Fat.o )
[ 3 of 14] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Types ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Types.hs, dist/build/Control/Concurrent/Chan/Unagi/NoBlocking/Types.o )
[ 4 of 14] Compiling Control.Concurrent.Chan.Unagi.Constants ( src/Control/Concurrent/Chan/Unagi/Constants.hs, dist/build/Control/Concurrent/Chan/Unagi/Constants.o )
[ 5 of 14] Compiling Control.Concurrent.Chan.Unagi.Internal ( src/Control/Concurrent/Chan/Unagi/Internal.hs, dist/build/Control/Concurrent/Chan/Unagi/Internal.o )
[ 6 of 14] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Internal ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Internal.hs, dist/build/Control/Concurrent/Chan/Unagi/NoBlocking/Internal.o )
[ 7 of 14] Compiling Control.Concurrent.Chan.Unagi.NoBlocking ( src/Control/Concurrent/Chan/Unagi/NoBlocking.hs, dist/build/Control/Concurrent/Chan/Unagi/NoBlocking.o )
[ 8 of 14] Compiling Control.Concurrent.Chan.Unagi.Unboxed.Internal ( src/Control/Concurrent/Chan/Unagi/Unboxed/Internal.hs, dist/build/Control/Concurrent/Chan/Unagi/Unboxed/Internal.o )
[ 9 of 14] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Unboxed.Internal ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed/Internal.hs, dist/build/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed/Internal.o )
[10 of 14] Compiling Control.Concurrent.Chan.Unagi.Unboxed ( src/Control/Concurrent/Chan/Unagi/Unboxed.hs, dist/build/Control/Concurrent/Chan/Unagi/Unboxed.o )
[11 of 14] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Unboxed ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed.hs, dist/build/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed.o )
[12 of 14] Compiling Control.Concurrent.Chan.Unagi.Bounded.Internal ( src/Control/Concurrent/Chan/Unagi/Bounded/Internal.hs, dist/build/Control/Concurrent/Chan/Unagi/Bounded/Internal.o )
[13 of 14] Compiling Control.Concurrent.Chan.Unagi.Bounded ( src/Control/Concurrent/Chan/Unagi/Bounded.hs, dist/build/Control/Concurrent/Chan/Unagi/Bounded.o )
[14 of 14] Compiling Control.Concurrent.Chan.Unagi ( src/Control/Concurrent/Chan/Unagi.hs, dist/build/Control/Concurrent/Chan/Unagi.o )
Preprocessing test suite 'test' for unagi-chan-<IP_ADDRESS>...
[ 1 of 26] Compiling Utilities        ( src/Utilities.hs, dist/build/test/test-tmp/Utilities.dyn_o )
[ 2 of 26] Compiling IndexedMVar      ( tests/IndexedMVar.hs, dist/build/test/test-tmp/IndexedMVar.dyn_o )
[ 3 of 26] Compiling Data.Atomics.Counter.Fat ( src/Data/Atomics/Counter/Fat.hs, dist/build/test/test-tmp/Data/Atomics/Counter/Fat.dyn_o )
[ 4 of 26] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Types ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Types.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/NoBlocking/Types.dyn_o )
[ 5 of 26] Compiling Control.Concurrent.Chan.Unagi.Constants ( src/Control/Concurrent/Chan/Unagi/Constants.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Constants.dyn_o )
[ 6 of 26] Compiling Control.Concurrent.Chan.Unagi.Internal ( src/Control/Concurrent/Chan/Unagi/Internal.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Internal.dyn_o )
[ 7 of 26] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Internal ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Internal.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/NoBlocking/Internal.dyn_o )
[ 8 of 26] Compiling Control.Concurrent.Chan.Unagi.NoBlocking ( src/Control/Concurrent/Chan/Unagi/NoBlocking.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/NoBlocking.dyn_o )
[ 9 of 26] Compiling UnagiNoBlocking  ( tests/UnagiNoBlocking.hs, dist/build/test/test-tmp/UnagiNoBlocking.dyn_o )
[10 of 26] Compiling Control.Concurrent.Chan.Unagi.Unboxed.Internal ( src/Control/Concurrent/Chan/Unagi/Unboxed/Internal.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Unboxed/Internal.dyn_o )
[11 of 26] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Unboxed.Internal ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed/Internal.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed/Internal.dyn_o )
[12 of 26] Compiling Control.Concurrent.Chan.Unagi.Unboxed ( src/Control/Concurrent/Chan/Unagi/Unboxed.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Unboxed.dyn_o )
[13 of 26] Compiling Control.Concurrent.Chan.Unagi.NoBlocking.Unboxed ( src/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/NoBlocking/Unboxed.dyn_o )
[14 of 26] Compiling UnagiNoBlockingUnboxed ( tests/UnagiNoBlockingUnboxed.hs, dist/build/test/test-tmp/UnagiNoBlockingUnboxed.dyn_o )
[15 of 26] Compiling UnagiUnboxed     ( tests/UnagiUnboxed.hs, dist/build/test/test-tmp/UnagiUnboxed.dyn_o )
[16 of 26] Compiling Control.Concurrent.Chan.Unagi.Bounded.Internal ( src/Control/Concurrent/Chan/Unagi/Bounded/Internal.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Bounded/Internal.dyn_o )
[17 of 26] Compiling Control.Concurrent.Chan.Unagi.Bounded ( src/Control/Concurrent/Chan/Unagi/Bounded.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi/Bounded.dyn_o )
[18 of 26] Compiling UnagiBounded     ( tests/UnagiBounded.hs, dist/build/test/test-tmp/UnagiBounded.dyn_o )
[19 of 26] Compiling Control.Concurrent.Chan.Unagi ( src/Control/Concurrent/Chan/Unagi.hs, dist/build/test/test-tmp/Control/Concurrent/Chan/Unagi.dyn_o )
[20 of 26] Compiling Implementations  ( tests/Implementations.hs, dist/build/test/test-tmp/Implementations.dyn_o )
[21 of 26] Compiling Deadlocks        ( tests/Deadlocks.hs, dist/build/test/test-tmp/Deadlocks.dyn_o )
[22 of 26] Compiling DupChan          ( tests/DupChan.hs, dist/build/test/test-tmp/DupChan.dyn_o )
[23 of 26] Compiling Smoke            ( tests/Smoke.hs, dist/build/test/test-tmp/Smoke.dyn_o )

tests/Smoke.hs:175:14: warning: [-Wdeprecations]
    In the use of ‘isEmptyChan’
    (imported from Control.Concurrent.Chan):
    Deprecated: "if you need this operation, use Control.Concurrent.STM.TChan instead.  See <http://ghc.haskell.org/trac/ghc/ticket/4154> for details"
[24 of 26] Compiling Unagi            ( tests/Unagi.hs, dist/build/test/test-tmp/Unagi.dyn_o )
[25 of 26] Compiling Atomics          ( tests/Atomics.hs, dist/build/test/test-tmp/Atomics.dyn_o )
[26 of 26] Compiling Main             ( tests/Main.hs, dist/build/test/test-tmp/Main.dyn_o )
Linking dist/build/test/test ...
running tests
Running 1 test suites...
Test suite test: RUNNING...
Assertions: On
Testing atomic-primops:
    counter smoke test... OK
    counter overflow... OK
    counter is atomic... test: Counter broken: expecting 10000000 got 9999984
CallStack (from HasCallStack):
  error, called at tests/Atomics.hs:150:9 in main:Atomics
Test suite test: FAIL
Test suite logged to: dist/test/unagi-chan-<IP_ADDRESS>-test.log
0 of 1 test suites (0 of 1 test cases) passed.
builder for '/nix/store/9df6kxl68z3ij9hdsdis8p5f2l3wfwxd-unagi-chan-<IP_ADDRESS>.drv' failed with exit code 1

Can you please paste me the exact versions of the dependencies you're compiling with? (atomic-primops is the one I'm really interested in).
Also uname -a.

(and GHC version, please)

You can find all dependencies here: https://headcounter.org/hydra/build/2167633#tabs-build-deps
The system is an x86_64-linux, the build is done by nix.

Hm, I don't get this failure when trying to repro locally with  ghc-8.0.1 (I don't have 8.0.2 installed atm) and atomic-primops <IP_ADDRESS>.  I'm not sure how to repro from this since I'm not really familiar with nix.
Would you be able to try running the test suite for atomic-primops using the same configuration you used to build unagi-chan? There should be tests of the atomicity of fetch-and-add primops there. Alternatively could you spell out steps to repro with nix?
This definitely would seem to be a bad bug upstream (either in ghc or atomic-primops) that I'd like to be able to help sort out.


Update Package.toml

Changing URL to original repo

I’m concerned that old versions might not be installable. All the registrered tree hashes must be present in the new repo. Someone needs to confirm that is the case. Check out previous threads like https://github.com/JuliaRegistries/General/pull/58361

Concerning older versions: I am very doubtful that this package is used by anyone else as it has not been advertised. I can only offer my personal reassurances that it is not used. I can always insert a message in the currently registered repo that the URL has been updated. If this is not convincing, then let us drop this issue. Thanks for your input.

It's OK if the repo has been updated, the problem is if older versions become uninstallable due to changing the URL here. If the code associated to a version of the package exists in the old repo but not the new repo, and the package manager looks in the new repo for that code and doesn't find it, suddenly the old working version will abruptly stop working (without the user doing anything). Even if there's very few users, that's not something the General registry wants to ever happen.
However, that doesn't mean you can't ever change repos. It just means the new repo has to contain all the old versions in the commit history somewhere. We can check this as follows, based on the code from @GunnarFarneback here. First we clone the new repo, cd into it, and start a julia session:
git clone https://github.com/ngiann/FastParzenWindows.jl.git
cd FastParzenWindows.jl
julia

Here, git cloning gives me this warning:
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'src/FastParzenWindows.jl'
  'src/fastparzenwindows.jl'

I think this is a real problem and means your package will be impossible to use on some systems - however, AutoMerge should catch this issue next time you try to register a version, so we don't need to deal with it now.
Then in our Julia session, we use the package RegistryInstances to check which tree hashes corresponding to versions of this package have been registered, and check if they are present in the new repo:
using RegistryInstances, UUIDs
pkg_name = "FastParzenWindows"

# Load General registry
general = only(filter!(r -> r.uuid == UUID("23338594-aafe-5451-b93e-139f81909106"), reachable_registries()))
pkg = general.pkgs[only(uuids_from_name(general, pkg_name))]
versions = registry_info(pkg).version_info
for version in sort(collect(keys(versions)))
    tree_sha = versions[version].git_tree_sha1
    print(version)
    try
        readchomp(`git rev-parse -q --verify "$(tree_sha)^{tree}"`)
        println(" found")
    catch
        println(" missing")
    end
end

This gives me just
0.1.2 found

Great! That means the only old version still has code present in the new repo, and changing the URL should be OK. I'll merge this then. However you'll want to take care of the file name clash before you register your next version of the package.

I can't thank you enough for taking the time and interest to provide me
with such a detailed answer! To be honest, I don't fully understand all the
technical details you mention, but I will reproduce the steps you outlined
on my local machine to better understand the situation. I will rename what
used to be the registered repo to something else. Many thanks again!
On Sun, 8 Jan 2023 at 15:33, Eric Hanson @.***> wrote:

Merged #75319 https://github.com/JuliaRegistries/General/pull/75319
into master.
—
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/75319#event-8176612506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTNOSAKTDOWAI5IO3G437TWRLF5PANCNFSM6AAAAAATUQ4OMI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Support pods dns resolve

We have supported statefulset pods dns resolve, for others with subdomain  set but not belong to statefulset, should we also support?
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-hostname-and-subdomain-fields

Makes sense to me

So what is the logic, and pod with subdomain matching the name of a headless Service that selects it gets a DNS record for hostname.subdomain.namespace.svc.cluster.local? And statefulset is not "special", it just meets that criteria?

Exactly that's what i think, and we need to  store pod hostname and subdomain to istioEndpoint


Pin cpuinfo to same revision as pthreadpool

Why is it needed? The latest revision should work.

The latest revision is broken when cmake < 3.12 (https://github.com/pytorch/cpuinfo/pull/62). This way downstream dependencies won't randomly break consumers of NNPACK.

No longer needed as pytorch/cpuinfo#62 has landed.


Removing PV usage percentage numbers from runbooks doc text

As we are changing the alert percentages from newer ODF version onwards, making the runbooks documentation texts general, thus making runbooks not dependant on ODF versions.

@jmolmo , @weirdwiz , please take a look at the changes.
Thanks

@agarwal-mudit , it is already approved by @jmolmo , but it is not yet merged. Can you please take a look (and approve if any additional sanction is required)?


Dapr 1.9.1 Checksum mismatch

Describe the bug

When building a docker container with go we have a step which calls go mod download.  We are getting the following error:
#11 [builder 6/9] RUN go mod download
#11 7.066 verifying<EMAIL_ADDRESS>checksum mismatch
#11 7.066 	downloaded: h1:f5gV8HtGz6iBJSsh6eI+/Ews4sGC3W9gX0/oD9ANVqM=
#11 7.066 	go.sum:     h1:SwfLYwqFwBNn1B8pCzGGG49utjV3oMQLZOlOkmf63T8=
#11 7.066
#11 7.066 SECURITY ERROR
#11 7.066 This download does NOT match an earlier download recorded in go.sum.
#11 7.066 The bits may have been replaced on the origin server, or an attacker may
#11 7.066 have intercepted the download attempt.
#11 7.066
#11 7.066 For more information, see 'go help module-auth'.
#11 ERROR: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1

To Reproduce

Have an application with an earlier version of the Dapr SDK in your go.mod file
Update to Dapr 1.9.1

Expected behavior

Not get a checksum mismatch when updating Dapr.

How did you upgrade the reference? I can't reproduce it

I have no idea how this keeps happening with Dapr go-sdk, this is the only project I keep having this issue.
The reason this happens is that the hash of the repository is different from what is known in the Go sum DB, to validate this:

Install https://github.com/vikyd/go-checksum: go install github.com/vikyd/go-checksum
Clone Dapr: git clone https://github.com/dapr/go-sdk.git
Checkout 1.9.1: cd go-sdk; git checkout v1.9.; cd ..
Get the checksum of the go.mod file: go-checksum go-sdk/go.mod, note GoCheckSum (h1:bK9bNEsC6hY3RMKh69r0nBjLqb6njeWTEGVMOgP9g20=)
Get the checksum of the repository content: go-checksum go-sdk<EMAIL_ADDRESS>note GoCheckSum (h1:WTzL+kH5evyGL6LUZvNIRK8U+CfDFl9btTgv8DFpjI8=)
Get the checksums from the Go sum DB: curl<EMAIL_ADDRESS>
Note that the hash of the go.mod from the repo and Go sum DB match up (h1:bK9bNEsC6hY3RMKh69r0nBjLqb6njeWTEGVMOgP9g20=) but that the repo hash doesn't match up: h1:f5gV8HtGz6iBJSsh6eI+/Ews4sGC3W9gX0/oD9ANVqM= vs h1:WTzL+kH5evyGL6LUZvNIRK8U+CfDFl9btTgv8DFpjI8=.

Something else that I just noticed. When I do:
go get github.com/dapr/go-sdk@2a85a7bb6a1447929720d7df779bff7f0ed41c24 (which is one commit after v1.9.1, 29bf88b1b089e2c99b27b2d0f8d460a936f749fe)
And then do go mod vendor, I don't only get the difference between the two commits (git diff 29bf88b1b089e2c99b27b2d0f8d460a936f749fe...2a85a7bb6a1447929720d7df779bff7f0ed41c24):
diff --git a/client/client.go b/client/client.go
index a40a36f..7a82fe9 100644
--- a/client/client.go
+++ b/client/client.go
@@ -283,7 +283,7 @@ func NewClientWithAddressContext(ctx context.Context, address string, opts ...Cl
        }

        if cOpts.useTLS || strings.Contains(address, "https://") {
-               option = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{}))
+               option = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{MinVersion: tls.VersionTLS12}))
        } else {
                option = grpc.WithTransportCredentials(insecure.NewCredentials())
        }

But I actually get the following change in my vendor folder:
diff --git a/vendor/github.com/dapr/go-sdk/client/client.go b/vendor/github.com/dapr/go-sdk/client/client.go
index ad5ac0da..7a82fe92 100644
--- a/vendor/github.com/dapr/go-sdk/client/client.go
+++ b/vendor/github.com/dapr/go-sdk/client/client.go
@@ -283,7 +283,7 @@ func NewClientWithAddressContext(ctx context.Context, address string, opts ...Cl
        }

        if cOpts.useTLS || strings.Contains(address, "https://") {
-               option = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{}))
+               option = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{MinVersion: tls.VersionTLS12}))
        } else {
                option = grpc.WithTransportCredentials(insecure.NewCredentials())
        }
@@ -294,6 +294,7 @@ func NewClientWithAddressContext(ctx context.Context, address string, opts ...Cl
                address,
                option,
                grpc.WithUserAgent(userAgent()),
+               grpc.WithBlock(),
        )
        cancel()
        if err != nil {

The extra change comes from https://github.com/dapr/go-sdk/pull/471 (commit 5eecffa4fa3df1825d5149471edd83e4aa89e7ba), which should be part of  v1.9.1, and it is on Git, but not in the Go package. So this is another indication there is some difference between what's on Git an what is known to the Go registries.

It does look like the tag has been modified. I appreciate it's frustrating. There is a release coming up soon that should not face the same issue, I'll keep this issue appraised of the latest as well as investigate how we can ensure this doesn't happen going forwards.

Thank you @mikeee! Will keep an eye out, for now I have set the dependency to go get github.com/dapr/go-sdk@2a85a7bb6a1447929720d7df779bff7f0ed41c24 to get around this issue.


change editor description of a child scene causing multiple open in editor buttons in the Scene tab

Tested versions
Godot V4.4 dev1.official
Godot V4.4 dev[906a4e9db91c2c6b17a0cb1cddf2a96f64114646]
System information
Godot v4.4.dev1 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 590 Series (Advanced Micro Devices, Inc.; 31.0.21905.1001) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)
Issue description
In editor's Scene tab, a node of instanced scene has a button "open in editor"
What's wrong: there will be multiple "open in editor" buttons after changing the "editor description" of an instanced scene.
What's expected: there should be only one "open in editor" button and it already exists
P.S. I found this when i'm poking a instanced .glb scene's editor description.
Steps to reproduce

create a scene
create another scene
add one scene into another
change instanced scene node's editor description

https://github.com/user-attachments/assets/0006fbcb-8dd8-43bc-9762-809c030fc12c
Minimal reproduction project (MRP)
N/A

Can reproduce it in v4.3.stable too

I've identified the code responsible for this, will take a look at fixing it

I've identified the code responsible for this, will take a look at fixing it

Nice! Is it #82916?

That's indeed the PR that introduced it, thank you for finding it!

Someone else will probably beat me to it, but here is what I found:
https://github.com/godotengine/godot/blob/139f9989e6afcc9376c1c3551cc410ce04981163/editor/gui/scene_tree_editor.cpp#L519
We are adding the "Open in Editor" button every time the scene tree node tooltip is updated (signal gets emitted from the UI for description, in this case)
		p_item->add_button(0, get_editor_theme_icon(SNAME("InstanceOptions")), BUTTON_SUBSCENE, false, TTR("Open in Editor"));

This is only for inherited scenes or if can_open_instance is true - not sure what that would signify yet.
So there should be a way to check if p_item already has an "open in editor" button, and only add it if it is missing.

Indeed, see the fix above :)


[lagobot] enable pipenv

Summary
How was it tested?

Current dependencies on/for this PR:

main

PR #820   👈

This comment was auto-generated by Graphite.


Feature/35 removeuser trigger

Fixes #35

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

v1.6.0
GitHub release

Your semantic-release bot :package::rocket:


Changing  force thresholds in hand_sequences.ini for ARE

Hi,
when trying to initiating some grasping and other hand-related actions using the ActionsRenderingEngine (ARE), the force thresholds as specified for each action and joint are surpassed pretty much all the time such that no grasping takes place (see log-file excerpt below). This happens without any object being present.
The (Python-) script I am using used to work, but after a hard drive failure and a complete re-install of the OS, yarp, icub-main etc, I am now experiencing the above problem.
I am planning to iteratively increase the allowed thresholds in the hand_sequences.ini file such that the grasping (and other) actions will finally be executed and wonder if anything speaks against that.
Also: if anyone has any idea what could have caused this change/spike in the sensor-readings I'd be curious to know.
The script I am using is the same that was used in the context of icub-main/issue #417, which means that I send a 0 to /wholeBodyDynamics/rpc:i for re-initialization prior to sending the ARE command.
Back then, I had a similar issue with some arm joint, but that was solved by a) increasing the allowed threshold and, b) having wholeBodyDyamics re-initialize prior to each ARE action.
Here are some snippets from the ARE log-file that show  how the force thresholds are exceeded once some command is received:
log_icubsrv_actionsRenderingEngine_7138_excerpt.txt
As can be seen from the log-file pretty much every involved joint exceeds the thresholds specified in hand_sequences.ini.
Another thing that changed in the script is the use of the new IControlMode2 interface as the old one has become deprecated. I am using a mix of cartesian control, position control, and ARE commands, and prior to issuing position control commands I issue a
iCtrl.setControlMode(j, yarp.encode('pos'), where iCtrl is an instance of iControlMode2
(before that, in the old interface, I used posCtrl.setPositionMode()).
I don't think this has any bearing on the issue, but I just thought I mention it in case anything else has changed in the meantime.
(I don't, for example, switch the control mode back to some other mode after using position control and prior to issuing ARE commands, assuming ARE will take care of that by itself).
Thanks in advance for any help.

Hi @frank-foerster
Thresholds in hand_sequences.ini
Did you try to recalibrate the fingers? This may help out:
$ yarp rpc /actionsRenderingEngine/cmd:io
>> calib fingers

ARE w/ WBD
ARE already talks to WBD to make sure that it is calibrated force-wise prior to commencing an action, thus, in principle, you wouldn't need to do that yourself explicitly.
The connection in question is:
<connection>
  <from>/actionsRenderingEngine/wbd:rpc</from>
  <to>/wholeBodyDynamics/rpc:i</to>
  <protocol>fast_tcp</protocol>
</connection

Hi @pattacini
no, I hadn't recalibrated the fingers. I did actually not know that you can do that.
I will try this tomorrow and will report back.
Thanks

@pattacini
This did the trick! After calibration, no more "threshold violations"!
Many thanks!

Happy to know it helped!


fix:added mobile validation for 11 digits and on error scroll to top

Fixes #2675
Changes proposed in this pull request:
added mobile validation for 11 digits
scrolling to the top when there is an error while creating / updating the patient
since its misleading and user might not be aware if the error is in the button or its a validation check

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Reverie-PC seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @jayavardhan3112, can you sign our Contributor License Agreement? Thanks

Hi @jayavardhan3112, can you sign our Contributor License Agreement? Thanks

I have already done that, but dont know why its not updating

Hi @jayavardhan3112, can you sign our Contributor License Agreement? Thanks

I have already done that, but dont know why its not updating

I believe the reason is that the author email on your commits doesn't correspond to your GitHub email. I would recommend amending your commits so that your email corresponds to your GitHub account: https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit


Clinical signs and symptoms widget crashing in development

As noted by @prashantuniyal02, the clinical signs and symptoms widget is crashing in development for pages like melanoma.
The API response is apparently clean (to me), so we might need to diagnose what exactly is causing the widget to crash.
I could confirm the reason for crashing is not the same as #2923.
@chinmehta could you diagnose what could be going on?

this is still observed in current deployment

thank you @chinmehta for fixing this!

Clinical signs and symptoms widget is working in the latest dev deployment.
#2923 is still crashing but as David mentioned the reason is different.


0% code coverage on dlrs_CampaignMemberTrigger and 'MALFORMED_ID' error when deploying changeset

Have recently tried to deploy a custom visualforce component with related Apex Triggers for a client where we are using DLRS. I am using DLRS to provide a count on the Account of Contacts who are also Campaign Members. The change set we are deploying relates only to the Opportunity object.
Unfortunately the developer I am working with has no experience with DLRS and I don't have the code knowledge to work this out myself. I've noticed that other users have hit similar issues previously but they were resolved in later releases? We are using the most up to date release of DLRS so I'm really at a loss as to how this can be fixed.
See Screenshot below of error being thrown. Hope someone can help or we'll have no choice but to uninstall DLRS as what we are trying to deploy is critical for the client.

Take a look at this issue, https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197, this covers something similar. This should suffice for you, but let me know if not.


Replace Pipenv with Poetry

I rebuilt the devcontainer, everything was fine.
I managed to deploy the cluster without any problems using vscode.

I rebuilt the devcontainer, everything was fine.
I managed to deploy the cluster without any problems using vscode.


Intellij IDEA support?

Hi thanks for this wonderful project! I am using Intellij IDEA and it has great support for traditional Helm charts. For example, when I type in {{ .Values.xxx}}, it will automatically give me hints on all available choices, and I can click it to directly jump to that variable definition. However, I cannot find how to do this with helmfile. Thanks very much!

@fzyzcjy Hey! Sorry for taking too long to reply. Unfortunately this is clearly out of scope of Helmfile and my spare time... I do see the value in having an IDE support though. How about submitting the same feature request to the issue tracker of the IDE of your choice, like IntelliJ IDEA, VS Code, etc?
If anyone reading this has your own implementation of such IDE plugin/extension, please feel free to share it here!

Please vote/watch https://youtrack.jetbrains.com/issue/IDEA-243811


Ever Growing ips.list file

I discovered an issue with fetching fresh IP blocklist data from blocklist.de which was appending to the file each time the files were generated causing the input data source of blocklist.de to grow at an alarming rate. This script error has been addressed in https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/commit/3427158f58cebd53098ed8f93d070dd1540e6675 and you will notice a dramatic decline in the size of the ips.list file.
@maravento

@maravento I kept the original list of blocklist.de which was being appended to in case you need it for removal purpose or comparison against current list.
Current list > https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/blob/master/.input_sources/_www.blocklist.de/ips.txt
List that was being appended to > https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/blob/master/.input_sources/_www.blocklist.de/all.txt

@mitchellkrogza Hi. I see that now there are only ips (not CIDR) addresses. Is this correct? (if so, better since the debugging is faster)

Hi @maravento yes indeed, because of me (stupidly) appending to the file when collecting data from blocklist.de it was also accumulating any debugging / removals they were doing on their own side. The ips.list now looks a lot cleaner and as you can see has reduced in size by +- 300,000 entries.
I also used your pipe and sort for the ips.list file
sort -t . -k 1.1n -k 2.2n -k 3,3n -k 4,4n -k 5,5n -k 6,6n -k 7,7n -k 8,8n -k 9,9n $_input2 | sed 's/^[ \s]//;s/[ \s]$//' | sed "/:/d" | uniq > $_input4 && mv $_input4 $_input2

@maravento have you got a good pipe to clean the domains.list file of any unwanted characters? Currently I am only running a simple pipe sed '/\./!d' to clean out any lines not containing a . but tested the latest domains.list now and found about 64 spaces which will lead to dupes.

I think it is better to "extract domains" since there will always be unwanted characters, because if you remove one, another appears:
regexd='([a-zA-Z0-9][a-zA-Z0-9-]{1,61}.){1,}(.?[a-zA-Z]{2,}){1,}'
egrep -oi "$regexd" domains.list > new
Also (if you want) you can put "dot" at the beginning:
egrep -oi "$regexd" domains.list | awk '{print "."$1}'
Also (if you want) remove www, ftp ... (which are not part of the domain):
egrep -oi "$regexd" domains.list | awk '{print "."$1}' | sed 's:(www[[:alnum:]].|WWW[[:alnum:]].|ftp.|...|/.*)::g' | sort -u > new

@maravento I created a new separate domain list file for testing using your pipe's and regex as above. Have a look at it and let me know your thoughts > https://hosts.ubuntu101.co.za/domains-dotted-format.list
I think it might need some tweaking, some domains like zzz.domain.com, we should probably strip out the zzz.
Let me know your feedback.

hi @mitchellkrogza. what is the difference between:
https://hosts.ubuntu101.co.za/domains.list
vs
https://hosts.ubuntu101.co.za/domains-dotted-format.list

@maravento the second is as per your earlier regex example, stripping out all www, WWW, ftp and starting each line with a .

@maravento I changed the way the file is processed, was using the wrong pipe. Check now at the latest list. I can spot 2 errors in it which is easy to fix ..doubleclick.com and ..doubleclick.net

The above list simply runs the following command and solves everything:
sed 's:(www[[:alnum:]].|WWW[[:alnum:]].|ftp.|...|/.*)::g' domains-dotted-format.list | sort -u > new-domains-dotted-format.list
in the result no longer exists .. or .www ... etc

Thanks @maravento I will update it tomorrow and notify you when done so you can double check I got it right :+1:

@mitchellkrogza. Debug TLDs. there are some on the list (.com.ai, .com.br, .com.cn, .com.es, etc)
example:
grep -Pri '^.com.es$' domains-dotted-format.list
.com.es
You can debug these TLDs with the IANA and Mozilla lists:
https://publicsuffix.org/list/public_suffix_list.dat
https://data.iana.org/TLD/tlds-alpha-by-domain.txt

Hi @maravento I am currently using this which I checked and looks exactly the same as the sed you suggested.
cat $TRAVIS_BUILD_DIR/domains.list | sed 's:(www[[:alnum:]].|WWW[[:alnum:]].|ftp.|...|/.*)::g' | awk '{print "."$1}' | sort -u > $TRAVIS_BUILD_DIR/domains-dotted-format.tmp && mv $TRAVIS_BUILD_DIR/domains-dotted-format.tmp $TRAVIS_BUILD_DIR/domains-dotted-format.list
How do I deal with it adding an extra dot onto ..doubleclick.com and ..doubleclick.net ?

correct way is:
awk '{print "."$1}'| sed 's:(www[[:alnum:]].|WWW[[:alnum:]].|ftp.|...|/.)::g' | sort -u
not
sed 's:(www[[:alnum:]].|WWW[[:alnum:]].|ftp.|...|/.)::g' | awk '{print "."$1}' | sort -u

Thanks @maravento I made that change and did a re-gen, can you check the latest output file it created as I am away from my desk now. Let me know and thanks for your help.

or easy:
awk '{print "."$1}' | sed -r 's:((www|ftp)[[:alnum:]]*?.)::gi'
example:
www3.doubleclick.com or wwwWx99.doubleclick.com
result: .
doubleclick.com

wwwABC88.doubletest.com
.wwwWx09.doubleclick.com
.doublesite.com
..doublexxx.com
sed -r 's:(^.?(www|ftp)[[:alnum:]]?.|^..?)::gi' prueba | awk '{print "."$1}' | sort -u
.doubleclick.com
.doublesite.com
.doubletest.com
.doublexxx.com

Thanks @maravento I’ll give it another shot on Saturday as I am out all day tomorrow, thank for all the advice :+1:

@maravento I tired that but now getting a lot of .. output. Also found another issue of some domains being pulled in which contain _ underscore characters like ___id___.c.mystat-in.net and gay_sexo__anal.midaxcom.com and galerie_femme_mure_poilue.paris-transsexuelle.info which all need to be stripped out as underscores are not valid in dns. ???

list:
.--xxx.com
.-yyy.com
.*zzz.com
.test.com
sed -r '/^.\W+/d' list > newlist
newlist:
.test.com
for the other case, wait for some tests

@maravento Houston ... the Eagle has landed ..... I have it sorted now using
sed -r 's:(^.?(www|ftp)[[:alnum:]]?.|^..?)::gi' $TRAVIS_BUILD_DIR/domains.list | awk '{print "."$1}' | sed '/_/d' | sed 's/\.\././g' | sort -u > $TRAVIS_BUILD_DIR/domains-dotted-format.list
👍
Now to clean the actual domains input list which generates the hosts file so it also removes underscores as they are simply not valid in any DNS system and this will significantly reduce the list size.
Shows how may people producing hosts list pay any sort of attention to what they are blacklisting, neither are they even testing or cleaning their lists as @funilrys will attest to 😁
Thanks again for all your constant help and input to the project.
The dotted format list will become very useful for people using dnsmasq which allows wildcarding with a dotted format list.


Support multiple rooms

Logic is currently hard coded to only work for one spawn.

For now, just need to update the main loop to iterate over spawns (still assuming only one spawn in a room) instead of just using a single spawn.


about subscribed clients list

hi, is that any way to check how many client subscribed a topic?

Hi, If you're using aedes with redis-persistence then you can get the the list of clientIds against a hash key which looks like sub:client:topic

It would be a nice PR for aedes-persistence.

thanks GavinDmello, i found that aedes.clients saved all clients info.
this code is what i want:
aedes.clients[Object.keys(aedes.clients)].subscriptions
is that ok ?

This approach will work if you have one client subscribing, may not work for multiple clients.

@GavinDmello yeah! thanks for help


Various Linux Fixes

The failure of Invoke-DbaDbMirroring highlighted a few issues with the way we handle paths.

I still have some fixes to do on Backup-DbaDatabase that relate to path but need a dedicated branch for those

Going to merge bc I need to do a few other things


MongoDB: improve error message Inconsistent column data: Malformed ObjectID by including the field(s) in the message

Currently, the error message only mention the faulty value but doesn't say if one or more fields are implicated and on which field it failed.
It seems like it errors on the first one.
Example from test
 test('should throw Malformed ObjectID error: in 2 different fields', async () => {
    const post = prisma.post.create({
      data: {
        id: 'something invalid 1111', // first
        published: false,
        title: 'Some title',
        ids: ['something invalid 2222'], // second
      },
    })

    // Message doesn't distinguish if one or more values failed / which one failed
    // seems it errors on the first one
    expect(post).rejects.toThrowErrorMatchingInlineSnapshot(`

      Invalid \`prisma.post.create()\` invocation in
      /client/src/__tests__/integration/happy/blog-env-mongo/test.ts:0:0

        181 })
        182
        183 test('should throw Malformed ObjectID error: in 2 different fields', async () => {
      → 184   const post = prisma.post.create(
        Inconsistent column data: Malformed ObjectID: invalid character 's' was found at index 0 in the provided hex string: "something invalid 1111".
    `)
  })

Might be done already. Next steps:

See if this is fixed, otherwise fix it.

See test on main branch, the snapshot didn't change since I originally created in this issue from what I see
https://github.com/prisma/prisma/blob/main/packages/client/src/__tests__/integration/happy/blog-env-mongo/test.ts#L191-L205

Related to https://github.com/prisma/prisma/issues/12096


fix: weatehr alert getter

:tada: This PR is included in version 1.17.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Incorrect index when prepending widget in listview

Steps to Reproduce
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'List playground',
      home: TestPage(),
    );
  }
}

class TestPage extends StatefulWidget {
  @override
  State<StatefulWidget> createState() => _TestPageState();
}

class _TestPageState extends State<TestPage> {
  List<int> items = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20]; //init list of items
  void _addItem({bool append}) {
    var now = DateTime.now().millisecondsSinceEpoch;
    if (append) {
      items.add(now);
    } else {
      items.insert(0, now);
    }
    setState(() {
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: ListView.custom(
          reverse: false,
          childrenDelegate: SliverChildListDelegate(
            List<Widget>.from(items.map((item) => _buildItem(item, items.indexOf(item))))
          ),
        ),
      ),
      bottomNavigationBar: BottomAppBar(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            FlatButton(
              onPressed: () => _addItem(append: true),
              child: Text('Append item'),
            ),
            FlatButton(
              onPressed: () => _addItem(append: false),
              child: Text('Prepend item'),
            ),
          ],
        ),
      ),
    );
  }

  Widget _buildItem(int data, int index) {
    return TestProxy(
      key: ValueKey(data),
      child: Container(
        height: 80.0,
        padding: EdgeInsets.all(16.0),
        decoration: BoxDecoration(
          border: Border(bottom: BorderSide()),
        ),
        child: Center(
          child: Text("index: $index . . . $data"),
        ),
      ),
    );
  }
}

class TestProxy extends StatefulWidget {
  final Widget child;

  const TestProxy({Key key, this.child}) : super(key: key);

  @override
  _TestProxyState createState() => _TestProxyState();
}

class _TestProxyState extends State<TestProxy> with AutomaticKeepAliveClientMixin {
  @override
  bool get wantKeepAlive => true;

  @override
  void initState(){
    super.initState();
    print("");
    //print("Rebuild for ${widget.key.toString()}");
    print("");
  }

  @override
  Widget build(BuildContext context){
    super.build(context);
    return widget.child;
  }
}

scroll all the way to the end of list
click prepend item
scroll back to beginning, the item that prepended is not visible, which it should

same issue here
for number

click prepend item

prepend multiple times to see the issue on hand easily(more than once at least).
Flutter doctor -v :
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G95, locale en-US)
    • Flutter version 1.9.1+hotfix.4 at /Users/fa****/Desktop/flutter
    • Framework revision cc949a8e8b (10 days ago), 2019-09-27 15:04:59 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/fa****/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.0, Build version 11A420a
    • CocoaPods version 1.8.0

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • iPhone 11 • 8F32A367-AE35-489B-94DA-A*********** • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)

• No issues found!

It looks like when a new element insert into front everything got shifted by one index. That bump a new element that is previously invisible into view. That newly created element with 0 layout offset which make the scrollable think the newly created element is the begin of list, which messes things up.
We should either give a more reasonable scroll offset or make RenderSliver better detect offset and self correct.

Any news on this?
It's a really bad bug imho

for the widget you are trying to display in the list view just wrap the state with a keepalive.
for example
class _Post extends State  with AutomaticKeepAliveClientMixin{
and dont forget to implement the keep alive above the build like so and add the super.build in widget.
get wantKeepAlive => true;     <------- add this bruv
@override
Widget build(BuildContext context) {
super.build(context);    <---- add this too!
return Container()
}
hopefully that works.

for the widget you are trying to display in the list view just wrap the state with a keepalive.
for example
class _Post extends State with AutomaticKeepAliveClientMixin{
and dont forget to implement the keep alive above the build like so and add the super.build in widget.
get wantKeepAlive => true; <------- add this bruv
@override
Widget build(BuildContext context) {
super.build(context); <---- add this too!
return Container()
}
hopefully that works.

This worked for me, but since I am now keeping alive images and videos, will there be an impact on memory?

it mostly does, in this case you would just paginate the data and load images/videos in bundles of groups. for example load 10 images then when the user scrolls past the bottom, load another 10 from the list.

Actually that doesn't solve the problem
When I add an item in a portion of the custom listview that is not visible in the viewport the listview brakes

there is a pr open waiting for review https://github.com/flutter/flutter/pull/42703 which should fix this issue

I tried to rebuild my app using your branch and it actually fixes the problem :)
Looking forward to seeing it merged

Original pr causes an internal test failure

On which Flutter SDK version is this fix available?

It should be in latest stable 1.17.2

Thanks!

@chunhtai  I am on Flutter 1.17.2 • channel stable and dart Dart 2.8.3 and still when I remove the top item from the list all the items below it are disposed and the state is lost.
#21023


Listening for provider reject

Hi,
any way to handle the case where no provider was able to handle a rpc request (server side) in order to dispatch some logs / alerts ?
Thanks

The easiest way I can think of currently is if your logger catches the NO_RPC_PROVIDER log and does something, we already log it currently. Does that make sense?

Yep all right,
I'm working on a wrapper library for deepstream applications (kind of framework) and I would like to implement a functionality that check current system charge (in term of CPU usage and RAM) and answer by reject or accept depending of the system load. Kind of custom load-balancer.
The thing is : if all my nodes are overloaded, client wont receive responses in that case I wanted to dispatch some alert to the sysadmin :)
I'll go that way then, should be a very very rare case.
Thanks again,
best regards

Thanks @ScreamZ, let us know how you get on.

@AlexBHarley @yasserf,
made a first release, if you wants to check it out.
Won't say it's production ready while I've not finished implementing unit tests, but you can try to poke with it.
Best regards


Change autoconfig property validate pattern

Codecov Report

Merging #244 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
- Coverage     55.53%   55.06%   -0.47%
+ Complexity      265      260       -5
============================================
  Files            86       86
  Lines          1156     1144      -12
  Branches         62       62
============================================
- Hits            642      630      -12
  Misses          480      480
  Partials         34       34

Impacted Files
Coverage Δ
Complexity Δ

...g/cloud/autoconfigure/context/AzureProperties.java
100% <ø> (ø)
5 <0> (-1)
:arrow_down:

...loud/autoconfigure/cache/AzureRedisProperties.java
100% <100%> (ø)
3 <1> (-1)
:arrow_down:

...utoconfigure/eventhub/AzureEventHubProperties.java
100% <100%> (ø)
4 <1> (-1)
:arrow_down:

.../autoconfigure/storage/AzureStorageProperties.java
100% <100%> (ø)
3 <1> (-1)
:arrow_down:

...onfigure/servicebus/AzureServiceBusProperties.java
100% <100%> (ø)
3 <1> (-1)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55fed1...f46a2c5. Read the comment docs.


changes to Vector3 for ES6 modules

Noted while using Vector3 in Natural Selection, and working on https://github.com/phetsims/dot/issues/100.
In Vector3:
import dot from './dot.js';
import './Utils.js';
import './Vector3.js';
...
  slerp: function( start, end, ratio ) {
    // NOTE: we can't create a require() loop here
    return dot.Quaternion.slerp( new dot.Quaternion(), dot.Quaternion.getRotationQuaternion( start, end ), ratio ).timesVector3( start );
  },

Now that's we're using ES6 modules:

Can the odd imports be changed/removed?
Can the "NOTE" comment be removed/revised?
Can dot.Quaternion be replaced with an import?

Looks like there are other uses of the dot import that should be reviewed:
166 return Math.acos( dot.clamp( this.normalized().dot( v.normalized() ), -1, 1 ) );
492 return new dot.Vector2( this.x, this.y );
502 return new dot.Vector4( this.x, this.y, this.z, 1 );
781 return this.setXYZ( dot.Utils.roundSymmetric( this.x ),
782      dot.Utils.roundSymmetric( this.y ),
783      dot.Utils.roundSymmetric( this.z ) );

All the imports seemed used to me, I removed the NOTE that is now covered by the explanation of the ts-expect-error. Also there is still a need for the Quaternion workaround as far as I could see. Anything else @jonathanolson?

The workaround isn't needed, it would just mean we'd have to use dot/js/imports.ts. So far it seems fine to leave it as-is, but maybe sometime we'll rip off that band-aid?
Cleaned up a few other things above. Look good @zepumph ?

Yes, looks nice, I also made https://github.com/phetsims/dot/issues/118 for when the time is right. Ready to close?

Looks good to close, since we have the separate issue for circularity. Thanks!


feat(app): allow app update pop-up notifications to be disabled

overview
This PR adds the ability for a user to disable app update pop-up notifications either via the pop-up or via a toggle in More > App > App Software Settings.
Closes #6684
~This is a draft PR blocked by #6708. Will require rebase.~
changelog

feat(app): allow app update pop-up notifications to be disabled

review requests
The acceptance criteria are in #6684, so take a look at that. As usual, manually editing version in app-shell/package.json to a previous version is the best way to test this with make -C app-shell dev

[x] App notification pops up if app is "outdated"
[x] Clicking on "Turn off update notifications" shows you a warning
[x] Clicking "View App Software Settings" takes you to the App settings page
[x] If you close and re-open the app, the notification does not pop up
[x] If you navigate to the App settings and toggle the setting back on, the notification pops up the next time you open the app

Note: The notification will also pop up as soon as you toggle it back on the first time you make the switch

[ ] If you open the app release notes outside of the notification, there's no "Turn off..." link

Click "View Available Update" in More > App
Click "Downgrade" (or whatever it says based on your fake dev version) on a Robot settings page and click "View App Update" on the warning modal that tells you to update your app before doing any robot updates

risk assessment
Medium risk. Mitigating factors:

We can / should smoke test actual app updates before merging / releasing
This PR doesn't mess with the actual plumbing of app updates at all, just the UI that hooks into it
Unit tests in this and previous PRs ensure the plumbing is still hooked into properly
I think this PR has very high test coverage, including of the UI and the user flows through the UI

Most, if not all of it was TDD'd

Reviewed with product and UX and requested changes have been made:
– Widen UpdateAppModal to match other alert modals and give the buttons more breathing room

Switch heading of notifications toggle section to Title Case
Update copy and links in downgrade app section

This PR is good to review for final approval

Finished smoke testing with a "production" app and checked off the boxes in the test plan accordingly. Found one issue where "Turn off app update notifications" was showing up in the modal when it shouldn't have, and added a unit test + fix to the PR accordingly


matplotlib showing inaccurate psf in checkpsf stage with --no_iraf flag

Hi, I was working with assan14il data and while I was generating the PSFs for some particular epochs, I came across this issue.
Basically what is happening is the -s checkpsf and -s checkpsf --no_iraf commands are showing completely different images.
When I run -
supernova@a4bd83f4f33f:~$ lscloop.py -n asassn14il -e 20151026 -d 121 -s checkpsf

I get -

But when I run -
supernova@a4bd83f4f33f:~$ lscloop.py -n asassn14il -e 20151026 -d 121 -s checkpsf --no_iraf

I get -

which is something completely different and not even an psf.
The image itself looks pretty normal -

This issue also happens with -d 122, 123, 124, 130 from the same -e 20151026. And with one or two images from other epochs as well, which I haven't written down.

Thanks for noticing this and for opening an issue! Issue (mostly) fixed in PR #96.
The PSF in the iraf display is definitely the “right” PSF – the image looks normal but if you zoom in you can clearly see the sources are donuts (image attached).

PSFs are saved in iraf as a combination of an analytical function (an elliptical Gaussian) and residuals. Since this PSF is very non-Gaussian, the residual component dominates. I had been combining the two components with the wrong normalization.
I looked around the iraf code for the right normalization and couldn’t actually find where it is defined. After testing a few things I got something that is close to right, but not exactly right, as you can see in the following image. This is the closest I could get, so I used that and added a printed warning for very non-Gaussian PSFs that –no-iraf might be displaying them incorrectly.

I've noticed cases where iraf shows a very good psf model but matplotlib shows a barely usable one. I think the core issue is the same as you pointed out, this image is just an extreme example of it.
Btw, I made the same commits as PR #96 to my local ..../lcogtsnpipe/trunk/src/lsc/myloopdef.py file and restarted the docker container to see the changes but I'm getting the same result. Do I have to do anything else with docker in order to implement the changes?

Okay, I had to build docker again as well.
I just wanted to add that this commit also fixes the other discrepancies between matplotlib and iraf display as well. For example in the following image now matplotlib more faithfully represents what iraf shows.
Iraf display -

old matplotlib image -

new matplolib image -


Adding some config settings

Adding two configuration settings for the extension:

flutterColor.hexFormat - one of upper case or lower case - (default upper case) Returned hex values will be cased according to this value.
flutterColor.includeAlpha - boolean - (default true) If false, then a six-digit color will be returned.

Hi @djpadz,
Can you let me know the use case of this config settings

Hi @djpadz, Can you let me know the use case of this config settings

Sure...  I'm working on a project in Python, where, just as a matter of coding standards, we express hex colors in lower case.  Also, we're not using the alpha value, so I figured I'd tweak the extension to make those configurable.

Hi, @neodisk17 I'll get on that, but it may not be this week.  Keep the PR open, and I'll submit as I get time.

Hi @djpadz,
I can review and merge the changes if you'd like, and also create an issue for the test cases. This way, we can release the functionality you need sooner. However, I'll need some screenshots showing the functionality in action.

@neodisk17 thanks for the offer, but I just need to carve out some time to get both done.  That way it's clean.


Invert match with an empty line as pattern hangs or is slow

ag '^$'    # works!
ag -v '^$' # hangs!

experienced the same result with ag compiled from this repo and ag version 0.29.1 from homebrew.

This problem still persists as of ag version 2.2.0. I came across this on Arch Linux today, all packages upgraded to the latest build available. The classic GNU grep, and ripgrep handle this pattern with --invert-match just fine.


Add label filtering (-l) for get namespaces

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #2913
Does this PR introduce a user-facing change?:

Add label filtering (-l) for get namespaces

➜  gwctl get namespaces -l kubernetes.io/metadata.name=monitoring
NAME        STATUS  AGE
monitoring  Active  29d

➜ gwctl get ns -l kubernetes.io/metadata.name=envoy-gateway-system
Unrecognized RESOURCE_TYPE

The command gwctl get namespaces is currently supported by gwctl, yet the shorthand gwctl get ns is not available,  Should I add ns as a shorthand to facilitate its use by users?

➜ gwctl get ns -l kubernetes.io/metadata.name=envoy-gateway-system
Unrecognized RESOURCE_TYPE

The command gwctl get namespaces is currently supported by gwctl, yet the shorthand gwctl get ns is not available, should we add ns as a shorthand to facilitate its use by users?

Yes definitely, lets do it in the same PR.

@gauravkghildiyal done, I'd like to continue working on Add label filtering (-l) for describe commands

/label tide/merge-method-squash

Thanks @yeedove
/ok-to-test
/lgtm
/approve


Adds custom profile to Drupal Installers.

Provides the ability to specify custom profile types for Drupal.

Jumped the gun on this before looking at existing PRs. I'll throw my efforts behind #294


New version: Microsoft.AzureDataStudio version 1.48.1

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Please DO NOT Merge this. This was autogenerated outside of our team and uses a link that will be decommissioned at the end of this month for the downloads. I will submit the correct version.

Please DO NOT Merge this. This was autogenerated outside of our team and uses a link that will be decommissioned at the end of this month for the downloads. If the Urls are not corrected by tomorrow I will go ahead and submit the correct version.

Can you please advise the best place I can get this links for future versions? I need to update my automation.

We (the ADS team) have always submitted updates to winget ourselves the day of release (I was in the process of doing so when the automation told me that there was already a Pull request out for it)


Publish latest version on crates.io

I have some code (https://github.com/slack-rs/slack-rs-api/pull/47)  that works with reqwest HEAD but not with reqwest 0.7.3. Would it be possible for you to publish current HEAD?

Just published master as v0.8.0!

Thanks!


Train_side meaning

Hello,
Thank you for sharing your work!
What does  'train_side' means? Does each image in a batch have different train_side?
And is it used in both Stage1 and Stage2 ?
Thank you

Hi sungheuiK,
Thanks for your attention.
'train_side' in our experiment always means the image on the left side of a stereo image pair. We use the 'train_side' instead of ' 'left_side' for compatibility with other works under this framework, where the 'train_side' could mean the image on the right side due to the flip data augmentation.
This setting is indeed used in both Stage1 and 2.

Okay, I  got that train_side is the left image. Then what does 's' and 'o' imply?

In fact, they mean 'Side'(left) and 'Other Side'(right) respectively : )


Upgrade Modernizer Maven Plugin 2.4.0 -> 3.0.0

This PR contains the following updates:

Package
Type
Update
Change

Modernizer Maven Plugin
build
major
2.4.0 -> 3.0.0

Release Notes

gaul/modernizer-maven-plugin (Modernizer Maven Plugin)
v3.0.0: Modernizer Maven Plugin 3.0.0

Add File violations, #301
Add violation for ByteStreams.toByteArray
Add violation for StringReader, #291
Add violations for Maps and Sets with expected size, #258
Rework pom.xml structure, #263, #264
Upgrade to asm 9.7.1 for Java 24 compatibility, #286

Thanks @cstamas and @mkarg for sending pull requests to improve Modernizer!
v2.9.0: Modernizer Maven Plugin 2.9.0

Upgrade to ASM 9.7
Revert unneeded Maven core dependency from 3.9.5 to 3.2.5, #241

Thanks @cstamas for sending pull requests to improve Modernizer!
v2.8.0: Modernizer Maven Plugin 2.8.0

Add m2e hint, #213
Add support for different output formats and add codeclimate as an output format, #235
Upgrade to ASM 9.6, #222

Thanks @hazendaz and @themadprofessor for sending pull requests to improve Modernizer!
v2.7.0: Modernizer Maven Plugin 2.7.0

Add Enumeration and Stack violations, #183, #185
Upgrade to ASM 9.5 for Java 21 compatibility, #198

Thanks @delanym for sending pull requests to improve Modernizer!
v2.6.0: Modernizer Maven Plugin 2.6.0

Add violations for Java 17, 18, and 19 #115
Recommend Optional::orElseThrow instead of get #147
Remove usage of plexus StringUtils for compatibility with newer Maven #170
Upgrade to ASM 9.4 for Java 20 compatibility #154

Thanks @Harmelodic, @krzyk, and @mattnelson for sending pull requests to improve Modernizer!
v2.5.0: Modernizer Maven Plugin 2.5.0

Maven pom.xml fixes
Upgrade to ASM 9.3 for Java 19 compatibility

Thanks @cstamas, @mnoteberg-non, and @sullis for sending pull requests to improve Modernizer!

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Modernizer Maven Plugin 2.4.0 -> 3.0.0

See:
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.5.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.6.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.7.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.8.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.9.0
- https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-3.0.0
- https://github.com/gaul/modernizer-maven-plugin/compare/modernizer-maven-plugin-2.4.0...modernizer-maven-plugin-3.0.0


Enable and fix 3 lints

A lot of the bad strings are modified or deleted... are we concerned about that?

I think we're over testing these – I just did a copy-paste from the "bad string" index. We've had no issues here. I don't expect any.
...the HTML cases, for instance, aren't even a concern.

Travis is failing due to https://github.com/dart-lang/sdk/issues/40744

I wanted to enable the lint without having to wire through all of the crazy
ignores – at least that was my thought
On Mon, Feb 24, 2020 at 12:41 PM Jacob MacDonald<EMAIL_ADDRESS>wrote:

@jakemac53 approved this pull request.
Fair enough - it does seem like we shouldn't be limiting these to 80 chars
(I assume the main reason they were deleted?). But maybe that is harder to
do than its worth (ignoring these files)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/json_serializable/pull/615?email_source=notifications&email_token=AAAEFCULU5AXJGAWOXMNRK3REQWITA5CNFSM4KZVPBP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWWWQXI#pullrequestreview-363685981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEFCVYS3BKP32ISA7TRVDREQWITANCNFSM4KZVPBPQ
.

@jakemac53 – honestly, I'll just get rid of the 80-char line lint. Too much noise


Multi-select: wrapping names in selection list should be indented from checkboxes

Current behavior

Long names in the checkbox list wrap under their associated checkboxes.

Expected behavior

Long names wrap, but don't go under the checkboxes.

Steps to replicate behavior

Check the multi-select on /blog/ and scroll down till you find a long name.

Screenshots
Current

Expected

This was fixed in #3801


REPL not working on xarray.dev

What happened?
The "try it" REPL did not property load at https://xarray.dev/#repl
There was a problem with import matplotlib
What did you expect to happen?
The automatically populated first block of the pyolite REPL would load and run without errors
Minimal Complete Verifiable Example
Open https://xarray.dev/#repl and watch errors.

MVCE confirmation

[x] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[x] Complete example — the example is self-contained, including all data and the text of any traceback.
[x] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
"""

The next two commands are only needed on this webpage

Please do not try to run them outside of this webpage, otherwise you will get an error

"""

import micropip

await micropip.install(['xarray'])

# Import packages

import xarray as xr

import numpy as np

import pandas as pd

%matplotlib inline

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 12
     10 import numpy as np
     11 import pandas as pd
---> 12 get_ipython().run_line_magic('matplotlib', 'inline')

File /lib/python3.10/site-packages/IPython/core/interactiveshell.py:2369, in InteractiveShell.run_line_magic(self, magic_name, line, _stack_depth)
   2367     kwargs['local_ns'] = self.get_local_scope(stack_depth)
   2368 with self.builtin_trap:
-> 2369     result = fn(*args, **kwargs)
   2370 return result

File /lib/python3.10/site-packages/IPython/core/magics/pylab.py:99, in PylabMagics.matplotlib(self, line)
     97     print("Available matplotlib backends: %s" % backends_list)
     98 else:
---> 99     gui, backend = self.shell.enable_matplotlib(args.gui.lower() if isinstance(args.gui, str) else args.gui)
    100     self._show_matplotlib_backend(args.gui, backend)

File /lib/python3.10/site-packages/IPython/core/interactiveshell.py:3522, in InteractiveShell.enable_matplotlib(self, gui)
   3501 def enable_matplotlib(self, gui=None):
   3502     """Enable interactive matplotlib and inline figure support.
   3503
   3504     This takes the following steps:
   (...)
   3520         display figures inline.
   3521     """
-> 3522     from matplotlib_inline.backend_inline import configure_inline_support
   3524     from IPython.core import pylabtools as pt
   3525     gui, backend = pt.find_gui_and_backend(gui, self.pylab_gui_select)

File /lib/python3.10/site-packages/matplotlib_inline/__init__.py:1
----> 1 from . import backend_inline, config  # noqa
      2 __version__ = "0.1.6"  # noqa

File /lib/python3.10/site-packages/matplotlib_inline/backend_inline.py:6
      1 """A matplotlib backend for publishing figures via display_data"""
      3 # Copyright (c) IPython Development Team.
      4 # Distributed under the terms of the BSD 3-Clause License.
----> 6 import matplotlib
      7 from matplotlib import colors
      8 from matplotlib.backends import backend_agg

ModuleNotFoundError: The module 'matplotlib' is included in the Pyodide distribution, but it is not installed.
You can install it by calling:
  await micropip.install("matplotlib") in Python, or
  await pyodide.loadPackage("matplotlib") in JavaScript
See https://pyodide.org/en/stable/usage/loading-packages.html for more details.

Anything else we need to know?
If 'matplotlib' is added to the list of libraries to be installed with micropip, it works fine:
"""
The next two commands are only needed on this webpage
Please do not try to run them outside of this webpage, otherwise you will get an error
"""
import micropip
await micropip.install(['xarray', 'matplotlib'])

# Import packages
import xarray as xr
import numpy as np
import pandas as pd
%matplotlib inline

xr

<module 'xarray' from '/lib/python3.10/site-packages/xarray/__init__.py'>

Environment

INSTALLED VERSIONS
------------------
commit: None
python: 3.10.2 (main, Jan  3 2023, 11:46:47) [Clang 16.0.0 (https://github.com/llvm/llvm-project dee009d3b5c71a340eb4ebb3cfb4
python-bits: 32
OS: Emscripten
OS-release: 3.1.27
machine: wasm32
processor:
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: None
libnetcdf: None
xarray: 2022.12.0
pandas: 1.5.2
numpy: 1.23.5
scipy: None
netCDF4: None
pydap: None
h5netcdf: None
h5py: None
Nio: None
zarr: None
cftime: None
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
dask: None
distributed: None
matplotlib: 3.5.2
cartopy: None
seaborn: None
numbagg: None
fsspec: None
cupy: None
pint: None
sparse: None
flox: None
numpy_groupies: None
setuptools: 65.6.3
pip: None
conda: None
pytest: None
mypy: None
IPython: 8.8.0
sphinx: None

Thanks for the report @bmaranville - we can get this fixed asap.


pythonPackages.databricks-connect: 7.1.0 -> 7.1.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

not sure why config = { checkMeta = true; }; felt these were marked broken

but these do build


No players are returned in when fetching plays

I think this might be since the last release, but now there is no player information returned when fetching plays.
This can be tested even with the demo username on the readme mattiabanned

@LearningProcesss just checking in on this one as I feel it is a pretty major issue and must be a regression? Also let me know if/how I can help. We are quite invested in getting this working and I have been a big fan of your library to date

Ciao @ericpoulinnz,
are you using 1.9.0?

Yes I updated to get comments for play logs from your last fix (which works well ☺)

@LearningProcesss hmm, players are definitely not being retrieved for me using the latest.
in package.json :
"boardgamegeekclient": "^1.9.0",

Called here (comments show inputs):
export const getBggPlayPage = async (username: string, page: number) => {
  const params: IPlaysRequest = {
    username, // "mattiabanned"
    page, // 1
  };
  const raw = await bggClient.play.query(params);
  console.log(raw);
  console.log("stringify", JSON.stringify(raw));
};

Output:
LOG  [{"page": 1, "plays": [[BggPlaysPlayDto]], "total": 1, "userid": 1236367, "username": "mattiabanned"}]
LOG  stringify [{"userid":1236367,"total":1,"page":1,"username":"mattiabanned","plays":[{"item":{"subtypes":[{"value":"boardgame"},{"value":"boardgameimplementation"},{"value":"boardgameintegration"}],"name":"Mistfall","objecttype":"thing","objectid":168274},"comments":"this is the first comment line\nthis is the second comment line","players":{},"id":57445284,"date":"2017-12-03","quantity":1,"length":180,"incomplete":0,"nowinstats":0,"location":"Italy"}]}]

Response calling BGG's API directly has a player in the play log:

Hej @ericpoulinnz thanks for pointing out this problem, 1.9.1 fix it.

Thank you @LearningProcesss , working well!


Rename timeout?

I think the term "timeout" can be confusing. In Ruby, "timeout" most often means Timeout.timeout. In Stoplight, timeouts don't have anything to do with limiting execution time. Instead they have to do with attempting to recover from a red light.
I don't have any better names for the concept though.

Possible name cool_off_time

Fixed by #96.


Timed release holds

A new upcoming hold type. For this, it can be a golden yellow hold with dots on it.
Kinda like this: https://camo.githubusercontent.com/a6e5b472c9715b92e9d74e9f503b8ebe4c228b09/687474703a2f2f7075752e73682f6e6d51764e2f373931306136316138302e706e67

This hold, it will also be the preceding hold body for lifts.

Timed release hold, is a hold with a lift at the end. I think the arrow on the bottom can be transparent

Like IIDX's Charge Notes?

I think so...


Add extra error text in the property parser

With properties being specified in all kinds of places, including hard
coded in providers, it's not always easy to figure out exactly what
string was incorrect when the parser would just say something like
'parse failed' with no more details.
Adding extra data to the error, showing exactly what string is
incorrect, helps a bit.  At the very least, this gives anyone
interested something to grep for.

Nice improvement.

Merged.
4cdb302fef1f2160b74acbe1739f62c713fd99f5 Add extra error text in the property parser

Thanks for the review!


feat: Update App Layout and Add Threat Model Report for full Mode

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"require_mail_server" set to TRUE disabled mail server by local binding

SUMMARY
If variable require_mail_server is set to true one may expect that mail server function is preserved. Instead, if set to true, postfix binds only on localhost, which disables the mail server function for hosts in the network.
ISSUE TYPE

Bug Report

ANSIBLE VERSION
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/dist-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.8.10 (default, Nov 26 2021, 20:14:08) [GCC 9.3.0]
  jinja version = 2.10.1
  libyaml = True

CONFIGURATION
n/a
OS / ENVIRONMENT
Ansible control node:
Description:    Ubuntu 20.04.3 LTS
Release:        20.04
Codename:       focal
Ansible managed node, with postfix installed
Description:    Ubuntu 21.10
Release:        21.10
Codename:       impish
STEPS TO REPRODUCE

install ubuntu
install postfix
configure postfix to accept mails from other hosts (=mailserver function)
run playbook with variable require_mail_server = true
postfix stops working in the network

EXPECTED RESULTS
by setting variable to true, I expect the binding of postfix service to keep on <IP_ADDRESS> instead of localhost.
ACTUAL RESULTS
bind to localhost only according to lineincfg module. --> Ansibile is doing fine. Variable setting is confusing though.
Suggestion
binding to localhost should be done if variable set to false.
require_mail_server= TRUE --> keep binding at <IP_ADDRESS> (or whatever set in config)
require_mail_server= FALSE --> bind to localhost only

@gitbock  - Ah I see. Actually task 2.1.15 | Ensure mail transfer agent is configured for local-only mode (Automated) sets it to only localhost based on the CIS Benchmark for Ubuntu 20.04 (v1.1.0), which is likely causing that issue.
https://github.com/darkwizard242/cis_ubuntu_2004/blob/54e4ffb3f8b90c68b4a05638c1d8470e758dbcbd/tasks/section_02.yml#L337-L356
If require_mail_server is set to false, it shouldn't touch any of the postfix configuration (i.e. /etc/postfix/main.cf). Do you mind setting it to false and confirming on your side for me. The action for if set to true or false was upon my initial thoughts, but I understand now that it actually had an opposite affect. If you test with false and it doesn't bind postfix only to localhost and/or impact anything esle on your side. I can probably have the when condition logic changed for the task to only run when require_mail_server is set to false instead of true and have it eventually released with your PR.

Hi @darkwizard242
Thanks for investigating!
I overruled the variable in my playbook
ubuntu_2004_cis_require_mail_server: false
# false = postfix will bind on <IP_ADDRESS> -> mail server stays reachable

and executed it.
It did not touch my postfix config. The config line is still commented and was not added (means activated by ansible)

#inet_interfaces = localhost
inet_protocols = ipv4
mynetworks = <IP_ADDRESS>/8 [...]

Yes, what do you think about inverting the logic by
when:
 - not ubuntu_2004_cis_require_mail_server

and modifying the description about the variable. Like this, it should be fine :)

@gitbock - Great, thanks for verifying that 👍🏼
Yes, agreed that inverting the when condition in the task to have the following makes more sense:
when:
 - not ubuntu_2004_cis_require_mail_server

I will merge your PR #13 , add the above discussed changes and release a new version for GitHub + Ansible Galaxy.

re: ipv6 - The reason I had it disabled by default was primarily due to CIS Benchmark for Ubuntu Linux 20.04 LTS itself. Since the default recommendation in the benchmark is to have it disabled, I didn't wanted to deviate from that for the sake of anyone that uses the role and prefers the role to be as relatively close to the actual benchmark as possible.
Honestly speaking, I too am in the same boat as you and have to override ipv6 configuration (to keep it enabled, contrary to the benchmark recommendation) in multiple projects where we utilize this role to build out CIS benchmark based AWS AMI's.

@gitbock - Done, I merge your PR #13  and also changed the when condition as we discussed above for 2.1.15 in #15.
GitHub release version 3.0.0 has been released. 3.0.0 is now available on Ansible Galaxy.

Hi @darkwizard242
IPv6: understood. Already was thinking of this 😉
Thanks for considering my PR 👍

Great. Thanks very much for the PR and changes discussed in this issue. Appreciate both your time and help 👍🏼
p.s. (feel free to close the issue if it's good with you)


Sizemapping: what happens when no size is defined?

Add a note describing the edge cases that may occur when:

screen size can be detected, but no mapping is defined
screen size cannot be detected

@mkendall07 would appreciate your eyes on this change - it basically matches what you verified in Slack earlier, but it has been reworded slightly.  Hopefully it is a little clearer, but I want to make sure I didn't introduce a technical error/omission.


QNetworkReplyImplPrivate::error: Internal problem, this method must only be called once.

QNetworkReplyImplPrivate::error: Internal problem, this method must only be called once.

他会导致网站的js会加载不完整

The same issue still happens.

It would be great if one of you managed to provide a set of steps to reliably reproduce this issue. If you do, it would be much easier to fix the issue.

Splash version: 3.2
Qt 5.9.1, PyQt 5.9, WebKit 602.1, sip 4.19.3, Twisted 16.1.1, Lua 5.2
Python 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609]
I run splash with command docker run -p 8050:8050 scrapinghub/splash
After some count of requests execution I receive a lot of errors in splash log like:
loadFinished: RenderErrorInfo(type='Network', code=99, text='Proxy connection refused', url='https://...') I rotate proxy servers on each request using next lua script:
function set_proxy(splash)
    splash:on_request(function(request)
        request:set_proxy{
            host=splash.args.proxy_host,
            port=splash.args.proxy_port,
            username=splash.args.proxy_user,
            password=splash.args.proxy_pass,
        }
        request:set_header('Proxy-Authorization', splash.args.proxy_auth)
    end)
    return 1
end

I also rotate user-agent http header using next lua script:
function set_user_agent(splash)
    splash:on_request(function(request)
        request:set_header('User-Agent', splash.args.user_agent)
    end)
    return 1
end

I understand that it's OK because some of my proxies can expire. But I suppose that it could be related to the main error.
In ~15-20 minutes I start to receive 504 response. But some requests still work. In a pair of minutes I receive just 504 errors. I also tried to run the docker container with next command docker run -p 8050:8050 scrapinghub/splash --max-timeout 3600 regarding to the manual. But the issue still happens.
When 504 error happens in the log I can rarely see the topic error.


Add keyboard shortcuts for going forward/back in memento history

From<EMAIL_ADDRESS>on February 18, 2014 12:45:27
Something like Alt+Left for back and Alt+Right for forward ,which are keyboard shortcuts for the browser forward/back buttons.
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=196

Obsolete; this was for Cr2bug/Quickbug.


NgMock: Useful this value in module config

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
feature
What is the current behavior?
The this value of a config function passed to the module function is currently either window or undefined depending on your use strict state.
beforeEach(module('myApp', function($compileProvider) {
  // `window` or `undefined`
  console.log(this);
}));

What is the expected behavior?
Can we provide the this value from beforeEach so that this is the current spec in any config functions?
What is the motivation / use case for changing the behavior?
Ease of testability when using this to share content that should be spec specific

Sounds reasonable (assuming there aren't negative implications - I couldn't think of anything).
If someone wants to knock up a PR, please do.


feat: Added local_api_shared configuration option.

This new option, which is false by default in order to not interfere with existing working installations, allows to share the UDP socket with other processes running on the same machine as the homebridge-weatherflow-tempest plugin.
Closes #26.

I'll tee this up in a new patch release.


[beta] 4.0.0-rc1: react-leaflet v3 support

@yuzhva Looks like you beat me to the dependency bump! Thank you.
I will be building an additional example relating to Leaflet/Leaflet.markercluster#612 tomorrow. This is the use case I have.
Please let me know if you have any insights into this before I start it, in case there is an easier way to do it now.

@charlieforward9 - I did not work with a leaflet for last years, unfortunately, I don't have any insights there.
The only insight is about the publishing package:
When the code in src/react-leaflet-markercluster.js is written / accomplished, before committing it it's also required to run:
https://github.com/yuzhva/react-leaflet-markercluster/blob/main/package.json#L23C6-L23C18
npm run build:source

It will update /dist folder - it's important as "main" key of package.json points to /dist source.
After that, you can increase the package version in package.json, merge code, create and push tag to git repo and after that npm publish --tag=latest
That's pretty all (=


Add Perl 5 to druid requirements

Without perl 5 I was unable to start druid using the instructions in the quickstart guide. For my testing, perl5 got it working.

This is perl 5, version 36, subversion 0 (v5.36.0) built for x86_64-linux-thread-multi

Description
Missing requirement for running the startup script. Without Perl 5 apache druid would not start.
Just added in "Perl 5" to the quick start guide requirements under the list that includes python and java.

I believe perl 5 is the only usable version. Perl 4 was discontinued in 1994. Perl 6 is a pretty big departure and doesn't run perl 5 programs. Perl 5 and 6 are both being maintained in parallel by the perl community.

I was just curious in what druid was using perl for, I found out that is just in the examples/bin scripts.
All deps are already included perl5 core since the version from March 25, 1996, so I think that "any" perl (five) interpreter available on recent distros will do. Perl code tends to keep running fine for years.
Fun fact (or not so much fun for some people), after year-long discussions, perl 6 was renamed to raku and usually it's easier to find it using rakulang.
Perl 5 version 34 was supposed to called Perl 7 (based on version 32, with some new default options) but that delayed and they gave up again. I because it's still too backward compatible with perl5 :laughing:, so perl 7 and 8 and 9 will not exist for a while


How to bring up PetClinic microservices along with UI

Hi,
I am new to the forum. I am using PetClinic application for showing testing capability in API and UI automation.
So I need to install the entire package (both MicroServices and UI). Need guidance for this installation.
~Sidhartha

Hi @sidharthasubudhi. This project provides both UI and REST API. The README.md explains how to build then launch the project.

Sure you may ask some questions there.

Thank you.

What are the supporting services (Config and Discovery Server) that must be started before any other application (Customers, Vets, Visits and API).
How to start ../mvnw spring-boot:run command. Please provide more details about this.
Is it possible to start UI in any port other than 8080? if so how to do that? (Because Jenkins is running in its default port 8080).
I was going though README.md but I need details about the above questions to start with.

You should start first the config server, second the discovery server, then all other microservices
To execute maven, you have to install the JDK 8
To change the port number, you have to edit the file https://github.com/spring-petclinic/spring-petclinic-microservices/blob/master/spring-petclinic-api-gateway/src/main/resources/application.yml and add follow this tuto: https://www.baeldung.com/spring-boot-change-port

I see the following packages are good to work with
spring-petclinic-admin-server
spring-petclinic-config-server
spring-petclinic-discovery-server
But other packages like
spring-petclinic-api-gateway, spring-petclinic-customers-service, spring-petclinic-vets-service, spring-petclinic-visits-service have some compliation errors.
I executed spring-petclinic-config-server  and then spring-petclinic-discovery-server packages as Maven Test.
Here I see server.port: 8888 in .yml files under resources folder.
The execution is successful but when I login http://localhost:8888, nothing runs here.
Also I didn't find anywhere port 8080 is defined.
I executed spring-petclinic-admin-server and spring-petclinic-api-gateway packages also.
All these 4 packages executed as maven test successfully. But when I open http://localhost:8888 , nothing opens.
Please let me know if I am doing anything wrong and how can I execute them successfully.

@sidharthasubudhi do you solve your issue?

Without feedback, I'm closing this issue. Please free to reopen it.


Fixed a memory leak and flaky test

The memory leak was caused by not properly cleaning up the RequestBodyPipe for Http2Streams. Removing the _ioCompleted check before consuming the message body seems to work well.
The flaky test didn't handle the fact that writing to the connection after a stream has been RSTed that it'll cause the entire connection to close.

#2799


Update to .NET Core 2.1.4 with SDK 2.1.402

PR Summary
Update to .NET Core 2.1.4 with SDK 2.1.402
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[x] Add [feature] if the change is significant or affects feature tests

@TravisEz13 You comment is addressed. Please take another look, thanks.


Create ar-EG locale

Description

Linked Issues

Additional Context

Thanks for your contribution.
Are the months and weeks same to English ? Just a question for me.

hi, hope  you well
thanks alot for this hard work
months and weeks are ok and common to be in english

Hi, you should merge #451 #452 #453 #454 into this PR instead of creating multiple PRs for one feature.

created new pull request with all changes


Issue on Zoom on Change State

I was looking at the Zoom function. I have Chart 1 Candlesticks (yExtents={[d => [d.high, d.low]]}) and Chart 2 RSI (yExtents={[0, 100]}). The events are the following:

The chart looks as normal, even with updating (every 500ms) data (the data looks good).
I then Zoom the Yscale scale.
It Zooms, but once I release the mouse (after state change), the Yscale goes to 0 to 100. On both Charts 1 and 2. One can still Zoom at this level (though wrong) but after state changes, the Yscale goes back to 0 to 100.
Reset, and the chart and it goes back to normal, but then reZoom and it happens again.

I get the feeling that the  "yExtents={[d => [d.high, d.low]]}" in my charts gets reset to "yExtents={[0, 100]})" on mouse release and after state change (on both Chart 1 and 2).
As a foot note (strange): If I make Chart 2 MACD (yExtents={macdCalculator.accessor()}). Chart 1 is OK when Zooming, though if I Zoom the MACD Chart 2, then Chart 1 gets the Yscale of the MACD, Chart 2.
Is this mycode or something related to the issue in the ref link?
Note: I did refresh a new install from NPM.
Ref link: https://github.com/rrag/react-stockcharts/issues/385

is this problem visible in the examples also or is this happening only in your code?
Also could you record a video and share please

Yes, i see the problem, thank you for reporting, I am looking at it now

Fixed in 0.7.0-beta.21 Thank you for reporting

Hello rrag, I confirm to you this has been fixed. Thanks, nice work! One very minor picky thing on some of the added props. When using fontSize of 11 the text in the arrow is poorly skewed depending if it is right or left. The following was a ugly hack to fix it.
   `
           // BPT KLUGE { key: 2, x: edge.coordinate.edgeXText + 8, for right none for left

            var kluge = edge.orient === "right" ? edge.coordinate.edgeXText + 8 : edge.coordinate.edgeXText;

	coordinate = _react2.default.createElement(
		"text",
		{ key: 2, x: kluge,
			y: edge.coordinate.edgeYText,
			textAnchor: edge.coordinate.textAnchor,
			fontFamily: edge.coordinate.fontFamily,
			fontSize: edge.coordinate.fontSize,
			dy: ".32em", fill: edge.coordinate.textFill },
		edge.coordinate.displayCoordinate
	);

`


Swipe Navigation

Would love it if you could bring back swiping between tabs again

Please, read the pinned issue:
https://github.com/maykar/custom-header/issues/17


Add twinkling stars animation

Describe the project you want to add with tech stack

I would like to twinkling stars animation using HTML, CSS.

@MohitGupta121 @TusharKesarwani  please assign me this issue under gssoc'23


Ubuntu 18/Debian 9 wallet

Debian 9 report
#error while loading shared libraries: libssl.so.1.0.0: cannot open shared object file: No such file or directory#
will there be a wallet for Ubuntu 18/Debian 9 ?

exit scam but you just needed to install proper dependencies


go example CI failure

This could be due to https://github.com/roc-lang/roc/commit/3215a8f3d73daf881185e4f7474972f2059754b6 but I need to take a proper look on Friday to make sure.
++ lsb_release -a
+ os_info='Distributor ID:	Ubuntu
Description:	Ubuntu 24.04.1 LTS
Release:	24.04
Codename:	noble'
+ set -e
+ echo 'Distributor ID:	Ubuntu
Description:	Ubuntu 24.04.1 LTS
Release:	24.04
Codename:	noble'
+ grep -q 'Ubuntu 20.04'
+ expect ci_scripts/expect_scripts/GoPlatform.exp
spawn ./examples/GoPlatform/main

Error: output was different from expected value.
Error: Process completed with exit code 1.

This is just #164, we had a grep to skip the go test on Ubuntu 20.04, but this did not apply for the newly added Ubuntu 24.
04.


Support for Slack app tokens

Slack app webhooks only allow you to post to a single channel. The incoming webhooks app let's you send to any channel, but it's considered legacy. Using tokens with a Slack app would let you post to multiple channels with the same token. There are a couple of different Github slack notifying apps that support this

I don't know if support has been officially released but I just made a sample repo to check and it seems to be working (except SLACK_ICON and SLACK_ICON_EMOJI that doesn't work apparently)

@titimoby  Could you tell me how did you do that?? I mean in which parameter did you use to put that token??


Fix mission with LAND_START and RTL item

This prevents a corner case when a VTOL user has set a LAND_START item as well as checked the box to end the mission with RTL.
What happens on RTL is that navigator would switch to mission mode on RTL and start with land_start, and then continue to the RTL item. At this point, navigator would send the vehicle_command for RTL to commander which would deny it because it is already in RTL mode. Thus navigator won't (re)set any items to actually do RTL and it means the vehicle will just head to whatever setpoint it received last.
This PR fixes this corner case by:

Enabling the fixedwing mission feasibility checks for VTOLs but without requiring a landing sequence.
Checking for LAND_START and a RTL item in a mission using the fixedwing mission feasibility checker.

Tested in SITL.
Discovered by @sfuhrer.

Thanks for looking into this @julianoes . I agree that a mission feasibility check makes sense here, as there is really no point in planning a mission with a land start marker and then a RTL waypoint.
While testing it I though run into issues with the Fixed wing feasibility checker, as it now checks the mission for an appropriate FW landing approach (which ofc doesn't need to be there for a VTOL). We thus should exclude this check for VTOL.

@sfuhrer but I thought I disabled that it requires a landing point here:
https://github.com/PX4/Firmware/pull/13734/files#diff-3f698c24ebab3cb3866d13e69f8e5459R87
What mission are you uploading to cause this?

@sfuhrer but I thought I disabled that it requires a landing point here:
https://github.com/PX4/Firmware/pull/13734/files#diff-3f698c24ebab3cb3866d13e69f8e5459R87
What mission are you uploading to cause this?

You just disabled the check for "having a land start marker", but if missions contain one then all the FW landing checks still run.
I've added another commit with the VTOL landing checks in a separate function.
Pros: only running the checks really required for VTOL, plus enabling us to add additional VTOL specific checks in the future (eg requiring a loiter to altitude before back transition (see eg https://github.com/PX4/Firmware/issues/12413)
Cons: adds some duplicated code
What do you think @julianoes ?

Makes sense, thanks @sfuhrer!

Was this closed intentionally?

No, that was a weird Github interaction.


When pressing a backspace in the 1. Line the app crashes

Or just randomly

Uploading Screen_Recording_20230314-214244_Noto.mp4…

The screen recording isn't there, could you please upload it again? Thanks.

Having the same issue ever since the new update. I am on Android 13 on a Pixel 6a. Never had the issue prior to the update. Here is a screen recording:
https://user-images.githubusercontent.com/26486074/225200598-c1e43772-7383-431b-ace5-e8dbc4bdb5be.mp4

The screen recording isn't there, could you please upload it again? Thanks.

Yes ofc
https://user-images.githubusercontent.com/96864185/225234155-5093557e-ab69-470c-88e5-7afd49e8e303.mp4

https://user-images.githubusercontent.com/96864185/225234834-43b5b78a-4cd1-47b0-b3fb-c3c09596b46b.mp4

This is related to #170. I'm working on a fix.

I just pushed an update with a potential fix for this problem. It's gonna take few hours before it's released on Play Store. However, if you have downloaded your app through GitHub/F-Droid, please update the app with the new APK from here.


Consider exposing cgltf_load_buffer_base64

For Filament's WebGL build we were able to use cgltf as-is with this one exception.
We easily wrote our own alternative to cgltf_load_buffers (since the filesystem does not exist), but we didn't want to write our own base64 decoder, so we had to publicize the one in our local copy of cgltf.

That totally makes sense. Should be fixed by a6b807790cc7a92cbbc3c106530e97c8d14656e5.

Thanks so much!


Center align keybindings in quick open

Part of #28602

So I had a look and i know what's going on and why it's difficult to center this. It's hard because the .monaco-kbkey style uses line-height to size the background of the button. A negative margin-top is used to work around this since the size is fixed to 22px from what I can tell.

There is one remaining issue however, this PR fixes the alignment of all items except for those containing a separator which is 1px off:

The reason this is off is because the size of .results-group-separator is 23px but its parent .monaco-tree-row is set to 22px, meaning the last pixel is being hidden via overflow:hidden.

The right fix here is to move the .results-group-separator class up one level to the .monaco-tree-row level and adjust it's height to 23px. Setting it manually in devtools to 23px seems to work just right:

@bpasero @joaomoreno I don't feel like I know the code well enough to make this last change, will probably take no time at all for one of you though 😄

I am never a big fan of using negative margins to accomplish centering. I think @joaomoreno was also digging into the alignment and maybe has an alternative solution?
Btw I see no difference between align-items: center and align-items: stretch on macOS at least.

My initial approach was align-items: stretch such that .monaco-kbkey gets sized to 100% height  of its container, then use line-height:22px on .htmlkb to center align it. The latter doesn't work though due to line-height driving the button height. So I believe you when you say if does nothing, feels cleaner to me to have it sized at 100% height though.
I'm not a fan of negative margins either but it's the only way I saw outside of using position: relative which could create an extra rendering layer. line-height is the regular way of center alignment outside of dodgy workarounds like display: table.

Going with https://github.com/Microsoft/vscode/pull/30182