Errors in CMakeLists.txt ...

Hi,
I just did a clean checkout of the repo and tried to build the 80 column version.
I found a couple of problems with CMakeLists.txt ... so, using cmake .. from .../80col-mono/Build, the SDK files would not be copied properly due to to this line being wrong:
if(EXISTS "${PICO_SDK_PATH}")
... as${PICO_SDK_PATH}refers to an internal CMake variable (which is not defined). Instead, it should use $ENV{} to access environment variables ... the following line works:
if(EXISTS "$ENV{PICO_SDK_PATH}")
Also, and most importantly, the line:
project(picoterm LANGUAGES CXX C ASM VERSION 2.5.3 )
Needs to be after the call to pico_sdk_init() - otherwise the sdk-related files will not build correctly. Also the SDK files will not copy as CMake shifts the working directory to .../80col-mono from .../80col-mono/Build.
Hope this is helpful!
Jason

Thanks for this!  I was wanting to rebuild it myself because, if I'm honest, I really do dislike Ubuntu Mono that much.  I also ran into the issues described, but unfortunately I don't know thing one about CMake.
I didn't have a problem with it copying the SDK files, but I didn't realize from your notes that the existing project(picoterm VERSION ...) line needs to be moved and have LANGUAGES CXX C ASM added to it rather than adding a second one with that after pico_sdk_init().  Before I realized that and fixed it, it was trying to use /usr/bin/cc as the C compiler, rather than the cross-compiler, and as you might imagine, an x86_64 assembler wasn't too keen on compiling the ARM assembly pulled in from the SDK code.

Also, this might be a bit of a derail, but for anyone else who might want to replace the font...  do use the LVGL converter mentioned in the comment at the top of font8.c, but don't save the output over top of the existing font8.c; just replace the glyph definitions, and change the .line_height and .base_line values in font8.c's lv_font_t to match the ones from the converter output.  Then run compile_font.py to update the NuPETSCII and CP437 fonts.  I replaced mine with the aspect-ratio-corrected OlivettiThin 8x16 font from int10h.org (which is period-appropriate, if not necessarily historically accurate), and it works:
Expand for photo

...although it had a different .line_height and .base_line from Ubuntu Mono, and as you can see, there is some junk appearing at the bottom of the screen now once it scrolls.  I haven't used it extensively with the new font yet, just booted it up to see if it displayed at all correctly, so I don't know if this is an indication of incipient memory corruption that's eventually going to crash Picoterm.

@myount
Would you like to open a new issue with your font message. I'm very interrested to dig further more into it.
Thanks

@spock64
I'm just a bit puzzle about usage of $ENV like if(EXISTS "$ENV{PICO_SDK_PATH}")
When I do it, it bricks the compilation on my Linux distro. However, the PICO_SDK_PATH is defined (see the code section at bottom).
dom:~/Bureau/RC2014/picoterm/80col-mono/Build$ cmake ..
domeu@dom-HP-ENVY:~/Bureau/RC2014/picoterm/80col-mono/Build$ cmake ..
System is unknown to cmake, create:
Platform/PICO to use this system, please post your config file on discourse.cmake.org so it can be added to cmake
Your CMakeCache.txt file was copied to CopyOfCMakeCache.txt. Please post that file on discourse.cmake.org.
PicoTerm 80Col version = 1.5.3
CMake Error at CMakeLists.txt:9 (message):
  Systen Environment variable PICO_SDK_PATH undefined!

-- Configuring incomplete, errors occurred!
See also "/home/domeu/Bureau/RC2014/picoterm/80col-mono/Build/CMakeFiles/CMakeOutput.log".
See also "/home/domeu/Bureau/RC2014/picoterm/80col-mono/Build/CMakeFiles/CMakeError.log".

However, the PICO_SDK_PATH is defined as stated by the export command here below
dom:~/Bureau/RC2014/picoterm/80col-mono/Build$ export | grep 'SDK'
declare -x PICO_SDK_PATH="../../pico-sdk/"

Do you have more information to share about it?
Cheers,
Dominique

Hi Dominique,
So how you declare the environment variable may vary somewhat, but I would expect
declare -x PICO_SDK_PATH="../../pico-sdk/" to be in your .bashrc (or similar)?
You could also have the environment in a shell script that calls cmake too - everyone has their own preferences.
Certainly when you do export | grep 'SDK' using your example above, your output should be:
PICO_SDK_PATH=../../pico-sdk/
Is there something wrong with how you are declaring the environment variable?
Best
Jason

Thanks for this! I was wanting to rebuild it myself because, if I'm honest, I really do dislike Ubuntu Mono that much. I also ran into the issues described, but unfortunately I don't know thing one about CMake.
I didn't have a problem with it copying the SDK files, but I didn't realize from your notes that the existing project(picoterm VERSION ...) line needs to be moved and have LANGUAGES CXX C ASM added to it rather than adding a second one with that after pico_sdk_init(). Before I realized that and fixed it, it was trying to use /usr/bin/cc as the C compiler, rather than the cross-compiler, and as you might imagine, an x86_64 assembler wasn't too keen on compiling the ARM assembly pulled in from the SDK code.
Also, this might be a bit of a derail, but for anyone else who might want to replace the font... do use the LVGL converter mentioned in the comment at the top of font8.c, but don't save the output over top of the existing font8.c; just replace the glyph definitions, and change the .line_height and .base_line values in font8.c's lv_font_t to match the ones from the converter output. Then run compile_font.py to update the NuPETSCII and CP437 fonts. I replaced mine with the aspect-ratio-corrected OlivettiThin 8x16 font from int10h.org (which is period-appropriate, if not necessarily historically accurate), and it works:
Expand for photo
...although it had a different .line_height and .base_line from Ubuntu Mono, and as you can see, there is some junk appearing at the bottom of the screen now once it scrolls. I haven't used it extensively with the new font yet, just booted it up to see if it displayed at all correctly, so I don't know if this is an indication of incipient memory corruption that's eventually going to crash Picoterm.

Cmake is a great build system - but really awkward to get right. The ordering of statements is important!
Glad you got it working - and thanks for the hint on terminal fonts ... I'm not a mono fan either!

Hi Dominique,
So how you declare the environment variable may vary somewhat, but I would expect declare -x PICO_SDK_PATH="../../pico-sdk/" to be in your .bashrc (or similar)? You could also have the environment in a shell script that calls cmake too - everyone has their own preferences.
Certainly when you do export | grep 'SDK' using your example above, your output should be: PICO_SDK_PATH=../../pico-sdk/
Is there something wrong with how you are declaring the environment variable?
Best Jason

I declare the environment variable as stated in the docs/compiling.md  . So I used the
export PICO_SDK_PATH=../../../../../pico/pico-sdk

I define it on need (it is not a permanent defines in bashrc, otherwise I would use an absolute path instead.
The PICO_SDK_PATH is indeed defined into my current terminal. IF I do open a new terminal and key-in export | grep 'SDK' THEN PICO_SDK_PATH is not defined.
Now I have a path to follow :-)

If not defined in.bashrc, it is possible to define an environment variable to execute a given command like the example here below.
The following command defines the environment variable PICO_SDK_PATH just before executing cmake ..
env PICO_SDK_PATH="../../../../../pico/pico-sdk" cmake ..

In such situation, the $ENV{PICO_SDK_PATH} can be read from the CMakeList.txt

Yes, that's the right sort of thing. You don't need the 'env' though ...
Just PICO_SDK_PATH="../../../../../pico/pico-sdk" cmake .. will work ... and this is what I use.
This syntax causes the environment variable PICO_SDK_PATH to be defined just for the command that follows. It's very handy and is what I've used since the, er, early 1980's !

I came very late to the Linux environment. Thanks for the TIP, it is something very useful to know.
I will post a newer version of CMakeList that checks the environment variable and use its value when defined.
I also recommended to use an absolute path for PICO_SDK_PATH, it is saver for file copy operations.

@myount
Would you like to open a new issue with your font message.
I'm very interrested to dig further more into it. Thanks

I was going to try to reproduce it tonight, and get direct VGA captures from the card (or as direct as I can get, going through an OSSC into an Elgato HDMI capture card)...  but it turns out that I couldn't get it to produce the garbage again.  I guess it was either an artifact of the scaler in the Dell monitor, or the sync settings that the OSSC settled on didn't reveal it.

This should be resolved now


cmd/vet: vet should recommend to use operators instead of strings.Compare to compare strings

What version of Go are you using (go version)?

$ go version
go version go1.17.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?

package main

import "strings"

var x = "abcdefgx"
var y = "abcdefgy"

func main() {
	if strings.Compare(x, y) == 0 {
		println(1)
	}
}

$ go vet main.go

What did you expect to see?
warning that strings.Compare(x, y) == 0 is slower than x == y for some cases.
By the current strings.Compare implementation, all calls to this functions should be warned. (sorry, there are still some cases the strings.Compare way is more performant)
What did you see instead?
Nothing outputted.

related: https://github.com/golang/go/issues/50167

I think vet is more for correctness, not for optimizations. Also, as you mentioned, there are valid uses of strings.Compare. I'm not sure vet should do this.
cc @timothy-king

Here are the vet inclusion criteria https://github.com/golang/go/blob/master/src/cmd/vet/README
This suggestion plausibly fails the "correctness" criteria:
Correctness:

Vet's checks are about correctness, not style. A vet check must identify real or
potential bugs that could cause incorrect compilation or execution. A check that
only identifies stylistic points or alternative correct approaches to a situation
is not acceptable.

An argument might be that this is a not a style suggestion and is instead an efficiency suggestion. My personal inclination is that this qualifies as 'identifying an alternative correct approach to a situation'. I am curious how others feel about this though.
Other thoughts:

This does not mean this is not a good recommendation for a different tool than cmd/vet.
This suggestion is somewhat consistent with the comment in compare.go

I agree that this is not a suitable check for cmd/vet.

This seems like an ideal candidate for a tool like gocritic

OK, I created an issue in the go-critic project: https://github.com/go-critic/go-critic/issues/1167


Perfomance: Improve item copy performance

Copying of a large nested structure with lots of expressions takes a lot of time (in excess of 1 minute). Needs investigation to see where is the bottleneck and if this could be made faster. If not, progress feedback should be created on composer side and ingress timeouts adjusted accordingly.

I closed this issue I believe it has been resolved already


Added support for directory option

Hi Brad,
I've updated the README to show information about the directory option. I needed to reword some parts which weren't really applicable anymore, so let me know if you want any parts changed.
I've also updated the grunt task to use the directory option from the command line if it's available.

Thanks for you contribution @Taiters


Maintainers List Update

Added @aabeshov as a maintainer
Added @Tokesh as a maintainer
Moved @pgtgrly to emeritus
Moved @abhivka7 to emeritus

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Wait to merge until permissions are adjusted pls.

@nhtruong Why did we close this?

@dblock I mass deleted all branches on my fork and didn't know that deleting my fork would close the PR too. Sorry about that.

@nhtruong You have to work with the admin folks for permissions, the CODEOWNERS still looks like those haven't been adjusted.

Maintainer invitations sent to @aabeshov @tokeshib.


Move mill branch to dotty-staging/scala3-example-project

Why do you think it should be moved? This branch is not really a work in progress but a user-facing demo. Maybe a better idea would be to create a separate example project for mill.

Having a scala3-mill-example-project would be much clearer for users. The other thing that might be useful is to have a scala3-mill.g8 template.
This also begs the question if we should rename this project to scala3-sbt-example-project.

Just my 2 cents: if I understood correctly,I think moving Mill to a separate project will increase the maintenance burden. Updates will have to be repeated, no? As a Mill user, if I see a build.sc and the README.md that says this project has SBT and Mill example projects, then its good enough.

The two branches already contain two distinct projects. Putting it in another project would not decrease maintainability by much. We already have to maintain all the scaal3-xyz.g8 projects at the same time which has not been hard.
Having two projects will benefit users as it will be simpler to find and navigate the examples for each build tool.

BTW. By having it in another branch we did not notice that there is no badge in the mill example project readme and that the build is failling.

Moved to https://github.com/dotty-staging/scala3-example-project/tree/mill


Typo: Guest agent

I think this is supposed to be "Guest agent"
https://github.com/kubevirt-ui/kubevirt-plugin/blob/639780605c3e468f677f5459df1aea3745a62a73/locales/en/plugin__kubevirt-plugin.json#L369

fixed by https://github.com/kubevirt-ui/kubevirt-plugin/pull/861
/close


hi，can you support  django-rest-framework

hi，can you support  django-rest-framework
thank you very much  :+1: ）

:+1: I may start working on this later this Spring.


AttributeError: object has no attribute 'resolve'

Hi,
I've experienced a weird condition at templatetags/macros/macros.py:L56: it seems that v could be something other than Variable (say SafeText or None) so the template rendering fails with an AttributeError exception. I haven't ever seen this in development environment and it only happened to me on second or third request to the production server, so I suspect it has something to do with CachedTemplateLoader.
Template example:
{% macro modal_header title=None %}

{{ title|default:"..." }}

{% endmacro %}

Exception: None object has no attribute 'resolve`.
Similar exceptions, but mentioning SafeText happened when I had title="Some text" instead of title=None.
Traceback:
54.     # recall all defaults are template variables
55.    self.kwargs = {k: v.resolve(context)
56.                   for k, v in self.kwargs.items()}

Captured frame contained k = u'title' and v = None (unfortunately, Sentry captures reprs and doesn't dig into objects so it lost exact type information and ability to introspect into self).
A quick-and-dirty workaround v.resolve(context) if isinstance(v, template.Variable) else v seemingly did the trick, but sadly I don't have any idea how such values occurred in self.kwargs in the first place and whenever my fix is correct. Don't have a time at the moment to try to replicate this in a clean empty project - sorry! - but wanted to report this right away.
Any ideas/suggestions?

I investigated and understood the bug.
I can now confirm, the issue is indeed with django.template.loaders.cached.Loader — on the second Template.render invocation self.kwargs are already rewritten with resolved values from the previous render call.
Here's the essence of the issue:
t = Template(
    "{% load macros %}"
    "{% macro test kwarg=foo %}{{ kwarg }}{% endmacro %}"
    "{% use_macro test %}"
)
c1 = Context({"foo": "one"})
c2 = Context({"foo": "two"})
assert t.render(c1) != t.render(c2), "The results must be different"

My originally proposed fix was completely wrong. The correct solution is to not do anything to self.kwargs in DefineMacroNode.render, but to store everything in independent variable. Then, use that variable in UseMacroNode.render instead of self.macro.kwargs. E.g. something along the lines of:
--- a/test_project_python27/test_project_python27/macros/templatetags/macros.py
+++ b/test_project_python27/test_project_python27/macros/templatetags/macros.py
@@ -52,8 +52,8 @@ class DefineMacroNode(template.Node):
         # variables.
         #
         # recall all defaults are template variables
-        self.kwargs = {k: v.resolve(context)
-                       for k, v in self.kwargs.items()}
+        self.kwresolved = {k: v.resolve(context)
+                           for k, v in self.kwargs.items()}

         # empty string - {% macro %} tag has no output
         return ''
@@ -202,7 +202,7 @@ class UseMacroNode(template.Node):
                 context[arg] = ""

         # add all of use_macros kwargs into context
-        for name, default in self.macro.kwargs.items():
+        for name, default in self.macro.kwresolved.items():
             if name in self.kwargs:
                 context[name] = self.kwargs[name].resolve(context)
             else:

Thanks so much!
I'll try to get a fix in this week.
Best,
Nick
On Sep 8, 2015 12:04 PM, "Aleksey Zhukov"<EMAIL_ADDRESS>wrote:

I investigated and understood the bug.
I can now confirm, the issue is indeed with
django.template.loaders.cached.Loader — on the second Template.render
invocation self.kwargs are already rewritten with resolved values from
the previous render call.
Here's the essence of the issue:
t = Template(
"{% load macros %}"
"{% macro test kwarg=foo %}{{ kwarg }}{% endmacro %}"
"{% use_macro test %}"
)
c1 = Context({"foo": "one"})
c2 = Context({"foo": "two"})assert t.render(c1) != t.render(c2), "The results must be different"
My originally proposed fix was completely wrong. The correct solution is
to not do anything to self.kwargs in DefineMacroNode.render, but to store
everything in independent variable. Then, use that variable in
UseMacroNode.render instead of self.macro.kwargs. E.g. something along
the lines of:
--- a/test_project_python27/test_project_python27/macros/templatetags/macros.py+++ b/test_project_python27/test_project_python27/macros/templatetags/macros.py@@ -52,8 +52,8 @@ class DefineMacroNode(template.Node):
# variables.
#
# recall all defaults are template variables-        self.kwargs = {k: v.resolve(context)-                       for k, v in self.kwargs.items()}+        self.kwresolved = {k: v.resolve(context)+                           for k, v in self.kwargs.items()}
     # empty string - {% macro %} tag has no output
     return ''@@ -202,7 +202,7 @@ class UseMacroNode(template.Node):
             context[arg] = ""

     # add all of use_macros kwargs into context-        for name, default in self.macro.kwargs.items():+        for name, default in self.macro.kwresolved.items():
         if name in self.kwargs:
             context[name] = self.kwargs[name].resolve(context)
         else:

—
Reply to this email directly or view it on GitHub
https://github.com/nalourie/django-macros/issues/7#issuecomment-138612791
.

Glad to help. No need to rush, I don't think it's anything urgent.
For a time being, for our own uses, I've just replaced PyPI dependency to my fork. You may consider cherry-picking my commit to save time, if you consider it a proper solution.
(Completely unrelated to the issue, I've also did some source tree cleanups and added tox testing against various Python&Django versions, so you may be interested in some other changes in my fork. Not sending proper pull requests yet, because my changes are somewhat dirty and I'm not sure I really did things the right way.)


Missing carriage returns in PDF

Describe the bug
When parsing a PDF file (produced from google docs), the carriage return are missing.
Do you know any workaround regarding this ?
To Reproduce
Steps to reproduce the behavior:
# No CR
print(textract.process('Test document 2.pdf'))

# Same document in docx format
# CR are properly found
print(textract.process('Test document 2.docx'))

Test document 2.docx
Test document 2.pdf
Expected behavior
I expect to find CR.
Desktop (please complete the following information):

OS: Windows 10
Textract version 1.6.3
Python version 3.7
Virtual environment yes

I get the following output for both files, using both pdf extraction methods available. There are no carriage returns, but I do get newlines which I think is what you want?
import textract

textract.process("test.docx").decode("utf8")
>>> 'Test document\n\n\n\nThis document is for testing.\n\n\n\nCheers'
textract.process("test.pdf", method="pdftotext").decode("utf8")
>>> 'Test document\nThis document is for testing.\nCheers\n\n\x0c'
textract.process("test.pdf", method="pdfminer").decode("utf8")
>>> 'Test document \n \nThis document is for testing. \n \nCheers \n \n \n\n\x0c'

Textract is only a wrapper around other tools that do the actual parsing. If something is wrong with the pdf parsing output, usually the issue lies with the parsing tools and not textract. While textract isn't parsing the pdf file, I do know that extracting the layout from a pdf (such as linebreaks, positioning, ...) is a non trivial task. That being said, I wonder what you're expected behaviour would have been in the output above?

Thanks for the feedback, indeed you're right I meant newlines not carriage returns.
That's interesting because I was not getting the newlines at all, I was getting this:
print(textract.process('Test document 2.pdf'))
'Test document This document is for testing. Cheers  \x0c'

But maybe it's because I did not provide a method like you did. I'll give it a shot tonight and let you know.

The method shouldn't matter, I just tried both to see if this issue is specific to one of the available methods. The standard method is pdftotext and textract falls back to pdfminer if it isn't available.
Do be aware that textract returns byte objects and not string objects. Printing a byte object shows \n while printing the decoded output, as in my previous reply, would print newlines instead of  \n.
>>> import textract
>>> print(textract.process("test.pdf"))
b'Test document\nThis document is for testing.\nCheers\n\n\x0c'
>>> print(textract.process("test.pdf").decode("utf8"))
Test document
This document is for testing.
Cheers

That's quite weird, I can reproduce the issue:
text_A = textract.process(r'C:\Users\Remi\Downloads\Test document 2.docx')
text_B = textract.process(r'C:\Users\Remi\Downloads\Test document 2.pdf')
print(text_A)
print(text_B)

b'Test document\n\n\n\nThis document is for testing.\n\n\n\nCheers'
b'Test document This document is for testing. Cheers\r\n\r\n\x0c'

I tried by passing method=pdftotext, I get the same result.
And method=pdfminer crashes with the following issue:
Traceback (most recent call last):
  File "compare_app\services.py", line 27, in <module>
    text_B = textract.process(r'C:\Users\Remi\Downloads\Test document 2.pdf', method="pdfminer")
  File "C:\Users\Remi\.virtualenvs\compareanything-nxT9K_aM\lib\site-packages\textract\parsers\__init__.py", line 77, in process
    return parser.process(filename, encoding, **kwargs)
  File "C:\Users\Remi\.virtualenvs\compareanything-nxT9K_aM\lib\site-packages\textract\parsers\utils.py", line 46, in process
    byte_string = self.extract(filename, **kwargs)
  File "C:\Users\Remi\.virtualenvs\compareanything-nxT9K_aM\lib\site-packages\textract\parsers\pdf_parser.py", line 31, in extract
    return self.extract_pdfminer(filename, **kwargs)
  File "C:\Users\Remi\.virtualenvs\compareanything-nxT9K_aM\lib\site-packages\textract\parsers\pdf_parser.py", line 48, in extract_pdfminer
    stdout, _ = self.run(['pdf2txt.py', filename])
  File "C:\Users\Remi\.virtualenvs\compareanything-nxT9K_aM\lib\site-packages\textract\parsers\utils.py", line 96, in run
    stdout, stderr = pipe.communicate()
UnboundLocalError: local variable 'pipe' referenced before assignment

Are you running on Windows or Linux ?

I get the same results on Windows 10 as on Linux (WSL). I did notice the same issue with the pdfminer method on Windows. There's an issue discussing it in great detail, #154, and I posted the start of a solution there. The full solution will be included in the next version of textract.
Which version of pdftotext are you using? The latest version that is easily installed on Windows are the command line tools from Xpdfreader. Could you try installing these and see if it changes the output?


🐛 [FirebaseAuth] EmailAuthProvider.credential and linkWithCredential does not work as expected

Bug report
I'm having trouble to convert an anonymous Firebase user to a registered user with email and password. It seem's like EmailAuthProvider.credential creates a new user (with new uuid and everything) instead of converting the current anonymous user.
Steps to reproduce
My code looks like this:

Create a anonymous user

Future signInAnonymously() async {
    try {
      await _auth.signInAnonymously();
    } on auth.FirebaseAuthException catch (e) {
      throw SignInException(e.code);
    }
  }

Convert to a user with email and password

Future linkAnonymousAccount({
    required String email,
    required String password,
  }) async {
    try {
      await _auth.currentUser!.linkWithCredential(
        auth.EmailAuthProvider.credential(email: email, password: password),
      );
      // await refreshUser();
    } on auth.FirebaseAuthException catch (e) {
      throw LinkAnonymousAccountException(e.code);
    }
  }

Expected behavior
I expect that my anonymous user is converted and has the same uuid, displayName and photoUrl as before. My firebase console should have exactly one user entry. But unfortunately a second user get's created with a different uuid and without a displayName (I assigned one previously to the anonymous user).
I'm sorry if I miss something obviously. Thanks in advance!
Additional context
The result of step one and two:

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.5.0, on Microsoft Windows [Version 10.0.19041.1288], locale de-DE)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 4.1)
[√] VS Code (version 1.61.2)
[√] Connected device (2 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
dependencies:
- bloc 7.2.0 [meta]
- cupertino_icons 1.0.3
- day_night_switcher 0.2.0+1 [flutter]
- equatable 2.0.3 [collection meta]
- firebase_auth 3.1.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.6.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_bloc 7.3.0 [flutter bloc provider]
- flutter_localizations 0.0.0 [flutter intl characters clock collection meta path typed_data vector_math]
- formz 0.4.0
- intl 0.17.0 [clock path]
- persistent_bottom_nav_bar 4.0.2 [flutter]
- shared_preferences 2.0.8 [flutter meta shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]

dev dependencies:
- bloc_test 8.3.0 [bloc meta mocktail test]
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- mockito 5.0.16 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api]

transitive dependencies:
- _fe_analyzer_shared 26.0.0 [meta]
- analyzer 2.3.0 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml pedantic]
- args 2.3.0
- async 2.8.1 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.1.1 [analyzer async convert crypto glob logging meta path]
- built_collection 5.1.1
- built_value 8.1.2 [built_collection collection fixnum meta]
- characters 1.1.0
- charcode 1.3.1
- cli_util 0.3.3 [meta path]
- clock 1.1.0
- code_builder 4.1.0 [built_collection built_value collection matcher meta]
- collection 1.15.0
- convert 3.0.1 [typed_data]
- coverage 1.0.3 [args logging package_config path source_maps stack_trace vm_service]
- crypto 3.0.1 [collection typed_data]
- dart_style 2.2.0 [analyzer args path pub_semver source_span]
- fake_async 1.2.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase_auth_platform_interface 6.1.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 3.1.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.0.1 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.0.0
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- frontend_server_client 2.1.2 [async path]
- glob 2.0.1 [async collection file path pedantic string_scanner]
- http_multi_server 3.0.1 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- io 1.0.3 [meta path string_scanner]
- js 0.6.3
- lints 1.0.1
- logging 1.0.2
- matcher 0.12.10 [stack_trace]
- meta 1.7.0
- mime 1.0.0
- mocktail 0.1.4 [collection matcher test]
- nested 1.0.0 [flutter]
- node_preamble 2.0.1
- package_config 2.0.2 [path]
- path 1.8.0
- path_provider_linux 2.1.0 [flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.0.1 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.3 [ffi flutter meta path path_provider_platform_interface win32]
- pedantic 1.11.1
- platform 3.0.2
- plugin_platform_interface 2.0.1 [meta]
- pool 1.5.0 [async stack_trace]
- process 4.2.3 [file path platform]
- provider 6.0.1 [collection flutter nested]
- pub_semver 2.1.0 [collection meta]
- shared_preferences_linux 2.0.2 [file meta flutter path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 2.0.2 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.2 [flutter flutter_web_plugins meta shared_preferences_platform_interface]
- shared_preferences_windows 2.0.2 [flutter file meta path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.2.0 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 3.0.0 [path shelf shelf_static]
- shelf_static 1.1.0 [convert http_parser mime path shelf]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.1.1 [analyzer async build dart_style glob meta path source_span yaml]
- source_map_stack_trace 2.1.0 [path stack_trace source_maps]
- source_maps 0.10.10 [source_span]
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test 1.17.10 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]
- test_api 0.4.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.4.0 [analyzer async args boolean_selector collection coverage frontend_server_client glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0
- vm_service 7.3.0
- watcher 1.0.0 [async path pedantic]
- web_socket_channel 2.1.0 [async crypto stream_channel]
- webkit_inspection_protocol 1.0.0 [logging]
- win32 2.2.9 [ffi]
- xdg_directories 0.2.0 [meta path process]
- yaml 3.1.0 [collection source_span string_scanner]

@M4tth1as I'm assuming that _auth is a reference to FirebaseAuth.instance, but what does auth refer to?

@M4tth1as I am using basically the same approach that you are using, but my outcome is a single Firebase account. The anonymous account is being converted to an email account as expected.  The only notable difference is that I am not setting displayName nor photoUrl

You're right @spookymodem.  I used Bloc for State Management and used the wrong bloc on the regarding screen, which didn't called the linkAnonymousAccount-Method. My apologize, I'm closing here.


Warning: Product properties should not be accessed directly

I updated to WooCommerce 3.0. Now I get the following warning:
[10-May-2017 09:02:21 UTC] id was called incorrectly. Product properties should not be accessed directly. Backtrace: require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), do_action('template_redirect'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, WC_AJAX::do_wc_ajax, do_action('wc_ajax_checkout'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, WC_AJAX::checkout, WC_Checkout->process_checkout, WC_Checkout->process_order_payment, WC_Gateway_BACS->process_payment, wc_reduce_stock_levels, wc_update_product_stock, WC_Product->save, WC_Data_Store->update, WC_Product_Data_Store_CPT->update, WC_Product_Data_Store_CPT->update_post_meta, update_post_meta, update_metadata, apply_filters('update_post_metadata'), WP_Hook->apply_filters, call_user_func_array, Hyyan\WPI\Product\Variable->skipDefaultAttributesMeta, Hyyan\WPI\Utilities::maybeVariableProduct, WC_Abstract_Legacy_Product->__get, wc_doing_it_wrong. This message was added in version 3.0.

Tested with Chrome and Hyyan WooCommerce Polylang Integration Version 0.29.1

Hyyan WooCommerce Polylang Integration Version 0.29.1 does NOT work with WooCommerce 3.0.
see the 0.30 RC1 Pull Request or release branch here:
https://github.com/Jon007/woo-poly-integration/releases


Add support for project option in tslint

Codecov Report

Merging #258 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   90.82%   90.83%   +<.01%
==========================================
  Files          45       45
  Lines        2628     2630       +2
==========================================
+ Hits         2387     2389       +2
  Misses        241      241

Impacted Files
Coverage Δ

lintreview/tools/tslint.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e36ecc...c373d0e. Read the comment docs.


Wagtail 5.2

Wagtail 5.2 release notes
Includes PR: https://github.com/wagtail/wagtail-autocomplete/pull/162
Changes:

Update test matrix to include Wagtail 5.2
Remove tests for Wagtail 4.2 and 5.0 as they have reached their EOL

Superseded by: https://github.com/wagtail/wagtail-autocomplete/pull/169


pfSimpleSort not included in bower dist 2.2.1

When installing angular-patternfly v2.2.1 via bower,  angular-patternfly.js is missing the pfSimpleSort directive.

pfSimpleSort was added after 2.2.1 was released. It is in the master repo and will be included in the next release.

pfSimpleSort is now available in 2.3.0


Make logger instance local to each instance that uses it

Any class with verbose property should now implement an (optional) logger prop (which if not specified defaults to global logger as before).
BaseLogger now inherits from pydantic.BaseModel so that it can easily be used as the type of a property on the other classes which inherit from BaseModel.

@hwchase17 This is a first step towards being able to eg. run multiple independent agents in the same python process logging to different places.

Closing this


Printer Layout Settings

I appreciate you adding custom sizes. I do have one more somewhat minor issue. Eventhough I have the Column and Row set to 1x1. it is still by default showing 3 rows. Not that big of a deal but if I forget to select the page to print to 1, it prints two blanks.

I noticed this as well. Possibly a bug?


FreeType support for gd extension

I read the php-nginx README.md and it says

These extensions are compiled as shared (you need to enable with php.ini):
GD (gd; with PNG, JPEG and FreeType support)

but when i check my app's php -i, I see that FreeType for gd extension is not enabled.
Do I have to add anything other than
extension=gd.so
in my php.ini to enable the FreeType support?

@yukiorii Thanks for the report. Definitely the support was missing. We'll add it soon.

We'll release a new runtime soon. I'll close this when it's done

Released! https://github.com/GoogleCloudPlatform/php-docker/releases/tag/2017-03-21-20-26


[Feature Request]:  Add title and createdAt for DAOSpace proposal

Feature Request
Describe the Feature Request
According to the previous proposal interface, proposals defined in DAOSpace now lack the proposal title and proposal creation time fields.

@jolestar @WGB5445

I remember we discussed this.
The description field is a to an IPFS json file and contains all the proposal's information.

description

Loading IPFS content on the list page will be slower because each list item is loaded. I think it is more appropriate to load IPFS content only on the details page.

增加 title|description
扩展字段 properties ? 考虑使用什么方案

#183 已解决，关闭该 issue

#183 已解决，关闭该 issue

什么时候部署halley网络？

#183 已解决，关闭该 issue

什么时候部署halley网络？

https://github.com/starcoinorg/starcoin/pull/3786


Output InspectCode result in XML format

Latest InspectCode version generates a SARIF file by default. Enforce to write an XML file which Cake.Issues can parse.
Once we've updated to Cake Issues 3.x we can use the available SARIF parser.

@pascalberger thank you for catching, and fixing, this!


Unable to create with npx

npx --yes -- create-figma-plugin figma-hello-world --yes
npm --version
7.19.0

file:///Users/xxx/.npm/_npx/439399134eb6e80a/node_modules/create-figma-plugin/lib/utilities/settings/create-plugin-display-name.js:1
import { titleCase } from 'title-case';
         ^^^^^^^^^
SyntaxError: The requested module 'title-case' does not provide an export named 'titleCase'
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:92:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:107:20)
    at async Loader.import (internal/modules/esm/loader.js:179:24)

Thoughts???

Node.js v14 is required to use 1.0.0 of this toolkit

yeah, I am already on node v14.0.0. 😑

Unfortunately, I’m not able to replicate this problem locally.
$ node --version
v14.15.4
$ npm --version
7.19.0
$ npx --yes -- create-figma-plugin figma-hello-world --yes
info Scaffolding a new plugin...
info Cloning template...
info Installing dependencies...
success Done
$ cd figma-hello-world
$ npm run build

><EMAIL_ADDRESS>build
> build-figma-plugin --typecheck --minify

info Building...
success Built in 2.437s

Other boilerplates/tools that you can consider using instead of Create Figma Plugin: https://github.com/thomas-lowry/figma-plugins-on-github#resources

I am having an issue as well, but mine is when I omit the second --yes from the npx command ... when I do that I type in the info for each prompt, and then I get to the end and I see this message: error The "path" argument must be of type string. Received undefined
However, I was never prompted to input a path?

@Jeremy-Knudsen Ah! There’s a bug with the CLI argument parsing. Until a fix is released, you will need to do something like this:
$ npx --yes -- create-figma-plugin figma-hello-world --template default

@Jeremy-Knudsen The bug you reported should be fixed as of 1.2.1

@yuanqing it is strange, only title-case package gives me the error.
I have to remove that usage to make it work for now.

Also, getting other error
➜  figma-hello-world2  npm run watch

> watch
> build-figma-plugin --typecheck --watch

internal/modules/run_main.js:54
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:666:11)
    at Loader.resolve (internal/modules/esm/loader.js:97:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:42:40)
    at link (internal/modules/esm/module_job.js:41:36) {
  code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'
}

It maybe just my desktop issue, switch to another computer which seems fine now. thanks!

For anyone else facing this issue
Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:666:11)
    at Loader.resolve (internal/modules/esm/loader.js:97:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:42:40)
    at link (internal/modules/esm/module_job.js:41:36) {
  code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'
}

It went away after after I upgraded my node version from v14.1.0 to v14.15.4 and my npm version to 7.19.0


Docker-compose can't start bot-pokegoweb

Expected Behavior
Working version..
Actual Behavior
Youris-MBP:pokebot youri$ docker-compose up
Starting pokebot_bot-pokego_1
Starting pokebot_bot-pokegoweb_1

ERROR: for bot-pokegoweb  Cannot start service bot-pokegoweb: oci runtime error: rootfs_linux.go:53: mounting "/var/lib/docker/aufs/mnt/6ac1f75194cc7b828690d9b215082f40e41aa7228523101a935ea62ba1cecab6/usr/src/app/web/config/userdata.js" to rootfs "/var/lib/docker/aufs/mnt/6ac1f75194cc7b828690d9b215082f40e41aa7228523101a935ea62ba1cecab6" caused "not a directory"
ERROR: Encountered errors while bringing up the project.

Other Information
OS:
Git Commit: 298006d868f3fe85a2c93526589a1ba6b26695f1
Python Version: 2.7.10

@YOUR1 Update to the latest version as there has been some significant changes, and this may solve your problem


Optimize bundling of Modules/Libs shared between lazy loaded modules

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Desired functionality.
Here's a fairly common scenario: I have an application which has two feature modules that each depend on chart.js. Last time I checked with webpack-bundle-analyzer, angular-cli included the full chart.js library in each of the two feature modules.
The more general case is that feature modules (FM) may want to share another module between another, e.g. I have FM A and FM B and both access an angular module X. However, FM C and FM D do not depend on X. It would be awesome if angular-cli could figure that out from the module declarations/imports and then ensure that module X is loaded the first time either FM A or FM B is loaded. Of course, this would require that X be put in its own bundle/chunk.
Mention any other details that might be useful.
I've just stumbled over an article indicating that webpack should support such a scenario with the commonschunk plugin:
https://medium.com/webpack/webpack-bits-getting-the-most-out-of-the-commonschunkplugin-ab389e5f318

The common chunks plugin is actually used.  I have also experimented with alternate configurations (various settings, multiple instances, etc.) within the CLI.  Unfortunately, the common chunks plugin currently does not analyze the full depth of the child hierarchy.  There is this webpack PR that should hopefully improve the situation.

Unless something like a change to common chunks plugin as above PR etc, it's very hard to bring this in.
Currently (loosely speaking) the only sources for chunks are whether vendor chunk is being used or not, and lazy loaded routes.
For the lazy loading, the compiler checks for the loadChildren routes of AppModule and finds which modules those refer to, and repeats the check recursively for all checked modules. It then generate the route information which is later passed to both Webpack for creating chunks, and the router for knowing which imports to call in runtime. It would require a lot of changes to separate both paths, and to also analyze all imports of each module to decide which is used multiple times and could benefit from being a separate bundle.
Without a separate chunk, the only way to import module X once today is to import it in AppModule. This means it doesn't get lazy loaded, and you get to choose between either lazy loading multiple times, or single initial loading.

Hm, I can't comment on the details of integrating this with webpack as I'm far from being an expert in this. Maybe someone like @TheLarkInn could provide some valuable insight as well.
In any case, I though it may be interesting to share the current workaround that I'm using: https://gist.github.com/JohannesRudolph/87bf06aeaa0a94f1129fd0e0216be18f
It's simple and stupid, but at least it ensures very large third party libs (like chart.js) can be reasonably shared between lazy loaded feature modules without duplicate loading. Mind you this comes at the expense of totally evading webpack and any potential benefits we could have from it (e.g. tree-shaking).

The common chunks plugin is already integrated with the CLI.  Without additional improvements to the common chunks plugin, there is not much more that can be done currently.  Especially if an app has lazy loaded routes with a depth of more than one.

Have you also considered adding the library to the scripts array in .angular-cli.json, with the lazy option set?
Docs

Rollup not working in async router module #7143
@filipesilva
I update the angular/cli to version 1.2.6. The problem seems to be solved, but it introduces a new problem.
The new problem is the async router module bundle itself twice.

I update the code to the repo angular-asyn-routing-test/tree/dev
Looking forward to your reply.

https://github.com/webpack/webpack/pull/4255 has been resolved, is there another blocker?

@mgol I havent had time to look at it further but we've since created a common module that includes all the code shared between lazy routes. Does that not suffice for you case? Can you see any differences when you use the fix in webpack/webpack#4255? If so, you could do a PR.

Consider this situation. A, B, C modules can be lazy loaded at /a, /b, and /c. B and C have a large set of shared dependencies. Most users will start with /a and therefore, it would be best if this large set of dependencies was postponed until /b or /c are accessed. AFAICT, the fact that both B and C share some code means it ends up in the common bundle and therefore gets loaded for /a. It would be preferable if B and C's dependencies were packed into a separate bundle that only got loaded when either /b or /c are accessed. Is this possible with angular-cli, currently?

@filipesilva In a lot of apps, you can't predict what page the user will land on first. The user might also refresh the browser anywhere. If they do this on a route that was lazy-loaded, the it will require common.js which is probably very large. If the code was split into smaller common chunks, it could make a big difference. The app I'm working on has a main/common/lazy-feature ratio of about 1/8/1, so in my case we would benefit a lot from this.
I've been trying to figure this out all day. When it looked like smaller common chunks weren't supported, I tried a hack to force Angular to create a separate chunk for shared module X by defining a lazy-loaded route for it at /x. I figured x.js would get created, which would then be fetched when the user goes to /a, /b, or /x. However, the priority goes to common.js and when I go to /x there isn't an x chunk, instead common.js loads, which still contains the shared module X.

This is more advanced code splitting is now supported with Angular CLI 6.0+.

@clydin That's amazing! I wasn't aware of this! Do you know if this new capability is documented somewhere?

Yes we noticed the same thing after upgrading. All of a sudden we had like
15 bundles more than before. Very cool stuff :-)
Mike Pearson<EMAIL_ADDRESS>schrieb am Do. 6. Dez. 2018 um
20:34:

@clydin https://github.com/clydin That's amazing! I wasn't aware of
this! Do you know if this new capability is documented somewhere?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/6204#issuecomment-445000977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH8N062A8A4Q-qr2RR5P6dgNz1cWFuIks5u2XFQgaJpZM4NSrDn
.

@mfp22 I wrote up a description of the new behavior in this comment: https://github.com/angular/angular-cli/issues/10364#issuecomment-382040140

I've read through all these comments, feature requests, documentation, and I'm still lost. I get no extra bundles when building, and I see common modules show up in both my root module and my lazy-loaded module. I'm building with every variation of ng build --prod --aot --commonChunk I can think of. What do I do to get this "splitting" behavior?
Angular CLI: 7.3.3
Node: 8.11.3
OS: win32 x64
Angular: 7.2.7
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.3
@angular-devkit/build-angular     0.13.1
@angular-devkit/build-optimizer   0.13.1
@angular-devkit/build-webpack     0.13.1
@angular-devkit/core              7.3.3
@angular-devkit/schematics        7.3.3
@angular/cdk                      7.3.3
@angular/cli                      7.3.3
@angular/material                 7.3.3
@ngtools/webpack                  7.3.1
@schematics/angular               7.3.3
@schematics/update                0.13.3
rxjs                              6.4.0
typescript                        3.2.4
webpack                           4.29.0


Remove uneccesary pip installs from notebook

Since we now use a custom image that pre installs these packages, we don't need these in the notebook.

/gcbrun

v1.1 cherry-pick https://github.com/GoogleCloudPlatform/ai-on-gke/pull/486


[Bug]: Patch 6 Mod Manager Disables Mods Unable to Load Save

Operating System
Windows 11
BG3 Mod Manager Version
<IP_ADDRESS>
BG3 Game Version
Patch 6 Beta
Bug Summary
Hi! I hope everything is going well. I want to report a bug, every time I try to export my BG3 mods to my mod manager for Patch 6, it immediately disables them and resets the mod settings file. I have no idea what's going on.
Links
No response

you have incompatible mods. the patch 6 beta branch is more like a mix of patch 6 and patch 7. mods that are incompatible with patch 7 may still be incompatible with patch 6 beta.


Doesn't support writing?

I'm successfully mounting emulators on mac, but I can't seem to write to them. I'm attempting to write to the /sdcard dir, and receiving:
touch: foo.text: Function not implemented```

Is writing unimplemented yet?

Yep, writing hasn't been implemented yet.

Is it coming soon? I'd recommend mentioning this in the README (I spent a
chunk of time building adbfs into our toolset without awareness that it
wouldn't be functional yet).
On Thu, Dec 24, 2015 at 4:28 AM, Zach Klippenstein<EMAIL_ADDRESS>
wrote:

Yep, writing hasn't been implemented yet.
—
Reply to this email directly or view it on GitHub
https://github.com/zach-klippenstein/adbfs/issues/18#issuecomment-166950240
.

For writing, in addition to supporting file writes, the following operations will be supported (from https://godoc.org/github.com/hanwen/go-fuse/fuse/pathfs#FileSystem):

Create
Chmod
Chown
Utimens
Mkdir
Rmdir
Rename
Link
Unlink
Symlink

This sounds great! I just need to create dirs and files.
I just checked out the latest and re-ran the install.sh script. Automounter is mounting a Genymotion emulator, but the contents of the dir are empty.

Can you run automounter with the -v flag and send me the output?
In other news, I've got support for file writes kind of working in a branch for OSX, but Finder's doing some weird stuff so you have to use the command line for most things. If you want to give it a try checkout the file-write branch.

Still haven't been able to find out why Finder doesn't want to cooperate. The file-write branch is getting a lot closer to being ready to merge though, I basically just need to write a bunch of tests and make sure I haven't broken anything with all the rebasing I've been doing this week. I'm back to my day job this week though so not sure when I'll get to finishing it.

Finder bug is now its own issue: #34


Remove //tools/runfiles and add //cc/runfiles

The targets in the old package were either not publicly visible or testonly dependencies and had diverged heavily from @bazel_tools.
Instead, add an alias to the Bazel-provided runfiles library under //cc/runfiles, following https://bazel.build/rules/deploying.

@oquenchil import/copybara is failing. Happy to look into the failure, but I don't seem to be able to access the logs.

Hey Fabian, it looks like I'm going to have to do this change internally first. I will credit you with ORIGINAL_AUTHOR.
The problem is that the copybara scripts are internal because they contain internal paths. The error I'm seeing is that a move is being applied on a file that doesn't exist in the working directory (which makes sense because it has been deleted). So I have to delete the file and modify the copybara script in the same change.


Gareth update Developer's Guide

Updated the export function:

Explain how the export function works
Include sequence digram to illustrate
Explain design ideas and implementation

Codecov Report

Merging #119 (6386434) into master (6475e59) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     54.92%   54.92%
  Complexity      571      571
=========================================
  Files           101      101
  Lines          2658     2658
  Branches        374      374
=========================================
  Hits           1460     1460
  Misses          962      962
  Partials        236      236

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


single-spa-layout

there are issues and bugs in single-spa-layout

Hi, we are actively working on reviewing issues, pull requests, and fixing bugs.


tofu 1.4.1 installation on Eurofusion Gateway failing

The pip installation on the gateway failed.
In fact, it succeeded, but there is an error at import time, suggesting something went wrong at compilation time.
The error message is somewhat similar to the first one obtained on ITER:
In [1]: import tofu
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/_core.py in <module>()
     29 try:
---> 30     import tofu.geom._def as _def
     31     import tofu.geom._GG as _GG

AttributeError: module 'tofu' has no attribute 'geom'

During handling of the above exception, another exception occurred:

TypeError                                 Traceback (most recent call last)
/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/_GG.py in <module>()
     14     try:
---> 15         from tofu.geom._GG03 import *
     16     except Exception:

/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/_GG03.pyx in init tofu.geom._GG03 (tofu/geom/_GG03.cpp:103443)()
----> 1 # cython: boundscheck=False
      2 # cython: wraparound=False
      3 # cython: initializedcheck=False

TypeError: C function tofu.geom._basic_geom_tools.compute_hypot has wrong signature (expected arrayobject *(__Pyx_memviewslice const , __Pyx_memviewslice const , struct __pyx_opt_args_4tofu_4geom_17_basic_geom_tools_compute_hypot *__pyx_optional_args), got arrayobject *(__Pyx_memviewslice, __Pyx_memviewslice, struct __pyx_opt_args_4tofu_4geom_17_basic_geom_tools_compute_hypot *__pyx_optional_args))

During handling of the above exception, another exception occurred:

ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-fb62ffe09d58> in <module>()
----> 1 import tofu

/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/__init__.py in <module>()
     70 from tofu.utils import save, load, load_from_imas, calc_from_imas
     71 import tofu._plot as _plot
---> 72 import tofu.geom as geom
     73 import tofu.data as data
     74

/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/__init__.py in <module>()
     10 """
     11
---> 12 from tofu.geom._core import PlasmaDomain, Ves, PFC, CoilPF, CoilCS, Config
     13 from tofu.geom._core import Rays, CamLOS1D, CamLOS2D
     14 from . import utils

/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/_core.py in <module>()
     34 except Exception:
     35     from . import _def as _def
---> 36     from . import _GG as _GG
     37     from . import _comp as _comp
     38     from . import _plot as _plot

/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/geom/_GG.py in <module>()
     15         from tofu.geom._GG03 import *
     16     except Exception:
---> 17         from _GG03 import *

ModuleNotFoundError: No module named '_GG03'

@Didou09 for this build GCC which is being used is in version 6.1.0 and cython in version 0.29.13

I've been checking further this issue, when tried to reinstall with -v and --force-reinstall I saw some errors messages with scipy that was required in a different version for another package. After removing this package and installing tofu it seems to work better.

I've been successfully running the first part of the 5 min tutorial, so I guess basic install is ok:
In [4]: import tofu as tf
No module named 'pywed'
No module named 'pywed'
/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/__init__.py:28: UserWarning: Traceback (most recent call last):
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/magFieldLines.py", line 30, in <module>
    from tofu.mag.mag_ripple.mag_ripple import mag_ripple
ModuleNotFoundError: No module named 'tofu.mag.mag_ripple.mag_ripple'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/__init__.py", line 13, in <module>
    from tofu.mag.magFieldLines import *
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/magFieldLines.py", line 32, in <module>
    from mag.mag_ripple.mag_ripple import mag_ripple
ModuleNotFoundError: No module named 'mag'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/magFieldLines.py", line 30, in <module>
    from tofu.mag.mag_ripple.mag_ripple import mag_ripple
ModuleNotFoundError: No module named 'tofu.mag.mag_ripple.mag_ripple'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/__init__.py", line 15, in <module>
    from .magFieldLines import *
  File "/gw/switm/python/3.6.0.b3/lib/python3.6/site-packages/tofu/mag/magFieldLines.py", line 32, in <module>
    from mag.mag_ripple.mag_ripple import mag_ripple
ModuleNotFoundError: No module named 'mag'

    => the optional sub-package tofu.mag is not usable

  warnings.warn(msg)

In [5]: configB2 = tf.geom.utils.create_config("B2")

In [6]: configB2.plot()
Out[6]:
[<matplotlib.axes._axes.Axes at 0x2ba041e82ef0>,
 <matplotlib.axes._axes.Axes at 0x2ba0422ec438>]

Ok, so it suggests it was dependencies-related.
We still need to investigate because installing tofu should be easy despite its co-existence with other packages.
Regarding the tutorial:
tofu has 2 optional sub-packages : tofu.imas2tofu and tofu.mag
They are optional in the sense that they rely on specific libraries (imas and a fortran library) that not everyone has.
When importing tofu, if one of these dependencies is detected as absent, tofu throws a warning specifying that the corresponding optional sub-package is not usable, but does not throw an error.
This way the user is informed of why the sub-package cannot be used, but he can still use the rest of tofu normally.
The warning includes the traceback to make debugging easier in case the user wants to find out what happened.
Thanks very much for your detailed feedback and help @olivhoenen, we can consider basic install is fine until @lasofivec comes back and has a closer look at the first failed attempt (at least to make installing future releases more robust).

I've been checking further this issue, when tried to reinstall with -v and --force-reinstall I saw some errors messages with scipy that was required in a different version for another package. After removing this package and installing tofu it seems to work better.

Thanks for the feedback @olivhoenen.
So, in conclusion the installation (or update?) from pip didn't work but forcing the reinstallation/compilation of the library made it work?
Do you remember which package(s) had issues as you stated above?
It wasn't clear to me if it were tofu's dependencies, tofu modules or un related installed packages.

Hi @lasofivec, yes the aforementioned package was EasyVVUQ (which is still in alpha stage, and I'm not 100% sure which version I had back then) developed in another project and which has this this of requirements. Not that I am not so sure if removing this package (and it's scipy related conflict) was the only reason for this issue, as --force-reinstall also updated quite a few other packages.

I'm thinking it is more the --force-reinstall that did the trick.
On another platform installing by using the setup tools a clean was necessary before the installation was successful. I am not sure why it didn't work out of the box though.


Fix help to provide sample that actually works

Using 1 doesn't display privileged containers but if we use true it does.

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Hi, you need to sign-off your commit. This should be as simple as git commit -s ... :)

Ok, let me give it another try.

@elvsp1n looks good, but since you're modifying a translated string, you should run "make i18n" and commit the changes it makes as a second commit (we usually call it "i18n: update templates").
If you're not on a system where you can run "make i18n", let me know and I'll do it for you.

@stgraber I should be able to do it from osx or ubuntu, let me give it a try to keep learning this git process that you guys have.

Ok gents, I was able to do it on a fresh ubuntu install with this:
Ubuntu:
sudo apt install make golang gettext
export PATH=$PATH:/usr/local/go/bin
export GOPATH=$HOME/go
export PATH=$PATH:$GOROOT/bin:$GOPATH/bin
mkdir -p ~/go/src
git clone https://github.com/elvsp1n/lxd
cd lxd/
git checkout patch-3
make i18n
Running git status I see this
modified:   po/de.po
modified:   po/el.po
modified:   po/fr.po
modified:   po/it.po
modified:   po/ja.po
modified:   po/lxd.pot
modified:   po/nl.po
modified:   po/ru.po
modified:   po/sr.po
modified:   po/sv.po
modified:   po/tr.po
Now I added the file with
git add .
Then committed the changes (with the signoff)
git commit --signoff -m "i18n: update templates"
And finally
git push
Sorry for all the details, I use this for future reference for my own :). I will now start using make i18n on my own projects as this make things way easier to keep everything translated.

Sounds good.

jenkins: test this please


Different Resolutions misplace buttons

When you change resolutions in the game view, the buttons move into different places

Not a major issue if we only stay in one, but we would need to decide what
still a good fix if someone has time

Got closer with this

However there isn't a GREAT solution
It looks like we will just need to create bigger buttons or find the PERFECT ratio
Regardless, this should not be a priority while we still use the not ideal background


error occurred at dialog prompt

i got error when submitted at dialog prompt
Uncaught TypeError: Cannot read property 'checkValidity' of undefined
    at o.html5Validation (app.ed77701….js:1)
    at o.n [as html5Validation] (vendor.726eec4….js:6)
    at o.blur (app.ed77701….js:1)
    at n (vendor.726eec4….js:6)
    at HTMLInputElement.t (vendor.726eec4….js:6)
    at Object.Ot [as removeChild] (vendor.726eec4….js:6)
    at r (vendor.726eec4….js:6)
    at n (vendor.726eec4….js:6)
    at vendor.726eec4….js:6
    at vendor.726eec4….js:6
    at c (vendor.726eec4….js:6)
    at HTMLDivElement.d (vendor.726eec4….js:6)

Gonna take a look at it tomorrow, did you clone or is it in the online docs?

in online docs site!

This is not happening here 🤔
Tested in Chrome, Firefox and Edge.

😟 I got this error in Chrome. And my team's browser too. I've tested at firefox, and it was OK.
I have no clue why it is ok at your env...
I figure it is not critical problem, so there is no problem to close this issue.
Thanks.

It might've been fixed at the v0.3.2, could you take a look?


[Question]How can I not show the dates with no data in the OHLC chart?

How can I not show the dates with no data in the OHLC chart so that the graph is continuous?
In example: https://hvplot.holoviz.org/reference/tabular/ohlc.html
how to not show the non trading dates' data with empty in chat?

Do you mean skip the gaps? https://github.com/holoviz/hvplot/issues/1458


[BTC] Add 10k sats treshold for swap / deposit

wallet should not allow user to send less than 10K says to asgard

^ See https://discord.com/channels/838986635756044328/839002619481554955/848778233075335218 (and its following message)

V


Fix unscoped template variables

LDAP related variables in rabbitmq.config.erb rely
on dynamic scoping, which is discontinued in the future parser.
They need to be exposed in rabbitmq::config in order to be
accessible in the template.

This fix is blocking for Puppet 4 migration.
@cmurphy @mhaskel can you check it please?


[CELEBORN-623][FOLLUPUP] Refine doc about use ratis shell with RSS cluster

What changes were proposed in this pull request?
Refine this doc since:

It didn't mention our cluster default RPC type is  NETTY
If the user use the ratis shell with GRPC but didn't know the ratis cluster is NETTY, the error is not clear and hard to debug.

Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

ping @pan3793

Thanks, merged to main/0.3


Filter by labels/annotations

Currently, all objects are watched (either globally or by namespace, see #32), and all objects are handled. This is a normal case for the operator that "owns" the handled objects.
For the cases when an operator spies on the objects tat it does not "own", such as pods (#30), or the log (#46 ), it should be able to filter out all objects definitely not in the scope of interest.
The easiest way is by labels, as it is supported by the Kubernetes API, and can be put into a query to be performed server-side. Also, filtering by annotations is probably possible — via the field-selectors.
Example usage:
import kopf

@kopf.on.event('', 'v1', 'pods', labels={'model': None, 'model-id': '123abc')
def model_pod_changed(**kwargs):
    pass

The same is for create/update/delete/field handlers, and, when implemented, for the event & log handlers.

Additionally, the label filtering should be accepted on the command line (same semantics as kubectl):
kopf run handlers.py -l experiment=expr1

That can be useful for development and debugging purposes, when it is not desired to put the labels to the code permanently.

Hey @nolar,
I’d like to take this one on if possible.
I have a few questions about this:

You say that labels “can be put into a query to be performed server-side”, is that true? What happens if there are different filters for the same resource on different handlers, would we have to make 2 queries to the Kubernetes API? Im then thinking that this should then be handled in the code itself, do you agree? (similar for annotations).
What is the semantic around the {‘model’: None} label shown above; is that “the model key exists but with any value”, or “the model key exists with the value null”?
What should happen if labels are specified on the command line, and in the handler, is it a join of the two? Only the one in the handler, or command line wins?

Thanks!

@dlmiddlecote
Hm. Probably, that little note was done when only the command-line filtering was in mind, not per-handler — i.e. global. This makes no sense with per-handler filtering, of course. The logic of label-matching must be inside of Kopf then, not in the API queries and server-side.

{'model': None} meant that the model label should be there, but it does not matter with which value. An equivalent of kubectl get pod -l mylabel vs kubectl get pod -l mylabel=myvalue. I think, it is impossible to have a label with value null (never tried though).
Keep in mind: this syntax snippets are just suggestions. They can be varied as needed if some problematic details pop up. E.g., a special object kopf.ANY can be introduced instead of None for label values — the same way as in mock library (when matching the call() arguments).

It is an interesting question. Maybe, the command-line label filtering must be removed at all, leaving only the per-handler filtering.
Initially, I would say that from the user point of view, this must be an intersection of the labels (not the union) — i.e. AND, not OR — i.e. it must match both, or be ignored.
The command-line filtering can be used when restricting an operator's scope on deployment time (e.g. -l experiment=expr1), while the per-handler labels can be used to express the object relations (e.g. {"parent-run-id": ANY/None} for pods).
However, if started with both, this causes problems and confusion: according to this logic, that should be a pod with parent-run-id present AND restricted to experiment=expr1. However, there is no place where this experiment label is put on the created pod, unless a developer explicitly implemented that.
If we go that way, Kopf must also implicitly add the command-line-specified labels on all created children object (e.g. in kopf.adopt(), in the assumption that they all go through it). Which is not so thought-through territory, so I would recommend to avoid it for now.
Just per-handler filtering is enough. If the developers want it, they can define experiment as an env var, and add these labels themselves to the handler declarations as a global filter.

(reserved for @dlmiddlecote)

Released as kopf==0.20
Docs: https://kopf.readthedocs.io/en/latest/handlers/#filtering


Ensure the err is surfaced in e2e/integration tests to improve debuggability

What would you like to be cleaned:
We use this pattern in many places :
if err := k8sClient.Get(ctx, wlLookupKey, createdWorkload); err != nil {
return false
}

We prefer to replace it with something like:
gomega.Eventually(func(g gomega.Gomega) {
	g.Expect(k8sClient.Get(ctx, wlLookupKey, createdWorkload)).Should(gomega.Succeed())
	...
}, util.LongTimeout, util.Interval).Should(gomega.Succeed())

This is a follow up to the discussion here: https://github.com/kubernetes-sigs/kueue/pull/3284#discussion_r1814544537
Why is this needed:
To improve debuggability.

/assign
I already started working on it before.


Node S-ASO fails to add boolean variable to Server

Hello,
The node S-ASO fails to add boolean variable when inject with value "false" ( works with value "true" ).

Sorry if I made any mistake, I have just started learning about OPC-UA.
My code:
[{"id":"e9e4aee6.b1a5b","type":"OPCUA-IIoT-Server","z":"8258c812.8b1668","port":"55388","endpoint":"","acceptExternalCommands":true,"maxAllowedSessionNumber":"","maxConnectionsPerEndpoint":"","maxAllowedSubscriptionNumber":"","alternateHostname":"","name":"","showStatusActivities":true,"showErrors":true,"allowAnonymous":false,"isAuditing":false,"users":[{"name":"admin","password":"admin001"}],"x":557.072868347168,"y":88.29517269134521,"wires":[[]]},{"id":"cfe49f8a.79ef","type":"OPCUA-IIoT-Inject","z":"8258c812.8b1668","injectType":"inject","payload":"","payloadType":"date","topic":"","repeat":"","crontab":"","once":true,"startDelay":"10","name":"","addressSpaceItems":[],"x":145.07638549804688,"y":76.12153816223145,"wires":[["f939eb43.d420c8"]]},{"id":"f939eb43.d420c8","type":"OPCUA-IIoT-Server-ASO","z":"8258c812.8b1668","nodeId":"ns=0;s=Folder","browsename":"Folder","displayname":"Folder","objecttype":"FolderType","datatype":"","value":"","referenceNodeId":"ns=0;i=85","referencetype":"Organizes","name":"","x":293.0799102783203,"y":76.33334255218506,"wires":[["e9e4aee6.b1a5b","8fb4d458.0cccd8"]]},{"id":"8c4a900d.0e689","type":"OPCUA-IIoT-Inject","z":"8258c812.8b1668","injectType":"inject","payload":"false","payloadType":"bool","topic":"","repeat":"","crontab":"","once":true,"startDelay":"15","name":"","addressSpaceItems":[],"x":123.01736068725586,"y":116.01043701171875,"wires":[["2b48b9a3.1db426","ea37dd39.62793"]]},{"id":"2b48b9a3.1db426","type":"OPCUA-IIoT-Server-ASO","z":"8258c812.8b1668","nodeId":"ns=0;s=Var","browsename":"Var","displayname":"Var","objecttype":"BaseDataVariableType","datatype":"Boolean","value":"false","referenceNodeId":"ns=0;s=Folder","referencetype":"HasComponent","name":"","x":292.02090072631836,"y":122.22222232818604,"wires":[["e9e4aee6.b1a5b","8fb4d458.0cccd8"]]},{"id":"8fb4d458.0cccd8","type":"debug","z":"8258c812.8b1668","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":557.0833053588867,"y":144.1874942779541,"wires":[]},{"id":"ea37dd39.62793","type":"debug","z":"8258c812.8b1668","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":315.0173797607422,"y":167.01041221618652,"wires":[]}]
Thank you !

Hi,
Yes, you are right. The value check of the boolean accepting only type of boolean values in the new version. I have fixed it and will release a fix within a few days.
Thank you for that issue!
Klaus

[{"id":"25e800c9.07097","type":"tab","label":"Flow 1","disabled":false,"info":""},{"id":"c59c3609.9d6bf8","type":"OPCUA-IIoT-Inject","z":"25e800c9.07097","injectType":"inject","payload":"","payloadType":"date","topic":"","repeat":"","crontab":"","once":true,"startDelay":"10","name":"","addressSpaceItems":[],"x":248.0035171508789,"y":120.82636547088623,"wires":[["a71f890c.4b45f8"]]},{"id":"a71f890c.4b45f8","type":"OPCUA-IIoT-Server-ASO","z":"25e800c9.07097","nodeId":"ns=1;s=Folder","browsename":"Folder","displayname":"Folder","objecttype":"FolderType","datatype":"","value":"","referenceNodeId":"ns=0;i=85","referencetype":"Organizes","name":"","x":396.00704193115234,"y":121.03816986083984,"wires":[["c9479df9.848bf"]]},{"id":"df89825e.a0e44","type":"OPCUA-IIoT-Inject","z":"25e800c9.07097","injectType":"inject","payload":"false","payloadType":"bool","topic":"","repeat":"","crontab":"","once":true,"startDelay":"15","name":"","addressSpaceItems":[],"x":234.94448852539062,"y":183.71527099609375,"wires":[["b18bf3af.a5fef","7759f84b.b77e88"]]},{"id":"b18bf3af.a5fef","type":"OPCUA-IIoT-Server-ASO","z":"25e800c9.07097","nodeId":"ns=1;s=VarTrue","browsename":"VarTrue","displayname":"Var True","objecttype":"BaseDataVariableType","datatype":"Boolean","value":"","referenceNodeId":"ns=1;s=Folder","referencetype":"Organizes","name":"","x":400.947998046875,"y":202.92706298828125,"wires":[["c9479df9.848bf"]]},{"id":"c9479df9.848bf","type":"OPCUA-IIoT-Server","z":"25e800c9.07097","port":"55388","endpoint":"","acceptExternalCommands":true,"maxAllowedSessionNumber":"","maxConnectionsPerEndpoint":"","maxAllowedSubscriptionNumber":"","alternateHostname":"","name":"","showStatusActivities":false,"showErrors":false,"allowAnonymous":true,"isAuditing":false,"users":[],"publicCertificateFile":"","privateCertificateFile":"","x":605.5,"y":186.5,"wires":[["8802ef34.6b5408"]]},{"id":"7759f84b.b77e88","type":"OPCUA-IIoT-Server-ASO","z":"25e800c9.07097","nodeId":"ns=1;s=FloatTest","browsename":"FloatTest","displayname":"Float Test","objecttype":"BaseDataVariableType","datatype":"Float","value":"1000.0","referenceNodeId":"ns=1;s=Folder","referencetype":"Organizes","name":"","x":399,"y":159,"wires":[["c9479df9.848bf"]]},{"id":"8802ef34.6b5408","type":"debug","z":"25e800c9.07097","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","x":758.5,"y":185.5,"wires":[]},{"id":"b0f180ee.ce6858","type":"OPCUA-IIoT-Server-ASO","z":"25e800c9.07097","nodeId":"ns=1;s=VarFalse","browsename":"VarFalse","displayname":"Var False","objecttype":"BaseDataVariableType","datatype":"Boolean","value":"","referenceNodeId":"ns=1;s=Folder","referencetype":"Organizes","name":"","x":402,"y":249,"wires":[["c9479df9.848bf"]]},{"id":"4bb38682.312bb8","type":"OPCUA-IIoT-Inject","z":"25e800c9.07097","injectType":"inject","payload":"true","payloadType":"bool","topic":"","repeat":"","crontab":"","once":true,"startDelay":"15","name":"","addressSpaceItems":[],"x":241,"y":246,"wires":[["b0f180ee.ce6858"]]}]

fixed since v2.0.2+


About Page content

This checks a few boxes on #8.
namely: sponsorship and general contact emails, what is revuc, and MLH code of conduct
This is still a WIP but I wanted to get a pull request going because I need to stop for now. Feel free to add and edit @noahbass @domfarolino
Some of the content is ripped from the old site, some I rewrote. I definitely am going to revisit the middle paragraph.
DON'T MERGE YET

I'm happy with the content now. Please review @noahbass
@domfarolino @noahbass It certainly doesn't look good though. It needs styled or images or something. It's just a wall of text right now

I'm good with this @noahbass wanna approve?

I'm sitting at my computer. I'll take a look at @noahbass 's notes and update @domfarolino

LGTM


Error when trying to minify

When I try to minify a file, I get the following error. Do I need to install Java in order to use this plugin? Thanks! :)
Command failed: C:\Windows\system32\cmd.exe /s /c "java -server -XX:+TieredCompilation -jar -Xss2048k "C:\Users\rdebe_000.atom\packages\atom-minify\node_modules\node-minify\lib/google_closure_compiler-v20130411.jar" --js="C:\Users\rdebe_000\Documents\Projects\flexMenu\flexmenu.js" --language_in=ECMASCRIPT3 --js_output_file="C:\Users\rdebe_000\Documents\Projects\flexMenu\flexmenu.min.js" "
'java' is not recognized as an internal or external command,
operable program or batch file.

Hey! Yes, you need to install Java for YUI (CSS and JS compressor) and Google Closure Compiler.
I will update the documentation soon, but before I rewrite the complete package. About 80% is finished.

With version 0.2 I included a Java-check when using YUI oder GCC. If Java is not present, you see an error message.
PS: You can use UglifyJS2 as Javascript minifier, so you don't need to install Java.

What is the right Java (JRE/JDK/...) to install?

JRE should do it.  I've installed Java 8 Update 121.


Created metadata write group.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@93494d7). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage        ?   90.67%
=======================================
  Files           ?        4
  Lines           ?      429
  Branches        ?        0
=======================================
  Hits            ?      389
  Misses          ?       40
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CSS variables should bind to :host instead of :root (discussion?)

Bootstrap sets CSS variables on the :root element (see here).
This can cause issues when using shadow root and loading bootstrap inside the shadow document. As CSS variables on :root inside the shadow document are silently thrown away. This creates some broken styling (like text-*, which uses CSS variables since 5.1.0).
Reproduced on codepen: https://codepen.io/hugo-vrijswijk/pen/wvdEbyb?editors=1010
Here, Bootstrap CSS is loaded inside the shadow root. The p next to it has access to all bootstrap styling, except CSS variables. fw-bold works as it doesn't use any variables. The text-primary doesn't work because --bs-primary-rgb doesn't exist inside the shadow root.
Workaround: for the text-* issue, reverting to 5.0.2 works. Or, when building the SCSS manually, copy-pasting _root.scss and replacing it with :host also does the trick. Loading bootstrap outside any shadow roots also works, but is not an option in my case.
Browser: Firefox 90 & Chrome 92
OS: Windows 10

I don't think we'll be making this change in v5, and given v6 is likely a ways away, going to close out. We'll be revisiting all issues labeled v6 when the time is right :).


Fix eval with result and variable

OFunctionCall:isEarlyCalculate - if eval function, check if string
contains the varName.
Let expression step: save the result in the context (where it will be
taken again in the next row)
isEarlyCalculate: also get the variable name the result is put in.

resolves #9240
Notes:

I've looked and tested what I can, but I'm not familiar enough with the area of the code changes, so a thorough review should be done to verify this code is valid in all cases

Codecov Report

Merging #9269 into develop will decrease coverage by 0.01%.
The diff coverage is 19.35%.

@@              Coverage Diff              @@
##             develop    #9269      +/-   ##
=============================================
- Coverage      52.88%   52.87%   -0.02%
+ Complexity     36100    36082      -18
=============================================
  Files           2511     2511
  Lines         194662   194671       +9
  Branches       34844    34846       +2
=============================================
- Hits          102951   102930      -21
- Misses         76804    76826      +22
- Partials       14907    14915       +8

Impacted Files
Coverage Δ
Complexity Δ

...ent/core/sql/executor/OSelectExecutionPlanner.java
64.55% <0.00%> (ø)
396.00 <0.00> (ø)

...orient/core/sql/parser/OArrayConcatExpression.java
20.00% <0.00%> (ø)
9.00 <0.00> (ø)

...logies/orient/core/sql/parser/OBaseExpression.java
59.34% <0.00%> (ø)
95.00 <0.00> (ø)

...chnologies/orient/core/sql/parser/OCollection.java
57.14% <0.00%> (ø)
26.00 <0.00> (ø)

...nologies/orient/core/sql/parser/OFunctionCall.java
50.98% <0.00%> (-1.66%)
50.00 <0.00> (ø)

...chnologies/orient/core/sql/parser/OIdentifier.java
55.88% <ø> (ø)
19.00 <0.00> (ø)

...s/orient/core/sql/parser/OLevelZeroIdentifier.java
42.36% <0.00%> (ø)
48.00 <3.00> (ø)

...orient/core/sql/parser/OParenthesisExpression.java
36.97% <0.00%> (ø)
22.00 <2.00> (ø)

...gies/orient/core/sql/parser/OSuffixIdentifier.java
34.83% <0.00%> (ø)
52.00 <2.00> (ø)

...hnologies/orient/core/sql/parser/OWhereClause.java
30.61% <0.00%> (ø)
23.00 <0.00> (ø)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e964c...5fbb8ff. Read the comment docs.

hi @matanshukry,
This look ok, anyway there is no test case that prove the case, could you add one?
Bye

@tglman .. It's been 4 months.
I'm afraid I don't have time for this.

@luigidellaquila WDYT?

@luigidellaquila WDYT?

Closing this PR because it is out of date. If you are still interested to provide contributions please open a new one which is based on to date sources for develop the branch.


esp_check.h: No such file or directory

Trying to build this library always fails with this error, even with just the Arduino IDE and your example with the target ESP32 version 1.0.6

Looks to be platform version issue, updating to latest resolves the issue


Stdlib cannot contain directories

Hello!
It seems that if standard library contains directories (like current Diem library does: doc/), the language server bails out with EISDIR, since it tries to read that directory as a regular file.

Hello @villesundell
Thank you for bug report.
We are looking into issue, and we would try to fix it asap.

Hello @villesundell
We found issue, it's not in language-server unfortunately, bug happens in Move IDE.
We need little more time to fix, but we will do it asap.

Hey @villesundell
We published new VSCode extension, there is fixed issue.
You can download by link - https://marketplace.visualstudio.com/items?itemName=PontemNetwork.move-language
We will support Move language extension in the future, active development starting since next week.

Hello @borispovod !
Thank you very much for the fix, and also thank you supporting it in the future :)


ImportError: dlopen(/usr/local/bin/_jpype.so, 2): Symbol not found: _PyCObject_Type

Hi Guys,
I am starting to migrate code from python 2.7 to python 3.7 and today, trying to use JPype, I got the following error. I am on MacOS Mojave 10.14.2 and installed Jpype through pip --> pip install jpype1
Not sure how to fix this one:
Traceback (most recent call last):
  File "pachifer.py", line 4, in <module>
    import jpype
  File "/usr/local/bin/jpype/__init__.py", line 17, in <module>
    from ._jpackage import *
  File "/usr/local/bin/jpype/_jpackage.py", line 18, in <module>
    import _jpype
ImportError: dlopen(/usr/local/bin/_jpype.so, 2): Symbol not found: _PyCObject_Type
  Referenced from: /usr/local/bin/_jpype.so
  Expected in: flat namespace
 in /usr/local/bin/_jpype.so

Thank you for your help!

Fixed my own issue by uninstalling with pip2.7 and installing with pip3. 💃


Fix chunckedLoading LatLngBounds.intersects()

This PR fixes #743. We use Leaflet.markercluser with chunckedLoading in production and have seen issues similar to the ones that are reported in #743.
We applied this fix over two months ago and we haven't seen the issue again eversince. Also see my comment in #743, why this fixes the issue.

Can we have a test case that reproduces this too please?
See the spec dir.
If that's a bit tough, then at least an example in example/old-bugs.
Thanks!

The problem with tests is that they fail locally similar to Travis, so I cannot really write a test without testing it :).
I created an example.
With https://github.com/Leaflet/Leaflet.markercluster/pull/891/commits/c7932f6e3148d2fc830cd7b65bd08cfa7f942afa you are able to reproduce the bug. With https://github.com/Leaflet/Leaflet.markercluster/pull/891/commits/bc40326a4471bffe82ec2239a5a7f9f69807386e it's fixed.
It is a bit hard to reproduce, you need to zoom out before the cluster is fully loaded in order to trigger the removeLayers before the chunckedLoading is done. It is important to do this during the zoom.

I've fixed the tests, please create a test instead of the example if possible!

I've fixed the tests, please create a test instead of the example if possible!

Awesome work!
I created a test and showed that it failed and that the code change fixed the failure.
I am not sure how many markers are needed in order to provoke this issue. I settled for 1000, but I think it might be possible to further reduce it.

Great thanks!


Edge browser assignment count can be out of sync when a paper is desk-rejected/withdrawn

the assignment count shown at the bottom right corner of a profile entity is the count of assignment edges
so if some assigned papers are desk-rejected/withdrawn, the count will be out of sync with actual assignments
discussed this in the meeting and decided to remove edges when a paper is desk-rejected/withdrawn in the process function

Another solution to this is that the edge browser loads the Blind_Submission, Desk_Rejected_Submissions and Withdrawn_Submissions.
I'm not sure about that I said yesterday, deleting edges could loose track of the assigned reviewers/acs.

what should we do here?
should we delete the assignment edges? or ask the edge browser to load the desk rejected and withdrawn submissions?

Let's try to delete the proposed_assignment and assignment edges when the paper is withdrawn o desk rejected. To delete the edges, you can use the following call:
edges = client.delete_edges(invitation='NeurIPS.cc/2022/Conference/Reviewers/-/Proposed_Assignment', head=forum_note.id, soft_delete=True)

Should we restore edges when desk-reject/withdraw is undo?

Should we restore edges when desk-reject/withdraw is undo?

Yes!


Fix getpeers RPC not matching maxpeers

What current issue(s) does this address, or what feature is it adding?
Fix #678
How did you solve this problem?
if a peer disconnects or loses connection for whatever reason, then also remove it from the ADDRS list, on top of the Peers list.
How did you make sure your solution works?
wrote a test pre-fix, failed, fix, works
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

[X] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.2%) to 82.251% when pulling a1f93efb142edd019822fb4e284cefcd97e56b60 on ixje:getpeers_maxpeers into fd5e1d928cd3860839f93b7a9c757779e1b82ada on CityOfZion:development.

Good work! I was just sitting down to take a look at this lol.

Unfortunately this introduces a new problem. Peers with lost connection are now not reconnecting anymore, as they would have when calling PeerCheckLoop. This is because PeerCheckLoop is comparing self.Peers with self.ADDRS and when the peer with the lost connection is removed from both, then it will not reconnect anymore. This is an issue when you are using a fixed set of peers. When the last peer disconnects, the synchonization stops completely.

reverted in #693


Wrap option

This pull request adds the wrap option (default is true). If wrap is set to false, angular-carousel won't loop back to the start if it hits the last index (and vice versa)

Hey, thanks for the contribution !
Isn't wrap the same as allow-loop ?

I just had a look at the code, I think wrap works a bit differently (for example, it will stop the looping even on things like auto slide). Allow loop only appears to work in regards to controls
I think that wrap will work the same way that auto loop does if you do happen to have controls


[Bug Report] select error warning is not clear

Element UI version
1.2.9
OS/Browsers version
所有
Vue version
2.2.6
Reproduction Link
https://jsfiddle.net/b6mg7kL6/
Steps to reproduce
1.open the console
2.run the code again
3.there will be some errors "Cannot read property 'indexOf' of undefined"
4.remove the multiple attribute from the select tag
5.run again
6.errors will not occur
What is Expected?
錯誤的原因是沒有寫v-model在select中，但是提示不明確
https://github.com/ElemeFE/element/blob/b9e3e7faefd296a2be92b73d512cdba1fe71da33/packages/select/src/option.vue#L70
這行代碼直接去取值，沒有做判斷和校驗
What is actually happening?
nothing

Set the value prop required in #4423 .


DPL-478 - As a Developer I need an API endpoint to allow users to upload a QC results spreadsheet

User story
As a Developer I need an API endpoint to allow users to upload a qc results spreadsheet
Who are the primary contacts for this story
Steve
Who is the nominated tester for UAT
This can be done within PSD. UAT would need to ensure that it still works with the front end
Acceptance criteria
To be considered successful the solution must allow:

[x] Addition of status column to the qc results table. Decision on the QC outcome (free text field)
[x] Addition of decision made by column to the qc results table to allow reporting of who made the status decision e.g Long Read or ToL so that decisions can be made independently by various stakeholders
[ ] An agreed csv format
[ ] The creation of a create only JSON API compliant endpoint which will accept a csv
[ ] A model which will be a record of the csvs uploaded. Do we need to save the raw data?
[ ] An associated factory which will handle the csv data and transform it into qc results
[ ] Validation to ensure that the qc results are correct
[ ] JSON API resource which will provide feedback on success or provide errors
[ ] An agreed message format to send the qc results to the warehouse
[ ] A handler to send the message to the warehouse
[ ] modification of qc type column so that it can recognise different label (OPTIONAL - to decide)

Dependencies

sanger/unified_warehouse#397
sanger/traction-ui#885

References
This story has a non-blocking relationship with:

sanger/traction-ui#855

Additional context

The above story is the originator but has been split out
We will need the agreed csv format before progressing
It is possible to split this story into sub stories e.g. creating the message structure

As per meeting with Hermione and Lucy on 22/09:

They would like the status to be recorded and for the team who have made the decision to be recorded so decisions can be made independently.

Lucid chart diagram to show how the qc results are recorded and stored.
https://lucid.app/lucidchart/62e931d9-5afc-40db-a885-533196afb88a/edit?viewport_loc=285%2C-55%2C2549%2C1546%2C0_0&invitationId=inv_623f65cd-4e79-41d8-bd80-e367445d3ab8#

Comparison of system column names and extraction headings
https://docs.google.com/spreadsheets/d/103tq5LMt92PepzBF-J4TepuuILFXsPr3lOYpysz9yJI/edit?usp=sharing

Questions

[ ] The CSV uploaded to the UI, will that include the top line of groupings?
[ ] Are all the Green columns wanting to be stored in Traction?
[ ] For each mapping, could we confirm if they match to existing field in rake task

Always have LR decision, sometimes have TOL
Done need to store Femto dilution
Herminore to add system field name for Femto Frag Size
Herminore to look into headers can be unique


Maven?

This library looks pretty cool but is not in Maven?

Thank you for the kind words!
It is not in Maven because I don't feel it is a standalone enough of a component to be a Maven artifact.  In my experience, the frameworks like this require various customization per customer requirements, a process that often requires modification of the base classes.  It's probably easier simply copy src/ files to your project.
Having said that, I would certainly consider publishing a Maven artifact in the future.


stream.stream() does not advance the stream

According to the docs, calling stream.stream() should advance the stream so that the box event fires again if there are more boxes. This does not happen.
Below is the code I would expect to work, but it only ever emits the first box. I've validated that the stream returned from stream.stream() does emit an end event, so that's not the issue. Also, it does call the _kick function, but the problem is that _pending isn't 0. I just can't figure out why - could be an off-by-one error.
var fs = require('fs')
var mp4 = require('mp4-stream')

var stream = mp4.decode()

stream.on('box', function (headers) {
  console.log(headers.type)
  stream.stream().resume()
})

fs.createReadStream('./test.m4v').pipe(stream)

I have similar issue.

I have similar issue.


found an offline zkCluster, zkAddr is <IP_ADDRESS>:2181

Service suddenly interrupted, restart service (saturn-console-2.0.7.jar) failed.
[2017-09-05 11:06:15.917] [ERROR] [main] [c.v.s.j.c.service.impl.RegistryCenterServiceImpl] >>> found an offline zkCluster, zkAddr is <IP_ADDRESS>:2181
[2017-09-05 11:06:16.174] [ERROR] [main] [com.alibaba.druid.pool.DruidAbstractDataSource] >>> maxIdle is deprecated
[2017-09-05 11:06:16.221] [ERROR] [main] [com.alibaba.druid.pool.DruidDataSource] >>> testOnBorrow is true, validationQuery not set
[2017-09-05 14:04:07.202] [ERROR] [http-nio-9088-exec-7] [c.v.s.j.c.service.impl.RegistryCenterServiceImpl] >>> found an offline zkCluster, zkAddr is <IP_ADDRESS>:2181

I saw in the log ZK failed to start, but did not find it for what reason failed to start.

Because ZK did not start the reason, has been processed.


Support Sniffer-only mode in esp-wifi

Rationale: esp_wifi_80211_tx has a lot of restrictions if the device has a Wi-Fi connection, per https://docs.espressif.com/projects/esp-idf/en/stable/esp32s3/api-guides/wifi.html.
Currently the sniffer can only be enabled after AP/STA interface is already configured. It would be better if a dedicated sniffer mode can be supported.
CC @Frostie314159

Is this actually possible with the available wifi blobs right now?

With the current blobs no. For various reasons, they require an interface to be active.
I did however manage to create a PoC without the blobs, but it's pretty hacky.

Thanks for clarifying! I figured this might be the case. For many reasons we'll probably use the blobs here in esp-wifi for the foreseeable future so I'll close this issue for now. I'd love to see this work out in a 3rd party crate. FYI we just created https://github.com/esp-rs/esp-hal-community to home crates that don't quite belong here, but are also related.