(WIP) Record and restore scroll positions

WORK IN PROGRESS, DO NOT MERGE
This PR is a work-in-progress bringing scroll position save and restore to the 1.0 branch.

@mjackson @ryanflorence
I would like your attention here before I proceed with writing tests for this.
Michael suggested me to implement behaviors as components and I really liked this idea.
Here's how scrolling works here:

Histories descending from DOMHistory should call recordScrollPosition() on their push actions (we might actually be able to also call it for pop action in BrowserHistory to preserve Forward button position; we removed Forward restoration in previous versions because it didn't behave consistently in HashLocation, but now we can support them separately).

Custom histories may override getScrollPosition() (this would fix #1112).

createRouter now accepts a second argument: behavior. Here's where it gets interesting. behavior must be a React class. By default it is BrowserScrollBehavior but you can also supply react-router/ScrollToTopBehavior (not exported by default so you don't drag it if you don't use it). People can also implement their own behaviors.

Now what's a behavior? It's a React class that Router wraps its children into. It receives router state as props (and can do custom stuff in response to it), and the router's matched children as regular children. It may decide to do some post processing on them, or it may just hook into componentDidUpdate to update scroll position.
Here's how built-in behaviors work:
createScrollBehavior.js
var React = require('react');
var PropTypes = require('./PropTypes');

function createScrollBehavior(applyScrollPosition) {
  class ScrollBehavior extends React.Component {
    static propTypes = {
      location: PropTypes.location,
      children: React.PropTypes.element.isRequired
    }

    componentDidUpdate(prevProps) {
      var prevLocation = prevProps.location;
      var location = this.props.location;

      if (prevLocation.path === location.path)
        return;

      applyScrollPosition(location.scrollPosition);
    }

    render() {
      return React.Children.only(this.props.children);
    }
  }

  return ScrollBehavior;
}

module.exports = createScrollBehavior;

BrowserScrollBehavior
var createScrollBehavior = require('./createScrollBehavior');

function restoreScrollPosition(scrollPosition) {
  if (scrollPosition) {
    window.scrollTo(scrollPosition.x, scrollPosition.y);
  } else {
    window.scrollTo(0, 0);
  }
}

module.exports = createScrollBehavior(restoreScrollPosition);

ScrollToTopBehavior
var createScrollBehavior = require('./createScrollBehavior');

function scrollToTop() {
  window.scrollTo(0, 0);
}

module.exports = createScrollBehavior(scrollToTop);

User can also create custom behaviors for scrolling (#1112) or maybe something else.
User may also compose behaviors freely as they're just React classes.

first glance, this is awesome.

This is currently missing ignoreScrollBehavior but that too, should be possible, by introspecting the route info passed by the Router to the behaviors.

Interesting. I really like this approach a lot. I wonder if we could do createHistory like this as well...

All right, I added ignoreScrollBehavior back. If the rest is fine, I can write tests tomorrow.

By the way, we're going to need a separate index.umd.js that exports all histories and scroll behaviors for the UMD build.

I wonder if @ryanflorence can also do the async props via a similar approach.

If we do everything like this – as components that just take router props and pass them down the chain – we can have a "middleware" API that anyone can build stuff on.

Personally I'd prefer createRouter to stay continue taking only a single argument. How about putting the behavior on the root route like <Route behavior={Behavior} />?

Yes, I'm not super happy about it either.
In fact the guys had an epiphany about componentization that I'm sure they'll share soon.

Superseded by c5966be71e54a83029c6f31f22102519202dc724 and 663a97e242a284c77f70e3f406f1e50a8fdb7dcd.


NTLM Auth

Hi!
How to change default SoapClient to my own child class?
I have faced issue with NTLM authentication (described here).
Just need to implement method setClient()
Thanks in advance!

Made this availible in version 0.3.*.
$service->client($customClient)

Hope it will help, if you'r having other issues please let me know.


Dealing with operator IN, strange behavior

Hi there.
I have simple model like
class Post
  include Dynamoid::Document

  field :text
  field :post_type
  field :user_id

  range :posted_at, :datetime

  global_secondary_index hash_key: :user_id, range_key: :posted_at, projected_attributes: :all
end

I need to solve two simple problems:

Get all posts for one user like: Post.where(user_id: 1).scan_index_forward(false)
Get all posts for multiple users like:
Post.where('user_id.in': [1,2,3,4,5]).scan_index_forward(false)

...In the near future I will add pagination and filtering via post_type.
The firstone works well.
But, when I use the secondone (with operator in), i'm getting error Not indexed attributes: :user_id.in and the ordering didn't work at all.
The ordering (scan_index_forward) by posted_at in both cases is very important.
Where did i miss? Thnks.
Regards.

Hmm, good question.

But, when I use the secondone (with operator in), i'm getting error Not indexed attributes: :user_id.in

Looks like it's just a warning, not an error.

and the ordering didn't work at all

Yeah. Again, looks like it's completely correct behavior. In DynamoDB sorting works only in Query API call, but   Query requires equality condition for partition/hash key, e.g. user_id: 'a'. Condition 'user_id.in': [1,2,3,4,5] is only supported by Scan API call which doesn't support sorting.
So you can use sorting only with conditions like Post.where(user_id: 1).

Hi @andrykonchin. So, no chance for me, am i right?
Thanks for reply.


gtk_settings_get_default() returns nullptr

Hello again, @wangwenx190 !
I'm using Debian based Linux (not Ubuntu). Following your instructions in the readme I have installed the GTK3 development package (libgtk-3-dev:amd64 version 3.24.30), before building framelesshelper (tag 2.2.1). And it built without any related errors.
Now I'm trying to run a debug configuration of application linked to your lib. However Q_ASSERT triggered at the very beginning in the template function gtkSetting (src/core/utils_linux.cpp), because gtk_settings_get_default() returns nullptr.
Searching the GTK documentation I found that gtk_init (https://docs.gtk.org/gtk3/func.init.html) should be called first. This helped, but now I'm getting warning on start: "Gtk-WARNING **: Theme parsing error: gtk.css:3877:13: Not using units is deprecated. Assuming 'px'."
I'm not familiar with GTK, could you please explain, what I'm doing wrong?

Maybe you can just ignore the warning message from GTK. However, it should not be necessary to call gtk_init() manually, it's strange. Can you try the latest code from the main branch instead? Do you still have this issue?

It would be great if you could call gtk_init() in the FramelessHelper::Core::initialize() function for example. Is it possible?

I'm not quite sure about this, because I'm not very familiar with GTK either. You can try this in your own fork to see if it can work reliably. If so, we can merge it to the main repository. What do you think?

Take a look please

Thanks! I've left a comment there.


KOGITO-6145 DMN codegen heuristic for DMN Editor encoding

https://issues.redhat.com/browse/KOGITO-6145

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The (build) kogito-apps check has failed. Please check the logs.

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

The (build) kogito-runtimes check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) optaweb-employee-rostering check has failed. Please check the logs.

The (build) optaplanner-quickstarts check has failed. Please check the logs.

The (build) optaplanner check has failed. Please check the logs.

Before. On Win10 with default encoding for EMEA (non-UTF8) breaks with:

Before. On Mac OSX (EMEA located) the problem does not replicate as by default UTF8 is accounted.

After.  On Win10 with default encoding for EMEA (non-UTF8) the heuristic kicks-in and the file is explicitly read by Reader with UTF8 encoding:

Jenkins retest this

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

The (build) optaplanner-quickstarts check has failed. Please check the logs.

The (build) kogito-runtimes check has failed. Please check the logs.

The (build) kogito-apps check has failed. Please check the logs.

The (build) optaplanner check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) optaweb-employee-rostering check has failed. Please check the logs.

Jenkins issue not related
java.nio.file.NoSuchFileException: /home/jenkins/workspace/KIE/kogito/main/pullrequest/kogito-runtimes.tests.kogito-runtimes/.ci/actions/build-chain/action.yml
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
	at java.nio.file.Files.newInputStream(Files.java:152)
	at hudson.FilePath.newInputStreamDenyingSymlinkAsNeeded(FilePath.java:2113)
	at hudson.FilePath$Read.invoke(FilePath.java:2195)
	at hudson.FilePath$Read.invoke(FilePath.java:2182)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3317)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
Caused: java.io.IOException

Jenkins retest

Jenkins retest this

The (build) kogito-runtimes check has failed. Please check the logs.

The (build) kogito-apps check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

the Jenkins -examples failure likely unrelated since the analogous GHA is passing

(it also pertains to unrelated tests)


Overuse of inline

I've noticed many functions are inline with noinline lambda argument. (like here for instance)
This is a bit a shame because we get the bad* effects of inline without getting any benefit as the lambda will not be inlined.
The bad effects of inline functions are:

Harder to debug since the function doesn't exist at runtime.
Internal implementation is exposed.
Any change in the implementation of the function breaks binary compatibility.

Except when done for good reasons, inline function should generally be avoided in public API. And in this case, there is no benefit if the lambda is marked noinline.

I should probably mention this in contribution guideline: this library follows this guideline in terms of deciding which extensions should be inline. If you find something that violates that guideline in current branch, create a PR and we'll talk more about it.

Where you referring to the comment of Jake Wharton and the rule is "function which are actually only aliases existing public APIs should be inlined"?
I'd be fine with this guideline indeed.

Yes, that should be the basis of decision whether or not to inline.


Remove jimp dependency

I think jimp was a dependency of component-image, which we no longer use

Codecov Report

Merging #1101 (0a6ddd1) into main (6adbd92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   99.06%   99.06%
=======================================
  Files         112      112
  Lines         860      860
  Branches      233      233
=======================================
  Hits          852      852
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adbd92...0a6ddd1. Read the comment docs.


Compare how Namespace performs compared to BuildJet for our repository

The big problem that we're facing with BuildJet is the limited amount of storage. Namespace, on the other hand, offers much larger cache volumes which would easily fit our entire target/ directory.
I should note that Namespace does not support the actions/cache caching APIs though, which means we wouldn't be able to use swatinem/rust-cache@v2.

We switched to Namespace and we're pretty happy for now.


Illegal dynamic reference: State in dynamic input task

steps
Compile this code under sbt 1.0.0
private def testState: Def.Initialize[InputTask[Unit]] =
    Def.inputTaskDyn {
      someFunc(someParser.parsed, state.value)
    }

problem
It throws Illegal dynamic reference: State, but under 0.13.16 sbt everything is alright
expectation
Normal compilation as in sbt 0.13.16
sbt version: 1.0.0

Thanks @vovapolu, I'll see if I can identify how this regressed.

@vovapolu this is the bug that's holding back some of the ensime-extras tasks like ensimeCompileOnly, right?
If that is the case, @jvican if you could promote this one it would be awesome. I felt like using ensimeCompileOnly today and remembered it was missing :sob:

@fommil ensimeCompileOnly absence is related to huge changes in compiler api in sbt. This issue affects on ensimeTestOnly task.

do we need changes from sbt to allow that?

Allow what? :) We need to rewrite ensimeCompileOnly task for the new api, sbt has already changed this api :) ensimeTestOnly is almost blocked by this issue (I couldn't find a hack to make it work).

Ah ok so the sbt 1.0 is powerful enough to let us to that.

@fommil I cannot promote this one since I'm not hacking on sbt/sbt much these days... Too many projects 😞. What I can provide is a little bit of feedback.
I think that this issue is pretty common when you start using dynamic tasks sparingly, and IMO the "dynamic detection" can be improved. Right now, I believe we're just checking if there's a Select tree (or something that it's not an Ident) within the non-dynamic body, and fail if that's the case. It seems that this check is not good enough, I've hit this limitation before in https://github.com/sbt/sbt/issues/3110. Without looking into the issue, I cannot confidently say this detection is flawed. What I've observed is that it usually fails when the typechecker has applied an implicit conversion (and hence a Select tree), and also in other cases I don't have an hypothesis for.
I think that a solution worth looking into is to whitelist some sbt APIs that we know are safe. For example, selecting a name from an object like sbt.State and sbt.Def (though order of initialization can change here, I wouldn't expect that to affect sbt evaluation semantics).
For now, you can try the workaround I explain in https://github.com/sbt/sbt/issues/3110 and see if ensimeTestOnly compiles.

State is a Task, it looks like it's not possible to use any Task in parsed.

The error is unrelated to state being a task, the same error happens for settings
// OK, works as expected
run := Def.inputTask {
  val args = sbt.complete.Parsers.spaceDelimited(scalaVersion.value).parsed
  println(args)
}.evaluated

// Error
run := Def.inputTaskDyn {
  val args = sbt.complete.Parsers.spaceDelimited(scalaVersion.value).parsed
                                                 ^^^^^^^^^^^^^^^^^^
                                                 Illegal Dynamic reference
  Def.task(println(args))
}.evaluated

This issue is a blocker for https://github.com/scalacenter/scalafix/issues/844 I would like scalafix <semantic rule> to depend compile.value while scalafix <syntactic rule> should run without compilation. In order to construct the parser I need access to a setting key scalafixDependencies: SettingKey[List[ModuleID]]

A workaround I'm using to read global settings from dynamic input tasks is to store them in mutable variables in the plugin object. I set the variable during initialize with
override def globalSettings = List(
  initialize := { myScalaVersion = scalaVersion.value }
)

The parser then accepts a scalaVersion: () => String instead of scalaVersion: String. This may not work for everybody and it would be great to avoid this hacky workaround.

Using directly the helpers that the macro code would emit if there was not false positive seems to work and to be portable across sbt 0.13.x and sbt 1.x
https://github.com/sbt/sbt/blob/b18140c14b1e5fa72e2709576aede414298c3f91/main-settings/src/main/scala/sbt/InputTask.scala#L93-L100
Example of replacing the workaround mentioned just above with that: https://github.com/scalacenter/sbt-scalafix/pull/126/commits/2ca68e4f38cc39d5a7cdd32658e69bcad9d5b6ca#diff-b6db8e3499369917214568aee2dd0960R168


Missing test coverage for encode_json for values smaller than 0x1f

What is the problem this feature will solve?
increases test coverage
What is the feature you are proposing to solve the problem?
I was investigating ada. I saw that you do 2 * c and was wondering if a bitshift makes a difference c << 1 but then I realized that if replace with just returning '0', then ctest --output-on-failure --test-dir build will pass all the tests. So there is missing test coverage.
I guess that the compiler will create the same bytecode for 2 * c and c << 1. But it would make sense to have test coverage.
What alternatives have you considered?
No response

Would you like to open a pull request for the missing test?

I have no clue where to put it :D

I have no clue where to put it :D

test/basic_tests.cpp works


ModuleNotFoundError: No module named 'tableasdk.HyperExtract'

Hey thanks for creating this library.
I just installed tableausdk(TableauSDK-10300.18.0510.1135) and ran its setup.py, then pip installed pandleau. But when running either import pandleau or from pandleau import *, I get this error:
>>> from pandleau import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/maxepstein/myproject/myenv/lib/python3.6/site-packages/pandleau/__init__.py", line 1, in <module>
    from . import pandleau
  File "/Users/maxepstein/myproject/myenv/lib/python3.6/site-packages/pandleau/pandleau.py", line 11, in <module>
    from tableausdk.HyperExtract import *
ModuleNotFoundError: No module named 'tableausdk.HyperExtract'

Navigating to my myproject/myenv/lib/python3.6/site-packages/tableausdk and running ls, I can confirm there's no HyperExtract module there.
Looking up this issue on Tableau help, I see ["Note: Use the Extract API 2.0 to create .hyper files for Tableau 2018.1 and later. Use the Tableau SDK to create .tde files for previous versions of Tableau."](https://onlinehelp.tableau.com/current/api/sdk/en-us/help.htm)
But Pandleau says it requires the Tableausdk and then exports .hyper files. Is there something I missed installing, or am I using this wrong? Thanks

Hi MaxPowerWasTaken,
Thanks for reaching out and bringing this to my attention!
Tableau updated their original tableausdk package with the new Extract API 2.0 package, which is similar to the original but a few changes were made - mainly, adding the .hyper extension and removing the .tde extension. I went ahead and updated the pandleau module to use the .hyper extension, but you can look back at old commits to see another version for .tde files (it's a little slower than the current version, however) in case you are using an older version of tableau.
The best way to install the updated tableausdk Python package is via the following link:
https://onlinehelp.tableau.com/current/api/extract_api/en-us/help.htm#Extract/extract_api_installing.htm%3FTocPath%3D_____3
Unfortunately, this doesn't appear to be overwriting the original tableausdk module (perhaps to give some users compatibility with .tde files), so you'll have to delete the file you've specified above,
myproject/myenv/lib/python3.6/site-packages/tableausdk
and replace it with the updated tableausdk module.
Let me know if this helps or if you have any other issues with pandleau. Thanks!

Awesome, thanks for the answer. Bummer to see at the link you provided that the Extract 2.0 API, "For Python, you must have Python 2.6 or 2.7 installed. (Python 3 is not supported.)"
Anyway, thanks again

Yeah, I don't know why Tableau chooses to use only Python 2 - I feel like adding compatibility with Python 3 would be a great update to their tableausdk module. Let me know if you have any other issues, thanks!


Issue with CMakeLists.txt during configuration step

Hi there, @weslleyspereira  and @langou! I just installed tlapack and got the example "geqr2" to work, but I had some hiccups in the installation process and I had to edit CMakeLists.txt to get things to work. Can one of you take a look below and let me know if you think those edits were avoidable?
Here's the full context of the configuration step:
(base) riley@borneophant:~/Documents/Research/tlapack/tlapack$ cmake -B build -D CMAKE_INSTALL_PREFIX=~/Documents/Reserch/tlapack/tlapack .
-- <T>LAPACK version 0.1.1
-- testBLAS not found. Trying to fetch from https://github.com/tlapack/testBLAS.git. It may take a while.
-- testBLAS version 0.1.2
-- Catch2 not found. Trying to fetch from https://github.com/catchorg/Catch2.git. It may take a while.
-- Using Catch2 from https://github.com/catchorg/Catch2.git.
-- Using testBLAS from https://github.com/tlapack/testBLAS.git.
CMake Error at CMakeLists.txt:197 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "ARCHIVE_OUTPUT_DIRECTORY" is not allowed.

CMake Error at CMakeLists.txt:197 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LIBRARY_OUTPUT_DIRECTORY" is not allowed.

-- Configuring incomplete, errors occurred!
See also "/home/riley/Documents/Research/tlapack/tlapack/build/CMakeFiles/CMakeOutput.log".

I really don't know what to make of that message. Grasping at straws, I just commented out these lines in CMakeLists.txt:
https://github.com/tlapack/tlapack/blob/ee39c930511b4f06545c691f5246338ff96646c2/CMakeLists.txt#L197-L200
It turns out, that worked!  I was able to finish the configuration step and execute the other commands
cmake --build build
cmake --build build --target install

without problems.

Hi @rileyjmurray. Thanks for noticing that! Your solution works, although it changes the place the libraries will be installed. Instead, I suggest we remove tlapack from the installable libs in this line:
https://github.com/tlapack/tlapack/blob/ee39c930511b4f06545c691f5246338ff96646c2/CMakeLists.txt#L34
Currently, tlapack is just an interface, not a physical library.
What do you think?

I just tried out that change, and it worked great! Thanks, @weslleyspereira!
I'll leave this issue open and you can close it when you make your proposed change.


tensorflow-1.10.0-cp35-none-linux_armv7l.whl is not a supported wheel on this platform. Storing debug log for failure in /root/.pip/pip.log

Hi,
This project is really interesting but some how i am struggling from last 2 days and getting this error every time.
tensorflow-1.10.0-cp35-none-linux_armv7l.whl is not a supported wheel on this platform.
Storing debug log for failure in /root/.pip/pip.log
My raspberry is running on version  "jessie desktop".
Please help me to resolve it.
Regards
Devraj

You can now install TensorFlow just by issuing these commands in the Pi terminal:
sudo apt-get install libatlas-base-dev
pip3 install tensorflow

Will you try that and see if it works?

i had the same problem as Devraj004. I tried your fix Edje but i get this
pi@raspberrypi:~/tf $ pip3 install tensorflow
Downloading/unpacking tensorflow
Could not find any downloads that satisfy the requirement tensorflow
Cleaning up...
No distributions at all found for tensorflow
Storing debug log for failure in /home/pi/.pip/pip.log
sudo apt install libatlas worked but the install tensorflow on the second line didnt

Well i found that the tensor flow for ARM has all the whl files for Python 3.5 and i was running python 3.4. I just upgraded the Pyhton to 3.5.2 and tf started installing.


two outlook windows, one on two different screens does not work both go to the same screen

Microsoft PowerToys version
0.84.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
Workspaces
Steps to reproduce
First, let me say thanks for a great new toy.   Appreciate everyone involved.
create a workspace with three screens.  Put outlook email on one screen and outlook calendar on another.
✔ Expected Behavior
for the outlook email window to be on one screen and the calendar window on the other as per the setup.
❌ Actual Behavior
both outlook windows appeared on the same screen.  I also get an error message from outlook saying that another version of outlook is already running but both windows do open up.   I suspect that there may need to be a delay in starting the windows.
Other Software
No response

@bradyguyc a delay in launch between the two instances does in fact fix the issue.
A simple but not so robust solution could be to add the ability for users to set a per-app delay when launching an application.

@bradyguyc a delay in launch between the two instances does in fact fix the issue.
A simple but not so robust solution could be to add the ability for users to set a per-app delay when launching an application.

I just encountered a similar use case for this, where I would want to open the main Steam window and then also the Steam Friends-window after by passing CLI-arguments. As of now they get placed in the exact same place and size.

@bradyguyc please retest with the new 0.87 PT version and if the issue persists send a /bugreport. Thanks!

Thanks for the follow up I appreciate your looking into this.  Unfortunately I moved away from the new utility and have been using displayfusion's product for awhile now.   It would take sometime to get back to how I was trying to use this new tool.
Thanks
Brady


Investigate Overlay Custom Colours

Allow the user to customize the colours of the overlay by allowing them to specify what M3 colour they want to apply to the overlay. Provide several options based on the current dynamic theme or app colours (if dynamic colours not available).

Add support to select from 3 colours.


Adds new plugin: statichit

This is a simple plugin (based off of the generator plugin) to
serve static content from a local filesystem. It shares some
of the same functionality as the healthchecks plugin,
but can be used in the remap context, making it reloadable.

Or use Transaction Box.

Cherry-picked to v9.0.x branch.


Primary and Secondary Replica SQL Server Error Logs

Hi All,
If at primary replica the business continues; then the SQL Server error log on secondary server is also synchronized with primary? Both Servers have different physical machines! In both case why and why not?
Does it should be part of this page as well ?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 154afa3b-d022-db3d-b118-ef4126a23ca0
Version Independent ID: 72b2496e-683d-c4f2-bc01-441d81f8383f
Content: SQL Server error log (availability groups) - SQL Server Always On
Content Source: docs/database-engine/availability-groups/windows/sql-server-error-log-always-on-availability-groups.md
Product: sql
Technology: high-availability
GitHub Login: @rothja
Microsoft Alias: jroth

@GITAhmad123 So sorry for the delay. So you're asking if the error log gets synchronized it will show the same physical machine in both logs? Or if it doesn't why not? Is that the correct question? Thank you!

@GITAhmad123 Thanks for reaching out. I'm not sure I have enough information to go on here, but apologies if I just misunderstood the initial description. I'm going to close this issue, but please feel free to add more details and I will reopen it to continue investigating. Thank you!


Symlink support for Windows

Removed the Windows symlink restriction and deprecated the method as it is natively supported.

sure, agree, lets remove this!


Tweak colors to be WCAG 2AA valid

Feel free to push here any further color tweaks. I check this on our docs page, but the highlighting colors mostly don't pass WCAG 2.0 AA so this makes it harder.
Also, not sure if this should be backported or not.
Preview: https://deploy-preview-29198--twbs-bootstrap.netlify.com/
TODO:

[x] darken links color - #0d6efd
[x] darken pink color - #d63384
[x] darken info color - #15819e
[x] darken success color - #24883e
[ ] breadcrumb

I added a small TODO. After this we should be mostly covered.

I split the doc-related fixes to #29208. I'll rebase this after the merge and see where we are at.

@patrickhlauke: any suggestions?

Maybe we should move forward with the blue and pink changes only since those are the least intrusive ones?

Maybe we should move forward with the blue and pink changes only since those are the least intrusive ones?

Yup

Alright, I cleaned up the patch. I don't think we should backport this, though, because it can be a breaking change for some people.
@mdo please confirm if you are OK with these 2 color changes. The difference isn't that big.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_0f8mv4nmzv/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


SWDEV-317716 - [catch2][dtest] Add test for hipDeviceGetUuid

Change-Id: Ic2940cd45cacc32212df7c76ee8f4ca5e7e3740c

Hi @mangupta @gargrahul, can this PR be closed, as #2614 is duplicate of this and it has the working test case.

Closing as per the last comment.


[openssl] Interrupt the build process when files conflict

https://github.com/microsoft/vcpkg/blob/0a16cad0072f9cc20045a49754ce5fef20c4b08f/ports/openssl-windows/portfile.cmake#L3-L7
This will make other ports that rely on it unable to find the files generated by openssl when they are building, thus hiding this issue.
Fixes #12443.

Thanks!


⚠ PrivateHD has degraded performance

In 5da3b49, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1901 ms

Resolved: PrivateHD performance has improved in bd9e6e5.


continue to do unit_remove if no WWID found

Signed-off-by: CaoBiao<EMAIL_ADDRESS>

test
1. attach 3 volumes
2. undedicate the FCP devices
3. before detach

4. detach 1st volume:
5. detach 2nd volume:
6. detch 3rd volume:


Cell cleanup: typos

Description:
Corrected some misspelled words in the documentation.
Reviewer(s):
@nskinkel

Coverage remained the same at 35.89% when pulling 21b286fc8d252743620cf83aa9ed475ae88ab1e0 on CivBase:clean_up_typos into 44441db07463583f47d7cc8887d22a0798d7b80d on nskinkel:master.

Thanks! merged.


Adding hegel project to build tooling

Description of changes:
Adding tinkerbell/hegel project to our build tooling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks pretty good to me.
Could you look at adding a updating section to the readme for this project? Check out one of the flux projects for an example. It would be good to get in the habit of adding these add we add new projects.

Thanks 👍 I have updated with a minimal README.

🥯 🎉


Next Timer, Next Alarm, Next Reminder sensors not being created

Describe the bug
The Next Timer, Next Alarm, and Next Reminder sensors are not being created for any of my Alexa devices. media_player devices are created for each and work correctly.
To Reproduce
Restart Home Assistant. Notice the lack of sensors.
Expected behavior
Each included Echo device should have corresponding Next Timer, Next Alarm, Next Reminder sensors.
Screenshots
N/A
System details

Home-assistant (version): 0.108.4
Hassio (Yes/No): NO
alexa_media  (version from const.py or HA startup):  2.8.3
alexapy (version from pip show alexapy or HA startup): 1.10.1

Logs
See attached.
home-assistant.log

Please make sure you are not excluding the sensors. include_device is a white list. exclude_device is a black list.
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Garage next Alarm: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Garage next Timer: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Garage next Reminder: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Kitchen next Alarm: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Kitchen next Timer: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Kitchen next Reminder: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Bedroom next Alarm: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Bedroom next Timer: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Bedroom next Reminder: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Living Room next Alarm: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Living Room next Timer: unavailable>
2020-06-05 07:33:03 DEBUG (MainThread) [custom_components.alexa_media.helpers] v*******n@g*******m: Excluding device: <Entity Living Room next Reminder: unavailable>

Duplicate of #745


[BUGS] Events page placeholders

Description

If you take a look at the Events page you will see that we have placeholders enabled for desktops too.
I want the placeholders only for mobile view.
I want Labels to be available for the Desktops !
Also can we center the Create button for the mobile and make it a bit larger too ?

Screenshots
Changes to be made :

Additional information
No response
🥦 Browser
Brave
👀 Have you checked for similar open issues?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue ?
No, someone else can work on it

@IAmTamal  assign the task  to me. I will get it done.

Hey @IAmTamal I would love to work on this, and will try to complete asap.
Can you assign me this task?

Go for it @devwithsubhrajit2002
@srijoy-paul , we are trying to give everyone a fair chance !

I think this issue is solved so we can close this issue.

I think this issue is solved so we can close this issue.

This issue was not created TBH


proposal: Provide mechanism for custom x509 verification in crypto/tls

Most typical SSL/TLS interactions warrant a standard x509 validation process involving verifying a chain of x509s against a pre-established set of root CAs.  However, there are a subset of applications where this is not the desired functionality.  APIs such as OpenSSL recognize this and provide a way to override the default behavior (e.g. SSL_CTX_set_cert_verify_callback).  crypto/tls seems to lack such a feature, instead opting to invoke x509.Verify() directly.  It would be helpful to provide conceptual equivalence, perhaps by allowing a Verify function to be set on the Config.

/cc @agl for thoughts.

What are the concrete use cases that Go's APIs make difficult?
We already support changing the root CAs with tls.Config.RootCAs.
The http Client already provides a DialTLS hook letting you do your own verification there.
The tls Config already provides InsecureSkipVerify to let it get out of the way and let you do your own verifications before using the connection.
I don't see how adding more mechanism enables anything new, and only serves to confuse the readers of documentation about the N different ways to do things.

Hi Brad,

RootCA approach: validating a self-signed certificate is generally different from the process of validating a chain of traditional PKI certs, and as far as I know, there is no value of tls.Config.RootCA that would allow the current validation routines to do the right thing.  I could try experimenting with this idea.

http Client approach: I am not familiar with the http subsystem to comment on whether this is a feasible suggestion.  However, I need raw sockets so it wouldn't help me if it could.

InsecureSkipVerify approach: It looks like I might be able to do as you suggest with tls.Conn -> ConnectionState -> PeerCertificates, but its not entirely clear how to get the tls.Conn from the tls.Dial which seems to return a net.Conn.  Any suggestions?

I figured out the deal with net.Conn vs tls.Conn, and verified that your suggestion does indeed work, as demonstrated here: https://gist.github.com/ghaskins/5f9758d7e8cb48bf1f7d
Thanks Brad!
-Greg


color conversion code wreeks of SDL

Compiler chokes on SDL verbage because we are not using Dword conversion nor are we using SDL subroutines to fetch the colormap from the current bpp used.
OpenGl reports back 32bit float data(always- which is where the SDL glitch is) and needs to be converted to current bpp byte-mode before we can use the data.
This will take a minute to solve. Current sheme uses SDL-ish RGBA record/struct. Windows stores this backwards in BE(big endian), not LE mode. (compiles 1/3 of the way into the main unit.)

fixed w comment: backport may be necessary- yet calling SDL for data we should be able to produce is bs.


Typing error with

Package Name: azure-keyvault-secrets
Package Version:
Operating System:
Python Version:

Describe the bug
Starting with this code:
from azure.keyvault.secrets.aio import SecretClient

async with SecretClient(
    vault_url=f"https://{key_vault_name}.vault.azure.net", credential=azure_credential
) as key_vault_client:
    search_key = (await key_vault_client.get_secret(search_secret_name)).value

Then running "python -m mypy", we get this typing error:
error: "AsyncKeyVaultClientBase" has no attribute "get_secret"  [attr-defined]
The error only happens when I use it as an async context manager.

@mccoyp Could you take a look?

Hi @pamelafox, sorry about the delay on this. It looks like this typing confusion comes from how we implement the __aenter__ method to make the client a context manager. Specifically, the method is implemented in the base client that SecretClient inherits from, and its return type is typed accordingly: https://github.com/Azure/azure-sdk-for-python/blob/c41c06e52679f2520010759dd7de8a4665eec597/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/async_client_base.py#L69
Because of this, within the async with block, mypy interprets the key_vault_client as an AsyncKeyVaultClientBase instead of a SecretClient -- hence, the error it raises. This also appears with the synchronous client, since it has an analogous implementation.
I'll open a PR to shift out these context manager methods to the user-facing clients to avoid this issue, per how other clients in the SDK handle this. Thank you for raising this issue!


[libsodium] Build error on x86-windows

Package<EMAIL_ADDRESS>Host Environment

Host: x64-windows
Compiler: MSVC 19.40.33808.0
vcpkg-tool version: 2024-08-01-fd884a0d390d12783076341bd43d77c3a6a15658
vcpkg-scripts version: ee2d2a100 2024-09-10 (2 days ago)

To Reproduce
vcpkg install
Failure logs
-- Downloading https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz -> jedisct1-libsodium-1.0.19.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from D:\git\vcpkg\vcpkg-bundle.json
[DEBUG] Failed to open: D:\git\vcpkg\vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Feature flag 'dependencygraph' unset
[DEBUG] Trying to hash D:\git\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.34624.part
[DEBUG] D:\git\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.34624.part has hash efeb4c0dc352993fc128974abb27e4be60521e85ce191c8c38a84168d4e7d7b1d2c26843250077dd21dadb13678bf56712375e74754eb02100b8cc418ebffb94
error: Missing jedisct1-libsodium-1.0.19.tar.gz and downloads are blocked by x-block-origin.
error: File does not have the expected hash:
url: https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz
File: D:\git\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.34624.part
Expected hash: 6094d7bf191ea3be85f2ddab76b71f1b9c69c786493db5b84d3c5d5a0237003377ddf6a8687a962ea651fe4a9369cf5ee1676ba0bae82690f5f7ef31a698efa9
Actual hash: efeb4c0dc352993fc128974abb27e4be60521e85ce191c8c38a84168d4e7d7b1d2c26843250077dd21dadb13678bf56712375e74754eb02100b8cc418ebffb94
[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(1030):
[DEBUG] Time in subprocesses: 0us
[DEBUG] Time in parsing JSON: 6us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 1234us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 967 ms (917312us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same `https://` prefix issue.

      3. Your proxy's remote server is out of service.

      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  C:/Users/stjohnson/AppData/Local/vcpkg/registries/git-trees/38de4073e90ae48d9d7bc68db71b850b5645f5ab/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:192 (include)

Additional context
vcpkg.json
{
  "name": "natstest",
  "version-string": "1.0.0",
  "dependencies": [
    "cnats"
  ]
}

@stewartjohnsonETC, The latest version of libsodium is 1.0.20#3, please use git pull get the latest version of vcpkg and try again.


doc: gcov: Added documentation for code coverage.

The documentation shows the steps to be followed for generating the
code coverage reports.
Signed-off-by: Adithya Baglody<EMAIL_ADDRESS>

Codecov Report

Merging #13242 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13242   +/-   ##
=======================================
  Coverage   48.75%   48.75%
=======================================
  Files         319      319
  Lines       46871    46871
  Branches    10835    10835
=======================================
  Hits        22850    22850
  Misses      19394    19394
  Partials     4627     4627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaae57...7b826c0. Read the comment docs.

@aescolar @dbkinder Thanks for the review. Please revisit.

@dbkinder please revisit the PR


User documents not downloading on PROD

Description
Two users have reached out because they are having issues downloading their PDFs (https://www.earthdata.nasa.gov/apt/documents/opera-dist-product-atbd/v1.0 and https://www.earthdata.nasa.gov/apt/documents/tempo-nitrogen-dioxide/v1.0).
Note: can add "/pdf-preview" to the end of the URL as a workaround for now.
Tasks:

[ ] Determine why these are not downloading
[ ] Determine and implement a solution (note, if this a pdf generation timing out issue, it will be addressed with #451)

Acceptance Criteria

[ ] PDFs are downloadable
[ ] Notify users

@wrynearson Created this ticket for tracking purposes.  You noted that you were able to download this one, but I still can't.

Thanks @bwbaker1. I just retried the first one, but I'm also not able to downloaded it. I must have been mistaken

cc @batpad @sunu @naomatheus

@wrynearson There are two versions of that document and both are named exactly the same.  One will download, but it's not the document that they are actively working on.  Not sure why they created two.

I believe we're ready for review on this. RE #701
cc @wrynearson @sunu

Hi @bwbaker1, this push to production fixed the Tempo doc, but we are still having issues with the OPERA document. We'll need to do more investigation with @naomatheus since the error logs are within MCP

^ I noticed that when testing yesterday. The good news is that the other documents I tested all downloaded very smoothly.

We have identified the issue that's causing the OPERA document export to fail and we're working on a fix


Made both CryptoTests_jtreg and CryptoTests targets vendor neutral

It is passing for all vendors, the differences lies in underlyng OS, not JDK

However, as pointed out in https://github.com/adoptium/aqa-tests/pull/5248#pullrequestreview-2011754569   they must have no intersection on platforms/OSes
I would like to return CryptoTest target to be vendor neutral, and correclty run on platforms where it can.
On all other platforms - or generally anywhere where @llxia  needs it - it should run the new CryptoTests_jtreg
Can you help me to set up platforms properly or is this out of cope?

Thanx, that is alredy much more frienldy, Will continue with it. TY!

Thanx a lot for patience! Ok by me if I have permissions to say anything to it. TY!


how to create "preprocessed_data.txt"

Hi, I try to run the char-rnn.py but notice that there is no file called "preprocessed_data.txt". Can you pls kindly let me know how to create it?
Cheers

Hi, please see the Dataset section of README.

hi, we did follow the process but it seems only created 1000 .tex file in the dataset directory, and we cannot find the "preprocessed_data.txt"....

hi, we did follow the process but it seems only created 1000 .tex file in the dataset directory, and we cannot find the "preprocessed_data.txt"....

Great. I assume you have run the preprocess_char.py script, which outputs preprocessed .tex files. Next, we concatenate (merge) the 1000 .tex files to create "preprocessed_data.txt", a text file that includes the complete dataset. To do so, we use the following unix/linux command:
cat dataset/*.tex > preprocessed_data.txt
It is important to note that this (our) approach does not treat each paper (.tex file) separately, instead it treats the complete dataset (preprocessed_data.txt) as one single text.

Thanks, it works now. Have a good day.

Thank you, closing the issue.


ERROR Error: NGT_CANNON_BODY_TYPE is required

After adding cannon physics around an object, the following appears in the browser console.
ERROR Error: NGT_CANNON_BODY_TYPE is required
at new NgtCannonBodyController (angular-three-cannon-bodies.mjs:136:19)
at NodeInjectorFactory.NgtCannonBodyController_Factory [as factory] (angular-three-cannon-bodies.mjs:342:1)
at getNodeInjectable (core.mjs:3565:1)
at instantiateAllDirectives (core.mjs:10298:1)
at createDirectivesInstances (core.mjs:9647:1)
at Module.ɵɵelementStart (core.mjs:14541:1)
at PlaneComponent_Template (storybook-plane.component.ts:7:9)
at executeTemplate (core.mjs:9618:1)
at renderView (core.mjs:9421:1)
at renderComponent$1 (core.mjs:10702:1)

To fix, import NgtPhysicPlaneModule


"Discard 2 cards"

This wasn't supported before because we didn't allow multiple-targeting, but we do now, so there's probably nothing stopping us from making it parse.
https://discord.com/channels/301800217055985665/301800217055985665/1106375490010366052

Similarly: "Deal 2 damage to 2 objects"


Fix/met 2325 governance voting spo chart not loading votes hot fix

Hi all, I have some comments on this issue.


Kleeja error : [ 8192:usr.php:95 ]

hi
after install  show erorr
[Kleeja] error :
[ 8192:usr.php:95 ]
Required parameter $expire follows optional parameter $hashed
Visit Kleeja Website for more details.

Server

OS: [Linux]
PHP version: [7.2]

thanks...

have the same issue here

it's just because u are using PHP >=8.
Kleeja is not compatible with PHP 8 yet.
Thanks you for reporting

it's just because u are using PHP >=8. Kleeja is not compatible with PHP 8 yet. Thanks you for reporting

hi
we use PHP  [7.2]
but show error [ 8192:usr.php:95 ]


help_docs: Document Markdown stream/topic auto-linking feature (update).

Rev on #21168.
Reasoning behind changes:

Framed the sections in terms of use cases (link from Zulip vs. anywhere).
Made the language less technical (removed references to Markdown syntax).
Focused on the auto-complete experience as the primary way to link to stream/topic in Zulip, since it's the most common approach in practice.

Testing plan:
manual
GIFs or screenshots:

Squashed and merged with the small change noted above, thanks @alya and @laurynmm!

Should we also be mentioning that clicking the timestamp on a message gets you these permanent links? I think that's totally undocumented at present.

Yeah, that should probably be a note in help/link-to-a-message-or-conversation#link-to-a-specific-message. @laurynmm would you be up for posting a PR?


Add xray.AWSv2() for aws-go-sdk-v2 compatibility

Issue #, if available:
Related to: #53
Description of changes:
Add xray.AWSv2() for compatibility with aws-sdk-go-v2.
This is maybe not the nicest implementation, because it includes a lot of code duplication from aws.go. The problem is, that the types client.Client (from aws-sdk-go) and aws.Client (from aws-sdk-go-v2) can not be used interchangeably and a common interface, which would work with both is to my knowledge currently not present.

Hey guys, any news on this? REALLY in need of this!

Hi all, the aws-sdk-go-v2 is still in developer preview and some X-Ray tracing related components are still subject to change. We will work with AWS Go SDK team to support a more stable version as early as possible. Please stay tuned and thank you for your patience.

In order to use Go Module I had to go to the V2, which means I've lost support for X-Ray, so I do appreciate your reply. ☺

aws/aws-sdk-go is tagged as v1.19.41 and since it is pre-v1 release should work correctly with modules.

Thanks dear stale-bot for the kind reminder. I clearly see no interest from the maintainers in this PR so I will close it.


Deploy the system on a test environment.

Deploy the system on a DNSSEC test environment using the Knot authoritative server. We need to at least use our system in the niclabs DNS records.

I will put this as a milestone.


[FLINK-15168][table-planner] Fix physical indices computing.

What is the purpose of the change
Starting from this PR we use the schema that comes from CatalogTable instead of schema that comes from TableSource.
Computing physical indices is based on the new type hierarchy instead of TypeInformation.
Verifying this change
This change added tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @wuchong


Standalone Lite: Strategy base classes and registry

What does this PR do?
Adds the Strategy base classes. Implementations and the corresponding tests will follow in the other PRs.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃

@kaushikb11 ^^ :otter:


Storage resolver

That's PR make use of debug_StorageRangeAt endpoint.
Before that the entire storage was loaded.
Basically instead of passing the storage to the decoder, we pass the storageResolver .
There are many changes because storageResolver is async, storage was just a map...

please rebase.


Reorganizing the Operation > Monitoring pages

Description
Reorganizing the Operation > Monitoring pages to follow the structure suggested in https://github.com/dapr/docs/issues/1182
Issue reference
Fixes https://github.com/dapr/docs/issues/1182

@orizohar can you please help review & merge ? thanks


[MAC] GPU plugin causes freeze on login

Type
Crash or hang
Operating System
None
OS Version
MAC 15.0.1 - also on previous versions
Bug description
When I log into my account with the GPU plugin enabled, the game will freeze 90% of the time.
With the GPU plugin disabled, it loads 100% of the time.
It's been like this for a month or 2. Used to work fine.
Screenshots or videos
No response
RuneLite version
Launcher: 2.7.2
runelite: <IP_ADDRESS>
Logs
I was told on discord that log files are not relevant for freezes

I'm experiencing this on linux too


[cleanup] move nix.DevboxShell to impl.DevboxShell

Summary

nix.Shell has gradually evolved to encompass more logic than a simple nix shell.
So, previously, we had renamed it to nix.DevboxShell and added a TODO to
move it out of the nix folder.
This PR moves it out of the nix folder.

No other change in logic to make this easy to review.
How was it tested?
buildkite tests

Current dependencies on/for this PR:

main

PR #724   👈

This comment was auto-generated by Graphite.

The auto-nix-install is failing due to github rate limits. This PR shouldn't affect it so am landing.


Remove @nestjs/class-validator, @nestjs/class-transformer as redundant

Replace them with standard class-validator/class-transformer.
Previously there was a security issue that I considered while installing nestjs' libraries, for now I don't find it as a hitch anymore.

done


Add Ballerina doc comments

Purpose

Add Ballerina doc comments

Codecov Report

Merging #961 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   48.33%   48.33%
=======================================
  Files          26       26
  Lines        2458     2458
=======================================
  Hits         1188     1188
  Misses       1006     1006
  Partials      264      264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be51602...f072794. Read the comment docs.


[Test] Initial unit test framework

Signed-off-by: Greg Balke<EMAIL_ADDRESS>Topic: cli_unit_test_framework
Reviewers: jerry-skydio
Relative: github_workflow_python_install

Reviews in this chain:
└https://github.com/Skydio/revup/pull/46 [Test] Initial unit test framework

#
head
base
diff
date
summary

0
ace55c66
c6262ecc
diff
Sep 15 10:49 PM
2 files changed, 52 insertions(+)


Create a basic client with username/password

This client will retrieve an oAuth token using: https://docs.gitlab.com/ce/api/oauth2.html#1-requesting-access-token (fixes #385).
It also removes the libraryVersion (closes #387).

Thank you for adding this. We were rolling our own functionality for it and I'm glad we can remove it now. Looking forward to a tagged release containing this change.

Tagged!


Typemill - hljs plugin - add badge option and update to version 11 of hljs

PR: https://github.com/typemill-resources/highlight/pull/2

@trendschau for some reason I forgot to add it to the commit, but I also forgot the hljs file itself
https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.4.0/highlight.min.js

thank you! Is there any reason why it uses 11.4.0 and not 11.5.0?

Not really, I just tested it with a version I had locally, which was 11.4

Hm, I still get message that  hljs.addPlugin and hljs.highlightAll not a function. Do you have a working local version and can you commit it to github?

Yes, I'll draft a pr

https://github.com/typemill-resources/highlight/pull/3/files try out that one, works on my installation

ok, added the highlights-copy.min.css file manually and pushed it. Now it works. I will publish it later today.


Add setIconRaw to set window icon to void*

I know you fixed setIcon to take an RGBImage in #154, but this readds (with correct type) the version that takes a void* as setIconRaw (feel free to change, wasn't sure what a good name would be).
This version takes a platform-specific icon format. The reason I'd like it is on Windows, I use this to pass the .ico from the executable itself to be the window icon, which produces a nicer 16x16 small icon than passing my normal large icon file and having FLTK scale it down (.ico on top, scaled larger .png on bottom):

This is done like so (inside appropriate ifdefs):
foreign import ccall "&fl_display" fl_display :: Ptr HINSTANCE

... = do
  disp <- peek fl_display
  icon <- loadIcon (Just disp) $ intPtrToPtr 1
  FL.setIconRaw window icon

where HINSTANCE and loadIcon come from the Win32 package.
Also I wasn't sure if it makes sense to accept Ptr a or Ptr (). I went with the first but it doesn't really make a difference to me.

Thanks for this PR, unfortunately this function is deprecated so it may go away ( although FLTK hasn't cut a release in long enough that I think you're ok for a year at least :) ). Ok if I merge this with a {-# DEPRECATED ... #-} pragma.

Oh dang, I didn't notice that deprecation... Sure, that's fine by me, I'll keep an eye on if it goes away at some point.


LitHTML vs HyperHTML

HyperHTML seems to have wider browser support, maybe it's a good idea to use that?
See this table: https://gist.github.com/WebReflection/fadcc419f5ccaae92bc167d8ff5c611b

I'm happy to have both. If you feel like writing a renderer for one, we're more than happy to receive a contribution. Hard part is creating a repo, but having a gist or something we can refer that's written in the same style of the lit html one would be a good place to start :)


the model sizes of the searched models and the search time by AutoKeras and Google AutoML Vision

Sorry to be a bother.
I am now following your paper.
Some experimental results, i.e. the model sizes of the searched models and the search time by AutoKeras and Google AutoML Vision, may be useful to my paper.
Could you send me the records if it's possible?
Thank you very much!
my email<EMAIL_ADDRESS>

Hi @pingguokiller ,
Thanks for your interest!
We are planning to release these model weights together with MedMNIST v2 recently. We are still cleaning the code repo and experiments, you will have them by the end of this month (or very soon).
Please stay tuned ;)
Cheers,
Jiancheng

Hi @pingguokiller,
We have recently updated experiments code and trained model weights on MedMNIST/experiments.
Feel free to check out!
Jiancheng

It's so nice of you.  Thanks for your help!发自我的华为手机-------- 原始邮件 --------发件人： Jiancheng @.>日期： 2021年8月23日周一 凌晨1:26收件人： MedMNIST/MedMNIST @.>抄送： pingguokiller @.>, Mention @.>主    题： Re: [MedMNIST/MedMNIST] the model sizes of the searched models and the search time by AutoKeras and Google AutoML Vision (#13)
Hi @pingguokiller,
We have recently updated experiments code and trained model weights on MedMNIST/experiments.
Feel free to check out!
Jiancheng
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.


Change file structure for typescript functions

By default, functions in TypeScript (Model V4) are created in src/functions directory , then transpiled function code are generated in dist/src/functions directory as below.
├── src
│   └── functions
│       └──httpTrigger1.ts
├── dist # generated by tsc
│   └── src
│       └── functions
│           ├──httpTrigger1.js
│           └──httpTrigger1.map.js

In the above structure, src in dist does not seem to be needed.
This PR changes default settings (including generated package.json, tsconfig.json etc) for the structure from above to below.
├── src
│   └── functions
│       └──httpTrigger1.ts
├── dist # generated by tsc
│   └── functions
│       ├──httpTrigger1.js
│       └──httpTrigger1.map.js

Additionally, structure for JavaScript functions also is changed because transpilation is not needed.
├── functions
│   └──httpTrigger1.js

Thanks @ejizba !
I understand the reason of the structure clearly, so I close this PR.
# I would like you to consider about including test templates next to src.


Images overflow to next page in PDF export in screen mode

Environment:

Puppeteer version: 0.11.0
Platform / OS version: Mac OS X

While running the following script:
const puppeteer = require('puppeteer');

(async () => {
const browser = await puppeteer.launch();
const page = await browser.newPage();
await page.emulateMedia('screen');
await page.setViewport({
    width: 1024,
    height: 768,
 });
await page.goto('file:///test.html', {waitUntil: 'load'});
await page.screenshot({
    path           : 'test.png',
    fullPage       : false,
});
await page.pdf({
  path: 'test.pdf',
  width: '1024px',
  height: '768px',
});
await browser.close();
})();

With the following page:

The image gets printed in a second page in the PDF: test.pdf
While it is should be positioned in the first page as per the screenshot:

Hi @astefanutti  its the problem of your html page.. you have absolute positioned it to top : 500px which makes it to be pushed down and thus looks like its in the next page. change you html file to top : 0px and it works.
Hope that helps

@girishpatil the thing is that it renders as expected when exporting as PNG, while it renders incorrectly when exporting as PDF.

I'm also experiencing something similar: the image is being pushed to the next page when it's in an absolutely positioned layer, instead of being cropped up as it should by the css rules.

I think this is from Chromium 774970: Headless Print to PDF - entire image clipped when it overflows page.


Fixes #1465: End the listener vanflow record when the listener is del…

…eted and not wait until the last connection on that listener is deleted

Patch looks good to me. Can @fgiorgetti validate that it fixes the issue he found?

I talked to @fgiorgetti about testing. He wants the PR to be committed to main and he will test immediately. I will go ahead and merge this and if it does not fix the issue, we will revert immediately.

@ganeshmurthy @kgiusti That CI test is now passing, I have also confirmed manually that the collector is receiving the appropriate flow record to terminate the listener.
Thank you!

@ganeshmurthy @kgiusti That CI test is now passing, I have also confirmed manually that the collector is receiving the appropriate flow record to terminate the listener. Thank you!

@fgiorgetti thank you very much for testing


Fix with_contextvars not properly wrapping functions in some cases.

[x] I have read and agree to the contributing guidelines for submitting new pull requests.

Describe your changes
Fixed

with_contextvars not properly wrapping functions in some cases.

The old implementation had some issues with wrapping some gradio functions, presumably because functools.partial fixes the arguments. This new implementation has a bit less magic and fixes the issue.
While it strongly resembles a decorator, that is a whole rabbit hole I don't want to go back down.
Issue ticket number and link
Closes #1378

any insight into why partial is messing this up

I think gradio relies on inspecting function signatures and partial changes it enough to break things.


Update icon: Google

URL for the brand / site / app
https://google.com
Reason for update
Updated brand color
Logo resources for the icon
https://uxwing.com/google-color-icon/
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines.

No need for update, BG color is from Google's G logo symbol's blue section (#4285F4). Blue is the Google's most used color, so that's why we choose that.
Similar to https://github.com/aegis-icons/aegis-icons/issues/140#issuecomment-735439804, we also will not make BG variations for other colors (as also stated in the FAQ)


Helm and Tiller report incompatible version numbers

Hi,
I'm confused at "[0000] DEBUG  Setup Helm Client helmClientVersion=v2.3.1", I'm using helm and tiller both v2.1.3, but why log says helmClientVersion=v2.3.1, is this mean I MUST use helm client with version 2.3.1? Thanks.
[0000] DEBUG  desired landscaper.Component{Name:"example-hello-world", Namespace:"example", Release:(*landscaper.Release)(0xc420180900), Configuration:landscaper.Configuration{"message":"Hello, Landscaped world!", "sleep":1, "Name":"hello-world", "_landscaper_metadata":map[string]interface {}{"chartrepository":"devops", "releaseversion":"0.1.0"}}, Secrets:landscaper.Secrets{}, SecretValues:landscaper.SecretValues{}}
[0000] DEBUG  Desired state has been read components=2 directory=example/landscape
[0000]  INFO  Obtain current state Helm Releases (Components) from Tiller
[0000] DEBUG  listHelmReleases
[0000] DEBUG  Setup Helm Client helmClientVersion=v2.3.1
[0000] DEBUG  Create tiller tunnel tillerNamespace=kube-system
E0504 14:40:20.408012    7197 portforward.go:209] Unable to create listener: Error listen tcp6 [::1]:22972: bind: cannot assign requested address
[0000] DEBUG  Created tiller tunnel port=22972
[0000]  INFO  Connected to Tiller clientServerCompatible=false tillerVersion=v2.1.3
[0000]  WARN  Helm and Tiller report incompatible version numbers
[0000] ERROR  Loading current state failed error=rpc error: code = 2 desc = client version is incompatible
Error: rpc error: code = 2 desc = client version is incompatible

root@myserver:/tmp/landscaper$ helm version
E0504 14:40:26.246994    7211 portforward.go:209] Unable to create listener: Error listen tcp6 [::1]:34390: bind: cannot assign requested address
Client: &version.Version{SemVer:"v2.1.3", GitCommit:"5cbc48fb305ca4bf68c26eb8d2a7eb363227e973", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.1.3", GitCommit:"5cbc48fb305ca4bf68c26eb8d2a7eb363227e973", GitTreeState:"clean"}

Hi, landscaper is built against a specific version of Helm. Your installed Tiller should be compatible with that version. In Landscaper 1.0.4 we bumped to Helm 2.3.1. Either upgrade your Tiller (with e.g. helm init --upgrade) or use Landscaper 1.0.3.


CRI: mirrors and primary registry are "skipped" if the ImagePullProgressTimeout has expired on previous mirrors

Description
If you define mirrors in /etc/containerd/certs.d//host.toml then try to pull an image with cri plugin and one of the mirrors tried do not respond within the ImagePullProgressTimeout timeout, all successive mirrors and the primary registry also failed as the timeout is global to the pull.
As a result mirror configs are of no help if you want to survive a temporarily unavailable mirror.
Steps to reproduce the issue

configure a mirror.
/etc/containerd/cert.d/_default/host.toml:

[host]
[host.'https://example.com']
capabilities = ['pull', 'resolve']

(optional) reduce the image_pull_progress_timeout.
In /etc/containerd/config.toml:

[plugins."io.containerd.grpc.v1.cri"]
image_pull_progress_timeout = "2s"

Then restart containerd: systemctl restart containerd

block traffic to the mirror (example for https://example.com/, which indeed is not a registry):

$ sudo iptables -I INPUT -s <IP_ADDRESS>/32 -j DROP
$ sudo ip6tables -I INPUT -s 2606:2800:21f:cb07:6820:80da:af6b:8b2c -j DROP

pull an image:

$ crictl --runtime-endpoint unix:///run/containerd/containerd.sock pull busybox
E0821 16:04:09.772375  579991 remote_image.go:180] "PullImage from image service failed" err="rpc error: code = Canceled desc = failed to pull and unpack image \"docker.io/library/busybox:latest\": failed to resolve reference \"docker.io/library/busybox:latest\": failed to do request: Head \"https://example.com/v2/library/busybox/manifests/latest?ns=docker.io\": context canceled" image="busybox"
FATA[0002] pulling image: rpc error: code = Canceled desc = failed to pull and unpack image "docker.io/library/busybox:latest": failed to resolve reference "docker.io/library/busybox:latest": failed to do request: Head "https://example.com/v2/library/busybox/manifests/latest?ns=docker.io": context canceled

Describe the results you received and expected
Image pull fails :
The first mirror do not respond, the timeout is reached, then the next host is tried but fails instantly because the context is already
canceled : msg="trying next host" error="failed to do request: Head \"https://registry-1.docker.io/v2/library/busybox/manifests/latest\": context canceled" host=registry-1.docker.io
containerd logs:

Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.013264606Z" level=debug msg=ImageFsInfo
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.013337789Z" level=debug msg="ImageFsInfo returns filesystem info [&FilesystemUsage{Timestamp:1724256405294515083,FsId:&FilesystemIdentifier{Mountpoint:/var/lib/containerd/io.containerd.snapshotter.v1.overlayfs,},UsedBytes:&UInt64Value{Value:9069412352,},InodesUsed:&UInt64Value{Value:216985,},}]"
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.014000501Z" level=info msg="PullImage \"busybox\""
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.014050063Z" level=debug msg="PullImage using normalized image ref: \"docker.io/library/busybox:latest\""
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.014074486Z" level=debug msg="PullImage \"docker.io/library/busybox:latest\" with snapshotter overlayfs"
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.015657983Z" level=debug msg="loading host directory" dir=/etc/containerd/certs.d/_default
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.015812264Z" level=debug msg=resolving host=example.com
Aug 21 16:06:51 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:51.015829495Z" level=debug msg="do request" host=example.com request.header.accept="application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, */*" request.header.user-agent=containerd/1.7.11 request.method=HEAD url="https://example.com/v2/library/busybox/manifests/latest?ns=docker.io"
Aug 21 16:06:52 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:52.015204418Z" level=debug msg="progress for image pull" activeReqs=1 lastSeenBytesRead=0 lastSeenTimestamp="2024-08-21T16:06:51Z" ref="docker.io/library/busybox:latest" reportInterval=1s totalBytesRead=0
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015257917Z" level=debug msg="progress for image pull" activeReqs=1 lastSeenBytesRead=0 lastSeenTimestamp="2024-08-21T16:06:51Z" ref="docker.io/library/busybox:latest" reportInterval=1s totalBytesRead=0
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015336685Z" level=error msg="cancel pulling image docker.io/library/busybox:latest because of no progress in 2s"
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015452697Z" level=info msg="trying next host" error="failed to do request: Head \"https://example.com/v2/library/busybox/manifests/latest?ns=docker.io\": context canceled" host=example.com
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015481010Z" level=debug msg=resolving host=registry-1.docker.io
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015498785Z" level=debug msg="do request" host=registry-1.docker.io request.header.accept="application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, */*" request.header.user-agent=containerd/1.7.11 request.method=HEAD url="https://registry-1.docker.io/v2/library/busybox/manifests/latest"
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.015555866Z" level=info msg="trying next host" error="failed to do request: Head \"https://registry-1.docker.io/v2/library/busybox/manifests/latest\": context canceled" host=registry-1.docker.io
Aug 21 16:06:53 ip-100-88-144-226.eu-west-3.compute.internal containerd[522595]: time="2024-08-21T16:06:53.016893279Z" level=error msg="PullImage \"busybox\" failed" error="rpc error: code = Canceled desc = failed to pull and unpack image \"docker.io/library/busybox:latest\": failed to resolve reference \"docker.io/library/busybox:latest\": failed to do request: Head \"https://example.com/v2/library/busybox/manifests/latest?ns=docker.io\": context canceled"

In this case I would expect containerd to try the next host with a timeout reset to the initial value and not to fails immediately.
While this is not a bad thing to have a "global" timeout, we also need a timeout that apply only for each hosts.
For example, a timeout of 20s for each mirrors, and a global one of 60s.
What version of containerd are you using?
containerd github.com/containerd/containerd 1.7.11 64b8a811b07ba6288238eefc14d898ee0b5b99ba
Any other relevant information

$ crictl info
{
  "status": {
    "conditions": [
      {
        "type": "RuntimeReady",
        "status": true,
        "reason": "",
        "message": ""
      },
      {
        "type": "NetworkReady",
        "status": true,
        "reason": "",
        "message": ""
      }
    ]
  },
  "cniconfig": {
    "PluginDirs": [
      "/opt/cni/bin"
    ],
    "PluginConfDir": "/etc/cni/net.d",
    "PluginMaxConfNum": 1,
    "Prefix": "eth",
    "Networks": [
      {
        "Config": {
          "Name": "cni-loopback",
          "CNIVersion": "0.3.1",
          "Plugins": [
            {
              "Network": {
                "type": "loopback",
                "ipam": {},
                "dns": {}
              },
              "Source": "{\"type\":\"loopback\"}"
            }
          ],
          "Source": "{\n\"cniVersion\": \"0.3.1\",\n\"name\": \"cni-loopback\",\n\"plugins\": [{\n  \"type\": \"loopback\"\n}]\n}"
        },
        "IFName": "lo"
      },
      {
        "Config": {
          "Name": "cilium",
          "CNIVersion": "0.3.1",
          "Plugins": [
            {
              "Network": {
                "type": "cilium-cni",
                "ipam": {},
                "dns": {}
              },
              "Source": "{\"enable-debug\":false,\"log-file\":\"/var/run/cilium/cilium-cni.log\",\"type\":\"cilium-cni\"}"
            },
            {
              "Network": {
                "name": "istio-cni",
                "type": "istio-cni",
                "ipam": {},
                "dns": {}
              },
              "Source": "{\"cni_event_address\":\"/var/run/istio-cni/pluginevent.sock\",\"kubernetes\":{\"cni_bin_dir\":\"/opt/cni/bin\",\"exclude_namespaces\":[\"istio-system\",\"kube-system\"],\"kubeconfig\":\"/etc/cni/net.d/ZZZ-istio-cni-kubeconfig\"},\"log_level\":\"info\",\"log_uds_address\":\"/var/run/istio-cni/log.sock\",\"name\":\"istio-cni\",\"type\":\"istio-cni\"}"
            }
          ],
          "Source": "{\n  \"cniVersion\": \"0.3.1\",\n  \"name\": \"cilium\",\n  \"plugins\": [\n    {\n      \"enable-debug\": false,\n      \"log-file\": \"/var/run/cilium/cilium-cni.log\",\n      \"type\": \"cilium-cni\"\n    },\n    {\n      \"cni_event_address\": \"/var/run/istio-cni/pluginevent.sock\",\n      \"kubernetes\": {\n        \"cni_bin_dir\": \"/opt/cni/bin\",\n        \"exclude_namespaces\": [\n          \"istio-system\",\n          \"kube-system\"\n        ],\n        \"kubeconfig\": \"/etc/cni/net.d/ZZZ-istio-cni-kubeconfig\"\n      },\n      \"log_level\": \"info\",\n      \"log_uds_address\": \"/var/run/istio-cni/log.sock\",\n      \"name\": \"istio-cni\",\n      \"type\": \"istio-cni\"\n    }\n  ]\n}\n"
        },
        "IFName": "eth0"
      }
    ]
  },
  "config": {
    "containerd": {
      "snapshotter": "overlayfs",
      "defaultRuntimeName": "runc",
      "defaultRuntime": {
        "runtimeType": "",
        "runtimePath": "",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "ContainerAnnotations": null,
        "runtimeRoot": "",
        "options": null,
        "privileged_without_host_devices": false,
        "privileged_without_host_devices_all_devices_allowed": false,
        "baseRuntimeSpec": "",
        "cniConfDir": "",
        "cniMaxConfNum": 0,
        "snapshotter": "",
        "sandboxMode": ""
      },
      "untrustedWorkloadRuntime": {
        "runtimeType": "",
        "runtimePath": "",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "ContainerAnnotations": null,
        "runtimeRoot": "",
        "options": null,
        "privileged_without_host_devices": false,
        "privileged_without_host_devices_all_devices_allowed": false,
        "baseRuntimeSpec": "",
        "cniConfDir": "",
        "cniMaxConfNum": 0,
        "snapshotter": "",
        "sandboxMode": ""
      },
      "runtimes": {
        "runc": {
          "runtimeType": "io.containerd.runc.v2",
          "runtimePath": "",
          "runtimeEngine": "",
          "PodAnnotations": null,
          "ContainerAnnotations": null,
          "runtimeRoot": "",
          "options": {
            "SystemdCgroup": true
          },
          "privileged_without_host_devices": false,
          "privileged_without_host_devices_all_devices_allowed": false,
          "baseRuntimeSpec": "",
          "cniConfDir": "",
          "cniMaxConfNum": 0,
          "snapshotter": "",
          "sandboxMode": "podsandbox"
        }
      },
      "noPivot": false,
      "disableSnapshotAnnotations": true,
      "discardUnpackedLayers": false,
      "ignoreBlockIONotEnabledErrors": false,
      "ignoreRdtNotEnabledErrors": false
    },
    "cni": {
      "binDir": "/opt/cni/bin",
      "confDir": "/etc/cni/net.d",
      "maxConfNum": 1,
      "setupSerially": false,
      "confTemplate": "",
      "ipPref": ""
    },
    "registry": {
      "configPath": "/etc/containerd/certs.d:/etc/docker/certs.d",
      "mirrors": null,
      "configs": null,
      "auths": null,
      "headers": null
    },
    "imageDecryption": {
      "keyModel": "node"
    },
    "disableTCPService": true,
    "streamServerAddress": "<IP_ADDRESS>",
    "streamServerPort": "0",
    "streamIdleTimeout": "4h0m0s",
    "enableSelinux": false,
    "selinuxCategoryRange": 1024,
    "sandboxImage": "xxx.dkr.ecr.xxx.amazonaws.com/eks/pause:3.5",
    "statsCollectPeriod": 10,
    "systemdCgroup": false,
    "enableTLSStreaming": false,
    "x509KeyPairStreaming": {
      "tlsCertFile": "",
      "tlsKeyFile": ""
    },
    "maxContainerLogSize": 16384,
    "disableCgroup": false,
    "disableApparmor": false,
    "restrictOOMScoreAdj": false,
    "maxConcurrentDownloads": 3,
    "disableProcMount": false,
    "unsetSeccompProfile": "",
    "tolerateMissingHugetlbController": true,
    "disableHugetlbController": true,
    "device_ownership_from_security_context": false,
    "ignoreImageDefinedVolumes": false,
    "netnsMountsUnderStateDir": false,
    "enableUnprivilegedPorts": true,
    "enableUnprivilegedICMP": true,
    "enableCDI": false,
    "cdiSpecDirs": [
      "/etc/cdi",
      "/var/run/cdi"
    ],
    "imagePullProgressTimeout": "2s",
    "drainExecSyncIOTimeout": "0s",
    "containerdRootDir": "/var/lib/containerd",
    "containerdEndpoint": "/run/containerd/containerd.sock",
    "rootDir": "/var/lib/containerd/io.containerd.grpc.v1.cri",
    "stateDir": "/run/containerd/io.containerd.grpc.v1.cri"
  },
  "golang": "go1.20.12",
  "lastCNILoadStatus": "OK",
  "lastCNILoadStatus.default": "OK"
}

Show configuration if it is related to CRI plugin.

version = 2
root = "/var/lib/containerd"
state = "/run/containerd"
imports = ["/etc/containerd/config.d/*.toml"]

[grpc]
address = "/run/containerd/containerd.sock"

[plugins."io.containerd.grpc.v1.cri".containerd]
default_runtime_name = "runc"
discard_unpacked_layers = false

[plugins."io.containerd.grpc.v1.cri"]
enable_unprivileged_ports = true
enable_unprivileged_icmp = true
sandbox_image = "xxx.dkr.ecr.xxx.amazonaws.com/eks/pause:3.5"

[plugins."io.containerd.grpc.v1.cri".registry]
config_path = "/etc/containerd/certs.d:/etc/docker/certs.d"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
runtime_type = "io.containerd.runc.v2"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc.options]
SystemdCgroup = true

[plugins."io.containerd.grpc.v1.cri".cni]
bin_dir = "/opt/cni/bin"
conf_dir = "/etc/cni/net.d"

I'm new to the containerd project, but I invested some time in analyzing the problem here.
As a sidenote: Since fetching is done via the containerd client implementation, I'm not sure if the problem I describe occurs for every implementation of "Pulling an image". I noticed that nerdctl uses the containerd.Client implementation directly but I haven't found out yet, how crictl handles this.
@dmcgowan I'd like to help fixing this problem, but I think I'd need some guidance in how to approach this or at least an opinion.
I thought of introducing a per host timeout, so that any timeouts on parent context would would not stop subsequent hosts from being used for further fetches, altough I'm not sure yet about the size of that timeout. For a better performance I thought of discarding hosts/mirrors, that timed out (if there are alternatives for the timed out host).
There is two places I see that the different hosts are being used for fetches: When resolving the image and when fetching the actual config and blobs.
In both cases there is loops over all hosts to fetch from any of them.
The main issue I see is that the fetching of multiple descriptors concurrently is separated from where they are fetched from. Thus for every fetch of a descriptor, every host is tried until one fetch is sucessfull. If we introduced a per host timeout, should we then discard any hosts that have already timed out before? Otherwise subsequent descriptors would again timeout on that host.
I tested this and I could make a Pull successfull by using such a per host timeout, but every descriptor will try the "bad host" again, thus making the overall Pull very slow.
E.g. what I broadly did was:

Adding a test to integration/image_pull_timeout_test.go that fails, when a host is added that does not respond
Adding child contexts with a timeout in the loop over hosts in the resolver, so the request would not hang forever
Adding child contexts with a timeout in the loop over hosts in the "Fetcher", so the requests would not hang forever

This makes the test pass, altough the result is a slow fetching of descriptors due to the problem I described above.
The alternative would be to try and fetch all descriptors from one host and only switch to the next one on error or timeout.
But I don't know all the reasons for doing it the way it's currently being done (e.g. maybe certain manifest/config/blobs are not available on all hosts, thus it makes sense to try every host for every descriptor)


Updates for file reading

Deny images over App.MAX_BYTES
Show state when drag is happening
Only process image files
Display errors and skipped files

Yup!
Btw you can commit directly now


Update dependencies

Need to update all required dependencies

@maxonfjvipon the puzzle #18 is still not solved.


consolidation of linting dependencies, scripts, etc in monorepo

updates all affected dependencies while at it
adds YAML linting to the mix

this went way out of control, apologies for the mess.

Looks good for now. The only thing I'm worried about is we might go back and re-place all of this where it is now for better peer dependency resolution. I'm playing with that in frontend. I'm OK to merge this here with a few changes and then we can go back if needed.

i'd prefer if we merged this in, it'll give us some cleanup, updated dependencies, and YAML linting.
will make another pass over this for further realignment with frontend's monorepo layout once that's done.


Delete unused constant in InfoBar

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Thank you for submitting this PR, the current focus of the team is to assist our users in moving from WinUI 2 to WinUI 3. We are closing this PR as it does not address resolving a critical issue for WinUI 2 or WinUI 3.


Fix card brand image alignment

Summary
I've fixed a case where the card brand images are not correctly aligned. Like so:

Probably due to a combination of the margin here, plus the margin-top: -8px of the brand image wrapper.

Setting the images as display: block instead of the default inline is one solution to the problem. Another viable solution would be to set vertical-align: top on the image element.

Tested scenarios

Fixed issue:

Closing this PR for now, as we can't reproduce this problem.


Tracking issue for abi-checker failures

Todo: add list of all failures. See https://github.com/bjorn3/rustc_codegen_cranelift/pull/1255

STATUS_ACCESS_VIOLATION for MSVC on pair rustc_calls_cgclif:
generating bool::c::rustc_calls_rustc
compiling  bool::c::rustc_calls_rustc
running    bool::c::rustc_calls_rustc
error: process didn't exit successfully: `target\debug\abi-checker.exe --pairs cgclif_calls_rustc --add-rustc-codegen-backend cgclif:C:\Users\Afonso\CLionProjects\rustc_codegen_cranelift\build\bin\rus
tc_codegen_cranelift.dll` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

Discovered in #1255 (and possibly #1249)

I've been investigating this, and I think this is related to missing stack probes. I don't understand why this wasn't triggering earlier, since some tests did show up as completed.
This crashes on the first stack access that is "far" away (about 0x17D70 bytes away from the last stack write).
It doesn't even call the first test function, it crashes allocating some stack for it.
If I isolate the tests down to just calling convention "c" and the "bool" test suite it crashes, and if i isolate it down to just "f32" and calling convention "c" it starts crashing as well (which it didn't while running in y.exe, but we may have had some more leeway there due to previous stack usage?).
I confirmed this by doing a sort of stack probe before starting the test, I just allocated a 256k array in memory and wrote to it from bottom to top, and the tests now pass!
With this fix the entire ABI suite passes, for all calling conventions (that we test)!

I think a nice way of fixing this properly would be to work on https://github.com/bytecodealliance/wasmtime/issues/2299 and solve it that way. I'll give it a try.

Right, I believe on Windows the stack is almost completely unmapped, but still reserved, by default and you need to hit the guard page for windows to grow the stack. Still interesting that stack probes are mandatory on Windows. I never would have thought of that.

I think a nice way of fixing this properly would be to work on https://github.com/bytecodealliance/wasmtime/issues/2299 and solve it that way. Its a really nice coincidence that this ended up being related to missing stack probes, since I've been wanting to enable inline stack probing for a while

:heart:

Updated to Cranelift 0.87.0 in https://github.com/bjorn3/rustc_codegen_cranelift/commit/b14c7337db5861288afc3b26ba006859ed052d39.

The latest Cranelift update realigns the 128bit int abi with cg_llvm.


Display User Friendly error message when pachd can't connect to object storage

What happened?:
Booting pachd with incorrect or missing storage credentials results in the following log messages when pachd boots:
2021-05-12T15:48:38Z INFO no Jaeger collector found (JAEGER_COLLECTOR_SERVICE_HOST not set)
2021-05-12T15:48:38Z INFO started setting up Block API GRPC Server

What you expected to happen?:
Pachd should print an error message when it can't connect to object store or when objects storage credentials are missing.
How to reproduce it (as minimally and precisely as possible)?:
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI and pachd server version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

It should already do that and I have seen it output error messages in the past when we fail to connect to / test object storage. If the server set up returns an error, which it should when we error while setting up / testing the object storage client, then that gets output in a message with the name of the server that errored. You should only be in this situation if the set up hangs, which could be because a timeout isn't set.

That's what confused me as well, as they tried setting a timeout and the same issue occurred. What I'm thinking is perhaps adding a pre-flight check if the ENV Var isn't set all all and bailing out there (or perhaps even just a warning) It is a bit tricky because we need to take into account scenarios where creds are legitimately not needed, such as google workload identity, but I think we can pick that up from annotations and such on the pachd deployment.
First step is reproducing what they were seeing on our end.


Built-in rules that check the sites/config resource do not include the possibility of the config defined in the sites resource

Current proposed built-in rules that check the sites/config resource does not consider the case where the config can be defined directly in the sites resource. These rules should be updated to check both the possibility that the config was defined in sites AND sites/config as a separate resource.
Microsoft.Web/sites schema where the config can be defined: https://docs.microsoft.com/en-us/azure/templates/microsoft.web/sites?tabs=json#SiteConfig
Affects issues: #94 #93 #81 #80 #79 #74 #73 #70 #69 #68 #67 #66 #65 #64 #63 #62

Updated all rules in issues listed above.