[stable/influxdb]: Add the existing pvc and the release label back to the chart.

Signed-off-by: Aisuko<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Add back pre-existing volume.
Add the label name release.

Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #18479

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

bump

Will try to look more closely at this soon, but may not be able today. Quick notes for now: the pv dynamic provisioning logic changes - I remember that is something that was applied to a lot of charts (see the comments in values.yaml). Let’s please explain this change, and make sure it doesn’t cause another regression. Also does the data loss is the previous version mean it was an accidental breaking change (if upgrading from a previous version, requiring manual steps to preserve data)? If so we should note that in the readme and version bump accordingly.

/retest

/retest

/retest

/retest

/test pull-charts-e2e

I don't think a major bump/upgrading note is needed, this is to fix a regression from the move to statefulset.
upgrading note definitely needed for move to 3.X.X which was bi of a disaster (aside from removal of pre existing PVC, statefulset  should have been an option (type: Deployment|StatefulSet) instead instead of complete shift, with a deprecation notice about deployment), but is already there https://github.com/helm/charts/tree/master/stable/influxdb#from--300-to--300
Backup and restore steps should be elaborated on though. not only for that breaking change but as general guidelines for users of this chart.

I don't think a major bump/upgrading note is needed, this is to fix a regression from the infamous move to statefulset.
upgrading note definitely needed for move to 3.X.X which was bit of a disaster (aside from removal of pre existing PVC, statefulset should have been an option (type: Deployment|StatefulSet) instead instead of complete shift, with a deprecation notice about deployment), but is already there https://github.com/helm/charts/tree/master/stable/influxdb#from--300-to--300
Backup and restore steps should be elaborated on though. not only for that breaking change but as general guidelines for users of this chart.

Hello, sir.  I agree with you. Add Deployment as another choice would be good.  But, for this PR, I 'd like to fix the release.label and complete the storage policy for Statefulset first.  This PR status has been so long time to open.

To be honest, I do not know why the CI can not work very well, for this PR. Please help
to look at this log. https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/helm_charts/19295/pull-charts-e2e/1209648306368548864/build-log.txt

I don't think a major bump/upgrading note is needed, this is to fix a regression from the infamous move to statefulset.
upgrading note definitely needed for move to 3.X.X which was bit of a disaster (aside from removal of pre existing PVC, statefulset should have been an option (type: Deployment|StatefulSet) instead instead of complete shift, with a deprecation notice about deployment), but is already there https://github.com/helm/charts/tree/master/stable/influxdb#from--300-to--300
Backup and restore steps should be elaborated on though. not only for that breaking change but as general guidelines for users of this chart.

Hello, sir. I agree with you. Add Deployment as another choice would be good. But, for this PR, I 'd like to fix the release.label and complete the storage policy for Statefulset first. This PR status has been so long time to open.

But we are fixing a regression introduced in v3.X.X so I don't think a major bump is necessary. Elaboration on how to migrate from 2.X.X to 3.X.X should be added along with the regression fixes.

I know what you mean and I checked the PV logic. There is true that we add back the PV logic to the chart and did not cause a broken change, there just more than one option for how to use the PV.


OWASP Guidance: prefer Origin header over Referer header when Identifying Source Origin

CSRF protection in csrf.py should prefer Origin header over Referer header if the former is available when checking same_site().

OWASP Guidance on the topic

The current code
       if request.is_secure and current_app.config['WTF_CSRF_SSL_STRICT']:
            if not request.referrer:
                self._error_response('The referrer header is missing.')

            good_referrer = f'https://{request.host}/'

            if not same_origin(request.referrer, good_referrer):
                self._error_response('The referrer does not match the host.')

only looks at request.referrer.

Broken off from https://github.com/wtforms/flask-wtf/issues/364


Fixed dependencies

https://github.com/tannerlinsley/react-form/issues/38

Looks like they accidentally accrued some deps in these two commits :(

cc89cd9016ebcc13b357f1f654cbd88185e8fcfc
5fa7f9639c3a75bd67961f81452da67208f35a4c

Thanks for the fix!


Make smoke test print page contents on failure

This is to help us figure out what failed, and whether or not it is
something we need to be worried about.

Review app deployed to https://teaching-vacancies-review-pr-3011.london.cloudapps.digital

Yes!!!!


update deps and not scanning whole drive in windows

For #106
The changes:

Update Electron to version ^4.0.0 in packages.json
Update travis nodejs version to 8 in .travis.yml
Fix cwd for windows OS to avoid scanning the entire disc in lib/local/windows.js line 5

@chasenlehara https://github.com/bitovi/launchpad/issues/111


Fix COC auto-formatting breaking files somehow if save too fast after making change

Related: #5

Come back to soon, progress so far:

git bisect says https://github.com/neoclide/coc.nvim/commit/9c54590c6dd37f06a27768a5c3e22615795a0ae9 is the culprit

related issue: https://github.com/neoclide/coc-prettier/issues/134

minimal vimrc reproducing this:
call plug#begin()
Plug 'neoclide/coc.nvim', {'commit': '9c54590c', 'do': 'yarn install --frozen-lockfile'}
call plug#end()

noremap <silent> <C-s> <Esc>:write<CR>
noremap! <silent> <C-s> <Esc>:write<CR>

example of issue:

https://user-images.githubusercontent.com/7476523/133945423-d1b48d10-6c97-4e9c-b485-0c68c16e45f4.mp4


Error missing numexpr dependency when running 07_Agents/00_Function_DIY_Agents.ipynb

When running in 07_Agents/00_Function_DIY_Agents.ipynb notebook
from langchain import LLMMathChain

math_tool_template = """\
Given a question from the Human with a math problem, provide only a single line mathematical expression that solves the problem in the following format.
Never solve the expression only create a parsable expression.
```text
${{single line mathematical expression that solves the problem}}
```

Here is an example response with a single line mathematical expression for solving a math problem:
```text
37593**(1/5)
```

Human: {question}

Assistant:"""

llm_math_chain = LLMMathChain.from_llm(llm=agent_llm, verbose=True)
llm_math_chain.llm_chain.prompt.template = math_tool_template
result = llm_math_chain('What is nine times 465?')

getting following error:
ImportError: LLMMathChain requires the numexpr package. Please install it with `pip install numexpr`.

Solution that works for me:
pip install numexpr

Closing this; please refer to the latest bedrock workshop update and reopen if still relevant


feat(file_index): add file index format read and write

part #34

This update involves the reconstruction of FileIndexFormat's reading and writing functionalities based on the new FileIO. To keep the changes manageable, I’ve split the PR into smaller parts. If you have a moment, I would greatly appreciate reviews. @Xuanwo @SteNicholas

Sorry for being late again. I have corrected all your comments. Please review them when you have time to see if there are any problems. Thank you very much. @Xuanwo


CI/CD

Requirements:

PR checks: linting, typechecks, unit tests
Automate deploy/publish???
Eject create-react-app?

Closing this for now. Let's focus on the next milestones first and see if projects is valuable before wasting time to maintain CI


⚠ GitLab Server has degraded performance

In 6bb3191, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 12126 ms

Resolved: GitLab Server performance has improved in ce79b80.


Fixed #10088 -- Added QuerySet.select_for_share().

Initial work to address ticket-10088.
Alternative to #15939 and #16172.
Thought I'd get this out there as I've been sitting on it for a couple of years. I've rebased it.

Adds support for nowait, skip_locked, of and key options

Note that select_for_update() has no_key, but select_for_share() has key

Adds support for LOCK IN SHARE MODE for MariaDB and MySQL < 8.0.1
Implements support of for_share_after_from like for_update_after_from used by MSSQL backend
Shared documentation for select_for_share() and select_for_update() as very similar
Shared tests for select_for_share() and select_for_update() as very similar

The patch is quite mature, but there is still some work to be done:

[ ] Properly implement the "blocking" tests using other thread for FOR SHARE case
[x] Determine what to do about subTest() not supporting skipTest()

Have split into separate test modules with some preliminary refactoring to make things more maintainable.

[ ] Review whether anything has been missed. I've rebased this but it was written a long time ago...

I've marked this as a draft because of needing to think about the testing issues, but it's ready for a first round of review.

buildbot, test on oracle.

buildbot, test on oracle.

Have pushed progress so far. Still some tidying up to be done, fixing some tests, etc.
So no review required yet.

buildbot, test on oracle.


Add support for Chimera 0.40.202 FPS Throttle

nToss — 01/23/2021

So I was proven wrong when arguing about the ancient Chimera version we use
It turns out
It does have framerate throttle

nToss — 01/24/2021

I still haven't figured out where Chimera-202 saves the framerate throttle setting
Kava said it's supposed to save to chimera.bin, but the file was unchanged each time changed the throttle.
and the throttle is saved after closing the game and loaded when starting the game

Miris Wisdom — 01/24/2021

0xB5 is the chimera fps throttle (seems to vary depending on whether the value is, e.g. 15 vs 59.99 -- also can't confirm if other values are applied in the binary as an invisible side effect)
but on the positive note, the fps throttle is absolutely saved in the chimera.bin. i'll have a look again more closely soon

Miris Wisdom — 01/24/2021

figuring out how the number is encoded will be interesting

Miris Wisdom — 02/09/2021

there was a super epic time where i had a struct of the chimera we use and could therefore know how the chimera_fps_throttle is stored

ArecadianFox provided some FPS values via labelled chimera.bin configs
https://docs.google.com/spreadsheets/d/1_bDBeSsxGjLbN4aA6p-mduVEnNB9qOMog_kpjCVRYCY/edit?usp=sharing

C# floats are slightly different from C/C++ floats.
See System.Runtime.InteropServices.NFloat

Something I recently learned is Chimera's FPS throttle is exactly that—a throttle. Sure, it limits the max FPS, but it does so by making the main thread sleep.
While sleeping, no user input is registered and processed which leads to perceived input latency.
What we should do is uncap FPS and then use/encourage driver- or software-based¹ framerate limiting. In fact, V-Sync alternatives (e.g. Fast Sync, Adaptive Sync (maybe), FreeSync, G-Sync, et cetera) would be preferable.
¹ SpecialK offers a framerate limiter, but I can't promise it doesn't introduce significant input latency.


Need more EO-tests

You can add your .eo tests to src/test/eo/org/eolang/dejump.
Rules for tests:

has only one outer abstract object, inside of which the logic of the test;
name of this object should be equal to the name of file with this test:
for example, if your test has a "main" object [] > easy_test, so the .eo file should be called easy_test.eo;
your test should not contain any alias-es:
for example, if you use object stdout in your code, use it as QQ.io.stdout, NOT with alias;
logic of your test can be absolutely different - it is no requirement to has a goto object inside, but, since
we check goto elimination, it would be better that your test will have it :) ;
based on concept of transformations, there are cases of using goto, which are not allowed for this applications:

When objects forward/backward encapsulated (directly or throw other objects) in any foreign objects -- objects, that
are implemented somewhere in your code (objects, that general EO-syntax doesn't support):

goto
  [g]
    foreign_obj > @
      QQ.io.stdout
        "We don't know the logic\n"
      g.forward TRUE

Cases, where we dataize objects forward/backward outside object goto:

goto
  [g]
    seq > @
      foo g
[x] > foo
  x.forward 25

As examples of tests, check .eo files at src/test/eo/org/eolang/dejump.

@Graur FYI


Remove some outdated tutorials

Hey colleagues,
we want to remove some outdated tutorials but we're unsure how to do that.
Can you point me at the right resources/people/process?
Best,
Tom

He @jmmargo, do you have any updates there?

Sorry about the delay Tom.  Just send me an email and let me know which tutorials need to be removed.  And do you want them removed from both QA and production repos?  I will check if they are referenced in any other tutorial, groups, or missions.
Thanks,
Joshua


Added newsletter from address verification

refs https://github.com/TryGhost/Team/issues/1498
refs https://github.com/TryGhost/Team/issues/584
With membersFromAddress being removed in favor of separate from addresses for each newsletter the verification flow needs to be moved too.
This also addresses problems with the existing verification flow where the emailed link was pointing directly at an API route resulting in poor experience when the process is unsuccessful. With this new flow there's no specific endpoint for triggering an email change, instead a verification will be triggered as needed when creating/updating a newsletter with meta data inserted in the response for clients to inform users as needed. The email also links to an Admin endpoint rather than an API endpoint providing a smoother confirmation flow.

updated newsletter service so the index exports an instance

follows the more common pattern for services
keeps dependency injection in one place so it's not necessary to re-specify the injected dependencies everywhere the service is consumed

added add and edit methods to NewsletterService class

accepts same arguments as NewsletterModel.add/edit
if the supplied sender_email attribute requires verification the attribute is stripped before saving, a verification email is triggered, and a meta: {sent_email_verification: ['sender_email']} property is added to the response
email verification contains a link to Admin, eg https://yoursite.com/ghost/#/settings/members-email/?verifyEmail=token with the token containing the id of the newsletter that's being updated, the new email, and the changed property

updated newsletters API so it uses the NewsletterService.add/edit methods that contain the verification email trigger business logic
added PUT /newsletters/verify-email/ endpoint

accepts {token: 'xyz'} in the body, this request is triggered by Admin when the confirmation link is loaded
extracts data from the single-use token, then uses the id, email, and property data to edit the newsletter completing the update of the email address

TODO:

[ ] add tests
[ ] when importing newsletters set sender_email to null

I have some comments on naming 😬  ref: API design docs

endpoint names should be snake_case not kebab
endpoint names should be nouns wherever possible :)

Suggestions:
PUT /newsletters/emails/
PUT /newsletters/verifications/
PUT /newsletters/from_address/
Any of these or similar would be fine, depends on how you think about the resource that you're operating on.
In terms of existing patterns in the API that relate to this
router.put('/authentication/passwordreset' is 👍
router.post('/authentication/invitation'  is 👍 (although plural would prob be even better)
router.post('/authentication/reset_all_passwords' is 👎
Also (I've spent way to long looking at the request and response bodies of all our endpoints recently haha) if we have no strong use-case for a response body from the endpoint, I am heavily in favour of setting statusCode: 204 for any custom endpoint that does a thing and reports OK or errors. I can't quite tell from the PR if there's a real need for returning the edit response?

I have some comments on naming 😬 ref: API design docs

👍 I'll update to PUT /newsletters/verifications/. The token contains the property name and the new value so it's a fairly generic property/value verification process.

I can't quite tell from the PR if there's a real need for returning the edit response?

The response is by the Admin as it lets it update it's internal store with the newly updated data. Clients can't read the data from the token, all they knows is that it needs to send it to the API to get the updated newsletter in response. An alternative would be returning something minimal with the id of the newsletter so the client can re-fetch it to get the updated version 🤔

Ok, that all makes sense to me :)


Stuck in loop if user_creator service is not used

Hi,
I am having some difficulty while implementation. If I don't provide user_creator service and user authenticated successfully, the system stuck in loop keep redirecting to IdP and IdP keep sending back to SP. I think this is because the user not authorized so token not generated so SP send to IdP but user is authenticated so IdP send back user to SP.
I remember I had a similar issue in SamlSPBundle and I overcome this by setting user role to something which is not in system. This stops the user at SP with 403 error as user is not authorized. I unable to do same here unless I have to override authenticate function in LightsSamlSpAuthenticationProvider.
Is there some better way to handle this case without overriding? I am avoiding this as it is hard to maintain for subsequent updates. Thanks

I able to resolve this by creating my own user provider. I used the same trick to login user without any role and it works as it shows 403 error.


copy/create DEMO ATBD

Description:
The DEMO ATBD needs to be re-done since it was accidentally deleted.  DevSeed will attempt to recover the original from UAH PROD, if this isn't possible, the ATBD will need to be copied over from an old PDF version.
This ATBD has now been accepted for publication through AGU ESS: https://doi.org/10.1029/2022EA002516
Tasks:

[x] Copy DEMO ATBD into MCP.
[ ] Need to compare the officially accepted AGU ATBD with the DEMO to ensure consistency.
[ ] Review PDF version (ATBD currently not downloading, so cannot check PDF version yet)

Acceptance Criteria:

[ ] Published DEMO ATBD to MCP (DevSeed will let us know when finished with search and discovery fix, then we can publish)

@bwbaker1 I checked with the team and unfortunately this is not easily migrated. The original migration script that was run when we moved over to MCP only worked because there were no documents (draft or published) in MCP at the time. Now that we have migrated over some documents, migrating over individual documents becomes much more complex. The least-cost solution would probably be using a PDF to re-create the ATBD.

@aboydnw Can you look into one more option? Instead of migrating it over to MCP, is it possible to make it viewable from UAH PROD?  Copying content over from the PDF isn't a big deal (same as copying from within the tool), however I forgot how many long equations there are in that atbd.  It will take a very long time to figure out the Latex syntax for all of them.

@bwbaker1 sure thing, let me check on that

@bwbaker1 it's not really a quick thing to reveal the UAH stack via a UI. would this json that Leo pulled be close enough to what you are looking for? I looked through it and you can see the equations broken down by section and copy and paste the latex equation. https://drive.google.com/file/d/13vIyZ0jroD0uDNQ3U0xnKyY7LaXjylVN/view?usp=sharing

@aboydnw No, I don't think this helps too much.  Its difficult to find the equations in the JSON and the syntax is a little different.  I will re-do the document from scratch.  I think the important thing moving forward is to make sure published documents cannot be deleted.  In that regard, I'm kind of glad this happened now and not later.

Confirming that this should wait until we've fixed #500, otherwise the ATBD won't be indexed for search.
cc: @naomatheus

Need to the GEDI L4 published article to what is in APT.  There may be a few needed updates.
Still waiting on the ability to download PDFs on PROD.
Once 1 and 2 are done, will publish the Demo ATBD.

@deborahUAH @bwbaker1 you're now able to work on this now that n° 2 ☝ is implemented

Update: Adding the "Discussion" has been deprioritized for now because it would require too much time/effort when the focus needs to be on PDF upload. Once the PDF upload is implemented, the workaround will be to use that to get this ATBD public on APT.

@bwbaker1 would leaving out the discussion part in the document PDF download be a bigger negative point than the benefits of having a demo ATBD on production? Users could still see the discussion in the HTML view mode, which is what I'd assume we'd like to be showing off to the users of the tool. You all are the ATBD experts though, so I'll leave this decision for your side

@wrynearson Let's discuss this more at our tagup 5/15. It will be easier to give you more context then.


ASP.NET Core 2.1 Roadmap Update

Roadmap Update
I know ASP.NET Core 2.0 was just released, but it might be helpful for contributors and users alike to have an idea of what the roadmap for ASP.NET Core 2.1 is looking like. Is this something that can be updated here?
Thanks!

Enterprise Library ，Unity and AntiXss support net core?

We'll have @DamianEdwards get an update to this. I think he's a few thousand miles/kilometers/parsecs away from work right now, but I'm sure he can do this when he returns.

When I'm back, I'll update the roadmap and post a planning announcement over in aspnet/Announcements. In the meantime, folks can look at issues created in the 2.1 milestone in each of the repos to start getting an idea of what we're investigating for 2.1.

Awesome, sounds good, thank you!

Razor Pages support ASP.Net server controls or have server controls?

The MVC programming model to his advantage, but there are also disadvantages, page data and logic processing mainly by JS control, C# is only to the front-end data transfer function, the C# instead of weakening, the enhanced JS and web; from ASPX, aspx.cs aspx.cs played this way with powerful back-end processing capabilities of C#, not only can provide data, but also can process the front interface with C# display or logical processing; hope to use the Razor Pages Cs, play the powerful function of C#

It would be nice, if we can have T4 templates.

@ghd258 have a look at #blazor 😎 C# in the browser could provide a powerful client side programming model that would works with the DOM to give the user experience your looking for 😉

Any plans to support a more modular architecture? Something like OrchardCore  would be nice

@encrypt0r - for a more modular architecture please use OrchardCore - it's great!

cc @sebastienros - see above comment.

@Eilon indeed it is. But an official solution means that Visual Studio supports it much better. Currently you need some sort of hacks to get a decent experience.

@encrypt0r there are no plans at this time to have something built into ASP.NET Core, but the community has produced some great solutions to many problems that aren't solved in the core product.
We'd like to learn more about what hacks are required for this and where the Visual Studio experience isn't as good as you'd like. Some might be issues in OrchardCore, and some might be issues elsewhere in ASP.NET Core or Visual Studio.

@Eilon These are a couple of the issues I can think of right now:

You can't add Views and Controllers via Add New Item (And therefore no scaffolding) in a Net Standard library. I get it, Visual Studio is trying to help you by giving you only the list of things that it thinks are applicable to a class library. One way to solve that is to use Microsoft.Net.Sdk.Web
I get some weird compilation issues when trying to use razor pages in the modules.

@encrypt0r thanks for the info.
Adding @rynowak regarding this feedback on Razor because these are some areas that we're looking to improve in future releases.
Also adding @sebastienros because he's had to deal with some of these issues while working on Orchard Core and he might have some insights or tips & tricks on getting a better experience with what's already available.

I get some weird compilation issues when trying to use razor pages in the modules.

@encrypt0r - can you please log an issue on https://github.com/aspnet/MvcPrecompilation

@rynowak Actually, I can't reproduce that issue anymore. It could have been some issue with not referencing the right packages or something. Using the empty web project template for the modules makes the experience much better.

@encrypt0r - I've added your feedback about new item to a tracking item here https://github.com/aspnet/Razor/issues/1712
If you have more feedback about what's broken/missing from class library scenarios please add it there

@rynowak No that's all I had

So... No updates on the 2.1 roadmap yet?

@SanderDeclerck we've been doing some internal planning and I think very soon @DamianEdwards will be posting some public info.

If I could make some wishes in terms of features, then it would be @SteveSandersonMS's Angular template based on Angular CLI (seems to be almost done, so would be great to get it) and Health Checks.

+1 for Health Checks

@mpoettgen we're actually planning to ship the Angular-CLI based templates even before the next full release of ASP.NET Core. Certainly at least a preview.

I have been hunting for updates on 2.1 roadmap and there doesn't appear to be much available. We are stuck with a dependency on WS-Fed, which support was cut from 2.0, and I was hoping this would be making an appearance in the near future.

We have a preview of WS-Fed support out already, for use with 2.0.0

I wanted to compile views/pages in assemblies and reuse them somewhere else, but I couldn't. I think this needs to be addressed too.
https://stackoverflow.com/questions/47726991/how-to-reuse-views-pages-in-asp-net-core-mvc

@nefcanto we're working on a number of things that will help this scenario (in fact we had a meeting about it today). We'll share details in an issue soon.

Closing old discussion. Please log a new issue if you have a question about anything else.


Update peer dependency for Astro v2

I don't see anything in the release notes or migration guide that would indicate an issue with version 2.

Dependency version notation

The easier solution might be to remove the field entirely. I don't know how much value it adds, and I don't want to be forced to release if there are no breaking changes.

For the record, I went with removing the peerDependency entirely. We can always reintroduce it if/when there are version-specific APIs that we need from Astro.


First time install. Cannot pick up items

Describe the Bug:
I've installed the Modpack using Cursed Forge.
Stared just fine, on survival mode. But i cannot pick up anything, the blocks break but don't drop anything ( same with leafs, grass, branches and pebles)
Damage and hunger work, so does the quest jornal ( at least the initial quest)
How Can We Reproduce the Bug:
Fresh install with:

Modpack v <IP_ADDRESS>
Game version 1.20.1
Forge version 47.2.20

Expected behavior:
After breaking ( right button click) the item should be pickable.
If Applicable, Add Screenshots or Video to Explain the Bug:
Some people on reddit ( for other mods) mentioned toggle the touchscreen on/off and i've tried without success on both.

Someone mentioned that it might be on Adventure mode instead of survival.
I don't know how to check but i've deleted and created a new world and survival is the default - i left it as is.
Small video with the issue
https://mega.nz/file/Swx0DRYA#rpc8_PCiTMHkxp2U_CxM2Ng03hTvj38M-HS9QmyAO8g
Crash Report or Game Log
No crash.
Please complete the following information:

Have you checked if your bug has already been reported, including closed issues? : Y
Have you added or removed any mods, and if so, which?: N
Modpack Version Number : <IP_ADDRESS>
Is OptiFine installed? :  N ( i don't know what this is but haven't installed it manually)
Does this issue affect Server, Client, or Both? : Client ( only tried on client)

Additional context:

Not sure what this issue is, but it's happened to a few people yet we haven't been able to duplicate it.
You can resume playing the game normally if you enter the following command:
/gamerule doTileDrops true

Thank you Joel, for your response.
I'm not familiar with that command, can't seem to run it while ingame.
To do it, i've recreated the world and on that screen i see a Game Rules list, i was able to locate and turn it on that way but it did not work.


[Skype for Business] Code not working on Skype for business channel

System Information (Required)

SDK Language: Node Js
SDK Version: 3.8.4
Development Environment: Azure Bot Service

Issue Description
i have written small code for POC and its working like a charm on every channel like Skype, Emulator etc. but when i integrated this with Skype for business its for not working properly. few issues are like multiple root dialog messages, weird behavior for some users and now its showing "Opps something went wrong" error message even its working on other channels.
Please help us to resolve this as ASAP.

@gohilsagar Can you post your complete bot code that causes the issue?

// Code
var bot = new builder.UniversalBot(connector);
server.post('/api/messages', connector.listen());
/const { WitRecognizer } = require('botbuilder-wit');
// Alternatively, you can add a global recognizer to the bot
bot.recognizer(new WitRecognizer('OMA6J3GMQV43OCFXKIA3QKP7BJQCFDBT'));/
//=========================================================
// Bots Dialogs
//=========================================================
var rootFlow = new Enum(['payment', 'issue','Yes','No','Reset', 'StartGreeting','EmployeeData'],{ignoreCase:true});
const client = new Wit({accessToken: 'OMA6J3GMQV43OCFXKIA3QKP7BJQCFDBT'});
var commonAddress= {};
// On Error
bot.on('error', function(message) {
/* bot.send(new builder.Message()
.address(commonAddress)
.text('Error : ' +message));*/
console.log('[error] called' + message);
// Root dialog for entry point in application
bot.dialog('/', [
function (session,args, next) {
/if (session.dialogData.isRootShown === undefined || session.dialogData.isRootShown === false) {/
if (isShown === false) {
if (commonAddress !== undefined || commonAddress === {}) {
var commonAddress = session.message.address;
}
        session.send("Hey " + session.message.user.name.split(" ")[0] + ", Welcome to Innojam!");
        builder.Prompts.text(session, "Would you like to register?");
        session.dialogData.isRootShown = true;
        isShown = true;
    }
    else
    {
        isShown = false;
        next();
    }
},
function (session, results) {
    isShown = false;

if (results.response.toUpperCase().indexOf("NO") != -1) {
session.beginDialog('/ConversationEnd');
}
else if (results.response.toUpperCase().indexOf("YES") != -1) {
session.beginDialog('/UserRegistration');
}
},
function (session,results) {
session.endDialog();
}

@gohilsagar Can you provide some more detail on the issues you're running into with the Skype for Business channel, so we can help debug?  Specifically:

Were you able to successfully register the endpoint in your development tenant using the Skype for Business PowerShell cmdlets?  Any errors when creating the bot after you added the Channel and ran the PowerShell?
When messaging the bot from the Skype for Business client, does the bot respond with a specific error message?  Or not respond at all? A screenshot could help here.
Are you using Azure App Insights with your bot, or are you able to gather HTTP traces of any error you're receiving to your bot service code?  This can also help us with debugging.

@gohilsagar, Are you still running into this issue?

Closing issue due to inactivity.


GenerateDeltaDumpJob and UpdateOrganizationStatisticsJob are occasionally segfaulting

We're seeing segmentation faults for the UpdateOrganizationStatisticsJob and the GenerateDeltaDumpJob. These failed today (2021-10-13), as well as on 2021-10-01 and 2021-09-25.

Closing, because I think this was fixed by recent work by @cbeer and @corylown.


tributary uses the python 'graphviz' module, which comes from python-graphviz

(pygraphviz provides the pygraphviz module instead)

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add toolbar button to create job from current notebook

Problem
Users may not know that they can create a job or job definition from the current notebook.
Proposed Solution
In the current notebook, add a toolbar button to open the create-job form to create a job or job definition from the current notebook. As is the case when the user right-clicks on a file in the file browser, the form should be pre-populated based on the current notebook.

Proposed insertion point after "Restart Kernel & Run All Cells …"

This should be to the right of the built-in default toolbar items, which I believe would be to the right of the code type dropdown.


[DSL] Enable propertybag for game objects

Currently, the method of the CollisionComponent (added in https://github.com/Programmiermethoden/Dungeon/pull/154) is executed every frame. If this method calls back on logic defined in a DSL function, this logic will also be called every frame.
There are use-cases (e.g. opening an UI-element) for such DSL event handler functions, which should only handle the first occurrence of an event. This requires storage of information about the state (e.g. 'was this function called before?') in the context of the game object, for which the event is handled. This storage could in theory be implemented as another Component, but this would clutter up the ECS.
Therefore a game object definition should be able to hold a propertybag, which is independent from the other components of a game object definition. This propertybag should be accessible in the context of the game object.
Syntax example (the properties definition defines the propertybag):
game_object my_obj {
    comp1 {
        member1: 42,
        member2: "Hello"
    },
    properties {
        property1: 13,
        property2: "Moin"
    }
}

Estimated Requirements

Define, if the propertybag should be treated as any other `AggregateValue' or, if it should be an exceptional case

this will affect the SymbolTableParser, VariableBinder and DSLInterperter

Adding a new AggregateValue to the MemorySpace of the AggregateValue used to represent the game object instance

Das hier ist eigentlich outdated und die Use-Cases werden anders abgebildet, ich hatte auch vorallem an die Speicherung/Referenzierung eines Task in Entity gedacht, das machen wir ja mit TaskComponent bzw. TaskContentComponent.


libtorrent-rasterbar: 2.0.6 -> 2.0.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/arvidn/libtorrent/releases.
meta.description for libtorrent-rasterbar is: "A C++ BitTorrent implementation focusing on efficiency and scalability"
meta.homepage for libtorrent-rasterbar is: "https://libtorrent.org/"
meta.changelog for libtorrent-rasterbar is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.7 with grep in /nix/store/v6yri12qzagz3p7910gfymaxp56sf7fw-libtorrent-rasterbar-2.0.7
found 2.0.7 in filename of file in /nix/store/v6yri12qzagz3p7910gfymaxp56sf7fw-libtorrent-rasterbar-2.0.7

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
btfs
libtorrent-rasterbar
libtorrent-rasterbar-2_0_x
python310Packages.libtorrent-rasterbar
python39Packages.libtorrent-rasterbar
qbittorrent
qbittorrent-nox
springLobby

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v6yri12qzagz3p7910gfymaxp56sf7fw-libtorrent-rasterbar-2.0.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libtorrent-rasterbar https://github.com/r-ryantm/nixpkgs/archive/96843639d7761a613929dbaed8ecc2ca6e0479b0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v6yri12qzagz3p7910gfymaxp56sf7fw-libtorrent-rasterbar-2.0.7
ls -la /nix/store/v6yri12qzagz3p7910gfymaxp56sf7fw-libtorrent-rasterbar-2.0.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

btfs
libtorrentRasterbar (libtorrent-rasterbar ,libtorrentRasterbar-2_0_x)
python310Packages.libtorrent-rasterbar
python39Packages.libtorrent-rasterbar
qbittorrent
qbittorrent-nox
springLobby

Maintainer pings

@ofborg test deluge qbittorrent


[SPARK-GREENPLUM-5] Set a timeout for copy operation, which copies a partition's data to greenplum. #10

What changes were proposed in this pull request?
I add a copyTimeout option to GreenplumOptions.
And for each partition, I start a copy thread and check the copy thread's state.
The exception of copy thread would be throwed and if the copy thread has been running for more than the copyTimeout, a timeout exception would be throwed.
Otherwise, the copy operation is completed in timeout.
How was this patch tested?
Existing unit test.

I have implemented a method to check the state of copyThread instead of using callable.
@yaooqinn


Intellisense for instantiation of abstract classes

VSCode Version: 1.24.1
OS Version: Windows 10 1803

Steps to Reproduce:

Create an abstract class

abstract class abc {}

Type in new <ctrl + space> => The abstract class will be suggested. If you accept the proposal, you will get an an error (abstract classes can't be instantiated)

Does this issue occur when all extensions are disabled?: Yes

This issue was moved to Microsoft/TypeScript#25234


Performance improvements

Motivation and Context
In an attempt to make the to-do page on frontstage even quicker, We've decided that adding an index  on the case table for the partyid would help increase the speed. It will also now pass in a IAC boolean so it can skip adding the iac which removes another DB calls
What has changed

Added an index on the case table for the partyId column
Added boolean check on IAC so it can be skipped

How to test?

Run with frontstage PR
Run the acceptance tests
Open up the todo page and make sure everything is working such as accessing survey and completing it.

Links
Trello

The code looks reasonable, though I'm not well versed enough in it to approve it I feel.
Just to make sure I understand, when we search for cases, we already know if there's an iac for it already?  Which is why we can only do that extra step if we know that one needs to be set?


Full test plan for the normal user and domain admin user

Note: for User role test exclude after Account/User feature, for DomainAdmin role exclude after Infrastructure (except for Offerings)
Common

[X] Project selector
[X] Language selector
[X] Notifications / clear notifications
[X] Paginations
[X] Profile
[X] Help
[X] Logout
[X] Context-sensitive help

Dashboard

[X] Fetch latest (only on Admin dashboard)
[X] View hosts in alert state
[X] View alerts
[X] View events

Compute > Instances

[X] Basic search
[X] Extended search
[X] Sort
[X] Links
[X] Filter by
[X] Create new instance

Compute > Kubernetes
This requires configuring and setting up CKS: http://docs.cloudstack.apache.org/en/latest/plugins/cloudstack-kubernetes-service.html

[X] Basic search
[X] Extended search
[X] Sort
[X] Links
[X] Filter by
[X] Add Kubernetes cluster
[X] Start/stop a Kubernetes cluster
[X] Scale Kubernetes cluster
[X] Upgrade Kubernetes cluster
[X] Delete Kubernetes cluster

Compute > Instances > selected instance

[X] View console
[X] Reboot instance
[X] Update instance
[X] Start/Stop instance
[X] Reinstall instance
[X] Take snapshot
[X] Assign VM to backup offering
[X] Attach ISO
[X] Scale VM
[X] Migrate instance to another host
[X] Change affinity
[X] Change service offering
[X] Reset Instance Password
[X] Assign Instance to Another Account (VM must be stopped)
[X] Network adapters
[X] - Add network to VM
[X] - Set default NIC
[X] - Add/delete secondary IP address
[X] - Delete VM network
[X] Settings
[X] - Add setting
[X] - Update setting
[X] - Delete setting
[X] Add / delete comment
[X] Add / delete tags
[X] Links

Compute > Instance groups

[X] Search
[X] Sort
[X] Links
[X] New instance group

Compute > Instance groups > selected instance group

[X] Links
[X] Update instance group
[X] Delete instance group

Compute > SSH Key Pairs

[X] Search
[X] Sorting
[X] Links
[X] New SSH key pair

Compute > SSH Key Pairs > selected SSH key pair

[X] Links
[X] Delete SSH key pair

Compute > Affinity Groups

[X] Search
[X] Sort
[X] Links
[X] New affinity group

Compute > Affinity Groups > selected affinity group

[X] Links
[X] Delete affinity group

Storage > Volumes

[X] Basic search
[X] Extended search
[X] Sort
[X] Links
[X] Create volume
[X] Upload local volume
[X] Upload volume from URL

Storage > Volumes > selected volume

[X] Detach volume
[X] Take a snapshot
[X] Recurring snapshot
[X] Resize volume
[X] Migrate volume
[X] Download volume
[X] Delete volume
[X] Links
[X] Add/delete tags

Storage > Snapshots

[X] Basic search
[X] Extended search
[X] Sort
[X] Links

Storage > Snapshots > selected snapshot

[X] Links
[X] Add/delete tags
[X] Create template
[X] Create volume
[X] Revert snapshot
[X] Delete snapshot

Storage > VM Snapshots

[X] Basic search
[X] Extended search
[X] Sort
[X] Links

Storage > VM Snapshots > selected snapshot

[X] Links
[X] Add/delete tags
[X] Revert VM snapshot
[X] Delete VM snapshot

Storage > Backups
Network > Guest networks

[X] Basic search
[X] Extended search
[X] Sort
[X] Links
[X] Add network

Network > Guest networks > selected network

[X] Links
[X] Add/delete tags
[X] Update network
[X] Restart network
[X] Delete network
[X] Acquire new IP (only for isolated networks)
[X] Replace ACL list(only for VPC isolated networks)
[X] Delete public IP address (only for isolated networks)
[X] Add/delete egress rule (only for isolated networks)

**Network > VPC **

[X] Basic search
[X] Extended search
[X] Sort
[X] Links
[X] Add VPC

Network > VPC > selected VPC

[X] Links
[X] Update VPC
[X] Restart VPC
[X] Delete VPC
[X] Networks
[X] - Links
[X] - Paginations
[X] - Add network
[X] - Add internal LB
[X] Public IP addresses
[X] - Links
[X] - Pagination
[X] - Select tier
[X] - Acquire new IP
[X] - Delete IP address
[X] Network ACL Lists
[X] - Links
[X] - Pagination
[X] - Add network ACL list
[X] Private Gateways
[X] - Links
[X] - Pagination
[X] - Add private gateway
[X] VPN Gateway
[X] - Links
[X] VPN Connections
[X] - Links
[X] - Pagination
[X] - Create Site-to-site VPN connection
[X] Virtual routers
[X] - Links
[X] - Add/delete tags

Network > Security groups

[X] Search
[X] Sort
[X] Links
[X] Add security group

Network > Security groups > selected security group

[X] Links
[X] Add/delete tags
[X] Add ingress rule by CIDR
[X] Add ingress rule by Account
[X] Ingress rule - add/delete tags
[X] Ingress rule - delete
[X] Add egress rule by CIDR
[X] Add egress rule by Account
[X] Egress rule - add/delete tags
[X] Egress rule - delete
[X] Ingress/egress rules pagination

Network > Public IP Addresses

[X] Search
[X] Sort
[X] Links
[X] Acquire new IP

Network > Public IP Addresses > selected IP address

[X] Links
[X] Add/delete tags
[X] Enable/Disable static NAT
[X] Release IP
[X] Firewall - add rule
[X] Firewall rule - add/delete tags
[X] Firewall rule - delete
[X] VPN - Enable/Disable VPN
[X] VPN - Manage VPN Users

Network > VPN Users

[X] Links
[X] Search
[X] Sort
[X] Add VPN user

Network > VPN Users > selected VPN user

[X] Links
[X] Delete VPN User

Network > VPN Customer Gateway

[X] Links
[X] Basic search
[X] Extended search
[X] Sort
[X] Add VPN Customer Gateway

Network > VPN Customer Gateway > selected gateway

[X] Links
[X] Edit VPN Customer Gateway
[X] Delete VPN Customer Gateway
[X] Add/delete tags

Images > Templates

[X] Links
[X] Basic search
[X] Extended search
[X] Sort
[X] Change order (move to the top/bottom, move one row up/down)
[X] Register template
[X] Upload local template

Images > Templates > selected template

[X] Links
[X] Add/delete tags
[X] Edit template
[X] Copy template
[X] Update template permissions
[X] Delete template
[X] Download Template
[X] Zones pagination
[X] Settings - add/edit/remove setting

Images > ISOs

[X] Links
[X] Basic search
[X] Extended search
[X] Sort
[X] Change order (move to the top/bottom, move one row up/down)
[X] Register ISO
[X] Upload local ISO

Images > ISOs > selected ISO

[X] Links
[X] Add/delete tags
[X] Edit ISO
[X] Download ISO
[X] Update ISO permissions
[X] Copy ISO
[X] Delete ISO
[X] Zones - pagination

Images > Kubernetes ISOs

[X] Links
[X] Basic search
[X] Sort
[X] Refresh
[X] Pagination
[X] Enable/Disable
[X] Add Kubernetes Version

Projects

[X] Links
[X] Basic search
[X] Extended search
[X] Sort
[X] Switch to project
[X] New project
[X] Project invitations

Projects > selected project

[X] Links
[X] Add/delete tags
[X] Edit project
[X] Suspend/Activate project
[X] Add account to project
[X] Accounts - Make account project owner
[X] Accounts - Remove account from project
[X] Delete project
[X] Accounts - pagination
[X] Resources - edit

Events

[X] Links
[X] Basic search
[X] Extended search
[X] Sort
[X] Archive event
[X] Delete event

Events > selected event

[X] Links
[X] Archive event
[X] View event timeline
[X]  Delete event

Users

[X] Links
[X] Search
[X] Sort
[X] Add user

Accounts

[X] Links
[X] Search
[X] Sort
[X] Add account

Accounts > selected account

[X] Links
[X] Update account
[X] Update resource count
[X] Disable/enable account
[X] Lock/unlock account
[X] Add certificate
[X] Delete account
[X] Settings

Users > selected user

[X] Links
[X] Edit user
[X] Change password
[X] Generate keys
[X] Disable/enable user
[X] Delete user
[X] Copy API Key
[X] Copy Secret Key

Domains

[X] Search
[X] Expand/collapse
[X] Add/delete note
[X] Add domain
[X] Edit domain
[X] Delete domain
[X] Update resource count
[X] Settings

Offerings > Compute offerings

[X] Links
[X] Search
[X] Sort
[X] Add offering

Offerings > Compute offerings > selected offering

[X] Links
[X] Edit offering
[X] Update offering access
[X] Delete offering

Offerings > Disk offerings

[X] Links
[X] Search
[X] Sort
[X] Change order (move to the top/bottom, move one row up/down)
[X] Add offering

Offerings > Disk offerings > selected offering

[X] Links
[X] Edit offering
[X] Update offering access
[X] Delete offering

Tools

[X] comments

Did not find any major UI issue with User and domain admin ( Role) account

@borisstoyanov please add the tag testing

Thanks @kiranchavala ! If you're done with the effort I think it's safe to close the issue


Is there another way to distribute typings.d.ts?

TypeScript as a dev dependency adds 33MB to node_modules. I want to support TypeScript, but I don't want to add this weight to every Hyperapp install. Is there any way we can still distribute typings.d.ts without having TypeScript as a dev dependency on this repo?
What other options do we have?

We could publish the typings to DefinitelyTyped and tell users that want TypeScript support to install them via npm install @typings/hyperapp. On the other hand if we are in the TypeScript zone already we don't we write the library itself in TypeScript. Andre Staltz argues that "All JS Libraries should be authored in TypeScript
" (or another typed JS layer) and I kinda agree with him.

I'm a bit confused - I thought that TypeScript support comes from adding "typings": "hyperapp.d.ts" to our package.json and including that file when we publish.
I also thought the only reason we install TypeScript was to run the test that verifies our typings match the current library code. We could move this verification to another project since hopefully the API changes should be minimal in a post 1.0.0 world 🙏

The best place for typings are DefinitelyTyped and flow-typed if source code is plain javascript because they have tests for typings, compatibility checks with typed language version, etc.
I vote for removing typings from core :)

So if we do decide to publish on DefinitelyTyped instead, that might raise the question again of where our API docs are. I think we're going to need to write some if we want to be taken seriously and increase adoption. With the stable 1.0.0 API, this should be worth the effort.

@okwolf Where are they now?

@JorgeBucaran I thought our current answer is that hyperapp.d.ts is our only API documentation.

@okwolf Gotcha. Yeah, you are right.

Is having TypeScript as a dev dependency a big deal? The only people this matters to are the people are clone the project and install its dependencies.

@Seikho We would lose some of that if we removed the typings from this repo. As a compromise, we could ship the typings, but not require TypeScript as a dependency like @okwolf said.

And how about maintaining our own typing repo ?
People will install @hyperapp/typed and we will be able to provide types for Typescript, Flow, Reason, whatever without noise in the main repository

That's another good idea.

Please don't remove the typings from the repo. Just leave it there and remove the typescript dependency as people who use typescript have it probably already installed anyway.

@alber70g I am without. I hate using DefinitelyTyped and it is really a please to only have to depend on the lib you want to use (Hyperapp) instead of having to depend on one more package to have the types.
Do not forget we will have to do the same with the router and html.
  "dependencies": {
    "@hyperapp/HTML": "^0.5.1",
    "@hyperapp/router": "^0.4.1",
+  "@types/hyperapp": "^1.0.0",
+  "@types/hyperapp-html": "^0.5.1",
+  "@types/hyperapp-router": "^0.4.1",
    "hyperapp": "^1.0.0"
  }

We could also make TypeScript and optional dependency. If you don't want to install it you run npm install --no-optional

I'm late to the party and don't have much new to add to the thread, but having used TS for a while here are my 2cs

Writing a library in TS means the typings are guaranteed to be be correct. As mention the typings are the AP docs. This is ideal
It's easy to build and publish the library npm package so that both the pure JS and typings are included. Thus it's usable by JS or TS users without any extra effort. This is ideal and now the preferred way according to TS community.
Yes the typings will be included in using codes deps (node_modules) but it's dev only and they don't end up in the built app bundle.
definitelyTyped is still available but depreciated. Ambient types for JS libs are now published under npm @types/*. VSCode is really good at finding the correct typings wherever they are but other tools need more help.
TSC replaces babel for transcompiling to ES5, though you still need polyfils for promises etc. TSC is pretty flexible in what ES version you target.
You can gradually migrate the code to TS , but then the typings will not be complete unless you maintain them separately. Also you can now add type docs in JS files for the compiler to see, but I doubt typings are created in this case (i've not checked)

My preference would be be to get to the point where the library is written in TS and published with the typings in npm package for anyone using TS. However I accept this is extra work for the library maintainers and the types can get pretty complex, especially  when generics are used (see cyclejs)

@timjacobi Not too bad :)
@SteveALee Please see https://github.com/hyperapp/hyperapp/issues/494

@JorgeBucaran yeah, the 2 are tightly coupled :)

@JorgeBucaran Hmm, I got a bit carried away and answered more than this issues. Sorry
Given the typings are to be maintained separately from the javascript (#494) they are so called ambient types like any others in definitetyped etc. As a TS user I'd like them to be easily available and while that means having them in the main npm package I'd still accept them being available via adding @types/hyperapp as another dependency, especially as I believe @code will still find them anyway (if names are consistent).

@timjacobi's or @okwolf suggestions are pretty good :)


🐛 Failed to load plugin "slides-extended" v2.1.4 on MacOS

Input data (markdown source)
N/A
Expected Behavior
Expected plugin to update and load successfully.
Current behaviour
When plugin Enable is attempted, pops up error message 'Failed to load plugin "slides-extended"', does not enable.
Steps to reproduce

Launch Obsidian Sandbox
Go to Settings -> Community Plugins
Browse, find Slides Extended
Click Install
Click Enable
Plugin does not enable, but instead produces 'Failed to load plugin "slides-extended"' message

Environment: M3 Macbook Pro, macOS Sequoia 15.1.1, Obsidian 1.7.7, Slides Extended 2.1.4
Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[X] macOS
[ ] Windows

Obsidian Version
1.7.7
Slides Extended Plugin Version
2.1.4
Checks

[X] I have tried it in the sandbox vault with only this plugin enabled

Possible solution
No response

will have a look, thanks

I just tried this on the sandbox vault with no issues (on a mac).
Can you try it in the sandbox vault?
Alternately:

Uninstall the plugin
Restart Obsidian
Open the developer console
re-install the plugin.

If it fails, please include any messages related to slides extended from the console.

Failed in my sandbox vault also.  It succeeds on the Install, but fails on Enable.

Here is the saved Developer Console log:
app.js:1 Obsidian Developer Console
app.js:1 Plugin failure: slides-extended TypeError: dte.tracingChannel is not a function
    at eval (plugin:slides-extended:8:37744)
    at eval (plugin:slides-extended:6:330)
    at eval (plugin:slides-extended:8:38470)
    at eval (plugin:slides-extended:6:330)
    at eval (plugin:slides-extended:109:14388)
    at eval (plugin:slides-extended:6:330)
    at eval (plugin:slides-extended:367:26992)
    at eval (plugin:slides-extended:6:330)
    at anonymous (plugin:slides-extended:475:21425)
    at e.<anonymous> (app.js:1:2199465)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
Promise.then (async)
l @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
e.enablePlugin @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
e.enablePluginAndSave @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
(anonymous) @ app.js:1

Thank you for your work on this plugin.  I'm teaching coding to a couple of grade-schoolers and it's been very helpful.

The same for me.
Input data (markdown source)
N/A
Expected Behavior
Expected plugin to update and load successfully.
Current behaviour
When plugin Enable is attempted, pops up error message 'Failed to load plugin "slides-extended"', does not enable.
Steps to reproduce
Launch Obsidian Sandbox
Go to Settings -> Community Plugins
Browse, find Slides Extended
Click Install
Click Enable
Plugin does not enable, but instead produces 'Failed to load plugin "slides-extended"' message

Environment: ASUS, Windows 11, Obsidian 1.7.7, Slides Extended 2.1.4
Which Operating Systems are you using?
Android
iPhone/iPad
Linux
macOS
Windows

Obsidian Version
1.7.7
Slides Extended Plugin Version
2.1.4
Checks
Possible solution
No response
this is the  copy of devtools:
Plugin failure: slides-extended TypeError: dte.tracingChannel is not a function
at eval (plugin:slides-extended:8:37744)
at eval (plugin:slides-extended:6:330)
at eval (plugin:slides-extended:8:38470)
at eval (plugin:slides-extended:6:330)
at eval (plugin:slides-extended:109:14388)
at eval (plugin:slides-extended:6:330)
at eval (plugin:slides-extended:367:26992)
at eval (plugin:slides-extended:6:330)
at anonymous (plugin:slides-extended:475:21425)
at e. (app.js:1:2199465)
at app.js:1:237228
at Object.next (app.js:1:237333)
at a (app.js:1:236051)

I have the same issue here.
I'm on Windows, and there's something wrong with version 2.1.4.
I have reinstalled the v2.1.3, and there is no problem

ok. I've reverted fastify. I think the reference to the tracingChannel was added in the more recent version. It is weird that I don't see the issue locally with the sandbox vault... makes it difficult to test/understand.

Release is in flight. If you could both pick up 2.1.5 when it is available and LMK if it is ok, that would be lovely.

The 2.1.5 update works for me!

which installer are you using?

I am just installing from the Community Plugins Browse panel in Obsidian, and clicking on the Install button.

Ah, sorry.  Obsidian Installer 1.5.8.

AH HA. The latest installer is 1.7.5. You're considerably behind.

The latest installer is 1.7.5.

I updated it just now and got Installer 1.7.7.
I'm fairly new to Obsidian and did not realize the installer was a separate entity that needs to be updated.  Thanks.


Adapt latest kfserving and training oprator

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #563 ，fixes #565
fixes the dependence is too old.

use newest kfserving 0.6.1 , which same version like kubeflow-components-versions

update to newest training job 1.3.0，kubeflow-tfjob and kubeflow-pytorchjob even never maintain.

@jinchihe  please review


Apply fixed/pattern values in ResourceForm

How should fixed/pattern values be applied to a resource in ResourceForm? At a high level, the two most likely approaches would either be:

at load time, i.e. as the ResourceForm and the tree of input components included in it are setup.
at save time, i.e. when the user clicks OK to save the resource, merge in all fixed/pattern element values into the resource before submitting it to the server to be validated and saved.

The load-time option is preferential since it would allow feedback to the user of which values are fixed and should not (or cannot) be edited so that they don't attempt to fill in values that would only inevitably lead to validation errors. At a high level, the algorithm would be as follows:

For required array elements (element.min > 0), create up to min placeholder values

For elements with fixed/pattern values within a required element, apply the fixed/pattern value to the placeholder.

For optional array elements (element.min === 0), do NOT create any placeholder values

For elements with fixed/pattern values within an optional element, only apply them to existing entries

When a new array/slice entry is added (i.e. the user clicks the Add button), for both required and optional elements, apply same logic as above.
For non-array elements, (element.max === 1), apply fixed/pattern values, but track that they were applied be default and do not include them in a save request if the user doesn't change anything else in the element.

The application of fixed/pattern values should be centralized rather controlled by individual inputs. The most obvious location is within ElementContext since all elements shown in a form are contained within an ElementContext. Since applying cardinality & fixed/pattern values requires profile & extensions schemas to be loaded, it must be possible for fixed/pattern values to be applied at various depths within a resource; not just at ResourceForm or the top-most BackboneElementInput. ElementContext also fits nicely with this requirement since a new context is already necessary when a type schema is fetched from the server.
When displaying fixed/pattern elements:

Display the input in a disabled/read-only state with a tooltip explaining "This value is required by the US Core Patient profile"
If the resource has an existing value that does NOT conform to the fixed/pattern value, highlight it as an error with a message/question mark icon explaining it does not conform along with a button to set the value to the fixed/pattern value. The guiding principle here is that an existing value should never be changed automatically; the user must explicitly opt-in to the change.

What to do with custom input components that ignore some sub-elements that could have a non-zero min or fixed/pattern values? For example, QuantityInput shows value, comparator, unit but ignores system, code. They should mostly just work as if they were hidden form fields. The one exception being when the existing element values that do NOT conform to fixed/pattern values. In that case, a message should be shown for the input similarly as described above: a message is shown for the QuantityInput explaining that there the non-conforming values along with a button to set the hidden values to the required fixed/pattern values.

Thanks @mattlong, lots of good thinking here.  Responses inline:

at load time, i.e. as the ResourceForm and the tree of input components included in it are setup.

Agree

at save time, i.e. when the user clicks OK to save the resource, merge in all fixed/pattern element values into the resource before submitting it to the server to be validated and saved.

This will happen on server regardless, but agree that it's less useful in UI.

For required array elements (element.min > 0), create up to min placeholder values

For elements with fixed/pattern values within a required element, apply the fixed/pattern value to the placeholder.

Makes sense 👍

For optional array elements (element.min === 0), do NOT create any placeholder values

For elements with fixed/pattern values within an optional element, only apply them to existing entries

Clarifying question:  the element is "optional", but if an element exists, then it must satisfy the fixed/pattern value?
That makes sense.

When a new array/slice entry is added (i.e. the user clicks the Add button), for both required and optional elements, apply same logic as above.

👍

For non-array elements, (element.max === 1), apply fixed/pattern values, but track that they were applied be default and do not include them in a save request if the user doesn't change anything else in the element.

🤔
If min === 0, then my assumption would be that we show empty form element.  If min === 0 and it is fixed value, would the optimal UX be a checkbox?  Because it's effectively there or not?
If min === 1, then agree, we should just show the value.  I would assume that we would include it in the submission in that case though.

The application of fixed/pattern values should be centralized rather controlled by individual inputs. The most obvious location is within ElementContext since all elements shown in a form are contained within an ElementContext. Since applying cardinality & fixed/pattern values requires profile & extensions schemas to be loaded, it must be possible for fixed/pattern values to be applied at various depths within a resource; not just at ResourceForm or the top-most BackboneElementInput. ElementContext also fits nicely with this requirement since a new context is already necessary when a type schema is fetched from the server.

Makes sense 👍

When displaying fixed/pattern elements:

Display the input in a disabled/read-only state with a tooltip explaining "This value is required by the US Core Patient profile"

👍

If the resource has an existing value that does NOT conform to the fixed/pattern value, highlight it as an error with a message/question mark icon explaining it does not conform along with a button to set the value to the fixed/pattern value. The guiding principle here is that an existing value should never be changed automatically; the user must explicitly opt-in to the change.

That sounds like a good compromise.  It's a tricky situation, but this seems about as good as we can get.
Maybe optimal UI would be a simple button for "fix this", which would swap in the required fixed value.  But that can be future work.

What to do with custom input components that ignore some sub-elements that could have a non-zero min or fixed/pattern values? For example, QuantityInput shows value, comparator, unit but ignores system, code. They should mostly just work as if they were hidden form fields. The one exception being when the existing element values that do NOT conform to fixed/pattern values. In that case, a message should be shown for the input similarly as described above: a message is shown for the QuantityInput explaining that there the non-conforming values along with a button to set the hidden values to the required fixed/pattern values.

These are good questions.  I don't think it's P1 to solve them all, but it's worth thinking about.
One idea we have discussed in the past is updating <BackboneElementInput> to support a horizontal/row configuration, such that all of our specialty input components could use that.  There's a lot of complexity in there (when do you use row mode?  do you still show all fields?  what about help text and labels?), but that would probably lead to the "right" solution.

Overall, I think all of these proposals sound good, and definitely on the right track.  Personally, I'm comfortable with some 80/20 thinking here, and we can figure out the long tail edge cases in future revs.


curColWidth property access problem

I have the following three lines in controllerA in order to access the width of each cell defined in gridster:
var gridsterScope = angular.element("div[gridster]").scope();
console.log(gridsterScope.gridster);
console.log(gridsterScope.gridster.curColWidth);

I tried to monitor the output thru Chrome Developer Console.  I can see the second line and output the whole object including curColWidth (value is 116.4375).  My purpose is to use curColWidth to calculate actual gridsterItem actual width in px instead of number of cell.  However, I got undefined error at the third line.  I have no idea why can't access curColWidth property.  Anyone can help?

I think you have a race condition.  In Chrome, when you console.log an Object, the tree that is displayed will synchronize with the object as it gets updated, so will see values that are set after the console.log(gridsterScope.gridster) call.  However, since curColWidget is initially undefined and it is not an object with keys that update, your console output stays undefined.
You probably just have to let another watch cycle run to get that value.


this fixes the XR_ERROR_ACTIONSETS_ALREADY_ATTACHED error

With this change HTC trackers work in Unreal with the Varjo runtime.

thanks for the contribution. will remove the OnBeginSession override


Sharing content

Is there any way to share the tweet or content through link from fritter app?

Not currently, but I'll add it to the roadmap!


[SPARK-22284][SQL] Fix 64KB JVM bytecode limit problem in calculating hash for nested structs

What changes were proposed in this pull request?
This PR avoids to generate a huge method for calculating a murmur3 hash for nested structs.
Description will be updated with generated code.
How was this patch tested?
Added new test to HashExpressionsSuite

Test build #83010 has started for PR 19563 at commit bb9191f.

Test build #83010 has finished for PR 19563 at commit bb9191f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83010/
Test FAILed.

Merged build finished. Test FAILed.

Test build #83017 has started for PR 19563 at commit 67d1e58.

Test build #83017 has finished for PR 19563 at commit 67d1e58.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83017/
Test PASSed.

ping @cloud-fan

Test build #83082 has started for PR 19563 at commit 63c3a07.

Test build #83082 has finished for PR 19563 at commit 63c3a07.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83082/
Test PASSed.

Test build #83185 has started for PR 19563 at commit 70c2304.

Test build #83185 has finished for PR 19563 at commit 70c2304.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83185/
Test PASSed.

thanks for addressing the comments @kiszk , now it LGTM

LGTM

Test build #83690 has started for PR 19563 at commit 7947ca2.

Test build #83690 has finished for PR 19563 at commit 7947ca2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83690/
Test PASSed.

thanks, merging to master/2.2!


CTRL+A in the search field (and other dialog text fields) should select the text in the text input

Similar to how CTRL+A works across most of the programs I use, I would expect it to select all text in the currently focused text field.

Yes, the ZInputBox widget is currently missing selection support.
I've opened tuiwidgets/tuiwidgets#3 for tracking the needed work in tui widgets. Likely this only works well if also tuiwidgets/tuiwidgets#4 is implemented.


Chore/add CI

Add basics CI that tests the project with using rust nightly build.

Test project using cargo test
Build project using cargo build

Merged and confirmed we have passing builds on the action. Great work!


Cosinder adding dependabot for automatic dependency updates

It's just a simple config file 🙃.
However I'm not sure if you want to deal with automatic dependency updates at this point.

We're waiting until we're fully on GraalVM23 (for 0.26.0-dev we're now dropping JDK11 support) and Gradle 8.x, but then, yes, definitely want dependabot

I prefer renovate-bot (used by JUnit etc.), but either bot is a big step forward. Sending manual PRs with dependency updates is time-consuming and should be automated away as much as possible.


Silently handle errors writing analytics data

Linked to Zendesk issue
gz#268

Resolved in v2.5.0


Allow for alignment / packing settings

Currently, I don't know of any way to automagically get the same padding as the C compiler, but maybe we could add some way for it to know at least to align up to 4 bytes, or something like that.

That seems like it could be tricky considering how different C compilers can pack completely differently... but it might be worth thinking about.

Should alignment propagate from the top-level message object to all elements?  like the Big/Little endian flag?

I was thinking, at least initially, we could do something similar to:
m = Message([
   ....
], Mode, alignment=4)

maybe later that could be more complex, but that would at least let you add some auto padding.

Oh, and another thing is, for messages where we have
m = Message([
    ...
    this: {
        enum.value: MessageType
        ....
    },
])

Maybe we could add some of alignment / padding for those, to automatically put padding behind smaller objects.
That might be a different issue.

I like it, it's a simple parameter for the Message object.  It should be passed recursively to every individual field so that:

each field can pad itself out to the specified alignment on packing, and make sure to consume the necessary number of bytes when unpacking.
each field that contains Message objects can pass the alignment on to each of those elements.

And if we find in the future that we need to handle alignment differently, then we can always change it.  But it keeps it simple for now.

you know.  this is something that should be standard.  Perhaps the Element class should have pack/unpack functions that are called by the other element objects after they are done, and the high-level element class will handle global things like managing alignment?
If necessary then the individual elements can not call the parent pack/unpack if they have to manage data in a different way.

That seems like a good idea.
It might be difficult to enforce alignment for an item that has multiple items inside of itself (like elementvariable).
If alignment is 4, and they have a length 9 element, would we expect it to pack each one next to each other, or 9 data, 3 pad, 9 data, 3 pad. Not sure how we would handle it when that is the case. I do prefer if more happens standard in the Element class.

I think that works ok in this case, because then the alignment is passed to the Message object referenced by the elementvariable, and that Message object when packed or unpacked will consume the correct alignment of bytes.
That would be an example where it wouldn't be necessary to call the parent class's pack/unpack function to get the correct alignment.


More compiler stuff

Handling multiple output keys
Metagraph DAGs automatically optimize if the final result is a Metagraph object.  All compilers referenced in the DAG are used, although this has only been tested on DAGs with a single compiler.

Thanks for review!  I think I've resolved the suggestions.


The library is not compatible with python-dotenv 0.21.0

I am trying to install the latest ipfabric library to the environment where I already have python-dotenv version 0.21.0. When adding the ipfabric library using poetry I get the following error:
  SolverProblemError

  Because ipfabric (5.0.7) depends on python-dotenv (>=0.20.0,<0.21.0)
   and no versions of ipfabric match >5.0.7,<6.0.0, ipfabric (>=5.0.7,<6.0.0) requires python-dotenv (>=0.20.0,<0.21.0).

  at ~/.poetry/lib/poetry/puzzle/solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

I guess, changing the following line to python-dotenv = "^0.20" would help to solve the issue:
https://github.com/community-fabric/python-ipfabric/blob/e3b54de3780fcc4696f5bf873f4a012b1293e132/pyproject.toml#L26

#146


Set MaxItems to 1 for pb.spec.subjects

The propagator only handles first matching subject in placementbinding.
See https://tinyurl.com/yrtd6e4r. Add this restriction to CRD.
Signed-off-by: Yu Cao<EMAIL_ADDRESS>

/hold

The beginning of the loop skips subjects if they don't match the right group, kind, and name: https://github.com/open-cluster-management/governance-policy-propagator/blob/6e85f433a93f64efa7da423bab1e2281d1069775/controllers/propagator/propagation.go#L230
Honestly I don't know what the purpose of that is, but it is a case where more than one subject could be processed.

@JustinKuli You are right. The placement binding was used by apps before. It is now only used by GRC. So I won't expect user is going to bind a non policy subject. It's probably better to further restrict the subject to only allow either Policy or PolicySet and remove the API check code block.

@mprahl @JustinKuli I have made some further change based on @JustinKuli 's comments.

/unhold


fix webpack generating window reference in build

The current build uses webpack 4, which outputs an undefined
window reference and causes
ReferenceError: window is not defined

to repro you can visit
https://npm.runkit.com/cache-control-parser
and click run

Thanks @whacked

Version 1.0.6 will be published automatically to npm


How to include items from "Show all" list, in your toolbox?

I'm trying to figure out how to add items, which are shown in the "Show all" list of toolbox items, to my general list of toolbox items - But haven't found this subject described anywhere.
The "Show all" list contains elements I'm interested in seeing in my toolbox, but there doesn't seem to be any way for me to include those items. Clicking "Choose items" will open a dialog which will allow me to select between 5 different categories of components, to add to the toolbox, but these do not include the same items as are displayed in the "Show all" list.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f92855d-5247-0ffa-ef6f-cb654d7b26a7
Version Independent ID: 54b3a6ba-badb-29c0-f3b4-f013414263aa
Content: Toolbox window - Visual Studio
Content Source: docs/ide/reference/toolbox.md
Product: visual-studio-windows
GitHub Login: @gewarren
Microsoft Alias: gewarren

I'm guessing that this is a product design flaw. To make sure that this problem is logged in the right place, please use the Report a Problem tool. When you do this, your report becomes part of the work items that are tracked on Visual Studio Developer Community, which allows you to engage directly with the engineering team while they address and fix the problem.


chore(tech-snacks): add jest snack

Add snack to change mounts to shallows.

I see this isn't needed since all cases of mount are already used to find nested elements in developer-friendly manner.


Using valuesFrom causes no deployment

Hi, I'm trying to make use of the valuesFrom feature to replace the inline values definition, but for some reason when I add this to my yaml, the deployment is not executed.
I also don't see any error log in the helm controller or anything.  The specified config map is there, in the same namespace and with a key named values.yaml containing the config.
I'm using:

helm-controller:v0.11.1
kustomize-controller:v0.13.2
notification-controller:v0.15.0
source-controller:v0.15.3

Is there any way I can debug this issue?

Can you please share a minimal example that creates a reproducable result; or at least share a (redacted) version of your HelmRelease resource and ConfigMap, and the output of kubectl describe helmrelease <name>?
This would help me understand your issue better.

Sure thing...
Config:
apiVersion: v1
kind: ConfigMap
metadata:
  name: prometheus-msteams
  namespace: monitoring
data:
  values.yaml: |
    connectors:
      - tech: https://etc.com

Helm:
---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: company-prometheus-msteams
  namespace: flux-system
spec:
  chart:
    spec:
      chart: prometheus-msteams
      sourceRef:
        kind: HelmRepository
        name: prometheus-msteams
  interval: 1m0s
  releaseName: company-prometheus-msteams
  targetNamespace: monitoring
  valuesFrom:
    - kind: ConfigMap
      name: prometheus-msteams

Source:
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmRepository
metadata:
  name: prometheus-msteams
  namespace: flux-system
spec:
  interval: 1h0m0s
  url: https://prometheus-msteams.github.io/prometheus-msteams/

kubectl describe helmrelease <name> gives no output... helm release is never deployed so not found.

That did it, thanks.
Using flux get all --all-namespaces I figured out that:
could not find ConfigMap 'flux-system/prometheus-msteams'
Now that I think of it, it actually makes sense that during deployment it will look in the configured metadata namespace, and not the target namespace.
Thanks again!

Closing this as the issue has been resolved :-)


SQL DB Localization needs to be fixed for some elements

Azure Data Studio Version:
OS Version:

Steps to Reproduce:

Open Publish tab on SQL DB Proj.
Observe Advanced button text and when click on it observe the table header text.
Some option's descriptions are in english

Does this issue occur when all extensions are disabled?: Yes/No

Latest SQL DB code, when language set to Spanish, found the below text shows in non-spanish, which needs to take a look at.

as discussed in standup, this localization is probably from DacFx and those strings haven't been localized yet in the DacFx repo. @ssreerama you can check the sql-database-projects .xlf files in ADS to confirm if the other other description strings that are localized are present there to verify if they come from DacFx.

I see all the non localized strings are recently updated DacFx string! Do you know when can we expect the new DacFx Localized strings? Is it a regular process before the release or need to log a request! thanks

If you look at the history of DacFx commits, all the LEGO checkins are localization and these PRs get sent periodically, without us needing to request it. If it's urgent, there's probably a way to request it.

@kisantia , I see there is already a LEGO checkin happened in DacFx offical branch. We need to use that Nuget version in STS right!

closing since loc updates will come from DacFx


Router interceptor and Authentication

Hey I'm a complete newbie in docusaurus and I am loving it <3
We have a private document that we want to publish it and make it accessible to our members but we need some sort of authentication even the most simple one with a hard coded username and password...
I made a simple front-end login page and I managed to get it working only for FIRST page which is the main one in the classic theme.
Seems like when user goes to directly to one of the doc page route bypasses the main page...
I was wondering if there is any API to intercept and play around with the router by using the classic theme itself. I do not want to eject or extract the theme itself and go into rabbit whole of how classic theme made and etc.

I think you may have better luck with looking into actual deployment platform. Otherwise, you're changing the internal behaviour of Docusaurus linking. That can make it difficult to upgrade your instance of Docusaurus, unless there's a way to do it properly.
I deployed my site in AWS (S3 + CloudFront). Plus WAF service linked to the CloudFront made it possible so that the site is only available from certain IP addresses. You can also integrate single sign on services with CloudFront. It all depends on how and where you're deploying the site.
Hope that helps.

@amimas I agree with you, it can be achieved if the deployment platform has a way to shield it.
We were thinking of using Netlify... (I believe a lot of people deploy their docs in Netlify as well) I am not sure if we will be able to shield it through Netlify...

you're changing the internal behaviour of Docusaurus linking. That can make it difficult to upgrade your instance of Docusaurus, unless there's a way to do it properly.

What you  mentioned above is exactly why I didn't want to modify Docusaurus linking capability and how it's tied to the rest of the code...
Just to confirm, based on what you mentioned currently, there is no such a way to achieve this smoothly through Docusaurus right?

Yes, that is right, there is no way to implement authentication in Docusaurus, for example, this can be done using a proxy server (see https://github.com/facebook/docusaurus/issues/2769 for more details).

@lex111 Thanks for the issue - I am sure that will help a lot.
How about intercepting the router and playing around with it.... There wasn't much of a documentation around that as well.
Do you think exposing some routing API would be an issue?

We are using a react-router and as far as I know there is no route guard, so the only and best option is using a proxy server or similar feature provided by your hosting provider.

@lex111 sweet as - on that note, I will close this issue thanks


adds pagination and search functionality on user list

Issue
Closes #248
What are the changes?

fixes user card placement
showing only those user's on the listing screen whose archived role is false
added pagination on the user listing screen
added search functionality of particular user by username

Is Development Tested?

yes

Short video of how this will look on the website
https://user-images.githubusercontent.com/54801934/205439399-5ef0e490-71b7-48e4-a99d-1beb4d3bd69e.mp4

Can we please change the colors of next and previous button so that it is more visible?

Can we please change the colors of next and previous button so that it is more visible?

changed the color, let me know if it needs any changes
In this case, the previous button is not active

In this case, both buttons are active


Fix some problems with outlook recurrence rule

Short description

This pr fixes two problems that happen when importing external calendars that were generated in microsoft outlook.
Proposed changes

Handle the WKST property in recurrence rules (For now, the only supported weekstart is monday)
Handle the BYMONTHDAY and BYMONTH properties in recurrence rules: They must match the month and day of the event, because we don't support recurrence rules which start on a different day than their event
This pr does not solve #3227 fully, because rrules with weekdays like -1SU are still not handled. I will open another pr for that functionality.

Side effects

Less import errors

Resolved issues

Fixes: partially #3227

Pull Request Review Guidelines

Raising priority, as this pr blocks another pr now

@david-venhoff
Thank you for keep improving iCal feature 😻
I tried with the URL provided in the issue description and still got an error:  Could not import event due to unsupported recurrence rule: ValueError('by_set_pos must not be None') Is this (a part of) something you mentioned in the description as not covered (to be solved in the follow PR)?

@MizukiTemma

Is this (a part of) something you mentioned in the description as not covered (to be solved in the follow PR)?

Exactly. The problem with these events is that the by_set_pos attribute is specified as part of the by_day attribute, but the cms in this pr still does not understand that and thinks that by_set_pos is missing. This will be solved by the follow-up pr.

Though 20 event must be imported?

A lot of the events of this calendar can not be imported because the recurrence end date is on the same day as it starts, and the recurrence rule form currently throws an error when that happens. IMO that is fine and just an error with the events, not with the cms.

@MizukiTemma

Is this (a part of) something you mentioned in the description as not covered (to be solved in the follow PR)?

Exactly. The problem with these events is that the by_set_pos attribute is specified as part of the by_day attribute, but the cms in this pr still does not understand that and thinks that by_set_pos is missing. This will be solved by the follow-up pr.

Though 20 event must be imported?

A lot of the events of this calendar can not be imported because the recurrence end date is on the same day as it starts, and the recurrence rule form currently throws an error when that happens. IMO that is fine and just an error with the events, not with the cms.

Thank you for explanation 🙏 Then this PR is ready to go 🚀


reworks packages names

Based on remarks from @JulienVig, WDYT?
The name on NPM doesn't match the ones in the repo, that's confusing, and some paths are nested unnecessarily. Proposed list of renaming, from old name to new name (both FS and NPM)

discojs/discojs-core -> discojs
discojs/discojs-node -> discojs-node

thin layer over discojs, might not be needed if merged inside server/benchmark

discojs/discojs-web -> # merged in webapp
server -> discojs-server
cli -> cli (not published)

reduces the scope of the tool, from what I gathered, there is no need for a full CLI moar CLI in the future

web-client -> webapp (not published to NPM)

excellent
want to rename first or first prioritize the bugfixing of the current main functionality issues listed by julien?
for cli: could this also help how disco can be integrated into existing apps? headless mode, would be nice to describe a bit how to do that (in which case it would be more than just benchmarking). but if that's not cli then sure fine to call it benchmarking

Looks good! I have few concerns though:

If discojs-node is merged with the server then it gets confusing to import Client-side material from discojs-server.
A user would never import discojs itself which may be confusing? Is it a good idea to use discojs for something only contributors will encounter? I don't have other ideas though so I'm fine going with it anyway
Once there is a discojs-server users may be wondering why discojs-web isn't the webapp. So I think we should indeed merge discojs-web and webapp. Unless we want to let contributors create other UI's, which I don't think has been an important point so far.

I think the renaming and other refactors should wait until the current PRs are merged and bugs are fixed.
It would be nice to have a headless mode but so far the CLI was only used as benchmark so it'd be a new feature. Maybe we can leave it as CLI for now since it's quite a clear name already.

want to rename first or first prioritize the bugfixing of the current main functionality issues listed by julien?

bug fixing is the most important for now, this issue is for after the fixes (and some tests also).

for cli: could this also help how disco can be integrated into existing apps? headless mode, would be nice to describe a bit how to do that (in which case it would be more than just benchmarking). but if that's not cli then sure fine to call it benchmarking
[...]
It would be nice to have a headless mode but so far the CLI was only used as benchmark so it'd be a new feature. Maybe we can leave it as CLI for now since it's quite a clear name already.

keeping it as cli for now, we can discuss later on how/what to add to it (same functionnality as the webapp? only basics as benchmark/train/predict?)

If discojs-node is merged with the server then it gets confusing to import Client-side material from discojs-server.

I don't follow you there, which client-side material are you talking of?
I hesitated quite a bit to actually rename it as a discojs-$extension but there was a disco-server NPM packages so I got pushed into following that. not publishing it on NPM and keeping it as server is making a bit more sense to me but I'm not sure of how people actually want to try it out (docker comes to mind to where server should run).

Once there is a discojs-server users may be wondering why discojs-web isn't the webapp. So I think we should indeed merge discojs-web and webapp. Unless we want to let contributors create other UI's, which I don't think has been an important point so far.

good point, let's merge theses. we can unmerge it should the need arise (it's only two small files anyway)

So I think we should indeed merge discojs-web and webapp. Unless we want to let contributors create other UI's, which I don't think has been an important point so far.

let's merge theses. we can unmerge it should the need arise (it's only two small files anyway)

I just read the NextJS PR. Merging discojs-web into webapp means that we are not planning to integrate the NextJS frontend.

I think keeping it separate would make sense. Or what about merging discojs-node and server and naming the union discojs-node (rather than discojs-server)? As such users can import client and server instances from the same import named discojs-node which I think makes intuitive sense since both rely on Node.js. Would it make sense to include the server implementation in the Disco.js library?

If I may, I think this is a good idea as it appears discojs-node needs the server anyways.
However, I would keep discojs-web separate from the web app since there is a pretty clear distinction between them: the web app uses discojs-web and is not part of it.
Overall, here is a proposition:
.
├─ cli/
├─ disco/
│   ├── core/
│   ├── node/
│   │   │   ├── plugins/ # Contains discojs/discojs-node, still keeping a slight separation with the server since it clearly extends code from core/
│   │   │   └── server/ # Contains server/
│   └── web/
│   │   │   └── plugins/ # Contains discojs/discojs-web, named plugins to have the same format as for node
#   │   │   └── webapp/ # If decided to be merged with discojs-web
├─ docs/
└─ webapp/

In other words, a user can rely on the current discojs-node for things that have nothing to do with running a server (such as data preprocessing, training a local model etc) so merging discojs-node into the server may create confusion.
I think keeping it separate would make sense.

right, it'll be nice to allow users to run disco locally (ie w/ node and w/o a server). keeping the discojs-node separated will probably ease that. keeping it separated then.

Or what about merging discojs-node and server and naming the union discojs-node (rather than discojs-server)? As such users can import client and server instances from the same import named discojs-node which I think makes intuitive sense since both rely on Node.js. Would it make sense to include the server implementation in the Disco.js library?

hum, I don't think so: the server should be dumb, really only exposing discojs calls via HTTP, not much more (a thin axios/bun layer will work), most of the logic should go into discojs. discojs-node will only provide a few node-specifics helpers in this case.

If I may, I think this is a good idea as it appears discojs-node needs the server anyways.

indeed, it currently does, but it shouldn't, we need to have a tree of deps not a full graph.

However, I would keep discojs-web separate from the web app since there is a pretty clear distinction between them: the web app uses discojs-web and is not part of it.

I get your point, but having many packages for small fonctionnalities is cumbersome in JS' world. I try to weight how much we can simplify our dev workflow and users workflow, and IMO merging some pkgs will improve it.

Does merging discojs-web into the webapp implies that we would need to re-build the webapp for changes to apply? (and lose the hot-reloading feature)

after probing the code a bit more, it seems that discojs-core is already containing some node and web specific code (WebSocket implementation differs by platform, loading wrtc iff node). keeping this split (discojs-node & discojs-web) does makes more sense for me now.

Does merging discojs-web into the webapp implies that we would need to re-build the webapp for changes to apply? (and lose the hot-reloading feature)

no, as discojs-core will be a real deps of discojs-web (and not contained in it), hot-reloading seems to work with deps also, at least when trying out in #617: cd web-client && npm start seems to watch pretty much everything