HBASE-27681 Refactor Table Latency Metrics

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 40s
master passed

+1 :green_heart:
compile
3m 38s
master passed

+1 :green_heart:
checkstyle
0m 55s
master passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

-0 :warning:
javac
2m 27s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 29s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
1m 39s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

45m 41s

Reason
Tests

FindBugs
module:hbase-server

Unread field:MetricsTableLatencies.java:[line 116]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 87736c4a34cb 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 19s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
5m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
5m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 17s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 32s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
213m 15s
hbase-server in the patch passed.

244m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3e0e2b922aef 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/testReport/

Max. process+thread count
2656 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 45s
master passed

+1 :green_heart:
compile
1m 35s
master passed

+1 :green_heart:
shadedjars
5m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 29s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 21s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 52s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
320m 49s
hbase-server in the patch failed.

355m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5d4d7280b448 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/testReport/

Max. process+thread count
2388 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Should we do anything to unify with TableMetrics/MetricsTableSourceImpl class?
I think so. But maybe we can split it into another issue? What do you think?

Are there any additional tests we should add to verify all the new behavior end-to-end? It's a big change. We might at least want to upload a screenshot or dump of jmx metrics from a real server to prove that all of the expected metrics get updated.
I will do some tests and upload, maybe a doc, in this weekend.

I also find a lot of duplication in RSRpcServices. I almost wonder if we should expose a method on HRegion:
Glad to make some changes.

Convergence of null check, and renamed metricsName to tableRequests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
2m 58s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 11s
master passed

-0 :warning:
patch
1m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
2m 54s
the patch passed

-0 :warning:
javac
2m 22s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 25s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
1m 39s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

42m 38s

Reason
Tests

FindBugs
module:hbase-server

Unread field:MetricsTableRequests.java:[line 116]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 789d0261037c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

-0 :warning:
patch
5m 34s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
207m 54s
hbase-server in the patch passed.

231m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 33a005133b24 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/testReport/

Max. process+thread count
2505 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
216m 34s
hbase-server in the patch passed.

245m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c3d4a8157d04 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d2b0074f7a

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/testReport/

Max. process+thread count
2514 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Previously this duplication was nicely encapsulated in MetricsRegionServer. We passed in a TableName, and it updated table metrics if appropriately.
You removed the TableName argument, so now the code has to live outside MetricsRegionServer. What if you replace TableName argument with Region argument?

Agree that is a truly problem. Honestly I have consider it too.
I think the previous code structure is a bit confusing.
From the naming point of view, MetricsRegionServer and MetricsTableRequests should be at the same level, but they are actually completely different. We can see that MetricsRegionServer holds serverSource, metricsTable, tableMetrics, userAggregate, and so on.
My vision is that each metrics object is only responsible for operating one type of metrics (that is, a bean in jmx), so that the metric of the table belongs to the metricsTable, the metric of the server belongs to the metricsServer, and the metric of the region belongs to the metricsRegion. Then there is a tool class that only needs to be called once externally (such as in RSRpcServices), and encapsulates all operations on metrics in the methods of this tool class.
In fact, the current MetricsRegionServer is such a tool class. We can change its name, or create a new class, and then gradually refactor various metrics, transfer the function of the main entrance to the new class, and let MetricsRegionServer gradually degenerate into only responsible for serverMetrics.
But in order to disassemble the work and try to have a clear goal, in this ticket I don't intend to modify anything other than tableLatencies. That's why I just left it here.
After all now I'm glad to temporarily put these logics back into MetricsRegionServer, just as you said, replace TableName argument with Region argument. What do you think?

@thangTang your analysis makes a lot of sense, and I 100% agree with the direction. I agree the existing setup is a bit confusing, and MetricsRegionServer is more of a tool class. I agree it would be nice to either rename it or refactor it, and that can happen in a separate issue.
For this PR, I think it would be nice to move the logic back into MetricsRegionServer for now. For two reasons:

Reduces the diff here
Keeps RSRpcServices a bit cleaner... It's already a huge and messy class, so would rather not move more logic into it if not necessary.

Passing Region into MetricRegionServer might seem a bit weird, but all of the options are weird.  This way at least is a minimal diff. I think we could add a comment or todo in the code to let developers know that we hope to clean up the abstraction.
I have another PR https://github.com/apache/hbase/pull/5067 which is going to add more metrics to Table and RegionServer beans. I think that PR would also end up quite a bit messier if we moved the logic into RSRpcServices, so I think that's a good reason (ease of adding new metrics)

I think it would be nice to move the logic back into MetricsRegionServer for now.

Thank you for your suggestion @bbeaudreault ~
I pushed a new commit and put them back: )

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 20s
master passed

+1 :green_heart:
compile
2m 57s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  8s
master passed

-0 :warning:
patch
1m 45s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
2m 54s
the patch passed

-0 :warning:
javac
2m 22s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 11s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

42m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8b91c5528b2f 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

-0 :warning:
patch
5m 34s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 43s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
4m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
211m  8s
hbase-server in the patch failed.

234m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f14ee5b7b001 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/testReport/

Max. process+thread count
2486 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
4m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

-0 :warning:
patch
5m 43s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
217m 46s
hbase-server in the patch passed.

244m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b27b80197d28 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/testReport/

Max. process+thread count
2510 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
compile
2m 56s
master passed

+1 :green_heart:
checkstyle
0m 50s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  4s
master passed

-0 :warning:
patch
1m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

-0 :warning:
javac
2m 23s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 14s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

41m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 3476f1d06bbd 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
0m 54s
master passed

+1 :green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

-0 :warning:
patch
5m 31s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
207m 35s
hbase-server in the patch passed.

230m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 230883cbff32 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/testReport/

Max. process+thread count
2431 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
4m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

-0 :warning:
patch
5m 43s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
4m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 42s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
215m 56s
hbase-server in the patch passed.

242m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3155b8c54e64 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/testReport/

Max. process+thread count
2486 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
2m 57s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  6s
master passed

-0 :warning:
patch
1m 45s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
2m 55s
the patch passed

-0 :warning:
javac
2m 23s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

-0 :warning:
checkstyle
0m 35s
hbase-server: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m  9s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

-1 :x:
spotless
0m 37s
patch has 21 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

43m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 67fc804e48fd 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  0s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

-0 :warning:
patch
5m 33s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
210m 25s
hbase-server in the patch failed.

234m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7b64a1ff6f3a 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/testReport/

Max. process+thread count
2409 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
4m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

-0 :warning:
patch
6m  3s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
268m 41s
hbase-server in the patch failed.

296m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 753c306885a3 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/testReport/

Max. process+thread count
2452 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
2m 58s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  5s
master passed

-0 :warning:
patch
1m 44s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
2m 54s
the patch passed

-0 :warning:
javac
2m 22s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 29s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

43m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 6e8e729691bc 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

You could just remove that null check on region and update the tests to pass a mocked Region.
Also I think the pre-commit hook is saying you need to rebase your PR

Thank you very much for your patient review.
I removed all null checks, but to be honest, I'm not sure if there is any corner case that I didn't think of. . . Let's wait for the CI results.
And of course, in addition to this, I still need to do some real-world testing on the final version.

Actually, I have another question I would like to ask for your opinion.
I don't quite understand why TableQueryMeterMetrics needs to have a separate switch. They don't seem to have any extra overhead. Or even if it is necessary, I think it should be used as a separate JMX bean instead of being mixed with TableRequests.
What do you think about this?
Thank you!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

-0 :warning:
patch
5m 34s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
209m 22s
hbase-server in the patch passed.

232m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8280d476a22e 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/testReport/

Max. process+thread count
2479 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I removed all null checks, but to be honest, I'm not sure if there is any corner case that I didn't think of

Just to be clear, I'm not against null checks. I'm against replacing:
if (object != null) {
  object.doSomething();
}

with
Optional.ofNullable(object).ifPresent(Object::doSomething);

It's fine in simple code, but in hot code paths its an unnecessary object allocation. You could keep the null checks in your PR if you want, they aren't a problem. I just didnt want the unnecessary optional stuff in the specific area.

I don't quite understand why TableQueryMeterMetrics needs to have a separate switch.

The TablequeryMeter stuff uses an codeahale metrics EWMA. This has caused performance issues for some people in the past, so a config was added to disable separately it. We have it disabled at my company, though have other table metrics enabled.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 43s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
5m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

-0 :warning:
patch
6m 42s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 47s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
256m 48s
hbase-server in the patch passed.

288m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c3026390145e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/testReport/

Max. process+thread count
2488 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s
master passed

+1 :green_heart:
compile
2m 56s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  7s
master passed

-0 :warning:
patch
1m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
2m 58s
the patch passed

-0 :warning:
javac
2m 24s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

-0 :warning:
checkstyle
0m 36s
hbase-server: The patch generated 4 new + 24 unchanged - 0 fixed = 28 total (was 24)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 19s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

-1 :x:
spotless
0m 36s
patch has 48 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

41m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux cf949ffb07a6 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
4m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

-0 :warning:
patch
5m 30s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
211m 44s
hbase-server in the patch failed.

234m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bf3b261b7b2a 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/testReport/

Max. process+thread count
2448 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
master passed

-0 :warning:
patch
6m 50s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 24s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
5m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 20s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
249m 26s
hbase-server in the patch failed.

280m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f6bf7e844fb2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/testReport/

Max. process+thread count
2496 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

After removed the null check of MetricsTableRequests, found this error in CI:
2023-03-06T10:36:45,112 ERROR [RS_OPEN_PRIORITY_REGION-regionserver/<IP_ADDRESS>:0-0] coprocessor.CoprocessorHost(420): The coprocessor org.apache.hadoop.hbase.security.visibility.VisibilityController threw java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.hbase.regionserver.metrics.MetricsTableRequests.updateTableWriteQueryMeter(long)" because the return value of "org.apache.hadoop.hbase.regionserver.HRegion.getMetricsTableRequests()" is null
java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.hbase.regionserver.metrics.MetricsTableRequests.updateTableWriteQueryMeter(long)" because the return value of "org.apache.hadoop.hbase.regionserver.HRegion.getMetricsTableRequests()" is null
        at org.apache.hadoop.hbase.regionserver.MetricsRegionServer.updateWriteQueryMeter(MetricsRegionServer.java:258) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4711) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4623) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5116) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5110) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5106) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.lambda$put$11(HRegion.java:3266) ~[classes/:?]
        at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3255) ~[classes/:?]
        at org.apache.hadoop.hbase.security.visibility.DefaultVisibilityLabelServiceImpl.addSystemLabel(DefaultVisibilityLabelServiceImpl.java:218) ~[classes/:?]
        at org.apache.hadoop.hbase.security.visibility.DefaultVisibilityLabelServiceImpl.init(DefaultVisibilityLabelServiceImpl.java:143) ~[classes/:?]
        at org.apache.hadoop.hbase.security.visibility.VisibilityController.initVisibilityLabelService(VisibilityController.java:268) ~[classes/:?]
        at org.apache.hadoop.hbase.security.visibility.VisibilityController.postOpen(VisibilityController.java:258) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$2.call(RegionCoprocessorHost.java:511) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$2.call(RegionCoprocessorHost.java:508) ~[classes/:?]
        at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:558) ~[classes/:?]
        at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:631) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postOpen(RegionCoprocessorHost.java:508) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1101) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:955) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7724) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7679) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7654) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7613) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7569) ~[classes/:?]
        at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:136) ~[classes/:?]
        at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:100) ~[classes/:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

That's because Coprocessor inited earlier than MetricsTableRequests.
So I just removed region null check and put MetricsTableRequests null check back.
Considering that the previous code also has non-empty check on tableMetrics and tableName, I don't think this will be worse.
And thank you for providing me the informations about Meter metrics!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

-0 :warning:
patch
5m 30s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
4m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 14s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
215m 51s
hbase-server in the patch passed.

239m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7c0eebe15308 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/testReport/

Max. process+thread count
2503 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 24s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
4m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

-0 :warning:
patch
5m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 20s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
217m 52s
hbase-server in the patch failed.

244m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 90f201b34ed5 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59fdaa28f7

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/testReport/

Max. process+thread count
2525 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Removed some unnecessary modify in RSRpcServices.
Failure test seems not related.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
compile
3m  2s
master passed

+1 :green_heart:
checkstyle
0m 54s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 12s
master passed

-0 :warning:
patch
1m 47s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

-0 :warning:
javac
2m 24s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 26s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

43m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 075f6febd6f3 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 37858bb6b0

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
6m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 23s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 53s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
214m 32s
hbase-server in the patch passed.

250m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0838755d55c2 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 37858bb6b0

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/testReport/

Max. process+thread count
2837 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

-0 :warning:
patch
5m 39s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 15s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 29s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
255m 12s
hbase-server in the patch failed.

280m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7c578d19b19e 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 37858bb6b0

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/testReport/

Max. process+thread count
2543 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/9/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Integration Testing of HBASE-27681](Integration Testing of HBASE-27681)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
2m 58s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

-0 :warning:
javac
2m 22s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 23s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

42m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 400a42d735aa 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 586073d0c0

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
4m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 17s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 32s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
209m 47s
hbase-server in the patch passed.

233m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f804c8f59633 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 586073d0c0

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/testReport/

Max. process+thread count
2489 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
4m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hbase-metrics in the patch passed.

+1 :green_heart:
unit
0m 38s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
221m  5s
hbase-server in the patch failed.

248m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 534d50b443e3 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 586073d0c0

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/testReport/

Max. process+thread count
2497 (vs. ulimit of 30000)

modules
C: hbase-metrics hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5072/10/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The new failed test seems also not related.
I tried to run TestHRegionWithInMemoryFlush and TestAsyncFSWALCorruptionDueToDanglingByteBuffer on my local, both passed.
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.58 s - in org.apache.hadoop.hbase.wal.TestAsyncFSWALCorruptionDueToDanglingByteBuffer
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule$1 (file:/Users/tianhang.tang/workspaces/apache/hbase/hbase-common/target/test-classes/)
WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule$1
WARNING: System::setSecurityManager will be removed in a future release
[INFO] Tests run: 133, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 335.874 s - in org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 134, Failures: 0, Errors: 0, Skipped: 0

@thangTang I tried cherry-pick to branch-2, but there are a bunch of merge conflicts. Any chance you can submit a backport PR for branch-2?

Sure. Will open a PR this week. Thank you for your patient and meticulous
review, it helped me a lot: )
Bryan Beaudreault @.***>于2023年3月8日 周三01:09写道：

@thangTang https://github.com/thangTang I tried cherry-pick to
branch-2, but there are a bunch of merge conflicts. Any chance you can
submit a backport PR for branch-2?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/hbase/pull/5072#issuecomment-1458531308, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKMK637GQFX2OLPEJYK6GLW25TWFANCNFSM6AAAAAAVMHT23E
.
You are receiving this because you were mentioned.Message ID:
@.***>

@thangTang also, I'm not sure how I missed this but I just realized that we didn't delete MetricsTableLatencies or MetricsTableLatenciesImpl classes. Those are now unused I believe, but the classes still exist. I think we might need another jira to delete those.

@thangTang also, I'm not sure how I missed this but I just realized that we didn't delete MetricsTableLatencies or MetricsTableLatenciesImpl classes. Those are now unused I believe, but the classes still exist. I think we might need another jira to delete those.

Oh... Sorry about that...
I think I can just open a new PR and push an Addendum commit?

Pls help me take a look at https://github.com/apache/hbase/pull/5092.
If you think we need a single ticket, feel free to leave a msg to me and I will create a new one.

Yes that works. I can take a look tomorrow morning my time. Also, we don't need a new jira for backport. We sometimes do that when doing a backport after the original jira was long resolved. But we haven't restocked this yet, so can just use the same jira

Yes that works. I can take a look tomorrow morning my time. Also, we don't need a new jira for backport. We sometimes do that when doing a backport after the original jira was long resolved. But we haven't restocked this yet, so can just use the same jira

Sorry, I just saw this message... I already opened a new issue for Backport this morning😂
Could see https://github.com/apache/hbase/pull/5093

I think I'm going to rename the title of your PR and rewrite the commit message when I merge, so that it can be associated with the original jira. As someone who often goes digging in jira to find when or why changes occurred, I think it's much nicer to keep the backports in the original jira if at all possible. So once I merge we can resolve your new jira as Won't Do or Not A Problem or something

Hi no need to do this by yourself @bbeaudreault , if you think so, just give me a few minutes to rebase my commit and re-push it, then you can just review and merge: )

OK, then thank you so much.
Bryan Beaudreault @.***>于2023年3月8日 周三22:57写道：

@thangTang https://github.com/thangTang no worries -- it's easy for me
to do in the github UI when I merge. Github gives me a chance to rewrite
the commit (which we use for adding the Signed-off-by tags and such). I
can just change it there.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/hbase/pull/5072#issuecomment-1460287284, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKMK62UXAMHA7MQCBH2Z73W3CM5FANCNFSM6AAAAAAVMHT23E
.
You are receiving this because you were mentioned.Message ID:
@.***>


Modifies files in invisible way

https://github.com/webmproject/libwebp-demo/tree/gh-pages
Try running this example with http-server and then i.e. serve. http-server somehow modifies files on the fly. When trying to read their binary content they have bugs
Tried on Windows 10, Chrome browser

Closing as a non-issue. The project installs a service worker that modifies data on the fly. Using <IP_ADDRESS> instead of localhost or changing the port where the project works only once before installing the worker confirms this


block_writer fails with "value X is too large to be recorded"

Example failure from block_writer.stderr:
2017/01/31 07:18:05 value -946739623 is too large to be recorded

Which results in a failure of a supervisor status for block_writer:
[02:23:20][TestContinuousLoad_BlockWriter] 	farmer.go:292: block_writer (bwriter6h-desperateleavitt-cockroach-2.eastus.cloudapp.azure.com) is not in expected state RUNNING:
[02:23:20][TestContinuousLoad_BlockWriter] 		block_writer                     EXITED    Jan 31 07:18 AM
[02:23:20][TestContinuousLoad_BlockWriter] 	test_log_scope.go:85: test log files left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/TestContinousLoad-bwriter278254757

Failures:
https://teamcity.cockroachdb.com/viewLog.html?buildId=133874&tab=buildResultsDiv&buildTypeId=Cockroach_AllocatorTest1to310g
https://teamcity.cockroachdb.com/viewLog.html?buildId=133875&tab=buildResultsDiv&buildTypeId=Cockroach_AllocatorTest3to510g
https://teamcity.cockroachdb.com/viewLog.html?buildId=133879&tab=buildResultsDiv&buildTypeId=C_BW_4Nodes_6Hours
cc @petermattis since this may be related to recent block_writer changes

I'm guessing we had a time jump that caused a negative elapsed time. I'll add a workaround.

This still manifests itself, now with large positive values:
2017/02/01 16:32:14 value<PHONE_NUMBER>3 is too large to be recorded

Failure:
https://teamcity.cockroachdb.com/viewLog.html?buildId=135857&buildTypeId=Cockroach_AllocatorTest1to310g&tab=buildResultsDiv

Also confirmed that the test is using build 5d6d4c7ee7fcaa86348fd01e9cec952856ecda37.


Develop test suite for new repo1 files

Summary

Design a test suite that can be called from command line to ensure that the files we're pushing to repo1 are valid.
Namely, we should be able to:

build a docker image successfully
build an env inside of that docker image

Do we use pytest?
Do we write it in python or bash?
Proposed implementation

Acceptance Criteria

Tasks to complete

Related to

If we build docker images, it may make more sense to write this in bash. Otherwise, I'd like to stick with python.
An alternative is to building docker images is to just perform all the tasks that are happening inside of the docker image. For example, building the local channel.
Now that I'm thinking more about this, I'd like to have this as optional final step to update_repo. Add a flag to trigger whether it is run or not (since it will be time consuming).

Summary of what the dockerfile is doing:

downloading micromamba-0.23.0-0.tar.bz2
copying in files from a local channel
creating a conda env from the local channel using micromamba

This is a test fo everything that happens after we push files over the IB fence

if we do this outside of docker, is it possible to build the envs for different OSs?


[Bug]: Attempting to run MySQL 8 with MariaDB compatibile results in "RSA public key" error

Module
MariaDB
Testcontainers version
1.17.6
Using the latest Testcontainers version?
Yes
Host OS
macOS
Host Arch
x86
Docker version
Client:
 Cloud integration: v1.0.29
 Version:           20.10.22
 API version:       1.41
 Go version:        go1.18.9
 Git commit:        3a2c30b
 Built:             Thu Dec 15 22:28:41 2022
 OS/Arch:           darwin/amd64
 Context:           default
 Experimental:      true

Server: Docker Desktop 4.16.2 (95914)
 Engine:
  Version:          20.10.22
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.18.9
  Git commit:       42c8b31
  Built:            Thu Dec 15 22:26:14 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.14
  GitCommit:        9ba4b250366a5ddde94bb7c9d1def331423aa323
 runc:
  Version:          1.1.4
  GitCommit:        v1.1.4-0-g5fd4c4d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

What happened?
Starting a MySQL 8 instance like this results in an error on container.start().
        var image = DockerImageName.parse("mysql:8.0.27")
            .asCompatibleSubstituteFor("mariadb");

        container = new MariaDBContainer<>(image);
        container.addEnv("MYSQL_ALLOW_EMPTY_PASSWORD", "yes");
        container.addParameter("MYSQL_ALLOW_EMPTY_PASSWORD", "yes");
        container.start();

Relevant log output
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
	at BaseJpaTest.<clinit>(BaseJpaTest.java:56)
	... 71 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
	... 73 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542)
	at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
	... 74 more
Caused by: java.lang.IllegalStateException: Container is started, but cannot be accessed by (JDBC URL: jdbc:mariadb://localhost:52161/test), please check container logs
	at org.testcontainers.containers.JdbcDatabaseContainer.waitUntilContainerStarted(JdbcDatabaseContainer.java:178)
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485)
	... 76 more
Caused by: java.sql.SQLException: Could not create new connection
	at org.testcontainers.containers.JdbcDatabaseContainer.createConnection(JdbcDatabaseContainer.java:263)
	at org.testcontainers.containers.JdbcDatabaseContainer.createConnection(JdbcDatabaseContainer.java:219)
	at org.testcontainers.containers.JdbcDatabaseContainer.waitUntilContainerStarted(JdbcDatabaseContainer.java:159)
	... 77 more
Caused by: java.sql.SQLTransientConnectionException: Could not connect to address=(host=localhost)(port=52161)(type=master) : RSA public key is not available client side (option serverRsaPublicKeyFile not set)
	at org.mariadb.jdbc.internal.util.exceptions.ExceptionFactory.createException(ExceptionFactory.java:79)
	at org.mariadb.jdbc.internal.util.exceptions.ExceptionFactory.create(ExceptionFactory.java:197)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.connectWithoutProxy(AbstractConnectProtocol.java:1399)
	at org.mariadb.jdbc.internal.util.Utils.retrieveProxy(Utils.java:635)
	at org.mariadb.jdbc.MariaDbConnection.newConnection(MariaDbConnection.java:150)
	at org.mariadb.jdbc.Driver.connect(Driver.java:89)
	at org.testcontainers.containers.JdbcDatabaseContainer.createConnection(JdbcDatabaseContainer.java:254)
	... 79 more
Caused by: java.sql.SQLException: RSA public key is not available client side (option serverRsaPublicKeyFile not set)
	at org.mariadb.jdbc.internal.com.send.authentication.CachingSha2PasswordPlugin.process(CachingSha2PasswordPlugin.java:189)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.authenticationHandler(AbstractConnectProtocol.java:762)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.createConnection(AbstractConnectProtocol.java:563)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.connectWithoutProxy(AbstractConnectProtocol.java:1394)
	... 83 more

Additional Information
No response

MYSQL_ALLOW_EMPTY_PASSWORD will be set automatically if the username is root and password is empty or null.
https://github.com/testcontainers/testcontainers-java/blob/de1324ed2800eff4da326d0c23d281399d006bc0/modules/mariadb/src/main/java/org/testcontainers/containers/MariaDBContainer.java#L75-L80
As the mysql image documentation says:

MYSQL_ALLOW_EMPTY_PASSWORD
This is an optional variable. Set to a non-empty value, like yes, to allow the container to be started with a blank password for the root user. NOTE: Setting this variable to yes is not recommended unless you really know what you are doing, since this will leave your MySQL instance completely unprotected, allowing anyone to gain complete superuser access.

@tbeauvais-imagine did the last comment help you?

Nope, it didn't. Though I was able to get around it eventually.
Half of it had to do with improper documentation and the other half had to do with how we are setting up the properties for the Spring clients.
Assigning the properties directly on the container works.
var image = DockerImageName.parse("965331111166.dkr.ecr.us-west-2.amazonaws.com/mysql:8.0.27")
    .asCompatibleSubstituteFor("mariadb");

container = new MariaDBContainer<>(image)
    .withUrlParam("allowPublicKeyRetrieval", "true")
    .withUrlParam("useUnicode", "true")
    .withUrlParam("characterEncoding", "UTF-8");

container.start();

Then use the JDBC URL that is generated by the container (where we were building it improperly ourselves.
@DynamicPropertySource
static void mysqlProperties(DynamicPropertyRegistry registry) {
    var dsUsername = container.getUsername();
    var dsPassword = container.getPassword();

    registry.add("spring.datasource.url", () -> container.getJdbcUrl());
    registry.add("spring.datasource.username", () -> dsUsername);
    registry.add("spring.datasource.password", () -> dsPassword);
}

Hopefully, this helps the next ones that have this problem.
Thanks for the response! :)


how to make it send country code rather than country-name?

I wondering if there is any way to make it select country code rather than country name. Can anyone help me?
now it sends data to server like "country_code"=>"Albania (Shqipëri)"

you will need to run 'getSelectedCountryData' and get the iso2 name before submitting.
at least thats what i do, and if my page fails due to validation issues, i usually just run 'selectCountry' and pass in the iso2 name to reselect the country again

If I understand the question correctly, you're suggesting that you don't get the country code, you get the name of the country? Do you get the same value passed in country as you get in country_code? I just tried this myself and wasn't able to duplicate the issue.

Haven't seen any further action on this. In case there was a misunderstanding, can you also confirm that you are using the _code suffix to a field so that you have two inputs, one for the country and one for the country code?
See the example in point number 4 under "Getting Started" on the README for this plugin.

Hello!
When i tried to pass the country_code as a parameter , I always get a null value from it.
Any advise?

So, @jhio1, I'm not sure what you mean about a parameter. Did you create an input element with the ID country_code, and you had an input element with the ID country which you applied the plugin to? Or were you trying to pass country_code as a parameter in the object you pass to the plugin when you initialize it?

Having seen no further response on this issue, and given that it's working correctly in my own tests and for other users, I'm going to assume that the problem was a misunderstanding about how to use the country code feature. I'm closing this issue, but if you are able to replicate the problem please re-open it or file a new one so we can take a look.