Fix text masking with certain tokenizers

Overview
Description of the changes proposed in this pull request:
Fixed a bug in text masker for a tokenizer where keep_prefix is >0 but keep_sufix is 0. In this case, the full mask is overwritten to True. This PR contains the (small) fix and some tests.
Checklist

[x] All pre-commit checks pass.
[x] Unit tests added (if fixing a bug or adding a new feature)

@connortann could you please let the workflows run?

From my side the code looks good. Just waiting for the CI checks to pass. @connortann gentle push ;)


More robust treatment of uncaught panics for child threads

Currently, an uncaught panic on a child thread will result in output to that thread's panic output handle (which is currently overridable).
This may not be a desirable default, and we probably want the behavior to be more thoroughly customizable.
See this previous RFC for some discussion on the topic.

Note: a change to the default would likely be a breaking change.

Yup.


Allow Layers to have both an image and a background color.

👊

We should add a simple test for this behavior :-)

Good point, I’ll look into this tomorrow!

Is this a good one for the Future branch? Happy to rebase.


Add solo node delete subcommand

add a solo node delete subcommand, much of the code can be reused from solo node add, you will use the NodeDeleteTransaction
use DRY principle
stop the Hedera service, but leave the pod running
depends on https://github.com/hashgraph/solo/issues/381

:tada: This issue has been resolved in version 0.29.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create yass.yml

Learn Build status updates of commit ff37257:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/yass.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Pg Query Dependency Issue (maybe?)

Attempting to run this: PgColumnBytePacker::PgDump.sort_columns_for_definition_file( Rails.root.join('db', 'structure.sql').to_s, connection: ActiveRecord::Base.connection) yields this error:
TypeError: wrong argument type Integer (expected String)
from /opt/homebrew/lib/ruby/gems/2.6.0/gems/pg_column_byte_packer-1.1.0/lib/pg_column_byte_packer/pg_dump.rb:74:in `[]'

The line in question that fails is:
if parsed && (column_def = parsed.tree[0]["RawStmt"]["stmt"]["CreateStmt"]["tableElts"][0]["ColumnDef"])

And parsed is defined as PgQuery.parse(fake_query).
This is just a guess, but judging by the release dates of this gem, I'd assume it was working on PgQuery 1.2, but the latest PgQuery is now 2.1 which I can only guess has changed the interface quite a bit. Since this gem doesn't lock down PgQuery to any version, I'm assuming it's now broken by default.
Is anyone else seeing this?
I'm on OSX 11.4 on Apple M1, running against PG12 with ruby 2.6

@bradrobertson I think that's the issue, yeah. I work at pganalyze, which maintains pg_query, and 2.0 changed the raw parse tree representation. We've kept compatibility at the helper method level, but if pg_column_byte_packer is accessing the raw parse tree, it will need to adapt (or pin to the older 1.x versions).
The new way to access the column definition structure similar to the above would be
parsed.tree.stmts[0].stmt.create_stmt.table_elts[0].column_def


eyes integration fix

Check if the eyes key is defined and if it is then it creates an instance for eyes. After the scenarios it checks If there is an eyes instance and then it closes it . This should fix the extra errors .

Thanks Temi, but this was added in a previous commit.


the trait rusqlite::types::ToSql is not implemented for std::vec::Vec<&std::string::String>

I want to construct a SQL query that uses an in condition on an input vector. The simplified code snippet looks like:
let values: Vec<String> = vec!["foo".to_string(), "bar".to_string()];
let mut stmt = try!(conn.prepare("SELECT * FROM table where command in ?"));
let rows = try!(stmt.query_map(&[values], ...));

I expect that the constructed SQL look like:
SELECT * FROM table where command in ('foo', 'bar')

But compiling the code fails with
the trait `rusqlite::types::ToSql` is not implemented for `std::vec::Vec<&std::string::String>`

Is this something that rusqlite should support or should this use case be covered in the application? I just started learning Rust (by rewriting command-not-found in Rust) and are open to suggestions how to implement that.

You should pass the vector directly:
let rows = try!(stmt.query_map(values, ...));

A complete example:
use rusqlite::Connection;

fn main() {
    let db = Connection::open_in_memory().unwrap();

    let values: Vec<String> = vec!["foo".to_string(), "bar".to_string()];
    db.query_row("SELECT ?, ?",
                 values, // <======
                 |row| {
                     let foo: String = row.get(0);
                     let bar: String = row.get(1);
                    println!("{}, {}", foo, bar);
                 }).unwrap();
}

The problem is that the length of the vector is dynamic.

In that case, you can give array extension a try.
Currently, only vector of Value are supported (Strings can be transformed into Values).
See https://github.com/jgallagher/rusqlite/blob/master/src/vtab/array.rs#L186
And https://sqlite.org/carray.html
let mut stmt = try!(conn.prepare("SELECT * FROM table where command in rarray(?)"));

Would you mind closing the issue ?

I still haven't found time to try out the array extension. I'll close this issues now and will report back in an error case. Thanks for your help.

Too bad this discussion was discontinued. How to perform in query with a Vec? I'm also getting the "is not implemented" error.

https://github.com/rusqlite/rusqlite/blob/master/src/vtab/array.rs#L18

 // Note: A `Rc<Vec<Value>>` must be used as the parameter.

...

@gwenn Thanks! I also wasn't using the vtab and array features.
Just one question more, as it's a bit difficult to understand from the source, when can the result of rusqlite::vtab::array::load_module(&db) be Err? If I'm sure that the features are enabled, can I assume it's always Ok?

The error comes from sqlite3_create_module_v2.
But SQLite documentation doesn't say anything about the returned code !
So you should assume that load_module can fail.

Ok, thanks again!


Update substrait to 0.23.0

Substrait supports physical join and expr evaluation in v0.23.0

Thanks, will merge it today!


translate-shell: 0.9.4 -> <IP_ADDRESS>

Semi-automatic update. These checks were performed:

built on NixOS
found <IP_ADDRESS> with grep in /nix/store/b8w2c7x6vy16bdfcyxnsv40r88ybdqhy-translate-shell-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/b8w2c7x6vy16bdfcyxnsv40r88ybdqhy-translate-shell-<IP_ADDRESS>

cc "@ebzzry"

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘libpciaccess-0.14’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/servers/x11/xorg/default.nix:1115 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
gzipping man pages under /nix/store/fyyb02n68bppr74sccbv87jlifgbvgc8-mpv-0.27.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fyyb02n68bppr74sccbv87jlifgbvgc8-mpv-0.27.0/lib  /nix/store/fyyb02n68bppr74sccbv87jlifgbvgc8-mpv-0.27.0/bin
patching script interpreter paths in /nix/store/fyyb02n68bppr74sccbv87jlifgbvgc8-mpv-0.27.0
checking for references to /tmp/nix-build-mpv-0.27.0.drv-0 in /nix/store/fyyb02n68bppr74sccbv87jlifgbvgc8-mpv-0.27.0...
building path(s) ‘/nix/store/a9bjdm77rk33n1qxi14msniyw98gwn07-translate-shell-<IP_ADDRESS>’
building
installing
postFixup
/nix/store/a9bjdm77rk33n1qxi14msniyw98gwn07-translate-shell-<IP_ADDRESS>

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘jailbreak-cabal-1.3.2’ in /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/pkgs/development/haskell-modules/hackage-packages.nix:120316 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


Footer layout issue

At around 1400px width, the download button seems to be at an awkward position.
https://user-images.githubusercontent.com/32864116/124292838-982c3000-db88-11eb-88db-87eac4914d82.mp4

I will be working on this issue.

Is this issue closed?


B11009049's new log i don't wanna be the only one who get A

Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

reviewed and achieved


google_maps_flutter: onTap not working on polygon

I am using google_maps_flutter: ^2.0.4 on Android 11
I Specified areas with polygon and the onTap not working when tapping on mentioned areas
But onLongPress works fine

@AliEasy
Try using consumeTapEvents property to achieve onTap and see if it helps to answer your question.

Yes!
Setting consumeTapEvents: true and using onTap in Polygon does the job
Thanks


always sort chatList when invalidate

When invalidate,the chatList in contacts-view.js line 30:
nextProps.chatList.map((c) => {
always sort whether chatLists have changed or not.
I think here should check if chatList changed like:
const {chatList}=nextProps;
if(chatList!==prevState.chatList){
nextProps.chatList.map((c) => {
and at the final of getDerivedStateFromProps,
set new chatList to states like:
return {
chatList:chatList,
contactList: contacts,
archivedCount: archivedCount
};

Yes, you are right that the sorting happens too often and it's bad. But I think the solution you are proposing is not the best one. The getDerivedStateFromProps should not be called at all. It should be refactored to use componentDidUpdate instead.

Great, hope your update

Fix released in https://github.com/tinode/webapp/releases/tag/v0.16.0


Footer element in compose element results in error

I'm submitting a bug report

Library Version:
1.7.0

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
v8.11.3

NPM Version:
6.1.0

JSPM OR Webpack AND Version
webpack 4.1.1

Browser:
Chrome 67.0.3396.87

Language:
TypeScript 2.7.2

Current behavior:
Using a compose element to include a view-model containing a footer element results in the following error:
ERROR [templating-resources] RangeError: Maximum call stack size exceeded
    at Container.invoke (webpack-internal:///./node_modules/aurelia-dependency-injection/dist/native-modules/aurelia-dependency-injection.js:707:13)
    at ProviderResolver.get (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2074:72)
    at Container.get (webpack-internal:///./node_modules/aurelia-dependency-injection/dist/native-modules/aurelia-dependency-injection.js:644:21)
    at Container.elementContainerGet [as get] (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2129:15)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4116:56)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4128:39)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4128:39)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4128:39)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4128:39)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
    at HtmlBehaviorResource.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4128:39)
    at applyInstructions (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2231:31)
    at ViewFactory.create (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:2452:7)
From previous event:
    at CompositionEngine.createController (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4619:8)
    at CompositionEngine._createControllerAndSwap (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4581:17)
    at CompositionEngine.compose (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4667:19)
    at processChanges (webpack-internal:///aurelia-templating-resources/compose:185:55)
    at Compose.bind (webpack-internal:///aurelia-templating-resources/compose:96:5)
    at Controller.bind (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:3501:22)
    at View.bind (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:1490:22)
    at Controller.bind (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:3493:17)
    at Controller.automate (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:3438:10)
    at eval (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4582:18)
From previous event:
    at CompositionEngine._createControllerAndSwap (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4581:43)
    at CompositionEngine.compose (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4667:19)
    at TemplatingEngine.compose (webpack-internal:///./node_modules/aurelia-templating/dist/native-modules/aurelia-templating.js:4931:36)
    at Aurelia.setRoot (webpack-internal:///aurelia-framework:526:19)
    at eval (webpack-internal:///main:27:55)
From previous event:
    at Module.configure (webpack-internal:///main:27:21)
    at eval (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:101:27)
From previous event:
    at config (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:96:54)
    at eval (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:132:12)
From previous event:
    at bootstrap (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:131:24)
    at eval (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:118:7)
From previous event:
    at run (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:113:59)
    at Module.eval (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:138:16)
    at eval (webpack-internal:///./node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js:139:30)
    at Module../node_modules/aurelia-bootstrapper/dist/native-modules/aurelia-bootstrapper.js (http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:109:1)
    at __webpack_require__ (http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:20:30)
    at Object.0 (http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:620:18)
    at __webpack_require__ (http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:20:30)
    at http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:84:18
    at http://localhost:9000/app.77f09c3beb8536a8a5a9.bundle.js:87:10

Expected/desired behavior:
I created a Gist for this issue, but it would not allow me to save. Instead, I created a repository that displays the issue: https://github.com/YardGnomeNinja/AureliaTemplatingFooterTest

What is the expected behavior?
A compose element containing a footer element should not result in error.

Are you sure the footer view and VM are in the build? You are passing a moduleId to <compose> but I don't see anywhere something like PLATFORM.moduleName('resources/elements/footer');.

In my main project, where I discovered this issue, I have a number of compose elements defined in this way without issue. I have not defined any of them as modules.
I have also tested by commenting out only the footer element and retained the rest of the content of footer.html and found it to work as long as footer was commented out.

I've also just discovered, this happens with an aside element as well. Again, as long as I comment out the aside element and retain the contents of the element, the page loads without error.

For sake of thoroughness, I added .plugin(PLATFORM.moduleName('resources/elements/footer') to aurelia.use in main.ts and the issue remains.

I did not mean to pass it to Aurelia.plugin - it is not a plugin.

Sorry, I'm new to the whole Webpack thing. I've only ever seen anything included that way as a plugin. What is the alternative?

So the issue turns out different, as by @bigopon 's explanation, the issue is the VM name class Footer. By convention this turns in a custom element - <footer>. Also custom elements are available in themselves. So now in the view(footer.html) you have a recursion.

That makes perfect sense. Sorry for posting an issue about it. I wasn't aware that was how that worked. Thanks for your insight!


Opencl depth packer processor no longer works..

I have been using your version of libfreenect2(https://github.com/wiedemeyer/libfreenect2) for a while and it was working well with opencl depth packet processing.
But recently after some system updates, the opencl depth packet processing no longer works. It is giving this error:
"[OpenCLDepthPacketProcessor::init] ERROR: clGetPlatformIDs(-1001)
terminate called after throwing an instance of 'cl::Error'
what(): clGetPlatformIDs
Aborted (core dumped)"
I was able to use the cpu depth processing and still get the sensor working, but it much slower compared to before for my task.
I am working on ubuntu 14.04(64 bit), ros indigo and NVIDIA Corporation GK106 [GeForce GTX 660] controller
I still want to use the opencl depth packet processor and not cpu. Please let me know what to do, Thank you!

maybe the maximum depth is set higher, so that far points are not filtered out.


⚠ Fortnite has degraded performance

In 75200fd, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 2517 ms

Resolved: Fortnite performance has improved in 87f0901.


Add AzureAD PowerShell Module to Windows and Linux images

Tool name
AzureAD PowerShell Module
Tool license
Apache License
Add or update?

[X] Add
[ ] Update

Desired version
Stable (most recent, <IP_ADDRESS>)
Approximate size
No response
Brief description of tool
This is one of the common modules that are needed when dealing with Azure Active Directory. It is used to run recurring tasks (using Azure Pipelines) for Azure AD and having it as part of the base image will get things much faster;

I don't see any complication of adding this to Windows or Linux managed agents
It takes the load off the PSGallery website to download the module in every job
It will decrease the run-time of the job and releases agents to the pool faster

URL for tool's homepage
https://www.powershellgallery.com/packages/AzureAD/<IP_ADDRESS>
Provide a basic test case to validate the tool's functionality.
You should be able to find commands like this after the module is installed:
- Get-AzureADCurrentSessionInfo
- Connect-AzureAD

Virtual environments affected

[X] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
I can try :)

Hi @ksaffarian. Could you please change title of the request to include tool you want to add to the image.

May I know what is the next step about this request?

@ksaffarian, we will think about adding AzureAD PowerShell Module to the images and will let you know.

Hello @ksaffarian! Thank you for the request!
Have you considered using Microsoft Graph instead of Azure AD? It looks like the Azure AD PowerShell module will reach EOL in 2022 in favor of Microsoft Graph. Please see the details here

Thanks for the good point @MaksimZhukov
We will look into using Graph SDK.
Can you confirm if that is included in the OS images?

The Microsoft Graph module is preinstalled on Windows images.

I think we can close this issue for now;
Thanks for the help :)


Make elements.code and elements.codespan options work as documented

Issue: https://github.com/cerebral/marksy/issues/38
Current behaviour:
— block code rendering can be overriden only in "components" mode
— inline code is rendered by elements.code not element.codespan
Desired (and documented) behaviour:
— block code rendering can be overriden with elements.code({language, code})
— inline code rendering can be overriden with elements.codespan({children})

@christianalfoni thanks for opening the doors for us to fix this. If you can merge this and publish a new version for us, it'd be much appreciated!

Currently running into issues in Spectacle related to this bug.

Included in #46


Acl manager ut

ACL Manager UT for the rule processing module, including a bugfix to allow multiple security groups on one endpoint.

Markups made.


Feature request: translation files

Hi! I would love to have a translation feature, I can do the English-Dutch translations myself at least :)

duplicate #83


Initial Interop45 sample app

cc @divega
Initial sideby side sample for Identity 2.0 App configured to interop.
Migration code added under Compat directory.
Note: NormalizedUserName/Emails are not updated automatically currently.  Need to wireup OnSaveChanges?

Besides the comments I already made:

I like the idea of fixing things up on SaveChanges(). It should work for normalization of user name and email and also for the concurrency token.
This is a lot of sample code to look at so while reviewing I had to assume that it would be possible that it should be easy to get this code by using one of the default templates for MVC5, then making a few changes and then following whatever the migration steps are. That makes me think that it would be very useful to include a readme file with those steps alongside the sample code.

@HaoK are you planning to make an initial commit and the iterate over it or would you like to get it all fixed in this review?
Personally I think that pushig this even if it is not completely correct would be good as there is a lot of boilerplate code that I would prefer not to look at in subsequent reviews :smile:

Yeah just looking for major stuff. I'm happy to push an initial mostly functional iteration.

Ok, can you please answer if using EF7 for the migration was intentional? Otherwise :shipit:

Just old artifacts there with ef7 migrations

267d0ac20671ec80ae0d45c1988f1347a2dff0b9 will send new PR with next iteration


AWS_SHARED_CREDENTIALS_FILE not working as expected

Issue details
In my CI environment, I am trying to make use of AWS_SHARED_CREDENTIALS_FILE and AWS_CONFIG_FILE environment variables which are not in their default location. This is because these are provided by the CI environment as a File type of variable, so it's held in a temporary file for me.
I know that the files and credentials are correct because in the CI scripts section I am running aws sts get-caller-identity --profile production and I can see the value's i'd expect.
In my Pulumi.production.yaml file I have aws:profile set to production, and locally this works fine (with the ~/.aws/credentials and ~/.aws/config files in their default location).
But in CI, with the environment variables defining where these files are located, it does not work.
To verify whether it worked, in my index.ts file I have the following:
aws.getCallerIdentity().then(provider => {
    if (provider.accountId !== config.require('aws_account_id')) {
        console.error("Assumed a role under the wrong account id", { provider });
        process.exit(4);
    }

    const match = provider.arn.match(/(,*)\/(.*)\/(.*)/)!;

    if (!match) {
        console.error("The provider has not been setup correctly.", { provider });
        process.exit(1);
    }

    if (!match.hasOwnProperty(2)) {
        console.error("The provider has not been setup correctly.", { provider });
        process.exit(2);
    }
});

and in my Pulumi.production.yaml file I have the aws_account_id set to the value of the account that should be assumed.
This again works locally, but not in CI.

Hi @alexbowers - would you be able to have your CI log the value of AWS_SHARED_CREDENTIALS_FILE and AWS_CONFIG_FILE and share?
Also, could you share the output of the Pulumi program? That will help us track this down. :)

I believe this was fixed by https://github.com/pulumi/pulumi-aws/pull/2004
Though #2016 has been introduced.


Bump the worker liveness check timeout to avoid false failures

In some environments I've seen this take over a second to complete.
It runs every 10 seconds so I figure 5 seconds is a fine time to wait.

Jansa backport details:
$ git log -1
commit 63a42ab69d8b716ac05c647fcb3aae316b4a47e2
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Wed Jun 3 09:51:01 2020 -0400

    Merge pull request #20236 from carbonin/bump_worker_liveness_check_timeout

    Bump the worker liveness check timeout to avoid false failures

    (cherry picked from commit 9438f1a7264ee668a57195fc5fee5c733ca63b23)


openjfx11: drop

OpenJFX 11 reached end‐of‐life in 2023.
cc @emmanuelrosa – sorry about the casualty here, but we can’t ship an unsupported multimedia framework that vendors a year+ old copy of a browser engine, especially in security‐critical contexts :) Maybe you’d be interested in reviving https://github.com/NixOS/nixpkgs/pull/318594 now that the error message for the formatting check has been improved?
Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:

bisq-desktop

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I just made another attempt at contributing Bisq 2, but the damn formatter is still getting in the way. https://github.com/NixOS/nixpkgs/pull/347160

Thanks for the great work in those JDK/JFX cleanups @emilazy.

I’ll do a manual backport later.

Thanks for the great work in those JDK/JFX cleanups @emilazy.

I’m currently in the process of deduplicating the OpenJDK/OpenJFX expressions across versions, which is leading to some very interesting revelations about what all that copy‐pasting led to :)


How to use job.Mondays()

Is it possible to schedule a job every two mondays ?
The property mondays() doesnt exist ?

I would use every(60).days instead.

Scheduling a job every n mondays is not supported. You can read here in more details why.
(yes, this should be in the docs. I will add it there)


Is it possible to include non-minimised versions of the CSS in the dist folder?

For those of us non-front end devs that aren't that familiar with SCSS (or want to make a few tweaks without setting up a full build environment).

Sure, if you want to do a PR you are also welcome but otherwise I'll do it, should be pretty easy. The releases folder is there for historic reasons, please use the picnic.min.css on the root.

Nevermind, picnic.css is already on the root.

Cool - that's excellent thanks.


Donut chart labels overlaping/cutting

Hi,
I am using donut chart to display high number values. But its overlapping/cutting and looks ugly, is there any way to fix this.

One approach will be styling texts
.c3-chart-arcs g text {
    font-size: 10px;
}

Hello!
I've the same problem. @netil what do you exactly mean with "styling texts"? I've tried to increase the z-index with the class selector you wrote above. But the data labels still does disappear behind the chart.
Any idea what i can do about it?
Thank you in advance for the answers.


Making Credentials classes Serializable

In order for us to expose google-auth-library-java classes in google-cloud-java (thus dropping our AuthCredentials classes), we need Credentials classes to be Serializable.
One of the main obstacles to making Credentials classes serializable is that some of them contain an HttpTransport field, which is not serializable (see ComputeEngineCredentials for instance).
We faced this issue with our HttpServiceOptions  classes and introduced the HttpTransportFactory interface:
  /**
   * A base interface for all {@link HttpTransport} factories.
   *
   * <p>Implementation must provide a public no-arg constructor. Loading of a factory implementation
   * is done via {@link java.util.ServiceLoader}.
   */
  public interface HttpTransportFactory {
    HttpTransport create();
  }

When serializing an option object we only transmit the class name for the transport factory and try to instantiate the factory from its classname upon deserialization.
Do you think something like this could be done for Credentials classes as well? Opinions are welcome.
/cc @anthmgoogle @garrettjonesgoogle @lesv

One thing that's not clear to me from HttpServiceOptions is why it's necessary to have two layers of indirection, i.e. httpTransportFactoryClassName => httpTransportFactory => HttpTransport.

HttpTransport implementations might have instance fields (see for instance NetHttpTransport.Builder). So while you could serialize them just using the class name and a no-arg constructor the deserialized transport could have have a different behavior (e.g. missing a proxy configuration).
We introduce an HttpTransportFactory and document that it should have a no-arg costructor so we can serialize it just using only the classname. To HttpTransportFactory we can add proper documentation and it's reasonable to assume/require that a factory has no instance fields and an empty constructor.

Ok, that makes sense. This seems like a reasonable approach and I'm personally fine with using it here (google-auth-library-java).

I agree with adding this functionality to Credentials so that it can be used more broadly. There was no decision when this was originally created inconsistent with this.

This was fixed in #69


[SUPPORT]The k8s cluster submitted a task to write Spark streaming to Hudi, but encountered an error

Caused by: java.net.UnknownHostException: mytask-driver-svc.dataaccess.svc: Temporary failure in name resolution
at java.base/java.net.Inet4AddressImpl.lookupAllHostAddr(Native Method)
at java.base/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(Unknown Source)
at java.base/java.net.InetAddress.getAddressesFromNameService(Unknown Source)
at java.base/java.net.InetAddress$NameServiceAddresses.get(Unknown Source)
at java.base/java.net.InetAddress.getAllByName0(Unknown Source)
at java.base/java.net.InetAddress.getAllByName(Unknown Source)
at java.base/java.net.InetAddress.getAllByName(Unknown Source)
at org.apache.hudi.org.apache.http.impl.conn.SystemDefaultDnsResolver.resolve(SystemDefaultDnsResolver.java:45)
at org.apache.hudi.org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:111)
at org.apache.hudi.org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:353)
at org.apache.hudi.org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380)
at org.apache.hudi.org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
at org.apache.hudi.org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.hudi.org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at org.apache.hudi.org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at org.apache.hudi.org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at org.apache.hudi.org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
at org.apache.hudi.org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107)
at org.apache.hudi.org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55)
at org.apache.hudi.org.apache.http.client.fluent.Request.execute(Request.java:151)
at org.apache.hudi.table.marker.TimelineServerBasedWriteMarkers.executeRequestToTimelineServer(TimelineServerBasedWriteMarkers.java:173)
at org.apache.hudi.table.marker.TimelineServerBasedWriteMarkers.doesMarkerDirExist(TimelineServerBasedWriteMarkers.java:99)
... 57 more
I found  this Serivce   'mytask-driver-svc.dataaccess.svc' in my k8s cluster.This is an occasional problem

@xiazhanjia Looks like the it is trying to request to timeline server which may be no longer available. Are you using spot instances?
As a workaround, you can disable timeline server for now and let us know in case you still see the issue.

@xiazhanjia Were you able to resolve this issue?


Fix caching issues

Issues when updating CSS files or device model pictures, for instance.

Unable to reproduce this issue. Steps to reproduce it are needed.

We close this issue for the moment.
@adcoly @Metal-Mighty , please provide us more details about your issues if you can...


Build version indicator

Adds a visual build version indicator by replacing the "PRE" with the version number.
Currently, we'd need a way to distinguish between stable and preview. Right now I've appended a "*" for preview builds, but maybe we should look into adding an icon or appending "-PRE" for preview?
Open to discussion.

All looks good to me, just adding some of my suggestion in comments,
Though I wonder if we need to also add a debug build identifier too but it seems like its unnecessary because we don't ship debug builds in our CI builds

Debug state will never get reached in a client environment because the application is already pre-compiled. So, really, we'd be helping developers. I think it's a cool change to add, but wondering if maybe we'd want to see the "next dev version" or something along those lines (e.g. display 1.71.5 in the case of preview, since it has not been released yet).

All looks good to me, just adding some of my suggestion in comments,
Though I wonder if we need to also add a debug build identifier too but it seems like its unnecessary because we don't ship debug builds in our CI builds

Debug state will never get reached in a client environment because the application is already pre-compiled. So, really, we'd be helping developers. I think it's a cool change to add, but wondering if maybe we'd want to see the "next dev version" or something along those lines (e.g. display 1.71.5 in the case of preview, since it has not been released yet).

When compiling, Collapse is able to detect if the app is running in DEBUG, so I just changed the VersionIndicator to match that:

Alternative:

 Version number indicator

Merging as corrections have been made.


fix(atomic): gave main role to refine modal's content

https://coveord.atlassian.net/browse/KIT-1212
When focusing on the "Sort" heading with TalkBack, it would read out "Sort, InIn". You can see a video of it in the JIRA above.

A document mustn't have more than one  element that doesn't have the hidden attribute specified.

Is there a possible incompatibility with some customer's pages?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main
I think it's a similar problem that we had to face with landmark

A document mustn't have more than one
element that doesn't have the hidden attribute specified.

Is there a possible incompatibility with some customer's pages?
developer.mozilla.org/en-US/docs/Web/HTML/Element/main
I think it's a similar problem that we had to face with landmark

The modal inherently has a risk of being incompatible with a customer's page since it must hide every element outside of it from the tab order and hide them all from the accessibility DOM by giving them aria-hidden.
We are already doing this, and since aria-hidden removes an element and its descendants from the accessibility DOM, there should not, in theory, be any other main element in the page.

I don't think it's a good idea to use main here... If you read the description from MDN :

The main HTML element represents the dominant content of the  of a document. The main content area consists of content that is directly related to or expands upon the central topic of a document, or the central functionality of an application.

I don't think it's fair to say that the refine modal of the search page is "the central functionality of an application"...
Also, even if everything else is hidden, it still causes problem for the validity of the document, if there's more than one main tag present in the page.


Prevent duplicate registration of generic explanation

Like the title says.

The last two commits done here refer to issue #169 instead of this issue.


Feature/remove geodata lookup

I wrote a node service which is adding coordinates to the spreadsheet (data source of events) so we do not have to fetch them for every load.
This commit removes the lookup and uses the coordinates form the spreadsheet instead.
I executed the script locally so we have all coordinate for the currently existing events.
fixes #60
@MichaelKohler Can you setup the script on a server and execute it like every hour or so.

Will merge once I set up the service.

Actually, merging now as this is a major improvement.


[CROSSDATA-646] Crossdata as runs as an application instead as an Upstart service within docker.

Description
After merging this PR Crossdata will be launched as an application within the docker, not as an INIT daemon. That makes its output to be correctly redirected to cluster managers as well as the docker container be stopped if the server crashes.
If the docker is run with the option -e SERVER_MODE=debug it will launch Crossdata as a service within the docker container, that is, as before the PR was merged.
Testing

[x] Manual tests

+1

+1

Wrong branch?


Project Dependencies

I am creating a plugin that I am splitting across a couple projects to reuse some of the code I need for a later project, but I can't find a way to get the packager to pull in the local project .dll other than the root package dll.
I've tried a bunch of different things through mdtool to no avail as every dependency is treated like it should be an addin on its own.
Do you know if this functionality exists with the packager or with mdtool?

From what you're describing you need to register each dll as an AddinDependency. This is a sample of my other addin's depenedency file:
Addin.Assemblies.cs
using Mono.Addins;

// Dependencies
[assembly:ImportAddinAssembly("Parse.dll")]
[assembly:ImportAddinAssembly("Parse.NetFx45.dll")]
[assembly:ImportAddinAssembly("MFractor.Library.dll")]
[assembly:ImportAddinAssembly("MFractor.Licensing.dll")]
[assembly:ImportAddinAssembly("AndroidResourceIndexer.dll")]
[assembly:ImportAddinAssembly("Logging.dll")]

Each dll that is referenced by the project that needs to be included in the final mpack file should have a ImportAddinAssembly attribute used.

Just to note, this is the standard way of bundling dlls into the addin.

Perfect.
Is there standard documentation somewhere for constructing add-ins? Every document I have been using from monodevelop and Xamarin is outdated or incredibly vague and have mainly been looking through other add-ins to find out how they work.

I feel your pain Caleb, the documentation is pretty crap for building addins. Honestly, that methodology (inspecting other addins source code) seems to be the way to go. It's frustrating but eventually you learn enough that your development cadence is reasonable.
I'd absolutely love to be able to build a knowledge base around what I've learnt from building my other addin. Maybe one day I'll find the time...


[wip] Refactor preamble toc.

Will update tests if approach is sound. cc @cmc333333

Is toc-preamble.html missing?

Added it.

Direction makes sense to me

Cleaned up, tests passing. This could use more work--reasoning about child views and their URLs is still much more complicated than it should be--but at least it (mostly) works.

Going ahead with the merge so we can start working with this. Great stuff, @jmcarp


⚠ Samsung has degraded performance

In 484c8e2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2543 ms

Resolved: Samsung performance has improved in 92c587f.


Use actual base class instead of super()

super() is super for complicated class hierarchies, but for such simple cases I think it's not necessary.
I think to a large extent this is a matter of taste, I prefer to use super() only if its really necessary and if it actually makes a difference.
When searching around on the net, I found that the Python community seems to be torn about that issue.
It is considered everything between "super" and "harmful" ...

Fine by me. I have no preference.


fix major or minor bumps

when increasing the major or minor version whe need to move the less important numbers to zero

Its probably easier these days to use: npm version https://medium.com/swlh/how-to-automatically-bump-npm-package-version-feee0e4dde6f


Jongo update doesn't update all fields in this case.

Say i have the java classes:
Parent {
  ObjectId _id;
}

Child {
 ObjectId _id;
 ObjectId parent;
}

A standard parent/child relationship.
If i create a parent, and a child, and set the child to have a reference to parent.
If i then later set the childs parent to null an try to update the collection as follows:
Child child = collection.findOne("{_id: #}",id).as(Child.class);
child.setParent(null);
collection.update(child.getId()).with(child);

The childs parent reference is never set to null. Instead i am forced to run
collection.update(id).with("{$set: {parent: #}}",null);

I'm guessing that if I set the parent field to be a String instead of an ObjectId then this would work fine, as it seems that jongo handles primitives just fine. But shouldn't this case work when using an ObjectId?

What if I want set a field to null????
For instance...
I have
{
  'nome' : 'John Doe',
  'phone' : '123'
}

And I want
{
  'nome' : 'John Doe',
  'phone' : null
}

I need to retrieve entire object, set only one field to null and them update?????

Hello,
You can use $set operator:
collection.findAndModify().with("{$set: {phone: null}}").returnNew().as(Person.class);
//or
collection.update("{}").upsert().with("{$set:{name:null}}");


How can users get a list of pre-installed software without logging into the Fornax Science Console?

Users who are reading the documentation to determine if the Fornax Science Console will be useful for them may want a description of software that is already installed before they bother obtaining an account.
Can this list be automatically generated somehow?

Can this list be automatically generated somehow?

Would be nice to include a humanly digestible version of the docker file, as pointing to the image public.ecr.aws or the configfile won't be useful from the user's POV
cc-ing @zoghbi-a as heasarc maintains the images and he could point me to the image in the first place.


Mustang sample file not valid

Allegedly the 505 ZF1 sample does not validate on validator.zugferd.org

can't reproduce. ZUV 0.4.5 reports no errors and validator.zugferd.org says "ZUGFeRD-PDF und ZUGFeRD-xml sind valide."

The problem was the versionnumber auf download (1...x) in the filename. Sorry!

... sorry, but i can't get a valid ZUGFeRD-PDF with your testfiles or with my own-files :( I working on this problem since days.
With your testfiles i get:
"A file's name dictionary, as defined in PDF Reference 3.6.3, shall not contain the EmbeddedFiles key"
and with my files:
"A file specification dictionary, as defined in PDF 3.10.2, shall not contain the EF key."

... sorry, but i can't get a valid ZUGFeRD-PDF with your testfiles or with my own-files :( I working on this problem since days.
With your testfiles i get:
"A file's name dictionary, as defined in PDF Reference 3.6.3, shall not contain the EmbeddedFiles key"
and with my files:
"A file specification dictionary, as defined in PDF 3.10.2, shall not contain the EF key."

I'll have a closer look, the input should be PDF/A-1 but the output should definitely not be PDF/A-1(B) but PDF/A-3

... here a screenshot from your samplefile.

... and here the output-file.

I opened it as Mustangproject issue https://github.com/ZUGFeRD/mustangproject/issues/57 and I'll close it here


http.ServerResponse is undefined

Hey there, I got this error (like #3592) when trying to compile a react app which was created by create-react-app. It uses express to get socket.io running.
Node.js: 8.11.1
Express: 4.16.3

I've uploaded the code and instructions how to run the app here.

From the code you posted, it looks like you are trying to run express in the browser.  I say this because the express import is in a file which also has document.getElementById.  This is not supported, and I am guessing this code was not generated by create-react-app.  Not sure what you are going for with the posted code, so I cannot help more than that, sorry.

Yeah it was because of that, I've split the server into a seperate file. Now I just need to figure out how to make them work with each other, but I'll hopefully figure this out on my own. Thanks for the tip!

No problem.  Good luck!

I'm having the same issue with my server, but I don't understand how to solve it. When you say you split the server into a separate file, what exactly does that mean? It's my first time trying to set up a server, and I was under the impression that the "server" was actually a bunch of different files working together.

Hey @Jazy1618, I think you should post some code examples on Stack Overflow.  The OP was not an express bug, and my guess is that your issue is also not.  There is also a Gitter for the express community were you can find help.  https://gitter.im/expressjs/express

I was under the impression that the "server" was actually a bunch of different files working together.

This is true, and my assumption based on lack of information from the OP is that it was the code which creates the express instance which was moved to a separate file.

Oh, thank you! I'll post it on the express Gitter with some code.

@EleosOS  - did you find solution for same error i got with react webpack.
TypeError: Cannot read property 'prototype' of undefined

I had this similar issue and the problem was an unintended import { response } from 'express' in one of my services files
Depending on your IDE if you declare a variable or pass params in a function using response it may auto import from express
Example here:

import axios from 'axios'
import { response } from 'express' //Unintended import
const baseUrl = 'http://localhost:3001/api/blogs'

const getAll = async () => {

  exampleFunction(response) //could cause an auto import
  const response = await axios.get(baseUrl) //const declaration could also cause auto import

  return response.data
}

I had this similar issue and the problem was an unintended import { response } from 'express' in one of my services files
Depending on your IDE if you declare a variable or pass params in a function using response it may auto import from express
Example here:

import axios from 'axios'
import { response } from 'express' //Unintended import
const baseUrl = 'http://localhost:3001/api/blogs'

const getAll = async () => {

  exampleFunction(response) //could cause an auto import
  const response = await axios.get(baseUrl) //const declaration could also cause auto import

  return response.data
}

Yeah it was because of that, I've split the server into a seperate file. Now I just need to figure out how to make them work with each other, but I'll hopefully figure this out on my own. Thanks for the tip!

do you mean here to have two separate node_modules folder for each.

Hi everyone, i got the same error how can i solve this please help, I'm working first time with the Backend so i don't have any idea to solve this?
Please help me Thanks in advance


Change is calculated incorrectly for some coin systems

In some situations, getChange method doesn't return correct values.
An example to this is input getChange(12, [1, 4, 5]) - it should result in three coins of value 4 which is the least amount of coins, but it returns two 5 coins and two 1 coins.
Actual behavior:
getChange(12, [1, 4, 5]);
=> { success: true, change: [5, 5, 1, 1], left: 0 }

Correct behavior:
getChange(12, [1, 4, 5]);
=> { success: true, change: [4, 4, 4], left: 0 }

Thank you for your feedback.
I got it wrong indeed and didn't covered the least amount of coin returned.
I'll have a look tomorrow and get back to you.

Hi @petrjoachim,
I reworked getChange() and fixed the issue.
I let you have a look, the changes are published to npm.
25de8ab094b98bf456e8873596bc62a035b5491a


Build failure: xone

Steps To Reproduce
Steps to reproduce the behavior:

build xone

Build log

nix log /nix/store/cbcv9vfynssj9bl0mrxr5zggj9c8rr8m-xone-0.3.drv
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/cbcv9vfynssj9bl0mrxr5zggj9c8rr8m-xone-0.3.drv^*'
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/sxvbr4xpsz2w9zd2mxqsdxl3zkcz6wfi-source
source root is /build/source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/15qds5bbdym41di9g70krvi9d4wjbqyx-kernel-6.3.patch
patching file bus/bus.c
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
build flags: SHELL=/nix/store/4vzal97iq3dmrgycj8r0gflrh51p8w1s-bash-5.2p26/bin/bash -C /nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/build M=\$\(sourceRoot\) VERSION=0.3>
make: Entering directory '/nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/build'
  CC [M]  /build/source/transport/wired.o
  LD [M]  /build/source/xone-wired.o
  CC [M]  /build/source/transport/dongle.o
/build/source/transport/dongle.c:970:10: error: 'struct usb_driver' has no member named 'drvwrap'
  970 |         .drvwrap.driver.shutdown = xone_dongle_shutdown,
      |          ^~~~~~~
/build/source/transport/dongle.c:970:36: error: initialization of 'const struct attribute_group **' from incompatible pointer type 'void (*)(struct device *)' [-Werror=incompatible-pointer-types]
  970 |         .drvwrap.driver.shutdown = xone_dongle_shutdown,
      |                                    ^~~~~~~~~~~~~~~~~~~~
/build/source/transport/dongle.c:970:36: note: (near initialization for 'xone_dongle_driver.dev_groups')
cc1: some warnings being treated as errors
make[2]: *** [/nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/source/scripts/Makefile.build:243: /build/source/transport/dongle.o] Error 1
make[1]: *** [/nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/source/Makefile:1919: /build/source] Error 2
make: *** [/nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/source/Makefile:240: __sub-make] Error 2
make: Leaving directory '/nix/store/q3k5l3bf08s4wa5im3lj63vivqj4ml4y-linux-6.8-dev/lib/modules/6.8.0-zen1/build'
lines 1-32/32 (END)

Additional context
Notify maintainers
@rhysmdnz

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

system: "x86_64-linux"
host os: Linux 6.7.9-zen1, NixOS, 24.05 (Uakari), 24.05.20240309.3030f18
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "nixos"
nixpkgs: /nix/store/nra828scc8qs92b9pxra5csqzffb6hpl-source

Add a :+1: reaction to issues you find important.

I am not able to build either, but my error looks diffrent:
building the system configuration...
error: builder for '/nix/store/qwxaapzybz6zc2sac33p87rkhdl1anws-xone-0.3.drv' failed with exit code 2;
       last 10 log lines:
       >       |          ^~~~~~~
       > /build/source/transport/dongle.c:970:36: error: initialization of 'const struct attribute_group **' from incompatible pointer type 'void (*)(struct device *)' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wincompatible-pointer-types-Werror=incompatible-pointer-types8;;]
       >   970 |         .drvwrap.driver.shutdown = xone_dongle_shutdown,
       >       |                                    ^~~~~~~~~~~~~~~~~~~~
       > /build/source/transport/dongle.c:970:36: note: (near initialization for 'xone_dongle_driver.dev_groups')
       > cc1: some warnings being treated as errors
       > make[2]: *** [/nix/store/46l0ym1wzfffmslhni6awbkd3wy13vrp-linux-6.8-dev/lib/modules/6.8.0/source/scripts/Makefile.build:243: /build/source/transport/dongle.o] Error 1
       > make[1]: *** [/nix/store/46l0ym1wzfffmslhni6awbkd3wy13vrp-linux-6.8-dev/lib/modules/6.8.0/source/Makefile:1921: /build/source] Error 2
       > make: *** [/nix/store/46l0ym1wzfffmslhni6awbkd3wy13vrp-linux-6.8-dev/lib/modules/6.8.0/source/Makefile:240: __sub-make] Error 2
       > make: Leaving directory '/nix/store/46l0ym1wzfffmslhni6awbkd3wy13vrp-linux-6.8-dev/lib/modules/6.8.0/build'
       For full logs, run 'nix log /nix/store/qwxaapzybz6zc2sac33p87rkhdl1anws-xone-0.3.drv'.
error: 1 dependencies of derivation '/nix/store/g60dgqvqygwq194nz7c4fkyfwfs3mqm9-kernel-modules.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-nvidia-x11-550.54.14-6.8.drv-0/NVIDIA-Linux-x86_64-550.54.14/kernel': Directory not empty
error: 1 dependencies of derivation '/nix/store/hk18ylzhlpbcpbrgkgnw4kahwcj201ak-linux-6.8-modules.drv' failed to build
error: 1 dependencies of derivation '/nix/store/1f5lchdxfvjlcyg3l0mvn9qbxfz11i5z-nixos-system-Ni-24.05.20240312.0ad13a6.drv' failed to build

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.7.9, NixOS, 24.05 (Uakari), 24.05.20240309.3030f18`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/nix/store/nra828scc8qs92b9pxra5csqzffb6hpl-source`

I’ll take a look later today. The released version of xone is quite old at this point. And probably has some incompatibility with newer kernels. Development of it has picked up in the last couple of months. Can probably grab some of the newer patches to fix it

Can anyone bump the xone version then?

Can anyone bump the xone version then?

IDK how the versioning should be. There is no new official release since Jun 20, 2022.

Can anyone bump the xone version then?

IDK how the versioning should be. There is no new official release since Jun 20, 2022.

You can use the master branch and set the sha256 value. The Version number is then the date of the commit you use. an example how this work ist here:
https://github.com/Svenum/NixOS-Config/blob/master/custom-nixpkgs/plasma-applet-quickshutdown/derivation.nix

Now it happens on NixOS 23.11 as well when using the latest kernel.
Can #296470 be backported?


[arrow]replace Abi.h with arrow's abi.h

Remove unuseful file Abi.h.

What is the reason behind this change?  We are keeping a copy of Abi.h because we don't want to restrict arrow dependency to tests and parquet for now.  It's a dependency too large and can cause trouble if we use it everywhere.

We are keeping a copy of Abi.h because we want to restrict arrow dependency to tests and parquet only for now. It's a dependency too large and can cause trouble if we use it everywhere like this.

We are keeping a copy of Abi.h because we want to restrict arrow dependency to tests and parquet only for now. It's a dependency too large and can cause trouble if we use it everywhere like this.

Ok,  I know.

Thanks for the understanding


Reduce number of HTTP request caused by .txt files when loading a world

Is your feature request related to a problem? Please describe.
When starting a game world, multiple txt files used by the name generator are being loaded. In the case of a freshly created world with core, altdorf, rnhd and starter set modules enabled, more than 10% of HTTP requests are caused by these txt files:

Describe the solution you'd like
Consolidate multiple txt files into JSON files or load them when needed, not during world initialisation.

I don't think consolidating them is that important. I would suggest that loading them on demand (when opening the character creator) would be better.
But I think the best way to change this would be to do these two things:

Change the NameGenWfrp._loadNames(); call from init hook to ready hook.
Change the NameGenWfrp._loadNames(); method from synchronous to asynchronous.

So it would still be already preloaded in case someone wants to create a character and the app would open without the lag, but it would not load them synchronously on init, which is what can slow down loading.
Unless I'm mistaken how Foundry handles hooks. In that case disregard my comment.


Width and Spacing of Minute Candlesticks

Hello
So we are implementing the candlestick chart with resolution options that include 15min and 30min.  When rendering, the candlesticks appear very skinny and spaced apart.  We would like them to render close to how the rest of the chart does.
Here is the react-stockcharts chart with 15min resolution over 2 weeks:

Here is trading view's chart also with 15min resolution over 2 weeks:

Here is react-stockcharts chart with 1 hour resolution over 1 week:

Additionally, here is the first react-stockcharts with 15min resolution when zoomed up:

Lastly, here is the react-stockcharts with 1hour resolution when zoomed up:

Note how spaced out the bars are from one another in the minutes chart opposed to the hour chart.
I am currently changing the resolutions by interchanging 'utcMinute', 'utcHour', and 'utcDay' from the d3-time package into the 'timeIntervalBarWidth' function that is passed to the width property CandlestickSeries component.
When I tried to access this 'timeIntervalBarWidth' my edits to the function did not make it to the browser.
How do you suggest making the minute candlesticks look more appropriate for the context?
Thank you

I recall this issue, it was with the

When I tried to access this 'timeIntervalBarWidth' my edits to the function did not make it to the browser.

what does this mean your edits did not make it to the browser?
can you change to use plotDataLengthBarWidth and see if that helps?
I don't recall why timeIntervalBarWidth was added.

Okay.  The timeIntervalBarWidth was handy for switching back and forth between resolution types, but yes, does not seem complete.
It is still active in your first candlestick example.  You seemed to have taken a different approach in the second example.
I am now getting an error with plotDataLengthBarWidth

Uncaught TypeError: accessor is not a function

Here is what I am passing it:
import { utcMinute } from "d3-time";

const xScaleProvider = discontinuousTimeScaleProvider
    .inputDateAccessor(d => d.date);
const {
  data,
  xScale,
  xAccessor,
  displayXAccessor,
} = xScaleProvider(initialData);

const moreProps = {
  xScale,
  xAccessor,
  plotData: data_back
};

<CandlestickSeries width={ plotDataLengthBarWidth(utcMinute, moreProps) }/>

I meant by..

When I tried to access this 'timeIntervalBarWidth' my edits to the function did not make it to the browser.

..is that when I tried to add a debugger/console logs they were ignored.  Not sure why or how that was the case.

can you try
<CandlestickSeries />

not including width breaks everything

I dont know what the problem is, do you have a few mins to chat about this on gitter?

Sure.  Just messaged you on there.

Closing as @colorwheeloflife got this working

was there a fix to this issue?  i'm having the same problem

Oh, I love it so much when the issue got fixed but no solution is posted.

Wow, nobody even bothers to reply. Thanks so much.

I think this is an issue about bar width not automatically adjusting on different time frames, right? (I'm too lazy rn to read it through :3 ) if so:
@rm-rf-etc and for anyone interested - I have no clue how to make this calculate proper sizing automatically again but for my use case I've simply made a dict of d3 timeframes like that:
periodToTimeIntervalMap: {
		"1m": utcMinute,
		"5m": utcMinute.every(5),
		"30m": utcMinute.every(30),
		"1h": utcHour,
		"3h": utcHour.every(3),
		"1d": utcDay
},

And then provide appropriate one to CandlestickSeries's width property as timeIntervalBarWidth(timeInterval).
Well, in fact, I have a proxy/accessor that also allows me to adjust bar width returned by timeIntervalBarWidth to achieve a slight gap between bars:
function barWidthAccessor(widthMult) {
	return function() {
		return widthMult*timeIntervalBarWidth(timeInterval)(...arguments);
	}
};

And then use it like:
<CandlestickSeries
	...
	width={chartHelpers.barWidthAccessor(0.8)}/>

Would've been better if this all worked automagically, but it's better than nothing, hope it helps :)

Wasn't easy to find even after reading all ... so leaving last message what worked for me
<CandlestickSeries width={timeIntervalBarWidth(utcMinute.every(1))}/>


Develop Readme Driven d

Develop a detailed  readme that contains all the necessary components of the project.
Subjects to be included:Introduction
- [ ] Statement of intent
Overview
- [ ] Design/ Figma link
- [ ] Project Roadmap (diagram)
Getting started/ Usuage
- [ ] Installation
- [ ] Show use case example
- [ ] Live Demo
What we need todo?
FAQS
Contributors
Resource


"change:..." events sometimes not fired for CollectionView cell children

This example works the following way:

The visible data item property gets updated on demand (when the toggle visible button is pressed) and a refresh() is called for the corresponding item.
Item visibility is set depending on the data item value in the change:item callback.

The change:visible callback is then called only on the first property change of the cell although one would expect it to be called on every property change.
var page = tabris.create("Page", {
  title: "Hello, World!",
  topLevel: true
});
var items = [{visible: true, text: "foo"}, {visible: true, text: "bar"}];

var collectionView = tabris.create("CollectionView", {
  layoutData: {left: 0, top: 0, right: 0, bottom: 0},
  items: items,
  itemHeight: 100,
  initializeCell: function(cell) {

    var composite = tabris.create("Composite", {
      layoutData: {left: 3, top: 3, width: 94, height: 94},
      background: "red"
    }).on("change:visible", function() {
      console.log("composite visible changed");
    }).appendTo(cell);

    tabris.create("Button", {
      text: "toggle visible",
      layoutData: {right: 0, top: 0}
    }).on("select", function() {
      var itemIndex = cell.get("itemIndex");
      items[itemIndex].visible = !items[itemIndex].visible;
      collectionView.refresh(itemIndex);
    }).appendTo(cell);

    cell.on("change:item", function(widget, item) {
      cell.set("itemIndex", items.indexOf(item));
      composite.set("visible", item.visible);
    });

  }
}).appendTo(page);

page.open();

This happens "by design": as cells get recycled by the client it is not predictable whether a recycled cell is shown or if the property of the certain view in the cell has changed.


Nesting components deeper than one level

Is this possible? I have a component which is nested deeper into a Formsy.Form, but I get:
Uncaught Error: Form Mixin requires component to be nested in a Form

To give more info, some parts of my form are a collection of inputs which affect each other, so I extracted them as separate components.

It's not possible with the currently released version, but will be coming in a future release.
See https://github.com/christianalfoni/formsy-react/issues/158.

Great! Closing this then…


StateMachine Update in real world

type IStateMachine interface {
  Update(data []byte)  uint64
}

in a real world, we cann't assume Update() always have the same result. If one of node failed to Update, lastApplied is still updated. How can we avoid this ?

we cann't assume Update() always have the same result

No, when using consensus algorithms, a big requirement (not assumption) is that Replicated State Machines backed by the consensus algorithm are deterministic. With the same initial state and the same input (the data []byte input here), calling Update() on all your replicas should lead to the same output and the same new state.

If one of node failed to Update, lastApplied is still updated.

Please define what do you mean by "failed to update".
When one of the nodes failed to "Update" because the input is considered as invalid, while other nodes all successfully complete the Update as they see the input as valid, then you have a bad design for your state machine. See the explanation above.
When one of the nodes failed to Update because the disk is faulty or run out of memory, then you must panic inside the Update method. The lastApplied value is not persisted. Once the issue is resolved, you can restart the Raft node and the same log entry will be executed again using the Update() method.
When some requests can not be fulfilled by design, that is not a failure. Say when all your State Machines show that variable X maintained by your State Machine has a value of 1,  but Update() wants to run an update command "X=2 if X==3", obviously it is not a failure, all your State Machines should return a uint64 code to indicate such outcome.

by failed to update i mean disk faulty. Your answer is quite clear to me.
Thanks a lot.


Upload Artwork to CNCF

For Sandbox onboarding (https://github.com/cncf/toc/issues/556)

[x] Assets: Horizontal, Stacked, Icon
[x] Assets: Color, Black, White
[x] Assets: PNG, SVG
[ ] GitHub: add cdk8s to https://github.com/cncf/artwork/blob/master/examples/sandbox.md

https://github.com/cncf/artwork/pull/209


restore display of tl-slidenav-title and tl-slidenav-description elem…

…ents as per original knightlab Timeline

@rezeau To me, https://github.com/NDLANO/h5p-ndla-timeline/blob/master/src/styles.scss#L86-L90 feels like a pretty deliberate choice to not have the navigation title and description visible. You may want to discuss changes that are not fixing obvious bugs beforehand.

Yes, we decided to not have them to simply improve accessibility and give it a more clean look.


Environment not working

Describe the bug
Can someone explain to me how to make the environment work with a file? With the preset it works well. using useEnvironment doesn't work either.
I tried with a file in the public folder
<Environment
  path="/milkyway-4k.jpg"
  :background="true"
/>

but also by importing it from the assets folder.
import MilkyWayEnvironment from<EMAIL_ADDRESS>
<Environment
  :path="MilkyWayEnvironment"
  :background="true"
/>

When using the component I get only a warning :
[Vue warn]: expose() should be passed a plain object, received ref.
  at <Component path="/milkyway-4k.jpg" background=true >
  at <App>

When I use useEnvironments I get 2 warnings and 1 error :
[Vue warn]: injection "useTres" not found.
Unhandled error during execution of setup function
tres.js:431 Uncaught (in promise) Error: useTresContext must be used together with useTresContextProvider

I tried to import the environment image into Stackblitz but it doesn't work.
Reproduction
https://stackblitz.com/edit/tresjs-basic-8r1lk7
Steps to reproduce
No response
System Info
No response
Used Package Manager
yarn
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi @KaliaJS thanks for reaching out.

I tried with a file in the public folder

path is not the correct prop, you need to use files and accept and array of .jpeg or an hdr file, you cant pass only a jpg because Environment doesn't work that way, it only accepts a CubeMap of images or .hdr files
Check here for usage https://cientos.tresjs.org/guide/staging/environment.html#usage.

I tried to import the environment image into Stackblitz but it doesn't work.

Yeah that doesn't work most of the time when that happens you can create a reproduction repo based on https://github.com/Tresjs/starter so I can take a look 😊

@alvarosabu Okay thank you I understand better.
I had tried with an EXR file and thought the extension was not important. I thought we could also put a jpg if we wanted to use only the background.

@alvarosabu It's working but I've a warning in the console saying :
expose() should be passed a plain object, received ref.
  at <Component files= (6) ['/src/assets/environments/space-posx.jpg', '/src/assets/environments/space-negx.jpg', '/src/assets/environments/space-posy.jpg', '/src/assets/environments/space-negy.jpg', '/src/assets/environments/space-posz.jpg', '/src/assets/environments/space-negz.jpg'] background=true >
  at <App>

Any idea why ?


[MRG] Nicolet reader.

IO module for reading Nicolet files.

you'll need to add a super tiny file for testing.
thanks @jaeilepp

you'll need to add a super tiny file for testing.

Should I add data for testing?

Should I add data for testing?

yes. A super tiny file. 30kb or something if you can.

If it needs to be bigger it can go in the testing repo

Does someone know if I need to add the testing data path somewhere for travis to find it?

see MANIFEST.in and setup.py

This is ready if we don't want anything fancier.

did you try the reader of more public data accessible online?

did you try the reader of more public data accessible online?

What do you mean by this?

is there any public data in this format? to check our reader generalizes to other systems

I couldn't find any sample data online.

LGTM
let's fix the travis problem on py35 first
then rebase and squash everything into one commit.

also you'll need to update what's new + python reference rst file.

with the other EEG readers, the argument order is ...eog, misc,..., here, we have intervening channel types ...eog, ecg, emg, misc,.... do we want to keep that other?

with the other EEG readers, the argument order is ...eog, misc,..., here, we have intervening channel types ...eog, ecg, emg, misc,.... do we want to keep that other?

+1 for being consistent.

Ready for review.

took care of it.
rebased + merged after a cosmit:
69d9edadeb2a0e939c553f11d957ecafbdf7f236
thanks @jaeilepp !


Make rules Manager Update method  no-op after Close

Fixes #14146
This is an alternative approach to PR #14175
I considered @machine424's initial suggestion to set m.groups to empty slice. However in case Update is called after Close we would end up with new rule groups running and that cannot be stopped using Stop since it is not possible to call Stop twice. Actually the same thing happens with #14175 . The approach in this PR makes for a cleaner shutdown: no dangling go-routines that are stopped in an unpredictable way.
As @roidelapluie mentioned, we don't have any case were we restart a stopped ruler, so I think this approach is acceptable.
Credits to @machine424 for providing the unit tests.

PS:
Another approach that I also considered, but that I don't think it is worth implementing is to make Update after Close return an error, (i.e.: make it illegal), but that would not solve the problem of the race condition during shutdown because it would produce misleading error messages in case there is a reload after SIGTERM.
We would need to either:

Avoid calling Update during reload in case the manager is already closed by adding a new method to it IsClosed and a mutex that controls the access to the manager.
Implement error types for the Update method that the reloader could use to distinguish between real errors and expected errors.

Thanks for working on this!


Importing shapefiles with projection is broken

Since the update of proj4 to use default exports this library doesn't work anymore when importing shape files in a zip with included projection file or a separate projection string.
The imports of proj4 for this library would need to be changed to either use ES6 module imports, or to
require('proj4').default, otherwise what it imports isn't a function.

Maybe this is the fix for https://github.com/calvinmetcalf/shapefile-js/issues/75?

@estaub seems very likely

#84 should fix this I should be able to publish this latter today

v3.4.1 is published

Confirmed as fix for #75.


Add stress tests

Add tests that give a hard time to the library.

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Prevent concurrent writes

Concurrent writes might lead to invalid JSON being saved in the cookie jar.
Backport changes from https://github.com/guzzle/guzzle/pull/1884 to the master (so they will be available for the 6.x release).
Related https://github.com/guzzle/guzzle/issues/1883

@sagikazarmark I've rebased against the master and tests are green now ✨

Thanks @j0k3r !


preprocess _transfrom function

For preprocess:
Compose(
Resize(size=224, interpolation=bicubic, max_size=None, antialias=None)
CenterCrop(size=(224, 224))
<function _convert_image_to_rgb at 0x7f6d51348af0>
ToTensor()
Normalize(mean=(0.48145466, 0.4578275, 0.40821073), std=(0.26862954, 0.26130258, 0.27577711))
)
I don't understand that why the code uses CenterCrop with size 224,224
when image is already resized to 224,224?   (Resize(size=224, interpolation=bicubic, max_size=None, antialias=None))
what's the use for CenterCrop here? is it neccesary to do centercrop here?
thanks!!

torchvision docs: Resize

size: Desired output size. If size is a sequence like (h, w), output size will be matched to this. If size is an int, smaller edge of the image will be matched to this number. i.e, if height > width, then image will be rescaled to (size * height / width, size).

_transforms(n_px) takes in a single n_px value equal to the input_resolution of the image model. So as per the docs, the smaller edge on image becomes n_px long. Then a final CenterCrop for n_px*n_px image.


Update todos example

Store could be read-only.

const doesn't make the store read-only, just the instance variable for it.


Deactivate button does not reflect deactivation in Metamask

Cool repo!
Bugreport:
The deactivate button does not seem to propagate to Metamask (I have not tested for other wallets).
After connecting:

After disconnecting:

As can be seen the little green dot shows that one is still connected
Find a minimal working example here.

Yeah I noticed this error, too. I have deactivated my metamask account, but this package still returns the address of my metamask. It means that it actually has not deacticated the connection.

I might be wrong, but I believe calling deactivate() simply clears the web3-react state machine (from useEthers() in this package).
So { account, connector } etc. you destructure from useEthers() will be cleared.
The fact that Metamask still shows "connect" just means you have previously granted permission for Metamask to connect to this domain and inject the web3 provider into the browser to be used for reading/writing to some network. You can always revoke this permission from your wallet.

@FBosler I strongly feel that you have 2 more accounts in your metamask. I think you have deactivated the app from the account 1, but I think that you have not deacticated the app from account 2.

yes I have the same issue

Same issue here.

yeahh, I'm facing the same issue

same issue!

Metamask does not share deactivating from page api.


index.query() missing 1 required positional argument: 'queries'

index.query appears to require an attribute ['queries'] that is not documented.
index = pinecone.Index(index_name='my-index')
index.query(vector=vector, top_k=1, include_values=True, include_metadata=True)

TypeError                                 Traceback (most recent call last)
/var/folders/l0/ktlckjc908l0dxxgj_ctm15r0000gn/T/ipykernel_78177/4103042064.py in <module>
----> 1 index.query(vector=vector, top_k=1, include_values=True, include_metadata=True)

/usr/local/lib/python3.9/site-packages/pinecone/core/utils/sentry.py in inner_func(*args, **kwargs)
     21     def inner_func(*args, **kwargs):
     22         try:
---> 23             return func(*args, **kwargs)
     24         except Exception as e:
     25             init_sentry()

/usr/local/lib/python3.9/site-packages/pinecone/core/utils/error_handling.py in inner_func(*args, **kwargs)
     15         Config.validate()  # raises exceptions in case of invalid config
     16         try:
---> 17             return func(*args, **kwargs)
     18         except MaxRetryError as e:
     19             if isinstance(e.reason, ProtocolError):

TypeError: query() missing 1 required positional argument: 'queries'

My fault, was using version 2.0.3. Upgrade to v2.1.0 and issue is fixed.


Loss Module

While I was trying to run the train.py, I faced the following error, because their is no loss code. Could you provide the loss code?
Thank you.
Traceback (most recent call last):
File "train.py", line 4, in
from loss import get_loss_fn
ModuleNotFoundError: No module named 'loss'

Sorry, the code is not fully ready since I am working on incoming ddls. I have added the loss function and slightly modified the train.py. I used the Temple sequence from SPMCs set https://github.com/jiangsutx/SPMC_VideoSR as validation set.

Thank you for your fast reply :)

Also, may I ask if you could upload the SR_datasets.py? train.py refers to it.
train.py
line 5: from SR_datasets import *

Yes, I have added it. Please check the SR_datasets.py.

Thank you so much for the fast feedback :D

Sorry for the inconvenience.


Support to infer the schema from external files

What problem does the new feature solve?
Following #1041, We plan to support file external table.
We are allowing users to create an external table without table schema definition, and the database will infer the schema from the external file(s)
MySQL> CREATE EXTERNAL TABLE city with(location="/var/data/city.csv");

What does the feature do?
Single file
Infers table schema from a single file is the simplest case. However, we might need to support inferring data schema from part of the file in the future (it employs an AsyncReader and reads limited rows to infer data schema).
Merge multiple schemas
For multiple files, we plan to support the following modes: union mode, and intersection mode.
Assuming we have schemas: A, B, C, and D, only when A is compatible with B, B is compatible with C, and C is compatible with D. Then the database will try to merge the above schemas. i.e., It will throw an error if multiple schemas are non-compatible. (compatible schema, see also #1330)
Union Mode
In union mode, it will keep fields appearing in any schemas and set all values of absence fields in a file to NULL (i.e., it assumes absence fields' values are nullable).
e.g., for schema A, and B
A:
(
    host STRING,
    idc STRING,
    memory_util DOUBLE,
    power_consuming DOUBLE,
    ts TIMESTAMP
)

B:
(
    host STRING,
    idc STRING,
    cpu_util DOUBLE,
    disk_util DOUBLE,
    ts TIMESTAMP
)

Union_Merge(A, B):
(
    host STRING,
    idc STRING,
    cpu_util DOUBLE,
    memory_util DOUBLE,
    disk_util DOUBLE,
    power_consuming DOUBLE,
    ts TIMESTAMP
)

Intersection Mode
In intersection mode, it will keep fields appearing in all schemas.  It throws an error if there are no fields left when merging.
e.g., for schema A, and B
A:
(
    host STRING,
    idc STRING,
    cpu_util DOUBLE,
    memory_util DOUBLE,
    power_consuming DOUBLE,
    ts TIMESTAMP
)

B:
(
    host STRING,
    idc STRING,
    cpu_util DOUBLE,
    disk_util DOUBLE,
    ts TIMESTAMP
)

Intersection_Merge(A, B):
(
    host STRING,
    idc STRING,
    cpu_util DOUBLE,
    ts TIMESTAMP
)

Implementation challenges
No response

Can we mark this issue as finished?

We don't have to include infering schema from multiple files in this topic. I believe explicit schema altering and column mapping (the ETL approach) is resonable.


#723 - [Manual] - Previous search results from cache are displayed in offline mode for a new search request - Implemented

#723 implemented

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Vadim-Bulavin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Call Resource.FormatError_FileNotFound instead of doing string.Format

Fixes #171

cc @Tratcher \ @Eilon

Make sure to check the other providers: https://github.com/aspnet/Configuration/blob/dev/src/Microsoft.Framework.ConfigurationModel/ConfigurationExtensions.cs#L37

Updated

:shipit:


Using WebRTC-Scalable-Broadcast with this plugin

Hello Guys,
First of all, thanks for all your work. It's amazing.
Okay, now to the problem. I am having issues implementing https://github.com/muaz-khan/WebRTC-Scalable-Broadcast as an iframe with this plugin. Generally I use webrtc iframes with your plugin and they work fine. But for this scalable-broadcast feature, I am not able to find RTCPeerConnection and RTCIceCandidate functions. Can you guys give it a little bit of time and have a look at it ?
Cheers

Those functions are exposed in the Cordova namespace for this plugin, that is, cordova.plugin.iosrtc. These are the exported classes: https://github.com/eface2face/cordova-plugin-iosrtc/blob/master/js/iosrtc.js#L38
I don't know if you'll run into any trouble for using an iframe though,

@okpatil4u nobody will take his time to check your whole app code and plugin usage, nor what such a 3rd party WebRTC library does. You almost provide zero details regarding what you are doing and which exact error you get stuck with.
Note also that questions must be done in the public mailing list, and not here.

@ibc no worries. @saghul 's explanation was good enough.


[Log View] Show logs in a real-time mode

This issue covers the following requirements:
[REQ-LOGS-011] The user should be able to view the logs in real time

By clicking Follow Log button table becomes emty with No results (in case no new logs are sent).

Steps:

Login and go to Logs
Select VM with logs and press Show Logs (See the logs appear)
Press Follow Logs

Expected: Logs are the same as before pressing Follow log
Actual: No results is present


⚠ Bofrost.lu has degraded performance

In ef85b7d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2362 ms

Resolved: Bofrost.lu performance has improved in e65c22c.


error 404 on bs-component.component.html

downloaded zip
extracted
npm install
npm start
browser stuck:
Failed to load resource: the server responded with a status of 404 (Not Found)
Unhandled Promise rejection: Failed to load http://localhost:5555/app/dashboard/bs-component/bs-component.component.html ; Zone: <root> ; Task: Promise.then ; Value: Failed to load http://localhost:5555/app/dashboard/bs-component/bs-component.component.html undefined
Error: Uncaught (in promise): Failed to load http://localhost:5555/app/dashboard/bs-component/bs-component.component.html(…)

if I try
gulp build.prod
output is
[...]
[00:58:26] Starting 'build.js.prod'...
Error: ENOENT: no such file or directory, open '/home/roberto/tinbroker-dev-frontend/dist/tmp/app/dashboard/bs-component/bs-component.component.html'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.fs.readFileSync (fs.js:397:15)
    at getFileData (/home/*deleted*/node_modules/gulp-inline-ng2-template/parser.js:281:17)
    at /home/*deleted*/node_modules/gulp-inline-ng2-template/parser.js:245:22
    at /home/*deleted*/node_modules/async/dist/async.js:3671:13
    at replenish (/home/*deleted*/node_modules/async/dist/async.js:884:21)
    at /home/*deleted*/node_modules/async/dist/async.js:888:13
    at eachOfLimit (/home/*deleted*/node_modules/async/dist/async.js:915:26)
    at /home/*deleted*/node_modules/async/dist/async.js:920:20
    at _parallel (/home/*deleted*/node_modules/async/dist/async.js:3670:9)

problem found in src/client/app/dashboard/bs-component/bsComponent.component.ts
line 7
from
   templateUrl: './bs-component.component.html',
to
    templateUrl: './bs-Component.component.html',


NIFI-2574 checkpoint commit to allow 1831 progress

Builds fine.  Just cannot run tests.
mvn clean install -DskipTests
But this lets NIFI-1831 work continue while i clean up NiFiProperties static singleton usage
Will remove getInstance() method altogether and will remove BOGUS_INSTANCE and will not extend Properties

As of right now, I have merged these commits into PR 834 and the build compiles, checkstyle passes, and all current tests pass.
There is still substantial cleanup work to do and because of the change from NiFiProperties.getInstance() to using NiFiPropertiesLoader.get(), the integration with Spring for web-api still needs to occur.
Thanks for the help @joewitt .

@alopresto ok this is now fully up to date with master, full clean build w/contrib check solid.  Standalone app and cluster up and running.  There is some gremlin there still.
@markap14 can you please take a look at this PR/build it and do a simple GenerateFlowFile -> UpdateAttribute flow and let it run.  The UpdateAttribute won't pull the data from the queue and expiration won't work either.  I clearly missed something.  If you could help find the issue that would be wonderful.
@alopresto I think we should get this wrapped up and merged into master and then NIFI-1831 should be safely layered from that basis.

@joewitt it appears that the queue swap threshold isn't set when the Connection Builder is created/populated

I checked this out, ran the build (with tests and contrib-check) and started an instance and verified the flow mentioned above. I'd like @markap14 to give a +1 before I merge it back to master though.

I left a couple of inline comments regarding a few typos that I noticed, but these are really not related to this PR, just things that I noticed along the way as reviewing. I'm not seeing anything wrong with the changes here. Am +1 to merge as-is


Update social icons' hover colors to reflect original brand colors

Pull Request Description
Overview
This PR does the following:
Updates the hover colors of social icons to reflect their original brand colors.
Related Issues
Fixes #469
Changes
List the detailed changes made in this PR:
Changed hover color for LinkedIn icon to #0077B5.
Changed hover color for GitHub icon to #211F1F.
Changed hover color for Instagram icon to #E1306C.
Also apply transition on each icon
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
Pull this branch.
Run npm install to install dependencies.
Run npm start to start the development server.
Verify that the hover colors for the social icons match their original brand colors:
Hover over the LinkedIn icon and confirm it changes to #0077B5.
Hover over the GitHub icon and confirm it changes to #211F1F.
Hover over the Instagram icon and confirm it changes to #E1306C.
Check that any other icons have the expected hover colors.
Screenshots
https://github.com/user-attachments/assets/aba7fcdb-32d0-4a9f-abfd-14478466f237
Additional Context
Any additional context or information that reviewers should be aware of:
This PR is based on the issue reported regarding the visibility of social icons during hover states.

@MuhammadAshraf23 Resolve these conflicts please.

@Suman373 please merge it

@Suman373 please merge it

The PA will merge if after verifying


Compare records

View original record and enhanced record side-by-side

SearchIndexDocument model (subclass of SolrDocument) allows a single document returned from a Solr query to be associated with its DPLA::MAP::Aggregation
New initializer mix-in to DPLA::MAP::Aggregation allows aggregation to be associated with its original record
Allows OriginalRecord to be loaded from an identifier with a mime type extension
Rake tasks save sample aggregations and original records to Marmotta
New records#show view with helper methods in SearchResultsHelperBehavior
IndexService does not attempt to index fields that are not defined in the Solr schema

To test in browser:

Generate test app with engine cart
You may need to stop, clean, and config jetty
Follow new instructions in README.md to save a sample valid and/or invalid record
Open /krikri/records in your browser and click on a record to view records#show

Great work! I think none of my feedback should require anything super complicated. I'm also raising a few questions here and there (mostly for @no-reply).

This looks awesome.  Minus the few tweaks still outstanding from comments, I think it's ready to go.
I believe it will pass CI once rebased to a point after the merge of #88.

Do not merge yet - awaiting feedback from Gretchen.

As per request from Gretchen, the view layout has been changed so that enriched record appears to the left of original record.

:rocket:


MGDOBR-1228: Adopt TableView from app-services-ui-components

Task: https://issues.redhat.com/browse/MGDOBR-1228
After these changes, we have almost all IT tests failing because they were based on ouiaIds or different DOM structures.

@kelvah, apart from the test failures that we were already expecting, there is also one change in the UI's behavior.
When we had no instances/processors previously it was like this:

Now, with TableView, we should adopt a solution like the one used by the Kafka Instances table:
https://redhat-developer.github.io/app-services-ui-components/?path=/docs/kafka-kafkainstances-components-emptystatenoinstances--empty-state-no-instances
Is it ok for you? Should we also involve UX in that change, or is it expected with the adoption of this component?

@kelvah, apart from the test failures that we were already expecting, there is also one change in the UI's behavior. Is it ok for you? Should we also involve UX in that change, or is it expected with the adoption of this component?

@vpellegrino we chatted about this on our call earlier. Just to keep track of things also here, the new behavior was agreed with UX team already. So fine for me to follow their guidelines and switch to the "empty state" replacing the table.

When I have started to create Mocked and Dev Quality Checks I was followed the OUIA Standard which looked as the good practice:
https://www.patternfly.org/v4/developer-resources/open-ui-automation/
https://docs.cypress.io/guides/references/best-practices
The label might reflect the UX experience better but it might be a source of instability like change lables, find substrings, etc.
In case that there are a lot of changes and the UI offers new views, user's useages, adopt the v2 backend. We should disable quality checks and consider new implementation. What do you think @Srihari1192 .
The OUIA supports was added by qe members and sometimes it was not trivial. I understand that the implementation of ouia standard might slow down a progress on UI. The new component brings new behaviour (it requires more wait rutine).

@sjamboro Yes agree, if our new UI is adopting to v2 SDK, we can disable the quality checks for now as it's failing.

There are my thought about this code. This migration hides ouiaId implementation and there is not support to set data-ouia-component-id. In such situation the only reasonable solution is contains("button", "Create processor).. I know that it is a common approach in UI. I was solving several issues when labels was substring of another one and it broke our test. Currently we have possibility to find it directly in PR so it could not be pain. This PR changes only a small piece of test suite but in case that we will adopt more components it could be a reason why we lost a benefits of ouia standards.

@sjamboro I am not sure I get all points you mentioned in the review you submitted.
BTW, I am 100% open to including in this PR different solution. So, feel free to open a PR against my branch.

@sjamboro, can you please review this PR and let me know if you have further considerations?


Can't customize 502 error page

Hello
I tried to adjust the template to support customized error pages:
server {
        server_name _; # This is just an invalid value which will never trigger on a real hostname.
        listen 80;
        access_log /var/log/nginx/access.log vhost;
        error_page 502 /50x.html;
        return 503;
}

server {
        server_name {{ $host }};
        listen 80 {{ $default_server }};
        access_log /var/log/nginx/access.log vhost;
        error_page 502 /50x.html;

But it seems not to work correctly, I'm still getting '502 Bad Gateway'.
Any ideas?
Thanks
Manuel

It is unclear of what you actually did. Can you explain it in another way?

Check the issue #275
Basically, because of nginx shenanigans, you need the return 503; line inside a location /.


Unable to start

Jul 13 20:28:44 parsers.c:959 moloch_parsers_classifier_register_port_internal(): Parser 'dhcpv6' built with different version of moloch.h
392 != 384
////
moloch version：2.3.2
os： Centos 7

We use github for feature requests and bug reports, please use slack for questions. Looks like you have 2 versions installed.


Parsing raw html

It would be great if we could pass a raw HTML string to be parsed rather than relying on the library to make a request. Some websites are blocked on my server, so this library will throw HTTP errors. Using a proxy service works well to get around this, but there's currently no option to pass the HTML to urlMetadata().

That's an interesting use-case, will implement.

This would be favourable to me too. I'm using this for link expansion and a link can potentially link to other content types, like image/jpeg in which case this throws.
I'd handle other content types myself and only pass response to url-metadata in case of html response. For me it would be more convenient to pass a Response object rather than html string.

Ok, thanks for additional context. Have to think on this some more & how it fits with various use-cases. I like the suggestion of passing back Response vs throwing error.

Updated roadmap
FYI @arosiclair @MartinMalinda
https://github.com/laurengarcia/url-metadata/commit/ae90a39ee5f083db92b5b123356085f9407f53aa

Latest update: version 3.5.0 is in production
https://www.npmjs.com/package/url-metadata
Ended up keeping it very simple. Added an option to pass in  a Response object. Passing in a raw html string was trickier bc it opens a can of worms around decoding without response headers present. This should fulfill requirements for both use-cases described above.
Implementation details in https://github.com/laurengarcia/url-metadata/pull/74
Updated README and tests, refer to those if you need more details.
Sample usage:
// Alternate use-case: parse a Response object instead
try {
  const url = 'https://www.npmjs.com/package/url-metadata';
  // fetch the url in your own code
  const response = await fetch(url);
  // ... do other stuff with it...
  // pass the `response` object to be parsed for its metadata
  const metadata = await urlMetadata(null, { parseResponseObject: response });
  console.log(metadata);
} catch (err) {
  console.log(err);
}