Identify and document removable dependencies

We want to go through the whole ClimaCoupler package and identify dependencies that we can easily remove. This will decrease compile time, and make sure that we're actually using all the dependencies we pull in.
Environments to go through

top-level Project
experiments/ClimaEarth
test
experiments/ClimaCore
docs

Part of https://github.com/CliMA/ClimaCoupler.jl/issues/1050
Dependencies we can remove
(to be filled out)

Packages I found can be removed without implementing any new methods:
(note: I have not tried removing any of these and running)
top level

Artifacts

experiments/ClimaEarth

ClimaCorePlots
Interpolations (indirectly dep) (needed for ClimaUtilitiesClimaCoreInterpolationsExt, which is never used -  check this , maybe in Project.toml for compat)
Glob
JLDL (indirectly dep)
OrderedCollectrons (indirect dep)

experiments/ClimaCore

Thermodynamics (indirectly dependent)

test

Adapt (indirectly dep)
CairoMakie
ClimaAnalysis
ClimaCorePlots
ClimaLand (indirectly dep,  maybe in Project for compat)
ClimaTimeSteppers (indirectly dependent)
ClimaUtilities (indirectly dependent,  maybe in Project for compat)
Downloads (indirectly dependent,  maybe in Project for compat)
GeoMakie
Interpolations (indirectly dep)
IntervalSets (imported with using, need to check,  maybe in Project for compat)
LinearAlgebra (indirect dep)
OrderedColelctions (indirect dep)
Plots
PrettyTables (indirect dep,  maybe in Project for compat)
Printf (indirect dep)
SciMLBase (indirect dep, maybe in Project for compat)
Statistics  (indirect dep)

docs

Pkg

Most of these are indirect dependencies/never imported, so I don't think removing them from Project.toml files wouldn't make compilation any faster. It seems like experiments/ClimaEarth has a lot of dependencies that are used for plotting and leaderboard.

Most of these are indirect dependencies/never imported, so I think removing them from Project.toml files wouldn't make compilation any faster.

It's a bummer that removing most of these won't help with compilation time. It would still be good to remove everything you identified so our environments only have what we need.

It seems like experiments/ClimaEarth has a lot of dependencies that are used for plotting and leaderboard.

We could potentially move the plotting + leaderboard code into an extension that's only loaded for simulations where we want postprocessing. We can discuss and think about if this would be worth the effort.


batch-shuffle-interface-poc

What is the purpose of the change
This PR is a draft for convenience of obtaining the main code diff of the ResultPartitionWriter interface changes.
The main purpose of the ResultPartitionWriter interface improvement is for sort-merge based batch shuffle. To make it possible to implement the sort-merge based batch shuffle, after discussion, we decide to add record-oriented interfaces to ResultPartitionWriter and remove the old buffer-oriented interfaces. However, this change introduce additional per-record overhead and result in 5% -10% performance regression for some network benchmarks. We further do some optimizations:

Remove the ConsumableNotifyingResultPartitionWriterDecorator and migrate the corresponding logic to ResultPartition which reduces the delegated method call to ResultPartition.
Inspired by Stephan's code, the RecordSerializer is removed and at the same time we implement some optimization for the record serialization logic.
We optimize some logics of ResultPartition, for example, the method of coping record to BufferBuilder. (These logics are migrated from RecordWriter)

These optimizations compensate the regression and the followings are the benchmark results:
Before this change:
Benchmark                                                                     (channelsFlushTimeout)   Mode  Cnt      Score      Error   Units
DataSkewStreamNetworkThroughputBenchmarkExecutor.networkSkewedThroughput                         N/A  thrpt   30  20508.293 ±  467.932  ops/ms
StreamNetworkBroadcastThroughputBenchmarkExecutor.networkBroadcastThroughput                     N/A  thrpt   30    707.308 ±    7.070  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                 100,100ms  thrpt   30  48370.571 ± 1300.206  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                             100,100ms,SSL  thrpt   30  11182.832 ±  249.167  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                  1000,1ms  thrpt   30  28303.697 ±  731.245  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                1000,100ms  thrpt   30  32439.635 ± 4025.664  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                            1000,100ms,SSL  thrpt   30   9127.954 ±  178.195  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                        1000,100ms,OpenSSL  thrpt   30  23218.673 ±  529.881  ops/ms

After this change:
Benchmark                                                                     (channelsFlushTimeout)   Mode  Cnt      Score      Error   Units
DataSkewStreamNetworkThroughputBenchmarkExecutor.networkSkewedThroughput                         N/A  thrpt   30  21241.746 ±  445.289  ops/ms
StreamNetworkBroadcastThroughputBenchmarkExecutor.networkBroadcastThroughput                     N/A  thrpt   30    714.766 ±   22.332  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                 100,100ms  thrpt   30  48641.043 ± 1522.510  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                             100,100ms,SSL  thrpt   30  11093.303 ±  166.213  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                  1000,1ms  thrpt   30  28392.504 ± 3361.873  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                                1000,100ms  thrpt   30  32617.439 ±  815.474  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                            1000,100ms,SSL  thrpt   30   9028.759 ±  138.101  ops/ms
StreamNetworkThroughputBenchmarkExecutor.networkThroughput                        1000,100ms,OpenSSL  thrpt   30  24030.099 ±  788.459  ops/ms

Brief change log

Change the interface of ResultPartitionWriter. Interfaces added include writerRecord, broadcastWrite, broadcastEvent, setMetricGroup, setConsumableNotifier, createSubpartitionView and release. Interfaces removed include getBufferBuilder, tryGetBufferBuilder, addBufferConsumer and fail.
Migrate the logic of broadcast optimization to ResultPartition and remove BroadcastRecordWriter and ChannelSelectorRecordWriter.
Remove RecordSerializer which is used to turn records into sequences of memory segments, because we do not need it any more.
As mentioned above, do some refactor and optimization to improve the performance.
Refactor the corresponding test cases.

Verifying this change
TODO
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

test


Make captions bold text below the plots

That's not what is meant by captions. They should not be in the plot but in the text. It should be like:
Morris global sensitivity results. Depicted are the results of a Morris global sensitivity analysis using the morris function of GlobalSensitivity.jl with parameters x y z. The plots are results of the plot recipe depicting the mean and variance of the Morris indices over the parameter space x in a to b etc.
One line is not a figure caption in real work. It should be like 4 sentences minimum.

I think we're good.


Leetcode Solutions Added

Pull Request Template
What have you Changed(must)
Write here what you have changed in the codebase
Issue no.(must) -
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[ ] This issue was assigned to me if not it will be marked as spam.
[ ] My file is in the proper folder
[ ] I am following clean code and Documentation.
[ ] I have added the title and what program will do first in the file
[ ] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

@SHY-Corp Please Review My Pull Request , Thank You

@surikunal you have to create a PR only after you've been assigned to the issue. We'll be closing this now. Please go through the contribution guidelines.


Add pushing to Cask into the Fastfile release lane

See #189 for details.

[ ] add to fastfile
[ ] add Cask to readme as recommended installation

Does anyone want to take over this issue? I tried quickly playing with Cask, but didn't love how devs upload new versions, so I didn't finish it.
Basically we need to add a step to the Fastfile which automatically uploads a new spec to the Cask repo based on the other information in the context. Look at the release lane.

Duplicate of #229


JS Improvements

Some JS improvements
Modularize the app in modules
Now, the whole JS behavior of the app is held between the app.js and the layout.js file. It would be good to model separate models to encapsulate different logic improving their abstraction and their readability.
Moreover, it would be good to consolidate a single way of modeling these behaviors. JavaScript gives you the chance to have single functions, plain old JS objects, classes, etc. Having one way of doing things makes clear on how to collaborate 😉
For example, the layout.js file includes the error handling logic. This behavior could be extracted to a module itself.
Place JS dependencies within <head>
Some JS scripts are loaded at the end of the index.html file, I understand the purpose. You can use async though.
Separate lib files from project files
All the JS files are placed within the js folder, please move them to custom folders such as lib and app folders or so.

Regarding asynchronous loading of the scripts, wouldn't defer make more sense here, since some scripts depend on others (like JQuery) having been already loaded?

The changes proposed by @spalladino here should be included when tackling this issue.


AWS Secrets (ASM)

Description
Would like to see integration for using AWS Secrets Manager within pipeline.  similar to using Hashi Vault, be able to inject from ASM at build time.

https://aws.amazon.com/secrets-manager/

up 👍


Document MaxKeys and workaround?

1 << 30 is 1 073 741 824, a fourth of the range of a uint32. One can't necessarily just make more db files (assuming the hash function is available to direct to the right database) because different operating systems have different file/inode limits and open file descriptor limits.

Hm... file size limits (depending on OS, not storage) also enter the design space of intended use, which I'm hoping future documentation will address.

I set the MaxKeys value to math.MaxUint32 (https://github.com/akrylysov/pogreb/commit/b08c0bfa1afc981852b0c16c2b38d4284d4b1f04). I don't have plans of making the value larger than MaxUint32 right now, it would require storing 64-bit hashes. MaxKeys was already documented https://godoc.org/github.com/akrylysov/pogreb#pkg-constants.


Change references to 'number' rule in the syntax reference to 'digit' rule

In the ohm syntax reference, it uses the number rule a few times. number doesn't appear to be a built-in rule at this time, so I believe it should be changed to the digit rule instead.
This is minor, but it confused me a bit as an ohm newbie trying out everything in the syntax reference.

Good point -- thanks, Nicole! Fixed.


Kendo type input duplicate formControl directive

Description
In the kendo input type, the input component has the formControl directive twice:

https://github.com/ngx-formly/ngx-formly/blob/main/src/ui/kendo/input/src/input.type.ts#L20
This was introduced in #3220 but I could not see any reason why.
Thanks

Could you please send a PR ?

This issue has been fixed and released as part of v6.0.1 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


Feature/request context

@WanWizard until we finish to find out how to share/use (separate) contexts between requests, are you satisfied with this solution?
It is basically the same as before except all the paths are handled correctly and the finder is reseted to its original state instead of alteration.

Can't look at it in detail at the moment, but it sounds very logical, the router should not pull stuff in, it should be injected.

I am going to merge this for now then. However it is just one percent better than the injection factory thing. :stuck_out_tongue:


Create vrep ik plugin

V-REP discussion of integrating custom Inverse Kinematics
v-REP discussion transferring data between plugins

This plugin has been running for some time, though the documentation should be updated accordingly.


Update hello-world.md

Spotted a typo:

	@foreach(var child in Model.Children){

<a href="<EMAIL_ADDRESS>	}

Amended the last closing list tag to closing unordered list.

Thanks!

Will this auto update this page?
https://our.umbraco.org/documentation/Getting-Started/Design/Razor/hello-world


MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.3, and co…

…nda-forge-pinning 2<IP_ADDRESS>.14.32

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Cannot render server-side

In node.js, when I call
require('flowchart.js')

I get the Raphael exception below:
/.../node_modules/raphael/dev/raphael.core.js:96
            doc: document,
             ^

ReferenceError: document is not defined
    at /.../node_modules/raphael/dev/raphael.core.js:96:18
    at /.../node_modules/raphael/dev/raphael.core.js:15:26
    at Object.<anonymous> (/.../node_modules/raphael/dev/raphael.core.js:19:2)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at /.../node_modules/raphael/raphael.amd.js:16:23

Thank you for the good work !

I never did never try to use it on server-side

See this SO answer

OK, so flowchart.js was not meant to be run server side from the beginning. I'll see if it can be ported (Raphael might work server side if I believe their website)
Thank you for the answer !

Can it support renderToString? When I work on server-side, I can use this method to parse the code, and add style it will draw the flowchart.

Try to do a PR...

Does jsdom help?


Testing: Update IsSUSE and call to prepareSLES.

Description
Update IsSUSE and call to prepareSLES. This PR attempts to integrate all uses to IsSUSE, calls to prepareSLES and overall preparation requisites to run tests correctly on a SUSE VM.
Additionally fixes the following error by calling prepareSLES when the ImageSpec is  stackdriver-test-143416:sles-15-sp4-sap-saphana which is a special case  :
Problem retrieving files from 'SLE-Module-Basesystem15-SP4-Pool'.
Credentials are invalid. For details see "/var/log/cloudregister". Re-register the system with "registercloudguest --force-new"
Please see the above error message for a hint.

Related PRs :

https://github.com/GoogleCloudPlatform/ops-agent/pull/1685
https://github.com/GoogleCloudPlatform/ops-agent/pull/1703
https://github.com/GoogleCloudPlatform/ops-agent/pull/1716

Related issue

How has this been tested?

Checklist:

Unit tests

[ ] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[ ] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

It looks like the soak test launcher test has a failure related to your change

It looks like the soak test launcher test has a failure related to your change

Yes, they were from my change. It was because i tried to call getOS before waitForStart, which i realized it won't work since getOS ssh's and run a command. I reverted the order and made sure within waitForStartLinux we use IsSUSEImageSpec, because the vm.OS.ID is not set at that moment.
Most SLES tests are passing (SLES 15 AArch64 seems like a flake) and most importantly third party apps integration test (SAP HANA x86_64) passed, which was the one i wanted to fix.
There is failure in Ops Agent integration test (Rocky Linux 8 x86_64) and third party apps integration test (CentOS 7 x86_64), but i think they are flakes unrelated to this PR.

Most tests on https://github.com/GoogleCloudPlatform/ops-agent/pull/1720/commits/4f19034c50df887836afd0c5e10f663548ad14a7 passed, only Ops Agent integration test (Ubuntu 23.10 Mantic) which didn't fail in previous run, so it's most probably a flake.


Jekyll & persistent deploy script statuses

Added Jekyll
Created persistent status.json (with status utility /api/utilities/status.js) in /opt/data/deployments directory that is update each time status changes.. status.json is read from file on server start
Each of the following scripts's can be executed from the posm-admin console:
posm-deploy-full.sh
omk-atlas.js
render-db.update

TODO:
Kill scripts with "Cancel" button

This looks great! For some reason, however, I'm not getting any console output when I initiate a full deploy. Debugging...

Make sure you cd into /Jekyll and Jekyll build --watch; I always forget

As well as npm install, added a couple libraries

The Jekyll output is not enough?

Another thing; Webstorm was weird about automatically uploading changes to the posm; so I had to right click the /build folder and hit, "upload to posm" after making changes

I checked out the HEAD of the jekyll branch both on my Mac and the POSM. I shouldn't have to rebuild the jekyll project to have things in the right state.
In the debugger, for 'full-deploy.js, it get's to that initial 'Doing a full deployment starting with fetching a HOT Export tar.gz.' response, but we never get to the callback from fullDeployProc`.

Yay, I'm getting this
Error: spawn EACCES
    at exports._errnoException (util.js:870:11)
    at ChildProcess.spawn (internal/child_process.js:298:11)
    at exports.spawn (child_process.js:362:9)
    at init (/opt/admin/posm-admin/api/controllers/full-deploy.js:53:26)
    at Layer.handle [as handle_request] (/opt/admin/posm-admin/node_modules/express/lib/router/layer.js:95:5)
    at next (/opt/admin/posm-admin/node_modules/express/lib/router/route.js:131:13)
    at next (/opt/admin/posm-admin/node_modules/express/lib/router/route.js:125:14)
    at Route.dispatch (/opt/admin/posm-admin/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/opt/admin/posm-admin/node_modules/express/lib/router/layer.js:95:5)
    at /opt/admin/posm-admin/node_modules/express/lib/router/index.js:277:22

Stupid permissions. I'll sort it out and have it fixed in posm-build so you don't have to deal with it next time.

It's there. I think for some reason the files checked in git didn't have executable permission?
https://github.com/AmericanRedCross/posm-build/blob/b4db4c1c438fc2c1d67ed4e31444de6650418339/kickstart/scripts/admin-deploy.sh#L44

https://github.com/AmericanRedCross/posm-admin/commit/fec5f6ef7496b37e0b8fbacd58405c3bcc4c866a


Status bar vanishes when loading a menu item inside a navigation controller

When I create my menu item controllers, I embed them in navigation controllers.
e.g.
let text = TextViewController(textView: TextView.init(frame: UIScreen.main.bounds), pageID: page.pageid)                 let navigationController = UINavigationController(rootViewController: text)                 contentList.append(navigationController)
Issue is when I click one of these items, it loads, but the status bar vanishes and just leaves a black box.
How can i get the behaviour to work as expected and retain the status bar which then takes on the background colour of the navigation bar, as it would do outside of the side menu encapsulation

Hi @jackdem,
What preferred status bar color do you have, when menu items are loaded? It could be a situation, when you have default (darkContent) and dark background.

Hi there, my appearance config looks like this:
    ```

UINavigationBar.appearance().tintColor = UIColor.white
UINavigationBar.appearance().barTintColor = UIColor().appThemeColour()
UINavigationBar.appearance().isTranslucent = false
UINavigationBar.appearance().shadowImage = UIImage()
UINavigationBar.appearance().setBackgroundImage(UIImage(), for: .default)
UINavigationBar.appearance().titleTextAttributes = [NSForegroundColorAttributeName : UIColor.white]
UIApplication.shared.statusBarStyle = .lightContent

Is it reproduced on iOS 11 only or on all versions?

im not sure how to confirm older versions as im only working with 11

In Xcode you can click on Active Scheme and then Download Simulators and choose version before 11 to download.
Also, this Stack Overflow question should help you.

I downloaded iOS 10.0 simulators and it seems to work fine, so its iOS11, is there a fix / solution possible? as currently its not really usable in iOS11 with this behaviour in my use case

I'll take a look into your issue today. To simplify this work, please, try to reproduce the issue on the sample or send me your code.

Also, did you test it on a real device? Or simulator only?

Simulator only, i dont have any iOS10 devices.
I cant provide a sample sorry, but the setup is simply, the sidemenu and then clicking an item loads a navigation controller with a viewcontroller assigned to it. This view controller will suffer the black bar issue. If you drag the view controller to open the menu then very slowly move it backward closing the menu, you can get the black bar to dissapear for that run of the app. So it seems perhaps its to do with the animation of the navigation bar in combination of the side menu that causes it

Hi was there a solution found to this? ive been running my app on iOS10 simulator for a while now but i cant do a public release unless there is a work around, would be much appreciated

Hi @jackdem ,
It looks like CGAffineTransform(scaleX, y) of ViewController's view works not correctly with NavigationBar in iOS 11. I'm going to report a bug to Apple.
You can use contentScale = 1 for iOS 11 users for now until this issue will not be fixed or we'll find some workaround.
Please, let me know if SideMenu works for your case without content scale.

thanks, sorry for the simple question, but where do i set the contentScale?

Using TransitionOptions.contentScale = 1

unfortunately this didnt fix it, the status bar remains the wrong colour in an iOS11 simulator

Please, attach the recording. I can't reproduce your issue with contentScale equal to 1.

sorry i set it in the viewwilltransition, moved it to the viewdidload and now its fine, no issue. i just loose the nice animation. Is this something that should resolve in the longer term?

It will depend on Apple's answer

I have the same issue, I hope Apple answers soon :)

if #available(iOS 11.0, *) {             transitionOptions.contentScale = 1         }
Your workaround is working btw!

The workaround is not proper, if you use the gesture navigation to slowly open and/or slowly close the side menu, the white status bar is displayed and it vanishes when the view takes up the full space.


Release for cohorts support

Unit tests for cohorts (and insights integration)
Minor version bump for release

@dmmiller612 - any objection to removing that test/unit/commands/insights-data/query.json file?  I couldn't find anywhere it was being used.


analytically, filiety (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Split methods in QueryAndFetchConsumer into smaller methods

This commit only moves functions or splits them into multiple functions.
normalSelect is moved outside of the Visitor inner class.

Codecov Report

Merging #5326 into master will decrease coverage by 0.03%.
The diff coverage is 90%.

@@             Coverage Diff              @@
##             master    #5326      +/-   ##
============================================
- Coverage      82.3%   82.26%   -0.04%
- Complexity    10963    10973      +10
============================================
  Files          1329     1329
  Lines         43385    43393       +8
  Branches       5479     5477       -2
============================================
- Hits          35706    35699       -7
- Misses         5127     5139      +12
- Partials       2552     2555       +3

Impacted Files
Coverage Δ
Complexity Δ

.../crate/planner/consumer/QueryAndFetchConsumer.java
90.32% <90%> (-2.28%)
12 <10> (+10)

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
75.67% <0%> (-13.52%)
8% <0%> (-1%)

...or/transport/distributed/DistributingConsumer.java
73.95% <0%> (-9.38%)
20% <0%> (ø)

.../distributed/TransportDistributedResultAction.java
70.31% <0%> (-7.82%)
7% <0%> (-1%)

...o/crate/planner/node/dql/join/NestedLoopPhase.java
74.69% <0%> (-3.62%)
20% <0%> (-2%)

...in/java/io/crate/breaker/RamAccountingContext.java
80% <0%> (-3.34%)
19% <0%> (-2%)

...ration/collect/collectors/LuceneBatchIterator.java
86.95% <0%> (-3.27%)
36% <0%> (-1%)

...c/main/java/io/crate/exceptions/SQLExceptions.java
67.67% <0%> (-3.04%)
33% <0%> (-2%)

.../crate/executor/transport/task/UpsertByIdTask.java
77.39% <0%> (-1.37%)
27% <0%> (ø)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94e101...8cff5b8. Read the comment docs.


Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
Attempting to run brew test-bot on a cask tap.
What happened (include all command output)?
Given a cask with:
  url "https://download.visualstudio.microsoft.com/download/pr/#{version.csv.second}/#{version.csv.third}/dotnet-sdk-#{version.csv.first}-osx-#{arch}.pkg"
  homepage "https://microsoft.com/net/core#macos"

When brew test-bot --only-tap-syntax on ubuntu-latest
Then
Run brew test-bot --only-tap-syntax
  brew test-bot --only-tap-syntax
  shell: /usr/bin/bash -e {0}
==>Using Homebrew/homebrew-test-bot dbfd4e1 (Merge pull request #806 from Homebrew/no_bottle_disabled)
==>Using Homebrew/brew 3.5.2 (Merge pull request #13413 from MikeMcQuaid/update_report_new)
==>Using Homebrew/homebrew-core a98cbb1c7c4 (nmap: update 7.92 bottle.)
==>Testing jasonkarns/homebrew-homebrew 5c814f4 (Merge 217b566370c7ba8db30ec463b5ca4b375d3def1e into 3567b74dd80fa33b4e21d3e72cfc5c22638e48b0):
==>Running TapSyntax#run!
==>brew readall --aliases jasonkarns/homebrew
==>brew style jasonkarns/homebrew
==>brew audit --tap=jasonkarns/homebrew --except=version
==>FAILED
Full audit --tap=jasonkarns/homebrew --except=version output
  audit for dotnet-sdk: failed
  - The URL's domain download.visualstudio.microsoft.com does not match the homepage domain microsoft.com, a 'verified' parameter has to be added to the 'url' stanza. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified
  Error: The URL's domain download.visualstudio.microsoft.com does not match the homepage domain microsoft.com, a 'verified' parameter has to be added to the 'url' stanza. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified
  Error: 1 problem in 1 cask detected
Error: 1 failed step!
brew audit --tap=jasonkarns/homebrew --except=version
Error: Process completed with exit code 1.

Action run: https://github.com/jasonkarns/homebrew-homebrew/runs/6864273309?check_suite_focus=true
Conversely, when verified is added as per required by the linter on ubuntu, then I get a lint error on macOS that says the verification is unnecessary.
Given a cask with:
  url "https://download.visualstudio.microsoft.com/download/pr/#{version.csv.second}/#{version.csv.third}/dotnet-sdk-#{version.csv.first}-osx-#{arch}.pkg",
      verified: "download.visualstudio.microsoft.com"
  homepage "https://microsoft.com/net/core#macos"

When brew test-bot --only-tap-syntax on macos-latest
Then
Run brew test-bot --only-tap-syntax
  brew test-bot --only-tap-syntax
  shell: /bin/bash -e {0}

==>Using Homebrew/homebrew-test-bot dbfd4e1 (Merge pull request #806 from Homebrew/no_bottle_disabled)
==>Using Homebrew/brew 3.5.2 (Merge pull request #13413 from MikeMcQuaid/update_report_new)
==>Using Homebrew/homebrew-core a98cbb1c7c4 (nmap: update 7.92 bottle.)
==>Testing jasonkarns/homebrew-homebrew 4454074 (Merge eac2aeb733c27e3cb21509420888d41830c60bb9 into 3567b74dd80fa33b4e21d3e72cfc5c22638e48b0):
==>Running TapSyntax#run!
==>brew readall --aliases jasonkarns/homebrew
==>brew style jasonkarns/homebrew
==>brew audit --tap=jasonkarns/homebrew --except=version
==>FAILED
Full audit --tap=jasonkarns/homebrew --except=version output
  audit for dotnet-sdk: failed
  - The URL's domain download.visualstudio.microsoft.com matches the homepage domain microsoft.com, the 'verified' parameter of the 'url' stanza is unnecessary. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified
  Error: 1 problem in 1 cask detected
  Error: The URL's domain download.visualstudio.microsoft.com matches the homepage domain microsoft.com, the 'verified' parameter of the 'url' stanza is unnecessary. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified

Error: 1 failed step!
brew audit --tap=jasonkarns/homebrew --except=version
Error: Process completed with exit code 1.

Action run: https://github.com/jasonkarns/homebrew-homebrew/actions/runs/2489444965
ie, with the :verified option present, the linter passes on ubuntu but fails on macos. When the option is omitted, it fails on ubuntu (github actions cancels the macos run as soon as the ubuntu run fails, so it's unclear if the macos job would pass. however, brew audit ./Casks/dotnet-sdk.rb --except=version does pass locally on macos without the verified option present)
What did you expect to happen?
I'd expect the linter to produce consistent results given the same cask code across both ubuntu and macos.
Step-by-step reproduction instructions (by running brew commands)
brew audit ./Casks/dotnet-sdk.rb --except=version across both ubuntu and macos. Pointing to the cask at: https://github.com/jasonkarns/homebrew-homebrew/blob/eac2aeb733c27e3cb21509420888d41830c60bb9/Casks/dotnet-sdk.rb

CC @homebrew/cask folks for thoughts/help.

CC @Homebrew/cask again and also @bevanjkay @apainintheneck @samford as I have no idea how this should work. Replying with "I also have no idea" would be helpful, thanks ❤

I have no idea either, although I do know that brew audit <filename> is not the same as brew audit <token>. So that might explain some issues.

I'd expect the linter to produce consistent results given the same cask code across both ubuntu and macos.

I agree with this. Unfortunately, I also don't understand why it isn't giving the same results currently. Sorry 😢

I have no idea either, although I do know that brew audit <filename> is not the same as brew audit <token>. So that might explain some issues.

Ah, yes.

brew audit ./Casks/dotnet-sdk.rb --except=version

is incorrect usage of of brew audit and will produce garbage. I wish we handled that garbage production better, though (e.g. documenting that brew doesn't take file name arguments, and behaving less misleadingly when file names are passed).

Taking a look at Tap, I think Cask was https://github.com/jasonkarns/homebrew-homebrew/blob/cb497ca65807e5310652da7f736711e9e99bfe80/Casks/dotnet-sdk.rb, which seems to have mix of version syntax from older copy of core Cask with url from newer copy.
version.csv.second would include a colon character followed by number when MacOS.version <= :sierra (inclusive of Linux). This gets incorrectly parsed as port number resulting in domain of microsoft.com:1076952734:
https://github.com/Homebrew/brew/blob/b4619fe2dbe26cc14294049574358e92a5bb6dc8/Library/Homebrew/cask/audit.rb#L384
Since macOS runners would be running newer OS than Sierra, they use other version, which has character hex and isn't seen as a port number.

brew audit ./Casks/dotnet-sdk.rb --except=version

is incorrect usage of of brew audit and will produce garbage. I wish we handled that garbage production better, though (e.g. documenting that brew doesn't take file name arguments, and behaving less misleadingly when file names are passed).

@carlocab Should we just fail brew audit if you pass a filename? Does this work ok when passed a folder name? Does this work ok for formulae?

Not sure if we need to change anything as the particular Cask seems to have been broken in current state and : is a reserved character in URL encoding. If really wanted, then can add a more specific URL regex.

@cho-m Thanks for digging in. Will consider this as WONTFIX but keep it open for now to discuss the brew audit $FILENAME stuff above.


[FEATURE] add bind descriptions

Description
Request
add an optional description parameter to binds
bind=MODS,key,dispatcher,params,description

so it would show in hyprctl binds -j
{
  "locked": false,
  "mouse": false,
  "release": false,
  "repeat": false,
  "non_consuming": false,
  "modmask": 0,
  "submap": "toggle",
  "key": "g",
  "keycode": 0,
  "catch_all": false,
  "dispatcher": "exec",
  "arg": "/home/artem/.config/hypr/scripts/toggle-gaps.sh 20",
  "description": "toggle gaps"
}

Use Case
I am currently writing a script that would print my binds for a given submap (probably will write one for all binds as well later) and my current logic is to parse my hyprland.conf which is structured like so:
bind = SUPER , t , submap , toggle

submap = toggle
bind =       , s , exec   , $myHyprConfig/toggle-status-bar.sh                        # toggle status bar
bind =       , b , exec   , $myHyprConfig/toggle-borders.sh $borders                  # toggle window borders
bind =       , c , exec   , $myHyprConfig/toggle-corners.sh $corners                  # toggle corners
bind =       , g , exec   , $myHyprConfig/toggle-gaps.sh $gaps_inner                  # toggle gaps
bind =       , z , exec   , $myHyprConfig/toggle-zen.sh $borders $corners $gaps_inner # toggle zen mode
bind =       , h , exec   , $myScript/toggle-headphones.sh                            # toggle bluetooth headphones

# reset submap
bind = , escape , submap , reset
bind = , s      , submap , reset
bind = , b      , submap , reset
bind = , c      , submap , reset
bind = , g      , submap , reset
bind = , z      , submap , reset
bind = , h      , submap , reset

submap = reset

All I am really doing is printing all lines between submap\s*=\s*$submap and # reset submap, and awking it to print the second parameter and the comment line resulting in this:
 s - toggle status bar
 b - toggle window borders
 c - toggle corners
 g - toggle gaps
 z - toggle zen mode
 h - toggle bluetooth headphones

This is fine but I feels like a waste to not utilize hyprctl binds functionality, but that doesn't have descriptions so I can't use that as it is.
Implementation
Ideally, I see this added as a last optional parameter so it doesn't break anyone's config (default to an empty string or null when not specified). But I don't know if there are any dispatchers that accept multiple parameters making this impossible. If that is the case maybe it can be this instead
bind=MODS,key,description,dispatcher,params

not possible, impossible to detect description with exec scripts.

Sorry for annoyance, but why exactly is not possible to detect it, if they just separated by comma in this case? Like detect next comma is hard or something?

@vaxerski are you talking specifically this suggestion
bind=MODS,key,dispatcher,params,description
or does that apply to putting description param before dispatcher as well?
bind=MODS,key,description,dispatcher,params
if either is impossible then can we come up with some other mechanism to achieve this? Maybe something like this is possible to assign description to existing bind:
bind = , h , exec , $myScript/toggle-headphones.sh
bind_desc = , h , "toggle headphones"

both suck, one is a breaking change and has limitations, the other isnt possible.
bind_desc is an option, but I still find this kinda stupid.

Yeah, I sort of agree. I saw no drawback to description at the end, but the others do suck a bit.

Glad I found this issue because I was going to suggest something like this. I still think it would be beneficial do have a way to lookup things which are bound and see which key combos they have been assigned to. Maybe something rofi and other dmenu like tools could digest and make available. If starting a config from scratch, of course muscle memory will develop as you go. If taking pieces and parts from the internets that is a different story...

looks like this has been added after all 😄
https://wiki.hyprland.org/Configuring/Binds/#description


Synchronously update status label

Once unshelved, the label (active) did not get updated at the same time when the command history showed that it the command is successfully executed (and indeed the instance was available). It was about 5 minutes.
Originally posted by @muratmaga  in https://github.com/MorphoCloud/MorphoCloudWorkflow/issues/27#issue-2487721000

Fixed in https://github.com/MorphoCloud/MorphoCloudWorkflow/compare/ccfcc35876b16c52e8636418a0f8ae5aa33365c7...15bc17c705c356c8cec089e646bbf75d1d5bdcf0


unexpected output for json

when using this
curl -X POST https://reqbin.com/echo/post/json \
   -H 'Content-Type: application/json' \
   -d '{"login":"my_login","password":"my_password"}'

--language json gives:
{
    "url": "https://reqbin.com/echo/post/json",
    "raw_url": "https://reqbin.com/echo/post/json",
    "method": "post",
    "headers": {
        "Content-Type": "application/json"
    },
    "data": {
        "{\"login\":\"my_login\",\"password\":\"my_password\"}": ""
    }
}

but this looks wrong to me (data with key/value)?
in comparison, python gives:
import requests

headers = {
    # Already added when you pass json=
    # 'Content-Type': 'application/json',
}

json_data = {
    'login': 'my_login',
    'password': 'my_password',
}

response = requests.post('https://reqbin.com/echo/post/json', headers=headers, json=json_data)

I hope
{
    "url": "https://reqbin.com/echo/post/json",
    "raw_url": "https://reqbin.com/echo/post/json",
    "method": "post",
    "headers": {
        "Content-Type": "application/json"
    },
    "data": {
        "login": "my_login",
        "password": "my_password"
    }
}

is what you were expecting in that case. We could also put the parsed JSON object as a separate property and leave data: in the either querystring or multipart/form-data format
{
    "url": "https://reqbin.com/echo/post/json",
    "raw_url": "https://reqbin.com/echo/post/json",
    "method": "post",
    "headers": {
        "Content-Type": "application/json"
    },
    "data": {
        "{\"login\":\"my_login\",\"password\":\"my_password\"}": ""
    },
    "data_json": {
        "login": "my_login",
        "password": "my_password"
    }
}


[BEAM-13184] Autosharding for JdbcIO.write* transforms

This enables a path that relies on Auto-sharded GroupIntoBatches - this will help the JdbcIO transform scale with the size of a cluster in streaming, and hel with efficiency.
r: @aromanenko-dev
r: @chamikaramj

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Java PostCommit

Run Java PostCommit

Run Java PostCommit

Run Java PreCommit

PTAL friends : )

@pabloem Sorry for delay, I was busy with some other things. I'll try to take a look in the next few days.

adding a test makes sense. I'll work on that

Run Java PostCommit

Run Java PostCommit

Run Java PreCommit

hi @aromanenko-dev : ) - I'd love to get this in for the release cut on wednesday (though don't feel pressured to allow bad quality code. if fixes are needed, I'll happily make them)

Hey @pabloem, kind ping on this PR

Run Java PreCommit

Run Java PostCommit

Run Java PreCommit

Run Java PostCommit

Run Java PostCommit

@chamikaramj @aromanenko-dev PTAL

Run Java PostCommit

Run Java PostCommit

anyone got some time? : )

Thanks, it's ok for me but maybe @chamikaramj has some additional comments?

LGTM. Thanks.

random musings from me, because we've tried to do something like this as well w/ our own SQL-ish IO.
If you introduce an (implicit) reshuffle between the producer of the rows being written and the writer, you'll possibly break an implicit contract that users have been relying on that mutations produced are applied in-order to the JDBC destination.
For example, if a GBK is triggering every 10 seconds and the next transform is a JdbcIO, by default that GBK trigger will fuse w/ the JdbcIO writer and apply "inline", so all triggers will apply in order.  If you apply batching (with autosharding or not), multiple mutations for the same row may be grouped into multiple different batches, which will then be applied in a non-deterministic order.


In OSX you actually can install scheme from homebrew

Describe the bug
In https://github.com/uwu-tech/Kind/blob/master/INSTALL.md#macos
when saying that for MacOS you must compile scheme from source.
I think this is no longer true: I installed from homebrew without problems (besides that)
Environment (please complete the following information):

OS: MacOS BigSur 11.5
Kind version: kind-scm 1.0.85

This will work in some cases, however the brew package is based on the official version and it doesn't support Apple silicon yet. I'm reworking the build system to sidestep those issues and distribute Kind as a single binary executable with no dependencies.

The new build system is live ^^
Could you try it to see if it works?

however the brew package is based on the official version and it doesn't support Apple silicon yet.

Weird, because I installed it in my M1 Apple mini.

Could you try it to see if it works?

Would like to, but I’m on vacation and far from my computer for 1 week.

No problem

Followed your instructions to install from source. Failed at make in step 4 with
> make

cd ChezScheme && git submodule init && git submodule update
S'ha registrat el submòdul «bin/scm/ChezScheme» (git@github.com:racket/ChezScheme.git) per al camí «./»
S'ha registrat el submòdul «bin/scm/chez-exe» (git@github.com:rigille/chez-exe.git) per al camí «../chez-exe»
S'està clonant a «/Users/saludes/Desktop/kind-lang/Kind/bin/scm/ChezScheme»...
S'està clonant a «/Users/saludes/Desktop/kind-lang/Kind/bin/scm/chez-exe»...
Camí de submòdul «./»: s'ha agafat «bf49dfbd8c47c759bc2ac99978a0db02b2969578»
Camí de submòdul «../chez-exe»: s'ha agafat «937629ad6cdcec698f0b25d996bb9b01a3b7cce7»
cd ChezScheme && ./configure --pb --kernelobj --disable-curses --disable-iconv --disable-x11
Source in "nanopass" is missing; check out Git submodules using
   git submodule init
   git submodule update
make: *** [scheme/bin/scheme] Error 1

I did (this time in Kind) :
git submodule init
git submodule update

and worked.

Closed because the repository now only contains the code for the Kind2 language.


Tag pages do not load up

When I visit the tag pages, they do not open up.
It just says "An unexpected error has occurred."

Hosted version: https://next-cms-ghost-j2jwkzzdp.vercel.app/tag/developer-essentials
Original source: https://www.crio.do/blog/tag/developer-essentials/

You need to find the exact error message in the Vercel console and post it here for further assistance. My best guess is that you switched image optimizations on again (which is the recommended setting for Vercel deploys) but forgot to add the domains for image serving in next.config.js. For your site, I had to add at least the following:
      'www.crio.do',
      'drive.google.com',
      'lh3.googleusercontent.com',
      'lh6.googleusercontent.com',

But it could be something different. Just note that I am able to the tag page on localdomain:

You need to find the exact error message in the Vercel console and post it here for further assistance. My best guess is that you switched image optimizations on again (which is the recommended setting for Vercel deploys) but forgot to add the domains for image serving in next.config.js. For your site, I had to add at least the following:
      'www.crio.do',
      'drive.google.com',
      'lh3.googleusercontent.com',
      'lh6.googleusercontent.com',

But it could be something different. Just note that I am able to the tag page on localdomain:

As I cannot reproduce the issue (it works fine on my end) I am going to close it. If you want to reopen, please attach detailed error logs and some instructions on what you did to get there.

As I cannot reproduce the issue (it works fine on my end) I am going to close it. If you want to reopen, please attach detailed error logs and some instructions on what you did to get there.


[20.09] chromium: 88.0.4324.150 -> 88.0.4324.182

Motivation for this change
Backport of #113368.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

nix-build -A nixosTests.chromium succeeded.


Fix gitlab markdown/html

Closes #334

Codecov Report

Merging #337 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   77.52%   77.58%   +0.05%
==========================================
  Files          24       24
  Lines        1522     1526       +4
  Branches      259      259
==========================================
+ Hits         1180     1184       +4
  Misses        342      342

Impacted Files
Coverage Δ

lib/workers/pr.js
99.02% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acceee4...4da0b89. Read the comment docs.


Pull up

Please merge this pull request to follow upstream.

Please close pull request #1 and accept this pull request.

Nevermind

I took a look at hackforla changes and I would have to add them

Upstream made many changes which will delete hackforla tags.

Upstream seemed to delete all hackforla title from all files.


Can I access the actual database name from a listener/observer?

I am trying not to hard-code the name of the nsf into my listeners like this
var CURRENT_DB = session.getDatabase("","chat.nsf");
I tried using session.getCurrentDatabase(); but that returns null.
The problem is that if someone changes the name of the nsf, then the application breaks. It would be nice to use a dynamic name, instead of a hard-coded one. Is that possible right now?

Try:
var CURRENT_DB = session.getDatabase("", script.dbPath());

Thanks, Mark.
Beautiful. Now I can generalize my app easily.


Investigate potential JSON schema viewers

Based on the work in #1411, a sample JSON is now available that contains the fields generated by the ETL pipelines for each dataset.
Command:
gsutil -m cat gs://ot-snapshots/etl/outputs/21.03.1/metadata/\*\*/part\* | jq '.' | less > data_download.json
Output file:
sample-data-download-response.json.zip
The JSON also contains the schema for each dataset in the serialisedSchema field.
Can we please investigate potential JSON schema viewers, for example material-ui-json-schema-viewer and json-schema-viewer? Is it feasible to display the dataset schema based on the serialisedSchema string?
If we can display the schema, would the package support?

By default, fields are collapsed due to the large size of some dataset schemas (e.g. evidence)
Allow users to download the schema

The feedback on whether this is feasible will inform the ongoing discussions around the data download page specification.

After investigating react-json-view we are able to collapse deeply nested fields or large datasets. We are also able to download the schema.

Ticket closed as initial implementation of data downloads page will not contain schema


made borderresize take a parameter

Until now it is not possible to change how many pixels near a border is considered "near enough", so that the window can be resized by dragging this border. This is especially frustrating on a touchscreen, where I would wish to have more than just 2 pixels to tap on for resizing windows.
This shoudl allow exactly that. Until now, you were stuck with 2 pixel wide borders for resizing. But now this value is not a global variable but instead a parameter for the borderResize layout modifier

Thanks!


Add 'ad-m/github-push-action'

@ad-m  your changes have been merged, thanks for your contribution 👍


fix reporting on scalar markets including invalid outcome

fixes https://github.com/augurproject/augur/issues/3549
old util helper was using v1 logic instead of v2 logic to convert from outcome to payout numerators

I find isInvalid confusing because validity is a pretty broad concept. I prefer invalidOutcome.

IsInvalid is a  V1 common term.


composer require solution-forest/filament-access-management DON'T install same files (like FilamentUserHelpers)

Hi,
After run composer require solution-forest/filament-access-management some files do not find on vendor folder.
On Src\Concerns, only "FilamentUser.php", but dont have "FilamentUserHelpers.php"
How to fix?

same issue for me as well.
Trait "SolutionForest\FilamentAccessManagement\Concerns\FilamentUserHelpers" not found

sorry the package was not released. please update the latest library.


React navigation version issues

Navigating from a button in Tabs to new page  is working perfectly in  v1.0.0 beta.11  and its  not  working in v1.0.0 beta.13

Closing because you haven't respected the issue template.
Moreover, beta.13 is not latest.


Speed up index generation slightly by forcing inlining of XXH64

See https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
This speeds up index generation by ~3%.

super! approved


MRG: Deprecrate pick channels in info

Follow up on the discussion in #10035

To give some context, I wanted to see if equalize_channels had to operate on Info as well. It breaks a lot of stuff if it doesn't; so I ended up adding the selection of channels for Info directly in equalize_channels instead of using Info.pick_channels.

Doc build failure doesn't seem to be related to this PR.

Thanks for the tips, let's see if CIs are green; I wasn't quite sure on how the deprecated decorator works (especially as it doesn't throw any warning at me in the IPython console).

Thanks @mscheltienne !


DOC: Added sphinx template

created a requirements file
created a sphinx template
using shibuya theme

Thanks for the PR @dsrishyla !
Can we add one more file. We want to have the documentation built automatically when someone opens a PR. can you please create a file .readthedocs.yaml in the project root directory, and add the following?
# .readthedocs.yaml
# Read the Docs configuration file
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details

# Required
version: 2

# Set the OS, Python version and other tools you might need
build:
  os: ubuntu-22.04
  tools:
    python: "3.11"

# Build documentation in the "docs/" directory with Sphinx
sphinx:
   configuration: docs/source/conf.py

# Optional but recommended, declare the Python requirements required
# to build your documentation
# See https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html
# python:
#    install:
#    - requirements: requirements.txt


updated versions for rxjs and zone.js to match peer dependencies

@manfredsteyer — Thank you Manfred, much appreciated! 👍


Implemented FT cases 115, 116

Implemented FT cases 115, 116

Tracked with branch NMS.FT.KILKARICONTROLLERIT.
So closing this request.


Add touch event listener

Hi,
I would like to add MotionEvent listener to PatternLockView in order to display X and Y touch screen position to user. How can I achieve that?

I have used dispatchTouchEvent in my main view and everything is working like a charm


Handle parsing into ambiguous types in a union

As reported in https://zigforum.org/t/zig-nestedtext-release-0-1-0/383/17:
test "typed parse: jeang3nie" {
    const Kind = union(enum) {
        color: []const u8,
        plain,
    };
    var p = Parser.init(testing.allocator, .{});
    const r = try p.parseTyped(Kind, "> null");
    defer p.parseTypedFree(r);
    std.debug.print("{s}\n", .{r});
}

This parses into color with the string null since this is the first field that succeeds, but parsing as a string should probably be the last resort (since this will always succeed).

What about the more general problem of preferring the type that's 'hardest' to parse into? E.g. prefer a u8 field over a u16 field if the integer fits into u8, regardless of field ordering? Or should the user be required to place the u8 field before u16 in this case?

Neither of the above mentioned solutions are going to cover all uses of tagged unions unfortunately. Any time two or more tags have the same payload or one which can be ambiguous to the parser, as in your above example of a u8 and a u16, there is a very real chance that the parser will not be able to preserve the original data.
There is a similar issue in Rust using an enum with an associated data type, which is solved in serde by using a cfg attribute:
#[derive(Clone, Deserialize, Debug, Serialize)]
#[serde(tag = "ColorType")]
pub enum Color {
    Hex(HexColor),
    Reduced(ReducedRGBA),
    Rgba(RGBA),
}

And this serializes to the following toml
ColorType = "Reduced"
red = 36
green = 31
blue = 49
alpha = 255

The two languages are very different but I bring it up because having an enum which stores a value is an almost identical concept to a tagged union. In both cases we're encoding a variant along with it's data using the type system.
That tag name itself can be vital to the program logic. I'm currently implementing gradient backgrounds in Zterm, and my gradient can be linear, radial or elliptical. Circular or elliptical variants take a starting position, while a linear variant can have an angular direction or an ending position. Currently this is all encoded into the Kind tagged union, but zig-nestedtext is unable to preserve which variant is being used except in the case of a linear gradient with an angular direction, as the other two variants do not have this possibility. Or it might accidentally get it correct because it was linear and that happens to be the first possibility.
const Gradient = struct {
    kind: Kind,
    // other fields omitted
};

const Kind = union(enum) {
    linear: Direction,
    circular: Position,
    elliptical: Position,
};

const Direction = union(enum) {
    position: Position,
    angle: f64,
};
// Position is a struct with x,y coordinates

I could work around it by storing the variant separately as an enum in my Gradient struct, but this then becomes duplicate information and the entire point (in my use case at least) is to keep the configuration struct as small as possible. It's not a large overhead, but it illustrates a weakness in the current implementation. I think a better solution would be storing the tag in the nestedtext.

Pasting the corresponding zigforum message here too, since zigforum currently seems to be down (and I have the message in my emails).

So I don’t know if you remember talking about this before, but there was a bug with this when using tagged unions if there were two items that had no payload. In that case it would just pick the first one when parsing back into a struct. I have another related problem and I think both could be fixed with the same change. Let me give some background.
pub const Kind = union(enum) {
    linear: Direction,
    radial: Placement,
    elliptical: Placement,
};

pub const VerticalPlacement = enum {
    top,
    center,
    bottom,
};

pub const HorizontalPlacement = enum {
    left,
    center,
    right,
};

pub const Placement = struct {
    vertical: VerticalPlacement,
    horizontal: HorizontalPlacement,
};

pub const Direction = union(enum) {
    angle: f64,
    edge: Placement,
};

pub const Gradient = struct {
    kind: Kind,
    /// more fields omitted
}

When I have a Gradient struct that is a linear gradient with a direction going to the top left, here’s what is saved.
background:
  kind:
    vertical: top
    horizontal: left

Basically, we’re saving the union payload but not the tag. You know the NestedText spec better than me, and also the codebase, so would it be appropriate to embed the tag, too, so that we get something more like this?
background:
  kind:
    linear:
      edge:
        vertical: top
        horizontal: left

Right now by only saving the payload there’s no way to parse that back into the original struct. This is really a different example of the same problem, there are now three union variants that can all potentially have the same data (a position) and there’s no way to tell them apart, just like if there were two branches with no payload. Saving the tag would fix that condition as well is my thinking.
I could completely rethink my struct layout of course, but I would love for this library to be able to handle anything that gets thrown it’s way. And as always I’m willing to help.

@nfisher1226 thanks for the thoughts here and clear description of the problem. I'm increasingly convinced that this issue should be addressed in one way or other, and if we can agree on a way to do so I'd be happy to accept a PR, or may be able to find time to implement it myself.

Neither of the above mentioned solutions are going to cover all uses of tagged unions unfortunately. Any time two or more tags have the same payload or one which can be ambiguous to the parser, as in your above example of a u8 and a u16, there is a very real chance that the parser will not be able to preserve the original data.

Yeah, I'm not convinced my initial proposal is the best way forwards. Perhaps it's an approach that should be taken in addition to a full solution, but that can be assessed separately (I'll split into a separate issue if necessary, let's keep using this issue for this discussion now - I've changed the title).

There is a similar issue in Rust using an enum with an associated data type, which is solved in serde by using a cfg attribute:
#[derive(Clone, Deserialize, Debug, Serialize)]
#[serde(tag = "ColorType")]
pub enum Color {
    Hex(HexColor),
    Reduced(ReducedRGBA),
    Rgba(RGBA),
}

And this serializes to the following toml
ColorType = "Reduced"
red = 36
green = 31
blue = 49
alpha = 255

This is great to know about and worth taking into consideration. What I'm confused about is how this generalises - it looks like the ReducedRGBA must be a mapping object (struct?), and the 'tag' then gets embedded inside that mapping, but then what happens if the payload of an enum field is not a struct?

Basically, we’re saving the union payload but not the tag. You know the NestedText spec better than me, and also the codebase, so would it be appropriate to embed the tag, too, so that we get something more like this?
background:
  kind:
    linear:
      edge:
        vertical: top
        horizontal: left

I did find it a bit weird when implementing parsing into unions that the tag names are ignored and not dumped out (which is behaviour I took from Zig's std.json). I don't think the NestedText spec comes into this at all, this behaviour of parsing into/dumping out types is intentionally the responsibility of the library as NestedText consists only of containers and strings, so we're free to design our own solution here.
I think it should be fine to provide an option to the parse and dump functions to include union tags (i.e. just treat them the same as structs but with only one field expected to be present), which should give you the deeply nested output you suggested above. The only thing is that this would apply to all unions in the parse/dump.
An alternative option would be to check for an attribute on structs/unions to check whether direct union members should have their tags included, which would allow for controlling it per usage of union fields (not per union type - either would be possible but I think the former makes more sense).
For example, using your previous example, if you put const nestedtext_tag_child_union = true; on the Gradient struct then you would include one of the 'linear', 'radial' or 'elliptical' tags in the output. You would also have the option of placing this attribute on the Kind union to include the 'angle' or 'edge' tag in the 'linear' case, but you might not want that since that union is unambiguous anyway.
Thoughts? One or both of these options seem reasonable to me, but it's possible I'm overlooking something.

Yeah, I'm not convinced my initial proposal is the best way forwards. Perhaps it's an approach that should be taken in addition to a full solution
Probably wise. As the code sees more usage other edge/corner cases may show themselves, so the extra approach might help. Not to mention, there are also untagged unions to account for.
it looks like the ReducedRGBA must be a mapping object (struct?), and the 'tag' then gets embedded inside that mapping
Exactly.
but then what happens if the payload of an enum field is not a struct?
Shouldn't matter actually. It's using the enum field name, not the name of the data type.
An alternative option would be to check for an attribute on structs/unions
I do kind of like this approach as it gives some fine grained control. However there is complexity to consider. The payoff must be weighed against the gain, and liking it doesn't necessarily make it worth it.

An argument can be made, however, that since NestedText is meant to be human readable it might be a good idea to have the tools to provide clarity where it is needed, without nesting things overly deep where that clarity isn't necessary.
I know that's not expressing a clear preference, I'm just thinking as I type right now.

@nfisher1226 Please try out the include-union-tags branch, where you can place a nestedtext_include_tag attribute on unions to have the tag included in a single-field key-value object (parsing and dumping behaviour should match up).
See the tests in src/nestedtext.zig for how to use this:

test "typed parse: union, include tag" {
    var p = Parser.init(testing.allocator, .{});

    const MyUnion = union(enum) {
        foo: usize,
        bar: bool,
        baz,

        const nestedtext_include_tag = true;
    };

    try testing.expectEqual(MyUnion{ .foo = 1 }, try p.parseTyped(MyUnion, "foo: 1"));
    try testing.expectEqual(MyUnion{ .bar = false }, try p.parseTyped(MyUnion, "bar: false"));
    try testing.expectEqual(MyUnion{ .baz = {} }, try p.parseTyped(MyUnion, "baz: null"));
}

test "from type: union" {
    const MyUnion = union(enum) {
        foo: usize,
        bar: bool,
        baz,
    };

    {
        const tree = try fromArbitraryType(testing.allocator, MyUnion{ .foo = 123 });
        defer tree.deinit();
        try testStringify("> 123", tree);
    }
    {
        const tree = try fromArbitraryType(testing.allocator, MyUnion{ .bar = true });
        defer tree.deinit();
        try testStringify("> true", tree);
    }
    {
        const tree = try fromArbitraryType(testing.allocator, MyUnion{ .baz = {} });
        defer tree.deinit();
        try testStringify("> null", tree);
    }
}

Any feedback welcome. I can create a release if this seems like a good solution.

I tried a simple test program but it doesn't seem to be working for me. Not sure if I'm missing something here.
const std = @import("std");
const nt = @import("nestedtext");
const allocator = std.heap.page_allocator;
const stdout = std.io.getStdOut().writer();

const Foo = union(enum) {
    bar: u8,
    baz: bool,
    buzz,

    const nestedtext_include_tag = true;
};

pub fn main() anyerror!void {
    var foo = Foo{ .bar = 42 };
    std.debug.print("{s}\n", .{foo});
    {
        const tree = try nt.fromArbitraryType(allocator, foo);
        defer tree.deinit();
        try tree.stringify(.{}, stdout);
    }
    std.debug.print("\n\n", .{});
    foo = Foo{ .baz = true };
    std.debug.print("{s}\n", .{foo});
    {
        const tree = try nt.fromArbitraryType(allocator, foo);
        defer tree.deinit();
        try tree.stringify(.{}, stdout);
    }
    std.debug.print("\n\n", .{});
}

Program output:
Foo{ .bar = 42 }
> 42

Foo{ .baz = true }
> true

What's odd is that the tests are passing, so it apparently is working in the test block but not in my code.

Ah, figured it out. Needs to be pub to be seen outside that file, which means it's only visible to zig-nestedtext if it's pub. Should have thought of that right away.
pub const nestedtext_include_tag = true;

Tried it as above and it worked, tried it with the buzz field mapping to a struct and it worked nicely in that instance as well. Let me look some more things over and test a few more cases, but this looks good right now. That little gotcha about making the nestedtext_include_tag declaration pub should be documented so that it doesn't trip up others, but that's the only issue I currently see.

Yeah, I thought it would be the missing pub. I don't currently have any documentation other than docstrings and tests... But yes, when documentation appears it would be good to include this, even though it could be considered a Zig gotcha more than a gotcha in the nestedtext library.
I'm thinking I might also add the ability to specify whether union tags should be included globally (e.g. when calling fromArbitraryType()), where the per-union field would override it either way.

@nfisher1226 Would you like to try out the include-union-tags-global branch? This adds an options arg to fromArbitraryType() and Parser.parseTyped() (and Parser.parseTypedFree()).
My main question is whether this backwards incompatible API change of having to specify the options arg (as .{} to use the status quo default) is worth it or whether it's just annoying (especially considering Parser.init() already takes a set of options for handling the actual parsing from text).
It works as follows:
test "from type: union, with and without tags" {
    const PlainUnion = union(enum) {
        foo: usize,
        bar: bool,
        baz,
    };

    const AttrUnion = union(enum) {
        x: PlainUnion,
        y: PlainUnion,

        const nestedtext_include_tag = true;
    };

    {
        const tree = try fromArbitraryType(
            testing.allocator,
            AttrUnion{ .x = .{ .foo = 123 } },
            .{},
        );
        defer tree.deinit();
        try testStringify("x: 123", tree);
    }
    {
        const tree = try fromArbitraryType(
            testing.allocator,
            AttrUnion{ .x = .{ .foo = 123 } },
            .{ .include_union_tags = true },
        );
        defer tree.deinit();
        try testStringify("x:\n  foo: 123", tree);
    }
}

I'll give it a try later tonight.

Ok, just tried it out. I see what it does now. My question would be what is the use case for this that isn't already solved by the nested_text_include_tag declaration placed on the union? It's finer grained in that it can be controlled per call to the interested functions, but I don't know that there's a situation where you would want to parse it either way or not. Except, perhaps, foreign types? Where you're dealing with a type from a library and thus can't place the declaration yourself?

My question would be what is the use case for this that isn't already solved by the nested_text_include_tag declaration placed on the union? It's finer grained in that it can be controlled per call to the interested functions, but I don't know that there's a situation where you would want to parse it either way or not. Except, perhaps, foreign types? Where you're dealing with a type from a library and thus can't place the declaration yourself?

It's interesting that you consider this "finer grained" (since you can control the behaviour per call) - I was thinking of this as less fine-grained since it affects all unions, hence having the per-union field override this 'global' option (of course, both are valid perspectives).
You make a good point about external types, I hadn't thought about that (although I'm unclear how often you'd want to [de]serialise foreign types).
My main reason for including the per-call option was that I thought it might be annoying having to annotate all unions with the nestedtext attribute if you just wanted it enabled on all of them, and felt like it could be considered clutter on the actual types.
I'm still open to opinions though! If you think the per-union attribute does the job for you then maybe I'll release only that change for now.

I do see what you mean about this affecting all unions. After re-reading I hope I didn't come off as abrasive, by the way.
I wouldn't worry about foreign types. I was just spit-balling for what the use case might be. This is useful and I don't mind it. We already have cases in the standard library where we're passing in optional arguments via a tuple, so there's precedent. But I think having one way of doing this is probably enough, and for me I tend to prefer the first way (with the per-type declaration). But I'm happy either way.


train on dtu with different numdepth and interval

thank you for your great work.
i want to finetune the model on the same dtu dataset but with different numdepth (192->512) and intervalscale(1.06->0.25). as i want to get inference from the model for a high detail object which depth variation is a lot on its surface i think 192 may not suffice. so i decide to change these parameters in config file and finetune the model.(i want to finetune in small set of dtu scans). you saved the checkpoint in epoch 6, although after finetuning the loss decrease from 16 to ~6 but it does not decrease anymore. what is your suggestion for my problem?

besides, i want to know if i change depth_type from ce to reg it has positive effect? and also to increase "ndepths": [  32,  16,     8,    4 ], from 4 stages to 5 stages?


CustomScrollView should not scroll when pointer down starts on Sliver App Bar

When using SliverAppBar you can scroll the view by only touching the app bar, that is really weird.
Dragging inside SliverAppBar should not affect the scroll of the scroll view. Also it would be interesting to block scrolling also to SliverPersistentHeader when is collapsed.
https://dartpad.dartlang.org/7c10802218f91b56cfa51ae64a27f389

Code Sample
// Copyright (c) 2019, the Dart project authors.  Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        home: Scaffold(
      body: CustomScrollView(slivers: [
        SliverAppBar(
          pinned: true,
          title: Text('Sliver App Bar behaviour'),
        ),
        SliverList(
            delegate: SliverChildBuilderDelegate(
                (_, index) => ListTile(title: Text('item $index')),
                childCount: 100))
      ]),
    ));
  }
}

[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.18.0 at /Users/taha/Code/flutter_dev
    • Framework revision 14f3a36aba (3 days ago), 2020-04-03 17:06:01 -0700
    • Engine revision 09bc1fc45e
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 e736495eb7)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.0

[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome           • web-javascript • Google Chrome
      80.0.3987.149
    • Web Server • web-server       • web-javascript • Flutter Tools

• No issues found!


pretty.Sprint is CPU intensive, print only once

Since pretty.Sprint is pretty heavy, we should only be doing it once instead of twice.
The args don't mutate during the query, so we can generate the args string once and use it for tracing and for logging.

Hey there, this repo is not actively maintained, would you be willing to submit this PR to my fork ? https://github.com/luna-duclos/instrumentedsql


Adding a method to return the details of the icap request

This patch was created in order to get the details of the ICAP request like custom headers, icap version, etc.

👍


Datepicker doesn't clear input when it has an invalid value

Repo
Here is a StackBlitz with a min required code:
https://stackblitz.com/edit/angular-mat-datepicker-clear-input-uzdtjz?file=app/datepicker-overview-example.ts

Case №1:
Steps to reproduce:

Insert "a1" into an input field
Click the X button to clear.

Expected Behavior
Expect: to see an empty field with a placeholder.
Actual Behavior
Actual: an empty field with a placeholder.
 Passed

Case №2:
Steps to reproduce:

Insert "1" into an input field
Click the X button to clear.

Expected Behavior
Expect: to see an empty field with a placeholder.
Actual Behavior
Actual: for a moment input field displays the 1/1/2001 date and then we are able to see an empty field with a placeholder.
 Failed

Additional Information
If there any issue with input values into a field - refresh a page.

Environment

Angular: 10
CDK/Material: 10
Browser(s): Google Chrome
Operating System (e.g. Windows, macOS, Ubuntu):  Windows 10

I was looking into this and I think that it has nothing to do with Material. The problem is that you try to clear the value by assigning null, but if the value is already null, change detection won't pick it up and notify the datepicker. If you switch between null and undefined it works. https://stackblitz.com/edit/angular-mat-datepicker-clear-input-jv7267?file=app%2Fdatepicker-overview-example.ts
Closing the issue since we can't do much about it.

@crisbeto the field value isn't the same as the date picker value?

The value only gets assigned to the datepicker's model if it's a valid date. E.g. a1 and a2 both get assigned as null, because they're invalid.


Radiator valve

Hey there, first of all thank you for your work, it's amazing! I would like to ask that is there any way to control radiator valves through zipato with this plugin? Thank you!

Hello Aibkaresz
Today no, there is no way to use it. You can make some bypass and use a virtual switch and rules inside the box. That'll be a lot of work but I think it can work. But you'll have switches in Home app...
I recently bought two radiator valve and start to test it with the zipabox.
I'll certainly give some time to add it to the plugin but not in the next version.
So just wait (maybe a lot) and see


feat: Series descriptive methods

Description
Similar to #159 but for series and expr methods (complete list from polars); introduces the following Series methods:

is_duplicated
is_empty (not in expr)
is_unique
null_count
is_first_distinct
is_last_distinct
is_sorted (not in expr)
value_counts (not in expr)

thanks @FBruzzesi ! Looks like value_counts is failing on the minimum pandas version, possibly related to https://github.com/pandas-dev/pandas/pull/49912

thanks @FBruzzesi ! Looks like value_counts is failing on the minimum pandas version, possibly related to pandas-dev/pandas#49912

Thanks Marco, it seems that both naming and order is different (as if sort=True has no effect?). Should we manually address that? E.g. renaming and sorting afterwards?

I think order is fine, there are other places where the order isn't preserved (e.g. group_by) - shall we just document the lack of ordering guarantee, and fixup the names?

Pandas value_counts has a sort keyword since forever I think (v1.0 is the furthest I could find on the doc page). Setting sort=True and getting unsorted results is not ideal to me

yeah, sorry, hadn't looked carefully enough - sure, this one should be easy enough to work around and manually fixup


[feature request] Support of array formulas

Does exceljs supports array formulas?
If does, how can I use MMULT function?
Regards.

Closed, but what is the solution?


HfDeepSpeedConfig must be kept during AutoModel.from_pretrained if using ZeRO-3

According to Non-Trainer Deepspeed Integration:

The HfDeepSpeedConfig is used to integrate Deepspeed into the 🤗 Transformers core functionality, when Trainer is not used. The only thing that it does is handling Deepspeed ZeRO-3 param gathering and automatically splitting the model onto multiple gpus during from_pretrained call.

from transformers.integrations import HfDeepSpeedConfig
from transformers import AutoModel
import deepspeed

ds_config = {...}  # deepspeed config object or path to the file
# must run before instantiating the model to detect zero 3
dschf = HfDeepSpeedConfig(ds_config)  # keep this object alive
model = AutoModel.from_pretrained("gpt2")
engine = deepspeed.initialize(model=model, config_params=ds_config, ...)

But we seem to missing HfDeepSpeedConfig when init Actor, Critic, Reward.

this feature is used for ZeRO3 + save init GPU memory. Our RLHF only use ZeRO2 now~


Disable Create column button while the column name is empty

Fixes #25116

I have to say, without your GIF I wouldn't have had a single idea what this PR is fixing or what the original issue wanted…

There are some nits in code.
Before reviewing, the question is how does this fix #25116 ? #25116 said "click new column button to input name", then the input field is not empty?

You are right I tried creating a kanban board using Enter key It is  working fine.
My bad  I miss interpret the issue.
We can change the title of the issue.
'Disable Create column button while the column name is empty'
This pr is addressed the issue in the Pr.


Fallback to saved wallpapers when a new one can't be found.

I'm running a 1440p monitor so search seems to sometimes(often) have trouble finding me a new wallpaper within the 50 retries limit.
It would be nice if instead of displaying an error and not changing the wallpaper it would instead fallback to using one of the ones I already have downloaded. At least until the next time it's supposed to search that is.

Also I'm not really sure if search is supposed to fail this often so here is my query if you are interested.
subreddits -- MinimalWallpaper+wallpapers+wallpaper+NSFW_Wallpapers+Artsy_NSFW_Wallpapers+WQHD_Wallpaper+ghibli+bigwallpapers+MachinePorn+GeekPorn+spaceporn+EarthPorn+Offensive_Wallpapers
query -- 2560x1440 OR 1440p OR WQHD NOT (title: car OR title: lamborghini OR title: BMW)

Interesting idea. I can certainly look at implementing something like that for when RWC can't find new wallpapers after 50 trys (or you go offline). I guess there might be a few factors to consider though as I'm sure that not everyone saves/auto saves wallpapers so it might need something included to auto save some anyway.  I'll add it to the list of suggestions.
I might also look at just removing the 50 retries all together and let it retry infintely.

Added to the ideas list in the project plan.


vdirsyncer not working with horde server

I have vdirsyncer 0.5.2 installes on Max OS X (via homebrew) and I am trying to sync calendars between the local file system and our university's Horde server. The auto-discovery of collections seems to work fine, the actual syncing produces only many errors of the type "NotFoundError".
Example:
Unhandled exception occured for sgr_cal/calendar:iU0EldL9ojbyuFBg09A37g8.
Traceback (most recent call last):
File "/usr/local/Cellar/vdirsyncer/0.5.2/libexec/lib/python2.7/site-packages/vdirsyncer/cli/tasks.py", line 77, in sync_collection
force_delete=force_delete
File "/usr/local/Cellar/vdirsyncer/0.5.2/libexec/lib/python2.7/site-packages/vdirsyncer/sync.py", line 163, in sync
b_info.prepare_idents(storage_a.read_only)
File "/usr/local/Cellar/vdirsyncer/0.5.2/libexec/lib/python2.7/site-packages/vdirsyncer/sync.py", line 111, in prepare_idents
if prefetch else ()):
File "/usr/local/Cellar/vdirsyncer/0.5.2/libexec/lib/python2.7/site-packages/vdirsyncer/storage/dav.py", line 387, in get_multi
raise exceptions.NotFoundError(href)
NotFoundError: /horde3/rpc/calendars/sgr/calendar:iU0EldL9ojbyuFBg09A37g8/qHS4PBwb08G2KnLxo2Qq1w1.ics
What is wrong here? What more info should I provide?
Greetings, Stefan

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26490248-vdirsyncer-not-working-with-horde-server?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github).

Please use the -vdebug option and wrap with ``` when posting output.

Will do, but output will be very long! Should I post everything?

You can also send it to the email address on my profile, that's probably more sensible because the log might contain sensitive information (calendar content).

Mail is sent!

Oh, I just noticed that you use version 0.5.2, the latest version 0.6.0 fixes many bugs like this.

Ah, 0.6.0 just came around a few hours ago (on homebrew/Mac OS X) - tested it and it worked! Yeah and thanks a lot!

Glad it works!


Vulnerability issue of libpng

libpng versions 1.6.36 and earlier have a use-after-free bug in the simplified libpng API png_image_free(). It has been assigned ID CVE-2019-7317. The vulnerability is fixed in version 1.6.37, released on 15 April 2019.
http://www.libpng.org/pub/png/libpng.html
Maybe, the binaries could be updated?

See: https://github.com/JuliaIO/LibpngBuilder/pull/10

Sorry, didn't realise this

No, I started that PR because of this issue :P

https://github.com/JuliaIO/LibpngBuilder/releases/tag/v1.0.3

No, I started that PR because of this issue :P

:-D
You were so quick!


Improved error handling in authentication

This improves error handling in blockstack.js authentication.
If the given auth response object is invalid, it rejects with:
LoginFailedError('Invalid authentication response.')

If the given auth response object has version > 1.1.0 (when the transit key began to be used), and the decryption of the appPrivateKey fails, then the function rejects with:
LoginFailedError('Failed decrypting appPrivateKey. Usually means that the' +
                            ' transit key has changed during login.')

I also added code coverage for handlePendingSignin with both a bad transit key, and a good transit key.
You can test this by linking the modified blockstack.js and trying to sign in with a bad transit key (start the login in, in say, private browsing mode) and a good one.

This improves the error handling of https://github.com/blockstack/blockstack.js/issues/331

@kantai this is going to take a bit more time to test than I have remaining tonight. Will take a look at it tomorrow! Apologies for the delay!

Okay no worries, @larrysalibra -- we can ship this in another release, but I'll make a release with develop now to ship the default name lookup URL changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: kantai:x: larrysalibraYou have signed the CLA already but the status is still pending? Let us recheck it.

I tested this by linking blockstack-todos to it, starting a sign in session and deleting the transit key from local storage before approving it and it worked for me!


New Line

Is it possible to send a message with a new line? I have tried using \n, but it appears that the meesage simply does not send.

you need to escape the control characters or send a raw string like:
chatbot.send_message(r"new \n line")
or
chatbot.send_message("new \\n line")
I could add a check for this but I think that would cause an unnecessary overhead.

Thank you! This did work for me, but it caused the code to throw these error messages when I used chatbot.send_message("new \\n line")
10:26, ERROR: error from callback <bound method WebSockClient.on_message of <Reddit_ChatBot_Python.ws_client.WebSockClient object at 0x0000022061A0D360>>: Invalid control character at: line 1 column 101 (char 100)
10:26, ERROR: Invalid control character at: line 1 column 101 (char 100)
Do you know if there is a way to fix this? Sending the new line still works, but the error messages are cluttering up printing the chat on the console, and seems to be breaking something else in my code. Still trying to figure out why that last bit is happening.

Thank you!

for the future reference: i just pushed the 1.4.9 and it fixes a problem with ws messages which consequently solves new line problem as well. no need for the escaping anymore.
chatbot.send_message("new \n line") is fine now


Continued Addon Maintenance?

I've been working to update Craftility for The War Within, and have gotten it mostly error free. Are you still interested in maintaining this addon or could I fork it and take up maintaining the addon?

Absolutely feel free to fork it and continue with it. I no longer play WoW and have no intention to return so I do not have anything to develop on.
If you take it over let me know and I can update the readme to point to your fork.
Also feel free to reach out if you have any questions you think I might be able to answer. It has been a long time since I looked at the code, but I might be able to provide insight on why I did something a certain way.

I've been working to update Craftility for The War Within, and have gotten it mostly error free. Are you still interested in maintaining this addon or could I fork it and take up maintaining the addon?

I stumbled upon this addon about a month ago and was curious if you had any intentions on continuing maintenance of the addon. I'd really like to give it a shot.


llama-cpp: set build_number/build_commit for version info

Description of changes
Before:
./result/bin/llama --version
version: 0 (unknown)
built with clang version 16.0.6 for arm64-apple-darwin

After:
./result/bin/llama --version
version: 2674 (1958f7e)
built with clang version 16.0.6 for arm64-apple-darwin

Also switched the other substituteInPlace to --replace-fail.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Could you rebase? You raced with a @r-ryantm update.

@philiptaron Thanks, updated.


Install failing with errors around absl

What version of OR-Tools and what language are you using?
Version: v9.10
Language: C++
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
N/A
What operating system (Linux, Windows, ...) and version?
Windows 11 on AMD 7000 series
What did you do?
Steps to reproduce the behavior: following the instructions on the OR-tools website fails. The exact steps to reproduce are

git clone https://github.com/google/or-tools
cd or-tools
git checkout v9.10
cmake -S . -B build -DBUILD_DEPS=ON
cmake --build build --config Release --target ALL_BUILD -j -v

What did you expect to see
Successful build
What did you see instead?
Full error message below: 5 errors all similar to C:\Users\Tom Whitehead\Documents\Git\or-tools\build\_deps\abseil-cpp-src\absl\numeric\int128.cc(32,24): error C2491: 'absl::lts_20240116::kuint 128max': definition of dllimport data not allowed
Make sure you include information that can help us debug (full error message, model Proto).
traceback.txt
Anything else we should know about your project / environment

Can you run cmake -G to know which generator you used ?
The one with the * is your default one

Thanks @Mizux : output below. I do have VS 17.10 2022 installed if that makes a difference.
PS C:\Users\Tom Whitehead\Documents\Git\or-tools> cmake -G
CMake Error: No generator specified for -G

Generators
* Visual Studio 17 2022        = Generates Visual Studio 2022 project files.
                                 Use -A option to specify architecture.
  Visual Studio 16 2019        = Generates Visual Studio 2019 project files.
                                 Use -A option to specify architecture.
  Visual Studio 15 2017 [arch] = Generates Visual Studio 2017 project files.
                                 Optional [arch] can be "Win64" or "ARM".
  Visual Studio 14 2015 [arch] = Generates Visual Studio 2015 project files.
                                 Optional [arch] can be "Win64" or "ARM".
  Visual Studio 12 2013 [arch] = Deprecated.  Generates Visual Studio 2013
                                 project files.  Optional [arch] can be
                                 "Win64" or "ARM".
  Borland Makefiles            = Generates Borland makefiles.
  NMake Makefiles              = Generates NMake makefiles.
  NMake Makefiles JOM          = Generates JOM makefiles.
  MSYS Makefiles               = Generates MSYS makefiles.
  MinGW Makefiles              = Generates a make file for use with
                                 mingw32-make.
  Green Hills MULTI            = Generates Green Hills MULTI files
                                 (experimental, work-in-progress).
  Unix Makefiles               = Generates standard UNIX makefiles.
  Ninja                        = Generates build.ninja files.
  Ninja Multi-Config           = Generates build-<Config>.ninja files.
  Watcom WMake                 = Generates Watcom WMake makefiles.
  CodeBlocks - MinGW Makefiles = Generates CodeBlocks project files
                                 (deprecated).
  CodeBlocks - NMake Makefiles = Generates CodeBlocks project files
                                 (deprecated).
  CodeBlocks - NMake Makefiles JOM
                               = Generates CodeBlocks project files
                                 (deprecated).
  CodeBlocks - Ninja           = Generates CodeBlocks project files
                                 (deprecated).
  CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files
                                 (deprecated).
  CodeLite - MinGW Makefiles   = Generates CodeLite project files
                                 (deprecated).
  CodeLite - NMake Makefiles   = Generates CodeLite project files
                                 (deprecated).
  CodeLite - Ninja             = Generates CodeLite project files
                                 (deprecated).
  CodeLite - Unix Makefiles    = Generates CodeLite project files
                                 (deprecated).
  Eclipse CDT4 - NMake Makefiles
                               = Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Eclipse CDT4 - MinGW Makefiles
                               = Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Kate - MinGW Makefiles       = Generates Kate project files (deprecated).
  Kate - NMake Makefiles       = Generates Kate project files (deprecated).
  Kate - Ninja                 = Generates Kate project files (deprecated).
  Kate - Ninja Multi-Config    = Generates Kate project files (deprecated).
  Kate - Unix Makefiles        = Generates Kate project files (deprecated).
  Sublime Text 2 - MinGW Makefiles
                               = Generates Sublime Text 2 project files
                                 (deprecated).
  Sublime Text 2 - NMake Makefiles
                               = Generates Sublime Text 2 project files
                                 (deprecated).
  Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files
                                 (deprecated).
  Sublime Text 2 - Unix Makefiles
                               = Generates Sublime Text 2 project files
                                 (deprecated).

While I still don't know  what's happen, kuint128max was gone in abseil-cpp 20240722.0...
ref: https://github.com/abseil/abseil-cpp/commit/34604d5


update static site and spec

PR Description
PR 1/2 of updating API doc update system. The second PR 2/2 will be done on master to update CI and scripts.

update static site and spec
rename spec files with "teku-" prefix
remove old versions and update versions.json

Next step is updating the master CI config and scripts.
Fixed Issue(s)

fixes #3231
fixes #2128
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixes for kernel private memory size test

Add the test source to CMakeLists.txt
Register the test with the api suite
Fix build error in host code
Use uint instead of ulong (not all devices support 64-bit types)

@chemis01 please take a look.

@jrprice Looks good to me, thank you.