Latency Threshold in the example graphs

In the Example section you have two graphs. One with docker and one without.
It seems that the test without docker has a higher latency threshold than the one with docker.
Do you perhaps know the reason why this happens? I would think that a system with docker would have a higher latency threshold.

Hi @elishafer,
I do not see a noticeable difference between the two graphs. The data was obtained by 5 minutes of benchmark and I would assume that any visible difference would be caused by the small sample size (normally you would run these tests for several hours/days) as well as background load. As Docker is based on abstractions on the Linux kernel level , it should achieve native performance on a Linux machine. After all a Docker container still uses the same kernel as the host system! The only aspects that might suffer a slight performance hit are those where some form of virtualization is involved, such as I/O and networking. Latter can be worked around by removing the isolation between the container's network stack and the host systems with net=host. For actual benchmarks you might have a look at this fairly old research paper from IBM (also available for free on IBM Research).

Thanks for the quick and detailed response! Also thank you for your guides, your motivation section for academy really struck a chord with me.

Glad to hear that!
Let me know if we can close this issue.


FORCEQUITTING AND REOPENING MAKES BRACKET GO BLANK

Prerequisites

[ ] Can you reproduce the problem with Debug -> Reload Without Extensions? YES
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported? YES
[ ] Did you read the Troubleshooting guide? YES

For more information on how to write a good bug report read here
For more information on how to contribute read here
Description
This has happened a million times to me on mac and on windows. After keeping brackets inactive, it makes my computer really slow, so I force quit it, but then the next day when I reopen it, The app is blank, so I have to quit it and then reopen which works then. I think Its the js file which has a bug.
Other than that, App is good
Steps to Reproduce

Force Quit
Restart
Watch Brackets blank(to some or all users)

Expected behavior: Just app opens, GUI can be seen
Actual behavior: Just app opened no GUI seen
Versions
OS V-  Mac Sierra, Windows 10 Pro
Bracekts V - 1.11

Repro step:
So assume your computer hangs for some time and only brackets is open so i  force quit it, then restart it and then u will see a black screen...


Implement cors headers.

Closes #571

Thanks for the PR!
Could you make this an optional configuration option, along with the hostnames to enable?  Having CORS wide opened like this basically opens it up to any website on the internet, which the app should not be doing in its default configuration.

Implemented in 838c4a0


Show name, affiliation and link on dropdown speakers info

Intends to resolve #783 .
Result:

Current coverage is 42.54% (diff: 100%)

Merging #785 into development will not change coverage

@@           development       #785   diff @@
=============================================
  Files                6          6
  Lines              731        731
  Methods             73         73
  Messages             0          0
  Branches           118        118
=============================================
  Hits               311        311
  Misses             420        420
  Partials             0          0

Powered by Codecov. Last update 97000d9...2b3dd7f

@shubham-padia The issue says to add name and org in gray area. According to me it's not looking good center aligned.

Nice. Next steps:

[ ] Yes, please keep the text alignment.
[ ] Add following text into gray area "Abdul Rauf (Mozilla)"

@mariobehling Updated the PR, looks like this now,

Ok, thanks for the screenshot. I think you are right, it looks too squeezed. Please

[ ] move the sharing link into the social media area
[ ] No need to repeat the name in the white area

@mariobehling In the current social media area, there is no space left for putting the share link due to unnecessarily large spacing between the icons.
Right now :

1st approach :
If we reduce the unnecessary spaces :

2nd Approach:
Alternatively without removing the spacing, placing the share link on a new line can also work :

Should I go with approach 1 or 2 ?

@shubh1m Thank you. There is probably no perfect solution, but let's try the 1st approach and see how it works for the users, I would say.

@mariobehling updated the code according to approach 1. Please review.

Thank you!

So, looking at the details I see you are not using US/British punctuation rules and we can enhance some details. Created a follow up issue. Thank you: https://github.com/fossasia/open-event-webapp/issues/791


What’s the difference between WebServer and Airflow CLI?

@mik-laj please reopen if this issue is still relevant


Make pipectl plan-preview command renders the results to stdout and file

What this PR does / why we need it:
This PR updates pipectl to make its plan-preview command renders the results to both stdout and a given file.
This also adds the needed fields to the PlanPreview's models.
Which issue(s) this PR fixes:
Fixes #2109
Does this PR introduce a user-facing change?:

NONE

/golinter fmt

excellent!
/lgtm

Way to go 🚀
/approve


Conditionally sync videos when chosen

VideoChosenView currently always updates existing items from the library when chosen, which could be considered wasteful in environments that are regularly synced. These changes add a new BYNDER_SYNC_EXISTING_VIDEOS_ON_CHOOSE setting to toggle this behaviour, in-line with the equivalent views for images and documents.

Gawd bless ya, @zerolab!


Add aria-attributes?

As a follow up to adding SVG tags. See https://github.com/PurpleKingdomGames/tyrian/pull/97#issuecomment-1115244031
At the moment, for me at least, mostly useful when (semi) automatically converting Tailwind templates from html to tyrian.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes

Just having another look at this. What we need is a table of names and acceptable types, then the attributes can be generated along with the others... but I'm struggling to find one. MDN usually does the trick but I'm not seeing it this time?
As a first pass, I'm going to generate all of these as string attributes and people can help improve them as they discover problems.


Backport SVG related patches

TODO:

[ ] fix form state icons escaping
[ ] backport missing bg optimization
[x] optimize SVGs
[ ] merge to the v4-dev-xmr branch, not v4-dev

I don't think https://github.com/twbs/bootstrap/pull/29139/commits/432605e0097bc1f084091de2eedc667777eb72f8 is related to this PR.

 I could split 8c2836a and 432605e tomorrow assuming we finish this branch.


Parse authParamsString on plugin side

Motivation
#671

Use unique parsing logic for authParamsString on plugin side

Modifications
I added AuthParamsStringConfigurable interface to parse authParamsString on plugin side.

If AuthParamsStringConfigurable is implemented, parse authParamsString on plugin side.
If AuthParamsStringConfigurable is not implemented, use default parsing logic(separated by “:” and “,”) on AuthenticationFactory.

Result

We can parse authParamsString on plugins side by overriding configure(String authParamsString) in AuthParamsStringConfigurable interface.

I added AuthParamsStringConfigurable interface to parse authParamsString on plugin side.

If AuthParamsStringConfigurable is implemented, parse authParamsString on plugin side.
If authParamsString is JSON, parse JSON on AuthenticationFactory.
If authParamsString is not JSON, use current parsing logic(separated by “:” and “,”) on AuthenticationFactory.

@tkb77 Can you explain why we should parse JSON in AuthenticationFactory in spite of the fact that plugins can easily do that in the new configure? It would be just a line.
Map<String, String> authParams = AuthenticationUtil.configureFromJsonString(authParamsStr);

I don't see pros keeping the old configure interface and supporting new format in it. I think it should be left just for compatibility.
Also, format auto-detecting is not so easy.
"abc":"x,y,z"}

Note that { is missing. This string would be parsed as a colon-comma format string, which means that abc would not be set without any errors. This is unsafe.

I can not explain the clear reason.
I try to parse authParamsString on plugin side without changing current parsing logic.
I will only add AuthParamsStringConfigurable interface and enable AuthenticationFactory to use it in this pull request.
I will implement original parsing logic on the plugin side at the next pull request.

retest this please

LGTM

If I understand you all correctly, our consensus here is:

Replace configure(Map<String, String> with configure(String)
Provide a separated interface to manage compatibility
Add support for JSON to Athens plugin (or provide an utility class and use it from plugins)

and I think we should:

Deprecate the old configure in 1.20 (or 1.21), and remove it in 2.0
Integrate the new configure into Authentication and deprecate the separated interface in 2.0

@tkb77 @merlimat @rdhabalia Makes sense?

@ maskit
Thank you for your comments.

AuthParamsStringConfigurable -- The name might be unclear.
What did you feel unclear about the name?
Please tell me if there is an idea or suggestion.

Old configure -- Should be deprecated
Does the old interface need to be deprecated?
When deleting the old interface, it is inconvenient because we have to give all settings as a string.

New configure -- Future plan should be explained on Javadoc
I will add javadoc for the new interface.

@tkb77

What did you feel unclear about the name?
Please tell me if there is an idea or suggestion.

I can understand the name because we have been talking about it but I'm not confident with that plugin developers easily understand what it is for. The name you suggested doesn't add any context (the same thing is already written as the method name and the parameter name). As I wrote on the issue, I'd suggest EncodedAuthenticationParameterSupport. I'm also fine with Pulsar2AuthenticationInterface if we agreed on marking the old one deprecated.

Does the old interface need to be deprecated?
When deleting the old interface, it is inconvenient because we have to give all settings as a string.

Yes, I think it need to be deprecated because it makes API simple and solid, and it indicates that we are not going to add support for other formats on configure. As I wrote above, plugin developers can parse the string with just one line if we provide an utility class.
Honestly, I'd not write configuration values directly in authParams if I wrote a plugin which requires many and/or complex configurations. I'd write just an external filename or an URL instead. Even if the format was JSON, one line JSON is hard to read / write.

@ maskit
Thank you for advising me.
I fixed as follows.

Add Javadoc
Set deprecated to the old configure
Rename the new interface EncodedAuthenticationParameterSupport

LGTM. @maskit can you do a final check on this?


Multiple card processing issue

It looks like there is an issue with some customers being double (triple and quadruple billed) when paying via stripe. So here is my diagnosis of the issue so far:

A customer adds products to their cart and checkout
They enter their card details into the stripe form and a stripe token is then generated
The user then decides to go back to the shop and add other products (after the stripe token has been created)
They then go through the checkout process again

Step 4 is where I believe the issue lies. A new token is created thus when the customer is asked to 'finalise their order', the card is being processed more than once.

Hmm, I'll try and replicate this

Thanks.


docs(github-templates): adding different kind of issue templates and update the pull request template.

Purpose

Include the following issue templates:

EngineeringFundChecklist
Sprint0
bug
check-point
design-review
dod-review
feature
found-dead-links
release
retro
sprint-tracker
task
user-story

Creating a draft PR to discuss the use of the templates

Does this introduce a breaking change?

[ ] Yes
[x] No

Author pre-publish checklist:

[ ] Added test to prove my fix is effective or new feature works
[ ] No PII in logs
[ ] Made corresponding changes to the documentation

@devlace Let's catchup to discuss this one before looking into a PR option


custom TabBarView animations

make a custom TabController

TabBarView doesn't always need to be TabBarView if animations are very specific. Then, just the passed views is manipulated by AnimatedBuilder

no animation?


Exception: Multiple node elments can't be created when using HtmlNode.CreateNode

Description
I'm having issues creating a simple node from a fixed string
Sample code
 [TestClass]
    public class UnitTest1
    {
        [TestMethod]
        public void TestMethod1()
        {
            string ga = "

fds	fsd	fsd	5/22/2017

";
            HtmlNode oldTable = HtmlNode.CreateNode(ga);
        }
    }

Exception
Exception message:
Stack trace:
Multiple node elments can't be created.
    at HtmlAgilityPack.HtmlNode.CreateNode(String html) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.cs:line 719

Fiddle or Project
I did this fiddle but i was not able to save it.
using System;
using HtmlAgilityPack;
public class Program
{
	public static void Main()
	{
		 string ga = "

fds	fsd	fsd	5/22/2017

";
            HtmlNode oldTable = HtmlNode.CreateNode(ga);
	}
}

.net code 4.7.2
Further technical details

HAP version: 1.11.7
NET version :4.6.1

it would help if i use correct html.


Patch international branch with security updates

See DoSomething/devops#87

Patch international branch with security updates
Current International branch is outdated.

[ ] Make a list of updates to include
[ ] Patch the branch
[ ] Test the branch
[ ] Deploy to production

Hi @andrea! Need your opinion. I’m patching international with security fixes. I cherry picked relevant version updates from the main branch (see #6386).
And everything is fine, except I don’t know what should I do with Features module patch. Because it needed an update for 7 minor versions (7.x-2.2 to 7.x-2.9), there are some changes in the export syntax. Normal procedure is to recreate all feature based modules, so I did it for dev branch, see #6382.
However, features intl-sites branch is outdated and feature modules are significantly behind dev. It's not possible to easily cherry pick this updates from #6382. I can recreate feature modules in intl-sites branch the same way I did in dev, but it'll take some time and it's risky.
Alternatively, we can leave it all like this. Feature modules should work fine, except they will be displayed as 'Overridden'. So the question is — does it really worth it and should invest my time in it?
cc @sheyd

@sergii-tkachenko let's go with the overridden route

Hi, wrong handle
On 20 Apr 2016 7:23 pm, "Sergii Tkachenko"<EMAIL_ADDRESS>wrote:

Hi @andrea https://github.com/andrea! Need your opinion. I’m patching
international with security fixes. I cherry picked relevant version updates
from the main branch (see #6386
https://github.com/DoSomething/phoenix/pull/6386).
And everything is fine, except I don’t know what should I do with Features
module patch. Because it needed an update for 7 minor versions (7.x-2.2 to
7.x-2.9), there are some changes in the export syntax. Normal procedure is
to recreate all feature based modules, so I did it for dev branch, see
#6382 https://github.com/DoSomething/phoenix/pull/6382.
However, features intl-sites branch is outdated and feature modules are
significantly behind dev. It's not possible to easily cherry pick this
updates from #6382 https://github.com/DoSomething/phoenix/pull/6382. I
can recreate feature modules in intl-sites branch the same way I did in
dev, but it'll take some time and it's risky.
Alternatively, we can leave it all like this. Feature modules should work
fine, except they will be displayed as 'Overridden'. So the question is —
does it really worth it and should invest my time in it?
cc @sheyd https://github.com/sheyd
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/DoSomething/phoenix/issues/6331#issuecomment-212544867

Wrong handle?

Ah, sorry @Andrea, confused this with Slack. My apologies.


chore: add testcase for slice equality failing in comptime interpreter

Description
Problem*
Resolves
Summary*
This PR adds a test case for #5273 which tracks whether the compile is properly handling comptime slice equalities. Once #5273 is fixed then it should be moved to compile_success_empty.
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

This test needs to be exempted from the legacy tests for CI to pass.
I think we can just wait and add this test as part of https://github.com/noir-lang/noir/pull/5276 when it is expected to work though.

I've added an entry to ignore the legacy test.

My thinking on this is it's generally just observability. Tests become us asserting that the compiler does what we expect rather than just "working correctly". This ensure that if the behaviour of the compiler changes in future then we'll be aware of it.

@TomAFrench I can see that argument, but doesn't it apply to all known issues? I think we should just wait until traits / operator overloading is implemented in the interpreter to add this test since I don't see it being accidentally added.


Geometry Qualifier - list needs to be reviewed and updated

This was identified when reviewing the Research Permit resource model, but the list should probably be the same for all geometry qualifiers in the system. Need to:

[ ] Remove any values that are not relevant to FMO
[ ] Ensure wording works for relevant values
[ ] Add any values that may be missing

Once list has been defined

[ ] @bferguso to update the values in the RDM

From existing default terms related to Spatial Location, we would like the following in the LOV, with this wording:
access point
buffer polygon
centre point
footprint polygon
perimeter polygon
datum point


As a busy university student taking many modules simultaneously, I can make use of the todo list.

To prevent myself from missing important deadlines.

Removed feature.


Safari selects wrong language with two common roots

Version Information

WordPress: 4.6.1
MultilingualPress: 2.4.7

Steps to Reproduce

Base site with language English
Additional site with language en-GB
Ensure priority for both languages to the same value (I'm using 2)
Only redirect from main site, not from other language
Browse to main site from chrome, firefox, and safari

What I Expected
With system/browser language set to US english, no redirect occurs. This is the case in Chrome and in Firefox.
What Happened Instead
In Safari only, redirect occurs to en-GB despite system language set to US English.
*Note that not setting equal priority will cause the higher priority site to always load in any browser, regardless of system language.
Overall expectation
The larger desired behavior here is that if a user comes to the site with US English, no redirection occurs. If they come to the site with en-GB, they are redirected to the en-GB site.
Browser Information (all current versions on OS X)
Here are the Accept-Language header values for various browsers with a US English configuration
Safari
[en-us] => 1
Firefox
[en-US] => 1
[en] => 0.5
Chrome
[en-US] => 1
[en] => 0.8

Hi, and thanks for this (detailed) issue.
the problem is that Safari seems to be sending lowercase values in the Accept-Language header. MultilingualPress, however, is matching against HTTP codes with the language part being lowercase, while the region part is uppercase.
I did a quick search and learned that a lowercase value seems to be perfectly valid.
MultilingualPress is trying to match en-us, case-sensitively, against en-US—and fails. There are, however, two MultilingualPress languages with the same language part like the Accept-Language header value (i.e., en). These are ordered by priority (and then alphabetically). Since they both have the same priority, en-GB goes before en-US). Result: since redirection is enabled on the US English site, the user gets redirected to the GB language version.
If you are a developer, you could try the following changes to inc/redirect/Mlp_Language_Negotiation.php:

in Mlp_Language_Negotiation::parse_accept_header(), add the following line as first line inside the foreach loop (in line 175):

$name = strtolower( $name );,
so you have the following:
foreach ( $fields as $name => $priority ) {

	// The following line is the new one.
	$name = strtolower( $name );

	$out[ $name ] = $priority;

	// ...
}

in Mlp_Language_Negotiation::get_user_priority(), set both language codes to lowercase as well, so you get the following:

$lang_http = $language->get_name( 'http_name' );

// The following line is the first of the new ones.
$lang_http = strtolower( $lang_http );

// ...

$lang_short = $language->get_name( 'language_short' );

// The following line is the second and last of the new ones.
$lang_short = strtolower( $lang_short );

This should do the trick. If it really does, it will soon get shipped in a new release.
Thanks,
Thorsten

Hi Thorsten,
Thanks for the code. I've made the necessary modifications, but unfortunately that doesn't seem to do it. in Mlp_Language_Negotiation::get_redirect_match the possible matches are sorted by priority. Here are the results. If we pop an entry off, then we end up with the GB site, even though our browser language is set to en-us. I can change the priority, but then I can't get a redirect to en-GB if the browser (rather the whole system in the case of safari) is set to use that language in any browser at all.
Array
(
    [1] => Array
        (
            [priority] => 2
            [url] => http://example.com/
            [language] => en-US
            [site_id] => 1
        )

    [0] => Array
        (
            [priority] => 2
            [url] => http://example.com/gb/?noredirect=en_GB
            [language] => en-GB
            [site_id] => 4
        )

)

Hi,
thanks for reporting back.
I will try this locally with faked data for both Accept-Language and possible translations.
The problem, as I see it now, is that MultilingualPress does not differentiate between language codes that match with their language and region parts, and the ones that only match with their language part. This is, of course, not ideal.

It does seem that way. I am guessing that in the Firefox and Chrome cases it work out better because they report the language with a lower priority. (region = 1, language = .5/.8). In that way the priority is then properly modified (priority * browser_priority) and the correct site locale can then be selected. With Safari, MultilingualPress adds the non-region language entry because Safari doesn't provide it, and copies the priority, so both end up equal.
Side note: MultilingualPress also adds an empty entry on for Firefox and Chrome, though it doesn't seem to have any ill effect in my setup. I wasn't able to look into why that is.

Thanks for looking into it. You made the same observations as I did. :)
Currently, I'm thinking about adding a language-only match with a lower priority than the full one. This lower value could be calculated by the original priority of the full language, multiplied with a filterable factor, which defaults to maybe 0.7.
I also saw the entry with the empty key. This is happens because MultilingualPress returns '' for the short version of language-only value (that already is short). ;) I will fix this as well. Expect an update in the according branch next week.
Thanks again!

Hey @dboune,
I finally managed to give this a try. If you have time, feel free to check out the new feature branch. All changes were made in ince/redirect/Mlp_Language_Negotiation.php, so you could also just go ahead and copy that file into your MultilingualPress source.
The commit includes all changes like proposed:

introduce a filterable factor (by default .7) for language-only redirect matches;
ignore potential empty short language values (i.e., '').

Thanks,
Thorsten

@tfrommen This worked for me! Thank you! Safari on IOS also had the same issue (not unexpected), and both are now working as expected for my particular scenario. I have not tested more than two locales with the same root.

Great! Thanks for testing, @dboune - I will merge this and release it sometime soon.


Added Smooth Scrolling in B2T and Customize the Scrollbar | Issue #21

https://github.com/user-attachments/assets/f88f86c7-7b28-4170-a326-d96b59fe9ade
Completed #21

@Shariq2003 Looks good just change the scroll top button icon...  you can download icon from this URL
https://www.flaticon.com/search?word=scroll top
Note :

It needs to be circular like the chatbot button
Should be in white or black theme color

@Shariq2003 Looks good just change the scroll top button icon... you can download icon from this URL
https://www.flaticon.com/search?word=scroll top
Note :

It needs to be circular like the Chatbot button
Should be in white or black theme color
It's size should be similar to Chatbot button, I think you made it little bigger then before please correct it

okay sir

@Vinay-Khanagavi sir check now
https://github.com/user-attachments/assets/b3ad6bf1-363b-4cfc-b2df-12b75652a27c

Thanks for the contribution

@Vinay-Khanagavi u have added invalid tag

Thanks sir

Yeah no problem.. join the discord server if you didn't yet


Add fix to LngLatAlt deserilizer for mongo

Adds a third case statement encase the json string contains string
coordinate values instead of a double
Fix for issue #28

Any action on this PR?

Thx for the PR

:) thanks for merge

Have you uploaded version 1.7 to maven central?

Of course:
http://search.maven.org/#artifactdetails|de.grundid.opendatalab|geojson-jackson|1.7|jar


Fix TimeFormatExtractionFn getCacheKey when tz, locale are not provided.

The docs claim tz, locale are optional but getCacheKey threw NPE when either was null.
This also prevents some Druid SQL queries from working when cache is enabled, since it uses TimeFormatExtractionFn for some features.

👍


0.1.10-preview of Microsoft.Build.Sql introduces build error on arm64 .NET 6

SqlPackage or DacFx Version:
.NET Framework (Windows-only) or .NET Core:
Environment (local platform and source/target platforms):

Steps to Reproduce:

Using WideWorldImporters as a demo environment, extract to a project (SDK-style)
Project builds fine (with model warnings) on 0.1.9-preview
Update SDK reference to 0.1.10-preview

➜  WideWorldImporters dotnet build
MSBuild version 17.3.2+561848881 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
/Users/drewsk/.nuget/packages/microsoft.build.sql/0.1.10-preview/tools/netstandard2.1/Microsoft.Data.Tools.Schema.SqlTasks.targets(451,5): error MSB4216: Could not run the "SqlModelResolutionTask" task because MSBuild could not create or connect to a task host with runtime "NET" and architecture "arm64".  Please ensure that (1) the requested runtime and/or architecture are available on the machine, and (2) that the required executable "MSBuild.exe" exists and can be run. [/Volumes/Storage/CodeRepos/dzsquared/build2023-demo/sql/WideWorldImporters/WideWorldImporters.sqlproj]
/Users/drewsk/.nuget/packages/microsoft.build.sql/0.1.10-preview/tools/netstandard2.1/Microsoft.Data.Tools.Schema.SqlTasks.targets(452,7): error MSB4027: The "SqlModelResolutionTask" task generated invalid items from the "Include" output parameter. This object is no longer valid because the MetadataLoadContext that created it has been disposed. [/Volumes/Storage/CodeRepos/dzsquared/build2023-demo/sql/WideWorldImporters/WideWorldImporters.sqlproj]

Build FAILED.

/Users/drewsk/.nuget/packages/microsoft.build.sql/0.1.10-preview/tools/netstandard2.1/Microsoft.Data.Tools.Schema.SqlTasks.targets(451,5): error MSB4216: Could not run the "SqlModelResolutionTask" task because MSBuild could not create or connect to a task host with runtime "NET" and architecture "arm64".  Please ensure that (1) the requested runtime and/or architecture are available on the machine, and (2) that the required executable "MSBuild.exe" exists and can be run. [/Volumes/Storage/CodeRepos/dzsquared/build2023-demo/sql/WideWorldImporters/WideWorldImporters.sqlproj]
/Users/drewsk/.nuget/packages/microsoft.build.sql/0.1.10-preview/tools/netstandard2.1/Microsoft.Data.Tools.Schema.SqlTasks.targets(452,7): error MSB4027: The "SqlModelResolutionTask" task generated invalid items from the "Include" output parameter. This object is no longer valid because the MetadataLoadContext that created it has been disposed. [/Volumes/Storage/CodeRepos/dzsquared/build2023-demo/sql/WideWorldImporters/WideWorldImporters.sqlproj]
    0 Warning(s)
    2 Error(s)

Time Elapsed 00:00:00.95

As part of this, let's investigate how we can beef up test coverage to prevent these types of regressions in the future

I'm getting the same error on Azure Data Studio while trying to build the DacPac project. Is there any update?
System:
Mac M1,
macOS Ventura 13.3.1 (a)

I'm having the same issue when using the SQL Database Projects extension on VS Code  and trying to Right click on project > Build | Publish.
If I use the CLI Tools with
$ dotnet build

I get the same error.
It only builds when unloading the Sdk Version to 0.1.9-preview or previous versions on the .sqlproj like this:
<Sdk Name="Microsoft.Build.Sql" Version="0.1.9-preview" />

Tested on:

MacBook Pro M2 Max 32 GB

macOS Ventura 13.5

VS Code 1.80
.NET SDK 7.0.203

I've done a few more tests and updated my .NET SDK to 7.0.306 version and it builds correctly even with the latest Sdk Version: 0.1.10-preview


rewrite dev example

Now the dev example is too huge and unmanageable. Need to split more small examples.
E.g.

[ ] input fields

[ ] selects

[ ] date pickers

[ ] sliders

[ ] checkbox, switch, radio

[ ] small real example (user settings)

[ ] sandbox (for develop & test new fields)

Is it ok to do a solution with vue router ? Have pages with all the things mentioned above

@cristijora yes please, because, if we need to do a different webpack config each time, it is going to be a pain

I can start working on this in a day. Don't know how much time it will take though.

Great!

Do you want it very simple and clean or have some bootstrap stuff in it so the examples look more pretty ?

I think need bootstrap because need it for some fields. So can be pretty :)

Hey @cristijora , what's your progress on this issue ? Any roadblock ? Need help ?

I have some issues with free time. Started 2 pages (inputs and selects) Don't have any roadblock but help would be appreciated. You can see the linked commit from above. Hope I can find some free time by the end of this week but help would be needed indeed here.

Since you're reworking the examples, should the font conform to the standard Bootstrap v3 fonts?  Devs tend to copy/paste examples, so they should be as agnostic & flexible as possible IMHO.

Any updates about it?

I was thinking about having a go at this today, but I'm not going to get time for a while.
I think this should probably be merged with #166. Seems pretty do-able, just finding time.


LoadFontFace from []byte vs. filepath?

Is there any suggested way of loading a fontface from a []byte vs. filepath?

hello! please read https://github.com/fogleman/gg/issues/141#issuecomment-911164281. you can probably use something similar.


Fix mesos cluster scheduler options double-escaping

What changes were proposed in this pull request?
This is a port of SPARK#20641

Don't enclose --conf option value with "", as they are already escaped by shellEscape
and additional wrapping cancels out this escaping, making the driver fail to start.
This reverts commit 9b377aa [SPARK-18114].

How was this patch tested?

Manual test with driver command logging added.

This PR is outdated, a different PR was merged on apache/spark addressing this same issue SPARK#21014


Switch to NpmClientHandler

Traceback (most recent call last):
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\sublime_lib\st3\sublime_lib\resource_path.py", line 521, in read_bytes
    return sublime.load_binary_resource(str(self))
  File "C:\Program Files\Sublime Text\Lib\python33\sublime.py", line 247, in load_binary_resource
    raise IOError('resource "%s" not found' % name)
OSError: resource "Packages/LSP-bash/bash-language-server" not found

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Program Files\Sublime Text\Lib\python33\sublime_plugin.py", line 478, in on_api_ready
    plc()
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Installed Packages\LSP-bash.sublime-package\plugin.py", line 6, in plugin_loaded
    LspBashPlugin.setup()
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\lsp_utils\st3\lsp_utils\npm_client_handler.py", line 61, in setup
    cls.__server.setup()
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\lsp_utils\st3\lsp_utils\server_npm_resource.py", line 68, in setup
    self._copy_to_cache()
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\lsp_utils\st3\lsp_utils\server_npm_resource.py", line 92, in _copy_to_cache
    ResourcePath(src_path).copytree(cache_server_path, exist_ok=True)
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\sublime_lib\st3\sublime_lib\resource_path.py", line 608, in copytree
    resource.copy(file_path)
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\sublime_lib\st3\sublime_lib\resource_path.py", line 582, in copy
    data = self.read_bytes()
  File "C:\Users\Clover\AppData\Roaming\Sublime Text\Packages\sublime_lib\st3\sublime_lib\resource_path.py", line 523, in read_bytes
    raise FileNotFoundError(str(self)) from err
FileNotFoundError: Packages/LSP-bash/bash-language-server

>>> sublime.load_binary_resource('Packages/LSP-bash/bash-language-server')
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Program Files\Sublime Text\Lib\python38\sublime.py", line 247, in load_binary_resource
    raise FileNotFoundError(f'resource "{name}" not found')
FileNotFoundError: resource "Packages/LSP-bash/bash-language-server" not found

It clearly worked before or nobody would be able to install the server. Stange. :)

Or maybe I somehow test it in a wrong way since I do it all manually with downloaded zip files.

Something must be wrong with the way you are testing yes.
BTW. When manually trying sublime.load_binary_resource('Packages/LSP-bash/bash-language-server') you need to switch to Python3.3 host (right click in console input field).

Actually load_resource doesn't work with directories but sublime_lib does so this should work:
sublime.load_binary_resource('Packages/LSP-bash/bash-language-server')

At this moment,

if I test it like there is a .no-sublime-package, it installed.
if I test it with a manually packed .sublime-package, it failed to installed.

Nvm. Things are all good.
Somehow the package created by Package Control: Create Package File works.
While the one I manually zipped and change ext to .sublime-package does not. :confused:
I have no problem with this PR now.

Cool. I also wasn't able to make my manually zipped package to work. So strange. :)


Fixed typos with receive

Fixed typos with the word "receive"

Automated message from Dropbox CLA bot
@Jeffthebest1, it looks like you've already signed the Dropbox CLA. Thanks!


Search for card by name occasionally slow

SELECT * FROM _cache_card AS c WHERE ((1 = 1) AND LOWER(c.name) IN ('mana bloom'))

Has hit over 10s a decent number of times. If we have the canonical name here we can do something more sensible. /seasons/9/cards/mana+bloom/

It's the call to LOWER and not the pointless 1 = 1 or IN that contributes to the speed here.
This query is around 30ms on local but less than 10ms when the LOWER is removed.
I'm inclined to put canonical_name into the cards table. Also we don't seem to use name_ascii anymore (??) so that could be removed.


sage: 9.8 -> 10.0

Description of changes
Includes updates to Singular, PARI and Giac.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build sageWithDoc

@ofborg build giac-with-xcas sageWithDoc

@ofborg build giac-with-xcas sageWithDoc

@ofborg build giac-with-xcas sageWithDoc

The aarch64 test timeout is rare, not specific to aarch64 and preexisting (sagemath/sage#33161).

Currently sage is failing for aarch64-linux and is not even present in darwin hydra. Going to merge this now since sage is always a difficult child and requires more attention to keep working.


Incremented version to 1.2.5

Incremented version to 1.2.5 in 1.2 following from https://github.com/opensearch-project/opensearch-build/issues/1600 to prepare for the next possible release.
Backport the change to higher version branches

Closing this issue as the parent issue is closed.


CFE_SB_MsgHdrSize returns size_t but still attempts to return CFE status code

Describe the bug
The CFE_SB_MsgHdrSize() function returns a size_t value.  Therefore, there is no provision/possibility for an error to be returned.
However, if passed a NULL argument, this still attempts to return CFE_SB_BAD_ARGUMENT which will be implicitly converted to a size_t value - which is platform-defined.  Notably, since size_t is unsigned, the result is always positive (success range) and will not be correctly interpreted by the caller.
To Reproduce
Call CFE_SB_MsgHdrSize() with a NULL MsgPtr argument.
Expected behavior
This function should probably return 0 instead of CFE_SB_BAD_ARGUMENT in this case.
Cannot return CFE status codes from a function that does not return CFE_Status_t (or int32).
Code snips
https://github.com/nasa/cFE/blob/2afdbc16e360530a9b4bbe4e0dcc814f675c1acb/modules/sb/fsw/src/cfe_sb_util.c#L54-L57
System observed on:
Ubuntu
Additional context
This line was also not being covered by the coverage test (#471) and the return type mismatch prevents this from being covered properly.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.

This also affects CFE_SB_GetUserDataLength()


Unable to load log servers with log-list.json

Hey 👋
We did the migration from 0.3.0 to 1.1.1 recently and we observed some non-fatal reports on Crashlytics since then. By digging into the issue, it looks like there is an internal library error happening quite randomly, only from time to time (like once every few minutes), without preventing the usage of our app overall (at least visibly for the user). Here is the stack trace:
2022-10-04 17:33:08.402 30118-30253/<package_name> I/CertificateTransparency: <domain_url> Failure: Unable to load log servers with log-list.json failed to load with java.lang.InterruptedException
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
        at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.hasValidSignedCertificateTimestamp(CertificateTransparencyBase.kt:112)
        at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.verifyCertificateTransparency(CertificateTransparencyBase.kt:96)
        at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyInterceptor.intercept(CertificateTransparencyInterceptor.kt:69)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        <...>
2022-10-04 17:33:08.402 30118-30253/<package_name> I/CertificateTransparency:     at java.lang.Thread.run(Thread.java:1012)
2022-10-04 17:33:08.404 30118-30253/<package_name> I/okhttp.OkHttpClient: <-- HTTP FAILED: javax.net.ssl.SSLPeerUnverifiedException: Certificate transparency failed

We didn't have this report at all with the previous 0.3.0 version, and this failure is happening really randomly, among successful "SCT trusted logs". Our domains have needed certificates and Certificate Transparency is working as expected, so, especially seeing the json file reading failure, it looks to be more internal to the library than due to a certificate failure itself.
Does it ring a bell to you? Thanks in advance for your help, and overall for your work on this CT library 🙏

Any updates here? I also got logs with this issue randomly

Nothing in particular comes to mind - InterruptedException kind of implies the the coroutine block has been cancelled in some way - could be timeout? I might need to add some more tests around timeouts etc to see if I can replicate more reliably.
The fix may be as simple as the code detecting this exception and suppressing (if appropriate)

One thing to look at is what you do in terms of caching the log list data (to disk for example) that could reduce the number of network hits

On reflection I think this is likely solved by #39 and given no other reports of a similar issue I'm going to close this one.

Thanks for your answers and your work on this library 🙏  I'll see with the latest release if this is something still being reported in production environment or not 🙂

The fix may be as simple as the code detecting this exception and suppressing (if appropriate)

Unfortunately in the case of the InterruptedException, the lib is throwing an SSLPeerUnverifiedException which is indistinguishable from a validation failure.  In our app, I implemented a kind of kludgy workaround to look at the VerificationResult from the last logger callback to determine whether we should suppress the error.  It would be great if there were an easier way to distinguish these cases.
I can still reproduce this issue on 2.1.2 by spamming a bunch of requests at once.

Have reopened for further investigation. @ikeed, this definitely sounds testable/reproducible by what you are saying then.

Thanks very much Matt! If you need any more info from me, just ask.

Incidentally, if the InterruptedException is too complex to fix, just embedding some kind of a "reason" field into the SSLPeerUnverifiedException would suit my needs.  I'm not sure if that's the direction you want to go.  We get a VerificationResult in the log callback and it would be useful to have something similar in the SSLPeerUnverifiedException itself so clients can make smarter decisions when an error is thrown.  Just to help distinguish between concurrency issues and an actual dodgy cert.

Hi @mattmook , we are facing the same issue. Getting this error :
Unable to load log servers with log-list.zip failed to load with kotlinx.coroutines.JobCancellationException
Here's the error :
E/CertificateTransparencyManager: Certificate transparency failed for host : y.x.com with result: Failure: Unable to load log servers with log-list.zip failed to load with kotlinx.coroutines.JobCancellationException: Parent job is Cancelling; job=BlockingCoroutine{Cancelled}@5bb23e7 Caused by: java.lang.InterruptedException at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:159) at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:3) at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.hasValidSignedCertificateTimestamp(CertificateTransparencyBase.kt:7) at com.appmattus.certificatetransparency.internal.verifier.CertificateTransparencyBase.verifyCertificateTransparency(CertificateTransparencyBase.kt:77) at
Could you suggest what can be done here ?


Swarm: Multiple instance and smart deploy

[ ] Do session affinity at LB

[ ] Try multi-instance

[ ] K8S Health Check

[ ] Smart Deploy

What about quick start of Spring Boot (w/o autowire checks)

What about quick start of Spring Boot (w/o autowire checks)

Partialy fixed by #319

Partialy fixed by #319


Add VTT and TXT formats to output converter

This commit adds the ability to convert the generated JSON output to VTT and TXT, retaining the ability to convert SRT. It now defaults to formatting as SRT for backwards compatibility.
Here's what the tool as currently written generates (with an admittedly simple output.json file).
SRT
1
00:00:00,000 --> 00:00:03,000
 And so my fellow Americans,

2
00:00:03,000 --> 00:00:08,000
 ask not what your country can do for you,

3
00:00:08,000 --> 00:00:11,000
 ask what you can do for your country.

VTT
WEBVTT

1
00:00:00.000 --> 00:00:03.000
 And so my fellow Americans,

2
00:00:03.000 --> 00:00:08.000
 ask not what your country can do for you,

3
00:00:08.000 --> 00:00:11.000
 ask what you can do for your country.

TXT
 And so my fellow Americans,
 ask not what your country can do for you,
 ask what you can do for your country.

@mjgiarlo maybe it would be better to explicitly specify the encoding as utf-8 when opening the JSON file, as utf-8 is a more universal encoding standard that can handle a wider range of characters given the default encoding for the open() function can vary depending on the system.
with open(input_path, 'r', encoding='utf-8')


App crash

App is crashing on clicking information related to products such as ingredients,nutrition,nutrition table

Not able to reproduce this bug. Works fine on my device.
Android 7.1.1

I believe this is a duplicate of #621

Hi @ManognaMutyala, PR #783 should have fixed it, can you update your repo and try to reproduce it? If it's already fixed please close this issue ticket. Thanks!

Thanks @ManognaMutyala!


Cannot find module '@vidstack/react/player/layouts/default'

Current Behavior:
After install vidstack@next via pnpm add @vidstack/react@next, and using default layout, but I got this error
Cannot find module '@vidstack/react/player/layouts/default' or its corresponding type declarations.ts(2307)

Expected Behavior:

Steps To Reproduce:

Environment:

Anything Else?

Strange, somehow the types were not included in last release but they were there. I re-released in 1.1.6 with them 👍 Let me know if the issue persists so I can reopen.

I still get same error after upgrade to v1.1.6

only work version is 1.1.1

Is this with Next.js?

I use vite + react router

I just tested it, found one small issue and fixed it. Try again in 1.1.7 please.

this error happen again in v1.1.10, go back to 1.1.9 fixed this

Ah god damn, sorry I need to add a script to check for this missing. Not sure how it randomly doesn't get built. Fixed in 1.1.11.


installing packages from git broken

Fresh install:
$ pipenv --version
pipenv, version 3.3.6

Simple Pipfile:
$ cat Pipfile
[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true

[packages]
crayons = { git="https://github.com/kennethreitz/crayons.git", ref="v0.1.2" }

Creates what seems to me a valid lock file:
$ cat Pipfile.lock
{
    "_meta": {
        "hash": {
            "sha256": "39b2447b7dd6976804de490321577a2db0f4fc4327e0795a93436ea69afad9a8"
        },
        "requires": {},
        "sources": [
            {
                "verify_ssl": true,
                "url": "https://pypi.python.org/simple"
            }
        ]
    },
    "default": {
        "crayons from<EMAIL_ADDRESS>{
            "hash": "sha256:a292b7ef29131345fd329ff5a94d1e2e59569be4dbd9fa8b99ff7114d72102a6",
            "version": "==0.1.2"
        },
        "colorama": {
            "hash": "sha256:a4c0f5bc358a62849653471e309dcc991223cf86abafbec17cd8f41327279e89",
            "version": "==0.3.7"
        }
    },
    "develop": {}
}

And now installing breaks:
$ pipenv install
No package provided, installing all dependencies.
Pipfile found at /[...]/Pipfile. Considering this to be the project home.
Installing dependencies from Pipfile.lock...
An error occured while installing!
Invalid requirement: 'crayons from<EMAIL_ADDRESS>It looks like a path. Does it exist ?

To activate this project's virtualenv, run the following:
 $ pipenv shell

These are the versions in my env:
$ pip freeze
appdirs==1.4.0
blindspin==2.0.0
click==6.7
click-completion==0.2.1
colorama==0.3.7
crayons==0.1.2
delegator.py==0.0.8
Jinja2==2.9.5
MarkupSafe==0.23
packaging==16.8
parse==1.6.6
pew==0.1.26
pexpect==4.2.1
pipenv==3.3.6
pipfile==0.0.1
ptyprocess==0.5.1
pyparsing==2.1.10
pythonz-bd==1.11.4
requests==2.13.0
requirements-parser==0.1.0
resumable-urlretrieve==0.1.4
six==1.10.0
toml==0.9.2
virtualenv==15.1.0
virtualenv-clone==0.2.6

Leaving out the ref attribute makes no difference.
Providing the editable flag leaves the package out of the lock file altogether:
$ cat Pipfile
[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true

[packages]
crayons = { git="https://github.com/kennethreitz/crayons.git", ref="v0.1.2", editable=1 }

produces:
$ cat Pipfile.lock
{
    "_meta": {
        "sources": [
            {
                "url": "https://pypi.python.org/simple",
                "verify_ssl": true
            }
        ],
        "requires": {},
        "hash": {
            "sha256": "fa6b6a1618451ef360028928588f70f6b3964f4dc8b0d371fb71a355b334abee"
        }
    },
    "develop": {},
    "default": {}
}

Thanks for opening this @evertlammerts, we realized last week that this was regressed in the 3.3.X releases of pipenv. I'm currently working on getting this functionality reintegrated, so bear with me while we get this tidied.
Since we hadn't gotten around to making a formal issue for this, we'll use this one to track this going forward.

Thanks for the update. What's the last known version to have worked? I've just tried 3.2.14 and that doesn't seem to either.
Let me know if you want some help on this, with a few pointers I may be able to come up with a fix?

Hrmm, so you've actually encountered a variant of what we noted in #198. I had to backtrack all the way to 0.2.8 to find a version that handles this as expected which is before I started working on the project. While this will generate the expected Pipfile.lock output, it doesn't seem that pipenv was able to install from those specs at the time.
That leads me to believe this specific case may have never worked. We need to make some changes in do_lock, get_downloads_info and ensure_proper_casing. I'd be open to reviewing a patch fixing this but will need tests ensuring the change doesn't break other functionality. This particular portion of the code is hard to test right now so I'm working on refactoring some of it. Which will then allow us to implement this functionality more cleanly.

i do believe that egg has always been a requirement.

Sorry, don't think I understand. Are you saying I can't install from Git?

@evertlammerts, you should be able to install from git, but the functionality is currently broken. The use of ref and editable hadn't been tested before, and I can't find a version of pipenv where it ever did work correctly. We are working towards getting this addressed in a future release.

Got it, thanks!

Hi, thanks for this great tools! i just want to report another error when installing a package using git:
$ pipenv --version
pipenv, version 3.4.1`

$ pipenv install git+https://github.com/django/django.git
Installing git+https://github.com/django/django.git...
Collecting git+https://github.com/django/django.git
  Cloning https://github.com/django/django.git to /private/var/folders/t_/cpyg93cx79zfjwgnp24fx7rw0000gn/T/pip-dfds2x7k-build
Requirement already satisfied: pytz in /Users/ayik/.virtualenvs/empu/lib/python3.6/site-packages/pytz-2016.10-py3.6.egg (from Django==2.0.dev20170214233504)
Installing collected packages: Django
  Found existing installation: Django 1.10.5
    Uninstalling Django-1.10.5:
      Successfully uninstalled Django-1.10.5
  Running setup.py install for Django: started
    Running setup.py install for Django: finished with status 'done'
Successfully installed Django-2.0.dev20170214233504

Adding git+https://github.com/django/django.git to Pipfile's [packages]...
Traceback (most recent call last):
  File "/Users/ayik/.local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/cli.py", line 771, in install
    project.add_package_to_pipfile(package_name, dev)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/project.py", line 173, in add_package_to_pipfile
    self.write_toml(p)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/project.py", line 127, in write_toml
    f.write(format_toml(toml.dumps(data)))
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/toml.py", line 602, in dumps
    addtoretval, addtosections = _dump_sections(sections[section], section)
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/site-packages/toml.py", line 619, in _dump_sections
    if not re.match(r'^[A-Za-z0-9_-]+$', section):
  File "/Users/ayik/.local/venvs/pipenv/lib/python3.6/re.py", line 172, in match
    return _compile(pattern, flags).match(string)
TypeError: expected string or bytes-like object

and... my Pipfile is now an empty file ! 😱

Hey @chenull, this is a separate but definitely important issue. Can you please open this in another ticket so we can track it appropriately.

submitted new issue in #225

I believe that is actually a dupe of https://github.com/kennethreitz/pipenv/issues/47

Thanks @zackkitzmiller, this issue (#204) is definitely separate from #47. #225 is tangential to #47 but has some other nuances (files being erased). I'm leaving both of these open for the moment because they aren't fully resolved.

@nateprewitt Sounds good. I'll just runoff then.

I'm going to fix this issue. Is there anyone else who's currently working on this issue?

I'm in the middle of working on this @simnalamburt. The problems for this are actually fairly systemic and I haven't fully synced up with Kenneth on finalizing some approaches.
The general overview is as follows:
We currently try to download every package name in the Pipfile from pip. This means a vcs dependency that exists in Pip gets overwritten. Separating that out requires a change in how we internally model the Pipfile without breaking our public interface for it.
We also need to have this similar approach for Pipfile.lock because when we go to install dependencies they are all required to have hashes in our current approach. I've rewritten this to do installs from two separate requirements files, one containing hashes for pip and the other installing from the vcs.
This is all mostly done but needs to be centralized into a clearer interface in projects.py which I haven't had a moment to sit down with for the last couple days due to everything else going on with this project and others.
If you'd like to peruse through the code and see if you have any further ideas, I'd be happy to read over them.

Oh I didn't know that it's that complicated issue. I just test it on my own and I found that it's not that simple. But glad to hear that it's all mostly done! I'll give you a hand if you need any help to resolve this issue. Thanks!

Definitions like this
[packages]
crayons = { git="https://github.com/kennethreitz/crayons.git", ref="v0.1.2" }

aren't valid in TOML.
Pipenv will install from git, if you define Git-dependency as TOML table:
[packages]
foo = "*"

[packages.crayons]
git = "https://github.com/kennethreitz/crayons.git"
ref = "v0.1.2"

@astynax, inline tables are very much so valid TOML.

Pipenv will install from git, if you define Git-dependency as TOML table

Are you suggesting that you're currently able to install from git with pipenv when using a table?

@nateprewitt Hmm... you are right about inline tables.
But pipenv install git+... still fails. And Pipfile with tables + pipenv install work for me.

But pipenv install git+... still fails.

Installing from git should still work fine in the form pipenv install git+https://github.com/django/dango.git#egg=Django. I believe this is noted farther up in the issue.
The problem we're discussing here is installing those dependencies again from the Pipfile/Pipfile.lock. There's a pretty detailed explanation of the current state of things two comments above your original.
The only reason that crayons works in this case is it's a dependency of pipenv itself and MUST be installed and you have chosen the same version number that pip will install by default. If you try another package that isn't hosted on PyPI such as the example below, you'll find your table syntax doesn't work.
[packages.coinbase]
git = "https://github.com/coinbase/coinbase-python"
version = "2.0.2"

@nateprewitt I mentioned the crayons in my comments just for example. I used toml-tables with pipenv install for another package (pylint) and installation was succeed.

This should be resolved with #242 and released in 3.5.0.


signature for get includes request

a trivial change to add request to the get signature.  it's nicer to override too...

Hi @minusf,
I don't see how this improves things for either Wagtail core development or people overriding this method - the override method can still use def get(self, request, *args, **kwargs) even if the base method doesn't - but happy to reconsider if you can provide more details.

Hi @minusf,
I don't see how this improves things for either Wagtail core development or people overriding this method - the override method can still use def get(self, request, *args, **kwargs) even if the base method doesn't - but happy to reconsider if you can provide more details.

no worries, i thought it was an oversight.
(i like consistency, and get uses request multiple times)

no worries, i thought it was an oversight.
(i like consistency, and get uses request multiple times)


Bug: Firefox asks for confirmation when leaving an exercise that is synchronized

Related issue(s) or PR(s):

#372

Bug description
Erik noticed:

Minor issue: when the tab is already synchronized, I think the confirmation dialog This page is asking you to confirm that you want to leave - data you have entered may not be saved. should not appear, while it appears unconditionally(?)

and Yann tried by several means to fix this without success. The documented way that should ensure confirmation deactivation is to delete the returnValue property of the HTML event... but Firefox ignores such deletion.

So, this issue will be resolved by #372 but just to keep some explanation/details for future reference:
The first implementation version in #372 was working with Chrome:

https://github.com/ocaml-sf/learn-ocaml/pull/372/commits/6b63b7d761b828f4f8409d57bfd54dc4d548558f
https://github.com/ocaml-sf/learn-ocaml/blob/6b63b7d761b828f4f8409d57bfd54dc4d548558f/src/utils/js_utils.ml

  let onbeforeunload ?(win = Dom_html.window) f =
    win##.onbeforeunload := Dom_html.handler (fun ev ->
                                let (status, propagate) = f ev in
                                if status then (
                                   Js.bool propagate
                                ) else
                                  (
                                    Js.(Unsafe.eval_string "undefined");
                                  )
                             )

But Dom.handler appears to be incompatible with "onbeforeunload" and Firefox.

Namely, the semantics of Dom.handler requires to "return true" to tell Dom.handler that we want to unload normally,
but with some browsers such as Firefox we should actually "return undefined" (better than "return null" BTW),
but then, "undefined" is seen as "false", implying Dom.handler will call "preventDefault",
end_of_the_story.

A sketch of an onbeforeunload-specific handler could be:
  (* Copy of private [Dom.window_event] *)
  let window_event' () : 'a #Dom.event Js.t = Js.Unsafe.pure_js_expr "event" in
  (* Fixed copy of [Dom.handler], working for onbeforeunload
     even for Firefox *)
  let handler_onbeforeunload :
        ((#Js_of_ocaml.Dom_html.event as 'b) Js_of_ocaml__.Js.t ->
         bool Js_of_ocaml__.Js.t) ->
        (* ('a, 'b Js_of_ocaml__.Js.t) Js_of_ocaml.Dom_html.event_listener = *)
        ('a, 'b Js_of_ocaml__.Js.t -> bool Js.t) Js.meth_callback Js.opt =
    fun f ->
  Js.some
    (Js.Unsafe.callback (fun e ->
         (* depending on the internet explorer version, e can be null or undefined. *)
         if not (Js.Opt.test (Js.some e))
         then (
           let e = window_event' () in
           let res = f e in
           if not (Js.to_bool res) then
             (e##.returnValue := res; res)
           else
             Js.Unsafe.pure_js_expr "undefined"
         ) else (
           let res = f e in
           if not (Js.to_bool res) then
             ((Js.Unsafe.coerce e)##preventDefault (* ; res *))
           else
             (Js.Unsafe.delete (Js.Unsafe.coerce e) "returnValue";
              Js.Unsafe.pure_js_expr "undefined")))) in
   *)

Anyway, the current hack is quite simpler:
  let prompt_before_unload () : unit =
    Js.Unsafe.js_expr "window.onbeforeunload = function(e) {e.preventDefault(); return false;}" in
  let resume_before_unload () : unit =
    Js.Unsafe.js_expr "window.onbeforeunload = null" in
  let () =
    Ace.register_sync_observer ace (fun sync ->
        if not sync then prompt_before_unload ()


SELinux: Validate platform aws in enforcing mode

Validate platform aws in enforcing mode
General
After all packaging and pipeline related stuff regarding SELinux got merged, we need to perform new platforms tests. This issue covers the integration tests with SELinux in enforcing mode for the platform type aws.
Do not start with this tests before these ones are done:

#1200
#1201
#1202

Task
Important: Before performing the platform tests make sure, that your SELinux is running in enforcing mode.

Run the platforms related tests on aws
Log and add all avc messages to this issue (or extend the gardenlinux-selinux-module by providing a PR)
Rerun the tests after adding the rules

Platform/Hyperscaler related rules have been added in PR: https://gitlab.com/gardenlinux/gardenlinux-package-gardenlinux-selinux-module/-/merge_requests/7

Just released version gardenlinux-selinux-module-1.0.5 for AWS hyperscaler (changelog).
This needs retesting with 1.0.5.

Validated on AWS:
SELinux status:                 enabled
SELinuxfs mount:                /sys/fs/selinux
SELinux root directory:         /etc/selinux
Loaded policy name:             default
Current mode:                   enforcing
Mode from config file:          enforcing
Policy MLS status:              enabled
Policy deny_unknown status:     allowed
Memory protection checking:     actual (secure)
Max kernel policy version:      33

Process contexts:
Current context:                unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
Init context:                   system_u:system_r:init_t:s0

File contexts:
Controlling terminal:           unconfined_u:object_r:user_devpts_t:s0
/etc/passwd                     system_u:object_r:etc_t:s0
/etc/shadow                     system_u:object_r:shadow_t:s0
/bin/bash                       system_u:object_r:shell_exec_t:s0
/bin/login                      system_u:object_r:login_exec_t:s0
/bin/sh                         system_u:object_r:bin_t:s0 -> system_u:object_r:shell_exec_t:s0
/sbin/agetty                    system_u:object_r:getty_exec_t:s0
/sbin/init                      system_u:object_r:bin_t:s0 -> system_u:object_r:init_exec_t:s0
/usr/sbin/sshd                  system_u:object_r:sshd_exec_t:s0

No further AVCs found. Pretty good...


Initialize HPWH objects from schema-based data model

Enables initialization of HPWH objects from IHPWH data-model specification in JSON format. The IHPWH data-model specification is defined by schema entries in repository hpwh-data-model. The schema are used by lattice to generate a code library for reading the JSON representations of the HPWH models. The code-generation step could be initiated by cmake when building the project (rather than being retaining the code in HPWHsim, but this has not been implemented, due to a relatively small number of manual changes that remain necessary in the generated code.
The command-line utility convert was added to the hpwh executable. This was used to convert all existing IHPWH models from preset entries to JSON files. These models were exported to the folder "models_json " in the "test" folder.  Many of these models were previously implemented using polynomial expansions at specific environment temperatures of the variation of input power and cop with heat-source temperature (determined by the condensity-weighted tank temperature.) These were converted by sampling into performance grids for evaluation using btwxt. Criteria were developed for the number of grid points, based on the curvatures of the input-power and cop functions, to ensure sufficient resolution of the grid representations for the reproduction of reference test results.
The assigned JSON file names correspond to their predefined model names. However, 'cse' primarily specifies HPWH presets by HPWH::MODELS number, whereas HPWHsim uses only specification by model name, not number, for testing. Furthermore, roughly eight models did not have assigned names, and were inaccessible via command line. To export these models to JSON, the convert utility also allows specification by either model name or number.  Obvious names were also defined in the code for these models. However, no mechanism exists currently to initiate a model from a JSON representation via model number.
Tests were added for comparison of the JSON and Preset (and File) representations.

Codecov Report
Attention: Patch coverage is 49.84747% with 822 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@cab482a). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

src/HPWHUtils.cc
26.62%
317 Missing :warning:

src/HPWHHeatSource.cc
44.21%
188 Missing :warning:

src/HPWHpresets.cc
55.21%
116 Missing :warning:

src/HPWHHeatingLogic.cc
56.28%
101 Missing :warning:

src/HPWHTank.cc
75.41%
89 Missing :warning:

src/HPWHHeatingLogic.hh
0.00%
6 Missing :warning:

src/HPWHTank.hh
54.55%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #211   +/-   ##
==========================================
  Coverage           ?   62.63%
==========================================
  Files              ?       11
  Lines              ?     6203
  Branches           ?        0
==========================================
  Hits               ?     3885
  Misses             ?     2318
  Partials           ?        0

Flag
Coverage Δ

integration
62.63% <49.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@spahrenk make new PR merging use-data-models into main.


Update 'stable' branch

The docs use the stable branch, and it doesn't include certain features, which the latest version already provides (in my case the 'environment' plugin).

Thank you for bringing this up, Felix. I have pushed all the commits from master up until f5994a9 (April 11, 2018), which should coincide with the v1.0.6 release, to the stable branch.


Get loop working in the bytecode compiler and fixed a function call bug.

Filling in br target computation
Fixed bug where formal parameters were being zeroed with
other locals

Hi @commonlisp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Locked the conversation and deleted 1 comment with personal information


Optionally Disable Running Tests

The rake tasks make it very easy to spin up some infrastructure. Sometimes, I just want to use them to just spin up that infrastructure, and I don't want to wait for the tests to run or anything. I just want to spin up the test. This will allow me to do that easily.

@gmmeyer xouls you please add this to the template in the datadog-sdk-testing gem as well?

Yes I can


Support Web Push + PWA, for background notifications

I am not sure what running as progressive web app requires, but I understand they should be able to support receiving notifications in the background even without the tab/app open as long as browser is running.
I think currently at least webapp manifest is missing.

https://developer.mozilla.org/docs/Web/Manifest
https://developer.mozilla.org/docs/Web/Progressive_web_apps
https://caniuse.com/web-app-manifest (add to homescreen)

Somewhat unrelatedly, iOS is also receiving support for web push sometime next year, https://webventures.rejh.nl/blog/2022/06/25/the-biggest-thing-from-wwdc22/
Update 2023-04-02: iOS 16.4 supports web push when the PWA has been added to the homescreen.

I've thought about trying to make this work. I think it might solve #199, too

Just thought i would leave my 2 cents
You can create a shortcut with chrome and have it opened as a separate window

This will give it a sorta PWA like feel, although it is still a chrome instance just running in a separate window

The browser asks me if I want to receive notifications, it works in the foreground but after closing the page it does not work anymore. Service workers need to be implemented.

Made progress in making the react web app fulfill install-ability requirements on the pwa-background-push branch of my forked repo.
No custom service workers are hooked up yet, nor have I managed to successfully install the PWA version so far.
Next steps...

Request permission,
Generate notification,
Push.

Made progress in making the react web app fulfill install-ability requirements on the pwa-background-push branch of my forked repo.
No custom service workers are hooked up yet, nor have I managed to successfully install the PWA version so far.
Next steps...

Request permission,
Generate notification,
Push.

Nice work !!

Made progress in making the react web app fulfill install-ability requirements on the pwa-background-push branch of my forked repo.

Where are you planning to store the subscriptions from the client? Those have to be somewhere on the backend side :thinking:

I've hit a blocker with this endeavor.
I've made the web app install-able, and added appropriate views / preferences for enabling background notifications, but am lost when it comes to actually delivering notifications from the service worker itself, or how to go about listening for events that trigger a notification.
None of the classes in the app/ directory can be imported into the service worker. Additionally, all of the examples I have seen online for enabling push notifications to be delivered from the service worker seem to leverage PushManager / web push protocol. I do not know how to configure / incorporate this server logic into the existing web app code; plus, all the class instances in app/ will cease to run once the PWA is closed.

So I know nothing about PWA, but I looked at web push and the service worker stuff for a while (not sure if that's the same thing), and the more I looked, the more confused I got.
It's been a while, so my memory is fuzzy, but luckily I can ping some experts, that can hopefully shed some light :-D
Pretty please, @p1gp1g @karmanyaahm (sorry for pinging you on two tickets :-))

It's been a while, so my memory is fuzzy, but luckily I can ping some experts, that can hopefully shed some light :-D

(background: i've done this before and switched from my own webpush-spaghetty-app to ntfy, it is an awesome tool btw 😉 )
For webpush to work you need to generate a keypair, the public key is for the frontend and the private key is backend-only.
You also need to save the subscriptions from the frontend in the backend (somewhere in a database usually)
A subscription can be obtained by the pushManager in the browser.
This is a rough overview how a subscription is obtained on the frontend/browser side:
if (navigator.serviceWorker){
	// service-worker registration (snippet below)
	navigator.serviceWorker.register('service-worker.js');

	// ready event
	navigator.serviceWorker.ready
	.then(function(registration){
		return registration.pushManager.getSubscription()
		.then(function(subscription){
			if (subscription)
				// already subscribed
				return subscription;

			// new subscription
			// public key from the backend
			return fetch("api/push/pubkey")
			.then(function(res){ return res.text(); })
			.then(function(vapidPublicKey){
				return registration.pushManager.subscribe({
					userVisibleOnly: true,
					applicationServerKey: vapidPublicKey
				});
			});
		});
	})
	.then(function(subscription){
		// TODO: store subscription object in the backend for later notification
	});

} else {
	//no push
}

A subscription looks like this:
{
 "endpoint": "https://browser-dependent-url.com/xy",
 "keys": {
    "auth": "abcde--",
    "p256dh": "efgh=="
}

For the sending part in the backend you should really use a library, i can suggest this: https://www.npmjs.com/package/web-push
Sent notifications arrive in the service-worker.js and get dispatched to the user here:
self.addEventListener('push', function(event){
	var payload = event.data ? event.data.text() : null;
	if (!payload)
		return;

	var data = JSON.parse(payload);
	event.waitUntil(
		self.registration.showNotification(data.label, {
			body: data.text
		})
	);
});

Side-note: pwa != webpush, both can be developed undependently

Made progress in making the react web app fulfill install-ability requirements on the pwa-background-push branch of my forked repo.

Where are you planning to store the subscriptions from the client? Those have to be somewhere on the backend side 🤔

I would suggest nats.
you can embed nats or run it as a separate service.
Nats is 100% golang.

hopefully shed some light

PWAs and WebPush are related but separate. One does not require the other.
I agree with @BuckarooBanzay's comment. The frontend is simple, an extra JS file that handles push, notifies, and stores it into the indexed DB.
The backend could get complicated, however. First, you need a way to register. Perhaps POST ntfy.sh/mytopic,topic2/push with the subscription:
{"endpoint": "https://browser-dependent-url.com/xy", "keys": {"auth": "abcde==","p256dh": "efgh=="}}

Then, ntfy needs to store mytopic:subscription, topic2:subscription in the database.
Just like there's a sendToFirebase function, there will have to be a sendToPush function. On every message, sendToPush will look up the subscriptions associated with that topic, and then run the WebPush library on each of those.
The library encrypts the payload and POSTs it to the endpoint.
Details:

I'd recommend allowing ignoring encryption when keys is null (POST raw notification to the server).
The ntfy server will have to generate VAPID keys. It can be saved to the DB on the first run. (https://pkg.go.dev/github.com/AbdullahDiaa/govapid#GenerateVAPID).
There needs to be a config option for the email of the server host or something similar (for VAPID).
Make sure the endpoint cannot point to the ntfy server itself, preventing loops.

Any plans for when this will be released?

@gedw99 @pinpox You can help test it. It's deployed on https://staging.ntfy.sh -- Docs are here: https://docs.ntfy.sh/subscribe/pwa/
We found some small issues, but nothing major. It's almost ready for prime time.

specifically here: https://staging.ntfy.sh/app :D
and the self-hosting config docs are here: https://docs.ntfy.sh/config/#web-push

:loudspeaker:  Request for testing:
The next ntfy server release will contain a progressive web app (PWA) with Web Push support, which means you'll be able to install the ntfy web app on your desktop or phone similar to a native app (even iOS! :partying_face:), and get basic push notification support (without any battery drain).
Installing the PWA gives ntfy web its own launcher (e.g. shortcut on Windows, app on macOS, launcher shortcut on Linux, home screen icon on iOS, and launcher icon on Android), a standalone window, push notifications, and an app badge with the unread notification count.
The (hopefully) production ready version of the PWA is currently deployed on https://staging.ntfy.sh/app -- Install instructions with screenshots can be found in the docs (https://docs.ntfy.sh/subscribe/pwa/).
Please report bugs or issues on Discord/Matrix/Lemmy. PLEASE HELP TEST
Huuuuge thanks goes to @nimbleghost for developing this entire feature top to bottom. If you throw donations my way, I'll share them with him. He certainly deserves it for all this great work. :clap:


[Storage] [STG 95] Bump azure-core minimum dependency for autorest code generation

🚢

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob


Nifty model doesnt give same accuracy

When I run experiment.ipynb the model does not yield the same accuracy as given when the code is first checked
Before:

After:

Could you please help me and explain why this is happening @pranjal-joshi ?
Also, how is the 128 rights and wrongs in the first one when the test size is only 40 days? Also is there way to further backtest the model for more than 40 days (like 100 days)?

Hi it seems that the accuracy given is misleading as maybe you forgot restart the kernel before running the code, so the correct prediction value increased exponentially.

The ML model training has 3 sub datasets

Training
Testing
Validation

The 100 days results you are watching must be the validation that was neither used for training, nor for testing.
Disclaimer: The training results are experimental and I don't claim whether the accuracy is high enough to take your trading decisions based on it.

Could you say what the test and validation accuracy was for the current model v2?

No comments on absolute accuracy
Please refer to the notebook shared.
This is the only experiment with ML so far.

Please can you tell me where in the notebook I can find the accuracy?
I understand it is only for educational purposes

@dopevog
The following notebook will walk you through data preprocessing, feature engineering, training, validation and testing.
https://github.com/pranjal-joshi/Screeni-py/blob/main/src/ml/experiment.ipynb

@pranjal-joshi could you tell me which cell blocks corespond to which part of the code please? Am facing difficulties trying to find it.

@pranjal-joshi also, is this the same code that was used to make v2 model or was it diffirent?

@pranjal-joshi please respond

@pranjal-joshi also, is this the same code that was used to make v2 model or was it diffirent?

The same notebook is updated and used for v2 model

@pranjal-joshi could you tell me which cell blocks corespond to which part of the code please? Am facing difficulties trying to find it.

The Jupyter notebooks are self explanatory 😅
I hope you have sufficient python/ML background to get started with this.
If you have specific query, you can refer the piece of code from notebook and then we can discuss.

I am actually pretty new to ML sorry @pranjal-joshi


Add a Php wrapper for is_callable

The fact that calling callbacks by is_callable could be hazardous was new to me https://github.com/yiisoft/yii/issues/3492 http://www.yiiframework.com/news/78/yii-1-1-15-is-released-security-fix/
Therefor in the past it was chosen to change all classes with checking against instanceof Closure, which goes at cost of flexibility (see https://github.com/yiisoft/yii2/pull/12614).
This makes it impossible to override Yiis core classes with callback arrays or to pass these as configuration. This is a pity, because flexibity is reduced while there are alternatives for is_callable($mixed,true) which still enable the use of callback array.
Another thing about this is consistency. Frameworkwide there isnt any. Sometimes, there is only checked on null (see https://github.com/yiisoft/yii2/blob/master/framework/grid/GridView.php#L466), and sometimes on Closure (see https://github.com/yiisoft/yii2/blob/master/framework/grid/GridView.php#L466)
I dont like the inconsistency as you can see at https://github.com/yiisoft/yii2/pull/12614/commits ;) but I was also surprised that arrays were not supported because of https://github.com/yiisoft/yii/issues/3492.
To have best of all worlds including safety, I would suggest 1 way of dealing with this, preferably by using a method in newly to create 'PhpHelper'.

namespace yii\helpers;

class PhpHelper
{

    /**
     * Returns a boolean indicating if a callable may be called
     * @see https://github.com/yiisoft/yii/issues/3492
     * @param Closure|array
     * @return bool
     */
    public static function mayCall($callable)
    {
        if($mixed === null){
            return false;
        }

        if ($mixed instanceof \Closure || (is_array($mixed) && is_callable($mixed))){
            return true;
        }

        return false;
    }
}

I would rather see helper for converting callable to closures, like https://wiki.php.net/rfc/closurefromcallable

@rob006 that's separate issue: https://github.com/yiisoft/yii2/issues/8797#issuecomment-112083165

I was thinking about something simpler: https://gist.github.com/rintaun/2773168#gistcomment-1876685


Is it possible to update the mime_types dependency?

I am unable to update github_api past 0.13.0 due to its dependency on mime_types < 3.0 - is there any chance that this restriction could be relaxed? I have several necessary gems (most notable is the google-api-ruby-client) that require more recent releases of mime_types

Hi Charles,
I think this is a good time to upgrade the gem to minimum Ruby v2.0 and hence bump the mime_types requirement. I should have some time to release tomorrow.

Release v0.18.0 without mime-types dependency. Enjoy!


Relax textual pin

+ pip check
toolong 1.2.0 has requirement textual<0.51.0,>=0.50.0, but you have textual 0.51.0.

I'm not sure if you were intending to exclude textual>=0.51? Assuming that's not the case I've loosened the pin here. If <1 is too loose, feel free to push any changes you want to this PR...

The pinning was intentional. Since its an app there isn't the need to share dependancies with other libs. If you install with pipx then you can avoid any conflicts...


What kind of authentication method should be used?

We have to choose a method to verify that a user can access specific resources.
My suggestion is to use JWT with OpenID and OAuth2.0. It is more work, but should fit our needs the best.

I will close which means JWT will be chosen.


Files with spaces or special characters

Hi,
Thanks for fzf.fish, it works great, though on file completion escaping backshlashes are not added which leads to no working commands
eg. cp machin\ truc\ bidule ~ becomes cp machin truc bidule ~
Thanks

very odd I am not able to reproduce the bug. Can you follow the issue reporting template so I have more info to repro it?
https://github.com/PatrickF1/fzf.fish/issues/new?assignees=&labels=&template=bug_report.md&title=

Hi @raphael-small , one possibility is that you are using a different plugin. fzf.fish often gets confused with the fish integration installed by fzf.
Closing this for now. Feel free to re-comment if you still have problems. https://github.com/junegunn/fzf/blob/master/shell/key-bindings.fish

Hi,
thanks for your reply, it's totally possible, I'll investigate
have a nice day

It was indeed the fzf integration that had problems
Sorry for the noise


Remove executable flag from test data files

The *-words.txt test data files were marked as executable files. Since
that is not needed, this commit removes the executable flag from each of
them.
Note that I am packaging this package for the Fedora distribution and those
files must be marked as non-executable in the RPM package.

Thanks!
(The AppVeyor build failure is unrelated this.)


shx for cross platform compatible shell commands

Fixes builds in non-Unix environments (i.e. Windows does not have the cp builtin).

Pull Request Test Coverage Report for Build 170784

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 83.613%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-streaming/src/webSocket/webSocketTransport.ts
2
81.55%

libraries/botframework-streaming/src/webSocket/webSocketServer.ts
7
66.67%

Totals

Change from base Build 170657:
-0.06%

Covered Lines:
15625

Relevant Lines:
17784

💛  - Coveralls


Crash on gauche commit

https://github.com/shirok/Gauche/commit/2eeca102b33a4ab7450d6fb5508642431fc46dc1
thread 'main' panicked at 'index out of bounds: the len is 49 but the index is 49', src/display/side_by_side.rs:505:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal: external diff died, stopping at examples/spigot/README.adoc

Merging into #688.


Fix an interactor bug with momentum.

Using the default map interactor options, if you right click or right drag on the map, mousemove event cease getting generated.  The action state was marked as zoom or momentum after the mouse up (since it was performing that action), and this is never cleared as clearing is done on mouse up.  This blocked generating mousemove events.
Also, tweak one of the polygon tests to try to eliminate occasional test failures.

Current coverage is 80.73% (diff: 100%)

Merging #604 into master will increase coverage by 0.01%

@@             master       #604   diff @@
==========================================
  Files            82         82
  Lines          7419       7424     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5989       5994     +5
  Misses         1430       1430
  Partials          0          0

Powered by Codecov. Last update daf9c26...7455bd7

To see the problem, load the tile example page from http://opengeoscience.github.io/geojs/examples/tiles/, open a javascript console and type tileDebug.map.geoOn('geo_mousemove', function (evt) { console.log(evt.map.x, evt.map.y); }). Now when you move the mouse, you'll see screen coordinates in the console.  Focus the map window, then right click. The screen coordinates will stop updating until you left click.

LGTM  (but didn't run it yet) :+1:


Add delete_role function

Howdy @djlarsu!
Looks like the test change that was added here ended up repurposing an existing test instead of adding a new one. We also have a similar PR open previously under https://github.com/ianunruh/hvac/pull/112 that should accomplish the same ends. So I'm going to go ahead and close out this PR, but if https://github.com/ianunruh/hvac/pull/112 doesn't cover exactly what you were after, feel free to reopen this PR or create a new issue with additional notes.


[WIP] Add ParserTestDriver

Currently, fluentd does not have ParserTestDriver.
This PR adds this test driver.
Remaining tasks

[ ] Frozen ParserTestDriver API

[x] Decide whether to include utility methods such as str2time or not.

[x] Replace a few parser test cases with ParserTestDriver
[ ] Documentations?

Could you replace one actual parser test using this driver?

I try to replace TimeParser and SyslogParse test cases with ParserTestDriver.

I've found that parser test driver in this commit https://github.com/cosmo0920/fluentd/commit/d5d0846e8af444cbddbb3e3a03e6df19b7875ef0 does not handle to instantiate RegexParser.
How do we abstract this parser with this test driver?

I want to write parser test like following:
def test_multiline
  conf = %[
  <grok>
    pattern %{DATA:message1}\n
  </grok>
  <grok>
    pattern %{DATA:message2}\n
  </grok>
  ]
  text = <<TEXT
host1 message1
  message2
TEXT
  d = Fluent::Parser::TestDriver.new(Fluent::TextParser::MultilineGrokParser).configure(conf)
  d.parse(text) do |time, record|
     assert_equal(expected, record)
  end
end

This is same as other test drivers.

TimeParser itself is not a Parser plugin so I think supporting TimeParser API is not needed.

Rebased. I removed a commit which replaces TimeParse test cases with ParserTestDriver.

@okkez How about this? If you ok, I will merge this patch.

How to use nested config_section and cnofig_param?
How about this?
But this is no tested.
def configure(conf)
  case conf
  when Fluent::Config::Element
    @config = conf
  when String
    io = StringIO.new(conf)
    @config = Cofig::Parser.parse(io, 'fluent.conf')
  when Hash
    @config = Config::Element.new('ROOT', '', conf, [])
  else
    raise "Unknown type... #{conf}"
  end
  @instance.configure(@config)
  self
end

As a result of @okkez and I discussion, I added commits to drop TimeParser support in this test driver, fix usage of Class.new, and string literal support in #configure.
Could you review this PR again?

If there are no concerns from other developers, I will merge it.

Looks good to me :+1:


[WFLY-8109] Improve timeouts in AS TS

Improve timeouts in AS TS

JMSMessageDrivenBeanTestCase should use TimeoutUtil for timeout
increase timeout in PassivationTestCase
JspCompilerTestCase should use TimeoutUtil for timeout
increase timeout in MDBTestCase
increase the default forked process timeout for basic module to hour, same timeout is used in clustering module, see https://github.com/wildfly/wildfly/blob/master/testsuite/integration/clustering/pom.xml#L24

This stabilizes TS on slower machines.
Downstream issue and PR will follow.

@bstansberry Thank you for your review.
I fixed JMSMessageDrivenBeanTestCase as requested.
I also remove usage of TimeoutUtil from TxTestUtil, because this causes fail of MessageDrivenTimeoutTestCase if -Dts.timeout.factor=200 is used. More information is in description of https://issues.jboss.org/browse/WFLY-8109
Can you please review this again?

@marekkopecky This looks good, but will need a JBEAP equivalent before it can be merged for WF 11.

@bstansberry Sure,
JBEAP jira: https://issues.jboss.org/browse/JBEAP-8966
JBEAP PR: https://github.com/jbossas/jboss-eap7/pull/1373


Add ckeditor

Based on https://github.com/kont-noor/WebLog/pull/4 Add bootstrap

Will close it because we changed the engine structure


Failed to build bundle due to errors on a clean React Native project

Environment
MacBook Pro 16 2019
npx -v = 7.5.3
XCode = 12.4
cocoapods = 1.10.1
Simulator = iPhone 12 Pro
Description
I set up a react native project by using the npx react-native init AwesomeProject command, and after following the https://github.com/callstack/repack Installation & Setup section guide when I run the npx react-native webpack-start and when the application is started and connected to the server, bundling fails with the following error:
ℹ [12:25:10.889Z][DevServerProxy] Server listening at http://[::]:8081
ℹ [12:27:31.506Z][DevServerProxy] Starting compiler worker { platform: 'ios', port: 49682 }
ℹ [12:27:31.568Z][DevServerProxy] Hermes device connected { deviceId: 0 }
ℹ [12:27:32.748Z][DevServer@ios] Server listening at http://<IP_ADDRESS>:49682
ℹ [12:27:32.786Z][webpack-dev-middleware] wait until bundle finished: /index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.AwesomeProject
✖ [12:27:49.611Z][LoggerPlugin] Failed to build bundle due to errors
✖ [12:27:49.611Z][LoggerPlugin] Error in "./node_modules/react-native/Libraries/Utilities/HMRClient.js": Module not found: Error: Can't resolve './getDevServerLocation' in '/Users/duskomirkovic/Documents/Projects/AwesomeProject/node_modules/react-native/Libraries/Utilities'
⠦ Running: (ios)  100%
Reproducible Demo

Ran npx react-native init AwesomeProject
Ran cd AwesomeProject
Ran yarn add -D webpack terser-webpack-plugin babel-loader @callstack/repack
Created react-native.config.js with content specified here: https://github.com/callstack/repack
Created webpack.config.js with content from here: https://github.com/callstack/repack/blob/main/templates/webpack.config.js
Configured XCode build phase Bundle React Native code and images to match the one provided in the Installaton & Setup section here: https://github.com/callstack/repack
Ran cd ios
Ran pod install
Ran cd ..
Ran npx react-native webpack-start
Ran npx react-native run-ios

This is caused by braking change in Webpack 5.49.0 tracked here: #63
For now, please downgrade Webpack to 5.48.0.

This problem was addressed in<EMAIL_ADDRESS>- please update to this version.


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
Fixed URLs
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

[ ] http://spark.apache.org/ with 1 occurrences migrated to:
https://spark.apache.org/ (https result 200).

Closing this PR as this project is no longer actively developed.


Doc Comments

Most of the libraries functions are not annotated using doc comments. It would be really helpful for development in many cases. I have started to annotate some, but its somewhat difficult because of my lacking experience with the library.

I have opened a pull request: #57

Hey, thanks for helping out with the documentations, it is always appreciated.
I'm doing my best to documenting the most important things in README here and examples for now (maybe I'll expand it to a book later).
However there are always room for new docs including doc annotations.
Please let me know in the PR or in the comment If you see some function that caused some struggling for you - it is actually great to have additional eyes to have a look at this, if we have some confusing name or places to document it (or even rename it) where possible.
Saying that please avoid documenting internal APIs (including the 'Classic API'), since it probably will be changed (or even hidden to users) with in next releases. The current idea is to rely in the apps on the Fluent API and models that it uses and hide complexity.

I have only been using the fluent api, so I had no intention to document the classic api

One thing I'm bit confused about @abdolence is whether you are supposed to have a single global FirestoreDb instance in your program or create a different one for each request.

@thurn a good point.
Hope this answers your question:
https://github.com/abdolence/firestore-rs#firestore-database-client-instance-lifecycle
Let me know if I can describe it more.


CI stage "npm run cypress:e2e:server" fails

🐞 Bug report
Description
In the GitHub Actions CI pipeline, the Cypress E2E Test fails because of missing browser:
🔬 Minimal Reproduction
See example at https://github.com/scullyio/scully/pull/575/checks?check_run_id=701664156
🔥 Exception or Error

Can't run because you've entered an invalid browser name.

Browser: 'chrome' was not found on your system.

Available browsers found are: firefox, electron

@evolkmann No clue what happened, I'll restart the tests. Will keep an eye on it.

That fixed it. Some fluke in GA. Closing for now, will keep an eye on this. if it happens a lot, we need to take some extra care there