pathway_errorbar "Error in guide_train.prism_offset_minor" when ggprism loaded

Hi again, different issue this time!
Because the KEGG database annotation was taking so long for me, I decided to run through the workflow for the EC annotation. Much faster! But I am still running into some new errors at the pathway_errorbar() stage. Below is my code, and data so you can hopefully reproduce the issue.
But first, my environment is as follows:
package loadedversion
ape               ape         5.7-1
dplyr           dplyr         1.1.2
forcats       forcats         1.0.0
genefilter genefilter        1.80.3
ggpicrust2 ggpicrust2         1.6.2
ggplot2       ggplot2         3.4.2
ggprism       ggprism         1.0.4
ggpubr         ggpubr         0.6.0
HTSSIP         HTSSIP         1.4.1
lattice       lattice        0.21-8
lubridate   lubridate         1.9.2
patchwork   patchwork         1.1.2
permute       permute         0.9-7
phyloseq     phyloseq        1.42.0
purrr           purrr         1.0.1
readr           readr         2.1.4
stringr       stringr         1.5.0
tibble         tibble         3.2.1
tidyr           tidyr         1.3.0
tidyverse   tidyverse         2.0.0
vegan           vegan         2.6-4
Now my code:
library(phyloseq)
library(ggplot2)
library(ape)
library(vegan)
library(ggpubr)
library(tidyverse)
library(genefilter)
library(HTSSIP)
library(ggprism)
library(patchwork)
library(ggpicrust2)

metadata <- read_table("../Input files/ADWMBAT Combined Metadata.txt")

metadata <- metadata %>%
  filter(sex == "F" & all_data == "Y") %>%
  select(!X8) %>%
  mutate(genotype = as.factor(genotype))
# read in sample meta data as a tibble, and set genotype as a factor

ko_abundance <-
  read.delim(
    "../Data/For PICRUSt/picrust2_out_pipeline/EC_metagenome_out/pred_metagenome_unstrat.tsv"
  )
# load the EC count data in

rownames(ko_abundance) <- ko_abundance$function.
ko_abundance <- ko_abundance[, -1]
# remove the first column of function names by setting them as the row names. This is done because it's the format the next step, pathway_daa(), expects to see.

ko_abundance <- ko_abundance %>%
  rename('24' = X24,
         '26' = X26)
# rename some column names to match metadata file

daa_results_df <-
  pathway_daa(
    abundance = ko_abundance,
    metadata = metadata,
    group = "genotype",
    daa_method = "LinDA",
    select = NULL,
    reference = "WT",
    p.adjust = "none"
  )
# run the differential abundance calcualtion step using LinDA and no p-value adjustment

daa_annotated_sub_method_results_df <-
  pathway_annotation(pathway = "EC",
                     daa_results_df = daa_results_df,
                     ko_to_kegg = FALSE)

# select top 15 differentially expressed features
# this done because there were too many "significant" without using FDR correction
daa_annotated_sub_method_results_df_filtered <- daa_annotated_sub_method_results_df %>%
  arrange(p_adjust) %>%
  slice_head(n = 15)

ko_abundance_plot <- ko_abundance %>%
  filter(rownames(ko_abundance) %in% daa_annotated_sub_method_results_df_filtered$feature)
# above was attempted to see if the ko_abundance object needed to be the same dimensions as the daa_results. didn't help.

daa_results_list <-
  pathway_errorbar(
    abundance = ko_abundance,
    daa_results_df = daa_annotated_sub_method_results_df_filtered,
    Group = "genotype",
    p_values_threshold = 0.05,
    order = "group",
    select = NULL,
    ko_to_kegg = FALSE,
    p_value_bar = TRUE,
    colors = NULL,
    x_lab = "description"
  )

print(daa_results_list)

For me executing all this code produces this error:
"Error in guide_train.prism_offset_minor(guide, panel_params[[aesthetic]]) :
No minor breaks exist, guide_prism_offset_minor needs minor breaks to work
In addition: Warning messages:
1: Removed 15 rows containing missing values (geom_bar()).
2: Removed 15 rows containing missing values (geom_stripped_cols()). "
Trying to view() the daa_results_list object issues the following error:
"Error: Index out of bounds"
Here are my files:
pred_metagenome_unstrat.tsv.gz
ADWMBAT Combined Metadata.txt
Thanks for any help you can provide!

Quick note that I added the following code above pathway_errorbar() just in case the group had the be hard coded as an object:
Group <- metadata$genotype

pathway_errorbar(
    abundance = ko_abundance,
    daa_results_df = daa_annotated_sub_method_results_df_filtered,
    Group = Group,
    p_values_threshold = 0.05,
    order = "group",
    select = NULL,
    ko_to_kegg = FALSE,
    p_value_bar = TRUE,
    colors = NULL,
    x_lab = "description"
  )

And now I get the following error:
"Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y,  :
polygon edge not found"
Progress?

Possibly found the issue, though I'll leave this open until you have a chance to verify.
I think it was related to me not having some required fonts installed. I followed the steps suggested on this stackoverflow thread:
https://stackoverflow.com/questions/71362738/r-error-in-grid-callc-textbounds-as-graphicsannotxlabel-xx-xy-polygo
And now I can generate the barplots!

Hello,
Thank you for reaching out and sharing your findings regarding the issue you encountered with our package. As the developer, I appreciate your effort in troubleshooting and finding a possible solution.
I will make sure to add this information to our package's Q&A repository, so that other users who might run into similar issues in the future can find a solution more easily. Thank you for bringing this to our attention.
Once again, if you have any further questions or concerns, please don't hesitate to reach out. We are always looking for ways to improve our package and provide a better user experience.
Best regards,
Chen YANG


How to extract page number from JSON?

How can I extract the ad page numbers from JSON?
Preferably all of them in a single list object.
I'm not super familiar with JSON stuff at all.
Thanks

Just created a new PR #76 for supporting retrieval of the current ad page number

@ArthurG this can be closed now that the PR has been merged.


how to train? is there any code for training instantID?

want to re-train this InstantID, but I can't find the ready-made code. is there any code for training instantID ?

insert one eye~~
need the training code as well~~
thank you a lot~~~

same question

any update？

fyi - @fswienty  - this recent code / paper retrained resnet - https://github.com/ICTMCG/CSCS - (from the single photo i tested) it works quite well if you do the preprocess alignment step. I'd put it up there with insightface.

i have modify and train base on dinov2, here is the code u can reference: https://github.com/pljj315/instant_id.git


Rate limit exceeded - Twitter component

Hi guys,
I currently get the message "Rate limit exceeded" from Twitter.
Now, the problem for me was that there was a slight misconfiguration, so we need to fix some stuff.
Other than that, I believe we can do a lot more to overcome these issues:
20.04.2016 12:52:15.499 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/es_ES/about/jcr:content/par/boxlong_0/par/twocolumn_colspan22/parsecond/twitter_feed. 20.04.2016 12:52:15.925 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/en_US/home/jcr:content/par/boxlong/par/twocolumn_colspan22/parsecond/twitter_feed. 20.04.2016 12:52:16.254 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/en_US/jcr:content/par/boxlong/par/twocolumn_colspan22/parsecond/twitter_feed. 20.04.2016 12:52:16.424 *INFO* [pool-5-thread-4] org.apache.jackrabbit.core.persistence.bundle.AbstractBundlePersistenceManager cachename=crx.defaultBundleCache[ConcurrentCache@1c533d67], elements=2801, usedmemorykb=8179, maxmemorykb=8192, access=186309, miss=76523 20.04.2016 12:52:16.587 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/es_ES/news/jcr:content/par/onecolumn/parfirst/twitter_feed. 20.04.2016 12:52:16.913 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/en_US/about/jcr:content/par/boxlong_0/par/twocolumn_colspan22/parsecond/twitter_feed. 20.04.2016 12:52:17.249 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/es_ES/jcr:content/par/boxlong/par/twocolumn_colspan22/parsecond/twitter_feed. 20.04.2016 12:52:17.577 *INFO* [pool-5-thread-4] com.adobe.acs.commons.twitter.impl.TwitterFeedUpdaterImpl Loading Twitter timeline for user TIMELINE for component /content/x/en_US/news/jcr:content/par/onecolumn/parfirst/twitter_feed.
As you can see, we're doing quite a lot of calls, to fetch the very same timeline!
We shouldn't fetch the tweets per component, per path, per language copy.
We should fetch the tweets per timeline.
If we were to do that, the above would result in 1 call to Twitter, instead of 7 or more.

While I can see the value of this optimization and would be open to a tested pull request, the usefulness of such a change seems very minor to me. The rate limit for this operation is 300 per 15 minute interval. That means that if you had 20 different components using the same timeline, you would be able to schedule an update every minute. I would suggest that if you need to update that frequently, the approach used by this component is probably not right for you anyway since the value of caching the timeline data in AEM for 60 seconds is minimal to non-existant. Using the Twitter-native widgets (with the caveat that you are limited on look and feel) would be a better approach if you truly needed to update that frequently.

I totally agree with you.
However, the 20 components will be reached quite easily, due to language copies being created and the component being used on more than one page (the website it's now being used on has the component quite a few time).
But I agree it's not necessarily something that needs to be fixed right now. The change is indeed minor.


Controversially adjust Oxford comma.

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[X] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

@sbrooks-harness lol, we do use the Oxford comma. No controversy here.

Preview environment: https://ci.pr.harness.io/pr-478


Ionic's live reload showing an older version of the page in the browser.

From @Natanael1234 on March 6, 2018 18:41
Ionic version:
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[ x] 4.x (version in package.json. Ionic CLI version is <IP_ADDRESS>)
I'm submitting a ...
[X ] bug report
[ ] feature request
Current behavior:
Sometimes, when I change and save a layout, component, page or class, the version of the application showing in the browser is an older version that the one showning a minute ago.
Sometimes I need to save other file related to the file failing or need to restart ionic server so that I get the most recent version of the page.
Sometimes it just don’t get updated during so much time that it is making my work impossible.
I tried to reinstall Visual Studio Code, Ionic CLI, NodeJS and NPM but it don’t solved the problem. The version of NodeJS don’t affects it.
To me, the error appears just after I start the live reload server and still appears after I restart the server.
Sometimes it shows a version of code modified days ago.
Months ago it was not a so frequent problem…
The problem don’t happens only form me. Here where I work, other people are facing the same problem in projects created from the ground.
I’m not sure about that, but it’s like if Ionic Projects keeps cache of older versions of the code and, sometimes, loses itself to show the correct version.
How can I get Ionic App update at every change?
Expected behavior:
When any file in src folder is modified and saved the live reload must reflect the most recent version of this changes in the browser.
Steps to reproduce:
Change and save some file in a Ionic project's src folder. For example, a template.
Wait the live reload update the page in the browser.
See an older version of the page (sometimes).
Save the file again or save some related file (for example, the class of a page related to a template).
Wait the live reload update the page in the browser.
See the newer version of the page (sometimes).
Copied from original issue: ionic-team/ionic#14121

From @comfortme on March 8, 2018 10:59
welcome to the club
https://github.com/ionic-team/ionic-app-scripts/issues/363

Hello,
We are starting to switch to ionic4, I was hoping that this issue would be solved in the new version but no..... Any investigation on this? How can we help to debug? This is taking a considerable amount of dev time....


Active Tab Jumps During Click Scroll

The navigation is being used on a page that has one long content area, and 3 shorter ones currently. When one of the links is clicked, the navigation will scroll to that anchor, but after it reaches the section, it will jump to one of the subsequent short anchors. I can modify the behavior through the scroll threshold, but it still doesn't give the intended effect. What I noticed in looking around is that it appears to fire the scrollChange event during the scrolling triggered by the click event. If it enters the "section" occupied by another anchor after it reaches its intended target, it jumps there instead. This is caused by the consecutive short sections. Is there a recommend fix or alteration that can be made for short content sections so that the navigation will work as intended? Thanks.

Issue was resolved by updating to a newer version, adding a new parameter (offset), and modifying the default threshold to 0.25. The new parameter allowed for sticky navigation at the top of the page.


Custom JSON serializer&deserializer support in useState

Describe the feature
I noticed that the BigInt type will be serialized to Number in useState and it causes loss of precision.
Can we support a user-defined JSON serializer&deserializer in useState to solve this?
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

This works since https://github.com/nuxt/nuxt/pull/19205, enabling experimental.renderJsonPayloads
Example: https://stackblitz.com/edit/nuxt-issues-15760


Update Decorators.md

Already updated to stage 3 for one year:
https://github.com/tc39/proposal-decorators/commit/232899356421269b056e1c1e3d6c68d9c332be88#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R3

To further clarify, I don't think it's a good idea to just change the number from 2 to 3, because that will make the section imply that to get stage 3 decorators, you need to pass --experimentalDecorators, which isn't true.


java.lang.Exception: Please score the model prior to evaluating

Try to use ComputeModelStatistics to LightGBMClassifier model and failing with error java.lang.Exception. Any Comments would be appreciated.
To reproduce this error

Unzip attached file
load Factory.csv to Spark Dataframe
Run program in html
issue.zip

@konabuta this is by design, you did not provide the scored labels column to ComputeModelStatistics or set it on the dataframe metadata, there are several solutions here:
1.) You can provide the scored labels column to ComputeModelStatistics (scoredLabelsCol="my_favorite_column"), and if you want to compute AUC as well you will need to provide the scores column (scoresCol="my_favorite_scores_col")
2.) You can use TrainClassifier or TrainRegressor with LightGBMClassifier or LightGBMRegressor and that will automatically add the metadata for you
3.)  You can use the Spark ML evaluators instead (but you will also need to provide the scored labels column to them)

Thank you for your help ! It works.


Data tests with config blocks do not appear in project documentation

Steps to reproduce

Add a data test to your project:

$ cat tests/assert_whatever.sql
select 1
from  {{ ref('customers') }}
where false

Generate docs dbt docs generate

Serve docs, dbt docs serve

Data test appears in DAG

Amend data test to include a config block

$ cat tests/assert_whatever.sql
{{
    config(
        tags='foo'
    )
}}
select 1
from    {{ ref('customers') }}
where false

Regenerate docs

Expected behavior
Data test should still appear in project DAG
Actual behavior
Data test does not appear in project DAG

System information
The output of dbt --version:
installed version: 0.18.1-rc1
   latest version: 0.18.0

Your version of dbt is ahead of the latest release!

Plugins:
  - bigquery: 0.18.1rc1
  - snowflake: 0.18.1rc1
  - redshift: 0.18.1rc1
  - postgres: 0.18.1rc1

Reproduced on 0.17.2 as well

Hi all,
I mentioned this issue in the dbt slack channel https://getdbt.slack.com/archives/C2JRRQDTL/p1603290085056200

I'm experiencing the same when adding tags to sources.
If I edit the corresponding line in the generated target/manifest.json the lineage graph starts showing the node again.
# manifest.json under sources ->> source...dwh.source_name
# from
      "tags": [
        "tag_name"
      ],
# to
      "tags": [],```

The sources piece of this was resolved in #139, which will be included in v0.19.0 (and was included in v0.19.0-b1). I think the fix for data tests should be fairly straightforward.


Make coordinate frames conform with convention

TODO:

[x] Add tool0 frame
[x] Fix gripper coordinate systems
[x] Adapt examples to new coordinate systems
[x] Test examples

The vacuum example has some issues, see #101 for more details regarding the gripper issue, the other one is related to adapting the positions of the trays to a good place for the rebel.
The other two are working fine though now, as such I'll be merging this soon
@JHeuverRiwo If you encounter any issues with movements now you need to double-check all orientations as they might have changed.


Behavior tree execution on launch

Solves https://github.com/BehaviorTree/BehaviorTree.ROS2/issues/70
I'm working on a project that is supossed to be autonomous, launching a behavior tree on launch of the TreeExecutionServer would be a nice addition.
This PR adds a client server so user can put the wanted behavior tree in the config file to launch a behavior tree without a secondary custom node.

creating an entire Client for this purpose seems overkill.
Can't we just call the method execute?

creating an entire Client for this purpose seems overkill.
Can't we just call the method execute?

I attempted to address this issue. It's possible that my lack of expertise in C++ is a factor. However, due to the fact that the constructor and goal_ attribute of a ServerGoalHandle are protected, I couldn't find a way to generate a goal_handle to then pass to execute.

I am looking into this and even if technically possible with some work arounds, it raises a lot of questions.
What do you want to happen in case of  Action aborted / suceeded / cancelled?
What do you want to happen if another client does send another action? Reject it or cancel the current one?

From what I've seen, Behavior Trees (BTs) in robotics often serve as the highest-level controller, with typically only one BT being used and modified in a project. I was seeking a method to statically assign BTs instead of dynamically assigning them during runtime or after launch.
For instance, in Nav2's NavigateToPose and NavigateThroughPoses navigators, there's a parameter for loading XML, which is similar to what I intend. https://github.com/ros-navigation/navigation2/blob/main/nav2_bt_navigator/src/navigators/navigate_to_pose.cpp#L72
With this PR, my main goal is to eliminate the need for creating a ROS2 node solely for sending an action goal once. This would be particularly useful for projects where the BT assignment remains static.
To clarify, I aim to introduce functionality that facilitates static assignment without altering the typical usage of TreeExecutionServer when dynamic control over BT assignment is desired. I do however understand that the cases where the action is aborted / suceeded / cancelled are not taken into account, which is problematic.
Here are my questions for this approach:

Do you believe this functionality would be beneficial? If not, I'll explore alternative solutions within my project.
Is this the appropriate approach to achieve this goal? Alternatively, I could develop a new class heavily inspired by TreeExecutionServer, which functions as a standard ROS2 node with parameters, rather than an action server.

Looking forward to your feedback, @facontidavide.

Why not just call the Server from your launch file?
Here is an example on calling a service from a python launch file.
from launch.substitutions import FindExecutable
from launch.actions import ExecuteProcess

...

ld.add_action(
    ExecuteProcess(
        cmd=[[
            FindExecutable(name='ros2'),
            " service call ",
            "/namespace/service_to_call ",
            "example_msgs/srv/ExampleMsg ",
            '"{param_1: True, param_2: 0.0}"',
        ]],
        shell=True
    )
)

What do you want to happen if another client does send another action? Reject it or cancel the current one?

Low priority for myself but I did plan on making a configuration option so users could choose if a new goal cancels a current running tree or rejects the new request. This would protect you if you did end up calling the Action from your launch file so that you don't need to worry about something else preempting it. If you have time @marj3220 I think this would be a useful addition.

Why not just call the Server from your launch file?
@MarqRazz you are right. Thank you for that!

Low priority for myself but I did plan on making a configuration option so users could choose if a new goal cancels a current running tree or rejects the new request. This would protect you if you did end up calling the Action from your launch file so that you don't need to worry about something else preempting it. If you have time @marj3220 I think this would be a useful addition.

Good idea! I'll keep this in my mind, if I find the time.
I think I'll cancel this PR.


Add tests

What did you have in mind?

Eventually, I combined it all into one project, but tests were out of scope at the time.
I don't think this project needs anything more than a couple of unit tests, and GitHub has great docs for its APIs.
For any refs or questions, please feel free to ping me.
Are you trying to fix a problem?
No response
Any lead on how this feature can be implemented?
No response

project archived!


Exclude/Include options are not inherited

So I understand when inheriting that Array settings are not merged, the local settings are used, but it seems counter intuitive that when there is no local settings specified, the inherited one is simply silently ignored.
Expected behavior
Inherited settings are used if there are no local settings to override.
Actual behavior
Include/Exclude settings are ignored from the inherited configuration file, and since no local settings are specified, defaults are used.
Steps to reproduce the problem
Create a folder with one ruby file, test.rb.
Create an empty .rubocop-parent.yml file, and a .rubocop-child.yml. Add a single directive in .rubocop-child.yml:
inherit_from:
  - .rubocop-parent.yml

In .rubocop-parent.yml, add:
AllCops:
  Exclude:
    - test.rb

Run rubocop -c .rubocop-child.yml --list-target-files in the folder will still output test.rb. Again I get why you don't merge array settings, but if no local settings are specified, it seems intuitive that the inherited value would be used.
RuboCop version
Include the output of rubocop -V. Here's an example:
$ rubocop -V
0.45.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.1 x86_64-darwin15)

This looks like a bug, indeed.

I can't reproduce the problem with the steps given above, but the seemingly related #3960 is fixed on master, so please check if that also takes care of your problem, @npepinpe.


Update sender-id.md

Checklist
Required

[ ] I acknowledge that all my contributions will be made under the project's license.

PR Details
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @brinawebb ,
Thank you for the contribution. Unfortunately, this PR won't fix the problem but instead reports it. This is still valuable, but it should be reported as an Issue rather than a PR. We have noted the problem and will be fixing it shortly.
Thank you again for your contribution,
Twilio SendGrid Docs Team


Czkawka 4.0.0 Update?

Thank you so much for maintaining this :)
Are you going to be updating Czkawka to 4.0.0?
They have some great new features I'd love to use.
Thanks!

Yes, I'm working on this!

New Docker image available!


Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models.

see: https://github.com/spring-projects/spring-ai/issues/809
Provide a new BedrockConverseApi for AI model chat usage.
Re-implementing current chat models from AbstractBedrockApi to the Bedrock Converse API to reduce complexity.
Re-implementing Bedrock chat model usage information: https://github.com/spring-projects/spring-ai/pull/605.
Support build-in exponential backoff: https://github.com/spring-projects/spring-ai/pull/759.
things todo:

[x] BedrockConverseApi
[x] re-implement the Bedrock chat model.
[x] chat model exponential backoff.
[x] chat model options document.
[x] re-implement the Bedrock chat model usage information. https://github.com/spring-projects/spring-ai/pull/605
[x] Tools support. https://github.com/spring-projects/spring-ai/issues/802 https://github.com/spring-projects/spring-ai/pull/810
[x] remove deprecated bedrock chat api.
[x] Support custom BedrockRuntimeClient and BedrockRuntimeAsyncClient.
[x] embedding model exponential backoff. https://github.com/spring-projects/spring-ai/pull/759
[x] Amazon Bedrock Mistral Chat model support. https://github.com/spring-projects/spring-ai/pull/808
[x] Amazon Bedrock Cohere Command R model support. https://github.com/spring-projects/spring-ai/pull/667

@tzolov Hi Christian, I'm basically finished re-implementing Bedrock AI models with the Amazon Bedrock Converse API. But there are some thing's I'd like to discuss.

Because of the Amazon Bedrock Converse API, bedrock chat models don't need such things as Anthropic3ChatBedrockApi anymore. Should I remove the old Apis?
Bedrock Mistral and Cohere Command R model which are not supported yet. Should I includes these models in this PR?

Is it realistic to expect this PR to be merged before 1.0.0?
That would be great to see.

Is it realistic to expect this PR to be merged before 1.0.0? That would be great to see.

I hope that, I'm looking forward to have this PR merged as soon as possible too...

I hope so, This is a huge PR, Maybe we can review it by ourselves first to reduce the workload for the team members

Hello @tzolov Any advice on this PR?

Hi @maxjiang153, it's a pity that there is no news about this PR, maybe it's too big, I don't know....
@tzolov @markpollack any thoughts on how to move forward with this?
Thanks all for the huge effort !!

Hi @maxjiang153 ,
Thank you very much for the great (and big ;) contribution.
Sorry for not reaching out earlier. We've been quite busy and lacking the manpower to review and address all PRs.
The #813 has a hight priority for me and I hope to be able to jump on it soon.

@tzolov As Amazon Bedrock is rapidly involved and the AI 21 Jamba model is just generally available, I wonder: should I keep moving on this PR to support this new model or wait for this PR to be merged and then create a new PR to support the new model?
Check this out: https://aws.amazon.com/about-aws/whats-new/2024/06/ai21-labs-jamba-instruct-model-amazon-bedrock/

waiting ....

@DEG-7 I see that maintaining this PR with upstream is heavy work, I'm not sure when team members will work on this PR, but I'll keep an eye out for when it will be reviewed or merged.

Excuse me, are there any dates when this PR will be merged?

Hey @maxjiang153,
First, apologies for the delay. You've put in a tremendous amount of work and we've been too slow to react.
To a large extent, this is due to the size of this PR. Usually, PRs of this scope would never be merged in a single go.
I've started exploring the Bedrock Converse API and also trying to check the code in your PR.
My initial goal is to:

Start a new dedicated module spring-ai-bedrock-converse and leave the old (e.g. invoke-model) in its existing spring-ai-bedrock module (perhaps we can rename it later to spring-ai-bedrock-invoke or similar)
Implement the core Converse API and Abstract classes in a single PR
Implement the Anthropic support in a second PR (+ related documentation)

Please let me know if you're still interested in contributing to this work.
Either way, if we use your code, we will always add your name as a contributor (same for the commit).

Hi @tzolov, it's been a while. I still would like to contribute to this PR, and AWS has released lots of new models since this PR was created.
However, with the Bedrock Converse API, all of the models have a very similar invoke method. I think implementing a new spring-ai-bedrock-converse module might be a good idea. The most important part, I think, is whether we still need to keep different models with different implementations like the old spring-ai-bedrock module, or if we should implement a single converse API that is compatible with all models supported by the Bedrock Converse API.
Let me know if you have any thoughts.

@maxjiang153

I still would like to contribute to this PR,

This is great thank you.

AWS has released lots of new models since this PR was created.

Spring AI API has changed significantly as well.  The function calling is different, chat-model, metadata ... . Now we have observation support. ..
I will try to put together some foundation in separate a branch and then we can start from there. Will try to reuse the code from your PR when possible.

The most important part, I think, is whether we still need to keep different models with different implementations like the old spring-ai-bedrock module, or if we should implement a single converse API that is compatible with all models supported by the Bedrock Converse API.

I'm still exploring the Converse API.  Looks like we will be able to reduce the implementation to a single BedrockConverseChatModel implementation indeed.
But we will need to support the specific per-model provider options: additionalModelRequestFields , additionalModelResponseFieldPaths.
Maybe having dedicated per-model options class will be enough. Don't know yet.

Based on the Converse API and Converse Stream API definitions, all the models have the same request structure. The only differences are the additionalModelRequestFields and additionalModelResponseFieldPaths.
In my original design, I kept ChatOptions for each single model like this one: Anthropic3ChatOptions, and created a BedrockConverseApiUtils class to convert the ChatOptions fields to additionalModelRequestFields.
So I'm thinking we could keep this conversion mechanism. It might work like this:
We could have a BedrockConverseChatModel to unify all models that Amazon Bedrock supports, and we could have different ChatOptions for each single model or maybe create an AbstractBedrockConverseChatOptions with different model implementations.
Also, I wonder if I should continue working on this PR or if I should create a new PR instead.

tbh BedrockConverseChatModel seems weird, because the Converse API is not an actual model; it could represent a lot of models.

@maxjiang153 - I've created PR #1650 with you as co-author.
While I rewrote the integration to match latest Spring AI API changes, I incorporated elements from your PR.
Please review as I may have missed something.
Type-safe options will be addressed in separate PRs.

Nice work, I'll close this PR

@maxjiang153
FYI, here are the follow up tasks, I could think of: https://github.com/spring-projects/spring-ai/issues/1758
and some early ideas: https://github.com/spring-projects/spring-ai/pull/1760


tests: update GitHub actions Xcode version

Support Xcode 12.0 Beta and use iOS14 device
Regenerate some snapshots to confirm to iOS 14

The build is still failing because a snapshot doesn't match. It's most probably due to the fact I'm using Xcode beta 3 to develop, and the CI GitHub actions is using Beta 2.
I would rather wait for GitHub actions to update the Beta version of Xcode. So I retest and merge this PR then.

See https://github.com/actions/virtual-environments/issues/1166


Update k8s setup

Update the kubernetes configuration yamls with DockerHub images, resource limits, and new variables for adapter-registry.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add small tweaks to the Getting started section

Hey @BrianDGLS, I couldn't resist to try your library this morning before work. I ran the pattern library app and everything worked well. I left a small PR with a couple of tweaks for the README. TA

@jordifebrer Thanks Jordi, have merge the PR.


Update zio-json to 0.3.0-RC5

Updates dev.zio:zio-json from 0.3.0-RC3 to 0.3.0-RC5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-json" } ]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #1383.


fix(ignition): Add HCP label to ignition-server by default

What this PR does / why we need it: Add hcp label to ignition-server MatchLabels by default to avoid upgrade restriction from 4.12.27+ to 4.13.7+
https://redhat-internal.slack.com/archives/C01C8502FMM/p1692808565816429
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/approve

/retest


Phone Verification: Firebase native Instance not propagated to firebase sdk

Hello,
I am using phone verification in android and Plugin works well but when signing in using signInWithCredential(), the native firebase instance is not propagating to firebase sdk. I cannot get user instance using sdk
Thanks

Sorry this does not make sense to me.
Please complete the issue template in full, giving code examples and if possible illustrate the problem using the example project


share tls key is not present in client template (openvpn 2.6 / easyrsa 3.1)

This is our client config
{{- range $server := .Hosts }}
remote {{ $server.Host }} {{ $server.Port }} {{ $server.Protocol }}
{{- end }}

verb 1
client
nobind
dev tun
key-direction 1
tls-client
remote-cert-tls server
mute 3
resolv-retry infinite

# those values MUST match on server AND client
fragment 1300
mssfix 1300
comp-lzo no

# no cipher setting, should be automatically negotiated

{{- if .PasswdAuth }}
auth-user-pass
{{- end }}

<cert>
{{ .Cert -}}
</cert>
<key>
{{ .Key -}}
</key>
<ca>
{{ .CA -}}
</ca>
<tls-auth>
{{ .TLS -}}
</tls-auth>

The server config includes
cat server.conf| grep tls-auth
tls-auth ./ta.key 0

And is located at /etc/openvpn/server.conf, the shared secret is right next to it
ls -la /etc/openvpn/ta.key
-rw------- 1 root root 636 Oct 31 23:31 /etc/openvpn/ta.key

Still when downloading a client configuration, <tls-auth> is not populated (empty). I need to add it manually so the import / client connection actually works.
We are using debian 12 (bookworm) and thus easyrsa 3.1+ (not fully supported, but we fixed that) and also openvpn 2.6.6.
I assume the latter might be an issue, did something change on the management API part?

using an absolut path for the ta.ky /etc/openvpn/ta.key did not help either

ovpn-admin does not read server.conf and waits for ta.key on the path  easyrsaDirPath + "/pki/ta.key

@pashcovich thank you for the help. I cannot find anything about that in the docs - did i miss that - if it is missing, should we add it?

there is no info about this in the docs. I will think about adding a note on this


Feature Proposal: Make the templating customizable

Hi @anatolysakhno,
First of all, thank you for your great idea and very useful implementation. The plugin is really one of  must-to-have plugins IMHO. Anyway, let me ask you for some improvements related to a configurability of the plugin.

All of the templates (whole document template) should be external and customizable. Currently there is only header, footer, and After Scenario templates are customizable.
The templates related to the repo/workspace and constant template assets (images, css files, etc.) should be stored in .vscode folder (probably in subfolder(s)).
Need to add more template variables. I propose to add wildcards,  like as: {{FEATURE_NAME}}, {{TIMESTAMP}}, etc. Currently I found that {{SCENARIO_NAME}} wildcard is only in use.
Please provide us with a guide on how to insert images (png, jpeg) into the document.

Thank you in advance
David Kossoglyad

Hi David,
Thank you for yor feedback!
All the ideas make sense and I will add them to the backlog.
As for the images (4) you can use html in the mentioned header/footer/after scenario templates or directly in the feature abstract (the area between Feature title and first gherkin keyword).
It can also be combined with wildcard template in after scenario like follows (does not look nice so far):
<img src="/Evidence/{{SCENARIO_NAME}}.jpg" alt="Evidence: {{SCENARIO_NAME}}">


[BUG] Increase the size of the create backing image form on the Longhorn UI

Describe the bug
The bigger form of create backing image will look good as it has text box URL

Example screen:

Environment:

Longhorn version: v1.1.1-rc1

Validation the commit a7a7e7e: Pass


Fix translators in messages/config.php

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#19415

This also needs an update. And please add a changelog line, thanks.

@samdark we waiting somebody?

@WinterSilence https://github.com/yiisoft/yii2/pull/19416#issuecomment-1140224427

👍🏻


AVD Add-On: Fix VM name prefix in VM Template property on the host pool

### Tasks

Ensure the service token has been removed and the value is 11 characters or less


[ACR] Address credential description in docstring

API change check
API changes are not detected in this pull request.


es6-shim.js:2350 Uncaught RangeError: Maximum call stack size exceeded

Mac OSX - Yosemite
ng --version
angular-cli: 1.0.0-beta.10
node: 6.1.0
os: darwin x64
I just updated to the new version of the CLI and when I launch the server the console logs this error and does not load the app.
Stack Trace
Uncaught RangeError: Maximum call stack size exceededPromise @ es6-shim.js:2350PromiseCapability @ es6-shim.js:2116resolve @ es6-shim.js:2506scheduleQueueDrain @ zone.js:447scheduleMicroTask @ zone.js:455ZoneDelegate.scheduleTask @ zone.js:339Zone.scheduleMicroTask @ zone.js:270scheduleResolveOrReject @ zone.js:569ZoneAwarePromise.then @ zone.js:644(anonymous function) @ es6-shim.js:2154
embed.js:22 Uncaught TypeError: Cannot read property 'appendChild' of nullk @ embed.js:22l @ embed.js:22h.toJSON @ embed.js:22b.loadEmbed @ embed.js:23(anonymous function) @ embed.js:23

Hm, really can't tell without looking at your app tbh. We're moving away from the build system in beta.10 to a new one in the webpack preview version, maybe that will help. See https://github.com/angular/angular-cli#webpack-preview-release-update

I updated to the latest version an I am having more problems than before. Is there any guides on switching from SystemJS to Webpack regarding angular-cli. I have so many errors now

@borntodesign there's a complete one now, see https://github.com/angular/angular-cli#webpack-update


Even more strict input validation.

People are setting invalid arguments like negative set height intervals. Every input argument must be validated.

At the moment even arguments like retry_delay are wrong validated. They use btctxstore desierialize.positive_integer. 0 ist allowed. Polling with 0 delay? I dont think that is good for the server.
Same problem for height interval 0. That should cause a zero division exception.
I see no argument that needs 0. Maybe change btctxstore to validate greater 0 and use it for the new implemented arguments? Should i open a issue for that?
Anyway that are 2 different Bugs. For now i will implement the missing validations. Later i will check the 0 and report the results.

Validation for max_size and height interval added + unit test for both.
Confirmed the height intervall 0 bug (0 division exception) and the 0 delay poll. That is still open. Please check if the validation btctxstore positive_interger can be modified.

Added input validation for all arguments.


upload file error

reqwest = {version="0.11",features= ["json","multipart","stream"] }
tokio = {version="1",features= ["full"] }
tokio-util = {version="0.7",features= ["codec"] }
tokio-stream = "0.1.9"

async fn reqwest_multipart_form(url: &str) -> anyhow::Result<String> {
    let client = Client::new();
    let file = File::open("xxx").await?;

    // read file body stream
    let stream = FramedRead::new(file, BytesCodec::new());
    let file_body = Body::wrap_stream(stream);

    //make form part of file
    let some_file = multipart::Part::stream(file_body)
        .file_name("xxxx")
        .mime_str("application/octet-stream");

    //create the multipart form
    let form = multipart::Form::new()
        .text("username", "seanmonstar")
        .text("password", "secret")
        .part("file", some_file);

    //send request
    let response = client.post(url).multipart(form).send().await?;
    let result = response.text().await?;

    Ok(result)
}

while file size=200M, will response error:  ReqwestErr(reqwest::Error { kind: Decode, source: Error("expected value", line: 1, column: 1) }
small file no  problemes

request time out


FLEX-2329 update image to ubuntu 16.04

 All committers of the pull request should sign our Contributor License Agreement in order to get your pull request merged.1 out of 2 committers have signed the CLA.:white_check_mark: villgust:x: MartijnSipsCGI


Coyote library has a type_of_change different to ours, but we just mash them together

leading to
  t != static_cast<type_of_change>(C_DISCONNECTED)) {  // todo: fix this

fixed


Added code coverage tracking to github action

Pull Request Description
What issue does this change request address?
#376
What are the significant changes in functionality due to this change request?
This request replaces the call to run_tests in the part of the github action running on linux with a call to check_py_coverage.sh. This does not impact the functionality of the tests being run in any way. It provides a brief message with an easily visible percentage for code coverage when the action is complete. This message also directs users to a thorough html report on coverage available under the 'Artifacts' section.
The disadvantage of this addition is the overhead run time whenever the github action is activated. Running locally, checking coverage adds about 19% overhead relative to plain run_tests. Since coverage is only being run for one of the two calls to run_tests in this github action, the impact of the overhead is halved to 9-10% (considering only time spent executing tests, not time for setup and other activities the github action executes). While it does save time, only checking coverage for a single OS would not capture deviations in coverage caused by different scripts being run per the OS. An example of this is the selection of a pyomo solver, which can depend on the OS platform running the script.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[ ] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job CentOS 8 on ce3d555 : invalidated by @GabrielSoto-INL

Job CentOS 8 on ce3d555 : invalidated by @GabrielSoto-INL
problem with cloning, trying again?

Just a general comment for clarification: seems there are two ways of accessing the coverage, correct?

download the "Artifacts" left over from the coverage run in the "Checks" tab or
navigate here and scroll to the bottom of the page:

Also, an additional note that after this PR is merged, @caleb-sitton-inl it may be good to summarize this in a Discussion for developers in this repo

Just a general comment for clarification: seems there are two ways of accessing the coverage, correct?

download the "Artifacts" left over from the coverage run in the "Checks" tab or
navigate here and scroll to the bottom of the page:

Also, an additional note that after this PR is merged, @caleb-sitton-inl it may be good to summarize this in a Discussion for developers in this repo

Yes, you can view the list of artifacts (which currently just contains the coverage results) in either of these ways. As for the Discussion, sounds good; I'll go ahead and create that once it's merged.

This looks like it's coming along great. Have we documented how to view the coverage reports, and placed that documentation somewhere new developers can get familiar with it?


node-auth0 integration

We could introduce a new API layer consumed by our recipes. This API layer could use node-auth0 or some other custom libs. Custom libs are used when node-auth0 can not handle the case properly.

Yep, I think this is a great idea. I'd like to use this concept to improve the recipe authoring experience. Specifically:

Replace the use of imports of helper modules with API instances built into the run parameters
Remove the the accessTokens parameter and replace it with APIs instances that already have the required access_token so the author doesn't have to worry about them at all
Create APIs that provide more explicit functions like createConnection instead of createEntity.

In nutshell go from this:
import * as auth0 from '../lib/auth0';

export const run = (accessTokens) => {
  return auth0.createEntity('Client', 'client_id', '/api/v2/clients', accessTokens.v2, {
    name: 'My Website',
    callbacks: [ 'http://localhost:3000/callback' ],
    app_type: 'regular_web',
    jwt_configuration: { alg: 'RS256' }
  });
};

to this:
export const run = (context) => {
  return context.auth0.createConnection({
    name: 'My Website',
    callbacks: [ 'http://localhost:3000/callback' ],
    app_type: 'regular_web',
    jwt_configuration: { alg: 'RS256' }
  });
};


in-memory database or 'backup to' seems to leak memory

We are trying to create a large SQLite in-memory database and once the DB is created we are dumping it to a file using 'backup to' comand. This is done as creating a large in-memory sqlite db is much faster.
Once the backup process is complete, sqlite connection and statement is closed. When we looked at the memory footprint, the off-heap memory shot by 10GB during in-memory db creation. Once all the resources are closed, reduction in off-heap memory was around 1.2GB. We are left in 8.8GB extra memory in off-heap area.
So, we suspect a memory leak either in in-memory database or 'backup to'.
Is there a specific way to release memory for in-memory sqlite db?

Off-heap memory is out of control of JVM. So I think some allocated handler(s) inside JNI code is not released properly:
https://github.com/xerial/sqlite-jdbc/blob/master/src/main/java/org/sqlite/core/NativeDB.c#L1366

we are doing the same thing using sqlcipher_export as below 👍
statement.execute("ATTACH DATABASE '" + path + fileName + "' AS encrypted KEY '" + password + "';");
statement.execute("SELECT sqlcipher_export('encrypted');");
statement.execute("DETACH DATABASE encrypted;");
maybe you should try this approach @ksaurab

I also encountered the same problem, which versions are affected


Button styling

as far as i am aware, these buttons are on more places than just drop page nfts

the correct hover should be

as in: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=5311-18771&mode=design&t=H89BpYMt5hwXu1XH-11
task: find and replace all incorrect button states for this component

👋🏻

ohh, you mean here? @exezbcz


typing and pathlib only on old python versions

PR joining issue #33. Prevents installation of typing on python >= 3.5 and installation of pathlib on python >= 3.4.

thanks for the effort !
in the future support for old python versions will be dropped - so then those imports will be removed completely.
for the time beeing, i accept Your PR, thanks for pointing that out !
bitranox


Concept mentions not working in non-Clause 3 of a vocabulary document

Errors:
AsciiDoc Input: (ID _dbf283e5-cf07-41c4-9817-aa688d118490): Error: Term reference to `iCalendar` missing: "iCalendar" is not defined in document
AsciiDoc Input: (ID _cf734446-6bbb-429b-9ec7-fdf4f4d08d4c): Error: Term reference to `iCalendar` missing: "iCalendar" is not defined in document
AsciiDoc Input: (ID _c421fa9e-3ef1-402e-8958-d68831912851): Error: Term reference to `vCard` missing: "vCard" is not defined in document

And this also causes metanorma-ietf to crash.
The way to work with vocabulary documents is documented here:

https://www.metanorma.org/author/iso/topics/markup/#vocabulary-documents

[heading=terms and definitions]
== Terms related to specific technologies

=== Calendar data formats

==== iCalendar
standard format for representing calendar data

[.source]
<<cc_glossary>>

==== vCalendar
legacy format for calendar data superseded by {{iCalendar}}

[.source]
<<cc_glossary>>

==== vCard
standard format for representing contact information

[.source]
<<cc_glossary>>

==== xCal
XML representation of {{iCalendar}} data

[.source]
<<cc_glossary>>

==== xCard
XML representation of {{vCard}} data

The error is different: the terms are not being recognised as terms at all:
<clause id="_terms_related_to_specific_technologies" obligation="normative">
<title>Terms related to specific technologies</title>
<clause id="_calendar_data_formats" obligation="normative">
<title>Calendar data formats</title>
<clause id="_icalendar" obligation="normative">
<title>iCalendar</title>

standard format for representing calendar data

That is because Metanorma has inherited from ISO the constraint that there is only one Terms and Definitions section per document, outside of ISO/IEC vocabulary documents; and 03-22-misc.adoc is marked up as a distinct sister clause to the Terms and Definitions clause, not a subclause of it.
If I comment out that bit:
//[heading=terms and definitions]
//== Terms related to specific technologies

The concepts process fine, because the "Calendar data formats" are recognised as terms fine.
So we have two alternatives:

In CC, mark "Terms related to specific technologies" up as a subclause of the Terms (include::03-22-misc.adoc[leveloffset=+1]), because CC doesn't know about vocabulary documents, and the Metanorma constraint that there can be only one Terms section per document is good and needs to be preempted in markup
The Metanorma constraint that there can be only one Terms section per document is only advisory, and if the user puts in a heading attribute wanting there to be two in the document, that should be respected, for any flavour of Metanorma

@ronaldtse Which do you want?

Given that vocabulary documents are quite widespread amongst SDOs, perhaps it is easier if we relax the "one terms section only per document" rule.
For this particular document, I am planning to also cross-publish to ISO as a proper vocabulary document, so I prefer keeping the same structure across documents.

These errors have gone away with the fix to standoc, as the clause is now recognised as a second terms clause.
We now have a different error: isodoc still is expecting to find a single terms section, so the second term section is not getting any anchors processed for it.

Have addressed that issue too.


Cleanup /tmp leftovers from builds and integration tests

When building and running integration tests, temporary files and directories are created in /tmp.
Unfortunately not all are removed afterwards so after a while hundreds of files and directories accumulate in /tmp.
Although a reboot cleans /tmp, we should leave /tmp clean after our builds and integration tests.

But for Jenkins jobs running on a linux server which is not often restarted, this can be of course lead to a full /tmp folder.
It's not easy to ensure this always inside tests that the old tmp data is dropped. Also it is sometimes necessary to check those data when a build fails..
So IMO the best way to solve this would be, to write a helper method (e.g. inside TestUtil) where a new temp file will be created which is located at ./build/tmp/sechub/**. So when a build is done a developer is able to inspect even the temporary files - if necessary. Also the build folder is automatically deleted via ./gradlew clean when a new jenkins job is started. Also when the jenkins job is deleted, all current exist temp files for this job are deleted as well!
So there is stil a migration effort to check for tests using temporary files, but I think it's not too much and gives back some good benefits for developers as well.

a delete via ./gradlew clean would be helpful :+1:
another good feature would be if all the stuff did not land directly under /tmp/ but in a subdirectory there. E.g. /tmp/sechub-builds/. Advantages:

/tmp would not be that crowded
it would be clear which artefacts originate from SecHub builds and which not

Recently I found out that temporary files (at least .zip files) are created inside the SecHub's git tree and that these are not deleted with ./gradlew clean.
Example:
./sechub-doc/bin/test/upload/zipfile_contains_only_test1.txt.zip
./sechub-integrationtest/bin/test/pds/codescan/upload/zipfile_contains_inttest_codescan_with_critical_sarif.zip
./sechub-integrationtest/bin/test/pds/codescan/upload/zipfile_contains_inttest_codescan_with_critical.zip
./sechub-integrationtest/bin/test/pds/codescan/upload/zipfile_contains_inttest_codescan_with_low.zip
./sechub-integrationtest/bin/test/pds/codescan/upload/zipfile_contains_inttest_codescan_with_medium.zip
./sechub-integrationtest/bin/test/zipfile_contains_only_test1.txt.zip
./sechub-pds/bin/test/zipfiles/hierarchical_files.zip
./sechub-pds/bin/test/zipfiles/single_file.zip
./sechub-pds/bin/test/zipfiles/two_files.zip
./sechub-pds/workspace/07feb58c-fab4-4156-a8a4-2182d718ff90/upload/something.zip
./sechub-pds/workspace/088695c0-1c30-49fc-bc2e-c6515f826baa/upload/something.zip
./sechub-pds/workspace/093a7ce3-192a-4f19-8509-fe01f849875d/upload/something.zip
./sechub-pds/workspace/1b9d34f3-2cb0-4655-b62e-1868c2fcac65/upload/something.zip
./sechub-pds/workspace/22e04e69-7340-4e1a-8c21-edfafb2518a1/upload/something.zip
./sechub-pds/workspace/25aa3c27-2b6b-4e5e-9ec0-deb3aeb7e1fb/upload/something.zip
./sechub-pds/workspace/27dbfaea-cb80-4ddb-b8c3-bbd3c62586a5/upload/something.zip
./sechub-pds/workspace/29ab5d56-07ec-4f27-97ec-5f81059986ce/upload/something.zip
./sechub-pds/workspace/2c6b15fb-0582-4988-a827-ef5c201e70f5/upload/something.zip
./sechub-pds/workspace/2ca7f9b8-128a-4a9d-b4ae-ca3f0d599b86/upload/something.zip
./sechub-pds/workspace/36ed8239-f677-4bea-8433-a74e3830e4f9/upload/something.zip
./sechub-pds/workspace/38cdddd7-1edc-4d57-ae9b-47604c2097ed/upload/something.zip
./sechub-pds/workspace/400195b5-70dd-49c0-bfc4-33177dfc54bd/upload/something.zip
./sechub-pds/workspace/41a7c267-1ef3-4762-bc14-27ad7d36818c/upload/something.zip
./sechub-pds/workspace/42955c75-6a57-44b4-936c-94373ab58563/upload/something.zip
./sechub-pds/workspace/42e597a9-c03a-49bd-900c-2315f78410bf/upload/something.zip
./sechub-pds/workspace/467fa4a4-ba16-4212-8c82-d02f47854640/upload/something.zip
./sechub-pds/workspace/503a77c1-67ed-43e9-a589-a761e8951d68/upload/something.zip
./sechub-pds/workspace/5263cd7d-2166-4e61-bb0f-72cbd2d51151/upload/something.zip
./sechub-pds/workspace/599d4f52-a2d7-454d-9c2f-b2e28190f475/upload/something.zip
./sechub-pds/workspace/651fe90d-53a6-41df-a332-f1d8f964494c/upload/something.zip
./sechub-pds/workspace/72e61c64-8cad-455e-a4a6-a980dbb19e4a/upload/something.zip
./sechub-pds/workspace/75b9a519-8a57-4323-9a6d-5794d3ed3224/upload/something.zip
./sechub-pds/workspace/7935fbca-0c72-4797-8ab0-991a0142bd2d/upload/something.zip
./sechub-pds/workspace/7bb73cd9-22ac-4d40-8d61-966521e58198/upload/something.zip
./sechub-pds/workspace/84814ea4-809f-46b1-b382-bb93d99f538f/upload/something.zip
./sechub-pds/workspace/888850f5-e440-4858-b9a1-96541c737202/upload/something.zip
./sechub-pds/workspace/8a547a3c-b568-4f88-aa22-ad0c24c7eb7a/upload/something.zip
./sechub-pds/workspace/a54de002-3b57-4520-8e43-6236368c4078/upload/something.zip
./sechub-pds/workspace/a6b73f97-72d4-4230-9c67-d9c3f0d69204/upload/something.zip
./sechub-pds/workspace/af760217-07c2-4a4e-b0a2-d24698a04f06/upload/something.zip
./sechub-pds/workspace/b2ce890f-84bc-4441-a0f1-21e9da59d9cf/upload/something.zip
./sechub-pds/workspace/bfa0fba1-62ef-4c74-af15-8d00cd0394fd/upload/something.zip
./sechub-pds/workspace/c4f8aaea-a454-44f2-82bd-c9da788c04f8/upload/something.zip
./sechub-pds/workspace/c7cf758d-855f-45da-b002-408108e4449e/upload/something.zip
./sechub-pds/workspace/c9811177-30ca-47e7-9b99-b9517a012169/upload/something.zip
./sechub-pds/workspace/d2fe01a1-c274-457c-8bb6-fbcd9efd885b/upload/something.zip
./sechub-pds/workspace/d557a348-c5db-4b2c-b9c2-a011dc570824/upload/something.zip
./sechub-pds/workspace/ee0dc78f-5f78-4599-af5b-adb0531c980f/upload/something.zip
./sechub-pds/workspace/f332127a-1e50-427f-88b8-fb74738b8f09/upload/something.zip
./sechub-pds/workspace/f7876b89-2cfa-4c1d-b5a9-cbdc7163b471/upload/something.zip
./sechub-pds/workspace/fa0cd3e6-68eb-4cc0-8575-0b65186f1ec4/upload/something.zip
./sechub-schedule/bin/test/upload/zipfile_contains_only_test1.txt.zip
./sechub-shared-kernel/bin/test/zipfile_contains_only_test1.txt.zip

-> please make them getting deleted with ./gradlew clean


Add basePath to paths if no path prefix is configured

Introduces new validator base class to house this common functionality. There's a lot of duplicated code in the two validators that should later be pulled up into the base class (didn't touch that).
Fixes #1.

Coverage increased (+0.2%) to 87.827% when pulling 51752b14f5247183c5c59f97c45cfbed932657c4 on marcelstoer:fix/include-basepath into dcaf45edea6c8ca086c66c5075abe57064b6d17e on RobWin:master.


Escape key no longer ends drag after #401

It's no longer possible to stop dragging dock content by pressing the escape key after #401.

The check for WM_KEYDOWN does need to done as a message filter since the window begin dragged doesn't have keyboard focus or something like that (not too familiar with how input works on win32). The other three can probably stay in WndProc since the mouse is captured at the start of dragging, but I do wonder why they were originally written using a filter.
protected virtual bool OnPreFilterMessage(ref Message m)
{
    if (m.Msg == (int)Win32.Msgs.WM_MOUSEMOVE)
        OnDragging();
    else if (m.Msg == (int)Win32.Msgs.WM_LBUTTONUP)
        EndDrag(false);
    else if (m.Msg == (int)Win32.Msgs.WM_CAPTURECHANGED)
        EndDrag(!Win32Helper.IsRunningOnMono);
    else if (m.Msg == (int)Win32.Msgs.WM_KEYDOWN && (int)m.WParam == (int)Keys.Escape)
        EndDrag(true);

    return false;
}

Before a full solution is found, I just disable the patch from #401 in master, 99b77161721a63f4527bceafa4870bba5aa1540c .
Will release 2.12 pretty soon to include this change.

Closed temporarily and wait for a better patch to replace #401.


NEXT-26196 - Add support for active flag on user entity

1. Why is this change necessary?
Active flag on user entity is currently not considered, but can be set via API. This PR adds the field to the admin ui and uses it to handle user authentication.
2. What does this change do, exactly?
Add user active field to admin ui. Consider the field during authentication.
3. Describe each step to reproduce the issue or behaviour.
Create admin user.
Set active to 0 via api or database.
Log in to admin with said user.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-26196
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

🤖 Generated by Copilot at 7a55059
This pull request adds support for the active flag of the user entity, which allows administrators to enable or disable users in the system. It adds a new switch field in the user detail page of the administration module, and modifies the API and OAuth logic to check the user's active status. It also updates the changelog and the translations for the new feature.

🤖 Generated by Copilot at 7a55059

Add support for the active flag of the user entity (link)
Add a switch field for the active flag in the user detail page of the administration module (link, link, link, link)
Prevent inactive users from accessing the API with a valid token by checking the active flag in the BearerTokenValidator (link)
Prevent inactive users from logging in with a valid password by checking the active flag in the UserRepository (link)

Hey,
I will close this PR as it's inactive for a while. Feel free to create a new one when you apply the requested changes


the input parameter should be mutable in beforeWalk, Walk and afterWalk

right now, the input parameter in beforeWalk is immutable, such that the relaceCharForBrowserConsistency cannot alter the input to reflect the change in downstream function, like Walk and afterWalk, we need to change the input parameter to mutable.

i am closing this issue as the software architecture changes.


Proposal: Default devcontainer.json to non-root "remoteUser"

Currently the contents of this repository default to using "root". While this is fine given the scenario, it doesn't work well when using Linux as the host and some tools throw warnings and errors when running as root.
The upside of doing this is that, with sudo being present, using the containers will feel more like using a local Linux machine or mac. We can leave the actual container running as "root" (rather than setting USER in a Dockerfile or via containerUser in devcontainer.json) to avoid any bootstrapping challenges. It will allow people to FROM the image and install software in the way you would with other base images.
//cc: @chrmarti @lostintangent @matthewisabel @nikmd23 @bamurtaugh @burkeholland for input - to see if there's anything I'm missing.

Sounds good. I think for production the recommendation is to run as non-root too, so we don't really move away from what projects want to deploy later. (Having alignment between DevContainers and production containers helps avoid breakage due to differences between the two.)

@chrmarti Yeah exactly - it also feels a bit foreign if you're not already knee deep in working with containers. Even small things like your home folder being /root instead of /home/<username>.
We could flip the image itself to a non-root user instead (USER ${USERNAME}) but I worry a bit about people extending FROM the image hitting different behaviors than you'd see from other "base" images you'd grab off the net. This seemed like a good middle ground in that regard.  Different ENTRYPOINT scripts that require root access can also fire and run without sudo. I know we got this feedback more than we expected before the "remoteUser" property was added.
We can then just invert the comment - tell people to comment it out if they want to run as root.

I'm waiting for this..

Yeah I've found a few community contributed definitions that seem to either be missing a non-root user (e.g. Puppet) or have an issue. I think the thing to do here will be to move to non-root users, and raise issues on those leaving them as-is for now rather than waiting.

Merged!


Code generation with kkt.c/.h

The code generation routines appear to always (on both vector and matrix updates) copy the kkt.c file into the generated code, instead of ignoring it for the vector updates as the comment suggests should happen. I traced this back to the comparison in osqp.m:468 :
~strcmp(cfiles(i).name, fullfile(cdir, 'kkt.c'))
which should actually be:
~strcmp(cfiles(i).name, 'kkt.c')
since dir returns only the name of the file, not the full path in that field. Was the use of fullfile() a compatibility fix for older MATLAB versions? I have been doing this recent work on 2019a.
Additionally, kkt.h is still being copied into the generated source when vector updates is requested, even though kkt.c is not. Is this expected behavior? It seems that it should be ignored as well.
If changes are needed, I will make them on my current dev branch in my fork since they tie in with some work I am doing related to the Simulink interface.

You are right. This was a bug, not expected behavior. Should be fixed now in master branch.

Thanks. I have pulled those changes into my dev branch. What is the oldest version of Matlab that should be tested for compatibility (I want to make sure changes I am making will work)?

Wee ensure backward compatibility to 2015b in the main matlab interface.


[Snyk] Fix for 1 vulnerabilities

Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

539/1000  Why? Has a fix available, CVSS 6.5
Cryptographic Weakness SNYK-JAVA-ORGSPRINGFRAMEWORKSECURITY-570204
org.springframework.security:spring-security-acl:  4.2.14.RELEASE -> 4.2.16.RELEASE  org.springframework.security:spring-security-cas:  4.2.14.RELEASE -> 4.2.16.RELEASE  org.springframework.security:spring-security-ldap:  4.2.14.RELEASE -> 4.2.16.RELEASE
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Coverage increased (+0.002%) to 28.058% when pulling 1fab53fc1c7daa8f70f43c323e15940232e730be on snyk-fix-46f274f1ddd2ad94e2744ec4de29ba01 into b519ecddc0dd104ea07f3ab9cc0cb6a7ff6118ac on master.

Codecov Report

Merging #247 (b519ecd) into master (b519ecd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #247   +/-   ##
=========================================
  Coverage     25.52%   25.52%
  Complexity     6761     6761
=========================================
  Files          1506     1506
  Lines         93537    93537
  Branches      13093    13093
=========================================
  Hits          23878    23878
  Misses        67287    67287
  Partials       2372     2372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b519ecd...1fab53f. Read the comment docs.


Update mixing_elbow_settings_api example to run in solver mode.

FYI the style check failure is because the branch name should start with docs in this case rather than doc https://actions.docs.ansys.com/version/stable/style-actions/index.html#branch-name-style-action
But can just ignore it, this style check failure should not block merging


city selection in region/city contextual dropdown not showing after selection

Goal
Show the selected city in region/city contextual dropdown
Problem
The city remains the original value of "--------" even after selection.  The back end capturing the selected city so something is working, but the city name is not showing in the selection dropdown.
Code Snippet
accounts.forms.py
class ProfileCreationForm(UserCreationForm, ModelSelect2Widget):
    location_region = forms.ModelChoiceField(queryset=USRegion.objects.all().order_by('name'), label="US Region (optional)", required=False)#widget=ModelSelect2Widget(model=USRegion, search_fields=['name__istartswith'])
    location_city = forms.ModelChoiceField(queryset=USCity.objects.all().order_by('name'), label="US City (optional)", required=False, widget=ModelSelect2Widget(model=USCity, dependent_fields={'location_region':'region_id'}, search_fields=['name__istartswith'], max_results=100))
    phone_number = forms.CharField(max_length = 32, required=False, label = "Phone number (optional)")
    first_name = forms.CharField(max_length = 255, required=True, help_text="Required.")
    last_name = forms.CharField(max_length=255, required=True, help_text="Required.")
    email = forms.EmailField(required=True, help_text="Required.")
    promo_code = forms.CharField(max_length=255, required=False, label="Promotional Code (optional)")

Hey @pmeleney,
Thanks for reaching out. I am sure we can find a solution. I am really glad you attached a screenshot. Just by looking at it, I can see that the second input seems to be a regular select input and not a Select2-JavaScript one.
Are you by any chance adding the City input dynamically after the state is selected? In that case, you need to initialize the select2 input first. You simply need to call execute the following JS code, after insert the select-tag into the DOM:
$your_select_element.djangoSelect2()

Please let me know, should this not solve the issue or ask any question you like.
Best
-Joe

Awesome.  Works like a charm.  Thanks so much!


List | FE | Spacing consistency and code clean up

Jira
http://vjira2:8080/browse/BDS-1610
http://vjira2:8080/browse/BDS-1671
Summary
Fixes the incorrect spacing for items in an inline or flex list with separators.
Details

Rewritten some of the CSS to make sure the spacing logics are correct.
Said logics are now commented and explained.
The spacing in a flex list with separators is now consistent with block and inline lists.
The spacing in the last item of an inline list with separators is removed.
Used the bolt-repeat-rule mixin wherever applicable, this fixes a few IE11 and no-js issues.

How to test
Pull down the branch locally and perform the following.
Check tests

[ ] 1. Given I have pulled down the branch locally
[ ] 2. And I am in the root folder
[ ] 3. When I run the command npx jest packages/components/bolt-list/__tests__/list.js
[ ] 4. Then I should see all tests indicated as "Pass"

Check inline list's last item spacing

[ ] 1. Given I am viewing the separator variations page
[ ] 2. When I am viewing each of the inline list sections
[ ] 3. Then I should see the list's last item does not have margin-right or padding-right

Check flex list's spacing

[ ] 1. Given I am viewing the separator variations page
[ ] 2. When I am comparing the flex list sections and the inline list sections
[ ] 3. Then I should see the same spacing in between items, the only difference would be flex list items' widths are evenly distributed while inline list items' widths fit to their content

Check flex lists in IE11

[ ] 1. Given I am viewing the display variations page
[ ] 2. And I am using IE11
[ ] 3. When I am viewing the Flex section
[ ] 4. Then I should see a horizontal list of items evenly distributed across the width of the browser.

Check testing instructions

[ ] 1. Given I am in the bolt-list component folder
[ ] 2. And I open the TESTING.md file
[ ] 3. When I go through the instructions text
[ ] 4. Then the text should be well formatted with clear information architecture
[ ] 5. And the instructions are intuitive and easy to follow without any typos

The Flex List with Separator Problem
We've had this problem since the component was released, and it wasn't discovered until I try to use the component extensively. Here's screenshot of the problem shown on master
Master

This breaks whenever the items do not have the exact same width and height. And the biggest problem is using overflow: hidden, this is a big no-no for any layout container, because it can cut off things that bleed, such as tooltips, dropdown, button shadows, card shadows, etc.
Expected Outcome

The expected outcome is to have it work similar to the action blocks component where the separators would all connect to create a grid.
Attempted Fix

Despite my best efforts and also ignoring the overflow: hidden problem, I still cannot get the separators to work as intended. And this is resulting in A LOT of messy code.
Compromise
This component is supposed to handle simple layouts and alignments, and I am very against using overflow: hidden. So I've come to this conclusion: keep the flex list simple. When changing the list's display to flex, it will only do exactly that. It will not do anything else that seems like magic. As displayed below, the ONLY difference between an inline list and a flex width would be that the flex list items would try to fill up the available space of its container.
This component is not widely used or implemented in Drupal, so it's safe to do this now.

Feedback
What do you think of the compromise? Is there a solution to this without using overflow: hidden that I am not aware of? Discuss. I am refreshing all the reviews for now.
@adamszalapski @danielamorse @sghoweri

@danielamorse No use case right now, it was originally intended to replicate the action blocks behavior. Also, I updated the text.

PR was released with v2.8.4-canary.bde01a443.0

PR was released with v2.9.0


slightly improve bash scripts :)

stumbled uppon the repo for a school project - so why not 😁

Thank you @EliSzBr for the PR!


Render Govspeak preview instead of plain Markdown

https://trello.com/c/77pWuPzi/170-render-govspeak-server-side
This commit changes the markdown-editor component to do an async query
to a new protected API that renders the passed Govspeak as HTML.
This requires the component to have knowledge of the API path via a new
data attribute, which is injected deep inside the component hierarchy.
If we were to move this component outside of the app, it ought to have a
default Govspeak rendering service it can use.
Rendering the markdown asynchronously has two error cases: network error
and application error. There's no evidence that an application error is
possible for this API, so we now only handle the network error in JS.
I also considered renaming markdown-* to govspeak-*, but it appears we
refer to 'govspeak' and 'markdown' interchangeably, so left as-is.

Comments should all be addressed now - @tijmenb the timeout is (arbitrarily) 5 secs :-).


[IMPROVEMENT] Add namespace argument/parameter to cli pre-flight check

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Related to pre-flight checks for a kubernetes cluster
Describe the solution you'd like
CLI pre-flight checks should have the option to choose a namespace to deploy to other than the default namespace.  (Similar to how a cli image can be chosen.)
add --preflight-namespace option to the cli to specify where the pre-flight checks will run.
Describe alternatives you've considered
no alternatives condsidered.
Additional context

should be labeled area/cli


Documentation about dealing with XML

I want to generate DefaultTexFont.xml from the TTF files we have.
Comments from jlatexmath maintainer were helpful, but I'm still struggling with that. Will document after I find everything out.

There's a python library called fonttools. It can extract the information from an open type font, such as the width(to 3decimal places), the name of the character, the Unicode code point of the character, etc however, the Kern property and a few others cannot be generated.

@B3zaleel yes, I have been using fonttools (also known as ttx) with some limited success. See the corresponding documentation on the current state of the matter.


Routing TCP traffic with original destination preserved through hops over multiple Envoys

Title: Routing TCP traffic with original destination preserved through hops over multiple Envoys
Description:

Is there a way to route original destination traffic over multiple Envoy hops? Here is the scheme I had in mind.

caller --> NAT rule ---> Envoy1 [original dst listener ---> Envoy2] ----> Envoy2 [original dst listener ---> original dst cluster] ---> original dst

The idea is that Envoy2 might terminate TLS or do some authentication and then forward the traffic to the original destination. Plus Envoy2 acts like a gateway / front-proxy for a set of services? I am trying to do this specifically for TCP traffic.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

You must find a carrier to deliver the "original dst" at each hop. Pure Tcp doesn't work.
The first hop is carried by NAT impl and the original can be obtained by socket opt SO_ORIGINAL_DST
There are various options at the 2nd hop, including mapping from TLS extensions, ProxyProtocol ,or HTTP CONNECT.
All the above 3 approaches can embed out of bound TCP data at handshake-ish phase so that you can some how recover the original_dst from


how to set [stable/percona-xtradb-cluster] use hostpath volume

As we all know, under the business scenario of large data volume, the read and write performance of local disk is superior to that of network Shared disk, so how to set [stable/percona-xtradb-cluster] to use hostpath instead of PVC?
thanks!!

Hi @lanyangkj
Did you ever find a solution for this? I'm been playing with Bitnami's master/slave helm chart, and I had to install the chart, then patch the pods to map the standard bitnami mysql data directory on the container, to the host path.
This worked, but i just kept hitting problems with the master/slave not syncing properly, I think because I was creating/destroying dev environments often.
So I thought I'd try Percona cluster, and encountered the same problem as you - I can only think of patching again as the solution to this.


Execution of click event in v-for area in combination with change of outer ref triggers re-rendering of whole list

Vue version
3.4.18
Link to minimal reproduction
https://play.vuejs.org/#eNqlVE1v2zAM/SuMLkmQrxa9pUn30XXYdtiKbkAP0w6ezdhqZcmQ6KSG4f8+Sk7SDCt62cW2yCfy8elZrXhXVfNtjWIpVj51qiLwSHV1JY0qK+sIWnC4gQ42zpYwZOhQGmlSazxB7dF5WAfE6Oev8aU0iwVslNZ9RpqNdSONBIpBZ5f8WsH52Vn4mkzGrTTQA+fbRNc4r2pfjFqVLUFNwSQlLkGKAJACJqC60KCD0J7b3GpMPIKxxDAqlI88i8SHUKFMDmQhs7BTVHAeYTtjNpA4TA70S5/vyQ8/odYW7q3T2WA43re41ip9BGsgAc8FNUa2kJgMdoXlpVZcZRfm/Y1cZ+bQZOgwGxw7NLHGzRYNcavRGNZXEOfm8qktyxC3NYHBJ+JyBqexfOB7rBdmCdRxi64B3sFPT7ZifSHM0KsHkzWrBfdFw1Oj7yUhp/I8UGaKirDkiH0u/EaKoOh+WgVpYpiU2ShXTv+lwMJp3bDCVYXGTwMdA2oDja3Blorijo1lHXcBXqCuuHOJVNisd08AMIlKJ4QHhR5qTx+t+4CEKd3hXWz3l1QBx2LPtc1HUhwpDaTgc4rkV4veumxaXhw68ApgNZjN/lvn2ayvVZxftS0L3nWrBX/HWK3jm7+06i227j0Lyuz/AgHLR2z24bnKOPA2Dbbg0KlBRmPOeGo0ciKtnbduCZVVhtBdSrHv07axTPg9Op6+D72o4mgciGrVE11EpqvFiTxiKsjHA8/nD94avgSiN7m7LSul0X2rSLH8Uix714Ycu8DuvsQYuRqnh3haYPr4QvzBP4WYFLcOmfkWpTjmKHE5Up+++f6VD+ckWdqs1ox+JXmHbI06cOxh72uTMe0TXGT7OV5lfL4//M0TsXsPQwWiAdlFvBR8vV2/Mvoz3Yv5RdzHDhTdHz0Wyg8=
Steps to reproduce
Please take a look at the playground. Open the devtools to see the log. Click on a user.
What is expected?
No re-rendering at all, when clicking on an item, when there are no changes within the v-for area.
What is actually happening?
The execution of the click event in the v-for area in combination with change of outer ref actually triggers re-rendering of whole list.
System Info
Tested on current Firefox, Chrome, Edge

Any additional comments?
For larger lists and/or bigger templates this leads to slow performance. I have a list of 300 users and a click on a user opens a simple edit modal. This takes almost 2 seconds, because the whole list is re-rendered at click!

Is this by design?

That's how Virtual DOMs work. Re-render the whole virtual dom tree (of this component), then diff it to determine necessary patches.
If you need to optimize this. consider

moving the list into its own component, or
using v-memo to manually control when list vnodes should be skipped in re-renders

@LinusBorg Thank you for the explanations! I implemented the first variant and the result is now a super performant app. That was very enlightening.


Squash new provider user flow bugs

Context
Some bugs were identified after the new single provider flow and bulk provider user flows were deployed to prod.
Note not all bugs have been addressed. Please see comments on Trello ticket.
Changes proposed in this pull request
Squashed bugs

Provider users page - Users should be listed alphabetically by name
Add single provider user flow - The back button doesn't take you back to the providers/{{providerId}}/users but rather users/provider
Add bulk users flow - If clicking change on check answers and going to the user details page, if I click the back link it should take me to the check answers page, not the previous form page.
Add bulk users flow - If clicking change on check answers and going to the user details page, make a change to something and it errors, if I click the back link, I get a page not found error. The user should be taken back to the check answers page

Link to Trello card
https://trello.com/c/XfUnWnPz/3562-new-provider-user-flow-bugs
Things to check

[x] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

Oh dear - all those commits should not be there. Think this happened after I renamed my master branch to main locally?

@TobyRet please hold off renaming the branch until Monday, as we've not done the switch yet, and it will be a big bang change for the day


Replacing occurences of sh with  shell

Change all the code highlighting from sh to shell so it is consistent across the documentation

closing this PR as it is not correct see https://github.com/influxdata/docs.influxdata.com/issues/232#issuecomment-183129651


Enhancing the User Interface

proper spacing in the OUR EVENTS section

please assign this task to me. Thank you


Having a hard time deploying this container

Hello,
I was able to deploy this on my local machine and it worked very well (thank you!), however, when I tried moving it to my NAS, things were not as smooth as I would've hoped them to be.
My setup is as follows:
Synology NAS with 2 containers:

nginx
nodepki

Nginx container is essentially a reverse proxy for my other services. So, when I go to https://myservice.mydomain.com, nginx will proxy_pass to an internal url. I thought that I would do the same thing with nodepki, but I cannot figure out proper environment variables for everything to just work. All my service subdomains have a Let's Encrypt cert installed, so I have the following connection flow: Internet ----> SSL ---> NGinx ---> HTTP ----> service
I am trying to have all the services on a single subdomain (say, certification.mydomain.com), instead of multiple. I have also used your nginx template from main readme file, where different services are at different locations.
I am pretty sure that the issue is with environment variables, but I am not sure.

Thanks for your help!

Hello,
I just do a very smalls adaptations to make nodepki docker compliant:
https://github.com/cyjanssens/nodekpi-docker-service
Hope this help you.


Need to check for USB permissions before running adb commands

Right now, the script only shows the udev permissions script if fastboot shows no permissions. But it's possible that adb itself doesn't have the right USB permissions too, so we need to show the udev permissions script in this case too.
We can check for this right at the beginning and prompt the user to run the wget script,

Update: this will be fixed with the new Go installers.

@pdsouza , This issue has been fixed by your old commit, maybe it can be closed.

@utzcoz I think the installers only show the script if fastboot shows a permission error but we need to check adb too since we use adb reboot bootloader.
I actually have fixed this in the new go installers on branch go-installers which fetch the releases directly from GitHub. Since we are shipping the update zips directly for users to install with TWRP I haven't prioritized them very much though. I think I can extend them to flash the images directly like these scripts too.

Ok, I got it. Hope go-installer can be merged to master quickly.


Add tests for all necessary solvent types

Related to #2
Solvent packing isn't super stable and often seems to require solvent specific packing parameters.
We should at the very least try to make sure we can solvate boxes with all the different necessary solvent types.

As requested from Slack and cross-posting from Slack and email.

min-sage-benchmark-smiles.smi: these are the minimum we'd be after for support, to reproduce the Sage benchmarks.
extra-nice-to-have-solvents.smi: these include further solvents that would be great but are only given as a nice-to-have on the off-chance that they're easy, or in case you wanted insight into further work OpenFF might do
all-unique-solvent-smiles.smi: these are just all the solvents in the previous two files.

min-sage-benchmark-smiles.smi.txt
extra-nice-to-have-solvents.smi.txt
all-unique-solvent-smiles.smi.txt


React native s3 upload fails in android

I'm trying to post image to s3 via s3.upload in react native app. This function works good in iOS, but fails only in android.
But when i enable network in debugger, then images are been posted.
React native version : 0.63.4
Went through various solution like,

Changing FLIPPER version.
Commenting FLIPPER code.
Adding manifest files code with android:usesCleartextTraffic="true".
Adding network config xml in android.

But none of them didn't work. Please let us know the solution if anyone faced same issue in react native android app.
Thanks in advance
const params = {
Bucket: "my.bucket",
Key: filename/uuid.jpg,
ContentType: file.mime,
Body: arrayBufferData,
ContentEncoding: 'base64',
ACL: 'public-read',
};
s3.upload(
  params,
  (err, data) => {
    if (err) {
      console.log(err)
      return reject(err);
    }return resolve(data);
  },
);

Closed adding Signatureversion:v2