CancelImageLoadOperation may cause this bug?

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
ios

Platform Version
9.0

SDWebImage Version
3.8.2

Integration Method
cocoapods

Xcode Version
Xcode 8.3.2

Repro rate
all the time (100%) /

Repro with our demo prj

Demo project link

Reset the URL for UIImageViewA will cause empty Image for UIImageViewB?
I've read the SDWebImage code, and found a bug(maybe) for SDWebImage.
- (void)sd_setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholder options:(SDWebImageOptions)options progress:(SDWebImageDownloaderProgressBlock)progressBlock completed:(SDWebImageCompletionBlock)completedBlock {
    [self sd_cancelCurrentImageLoad];
    //...
}

the problem is that what if UIImageViewA and UIImageViewB got the same URL, and then UIImageViewA  set a new URL, but UIImageViewB didn't change the URL.
Because UIImageViewA set a new URL. the first thing it will do is cancel the NSOperation. but this operation is shared with UIImageViewB. So UIImageViewB will got the cancel operation and will not get the image.
To test that,  the following code will show that self.imageViewB could not get the image:
    NSArray *image = @[
                       @"http://www.weipet.cn/bixiong/images/pic/43.jpg",
                       @"http://www.weipet.cn/bixiong/images/pic/9086309.jpg",
                       @"http://c1.cdn.goumin.com/cms/petschool/day_141210/20141210_8ae7939.png",
                       @"http://desk.fd.zol-img.com.cn/t_s1680x1050c5/g5/M00/02/03/ChMkJ1bKxtqIXy1OAAi9LK5qQwgAALHrQK3PAoACL1E420.jpg",
                       @"http://www.redmaplenews.com/bbs/data/attachment/forum/201301/30/223812ejfibjevvj3n3ldh.jpg",
                       @"http://www.weipet.cn/bixiong/images/pic/b2-1.jpg",
                       @"https://4.bp.blogspot.com/-Uc1cshYSKy0/VyFnyanxMqI/AAAAAAAAAGM/JB2IH9UuTSIJ1CCqLHwOFIGIIUL7GRlVACKgB/s1600/201404211123518834.jpg"];
    for (int i = 0; i < image.count; i++) {
        UIImageView *imageView = [[UIImageView alloc] init];
        [imageView sd_setImageWithURL:image[i]];
    }
//make sure the  imageViewA's operation and imageViewB's operation doesn't execute

     [self.imageViewA sd_setImageWithURL:@"https://timgsa.baidu.com/timg?image&quality=80&size=b9999_10000&sec=1502713596019&di=81318f5c8b5383978012eccad023ca31&imgtype=0&src=http%3A%2F%2Fatt.bbs.duowan.com%2Fforum%2F201406%2F20%2F114126lmv3zmpnozckkllq.jpg"];

    [self.imageViewB sd_setImageWithURL:@"https://timgsa.baidu.com/timg?image&quality=80&size=b9999_10000&sec=1502713596019&di=81318f5c8b5383978012eccad023ca31&imgtype=0&src=http%3A%2F%2Fatt.bbs.duowan.com%2Fforum%2F201406%2F20%2F114126lmv3zmpnozckkllq.jpg"];
    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 1 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{
        [self.imageViewA sd_setImageWithURL:@"https://timgsa.baidu.com/timg?image&quality=80&size=b9999_10000&sec=1502713596019&di=ba893d856490e04de7bc5a800b21c167&imgtype=0&src=http%3A%2F%2Fimg3.duitang.com%2Fuploads%2Fitem%2F201202%2F24%2F20120224114616_wxxGx.jpg"];
      //reset the imageViewA's URL will also cancel imageViewB's operation. So is this a bug?
    });

show your code

Your worry about this case will not happens in SD 4.0. I check the code, for each URL, we will actually create only one NSOperation. But it can hold an array of callbacks for each progress block and completion block which passed by sd_setImageWithURL:.
For example, the code you provide will create an shared NSOpeartion op for actual download.
UIImageViewA's completion block blockA will cause op.callbacks[0] = blockA (In fact, we have progress block and completion block so the item is an tuple like NSDictionary<NSString, dispatch_block_t>, but we keep things simple here).
UIImageViewB's completion block blockB will cause op.callbacks[1] = blockB.
When one call cancel, it will check whether the op.callbacks.count > 0 and only if it's empty, we cancel the internal NSURLSessionTask. So the example code above will not cause bugs.
You can check the code here : https://github.com/rs/SDWebImage/blob/master/SDWebImage/SDWebImageDownloaderOperation.m#L111

Sadly it seems that old version SD 3.8.x do not have this consideration for this edge case. It just cancel the NSURLSessionTask whenever it received cancel call. So it may cause the bug you show.
You can see the code here:
https://github.com/rs/SDWebImage/blob/3.8.2/SDWebImage/SDWebImageDownloaderOperation.m#189

@VioletHill it's very important for us that you fill in the issue template, not leave the default values there. Please update it so we know which version you are talking about and more

@bpoplauschi Sorry for that didn't fill the issue template well. I will update soon
and  thanks for @dreampiggy.


[Bug]:

How it work this method anyone help me or explain me
coolify
Using coolify how to setup Automatic deployment of docker-compose application via github ??


I'm already logged in，but micro v3 Wrapper An account is required [BUG]

Describe the bug
I'm already logged in,
--- admin micro
micro login
Just remove this line and it will work correctly
service.WrapClient(NewLogWrapper),

How to reproduce the bug:
package main

import (
	"context"
	"github.com/micro/micro/v3/service"
	"github.com/micro/micro/v3/service/client"
	"github.com/micro/micro/v3/service/logger"
	"github.com/micro/services/helloworld/handler"
)

type logWrapper struct {
	client.Client
}
func (logW *logWrapper) Call(ctx context.Context, req client.Request, rsp interface{}, opts ...client.CallOption) error {
// do something
	return logW.Client.Call(ctx, req, rsp)
}

func NewLogWrapper(c client.Client) client.Client {
	return &logWrapper{c}
}

func main() {
	// Create service
	srv := service.New(
		service.Name("helloworld"),
		service.WrapClient(NewLogWrapper), // Just remove this line and it will work correctly, then won't report need an accout，How can I solve this problem?
	)

	// Register Handler
	srv.Handle(new(handler.Helloworld))
	// Run the service
	if err := srv.Run(); err != nil {
		logger.Fatal(err)
	}

}

Environment:
go version go1.14.10 darwin/amd64
micro version v3.0.0-beta

Please upgrade to the latest version of the beta.

Also this is the completely wrong repository.

Also this is the completely wrong repository.

My fault, this wrapper is divided into client and server

func logWrapper(fn server.HandlerFunc) server.HandlerFunc {
	return func(ctx context.Context, req server.Request, rsp interface{}) error {
		err := fn(ctx, req, rsp)
		return err
	}
}

#####in the main function
service.WrapHandler(logWrapper),


Add RHEL9 build instructions

Summary of changes
Added build instructions for RHEL9.
Description
Since fuse3 is the default package on RHEL9, ltfs won't build. This requires building fuse 2.99 from source.
Type of change

Documentation

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have confirmed my fix is effective or that my feature works

Can you point me to where in any RHEL9 repo the packages you mentioned are available?
I've searched before, and the only thing I found in the repo is fuse3 - not fuse2. I tried building with fuse3 and it simply doesn't want to play ball with ltfs.
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/package_manifest/repositories#CodeReadyLinuxBuilder-repository

Can you point me to where in any RHEL9 repo the packages you mentioned are available? I've searched before, and the only thing I found in the repo is fuse3 - not fuse2. I tried building with fuse3 and it simply doesn't want to play ball with ltfs.

For RHEL9, I can find a doc below. It says fuse-devel package was MOVED from rhel8-BaseOS repository to rhel9-CRB in RHEL9. Please contact to RedHat if you cannot find fuse-devel package on your system.
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/considerations_in_adopting_rhel_9/assembly_changes-to-packages_considerations-in-adopting-rhel-9
I don't use RHEL at all now because I have no license. But RockyLinux shall be a complete clone of RHEL. On RockyLinux9, I used the command dnf config-manager --set-enabled crb for enabling CRB, installed fuse-devel successfully and finally build the LTFS source successfully.

Hi, as always - thank you for being as helpful as you are. I'm genuinely
impressed with your dedication to this project. I will modify my pull
request soon and I will look into RockyLinux as well.
On Sat, Oct 19, 2024 at 12:45 PM Atsushi Abe @.***>
wrote:

Can you point me to where in any RHEL9 repo the packages you mentioned are
available? I've searched before, and the only thing I found in the repo is
fuse3 - not fuse2. I tried building with fuse3 and it simply doesn't want
to play ball with ltfs.
For RHEL9, I can find a doc below. It says fuse-devel package was MOVED
from rhel8-BaseOS repository to rhel9-CRB in RHEL9. Please contact to
RedHat if you cannot find fuse-devel package on your system.
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/considerations_in_adopting_rhel_9/assembly_changes-to-packages_considerations-in-adopting-rhel-9
I don't use RHEL at all now because I have no license. But RockyLinux
shall be a complete clone of RHEL. On RockyLinux9, I used the command dnf
config-manager --set-enabled crb for enabling CRB, installed fuse-devel
successfully and finally build the LTFS source successfully.
—
Reply to this email directly, view it on GitHub
https://github.com/LinearTapeFileSystem/ltfs/pull/486#issuecomment-2423755372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJ76ID22SKWJUJ4VNBCULLZ4IZ25AVCNFSM6AAAAABP6ISJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTG42TKMZXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Philip Butkiewicz
T: +81 50 5534 5261


Make the 64Drive's button usable for something

The button on the back of the 64Drive cartridge is useless, but can be programmed to do whatever the developer wants. Would be a cool feature to allow the developers to map a function to the button.

Added in 0cf8a42.


Develop: Add "Back" gesture

As a user on any page of the application other than "Home", I want to be able to swipe right from the left screen edge to go back to the previous page.
Acceptance Criteria

User can swipe right from the edge of the screen to navigate back to the previous page they were on
Action does nothing if on the homepage
Action should not trigger navigation between emails, as that is a swipe right from within the display
Document any relevant content in the Programmer guide (draft thoughts of usage and importantly the "Why")
Updates SRS and STP (and other docs if necessary)
Add/Update relevant unit tests

Using CupertinoPageRoute to create this feature for going back.  This will be applied for Android and iOS.


bamdone-ieeeconf:0.1.1

I am submitting

[ ] a new package
[x] an update for a package

Description: Fixed the figure numbering issue where it starts at 2 instead of 1

[X] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thank you.


fix: This fixes the border issue for the table v1 widget (#18322).

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description
This fixes a UX issue in the table v1 widget. Under the filters and download button the border appear to be missing, this commit fixes it.

Add a TL;DR when description is extra long (helps content team)

Fixes #18322

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

LGTM . Pls proceed


Link database to project

Goal: create mysql or postgres

Goal: create mysql or postgres database as the backend

UPDATE: now using Firebase instead of a relational database


Drop legacy Parser and ActionBuilder APIs

I think it's been long enough. Will of course need to be documented in changelogs :)

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (2747411) 97.98% compared to head (22433d0) 97.96%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   97.98%   97.96%   -0.02%
==========================================
  Files          71       69       -2
  Lines        2726     2700      -26
==========================================
- Hits         2671     2645      -26
  Misses         55       55

Impacted Files
Coverage Δ

src/dynamicprompts/parser/parse.py
98.78% <100.00%> (-0.09%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


int for tokens instead of wei; deploy contracts to sepolia

1. Added steps to deploy to Sepolia. Resulting Token contract
2. Changed token amounts to whole numbers
2a. Go code from:
collateral := big.NewInt(0)

to:
collateral := EtherToWei(0)

2b. Hardhat tests from:
ethers.getBigInt(1),

to
ethers.parseEther("1"),

3. Added fields to .env file to support other chains:
export INFURA_KEY=
export LOG_LEVEL=info
export NETWORK=geth
export WEB3_RPC_URL=ws://localhost:8546
export WEB3_CHAIN_ID=1337

This looks great thank you! Please resolve the conflicts and again, confirm with a manual test that devstack is still working.
Will this require any changes to environment for the testnet? I e any deploy time considerations?

@lukemarsden I resolved the conflicts and retested the devstack.
This should create no issues for the testnet.

great, approved! please merge :)

and thank you!


not able to login to an oracle instance using .usqlpass entry...

I am able to login to an oracle instance using usql and dburl at the command line. But if I put the password entry in ~/.usqlpass file, it complains about incorrect password. My assumption is that may be oracle entry in .usqlpass file has a different format
Following is the format of the oracle password entry in .usqlpass
or:ORACLE_HOST:SQLNET_PORT:1521:ORACLE_SID:USER:PASSWORD
my usql command line is
$ usql or://USERi@ORACLE_HOST:SQLNET_PORT/ORACLE_SID
And it returns the following error message
error: ora: ORA-01017: invalid username/password; logon denied
Enter password:
What am I missing? (I have doubly checked the .usqlpass entry for typos)

Please try this:
ora:*:*:*:user:pass

I believe the issue is that you need to use the ora as the driver name. I believe the usqlpass implementation doesn't respect the driver aliases. I'll make a point of adding that functionality.


Messaging: clarify network attributes usage on common semconv

Changes
Addresses messaging portion of #690
Removes network attributes from general messaging semantic conventions.
Based on the findings from Java instrumentation libraries, the only messaging instrumentation that populates network attributes is RabbitMQ (which also sets them in native .NET instrumentation).  This PR adds network.server.address|port on the rabbitmq extension.
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[x] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

schema-next.yaml

From the messaging point of view, I'd agree to merge those changes.

Looking into java instrumentation repo:
Messaging systems:

report only network attributes:

rabbitmq, but reporting network stuff is not straightforward involving thread locals, passing things through otel context

report server and network attributes:

aws sns/sqs server and only network.protocol.verion out of all network attributes

report server attributes only:

pulsar

report no server/network attributes at all: kafka, rocketmq

Databases:

report only network:

cassandra
Redisson

report only server:

jdbc
mongo
r2
vertxsql
elastic rest

report both, server and network attributes:

dynamodb (also reports network.protocol.verion, but no other network)
jedis (depends on the version)
lettuce
vertx redis
elastic-transport
opensearch

report nothing (no network or server):  geodedb, Rediscala, Spymemcached

All instrumentations that report network, report only network.peer.address|port and some report network.type. I could not find any that reports protocol name or transport.
I probably missed something, but I think there is enough evidence.

server.* or network attributes cannot be required on DB or messaging
I think instrumentations that support network, but don't report server.address should try by calling getHostName() on Inet*Address they already have
I still want to remove network from general db, we keep it for redis, cassandra, and elastic.
I still want to remove network from general messaging, but want to keep them for rabbitmq

Looking into java instrumentation repo:

Thanks @lmolkova for this research.
To add one more datapoint, the .NET RabbitMQ instrumentation populates both network and server attributes (if they are available):

network.peer.address
network.peer.port
network.local.address
network.local.port
network.type
network.protocol.name
network.protocol.version
server.address
server.port

Based on the discussion in Messaging SIG, breaking this one down into two PRs. This one contains messaging portion only.
Will send a separate one for DBs.

Based on the database discussion on similar PR https://github.com/open-telemetry/semantic-conventions/pull/768#issuecomment-1986534133, I updated this one to be consistent with databases:

removed network.transport|type
kept network.peer.* in common, but clarified they apply for self-hosted systems where they make sense


Cannot execute pipenv shell properly

See the following output:
➜  test-pipenv pipenv --three
Creating a Pipfile for this project...
Creating a virtualenv for this project...
⠋Running virtualenv with interpreter /usr/bin/python3
Using base prefix '/usr'
New python executable in /home/florian/.virtualenvs/test-pipenv/bin/python3
Also creating executable in /home/florian/.virtualenvs/test-pipenv/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /home/florian/.virtualenvs/test-pipenv
➜  test-pipenv pipenv install Django
Installing Django...
Collecting Django
  Using cached Django-1.10.5-py2.py3-none-any.whl
Installing collected packages: Django
Successfully installed Django-1.10.5

Adding Django to Pipfile's [packages]...
➜  test-pipenv pipenv shell
Launching subshell in virtual environment. Type 'exit' or 'Ctrl+D' to return.
/home/florian/.virtualenvs/test-pipenv/bin/python: Error while finding module specification for 'virtualenvwrapper.hook_loader' (ImportError: No module named 'virtualenvwrapper')
virtualenvwrapper.sh: There was a problem running the initialization hooks.

If Python could not import the module virtualenvwrapper.hook_loader,
check that virtualenvwrapper has been installed for
VIRTUALENVWRAPPER_PYTHON=/home/florian/.virtualenvs/test-pipenv/bin/python and that PATH is
set properly.
➜  test-pipenv env|grep VIRTUAL
VIRTUALENVWRAPPER_SCRIPT=/home/florian/.local/bin/virtualenvwrapper.sh
VIRTUALENVWRAPPER_PROJECT_FILENAME=.project
VIRTUALENVWRAPPER_WORKON_CD=1
VIRTUALENVWRAPPER_HOOK_DIR=/home/florian/.virtualenvs
VIRTUAL_ENV=/home/florian/.virtualenvs/test-pipenv
➜  test-pipenv which python
/home/florian/.virtualenvs/test-pipenv/bin/python

As you can see VIRTUAL_ENV is set properly and which python returns the one from the venv, but it looks like as if the executed shell is sourcing my profile again.
I am using virtualenv-wrapper manually without problems. My .zshrc has
source ~/.local/bin/virtualenvwrapper.sh

Is the anything I can do to get around this error? Please tell me if (and which) information you need.

export VIRTUALENVWRAPPER_PYTHON=/usr/bin/python

before sourcing the wrapper script did help -- not sure if that is a bug at all, or in which component it is :)

@apollo13 could you verify for me that virtualenvwrapper is installed inside your pipenv environment with the command pipenv run pip freeze? I'm pretty sure this is an issue of the script you're sourcing assuming that virtualenvwrapper is already installed when it hasn't been added to that environment.
We don't officially support virtualenvwrapper right now and there's a possibility there's conflicting functionality, but I'm happy to take a look if the above isn't true.

@nateprewitt Yes, virtualenvwrapper is not installed in the pipenv venv. The virtualenvwrapper zsh hook tries to find it's python via this: https://bitbucket.org/virtualenvwrapper/virtualenvwrapper/src/cee707f128e39623718568b47b6038e8d62c5f34/virtualenvwrapper.sh?at=master&fileviewer=file-view-default#virtualenvwrapper.sh-47:51 -- which obviously breaks for venvs.

Yeah, so given this startup script in your profile, you'll either need to install virtualenvwrapper inside your pipenv environment before running the shell. I think that's the only advice we can give at this point since I wouldn't consider this a bug in popenv

FWIW I worked around this by only sourcing virtualenvwrapper.sh if pipenv is not currently active, because if I'm using pipenv I'm probably not going to need virtualenvwrapper anyway. My .zshrc now goes like this:
if [ "$PIPENV_ACTIVE" != '1' ]; then
    [ -f /usr/local/bin/virtualenvwrapper.sh ] && source /usr/local/bin/virtualenvwrapper.sh
fi


Benchmark on pr

just testing CI

Codecov Report

Merging #2 (e7ab53f) into periodic_benchmarks (0831ed3) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           periodic_benchmarks       #2   +/-   ##
====================================================
  Coverage                98.14%   98.14%
====================================================
  Files                      272      272
  Lines                    15515    15515
====================================================
  Hits                     15227    15227
  Misses                     288      288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0831ed3...8ca515a. Read the comment docs.

Codecov Report

Merging #2 (e7ab53f) into periodic_benchmarks (0831ed3) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           periodic_benchmarks       #2   +/-   ##
====================================================
  Coverage                98.14%   98.14%
====================================================
  Files                      272      272
  Lines                    15515    15515
====================================================
  Hits                     15227    15227
  Misses                     288      288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0831ed3...8ca515a. Read the comment docs.


Footer

[o] icons in footer need color adding

leave as is until next upgrade add chat interaction app


Html Files doesn't reload when using ng-include in angularjs

Hello, we are using yii2 together with angularjs. We encountered a problem when using ng-include in angularjs to include partial html templates. We are also using stateProvider of angular and binding it to ui-view. The request goes first to yii and then renders the html using ui-view. Is this a problem in assets manager or does yii caches the html files?

update: when i open that static html page using chrome developer tools it reloads

Then it looks like a problem with Angular and we can't fix it from Yii side.


Fix missing Agda import

This is just fixing an import that became outdated after merging #5730: see the comments there for more details.  I'll auto-merge it to get master working again.

Gah. This failed after merging with

error: some substitutes for the outputs of derivation '/nix/store/3zw2qwjvqh8a0s1cnzb6mvms7vk99y2p-hadrian-source.drv' failed (usually happens due to networking issues); try '--fallback' to build derivation from source

I think the original problem should be fixed though, so I won't try to fix that.


Fix to accommodate arrow functions and their lack of a prototype.

While trying to implement testing, I was getting the error:

Cannot read property 'isReactComponent' of undefined

After some diligent internet scouring, I came across a similar issue on react-table, where they came to the conclusion that the lack of a prototype on arrow functions was the root cause and the method that they had in place to normalize, didn't cover that.  @rpalermodrums suggested using Object.getPrototypeOf as a solution. It works for me locally, so fingers crossed. I'm still a little new to software engineering, so I can't say that I'm fully confident that I understand what the potential ramifications are, although it seems pretty straight-forward. Please don't kill me.

Can this be merged?

Why was it closed? :( I have the same problem with arrow function components


DOCS: disable jinja

I want to send a complex email: css and sh*t. I don't need jinja for this email, but I get errors when sending the email, since the css syntax tricks the jinja parser. Could fix it, double curly braces everywhere, but:
Is there a way to send the html without jinja parsing?
Regards
Traceback (most recent call last):
  File "./test_embed_redmail.py", line 136, in <module>
    email.send(
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/sender.py", line 260, in send
    msg = self.get_message(
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/sender.py", line 334, in get_message
    body.attach(
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/body.py", line 113, in attach
    html, cids = self.render(
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/body.py", line 173, in render
    html = super().render(html, tables=tables, jinja_params=jinja_params)
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/body.py", line 76, in render
    return self.render_body(cont, jinja_params={**tables, **jinja_params})
  File "/usr/local/lib/python3.8/dist-packages/redmail/email/body.py", line 51, in render_body
    template = Environment().from_string(body)
  File "/home/user/.local/lib/python3.8/site-packages/jinja2/environment.py", line 1092, in from_string
    return cls.from_code(self, self.compile(source), gs, None)
  File "/home/user/.local/lib/python3.8/site-packages/jinja2/environment.py", line 757, in compile
    self.handle_exception(source=source_hint)
  File "/home/user/.local/lib/python3.8/site-packages/jinja2/environment.py", line 925, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<unknown>", line 11, in template
jinja2.exceptions.TemplateSyntaxError: expected token 'end of print statement', got ':'

Unfortunately, there is no elegant option. You could set the body to just {{ content }} and pass the actual content using the jinja_params. Put it as markupsafe.Markup so Jinja considers the thing safe and does not add any escaping.
I have thought maybe there might be a situation where one would like to disable it but could not come up with such where it is necessary. It sounds like in your case it is. I have plans to do a new release very soon and I actually already solved this already. I'll add a new argument use_jinja that is true by default but can be set false to prevent Jinja templating. Need to write a bit of docs though.


Add event verification to web hooks

Based on https://stripe.com/docs/guides/subscriptions#verifying-events

A little scary this isn't on by default. Perhaps we should raise Forbidden instead so that hits various logging points?

(hm, or SuspiciousOperation..)


Support for Tang Nano 20K

Is there any plans on extending support to Tang Nano 20K?

+1

https://github.com/lushaylabs/lushay-code/blob/main/src/utils/device-info.ts
here you can see that 20k is listed.
i have installed and looks like its working. will try later

Hi, support for the Tang Nano 20K was added here (constraints editor/project file) before it was added to the open-source toolchain for actually creating the bitstream so I still need to test it there, if I remember correctly it was only tested using the cloud toolchain.
I did see that the new nextpnr himbaechel version and corresponding apicula update do support the Tang Nano 20K, but I don't think they are in OSS-CAD-Suite, I will test it out since if not then it would require manually building nextpnr with the himbaechel flags, maybe I can add settings to easily override versions of specific tools in the open source toolchain to make it easier to work with

I tested nextpnr himbaechel version on linux, then you counter example worked as good.
To build the program which requires python 3.9, I used ubuntu 22.04 linux as a host.
At first recent oss-cad-suite (I used 231205 version) was installed, added bin path to .bashrc file.
And apycula module have to be installed.
$ sudo pip3 install apycula
Then I downloaded the nextpnr source and configured cmake build.
$ git clone https://github.com/YosysHQ/nextpnr`
$ cmake .. -DARCH=himbaechel -DHIMBAECHEL_GOWIN_DEVICES=all -DCMAKE_INSTALL_PREFIX=<oss-cad-suite install dir>

And build and install it into oss-cad-suite.
$ make
$ make install

You create counter example and setup Makefile as follows. THe family name of tangnano20k is GW2AR-18C, but the nextpnr hasn't the family, instead I used GW2A-18C.
BOARD=tangnano20k
FAMILY=GW2A-18C
DEVICE=GW2AR-LV18QN88C8/I7
all: counter.fs

# Place and Route
counter_pnr.json: counter.json
        nextpnr-himbaechel --json counter.json --freq 27 --write counter_pnr.json --device ${DEVICE} --vopt family=${FAMILY} --vopt cst=${BOARD}.cst

# Generate Bitstream
counter.fs: counter_pnr.json
        gowin_pack -d ${FAMILY} -o counter.fs counter_pnr.json

# Program Board
load: counter.fs
        openFPGALoader -b ${BOARD} counter.fs -f

clean:
        rm counter.fs

.PHONY: load clean
.INTERMEDIATE: counter_pnr.json counter.json

Then build counter_pnr.json by nextpnr-himbaechel. I got next message with no fmax available.
$ make
…
Info: No Fmax available; no interior timing paths found in design.
Info: Checksum: 0x5aafc6c1
Info: Routing globals...

Info: Routing..
Info: Setting up routing queue.
Info: Routing 669 arcs.
Info:            |   (re-)routed arcs  |   delta    | remaining|       time spent     |
Info:    IterCnt |  w/ripup   wo/ripup |  w/r  wo/r |      arcs| batch(sec) total(sec)|
Info:        703 |       16        477 |   16   477 |         0|       2.79       2.79|
Info: Routing complete.
Info: Router1 time 2.79s
Info: Checksum: 0x2eedabbc

Info: No Fmax available; no interior timing paths found in design.

Info: Program finished normally.
gowin_pack -d GW2A-18C -o blink.fs blink_pnr.json
rm blink_pnr.json

Finally the binary code can be downloaded and the leds on board would be blinked.
$ make load


"ng new" not working, says there is a syntax error

I am trying to start a new Angular project and have used Angular CLI before and it worked, however I cannot get "ng new" to work now. I have uninstalled and reinstalled angular cli, and I have the most up to date versions of node and npm.
When I try to use "ng new angular-project" now this is what I get:
/usr/local/lib/node_modules/@angular/cli/bin/ng:23
);
^
SyntaxError: Unexpected token )
at Object.exports.runInThisContext (vm.js:78:16)
at Module._compile (module.js:543:28)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.runMain (module.js:605:10)
at run (bootstrap_node.js:420:7)
at startup (bootstrap_node.js:139:9)
at bootstrap_node.js:535:3
Not sure what else I am missing. Any help is appreciated!

Can you provide the output of node --version from the same location the ng new was attempted?

node --version
v7.4.0
On Mon, Apr 13, 2020 at 3:06 PM Charles<EMAIL_ADDRESS>wrote:

Can you provide the output of node --version from the same location the ng
new was attempted?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/17462#issuecomment-613045855,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHYQPZS3CPVIYJRSX2MFLLRMNPCTANCNFSM4MHELFLQ
.

The Angular CLI requires a minimum Node.js version of v10.13 with v12 recommended for optimal performance.
Can you try updating the Node.js version to see if that resolves the problem?

That fixed it. I apologize, I had run command line functions to update, but
I guess I did something wrong on that part. Sorry for wasting your time,
but thank you for the help!
-Chase
On Mon, Apr 13, 2020 at 3:14 PM Charles<EMAIL_ADDRESS>wrote:

The Angular CLI requires a minimum Node.js version of v10.13 with v12
recommended for optimal performance.
Can you try updating the Node.js https://nodejs.org/ version to see if
that resolves the problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/17462#issuecomment-613049432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHYQPZ3IJZUIRW4WWEGUXTRMNQANANCNFSM4MHELFLQ
.

No problem at all.  I'm glad it's working now.
I put together a fix so that users should get a message instead of a syntax error in the future.


Authenticating via Visual Studio only seems to work if the TenantId is supplied -- is that correct?

With regard to Visual Studio credentials -- see my StackOverflow post at:
https://stackoverflow.com/questions/70869615/visual-studio-2019-tokenservice-exe-has-failed-with-unexpected-error-ts003-err
I would like some clarification in the documentation with regard to what values (if any) are required when using the DefaultAzureCredentialOptions.  class, specifically with the ExcludeVisualStudioCredential.
In my scenario, I was trying to use the Visual Studio credential in order to use Azure KeyVault.  According to the docs, the credentials should be picked up automatically after logging into Azure via Visual Studio.  Experience to date indicates this is not the case as the ONLY way I can seem to make this option work is by setting the VisualStudioTenantId property manually as shown in my StackOverflow post.
If someone could provide a code sample using the Visual Studio credential WITHOUT having to set the TenantId manually (or update the docs to indicate the TenantId MUST be specified for this option), that would be most helpful.
Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 615f84d6-1fac-9689-3c60-320ba71885f7
Version Independent ID: ad90a58b-2120-b876-8f3c-0bffe298c158
Content: DefaultAzureCredentialOptions.VisualStudioTenantId Property (Azure.Identity) - Azure for .NET Developers
Content Source: xml/Azure.Identity/DefaultAzureCredentialOptions.xml
Service: azure
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Thank you for your feedback.  Tagging and routing to the team members best able to assist.

Could you try this with the latest beta KeyVault package version? It has a new feature that will attempt to perform tenant discovery.  https://www.nuget.org/packages/Azure.Security.KeyVault.Secrets/4.3.0-beta.4

Christopher – I can confirm that after installing the Azure.Security.KeyVault.Secrets  4.3.0-beta.4 package, the Visual Studio credentials are picked up WITHOUT the need to include the Tenant ID.
Currently my project was using the following NuGet packages:
Azure.Extensions.AspNetCore.Configuration.Secrets
Azure.Identity
I can see that Azure.Extensions.AspNetCore.Configuration.Secrets depends on Azure.Extensions.AspNetCore.Configuration.Secrets (>= 4.0.2); hopefully, the Azure.Extensions.AspNetCore.Configuration.Secrets package will be updated soon to include the beta update.
Thanks!
From: Christopher Scott @.>
Sent: Friday, January 28, 2022 8:33 AM
To: Azure/azure-sdk-for-net @.>
Cc: bdcoder2 @.>; Author @.>
Subject: Re: [Azure/azure-sdk-for-net] Authenticating via Visual Studio only seems to work if the TenantId is supplied -- is that correct? (Issue #26652)
Could you try this with the latest beta KeyVault package version? It has a new feature that will attempt to perform tenant discovery. https://www.nuget.org/packages/Azure.Security.KeyVault.Secrets/4.3.0-beta.4
—
Reply to this email directly, view it on GitHub https://github.com/Azure/azure-sdk-for-net/issues/26652#issuecomment-1024332335 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNINOEZJLNRVA47VHOUD6DUYKZK5ANCNFSM5M7II6JA .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ABNINOH62RRAAFP44AJCVXTUYKZK5A5CNFSM5M7II6JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHUHBELY.gif Message ID: @.*** @.***> >

From Stackoverflow:
Chistothes: Note this feature was added to the Key Vault SDK here github.com/Azure/azure-sdk-for-net/blob/main/sdk/keyvault/… in combination with the >=1.5.0 version of Azure.Identity
bdcoder: Strange, I am using Azure.Identity 1.5.0 -- but if I remove the Azure.Security.KeyVault.Secrets 4.3.0-beta.4 package, the VisualStudio credentails are NOT picked up (as per the original post).

Yes, both are needed together.

@christothes - sorry for being slow here, but I have 3 NuGet packages installed currently:

Azure.Extensions.AspNetCore.Configuration.Secrets 1.2.1
Azure.Identity 1.5.0
Azure.Security.KeyVault.Secrets 4.3.0-beta.4

When the above are used, everything works.
I was under the impression that only two of the packages (Azure.Extensions.AspNetCore.Configuration.Secrets and Azure.Identity) should be required because of the comment "this feature was added to the Key Vault SDK here github.com/Azure/azure-sdk-for-net/blob/main/sdk/keyvault/… in combination with the >=1.5.0 version of Azure.Identity".
So to clarify -- all THREE packages are required?

@christothes - Thank-you again! - makes sense.


Fix bug when loading the script from a non-session Whova page

Because the script errors out, it is not able to modify a subsequent navigation to a session. I suspect the script needs to do a check on whether the current page is a session or not.
The console error:
Uncaught TypeError: Cannot read properties of undefined (reading 'classList')
    at onLoad (VM342 userscript.html:81:16)
    at Proxy.<anonymous> (VM342 userscript.html:171:31)
    at St (<anonymous>:9:89)
    at t.<computed> (<anonymous>:59:418)
    at St (<anonymous>:9:89)
    at r (<anonymous>:22:484)
    at <anonymous>:23:112
    at <anonymous>:69:256
    at g (<anonymous>:69:275)

Another idea: integrate try/catch structures into the modification parts of the code.

Closed with 8e4eb3b. 😄

Closed with 8e4eb3b. 😄


Freewall will fire until window is resized

Hello,
I am loving Freewall but am having a hard time getting it to fire on page load. I am getting the images using instafeed.js. No matter how far down I put the script or even if I tell it to execute after all images are loaded it will not until I resize the browser. Any help would be hugely appreciated..
Thanks!

i have this problem too.
On my page I have two freewall galleries. The first one loads without a problem but the second one loads with images of random width and height, but returns to normal on resize or even if i click on inspect element. (i tested in mozilla)

i have this problem too.

I'm guessing all of you are using the Pinterest grid?

try this under your freewall script
$(window).trigger('resize');

Hi @lr150561
I believe you didn't do it write. I trigger wall.refresh() after all images being loaded (exclude those image loading errors).
sample code like this
var images = $(html).find('img');
var length = images.length;
images.load(checkImageStatus);
images.error(checkImageStatus);

wall.appendBlock(html);

function checkImageStatus() {
    --length;
    if (!length) {
        setTimeout(function () {
            wall.refresh();
        }, 505);
    }
}

Thank you @dragonfish-au  👍
https://github.com/kombai/freewall/issues/203
https://github.com/kombai/freewall/issues/207
https://github.com/kombai/freewall/issues/208


Question: Any way to render on nested property change?

Let's say I make an address component, which takes an object property with street and suburb keys, each with a string value.
Currently, if I change the object identity of the property itself, the component will be re-rendered, but if I change (from somewhere else in the app) just the value of the street key of the property, no render is triggered.
Is there a recommended approach to have a component watch the inner value of a property rather than just its reference identity?
EDIT: Note: similar scenario happens when trying to add extra options to the array property of a dropdown component, for example.

Please tell me if I misunderstood, but I think you can use a 'hasChanged' function when defining a new property within your component. Ideally, you would actually want to define two separate primitives in your component (two strings called street and suburb), as it makes diffing a lot easier (if you had huge objects, it could hurt performance if you diffed on every property change).
You can see an example on the Lit playground page:
https://lit.dev/playground/#sample=examples/properties-has-changed
If you do want to use an object though, I think this example may be helpful.
interface Address {
 street: string;
 suburb: string;
}

@customElement('address-component')
export class AddressComponent extends LitElement {
 @property({
   type: Object,
   hasChanged: (currentAddress?: Address, previousAddress?: Address) => {
     return !(currentAddress?.street === previousAddress?.street);
   },
 })
 address?;

 firstUpdated(_changedProperties) {
   this.address = { street: '111 11 street', suburb: 'somewhere in canada' };
 }
 render() {
   return html` <input
       @input="${(e) => {
         this.address.street = e.target.value;
       }}"
     />
     <span>${this.address?.street}</span>`;
   }
}

Please let me know if this is not what you were looking for! Hopefully we can find the answer if so. Also, keep in mind that when assigning an object in the template, you don't have to put quotes around it:

It threw me off the first time I had to use objects as properties.
Anyways, good luck!! David

Thanks for taking the time to look at this David. I've done a bit of investigation of the hasChanged function, and it doesn't seem to work quite the way you're suggesting. From the lit.dev documentation:

hasChanged()
Called when a reactive property is set. ...

It is only called when the value of the property itself is set (i.e. to a different object entirely), so it can only serve to "filter out" renders, making them less rather than more granular. I have done a few code experiments to confirm this, I'm in the process of tidying and documenting them and will post here once complete.
There is another component lifecycle method called requestUpdate, which can imperatively trigger an update cycle, however this would require setting up some sort of watcher on the object's properties when it is first set, and each time it is reset.
Thanks again for your input.

OH if you want to update whenever the object is set, you could just return 'true' from the hasChanged function... albeit I feel oddly guilty whenever I do it. I made a stackblitz this time, but it does use lit-element because that was a template I had saved. Should work about the same though:
https://stackblitz.com/edit/hgtmpc?file=address-single.js
Is that more like what you are looking for? Also, you were totally right about the requestUpdate! I typed the response up and forgot to add it in. I'll fix it above.
You may also be able to use a setter, but I think that still requires your new object to pass the 'hasChanged' criteria.
Feel free to take over that stackblitz also!
David

Lit has a simple change detection strategy that works by creating accessors for reactive properties. Anything more involved than that requires an entire system to observe objects and collections - which is going to be more opinionated and invasive than we want to be, and possibly unnecessary for a lot of devs who use immutable patterns or statement management libraries.
Right now libraries that allow deep property observation either:

Patch accessors onto objects as they're used, and patch mutating methods onto common collections like Array, Map, Set (ie, patch Array.push() and Set.add()). We don't want to patch other objects - it's dangerous, slow, and incomplete - we can't possibly know all the mutating methods to patch and Array's can't be fully supported.
Require that all data object are used via a set of Proxies that serve the same purposes as the patches, but don't modify the underlying object. It's better than patching but doesn't work on IE11, creates a new Proxy object for every object used in the data system, and is also incomplete first due to the same issue with patching, and second because this system can't detect changes that happen outside of the Proxies.
Rerun all expressions any time anything in the app changes, and know when the world changes by patching all async task creation in the entire DOM API so that you can check the expression list when the tasks complete. This is the zone.js approach, and it's also invasive, incomplete and slow.
Make you opt-in to special observable objects. These objects do the same work that patching plain data object would, but there's no patching because the objects were design to be observed. MobX is a good example, and there's a nice mixin for using it with Lit. This approach doesn't have the downsides of the above if you can use those special objects.

Given that the first three have too many downsides for us, and the last technique already works with Lit, we're keeping our deep change detection simple, and recommend using a thrid-party observer system like MobX. I also hear that Vue's reactivity system, which uses Proxies, can work well with Lit.

Closing based on @justinfagnani's response. Please re-open if further discussion is necessary.


Implement basic down-level compatibility for "Old-IE" and other statistically relavent browsers

Here's a stand alone implementation of "ready" extracted from jQuery: https://github.com/cms/domready/blob/master/domready.js


Provide a way to customize the xdg-user-dirs

The xdg-user-dirs package contains a file named etc/xdg/user-dirs.defaults.
A module allowing to customize this file would be great.

GNOME users, at least, already have ~/.config/user-dirs.dirs generated in their profile by the GNOME module. That would override the XDG module.

I'm also interested in a way to customize xdg-user-dirs

There is little need for dedicated options, you can just use
{
  environment.etc."xdg/user-dirs.conf".text = ''
    XDG_DESKTOP_DIR="$HOME/Desktop"
    XDG_DOCUMENTS_DIR="$HOME/Documents"
    XDG_DOWNLOAD_DIR="$HOME/Downloads"
    XDG_MUSIC_DIR="$HOME/Music"
    XDG_PICTURES_DIR="$HOME/Pictures"
    XDG_PUBLICSHARE_DIR="$HOME/Public"
    XDG_TEMPLATES_DIR="$HOME/Templates"
    XDG_VIDEOS_DIR="$HOME/Videos"
  '';
}

in your configuration.nix.

@jtojnar It does not work...
What I have tried so far in a VM:

removing the user homedir + nixos-rebuild switch --upgrade
changing environment.etc."xdg/user-dirs.conf".text to environment.etc."xdg/user-dirs.dirs".text + removing the user homedir + nixos-rebuild switch --upgrade
changing environment.etc."xdg/user-dirs.conf".text to environment.etc."xdg/user-dirs.default".text + removing the user homedir + nixos-rebuild switch --upgrade

I am using Gnome as a DE

nixos-rebuild switch --upgrade will not be enough. xdg-user-dirs relies on /etc/xdg/autostart to run so you need to re-login for it to be triggered.

I did reboot the VM after every nixos-rebuild switch --upgrade

Hmm, apparently, it should have been user-dirs.defaults, not user-dirs.default or user-dirs.conf.

@jtojnar ... sorry for the delay...
But I just tried with only this configuration.nix

{ config, pkgs, ... }:

{

  imports =
    [ # Include the results of the hardware scan.
      ./hardware-configuration.nix
    ];

  # Use the GRUB 2 boot loader.
  boot.loader.grub.enable = true;
  boot.loader.grub.version = 2;

  # Define on which hard drive you want to install Grub.
  boot.loader.grub.device = "/dev/sda"; # or "nodev" for efi only

  networking.hostName = "nixos"; # Define your hostname.

  # Enable the X11 windowing system.
  services.xserver.enable = true;
  services.xserver.layout = "es";

  # Set your time zone.
  time.timeZone = "Europe/Copenhagen";

  environment.etc."xdg/user-dirs.defaults".text = ''
    XDG_DESKTOP_DIR="$HOME/system/desktop"
    XDG_DOWNLOAD_DIR="$HOME/downloads"
    XDG_TEMPLATES_DIR="$HOME/system/templates"
    XDG_PUBLICSHARE_DIR="$HOME/system/public"
    XDG_DOCUMENTS_DIR="$HOME/documents"
    XDG_MUSIC_DIR="$HOME/media/music"
    XDG_PICTURES_DIR="$HOME/media/photos"
    XDG_VIDEOS_DIR="$HOME/media/video"
  '';

  # Enable the GNOME Desktop Environment.
  services.xserver.displayManager.gdm.enable = true;
  services.xserver.desktopManager.gnome3.enable = true;
}

And it does not use the user-dirs I configure above

Okay, there are several issues here:

As https://github.com/NixOS/nixpkgs/issues/33282#issuecomment-357383680 correctly points out, XDG_CONFIG_DIRS is profile-relative variable and since it is set, /etc/xdg will not be used as per the spec:

If $XDG_CONFIG_DIRS is either not set or empty, a value equal to /etc/xdg should be used.

We could add (pkgs.writeTextFile { name = "user-dirs.defaults"; text = "…"; destination = "/etc/xdg/user-dirs.defaults"; }) to environment.systemPackages which would add it to XDG_CONFIG_DIRS but that will conflict with the file from the preset file from the xdg-user-dirs package installed by gnome3 module.

Okay, I have came up with the following abomination to add to your configuration.nix:

  imports = [
    ({lib, pkgs, ...}: {
      environment.systemPackages = lib.mkBefore [
        (pkgs.writeTextFile {
          name = "user-dirs.defaults";
          text = ''
            XDG_DESKTOP_DIR=system/desktop
            XDG_DOWNLOAD_DIR=downloads
            XDG_TEMPLATES_DIR=system/templates
            XDG_PUBLICSHARE_DIR=system/public
            XDG_DOCUMENTS_DIR=documents
            XDG_MUSIC_DIR=media/music
            XDG_PICTURES_DIR=media/photos
            XDG_VIDEOS_DIR=media/video
          '';
          destination = "/etc/xdg/user-dirs.defaults";
        })
      ];
    })
  ];

But again, it does not work. Turns out we are prefixing the XDG_CONFIG_DIRS with presets when running xdg-user-dirs-update. So we need to patch as well.
With the patch and the horrendous snippet, I can confirm the expected directories were created.

https://github.com/NixOS/nixpkgs/pull/67389 now contains full fix enabling us to use environment.etc."xdg/user-dirs.defaults".text as suggested in https://github.com/NixOS/nixpkgs/issues/33282#issuecomment-523572259.

Awesome @jtojnnar .... I just built from your branch https://github.com/jtojnar/nixpkgs/tree/xdg-user-dirs and works like a charm.
Thanks a lot, I owe you one

@jtojnar @tiramiseb you probably want to reopen this, because functionality implemented here is currently broken.
Please see: #221604

As mentioned in the other issue, there is a prerequisite of environment.systemPackage = [ pkgs.xdg-user-dirs ] and having something that runs autostart entries (which DEs like GNOME or Plasma do out of the box).


Add new contains match for Authorization Policy

Please provide a description of this PR:
Adds a contains match to Authorization Policy header matching.
If a user wants to match on part of the header when the string to match is not either the prefix or suffix of the string, user can provide the match as *<header-string-to-match>* and these changes will check if the header contains the provided string which has been bounded with *.
This change will replace the previous behavior of headers being bounded with * only matching on the suffix.  So instead of */productpage* returning matches for /productpage*, it will instead return matches for /productpage and suffix matches are more strictly defined as */productpage.
Fix Issue: https://github.com/istio/istio/issues/40784
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@rrobb-aspen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
01407399d026cf61779f69fb72938946233bd374
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rrobb-aspen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
795222baf37561377eaa35800f17e5025de4927d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rrobb-aspen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
59158eeff9383b2f895a221bfb2108d43b90e663
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As discussed in https://github.com/istio/api/pull/2470, we need a design for this feature before committing the code.

I agree that this feature needs a design document and a review for the design.

A do-not-merge label is added to the PR so the PR will not be merged until the design is approved.

As discussed in istio/api#2470, we need a design for this feature before committing the code.

We are evaluating our options and making sure it passes the CI/CD. We will have a formal doc in the coming weeks detailing our findings. We understand that it can take time to get community feedback before anything is approved, but we would like to understand the pros/cons better before we document this. I'll put up another PR up soon that has a CEL approach (hopefully) to aid in this discussion.

We've taken the feedback from the community into consideration.  We are hoping to have a solution presented to the community in the on-coming weeks.


:memo: add graph

https://github.com/alakarteio/k-ramel/tree/doc/graph
This is a first "graph" PR, we want to create a graph that is more userfriendly, maybe an animated one would be cool.

Pull Request Test Coverage Report for Build 1463

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.56%

Totals

Change from base Build 1454:
0.0%

Covered Lines:
310

Relevant Lines:
319

💛  - Coveralls


Migrate to Base-Apps

Hi, how you doing?
Well, Foundation for Apps is not supported anymore, so the community forked it and created the https://github.com/base-apps/angular-base-apps .
Could we migrate to base-apps? @gakimball @soumak77 could help!
This foundation-apps-modal is great since we can bind a controller to a modal!

Hello! I think will be better to fork this repo for angular-base-apps.


Removed steps in the Table to Point model that are not need

The model has not been updated since ArcGIS for Desktop 10.1. At that
point the Convert Coordinate Notation GP tool did not keep the
attributes. Due to this there was a py script that was needed to add
unique ids to table and a join step to get your final output.
This is not needed anymore as of ArcGIS for Desktop 10.2

That makes that step just Convert Coordinate Notation, correct? Should we just be getting rid of Incident Table to Point then?

@topowright Can you update the Pro toolbox as well?

There is a known issue with 1.3 with this tool. This tool will not have drop down menus in 1.2 if there are edits made. This fix was only for ArcMap

!@#$%
OK. For ArcMap only. and a known issue for Pro. :smiling_imp:
Testing this one out.

@topowright finding models are all corrupted for the 10.x tbx on this one per discussion yesterday. Going to have to rebuild them.

@topowright
.... should have clarified. These models need to be rebuilt... and so I am going to reject this PR in favor of a fix for whole toolbox.


TEMPORARY - Add coreclr nuget feed for System.Metadata.Reflection

This needs to be removed once the package has been published to nuget.org

@gregg-miskelly

Don't you want to update our version number also? Otherwise LGTM


[Test] add test for common-config

Signed-off-by: jimin.jm<EMAIL_ADDRESS>What is the purpose of the change
[Test] add test for EnvironmentConfiguration、InmemoryConfiguration、SystemConfiguration
Brief changelog
[Test] add test for common-config
Verifying this change
CI
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

@Moriadry all fixed.

Codecov Report

Merging #4208 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #4208      +/-   ##
===========================================
+ Coverage     62.93%     63%   +0.06%
+ Complexity      507     505       -2
===========================================
  Files           769     769
  Lines         33058   33058
  Branches       5217    5217
===========================================
+ Hits          20806   20827      +21
+ Misses         9858    9826      -32
- Partials       2394    2405      +11

Impacted Files
Coverage Δ
Complexity Δ

...bo/rpc/cluster/support/FailbackClusterInvoker.java
67.21% <0%> (-3.28%)
0% <0%> (ø)

...ache/dubbo/registry/multiple/MultipleRegistry.java
62.67% <0%> (-1.41%)
20% <0%> (-2%)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
80.14% <0%> (-0.74%)
0% <0%> (ø)

...main/java/org/apache/dubbo/remoting/Constants.java
100% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...n/java/org/apache/dubbo/common/utils/UrlUtils.java
78.04% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...ibaba/dubbo/registry/support/AbstractRegistry.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...java/org/apache/dubbo/remoting/utils/UrlUtils.java
57.14% <0%> (ø)
0% <0%> (ø)
:arrow_down:

.../remoting/transport/netty4/NettyClientHandler.java
68.42% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...bo/remoting/transport/netty4/NettyTransporter.java
100% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...rc/main/java/org/apache/dubbo/rpc/AppResponse.java
72.34% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b97a0b...78cbe91. Read the comment docs.


Argument is too large: value (line 2022, file Code, project console)

Trying to use gas-console as a reporter I've been getting this error.
When I use a addConsoleReporter() and make output to the Logger service this error doesn't appear.
The error happens with any release of the used library "console" even with no this library used at all.
The gas-console is empty.
However the sample project is still working and it is reporting to gas-console.

Hi, sorry for late response.
In line 2022, file Code, project console, there's this code:
  this.cache.put(this.name, str, 15*60); // 15min.

The Cache service limits the size of value(in this case str = output to console) to 100KB.
I'm sorry but 'gas-console' doesn't care about this limitation.
Was your report larger than that?
if (no) pls let me know.


Update webservice

Update webservice.  Currently builds.  hopefully doesn't require migration script for tests

Codecov Report

Merging #227 into develop will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff            @@
##           develop     #227   +/-   ##
========================================
  Coverage    60.16%   60.16%
========================================
  Files          116      116
  Lines         3507     3507
  Branches       454      454
========================================
  Hits          2110     2110
  Misses        1165     1165
  Partials       232      232

Impacted Files
Coverage Δ

src/app/shared/image-provider.service.ts
66.66% <66.66%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606219e...6c79540. Read the comment docs.

Fixed the tests now.  When I said "build", i meant ng build


Handle new statuses collected by vaultaire-collector-ceilometer

PRs of note - anchor/vaultaire-collector-ceilometer#13 and anchor/vaultaire-collector-ceilometer#14

what is happening here, @oswynb?

This is now handled in ceilometer-common


RS-259: Update snap documentation

Explained how to use a data folder outside snap
Fixed guide descriptions

@AnthonyCvn I'll try to make it in a task related with the guides


Ported Esp-radio to Adafruit Feather boards

If interested in using Adafruit Feather boards, see the fork http://github.com/bbx10/Esp-radio.

Nice work pull the abs fix from today if you want to use analog buttons.

Ok, I will try to keep in sync with the latest changes.


adding tests for iris tools

adding tests for iris tools and corrected the convert_photons_to_DN and DN_to_photons function in IRISRaster class

ping @DanRyanIrish

Thanks so much @abit2 for this PR and contributing to irispy.  I'm going through it now.

Thanks @abit2.  I had a quick look at your PR it looks good.  I'll let you know when I get a chance to make some more comments.

Hi @abit2.  This looks good!  Could you add one more function to test_iris_tools.py to test that calculate_intensity_fractional_uncertainty() raises a ValueError when the wrong units are passed in.  You should be able to do it simply with:
with pytest.raise(ValueError):
    calculate_intensity_fractional_uncertainty(data, wrong_units, detector_type)

Great stuff.  If this passes the Travis test, we should be ready to merge it!

@DanRyanIrish any suggestions on what I should work next


Split requests

Description: Open and Split requests

Short Description of the needed Epic in the below format

As a (who/ person)

I want (what/ goal)

so that (why/ benefit proposal)

What are the most critical features being built as part of this Epic

Expected Outcome – Justification why this Feature must be built, what is expected value and justification for priority.

Sizing

T-shirt size:

[ ] S
[ ] M
[ ] L
[ ] XL
(S=1-2 Sprints, M=2-3 Sprints, L=4-5 Sprints, XL=not sure, probably more than 5 Sprints).

Risks and Assumptions*

[ ] What are assumptions?
[ ] What are the risks?
[ ] Have we done an RFC on a technical approach?
[ ] Are the dependencies (technical, business, regulatory/policy) known?
[ ] Has work on this Epic been prioritized with key stakeholders?

Split request is a story under redirect epic. Closing this epic


Missing attribute docs

Could you please provide some decent documentation on SearchView XML attributes?

Please read README.


the app cannot start even by building cloning and running or by just running the binary.

Traceback (most recent call last):
File "/home/Desktop/learning/workspace/STB_IPTV/QiTV/main.py", line 28, in
prevent_sleep()
File "/home/Desktop/learning/workspace/STB_IPTV/QiTV/sleep_manager.py", line 32, in prevent_sleep
prevent_sleep_linux()
File "/home/Desktop/learning/workspace/STB_IPTV/QiTV/sleep_manager.py", line 110, in prevent_sleep_linux
if reply.type() == reply.ReplyMessage:
AttributeError: 'PySide6.QtDBus.QDBusMessage' object has no attribute 'ReplyMessage'

Thanks, since you can build from scratch, I suggest you to disable sleep manager code in main.py. Hopefully it will fix. I don’t test on linux and seems sleep prevention function has missing function signatures, I will fix it later.

Test this and let me know if it fixes.
https://github.com/ozankaraali/QiTV/releases/tag/release-6ec13ed


Make graph-node more robust in the face of shards being down or restarting

This PR is a continuation of PR #2727 and rounds out the story of making graph-node handle shards being down during startup and during normal operation more gracefully, including coming back to a sane state when a failed shard comes back up. Even so, it's probably a good idea to restart graph-node after a shard restarted.
The basic ideas behind these changes are:

queries should fail fast if they involve a failed shard
queries should only fail if they involve a failed shard
when the primary fails, queries against other shards should still work (achieved with home-grown table replication)
indexing operations in a failed shard retry and block indefinitely
indexing operations in other shards are not affected by a shard failure, even when the primary failed
indexing will not make progress if the failed shard contains the block store for the subgraph's network, but will resume when the block store becomes available again

Testing these things is unfortunately a very manual process. Testing was done under very little load, and it's possible that this did not reveal issues that only appear under high loads. Here are my notes on what I tested:
Setup

three shards: primary, sharda, and shardb
block store also in primary
one simple subgraph (dice2win) indexing in each shard

Notes

indexing service API returns errors when any shard is down if that shard is needed to form response
not clear how all this works under high load

Scenarios
sharda is down on startup

[X] graph-node starts up
[X] queries against primary and shardb work
[X] queries against sharda fail fast
[X] indexing in primary and shardb continues
[X] queries against sharda work after it comes back up
[X] indexing in sharda resumes when sharda comes back up

sharda goes down during operation

[X] queries against primary and shardb work
[X] queries against sharda fail fast
[X] indexing in primary and shardb continues
[X] queries against sharda work after it comes back up
[X] indexing in sharda resumes when sharda comes back up

primary is down on startup

[X] graph-node starts up
[X] queries against sharda and shardb work
[X] queries against primary fail fast
[X] queries against primary work after it comes back up
[X] indexing resumes when primary comes back up

primary goes down during operation

[X] queries against sharda and shardb work
[X] queries against primary fail fast
[X] queries against primary work after it comes back up
[X] indexing resumes when primary comes back up

First of all, great PR clap It took me some time to review haha.

Thanks!

Some questions I have about the PR description are:

Even so, it's probably a good idea to restart graph-node after a shard restarted.

I'm curious, why is that?

There's at least two things that I am worried about: (1) I am not 100% confident that this catches all ways in which indexing could fail when a shard goes down (especially when the shard with the block store goes down at the wrong moment) and (2) because listeners reconnect after some delay, it's possible that they miss assignment events, and, e.g., a subgraph deployed during that time doesn't start syncing.

queries should only fail if they involve a failed shard

What part of this scenario is not covered today by #2727? Also, after reading through your code, it seems that the behavior is to try to get a connection from a shard and if that fails, we try on the next one. How would a failed shard get a query invoked? thinking (maybe I just misunderstood your statement above)

#2727 does not cover the scenario where the primary fails - without this PR, when the primary fails, most queries will fail, since the primary is needed to determine where a subgraph is stored. There's a bit of caching in memory of this data, but it's with a 120s TTL and doesn't cover the resolution of subgraph names to hashes.
The only data that we try getting from different shards is whatever is mentioned in primary::Mirror, but that's the crucial stuff that helps in resolving subgraph names to deployments, and finding which shard has the data for a deployment.

indexing operations in a failed shard retry and block indefinitely

What happens today on the indexing part? I think I'm more aware on the query side.

The subgraph will just fail and needs to be restarted.

Addressed all review comments (I think)

Rebased to latest master

Also, one thing I forgot to ask on the first review is about the Cows.
I read your commit description on it and it makes sense, but I didn't actually found where this is used on the retry.
I'm probably looking at the wrong place. Can you give me a hint on that please?

Also, one thing I forgot to ask on the first review is about the Cows. I read your commit description on it and it makes sense, but I didn't actually found where this is used on the retry. I'm probably looking at the wrong place. Can you give me a hint on that please?

What changed with retrying is that we need two ways to access the entities we are about to write to the store: one for forming the actual relational_queries::InsertQuery and one if the insert fails and we need to retry. Without retrying, we just passed ownership of the entities into the InsertQuery, where the entities can get mutated if there are fulltext search fields. Because we still need access to the entities for a possible retry, we can't pass ownership to InsertQuery any more. At the same time, mutating the entities in InsertQuery is pretty rare, so we don't want to just clone entities on every insert. That's where the CoW comes into play since it allows us to pass references into the InsertQuery: in the common case, the insert will just use references, and only when there are fulltext search fields will a clone happen.

I made a mistake when merging this (not pushing the updated master) This is fixed now, and the PR has been merged at commit 042cf0ac


how can I put your DateTimeField into use in none architect extjs5 app.

hi ,  author ,
thanks very much for your 'DateTimeField' , but I got trouble using it . would you please give some help ?
My  extjs5 app was generated from sencha cmd tool ,  no use of Architect , and nothing else .
And I have copied the 2 js files 'DateTimeField.js' and 'DateTimePicker.js' to the right place of my ext package.
but I am getting trouble , the datetime component does not show correctly. Do I miss something ?
ps :  I only copied the 2 files above into my project, the other files were ignored .

When you go to your Developer Tools and see all the javascript files that have been imported, can you confirm that DateFimeField.js and DateTimePicker.js are there? If yes, let me know what version of the ExtJS5 you are using (5.0.1, 5.1...).

The 2 files are exactly there.   And my Extjs version is  <IP_ADDRESS>

I've added support for ExtJS 5.1

Great thanks !    I will try it later.
Thanks again, you helped me a lot !


fix: Fix pointer mutation causing incorrect maxPods values

Fixes #7011
Fixes #6890
Fixes #6979
Description
This PR fixes a bug where both GetKubeletConfigurationWithNodeClaim and GetKubeletConfigurationWithNodePool were returning the nodeClass.Spec.Kubelet back to the caller when Kubelet was specified and there was no Kubelet compatibility annotation.
This would be fine; however, this call returned back the original pointer for the Kubelet data -- meaning that any caller could then mutate the original data for other callers without knowing it. In this case, the launch template resolver was inadvertently mutating the maxPods data across instance type combinations, leading to incorrect maxPods values being specified sometimes.
How was this change tested?

make presubmit
Print-lining and validating that we are no longer seeing inconsistent maxPods when using the production data.

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 79.396%

Totals

Change from base Build<PHONE_NUMBER>5:
0.02%

Covered Lines:
5942

Relevant Lines:
7484

💛  - Coveralls

In which release can we expect this fix?


Make calls configurable by provider (when multiple services used)

We will have at least 2 services that are used for tracking, both are supported by Angulartics. However, we don't need all events to be sent to both. So is that possible to specify which service to be used for certain events?
Thanks!

Hi!
This would be a great feature indeed ;)

Just out of curiosity, what tracking for what providers do you intend to disable?

+1
I'm using GA and Intercom, but Intercom is not great for tracking very highly frequent events. Ideally I'd like to opt-out these call of the Intercom provider.

I feel like exploring something like event namespaces might be useful. Like ga.user_clicked_like_button or support.cancel_button_clicked where you would specify a namespace for an integration to bind to.

It would be interesting if we could do something like $analyticsProvider.namespace('support:', ['intercom', 'segment']) where the first argument is any arbitrary string you wish to specify as a prefix for your event name (it would be stripped out before sending). This way we don't impose a . dot or : or whatever syntax on your event naming convention. Of course, non-namespaced events would go to all services, OR you could do $analyticsProvider.namespace('', ['google-analytics']) to say that if it doesn't match a namespace send it here. This could also be a hash where the namespace is the key and the service is the value. The only complexity arrises from angulartics knowing the names of it's registered plugins. Another variation to prevent changing the register handler api is to bind the namespace from within the plugins themselves (although this may cause code duplication).

+1 for a way to configure events on a per-provider basis. Like @abanctelchevrel I am working on a project that uses GA and Intercom. Stakeholders require GA analytics remain pristine and Intercom events are treated independently from a measurement perspective.

I like the idea of namespacing but wonder what complexity it would add. We'd obviously welcome a PR
Segment handles this like so:
 "integrations": {
    "All": true,
    "Mixpanel": false,
    "Salesforce": false
  },

@timelf123 Noodling the idea of namespacing after reading @ProLoser's comment, but also concerned with the impact it would have elsewhere (if any, granted). I really like it, but not close enough to source yet to throw up a PR. I'll take a stab if I can later this week once my desk is a little clearer.

@j-hernandez awesome, feel free to hit me on gitter to discuss https://gitter.im/angulartics/angulartics

Hi there, I have posted in gitter, so I reproduce it here .
I am happy to code this functionality as I need it, instead of hacking the code ( that I have already done in fact :p) I would like to provide a nice PR that can be used by everybody.
Could you kindly sumarize what you would need ?

any update on this?


ref(docker): organize ENV and ARG values based on their usage

Motivation
Docker environment variables (ENV) and build arguments (ARG) were being used in a confusing way across the Dockerfile and entrypoint. This PR is scoping each variable and build argument under the stage they were meant to be used.
As a consequence this PR:
Overrides PR #7175
Allows PR  #7179 to work as expected
Fixes #7197
Specifications
Summary: https://vsupalov.com/docker-arg-vs-env/
Deep-dive: https://vsupalov.com/docker-arg-env-variable-guide/
Solution

Add global ARGs which are required across stages
Add SHORT_SHA in the deps stage for build scope
Use a single TEST_FEATURES argument and variable for tests purposes
Add the FEATURES ARG to the release stage to change build time features
Add the FEATURES and NETWORK ARG and ENV to the runtime stage for consistency with global/previous ARGs

Review
@teor2345 and @upbqdn might want to have a look at this
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Follow Up Work
Based on this changes, also remove inconsistency from workflows.
Test this changes
I might also remove NETWORK as an ARG, but I need to fully evaluate the whole pipeline (but this should only be an ENV variable, as it has no impact at build time).

This can be tested locally (for mining) with the following commands:
Build with:
docker build -f ./docker/Dockerfile --target runtime --build-arg FEATURES='default-release-binaries getblocktemplate-rpcs'  --tag zfnd-local/zebra.mining:latest .

Optionally, add these build-args:
--build-arg RUST_BACKTRACE=full --build-arg RUST_LOG=debug --build-arg COLORBT_SHOW_HIDDEN=1

Run with:
docker run -e NETWORK="Mainnet" -e RPC_PORT="8232" -e MINER_ADDRESS="t1XhG6pT9xRqRQn3BHP7heUou1RuYrbcrCc" -p 8232:8232 zfnd-local/zebra.mining


Support to AlpineJS v3

Please, add support to AlpineJS v3. Thanks a lot! Great package!!!

This is a livewire package, so until livewire itself supports Alpine 3, there isn't a lot that can be done.

https://twitter.com/calebporzio/status/1404456562777800708?s=21 soon 😄

And Alpine v3 support is added to Livewire 🥳 https://github.com/livewire/livewire/releases
I only needed to import the Modal JS before Alpine to get it working 👍
// Import Livewire UI Modal
require('../../vendor/livewire-ui/modal/resources/js/modal.js')

// Import Alpine
import Alpine from 'alpinejs'

window.Alpine = Alpine

Alpine.start()

The modal indeed works fine with Alpine v3 and doesn't require any changes 😄 I've updated the readme to include the Alpine v3 CDN.

In case anyone is still getting errors after upgrading to Alpine v3: in my case it helped to include this line
window.Alpine = Alpine

I know the official documentation already tells us to include this line, but I never do. 😅


Golang: Fix go/jsonclient test for Go 1.8

It is considered bad practice matching on error strings since the exact
string output is generally covered by the Go compatibility agreement.
In order for this code to work on both Go 1.7 and Go 1.8, we use a regexp
that matches on both versions of the output.

\cc @daviddrysdale


Update entrypoint.sh to emit errors as an output

Bumping this again - This could use repair.  We don't have SARIF support so we need actual output.

Fixed spelling error.


Roll Flutter Engine from f310ffd1461a to bf8547dd9bcd (4 revisions)

https://github.com/flutter/engine/compare/f310ffd1461a...bf8547dd9bcd
2023-02-07<EMAIL_ADDRESS>Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)
2023-02-07<EMAIL_ADDRESS>Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)
2023-02-07<EMAIL_ADDRESS>Add helpers for updating arm tools in CIPD (flutter/engine#39458)
2023-02-07<EMAIL_ADDRESS>[impeller] ensure full glyphs respect alpha (flutter/engine#39377)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[tests-only] [full-ci] Bump CORE_COMMITID for tests

Description
Related Issue
https://github.com/owncloud/QA/issues/739
How Has This Been Tested?
CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

https://drone.owncloud.com/owncloud/ocis/11757/49/9
runsh: Total unexpected failed scenarios throughout the test run:
webUICreateFilesFolders/createFile.feature:31

  Scenario: redirect to subfolder after closing the text editor # features/webUICreateFilesFolders/createFile.feature:31
- Connecting to selenium on port 4444...

ℹ Connected to selenium on port 4444 (240ms).
  Using: chrome (94.0.4606.61) on Linux platform.

    Given user "Alice" has been created with default attributes and without skeleton files in the server
    And user "Alice" has created file "/lorem.txt" in the server
    And user "Alice" has logged in using the webUI
√ Element <input[autocomplete="kopano-account username"]> was visible after 687 milliseconds.
√ Element <input[autocomplete="kopano-account username"]> was not present after 139 milliseconds.
√ Element <#files-view> was visible after 454 milliseconds.
    And the user has browsed to the personal page
√ Element <//nav[@id="files-breadcrumb"]//*[(self::a or self::button)]/span[contains(text(),'Personal')]> was visible after 93 milliseconds.
    Given user "Alice" has created folder "parent-folder" in the server
    When the user reloads the current page of the webUI
    And the user opens folder "parent-folder" using the webUI
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='parent-folder' or @data-test-resource-path='/parent-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 27 milliseconds.
√ Element <//*[self::table[contains(@class, "files-table")] or self::div[contains(@class, "files-empty")] or self::div[contains(@class, "files-not-found")]]> was visible after 93 milliseconds.
    Then there should be no resources listed on the webUI
√ Element <.files-empty> was visible after 18 milliseconds.
    When the user creates a markdown file with the name "sample.md" using the webUI
√ Element <#new-file-menu-btn:enabled> was visible after 21 milliseconds.
√ Element <#new-file-menu-drop .new-file-btn-md> was visible after 34 milliseconds.
√ Element <.oc-modal> was visible after 24 milliseconds.
√ Element <.oc-modal> was not present after 8 milliseconds.
    And the user closes the text editor using the webUI
√ Element <#text-editor-controls-close> was visible after 22 milliseconds.
    Then breadcrumb for folder "parent-folder" should be displayed on the webUI
 Error while running .isElementDisplayed() protocol action: The command failed because the referenced element is no longer attached to the DOM. – stale element reference: element i...

 Error while running .isElementDisplayed() protocol action: The command failed because the referenced element is no longer attached to the DOM. – stale element reference: element i...

 Error while running .isElementDisplayed() protocol action: The command failed because the referenced element is no longer attached to the DOM. – stale element reference: element i...
...
    ✖ failed
      timeout error
      TimeoutError: timeout error
          at PeriodicPromise.getError (/srv/app/web/tests/acceptance/node_modules/nightwatch/lib/utils/periodic-promise.js:161:12)
          at PeriodicPromise.perform (/srv/app/web/tests/acceptance/node_modules/nightwatch/lib/utils/periodic-promise.js:111:16)
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
    And file "sample.md" should be listed on the webUI
    - skipped


Index generator pdf

dristi pdf index generator

Summary by CodeRabbit

New Features

Introduced a new functionality to process case bundles and manage associated PDF documents.
Added a new POST route /process-case-bundle for handling case bundle processing requests.

Bug Fixes

Improved error handling for missing required fields in the case bundle processing request.

Documentation

Updated documentation to reflect new route and processing capabilities.

will be closed soon in favour of #1062 @mithunhegde-egov
I had added more commits on top of your branch and it is better to merge that


updatePortion error message/UG has to be more specific

To describe that a new portion will be added if the person does not already exist, and that if the person already exists, to describe the behaviour of the other weights after updating.
It seems that the original weightage values hold for the remaining amount of money after the new weightage is deducted

Will be added into UG


Add before unload warning

Closes #1227

Pull Request Test Coverage Report for Build 3533

6 of 30 (20.0%)  changed or added relevant lines in 4 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 34.317%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/StepOne/index.js
2
6
33.33%

src/components/StepThree/index.js
2
6
33.33%

src/components/StepFour/index.js
0
6
0.0%

src/components/StepTwo/index.js
2
12
16.67%

Files with Coverage Reduction
New Missed Lines
%

src/components/StepFour/index.js
1
1.39%

src/components/Common/PreventRefresh.js
4
0.0%

Totals

Change from base Build 3529:
-0.2%

Covered Lines:
1684

Relevant Lines:
4772

💛  - Coveralls


Contact form is not working

After clicking on the submit button the page is showing error 404 not found

😒
On Sat, 8 Aug 2020 at 8:22 AM, Ritwik Sinha<EMAIL_ADDRESS>wrote:

After clicking on the submit button the page is showing error 404 not found
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Digi-Bit/DigiBit/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQMDSWUVR3LUUEL2M5C4Y3TR7S4VRANCNFSM4PYKY6KQ
.


consumer timeout value is not provider config

Environment

Dubbo version: 2.7.x
Operating System version: all
Java version: 1.8

Steps to reproduce this issue

provider config  dubbo.provider.timeout=2000
consumer timeout value is DEFAULT_TIMEOUT（1000）

Pls. provide [GitHub address] to reproduce this issue.
Expected Result
2000
What do you expected from the above steps？
Actual Result
1000

the consumer url is
dubbo://<IP_ADDRESS>:18089/xxxxx?anyhost=true&application=xx&bean.name=ServiceBean:com.demo.xx&xxxxe&default.timeout=2000&xxxxx
int timeout = getUrl().getMethodPositiveParameter(methodName, TIMEOUT_KEY, DEFAULT_TIMEOUT);

I think your problem is not a really problem, because this strategy is designed on purpose!
http://dubbo.apache.org/en-us/docs/user/recommend.html

If a attribute is configurated in provider side, not configurated in consumer side, consumer service will use the attribute in provider side.
But now the provider configuration is not used.

https://github.com/apache/dubbo/issues/5948


Add Gradle properties files to the configuration cache fingerprint

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test ACC

OK, I've already triggered AllConfigCacheTestsReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFN

OK, I've already triggered ReadyForNightly build for you.

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

@bot-gradle test RFN

OK, I've already triggered ReadyForNightly build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


User can change the page size and its margin for Pages mode

Not gonna do this for current milestone. We will put this for lower prioirty


feat(LESQ-981): query for geo_restricted and login_required in downloads

Description
this only updates the existing queries to get geo_restricted and login_required for lessons and logs it to the console when the feature flag is enabled. This also removes the hard coded geo restriction enabler from the feature flag as we need to do it anyway and it was easier than re-implementing.
How to test
Without the use-auth-owa feature flag

Go to https://deploy-preview-2830--oak-web-application.netlify.thenational.academy/teachers and https://deploy-preview-2830--oak-web-application.netlify.thenational.academy/teachers/specialist/subjects
Click through to the downloads page for any lesson
You should be able to view the page and download exactly as before

With the use-auth-owa feature flag

Go to https://deploy-preview-2830--oak-web-application.netlify.thenational.academy/teachers and https://deploy-preview-2830--oak-web-application.netlify.thenational.academy/teachers/specialist/subjects

Click through to the downloads page for any lesson

You should be able to view the page and download exactly as before

You should see a message logged to the browser console restrictions { geoRestricted: false, loginRequired: false } for all lessons
👋🏻 Currently there are no restrictions configured in production so all lessons will log { geoRestricted: false, loginRequired: false }

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.572.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[release-1.26] Bump kine to v0.10.3

Proposed Changes
Bump kine to v0.10.3
Fixes issue with nonexistent nats.io commit id in go.mod pseudo-verson
Types of Changes
version bump
Verification
Check version
Testing

Linked Issues

https://github.com/k3s-io/k3s/issues/8329

User-Facing Change

Further Comments

CI flaked due to rancher/k3s:v1.28.1-k3s1 not being pushed to docker hub yet; merging.


Make it simpler to control what's included by flow_from_directory

Two changes here:

Allow passing a subclass of DirectoryIterator to flow_from_directory()
Make it easier to subclass DirectoryIterator to add custom file name filtering logic

The motivation for this change is I'm working on a project where I have some noisy data, and want to have my own custom logic to exclude some of the images in each directory.
Most of this diff is changed lines due to the fact that I needed to move ImageDataGenerator to the bottom of the file, since DirectoryIterator now needs to be a kwarg in ImageDataGenerator, and thus has to be defined before ImageDataGenerator.

The motivation for this change is I'm working on a project where I have some noisy data, and want to have my own custom logic to exclude some of the images in each directory.

I think the change is too extensive for a purpose that is too niche. It may be better in this case for your to maintain your own image data generator code separately.


latest update pop up still opened

Issue Type: Bug
"restart vscode" pop up appear each time i open the editor, I doubt that you push update each hours :sob:
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:30:02.420Z)
OS version: Darwin x64 20.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
16.00GB (0.83GB free)

Process Argv
. --crash-reporter-id b38eb96f-5ad0-4387-a97b-1472b859e24d

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

vscode-svgviewer
css
2.0.0

vscode-eslint
dba
2.1.14

gitlens
eam
11.2.1

carbon-now-sh
eri
1.2.0

auto-rename-tag
for
0.1.6

python
ms-
2021.1.502429796

jupyter
ms-
2020.12.414227025

material-icon-theme
PKi
4.5.0

vscode-surround
yat
1.0.2

(3 theme extensions excluded)

1.52.2 was released yesterday, but the version info you posted still shows 1.52.1.

Looks like an Electron failing to apply update.

for some reason after closing very hard my vs code, it was successfully released to 1.53.2 🎈 🥳
i guess @joaomoreno  was right !
I'm closing this as it was not rocket science to resolve this on my side


New Rule: Risk Score

/update-test-rules

The above test rules add never took. The rule is not in the table. Going to try again will monitor actions.

/update-test-rules

/update-test-rules

/update-test-rules


Reveal IntegrityError raised in sync_usersocialauth view

The redirect in finally clause was executed even when an non-GithubException (like IntegrityError) was raised. This hid the error. Now it results in loud error.

This IntegrityError is another bug -- I covered it here https://github.com/swcarpentry/amy/issues/891.

Any chance for a regression test?

@pbanaszkiewicz, done.


Add integrationtestingcreds to list of Expensify emails

Details

Add<EMAIL_ADDRESS>to the list of Expensify emails.
cc @coleaeason
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173672
Tests

No
QA Steps

No

Sorry to update after getting two approvals, but the word cloud nature of that email list was more than I could bear. Put each entry on its own line for readability's sake.

Self merging since I've got one full approval from @thienlnam and the only change since @coleaeason's last approval was formatting.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @deetergp in version: 1.0.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅