Remove use of Guava types from API surface.

Replace com.google.common.base.Function
with java.util.function.Function
Replace com.google.common.collect.ImmutableList
with java.util.List
This does change the binary API compatibility of the library...
Fixes #410 ☕

@olavloite as he wrote the code I am modifying.
I don't know if the benefits of changing this API surface outweigh the cost of breaking binary compatibility with older library versions...

Updated to only replace ImmutableList -> List to keep JDK 1.7 compatibility.

@nielm You need to add an entry to https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

@nielm You need to add an entry to https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

Thanks, Knut, Done!

@nielm could you amend your commit to have the "breaking change" footer or "!" in the commit message (https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-description-and-breaking-change-footer). This will make sure that the automation releases a major version.


Add OCM_USER_PASSWORD to variables.ts

To support the staging environment, we need to pass the scripts a
username and a password. The password was missing.

/lgtm


AMIs listed on node template status are incorrect

Description
Observed Behavior:
The correct AMIs should be listed
Expected Behavior:
The old, incorrect AMIs were listed.
Reproduction Steps (Please include YAML):

Look at the AWS node template
Upgrade your cluster version
Look at the AWS node template again

In my case, the AMIS on the template (even 12 hours later) are showing for the old K8s versions and not my current cluster version.
Versions:

Chart Version:
Kubernetes Version (kubectl version):

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@tzneal Can you share your AWSNodetemplate?

I think this is it, and I don't have an AMI selector.
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"karpenter.k8s.aws/v1alpha1","kind":"AWSNodeTemplate","metadata":{"annotations":{},"creationTimestamp":"2022-09-08T14:00:24Z","generation":26,"name":"default","resourceVersion":"214609316","uid":"60162c71-ed80-4e39-b613-17ad9752e8a4"},"spec":{"amiFamily":"AL2","securityGroupSelector":{"karpenter.sh/discovery":"tnealt-karpenter-demo"},"subnetSelector":{"karpenter.sh/discovery":"tnealt-karpenter-demo"}}}
  creationTimestamp: "2022-09-08T14:00:24Z"
  generation: 55
  name: default
  resourceVersion: "283463556"
  uid: 60162c71-ed80-4e39-b613-17ad9752e8a4
spec:
  amiFamily: AL2
  securityGroupSelector:
    karpenter.sh/discovery: tnealt-karpenter-demo
  subnetSelector:
    karpenter.sh/discovery: tnealt-karpenter-demo
status:
  amis:
  - id: ami-03c71b04d72abcaba
    name: amazon-eks-node-1.26-v20230703
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: DoesNotExist
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: DoesNotExist
  - id: ami-04b16fffebdb71b44
    name: amazon-eks-gpu-node-1.26-v20230703
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: Exists
  - id: ami-04b16fffebdb71b44
    name: amazon-eks-gpu-node-1.26-v20230703
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: Exists
  - id: ami-0e1b6fa1064526fe3
    name: amazon-eks-arm64-node-1.26-v20230703
    requirements:
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: DoesNotExist
    - key: kubernetes.io/arch
      operator: In
      values:
      - arm64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: DoesNotExist
  securityGroups:
  - id: sg-05f88204faa8cf2d4
    name: eksctl-tnealt-karpenter-demo-cluster-ClusterSharedNodeSecurityGroup-1GYN6XLQSMHLC
  - id: sg-05c364fe5ccfc49b4
    name: eksctl-tnealt-karpenter-demo-cluster-ControlPlaneSecurityGroup-ZNWBNVJKS2ZJ
  subnets:
  - id: subnet-0ef4e49e53c6efeb8
    zone: us-west-2d
  - id: subnet-0c11eccbdb504fc8c
    zone: us-west-2a
  - id: subnet-08b2f89b5c564eef8
    zone: us-west-2d
  - id: subnet-0d1867bc726b0761e
    zone: us-west-2a
  - id: subnet-07c63b239e3635300
    zone: us-west-2c
  - id: subnet-015e9db74b0cc6b47
    zone: us-west-2c

Do you by any chance happen to have the logs? I wasn't able to replicate the issue on a new cluster

Nope, sorry.  Did you upgrade a cluster and it worked?

Yeah I upgraded the cluster from 1.24 to 1.25 It took around 5 minutes to change, but it updated

karpenter-77b97df45-bn4g5 controller 2023-07-20T19:42:18.794Z	ERROR	controller	Reconciler error	{"commit": "47446e1-dirty", "controller": "awsnodetemplate", "controllerGroup": "karpenter.k8s.aws", "controllerKind": "AWSNodeTemplate", "AWSNodeTemplate": {"name":"default"}, "namespace": "", "name": "default", "reconcileID": "26744bea-bafe-44ee-9062-9e805b6e1df5", "error": "Internal error occurred: failed calling webhook \"defaulting.webhook.karpenter.k8s.aws\": failed to call webhook: Post \"https://karpenter.karpenter.svc:8443/?timeout=10s\": dial tcp <IP_ADDRESS>:8443: connect: connection refused"}

Talked offline. I wasn't able to reproduce and seems to be a webhook error. Closing for the time being.


Sort practice exercises

Sorted by difficulty, name

Thanks! I've been meaning to do this but never got around to it.


feat:add configs for alpha environment

The main reason for creating the separate alpha environment is to enable the redirectSignIn and redirectSignOut properties to point to the alpha domain instead of stage.
Relates to this closed PR
https://github.com/Health-Education-England/tis-revalidation-v2/pull/1081
NO TICKET

I don't think there's an issue with duplicates in the environment properties so happy to ignore.

I'm testing my theory about whether this needs to be merged to give you what you need by running the "deploy alpha" workflow from the branch.


Introduce ONNXUnitConstantOp to replace std ConstantOp with unit value

ConstantOp in std dialect used to allow a "unit" constant. This is no longer allowed (https://reviews.llvm.org/D118654).
In this PR we are addressing that change in MLIR by introducing a custom operation in the ONNX dialect.
Signed-off-by: Ettore Tiotto<EMAIL_ADDRESS>

Thank you for proposing this op!
It seems to me this op is for create a None value only so could we simplify it. e.g.:

Declare a custom builder so that we can use create<ONNXUnitConstantOp>(UnknownLoc::get(&ctx)) instead of create<ONNXUnitConstantOp>(UnknownLoc::get(&ctx), builder.getNoneType(), builder.getUnitAttr())
Suggest to use a more descriptive name, e.g. ONNXNoneOp. Honestly, I saw some users were confused on the usage of constant unit for none value.

Declare a custom builder so that we can use create(UnknownLoc::get(&ctx)) instead of create(UnknownLoc::get(&ctx), builder.getNoneType(), builder.getUnitAttr())

Good idea, incidentally I was thinking about it last night. Make sense to simplify the op that way.

Suggest to use a more descriptive name, e.g. ONNXNoneOp. Honestly, I saw some users were confused on the usage of constant unit for none value.

This is subjective of course. I was debating about ONNXNoneOp and ONNXConstantUnitOp. I settled on the later because it I was replacing a ConstantOp with unit value.

What's the usage of the unit constant? std::constant unit is used to represent the optional tensor in onnx-mlir. In the newer version of onnx model, tensor with 0 length, such as tensor<0xi32> and tensor<0xf32>, is used.

What's the usage of the unit constant? std::constant unit is used to represent the optional tensor in onnx-mlir...

A 'unit constant' according to this discussion (https://discourse.llvm.org/t/standard-dialect-the-final-chapter/6061) has no well defined semantics in MLIR (hence the removal). We currently use it in cases to provide a 'None' value to arguments of operators that are optional arguments. For example:
  %cst = constant unit
  %0, %1 = "onnx.Split"(%arg0, %cst) { axis = 0 : si64} : (tensor<16x32x64xf32>, none) -> (tensor<*xf32>, tensor<*xf32>)

Here the second argument to onnx.Split can take a value with "none" type. The unit constant provides that value.

In the newer version of onnx model, tensor with 0 length, such as tensor<0xi32> and tensor<0xf32>, is used.
We'd better to have a wrapper to handle both cases.

What are the semantics of tensor with zero elements ?

What's the usage of the unit constant? std::constant unit is used to represent the optional tensor in onnx-mlir...

A 'unit constant' according to this discussion (https://discourse.llvm.org/t/standard-dialect-the-final-chapter/6061) has no well defined semantics in MLIR (hence the removal). We currently use to provide a 'None' value to arguments of operators that are optional arguments. For example:
  %cst = constant unit
  %0, %1 = "onnx.Split"(%arg0, %cst) { axis = 0 : si64} : (tensor<16x32x64xf32>, none) -> (tensor<*xf32>, tensor<*xf32>)

Here the second argument to onnx.Split can take a value with "none" type. The unit constant provides that value.

In the newer version of onnx model, tensor with 0 length, such as tensor<0xi32> and tensor<0xf32>, is used.
We'd better to have a wrapper to handle both cases.

What are the semantics of tensor with zero elements ?

joining the discussion as i'm interested in seeing how this gets resovled. FWIW i took @chentong319 's comment and quickly replaced constant-unit with a 0-length i64 tensor along one path through onnx-mlir and was able to get a simple test case working

Addressed comments from @tungld


Discuss: Rename className to scope

Is your request related to a specific problem you're having?
Yes, once we add nested scope then technically className is no longer accurate, plus it's length has always bothered me.
The solution you'd prefer / feature you'd like to see added...
I propose we rename it scope...
Before:
      {
        className: 'title.class',
        match: '^\\w+(?=:)'
      },

After:
      {
        scope: 'title.class',
        match: '^\\w+(?=:)'
      },

Of course we'd continue to support className (deprecated)... this would be an alias essentially.
Any alternative solutions you considered...
Nope.  TextMate grammars calls this captures/name in the grammar and "scopes" is the concept I believe.
 {  match = '(@selector\()(.*?)(\))';
    captures = {
       1 = { name = 'storage.type.objc'; };
       3 = { name = 'storage.type.objc'; };
    };
 };

Additional context...
None.

CC @highlightjs/core

No objections here, makes sense to me

Would this still support multiple classes? I've been adding multiple classes for debugging. Otherwise I'm :+1:

Same behavior, just a name change since technically "function.title.call" is NOT a class name.  And I've never loved the verbosity of className...


Add Education Department Punjab, Pakistan URL http://qaed.edu.pk/

Official Domain: http://qaed.edu.pk/
This is the Govt. Institution that provides training to all the teachers of School Education Department of Government of Punjab, Pakistan. There are many computer programming courses that are offered. Here is the url of School Education Department: https://schools.punjab.gov.pk/
Here is the URL where academics and trainings offered for teaching staff:
http://qaed.edu.pk/pages/subpages/6
Here are the computer courses offered in Punjab Schools
https://sabaq.pk/book-page.php?b=p&c=12&s=cs
https://sabaq.pk/book-page.php?b=p&c=11&s=cs

@seaatif First stage of verification passed, official domain is qaed.edu.pk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@seaatif Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Radio volume bar extends past the screen

The volume bar at the bottom of the Radio extends beyond the visible portion of the screen. It should be anchored to the right side of the view using autolayout

Note: this may not show up in the simulator, run on a device to test it

Closed by #27


Bumping up version to 2.4.0 for the Fine Release

API Versioning bump 2.4.0-pre => 2.4.0

/cc @gtanzillo I knew I forgot something

@abellotti I believe you'll also want to create another PR to master, bumping master-only to 2.5.0-pre or something like that

Fine backport details:
$ git log -1
commit e50a9592a04d31dee8b56d7034a9a7996e40d1b1
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Tue Mar 28 13:34:26 2017 -0400

    Merge pull request #14541 from abellotti/api_version_240_fine_release

    Bumping up version to 2.4.0 for the Fine Release
    (cherry picked from commit f0297aace1e6d6afbd6b176a728ffbb693cd8aa8)


Change ns-export command to incorporate splatfacto naming

Change ns-export command to incorporate "splatfacto" naming convention.

Thanks for the PR! We're hesitant to call the export option splatfacto since the export is compatible with standard .ply exports. splatfacto is a method, but the export type is still the same data format as others. That said, renaming it from gaussian-splatting to something shorter like splat would be nice to make tab completion more intuitive.

Something shorter or more specific sounds good to me, but ns-export splat seems confusing because of the common .splat file format (which is different from the .ply we're exporting).


initialize remaining tests, update firebase config

It's adding all code needed to test all appropriate snippets in CI.
Pre-submit checklist

[x] This PR follows the Google Developer Documentation Style Guidelines
[x] This PR uses semantic line breaks

The recommendation would be to deploy the rules with your project, and
treat them as source code.
But yeah, many folks in DevRel probably mostly use the console to edit
rules (I definitely do). If you don't want to touch the rules, you can just
remove the file from your repo, and remove the reference to the file from
the firebase.json. I wouldn't have flagged this if the file+reference
weren't present.
On Mon, Apr 18, 2022 at 8:26 AM Eric Windmill @.***>
wrote:

@.**** commented on this pull request.
In .github/workflows/scripts/firestore.rules
https://github.com/firebase/snippets-flutter/pull/11#discussion_r852197008
:

@@ -0,0 +1,8 @@
+rules_version = '2';
+service cloud.firestore {

match /databases/{database}/documents {
match /{document=**} {

 allow read, write: if true;

@puf https://github.com/puf This has been the motivation I needed to
actually learn about the security rules, but I have a question. It seems
that no other snippets projects are defining rules in their project code,
so I'm assuming they're solely using the console. Do you have a
recommendation or preference on which route to take? I'm only using the
files in the code because initializing the project generated the files.
—
Reply to this email directly, view it on GitHub
https://github.com/firebase/snippets-flutter/pull/11#discussion_r852197008,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7BX6AZXDHYPONKOABGRTVFV5KHANCNFSM5TLFH7EQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Proposal]

Problem Description
Hard to determine what routes belong to what, you have to manually organize them which is a time sink and can lead to confusion in large APIs/projects.
Proposal
Mitmproxy should have a directory sidebar similar to the one in Charles, and then the ability to easily export/import it retaining the structure in folders.
Example here:
https://deliveroo.engineering/images/posts/how-to-use-charles-proxy-to-rewrite-https-traffic-for-web-applications/02-after.png
This way it's easy to tell where everything is in the API at a simple glance.
This feature would not only make working with APIs easier but also really help mitmproxy stand out among its competitors. Since Charles is the only proxy client to date to offer this feature but is locked behind a subscription/proprietary code.
Alternatives
N/a
Additional context
N/a

So basically https://github.com/mitmproxy/mitmproxy/issues/5627 but for mitmproxy instead of mitmweb?
I'm not sure this type of UI can be easily navigated in a terminal. But feel free to submit a PoC PR!


Support for private / public ROs

This is a huge change. Reasons:

Users might not feel confident (or ok..) making public ROs from day 1.
A private namespace will make OpenBio more appealing to new users.
Sometimes the licensing status of ROs (and especially data) is not clear.

Of course these are open for discussion. Add your comments below. Here I am listing the technical details for this change:

[x] Change database model in Tools/Data, Workflows. visibility = public/private/... (type:enum this will allow for more in the future. Default = "public")
[x] Change the query from search input in Tools/WFs. Add an extra Q object.
[x] Change the UI. Add a checkbox button "Public / Private" similar to input/output variables in WFs
[x] Search on comments should exclude private ROs
[x] Disable private interlinks
[x] When converting from private to public make sure that the RO does not have a private dependency
[x] When converting from public to private make sure that this RO is not used by any public RO
[x] When creating a new public RO check that it does not uses a private RO
[x] Show Public/Private status in Fork tree
[x] Change the REST API
[x] Update Documentation
[x] Test

After adding Tests and Documentation I am closing this issue.


Create zh_cn.lang

I'm not the translator, it's translated by 凌漠血.

I can't accept a translation that isn't yours.


WIP: Add superclass options to the NewtonsoftCSharpTargetLanguage

I'm switching branches and fixing build errors now.


Release Google.Cloud.ResourceManager.V3 version 1.2.0

Changes in this release:

Commit 1964fe9: docs: fix docstring formatting
Commit 5adca20: docs: fix docstring formatting

Created release for Google.Cloud.ResourceManager.V3-1.2.0


Fix for #360

Hi,
I have removed outline using css and tested. It’s working fine. Can you
please review?
Signed-off-by: srinivas padidapelli<EMAIL_ADDRESS>

@SrinivasPadidapelli Please amend your commit to correct the sign off message. You need to make sure that the format is like this: Signed-off-by: John Doe<EMAIL_ADDRESS>Note that your email must be wrapped by <>.


Updates for COSIMA production run

Updates for COSIMA production run

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8a4be56). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   77.77%
=========================================
  Files             ?        2
  Lines             ?       63
  Branches          ?        0
=========================================
  Hits              ?       49
  Misses            ?       14
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4be56...3fdcdcd. Read the comment docs.


Update near login documentation

There are no a documentation to specify it for using a different wallet even if it already had a walletUrl option.

no draft


[Feature]: VNC PASSWORD

Is your proposal related to a problem?
is it possible to make a password to vnc access through the web port 8006 ?
Describe the solution you'd like.
vncpasswd
Describe alternatives you've considered.
vnc_passwd
Additional context
No response

you can use nginx to set password
sudo apt update
apt install apache2-utils
sudo htpasswd -c /etc/nginx/.htpasswd <your username>

server {
    listen 8007;
    server_name localhost;
    location / {
        proxy_pass http://localhost:8006;
        auth_basic "Restricted Content";
        auth_basic_user_file /etc/nginx/.htpasswd;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
    }
}

then, restart
service nginx restart

you can use nginx to set password
sudo apt update
apt install apache2-utils
sudo htpasswd -c /etc/nginx/.htpasswd <your username>

server {
    listen 8007;
    server_name localhost;
    location / {
        proxy_pass http://localhost:8006;
        auth_basic "Restricted Content";
        auth_basic_user_file /etc/nginx/.htpasswd;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
    }
}

then, restart
service nginx restart

Should I set the Settings on my mainframe or in my docker container？

Should I set the Settings on my mainframe or in my docker container？
@Taitancjy
In your nginx configuration, it is best to set it on your host to prohibit external network access to this port, use nginx as an internal network proxy, and set an access password in nginx


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-01-08)
Features

init (4c510d9)

Bug Fixes

update g token (e6ae85d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sixdjango/ts-react-component-lib-starter/releases/tag/v1.0.0 :sunflower:


Valid package missing from the index

validated-changeset seems to be completely missing from the index (see failed requests) despite existing for quite a while and not being deprecated 🤔

NB: I did not know the Algolia was in the critical path of jsdelivr, maybe we should produce a different index without 3rd party enrichment to avoid disruption.

It doesn't affect our CDN but affects the website since that relies mostly on the data from the index to render the package pages (I think similarly to https://yarnpkg.com/). A retry strategy would definitely be good.

maybe we should produce a different index without 3rd party enrichment to avoid disruption.

So it was something else than npm that failed?

So it was something else than npm that failed?

In that case no, NPM was the issue. But 3rd party is what make the indexing slow, you can have many hours of lag because of this. I don't know if it's acceptable for you, considering that without 3rd party the page would probably empty.
We can eventually think of "on-demand" endpoint, that you can reach to request a package that seems to 404. But I guess you got a lot of 404 that would also spam us. wdyt?

Right now, we're only using the following attributes, which I think all come from npm?
[ 'deprecated', 'description', 'githubRepo', 'homepage', 'keywords', 'license', 'name', 'owner', 'version' ]

But that's going to change in a redesign that we're working on right now as we also want to show part of READMEs.
We also query our own API which could be used to prevent 404 calls if there was an on-demand endpoint in the future, but the thing is, most people get to the package pages from the search results. If the search doesn't return the package, the on-demand approach won't help. So it would have to be a combination of npm-only index + the endpoint.
I think a good enough start here is ensuring that we don't miss any packages completely because of temporary errors.

It's not ideal, but a temporary workaround would be in your frontend to fall back to https://registry.npmjs.com/validated-changeset, as that's a more "pure" source of truth

It's not ideal, but a temporary workaround would be in your frontend to fall back to https://registry.npmjs.com/validated-changeset, as that's a more "pure" source of truth

Indeed for direct access to that page, we could.

Made a quick and dirty retry strategy @MartinKolarik


cspyce.ckfxfm outputs float[3, 3] array instead of float[6, 6]

For cspyce.ckfxfm, it returns 3 parameters: xform, ret, and found. xform is supposed to be returned as a float[6,6] array. It say so in the help message:
Help on function ckfxfm in module cspyce.cspyce2:

ckfxfm(inst, et) -> ['xform', 'ref', 'found']
    Find the state transformation matrix from a C-kernel (CK) frame with the
    specified frame class ID (CK ID) to the base frame of the highest
    priority CK segment containing orientation and angular velocity data for
    this CK frame at the time requested.

    https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/cspice/ckfxfm_c.html

    Inputs:
      int        inst  = Frame class ID (CK ID) of a CK frame.
      float      et    = Epoch measured in seconds past J2000 TDB.

    Returns:
      float[6,6] xform = Transformation from CK frame to frame `ref'.
      int        ref   = Frame ID of the base reference.
      bool       found = True if the requested pointing is available.

However, it isn’t returning a float[6, 6] array. It’s returning a float[3, 3] array:
xform = array([[-0.64399206, -0.34110294,  0.68477954],
       [ 0.48057295, -0.87682328,  0.01518468],
       [ 0.5952511 ,  0.33886533,  0.72859208]])

    def xf2rav(xform):
        r"""xf2rav(ConstSpiceDouble [6][6] xform)"""
>       return _cspyce0.xf2rav(xform)
E       ValueError: SPICE(INVALIDARRAYSHAPE) -- xf2rav -- Invalid array shape (3,3) in module xf2rav; (6,6) is required

/usr/local/lib/python3.9/site-packages/cspyce/cspyce0.py:2079: ValueError

Here is an altered version of the cspyce.ckfxfm unit test. To run this, copy the directory cspyce-unit-test-kernels from Dropbox to the current directory. Then run:
import cspyce as cs

cs.furnsh('cspyce-unit-test-kernels/pck00010.tpc')
cs.furnsh('cspyce-unit-test-kernels/de405s_littleendian.bsp')
cs.furnsh('cspyce-unit-test-kernels/gm_de431.tpc')
cs.furnsh('cspyce-unit-test-kernels/naif0012.tls')

cs.furnsh('cspyce-unit-test-kernels/cas00167.tsc')
cs.furnsh('cspyce-unit-test-kernels/cas_iss_v10.ti')
cs.furnsh('cspyce-unit-test-kernels/13056_13057ra.bc')
cs.furnsh('cspyce-unit-test-kernels/cas_v40.tf')
cs.furnsh('cspyce-unit-test-kernels/cpck05Mar2004.tpc')
# arbitrary time covered by test ck kernel
et = cs.str2et("2013-FEB-26 00:01:08.828")
xform, ref, found = cs.ckfxfm(-82000, et)
print(xform)
print(ref)
print(found)
rot, av = cs.xf2rav(xform)
arc = cs.vnorm(av)
assert ref == 1
assert arc > 0

This is very strange.  The template and generated code definitely have 6x6.  I can look at this once I have access to the test kernels.

This is a copy and paste error.  cspyce1.py line 873.
ckfrot -> ckfxfm.


Do mvn package before exec:exec

Tried to test this out. It seems we should always do "mvn package" (or compile) first, otherwise the main class will be missing.

LGTM - I know Kevin has / will sign the CLA internally.

Yeah, I have signed the CLA. For some reason when create a PR directly from Gitbub, it doesn't show up :D


Spark Change - CoarseGrainedExecutorBackend

org.apache.spark.executor.CoarseGrainedExecutorBackend
Before:
After:
case message: OapMessage =>
      OapMessageUtils.handleOapMessage(message)

Reason:
To route OAP RPC messages.
NOTE:
This will be resolved by #623

Resolved.


Turn off autogenerate

Hi,
Is there a way to prevent typedoc from autogenerating documentation that you have no explicitly set doc strings for.
For example i only want it to generate documentation if i have something like the following above a fucntion call.
   /**
     * Represents a book.
     * @constructor
     * @req {string} title - The title of the book.
     * @res {string} author - The author of the book.
     */

I don't want it to autogenerate based on my code, but only when i explicitly define these comments.

Hello @KayHS, TypeDoc does not currently support this use case. This should be possible with a plugin, however unfortunately we don't have documentation on how to create plugins at the moment. You might be able to learn from an existing plugin.

I'm going to close this as I don't anticipate adding this feature. You may want to use the @ignore tag to avoid generating documentation on specific comments. Feel free to comment and ask questions.


thumbnails added

@Ren22 the PR fails to pass the tests, plz take a look

@intsco seems that it happens because of the new field in database, will check it

Has data migration been discussed? The existing datasets that have optical images will need to have thumbnails generated before we can deploy this.

@LachlanStuart good point. A migration script should also be provided

The migration script works for me. Here's what's left:

The test_dataset_manager test_add_optical_image test is failing because post_image gets called 4 times but the mock is only given 3 return values in the side_effects
This issue: https://github.com/METASPACE2020/sm-webapp/pull/39/files#r190954053


Abstract state with resolve

This is mostly a question: is this possible? I have several route configs that look like this:
    $stateProvider
        .state('event-reserve', {
            url: '/event-reserve/{id:int}',
            params: {
                id: 0,
                event: {},
                course: {},
                group: {}
            },
            controller: function ($scope, members) {
                this.members = members;
            },
            controllerAs: 'vm',
            template: '<eventreserve members="vm.members"></eventreserve>',
            resolve: {
                members: ['memberService', function(memberService) {
                    return memberService.getMembers();
                }]
            }
        });

If I were doing old-style 1.X angular, I would create an abstract event route and resolve my common objects there. Then the route above would be a child: event.reserve.
Has anyone used abstract routes with resolves using the NG6-starter? I can't picture how it would work given that there is no template associated with my abstract route.

So this turns out to work with the same wrapper workaround.
My parent module defines the abstract state:
let eventModule = angular.module('app.events', [
    uiRouter,
    EventDetail.name,
    EventRegister.name,
    EventReserve.name,
    EventPayment.name
])
    .config(($stateProvider) => {
        'ngInject';

        $stateProvider
            .state('event', {
                abstract: true,
                url: '/event/{id:int}',
                params: {
                    id: 0
                },
                template: '<ui-view />',
                resolve: {
                    event: ['$stateParams', 'eventService', function($stateParams, eventService) {
                        return eventService.getEvent($stateParams.id);
                    }]
                }
            });
    });

Then my child gets the resolved data the same way as if the resolve was on it's own route config:
let eventDetailModule = angular.module('eventDetail', [
    uiRouter
])
    .config(($stateProvider) => {
        'ngInject';

        $stateProvider
            .state('event.detail', {
                url: '/detail',
                controller: function ($scope, event) {
                    this.foo = event;
                },
                controllerAs: 'vm',
                template: '<eventdetail foo="vm.foo"></eventdetail>'
            });
    })
    .component('eventdetail', eventDetailComponent);

I have foo defined as a binding on the component, and this.foo is resolved on my controller constructor.


Collect clicks on subjects accessed

This issue is to track the number of clicks made on different subjects on the Body, Topics, and Test tab.
CanBeWell 1.0 team will research further to see the possibilities of implementing and Analytics team will plot the data on the dashboards

tested and fixed


What can be used for "username" when using PublicClientApplication/UserNamePasswordParameters?

Examples only seem to show the userPrincipalName(UPN) value being used along with the generic /organizations URL.
Can other values be used to authenticate a user?  For example:  samAccountName, or onPremisesUserPrincipalName?  Using a value which does not include a domain would obviously require the usage of a tenanted endpoint for the authority.
There does not seem to be much documentation or guidance around this.

Hello @Mark-Palmer-Imprivata : What sort of values were you hoping to use? I believe UPN is the recommended option, and I haven't seen anything else used for the username/password flow or documentation covering anything else.
However, according to this page it seems like there is a way to set up email as an alternative sign option for your active directories/tenants. Our library just sends the requests to the token service and handles the response so it would depend on how the backend server handles it, but perhaps if you set that up for your AD then you may be able to get tokens using email/password.

This question was to try to understand what is possible - I suspected UPN was the main use case, and I think I remember seeing something about email address previously (but, I also recall seeing that UPN is typically the same as the users email address).
This question came about from a use case related to Azure AD Connect:

User is synced from local AD to Azure AD.
Users UPN in local AD contains Unicode characters.
Azure AD Connect converts Unicode characters into underscores in the Azure AD UPN.
If the desire is to allow the user to login using the UPN from their local AD, this does not seem possible - but using the Azure AD UPN with the underscores in it works.  We know that there is an attribute called onPremisesUserPrincipalName that contains the Unicode-escaped version of the local AD UPN, but that can't be used to authenticate.

We also know that Azure AD itself does not permit entering Unicode characters for UPN/password when creating a user.
The goal is to try to understand what is actually supported.

Closing due to inactivity. If you have any other related questions or issues, feel free to leave a comment or re-open.


BeanPropertyDefinitions not compatible with Jackson 2.7.x

We use Springfox in a project that we'd like to upgrade from Jackson 2.6.x to 2.7.x. However, BeanPropertyDefinitions is indirectly used and this class is not compatible with Jackson 2.7.x, due to a change to the POJOPropertyBuilder constructors.
The issue can easily be reproduced by building Springfox with the following change:
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index bf13446..cc3bf8f 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -3,7 +3,7 @@ ext {
   classmate = "1.3.1"
   groovy = "2.4.5"
   guava = "18.0"
-  jackson = '2.6.4'
+  jackson = '2.7.3'
   joda = "2.9.1"
   jsonPath = "2.1.0"
   mockito = "1.10.19"

The build then fails as follows:
.../springfox/springfox-schema/src/main/java/springfox/documentation/schema/property/BeanPropertyDefinitions.java:70: error: no suitable constructor found for POJOPropertyBuilder(PropertyName,AnnotationIntrospector,boolean)
            = new POJOPropertyBuilder(new PropertyName(beanProperty.getName()),  annotationIntrospector,  true);
              ^
    constructor POJOPropertyBuilder.POJOPropertyBuilder(POJOPropertyBuilder,PropertyName) is not applicable
      (actual and formal argument lists differ in length)
    constructor POJOPropertyBuilder.POJOPropertyBuilder(MapperConfig<?>,AnnotationIntrospector,boolean,PropertyName,PropertyName) is not applicable
      (actual and formal argument lists differ in length)
    constructor POJOPropertyBuilder.POJOPropertyBuilder(MapperConfig<?>,AnnotationIntrospector,boolean,PropertyName) is not applicable
      (actual and formal argument lists differ in length)

Are there plans to make Springfox compatible with the latest version of Jackson?

2.7 jackson has been a terrible release causing quite a few breaking changes. Since were [tracking springs dependencies](https://spring.io/blog/2016/04/06/spring-framework-4-3-goes-rc1, really trailing by one release, just to ensure compatibility It might not be until 4.4 spring is released. Really the upgrade to jackson dependencies have been pretty seamless up until now, so we want to error on the side of caution and uprev the dependency in lockstep with projects like spring-data, spring-hateoas etc.

@dilipkrish, thanks a lot for this. The change seems to work well!
One little snag: on large projects with Jackson 2.7 the log statement statement at PojoPropertyBuilderFactory.java:98 produces a lot of ERROR log messages with lengthy stacktraces. We can suppress these on our side, of course, but arguably the message should be DEBUG level, rather than ERROR. WDYT?

@Stephan202 thats an oversight. I'll fix that


[Request] Possibility to render custom component for input field?

Thanks for the hard work that went on this package!
I saw that an optional renderTextInput prop is available, to display a TextInput with custom props. Is it somehow possible to render a custom component instead?
My need arises from using NativeBase as UI framework, so rendering a <Input /> component fdrom native base would keep my input fields visually consistent.
Is it already somehow possible?
Thanks

You can pass any component you want to renderTextInput. If you look at the tests you can see that you can pass a different component, like Text. If you can think of a way to make this clearer in the documentation, please make a PR for the README. Thanks!


Bump security-checker version to ^5.0

Bump security-checker version as recommended here https://twitter.com/fabpot/status/1067085006542118913
Here #157 we changed the domain but the package version remained at v4.1.

Thanks! :-)


Minecraft Forge Server Patches

Closed by https://github.com/thecatcore/Apron/commit/6c39c8f39e0c9bc6bfec9b21f959c730a3e7f6ec


Improve the inventory loading email.

Make the inventory loading email more interesting with details of what pipelines have run, how many resources have been processed, and the status.
Example.

Fixes #106

You're right. I forgot that format() must be used for column names.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


[⚡e2e]: create a directive "find element by xpath"

As a test writer, I want to have the capability to select an element by XPath
See #2263
Syntax:
  Then find the element by XPath "//*[@id="something"]/div"

:tada: This issue has been resolved in version 5.0.0-beta.17 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG]not support @ in password when auth

Describe the bug
Only support alphaNum in password now, but need to support such as @,!.

@cdyue
Yeah makes sense. We are working on it, and this issue will be properly addressed in the next release. We'll keep you posted.

yes my password also has a non alphanum character.  Can't use etcdmanager because of that.

@kesavkolla @cdyue
The fix has been merged into master, you should be able to use any UTF8 string now. We will publish a new binary release later this week.
Should the problem resurface, please reopen!

@gtamas Thanks.


Update ErrorBoundary to use miette::Diagnostic instead of Error, and various other tweaks

So my goal here has always been to have one standard, pretty page for errors, and a general way to catch errors both at the routing level and inside the app.
This PR should allow one to use one template for both kinds of Errors, and provide additional metadata. It also creates a neat(IMO) way to map between unique Rust Errors and HTTP statuscodes.
You can see it working in the todo_app_sqlite_axum example.
What's still left would be making error_template actually return the error code from the Rust error, but I wanted to get input on this app structure.
It also adds miette as a dependency, which should have a small impact on WASM size, but we should test it.

So this should be ready to merge, assuming the test passes. The todo_sqlite_axum example has been updated to show a more complete error handling scheme, and there are still some convenience changes to unify Error handling and clear up some API quirks

Yeah looks good. But I think you can remove the miette dependency from leptos_dom, right?
I'm also wondering if we should abstract away from making the HashMap that's internal to Errors public: i.e., give ways to insert and remove and get an iterator, but without promising that it's backed by a HashMap? (For example given the likely small n here it's almost always more efficient to store them in a Vec<_> and do a linear search.)
This PR is already a breaking change from 0.1.3 (because the callback is RwSignal<Errors> instead of Option<RwSignal<Errors>> so if there are any other API changes we should make them now.

Forgot to save that file.
I mean we certainly could limit visibility to the HashMap, I'm just not sure I want to reimplement all or some of hashmap's methods.
I thought you wanted HydrationKey so you can do cleanup?


Feature request: Input available in the debug console

VSCode Version: 1.11.0
OS Version: Mac OS X 10.12.3

You cannot debug any program which requires Input from the standard input because the debug console does not support input (in particular with Node.JS).
So the feature request is the ability to select the Debug Console output window and send there input (keystrokes), while preserving the bottom console input.

@delian by default, node debugging uses the debug console which does not support reading input (because it is a REPL too). Please add a console attribute to your launch config and set it to either integratedTerminalor integratedTerminal.  See documentation: https://code.visualstudio.com/docs/editor/node-debugging#_node-console


ci: add lint to build requirements

Signed-off-by: Mike<EMAIL_ADDRESS>

Codecov Report

Merging #77 (840a7c3) into master (c0c7d38) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   33.06%   33.06%
=======================================
  Files          59       59
  Lines        3163     3163
  Branches      498      498
=======================================
  Hits         1046     1046
  Misses       1953     1953
  Partials      164      164

Impacted Files
Coverage Δ

src/ClientActions.ts
96.96% <ø> (ø)

src/repositories/AMTDeviceFileRepository.ts
15.38% <ø> (ø)

src/DomainCredentialManager.ts
79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c7d38...840a7c3. Read the comment docs.

Codecov Report

Merging #77 (840a7c3) into master (c0c7d38) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   33.06%   33.06%
=======================================
  Files          59       59
  Lines        3163     3163
  Branches      498      498
=======================================
  Hits         1046     1046
  Misses       1953     1953
  Partials      164      164

Impacted Files
Coverage Δ

src/ClientActions.ts
96.96% <ø> (ø)

src/repositories/AMTDeviceFileRepository.ts
15.38% <ø> (ø)

src/DomainCredentialManager.ts
79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c7d38...840a7c3. Read the comment docs.


State transitions when onEntry throws an Exception

If a runtime exception is thrown during onEntry (StateMachineConfig) Action, the state machine still transitions to the target state. In my particular use case, the onEntry actions and the state transition are intrinsically tied and therefore must either both be executed or no transition should occur at all.
Example:
phoneCallConfig.configure(State.Ringing)
        .onEntry(new Action() {
            @Override
            public void doIt() {
                throw new RuntimeException("Deliberately thrown");
            }
        });

In the above snippet, the onEntry action always fails but the state always transitions to Ringing. For what I'm doing at the moment, onEntry must complete for the state to transition.

Option A: onEntry should never affect the state transition. Users will have to write their own fork of stateless4j to handle this case
Option B: onEntry should complete, otherwise 'roll back' the transition
Option C: Expose a facility in the framework to allow atomic transition and onEntry actions

Any preferences/advice from the stateless4j community on how to implement my requirement?
Thanks
Jonathan

If you need to conditionally leave the state, try to use permitIf while configuring state.


Benchmark failures - bugs/missing operations

[x] GroupBy.value_counts
[ ] iloc
[x] select_dtypes
[ ] Repartition misses keyword-argument partition_size
[ ] GroupBy.apply
[x] set_index
[x] grouping by a Series object
[ ] grouping by an Index object
[x] assign with callable
[ ] GroupBy.agg shuffle keyword
[x] missing align step in add/sub, ...
[x] missing keywords in read_csv
[x] "p2p" shuffle

Not planning on fixing all of them immediately, just collecting failures and fixing what was on my agenda anyway or is a very small fix.
Reference build: https://github.com/coiled/benchmarks/actions/runs/5310108176/jobs/9611644148?pr=837

@mrocklin thoughts on partition_size in repartition? This triggers an immediate computation in dask/dask, but I think we could reasonably defer this to compute time

I think that anything we can defer we should defer.
I think that for this value in particular we'll likely have to compute it if anything asks us for divisions.

closing, those all work


Review of pruning

Fixes #3487.

pruning: present only inbound connections to the pruning policy
pruning: fix typos
pruning: include current connection in the choice map
pruning: improved logging
pruning: set connection state to TerminatedState
pruning: factor out pruning
pruning: do not prune in Duplex → InboundState transition
pruning: improved a comment

bors merge

bors cancel

Also isn't it worth it to update the docs in this PR?

Also isn't it worth it to update the docs in this PR?

Neil is reviewing the documentation right now, so it's better not to interfere with his work.

bors merge


Breaks on firefox

Hey,
Great package! everything works just fine on safari and chrome but refuses to upload files on firefox. Here is the error:
File.lastModifiedDate is deprecated. Use File.lastModified instead.  app.js:14048:16 SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data[Learn More]  lepozepo_cloudinary.js:224:20 	Cloudinary._upload_file/</< http://localhost:3000/packages/lepozepo_cloudinary.js:224:20
How can I fix this?

Can confirm, Mozilla is deprecating the portion of the Files api. https://www.fxsitecompat.com/en-CA/docs/2016/file-lastmodifieddate-has-been-deprecated/

Awesome, I'll have a look as soon as I can. PRs are always welcome though :D

I was considering that but could not find the call for the method in the code base.
Maybe it's in one of the supporting libraries used to run the package?

@NicholasEli I found out what was causing the issues! (I hope....)
After hours and hours of searching for that line, and finding nothing, ...
Turns out that the error has nothing to do with this package! You will not believe this but what is throwing the error is this line console.log("file: ", file);
I think firefox did not like what I was logging to the console... which is the file i got from event.target.files[0] .
Maybe go back into your code and check if you are facing the same issue.


[ISSUE #8697]feat:When starting the broker and nameserver, the xmx, xms, and xmn p…

[ISSUE #8697]When starting the broker and nameserver, the xmx, xms, and xmn parameters in the JVM can be passed
Which Issue(s) This PR Fixes
Fixes #8697
Brief Description
Modify the runbroker. sh and runserver. sh files to include judgments for xmx, xms, and xmn. If not passed in, use the default values.
How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.36%. Comparing base (c5ac8a4) to head (810c56e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8788      +/-   ##
=============================================
- Coverage      47.43%   47.36%   -0.07%
+ Complexity     11577    11561      -16
=============================================
  Files           1282     1282
  Lines          89864    89864
  Branches       11563    11563
=============================================
- Hits           42623    42563      -60
- Misses         41998    42056      +58
- Partials        5243     5245       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ideas On Decentralizing ZeroLink

One way would be to use CoinShuffle's model, however that still requires a central server, even though it conducts less coordination and it functions more like a message board, rather than a coordinator as ZeroLink's coordinator. I'm not sure that adds substantial plausability for the operator of the server.

Another way could be to introduce fees to the system. A back end could act as a registrar for coordinatiors, where coordinator could be anyone. The users in InputRegistration phase would always register their inputs to the coordinator that is online with and offers the smallest mixing fee and the most registration. When a new coordinator comes online with smaller fee, the user could automatically switch.
The beauty in it is that eventually only altruistic zero fee coordinators would compete with each other. When a coordinator gets shut down for various reasons, there would always be a new one that is ready to take its place and it wouldn't require manual coordination from the users to switch to this.

While the Byzantine Cycle Mode topic was closed, because compared to ZL it worsens privacy, but it actually gives a neat tool to come to consensus in a decentralized way on the question: "Among many solutions, which solution should the peers settle on?"


AvailableCountries to AvailableCountriesAndRegions

My first open source contibution.
Kindly merge it if you are satisfied !!

Can one of the admins verify this patch?


Date breaking build (slightly different than previous date breaking issues)

I'm playing with prose on a Jekyll test site that can be found at rdwatters.github.io. I currently sort my posts by the date: field in a post's metadata. That said, I only use the year, month, and date (eg, 2015-09-01).  This doesn't cause any issues for sorting on local dev, but because prose.io saves the full date (ie, including, h, s, etc), my builds are breaking when I update posts in prose. I would like to have the option for two separate dates in the metadata--one for publish_date (ie, the date that writes to the page, since this gives editors more control over what end-users see) and one for date (maintained by Jekyll/prose auto-magically. However, my attempt at a workaround to use publish_date resulted in prose doing the same thing w/r/t adding the full date automatically. Am I missing something in the config? I would like for authors to be able to change these dates at will. Thanks!

@rdwatters we do need to create a date metadata field - see #760. In the meantime, the best stopgap is to manage your date using a text element. You can pair this with a hidden element containing the creation date as below.
- name: "creation_date"
  field:
    element: "hidden"
    value: "CURRENT_DATETIME"
- name: "publish_date"
  field:
    element: "text"
    placeholder: "yyyy-mm-dd"

Dereklieu, thanks so much for the quick response on this. I'll attempt the workaround this evening and get back to you. Any thoughts on an ETA for the data metadata field? Cheers.

@rdwatters great. Not sure on ETA, there's a couple of things I've been meaning to work on but if I have time over the long weekend I'll try to get to it.

@dereklieu So, as it turns out, the above workaround doesn't actually work. I created a published_on and a created date per your suggestion:
metadata:
    _articles:
      - name: "updated_date"
        field:
          element: "hidden"
          value: "CURRENT_DATETIME"
      - name: "title"
        field:
          element: "text"
          label: "Title"
          placeholder: "Enter the title of this article"
          value: ""
      - name: "description"
        field:
          element: "textarea"
          label: "Article Description"
          help: "Write a short description of this article. Try to keep it to less than 200 characters."
      - name: "published_on"
        field:
          label: "When this article was published"
          element: "text"
          placeholder: "Enter as yyyy-mm-dd"
      - name: "published"
        field:
          element: "checkbox"
          label: "Publish now"
          help: "Keep this unchecked if you do not want to   publish the article right now"
          value: "true"
      - name: "layout"
        field:
          element: "hidden"
          value: "article"
      - name: "main_image"
        field:
          element: "text"
          label: "Article image"
          value: "Full filename of the image you want to use"
      - name: "main_image_description"
        field:
          element: "text"
          label: "Article image description"
        value: "Write a descrption of the image used for the   article"
      - name: "comments"
        field:
          element: "checkbox"
          label: "Include comments?"
          value: "true"
      - name: "insearch"
        field:
          element: "checkbox"
          label: "Include in search?"
          value: "true"

I am able to sort on the published_on date, but the problem is that when I enter a date as a string, it writes the metadata to the file in quotes; e.g., writing 2015-08-10 into the field in the prose editor writes published_on: "2015-08-10" to the markdown file, which then breaks the Jekyll build. When I open the same document again in prose and open the metadata, that field will then contain the full date, including seconds and hours. Any thoughts on this?

@dereklieu Any update on this? Thanks for all your feedback!

I seem to be running into a similar issue that when I use CURRENT_DATETIME (in quotes or not) prose writes it in quotes which subsequently breaks the build when an unquoted date wouldn't (in this case for pelican).


Deal with player transferences during a season

Context
For players that are transferred in the middle of the season, the might have appearances in two different clubs (even within the same league). When this happens, we are not able to correctly identify which club the player was playing for at the time of the appearance.
Example
For example geoffrey-kondogbia moved from  to atletico-madrid after playing some games for fc-valencia, which caused early season appearances to be tagged as if he played for atletico-madrid (his current team). They should be fc-valencia, as this is the team he was playing for by the time of the appearance.
How to fix
Fixing this required a change in the scraper to parse for which club a player was playing for in a new column. The problem has been addressed and solved at this PR. Now we need to adapt player-scores to work with this new version of the scaper.
How to validate
In order to find the faulty rows, show appearance for teams that fail validation
print(games_per_season_per_club)
rows = df[(df['season'] == 2018) & (df['club_domestic_competition'] == 'ES1') & (df['competition'] == 'ES1') & (df['player_club_name'] == 'athletic-bilbao')]
pandas.set_option('display.max_rows', rows.shape[0]+1)
print(rows[['date', 'round', 'home_club_name', 'away_club_name', 'game_id', 'player_club_name', 'player_name']].sort_values(by='date'))

This has been resolved after dataset normalization


No sideband data stored for push

This seems like it could be a regression since https://github.com/src-d/go-git/pull/573. I haven't been able to see any sideband data for push for a few months now, while clone stores sideband data just fine. I should've reported this earlier, I thought it was user error at first (hey, maybe it still is!)
Steps to reproduce:

Run the progress example, and see that sideband works fine with clone.
Add Progress: os.Stdout to the push options in the push example and see no sideband data written to os.Stdout.
Push to GitHub using the original implementation's example and see no sideband data written to os.Stdout.

Let me know if I can provide any more details. Thanks!

I'm experiencing this as well and I think I know where it comes from.
The offending line is plumbing/protocol/packp/report_status.go:77.
ReportStatus breaks out on the first flush (30 30 30 30 which is 0000 in ASCII) - however if I understand the protocol correctly, flush does not necessarily mean EOF - it means end of band!
Here's an example response I get from my personal GitLab instance when pushing a branch that is not the default, in which case GL sends a message over band 2 (the verbose band) with a link to immediately create a merge request:
30 30 33 31 01 30 30 30 65 75 6E 70 61 63 6B 20 6F 6B 0A 30 30 31 61 6F 6B 20 72 65 66 73 2F 68 65 61 64 73 2F 64 65 76 65 6C 6F 70 0A 30 30 30 30 30 30 38 35 02 0A 54 6F 20 63 72 65 61 74 65 20 61 20 6D 65 72 67 65 20 72 65 71 75 65 73 74 20 66 6F 72 20 64 65 76 65 6C 6F 70 2C 20 76 69 73 69 74 3A 0A 20 20 68 74 74 70 73 3A 2F 2F 6D 79 2E 67 69 74 6C 61 62 2E 69 6F 2F 72 65 70 6F 2F 61 62 63 64 65 66 67 68 69 2F 6D 65 72 67 65 5F 72 65 71 75 65 73 74 73 2F 6E 65 77 3F 6D 65 72 67 65 5F 72 65 71 75 65 73 74 25 35 42 73 6F 75 72 63 65 5F 62 30 30 31 37 02 72 61 6E 63 68 25 35 44 3D 64 65 76 65 6C 6F 70 0A 0A 30 30 30 30
Fully translated to ASCII this is:
001aok refs/heads/develop
00000085
To create a merge request for develop, visit:
  https://my.gitlab.io/repo/abcdefghi/merge_requests/new?merge_request%5Bsource_b0017ranch%5D=develop

0000```

I've prepared a gist that breaks the above down byte-by-byte and runs it through the demuxer raw. The demuxer itself handles this correctly, the issue definitely lies somewhere within the status report bits. Comments indicate number of bytes, running total in parentheses, followed by the meaning of those bytes. For the most part this'll just be the ASCII above ;)

Note how the first flush is part of the band 1 payload (as in, those 4 bytes are counted towards band 1's length), the last flush however is not part of the payload.

I'm going to step through the code with delve a bit to identify exactly where it goes wrong; whether it's the scanner misreading the four zeroes as an empty string (resulting in `len(b) == 0`) or if it really is the line above on its own.

Replace that break with continue and everything will work as it should; sidebands will be decoded correctly in full and without errors. Tests also still pass. I can create a PR for this, however it would perhaps be good if one of the maintainers took a look at this and perhaps remembers if there was a specific reason to have this in there. From my point of view it just seems to assume "flush means done, so quit", but that's not technically the case :)
I took a quick look at the "real" git code and it looks like recv_sideband just runs until EOF, flushes don't abort anything.

@Werelds We probably missed this. A PR would be welcome, but we'll need to add a specific test for this to verify the change. Thank you!

For reference: both send-pack and fetch-pack use the same recv_sideband.
We'd obviously have io.Writer parameters for each band instead, which is then more than flexible enough to discard bands if necessary, use a byte buffer or decode on the fly as necessary.

@Wereds,
Are you still working on this?
Thanks!

Unfortunately, not right now, no! Being the only remaining backend developer in a team has some downsides ;)
Hopefully soon I'll have a bit more time again to look at a better solution.
I still stand by what I said above: to handle sidebands correctly, the ideal fix should follow Git's example and not attempt to save a few hundred microseconds by not always fully decoding.

Hi - we'd like to try and find a resolution to this issue.
We have a problem where it looks like this is causing a functional issue rather than simply a cosmetic issue of no output being displayed.
We have a git server which is configured with some hooks that perform actions when commits are pushed to the server, and the server is returning sideband information to the client while processing the hooks. We see issues with the hooks not being executed which only occur when we are pushing to our server using the go-git library (everything works correctly using the command line git client). Our suspicion is that the client is breaking the connection early (due to the break statement mentioned above) and this is interrupting the server's processing of the hooks. If I simply change this break to a continue as @Werelds suggested, pushing using the library works correctly and our server is able to process its hooks.
Is someone able to take a look at this? Is PR #821 on the right track?


Invalid HAPROXY_{n}_xxx template labels in one app can break haproxy config

In a cluster with many users, a single app containing bad HAPROXY_{n}_xxx template labels will result in a bad overall haproxy config.
The effect of this is that already started marathon-lb instances will stop updating, and new marathon-lb instances cannot start.
An example "bad label":
HAPROXY_0_BACKEND_SERVER_OPTIONS: "  server {serverName} {host_ipv4}:{port}{cookieOptions}{healthCheckOptions}{otherOptions}  timeout server 600s"
(this particular bad label was produced by attempting to edit it using the dcos ui, which removes some of the critical line endings from the string)

i got the same issue:
my "bad label":
HAPROXY_0_BACKEND_SERVER_OPTIONS= server {serverName} {host_ipv4}:8090{cookieOptions}{healthCheckOptions}{otherOptions}\n
the result in haproxy.cfg:
backend release_dolphin_10069
balance roundrobin
mode http
option forwardfor
http-request set-header X-Forwarded-Port %[dst_port]
http-request add-header X-Forwarded-Proto https if { ssl_fc }
server 192_168_30_214_31309 <IP_ADDRESS>:8090\n
if i scale my app to 2 or more :
the result in haproxy.cfg will be:
backend release_dolphin_10069
balance roundrobin
mode http
option forwardfor
http-request set-header X-Forwarded-Port %[dst_port]
http-request add-header X-Forwarded-Proto https if { ssl_fc }
server 192_168_30_214_31309 <IP_ADDRESS>:8090\n  server 192_168_30_215_31310 <IP_ADDRESS>:8090\n

i was wrong。 config in json mode ：
"HAPROXY_0_BACKEND_SERVER_OPTIONS": "  server {serverName} {host_ipv4}:8090{cookieOptions}{healthCheckOptions}{otherOptions}\n"
it works well

I believe this is resolved - please let me know if I need to reopen.


Crosshair: move line color to a prop

I can do the same for the line width, if that makes sense.

@mcnuttandrew I updated the PR to use style objects. Do you think I should move the default styles to JS? It may be best to keep them in CSS, otherwise I think it breaks the possibility for the users to override them in their own stylesheets.


ESP f/w F152642521 for CAR.RAV4H_TSS2

DongleID 08ae2ec6875e165c

I see three mismatches.
(0x700, None) - b'\x018966342X6000\x00\x00\x00\x00'
(0x7b0, None) - b'F152642521\x00\x00\x00\x00\x00\x00'
(0x7a1, None) - b'8965B42181\x00\x00\x00\x00\x00\x00'

I only see the 1 missing firmware for ESP, which is what I added in my original PR.  That was based on this FPv2 output...
      ( ecu = engine,
        fwVersion = "\x018966342X6000\x00\x00\x00\x00",
        address = 1792,
        subAddress = 0 ),
      ( ecu = esp,
        fwVersion = "F152642521\x00\x00\x00\x00\x00\x00",
        address = 1968,
        subAddress = 0 ),
      ( ecu = eps,
        fwVersion = "8965B42181\x00\x00\x00\x00\x00\x00",
        address = 1953,
        subAddress = 0 ),
      ( ecu = fwdRadar,
        fwVersion = "\x018821F3301400\x00\x00\x00\x00",
        address = 1872,
        subAddress = 15 ),
      ( ecu = fwdCamera,
        fwVersion = "\x028646F4203500\x00\x00\x00\x008646G2601200\x00\x00\x00\x00",
        address = 1872,
        subAddress = 109 ) ],

For reference, this change worked  for me (on the dongle mentioned in the commit). The car was recognized and open pilot worked.

Hmm, I don't exactly understand the mismatches, but I don't see how this hurts to merge.


Rename package from gnosis-py to safe-eth-py

gnosis-py was also updated to point to this package: https://pypi.org/project/gnosis-py/


sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: users.password_hash [SQL: 'SELECT users.id AS users_id, users.username AS users_username, users.role_id AS users_role_id, users.password_hash AS users_password_hash \nFROM users \nWHERE users.username = ?\n LIMIT ? OFFSET ?'] [parameters: ('Tyrel', 1, 0)] (Background on this error at: http://sqlalche.me/e/e3q8)

Hi! I've been encountering this issue for a while & I'm totally lost. I even did a checkout of version 8b, and still this issue prevails. Also did a flask db upgrade, but no luck. Much appreciated!
Here's the output from the flask db upgrade command:
$ flask db upgrade
INFO  [alembic.runtime.migration] Context impl SQLiteImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.

EDIT: Still struggling, but found something interesting; Found out that my users table doesn't have a password_hash column (which is clear from the error message), but for some reason flask db upgrade isn't fixing this. Any ideas?
$ sqlite3 data-dev.sqlite
SQLite version 3.22.0 2018-01-22 18:45:57
Enter ".help" for usage hints.
sqlite> .schema
CREATE TABLE alembic_version (
	version_num VARCHAR(32) NOT NULL,
	CONSTRAINT alembic_version_pkc PRIMARY KEY (version_num)
);
CREATE TABLE roles (
	id INTEGER NOT NULL,
	name VARCHAR(64),
	PRIMARY KEY (id),
	UNIQUE (name)
);
CREATE TABLE users (
	id INTEGER NOT NULL,
	username VARCHAR(64),
	role_id INTEGER,
	PRIMARY KEY (id),
	FOREIGN KEY(role_id) REFERENCES roles (id)
);
CREATE UNIQUE INDEX ix_users_username ON users (username);

For extra clarity, here is my templates/models.py file:
from werkzeug.security import generate_password_hash, check_password_hash
from . import db

class Role(db.Model):
    __tablename__ = 'roles'
    id = db.Column(db.Integer, primary_key=True)
    name = db.Column(db.String(64), unique=True)
    users = db.relationship('User', backref='role', lazy='dynamic')

    def __repr__(self):
        return '<Role %r>' % self.name

class User(db.Model):
    __tablename__ = 'users'
    id = db.Column(db.Integer, primary_key=True)
    username = db.Column(db.String(64), unique=True, index=True)
    role_id = db.Column(db.Integer, db.ForeignKey('roles.id'))
    password_hash = db.Column(db.String(128))

    @property
    def password(self):
        raise AttributeError('password is not a readable attribute')

    @password.setter
    def password(self, password):
        self.password_hash = generate_password_hash(password)

    def verify_password(self, password):
        return check_password_hash(self.password_hash, password)

    def __repr__(self):
        return '<User %r>' % self.username

wow... so i totally missed the part where you have to run flask db migrate -m "initial migration". Did that, everything works perfectly now. Thanks anyway!


updated Adjacency

This pull request address a number of issues with Adjacency() class.
Fixes #94, #93, #90, #83, #82, #81
Also fixes #91 bug in Brain_Data

Coverage increased (+1.03%) to 53.81% when pulling 555587f01c318a7eb1ee800b57d1d41d4c28ba37 on update_adj into 54b784471274bc7a7cfeda432acc1db6b42338b3 on master.


SW-2720 Replace momentjs usage with luxon in terraware-web

also update web-components to pick up DatePicker and date utils changes that leverage luxon

TODO Fixes:
date/timezone issues - showing one day in the past or future (accessions, viability testing, scheduling observations)
Test Monitoring Charts

Nice update!
Are the "todo fixes" mentioned in the PR description new regressions from these changes or pre-existing issues or ?

Nice update!
Are the "todo fixes" mentioned in the PR description new regressions from these changes or pre-existing issues or ?

Oops, thanks for catching that. The todos are outdated, no outstanding issues. Will update the comment.


Changing the color of PFD report

Description:
I am encountering an issue when generating PDFs from HTML content, the page size remains fixed, leading to blank white space when the HTML content does not fill the entire page.
Expected Behavior:
I expect the PDF page to be a defined color and not white.
Steps to Reproduce:
Generate a PDF from HTML content where the content height varies with a darker background.
Observe the PDF output to see that the pdf page is white from where the html content ends.

This issue has been resolved and an update is currently in development.


Count Palindrome Numbers in a Range

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Create a function that returns the number of palindrome numbers in a specified range (inclusive).
Problem Link: https://edabit.com/challenge/BRoBDeEc2be7wm8BD
Examples :
 countPalindromes(1, 10) ➞ 9

 countPalindromes(555, 556) ➞ 1

 countPalindromes(878, 898) ➞ 3

Before submitting a PR please Check some details. Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is valid for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

Hello, please assign me.

Hi  I would like you to assign this issue to me.
I have solved the complete problem and here is the output for the same.
PS C:\Users\vedant jolly\Desktop> python .\hacktober.py
1 10
9
PS C:\Users\vedant jolly\Desktop> python .\hacktober.py
878 898
3
I have performed the above code in python,

Hello! I would like to have this assigned to me.


Add version resource and client method

resolve #10

Coverage increased (+0.53%) to 93.24% when pulling 07ecc2ba036cfb0022d815daff11a207dcae52da on boie0025:nb/features/version into f3dd96ffe54963bfbc911ed55dab42046c70f662 on locomotivecms:master.


Push orphaned check notices to the event queue

Orphaned check condition should be logged and pushed to the event log. In some (most?) of the cases right now, it's just an error that bubbles up and ends up being thrown away.

Done in #152


Ability to run just one test in local_test_runner

Allow passing just one testname to local_test_runner.

👍  - once CI passes.


Generator name should be 'Flow XO'

The name is derived from the package.json name field, taking the portion after the generator- bit and capitalizing it. The best we can do is change the package name from generator-flowxo to generator-flowx-xo which would produce a name of Flow Xo - not sure if that's better or worse (also you'd have to re-install the generator)

That is incredibly dumb! I guess we should just leave it as it is.


🌟Feature request: Allow passing default value/custom store for inputValue into combobox builder

Is your feature request related to a problem? Please describe.
At the moment I struggle to change the initial value of an input field without user intervention. For example I am using combobox from melt-ui, and I am storing user's data in local storage. When the user visit the page, I want to update the inputValue based on the value I retrieve from local storage. At the moment it seems to be impossible
Describe the solution you'd like
Either the builder accept a new args, defaultInputValue for passing a string of default value, or the builder accept a user provider inputValue store in the args for createCombobox builder.
Describe alternatives you've considered
Passing the store from parent to combobox, and code the update logic there myself, but it is just very messy.
Additional context
Add any other context or screenshots about the feature request here.

This is currently possible, you can use the defaultSelected prop:
const {
		elements: { menu, input, option, label },
		states: { open, inputValue, touchedInput, selected },
		helpers: { isSelected },
	} = createCombobox<Manga>({
		forceVisible: true,
		defaultSelected: {
			value: userData.value,
			label: userData.label,
		},
});

If you need to update it after the page has loaded, you can use the store returned from the builder:
const {
		elements: { menu, input, option, label },
		states: { open, inputValue, touchedInput, selected },
		helpers: { isSelected },
	} = createCombobox<Manga>({
		forceVisible: true,
		defaultSelected: {
			value: userData.value,
			label: userData.label,
		},
});

// just an example, this could be trigger by a function call or whatever
$: if (userData) {
	selected.set({ value: userData.value, label: userData.label ?? userData.value })
}

I see. Sorry for missing that option, thank you for your response.


Slow plugin initialization

Using https://github.com/tweekmonster/startuptime.vim I can more accurately diagnose which scripts are taking longer to load than others. As you can see from the attached screenshot grepper takes quite a bit more time than other scripts. What matters here is relative speed (since I've got a pretty fast SSD), not absolute speed. After some investigation, it turns out that https://github.com/mhinz/vim-grepper/blob/32c002c239d1838636bd3787012dc319dc4c96ee/plugin/grepper.vim#L13 is the culprit, since it makes a system call to the git binary. Is there any way of optimizing the git version detection? Perhaps caching the result or providing an option so the user can opt-in to column-precision jumps? (which is what git's --column option is for)

Interesting, we've already discussed skipping this version check here: https://github.com/mhinz/vim-grepper/issues/178 but we've still added it later in https://github.com/mhinz/vim-grepper/commit/41310e3c62d0eda9e69c91a762ecfd05813cc236.
I would argue that startup speed is quite important as it can quickly go out of control with when using a lot of plugins (which is now common).

Well, the alternative is removing that code again and losing the feature, unless people set g:grepper.git theirselves, which they usually don't.
Debian stable (Stretch) still uses git 2.11 and git 2.19 is needed. Debian testing (Buster) has git 2.20 and enters Full Freeze in a few days which means that the next Debian release will be around June. Then we can assume that everyone should have an mostly up-to-date git and remove that check at all.

Okay, I added an optimisation for Git now: https://github.com/mhinz/vim-grepper/commit/62bd03f0b9dc6ab5217aa164753337893faac890
If git is used and g:grepper.git.grepprg is still the default, it now checks for the git version only once at the first invocation of :Grepper and not at source time.
Another user reported a substantial startup time reduction. Please test the latest version!

Definitely much faster:


Support vim snippet engines

Preliminary Steps
Please confirm you have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[x] considered implementing an override,
[x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description
There are various snippet engines for Vim, but none of them are supported by linguist.
Here are some of the most popular engines:

SnipMate (extension: .snippets)
UltiSnips (extension: .snippets)
Neosnippet (extension: .snip)

And some examples:

vim-snippets: SnipMate & UltiSnips
neosnippet-snippets: Neosnippet

UltiSnips and Neosnippet are (mostly) compatible with SnipMate, which means that SnipMate can be used as the only filetype if adding multiple filetypes for the same thing is not desirable.

I have checked the code and this issue is still relevant because Vim snippet engines are still not supported.

Support is only going to be added when someone opens a pull request adding support. Please feel free to review CONTRIBUTING.md and submit a PR if snippets meet all the criteria.


Update version to 2020.4.0 and add Changelog

Codecov Report

Merging #31 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   77.91%   77.91%
=======================================
  Files          22       22
  Lines         788      788
=======================================
  Hits          614      614
  Misses        174      174

Impacted Files
Coverage Δ

wellcomeml/__version__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786aae6...9dfa469. Read the comment docs.

This is awesome.

Let's do it. We can apply a release tag after merging this :shipit:

 WellcomeML improvements


Passport strategy not being called at all

I seem to not be able to call my JWT passport strategy at all, the reason that makes me think it is not calling it is that I am getting no output from a console.log which I would expect to run every time no matter whether the token is valid or not. Heck even if there was no token I think it should run.
Here is an example route of mine, keep in mind I am using controllers and that the method I am using has been used for both my login as well as sign up local strategies.
router.get('/auth/test',
  sessions.authorize,
  (req, res) => {
    res.send('You reached a private route.');
  });

Here is that controller/middleware I mentioned before
exports.authorize = (req, res, next) => {
	passport.authenticate('jwt', {
		session: false
	}, (err, token) => {
	    if (err) console.log(err);
	    next();
	})(req, res, next);
};

And finally my passport strategy. I have tried a few different opts.jwtFromRequest that I found here and on StackOverflow none of which worked so I went back to this one.
var opts = {};
opts.jwtFromRequest = ExtractJWT.fromAuthHeaderAsBearerToken();
opts.secretOrKey = config.passport.jwtSecret;
passport.use(new JwtStrategy(opts, function(jwt_payload, done) {
  console.log('payload received: ', jwt_payload);
    User.findOneById({id: jwt_payload.id}, function(err, user) {
      console.log('User: ', user);
      if (user) {
        console.log(user);
        return done(null, user);
      }
      if (err) {
        return done(err, false);
      }
    });
}));

I am using Postman with the authorization type of Bearer token and I am have tried just the plain token as well as doing JWT <token> with the space as well as JWT in lower case too.
I'm not sure what else might be helpful, hopefully someone can help as I have been at this for a few days now.

It seems like it is skipping my sessions.authorize, totally.  I was expecting to at the least see the output from console.log('payload received: ', jwt_payload);  but nothing from that shows.

Have you been able to solve you issue? This doesn't sound like an issue with passport-jwt, but a broader issue you are having with passport or your application.

I also have the same issue, I even copy-pasted the code from here and I got the same issue, not even the console.log from the JwtStrategy function is running.

Closing as the original author has not responded.


Error when building

I am getting the following error when running my node project
node_modules/valibot/dist/index.d.ts(2170,27): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,42): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,65): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,74): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,94): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,108): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2170,109): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,32): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,47): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,70): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,79): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,99): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,113): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(2197,114): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,55): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,71): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,87): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,96): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,104): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,123): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,125): error TS1434: Unexpected keyword or identifier.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,134): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3358,135): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,65): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,81): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,102): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,111): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,119): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,138): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,140): error TS1434: Unexpected keyword or identifier.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,149): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(3381,150): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,58): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,77): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,92): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,103): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,106): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,114): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,131): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,144): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,168): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,182): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5066,183): error TS1128: Declaration or statement expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,58): error TS1139: Type parameter declaration expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,77): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,92): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,103): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,106): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,114): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,131): error TS1005: ',' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,144): error TS1005: ')' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,168): error TS1109: Expression expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,182): error TS1005: ';' expected.
[tsc     ] node_modules/valibot/dist/index.d.ts(5226,183): error TS1128: Declaration or statement expected.

Does it work with the skipLipCheck option enabled?

I am facing the same thing when trying to build. it working fine though on dev

After rechecking valibot doc and my package.json again, I saw my typescript version was below the minimal requirement specify on the doc.

Upgrade typescript version >= 5.0.4 , the issue is resolve for me.

Are you able to upgrade?

I'm seeing this in several projects using typescript v4 (yes, with "skipLibCheck": true), and upgrading them to v5+ is not easy, as it would require upgrading several of their dependencies by major versions.
They will be upgraded (hopefully soon) but until then we can't use valibot.
I've found that when writing a library it's generally best to build it with a slightly older, more widely adopted version of typescript.

Valibot requires one or two features that were introduced with TypeScript >=v5. I do not plan to downgrade the requirement, but what I can consider is releasing a version of Valibot that supports TypeScript v4 as soon as Valibot reaches v1.

I will close this issue, but will reopen it if there is a good reason in the future.

i have updated the typescript version  still i m getting a same error Error - [tsc] node_modules/botframework-webchat-core/node_modules/valibot/dist/index.d.ts(2170,27): error TS1139: Type parameter declaration expected.

What is your TypeScript version and what is the Valibot version you are using?

Hi fabian-Hiller/,
Thank you so much for your reply!
I have fixed the issue no code is working fine for me.
Thanks,
Pawan Mishra
On Sun, 29 Dec 2024 at 7:37 PM, Fabian Hiller @.***>
wrote:

What is your TypeScript version and what is the Valibot version you are
using?
—
Reply to this email directly, view it on GitHub
https://github.com/fabian-hiller/valibot/issues/547#issuecomment-2564776347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODLP7XPBLT5TVVUXVT3EXT2IAQMHAVCNFSM6AAAAABUKQKV62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG43TMMZUG4
.
You are receiving this because you commented.Message ID:
@.***>


[TCE] Un-modal video

Currently
The last usage of jQuery on To Change Everything (TCE) is the video modal which uses Fancybox which depends on jQuery.

Preferred
Instead of showing the video in a lightbox/modal behind a click/tap, let's promote it to being displayed all of the time. No click / modal needed.
Let's put in the new row between the header and the current first row.
With  the video player on display, wide, not just a half-width column like the others below.
The video player should be responsive.

What about the current "watch video" cta, should it be removed and the download PDF centered?

@QueerSynd good question. I think the PDF cta would look weird centered by itself.
the actual goal is to drop jquery, so in theory we could keep the current style and do it all in vanilla js (honestly, we could probably do it all in css)
all that said, i do think the new layout @veganstraightedge proposed for the video would be nice (because it would be easier to hide for languages where we don't yet have a translation)
@veganstraightedge what do you think about the solo pdf cta? We actually have this in czech (css is janky there since it is still being served out of /public, but that will be fixed in #1904)
also, this just came to me while thinking through this, if we add a new row for the video, we could have a new CTA in that row requesting translations of the script (maybe link to a GH issue with the english script broken out line by line?)

A solo "download PDF" is fine for now. After it's solo, we can consider it if it feels weird by itself. And if so, we can reimagine how to handle it. 👍🏻

Hi, I've been out of the loop for a while, what is the status of this issue? Anything I can do to help close it?


Initial configuration minor improvements

Fix issue with abandoned interactions. Increase readability.
It is possible some interactions to stay ongoing when a session is over, mainly in case of emails.
To fix the case when a new session is unaware of those, the _this.initOngoingInteractions was introduced.
During the fix, the function of user initialization was extracted just for better readability.

Hi @AntonRozhanskii , could you please write a description for this PR?
Main problem in this PR is that it adds two new functions to the public API, even though they are marked @private and function name starts with underscore. Both of the functions are intended to be used only from within CPC.load and intention clearly is not to allow users to call these functions directly.
Function _this.initOngoingInteractions - This seems like a bugfix. It indeed could be so that user has ongoing interactions left open from previous Communication Panel session. And currently CPC is unaware of those. So the idea behind this seems like a good idea.
Function this._getUserData - This seems to be just an effort to improve code readability. However I'm not sure if this makes it better or worse, because now the this.hostAppEventHandler call would be inside this._getUserData , which I find unintuitive.
Please correct if I misunderstood some intentions.

Hi @cpc-dev-contactpro.
You totally got both ideas of the PR.
Regarding the usage of this.hostAppEventHandler, the approach I used allowed me to modify the event so it is ease to identify inside the event handler, also eliminating the possibility of building complex logic of distinguishing getDetails responses.
While both functions are meant to be called within the load, sometimes it might be useful to call them again. Maybe for development or debug need. It is also possible that something went wrong and for some reason initialization didn't succeed, this happened to us with interactions.
I would like to express my personal opinion. I believe that the load function might be refactored. From my personal point of view, the function is too big, and contains transitions between different levels of abstraction. But this work is better to be made within a separate PR.


Handle SMS messages longer than 160 characters

Fixes #1321
Change-Id: I1bb7050e0754bc9c027aad475e15aae2db677de0

I tested this with the newer emulator and also sent a companion to @PeterMathijssen for testing, and he confirmed it fixed his issue.


Fix issue with using window global in serverless context

The push gateway exporter has a reference to window, which won't be defined for serverless functions.

Closing in favor of a more general pr with beta testing fixes


Update README and remove startup script

Updates README and removes startup script as part of the migration to GOV.UK Docker.
Trello:
https://trello.com/c/Psf7EzPB/204-move-away-from-startupsh
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Cheers for the review @ChrisBAshton! Sure thing I've updated as per your comments.
As for the wrapped new lines. I personally prefer the lines to be shorter as I think they're easier to work with in general, my editor does this for me. However if you feel strongly about it I can remove the wrapping?

As for the wrapped new lines. I personally prefer the lines to be shorter as I think they're easier to work with in general, my editor does this for me. However, if you feel strongly about it I can remove the wrapping?

Not something I feel hugely strongly on, and there's no official guidance on this in things like the GDS Way, but ISTR it came out of a Slack conversation with @benthorner & others in the devtools channel, which concluded a dislike for hard-wrapping in markdown (but not in commit messages). It's been quietly adopted in a couple of PRs so far:
https://github.com/alphagov/link-checker-api/pull/456/commits/bc55e25667e793af4f92b6b1ee38183642cb1b8d
https://github.com/alphagov/publishing-api/pull/1936/commits/0aef8cda57b8c7910bc50ae6a2af21b600fe9790

Ah, okay. Well if it's been actively agreed upon then that's fair enough. I'll have to silence my markdown hints concerning line length! 😆


fix the updated hook with several v-draggables: use a WeakMap

Hi again,
#4 has some issues when using multiple v-draggables
binding.dir.updated is global for all v-draggables, so this wasnt the right thing ;)
i changed it, so it is using a WeakMap on the element

Sorry for the delay in response. Thanks again for your contribution, good idea with the WeakMap. Released this as 3.0.1.

Sorry for the delay in response. Thanks again for your contribution, good idea with the WeakMap. Released this as 3.0.1.


Use react-components for open traces and views and related updates

This change includes updates to propagate signals between webviews.
This will allow views to be updated when one view changes. For example,
when the user selects an open trace in the "Traces" view, the selection
is sent to the various react-components. The "Available Views" view
will use that signal as trigger to fetch the available views from
the remote server.

Remove analysis and traces tree view from the extension. They are
replaced by the theia-trace-extension react components and
corresponding webviews.

The classes AnalysisTree and TracesTree is still in the code base to
allow opening traces from the file system using the context sensitive
menu and "Open in Trace Viewer" command. This will have to be clean-up
in a later patch (+ using a cancelable progress monitor).

The patch also includes a fix to make source-map work when debugging
the webview apps.

An additional commit to introduce ESLINT to the project and related code
updates

Needs https://github.com/theia-ide/theia-trace-extension/pull/295
Fixes #7
Fixes #11
Fixes #16
Signed-off-by: Bernd Hufmann<EMAIL_ADDRESS>

The following sequence diagram illustrates the communication between the webviews and the vscode extension using the example of selecting a trace. The communication between webviews and vscode extension is described in [1] and [2].

[1] https://code.visualstudio.com/api/extension-guides/webview#passing-messages-from-an-extension-to-a-webview
[2] https://code.visualstudio.com/api/extension-guides/webview#passing-messages-from-a-webview-to-an-extension

Also, I don't think it fixes #4. This one will require that we parse the user's workspace to detect all possible traces. It is not in the scope of this PR.

Also, I don't think it fixes #4. This one will require that we parse the user's workspace to detect all possible traces. It is not in the scope of this PR.

After re-reading the #4, I realized that it describes something else, i.e. trace detection on the file system. My understanding was that it was showing the available traces on the server. I'll remove it.

https://github.com/theia-ide/theia-trace-extension/pull/295 has been merged to master.

I also updated the readme and added new screenshots.

@tahini  are ok with this PR as well?

Thanks for the reviews!


Could H time format token set padded 12 hour based value under time_24hr = false?

I'd like a way to format 12 hour time formats with leading zeros but can't see a way to do this under the current documentation for time format tokens.
I suppose one way is introducing a new hour formatting token.
However, it seems odd that H under time_24hr = false causes the time picker to display a 12 hour spin control but then set a 24 hour format input value .
Could the H token take the value of time_24hr into account when setting the input value?  Setting 01-12 when time_24hr = false and 00-23 when time_24hr = true?
Your Environment

flatpickr version used: 2.6.0
Browser name and version: IE 11.0.9600.18638
OS and version: Windows7 Pro

Tested the new G formatting token under v2.6.3 and it's doing exactly what's expected.  Thanks for this!


PNT Docker-Compose setup

I am used to working with Docker and Docker-compose.
This is my current development setup.
Adding this because it might help others that used docker-compose / docker setup faster.

@PaulBernier Rebased with new changes.