Maintainership status and crates.io release

What is maintainership status of this library? Should it be considered abandoned?
If not, when is the next crates.io release expected?

I think for the most part hound already does what most people need it to do, and that's why the repo is quiet.
@ruuda has always been responsive to issues and PRs whenever I've submitted anything.
Are you currently waiting for some feature to land in a new crates.io release?

I think for the most part hound already does what most people need it to do, and that's why the repo is quiet.
@ruuda has always been responsive to issues and PRs whenever I've submitted anything.
Are you currently waiting for some feature to land in a new crates.io release?

Are you currently waiting for some feature to land in a new crates.io release?

Primarity things for outputting wav files to stdout or reading them from stdin, like https://github.com/ruuda/hound/issues/39 or https://github.com/ruuda/hound/pull/36.
I don't typically use wav files as a storage medium for audio, just as a intermediate representation to get it to/from some filtering application.

I think for the most part hound already does what most people need it to do, and that's why the repo is quiet.

I think making a minor release once in a blue moon may be beneficial, even if just to show that the project as active.
For there are a number of things already in master, but not on crates.io.

Are you currently waiting for some feature to land in a new crates.io release?

Primarity things for outputting wav files to stdout or reading them from stdin, like https://github.com/ruuda/hound/issues/39 or https://github.com/ruuda/hound/pull/36.
I don't typically use wav files as a storage medium for audio, just as a intermediate representation to get it to/from some filtering application.

I think for the most part hound already does what most people need it to do, and that's why the repo is quiet.

I think making a minor release once in a blue moon may be beneficial, even if just to show that the project as active.
For there are a number of things already in master, but not on crates.io.

Thank you for taking the time to open an issue. I wouldn’t call the repository abandoned, I intend to make a new release with everything that’s on master. But to be honest, I’ve been wanting to do that for more than two years, and I haven’t gotten to it yet.
If it was a simple matter of publishing the crate, I would have done it a long time ago, but there are a few issues with the current state. #26 in particular, but I also think some of the interfaces can be simplified, so I don’t want to make a new release now with quite a few new features that have accumulated, and then introduce many breaking changes in the release after.
I understand that it’s frustrating to wait for a new release. I hope I can find the time to make a new release soon.

Thank you for taking the time to open an issue. I wouldn’t call the repository abandoned, I intend to make a new release with everything that’s on master. But to be honest, I’ve been wanting to do that for more than two years, and I haven’t gotten to it yet.
If it was a simple matter of publishing the crate, I would have done it a long time ago, but there are a few issues with the current state. #26 in particular, but I also think some of the interfaces can be simplified, so I don’t want to make a new release now with quite a few new features that have accumulated, and then introduce many breaking changes in the release after.
I understand that it’s frustrating to wait for a new release. I hope I can find the time to make a new release soon.

I just published 3.5.0 which includes #36. I cherry-picked the contributions that were compatible on top of 3.4.0 for that release, there are other changes on master still unreleased. I still plan to get to those, but I hope this helps in the meantime.


fix(pie-monorepo): fix majority of TS/ESlint issues

"pie-storybook": minor
[Changed] - use our eslint config, fix various linting issues and use render function syntax for story declarations

"@justeattakeaway/pie-icon-button": minor
[Changed] - use our eslint config, remove eslint comments

"@justeattakeaway/pie-button": minor
[Changed] - use our eslint config and fix various linting issues

"@justeattakeaway/pie-modal": minor
[Changed] - use our eslint config, remove eslint comments

"@justeattakeaway/eslint-config-pie": minor
[Added] - disabled 'import/no-extraneous-dependencies', allow omitting of .ts and .js file extensions with 'import/extensions' and update the 'import/resolver' to recognise .ts files

"@justeattakeaway/pie-icons-vue": minor
[Removed] - eslint comments

"@justeattakeaway/pie-webc-core": minor
[Changed] - use our eslint config, add SCSS type declarations, remove eslint comments

"@justeattakeaway/pie-components-config": minor
[Changed] - add our eslint config, remove eslint comments and .js file extensions from imports

Just a reminder that changesets should only be added for consumer facing changes - https://github.com/justeattakeaway/pie/blob/main/README.md#versioning--publishing-packages
I feel like we'll be unnecessarily be creating unneeded versions / npm publishes in it's current state. In fairness, this is something we probably need to make more visible, as I've only been pointing this out in PR's on an ad-hoc basis, so apologies if this rule has been broken a lot already.

Just a reminder that changesets should only be added for consumer facing changes - https://github.com/justeattakeaway/pie/blob/main/README.md#versioning--publishing-packages
I feel like we'll be unnecessarily be creating unneeded versions / npm publishes in it's current state. In fairness, this is something we probably need to make more visible, as I've only been pointing this out in PR's on an ad-hoc basis, so apologies if this rule has been broken a lot already.

Sure thing - how do you define consumer facing @siggerzz?
Perhaps the changeset cli shouldn't include the packages we don't need changesets for in that case. Easier to not add incorrect files that way.

@jamieomaguire I guess anything that has an effect on users of the published package and not 'internal' monorepo specific changes like the ones mentioned in the readme.
For example a change to dependencies / peerDependencies would warrant a changeset, as that has a potential impact on a consumer of the package.
However, a change to devDependencies would not need a changeset, as those are only used internally.
In the case of this PR, these linting changes have an effect internally within the monorepo, but an end-user of the package does not need to know / care about such changes.

@siggerzz yeah makes sense. I've removed most of the changes but the changes to our listing package will affect consumers of it so I've left that in 👍


Update NL extra translation

Added additional translation

Thanks! Would it be possible to put the extras in a new .extra.nl file instead? Check how the .en files are done...

Hi, I edited the nl.extra.js file. I don't know exactly what you mean? 😉

Ohhh, I checked too quickly, my bad.
All good, thanks!


Missing tfjs_graph_converter

tfjs_graph_converter I guess is this one? https://github.com/patlevin/tfjs-to-tf

Yes, it is that one, sorry. We have updated the readme with the instructions.
If you have any other issues, feel free to reopen.


.New should expect a sessions.Store, not sessions.CookieStore

Since sessions.Store is an interface it can be accepted as a parameter and it would allow other kinds of Gorilla session stores to be used with csrfbanana.

Good catch, I'll make the change.


archi: 4.7.1 -> 5.2.0

upgraded binary release of archi to 5.2.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build archi archi.passthru.tests

@wegank why did you mark this PR as a draft?

It doesn't build anymore, see ofborg.

@wegank thanks for the headsup. They changed the download link. I pushed a commit to fix this issue.

@ofborg build archi archi.passthru.tests


Avoid calling PackageService->getClass statically

This should be the only place where PackageService->getClass is called statically

Why do this instead of just creating a new PackageService instance? See the performance comparison between https://3v4l.org/9XZXf/perf#output and https://3v4l.org/coZM9/perf#output.
There's no impact to create a new instance every time vs accessing a single instance. And with the extra step of having a facade use call_user_func_array we're probably actually losing performance here.
It's a microoptimization, but still I think it's wise to create the service objects as they are needed instead of keeping a singleton around wherever possible.

I'd honestly be happier with:
\Concrete\Core\Support\Facade\Application::make(PackageService::class)->... because that's easier to clean up later. Ideally these value objects wouldn't have this kind of service attached to them, instead of $controller = $package->getController() we'd use a pattern like $controller = $packageControllerFactory->create($package) to keep our responsibilities separate.

There are a lot of other places too where this should be fixed like you say
(I don't have time right now).
Il 30 Set 2016 20:03, "Korvin Szanto"<EMAIL_ADDRESS>ha scritto:

I'd honestly be happier with:
\Concrete\Core\Support\Facade\Application::make(
PackageService::class)->... because that's easier to clean up later.
Ideally these value objects wouldn't have this kind of service attached to
them, instead of $controller = $package->getController() we'd use a
pattern like $controller = $packageControllerFactory->create($package) to
keep our responsibilities separate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/4445#issuecomment-250812036,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4pdE45R0lwRRF-xrCCkugMbqpgrXhyks5qvU7xgaJpZM4KLWBa
.

@mlocati I'm asking a question not requesting changes, not sure what you mean by that. I know there are a lot of places in the core using bad code, that doesn't seem like a reason to add more bad code if we can avoid it.

Why do this instead of just creating a new PackageService instance? See the performance comparison between https://3v4l.org/9XZXf/perf#output and https://3v4l.org/coZM9/perf#output.

This comparison does not take in account the overhead of the laravel builder: in does some reflection to determine the constructor patameters and it does some other useful stuff.
BTW, I updated this PR

@mlocati yeah that's true, we could follow a pattern like [we did in the old Session](https://github.com/concrete5/concrete5/blob/7b039747ab761de682d06a473441db08911f4988/concrete/src/Session/SessionServiceProvider.php#L11]. However honestly I wonder how many times we really are calling this method. If that's actually being called a lot on page load perhaps we should look into ways to reduce that.


JVM crash

Version of Archi, Operating System

Archi 4.0.2, Ubuntu 16.04LTS
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)
Expected Behaviour

Doesn't crash.
Actual Behaviour

JVM crashes (logs attached)
Steps to Reproduce the Behaviour

Not always, but the crash more frequently occurs when pushing model to GIT (plugin archi-contrib version 0.2.3)

logs.tar.gz

Not so easy to diagnose this as it is an internal Java error. It seems to happen on org.archicontribs.modelrepository.actions.PushModelAction#run() when the progress monitor dialog is closed:
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
J 14700  org.eclipse.swt.internal.gtk.OS._gtk_widget_destroy(J)V (0 bytes) @ 0x00007f2c3b58b081 [0x00007f2c3b58b040+0x41]
J 12885 C1 org.eclipse.swt.widgets.Widget.destroyWidget()V (30 bytes) @ 0x00007f2c39e93244 [0x00007f2c39e92f60+0x2e4]
J 16435 C2 org.eclipse.swt.widgets.Widget.release(Z)V (90 bytes) @ 0x00007f2c39c6f528 [0x00007f2c39c6f400+0x128]
J 13418 C1 org.eclipse.swt.widgets.Control.release(Z)V (115 bytes) @ 0x00007f2c3aab5a8c [0x00007f2c3aab5580+0x50c]
J 13121 C1 org.eclipse.swt.widgets.Widget.dispose()V (27 bytes) @ 0x00007f2c3afdcac4 [0x00007f2c3afdc300+0x7c4]
j  org.eclipse.swt.widgets.Shell.dispose()V+20
j  org.eclipse.jface.window.Window.close()Z+65
j  org.eclipse.jface.dialogs.Dialog.close()Z+26
j  org.eclipse.jface.dialogs.ProgressMonitorDialog.close()Z+12
j  org.eclipse.jface.dialogs.ProgressMonitorDialog.finishedRun()V+5
j  org.eclipse.jface.dialogs.ProgressMonitorDialog.run(ZZLorg/eclipse/jface/operation/IRunnableWithProgress;)V+46
But this kind of error can happen with Ubuntu Themes. Try a normal theme and see if it happens.

Hi Phil, sorry for the delay.
I'm not using any custom theme, just Ubuntu's default.
2017-07-14 18:56 GMT-03:00 Phil Beauvoir<EMAIL_ADDRESS>
Not so easy to diagnose this as it is an internal Java error. It seems to
happen on org.archicontribs.modelrepository.actions.PushModelAction#run()
when the progress monitor dialog is closed:
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
J 14700 org.eclipse.swt.internal.gtk.OS._gtk_widget_destroy(J)V (0 bytes)
@ 0x00007f2c3b58b081 [0x00007f2c3b58b040+0x41]
J 12885 C1 org.eclipse.swt.widgets.Widget.destroyWidget()V (30 bytes) @
0x00007f2c39e93244 [0x00007f2c39e92f60+0x2e4]
J 16435 C2 org.eclipse.swt.widgets.Widget.release(Z)V (90 bytes) @
0x00007f2c39c6f528 [0x00007f2c39c6f400+0x128]
J 13418 C1 org.eclipse.swt.widgets.Control.release(Z)V (115 bytes) @
0x00007f2c3aab5a8c [0x00007f2c3aab5580+0x50c]
J 13121 C1 org.eclipse.swt.widgets.Widget.dispose()V (27 bytes) @
0x00007f2c3afdcac4 [0x00007f2c3afdc300+0x7c4]
j org.eclipse.swt.widgets.Shell.dispose()V+20
j org.eclipse.jface.window.Window.close()Z+65
j org.eclipse.jface.dialogs.Dialog.close()Z+26
j org.eclipse.jface.dialogs.ProgressMonitorDialog.close()Z+12
j org.eclipse.jface.dialogs.ProgressMonitorDialog.finishedRun()V+5
j org.eclipse.jface.dialogs.ProgressMonitorDialog.run(
ZZLorg/eclipse/jface/operation/IRunnableWithProgress;)V+46
But this kind of error can happen with Ubuntu Themes. Try a normal theme
and see if it happens.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/issues/255#issuecomment-315477616,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AID1Sg6EjSxsS6E7pLffU_LVhAthJ2imks5sN-QHgaJpZM4OYu8F
.

Need to pin this one down to something specific. Can you narrow it down? Try different version of Ubuntu, Java...?

No problem, I've switched JVM to Openjdk. I'll keep you informed.
2017-07-24 18:06 GMT-03:00 Phil Beauvoir<EMAIL_ADDRESS>
Need to pin this one down to something specific. Can you narrow it down?
Try different version of Ubuntu, Java...?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/issues/255#issuecomment-317554692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AID1StMdrTvOkzFDEAwoaL-Sq5HHHGDGks5sRQc9gaJpZM4OYu8F
.

Closing pending further info. Please re-open if still a problem.


chore(main): release 0.3.1

:robot: I have created a release beep boop
0.3.1 (2022-12-02)
Bug Fixes

add extension error loggings for mypy (88280f1)

Miscellaneous

deps-dev: bump tox from 3.26.0 to 3.27.1 (#105) (de0791f)
deps-dev: bump twine from 4.0.1 to 4.0.2 (#106) (d813fa8)
deps: bump actions/setup-python from 3 to 4 (#98) (92817e0)
deps: bump black from 22.8.0 to 22.10.0 (#107) (63ba577)
deps: bump docker/build-push-action from 2.5.0 to 3.2.0 (#99) (059134e)
deps: bump docker/login-action from 1.10.0 to 2.1.0 (#102) (42fe5c8)
deps: bump docker/metadata-action from 3.3.0 to 4.1.1 (#104) (acbfd60)
deps: bump mypy from 0.971 to 0.991 (#103) (2a8437f)
deps: bump pylint from 2.15.2 to 2.15.7 (#100) (a13fb42)
deps: bump python from 3.10.7-slim to 3.11.0-slim (#97) (7d366a2)
release-please: add changelog-type (#110) (56558f7)
testpypi: add condition (#108) (e9d2e47)
testpypi: change if position (#109) (88eb324)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/bowentan/glob-linters/releases/tag/v0.3.1 :sunflower:


fix: postinstall link command

This PR fixes installation issue for postinstall script.
FIX: #10

Coverage remained the same at 100.0% when pulling 12fdd58db6dc3ff22538860c00006a36e2ee57b9 on saeidalidadi:fix-package-postinstall into be25df493914df3f8066b8a8630f7d09487bf53c on google:master.

I signed it!

:+1: Thanks for your creative gaming framework


Provide non-atomic versions of many reference counting operations.

What's in this pull request?

Provide non-atomic versions of many reference counting operations.
Non-atomic reference counting operations are much faster than their atomic counterparts.
These new entry points will be used by optimizations, which would replace atomic reference counting operations by non-atomic reference counting operations when it is safe to do so.
Resolved bug number: (SR-248)

Before merging this pull request to apple/swift repository:

[x] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please smoke test

@jckarter Joe, do you mind taking a look?

@jckarter @gparker42 I pushed a new version. It addresses @jckarter's comments.
I have not introduced barriers, because IMHO, the non-atomic APIs are not supposed to be used if the compiler cannot prove that the object is owned by a single thread. And if this can be proven, then there is no need for such barriers, right?

There's still an extra unnecessary store in your doDecrementShouldDeallocateNonAtomic implementations, but other than that it LGTM. I'd still wait for @gparker42's approval too.

@gparker42 Greg, could you reply to Joe's and my comments and questions? Do you still think we need barriers?

@jckarter I just spoke with @gparker42 and we agreed that it is safer to have the barriers on the deallocation pass.

@swift-ci Please smoke test

@swiftix @gparker42 SGTM. For my own education, why is the barrier necessary if you've already done an isUniquelyReferenced check?

@gparker42
As I mentioned to @swiftix, the memory barrier on the refcount decrement is still required for the same reason that it was needed before.
T1: store to x, release x
T2: checkuniq x, release x, dealloc x (release barrier)
Wither a barrier on the normal release, T1 could issue the store after the object is deallocated by T2.

I see, thanks @atrick.

@swift-ci Please smoke test

@jckarter @gparker42
For the record, the example I showed is bogus because the reference would not be unique in T1, so its release would be still be atomic. To expose a problem, the same object needs to be unique in one thread, handed off to another thread (written to a global), then accessed as unique in a second thread. Through ARC magic, it might be possible in theory to store the reference to a global without touching the refcount (it's copied to the global as a 'take').
At any rate, proving safety or lack thereof is tricky. I don't anticipate the release barrier to have any measureable performance cost (although @swiftix plans to verify that).

@swift-ci Please smoke test

@atrick Even then, since "store to x" is nonatomic, and the barrier in "release" isn't a full store fence, couldn't the nonatomic store still be reordered?

@jckarter The "release" barrier prevents the current store (in this case, the refcount decrement) from completing prior to any other loads and stores from that thread that appear before it in program order. For example, you could initialize an object, publish the object pointer via a "release" and be sure that other threads only see initialized memory.
Additionally, a "release" barrier cannot be reordered with subsequent barriers, but can be reordered with subsequent nonatomic loads and stores.

For example, you could initialize an object, publish the object pointer via a "release" and be sure that other threads only see initialized memory.

Don't the other threads still need either a consume dependency on the pointer, or an acquire barrier, to see the initialization?

Other threads would only need an acquire barrier if they were entering a critical region. In my simple object initialization example, only the initializing threads needs any kind of barrier because the object isn't shared across threads until it is "published".

The barriers in retain and release are not intended to provide sufficient synchronization to publish an object to other threads. How could they? In the ordinary simple case you need to store to the global before calling release. Any barrier in release is too late to help your thread synchronization.
There is only one happens-before relation in retain/release: every operation by a thread before that thread called release happens-before the object's deinit begins. Any other synchronization must occur by other means.
(There might be another happens-before relation with weak variables becoming zero but I think that one would be enforced outside retain/release itself.)

To expose a problem, the same object needs to be unique in one thread, handed off to another thread (written to a global), then accessed as unique in a second thread.

This is already a race-prone operation. (For example on some architectures there is no guarantee that the second thread sees an initialized object.) Resolution of the other races would almost certainly have enough barriers to fix the happens-before-dealloc problem as well.

Sorry for causing confusion with my misleading example. Backing up to the beginning:
My argument is that the nonatomic variants of retain/release should provide the same level of synchronization as the atomic variants, mainly because synchronization is not the thing that the new runtime calls are attempting to optimize, as I mentioned here:
https://bugs.swift.org/browse/SR-249
As @gparker42 just explained, retain/release operations provide almost nothing in the way of synchronization. But there is a guarantee that a thread's own operations complete before a release. Generally, you don't get any happens-before relation across threads without both a release and an acquire (as @jckarter said). The current retain/release synchronization only needs an acquire on the deallocation path because we only care that access to the object happens before it is deallocated.
Now I'm forced to explain my previous comment even though it is irrelevant to this problem:
You can cheat on synchronization by knowing that an object is uniquely referenced. In that case, you could rely on a single hardware release barrier on the store that "publishes" the object pointer to other threads. That's sufficient because we simply don't care about the other thread's order of operations as long as data flow dependencies are respected. But...
(a) you need a release barrier everywhere the pointer may be published
(b) you still need a software memory barrier in the "client" thread so the compiler can't in theory do something like value prediction when it loads the shared reference
Now for what is important to this problem: the retain/release synchronization is only relevant to the new runtime calls when this sequence of events occurs...
(1) the object is unique in thread1
(2) the object is shared with thread2
(3) the object is made unique in thread2
(4) the object is deallocated
Step (2) is either a race condition, or is synchronized such that all access to the object in thread1 happens before deallocation.
In conclusion: we don't need the release barrier on the fast decrement path of the new runtime calls for the reason that I thought, but I still think we should keep the barrier because...

The release barrier should have no performance penalty (and will be verified).

Race conditions happen, and I would rather not make them harder to debug.

Our uniqueness check only applies to the strong refcount, and reasoning about synchronization in the presense of weak references is already complicated enough.


the total  calls in an hour or one day

Please answer these questions before submitting your issue.

Why do you submit this issue?
[X ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Where can I find the total  calls in an hour or one day? In the Topology,I can only see the Cpm.
In the pinpoint, I can the total  calls in the ServerMap ，Just like the data in the red box of the picture below。

We don't response to pinpoint question. Your question is not on the right way.
Learn SkyWalking, learn OAL.

Sorry, Maybe I didn't make it clear。 I only want to know,if skywalking have the same function like Pinpoint that I can know the total calls in an hour or one day. Now In the Topology,I can only see the Cpm.

Sorry, Maybe I didn't make it clear。 I only want to know,if skywalking have the same function like Pinpoint that I can know the total calls in an hour or one day. Now In the Topology,I can only see the Cpm.

You can, but we don't provide as default, as it doesn't make sense. You could customize by yourself very easily. That is why I mentioned OAL. But again, don't include Pinpoint in, what they did has nothing related to the answer.

@wu-sheng Thank you very much,that is my wrong. And Can you tell me how to customize it ?

I have told you twice. Read OAL doc.

@wu-sheng Very sorry to make you angry. I have read the doc. I have solve the problem. Many people recommend this software to me.

@wu-sheng Very sorry to make you angry. I have read the doc. I have solve the problem. Many people recommend this software to me.

I am not angry, I just can't paste all documents here.


Header mimics drawchange.org

Make the Header component mimic the navbar on the drawchange.org website. All the links should link back to the original drawchange.org website.

[x]  About Us Dropdown
[x] Contribute Dropdown
[x] News Link
[x] Activities Dropdown
[x] Contact Link
[x] Donate Link
[ ] Navbar is responsive

Make the Header have the same links & styles as the drawchange.org header.

Responsiveness iffy, but basic functionality is done

Closed


Unexpected alert message on recommended-modules.tpl?

Hi!
In version 3.1.0 there's this alert message in recommended-modules.tpl.
} else {     alert('wooow')   }

Hello @albert28
Indeed, code review has been done a bit too quick on this one 🙈
Will release a new version this week.
Thanks for your feedback !

The release v.3.1.1 has been done
Again, thanks for your feedback


Migrate bdg-formats to new adam-formats module

See proposal downstream https://github.com/bigdatagenomics/adam/pull/1689.
That pull request should be modified to include revision control history from this repository, at least for the file bdg-formats/src/main/resources/avro/bdg.avdl.
Note this would mean end-of-life for the bdg-formats repository.  Outstanding issues and pull requests would need to be migrated downstream.

Closing as wontfix


[ACR] React to stable/2021-07-01 swagger changes

For issue: https://github.com/Azure/azure-sdk-for-python/issues/21057

Looks like it's all changes to generated code. LGTM, probably should also have someone from Python team sign off

Can you help with that? I'm actually don't know who is the best person to tag.


The 'by' step clause causes an error

Example:
define variable i as integer no-undo.

do i = 5 to 10 by 2:
    message "HELLO".
end.

Registered: https://github.com/usagi-coffee/tree-sitter-abl/issues/82

Fixed with 0.0.42 version of tree-sitter-abl


[VGUI2] Server browser auto resized and broke in CS

All other tabs(internet, etc) have the same issue.

not be able to repro this issue with official cstrike 8684

Issue present on a fresh new install on steam too(legacy branch):

Confirming fix, ty


Enhance the Error type to provide more information about the error.

This introduces the following changes.:

The Error code now has a Code field that exposes the YARA API error code to Go users, and also exposes the error codes as constants that can be used in Go code (example: err.Code == yara.ERROR_TIMEOUT). Sometimes is useful to get a numeric error code instead of a text string.

When Error is converted to a string, it includes the name of the rule causing the error. For example, instead of getting an error like syntax error, unexpected identifier, expecting <condition>, you get rule \"foo\": syntax error, unexpected identifier, expecting <condition>.

awesome, thank you!


how to show the selected date in Scope example!

i want to show the selected date in Scope example using scope week. for example , i choose 12/27,but switched to scope week, it was not showed!

thank you!

Yes, this is a big issue. Please fix and let us know. Thank you

Fixed


Camera

Will you make a sample program with a camera?
Thank.

Checkout this or this example.

Thank.


Change resolution of video

Hi,
I would change resolution of captured video.
I see that now it is 320x240 in the interference.py.
I tried to change to 640x480 but I had problems in the run.
Can you help me to do this?
Thanks

Hi, is it possible to change resolution to 640x480 ?
I trained but I had errors.
Thanks

@grdsvt Can you attach your error? It can be run at 640 * 480 during testing. Only need to modify input size and anchors... , training at 640*480 is also possible.

Hi, sorry I changed horizontal with vertical dimension......this was my error.
Now it is all ok


Update to eslint and update package.json

Changes:

Update to eslint from tslint
Fix eslint rule violations
Minor tweaks to package.json

Issues:

resolves #33

Notes:

Depends on #34

EDIT: closed because commit history is messy.  Squashed commits and opened #39

Squashed commits on new branch and opened #39


New question about filesize and # of files limits

I'd like q/a about filesize and # of files limits and whether it is configureable (Default in sufia/uploads is set to 500MB and 100 files max at a time)
Is this configurable? There is a ticket to make it configurable https://github.com/projecthydra/sufia/issues/1827 (v.7.2.0)

Oh and how to deal with large file upload/download
Eg. Recommends: Use Browse-everything (Box, Dropbox, Server directory integration).

Thanks for creating this issue, @younga3! I've taken a crack at it here: http://sufia.io/about/managers/#q21


Recursion abort leads to empty objects

{
search(text:"an") {
__typename
... details
}
}
fragment details on Human {
name
friends {
... details
}
}

This issue should be fixed but we need some tests for this.


Steam-Crypto Error

Hi, I am currently receiving this error with Steam-Crypto I've checked and my Node version should be the latest thanks for any help you can provide!
/var/www/bot/node_modules/steam-crypto/index.js:6
var cryptedSessionKey = crypto.publicEncrypt(publicKey, sessionKey);
^
TypeError: Object # has no method 'publicEncrypt'
at Object.exports.generateSessionKey (/var/www/bot/node_modules/steam-crypto/index.js:6:34)
at CMClient.handlers.(anonymous function) (/var/www/bot/node_modules/steam-user/node_modules/steam-client/lib/cm_client.js:315:31)
at CMClient._netMsgReceived (/var/www/bot/node_modules/steam-user/node_modules/steam-client/lib/cm_client.js:242:24)
at TCPConnection.EventEmitter.emit (events.js:95:17)
at TCPConnection.readPacket (/var/www/bot/node_modules/steam-user/node_modules/steam-client/lib/tcp_connection.js:59:7)
at TCPConnection.EventEmitter.emit (events.js:92:17)
at emitReadable (_stream_readable.js:408:10)
at emitReadable (_stream_readable.js:404:5)
at readableAddChunk (_stream_readable.js:165:9)
at TCPConnection.Readable.push (_stream_readable.js:127:10)

What's your node.js version?

Well, it looks like I've come across a new error when I do node -version nothing happens do you know where I could get help with that?

node --version

That seems to be not working either which is really weird as I installed it about 2hours ago.

Can you provide a screenshot or a video?

Heres a video https://youtu.be/qWN9MPn_nJ8 btw I just want to say I'm really appreciative towards you helping me out :)

Try nodejs --version or rebooting.

Ok, my nodejs --version works and it is v0.10.25

Well that's really old. You need at least v4.1.1.

It looks like you installed nodejs via apt-get on Debian/Ubuntu, @ThatBossGuy
As I see that you are using DigitalOcean, feel free to take this guide hosted by them (should work on their systems, and actually anywhere else).
https://www.digitalocean.com/community/tutorials/how-to-set-up-a-node-js-application-for-production-on-ubuntu-16-04
Also uninstall that old 0.10 version.


[Feature] Life Cycle Management (timed publication/depublication)

This is a summary of a discussion we had at the meeting in Bern - and a call for community feedback:
Use case

Lecturers want recordings to be published one week after the lecture, or all episodes of a series should be published at the end of the semester. They MAY also want different publication dates for individual episodes of a series.
At the request of lecturers or in line with a "Life Cycle Policy", recordings should be depublished and/or archived/deleted at a defined point in time. Ideally, the "owner" of the video is informed in advance.

Possible implementation

metadata
workflows
tasks (says Lars)

Delayed publication
It should be possible

to set a fixed delay for the publication of all episodes compared to the creation date for the entire series / all episodes ("+3 days")

enter a fixed date for the publication of a series / all episodes ("publication on 12/24/2023"), or

a separate publication date is defined for each episode (improbable and time-consuming).

Metadata: http://purl.org/dc/terms/available for series and episode.

Workflow: "Pause" or "Conditional Execution" (IF decterms:Created was more than x days ago...)

Tasks?

Automatic depublishing/deleting
It should be possible

to automatically delete series of a certain age after first informing the "owner" of the series.

Worst case: Changing the information in one episode overwrites the information for the series and may result in an adjustment to the information about the series - but not for the other episodes in the series (e.g. the series will last longer with an extended episode , but the other episodes will be deleted).

Metadata: http://purl.org/dc/terms/valid for series and episode, where the series inherits this on the episodes, subject to the special case described above.

Workflow: "Pause" or "Conditional Execution", depublication/deletion once a time span defined has passed since the series was created or the first/last episode was recorded/published.

Variants of the standard workflow of a university: Lecture recordings are created with a lifespan of two years, user uploads with five, events with ten years; special cases without a limit.

SHOULD be able to depublish first, then delete after a further delay.

MUST inform the owner in advance.

Tasks?

Pending issues

User uploads (Tobira, LMS et. al)
"Old" video stocks, "alternative" distributions and the plug-ins of the various LMS and Tobira have to be considered.
See https://tinyurl.com/283krc8c (German only)

Since one of these has a question mark and my name is attached to this, let me try to clarify my ideas around implementing this.

Possible implementation

metadata
workflows
tasks (says Lars)

Using additional metadata
This is specifically for when to publish and when to retract (or delete? Needs clarification.) media.
We add additional metadata to Opencast's default metadata catalogs. Preferably these are Dublin Core elements like available and valid which specify the lifecycle of an event.
We then require a new service in Opencast which checks this metadata in regular intervals and publishes, retracts or deletes media if necessary.
In the admin interface, we would need two new metadata fields at the minimum (that should be easy), although it would be nice to have a new table to see these livecycle actions on. For example, to identify the next events to be deleted. Instead of adding a new table this could also go into the main events table, but maybe that is too many columns then?
This should be moderately complex to implement, easy to use, but not very flexible.
https://github.com/opencast/opencast/assets/1008395/44264cfc-b887-4966-90ca-c8812ca2971e
Workflows: Delay Operation
If I just want to delay publication by a fixed amount of time, we can just implement a workflow operation which doesn't do anything but wait. That way I can easily delay publication by a given amount of time. The time could be set in the workflow interface. You could do the same with a workflow for deleting events.
Implementing this should be really simple. It should also be enough for short term delays (days) and occasional use. But this has some disadvantages as well.
Delaying the workflow in an operation has a number of disadvantages, though. This is mainly because the workflow is running for the entire time it is waiting. This makes it hard to identify what is actually being processed in Opencast since users cannot easily distinguish between workflows which are waiting and which are actively processing data. There are a few things we could do to make this a bit better like setting the workflow/event status to something like “waiting”, but that isn't really solving that problem. That is probably okay, if you occasionally want to delay a publication for a few days. You wouldn't want to have thousands of videos in this state.
You also wouldn't be able to change any metadata or start any other workflows on the event. There is an active workflow running on this after all.
In the end: Really easy to implement, works for occasional use, no UI changes needed, becomes unusable on a larger scale or over long periods of time.
https://github.com/opencast/opencast/assets/1008395/ad78c988-8a3f-45d4-8c14-6f9baf148ebb
Scheduled Tasks/Workflows
The idea of using metadata for actions like removing events is just the idea of executing a specific task at a given time. Like the valid metadata is set to 2024-02-01, therefor Opencast should run the “retract” workflow after that. Only that you limit this approach in advance to two or three specific events: Publication, retraction, deletion.
As a more powerful variant of this, you could also just allow users to schedule the execution of any workflow on given events. To reproduce the effect we of retracting an event on Feb 01, 2024 I mentioned before, as a user I would just:

Mark the events to operate on
Go to “Actions” → “Start Task”
Select the “retract” workflow
Set Feb 01, 2024 as execution data
Schedule the task (instead of executing it right now)

This approach is very flexible since users could schedule any workflow and even build their own workflows for this. Whatever can be done via workflow becomes possible.
The admin interface should list scheduled events in the event details. There should probably also be a global table listing all scheduled tasks.
https://github.com/opencast/opencast/assets/1008395/6e29a8be-5bbb-4fc9-8d6b-55d84f23858c
Some Notes

I think the workflow delay option is too limited and people will quickly complain that it's not flexible enough when you really think about modelling a video lifecycle.
I like the idea of scheduled tasks, but I also see usability advantages in using metadata. It's simpler because it's far more limited.
All admin interface changes should go into the new admin interface, not the old one

Two additional notes to myself, my future me and the future developer(s):

Needs a mechanism to inform "users" (dcterms:Creator or owners according to other metadata) about upcoming unpublishing or archival.
Apply to episodes and/or series (all on Dec 24th / all with two days delay to creation)
Needs to unpublish from given channels.

Cf.

https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/available
https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/issued
https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/temporal
https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/valid

It seems "valid" includes start and beginning of a publication:
dcterms:valid
The range defined for dcterms:valid is the class of rdfs:Literal. Values used with this property therefore have to be literal values.
ex:myDraft dcterms:valid "2007-05-06/2007-07-15"

Some thoughts after re-visiting this for our meeting:

To me, "Workflows: Delay Operation" is not an option if we want a life cycle policy ("retract after two years") to be executed to a class of videos, say "lecture recordings": If we put all of them (10k/year approx. at ETH) in delay, this not only clutters the system, it also makes it impossible to execute other workflows during that time, so not even a metadata update would be possible (if I understand Lars correctly). That would even exclude this as an option for the idea of delaying individual events with a given time (+x days for each episode) because someone always wants something to happen to his/her video.
With the same idea of having a life cycle policy for thousands of videos, I don't think "Scheduled Tasks/Workflows" is an option because it has to be executed manually (if I understand Lars correctly). However, it might be an option for the less frequent request to delay publication (+x days for each episode).
At this point in time, dcterms:valid (series) with a range defined with two dates (or as an interval from dcterms:created, like +x years) for a service to detect and transfer into workflows seems to be the the best way to move forward for the life cycle policy I have in mind. However, I wonder how to add "archive" or "delete" as a second step after retracting the videos from publication initially.

Some additional discussions (in German): https://docs.google.com/document/d/1rlo82MNKJKGDG0sBjjcCDnjjZrhRwKnPkabGFt1a_Rc/edit

Hi all,
after reading  this

Some additional discussions (in German): https://docs.google.com/document/d/1rlo82MNKJKGDG0sBjjcCDnjjZrhRwKnPkabGFt1a_Rc/edit

and this

Pending issues
* User uploads (Tobira, LMS et. al)

* "Old" video stocks, "alternative" distributions and the plug-ins of the various LMS and Tobira have to be considered.

I'm wondering why user uploads/third party systems are currently not considered.
In the german discussion linked above the only mechanism that would allow third parties to add lifecycle information (create-lifecycle-task-WOH) has the comment "optional". Adding lifecycle information to the metadata is also tricky, at least that is mentioned in the german discussion.
In our case 99% of events are created outside of opencast and almost no one except us admins has to use/see the admin ui. Except for cutting of course.
If those (future) discussions are not for some reason closed I would like to be invited please :) @oas777 @lkiesow

Hello Christoph. The discussion is certainly not "closed" with this ticket being visible, so good to see you chime in. However, you should keep in mind this feature received funding as part of the crowd funding. Which means resources are limited. So we have to start somewhere and that usually is Opencast (cf. https://github.com/opencast/opencast/pull/5478 for playlists in OC which is the prerequisite to playlists appearing in Tobira and/or LMS at a later stage). So consider this the birth of life cycle management in OC and if you want to see this in your LMS you know you need someone to implement this.

Cf. user stories at https://github.com/opencast/opencast/issues/5599 and https://github.com/opencast/opencast/issues/5602.

Thank you for the invite even though my institution did not contribute to the crowdfunding. I'm fully aware that Opencast has to come first in order for this to work and that the funding doesn't include implementations elsewhere :) I would just like to ask that this feature isn't somehow only baked into the admin UI but also available to outside system (e.g. via API or Metadata or TDB) 😇

Final concept for discussion at the summit: https://docs.google.com/document/d/1DXogFGigUUmmuOt7pqT9rcnMxFviLTPfvSSgJro4X04/edit#heading=h.ze9yfqr0f5rt

Hello, any updates here after the summit?
Thanks


Add spacing around git auto rules to keep .gitignore clean

It bugs me that the default .gitignore from https://github.com/silverstripe/silverstripe-installer has nice spacing around each set of rules but the rules added by this module doesn't.
This patch adds a new line before and after the rule set to keep the spacing as intended.

Nice, always keen to keep things tidy and consistent!

thanks :)


Multipool pre-allocation option missing in Helm chart

Is there an existing issue for this?

[x] I have searched the existing issues

Version
equal or higher than v1.16.0 and lower than v1.17.0
What happened?
It is not possible to set ipam-multi-pool-pre-allocation in Helm chart at all. I searched through and through and it is not even in current master branch.
Not sure if this is a bug or CFP but for me it is quite a critical problem as with 8 running pods and /28 pools it is already requesting second pool (8 allocated IPs for pods, 9th for the Proxy, +8 default pre-alloc gives 17 requested -> rounded up to 24 -> second /28 allocated even though only 8 pods are actually running).
I will be sending PR to add this option to cilium-config configmap in a few minutes.
How can we reproduce the issue?

git clone
try to set value for ipam-multi-pool-pre-allocation

Cilium Version
master branch, but not available even in 1.15.x branch we currently use
Kernel Version
not relevant
Kubernetes Version
not relevant, but 1.30 and 1.31 branches
Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

It is not possible to set ipam-multi-pool-pre-allocation in Helm chart at all. I searched through and through and it is not even in current master branch.

Note that you can use extraConfig for this purpose, e.g. --set-string extraConfig.ipam-multi-pool-pre-allocation=default=16,blue=8


Monitor.GetLock: No dynamic type checks if IsLock == true

Monitor.GetLock uses Lock.IsLock to determine whether a given object is a Lock. The Lock.IsLock function is optimized to avoid "the overhead of the full casting logic in the runtime," yet we still perform a typecheck when we cast to Lock since the compiler doesn't know that obj must be an instance of Lock at that point.
This change changes it to use RuntimeHelpers.UncheckedCast instead of a regular cast to avoid the overhead of dynamic typechecking.
Public methods this affects (if obj is a Lock):

Enter
TryEnter
Exit
IsEntered

cc @jkotas

LGTM. Thanks!


[Minor] remove unused method in HoodieActiveTimeline

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@leesf @yanghua @danny0405 have a review please, the method is not be used in global.


Allow for global config

This is a very small change that we have to make in our app to allow us to globally configure the options for TinyMCE once instead of doing it again and again in each controller.
Now we can do the following:
angular
  .module("ui.tinymce")
  .config([
      "uiTinymceConfig", (uiTinymceConfig) => {
        uiTinymceConfig.toolbar = "undo redo | bold italic bullist numlist blockquote styleselect removeformat | charmap link | spellchecker";
        uiTinymceConfig.skin = "lightgray";
        uiTinymceConfig.theme = "modern";
        //etc...
    }
  ]);

Thanks, sorry for the late response.
I will look at this today and get it merged in if needed.

I am not sure why this needs to happen. You should still be able to configure it globally if you add a value to the module of your app. For instance in my app I have:
    /**
     * Global tinymce configs
     */
    module.value("uiTinymceConfig", {
        skin: "light",
        skin_url : "styles/skins/light"
   });

I agree that having it in config might be better, but I don't want to create any breaking changes for people already using it the current way.
Please feel free to comment back on the closed PR, and we can get the change in barring any more information.


Adjustments for SF v0.1.12 (Enginebuild #99303):

As the save-script came in quite handy with fixing a problem on a pal's save, here's my contribution to your efforts by incorporating some changes to comply with latest 0.1.12:

Added support for UTF-16 strings
Introduced 'index' on properties
Added ByteStructure to ArrayStructure

Thank you very much for your contribution!


About beta in NeRF-w

Hello there,
Thank you for contributing this repo.
I have a question about the beta in NeRF-w. In NeRF-w paper, Eq. (12) shows the beta is calculated like
# out[..., 8] is the beta output from MLPs
transient_betas = beta_min + torch.log(1 + torch.exp(out[..., 8]))

But I do not see there are similar lines in this code.
And I have read the 'difference part with the original paper' part in the README.md. I can understand that the beta_min addition is operated after compositing.
I just feel confused why you calculate beta in the way of this code.
Thanks.

The log(1+exp(...)) is just softplus, which I already have in the network activation:
https://github.com/kwea123/nerf_pl/blob/f121fc135dbc75d4edccedfb7d08b58a64fc8c88/models/nerf.py#L101
so my out[..., 8] already corresponds to his log(1+e^beta_i(t)) in the equation.


Why are the annotations given for target domain dataset for training?

I understand that while training both source and target domain datasets are provided. In the paper it is mentioned that only annotations for source domain is required. But in the experiments, both annotations files are requested while training. Can you explain why?

Hi, thanks for your interest!
As Detectron is designed for supervised learning, it requires to pass an annotation file for each dataset for training and testing. When I implemented the method, I didn' intend to make a huge change to the codebase. Thus, I follow the Detectron's way to create an annotation file with pseudo bboxes and pseudo masks for target domain dataset. You could check convert_cityscapes_to_unlabeled_caronly_coco.py to see how we generate pseudo bboxes and masks.


Tooltip with package version in package.json

Issue Type: Bug
This tooltip which tells the latest version of a npm package seems to be not up to date. I use it all the time to know when I need to upgrade but now Sentry told me to upgrade, while the tooltip was still saying I am up to date. This is absolutely no priority, but I thought you should know. Thank you.

Notification from Sentry

VS Code version: Code 1.50.0 (93c2f0fbf16c5a4b10e4d5f89737d9c2c25488a3, 2020-10-07T06:10:52.432Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
AMD Ryzen 7 3700X 8-Core Processor              (16 x 3600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (6.59GB free)

Process Argv
--folder-uri file:///d%3A/WISK --crash-reporter-id 2d04b6c3-62e2-4115-9ffe-3e2e5bda0239

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

vscode-blink-mind
awe
0.0.10

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.1.10

gitlens
eam
10.2.2

EditorConfig
Edi
0.15.1

prettier-vscode
esb
5.7.1

auto-close-tag
for
0.5.9

favorites
kdc
2.4.5

back-n-forth
nic
3.1.0

vetur
oct
0.28.0

vscode-import-cost
wix
2.12.0

Maybe a duplicate of #108605 which has been fixed by @aeschli

dup of https://github.com/microsoft/vscode/issues/108605


Wind gust cli acceptance tests

Added acceptance tests for the wind gust diagnostic cli.
Testing:

[x] Ran tests and they passed.

CLA

[x] If a new developer, signed up to CLA

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- lib/improver/tests/wind_calculations/wind_gust_diagnostic/test_cli_wind_gust_diagnostic.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- lib/improver/tests/wind_calculations/wind_gust_diagnostic/test_cli_wind_gust_diagnostic.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/tests/wind_calculations/wind_gust_diagnostic/test_cli_wind_gust_diagnostic.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/tests/wind_calculations/wind_gust_diagnostic/test_cli_wind_gust_diagnostic.py  1

See the complete overview on Codacy


Validate with regex

https://github.com/RuiSiang/monero-merchant/blob/9b4cee6445e7b7d76ee008ea30244420ebb46215/service/invoice.ts#L29
These (4 and 8 addresses) should probably be validated with regex rather than character length and have corresponding tests added.  Not sure if they have similar/same regext, but for example:  https://monero.stackexchange.com/questions/2554/what-is-the-regex-for-a-monero-address-or-payment-id

Changed, thanks for the suggestion.


DMA unmap notification miss after QEMU shutdowns/fails may occur unmap errors

QEMU does not send any dma unmap notification when it shutdowns/fails, it may occur errors when we quit QEMU first then quit the userspace program which uses libmuser.
Generally, QEMU will notify libmuser dma map/unmap events and libmuser will maintenance the mapping table. However, if the QEMU process was ended, QEMU does not send any dma unmap notification when it shutdowns, which makes the mapping table in the libmuser still exists.
In dma.c, libmuser will unmap all mapped regions by dma_controller_destroy if the userspace program quit. If the QEMU process does not exist, the unmap may fail since it unmap a region that does not exist.  We can see tons of kernel bug in dmesg when this situation occurs.
I think we need to do some cleaning if QEMU fails. Please fix me if there is anything inappropriate.

Closing issue as we haven't heard back from reporter.


[MOB-1220] - reorg mappers

Removed sample mappers from public SDK.

Yes. I will make that change separately. That app depends on Swiftsdk so this needs to be checked in first.

On Feb 24, 2020, at 06:23, Victor Babenko<EMAIL_ADDRESS>wrote:

@vbabenkoru commented on this pull request.
I think the Inbox Customizations sample app depends on this class, it might also require some changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Importing webaudio controls using import - need to wrap in vue

@micbuffa This project looks intriguing to me as it seems to use modern ES module imports with the webaudio controls - could that be considered one of the purposes of this project? The webaudio official docs don't mention import usage.
I'm trying to wrap some webaudio controls in a vue component, so that it plays nice in vue. Should I perhaps be using this project instead of the original g200kg version?
P.S. Not sure if you know anything about vue, but whilst I was able to import the g200kg javascript file in a .vue file using
<template>
  <webaudio-knob ref="knobRef" src="../knobs/LittlePhatty.png" min="0" max="100"></webaudio-knob>
</template>

<script>
import "https://g200kg.github.io/webaudio-controls/webaudio-controls.js"
...

but this gave me
Failed to resolve component: webaudio-knob

Not sure switching to your project would actually help?

Hi, here you can find a very simple vueJS project with webaudiocontrols imported in the HelloWorld.vue component. The trick is to understand that in <webaudio-knob src="./LittlePhatty.png", . corresponds to the public folder. The VueJS compiler resolves . in <img src="./image.png" so you can have image.png under the src folder, but this does not work with custom elements from the webaudiocontrols lib. See this github project : https://github.com/micbuffa/vueJSWithWebAudioControls.git


Language in the Title of Changesets

Hi,
Recently I spotted the first changeset generated by the app. Unfortunately the title is in French, while I would recommend English in non French speaking countries.
https://www.openstreetmap.org/changeset/73905138
BR
tux67

Hi,
"Sortie avec osm go!" is a default value for changeset title.
You can change this title before send data to OSM, the new title will be saved for the next time.
With lastest version, the default value is an empty string.
Thank you for your interest


Create generic event listener with "get subscription" as a method

Related to https://github.com/yzernik/squeaknode/issues/1017

https://github.com/yzernik/squeaknode/pull/1083


invalid pointer casts (byteSwap)

Originated by glimes (31 on babelfish):
cppcheck has a very useful warning about invalid pointer casts which is triggered by the a call to byteSwap. We could patch this with a double-cast ... or we could fix it, by having byteSwap take a (void*) pointer parameter. But fixing it is a good idea, so future cppcheck messages about this condition are more useful.

I do not see any call to byteSwap in this tool.

Could you run cppcheck on the code and confirm there are no invalid pointer cast warnings?

No warning when I did cppcheck:
anh@anh-VirtualBox:/media/sf_share/elf2cfetbl$ cppcheck elf2cfetbl.c
Checking elf2cfetbl.c ...
anh@anh-VirtualBox:/media/sf_share/elf2cfetbl$

Ran with:
cppcheck --enable=performance,portability,warning --std=c99 --std=posix --inconclusive -j 8 *
and confirmed no pointer cast error exists.


IOError in lib/imu.py is not defined

Error triggered by running latest master on a yellow prototype board without an IMU fitted.

Traceback (most recent call last): File "main.py", line 4,
in  File "apps/home/main.py", line 95, in
File "/flash/lib/imu.py", line 32, in init
NameError: name 'IOError' is not defined

Looks like IOError isn't raisable from python - Fixed in cd3a23b82573e2b14b505f52f647e604cda8d050


Switched from NSWindow to NSPane

An NSPane is „A special kind of window that typically performs a function that is auxiliary to the main window.“ and therefore suited better for the use case.

NSPanel's have a lot of uses, but it doesn't fit for a settings window. A settings window is not auxiliary to the main window, it's just another window in your app.
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/WinPanel/Concepts/UsingPanels.html#//apple_ref/doc/uid/20000224

Sorry to come back to this closed request, but I disagree with your opinion regarding NSPanel for settings, and I can support my opinion with what Xcode does:

Others use NSWindow, true. In document based apps, using NSPanel is, at least, a good idea because that way the document window can stay main window and the NSPanel can be auxiliary to it. That way the "current document" window isn't lost.

Apple has been inconsistent about this in the past, but I think the best reference point is SwiftUI.Settings, which uses NSWindow, even when the app is a document-based app (DocumentGroup).

In document based apps, using NSPanel is, at least, a good idea because that way the document window can stay main window and the NSPanel can be auxiliary to it. That way the "current document" window isn't lost.

Windows can be auxiliary without being NSPanel. However, it seems like we are currently not preventing this. Can you try out this: https://github.com/sindresorhus/Settings/pull/125


Add data source for GCP Private Service Connect URIs

Overview
Add a data source for the GCP private service connect URIs described in https://www.elastic.co/guide/en/cloud/current/ec-traffic-filtering-psc.html#ec-private-service-connect-uris. This would make terraform code cleaner while automatically making available new regions with the correct data populated, even if this field is static and not looked up via an API (like ec_stack data source)

Possible Implementation
Static very much possible as long as it tracks the original document, Dynamic might be overkill.

Testing
Instantiate the data source, compare with the URL above.

Context
Not having this I've had to define a local or var in terraform and copy it around from module to module. Prone to copy/paste errors and typos.

Your Environment

All three providers are being done under https://github.com/elastic/terraform-provider-ec/issues/514


Import more from six

@scop have you found everything that can be imported from six?
@Lukasa @haikuginger if the answer to ^ is no, can we hold off until this is completed?

I want this badly, but, like @sigmavirus24, I also want it done once and for all. @scop, if you haven't already, do you want to try searching the repo for any other instances of except ImportError that can be replaced with six helpers?

This commit was done by looking at the output of git grep -B 4 ImportError, I think I caught all of what was there. I just did another run with git grep -B 4 except: and there's one more in it, will force-push in a jiffy.

Okay; in that case I'm 👍. @sigmavirus24, @Lukasa, any other thoughts?
@scop, if you could go ahead and rebase on master, that'd be great.

I'm happy. We can merge when we get the rebase. =D

Rebased.

Nice, thanks @scop! :custard:


fix: Update broken links to PH model catalog item

Fix links to ph povmap model

Updating from external fork


"Failuer" -> "Failure"

This was only done with find ./ -type f -exec sed -i -e 's/Failuer/Failure/g' {} \;, so don't need to add me to every file's copyright 😅.
Nothing seems to break when building, so I assume this is ok. You may want to check further, but it is a lot of files.
I'd recommend moving
const (
	ExitSuccess int = iota // 0
	ExitFailure
)

to internal/lib, and using mb.ExitSuccess / mb.ExitFailure instead; it's kind of just boilerplate right now.

@polynomialspace, this is great jobs!!
I'm Japanese so I can't notice the typo ... Thank you for fixing it!


Questions / clarifications

Hi Otto,
I have a few questions.
It's unclear to me whether the data.py script requires "pre-processed" data, eg with ",COMMA" annotations, or if this is the script that will annotate the data.
case 1: if it requires annotated data, do you intend to provide the preparation script ?
case 2 : if it will annotate data, what kind of data is required ?  tokenized ? normalized for strange punctuation / numbers formatting ?
Can you give an idea of training time depending on amount of data and use of cpu or gpu ?
Last question, if data were properly tokenized, why does it require this specific annotation. Couldn't we use directly the "," and "." ?
thanks for yor insight, and great work by the way.

Hi Vince,
The data.py script requires pre-processed data (case 1). I've used this model mostly in speech recognition and the training data was the same one that I used for language model training (the one and only difference is that LM training data did not have punctuation tokens).
I have not planned to provide the preparation scripts since there is no single right way to do this processing, that works with all languages and datasets. There is no special requirement for numbers formatting (in the Europarl demo, I mapped all numberic tokens to NUM for example). Punctuation should be normalized (no more than one punctuation symbol per inter-word slot). This model does not currently restore intra-word punctuation (e.g. period in 19.5 or A.D.), but I believe that this toolkit can be adjusted for any sequence labelling task with relatively small modifications.
I'll add the training time estimates in the readme at some point. Thanks for the suggestion!
Currently I can say that the model processes about 1500 samples per second on a Tesla K20 GPU and
the best validation cost is usually achieved around epoch 4-5. So for example a 50M word training set would take up to 50 hours.
The ,COMMA, .PERIOD etc.. annotation is not necessary actually as long as the data is properly tokenized and the punctuation symbols separated from the surrounding words with whitespace ("hi , how  are you ?" is also fine for example). You can use any annotation tokens you wish, as long as you define them in data.py script header in PUNCTUATION_VOCABULARY, PUNCTUATION_MAPPING  and EOS_TOKENS  constants).
Best,
Otto

ok thanks.
a simple tokenization should work then.
I'll try it.

There's now an example in ./example that should work well. Training set size is 40M words and should take about 15h on a good GPU.


tailscale: add sysctl to the PATH of tailscaled

Motivation for this change
tailscaled complains that it cannot find sysctl when advertising an exit node with tailscale up --advertise-exit-node.
Warning: couldn't check net.ipv4.ip_forward (exec: "sysctl": executable file not found in $PATH).
Subnet routes won't work without IP forwarding.

https://github.com/tailscale/tailscale/blob/118cf0cd75f92bbe3d994a5b1587c9ea3553221b/ipn/ipnlocal/local.go#L2655-L2670
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tailscale

Also this code section might also be affected if somehow /proc/sys/net/ipv4/ip_forward and /proc/sys/net/ipv6/conf/all/forwarding cannot be read:
https://github.com/tailscale/tailscale/blob/25df067dd0c854eebcd2841b82ad92ebb1d77165/control/controlclient/direct.go#L1113-L1153

Looks like this was fixed by #125955


[CI] Upgrade cuDF and RMM to 0.19 nightly

Might help fix https://github.com/rapidsai/cudf/issues/7722

@trivialfis I'm reverting #6818 to check whether the crash still occurs with the latest cuDF.

Hmm .. a new error trace.

Did it just fix itself?  -, -?

Don't merge, I need to revert the commit and try again.

We ran out of CI budget. Please try again in an hour.

@hcho3 I think it somehow has fixed itself, even without upgrading: https://github.com/dmlc/xgboost/pull/6858 .  It's not determined yet since I didn't run memcheck on that PR.  But for this one, the error seems to be gone.

I recommend hunting it down, unlikely magically goes away :)

Yeah ..  the difficulty is it's not reproducible on CI.  It's very unlikely that we can debug in on Jenkins.

@hcho3 @pseudotensor The issue is addressed.


Different result on extracting tarball

please take a look on gem submission on ARCHIVE
I ran sbo-bot and it got pushed to https://github.com/SlackBuildsOrg/slackbuilds/pull/8742
it shows that no rc.gem exists, but when i look into the tarball in ARCHIVE, it does exists
willysr@home:~$ tar xvf /data/repo/sbo/ARCHIVE/gem.tar.gz
gem/
gem/gem.info
gem/gem.8
gem/gem.SlackBuild
gem/doinst.sh
gem/README
gem/slack-desc
gem/rc.gem

We could change it to force add everything and ignore the gitignore. Then if there is some rubbish, we'd just need to update the PR while reviewing.
Should we make that change?

ah, didn't think of that
i think i was the one who added that entry in gitignore
since there's only 1 entry who had issue, i think we can change the name of the rc.gem into something else to avoid the .gitignore entry


arXiv widget

Feature Request
Is your feature request related to a problem? Please describe.
I find it a bit tedious to have to upload my publications (and those of my research group) to a webpage in markdown. I have created an automated solution base on the arXiv js widget and some existing work by Willie WY Wong (https://qnlw.info/project/custom-website/#arxiv-listing) to integrate it into hugo academic.
I have a JS widget here https://github.com/andrewfowlie/njnu_particle_physics_webpage/blob/main/static/js/arxiv_widget.js. This creates html for a list of arXiv articles found using the official arXiv js widget.
I then create my arXiv preprints pages like this:
---
title: ""
widget: blank
---

I think it's pretty cool. It gives this https://njnu-particle-physics.github.io/preprints/. The athor ID is the only bit a different user would need to change. I use it in the same way on the landing page (but with different maxArticles=5 and showAbstract=0) to create the latest pre-prints section https://njnu-particle-physics.github.io/
If more than one authorID is supplied, the articles are all collected then sorted by date and supplied.
Describe the solution you'd like
I'd like to turn this into a proper widget inside the hugo-academic theme. I think loads of people would use this. But I don't really know what I'm doing, and would need help tidying the styling, html etc etc into something good enough for hugo-acaddemic master.

Closing as an automated publication importer already exists: https://github.com/wowchemy/hugo-academic-cli . The importer is not limited to only arXiv preprints and generates static files for fast loading etc, unlike the proposal in this issue. Furthermore, the display of publications can be fully customised via the Pages/Featured widgets.

@gcushen the publication importer is a rather different solution. This one has some very nice advantages.
I can set my arXiv ID (and the IDs of for the other profiles on our group webpage) then forget it. No need to run a publication importer and update the webpage every time someone on the group publishes a new paper.

Kind suggestion to revisit this. An automated solution is way better for personal webpages if author is frequently making new papers, or academic group pages with many members, where there could be dozens of papers per month. Not as a replacement for current system, but as an alternative.


Get rid of ConfigProjector and ConstraintSet ?

ConstraintSet shouldn't be hard. ConfigProjector might be a little more challenging.
Can ConfigProjector be a typedef pointing to a solver from hpp-constraints ?

Not as of today, but little work is required.


custom scale for useSlider

🙋 Feature Request
For sliders with a wide range of values, a logarithmic or other custom scale can be helpful to enable selecting higher precision for smaller values and lower precision for larger values.
🤔 Expected Behavior
The slider should feel linear, but output values based on a scale function. For example, the bottom of the slider might be zero, the middle might be 100, and the top might be 10,000.
😯 Current Behavior
Currently useSlider only does linear scale.
💁 Possible Solution
It's possible to wrap useSlider with in/out transforms, but the <output> element in the slider is wrong, as will aria-valuetext, etc. It's better if useSlider is aware of the transform.
Material UI offers a scale prop: https://github.com/mui-org/material-ui/pull/19158/files
🔦 Context
Small biz might have 12 of something, where enterprise biz has 100,000 of the same thing. The small biz needs fine granularity at one end of the slider, and the enterprise biz needs large values available—even if they're not as precise—at the other end of the slider.
🧢 Your Company/Team
Scampersand (not affiliated with Adobe)

For anybody looking here for an interim solution, this is what I'm doing:
import {useSliderState as useSliderStateRS} from 'react-stately'

// Wrap react-stately's useSliderState to apply scaling functions.
const useSliderState = ({toPercent, toValue, ...props}) => {
  let state = useSliderStateRS(props)

  if (toPercent && toValue) {
    return {
      ...state,
      getPercentValue: toValue,
      getValuePercent: toPercent,
      setThumbPercent: (index, percent) =>
        state.setThumbValue(index, toValue(percent)),
      getThumbPercent: index => toPercent(state.getThumbValue(index)),
    }
  }

  return state
}

// Make Slider with logarithmic scaling
<Slider
  toPercent={value => Math.log10(value + 1) / Math.log10(maxValue + 1)}
  toValue={percent => 10 ** (percent * Math.log10(maxValue + 1)) - 1}
/>

Hey! thanks for the issue. Just real quick, I think you're trying to do this with your own component, not the React Spectrum Slider, your own slider using the hooks? If so, you could just substitute whatever you want in place of what is returned by the hooks. Something like this:
https://codesandbox.io/s/little-monad-cx9l7?file=/src/App.js
If you're trying to do this with our Slider, then we'll need to check with our Design to make sure this is something we want to support. I think we'd want to explore some different API choices

Hey @snowystinger, thanks for the reply.
You're right, I'm using react-aria and react-stately hooks with my own components. React Spectrum looks nice, but I'm particularly happy with the way you've architected the layers so people can bring their own presentation layer.
And yep, I can substitute what's returned by the hooks—indeed, that's what I'm doing in the code snippet above. Again, I'm really grateful for the architecture that makes this possible.
The downside is that it feels more tightly coupled to the useSliderState internals than I'd like. I had to walk through all the state properties to figure out what to substitute, and I'd be concerned that a minor update release of react-stately could break it.

Right, I see yours is coupled a bit. I think my suggestion is slightly less coupled, as it doesn't alter state being passed from stately to aria, it only deals with things in the render layer. I do have to know about aria properties, but those won't change unless html itself changes. Does that make more sense?
Also, I forgot to say that I'll bring this up with design next week.

Sorry, I didn't mention that I looked at your codesandbox. Thanks for taking a hack at it!
Let's call your suggestion "value scaling" and mine "percent conversion."
The drawback to value scaling is that useSliderState tracks an internal value that's different from the external value, so you have to make sure to catch it and modify at every point. Anything that relies on the value, such as defaultValue, minValue, maxValue, value (controlled) and step are thrown off by the fact that the internal state is different from the external state. That's a lot of implementation details putting a burden on the caller.
By contrast, percent conversion modifies how useSliderState converts values to slider percentages and back. That means that internal and external values stay consistent, and you don't have to take any special measures as the caller.
Intuitively, it seems like there's a drawback to percent conversion, because you have to pass two functions, one for scaling (for determining the value as the slider moves) and the other for unscaling (for positioning the slider given a value). However value scaling actually has the same drawback, because the caller has to do those conversions for the props mentioned above:
value scalingpercent conversion
// adjust by 1 to avoid -Infinity
const scale = intValue => 2 ** intValue - 1
const unscale = extValue => Math.log2(extValue + 1)

// logarithmic Slider [0, 100] defaulting to 50
<Slider
  scale={scale}
  minValue={unscale(0)}
  maxValue={unscale(100)}
  defaultvalue={unscale(50)}
/>

// adjust by 1 to avoid -Infinity
const scale = intValue => 2 ** intValue - 1
const unscale = extValue => Math.log2(extValue + 1)

// logarithmic Slider [0, 100] defaulting to 50
<Slider
  scale={scale}
  unscale={unscale}
  minValue={0}
  maxValue={100}
  defaultvalue={50}
/>

// Slider converts scale/unscale → toValue/toPercent
// internally, so caller can pass simpler functions

I'm thrilled to hear you'll bring this up with Design, thanks!

Ah, yes, I do see the issue for min/max etc, I oversimplified by ignoring them. Thank you for patiently pointing them out.

Hey there @agriffis , we've started our conversation with Design. Could you give some more specifics of the kinds of scales you need? We would like to gather some data to help explore the use cases.

Here are two examples:

"How many employees in your organization?"

For this question, you want to provide high precision for answers at the low end, because it matters to the small biz that they can answer exactly. For large biz, they don't care about precision, they just need to be in the ballpark.
Psychologically, it's affirming for the small biz that their answer of "8" isn't buried at the far left of their slider, even though the slider can accommodate 100,000.
For this kind of slider, you might want log2 or log10 depending on how you want the curve to work.

"How many calories do you typically eat in a day?"

In this example, you want a bell curve. Answers under 1,000 or over 4,000 are atypical but you need to accommodate them. Most of the answers are near the middle and you'd like to have the most precision and usability in that portion of the slider.

No worries, thanks for letting us know!
Good news is, if anyone needs it, the hard work has been done. Just a matter of implementing it now.


Two questions

Hi,
Two quick questions :)

How do I get the View of a specific MaterialSimpleList from the dialog or the adapter? Tried several ways and it didn't work ...
Any way to add a title to a MaterialSimpleList?

Thanks!
Yohay

You'd have to extend the adapter class and override onBindViewHolder.
A title to the dialog? https://github.com/afollestad/material-dialogs#simple-list-dialogs

Thanks!


Missing annotated STR call VCF - in HK?

Description of the bug
Not entirely sure this is a pipeline issue -  CASEID_repeat_expansion_stranger.vcf.gz exists after a run, and in the deliverables file. But then again, there are tags for it in both Hermes and CG. A typo somewhere, or a permissions issue somehow? The index is copied... 🙄  Seen for 3/3 cases investigated.
Command used and terminal output
No response
Relevant files
No response
System information
No response

Thanks for submitting @dnil we'll look into it.

@peterpru have you noticed this issue in your tests?

You can see this with e.g. amusingmarmoset: the file is present in /home/proj/stage/analysis/cases/amusingmarmoset/repeat_expansions/ but not in e.g. /home/proj/stage/housekeeper-bundles/amusingmarmoset/2024-06-25/.

@peterpru have you noticed this issue in your tests?

I can check it out, might have been missed in the PR.

Super! That analysis dir does bear the signs of quite a few reruns, so possibly it would still work if we get a full run from start to finish, but better safe...


chore: Animated Landing Page

Related Issue

Description
Resolved #1823

Added animation to the landing page. I found these value good, if you have any issue or want any change in animation, I'll be more than happy to do so.
Screenshots

@priyankarpal Can you please, what else needs to be done?

@priyankarpal Can you please, what else needs to be done?

will check soon

@priyankarpal Can you please, what else needs to be done?

will check soon

we need to add animations for all pages( docs, projects page, user profile)

Any Update?

yup, adding animations require checking possible values to find the best one that fits all the screen sizes. I would like to create one PR for each page. If you allow 😅

Any Update?

I will check soon

@priyankarpal Please Review Brother

@priyankarpal Please Review Brother

yeah sure


[BUTTON IDEA]: 3D Layered Icon Button

1. Name of button: 3D Layered Icon Button
2. Description: Initially skewed button. On hover, we see a decreasing transparency 3D stack below button
3. Button Type (Animated, Special, etc...): Hover button
4. Will you work on it?: Yes. I'll try adding some fill-in or ripple effect to complement the effect even better. I also want to implement different style for dark and light theme for buttons of different platforms like Google, Facebook, Instagram, Snapchat, LinkedIn, Github and more.

@crew-guy someone tried implementing this before, but it didn't look so good. You may work on it and I'll see how it looks in the end.

@crew-guy someone tried implementing this before, but it didn't look so good. You may work on it and I'll see how it looks in the end.

You were so SO right about this Ma'am. It took me forever to implement just a rudimentary version of this (check out pull request #746 ) 😅😁
But it was really fun ! I look forward to coming up with and implementing more such design ideas !

You did a great job at it @crew-guy , I just need you to make the changes mentioned in the PR and I'm sure it will be a part of the repo soon! Thank you for contributing and trying hard.

Hey !! I have completed both tasks assigned to me. Check out PR - #764 and #763
I gotta say, refactoring my own code from icon buttons to button styles and that too whilst minimizing CSS lines has gotta be the one of the coolest CSS problems I've had to crack
I honestly had no clue about PRs and branches but thanks to these assignments, I have a fairly good idea of how to work around them.
You're a great mentor Ma'am and I really enjoy working with you ! 🙏🏻😄

@crew-guy thank you so much and I hope this repository keeps helping you learn new things! I'll check your PRs soon.

Thanks !!🙏🏻


Add Inspektor Gadget generic plugin

We want to have a generic Inspektor Gadget plugin for Headlamp, so users can get a quick access to all the insights given by it.
This plugin should offer a generic UI for all gadgets, with certain special cases maybe getting their own dedicated UI.
Acceptance Criteria:

[ ] A good % of IG gadgets can be used in the plugin
[ ] CI is set up so the plugin is tested with Headlamp automatically

Todo:

[ ] IG has background running gadgets merged: https://github.com/inspektor-gadget/inspektor-gadget/pull/3587
[ ] Filter UI papercuts are fixed
[ ] UI adapts to new IG UI-related annotations
[ ] Publishing done by IG team

Hey @mauriciovasquezbernal @flyth @eiffel-fl nice work in merging in

https://github.com/inspektor-gadget/inspektor-gadget/pull/3587

We're using this issue to track work for the plugin. If there's any thing left to do can you please link an issue here? Or leave a comment about what's left to do here?

Thanks! There is nothing left on our side at the moment, afaik.


[UI/UX]: White bar under messages (User/AI)

How are you running AnythingLLM?
Docker (local)
What happened?
Everything works fine but this weird white bar shows up under all my messages not sure if this is a bug on my end or I didn't configure it properly but just checking if anyone else had this issue.

AnythingLLM - Docker (Unraid)
Are there known steps to reproduce?
No response

What browser are you using here where this is happening? I cannot replicate this on Chrome. Are you running the latest docker image?

I have this issue as well with the latest anythingllm docker image (pulled a couple of minutes ago). Happens only in Chrome browsers (Chrome, Chromium, Edge) but not in Firefox.

What OS? @mybr4inhurts

We tested this with Windows 10, Windows 11 and Ubuntu 24.04 (x86-64)

Same here. Chromium on Linux with a docker image running on remote macos, latest build available today.


docs: Use Object.defineProperty() for stubbing global properties

Direct assignments to window properties fails silently if they are not
writable, so Object.defineProperty() should be used when stubbing
global properties.
Closes #9287

Summary
#9287
Test plan
This is a documentation-only change.

One of the build's timed out, but I don't think I have permissions to restart it.

Thanks! Mind updating the versioned docs as well?

Sorry, I'm not familiar with this project. Where can I find the versioned docs?

website/versioned_docs :_

website/versioned_docs :)

Thanks!
I'm not sure how that works, though. Which version do I add my changes to? The ManualMocks.md file only exists in two of those version folders: 22.x and 23.x.

Codecov Report

Merging #9288 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9288      +/-   ##
==========================================
- Coverage   64.98%   64.93%   -0.05%
==========================================
  Files         278      278
  Lines       11899    11905       +6
  Branches     2934     2934
==========================================
- Hits         7733     7731       -2
- Misses       3537     3544       +7
- Partials      629      630       +1

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
94.93% <0%> (-1.27%)
:arrow_down:

packages/jest-core/src/collectHandles.ts
2.08% <0%> (-0.3%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c8a69...00833dc. Read the comment docs.

I'm not sure how that works, though. Which version do I add my changes to

If the part you've changed exists (and applies) to that version, it should be updated.

The ManualMocks.md file only exists in two of those version folders: 22.x and 23

A new version is only generated if the newer versions differs from the current one.

OK, I've updated the 23.x version of the docs, since that is the most up-to-date one and is where the matchMedia() example was first added. Hopefully that's what you meant.


LiquidCrystal_PCF8574::print() doesn't handle '\n' character

For example, for string "hello\nworld" on display 16x2 word "hello" should be on first line and "world" on second line.

What should happen when that character occurs on the last line?
Does the controller support vertical scroll directly, or should it write "outside" LCD?

What should happen when that character occurs on the last line?

Just ignore it I think.

Does the controller support vertical scroll directly, or should it write "outside" LCD?

Don't know about these details

My point was that I don't think the library should support anything that the hardware itself doesn't.


update some devtools console docs

@pbakaus PTAL

Awesome work, really like the clearer and simpler wording! One nit that doesn't need to be addressed. LGTM.

@kaycebasques I found one or two things you should look at.


FEI-4957.1: Remove file extensions from imports/requires

Summary:
TypeScript doesn't work with file extensions in imports.  This PR removes all .js file imports and requires.
I use find'n'replace with .js"; and .js");.    In the future I will try using eslint's auto-fixing and if that doesn't work I'll use regex find and replaces to be more precise.
Issue: FEI-4957
Test plan:

yarn lint
yarn test

this makes me sad!  I really got used to using extensions and learned to appreciate the extra readability it gives folks. oh well.

TypeScript doesn't work with file extensions in imports.

I presume this means that we now have the ambiguity of not knowing if ./some-thing is importing a .ts, .tsx, ./some-thing/index.ts, or ./some-thing/index.tsx just from reading the imports. Is that right?
I don't envisage that causing any issues (pretty sure the ./some-thing.js could be ./some-thing.js/index.js anyway, though that wouldn't happen), just wanted to understand any implications for my own personal edification.


each thread has its own engine, handle all connections associated with the engine？

You guided me each thread has its own engine, handle all connections associated with the engine.
I check that the server handles multiple connections in a single thread. Does this mean that the server and client under the same engine do not support multiple threads? Does multithreading have to be under different engines?
My simple multiple clients under the same engine was that one thread went to prog_run to listen to all events, and one thread went to add client connections, add evthread_use_pthreads() was invalid, which caused many unknown problems.
It is normal for a single-threaded engine to process multiple connections at the same time. In the single-threaded state, I didn't think of a way to add connections when I need to add connections. Any suggestions for me?
Must lsquic client and server each thread has its own engine, handle all connections associated with the engine?
Does lsquic support multi-threaded server and client under the same engine?

My simple multiple clients under the same engine was that one thread went to prog_run to listen to all events, and one thread went to add client connections was locked,
Basic errors are reported inside event_base_loop(), how can I lock it?
Is it necessary to lock the place where the source code corresponds to the non-reentrant function that reports the error?

My simple multiple clients under the same engine was that one thread went to prog_run to listen to all events, and one thread went to add client connections was locked,
Basic errors are reported inside event_base_loop(), how can I lock it?
Is it necessary to lock the place where the source code corresponds to the non-reentrant function that reports the error?

Multi-threads start at the same time (engine: connection, 1:1 or 1:n) multi-engine multi-connection client,
The entire client must be locked before the next engine can be established. Multiple engines cannot exist at the same time. Is the method I used wrong? Any suggestions?

lsquic is for event driven application, not for multi-thread application.
It allows use multi-thread to take advantage SMP, but each thread still need to run in event driven mode with its own engine.
lsquic internally does not use mutex or lock. it is your responsibility to make sure only one thread is accessing one engine at any given time, otherwise, there will be race.
There is not much we can help with using lsquic in a true MT application, I would say, it will not work and does not scale.


VS2022 support

Add support for building in VS2022.
1ds only detects vs2017 or vs2019. So when installing packages, if vs2019 is installed the various packages must be installed in 2019 and not 2022.

Have you tried build-all-v143.bat:
https://github.com/microsoft/cpp_client_telemetry/blob/main/build-all-v143.bat
@echo off

set VSTOOLS_VERSION=vs2022
set PlatformToolset=v143
call build-all.bat

Nice. I can use that.
That script is not documented anywhere, and the Windows documentation specifically does not make note of VS2022.

It's documented in README - Build issues are in general out of the support scope due to the unlimited number of build flags combinations.. https://github.com/microsoft/cpp_client_telemetry/pulls?q=is%3Apr+is%3Aclosed+vs2022 - if you feel that something is missing, best way to fix this is to send in a PR.

@pablo-msft can this be closed ?

@latitb I think this can be retitled, since VS2022 can be used, but should not be closed.
I acknowledge that build issues are out of support scope, due to consumers of the library using any combination of flags. However, there is a clear need for documentation of said flags or capabilities, so that new consumers can make informed decisions and use the capabilities of the 1DS library. Visual Studio is the tool that 1DS suggests using to compile its code package for Windows, and it is unclear how to configure it in the first place.


Error message unreadable

plugin version: 2023.1.51
IDEA version: 2023.1.2

Hi. Did restart IDE after switch between theme helps? And please describe how to reproduce this issue, thanks.

I have reset those color to default. Please check these updates if they are solved:
https://plugins.jetbrains.com/files/18922/347273/GerryThemes.jar
https://plugins.jetbrains.com/files/19668/347271/GerryThemesPro.jar


Ping-Passthrough not working

I have a Velocity 3.4.0-SNAPSHOT-451 proxy running with a FABRIC server and a PAPER server behind it.
player-info-forwarding-mode = "modern"
ping-passthrough = "all"
For the Paper server it correctly shows the icon and MOTD
For the Fabric server it shows the velocity icon and MOTD
When adding the fabric server directly it shows the correct icon and motd
I can still connect through velocity though so it is not a connection issue
I am using the default FabricProxy-Lite.toml config with the secret added.
Whenever I press "Refresh" in the server list I get this error in the Fabric server logs
[10:58:37] [Netty Epoll Server IO #2/ERROR]: Exception occurred in netty pipeline

io.netty.channel.unix.Errors$NativeIoException: recvAddress(..) failed: Connection reset by peer

The reason for this error was the mod "Better Compatibility Checker
Better Compatibility Checker"
After removing it the ping passthrough worked again.
I think the mod modifies the messages sent and velocity can't process them.


Opt-out from using onShippingChange() callback with storybook demo

This PR fixes #50 and makes sure the default inline guest feature works with the Standard Cards button for the Buttons Storybook Demo. Ex:

This bug was only for the storybook demos. It turns out the storybook docs addon passes default values for props for component stories like the Buttons story even though we are not passing default prop type values. Passing default functions to most callbacks doesn't matter. But with the onShippingChange callback it does matter and using that option forces the user into the popup experience with the Standard Cards button. This PR passes null instead of a noop function to onShippingChange so the inline guest functionality works as expected.

@elizabethmv I pushed up a couple more commits. Please test this again locally.

When testing this locally I'm getting a mix of both. Sometimes I get the popup sometimes I get inline 🤔

When testing locally here's what to look for:

All the example paypal button stories should open the inline guest form. I noticed this was not the case from your screenshot. Please clear browser cache and try again. I wasn't able to reproduce on my end. If it still happens for you please let me know and I will dig into it more.
The subscriptions example always uses the popup approach. The subscription functionality really depends on the buyer signing in and doesn't work with the buyer being a guest. The toggle demo with subscriptions should use the inline guest form when Order is selected. There was a bug related to "intent=order" no longer being a valild query param. I fixed that and it's working again:

The Marks radio button example was broken. It seems like the default color for the Marks standard card button is gold which is breaking it. Explicitly setting all the button colors to white fixes the issue.

@elizabethmv I see what you mean now. I can reproduce the inconsistent popup behavior. I tested in Chrome and it seems to open up the popup the most compared to other browsers. It's definitely inconsistent. I think this PR is still a good improvement so I'm going to merge it.


Issue with rearranged code

I have arranged the code to multiple files and classes, but now there are some function declaration issues.

Issue fixed. It was missing some functions.


Feature/settings

added vscode settings to ignore certain errors/warnings from the lua LSP

i have no idea why that last commit caused every indent to double in size

did a git pull on my windows laptop and everything seemed fine, i think my previous file on my desktop had only 2 spaces per indent, even though it looked normal on the diff. anyways, should be fine

i'm just going to make a new branch with the changes so that no funky merge conflicts on current branches happens