Moderation shortage

(Creating a new issue since it was indicated in #20 that anything pertaining to number of moderators would be considered off-topic there.)
I've noticed a shortage of moderation in #Node.js in the past few weeks, unfortunately. There have been a few cases where it was difficult to get hold of an active channel moderator, to deal with a problematic user - in fact, there's such a problematic user active in the channel right now that refuses to leave.
Is this a known issue?

I don't think Node.js Foundation ever took on #Node.js IRC channel officially. I think it's a separate, independent entity, although managing it in a more official capacity has certainly been discussed.
That doesn't answer your question, but it hopefully provides some context and explains a difficulty.
cc'ing a few folks who are ops in #Node.js who are also sometimes active in the nodejs GitHub discussions: @ashleygwilliams @feross @isaacs @brycebaril

It was indicated in nodejs/TSC#121 (specifically, in this post) that further discussion should be directed here - hence why I'm filing this issue here :)
I honestly have no idea where else I'd file this anyway.

This is definitely something that needs to be figured out. There has been an active discussion around more "official" communication channels and the community committee is definitely the right place to solve those issues. @nodejs/community-committee, let's make sure this is on the agenda for the next call (if it's not already, I'm still catching up after being a bit disconnected the past couple of weeks)

@isaacs has more or less handed over #Node.js to myself/@emilyrose.
If we want to add more people so that we can cover odd times better (or any other reason really) then let's do it.
Most of the existing OPs are more inactive than active, fwiw.

I'm perpetually idling and often by computer. Willing to help with op duties
On Tue, Apr 18, 2017, 6:05 PM Jeremiah Senkpiel<EMAIL_ADDRESS>wrote:

@isaacs https://github.com/isaacs has more or less handed over #Node.js
to myself/@emilyrose https://github.com/emilyrose.
If we want to add more people so that we can cover odd times better (or
any other reason really) then let's do it.
Most of the existing OPs are more inactive than active, fwiw.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/community-committee/issues/33#issuecomment-294998010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAecV1QhZ8btMA1ADuj4pvr66cUIhcD-ks5rxTPDgaJpZM4M-dkR
.

I'm removing the cc-agenda label because there are some broader structural changes that need to happen before we can really discuss this issue.

I need to +1 this in a big way.
From my perspective: For the last 2 years #node.js has had no active mods, full stop.
At some point, Max casually added @avianflu (I don't know the full timeline) and as we realized that the mods were asleep at the wheel, he started trying to step in despite the fact that he doesn't work in node anymore. Eventually, in the last 3 or 4 months, he asked me to help because I've been complaining about this problem non-stop on twitter pretty much every time a troll shows up.
Now, I'm glad to do this. Banning jerkwads is one of my primary skills! I'm way better at this than dealing with the minutiae of trying to run a community project through github issues.
@Fishrock123 was nice enough to point me in the right direction(s) as far as access to repos and has been around for the assist recently thank goodness. But someone, somewhere, has been asleep at the wheel, and that's not OK. Even now, with 3 of us part-time, we're overwhelmed. Which isn't surprising, considering the room has ~1000 people in it.
Some things I would like to get cleared up:

Does the node.js CoC cover the irc room? Ts the irc room considered one of the spaces "owned" by the project?
Who used to moderate the node.js irc room? Are they existing or past members of the CTC?
Why have mods been afk for so long? If not part of the CTC, do they expect to be able to come back and assert authority after years of being absent? If part of the CTC, why have issues around moderation not been resolved?
If #node.js is a space controlled by the project, and presumably there are general purpose moderation resources, can we get a hand?

@jfhbrook I use irccloud as a client, so while I'm always present in the room, I'm not always immediately there. Maybe we should redefine how reporting should be if someone violates something / needs moderation. Because while I might not be directly in front of my screen, I also have irccloud on my phone and can jump in at any moment.

This is good! And something I would like to work on as well--my client is still irssi in a tmux session, and as you might imagine doesn't work great on phones. I can get decent coverage during the workday and most worknights, just by virtue of not leaving my apartment.
I don't expect perfect coverage, and in fact I was basically OOO the last 3 weeks due to medical issues. I just need help, is all.
Moderating IRC is challenging because it has to happen on 2 levels (and I'm making this up based on my experiences, if any of you here have some theory to throw behind this I'm definitely interested):

on-call: someone mentions you, and it sets off an alarm that makes your phone beep. You hop in and ban the spammer. This is the easy case, but one that has been the most difficult to deal with. Many of us only have visual bells. I can fix this, with some patience while I find the spoons to switch to irccloud.
participatory de-escalation: A lot of times, someone isn't actively spouting truly odious ideas but are instead getting in a fight with someone over a software opinion, or maybe someone is being just sexist enough to bother people, in which case you have to be actually paying attention in order to try and set the tone for the rest of the conversation, issue warnings, etc. Giving some of your more active users faith that you'll take care of something when pm'd ( @joepie91 is pretty good at this kind of thing) helps, but isn't a substitute for actually hanging out some odd Thursday night.

If you're volunteering to be involved in the irc room @rachelnicole that's fantastic! Same with @MylesBorins but I feel like a lot of people have volunteered and then haven't been around. But dunno, maybe I'm just being grouchy. Totally willing to start w/ a clean slate here.

I want to ask about this for a second:

@isaacs has more or less handed over #Node.js to myself/@emilyrose.

So am I to read this as:

The channel is not an official project space
The owners are officially (is this reflected in the access list at all?) @Fishrock123 and @Amorelandra

If so, some immediate problems:

@baudehlo made some comments earlier today that indicated that, to me, at one point in time, @aredridel was basically running the show but that was all definitely a very long time ago and as far as I can tell there's been zero communication by anyone as to what the actual state is...maybe we should either (a) clean up the moderation list or (b) go through the effort to bring them into the fold? Possibly some combination thereof?
From the same conversation and others, it became clear to me that, if the irc room isn't a project space that the decision to adopt node's CoC as the official rules has not been reached by any kind of consensus (though with the amount of afk people on the moderation list, how could we?)

@jfhbrook i agree with #1, we should re-review the moderation list and try and reach out to those who are lapsed.
Also for #2, that's totally something that the Community Committee can vote on, for bringing it under the jurisdiction of the org. Perhaps someone else might have some more guidance?

so idk freenode channel ownership rules (or even how its chanserv does that kinda thing, I've mostly worked with mibbit in terms of access lists), but it would probably be good to make sure we know who holds the keys in case someone feels like they're being usurped. With 20 mods I could see at least one of them going poorly.

I'm always around and always available at a ping in EST work hours. I don't actively read the channel because it's too active. I've been out for 2 weeks due to a new baby.
I'm not sure what the major concern is here and I disagree with @jfhbrook's shouty headline above about nobody being around for the last 2 years. I'm just a silent member of the channel 99% of the time.

The lack of moderation on IRC channel is a problem and is driving people away. A member of the community has only recently described #node.js on another Freenode channel as "regularly explodes into flame wars" and eventually left because they "can't stand it anymore". IMO, IRC should indeed have a higher level of tolerance for language because of its instant nature, but some of the things that are said in the channel would have provoked a swift moderation response had it been on GitHub. (Just read the logs and decide for yourselves.)

@baudehlo congrats on the child!
but I haven't seen you take a single moderation action, even when we've mass pinged mods in the past. Even so, people have to be actively participating at least sometimes to be an effective mod, I'm sorry.

I have all my logs in irccloud going back years. When was this ping and who from?
If I'm at work when I'm pinged I respond, always.
Here's the full list of "pings" I have:

I have one ping from kiraid on May 12th at 9:08pm. I'm not around at that time.
Another from naezith on December 28th 2016 at 6:19pm. I wasn't around.
I have sdegutis asking if I'm an op on August 28th at 2:06pm which I responded yes to, there were no further questions.
I have a conversation with AvianFlu (another Op) about banning Avinash on September 20th, 2016.

That's literally all the PMs I have regarding ops on #Node.js, aside from questions from people unable to talk without registering.
The moderation actions I've taken have been light handed, telling people to cut it our or chill when required. Mostly I've been inactive because nobody has asked me to help out with a problem (and I don't actively read the channel because there's too much backlog to go through to keep up with everything).
As for driving people away, you need data to back that up rather than an anecdote. The reduction in content in #Node.js (I graphed it over the last 2 years to check) matches the general reduction in usage of IRC across multiple channels.
I'm not arguing that we don't need more moderators (we do, mostly to cover timezones), but if there's issues requiring moderation on #Node.js, nobody is contacting me about them, and I can prove it.

@baudehlo I have pinged a number of ops (including you) in the channel several times in recent history:
[Saturday, April 08, 2017] [11:21:33 PM] <joepie91>	ping mscdex feross baudehlo
[Saturday, April 15, 2017] [09:49:31 PM] <joepie91>	feross: baudehlo: mscdex: around?
[Thursday, June 01, 2017] [08:36:42 PM] <joepie91>	ec: probably should. topic tends to lag behind :) cc mylesborins mscdex feross Fishrock123 baudehlo
[Thursday, June 01, 2017] [08:40:01 PM] <joepie91>	baudehlo: thanks :)
[Monday, July 10, 2017] [02:25:16 PM] <joepie91>	ping baudehlo, feross, mscdex, mylesborins - any of you happen to be around?
[Saturday, July 22, 2017] [06:27:14 PM] <joepie91>	paging baudehlo, feross, jfhbrook, mscdex, mylesborins, whichever op is currently awake.

Of these cases, you only responded on June 1, by updating the topic.
As for me personally, I typically only bother pinging ops in channel in extreme cases, because it virtually never results in an op response anyway (from either you or anybody else, leaving the reason for that aside), and there's a real risk of it further escalating the situation, as it has done in the past.
Pinging ops privately is something that I might more easily do... if it actually resulted in responses from the ops I pinged, and there was a clear indication of what ops are going to be available. Somebody never responding to pings in channel doesn't inspire confidence in me that they're going to respond to a ping in private, and it costs time and effort to reconcile/centralize things if multiple ops end up responding to a PM about the same incident.
On top of that, active coverage of the channel (ops responding to incidents of their own accord, without needing to be actively notified of incidents) is essentially nonexistent. All of this together means that there's a moderation problem, and that people stop bothering to report incidents. The massive access list, mostly containing inactive users, exacerbates that problem.
So far, the only op who consistently gets back to me about incidents, has been @AvianFlu - however, he's rarely around at the same time as I am, and often isn't around when incidents occur. That's not a point of criticism towards him personally (as he's in a different timezone), just an observation of how this makes rule enforcement difficult.
As far as I'm concerned, the following things need to happen:

Clean up the access list, removing everybody who has no intention of moderating the channel. This clarifies towards users who the contact points are for incidents.
Consistently respond to in-channel notifications as well as private notifications, ensuring that incidents have been handled.
Actively moderate the channel, keeping at least a cursory eye on what happens in the channel even if nobody is explicitly pinging ops.
As already said, enough ops to actually cover the channel, availability-wise. There don't need to be sub-minute response times, but having to wait 2 days for moderator resolution (if one occurs at all!) is just too long, for a channel of this size and importance.

#2 is hard because on a channel with lots of scrollback it's hard to find who said your name (maybe easier in other clients, I'm not sure). PM ops if you want them. I will respond, fast in EST business hours, slower in all other cases. I get PMs on my phone though, so you will likely have more luck that way.
Perhaps we should say that in the /topic too.
As I said, we do need more moderators, but finding them is HARD, and trying to call out the current ones on being inactive isn't a good approach.

i think whatever we decide on it should definitely be reflected in a gist somewhere so people can see who to contact / about what, etc.
i run irc cloud too, and often the only questions i get in pings are people asking me why other people banned them, or technical questions.

I agree that @AvianFlu has been fantastic.
I also agree that it would be nice to get some nite modz. We're pretty US-centric, and while ime traffic does decrease at night, there are still situations that happen at 3:00am eastern.
As previously mentioned, I feel pretty strongly that the best ops are going to be ones that are actively involved in the channel at least sometimes--I've deescalated a number of situations without anyone getting pinged, just by being Around. This is something that simply can't be done with an on-call model.
I have few concerns around alienating existing mods for calling them out on being afk, since worst case they're still afk. I suspect a number of them have written off irc and spend most of their time on curated slack spaces like wealljs, and just haven't bothered to deop themselves out of a sense of duty. If that's not the case--and it sounds like @baudehlo is overwhelmed by chat volume but does legitimately want to be available--then we can talk.
Also in agreement about updating messaging in our topic to clarify open issues. I think active mods have been a little shy with the topic, given the lack of a clear owner of the channel.

Regarding an on-call, one idea, and I don't have much bandwidth for hacking these days, is a moderation bot that implements oncall schedules, so you'd !oncall and hilight mods that have registered as being available at those times.

@jfhbrook just wanted to dispute your "2 years" comment; until last September or so, I've been a very active op in that channel, frequently enforcing the node CoC and moderating issues. During my 2 years or so being an op there were very few times I wasn't online when an issue occurred.

I'll be the first to admit that my sense of time is very poor. I'll regularly confuse 6 weeks and 6 months in conversation, much to the frustration of my friends. In other words, I don't entirely dispute that.

@jfhbrook: Regarding an on-call, one idea, and I don't have much bandwidth for hacking these days, is a moderation bot that implements oncall schedules, so you'd !oncall and hilight mods that have registered as being available at those times.

You'd probably want !ops, then - that's the de facto standard for these kind of bot pings in most channels, and I've more than once seen a user attempt to use that command in #Node.js as well.

@baudehlo: #2 is hard because on a channel with lots of scrollback it's hard to find who said your name (maybe easier in other clients, I'm not sure). PM ops if you want them.

I understand that this can be tricky, but it's not reasonable to expect random channel users (ie. not me) to PM 5-10 people on the access list in the hopes of catching one that's active. This is a problem that's easier to solve on the ops' side (client configuration that shows a channel highlight list or such), than on the users' side. Putting things in the topic isn't likely to help with that, either.

I'm also going to throw out there, and I'm not necessarily advocating for anything, but @ljharb was at one point in time a mod, and while I don't remember how that went or why his @ got taken away (probably @Amorelandra can say more) I've seen him be pretty involved in the channel and having deescalated a number of situations. If we're going to be cleaning up the access list and adding people that are de facto more involved, this is something to consider.
Again, just throwing it out there.

RE: !ops, is that smart enough to not ping me if I'm sleeping? Not critical for this kinda thing, jsut wondering.

Hey everyone. I'm glad to see an increased interest in moderation of IRC.
It seems like we have an issue that might involve technical solutions as well as additional recruitment.
I'd also just like to mention that I'm almost always available to drop into IRC. I'm not currently idling a client in the channel, but I can be reached via twitter (my DMs are open).

@Amorelandra something I would very much like to see is, from everyone on the access list, either a commitment to be on irc and participating in chat for at least a few hours a week, or voluntarily removing themselves from the access list. Considering that you're not even on freenode: how do you respond?

@jfhbrook I'd respond by asking you to chill a little bit. I don't think it's reasonable to expect moderators to be online 24/7.

No, but it's reasonable to expect moderators to be online and participating a couple times a week. It's possible we've just missed each other, but I have not ran into you on that channel in what feels like months. You're not the only one either.

Yep, you've definitely been missing me, then.
I'm happy to chat through solutions, but the blame game doesn't seem like a productive endeavor.

I don't want to blame people, I want mods that do more than idle, and I don't appreciate being told that the status quo is ok, because it's not, and I know this isn't just me--multiple people have already backed me up on this.

being told that the status quo is ok

who's saying this to you?

All I know is that I'm getting resistance when I'm saying that mods are generally unavailable. I interpret this as being told that existing mod coverage is fine.

I think we would all do better to ask clarifying questions rather than making assumptions.
What can I help clarify?

@jfhbrook: RE: !ops, is that smart enough to not ping me if I'm sleeping? Not critical for this kinda thing, just wondering. This is assuming that there's a canned solution we can deploy.

I'm not aware of any !ops bots that are availability-aware (ie. have an 'on call' system). It wouldn't be hard to write one, though.

Sure:

@joepie91 has strong evidence that we've had extreme difficulty getting ahold of moderators at many hours of the day, and I can anecdotally confirm. Why is this? why shouldn't existing mods have to answer for this in some manner?
Out of people currently opped in the channel, I've seen @AvianFlu actively moderate, and myself participating casually at work and more in-depth at home and on weekends. I've hardly seen anyone else on the access list participating in the chat. I suspect many of them don't use IRC anymore. Why shouldn't we clean these people out of the access list, so it's more clear who can/will be able to take action?
I've said multiple times that being on-call isn't enough, since many issues get bad enough to turn off users but not so bad that they pull up the channel list and start pinging names. I seem to be getting pushback on this, and I don't understand why. Surely "DM people on twitter" isn't an generally acceptable means of accessing an irc mod.
Who actually owns the channel? Are they still involved in the management of the channel? If not, can we transfer ownership?
Why should I bother trying to help, if this is going to end up being a scenario where it's effectively just me and @AvianFlu ? This conversation is making me feel like I should throw in the towel on both moderation and participation in the irc room.

@joepie91 starting to think that the on-call schedule component would be more trouble than it's worth. :) but worth talking through regardless.

Why is this? why shouldn't existing mods have to answer for this in some manner?

Because this isn't an inquisition, it's a call for solutions. People are allowed to have lives that exist outside of IRC. There's nothing to "answer for".

Why shouldn't we clean these people out of the access list, so it's more clear who can/will be able to take action?

If the desire is for more moderation, why are you asking to remove access for existing moderators? There is no real limit to the number of people who can be on the list. It seems to make more sense to simply find additional folks willing to get involved.

I seem to be getting pushback on this

What is giving you this perception?

This conversation is making me feel like I should throw in the towel on both moderation and participation in the irc room.

I will admit that from my perspective you do seem rather aggressive with the way you're approaching the conversation. Perhaps it would be in your best interest to consider stepping away for the time being? It's rarely good to be involved in situations that actively cause you stress.

@Amorelandra Because this isn't an inquisition, it's a call for solutions. People are allowed to have lives that exist outside of IRC. There's nothing to "answer for".

Sure, they are, but when those lives become so time-consuming that people are unable to moderate the IRC channel, then perhaps they are not in a good position to be moderators for it?

@Amorelandra: If the desire is for more moderation, why are you asking to remove access for existing moderators? There is no real limit to the number of people who can be on the list. It seems to make more sense to simply find additional folks willing to get involved.

I already answered this several comments ago: it is unclear who is available to deal with channel incidents, and people are discouraged from reporting issues when the people they message or ping consistently don't ever answer.

I already answered this several comments ago: it is unclear who is available to deal with channel incidents, and people are discouraged from reporting issues when the people they message or ping consistently don't ever answer.

This sounds like a problem in need of a technical solution. I like the idea of a way to ping all ops via a simple and well-understood command.

I'm not sure tone policing is going to help keep the conversation productive.

Because this isn't an inquisition, it's a call for solutions. People are allowed to have lives that exist outside of IRC. There's nothing to "answer for".

Being an irc moderator is a responsibility. Either you take on that responsibility, or you don't. This doesn't fly.

If the desire is for more moderation, why are you asking to remove access for existing moderators?

It's extremely disheartening when those moderators don't actually show up to do anything. A name that doesn't lead to anything is more than useless, it's just noise. There needs to be some confidence level around thinking that pinging a mod will actually bring someone online. It's also unclear who I, as a mod, can talk to, when I need a second opinion.
Again, being a mod is a responsibility, not a badge that you get to wear so you feel cool.

What is giving you this perception?

You, baudehlo, myles, even rachel, have all responded with "I'll respond to pings" as though that's enough. Few people have volunteered to participate, and yet want to keep their sherrif's badge.

I will admit that from my perspective you do seem rather aggressive with the way you're approaching the conversation. Perhaps it would be in your best interest to consider stepping away for the time being? It's rarely good to be involved in situations that actively cause you stress.

If it seems like I'm being aggressive, it's because seeing a channel I love go down the shitter due to non-moderation is a problem that's been bothering me for a very long time, and it's only now that I've been able to find a venue to express this. But really, I don't appreciate the tone policing either. What I'm saying is valid, even if you don't like it.

I like the idea of a way to ping all ops via a simple and well-understood command.

Doing this manually, as people have done, rarely works. This is not in and of itself a solution, just a piece of the puzzle. That said, this is something I want to see, since in many clients pulling up the names list, searching for @s and pinging them one by one is hard work. Lower barriers of entry are always good.

@Jfhbrook how is saying that I'll be responsive if someone pings me not participating? Legitimate question. I'm always online as part of my job as is a lot of other people on the list. Perhaps we just need to create a better call to action for situations that need to be moderated.

@rachelnicole participation means hanging out in the irc room, answering questions, talking to people, noticing when prometh is being a jerk about angular again and reminding people that we all have different opinions about tech and that shitting on other peoples' work isn't really acceptable, etc.
You can't get that from idling.

Being an irc moderator is a responsibility. Either you take on that responsibility, or you don't. This doesn't fly.

What kind of answers are you looking for?

sherrif's badge.

I'm not comfortable with this association.

But really, I don't appreciate the tone policing either. What I'm saying is valid, even if you don't like it.

My apologies if it came across as "tone policing", but I'm trying to understand your perspective and ask for clarification. Nothing I have said has been an attempt to invalidate what you're saying. Please do not misinterpret my concern for your well-being as an attempt to police your tone.

my concern for your well-being

I don't believe for a second that this is in good faith.

I'm not comfortable with this association.

Hey, I'm not a huge fan of the cops either. Insert whatever metaphor you prefer--the point is that the @ isn't something you get for being cool.

What kind of answers are you looking for?

See my answer to rachel's question.

@jfhbrook idk i think in this case, I disagree. I've been using irc for over half my life and have been in lots of channels that run like ours do.
You don't need to be a moderator to tell people that people have different opinions on tech. Moderation is only necessary when users can't self moderate themselves.
I am willing to come up with a better solution than what exists though! It should be revisited

I don't believe for a second that this is in good faith.

OK, then! I'll be abstaining from further comment.

You don't need to be a moderator to tell people that people have different opinions on tech. Moderation is only necessary when users can't self moderate themselves.

Which occurs with some regularity, and there is no clear escalation path, nor is there active participation from channel operators to spot trouble before people walk out in frustration. Which is why this thread exists in the first place.
I'm not sure what is even being discussed now. It has been indicated repeatedly that there is a problem with the level of moderation in the channel, by multiple people, from multiple perspectives. It's clear that the current moderation policy is not working, so I don't get why this discussion seems to be devolving into what sounds a lot like "but it's fine how it is now".
Why are we still discussing the merits of the complaints, instead of finding concrete solutions to the problems that have already been pretty conclusively shown to exist? I don't feel like the complaints are taken seriously right now.

Joshua what you're missing from your "if you're not active then GTFO"
response is that not everyone is active all the time, and so taking that
attitude means you'll just kick someone off the list because they haven't
been active for N days/months, when they may have just been super busy at
work, or in their personal life, and will get back to being on #Node.js
soon. I've definitely been that way. I go through dips and peaks on it.  Better
to just add more moderators than try and threaten the existing ones with
being kicked out if they don't participate.
If you're feeling a bit of moderator pushback, it's because this became a
bit of a witch hunt in which we had to defend ourselves. Nobody likes doing
that. It's not fun.
The !ops bot looks like a reasonable solution to me. Surely we can just add
a bot like that and try that as an interim solution until more people
volunteer to moderate?
On Fri, Sep 1, 2017 at 2:18 PM, Emily Rose<EMAIL_ADDRESS>wrote:

Being an irc moderator is a responsibility. Either you take on that
responsibility, or you don't. This doesn't fly.
What kind of answers are you looking for?
sherrif's badge.
I'm not comfortable with this association.
But really, I don't appreciate the tone policing either. What I'm saying
is valid, even if you don't like it.
My apologies if it came across as "tone policing", but I'm trying to
understand your perspective and ask for clarification. Nothing I have said
has been an attempt to invalidate what you're saying. Please do not
misinterpret my concern for your well-being as an attempt to police your
tone.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/community-committee/issues/33#issuecomment-326650200,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAobY06DS7-JxPCo8tJpMt4OzaiZVYNaks5seEpogaJpZM4M-dkR
.

@joepie91 I just said "I am willing to come up with a better solution than what exists though! It should be revisited"
Should we close this issue and start a new one with actionable items / requests to keep better track of how to improve the policy?

I don't see what closing this issue and opening a new one would accomplish. I've already provided a number of actionable items for solving the moderation issues in the channel, based on over two years of active participation(!) in the channel, but instead people seem to be getting upset about the possibility of their +o being taken away.
I really don't get the fuss here. It's in the channel's best interest to keep the access list devoid of inactive users, as it's a standardized way to consult the users responsible for managing a channel (with or without an !ops bot), which means that having inactive entries on it will confuse and frustrate users, not to mention the security implications of keeping access around for people who don't need it from a pragmatic perspective.
Okay, sometimes life takes over, and sometimes that means one doesn't have time to spend on moderation for an extended period of time. What is the problem with removing access in the meantime? It can be re-added once somebody is available again. This is turning into a storm in a teacup, and by this point I can't help but feel that this is more about status symbols than about the channel's best interests.
Once again: this problem can be solved by cleaning up the access list, finding new operators who can commit to participating actively in the channel for some amount of time, and improving response consistency when ops are explicitly pinged. These are the actionable items, and as far as I'm concerned, anything that doesn't address these points is just noise. This thread has been going on for several months now with no concrete solutions in sight.
And yes, I am beginning to get frustrated, because this thread is devolving into what seems like interpersonal drama and non-constructively picking on specific words and phrases, when really it should be exclusively about how to best moderate the channel. I don't even really care who the ops are, so long as they can commit to the above, and act in the channel's best interests.

Okay cool, I'm fine with stepping down from ops since the level of participation I'm willing to contribute seems to be not good enough for what you think is best for the channel.
Good luck.

@rachelnicole please reconsider. IMHO this issue is about having more ops rather than less ops.
I'm definitely not agreeing on the direction this conversation is taking.
Can we talk about more ops, rather than a process to remove the existing ops?

I agree with Rachel, if that's the consensus then I'm happy to step down
too. Keeping adding/removing mods based on their activity level seems like
a daft idea to me, as you'll just remove people never to add them back. I
don't know why Sven is going all hyperbole on this. We've said we want more
moderators and better tools, but it seems to be the aim to get rid of the
current mod team and find a new one.
Good luck, sincerely.
On Fri, Sep 1, 2017 at 3:04 PM, Rachel White<EMAIL_ADDRESS>wrote:

Okay cool, I'm fine with stepping down from ops since the level of
participation I'm willing to contribute seems to be not good enough for
what you think is best for the channel.
Good luck.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/community-committee/issues/33#issuecomment-326660507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAobY1JghHCqA4XPyjPuDUVa_sMeZodaks5seFVQgaJpZM4M-dkR
.

@mcollina i tried to steer the conversation into a different direction explicitly talking about improvements in a clean thread and it seemed to be not good enough. I think @joepie91 is under the impression that some people care about the 'status' of being an op, which I honestly couldn't care less about, I just volunteered last time someone asked if i would be willing to help.

well hey, I'm out. It's clear that nobody in this group sees eye-to-eye with me when it comes to the commitment that being an op on irc should bring with it, and I'm unwilling to put in the effort I think is necessary if I get minimal backup.

@jfhbrook Reading this scrollback, I see a lot of folks agreeing with you on the need to fix a lot of problems you've generously spent your time identifying. The methods to which you were offering a solution they may have disagreed on, but we have to find some common ground here.
Ultimately, this entire thing, a large OSS effort, is still almost entirely a volunteer effort. I am a paid employee of the Node.js Foundation, but there is so much work to be done that much of my GitHub and IRC time is very much outside of any sort of work hours.  This project relies on people stepping up and offering the time they have available. The complication with moderators is that while anyone can volunteer, it doesn't mean that (a) they have the skillset to do so and if they have the skillset, (b) they may not have a lot of time. Do we not allow folks to volunteer if they can't commit to enough hours? I think that was the heart of the conversation y'all were drilling down to, but I'd love to hear thoughts.
@joepie91 @rachelnicole @baudehlo @Amorelandra Thanks for offering up your time and ideas as well. I'd been added as a moderator but also have not gotten many pings. I've had some one on one conversations with folks to moderate, but I've also missed a few. I have felt the guilt around not being available enough, which is why we had started this lovely thread AND this one.

Thank you, @hackygolucky.
After talking through issues discussed in this thread I've done two things to improve my availability and address what I perceive as misgivings:

I have switched to the use of IRCCloud so as to be alerted of pings via my mobile device as well.
I have removed auto-op from my channel access flags, so that my name longer appears by default with the contentious "+o/sheriff's badge" that's been mentioned.

I'm also experimenting with a bot to make it much easier to alert available mods. No promises on this front, but interested parties should hit me up if they'd like to collaborate.

@hackygolucky,
The only reason this channel has any traction at all is because of about a dozen people that spend almost all day in there, on a volunteer basis. Obvious examples include ljharb and joepie, but there are others. I get that volunteering takes time, but there are currently people taking that time even though they're largely powerless to fix problems when they see them.
Yes, I do think that moderating in irc should be a commitment, because moderating irc is difficult and when done poorly leads to channel quality going down the toilet. I've had to leave multiple irc channels over peoples' inability to moderate them or make them welcoming spaces. It's really sad to me that #node.js is basically on that list now.
As I've said multiple times, I don't expect people to be chatting 24/7, or not going on vacation, etc. But if someone is gone for months at a time and/or "doesn't really do irc anymore"? Yes, it would be appropriate to ask if they're being effective at the position that they volunteered for.
At any rate, I'm done, both with this thread and with the irc room. I'll be clicking the unfollow button.

[I'm happy to re-post this on another thread if appropriate]
If you have any interest in helping to moderate the IRC channel, and you are at least somewhat active on a regular basis: let me know. You don't have to be an expert at IRC. I will be more than happy to show you the commands and explain our moderation strategy.

Why aren't ljharb and joepie mods?

On Sep 1, 2017, at 6:56 PM, Joshua Holbrook<EMAIL_ADDRESS>wrote:
@hackygolucky,
The only reason this channel has any traction at all is because of about a dozen people that spend almost all day in there, on a volunteer basis. Obvious examples include ljharb and joepie, but there are others. I get that volunteering takes time, but there are currently people taking that time even though they're largely powerless to fix problems when they see them.
Yes, I do think that moderating in irc should be a commitment, because moderating irc is difficult and when done poorly leads to channel quality going down the toilet. I've had to leave multiple irc channels over peoples' inability to moderate them or make them welcoming spaces. It's really sad to me that #node.js is basically on that list now.
As I've said multiple times, I don't expect people to be chatting 24/7, or not going on vacation, etc. But if someone is gone for months at a time and/or "doesn't really do irc anymore"? Yes, it would be appropriate to ask if they're being effective at the position that they volunteered for.
At any rate, I'm done, both with this thread and with the irc room. I'll be clicking the unfollow button.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Amorelandra definitely interested in collaborating on that bot - happy to help however I can. 👍

(I'm only around for a brief moment today - I'll write a more extensive post later, if people have further questions.)
@baudehlo: For me personally, the offer has been extended to me in the past, but I've turned it down due to conflict-of-interest issues; most notably, some of my tutoring customers come from #Node.js, and I don't want to create an impression that my services are in any way 'officially sanctioned'.
That having been said, the amount of customers that come in through #Node.js has dropped in recent times, in favour of people finding me through different venues. While I'm still a bit iffy about the possible conflicts of interest, I'd be willing to consider taking on +o if the needed moderation coverage can't be obtained otherwise.
Thoughts on this are welcome.

@joepie91 I'm definitely still open to revisiting this offer if you feel it would be appropriate and we have support from other moderators.

It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.


Feature/make builder move noexcept

Builder move construct and move assign are now noexcept
Builder using an existing Buffer object can now be created without a heap allocation

Coverage increased (+6.5%) to 95.945% when pulling bd485a41335817143a7a21d47eba804ca3aa388e on feature/make-builder-move-noexcept into 4ed192b4c56f7f0d6f7da22041b20adf62b60a6d on master.

Obsoleted by https://github.com/arangodb/velocypack/pull/46


Move logs to the /logs folder

Currentlly logs are stored at /bin folder in the CLI...
it should move to /logs folder (next to the bin folder)
So we will have 4 folders : bin + logs + content + lib

Actually the execution log is stores where you run the executable from.
But I agree that we should have a dir for logs


fix(resolver): make sure package.json path is inside the resolved path

Current dependencies on/for this PR:

main

PR #1481   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 21, 4:24 AM: @Boshen merged this pull request with Graphite.


Clean up manifest.in

I'm sure I can make better use of recursive-include, ie recursive-include simple_deploy/management/commands *

Notes

Sources

https://packaging.python.org/en/latest/guides/using-manifest-in/
Creating a source distribution
Configuring setuptools using setup.cfg files

Changes

Simplified MANIFEST.in using recursive-include and global-exclude
Addressed warnings, by adding specific directories to setup.cfg -> [options] -> packages.

Wrapping up

[ ] Make a release, and test it.


imp: adonis - tighten scope of nan-checking; tests

This is a follow-up PR for https://github.com/qiime2/q2-diversity/pull/282
cc @collin-le & @nbokulich

This PR tightens up the NaN checking to only the columns used in the formula, rather than raising an error on any column, even if it isn't used.
This changeset also adds a few quick unit tests to exercise this behavior.

add an option to drop NaNs instead of failing?

I'm game - but how about we do it in a future dev cycle? I just wanted to wrap up @collin-le's work on this in time for the upcoming release next week.

Some tests are failing locally but this does not appear related to this PR.

Can you share some logs? I'm all green here.

but how about we do it in a future dev cycle?

👍 opening an issue momentarily...

Can you share some logs? I'm all green here.

I can share out of loop but the error is clearly unrelated, coming from core-metrics. I am going to go ahead and hit MERGE 🟢

I can share out of loop but the error is clearly unrelated, coming from core-metrics

There was a huge shuffle this summer related to q2-div-lib - you might need to refresh your dev env, in case you haven't in a while.


the same input produce different output

I infer with the prompt "you". And the output is different if i run multi times

Ho do you run the model? I run it with "you" multi times, output is the same.

python src/fiddler/infer.py --model "/VM/share/models/Mixtral-8x7V-v0.1/" --input you
first time:
 you
are
here
:
K
U
.
de
Fac
ult
ies
Fac
ulty
of
Human
ities
and
Social
Sciences
Department
second:
 you
are
here
:
K
U
.
de
Fac
ult
ies
and
Inst
itutes
Institute
for
Advanced
Study

my transformer version is 4.37.1 so i add a weight input at /miniconda3/envs/dsmii/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py line 767-770 like :
def forward(self, hidden_states,weight=1.0):
current_hidden_states = self.act_fn(self.w1(hidden_states)) * self.w3(hidden_states)
current_hidden_states = self.w2(current_hidden_states)
return current_hidden_states*weight
but i do not think this matter

I know the reason.
"inps.to("cpu",non_blocking=True)" is bad
non_blocking will make the cpu matmul directly start the computaion without waiting "inps" to be copied to cpu. Of course, if the copy is very faster, this may not happen. But i think some kind of "wait" is needed.

Hi @Eutenacity, thank you very much for figuring out the issue. That is actually a problem. I will fix it later.


Jest migration.

Hello !
Why do you need expect as a dependency ? Jest already uses expect I believe.

I don't like magically injected globals. I could omit that line and these tests would still pass, but I like to know where my assertion library is coming from.

Okok, that was just out of curiosity, thanks !


initial automated tests for spaces

What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested? If it is not, please explain why.
(Details)
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Stale. Closing. I am going to instead add E2E tests for spaces with the new cypress setup


PowerToys Run takes noticeably longer to open than Launchy does

Microsoft PowerToys version
0.64.1
Installation method
GitHub
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
Press Alt-Space to have PowerToys Run open up
✔ Expected Behavior
For PowerToys Run to open immediately.
❌ Actual Behavior
It takes a noticeably long amount of time for it to open. Like if I start typing immediately after pressing Alt-Space, it'll miss a few keystrokes.
Other Software
No response

Is this issue still relevant in v0.74.1? /needinfo

I can't recall it happening recently so I'm gonna go with no.


fix runner to emit start/end event

Description of the Change
Using mocha programmatically, the mocha runner doesn't emit start/end event correctly.
Because both events emitted before event listeners are registered. So, this change is fixed to emit events in event loop.
Alternate Designs
I have no idea.

Why should this be in core?
This is a bug.

Benefits
Users can get start/end event correctly.

Possible Drawbacks

Applicable issues
close #2753

Coverage increased (+0.05%) to 90.072% when pulling f00567c95d74a5edd5d577ef68be98e5262a12dd on outsideris:issue-2753 into 0d95e3f41a0859be4e7225541575e78b6d8926ee on mochajs:master.

@outsideris, issue #3569 may be implicating your PR. Can you confirm?


Client Allocation Request for: Textile

Client Allocation Questions
Core Information

Name: Textile
Website / Social Media: company is https://twitter.com/textileio on twitter, https://www.linkedin.com/company/textile.io/. my personal, andrewxhill
Region: North America
DataCap Requested: 9TiB
Addresses to be Notarized: f3rab4mhsr7f2gdg6ozgj44mtny6bhcy3rvlftc5xyki6t4hvhdkaji3ahfaid6fh2o3wff4yfrzag4lge2r2q
Notary Requested: Broz221

Ping @Broz221

Thanks for your application.
Please answer following questions:
What's your name? What's your duty in this company? Please give me your E-mail address and your brief introduction.
Please give me simple overview of your company. (Company scale, establish time, project, use case, etc.)
What's you/your company's contribution to Filecoin? (If exsit)
What kind of data do you want to store? And how much? How about copy right of data?
How many miners do you want to store data to? Which aspect will you inspect these miners?
Could please you introduce your past usage of cloud storage?

hey @Broz221 sorry about that, we got this request fulfilled already and I never closed this issue. we may have a new request soon. cheers


[Bug] downloaded vision zero widget on Safari appears empty

Describe the bug
The downloaded png of the vision zero widget from the app when browsing on safari shows a blank container. See screenshot.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://anyway-newsflash-infographics.web.app' on Safari browser.
Click the download icon on the vision zero widget
Open the downloaded png

Expected behavior
The widget should appear exactly as it does on the app
Screenshots

Environment
Browser: Safari (MacOS)
Environment: Local and Production

Not sure why this was happening but now it works as it should


Enum is being mapped with private member variable that cannot be ignored

I cannot seem to ignore the private "description" field from showing up in the generated Selma mapping class.
And, it is trying to access it like it's public for some reason:
   switch (in) {
        case ONE :  {
        ...
          break;
        }
        case TWO :  {
        ...
          break;
        }
        case THREE :  {
		...
          break;
        }
        case description :  {
		...
          break;
        }
      }

Any ideas?
Here is the enum (it matches for both the source and destination):
public enum NumberEnum {
	ONE("one"),
	TWO("two"),
	THREE("three");

	private String description;

	private NumberEnum(String description) {
		this.description = description;
	}

	public String getDescription() {
		return description;
	}
}

Hi it looks like a bug, Selma should definitely ignore this kind of members.
I'll have a deeper look on this quickly.
Thanks for the report.

Thanks for fixing this!  Will this only be available in the 1.0 release or before as well?

Winter and 1.0 is coming :)


Update README.md

Add hacktoberfest logo..

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

Hi @Brijesh1963. Welcome to LinksHub! :) This issue is already assigned to someone else and we don't accept spam pull requests, so I'm closing this pull request. In the future refer to our Contributing Guides to learn how to effectively contribute to the project! 😊


moment(arg).isAfter(some-date) returns true if arg is undefined regardless of the value of some-date

Describe the bug
moment(<var>).isAfter(date) returns true if var is undefined
To Reproduce
Steps to reproduce the behavior:
Run moment().isAfter(new Date().getDate()) or
moment(undefined).isAfter(new Date().getDate())
The argument to isAfter does not have any influence on the result.
Expected behavior
IMO in this specific case isAfter should return false.
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 83.0.4103.116

Moment-specific environment

The time zone setting of the machine the code is running on
UTC+01:00
The time and date at which the code was run
16/07/2020 12:51

Please run the following code in your environment and include the output:
console.log((new Date()).toString())
console.log((new Date()).toLocaleString())
console.log((new Date()).getTimezoneOffset())
console.log(navigator.userAgent)
console.log(moment.version)

Thu Jul 16 2020 12:48:48 GMT+0200 (Centraleuropæisk sommertid)
16.7.2020 12.48.48
-120
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36
2.10.6

That's an old version of moment. Date.prototype.getDate returns the day of the month which gets fed as a timestamp to moment which puts you back at Jan 1st 1970. Your clock is most likely to return a date after therefore that moment instance is indeed after that.
I tried moment().isAfter(), moment().isAfter(moment()) and moment().isAfter(moment(new Date())) and it seems to be working just fine, it returns false.

Thanks for MinusFour for answering the question.


NotFoundError: Resource worker/embedding_layer

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab
GPU model and memory: TPU

Describe the current behavior
When i try to call fit on a character level LSTM based model I get following error NotFoundError: Resource worker/embedding_layer/embeddings/N10tensorflow3VarE does not exist. 	 [[{{node embedding_layer/embedding_lookup}}]]
Describe the expected behavior
If I run the exact same model on a GPU, everything works as expected (eg. the model trains).
Code to reproduce the issue
I am following the official google guides as to how train a keras model on tpu using the tensorflow contrib keras to tpu model function
Other info / logs
---------------------------------------------------------------------------
NotFoundError                             Traceback (most recent call last)
<ipython-input-32-fff2e852201f> in <module>()
----> 1 model.fit(X,y,epochs=1,validation_split=0.1,batch_size=batch_size)#,callbacks=callbacks)

4 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/errors_impl.py in __exit__(self, type_arg, value_arg, traceback_arg)
    526             None, None,
    527             compat.as_text(c_api.TF_Message(self.status.status)),
--> 528             c_api.TF_GetCode(self.status.status))
    529     # Delete the underlying status object from memory otherwise it stays alive
    530     # as there is a reference to status from this from the traceback due to

NotFoundError: Resource worker/embedding_layer/embeddings/N10tensorflow3VarE does not exist.
	 [[{{node embedding_layer/embedding_lookup}}]]```

@sarim-zafar Could you provide the minimum code snippet to reproduce the issue reported here. Thanks!

@sarim-zafar Could you provide the minimum code snippet to reproduce the issue reported here. Thanks!

# define LSTM input_layer = Input(       name='seed', shape=(longest,), batch_size=batch_size, dtype=tf.int32) l0=Embedding(input_dim=max_token_index+1,output_dim=d,name='embedding_layer',mask_zero=True)(input_layer) l1=GRU(128, return_sequences=True,dropout=0.2)(l0) l2=GRU(128, return_sequences=True,dropout=0.2)(l1) l3=GRU(128, return_sequences=True,dropout=0.2)(l2) output=GRU(max_token_index+1,return_sequences=False, activation='softmax',dropout=0.2)(l3) model = tf.keras.Model(inputs=[input_layer], outputs=[output])


Moved DatabaseIntrospection.get_table_description() internal_size release note to "Database backend API" section.

(I encountered this while working on the Snowflake backend.)

@timgraham Thanks :+1:


Provide a "future discounted reward" view of current episode

i.e. to basically see what the effect will be of different discount factors like 0.9  0.95  0.99  0.995   0.999  etc.

basic done in v3, remaining features being added now


documentations: new flags in --insecure-options

Following https://github.com/coreos/rkt/pull/2983, there are new flags in --insecure-options
/cc @lucab @iaguis

lookz good to me

docs only, skipping CI


formalize grammar of "Value syntax"

normalize tokens
document delimiters and grammar

Deduplication of MIXS ID and Value syntax columns
from MIxS6 packages - Final_clean sheet

964 duplicate rows found and removed
791 unique rows remain

Then

remove MIXS ID column
add all Value syntax rows from MIxS6 Core- Final_clean sheet

Then pivot to tabulate => static value syntax tabulation

Next

parse out {}-wrapped tokens
highlight problematic hybrid Value syntaxes, especially enumerations+


Improve search form component

improvements

tomorrow as a default date
no longer possible to set an empty (=invalid) date
fixed Legs (keys in the list)
search button added
added link to the booking after clicking on "buy"

Suggested further changes

From & To are empty by default
Handle autocomplete onChange event instead of onSelect - writing into input has no effect

great!
could you elaborate more on your suggestions?

why do you think it is better to remove values?(on kiwi.com there are defaults too)
autocomplete is not handled by onSelect it is handled by component itself (filterOption bool), so I really see no reason for adding onChange logic.

ad 2) Autocomplete has 3 handlers - onSearch, onChange and onSelect, we handle on onSelect, which means nothing happens when typing into inputs, which is quite confusing


💡 [REQUEST] - remove console.debug react-ipynb-renderer is working

Summary
I'm trying to declutter the output from jest as much as possible, mostly from failed prop-type checks.
This call to console.debug is one of those things that clutters my workflow. What's the best way to disable it?
Reference Issues
No response
Basic Example
_
Drawbacks
_
Unresolved questions
No response

Removed debug output in v.2.2.2.
Please check if it is as expected.

@KJSanchez Did it work as expected?
If it works fine, please close the Issue.


refactor(statsd): refactor workspace id and name retrieval

use the workspace created by default to avoid querying the database for workspace ID and name with every request.

Summary

Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference

Fix FTI-5303

@sabertobihwy pls check the comments above.

Hi @hanshuebner, I submitted a corresponding PR to EE: https://github.com/Kong/kong-ee/pull/6375
NOTE: https://github.com/Kong/kong-ee/pull/6375 will not be merged. After this PR is merged(#11442), when cherry picking this PR to EE, it will be modified according to https://github.com/Kong/kong-ee/pull/6375, so https://github.com/Kong/kong-ee/pull/6375 is only used to demonstrate the ideas and details.

This PR is simple, an existing test case can be considered as already covered: https://github.com/Kong/kong/blob/d4d547d5e0f2ce5c270cde5bef50d58740be450a/spec/03-plugins/06-statsd/01-log_spec.lua#L1491-L1507

Please fix the PR description.

@vm-001 are your changes addressed on this PR?

@vm-001 are your changes addressed on this PR?

Yes. So, approved.

@sabertobihwy please cherry-pick the change into kong-ee


Correct mistakes in readme

Nice work - I'm going to close this PR so others can complete the assignment


[Feature] 希望 ListTable 可以增加配置 rowHierarchyTextStartAlignment

What problem does this feature solve?
同层级的结点是否按文字对齐 如没有收起展开图标的节点和有图标的节点文字对齐 默认 false
What does the proposed API look like?
同层级的结点是否按文字对齐 如没有收起展开图标的节点和有图标的节点文字对齐 默认 false

感谢你的反馈！我们已经收到你的问题，并将在后续进行处理。
如果有开发者对这个 issue 感兴趣，请在issue下方留言“认领该issue”，留言后开始你的创作提pr给我们！
欢迎大家参与开源共建！我们非常感激每一位贡献者，提交pr后我们将为参与共建的开发者准备一份礼品。
参与共建可参考：https://visactor.io/vtable/guide/Contribution_Guide
与官方开发者交流问题可以下载飞书app扫码加入飞书群：

再次感谢你的支持！
Thank you for your feedback! We have received your question and will deal with it later.
If any developer is interested in this issue, please leave a message "claim this issue" below the issue. Welcome to participate in open source co-construction!
We are very grateful to every contributor. After submitting the PR, we will prepare a gift for the developers who participated in the co-construction.
For participation in co-construction, please refer to: https://visactor.io/vtable/guide/Contribution_Guide
To communicate with official developers, you can download the Feishu app and scan the QR code to join the Feishu group！
Thank you again for your support!


Error in "tasks/proxy.js"

Hi,
There is an error in the file "tasks/proxy.js", line 91: the method " grunt.verbose.log(err); " does not exist. This should be replaced with something like " grunt.verbose.writeln(err); "
                   var req = request.post(url+name, function (err, resp, body) {
                      if (err) {
                        grunt.verbose.log(err);
                      } else {

Unsure if still needed, but I submitted a PR #17 to resolve the issue.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ecamoleong sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Kestral is very slow when posting data

Please get the sample source from  https://github.com/cibinmathewjose/KestrelPostIssue.git
run the code and post {"Name":"test","Price":1} to http://{machine}:5000/api/products, it will take ~6 seconds.
if you post {"Price":1} to http://{machine}:5000/api/products it will work normally.
The put request endpoint is always slow with machine name url, regardless of the data posted.
Also if you use localhost instead of machine name in url, it will always works normal.
this is the same issue as #2229

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Add Flux Common Query Example: Query by Business Hours

We have a number of outstanding requests where users would like to query InfluxDB based on peak business hours for a given date range.  We should provide an example of doing this within the common query examples in the documentation.

https://docs.influxdata.com/influxdb/v2.0/reference/flux/stdlib/built-in/transformations/hourselection/
Add into Common queries using language like "Filter data by business hours".


Add tests for aggregator functions (meant for AttributeTables, but stored in Attribute classes)

Codecov Report

Merging #268 (51dfafc) into master (5b25930) will increase coverage by 1.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
+ Coverage     68.65%   70.35%   +1.69%
- Complexity      569      578       +9
============================================
  Files            98       98
  Lines          2125     2125
  Branches        171      171
============================================
+ Hits           1459     1495      +36
+ Misses          575      542      -33
+ Partials         91       88       -3

Impacted Files
Coverage Δ

src/main/java/donnafin/ui/AttributeTable.java
97.82% <ø> (ø)

src/main/java/donnafin/model/person/Policy.java
84.90% <0.00%> (+22.64%)
:arrow_up:

src/main/java/donnafin/model/person/Asset.java
85.41% <0.00%> (+24.99%)
:arrow_up:

src/main/java/donnafin/model/person/Liability.java
85.41% <0.00%> (+24.99%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b25930...51dfafc. Read the comment docs.

Nice catch! 🤦


go build error

i use shell script to go build, but i failed
GOOS=linux GOARCH=386 go build && mv proxyWebApplication proxyWeb/proxyWebApplication && tar zcfv "zip/proxy-linux-386.tar.gz" proxyWeb
why?
this is error information
../github.com/mattn/go-sqlite3/sqlite3_go18.go:26: undefined: SQLiteConn ../github.com/mattn/go-sqlite3/sqlite3_go18.go:27: undefined: namedValue

my os is linux-amd64, only linux-amd64 can go build

Because you don't install cross C compiler for linux-i386.

Similar issue. Trying to compile for linux/x86_84 on my mac. Code will run on my hosting provider which doesn't have gcc installed. So I need to compile on my mac for use on linux.
$ GOOS=linux GOARCH=amd64 go build --tags "libsqlite3 linux"
# github.com/mattn/go-sqlite3
../github.com/mattn/go-sqlite3/sqlite3_go18.go:18:10: undefined: SQLiteConn

You must install cross C compiler for Linux on your Mac.

Any hints on installing that?

thanks

@utdrmac I don't have Mac. Sorry.

@utdrmac Were able to compile linux binary on mac?

Nope. I just booted up a VirtualBox with the same OS as my hosting provider, installed go, etc, compiled, copied. works well. Took about 10m to download/install a CentOS6 VM. Another 10m to install/setup Go. Would have spent a lot longer figuring out cross-compile stuff.

Same problem here. I can not cross compile this library for linux/amd64 now.

Do you use cross C compiler? Maybe you are using host compiler. Check CC in go env.

@mattn Yes I was using the host compiler, it was the cause. So I installed the cross compiler for linux on mac: http://crossgcc.rts-software.org/doku.php?id=compiling_for_linux and ran the build command, the results was successful. (Of course, I did not run this output binary on linux instance yet)
Thanks you.
@utdrmac I solved the cross compilation problem on mac with gcc for linux for mac

@mingrammer do you have gcc for linux for windows

@yincongcyincong I did not found one for windows. You should find it yourself .. sorry.

@yincongcyincong I did not found one for windows. You should search it yourself, sorry.

Does anyone have the correct incantation (or value for CC) to use the "cross compiler" on mac? I have gcc installed via brew but can't figure it out so I'm still getting this error, we could then improve the documentation by listing the actual steps required! The url in the page earlier linked is now extinct so it's of no use.

@utdrmac @mingrammer could you please write an update for the compilation section for MAC within the README. Hope you can take some time for it. I think it will help a lot of people. Don't have Mac myself.

@GJRTimmer Sorry, I gave up on using SQLite3 in my project because this was too complicated to cross-compile for each OS. I switched to https://github.com/coreos/bbolt in my project which is 100% Go and allows me to compile for each os/arch on my mac.

For those having this issue on linux (especially if you're using Ubuntu), please do the following:
$ sudo apt-get install gcc-mingw-w64

The above command will install cross compiler for C. Then you can build with the following code:
To build for windows amd64:
GOOS=windows GOARCH=amd64 CC=x86_64-w64-mingw32-gcc CGO_ENABLED=1 go build -o binary_name_amd64.exe .

Similarly for windows 386:
GOOS=windows GOARCH=386 CC=i686-w64-mingw32-gcc CGO_ENABLED=1 go build -o binary_name_386.exe .

Hope this helps.

here new problem is "i686-w64-mingw32-gcc: error: CreateProcess: No such file or directory", how to resolve?

I have this bug:

#17 29.00 # github.com/mattn/go-sqlite3
#17 29.00 sqlite3-binding.c:35901:42: error: 'pread64' undeclared here (not in a function); did you mean 'pread'?
#17 29.00 35901 |   { "pread64",      (sqlite3_syscall_ptr)pread64,    0  },
#17 29.00       |                                          ^~~~~~~
#17 29.00       |                                          pread
#17 29.00 sqlite3-binding.c:35919:42: error: 'pwrite64' undeclared here (not in a function); did you mean 'pwrite'?
#17 29.00 35919 |   { "pwrite64",     (sqlite3_syscall_ptr)pwrite64,   0  },
#17 29.00       |                                          ^~~~~~~~
#17 29.00       |                                          pwrite
#17 29.00 sqlite3-binding.c: In function 'seekAndRead':
#17 29.00 sqlite3-binding.c:35905:49: error: unknown type name 'off64_t'; did you mean 'off_t'?
#17 29.00 35905 | #define osPread64 ((ssize_t(*)(int,void*,size_t,off64_t))aSyscall[10].pCurrent)
#17 29.00       |                                                 ^~~~~~~
#17 29.00 sqlite3-binding.c:38767:11: note: in expansion of macro 'osPread64'
#17 29.00 38767 |     got = osPread64(id->h, pBuf, cnt, offset);
#17 29.00       |           ^~~~~~~~~
#17 29.00 sqlite3-binding.c:35905:58: error: expected ')' before 'aSyscall'
#17 29.00 35905 | #define osPread64 ((ssize_t(*)(int,void*,size_t,off64_t))aSyscall[10].pCurrent)
#17 29.00       |                   ~                                      ^~~~~~~~
#17 29.00 sqlite3-binding.c:38767:11: note: in expansion of macro 'osPread64'
#17 29.00 38767 |     got = osPread64(id->h, pBuf, cnt, offset);
#17 29.00       |           ^~~~~~~~~
#17 29.00 sqlite3-binding.c: In function 'seekAndWriteFd':
#17 29.00 sqlite3-binding.c:35923:57: error: unknown type name 'off64_t'; did you mean 'off_t'?
#17 29.00 35923 | #define osPwrite64  ((ssize_t(*)(int,const void*,size_t,off64_t))\
#17 29.00       |                                                         ^~~~~~~
#17 29.00 sqlite3-binding.c:38896:17: note: in expansion of macro 'osPwrite64'
#17 29.00 38896 |   do{ rc = (int)osPwrite64(fd, pBuf, nBuf, iOff);}while( rc<0 && errno==EINTR);
#17 29.00       |                 ^~~~~~~~~~
#17 29.00 sqlite3-binding.c:35924:21: error: expected ')' before 'aSyscall'
#17 29.00 35924 |                     aSyscall[13].pCurrent)
#17 29.00       |                     ^~~~~~~~
#17 29.00 sqlite3-binding.c:38896:17: note: in expansion of macro 'osPwrite64'
#17 29.00 38896 |   do{ rc = (int)osPwrite64(fd, pBuf, nBuf, iOff);}while( rc<0 && errno==EINTR);
#17 29.00       |                 ^~~~~~~~~~
#17 29.00 sqlite3-binding.c:[359](https://github.com/iesitalia/image-proxy/actions/runs/11372536680/job/31637080124#step:7:364)23:21: note: to match this '('
#17 29.00 35923 | #define osPwrite64  ((ssize_t(*)(int,const void*,size_t,off64_t))\
#17 29.00       |                     ^
#17 29.00 sqlite3-binding.c:38896:17: note: in expansion of macro 'osPwrite64'
#17 29.00 38896 |   do{ rc = (int)osPwrite64(fd, pBuf, nBuf, iOff);}while( rc<0 && errno==EINTR);
#17 29.00       |                 ^~~~~~~~~~
#17 ERROR: process "/bin/sh -c GO111MODULE=on CGO_ENABLED=1 GO_CFLAGS=\"-D_LARGEFILE64_SOURCE\" GOOS=linux GOARCH=amd64 go build -ldflags=\"-s -w\" -o imageproxy ./main.go" did not complete successfully: exit code: 1
------
 > [builder 7/7] RUN GO111MODULE=on CGO_ENABLED=1 GO_CFLAGS="-D_LARGEFILE64_SOURCE" GOOS=linux GOARCH=amd64 go build -ldflags="-s -w" -o imageproxy ./main.go:
29.00       |                     ^~~~~~~~
29.00 sqlite3-binding.c:38896:17: note: in expansion of macro 'osPwrite64'
29.00 38896 |   do{ rc = (int)osPwrite64(fd, pBuf, nBuf, iOff);}while( rc<0 && errno==EINTR);
29.00       |                 ^~~~~~~~~~
29.00 sqlite3-binding.c:35923:21: note: to match this '('
29.00 35923 | #define osPwrite64  ((ssize_t(*)(int,const void*,size_t,off64_t))\
29.00       |                     ^
29.00 sqlite3-binding.c:38896:17: note: in expansion of macro 'osPwrite64'
29.00 38896 |   do{ rc = (int)osPwrite64(fd, pBuf, nBuf, iOff);}while( rc<0 && errno==EINTR);
29.00       |                 ^~~~~~~~~~
------


fix(Android): upgrade react-native-vision-camera v4

Fix Android support for react-native-vision-camera release v4.0.0

changelog

[!CAUTION]
This will break in react-native-vision releases before v4.0.0

Upgrade
Dependencies
    "react-native-vision-camera": "3.9.1",
    "react-native-worklets-core": "0.4.0",

    "react-native-vision-camera": "^4.0.1",
    "react-native-worklets-core": "^1.1.1",

Fix
com.mrousavy.camera.frameprocessor imports
import com.mrousavy.camera.frameprocessor.Frame
import com.mrousavy.camera.frameprocessor.FrameProcessorPlugin
import com.mrousavy.camera.frameprocessor.VisionCameraProxy

import com.mrousavy.camera.frameprocessors.Frame
import com.mrousavy.camera.frameprocessors.FrameProcessorPlugin
import com.mrousavy.camera.frameprocessors.VisionCameraProxy

toDegrees() method
orientation.toDegrees() was removed in v4
val image = InputImage.fromMediaImage(mediaImage, orientation.toDegrees())

val image = InputImage.fromMediaImage(mediaImage, frame.imageProxy.imageInfo.rotationDegrees)

type FrameProcessor
type FrameProcessor was replaced with ReadonlyFrameProcessor

@pedrol2b Hey ! Thanks for helping. I'll test it if all Ok than I merge your request.

@pedrol2b Hey ! Thanks for helping. I'll test it if all Ok than I merge your request.

I updated it only for Android, but I did not test on iOS yet


Release 0.0.6

Update selector
Cleanup extra spaces
Update name in package.json
Add changelog note

Fixes https://github.com/nik9play/BetterDiscordPlugins/issues/1

@nik9play I've been using this for a while, and it works perfectly. Please merge.

sorry for the wait, i was busy


No XML comments in Visual Studio

Maybe <GenerateDocumentationFile> property could fix this?

The documentation files are in the package already:

Are you still seeing this?

Oh yes, you're right. On the class itself and other methods it works just fine.
And if I copy the method into my own code then the XML comment also shows up. Not on the nuget though.


Zuul and X-Forwarded-For

Should Zuul support X-Forwarded-For out of the box? Just like it sets X-Forwarded-Host

Sounds like a reasonable idea (obviously checking first if the header is already set and not setting it in that case).

At present it seems the X-Forwarded-For headers that are passed into a typical @EnableZuulProxy @SpringBootApplication are stripped from the requests: https://gist.github.com/timtebeek/7aa8f6fc1b8c014c6e4a
(using spring-cloud-starter-zuul:Angel-SR3)

curl -v -H 'X-Real-IP: <IP_ADDRESS>' -H 'X-Forwarded-For: <IP_ADDRESS>' http://apache.proxied.zuul.instance/manage/trace

This makes it impossible for me to access the value in any downstream backend services, as needed for some auth-logic.
What changes would I have to make to at least retain the X-Forwarded-For headers that are passed in?

Probably some additional logic in ProxyRequestHelper is all that is needed.

For now I've setup a minimal ZuulFilter:
	public Object run() {
		RequestContext ctx = RequestContext.getCurrentContext();
		// Rely on HttpServletRequest to retrieve the correct remote address from upstream X-Forwarded-For header
		HttpServletRequest request = ctx.getRequest();
		String remoteAddr = request.getRemoteAddr();
		// Pass remote address downstream by setting X-Forwarded for header again on Zuul request
		log.debug("X-Forwarded-For set to: {}", remoteAddr);
		ctx.getZuulRequestHeaders().put(X_FORWARDED_FOR, remoteAddr);
		return null;
	}

That works, but it seems such a common case to me that might warrant better handling. :)

Were you going to send a pull request then?

Hadn't thought about it yet, as I thought the handling might need to be extended a bit to conform to the behavior seen in other proxies, such as appending a new value for X-Forwarded-For rather than merely sending the old value. Didn't yet think I'd get that right the first time in a pull request.

Fair enough. I think the default should be what you did (replace the existing one), and we can add a boolean flag option to append as well.

How does this tie into Spring Boot 1.3 X-Forwarded header support?

That's related to the backend, so I don't think there is any tie in really.

Our Zuul PreDecorationFilter already sends x-forwarded-* headers by default. I don't think there's anything else to do here.

@dsyer It's true that some X-Forwarded- headers are now set, but X-Forwarded-For appears not to be set still: https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/pre/PreDecorationFilter.java

OK, I guess we are still waiting for a pull request then. Maybe we should append rather than replace though, by default?

@dsyer Please have a look at #952

Fixed via #952


RDK-37173: Fix occasional lack of focus

fixes occasional lack of focus leading to UI lacking hover etc. in apps such as STV or Discovery+

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Pawel Lampe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @modeveci, could you please take a look?


[WIP] Add BCH Support

Hi, this PR is intended to track the progress of bitcoincash integration into BasicSwap DEX, I'd appreciate you reviewing it and helping me navigate through the integration process.
As BCH is not a segwit coin, it can not be simply plugged into the existing protocol, like for example LTC. BCH-XMR swaps follow their own protocol, see https://gitlab.com/0353F40E/cross-chain-swap-ves. It employs a creating a swaplock smart contract which is a covenant to restrict spending to two paths - refund and swap. Swap path requires the OT-VES signature for XMR side to construct the spending key. More details in the link above. My work so far already contains the code required to construct the smart contract and spend it, so I am working further on building blocks required to implement the protocol in BSX.
Thanks in advance.

This week's activities were to continue evolving BCH interface to be compatible with XMR_SWAP protocol, (re-)implementing the segwit script and transaction building on a BCH non-segwit chain. In addition I have done some investigation and BCH seems to be a viable swap pair (follower) for segwit coins too if treated as an unscriptable coin.

This week's report features progress on further work towards implementing the BCH swap interface. Major achievement is the happy path (lock-spend) BCH-XMR swap completion, yay! More work is needed on three other paths:

lock-refund
lock-refund-spend
lock-refund-refund

These will be easier to implement as most fundamentals are already in place.

I have done some investigation and BCH seems to be a viable swap pair (follower) for segwit coins too, if treated as an unscriptable coin.

Why does it need to be treated as unscriptable? "classic" HTLC works just fine with BCH, too.
Because BCH has relatively much cheaper fees, maybe BCH could be the "lead" and BTC side treated as if unscriptable to reduce on-chain footprint, in which case you'd use the same BCH-XMR contract and adaptor sig (but no need dleq since it is same curve).

Why does it need to be treated as unscriptable? "classic" HTLC works just fine with BCH, too.
Because BCH has relatively much cheaper fees, maybe BCH could be the "lead" and BTC side treated as if unscriptable to reduce on-chain footprint, in which case you'd use the same BCH-XMR contract and adaptor sig (but no need dleq since it is same curve).

This is a great question, but it shifts this PR into another plane of discussion. My primary goal is to implement BCH-XMR swaps here

Hey guys, I am happy to drop the [WIP] tag from this PR. I have rigorously tested my changes and changed some gui code to display the BCH asset info correctly. Please check and verify.
This concludes my involvement as discussed with ofrnxmr. But I'd try to find more time if any issues are found.


add support for languages

closing this, as this task isn't assinged to me.
It was just a test-implementation. Feel free to reopen when needed


Error occurred when executing KSampler:  0

Can't figure out what this question means

It's an error you're getting within Advanced-ControlNet, not AnimateDiff-Evolved. Looking at the line number you have, you are not on the most recent Advanced-ControlNet version. With recent ComfyUI changes, Advanced-ControlNet has to be updated to the most recent to work with the most recent versions of ComfyUI - that could be where your issue comes from.
I'd recommend updating both your ComfyUI and Advanced-ControlNet.

I have manually confirmed that this is indeed what happens if your Advanced-ControlNet version is outdated compared to the recent ComfyUI changes. Simpy update Advanced-ControlNet. If that doesn't fix it, it means your Advanced-ControlNet didn't update.
https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/issues/124


updates search field size on load and on key enter

This pull request fixes the following issues:

search field should be focused on load but small
on keydown field should resize to bigger field same as on focus

:+1:


Characters count

Could you please display on the status bar the characters count of the selected word ?

Ok.
That's easy to do

Thank you very much! 👍


How about multiple cameras?

Thank you very much for your code. May I ask how to modify the code for multiple cameras with multiple k?

@chl2 Hi, you could modify the provider.py and load different camera intrinsics for each image.


Inline Method refactoring should update imports

When a method from another library is inlined, it's possible that the body of the method references elements that are not visible yet in the target library. Would be nice to update imports.

I think @DanTup and/or @bwilkerson did a lot of work to add the right import directives when extracting a class to a new file; can that be applied here for method inlining?

The code probably wasn't written with re-use in mind, but yes, the problem is very similar and there's almost certainly some common implementation that could be extracted.


[Backport 2.x] Skip performOnPrimary step when executing PublishCheckpoint. (#6366)

Manual backport of https://github.com/opensearch-project/OpenSearch/pull/6366 to 2.x.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #6397 (9cf2da3) into 2.x (daec8fb) will increase coverage by 0.02%.
The diff coverage is 5.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #6397      +/-   ##
============================================
+ Coverage     70.48%   70.50%   +0.02%
+ Complexity    59278    59273       -5
============================================
  Files          4795     4795
  Lines        284137   284143       +6
  Branches      41311    41313       +2
============================================
+ Hits         200262   200340      +78
+ Misses        67176    67077      -99
- Partials      16699    16726      +27

Impacted Files
Coverage Δ

...eplication/checkpoint/PublishCheckpointAction.java
23.43% <5.88%> (-4.15%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

...opensearch/persistent/PersistentTasksExecutor.java
22.22% <0.00%> (-40.75%)
:arrow_down:

...a/org/opensearch/monitor/process/ProcessStats.java
34.92% <0.00%> (-39.69%)
:arrow_down:

...cluster/coordination/PublishClusterStateStats.java
33.33% <0.00%> (-37.51%)
:arrow_down:

...arch/search/aggregations/pipeline/LinearModel.java
23.07% <0.00%> (-34.62%)
:arrow_down:

...nsearch/index/shard/IndexShardClosedException.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...earch/client/indices/GetIndexTemplatesRequest.java
53.84% <0.00%> (-30.77%)
:arrow_down:

...pensearch/client/core/MultiTermVectorsRequest.java
41.17% <0.00%> (-29.42%)
:arrow_down:

... and 452 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Convert JB to Article

Using the jb-article syntax doesnt seem to work. I have combined the ipynbs for now, and we are trying to figure out the solution.

TIff helped identify a new feature in jb that helped:
jupyter-book build MY_BOOK --builder singlehtml


Added Meme Share App (issue #244)

You can merge as I removed all the remaining. Only meme share is there.

The best solution would be close the initial pull request and then add in first the Meme Share app to the repository and commit and then commit other files. I hope this is clear, if needed some more help ping me here again.

The best solution would be close the initial pull request and then add in first the Meme Share app to the repository and commit and then commit other files. I hope this is clear, if needed some more help ping me here again.

ok, I will do it now. Please check it and merge it as possible as you can.


Update comments in latch-based register file

This commit updates the comments inside the latch-based register file. Some of them were outdated or just wrong.

This PR superseedes lowRISC/ibex#271.


[Bug]AIPC RAG does NOT work

Priority
Undecided
OS type
Ubuntu
Hardware type
AI-PC (Please let us know in description)
Installation method

[X] Pull docker images from hub.docker.com
[ ] Build docker images from source

Deploy method

[X] Docker compose
[ ] Docker
[ ] Kubernetes
[ ] Helm

Running nodes
Single Node
What's the version?
OPEA v1.0
With the fix https://github.com/opea-project/GenAIExamples/pull/933
Upload test file and ask questions, got unexpected result
AIPC:

Result on Xeon:

Description
APIC RAG does NOT work
Reproduce steps
Upload PDF file and ask questions from the file, the answer does not from the upload PDF file.
Raw log
No response

Fixed by PR#795


error

What version of Music Assistant has the issue?
2023.12.3
The problem
I have such a log at the start.  MA does not work at all, more precisely, there is no way to select a player.
2023-12-18 04:40:51.084 ERROR (MainThread) [asyncio] Task exception was never retrieved
future: <Task finished name='Task-1' coro=<run..new_coro() done, defined at /usr/local/lib/python3.11/site-packages/aiorun.py:209> exception=OperationalError('duplicate column name: external_ids')>
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiorun.py", line 219, in new_coro
await coro
File "/usr/local/lib/python3.11/site-packages/music_assistant/main.py", line 174, in start_mass
await mass.start()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/server.py", line 139, in start
await self.music.setup(await self.config.get_core_config("music"))
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/music.py", line 106, in setup
await self._setup_database()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/music.py", line 665, in _setup_database
await self.database.execute(
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/helpers/database.py", line 151, in execute
return await self._db.execute(query, values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 190, in execute
cursor = await self._execute(self._conn.execute, sql, parameters)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 133, in _execute
return await future
^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 106, in run
result = function()
^^^^^^^^^^
sqlite3.OperationalError: duplicate column name: external_ids
How to reproduce
start MA - error
Relevant log output
2023-12-18 04:40:51.084 ERROR (MainThread) [asyncio] Task exception was never retrieved
future: <Task finished name='Task-1' coro=<run..new_coro() done, defined at /usr/local/lib/python3.11/site-packages/aiorun.py:209> exception=OperationalError('duplicate column name: external_ids')>
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiorun.py", line 219, in new_coro
await coro
File "/usr/local/lib/python3.11/site-packages/music_assistant/main.py", line 174, in start_mass
await mass.start()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/server.py", line 139, in start
await self.music.setup(await self.config.get_core_config("music"))
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/music.py", line 106, in setup
await self._setup_database()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/music.py", line 665, in _setup_database
await self.database.execute(
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/helpers/database.py", line 151, in execute
return await self._db.execute(query, values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 190, in execute
cursor = await self._execute(self._conn.execute, sql, parameters)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 133, in _execute
return await future
^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiosqlite/core.py", line 106, in run
result = function()
^^^^^^^^^^
sqlite3.OperationalError: duplicate column name: external_ids
Additional information
No response
What version of Home Assistant Core are your running
2023.12.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

OK it looks like you have tried to upgrade between unsupported versions. If you can roll back to b75 via a backup then upgrade straight to b78. If you can't then you are going to have to remove and reinstall the addon


Update constants.js

Kind of broken when you can't change the threshold when you host it since you can't access the modules on some common hosting sites like repl.it and heroku

Hey, I don't understand the problem you're talking about, can you clarify a bit?
Also, I want to keep the default value of threshold at 1 because otherwise some users have the impression that the module doesn't work when there is just not enough reaction. That's why it's an option ;)

Closed due to inactivity


Filtering subitems to avoid duplicates

Filtering all the nav items to avoid duplicate references, that caused errors in console.
The error:
Warning: Encountered two children with the same key, `content/colors/foreground.json`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution @karelnagel - I'm surprised there were two items with the same form id though. Do you have a specific query where you notice this ocurring?

@karelnagel Can you provide a reproduction of this error? (PR looks good but we would like to see how the issue occurred before it is merged )


Update README.md and Contributor section #82

Description
This PR updates the README file to improve clarity and provide detailed instructions for contributors.
-This PR does the following:
-Adds a section for contributing guidelines.
-Fixes outdated information regarding the installation process.
-Updates the contact information and links to related resources.
Related Issues

Placeholder: "Fixes #82"

Changes
List the detailed changes made in this PR.
-Added a new section outlining how to contribute to the project.
-Refactored the installation instructions for better clarity and accuracy.
-Fixed the outdated links to resources and contact information.
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

Pull this branch.
Run npm install to install dependencies.
Run npm test to execute the test suite.
Verify that all links are functional and direct to the correct resources.

Screenshots (if applicable)

Additional Context

This PR is based on feedback from the community and aims to enhance the onboarding experience for new contributors.

Checklist

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

Please assign this under gssoc-extd, hactoberfest and hactoberfest-accepted. Thank you! @Soujanya2004


chore: remove console statements from dist files

Description

remove console statements from dist files

Note: merging this might break yarn.lock again. we had this issue for revenuehero/headlessui @jartek


4.27 Support

Are you going to be adding 4.27 support?

Just added support for 4.27. check the drive for the packaged binaries.


[FEATURE] No option for xenstoredata

Although the XAPI supports xenstoredata there is no such option in the provider for VMs. Request add option like:
resource "xenorchestra_vm" VM" {
affinity_host = data.xenorchestra_host.host.id
count         = length(var.ip)
cpus          = 2
disk {
attached   = true
name_label = VM${count.index + 1}-Disk0"
size       =<PHONE_NUMBER>0
sr_id      = data.xenorchestra_sr.local_storage.id
}
template         = data.xenorchestra_template.mytemplate.id
exp_nested_hvm   = false
memory_max       =<PHONE_NUMBER>
name_description = "Virtual Appliance"
name_label       = "VM${count.index + 1}"
network {
attached = true
#              device = 0
network_id = data.xenorchestra_network.MyNet.id
}
cdrom {
id = resource.xenorchestra_vdi.iso[count.index].id
}
vga      = "cirrus"
videoram = 4
xenstoredata = {
"vm-data/whatever" = "Testdata"
}
}

@ddelnano I have an attempt at this in my fork currently, but my knowledge of the API we are hitting on the xenorchestra server is limited, So I am not actually entirely sure where to look up the format in that source code. Perhaps you know?

@ravager-dk the API is self describing with the xo-cli. If you run xo-cli --list-commands you will see most of the arguments exposed.
ddelnano@ddelnano-desktop:~$ xo-cli --list-commands | grep vm.create
vm.create [affinityHost=<string>] [bootAfterCreate=<boolean>] [cloudConfig=<string>] [networkConfig=<string>] [coreOs=<boolean>] [clone=<boolean>] [coresPerSocket=<string|number>] [resourceSet=<string>] [destroyCloudConfigVdiAfterBoot=<boolean>] [installation=<object>] [vgpuType=<string>] [gpuGroup=<string>] name_label=<string> [name_description=<string>] [pv_args=<string>] [share=<boolean>] template=<string> [VIFs=<array>] [VDIs=<array>] [existingDisks=<object>] [hvmBootFirmware=<string>] [copyHostBiosStrings=<boolean>] *=<unknown type>

Xenstoredata is not part of that today, so that would need to be a feature request for the vatesfr/xen-orchestra project.

@ddelnano thanks for the info. I had not seen that xo-cli could be used to gather the API info. I was looking through the xen-orchestra source and found several references to xenstoredata in there, so I assumed it was OK.
The problem I have is that when deploying Netscaler VPX's the only supported way to auto provision the IP information is via xenstoredata - https://support.citrix.com/article/CTX128236/how-to-autoprovision-netscaler-vpx-on-xenserver
My only other option is to switch to the xenserver provider instead, which has this option communicating directly with the xenserver. I would however prefer some degree of feature parity between xenorchestra and xenserver. I don't need it in the UI of xenorchestra, just in the API.

This depends a bit on the strategy of #263. Xenstore data for Netscaler VMs does not take effect if the VM is running. There are several ways to implement it.
One strategy would be to not set start the VM on creation if xenstore data param is set, then do a VM.set and then VM.start.

@ravager-dk this functionality will be available in v0.28.0. I'll be making that release tomorrow once our main build's nightly job succeeds

v0.28.0 is now available.

Finally had a chance to verify it today. It works like a charm.
Good job @ddelnano

Thanks for letting me know it suits your needs and is working!


Greenkeeping

Upgrading Thoas to version 1.2 and raising the minimum required version of the Gleam standard library to match Gleam's release version 0.32

Hello! Thank you, but this does not update the versions as the upper bound of the constrains have not changed. Nothing needs to be done to ensure that users get the latest versions here.

Except that you have a conflict when you want to use the latest version of thaos 1.2.0 and json at the same time :-)