Fix flexvolume cleanup on "RemoveContainer"

Relates to https://github.com/Mirantis/virtlet/pull/336
Patch adds call of volume cleanup on StopContainer as by the time of RemoveContainer kubelet's volume manager already cleans up all flexvolume dirs and virtlet flexvolume teardown is never called. So to support uncommon VM lifecycle sequences (as it doesn't excluded explicitly by CRI spec), like CreateContainer->RemoveContainer we need to be able to clean on RemoveContainer.
As possible solutions:

store flexvolume data in bolt
call cleanup within flexvolume driver

Fixed in #361


Could NOT find Eigen3 (missing: EIGEN3_INCLUDE_DIR EIGEN3_VERSION_OK)

Hello, I was trying to reproduce your work. I was able to download and run mrfmap library file and test the program ./testMRFMapViewer file. Everything seemed ok at that point. Then I followed mrfmap_ros tutorial, I did the following:
sudo apt install python-virtualenv
virtualenv ~/virtualenv
source ~/virtualenv/bin/activate
pip install -U vtk PyYAML mayavi matplotlib numpy scipy PyGeometry==1.5.6 opencv-python click
cd ~ && mkdir -P sandbox/mrfmap_sandbox/src && cd sandbox/mrfmap_sandbox && catkin init
catkin config -DCMAKE_BUILD_TYPE=Release
catkin config --install
cd src && git clone https://github.com/mrfmap/mrfmap_ros.git
catkin build mrfmap_ros

So I got the following result:
arghya@arghya-Erazer-X7849-MD60379:~/sandbox/mrfmap_sandbox/src$ catkin build mrfmap_ros
--------------------------------------------------------------------------
Profile:                     default
Extending:          [cached] /home/arghya/ws_moveit/devel:/opt/ros/melodic
Workspace:                   /home/arghya/sandbox/mrfmap_sandbox
--------------------------------------------------------------------------
Build Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/build
Devel Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/devel
Install Space:      [exists] /home/arghya/sandbox/mrfmap_sandbox/install
Log Space:          [exists] /home/arghya/sandbox/mrfmap_sandbox/logs
Source Space:       [exists] /home/arghya/sandbox/mrfmap_sandbox/src
DESTDIR:            [unused] None
--------------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        merged
--------------------------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
--------------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
--------------------------------------------------------------------------
Workspace configuration appears valid.
--------------------------------------------------------------------------
[build] Found '1' packages in 0.0 seconds.
Starting  >>> mrfmap_ros
___________________________________________________________________________________________________________________
Errors     << mrfmap_ros:cmake /home/arghya/sandbox/mrfmap_sandbox/logs/mrfmap_ros/build.cmake.004.log
CMake Error at /opt/cmake/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find Eigen3 (missing: EIGEN3_INCLUDE_DIR EIGEN3_VERSION_OK)
  (Required is at least version "3.3.7")
Call Stack (most recent call first):
  /opt/cmake/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindEigen3.cmake:76 (find_package_handle_standard_args)
  CMakeLists.txt:26 (find_package)

cd /home/arghya/sandbox/mrfmap_sandbox/build/mrfmap_ros; catkin build --get-env mrfmap_ros | catkin env -si  /usr/local/bin/cmake /home/arghya/sandbox/mrfmap_sandbox/src/mrfmap_ros --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/arghya/sandbox/mrfmap_sandbox/devel/.private/mrfmap_ros -DCMAKE_INSTALL_PREFIX=/home/arghya/sandbox/mrfmap_sandbox/install -DCMAKE_BUILD_TYPE=Release; cd -
...................................................................................................................
Failed     << mrfmap_ros:cmake          [ Exited with code 1 ]
Failed    <<< mrfmap_ros                [ 0.6 seconds ]
[build] Summary: 0 of 1 packages succeeded.
[build]   Ignored:   None.
[build]   Warnings:  None.
[build]   Abandoned: None.
[build]   Failed:    1 packages failed.

Here is my log file:
build.cmake.004.log
Now the problem seems to me is that it's the eigen version mismatch. Here are the things that I changed:

After fresh clone of mrfmap_ros repo, I replaced a line of Cmakelist.txt file with the default MRFMAP PATH '/home/icoderaven/packages/mrfmap/install/share/cmake/' with '/home/arghya/mrfmap/install/share/cmake/' (my default mrfmap library installed path).

Initially before building mrfmap library, I had Cmake version 3.10. I downloaded the Cmake 3.18 manually and installed it on the system. The command 'cmake --version' showed 3.18.1.

Initially before building mrfmap library, I had Eigen version 3.3.4. So, in order to upgrade, I downloaded version 3.3.7. Manually copied the 'Eigen' subdirectory of  'eigen-eigen-323c052e1731' directory (which was generated after extracting the eigen-eigen-323c052e1731.tar.bz2 file) from /home/arghya/Downloads directory to /usr/local/include directory. So at this point, my /usr/include directory has a 'Eigen' subdirectory where the version is 3.3.4 where as my /usr/local/include has a 'Eigen' subdirectory where the version is 3.3.7.

So, after this stage, I tried to build the mrfmap library which worked and seemed ok (as I was able to run the test file in open3D). Then I tried to build mrfmap_ros package with 'catkin build mrfmap_ros'. The same error occured shown above.

So, I thought that this may be due to version mismatch of eigen. So, I deleted the subdirectory named 'Eigen' (version 3.3.4)  in usr/include/ directory and replaced it with subdirectory named 'Eigen'  (version 3.3.7) which was in usr/local/include directory. Then I repeated the workflow of no. 4 but got the same error.

Then I thought may be I should try to build the  'eigen-eigen-323c052e1731' directory (which was generated after extracting the eigen-eigen-323c052e1731.tar.bz2 file). So inside the 'eigen-eigen-323c052e1731' directory, I created a subdirectory build with 'mkdir build' && cd build' and 'cmake ..' and then 'sudo make install' command. Though it appeared the same (copied the 'Eigen' subdirectory (basically header files) to /usr/local/include directory which I previously did manually), I repeated the workflow of no. 4 but got the same error.

Now I have 2 'Eigen' subdirectories with the same version (3.3.7). One inside /usr/include directory and one inside /usr/local/include directory. Still the problem persists.
I am using ubuntu 18.04 machine with nvidia graphics card 1070, graphics driver version 440 and CUDA version 10.2.
It appeared to me that there are some 'cache' directory from where it is reading the version (which may be 3.3.4) and that's why after changing 'Eigen' header files in the actual directories, cmake is not taking into account whether the actual version has changed or not. It's reading the cached version and showing the error. Can anybody help ??

Hi @ArghyaChatterjee!
If you look at https://github.com/mrfmap/mrfmap_ros/blob/94416bfae6f4dc3772a1121fd2d10bef3170a685/CMakeLists.txt#L23
All you need to do is point an environment variable to your Eigen 3.3.7 directory
export EIGEN3_INCLUDE_DIR=/path/to/eigen

and then do a catkin clean before building.
As a side note, avoid changing contents of your /usr/include since other packages in your system might depend on it.
Let me know if this helps!

Hi @icoderaven , thanks for your reply. It helped a lot. However, the package still didn't build correctly. So, initially inside the virtual environment, I tried to install the libraries as you mentioned with the command pip install -U vtk PyYAML mayavi matplotlib numpy scipy PyGeometry==1.5.6 opencv-python click. The error shows up something like this:
(virtualenv) arghya@arghya-Erazer-X7849-MD60379:~$ pip install -U vtk PyYAML mayavi matplotlib numpy scipy PyGeometry==1.5.6 opencv-python click
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Requirement already up-to-date: vtk in ./virtualenv/lib/python2.7/site-packages (8.1.2)
Requirement already up-to-date: PyYAML in ./virtualenv/lib/python2.7/site-packages (5.3.1)
Requirement already up-to-date: mayavi in ./virtualenv/lib/python2.7/site-packages (4.7.1)
Requirement already up-to-date: matplotlib in ./virtualenv/lib/python2.7/site-packages (2.2.5)
Requirement already up-to-date: numpy in ./virtualenv/lib/python2.7/site-packages (1.16.6)
Requirement already up-to-date: scipy in ./virtualenv/lib/python2.7/site-packages (1.2.3)
Requirement already up-to-date: PyGeometry==1.5.6 in ./virtualenv/lib/python2.7/site-packages (1.5.6)
Collecting opencv-python
  Using cached opencv-python-<IP_ADDRESS>.tar.gz (88.0 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /home/arghya/virtualenv/bin/python2 /home/arghya/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpALU67E
       cwd: /tmp/pip-install-T2hiB6/opencv-python
  Complete output (22 lines):
  Traceback (most recent call last):
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py", line 280, in <module>
      main()
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py", line 263, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py", line 114, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/setuptools/build_meta.py", line 146, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/setuptools/build_meta.py", line 127, in _get_build_requires
      self.run_setup()
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/setuptools/build_meta.py", line 243, in run_setup
      self).run_setup(setup_script=setup_script)
    File "/home/arghya/virtualenv/local/lib/python2.7/site-packages/setuptools/build_meta.py", line 142, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 448, in <module>
      main()
    File "setup.py", line 99, in main
      % {"ext": re.escape(sysconfig.get_config_var("EXT_SUFFIX"))}
    File "/home/arghya/virtualenv/lib/python2.7/re.py", line 210, in escape
      s = list(pattern)
  TypeError: 'NoneType' object is not iterable
  ----------------------------------------
ERROR: Command errored out with exit status 1: /home/arghya/virtualenv/bin/python2 /home/arghya/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpALU67E Check the logs for full command output.

The error is about opencv. Actually I ignored it previously thinking that I have opencv 3.4.8 installed for both python 2.7 and python 3.6.9 version so may be it is not a major problem.
Now after your suggestion, I changed the environment variable to permanently source eigen3 directory to my .bashrc file hence to the terminal. Now, another error shows up like this:
 (virtualenv) arghya@arghya-Erazer-X7849-MD60379:~/sandbox/mrfmap_sandbox/src$ catkin build mrfmap_ros
--------------------------------------------------------------------------
Profile:                     default
Extending:          [cached] /home/arghya/ws_moveit/devel:/opt/ros/melodic
Workspace:                   /home/arghya/sandbox/mrfmap_sandbox
--------------------------------------------------------------------------
Build Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/build
Devel Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/devel
Install Space:      [exists] /home/arghya/sandbox/mrfmap_sandbox/install
Log Space:          [exists] /home/arghya/sandbox/mrfmap_sandbox/logs
Source Space:       [exists] /home/arghya/sandbox/mrfmap_sandbox/src
DESTDIR:            [unused] None
--------------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        merged
--------------------------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
--------------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
--------------------------------------------------------------------------
Workspace configuration appears valid.
--------------------------------------------------------------------------
[build] Found '1' packages in 0.0 seconds.
Starting  >>> mrfmap_ros
_____________________________________________________________________________________________________________________________________________________________________
Errors     << mrfmap_ros:make /home/arghya/sandbox/mrfmap_sandbox/logs/mrfmap_ros/build.make.001.log
/usr/bin/ld: cannot find -lThreads::Threads
collect2: error: ld returned 1 exit status
make[2]: *** [/home/arghya/sandbox/mrfmap_sandbox/devel/.private/mrfmap_ros/lib/mrfmap_ros/GVDBBatchMapCreator] Error 1
make[1]: *** [CMakeFiles/GVDBBatchMapCreator.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lThreads::Threads
collect2: error: ld returned 1 exit status
make[2]: *** [/home/arghya/sandbox/mrfmap_sandbox/devel/.private/mrfmap_ros/lib/mrfmap_ros/ros_mrfmap_node] Error 1
make[1]: *** [CMakeFiles/ros_mrfmap_node.dir/all] Error 2
/usr/bin/ld: cannot find -lThreads::Threads
collect2: error: ld returned 1 exit status
make[2]: *** [/home/arghya/sandbox/mrfmap_sandbox/devel/.private/mrfmap_ros/lib/MRFMapRosPyModules.so] Error 1
make[1]: *** [CMakeFiles/MRFMapRosPyModules.dir/all] Error 2
make: *** [all] Error 2
cd /home/arghya/sandbox/mrfmap_sandbox/build/mrfmap_ros; catkin build --get-env mrfmap_ros | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
.....................................................................................................................................................................
Failed     << mrfmap_ros:make           [ Exited with code 2 ]
Failed    <<< mrfmap_ros                [ 0.3 seconds ]
[build] Summary: 0 of 1 packages succeeded.
[build]   Ignored:   None.
[build]   Warnings:  None.
[build]   Abandoned: None.
[build]   Failed:    1 packages failed.
[build] Runtime: 0.4 seconds total.

Your help is much appreciated. Eagerly waiting for your response. TIA.

For the first error, sometimes pip doesn't get dependencies correctly resolved, so it requires finding dependencies manually by searching for errors and installing them. Let me know if you are still struggling, and I'll try to set up a fresh instance to figure it out.
For the latter case, it seems that the transitive pthreads dependency is not working out. Can you add this line
find_package(Threads REQUIRED)

to the CMakeLists.txt and check on a clean rebuild?

So, according to your suggestion, I added the line find_package(Threads REQUIRED) to my CMakeLists.txt file, performed a catkin clean inside 'src' folder and initiated catkin build mrfmap_ros. The problem seem to be resolved from then on. However, another problem occured regarding 'catkin_pkg' package.
(virtualenv) arghya@arghya-Erazer-X7849-MD60379:~/sandbox/mrfmap_sandbox/src$ catkin build mrfmap_ros
--------------------------------------------------------------------------
Profile:                     default
Extending:             [env] /home/arghya/ws_moveit/devel:/opt/ros/melodic
Workspace:                   /home/arghya/sandbox/mrfmap_sandbox
--------------------------------------------------------------------------
Build Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/build
Devel Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/devel
Install Space:     [missing] /home/arghya/sandbox/mrfmap_sandbox/install
Log Space:         [missing] /home/arghya/sandbox/mrfmap_sandbox/logs
Source Space:       [exists] /home/arghya/sandbox/mrfmap_sandbox/src
DESTDIR:            [unused] None
--------------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        merged
--------------------------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
--------------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
--------------------------------------------------------------------------
Workspace configuration appears valid.

NOTE: Forcing CMake to run for each package.
--------------------------------------------------------------------------
[build] Found '1' packages in 0.0 seconds.
Starting  >>> catkin_tools_prebuild
__________________________________________________________________________________________
Errors     << catkin_tools_prebuild:cmake /home/arghya/sandbox/mrfmap_sandbox/logs/catkin_tools_prebuild/build.cmake.000.log
ImportError: "from catkin_pkg.package import parse_package" failed: No module named catkin_pkg.package
Make sure that you have installed "catkin_pkg", it is up to date and on the PYTHONPATH.
CMake Error at /opt/ros/melodic/share/catkin/cmake/safe_execute_process.cmake:11 (message):
  execute_process(/home/arghya/virtualenv/bin/python2
  "/opt/ros/melodic/share/catkin/cmake/parse_package_xml.py"
  "/opt/ros/melodic/share/catkin/cmake/../package.xml"
  "/home/arghya/sandbox/mrfmap_sandbox/build/catkin_tools_prebuild/catkin/catkin_generated/version/package.cmake")
  returned error code 1
Call Stack (most recent call first):
  /opt/ros/melodic/share/catkin/cmake/catkin_package_xml.cmake:74 (safe_execute_process)
  /opt/ros/melodic/share/catkin/cmake/all.cmake:168 (_catkin_package_xml)
  /opt/ros/melodic/share/catkin/cmake/catkinConfig.cmake:20 (include)
  CMakeLists.txt:4 (find_package)

cd /home/arghya/sandbox/mrfmap_sandbox/build/catkin_tools_prebuild; catkin build --get-env catkin_tools_prebuild | catkin env -si  /usr/local/bin/cmake /home/arghya/sandbox/mrfmap_sandbox/build/catkin_tools_prebuild --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/arghya/sandbox/mrfmap_sandbox/devel/.private/catkin_tools_prebuild -DCMAKE_INSTALL_PREFIX=/home/arghya/sandbox/mrfmap_sandbox/install -DCMAKE_BUILD_TYPE=Release; cd -
..........................................................................................
Failed     << catkin_tools_prebuild:cmake          [ Exited with code 1 ]
Failed    <<< catkin_tools_prebuild                [ 0.9 seconds ]
Abandoned <<< mrfmap_ros                           [ Unrelated job failed ]
[build] Summary: 0 of 2 packages succeeded.
[build]   Ignored:   None.
[build]   Warnings:  None.
[build]   Abandoned: 1 packages were abandoned.
[build]   Failed:    1 packages failed.
[build] Runtime: 1.0 seconds total.

So, after I added python path (version 2.7.17) into the .bashrc file (export PYTHONPATH=$PYTHONPATH:/usr/lib/python2.7/dist-packages), I opened a new terminal, moved to the 'src' directory, performed a catkin clean and then executed catkin build mrfmap_ros. The program was able to find out catkin_pkg. I somehow managed to build the package with a warning regarding opencv version:
(virtualenv) arghya@arghya-Erazer-X7849-MD60379:~/sandbox/mrfmap_sandbox/src$ catkin build mrfmap_ros
--------------------------------------------------------------------------
Profile:                     default
Extending:             [env] /home/arghya/ws_moveit/devel:/opt/ros/melodic
Workspace:                   /home/arghya/sandbox/mrfmap_sandbox
--------------------------------------------------------------------------
Build Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/build
Devel Space:        [exists] /home/arghya/sandbox/mrfmap_sandbox/devel
Install Space:     [missing] /home/arghya/sandbox/mrfmap_sandbox/install
Log Space:         [missing] /home/arghya/sandbox/mrfmap_sandbox/logs
Source Space:       [exists] /home/arghya/sandbox/mrfmap_sandbox/src
DESTDIR:            [unused] None
--------------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        merged
--------------------------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
--------------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
--------------------------------------------------------------------------
Workspace configuration appears valid.

NOTE: Forcing CMake to run for each package.
--------------------------------------------------------------------------
[build] Found '1' packages in 0.0 seconds.
Starting  >>> catkin_tools_prebuild
Finished  <<< catkin_tools_prebuild                [ 1.2 seconds ]
Starting  >>> mrfmap_ros
__________________________________________________________________________________________________________________________
Warnings   << mrfmap_ros:make /home/arghya/sandbox/mrfmap_sandbox/logs/mrfmap_ros/build.make.000.log
/usr/bin/ld: warning: libopencv_imgcodecs.so.3.2, needed by /opt/ros/melodic/lib/libcv_bridge.so, may conflict with libopencv_imgcodecs.so.3.4
/usr/bin/ld: warning: libopencv_imgcodecs.so.3.2, needed by /opt/ros/melodic/lib/libcv_bridge.so, may conflict with libopencv_imgcodecs.so.3.4
cd /home/arghya/sandbox/mrfmap_sandbox/build/mrfmap_ros; catkin build --get-env mrfmap_ros | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..........................................................................................................................
Finished  <<< mrfmap_ros                           [ 32.7 seconds ]
[build] Summary: All 2 packages succeeded!
[build]   Ignored:   None.
[build]   Warnings:  1 packages succeeded with warnings.
[build]   Abandoned: None.
[build]   Failed:    None.
[build] Runtime: 33.9 seconds total.
[build] Note: Workspace packages have changed, please re-source setup files to use them.

A little observation:

When initiating the command mkdir -P sandbox/mrfmap_sandbox/src && cd sandbox/mrfmap_sandbox && catkin init, (which is basically making a directory) using a capital 'P' as flag is throwing error. Small 'p' seems to resolve the issue.
Same is the case with mkdir -P ~/bagfiles/ICL && cd ~/bagfiles/ICL. Small 'p' seems to resolve the issue.

Good catch with the -P flag! Also, it seems like you have multiple opencv version installed to system? Generally not a recommended situation even if the different libraries are ABI compatible.

Closing the issue since the main issue appears to be resolved.


Added necessary fallbacks

Fixes #723

Description

Added: falbacks missing in webpack 5

Checklist
- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

[x] I have verified the functionality in some of the neeto web-apps.
[x] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers
@AbhayVAshokan _a

@AbhayVAshokan I have added the fallbacks necessary to use neeto-commons, I was not able to reproduce the error of node modules missing as mentioned in the issue, Can you please take a look.


[BUG] (Code 401) API-key format invalid.

Describe the bug
(Code 401) API-key format invalid.
To Reproduce
python execute_orders.py --symbol TRXBTC --buy_type market --total 0.00004 --profit 4 --loss 2
Expected behavior
Order to be placed
Screenshots

Environment (please complete the following information):

OS: Windows 10
Python version : 3.8
Release version : 0.0.4

Saved the API keys with quotes " in the env variable so the binance client was unable to process the keys.


Modify Mint to enable JSON logging format in minio-js

This is a duplicate of https://github.com/minio/minio-js/issues/614 . The fix for this issue needs to go into Mint instead of minio-js.

Blocked by releasing minio-js sdk.


Update On Off attribute value doesn't work (TZ-1417)

Answers checklist.

[X] I have read the documentation ESP Zigbee SDK Programming Guide and tried the debugging tips, the issue is not addressed there.
[X] I have updated ESP Zigbee libs (esp-zboss-lib and esp-zigbee-lib) to the latest version, with corresponding IDF version, and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
5.3
esp-zigbee-lib version.
1.6.1
esp-zboss-lib version.
1.6.1
Espressif SoC revision.
ESP32-C6
What is the expected behavior?
esp_zb_zcl_set_attribute_val updates value and sends report (if configured) about changed status
What is the actual behavior?
After call esp_zb_zcl_set_attribute_val neither value changed nor report genereted
Steps to reproduce.

Create simple device with ESP_ZB_ZCL_CLUSTER_ID_ON_OFF and ESP_ZB_ZCL_ATTR_ON_OFF_ON_OFF_ID attribute
Connect device to coordinator. Create binding and configure reporting of the on_off attr to coordinator
Set value of on_off attr via coordinator (works fine)
Set value of on_off attr via device (no report about attr value change)
Read value of on_off attr via coordinator (reads not actual value)

Code for change value on device (procedure is called in FreeRTOS Task):
static void relay_set_state(bool state)
{
	gpio_set_level(RELAY_IO, state);
	esp_zb_lock_acquire(portMAX_DELAY);
	esp_zb_zcl_set_attribute_val(SW_ENDPOINT, ESP_ZB_ZCL_CLUSTER_ID_ON_OFF, ESP_ZB_ZCL_CLUSTER_SERVER_ROLE, ESP_ZB_ZCL_ATTR_ON_OFF_ON_OFF_ID, &state, false);
	esp_zb_lock_release();
}

Same issue described on forum: http://esp32.io/viewtopic.php?t=41047
More Information.
No response

Hi @grebenyuk51 ,
Could you please refer to the temperature sensor example which is similar with your project?

in that example there is no ESP_ZB_ZCL_CLUSTER_ID_ON_OFF. Thus, no ESP_ZB_ZCL_ATTR_ON_OFF_ON_OFF_ID. Or you want to tell me, that I have to manage value of ESP_ZB_ZCL_ATTR_ON_OFF_ON_OFF_ID and do reporting like in example?
But why I can only change ESP_ZB_ZCL_ATTR_TEMP_MEASUREMENT_VALUE_ID via esp_zb_zcl_set_attribute_val, and zigbee will do all magic stuff under hood?

Or you want to tell me, that I have to manage value of ESP_ZB_ZCL_ATTR_ON_OFF_ON_OFF_ID and do reporting like in example?

What I mean is that the SDK can only provide typical examples to demonstrate API usage rather than covering every possible case. The temperature sensor and thermostat example share the similar application logic with your use case, differing only in the cluster. You can review it to understand the runtime logic of attribute setting and reporting, and then use it as a foundation to design or modify your application.


[ISSUE-2321] Updates documentation on re-mounted configuration for params

Addresses this issue: https://github.com/ruby-grape/grape/issues/2321 updating the configuration and adding appropiate testing for this scenario

Fix changelog? Extra pace before -  [.


Check for bad-data response on MD5 mismatch with S3 backend

This is a low priority but we should make sure that #11 is also working appropriately for the S3 backend. Ideally, this should be an end-to-end check with S3 noticing the problem and us mapping the error response to an appropriate Hatrac error response to our client.

@mikedarcy  I'm reassigning this old blocked issue since it would be good to check while doing #45


Migrate azure-security-attestation to stream-style serialization

Description
Migrates azure-security-attestation to azure-json stream-style serialization to reduce reliance on Jackson Databind.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-security-attestation


[FEATURE REQ] sdk automation breaking change detection, output generateOutput.json even when exception occurs

https://github.com/Azure/azure-rest-api-specs/pull/31435/checks?check_run_id=32563739549

When SDK bug happen, we should still output generateOutput.json,
Priority might be low, as this only happens when SDK has bug... It's not very helpful to service.

Related PR: https://github.com/Azure/azure-sdk-for-java/pull/42799


detected video in carrier.mp3

i think ffprobe is detecting a single image (album art) as video in my carrier.mp3, causing this line in process:
if 'video' in carrier_type:
to be true. i ran ffprobe with debug loglevel and got this output:
Duration: 00:05:53.31, start: 0.000000, bitrate: 256 kb/s
Stream #0:0, 50, 1/14112000: Audio: mp3, 44100 Hz, stereo, fltp, 256 kb/s
Stream #0:1, 1, 1/90000: Video: mjpeg (Baseline), 1 reference frame, yuvj420p(pc, bt470bg/unknown/unknown, center), 1280x720 [SAR 1:1 DAR 16:9], 0/1, 90k tbr, 90k
tbn (attached pic)
Metadata:
comment         : Other
audio
video
i tried this:
ffprobe -v error -select_streams v:0 -count_frames -show_entries stream=nb_read_frames -print_format csv=p=0 carrier.mp3
and it returned 1
i get this error when i run stammer:
File "C:\Users\thoma\source\stammer\stammer.py", line 61, in make_frames
frames = np.zeros((num_frames, frame_length * 2), dtype=input_audio.dtype)
ValueError: negative dimensions are not allowed
after removing the album art and running again:
ffprobe -loglevel error -show_entries stream=codec_type -of csv=p=0 carrier.mp3
returns only 'audio' and stammer works fine.
maybe stammer can use the file extension rather than ffprobe to determine the file type?

A simple search leads me to believe -select_streams v:0 needs to be -select_streams V:0.
Uppercase V seems to mean "videos which are not attached pictures"


PHP 7.4 Deprecated function : Array and string offset access syntax with curly braces is deprecated

I got some warning for PHP 7.4 Please fix in filters/FilterASCIIHex.php line 57
$hex .= sprintf("%02x", ord($str{$i}));
to
$hex .= sprintf("%02x", ord($str[$i]));

Come on. This is easy
search: {$i}
replace: [$i}


[dedicated vc] management tool

a part of #2790

Coverage remained the same at 53.546% when pulling 4368b91faf4566bb965a545ad4eaccc8490423c3 on zimiao/dedicate_vc_tool into 9eabf1ee3ef02d8e41f897f232b89163e4d60049 on dedicated_vc.

Coverage remained the same at 53.546% when pulling 4368b91faf4566bb965a545ad4eaccc8490423c3 on zimiao/dedicate_vc_tool into 9eabf1ee3ef02d8e41f897f232b89163e4d60049 on dedicated_vc.

Coverage remained the same at 53.546% when pulling 4368b91faf4566bb965a545ad4eaccc8490423c3 on zimiao/dedicate_vc_tool into 9eabf1ee3ef02d8e41f897f232b89163e4d60049 on dedicated_vc.

@abuccts
Added lisence on non-doc parts.


[CLI]: Wandp process fails to terminate

Describe the bug
After my training script terminates, wandb process is stuck and is not terminated, even ctrl+c cannot terminate it sometimes.
am sharing debug internal logs:
2023-03-17 10:58:41,519 INFO    SenderThread:38526 [sender.py:transition_state():587] send defer: 14
2023-03-17 10:58:41,519 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: defer
2023-03-17 10:58:41,520 DEBUG   SenderThread:38526 [sender.py:send():336] send: final
2023-03-17 10:58:41,520 INFO    HandlerThread:38526 [handler.py:handle_request_defer():170] handle defer: 14
2023-03-17 10:58:41,520 DEBUG   SenderThread:38526 [sender.py:send():336] send: footer
2023-03-17 10:58:41,521 DEBUG   SenderThread:38526 [sender.py:send_request():363] send_request: defer
2023-03-17 10:58:41,521 INFO    SenderThread:38526 [sender.py:send_request_defer():583] handle sender defer: 14
2023-03-17 10:58:41,522 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: poll_exit
2023-03-17 10:58:41,523 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: server_info
2023-03-17 10:58:41,523 DEBUG   SenderThread:38526 [sender.py:send_request():363] send_request: poll_exit
2023-03-17 10:58:41,524 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: get_summary
2023-03-17 10:58:41,525 DEBUG   SenderThread:38526 [sender.py:send_request():363] send_request: server_info
2023-03-17 10:58:41,525 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: sampled_history
2023-03-17 10:58:42,143 DEBUG   HandlerThread:38526 [handler.py:handle_request():144] handle_request: shutdown
2023-03-17 10:58:42,144 INFO    HandlerThread:38526 [handler.py:finish():842] shutting down handler
2023-03-17 10:58:42,525 INFO    WriterThread:38526 [datastore.py:close():298] close: /home/batu/wandb/run-20230317_105832-lvhco0to/run-lvhco0to.wandb
2023-03-17 10:58:43,142 INFO    SenderThread:38526 [sender.py:finish():1504] shutting down sender
2023-03-17 10:58:43,142 INFO    SenderThread:38526 [file_pusher.py:finish():164] shutting down file pusher
2023-03-17 10:58:43,143 INFO    SenderThread:38526 [file_pusher.py:join():169] waiting for file pusher

Additional Files
wandb dir / debug.log:
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Configure stats pid to 38509
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Loading settings from /home/batu/.config/wandb/settings
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Loading settings from /home/batu/wandb/settings
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Loading settings from environment variables: {}
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Applying setup settings: {'_disable_service': False}
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_setup.py:_flush():76] Inferring run settings from compute environment: {'program_relpath': 'demo.py', 'program': '/home/batu/demo.py'}
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:_log_setup():506] Logging user logs to /home/batu/wandb/run-20230317_105832-lvhco0to/logs/debug.log
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:_log_setup():507] Logging internal logs to /home/batu/wandb/run-20230317_105832-lvhco0to/logs/debug-internal.log
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:init():546] calling init triggers
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:init():552] wandb.init called with sweep_config: {}
config: {}
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:init():602] starting backend
2023-03-17 10:58:32,896 INFO    MainThread:38509 [wandb_init.py:init():606] setting up manager
2023-03-17 10:58:32,898 INFO    MainThread:38509 [backend.py:_multiprocessing_setup():106] multiprocessing start_methods=fork,spawn,forkserver, using: spawn
2023-03-17 10:58:32,900 INFO    MainThread:38509 [wandb_init.py:init():613] backend started and connected
2023-03-17 10:58:32,902 INFO    MainThread:38509 [wandb_init.py:init():701] updated telemetry
2023-03-17 10:58:32,902 INFO    MainThread:38509 [wandb_init.py:init():741] communicating run to backend with 60.0 second timeout
2023-03-17 10:58:33,604 INFO    MainThread:38509 [wandb_run.py:_on_init():2133] communicating current version
2023-03-17 10:58:33,851 INFO    MainThread:38509 [wandb_run.py:_on_init():2142] got version response
2023-03-17 10:58:33,852 INFO    MainThread:38509 [wandb_init.py:init():789] starting run threads in backend
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_console_start():2114] atexit reg
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_redirect():1969] redirect: SettingsConsole.WRAP_RAW
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_redirect():2034] Wrapping output streams.
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_redirect():2059] Redirects installed.
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_init.py:init():831] run started, returning control to user process
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_finish():1854] finishing run colorslab/multideepsym/lvhco0to
2023-03-17 10:58:38,866 INFO    MainThread:38509 [wandb_run.py:_atexit_cleanup():2083] got exitcode: 0
2023-03-17 10:58:38,867 INFO    MainThread:38509 [wandb_run.py:_restore():2066] restore
2023-03-17 10:58:38,867 INFO    MainThread:38509 [wandb_run.py:_restore():2072] restore done
2023-03-17 10:58:43,146 INFO    MainThread:38509 [wandb_run.py:_footer_history_summary_info():3422] rendering history
2023-03-17 10:58:43,146 INFO    MainThread:38509 [wandb_run.py:_footer_history_summary_info():3454] rendering summary
2023-03-17 10:58:43,148 INFO    MainThread:38509 [wandb_run.py:_footer_sync_info():3380] logging synced files

Environment
WandB version: 0.14.0
OS: Ubuntu 22.04LTS
Python version: 3.10.9
Versions of relevant libraries:
pytorch: '1.13.1+cu117'
Additional Context
As far as I understand, It cannot complete uploading a file and the subprocess responsible for loading the file is initialized and terminated in a recurring manner.
There is a ss from htop bellow, the list goes on and on:

Additional information: it works just fine when I reduced number epochs from 200 to 10
I would really like to keep my epoch number in at least 200

@mbatuhancelik do you think you could provide more information like the full debug logs as well as a reproduction example to see how you execute your code?

You can find log files here
As a reproduction example, I can send the training loop, sadly it is not possible for me to send the whole model structure.
def train(self, epoch, loader, val_loader=None):
        for e in range(epoch):
            # one epoch training over the train set
            epoch_loss = self.one_pass_optimize(loader)
            self.epoch += 1
            wandb.log({"train_loss": epoch_loss, "epoch": self.epoch})

            # calculate validation loss
            if val_loader is not None:
                val_loss = 0.0
                for i, sample in enumerate(val_loader):
                    with torch.no_grad():
                        L = self.loss(sample)
                    val_loss += L.item()
                val_loss /= (i+1)
                wandb.log({"val_loss": val_loss, "epoch": self.epoch})

                if val_loss < self.best_loss:
                    self.best_loss = val_loss
                    self.save("_best")
                print(f"epoch={self.epoch}, iter={self.iteration}, train loss={epoch_loss:.5f}, val loss={val_loss:.5f}")
            else:
                if epoch_loss < self.best_loss:
                    self.best_loss = epoch_loss
                    self.save("_best")
                print(f"epoch={self.epoch}, iter={self.iteration}, loss={epoch_loss:.5f}")
            self.save("_last")
        self.save_symbols(val_loader)
def save(self, ext):
        if not os.path.exists(self.path):
            os.makedirs(self.path)

        for name in self.module_names:
            module = getattr(self, name)
            module_dict = module.eval().cpu().state_dict()
            module_path = os.path.join(self.path, name+ext+".pt")
            torch.save(module_dict, module_path)
            getattr(self, name).train().to(self.device)

Going over the log files I noticed we have been uploading checkpoint files in each epoch, resulting in 200 more updates, by moving this operation to the end of the training loop, I managed to get it working. However, the fact remains there was a sudden behavior change.

@mbatuhancelik Thanks for the update and glad to hear that you were able to make it work.
It seems that when you try to upload too many files quite rapidly things are being slowed down, so it takes the process longer to sync all the changes to the checkpoints.
We will take a look into your use case to see if we can fix this behavior change and will update with further findings this thread.


Suggestion to handle 'required' resources or default resources created in new Twilio accounts with less friction

Issue Summary
Twilio accounts have some resources that are required, and are created as part of a new account, but are not recognised automatically as part of terraform. Some of these appear to be just defaults to get you started, but others appear to be required and have a special status.
For example, one of the serverless services is required and should not be removed, and Flex only uses the 'default' versions of some components, like Chat or Conversations services
In order to handle this, we have had to employ workarounds to import these resources when we create new accounts:
https://github.com/techmatters/flex-plugins/blob/master/scripts/src/terraformSupplemental/importDefaultTwilioResourcesToTerraform.ts
However this isn't a foolproof solution, and it has been a source of significant headaches when the default resources created by new accounts change.
Ideally we should be able to work with newly created Twilio accounts via the terraform provider without having to import resources first, and should thereafter know which versions of resources are required or special versions from their Terraform configuration, rather than it having to be tracked separately
Suggested Change

Have the option to create 'bare bones' Twilio accounts, where nothing is added but the absolute minimum required, with the assumption that terraform will take care of the rest, so importing resources isn't required
Call out the 'special' versions of resources in the terraform provider resources. This could be done either:

By being able to designate which resource has the special status via a property flag i.e. default = true for a default conversations service.
Having a separate type of resource for configuring the required default resource, e.g. twilio_default_serverless_service_config_v1, and only have the twilio_serverless_services_v1 used for creating additional serverless services

Agreed. We've had the second option in our backlog for a while (reference DI-1050), but it's not been prioritized.
Pull requests and +1s on the issue summary will help it move up the backlog.

agreed that this is difficult to work with in flex environments which spin up lots of default resources.
a phone number, taskrouter config, studio flows, conversations services, chat services, proxy services, flex conversation addresses (undocumented as far as i can tell), etc...


Error when add to Favourite

Q
A

Bug report?
yes

Feature request?
no

Support request?
no

Variable "form" does not exist in @CocoricoCore/Frontend/ListingResult/result.html.twig at line 55 when press "Favorites" link:

Level
Channel
Message

INFO                                                 13:30:00
request
Matched route "cocorico_listing_favourite".                                           Context: { "route_parameters":  {"_controller":  "Cocorico\CoreBundle\Controller\Frontend\ListingFavouriteController::indexFavouriteAction",  "_locale": "en", "_route": "cocorico_listing_favourite"  },"request_uri": "http://cocorico.dev/en/listing/favourite" }

INFO                                                 13:30:00
security
Populated the TokenStorage with an anonymous Token.

CRITICAL                                                 13:30:01
request
Uncaught PHP Exception  Twig_Error_Runtime: "Variable "form" does not exist in<EMAIL_ADDRESS>at line 55" at  /var/www/cocorico/Symfony/app/cache/dev/classes.php line 4953                                           Context: { "exception": "Object(Twig_Error_Runtime)" }

Thanks rterreroalares :) I reopen it because it is not already merged. It will be merged in a few instants ;)


gl-testing docker image build crash on Apple Silicon

I've been trying to build gl-testing docker image without success on my M1 MBP 16G.
It is a crash when compilation goes out-of-resources, error code 127
However, enabling sparse index protocol solved the issue,
Setting the toolchain to nightly and enabling sparse did work, though apparently it is already on stable rust 1.68+ moving forward, the Dockerfile I used is here below.
# A simple Dockerfile that can be used to test integrations.
#
# The `gl-testing` framework requires a number of dependencies in
# order to run correctly (CLN versions, python dependencies,
# `gl-client` library, etc). This Dockerfile provisions all those
# dependencies correctly and can be used to test the greenlight
# libraries themselves or as a base image for your own test images.

ENV CLN_PATH=/opt/cln/v0.10.1/usr/local/bin/:/opt/cln/v0.10.2/usr/local/bin/:/opt/cln/v<IP_ADDRESS>/usr/local/bin/:/opt/cln/v0.11.2gl2/usr/local/bin/:/opt/cln/v22.11gl1/usr/local/bin/:/opt/cln/v23.05gl1/usr/local/bin/

# Shorten poll intervals so tests are faster to run
ENV DEVELOPER=1

# Add the latest CLN version to the `$PATH` so `pyln-testing` can find
# it when it wants to spawn a new node
ENV PATH=/opt/cln-latest/usr/local/bin/:$PATH

# And we also add the cargo bin directory just for the sake of
# simplifying a dev's life.
ENV PATH=/root/.cargo/bin:$PATH

# Make sure we can tell when running in the docker container. This is
# helpful if we expect to be run in the container, but have been
# invoked somewhere else.
ENV GL_DOCKER=1

# Add cargo and the rust toolchain in case we want to compile
# gl-plugin and gl-signerproxy. This can be useful if we want to
# develop them, and bind-mount the repository from the host into
# `/repo`
RUN curl \
    --proto '=https' \
    --tlsv1.2 \
    -sSf https://sh.rustup.rs | sh \
    -s -- -y --default-toolchain ${RUST_VERSION}

RUN mkdir /tmp/protoc && \
    cd /tmp/protoc && \
    wget --quiet -O protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v3.19.3/protoc-3.19.3-linux-x86_64.zip && \
    unzip protoc.zip && \
    mv /tmp/protoc/bin/protoc /usr/local/bin && \
    rm -rf /tmp/protoc

RUN wget -q https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssl_1.5.0_linux_amd64 -O /usr/bin/cfssl && \
    chmod a+x /usr/bin/cfssl
RUN wget -q https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssljson_1.5.0_linux_amd64 -O /usr/bin/cfssljson && \
    chmod a+x /usr/bin/cfssljson

# Run in a venv, so we don't get warnings about root being special.
 When integrators use this image they'll mount
# their own code into `/repo`
RUN python3 -m pip install /repo/libs/gl-testing

# Required to build and test the JS bindings
RUN npm install -g cargo-cp-artifact

# Hack: importing the proto files twice isn't a good idea, and
# pyln-testing currently does.
RUN sed -i \
    's/from pyln.testing import grpc/#from pyln.testing import grpc/g' \
    /tmp/venv/lib/python3.8/site-packages/pyln/testing/utils.py

RUN ln -s /opt/cln/v23.05gl1 /opt/cln-latest
WORKDIR /repo

Maybe an upgrade to rust 1.69, changing the index protocol to sparse and a dockerfile change would solve this ;).
Happy to provide a PR for this.

Thanks @Jossec101, I think the sparse protocol was enabled by default in 1.70 released last week, so maybe we should just update to that instead? Either way, thank you very much for investing the time and sharing the solution. I'll update the Dockerfile ASAP.

Another thing that comes to mind is that cargo will automatically spawn a new rustc process per core that is available. With mixed core (performance vs. low-power) this can lead it to assume that there are a lot of cores available, spawning more processes and thus exhausting memory. I observed this on a CI system that put limits on memory but would pass cores through transparently, and maybe that has an impact too?


Doesn't gunicorn throttles sanic?

Isn't Gunicorn a throttling factor when using Sanic? Since it isn't ASGI like Uvicorn or Hypercorn?

Nevermind, just saw it's actually uvicorn, sorry


Update Deno Binary

Arghh wrong commit title again

What are the commit titles you wish to see?

Update deno-bin


Fix bugs and weaknesses in SourceMixer class

The current implementation of the SourceMixer class has some undesired bugs:

the sources attribute included in the digest attribute results in a permanently changing digest, even when the sources list has not changed. This can be tested by evaluating the following lines multiple times:

from acoular import PointSource, SourceMixer
sm = SourceMixer(sources=[PointSource()])
print(sm.digest)

the validate_sources method is evoked when the sources list is changed. This violates the lazy evaluation strategy. The following line causes an Attribute error: sm = SourceMixer(sources=[PointSource()]), since PointSource has no signal where the sample_frequency comes from. However, it could be added in a later stage of the code. This should not result in any error. It would be better to validate the sources in the result function, when the processing starts.

mentioned in commit 319733f8defc5256f817b8235ba3e6c9b0be39c7


Wasm support

Thanks for making this crate, it seems very useful :)
Currently the crate always depends on e.g. tokio which means it can't be compiled to wasm for use in frontends (or serverless wasm workers like on AWS/Cloudflare) that want to make OpenAI API requests.
It would be great if this crate could also be compiled to wasm.

Thank you 😌
Given that reqwest support wasm, would like to have wasm support too.
I'm not very familar with wasm ecosystem, but seems like tokio has work in progress for it https://github.com/tokio-rs/tokio/issues/4827
Perhaps via feature flag to swtich between tokio and wasm as initial starting point to support wasm?
Would love your input/ideas on implementation.

Yes, tokio could be an optional feature.
Wasm doesn't need the tokio runtime (and it wouldn't be desirable because of the bloat), but request works on wasm as well.
Not sure which other deps are only needed outside of wasm.
If there are more deps that aren't needed on wasm, you could put them all under one feature named "runtime".

I would love to be able to implement a different async solution.
I think that async-std is an option, and so is executor, which is a no_std option:
https://github.com/richardanaya/executor
I would love to be able to use this crate as no_std on embedded one day, for which I would likely want to use embassy-executor
https://github.com/embassy-rs/embassy/blob/b74645e25960c6d4160b5a150d2e6bf239cef9c8/examples/rp/src/bin/adc.rs#L4
My ideas being personal devices that connect to the openAI API for voice to text, and then to chatGPT.
I may try and help here at some point in the near future. I am currently making a bot to make code upgrades automatically, using your library, so maybe I will point it this direction to test it out....

Hi @cosmikwolf
It seems that support for different async executor should be a separate issue?
Is that somehow related to WASM as well?

Hello @64bit have little experience with WASM architecture but would like to pick this up in the coming week.

Thank you @cosmikwolf and @Doordashcon  for offering to contribute!
I'll let you guys coordinate on this thread.
To consider this resolved we should at least have one working example for AWS lambda or Cloudflare ( or both if you're feeling adventurous :))

+1. I skimmed through the code searching for tokio, and it seems most of the usage relates to files. So, I guess probably the easiest first step is to gate file-related ops behind a feature with optional tokio dependency. Those who want to upload/download music/images have to wait for a while, but text only functions should just work on wasm I guess?

Getting started without streaming and files support, but testable through examples would still be a good first step!

Hi all! If you can help testing #120 and/or try it on wasm, it would be great.

Updates from release notes in 0.17.0:

WASM support, it lives in experiments branch. To use it please pin directly to git sha in your Cargo.toml. Any discussion, issues, related to WASM are welcome in https://github.com/64bit/async-openai/issues/102 . Any WASM related PRs are welcome in experiments branch.

I am maintaining the code for wasm support and I am trying to stabilize wasm target(s) in main. So perhaps we can discuss a more detailed plan here?
Current State
wasm32-unknown-unknown is already working. See the example openai-web-app. And to my knowledge, wasi support should just work since wasm32-unknown-unknown is the bare minimum.
Implementation Plan (not complete)
If you have something in mind, please make a comment or help out the implementation.
Tracking List:

Wasi example(s) on AWS/Cloudflare:

[ ] Compiles to wasm32-wasi target

Since I want to publish a crate that depends on WASM feature of async-openai, I need to publish WASM support first, so I'd like to publish my fork on crates.io with the name async-openai-wasm soon.

Thank you for a heads up. I think that's a good way forward to keep it sustainable.
Do you plan to make it permanent?  If so, you're welcome to link new crate in README. And so we can also close the experiments branch and related doc in README.

Yeah, I've made a PR. Thanks!

WASM support has a new home https://github.com/ifsheldon/async-openai-wasm, hence closing


Exception: process 3 terminated with signal SIGKILL

Hi, when using more than 1 GPU I get the following error:

Traceback (most recent call last):
  File "projects/WSL/tools/train_net.py", line 257, in <module>
    args=(args,),
  File "DRN-WSOD-pytorch/detectron2/engine/launch.py", line 59, in launch
    daemon=False,
  File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 199, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 157, in start_processes
    while not context.join():
  File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 107, in join
    (error_index, name)
Exception: process 3 terminated with signal SIGKILL

Do you know what could be the problem?
If I use only one GPU, I get a memory error when loading the weights.
This is my configuration:
----------------------  -------------------------------------------------------------------------------
sys.platform            linux
Python                  3.7.10 | packaged by conda-forge | (default, Feb 19 2021, 16:07:37) [GCC 9.3.0]
numpy                   1.19.5
detectron2              0.2 @/home/usr_341317_ulta_com/work/brand-detection/DRN-WSOD-pytorch/detectron2
Compiler                GCC 8.3
CUDA compiler           CUDA 11.0
detectron2 arch flags   sm_70
DETECTRON2_ENV_MODULE   <not set>
PyTorch                 1.7.1 @/opt/conda/lib/python3.7/site-packages/torch
PyTorch debug build     False
GPU available           True
GPU 0,1,2,3             Tesla V100-SXM2-16GB
CUDA_HOME               /usr/local/cuda
Pillow                  8.1.0
torchvision             0.8.2 @/opt/conda/lib/python3.7/site-packages/torchvision
torchvision arch flags  sm_35, sm_50, sm_60, sm_70, sm_75, sm_80
fvcore                  0.1.4.post20210323
cv2                     4.5.1
----------------------  -------------------------------------------------------------------------------
PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.4 Product Build 20200917 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v1.6.0 (Git Hash 5ef631a030a6f73131c77892041042805a06064f)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 11.0
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_37,code=compute_37
  - CuDNN 8.0.5
  - Magma 2.5.2
  - Build settings: BLAS=MKL, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_VULKAN_WRAPPER -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

Thanks

Hi. Sorry, I can't find what causes the problem.
Can you run the original detectorn2 code?


HostFS + File Sharing?

Hello there!
I already have a 10TB NAS set up with all my files structured and laid out like a gigantic home folder - because...its a NAS, my stuff goes there. Thing is, I have been wanting a way to easily share them but also use them when I am away. One way would be to use a web desktop that just mounts this NAS as the "user's" home folder. That shouldn't be too difficult.
The other thing is, that I would love to be able to share some files from within the desktop as a link to my collegues on occasion. Is that possible?
Thanks and kind regards!
PS. Nostr is moving to NIP-44 and friends for better encrypted DM support. ;)

Hi @IngwiePhoenix,
It would indeed be nice to be able to mount a local file system. It's not impossible to do this, but the folder would need to be inside public or possibly just linked. Then the JSON builder could map it.
And indeed I have plans to upgrade Nostr also, I just haven't taken the time to make the adjustments. I'd posted about it a while ago. https://github.com/nbd-wtf/nostr-tools/issues/311


[5.4] Breaking the way to register the middleware via the RouteServiceProvider

Laravel Version: 5.4.0
PHP Version: 7.1
Database Driver & Version: none

Description:
A breaking change appeared in my app that stops the usage of $this->middleware() in my external package's RouteServiceProvider extends \Illuminate\Foundation\Support\Providers\RouteServiceProvider.
This is the code i used to register the middleware.
/**
 * Define the routes for the application.
 *
 * @return void
 */
public function map()
{
    $this->middleware('admin', \Vendor\Package\Http\Middleware\CheckAdministrators::class);
    //...
}

I fixed the issue by using the new method aliasMiddleware:
/**
 * Define the routes for the application.
 *
 * @return void
 */
public function map()
{
    $this->aliasMiddleware('admin', \Vendor\Package\Http\Middleware\CheckAdministrators::class);
    //...
}

Is that a correct way to do it ? Why is not mentioned in the Upgrade Guide or Middleware doc section ?

Having the same issue; https://github.com/barryvdh/laravel-cors/pull/171
Should probably be documented.

Thank you for pointing this out, PRed an update to the upgrade docs :)

PR: https://github.com/laravel/docs/pull/3028


Command Binary Interface

This is a MVP for a Command Binary Interface. It's heavily based on Ping.
"""Demo for the Command Interface."""
import logging
import shc
import datetime
import json

from shc.interfaces.command import Command
from shc.web import WebServer
from shc.web.widgets import TextDisplay, DisplayButton, ButtonGroup, icon

server = WebServer("localhost", 8080, index_name="index")

index_page = server.page("index", "Command Binary Interface")

# Check if a system service is running
command1 = Command("systemctl is-active sshd.service")
command1_result = shc.Variable(str, "Command result 1").connect(command1)

index_page.add_item(
    TextDisplay(str, "{}", "Command 1").connect(command1).connect(command1_result)
)

# Get random value (1 or 0)
command2 = Command("echo $((RANDOM%2))")

command2_result = shc.Variable(bool, "Command result 2").connect(
    command2, convert=(lambda x: bool(int(x)))
)

index_page.add_item(
    ButtonGroup(
        "Command 2",
        [
            DisplayButton(label=icon("bell outline"), color="teal").connect(
                command2_result
            ),
        ],
    )
)

# Get data from a RESTful API (no error handling!)
command3 = Command("curl http://worldtimeapi.org/api/ip", datetime.timedelta(minutes=5))
command3_result = shc.Variable(str, "Command result 3").connect(
    command3, convert=(lambda x: json.loads(x)["datetime"])
)

index_page.add_item(TextDisplay(str, "{}", "Command 3").connect(command3_result))

if __name__ == "__main__":
    logging.basicConfig(level=logging.DEBUG)
    shc.main()

Codecov Report

Merging #49 (9db9427) into main (611cd0f) will increase coverage by 0.06%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   80.02%   80.08%   +0.06%
==========================================
  Files          35       36       +1
  Lines        4405     4429      +24
  Branches      590      763     +173
==========================================
+ Hits         3525     3547      +22
- Misses        721      722       +1
- Partials      159      160       +1

Impacted Files
Coverage Δ

shc/interfaces/command_binary.py
90.00% <90.00%> (ø)

shc/interfaces/mqtt.py
85.89% <0.00%> (+0.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611cd0f...9db9427. Read the comment docs.

Hi again,
I feel that this interface should provide a more generic functionality to be merged to the SHC code base. Currently, I cannot think of any program that prints either "1" or "0" to stdout. To make it usable for more different scenarios, I would propose to modify the interface, such that it is Subscribable[bytes] or Subscribable[str], publishing the full stdout of the called process (either as raw bytes or decoded with the system default (!) encoding).
Another possibility (maybe another interface class with some shared code) would be publishing the program's exit code as an int.
You could still use these interfaces in your example by providing a custom convert function when subscribing/connecting the button to your interface:
DisplayButton(label=icon("bell outline"), color="teal").connect(command, convert=(lambda x: x, lambda x: bool(int(x))))

(I used the identity function for the bool → str conversion here, since the type checker expects a callable object, but we don't actually need this function.)
Of course, you can also use the interface just as it is by defining the interface class in your custom SHC application. I actually do this in my private SHC projects, implementing interfaces to our Yamaha sourround receiver and a custom LED controller, which tailored to our specific application and not generic enough to integrate them into the SHC codebase.

An addtional comment on your code example:
You should use an shc.Variable(bool) "between" the interface and the DisplayButton for caching the current state. The DisplayButton expects to be connected to a Readable object to read the current state whenever a new web client connects. Since, your Interface implementation is only Subscribable, but not Readable, new web clients will only see a loader animation until the interface publishes the next value. Creating a Variable that caches the current state and connecting both, the Interface and the DisplayButton to it, will resolve this.

Currently, I cannot think of any program that prints either "1" or "0" to stdout.

Depends on how much Bash foo you want :wink:
$ ping -W 1 -c 1 <IP_ADDRESS> > /dev/null 2>&1 && echo 1 || echo 0

or only go for the specific information:
$ cat /proc/sys/net/ipv4/ip_nonlocal_bind

On second thought it was indeed very limited as other commands return different information. Like  active/inactive:
$ systemctl is-active sshd.service

With convert one could basically run every command and to do the evaluation later.

Of course, you can also use the interface just as it is by defining the interface class in your custom SHC application.

I could but I would prefer to have it upstream. This will avoid that somebody else is re-inventing the wheel while it would be possible to improve the existing "not perfect" or "covering other use cases" Command interface.

I actually do this in my private SHC projects, implementing interfaces to our Yamaha sourround receiver and a custom LED controller,...

I think that people like me could learn a thing or two from those interfaces.

Creating a Variable that caches the current state and connecting both, the Interface and the DisplayButton to it, will resolve this.

Thanks for the hint. And, of course, for your feedback.

I've taken your ideas from this PR and modified them a bit before merging:

I changed the base class from Subscribable[str] to Readable[str], such that the command is not called periodically, but instead is called every time the object is being read. You can easily do this perioically, using the shc.misc.PeriodicReader (see docstring of Command for an example).
I added the shell, check and include_std_err parameters, allowing to customize the behaviour
I added the CommandExitCode class, taking up my idea from above to publish the exit code instead of the stdout of the command.


Added support for the editor buttons

Just added a second optional parameter to the DataTable::of. Its default value is 'id'.

Hello. Thanks for contributing.
That's was great! I'll review and test later..
are you already test and use this code and working fine?

Yeah, I have actually used it on an intranet setup. You can review and test it. Let me know if you encounter any issues with it.

sorry late response.
after I review and thinking. I can't accept this pull request, the reason :

your code looks incomplete. you said: added a second optional parameter.. I didn't see this on last your pull request.. are you sure have added this? and are you sure already test this code (last pull maybe different on your local project) ?
looks like your code doesn't meet for general purpose (just what you need for your project?).
are your code tested for all case? minimal case for all feature for this library on documentation ? like if we use join, subquery, etc..
This is my opinion. If want to make "Editor" library. maybe better if this "Editor" has Separated library or Class.

Hello @hermawanramadhan,
I have worked issue you mentioned. Please go through my latest update and let me if you encounter any other issues with the update.


Use sorted(set) when you need ordered output

https://github.com/duck2/uxsdcxx/blob/65c17a2b626e4d2429256db89b5496e2788ffa99/uxsdcxx.py#L457
https://github.com/duck2/uxsdcxx/blob/65c17a2b626e4d2429256db89b5496e2788ffa99/uxsdcxx.py#L456-L467
The Python code you want is;
for i, dfa in enumerate(sorted(t.group_dfas)):
    pass

There is also http://www.grantjenks.com/docs/sortedcontainers/sortedset.html if speed becomes a problem...

This is solved in the latest commit: uxsdcxx is always gives the same output for a given input file.
https://github.com/duck2/uxsdcxx/blob/be0022108e36b9f4eca564e5bd733c1cdb5fd7a1/dfa.py#L162


AttributeError: 'Dictionary' object has no attribute 'eos'

Thanks for the interesting work.
I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'.
Could you please upload the  sentencepiece.bpe.model or which  sentencepiece.bpe.model you used while training the PLBART model?

Thanks for your attention, I have added this file.

Thanks for the interesting work.
I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'.
Could you please upload the sentencepiece.bpe.model or which sentencepiece.bpe.model you used while training the PLBART model?

i have the same error：**AttributeError: 'Dictionary' object has no attribute 'eos'*。Have you solved this problem?  Could you please tell me the version of fairseq you used？

Thanks for the interesting work.
I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'.
Could you please upload the sentencepiece.bpe.model or which sentencepiece.bpe.model you used while training the PLBART model?

i have the same error：**AttributeError: 'Dictionary' object has no attribute 'eos'*。Have you solved this problem? Could you please tell me the version of fairseq you used？

Hi,
I solved the problem. It's related to the model checkpoint. You must have the exact model checkpoint to run the PLBART model on the clone detection dataset. You can download the checkpoint from the following link:
https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0
If you have any problems downloading it, please let me know. I can share the model via email.

Thanks for the interesting work.
I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'.
Could you please upload the sentencepiece.bpe.model or which sentencepiece.bpe.model you used while training the PLBART model?

i have the same error：**AttributeError: 'Dictionary' object has no attribute 'eos'*。Have you solved this problem? Could you please tell me the version of fairseq you used？

Hi,
I solved the problem. It's related to the model checkpoint. You must have the exact model checkpoint to run the PLBART model on the clone detection dataset. You can download the checkpoint from the following link:
https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0
If you have any problems downloading it, please let me know. I can share the model via email.

Hi,
I have downloaded and used the file in your link, but I still have the same error, may I ask if you have changed anything else ?

I did not change anything.

Awal
On Sat, Aug 10, 2024, 3:55 a.m. lsr_haha @.***> wrote:

Thanks for the interesting work.
I am facing some problems while trying to train the PLBART model on the
clone detection dataset. I did not find sentencepiece.bpe.model in the
replication package. I downloaded sentencepiece.bpe.model from the
following link:
https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no
attribute 'eos'.
Could you please upload the sentencepiece.bpe.model or which
sentencepiece.bpe.model you used while training the PLBART model?
i have the same error：**AttributeError: 'Dictionary' object has no
attribute 'eos'*。Have you solved this problem? Could you please tell me the
version of fairseq you used？
Hi,
I solved the problem. It's related to the model checkpoint. You must have
the exact model checkpoint to run the PLBART model on the clone detection
dataset. You can download the checkpoint from the following link:
https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0
If you have any problems downloading it, please let me know. I can share
the model via email.
Hi,
I have downloaded and used the file in your link, but I still have the
same error, may I ask if you have changed anything else ?
—
Reply to this email directly, view it on GitHub
https://github.com/CGCL-codes/Attack_PTMC/issues/4#issuecomment-2280721265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVFH4WNVG7BE4BJX6C3HGDZQXPQFAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQG4ZDCMRWGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I did not change anything.
…
----- Awal
On Sat, Aug 10, 2024, 3:55 a.m. lsr_haha @.> wrote: Thanks for the interesting work. I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'. Could you please upload the sentencepiece.bpe.model or which sentencepiece.bpe.model you used while training the PLBART model? i have the same error：**AttributeError: 'Dictionary' object has no attribute 'eos'。Have you solved this problem? Could you please tell me the version of fairseq you used？ Hi, I solved the problem. It's related to the model checkpoint. You must have the exact model checkpoint to run the PLBART model on the clone detection dataset. You can download the checkpoint from the following link: https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0 If you have any problems downloading it, please let me know. I can share the model via email. Hi, I have downloaded and used the file in your link, but I still have the same error, may I ask if you have changed anything else ? — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVFH4WNVG7BE4BJX6C3HGDZQXPQFAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQG4ZDCMRWGU . You are receiving this because you authored the thread.Message ID: @.*>

I think my problem may be due to fairseq's version issues.Could you please tell me the version of fairseq you used？

I did not change anything.
…
----- Awal
On Sat, Aug 10, 2024, 3:55 a.m. lsr_haha @.> wrote: Thanks for the interesting work. I am facing some problems while trying to train the PLBART model on the clone detection dataset. I did not find sentencepiece.bpe.model in the replication package. I downloaded sentencepiece.bpe.model from the following link: https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model However, I got the error: AttributeError: 'Dictionary' object has no attribute 'eos'. Could you please upload the sentencepiece.bpe.model or which sentencepiece.bpe.model you used while training the PLBART model? i have the same error：**AttributeError: 'Dictionary' object has no attribute 'eos'。Have you solved this problem? Could you please tell me the version of fairseq you used？ Hi, I solved the problem. It's related to the model checkpoint. You must have the exact model checkpoint to run the PLBART model on the clone detection dataset. You can download the checkpoint from the following link: https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0 If you have any problems downloading it, please let me know. I can share the model via email. Hi, I have downloaded and used the file in your link, but I still have the same error, may I ask if you have changed anything else ? — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVFH4WNVG7BE4BJX6C3HGDZQXPQFAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQG4ZDCMRWGU . You are receiving this because you authored the thread.Message ID: @.*>

Thank you very much for your reply. I have solved the problem. It is a version issue with fairseq, "eos" was added in version 0.12. This error can be avoided simply by lowering the version to 0.10.2

That's a great news. My fairseq version was: fairseq==0.10.0, and it
worked.
Thanks and Regards
-------------------------
Md. Abdul Awal
Assistant Professor
Dept. of Computer Science and Engineering
Khulna University of Engineering & Technology (KUET)
Khulna-9203, Bangladesh
Email: @., @.
Cell Phone: +88 01815-940-362
Website: https://sites.google.com/site/abdulawal2k8/
https://sites.google.com/site/awalcse2k8/
On Sun, Aug 11, 2024 at 3:15 AM lsr_haha @.***> wrote:

I did not change anything.
… <#m_-2024374568178553170_>
----- Awal
On Sat, Aug 10, 2024, 3:55 a.m. lsr_haha @.*> wrote: Thanks for the
interesting work. I am facing some problems while trying to train the
PLBART model on the clone detection dataset. I did not find
sentencepiece.bpe.model in the replication package. I downloaded
sentencepiece.bpe.model from the following link:
https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
https://github.com/wasiahmad/PLBART/blob/main/sentencepiece/sentencepiece.bpe.model
However, I got the error: AttributeError: 'Dictionary' object has no
attribute 'eos'. Could you please upload the sentencepiece.bpe.model or
which sentencepiece.bpe.model you used while training the PLBART model? i
have the same error：AttributeError: 'Dictionary' object has no attribute
'eos'。Have you solved this problem? Could you please tell me the version of
fairseq you used？ Hi, I solved the problem. It's related to the model
checkpoint. You must have the exact model checkpoint to run the PLBART
model on the clone detection dataset. You can download the checkpoint from
the following link:
https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0
https://usaskca1-my.sharepoint.com/:u:/g/personal/mda439_usask_ca/EZrTseUNOu5Irs1sXQAquRwBuRCyjDE0UW7wYxx59ywCAQ?e=v5I2M0
If you have any problems downloading it, please let me know. I can share
the model via email. Hi, I have downloaded and used the file in your link,
but I still have the same error, may I ask if you have changed anything
else ? — Reply to this email directly, view it on GitHub <#4 (comment)
https://github.com/CGCL-codes/Attack_PTMC/issues/4#issuecomment-2280721265>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVFH4WNVG7BE4BJX6C3HGDZQXPQFAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQG4ZDCMRWGU
https://github.com/notifications/unsubscribe-auth/ADVFH4WNVG7BE4BJX6C3HGDZQXPQFAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQG4ZDCMRWGU
. You are receiving this because you authored the thread.Message ID: @.>
Thank you very much for your reply. I have solved the problem. It is a
version issue with fairseq, "eos" was added in version 0.12. This error can
be avoided simply by lowering the version to 0.10.2
—
Reply to this email directly, view it on GitHub
https://github.com/CGCL-codes/Attack_PTMC/issues/4#issuecomment-2282688842,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVFH4U7VAK56G3K54NOWALZQ4TSJAVCNFSM6AAAAABJACIHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGY4DQOBUGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Pedal

Added pedal fingerprints, and _comma.dbc to Odyssey, Ridgeline, Pilot and RDX.
Altered _comma.dbc and panda/board/safety/safety_honda.h to account for variance in Pedal threshold.
Tested with 4 Pedal boards and 2 cars (RDX and Odyssey).  These threshold changes account for variance in Pedal a-to-d and possibly the physical gas pedals.

Yay! Thanks Joel!

I wondered about that. I'll remove the panda from the PR.

Done. Added relevant pull-request for Panda.

@joeljacobs , great. Same thing for opendbc too :).

@rbiasini Do I need to update this PR for 0.4.6? I don't think there is any problem with this PR since it's just fingerprints.

@joeljacobs see my comment. Since some changes are needed, feel free to update to 0.4.6.

@rbiasini how does this look?

@rbiasini This is now updated for the new refactoring. I also did what you asked and sorted all of the IDs and removed the #sent messages lines.

I also converted all hexadecimal entries for all fingerprints, like you suggested.

is this the same as https://github.com/commaai/openpilot/pull/268? if yes, than we can close this one as I ended up verifying the correctness of PR 268. Thanks @joeljacobs

Yes, I think he and I both changed my original PR for 0.4.7, so they should be more or less the same.

Updated PR is now at #274


Loc schema reference fix from 1.19 publish

Fixing some errors from last week's 1.19 GA publish:
Add localizationKeys property (see schema)

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/localization-schema.md
99
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Pivot data format keep keys as separate property

This PR aim to fix issue where data.order: null would still not leave the data order untouched if targets have numerical values.

Fix #1793
Fix #1534

The idea of this update is to keep the ordered keys as an array in the pivot format returned by convert methods.

Codecov Report

Merging #2314 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
+ Coverage   74.95%   75.21%   +0.25%
==========================================
  Files          51       51
  Lines        4233     4236       +3
==========================================
+ Hits         3173     3186      +13
+ Misses       1060     1050      -10

Impacted Files
Coverage Δ

src/data.convert.js
87.05% <100%> (+7.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208b8ec...18c3a1e. Read the comment docs.

I confirmed the data order preseved in this example with this change:
var chart = c3.generate({
    data: {
        columns: [
            ['data5', 30],
            ['data1', 130],
            ['2', 35],
            ['data4', 60],
            ['data3', 100]
        ],
        type: 'bar'
    }
});

Thanks for the contribution!


[WFLY-11222] Fix wrong grep escaping on wsprovide and wsconsume scripts

Upstream jira: https://issues.jboss.org/browse/WFLY-11222
See also the discussion on WFLY-10241
cc: @asoldano, @rsearls, @jamezp

I think we should remove check all together as the -secmgr argument is not a valid JVM option. I'm closing this in favor of #11772. If anyone disagrees we can reopen this.


Docker and vuestorefrontapi_app_1

After
C:\Users\bajg\Documents\VisualStudioCode\vue-storefront-api>docker-compose -f docker-compose.yml -f docker-compose.nodejs.yml up -d
i got
Starting elasticsearch              ... done
Starting vue-storefront-api_redis_1  ... done
Starting vue-storefront-api_kibana_1 ... done
Recreating vuestorefrontapi          ... done

C:\Users\bajg\Documents\VisualStudioCode\vue-storefront-api>docker exec -it vuestorefrontapi_app_1 yarn migrate
Error: No such container: vuestorefrontapi_app_1

Elasticsearch and readis cointerners working fine, but vuestorefrontapi_app_1 not. Why is that ?
I have basic knowledge of docker.

I solve that by :

creating new compose-yaml file rename "app" to "app2"
creating new dockerfile and wchit looks like this

FROM node:10-alpine

ENV VS_ENV dev

WORKDIR /var/www

RUN apk add --no-cache curl git

COPY package.json ./
COPY yarn.lock ./

RUN apk add --no-cache --virtual .build-deps ca-certificates wget && \
    yarn install --no-cache && \
    apk del .build-deps

COPY docker/vue-storefront-api/vue-storefront-api.sh /usr/local/bin/

RUN yarn install

EXPOSE 8080
CMD [ "yarn", "start" ]

now cointeinrer run,  but still don't what caused this problem.


Shouldn't the rename-annotations command delete the old set path?

Not at all urgent, but I was following the Alex's instructions to make the eaf/annotator1 -> eaf/an1 change, and noticed that the command doesn't remove the old set. Is that intentional? If not I can submit a pull request so that the old set is removed which seems more intuitive.
https://github.com/LAAC-LSCP/ChildProject/blob/51b5aa7448c1b5b360d23be7ee43dcb7c4c81e03/ChildProject/annotations.py#L386-L395

I think you're right!
I'm thinking rename-annotations should always be recursive such that this function could just:

move the whole directory (annotations/ to annotations/)
update the index accordingly for  and its subsets

Unless we can think of some cases for which we don't want rename-annotations to apply recursively to all subsets, but I don't see any.

agreed! rename should remove
On Thu 17 Jun 2021 at 08:43, Lucas Gautheron @.***>
wrote:

I think you're right!
I'm thinking rename-annotations should always be recursive such that this
function could just:

move the whole directory (annotations/ to annotations/)
update the index accordingly for and its subsets

Unless we can think of some cases for which we don't want
rename-annotations to apply recursively to all subsets, but I don't see any.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LAAC-LSCP/ChildProject/issues/243#issuecomment-862972837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY6PHIXJYCVJFL63F6363TTTGKR3ANCNFSM462P5GAA
.

--

Alex (Alejandrina) Cristia
Researcher, CNRS
Laboratoire de Sciences Cognitives et Psycholinguistique
29, rue d'Ulm, 75005, Paris, FRANCE
My site: www.acristia.org


SpaceTree Multitree + Bezier Edges + Load JSON = sad edges

Hello everyone!
First of all, please note that this is a copy of the topic on google groups.
Sorry for the double post but the group is flooded with job seekers and my message seems to fit better here.
I have a bug with version 2.0.1 (current stable).
I use it to generate a multitree with bezier edges.
There's no problem when I use addSubtree after a user event, but there's one on loading JSON data.
If I have nodes on the right side of the root node, the edges will go straight from the left side of the root node to the right side of the children nodes.
It should be the opposite sides and bezier curves.
Oddly there's no problem with nodes on the left side.
Code to reproduce, based on multitree demo:
var labelType, useGradients, nativeTextSupport, animate;

(function() {
  var ua = navigator.userAgent,
      iStuff = ua.match(/iPhone/i) || ua.match(/iPad/i),
      typeOfCanvas = typeof HTMLCanvasElement,
      nativeCanvasSupport = (typeOfCanvas == 'object' || typeOfCanvas == 'function'),
      textSupport = nativeCanvasSupport
        && (typeof document.createElement('canvas').getContext('2d').fillText == 'function');
  //I'm setting this based on the fact that ExCanvas provides text support for IE
  //and that as of today iPhone/iPad current text support is lame
  labelType = (!nativeCanvasSupport || (textSupport && !iStuff))? 'Native' : 'HTML';
  nativeTextSupport = labelType == 'Native';
  useGradients = nativeCanvasSupport;
  animate = !(iStuff || !nativeCanvasSupport);
})();

var Log = {
  elem: false,
  write: function(text){
    if (!this.elem)
      this.elem = document.getElementById('log');
    this.elem.innerHTML = text;
    this.elem.style.left = (500 - this.elem.offsetWidth / 2) + 'px';
  }
};

function init(){
    //init data
    var json = {
    "id":"643",
    "name":"Gangliosidose à GM1",
    "data":{"$orn":"right"},
    "children":[
      {"id":"13683",
       "name":"Maculopathie primaire ou secondaire non classifiée",
       "data":{"$orn":"right"},
       "children":[]},
      {"id":"13731",
       "name":"Maladie métabolique avec tâche maculaire rouge cerise",
       "data":{"$orn":"right"},
       "children":[]},
      {"id":"13709",
       "name":"Anomalie du système nerveux avec atteinte ophtalmologique",
       "data":{"$orn":"right"},
       "children":[]},
      {"id":"11283",
       "name":"Gangliosidose à GM1 type 3",
       "data":{"$orn":"left"},
       "children":[]},
      {"id":"11282",
       "name":"Gangliosidose à GM1 type 2",
       "data":{"$orn":"left"},
       "children":[]},
      {"id":"11281",
       "name":"Gangliosidose à GM1 type 1",
       "data":{"$orn":"left"},
       "children":[]}
      ]
    };

    //end
    //grab radio button
    var normal = $jit.id('s-normal');
    //init Spacetree
    //Create a new ST instance
    var st = new $jit.ST({
        //id of viz container element
        injectInto: 'infovis',
        //multitree
          multitree: true,
        //set duration for the animation
        duration: 800,
        //set animation transition type
        transition: $jit.Trans.Quart.easeInOut,
        //set distance between node and its children
        levelDistance: 40,
        //sibling and subtrees offsets
        siblingOffset: 3,
        subtreeOffset: 3,
        //set node and edge styles
        //set overridable=true for styling individual
        //nodes or edges
        Node: {
            height: 30,
            width: 120,
            autoHeight: true,
            color: '#CBEDFF',
            overridable: true,
            CanvasStyles: {
              shadowColor: '#e5e5ff',
              shadowBlur: 8
            }
        },
        Edge: {
            type: 'bezier',
            color: '#65B8EE',
            overridable: true
        },

        onBeforeCompute: function(node){
            Log.write("loading " + node.name);
        },

        onAfterCompute: function(){
            Log.write("done");
        },

        //This method is called on DOM label creation.
      //Use this method to add event handlers and styles to
      //your node.
      onCreateLabel: function(label, node){
        label.id = node.id;
        label.innerHTML = node.name;

        label.onclick = function(){
          manageClick(node);
        };
        var style = label.style;
        style.width = 120 + 'px';
        style.cursor = 'pointer';
        style.color = '#333';
        style.textAlign= 'center';
        if (node.selected) {
          style.color = '#fff';
        }
      },

      onPlaceLabel: function(label, node){
        if (node.selected) {
          var style = label.style;
          style.color = '#fff';
        }
      },

      //This method is called right before plotting
      //a node. It's useful for changing an individual node
      //style properties before plotting it.
      //The data properties prefixed with a dollar
      //sign will override the global node style properties.
      onBeforePlotNode: function(node){
        if (node.selected) {
          node.data.$color = "#3399DD";
        }
      },

      //This method is called right before plotting
      //an edge. It's useful for changing an individual edge
      //style properties before plotting it.
      //Edge data proprties prefixed with a dollar sign will
      //override the Edge global style properties.
      onBeforePlotLine: function(adj){
      }
    });
    //load json data
    st.loadJSON(json);
    //compute node positions and layout
    st.compute('end');
    st.select(st.root);
    //end
}

Did I do something wrong?
Do not hesitate to ask if you need more information.
Thanks for your time and attention!
Yannick

I'm encountering this issue too!
Has there been any update on this issue? (or a workaround?)

I'm not aware of a workaround or anything done, sadly.
Please let me know if you find something!


sdist builds disabled

Describe the bug
Building an sdist in Github CI fails with various permissions issues due to the way we construct wheels. We need to update PKG-INFO for meson dist based sdist build. I thought I would be able to fix this by merging PKG-INFO during the CI build but setuptools_scm still sees changes. I am currently considering that this might be due to the artifact folder not being included into .gitignore.
Now, personally I am fine with defaulting to only wheel releases being published to PyPI as they are built from the git tag/release distribution. Therefore, I am creating this issue for posterity as I am satisfied with the state of OZI being a wheel-only platform.

Fixed in Release 0.0.196


Building issue on Xcode 12.5

Hi,
On Xcode 12.4 we just saw the warnings, but now on the new Xcode 12.5 they have become errors.I think that this should be taken care of now. Not sure how much I can just remove these attributes.
Error:
ios/Pods/MobileMessaging/Classes/Vendor/CryptoSwift/Generics.swift:39:28: 'exported: true' has no effect in '_specialize' attribute'_specialize' attribute
@_specialize(exported: true, where T == Int) 'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == UInt)'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == UInt8) 'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == UInt16) 'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == UInt32) 'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == UInt64) 'exported: true' has no effect in '_specialize' attribute
^
ios/Pods/MobileMessaging/Classes/Vendor/CryptoSwift/UInt32+Extension.swift:32:29: 'exported: true' has no effect in '_specialize' attribute
@_specialize(exported: true, where T == ArraySlice)
Versions:
MobileMessaging SDK version: 3.0.3
Xcode version: 12.5
Cocoapods version: 1.10.1

Hi @ARazaAnjum, thank you for reporting it, actually changes already done on iOS SDK and we will update plugin today!
BR, Olga

@ARazaAnjum, we've released 3.1.0 version with Xcode 12.5 support.
BR, Olga

Closing it, seems it's sloved.


Add DG help command sequence diagram and activity diagram

Codecov Report

Merging #527 (addc056) into master (b0b0c32) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #527   +/-   ##
=========================================
  Coverage     65.25%   65.25%
  Complexity      737      737
=========================================
  Files           147      147
  Lines          2590     2590
  Branches        282      282
=========================================
  Hits           1690     1690
  Misses          749      749
  Partials        151      151

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


No file matching in image directory

Hello,
I manage to install almost everything with a manim tutorial by "theorem of Beethoven" on Windows 10
https://www.youtube.com/watch?v=ZltiKHFWmv8
Everything went fine, and at the end, the first test "transform square in circle" works fine, but the LaTeX test went wrong.

I don't know what to do, I don't understand what's going on.
If anyone can help, I would really appreciate.
Thanks for all,
Yoann

Please read what your terminal says, it is understood that the dvisvgm command is not recognized as an internal command, that is, it was not included when you installed LaTeX, that could happen for two things, or you only installed the basic version or there was an error in the installation, investigate how to install that dependency in some forum.

I use LaTeX on a daily basis, I had probably an old version of MikTex. I unsinstalled and reinstalled it, everything works now.
Thanks for the help !

Ok, please close the issue


Add Series.from_csv with some tests

Just a convenience method to mirror the one in DataFrame.

Thanks Dieter, merged into master


Where to mention community working groups?

Removes community working groups. They will find a new landing place shortly.
(https://github.com/ros2/ros2_documentation/pull/3374#:~:text=community working groups.-,They will find a new landing place shortly.,-Per Feb23 TSC)

I am looking for a place to mention the deliberation working group, which is a community working group. Is there a new place for them, that I am just not able to find? :slightly_smiling_face:

These used to live on http://docs.ros.org/en/rolling/The-ROS2-Project/Governance.html , but they were removed with a new place in mind.  I don't know what that place is, though.  @kscottz @gbiggs can you please comment?

I believe we removed the community working groups but I am not sure if we actually created a new place for them.