Device options are now stream specific; remove owner-name

I found that:

we transmitted each option multiple times from the adapter
counted on overwrite of previous options to make this work in librealsense
set-value in librealsense tried to apply the value to ALL streams that supported this option!

Above is now fixed
We were abusing option creation in the tests, reusing options for multiple streams - this is now impossible

Towards this, I removed owner-name: it's now not possible to get it wrong (as I did, and it crashed)

Tracked on [LRS-865] "Device options are not stream-specific"

I feel like, obviously, something's not clear. Let's talk in person tomorrow.

To summaries our discussion:

Current USB based cameras have options that affect all streams in the sensor, even if they are not related like "Depth Units" for infrared streams.
Previous adapter implementation have duplicated the options for all stream of the sensor. dds_sensor_proxy have set the value repeatedly without need.
New adapter implementation will send options only on one stream per sensor, other streams will not carry options.
This might not be the most optimal solution, but we want a general solution to adapt legacy USB devices, we don't want to start mapping options to streams per device type.
We will work so that new, ethernet based devices, will support options per stream, not per sensor.
Currently no "general" options. dds_option will be at stream or device level.


ProVerif backend: Translation of fns to letfuns

This PR includes basic translation of Rust fns into ProVerif letfun macros. The next steps would be separate treatment of those fns that have been annotated as ProVerif processes and hooking up known letfuns where possible (At the moment I've introduced dummy constructors up to arity 7 in order to generate syntactically valid, if useless, ProVerif for function calls).

Thanks! I had experimented with moving the ProVerif toolchain tests into their own directory on this branch, but I've reverted that again, just now.


mark_as_static support for erroneous objects

Some expert trajectories involve collision with a road_edge. This PR adds support to set those agents as static during json generation.

Is this ready for review?

Not yet, json generation with collision checking in 3d takes a lot longer than without. I need to plot the distribution of scenes against the proportion of agents being marked as static, to determine if such an overhead is even worth it.


white sreen ia displayed on the side panel when set displace as true..

I set displace value to true. when i open the side panel, white page is displayed on the panel. once we scroll the screen little left, the panel,is displayed correctly.

Thanks @englishextra


specify cordova-custom-config version

Something changed recently:
https://github.com/dpa99c/cordova-custom-config/commit/2e1d5d686ac31d3a01d17efbe625de4ff0cd86ce#diff-04c6e90faac2675aa89e2176d2eec7d8
cca doesn't seem to support this method...next-to-most recent NPM still works fine - this unbreaks the Android build.

This change is

https://github.com/uProxy/uproxy/issues/2835


Saving credentials, part II

Thanks very much for this useful image. One problem I have is I want to deploy it into my private repository already logged in. To do this I tried removing the volume you have created at /dbox/.dropbox. This way I can commit that directory's contents back to the image after running it and logging it in.
Doing so, I can clearly see the /dbox/.dropbox contents in my docker diff output, before docker container commiting them. But after I stop the container and start my newly committed image, it requires logging in with the URL again.
The files are there, but the running Dropbox service seems to reject them. What am I missing?
-Brandon

One possible explanation would be that Dropbox checks the host network interface id. Whenever a new device is detected, Dropbox asks to authorise it by following the link. Preserving the network interface or making it seem like the one already authorised would make it possible to reuse your existing configuration.


For old version

I am using cordova-ios version 3.9.2. Which version of cordova-splash should I use for this build ?
Thanks

Hey,
The latest (0.0.9) will be good.
If default command (cordova-splash) does not produce expected results, add the option to use old iOS paths (cordova-splash --xcode-old) .


React Refactor: UNSAFE methods alerts-view.tsx

convert UNSAFE_ methods and use useState and useEffect and useRef and convert to functional component
augur/packages/augur-ui/src/modules/alerts/components/alerts-view.tsx
  UNSAFE_componentWillUpdate(nextProps: AlertsViewProps) {
    if (this.props.alertsVisible && !nextProps.alertsVisible) {
      const { updateExistingAlert, alerts } = this.props;
      alerts.forEach(alert => {
        updateExistingAlert(alert.uniqueId, { ...alert, seen: true });
      });
    }
  }

@bthaile I want to use Alert interface on modules/types for typing "alerts" prop, but currently Alert interface contains only "id" prop and doesn't contain "uniqueId" prop. Walking through alert reducers/actions, I can see that we only use "uniqueId" for checking for existing alert and in most cases there's same value for both props. Could you please recheck and confirm that, so we can remove the "id" prop.

Total Cost for PR: 50 Credits


make install fail on ubuntu arm

$ DEBUG=1 make install
Eager macro-expansion failure: (void-function cl-remove-if)
Symbol's function definition is void: cl-remove-if
Makefile:59: recipe for target '.local/autoloads.el' failed
make: *** [.local/autoloads.el] Error 255
$ ls .local/
@odroidc1.home.local  packages
$ uname -a
Linux odroidc1 3.10.104-184 #1 SMP PREEMPT Mon Feb 20 06:38:17 UTC 2017 armv7l armv7l armv7l GNU/Linux
$ emacs --version
GNU Emacs 24.5.1
Copyright (C) 2015 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
d$ make -d install
GNU Make 4.1
Built for arm-unknown-linux-gnueabihf
Copyright (C) 1988-2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Reading makefile 'Makefile'...
Updating makefiles....
Considering target file 'Makefile'.
Looking for an implicit rule for 'Makefile'.
Trying pattern rule with stem 'Makefile'.
Trying implicit prerequisite 'Makefile.o'.
Trying pattern rule with stem 'Makefile'.
...... PRUNE .......
Considering target file 'install'.
File 'install' does not exist.
Considering target file 'init.el'.
Finished prerequisites of target file 'init.el'.
No need to remake target 'init.el'.
Considering target file '.local/autoloads.el'.
File '.local/autoloads.el' does not exist.
Finished prerequisites of target file '.local/autoloads.el'.
Must remake target '.local/autoloads.el'.
Putting child 0x5cf18 (.local/autoloads.el) PID 13182 on the chain.
Live child 0x5cf18 (.local/autoloads.el) PID 13182
Eager macro-expansion failure: (void-function cl-remove-if)
Symbol's function definition is void: cl-remove-if
Reaping losing child 0x5cf18 PID 13182
Makefile:59: recipe for target '.local/autoloads.el' failed
make: *** [.local/autoloads.el] Error 255
Removing child 0x5cf18 PID 13182 from chain.

Same problem on OSX:
~/.emacs.d (master) DEBUG=1 make install
Symbol's function definition is void: advice-add
make: *** [.local/autoloads.el] Error 255
~/.emacs.d (master) uname -a
Darwin xxxx 16.5.0 Darwin Kernel Version 16.5.0: Fri Mar  3 16:52:33 PST 2017; root:xnu-3789.51.2~3/RELEASE_X86_64 x86_64 i386 MacBookAir6,2 Darwin
Emacs Version 25.2 (9.0)

I've pushed a fix specifically for the missing cl-remove-if.
However, on Ubuntu I see you're using Emacs 24.4. This config will break on versions under 25.1. Not that this specific error was caused by this, but this won't be the last error you get!

The issue for me, was that the default emacs in CLI was the old one from OSX. Added an alias to use the brew one and now it works.

Excellent! And thank you!


Cannot run sample project on aws lambda

Hi I am trying to use this awesome framework, but unfortunately the code won't run on aws lambda with this error:
{
  "errorType": "Runtime.HandlerNotFound",
  "errorMessage": "index.handler is undefined or not exported",
  "trace": [
    "Runtime.HandlerNotFound: index.handler is undefined or not exported",
    "    at Object.module.exports.load (/var/runtime/UserFunction.js:144:11)",
    "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
    "    at Module._compile (internal/modules/cjs/loader.js:1156:30)",
    "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)",
    "    at Module.load (internal/modules/cjs/loader.js:1000:32)",
    "    at Function.Module._load (internal/modules/cjs/loader.js:899:14)",
    "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)",
    "    at internal/main/run_main_module.js:18:47"
  ]
}

I follow this step:

serverless install --url https://github.com/AnomalyInnovations/serverless-nodejs-starter --name my-project
cd my-project
npm install
serverless deploy (but it's error because i havn't setup my aws account to allow cloudformation stack)
So, i upload the file manually to my aws-lambda function. I upload zip from .serverless/hello.zip
Uploaded finished and i saved the code, run the test
Result is error

Please help me thanks

I haven't tried manually uploading it. And it seems like that doesn't work because the error is complaining about index.handler which we don't have defined in this starter.


Add a UserSetting for --cf

🚀 Feature Proposal
Adding the --cf to commands so that the dialogue is skipped is nice, but you're still having to do an extra step for each action. Why not just allow users to do something like:
import { KlasaMessage, CommandStore } from 'klasa';
import { BotCommand } from '../../lib/BotCommand';

export default class extends BotCommand {
	public constructor(store: CommandStore, file: string[], directory: string) {
		super(store, file, directory, {
			usage: '<setting:int{0,1}|string>',
			usageDelim: ' '
		});
	}

	async run(msg: KlasaMessage, [setting]: [int|string]) {
                if (typeof setting == "number"){
                        if (setting == 1){
                                await msg.author.settings.set("SkipCFOnAllActions", true);
                        } else {
                                await msg.author.settings.set("SkipCFOnAllActions", false);
                        }
                } else {
                        if (setting === "true"){
                                await msg.author.settings.set("SkipCFOnAllActions", true);
                        } else {
                                await msg.author.settings.set("SkipCFOnAllActions", false);
                        }
                }
	}
}

Then rather than checking for --cf in messages, you could just have it check for the UserSetting.SkipCFOnAllActions

I don't think this is a good idea. People will set it and then forget later on and then accidentally do something without knowing.


Question: Detect italic additionally from font name?

I had a closer look at the detection of the italic style in the FontsData. Due to a recent feedback I was wondering, if we should additionally try to detect if the word "Italic" is present in the font name, despite the correct fsSelection values not being set. This might be a case of users having to create proper files, but just throwing it up here as this came up with a user of my plugin that uses this library.

Added this in a preliminary way to this branch

I guess this was closed with #17


Docs for collapse should demo accordion-like groups

Fixes #33345
Preview: https://deploy-preview-33348--twbs-bootstrap.netlify.app/docs/5.0/components/collapse/#accordion-like-group-management

I seriously doubt about this pattern's accessibility, and as such don't think it should be added. Thoughts, @patrickhlauke?

@ffoodd @patrickhlauke I use this pattern when a user action should change the page state. For example, during a checkout process, user actions can (and should) change what is shown during the next step. This pattern also makes it easy to return to a previous step.
I find the pattern most helpful during a process. However, in trying to make the example as generic as possible, I omitted that context, and without that context, I understand your concern, because panels suggest that content is parallel, not sequential. Rewriting the example to show sequential steps instead of parallel panels makes this more clear, with the caveat that the example becomes more opinionated and less generic. That said, showing sequential steps would probably be an improvement.
Also, in the case of focus being lost, Chrome and Firefox handle the loss of focus reasonably well. Do you know whether or not the scenario of focus being reset to the start of the page actually occurs in any of the browsers supported by v5?

Also, in the case of focus being lost, Chrome and Firefox handle the loss of focus reasonably well. Do you know whether or not the scenario of focus being reset to the start of the page actually occurs in any of the browsers supported by v5?

Chrome + JAWS bypasses Chrome's error correction, just as one example. Do not rely on focus error correction, it needs to be explicitly handled.

Do not rely on focus error correction, it needs to be explicitly handled.

This sounds like a distinct issue: "some components should be able to explicitly set focus".
For example, it looks like the same issue occurs when toggling between modals, see https://getbootstrap.com/docs/5.0/components/modal/#toggle-between-modals
I could imagine an attribute data-bs-autofocus that grabs focus when an ancestor is shown. More precisely, when any element is shown (including when the document is first shown), the first child having data-bs-autofocus would be given focus. This would also allow modals to set focus on the user name for a sign in form, or on the close button. Or in the example I'm describing, it would be easy to focus on the next step in the process.

This sounds like a distinct issue: "some components should be able to explicitly set focus".
For example, it looks like the same issue occurs when toggling between modals, see https://getbootstrap.com/docs/5.0/components/modal/#toggle-between-modals

focus is programmatically handled and sent to the newly shown <div> which has a tabindex="-1" to be able to receive programmatic focus()

Think we can close this one out as stale and possibly too confusing to include in the docs. I'm into adding more docs examples whenever possible, but per other feedback, closing out.


Navigation improvements

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[x] @clerk/nextjs
[ ] @clerk/types
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

The default navigate function provided by Remix works in 5 phases:

calls the route loader
replaces the current url
waits for the loader to return route data
unmounts the old tree
finally, it mounts the new page

In our case, SignIn remained mounted up until step 5. Because we couldn't reliably await the navigation, withRedirectToHome in some cases would trigger before the new page is mounted causing a redirect to the home page instead of respecting the redirectUrl prop.
We used the useTransition remix hook to create a custom awaitable navigate function for use with Remix applications. The hook stores all pending navigations and resolves them when the state changes to idle (loading -> idle).
I'm also considering adding a small delay for extra safety - keep in mind that this delay will only applied to navigations triggered by clerk (after sign in, after sign out etc) so it shouldn't be noticeable at all.
This PR also includes a beforeUnload fix - we now use listen for the native beforeUnload event as well as the custom clerk:beforeUnload event (which exists to cover inconsistencies between browsers and only fires when windowNavigate is called). Ideally we don't want to listen for the native beforeUnload event always as this disabled the BF cache - to prevent this, we created a beforeUnloadTracker which starts tracking just before a potential navigation is going to happen and stops tracking right after.
PS: We use beforeUnload in one more place but my tests show that this does not affect BF at all, however I need to investigate further to make sure.
Additional context:

https://developers.google.com/web/updates/2018/07/page-lifecycle-api#the-beforeunload-event
https://developers.google.com/web/updates/2018/07/page-lifecycle-api#managing-cross-browsers-differences
https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#usage_notes

@nikosdouvlis Does this fix apply only to remix or are there scenarios that we need to fix in @clerk/clerk-react as well?

@nikosdouvlis Does this fix apply only to remix or are there scenarios that we need to fix in @clerk/clerk-react as well?

Before this PR, we only caught unloads when the external navigation was triggered by our own windowNavigate function (which would be the case for anyone using our components).
The update here enables us to properly catch the unload event when developers do this manually:
setSession("sess_foo", () => {
  window.location.href = "/bar"
});

This portion of the PR is not Remix-specific


Export getUserAppFileUrl

Describe the feature
As we get user-owned storage back, it is important to lookup the read url from the profile. This is what getUserAppFileUrl does. This function should be exported by @stacks/storage

thanks @friedger, we'd have to see if/how we could prioritize this. do you have more context on the importance - is this a blocker for you? in what use case/app?

As a workaround, I have cloned the code for the function.
I am upgrading my blockstack apps to stacks apps. I am using the function to get a public calendar from a different user on cal.openintents.org

@friedger I was looking into this issue. The getUserAppFileUrl  is a method of Storage class which is already exported from storage package. To call this method we need a instance of Storage class which is exported by storage.
Example test case:
  const { Storage } = require('../src');
  const storage = new Storage({ userSession });

  await storage.getUserAppFileUrl(path, name, appOrigin).then((url: string) => {
    expect(url).toBeTruthy();
    expect(url).toEqual(fileUrl);
  });

@friedger If you can elaborate what sort of export you are envisioning for getUserAppFileUrl that would be great.
cc: @agraebe @friedger @asimm241

@asimm241 investigated this and it seems not to be an issue. closing for now; please reopen with more details if it still is an issue

@agraebe Could you please reopen it.
The issue is about the requirement of a user session. The method is querying of a different user's profile. There is no need for this dependency.
Workaround would be to define a new function that creates the objects.
async function getUserAppFileUrl2(...) {
   return new Storage({new UserSession()}).getUserAppFileUrl(...)
}

The method does not belong to the storage object, I think.

@agraebe Could you please reopen it.
The issue is about the requirement of a user session. The method is querying of a different user's profile. There is no need for this dependency.
Workaround would be to define a new function that creates the objects.
async function getUserAppFileUrl2(...) {
   return new Storage({new UserSession()}).getUserAppFileUrl(...)
}

The method does not belong to the storage object, I think.

@friedger Just reiterating this thing.
The method getUserAppFileUrl  belongs to storage class. To call the method you need a storage class object. Here is the reference:
https://github.com/blockstack/stacks.js/blob/f3cf94683b377619b9390fb400f445edf47f378a/packages/storage/src/storage.ts#L196
Test case: https://github.com/blockstack/stacks.js/blob/f3cf94683b377619b9390fb400f445edf47f378a/packages/storage/tests/storage.test.ts#L1970
It would be great if you can visit my previous comment with snipit:
  const { Storage } = require('../src');
  const storage = new Storage({ userSession });

  await storage.getUserAppFileUrl(path, name, appOrigin).then((url: string) => {
    expect(url).toBeTruthy();
    expect(url).toEqual(fileUrl);
  });

And elaborate on what sort of getUserAppFileUrl export you need. As its a method of storage  class which is already exported.

The method getUserAppFileUrl belongs to storage class.

@ahsan-javaid I disagree here. As a app developer, I just need the Stacks chain to resolve the username, lookup the profile and construct the read-only url.
The use-case is that I want to show a list of public avatar, they are stored at a specific file on the users gaia bucket unencrypted. There is no need to authenticate with the gaia storage, no need to be authenticated as a user. I just  want to call getUserAppFileUrl(path, username, window.location.origin) and display that image.
The storage object describes mainly my own storage, the storage object has an understanding of my gaia host configuration. At least that is my understanding.
cc @HariniRajan397 as she investigates how to support custom gaia configurations.

Furthermore, the implementation is

async function getUserAppFileUrl(path, username, appOrigin, zoneFileLookupURL) {
  const profile = await lookupProfile({ username, zoneFileLookupURL })
  let bucketUrl
  if (profile.hasOwnProperty('apps')) {
    if (profile.apps.hasOwnProperty(appOrigin)) {
      const url = profile.apps[appOrigin]
      const bucket = url.replace(/\/?(\?|#|$)/, '/$1')
      bucketUrl = `${bucket}${path}`
    }
  }
  return bucketUrl
}

There is no use of any gaia related methods. The function could be even moved to @stacks/profile. However, without any storage calls there won't be any meaningful files to resolve.

@friedger it looks like the issue is mostly about making this function a bit more straightforward to use (i.e. not requiring construction of a Storage class)?
Seems like a reasonable request.
One thing I'd caution is that if the function getUserAppFileUrl(path, username, appOrigin, zoneFileLookupURL) is exposed, it should require that last param zoneFileLookupURL to be specified. It would help inform/encourage app devs that they are forfeiting a possible user-supplied endpoint in favor of either the Hiro hosted instance or their own instance (regardless if the current wallets/authenticators support that at the moment). In other words, we want to encourage devs to use the Storage class when the user is logged in (and possibly specifying their own decentralized node endpoint), but also allow the use-case that you are requesting.


Bump xterm to 2.0.1

update confirmed by @GermanBluefox at 6.11.2023 by telegram

2.0.1 created 18.09.2023
58 user
OK


[INTERNAL] LocatorResourcePool: pass through constructor arguments

ignoreMissingModules parameter is passed along now when creating
a new LocatorResourcePool

Coverage remained the same at 92.578% when pulling 5795d482440206023f3d60123c1a0a36ceec7017 on locator-resource-pool-ctor-params into 7416a973977995e9f65913cb4d02156d1281505a on master.


Cannot repartition dataframe with TZ-aware datetime64 index

What happened:
Repartitioning a dask dataframe indexed with a TZ-aware datetime index of type 'datetime64[ns, UTC]' fails with: TypeError: Cannot interpret 'datetime64[ns, UTC]' as a data type
What you expected to happen:
Repartitioning should work as expected with the TZ-naive index.
Minimal Complete Verifiable Example:
from datetime import datetime, timedelta
import dask.dataframe

# Create some test data with a naive datetime index
vals = range(10)
dts = [datetime(2020,1,1,12,0) + timedelta(minutes=x) for x in l]
idx = pd.to_datetime(dts, utc=False)
s = pd.Series(vals, idx)

# Turn into dask dataframe
ddf = dask.dataframe.from_pandas(s, npartitions=1)

# This works as expected
ddf.repartition(5)

# Let's convert the index to a TZ-aware datetime index with TZ set to UTC
ddf.index = dask.dataframe.to_datetime(ddf.index, utc=True)

# No trouble so far
ddf.head()

ddf.repartition(3)
TypeError: Cannot interpret 'datetime64[ns, UTC]' as a data type

Anything else we need to know?:
Full error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_3646785/374576154.py in <module>
     17 ddf.index = dask.dataframe.to_datetime(ddf.index, utc=True)
     18
---> 19 ddf.repartition(3)

~/.conda/envs/dwc2/lib/python3.9/site-packages/dask/dataframe/core.py in repartition(self, divisions, npartitions, partition_size, freq, force)
   1317             return repartition_size(self, partition_size)
   1318         elif npartitions is not None:
-> 1319             return repartition_npartitions(self, npartitions)
   1320         elif divisions is not None:
   1321             return repartition(self, divisions, force=force)

~/.conda/envs/dwc2/lib/python3.9/site-packages/dask/dataframe/core.py in repartition_npartitions(df, npartitions)
   6977         original_divisions = divisions = pd.Series(df.divisions)
   6978         if df.known_divisions and (
-> 6979             np.issubdtype(divisions.dtype, np.datetime64)
   6980             or np.issubdtype(divisions.dtype, np.number)
   6981         ):

~/.conda/envs/dwc2/lib/python3.9/site-packages/numpy/core/numerictypes.py in issubdtype(arg1, arg2)
    417     """
    418     if not issubclass_(arg1, generic):
--> 419         arg1 = dtype(arg1).type
    420     if not issubclass_(arg2, generic):
    421         arg2 = dtype(arg2).type

TypeError: Cannot interpret 'datetime64[ns, UTC]' as a data type

Environment:

Dask version: 2022.2.1
Python version: 3.9.9
Operating System: Linux Centos 8
Install method (conda, pip, source): conda

I think the key issue is that timezone-aware datetime64 dtypes are a feature of Pandas which is not supported by NumPy.
Here is the relevant Pandas documentation:
https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#timeseries-timezone-series
Trying to interpret the dtype from numpy will result in an error.
One workaround would be to only support UTC and apply .to_numpy(dtype="datetime64[ns]") are explained in documentation above. This will convert to UTC and remove timezone information making the array usable by numpy.

Yeah, this is the same issue as https://github.com/dask/dask/issues/8779 , our partitioning code needs to be updated to work with the pandas custom dtypes.

Yeah, this is the same issue as #8779 , our partitioning code needs to be updated to work with the pandas custom dtypes.

Thanks @jcrist and @jaj42! I closed #8779 since we can address the larger issue of updating the partitioning code (specifically percentiles_summary) to work with both pandas "string" and pandas datetime here.
Maybe we could edit the title of this issue to something like "Update partitioning to work with custom pandas dtypes"?

Possible duplicate of this issue by @mrocklin . Should we close that one and favor this one, or vice-versa?


not working for http & https

tried the configuration but not working for http & https
Error for http:
div id="content">
The following error was encountered while trying to retrieve the URL: http://httpbin.org/

Access Denied.

Access control configuration prevents your request from being allowed at this time. Please contact your service provider if you feel this is incorrect.
Your cache administrator is webmaster.

Generated Sat, 13 Jul 2019 12:05:14 GMT by 8f8b721ec41c (squid/3.5.27)

Error msg during https:
macpros-MacBook-Pro:~ macpro$ curl -x https://<IP_ADDRESS>:3128/ https://github.com/ -v

Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 3128 (#0)
ALPN, offering h2
ALPN, offering http/1.1
Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
successfully set certificate verify locations:
CAfile: /etc/ssl/cert.pem
CApath: none
TLSv1.2 (OUT), TLS handshake, Client hello (1):
error:1400410B:SSL routines:CONNECT_CR_SRVR_HELLO:wrong version number
Closing connection 0
curl: (35) error:1400410B:SSL routines:CONNECT_CR_SRVR_HELLO:wrong version number

*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to host.docker.internal (<IP_ADDRESS>) port 3128 (#0)
> GET http://github.com/ HTTP/1.1
> Host: github.com
> User-Agent: curl/7.58.0
> Accept: */*
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 403 Forbidden
< Server: squid/3.5.27
< Mime-Version: 1.0
< Date: Mon, 17 Aug 2020 11:21:54 GMT
< Content-Type: text/html;charset=utf-8
< Content-Length: 3523
< X-Squid-Error: ERR_ACCESS_DENIED 0
< Vary: Accept-Language
< Content-Language: en
< X-Cache: MISS from 9d02f873de96
< X-Cache-Lookup: NONE from 9d02f873de96:3128
< Via: 1.1 9d02f873de96 (squid/3.5.27)
< Connection: keep-alive
<
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

<meta type="copyright" content="Copyright (C) 1996-2017 The Squid Software Foundation and contributors">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>ERROR: The requested URL could not be retrieved</title>

ERROR

The requested URL could not be retrieved

The following error was encountered while trying to retrieve the URL: http://github.com/

Access Denied.

Access control configuration prevents your request from being allowed at this time. Please contact your service provider if you feel this is incorrect.

Your cache administrator is <a href="mailto:webmaster?subject=CacheErrorInfo%20-%20ERR_ACCESS_DENIED&body=CacheHost%3A%209d02f873de96%0D%0AErrPage%3A%20ERR_ACCESS_DENIED%0D%0AErr%3A%20%5Bnone%5D%0D%0ATimeStamp%3A%20Mon,%2017%20Aug%202020%2011%3A21%3A54%20GMT%0D%0A%0D%0AClientIP%3A%20<IP_ADDRESS>%0D%0A%0D%0AHTTP%20Request%3A%0D%0AGET%20%2F%20HTTP%2F1.1%0AUser-Agent%3A%20curl%2F7.58.0%0D%0AAccept%3A%20*%2F*%0D%0AProxy-Connection%3A%20Keep-Alive%0D%0AHost%3A%20github.com%0D%0A%0D%0A%0D%0A">webmaster.

Generated Mon, 17 Aug 2020 11:21:54 GMT by 9d02f873de96 (squid/3.5.27)

* Connection #0 to host host.docker.internal left intact```

I was hoping that someone would have a ready solution, but I'm having this problem out of the box as well.

Same here.

Same issue. Please fix!

You might need to edit your squid.conf. Out of the box, squid comes configured to deny requests other than localhost (http_access deny all).
On a fresh install, squid does this so that a) your machine doesn't proxy everything from everybody to everywhere (aka the infamous "open proxy," a vestige of yesterday's internet), basically forcing you to take charge of the extremely powerful daemon that is squid. And, b) you're forced to edit squid.conf, or supply your own, changing http_access deny all to http_access allow all.


Question: Can someone tell me what I'm not doing correctly?

My ExAdminSample
This is a bare Phoenix app,I think I have followed the instructions to have ExAdmin working properly, but the page that I see is without style.
Thanks in advance

Follow the instructions added to your brunch-config.js file

Thanks @smpallen99, but I have followed the instructions and replaced the blocks for JavaScript and CSS.


Do not split runs on font scaling if the run is RTL

Summary of the Pull Request
Right now if we have a glyph that needs scaling amidst some that don't, we split the GlyphRun and only apply scaling as necessary. This is generally fine, but it shouldn't be done in RTL since splitting the GlyphRun causes directionality issues.

References
#538

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
In the process of working on this, I think I may have come up with the correct algorithmic idea for the Grand Fix for almost all RTL behavior: on the font fallback routine, if the run would be split by the index from the MapCharacters phase, try again and see if the fallback font can do the entire run. I have just been unable to create an object from the fallback font factory to run through the normal method with MapChars, so if you could point me in the right direction with DWrite that'd be great

Validation Steps Performed
Cat-ing. Generally speaking this means that RTL words will be intact though in reverse order when cat-ed, instead of just garbled arbitrarily.

Doing something like this will break any application that is designed to work with RTL text. Applications need to know that if they output a character at a particular coordinate, then that is where the character will be displayed. There are escape sequences an application can use to change the directionality of text, but if the terminal just starts moving characters around of its own accord, it will be impossible to work with.

@j4james are you critiquing my PR or the original behavior? My PR is about doing less reordering, not more.

Wait, I'm not sure about this. What is actually causing it to display incorrectly? Is this just the bidiLevel flag isn't copied to the new run when one is split?
I'm concerned about just opting-out of this codepath for RTL. That doesn't feel like the right answer here if it's still useful for LTR text.
Can you give a sample file or some sample text to this including screenshots?

@j4james are you critiquing my PR or the original behavior? My PR is about doing less reordering, not more.

It's possibly I'm just looking at it wrong, but my initial impression was that your PR was making things worse than they were before. If I output the character א followed the character ב, then I expect to see א in column 1 and ב in column 2.
This is my test case:
printf "א"; sleep 1; printf "ב"; printf "\n"

And this is what that looks like in the preview build:

However, with your PR merged, I'm now seeing those characters reordered as they are output, so א shifts to column 2, and ב ends up in column 1.

That said, I don't think the current behaviour is correct either. More complicated examples seem to do some weird reordering too. But this PR doesn't help with that, at least as far as I can tell.

@j4james that's not a bug, that's the feature!
Look at the sequence אב for a second. Hebrew is an RTL language, so the alef, א, should be to the right of bet, ב.
So your second example is actually exactly what the fix is meant to be.

@miniksa so @j4james has a nice example actually, here's as good example.
I took the Hebrew alphabet in four letter chunks (the Arabic alphabet with the whole connectivity thing is too hard to read here)
The left is the bugfixed version. You can see that it maintains the integrity of the four letter chunks, however, it makes that space in Cascadia Code, not in fallback, so it does split the GlyphRun. The rightmost is current behavior on Liberation Sans, a pretty crummy font which I only have for Hebrew support. You can see that that it behaves perfectly there without the fallback. The middle is present (i.e. not this fix) behavior under font fallback, and the order is just completely bogus.

For those who aren't familiar with the Hebrew alphabet, we could say that they effectively are (using letter number):
Left: 4321 8765 12-11-10-9 ....
Right: 22-21 20-19-18-17 16-15-14-13 ...
Middle: 1432 5768 9-12-11-10 13-14-15-16 17-18-19-20 21-22

For reference, here's what it looks like in conhost, which is technically the correct order, i.e. 1234 5678 9-10-11-12 ...

So while the middle version is clearly not right, it's probably the least broken of the three. At least some of the chunks are in the right order.
For a Hebrew speaker, the left version may appear to be more correct, because it's displaying the chunks in their correct language order, but that's not something the terminal should be trying to do - that's the application's responsibility.

No, ConHost is the wrong order since unlike ConHost WT aims (not at high priority, but aims) to support RTL. You can see in the linked issue.
The right version is the correct one for any application which supports RTL.

If you think this is the correct solution for RTL, I invite you to try editing a line of Hebrew text in vi, or even just the command line. For example, start by enter אגדהוזח and then try to insert ב between the א and the ג. Let me know how many keystrokes it takes before you give up and just delete the whole line to start from scratch.
I'm not a Hebrew speaker (or any other bidirectional language for that matter), so this isn't going to effect me either way. But I've written enough bidirectional software to know that this approach will complete break any real bidi applications. And while it may sometimes give the appearance of "fixing" applications that aren't bidi-aware, it won't do that very well, and in the process will break a whole lot of other things.

You're absolutely correct that editing something in Vim is extremely nutty. However, a few things to keep in mind:

It's already totally broken. It's a nightmare under all circumstances. And I tried your challenge out, and it's much much better when we're in the native font zone and not the fallback zone.
The approach of 'just print all the characters in reverse order' could sometimes let you hack something through in Hebrew, but that's fundamentally impossible with Arabic where it needs to be drawn as the words actually are.
That'd also necessitate a major change since we'd need to say that we now split every individual RTL to its own GlyphRun.
I think you're missing a lot here. As a developer whose primary language is English but works on Hebrew and Arabic NLP projects, I am well aware that I cannot expect a decent CLI editor for RTL text. Much more likely is that I'm peeking in on a file and then I can make out what it says. Or lets say I'm using some corpus dump and there are Hebrew file names. Let's take this little example.
For reference, the name of the folder is תיקייה-עם-שם-בעברית-אבגד.
Current Behavior with Font Fallback:

Current Behavior, Hebrew Supported Font:

So while you argue that it doesn't do it well enough, I actually have three different profiles for Ubuntu in my WSL. Ubuntu, UbuntuHeb, and UbuntuAR. Because the RTL support when we're not glitching on fallback is actually to my taste very good, and it's really useful.
5. Lastly, if we want to address Bidi editing, the way to do that isn't to scramble the ordering of the text stream, it's to have the cursor jump around to the correct place in the stream. That's how every decent Bidi editor does it.

Under the PR, this specific use case with ls by the way, is not perfect like the example on the bottom, but better.

I'm concerned about just opting-out of this codepath for RTL. That doesn't feel like the right answer here if it's still useful for LTR text.

@miniksa I would formulate the case as follows: this codepath is generally beneficial since a single massive oversize character doesn't make everything else in the GlyphRun tiny. However, this is isn't worth it when splitting a GlyphRun has 'side effects', like it does with Bidi here. The scaling cases aren't worth the price of garbling the order, and any very unusually sized character like emoji is probably going to be a different BidiLevel anyway. It's really about the side effects that it has with the layout more than anything else.
(I say generally beneficial since in cases where you have a lot of LTR font fallback, like if you're trying to copy Cherokee into the terminal, when every glyph has a different scale the ransom-note aspect of the sizing maybe isn't ideal.)

OK two thoughts here:

The correction algorithm probably shouldn't be "ransomnote"ing any fallback font run. Perhaps what it should be doing is identifying a scale factor that is appropriate for the entire font/run instead of splitting the runs further.
I feel like a 1 run, 7 RTL characters and 7 runs, 1 RTL character each should both display properly (with all other properties being the same like scale factor). There must be something missing in the rendering portion that could be taught to account for RTL.

I think fixing either of those would also result in the same visual correction as your currently proposed fix while also getting deeper into the root of other related issues at the same time.

OK two thoughts here:

The correction algorithm probably shouldn't be "ransomnote"ing any fallback font run. Perhaps what it should be doing is identifying a scale factor that is appropriate for the entire font/run instead of splitting the runs further.
I feel like a 1 run, 7 RTL characters and 7 runs, 1 RTL character each should both display properly (with all other properties being the same like scale factor). There must be something missing in the rendering portion that could be taught to account for RTL.

I think fixing either of those would also result in the same visual correction as your currently proposed fix while also getting deeper into the root of other related issues at the same time.

A further thought on 2... if I were to have 7 RTL characters in a row in a stock IDWriteTextLayout from the DWriteFactory and I assigned a different color to each one... I would expect internally that it had to break it into 7 runs with a different brush per run to draw that. So it must know how to compensate the origins for adjacent RTL runs and we probably have just not handled that yet in CustomTextLayout or CustomTextRenderer

For another example of software that will be broken by this PR, below are screenshots of VIM in Hebrew mode (i.e. vim -H), first in conhost and then in Windows Terminal with this PR applied. In both case I've just typed in the Hebrew alphabet, in four character chunks. Note how the Windows Terminal version has incorrectly reordered each chunk. Hebrew users will not thank you for this.
The current Windows Terminal implementation isn't right either, but if you want to fix that, you need to match the conhost behaviour.

So, this touches a bit on what it means to have host or guest-controlled BiDi, and it's going to make problems ever more apparent. There's a large body of work related to how to handle RTL in terminal emulators, but very little consensus on whose job it is to do so.
It looks like vim's Hebrew mode (which I didn't know existed!) prefers to handle RTL itself... but detecting what an application's intent is when it puts RTL text in the buffer is going to be nigh-unto impossible. ☹

detecting what an application's intent is when it puts RTL text in the buffer is going to be nigh-unto impossible. ☹

This is exactly what I've been trying to say. This is not a problem that the terminal can solve. And I don't believe the VTE proposal is any better. The best thing a terminal can do is stay out of the way, and let the applications handle the issue themselves (like VIM's Hebrew mode as one example).
That said, there are cosmetic UI enhancements that a terminal could add to make things less painful when working with bidi-unaware applications. For example, a toggleable "mirror mode". which simply flips the entire screen. Or something like a bidi IME, that allows you to enter RTL text and have it pasted into the terminal in reverse order. I'd recommend looking at early Hebrew terminals and terminal emulators to see how they handled this sort of thing.

No, staying out of the way is a cop-out. I care a million times more about having ls work for me than I do about having vim.

You've only given one example of something that doesn't work, and that's vim -H. And I don't dispute that, but it doesn't work now either. And 100% we should break it so that everything else works. Because everything else in ConHost Hebrew is absolutely 100% unusable without mentally reading everything precisely backwards.

I wanna be clear. The ConHost behavior is unbearable. cat doesn't work. ls doesn't work. I actually use Hebrew. You can see from the original issue and the way people have commented on thread #538 that nobody really wants the ConHost behavior in place.
So yeah, vim -H doesn't work and I don't care. But as for "Hebrew users" -- I am one. I have special profiles for fonts that support glyphs because I <3 the current RTL behavior when it doesn't run into font issues. Seriously. Because really, honest to god, 90% at least of my actual, real world, my student job doing Hebrew & Arabic NLP thingies do work.

@miniksa that's a really good point. I guess we could essentially put in a for loop to reorder the thingy in _DrawGlyphRuns?
if run is ltr: draw normally
else:
    from last consecutive rtl run to the present run draw the run (note the reversed order)
    advance to past the last consecutive rtl run

I understand the need to make ls and cat work better with RTL languages - I'm very much in favour of fixing that. I'm just saying that it would be preferable if we could solve that problem in a way that doesn't break every other RTL application in existence, even if you don't personally use any of them.
Anyway, I've made my point. I'm not directly effected by this so I'll stay out of the discussion from now on. You guys can decide however you want to address the issue.

I wonder if it might be most appropriate to simply offer a config flag? experimental.rendering.rtlLanguageIsGuestManaged or something would be our escape hatch for vim -H or -A or -F...
I hate that there's no way for us to detect that the guest wants to handle it itself right now, and we have to support both cases relatively "seamlessly".

I wonder if it might be most appropriate to simply offer a config flag?

FWIW, most terminals that try to do something clever with RTL will have an option or escape sequence to turn that behaviour off.

I mentioned this on the other PR, I agree that that's appropriate, and the behavior should be implemented by just marking every run as ltr if the flag is set. That'd cause the equivalent behavior.

I like taking @DHowett's flag and applying it to the @schorrm behavior of putting all the bidiLevel flags on the runs back to 0 if it's turned on.

With the generalized fix that came in #7190, I think this PR is partially obsolete. I think it's a good idea to take this idea of the uniform scaling (especially?) in the case of font fallback, but there's no reason that it should be unique to RTL anymore. So I think it makes sense to close this PR (after completing some discussion items here) and open a ransomnoting specific PR, as well as one for the flag described.

@DHowett can you give me an outline of the code for making a new JSON flag? Also, once we're doing that flag, I think we might as well allow a flag to force all RTL (set all bidiLevel to 1). Rare use cases, but if we're already going through that part of code flow, might as well. I would suggest the names experimental.rendering.forceLTR and experimental.rendering.forceRTL.
I don't have any real insight into determining optimal font scale splitting in general. However, one observation is that with fallback, when it rains, it pours. I think it's reasonable to assume in most fallback cases that it won't just be one glyph that gets resized, and rather the whole run is going to get ransomnoted. And perhaps, like the ultimate RTL fix in #7190, this might make sense to analyze across multiple runs.

Closing this, and I'll try and touch on the action items separately.


godog command is on error with go modules and sub-packages

With go 1.11 and the environment variable GO111MODULE enabled, the godog command is on error and fails to compile the testmain because the path used as import path is not the good one (only the module path is used).
Example of result when godog is called from the directory module/qa:
failed to compile testmain package: exit status 2 - output: /var/folders/6c/k20xl1c17735407tz10y6xs80000gn/T/go-build466142923/b001/_testmain.go:5:2: can't find import: "module"
I hope it helps, I have also fixed some lints.

Codecov Report

Merging #138 into master will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   79.52%   79.61%   +0.08%
==========================================
  Files          17       17
  Lines        2589     2595       +6
==========================================
+ Hits         2059     2066       +7
+ Misses        380      377       -3
- Partials      150      152       +2

Impacted Files
Coverage Δ

utils.go
50% <ø> (ø)
:arrow_up:

fmt_cucumber.go
98.54% <ø> (ø)
:arrow_up:

fmt.go
91.85% <100%> (-0.09%)
:arrow_down:

suite.go
88.88% <100%> (+0.62%)
:arrow_up:

fmt_junit.go
94% <25%> (-1.92%)
:arrow_down:

builder_go110.go
59.72% <65.51%> (+1.9%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c35207...479842c. Read the comment docs.

Hi @rvflash , thanks, I will check this properly in few days

Hi @l3pp4rd, thanks.
I had to make a new modification after a last test with a go.mod file inside the GOPATH.
Not sure this is the best way to do it, the go/build package lacks means to deal with modules.
At your disposal if needed,

merging it for now, later will need to create proper build tests, but do not worry about it

could you also give an example of this module subpackage build failure? is it a case when you have lets say a module at /tmp/module and a subpackage in /tmp/module/sub which was not building properly before?


non-proxy-hosts-pattern is ignored

I have tried to specify proxy server and list of exclusions.
spring:
  cloud:
    gateway:
      httpclient:
        proxy:
          host: *.*.*.*
          port: 80
          non-proxy-hosts-pattern: '(localhost|<IP_ADDRESS>)'

However, Gateway still tries to reach <IP_ADDRESS> through the proxy server.
Spring Cloud Gateway 2.1.0.M1

non-proxy-hosts-pattern is a java regular expression. That value is passed directly to the reactor-netty class. The test I see for it only provides a single value.
https://github.com/reactor/reactor-netty/blob/d0480d110462d13aaf397acd51ee874fd0bd82ae/src/test/java/reactor/netty/http/client/HttpClientProxyTest.java#L102-L120
My guess is the regex is not correct.
Maybe @violetagg might now better.

@VladimirKravtsov works OK for me. Can you try with the mentioned test above and you regex?

Dears @spencergibb, @violetagg,
I guess the issues is there. Please, find my explanations here https://github.com/reactor/reactor-netty/issues/523


Yarn package upgrade

Should fix the dependabot security alert. We're not using that bit, but still better to do it!

My word, a 5.7k line dependency lock file 🤪

Yea 😬
Also, it didn't fix the alert because parcel is locked on an old version of the vulnerable package. There's a new major version of parcel, which will hopefully move that dependency forward too. We're still not using the vulnerable dependency in any meaningful way though, so it's all good.


Add python 3.4 and 3.5 to travis-ci builds

Closes-Issue: #63

Coverage decreased (-1.7%) to 95.25% when pulling e9447c14a80737e163d765cfe64c53f7bcf75bcc on quintusdias:issue63 into 8c7b6ca1feb3d1b33c65a5df6de22b50efef66d4 on python-xmp-toolkit:devel.


Clip msa

Refactor geo endpoint to query for polygons that intersect with the screen as a polygon.

Coverage remained the same at 80.57% when pulling c7bf2b21b237bd2454e48791d0e311e14025672a on mehtadev17:clip_msa into 96c0eb89d3ec8dcef5b4737e2a021337b594522d on cfpb:master.

Coverage remained the same at 80.55% when pulling 580eef317a9ef9240c1ddedcabf1dd37d5050d4b on mehtadev17:clip_msa into 96c0eb89d3ec8dcef5b4737e2a021337b594522d on cfpb:master.

:+1:


docs: fix assume reference link in fuzz testing docs

fix link to assume in fuzz testing docs.

@all-contributors add @anticlimactic for maintenance


fix test declaration

Fixes test declaration to use shapes rather than length.

Build triggered. sha1 is merged.

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/295/

Build finished. No test results found.


French Blazor documentation "éblouissant"

There are still pages in the French documentation that says "éblouissant" instead of Blazor (again, for instance, the Italian documentation does not have this problem).

https://docs.microsoft.com/fr-fr/dotnet/architecture/blazor-for-web-forms-developers/introduction
https://docs.microsoft.com/fr-fr/dotnet/architecture/blazor-for-web-forms-developers/project-structure

@JasonCard, Do you think the no-loc extension should be used? or there is something to be done in the localization system to always completely prevent "Blazor" from being localized? I think it might be tedious and noisy to add Blazor to no-loc everywhere.

@Youssef1313 Yes, I'd recommend to use the no-loc custom metadata. for "Blazor" to resolve this issue. That's currently the best way to avoid over-localization of terms.


fix(union_serializer): do not raise warnings in nested unions

In case unions of unions are used, this will bubble-up the errors rather than warning immediately. If no solution is found among all serializers by the top-level union, it will warn as before.
fixes https://github.com/pydantic/pydantic/issues/10682

[x] Unit tests for the changes exist
[x] Documentation reflects the changes where applicable
[x] Pydantic tests pass with this pydantic-core (except for expected changes)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

Hello @sydney-runkle , could you please review ? I believe that this would fix https://github.com/pydantic/pydantic/issues/10682 , but I'd like to know what you think about the approach taken here before I adress the missing coverage :slightly_smiling_face:
Also, I'm sitting in a train with bad wifi so I can't clone the pydantic repo to run the tests right now, but I'll do it asap

Update: pydantic tests still pass with this change

Hi @lukapeschke, thanks for the PR here.
I took a look at your original issue https://github.com/pydantic/pydantic/issues/10682 and I could still reproduce it on this branch. I sort of see the motivation for the change here and I think it might be ok, but;

in general this is adding even more complexity to the union pathways
in this case your issue is fixed by #1530

the whole serializer warning system is due an overhaul, so I'm reluctant to add the complexity here.

Hi @davidhewitt thanks for the reply!
The bug I'm encountering was actually a different one. At first glance I thought it was the same as https://github.com/pydantic/pydantic/issues/10682 but it's not, my bad. I'll unlink the issue.
Below is an MRE for the problem I have, it's the same as the one described in the unit tests. I tested your branch, but the problem is still there.
What would be your preferred way to solve this ? Should I open a different issue in the pydantic repo ? Could you include a fix in your PR if  you have an easier one ? If not, I'm also happy to rewrite this if you have a simpler idea in mind, as I'm not very familiar with the pydantic codebase.
Let me know what you'd prefer :slightly_smiling_face:
from pydantic import BaseModel, TypeAdapter, Field
from typing import Literal, Annotated

class A(BaseModel):
    a: str

class B(BaseModel):
    b: str

class Animal(BaseModel):
    type_: str = Field(alias="type")

class Dog(Animal):
    type_: Literal["dog"] = Field("dog", alias="type")

class Cat(Animal):
    type_: Literal["cat"] = Field("cat", alias="type")

type Letter = A | B
type Animal = Cat | Dog

class MyModel(BaseModel):
    elems: list[Animal | Letter]

# prints {'elems': [{'type_': 'dog'}]}
print(MyModel(elems=[{"type": "dog"}]).model_dump(warnings="error"))
# I expect this to print {'elems': [{'a': 'a'}]}, but it raises an error
print(MyModel(elems=[{"a": "a"}]).model_dump(warnings="error"))

@davidhewitt Thanks a lot for the pointers! Indeed, by only checking extra.check, the code is simpler, the PR is almost only tests now. I've added tests for json_key as well, but I've not been able to make serde_serialize fail, so I haven't touched its implem. I guess it is because the function itself is not recursive, but relies on to_python instead ?
Could you please re-review ? Pydantic's tests are still passing with this new version.


Hazeel Cult (Siding with Hazeel)

When you've done the part of poisoning the cooking range, you should get upstairs and talk to Ceril again. This is not mentioned in the quest helper guide.

+1, I also ran into this same issue


Exposing GarbageCollection (GC) in ch binary

Hey, is there an easy way to expose GC from withing a script in ch?
I'd like to run a js script that contains a statement - 'gc();'
and that this statement will run a GC cycle.

 You can construct a javascript wrapper function around that and expose it on the global object if you want.

I'll add a bit more info, sorry.
I'm fuzzing the js engine via the ch.exe binary.
my inputs are using the gc() function from js.
I'd like to do the minimal required changes to let the ch.exe expose the GC from js.
For example, in JavaScriptCore, V8 and SpiderMonkey it's supported with runtime flags or compilation flags.
If it's not supported in Chakra's builtin example - 'ch.exe', could you please point me to an example that adds a native function? i'll take off from there.
Thanks for your help!

Ah, I see. If you are using a debug or test ch.exe binary, then if you pass it the -collectgarbage command line argument, then it will expose a global CollectGarbage() function which triggers a garbage collection.


[Enhancement] Use a variable instead of a fixed number

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
In eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java
In the method initHttpClientPool()
At line 253
The number of loops should not be fixed

Describe the solution you'd like
Maybe you could use a new variable instead of a fixed number
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Hey, I would like to pick this.


[FEAT] "tap to top" when tapping top right of status bar for vertical pagers

Is your feature request related to a problem? Please describe.
For vertical pagers, I'd love a modifier that lets me enable "tap to top" as is seen in other vertically scrolling/feed-based apps.
Describe the solution you'd like
An opt-in modifier to enable tapping on the top-right of the status bar to animate the vertical pager back to index 0.
Describe alternatives you've considered
Just manage it with the index state myself.

Hi @garrettmaring , please see this answer and let me know if it makes sense


Refine the List builder

Which issue does this PR close?

None.
Rationale for this change

remove the field GenericListBuilder::len, as it is always equal to the bitmap length.
refine the doc and test.
move the test of binary builder and string builder to their own files.

What changes are included in this PR?

Are there any user-facing changes?
No.

Codecov Report

Merging #2034 (64f3bd6) into master (ef02bf8) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
+ Coverage   83.44%   83.54%   +0.10%
==========================================
  Files         222      222
  Lines       57979    58185     +206
==========================================
+ Hits        48378    48610     +232
+ Misses       9601     9575      -26

Impacted Files
Coverage Δ

arrow/src/array/builder/generic_binary_builder.rs
83.78% <100.00%> (+26.64%)
:arrow_up:

arrow/src/array/builder/generic_list_builder.rs
95.06% <100.00%> (-1.64%)
:arrow_down:

arrow/src/array/builder/generic_string_builder.rs
92.13% <100.00%> (+10.08%)
:arrow_up:

arrow/src/array/equal_json.rs
87.89% <0.00%> (-1.81%)
:arrow_down:

arrow/src/array/array_decimal.rs
91.11% <0.00%> (-1.77%)
:arrow_down:

arrow/src/datatypes/field.rs
54.59% <0.00%> (-1.29%)
:arrow_down:

parquet/src/file/properties.rs
95.04% <0.00%> (-0.73%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.75% <0.00%> (-0.23%)
:arrow_down:

parquet/src/arrow/record_reader/mod.rs
89.17% <0.00%> (-0.19%)
:arrow_down:

arrow/src/datatypes/datatype.rs
65.68% <0.00%> (-0.12%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef02bf8...64f3bd6. Read the comment docs.


torchrun --nproc_per_node=4 /data/zxb/DINO_FL/train/train.py

[rank0]:[E ProcessGroupNCCL.cpp:1316] [PG 0 Rank 0] Heartbeat monitor timed out! Process will be terminated after dumping debug info. workMetaList_.size()=1
[rank0]:[E ProcessGroupNCCL.cpp:1153] [PG 0 Rank 0] ProcessGroupNCCL preparing to dump debug info.
[rank0]:[F ProcessGroupNCCL.cpp:1169] [PG 0 Rank 0] [PG 0 Rank 0] ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives. This typically indicates a NCCL/CUDA API hang blocking the watchdog, and could be triggered by another thread holding the GIL inside a CUDA api, or other deadlock-prone behaviors.If you suspect the watchdog is not actually stuck and a longer timeout would help, you can either increase the timeout (TORCH_NCCL_HEARTBEAT_TIMEOUT_SEC) to a larger value or disable the heartbeat monitor (TORCH_NCCL_ENABLE_MONITORING=0).If either of aforementioned helps, feel free to file an issue to PyTorch about the short timeout or false positive abort; otherwise, please attempt to debug the hang. workMetaList_.size() = 1
[rank1]:[E ProcessGroupNCCL.cpp:1316] [PG 0 Rank 1] Heartbeat monitor timed out! Process will be terminated after dumping debug info. workMetaList_.size()=1
[rank1]:[E ProcessGroupNCCL.cpp:1153] [PG 0 Rank 1] ProcessGroupNCCL preparing to dump debug info.
[rank1]:[F ProcessGroupNCCL.cpp:1169] [PG 0 Rank 1] [PG 0 Rank 1] ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives. This typically indicates a NCCL/CUDA API hang blocking the watchdog, and could be triggered by another thread holding the GIL inside a CUDA api, or other deadlock-prone behaviors.If you suspect the watchdog is not actually stuck and a longer timeout would help, you can either increase the timeout (TORCH_NCCL_HEARTBEAT_TIMEOUT_SEC) to a larger value or disable the heartbeat monitor (TORCH_NCCL_ENABLE_MONITORING=0).If either of aforementioned helps, feel free to file an issue to PyTorch about the short timeout or false positive abort; otherwise, please attempt to debug the hang. workMetaList_.size() = 1
[rank3]:[E ProcessGroupNCCL.cpp:1316] [PG 0 Rank 3] Heartbeat monitor timed out! Process will be terminated after dumping debug info. workMetaList_.size()=1
[rank3]:[E ProcessGroupNCCL.cpp:1153] [PG 0 Rank 3] ProcessGroupNCCL preparing to dump debug info.
[rank3]:[F ProcessGroupNCCL.cpp:1169] [PG 0 Rank 3] [PG 0 Rank 3] ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives. This typically indicates a NCCL/CUDA API hang blocking the watchdog, and could be triggered by another thread holding the GIL inside a CUDA api, or other deadlock-prone behaviors.If you suspect the watchdog is not actually stuck and a longer timeout would help, you can either increase the timeout (TORCH_NCCL_HEARTBEAT_TIMEOUT_SEC) to a larger value or disable the heartbeat monitor (TORCH_NCCL_ENABLE_MONITORING=0).If either of aforementioned helps, feel free to file an issue to PyTorch about the short timeout or false positive abort; otherwise, please attempt to debug the hang. workMetaList_.size() = 1
W0725 08:32:26.101000<PHONE_NUMBER>04544 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 651734 closing signal SIGTERM
/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 32 leaked semaphore objects to clean up at shutdown
warnings.warn('resource_tracker: There appear to be %d '
/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 32 leaked semaphore objects to clean up at shutdown
warnings.warn('resource_tracker: There appear to be %d '
E0725 08:32:28.020000<PHONE_NUMBER>04544 torch/distributed/elastic/multiprocessing/api.py:826] failed (exitcode: -6) local_rank: 0 (pid: 651732) of binary: /home/zhuxiaobo/anaconda3/envs/my_pytorch_env/bin/python
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/launch.py", line 198, in
main()
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/launch.py", line 194, in main
launch(args)
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/launch.py", line 179, in launch
run(args)
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/run.py", line 870, in run
elastic_launch(
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/zhuxiaobo/anaconda3/envs/my_pytorch_env/lib/python3.11/site-packages/torch/distributed/launcher/api.py", line 263, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
/data/zxb/DINO_FL/train/train_stage.py FAILED
Failures:
[1]:
time      : 2024-07-25_08:32:26
host      : user
rank      : 1 (local_rank: 1)
exitcode  : -6 (pid: 651733)
error_file: <N/A>
traceback : Signal 6 (SIGABRT) received by PID 651733
[2]:
time      : 2024-07-25_08:32:26
host      : user
rank      : 3 (local_rank: 3)
exitcode  : -6 (pid: 651735)
error_file: <N/A>
traceback : Signal 6 (SIGABRT) received by PID 651735
Root Cause (first observed failure):
[0]:
time      : 2024-07-25_08:32:26
host      : user
rank      : 0 (local_rank: 0)
exitcode  : -6 (pid: 651732)
error_file: <N/A>
traceback : Signal 6 (SIGABRT) received by PID 651732

I encountered the same issue as you. May I ask if your problem has been resolved? I look forward to your reply.

ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives.

One of the processes got stuck while waiting on a collective operation (all_gather etc.). It's likely a problem on your side rather than the code in the repo. It's also hard to debug without seeing the code and the python environment.
Troubleshooting tips:

Write a mini script that simply initializes distributed and runs some collectives to check that your GPUs can talk
Make a list of all modifications made on top of the provided code, check that all new collectives are executed in the same order on all ranks
Ensure that the modified code runs on a single GPU
Follow https://pytorch.org/docs/master/distributed.html#debugging-torch-distributed-applications

请问解决了吗


Maybe unsound in SkBuff

hello, thank you for your contribution in this project, I am scanning the unsoundness problem in rust project.
I notice the following code:
pub struct SkBuff {
    pub skb: *mut __sk_buff,
}

impl SkBuff {
    pub fn new(skb: *mut __sk_buff) -> SkBuff {
        SkBuff { skb }
    }

    #[allow(clippy::len_without_is_empty)]
    #[inline]
    pub fn len(&self) -> u32 {
        unsafe { (*self.skb).len }
    }
............................
}

Considering that programs is a pub mod and skb is a pub field, I assume that users can directly manipulate this field, and that len is a public function. This potential situation could result in self.skb being a null pointer, and directly dereferencing it might trigger undefined behavior (UB). For safety reasons, I felt it necessary to report this issue. If you have performed checks elsewhere that ensure this is safe, please don’t take offense at my raising this issue.
Sorry, I can't provide a Poc, because trying to import SkBuff in my environment will get an error:
error[E0432]: unresolved import `aya::programs::SkBuff`
 --> src/main.rs:3:5
  |
3 | use aya::programs::SkBuff;
  |     ^^^^^^^^^^^^^^^^^^^^^ no `SkBuff` in `programs`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `lwz` (bin "lwz") due to 1 previous error

If this can be solved, I am happy to provide a Poc.

same problem for https://github.com/aya-rs/aya/blob/5a43bedc0180ba41854e6c23f0476c2cbeb1e2bd/ebpf/aya-ebpf/src/programs/sk_msg.rs#L9

and maybe same problem for
pub struct ProbeContext {
    pub regs: *mut pt_regs,
}

impl ProbeContext {
    pub fn new(ctx: *mut c_void) -> ProbeContext {
        ProbeContext {
            regs: ctx as *mut pt_regs,
        }
    }
    pub fn arg<T: FromPtRegs>(&self, n: usize) -> Option<T> {
        T::from_argument(unsafe { &*self.regs }, n)
    }
}

If we need fix it maybe we should add check for null pointer in new method too :)

I think the proper fix would be to use NonNull in context types and making sure it's a private field. We could provide as_ptr() -> *mut pt_regs (or whatever pointer type is wrapped by the given context) method for callers who want to do unsafe stuff with the context, or call some BPF helper directly.

A pull request is very welcome! :slightly_smiling_face: Your build error looks weird, but hard to debug for me, since it's your own project where you're using Aya as an external crate. Would you mind sharing the code, or at least Cargo.toml?
That said, I think our integration tests should be good enough for you to make and test the change just using the main Aya repo.

ofcourse, here is my main.rs:
extern crate aya;

use aya::programs::SkBuff;
fn main() {

}

and Cargo.toml:
[package]
name = "lwz"
version = "0.1.0"
authors = ["lwz"]
edition = "2018"

[dependencies]
aya = "0.13.1"

result:
error[E0432]: unresolved import `aya::programs::SkBuff`
 --> src/main.rs:3:5
  |
3 | use aya::programs::SkBuff;
  |     ^^^^^^^^^^^^^^^^^^^^^ no `SkBuff` in `programs`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `lwz` (bin "lwz") due to 1 previous error
lwz@LAPTOP-F68E79VH:/mnt/e/Github/lwz$

and https://github.com/aya-rs/aya/blob/1dfcfbcf90d4b01ec56c4bc236577857c1fb6753/ebpf/aya-ebpf/src/programs/sk_buff.rs#L263
I'm not sure if I've found all of these bugs, but it seems to be a common problem in this library. Maybe my program is underreporting. But that's probably all the cases I could find.

Yeah, if you find any other structs wrapping a raw pointer, it totally makes sense to ensure it's NonNull and private.

Considering this is a unsound problem and this crate is published on crates.io, I suggest maybe we should report it to RustSec?

Considering this is a unsound problem and this crate is published on crates.io, I suggest maybe we should report it to RustSec?

I doubt it. This crate (aya-ebpf) can only be compiled with nightly compiler targeting bpfeb-unknown-none and bpfel-unknown-none, which are Tier 3 platforms.


⚠ ClamAV has degraded performance

In 077f9ff, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 94 ms

Resolved: ClamAV performance has improved in 65f8f69 after 5 minutes.


panic: 'put' with an unexpected smaller revision

master 节点启动失败
日志报panic
Journal file<EMAIL_ADDRESS>is truncated, ignoring file.
--
-- A start job for unit k8e.service has begun execution.
--
-- The job identifier is 6442.
Jun 02 07:55:46 k8s-master-133 sh[7399]: + /usr/bin/systemctl is-enabled --quiet nm-cloud-setup.service
Jun 02 07:55:46 k8s-master-133 sh[7400]: Failed to get unit file state for nm-cloud-setup.service: No such file or directory
Jun 02 07:55:46 k8s-master-133 k8e[7403]: time="2023-06-02T07:55:46Z" level=info msg="Starting k8e v1.25.5+k8e1 (7f66e3d5)"
Jun 02 07:55:46 k8s-master-133 k8e[7403]: time="2023-06-02T07:55:46Z" level=info msg="Managed etcd cluster bootstrap already complete and initialized"
Jun 02 07:55:46 k8s-master-133 k8e[7403]: time="2023-06-02T07:55:46Z" level=warning msg="Cluster CA certificate is not trusted by the host CA bundle, but the token does not include a CA hash.
--
-- The process' exit code is 'exited' and its exit status is 2.
Jun 02 07:55:46 k8s-master-133 systemd[1]: k8e.service: Failed with result 'exit-code'.
-- Subject: Unit failed
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- The unit k8e.service has entered the 'failed' state with result 'exit-code'.
Jun 02 07:55:46 k8s-master-133 systemd[1]: Failed to start Kubernetes Easy Engine.
-- Subject: A start job for unit k8e.service has failed
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A start job for unit k8e.service has finished with a failure.
--
-- The job identifier is 6442 and the job result is failed.

VERSION:
v1.25.5+k8e1 (7f66e3d5)

nm-cloud-setup.service: No such file or directory 重新安装节点后出现这个

VERSION: v1.25.5+k8e1 (7f66e3d)

我之前也发现这个问题。升级到v1.25.7+k8e1 for Security Upgrade，修复了此问题。
nm-cloud-setup.service: No such file or directory , 这个可以不用关注，你可以手工在 k8e.service 里面去掉这个

https://github.com/xiaods/k8e/pull/319  在安排文件中也优化去掉了nm-cloud-setup.service，

/close as resolved

升级完可以了


Handle Missing Email Error When Creating BC Services Card Accounts and Improve Email Logging

In rare cases, when creating a BC Services Card account, users may not have an email address associated with their account. This can result in a series of errors, as seen at 8:10 AM today. The current system assumes that an email is mandatory, but this is not always the case.

Potential Solution:
Error Handling: Implement error handling to catch scenarios where the user does not have an email. Ensure that these cases are properly logged.
Enhanced Logging: Add logs with a clear message such as email sent to ________ to make it easier to track when and where emails are being sent. This is already in place in the Names project and could be extended to this system as well.

low priority

@hanlunBCRegistries Who reviews your PR's

@PCC199 Normally Ethan does

@Maribeth-Wilson Can we push to production

@Maribeth-Wilson Can we push to production

has this been tested?


Enhanced Create contact page issue - 157

Related Issue or bug
Enhanced create contact page with css and bootstrap
Fixes: #157
Describe the changes you've made

Added Jumbotron
Edited width of form
Edited width of select box
Edited labels

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Run python manage.py runserver
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
Updated

original screenshot
updated screenshot

I have made the recommended change, please check now!

@zaverisanya Any updates?

@sakshikhachane  I will complete it by tonight!

I have made the recommended changes. Please check!

I have made the recommended changes. Please check! @swapnilsparsh

Sir, please elaborate the 2nd point, what exactly do you mean by 'adding illustrations'?

Sir, please elaborate the 2nd point, what exactly do you mean by 'adding illustrations'? @swapnilsparsh

Have a look at register page there you can see a illustration on your right side or you can google it.

@zaverisanya  Any updates ?

@zaverisanya  Any updates?


Optimize calls with new livestream APIs

Today:

we claim search channel ids based on /all api
we claim search past 2 claims and future claims to get scheduled / active

With new APIs:

they now return "active claim id" - so we can pass those directly into claim search, and don't need use limit claims = 2
they now return "future scheduled calims" - so no need to claim search with channel id for future - use those claim ids to show upcoming.

Need to test-  back to back streams that may go over time, late / early stream starts

Is it possible for the API to return the canonical_url as well?  That seems to be last piece of info that we need to eliminate the  claim_search call entirely right after fetching the livestream data.  Having that info would clean up the code a bunch -- we now need claim_search to store the uri for the rest of the code.
Unless I missed something, the livestream claims would later be resolved or batch-resolved naturally when things like ClaimTilesDiscover or ClaimPreview uses it anyway.  It's unfortunate the most of the GUI still uses uri.
Currently:
From API:
      "url": "https://cloud.odysee.live/content/01a51d9547b0a35575bc65e21a3e2e1dd9fee877/master.m3u8",
      "type": "application/x-mpegurl",
      "live": true,
      "viewCount": 101,
      "creatorId": "01a51d9547b0a35575bc65e21a3e2e1dd9fee877",
      "startedStreaming": "2022-06-16T13:38:06.000Z",
      "claimId": "c35e7ada8fbe99d3fe6f20ee2b32c959d6539ac9",
From claim_search:
      "claimUri": "lbry://@vogelshuisjes#0/live#c3"

We added canonical URL:
Also, we now have an api where you can pass channel claim ids to show all future claims: this will show all the future scheduled claims (if any), and only return live status for channel claim ids you pass:
https://api.odysee.live/livestream/subscribed?channel_claim_ids=745d1223c66aaaa810fd58241304ef54b28c95f2,c5b0b17838df2f6c31162f64d55f60f34ae8bfc6
We may not need to call all api on page load, and use this instead. But we'd still need to then call for each category (can use channel ids), and wild west (all)

Was replacing the claim_search with Active and canonical data ... then realized that we'll lose the ability to filter by language, which was being done through those claim_searches.
We actually still need to do 1 claim_search|resolve to batch-resolve the claims, so we could manually do the lang filter here after getting the claims, but that will be slower (but still acceptable I guess, since the count is currently ~50).
Or can we ignore language for livestreams?

Branch: optimize.live.calls

We ended up having to claim_search|resolve on the API results anyway to:

avoid individual resolves when displaying the tiles.
continue to support "search in language" in Category Pages (unless the API is updated to provide language info.

That final claim_search itself could be stalling, so things like the Following row in the homepage could still be stalling (back to original problem).
Brainstorming further action

API to provide language info, or better yet, ability to provide filtered results directly?
App side to de-prioritize the livestream claim resolves -- if data comes in late, just show the other claims immediately.

I can add language with the next batch of changes. Not sure about filtering by language up front - would be good for wild west, but not category or following (may follow / be in the category, but in a different language) right? We can discuss more...
We can consider adding all data, but maybe with a param.


Added cs locale

I added cs locale file for Czech Language

Great, thanks @vitkabele!

My first public commit :+1:


[Test: ignore] Validate one-way sync of issues to Linear

We use Linear internally to track issues. Creation of this r in GitHub tests the integration between GitHub and Linear. The sync moves in one direction; issues created in Linear will not automatically appear in GitHub.

Closing test issue


Remove Timers object from bdg-utils as it contains ADAM-specific timers

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/25/
Test PASSed.

Merged! Thanks for catching this @nfergu!


Migrate provider hub rules to azure-core and azure-resource-manager libs

steps for https://github.com/Azure/typespec-azure-pr/issues/4039

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-azure-resource-manager

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/235/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/235/


Add useRefetchableFragment and usePaginationFragment hooks

By bumping apollo-react-relay-duct-tape, now we are able to use useRefetchableFragment and usePaginationFragment hooks, but they weren't exposed by nova-facade. Therefore, the scope of this PR is to add these hooks, following the same signatures as graphitation.
In this scope, I did the following changes:

added both hooks to packages/nova-react/src/graphql/hooks.ts, where they used the same signature from graphitation: useRefetchableFragment and usePaginationFragment
for both hooks I call the implementation from the host app and return an error if it's not available, similar to other hooks
to have a typing consistency, I reuse the same types from graphitation, that were added to packages/nova-react/src/graphql/types.ts. Even if FetchPolicy is used for useLazyLoadQuery, it's not the scope of this PR to change options -> fetchPolicy type (it can be done in another one if it's required reusing the same FetchPolicy type definition. I chose to add these types in type.ts to keep hooks.ts as clean as possible.
updated the nova/types with the new nook definitions in packages/nova-types/src/nova-graphql.interface.ts
added unit tests in packages/nova-react/src/graphql/hooks.ts

Looks good, just awaiting confirmation that this has been verified to worked in usage.


[WIP] Rate limit middleware

Fix https://github.com/CartoDB/Windshaft-cartodb/issues/820

All features finished, ready to final CR.
Before merge it, we will need to make some changes:

change the test docker image --> we need to talk with infra about the best place to have the redis cell library and update it https://github.com/CartoDB/Windshaft/blob/rateLimits/Dockerfile
config parameters: we need to update the config params on cartodb-platform (example https://github.com/CartoDB/cartodb-platform/pull/3951/files)


Unpack commits from metadata in changes.sql

Related issue https://github.com/GoogleCloudPlatform/fourkeys/pull/132

FYI, I ran the e2e tests on this PR and those tests still pass. :)

Related issue https://github.com/GoogleCloudPlatform/fourkeys/pull/132


[ContextMenu] Add long press support for touch/pen

Closes #701
This PR adds support for long press to trigger opening ContextMenu with touch/pen.

I think this looks good, but I didn’t clone and test. My only suggestion would be to set -webkit-touch-callout: none as an inline style on the element to prevent the iOS “context menu” from appearing (this acts like calling preventDefault).

One edge case to watch out for is if the user puts two touch points down. It looks like handleOpen will be called twice, which is fine if it’s idempotent. Alternatively the context menu could cancel when a second touch point is added. I don’t have a strong preference, just wanted to mention the edge case.

Also with 2 touch points it looks like 2 timers are set but only 1 is tracked as a ref and cleared in useEffect, which might result in a bug.

Thanks @rafgraph, I'll check the double touch case. Instinctively I thought it'd be ok cause I'm using pointer events rather than touch events, but I'll check how it behaves.


ext_proc_integration_test is v flakey

//test/extensions/filters/http/ext_proc:ext_proc_integration_test       TIMEOUT in 1 out of 2 in 914.4s

https://dev.azure.com/cncf/envoy/_build/results?buildId=143656&view=logs&j=d1f76054-8f79-554b-6f4a-11d6a63b8e00&t=a193292f-96b1-53c3-0505-a923ddcc3f84&l=4790
Its been happening since yesterday

and is almost certainly from:
https://github.com/envoyproxy/envoy/pull/27812

cc @yanjunxiang-google @yanavlasov
i think we want to resolve this asap due to pending release - ie revert or fix forward

also seeing it on PRs

@phlax I think we can fix forward. This is the  PR: https://github.com/envoyproxy/envoy/pull/28574

Fixed in #28574


feat: Add CSharp SDK

FLI-783 - C# Server Side SDK

Add Authentication
Add Evaluation (Boolean, Variant, and Batch)

@markphelps I fixed the issues you mentioned. Since the srcWrong didn't show in Visual Studio, I forgot I removed it, but it must not have been deleted from the folder. Now, the header will be set by the strategy. As far as patterns for testing. Xunit is commonly used, similar to junit.
This might be more than what you want, but you can do something like this for the integration test
https://blog.devgenius.io/integration-testing-in-net-8-b8ab83e7531d
you can also use other integration testing tools like Selenium but I haven't set anything like that up.

@markphelps I fixed the issues you mentioned. Since the srcWrong didn't show in Visual Studio, I forgot I removed it, but it must not have been deleted from the folder. Now, the header will be set by the strategy. As far as patterns for testing. Xunit is commonly used, similar to junit.
This might be more than what you want, but you can do something like this for the integration test https://blog.devgenius.io/integration-testing-in-net-8-b8ab83e7531d
You can also use other integration testing tools like Selenium, but I haven't set anything up like that.
If you just need something similar to how the Java test is set up. I probably could knock that out tonight.

No pressure! But if you are able to that would be amazing! yeah the tests are very basic at the moment, the Java one is probably a good reference as you mentioned
basically it just depends on FLIPT_URL and FLIPT_AUTH_TOKEN.
If you are able to get something going I can take it and hook it up to our CI, as we use Dagger and getting it all wired up takes a bit of time.
But if not I can also take a stab at writing a test if you don't have the time. Regardless this contribution is much appreciated! We've been asked by several people to have a C# SDK and now we can say we've got one!! Thanks again @vgwizardx


Refactor the data migration code

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
Now that we have support for DBIterator and WALIterator, we can refactor migration code based on redis-command using these two classes. Also, now that we support two different migration types, we can make the code base about migration a bit cleaner than it is now.
The unit tests could also be clearer.
Solution
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi, i'm interested in this issue, could you please assign this to me?

@caipengbo Would you mind giving some input about what you plan to improve?

This is my personal opinion for reference only:

decouple the iteration logic from the send logic:

use DBIterator and WALIterator for data iteration
use a Sender helper class for sending data and rate limit

Make the two migration types more uniform
Refactor Golang unit tests about data migration to make them more concise and faster to run
Other minor change:

MigrationJob stores what is really needed
...

@wsehjk @git-hulk

@caipengbo Thanks for your input.

@git-hulk This is my personal opinion for reference only:

decouple the iteration logic from the send logic:

use DBIterator and WALIterator for data iteration
use a Sender helper class for sending data and rate limit

Make the two migration types more uniform

Refactor Golang unit tests about data migration to make them more concise and faster to run

Other minor change:

MigrationJob stores what is really needed
...

As @tisonkun said, you can also share some of your plans and we can discuss them together @wsehjk .

Thank you for the info, really helpful, and i will walk through the code and share my thought before developing


ARROW-10993: [CI][macOS] Fix Python 3.9 installation by Homebrew

https://github.com/apache/arrow/runs/1579780011#step:4:520
==> Pouring<EMAIL_ADDRESS>Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite<EMAIL_ADDRESS>
To list all files that would be deleted:
  brew link --overwrite --dry-run<EMAIL_ADDRESS>
Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/2.7/bin/2to3

+1


Introduce EP 5.4.1 & 5.4.2

Introduce two social proposals:

[5.4.1] [Social] Funding Request: ENS Meta-Governance Working Group Term 5 (Q1/Q2)
[5.4.2] [Social] Funding Request: ENS Public Goods Working Group Term 5 (Q1/Q2)

This issue has been resolved #218 #219


Naming Recommendation Article is incomplete. It is missing some Azure Resources

I appreciate the existence of naming recommendations; I think that can go a long way to helping people standardize on terminology. However, I was surprised to find that this article didn't include some of the Azure Resources that have been created as part of our solution (Storage Account, API Connection, Private DNS zone, Private endpoint). It also seems to recommend at least one prefix that not even Microsoft uses when automatically naming generated resources. For 'App Service Plan' the article recommends 'plan-' whereas Azure creates default App Service Plans with 'ASP-'. It would be helpful if an article like this was complete and up-to-date and new Azure resources are introduced as anything missing then allows for differences in how things are named.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c22eb33-2fde-55b4-021d-e229c857e51b
Version Independent ID: 1f767675-7d50-6ea5-b798-1323cd4a63a1
Content: Recommended abbreviations for Azure resource types - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/resource-abbreviations.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

In particular API Connection is what I need today. For now I will go for apicon.

@jeffwessling - Thanks for the feedback! You should see some updates soon. We made that changes to the app service plan.

https://github.com/MicrosoftDocs/cloud-adoption-framework-pr/pull/3950


Error in ps vita cannot install the vpk

I have been exporting several vpks and none can be installed on my ps vita before they were installed well and now they are not installed I do not know if my pc is my java or something similar so the vpks are damaged I can install any other vpk but the ones that do My pc I have not tried on other pcs since I only have one but before they went well and now it only gives me an error and nothing is installed I wanted to know if someone or you kurome knows something since it is the programmer greetings!

please check if u can extract the vpk using 7zip


Create coding style guide and stick to it

Following up on a comment @stwalkerster left on #182, we should really agree on a standard way of indenting lines. Once we do this, we should go through all of the code and make sure it uses that standard (Scrutinizer can probably do this automatically).
I personally would prefer to use [MediaWiki's tab style] (https://www.mediawiki.org/wiki/Manual:Coding_conventions#Tab_size), which is one hard tab per indentation level.

I think we're there in #232, so will close for now


Rename LICENSE-APACHE-2.0.txt to LICENSE.APACHE-2.0.txt

See xeipuuv/gojsonreference#10

Hello,
This repository is not maintained anymore, the new one is https://github.com/gojsonschema/gojsonpointer. The file has been renamed :)


Fix typo in db_connection.ex

Hi,
I thought it should be GenServer rather than GenSever.

Thanks @Theemuts, could you squash to one commit please?


Nav bar panning zoom-in bug

To see, pan left repeatedly when brush is at LHS of domain.

Then zoom in.

Caused by lack of dispatch in zoom, and altering of scales due to lack of re-render.


Implement basic enum formatting

This PR adds formatting for enums with tuple-like variants.
cc https://github.com/nrc/rustfmt/issues/76

Thanks for all the feedback!