add acdemicougb.txt

added my university

@GuilhermeMalaquias Please provide us with:

the school official website URL
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Url the school: www2.ugb.edu.br
Url IT-related: www2.ugb.edu.br/graduacao/sistemas-de-informacao-vr
Em ter., 10 de nov. de 2020 às 06:54, Philip Torchinsky <
<EMAIL_ADDRESS>escreveu:

@GuilhermeMalaquias https://github.com/GuilhermeMalaquias Please
provide us with:

the school official website URL
an URL of a page on the official website where the school offers an
IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are
submitting as an official email domain for the students.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/9834#issuecomment-724593756, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQMHH7OKMTTPHYWIS4WSVC3SPEEWBANCNFSM4TN2K47A
.

@GuilhermeMalaquias Thank you for the clarification. Pull request merged.


iCloud Password Extension

Install the extension and try to sign it into iCloud via authentication. You are informed you must be using macOS Sonoma and are asked to download it.
I'm running macOS Sonoma :)

I can duplicate this issue, will investigate into it.

Can confirm that this is also an issue with official Google Chromium, I do recommend you to report this to Apple and Google.

I don't have this issue with Brave or Vivaldi.....

This has to do with that a NativeMessagingHosts file isn't being created for Chromium, but does for those other browsers.
To fix this you can copy the com.apple.passwordmanager.json from Vivaldi/Brave's NativeMessagingHosts folder, or simply run the following command in Terminal:
echo '{
    "name": "com.apple.passwordmanager",
    "description": "PasswordManagerBrowserExtensionHelper",
    "path": "/System/Cryptexes/App/System/Library/CoreServices/PasswordManagerBrowserExtensionHelper.app/Contents/MacOS/PasswordManagerBrowserExtensionHelper",
    "type": "stdio",
    "allowed_origins": [
        "chrome-extension://pejdijmoenmkgeppbflobdenhhabjlaj/",
        "chrome-extension://mfbcdcnpokpoajjciilocoachedjkima/"
    ]
}' > ~/Library/Application\ Support/Chromium/NativeMessagingHosts/com.apple.passwordmanager.json

Thanks that has indeed fixed the issue. Surely though there should not be a need to fix this?

Thanks that has indeed fixed the issue. Surely though there should not be a need to fix this?

This is an issue of vanilla Chromium (you may already discovered), as ungoogled-chromium wants to stay as close as possible to vanilla, we might not fix it here. I do recommend you to report this to Chromium dev directly though.

Well, let's consider it solved for now then.

To clarify, running the script above did indeed fix the problem, although I still think a permanent fix needs to be incorporated into the program itself. The need for manual fixes like this having to be applied is why I stopped using it.

To clarify, running the script above did indeed fix the problem, although I still think a permanent fix needs to be incorporated into the program itself. The need for manual fixes like this having to be applied is why I stopped using it.

NativeMessagingHosts should be installed by the extension rather than the browser, there’s absolutely nothing we can do, neither actually Chromium devs, you should report this to Apple if what you want is a permanent fix, otherwise I could only suggest you to use the temporary fix or stop using browsers that Apple haven’t considered at the first place.

Reference: https://github.com/keeweb/keeweb/commit/e674607fce5e5c849b1396b5114325a9f6416820 (another password manager that uses NativeMessagingHosts)

Interesting, I can't see that Apple have considered Vivaldi or Brave and they both work.

Interesting, I can't see that Apple have considered Vivaldi or Brave and they both work.

Because Brave points their location to Chrome (code). Which:

Chromium doesn't, obviously.
They actually shouldn't do that.

I could assume that Vivaldi do the same.
And I will go strongly against adding this for UGC.

Fair enough I understand your position.

This is happening to be, i noticed it happened after installing several browsers to try, I already had arc but installed Vivaldi and Chrome Canary, after removing and going back to this extension this happened and the terminal command makes nothing, any ideias ?


Empty response

Added the method emptyResponse to use in command that don't need to fire a Request to telegram.

Looks good, merging.


Installation error

ew && PKG_CONFIG_PATH="/home/think-crag/.local/share/hyprpm/headersRoot/share/pkgconfig" make release
g++ -fPIC -fno-gnu-unique -std=c++2b -O3 -DWLR_USE_UNSTABLE
-MT src/main.o -MMD -MP -MF src/main.d
pkg-config --cflags pixman-1 libdrm hyprland
-c src/main.cpp -o src/main.o
En el fichero incluido desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../Window.hpp:8,
desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/ConfigManager.hpp:16,
desde src/main.cpp:1:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp: In member function ‘virtual std::string CGradientValueData::toString()’:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp:64:5: aviso: no hay una declaración de devolución en la función que no devuelve void [-Wreturn-type]
64 |     }
|     ^
src/main.cpp: In function ‘PLUGIN_DESCRIPTION_INFO pluginInit(void*)’:
src/main.cpp:17:152: error: asignador C99 ‘data’ fuera del inicializador agregado
17 |     HyprlandAPI::addConfigValue(PHANDLE, "plugin:scroller:col.freecolumn_border", SConfigValue{.data = std::make_shared(0xff9e1515)});
|                                                                                ^
src/main.cpp:17:152: error: uso no válido del tipo incompleto ‘struct SConfigValue’
En el fichero incluido desde src/main.cpp:2:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/plugins/PluginAPI.hpp:63:8: nota: forward declaration of ‘struct SConfigValue’
63 | struct SConfigValue;
|        ^~~~~~~~~~~~
make: *** [Makefile:18: src/main.o] Error 1

You are using a newer version of Hyprland than 0.35. I am working on supporting the current version. Check back in a few hours!

Try again. I don't have Hyprland 0.37.1 on my system, but I think it should compile now. If it doesn't, let me know. Otherwise, please close this issue.

ew && PKG_CONFIG_PATH="/home/think-crag/.local/share/hyprpm/headersRoot/share/pkgconfig" make release
cmake -B ./Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=
-- The CXX compiler identification is GNU 13.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.1.1")
-- Checking for modules 'hyprland;pixman-1;libdrm'
--   Found hyprland, version 0.37.1
--   Found pixman-1, version 0.43.4
--   Found libdrm, version 2.4.120
-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/hyprpm/new/Release
cmake --build ./Release -j
make[1]: se entra en el directorio '/tmp/hyprpm/new/Release'
[ 50%] Building CXX object CMakeFiles/hyprscroller.dir/src/main.cpp.o
[ 50%] Building CXX object CMakeFiles/hyprscroller.dir/src/dispatchers.cpp.o
[ 75%] Building CXX object CMakeFiles/hyprscroller.dir/src/scroller.cpp.o
/tmp/hyprpm/new/src/scroller.cpp:3:10: error fatal: hyprland/src/desktop/Window.hpp: No existe el fichero o el directorio
3 | #include <hyprland/src/desktop/Window.hpp>
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilación terminada.
make[3]: *** [CMakeFiles/hyprscroller.dir/build.make:104: CMakeFiles/hyprscroller.dir/src/scroller.cpp.o] Error 1
make[3]: *** Se espera a que terminen otras tareas....
En el fichero incluido desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../Window.hpp:8,
desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/ConfigManager.hpp:16,
desde /tmp/hyprpm/new/src/main.cpp:1:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp: In member function ‘virtual std::string CGradientValueData::toString()’:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp:64:5: aviso: no hay una declaración de devolución en la función que no devuelve void [-Wreturn-type]
64 |     }
|     ^
En el fichero incluido desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../Window.hpp:8,
desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/ConfigManager.hpp:16,
desde /home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/Compositor.hpp:10,
desde /tmp/hyprpm/new/src/dispatchers.cpp:1:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp: In member function ‘virtual std::string CGradientValueData::toString()’:
/home/think-crag/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../config/ConfigDataValues.hpp:64:5: aviso: no hay una declaración de devolución en la función que no devuelve void [-Wreturn-type]
64 |     }
|     ^
make[2]: *** [CMakeFiles/Makefile2:83: CMakeFiles/hyprscroller.dir/all] Error 2
make[1]: *** [Makefile:91: all] Error 2
make[1]: se sale del directorio '/tmp/hyprpm/new/Release'
make: *** [Makefile:13: release] Error 2
@dawsers

Please, run hyprctl systeminfo and copy the results here. I need to know the exact version of Hyprland you are running. hyprpm only supports very specific versions given by commit pins or it will default to the trunk revision. You may need another version or a manual build.

Latest version does not build:

it is missing scrolllayout before predictSizeForNewWindowTiled() so it leads to an undefined symbol
Window.hpp has been moved in 0.38.0

With the modification it does not work at all. All windows seems to be sent out of viewport of the monitor. Reproduced on 0.37.1 and 0.38.0

Please, try to build again with the latest commit. I can check it builds, but I cannot check it works correctly, as I don't have anything other than 0.35 on my system. I am in the process of building a virtual machine to be able to test...

Unfortunately it does not work either. Windows disappears. I do not have this behavior with other plugins.
I think you do not need a VM for that and you shall be able to compile it on a temp directory.

I use a nested Hyprland session to debug, and that works for as long as the version is the same as the one in the system. I can compile a different version of Hyprland in a temp dir like you suggest, together with the dependencies that are different than the ones on my system (hyprcursors, hyprlang). The problem is when running it, it tries to use two versions of hyprlang (the one I compile and link against and the one on my system) even if I use LD_LIBRARY_PATH, and it crashes. I think a tty would have the same problem. I am sure this can be fixed, but it is not evident. I spent a full afternoon this weekend trying to make that work and I couldn't work around the problem.
When running locally, there is a conflict

Ok understood. tty won't prevent you from that I guess. I've never tried to run wayland compositors within docker either. So even with that isolation I don't know if it will work.

I also tried with podman and distrobox (similar). The problem is when you want graphical output, it links the container to the system's compositor (or X) sockets, so you can actually see things. At that point, you are again trying to nest two different versions of the compositor, and it crashes. So I use that container to compile the code for v0.37.1, but I cannot test it until I do the VM thing.

This should be fixed now. There is currently support for Hyprland 0.35 and 0.38.0. The trunk version is not working because of recent changes I don't want to follow for now until things stabilize upstream. I removed support for v0.37.1. I will only follow the version I use and the latest tagged one from now on. Let me know how it goes...


fix(ci): Add lightwalletd gRPC, clippy, rustfmt patch jobs

Motivation
We forgot to add a patch job for the:

lightwalletd GRPC tests
clippy lint
rustfmt lint

Some PRs will show as pending until this merges.
We're also running some patch jobs when we don't need to.
Review
I might just admin-merge this.

I admin-merged because this CI bug is blocking other PRs from merging.


Issue#1887: Using id or imp.ext.prebid.storedrequest.id of Imp object to use as key for merging of stored request.

This is to avoid BigDecimal's hashing problem.

Closing this in favor of more reliable implementation: https://github.com/prebid/prebid-server-java/pull/2197


fix various model hardcoding. Should move to model features

Eg we should add functionality to identify model capabilities:

will it accept image input
is it speech to text
is it text to speech

Then we can filter models better and help users decide what to use

@humphd i ran prettier, but vs code still do a bunch of header "cleanups" in this diff. wdyt re this change?

We can do this for vlms too

@Amnish04 this touches some of your code, in case you want to look too. I think the changes are fine.


[decomp] return value of go shouldn't be none

Look into https://github.com/xTVaser/jak-project/tree/decomp/babak-batch
and see why the offline tests pass.

this is blocking:

muse
process-taskable

fixed, both compile now!


Switch continuation-local-storage dependency to cls-hooked

As mentioned in #12, temporary solution for async/await behavior of CLS.
Having such version released should be enough to live with automatic transactions (for now).

this change is published in 0.1.67


Doesn't work with newer versions of the bootloader crate

Starting in version 0.10.1 of the bootloader crate, they removed the package.metadata.bootloader.target key in their Cargo.toml. This causes an error to be thrown by this crate whenever using a version of bootimage than version 0.10.0.
The error looks as follows:
Error: An error occured while trying to build the bootloader: The `bootloader` dependency has not the right format: No `package.metadata.bootloader.target` key found in Cargo.toml of bootloader

(If you're using the official bootloader crate, you need at least version 0.5.1)

Caused by:
    The `bootloader` dependency has not the right format: No `package.metadata.bootloader.target` key found in Cargo.toml of bootloader

    (If you're using the official bootloader crate, you need at least version 0.5.1)

Perhaps, for the time being, the error could include a message that a version higher than 0.10.0 cannot be used also, until a legitimate fix is created.

Just realized that post 0.10.0 of the bootloader crate doesn't use this project anymore. Reference for anyone who is looking at this in the future.


Add support for VK_KHR_dedicated_allocation

Has just been made "stable" in Vulkan 1.0.54.

Note that nVidia (who built the extension and are probably the only ones who support it) recommend using dedicated allocations for "render targets" and "very large buffers/images (dozens of MB)".
This is probably what vulkano is going to do by default.

Although a bit off-topic, another thing to discuss is how to handle "pure-win" extensions.
What is mean is that there's no reason not to enable khr_maintenance1, khr_get_memory_requirements2 and khr_dedicated_allocations when they are available.
The fact that extensions must be explicitly enabled in Vulkan is to protect application writers from accidentally depend on features from extensions that may not be available everywhere.

While were discussing extensions...something I also noticed:
How do we deal with dependencies between extensions?
For example - once we support it - what happens if the user enables VK_KHR_incremental_presentwithout enabling VK_KHR_swapchain?

Perhaps it would be better if we introduce a new Extension type? The already supported extensions could be static constants of the Extension type. Then we could easily add support for dependencies, something like:
struct Extension {
  name: &'static str,
  dependencies: Option<&'static [&'static Extension]>
}

And then:
static const VK_KHR_swapchain = Extension {
  name: "VK_KHR_swapchain",
  dependencies: None
};

static const VK_KHR_incremental_present = Extension {
  name: "VK_KHR_incremental_present",
  dependencies: Some(&[&VK_KHR_swapchain])
};


Question: v1.1.1 status

What's the status on the next patch release?  Just looking for a ballpark so I can schedule the update in one of my upcoming sprints.

Two weeks is a good estimate. A few of us on the team are out of the office next week (vacation, off-site training), but the week after we can put out a patch.
Thanks for continuing to use the framework! The work you've contributed so far is fantastic :)


Build containers outside & docker load into hosts.

I don't see where you're passing in the calico-node image?

The approach looks good but you need to comment your code. Add in some echo statements too so the user knows what's going on.
Address this and my other feedback above then let me take another look before you merge.

OK, looks fine. Merge away.


Python Project Tells you day on which you born

Describe the project you want to add with tech stack

Tells you the day on which you born Using Python
Expected behavior

Show you the day you born
Screenshots (optional)

Additional context (optional )

Please assign me under GSSOC'23

@MohitGupta121
Kindly assign me under gssoc'23

what exactly we want to do here ? what do you mean by telling the day we were born ?
what is the input format ?
what is the output format ?


In my C++ project, Publication.offer starts returning large negative numbers after successfully sending ~24 million messages

The StreamingPublisher and RateSubscriber sample projects using tag 1.11.2 seem to be working fine in a similar test scenario (sending batches of 65 million randomly sized messages under 100 bytes). But when performing that test within my own project, things suddenly appear to start failing after 24 million or so successful messages. Publication.offer will abruptly start returning a large negative numbers (eg. -214748720) instead of the usual positive number, or the expected enumerated constants (eg. the occasional BACK_PRESSURED or ADMIN_ACTION).
I don't see any issues with /dev/shm free space, and AeronStat looks completely normal. I'm not sure what is wrong here, but under what conditions will Publication.offer suddenly start behaving this way? Once it starts failing, it never recovers for me.
Thanks in advance for any insights or tips!

Could you be doing something like using an exclusive publication from many threads? Is bounds checking enabled in your app in case some thread is writing outside the bounds of a buffer and corrupting the system?

Closing due to no further followup.


[Circle CI] set badge text as message when invalid

Give a general idea of why the badge is not displaying as expected.
only when status not available and message is available otherwise defaults to "invalid"
example invalid response:
{
  "message" : "Permission denied"
}

example badges:

-vs-

Updated to check if data.message !== undefined

Thanks! Merged by ad6691a4d8d31179f0d4f45fe40bae566133899e.


Fix mark addresses and add specs for addresses

Fixes #70.
Changes Proposed in this Pull Request:

Fix using marks as addresses - no idea where that code came from 😇
Add specs for addresses by checking how ex behaves when used as a motion (e.g. :3 or :'a)

I have written tests for:
[](Remove the []() to uncomment the appropriate lines)
[](- New features introduced)

Bugs fixed
Neither (I'm just enhancing tests!)

The failing specs are actually supposed to be failing and not broken by this PR, will put up a fix soon.


Switch from using angular quickstart to relevant node modules

Dependencies are currently pulled in from the angular/quickstart repository, this repository is likely a temporary solution while angular2 is in alpha. Move towards including the required dependencies in package.json.

[x] angular
[x] rtts/typescript?
[x] systemjs
[x] es6-shim

Implemented in 0.2.0


Bumping the version of RxJS for pipe support

Bumping RxJS version so that it matches the version bump in skyux2 (https://github.com/blackbaud/skyux2/pull/1493)

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   99.22%   99.22%
=======================================
  Files          71       71
  Lines        1685     1685
  Branches      264      264
=======================================
  Hits         1672     1672
  Misses         13       13

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
94.11% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbac84...b102885. Read the comment docs.

Hey @mattfurness.  Thanks for the PR!  I wanted to give you an quick update.
Unfortunately, the version of RXJS used in builder must explicitly match that used in @blackbaud/skyux.  It is a flaw we have a plan to fix in a future breaking change release.  Until then, it's a fairly significant coordinated effort to get the version updated.


Users get confused when creating issues

In the issue creation page, people seem to miss the small
"Don’t see your issue here? Open a blank issue." text at the bottom of the page.

Reported this to GitHub here: https://github.com/orgs/community/discussions/101943 and asked for a solution.
For a workaround we can use the "contact links" functionality.

@cjyabraham @Riaankl
Do you know any good solution to this problem?
See #588 for my suggested workaround.

Hi @aliok, I don't have much experience configuring GH screens like this, however, sounds like your workaround could help.

I will wait for some time to see if I get a response from GitHub folks in https://github.com/orgs/community/discussions/101943 before merging this workaround.


refactor generator interface

This PR refactors the new generator interface
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@costinm  I was playing around with this and slightly refactored - See if this makes sense. I am happy to close this if you think what we have is the better compared to this

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8b5804cbec3ff22005ccdad46c83b01dec303877
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8b5804cbec3ff22005ccdad46c83b01dec303877
link
/test lint_istio

unit-tests_istio
8b5804cbec3ff22005ccdad46c83b01dec303877
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm Sorry, I did n't know you have ton of code of relying on that interface, feel free to revert as needed

https://github.com/istio/istio/pull/23128 reverts the most problematic parts, I left the rest in place.


Ocata support

POLICY_FILES settings key changed for Horizon Ocata, it is now considered version specific. SESSION_BACKEND settings key parametrized.

I'm going to separate this PR to two PRs, one for parametrized SESSION_BACKEND and one regarding POLICY_FILES


fix(chart-cards): enable truncation options

Prereq PR: #2093
Internal issue: https://github.ibm.com/wiotp/Maximo-Asset-Monitor/issues/1778
Summary

Updates TimeSeriesCard, BarChartCard, and PieChartCard to have content.truncation prop that allows for using different types of truncation and a character threshold of when that truncation will trigger

Change List (commits, features, bugs, etc)

Update API snaphots
Move all timeseriescard utility functions to timeSeriesUtils
Update timeSeriesUtil tests to use describe blocks for each function

Acceptance Test (how to verify the PR)

Best way to test is to run the server locally
For default prop settings, update the labels in each card type to have different size labels, with at least one being over 20 characters long. See that the truncation only enables when it gets to that length
Try different variations of the truncation prop and see that they function correctly. Try different types and different character thresholds

Waiting for test coverage PR to be merged


refactor(core): 💡 optimize QueryId::is_same by not creating a String …

…using format for every comparison
Purpose of this Pull Request
It has proven that QueryId comparison make up quite a significant portion of a frame, part of the reason was that a string was created using format! for every invocation, since all involved parameters are of &'static str, we can skip creating the string and just use those for the comparison
Checklist Before Merging
Please ensure the following are completed before merging:

[X] If this is linked to an issue, include the link in your description.
[X] If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
[X] If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information
The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.
If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

It looks good. Thanks for your improvement.

You are very welcome. I did notice, I've been playing around a little bit and noticed it showing up in some profiles. With some unstable features it would be possible to optimize this a little further and collapse this into just a few integer compares, maybe one day those will get stabilized 😅
I've only just started playing around with Ribir, really liking it so far, so a lot to learn and figure out, but it's quite possible I will have more PRs coming in the future :)

We always welcome contributions! There is indeed a lot of work to be done, and at the moment, we haven't even begun any profiling yet.


No such file or directory error

While trying to repro #225 I had this:
cc1plus: fatal error: <source>: No such file or directory
compilation terminated.
Compiler exited with result code 1

I had opened a new private mode window, clicked the new compiler button twice and edited the options. The middle compiler pane had the error in it.
Opening a new private mode window without closing the old one yields a variant of #225 : the original window has differing compilers (see attachments).

I'm pretty sure this is the same as #212 and so closing it as a duplicate.


Crash

MacVim just crashed.
That is horrible.
Please ensure it won't ever crash again.
Stacktrace was sent to Apple.

could you elaborate the crash? and could you paste the stack trace in gist?

could you elaborate the crash?

All MacVim windows disappeared (one or more), and then the window by Mac OS X appeared offering to send the report to Apple.

could you paste the stack trace in gist?

I'm sorry, I had clicked on the window by the OS which had offered to send it to Apple, then it seems to have sent it, then the stack trace was gone. I should have copied it and provided it to you.

you may have Vim or MacVim crashlogs in ~/Library/Logs/DiagnosticReports.

Yep just found it, just a sec

Here you go:
https://gist.github.com/tobireif/cfb0d3f4ac94e4d587db809de173cdd3

Please feel free to request any additional info.
I hope you can ensure that MacVim won't crash in the future 😀

We need a repro step to crash MacVim, as simple and short as possible.

I was simply using MacVim for editing a .txt file (and perhaps more), then it crashed. I have no idea how I could trigger another crash.
You had requested the stack trace - does it not help?

All I remember is that after editing something using MacVim I switched away from MacVim perhaps the Transmit https://panic.com/transmit/ window, then MacVim crashed.

have the same problem. pressing on "I" or "O" will crash the vim.
Tried the solution from #667. But have error during the built
❯ brew reinstall macvim --build-from-source
==> Reinstalling macvim
==> Downloading https://github.com/macvim-dev/macvim/archive/snapshot-146.tar.gz
==> Downloading from https://codeload.github.com/macvim-dev/macvim/tar.gz/snapshot-146
######################################################################## 100.0%
==> ./configure --with-features=huge --enable-multibyte --with-macarchs=x86_64 --enable-perlinterp --enable-rubyinterp --enable-tclinterp --enable-terminal --with-tlib=ncurses --with
==> make
Last 15 lines from /Users/itwonders/Library/Logs/Homebrew/macvim/02.make:
    export XCODE_DEVELOPER_USR_PATH=/Applications/Xcode.app/Contents/Developer/usr/bin/..
    /Applications/Xcode.app/Contents/Developer/usr/bin/ibtool --strip /tmp/macvim-20180419-11072-14i0064/macvim-snapshot-146/src/MacVim/build/Release/MacVim.app/Contents/Resources/English.lproj/FindAndReplace.nib --output-format human-readable-text /tmp/macvim-20180419-11072-14i0064/macvim-snapshot-146/src/MacVim/English.lproj/FindAndReplace.nib

CopyPlistFile build/Release/MacVim.app/Contents/Resources/KeyBinding.plist KeyBinding.plist
    cd /tmp/macvim-20180419-11072-14i0064/macvim-snapshot-146/src/MacVim
    builtin-copyPlist --outdir /tmp/macvim-20180419-11072-14i0064/macvim-snapshot-146/src/MacVim/build/Release/MacVim.app/Contents/Resources -- KeyBinding.plist

** BUILD FAILED **

The following build commands failed:
	StripNIB English.lproj/Preferences.nib
(1 failure)
make[1]: *** [macvim] Error 65
make: *** [first] Error 2

Then I uninstall all the macvim, and install it again and it fixed the problem.
brew uninstall macvim --force macvim
brew install macvim

@tobireif @kenng I can't reproduce your issue
Does it still an issue with recent versions of MacVim? Have you tried to run it mvim -u NONE -U NONE to reproduce an issue?

MacVim hasn't crashed here since many months or even years.

Could this issue be closed?

You had also asked @kenng . I can't talk for him. As for as the issue concerns me, yes you could close this ticket.

There was a lot of such issues that time and the underlying issues were fixed. If something crashing MacVim nowadays, it's mostly incompatible plugins. It's easier to reopen the issue if it's still hitting users.

Closing. @kenng please open a new ticket if/when necessary.

@tobireif yes can close, it is working as for now, after uninstall & install again.

@kenng Good to hear!


metrics identifier question

The docs say the format should be collectd.<host>.docker_stats.<app>.<task>.<type>.<metric>, but the PUTVAL is PUTVAL %s/docker_stats-%s.%s/gauge-%s %d:%d\n.
From what I gather from https://collectd.org/documentation/manpages/collectd-exec.5.shtml, it looks like the PUTVAL should be PUTVAL %s/docker_stats/%s/%s/gauge-%s %d:%d\n.
If this is the case, I can send a PR for you.

An Identifier is of the form host/plugin-instance/type-instance with both instance-parts being optional.

The only reason it works now is that I disable changing . to _ in collectd config, otherwise it would be mess: collectd.<host>.docker_stats.<app>.<task>-<type>-<metric>.
Correct me if I'm wrong and it could be better.

This is a screenshot from graphite web. If the PUTVAL would have slashes in between app and task, I would be able to do easier * queries.

What do you use to visualize metrics?

Are you using my image and config?


Allow mult unicode to be printed infix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.538%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
950

Relevant Lines:
1061

💛  - Coveralls


Feature sdl 0262 new vehicle data seat occupancy

Implements https://adc.luxoft.com/jira/browse/FORDTCN-4193
This PR is not ready for review.
Testing Plan
Manual testing
Summary
Add new structure SeatOccupancy into VehicleData
CLA

[x] I have signed the CLA

Internal review is done. Move PR to the open


Pressing <C-p> and <C-n> in insert mode without a cmp menu out will call out a unknown menu

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.10.0-dev-319+g5825d2f6ca
Operating system/version
ArchLinux
Terminal name/version
foot version: 1.14.0 +pgo +ime +graphemes -assertions
$TERM environment variable
foot
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue

Open a file
Move to somewhere to let some text under cursor
Press i to switch to insert mode
Press <C-p> or <C-n>

Expected behavior
Nothing happen
Actual behavior
A unknown menu which doesn't follow cmp theming appeared.

Additional information
Normal CMP menu looks like

Seems relevant to these two lines:
https://github.com/ayamir/nvimdots/blob/c6b4163407c5aae191a1235077982c245ca4221f/lua/modules/configs/completion/cmp.lua#L116-L117
Have u check if there's any related issue in the upstream repo, e.g. https://github.com/hrsh7th/nvim-cmp?

Seems relevant to these two lines:

No, I removed these lines and the problem still exists.

Have u check if there's any related issue in the upstream repo, e.g. https://github.com/hrsh7th/nvim-cmp?

Not very sure about this, I also tested in NvChad, this problem is also in NvChad

It's not bug. Just nvim built-in keyword completion.

So is there any need/way to disable it?

So is there any need/way to disable it?

u can first check if cmp is available, and if not, map that to <Nop>. A simple Lua function is sufficient to handle this problem.

Works well.


sc-1174 - Feature - Toolbar Publish

Short summary
Based on the foundation story, the publish feature has been added to the toolbar.

It will update the redux state project name, description, and authors. The Report & Tracking seems to be specific to each publish so I kept it in the local component state. It is easy to change in case we need to send it to the redux store.
The response to the publication has been hardcoded since the publish hook is not asynchronous.
I added some fixes to the main code, check out the comments in the code for more info.

@aubeOSG all merge conflicts have been fixed, this is now good for review.


Return type of suspend function not considered for public API

Plugin version
2.5.0
Gradle version
8.11.1
JDK version
22
Kotlin and Kotlin Gradle Plugin (KGP) version
2.0.21
Android Gradle Plugin (AGP) version
8.7.2
Describe the bug
I have 3 modules:
module A
interface MyResult

module B (api(projects.A))
interface Foo {
  fun bar(): MyResult
}

module C (implementation(projects.B), implementation(projects.A))
class Baz(
  private val foo: Foo,
) {
  fun bing() {
    foo.bar()
  }
}

Running buildHealth fails with:
> Advice for :B
  Existing dependencies which should be modified to be as indicated:
    implementation(projects.A) (was api)

  Advice for :C
  Unused dependencies which should be removed:
    implementation(projects.A)

Running :B:reason --id :A:
------------------------------------------------------------
You asked about the dependency ':A'.
You have been advised to change this dependency to 'implementation' from 'api'.
------------------------------------------------------------

Source: devDebug, main
----------------------
* Imports 1 class: MyResult (implies implementation).

Running :B:reason --id :A:
------------------------------------------------------------
You asked about the dependency ':A'.
You have been advised to remove this dependency from 'implementation'.
------------------------------------------------------------

Source: devDebug, main
----------------------
(no usages)

If I follow the advice then compiling C fails:
e: Baz.kt:20:52 Cannot access class 'MyResult'. Check your module classpath for missing or conflicting dependencies.

repro.zip
Running ./gradlew buildHealth on the repro above fails only when foo is a suspending function in services/foo/public/src/main/kotlin/template/services/foo/Foo.kt.

Thanks for the report. I note the description of the issue (in the text) doesn't include any suspend functions. Does the repro contain suspend functions? (I haven't downloaded it yet.) If so, could you update the description?

Updated. The repro project looks pretty different though, the description here was originally derived from that.


zsh completion

Weekend hack by someone who doesn't grok zsh completion
but who finds it deeply offensive that most completion
files have an unmaintainable duplication of options
and arguments. The idea behind this one is to discover
the command line using --help, with a few hardcoded
helpers for discovering containers, images, pods,
and figuring out which args take files/dirs as args.
Working remarkably well. I am using this in my daily
routine and wondering how I ever managed without it.
It's not perfect -- a future version can perhaps
show only stopped containers for podman rm, only
running ones for podman stop -- but ROI seems low
on that given my limited zsh completion skills.
Sadly, I can't figure out how to write a regression
test suite for this. It would be lovely to have a
list if partial command lines and expected completions,
because the history of this change is that (seemingly)
minor tweaks in one place cause breakage in another.
Does anyone know of such a framework?
Still... working well enough to ship, IMO.
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

Very low priority: this was a weekend and spare-time project, and I know everyone has way too much already.
Best way to review, I think, is simply to use it. Any zsh users around?

/approve
I'll test-drive this tomorrow and see how it works. Thanks a lot @edsantiago

LGTM

/lgtm


Function composition / flow operator

I use ramda a lot and I was curious if civet could support a few things natively. Something I do a lot with ramda is create a function using pipe. For example:
const doTheThing = R.pipe(
  R.pluck('myprop'),
  R.map(R.toUpper)
)

console.log(doTheThing([{myprop: 'hello'}])) // outputs [HELLO]

My understanding is that the pipe operator in civet currently requires a start value, so one can't easily compose functions using pipe. You can see my attempts at this in https://github.com/DanielXMoore/Civet/issues/75#issuecomment-1448930717
It would be really neat if there was some sort of function composition / flow operator (see pipe vs flow in fp-ts and F# Pipelining vs. Composition for good explanations of these two concepts).
F# uses >> for composition. So these two would be equivalent:
input := [myprop: 'hello']

// using pipe, |>
input
  |> .map .myprop
  |> .map .toUpperCase()
  |> console.log

// using flow, >>
doTheThing := .map .myprop >> .map .toUpperCase()
console.log doTheThing input

wouldn't you need parens?
doTheThing := (.map .myprop) >> (.map .toUpperCase())

wouldn't you need parens? doTheThing := (.map .myprop) >> (.map .toUpperCase())

Possibly. I learned about the existence of civet yesterday, please excuse any mistakes in my civet code :slightly_smiling_face:
I was thinking since the pipe code works fine without parens it'd be nice if this worked the same. i.e. to convert from pipe to flow:

remove input |>
replace all |> with >>
there is no step 3

Just for aesthetic reasons, I prefer >> instead of |>.

I don't think we can use >> (until we have operator overloading) because f >> g already has a meaning in JavaScript (shift right).
Oren mentioned on Discord that these examples could be reasonably represented in Civet as & |> f |> g, which would mean $ => g(f($)). This doesn't work yet but would be a natural extension to & notation (function shorthand).
Do you think that would suffice, or is this too verbose?

Operator overload looks exciting and desirable.

Oren mentioned on Discord that these examples could be reasonably represented in Civet as & |> f |> g, which would mean $ => g(f($)). This doesn't work yet but would be a natural extension to & notation (function shorthand).
Do you think that would suffice, or is this too verbose?

Yes, I forgot to mention I did try that, it felt natural, so personally I think that's a good solution.

Released in v0.5.81


Add Chinese translation

By: 抗药又坚硬汉化组(SBMW GROUP)

Please revert the latest commit. If you don't want to change the Sandstone Brick name, just leave it the same as vanilla Terraria's translation.

Oh, yeah. I forgot.


update docs

Updates the docs to 0.6.5

makes some simplifications/clarifications to programming-model.fsx

adds link to table of data abstractions (temporary - needs more work at later date)

Please re-run doc generation after this

@eiriktsarpalis I had some trouble running doc generation, I think I fixed the issues - let me know if you have problems


Locked mouse scaling seems too sensitive

Steps to reproduce:

Enable pointer locked mode using settings, Control Scheme: Locked
Focus the UE application, do some small circles with the mouse to move the camera
Focus the Pixel Streaming browser tab, do the same motion with the mouse
Note the sensitivity seems much higher.

This does not appear to reproduce when using "hovering mouse mode".
CC @Belchy06 to review.

@EpicGames/developers this software is incredible.

Issue was resolved as part of https://github.com/EpicGames/PixelStreamingInfrastructure/commit/95f2bef3349b6b715e3261a259afe6e0bed53c9d


feat: MPTT relations compatibility issue reproduction

Description
Trying to get an author and then the total count of the children of that author breaks when there are no children present but requested in the query.
Error:
"message": "An unknown error occurred."

The PR includes a test test_nexted_children.py, which illustrates the use case and resulting error.
FYI: Disabling the DjangoOptimizerExtension makes the test pass without any issue.
Types of Changes

[x] Bug reproduction for 3rd party compatibility

Summary by Sourcery
This pull request enhances the RelayAuthor model by adding MPTT relations to support hierarchical data structures. Additionally, a new test case is introduced to verify the nested children count functionality.

Enhancements:

Added MPTT (Modified Preorder Tree Traversal) relation to the RelayAuthor model to support hierarchical data structures.

Tests:

Introduced a new test case 'test_nested_children_total_count' to verify the nested children count functionality in the RelayAuthor model.

Closing this as https://github.com/strawberry-graphql/strawberry-django/pull/553 superseded it


Running jobs in a private container

TL;DR
To be able to run jobs in a container that uses a private registry for images, with Workload Identity Federation
container:
  image: europe-docker.pkg.dev/my-project/my-artifact/image:latest
  credentials:
     username: 'oauth2accesstoken'
     password: '${{ steps.auth.outputs.access_token }}'

Detailed design
No response
Additional information
Right now it's a chicken-egg issue as I need to first authenticate via Workload Identity Federation, but then I can't use the token in another job to pull the image from a private Artifact Registry. Just looking for guidance on what would be the best way to implement this.

Hi @bgdanix - this is a limitation of GitHub Action, and is not something we control. In this case, I believe you would need to use a longer-lived secret like a service account key and interprolate it as a GitHub Secret.

This is a pretty sad limitation, especially if your project/org does not allow long lived service account keys.
I'm curious if anyone else has found a (even hacky) workaround. There are some ideas floating around in https://github.com/orgs/community/discussions/38006 but none that seems to work.

@faximan I think I've come up with a viable workaround, though I have not tested it thoroughly.  The resulting access_token will be good for 60m, so there's some security implications as the token won't be masked in debug logs.
jobs:
  gcloud-setup:
    permissions:
      contents: write
      id-token: write
    runs-on: ubuntu-latest
    outputs:
      access_token: ${{ steps.access_token.outputs.access_token}}
    steps:
      - name: Checkout
        uses: actions/checkout@v4

      - name: Authenticate with Google Cloud
        uses: google-github-actions/auth@v2
        with:
          project_id: <project>
          workload_identity_provider: 'projects/<projectId>/locations/global/workloadIdentityPools/<pool>/providers/<provider>'

      - name: Set up Cloud SDK
        uses: 'google-github-actions/setup-gcloud@v2'

      - name: Export Access Token
        id: access_token
        run: echo "access_token=$(gcloud auth print-access-token --impersonate-service-account <sa>@<project>.iam.gserviceaccount.com)" >> $GITHUB_OUTPUT

  job-using-private-registry-image:
    needs: gcloud-setup
    runs-on: ubuntu-latest
    container:
      image: us-central1-docker.pkg.dev/<project>/<registry>/<image>:<tag>
      credentials:
        username: oauth2accesstoken
        password: ${{ needs.gcloud-setup.outputs.access_token }}
    steps: [...]


[BUG] Duplicate package entries in Discover Packages's Search

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
When searching for packages in the "Discover Packages" tab duplicate package entries are observed.
Steps to reproduce the issue

In the "Discover Packages" tab begin to search for a package
Change your of the search query slowly. As long as the time between your change to the query is enough for it to begin to search for your query it will occur.

WingetUI Log
Uploaded as file due to length limit
WingetUILogs.txt
Package Managers Logs
Uploaded as file due to length limit
PackageManagerLogs.txt
Screenshots and videos

I will investigate that

related to https://github.com/marticliment/WingetUI/issues/1373 I suppose

Please test latest beta: https://github.com/marticliment/WingetUI/releases/download/2.1.2-beta/WingetUI.Installer.exe


pre-pwa: refactor naming convention for react components

So, I've been talking to @TheLarkInn regarding converting webpack.js.org to be a PWA. So, this is the first of a few tasks I'm creating to lay out a plan towards that direction.
Measuring by the current usage of react; I'd like to refactor the naming convention of the components to use Pascal case.
For example, this is the current convention:

components/dropdown/dropdown.jsx
components/dropdown/dropdown-style.scss

With the proposed convention this would like:

components/Dropdown/Dropdown.jsx
components/Dropdown/Dropdown.scss

@hulkish saw your slack message, but didn't get a chance to reply as I've been sick the last few days -- would you mind merging these four issues to one meta issue with a checklist with the four points? We can then link PRs within the checklist and mark things done as they are completed. Also, as mentioned on #1380, I would really like the issues to be mostly content-related.
Re the proposed naming convention, I'm fine with that change. How is that related to making the site a PWA though?

Also we should make sure we stay in sync as we port the site -- I'm not sure if switching to gatsby or phenomic tackles or conflicts with certain parts of this.

@slipjack i dont think switching to gatsy or phenomic will conflict with what i have in mind - since i am primarily focused on the react + webpack.config.js areas of the app.
Regarding the naming convention pwa dependency question.. It doesn't necessarily need to be so in order to convert to a PWA - but I figure it's a change made much easier before the actual conversion.

I'd like to PR this but I'm not so knowledgeable to be honest.
It should be very simple, right?

@Dean-Coakley Yea, it's pretty straight forward.. just be sure to update the import paths with the changes as well. Ex:
import Dropdown from './components/Dropdown/Dropdown';

@hulkish navigation-bar -> NavigationBar ?

NavigationBar

@hulkish Sorry for more questions but:
Would I be correct in saying:
import Sidebar from '../Sidebar/Sidebar'; will import the .jsx
and import '../Sidebar/Sidebar'; will import the .scss ?
Secondly, Organization/projects.json and Support/support-additional.json should not be renamed.

yes for jsx(an assumed extension). No for scss (not an assumed extension)

moving this to https://github.com/webpack/webpack.js.org/issues/1400


Ban message

When disconnect from server apears well (Permantly ban >> Test)
But entering again to the server, (Appears like vanilla message and the reason appears the way should be, ex.)(Vanilla messages; Reason: Permantly Ban>> Teste)
Cardinal Version

Update your cardinal, it was fixed by #731

This is issue #371 , discuss there.

Update cardinal.

@Eudaldca you don't see the cardinal version .-.?

Closing in reference to #371


The output from Export-Clixml includes a dead link

Documentation Issue
When using Export-Clixml to pass information to a file the first line of the resulting XML file is

<Objs Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/powershell/2004/04">

This xmlns link (http://schemas.microsoft.com/powershell/2004/04) results in a 404 error when clicked

Close as stale issue.

Close as stale issue.


Short formats for relative timestamps, Fixes #1115

Open more for review and discussion than merge

Don -- marking with WIP --- please use going forward if something is not ready for merging!
Thanks!

I would be fine to not have the defaulting based on mobile - honestly I am not sure how much this is about mobile vs. desktop - more about the context in which you are showing the timestamp.  Is it in a toolbar all by itself where you have lots of room (regardless of platform), or are you looking to fit it alongside a number of more important metadata and you want to show it as succinctly as possible.  In the end, the config exists for the developer to choose.
Was that the issue keeping this in WIP status?

Well the approach I had to take for the defaulting called into question whether the component is an outlier in that it doesn't follow our standard patterns, and whether we should rework it to do so. I haven't spent a ton of time in Hoist React land this year so forgive me if I'm over thinking this.

Discussed with Lee, few small changes coming, will look to close today


Icons are not in a very useable format

For now we're ignoring them. I recommend using a normal icon font such as Font Awesome, Feathers e.t.c None of the icons seem too unique.
@gutsal-arsen what do you think? If you approve an icon font we'll use it instead.
https://fontawesome.com/

Go for FontAwesome.


EY Enemy

All the scripts needed for EY to function have been made. Also restructured laptop goon shooting function to be reused on all enemies.

I'm getting ready to merge and updating the change log - please @me if any other changes are pushed.


Broken download link from README file

https://osrelease.download.prss.microsoft.com/pr/download/Mariner-2.0-x86_64.iso gives me a "GatewayExceptionResponse"

Thanks for the report, will check to see what's wrong.

This should now be resolved.


Move file-based stores to actual db

With #456, we can move:

[ ] issue_commands_ran.json (#350)
[ ] voters.json (#391)
[ ] .migrated (#393)

to an actual db.

Until / Unless we get a proper web framework on the server, we still need to dump server/voters.json for the website to work.

@md678685 yes, although creating a simple script to be called with ajax which reads db and dumps js would be fairly trivial to create...

We'd at least need to ditch or extend SimpleHTTPRequestListener.

Yeah, why not use nginx? It's running already...

I'm not sure about using Nginx when we need to be able to query a DB to return results. I think accessing the database should be done through ChaosBot as much as possible, and we should probably implement a proper web framework like Flask anyway so we can extend the website further.

👍 I support Flask


Added basic cairo-prove binary.

Stack:

#6710 ⬅
#6709
#6708

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is


Stuck in loading on mobile

Temporarily fixed - this seems to be a bug in iOS WASM implementation, which I've disabled.  Will revisit this in the future..

This is resolved on safari for iOS 11.2.5 but I get infinite loading on chrome 64.0.3282.112

ill send the debug log tonight


dist/index.js not generated

dist/index.js needs to be pushed:
Error: File not found: '/home/runner/work/_actions/bubkoo/update-authors/eecd03e7962630147a1991e01adcacbbfe716e12/dist/index.js'

https://github.com/crazy-max/buildkit/runs/1439260216?check_suite_focus=true#step:3:9

Nevermind you prefer to push dist in a dedicated way.


The wast file exists and is correct, but when run "cleos set code "prompt is not found

2、

In more recent releases, the command that takes just the parent directory name is set contract.  cleos set code now expects the full path to the WAST file itself.  The command you want is:
cleos --print-request set contract eosio ./hello
If there is documentation that says set code accepts the parent path, it needs to change.  Please paste a link.


Does Kamaji support accessing the container pod?

In Kamaji, is it supported to enter the container pod? Because when I try using kubectl exec, it can't enter the container pod. Or am I doing something wrong in installing and configuring Kamaji?

Strictly related to #443, prior to giving a try to Kamaji I strongly suggest knowing in depth the architecture of Kubernetes, and Control Plane <> Kubelet communications.
tl;dr; you have to enable Konnectivity, we also have a dedication section on our documentation website.


All shortcuts are added to steam regardless

Despite my choice in the menu for what launcher I want to install, it adds shortcuts for all launchers into Steam. It seems like it might be just the default launchers, but it adds all of them back in. There is nothing in the script that prevents duplicate shortcuts from being added to Steam either, so there will be infinite duplicates of the shortcuts each time the script is run, which I don't think anything is installed at the locations the shortcuts are supposed to be linking to, so they are shortcuts that don't even work, meaning they just have to be manually deleted. This is also annoying since some changes need to be made to the shortcuts to get them to work since there are other issues with where they are linking to, so each one needs to be checked to make sure you manually delete the correct shortcut. There needs to be some kind of check here to make sure that the script is only adding the shortcut for the selected shortcuts and that duplicates are not being created endlessly.

@Dartis4 this is actually not true. "There is nothing in the script that prevents duplicate shortcuts from being added to Steam either, so there will be infinite duplicates of the shortcuts each time the script is run" --- my script does this check for each and every shortcut. please send a log so i can see whats going on!!


Bootstrap conflict

Screenshot

Steps to Reproduce
I tried to use Bootstrap v4.0.0-alpha.6 (https://getbootstrap.com)
is order to use the fancy button they made
The issue is that it mess with the ratio of many element in the theme.
It would be great to be able to use bootstrap4 (bootstrap.min.css & bootstrap.min.js) without any conflict or to integrate it directly in the theme.
My requirement really is to get great button to make call to action in my content.
Technical details:

Ghost Version: 1.5.2 (via the official Docker hub image)
Casper version 2.0.2
Browser version: Chrome 60.0.3112.90 (Official Build) (64-bit)
OS Version: Mac OS X 10.11.6
Environment production
Node Version: v6.11.2
Database: sqlite3
Mail SMTP

@pascalandy I'm going to close this as it's not a bug - Casper is designed as a standalone theme, if you want to integrate it with other CSS frameworks that's your prerogative but it's not something that we're going to address in core.


Resolve package not found when updating conda env from environment.yml

We get a resolve package not found error when updating a conda environment from environment.yml
The specific command which was used:
conda env update -f environment.yml

When we can use the environment.yml properly, the .travis.yml should be configured to use the environment.


[$1000] Android - Composer input overlaps with attachment separator

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app -> Login in account
Navigate any chat conversation
Notice composer input (from left side it overlaps)

Expected Result:
Composer input should not be overlaps with attachment separator
Actual Result:
Composer input overlaps with attachment separator
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680359256103449
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0160683cfa6e9f3593
Upwork Job ID:<PHONE_NUMBER>077060096
Last Price Increase: 2023-04-04

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Wow @dhairyasenjaliya you've got some good eyes.

Job added to Upwork: https://www.upwork.com/jobs/~0160683cfa6e9f3593

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
composer input overlaps with attachment separator in android
What is the root cause of that problem?
the root case is ButtonAttachment borderRightWidth: 1 shown blurry on some screen density.
react native use dp for dimensions and round it to px, so if value 1dp = 2.5 pixels, some devices show it blurely because physical screens have only a fixed number of pixels.
to know how many pixels in 1dp  in any device use PixelRatio.get().
in my emulator 1dp = 2.5px so the last .5px show blurely.
and in the app the current style for footer is :

<ButtonAttachment style={{borderRightWidth: 1}} />
// view paddingVertical: 5, and no backgroundColor let border to show blurely
<View>
    // Composer has backgroundColor: themeColors.componentBG
    <Composer />
</View>

What changes do you think we should make in order to solve the problem?
apply the same background color for <Composer /> and <View> wrap it, or clear it from both, or set it in the wraper.
my sugguest is to add backgroundColor: themeColors.componentBG for the wraper <View> here.
and also if we found the ButtonAttachment borderRightWidth: 1 is very thin, we may increase it.
    textInputComposeSpacing: {
        paddingVertical: 5,
        ...flex.flexRow,
        flex: 1,
        backgroundColor: themeColors.componentBG,
    },

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
composer input overlaps with attachment separator in android
What is the root cause of that problem?
The root case may be the fixed width provided in the styling.
What changes do you think we should make in order to solve the problem?
the issue can be solved by not providing fixed width of composer and add a bit margin to it so it could have a safe space from separator and send button

Proposal
Please re-state the problem that we are trying to solve in this issue.
composer input overlaps with attachment separator in android
What is the root cause of that problem?
The root cause of this problem is styling.
What changes do you think we should make in order to solve the problem?
This issue can be fixed by adding min-width and max-width in the massage dialog div.

@ahmedGaber93 Thanks for the proposal. I'm not sure this is blur related. If you zoom the following screenshot https://user-images.githubusercontent.com/43996225/229310637-cf6becf7-ebc5-433f-9c6d-d73181242e12.png you will see that the separator is shown correctly on top and bottom parts and only the middle part where the input is rendered it's cut (overlapped).

@Mabroorkhan Thanks for the proposal. Your RCA is not clear, you need to pinpoint the exact root cause and not guess potential causes.

@UzairHKhan Thanks for the proposal. Your RCA is not clear, can you elaborate? And why this happens on Android only?

@s77rt some time it only happens in a single platform or in similar screen size phones and works fine in all others the main cause of these types of issues is the width of the boxes if it is taking the width more than it requires it will overlap or can displace another box the possible way to fix this is by adding
 width: -webkit-fit-content;
 width: -moz-fit-content;
 width: fit-content;

This similar issue occurred in my previous work history and was happening only in iOS.

@UzairHKhan If that's the case then we need to figure out why the input is taking more space than it requires.

@s77rt I find the issue is due to flex: 4 1 0% in textArea styling which can be fixed byflex:  1 and margin: 0px 2px

@Mabroorkhan Thanks for checking. Can you elaborate with this happen only on Android?

@s77rt Yes I need to dive into the code to get more context on this possibly textarea has some width.

@s77rt I found more bugs in it

in screen width 320px the border is cutting off from the top when the placeholder is take two lines img 2
when the placeholder goes in three lines we see expend button img 2 after clicking the expend button the textarea expands and we see it like this img 3

@s77rt Another possible way to fix the border issue is to make the textarea background transparent it won't affect the UI as div also have same bg color and if the text overlaps the border it will still be visible

@s77rt i think this overlaps not related with width of any View in the component, because i trying simple example in expo snack and the overlaps is exist.

simple example code.
import * as React from 'react';
import { View } from 'react-native';

export default function App() {
  return (
    <View style={{lex: 1, height: "100%", justifyContent: 'center'}}>
      <View style={{
        borderWidth : 1,
        borderColor : "green",
        borderRadius : 15,
        overflow : 'hidden',
        flexDirection: "row",
        alignItems: "center",
      }}>
        <View style={{
          height: 30,
          width: 30,
          backgroundColor: "black",
          borderRightWidth: 1,
          borderRightColor: "green"
        }} />
        <View style={{backgroundColor: "black", flex:1, height: 20, borderWidth: 0}} />
      </View>
    </View>
  );
}

result.

you can try snack here but test it in a real device because i think emulators don't have the a real number of pixels.
and also result may be diffrent depond on sceen density.

@UzairHKhan Thanks for the proposed fix but I think we are not looking for solutions at this point. It's important to understand the root cause first.

@ahmedGaber93 Thanks for checking that. So looks like the bug is in RN. Let's fix it on RN then.

@s77rt thanks for the feed back

@s77rt I think the bug is in android itself not react native, and setting the wrapper view background is the simple way to fix the UI issue.

@ahmedGaber93 Were you able to replicate the bug on Android (native code)?

@s77rt no i couldn't replicate the bug on android (native code).

Not overdue. Still waiting for proposals, so far the bug seems to exist on RN too and we are aiming to fix it on that level (assuming the bug is not originating from native Android SDK).

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Upwork job price has been updated to $2000

Still waiting on more proposals.

@puneetlath @s77rt this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

We are not any close to picking a proposal. So far we think the bug is in RN and no proposals submitted for that matter.

@s77rt as I have proposed before these type of issues is caused by the width alow me solve this bug

@UzairHKhan Thanks for the follow up. I'm not really convinced this is the reason. Can you please explain why this is happening on Android only?

@s77rt in the current implementation I noticed that it is using flex: 1 to fill all the available space between but in compilation of RN some time it produces bug in single platform and work fine in other so we have to replace flex: 1 with  width and possibly it will fix the bug

Hi I'm Nicolay from Callstack - expert contributor group - will start investigation in this area

@UzairHKhan

but in compilation of RN some time it produces bug in single platform

We need to fix that bug instead of replacing flex with width.

@puneetlath Please assign @narefyev91 as per the process.

📣 @narefyev91 You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

My updates - indicated an issue - found a possible solution - provide proposal for internal review. Will post here - as soon as i get approval

@narefyev91 Thanks for the proposal. So If I get this correctly, you are saying that the Composer is not overlapping with the separator. But it's actually the separator taking more space. Would that be "about" right?
If that's the case why using flex does not take into consideration that extra space taken by the separator and draw the input on that used extra space. Why the input is not shifted so it does not collide with that? Is this by design? And lastly why we are not experiencing the bug on iOS (or are we)?

@s77rt StylesSheet.hairlineWidth will be very thin because it equals 1px, but borderRightWidth: 1 equal about 2.5px or 3px in modern devices depend on PixelRatio.get() and also it may not be visible in some devices.

@narefyev91 Thanks for the proposal. So If I get this correctly, you are saying that the Composer is not overlapping with the separator. But it's actually the separator taking more space. Would that be "about" right?
If that's the case why using flex does not take into consideration that extra space taken by the separator and draw the input on that used extra space. Why the input is not shifted so it does not collide with that? Is this by design? And lastly why we are not experiencing the bug on iOS (or are we)?

I will say nothing is overlapping - we have dropping pixels in android - as you see in the screenshots. TextInput taken correct space, and the issue that line is not renders at it should be - not in a full width - that's why TextInput sees that max available space started from rendered line (rendered line it's line with bold color and not thin). Such issue does not exist on IOS because in IOS 1px = 1px - without any pixel drops.

@s77rt I think StylesSheet.hairlineWidth will be very thin because it equals 1px, but borderRightWidth: 1 equal about 2.5px or 3px in modern devices depend on PixelRatio.get() and also it may not be visible in some devices.

We already use StylesSheet.hairlineWidth under the hood - it equal already drawable line - which in bold. If it will be not visible - the whole border will be not visible as well. And 1px is not equal 2.5px or 3px to be honest - it's something around 1.6px - 1.8px in modern phones

@narefyev91 I just try it before in my real device in this snack, and it displayed very thin and not fixed the issue, but may I missed something.

@ahmedGaber93 For sure the line will be thin that's why i told that maybe make sense to apply this width for the whole component. BTW i can't really say why in expo snack it still cutting, i tested on real device and devices in emulators and that was working. In any case i provided 2 possible solutions which i discovered

@narefyev91

Such issue does not exist on IOS because in IOS 1px = 1px - without any pixel drops.

Did you mean to say that 1dp = a round number of pixels? Where on Android it may not always be the case?
Can you please include screenshots before the change and after the suggested change for both iOS and Android?

@s77rt
https://angrytools.com/android/pixelcalc/
Example

Result you can see here:
Before:

After:

@s77rt IOS does not need any changes in IOS - there are no issues with dropping pixels

Also, if we swap the text input with a simple view/rectangle, will we experience the same bug?

@s77rt
Sure:
IOS 1px (default)

IOS - calculated pixel - 1 + (1 - Stylesheet.hairlineWidth)

IOS - Stylesheet.hairlineWidth

Android - calculated pixel 1 + (1 - Stylesheet.hairlineWidth)

Android - Stylesheet.hairlineWidth

Platform specifications:
IOS, webIOS, webAndroid, Desktop, Web -  1px = 1px (standard behaviour) - should not be changed
Android - 1px = 1 + (1 - Stylesheet.hairlineWidth) - should be changed (to prevent dropping pixel)

@narefyev91 Thank you!
I have two concerns:

Are we sure the fault is not on the TextInput (not getting shifted). Check comment above.
You are suggesting to set borderRightWidth: 1 + (1 - StyleSheet.hairlineWidth) This does not make much sense because StyleSheet.hairlineWidth will return the dp value that corresponds to one pixel on the device. Example: 0.5 dp => 1 pixel. Using multiples of that value (1, 1.5, etc.) is okay as this will still result in a fixed number of pixels (2, 3, resp). But if we alter the value by addition/subtraction the new dp may correspend to a non fixed number of pixels e.g. 2.5 pixel so the OS will have to compensate and the blur effect can be seen again. I don't think we consider those as "dropping" pixels.

@puneetlath @s77rt @narefyev91 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Still discussing proposals

@s77rt Hey!
For your first point:

TextInput really stays on all possible space - and will also cut a peace of attachment border
For the second point:
Not really - 1dp - will be fully different on devices - and variation of it is from 0.2 - to 0.5. For Example for devices with large screens i get between 0.28 - 0.36. On small devices - 0.4 - 0.5.

@narefyev91 Hi again :wave:  I'm not sure you answered my questions :sweat_smile:

Can you try use a <View /> with a different background instead of the TextInput and see if it actually cut the separator or not
I don't think you understood my concern in this point. I'm not talking about different devices.  In one device, the StyleSheet.hairlineWidth  will return how much dp would correspond to one pixel. Is that right? Let's assume the value for our device is 0.3 dp. So if we set the border width to 0.3 we will be sure that exactly 1 pixel will be used so the line will look clear and blur-free. Do we agree on that so far? If we set it to 0.6 we will get 2 pixels. So any multiple of 0.3 will result in a fixed number of pixels. Still makes sense? Okay, now if we apply your suggested formula 1 + (1 - StyleSheet.hairlineWidth) we will get 1.7 and this is not a multiple of 0.3 so it will result in blurry pixels (5.67 px).

@s77rt Sure thing! this is simply view with Text inside

@s77rt BTW - i came up with some maybe different solution - if we have such issues with border in android - maybe we will fully remove it? And use Separator as simple View with width 1. Which will not impact any other platform and bring same visual effect for android as well
                                    </AttachmentPicker>
                                    <View style={{width: 1, height: 'auto', backgroundColor: themeColors.border}}/>
                                    <View style={[styles.textInputComposeSpacing]}>

And we will get on android this

@narefyev91 Actually I was looking more into this and I think we still have more to explore. I think we are not seeing the blur pixels on iOS just because we are lucky :grin:.
The ratio on iOS is either 2 or 3 (based on https://reactnative.dev/docs/pixelratio#get) and those ratios plays well with a border width of pixel. I have compiled this script to help understand the results.
let analyseOptimalBorderWidth = (ratio) => {
    // Based on https://github.com/facebook/react-native/blob/4da201396c12cbfa8427d17465376de123913f62/packages/react-native/Libraries/StyleSheet/StyleSheet.js#L164-L167
    let hairlineWidth = Math.round(0.4 * ratio) / ratio;
    if (hairlineWidth === 0) {
        hairlineWidth = 1 / ratio;
    }
    [1, 1.3, 1.5, 1.8, 2, hairlineWidth].forEach(width => {
        const numPixels = width / hairlineWidth;
        const isRoundNumPixels = numPixels % 1 === 0;
        console.log(`Setting borderWidth to ${width} will use ${numPixels} pixel(s) ${isRoundNumPixels ? '✅' : '❌'}`);
    });
}

console.log("Tesing with ratio of 1 (mdpi Android devices)");
analyseOptimalBorderWidth(1);

console.log('='.repeat(30)+'\n');

console.log("Tesing with ratio of 1.5 (hdpi Android devices)");
analyseOptimalBorderWidth(1.5);

console.log('='.repeat(30)+'\n');

console.log("Tesing with ratio of 2 (xhdpi Android devices, iPhone 7, 8, 11)");
analyseOptimalBorderWidth(2);

console.log('='.repeat(30)+'\n');

console.log("Tesing with ratio of 2.5 (?)");
analyseOptimalBorderWidth(2.5);

console.log('='.repeat(30)+'\n');

console.log("Tesing with ratio of 3 (xxhdpi Android devices, iPhone 7 Plus, 8 Plus, X, XS, XS Max, 11 Pro, 11 Pro Max)");
analyseOptimalBorderWidth(3);

console.log('='.repeat(30)+'\n');

console.log("Tesing with ratio of 3.5 (xxxhdpi Android devices)");
analyseOptimalBorderWidth(3);

As you can see that on iOS a borderwidth of 1 will always use a round number of pixels. So what we should test instead is the outcome of tricky borderwidth like 1.8, this should result in a non-round number of pixels. Will iOS show some blurry pixels in that case? And if so will they overlap with the text input or not.

Tesing with ratio of 1 (mdpi Android devices)

Setting borderWidth to 1 will use 1 pixel(s) ✔
Setting borderWidth to 1.3 will use 1.3 pixel(s) ❌
Setting borderWidth to 1.5 will use 1.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 1.8 pixel(s) ❌
Setting borderWidth to 2 will use 2 pixel(s) ✔
Setting borderWidth to 1 will use 1 pixel(s) ✔

Tesing with ratio of 1.5 (hdpi Android devices)

Setting borderWidth to 1 will use 1.5 pixel(s) ❌
Setting borderWidth to 1.3 will use 1.9500000000000002 pixel(s) ❌
Setting borderWidth to 1.5 will use 2.25 pixel(s) ❌
Setting borderWidth to 1.8 will use 2.7 pixel(s) ❌
Setting borderWidth to 2 will use 3 pixel(s) ✔
Setting borderWidth to 0.6666666666666666 will use 1 pixel(s) ✔

Tesing with ratio of 2 (xhdpi Android devices, iPhone 7, 8, 11)

Setting borderWidth to 1 will use 2 pixel(s) ✔
Setting borderWidth to 1.3 will use 2.6 pixel(s) ❌
Setting borderWidth to 1.5 will use 3 pixel(s) ✔
Setting borderWidth to 1.8 will use 3.6 pixel(s) ❌
Setting borderWidth to 2 will use 4 pixel(s) ✔
Setting borderWidth to 0.5 will use 1 pixel(s) ✔

Tesing with ratio of 2.5 (?)

Setting borderWidth to 1 will use 2.5 pixel(s) ❌
Setting borderWidth to 1.3 will use 3.25 pixel(s) ❌
Setting borderWidth to 1.5 will use 3.75 pixel(s) ❌
Setting borderWidth to 1.8 will use 4.5 pixel(s) ❌
Setting borderWidth to 2 will use 5 pixel(s) ✔
Setting borderWidth to 0.4 will use 1 pixel(s) ✔

Tesing with ratio of 3 (xxhdpi Android devices, iPhone 7 Plus, 8 Plus, X, XS, XS Max, 11 Pro, 11 Pro Max)

Setting borderWidth to 1 will use 3 pixel(s) ✔
Setting borderWidth to 1.3 will use 3.9000000000000004 pixel(s) ❌
Setting borderWidth to 1.5 will use 4.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 5.4 pixel(s) ❌
Setting borderWidth to 2 will use 6 pixel(s) ✔
Setting borderWidth to 0.3333333333333333 will use 1 pixel(s) ✔

Tesing with ratio of 3.5 (xxxhdpi Android devices)

Setting borderWidth to 1 will use 3 pixel(s) ✔
Setting borderWidth to 1.3 will use 3.9000000000000004 pixel(s) ❌
Setting borderWidth to 1.5 will use 4.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 5.4 pixel(s) ❌
Setting borderWidth to 2 will use 6 pixel(s) ✔
Setting borderWidth to 0.3333333333333333 will use 1 pixel(s)

Testing with ratio of 1 (mdpi Android devices)

Setting borderWidth to 1 will use 1 pixel(s) ✔
Setting borderWidth to 1.3 will use 1.3 pixel(s) ❌
Setting borderWidth to 1.5 will use 1.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 1.8 pixel(s) ❌
Setting borderWidth to 2 will use 2 pixel(s) ✔
Setting borderWidth to 1 will use 1 pixel(s) ✔

Testing with ratio of 1.5 (hdpi Android devices)

Setting borderWidth to 1 will use 1.5 pixel(s) ❌
Setting borderWidth to 1.3 will use 1.9500000000000002 pixel(s) ❌
Setting borderWidth to 1.5 will use 2.25 pixel(s) ❌
Setting borderWidth to 1.8 will use 2.7 pixel(s) ❌
Setting borderWidth to 2 will use 3 pixel(s) ✔
Setting borderWidth to 0.6666666666666666 will use 1 pixel(s) ✔

Testing with ratio of 2 (xhdpi Android devices, iPhone 7, 8, 11)

Setting borderWidth to 1 will use 2 pixel(s) ✔
Setting borderWidth to 1.3 will use 2.6 pixel(s) ❌
Setting borderWidth to 1.5 will use 3 pixel(s) ✔
Setting borderWidth to 1.8 will use 3.6 pixel(s) ❌
Setting borderWidth to 2 will use 4 pixel(s) ✔
Setting borderWidth to 0.5 will use 1 pixel(s) ✔

Testing with ratio of 2.5 (?)

Setting borderWidth to 1 will use 2.5 pixel(s) ❌
Setting borderWidth to 1.3 will use 3.25 pixel(s) ❌
Setting borderWidth to 1.5 will use 3.75 pixel(s) ❌
Setting borderWidth to 1.8 will use 4.5 pixel(s) ❌
Setting borderWidth to 2 will use 5 pixel(s) ✔
Setting borderWidth to 0.4 will use 1 pixel(s) ✔

Testing with ratio of 3 (xxhdpi Android devices, iPhone 7 Plus, 8 Plus, X, XS, XS Max, 11 Pro, 11 Pro Max)

Setting borderWidth to 1 will use 3 pixel(s) ✔
Setting borderWidth to 1.3 will use 3.9000000000000004 pixel(s) ❌
Setting borderWidth to 1.5 will use 4.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 5.4 pixel(s) ❌
Setting borderWidth to 2 will use 6 pixel(s) ✔
Setting borderWidth to 0.3333333333333333 will use 1 pixel(s) ✔

Testing with ratio of 3.5 (xxxhdpi Android devices)

Setting borderWidth to 1 will use 3 pixel(s) ✔
Setting borderWidth to 1.3 will use 3.9000000000000004 pixel(s) ❌
Setting borderWidth to 1.5 will use 4.5 pixel(s) ❌
Setting borderWidth to 1.8 will use 5.4 pixel(s) ❌
Setting borderWidth to 2 will use 6 pixel(s) ✔
Setting borderWidth to 0.3333333333333333 will use 1 pixel(s) ✔

Yup seems not really a lot of logic we can wrap around all this - sometimes it's working sometimes not. And for sure we can try to find exact calculation which will work for everything LOL. But based on the result - i do not see any possible fix which can be based on some logic. BTW what do you think about my comment above?

@narefyev91 Would you please share the results of setting a border width of 1.8 on iOS.
The idea of using a separator actually raises more questions. The View width is set to 1 so we will still get some blurry pixels but the issue would be reproducible. Why the issue only occur with borderWidth?

@narefyev91 Would you please share the results of setting a border width of 1.8 on iOS.
The idea of using a separator actually raises more questions. The View width is set to 1 so we will still get some blurry pixels but the issue would be reproducible. Why the issue only occur with borderWidth?

Interesting that width does not have the same effect of blurry pixels

@narefyev91 All values resulted in same width? That's weird

yup - i think IOS rounding that border to same value

@narefyev91 Do you have an update for your proposal? Mainly about the root cause, do you think the bug is on RN or Android itself
Also @narefyev91 thanks a lot your collaboration here. Such tiny bugs are sometimes the hardest.
Yup - hope i'm trying to help here a little bit 😁.
In my view - the issue is coming from RN - that doing a lot of custom logic for borders and border radius.

@narefyev91 Do you have an update for your proposal? Mainly about the root cause, do you think the bug is on RN or Android itself
Also @narefyev91 thanks a lot your collaboration here. Such tiny bugs are sometimes the hardest.

Yup - hope i'm trying to help here a little bit 😁. In my view - the issue is coming from RN - that doing a lot of custom logic for borders and border radius. Also this is old issue - but seems still has correct explanation why we see that issue with blurry border https://stackoverflow.com/a/24712372

@s77rt but also interesting that in flatter they have the same issue with 1px border https://github.com/flutter/flutter/issues/13675#issuecomment-759398861

@narefyev91 What do you propose to move forward?

@narefyev91 What do you propose to move forward?

I will suggest to move away from custom calculation for border - because based on your discovering we already have inconsistency between platforms. As solution should be generic - i will suggest to add Separator View - with width 1, in case that width in Android renders correctly - and do not have any issues with styling.

@s77rt This is an image from bare Android App
Issue still there - that's how Android renders it's own border

@narefyev91 Having blurry pixels is not an issue. As long as adjacent elements don't get drawn on those blurry pixels I'm okay with that.

@narefyev91 Having blurry pixels is not an issue. As long as adjacent elements don't get drawn on those blurry pixels I'm okay with that.

But blurry pixels are not counting as a wall to prevent View of start drawing inside that area

But on a bare Android App will they act as a wall?

But on a bare Android App will they act as a wall?

nope - it's doing the same as we already see

@narefyev91 Thank you! I have just asked on Slack on how we should move forward https://expensify.slack.com/archives/C01GTK53T8Q/p1682425579144149
cc @puneetlath

RETESTS SUMMARY
This fix is verified on Branch PR Draft narefyev91:add-new-separator-for-action-composer
Tests are conducted on the following devices:
Google Chrome Version 112.0.5615.121 (Official Build) (arm64) at Mac OS Ventura 13.3.1
Safari Version 16.4 (186<IP_ADDRESS>.23) at Mac OS Ventura 13.3.1
Expensify Desktop app - New Expensify Electron Version v1.3.1-0, Electron Version 22.3.6 (22.3.6)
iOS native app - iPhone Simulator Version 14.2 (986.5), iOS 16.2, SimulatorKit 627, CoreSimulator 885.2
Safari on iOS - iPhone Simulator 14 iOS 16.2
Android native app v1.3.1-0 - Android Emulator -Nexus_5X_API_TiramisuPrivacySandbox:5554
Chrome 101.0.4951.74, Operating system Android13; Build/TRA4.221021.001.B1
The above tests are executed with a 100% pass value

📣 @m4rtag! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@puneetlath, @s77rt, @narefyev91 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

This is on staging.

The PR that introduced the bug has been identified: This is mostly a bug on Android. No PR to pinpoint here.
The offending PR has been commented on: n/a
A discussion in #expensify-bugs has been started: I don't think this is applicable here (cc @puneetlath).
Determine if we should create a regression test for this bug: No, this is a very low priority bug.

Thanks @s77rt. Checklist completed and contract offers sent.

All paid. Thanks everyone!


Integrating buildkit into packaging process

Inspired by #366. As always, feel free to contribute ideas. Nothing here's set in stone, and more feedback can help me design something better from the outset.
Motivation
Using buildkit in packaging scripts solves the problem of integrating with Linux packaging scripts (e.g. #37). This additionally has multiple beneficial side-effects explained below.
Summary

Minimal impact to buildkit and existing file structures
All packaging scripts include buildkit and a user config bundle
Add feature to buildkit to apply patches
Simplify domain substitution code
Use more Python in packaging scripts if it's easier.

Ideas

Copy buildkit and user config bundle into or alongside packaging scripts. Make user specify resulting directory of packaging scripts (e.g. debian directory, Windows files, macOS files) or the packaging script (e.g. PKGBUILD, which downloads everything itself) explicitly, since they don't have to go into a buildspace tree.
Make buildkit autogenerate patch at end of user config bundle patch_order to apply domain substitution only to the intersection of files defined in domain_substitution_list and files modified by patches in patch_order.

This is better than domain substituting the patches entirely, but the user still needs to verify that patches don't have substituted domains when submitting them.
Don't have any contexts in these patches to keep size small.

Or, maybe make this an auto-generated binary patch to handle files that are minified or have characters that don't translate well to a patch. That way, all files in the domain substitution list can be modified. This may also help with performance compared to a regular huge patch.

For Debian, need to see if it's possible to hook into Debian scripts to autogenerate and apply this before running GN (ideally right after applying all patches), and revert it after the build command has finished (ideally right before unapplying patches). Hooking into quilt would be a challenge to handle all possible scenarios if the user uses quilt directly.
Then the hacky patch domain substitution reversal code, patch verification, and patch domain substitution can all be removed.

Add an environment variable BUILDKIT_USER_BUNDLE to specify the user config bundle path. But, still leave the option to override this in the buildkit CLI.

To Do

[x] Investigate feasibility and implementation of binary patches for domain substitution.

If it fails, investigate using regular patches or keeping things the way they are.

[ ] Windows: Migrate existing batch scripts to Python (batch scripts are a pain to use and maintain), using buildkit's API (not CLI). Do this after solving the above problems first.
[x] linux_simple and macos packaging types: Modify shell scripts

I tried looking around, but I couldn't find a solution that meets my requirements.
A simple method with a straight-forward implementation I'm considering uses a .tar.gz of a file tree that mirrors the buildspace tree, but contains only the original versions of the files modified by domain subsitution. Another plain-text file will contain the CRC32 checksums of the files in the archive after they have been domain substituted. These files are then used like the following:

Substituting domains is pretty straight-forward: For each file in the domain substitution list, substitute the domains in memory. If no substitutions were made, go to the next file and repeat these steps. Otherwise, store the original file in the .tar.gz, compute the CRC32 checksum, and replace the original file with the substituted one.
Reversal is pretty straight-forward as well: For all files in the CRC32 checksum list, compute the hashes of the actual files. For any file that has a hash mismatch, let the user know and continue. If hash checking completes with no mismatches, unpack the .tar.gz over the buildspace tree, replacing all the files that were already present. Then delete the .tar.gz and CRC32 hashes (they need to be recomputed if any files with domains get modified).

Note about compression: From the results of a benchmark of gzip, bzip2, and lzma, it seems that gzip with compression level 1 will suffice to compress the tar archive as these files are mainly source code, and speed is more important than saving a little on size.
If anyone has a better method, I'd like to hear it. Otherwise, I'm going to start implementing this.

Implemented, except Windows stuff. That can be done whenever, if necessary.


Remove logging on info level from kafka service

To make it possible to call testConnection periodically.

@weeco I ended up moving the whole log up, let me know what you think.


Warning about discarding return value

This HIP call expects the return value to to be discarded.
https://github.com/illuhad/hipSYCL/blob/5296ee524df046eaffa58ca4227f062a912bb4b6/include/hipSYCL/sycl/backend/clang.hpp#L57
/bin/../include/CL/../hipSYCL/sycl/backend/clang.hpp:57:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
  hipConfigureCall(grid, block, shared, stream);

... I think it expects it not to be discarded ;) The HIP headers are quite prone to producing warnings here and there, especially when compiling with clang.. We may have to add this warning to the list of warnings that are suppressed when including the HIP headers.

That's what I meant. Note to self: proof read before sending.

Should be fixed by PR #226.


DRILL-5405: Add missing operator types

It's CoreOperatorType enum from UserBitShared.proto [1].
[1] https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/UserBitShared.proto#L266

From the comments on 214, looks like this change in not required. I could not find the resolution/ discussion on the dev list, as mentioned in the comments. But since a new operator type was not added in the PR, this change is not necessary. -0 for this change.

@sudheeshkatkam thanks for pointing out on the discussion. I will close this PR but I'll update Jira to reflect discussion points.


Replace DeveloperError with Check in BoundingRectangle

Part of #4794

Oops, sorry about that. It was muscle memory.
I have fixed this.


Fix/ci

This pull request includes updates to the GitHub Actions runner, transitioning it to macOS-14 and Xcode version 15.2.
These changes aim to resolve the ongoing CI issue associated with the Package.resolved file structure.

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@volodymyr-chekyrta 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.