fix(cdc): create postgres publication in Meta for cdc source job

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The patch has been tested on release-2.1:
https://buildkite.com/risingwave-test/ch-benchmark-pg-cdc-shared-source/builds/130#01939be7-f53e-45bd-bd3f-9fd24a582cef
close https://github.com/risingwavelabs/risingwave/issues/19681
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

done in https://github.com/risingwavelabs/risingwave/pull/19805


Disable socket factory for pre JDK11

Purpose
As discussed in https://github.com/prestosql/presto/issues/1169, the socket channel is the cause of the slowdown with JDK 11. As JDK-8131133 is fixed from JDK 9, the workaround is not necessary anymore. We can safely disable the socket factory usage if the runtime is JDK 11 or later. Confirmed the communication between server and client works well even with HTTP 2.
Overview

Add JavaVersion class from presto-server module to parse Java version string. Although we expected to use Runtime.getVersion, it does not exist in pre-JDK 9.
Check runtime version and disable socket factory if JDK 11 or later.

Thanks!


Minor edit for style consistency

There is a function given in text where similar utilities are given as python-like code.
This PR adjusts one such instance for style consistency with the rest of the document.
Feel free to close if the previous representation is preferred.

Do I need to push another commit that signs this branch or is this not the right venue to suggest these changes?

Lgtm


232 show album name in playlists and queue

Addresses #232
I inserted a column for the album name in the playlist view, as was described in the issue.
I'm not entirely happy with how the UI looks with it now. I think it would look best if we showed the album name beneath the artist, but I feel like that would be worse since it wastes so much vertical space.
I'm attaching a screenshot so we can discuss.

Since I am not experienced with both Rust and GTK I'd be happy for any pointers as to what could be improved here, even though this is a small change.
Thanks for the awesome spotify client!

Hey,
Sorry for not updating this for a little while, I'm embarrassed how long it took me to get this far.
Here's a side-by-side comparison of the changes:
Before:

After:

Here's a summary of the UI changes:

The index number of each song has been moved into the title
The cover of each song is displayed
The currently playing song is still marked with a little play icon. The cover is not visible here.

As you can see, the vertical space usage is exactly the same, horizontal space is slightly increased by having the index as part of the title.
In my opinion, it's quite functional this way and looks better than before.
I would still like to implement your suggestion to only show the cover in actual playlists, not in albums. I wanted to show this to you for feedback while I work on that.
I'm excited to hear what you think!

Hey, no worries about that, I can't say I'm being very active on the project either. Thank you so much for the work you've been putting into this!!
This looks really good, I think you're definitely headed in the right direction! If you end up working on having a different look for albums (no cover, only index) then we might even get rid of the index for this kind of view -- it does not make that much sense in a playlist context anyway.
Just tell me how far you're willing to go, if you want to merge as is I'll have a closer look/review, it's already quite good and functional after all!
Thanks a lot!

Hey,
Thanks for the positive feedback!
I just implemented not showing album covers for each song in album views.
Regarding the index in the different views:
I originally got rid of the index in the album view, then I reread your comment and realized that your suggestion was to get rid of the index in the actual playlist views but keeping it for albums, right? I understood the exact opposite when first reading it.
My reasoning was that albums generally don't have as many tracks as playlists, so albums don't really need an index. Playlists might have a lot of songs so it's good to know in which position a song is and how many songs in total the playlist has.
Your reasoning was that the index isn't very meaningful in a playlist, but is meaningful in an album?
I see the arguments in favor of the index for both cases now so I decided to keep it as is for now.
Actual playlists still look the same as in the screenshot above, albums now look like this:

I consider this ready for review now but I am open towards changes on the UI side of things.
If you are also happy with the UI, I will be looking forward to your code review.
Slightly related is issue #208 'Track titles aren't aligned in album view', which can be closed IMHO after merging this.

Hi! Sorry, I could have been clearer indeed! I see your point, but I think I'd prefer having the numbers for album tracks only -- in the context of a playlist, those numbers don't mean much and are subject to change everytime the playlist is updated, although I do understand that it helps to track progress. The other reason I prefer having numbers for album tracks are, well, aesthetic one, so that we don't have those empty spaces :p Again, if you prefer to stop here that's perfectly fine!

Hi,
I think it was me who misread what you wrote, but it doesn't matter!
I agree about the empty spaces, that is a really good reason for keeping them were they originally where.
To recap:

The album view stays exactly the way it was (so no mini cover images, index numbers stay where they are, just like the before image from above)
All other playlist views (now playing, actual playlists, etc.) will have miniature album covers and no index at all (like in the screenshot above from the playlist but without the index numbers at the beginning of each title)

Thanks for bearing with me. I appreciate that you are opinionated about UI details, I'd rather do it right than do it fast!

I just made the changes like I wrote above.
Album:

Playlist:

Looking at the screenshots I think it looks better than all the previous iterations.
It's ready for review from my side now, but if you have any suggestion for the UI it probably makes sense to discuss / implement changes before starting code review.

I'd prefer having the numbers for album tracks only -- in the context of a playlist, those numbers don't mean much and are subject to change everytime the playlist is updated, although I do understand that it helps to track progress.

It is also helpful to have the numbers when you scroll past a page boundary in a playlist and the next page refuses to load. I can't remember the details, but I have encountered that issue before. If it wasn't for the numbers, it would be much harder to see what happened.

I'd prefer having the numbers for album tracks only -- in the context of a playlist, those numbers don't mean much and are subject to change everytime the playlist is updated, although I do understand that it helps to track progress.

It is also helpful to have the numbers when you scroll past a page boundary in a playlist and the next page refuses to load. I can't remember the details, but I have encountered that issue before. If it wasn't for the numbers, it would be much harder to see what happened.

Ah interesting. That has not happened for me so far. I'm happy with either having the index numbers or keeping them out. What about you, @xou816 ?

Interested in learning more about the issue if anything :p but I wouldn't make a decision based on this alone! if better debug tools are needed that's another issue :)

@Noelle id be interested in your opinion on this too!

Actually I completely missed that you said it was ready for review, my bad! Just saw the above screenshots, really like it, I'll have a closer look!!

@jannuary  i'd be interested in your opinion on this too!

Not a fan, unfortunately - seems quite a bit more crowded and messy than the status quo. What's the problem to be solved with album covers/names in playlists?

I understand your critique but I do like seeing the album covers and find them useful. Do you have a suggestion on how to change it while still keeping the cover images? Or is it not really possible to resolve because you prefer a more minimal aesthetic?

Unsure. Maybe spacing the covers a bit more far apart would help?

I understand your critique but I do like seeing the album covers and find them useful. Do you have a suggestion on how to change it while still keeping the cover images? Or is it not really possible to resolve because you prefer a more minimal aesthetic?

Unsure. Maybe spacing the covers a bit more far apart would help?
Do you mean decreasing the size of the covers like this:

Do you mean decreasing the size of the covers like this:

No, the size's probably fine - you should increase the margins.

With slightly increased margins to the right, it looks like this:

An improvement in my opinion.

Hm, maybe 12px in each direction could work?

Actually, maybe 6 for top, start and bottom margins, but 12 for column spacing:

There's probably room for small improvements (mostly to improve legibility when using selection mode) but I think it's fine to merge this for now ;) it definitely helps identifying where a track comes from in contexts other than that of an album while keeping the same space usage, and that's the way the official app does things too!
If needed we'll open other issues along the way! But for now I think the improvement is clear over the current situation (fixes a recent issues with track numbers in the artist screen as well)

Looks good to me, merging when I get to a computer :) thank you very much for your work @abegert !
I'm sorry I had someone else chime in last minute, I really value their input as far as design is concerned, but next time I'll have them involved earlier on 😁
Thank you both!
Oh and @jannuary if you need help rebasing after this gets merged feel free to reach out! Hope this won't break things too badly! (I'm sure not)

Looks good to me, merging when I get to a computer :) thank you very much for your work @abegert ! I'm sorry I had someone else chime in last minute, I really value their input as far as design is concerned, but next time I'll have them involved earlier on grin Thank you both!
Oh and @jannuary if you need help rebasing after this gets merged feel free to reach out! Hope this won't break things too badly! (I'm sure not)

Oh I don't mind at all, looking at their design overhaul PR, @jannuary is definitely more design savvy than I am. I was happy to get constructive feedback.
Thanks for merging and all the feedback to both of you!


Ida 9 support?

Just tried a "fullrun" using ida 9 and it failed.  Before I post a bunch of information about it, just wanted to make sure it is expected to run correctly with the new version.  If not, are there any plans to make it compatible with ida 9?

This is currently expected and won't be fixed until I get IDA 9 or someone else decides to take the time to make sure it works between both IDA 7/8 and 9
The reason for this is they changed how the Structs and Enums work in IDA 9 so the entire way to insert the last portion of the fullrun fails.
IDA 9 currently should only work with ffxiv_idarename.py

IDA 9 has completely redone the Type system, so nothing works at all with the other 2 scripts. If you want to use those import with IDA 8 and then upgrade with IDA 9 as I'm not dealing with figuring out bad IDA docs again for the next month just to get it working.


Add Central Magnet School

I'm interested in having my school added to this list.
Domain
The domain of my school is central.rcs.k12.tn.us. However, the domain for the district is simply rcschools.net.
Long-term IT-related courses
This school has an AP Computer Science class and two other programming courses, all of which last one year. Proof for all of these classes' existence can be found here on page 8.
Email
My school issues email addresses. This can be proved by going to email.rcschools.net, which brings up a login field, showing there is an email server there.
I understand that the school emails are issued at a different domain than that of the school website. If this means that I need to change the pull request in some way, please tell me. I'm not quite sure how application for the education discount works, so I don't know if it's a problem that the email domain isn't a k12.tn.us domain. It should be enough for proof that on the central.rcs.k12.tn.us homepage, there is a link to email.rcschools.net under Resources > Student Links > Office 365 Email.
Thanks!

On further thought, I'm thinking that the file rcschools.txt should go under lib/net instead of what I have right now. Is this correct?

@disorientedperson Pull request merged. Thank you!


C++17

Hi,
Is there a way to use reflect-cpp with projects that only c++17 compatible?

This is a bit tricky...we use C++ concepts quite a bit, which is C++ 20 feature. But maybe we can find a workaround using Macros. You are not the first one to request this, to be honest.

It would be amazing if it can be used in c++17/c++14 projects. (And the option of disabling exceptions)
Thank you.

As far as the exceptions are concerned, we already have that:
https://github.com/getml/reflect-cpp/blob/main/docs/result.md

Here is the next problem: The way we pass strings as a template parameter is a C++ 20 feature:
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0732r2.pdf
As explained in this proposal, if did. this in C++ 17, we would always have to explicitly pass the string length as well. So instead of:
rfl::Field<std::string, „firstName“>
we would have to write
rfl::Field<std::string, „firstName“, 9>

@liuzicheng1987 I am not sure that there will be an elegant solution for C++17, as I understand one of the main features of your library is that macros are not required, I would say to make it compatible with C++17 adding simple macros just to add text will be fine.
I would recommend you to check this, this solution allows add text as a template argument in C++17 without providing an extra length argument. I understand that all this decltype("text"_something) is not elegant, but I would say just create a simple macro, sth like:
#if __cplusplus >= 202002L
#define Name(text) decltype(text##_something)
#else
#define Name(text) text
#endif

And declare field like(only necessary for C++17, but for C++20 also will work):
rfl::Field<std::string, Name("firstName")>
The other problem is that std::is_constructible will be false in C++17 for this case:
struct T {
   int a;
};
static_assert(std::is_constructible_v<T, int>); // false

But it is easy to fix. I am not completely sure but it looks like the rest code should work without big changes in C++17.


"Poiana Lacului", "Cătunași" are listed in the drop-down menu

Description:
When user writes "Pietroșani" and "Bădești" the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Pietroșani"

Expected results
The location appears in the drop-down menu as "Pietroșani, Argeș (Pietroșani)"

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Cătunași"

Expected results
The location appears in the drop-down menu as "Cătunași, Argeș (Poiana Lacului)"


Rewrite site-menu css

Summary | Résumé
CSS rewrite for the site-menu component.

This is fantastic! Just noticed a few small things, I am going to put them all in this comment.
Not all elements with role="menuitem" are <a> tags. The menu also accepts <span> tags as menu items. If a span is used it currently renders like this:

Looks like a align-items: center; display: flex; could fix the issue.

When rendering topbar, if focused on the top-level menu item the submenu trigger button text turns white, creating a colour contrast issue.

And lastly, this may come down to a token issue. I noticed the container size is really large, I believe it was this size before Nick adding styling to the site-menu. I am wondering do we adjust the tokens or do we make an easy way for someone to adjust the container width (StyleAPI)?

@ethanWallace fixed the two issues you found, thanks for pointing them out.
The container size is currently the same as the container size we are using on the docs page. I agree, it is quite big and we should give users the ability to change it. We could either do StyleAPI or we could add a containerSize prop that lets them select any of our supported container sizes. What do you think?

@ethanWallace fixed the two issues you found, thanks for pointing them out. The container size is currently the same as the container size we are using on the docs page. I agree, it is quite big and we should give users the ability to change it. We could either do StyleAPI or we could add a containerSize prop that lets them select any of our supported container sizes. What do you think?

I think it would be best as a styleAPI property. Something like customContainerWidth could set the max width of the container.

@ethanWallace I'll add it as part of the sidebar changes since it's more of a feature than a rewrite.


394 fix linting

Fix Linting and Formatting Issues
Description
This pull request resolves multiple linter and formatting issues across the repository to enhance code consistency and ensure compliance with our code quality standards. Key changes include:

Linting Corrections: Resolved various linting errors for better code readability and maintainability.
Configuration Updates: Adjusted pyproject.toml and related config files for improved compatibility with linting tools.
Code Cleanup: Addressed whitespace, line length, and unused imports flagged by the linter.

@hanlunBCRegistries - can you please provide an update on this tix?

@Maribeth-Wilson This ticket is complete and waiting for code review

@hanlunBCRegistries do you mind taking off the DRAFT flag so I can review it?

@EPortman Just updated, thank you for pointing it out


Scrollbar end buttons

Make sure these boxes are checked before submitting your issue -- thank you!

[ x] Check FAQ and Caveats
[ ] Search if there's already one reported in Issues
[ ] Prepare a JSFiddle reproducing the issue

perfect-scrollbar JSFiddle

[ ] Provide a page or source code where the issue can be checked

Hi,
I'm trying to create end buttons for a scrollbar. The little arrows when you click on it scrolls in that direction. Is there already a solution for that in perfect-scrollbar? If not how could I place my custom elements fixed at the ends of perfect-scrollbar? Currently they just scroll up with the content using position: absolute.
Kind regardes
Marcel
PS: love how clean the implementation is. No dirty style hacks. :)

Me too! How to use buttons instead of a scrollbar? :)


Close all dialogs

I've had some senarios where I wanted to close all dialogs. I used a while loop to do this together with the Get.isDialogOpen. But I gues this is not that elegant. Could we have it implemented in Get? So Get.closeAllDialogs() ? Let me know what you think :)

Why don't you use Get.until for this?
This is not documented, but let's say you have a base on Navigator.popUntil, you should know that it closes all routes until a bool function returns true.
Get already has isDialogOpen, snackbarOpen and etc, I think it would be even intuitive for you to try something like:
 Get.until((route) => Get.isDialogOpen);

I love that! Thanks I will use that.


Upgrade minimum version to Java 8

Java 8 is the standard JDK version, currently in update 60+. To benefit from the latest language features we must upgrade the minor version to Java 1.8 before we get a stable library version of 1.0

since 0.7


fix clap handling for primary/secondary

fix for nat-tcp lock issue
add script for temp disabling aslr for primary/secondary

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   50.18%   50.18%
=======================================
  Files          70       70
  Lines        4348     4348
=======================================
  Hits         2182     2182
  Misses       2166     2166

Impacted Files
Coverage Δ

framework/src/config/mod.rs
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c238ec...669cfb3. Read the comment docs.


[Bug Report] multi tree close cascade, such as A node all disabled, A cannot select

Element UI version
1.4.8
OS/Browsers version
61.0.3163.100
Vue version
2.5.2
Reproduction Link
https://jsfiddle.net/qaund6aa/
Steps to reproduce

勾选 二级 2-1
查看 二级 2-1 不会被勾选

What is Expected?

勾选 二级 2-1
二级 2-1 能被勾选

What is actually happening?

勾选 二级 2-1
二级 2-1 未并勾选

This is fixed in version 2.0. The fix may not be merged to 1.x because it uses another implementation.


Not working in vscode — CLI version does

So, for a while now, stylefmt doesn't seem to be able to format CSS / SCSS documents.
I'm using vscode 1.10.1, stylefmt v2.2.2 and stylelint v0.23.0 which are the latest at the time of this writing.
I'm using a .stylelintrc file with the following options:
{
  "extends": "stylelint-config-standard",
  "rules": {
    "number-leading-zero": "never",
    "declaration-empty-line-before": null,
    "at-rule-empty-line-before": null,
    "rule-empty-line-before": null,
    "rule-nested-empty-line-before": null,
    "selector-pseudo-element-colon-notation": null
  }
}

No errors are output (like when stylelint is out of date).

Hello, @ivancuric,
Most likely this is related to #67.

Please, look at 2.2.3 version. Potentially, this should fix the problem.


CLI: scope flows crashing

Instance of crash:
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope run  -p -- ./cribl start
Starting Cribl LogStream...
...
Cribl LogStream started

nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope flows
ID	HOST IP	HOST PORT	PEER IP	PEER PORT	LAST SENT	DURATION
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope dash
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope flows
panic: interface conversion: interface {} is nil, not string

goroutine 1 [running]:
github.com/criblio/scope/flows.getFlowEvents(0x12165c0, 0xc000138620, 0xc000314ab0, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/flows/flow.go:158 +0xa9f
github.com/criblio/scope/flows.GetFlows(0xc00033a870, 0x45, 0x12165c0, 0xc000138620, 0xc000138620, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/flows/flow.go:72 +0x8c
github.com/criblio/scope/cmd.glob..func5(0x1b55420, 0x1badf70, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/cmd/flows.go:59 +0x46c
github.com/spf13/cobra.(*Command).execute(0x1b55420, 0x1badf70, 0x0, 0x0, 0x1b55420, 0x1badf70)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:854 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0x1b55ea0, 0x5, 0xc000330460, 0x10b5be5)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895
github.com/criblio/scope/cmd.Execute()
	/home/runner/work/appscope/appscope/cli/cmd/root.go:25 +0x50
main.main()
	/home/runner/work/appscope/appscope/cli/main.go:22 +0x93

Another instance of crash:
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope run  -p -- ./cribl start
Starting Cribl LogStream...
...
Cribl LogStream started

nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope flows
ID	HOST IP	HOST PORT	PEER IP	PEER PORT	LAST SENT	DURATION
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope dash
nick@nick-VirtualBox:~/releases/2.4.4-RC1/cribl/bin$ ./scope flows
panic: interface conversion: interface {} is nil, not string

goroutine 1 [running]:
github.com/criblio/scope/flows.getFlowEvents(0x12165c0, 0xc000138620, 0xc000314ab0, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/flows/flow.go:158 +0xa9f
github.com/criblio/scope/flows.GetFlows(0xc00033a870, 0x45, 0x12165c0, 0xc000138620, 0xc000138620, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/flows/flow.go:72 +0x8c
github.com/criblio/scope/cmd.glob..func5(0x1b55420, 0x1badf70, 0x0, 0x0)
	/home/runner/work/appscope/appscope/cli/cmd/flows.go:59 +0x46c
github.com/spf13/cobra.(*Command).execute(0x1b55420, 0x1badf70, 0x0, 0x0, 0x1b55420, 0x1badf70)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:854 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0x1b55ea0, 0x5, 0xc000330460, 0x10b5be5)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895
github.com/criblio/scope/cmd.Execute()
	/home/runner/work/appscope/appscope/cli/cmd/root.go:25 +0x50
main.main()
	/home/runner/work/appscope/appscope/cli/main.go:22 +0x93

session.zip

digging through the events.json file from the attached zip with this command:
cat Downloads/session/events.json | egrep "(net\.conn\.open)|(net\.conn\.close)" | grep net.host.port | grep -v net.peer.port yielded 19 events.
  The results above prove that this isn't always true.

Yeah, the fix should be relatively easy on the CLI side. My question is, what are these flows? From a libscope perspective what IP.TCP traffic has a host IP of all 0's and a 0 port?

Closing as duplicates of #309 and #310 where the root cause is explained. The wonky all-0's addresses and ports are from UNIX-domain sockets.


Fix to specify File.open

When using with live_paper gem, line 168  "@f = open(infilename, "rb")" resolved to the wrong open. Easiest fix is to specify File.open.

Nice fix! :)


Add admin commission and vendor fee?

When can you add it?
100$ for it to be added.

I have a more advanced marketplace script with these features and more available, email me
<EMAIL_ADDRESS>with subject Bitcoin market if interested!

What? Get on skype?

Från: Mast3rMind<EMAIL_ADDRESS>Skickat: den 10 maj 2020 17:20
Till: 1234max/MultiVendorBitcoinMart<EMAIL_ADDRESS>Kopia: Lucce2<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Ämne: Re: [1234max/MultiVendorBitcoinMart] Add admin commission and vendor fee? (#11)
I have a more advanced marketplace script with these features and more available, email me
mast3rmind<EMAIL_ADDRESS>with subject Bitcoin market if interested!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/1234max/MultiVendorBitcoinMart/issues/11#issuecomment-626344021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APMPYIBP7FWMYXNQC6PTORLRQ3A47ANCNFSM4MT7OCIA.

back, how's the server comming?

Från: Mast3rMind<EMAIL_ADDRESS>Skickat: den 10 maj 2020 17:20
Till: 1234max/MultiVendorBitcoinMart<EMAIL_ADDRESS>Kopia: Lucce2<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Ämne: Re: [1234max/MultiVendorBitcoinMart] Add admin commission and vendor fee? (#11)
I have a more advanced marketplace script with these features and more available, email me
mast3rmind<EMAIL_ADDRESS>with subject Bitcoin market if interested!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/1234max/MultiVendorBitcoinMart/issues/11#issuecomment-626344021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APMPYIBP7FWMYXNQC6PTORLRQ3A47ANCNFSM4MT7OCIA.


"Where do I belong",  issue while sorting the array

function where(arr, num) {
// Find my place in this sorted array.
var newArr = [];
newArr=arr.sort();
return newArr;
}
where([1, 3, 20, 3], 5);
o/p : [1,20,3,3]
instead it should give output as [1,3,3,20]
in place of 20, numbers from 10 to 29 can be placed which gives the same issue... Could anyone pls help me out. Your response would be appreciated

Github issues are not for challenge help. Please visit the Help Chat for assistance. Thanks and happy coding!


Check whether entries are editable for toggle condition

The toggle location view edits button should only be added to the location view header if there are editable entries.
Edit roles maybe assigned by roles when the layer is decorated. In that case the toggle button might be shown but no entry is actually editable.

This must also be tested with new locations.


Latest update (25-Jan-2021) created hundreds of ordinary bookmarks

Add-on version
Add-on version: 3.2
Describe the bug
Today at lunchtime (UK/GMT), I found I had several hundred bookmarks, including multiple duplicates, from the BBC newsfeeds interspersed with my ordinary bookmarks.  Everything was normal this morning, but I see Livemarks had an (automatic) update earlier today.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I should see links to/from BBC newsfeeds only under the Livemarks folders I created for the RSS feeds.
Extra context
In the time it took me to fill out this issue form, Livemarks added over 60 bookmarks to the tail end of my bookmarks menu.  As an example, one (which I've not opened) entitled "Apple watch call saves cyclist swept into River Wye", URL https://www.bbc.co.uk/news/uk-england-hereford-worcester-55823987, appears six times, interspersed with others.
I have disabled Livemarks and the repeated adding of spurious bookmarks has stopped.
Livemarks 3.2 updated 25-January-2021, running in Firefox 76.0.1 (64-bit) under Windows 10 Pro.

This is strange, there hasn't been any significant change since 3.0 (October), maybe something Firefox is doing wrong on their side (they have been doing bookmarking updates for Firefox 84-86 and rolling out studies)? Note that January 25th was also when Firefox 85 got released.
Though you mentioned you're using Firefox 76, so I'm not really sure what could change here. Maybe @evilpie knows?
Also are you using Firefox 85 on any of your profiles? or syncing with a device using Firefox 85?

This is strange, there hasn't been any significant change since 3.0 (October), maybe something Firefox is doing wrong on their side (they have been doing bookmarking updates for Firefox 84-86 and rolling out studies)? Note that January 25th was also when Firefox 85 got released.
Though you mentioned you're using Firefox 76, so I'm not really sure what could change here. Maybe @evilpie knows?
Also are you using Firefox 85 on any of your profiles? or syncing with a device using Firefox 85?

I had this issue as well on Firefox 84.0.2.  Updating to Firefox 85 seems to have fixed it so far.

I had this issue as well on Firefox 84.0.2.  Updating to Firefox 85 seems to have fixed it so far.

In 84/85 Firefox developers made some significant changes to how bookmarks work, so it could be something was broken. Like Tim said our own code hasn't changed in this area for a while.

In 84/85 Firefox developers made some significant changes to how bookmarks work, so it could be something was broken. Like Tim said our own code hasn't changed in this area for a while.

Aha... thank you all for the switft and helpful replies.  Yes, I do have another copy of Firefox syncing with the one that I saw the problem on, and that other one is Firefox 84.0.2.   So I'm more than willing to believe this is (yet another) Firefox bug rather than the fault of the Livemarks plugin.  Oddly, that 84.0.2 still has Livemarks running and not screwing up.  Still, time to fix my FF, I think.

Aha... thank you all for the switft and helpful replies.  Yes, I do have another copy of Firefox syncing with the one that I saw the problem on, and that other one is Firefox 84.0.2.   So I'm more than willing to believe this is (yet another) Firefox bug rather than the fault of the Livemarks plugin.  Oddly, that 84.0.2 still has Livemarks running and not screwing up.  Still, time to fix my FF, I think.

Ok, I know that this topic has been closed and that I though that the issue was resolved however it isn't so pleas can you look into this again if you get time.
I have just deleted almost 2000 bookmarks for links to BBC pages.  I have attached an image of the links and as you will be able to see it is only a handful of pages that are getting bookmarked.
I fully understand that it's not something to do with your code but just thought I'd make yo aware that it is still happening.

Ok, I know that this topic has been closed and that I though that the issue was resolved however it isn't so pleas can you look into this again if you get time.
I have just deleted almost 2000 bookmarks for links to BBC pages.  I have attached an image of the links and as you will be able to see it is only a handful of pages that are getting bookmarked.
I fully understand that it's not something to do with your code but just thought I'd make yo aware that it is still happening.

Same here.  I've updated both copies of Firefox, hoping that might fix it, but it made no difference.  I've had to disable Livemarks, since I can't easily downgrade Firefox.

Same here.  I've updated both copies of Firefox, hoping that might fix it, but it made no difference.  I've had to disable Livemarks, since I can't easily downgrade Firefox.

We would need some steps on how to reproduce this. I just tried subscribing to BBC in a clean profile and all bookmarks are in the "BBC News" folder. Do you have uncommon settings?

We would need some steps on how to reproduce this. I just tried subscribing to BBC in a clean profile and all bookmarks are in the "BBC News" folder. Do you have uncommon settings?

And more importantly do you have other extensions that could interfere for example Default Bookmark Folder?.

And more importantly do you have other extensions that could interfere for example Default Bookmark Folder?.

I do use Default Bookmark Folder, 3.1.0, 27-Jan-2021.  The other extensions I have are Adblock Plus, 3.10.2 29-Jan-2021, JavaScript Toggle On and Off, 0.2.4 30-Nov-2020, and Print/print Preview, 1.3 12-Jun-2020.
Apart from the plugins, my install of Firefox 85.0 64-bit is identical on both machines, one running Windows 10 Pro 64-bit and the other running Windows 7 Pro 64-bit.  Firefox on the Win 7 machine was updated a week or so ago, on the Win 10 machine, yesterday evening.  Both have been running Firefox in its various versions for years.
So it seems, from what's been said, that the issue has been caused by a recent change in Firefox.  Nevertheless, that's the platform we have to work with.

I do use Default Bookmark Folder, 3.1.0, 27-Jan-2021.  The other extensions I have are Adblock Plus, 3.10.2 29-Jan-2021, JavaScript Toggle On and Off, 0.2.4 30-Nov-2020, and Print/print Preview, 1.3 12-Jun-2020.
Apart from the plugins, my install of Firefox 85.0 64-bit is identical on both machines, one running Windows 10 Pro 64-bit and the other running Windows 7 Pro 64-bit.  Firefox on the Win 7 machine was updated a week or so ago, on the Win 10 machine, yesterday evening.  Both have been running Firefox in its various versions for years.
So it seems, from what's been said, that the issue has been caused by a recent change in Firefox.  Nevertheless, that's the platform we have to work with.

I suspect removing "Default Bookmark Folder" should solve this: https://github.com/teddy-gustiaux/default-bookmark-folder/issues/399 (Since Firefox 85 the last used bookmark folder is remembered by Firefox itself)

I suspect removing "Default Bookmark Folder" should solve this: https://github.com/teddy-gustiaux/default-bookmark-folder/issues/399 (Since Firefox 85 the last used bookmark folder is remembered by Firefox itself)

Removing  "Default Bookmark Folder" isn't an acceptable option for me, unless there's another way to make the normal Bookmarks Menu the default for new bookmarks.

Removing  "Default Bookmark Folder" isn't an acceptable option for me, unless there's another way to make the normal Bookmarks Menu the default for new bookmarks.

Sure you just have to select "Bookmarks Menu" as folder once and in the future it will default there.
I am going to close this issue, there is nothing we are going to change here.

Sure you just have to select "Bookmarks Menu" as folder once and in the future it will default there.
I am going to close this issue, there is nothing we are going to change here.

I also use 'Default Bookmark Folder'.  I'll disable it and see what happens.
Cheers.

I also use 'Default Bookmark Folder'.  I'll disable it and see what happens.
Cheers.

Actually that doesn't make the Bookmarks Menu the default.  It makes whatever was the last place used the one that shows up in the menu - which, in my testing, is quite often the Livemarks folder I created.  Close, but no cigar.

Actually that doesn't make the Bookmarks Menu the default.  It makes whatever was the last place used the one that shows up in the menu - which, in my testing, is quite often the Livemarks folder I created.  Close, but no cigar.

Same issue here.

Sure you just have to select "Bookmarks Menu" as folder once and in the future it will default there.

Does not work, even though I have "selected Bookmarks Menu as folder once",

Same issue here.

Sure you just have to select "Bookmarks Menu" as folder once and in the future it will default there.

Does not work, even though I have "selected Bookmarks Menu as folder once",

Works fine for me and i'm not getting any more random bookmarks added since disabling 'Default Bookmark Folder' extension.


Use path parameter example/default when displaying list of operations

User story.
As a CLI and Studio users, I want the URLs with path parameters to be instantly usable if possible so that I can click them, or copy them into a HTTP client.
Is your feature request related to a problem?
Currently we show URLs like this:

In studio the current implementation is repeating the path with param templates showing up, then the full URL with the same stuff.

Describe the solution you'd like
We should use example values, default, the first item from an enum, or if x-faker is there we can use a value from that. The goal here is to make the URL useful, without somebody having to copy and paste it, only to tweak bits and probably put an example value in there themselves.
This logic should go into the Prism JS API itself, so studio and Prism CLI do not both need to figure out how to do it.

Yeah, I like the feature. This might not be that easy though. We'll figure it out.

the faker stuff is less important, just getting examples, default, enum in there should be main goal.

@StefanDywersant When working on this I really suggest you to write up a plan on how you're aiming to get these samples values — I just want to make sure we go on the right direction without writing code we're going to discard.

@StefanDywersant When working on this I really suggest you to write up a plan on how you're aiming to get these samples values — I just want to make sure we go on the right direction without writing code we're going to discard.

A utility which transforms IHttpOperation into example
I would make it pluggable: an example plugins might include:

A simple string
A string with colors (so I can see which ones are parameters)
A curl line (with headers and stuff). Here comes the question whether it is prism’s responsibility?

Above utility is responsible for putting path and params together and uses HttpParamGenerator
Introduce HttpParamGenerator which will use JSONSchemaGenerator and additionally handle param styles, static examples from HttpContent
We should be able to reuse HttpParamGenerator for generating headers (mocker/index.ts#computeMockedHeaders)

The good thing is that in the CLI we can use all the other packages since it's fundamentally the last one (core, http, http-server).
I would definitely keep out of the scope the idea of pluggable and just return string we're going to interpolate using any URI Template expander library (https://medialize.github.io/URI.js/uri-template.html)
result = URI.expand("http://example.org/{file}", {file: "hello world.html"});
Such string is then going to be fed to our signale logger — precisely here
Now the only thing that'd be "left" would be to grab each of these operations, take the resources and the required uri parameters (they should have a JSON Compabile schema) generate an example (static or dynamic? I vote for dynamic).
Apart these minor details, I think we're aligned @StefanDywersant — so please go ahead and rock this out 🎸


Add hotspot, circle and polygon

It is a really great example of an imagemap editor and I like the simplicity.
Some suggestions:

Add option for spot, circle and polygon (besides the "rect"), e.g. something like this http://codecanyon.net/item/image-map-pro-jquery-interactive-image-map-builder/2792438

Add drag support on touch devices, e.g. the plugin mentioned before or this one works well on touch: http://angularscript.com/simple-image-crop-directive-for-angularjs/

Maybe update readme to English?

Maybe add an example page using the json (for frontend) - (it could just be an example with some "dummy" json). e.g. this https://github.com/cowglow/angular-image-maps-rwd (Angular or jQuery version).

I am very glad to receive suggestions you given.
It's encapsulated temporarily from my one project. Given some time, it will improve gradually.
For suggestions:

I think circle will be added first and then polygon.

demo is so cool, and I had learnt something from its looks.

It's really nice to support touch devices, and I will do it.
The truth is my poor english, but I will try in english when next version is ready. Aha~
Maybe I had not understood what is the "dummy" json?

Maybe it's $scope.img in index.html ?

Thanks!

I am glad you like the suggestions :+1:
Great, often also a hotspot is useful (I guess it would just save [x, y] coords).
I really like this simply toolbar:

Previously there was this hotspot editor http://www.jqueryrain.com/2012/08/jquery-hotspot-map-powerful-annotations-and-tooltips/ but it seems to link to the new version now.
Anyway the old one looked like this, but the new one can the same and is actually better.

I don't think you need all the fancy configuration as a start - just some of the basic stuff would be cool :)
Okay, maybe Google Translate can help - at least I think it would make more sense to most people.
By "dummy" json it just meant to output json from the editor - so maybe just a basic example html page of using the json/coords. Maybe using the jQuery version in frontend of this plugin (for responsive images) https://github.com/cowglow/angular-image-maps-rwd
Some examples:
http://codepen.io/geeves/pen/BdmEb
http://anhee.github.io/jquery-hotspot/
http://codecanyon.net/item/jquery-hotspot-plugin-with-slideshow/full_screen_preview/4416686
I would be great if it just is an example with a free/open source script/plugin.

Maybe I missed the hotspot. But now I get it (I have not realized about it until just now).
Also get the "dummy" json.
That is all useful suggestions. I think it will keep simple and then improve for use.
Thanks for examples, I like them.

This is also a cool hotspot example: https://codyhouse.co/demo/3d-animated-mockup/index.html
I thought about another minor thing, when resizing the "rect". Often by hold down SHIFT + resizing the "rect" would keep the aspect ratio.
For a circle you might want to keep aspect ratio like it does here https://github.com/alexk111/ngImgCrop
Here is an example where aspect ratio is preserved when SHIFT is hold down and "free" mode https://fengyuanchen.github.io/cropper/
I also saw this: http://codecanyon.net/item/angular-cropper/full_screen_preview/10448716 ... I think the larger circles on the edges would work well for touch devices :+1:

Maybe these image map editors also can give you some inspiration:
http://www.endycahyono.com/apps/imagemap/
https://github.com/maschek/imgmap


Lora analogy

Hello, I saw in the paper

but in the code, we see at https://github.com/ByungKwanLee/MoAI/blob/a7728a8d1c8df27d3221708a4ca4366e271f51c8/moai/arch/expert_module.py#L143
how this saves compute as attention is still performed at d=4096 instead of r=64?
Also, did you try just concatenating the aux info to the Llm inputs along with the image features and the prompt? we see the answer from the repo but did you actually train this way?

Both 4096 x 64 and 64 x 4096 is more efficient than 4096 x 4096 becuase it is simple equation 4096 x 64 + 4096 x 64 <  4096 x 4096

Yes I did try but directly using the aux often makes wrong information embedded because computer vision outputs are not perfrect model without wrong answer.

I am more referring to this https://github.com/ByungKwanLee/MoAI/blob/a7728a8d1c8df27d3221708a4ca4366e271f51c8/moai/arch/build_mlp.py#L211
This line does. not seem to be in internlm, but the interlm2composer2-7b, means you use a vlm already and adapt it right? not an llm only right?

Based on the InternLM2, we tried to employ the image part adaptation to make VLM know where the image part is, and the results show that it somewhat makes better peformances. Therefore, we jointly train it with moai components. we will update the detail of this part and the vision projector training part, both.

Do you mean you use plora at the sft stage when training moai modules, or you use the plora weights given by InternLM2 composer? and why not showing the results without this plora part (moai modules only)?
This is the bite of code I am reffering to https://huggingface.co/internlm/internlm-xcomposer2-7b/blob/main/build_mlp.py#L205

I mean I used plora at the sft stage when training moai modules. And, I will abaltion it with and without PLoRA but it gives 2~3% margin

can you refer me to which LLM weights you used please? because I compared the weights of your model to the ones in InternLM2 7B and they are different, does this suggest that you trained the LLM? in fact, they are close to the internlmcomposer2 ones actually, same for the CLIP, similar to internlmcomposer2 rather than the one from openai, can you share more details about the pretraining stage ? what kind of weights you started from when doing the sft stage?


List of fixes & regressions

Must:

[x] add conda package to spectate (maybe it already exists? = it doesn't)
[x]  add from json
[x] fix examples

Not a must but nice:

[x] fix edge fine update on frontend
[ ] add zoom_change (will fail on jupyterlab see issue #26)
[ ] add rendered_position_change (js)
[x]  add functions get node and edge by id on python side
[x]  add from csv or from df
[ ]  implement get/set for rendered_position
[ ]  update TippyJS for latest version (^6.0.0 will probably do)
[x]  set_tip (on python side)

The rest of these are attended in other issues, so I'm closing this.


Browser Back button doesn't work, even in example code

Describe the bug
Browser Back button doesn't work, haven't tested in mobile
Only url changes page or title won't change
Beamer version: (e.g. v0.14.1, master, ...)
1.5.0
To Reproduce
Steps to reproduce the behavior:
Run the example: bottom_navigation
Expected behavior
url change should change the page also
Screenshots
https://user-images.githubusercontent.com/88944913/182034880-0f66b015-f720-412d-ae8e-a81d129e2460.mp4

Hey @hemanthvings :wave:
Thanks for creating an issue and sorry for a late response.
This is a strange issue that I've been seeing in some old versions too. Interesting fact is that after some more navigation, browser buttons seem to work as expected.
I have now investigated it fully and can provide a detailed explanation of why it happened.
In the MyApp, for the "root screen" we have this configuration
 routes: {
  '*': (context, state, data) => HomeScreen(),
},

Now RoutesLocationBuilder must surround the HomeScreen widget with a BeamPage and provide a key for it. The key to be selected is something like ValueKey(state.routeInformation.location). The important thing to note here is that Navigator will rebuild its pages only if the key has changed between 2 navigation events.
So we start of with that 1 root page in our root Navigator and it initially has the key ValueKey(/books). Then we navigate (but with nested Beamer!) to /articles or /books/2 and see that the nested Beamer properly updates the URL. When we press the browser back button to go back to /books, that event goes to root Beamer (the one with 1 root page with ValueKey(/books)), so it decides not to rebuild itself because this is the same key that the page already has!
The solution is for nested Beamer to properly rebuild when listening to changes on its parent. There was a bug that @MarkRunWu noticed as a related issue and fixed before I managed to take a proper look due to vacation and illness. Thanks again! :blue_heart:
So now the 1 root page will still not rebuild (and this is OK), but the nested Beamer that was on /books/2 or /articles will rebuild when its parents notifies it of /books.
I am now going to cherry-pick this into v1.5 branch and publish v1.5.2 on pub dev.


add 115-async-api

this notebook shows how to use Asynchronous Execution to Improve Data Pipelining

@raymondlo84 could you test it? It's failing on mac due to timeouts. I'd like to be sure it's working with macos.

However, it passed CI finally.

However, it passed CI finally.

Appreciated !


Fix wrong modulo call in ecp_double_add_mxz

Description
ecp_double_add_mxz wrongly does an MPI addition followed by a call to
MOD_MUL instead of MOD_ADD. This is more visible since the
mbedtls_mpi_xxx_mod functions have been added in commit 3b3b34f60800
("Replace some macros by functions").
Fix that by using mbedtls_mpi_add_mod instead. The testsuite still
passes after that change.
Status
READY
Requires Backporting
I am not sure it requires backporting, I don't think it as any real impact.
Migrations
NO
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated
[ ] Backported

The CI failures are due to a temporary issue on development, now fixed. Despite this the test coverage is satisfactory so the CI results are acceptable for merging.

I checked the CI results and the only failures are due to a known issue that was fixed in development in the meantime (which shows as the pr-merge job passes), so that's as good as a pass.

@aurel32 Our current policy is to acknowledge all external contributions in the ChangeLog. Could you add a new file under ChangeLog.d with an entry for this change? Suggested text:
Changes
   * Fix minor performance issue in operations on Curve25519 caused by using a suboptimal modular reduction in one place. Found and fix contributed by <your name and/or affiliation in your preferred format> in #3209.

Thanks!

I have just done that and force pushed the result.

I checked the CI results, and again the only failures are due to issues in development (at the point this PR was based on it) and unrelated to this PR - and the pr-merge job passes. So nothing preventing this PR from being merged.


[Bug] Conflict with Button Feel

Having Button Feel active with Dorako UI causes the Chat Tab to render improperly depending on which Foundry version you're using.
https://github.com/LebombJames/button-feel/issues/2
Foundry 10.303
Chat Tab button overlaps the chat messages.

Dorako 2.2.4
Button Feel 1.1.2
PF2 4.12.9
Foundry 11.304
Chat messages are instead overlapping the tab buttons.

Dorako 2.2.4
Button Feel 1.1.2
PF2 5.1.0

fixed in next release


[$250] Empty state list view does not use 400px as the width of the inner "modal" area

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.24-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724433592521089
Action Performed:

Go to staging.new.expensify.com
Navigate to empty pages in Search or empty pages in the workspace editor like Tags

Expected Result:
Inner modal portion is set to 400px
Actual Result:
Inner modal portion is not set to 400px
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ddff86d7195f923e
Upwork Job ID:<PHONE_NUMBER>118952549
Last Price Increase: 2024-08-27

Next up is proposal review

Sure, I'll do it today

Deployed to prod 9/2

Offer sent to @mkhutornyi for reviewer role ($250)
Contributor role was software mansion, so no payment required there.


Implement Checkpointer for DynamoDB

Implement the checkpoint interface in langchain (https://langchain-ai.github.io/langgraph/how-tos/persistence/?ref=blog.langchain.dev) for DynamoDB. This should include both checkpoint and memory store.

For university students interested in taking up this feature, I am available to assist with the design and mentoring as part of you taking up the development task.

Hi, me and a team of 4 from University of Toronto are interested in this feature. Can this task be finished in a couple of weeks?

I'm not sure if this feature should be included here as it concern Langgraph package.
@zhaoJoseph look at the postgres one if you are interested to contribute https://github.com/langchain-ai/langgraph/tree/main/libs/checkpoint-postgres
it's quite a simple task, but you must have good DynamoDB access pattern knowledge to properly use the primary keys.

Thanks for the clarification and guidance. I am also confused why this is under langchain-aws, also a maintainer from langgraph stated that they are only providing implementations for partner providers. https://github.com/langchain-ai/langgraph/discussions/1351, thanks anyway.


Using the file compare tool with screen readers needs some attention

Issue Type: Bug
The problem is, basically, that screen readers don't know that comparisons are happening. (I'm using NVDA for my screen reader.) In side-by-side mode, only the editable file can be browsed; I've not found a way to jump between it and the file showing the differences. In inline mode, NVDA simply jumps over any line indicating a change, making the mode useless.
The f7 command is the only way to get meaningful information about differences (side bug: f7 and shift-f7 appear to do the exact same thing). My main problems with f7 are:

There's a confusing line of text at the top of the list that has some line numbers, then two numbers indicating something? Basically, I have no idea what the top item in the list means.
The list includes items starting with a plus or a dash, which makes sense, but it also has a bunch of extra lines that don't appear to be different. Are these for context?
The list items all show the line number first. If I am comparing files I know well, I don't want to hear the line number constantly. It should be at the end, so I can hear the changed line itself first.
Once I find a change, I can't do anything with it. How can I revert the change so my file matches what the list item is showing? Pressing enter only moves me to the line, and there is no context menu for any list item.
Sometimes, I am taken out of NVDA's mode that works well with web UIs like VS Code. I am jumped to a list of diffs that is different from the list I've been describing so far. Yesterday, I had the list I've been talking about; today, when I went to confirm some things, I wound up in this new list.

I'm not sure what a good, accessible diff editor might be like. I'd love a sound indicating an addition, removal, or change, with a keystroke to update the active file with the change from A or B, or insert both (in case of a line change) then let me edit them together. Sounds would be hard with a web UI, though, and don't do anything for braille users. Maybe a custom style that a screen reader could interpret? Also, commands to jump from change to change would be great (no, the ones in the Go menu don't do anything).
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 3.16.0-4-amd64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz (4 x 3093)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: unavailable_off

Load (avg)
undefined

Memory (System)
15.88GB (9.53GB free)

Process Argv

Screen Reader
yes

VM
0%

Item
Value

Remote
SSH: git.domain.com

OS
Linux x64 3.16.0-4-amd64

CPUs
Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (2 x 2294)

Memory (System)
15.71GB (1.22GB free)

VM
100%

Extensions (6)

Extension
Author (truncated)
Version

remote-containers
ms-
0.94.0

remote-ssh
ms-
0.48.0

remote-ssh-edit
ms-
0.48.0

remote-wsl
ms-
0.41.7

vscode-remote-extensionpack
ms-
0.19.0

php-debug
fel
1.13.0

Unfortunetly did not have time to tackle this feature this milestone. Thus pushing to March as I plan to look into this then.

Ok, starting to look into this, my todo list after processing the above

[ ] Fix F7 and Shift + F7 doing the same thing
[ ] Provide more context in top of the line content. Not sure what context could be helpful here @alexdima let me know if you have ideas
[ ] Get line numbers to be read at the end not at the start
[ ] Introduce commands for reverting a change or staging a command (either context menu or just actions which the user can attach keybindings to)

@mehgcap please let me know if there is more you have hit in the meantime, or if my action list does not cover something
fyi @jvesouza and @ajborka for potential ideas

This sounds good for now. I'll open new issues once this work is complete, if anything new comes up. I think what you have will help a lot, though.
--
Alex Hall

On Mar 19, 2020, at 08:06, Isidor Nikolic<EMAIL_ADDRESS>wrote:
Ok, starting to look into this, my todo list after processing the above
Fix F7 and Shift + F7 doing the same thing
Provide more context in top of the line content. Not sure what context could be helpful here @alexdima https://github.com/alexdima let me know if you have ideas
Get line numbers to be read at the end not at the start
Introduce commands for reverting a change or staging a command (either context menu or just actions which the user can attach keybindings to)
@mehgcap https://github.com/mehgcap please let me know if there is more you have hit in the meantime, or if my action list does not cover something
fyi @jvesouza https://github.com/jvesouza and @ajborka https://github.com/ajborka for potential ideas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/88695#issuecomment-601141955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAILC224EKCZEY3TELMXFTTRIIDDTANCNFSM4KHGRSUQ.

@isidorn The line at the top follows the format of patch files used e.g. when using git diff on the console. e.g. when typing a space in a file, git diff outputs the following:
$ git diff
diff --git a/src/vs/editor/common/model/textModel.ts b/src/vs/editor/common/model/textModel.ts
index 31a929f0aa..dd8ddae14a 100644
--- a/src/vs/editor/common/model/textModel.ts
+++ b/src/vs/editor/common/model/textModel.ts
@@ -1344,7 +1344,7 @@ export class TextModel extends Disposable implements model.ITextModel {
        private _doApplyEdits(rawOperations: model.ValidAnnotatedEditOperation[], computeUndoEdits: boolean): model.IValidEditOperation[] {

                const oldLineCount = this._buffer.getLineCount();
-               const result = this._buffer.applyEdits(rawOperations, this._options.trimAutoWhitespace, computeUndoEdits);
+               const result = this ._buffer.applyEdits(rawOperations, this._options.trimAutoWhitespace, computeUndoEdits);
                const newLineCount = this._buffer.getLineCount();

                const contentChanges = result.changes;

The output of git diff is the source of inspiration for this entire UI, as it was my understanding that there was no accessible git tool, and folks simply used the terminal and the git command line to do git. So my assumption was that people are familiar with the format from the git command line.

@alexdima thanks for clarification, I also found this great comment from your past self which explains pretty much everything https://github.com/microsoft/vscode/blob/b9a877dedd31bfc88dcf3ef8d4d8b83608da2f9a/src/vs/editor/browser/widget/diffReview.ts#L605
So based on that comment I will just make the aria label a bit richer.

Note that for now I pushed two small changes:

Make sure the Go to next / previosu diff work when focus is not in the editor (this would happen when command triggered via command palette)
Changed that we announce: + LINE_CONTENT modified line LINE_NUMBER. So we first announce a + or - simbol, than the line content and at the end the modified or the original line number. @mehgcap you can try it out tomorrow and we can fine tune of course

I assume I'll get this if I install the Insider build of VSCode? I'm currently running the public release.
--
Alex Hall

On Mar 19, 2020, at 11:10, Isidor Nikolic<EMAIL_ADDRESS>wrote:
Note that for now I pushed two small changes:
Make sure the Go to next / previosu diff work when focus is not in the editor (this would happen when command triggered via command palette)
Changed that we announce: + LINE_CONTENT modified line LINE_NUMBER. So we first announce a + or - simbol, than the line content and at the end the modified or the original line number. @mehgcap https://github.com/mehgcap you can try it out tomorrow and we can fine tune of course
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/88695#issuecomment-601233337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAILC2ZEG7OZNFEDHSFDNJ3RIIYUTANCNFSM4KHGRSUQ.

@isidorn , I am not very familiar with diffs. Can you provide a simple example to work through now and after your push goes live to insiders?

@mehgcap yeah, tomorrow insiders should have my initial changes. Tomorrow I will hopefully tackle the rest, so the Insiders from Friday should be even better.
@ajborka diffs are mostly used with Source Control Providers, for example Git. It is a convenient way for users to look at their exact changes - differences before they commit their code.
If your repository is under source control VS Code for any file you can F1 > open changes, that opens the changes view which should be navigated via F7 and Shift + F7 in an accessible way and we are looking now into improving this.
More about Git and vscode can be found here https://code.visualstudio.com/docs/editor/versioncontrol

@mehgcap  I have enriched the aria label of the header to expalin a bit better what the encoding at the top means.
I have also changed that as you navigate through diffs, that the underlying selection in the modifed editor changes. Thus users can nicely use Git: Stage | Unstage | Revert Selected Ranges commands. Please note that this commands do not have a default keybinding so you would have to mind something to it. To make it more discoverable that these commands should be used I have the ariaLabel of the top level to mention these commands.
@mehgcap Once I fix the navigation sometimes not navigating issue I plan to close this and it would be great if you can try this out from next week's insiders and provide feedback.
I am open for suggestions.

I have pushed a change which fixed "Go to Next Difference" and "Go to Prev Difference" when invoked from the command palette.
@mehgcap now the "got to next" and "go to prev" always correctly work for me. It would be great if you try out vscode insiders from next week onward when you find time and let us know if there are stil issues so we tackle them.
@alexdim fyi previosuly the diff review mode would automatically close when the origianl or the modified editor would get focused, making the whole interaction with Quick Open rather tedious (quick open refocuses the editor on close). Also this automatic hidding was probably causing confusion. Since I think it is easy to hide it via esc or hitting the X I have removed this auto hide behavior.

This is working great for me with Jaws 2020 and the latest insiders release! Thanks for doing this @isidorn.

@cannona thanks for letting us know.
Please note that there are still some issue we are working on in this area. You can find them here
https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Aaccessibility+label%3Adiff-editor
Feel free to provide feedback and if there are other issues you are hitting. Thanks


Test multiple integer inputs for age_groups

Tests were done and script change can be see in pull request #33


UnboundLocalError: local variable 'layer' referenced before assignment

Running the examples/example.py code yields the following stack trace:
/home/leek/projects/google/neuroglancer/python/examples/example.py in <module>()
     30                toNormalized(getDataValue(2))));
     31 }
---> 32 """)
     33   s.append_layer(name='b',
     34                  layer=neuroglancer.LocalVolume(

/home/leek/projects/google/neuroglancer/python/neuroglancer/viewer_state.py in append_layer(self, *args, **kwargs)
    348
    349     def append_layer(self, *args, **kwargs):
--> 350         self.layers.append(ManagedLayer(*args, **kwargs))

/home/leek/projects/google/neuroglancer/python/neuroglancer/viewer_state.py in append(self, *args, **kwargs)
    289         else:
    290             layer = ManagedLayer(*args, **kwargs)
--> 291         self._layers.append(layer)
    292
    293     def extend(self, elements):

UnboundLocalError: local variable 'layer' referenced before assignment

The problem seems to be here: https://github.com/google/neuroglancer/blob/master/python/neuroglancer/viewer_state.py#L288
the line should read layer = args[0]

Thanks for spotting this.  It's been fixed now.


Allure combined not found

@MihanEntalpo
Hey I seem to have an issue running this, I have python 3.9 installed but whenever i run the allure combine command I get
"Could not parse arguments: Expected a command, got combine"
Do you know how I might resolve this? Really want to get this working, I am definitely in the right directory of the allure results tried also the report.
Thank you

allure combine ./allure-results

The problem is that you are calling "allure" command and passing parameters "combine" and "./allure-results" into it.
But you should call allure-combine ./allure-results

Closing due to no activity


fix(docs): change invalid docs owner to master

fixes: #14

Wholesome! Thanks for the PR! I'll deploy the release by tomorrow :D


Require minimum C++17

Remove support for C++14
Update CI configurations

TODO:

[ ] Check NVCC builder (problematic) + other builders
[ ] Remove C++17 feature tests that are not needed anymore + corresponding macros checks

We can leave this for a separate PR?

* [ ]  Update some old code with C++17 features

We can leave this for a separate PR?

* [ ]  Update some old code with C++17 features

I second this suggestion. Also @aurianer thanks for pushing this forward!

This tells me we're most likely not setting the -std flag for nvcc compilationn: https://cdash.cscs.ch/viewBuildError.php?buildid=155780. I think we can use the cuda_std_XX properties/(CMAKE_)CUDA_STANDARD variables the same way we use cxx_std_XX/(CMAKE_)CXX_STANDARD to set the standard when compiling with nvcc (see https://cmake.org/cmake/help/latest/prop_gbl/CMAKE_CUDA_KNOWN_FEATURES.html, https://cmake.org/cmake/help/latest/variable/CMAKE_CUDA_STANDARD.html?highlight=cmake_cuda_standard, available from CMake 3.17 onwards).

I'm encountering problems in the pkgconfig generation step because of the cmake generator expressions for languages. The error is the following:
  Evaluation file to be written multiple times with different content.  This
  is generally caused by the content evaluating the configuration type,
  language, or location of object files:

when generating lib/pkgconfig/hpx_application_debug.pc or one of the 3 others.
I thought about filtering those options out and make pkgconfig specific for CXX with a list(FILTER ... but I encountered another error, the flags being separated with a ; inside the generator expression. CMake considers therefore $<$<COMPILE_LANGUAGE:CUDA>:--extended-lambdas;--expt-relaxed-constexpr> as 2 items $<$<COMPILE_LANGUAGE:CUDA>:--extended-lambdas and --expt-relaxed-constexpr> and only the former is filtered out.
If anyone have a simple solution.. otherwise I would suggest we drop the support for pkgconfig, as it is not the first time we encounter problems with pkgconfig (object libraries) and that we have very few users using it.

I'd vote to drop support of pkgconfig

@aurianer FWIW, you can use $<SEMICOLON> to place semicolons inside generator expressions. Not sure if this helps, though.

I'd vote to drop support of pkgconfig

@stevenrbrandt you said at some point that you'd be interested in maintaining the pkgconfig support in HPX as you're using it.

@aurianer FWIW, you can use $<SEMICOLON> to place semicolons inside generator expressions. Not sure if this helps, though.

Thanks for the suggestion but I don't quite see how to replace only the semicolons inside the generator expressions without replacing the semicolons that separate the generator expressions, the pkgconfig flags are of type:
$<$<COMPILE_LANGUAGE:CUDA>:--extended-lambdas;--expt-relaxed-constexpr>;$<$<CONFIG:Debug>:HPX_DEBUG>; etc.

About @biddisco solution I still don't manage to make it work, my minimal example being:
message("Before flags !!!!!!!!\n ${_flags}")
string(REGEX REPLACE "\\$<\\$<COMPILE_LANGUAGE:CUDA>:[^>]*>" "" _flags ${_flags})
message("After flags !!!!!!!!\n ${_flags}")

output
Before flags !!!!!!!!
$<$<CONFIG:Debug>:HPX_DEBUG>;$<$<COMPILE_LANGUAGE:CUDA>:;ASIO_DISABLE_CONSTEXPR;>;$<$<CONFIG:Debug>:HPX_DEBUG>
After flags !!!!!!!!
 $<$<CONFIG:Debug>:HPX_DEBUG>$<$<CONFIG:Debug>:HPX_DEBUG>

The important semicolon between the 2 generator expressions is also gone, maybe I missed something..
@stevenrbrandt in this commit I just disable pkgconfig generation when HPX_WITH_CUDA is enabled, would that be sufficient for you?

I've encountered a lot of errors with the Intel compiler when switching to C++17 so I'm planning on removing the support for it. If anyone wants to pick it up you are more than welcome!

launch perftests

@aurianer I just pushed the commits for the CUDA builds. Hoping I didn't break the non-CUDA builds too badly...
For others, there were at least a couple of new CUDA bugs revealed by this. The first is neither std::invoke_result nor hpx::util::invoke_result detect that a noexcept member function is a valid argument for invoke_result. CUDA 11.1 fixes this, but I don't know what the underlying bug was. Example: https://godbolt.org/z/7PPf6zKaf.
The second bug is revealed by our tag_dispatch implementation. Specifically, this is triggered by having a templated base class for the CPOs. This is fixed in CUDA 11.2. Example: https://godbolt.org/z/43Mq5eh1E. As a workaround here I've made the nothrow detection always return true for the affected CUDA versions. This may lead to false positives, but I think those are better than false negatives if we make it always return false.

Thanks a lot for working on this!

I just rebased to solve the conflicts

I've reported the comments in this issue #5463, I will address them as soon as this PR is merged

@hkaiser @ms any hints about those failures of missing executables? Can it be related to the work on the GPU nodes at LSU?
https://cdash.cscs.ch/viewTest.php?onlyfailed&buildid=172230
Note: looks like the last 2 run on the perftests are green so it might have been due to daint in the end, I might increase the number of repetitions to have more stable results.

The failures are unrelated to this PR, I'm merging this :tada:


[BREAKING] bug

I am running v7 and i noticed that a lot of things run into problems, if i speed up. for example, when i go to 8 times speed (lower same issue but slower) my power grid failed multiple times now. The reason for me is that i need power to make more power and when i lose my cryptofluid my main generators go offline and i have to do manually start up. the issue is that the crypto fluid isnt working correctly. during speed-ups the tanks gets slowly emptied and as soon as i reset to 1x it fills up again pretty quickly. i saw some other things which look to me like the calculation or generally the speed-up is not working properly. This is really sad and makes the mod unusable!

I'm having this problem too, only I first noticed it happens with the water for Steam Generators. When I sped up the game, the water levels in the conduits would mysteriously go down, and then jump back up again when I reset the speed.
So, I decided to look into it a bit further to understand why this is happening. I'm not a mod developer, nor do I know much about how the game works technically, but, from what I can tell, a lot of the game's mechanics are limited by frame rate. If you want a tldr on how to fix it, you'll basically need to get as high of an FPS as possible (like above 200) because for some reason the game's logic is tied to the frame rate. So, turn off VSync, bloom, linear filtering, etc, anything that could slow it down you want to turn off, Settings -> Graphics is where you can find those settings. Then, also in Settings -> Graphics, drag the Max FPS all the way to the right until it says "None". You may also want to turn on "Show FPS & Ping" to see how high the FPS is. This probably won't work for all speeds, but it'll work perfectly for some of them.
If you don't believe me, you can try this out by going into sandbox mode, and using this schematic distributortest.zip, then changing the speed to something like 64x, you'll notice that the items are getting blocked by the distributor. See how low it needs to be before items can get through (for me it's 4x speed). Now, turn VSync off (this would sync the framerate with your monitor's framerate, so turn that off), and drag the Max FPS slider all the way to the right, and now go back and try setting it to whatever speed caused it to break before, and, hopefully, you should find that it works just fine now. Chances are, you're not going to get it up to, say, 256x speed, or even above 16x speed, without it breaking, but with this you might be able to get it up to 8x speed.
I hope this helps, since it certainly did for me.

Also, units automatically die.

The units dying thing is kinda weird but it happened to me too, and the FPS thing got me from x8 to x64 speed working.


build: fix staging-deploy Github action

Summary | Résumé

Trying to fix a recurring issue we have with our staging deployment script. @patheard suggested a new way of waiting for an action to complete before triggering another one.

on-failure

Gotcha! Just a question about your second point. How would the staging-deploy action not be fully executed just because we have this on-failure step? How does it work?

Gotcha! Just a question about your second point. How would the staging-deploy action not be fully executed just because we have this on-failure step? How does it work? cc @patheard

This would be to catch cases like what happened yesterday where the push-staging job timed out and failed.  In that case, you wouldn't want to try to run staging-deploy to deploy a new image (since it wouldn't exist).
In the on-failure job, you could do something like use a Slack webhook to post back to the #forms-dev channel to alert people that the deploy job didn't work as expected.

Gotcha! Just a question about your second point. How would the staging-deploy action not be fully executed just because we have this on-failure step? How does it work? cc @patheard

This would be to catch cases like what happened yesterday where the push-staging job timed out and failed. In that case, you wouldn't want to try to run staging-deploy to deploy a new image (since it wouldn't exist).
In the on-failure job, you could do something like use a Slack webhook to post back to the #forms-dev channel to alert people that the deploy job didn't work as expected.

Oh ok so we would add those two "steps" in the staging-build-push-container action then? The run command  with the echo will be what triggers or not the execution of the staging-deploy action?

I'd been thinking more that you could add them to the .github/workflows/staging-deploy.yml workflow like so:
name: Deploy to Staging

on:
  workflow_run:
    workflows: ["Staging — Push container to ECR"]
    types:
      - completed

jobs:
  # This job will only trigger if the staging-build-push-container workflow is unsuccessful.
  # It will post a message to Slack to notify the team there was a problem.
  # You'll need a `FORMS_DEV_SLACK_WEBHOOK` GitHub secret that can post to the #forms-dev channel to set this up.
  unable-to-deploy:
    if: ${{ github.event.workflow_run.conclusion == 'failure' }}
    runs-on: ubuntu-latest
    steps:
      - name: Post to Slack
        run: |
          json='{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":":red: Unable to deploy Staging form viewer: <https://github.com/cds-snc/platform-forms-clients/actions/workflows/staging-build-push-container.yml|ECR push failed>"}}]}'
          curl -X POST -H 'Content-type: application/json' --data "$json" ${{ secrets.FORMS_DEV_SLACK_WEBHOOK }}
          exit 1

  # If staging-build-push-container was successful, proceed with the deployment.
  deploy-form-viewer-service:
    if: ${{ github.event.workflow_run.conclusion == 'success' }}
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

    # remaining deploy steps

Happy to chat more tomorrow if you've still got questions.

I'd been thinking more that you could add them to the .github/workflows/staging-deploy.yml workflow like so:
name: Deploy to Staging

on:
  workflow_run:
    workflows: ["Staging — Push container to ECR"]
    types:
      - completed

jobs:
  # This job will only trigger if the staging-build-push-container workflow is unsuccessful.
  # It will post a message to Slack to notify the team there was a problem.
  # You'll need a `FORMS_DEV_SLACK_WEBHOOK` GitHub secret that can post to the #forms-dev channel to set this up.
  unable-to-deploy:
    if: ${{ github.event.workflow_run.conclusion == 'failure' }}
    runs-on: ubuntu-latest
    steps:
      - name: Post to Slack
        run: |
          json='{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":":red: Unable to deploy Staging form viewer: <https://github.com/cds-snc/platform-forms-clients/actions/workflows/staging-build-push-container.yml|ECR push failed>"}}]}'
          curl -X POST -H 'Content-type: application/json' --data "$json" ${{ secrets.FORMS_DEV_SLACK_WEBHOOK }}
          exit 1

  # If staging-build-push-container was successful, proceed with the deployment.
  deploy-form-viewer-service:
    if: ${{ github.event.workflow_run.conclusion == 'success' }}
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

    # remaining deploy steps

Happy to chat more tomorrow if you've still got questions.

Got it now! Stil need to Github actions and I got mixed up by the job aspect vs the step one. Going to update the PR soon. Thanks :)

@patheard  New Slack secret has been added here https://github.com/cds-snc/platform-forms-client/settings/secrets/actions


Make errorMessage of number input modal reactive to attribute changes

Overview
This PR ensures that the error message shown in the number input popup updates automatically if any node attributes change (such as the minimum and maximum value of the number variable). Currently it is not possible to update the min/max value through a UI when editing the variable, but this PR ensures the error message is updated when changing the html of the document manually.
connected issues and PRs:
Solves a large part of https://binnenland.atlassian.net/browse/GN-4395?atlOrigin=eyJpIjoiNjdhZGNkZmRjZGQ3NGY2ZWFkNmY5MzNlMjI5OGMzOWEiLCJwIjoiaiJ9
How to test/reproduce

Update the minimum or maximum value of a number variable through the customHTML modal and see how a possible error message appears (or disappears).

Checks PR readiness

[x] changelog
[x] npm lint
[x] no new deprecations

@lagartoverde tagging you in this to see if you think this is a good solution

Good change and fix! happy to see the weird bug was because of actual faulty code and not some weird hard-to-debug issue. Making the error message a getter is more sensible anyway here.
As far as I can tell the connected issue is also solved, except that the input number is not always reset (because localCopy does not change when min/max changes). You could maybe solve this with @trackedReset, however, it would reset when pressing "show as words" button too. Any other solution would be quite overkill for this issue.
In my opinion I'd say:
* good change, approved +1

* ticket can be closed (the important part is fixed)

  * that the "wrong" input number stays visible isn't a big deal and could be seen as a feature anyway. As long as the error message is correct (which you fixed here), I see no problem with it anymore.

I also tried it with the reset, but thought it would be confusing to the user when it resets the input when the toggle is clicked.


First pass implementation for dynasties

Provide first pass implementation for all dynasty related folders. This includes:

[ ] dynasties
[ ] dynasty_houses
[ ] dynasty_house_mottos
[ ] dynasty_house_motto_inserts
[ ] dynasty_legacies
[ ] dynasty_perks

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

Already done. #18


WIP: improve support for using directory locations for dependencies

Create distinct dependency classes to better support directory locations (and distinguish them from git locations).  This includes sprinkling in some OO.

I like this idea/code. Obviously tests need to be fixed and preferably new tests written too.

Related updates to openjdk18-openshift image: https://github.com/jboss-container-images/redhat-openjdk-18-openshift-image/pull/14

Apparently, urlparse is not available during test collection.  I'm guessing this is a problem with the build environment?

This should be good to go.  I migrated the existing tests to use the new Resource classes.  Also, I renamed the Dependency classes to Resource.  These should be used for all "resource" types now.  That said, package repositories are not using Resource, but do share the same download_file() code.

This should be ready to go now.

LGTM, but for final approval I defer here to @dbecvarik.

lemme update the docs

docs have been updated

please remove unneeded tests/test_unit_tools.py (contains no tests now) and then we can merge it.

done.

@dbecvarik Are we good to merge it?


Discussion:  adding iffyio, jmhain, and/or lovasoa as maintainer of sqlparser-rs

Rationale
(largely copied from https://github.com/sqlparser-rs/sqlparser-rs/issues/808)
This project need more maintainer capacity to do its users justice and help drive things forward. See https://github.com/sqlparser-rs/sqlparser-rs/discussions/940 for related discussion
I do enough to keep it from going entirely dormant, but that is really not sufficient for a healthy project; Having contributors wait weeks for review feedback is a bad experience for everyone involved and for that I apologize.
Proposal
I would purpose inviting @iffyio   @lovasoa  @jmhain as maintainers (with write access to the repository)
I would expect to continue to review / do releases.
I believe all three  recently have been contributing to the project for more than 6 months, both with high quality code and (more importantly) reviews and help for the rest of the community. I believe they will  use  judgement to ensure the project remains easy to contribute to, easy to use, solicit user feedback, and not cause excessive API churn for existing users.
Data:

@iffyio PRs / reviews
@jmhain PRs / reviews
@lovasoa PRs / reviews

If you have any comments, please share them here.
I look forward to a bright future for sqlparser-rs
Prior Art
Note we went through this process before with @AugustoFKL   https://github.com/sqlparser-rs/sqlparser-rs/issues/808 but sadly he was unable to continue  (see https://github.com/sqlparser-rs/sqlparser-rs/issues/808#issuecomment-1450734088)
Next steps
I plan to leave this ticket open for at least two weeks while anyone who would like can share comments. Then we'll figure out what to do
cc @Dandandan @tobyhede @andygrove @maxcountryman @nickolay

I started a discussion about moving sqlparser into Apache Software Foundation governance: https://github.com/sqlparser-rs/sqlparser-rs/issues/1294. Please let us know what you think

sqlparser is now part of DataFusion. see https://github.com/apache/datafusion-sqlparser-rs/issues/1294 for details
@iffyio has become a committer of DataFusion (and thus also of sqlparser-rs) now as well 🎉


HA log entry: NameError: name 'logger.info' is not defined - line 4173

Add the Python script to the HA config sub-folder, and pscripts to HACS but get the following error:
This error originated from a custom integration.
Logger: custom_components.pyscript.file.shellies_discovery_gen2
Source: custom_components/pyscript/global_ctx.py:341
integration: Pyscript Python scripting (documentation, issues)
First occurred: 6:20:26 PM (1 occurrences)
Last logged: 6:20:26 PM
Exception in </config/pyscript/shellies_discovery_gen2.py> line 4173: logger.info("Shellies Discovery Gen2 version: %s", VERSION) # noqa: F821 ^ NameError: name 'logger.info' is not defined

it's log.info


chore: refactor configuration

Attempt to simplify configuration / attribute access. Approach to be discussed.

Codecov Report

Merging #390 (a1d97ec) into main (e5e2d1c) will increase coverage by 0.06%.
The diff coverage is 83.67%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   91.73%   91.80%   +0.06%
==========================================
  Files         126      131       +5
  Lines        3931     4074     +143
  Branches      548      560      +12
==========================================
+ Hits         3606     3740     +134
- Misses        214      221       +7
- Partials      111      113       +2

Impacted Files
Coverage Δ

src/Polyfills/Nullable.cs
0.00% <0.00%> (ø)

...k.Mapperly.Abstractions/MapDerivedTypeAttribute.cs
0.00% <0.00%> (ø)

...ok.Mapperly/Configuration/AttributeDataAccessor.cs
74.19% <69.23%> (-0.81%)
:arrow_down:

src/Riok.Mapperly/Emit/SyntaxFactoryHelper.cs
95.35% <93.93%> (-0.23%)
:arrow_down:

...Riok.Mapperly/Configuration/ConfigurationReader.cs
100.00% <100.00%> (ø)

src/Riok.Mapperly/Configuration/MapDerivedType.cs
100.00% <100.00%> (ø)

...iok.Mapperly/Configuration/MappingConfiguration.cs
100.00% <100.00%> (ø)

src/Riok.Mapperly/Descriptors/DescriptorBuilder.cs
100.00% <100.00%> (ø)

...ers/BuilderContext/MembersMappingBuilderContext.cs
100.00% <100.00%> (ø)

...Riok.Mapperly/Descriptors/MappingBuilderContext.cs
98.07% <100.00%> (ø)

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


IteratorPageDownstream: avoid emitting another row in finish

calling finish() on the IteratorPageDownstream would always send the
rowReceiver at most one more row if the iterator wasn't exhausted. (which is
the case if the downstream returned false on a setNextRow call).

ack