Add partition_aware to UnionExec display

Draft  as it is clear we don't have plan coverage for this feature. See https://github.com/apache/arrow-datafusion/pull/6009#issuecomment-1509128673
Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/5970
Rationale for this change
As noted by @mingmwang and @crepereum on https://github.com/apache/arrow-datafusion/pull/6009, https://github.com/apache/arrow-datafusion/pull/6009#issuecomment-1508280788 there is no good way at the moment to tell if a UnionExec is "partition aware" and thus it is not clear to me if this mode is ever used.
What changes are included in this PR?
Thus this PR improves the display plan to include information about partition in the display of the UnionExec.
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?

https://github.com/apache/arrow-datafusion/pull/6045/files removed this field so there is no need for this PR anymore


Added 'tomorrow' property for Date class. (Addition to PR #578)

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 533 tests, with 0 failures (0 unexpected) in 10.132 (12.321) seconds

:book:
tvOS: Executed 502 tests, with 0 failures (0 unexpected) in 4.871 (6.837) seconds

:book:
macOS: Executed 367 tests, with 0 failures (0 unexpected) in 1.255 (1.588) seconds

SwiftLint found issues
Warnings

File
Line
Reason

DateExtensions.swift
477
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

Hey @AlexeiGitH :))
The Swiftlint is complaining about a trailing whitespace. Can you just make this little fix?

The Swiftlint is complaining about a trailing whitespace. Can you just make this little fix?
Where exactly that trailing space is?

The SwifterSwiftBot message is showing Swiftlint issues on line 477 on DateExtensions.swift :))

4 Messages
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖	iOS: Executed 533 tests, with 0 failures (0 unexpected) in 10.076 (13.197) seconds
📖	tvOS: Executed 502 tests, with 0 failures (0 unexpected) in 4.212 (7.444) seconds
📖	macOS: Executed 367 tests, with 0 failures (0 unexpected) in 1.517 (2.096) seconds
SwiftLint found issues
Warnings
File	Line	Reason
DateExtensions.swift	477	Lines should not have trailing whitespace.
Generated by 🚫 Danger

@AlexeiGitH it looks like this got stuck, probably because it was triggered while GitHub was having serious issues yesterday. You might want to push an empty commit to try and trigger it again.
git commit --amend
git push -f

@AlexeiGitH please resolve the conflicts, I made a small change to the CHANGELOG to remove /files at the end of my PR link. Sorry :)


move "registration" related guides into registration folder

cross registration
1699
capstone
these should just go in a 'academics/registration' folder for a lil more orgnization

really? ok


Add clang-tidy rule to enforce lower camelCase naming of function

Description:
clang-tidy v9 added more identifier name checks. FunctionCase is one of the newer ones that will avoid churn during code reviews.
When running clang-tidy locally, it caught one file with PascalCase functions in the benchmark tests. The fix for that file is part of this patch.
Risk Level: Low
Testing: local run of clang-tidy
Docs Changes: N/A
Release Notes: N/A

Note that clang-tidy CI is actually broken right now. See https://github.com/envoyproxy/envoy/issues/9512. I would really love to get this fixed but I'm not sure what the current status is.

Until we fix clang-tidy CI, this PR is still helpful if you're running clangd with your IDE.

ping @lizan can we merge this one now?

/azp run envoy-linux

Let's run this on fixed clang-tidy pipeline :)

test/common/buffer/buffer_speed_test.cc:5:10: error: 'benchmark/benchmark.h' file not found [clang-diagnostic-error] Is this something that would be fixed by merging from master?

@derekargueta @lizan ping

yeah merge master to pick up clang-tidy fixes. I'm not 100% sure about benchmark.h, but merging master is a safe operation. If it doesn't work with the clang-tidy fixes we can debug further.


fix(base) treat existing record which drops to ttl=0 as valid response

Resolves #131 and https://github.com/Kong/kong/issues/7551
Activity on https://github.com/Kong/kong/issues/7551 suggests that we were not alone in experiencing this issue. Given that we've had this code running for 6+ months without issue now I figured I may as well open a PR with this change.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this due to lack of activity. Please re-open if needed.


[SPARK-8196][SQL] Fix null handling & documentation for next_day.

The original patch didn't handle nulls correctly for next_day.

Merged build triggered.

Merged build started.

Test build #38668 has started for   PR 7718 at commit 6c4fb6a.

cc @adrian-wang

Merged build triggered.

Merged build started.

Test build #38669 has started for   PR 7718 at commit faa78cf.

There's another sql.DatetimeExpressionsSuite, should be moved to sql.DateFunctionsSuite.

OK I deleted that too.

Merged build triggered.

Merged build started.

Test build #38675 has started for   PR 7718 at commit 616a425.

Test build #38668 has finished for   PR 7718 at commit 6c4fb6a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class InternalRow extends Serializable with SpecializedGetters
case class LastDay(startDate: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class NextDay(startDate: Expression, dayOfWeek: Expression)

Merged build finished. Test PASSed.

Test build #38669 has finished for   PR 7718 at commit faa78cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class InternalRow extends Serializable with SpecializedGetters
case class LastDay(startDate: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class NextDay(startDate: Expression, dayOfWeek: Expression)

Merged build finished. Test PASSed.

Test build #38675 has finished for   PR 7718 at commit 616a425.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Question: What is the difference between lora dreambooth vs lora fine-tuning?

And what is the recommended  method to choose if one trains an artist style/character/concept?

I would like to download the regularization images. They drastically improved my models. How can I put them in when you took it out of the script?

Native:

flexible for larger dataset and longer training if you want to process 1000-100k dataset
is a traditional fine-tuning and common training method in Machine Learning
you can train with both captions and tags by defining JSON file
not training text encoder by default
bucketing and cache latents using separate script
you don't need to set instance prompt, so useful for style training
you dont need to set <number_of_repeats>_  to your foldername like dreambooth

Dreambooth

for short training
is a native fine-tuning but for specific use, such as training object or style
prior_loss_weight = 1.0
training with text encoder by default
use dreambooth when you want to avoid training with captions (but you can train with captions in kohyas)
you're training with instance token in dreambooth, eg. sksbiden for training Joe Biden dreambooth, and you need to write sksbiden as a prompt
you can only train with 1 type of caption at a time, e.g. only .txt or .caption
useful for multi-styled training e.g. Nitrosocke Diffusion, you can train with multiple folder and object in 1 session
you can use reg images to prevent overfitting

Use dreambooth when u wanna train on style or object
Use native when u wanna 'resuming' a model training with your own dataset

I would like to download the regularization images. They drastically improved my models. How can I put them in when you took it out of the script?

My notebook still create reg_images folder, the only i took of is a cell for generate and download them directly to reg folder
however you can copy or reg images to reg folder created by this cell

or download them using this cell and set extract to to your reg folder path

@Linaqruf Sorry but its still not clear to me, there is currently four notebooks:

Kohya LoRA Dreambooth for LoRA Training (Dreambooth method)
Kohya LoRA Fine-Tuning for LoRA Training (Fine-tune method)
Kohya Trainer for Native Training
Kohya Dreambooth for Dreambooth Training

It seems like you compared the 1) Kohya LoRA Dreambooth vs 3) Kohya Trainer for Native Training
But I think the question is if you want to do LoRA training, what is the difference between using 1) Kohya LoRA Dreambooth and 2) Kohya LoRA Fine-Tuning

That the same thing, if you want me to specify it, then:
LoRA finetuning:

Mainly using captions to train
Using --in_json to input captions and tags
You can use bucketing whle training but in LoRA Finetuning, you can run separate script for bucketing, that is prepare_buckets_and_latents, same feature but it will save the latents as .npz instead of caching it. Great for resuming training
Buckets and Latents information saved to where you stored the captions and tags, meta_lat.json
Can declare --dataset_repeats without renaming train folder

LoRA Dreambooth

Mainly using token to train
it will ignore token if you put captions,
Easy for multi-styled learning, like you can add new token by create new folder and train with it
prior_loss_weight = 1.0
You can use reg images for data balancing

Basically the same thing.
https://github.com/kohya-ss/sd-scripts/blob/main/train_network.py

it will ignore token if you put captions,

Is token the concept_name in the colab notebook? What if you trained with captions but you also added your token like sksneurosama in the captions .txt? Will it still be a trigger word?

it will ignore token if you put captions,

Is token the concept_name in the colab notebook? What if you trained with captions but you also added your token like sksneurosama in the captions .txt? Will it still be a trigger word?

yes, it still be a trigger word, it just not used as token for learning anymore


The .NET Core Debugger is still being downloaded. See the C# Output Window for more information.

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.3)
Product Information:
Version:            1.0.3
Commit SHA-1 hash:  37224c9917
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.12
OS Platform: Darwin
RID:         osx.10.12-x64
Base Path:   /usr/local/share/dotnet/sdk/1.0.3
VS Code version:
C# Extension version: 1.9.0
Steps to reproduce

Install c# extension in VS Code on MAC
dotnet new console
dotnet restore
Open in VS CODE
Wait for all components to stop downloading and installing, make sure that .NET core debugger is installed properly

Following is output in "C#" pane
Updating C# dependencies...
Platform: darwin, x86_64

Downloading package 'Mono Runtime (macOS)' (2031 KB) .................... Done!
Downloading package 'Mono Framework Assemblies' (5829 KB) .................... Done!
Downloading package 'OmniSharp (Mono 4.6)' (21963 KB) .................... Done!
Downloading package '.NET Core Debugger (macOS / x64)' (43814 KB) .................... Done!

Installing package 'Mono Runtime (macOS)'
Installing package 'Mono Framework Assemblies'
Installing package 'OmniSharp (Mono 4.6)'
Installing package '.NET Core Debugger (macOS / x64)'

Finished

create default .NET build task
create default .NET debug launch config
start debugging session

Expected  behavior
Debugging session starts
Actual behavior
I receive error:
The .NET Core Debugger is still being downloaded. See the C# Output Window for more information.
there is no C# output

I can see that the problem is that install.Lock is present in the package directory and this triggers the message. After removing it manually, it complains with Run 'Debug: Download .NET Core Debugger' in the Command Palette or open a .NET project directory to download the .NET Core Debugger.
Trying to run "Debug: Install .NET core debugger"  yields to command 'csharp.downloadDebugger' not found.

@tomitrescak very strange. If you uninstall and reinstall the extension again, do you get the same behavior?

@gregg-miskelly yes, I tried that several times unfortunatelly. I always get the install success message, but the debugger is not installed and install.lock is left behind.

Interesting. No idea what is going on there. If you don't mind doing us a favor, I can send you instructions on how to setup debugging and where to start. Otherwise, I can send you a private with some extra logging to try and understand the problem.

I should say: I will not in the office much over the next two days, so it will likely be Monday either way.

@gregg-miskelly I'll gladly follow your instructions, please send them to me.I will also try full reinstall of VS Code. I'm pretty much open to anything ;)

@tomitrescak Can you please uninstall and reinstall the extension. After reinstalling and seeing the output pane download and install packages, open the developer tools in VS Code by navigating to Help -> Toggle Developer Tools. There may be an error message in the console that can help us. Please report back anything you find.

@tomitrescak try this --
First install:

Node.js (newer than 4.3.1)
Npm (newer 2.14.12)

Then:

git close https://github.com/OmniSharp/omnisharp-vscode.git
cd omnisharp-vscode
npm i
npm run compile
Open this directory in VS Code (code . assuming it is on your path)
Open src/main.ts
Set a breakpoint in the then block for ensureRuntimeDependencies in the activate function
F5
When the breakpoint hits, see if what the value for success is. If it is true, see what in the world is going wrong in coreclrdebug.activate.

I do have the same problem, and followed your steps; did not hit the break point.
Any ideas?

so I'm having the exact same problem and right now it's looking like I'm getting a Promise.reject of type GitError.  The repo it appears to be trying to hit is the one for the *.cs file that I opened to test against.  Wouldn't I be expecting it to go back up to omnisharp in this case?

@fatguyclimbs I am not 100% following what you are saying.
By "I'm having the exact same problem" are you saying that the debugger downloads and installs correctly (you should get the same output in the C# pane that are listed above), but then when you try to debug you get "The .NET Core Debugger is still being downloaded. See the C# Output Window for more information"?
I don't see how a GitError could have anything to do with the debugger installing. My guess is that is unrelated.

@gregg-miskelly my apologies.  I put my breakpoint on the wrong .then block.  I'
It ended up skipping over both of your if statements in the coreclrdebug.activate method values are included next to the equality check.
!CoreClrDebugUtil.existsSync(_debugUtil.debugAdapterDir())) ==
"/Users/LukeB/Documents/workspace/omnisharp/omnisharp-vscode/.debugger" and
!CoreClrDebugUtil.existsSync(_debugUtil.installCompleteFilePath() == "/Users/LukeB/Documents/workspace/omnisharp/omnisharp-vscode/.debugger/install.complete"

@fatguyclimbs: Thanks! What do you get with:
cd /Users/LukeB/Documents/workspace/omnisharp/omnisharp-vscode
ls Install.*

nothing came back from the ls command.
However, running through the debugger seems to have resolved my issue though as I was able to debug through the HttpClient call that's  been holding me up since last night.
I'm more than happy to continue to dig through anything if there's anything that is left over that can possibly help from this machine!

hmm... Well, you are certain welcome to just carry since you don't have the repro right now. But if you want to try again, you could certainly do a rm .\install.Lock and rm -r .debugger from the root of the OmniSharp-vscode and then try again. If that doesn't get you back into the failing state, git clean -xdf will clean everything out and you can start completely clean. I am a little confused why nothing came back since you should have at least had an install.Lock file.

I found the install.lock file back in the root of ms-vscode-csharp-1.9.0 file back up in /Users/LukeB/.vscode.
but as soon as I get the POC I'm working on running I'll go back and see what else I can dig up.
thanks for the assist

I was having the same issue until I disabled the Legacy C# Support extension and tried again... not sure if that was the problem though.

I was having the same issue:

When i reinstall it ,it still doesn't work.
My OS:Ubuntu 17.04
.NET Core Version:1.0.4

@CwjXFH that error message is confusing, but the real problem is likely that Ubuntu 17.04 isn't officially supported. Here is the message you should have received earlier:
logger.appendLine(If '${info.distribution.name}' is binary compatible with a Linux distribution officially supported by .NET Core, you may be able to resolve this by setting 'csharp.fallbackDebuggerLinuxRuntimeId' in 'File->Preferences->Settings' and restarting VS Code.);

I have finally resolve this issue on Ubuntu 17.04!

Remove OmniSharp extension from VSCode.
Close VSCode.
Install dependencies:

sudo apt-get install libunwind-dev libicu-dev

Set csharp.fallbackDebuggerLinuxRuntimeId to value ubuntu.16.10-x64
Start VSCode and install OmniSharp extension.
Happy debugging!

Is there any update on this issue. Most of the times whenever i open my project in VS Code Omisharp starts downloading

@prashantquaero please remove "omnisharp.path": "latest" from your settings. you are opted into new builds from master so there are new ones multiple times a day

Closing out stale issue


Add START marker support

Support START and END markers for data streaming

Closed in preference of https://github.com/beatlabs/proton/pull/13


Add sample for importing a certificate to Key Vault

Based on user feedback, we should add a sample for importing a certificate.

Already done: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/Azure.Security.KeyVault.Certificates/samples/Sample2_ImportCertificate.md


Change nightly scheduled time

Changing it to run 3am AEST time

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.gfukushima seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Spike: Switch to babbage and use serializeBuiltinData

What & Why
To help on testing and releasing the Babbage scope, we want to be an "early adopting" DApp prior to the Vasil HF.
In this effort we need to switch to the newly created Babbage era and use it in our Chain access components and connect to a pre-release cardano-node on the corresponding testnet.
Furthermore, this allows us to test drive the requested-by-us (as CIP) serialiseBuiltinData builtin and report on the improvement we get by it.
Scope

Update cardano-node and cardano-ledger code to some pre-release version
Switch to using Babbage era in our chain access code

Optional: also switch the embedded ledger's era if it makes things easier

Use serialiseBuiltinData instead of our on-chain-CBOR-encoder
Report new transaction size and execution costs results
Report any issues encountered along the way

Tasks

[ ] #339
[ ] Migrate scripts to PlutusV2 to, use serializeData and benchmark tx-cost

Labelled :red_circle: because this was not discussed yet and I added it to keep track.

Discussed this in planning session and with added scope we deem this to be 🟢. Also prioritized this up to provide feedback to plutus early and be in a position to verify this feature for vasil HF.

Closed by creating draft PR #355


Is it possible to use magickload?

I'm trying to convert RAW images to JPG. I've got vips compiled with magick support, and the following cli command works:
vips magickload /test-photos/Nikon/RAW_NIKON_D3200.NEF /test-photos/Nikon/RAW_NIKON_D3200.JPG
Now, when I try the same thing with Sharp, I get a really low resolution JPG as the output.
const sharp = require('sharp');
var fs = require('fs');

const filename = `/test-photos/Nikon/RAW_NIKON_D3200.NEF`
var readStream = fs.createReadStream(filename);

(() => {

    var writeStream = fs.createWriteStream(`${filename}.jpg`);

    writeStream.on('finish', () => {
        console.log("DONE")
    })

    const conv = sharp({
        failOnError: false
    })

    conv
        .jpeg({
            quality: 100,
            force: true
        })

    conv.pipe(writeStream)

    readStream.pipe(conv)

})()

I suspect what's happening is that the raw input has an embedded jpg thumbnail, and that's what's being converted here. Is there a way for me to specify that I want to use the full image data as input?

I think Nikon RAW files masquerade as TIFF files. Given you're building your own libvips, try compiling it without libtiff support via ./configure --without-tiff

Thanks @lovell. That'd most likely work, but wouldn't that leave me with no tiff support overall? That's something I still use.
Seems like the magickload command would work well. I was only wondering if it had been implemented. If it hasn't already, I may be able to put together a PR.

sharp currently relies on libvips to determine the relevant loader for a given input and I'm unsure if the added complexity (error handling, testing etc.) of code in sharp to specify the loader is worth it.
Given you're building your own libvips, perhaps you could patch one/both of the relative priority values?
https://github.com/libvips/libvips/blob/97f5417aaa16c0eda19d98816b823bc92ebc93b3/libvips/foreign/tiffload.c#L182
https://github.com/libvips/libvips/blob/97f5417aaa16c0eda19d98816b823bc92ebc93b3/libvips/foreign/magick7load.c#L356

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


Large video files cannot be added to record

Package version (if known): November Release
Describe the bug
Uploading a large video file (106,533 KB) failed. The uploaded file made it to 23% before stopping.
Steps to Reproduce

Create or edit a record.
Choose a large video file to upload.
See error.

Expected behavior
The file would have uploaded without problems.
Screen shot

Edit - Solution
The files API route in nginx needs to match up with the files API route in records-resources. Since they don't, the nginx configuration doesn't help us.
Key files:

Cookiecutter nginx config: https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/60ba9c42a44d85257f392c5dd14d4fb2ee67b13e/{{cookiecutter.project_shortname}}/docker/nginx/conf.d/default.conf#L99
Invenio-records-resources files API route: https://github.com/inveniosoftware/invenio-records-resources/blob/master/invenio_records_resources/resources/files/config.py#L27

@ppanero could this be because of Nginx configuration see here ?

@ppanero could this be because of Nginx configuration see here ?

Thank you @mb-wali!
Well that was embarassing: nginx is configured for the files api below but the actual files API doesn't use that route :facepalm: . I've edited the ticket to reflect that.

Thank you @mb-wali!
Well that was embarassing: nginx is configured for the files api below but the actual files API doesn't use that route :facepalm: . I've edited the ticket to reflect that.

Still valid

@fenekku Is this still valid? @mb-wali reported it was working for him this released (I think you actually change the nginx conf in cookiecutter IIRC)

Right, this was solved and tested with 300MB+ files.


AWS SQS & SNS Support

Not sure if that'll require a separate library or not yet. Hoping that LocalStack is viable

Tasks

[ ] config the batch size for sending and receiving
[ ] config the polling time
[ ] does it support delayed delivery? That's cool.
[ ] default credentials?
[ ] configure the credentials. Chain in FI?
[ ] alter the AmazonSQSConfig. Like Rabbit MQ?
[ ] AutoProvision
[ ] AutoPurge
[ ] IStatefulResource support
[ ] prefix!!!
[ ] SNS topics
[ ] conventional routing
[ ] conventions for SQS endpoints
[ ] configure the queues
[ ] dedicated reply queue?
[ ] UseSqs(Action).Credentials()
[ ] UseSqsFromLocalstackIfDevelopment() -- be nice to have a DEV setting
[ ] build client in transport
[ ] extension methods for listening & subscribing
[ ] TransportCompliance for durable
[ ] TransportCompliance for buffered
[ ] TODO hunt
[ ] Eliminate nullable warnings


[BUG]: Drizzkle kit generate wrong SQL for Postgres enum arrays and double precision array.

What version of drizzle-orm are you using?
0.29.1
What version of drizzle-kit are you using?
0.20.7
Describe the Bug
Hello there, just finished migrating a big~ish project from prisma to drizzle (prisma.schema was 800lines) and I encountered this bug  :
error: type "notificationtype[]" does not exist
 code: "42704"

error: type "double precision[]" does not exist
 code: "42704"

SQL line generated :
"disabledNotificationTypes" NotificationType[],

ALTER TABLE "VidStat" ADD COLUMN "watchHours" "double precision"[];

correct line
"disabledNotificationTypes" "NotificationType"[],

ALTER TABLE "VidStat" ADD COLUMN "watchHours" double precision[];

Manually editing the quotes in the sql file works.
I tried to generate them in isolation and got the same result :
ALTER TABLE "UserNotificationSetting" ADD COLUMN "disabledNotificationTypes" NotificationType[];--> statement-breakpoint
ALTER TABLE "UserNotificationSetting" ADD COLUMN "disabledEmailTypes" EmailTypes[];--> statement-breakpoint
ALTER TABLE "VidStat" ADD COLUMN "watchHours" "double precision"[];

For reference this is the TS code :
export const notificationType = pgEnum('NotificationType', ["foo", "bar"]);

const somethingLikeThis = {
    disabledNotificationTypes: notificationType('disabledNotificationTypes').array(),
    watchHours: doublePrecision('watchHours').array(),
}

Expected behavior
I expect the SQL to be generated correctly.
Environment & setup
node --version v20.5.0
macos

@Angelelz Investigating this a little I think it might be because of the fact that I'm using camelCase / pascalCase and drizzle incorrectly quote things in this scenario.

Can you show what the statement that got generated by the pgEnum?

Can you show what the statement that got generated by the pgEnum?

--> statement-breakpoint
DO $$ BEGIN
 CREATE TYPE "EmailTypes" AS ENUM('WEEKLY_DIGEST', 'IMPORTANT_UPDATES', 'PROMOTIONS_DISCOUNTS_OFFERS', 'FEEDBACK_SURVEY', 'SUBSCRIPTION_UPDATES');
EXCEPTION
 WHEN duplicate_object THEN null;
END $$;
--> statement-breakpoint
DO $$ BEGIN
 CREATE TYPE "NotificationType" AS ENUM('NEW_COURSE', 'NEW_INSTRUCTOR_ANNOUNCEMENTS', 'COMMUNITY_ENGAGEMENT', 'ACHIEVEMENT_CELEBRATIONS');
EXCEPTION
 WHEN duplicate_object THEN null;
END $$;

These 2 statements.

I also encountered this. Maybe this issue should be created in the drizzle-kit-mirror repository? It would be great if the problem was resolved soon, I really don't want to change name case everywhere =(

I also encountered this. Maybe this issue should be created in the drizzle-kit-mirror repository? It would be great if the problem was resolved soon, I really don't want to change name case everywhere =(

As a workaround you can fix the generated migration manually. Only need to be done once.

Also hit this, yet not with double precision array, but with a enum of strings.

I am hitting this issue with an enum of strings
pnpm drizzle-kit -v
drizzle-kit: v0.20.14
drizzle-orm: v0.29.4

Also stumbled upon this issue with
doublePrecison('columnName').array() generating the following sql "columnName" "double precision[]",
In my case i can simply use real instead of doublePrecision

Same issue here: doublePrecision("embedding").array() gets converted to "embedding" "double precision[]" which fails with the following error:
error: type "double precision[]" does not exist

Can't use real for embeddings, since the precision is needed.

Solved the issue by implementing a float8 column builder:

float8-pg-column-builder.ts
import type {
  ColumnBaseConfig,
  ColumnBuilderBaseConfig,
  ColumnBuilderRuntimeConfig,
  MakeColumnConfig,
} from "drizzle-orm";
import {
  PgColumn,
  PgColumnBuilder,
  type AnyPgTable,
} from "drizzle-orm/pg-core";

export type PgFloat8BuilderInitial<TName extends string> = PgFloat8Builder<{
  name: TName;
  dataType: "number";
  columnType: "PgFloat8";
  data: number;
  driverParam: string | number;
  enumValues: undefined;
}>;

const entityKind: unique symbol = Symbol("entityKind");

export class PgFloat8Builder<
  T extends ColumnBuilderBaseConfig<"number", "PgFloat8">,
> extends PgColumnBuilder<T> {
  static readonly [entityKind]: string = "PgFloat8Builder";

  constructor(name: T["name"]) {
    super(name, "number", "PgFloat8");
  }

  /** @internal */
  build<TTableName extends string>(
    table: AnyPgTable<{ name: TTableName }>,
  ): PgFloat8<MakeColumnConfig<T, TTableName>> {
    return new PgFloat8<MakeColumnConfig<T, TTableName>>(
      table,
      this.config as ColumnBuilderRuntimeConfig<any, any>, // eslint-disable-line
    );
  }
}

export class PgFloat8<
  T extends ColumnBaseConfig<"number", "PgFloat8">,
> extends PgColumn<T> {
  static readonly [entityKind]: string = "PgFloat8";

  getSQLType(): string {
    return "float8";
  }

  override mapFromDriverValue(value: string | number): number {
    if (typeof value === "string") {
      return Number.parseFloat(value);
    }
    return value;
  }
}

export function float8<TName extends string>(
  name: TName,
): PgFloat8BuilderInitial<TName> {
  return new PgFloat8Builder(name);
}


powerline font looks bad when terminal is partially translucent

environment

vim: neovim
vim-airline: vim-airline with gruvbox theme
OS: macOS
Have you reproduced with a minimal vimrc: no but that doesn't matter for this
What is your airline configuration: let g:airline_powerline_fonts = 1
if you are using terminal:
terminal: macOS terminal.app
$TERM variable: xterm-256color
color configuration (:set t_Co?): not set
if you are using Neovim: yes
does it happen in Vim: probably

actual behavior
the angled part is opaque (i know it's because it's a character but is there a way to set the font to be also partially transparent so they match?)
expected behavior
the text should also be partially transparent
screen shot (if possible)

as you can see the corner things look weird.
the terminal I can using can display partially translucent text colors,
but I don't know which file to change. the only place I know I can set the text color is in the settings, and then changing the ansi colors, but changing those don't do anything because this is a different theme

Did this change just recently? What do you mean with partially translucent?
Please show the output of :hi airline_a_to_airline_b

the output is
airline_a_to_airline_b xxx ctermfg=246 ctermbg=239 guifg=#a89984 guibg=#504945
what I mean by partially transparent is that the terminal I use can have a translucent-ish background color so that it the windows under the terminal shows through slightly. the background colors have a bit of transparency while the text doesn't so  it colors don't work

airline_a_to_airline_b xxx ctermfg=246 ctermbg=239 guifg=#a89984 guibg=#504945

This means, that the highlighting has correctly (I suppose) set terminal and gui foreground and background colors. Does that match the highlighting of the NORMAL part and the hunks part? Basically what this highlighting group does is provide an automatic highlighting that smooths (or transitions) the highlighting of the NORMAL part (highlighting group:  airline_a)  to the hunks part (highlighting group airline_b). However, if you are using a partly transparent background, this is probably not supported (neither by vim nor vim-airline). You can achieve partly something like this by leaving out the background color definitions, so that vim uses whatever is available. However note there is at least one bug with with vim with regard to highlighting and transparent background: https://github.com/vim/vim/issues/7162 and https://github.com/vim/vim/issues/2361
So unless the color definitions for the highlighting group airline_a_to_airline_b are wrong, this is not a bug of vim-airline.

yeah I realized it not a problem with vim-airline.
I think I know a way I could fix it but don't know how to change the colors correctly
I'm new to vim so how exactly would you change colors of all the different segments?
for example, I want to change the segment that says normal to ansi color 15,
and for insert mode to change it to color 12?

you are using gruvbox. So all the different colors are defined in the gruvbox airline theme: https://github.com/morhetz/gruvbox/blob/master/autoload/airline/themes/gruvbox.vim
It's a bit hairy to find the right highlighting group, since those depend most likely on other highlighting groups.

thanks!

@chrisbra @Tony1324
This issue seems to be resolved.
Can I close it?

yeah


InvalidViewerCertificate bug

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dgpeyii8voziu
Region
eu-central-1
Step
Custom Domain Activation
Status
Failed
Issue or question
Hi,
While adding custom domain I'm getting InvalidViewerCertificate error.
Amplify cli version 6.0.1
Although certificate exists in us-east-1 cli give me this error.
Take care and stay healthy.
Error message
Rsource Name: AuthDomain (AWS::Cognito::UserPoolDomain)
Event Type: create
Reason: The specified SSL certificate doesn't exist, isn't in us-east-1 region, isn't valid, or doesn't include a valid certificate chain. (Service: AmazonCloudFront; Status Code: 400; Error Code: InvalidViewerCertificate; Request ID: 1d3b782b-9b19-4c39-a2b2-04a7822cf1ac; Proxy: null) (Service: AWSCognitoIdentityProviderService; Status Code: 400; Error Code: InvalidParameterException; Request ID: 38e8f94f-00df-4726-87eb-15574cd1eb6f; Proxy: null)
Additional information
No response

Hi @mehmetkemalbayer it looks like your custom domain is up and running. If you're still running into this issue feel free to re-open.


Restore Michael Lipman's SSN (078-05-1120)

Michael Lipman's SSN (078-05-1120) was removed in this PR: https://github.com/PatrickJS/everyone-ssn-usa/pull/1 (commit 25f60dd3f70b167b788233658180fce5175644d2).
This hack is one of the largest in US history, so we should behave professionally and maintain consistency with our goals of transparency. We should treat this repository as a true archive.

Thank you for your contribution and for bringing this to our attention. We recognize the potential impact that this may have on the functionality outlined in PR #1. However, instead of a full revert, we are considering an alternative approach that involves preserving the script’s intent while mitigating any visibility concerns by strategically hiding the sensitive value (see PR #4). This allows us to maintain the original logic while addressing the issue.
We appreciate your proactive approach and would encourage further discussion on this proposal to align on the most efficient solution. Please feel free to provide additional feedback or suggestions.


Add reducers and actions

Summary of branch implementations:-

[x] Redux toolkit is added.
[x] "Feature folder" approach is followed.
[x] Books actions, action types for 'adding' and 'removing books', and reducers are created and exported.
[x] Categories actions, action type for 'checking status', and reducers are created and exported.
[x] Redux store has been created and configured.

Hi @Ofarouq310 😊,
STATUS: APPROVED! 🥇 💯

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit: 🚀
Congratulations! 🎉
Highlights
✅ Project has met all the technical aspects you needed for this project. Keep rocking!
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Set Inter to use ss02 disambiguation styleset

This adds ss02 to Inter which is the disambiguation set https://rsms.me/inter/#features
It makes ILli1 a lot easier to tell apart.
Haven't been able to get this working on web. Seems that some react-native-web styles are overriding it and the font-feature-settings aren't getting applied correctly.
Looks great on android though
Thread with some more info
https://bsky.app/profile/benharr.is/post/3l7r4sv42sk2q

Another less disruptive option is to use cv05 which changes just the lowercase l
Gitlab used that for their version of Inter:
https://www.npmjs.com/package/@gitlab/fonts
character variants aren't in the react native fontVariant though...

this needs a look from @estrattonbailey

Hey sorry for the delay. I like the idea, I tend to prefer these too. Other users may have differing opinions, but I'd be curious to try this. At the very least the lower L variant (I kinda think the I with bars is ugly heh).
I had to timebox this today, got some other stuff to get done this weekend, but did a little poking so I better understand.
It does appear that RNW doesn't support stylistic-two, which should map to ss02 as you've already investigated. Searching around, it looks like RN itself does some mapping for these values. I suppose RNW would need to do the same, probably prior to passing the raw values into the styleq library it uses internally (also authored by @ necolas). I see you have a PR with the types already, nice.
So it seems the full situation is:

web needs a local patch in our codebase, or a PR to RNW
iOS doesn't seem to be working either, might need a reduced test case and issue report in RN repo
works fine on Android, nice

Not sure if/when we'll get time to dig deeper, but happy to review code or lend an ear if you want to keep looking into this!

I think cv05 is a better target as you mention here which only applies the curly lowercase l, but this runs into a similar issue in upstream RN. I'm not seeing any types/wrappers for any of the cv character variant font-features.
I will poke around a bit on patching RN and RNW for this when I find some time.


Add schwifty

This is a first pass at adding support for Schwifty models.

Error: Cannot find module 'schwifty'

Time to publish that sucker?

Coverage remained the same at 100.0% when pulling 7c131d1606b03b8266a8fbf3904b0c184a9abd0c on mattboutet:add-schwifty into a705ac51229f8959a1506434140a100001fe157c on devinivy:master.

Just pulling @mattboutet's commits over to #19 to make some adjustments.


Add check for parent classes

Checks all parents of class and if one of them is in supported_field_classes return True.
Needed for custom field classes, that inherit from supported field class.
For example if ModificationDateTimeField was used, result was error because it's class name was not in supported field classes, despite it inheriting from DateTimeField.
So now if class inherits from supported class it returns True.

Hi, thanks for your PR. Unfortunately, I have not time to have a look today. I'll check it out in a meanwhile

Idea is interesting, though I don't think it is the best way to implement it. I suppose, it would be much better to replace string names in supported_field_classes with real class objects or their full python import path and use isinstance function to check if field is supported or not.
I suppose, it will work in your example with ModificationDateTimeField, am I right?

I've implemented my approach to this problem in here

Released v3.7.0


404 Page not found

From @mirandtech on Wednesday, April 8, 2020 2:14:21 PM
Describe the bug
A clear and concise description of what the bug is.
https://docs.microsoft.com/en-us/microsoftteams/platform/redirects/?redirectedfrom=MSDN
page not found.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
Copied from original issue: MicrosoftDocs/feedback#2655

From @welcome[bot] on Wednesday, April 8, 2020 2:14:22 PM
Thank you for creating the issue! One of our team members will get back to you shortly with additional information. If this is a product issue, please close this and contact the particular product's support instead (see https://support.microsoft.com/allproducts for the list of support websites).

As per the confirmation received from the SME (Nikitha) on 01/27/2021, while migrating v3 to v4 doc and this is deprecated, hence, closing the issue.

As per the confirmation received from the SME (Nikitha) on 01/27/2021, while migrating v3 to v4 doc and this is deprecated, hence, closing the issue.


Load config from package.json

Expected behavior
All modern JS tools take config or from .TOOLrc or from "TOOL" key in package.json. The second way is nice to keep the project root clean. It will be cool if JSDoc supports also "jsdoc" key in package.json.
Maybe we should add the same behavior to JSDoc? For instance, cosmiconfig could automatically look into both places.
Current behavior
JSDoc now takes options only from CLI arguments or .jsdocrc config.
@hegemonic if you like this idea, I will send PR.

+1 for this, @ai please submit a PR 🙏🏻

@damianobarbati I think nobody will accept it :(


Extensions

It seems to be the convention elsewhere in the API to have URL parameters use lowerCamelCase.  Is there a reason to break with this and use all caps?

Implementing the CRS, we have an issue in supporting CRSes where no EPSG code or similar is defined.  We plan to allow this by allowing the server to accept things other than URLs for these parameters (e.g. Proj4 codes), but it's worth noting this issue in case others have it and it belongs in the spec, maybe a SHOULD statement?

CIS - the basis for OAPI-Coverages work - already provides something here: a "datacube" (ie: coverage with whatever number of dimensions) has exactly 1 CRS, represented - as per OGC convention - by a URL. In case a CRS does not exist (say, in EPSG) a CRS can be combined from existing CRSs / axes. This is also foreseen in ISO 19111-2, so in line with what's out there.
OGC operates a repository of CRSs which can return the definition ("resolve")  the URL, but companies etc can just as well establish their own CRS resolver. Even inline transport in the metadata, for homegrown definitions such as supported by PROJ, is possible with this mechanism.

@bilts, re case: admittedly, I did not take enough care on this; as conventions are gradually getting stable I will be happy to do a final run once the rules are fixed.

Teleconference 20200205: Agreed to merge and restructure repository to follow OAPI-Features and to add a README.md to the extensions/ subdirectory.


Task-based Inspection for Mingsai #1

Please review this figure, could you confirm if all the equations are correctly related?

@CynthiaLiu0805, this might be a better question for Mingsai, since he is the expert on the equations.

It looks good.
Add ‘Use’ when connecting GD2-GD3 to DD7?


test: add test to check if a format string is plain

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (a583ffa) 99.40% compared to head (dc3016d) 99.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   99.40%   99.42%   +0.01%
==========================================
  Files          56       56
  Lines        5866     5877      +11
==========================================
+ Hits         5831     5843      +12
+ Misses         35       34       -1

Files
Coverage Δ

include/emio/buffer.hpp
99.35% <100.00%> (ø)

test/unit_test/test_buffer.cpp
100.00% <100.00%> (ø)

test/unit_test/test_format_string.cpp
100.00% <100.00%> (ø)

test/unit_test/test_writer.cpp
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ICE with clang-15...


Play framework / Scala apps support?

I was really surprised to see no mention of Play framework in the docs. Even googling did not help. Is no one running Play apps on Flynn? Are there plans to support those?

Flynn ships with heroku-buildpack-scala which should automatically detect and handle Play applications.
If you want to use a later version you can set the buildpack manually with flynn env set BUILDPACK_URL="https://github.com/heroku/heroku-buildpack-scala"

@nileshtrivedi there is a Play example app here: https://github.com/flynn-examples/play-flynn-example


HOMS-107 add imprint controller and print buttons

If Imprint is offline you would get 500 when you try to print order. Wrap it in pretty error message. Something like "Print form printing service is not available".

When cursor points to "print" icon or "pencil" icon, icons are underlined. Do not underline, it looks ugly.

merge


Add CRUD like API for diagnostics bundles

The API definition could be found here

Codecov Report

Merging #112 into master will increase coverage by 3.41%.
The diff coverage is 81.98%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   60.15%   63.57%   +3.41%
==========================================
  Files          20       23       +3
  Lines        1915     2251     +336
==========================================
+ Hits         1152     1431     +279
- Misses        646      684      +38
- Partials      117      136      +19

Impacted Files
Coverage Δ

cmd/daemon.go
0% <0%> (-41.97%)
:arrow_down:

api/router.go
67.69% <100%> (+3.3%)
:arrow_up:

api/rest/bundle_handler.go
75.26% <75.26%> (ø)

collectors/collector.go
83.33% <83.33%> (ø)

api/rest/status.go
85.71% <85.71%> (ø)

api/providers.go
95.95% <92%> (+12.28%)
:arrow_up:

cmd/root.go
70.29% <96.15%> (+27.43%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34250b2...75b4116. Read the comment docs.

:wave: @drewvanstone @br-lewis @makkes  Can you review, please?


After updating the home key is disabled

After I installed the update through the digital paper app, the home key is disabled, after I start it, it shows applanuncher is stoped.
I can read paper in default reader app, however, I can not open the Android screen and use home to select the setting.

Did you update according to https://github.com/HappyZ/dpt-tools/wiki/The-Upgrade-Guide

Yeah, I have tried upgrade according to https://github.com/HappyZ/dpt-tools/wiki/The-Upgrade-Guide after I upgrade by Official Digital Paper Application. It shows the App launcher is stoped.
I also tried previous official pkg to downgrade the system, it also does not work.
Now, I am trying to find other alternative launchers to fix this problem.
And I want to know how can I delete the modified part and back to the official version, maybe root again may fix this problem.

You did the app launcher mod too?
If you post logcat it could be helpful.
On Thu, Mar 12, 2020, 13:43 Xiang Pan<EMAIL_ADDRESS>wrote:

Yeah, I have tried upgrade according to
https://github.com/HappyZ/dpt-tools/wiki/The-Upgrade-Guide after I
upgrade by Official Digital Paper Application. It shows the App launcher is
stoped.
I also tried previous official pkg to downgrade the system, it also does
not work.
Now, I am trying to find other alternative launchers to fix this problem.
And I want to know how can I delete the modified part and back to the
official version, maybe root again may fix this problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/HappyZ/dpt-tools/issues/161#issuecomment-598409486,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDVEKS3KWFKHTVVEJNHDWLRHFCNLANCNFSM4LGUDHGQ
.

Ok, thanks for your help! I tried reinstall launcher mod. It fixed.
Maybe you can add this step to the upgrade guide.

upgrade guide has it..
On Thu, Mar 12, 2020 at 2:10 PM Xiang Pan<EMAIL_ADDRESS>wrote:

Ok, thanks for your help! I tried reinstall launcher mod. It fixed.
Maybe you can add this step to the upgrade guide.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/HappyZ/dpt-tools/issues/161#issuecomment-598419571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDVEKS2H3TNFAR7LR2D4QDRHFFSVANCNFSM4LGUDHGQ
.

--
BR | Yanzi Zhu
https://happyz.me


feat: Allow "temp" files to be conditionally removed by user-set parameter (extending --nt)

Description
This PR changes the handling of temp files and the --nt parameter. It isn't directly related to #1602, but I believe it may be able to solve it.
The motivation is currently snakemake can delete all temporary files or none. As stated in the --nt parameter, if you are only running part of a pipeline but want to keep temp files that would be used later, you have to switch off all temporary file removal. So you end up in two situations

keep unwanted temp flagged files
comment out the temp flag on files you do want to keep for now

With this implementation, the default behaviour can be maintained

all temp flagged files are deleted
using --nt keeps all temp files
while also extending to allow
deleting certain temp flagged files based on a value set at runtime/config

This would work in the snakefile as
rule test1:
    output:
        temp("foo.txt",threshold=5)

rule test2:
    output:
        temp("bar.txt",threshold=2)

and running with
snakemake --nt

would delete all temporary files while
snakemake --nt 4

would only delete bar.txt (threshold 2<4) and keep foo.txt (threshold 5>4).
This easily allows users to configure which temp files should be deleted in partial runs, debug runs, release runs etc. There are some files that are 100% temporary and I would never like to keep while some are worth keeping while I flesh out the pipeline, which can be resolved here.
DRAFT
The main issues here are

hijacking the --nt parameter, so the name may be misleading now. I was avoiding introducing another parameter, but may be the cleanest solution.
determining the logic to be backward compatible. In this current implementation, notemp should be set to inf, so may just need to make thresholds implicitly negative or something else to make sure --nt behaves as expected.

QC

[ ] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[ ] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Actually it may be more in keeping with the meaning of --notemp to reverse the logic, and not delete files which have a threshold set below the user provided value.
So
rule test1:
    output:
        temp("foo.txt",threshold=1)

rule test2:
    output:
        temp("bar.txt",threshold=2).

And then
snakemake --nt

would keep all
snakemake --nt 1

would keep foo.txt, and
snakemake --nt 2

would keep both foo.txt and bar.txt

Can extend this to also include --delete-temp-output to have a user set level. The main issue is now --notemp (and maybe later --delete-temp-output) want to take an argument, so previous snakemake calls like
snakemake --quiet --notemp rule_of_choice

try to convert "rule_of_choice" to a float for notemp, so would need to be changed into
snakemake --quiet --notemp -- rule_of_choice

Not a difficult change, but was hoping to avoid too many syntax changes. Might be better to just add a new parameter called "--delete-temp-level" or something...

May be overcomplicating, but it was also possible to extend --nt as a parameter accepting 0 or more arguments. The logic would then be as follows

empty case: --nt -- <other args>  would implicitly set notemp to negative infinity and thus ignore all temp directives
single value case: --nt 5 would ignore temp directives for anything with threshold equal to or above the given value
multiple value case: --nt 3 5 10 would ignore temp directives for with the specific threshold values (would retain if threshold is 3, 5, or 10, would delete if threshold is 2, 4, 6, 7, 11, etc)

Does get complicated, but allows users as much granularity as they are willing to set.

I think this is a very useful feature to add. I often find myself commenting out temp() declarations during workflow development, and have forgotten to comment them back in for production.
I thought I would add my input on your current implementation and reply to some of your comments.

I vote to not hijack the --nt parameter for new use.
This would prevent backward compatibility of workflows. Anyone who uses --nt in their scripts with Snakemake would need to update them in order to upgrade Snakemake to a new version. Since most people don't read release notes when updating software, they would likely be unaware of the change to --nt.
For this reason, it is better to add a separate --nt-threshold parameter.

Same thing for --delete-temp-output. I know this is not implemented in the current PR, but if added, I think it would be better to just add a --delete-temp-output-threshold parameter.

In response to your comment about overcomplicating it, I think that is overly complicated. Just the threshold is sufficient for users to have the flexibility that this feature is meant to provide, namely, deleting only certain temporary files when running a workflow.

Possible Concerns

Scalability - This code adds logic comparing <= between the threshold file flag of temporary files and a user speciefied threshold value --nt. It would run this logic for every single temporary file in a workflow to see if it meets the threshold for deletion. If a workflow has millions of temporary files, this might be noticable speed-wise.

Infinite Loops - You defined and stored the --nt threshold as a float. Comparing floats can be imprecise sometimes and even lead to infinite loops (see here).
It is sufficient for this feature to use an integer for the threshold parameter, so it would be better to just define it like that. This avoids that problem.

Looking forward for this feature. It will extend the usage of snakemake. Thank you for implementing it!

Thinking out loud here... can the temp function accept:

a regex, which, if it re.matches the pattern, will/not keep the file?
a callable that returns a boolean, with the signature lambda wildcards:... (similar to input functions)?

rule a:
    input: ...
    output: temp("{name}.{ext}, lambda w: w.ext == "bam")  # mark as temp if ext == "bam"

Closing this in favour of #1969 which can achieve the same goals with more generalisation and less argument clutter.


Bugfix/fbp 105 sequence element parent

Fixes #105

Codecov Report

Merging #107 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #107      +/-   ##
============================================
- Coverage     54.13%   54.12%   -0.02%
  Complexity      576      576
============================================
  Files            80       80
  Lines          3105     3106       +1
  Branches        586      587       +1
============================================
  Hits           1681     1681
  Misses         1198     1198
- Partials        226      227       +1

Flag
Coverage Δ
Complexity Δ

#unittests
54.12% <100.00%> (-0.02%)
576.00 <2.00> (ø)

Impacted Files
Coverage Δ
Complexity Δ

...n/kotlin/com/valb3r/bpmn/intellij/plugin/Colors.kt
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

.../intellij/plugin/flowable/parser/FlowableParser.kt
64.98% <100.00%> (+0.11%)
51.00 <2.00> (+1.00)

...ginjection/FlowableDelegateExpressionUiInjector.kt
52.94% <0.00%> (-5.89%)
6.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3e4e3...56048bb. Read the comment docs.


Display date and time in two rows

I want to display the date and time as the time (e.g. 01/01/2018 10:09 AM instead of only 10:09 AM) but if I do that, the time column takes too much space (i.e. his width is too large).
So, is there a way to display the time in two rows?

What I want is the time to be displayed like:
01/01/2018
10:09 AM

Instead of being displayed like:
01/01/2018 10:09 AM

Closing since just find out that there is a renderTime property


Select table with test data

Description
Adds a front end option to select a table with a seperated option to select test data
Link to the issue you are closing
Fixes #121
Screenshot or other testing that you have completed

Checklist:

[x] ESLint passes
[x] Prettier passes
[x] Included comments where necessary
[x] Updated README if needed
[x] Verified that code runs and generates no errors/warnings

Integrated into #175


fix: add doctor support to sf cli

What does this PR do?
Just like the sfdx cli, adds the code to initialize the Doctor class when a doctor command is run from the sf cli.
What issues does this PR fix or reference?
@W-11862622@

Doctor QA Notes

✅ doctor -h
✅ doctor --help
❌
➜  ./bin/dev doctor
ERROR running doctor:  Must first initialize a new SfDoctor.


remove start command

As of right now, starting a long-running process like one via npm start doesn’t resolve in the terminal. So if the user wants to cancel the dev server, the port will remain locked in the background and the only way to kill it would be to run lsof -i tcp:<PORT>.
I recommend not starting the server automatically until https://github.com/devcontainers/spec/issues/83 is resolved.

Thanks @burkeholland for taking the time to check this out, and bring up the npm start issue. I reached out to the GitHub team to see progress on this so we know when it will be resolved so that we can enable it. For now, good call to remove.


[BUG] UserAgent policy seems violating from telemetry guideline

This guideline defines "[<application_id> ]azsdk-<sdk_language>-<package_name>/<package_version> <platform_info>" as telemetry and this table says AZURE_TELEMETRY_DISABLED is for controlling collection of this telemetry. If we follow this then UserAgentPolicy should not be activated at all if AZURE_TELEMETRY_DISABLED is set to true. It seems today AZURE_TELEMETRY_DISABLED controls only platform_info part of telemetry.
We want to confirm whether it's a bug in Java  UserAgentPolicy implementation or error in guideline.

@JonathanGiles @adrianhall could you please chime in to double guideline is correct here?

My expectation would be that if AZURE_TELEMETRY_DISABLED is set to false in the environment, that there would be no telemetry at all included in the User Agent policy. @adrianhall might interpret the requirements differently though.

It's a great comment to have a discussion about within the arch board.  @anuchandy - please file an arch board issue on azure/azure-sdk.
This isn't my addition (and its of marginal value since the user can override the user-agent).  But we should discuss.

Here is the issue created in arch board.
https://github.com/Azure/azure-sdk/issues/819

No longer working on Java related issue. Thanks!

No longer working on Java related issue. Thanks!

The parent arch board ticket is no longer active. Closing.


added Docker for Mac/Windows install links

reorder the install steps

I know Derek isn't running here right now but still need sign-offs on commits please.

I can't rebase the change so I'm going to add it in manually. Thanks for the links.


Why SWCLK and SWD register of pads_bank0 is not modeled in hardware structure?

Hi guys,
From the rp2040 datasheet(page 300), there are 2 registers named SWCLK and SWD at the offset of PADS_BANK0_BASE+0x7C and PADS_BANK0_BASE+0x80, right after the register for GPIO29. But there is no place for SWCLK and SWD in pads_bank0_hw_t. In my understanding, either the sizeof pads_bank0_hw_t.io should be 32 or there should be 2 additional fields, for example,
typedef struct {
io_rw_32 voltage_select
io_rw_32 io[30];
io_rw_32 swclk;    //
io_rw_32 swd;      //
} pads_bank0_hw_t;

How does this happen? Many thanks!

Those hardware_structs are autogenerated, so pinging @matiasilva
Interestingly, the "lower level" rp2040/hardware_regs/include/hardware/regs/pads_bank0.h (which is also autogenerated) does provide definitions for SWCLK and SWD.

Hi, these fields were not exposed in the previous run of header generation, so this looks intentional?


Issue when changing PolicyEnforcement

This issue happens on Jenkins build (861)[https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/861/]
Error:
level=info msg="setting PolicyEnforcement=always"
cmd: "sudo cilium config | grep PolicyEnforcement | awk '{print $2}'" exitCode: 0
 never

cmd: "sudo cilium config PolicyEnforcement=always" exitCode: 1
 Error: Unable to change agent configuration: Patch http:///var/run/cilium/cilium.sock/v1beta/config: EOF

Trying the same order and it didn't happen, so must be a race condition in any
place.

We haven't seen this issue in some time; I think we can close this.


Fix Go 1.13 private repository go get issue

Fixes #8095.

@rutgerbrf please send a PR to master at first.

Since #8112 merged, I have removed the blocked label. @techknowlogick

@techknowlogick it is been merged to master please approve


I've found some bugs.

Hi there,
I read the training code line by line, and I've found some bugs.

When making the contextualized vector representations of the image tokens, the model references text pad tokens. I think you need to mask the text pad parts for that!
When making the text loss, you included the loss from the text pad tokens. I think it should be removed from the text loss.

Thanks for updating the code!

@wcshin-git Hi Woncheol! Glad you have been studying the code :)
So, while you are correct that is the conventional way of doing things, if you read the paper, they actually do not mask out attention to the padding tokens. The paper takes a completely new turn, where they give each position a unique padding token. They neither exclude it from the loss nor mask out attention to it, as far as I understand it.
Hope this help!


test: add matrixonecluster rolling-update test

What type of PR is this?

[ ] API-change
[ ] BUG
[ ] Improvement
[ ] Documentation
[ ] Feature
[x] Test and CI
[ ] Code Refactoring

Which issue(s) this PR fixes:
As titled. Part of #212
What this PR does / why we need it:
Not Available
Special notes for your reviewer:
Not Available
Additional documentation (e.g. design docs, usage docs, etc.):
Not Available

/merge


Finding unique values

https://api.jquery.com/jQuery.unique/

http://api.jquery.com/jquery.grep/ combined?

"Note that this only works on arrays of DOM elements, not strings or numbers."


Only the first combobox works then all the others stay in place.

Don't have git on this computer so cant make a PR, but you fix it by doing
https://pastebin.com/rLgnFrMu

Didn't notice while testing.
Fixed with https://github.com/Wando1423/Antario/commit/a9da4806dcb0e3f3519fedc92ec77beeac7cd453

FYI @Monsterxsync you can edit files in the browser and GitHub will automatically fork the repo, and allow you to make a PR. All from the web.

Oh i didnt know that thanks!


Feature/ui mockup may05 version

@soninob I believe build should be at the project level. Let's talk on Sunday.

@edagan - I started doing it at the project level. But then I remembered that you ask me also to support executing multiple projects.
For now, we will keep it in the size of one to reduce additional work on the BE.
Do you think we should keep two implementations to the execution?

Project level + multiple calls from UI when more than one project is selected is the way to go, I believe.

@edagan - according to our conversation, we will not support multiple projects for now, the route will be under the projectID. no support for building with params for now.
I will update the branch and let you know when done.

@edagan - Changes were made based on our conversation.
Let me know if we want to handle actions on the build itself (stopping it, getting it, etc.)

Thanks!
As we discussed, this is the first phase for project-level execution. Merging.

@soninob @edagan just reviewing the latest changes for the project level execution API. From what I can see there is no information being sent for the ordering. That would imply that for nowthe backend can decide in which order they are executed. Please confirm :smile:
Cheers!


Adding support for static mac

This enables static mac support for windows containers.
Two other minor fixes:

Allow users to specify the physical interface they want to create a network on
IPAM doesn't override preferred IP anymore. This allows user to specify --gateway option which can be passed directly to HNS. This is required for creating networks in Azure and Microsoft Azure stack.

CI results:
PS C:\gopath\src\github.com\docker\libnetwork\drivers\windows> godep go test -v
=== RUN   TestNAT
--- PASS: TestNAT (1.00s)
=== RUN   TestTransparent
--- PASS: TestTransparent (1.10s)
PASS
ok      github.com/docker/libnetwork/drivers/windows    2.192s

LGTM


UG: add jar link and table of content navigation

jar link and table of content heading and navigation in middle of page

Codecov Report

Merging #111 (80a848e) into master (e1d360f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage     73.16%   73.16%
  Complexity      445      445
=========================================
  Files            76       76
  Lines          1323     1323
  Branches        140      140
=========================================
  Hits            968      968
  Misses          321      321
  Partials         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d360f...80a848e. Read the comment docs.


No module named 'returndata' in Web app's main.py file

Hi, very nice work.
I'm trying to run the web app, and in main.py there's an import (from returndata import Content), but there is no file named "returndata"?

Hi i could not find returndata

Hi, me neither

@jawadsh123 @adimyth Hi guys, if you get some time over the weekend could please look in this issue


The purpose of embed_extractor in the thing/stuff_generator class

Is it just a linear project layer? After acquiring the kernel weights from the KernelHead, I cannot find any activation layer following the layer itself. The weight seems to go directly to another Conv2d layer (embed_extractor) without any non-linearlity. If so, why not directly producing the kernels in the kernelhead instead?

Hi, the embed_extractor is used to ensure the same channel of the generated kernel and that in the encoded feature.
Because the channel in encoded feature may channel in different settings. So, the embed_extractor  is adopted for adjustment.

I see, so it is basically a linear projection. Thanks for your clarification.


UI Tests for the extension (in nodejs)

Re-write of https://github.com/microsoft/vscode-python/issues/4692
The original UI Tests were written in Python (that solution had issues due to the use of selenium driver).
The new version will be based on nodejs using the Chrome devtools protocol (puppeteer).
Broken into the following stages:

[ ] Refactor pipelines into stages https://github.com/microsoft/vscode-python/pull/7430
[ ] Add UI Tests to run smoke tests (enable just the smoke tests) https://github.com/microsoft/vscode-python/pull/6717 (todo - break up PR).
[ ] Add UI Tests to run UI Tests (enable just the stable UI Tests) https://github.com/microsoft/vscode-python/pull/6717
[ ] Add UI Tests to run UI Tests for other tests (there are a number of UI tests that are disabled).

Closing in favor of https://github.com/microsoft/vscode-python/issues/6511


Misc improvements

This pull request contains several improvements:
-Add support for automated testing
-Add recommended eclipse configuration
-Add new targets to speed_test.py
-Fix bugs and improve MbedBoard class
Let me know if you see any problems or would recommend any changes to make these patches better.  All feedback is appreciated.

Ran automated_test.py on several connected boards.

I glanced over the files, this PR looks fine. I would like to run the automated test on some boards today.


Webhook: Allow filtering for data.result of event

To create more targeted notifications (e.g., send slack notification on deployment errored), it would make sense to allow filtering of the data result of an event.

Very similar to what the job-executor-service is capable of, I would like to filter on certain event properties:
apiVersion: v2
actions:
  - name: "Run locust"
    events:
      - name: "sh.keptn.event.test.triggered"
        jsonpath:
          property: "$.data.test.teststrategy"
          match: "health"

Based on the above example, sh.keptn.event.test.triggered is forwarded when teststrategy = health

Question from the team:

which syntax to use? (JSON Path)
will it be there multiple filters?
what operators should be available? Only equality?
if multiple filters are set? will they be put in AND or OR?
how these filters should be configured?

Hi,

I would like to show my opinion on this topic based on the following use cases:
1. Use Case: As a user, I would like to trigger a remediation action if the action matches "roll-back".

2. Use Case: As a user, I would like to send a Slack notification if the evaluation failed.

3. Use Case: See example from above: As a user, I would like to trigger a test if the teststrategy equals health.

Q1: As a user, I won't play around with JSON syntax. I just want to reference a property from my task, which is technically stored in the event (e.g., for the second use case regarding evaluation, see $.data.evaluation.result). Note: Per convention, each event type (e.g. evaluation) has its reserved data block (i.e. evaluation):

{
  "data": {
    "evaluation": {
      "result": "fail",
      "score": 0,
      "timeEnd": "2020-09-01T08:36:06Z",
      "timeStart": "2020-09-01T08:31:06Z"
    },
    "labels": {
      "DtCreds": "dynatrace",
      "buildId": "build-17",
      "owner": "JohnDoe",
      "testNo": "47-11"
    },
    "message": "Evaluation failed since the calculated score of 0 is below the warning value of 75",
    "project": "sockshop",
    "result": "fail",
    "service": "carts",
    "stage": "staging",
    "status": "succeeded"
  },
  "id": "0f7ada5a-35d0-4d1e-856d-2b05dddc2476",
  "source": "lighthouse-service",
  "specversion": "1.0",
  "time": "2021-12-13T10:53:54.710Z",
  "type": "sh.keptn.event.evaluation.finished",
  "shkeptncontext": "4dd22f26-77d9-4a69-9b6d-db177689ac43",
  "shkeptnspecversion": "0.2.3",
  "triggeredid": "1f9cce30-300a-4841-be65-d57cbfb28581"
}

Q2: Yes, I can add multiple filters on the payload which are connected with an AND:

Q3:  Only equals (match) for now.

Q4:  No, just one list of property filters that are AND connected (see above). Note: If a user wants to create a OR connection, a second subscription can be created on the same event type:

Q5: How these filters should be configured? (see screenshots from above)

The decision of the team: refine this ticket into subtasks and substories since it requires a lot of changes in:

shipyard-controler
uniform API model
Bridge UI
Distributor

Furthermore, there are open questions:

for which property should we filter? Limited set based on the last event? pre-defined set of properties?
should we allow free text?
only properties inside the data field or also "shcontext" or "id"?

To the open questions:

The first question is a bit conflicting. We should be able to filter on all properties form the last event, but what should we filter for if there is no event. A very similar problem we have here with this Show example payload button:

Proposal: If no last event is provided, fall back to the default properties we have in the data block.

Not for the property, but for the value.

I see no use-case for filtering on a property outside the data block.

For question about the filtering syntax. The webhook service already uses syntax such as {{ .data.stage }} so IMO it makes sense to follow convention see here.
I'd like to see the webhook service be unopinionated about what I might want to filter on, so allow me to use anything in the JSON payload.
Some examples:
{{ .source == "some-source" }} and {{ .data.evaluation.result == "failed" }}
{{ .data.evaluation.result == "pass" }}
{{ .data.evaluation.result == "failed" }} and {{ .data.action == "scaleup" }}


Update hwloc to v2.1.0

Since this changes hwloc's API, there are a few things we should consider:

Are Charm++/AMPI applications allowed to use hwloc directly if they want to?
Do we support mixing our hwloc with an external hwloc?

Are Charm++/AMPI applications allowed to use hwloc directly if they want to?

It looks like we expose hwloc.h in our include folder. I would discourage this though.
Note that I didn't need to change our code that makes use of hwloc for this update.

Do we support mixing our hwloc with an external hwloc?

Yes, see #1895.

Are Charm++/AMPI applications allowed to use hwloc directly if they want to?

It looks like we expose hwloc.h in our include folder.

So in case the application requires another version of hwloc.h, there might be conflicts?

Note that I didn't need to change our code that makes use of hwloc for this update.

Ok, but there have been substantial API changes in 2.0: https://www.open-mpi.org/projects/hwloc/doc/v2.1.0/a00343.php

As long as the API changes don't affect our current usage, I think the upgrade should be merged on its own, and any other issues cleaned up in separate commits


[ECL] Moving towards multi-sensor-per-same-measurement fusion

This ECL PR aims to provide unambiguous logging of velocity and position measurement updates in the EKF2 estimator.
To enable this, we need to provide the right uorb messages on the Firmware side. Making the measurements sensor specific would increase the number of fields in ekf2_innovations.msg.
To avoid this we split the message in to sensor specific innovations, innovation variances and innovation test ratios.
These messages have different use-cases and can be enabled accordingly.
Logs of several test flights can be found in the ECL PR.

@dagar This is running out of space on fmu-v2 :)
Do you have an idea how we can get this in?

Looks good

@kamilritz you are also missing adding the RTPS ID's: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-compile/detail/PR-13127/8/pipeline/60#step-619-log-45

@kamilritz is there any reason ware creating 2 new messages for this? Why not just use ekf2_innovations.msg and add #TOPICS aliases for the other two, as they seem to have the exact same fields?

This would be something like: (ekf2_innovation.msg)
uint64 timestamp	# time since system start (microseconds)

# GPS
float32 gps_hvel	# horizontal GPS velocity innovation
float32 gps_vvel	# vertical GPS velocity innovation
float32 gps_hpos	# horizontal GPS position innovation
float32 gps_vpos	# vertical GPS position innovation

# External Vision
float32 ev_hvel	# horizontal external vision velocity innovation
float32 ev_vvel	# vertical external vision velocity innovation
float32 ev_hpos	# horizontal external vision position innovation
float32 ev_vpos	# vertical external vision position innovation

# Height sensors
float32 rng_vpos	# range sensor height innovation
float32 baro_vpos	# barometer height innovation

# Auxiliary (horizontal) velocity
float32 aux_hvel	# horizontal auxiliar velocity innovation from landing target measurement
float32 flow		# flow innvoation test ratio

# Various
float32 heading	# heading innovation
float32 mag		# earth magnetic field innovation
float32[2] drag	# drag specific force innovation
float32 airspeed	# airspeed innovation
float32 beta		# synthetic sideslip innovation
float32 hagl		# height of ground innovation

#TOPICS ekf2_innovations ekf2_innovation_variances ekf2_innovation_test_ratios

Also, please add those aliases to the RTPS ID's list.

@TSC21 That is a nice idea. The innovation_test_ratios fields are not exactly the same. But we can do this for innovation and innovation variances.

@TSC21 That is a nice idea. The innovation_test_ratios fields are not exactly the same. But we can do this for innovation and innovation variances.

@kamilritz the only difference I see is on the arrays. The same structure can still be used, but instead of using the entire array, just used the first array index.

@dagar This is running out of space on fmu-v2 :)
Do you have an idea how we can get this in?

I am not sure how much short we can get on fmu-v2 to get this in :S

@dagar This is running out of space on fmu-v2 :)
Do you have an idea how we can get this in?

I am not sure how much short we can get on fmu-v2 to get this in :S

There's quite a bit more that can be saved with a little effort. https://github.com/PX4/Firmware/pull/12601 https://github.com/PX4/Firmware/pull/12191

@dagar This is running out of space on fmu-v2 :)
Do you have an idea how we can get this in?

I am not sure how much short we can get on fmu-v2 to get this in :S

There's quite a bit more that can be saved with a little effort. #12601 #12191

Still on time for a release?

@TSC21 @kamilritz We can't change messages in ulog wildly like that. There are two options:

Just extend the existing message, only adding fields and not renaming any
Rename the whole message, so that the post-flight tooling can check for different message formats.

@TSC21 @kamilritz We can't change messages in ulog wildly like that. There are two options:

Just extend the existing message, only adding fields and not renaming any
Rename the whole message, so that the post-flight tooling can check for different message formats.

@LorenzMeier I was with the idea that it was ok to rename fields as long as we were synced with a release period were the debugging and plotting tools could be updated as well - and in that case it were the plotting tools that were extended and not the uORB msgs with new fields. But if it's just too much field renaming, I guess we can just add new fields and keep the previous naming for the others, but I think we lose consistency here.

This would break all post-flight tooling due to the uorb format changes - we need to take a more compliant approach for message changes. It is fine to break uORB to some degree, but ulog needs to be a more steady format.

Let's make an RFC for this and add it to the guidelines then, also go through what we think are critical messages and add a SITL test to make sure they still work.

Let's make an RFC for this and add it to the guidelines then, also go through what we think are critical messages and add a SITL test to make sure they still work for log processing tools.

Shouldn't log processing tools be topic name/field agnostic? And if they are not they can map the names from different releases to a common name?

I changed the topic names such that it is detectable, which version of the message is logged.

Shouldn't log processing tools be topic name/field agnostic? And if they are not they can map the names from different releases to a common name?

I think the issue is something like https://logs.px4.io where it automatically puts certain topics on certain graphs. If we reuse a field without changing the name these tools will silently start plotting garbage.

@dagar Can we get this in? I think I have sufficiently addressed the feedback and CI is only failing due to limited stack size on fmu v2.
If yes, we first need to merge: https://github.com/PX4/ecl/pull/668

@mhkabir I have tested it on my platform extensively. I ran GPS, VIO, FLOW in a lot of combinations and never had a preflight check failure that was not magnetometer related :)

@kamilritz Can you post some of that test data?
@PX4/testflights can you test this please?

@jkflying @bkueng Can you review this? This is the biggest change to the EKF (and the ekf2 frontend) in a while.

@mhkabir This is a log with GPS, VIO and FLOW combined: https://review.px4.io/plot_app?log=47bfecee-e43a-465c-82aa-d48f796e9749

@kamilritz thanks for the log. I looks OK, apart from this:

@kamilritz thanks for the log. I looks OK, apart from this:

Is there something I can do about this?

tested  on pixhawk4 v5 f-450
Flight Card 1
Modes Tested:
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Procedure:
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode.
Notes:
No issues were noted, good flight in general.
Logs:
https://review.px4.io/plot_app?log=a671f8b5-6372-47d1-97dc-e4b4d0a3a379Flight Card 2
Modes Tested
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.
Procedure
Armed form QGC.
Took-off on mission plan mode
. Note that commands were sent form QGC (Armed and takeoff)
Once all waypoint completed vehicle switched to RTL and landed as expected.
Good flight in general.
Note:
No issues were noted, good flight in general.
Logs:  https://review.px4.io/plot_app?log=38bf258c-29c1-43c2-ba2e-2f1df34e5af4
Flight Card 3
Modes Tested
Position Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.
Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.
Good flight in general.
Note:
No issues were noted, good flight in general.
Logs:   https://review.px4.io/plot_app?log=a2b30f1d-1a01-40a6-b305-69ca7692d8cf
Flight Card 4
Modes Tested
Fail safe:The radio control turned off and the vehicle returned and landed correctly.
Tested good.
Logs:
https://review.px4.io/plot_app?log=523e05cc-2d63-460a-8792-518502e1efc1

Tested on NXP FMUK66 v3
Flight Card 1

Modes Tested

Position Mode: Good
Altitude Mode: Good
-Stabilized Mode: Good

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode.

Notes
No issues noted, good flight in general.

Log
https://review.px4.io/plot_app?log=815b10b1-6ff9-413a-9d37-4e36f4df7598

Flight Card 2

Modes Tested
-Mission Plan Mode (Automated): Good.
-RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
Vehicle did not land properly.
While landing, vehicle descended very quickly then stoped at about 3 meters from the ground and ,like a bounce, the vehicle increased altitude to about 10 meters then it proceeded to rush to the ground fast enough for it to bounce off the ground and a really violent way and flipped. (Pilot required to switch "Kill Switch" ON in order to avoid vehicle damaging motors and propellers after the bounce/flip).
Loaded Master and vehicle behaved as expected, no issues.

Log
https://review.px4.io/plot_app?log=1a70df8e-aeac-47c3-87ac-ad39b73b8e00

Flight Card 3

Modes Tested

Position Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
Vehicle did not land properly.
While landing, vehicle descended very quickly then stoped at about 3 meters from the ground and ,like a bounce, the vehicle increased altitude to about 10 meters then it proceeded to rush to the ground fast enough for it to bounce off the ground and a really violent way and flipped. (Pilot required to switch "Kill Switch" ON in order to avoid vehicle damaging motors and propellers after the bounce/flip).
Loaded Master and vehicle behaved as expected, no issues.

Log
https://review.px4.io/plot_app?log=7ae7fbcb-9531-47d1-9267-dd0bd772e4f4

Tested on Pixhawk Pro v4
Flight Card 1

Modes Tested

Position Mode: Good
Altitude Mode: Good
-Stabilized Mode: Good

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode.

Notes
No issues noted, good flight in general.

Log
https://review.px4.io/plot_app?log=f1a26e95-b979-467d-83d1-5dc0c5fb4fdd

Flight Card 2

Modes Tested
-Mission Plan Mode (Automated): Good.
-RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
No issues noted, good flight in general.

Log
https://review.px4.io/plot_app?log=ac657dc9-733b-471b-907c-cd0bab7f772a

Flight Card 3

Modes Tested

Position Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
No issues noted, good flight in general.

Log
https://review.px4.io/plot_app?log=aab917c9-aa48-42be-a439-b857f7266e1a

Flight Card 4

Modes Tested

Position Mode: Good.
Failsafe RTL (Return To Land): Not returning after RC shutdown.

Notes
No issue noted, good flight in general.

Log
https://review.px4.io/plot_app?log=c0a1bc66-9c00-43f3-a03e-431b6bae2613

Loaded Master and vehicle behaved as expected, no issues.

@Junkim3DR To see if the reported problems in landing detection are for sure related to this pr and what exactly was different on that particular setup it would help a lot to have the log when you compared with master and had no issues as well. Do you still have this log? Could you upload it?

Do you still have this log? Could you upload it?

Hi @MaEtUgR, I believe this are the 2 logs I tested with master to see if the issue persisted.
Logs

https://review.px4.io/plot_app?log=2c48c8eb-b7b5-4322-840a-be6b7d75886a
https://review.px4.io/plot_app?log=eb0718a7-b018-400d-8a1b-1ae1fe71c5b6

@MaEtUgR it's the same setup nothing was changed.

@Junkim3DR can you please fly the NXP FMUK66 v3 with flight card 2&3 again. Once with this PR and once with current master. Please perform the same flights with both firmware version. Thank you very much.

Remaining things before we merge this (we're very close!):

FMU-v2 flash overflow.
Merge ECL PR. and rebase this on
Make sure land detection failure is not related to changes here.

Make sure land detection failure is not related to changes here.

@mhkabir any ideas how I can investigate this?

Tested on NXP FMUK66 v3
Flight Card 2

Modes Tested
-Mission Plan Mode (Automated): Good.
-RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
No issues on PR, vehicle landed slightly faster on master and bounced from the ground considerably.

Log

PR: https://review.px4.io/plot_app?log=358d8b6c-1e76-483b-b42f-f549f5ffe7bf
Master: https://review.px4.io/plot_app?log=c2c7dfaa-dd65-4e85-b8ad-835cc90efe58

Flight Card 3

Modes Tested

Position Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
Vehicle had no issue at all.

Log

PR: https://review.px4.io/plot_app?log=f1a87df3-f4bd-4960-bed5-12f24ec68249
Master: https://review.px4.io/plot_app?log=9123ef2f-c716-4925-b899-f04965c53b16

@Junkim3DR Thanks for the new log files. There is definitively something odd. We would need another log file that we can use for EKF replays. Can you flash the newest version of this PR, set SDLOG_PROFILE=2, set SDLOG_MODE="from boot to disarm", fly Flight Card 2 again and upload the log.
Thank you very much.

@Junkim3DR Which master firmware were you running as reference?

We would need another log file that we can use for EKF replays. Can you flash the newest version of this PR, set SDLOG_PROFILE=2, set SDLOG_MODE="from boot to disarm", fly Flight Card 2 again and upload the log.

Tested on NXP FMUK66 v3
Flight Card 2

Modes Tested
-Mission Plan Mode (Automated): Good.
-RTL (Return To Land): Good.

Procedure
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.

Notes
No issues on PR, vehicle landed slightly faster on master and bounced from the ground considerably.

Log

PR13127 1st Flight: https://review.px4.io/plot_app?log=72bcbcb2-0a47-487b-9ee5-b51c9ebc30ee
PR13127 2nd Flight: https://review.px4.io/plot_app?log=71dba018-52b6-4e8d-ad7f-00a867a5bdf0

Which master firmware were you running as reference?

Master used was latest form QGC the 12th of December 2019, commit: 9b66cbd2

@Junkim3DR Thank you very much!
@mhkabir @dagar  Together with @priseborough we tracked down the issue in the first test flights to extensively filtered baro data on the vehicle_air_data. On my test platform and in the newest log files on the NXP FMUK66 platform the baro data seems to be noisy as expected and the weird behavior during landing caused by bad vertical estimates is not noticeable.
I argue that it is okay to merge this now. LGTM!!!! (Reminder: ECL PR has to go first: https://github.com/PX4/ecl/pull/668)

I've checked the logs from Mexico testers who were using the standard GPS sensor fit and daa looked OK.


Error installing MMSplice

MMSplice version: 1.0.3
Python version: 3.5.1
Operating System: RHEL 7.4

I'm trying to install MMSplice. I run the commands:
pip install cyvcf2 cython
pip install mmsplice

I get this error:
ImportError: libstdc++.so.6: cannot open shared object file: No such file or directory

There are two options:

Try to install cyvcf2 cython from conda with conda install cyvcf2 cython.
pip install cython  then follow solution in the link https://stackoverflow.com/questions/11471722/libstdc-so-6-cannot-open-shared-object-file-no-such-file-or-directory

Dear @dglemos,
Have you solved your problem? If so, I will close the issue.

Hello Muhammed,
The problem persists due to permission issues. Feel free to close the issue though seeing as it's a problem on my side.
Thank you for your help.


Clearly separate autocomplete tags in lens dropdown

It's confusing why some tags would show up in the drop down and some wouldn't since right now everything's just mixed.
It'd be nice if we could split the list in 2 sections and move the autocomplete tags to the 2nd. With ideally a title that explains that only some whitelisted tags are there and they can use the generic "tags" search for everything else.

This is @tacigar's  comment on what'd be needed:

I use react-select(https://github.com/jedwatson/react-select) to implement global-search component. (Please see https://github.com/openzipkin/zipkin/blob/7ac793e1261c4e03b1f1066cf9718c6c7c740d18/zipkin-lens/src/components/GlobalSearch/SearchCondition.js#L132-L169)
This component library is not very extensible.
So I think it is hard to add separator and descriptions to the dropdown as long as we use it.
It seems that we need to throw away react-select and create similar component ourself…
But it is a bit hard...

I agree that for existing sites, they may be confused about which properties of the span are by default searchable. If we want to optimize for this, we could have a separate element for tags including predefined keys or blank to enter your own. Remember also that predefined should one day include standard tags that we don't auto-complete values for! ex antennae-id or request id.
on hover it could say how to control this.

what if tags had a tag: or tag. prefix? not necessarily elegant but it
could reduce confusion perhaps. other data are top level
On Thu, Apr 4, 2019, 7:45 AM Daniele<EMAIL_ADDRESS>wrote:

This is @tacigar https://github.com/tacigar's comment on what'd be
needed:
I use react-select(https://github.com/jedwatson/react-select) to
implement global-search component. (Please see
https://github.com/openzipkin/zipkin/blob/7ac793e1261c4e03b1f1066cf9718c6c7c740d18/zipkin-lens/src/components/GlobalSearch/SearchCondition.js#L132-L169
)
This component library is not very extensible.
So I think it is hard to add separator and descriptions to the dropdown as
long as we use it.
It seems that we need to throw away react-select and create similar
component ourself…
But it is a bit hard...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2485#issuecomment-479697515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611-Hu8bcQtt_S7J8XXvYqE2ah2L1ks5vdT0bgaJpZM4cbpaG
.

I mean ex duration is really span.duration and name is span.name tag is
span.tags.foo
possibly namespacing could clarify, skipping the span. part
On Thu, Apr 4, 2019, 8:47 AM Adrian Cole<EMAIL_ADDRESS>wrote:

what if tags had a tag: or tag. prefix? not necessarily elegant but it
could reduce confusion perhaps. other data are top level
On Thu, Apr 4, 2019, 7:45 AM Daniele<EMAIL_ADDRESS>wrote:

This is @tacigar https://github.com/tacigar's comment on what'd be
needed:
I use react-select(https://github.com/jedwatson/react-select) to
implement global-search component. (Please see
https://github.com/openzipkin/zipkin/blob/7ac793e1261c4e03b1f1066cf9718c6c7c740d18/zipkin-lens/src/components/GlobalSearch/SearchCondition.js#L132-L169
)
This component library is not very extensible.
So I think it is hard to add separator and descriptions to the dropdown
as long as we use it.
It seems that we need to throw away react-select and create similar
component ourself…
But it is a bit hard...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2485#issuecomment-479697515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611-Hu8bcQtt_S7J8XXvYqE2ah2L1ks5vdT0bgaJpZM4cbpaG
.

I think haystack doesn't have this problem because you cannot search on and
hoc values iirc
On Thu, Apr 4, 2019, 8:49 AM Adrian Cole<EMAIL_ADDRESS>wrote:

I mean ex duration is really span.duration and name is span.name tag is
span.tags.foo
possibly namespacing could clarify, skipping the span. part
On Thu, Apr 4, 2019, 8:47 AM Adrian Cole<EMAIL_ADDRESS>wrote:

what if tags had a tag: or tag. prefix? not necessarily elegant but it
could reduce confusion perhaps. other data are top level
On Thu, Apr 4, 2019, 7:45 AM Daniele<EMAIL_ADDRESS>wrote:

This is @tacigar https://github.com/tacigar's comment on what'd be
needed:
I use react-select(https://github.com/jedwatson/react-select) to
implement global-search component. (Please see
https://github.com/openzipkin/zipkin/blob/7ac793e1261c4e03b1f1066cf9718c6c7c740d18/zipkin-lens/src/components/GlobalSearch/SearchCondition.js#L132-L169
)
This component library is not very extensible.
So I think it is hard to add separator and descriptions to the dropdown
as long as we use it.
It seems that we need to throw away react-select and create similar
component ourself…
But it is a bit hard...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2485#issuecomment-479697515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611-Hu8bcQtt_S7J8XXvYqE2ah2L1ks5vdT0bgaJpZM4cbpaG
.


Method overloads based on same set of static method params

How do I add overloads based on same set of method static parameters?
Let's say I want ExampleMethWithStaticParam accept either int or float
https://github.com/fsharp/FSharpLangDesign/blob/master/FSharp-4.0/StaticMethodArgumentsDesignAndSpec.md
let x = ExampleType()

let v1int = x.ExampleMethWithStaticParam<1>(1)

//???
let v1float = x.ExampleMethWithStaticParam<1>(1.1)

//cc @dsyme @KevinRansom

As discussed on twitter, this can't be done (it would be an F# language feature request, though in truth  I don't think we would add support for this)


Introduce static code analysis

Is your feature request related to a problem? Please describe.
A static code analyser can find probable bugs in the code based on common patterns.
Describe the solution you'd like
Some static code analyser should integrated into the QA workflow.
Describe alternatives you've considered

Spotbugs

easy integration into maven

SonarCube

harder to setup at the first glance
product of SonarSource; also has a community edition
seems to support Kotlin as well

SonarCube looks like it is a sophisticated enterprise-level solution that requires a server running somewhere. It provides deep insights into the code, looks beautiful, and provides a ranking of the issues and detailed explainations. However, due to the complexity it is probably not suitable for Merkompiler. Definitively keep this in the back of the head for later.

SpotBugs does not support Kotlin (yet).
Hence have a look at detekt, a static analyzer for Kotlin code.