Unable to fetch last commit of each repository

Hi
I am trying to fetch last commit of each repository using below query and I am getting message as 'Returned 0 rows (0.038 seconds)'. Could you please suggest what might be the issue.  I am querying using engine.
/* Last commit for each repository */
SELECT r.repository_id, commit_author_name, commit_author_when, commit_message
FROM   refs r
NATURAL JOIN commits
WHERE  r.ref_name = 'HEAD'

Hey @ayushi04 ,
Could you check the output of the following query? SELECT COUNT(*) from repositories
If the output is 0, you didn't point correctly to a folder with repositories. Check -d option for more info: https://docs.sourced.tech/gitbase/using-gitbase/configuration#command-line-arguments

yes. I am able to run other queries in engine.  I am getting repositories count as 7.

I tried to reproduce the error using gitbase versions v0.19.0-beta3 and v0.18.1 with no luck. I just copy&paste your query and everything is working as expected using a subset of 340 repositories to test.
Maybe the error could be related with the engine itself instead of gitbase? @carlosms could you help us?

Thanks for the quick response. I followed following steps:

Running the docker image : sudo docker run --rm --name gitbase -p 3306:3306 -v /mnt/virtual_space/lp_mlrepo:/opt/repos srcd/gitbase:latest
starting the MySQL server : MySQL -q -u root -h <IP_ADDRESS>
My sql logs are :
mysql> select * from repositories limit 10;
+---------------+
| repository_id |
+---------------+
| 51ab4eef0925540772d4474d40f33274aafe30f0.siva |
| 54f420159013a9dc81188cdb21799eaaabf822e7.siva |

mysql> SELECT r.repository_id, commit_author_name, commit_author_when, commit_message
-> FROM refs r
-> NATURAL JOIN commits
-> WHERE r.ref_name = 'HEAD';
+---------------+--------------------+--------------------+----------------+
| repository_id | commit_author_name | commit_author_when | commit_message |
+---------------+--------------------+--------------------+----------------+
+---------------+--------------------+--------------------+----------------+
The repository list which I downloaded using below pga command:
pga get -u /lazyprogrammer/ -l python -o lp_mlrepo
Could you please recreate this example and check once. Thanks for the help

Now I see why you are not getting any HEAD. Rooted repositories (repositories that are inside the siva files) have no HEAD because they are storing several standard repositories. To be able to get all the HEADS from one rooted repo, you need to do something like:
SELECT
	refs.ref_name,
	r.repository_id,
	commit_author_name,
	commit_author_when,
	commit_message
FROM refs r
NATURAL JOIN commits
WHERE substring(r.ref_name,1,15) = 'refs/heads/HEAD';

Yes. That worked. Thanks a lot for the help.


perf: short-circuit all antiquotation parsers

Another ~13% speedup on my machine (after update-stage0 for the parser! change)
perf diff:
     3.87%     -2.77%  parser.lean.out     [.] lean_apply_2
     1.03%     -1.01%  parser.lean.out     [.] l_Lean_Parser_dollarSymbol___elambda__1
    13.83%     +1.00%  parser.lean.out     [.] lean_alloc_small
     4.47%     +0.89%  parser.lean.out     [.] l_RBNode_find___main___at___private_Init_Lean_Data_Trie_5__matchPrefixAux___main___spec__1___rarg
    13.59%     +0.88%  parser.lean.out     [.] lean_del
     1.35%     -0.85%  parser.lean.out     [.] l_Lean_Parser_mergeOrElseErrors
     2.45%     -0.77%  parser.lean.out     [.] l_Lean_Parser_tokenFn
     3.06%     +0.54%  parser.lean.out     [.] l_Lean_Syntax_mreplace___main___at_Lean_Syntax_updateLeading___spec__1
     2.20%     +0.51%  parser.lean.out     [.] l___private_Init_Lean_Data_Trie_5__matchPrefixAux___main___rarg

Ah, the diff doesn't look very impressive because functions that do not occur in capture in any snapshots in the newer executable are listed at the bottom
     1.33%             parser.lean.out     [.] l_Lean_Parser_setExpectedFn___rarg
     0.67%             parser.lean.out     [.] l_Lean_Parser_tryFn
     0.34%             parser.lean.out     [.] l_Lean_Parser_mkAntiquot___elambda__2
     0.30%             parser.lean.out     [.] l___private_Init_Lean_Parser_Parser_16__isDollar

Nice!

Speedcenter says -13% on Core.lean but +38% on compilation :scream: http://speedcenter.informatik.kit.edu/lean/changes/?tre=10&rev=933ff6dc88795cf9df9bd8bf49545919b4219053&exe=37&env=2

The problem is the code explosion produced by withAntiquot. We got 100k new lines of code.
I rewrote it as:
def tryAnti (c : ParserContext) (s : ParserState) : Bool :=
let (s, stx?) := peekToken c s;
match stx? with
| some stx@(Syntax.atom _ sym) => sym == "$"
| _                            => false

@[inline] def withAntiquotFn (antiquotP p : ParserFn) : ParserFn :=
fun c s => if tryAnti c s then orelseFn antiquotP p c s else p c s

I think it fixes the code overhead and preserves the perf improvement.

Results are in! http://speedcenter.informatik.kit.edu/lean/changes/?tre=10&rev=7e959f83933fd2a88f8aceb9546860b12830d316&exe=37&env=2
=> reduced to 7% compilation overhead, nice

There probably is just a handful of parser!s where this actually matters and for all others it's just compilation overhead, but finding those...


Hide SSH button when SSH is disabled

Hide SSH button when SSH is disabled

Does this not also require changes to the following lines in templates/repo/bare.tmpl
git remote add origin {{if $.DisableSSH}}{{.CloneLink.HTTPS}}{{else}}{{.CloneLink.SSH}}{{end}}

and

git remote add origin {{if $.DisableSSH}}{{.CloneLink.HTTPS}}{{else}}{{.CloneLink.SSH}}{{end}}

I also found I had to remove the following from public/ng/css/gogs.css to correctly align the copy button when displaying the new repo page. This appears to have no effect on the clone drop down on the existing repos.
.repo-bare #repo-clone-copy {
  /*margin-right: 200px;*/
}

Any new idea? @linquize @d-fens ? Should I merge this pr?


Fix the needs Rake task authenticating with the Publishing API

We were instantitating a new one without a token and it was working
fine in dev, but it failed on Integration, so use the already set up
Services.publishing_api for it, adjusting the timeout option as before.

You'll need to add the new link type to the schemas too. Links are actually validated in the publishing-api, but just raise errors to errbit at the moment.

@tijmenb Thanks. Done in https://github.com/alphagov/govuk-content-schemas/pull/457.


Proposed RFC Feature : Console Only Game Launchers for Simulations

Summary
This RFC proposes introducing the ability to the game launcher to launch in console mode only without the creation of a native window. Currently, the only launchers that can do this are the server and headless server launchers. The feature to support console-only game launchers is useful for simulation use cases since the native client windows is typically used just to provide visualization of the scene and is not used directly by any ROS2 sensor.
What is the relevance of this feature?
The general use case for not creating a native client window when launching the game launcher is primarily useful for simulation scenarios. This has little or no value for gaming scenarios. Currently for simulation projects, the client window that is created provides a view based on a camera that is configured in the simulation scene being launched. The camera may or may not be tied directly to the simulation target (ie robot), and may just provide a view of the scene to provide photo-realistic view of the simulation in general. (In many cases, the camera view can be changed using the same mechanisms as games do).
There are scenarios where the client window is not needed all, mostly in cases where automation or CI/CD pipelines are used to validate robot code. Furthermore, the O3DE Atom renderer may or not be needed for simulation use cases that do not O3DE's high-quality visualizations at all and thus needing to only rely on the simulations Physics and non-camera ROS2 sensors. The renderer will be needed for scenarios where there are sensors that utilize the ROS2 camera sensor even if the client window is not necessary.
Feature design description
Window-less clients will still launch with rendering capabilities enabled, but will not launch any native client window to show the game/simulation scene based on its camera view. The renderer will still be available to support features like the ROS2 Gem's camera sensor implementation. The underlying RHI will be initialized based on the current platform and hardware (DX12, Vulkan, etc), which means that it will still require video and graphics drivers to be available. The control of optionally creating the client window will be configured through the use of the settings registry.
Examples
Launching GameLauncher with Native Windows creation
Robot Manipulator
https://github.com/o3de/sig-simulation/assets/82231385/c10732da-cfd6-4b44-8042-9efa41309ba9
Robot Vacuum
https://github.com/o3de/sig-simulation/assets/82231385/6c4cdefb-06ef-406e-89e2-d117dafdadfa
Launching GameLauncher without Native Windows
Robot Manipulator
https://github.com/o3de/sig-simulation/assets/82231385/5a469a33-5290-4bd0-adfd-445c3efaceba
Robot Vacuum
https://github.com/o3de/sig-simulation/assets/82231385/ad6cd9f3-aa9a-4787-80d9-b730c053ec84
Technical design description
Client window creation control
Settings Registry
The control to create the client window in the client launcher will be controlled by the following settings registry key
/O3DE/Atom/Bootstrap/CreateNativeWindow

This key can be applied on a per-project case by providing a bootstrap.setreg file in the project's Registry subfolder. For example:
{
  "O3DE": {
    "Atom": {
      "Bootstrap": {
        "CreateNativeWindow": false
      }
    }
  }
}

The default behavior of CreateNativeWindow will be true.
Atom Bootstrap
The creation of the native client window is triggered in the BootstrapSystemComponent.cpp in the Atom gem. In addition to the check for the appType's IsHeadless() attribute, the component will also read the settings registry key value for CreateNativeWindow and use this flag to also determine if m_nativeWindow is created or not.
What are the advantages of the feature?

Allows simulation clients to run on a non-graphics intensive environment (headless)
Allows simulation clients to run on headless, server only operating systems
Provides option to not show a client window on the launcher when not needed
Disabling the main render pipeline that is used by the client will reduce the memory and resources used by the simulations that employs rendering from the ROS2 camera sensor.

What are the disadvantages of the feature?

On Linux, the X11 and graphical drivers (i.e. Vulkan display driver, etc) will still be a system pre-requisite. This is due to the library dependencies on the XCB/X11 on this platform, even if the null renderer is set.

How will this be implemented or integrated into the O3DE environment?
The changes needed will be backwards compatible with the current version of O3DE.

By default, if the /O3DE/Atom/Bootstrap/CreateNativeWindow is not set in the settings registry, the default behavior will create the client window for client launchers.

Are there any alternatives to this feature?
This is partially supported currently by setting the rhi argument to null that can be passed into the launcher. However, this does not prevent the creation of a client window, it only disables the loading and initialization of the backend Atom RHI.
How will users learn this feature?
This will be added to the o3de documentation, specifically the for the simulation and ROS2 specific topics.
Are there any open questions?
TBD

There is a use case still of using the Vulkan rendered for ROS2 camera sensors while still not creating a window. But we should also disable the client creation if null renderer is specified anyways.

Excellent RFC, this is very much needed for simulations, in CI/CD there is no need for client window. I also support @akioCL questions.

Is there any use case of creating the window when using the null renderer? Maybe we should skip window creation when the null renderer is being used.
Also, should we make the option of "CreateNativeWindow" a command line argument?

I agree, those are great ideas. I'll update the RFC

Minor updates

I am closing the issue: PRs are merged/ready.


Options ?

Hello, thank, great little tool !
I would like to use options like :
ffplay -autoexit -nodisp hello.wav
that is possible with node-ffplay ?
I dont find more documentation...
thanks

Done! You can check the README file for usage <3

Cool, thanks for the documentation/instructions...
Am not sure -autoexit -nodisp by default is a great thing ;)
There is an option to enable display (like -yesdisp) ?
Thanks, am searching (and kiding) ;)
I try to use ffplay has a playlist player + random
(right now am using m3u... not realy flexible)


Bluetooth: Controller: Restarting periodic advertising causes crash when ADV_SYNC_PDU_BACK2BACK=y

Describe the bug
Stopping and then starting periodic advertising causes an assert here: https://github.com/zephyrproject-rtos/zephyr/blob/0612dd433d77bf2aee899170ea1efd491f325540/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_sync.c#L345
ASSERTION FAIL [pdu] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_sync.c:345
Crash happens when using chained periodic advertising:
CONFIG_BT_CTLR_ADV_SYNC_PDU_BACK2BACK=y
CONFIG_BT_CTLR_DF_PER_ADV_CTE_NUM_MAX=5

What target platform are you using? nRF52833, Zephyr
Is this a regression? Same issue on Zephyr version used in nRF Connect 2.0

To Reproduce
My code does this and you should be able to reproduce by adding this to the end of main in https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/bluetooth/direction_finding_connectionless_tx:
    __ASSERT_NO_MSG(0 == bt_le_per_adv_stop(adv_set));
    __ASSERT_NO_MSG(0 == bt_le_ext_adv_stop(adv_set));
    struct bt_le_per_adv_param per_adv_param = {
        .interval_min = minAdvInterval,
        .interval_max = maxAdvInterval,
        .options = BT_LE_ADV_OPT_USE_TX_POWER,
    };
    int err = bt_le_per_adv_set_param(adv_set, &per_adv_param);
    if (err) {
        LOG_ERR("failed (err %d)\n", err);
        return;
    }
    LOG_INF("Periodic advertising enable...");
    int err = bt_le_per_adv_start(adv_set);
    if (err) {
        LOG_ERR("failed (err %d)\n", err);
        return;
    }
    LOG_INF("success\n");

    LOG_INF("Extended advertising enable...");
    err = bt_le_ext_adv_start(adv_set, &ext_adv_start_param);
    if (err) {
        LOG_ERR("failed (err %d)\n", err);
        return;
    }
    LOG_INF("success\n");

Expected behavior
No crash.
Impact
Cannot stop/start or change periodic adv. interval. when chained periodic adv. is used.
Logs and console output
<inf> app: Bluetooth initialized
<inf> app: Setting TxPower: 4
<inf> app: Set Tx Power: 4
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Set ext adv data...
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Update CTE params...
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Periodic advertising params set...
<inf> app: Started blink thread
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Enable CTE...
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Periodic advertising enable...
<inf> bt_adv_aoa: success

<inf> bt_adv_aoa: Extended advertising enable...
<inf> bt_adv_aoa: success

<inf> app: Pressed button => Change adv. interval
<inf> app: New interval: 1 => 100
<inf> bt_adv_aoa: Adv stopped
<inf> bt_adv_aoa: success
<inf> bt_adv_aoa: Periodic advertising enable...
<inf> bt_adv_aoa: success
<inf> bt_adv_aoa: Extended advertising enable...
<inf> bt_adv_aoa: success
ASSERTION FAIL [pdu] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_sync.c:34

Environment (please complete the following information):

OS: Windows
Toolchain: Zephyr
Commit SHA or Version used: 894423e9aed34a394b97c995c33549513b0ac4a5

@jakkra Thank once again with the easy to reproduce steps. Please verify the fix in #49856 and revert back with the results.

@cvinayak Thanks for the quick fix, not crashing anymore with https://github.com/zephyrproject-rtos/zephyr/pull/49856


Facing issue during use of ZIP deploy and Run from zip

Hi,
I am using zip deploy method to deploy code on WebApp. But sometimes we are facing issue file missing issue on zip deploy as result server is not working.
Same as Run from zip we are facing permission issue. sometime we are not able to edit files under wwwroot.
Someone please suggest if any solution for this?
Previously we were using WebDeploy but We are deploying nodeJs+Angular(Webpack) application so we have to deploy node_modules on server so it's taking more than one hours. It is trying to delete every individual files and trying to upload it again.

@harsh-argusoft RunFromZip makes file structure under wwwroot ReadOnly by design. If you want to edit something after deployment you should use ZipDeploy.
As for the issue with ZipDeploy, it removes previous files with every deployment. Are you using two Release Definitions to deploy (for instance one for Core app, another for dependencies)? If yes, that might be causing file missing issue.
Can you share debug logs for the task and release logs at<EMAIL_ADDRESS>for further investigation?

Hey @SumiranAgg ,
We are using a single pipeline and deploying directly to production slot. Faced with this issue yesterday again where index.html and web.config were missing. I have shared the debug logs on the above-mentioned email address. Thanks.

If you see the issue again, check the manifest file for latest deployment (You can find the link in debug log) for the missing files.
If the entries are missing, share that manifest file with us.
Closing the issue until details are shared for further investigation. Pleas re-open if required.


[WIP] Story of Layout feature

A PR to show my progress on working on this feature.
Dependency:

Flutter framework change:
https://github.com/albertusangga/flutter/pull/2

Very early prototype on showing Constraints next to the Widget:

Check-in #2:

Rename Show Constraints button to Layout button (change term of showConstraints to debugLayoutModeEnabled)
Change color from red to yellow (Dangerous to Warning, since we are unsure whether it's really an error)
Highlight children that got unconstrained by its parents (highlight the contraints text)
Highlight the parent widget name that unconstrained its child
Show fade-in/fade-out animation when Debug Layout mode

Check-in 3:

Made very early prototype on explaining Flex layouting (the feature for now will be temporarily called 'Story of Your Flex Widget')
Visualizing Flex and able to detect the Flex type (Row/Column)
Displaying correct amount of children and all of the children's widget name
All children is still equally weighted for this check in

Check in 4:

Avoid using hardcoded color and instead use Color from Theme (to support Light/Dark theme)
Remove hack in InspectorTree node
Remove wrong import
Rename 'Story of your Flex widget' to 'Story of the layout of your Row/Column widget'

Screenshots:

Check in 5:
Changelist:

Create proper deserializer method for flex properties from DiagnosticsNode
Create new flag (isExperimentalStoryOfLayoutEnabled) in InspectorTreeFlutterController to prevent showing all this features changes until my PR (github.com/albertusangga/flutter/pull/2) is landed to Flutter main repository
Inspector details tree now live inside of Tabs! User can focus on layout details instead if they want to.
Removed animation from DianogsticsNodeDescriptions for now (due to minor performance concerns and adding new flag, might add it later!)
Changed hardcoded constants for Buttons in InspectorScreen to prevent button groups expanding to two lines

Screenshots:

Inspector screen have tabs now!

TODOs:

Remove // constraints word from ConstraintsDescriptor
Highlight only unconstrained word in the ConstraintsDescriptor
Move StoryOfYourFlexWidget from Dialog to Tab


Research Google Maps API to get location info of Cafe

Approach will be to use maps embed with iframes instead.


is sorting by an associated column supported?

Given this AR model set:
class Sandwich < ActiveRecord::Base
  has_many toppings
  include OrderQuery
end

# has a name attribute
class Toppings < ActiveRecord::Base
end

Could you order by the associated column, Topping.name?
I have not had luck with this.  It appears that the order clause prepends the base model's table name, unless you pass a sql option with the raw value:
# fails, tries to do "sandwich.toppings.name"
point = Sandwich.include(:toppings).joins(:toppings).seek(*[[:"toppings.name", :desc]])

# works, I suppose the first arg is ignored since the has is passed in as a 3rd arg
point = Sandwich.include(:toppings).joins(:toppings).seek(*[[:"toppings.name", :desc, {:sql=>'toppings.name'} ]])

However, calling point.after above throws an error:
undefined method `toppings.name' for #<Sandwich:00x00...>

What do you want to achieve? It's a has_many association, so which one of the many do you want it to sort by? Max? Lexicographic?

Apologies, I probably should have used a has_one in the example.  Thus it would be a one-to-one join of two tables, sorting by a field in the second table.

For the has_one case this should be sufficient:
point = Sandwich.joins(:topping).seek([:topping_name, :desc, sql: 'toppings.name'])

class Sandwich < ...
  def topping_name
    topping.name
  end
end

@glebm does calling after on that point work for you?

The result of that is not really a point but a Space. You need to call at to get a Point.

Apologies for the delay. Indeed, once I get a Point, calling after on it is where I get the error.  I've created a rails spec gist to replicate the error.
The spec creates models Company and Employee, the latter is a has_one association of the former.  The spec is designed to connect to a mysql database via these environment variables:

DB_HOST
DB_USERNAME
DB_PASSWORD
DB_NAME
optional: DB_PORT (defaults to 3306)

The test will create the database, create the table structure, then seed the data with a few records: two Employee records, each with a Contract associated with it.
This is the result of the test I'm encountering:

  1) OrderQuery search sort on secondary join table can fetch 'next' on a Employee point when sorting by contract.contract_type
     Failure/Error: record = space.at(Employee.first).after(false).limit(1)

     NoMethodError:
       undefined method `contract_type' for #<Employee id: 1, name: "John", email<EMAIL_ADDRESS>       Did you mean?  contract
     # ./spec/association_spec.rb:145:in `block (4 levels) in <top (required)>'

Finished in 2.91 seconds (files took 0.89039 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/association_spec.rb:141 # OrderQuery search sort on secondary join table can fetch 'next' on a Employee point when sorting by contract.contract_type

I feel like I must be doing something wrong.  Help is appreciated!

Closing as it's old. In case you still need help, consider StackOverflow.

@glebm were you not able to replicate the problem with the gist I created?

I've had a look at your gist works if you simply:

Pass the correct arguments to order_query
-space = Employee.joins(:contract).seek([:contract_type, :desc, "contract.contract_type"])
+space = Employee.joins(:contract).seek([:contract_type, :desc, sql: "contract.contract_type"])

Define the contract_type method on Employee:
delegate :contract_type, to: :contract

Hi @glebm , I apologize for not responding to this sooner. I re-reviewed this today and now understand your approach, have been able to reproduce it locally.  Thanks again for your help!


Credential issues still continue after #123

The credentials issue is not fully resolved in #123
Comments are not left by GHPRB in the PRs being tested even though the appropriate global configuration is set. The GitHub status API updates complete successfully though.
Jun 29, 2015 4:30:29 PM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Got payload event: issue_comment
Jun 29, 2015 4:30:29 PM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context (null)
Jun 29, 2015 4:30:29 PM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Checking issue comment 'org.kohsuke.github.GHIssueComment@5dcd4aef' for repo cschcs/kesem
Jun 29, 2015 4:30:29 PM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #2 from User:arcivanov: test this please
Jun 29, 2015 4:30:29 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Retest phrase
Jun 29, 2015 4:30:29 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Admin User:arcivanov gave retest phrase
Jun 29, 2015 4:30:30 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jun 29, 2015 4:30:30 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jun 29, 2015 4:30:30 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...
Jun 29, 2015 4:30:30 PM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Got payload event: issue_comment
Jun 29, 2015 4:30:30 PM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context (null)
Jun 29, 2015 4:30:31 PM SEVERE org.jenkinsci.plugins.ghprb.GhprbGitHubAuth getBuilder
Failed to look up credentials for context (null) using id: 2c6f0a56-02f2-4082-88ca-143fa817b765
Jun 29, 2015 4:30:31 PM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Got payload event: issue_comment
Jun 29, 2015 4:30:31 PM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context (null)
Jun 29, 2015 4:31:00 PM FINE org.jenkinsci.plugins.ghprb.GhprbTrigger
Use webHooks is set, so not running trigger

Would you be able to run a rogue build?  I have a thought for where it might be failing in the lookup.

Totally!

If you would please get the same log.  The context shouldn't be (null).

Will do. Please standby.
From: David Tanner <notifications<EMAIL_ADDRESS>Reply-To: jenkinsci/ghprb-plugin <reply<EMAIL_ADDRESS>Date: Wednesday, July 1, 2015 at 22:24
To: jenkinsci/ghprb-plugin <ghprb-plugin<EMAIL_ADDRESS>Cc: Arcadiy Ivanov <arcadiy<EMAIL_ADDRESS>Subject: Re: [ghprb-plugin] Credential issues still continue after #123 (#124)
If you would please get the same log. The context shouldn't be (null).

Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/ghprb-plugin/issues/124#issuecomment-117878082.
This is a PRIVATE message. If you are not the intended recipient, please delete without copying and kindly advise us by e-mail of the mistake in delivery. NOTE: Regardless of content, this e-mail shall not operate to bind CSC to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose.

The null context is gone. This appeared:
Jul 02, 2015 2:37:44 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbGitHubAuth getBuilder
Failed to look up credentials for context Koji Job Generator (PR) using id: 2c6f0a56-02f2-4082-88ca-143fa817b765
This wasn't there before and this job is definitely accessible (verified with Github web access for those credentials).
From: David Tanner <notifications<EMAIL_ADDRESS>Reply-To: jenkinsci/ghprb-plugin <reply<EMAIL_ADDRESS>Date: Wednesday, July 1, 2015 at 22:24
To: jenkinsci/ghprb-plugin <ghprb-plugin<EMAIL_ADDRESS>Cc: Arcadiy Ivanov <arcadiy<EMAIL_ADDRESS>Subject: Re: [ghprb-plugin] Credential issues still continue after #123 (#124)
If you would please get the same log. The context shouldn't be (null).

Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/ghprb-plugin/issues/124#issuecomment-117878082.
This is a PRIVATE message. If you are not the intended recipient, please delete without copying and kindly advise us by e-mail of the mistake in delivery. NOTE: Regardless of content, this e-mail shall not operate to bind CSC to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose.

Still no comments on the PR being built.
From: Arcadiy Ivanov <arcadiy<EMAIL_ADDRESS>Date: Wednesday, July 1, 2015 at 22:41
To: jenkinsci/ghprb-plugin <reply<EMAIL_ADDRESS>jenkinsci/ghprb-plugin <ghprb-plugin<EMAIL_ADDRESS>Subject: Re: [ghprb-plugin] Credential issues still continue after #123 (#124)
The null context is gone. This appeared:
Jul 02, 2015 2:37:44 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbGitHubAuth getBuilder
Failed to look up credentials for context Koji Job Generator (PR) using id: 2c6f0a56-02f2-4082-88ca-143fa817b765
This wasn't there before and this job is definitely accessible (verified with Github web access for those credentials).
From: David Tanner <notifications<EMAIL_ADDRESS>Reply-To: jenkinsci/ghprb-plugin <reply<EMAIL_ADDRESS>Date: Wednesday, July 1, 2015 at 22:24
To: jenkinsci/ghprb-plugin <ghprb-plugin<EMAIL_ADDRESS>Cc: Arcadiy Ivanov <arcadiy<EMAIL_ADDRESS>Subject: Re: [ghprb-plugin] Credential issues still continue after #123 (#124)
If you would please get the same log. The context shouldn't be (null).

Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/ghprb-plugin/issues/124#issuecomment-117878082.
This is a PRIVATE message. If you are not the intended recipient, please delete without copying and kindly advise us by e-mail of the mistake in delivery. NOTE: Regardless of content, this e-mail shall not operate to bind CSC to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose.

If you try testing it again from the main configuration page, does it connect successfully?

From main config page all appears to be in order:
Test Credentials
Connect to API
Connected to https://api.github.com as
Repository owner/name
ServiceMesh/koji-jenkins-dsl
Check repo permissions
User has access to: Push, Pull

Test Credentials
Connect to API
Connected to https://api.github.com as
Repository owner/name
cschcs/kesem
Check repo permissions
User has access to: Admin, Push, Pull

Found this in startup logs though:
Jul 02, 2015 2:33:25 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository initGhRepository
Could not retrieve GitHub repository named ServiceMesh/koji-jenkins-dsl (Do you have properly set 'GitHub project' field in job configuration?)
java.io.FileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}
	at org.kohsuke.github.Requester.handleApiError(Requester.java:494)
	at org.kohsuke.github.Requester._to(Requester.java:245)
	at org.kohsuke.github.Requester.to(Requester.java:191)
	at org.kohsuke.github.GitHub.getRepository(GitHub.java:321)
	at org.jenkinsci.plugins.ghprb.GhprbRepository.initGhRepository(GhprbRepository.java:78)
	at org.jenkinsci.plugins.ghprb.GhprbRepository.init(GhprbRepository.java:51)
	at org.jenkinsci.plugins.ghprb.Ghprb.init(Ghprb.java:105)
	at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:170)
	at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:51)
	at hudson.model.AbstractProject.onLoad(AbstractProject.java:326)
	at hudson.model.Project.onLoad(Project.java:98)
	at hudson.model.Items.load(Items.java:320)
	at jenkins.model.Jenkins$17.run(Jenkins.java:2651)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:904)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/ServiceMesh/koji-jenkins-dsl
	at sun.reflect.GeneratedConstructorAccessor54.newInstance(Unknown Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1889)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1884)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1883)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1456)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1440)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
	at org.kohsuke.github.Requester.parse(Requester.java:451)
	at org.kohsuke.github.Requester._to(Requester.java:224)
	... 19 more
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/ServiceMesh/koji-jenkins-dsl
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1835)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1440)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:338)
	at org.kohsuke.github.Requester.parse(Requester.java:447)
	... 20 more

Maybe cranking up logging on commenting would help?

What does the domain information for the credentials look like?  Does it have the correct scheme, host, port, and path?

It's "Global credentials (unrestricted)", "secret text" with no domain information whatsoever. This is how new credential is registered when added from the main settings page.

I can't get my setup to do it.

Jenkins 1.609.1 ?

Security enabled. Security via OAuth to GitHub

the the logger, do you see the context text still?

Nope, I don't see the context (null) anymore, but I see this:
Jul 02, 2015 2:37:44 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbGitHubAuth getBuilder
Failed to look up credentials for context Koji Job Generator (PR) using id: 2c6f0a56-02f2-4082-88ca-143fa817b765

and on cschcs/kesem the comments are not posted in the PR request even though main settings specify those to be posted.

I wonder if the plugin should just forget about context?  Just use the jenkins instance.

If the credential is specified as Global there should not be any context used I would think.

Also could you add comments logging ad-nauseam, cause no comments are posted at all.

Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context HCS - Kesem - (PR) - (Autogen)
Jul 02, 2015 3:56:46 AM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Checking issue comment 'org.kohsuke.github.GHIssueComment@27f1ba1d' for repo cschcs/kesem
Jul 02, 2015 3:56:46 AM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #2 from User:arcivanov: test this please
Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Retest phrase
Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Admin User:arcivanov gave retest phrase
Jul 02, 2015 3:56:46 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2 was updated on cschcs/kesem at 7/2/15 3:56 AM by User:arcivanov
Jul 02, 2015 3:56:46 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2 was updated on repo cschcs/kesem but there aren't any new comments nor commits; that may mean that commit status was updated.
Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jul 02, 2015 3:56:46 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...

I just sent you another build with some more logging.

trying it already

seems like something didn't resolve in messages: "Looking up credentials for {0}, using context {1} for url {2}"

single quotes I guess tell it not to replace the number.  Redo

It should look like this
Jul 02, 2015 12:20:11 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Looking up credentials for d9535634-c7b0-46dc-b2dc-c57576ad9744, using context Testing for url https://api.github.com
Jul 02, 2015 12:20:21 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Found 1 credentials
Jul 02, 2015 12:20:21 AM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context Testing

Ah, so one nailed down:
Jul 02, 2015 4:25:48 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbGitHubAuth getBuilder
Failed to look up credentials for context Koji Job Generator (PR) using id: 2c6f0a56-02f2-4082-88ca-143fa817b765
Jul 02, 2015 4:25:48 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository initGhRepository
Could not retrieve GitHub repository named ServiceMesh/koji-jenkins-dsl (Do you have properly set 'GitHub project' field in job configuration?)
java.io.FileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}
...
Stopping the ghprb trigger for project Koji Job Generator (PR)
Jul 02, 2015 4:44:40 AM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger start
Starting the ghprb trigger for the Koji Job Generator (PR) job; newInstance is true
Jul 02, 2015 4:44:40 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Looking up credentials for 2d50728a-b29c-4b16-814b-0d6723e70beb, using context Koji Job Generator (PR) for url https://api.github.com
Jul 02, 2015 4:44:40 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Found 2 credentials
Jul 02, 2015 4:44:40 AM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context Koji Job Generator (PR)
Jul 02, 2015 4:44:40 AM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository createHook
Couldn't create web hook for repository ServiceMesh/koji-jenkins-dsl. Does the user (from global configuration) have admin rights to the repository?

Somehow "Koji Job Generator (PR)" had a credential UUID that was not default: 2c6f0a56-02f2-4082-88ca-143fa817b765 vs 2d50728a-b29c-4b16-814b-0d6723e70beb
Still no comments in PR being built:
Got payload event: issue_comment
Jul 02, 2015 4:49:43 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Looking up credentials for 2d50728a-b29c-4b16-814b-0d6723e70beb, using context HCS_-_Kesem_-_(PR)_-_(Autogen) for url https://api.github.com
Jul 02, 2015 4:49:43 AM FINE org.jenkinsci.plugins.ghprb.Ghprb
Found 2 credentials
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbGitHubAuth
Using OAuth token for context HCS - Kesem - (PR) - (Autogen)
Jul 02, 2015 4:49:43 AM INFO org.jenkinsci.plugins.ghprb.GhprbWebHook handleWebHook
Checking issue comment 'org.kohsuke.github.GHIssueComment@569e1b84' for repo cschcs/kesem
Jul 02, 2015 4:49:43 AM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #2 from User:arcivanov: test this please
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Retest phrase
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Admin User:arcivanov gave retest phrase
Jul 02, 2015 4:49:43 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2 was updated on cschcs/kesem at 7/2/15 4:49 AM by User:arcivanov
Jul 02, 2015 4:49:43 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #2 was updated on repo cschcs/kesem but there aren't any new comments nor commits; that may mean that commit status was updated.
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jul 02, 2015 4:49:43 AM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...

I have tried 1.24.5.
I have "Use comments to report intermediate phases: triggered et al" checked in Jenkins global config. No error messages appear in the Jenkins logs or in the build logs. No comments in the PR either.

So that setting is a little deceiving, it only is called if the status update fails. It is shown easiest using version an earlier version.
https://github.com/jenkinsci/ghprb-plugin/blob/ghprb-1.20.1/src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java#L166
In the later versions if the status updates fail, then the comment logic is called
https://github.com/jenkinsci/ghprb-plugin/blob/ghprb-1.24.5/src/main/java/org/jenkinsci/plugins/ghprb/GhprbBuilds.java
https://github.com/jenkinsci/ghprb-plugin/blob/ghprb-1.24.5/src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java#L170

What about default uncustomized build-success/build-failure comments? Same?

The build messages were always configured per job, with a global default when creating a new job.  The values that were there before should have been kept accross the update.

Should the default SUCCESS/FAIL comments be posted by default like in 1.23? I can't get GHPRB to comment on anything.

There is only a default if you add it.

I have the latest running on my own branch, and I do get the comments that I add for SUCCESS/FAIL.
https://github.com/DavidTanner/Testing/pull/12

Sorry, I didn't understand your message.  The default shouldn't be posted unless it is also on the job.  There have been several issues opened about not having anything posted to the comments.  The default appears if you select the option on the build.

by build I mean the job configuration.

I see. So that is a behavioral change from pre-1.24? Because there used to be default build success/failure comments and this change basically breaks automation that configures GHPRB.
There used to be defaults for Success and Failure comments with failures including last N lines of stdout logs. Now there is nothing apparently unless I configure.
Is there a reference for what variables expand in the messages?

Any environment variables available when the step runs will be expanded in the build message.  I can see adding a setting that will tell the plugin to use global values if local settings aren't present.
So yes, this does change default behavior.

Is there any way to dump build console output lines in the comment?

That is what the log lines except extension is for

Sorry, extension?

The extensions are in the drop down list at the end of the configuration section.  Things like build messages, log lines, commit status, etc.