Unknown error occurred when I try add SP601E

I am trying to add SP601E controller to my Home Assistant, but getting error after initialization
Version of the custom_component
0.2.2
Describe the bug
After adding device I have got error on initialization "Retrying setup: SP601E: Data Update failed"
Debug log

2022-12-17 16:16:08.964 DEBUG (MainThread) [custom_components.uniled] *** Setup UniLED BLE Device: 55:55:07:05:8A:6E: SP601E v1 - ({'device_class': 'ble', 'address': '55:55:07:05:8A:6E', 'model': 'SP601E'})
2022-12-17 16:16:08.964 DEBUG (MainThread) [custom_components.uniled.lib.classes] SP601E: Init Channel 0
2022-12-17 16:16:08.965 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Init BLE Device (Model: SP601E)
2022-12-17 16:16:08.965 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Set model SP601E
2022-12-17 16:16:08.965 DEBUG (MainThread) [custom_components.uniled.lib.classes] SP601E: Init Channel 1
2022-12-17 16:16:08.966 DEBUG (MainThread) [custom_components.uniled.lib.classes] SP601E: Init Channel 2
2022-12-17 16:16:08.966 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Update device (RSSI: -37) AdvertisementData(local_name='SP601E', manufacturer_data={20563: b'\x01\x01UU\x07\x05\x8an'}, service_uuids=['00001800-0000-1000-8000-00805f9b34fb', '00001801-0000-1000-8000-00805f9b34fb', '0000ffe0-0000-1000-8000-00805f9b34fb'], rssi=-37)
2022-12-17 16:16:08.967 DEBUG (MainThread) [custom_components.uniled.coordinator] SP601E: Update, entry state: ConfigEntryState.SETUP_IN_PROGRESS
2022-12-17 16:16:08.967 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Update
2022-12-17 16:16:08.967 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Connecting; RSSI: -37
2022-12-17 16:16:15.410 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Connected
2022-12-17 16:16:15.410 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Read Characteristic: 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 12): Vendor specific
2022-12-17 16:16:15.410 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Write Characteristic: 0000ffe1-0000-1000-8000-00805f9b34fb (Handle: 12): Vendor specific
2022-12-17 16:16:15.411 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Subscribe to notifications
2022-12-17 16:16:15.848 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Sending 1 command(s)
2022-12-17 16:16:15.849 DEBUG (MainThread) [custom_components.uniled.lib.ble_retry] SP601E: Starting retry loop
2022-12-17 16:16:15.849 DEBUG (MainThread) [custom_components.uniled.lib.ble_retry] SP601E: Attempt 1
2022-12-17 16:16:15.849 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Sending command: aa2f00
2022-12-17 16:16:16.140 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Awaiting status notification
2022-12-17 16:16:16.190 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Handle:12, notification data: 534301170f010100ff0a1e01ff000010010102ff
2022-12-17 16:16:16.433 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Handle:12, notification data:<PHONE_NUMBER>0a1e0000ff001000
2022-12-17 16:16:16.435 ERROR (MainThread) [root] A message handler raised an exception: can only concatenate tuple (not "bytearray") to tuple.
Traceback (most recent call last):
  File "src/dbus_fast/message_bus.py", line 796, in dbus_fast.message_bus.BaseMessageBus._process_message
  File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/manager.py", line 860, in _parse_msg
    on_value_changed(message.path, self_interface["Value"])
  File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 152, in on_value_changed
    callback(bytearray(value))
  File "/config/custom_components/uniled/lib/ble_device.py", line 200, in _notification_handler
    new_master_state = self._model.async_decode_notifications(
  File "/config/custom_components/uniled/lib/ble_banlanx1.py", line 147, in async_decode_notifications
    device.last_notification_data[5:] + data[5:]
TypeError: can only concatenate tuple (not "bytearray") to tuple

2022-12-17 16:16:18.142 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Timeout waiting for status notification
2022-12-17 16:16:18.143 DEBUG (MainThread) [custom_components.uniled.coordinator] Finished fetching SP601E data in 9.176 seconds (success: False)
2022-12-17 16:16:18.143 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Stop
2022-12-17 16:16:18.143 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Disconnecting from device
2022-12-17 16:16:18.151 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Stopped notifications from device
2022-12-17 16:16:20.119 DEBUG (MainThread) [custom_components.uniled.coordinator] Coordinator destroyed
2022-12-17 16:16:20.119 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] Device Destroyed
2022-12-17 16:16:20.120 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 2 Destroyed
2022-12-17 16:16:20.121 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 1 Destroyed
2022-12-17 16:16:20.121 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 0 Destroyed
2022-12-17 16:16:20.121 DEBUG (MainThread) [custom_components.uniled.coordinator] Coordinator destroyed
2022-12-17 16:16:20.122 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] Device Destroyed
2022-12-17 16:16:20.122 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 2 Destroyed
2022-12-17 16:16:20.122 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 1 Destroyed
2022-12-17 16:16:20.123 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 0 Destroyed
2022-12-17 16:16:20.123 DEBUG (MainThread) [custom_components.uniled.coordinator] Coordinator destroyed
2022-12-17 16:16:20.123 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] Device Destroyed
2022-12-17 16:16:20.124 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 2 Destroyed
2022-12-17 16:16:20.124 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 1 Destroyed
2022-12-17 16:16:20.124 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 0 Destroyed
2022-12-17 16:16:20.891 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Device disconnected (expected: True); RSSI: -37
2022-12-17 16:16:20.893 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Disconnected from device

Please download, install and test v0.2.3 Beta

With v0.2.3 I am getting another error:
'''
2022-12-18 11:48:02.753 DEBUG (MainThread) [custom_components.uniled.lib.ble_banlanx1] SP601E: Packet 2 - payload size: 8, payload so far: 23, message length: 23 (23)
2022-12-18 11:48:02.754 DEBUG (MainThread) [custom_components.uniled.lib.ble_banlanx1] SP601E: Good Status Message: 010100ff0a1e01ff000010010102ff0a1e0000ff001000
2022-12-18 11:48:02.754 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 1: Set Status: UNILEDStatus(power=True, mode=None, level=255, white=None, rgb=(255, 0, 0), rgb2=None, effect=1, fxtype=1, speed=10, length=30, direction=1, input=None, gain=16, chip_type=None, chip_order=0, segment_count=None, segment_length=None, extra={})
2022-12-18 11:48:02.754 DEBUG (MainThread) [custom_components.uniled.lib.classes] Channel 2: Set Status: UNILEDStatus(power=True, mode=None, level=255, white=None, rgb=(0, 255, 0), rgb2=None, effect=1, fxtype=1, speed=10, length=30, direction=0, input=None, gain=16, chip_type=None, chip_order=2, segment_count=None, segment_length=None, extra={})
2022-12-18 11:48:02.764 ERROR (MainThread) [root] A message handler raised an exception: bytearray index out of range.
Traceback (most recent call last):
File "src/dbus_fast/message_bus.py", line 796, in dbus_fast.message_bus.BaseMessageBus._process_message
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/manager.py", line 860, in _parse_msg
on_value_changed(message.path, self_interface["Value"])
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 152, in on_value_changed
callback(bytearray(value))
File "/config/custom_components/uniled/lib/ble_device.py", line 200, in _notification_handler
new_master_state = self._model.async_decode_notifications(
File "/config/custom_components/uniled/lib/ble_banlanx1.py", line 263, in async_decode_notifications
mode=data[23] if master_power else BANLANX1_MODE_OFF,
IndexError: bytearray index out of range
2022-12-18 11:48:04.460 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Timeout waiting for status notification
2022-12-18 11:48:04.461 DEBUG (MainThread) [custom_components.uniled.coordinator] Finished fetching SP601E data in 9.556 seconds (success: False)
2022-12-18 11:48:04.461 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Stop
2022-12-18 11:48:04.461 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Disconnecting from device
2022-12-18 11:48:05.478 DEBUG (MainThread) [custom_components.uniled.lib.ble_device] SP601E: Stopped notifications from device

When both channels are switched off, then initialization is successful. But when one of channels is switched on, then I am getting such error

I know what the issue is, for some reason your device is sending a status with one byte less than what my SP601E  does.
I'll post a fix shortly

Please download, install and test v0.2.4 Beta

It works fine now. Thanks a lot!


CMake project fails to load for Flutter Desktop

Steps to Reproduce

Create a project with --platforms=windows;
Open the windows directory in CLion or Visual Studio;
Configure the IDE to use Visual Studio's toolchain, and reload the CMake project.

Expected results:
It builds.
Actual results:
The CLion complains that the /wd"4100" has invalid numeric argument.
C:\Users\Perqin\AppData\Local\JetBrains\Toolbox\apps\CLion\ch-0\203.7148.70\bin\cmake\win\bin\cmake.exe -DCMAKE_BUILD_TYPE=Debug -G "CodeBlocks - NMake Makefiles" C:\Users\Perqin\Workspaces\wallpaper-mix\windows
-- The CXX compiler identification is MSVC 19.28.29910.0
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/bin/Hostx64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/bin/Hostx64/x64/cl.exe - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/Perqin/Workspaces/wallpaper-mix/build/windows

Cannot get compiler information:
	Compiler exited with error code 2: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\bin\Hostx64\x64\cl.exe" @C:\Users\Perqin\AppData\Local\Temp\response-file5558374812569702194 C:\Users\Perqin\AppData\Local\Temp\compiler-file9498359128234079483 | @response-file5558374812569702194=/TP -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP
	用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.28.29910 版
	版权所有(C) Microsoft Corporation。保留所有权利。

	all:
		@cd C:\Users\Perqin\Workspaces\wallpaper-mix\build\windows\flutter
		@set INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt
		@set LIB=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\lib\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64
		@set CL=
		@set _CL_=
		@set LINK=
		C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\bin\Hostx64\x64\cl.exe @<< C:\Users\Perqin\AppData\Local\Temp\compiler-file9498359128234079483
	/TP -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP<<

	cl /TP -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP
	cl: 命令行 error D8021 :无效的数值参数“/wd"4100"”

	Compiler exited with error code 2: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\bin\Hostx64\x64\cl.exe" @C:\Users\Perqin\AppData\Local\Temp\response-file15663675224215307081 C:\Users\Perqin\AppData\Local\Temp\compiler-file9498359128234079483 | @response-file15663675224215307081=/TP -DFLUTTER_PLUGIN_IMPL -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -Dfile_selector_windows_plugin_EXPORTS -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP
	用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.28.29910 版
	版权所有(C) Microsoft Corporation。保留所有权利。

	保留所有权利。

	all:
		@cd C:\Users\Perqin\Workspaces\wallpaper-mix\build\windows\runner
		@set INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt
		@set LIB=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\lib\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64
		@set CL=
		@set _CL_=
		@set LINK=
		C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\bin\Hostx64\x64\cl.exe @<< C:\Users\Perqin\AppData\Local\Temp\compiler-file9498359128234079483
	/TP -DNOMINMAX -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\.plugin_symlinks\file_selector_windows\windows\include /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP<<

	cl /TP -DNOMINMAX -DUNICODE -D_DEBUG -D_HAS_EXCEPTIONS=0 -D_UNICODE -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\cpp_client_wrapper\include -IC:\Users\Perqin\Workspaces\wallpaper-mix\windows\flutter\ephemeral\.plugin_symlinks\file_selector_windows\windows\include /DWIN32 /D_WINDOWS /GR /EHsc /Zi /Ob0 /Od /RTC1 -MDd /W4 /WX "/wd\"4100\"" /EHsc -std:c++17 /Be /Bd /EP
	cl: 命令行 error D8021 :无效的数值参数“/wd"4100"”

[Failed to reload]

It seems that this is caused by the line:
# Compilation settings that should be applied to most targets.
function(APPLY_STANDARD_SETTINGS TARGET)
  target_compile_features(${TARGET} PUBLIC cxx_std_17)
  target_compile_options(${TARGET} PRIVATE /W4 /WX /wd"4100")

in CMakeLists.txt, but it is strange that flutter run works perfectly.
I need to run the Windows app using CLion because I want to add C++ breakpoints for debugging.

Logs

@perqin
If I understand correctly, this issue is only occuring when you use CLion and not with Vscode ?
I am not much aware about CLion and it's setup though.

@darshankawar I try VS Code and it builds (configured with MSVC toolchain). But I launch Visual Studio and it fails with the same error as that in CLion:

@perqin
Does it only occur when you try to run Flutter project ? or with native as well ?
Just trying to segregate if it's specific to Flutter.

@darshankawar Yes, it only occur in my Flutter Desktop project.
By the way, I tried running cmake . in command line, and then opened the generated .sln solution with Visual Studio. Now the issue disappeared, but after I run BUILD_ALL - Debug - Start new instance, it complained that some path is "Access Denied". The project files doesn't require special permission to read/write and I also tried deleting the directory and rebuilt, but the error remained.

I am now still struggling how to debug the cpp code of a Flutter project with CLion/VS/other IDEs. Are there any working instructions?

Keeping this issue open for further investigation.

Where is the tool's repo? BTW I think this is not only the CLion's issue, because Visual Studio doesn't work, neither.

@perqin
Since this a long thread going on, can you provide the exact issue you are facing ?  Is it project failing to load for windows desktop or how to debug the cpp code of a Flutter project with CLion/VS/other IDEs.  Accordingly, we can direct / address this issue.
Thanks.

Sorry for not addressing my issue clearly. I want to know how to debug the cpp code of a Flutter Desktop project with Visual Studio.

@perqin Thanks for clarifying. Since it's more of a how to question using VSCode, I think it'll be better to ask this question in dedicated repo : https://github.com/Dart-Code/Dart-Code/issues, per this documentation, or even Stackoverflow would be a good platform to get help on your question.
I am going ahead and closing this, as it isn't a bug or a feature request. If you disagree or think this should be addressed here, write in comments and I'll reopen it.


Bug: Multiplayer game always have industrial research era

Even if the starting era should be neolite, hosting a server always resets it to industrial era.

I can verify that the same sort of issue happens for tribal starts.


Refactor apis

Branched from #11
More house cleaning.
Moves policy api group into directory.
Make code-gen binaries as a depend, refactor Makefile.
Not much interesting here :)

/assign @charlieegan3

Looks fine me be pending base -> attribute in #11. I'll LGTM when rebased.

/lgtm


can‘t build ios project

i git clone the project and put libraries into the project's root then  open SFBAudioEngine-iOS.xcodeproj and build
throw errors like this:
error: Build input file cannot be found: '/Users/yuu/code/SFBAudioEngine/ReplayGainAnalyzer.cpp' (in target 'libSFBAudioEngine' from project 'SFBAudioEngine-iOS')
warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'libSFBAudioEngine' from project 'SFBAudioEngine-iOS')

some files are gray status

when i delete this files
i got another error

xcode version Version 11.4 (11E146)

This project is in the midst of large changes to convert the playback implementation from AUGraph to AVAudioEngine. Once the conversion is complete I will take a look at fixing the iOS project- until then it doesn't make sense to update an obsolete .xcodeproj.

Well, to give a suggestion, you can open a new branch for refactoring to keep the master branch stable, haha

I did that for the Objective-C decoders...

PR #99 will allow compiling on iOS with the external libraries to follow

In its current state PR #99 builds and plays audio on iOS using Core Audio.

thank you very much


Outdated server component

As per https://forum.heroiclabs.com/t/ways-to-debug-server-code-nakama-defold-tictactoe-xoxo-example/3492/8
this code is outdated.
Could you update the code and the corresponding blog entries? Pretty please. ;-)

Strange thing that game still works on the web .. or is that also running an old server version?

Pull request waiting B-)

Merged!

update the code and the corresponding blog

Since the default behaviour is to not do anything with the match_signal it doesn't make sense to mention it specifically in the blog post.


Add a roll option for the branch being rolled to allow targeting of effects

Hello! I wanted to try and make effects for the classmate friendship goals in the Strength of Thousands AP, but couldn't find a way to uniquely identify these rolls to let me attach the Rule Elements to.  This was the minimal change I could think of that would allow me to target the rolls effectively, because the skill information is already present.

Closing because #2 is better!


about the command \color

is there any plan to implement the command \color?
If i want to implement this, where should i start from and how?

\textcolor is already implemented. Does that not work?

you mean tex command "\textcolor{red}{ letters in red} letters in black"?
or setting the textcolor properties of the MTUIMathLabel?
I can't use the tex command \textcolor

Yes tex command \textcolor. Why can't you use it? It should be easy to
add the \color command which is just an alias for \textcolor. Just add
it to the aliases list on MTMathAtomFactory.
On Fri, Jun 23, 2017 at 10:56 AM, wingsiu<EMAIL_ADDRESS>wrote:

you mean tex command "\textcolor{red}{ letters in red} letters in black"?
or setting the textcolor properties of the MTUIMathLabel?
I can't use the tex command \textcolor
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kostub/iosMath/issues/67#issuecomment-310732418, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFeXAU-ueqWmFH17clMeAXCDheXgr9hks5sG_xUgaJpZM4ODIlU
.

Any plan to implement the Tex command '\colorbox'?  That is the background color of the characters

@kostub this was implemented already, should this be closed?


appendix auth gcm link to new repo (which is xplat)

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors r+
Thanks for the fix!

:pushpin: Commit 5a0226d9bde3d7d8c45bbd70935792ce0aa937a4 has been approved by Eh2406

:hourglass: Testing commit 5a0226d9bde3d7d8c45bbd70935792ce0aa937a4 with merge 9140c546fe05d67e63726849c547209ee670e1f9...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing 9140c546fe05d67e63726849c547209ee670e1f9 to master...


[BUG] OpenSearch Dashboards Alerting Action Preview

Describe the bug
The mustache preview of ctx.results[0].hits.hits is broken and will not be displayed in the message preview.
To Reproduce
Steps to reproduce the behavior:

Go to Alerting and open a query with the method Extraction query editor
Add a sample query
Scroll down to 'Actions'
Add sample values

Monitor {{ctx.monitor.name}} just entered alert status. Please investigate the issue.
  - Trigger: {{ctx.trigger.name}}
  - Severity: {{ctx.trigger.severity}}
  - Period start: {{ctx.periodStart}}
  - Period end: {{ctx.periodEnd}}

{{#ctx.results[0].hits.hits}}
{{_source.summary.up}}
{{/ctx.results[0].hits.hits}}

The upper 4 values will be previewed if set. The results part will NOT be previewed. If one sends a test email the contents will be correct.
Expected behavior
The contents of the results will be previewed correctly.
OpenSearch Version
Docker 1.1.0
REPOSITORY                                TAG            IMAGE ID       CREATED         SIZE
opensearchproject/opensearch              1.1.0          6394bbe93612   6 weeks ago     835MB

Dashboards Version
Docker 1.1.0
REPOSITORY                                TAG            IMAGE ID       CREATED         SIZE
opensearchproject/opensearch-dashboards   1.1.0          ce0ea078fdfb   6 weeks ago     897MB

Plugins
Default
Screenshots

Additional context
None

Thank you, didn't see this repository. I've uploaded a wrong screenshot as well, the first one doesn't show the configuration of the 2nd screenshot (email). I'll fix this asap.

A PR for this is created, but I also wanted to drop a comment about the Mustache code being used. Once the correct data was available, in order to access the inner data I needed to access data from an array slightly different, like this:
{{#ctx.results.0.hits.hits.0}}
{{_source.agent}}
{{/ctx.results.0.hits.hits.0}}
The main difference being the .0 rather than [0].

Closing this issue as PR https://github.com/opensearch-project/alerting-dashboards-plugin/pull/334 has been merged. As discussed in that PR, there is a known issue with some of the variables in ctx which results from the alerting backend. That issue is being tracked in this issue https://github.com/opensearch-project/alerting/issues/200 in the backend repo, and there is currently a PR published to address it.


Asmatmaker

Android tv

@Asmatmaker cam you please help me understand what's going on here? It looks like you are trying to merge things from master back to a feature branch, which we should probably delete.

Closing out due to lack of update; please leave feedback if you believe this is in error.


Q: does styling without providing the index range work?

Can you for example type some text (e.g. "Hello") and then press a bold button WITHOUT selecting a range (i.e., no highlighting) and all other texts from that point onwards are bolded, like any other rich text editor?
EX)
https://user-images.githubusercontent.com/38872151/223916994-be1f9335-d7fe-4e3d-9488-489c64040e3b.mov
The current implementation of richTextFX seems to have the restriction of requiring a range. In other words, if the user press the bold button without highlighting a range, the selectionRange becomes (start=x, end=x) so styling with start and end where they are both x has no effect.

Try using:
area.setTextInsertionStyle( style );

and to unset:
area.setTextInsertionStyle( null );


chore: bump helm chart

Bump helm chart for 0.9
WRT #2440

/ok-to-test-managed provider=aws sha=bc3b44d

/ok-to-test-managed provider=gcp sha=bc3b44d

/approve


Add pending tabs styling

Pending tabs might be super confusing without the italics on the tabs. See https://github.com/atom/atom/issues/10753
cc @simurai

The italics already seem to work.

But something with the corners looks broken.

Closing this since the gif in the referenced PR has italics on the tabs so this probably never was an issue.


There is something error when i try to convert the module into keras module.

Traceback(most recent call last)
File "convert.py",line 262, in  _main(parser.parse_args())
...
...
Key error:"Cannot set attribute. Group with name "keras_version" exists."
have someone suddenly have this issue? Am i alone?

I just started seeing this in unrelated keras/tensorflow work. Still searching for a solution.


New extension: Perplexity-API

Description
This extension provides user access to all models through the Perplexity API.
There is a Raycast perplexity extension but it just opens query links in the browser for faster access to Perplexity web interface.
This extension, though, gives user access to open-source models not offered on the web interface. That's why I built a new extension rather than updating the existing one because they serve different purposes.
Selected Text Commands

Change tone to casual
Change tone to friendly
Change tone to professional
Comment code
Compose Message/Mail responses
Explain selected text
Fix grammar and spelling
Improve selected text
Make selected text longer
Make selected text shorter
Summarize selected text
Find synonyms according to the selected word
Break down project description into tasks
Translate selected text

Quick AI

Ask AI a one-shot question

Supported Models

codellama-34b-instruct
codellama-70b-instruct
llama-2-70b-chat
mistral-7b-instruct
mixtral-8x7b-instruct
pplx-7b-chat
pplx-70b-chat

Screencast

Additionally, it calculates the cost per request, as displayed in the toast notification.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I really think it would make sense to only have one Perplexity extension - what do you think, @third774?
This seems like a far better way to work with perplexity

I'm hopeful that one day my extension can be deprecated/removed — especially with the upcoming work y'all are doing to directly integrate Perplexity with Raycast. That said, I would argue that the current extension is still very useful in a few ways:

No API key required!
Can make use of Perplexity's copilot mode
Can make use of Perplexity's focus modes

I don't know if these are available via the API access to models are they? Often, I also like to inspect the search results that are surfaced in the web UI. I think we'd be losing that as well, wouldn't we?
I'm def not opposed to merging these two extensions though if y'all think that's best! It's just that personally I think I'm going to keep using the web UI until those features are available directly in Raycast.

What about we merge them so we can keep both yours and all the new stuff? It will require that content of the PR is added on top of the current extension so it's "just" an update 🙂

* No API key required!

* Can make use of Perplexity's copilot mode

* Can make use of Perplexity's focus modes

I don't know if these are available via the API access to models are they? Often, I also like to inspect the search results that are surfaced in the web UI. I think we'd be losing that as well, wouldn't we?

Exactly! None of those features are accessible through the API. Moreover, the web UI uses models from OpenAI, Anthropic and Google, whereas the API relies on models from Meta, Mistral, and Perplexity.

What about we merge them so we can keep both yours and all the new stuff? It will require that content of the PR is added on top of the current extension so it's "just" an update 🙂

The point is, the two extensions serve different purposes. Individuals seeking access to GPT3.5 or GPT4 prefer the web UI, whereas those who favor open-source models would use my extension.
Still, I get why you might consider merging them. In this case, should I modify the PR?

Sounds like it's better to keep it as two separate, as long as the naming clearly shows it 🙂

Would it make sense to make some of the commands disabled by default? Like we do in our Spotify extension 🙂

Would it make sense to make some of the commands disabled by default? Like we do in our Spotify extension 🙂

Thank you! I was unaware of the property.
I disabled some commands.


Feature/pagination

Should be fixed, also added some unit testing. Agreed on keeping visibleTo into another branch, will discuss with Nick


Add-on disabled on AMO

Didn't pass review, mainly because of #16
Edit: Fixed that and resubmitted - we shall see.

We're back on AMO: workarounds are disabled ReCAPTCHA and piwik for now.


[Serialbox] Import "official" package from Sergey

Repace our current serialbox-package with the one provided by Sergey in Spack.
Nonetheless the following modifications with regard to the original implementation were applied:

Add cmake_flags.append('-D__GCC_ATOMIC_TEST_AND_SET_TRUEVAL=1') to flaghandler to account for Daint specialities
Remove Python as run-dependency (tried to rebuild Python during build)
Hardcode boost dependency to<EMAIL_ADDRESS>type='build')to avoid a rebuild

This piece of works serves as an sub-step to fully outsource serialbox to the official Spack distribution
To-Do

[x] Manually serialize data from COSMO
[x] Manually run Dycore test with that data

launch jenkins serialbox

launch jenkins --daint icon

launch jenkins --tsa --only cosmo icon

launch jenkins --tsa --exclusive cosmo icon

launch jenkins --daint icon cosmo

launch jenkins --tsa cosmo icon

launch jenkins all

launch jenkins serialbox

launch jenkins --tsa cosmo

launch jenkins all

launch jenkins all

I will do the merge on Sunday evening to not break BB again!


UI branch

Made Admin_view_tests_and_users, that show tests and users for admin
Made test_data
Some small fixes

@akrisfx иди проверяй


Download incorrect and typo

It's January 2021 and not 20201
The download is still V3 and not V4 as announced in the article

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6624d44c-f9f6-02f8-2c67-0f0637fed62e
Version Independent ID: 9346a8ff-bab5-be2c-9dc1-d546fda1efa9
Content: Azure Icons - Azure Architecture Center
Content Source: docs/icons/index.md
Service: architecture-center
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 367341

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 367341

Don't see the 20201 typo, the download file is now pointing to v4 zip file.

Don't see the 20201 typo, the download file is now pointing to v4 zip file.


add webhook for created pull request, refactoring

Can anyone to help me? Where error is? I have check this file by local and i haven't any errors from phpcs.

@dancryer is this down to the new build mechanism? Wondering if GitHub doesn't have access to the build results and therefore always marks them as failed? Been seeing this on other PRs recently as well, it seems.

PHPCI/Controller/WebhookController.php
The class WebhookController has an overall complexity of 54 which is very high. The configured complexity threshold is 50.

Hello, @dancryer. I have checked WebhookController with phploc, it show me next info about complexity:
Cyclomatic Complexity
Average Complexity per LLOC                     0.30
Average Complexity per Class                   42.00
Minimum Class Complexity                     42.00
Maximum Class Complexity                     42.00
Average Complexity per Method                   4.15
Minimum Method Complexity                     1.00
Maximum Method Complexity                     9.00
Can you give me information, how can i check it on local machine?


Remove extra includes

The library should ideally be usable in common headers that permeate throughout a given project. Heavy includes can mean a heavy compilation performance hit in such cases.
Consider at least removing <array>, as it includes <algorithm>.
Consider reviewing all the other heavy includes and seeing if it's possible to go by without them:

<functional>
<memory>
<optional>
<stdexcept>

(Those are considered heavy according to C++ Compile Health Watchdog.)

Header  anyany/anyany.hpp now only depends on
, , , <type_traits>,


Request for defense method HGD and NRP model files

Dear authors,
Thanks for the open-source of your neurips23 paper Rethinking the Backward Propagation for Adversarial Transferability!
While I try to reproduce the results in Table 3 -- defense methods evaluation of BPA. I found the model files for defense methods HGD and NRP are not provided in this code repository.
It would be very helpful if you could provide these two files.
Thank you!

please refer to this repo: https://github.com/Trustworthy-AI-Group/TransferAttack


More flexible config mode reset

I'm thinking on how to make the reset (to config mode) more flexible.
At first step a method resetConfig that can be call from main code could be a nice step. It will allows any user defined reset (why not a konamicode on the device keypad ;)).
However the current reset (GPIO0==D3 low for 5sec) might be problematic if this pin is used for other something else. It could generate undesired reset...
An radical solution would be to let entirely the user defined (and code) the reset trigger... Not satisfying as with NodeMCU D3 is already bind to push btn (flash) and is a very good candidate for a default reset method !
One other solution may be to have tho other methods:

setResetTrigger(D4, HIGH, 6000): configure that config reset will be trigger if D4 is high for 6sec (with level and timing as option);
unableResetTrigger(): disable "homie-managed" reset

Other ideas ?

At first, Homie-ESP8266 was designed for NodeMCU v1.0, but this obviously has to evolve.
To sum up:

setResetTrigger(D4, HIGH, 6000)
setResetFunction(func). if func() returns true, the device resets. But setResetFunction() is already a function that allow to define a function to run (e.g. clean custom EEPROM) when a reset is triggered. Maybe we could rename this one setResetHandler() or setResetHook? The hook one is the most explicit, as it is actually an hook
disableResetTrigger() disables the inner reset trigger only

It seems clever for me to keep the default reset trigger. Note that to have an ESP8266 to boot from flash (normal boot) you need to have GPIO0 high, so in most set-up GPIO 0 will be pullup.
For "manual" reset I was more thinking to a Homie.resetConfig() method that can be called from the user code (basically from the loopHandler) that just directly trigger the reset...

The loopHandler is only called when the network is in a good state (connected to both Wi-FI and MQTT).  So a resetConfig could eventually be called from the loop(), but this is sad to add code there, where there is only a pretty Homie.loop() call.

good point :)
Maybe one can add a warning about that in the doc !
So your solution with a callback fct is clearly better.
I'll need all this for one of my devices where all GPIO are used. So I'll work on this when I update the FW of that device (to make it use Homie). However I don't know when it will be...

I'll create a proper documentation, as the project is becoming more and more feature-rich. ;)
I don't know how I will implement those methods either!

Docs are more complete about the loopHandler now. More flexible reset is the next thing I will implement.

Done: cfbcb5925520d091b86f9b46dd73ca80bf75cb71 and b9d4b6b358ad435cf1049758f704f4a91e84184f
You can see the usage in the Wiki

Great ! Nice work :+1:
I hope to have some time to test it one evening next week...
Thanks !

Take your time! Feel free to reopen if it does not work for you.


Add slack alert to EvalML test with Woodwork main

We can add a slack alert when our EvalML main fails with Woodwork main
This slack alert should ping both Woodwork & EvalML team

@chukarsten I can do this issue once #3479 and #3478 are done.


Feature: Instagram embed support

I've got a lot of links to Instagram videos in my workspace.
It would be awesome to be able to embed Instagram videos.
If there's appetite, I might craft a PR at some point.

It should be easy if you are trying to embed the iframe automatically, but using advanced features like timestamp will require support from Instagram iframe API. I'm not so familiar with it, but it seems to be less promising as I found this issue.


Javascript Autocomplete doesn't work

What did you expect to happen?
When have defined in the same file or default method from Javascript I would like to use C Spc or Cmd Spc to autocomplete or suggest the completion without press any shortcuts.
What actually happened?

Notice I've defined performanceDays in the line above and receive the No completion found.
Additional details:

My private config
use CMD Spc or C Spc to inspect keys);
Warning message: No completion found.

System information:

SYSTEM  type       darwin
        config     x86_64-apple-darwin18.7.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64
        path       (~/workspace/agriness-presence-frontend/node_modules/.bin/ /usr/local/sbin ~/bin /usr/local/bin ~/.emacs.d/bin /usr/bin /bin /usr/sbin /sbin /Library/Apple/usr/bin ~/Library/Android/sdk/emulator ~/Library/Android/sdk/tools ~/Library/Android/sdk/tools/bin ~/Library/Android/sdk/platform-tools ~/.antigen/bundles/robbyrussell/oh-my-zsh/lib ~/.antigen/bundles/mengelbrecht/slimline ~/.rvm/bin<EMAIL_ADDRESS>EMACS   dir        ~/.emacs.d/
        version    28.0.50
        build      Aug 20, 2020
        buildopts  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp<EMAIL_ADDRESS><EMAIL_ADDRESS>--with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained
        features   JPEG TIFF PNG RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS PDUMPER LCMS2
        traits     (server-running envvar-file)
DOOM    dir        ~/.dotfiles/emacs/.doom.d/
        version    2.0.9
        build      HEAD -> develop ce2cabf07 2020-08-25 06:07:47 -0400
        elc-files  0
        modules    (:completion company ivy :ui deft doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets :emacs dired electric (undo +tree) vc :os macos :tools editorconfig (eval +overlay) (lookup +docsets +dictionary) magit :lang emacs-lisp (go +lsp) json (javascript +lsp) markdown (org +pomodoro +journal +hugo) sh web yaml :app (rss +org) :config (default +bindings +smartparens))
        packages   ((ob-typescript) (prettier-js) (move-text) (js-doc))
        unpin      (n/a)
        elpa       (n/a)

Does completion work elsewhere? If so, then this issue should be reported upstream, to the LSP server you are using. You may also want to try another javascript LSP server.

Side note: it looks like you have a .js file open, therefore js2-mode is likely to be activate. Try switching to rjsx-mode and see if completion behavior changes. i.e. M-x rjsx-mode.

Does completion work elsewhere? If so, then this issue should be reported upstream, to the LSP server you are using. You may also want to try another javascript LSP server.

I tried both LSP modes but get the same problem.

Side note: it looks like you have a .js file open, therefore js2-mode is likely what major mode you're in. Try switching to rjsx-mode and see if completion behavior changes. i.e. M-x rjsx-mode.

I tested with rjsx-mode in a React file and in a pure Javascript, both returns No completion found.
My current details:

SYSTEM  type       darwin
        config     x86_64-apple-darwin18.7.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64
        path       (~/workspace/agriness-presence-frontend/node_modules/.bin/ /usr/local/sbin ~/bin /usr/local/bin ~/.emacs.d/bin /usr/bin /bin /usr/sbin /sbin /Library/Apple/usr/bin ~/Library/Android/sdk/emulator ~/Library/Android/sdk/tools ~/Library/Android/sdk/tools/bin ~/Library/Android/sdk/platform-tools ~/.antigen/bundles/robbyrussell/oh-my-zsh/lib ~/.antigen/bundles/mengelbrecht/slimline ~/.rvm/bin<EMAIL_ADDRESS>EMACS   dir        ~/.emacs.d/
        version    28.0.50
        build      Aug 20, 2020
        buildopts  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp<EMAIL_ADDRESS><EMAIL_ADDRESS>--with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained
        features   JPEG TIFF PNG RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS PDUMPER LCMS2
        traits     (server-running envvar-file)
DOOM    dir        ~/.dotfiles/emacs/.doom.d/
        version    2.0.9
        build      HEAD -> develop 1c99aed0c 2020-08-25 21:22:56 -0400
        elc-files  0
        modules    (:completion company ivy :ui deft doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets :emacs dired electric (undo +tree) vc :os macos :tools editorconfig (eval +overlay) (lookup +docsets +dictionary) magit :lang emacs-lisp (go +lsp) json (javascript +lsp) markdown (org +pomodoro +journal +hugo) sh web yaml :app (rss +org) :config (default +bindings +smartparens))
        packages   ((ob-typescript) (prettier-js) (move-text) (js-doc))
        unpin      (n/a)
        elpa       (n/a)

Does completion work elsewhere? If so, then this issue should be reported upstream, to the LSP server you are using. You may also want to try another javascript LSP server.

You're right, I tested with elisp and worked well, it's specific to LSP of Javascript.

Hey @hlissner !
I made the following steps and worked like a charm:

Enabled the lsp was disabled :/
Installed JavaScript/TypeScript (sourcegraph);
Run lsp in an opened file;
Initilized the LSP to the project. 💯


Updating docs and dgraph-js versions in examples

Signed-off-by: Prashant Shahi<EMAIL_ADDRESS>

This change is

Looks good.


the millisecond part of the timestamp is displayed incorrectly

Description
select now();
now
2022-10-10 11:19:12.1912 +0300
millisecond part always repeats data from minutes and seconds
It is DBeaver's bug, not DB
Native Postgresql client app psql displays timestamp correctly
DBeaver Version
Community Edition <IP_ADDRESS>207240747
Operating System
Windows 10
Database and driver
PostgreSQL 10/11
Steps to reproduce
Global Settings\Editors\Data Editor: Template for "Timestamp with Timezone" = "yyyy-MM-dd HH:mm:ss.ms Z"
Additional context
No response

Hello @Yurii-kyiv
As I can see in your pattern and result:
HH: (Hour in day) - 11
mm: (Minute in hour) - 19
ss: (Second in minute) - 12
m: (Minute in hour without leading zeros) - 19
s: (Second in minute without leading zeros) -12
So, 11:19:12.1912 - is expected result for your pattern. And here you can find our wiki page: https://dbeaver.com/docs/wiki/Managing-Data-Formats/#time
Do you want to see millisecond in the result value? Then you can try to use default DBeaver timestamp pattern with SS on the end.

Thanks a lot Anastasiya.
I was wrong. I used Postgresql template for timestamp.
11 октября 2022, 02:43:54, от "Anastasiya" @.***>:
Hello @Yurii-kyiv
As I can see in your pattern and result:
HH: (Hour in day) - 11
mm: (Minute in hour) - 19
ss: (Second in minute) - 12
m: (Minute in hour without leading zeros) - 19
s: (Second in minute without leading zeros) -12
So, 11:19:12.1912 - is expected result for your pattern. And here you can find our wiki page: https://dbeaver.com/docs/wiki/Managing-Data-Formats/#time
Do you want to see millisecond in the result value? Then you can try to use default DBeaver timestamp pattern with SS on the end.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

DBeaver is based on java, and it is a universal tool, so we are using java patterns, yes.
Ok. Does this issue solve? Am I closing the ticket?

Yes, issue solved. Thanks
11 октября 2022, 11:38:47, от "Anastasiya" @.***>:
DBeaver is based on java, and it is a universal tool, so we are using java patterns, yes.
Ok. Does this issue solve? Am I closing the ticket?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Added WIF support to AzureMonitorAlertsV0

Task name: AzureMonitorAlertsV0
Description: Added WIF support to AzureMonitorAlertsV0
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist:

[x] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

This task is deprecated


connectedComponentsWithStats ignores connectivity parameter

Expected behaviour
My example code creates a mask with two squares, which touch only at one corner. With connectivity equals 4 I would expect the output of figure 2, i.e. different labels for for each square.
With connectivity equals 8 I get the same labels for both squares, which is as expected.
Actual behaviour
With connectivity equals 4 I get the output of figure 1, i.e. the same output as for connectivity equals 8 (figure3). Specifying the connectivity has no influence on the output.
Steps to reproduce
This is the code, that created figure 1, 2 and 3:
import cv2
import matplotlib.pyplot as plt
import numpy as np

mask = np.zeros((6,6), dtype=np.uint8)
mask[1:3,1:3] = 255
mask[3:5,3:5] = 255

connectivity=4
_, labels, _, _ = cv2.connectedComponentsWithStats(mask, connectivity, cv2.CV_32S)
plt.figure()
plt.imshow(labels, cmap='jet')
plt.title('connectivity = {:d}'.format(connectivity))
labels[3:5,3:5]=2 # manually changing the labels to the expected output
plt.figure()
plt.imshow(labels, cmap='jet')
plt.title('connectivity = {:d} (expected)'.format(connectivity))

connectivity=8
_, labels, _, _ = cv2.connectedComponentsWithStats(mask, connectivity, cv2.CV_32S)
plt.figure()
plt.imshow(labels, cmap='jet')
plt.title('connectivity = {:d}'.format(connectivity))

plt.show()

The python function incorrectly. You can achieve expected behaviour with named parameters:
_, labels, _, _ = cv2.connectedComponentsWithStats(mask, connectivity=connectivity, ltype=cv2.CV_32S)

See documentation: https://docs.opencv.org/4.x/d3/dc0/group__imgproc__shape.html#ga107a78bf7cd25dec05fb4dfc5c9e765f

Hi Alexander,
That fixed the problem, thank you!
Markus
Markus Schiefele, PhD
Principal Software and Algorithm Engineer
@.***
[HID Global Logo]https://nam02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.hidglobal.com%2F&data=04|01|zach.osne%40hidglobal.com|71d566eedc614b5a89b808da0223509f|f0bdc1c951484f86ac40edd976e1814c|0|0|637824647955524029|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=y%2FcEbu0Z4vCt0ew0u8dYV4nspj%2FGiivEW2mlEQrkRcc%3D&reserved=0
3950 RCA Blvd. Ste 5001, Palm Beach Gardens, FL 33410 , USA
www.hidglobal.comhttps://nam02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.hidglobal.com%2F&data=04|01|zach.osne%40hidglobal.com|71d566eedc614b5a89b808da0223509f|f0bdc1c951484f86ac40edd976e1814c|0|0|637824647955524029|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=y%2FcEbu0Z4vCt0ew0u8dYV4nspj%2FGiivEW2mlEQrkRcc%3D&reserved=0
From: Alexander Smorkalov @.>
Sent: Wednesday, March 1, 2023 1:52 AM
To: opencv/opencv-python @.>
Cc: Schiefele, Markus @.>; Author @.>
Subject: [EXT] Re: [opencv/opencv-python] connectedComponentsWithStats ignores connectivity parameter (Issue #809)
CAUTION: This email is external. Do not click links or attachments that are unexpected or from unknown senders. If unsure, click the Report Phishing Button in Outlook.
The python function incorrectly. You can achieve expected behaviour with named parameters:
_, labels, _, _ = cv2.connectedComponentsWithStats(mask, connectivity=connectivity, ltype=cv2.CV_32S)
See documentation: https://docs.opencv.org/4.x/d3/dc0/group__imgproc__shape.html#ga107a78bf7cd25dec05fb4dfc5c9e765fhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.opencv.org%2F4.x%2Fd3%2Fdc0%2Fgroup__imgproc__shape.html%23ga107a78bf7cd25dec05fb4dfc5c9e765f&data=05|01|Markus.Schiefele%40hidglobal.com|2706ebc95cf343d24f4908db1a2178cb|f0bdc1c951484f86ac40edd976e1814c|0|0|638132503289791053|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=gf9jFlKiRErl0hnWFy8D4fh6rnAoYdXodV02QG0tQBY%3D&reserved=0

Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopencv%2Fopencv-python%2Fissues%2F809%23issuecomment-1449443848&data=05|01|Markus.Schiefele%40hidglobal.com|2706ebc95cf343d24f4908db1a2178cb|f0bdc1c951484f86ac40edd976e1814c|0|0|638132503289791053|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=9WDYtSdNNiOcZ3MPZw7Hv7s1zP8PYtmO4FKQFfM0IFQ%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQAOZODBIW2Q7MDYZMVBUETWZ3WZNANCNFSM6AAAAAAVK6MI2U&data=05|01|Markus.Schiefele%40hidglobal.com|2706ebc95cf343d24f4908db1a2178cb|f0bdc1c951484f86ac40edd976e1814c|0|0|638132503289791053|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=j5otVIjM7W2nZ4dAgLcDcUbxps%2Blzl9rA6ae4kxz9sQ%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Add command to list exsiting cloud connection accross regions in account

I would like to add a command which lists all the existing cloud connections across regions and their status

/assign

https://github.com/ppc64le-cloud/pvsadm/pull/545


ValueError: shape is not a placeholder errors on some PPT's

MacOS
Python: 3.9
is there an 'ignore' option if it can't render ?
Can it be fixed in the Powerpoint format?
Would it be this one in the library?
https://github.com/scanny/python-pptx/issues/333

python3.9/site-packages/pptx/shapes/base.py", line 153, in placeholder_format
raise ValueError("shape is not a placeholder")
ValueError: shape is not a placeholder
Traceback (most recent call last):
File "/usr/local/bin/pptx2md", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/site-packages/pptx2md/main.py", line 148, in main
parse(prs, out)
File "/usr/local/lib/python3.9/site-packages/pptx2md/parser.py", line 237, in parse
if hasattr(shape, "placeholder_format"):
File "/usr/local/lib/python3.9/site-packages/pptx/shapes/base.py", line 153, in placeholder_format
raise ValueError("shape is not a placeholder")
ValueError: shape is not a placeholder

should be fixed in version 1.6.1


Future testnet versions of BNS (v2, v3 etc.)

Use import function to airdrop every mainnet address to there respective testnet address.
This is also a good test of the import function for mainnet where you'd airdrop v2 names to v1 name holders.
Stacks CLI can be used to derive the testnet address from the mainnet address and visa versa. Related comment: https://github.com/hirosystems/stacks.js/issues/920#issuecomment-813952041

Thank you! Really useful

We will implement this when launching the final version for testnet and do migration of all namespaces and all names on mainnet to their corresponding testnet address


Account-switcher modal

This is a follow-up to:

#1037

Before this issue (and after #1037), when the user chooses the "Organizations" option from the main menu, we take them to a choose-account page with a list of accounts.
This issue is to instead show a modal menu with a list of accounts, like this:

This doesn't yet have a fully-updated design, so it will need that before it's ready for implementation.
This also has a post-launch issue as a prerequisite, in order to have all the needed data:

#1036

(Unlike #1037, this issue needs the realm name and icon even for accounts we don't currently have a live PerAccountStore for. That's why it needs that data to be in the database when #1037 doesn't.)
So this is a post-launch issue too.

Hi @gnprice , I donot see this UI on the app that you posted screenshot with. Can you please elaborate more.

Hi @yashrajjain726, welcome! This issue isn't yet ready to work on. If you'd like to choose an issue to work on, please see our guide to doing so and please choose a different issue.


Failing Scenarios Exiting with 0

Tests are being properly executed, however we have been having the exit 0 message from cucumber no matter if the features are failing or passing. This has been a relatively recent issue. See screenshot below.

TEST_SUITE="bundle exec cucumber path_to_features -r path_to_steps"

ruby 2.1.0
cucumber 1.3.10

Followed this one down the rabbit hole today. Couldn't see any nicer way of doing this in rails than an initializer with the following:
if defined? Minitest
  Minitest.module_eval do
    def self.autorun; end
  end
end

Looking at multi_test, it seems like it's supposed to do this. Maybe something in minitest changed?
One important thing: it only messes up when running from a rake task, not when run directly from the command line...

I was stuck trying to git bisect with cucumber and it kept failing because it always returned zero status code.
Thanks @alp06h hack I was able to figure out the problem.
I've had at features/support/env.rb
at_exit do
  DatabaseCleaner.clean_with :truncation
end

Changing it to this code bellow (borrowed from @alp06h 's code)
at_exit do
  # Preserve exit status
  exit_status = $!.status if $!.is_a?(SystemExit)
  DatabaseCleaner.clean_with :truncation
  exit exit_status if exit_status
end

... solved the issue.
I'm on:

Ruby 2.2.2
Cucumber 2.3.2
Rails <IP_ADDRESS>
Database Cleaner 1.5.1

Note: at_exit hook is recommended by the Cucumber github developers.
See:

https://github.com/cucumber/cucumber/wiki/Hooks#global-hooks
https://www.ruby-forum.com/topic/178689

What version of cucumber-ruby is this going to end up in?
Is cucumber-ruby part of  'cucumber', '2.3.3' or 'cucumber-rails', '1.4.3'or"database_cleaner", "1.3.0"`?  I use those and have this problem too but I don't see cucumber-ruby as part of those.  Do I need to open an issue somewhere else?  Where might that be?

@dwickwire Don't be confused. https://github.com/cucumber/cucumber-ruby is the ruby-gem "cucumber". See the gemspec-file.


Recent features/UI improvements

Remove Multiple Scrollbars.
Add Command Bar to Conversation, Revision, and Usage Sample Pages.
Switch to Circle Button for Adding Samples.
Adjust Resolution Checkbox.

Can we merge this after the three pending PR from the Massey team please?


Enter amount modal needs small improvements

Fix commas being added after the decimal point
Show type of unit amount should be entered in
Fix margin of the button from the text field

Verified this issue on keeper app v 1.2.18(411)


Remove redundant commands selector and test

Remove redundant getCommandsAsArray selector and test. Same result could be achieved by using Object.values in container component.

We weren't using this on the webapp anywhere so should have no backwards compatibility problems


Add codemod to replace array.prototype.some

I just merged the other PR, looks like this now has conflicts, can you fix those? :) Otherwise LGTM

@thepassle resolved


Minimal support for custom snapshot directory

Having this public could allow us to use custom snapshot directory.
This code will allow us to fix #9.

@mackoj, I think I'd like to leave this private since it's not really meant to be accessed in day-to-day use. It's a pretty trivial function and the Configuration.name is public, so you could easily duplicate it in your custom function that's calling down into verifySnapshot, assuming you're even using the name parameter in assertSnapshots.

Yes, it’s true. It can work without this modification.
I used this functionality because I simply copied and pasted your original implementation of assertSnapshot since you had used it.
My goal was more to demonstrate that it can be trivial to support the use of verifySnapshot instead of assertSnapshot and to gain the ability to change the snapshot directory.
I hope to have shown/shared a simple way, in issue #8, to support this feature that can be really helpful.

@mackoj I think it's a great example, thanks for sharing it.
Seeing as using a custom snapshot directory with vanilla swift-snapshot-testing requires calling into verifySnapshot directly rather than using one of the assertSnapshot functions I think requiring the same approach in this library is reasonable.
As you've demonstrated it's possible for consumers of the library to implement their own custom snapshotting functions by looping over configurations directly:
extension PreviewSnapshots {
    func customAssertSnapshots(
        as snapshotting: Snapshotting<AnyView, UIImage> = .image,
        record recording: Bool = false,
        file: StaticString = #file,
        testName: String = #function,
        line: UInt = #line
    ) {
        for configuration in configurations {
            let failure = verifySnapshot(
                matching: configure(configuration.state),
                as: snapshotting,
                record: recording,
                snapshotDirectory: "/some/location"
            )
            if let message = failure {
                XCTFail(message, file: file, line: line)
            }
        }
    }
}

Maybe adding a little bit of documentation could be enough to clarify how to utilize your library and assist people seeking this feature.

In my example, I did use the same function name as you because I didn’t want to change all the tests; it was more convenient and blend perfectly since it's not the same function signature.


Serialization and deserialization of G2

G2Projective does not implement serialization and deserialization methods of the form:
{"x": "0x01a6ba2f9a11fa5598b2d8ace0fbe0a0eacb65deceb476fbbcb64fd24557c2f4b18ecfc5663e54ae16a84f5ab7f62534,0x11fca2ff525572795a801eed17eb12785887c7b63fb77a42be46ce4a34131d71f7a73e95fee3f812aea3de78b4d01569", "y": "0x0b6798718c8aed24bc19cb27f866f1c9effcdbf92397ad6448b5c9db90d2b9da6cbabf48adc1adf59a1a28344e79d57e,0x03a47f8e6d1763ba0cad63d6114c0accbef65707825a511b251a660a9b3994249ae4e63fac38b23da0c398689ee2ab52"}

this feature has been implemented.

this feature has been implemented.


ssh_private_key -> private_ssh_key, misc cleanup

Corrects README to use private_ssh_key instead of ssh_private_key.
Misc markdown cleanup.

Thanks for the contribution and fixes @jramos-io!


Install dependencies script

I think it makes sense to have a shell script that will run remotely and install or update dependencies.
Call it deps.sh and let it live at root (don't install this when running dotfizzles install script).

For now, going to just document what needs to be done in WIKI:
https://github.com/mhulse/dotfizzles/wiki/Dependencies
And note that this needs to be done pre-installation of dotfizzles.

Also, let's remove .scripts and have people put stuff in a non-hidden dir called scripts (which is already being sourced in .bash_profile.

Scripts has been removed in house cleaning branch.
WIKI will be updated over time with deps:
https://github.com/mhulse/dotfizzles/wiki/Dependencies
Related: #221


Hi

Hi friend, could you rate my repositories and I'll rate yours at the same time? Thanks!

Sorry friend, but I'm still a beginner in this world. Of the languages you have repositories, I only understand HTML and CSS. There would be no way to evaluate their repositories.


[Pulsar-Functions] Use ComputeIfAbsent instead  in FunctionCacheManagerImpl

Motivation
cacheFunctions is  ConcurrentHashMap, no need to use synchronized block.
Modifications
Remove synchronized block.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Don't use putIfAbsent. Use computeIfAbsent.
For example,
    private static String newValue() {
        System.out.println("Call newValue");
        return "hello";
    }

    public static void main(String[] args) {
        final Map<String, String> map = new ConcurrentHashMap<>();
        System.out.println(map.putIfAbsent("A", newValue()));
        System.out.println(map.putIfAbsent("A", newValue()));
    }

The output is:
Call newValue
null
Call newValue
hello

But if you use
        System.out.println(map.computeIfAbsent("A", __ -> newValue()));
        System.out.println(map.computeIfAbsent("A", __ -> newValue()));

The output will be:
Call newValue
hello
hello

You can see computeIfAbsent avoids computing the value if the key already exists. Though the returned value is always non-null. So I suggested capturing an atomic boolean in the function of computeIfAbsent like:
        final AtomicBoolean computed = new AtomicBoolean(false);
        map.computeIfAbsent("A", __ -> {
            computed.set(true);
            return newValue();
        });

We need use putIfAbsent here , as previous logic, Only If the key is existed before , we register the entry.
If We use computeIfAbsent, the return value will be previous value or computed value, We cannot judge if the key existed before. @BewareMyPower

You can use following code to check if the previous doesn't exist as I've said.
        final AtomicBoolean computed = new AtomicBoolean(false);
        map.computeIfAbsent("A", __ -> {
            computed.set(true); // it's true only when the value is computed
            return newValue();
        });

For example, here is an example implementation for registerFunctionInstanceWithArchive:
        final AtomicBoolean computed = new AtomicBoolean(false);
        final AtomicReference<Throwable> throwable = new AtomicReference<>();
        final FunctionCacheEntry entry = cacheFunctions.computeIfAbsent(fid, __ -> {
            try {
                final FunctionCacheEntry cacheEntry =
                        new FunctionCacheEntry(narArchive, eid, rootClassLoader, narExtractionDirectory);
                computed.set(true);
                return cacheEntry;
            } catch (IOException e) { // I think it's better to catch `IOException`, instead of `Throwable`
                throwable.set(e);
                return null;
            }
        });
        if (throwable.get() != null) {
            Exceptions.rethrowIOException(throwable.get());
        }
        if (!computed.get() && entry != null) { // the key already exists
            entry.register(eid, Collections.singleton(narArchive), Collections.emptyList());
        }

/pulsarbot run-failure-checks


  I'm just testing the branch permissions--I shouldn't be able to merge with master until after Charlie reviews the change. Let's see

OK, it's blocking both a direct push to master from my local machine, and also the "Merge pull request" button above is unavailable, indicating that an approving review is required.

Charlie, one question is whether you got notified of this pull request yet. I didn't specifically request any reviews but I'd assume you'd get notified since the owner review should be required.

This is a test of the pull request system.


Rename connecting-to-github-with-ssh.md to connecting-to-github-with-…

…ssh.md gitAZ1341

Why:

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

I want change ssh gitAZ1341   to ssh GA121

I want change ssh gitAZ1341   to ssh GA121


Drop cluster-wide RBAC install and fix finalizer permissions issue.

We picked up an ArgoCD pattern where you can install with namespaced or
cluster-wide permissions. The cluster-wide was required so Argo could
potentially sync resources to the cluster it's running in. This however
is not relevant to the ApplicationSet CR, so we do not need to support
dual modes of install and can instead just deploy with namespaced RBAC.
Fix a missing permission for finalizers so we can set an Application
blockOwnerDeletion reference back to the ApplicationSet that is
originated from.

/cc @mgoodness
As we discussed dropping this cluster scoped install.

Fixes this error which surfaces at least with cluster generator:
time="2020-09-25T14:37:30Z" level=info msg="matched cluster secret" cluster=cluster-api.dgood-dev.new-installer.openshift.com-3927666468
time="2020-09-25T14:37:30Z" level=info msg="generated 1 applications" generator="&{0xc0003c5980}"
time="2020-09-25T14:37:30Z" level=error msg="failed to unchanged Application" action=unchanged app=admin-configmaps appSet=clustergen error="applications.argoproj.io \"admin-configmaps\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>"
2020-09-25T14:37:30.114Z        ERROR   controller-runtime.controller   Reconciler error        {"controller": "applicationset", "name": "clustergen", "namespace": "argocd", "error": "applications.argoproj.io \"admin-configmaps\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>"}

@dgoodwin does it fix #52 ?

@dgoodwin @OmerKahani the fix here to add applicationsets/finalizers  inbase/rbac resolved my final issue #52

Fixes #52


fix(toml): Don't lose 'public' when inheriting a dep

What does this PR try to resolve?
When inheriting a simple dep, we preserved the package dep's public
field but lost it when inheriting a detailed dep.
This was done by consolidating the code paths.  This also reduces the
risk of us doing this again in the future.
How should we test and review this PR?
I didn't write tests for this specific case because I refactored the root cause away.
Additional information

@bors r+

:pushpin: Commit 1fc366826c0b0a375423435a694aa3ad53c63d30 has been approved by Muscraft
It is now in the queue for this repository.

:hourglass: Testing commit 1fc366826c0b0a375423435a694aa3ad53c63d30 with merge e591b0ee9f79f14e54f7a105b589eba09632f0d0...

:sunny: Test successful - checks-actions
Approved by: Muscraft
Pushing e591b0ee9f79f14e54f7a105b589eba09632f0d0 to master...

:sunny: Test successful - checks-actions
Approved by: Muscraft
Pushing e591b0ee9f79f14e54f7a105b589eba09632f0d0 to master...

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.


Refactor mesh.go logic into SVM.ApplyLayer

Motivation
Closes #2831. It also brings forward #2069 by replacing big.Int with uint64 in a few places.
Changes
This PR completely replaces the mesh.go:txProcessor API with mesh.go:svm, which adds the ApplyLayer method. Some logic is then moved into the svm package.
Test Plan
Relying on the current testing infrastructure as no functional changes are expected.
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

I see most of the code that I'm touching is still based on *big.Int (uint64 as well, but we've established already that's not okay). I'm not sure if *big.Int the final decision, but I guess I should conform to that for all new code. @dshulyak what do you think?


Local testing strategy?

There's currently no way to start local dev server conveniently from the repo, maybe setup a Turborepo with a expo local test server + maybe a doc website in the future?
I think this project has great potentials and I'd love to contribute more to it!

Resolved by #5


Add Fig 3106, 3304, 3401 to docs/media + minor changes

In addition to adding/replacing figures in docs/median, this PR includes minor updates based on feedback from #441.

I'm working on Sebastian's PR right now so it'll be a little bit (~1 day maybe) before I can review this, but some other things I've noticed while trying to use the new clean_median_flux function:

I want to be able to set in the median_thresh parameter in the ECF
I want to be able to try without smoothing, so I suggest skipping the smoothing related steps if window_len <= 1 or window_len is None
I find it is important to smooth over masked pixels from the DQ array before smoothing and interpolating because some part of the smoothing/interpolating code does not appear to be aware of masked arrays and ignores the mask.

The local version of the code that I have come up with so far is:
def clean_median_flux(data, meta, log):
    """Computes a median flux frame that is free of bad pixels.

    Parameters
    ----------
    data : Xarray Dataset
        The Dataset object.
    meta : eureka.lib.readECF.MetaClass
        The metadata object.
    log : logedit.Logedit
        The current log.

    Returns
    -------
    data : Xarray Dataset
        The updated Dataset object.

    Notes
    -----
    History:

    - 2022-08-03, KBS
        Inital version
    """
    log.writelog('  Computing clean median frame...', mute=(not meta.verbose))

    # Create mask using all data quality flags
    mask = np.copy(data.mask.values)
    mask[data.dq.values > 0] = 0

    # Compute median flux using masked arrays
    flux_ma = np.ma.masked_where(mask == 0, data.flux.values)
    medflux = np.ma.median(flux_ma, axis=0)
    ny, nx = medflux.shape

    # Interpolate over masked pixels
    clean_med = np.zeros((ny, nx))
    xx = np.arange(nx)
    for j in range(ny):
        x1 = xx[~medflux.mask[j]]
        goodmed = medflux[j][~medflux.mask[j]]
        f = spi.interp1d(x1, goodmed, 'linear', fill_value='extrapolate')
        # f = spi.UnivariateSpline(x1, goodmed, k=1, s=None)
        clean_med[j] = f(xx)
    medflux = np.ma.masked_array(clean_med)

    # Apply smoothing filter
    if meta.window_len > 1:
        smoothflux = np.zeros((ny, nx))
        for j in range(ny):
            smoothflux[j] = smooth.medfilt(medflux.data[j], meta.window_len)

        # Compute residuals
        residuals = medflux - smoothflux

        # Flag outliers
        if not hasattr(meta, 'median_thresh'):
            meta.median_thresh = 5
        outliers = sigma_clip(residuals, sigma=meta.median_thresh, maxiters=5,
                              axis=1, cenfunc=np.ma.median,
                              stdfunc=np.ma.std).mask

        # Interpolate over bad pixels
        clean_med = np.zeros((ny, nx))
        xx = np.arange(nx)
        for j in range(ny):
            x1 = xx[~outliers[j]]
            goodmed = medflux[j][~outliers[j]]
            f = spi.interp1d(x1, goodmed, 'linear', fill_value='extrapolate')
            # f = spi.UnivariateSpline(x1, goodmed, k=1, s=None)
            clean_med[j] = f(xx)

    data['medflux'] = (['y', 'x'], clean_med)
    data['medflux'].attrs['flux_units'] = data.flux.attrs['flux_units']

    if meta.isplots_S3 >= 4:
        plots_s3.median_frame(data, meta)

    return data

Codecov Report

Merging #450 (e5f2847) into main (d586b6f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   58.49%   58.51%   +0.01%
==========================================
  Files          71       71
  Lines        7636     7638       +2
==========================================
+ Hits         4467     4469       +2
  Misses       3169     3169

Impacted Files
Coverage Δ

src/eureka/S3_data_reduction/optspex.py
45.24% <100.00%> (ø)

src/eureka/S3_data_reduction/plots_s3.py
92.39% <100.00%> (+0.05%)
:arrow_up:

src/eureka/S3_data_reduction/s3_reduce.py
92.47% <100.00%> (ø)

src/eureka/S3_data_reduction/straighten.py
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Station chosen!

We, G1, are planning to choose "Sand Island, Midway, United States (MID)" station. What about you guys?

we are trying to work with St. Davids Head, Bermuda, United Kingdom (BME) at the moment. Good luck with yours!


Excessive Memory Usage

ResNet-26 on CIFAR-10 (8.3M params) using your implementation without any changes fails to fit in memory in HAL and even on Colab - P100, T4 and P4. What was your system configuration for doing the benchmarks?

I have the same problem ResNet-26 on CIFAR-10. Running an RTX 2070 with 8gb graphics card RAM, I get the message:
Tried to allocate 308.00 MiB (GPU 0; 8.00 GiB total capacity; 5.08 GiB already allocated; 266.22 MiB free; 24.83 MiB cached)
This seems really odd. I would also like to know what hardware this was created on.

I have met the same issue, the memory seems never enough.

It uses about 13.00 GiB so if your GPU memory is less than that, you may get excessive memory usage problem. Maybe you should reduce the batch size to resolve this.

13 GB for a ResNet-26?

I don't know why it is so but this is how it looks like at the moment. Check the GPU Process 1

Holy cow. How did this pass muster? I don't have access to my cluster now but 13.6 gigs for a ResNet-26 is absolutely ridiculous. What's the use of such costly models?

I agree with you. This is very costly.

yes, this is too costly and slow to replace Convs.

This is ridiculous...I am using p2.16xlarge with 16 GPU and the CUDA memory is still not enough?

Have you all tried running the experiments with different batch sizes? I was able to run the default CIFAR10 experiments with a batch size of 8 using an RTX 2060. Total memory consumption was under 5 GB. On a more powerful machine with 32 GB V100 cards, I was able to run the default experiment configuration for CIFAR10 while using ~15 GB.

Have you all tried running the experiments with different batch sizes? I was able to run the default CIFAR10 experiments with a batch size of 8 using an RTX 2060. Total memory consumption was under 5 GB. On a more powerful machine with 32 GB V100 cards, I was able to run the default experiment configuration for CIFAR10 while using ~15 GB.

@iyaja
Hi Ajay, thank you a lot for your reply!
I am running it on the ChestXray dataset. It doesn't work with even a batch size of 1.
Could I ask how did you change the batch size? I do it via --batch-size=1.
What is weird is that the RuntimeError always stays the same no matter how small the batch size I set.
Setting batch size to 32, it says "CUDA out of memory. tried to allocate 25 MB"
Setting batch size to 1, it still says "CUDA out of memory. tried to allocate 25 MB".

Have you all tried running the experiments with different batch sizes? I was able to run the default CIFAR10 experiments with a batch size of 8 using an RTX 2060. Total memory consumption was under 5 GB. On a more powerful machine with 32 GB V100 cards, I was able to run the default experiment configuration for CIFAR10 while using ~15 GB.

@iyaja
Hi Ajay, thank you a lot for your reply!
I am running it on the ChestXray dataset. It doesn't work with even a batch size of 1.
Could I ask how did you change the batch size? I do it via --batch-size=1.
What is weird is that the RuntimeError always stays the same no matter how small the batch size I set.
Setting batch size to 32, it says "CUDA out of memory. tried to allocate 25 MB"
Setting batch size to 1, it still says "CUDA out of memory. tried to allocate 25 MB".

I also have no idea why it shows gpu_devices: None and gpu: None....Shown in my last image, it seems that all 16 GPUs are occupied.
Another weird thing is... When I was using 8 GPUs, it says CUDA tried to allocate 47MB. When I changed it to 16 GPUs, it says CUDA tried to allocate 25MB....Why increasing GPU just help that little...

I am trying to use AttentionConv on another model and I got a small Params size but got a super large Forward/backward pass size at the same time.
Why is Forward/backward pass size so large?

I am trying to use AttentionConv on another model and I got a small Params size but got a super large Forward/backward pass size at the same time. Why is Forward/backward pass size so large?

because it use unfold, it will bring huge gpu memory cost. The param is small... but intermediate featuremaps is very big.


offlineimap fails to launch becuase of missing configuration file

`diogo@PRO2:~$ lxc exec mailClienTest -- /bin/bash
root@mailClienTest:~# snap find OfflineIMAP
Name         Version  Developer     Notes  Summary
offlineimap  v7.2.1   snapcrafters  -      OfflineIMAP
root@mailClienTest:~# snap install offlineimap
offlineimap v7.2.1 from 'snapcrafters' installed
root@mailClienTest:~# offlineimap
ERROR:root: *** Config file '/root/snap/offlineimap/120/.offlineimaprc' does not exist; aborting!
diogo@mailClienTest:~$ offlineimap
ERROR:root: *** Config file '/home/diogo/snap/offlineimap/120/.offlineimaprc' does not exist; aborting!`

This is not a bug. offlineimap requires a configuration file in all packages. Create the file as requested, the documentation has an example. https://github.com/OfflineIMAP/offlineimap/blob/master/offlineimap.conf which should be as indicated, in $HOME/snap/offlineimap/current/.offlineimaprc


lax-mode + decreases clauses result in uninstantiated universes, leading to deep_compress-related error

Hi,
For a while, I've been running into the error Internal error: unexpected unresolved (universe) uvar in deep_compress when opening a module that uses lex_t
It seems that top-level definitions with such decreases clauses leave some universe variables uninstantiated.
The following module A imports module B. The first module declaration for B yields no error, while the three later yield the error about deep_compress.
module A
open B

module B

let rec j (n: nat): Tot unit (decreases (LexCons u#0 u#0 n LexTop))
  = if n=0 then () else j (n-1)

let rec f (n: nat): Tot unit (decreases (LexCons n (LexTop <: lex_t u#0)))
  = if n=0 then () else f (n-1)

let rec g (n: nat): Tot unit (decreases (%[n] <: lex_t u#0))
  = if n=0 then () else g (n-1)

let rec h (n: nat): Tot unit (decreases n)
  = if n=0 then () else h (n-1)

noeq type fake_lex_t =
  | FakeLexTop : fake_lex_t
  | FakeLexCons : #a: Type u#n -> a -> fake_lex_t -> fake_lex_t

let rec i (n: nat): Tot unit (decreases (FakeLexCons n FakeLexTop))
  = admit ()

module B

let rec f (n: nat): Tot unit (decreases %[n]) // or (decreases (LexCons n LexTop))
  = if n=0 then () else f (n-1)

module B

let foo (t:Type u#n): Type0 = True
let rec f (n: nat): Tot unit (decreases foo)
  = if n=0 then () else ()

module B

type foo: Type u#m = | FOO

let rec i (n: nat): Tot unit (decreases FOO)
  = admit ()

Since the error was introduced (on commit 97c7acadf70ca49f1285743870eb1d17f3bbd7b4), this issue reproduces on my side.
The issue was appearing only indirectly when I open a module; I think I remember modules are loaded in a sort of lax mode. Thus, I tried my faulty decreases clauses in lax mode, and the error appears directly, i.e., the following fails:
module Foo
#set-options "--lax"
type foo: Type u#m = | FOO
let i (n: nat): Tot unit (decreases FOO)
  = admit ()

So maybe it's type checking in lax-mode that somehow calls deep_compress without instantiating correctly some uvars on decreases clauses, what do you think?

Thanks for the report! I had observed this while bootstrapping F* with some local changes I have but couldn't find a small repro. This is probably the cause so it's great that you posted it. I think this is caused since the decreases clause is ignored in the computation of free variables in FStar.Syntax.Free, which can be fixed like this:
diff --git a/src/syntax/FStar.Syntax.Free.fs b/src/syntax/FStar.Syntax.Free.fs
index 1fa3c09d3f..77853c5f9b 100644
--- a/src/syntax/FStar.Syntax.Free.fs
+++ b/src/syntax/FStar.Syntax.Free.fs
@@ -198,8 +198,18 @@ and free_names_and_uvars_comp c use_cache =
               union (free_univs u) (free_names_and_uvars t use_cache)

             | Comp ct ->
-              let us = free_names_and_uvars_args ct.effect_args (free_names_and_uvars ct.result_typ use_cache) use_cache in
-              List.fold_left (fun us u -> union us (free_univs u)) us ct.comp_univs in
+              let decreases_vars =
+                match List.tryFind (function DECREASES _ -> true | _ -> false) ct.flags with
+                | None -> no_free_vars
+                | Some (DECREASES d) ->
+                  free_names_and_uvars d use_cache
+                | Some _ ->
+                  failwith "impossible"
+              in
+              let us = union (free_names_and_uvars ct.result_typ use_cache) decreases_vars in
+              let us = free_names_and_uvars_args ct.effect_args us use_cache in
+              List.fold_left (fun us u -> union us (free_univs u)) us ct.comp_univs
+         in
          c.vars := Some (fst n);
          n

But, this causes some crashes in regressions tests, for some reasons. I'll look more into it and report back.
Again thanks for the report!

Hello, @mtzguido  I find the deep_compress bug still exists when using the mutually inductive type!
For instance,

test.fst

type tlists = list tlist
val size_tlist_ok: tl:tlist -> Tot nat (decreases %[tl])
let rec size_tlist_ok tl =
  match tl with
  | Base _ -> 1
  | Llist l -> size_tlists l
and size_tlists (l:tlists) : Tot nat (decreases %[l]) =
  match l with
  | [] -> 0
  | hd :: tl -> let tn = size_tlist_ok hd in
    tn + size_tlists tl

valid.fst

module Valid

open Test

... fstar.exe valid.fst
(Error 339) Internal error: unexpected unresolved (universe) uvar in deep_compress

Now I find I even can not use the mutually inductive type
I get the issue if running the test.fst:
(Error 200) Unexpected number of universe instantiations for "size_tlists" (1 vs 0)

If I use the previous version, no this bug.

Hello, @mtzguido  I find the deep_compress bug still exists when using the mutually inductive type!
For instance,

test.fst

type tlists = list tlist
val size_tlist_ok: tl:tlist -> Tot nat (decreases %[tl])
let rec size_tlist_ok tl =
  match tl with
  | Base _ -> 1
  | Llist l -> size_tlists l
and size_tlists (l:tlists) : Tot nat (decreases %[l]) =
  match l with
  | [] -> 0
  | hd :: tl -> let tn = size_tlist_ok hd in
    tn + size_tlists tl

valid.fst

module Valid

open Test

... fstar.exe valid.fst
(Error 339) Internal error: unexpected unresolved (universe) uvar in deep_compress

Now I find I even can not use the mutually inductive type
I get the issue if running the test.fst:
(Error 200) Unexpected number of universe instantiations for "size_tlists" (1 vs 0)

If I use the previous version, no this bug.

Hi @nuaaysh , as Guido mentioned in the PR that fixes this issue, this code overlaps with some other work in progress that impacts the decreases clauses more broadly (see #1916). We would first push those changes, hopefully soon, and then I will pick Guido's commits to merge them into master.
As I understand from the discussion here and on Zulip, it seems like you are not blocked on it. Please let us know if you are and we can try to find a workaround or rejig the plan. Thanks for your patience as we sort it out!

Hi @nuaaysh , as Guido mentioned in the PR that fixes this issue, this code overlaps with some other work in progress that impacts the decreases clauses more broadly (see #1916). We would first push those changes, hopefully soon, and then I will pick Guido's commits to merge them into master.
As I understand from the discussion here and on Zulip, it seems like you are not blocked on it. Please let us know if you are and we can try to find a workaround or rejig the plan. Thanks for your patience as we sort it out!

Hello, @aseemr currently my question is solved, thanks a lot!

Hello, @aseemr currently my question is solved, thanks a lot!

Thanks for the fix and the explanation @mtzguido, your PR is indeed solving the issue on my side!

Thanks for the fix and the explanation @mtzguido, your PR is indeed solving the issue on my side!

I merged Guido's fix to master, closing this issue. Sorry for the delay.


Slack channel silently dropping long-running custom actions.

Rasa version:
2.2.0a1
Rasa SDK version (if used & relevant):
Not relevant
Rasa X version (if used & relevant):
Not used
Python version:
3.8.6
Operating system (windows, osx, ...):
Linux-4.15.0-47-generic-x86_64-with-glibc2.2.5
Issue:
I have a custom action that takes some time to complete.  It takes long enough that slack will close its connection with the rasa server, and send a retry request.  When this happens, the action fails silently.
Error (including full traceback):
The only clue as to the error comes from opening up the debugger in the middle of the server, e.g. calling breakpoint() here.  Then, if you wait a moment, then try to step over the return await self.process_message(..., you will get a stack trace and a line which reads:
asyncio.exceptions.CancelledError

Command or request that led to error:
Described above.
Content of configuration file (config.yml) (if relevant):
Not relevant - other than having a slack channel configured.
Content of domain file (domain.yml) (if relevant):
Not relevant
NOTE
I have a fix, and intend to discuss further issues not directly related to this in comments to my PR.

Thanks for the issue, @samsucik will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@samsucik Could you validate this problem?

@samsucik Could you validate this problem?

@wochinge in all honesty I'm quite busy and want to close some existing issues & projects first... Do you think that someone else could have a look?

@wochinge in all honesty I'm quite busy and want to close some existing issues & projects first... Do you think that someone else could have a look?

Mhm, you can ask in the product-support channel but I guess everyone is busy atm.

@nathan-chappell  re.

I have a fix, and intend to discuss further issues not directly related to this in comments to my PR.
what is your fix? Is it something that would be generally applicable, or was it only for a specific use case?

@melindaloubser1 Yea, I put in a PR a few months ago, with a (perhaps lengthy) discussion of the issue.  Bottom line is that there is an await in the code that shouldn't be there, there should just be the creation of a task on the event loop.  It's debatable whether or not this is really a Rasa issue, as basically one connection is closing an unrelated connection, throwing a silent error.
https://github.com/RasaHQ/rasa/pull/7526/files

Thanks for the link - looks like no one noticed the PR so far, sorry about that.


Allow framework users to navigate to an external URL using TurboNavigator

Exposing this function is a convenience so that, for common use cases, a framework user can open an external URL by using TurboNavigator, instead of implementing these functions themselves.
Session behavior when an external URL is found is unchanged.

@joemasilotti will merge this in as-is. If we decide on a name change, we can do another PR.


whitespace and quoting fixes in json and yaml examples

same as #3465.
My reading of https://github.com/OAI/OpenAPI-Specification/issues/3515#issuecomment-1925795442 is that this sort of update should be permissible in the 3.1.0 specification? If so, there are some other fixes in the 3.1.1 and 3.2.0 branches that should be backported also.

@karenetheridge the decision so far is to only accept changes to fix broken links, which aren't really specification content.  Or rather, the content is to point to a thing, and the thing moved, so the pointer needs fixing.
We did bring up fixing whitespace/formatting, but the decision was to not do it as no one wanted to argue over the boundaries of exactly what that entailed.

ok, closing.


Fix CodeQL workflow

The default config for the CodeQL scanner seems to break:

Complains about go not being in the code. (This is true untill we brin in lega-commander)
Fails at building java code. Needs manual configuration to get this to work it seems.

Fixed with commits 3e1ec94 and 13f2e1c.


wsl.exe command not recognized

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.19041.264]

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

Trying to install WSL following the guide Windows Subsystem for Linux Installation Guide for Windows 10. Command is not available.

What's wrong / what should be happening instead:

wsl.exe should be available.

You’re using 32-bit powershell. You’ll want to use 64-bit powershell, or specify the fully qualified redirected path to wsl.exe, c:\windows\sysnative\wsl.exe.

@DHowett That's it, thank you :).


fix(config): stop crash when logs written async

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
172

Relevant Lines:
172

💛  - Coveralls


Support AMI Event VarSet

Affect to the channel table.
Add the column variables.
"variables": {
  "key1": "val1",
  "key2": "val2",
  ...
}

Event: VarSet Example
Event: VarSet
Privilege: dialplan,all
Channel: SIP/agent-01-0000002b
ChannelState: 0
ChannelStateDesc: Down
CallerIDNum: agent-01
CallerIDName: <unknown>
ConnectedLineNum: <unknown>
ConnectedLineName: <unknown>
Language: en
AccountCode:
Context: public
Exten: 4000
Priority: 1
Uniqueid:<PHONE_NUMBER>.79
Linkedid:<PHONE_NUMBER>.79
Variable: SIPURI
Value: sip:agent-01@<IP_ADDRESS>:5060

Done.


fix: read conceal setting after sorting

Fixes #557
The explanation of the fix is that if format.conceal is true, then all offsets are set to 0 and then the matched pattern won't be the longest one (so if one types :lua, the pattern for ^: matches instead of ^:lua). Once sorting is done, then the offset is correctly applied based on format.conceal.
I manually tested this with and without concealing but I might appreciate a quick sanity check ;) @folke

Thank you for the PR! I'm leaving on vacation this evening, so won't have time to look at it till I'm back. End of August. Thanks again!

@folke no worries, enjoy your vacation! 🏝

@folke sorry for the ping, but are there any chances of having this merged soonish? :)

thanks!

@folke thanks to you! (for your patience with my endless issues and PRs to your plugins lol)


Hostname should be retrieved from postconf

Hostname should match the setting used by Postfix to remain consistent (and possibly to keep from leaking internal network information), so it should get the value from /usr/sbin/postconf -h myhostname instead of os.Hostname().  (Although os.Hostname() seems a sane fallback if postconf fails for any reason.)

I just want to make a quick comment noting I pretty much agree with this, although there's a few details to work out. I intend to look at this more in-depth and incorporate something for this fairly soon.

No problem.  Feel free to ping me if you need input.

I've implemented this in v1.1.0, thanks for reporting this.


Fix method to use local time in date handler

What is the context of this PR?
This changes date_handler.py to use now() instead of utcnow() when getting a referenced date. Previously when time was
between 12am and 1am the test was failing because of timezone difference.
How to review
New test was added. Run unit tests using make test-unit to check if the date is correct when test time is less than an hour to 12am in Universal Coordinated Time and local time is BST.

 Tests fail between 12am and 1am due to use of utcnow in date_handler.py (s)


Rewrite it in rust

Rust is blazingly fast and memory-efficient: with no runtime or garbage collector, it can power performance-critical services, run on embedded devices, and easily integrate with other languages.
Rust’s rich type system and ownership model guarantee memory-safety and thread-safety — enabling you to eliminate many classes of bugs at compile-time.
Rust has great documentation, a friendly compiler with useful error messages, and top-notch tooling — an integrated package manager and build tool, smart multi-editor support with auto-completion and type inspections, an auto-formatter, and more.

Too much work


[3634] Create and update trainee from Hesa XML based API

Context
https://trello.com/c/XzFdHeEl/3634-l-create-or-update-trainee-from-hesa-document-node
Changes proposed in this pull request

New parser to decode the Hesa XML into a more readable format
The beginnings of a new service to create/update trainees using the parsed Hesa data
New Hesa code set for training route mappings

Important business
~* Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?~
~* Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?~

 [L] Create or update trainee from HESA document node


⚠ SceneTime has degraded performance

In f1c6189, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1321 ms

Resolved: SceneTime performance has improved in e53219b after 6 minutes.


chore(grunt): use path.normalize in grunt shell:npm-install

This fixes the command on Windows clients.
cc @IgorMinar
Also needed for 1.3.x

lgmt. please backport to v1.3.x branch as well

Landed as https://github.com/angular/angular.js/commit/3bc429ad9f347139d09dceae6aeaaf7f16e08ddd and https://github.com/angular/angular.js/tree/v1.3.x