fix: handle partitions with empty table in read_parquet with dataset=True

When reading a set of parquet files with dataset=True, if the first partition is empty the current logic for dtype inference will fail. It ill raise exceptions as follows:
pyarrow.lib.ArrowTypeError: Unable to merge: Field col0 has incompatible
types: dictionary<values=null, indices=int32, ordered=0> vs
dictionary<values=string, indices=int32, ordered=0

To fix this, we filter out empty table(s) before merging them into one parquet file.
Note: I have only run the mock test suite, I can't easily run the suite against actual AWS services.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 778b386bd64ee5aae5ab77c278a4f0c07f05e212
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 778b386bd64ee5aae5ab77c278a4f0c07f05e212
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 1644f2dd8b1618e00461938b093ea26d55d99dce
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 1644f2dd8b1618e00461938b093ea26d55d99dce
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: f8ebab237be6718e60ede39e13ed04c59bac48dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: f8ebab237be6718e60ede39e13ed04c59bac48dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

I am bit confused about the way you are generating your partitioned dataset. Specifically this bit:
    for i, df in enumerate(dataframes):
        wr.s3.to_parquet(
            df=df,
            path=f"{s3_key}/part{i}.parquet",
        )

You are artificially creating the partitions instead of relying on awswrangler or pandas to do it.
When I rewrite your test with a proper partitioning call, the exception is not raised:
def test_s3_dataset_empty_table(moto_s3_client: "S3Client") -> None:
    """Test that a dataset split into multiple parquet files whose first
    partition is an empty table still loads properly.
    """
    s3_key = f"s3://bucket/"

    dtypes = {"id": "string[python]"}
    df1 = pd.DataFrame({"id": []}).astype(dtypes)
    df2 = pd.DataFrame({"id": ["1"] * 2}).astype(dtypes)
    df3 = pd.DataFrame({"id": ["1"] * 3}).astype(dtypes)

    dataframes = [df1, df2, df3]
    r_df = pd.concat(dataframes, ignore_index=True)
    r_df = r_df.assign(col0=pd.Categorical(["1"] * len(r_df)))

    wr.s3.to_parquet(r_df, path=s3_key, dataset=True, partition_cols=["col0"])

    result_df = wr.s3.read_parquet(path=s3_key, dataset=True)
    pd.testing.assert_frame_equal(result_df, r_df, check_dtype=True)

The difference being that in the code above, the files are written as a single dataset and the metadata for it is preserved

The difference being that in the code above, the files are written as a single dataset and the metadata for it is preserved

In that test example, there is no empty table written to s3 since you are concatenating the dataframes before writing to s3.
To trigger the error, the execution needs to go through https://github.com/aws/aws-sdk-pandas/blob/635f6d55b2ad1f77c9033cccee66c14f0b56e91b/awswrangler/_arrow.py#L33 with > 1 table, including one empty. That exception is triggered by some real parquet datasets created from spark. If that helps, happy to give details through our internal slack at amazon, including the dataset.

To trigger the bug, you need all of the following to be true

dataset=True
the datasets being read has more than one parquet file, with the first one read to be empty (order may not matter)
the s3 key must contain some partition so that awswrangler add the corresponding column(s)

When that happens, the underlying error is the type inference happening here: https://github.com/aws/aws-sdk-pandas/blob/main/awswrangler/_arrow.py#L41.
If a table is not empty, part_value will contain the right "type" for that added column partition. But if table is empty, you get a type that is independent of the value, e.g.
pa.array(["1"] * 0).dictionary_encode()
Out[4]:
<pyarrow.lib.DictionaryArray object at 0x7f63e97d9cb0>

-- dictionary:
0 nulls
-- indices:
  []

vs (no empty table)
<pyarrow.lib.DictionaryArray object at 0x7f63bda8eb20>

-- dictionary:
  [
    "1"
  ]
-- indices:
  [
    0
  ]

@jaidisido anything else I could provide to move this PR forward ? Happy to add more tests if needed

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 817028362f3c52351efa29e42c434aa9b94782d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 817028362f3c52351efa29e42c434aa9b94782d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 6ffa9f836356d250b46405e92fc77a07df3f36bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 817028362f3c52351efa29e42c434aa9b94782d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 6ffa9f836356d250b46405e92fc77a07df3f36bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 4996373e4952a6d43170f69d7c2ca35a6fe07d4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 4996373e4952a6d43170f69d7c2ca35a6fe07d4c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Direct use of bool in FFI is not advised

I double checked with the community discord before posting this, but basically rust's bool type shouldn't appear in FFI signatures directly, because different C ABIs treat it differently, and not all C compilers even have a real "bool" type.
I believe we should have all signatures go back to using bool updated to be a newtype over a u32.

I also checked with the community discord before deciding to use rust bool for this, and I was told it was fine in this case.

SDL asserts that sizeof(bool) == 1 at compile time for all targets in SDL_stdinc.h. If this assertion fails SDL won't compile.
If C99/C23 bool is used and is size 1, Rust's bool is binary compatible, using bit patterns 0x01 for true and 0x00 for false
Even if stdbool isn't used for some platform, SDL always uses its own defines for true and false instead of relying on type coercion on returns, so we should still be able to rely on getting only 0x01 or 0x00 from SDL

I'm sure the current setup is fine because we're mostly just returning bools from C into rust and then passing them around rust. There's a few places where they are passed from rust as args to C functions but I can't really imagine how they will be distorted.

Alright, if people don't see a point to it

I do think this is important, but unless I've been misinformed, bool works for this particular case, and bool is a better user experience.
The part about SDL asserting bool to be size 1 was crucial for this to work, so I don't think the information you were given conflicts with the information I was given if they didn't know about that part.
If I'm wrong, please reopen this issue.


Team Capes: Added Team cape renaming

Parses input to reassign team cape names.

if some of the input is invalid, just skips and continues parsing for other assignments. If the name is too long, it will keep it saved but output the max possible numbers of characters for the name to not clip with the cape count. Also slightly changed the client API's PanelComponent to make some positioning constants public, and added a getter for the width, to help make precise formatting. Built on top of my previous pull request implementing the minimum cape count.

Closing as this is very old PR now and has a lot of merge conflicts, reopen if you want to re-implement it.

Understandable. I won't be tackling this soon but if anyone wants to, there are now much better options available with RL configs than the csv format I'd initially done (well the option was always there, but not as easily accessible to those unfamiliar with creating UI from scratch in Java). I'd take a look at screen markers and copy the panel style they have, so you can add a new panel for each cape rename, containing simply a number input/combobox for cape#, and a string for the name. The csv format was fine in my opinion but for less technical users it would probably be odd/unfamiliar.


change optional to required dependencies

@eclarizio No, the build error is not related with our changes.


Discussion/mailinglist/forum?

Like martinellison said in  #1426:

(This is a support question; usually I ask support questions on a forum but gitea does not appear to have
a forum; apologies then if this is the wrong place, but please advise the correct place and update the
documentation).

I do not see any indication in the documentation about where support questions should go nor where I can follow discussions about the development of Gitea.

Probably on Gitter:
Join the chat: https://gitter.im/go-gitea/gitea

There's the GitHub issue, just the place we are.
Most of the team is active on Gitter. Room 1. Room 2.
There's a mailing list, but nobody uses it.
There's a #gitea channel on Gopher's Slack, but also nobody uses it.

I'd like to have a user forum actually. Other popular Go projects have one (Gogs, Hugo, Caddy, others), but it should have enough users to be worth.

Closing this as Gitea now links to discord as official chat (https://discord.gg/NsatcWJ), and forum (https://discourse.gitea.io/) on it's home page, docs, and blog (all in the theme, in the top nav bar)


How to migrate from 0.10 to 0.11

What do I need to change in this example to get it working, http://jsfiddle.net/vhb63d7h/ ?
It works with version 0.10.15, http://jsfiddle.net/qoz7fevL/

Got it working, http://jsfiddle.net/vhb63d7h/2/


Fix MD link to image in vs-ide-benefit.md

On the The Visual Studio IDE page, in Activation Step 2, there is a double quote that is closed prematurely (after the word 'Download'), which causes the image to not be shown correctly. The fix is to enclose the word 'Download' in single quotes, similar to what is done in Step 5.
This is a quick edit according to the Microsoft Docs contributor guide overview.

@YounesB-McGill : Thanks for your contribution! The author(s) have been notified to review your proposed change. @evanwindom

@YounesB-McGill : Thanks for your contribution! The author(s) have been notified to review your proposed change. @evanwindom

Looks good. Thanks for this fix @YounesB-McGill.


sfdx force:source:push hanging on job ID after dependencies deploy

Windows Version 10.0.15063 Build 15063
Python 3.7.3
CumulusCI 3.7.0
Running
cci flow run dev_org --org dev
flow hangs on:
Running command: sfdx force:source:push -u<EMAIL_ADDRESS>Job ID | 0Af0t00000SGJeGCAX
When I open the scratch org and look at the deploy status I can see the deploy succeeded. However no permissions were set for any of my objects or apps. Also none of my datasets are loaded.
I applied some of my managed permission sets to the User User and was able to get my application running (though not automated)
I thought this might be because of some branch work I was doing so I switched to my previously working master branch and that isn't working either.
Switched over to my laptop running CumulusCI 3.4.0 and was able to get a successful build.
My project:
https://github.com/tcdahlberg/Summit-Events-App

@tcdahlberg Can you be more specific about what you mean by the "flow hangs"? Did it silently stop doing anything? Did it exit with an error, and if so what error?
Can you try running the command (sfdx force:source:push -u<EMAIL_ADDRESS>on its own outside of CumulusCI and see if that gives any more clues? Maybe sfdx is outputting a message that CumulusCI is failing to relay to you.

No error. Just stopped at the Job ID and didn't progress. I have to end my terminal session to clear it out and be able to use cci.
the sfdx force:source:push works fine with no errors. There is nothing to push as the deployment when I look in the org says that it succeeded. The config_dev flow just never ran so objects and classes have no assigned permissions for System Admin. Tabs are not visible. The application I manage isn't visible. The dataset didn't load.
I just manually ran cci flow run config_dev and then everything worked. So, it is just not getting to that in the dev_org flow.
So, I am in a workable state at the moment but I don't have the flow automation I am used to.
Thanks for being so responsive!

@tcdahlberg Oh right, running the push command a 2nd time is not the same scenario since there's nothing left to push. It sounds like maybe the first push is successfully submitting the package for deployment, but then getting stuck waiting for confirmation that it finished. Could you try the following variation in a fresh scratch org?

cci flow run dependencies --org dev to install EDA and get ready for pushing your package
sfdx force:source:push -u SummitEventsDX__dev (replace dev if you named the scratch org something else)
That way we can see if sfdx gives any additional info on the first push to the org.

It may also be worth double-checking that your installation of the Salesforce CLI is up to date.

@davisagli , The sfdx force:source:pushed worked fine with no errors.
My Salesforce CLI is up to date (7.47.0-0e5d18732f). On my desktop I tend to be fanatical about updates to my downfall sometimes. There is one warning when I update the CLI that I have to admit I have been ignoring because things just seem to work.
warning "salesforcedx > @salesforce/sfdx-plugin-lwc-test ><EMAIL_ADDRESS>has unmet peer dependency "@oclif/plugin-help@^2".

@tcdahlberg hmm, ok, I'm not sure what's going on. I'll try to reproduce it with your project in Windows later this week.

@davisagli, thanks for the effort! I'm in a workable state at the moment with manually running through the flow so I can continue to develop.

I'm running into this issue as well.  More or less the same setup as above although on cci 3.8.0, and sfdx 7.50.0-9030e49cbb win32-x64 node-v10.15.3 (been updating both since we first starting to see this hoping it would be resolved before I needed to pay attention).
cci runs the dev org flow until it does the sfdx force:source:push and then it returns a job Id and hangs.  If I cancel it (^-c), and re-run the same flow the process completes successfully.  I have at least one other colleague on Windows reporting the same problem with similar versions.
Oh, and @tcdahlberg that sfdx unmet peer dependency warning happens on nearly every extension; I'm guessing it's a flaw in a tutorial someplace. The developers don't see it because the peer is in their copy as a dev dependency. It's a simple fix if the maintainer is open to PRs for example: https://github.com/eltoroit/ETCopyData/pull/41

Thanks @acrosman, I did fix that unmet dependency, but am still getting the hang after the job id. I have taken to using sfdx:force:open to open the org and make sure that the job ID deployment has fully deployed. Than I have to terminate the cci terminal session, open another session, and run the cci flow run config_dev --org dev to finish it up.
I was going to try this all out on another machine to make sure my environment wasn't corrupted but haven't had an opportunity. I can confirm after updating CCI to 3.9.0 and I still have the issue.

So far I've been able to confirm it's more complicated than just software versions or the project itself.
I had a colleague who was able to run our cci flow run dev_org --org dev successfully this morning.  He had newer Python (3.7.7) and newer Windows build (Version 1909 build 18363.720), but had CumulusCI 3.7.0. I've since updated both Windows and Python to match and continue to have the same problem.
Is there a good way to get a listing of all the versions of the various dependencies of cci?
I am also wandering if there are reasonable ways to help debug the exchange of information between CCI and SFDX to help spot the error in more detail.

@acrosman , @davisagli
I just set up my home computer for the obvious work from home reason. I used a newer version of python and windows then my work computer (which is tightly controlled when it comes to windows upgrades). I still experienced the hang on job ID after a fresh install of CumulusCI. My windows particulars:
Windows 10 version 1909 (10.0.18363 Build 18363)
Python 3.8.2
CumulusCI 3.9
sfdx-cli/7.50.0-9030e49cbb win32-x64 node-v10.15.3

@davisagli
I'm not set up to debug Windows but if its useful I could jump on a call with someone and see if we can add tracing information together which will shed some light on this.
It's also possible that cci flow run dev_org --org dev --debug would offer some insight, but its a bit of a long-shot.

I've been looking over package differences between my colleague who was able to get things to run smoothly and my own. I may have found a solution, although I hit my daily scratch limit just after I got it to run once, so I'm not totally convinced yet (it'll take a little while to setup another org for additional testing).
We ran pip list and pipx list on both systems. There were several package differences so I started to run them one-by-one.  I'm not sure this should make a difference, but figured it was worth a shot.
My copy of userpath was a version behind his, so I ran pip install userpath --upgrade and the next cycle of cci flow run dev_org --org dev worked.  I think I had deleted the org before I run the install, but it's possible I hadn't (which is why I wanted to do a second test).
If pip list reports userpath as less than 1.3.0 you might try updating it.  I also updated pipx which added click before I updated userpath so it may have been the combination (or I may be just plain wrong here).
I did try cci flow run dev_org --org dev --debug but the extra information wasn't terribly enlightening.
My current packages:
> pip list
Package     Version
----------- --------
argcomplete 1.10.0
click       7.1.1
distro      1.4.0
entrypoints 0.3
flake8      3.7.8
mccabe      0.6.1
pip         20.0.2
pipx        <IP_ADDRESS>
pycodestyle 2.5.0
pyflakes    2.1.1
setuptools  41.2.0
userpath    1.3.0

@acrosman , my userpath is 1.3.0 and pipx is <IP_ADDRESS> so they match yours. I am still getting the hang on jobid.
What's the format of your project? sfdx or mdapi? Mine is sfdx. Looking for clues.
I was curious when I ran debug a few lines before dx_push skipped update package xml and org_config.scratch. I don't pretend to understand the progression here:
2020-03-20 09:21:04: Skipping task update_package_xml (skipped when project_config.project__source_format != "sfdx" or not org_config.scratch)
2020-03-20 09:21:04: Skipping task deploy (skipped when project_config.project__source_format != "sfdx" or not org_config.scratch)
2020-03-20 09:21:04: ------------------------------------------------------------
2020-03-20 09:21:04: Running task: dx_push
2020-03-20 09:21:04: ------------------------------------------------------------
2020-03-20 09:21:04:
2020-03-20 09:21:04: Running command:  sfdx force:source:push -u<EMAIL_ADDRESS>2020-03-20 09:21:04: Options:
2020-03-20 09:21:04:   command: sfdx force:source:push -u<EMAIL_ADDRESS>2020-03-20 09:21:04: Beginning task: SFDXOrgTask
2020-03-20 09:21:04:
2020-03-20 09:21:04: Running command: sfdx force:source:push -u<EMAIL_ADDRESS>2020-03-20 09:21:10: Job ID | 0Af170000135w97CAA

@prescod  if you want to take on the task of troubleshooting I'd be willing to help with that. DM me on twitter if you are interested (same username on twitter).

Ours is also an sfdx project and provides more or less the same output as yours. Since one of my colleagues is able to run the flow I believe it's related to dependencies some place not the project itself.  But I'm guessing here since I cannot concretely say I found a solution.
I did notice that my python instance is all kinds of complicated by having ended up with both a 64 and 32 bit version kicking around, and pipx was really reluctant to switch over.  I had to uninstall cci, pipx, python37-32, delete pipx's settings in ~/.local, the 32-bit copy of all the libraries, and then it finally installed current versions of everything. From looking at the details it is pretty clear my previous setup was not clearly using one set of libraries I could trust the version numbers on.
Now I just need to get a new devhub setup so I can try to deploy again.

Can confirm now that the update of userpath and all the other updates I've tried did not indeed resolve the problem for me other anyone else on our team who has a problem.

Sorry to hear that! I'll try to get a support plan together in a meeting I
have this afternoon and get back to you.
On Fri, Mar 20, 2020 at 10:35 AM Aaron Crosman<EMAIL_ADDRESS>wrote:

Can confirm now that the update of userpath and all the other updates
I've tried did not indeed resolve the problem for me other anyone else on
our team who has a problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SFDO-Tooling/CumulusCI/issues/1579#issuecomment-601825857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFMS2RDVWRHTN5X63UDGLRIOSMJANCNFSM4K4NAUGA
.

Can you guys think of any way in which unusual Unicode characters could be involved? I remember a ticket like this that boiled down to a failure to parse UTF-8 coming from a subprocess.

@prescod hmm I can see how running in a terminal using cp1252 could lead to a UnicodeDecodeError when trying to decode the sfdx output as utf-8 (see cumulusci/tasks/command.py which the sfdx tasks are based on), but I don't see how it would simply hang.

Another hypothesis is that this relates simply to the amount of data being generated. If that's true, then a command like this might reproduce it:
cci task run command -o command 'python -c "print(name*100000000)"' > NUL:
(I think that's how to redirect to null on Windows)

@acrosman , @tcdahlberg :
Can you reproduce the bug with
cci task run dx_convert_from
If so, that might be a faster reproduction step! Before you run this, make sure that your /src directory is non-existent, empty or easily reverted!

cci task run dx_convert_from ran cleanly for me.
cci task run command -o command 'python -c "print(__name__*100000000)"' > NULL  appears to do nothing, but does allow me to break it cleanly.
I'm not aware of any UTF-8 mb4 characters, or really any beyond the standard base Latin characters.

@tcdahlberg @acrosman We think we've tracked this down, and we just released a possible fix in cumulusci 3.10.0. Could you try upgrading and see if it helps?

I just installed 3.10.0 and it appears to be working successfully.


Support for RPCS3 (+via Wine)..

Hi,
trying to run simple gs_gcm_basic_triangle.elf on RPCS3 running via Wine with Vulkan enabled I get an error..
log shows error is:
[MoltenVK ERROR] VK_ERROR_EXTENSION_NOT_PRESENT: Vulkan extension VK_EXT_debug_report is not supported.
Wine rpcs3.exe selected output:

[mvk-info] MoltenVK version 1.0.12. Vulkan version 1.0.77.
[mvk-info] GPU device:
model: AMD Radeon RX Vega 56
type: Discrete
vendorID: 0x10de
deviceID: 0x1d81
pipelineCacheUUID: 00000000-0000-0000-0000-27130000271C
supports the following Metal Feature Sets:
macOS GPU Family 1 v3
macOS GPU Family 1 v2
macOS GPU Family 1 v1
[MoltenVK ERROR] VK_ERROR_EXTENSION_NOT_PRESENT: Vulkan extension VK_EXT_debug_report is not supported.
0058:err:vulkan:wine_vkCreateInstance Failed to create instance, res=-7

Similar to #11.

Hi,
I renamed issue title to "support for RPCS3" as VK_EXT_debug_report is just the first issue I found..
really just wanted to say that seems "Vulkan Portability" devs are working with RPCS3 devs for Macos support and they are lifting a lot of requirements on their Vulkan code very fast like removing needed swizzle support of Vulkan implementation that would also likely help MoltenVK:
https://github.com/RPCS3/rpcs3/pull/4996
as you can see issues being fixed on both sides:
*Too many samplers are requested by a pipeline layout. Metal only supports 16 samplers per stage on all devices, while RPCS3 requested 20.
*Texture swizzling is (almost) not supported.
*Occlusion queries are missing.
*Buffers in HOST_VISIBLE memory with TEXEL_BUFFER usage are requested but not supported
also Macos related commits from RPCS3 side:
"vk: Implement double-buffered heaps for platforms without universal support for host visibility (APPLE)"
"vk: Support sw component swizzle decode because metal sucks "
as said before just pointing out in case somebody wants to work on this support..

RPCS3 has got a macOS version (that uses MoltenVK). Maybe this issue could be closed.

yep.. closing..


Title Bar Icon Color Not Being set Correctly When Using the Hover Editor

Before you open a bug report
Disable plugins and snippets that could be causing a conflict. Update to the latest versions of the following, and restart Obsidian:

Minimal Theme
Minimal Theme Settings plugin
Contextual Typography plugin

Confirm that the bug is not present when Minimal theme is off
Describe the bug
As I understand it, minimal now includes support for the Hover Editor plugin. When using the minimal theme, the hover plugin, and style settings plugin, if a "Titlebar active icon color" is set it is not used. Instead a different icon color is used. However the "Titlebar active foreground color" is applied correctly to the text in the titlebar. This used to work correctly so it seems to be an issue with a recent update.
To reproduce
In the Style Settings plugin, under Hover Editor, Title Bar Icons, set the "titlebar active icon color" to a specific color.
Expected behavior
The icons in the titlebar of the Hover Editor should be the color that is set using the Style Settings plugin.
Screenshots
For example, see this screenshot: the icons are not the color set in style settings:

Debug info (required):
SYSTEM INFO:
Obsidian version: v0.14.5
Installer version: v0.13.31
Operating system: Darwin Kernel Version 21.4.0: Mon Feb 21 20:35:58 PST 2022; root:xnu-8020.101.4~2/RELEASE_ARM64_T6000 21.4.0
Login status: logged in
Catalyst license: insider
Insider build toggle: on
Live preview: on
Legacy editor: off
Base theme: light
Community theme: Minimal
Snippets enabled: 7
Safe mode: off
Plugins installed: 19
Plugins enabled: 12
1: Minimal Theme Settings
2: Style Settings
3: Hider
4: Electron Window Tweaker
5: Icon Swapper
6: Footnote Shortcut
7: Dataview
8: Pandoc Plugin
9: Remember cursor position
10: Icon Folder
11: Hover Editor
12: Quick Explorer
RECOMMENDATIONS:
Custom theme: for cosmetic issues, please first try updating your theme to latest. If still not fixed, please try to make the issue happen in the help vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the help vault or disable community plugins.

I am not sure I understand what I am looking at in your screenshot. Why is the background of the titlebar blue?
The icons themselves are intended to use the same style as the pane's titlebar action icons. However I did notice an issue with the pin icon on panes that I just fixed.

I changed the active titlebar to blue and the active title bar text to white using style settings / Hover Editor / Title Bar Background / Foreground. That is working correctly. However when I make the color change for the icons, they do not change. It looks like they are being overriden by another icon style.

Hmm I am not able reproduce this issue. The icons do seem to respond to Style Settings for me. You need to use the "Icon color" setting, it seems like you are trying to use the "Icon color (active)" which is not used in this context

Yes, I am using the "Icon color (active)" setting under the Hover Editor title bar. I don't want to change the "icon color" for everything, just for the title bar of the hover editor.
Hmm. If the setting for the active icon color for the titlebar of the hover editor is not used in the title bar of an active hover editor, then what context is this setting for? Or why don't they simply follow the titlebar foreground color? Or is this a bug with the Hover Editor?
What's really interesting is that in another one of my Obsidian Vaults, the icons are colored correctly and it's coming from the color assigned to the titlebar:

The "active" color is used for active states such as the currently active sidebar tab. The style of the hover popover in Minimal is meant to mimic the normal pane style.
Based on the level of customization you are looking to do you should consider creating your own CSS snippet to modify these variables.

So the titlebar active icon colors are ignored by Minimal intentionally?

The active icon color variable represent the active state of the button to which the icon belongs, not the active state of a pane/window. In the context of panes/popovers, the buttons don't remain active after you use them, so the active state is not used.

I think I partially understand, but it would probably be helpful to retitle those settings so it's more clear. And I don't know if it's possible but it might reduce confusion to hide the settings for title bar icons when Minimal is the active theme because it doesn't appear to be used at all from what I can tell.
What is strange is that in one of my vaults, per the screenshot here https://github.com/kepano/obsidian-minimal/issues/259#issuecomment-1086681983 the icons do follow the titlebar color.


redirect "lbry.tv/lbry://name" to "lbry.tv/name"

Right now, if you go to the url beta.lbry.tv/lbry://name the app will crash. That isn't a valid url, we should redirect to beta.lbry.tv/name
This should happen in the ui server here: https://github.com/lbryio/lbry-desktop/blob/master/src/platforms/web/server.js#L7

i am on it

I am on it

@gagandeepp you'll need to do this in server.js.


Update maven plugin to <IP_ADDRESS>.v20151125

This should address the current issue in https://github.com/GoogleCloudPlatform/getting-started-java/pull/2 where an older version of the gcloud maven plugin cannot find the gcloud sdk.

Yep, this fixes the issue for me.


bored - did this

Little does help :)

Replace "swear / racist words" with "profanity"
Its a bit more professional @AlexHGaming

@FantasyIsBae Alright

profanity

@FantasyIsBae

Incoming megabyte

lmfao perfect time

xdd

Haha come discord


Add account entity

Added entites based on https://github.com/thenewboston-developers/Validator/blob/master/v1/accounts/models/account.py

Great work, left some comments via Slack

LGTM!


[ANDROID] Error while compiling

Hello after install i can't compile, getting this error.
/Users/dantecervantes/Documents/react-native/EM/CHM/club-house-now-mobile/node_modules/@yfuks/react-native-action-sheet/android/src/main/java/com/actionsheet/ActionSheetPackage.java:13: error: ActionSheetPackage is not abstract and does not override abstract method createJSModules() in ReactPackage
public class ActionSheetPackage implements ReactPackage {
       ^
1 error
:@yfuks/react-native-action-sheet:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':@yfuks/react-native-action-sheet:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details

any ideas?
RN version : 0.43.2
REACT version : 16.0.0-alpha.6

Hello !
As described in the readme
if react native < 0.47
npm install<EMAIL_ADDRESS>--save react-native link @yfuks/react-native-action-sheet


Make #[derive(sqlx::FromRow)] recusive

I have the following structs and schema:
#[derive(sqlx::FromRow, Serialize, Deserialize)]
pub struct Company {
    id: i32,
    name: String,
    #[sqlx(flatten)]
    contact_details: ContactDetails,
    #[sqlx(join)]
    users: Vec<User>,
}
#[derive(sqlx::FromRow, Serialize, Deserialize)]
pub struct User {
    id: i32,
    name: String,
    email: String,
    password: String,
    #[sqlx(flatten)]
    contact_details: ContactDetails,
    #[sqlx(join)]
    company: Company,
}

#[derive(sqlx::FromRow, Serialize, Deserialize)]
pub struct ContactDetails {
    phone: Option<String>,
    address_1: Option<String>,
    address_2: Option<String>,
    city: Option<String>,
    state: Option<String>,
    country: Option<String>,
    postcode: Option<String>,
}

CREATE TABLE company (
    id      integer PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY,
    name      varchar(120),
    contact_details jsonb
);
CREATE TABLE user (
    id      integer PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY,
    company_id integer DEFAULT NULL REFERENCES company(id) ON DELETE CASCADE,
    name      varchar(120),
    email      varchar(120),
    password      varchar(120),
    contact_details jsonb,
);
CREATE INDEX ON grant_user (email);

There are 2 actions that would be rather helpful. The first is that jsonb is able to be decoded directly to the struct field. Doing this via the flatten macro would generally match how serde_json works.
An example implementation I am currently using on the current impl contact_details: serde_json::from_value(row.get( "contact_details")).map_err(|e| sqlx::Error::Decode(Box::new(e)))?,.
The next action is joining two tables together. This is a bit trickier as the fields have similar names. The additional issue is circular references. To solve this, the addition of a lazy loading type is probably a good way to resolve the issue.

The first is that jsonb is able to be decoded directly to the struct field

We support this through wrapping the deserializeable type in sqlx::types::Json
#[derive(sqlx::FromRow, Serialize, Deserialize)]
pub struct User {
    id: i32,
    name: String,
    email: String,
    password: String,
    contact_details: Json<ContactDetails>,
}

#[derive(sqlx::FromRow, Serialize, Deserialize)]
pub struct ContactDetails {
    phone: Option<String>,
    address_1: Option<String>,
    address_2: Option<String>,
    city: Option<String>,
    state: Option<String>,
    country: Option<String>,
    postcode: Option<String>,
}

I would need to see how you expect sqlx(join) to be used. Can you show me a query and its results that would go into that type?

Does wrapping the deserializable type with Json work with the query_as! macro, as well? I'm trying that and receiving the trait sqlx::result_ext::ResultExt<sqlx_core::types::json::Json<...>> is not implemented for std::result::Result<std::option::Option<serde_json::value::Value>, sqlx_core::error::Error>

@kevlarr With 0.3 you need to use query_as_unchecked!. It will check for SQL semantic validity but will not check Rust <-> SQL types.
#397 will allow this in the normal query macros.

Ah perfect, thanks @mehcode! I was reading through some of the other issues and that merge request, but wasn't sure if that was the same. (Still new to sqlx.)

We now have #[sqlx(flatten)] which will be released in 0.6.1


By the way, can we also enable lazy loading for images embedded in posts?

Sure. However, this needs HTML rewriting. Do you mind submitting a PR?


add support of features vocab updating

We update the generator of features when update_vocab is activated.

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   64.69%   64.69%
=======================================
  Files          76       76
  Lines        6967     6967
=======================================
  Hits         4507     4507
  Misses       2460     2460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739daa9...d24c3ab. Read the comment docs.

Could we also update the embeddings of the features as well?

Thanks!


style: Improve Ammo Switcher Placement

The Ammo Switcher has an issue in the Favorites view especially. Depending on the length of ammo names, the dropdown will truncate the item name to an unreadable state. This is actually very easy for it to do and not the exception.

Consider creating a nested context feature for item table rows that allows for putting a contextual toolbar just below the colorized row and above the summary. Here is a rough example:

In the future, such a toolbar could be used for displaying other related, contextually relevant content.

Alas, the ammo switcher has met its end with dnd5e 4.x.
It was a great feature, but now we must abandon these dreams.


How do I tell HomeBridge to update when the state of one of my accessories has changed outside of homekit?

I have an MQTT light running on an ESP8266 which is registered as an accessory in HomeBridge.
Everything works great and I can turn it on/off, change brightness, and homekit can get it's current state when I ask Siri.
The problem I have is that if I change the light's state from outside homekit, e.g. I send an MQTT message from a switch or from a "node-red flow", how does homekit know the state has changed?
If I ask Siri "is the light on", it does query the accessory and get it's real state.
Also when I first launch the apple "home" homekit app, it seems to request the real state of the accessory at launch time.
But if i have the home app open on my iPhone, and then change the state of the light from the mqtt switch, homekit does not update, and so gets out of sync with reality.
Ideally from my accessory in homebridge, I'd like to subscribe to an MQTT topic so that if the light's state is changed (and the new value is published to the topic), then I can tell homebridge to update it's current state.
Does anyone know if this is possible?

Hi,
Take a look at:
https://github.com/cflurin/homebridge-mqtt
and
https://github.com/cflurin/homebridge-mqtt/wiki

Is there a way to access all accessories registered with a platform?

FWIW, this happens with WeMo lights, too. I have IFTTT configured to turn lights on at Dusk, the time of which actually changes from season to season. HomeKit doesn't support dynamic time triggers like this. Once IFTTT turns on my light, Homebridge doesn't know it's correct status.

I am just creating a plugin for Osram Lightify.
I currently use a global variable to keep the found accessories (which I like to have at the platform level). With polling I am able to change the state of the accessory if it was modified outside of home bridge.
Sent from my iPad

On 19.08.2016, at 20:28, Derek Moyes<EMAIL_ADDRESS>wrote:
FWIW, this happens with WeMo lights, too. I have IFTTT configured to turn lights on at Dusk, the time of which actually changes from season to season. HomeKit doesn't support dynamic time triggers like this. Once IFTTT turns on my light, Homebridge doesn't know it's correct status.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks cflurin, I quite like the way you've approached your mqtt plugin actually.
I had previously just written my own mqtt accessory, but I didn't think of using mqtt to add the accessory automatically, it works really well.
In addition I've now got homebridge updating it's state if I send my mqtt device a command directly (outside of homebridge) which is nice.
Many thanks.

Hi Jasonteale, how did you do that? I mean updating homebridge's state if you send my mqtt device a command directly (outside of homebridge). Thanks!


[Airflow]Fix remote log handler bug

What is the purpose of the change
Fix #172
Brief change log

Change the log_relative_path in remote log handler like S3, GCS, Azure when they init the context.
Add get_provider_info.py to pass airflow test cases.
Modified old test case in providers.

Verifying this change
This change has modified old test case to fit these new remote log handlers.

@aqua7regia , thanks for your contribution. I have checked all the log handlers and you missed the CloudwatchTaskHandler and ElasticsearchTaskHandler. Please add these handlers into this pull request.

Codecov Report

Merging #174 (c6be2a5) into master (723afa8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   59.37%   59.37%
=======================================
  Files         169      169
  Lines       13027    13027
  Branches     1684     1684
=======================================
  Hits         7735     7735
  Misses       4868     4868
  Partials      424      424

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723afa8...c6be2a5. Read the comment docs.


Feature Request:  Spark MapType mapping to BQuery

Hi Sam,
Firstly loving the library thanks! :)  Also enjoyed both your first blog post on the building robust pipelines (second post soon hopefully :) and your commentry on spark testing too on hangouts chat with Holden.  Spark testing is for sure challenging as Im finding, Im fairly new to spark / scala so finding my feet but enjoying it.  What is the best resources / examples for spark (scala) testing youve come across?
Unfortunately Ive been ill for the last week and have lost time on my project and wont be able to submit a PR for addimg MapType conversion to BQ to do it properly  anytime soon.(as mentioned Im quite new to this and not the quickest)  If you get time to do that it would of course be very much appreciated but understand you yourself are busy.   Otherwise I'll look at it in a few months time post go-live.
Anyway wanted to update you, say thanks and keep up the good work.
Kurt

You are most welcome! Thank you for the kind words and I will make sure to pass on your thanks to Holden
Unfortunately I am not free for the next month or so but I will share it in the twitterverse to see if anyone else would like to pick it up 😉

Cool no probs and also the kind words are deserved! :)  Enjoy your work and insight, hopefully one day not too far away I can get myself spark productive to contribute back.  In the mean time will continue to enjoy this library cheers!


run premerge checks for blaze builds

We already have a pipeline that checks bazel builds for every commit in main, would be great to enable this check for premerge too.
cc @GMNGeoffrey

My plan is to:

Add a new project on phabricator https://reviews.llvm.org/project/ "bazel"
Af diff author is a member of the "bazel" project, run a new step at premerge that will check if commit builds at "llvm-bazel" queue and fail build otherwise.

we should trigger build if "utils/bazel" is modified (without respecting the project membership).

@GMNGeoffrey here is an example https://reviews.llvm.org/D106955
user must be a member of https://reviews.llvm.org/project/profile/107/ or modify something under "utils/bazel/" to trigger the build.

Awesome, thank you! I'm going to set up some new agents to handle the increased traffic and then we can advertise this more widely.


Week1 varun iyer

Great Job Varun!! 🎉

Good job, closing the pull request since changes have been approved


MINIFI-290 Refactor Tests

Changes include:

Moving libminifi test resources to test/resources
Setting working directory when adding tests to ctest
so that tests can be loaded using a relative path
Moved YAML config test strings to test resources
Minor error log message correction noticed during testing
Tweak to ubuntu Dockerfile to fix docker build target

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

reviewing

Hey @kevdoran. This is certainly a lot cleaner and a much welcomed improvement.  Might you be able to rebase on the changes that went in recently for the updates to how configure is handled and take care of renaming YamlConfiguration while we are messing with it in this commit?
Thanks!

Thanks for the feedback @apiri. Will do

@apiri and @phrocker - requested changes have been made. let me know if there is anything else here

@kevdoran Thanks for rebasing/adjusting.  Will get this merged.

Saw that the Travis build for Linux failed.  Doing some additional builds/runs to make sure we're clear first.

I'll run some more linux tests as well. Should we look into configuring the CTests to dump verbose output on failures so we could get more information out of Travis?

@kevdoran that ticket already exists. It's part of another PR.

@apiri and @phrocker:
Here is the verbose test
-------------------------------------------------------------------------------
Test YAML Config Processing
  loading YAML without optional component IDs works
-------------------------------------------------------------------------------
/home/travis/build/kevdoran/nifi-minifi-cpp/libminifi/test/unit/YamlConfigurationTests.cpp:25
...............................................................................

/home/travis/build/kevdoran/nifi-minifi-cpp/libminifi/test/unit/YamlConfigurationTests.cpp:34: FAILED:
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

===============================================================================
test cases: 11 | 10 passed | 1 failed
assertions: 48 | 47 passed | 1 failed

1/6 Test #1: LibMinifiTests ...................***Failed    0.05 sec

It looks like this is failing for the same reason identified in MINIFI-304, which is resolved in @phrocker's pull request #96 [1]. Is that ready to merge?
[1] https://github.com/apache/nifi-minifi-cpp/pull/96

Hey @kevdoran,
#96 is now merged.  Would you be able to rebase and see if that solves the problem you were encountering before?

Will do.

@apiri @phrocker - update on this:
The approach of setting a hardcoded working directory when adding tests to ctest in the CMakeLists.txt file proved to be too brittle. If you invoke the test executable directly, it fails. After some exploration, I could not find a way to pass the resource location to the Catch unit tests in a manner that I was satisfied with. Two alternatives I explored included passing the location as an environment variable and passing it as a command line argument. The environment variable approach was a no-go as it it would require us to setup the "test" target in CMake using something other than enable_testing() and instead creating our own target, which seemed undesirable at this time. The argument approach would require us to define our own main for Catch unit tests, rather than using the #define CATCH_CONFIG_MAIN, and because #define CATCH_CONFIG_MAIN does more than just inline a main function, I didn't want to do that either in case assumptions made today break with other versions of Catch.hpp in the future.
The benefits here seemed minor, and could not justify the extra complexity introduced by the workarounds I explored (IMO), so I reverted the yaml config to being hardcoded inline strings. For now, I recommend closing MINIFI-290 as "won't do" and merge this PR which has a few other changes that I cam across while investigating this. Alternatively, we could move MINIFI-290 back to "open" if we want to revisit this in the future... but I'm sure if the need arises we would reopen it or make a new ticket.

@kevdoran thanks for all the thought process and rationale.  totally seems fair. will review the updates.  thanks!

Updated

@kevdoran cool, thanks will get merged!


[BEAM-9317] Fix portable test executions to specify the beam_fn_api argument

This allows for SDK level overrides when executing portable pipelines to occur.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @TheNeuralBit

Run Java Flink PortableValidatesRunner Batch

Run Java Flink PortableValidatesRunner Streaming

Run Java Spark PortableValidatesRunner Batch

Run Java Flink PortableValidatesRunner Batch

Run Java Flink PortableValidatesRunner Streaming

Run Java Spark PortableValidatesRunner Batch

Run Java Spark PortableValidatesRunner Batch

The Python failures are known to exist and are being fixed in #10856

The PVR tests passed, merging.


Update Readme.md

Corrected variable assignment of bodyParser to bodyparser.

Duplicate of #12

Thanks, landed on https://github.com/oauthjs/express-oauth-server/commit/2274bf1d2b1f5af1914e567502b523525a68ddb1.


Request Midnight Ghost Hunt

Game Title
Midnight Ghost Hunt
Game Website
https://midnightghosthunt.com/
Anti-Cheat Software
Easy Anti-Cheat
Status of the Anti-Cheat
⭐ Supported
Tinkering Steps
Works fine mostly altough some crashes when selecting perks (atleast for me) which can be fixed by disabling 'Show Tooltip Videos' under Options > Gameplay.
Proof of Mention
https://twitter.com/PlayMGH/status/1509950951398031367

What are the EAC Problems mentioned in the tweet?
Doesn't give the impression of Supported

That tweet was from before it was working at all. I haven't had any EAC issues with the game and most people on Proton DB agree. Maybe it only works on Flatpak like this Proton DB comment suggests and that's what they were referring too? But it runs on Steam Deck which correct me if I'm wrong but uses a form of distro steam.

(2 reports)
11 hours overall8 hours on Linux
2 months ago
Tinker Steps:Switch to experimental, Changed configuration
Have to run flatpak steam in order for EAC module to load. Also, need to disable 'Show Tooltip Videos' under Options > Gameplay to prevent crashing in loadout select menus. Works flawlessly after that.
Instability:Occasionally
Need to disable 'Show Tooltip Videos' under Options > Gameplay to prevent crashing in loadout select menus.
► Multiplayer
Overall (online):Excellent

That tweet was from before it was working at all. I haven't had any EAC issues with the game and most people on Proton DB agree. Maybe it only works on Flatpak like this Proton DB comment suggests and that's what they were referring too? But it runs on Steam Deck which correct me if I'm wrong but uses a form of distro steam.

(2 reports)
11 hours overall8 hours on Linux
2 months ago
Tinker Steps:Switch to experimental, Changed configuration
Have to run flatpak steam in order for EAC module to load. Also, need to disable 'Show Tooltip Videos' under Options > Gameplay to prevent crashing in loadout select menus. Works flawlessly after that.
Instability:Occasionally
Need to disable 'Show Tooltip Videos' under Options > Gameplay to prevent crashing in loadout select menus.
► Multiplayer
Overall (online):Excellent

Thanks.
The problem with flatpak is related to a glibc issue, it's currently being tracked in the "steam-overlay" repo

No problem. Thanks for the quick feedback and the website is great!. Should I close the problem or will you when you add it?

I'll close it once it's done ^^

Sounds good :D


When logged into Paideia, but not holding DAO tokens, provide good errors and disable buttons so the user knows they need DAO tokens

This is not completed
On Wed, Nov 9, 2022, 11:39 a.m. Viking Phoenix Consulting <
@.***> wrote:

Closed #539 https://github.com/ergo-pad/ergopad-api/issues/539 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/ergo-pad/ergopad-api/issues/539#event-7776708447, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUSIWPZPDDHXBWSPBT6RAILWHP4VVANCNFSM6AAAAAAROFFCC4
.
You are receiving this because you were assigned.Message ID:
@.***>


Foundry sanitizer cleanup

Align configuration from tools/bazel.rc  with sanitizer configuration on kokoro (simplifying the kokoro scripts and establishing single source of truth)
address https://github.com/bazelbuild/bazel/issues/6319 by introducing .bazelrc file in repo root
enable manual runs of sanitizers on foundry

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,997,540      Total (=)      1,997,540

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,021,899      Total (<)     11,021,901

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,014,439      Total (=)      2,014,439

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,113,681      Total (>)     11,113,673

 No significant differences in binary sizes

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,014,173      Total (=)      2,014,173

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,113,474      Total (>)     11,113,470

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,014,173      Total (=)      2,014,173

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,113,480      Total (>)     11,113,477

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences


override defaults

A couple of defaults I'd like to be able to override:

lower case strings: I'd like to preserve mixed case
use of - separator: I'd like to use _

Sound sensible. Would it be acceptable to have package globals to set things like separator or other default options?
We'd need to keep the current behaviour and make this optional of course.

This would be one way to achieve it which keeps the current behaviour by default and doesn't break the API

I had a think about this last year, and the reason I haven't done it is that it would make the interface not thread safe in a non-obvious way. You might be tempted to set the globals each time before calling the function, which would not be safe in a goroutine (i.e. in a server). The Separator might be safe as a global if it's clearly documented I guess, because you're likely only to set it once.
Re lowercase, I think better would be to add functions which preserve case, but I'm not sure on naming. I prefer to avoid mixed case in file names because of varying treatment on file systems like Mac OS or linux which can cause subtle bugs.
So on balance I'm going to close this one for the above reasons. Sorry it took so long and thanks for the suggestions.


Appstudio update test-component-pac-rprd

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-rprd-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
19 seconds
inspect-image

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
51 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
10 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
12 seconds
show-summary

Pipelines as Code CI/test-component-pac-rprd-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
19 seconds
inspect-image

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
51 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
10 seconds
label-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
12 seconds
show-summary

Pipelines as Code CI/test-component-pac-rprd-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
32 seconds
build-container

✅ Succeeded
13 seconds
inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
17 seconds
label-check

✅ Succeeded
16 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary

✅ Succeeded
4 seconds
show-sbom


Question: Any docs on setting up logging on client side?

I read the docs on Logging but it seems it is server side only?
I'm doing client connecting and there are occasions of 1006 error (as reported to me).
Can you help or point to example setting up logging on the client side?

Found it after a cup of coffee and waking up


Block edge 4.5.6

4.5.6 needs to be disabled:
3 clusters currently failing (14%),  1 gone ( 5%),and 17 successful (77%), out of 22 who attempted the update over 7d
Currently failing classification:
* Single master: 1
* Untriaged: 2
* Upgrade unsupported: 1

4.5.6 can be enabled again:
1 clusters currently failing ( 5%),  3 gone (14%),and 18 successful (82%), out of 22 who attempted the update over 7d
Currently failing classification:
* Untriaged: 1


Orchestrator relocation with gtid_mode = ON should be more flexible

I turned off pseudo-gtid on a cluster where gtid_mode = ON. Orchestrator sees this and was happy. However, when I tried to relocate some slaves under a different intermediate master it complained as being too complex. This is I think wrong.

Enclosed is a santised screen image of the error message I saw.
I was trying to drag the 2 slaves under server 2001 under server 1004.
With gtid this should be easy and I should be able to pretty much move any box under any box.
The only exception I see to this is if the slaves are missing gtid events which have been purged on the new master: that won't work so probably needs checking, but if the gtid event list is consistent this should work.
The example shown is using the latest code from github (or at last it's less than a week old).
Allowing this more flexible relocation would be good if GTID is being used.
Feel free to poke me if you need my configuration or further information.

I see this frequently where AUTO_POSITION=0 in SHOW SLAVE STATUS. Which means yours servers are GTID-enabled, but are not actually using GTID for replication.
orchestrator sees this as not-using-GTID and will not assume it is allowed to turn AUTO_POSITION on.
Can you please check if that is the case on your cluster?
I think this might be an interesting warning orchestrator can provide you with: "hey, you said you want to use GTID but actually your are not".


@JsonCodec(encodeOnly=true) causes a compiler error in Scala 2.13

When upgrading from Scala 2.12 to 2.13 am running into the following compiler error:
Usage of named or default arguments transformed this annotation
[error] constructor call into a block. The corresponding AnnotationInfo
[error] will contain references to local values and default getters instead
[error] of the actual argument trees
[error]   @JsonCodec(decodeOnly = true)
[error]    ^

The full import is io.circe.generic.JsonCodec.
What is the correct way to express this in Scala 2.13?
Note that I have set my compiler options to very strict (https://github.com/DavidGregory084/sbt-tpolecat/blob/master/src/main/scala/io/github/davidgregory084/TpolecatPlugin.scala) and all warnings (which this might be) are converted to errors.

Would you like an reproduction case for this?

Ok, I figured it out myself.
I had not added the scalac option `-Ymacro-annotations".
scalacOptions in ThisBuild ++= Seq("-Ymacro-annotations")

fixes it.

That's odd—I've forgotten that option a few times but have seen different error messages. Thanks for tracking it down, @leonardehrenfried.


Docker dev workflow needs to account for make prereqs step

https://github.com/Azure/acs-engine/pull/693 separated make prereqs from make build so dev dependencies didn't need to be downloaded/checked on every build. This breaks the Docker dev documentation at https://github.com/Azure/acs-engine/blob/master/docs/acsengine.md#microsoft-azure-container-service-engine
Rather than hack on the Docker run step or updating the current documentation, we might want want to regularly cut new acs-engine images.

Believe this done...


rootedAtAtom not found in atomsToUse when calling MolFragmentToSmiles()

Dear All,
Describe the bug
I have encountered an issue with MolFragmentToSmiles() function. I'm trying to generate the SMILES for each bit of the Morgan fingerprint for a given molecule. I am using the following code snippet in a jupyter-notebook.
from rdkit.Chem import AllChem as Chem
from rdkit.Chem import Draw
m = Chem.MolFromSmiles('OC(=O)C1=CC(O)=C(O)C(O)=C1')
info = {}
atoms=set()
for key in Chem.GetMorganFingerprint(m,radius, bitInfo=info).GetNonzeroElements():
     print (key)
     print('fp bit: ', info[key], ' and length is: ', len(info[key]))
     env = Chem.FindAtomEnvironmentOfRadiusN(m,info[key][0][1],info[key][0][0])
     print('Will use the atom: ', info[key][0][0], ' and radius; ', info[key][0][1])
     display(Draw.DrawMorganBit(m, key, info, useSVG=True))
     for bidx in env:
         atoms.add(m.GetBondWithIdx(bidx).GetBeginAtomIdx())
         atoms.add(m.GetBondWithIdx(bidx).GetEndAtomIdx())
     print('atom To Use: ', list(atoms), 'and rooted at atom: ', info[key][0][0])
     smiles = Chem.MolFragmentToSmiles(m,atomsToUse=list(atoms),bondsToUse=env, rootedAtAtom=info[key][0][0])
     print('Smiles is: ',smiles)

It generates the SMILES for first couple of bits, but afterward I get the following error.
RuntimeError                              Traceback (most recent call last)
<ipython-input-10-12a724ab569f> in <module>
     12         atoms.add(m.GetBondWithIdx(bidx).GetEndAtomIdx())
     13     print('atom To Use: ', list(atoms), 'and rooted at atom: ', info[key][0][0])
---> 14     smiles = Chem.MolFragmentToSmiles(m,atomsToUse=list(atoms),bondsToUse=env, rootedAtAtom=info[key][0][0])
     15     print('Smiles is: ',smiles)

RuntimeError: Pre-condition Violation
	rootedAtAtom not found in atomsToUse
	Violation occurred on line 609 in file Code/GraphMol/SmilesParse/SmilesWrite.cpp
	Failed Expression: rootedAtAtom < 0 || std::find(atomsToUse.begin(), atomsToUse.end(), rootedAtAtom) != atomsToUse.end()
	RDKIT: 2021.03.3
	BOOST: 1_74

However the Draw.DrawMorganBit() can produce the correct image of the bit fragment. Please also see an screenshot of the output below.

To Reproduce
Please see the python snippet above.
I'm not able to get why for some bits the rootedAtom are not in the atoms list. Could someone please let me know where am I making mistake or is it a bug?
Configuration:
Environment: RDkit version. rdkit 2021.03.3  installed via conda-forge
Python version: 3
OS: Ubuntu 20.04
Thanks in advance.

Hi. There are two problems here:

because atoms is defined outside your loop, you end up keeping the atoms from previous iterations in the environment
you need to be sure that the central atom (which ends up being rootedAtAtom) is in the atomsToUse list.
You can resolve both of these by moving the initialization of atoms into the loop and making it:

    atoms = {info[key][0][0]}

I'm closing this because it looks like the question is answered. Please reopen if necessary.

Hi, Thanks for the explanation. Indeed the issue is resolved.


cargo-llvm-cov: 0.6.2 -> 0.6.4

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Wrong hash?
$ nix shell 'github:matthiasbeyer/nixpkgs?ref=update-cargo-llvm-cov#cargo-llvm-cov' -c cargo llvm-cov
error: hash mismatch in fixed-output derivation '/nix/store/g9cbsypjjrallb1dsbm4naif3613r998-source.drv':
         specified: sha256-yXei86rj62il2kVdboOwfV6xW0q35H2CN4mHteNQzi4=
            got:    sha256-HPm++vsvyeeLkJfyjHPqmxfHv2/jque6B/4JXqTZ1UE=

huh, that's weird... for me it builds cleanly :eyes:

It fails in the same way for me on a different machine as well. Maybe it works for you because you have an old version of the FOD with a matching hash in your Nix store already? Maybe try setting all the hashes to the empty string and seeing if Nix gives you the same or different hashes as you try building again?

CI has probably the same issue... and you're absolutely right, I messed up the hash in one place. fixup incoming.


use ink IIP-2 selector

the wildcard selector in the proxy contract is currently hard-coded. We should use the one specified by ink instead in this issue: https://github.com/paritytech/ink/issues/1676
I couldn't access it in the current version of ink so we're waiting on further ink upgrades (currently 4.2 at time of writing)

Not blocked anymore. Moved to low priority, but ticket could also do with more elaboration - why should we use the one specified by ink


Not compatible with Unity 2020 (works with 2021)

Library\PackageCache\com.whisper.unity@9877bf753c\Runtime\Utils\MainThreadDispatcher.cs(13,63): error CS8124: Tuple must contain at least two elements.

The first error is related to the use of the new() construct:
private readonly ConcurrentQueue<Task> _actions = new();
Omitting the type in a new expression feature was added in C# 9.
I can suggest some workarounds:

Try to change the .NET version in the project settings
Fix incompatibility errors manually (preferably if point 1 didn't help)
Build this library in .NET Standard 2.0 and use the resulting .dll file

I made new PR to fix that. @chriswalz reopen this if you still have problems with latest version.

Thank you for this fix!


tutorial window

remove yellow arrow
remove yellow box
remove "disable the guide tour" aka "Don't show again"
position at the bottom, like the other windows
all passed circles should be filled
improve Header: "Which topic would you like"
Improve body: "The futuristic text boxes are subjects up for discussion. Click on them to join!"
Insert (centered) PNG showing a mouse cursor clicking a topic
(- For later: PNG could be be replaced by a GIF)

Please use a PNg with more zoom/less topics:

Header is missing question mark

Improved body: Click on the futuristic text boxes to discuss the subject.


add MarkupSafe==2.0.1 to install_requires

Originating Project/Creator

Affected Component

Affected Architectures(s)

Related Issue(s)

Has Unit Tests (y/n)

Builds Without Errors (y/n)

Unit Tests Pass (y/n)

Documentation Included (y/n)

Change Description
add "MarkupSafe==2.0.1" to install_requires in setup.py
Rationale
Fixes #48
Testing/Review Recommendations

pip install fprime-tools
Check MarkupSafe version by running pip freeze | grep MarkupSafe
If MarkupSafe version is 2.1.1, fprime-util --help may throw an error
Clone & cd into fprime-tools repo and checkout commit https://github.com/fprime-community/fprime-tools/commit/23c25be0f20de327dae12d67c82244faba41040c
Reinstall fprime-tools with python setup.py install
Rerun fprime-util --help

Has this error with newer versions of MarkupSafe been fixed in Jinja yet? It might be possible to just update cookiecutter, which could upgrade jinja to support the new version of MarkupSafe.

I am seeing a conflict here:  cookiecutter needs < 2.0.0 and this has marked specifically 2.0.1

Changed MarkupSafe==2.0.1 to MarkupSafe<2.0.0 in install_requires list in setup.py


No .exe, only python file, installation not clear at all.

Looks like a great idea but a Tkinter GUI would be fantastic.

Hi Ehtz, thanks a lot
The .exe is available in the releases section:
https://github.com/saschiwy/HeicConverter/releases/tag/v0.0.1
Let me know if you found it.
I wanted to use a script for automatization. But I would appreciate if you create a GUI via a PR.
Best Sascha

GUI Available with: Release v0.1.0


Fix indexing_query in update command

This will be one of a series of 2 or 3 PRs coming in today, and they will be my last of this summer. I would really appreciate if you could merge these and put out a release of bungiesearch by the end of the day on Friday - these are really tying up loose ends rather than major features. It's been a pleasure working with this project! I also wrote a celery signal processor for bungiesearch this summer as well, and you can check that out here: https://github.com/afrancis13/celery-bungiesearch. Feel free to take a look and use it/recommend it if you see a situation that fits the use case. I will make a second release of this as soon as the newest version of bungiesearch is released. Thanks for everything!

Previously, on update:
if hasattr(src.get_model_index(model_name), 'indexing_query')
Of course, this is never True, because 'indexing_query' never gets put on the model index, so you would need to do something like:
if hasattr(src.get_model_index(model_name).Meta, 'indexing_query')
However, to keep consistent with the project, I abstracted the detail of this into the indices.py document with _meta.

That's actually a good catch. I'll check the coverage tests which I added in just the other day to see how that wasn't caught in these.
As for your participation on this project, I really hope it's not over! You've contributed a lot or quality code and it's been a pleasure to see that people are using and contributing to this package.
I should be able to get those PRs dealt with quickly since I have a bit of spare time this week (hence my contributions to another open-source Web framework called Gin in Go). I'll check out your celery signal processor, we might even use it at Sparrho (we have a bit of a dodgy way to use celery with bungie search to make sure things are in sync).


Can't get vdebug working with neovim v0.2.2

Hi,
I have been trying to get vdebug to work with my neovim installation (v0.2.2) but I can't seem to get it working...
All my other plugins seems to work fine after switching from vim to neovim though... I think it has something to do with python support, but can't figure it out...
When I run :echo has('python') it returns 0 however.
Can anybody help me out?

Check the official docs for python+neovim: https://neovim.io/doc/user/provider.html#provider-python

I tried this but to no succes...   I also have a python version installed through my MAMP installation apparently... Could this be the problem?
I did both install commands like pip2 install --upgrade neovim .
neovim keeps giving 0 when I try :echo has('python')

I have no idea what MAMP is. But it sounds like a problem with neovim+python2 and whatever platform you use. It is not per se an issue with vdebug as vdebug requires :echo has('python') to print 1. Before that we can most likely not help you.

Thank you, your answer pointed me to https://github.com/neovim/neovim/issues/2193 which solved my issue.


Issue 96: Add new DefaultEnvironmentPlugin

Merge Checklist

[x] Have you linked this Pull Request to an Issue?
[x] Have you updated any relevant README files, to explain how this new feature works (with examples)?
[ ] Have you added relevant test cases for your change?
[ ] Do all tests and code style checks pass with ./gradlew check --info?
[ ] Have you successfully run your change in a pipeline in a Jenkins instance?
[x] Have you updated the CHANGELOG?

Codecov Report

Merging #97 (35465ba) into master (17f6756) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   86.40%   86.40%
=======================================
  Files          20       20
  Lines         250      250
  Branches       52       52
=======================================
  Hits          216      216
  Misses          1        1
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f6756...35465ba. Read the comment docs.


This seems to be broken..?

I just found this repository and wanted to give it a shot, so I grabbed a download link, replaced https://mega.nz with https://directme.ga and the screen is always stuck in "Direct MEGA - Please Wait..."
The download never begins.

I can't test it now, but from my tests it don't work well in Firefox as it
don't support creating readable streams.
There's a check testing if the browser supports it, IIRC in main.js. Maybe
this test is bugged: some browsers, like Safari, support creating streams
but those can't be used to initiate downloads, so it needs to blacklist
using user-agent detection. Well, it's a new feature in browsers so bugs
like those happen sometimes.
Can you investigate this? Check if the feature test is passing and if so
check developer console to see what's breaking the service worker. If it's
possible to fix it without blacklisting Firefox would be great, otherwise
we can blacklist it. You can send a pull request if you find a solution.

I wish I could, but I don't have a single clue about all this stuff, hahaha.. I'm just a guy browsing the internet.
Btw, I just checked directme.ga using Ungoogled Chromium and Google Chrome, and while the result that I got was different, it wasn't favorable either, sadly.
Instead of getting stuck in a never ending loading screen, the link just takes me to the download in MEGA.
What's even weirder is that I made a test file with notepad afterwards, uploaded it to my MEGA account, I tried to download it using directme.ga.. and the download worked correctly..?
Maybe the issue in this case is the file format..? The 1st file I was trying to download is a .7z compressed folder.

In Chrome it's working as expected: 7z files aren't supported because those here used to distribute malware. This website only support image, video and audio files. Of course, it's possible to distribute malware using image files, but it's harder as additional steps are required, like renaming files. By only allowing those kind of file I avoid getting this website into a blacklist (example, other website of mine got into McAfee site advisor blacklist because of this). Also, anyone is free to fork the source code and remove this check (just undo this commit).
But in Firefox it's not working as expected. I will try to find a fix for it, either downloading it (I only have Firefox 52 ESR, not latest version), or using some online cross browser testing tool.

I tested on Firefox 61.0.1 and 63.0 Nightly and on both the fallback version was used. Seems, from your screenshot that main.js ran but [fallback.js](https://github.com/qgustavor/direct-mega/blob/f1c01f2ca488d568e8ae6ae5b7082b84814ecef3/src/fallback.js] didn't. Maybe it was a network issue? I will put an error handler on main.js.

Closed because #21


update to newer alpine to fix vulns

The quay scanner has found some medium security vulnerabilities in our base StatsD image. I've verified that upgrading to the 9 version of the alpine-node image fixes this problem.
I don't have e2e tests for statsd, so I haven't actually tested functionality.

Superseded by #322.


Prettier

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
29

Relevant Lines:
29

💛  - Coveralls


everich, crocking

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[c,e]

/trunk merge


Domain Name

Hi folks,
Don't know how to reach you by email. I own the domain name vanillacomponents.com. It's expiring soon and you may have it. Email me at<EMAIL_ADDRESS>for info.
Thanks,
Robbert
DataGridXL

Thanks but i have 0 interest. The domain is not important in this project, thanks anyway.


Cannot build with lint turned on

To recreate just turn on lint for a sample application and try to run it.
Below is a link describing the steps to turn on lint in studio:
http://stackoverflow.com/a/27068675
The problem is with unused classes in the js.jar file:
../intermediates/exploded-aar/gvr-renderableview/framework/unspecified/jars/libs/js.jar: Invalid package reference in library; not included in Android: java.awt.event. Referenced from org.mozilla.javascript.tools.debugger.ContextWindow.

@danke-sra opened this issue to track the lint build problems.

@danke-sra manually deleting the unused packages from the jar file worked for me. Do you have a better solution?

I thought the warning could be suppressed from lint configuration file (xml?). Do you mean you've manually edited js.jar to fix the problem, or removed js.jar itself? If 'js.jar' has to be manually removed to suppress the warning, it's probably not the best. I found a way to suppress this specific warning in lint. If needed, I will check it.

Edited js.jar to fix the problem.
If we choose to go with lint.xml, then only providing one in the framework would not suffice. We would need to create one per sample project, which may not be desirable:
https://code.google.com/p/android/issues/detail?id=68808#c7

@rahul27 Can you please make a pull request for the updated js.jar? This seems to be the ideal solution.

@rahul27 Can we close this issue now?

Yup.


osd: drop support for device partition

We have been struggling with this, it's still broken and breaking other
things too now
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

jenkins test luminous-ansible2.3-dmcrypt_journal

jenkins test luminous-ansible2.3-switch_to_containers

jenkins test luminous-ansible2.3-bluestore_docker_dedicated_journal

jenkins test luminous-ansible2.3-bluestore_docker_dedicated_journal


2.35RC failing

I encountered a reproducible error with 2.35RC. This might belong also to stan-dev/stan or stan-dev/cmdstanr, but putting this now here. Sorry, I don't have time to prepare a minimal example. I've tested with the latest CmdStanR from github. The difference is whether I use cmdstan-2.34.1 or cmdstan-2.35.0-rc2.
R code to reproduce (requires cmdstanr, readr, dplyr)
library(cmdstanr)
# choose the version
#set_cmdstan_path("/u/77/ave/unix/.cmdstan/cmdstan-2.34.1")
set_cmdstan_path("/u/77/ave/unix/.cmdstan/cmdstan-2.35.0-rc2/")

powerindex <- readr::read_csv(url("https://users.aalto.fi/~ave/soccerpowerindex.csv")) |>
  dplyr::mutate(prior_score = as.vector(scale(rev(index))/2))
teamnames <- powerindex$team
worldcup2014 <- readr::read_csv(url("https://users.aalto.fi/~ave/worldcup2014.csv")) |>
    dplyr::mutate(team_1 = match(team1, teamnames),
         team_2 = match(team2, teamnames))
N_games <- nrow(worldcup2014)
gamenames <- with(worldcup2014, rev(paste(teamnames[team_1], "vs.", teamnames[team_2])))

#' Data for Stan
data <- with(
  worldcup2014,
  list(
    N_teams = nrow(powerindex),
    N_games = N_games,
    team_1 = team_1,
    score_1 = score1,
    team_2 = team_2,
    score_2 = score2,
    prior_score = powerindex$prior_score,
    df = 7
  )
)

stan_code="
data {
  int N_teams;
  int N_games;
  vector[N_teams] prior_score;
  array[N_games] int team_1;
  array[N_games] int team_2;
  vector[N_games] score_1;
  vector[N_games] score_2;
}
transformed data {
  vector[N_games] dif = score_1 - score_2;
}
parameters {
  vector[N_teams] alpha;
  real b;
  real<lower=0> sigma_a;
  real<lower=0> sigma_y;
}
transformed parameters {
  vector[N_teams] a = b * prior_score + sigma_a * alpha;
}
model {
  alpha ~ normal(0, 1);
  b ~ normal(0, 1);
  sigma_a ~ normal(0, 1);
  sigma_y ~ normal(0, 1);
  dif ~ normal(a[team_1] - a[team_2], sigma_y);
}
generated quantities {
  vector[N_games] y_rep;
  vector[N_games] log_lik;
  for (n in 1:N_games) {
    y_rep[n] = normal_rng(a[team_1[n]] - a[team_2[n]], sigma_y);
    log_lik[n] = log_diff_exp(normal_lcdf(dif[n]+0.5 | a[team_1[n]] - a[team_2[n]], sigma_y), normal_lcdf(dif[n]-0.5 | a[team_1[n]] - a[team_2[n]], sigma_y));
  }
}
"

model_2n <- cmdstan_model(stan_file = write_stan_file(stan_code))
fit_2n <- model_2n$sample(data = data, refresh = 0)

which gives with 2.35RC the following error
Error in !is.null(csv_contents$metadata$save_warmup) && csv_contents$metadata$save_warmup :
  invalid 'y' type in 'x && y'

The failure happens only if the model has been compiled with 2.35RC
Tagging #1266

Minimal example was posted in Stan discourse while I was writing this issue https://discourse.mc-stan.org/t/cmdstan-stan-2-35-release-candidate/35133/5

Yep I'm working on this today. CmdStan 2.35 is now returning true/false for default boolean argument values instead of 0/1, which is causing issues with our CSV parsing logic.
Transferring this to the cmdstanr repo


[Feature Request] Ability to turn on/off the feature altogether in a single click

I use the extension named Unhook as a "control panel" for Youtube. It allows me to turn off the feature on/off in one click which is very convenient at times.
Extension link: https://chromewebstore.google.com/detail/unhook-remove-youtube-rec/khncfooichmfjbepaaaebmommgaepoid
Screenshot (see the power button on the top right):
Extension in ON state

In OFF state:

I'd do it myself, but I'm currently pressed for time.

any updates on this?


Introduce command PRINTI to print integers

PRINTV prints integers in hexadecimal, PRINTI prints them in signed decimal. For example:
    PRINTT "Error at line "
    PRINTI __LINE__
    PRINTT "\n"

Fixes https://github.com/rednex/rgbds/issues/206
I know that this isn't a perfect solution. Ideally, we would have something like https://github.com/rednex/rgbds/issues/178, but that's quite tricky to implement in comparison.

Merged here: https://github.com/rednex/rgbds/commit/d243bd04ef929aa99158496c6f5fb048ec55ffa1


Add pyntree

Update Deepr-ai from pyndb -> pyntree as pyntree is the new, more supported version

Pyntree support was officially added in DeeprAI 1.0.3


Get neighboring objects in a single query

Use single query to retrieve connected {vertices,edges} instead of first getting ids and then doing individual request for each id. Achieves ~100x speedup for large connected sets.

Coverage decreased (-0.8%) to 78.114% when pulling b3cbc16020ec294bbdc0989279a427c2cd71655a on kensho:faster_neighbor_queries into d06f9179edc3e42a5828ea064f3f167b9b1912f2 on mogui:develop.

This PR is incompatible with OrientDB version 2.0 and earlier, which I propose is okay as:

the speedup gained in 2.1 and 2.2 is spectacular
the 2.1 series has been out for a year now, making 2.0 thoroughly obsolete.

Thoughts on this PR?

@mogui thoughts on dropping support for OrientDB 2.0 and applying this PR? OrientDB 2.0 is ancient and the 100x speedup is very worth it, I think.

Hi @obi1kenobi; the query strings etc. could be predicated on self.server_version. While I am inclined to agree 2.0 is ancient, it makes sense to support it when there's so little cost to doing so.

@TropicalPenguin thanks for your comment. Personally, I think there is real cost and very little benefit -- users of 2.0 can simply use an older (e.g. the current) version of pyorient. The cost comes in with unit testing and supporting the code in the future -- every caller of every function that switches behavior based on the server version as you suggest will now have to be tested on multiple different servers to ensure all of the exponentially-many variants still produce correct output.
At some point, one has to cut off support for ancient versions of a database and get those users to either upgrade their database or not upgrade their library. OrientDB 2.0 has not been the current version for nearly a year and a half, and it has known critical security issues. Nobody should be using it anymore, and if someone doesn't care that their database can get hacked, they probably don't care about the newest pyorient release either.

220451b suggests this is clear for merge; merging.


Use embedded video player

Instead of opening videos in a new tab, some users would prefer to view the video directly in the report.

Done.


buildPythonPackage does not seem to be verifying the sha256 checksum

Issue description
I was trying to add python-datetime_2_2 package to pkgs/top-level/python-packages.nix. To do that, I copied python-datetime_2_1 declaration, and changed the version in the name. I discovered that even if I did not correct the sha256 key, the package gets installed. For some reason, I can only use the keys from previous python-datetime_x_y packages -- see commented out shas.
Steps to reproduce
Apply the below patch, and run nix-env -f $MYPKGS -i python2.7-dateutil-2.2 this should install the correct version of datetime util. Now comment out the current sha, and uncomment one of the commented sha. If you try to unistall and install again, with the changed sha, it will allow it.
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 297dfae..07052a0 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -4750,6 +4750,29 @@ in modules // {
     };
   });

+  # csvkit 0.9.1 needs dateutil==2.2
+  dateutil_2_2 = buildPythonPackage (rec {
+    name = "dateutil-2.2";
+
+    propagatedBuildInputs = with self; [ self.six ];
+
+    buildInputs = [ pkgs.glibcLocales ];
+
+    src = pkgs.fetchurl {
+      url = "mirror://pypi/p/python-dateutil/python-${name}.tar.gz";
+      #sha256 = "02dhw57jf5kjcp7ng1if7vdrbnlpb9yjmz7wygwwvf3gni4766bg";
+      #sha256 = "1vlx0lpsxjxz64pz87csx800cwfqznjyr2y7nk3vhmzhkwzyqi2c";
+      sha256 = "0s74ad6r789810s10dxgvaf48ni6adac2icrdad34zxygqq6bj7f";
+
+    };
+
+    meta = {
+      description = "Powerful extensions to the standard datetime module";
+      homepage = http://pypi.python.org/pypi/python-dateutil;
+      license = "BSD-style";
+    };
+  });
+
   # Buildbot 0.8.7p1 needs dateutil==1.5
   dateutil_1_5 = buildPythonPackage (rec {
     name = "dateutil-1.5";

Technical details

System: 16.03.714.69420c5 (Emu)

Nix version: nix-env (Nix) 1.11.2

Nixpkgs version: "16.03.657.0c12bab"

This is standard (if unintuitive) nix behavior, if I'm understanding you correctly. fetchurl is a fixed-output derivation and really only cares about the output hash. It doesn't care where you got the content, as long as you have the correct hash (which makes intuitive sense, in a world with mirrors and spotty connectivity). When you copied the hash from another package, it looked to see if it already had that hash and just used it. For all it knows, you changing the URL was because that particular mirror was down.
One approach I've seen fetchFromGitHub take is to make the basename of the URL play a part in the final output hash, which makes confusing things like this go away, but costs us some flexibility.
Anyway, when copying around fixed-output derivation hashes, corrupt them a little (flip a non-zero digit to zero) before running a build.

I worked around in the manner you described, by corrupting the hash a little. I see what you mean. The hash is just used in a lookup, and fetched only if it is not already present.
Since this still seems a faulty behavior, I am wondering if one could check if there are multiple rules for fetching the same hash in the same config, and trigger an error if there is.

While I understand the issue (I've been bitten by it myself as well...) this isn't an issue of buildPythonPackage but, as @copumpkin wrote, Nix behavior. Therefore I am closing this issue.
If you want to discuss this further I suggest opening an issue on the Nix tracker.


Add support for solc 0.8.22

https://github.com/ethereum/solidity/releases/tag/v0.8.22

@Evalir

Tracking on https://github.com/alloy-rs/svm-rs/pull/97

Nope! should be closeable @pcaversaccio


timeline plugin: fuzzy/unclear/low resolution on some devices

On my laptop it's fuzzy, while it's fine on my phone.

The timeline for peaks.js and waveform-playlist don't suffer from this problem.

what kind of laptop? what version of wavesurfer.js?

Laptop: A (non-retina) MacBook running High Sierra, and a Windows 10 laptop.
Version: 3.2.0.

There's something about an extra pixel in the plugin: https://github.com/katspaugh/wavesurfer.js/blob/master/src/plugin/timeline.js#L336
can you adjust that and see if the issue is there. pixelRatio is being used in the plugin so it should take resolution in consideration..

Yes, that does improve it (I actually made that change before I made the PR, but forgot to mention that!), but it it's still not as sharp as the other two tools mentioned.
I'll do more looking when I get a chance.


Convert from forked to patched provider

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

[ ] Convert from a forked to a patched provider.
[ ] Archive pulumi's fork.

Introduced to resolve #309.


Added a prompt to restart the device

I forgot this when I used it for the first time, I hope you can add it.

you dont need to reboot


File Rotation Error - Monolog writing to the old file even after the max file size is reached

Hi Team,
I am using monolog for my latest PHP project and wanted to have a rotating file handler based on max file size and I came across your package and it was very valuable. I tested your code but I found a small error in the log-rotation when the max size is reached. The issue was when the PHP script was running and producing logs, the full PHP script output (until the script is finished) was still written to the old file even its size has gone past the max-size. However, for each successive PHP script runs, the rotations worked in the beginning and a new file was created and the outputs were each written to the same old file in each case. This implied the current file size check was not working before each record was written. I added two lines as follows (commented with "//I added this") into "src/Handler/monologRotatingFileHandler.php" in the "write" method as follows and the problem was ok.
protected function write(array $record)
{
clearstatcache(true, $this->filename); 	//I added this
	if(file_exists($this->filename)) {
		$fileSize = filesize($this->filename);
		if($fileSize >= $this->maxFileSize) {
			$this->mustRotate = true;
			$this->close(); 				//I added this
		}
	}
    parent::write($record);
}

Before each record is written, PHP should clear the stat cache with "clearstatcache()" when calculating the new file size, otherwise, the calculated file size at the beginning of the script will cache throughout the execution of the PHP script and files will never be rotated. I got this hint after analyzing log4php code for its "rollingFileAppender". Also "$this->close()" has to be included (which will rotate/archive the file and create a new one) before "parent::write($record)".
If you can verify this and update your code as above or someway better than this that you can think of, that will be great for others who might face the same issue when using this package.
Cheers!

Thank you for the feedback. I had a look at the bug and your suggested fix worked fine so i added it. 👍

That is good to know.
Cheers,
On Sun, 9 Aug 2020 at 08:38, sgoettsch<EMAIL_ADDRESS>wrote:

Thank you for the feedback. I had a look at the bug and your suggested fix
worked fine so i added it. 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sgoettsch/monolog-rotating-file-handler/issues/1#issuecomment-670981154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQPZ3UKCXOCKJ3Y5HNPPGDLR7XHXZANCNFSM4PT636OA
.


cleanup: simplify flagging of peers

Looks ok from my side, some high level comments:

A lot of tests got removed, are you sure they didn't contain any interesting test cases?
Removing timing information can make debugging slightly harder (e.g. have to find epoch in logs to know which wall clock time an epoch relates to)
This might need coordination with the admin UI team to update what is shown there. Do you know if this is the case @EthnTuttle, @okjodom?

A lot of tests got removed, are you sure they didn't contain any interesting test cases?

The tests were mostly testing the flagging of peers which has been simplified so far now that testing it seemed unnecessary, removing the tests also enabled me to remove the indirection where we had to calculate the consensus state in a separate function.

Removing timing information can make debugging slightly harder
I removed the timing because it is subjective to a peer. A peer that has been offline for a while will perceive a contribution as younger than it actually is. When debugging the consensus it tells us much more in which epoch / session and item has been submitted.


⚠ Guya.moe Proxied has degraded performance

In 73e9751, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 13455 ms

Resolved: Guya.moe Proxied performance has improved in d6afdab after 35 minutes.