set Playwright actionTimeout to 15 seconds

Playwright global config change to prevent exceedingly long timeouts when certain actions fail
e.g. button click

Or maybe we need to figure out why these tests need so long?

I'm afraid this change won't address those particular issues yet.  This will only tweak the test execution so that tests fail faster - (so I dont have to wait too long when rerunning builds).
Currently, actionTimeout is not specified, when a test fails on a particular action
e.g. clicking a button that is not ready to be clicked.
It will fallback to the test timeout (2 minutes)
I've also pushed some changes to:

enable the html report, this will give insight into which tests are slow.
enable screenshot on failure - for some reason the canvas does not render the lines in tracefiles.  Hoping the screenshot will capture the state of the canvas on failure

Okay, well I'm not sure exactly what's happening, but these 4 are consistently failing on this branch

So they must be related right, I've tried re-running the tests to make sure it's not a fluke.

some progress, I'm getting a different failure now after my most recent commit.  The most recent failure is on my list to fix.
  1) [webkit] › flow-tests.spec.ts:4165:7 › Sketch tests › Can delete most of a sketch and the line tool will still work

    Error: Timed out 10000ms waiting for expect(locator).toBeVisible()

    Locator: locator('[data-message-type="execution-done"]').last()
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 10000ms
      - waiting for locator('[data-message-type="execution-done"]').last()

       at test-utils.ts:49

      47 |
      48 | async function expectCmdLog(page: Page, locatorStr: string, timeout = 5000) {
    > 49 |   await expect(page.locator(locatorStr).last()).toBeVisible({ timeout })
         |                                                 ^
      50 | }
      51 |
      52 | async function waitForDefaultPlanesToBeVisible(page: Page) {

        at expectCmdLog (/Users/runner/work/modeling-app/modeling-app/e2e/playwright/test-utils.ts:49:49)
        at Object.expectCmdLog (/Users/runner/work/modeling-app/modeling-app/e2e/playwright/test-utils.ts:254:7)
        at /Users/runner/work/modeling-app/modeling-app/e2e/playwright/flow-tests.spec.ts:4200:13

I'll work on that first

Oh cool!
I think the failing macos playwright tests are related seeing some errors like TimeoutError: page.waitForEvent: Timeout 15000ms exceeded while waiting for event "console"
15000ms makes me think it's this. Should we increase the timeout? or increase it just for these tests?

I've extended the timeout for this particular call:
https://github.com/KittyCAD/modeling-app/pull/3115/commits/53fb96519de58d37cf6fbfaec1bbee0dea4e2171

https://github.com/KittyCAD/modeling-app/pull/3115#issuecomment-2257178830
^ these failures are longer occuring


Update crossterm to the latest version

This updates crossterm to the latest version. When I first did this in my fork I noticed that there was double button presses for everything so I looked into it and fixed the issue so I thought that I would contribute this change back to prevent others from needing to do the same debugging when updating crossterm to the latest version.

Would I update changelog? Seems like this change wouldn't be anything worth updating the changelog for.
Also it looks like this change increases the minimum required Rust version to 1.70 (from 1.66). Is that fine or do you prefer to keep things on this older version?


25% utilitization  - 2/8 cores

I have an Intel Xeon with 16 cores. It's running proxmox, 8 cores exposed to a container in a LXC (confirmed with /proc/cpuinfo).
This project/OpenVino is running on just 2/8 cores and top reports 25% utilization.
Is there any way to tell it to use all the cores available?

See https://github.com/bes-dev/stable_diffusion.openvino/issues/10#issuecomment-1232919688

thank you (closing)


raise valueerror after logging.error

Logging the error is useful for recording the event, but it doesn't stop the program from continuing, which might lead to further issues down the line.

solved with #68


Improve CLI use: enable passing arguments

Hi @0x80, I wonder if that could be a possibility, I am currently using isolate through cli, but I am not able to pass down any arg.
In case it makes sense, I am willing to help.
Thanks!

I'm open to it. It might make sense for some parameters. It was no priority for me because I didn't run into a situation myself where I felt like it would want to use them.
Most of the configurations are kind of set-and-forget I think, but I agree that it's unusual to not accept any arguments via CLI.
What would you suggest to use for arguments parsing? I am familiar with minimist and meow.

@0x80 Thanks for your reply. To provide more ctx: in our case, we are using it as part of the build script:
"build": "pnpm swagger:autogen & tsup && pnpm isolate"
It'd be useful for us to be able to pass down options here.
About your question: I've used cac before. It's pretty common to see it in action in well-established projects, but I really has no preference.
Leaving some refs:

https://github.com/chakra-ui/panda/blob/main/packages/cli/src/cli-main.ts
https://github.com/egoist/tsup/blob/dev/src/cli-main.ts
https://github.com/terai-labs/terai/blob/master/packages/dev/src/cli.ts

Could you maybe give me an example of the arguments you would like to pass during build?
I understand that arguments are useful if they differ between use-cases within the same repository, but I haven't been in a situation where I needed to change the configuration between build scripts or deployment targets.
If I understand more about your needs, then I can prioritize that maybe.

Sure, configuring "isolateDirName" and "logLevel" would be useful for me in that case

I'd like to isolate multiple packages from the root of a monorepo because of limitations with my build pipeline, and would also find passing CLI arguments useful. I'm willing to open a PR for this @0x80 ?

Hi @matthewaptaylor I can probably start working on this soon. I don't want to promise anything but it might be this week...
That being said, if you want to go for it, I'm open to PRs too. I briefly looked into some option (command.js, minimist, yargs, oclif, meow) and I think I prefer to use meow, because it's simple and sufficient. Also, I already use it in other projects, and it has no dependencies.


Support rotating keys with File#rewrite

The following Storage API method is not currently supported by gcloud-ruby:

objects.rewrite - Rewrites a source object to a destination object. Optionally overrides metadata. Can be used to rotate keys (see #722.)

@quartzmo, What's the status on the objects.rewrite operation?

@frankyn Thanks for re-surfacing this issue!
@blowmage Does anything block us from implementing this one?

Nothing blocks us AFAIK. Not exactly sure how involved it will be to implement, but it looks fairly big. Lots of settings that can be set in that operation, and it can involve multiple requests based on whether the file is a composite.

The Python client library currently has this implemented and here's a sample of their surface.

@frankyn Thanks!


Use OHM slippy map on OHM nominatim

Bug description
What is happening?:
when I visit nominatim.openhistoricalmap.org, I see the openstreetmap slippy map and not the OHM slippy map.
What should be happening?
I should be able to see the results of the nominatim search, which list what is in OHM, but the display doesn't show this.
Repro Steps
Steps to reproduce the behavior:

Go to nominatim.openhistoricalmap.org
Search on 'Kehl"
Click on any of the results
Note that you cannot see anything on the basemap.

Screenshots & URL

@jeffreyameyer this is true. We ticketed this a while ago when we setup nominatim https://github.com/OpenHistoricalMap/ohm-nominatim/issues/8
What's needed here is to fork the nominatim front-end code, and update the tile URL. But it's not super straightforward as we don't have a raster tile endpoint like the default OSM tiles. Though, we could replace the slippy map on nominatim website with a mapbox gl js and then use our vector tiles.
@danrademacher what do you think?

The Leaflet timeslider Demi we have might provide relatively readymade code to swap in GL inside Leaflet as the least invasive approach. I'll take a look

Hmm, OK, I looked into this some more, and here's my take:

Currently, we don't actually have a fork of Nominatim, we're just installing straight from OSM, but with our own database. This is great because it means we have one fewer fork to maintain.
If we want to have our vector tiles on our Nominatim, as Sajjad noted, we can't just replace this line of code for a new xyz template: https://github.com/osm-search/Nominatim/blob/master/settings/defaults.php#L97.
Instead, we'd need to mod the Nominatim website code. Simplest example would be to pull from the Leaflet GL timeslider demo, https://github.com/OpenHistoricalMap/mbgltimeslider-leaflet-control/blob/master/demo/index.html, though not sure we actually want a timeslider here.
Nominatim is a PHP application, and we'd have to root around a bit to see how we can best replace the map without making it overly difficult to stay in sync with upstream changes. It might just be a matter of hacking at this area of one JS file, https://github.com/osm-search/Nominatim/blob/f69c3d2b6674fe6624460e6a644d1f6e2cb2b415/website/js/nominatim-ui.js#L60-L63, but would need to experiment a bit and see.

I do find myself wondering a bit how important nominatim.openhistoricalmap.org is as a separate website. We need the service and application running to get search on openhistoricalmap.org, and it's nice to have this specific search and display system, but it also seems like Yet Another Thing to try to keep a fork aligned with upstream code.

Well... I think the important thing is something we haven't really
mentioned, which is including some sense of time in the search results.
That might argue for a different geocoder altogether... let's hold off on
this thread for a bit.
On Sat, Oct 31, 2020 at 9:54 PM Dan Rademacher<EMAIL_ADDRESS>wrote:

Hmm, OK, I looked into this some more, and here's my take:

Currently, we don't actually have a fork of Nominatim, we're just
installing straight from OSM, but with our own database. This is great
because it means we have one fewer fork to maintain.
If we want to have our vector tiles on our Nominatim, as Sajjad
noted, we can't just replace this line of code for a new xyz template:
https://github.com/osm-search/Nominatim/blob/master/settings/defaults.php#L97
.
Instead, we'd need to mod the Nominatim website code. Simplest
example would be to pull from the Leaflet GL timeslider demo,
https://github.com/OpenHistoricalMap/mbgltimeslider-leaflet-control/blob/master/demo/index.html,
though not sure we actually want a timeslider here.
Nominatim is a PHP application, and we'd have to root around a bit
to see how we can best replace the map without making it overly difficult
to stay in sync with upstream changes. It might just be a matter of
hacking at this area of one JS file,
https://github.com/osm-search/Nominatim/blob/f69c3d2b6674fe6624460e6a644d1f6e2cb2b415/website/js/nominatim-ui.js#L60-L63,
but would need to experiment a bit and see.

I do find myself wondering a bit how important
nominatim.openhistoricalmap.org is as a separate website. We need the
service and application running to get search on openhistoricalmap.org,
and it's nice to have this specific search and display system, but it also
seems like Yet Another Thing to try to keep a fork aligned with upstream
code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/issues/issues/157#issuecomment-720028039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALM4ETZ6MMIKSSVEXSTJGLSNTSYRANCNFSM4TEH5JKQ
.

--
Jeff Meyer
206-676-2347
osm: Open Historical Map (OHM)
http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page
http://www.openstreetmap.org/user/jeffmeyer
t: @OpenHistMap

I just remembered that we talked a long time ago (2018?) about trying to handle date-specific results client-side within openhistoricalmap.org — so ask Nominatim for all results, and then filter them on OHM.org.
So aim for an approach that reworks this Sidebar with JS to layer on date filtering to these results:

This approach would build on other sidebar work we have to do, and focus our code changes still on the website codebase. But it would still leave us with a nominatim.openhistoricalmap.org that's an incomplete OSM-ish experience, with OSM maptiles and no date filtering...

Closing per decision not to set up standalone nominatim.ohm.org - but, we still need to turn off the hyperlink in search results - new ticket coming for that.


WIP: compiling to wasm

I started an experiment to compile tantivy to wasm. These are some of the features I had to adjust to get it to compile.
The index writing doesn't work because it seems to be using std lib features that aren't supported by wasm target yet, such as std::threads. I can see from https://github.com/fulmicoton/tantivy-wasm that tantivy seems to have worked with wasm at some point with StaticDirectory which confirms that at least the index writing never worked in wasm.
Although there is no StaticDirectory in the current master, I don't see the Directory trait having changed since when it existed, so I could add it back. But I am a little stumped at how the DATA: &'static [u8] was generated. Would appreciate any pointers

The index writing doesn't work because it seems to be using std lib features that aren't supported by wasm target yet, such as std::threads. I can see from https://github.com/fulmicoton/tantivy-wasm that tantivy seems to have worked with wasm at some point with StaticDirectory which confirms that at least the index writing never worked in wasm.

Yes this is correct.
So for my small experiment, I just:

indexed things using a non-wasm program
merged all of the segments together.
wrote a small program to put the resulting segment in the static directory format.
included the resulting index file in the WASM program using include_bytes

(Of course this is not a good solution )

Hey @jonfk - thanks for the PR.
I have been hacking away on a WIP branch in my own fork. I followed Paul's earlier work on it, but haven't tracked upstream for a while. Have a look and let me know, if any of it is useful.
https://github.com/petr-tik/tantivy/commits/compiling_for_wasm

Thanks @jonk, I made some change your PR and merged it.

Thanks @fulmicoton for the quick work.
@petr-tik I will take a look at your branch. It seems like you are using a similar method to what @fulmicoton was using to generate the data to be served to the wasm. If we could add a serialization and deserialization scheme for the index so that we could have a better way to serve the index to the wasm.

If we could add a serialization and deserialization scheme for the index so that we could have a better way to serve the index to the wasm.

Can you be as explicit as possible about what you mean by serialization and deserialization scheme for the index?
Also do you need to index in web assembly or are you trying to serve a static index?

@fulmicoton Sorry for being vague about a serialization/deserialization scheme, it's just because I am not very knowledgeable about the inner workings of tantivy.
What I meant is some kind of defined format to transport the index. It could be json, protobuf, etc... which would allow some kind of client (here wasm) that could serve as the read only querying side of the index.
I don't know if that would be possible without breaking changes over time, which would really be a disadvantage of defining such a format.
My idea would be to implement a read-only Directory for wasm that would use indexeddb as the backing store to serve search queries.


replaced javascript library for java lib plus homespun code

As per our discussion #https://github.com/OHDSI/circe-be/issues/188 I've swapped out the javascript code for a pure java implementation. The java libraries available for semantic versioning don't have a readymade intersect function so I've written one myself (using some of the stuff the library did have)
There are some contraints, the original js library supported the full node semver syntax with tildes ~, carets ^ etc. for practical reasons this implementation only supports the basics as described in the Javadoc
To test the implementation I wrote a bunch of tests and checked the output of the new implementation against the old one, it appears to be working fine for the tests I conjured up.
If you can think of some kind of extra edge cases I did not test please let me know.

Ok, this is looking good to me, is there anything else you were trying to target or should I move forward with the PR?

I've updated the upstream master branch to make the next version 1.4.0-SNAPSHOT. can you sync your upstream fork and merge this PR with your forked master so you get the updated version?

@chrisknoll I've pulled in the changes and fixed the conflict

There was 1 issue that i found that broke 2 tests:
expected >=5.3.0 but was >=5.3.0

This is specifically related to PayperPlanPeriod where we define this CDM version range:
@CdmVersion(range = ">=5.3")

So, I can think of 2 ways to fix this, maybe we have to use fully qualified semver major.minor.hotfix version syntax where we use this, OR we make the semver utlity return the version range in major.minor.hotfix form which means to replace 5.3 with 5.3.0 (or basically fill in zeroes for missing parts of the major.minor.hotfix).
I feel like the latter is better option because it maintains backwards compatability about what the expected output is.   But if we don't want to change it in this repo, i'll have to update all the cdmVersion attributes in WebAPI to ensure they work off of a major.minor.hotfix format.

Or, Option 3: change the test, if we want to say that the test was wrong to reject the >=5.3 and make the test consider >=5.3 the correct response.

Principally I would say if you provide >=5.3 and it returns >=5.3 then that is completely accurate, can't really argue with that :-)
But if a three part version is always expected downstream I guess that is what should be provided...
At the same time it seems that OHDSI currently prefers two part version numbers (3.0, 5.3, 5.4, 6.0) but in the past they also had a 5.3.1 version... As this is an OHDSI specific library it should probably conform to OHDSI preferred standards, but to be honest I'm a bit confused what those are :-)
All in all I don't really know what is the best way forward, maybe Anthony has some words of wisdom in todays meeting.


Enable MCP by default in helm values and e2e tests

This PR inverts the default helm options so that MCP is enabled by default. For the time being users can still disable MCP to compare performance and functional behavior with MCP.
The MCP and non-MCP e2e tests have also been inverted so that the full test suite now runs with MCP enabled. A subset of e2e tests are run w/o MCP as a reference for flakiness.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-mixer-no_auth-mcp

prow//e2e-simpleTests-minProfile.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ad8d7c63f3c21140c11e1ae18ece618a53b93d65
link
/test e2e-mixer-no_auth-mcp

prow//e2e-simpleTests-minProfile.sh
a0ae44fe892d794bc6aa3b62e7fb7f99f55cad8d
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @hklai, all tests are green now. Once this is merged, we can merge https://github.com/istio/test-infra/pull/1077 and then create a follow-up PR in istio/istio to remove the *-mcp.sh variants.

update circleci so that the galley and non-mcp tests are mandatory.
why do we need to run 2x in circleci? can't we simply test only with mcp?

why do we need to run 2x in circleci? can't we simply test only with mcp?

How about we run non mcp in circle periodic only?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

How about we run non mcp in circle periodic only?

Done - circleci non-MCP tests are only run periodically. The prow tests will be updated in a follow-up test-infra PR

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
2a1f7ce406c854862f4fea75cb19e6caa1abedbe
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Removes some unnecessary awaits

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0@7a5a973).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5a973...34041cd. Read the comment docs.


Playground client not accessible remotely

This issue came up while taking part in the pioneer program

On MacOS there seem to be numerous issues with compiling the English Auction contract. Instead of trying to resolve those, I moved to a Debial10 hosted on GCE. I got the contract compiled and the playground server/client started.
However, because this is a remote machine I cannot access the playground-client on: https://localhost:8009
Instead, I'd like the playground-client to bind to <IP_ADDRESS>, so that I can use the remote IP.

CrossRef: https://github.com/input-output-hk/plutus-pioneer-program/issues/3
Diagnostic info:

I was using the:

[x] Plutus Playground

Adding host: "<IP_ADDRESS>" in plutus/plutus-playground-client/webpack.config.js seems to work ...
    devServer: {
        contentBase: path.join(__dirname, "dist"),
        compress: true,
        host: "<IP_ADDRESS>",
        port: 8009,
        https: true,
        proxy: {
            "/api": {
                target: 'http://localhost:8080'
            }
        }
    },

Not sure if this can generally be done to go forward.

For security reasons, defaulting to 0000 seems not good

I spent a long time tweaking my router and firewalls before realising it was a webpack issue: https://webpack.js.org/configuration/dev-server/#devserverhost

One can also SSH tunnel from the cloud to the local machine with something like:
ssh -i xxx.pem -N -L 8009:localhost:8009<EMAIL_ADDRESS>
To access the client through https://localhost:8009 just fine.

I think we can close this


Avoid using aliases

Example 4 would be better if it did not use aliases
Get-UnifiedGroup | where-object { -not ($_.ManagedBy) }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d063d71b-c1d5-e995-9e0d-a3daf646c712
Version Independent ID: 7cff679f-a994-e371-a227-b8c5635f1aa2
Content: Get-UnifiedGroup (exchange)
Content Source: exchange/exchange-ps/exchange/users-and-groups/Get-UnifiedGroup.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@dariomws  Thank you very much for the contribution and updating the documentation with PR. @AspenForester Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


circular select doesn't change look after selection

ahh good catch, it'll probably take me a while to get to this one unfortunately.


Support is-supported-script expression

Closes https://github.com/greensopinion/flutter-vector-map-tiles/issues/113.
I have tested this on a variety of complex shaping scripts such as Nepalese, Burmese, and Khmer, as well as RTL languages such as Arabic and Hebrew. These are the standard problem cases for text rendering, and it appears to pass as a result of not using SDF glyph rendering like most other "modern" renderers, which is pretty cool! As such, the implementation turned out to be pretty simple.

The contribution looks great. One of the checks failed, please resolve the formatting issues: https://github.com/greensopinion/dart-vector-tile-renderer/actions/runs/3993332817/jobs/6870719716

Sure thing. Just ran flutter format . and pushed the changes @greensopinion.

There are some failing checks see details
those will need addressing before we can merge this contribution.
You can run those checks locally on your machine by running the commands listed here: https://github.com/greensopinion/dart-vector-tile-renderer/blob/main/.github/workflows/CI.yaml

Thanks for the link. GitHub CI is a bit opaque since it doesn't run checks without manual approval apparently :joy: Sorry for all the back and forth as a result.

Just a quick bump on this ;)


README.md: Added link to latest release

Added link to version so that it automatically points to the latest project release with reference to #124

2.0.4 is not the latest release anymore. Anyway, thanks for the suggestion though. :) But I won't merge it as the version lacks behind.

Hi @rrooij the link https://github.com/terminusdb/terminusdb-server/releases/latest will automatically point to latest release. E.g. If you open the link in the browser, as of now it automatically redirects to v2.0.5. So having a link like that will help as you wont have to these changes again!

But the link text won't automatically change right? @rahuldeepattri


chore(deps) bump OpenSSL to 1.1.1f

should resolve https://www.openssl.org/news/secadv/20200421.txt
changelog: https://www.openssl.org/news/changelog.html#openssl-111

@hutchic the title and commit message refers to f while it should refer to g. Just to point out before it gets merged.


Adding jboss-ejb-iiop_1_0.xsd to ejb project satisfying numerous PR

https://bugzilla.redhat.com/show_bug.cgi?id=1192591
Upstream: #85
Moving jboss-ejb-iiop_1_0.xsd out of WILDFLY and putting it into metadata proper.

Has been taken care of in different PR.


(feat): smb chart

Details
Helm chart name:
samba
Describe the solution you'd like:
would be nice to have also samba chart, this will replace need of freenas, omv or samba standalone package ( multitenancy and ha will not work tho, but its ok for home usage ) ..
related:

https://github.com/kubernetes-csi/csi-driver-smb/tree/master/deploy/example/smb-provisioner
https://gandazgul.github.io/k8s-infrastructure/charts/samba/

Anything else you would like to add:
no
Additional Information:
no

I'll see if I can whip something up in the coming days. Currently already running it as a deployment/service, so should be able to get it working 😄

Closing this issue. An initial version has been released via #477 .
We can iterate on that if required. If so, we should maybe collect some ideas first through the Github Discussions pages.

Closing this issue. An initial version has been released via #477 .
We can iterate on that if required. If so, we should maybe collect some ideas first through the Github Discussions pages.


Ubuntu LTS 16.04 Build Failure: cannot find package "context"

make all, and make crictl both fail when trying to make, and install this package. The issue is that package context is missing. Would like a workaround that doesn't involve installing a new version of go on an LTS Ubuntu.

@ecarew I think your golang version is too old. :(
If you really don't want to install new golang, use a golang container to build the binary.

Yep, Go 1.9 or above is required to build crictl. You could also download crictl from release page https://github.com/kubernetes-incubator/cri-tools/releases/tag/v1.0.0-alpha.0.

@ecarew Feel free to reopen it if you still have issues.


docker: url-encode username and password

Fixes #60

Thanks a lot for your help, latest version of the Docker image along side with Helm package were released as 0.2.0-2 🎉


Mark deprecated options

It should be possible to mark options as deprecated.
WebPConvert::getConverterOptionDefinitions() should not return deprecated options

Related to #279


Update test-infra: get rid of Unbound variable running update-deps wa…

/retest
On Fri, May 17, 2019, 9:16 PM Knative Prow Robot<EMAIL_ADDRESS>wrote:

@chaodaiG https://github.com/chaodaiG: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-knative-observability-integration-tests eb5ea32
https://github.com/knative/observability/commit/eb5ea32691bd214626c5bf4cf21dc47d946a3eaf
link
https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_observability/28/pull-knative-observability-integration-tests/1129597696953290753/ /test
pull-knative-observability-integration-tests
Full PR test history
https://gubernator.knative.dev/pr/knative_observability/28. Your PR
dashboard https://gubernator.knative.dev/pr/chaodaiG.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knative/observability/pull/28?email_source=notifications&email_token=AKXNDYOBUUV5TRAULGZI5NDPV57LPA5CNFSM4HNZO5ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWHH4Y#issuecomment-493646835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKXNDYLCPL53CLA6HCA3ULLPV57LPANCNFSM4HNZO5ZA
.

/test pull-knative-observability-integration-tests

/lgtm

/approve


Add HasResponded for interactions

Description
It would be welcome that instead of trying to make an API call and checking if it throws an exception, we can check inside the interaction if it has been responded to or not. For example:
try
{
  await interaction.SendResponseAsync(InteractionCallback.ChannelMessageWithSource(message));
}
catch (RestException restException) when (restException.StatusCode == System.Net.HttpStatusCode.BadRequest)
{
  await interaction.SendFollowupMessageAsync(message);
}

could be replaced with:
if (!interaction.HasResponded)
  await interaction.SendResponseAsync(InteractionCallback.ChannelMessageWithSource(message));
else
  await interaction.SendFollowupMessageAsync(message);

Quoted from Kuba

it's not possible to create interaction.HasResponded because everybody can use RestClient.SendInteractionResponseAsync(...)

Closing with this conclusion.


Revised bundle name detection in AbstractFxmlView.getBundleName()

Previously getBundleName() always returned the value from
FXMLView#bundle attribute, due to testing the annotation instead of
the bundle-name for being empty.
We now correctly test the configured bundle-name. If the bundle name is
null we or empty we derive the bundle name from the classname.
Otherwise we use the value as is.
Fixes #38
Can be backported to 1.4.x

Coverage increased (+1.1%) to 39.098% when pulling d1fc66e3baf98a8c7969e1bfe81527b705dfd68a on thomasdarimont:pr/issue-38-fix-getBundleName into 55885ce4124f00dce0fc4bb0da4750c16b879930 on roskenet:master.


Update documentation based on feedback

Specific feedback:
"""
A suggestion for the README.md for tapis-status would be to specify that the JWT is for an individual user inside the tenant, not for the tenant API.  Similarly, authn_username is for an individual user inside a tenant, and not the tenant's name (e.g., not "dev")
"""

Updated main with these changes.


fix: spellcheck fixes and quiet flag

Closes #4804
fixes remaining cspell issues and adds --quiet to the spellcheck script to make it easier to read

(The random link to Get started cards was a misclick but I guess it’s forever marked.)


Update setup.py with missing packages, remove Click if necessary.

axiom validate -h fails to import items from modules distributed, dask and click. I had to install these modules manually for it to work.
pip install distributed dask click

I'm pretty sure we're no longer using click (unless dask is using it somewhere) - it was a CLI library that was tested in an earlier version.
We should deprecated it and remove it from the code.
As for distributed, it looks like it is missing from the setup.py install list.
I'll rename this issue and flag as a bug to get it into the work list.

This has been done in another commit, click is not actually installed by axiom, it was probably missing from the distributed package which has now been added.

Ok, it looks like click isn't actually required by Axiom but by distributed/utils:
File "~/.conda/envs/axiom_esci/bin/axiom", line 10, in
import axiom.drs.cli as adc
File "~/.conda/envs/axiom_esci/lib/python3.9/site-packages/axiom/drs/init.py", line 13, in
from distributed import Client, LocalCluster
File "~/.local/lib/python3.9/site-packages/distributed/init.py", line 2, in
from distributed import widgets  # isort:skip; load distributed widgets second
File "~/.local/lib/python3.9/site-packages/distributed/widgets/init.py", line 5, in
from distributed.utils import key_split
File "~/.local/lib/python3.9/site-packages/distributed/utils.py", line 37, in
import click
Jake Weis | M.Sc. | Ph.D. candidate
Institute for Marine and Antarctic Studies | Hobart, TAS, Australia
ARC Centre of Excellence for Climate Extremes
https://climateextremes.org.au/
Phone: +61<PHONE_NUMBER>
[Text  Description automatically generated with low confidence]
From: Ben Schroeter @.>
Date: Tuesday, 7 June 2022 at 3:14 pm
To: AusClimateService/axiom @.>
Cc: Jakob Weis @.>, Author @.>
Subject: Re: [AusClimateService/axiom] Import from modules distributed, dask and click fail (Issue #46)
I'm pretty sure we're no longer using click (unless dask is using it somewhere) - it was a CLI library that was tested in an earlier version.
We should deprecated it and remove it from the code.
As for distributed, it looks like it is missing from the setup.py install list.
I'll rename this issue and flag as a bug to get it into the work list.
—
Reply to this email directly, view it on GitHubhttps://github.com/AusClimateService/axiom/issues/46#issuecomment-1148205631, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVNGN2SVJCIUGP6PBVWT3LVN3LDHANCNFSM5YBR6XZA.
You are receiving this because you authored the thread.Message ID: @.***>
This email is confidential, and is for the intended recipient only. Access, disclosure, copying, distribution, or reliance on any of it by anyone outside the intended recipient organisation is prohibited and may be a criminal offence. Please delete if obtained in error and email confirmation to the sender. The views expressed in this email are not necessarily the views of the University of Tasmania, unless clearly intended otherwise.


Padding in FNO2d breaks "super resolution"

In the updated FNO2d model a 'padding' was introduced. According to a comment in the code this should help with non-periodic inputs. I think this padding may break the ability to evaluate the model on different grids than the one used for training, at least it did in my tests.

Right, the padding number should be set with respect to the spatial domain. If I would like to pad 1/5 of the domain size, then the padding number is 10 if the domain resolution is 50; and the padding number is 20 if the domain resolution is 100.
For example, you can modify
x = F.pad(x, [0,self.padding, 0,self.padding])
to be
x = F.pad(x, [0,x.shape[-1]//5, 0,x.shape[-2]//5])

Great, thanks. Will you update the code accordingly?

Sorry, I am a bit busy at this moment. But I will update it in the next version.

Ok, then I'll keep the issue open until it's included in the code

Could I ask questions about padding?
What's the intuition of the padding operation? I don't know why it is connected to non-periodic condition, and I'm confused about it.
Thanks.

And the padding doesn't seem to appear in the paper.

Sorry for the delay. The idea of padding is to put the input domain into a larger padded domain which is periodic. In this case, the Fourier series is defined on the padded periodic domain.

Domain padding is fixed in the latest version, see https://neuraloperator.github.io/neuraloperator/dev/modules/generated/neuralop.models.padding.DomainPadding.html#neuralop.models.padding.DomainPadding


Fixed batch job checker

This resolves #149
I have updated the jobAllocationChecker function to not delete elements out of the map so that they are still available for subsequent compares.  I have also modified the key to be a struct so that we no longer need to pre-populate our levantTask variable.

thanks for this @dansteen


[Hub Generated] Review request for Microsoft.Batch to add version stable/2023-05-01

Get responses to contain values that the Put requests did not have that got identified by S360 https://openapihub.azure-devex-tools.com/amekpis/correctness/detail?errorId=95CCEFF6-39EC-450A-8C82-E94C9382B314
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[x] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/pr RequestMerge

You are at step 2. Its too early for you to request a merge. Please request a merge once you get to step 4

@rkmanda I got the approval from the SDK team for the breaking change. two days ago [JeffreyRichter] added the Approved-BreakingChange

In hindsight, this might not have really needed ARM review. But anyway, signed it off now.

/azp run


Increase e2e timeout by a few minutes

Increases the e2e timeout to 8 minutes. This coincides to the other
timeouts:
8 minutes: timeout for pinging pods
9 minutes: timeout for total e2e tests
10 minutes: default timeout for golang tests

Okay, seems like this fixed semaphore a bit. Going to merge this in (for now).


Could not resolve all files for configuration ( Could not find com.github.yalantis:ucrop:2.2.6)

Getting this while building the app (android version Lollipop)
Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find :unspecified:.
     Required by:
         project :app > com.github.Drjacky:ImagePicker:1.8.1
   > Could not find com.github.yalantis:ucrop:2.2.6.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/github/yalantis/ucrop/2.2.6/ucrop-2.2.6.pom
       - https://jcenter.bintray.com/com/github/yalantis/ucrop/2.2.6/ucrop-2.2.6.pom
     Required by:
         project :app > com.github.Drjacky:ImagePicker:1.8.1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

https://github.com/Drjacky/ImagePicker#usage -> 1.
allprojects {
   repositories {
      	...
       	maven { url "https://jitpack.io" }  //Make sure to add this in your project for uCrop - an internal library
   }
}

This is my module level gradle
`
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
google()
jcenter()
maven { url "https://jitpack.io" }
}
dependencies {
classpath "com.android.tools.build:gradle:4.1.3"
    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}
`

using the latest version 1.8.1
implementation 'com.github.Drjacky:ImagePicker:1.8.1'

buildscript {
...
    repositories {
        google()
        mavenCentral()
        maven {
            url "https://plugins.gradle.org/m2/"
        }
...
}

allprojects {
    repositories {
        google()
        mavenCentral()
        maven { url "https://maven.google.com" }
        maven { url "https://jitpack.io" }
        maven { url "https://plugins.gradle.org/m2/" }

Also, be sure you have set it like: https://github.com/Drjacky/ImagePicker/issues/8#issuecomment-808271980


How to access job variables inside a script file

I have a script file called let's say create_dotenv.sh, and inside this script I want to access the environment variables (set in the pipeline) in order to create my .env.
Is it possible to do it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

Ok just figured how to do it, adding a . before the script, like so:
. ./create_dotenv.sh

I'll wait for further discussion before closing it because I don't really know if this is safe and a good practice.
I just know that is easier to have a script generating my files, so I can carry it along with the code and manage my yml more easily.
Reference: https://askubuntu.com/a/53178/1001717


offline documentation

I do most of my development work while offline: it would be nice if we could have links on doc.rust-lang.org to download the Book and possibly the standard library docs too.
The library docs are already in an archive under http://static.rust-lang.org/dist/ so we could maybe just link to the current version of that.
I don't know if the book already has an archive anywhere.

+1
And I think we'd better provide docs for all supported platforms, as some modules especially FFI-related are quite different for platforms.

The docs are already installed when you install Rust, is there still a large advantage to also having a separate link when you get them already anyway?

That doesn't include the Book (I think?), an offline copy of that would definitely be useful.

It does include the book.


AP causing a EXC_CRASH (SIGABRT) in ruby?

Please read my bug report: http://redmine.ruby-lang.org/issues/4820
I think AP may be causing a crash in ruby. Of course, this is a bug in ruby, but AP seems to be exploiting the bug.
When it crashes it leads me to: /lib/ap/core_ext/class.rb:14: [BUG] Segmentation fault
Hmm, you have labeled that line as EVIL?! Maybe it truly is!
You can try following my steps in the bug report to see if you can make it crash. But it crashes for me, fairly consistently, but not every time. My belief is that there is some interaction with the 'itslog' gem, because if I remove 'itslog' it doesn't crash (limited testing though). But the crash typically points to AP.
Anyone else experiencing a crash?

Please check out the latest v1.0.1

stll happening as explained here https://github.com/michaeldv/awesome_print/issues/54


Update TF parsing

We don't need to parse xunit (=the single test results) anymore.
We can newly get log_url from the API without a need to hardcode it.

TODO:

[ ] Wait for Miro (=@thrix) to add the log_url to their API. (edit: it will be run.artifacts.)

recheck

recheck

recheck


check mujoco dependency only when enable_continuous=True

@onlytailei
We should only require this dependency when enable_continuous=True. Can you check it first?

@jingweiz
Yes. Will revise it soon.

@onlytailei
Just change the default config to 5 and change a bit in README, should be fine now, can you pull the latest version and check it?

@jingweiz
I find that this is no explicit dependency with mujoco (like import mujoco) in pytorch-rl.
It is a implicit dependency in gym only if you try to start the related environments like "InvertedPendulum-v1"  (https://gym.openai.com/envs#mujoco)

It is better that enable_continuous=True can be connected with the environment and set automatically.


Creating TradeOffer

Hello friends,
I'm having trouble creating a TradeOffer and sending it to the user of my website. Do you have any suggestions on how to do it? I am using the following:

#427


Typo in menu option

"Draw Object Grpah" should be "Draw Object Graph"

Thank you for your pull request.


[Feature Request] Add MacOS support

So far I have tried 3 image viewers:

macfeh - Does not reload the image when the image gets altered. The normal feh has an --auto-reload option, but macfeh doesnt, and it does not look it will be added if we ask for it because the developer has not been active for a really long time.

qlmanage (Quick Look) - Does not reload the image when the image gets altered

Preview.app - Is able to reload the image using a small hack. But the down side of using preview is that it does not look minimal. It is possible to hide the tool bar and some of the junk, but I am not sure if it is possible to do so from the command line.

To change the focus from the image viewer back to the terminal, we can of course use Apple Script.

Small update:

I found out that imagemagick is not able to find fonts without Ghostscript on macOS.
After installing Ghostscript (brew install gs), doing convert -list font gave me the fonts.
Something else that I found out is that mktemp works differently on macOS. As you see in the screenshot (title of Preview.app), mktemp is not replacing the XXXXXX with the random letters for files.

Dropping this idea, because it takes too much time beceause I have to turn off and turn my laptop again to switch OS, to test the code on macOS and then test it on Linux to make sure it works fine. I am going to keep the macos-beta branch in case someone wants to work on it or if I ever go back to working on it :)

I will not be creating a macOS version because for some strange reason, imagemagick is not able to find all the installed fonts on macOS. So I dont see the point of making a macOS version if the user cant see all their fonts.
CC @XOKP

Thanks for your information, your effort on it is appreciated.


Better with Mods Integration

This would probably be pretty simple to add once the author gets around to documenting the IMC handler (and putting the mod on github, which he apparently plans to do soonish)
For now, it's possible to decompile the mod to find the IMC handler and discern some meaning from it.
Don't really know what the consent is on accepting this. Also don't know how feasible it is to add IMC support to CraftingHarmonics.
Currently working on figuring out the messages + parameters: They all take nbt data as input.
"addKilnRecipe", "addTurntableRecipe", "addLogHarvest"

"Input" as an ItemStack (blocks only) (meta of 32767 makes a non-meta sensitive match)
"Output" as an ItemStack

"addHeatRegistry"

"Input" as an ItemStack (blocks only) (meta of 32767 makes a non-meta sensitive match)
"HeatValue" as in Integer

"addNetherSpawnBlock"

"Spawn" as an ItemStack (blocks only)

The remaining recipes all use the same signature. But it might be subject to change, looks pretty dubious.
"addCauldronRecipe", "addStokedCauldronRecipe", "addCrucibleRecipe", "addStokedCrucibleRecipe", "addMillRecipe"

"Outputs" as a TagCompound

"Output" as an ItemStack
"Secondary" as an ItemStack; secondary output obviously (probably).

"Inputs" as a TagCompound

"InputLength" as an Integer
"Input_0" to "Input_[n]" as ItemStack (for a regular item) or a String followed by an Integer (for an orestack)

There appear to be no IMC messages for removing recipes.

Hi,
So, the problem with this is that all operations to add something have to be able to also remove it once added due to the way the system works, so, if the author's IMC code only has 'add' functions, then I can't add recipes that way.
While this isn't usually a problem - I have other ways that I can add/remove recipes that I use with other mods - I would prefer to wait until his source code is publicly available before I start trying to work with it.


Google cloud Storage 308 Error while writing file

Hi All,
I tried to pull the report from Double Click Search API and put it into Google Cloud Storage by using google app engine(Python).
The following code is used to pull the report and place in google cloud storage.
def download_files(service, report_id, report_fragment):
  """Generate and print sample report.

  Args:
    service: An authorized Doublelcicksearch service.
    report_id: The ID DS has assigned to a report.
    report_fragment: The 0-based index of the file fragment from the files array.
  """
  print "Enter into download_files", report_id
  filename="/awstogcs/DoubleClickSearch_Campaign"+report_id+"_"+report_fragment+".csv"
  write_retry_params = _gcs.RetryParams(backoff_factor=1.1)
  gcs_file=_gcs.open(filename, 'w', content_type='text/plain',retry_params=write_retry_params)
  request = service.reports().getFile(reportId=report_id, reportFragment=report_fragment)
  time.sleep(120)
  gcs_file.write(request.execute())
  gcs_file.close()

Not sure why getting this error message.
Error Message:
INFO     2017-06-26 13:23:37,417 module.py:809] default: "PUT /_ah/gcs/awstogcs/DoubleClickSearch_CampaignAAAndQT-U9IDyFYX_0.csv?upload_id=encoded_gs_file%3AYXdzdG9nY3MvRG91YmxlQ2xpY2tTZWFyY2hfQ2FtcGFpZ25BQUFuZFFULVU5SUR5RllYXzAuY3N2 HTTP/1.1" 308 -
INFO     2017-06-26 13:23:37,710 module.py:809] default: "PUT /_ah/gcs/awstogcs/DoubleClickSearch_CampaignAAAndQT-U9IDyFYX_0.csv?upload_id=encoded_gs_file%3AYXdzdG9nY3MvRG91YmxlQ2xpY2tTZWFyY2hfQ2FtcGFpZ25BQUFuZFFULVU5SUR5RllYXzAuY3N2 HTTP/1.1" 308 -
INFO     2017-06-26 13:23:37,976 module.py:809] default: "PUT /_ah/gcs/awstogcs/DoubleClickSearch_CampaignAAAndQT-U9IDyFYX_0.csv?upload_id=encoded_gs_file%3AYXdzdG9nY3MvRG91YmxlQ2xpY2tTZWFyY2hfQ2FtcGFpZ25BQUFuZFFULVU5SUR5RllYXzAuY3N2 HTTP/1.1" 308 -
INFO     2017-06-26 13:23:38,157 module.py:809] default: "PUT /_ah/gcs/awstogcs/DoubleClickSearch_CampaignAAAndQT-U9IDyFYX_0.csv?upload_id=encoded_gs_file%3AYXdzdG9nY3MvRG91YmxlQ2xpY2tTZWFyY2hfQ2FtcGFpZ25BQUFuZFFULVU5SUR5RllYXzAuY3N2 HTTP/1.1" 308 -
INFO     2017-06-26 13:23:38,440 module.py:809] default: "PUT /_ah/gcs/awstogcs/DoubleClickSearch_CampaignAAAndQT-U9IDyFYX_0.csv?upload_id=encoded_gs_file%3AYXdzdG9nY3MvRG91YmxlQ2xpY2tTZWFyY2hfQ2FtcGFpZ25BQUFuZFFULVU5SUR5RllYXzAuY3N2 HTTP/1.1" 200 -

@chaitu1124 Thanks for the report.  Unfortunately, the _gcs module you are using is not part of the google-cloud-storage library.  I'm not sure where it comes from.

@chaitu1124 FWIW a 308 means that the server is expecting more chunks to be sent during a resumable upload.

@tseaver _gcs is alias for cloudstorage
import cloudstorage as _gcs

@chaitu1124 That still isn't the google.cloud.storage library.  How did you install it?

@chaitu1124 ISTM you are referring to a GAE library. Is that correct?

@tseaver I try to run the python scripts in App engine. I installed the library with the following command.
pip install GoogleAppEngineCloudStorageClient -t <your_app_directory/lib> [ particular folder]

@chaitu1124 OK, that library looks to have its repository / issue tracker over here.


Romain empty controllers

API routes added in multiple Controller classes
Those routes will enable to navigate through the application but does nothing for the moment ; they will be correctly implemented later on when the fonctionnalities will be added
See later on if routes access based on user privileges are done correctly (for example the ones to remove invite and users on the AdministratorController)

ok pour moi.


Fixing a bug in management client that is sending atom xml elements out of order

Fixing a bug in management client that is sending atom xml elements in enity description
out of order in an update call. Because of this bug, deserializer on the service ignores
these out of order elements, and persists elements with default values in the righr order
resulting in these out of order elements getting duplicated in the resource xml.
This fix removes duplicate elements only if they are present from the xml, and sends
xml elements in the correct order in update call.

Were any updates needed for rules?

No

In reply to: 720683278 [](ancestors = 720683278)


add extend method to increase expiry (controller-only)

Add public facing method, that extends the session expiry.
Method is only allowed for controller.
By Default the method should extend session by 7 days and pairing by 30 days.

Since there is protocol refactor this issue can be closed


Powershell script references a URI that does not exist after the refactor- deployment fails

From Enterprise-Scale-AppService created by ahmedsza: cykreng/Enterprise-Scale-AppService#73
The powershell script that the custom script extension uses is hardcoded currently to https://raw.githubusercontent.com/cykreng/Enterprise-Scale-AppService/main/deployment/bicep/shared/agentsetup.ps1 (line 48 in createvmwindows.bicep)
I am not aware of any of doing absolute references..

updated the script to point to a URL does exist. Still need to figure if there is a better way to handle this. No errors now


Improve documentation

We have to document both usage (how to add and use in a project) as well as documentation for how to develop/test locally (adding a Postman collection would be nice).

How to integrate using curl?

How to integrate using Javascript (axios)?


safe delete -Rf doesn't delete anything

When running the safe delete -Rf, the given path is not removed.
Doesn't work:
safe delete -R secret/west/us/sandbox/certificates
safe delete -Rf secret/west/us/sandbox/certificates
Does work:
safe paths secret/west/us/sandbox/certificates | xargs safe delete

Can you provide more extensive logs to help me reproduce this?

nm, got it.
:ninja:


WIP: User management

@alanamircruz I added the chapter model to the authentication app and linked it to the User model, I hope that is ok
Also added an InLine for it in admin, not sure if needed.
Also noted a few questions I have, who is best to address them to?


fix: refactor notify triager workflow

ref : https://github.com/asyncapi/website/issues/3214

Summary by CodeRabbit

Bug Fixes

Enhanced the triager extraction process to ensure accurate identification of document and code triagers.
Added checks to prevent unnecessary review assignments when no triagers are found.

Improvements

Improved workflow efficiency by streamlining the process of adding reviewers and enhancing the handling of commit messages.
Simplified conditions for determining reviewer assignments based on file changes.
Updated the CODEOWNERS file to modify owner listings and comment formatting.

This is draft state

/bounty

@asyncapi/bounty_team

@sambhavgupta0705 Is it ready for review?

@anshgoyalevil nope
Will update it by next week

Hey
just finished my endsem examination
will be updating this PR by today.
Sorry wasn't able to manage time

closing it for sometime as I am doing testing on this

/unbounty


Error occur during training , Command terminated by signal 15

This occur when I run ./experiments/scripts/train_faster_rcnn.sh 1 coco res101
With env TITAN X (Pascal) , Ubuntu 16.04.1

https://www.redhat.com/archives/redhat-list/2002-July/msg02369.html
https://community.hpe.com/t5/General/usr-sbin-envd-1557-terminated-by-signal-15/td-p/5068523
It looks like someone or some process kill this. I have few to deal with this because it may be related to your disk or whatever.


WIP: Initial implementation of quick-switcher (keyboard-driven navigation)

Initial implementation of a quick-switcher / keyboard-driven navigation.
I created a new component that is attached to the root of the application. The component leverages the Clarity modal functionality.
To open the quick-switcher, hit the k key. Once open, you can use the input field to filter the list of potential destinations. You can use the arrow keys to go up and down in the list. Once you are set on a destination, hit Enter to navigate there. You may also use the mouse to select an item from the list.
Demo:

Fixes #413

Looks like the frontend build is failing. Going to review the build logs and address any issues.

Fixed the lint errors, minus one:

ERROR: /go/src/github.com/vmware-tanzu/octant/web/src/app/components/quick-switcher/quick-switcher.component.ts[90, 18]: non-arrow functions are forbidden

I need help with focusing the input once the Modal pops up. I am not sure how to do that in an Angular-native manner. Link to code in PR: https://github.com/vmware-tanzu/octant/pull/434/files#diff-cdf196737b682f9089d6e6506bfcebb2R88-R92

Oh, it just wants you to use () => {} instead of function () {}

Aaaah okay! I am still wondering if there is a better way to focus on the input. Ideally, I should be able to get an event or something that indicates the modal has opened. I couldn’t find how to do that though.

I like where this going. Is k the right invoking key? I'd like to throw some other contenders in the ring:
O for object
/ Because that's what vim does
Some other things to think about:

how would users discover this feature?
Could we reuse this modal idiom for other features? Perhaps a way to kickstart a process for creating objects?

I don't have strong opinions on k being the invoking key. I initially went with it because that's what I use for kubectl on the command line.
I like the alternatives you propose @bryanl. Here is another one:

g for "Go" (github uses this: g + n goes to notifications for example).

I love the idea of using /, but I would use it to search the contents of a page.
The way I envision this:

k + pods + enter takes me to the pods page
/ focuses on a search / filter bar
nginx to filter pods by name = nginx

re: feature discovery - I am not sure. I just reviewed Slack, Gmail and GitHub and none seem to have anything in the UI for discovering keyboard shortcuts.  One thing they do have in common is that they all use ? or cmd + ? to bring up a help menu that explains the keyboard shortcuts thought.

Hey all, anything I can do to move this forward?

@alexbrand Also can you add QuickSwitcherComponent to the declarations in app.component.spec.ts?

All set @GuessWhoSamFoo 👍

Two small changes then lgtm

For e2e testing, https://github.com/vmware-tanzu/octant/blob/master/web/cypress/integration/deployment.spec.js#L22 should be replaced with  cy.contains('span[class="ng-value-label ng-star-inserted"]', result.stdout); because there are now two focus elements possible (one on the namespace dropdown and the other from quick switcher)

Linter indentation

ERROR: /go/src/github.com/vmware-tanzu/octant/web/src/app/app.component.spec.ts[52, 31]: Insert `,`

Thanks again @alexbrand !


Update copyright years

Following the Apache Foundation's guidance on copyright notice: https://www.apache.org/legal/src-headers.html#notice
Resolves https://github.com/cerner/terra-framework/issues/65

👎  boo Danger...


Hyperion + Raspberry Pi: Lights when not watching video

On my Raspberry PI running OSMC + Hyperion, the automatic lights only seems to work when there is a movie/video playing. Is there anyway to have the automatic (ambilight) lights come on even when I am not watching a video?

I am also interested in this. Like would it be possible to implement a "pause lights" to hyperion? E.g it sees that XBMC is paused and after a certain period (or immediately?) it turns all the lights to white or dim or off. Would be cool. I'll look into it

Hyperion has a concept called 'priority channels'. Each input defines a certain priority number. The channel with the lowest number takes priority. For example if you start some kind of effect at priority channel 1000 and have the grabber running at 100. The effect should kick in when no video is detected.

That does not answer my question.. I am not talking about running an effect from the effects folder, I want the ambient light effect to be running even when a video is not detected (i.e. show the OSMC/Kodi screen border when a video is not playing)

There is an option in the hyperion configuration which disables/enables the grabber based on preferences. This is under the xbmcVideoChecker section.

What would the option be when it is at the main screen? I saw there was a grabMenu but that makes me believe that is only for when you are in the actual menu and not just the main screen

What is the main screen?

Like

Oh, ok that is indeed switched with the 'menu' option.

Should be answered
Closed


How to use concurrency with data passing without blocking the main isolate.

Please take a look at the following example:
import 'dart:async';
import 'dart:convert';
import 'dart:math';
import 'package:isolate/isolate.dart';

String str = _generateString();

Future<void> main(List<String> args) async {
  final IsolateRunner r = await IsolateRunner.spawn();
  final List<Operation> operationAndDuration = [];
  const int frameLengthIsMS = 1000 ~/ 120;
  final List<int> frames = [];
  final Timer timer =
      Timer.periodic(const Duration(milliseconds: frameLengthIsMS), (timer) => frames.add(timer.tick));
  Stopwatch s;

  Future<T> runAsyncOperation<T>(String description, Future<T> Function() operation) async {
    s = Stopwatch()..start();
    final value = await operation();
    operationAndDuration.add(Operation(description, s.elapsedMilliseconds ~/ frameLengthIsMS, timer.tick));
    return value;
  }

  T runSyncOperation<T>(String description, T Function() operation) {
    s = Stopwatch()..start();
    final value = operation();
    operationAndDuration.add(Operation(description, s.elapsedMilliseconds ~/ frameLengthIsMS, timer.tick));
    return value;
  }

  print("${str.length} bytes, please wait ~10 seconds.");

  final map = await runAsyncOperation("Isolate Decode", () => r.run(decode, str));
  final encodedMap = await runAsyncOperation("Isolate Encode", () => r.run(encode, map));

  await Future(() {});

  final map2 = runSyncOperation("Decode", () => decode(str));
  await Future(() {});

  final encodedMap2 = runSyncOperation("Encode", () => encode(map2));
  await Future(() {});

  assert(encodedMap == encodedMap2);

  timer.cancel();

  print(" • ${_zip(operationAndDuration, findSkippedFrames(frames)).map((v) {
    assert(v.value.key == v.key.at);
    final dif = v.value.value - v.value.key;
    return [
      v.key.description,
      "Took          : ${v.key.frames}",
      "SkippedFrames : ${dif}     (Frame ${v.value.key} to ${v.value.value})",
    ].join("\n   - ");
  }).join("\n\n • ")}");
}

class Operation {
  final String description;
  final int frames;
  final int at;

  const Operation(this.description, this.frames, this.at);

  @override
  String toString() => "Operation '$description' took '$frames' frames at '$at'";
}

List<MapEntry<A, B>> _zip<A, B>(List<A> a, List<B> b) {
  assert(a.length == b.length);
  return a.asMap().entries.map((entry) => MapEntry(entry.value, b[entry.key])).toList();
}

List<MapEntry<int, int>> findSkippedFrames(List<int> frames) {
  final List<MapEntry<int, int>> skippedFrames = [];
  frames.fold<int>(null, (previousValue, element) {
    if (previousValue == null) return element;
    if (previousValue + 1 != element) {
      skippedFrames.add(MapEntry(previousValue, element));
    }
    return element;
  });
  return skippedFrames;
}

Map<dynamic, dynamic> decode(String str) => json.decode(str) as Map<dynamic, dynamic>;

String encode(Map<dynamic, dynamic> str) => json.encode(str);

String _generateString() {
  final Random rnd = Random();

  final Map<dynamic, dynamic> map = <dynamic, dynamic>{};
  for (int i = 0; i < 500000; i++) {
    map[i.toString()] = [
      rnd.nextInt(1000),
      (int length) {
        final rand = Random();
        final codeUnits = List.generate(length, (index) {
          return rand.nextInt(33) + 89;
        });

        return String.fromCharCodes(codeUnits);
      }(10)
    ];
  }

  return json.encode(map);
}

Output:
13985982 bytes, please wait ~10 seconds.
 • Isolate Decode
   - Took          : 196
   - SkippedFrames : 152     (Frame 241 to 393)

 • Isolate Encode
   - Took          : 187
   - SkippedFrames : 6     (Frame 482 to 488)

 • Decode
   - Took          : 47
   - SkippedFrames : 47     (Frame 488 to 535)

 • Encode
   - Took          : 29
   - SkippedFrames : 30     (Frame 535 to 565)

I'd like to do expensive operations outside of the main isolate and receive a lot of data (e.g. large decoded json maps) back.
This example is supposed to show that using an isolate to decode a large json would result in 152 skipped frames for this particular run while doing the same work on the main isolate would only cost 47.
How do I decode large JSON strings where

all of the decoded data is needed in the main isolate (only passing back parts of it is not an option)
the main isolate is supposed to be able to run smoothly at 120FPS during the whole process.

Related issues: #29480 https://github.com/dart-lang/language/issues/124

The work on https://github.com/dart-lang/sdk/issues/37835 (which is under active development) should address this particular use-case.
As a stop-gap solution you could try using chunked JSON decoding on the main thread.

all of the decoded data is needed in the main isolate (only passing back parts of it is not an option)

I would be curious to hear more about this requirement. If you have so much data that it takes a long time to copy it into the main isolate - then it is unlikely you really are going to display all of it in the UI. Then what is the point of passing it all back into the main isolate? If your UI is going to display only slices of it - then you should be able to just pass over those slices back to the UI isolate.
Can you elaborate where the requirement to have the whole gigantic JSON-like data structure in the main isolate comes from?

I would be curious to hear more about this requirement.

I would like to be able to visualize vast amounts of data on a virtual canvas. without having to worry about blocking the UI and without adding unecessary complexity due to limitations by dart.
Since I need that canvas to be scalable, all of the data should optimally be available on the first frame. If that is not possible then at least the UI should not skip any frames so that a progress indicator can be displayed.

I will try a chunked approach, but I should have mentioned that encoding and decoding json is just a placeholder for many other problems. Working with audio/video/images, calculating technical indicators, any other form of data visualization with big data sets.
Yes, there are be workarounds for most of those problems with which one might be able to get a smooth UI, but i should not have to worry about that, just to get a smooth UI.


Fix Author search result without co-author

Hi @tdonohue, I'm @jtimal partner, I like to share this PR with you:
References

Fixes #2203

Description
Add a method to search-result-list-element component to show all the authors and if the author's name is highlighted its displayed anyways (if author's list length allow it)
Instructions for Reviewers
To reproduce the error we need an item with two or more dc.contributor.author:

Create and deposit a new item
Add to metadata two or more dc.contributor.author
Use search tool to find the item

List of changes in this PR:

Added a method to combine the highlighted authors and other authors' name
Changed the method used to displayed the list of authors in result list

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Hi @tdonohue I added a commit removing some trailing spaces and removing some console.logs that I forgot


Password Field

Description
When the user signs up to the application the user sets a password according to which he is verified on further logins.
Can I add a confirm password field here so that we reconfirm the password set by user during signUp
Domain
Front-End (Styling/Markup)
Code of Conduct

[X] I follow Contributing Guidelines of this project.

/assign


Actual remove batch and slot history conflict

Slot history stores fragments in unmounted state.
However, unmount uses actualBatchOwner to optimise the removal of actual UI elements.
This leads to a conflict because some actual UI instances deeper in the tree are not actually removed from their parents, so adding them back again will result in an error.

We don't use slot history at the moment (nor slots for that matter).


fix(assets): split asset utilization plugin code from asset calibration plugin code

Pull Request
🤨 Rationale
The following PR splits the current asset Grafana plugin into 2 separate plugins:

Asset Utilization plugin
Asset Calibration plugin

Link to workitem: Bug 2847424: Add feature flag to hide current progress on the Grafana Assets plugin
👩💻 Implementation

New plugin was generated
Code related to Calibration features are migrated from existing shared plugin to the Asset Calibration Plugin

🧪 Testing

Unit test
Manual tests

✅ Checklist

[x] This PR has a title that follows the commit message format.

:tada: This PR is included in version 3.12.1 :tada:
The release is available on:

v3.12.1
GitHub release

Your semantic-release bot :package::rocket:


Question - how do I get a ContentBlock's direction, so I can serialize it to HTML properly?

Hey,
First of all, a huge thanks for this beautiful piece of software. Can't stop praising it enough.
I'm dealing with mixed content, RTL and LTR, and Draft.js handles it perfectly.
My problem is that when I get to serialize the editor's state into HTML (requirement of our app), I can't see to know whether a block was rendered as RTL or not (at least not without scrapping rendered block classes from the editor, which I see get '-rtl' appended to when text is RTL).
Is there any way  to know via the API what is the direction of a given block? or any workarounds?
Thanks!

@GabiGrin - wow, I'm really sorry for such a slow response. We are trying to work on being more responsive.
As for the HTML conversion, are you currently using something like https://github.com/sstur/draft-js-export-html ?
We should expose DirectionMap on EditorState, here's some code showing it's a map of the block key to either the string 'RTL' or 'LTR':
https://github.com/facebook/draft-js/blob/5a36195d124990a082498665f6824ca96ab51e09/src/component/contents/DraftEditorContents.react.js#L106-L126

Going to close this out since it looks like this isn't an issue anymore. Please reopen if that's not the case.


[ᚬrc/v0.20.0] feat: Implement Serializers

For #137. Deadline: Sep 7th.

Codecov Report

Merging #139 into rc/v0.20.0 will increase coverage by 0.31%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           rc/v0.20.0     #139      +/-   ##
==============================================
+ Coverage       96.75%   97.07%   +0.31%
==============================================
  Files              41       50       +9
  Lines            1201     1332     +131
==============================================
+ Hits             1162     1293     +131
  Misses             39       39

Impacted Files
Coverage Δ

...zation/BaseSerializers/OptionSerializerTests.swift
100% <100%> (ø)

Source/Serialization/Serializer.swift
100% <100%> (ø)

...zation/BaseSerializers/DynVecSerializerTests.swift
100% <100%> (ø)

...erialization/BaseSerializers/ArraySerializer.swift
100% <100%> (ø)

...zation/BaseSerializers/FixVecSerializerTests.swift
100% <100%> (ø)

...ization/BaseSerializers/TableSerializerTests.swift
100% <100%> (ø)

...ization/BaseSerializers/ArraySerializerTests.swift
100% <100%> (ø)

...ization/BaseSerializers/UnionSerializerTests.swift
100% <100%> (ø)

...zation/BaseSerializers/StructSerializerTests.swift
100% <100%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3b776...b8598fd. Read the comment docs.


consider renaming apstra_datacenter_blueprint_system_node -> apstra_datacenter_system

Data source apstra_datacenter_blueprint_system_nodes returns a list of graph node IDs of system nodes.
Data source apstra_datacenter_blueprint_system_node returns detailed info about a single system node.
We'll likely be creating a bunch of data sources that follow this pattern. Currently in queue are data sources for routing_zones/routing_zone and virtual_networks/virtual_network.
Are the words blueprint and node really helping much here?
Should they instead be:

apstra_datacenter_systems
apstra_datacenter_system
apstra_datacenter_routing_zones
apstra_datacenter_routing_zone
apstra_datacenter_virtual_networks
apstra_datacenter_virtual_network

When I first created the system/systems data source it was a big departure from the others: Totally graph-query based.
This felt like a big departure...
But it's really only relevant to me as the implementer. I don't think the end user needs to know this level of detail.

Fixed by #104. Thank you @bwJuniper!


Input notebook link move from "Job files" to "Input filename" column

Problem
The input notebook download link is listed in the job files column. There is dedicated column called "input filename". Please see the uploaded screenshot.
It would be more natural to reuse the input filename column to show the input notebook.
Proposed Solution
When the input notebook is downloaded, change the text input name to link.

This is a nice idea, we are also going to remove the file extension from the default job name to show users that the name doesn't have to just be the full file name and extension.


More sophisticated ETag calculation

Follow-up to https://github.com/splitgraph/seafowl/issues/20
Currently, we compute the ETag based on all versions of Seafowl tables in a query. This disregards:

Contents changing when the version doesn't (e.g. using https://www.splitgraph.com/docs/seafowl/guides/baking-dataset-docker-image will always use V1 for all tables, since we're rebuilding the dataset from scratch each time): we should use the hashes of the Parquet files instead?
UDF/built-in function definitions changing
DataFusion query plan / execution changing

A prolly tree data structure could come in useful here https://github.com/attic-labs/noms/blob/master/doc/intro.md#prolly-tree-structure.
If a query plan can be evaluated deterministically it could use chunk hashing during each stage of applying the operations to pull results from an internal cache.
Are you familiar with doltdb https://github.com/dolthub/dolt? Essentially I would love to apply those semantics to seafowl!!

Another method: A weak etag with timestamp baked in can then let clients decide whether the information they might fetch from caches is within an acceptable threshold or not. If not, they issue a request that bypasses caches.


@conda-forge-admin, please add user @joannasendorek

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @joannasendorek in conda-forge/pandas-stubs-feedstock#73.


Add MajesticBank to swappers

Replacement for #2183

listed on getmonero under sponsors https://www.getmonero.org/community/sponsorships/, they claim to have their own monero reserves / increase of volume when compared with the same period last year, give the people monero / let their be swaps.
those against having majesticbank on the swappers page, please see the disclaimer and understand that services can be listed/de-listed if legitimate issues are reported.


[WIP] Adam learning rule

This implementation is based on the arxiv [v4] paper. Haven't run or tested it yet.
The paper seems to have at least one typo in that \beta_2^t is used but never defined. I'm assuming it is just \beta_2 currently. Also assuming that \beta_{1,t} is the same thing as \beta_1^t.

Why not just use Alec Radford's implementation?
https://gist.github.com/Newmu/acb738767acb4788bac3
I've been using that plugged into Pylearn2 in my private repo and it works well.

I don't think Alec's version is consistent with the most recent version of the paper, but I haven't really tested this implementation vs. his, so I'm not sure how different the results will be.

It might just be that Alec's version doesn't decay beta1, although the betas have been redefined, and I haven't checkout to see whether the rest of the math is equivalent.


fix: clean up warnings

r? @matklad

Thanks!
The travis failure seems unrelated and a bit mysterious

bors r+


restrict map zoom out to center on where we have data (i.e. Syria)

we now snap to fit results, users are allowed to zoom out further, but I think the main intent is met with recent changes


Update testrig

After creating your pull request, tick these boxes if they are applicable to you.

[ ] I have tested my changes against the dev branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.8 or higher
[x] I have ensured my code is formatted using Black

Description

Implement the queue and buffering mechanism for test commands

Test thoroughly with Python 3.10/3.12/3.13, no Python-version related issue is found

Add a coverage report of the latest version of testrig in htmlcov/, the original line coverage of testrig is 58%, the one of updated testrig is 60%

Remove an inaccessible url from PLAYABLE_STRING_ARRAY, and add a small spotify playlist as well as a youtube livestream link into it

Add a filtering function to filter the PLAYABLE_STRING_ARRAY before testing them on certain commands (like stream and pldump)

Remove redundant testing commands (like repeat off) and refine them

Add commands before some certain tests to ensure deterministic behavior (like seek and setspeed)

Add config change commands before testing certain commands (like setprefix and cache clear)

Remove deprecated command option

Related issues (if applicable)
Python 3.13 support #2435

@itsTheFae If there are any changes you want us to make, feel free to tell us here! Also, if you do not want the coverage report to be in the repo, I can delete it from the pr and send it to you in other ways.

Regarding the coverage report files.  If you don't mind, could you PR the report files against the fae branch of this repo?
The two branches are almost identical, and it will keep the extra files out of the upstream PR until we can touch base with the owners about perhaps putting coverage reports on the gh-pages site.

I've changed the target branch and also solved the conflicts.

The attached logs contain the results of test suites run on different Python versions for your reference.python10_ubuntu.log
python12_macos.log
python13_ubuntu.log

Sorry, do you mean I should create a separate PR targeting fae branch that only contains the coverage report or just switch the targeting branch of this PR to fae? I might have misunderstanded your message. If I did, I will revert the current commit and make a separate PR.

Yes, I meant make a separate PR for the coverage reports and remove them from this PR.  Sorry for the confusion there.
Thank you for your time and testing!

Gotcha! I have cleaned these things up for this PR, @YijunWang1121 will make a separate PRwith the coverage report.

Thanks again!