feat: add configurable middleware

This commit adds a Middleware interface.  Users can implement it
to add code that gets executed for each request; can be used for
logging, client-side metrics, etc.

putting this up for early review.  Before it gets merged I want to experiment with some concrete logging/metrics middlewares in the load generator, but i'm hoping this API is pretty much final.
trying to get this out for a customer in the next day or so.

That's an astute question!  The answer is that I expect a lot more people to be interested in retry than other middleware, so I wanted it to feel more like a first-class construct.

I think this is ready for review now.  I added another commit, https://github.com/momentohq/client-sdk-nodejs/pull/300/commits/3bee3d4e3ae9c42a0d9b9374bf67ab2f34a3e445 👍
feat: add experimental request logging and csv metrics middlewares

This commit provides some initial experimental middlewares that
can help us debug customer issues.  They are:

ExperimentalRequestLoggingMiddleware: logs information about each
request at various stages of its life cycle, can be used to gather
timing information etc.

ExperimentalMetricsCsvMiddleware: produces a CSV file containing
metrics about each request.  This can be shared with Momento to
help us analyze performance and other issues on the client.

A subsequent PR will update the examples to illustrate usage of
these new middlewares.

Here is an example of what the CSV data looks like:
numActiveRequests,requestType,status,startTime,endTime,duration,requestSize,responseSize
100,_SetRequest,0,1677691443726,1677691444480,754,126,2
97,_SetRequest,0,1677691443727,1677691444483,756,126,2
95,_SetRequest,0,1677691443725,1677691444483,758,126,2
93,_SetRequest,0,1677691443726,1677691444483,757,126,2
94,_SetRequest,0,1677691443725,1677691444483,758,126,2
92,_SetRequest,0,1677691443724,1677691444483,759,125,2
91,_SetRequest,0,1677691443728,1677691444483,755,126,2
90,_SetRequest,0,1677691443727,1677691444483,756,126,2
89,_SetRequest,0,1677691443726,1677691444484,758,126,2
88,_SetRequest,0,1677691443727,1677691444484,757,126,2
96,_SetRequest,0,1677691443727,1677691444483,756,126,2
86,_SetRequest,0,1677691443726,1677691444484,758,126,2
85,_SetRequest,0,1677691443726,1677691444484,758,126,2
99,_SetRequest,0,1677691443723,1677691444481,758,125,2
87,_SetRequest,0,1677691443727,1677691444484,757,126,2
84,_SetRequest,0,1677691443726,1677691444484,758,126,2
98,_SetRequest,0,1677691443727,1677691444481,754,126,2

I will file a separate PR that shows what it looks like to update the examples to use this.
Also, I think there is still a minor bug in the metrics middleware that I'm looking into.

https://github.com/momentohq/client-sdk-nodejs/pull/300/commits/25ce274580aaba056bbb9e52116230e58fc5d976 fixes a few bugs, I think this is gtg now, will file corresponding examples PR.

update to examples to illustrate use: https://github.com/momentohq/client-sdk-nodejs/pull/302

Added a commit: https://github.com/momentohq/client-sdk-nodejs/pull/300/commits/b0fb9f0d4f40e1dbae04a851a8f16ab854d087fa
@kvcache this fixes a bug in the way the middleware reverse was working.  I didn't realize that function modified the array in place.  I manually verified that the order of the callbacks matches what you and I both stated as our expectation above after this commit.
@malandis this adds that extra timestamp you asked for.

rebased onto latest main

yup, makes sense then if the order's right. I thought Array::reverse() did it in place but it was letting you use it as an expression value so I thought I was maybe just mistaken. Anyway, glad it's sorted.

yeah thanks for calling it out, i totally missed that.


validation scopes doesn't work?

I have created two modals (loginModal and registerModal), where a user can switch between them dynamically.
There is an issue with scopes, I am not sure why is this happening..
I have created a demo for the problem here:
https://2o2z51km00.codesandbox.io/
Source:
https://codesandbox.io/s/2o2z51km00

Open loginModal (it will open by default).
Submit login modal (with empty inputs)
Switch to register modal
As you can see, it highlights the same fields from login modal, even though I am using scopes.

Why does that happen?

Ok, as an alternative I  solved the issue by using:

I still don't know why it was happening....


added an option to specify 'only' as a selector for files to purge

Proposed changes
Added an option to have more fine-grained control over lists of assets purge runs.
Example:
new PurgecssPlugin({
  paths: glob.sync(`${PATHS.src}/*`),
  styleExtensions: ['.css']
  only: 'my_huge_css_to_purge'
  // or as an array:
  // only: ['my_huge_css_to_purge', 'and_another_one']
})

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments
I will change docs later if you think it is ok to have that option

Thanks for the contribution.
I think it is ok to have the option. Can you provide an example in the examples folder to confirm the plugin works as expected? You can base yourself on the simple one.

@Ffloriel done!

Thanks for the PR


Add license

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.824%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10

Relevant Lines:
15

💛  - Coveralls


reply to message

Would be lovely to have the possibility to reply_to_message_id as in send message

This issue was closed on #142  and enhanced on #144 😃


Ollie Pcan firmware

Hi i'm trying use an Ollie USB-can device. https://github.com/slimelec/ollie-hw
They provide a forked version of your PCAN firmware. i have tried both your version and their provided version.
the device is recognized as  the pcan adapter in device manager.
but no traffic can be sent or received.
If i unplug the usb cable and plug it back in data is received for between 100-200ms then stops. no errors are present in the PCAN software.
have you run into any similar issues?

To add to this. if i load the standard firmware for the device (non Pcan) i can send and receive can traffic. but the software i need to use for my application requires a PCan adapter.

@killisch you need to ask @slimelec directly i think... i never has his board on my hands ,but if you will saw his commit you need to preconfigured some pins to enable needed voltage switcher and all be OK i think. I think i will add some feature to easy makes special boards supported too as it was done for PCAN PRO X firmware. Anyway why you do not want to use his forked version ?

Another thing if your adapter does not connected to bus ( and no one will receive frames ) you will get FIFO overrun because frames does not comes out from your adapter... maybe you have such problem... anyway my solution is really well tested and shows very stable in real cases.

@moonglow the issues seems to be the latest pcan drivers. This was resolved by installing older drivers see Issue .
Btw nothing special about my adapter CAN side of things, I just enable few IO.

@slimelec  Thank you ! need to check whats they changed....
p.s: your adapter is nice, but i just does not have it :) that's why i can't provide correct support for that issue

@moonglow oh no! If you like drop me a message with your details and I'll get you sorted :)
https://www.meatpi.com/contact

@killisch @slimelec
can you check latest builds ( v1.6 )


Trouble with TA_PALETTE_CLUT4 Paletted Sprites

Hiya,
I wanted to try the paletted sprites feature, but I'm having trouble getting any functional results with the 16-color palette bank and TA_PALETTE_CLUT4 mode.
I've tried various permutations of manually defining palettes, INTENSITY4 and INTENSITY8 image encoding, and even exporting graphics from different tools and working in different color modes.
At best, I've managed to get a single color from my manually defined palette to display, without respecting alpha or the gradation of the graphic asset.
There is an example of paletted textures and sprites in pvrtest and advancedpvrtest, but they only show the 256-color TA_PALETTE_CLUT8 mode - and I have been able to reproduce that use case with my own sprites and palettes.
I've looked through some of the linked docs in the repo, but haven't found anything useful yet.
I'd really appreciate anything to point me in the right direction.
Thanks very much!

Looking at the source to texture.c it seems I only ever added texture load operations for 8 and 16 bit textures. It looks like the IMG2C program (sprite.py) handles INTENSITY4 just fine so that won't need upgrading. However, given there's no texture loading happening (and the various malloc examples assume texture loading works) it's not surprising you're seeing a solid color. Let me take a peek at what KallistiOS is doing for 4-bit textures since the hardware docs for twizzling are so dang confusing.

Should be fixed with 94a53ca86782bbc674ad98a84daa78b163d64ca3.

Amazing, thanks very much!


Work towards solving #979.

Please see the commit messages for a description.
I am working towards solving #979 on branch duesee/spec_issue_979 and figured that I can extract PR-able commits to slowly make some progress on main.

Nice, spot fuzzing is cool :-) I hoped a bit that this part of the code might not be reachable. Will convert this to a draft PR for now (with no review required).

Nice, spot fuzzing is cool :-) I hoped a bit that the unimplemented!() part of the code will not be reachable and I can get away with it until I can remove it again. Will convert this to a draft PR for now and resolve later.

You are working on the most reachable part of the library (from a network standpoint), so this is sort of expected :)
I don't remember the fuzzing being triggered much in the past (if at all), but now it detected issues twice in one week.

I'm working on another branch to fix #979. These are the changes so far that should be easy to review and low-risc to take. Making slow progress :-)

@raphaelrobert I could rebase and fixup the commits before you do the review. Depends a bit on your review style (commit-by-commit) or "Files changed", I guess.


sensors: convert lis2dh to use information coming from dts

Convert lis2dh accelerometer driver to get the device name as well
as i2c/spi slave information from device tree. Updates the build_all
test accordingly. (issue #11605)
Signed-off-by: Armando Visconti<EMAIL_ADDRESS>

This PR is addressing issue #11605.
I verified building driver for both I2C and SPI, but I tested only I2C on zephyr board.

Thanks for your help converting this sensor driver to dts.
Can you help with other sensors too? See #9962

Sure, I can take the ST ones

@galak
I didn't change the yaml for i2c in this re-push. Let us know your opinion and I'll change accordingly if the case.

recheck

Looks good, but would like to get feedback from @galak regarding the i2c compatible.

@galak @MaureenHelm
If you both agree I would change the i2c comaptible string into "st,lis2dh-i2c".
It make sense and it is a new creation. We may align the others later on.

done!
see if it is ok now.


fix: tweak check-requirements for calling ldconfig

Sometimes, the target system has ldconfig ready, but you can not assume that /sbin is in $PATH. This may cause the installation of 'ssh remote' to fail.

Issue example on latest Debian release.

@deepak1556 🤝 Done! Thanks for reminding me!

Cool! 😄


substitute vector for scalar?

To allow better vectorizing of models not originally designed for it.

Duplicate of #930


Status Update - PR5 and NG

I know many of you have been requesting or inquiring about support for Skyrim 1.6.640 and GOG. Work shall begin on this from this upcoming week (more than likely from 25/01/23). How long will it take, how long is a piece of string? Joking aside hopefully 1-3wks - time dependant of course as it seems to be quite a major overhaul.
What shall be contained in Preview Release 5:

ReShade is a hard requirement for the menu with certain mods detected. (Long story short - use a weird method and GameOverlay causes problems)
Fixed FOV override not turning off as it should.
Fixed scripted/animation flybacks, all of them! (Yes this was a B*tch!)
Fixed camera staying in third person when it should be in first. (Campfire caused this, other mods as well)
Added MediaKeys=1 to the ini file which allows media keys on your keyboard to work. Note: Can cause issues for non-us keyboards.
Skyrim Upscaler support.
HDT-SMP Force Fields signature update.
Scrambled Bugs signature update.
Fixed misc menu issues. (which seem to only cause issues with myself!)
Fixed first person positioning. (no more weird glitches when saving)
Fixed first person headbob positioning to match normal.
Fixed first person torch.
Fixed DirectX11 present detection thanks to PureDark
Misc backend changes in preparation for NG update.
Fixed double arm issue with Tween Menu.
Fixed NearDistance override not turning off as it should.
Fixed player placement in first person whilst sitting.
Fixed camera positioning whilst sleeping.
Fixed NearDistance so no more flickering shadows. Note: Detailed Shadows from ENBSeries (foilage/grass) are affected by this.
Fixed general ragdolls so your not propelled to timbuktu.
Fixed death ragdolls so your not propelled to timbuktu.
Reset State (from the menu) will now reset sit/sleep state flags which seem to be a common cause for the skating/sliding animation bug.
Fixed force first person issues related to animations.
Fixed model attachments to display in first person. (ie lantern)
Added Quick Light Lighting under fixes for Quick Light SE. Note: Activating will remove the lantern but the area will brighten up based on Quick Light settings.
Fixed mods/scripts which break the camera by incorrectly calling ForceFirstPerson().
Updated sitting to use the other camera mode for more accurate positioning.
Fixed torch to work again whilst sitting. (above probably broke it)
Fixed getting on a horse in first person that switched to third person on some occasions.
Fixed getting on a dragon in first person that switched to third person on some occasions.
Fixed getting off a dragon in first person to remain in first person.

Under dev:

POV toggle detection to block certain times entering first person fully, needs more work. This will solve game controller issues.
Projectile misalignment, Physical seems fine aka arrows, magic and shouts need reviewing.
bEnableShadows. The formidable missing arm/head shadow issue/hiding various states.
Note: Some recent reversing has gone into this but not much, still want this fixed!

PR5 release date should be 27th - 29th Jan 2023 for Skyrim 1.5.97 and 1.6.353
To show <3 and support just report bugs etc as it will greatly help for NG release which will no doubt be released on NexusMods.

Maxsu for a workable CommonlibSSE-NG to work from.
Capt. Panda for an awesome showcase of Improved Camera SE show your support and <3 for them!

Upcoming Aspirations/Plans:

Full TDM support.
Full Smoothcam support.
Json support mainly for profiles.
New UI system, possibly a separate mod.
Total customisation over which animation can play out in first person.

One final note Fallout4 yes we hear you, at least NG needs to be done and dusted before any attempt is made to port and we know their is a major update coming this year at some point.

PR5 release date should be 27th - 29th Jan 2023 for Skyrim 1.5.97 and 1.6.353

So just to confirm this means that PR5 will not work on the 1.6.640 version of Skyrim? Regardless of that answer it's awesome to hear you're back on this mod, and that even if PR5 won't be for 1.6.640, that it will likely be compatible soon. Love this mod, an essential for me, have missed it dearly.

As explained in the opener nope. Pretty much need Improved Camera in a cleanless/buggy free state as much as possible before converting to the newer library hence PR5.

any way we can test the beta of the mod?

Too bad that the next update will still not be compatible with 1.6.640. Meanwhile almost all mods in my load order (>650 mods) are compatible with 1.6.640 (even DAR). The only major mods that are not yet compatible are ImprovedCameraSE, Fuz Ro Bork Text to Speech and .NET Script Framework. I'm waiting and hoping.

I'm pretty pumped. The flybacks kill me inside.

I'm pretty pumped. The flybacks kill me inside.

That and the flickering shadows when the near distance was altered.

Can we expect to have a patch to work anytime soon on 1.6.629?

https://github.com/ArranzCNL/ImprovedCameraSE/issues/42#issuecomment-1500776167

Can we expect to have a patch to work anytime soon on 1.6.629?

https://github.com/ArranzCNL/ImprovedCameraSE/issues/42#issuecomment-1500776167

Alright, thanks. Good to know that at the very least the author is still active. Haven't tried this mod yet, but i am eager to see what it has to offer.

Can we expect to have a patch to work anytime soon on 1.6.629?

#42 (comment)


Update bindgen

I haven't been able to compile this since I'm on Linux and not Windows.

Let me know if you want a version bump for Alacritty.

@zacps Would probably be a good idea.

ping @zacps
Would you be able to put out a new release?


samples: boards: nordic: coresight_stm: Test STM dictionary mode

Extend STM logger test.
Use nrfutil trace to decode STM logs in dictionary mode.

FYI: @nordic-piks , @nordic-krch , @gchwier

As this sample doesn't even have a README (hence doesn't show up in the docs), I would suggest you please move it to tests/

This is sample application that shows how to enable STM logging. I prefer to keep it here.
STM functional testing will be put under /tests/ directory.

If you see value in having a sample too (which would make sense) please isolate the testing bits in the tests and keep the sample to the point...

I left check that confirms if sample works correctly:
If a sample can provide output that can be verified, then output should be evaluated against expected value to have some level of testing for the sample itself.

I don't think the user really needs to see the code for logs with zero, one, two, and three arguments to grasp the high level concepts.

I'm not the author of this sample. I prefer to leave sample code as it is.

Also please make sure to add the missing README.

I added README. However, I didn't take part in in development of STM logger. @nordic-krch Could You check if information in the README file is accurate?

Dear reviewers, please find some time to do the review.
This PR adds pytest test to check if logs from all tested cores are printed on the console.

I added Readme file. Where can I check how generated documentation looks like?

@kartben Could You comment if requested changes are addressed?

Sorry, for spamming and dismissing reviews.
I do some minor tweaks based on result (https://builds.zephyrproject.io/zephyr/pr/78947/docs/samples/boards/nordic/coresight_stm/README.html#coresight_stm_sample).

Sorry, for spamming and dismissing reviews. I do some minor tweaks based on result (builds.zephyrproject.io/zephyr/pr/78947/docs/samples/boards/nordic/coresight_stm/README.html#coresight_stm_sample).

Based on the diff, it will likely be worse :) You want to use a definition list.
https://docs.zephyrproject.org/latest/contribute/documentation/guidelines.html#lists
see suggested change

I decided to remove filter for a code coverage run. Let's not pollute sample.yaml.
(+rebased on top of main)

Dear reviewers, please find some time to do the review.


[rewrite:router] routed mount points don't honour m.redraw(true)

m.route(document.body, '/', {
  '/':{view: function(){
    console.log("view")
  }}
})

setTimeout(function(){
  console.log("before")
  m.redraw(true)
  console.log("after")
},100)

http://jsbin.com/vowuqufiva/edit?js,console
Expected: view => before => view => after.
Actual: view => before => after => view
Related: #1268 or #1269 (fixes proposed in either would fix it by making replay synchronous or by not replay-ing on redraw).

Fixed now that #1290 has landed


Version update3 3

Fixes for MacOSX and iOS.  Updated version in Readme to 3.3.

Guess somebody needs to fix Eclipse (w/ ADT) Android compiling because it hasn't been updated in a long time and someone mentioned it recently it wasn't building for them. I'll try to look into myself if I have any free time available to me this upcoming week.


Generate hash for cards that are missing.

I'm thinking of adding the logic here, not sure if it's needed in the customer front end as well. this will save the card with the missing hash.

@mstein-ck @ymwymw please advise if this is a good approach?


Fix long press triggering URL clicks in the comment body

It might be that there is a more elegant solution but in my testing this works and fixes issue #114.

I also just tested it with the swapped longpress behaivor which also works seamlessly. There a click on the url opens, the webpage and a click on on the rest of the comment opens the popup as expected.

Thanks! I've looked at some more proper solutions to this problem before but never managed to solve it so my elegance standards are low for this :) Much appreciated!

Yeah, it was a little bit tricky to solve and took me longer that I would have thought, but I think it was worth the two hours and I now have a even better mental model of the codebase ;)


UTooltip Implement manual controls via simple open property

Description
Implement manual controls via simple open property like on UPopover
Additional context
No response

We are currently doing a major rewrite of the module and support radix-vue that already has an API for this feature.
Make sure to keep an eye on its status via #1289.


Problems with Daly BMS: asyncio.exceptions.TimeoutError

Bluetooth and MQTT are working correctly. But batmon stopped after some minutes and I can not see any entities.
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
22:50:21 INFO [main] BT Discovery:
22:50:26 INFO [main] BT Device   55-F5-CF-D1-06-97   address=55:F5:CF:D1:06:97
22:50:26 INFO [main] BT Device   CF-4D-A3-04-73-E4   address=CF:4D:A3:04:73:E4
22:50:26 INFO [main] BT Device   57-DB-CB-A4-9C-45   address=57:DB:CB:A4:9C:45
22:50:26 INFO [main] BT Device   0F-12-21-51-CE-94   address=0F:12:21:51:CE:94
22:50:26 INFO [main] BT Device   ShellyPlus1PM-A8032ABBA0F4   address=A8:03:2A:BB:A0:F6
22:50:26 INFO [main] BT Device   38-AA-E2-1B-88-4A   address=38:AA:E2:1B:88:4A
22:50:26 INFO [main] BT Device   5A-28-31-87-52-06   address=5A:28:31:87:52:06
22:50:26 INFO [main] BT Device   44-5C-E9-8C-74-5D   address=44:5C:E9:8C:74:5D
22:50:26 INFO [main] BT Device   40-A3-24-FF-55-F3   address=40:A3:24:FF:55:F3
22:50:26 INFO [main] BT Device   F48F924E82DE3396EB   address=ED:ED:F8:9A:E7:62
22:50:26 INFO [main] BT Device   [TV] Fernseher   address=B8:BC:5B:A9:45:EF
22:50:26 INFO [main] BT Device   6A-65-2E-EB-48-D5   address=6A:65:2E:EB:48:D5
22:50:26 INFO [main] BT Device   0B-4A-CB-3D-65-32   address=0B:4A:CB:3D:65:32
22:50:26 INFO [main] BT Device   56-8A-02-A3-D3-F9   address=56:8A:02:A3:D3:F9
22:50:26 INFO [main] BT Device   CD-9A-DE-17-9D-02   address=CD:9A:DE:17:9D:02
22:50:26 INFO [main] BT Device   **DL-C66C09040D19   address=C6:6C:09:04:0D:19** <<-- Daly BMS
22:50:26 INFO [main] BT Device   98E7822CB2BC30AEE9   address=F3:33:CB:E0:36:2B
22:50:26 INFO [main] BT Device   98E7822E732230AEE9   address=F3:33:86:27:45:A1
22:50:26 INFO [main] BT Device   F2-6C-49-8F-38-27   address=F2:6C:49:8F:38:27
22:50:26 INFO [main] BT Device   C9-EE-8B-F8-D6-B4   address=C9:EE:8B:F8:D6:B4
22:50:26 INFO [main] BT Device   00-60-50-3B-82-C2   address=00:60:50:3B:82:C2
22:50:26 INFO [bt] BMS DalyBt(C6:6C:09:04:0D:19) keep alive enabled
22:50:26 INFO [main] connecting mqtt mqtt-user@core-mosquitto
22:50:26 INFO [main] Fetching 1 BMS + 0 others serially, period=1.00s, keep_alive=True
22:50:26 INFO [sampling] connecting bms **DalyBt(C6:6C:09:04:0D:19)**
22:50:26 INFO [main] mqtt watchdog loop started with timeout 120.0s
22:50:31 INFO [daly] found rx uuid to be working: 17 (tx 15, sx 48)
22:50:31 INFO [sampling] connected bms DalyBt(C6:6C:09:04:0D:19)!
22:50:39 ERROR [sampling] battery1 error: <class '**asyncio.exceptions.TimeoutError**'>
22:50:39 ERROR [main] 1 exceptions occurred fetching BMSs
22:50:39 ERROR [main] Error (num 1, max 200) reading BMS:
22:50:39 ERROR [main] Stack: Traceback (most recent call last):
  File "/usr/lib/python3.10/asyncio/tasks.py", line 456, in wait_for
    return fut.result()
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/app/main.py", line 83, in fetch_loop
    await fn()
  File "/app/main.py", line 268, in fn
    raise exceptions[0]
  File "/app/main.py", line 263, in fn
    await t
  File "/app/bmslib/sampling.py", line 50, in __call__
    return await self.sample()
  File "/app/bmslib/sampling.py", line 72, in sample
    sample = await bms.fetch()
  File "/app/bmslib/daly.py", line 122, in fetch
    status = await self._fetch_status()
  File "/app/bmslib/daly.py", line 149, in _fetch_status
    response_data = await self._q(0x93)
  File "/app/bmslib/daly.py", line 108, in _q
    sample = await self._fetch_futures.wait_for(command, self.TIMEOUT)
  File "/app/bmslib/__init__.py", line 46, in wait_for
    return await asyncio.wait_for(self._futures.get(name), timeout)
  File "/usr/lib/python3.10/asyncio/tasks.py", line 458, in wait_for
    raise exceptions.TimeoutError() from exc
asyncio.exceptions.TimeoutError
22:50:48 ERROR [sampling] battery1 error: <class 'asyncio.exceptions.TimeoutError'>
22:50:48 ERROR [main] 1 exceptions occurred fetching BMSs
22:50:48 ERROR [main] Error (num 2, max 200) reading BMS:
22:50:48 ERROR [main] Stack: Traceback (most recent call last):
  File "/usr/lib/python3.10/asyncio/tasks.py", line 456, in wait_for
    return fut.result()
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/app/main.py", line 83, in fetch_loop
    await fn()
  File "/app/main.py", line 268, in fn
    raise exceptions[0]
  File "/app/main.py", line 263, in fn
    await t
  File "/app/bmslib/sampling.py", line 50, in __call__
    return await self.sample()
  File "/app/bmslib/sampling.py", line 72, in sample
    sample = await bms.fetch()
  File "/app/bmslib/daly.py", line 122, in fetch
    status = await self._fetch_status()
  File "/app/bmslib/daly.py", line 149, in _fetch_status
    response_data = await self._q(0x93)
  File "/app/bmslib/daly.py", line 108, in _q
    sample = await self._fetch_futures.wait_for(command, self.TIMEOUT)
  File "/app/bmslib/__init__.py", line 46, in wait_for
    return await asyncio.wait_for(self._futures.get(name), timeout)
  File "/usr/lib/python3.10/asyncio/tasks.py", line 458, in wait_for
    raise exceptions.TimeoutError() from exc
asyncio.exceptions.TimeoutError

config in batmon:

address: C6:6C:09:04:0D:19
type: daly
alias: battery1

Info from the SMAFT BMS app (iPhone):
Battery code: SH39F003
Software version: 210629
Is the version working with Batmon (version 0.0.53) ?

Same but with overkill/JBD.

Did you ever receive any sensor data ?


Switch from GitBook to a different document tool chain

The Gitbook toolchain has been abandoned. We need a different toolchain. AsciiDoctor is a great candidate:

AsciiDoctor is mature/old
AsciiDoctor is active: in the last week there were 18 PRs and 14 closed issues.
There are numerous examples for integrating it with Gradle, which means our doc build aligns with our code build
GIthub renders AsciiDoc files
Asciidoc supports PlantUML so we can inline diagrams easily

Notes on conversion:

Pandoc can convert markdown to AsciiDoc so there won't be a line-by-line conversion. Obviously we'll have to give everything a good eyeballing afterwards.
We'd probably need to re-write the SUMMARY.md file
GitHub pages is Jekyll, and Jekyll has an Ascidoc plugin. This publishing pipeline will need updating though.

Notes on adding diagrams:

Examples of gradle builds for asciidoctor (including building PlantUML diagrams) are here: https://github.com/asciidoctor/asciidoctor-gradle-examples
Using gradle to build the documents with diagrams instead of the command line asciidoctor utilities means we don't need to add dependencies (PlantUML, gems) manually.

Dredging up this old issue as I had been thinking about ideas for improving the docs and wanted somewhere to record my thoughts before they fade off slack.
My concern with asciidoctor is that most examples I have seen render the content as a single page.  This seems a bit grim to me especially when you have a lot of documentation with a lot of images.  I agree that a move to asciidoc for the markup would be good as it is richer and more well defined.
I posted the following on the slack a while back

The docs are a bit of a mess as they are a jumble of different versions of stroom, e.g. how you install 5 is very different from 6 which is different from 7.
My thinking is that if we have a git branch for each minor version, i.e. 5.5, 6.1, and master (7.0) we can then maintain each version as a separate set of docs.  If there are changes common to all versions, e.g. styling then these can be merged up the branches.  If say a new feature is added to 6.1 then it can be added in there and then merged up to master to be available in 7.0.
There may be lots of merge conflicts but I think this is preferable to having each version as a totally independent copy.
I think it should be possible to get travis to checkout each branch, build the gitbook html/pdf and write them to the ghpages branch (in a separate dir for each) so they can all be published on github.io . We can then have a set of links to each version in the root readme.  This would mean a lot of culling is required, e.g. in the 5.5 branch stripping out all the 6/7 content.
Each version would be an independent site so we could say change the theme/look in one version.  The travis build would just need to run the appropriate tool chain for each version.  The only thing tying them together would be a simple single top level index.html page that lives in master and provides the links to the sub-sites.

An example of doing versioned sub-sites with travis (content tool chain aside) is
https://github.com/sdelamo/asciidoc-to-html-gh-pages
I discovered Hugo https://gohugo.io which supports .md and .adoc for content and looks pretty powerful.  This could be a good fit with lots of control for the look.  Their own docs are a good example of what I think we want, a site map on the left that links to the multiple pages and a page TOC on the right, e.g. https://gohugo.io/getting-started/installing/
The need to support puml is key.  Looks like this may be non-trivial with Hugo but there may be a way https://discourse.gohugo.io/t/generate-hugo-website-as-a-pdf/22855.
The other thing we need to ensure is that we can export the docs as a pdf, see here for how to do this in Hugo, https://discourse.gohugo.io/t/generate-hugo-website-as-a-pdf/22855

Requirements for a publishing tool chain :

Source documents in some simple markup, e.g. markdown (existing), asciidoc, etc.
If not markdown, then a painless way of migrating our existing markdown content.
Support for individual documents that are brought together by a main TOC or links between pages.
Ability to generate static html to publish on github pages or to serve somewhere else that stroom can link to it.
Ability to generate a PDF of the whole set of documents
A TOC that is ideally always visible on screen (and collapsible) for easy navigation
A way to publish a version for each git branch and have an overarching page or dropdown that lets you select the version to view.
Ability to render PUML diagrams in the html and pdf.

Worth investigating docsy https://www.docsy.dev/docs/ as this looks to have most things we want.  PDF generation should hopefully be achievable using the hugo link in a prev comment.  Also looks to support puml out of the box.

Docsy it is https://gchq.github.io/stroom-docs/


redis does not start

I have copied the folders and files but after ddev restart the redis process does not start due to this:
1:C 23 Jun 12:28:34.975 # Fatal error, can't open config file '/usr/local/etc/redis/redis.conf'

It seems to work now. As described in the varnish service readme (there are more steps), manually create the redis folder and then copy the config file. Otherwise there could be permission problems.
See also https://github.com/docker-library/redis/issues/120#issuecomment-430049839
The config file has chmod 644 which seems to be fine.


wranglerConfigEnv not picking up env specific bindings on Jest@28

Hey @mrbbot,
It looks like in the latest version of miniflare wranglerConfigEnv is not adding bindings to the global getMiniflareBindings.
wrangler.toml
[[env.dev.kv_namespaces]]
binding = "KEY_VALUE_STORE"
preview_id = "unused"
id = "unused"

jest.config.json
{
  "testEnvironment": "miniflare",
  "testEnvironmentOptions": {
    "wranglerConfigEnv": "dev"
  }
}

test
console.log(getMiniflareBindings()) // {}

However if I add a binding to the global env of the wrangler.toml it picks it up.
wrangler.toml
[[kv_namespaces]]
binding = "KEY_VALUE_STORE"
preview_id = "unused"
id = "unused"

test
console.log(getMiniflareBindings()) // { KEY_VALUE_NAMESPACE: ... }

I just popped it into the global scope as a workaround for now, but this would be a problem when I actually need to publish this worker.  Thanks for looking into it!

Here are all the relevant packages:
"@cloudflare/workers-types": "^3.9.0",
"@types/jest": "^27.5.0",
"jest": "^28.1.0",
"jest-environment-miniflare": "^2.4.0",
"jest-extended": "^2.0.0"

I will try to reproduce it in another project.

That seems to have done the trick.  Also fixed some other weird issues with ts-jest.  I'm going to run with 27 until 28 gets a little more mature.  Ill leave this open with edited title for you to track, but feel free to close if you want.

Will do! Any chance the undici test mocks made it into this release?

Just checked the release notes and looks like no.  Mocking fetch does the trick, but would be nice to have the undici mock instance. Let me know if there's anything I can do to assist on that!

The undici runtime or the cloudflare worker runtime is getting open sourced?

Ah the cf worker runtime. I see! Alright will keep an eye on that!


feat(which-key)!: support v3

So should I merge each one?

So should I merge each one?

This PR is sorta like a superset of the previous one (#1323). u can merge this one if u want the features listed here to be disabled, or the other one if not.


error: Merkle roots differ after transfer: got unexpected result

Getting this error when running the command
coda daemon -peer hello-coda.o1test.net:8303
OS: hostnamectl
   Static hostname: coda-labs-01
         Icon name: computer-vm
           Chassis: vm
    Virtualization: kvm
  Operating System: Ubuntu 18.04.2 LTS
            Kernel: Linux 4.15.0-52-generic
      Architecture: x86-64

Logs: tail -n 20 ~/.coda-config/coda.log
{"timestamp":"2019-07-25 06:24:55.508163Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 500, characters 63-70"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/trust","pid":2741,"typ":"consensus local state"}}
{"timestamp":"2019-07-25 06:24:55.509478Z","level":"Debug","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 467, characters 63-70"},"message":"Long async cycle: $span milliseconds","metadata":{"pid":2741,"span":"10.010089593s"}}
{"timestamp":"2019-07-25 06:24:55.520654Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 523, characters 64-71"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/receipt_chain","pid":2741,"typ":"receipt_chain_database"}}
{"timestamp":"2019-07-25 06:24:55.531070Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 531, characters 62-69"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/transaction","pid":2741,"typ":"transaction_database"}}
{"timestamp":"2019-07-25 06:24:56.897687Z","level":"Debug","source":{"module":"Coda_run","location":"File \"app/cli/src/coda_run.ml\", line 70, characters 52-59"},"message":"Successfully wrote the visualization of the registered masks at location: /root/.coda-config/registered_masks.dot.","metadata":{"coda_run":"Logging state before program ends","pid":2741}}
{"timestamp":"2019-07-25 06:24:56.899918Z","level":"Trace","source":{"module":"Coda_run","location":"File \"app/cli/src/coda_run.ml\", line 75, characters 56-63"},"message":"Shutdown before Coda instance was created, not saving a visualization","metadata":{"coda_run":"Logging state before program ends","pid":2741}}
{"timestamp":"2019-07-25 06:29:37.481377Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 291, characters 65-72"},"message":"Error reading daemon.json: $error","metadata":{"error":"(Unix.Unix_error\"No such file or directory\"open\"((filename /root/.coda-config/daemon.json) (mode (O_RDONLY O_CLOEXEC)) (perm 0o0))\")","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481453Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"external-port","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481467Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"client-port","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481474Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"snark-worker-fee","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481480Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"max-concurrent-connections","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481486Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"work-selection","pid":2883}}
{"timestamp":"2019-07-25 06:29:37.481493Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 313, characters 65-72"},"message":"Key '$key' not found in the config file, using default","metadata":{"key":"peers","pid":2883}}
{"timestamp":"2019-07-25 06:29:38.547970Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 486, characters 54-61"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/trust","pid":2883,"typ":"trust_system"}}
{"timestamp":"2019-07-25 06:29:48.618725Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 500, characters 63-70"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/trust","pid":2883,"typ":"consensus local state"}}
{"timestamp":"2019-07-25 06:29:48.620066Z","level":"Debug","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 467, characters 63-70"},"message":"Long async cycle: $span milliseconds","metadata":{"pid":2883,"span":"10.083974516s"}}
{"timestamp":"2019-07-25 06:29:48.631162Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 523, characters 64-71"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/receipt_chain","pid":2883,"typ":"receipt_chain_database"}}
{"timestamp":"2019-07-25 06:29:48.641164Z","level":"Trace","source":{"module":"Coda","location":"File \"app/cli/src/coda.ml\", line 531, characters 62-69"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/root/.coda-config/transaction","pid":2883,"typ":"transaction_database"}}
{"timestamp":"2019-07-25 06:29:50.081037Z","level":"Debug","source":{"module":"Coda_run","location":"File \"app/cli/src/coda_run.ml\", line 70, characters 52-59"},"message":"Successfully wrote the visualization of the registered masks at location: /root/.coda-config/registered_masks.dot.","metadata":{"coda_run":"Logging state before program ends","pid":2883}}
{"timestamp":"2019-07-25 06:29:50.083269Z","level":"Trace","source":{"module":"Coda_run","location":"File \"app/cli/src/coda_run.ml\", line 75, characters 56-63"},"message":"Shutdown before Coda instance was created, not saving a visualization","metadata":{"coda_run":"Logging state before program ends","pid":2883}}

Error:
    (monitor.ml.Error
  (runtime-lib/runtime.ml.E
    "Merkle roots differ after transfer: got unexpected result"
    ((expected
<PHONE_NUMBER>0467596106866402734597443669063381446628167838929129222958650359402660018169492542114228579857016809663362878702967691140114883880635297843337526424344049903879831696969707777320618038873222528382381697025453708056747)
      (got
<PHONE_NUMBER>1025011603230697695085370554301275323584479787590866411302392047573659534418116050177771442629407029327750673002858692494540135237949546362363166695549101792654595707467823915385172461099965870109734933066241071519040)
      (Loc lib/coda_base/ledger_transfer.ml:25:19)))
  ("Raised at file \"runtime-lib/runtime.ml\", line 28, characters 28-53"
    "Called from file \"runtime-lib/runtime.ml\" (inlined), line 105, characters 27-78"
    "Called from file \"lib/coda_base/ledger_transfer.ml\", line 25, characters 19-32"
    "Called from file \"lib/coda_lib/coda_lib.ml\", line 352, characters 4-73"
    "Called from file \"lib/coda_lib/coda_lib.ml\", line 394, characters 12-52"
    "Called from file \"src/deferred0.ml\", line 56, characters 64-69"
    "Called from file \"src/job_queue.ml\" (inlined), line 131, characters 2-5"
    "Called from file \"src/job_queue.ml\", line 170, characters 6-47"
    "Caught by monitor coda"))

Thank you for the issue report! We're tracking this one in #2991. Closing as duplicate.


Oblivious DNS

Icebox feature to consider adding support for oblivious DNS to okhttp-dnsoverhttps.  No urgency, just flagging it since it seems like a useful privacy focused value add we can provide.
https://blog.cloudflare.com/oblivious-dns/?s=03

Closing as low priority.
Seems like there are other alternatives as well https://community.brave.com/t/support-for-oblivious-dns-over-https-odoh/407327/5


1.0.0 Android probably shouldn't be the recommended as the stable version?

stopWithApp: true just gets ignored
theres also issues with the notification not calling the event handler correctly.
im also sometimes getting stuck in 'playback-queue-ended' never ending loops
clicking notification will also open the app and overwrite the existing player
this.state.position not working in progress component
playback from remote sources appears buggy
im going to migrate back to 0.2.5 for a bit, appreciate all the work you're doing though guys!

I don't have answer for your question But where should I use stopWithApp: true?

Take a look to #333

@alangumer event issues are only the beginning. 1.0.0 on android is still totally broken. im still advising to stick to 0.2.5

We know 1.0.0 is kinda broken, it has been released earlier than I thought it would, but we are slowly but surely fixing all of those issues in the dev branch.

@Guichaguri you're doing a fab job, much respect!


Scala 2.10 version

Hi, do you plan to release scala 2.10 version of this library?

I can see the artifact in the repository (https://mvnrepository.com/artifact/org.zalando/spark-json-schema_2.10/0.4)
Thanks!


Default follow-redirects value for forward-request policy seems to be incorrect

For the <forward-request /> policy, the documentation states that the default value of the follow-redirects attribute is false. However, in our testing, it appears that the default value is actually true. Can you please confirm?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5310021d-de39-9418-2a55-ccdd9c2f4db0
Version Independent ID: ad38bf02-de35-7d67-def7-b1a064dd032f
Content: Azure API Management advanced policies
Content Source: articles/api-management/api-management-advanced-policies.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

Apologies, this was my mistake. The default value is indeed false.

@johndowns Glad to hear that you found the necessary info. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Layout error when used as initial_layout for execute()

Informations

Qiskit Terra version: 0.7.0
Python version: 3.6.4
Operating system: Mac OS 10.14

What is the current behavior?
I generate a simple layout as in the example found in Layout.from_dict() (layout.py) docstring and then execute using the layout as the initial_layout. Use a physical backend, not a simulator.
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/qiskit/transpiler/_transpiler.py", line 109, in _transpilation
    pass_manager=pass_manager)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/qiskit/transpiler/_transpiler.py", line 188, in transpile_dag
    dag, coupling, initial_layout, trials=20, seed=seed_mapper)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/qiskit/mapper/_mapping.py", line 397, in swap_mapper
    for k, v in initial_layout.items()}
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/qiskit/mapper/_mapping.py", line 397, in <dictcomp>
    for k, v in initial_layout.items()}
TypeError: 'int' object is not subscriptable
"""

Steps to reproduce the problem
layout_dict = {}
for qreg in quantum_regs:
    for i in range(qreg.size):
        layout_dict[(qreg, i)] = i
layout = Layout(layout_dict)
execute(quantum_circuits, backend=backend, initial_layout=layout, shots=1024)

What is the expected behavior?
Execution completes successfully and the layout is respected.
Suggested solutions
Currently the hacky solution is to respect the _mapping.py description of the initial_layout and create a Layout such as
layout_dict = {}
for qreg in quantum_regs:
    for i in range(qreg.size):
        layout_dict[(qreg, i)] = (qreg, i)  # Note layout_dict values are tuple.
layout = Layout(layout_dict)
execute(quantum_circuits, backend=backend, initial_layout=layout, shots=1024)

Perhaps _mapping.py needs to respect the Layout?

This issue was fixed at some point (I think, after the Layout object refactor https://github.com/Qiskit/qiskit-terra/pull/1740). In https://github.com/Qiskit/qiskit-terra/issues/1637 I added a test with the code from OP. @ryan-woo feel free to reopen if you consider that the issue is still there.

I've exactly the same problem as ryan, but my python version is 3.7.1
I've just updated qiskit to be sure that it is on the last release.
Another strange thing is that it works if I use only an index in the layout dict, as
 qr = QuantumRegister(1) layout =Layout( { (qr,0) : 1 } )
I'm using the ibmq_16_melbourne  backend.
If it's useful i'll upload the whole code, but it's really the same.

What's your qiskit-terra version?

It is the one visualized by the command qiskit.__version__, right?
It is 0.7.0

The last terra version is 0.7.1. Maybe you want to update it pip install -U qiskit-terra and try again?

It still gives me the same error. This is the code, maybe i've done something wrong:
from qiskit import *
from qiskit.mapper import Layout

qr = QuantumRegister(2)
c = ClassicalRegister(2)
lay = Layout({ (qr,0): 1, (qr,1):10 })
pre = QuantumCircuit(qr, c)
pre.x(qr[0])
pre.barrier()
meas = QuantumCircuit(qr, c)
meas.measure(qr, c)
qc = pre+meas

IBMQ.load_accounts()
backend_exp = IBMQ.get_backend('ibmq_16_melbourne')

qjob = compile(qc, backend_exp, initial_layout=lay, shots=1024)

and gives me the error :
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-8-582d5d1c6d5e> in <module>
----> 1 qjob = compile(qc, backend_exp, initial_layout=lay, shots=1024)

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/tools/compiler.py in compile(circuits, backend, config, basis_gates, coupling_map, initial_layout, shots, max_credits, seed, qobj_id, skip_transpiler, seed_mapper, pass_manager, memory)
     59
     60     circuits = transpiler.transpile(circuits, backend, basis_gates, coupling_map, initial_layout,
---> 61                                     seed_mapper, pass_manager)
     62
     63     # step 4: Making a qobj

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/transpiler/_transpiler.py in transpile(circuits, backend, basis_gates, coupling_map, initial_layout, seed_mapper, pass_manager)
     65                                          'initial_layout': initial_layout,
     66                                          'seed_mapper': seed_mapper,
---> 67                                          'pass_manager': pass_manager})
     68     if return_form_is_single:
     69         return circuits[0]

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/tools/parallel.py in parallel_map(task, values, task_args, task_kwargs, num_processes)
     91     """
     92     if len(values) == 1:
---> 93         return [task(values[0], *task_args, **task_kwargs)]
     94
     95     Publisher().publish("terra.parallel.start", len(values))

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/transpiler/_transpiler.py in _transpilation(circuit, backend, basis_gates, coupling_map, initial_layout, seed_mapper, pass_manager)
    107                               format='dag',
    108                               seed_mapper=seed_mapper,
--> 109                               pass_manager=pass_manager)
    110
    111     out_circuit = dag_to_circuit(final_dag)

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/transpiler/_transpiler.py in transpile_dag(dag, basis_gates, coupling_map, initial_layout, format, seed_mapper, pass_manager)
    186             dag = BarrierBeforeFinalMeasurements().run(dag)
    187             dag, final_layout = swap_mapper(
--> 188                 dag, coupling, initial_layout, trials=20, seed=seed_mapper)
    189             logger.info("final layout: %s", final_layout)
    190             # Expand swaps

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/mapper/_mapping.py in swap_mapper(circuit_graph, coupling_graph, initial_layout, trials, seed)
    395         device_register = QuantumRegister(coupling_graph.size(), 'q')
    396         initial_layout = {(circuit_graph.qregs[k[0]], k[1]): (device_register, v[1])
--> 397                           for k, v in initial_layout.items()}
    398         # Check the input layout
    399         circ_qubits = circuit_graph.get_qubits()

/anaconda3/envs/Qiskitenv/lib/python3.7/site-packages/qiskit/mapper/_mapping.py in <dictcomp>(.0)
    395         device_register = QuantumRegister(coupling_graph.size(), 'q')
    396         initial_layout = {(circuit_graph.qregs[k[0]], k[1]): (device_register, v[1])
--> 397                           for k, v in initial_layout.items()}
    398         # Check the input layout
    399         circ_qubits = circuit_graph.get_qubits()

TypeError: 'int' object is not subscriptable

thanks for your support!

can you try with master?

Sorry, but I'm quite new to this.
What do you  mean by "try with master"?


[stable/cluster-autoscaler] Add extraEnvFromSecret parameter

What this PR does / why we need it:
This parameter can be useful if we want to supply the access keys via an
external secret. This should work with any cloud provider.
In my case I don't want to authorize the workers to interact with the ASG,
as any container running in the cluster would be allowed to do so,
instead I have created an IAM user and stored the credentials in a
secret.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Bump @viglesiasce @prydonius

/assign
/ok-to-test
/lgtm


[Run] Add commands history in results

Observed: PowerToys 0.20.1
Proposal:
Include details of previously run commands in the results for PowerToys Run.
Details

Launch PowerToys Run
Type a command (e.g. shutdown /r /t 0 /f) and run it.
When the action is completed, launch PowerToys Run again.
Type a command or URL that has been run previously (e.g. the example above)

Observed Behaviour
The command is not in the list of suggested actions to run
Expected Behaviour

Similar to the 'traditional' stock Windows "Run" functionality, the history of previously executed commands should be available.
This is stored in the registry Computer\HKEY_USERS\<User_SID>\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\RunMRU
Including this data in the PowerToys Run results would help PowerToys Run become a full replacement for the existing OS 'Run' box

Exists this bug also in 0.21.1 ?

Thanks. I tested today and it is also in 0.21.1.
Kind regards,
Paul

From: Aaron Junker<EMAIL_ADDRESS>Sent: Thursday, September 3, 2020 7:58:48 PM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: paulf-personal<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] [PowerToys Run] Include Previously run URLs and Commands in results (#6322)
Exists this bug also in 0.21.1 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F6322%23issuecomment-686696304&data=02|01||a8026126620d407bd4c908d8503b6476|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347563295977279&sdata=UdLVXKumxJOR1sYo%2Fia%2BsMtOZS%2BFYHDxenDAtZVsZcY%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKRGESWV7P3PDJJR6WYQ2ZDSD7RORANCNFSM4QUTFTVQ&data=02|01||a8026126620d407bd4c908d8503b6476|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347563295977279&sdata=%2FNf7kir%2B9vSSCEt4cFNAQqtUoftWTMHcsu541SdQjAU%3D&reserved=0.

This is a change in behavior.  The ask is to have a running list of past commands in the drop down vs the result based on return.
Example if i typed >ping github.com and then came back, it would show that command still.  But if i ran lets say 5 different apps + that, those aren't displayed.
@paulf-personal, you're looking more for this screenshot from runprompt, no?

Correct, that is the proposal / feature request.it would greatly enhance the functionality of the Power Toys Run.
Kind regards,
Paul

From: Clint Rutkas<EMAIL_ADDRESS>Sent: Thursday, September 3, 2020 9:42:23 PM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: paulf-personal<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] [PowerToys Run] Include Previously run URLs and Commands in results (#6322)
This is a change in behavior. The ask is to have a running list of past commands in the drop down vs the result based on return.
Example if i typed >ping github.com and then came back, it would show that command still. But if i ran lets say 5 different apps + that, those aren't displayed.
@paulf-personalhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpaulf-personal&data=02|01||ea5ca948345541f0e97608d85049dd28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347625451539570&sdata=yqTk6okWBMw7mmrACdwqtYg4V%2B8qfmKfcOjmsjo3pYU%3D&reserved=0, you're looking more for this screenshot from runprompt, no?
[image]https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F1462282%2F92164987-2c9ff780-edeb-11ea-9dfa-ba14f92b5940.png&data=02|01||ea5ca948345541f0e97608d85049dd28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347625451539570&sdata=UN3CrH6KsKaMreruQzZGCj%2BZPtXlcvB%2BInp7z87mzlQ%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F6322%23issuecomment-686754427&data=02|01||ea5ca948345541f0e97608d85049dd28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347625451539570&sdata=g%2FJAhyzXmfoAzOGWh02mwTs47tzPh4VaR7x76H6tuW8%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKRGESRTFS6VTUFWAGWCIVTSD75S5ANCNFSM4QUTFTVQ&data=02|01||ea5ca948345541f0e97608d85049dd28|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637347625451549566&sdata=hVCFRo1YBGcqx52zJbPJypLGqaCUaW6AVt2Wp7ZJWXk%3D&reserved=0.

@paulf-personal
in 0.29 this is available for the shell plugin, are you asking to have history also for other plugins?

@paulf-personal
in 0.29 this is available for the shell plugin, are you asking to have history also for other plugins?


Pac-Man Game Added

PR Description 📜
This pull request represents the successful addition of the Pac_Man game to the games directory, ensuring strict adherence to the established code of contributing guidelines and code of conduct.
Pac-man is an interesting game where players control a yellow, circular character named Pac-Man through a maze filled with dots and ghosts.
Fixes #199

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Explorer003 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @Explorer003 👋!
@kunjgit here,
We have this annoucement to make 📢!!
During the time of PR don't alter main index file ! 🙂
In main Readme file just use * as a game number during the time we are merging we will add number !! 👀
Make sure you join our Discord🕹 if you haven't 😇
Thank you 💗!

Hey @Explorer003 !! we have this game

Thank you  @Explorer003 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


docs(core): add description in README for passing xml with the web component

GH-25
Description
add the description in README about the usage of bpmnDiagram(XML) with web component.
Fixes #25
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

rectify the commit message.

@arpit1503khanna  is this resolved

@arpit1503khanna is this resolved

I have asked aryansh sir , to let me know if the solution recommended is working or not.


Youtube outdated player

Trying to play anything on youtube and the result is out of date youtube player. This is on the latest version of lavaplayer has has been a problem for sometime.

https://github.com/lavalink-devs/youtube-source


ReferenceError: window is not defined

Hi, your library works great on development - very happy! My nodejs/npm isn't my primary skill set, so let me know if I'm making any noob errors. I'm working on a project that uses webpack, react and redux.
I'm using pusher-redux and installed pusher-js separately since (IIRC) it oddly didn't install automatically as a dependency. The library works great on dev, though it does give me the following error:
var btoa = (window).btoa || function (b) {
                         ^
ReferenceError: window is not defined
at Object.<anonymous> (/home/user/project/node_modules/pusher-redux/node_modules/pusher-js/dist/web/pusher.js:890:27)
at __webpack_require__ (/home/user/project/node_modules/pusher-redux/node_modules/pusher-js/dist/web/pusher.js:38:30)
at Object.<anonymous> (/home/user/project/node_modules/pusher-redux/node_modules/pusher-js/dist/web/pusher.js:638:17)
at __webpack_require__ (/home/user/project/node_modules/pusher-redux/node_modules/pusher-js/dist/web/pusher.js:38:30)
....<snip>

This is the identical error to this error on pusher-js.
I see the error happening on the dev box, but npm start -s doesn't choke on it, and runs things fine anyway. However, when I run npm run build, the error is fatal and it doesn't complete the process of generating the resulting dist files.
Versions:
"pusher-js": "4.0.0",
"pusher-redux": "0.1.1"
Do you have any suggestions?
Many thanks!

interesting, I am using this with webpack in production and no issues so far :-/

I cleared out node_modules and reinstalled, and still getting this error.
Dependency list:
"connect-history-api-fallback": "1.3.0",
"file-downloader": "2.1.0",
"font-awesome": "4.7.0",
"font-awesome-webpack": "0.0.4",
"less": "2.7.1",
"lodash": "4.17.2",
"moment": "2.17.0",
"object-assign": "4.1.0",
"pusher-redux": "0.1.1",
"react": "15.4.1",
"react-dom": "15.4.1",
"react-redux": "4.4.6",
"react-router": "3.0.0",
"react-select": "1.0.0-rc.3",
"react-timeago": "3.1.3",
"redux": "3.6.0",
"redux-api-middleware": "1.0.2",
"redux-thunk": "2.1.0",
"resolve-url-loader": "1.6.0",
"url-loader": "0.5.7"

@TheRusskiy ^^

Is there any way to instantiate pusher-redux when there "is a window"? I'm not sure why it doesn't think there is a browser (presumably because it is writing the main js file)... can you comment?

Turns out this issue is with the wrong target (node rather than web) when it was attempting to run tests.

Also had this issue due to server side rendering. Window is not present when my component gets rendered server side. My solution was to wait till component had mounted to ensure window was present as follows:
componentDidMount() {
  const subscribe = require('pusher-redux');
  subscribe(...);
}

componentWillUnmount() {
  const unsubscribe = require('pusher-redux');
  unsubscribe(...);
}


Tooling to update data in place

@kshepard could you flesh out?

Overview
DistrictBuilder data will need to be updated several times in the future (adding additional demographics, etc.), and we would like to have some tooling in place to make this straightforward. There are a couple key challenges that need to be addressed here:

The initial data that has been published was not sorted by any specific value, and the sort order matters, as it's inherently used in the topological structure
There are some changes that will be incompatible. E.g. if a block group shifts from one county to another. We will need to detect any incompatibilities, because we don't want to update data and have everyone's existing maps break. Note: we don't need to solve the problem of what to do with incompatible data as part of this task -- we will eventually need to create a migration strategy, but simply being able to detect it now will be good enough.

In hindsight, the easiest way to proceed would have been ordering the geounits by their ids before doing any processing. However, even in this case, we'd still need to look at the previous data to be able to detect incompatibilities. If we were to try ordering it in this manner now, we'd need a migration plan, with code that would adapt all existing plans from the old format to the new one. I would like to avoid this, as it would be hard work, and would require downtime.
After thinking about it, I'm thinking the best approach is likely the following:

Aim to keep the initial plans valid by using that same ordering for future updates
We would need to update the process-geojson command to accept an optional S3 URL for the existing data. The command would pull down the topology, and would sort the new data based on the sort order within this topology.
While this is happening, this will be the ideal time to check for data inconsistencies: if the hierarchy is different in any way, we raise an error stating what's inconsistent, and halt processing
The publish-region command will be unchanged: we will still want to publish it separately and test locally to ensure all is well before pushing to production
We will need a new command (update-region?), which is very similar to publish-region, except it simply uploads the data to an existing S3 URL that's specified as a parameter, and then performs no database updates (the static data is changing in-place, so no database update is needed)

Acceptance criteria

The process-geojson command can accept an optional S3 URL for updating existing data. It will use the existing data's sort order for sorting the new data.
Data inconsistencies are checked for, and if any are found, an apropriate error is raised and processing is halted
A new update-region command is created to allow for pushing new data to an existing S3 URL


Change default timeout value

Currently the default zdns timeout value is 10 seconds. The default BIND timeout value is also 10 seconds. This creates a situation where zdns frequently returns TIMEOUT a few milliseconds before BIND returns SERVFAIL (assuming default invocations of both).
Bumping this to 15 seconds seems reasonable.

Why not 11 seconds?

Sure. I was going for a value that seemed "normal" by human standards, since it doesn't actually matter. Assuming a properly configured upstream resolver (which is totally trivial, right @zakird?) 11s should behave the same as 15s, over a large number of queries.


view: render the user goals screen for logged in user

This is how that view is being rendered:
res.render('dashboard', { // render handlebar view to display all goals by selected user
comments,
loggedIn: req.session.loggedIn
});

res.render('dashboard', { // render handlebar view to display all goals by selected user
goals,
loggedIn: req.session.loggedIn
});

res.render('userdashboard', { // render handlebar view to display all goals by selected user
goals,
loggedIn: req.session.loggedIn
});


⚠ Bofrost.be has degraded performance

In ec96bfb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1851 ms

Resolved: Bofrost.be performance has improved in ae6b922.


Compare with Cython implement

Thank you @Maghoumi  , I am investigating your amazing source code, but have you compare this with the Cython implement: https://github.com/mblondel/soft-dtw
I have used your softDTW in CUDA but with the Batch Size = 1, my GPU is nearly Out of memory, can not increase more

Here is my input size,

I wonder how can you use the batch size up to 256

Sorry for the late response.

but have you compare this with the Cython implement: https://github.com/mblondel/soft-dtw

Compare in what sense? In terms of speed, there's already a profiling function that compares the speed.

I wonder how can you use the batch size up to 256

It's a generic question, and the answer of course depends on what hardware you're using and what the nature of your data is. In our case, our data consisted of sequences with the length of at most 64 steps and overall fairly small. Also, our experiments were running with GPUs that had 32GB of VRAM.

Sorry for the late response.

but have you compare this with the Cython implement: https://github.com/mblondel/soft-dtw

Compare in what sense? In terms of speed, there's already a profiling function that compares the speed.

I wonder how can you use the batch size up to 256

It's a generic question, and the answer of course depends on what hardware you're using and what the nature of your data is. In our case, our data consisted of sequences with the length of at most 64 steps and overall fairly small. Also, our experiments were running with GPUs that had 32GB of VRAM.

Thank you, I found that my feature up to [sequence len = 1024, hidden dim=80], it seems too long for softDTW to run with large batch size, my GPU is RTX3090.


[PL-44116] PL 1.22.x release notes

PL-46590 PL 1.22.x SaaS release notes
https://harness.atlassian.net/wiki/spaces/PD/pages/21618098251/NG+Release+SAAS+January+22nd+2024+for+1.22.x-+Build
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b535eb61304ec44872f354--harness-developer.netlify.app

@saifeemustafaqharness remember to add Zendesk ticket number references when they are included.

Is there a preview link for this?

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b8d48e477640d0ddee400c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b8d5a1efd853ca8799ba93--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b9282449370209a3546120--harness-developer.netlify.app


fix(Types): TS type definitions didn't use the correct export mechanism

Reverting #12c93cb that has broken TS support.
based on @aarondail's issue:
https://github.com/rebeccahughes/react-native-device-info/issues/208
We've bumped into the same problem.

YES!  Will always merge awesome typescript!


pin google-api-python-client to 1.6.7 to avoid breakage

Tentative fix for https://github.com/grpc/grpc/issues/15600.
(looks like google-api-python-client 1.7.0 was released 11 hours ago, which seems to coincide with the breakage
https://pypi.org/project/google-api-python-client/#history)

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

This PR seems to be helping, but it would only fix on master branch, so ideal solution would be fixing https://github.com/google/google-api-python-client/issues/516.  But let's merge this PR anyway if the resolution is not super quick.

[microbenchmarks] No significant performance differences

Merging to unbreak mac builds. We can revert later once google/google-api-python-client#516 is fixed.


Display articles in all user languages on Press page

Description
Currently the Press page only displays articles in the primary language that is set, now it should display articles in all languages that the user uses.
Other changes
changed the enum in languages.ts, but I checked and it isn't being used anywhere else so should be fine.
Tested
I set my Chrome settings to also include Chinese, Chinese articles appeared on the press page
Related issues

Fixes #4791

good work. just a few refinements


⚠ Bofrost.lu has degraded performance

In f8192ed, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1703 ms

Resolved: Bofrost.lu performance has improved in e9a9c71 after 6 minutes.


Documentation uses † in the markdown, but it's rendered as 1

This is not so much a bug as an oddity (I noticed it while tracking down another bug in deadlinks: https://github.com/deadlinks/cargo-deadlinks/issues/133#issuecomment-748399781). In https://github.com/rust-lang/cargo/blob/94e21ada550f91f5d32f2f51635792a79aeb8d63/src/doc/src/reference/build-script-examples.md#build-script-examples, the link shows †, but it shows up differently when rendered:

I assume that's not intentional? Is this a mdbook bug maybe - I think footnotes are an mdbook extension? The links work fine, it just seems odd.

I wouldn't consider it a bug.  The footnote references can be any sort of label (a word for example), and those get numbered sequentially.  That makes it easier to maintain so you don't have to renumber footnotes when they are added/removed.  It could be changed to a more descriptive label, but I'm not sure it really matters.

I wouldn't consider it a bug.  The footnote references can be any sort of label (a word for example), and those get numbered sequentially.  That makes it easier to maintain so you don't have to renumber footnotes when they are added/removed.  It could be changed to a more descriptive label, but I'm not sure it really matters.


Design Meeting Notes, 5/21/2020

Always Emit export {}
https://github.com/microsoft/TypeScript/issues/38696

What does "always" mean?
If there were import/export statements in the file, there must at least be one import or export in the output.
We already have this rule in declaration files.

We just don't do it in module output.
We probably do.

This is valuable for tools like Webpack/TypeScript, but there's a class of users who won't want this.

They will have a point.

Conclusion

Add the export {}.
Do we need a patch release?

Sounds like no.

https://github.com/microsoft/TypeScript/pull/38712

Optimization hints on classes
https://github.com/microsoft/TypeScript/pull/38602
https://github.com/microsoft/TypeScript/pull/38566
In 3.9 we started emitting an IIFE around classes with statics when targeting ES2015.
class C {
    static x = someExpression();
}

Becomes
let C = /** @class */ (() => {
    class C {
    }
    C.x = someExpression();
});

Closure can't understand this output.
https://www.hyrumslaw.com/

Why are we emitting the noise anywhere?

https://github.com/microsoft/TypeScript/issues/16414
Exacerbated by https://github.com/microsoft/TypeScript/pull/32011

Shouldn't classes be used? Sounds like it should've been a dead-code elimination problem.

Bundlers not always good at tree-shaking.

Want to give the option, but maybe the default should be nice output.
Conclusion: ask more about the current issues, understand the problem better.

Allow modules to implement interfaces
https://github.com/microsoft/TypeScript/issues/420

What about contextual typing and inference on the members?

We already have that on values in general, don't co-mingle that.
https://github.com/microsoft/TypeScript/issues/7481

What about being able to validate that types are present?

Now you need to have meta-typed module system.

Most people seem to just want to validate the types.
What are the wins?

React Native platform-specific modules.
Config files

https://github.com/microsoft/TypeScript/issues/420#issuecomment-629853785
https://github.com/microsoft/vscode-eslint/issues/124
Needs JSDoc support then.

Plugin Systems
Mocking in Tests

Maybe the syntax might differ depending on module type.
Could imagine there's just a design-time check for type compatibility.

Assert a value or type conforms to some other type.

Problems

The syntax space isn't fleshed out
There's a lot of adjacent proposals
There's no way to make this check things other than modules.

@DanielRosenwasser I'm happy to talk to any of you about the class emit shape and #32011 - I think the wrapping is the right behavior at the moment. See https://github.com/microsoft/TypeScript/issues/38374#issuecomment-632920137

So, for those of us that don't want or need this behavior. What is the work around? This should be done explicitly by the user if they want to export export {}. This breaks my code for service workers when I'm importing only types.

RE: Allow modules to implement interfaces
export implements seems like the most natural syntax to me. Compared to module implements at least. module has a few meanings in TypeScript world.
One of the biggest wins is Next.js and other similar frameworks that expect a file to export specifically named functions for various things.


Bind attribute name in vNext

I looked through vNext.md and am very impressed by the way that you're examining any idea that may improve the API; as I said earlier, I think the library already has a very concise and effective way of getting things done. Much respect.
The name of the actual HTML attribute isn't that important, in my opinion, but db="..."> could be a bit confusing.
I suggest something like viewmodel="...">, vm="...">, bind-vm="...">, or simply bind="..."> – but at the same time think you should keep data-bind="..."> for those who get uncomfortable without the data- prefix :)

Thanks for the compliment. I try hard to make development as painless as possible.
The goal is to be concise out of the box (less crap), so db= as shorthand for data-bind= seems fitting. vm= doesn't seem right because you're not declaring a view model but the bindings instead.
I plan to give the user the option to change it with one line anyway. So if you prefer viewmodel= or data-bind= you can just add ViewModel.BindAttribute = "data-bind"; somewhere and you're good to go.

.bindAttribute sounds good – and fair point about vm=. I still think db= is confusing, though, since it pretty ubiquitously refers to a database.
Maybe you view data-bind as a full name, rather than as a HTML5 data attribute with the name bind?
I think many will interpret the attribute's name as simply bind, the way it is used now. But I think omitting the data prefix would send a nice signal, since it would make ViewModel feel more like a native part of Meteor*.
*The same way the framework uses the name= attribute on <template> without the HTML5 data prefix and the way Angular doesn't care about prefixing its attributes, either


Backport core String lib refactor fix PR and migrate all ImmutableMap with j.u.map

Description
This PR should fix refactor changes in this core backport PR https://github.com/opensearch-project/OpenSearch/pull/8382, meanwhile we've migrated all ImmutableMap with java.util.HashMap and use Collections.unmodifableMap or use java.util.Map.of(... by @nknize 's recommendation.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please notice that integ test fail at this moment because container is not updated. We can wait until all tests are passed.

All tests passed, build success.

@nknize We think a better idea is to use a separate PR to do the migration so that you can review it whenever you are free. Close it.


Is it possible if our object has more than one person?

Your work is so cool !  And  I am curious that Is it possible if our object has more than one person? Thankyou

Hi, thank you! Our project mainly focuses on the single-person setting but it should work okay-ish with the multi-person scenarios if there is no occlusion between the people.


Consider removing NodeModuleFile

          I'm thinking we might want to just remove this entirely? It doesn't seem to be used anywhere in the main repo. I haven't yet looked in contrib.

Originally posted by @dyladan in https://github.com/open-telemetry/opentelemetry-js/pull/4295#discussion_r1399343587
Evaluate impact on contrib repo as well as interface-only options

Closed because this is used heavily in contrib


Update textfield.py

I modified textfield.py to solve the problem of the cursor moving out of the box. This image reports the bug that previously existed.

You can reproduce this issue by setting a max height and then add some lines to reach the max_height, and then scrowlup, and you will see the cursor moving outside the box.
This is a simple example to repruduce the issue:
from kivy.lang import Builder

from kivymd.app import MDApp

KV = '''
MDScreen
    MDTextField:
        size_hint_x: .5
        hint_text: "multiline=True"
        max_height: "200dp"
        mode: "fill"
        fill_color: 0, 0, 0, .4
        multiline: True
        pos_hint: {"center_x": .5, "center_y": .5}
'''

class Example(MDApp):
    def build(self):
        return Builder.load_string(KV)

Example().run()

@Jonypr-code
Thanks for the PR!
Please try to make more detailed commits: what exactly did you change, why.
Update textfield.py is not a very good commit since it doesn't carry any information.

Yes i agree, im very proud of myself helping for helping this library, i will change the name of the pr, and i will change other thing in the code, you will see if it has +20 it dont works with other modes, only with fill mode, the fix is just replacing to + 10.

@Jonypr-code
Please try to make more detailed commits: what exactly did you change, why.
Update textfield.py is not a very good commit since it doesn't contains any information.

@Jonypr-code Developers who, for example, will read the history of commits after seeing the text of your commit, will not understand anything.

The changes you applied are great, but pay attention to linter requirements. This is the only problem.

Yes, i understand it, but i saw that the problem is with an unused import in a file that i didnt change nothing, the filemanager.py. I just changed the textfield.py.The other commits worked fine, i dont know why it changed to this last commit.


Add open telemetry tracing to go using interceptors

One of our users has recently noticed that we don't have Query/Signal interceptors.
We should address this TODO and add interceptors for Signal/Query.

We should be able to support open tracing for all calls, headers should be available on API calls too.
Discuss with @Spikhalskiy who has a lot of context in java.

Need to make sure that headers are passed on the server for signal/query.

I'm going to keep this issue focused on Signal/Query as it's more specific.


Units reaching max morale should cheer

Trigger cheer when unit morale is equal to max morale

Related to issue #10 and should be tested concurrently

Related to issue #4


Unable to resolve "./lib-cov..."

I started getting this error where it can't find /lib/lib-cov which is being required in index.js. The file doesn't exist. I'm not sure what process.env.JSCOV and I'm not sure why it's true, which may be the issue?
I'm using this package with Meteor, which is on Node 0.10.43 and npm 2.14.22 currently which may also be the issue? I'm not sure.
For now I just changed the exports to require lodash-inflection.js instead and it's working fine.

lib-cov is generated when running gulp jscov and is needed for coverage.
JSCOV should not be set to true unless you want to run test coverage.
I think it should work just fine if you unset JSCOV.
Could you try and let me know how it goes please?

@tuvistavie I can confirm that using Webpack's DefinePlugin fixed this:
new webpack.DefinePlugin({
      'process.env.JSCOV': JSON.stringify(false),
    }),


"Integer expected" error

The error is displayed whenever trying to run queries.
I have been looking into the exception generating the message, and it seems to originate from the parseInteger method within the Parser class (line 58). The method calls the nextToken method, which returns 2, causing the parseInteger method to throw the exception.
The exception is caught on line 155 in the Engine class and thrown as an EngineException.
All the classes mentioned above are part of the model.jar file located within the libs folder and originate from UPPAAL. The method called from H-UPPAAL causing the exception is located on line 150 in the UPPAALDriver class. The input is a UppaalSystem object, which is generated based on the HUPPAALDocument generated for the project. This also happens within the Engine class inside the model.jar and is assumed be handled correctly, hence the element closest to the exception handled by H-UPPAAL is the UPPAALDocument generated inside the HUPPAALDocument class.
I have also discovered that the 10. Semester project mentioned that H-UPPAAL was compiled using UPPAAL version 4.1.19 (from 2014). Using this version, a “Syntax error” is shown instead of the “Bug: Integer expected” error. This error is given within the parseProlog method inside the Parser class.

I haven't seen that error before. Do you still have the diagrams that produced the Integer expected error? If you zip the files and attach them to this PR, I'll take a look at the problem.

I haven't seen that error before. Do you still have the diagrams that produced the Integer expected error? If you zip the files and attach them to this PR, I'll take a look at the problem.

I am unable to recreate the error, after trying on both Windows and Ubuntu with two different sample projects, so I assume that it is no longer an issue. I will close this issue

I am unable to recreate the error, after trying on both Windows and Ubuntu with two different sample projects, so I assume that it is no longer an issue. I will close this issue


The NAWS Download Link Is In A Bad Place

It's immediately above the Delete Button in the Service Body Admin page.
It should either be removed, or moved away from that button.
I guess that could be done with CSS, but it might be easier to move it in the PHP code.

Fixed in 2.11.2.

Looks good to me.


Remove outdated comment in pallet asset

The check is now required when transfering to unexisting accounts.
This is probably inherited from previous architecture. Anyway the code always handled this case.

bot merge

bot merge


Added EOS Educational youtube channel

Only two videos so far, but very indepth and well explained. Great for beginners to get an overview.
https://www.youtube.com/channel/UClgHiX4W1yxyohrif0gEllA

Thanks for adding!


Updated submodules to 'v7.1.0' tag

Also harmonised conf headers to latest 7.1.0 templates.

Awesome! Thank you very much for the quick update!

FWIW I'd been shamelessly copying the config files from the eclipse project: https://github.com/lvgl/lv_sim_eclipse_sdl

@MCF it also could al work


[RELEASE] 1.6.1

What's the task? Please describe.
Action items for releasing v<x.y.z>
Describe the sub-tasks.

Pre-Release

[x] Regression test plan (manual) - @roger-ryao (release captain)
[x] Run security testing of container images for pre-GA milestones - @roger-ryao
[ ] Verify longhorn chart PR to ensure all artifacts are ready for GA (install, upgrade)  @mantissahz
[x] Run core testing (install, upgrade) for the GA build from the previous patch and the last patch of the previous feature release (1.5.4). - @chriscchien

Release

[ ] Release longhorn/chart from the release branch to publish to ArtifactHub
[x] Release note @jillian-maroket

[x] Deprecation note
[x] Upgrade notes including highlighted notes, deprecation, compatible changes, and others impacting the current users

Post-Release

[ ] Update https://github.com/longhorn/longhorn/blob/master/deploy/upgrade_responder_server/chart-values.yaml @PhanLe1010
[ ] Add another request for the rancher charts for the next patch release (1.6.2) @rebeccazzzz

Rancher charts: verify the chart can be installed & upgraded - @khushboo-rancher

[ ] rancher/image-mirrors update @mantissahz @PhanLe1010
[ ] rancher/charts 2.7 & 2.8 branches for rancher marketplace @mantissahz @PhanLe1010

cc @longhorn/qa @longhorn/dev

@roger-ryao The QA release captain needs to ensure the QA items in the description have been updated eventually.
cc @longhorn/qa

Run security testing of container images for pre-GA milestones:
v1.6.1-rc1: 2 HIGH, 0 CRITICAL
v1.6.1-rc2: 2 HIGH, 0 CRITICAL

cc @c3y1huang

Run security testing of container images for pre-GA milestones:
v1.6.1-rc1: 2 HIGH, 0 CRITICAL v1.6.1-rc2: 2 HIGH, 0 CRITICAL

longhornio/longhorn-manager:master-head (suse linux enterprise server 15.5)
===========================================================================
Total: 0 (HIGH: 0, CRITICAL: 0)

usr/local/sbin/longhorn-manager (gobinary)
==========================================
Total: 2 (HIGH: 2, CRITICAL: 0)

┌──────────────────────────────────────────────────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐
│                           Library                            │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version │                            Title                            │
├──────────────────────────────────────────────────────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ go.opentelemetry.io/contrib/instrumentation/google.golang.o- │ CVE-2023-47108 │ HIGH     │ fixed  │ v0.35.0           │ 0.46.0        │ opentelemetry-go-contrib: DoS vulnerability in otelgrpc due │
│ rg/grpc/otelgrpc                                             │                │          │        │                   │               │ to unbound cardinality metrics                              │
│                                                              │                │          │        │                   │               │ https://avd.aquasec.com/nvd/cve-2023-47108                  │
├──────────────────────────────────────────────────────────────┼────────────────┤          │        ├───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ go.opentelemetry.io/contrib/instrumentation/net/http/otelht- │ CVE-2023-45142 │          │        │ v0.35.1           │ 0.44.0        │ opentelemetry: DoS vulnerability in otelhttp                │
│ tp                                                           │                │          │        │                   │               │ https://avd.aquasec.com/nvd/cve-2023-45142                  │
└──────────────────────────────────────────────────────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘

This is caused by indirect dependencies from upstream (https://github.com/kubernetes/kubernetes/blob/v1.28.5/go.mod#L72-L73)
Currently, those haven't been fixed upstream:

https://github.com/kubernetes/kubernetes/pull/121842
v1.28.8: https://github.com/kubernetes/kubernetes/blob/v1.28.8/go.mod#L72-L73
v1.29.3: https://github.com/kubernetes/kubernetes/blob/v1.29.3/go.mod#L72-L73

Run security testing of container images for pre-GA milestones:
v1.6.1-rc1: 9 HIGH, 0 CRITICAL
v1.6.1-rc2: 9 HIGH, 0 CRITICAL
v1.6.1-rc3: 11 HIGH, 0 CRITICAL

@roger-ryao do you know why the result is different for rc1 and rc2 from your previous test?
https://github.com/longhorn/longhorn/issues/8209#issuecomment-2008602019

@roger-ryao do you know why the result is different for rc1 and rc2 from your previous test?
#8209 (comment)

SUSE Security Advisories after 3/26 are why the test results were different from the previous test results.
This update for krb5 fixes the following issues:

CVE-2023-26458: Fixed memory leak at /krb5/src/lib/rpc/pmap_rmt.c (bsc#1220770). https://www.suse.com/security/cve/CVE-2023-26458.html
CVE-2023-26461: Fixed memory leak at /krb5/src/lib/gssapi/krb5/k5sealv3.c (bsc#1220771). https://www.suse.com/security/cve/CVE-2023-26461.html
CVE-2023-26462: Fixed memory leak at /krb5/src/kdc/ndr.c (bsc#1220772).
https://www.suse.com/security/cve/CVE-2023-26462.html

I meant you don't need to rerun the old RCs (RC1 and RC2), as you already ran it. Next time, just need to run the latest release.

1.6.1 images are ready. @chriscchien @mantissahz Please help finish the testing. Thanks.

https://github.com/longhorn/longhorn/commit/51c05f714c264b0d2d88543b58837ff27792e15e
https://github.com/longhorn/charts/commit/35833202fc0df11d6ee61b735990a8d0356b29e4

Run core testing (install, upgrade) for the GA build from the previous patch and the last patch of the previous feature release (1.5.4):
amd64: 0 failure
arm64: 0 failure
amd64 upgrade: 0 failure
arm64 upgrade: 0 failure

Install and upgrade with longhorn/longhorn/charts and longhorn/charts

longhorn/longhorn/charts@51c05f7
longhorn/charts@3583320

Environment:

Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v1.28.3+k3s2

Number of control plane nodes in the cluster: 1
Number of worker nodes in the cluster: 3

Node config

OS type and version: ubuntu 2204
Kernel version: 5.15.0-91-generic
CPU per node: 4
Memory per node: 8096MiB

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): KVM
Number of Longhorn volumes in the cluster: 2

Fresh install with longhorn/longhorn/charts or longhorn/charts: PASSED

Create workloads with LH volumes
Backup and restore LH volumes
Delete LH

Upgrade: PASSED

Fresh installation LH v1.5.4 or v1.6.0:
Create workloads with LH volumes
Backup LH volumes
Upgrade LH with longhorn/longhorn/charts or longhorn/charts
Create workloads with LH volumes
Backup and restore LH volumes
Delete LH

@mantissahz @PhanLe1010 We will wait for 1 week to see the feedback on 1.6.1. After that if no outstanding issue, we can start to prepare the Rancher chart and mark 1.6.1 as the first stable release.
cc @khushboo-rancher @rebeccazzzz

1.6.1 was just marked as the first stable version of 1.6.
Let's start the post-release actions. @roger-ryao @mantissahz @PhanLe1010 @rebeccazzzz @khushboo-rancher

Post-Release

[ ]  Update master/deploy/upgrade_responder_server/chart-values.yaml @PhanLe1010
[ ]  Add another request for the rancher charts for the next patch release (1.6.2) @rebeccazzzz

Rancher charts: verify the chart can be installed & upgraded - @khushboo-rancher

[ ]  rancher/image-mirrors update @mantissahz @PhanLe1010
[ ]  rancher/charts 2.7 & 2.8 branches for rancher marketplace @mantissahz @PhanLe1010

cc @longhorn/qa @longhorn/dev

Closing, as all tasks have been finished. cc @derekbit


feat: Analyze sap.ui.core.Lib.init() call

JIRA: CPOUI5FOUNDATION-793
Adds checks whether Lib.init() has been called with apiVersion: 2 property.

I benchmarked one of the recent commits from this branch against the latest commit from the main branch that this one is based on:

Commit
Mean [s]
Min [s]
Max [s]

d313912 (main)
31.841 ± 0.415
31.198
32.597

13abc7f
32.714 ± 0.914
31.066
34.025


Synced actors are dispatching a (potentially) unnecessary update

Bug or feature request?
Bug.
Description:
Synced actors are dispatching a (potentially) unnecessary update.
(Bug) Expected result:
When spawning a synced actor the initial xstate.update event should wait till the parent initializes.
(Bug) Actual result:
When spawning a synced actor the initial xstate.update event is being dispatched before the parent initializes.
Link to reproduction or proof-of-concept:
https://codesandbox.io/s/xstate-bug-report-534-jw0i1

While maybe sharing initial state of the synced actor could be done in other way than with dispatching xstate.update the problem itself seems a little bit bigger - any event dispatched to the parent in such a scenario is causing a warning to be printed out. Demo with additional sendParent used - https://codesandbox.io/s/xstate-bug-report-534-1fdx4
The good thing is that the code actually works OK, it's only a warning which tries to be helpful, but in this case is inappropriate.
After quick debugging session though I see that the problem is that interpret call executes actions (should it?), so it starts the child machine which in turn send an event to the parent which is not yet initialized as its start wasn't yet called. Seems to me like interpret should be more lazy about the stuff it does at initialization time, WDYT @davidkpiano ?

Seems to me like interpret should be more lazy about the stuff it does at initialization time

Yes, it should. I'll be making changes around this behavior soon.