[Snyk] Upgrade html-snapshots from 4.1.0 to 4.1.1

Snyk has created this PR to upgrade html-snapshots from 4.1.0 to 4.1.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on a day ago.

Release notes

Package name: html-snapshots

4.1.1 -<EMAIL_ADDRESS><EMAIL_ADDRESS>

4.1.0 -<EMAIL_ADDRESS>

    from html-snapshots GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 99.245%. remained the same
when pulling 3504e3aa1acb58df701162b70f9d9034c7c65379 on snyk-upgrade-c6e5c32f6c8bc1f72484865af6931a52
into 48562034aafdec6c79ec88f095c5f7ea5a2dda19 on master.


do not count all emoji reactions as likes

client initiating action
any app that allows reactions different than like
client receiving or observing action (or lack thereof)
many
timestamp
discussion here: https://github.com/nostrability/nostrability/issues/88
what happens
some nostr apps count all emoji reactions as likes
suggestion
some emoji reactions can be e.g. negatives, and not fall under the like category. consider some solution where not all emoji reactions are considered and counted as likes

Gossip has recently split likes and reaction-count to display something like "18+26" which means 18 likes and 26 emojis.  And if you hover you see the emojis and a count for each.
I don't think it is possible to map emojis into either a like or a dislike.

Created a PR to fix this: https://github.com/nostr-protocol/nips/pull/1486

Created a PR to fix this: nostr-protocol/nips#1486

@vitorpamplona

User reports that primal only counts +/likes and disregards all else
https://njump.me/note1awuqnx9lc0rkdq52vurwajnzd9p5nwcz4ah9ffwp9cgjvkjd9mgs80u826


Unique arc colors

Added possibility to give longer chord_colors list to define each separated arc color.
Now each arc calculates individual color from chord_colors list. If list is shorter then color is selected modulo list length.
ps. Examples also updated with 5-th example with different arc colors test.

Hi @folkien thanks for the PR! Being able to set specific colors for chords is definitely a useful addition.
However, I wonder whether this is the best way to add it, as it feels unlikely that people would set all individual chords' colors, and a flat list is not the most convenient way to specify which chords should be colored as we start from a matrix.
I would propose to request a defaultdict accepting (i, j) and (rowname, colname) as keys (so the default color can be chosen by the user).
In case you haven't used defaultdict before, it would go like:
from collections import defaultdict

ccolors = defaultdict(lambda: "grey", {(0, 1): "blue", (1, 2): "red"})  # default color is grey

print(ccolors[(0, 0)])  # grey
print(ccolors[(0, 1)])  # blue

To be honest, for me using this dict it's overengineering this feature. Default mechanism of cmap and chord_colors are very good in many situations. But for me, i would like to specify arc colors beause i'm using this chart for traffic intersection diagram where every traffic relation has own individual color.
Example

To be honest, for me using this dict it's overengineering this feature. Default mechanism of cmap and chord_colors are very good in many situations. But for me, i would like to specify arc colors beause i'm using this chart for traffic intersection diagram where every traffic relation has own individual color. So i have to specify every arc color anyway.

I understand that you have a specific use case, however, I'm not comfortable with the way the feature is implemented at the moment as I feel it's not generic enough to accommodate other use cases that I feel should be supported if we include a "color specific chords" feature.
Would it really be that cumbersome for you to switch to a dict format? (if all entries are provided, it does not need to be a defaultdict)
Pinging @gph82 to hear his opinion on the PR.

Changes added today.

ideogram_colors argument added
chord_colors can be specified per node or per arc or per everything,


fix(python3): remove async reserved word

In python 3.7 and later, "async" is a reserved word. This change renames a variable with that name to avoid syntax errors when running with these later versions of Python.
Also adds a check re: the presence of the os.fchmod attribute to avoid errors when running on Windows.

FYI: per CONTRIBUTING, I should be authorized to contribute under the Amazon CLA. LMK if you need more info here.
cc @plumpy who I chatted with on slack about this.

Thanks, Allie!


Fix for checking padding for non square images

Thanks @arok for pointing to the issue. Finally it's in master branch.


XDG config location

It would be good if the configuration file could be located somewhere else. In particular, it would be nice to have it located where the XDG specification states (https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html), so you can have all your files under $XDG_CONFIG_HOME.
It should not be a difficult change and will allow us to have a cleaner home and an easier configuration backup.
The ability of setting the config file via environment variable (like OC_CONFIG=~/.opencommit), or using an environment variable to configure the software (like OPENAI_API_KEY=MyKey) would also be welcomed.

+1

Having the ability to pass the OpenAI API key via an ENV var, and not storing it in plaintext on disk, would boost my confidence in using OC.

Really? :-(

Having the ability to pass the OpenAI API key via an ENV var, and not storing it in plaintext on disk, would boost my confidence in using OC.
*Edit: the ENV var feature allegedly exists per #80, although it's not well documented.

Sorry to re-open, but can you tell me how the changes in $80 can be used such that the key can be stored in an environment variable instead of a file?

+1
I'd also love to see the config file being read from $XDG_CONFIG_HOME.
I would suggest the implementation as follows:

If present, the $XDG_CONFIG_HOME/.opencommit file is considered
If not, it falls back to the currently hardcoded path ~/.opencommit
exported environment variables always overrule 1. and 2.


generating bitcoin private key from 512 bit seed

Hi
I want to generate bitcoin private key from a 512 bit seed.
can I do this with your library and how ?
please give me example

Sorry, this library currently doesn't have that kind of wallet-specific functionality, it is focused only on cryptography using the secp256k1 elliptic curve (ECDSA, ECDH and ECIES). I would recommend looking into something like bitcoinjs-lib, which has more wallet functionality.


add internal error type

Pls do not change the files in evm, this files will be deleted very soon.
After my PR (https://github.com/cryptape/cita/pull/689) Merged, you will get the ExecutionError struct.
pub enum ExecutionError {
    VM(VMError),
    State(StateError),
    NotFound,
    Types(TypesError),
    Internal(String),
    TransactionMalformed(String),
    Authentication(AuthenticationError),
}

Pls do not change the files in evm, this files will be deleted very soon.
After my PR (cryptape/cita#689) Merged, you will get the ExecutionError struct.
pub enum ExecutionError {
    VM(VMError),
    State(StateError),
    NotFound,
    Types(TypesError),
    Internal(String),
    TransactionMalformed(String),
    Authentication(AuthenticationError),
}

We need a customized erro

We need a customized error type in cita-vm evm not evm in cita. It's means adding another type
in ExecutionError::VM::VMError

Sorry, I make some mistake, forgot my comments.


not covered sprintf distributed in several lines

Please take a look here: https://coveralls.io/builds/11510034/source?filename=src%2FRepositoryTrait.php#L121
It is happening more than once, when a sprintf is splitted into several lines the one in the middle is considered not covered which is impossible

php-coveralls is an app that pass your coverage report to CoverAlls service.
Following issue could have one of following 2 reasons:

code coverage report is not including this line, then report issue to code coverage tool you are using
code coverage report is including this line, yet CoverAlls is not displaying it as covered, then report issue to CoverAlls service.


Cannot use grpcio on manylinux2014_aarch64 (undefined symbol)

What version of gRPC and what language are you using?
Lang: Python 3.10
Version: 1.56.0
What operating system (Linux, Windows,...) and version?
quay.io/pypa/manylinux2014_aarch64
What runtime / compiler are you using (e.g. python version or version of gcc)
[root@b59a58c303a9 /]# /opt/python/cp310-cp310/bin/python3 --version
Python 3.10.12
[root@b59a58c303a9 /]# gcc --version
gcc (GCC) 10.2.1 20210130 (Red Hat 10.2.1-11)

What did you do?
From a T2A instance:
MANYLINUX_AARCH64_IMAGE=quay.io/pypa/manylinux2014_aarch64@sha256:9d9cb1d47af9989b7b408e0a27700556cdb85b6243a67506d0f984c0fb24140f
sudo docker run -it "${MANYLINUX_AARCH64_IMAGE}" bash
[root@b59a58c303a9 /]# /opt/python/cp310-cp310/bin/python3 -m pip install grpcio==1.56.0
Collecting grpcio==1.56.0
  Obtaining dependency information for grpcio==1.56.0 from https://files.pythonhosted.org/packages/26/cb/a2debcb7fe7a6f90f27d589facb85aa69e8ce39660e8faff2775911f58ee/grpcio-1.56.0-cp310-cp310-manylinux_2_17_aarch64.whl.metadata
  Downloading grpcio-1.56.0-cp310-cp310-manylinux_2_17_aarch64.whl.metadata (4.0 kB)
Downloading grpcio-1.56.0-cp310-cp310-manylinux_2_17_aarch64.whl (4.7 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.7/4.7 MB 45.5 MB/s eta 0:00:00
Installing collected packages: grpcio
Successfully installed grpcio-1.56.0
root@b59a58c303a9 /]# /opt/python/cp310-cp310/bin/python3 -c "import grpc"

What did you expect to see?
No errors given that the binary wheel is tagged with manylinux_2_17_aarch64.
This seems related to #30218.
What did you see instead?
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/python/cp310-cp310/lib/python3.10/site-packages/grpc/__init__.py", line 22, in <module>
    from grpc import _compression
  File "/opt/python/cp310-cp310/lib/python3.10/site-packages/grpc/_compression.py", line 20, in <module>
    from grpc._cython import cygrpc
ImportError: /opt/python/cp310-cp310/lib/python3.10/site-packages/grpc/_cython/cygrpc.cpython-310-aarch64-linux-gnu.so: undefined symbol: _ZTVNSt7__cxx1119basic_ostringstreamIcSt11char_traitsIcESaIcEEE

Anything else we should know about your project / environment?
[root@b59a58c303a9 /]# ldd  /opt/python/cp310-cp310/lib/python3.10/site-packages/grpc/_cython/cygrpc.cpython-310-aarch64-linux-gnu.so
        linux-vdso.so.1 =>  (0x0000ffffb38af000)
        librt.so.1 => /lib64/librt.so.1 (0x0000ffffb2e66000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x0000ffffb2e31000)
        libstdc++.so.6 => /lib64/libstdc++.so.6 (0x0000ffffb2d0a000)
        libm.so.6 => /lib64/libm.so.6 (0x0000ffffb2c59000)
        libc.so.6 => /lib64/libc.so.6 (0x0000ffffb2ad3000)
        /lib/ld-linux-aarch64.so.1 (0x0000ffffb3881000)
        libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x0000ffffb2aa2000)
[root@b59a58c303a9 /]# strings /lib64/libstdc++.so.6 | grep GLIBC
GLIBCXX_3.4
GLIBCXX_3.4.1
GLIBCXX_3.4.2
GLIBCXX_3.4.3
GLIBCXX_3.4.4
GLIBCXX_3.4.5
GLIBCXX_3.4.6
GLIBCXX_3.4.7
GLIBCXX_3.4.8
GLIBCXX_3.4.9
GLIBCXX_3.4.10
GLIBCXX_3.4.11
GLIBCXX_3.4.12
GLIBCXX_3.4.13
GLIBCXX_3.4.14
GLIBCXX_3.4.15
GLIBCXX_3.4.16
GLIBCXX_3.4.17
GLIBCXX_3.4.18
GLIBCXX_3.4.19
GLIBC_2.17
GLIBCXX_DEBUG_MESSAGE_LENGTH

There are two times the manylinux version becomes relevant here - at build time, and at runtime. You cannot directly change how the wheels are built (though it's probably worth considering moving to manylinux_2_28 in any case), but an you try what happens when you use a newer manylinux image to run, e.g. quay.io/pypa/manylinux_2_28_aarch64?

@jtattermusch Can you take a look since you were the original author of the Python aarch64 build?

I got an identical error on Python 3.9. Tried multiple grpcio versions starting from 1.46.3 to the latest version, all of them fail on a native centOS 7 aarch64.
Any pointers or plans to reopen this issue, please?


invert if condition revision check for readability

This is a cosmetic change. Inverting the only instance of {{- if eq .Values.revision "" }} to match with the other instances of {{- if ne .Values.revision "" }}. Shaves off unnecessary cognitive burden when I revisit charts and inspect .Values.revision decision flows
[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@howardjohn any chance you could review this?

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
b1acd76d91b3016fedf94992ee75f0052665b0af
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tariq1890: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
b1acd76d91b3016fedf94992ee75f0052665b0af
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
b1acd76d91b3016fedf94992ee75f0052665b0af
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
b1acd76d91b3016fedf94992ee75f0052665b0af
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio


Add catchJust

This comes from Haskell's Control.Exception.Base originally, but it's possible to generalise it to and MonadError instance, which is what I've done here.

Looks good!


Return a vector of initialized table derive structs after query

Instead of getting back:
Result<Vec<HashMap<String, Value>>>

Getting something similar to:
Result<Vec<Table>>

Fixed.


Consider a CSRF replacement for $.ajax

See:
https://github.com/shakacode/react-webpack-rails-tutorial/pull/73#issuecomment-137977029
We could provide a something helpful in this gem that facilitates true promises via 'fetch'.

My two cents. I use this:
import _ from 'underscore'

/* globals document */

export default class BaseData {
  constructor() {
    this.defaultParams = {
      credentials: 'same-origin'
    }
  }

  getCSRFToken() {
    return _.find(document.getElementsByTagName("meta"), (meta) => {
      return meta.name === "csrf-token"
    }).content
  }

  defaultHeaders = () => {
    return {
      'X-CSRF-Token': this.getCSRFToken(),
      'Accept': 'application/vnd.api+json',
      'Content-Type': 'application/vnd.api+json'
    }
  }

  post = (url, props) => {
    return fetch(url, {
      method: 'post',
      headers: this.defaultHeaders(),
      body: JSON.stringify(props),
      ...this.defaultParams
    })
    .then((response) => {
      return response.json()
    })
  }

  put = (url, props) => {
    return fetch(url, {
      method: 'put',
      headers: this.defaultHeaders(),
      body: JSON.stringify(props),
      ...this.defaultParams
    })
    .then((response) => {
      return response.json()
    })
  }

  delete = (url) => {
    return fetch(url, {
      method: 'delete',
      headers: this.defaultHeaders(),
      ...this.defaultParams
    })
    .then((response) => {
      return response.json()
    })
  }
}

And this module: "whatwg-fetch": "^0.9.0"

We're using axios here:
https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/package.json
@alexfedoseev Are we missing the headers for:
     'Accept': 'application/vnd.api+json',
      'Content-Type': 'application/vnd.api+json'

Here's our source: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client%2Fapp%2Futils%2FcommentsManager.js
import request from 'axios';

const API_URL = 'comments.json';

const CommentsManager = {

  /**
   * Retrieve comments from server using AJAX call.
   *
   * @returns {Promise} - result of ajax call.
   */
  fetchComments() {
    return request({
      method: 'GET',
      url: API_URL,
      responseType: 'json',
    });
  },

  /**
   * Submit new comment to server using AJAX call.
   *
   * @param {Object} comment - Comment body to post.
   * @returns {Promise} - result of ajax call.
   */
  submitComment(comment) {
    return request({
      method: 'POST',
      url: API_URL,
      responseType: 'json',
      headers: {
        'X-CSRF-Token': this.getCSRFToken(),
      },
      data: { comment },
    });
  },

  /**
   * Get CSRF Token from the DOM.
   *
   * @returns {String} - CSRF Token.
   */
  getCSRFToken() {
    const metas = document.getElementsByTagName('meta');
    for (let i = 0; i < metas.length; i++) {
      const meta = metas[i];
      if (meta.getAttribute('name') === 'csrf-token') {
        return meta.getAttribute('content');
      }
    }

    return null;
  },

};

export default CommentsManager;

Are we missing the headers for

No, since we don't use Vendor MIME Type to match the api version (we use URL instead).
More on subject: https://medium.com/@alexfedoseev/isomorphic-react-with-rails-part-ii-614980b65aef
And example of apiCall helper with axios:
import http from 'axios';
import getCSRFToken from './getCSRFToken';

const apiURLPrefix = '/api/v1';

// Transforming Immutable data to plain JS
http.defaults.transformRequest.unshift(data => (
  data && data.toJS === 'function' ? data.toJS() : data
));

http.interceptors.request.use(config => {
  // If it's not remote call, adding api prefix
  if (!config.remote) {
    config.url = `${apiURLPrefix}${config.url}`;
  }

  // Adding CSRF Token header
  config.headers = {
    'X-CSRF-Token': getCSRFToken(),
  };
  return config;
});

export default params => http(params);

:+1: I'm using that because I'm using a jsonapi-resources backend, which requires that MIME type

@alexfedoseev @josiasds @mapreal19 How about we release a tiny npm module to encapsulation axios and the ability to get the CRSF token from Rails? Then we can put the inclusion of the tiny npm module in the template setup.

I'd rather made getCRSFToken module and left axios in user land.
Reasons:

axios is opinionated.
axios's setup is opinionated.

This is probably the one we want to to support:
https://github.com/matthew-andrews/isomorphic-fetch

@jbhatab @alexfedoseev Once we put in the NPM library, I'll try to merge in the code from the: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/libs/metaTagsManager.js

@justin808 @alexfedoseev @jbhatab I'm using isomorphic fetch on a project along with this function:
function getCSRFToken() {
  return _.find(document.getElementsByTagName('meta'), (meta) => {
    return meta.name === 'csrf-token';
  }).content;
}

Regardless though, I vote we do not put this in the npm module for the same reason that Alex chose not to use Axios's implementation. Some people may not even be doing sessions this way.

Just to leave another implementation here for the sake of brainstorm. We only use helper methods that don't wrap fetch, but aid in parameter setting. Implementation in this gist.
For regular non-safe json requests:
fetch('/foobar.json', jsonHeader(/*fetch options*/));

With just the Rails CSRF headers:
fetch('/foobar.json', authenticityHeader(/*fetch options*/));

For safe calls (includes CSRF and credentials & same-origin header):
fetch('/foobar.json', safeCredentials(/*fetch options*/));

We'll soon be adding a JS helper method for the CRSF to the ReactOnRails npm module for this.
We probably want to be agnostic about the choice of fetch vs. axios.

agreed

We simply need to add this helper method to ReactOnRails.
From: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/libs/metaTagsManager.js
import _ from 'lodash';

export default {

  /**
   * Get CSRF Token from the DOM.
   *
   * @returns {String} - CSRF Token.
   */
  getCSRFToken() {
    const token = _.find(document.querySelectorAll('meta'), ['name', 'csrf-token']);
    return token ? token.content : null;
  },

};

To:

https://github.com/shakacode/react_on_rails/blob/master/node_package%2Fsrc%2FReactOnRails.js
A new file here: https://github.com/shakacode/react_on_rails/tree/master/node_package/src

We should also remove the dependency on lodash.

I'll probably add @fletcher91's code to the default package for ReactOnRails. Yes, we could have a separate node module. It's a tiny enough amount of code that I don't deem that necessary.
@fletcher91 Any changes to your gist? I copied below.
/**
 *
 * A regular non-safe get request:
 * fetch('/profiles/foobar.json', jsonHeader());
 *
 * How this would look in a safe fetch request:
 * fetch('/profiles.json', safeCredentials({
 *              method: 'POST',
 *              body: JSON.stringify({
 *                  q: input,
 *                  thing: this.props.thing
 *              })
 *          }));
 *
 *
 */

/**
 * For use with window.fetch
 */
export function jsonHeader (options) {
    options = options || {};
    return Object.assign(options, {
        'Accept': 'application/json',
        'Content-Type': 'application/json'
    });
}

/**
 * Lets fetch include credentials in the request. This includes cookies and other possibly sensitive data.
 * Note: Never use for requests across (untrusted) domains.
 */
export function safeCredentials (options) {
    options = options || {};
    return Object.assign(options, {
        credentials: 'include',
        mode: 'same-origin',
        headers: Object.assign((options['headers'] || {}), authenticityHeader(), jsonHeader())
    });
}

// Additional helper methods

export function authenticityHeader (options) {
    options = options || {};
    return Object.assign(options, {
        'X-CSRF-Token': getAuthenticityToken(),
        'X-Requested-With': 'XMLHttpRequest'
    });
}

export function getAuthenticityToken () {
    return getMetaContent('csrf-token');
}

export function getMetaContent (name) {
    let header = document.querySelector(`meta[name="${name}"]`);
    return header && header.content;
}

@justin808 Aside from some minor things like let to const and some JSdocs, it's still the same 👍  I've updated the gist accordingly

@fletcher91, @jbhatab does this make sense to go into React on Rails from the perspective that the CRSF thing is so standard for Rails apps? or more of a doc thing?

I'd be happy to have this as part of react_on_rails. It's really a very common requirement.

@anpr With the direction were going, I think this shouldn't be covered with our gem and can be covered in a docs if even needed at all. it depends on your architecture style.
We can relook into this when we redo the docs stuff.

@jbhatab, we're going to provide a default for this. I really think this is so common that it makes sense to include in our library, if it's non-obtrusive.
@anpr I can help you with this. Please email me at<EMAIL_ADDRESS>and I can add you to our Slack room.

We're working on restructuring our front-end (splitting into packages), so I can publish these helpers publicly to NPM if that helps

I basically copied the code above to my project and it solved the problem.
Still, I see this being a common requirement, so either as part of the gem or a separate npm package (I don't really care which of the two) would be beneficial.

@anpr I think part of the standard npm package for react-on-rails is fine if it's very small.

@dzirtusss Please take a look at this one.

We're using:

https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/libs/requestsManager.js#L33
https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/libs/metaTagsManager.js

and we don't have many of the headers in
https://gist.github.com/fletcher91/c62b865c6aa9f710531e
Can we abstract this into ReactOnRails?
CC: @alexfedoseev @robwise

@fletcher91 @anpr @alexfedoseev @dphaener @samnang @dzirtusss: we'd like to know if the headers here: https://gist.github.com/fletcher91/c62b865c6aa9f710531e
should be here: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/libs/requestsManager.js#L33

Actually I think we should not need to include jsonHelper into gem and specifically include json Accept and inContent-Type into headers because it is already included by ??? as follows:
Content-Type: application/json;charset=UTF-8
Accept: application/json, text/plain, */*
Cookie: _rails-react-tutorial_session=...

And everything works fine.
Maybe it will not work with fetch same way but will need to update first from axios to isomorphic-fetch in tutorial.

I think it will be ok if we use fetch like:
credentials: 'same-origin',
header: RubyOnRails.authenticityHeader(),

Resolved by #517


tests/instancetype/upgrade: Replace Update w Patch

What this PR does
It is common practice on our e2e tests to use Update k8s API in order to run the test. In order to ensure the change was executed, these also are wrapped with Eventually/RetryOnConflict.
The issue is that most often tests do not really need to use Update (for an atomic change) and Patch would be quicker and more precises.
Replacing Update in the following functions:

updateInstancetypeMatcher
updatePreferenceMatcher

Fixes # https://issues.redhat.com/browse/CNV-44574
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

Also from code-lint: :tada:
tests/instancetype/upgrade.go:1:1: directive `//nolint:dupl,lll` is unused for linter "dupl" (nolintlint)
//nolint:dupl,lll

/hold

Change: Rebase

Change: Fix @fossedihelm 's review

Also from code-lint: 🎉
tests/instancetype/upgrade.go:1:1: directive `//nolint:dupl,lll` is unused for linter "dupl" (nolintlint)
//nolint:dupl,lll

Fixed in a separate commit

@lyarwood can we remove the hold?

/retest

/hold cancel
/lgtm

/sig code-quality


Create Simple Consent Module for Congo Field Experiments

Create module that can be used to collect consent data for Congo Field Experiments.
Module should be able to allow experimenter to give unique string ID along with attached media (TBD). This may be either uploaded audio (declaring consent), fingerprint image file, or just click screen to say yes. (Will update when know after Nov 16th)

NB, we discussed the option to collect consent on paper, rather than in the app. In the interest of time, any of the options that don't involve clicking (i.e., the now implemneted solution) should be done offline IMO.

Closing issue here, as this will be taken care of not on AML framework


List of Int doesn't work in Function Calling

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
The following Code doesn't register the cited_answer citations object:
import os
from operator import itemgetter
from typing import List, Optional
from uuid import UUID

from langchain.chains import ConversationalRetrievalChain
from langchain.embeddings.ollama import OllamaEmbeddings
from langchain.llms.base import BaseLLM
from langchain.prompts import HumanMessagePromptTemplate, SystemMessagePromptTemplate
from langchain.retrievers import ContextualCompressionRetriever
from langchain.retrievers.document_compressors import FlashrankRerank
from langchain.schema import format_document
from langchain_cohere import CohereRerank
from langchain_community.chat_models import ChatLiteLLM
from langchain_core.output_parsers import StrOutputParser
from langchain_core.prompts import ChatPromptTemplate, PromptTemplate
from langchain_core.pydantic_v1 import Field as FieldV1
from langchain_core.runnables import RunnableLambda, RunnablePassthrough
from langchain_openai import ChatOpenAI, OpenAIEmbeddings
from logger import get_logger
from models import BrainSettings  # Importing settings related to the 'brain'
from modules.brain.service.brain_service import BrainService
from modules.chat.service.chat_service import ChatService
from modules.prompt.service.get_prompt_to_use import get_prompt_to_use
from pydantic import BaseModel, ConfigDict
from pydantic_settings import BaseSettings
from supabase.client import Client, create_client
from vectorstore.supabase import CustomSupabaseVectorStore

logger = get_logger(__name__)

class cited_answer(BaseModel):
    """Answer the user question based only on the given sources, and cite the sources used."""

    answer: str = FieldV1(
        ...,
        description="The answer to the user question, which is based only on the given sources.",
    )
    citations: List[int] = FieldV1(
        ...,
        description="The integer IDs of the SPECIFIC sources which justify the answer.",
    )

Error Message and Stack Trace (if applicable)
Here is the langsmith:

And if I don't put List but just Int it works

Description
I'm trying to attach a function calling for citation, but List[int] doesn't work.
I tried with Pydantic V1 and V2. None seems to work
System Info
langchain==0.1.16
langchain-community==0.0.34
langchain-core==0.1.45
langchain-openai==0.1.3
langchain-text-splitters==0.0.1
Documentation Link
I'm based on this documentation https://python.langchain.com/docs/use_cases/question_answering/citations/#cite-documents

Ok nevermind.
You need to use BaseModel from pydantic V1 also:
from langchain_core.pydantic_v1 import BaseModel as BaseModelV1
from langchain_core.pydantic_v1 import Field as FieldV1
This fixed it.


Fixed some issues and enhancement.

Summary

Added the logic of creating a post when a subscription is created or edited.
Modified an error when a user deletes a deleted subscription.
Made an event stand out .

Ticket Link
#116
#114

@mickmister @hanzei fixed the issue. Please review

@mickmister Gentle reminder to review this PR.

Codecov Report
Attention: Patch coverage is 76.31579% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 65.32%. Comparing base (1746ccd) to head (74d31f8).

Files
Patch %
Lines

server/plugin/api.go
72.72%
4 Missing and 2 partials :warning:

server/plugin/command.go
50.00%
1 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   65.40%   65.32%   -0.09%
==========================================
  Files          17       17
  Lines        2064     2085      +21
==========================================
+ Hits         1350     1362      +12
- Misses        674      679       +5
- Partials       40       44       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: add gwas_catalog_preprocess dag

This PR includes:

bugfix in submit_step where the ID for the job was derived from the step, and not the task_id that we define. I had clashes when adding several calls to the clump step
changes to the gwas_catalog.py step to stop the journey when the associations table is converted into a StudyLocus; and when the studies table is parsed into a split StudyIndex
addition of a new DAG that processes all GWASCatalog data. The new DAG is meant to be run as part of the preprocessing and consists of 2 groups of tasks:

Processing summary statistics

Conversion of harmonised summary stats to a StudyLocus after window based clumping
LD clumping of the SS StudyLocus
Fine mapping with PICS of clumped study locus

Processing of GWAS Catalog curation

Creation of a StudyLocus from curation and a StudyIndex
LD clumping of the curated StudyLocus
Fine mapping with PICS of clumped study locus

In the future, I'd like to see these 2 streams of data consolidated right before running LD clumping. That way, we could operate with a single dataset in all downstream processes.

Codecov Report

Merging #291 (93cfe02) into main (a6cc21d) will increase coverage by 0.23%.
The diff coverage is 95.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   86.41%   86.64%   +0.23%
==========================================
  Files          86       87       +1
  Lines        1987     1999      +12
==========================================
+ Hits         1717     1732      +15
+ Misses        270      267       -3

Files
Coverage Δ

src/airflow/dags/common_airflow.py
100.00% <ø> (ø)

src/airflow/dags/gwas_catalog_preprocess.py
100.00% <100.00%> (ø)

src/otg/gwas_catalog_ingestion.py
70.37% <66.66%> (ø)


Upload a profile picture

[x] User can set a profile picture

[x] the ability to upload picture from their desktop....
[x] If the user chose not to upload, he/she can choose icon (character, female, male...)

Test Case:

[x] Users should be able to upload profile image successfully

[ ]  If users chose not to upload, they can choose an icon (character, female, male...)
MInor change:
If the user chose not to upload a picture, the default image will be their profile picture, which is a gender-neutral profile icon.


Command parsing doesn't match aws-profile

$ aws-profile -p sandbox -- foo --bar baz
$ aws-profile -p sandbox foo --bar baz
These should both behave the same, but the 2nd command fails.

Resolved in 735d5ea


--massive-scan or --massive parameter

is it --massive-scan argument or only --massive?

It's --massive only, thank you for notifying. Fixed!


Draft: POC

Replace print statements with logging
Resolves #565
Summary
This pull request addresses the transition from using print()statements to the Python logging module. The update improves flexibility for managing output messages.
Changes made:

Replaces all occurences of print with appropriate logging levels (debug, info, warning, error)
Removed the verbose flag in favor of log levels
Replaced all f-strings with % formatting in logging statements to comply with pylint requirements

Documentation
Updated the documentation to include instructions on how users can configure logging verbosity.

NB: Do not merge this branch; it serves as a base for a POC branch.

Copy of MR https://github.com/GlacioHack/xdem/pull/610


React doesn't reload on globals change

Hi, love this package! It's something I've always wanted for unity. I noticed in my unity project that react doesn't seem to rerender when Globals change. Is this a known issue, or am I doing something wrong? If you'd like, I can bring some further details/images to clarify

Globals are not supposed to change. They are meant to be global constants. They are passed from C# to the React side only at the initialization and never again. What you can do is, you can assign a MonoBehavior to a global, then handle the changes inside that MonoBehavior. You can have an internal dictionary that holds the variables, and add events that handle changes to variables to trigger a render in React side.
Also, ReactUnity does not rerender React components itself. That is handled by React. If you want to rerender a component, you need to do it in React way. You can try one of these methods.

Alright, how would I go about making an event to trigger the react render? I currently have a monobehaviour (assigned as a global), but variables that change within that monobehaviour aren't reflected on the react side of things.
Thanks for the help in advance!

I've had early luck working with UnityEvents to accomplish this. Hope this helps.

Thanks @caldarellial , good example.
This seems like a common use case so I will check if it is possible to do the change detection with React Contexts.

OH! I didn't know you could add event listeners across the language! That's incredible, thank you so much. This project is great

This is now possible with latest version of @reactunity/core and @reactunity/renderer.
reactunity/renderer now has two useful exports: GlobalsProvider component and useGlobals hook. Example usage:
function App() {
  // This will be rerendered when Globals change in the C# side
  const globals = useGlobals();

  // Component logic here ...
}

Renderer.render(
  <GlobalsProvider>
    <App />
  </GlobalsProvider>
);


add instructions to enable ssh git ops

adding some instructions to edit gitea's app.ini file, in order to enable ssh git operations

@seven62 you included your internal IP addresses, can you replace those?

@peasead updated


Use single-quotes around string literals

This commit replaces double-quoted string literals with single-quoted ones in a few test cases. Double-quotes around string literals are invalid in standard-conforming SQL and accepting them by default is now considered a misfeature by the authors of SQLite. The test cases in question will also fail when SQLite is compiled with -DSQLITE_DQS=0.

Codecov Report

Merging #934 (582723e) into master (ab91e93) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   46.80%   46.60%   -0.21%
==========================================
  Files          11       11
  Lines        1457     1457
==========================================
- Hits          682      679       -3
- Misses        640      642       +2
- Partials      135      136       +1

Impacted Files
Coverage Δ

sqlite3.go
52.73% <0.00%> (-0.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab91e93...582723e. Read the comment docs.


Firefox: Hitting save when a tunnel is assigned to an interface will result in a validation error.

When a WireGuard Tunnel is assigned to an interface, it cannot be disabled.
This currently results in the checkbox being disabled on the frontend.
However, under Firefox, <input type="checkbox" disabled> do not send their value on FORM POST (this is the actual proper behavior according to the HTML specification).
This leads to a validation error when the form gets validated on save.
To fix, three possible solutions:

Remove the checkbox entirely, replacing it with a <input type="hidden" value="yes" name="enabled" />; while keeping the help text stating that the tunnel cannot be disabled.
Remove the validation for that specific field and just completely ignore the value when the tunnel is assigned to an interface.
Force that value to be yes before validation when the form gets posted, ignoring what's included in the POST request.

What version are you running? I caught this and added a hidden field
https://github.com/theonemcdonald/pfSense-pkg-WireGuard/blob/main/src/files/usr/local/www/wg/vpn_wg_edit.php#L180

@FineWolf Try the latest pre-compiled build v0.0.5_1. This issue should be resolved.

pfSense-pkg-WireGuard-0.0.5    pfSense package WireGuard
wireguard-kmod-0.0.20210412    WireGuard implementation for the FreeBSD kernel
wireguard-tools-1.0.20210315_4 Fast, modern and secure VPN Tunnel

On pfSense+ 21.02.2-RELEASE.
Will update and report back.

Resolved in 0.0.5_1. Thanks!


fix: removed u icon from user chat message

This is the fix for #407
I have removed the character U which used to appear besides user's chat message on the screen
I have done the changes for both playground and demo

thanks for the PR! i would love to use an icon instead of text "AG". the Bot icon from lucide-react looks good and we already had this package imported. should be a quick enhancement :)

@plutoless I have added the bot icon. This PR is up to date with the required changes and can be reviewed.

LGTM. thank you!


HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
branch-2 passed

+1 :green_heart:
compile
3m  9s
branch-2 passed

+1 :green_heart:
checkstyle
0m 42s
branch-2 passed

+1 :green_heart:
spotless
0m 56s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 40s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
3m 14s
the patch passed

+1 :green_heart:
javac
3m 14s
the patch passed

+1 :green_heart:
checkstyle
0m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
4m  5s
The patch causes 10 errors with Hadoop v2.10.2.

+1 :green_heart:
spotless
0m 50s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

33m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5894

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux dc171d44b138 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 860ac60733

Default Java
Eclipse Adoptium-11.0.17+8

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
branch-2 passed

+1 :green_heart:
compile
0m 43s
branch-2 passed

+1 :green_heart:
shadedjars
4m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 17s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
shadedjars
4m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
218m 52s
hbase-server in the patch passed.

240m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5894

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d72c0c52bf25 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 860ac60733

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/testReport/

Max. process+thread count
4343 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 58s
branch-2 passed

+1 :green_heart:
compile
0m 49s
branch-2 passed

+1 :green_heart:
shadedjars
5m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
216m 13s
hbase-server in the patch passed.

240m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5894

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6ab49e85edd1 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 860ac60733

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/testReport/

Max. process+thread count
4886 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5894/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[do-not-merge] draft: use sdk on relayer

Codecov Report

Merging #42 (3437b7a) into develop (ec4932b) will decrease coverage by 1.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    48.57%   47.56%   -1.01%
===========================================
  Files           95       93       -2
  Lines         3788     3681     -107
  Branches       728      715      -13
===========================================
- Hits          1840     1751      -89
+ Misses        1948     1930      -18

Flag
Coverage Δ

boba-contracts
20.15% <ø> (ø)

contracts
81.62% <ø> (ø)

core-utils
86.77% <ø> (ø)

data-transport-layer
29.25% <ø> (ø)

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/message-relayer/hardhat.config.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4932b...3437b7a. Read the comment docs.


Doesn't seem to be working at all

Maybe anyone can advice what I'm doing wrong?
public % vue-i18n-extract report -v "./**/.?(js|vue)" -l "./locales/.?(js|json)" | tee ./tmp/i18n-report.json
(node:43596) UnhandledPromiseRejectionWarning: Error: EISDIR: illegal operation on a directory, read
at Object.readSync (fs.js:506:3)
at tryReadSync (fs.js:331:20)
at Object.readFileSync (fs.js:368:19)
at /Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:66:19
at Array.map ()
at readVueFiles (/Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:61:22)
at VueI18NExtract.parseVueFiles (/Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:166:23)
at VueI18NExtract.createI18NReport (/Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:176:33)
at report (/Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:288:26)
at run (/Users/Paul/.config/yarn/global/node_modules/vue-i18n-extract/dist-node/index.js:275:7)
(node:43596) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:43596) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It looks like either the path is wrong or you don't have the right permission. Could it be?

It looks like either the path is wrong or you don't have the right permission. Could it be?

huh seems problem was here ".//.?(js|vue)" it somehow doesn't take all of the folders
and this way seems to be working fine "./pages//.?(js|vue)"

Interesting, usually the glob pattern needs a star before the .? so for example /**/*.?(js|vue). Closing this for now, let me know if you still have an issue!

I had a vendor folder with tons of files and folders, which might have had a folder that matched the glob. This was causing this error. Hope that helps someone who might be receiving this error.


Basic CLI

This package was intended to be a library and we don't always have time to maintain other artifacts. Would it be useful to maintain this CLI outside of this repo and give a link from the README? What do you think?

Hi. fair enough. I figured that might be the case. I'll keep the CLI separate, release it, and will open another issue with the link if you're interested in putting it in the README. thanks :)


Template 2018 june

Log is stored in config['pipeline_logs_root'] now.
Set log level and file name at controller.py. For debug level, output dataframe of every primitives will be in config['pipeline_logs_root']/dfs

Looks good to me


Student names change problem

After changing name in settings, it is not updated everywhere.

Username is now updated on change. #7


Glue Ball does not stick things together with Quark installed

Minecraft version
1.18.1
LibX version
LibX-1.18.1-3.1.8
UtilitiX version
UtilitiX-1.18.1-0.3.8
Forge version
39.0.56
The latest.log file
https://gist.github.com/Mattabase/c121bbac7362f40eed3c9bc416673ab7
Issue description
The "Glue Ball" does not function correctly with Quark installed, it can be placed but the blocks do not stick together
Steps to reproduce
Use the glue ball as you would without Quark installed, the blocks do not stick
Other information
This is my own testing modpack, I have not tested with just Quark and this mod, however removing just Quark does fix the issue and Quark does change piston logic

I tested a bit and tried to fix this. Now, I added a warning when the config in quark is enabled to replace the piston logic. If it's disabled, the glue works fine.
If I have enough time, I try fixing that completely, but for now you need to just disable this config option.


Add setup.py to allow using libbuild without antipackage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use default_error_messages and self.fail

Let's take a look at TokenObtainSerializer:
class TokenObtainSerializer(serializers.Serializer):
    username_field = User.USERNAME_FIELD

    def __init__(self, *args, **kwargs):
        super(TokenObtainSerializer, self).__init__(*args, **kwargs)

        self.fields[self.username_field] = serializers.CharField()
        self.fields['password'] = PasswordField()

    def validate(self, attrs):
        self.user = authenticate(**{
            self.username_field: attrs[self.username_field],
            'password': attrs['password'],
        })

        if self.user is None or not self.user.is_active:
            raise serializers.ValidationError(
                _('No active account found with the given credentials'),
            )

        return {}

And let's change this and other serializers to look more like that:
class TokenObtainSerializer(serializers.Serializer):
    default_error_messages = {
        'incorrent_credentials': _('No active account found with the given credentials')
    }

    username_field = User.USERNAME_FIELD

    def __init__(self, *args, **kwargs):
        super(TokenObtainSerializer, self).__init__(*args, **kwargs)

        self.fields[self.username_field] = serializers.CharField()
        self.fields['password'] = PasswordField()

    def validate(self, attrs):
        self.user = authenticate(**{
            self.username_field: attrs[self.username_field],
            'password': attrs['password'],
        })

        if self.user is None or not self.user.is_active:
            self.fail('incorrect_credentials')

        return {}

This way, when I inherit over TokenObtainSerializer and override validate method, I don't have to copy and paste the error message, I can just use self.fail with proper argument. What do you think?

Yeah, looks good to me.  Feel like making a PR with those changes?

Ok :)


Android getSharedPreferences file name and mode

I saw that it's not possible to get the sharedPreference with a specified file name. The only way is to use the DefaultSharedPreferences.
It's a possibility for you to add this function? :
Context.getSharedPreferences (String name, int mode)
Thanks in advance

So I came here for this exact same reason! And it appears this issue is the Android version of issue #3 ... so there seems to be interest in adding the ability to specify what I'll call a "file name".
But ... as I thought more about this, the more unsure I want to see this implemented. Here's my thought process:
Assuming we want to keep a common abstraction across all the platforms, then a single "file name" would be a parameter on all...

On Droid the "file name" parameter would be used to specify which physical file the preference resides in.
On iOS it would identify the "suite name" (assuming initWithSuiteName is used) it lives in - and that's meant for preferences shared across apps & extensions or app groups.
Since this library is meant to be used in shared code - it doesn't seem right to me that this single "file name" parameter would be used for such different purposes on each platform, it could get confusing.

(Unfortunately I don't know the Windows platforms enough to speak on those, but the point still stands for Droid & iOS.)
Anyway, those are my (unsolicited) thoughts ... 😄 ... I'd be interested in what you think...

So, it seems like each of the methods needs an additional name associated with it optionally:
T GetValueOrDefault<T>(string key, T defaultValue = default(T), string fileName);

I am not sure if "fileName" is really want I want to call it, but makes some sense.
For Android Mode there is no need for it as all others besides the default have been deprecated by now.

That's what I would think the method signature would look like as well. And I agree with "fileName" not being a great name - but I couldn't think of anything else last night (and nothing better right now either).
But it still kind of bugs me the way iOS would use that parameter isn't analogous to the way Droid would use it. I'm coming from the idea if something is used in shared code, the idea of what it does on each of the platforms is the same - although the implementation is different.
I might be overthinking this whole thing ... it would be useful...

@codemillmatt Can I get a code review on: https://github.com/jamesmontemagno/SettingsPlugin/tree/feature-filename
Windows I still need to test a bit, but it makes sense to me..

iOS and Android look good to me. Couple of nit-picky things:

In the Android Settings class, change GetSharedPrefence to GetSharedPreference
In the iOS Settings class, line 205 - unused commented line

Windows:
I'm confused as to why another CreateContainer would get called (line 155) when the key wasn't found during an add of a value? Could we create a new key/value combo in the current container? Or am I turned around?

Available for testing on: 2.6.0-beta9
Will apply the changes @codemillmatt has said.
For window those that what was always there... I think you are right though.. not sure why it is there, and all my tests still pass. and doesn't need it according to: https://msdn.microsoft.com/library/windows/apps/windows.storage.applicationdata.localsettings.aspx


Enum type instead of define multiple constant variable

regarding to Tact book constants documentation, it defined a non-friendly way to use the Enum concepts in Tact.
developers should define multiple constants instead of an enum, this way has some problem:

the defined constants to use instead of enums do not have a group:
it means if we have to define an enum for the status of a user we should do this for now:

   const activeUser: Int = 0;
   const blockUser: Int = 1;
   const deletedUser: Int = 2;

there is no consistency in naming and grouping.
maybe it be better to do this like it(just syntax sample):
enum user_status {
   ACTIVE = 0,
   BLOCK = 1,
   DELETED = 2
}

or
const (
   userActive = 0
   userBlock = 1
   userDeleted = 2
)

type consistency:
based on the above example from the tact book it is a mistake potential to use constant instead of
enum for types, for example:

  const activeUser: Int = 0;
  const blockUser: string = "1";
  const deletedUser: Int = 2;

Let's consider a solution for the mentioned problem by defining an enum type for tact and the tact compiler to make the tact language more developer-friendly. We can take inspiration from other languages, such as TypeScript, which changed the syntax and defined the enum type, while Golang used const in a grouping manner. There are various ways to implement this, and we should have a detailed discussion about the implementation of this feature in this issue.

Duplicate of #17


refactor: update linting rules, use my docker containers in molecule testing and minor fixes

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Alias electrum_nmc imports as electrum

This keeps us closer to upstream. Kudos to SomberNight from upstream for pointing me in this direction.

The Travis fails appear to be related to dependency versions, which should be fixed once I pull from upstream.  Merging.


Facet tree allow and

Particularly convenient for Classifiers:

allow user to select several item and filter them with a AND
allow user to filter again with another item

This PR includes the commit of PR#79 (fixing the regression on "allowAnd, etc. taken into account")
Relevant changes are in projects/components/facet/bootstrap/facet-tree/facet-tree.ts


isocodes: 3.74 -> 3.79

Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/iso-codes/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 3.79 with grep in /nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79
directory tree listing: https://gist.github.com/0636a62cebb498fde2d51579ff9c3e99

Success on x86_64-linux (full log)
Attempted: isocodes
Partial log (click to expand)
 /nix/store/qrxs7sabhqcr3j9ai0j0cp58zfnny0jz-coreutils-8.29/bin/install -c -m 644 ./data/iso_3166-1.json ./data/schema-3166-2.json ./data/iso_15924.json ./data/iso_639-3.json ./data/iso_3166-2.json ./data/schema-639-2.json ./data/schema-639-5.json ./data/schema-4217.json ./data/schema-15924.json ./data/iso_639-2.json ./data/schema-3166-3.json ./data/schema-3166-1.json ./data/iso_639-5.json ./data/iso_4217.json ./data/iso_3166-3.json ./data/schema-639-3.json '/nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79/share/iso-codes/json'
 /nix/store/qrxs7sabhqcr3j9ai0j0cp58zfnny0jz-coreutils-8.29/bin/mkdir -p '/nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79/share/pkgconfig'
 /nix/store/qrxs7sabhqcr3j9ai0j0cp58zfnny0jz-coreutils-8.29/bin/install -c -m 644 iso-codes.pc '/nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79/share/pkgconfig'
make[2]: Leaving directory '/build/iso-codes-3.79'
make[1]: Leaving directory '/build/iso-codes-3.79'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79
checking for references to /build in /nix/store/v3cwlccrh7g5m03wj8j7fhwc9xyrdj1q-iso-codes-3.79...

Success on aarch64-linux (full log)
Attempted: isocodes
Partial log (click to expand)
 /nix/store/c8bwnx988ckbw2igggv41s1mbd0v743m-coreutils-8.29/bin/mkdir -p '/nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79/share/pkgconfig'
 /nix/store/c8bwnx988ckbw2igggv41s1mbd0v743m-coreutils-8.29/bin/install -c -m 644 iso-codes.pc '/nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79/share/pkgconfig'
make[2]: Leaving directory '/build/iso-codes-3.79'
make[1]: Leaving directory '/build/iso-codes-3.79'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79
checking for references to /build in /nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79...
/nix/store/11c5pz4mipz9a4vzhp9jk0pkbn6riamh-iso-codes-3.79

Success on x86_64-linux (full log)
Attempted: isocodes
Partial log (click to expand)
 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 ./data/schema-639-3.json ./data/iso_3166-3.json ./data/iso_4217.json ./data/iso_639-5.json ./data/schema-3166-1.json ./data/schema-3166-3.json ./data/iso_639-2.json ./data/schema-15924.json ./data/schema-4217.json ./data/schema-639-5.json ./data/schema-639-2.json ./data/iso_3166-2.json ./data/iso_639-3.json ./data/iso_15924.json ./data/schema-3166-2.json ./data/iso_3166-1.json '/nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79/share/iso-codes/json'
 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/mkdir -p '/nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79/share/pkgconfig'
 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 iso-codes.pc '/nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79/share/pkgconfig'
make[2]: Leaving directory '/build/iso-codes-3.79'
make[1]: Leaving directory '/build/iso-codes-3.79'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79
checking for references to /build in /nix/store/q1s7gn90d08dg7lifld8nhxzb6qxzl5y-iso-codes-3.79...

Success on aarch64-linux (full log)
Attempted: isocodes
Partial log (click to expand)
 /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/mkdir -p '/nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79/share/pkgconfig'
 /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c -m 644 iso-codes.pc '/nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79/share/pkgconfig'
make[2]: Leaving directory '/build/iso-codes-3.79'
make[1]: Leaving directory '/build/iso-codes-3.79'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79
checking for references to /build in /nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79...
/nix/store/dmg7s7qvlzsphjlidcx2cgp2znwg71qr-iso-codes-3.79

Success on x86_64-darwin (full log)
Attempted: isocodes
Partial log (click to expand)
 /nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/mkdir -p '/nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79/share/iso-codes/json'
 /nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -m 644 ./data/schema-639-3.json ./data/iso_3166-3.json ./data/iso_639-5.json ./data/schema-3166-1.json ./data/schema-3166-3.json ./data/iso_4217.json ./data/schema-4217.json ./data/schema-639-5.json ./data/iso_639-2.json ./data/schema-639-2.json ./data/iso_3166-2.json ./data/iso_639-3.json ./data/schema-15924.json ./data/iso_15924.json ./data/schema-3166-2.json ./data/iso_3166-1.json '/nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79/share/iso-codes/json'
 /nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/mkdir -p '/nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79/share/pkgconfig'
 /nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -m 644 iso-codes.pc '/nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79/share/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-iso-codes-3.79.drv-0/iso-codes-3.79'
make[1]: Leaving directory '/private/tmp/nix-build-iso-codes-3.79.drv-0/iso-codes-3.79'
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79
/nix/store/f4drbvyns7il9s8wz5zspcvl80dx50yq-iso-codes-3.79

Failure on x86_64-darwin (full log)
Attempted: isocodes
Partial log (click to expand)
cannot build derivation '/nix/store/0l1wcy477q07sq3yibh5ax0cghbv7vaw-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/bf8kcsxzdnn0pp6cdk7277w49k91mdhx-CF-osx-10.10.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/pgv8b0604fqd8r2hk3bwj4yl05qf4ssk-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lh6fysihljkw5rl0hgrbzqnji7gqbdyp-python-2.7.14.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/hv0licjzdx3jmdywdjd830vrydqbfgid-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/7mq5vk1ch577wx2vghdzjgrhccba0046-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/jq1y49miypgx1ag7srsa4svg7y7q94ca-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/v48gd9j4vxgfslnss51qgdn8jsd8qgjn-python3-3.6.4.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/vmlqdr9xx0bmjzrf8krdi6z8gxv3jpr8-iso-codes-3.79.drv': 4 dependencies couldn't be built
error: build of '/nix/store/vmlqdr9xx0bmjzrf8krdi6z8gxv3jpr8-iso-codes-3.79.drv' failed


Updated TypeScript for VS2015 removes JavaScript support

After installation of latest TypeScript update on VS2015 Comunity Edition I found that support for JS was removed. There is no "JavaScript" branch in "Configuration / Text Editor" and VS does not recognize JS syntax. However, Node.js Tools do recognize JS files, but I think it is a separate tool.
S
o, because of the bug I need to completelly remove VS2015 and then try to make "cleare installation" again. Nothing helps: system restore point does not help, VS repair does not help, uninstallation of TypeScript from the system does not help. I will loose whole day making my system working again!

Duplicatie of https://github.com/Microsoft/TypeScript/issues/4238?

Yes, the duplicate.


CavasItem's clip only mode on skewed styleboxes fails to clear.

Tested versions

Reproducible in: 4.3.stable

System information
Godot v4.3.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; <IP_ADDRESS>36) - AMD Ryzen 7 4800H with Radeon Graphics (16 Threads)
Issue description

As you can see, the portions of the stylebox outside the bounding box are not being cleared; artifacts of previous frames persist.
Steps to reproduce
Create a panel with a flat stylebox.
Skew the stylebox.
Put any visible child inside the panel.
Minimal reproduction project (MRP)
panel.zip

Just noticed that this is also the case with expanded margins in general, not just skewed boxes.


WaitForInstance waits indefinitely

As far as I'm aware, and please correct me if I'm wrong, but the promise fromEvent created by WaitForInstance if the component class does not currently exist on the object will exist forever if the component class will never actually exist on the object.
A propsal for this could be to add an optional timeout (though the use of Promise:timeout(), which would add safety to the component as the event will resolve itself if the instance doesn't exist after a certain timeframe.
Another propsal could just be to issue a warning, much like the standard Roblox WaitForChild, that would let the developer know that there is a possible infinite wait on the obejct, so that the developer is at least warned that the class does not appear in a timely manor.

Yeah I think adding a timeout makes sense. This could be the second argument of WaitForInstance. Would also have to define a default timeout (usually I would choose 60 seconds). Could look something like this maybe:
local DEFAULT_TIMEOUT = 60

...

function Component:WaitForInstance(instance: Instance, timeout: number?)
   -- simplified; just demonstrating timeout:
   return somePromiseThing:timeout(timeout or DEFAULT_TIMEOUT)
end

Would also want to add into the documentation that this has a 60-second default timeout. Feel free to tag this onto https://github.com/Sleitnick/RbxUtil/pull/48 if you want!

For reference, the wait-for module has these default timeouts just like described. https://github.com/Sleitnick/RbxUtil/blob/main/modules/wait-for/init.lua

Could there be a potential usecase where someone does not wish to have a timeout at all? I'm unsure if in reality that would be good practice, but it could be used as a listener event in theory on the chance that it ever gets parented. I guess in this case the user could supply a really large number (like math.huge) to ensure that it never times out, but I'm unsure of the implications of giving the user an option to just not timeout.
I can't personally think of a good use for this really, but just thought I'd throw it out there as well.

This was something that could be done, though I think it could just overcomplicate the API and may just be worth not having the option for not timeing out.
lua function Component:WaitForInstance(instance: Instance, timeout: (number | boolean?)) 	local componentInstance = self:FromInstance(instance) 	if componentInstance then 		return Promise.resolve(componentInstance) 	end 	local promise = Promise.fromEvent(self.Started, function(c) 		local match = c.Instance == instance 		if match then 			componentInstance = c 		end 		return match 	end):andThen(function() 		return componentInstance 	end) 	if timeout == false then 		return promise 	end 	timeout = if timeout == true or timeout == nil then DEFAULT_TIMEOUT else timeout 	return promise:timeout(timeout) end
It may not be entirely correct, I have not actually tested this, but the idea would be that if you did the following, then it would use the default.
lua MyComponent:WaitForInstance(workspace.SomeInstance):andThen(function(myComponentInstance)
The folowing would never timeout if the user so desired.
lua MyComponent:WaitForInstance(workspace.SomeInstance, false):andThen(function(myComponentInstance)
The following would timeout after the desired time
lua MyComponent:WaitForInstance(workspace.SomeInstance, 10):andThen(function(myComponentInstance)

My only concern is that this makes the method more confusing to understand at an API level. I think it's reasonable to assume a default timeout and just add a large number otherwise.
For systems that are dealing with parts that might stream in/out, it's better to use the Streamable module, which lets you observe instances within a parent.

Yes this was my concern too, I just thought it as something to consider.

Added it in the attached PR: https://github.com/Sleitnick/RbxUtil/pull/53


cmd: Change default tpm path to use correct defaults

This makes sure gotpm does the right thing on systems that don't
support the RM.
Signed-off-by: Joe Richey<EMAIL_ADDRESS>

LGTM, but why can't we have the default tpmpath logic here (instead of go-tpm)? I feel like that's a somewhat very specific use case in the cmd tool.

This is a good point. I updated the PR to not depend on https://github.com/google/go-tpm/pull/256. Instead it just implements the logic in this package. This should make things easier, and it still solves the problem.
I also updated our dependencies and ran go mod tidy.


Some conv2d operations remain float32 after post training full integer quantization

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS Monteley 12.5.1, Android 12
TensorFlow installation (pip package or built from source): pip package
TensorFlow library (version, if pip package or github SHA, if built from source): 2.5.3

2. Code
Option B: Paste your code here or provide a link to a custom end-to-end colab
Some of the conversion codes are as follows.
converter.experimental_new_quantizer = True
converter._experimental_disable_per_channel = True
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8, tf.lite.OpsSet.SELECT_TF_OPS]
converter.inference_input_type = tf.int8
converter.inference_output_type = tf.int8
converter.representative_dataset = representative_dataset_gen
tflite_model = converter.convert()

3. Failure after conversion

The conversion is successful, but some conv2d operations remain float32 after post training full integer quantization. Some conv2d operations are sandwiched between dequantize and quantize operation, and these conv2d operations has float32 weights and bias. All conv2d should have int8 weights and int32 biases.
I tried running this model on Pixel 6 NNAPI delegate with TFLite model benchmark tool. Some operations fallbacks to the XNNPACK delegate. I suspect that the fallback to XNNPACK delegate is due to the float32 conv2d layers and it causes a slight degradation in inference speed.
How can I quantize all operations to int8 weights and int32 biases? Also, will quantizing all operations to int8 improve inference speed?

Quantized tflite model is here.
model_full_integer_quant.tflite.zip
4. (optional) RNN conversion support
None.
5. (optional) Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
The command to run model benchmark tool on Pixel 6 is as follows. I found specifying nnapi_accelerator_name="google-edgetpu" accelerates the inference speed the most.
android_aarch64_benchmark_model --graph=./model_full_integer_quant.tflite --use_nnapi=true --nnapi_accelerator_name="google-edgetpu" --enable_op_profiling=true
The log is here.

Click here to expand the log.
STARTING!
Log parameter values verbosely: [0]
Graph: [./exp_2/model_full_integer_quant.tflite]
Enable op profiling: [1]
Use NNAPI: [1]
NNAPI accelerator name: [google-edgetpu]
NNAPI accelerators available: [google-edgetpu,google-armnn,nnapi-reference]
Loaded model ./exp_2/model_full_integer_quant.tflite
INFO: Initialized TensorFlow Lite runtime.
INFO: Created TensorFlow Lite delegate for NNAPI.
NNAPI delegate created.
WARNING: NNAPI SL driver did not implement SL_ANeuralNetworksDiagnostic_registerCallbacks!
VERBOSE: Replacing 198 node(s) with delegate (TfLiteNnapiDelegate) node, yielding 7 partitions.
WARNING: NNAPI SL driver did not implement SL_ANeuralNetworksDiagnostic_registerCallbacks!
WARNING: NNAPI SL driver did not implement SL_ANeuralNetworksDiagnostic_registerCallbacks!
WARNING: NNAPI SL driver did not implement SL_ANeuralNetworksDiagnostic_registerCallbacks!
WARNING: NNAPI SL driver did not implement SL_ANeuralNetworksDiagnostic_registerCallbacks!
Explicitly applied NNAPI delegate, and the model graph will be partially executed by the delegate w/ 4 delegate kernels.
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
VERBOSE: Replacing 18 node(s) with delegate (TfLiteXNNPackDelegate) node, yielding 7 partitions.
The input model file size (MB): 3.56052
Initialized session in 1620.78ms.
Running benchmark for at least 1 iterations and at least 0.5 seconds but terminate if exceeding 150 seconds.
count=7 first=114164 curr=68436 min=67413 max=114164 avg=75216.3 std=15972

Running benchmark for at least 50 iterations and at least 1 seconds but terminate if exceeding 150 seconds.
count=50 first=68293 curr=66811 min=66170 max=70650 avg=68201.1 std=1021

Inference timings in us: Init: 1620775, First inference: 114164, Warmup (avg): 75216.3, Inference (avg): 68201.1
Note: as the benchmark tool itself affects memory footprint, the following is only APPROXIMATE to the actual memory footprint of the model at runtime. Take the information at your discretion.
Memory footprint delta from the start of the tool (MB): init=9.42969 overall=51.1094
Profiling Info for Benchmark Initialization:
============================== Run Order ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	 ModifyGraphWithDelegate	 1614.218	  808.024	 50.129%	 50.129%	  1252.000	        2	ModifyGraphWithDelegate/0
	         AllocateTensors	 1607.685	  803.867	 49.871%	100.000%	     0.000	        2	AllocateTensors/0

============================== Top by Computation Time ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	 ModifyGraphWithDelegate	 1614.218	  808.024	 50.129%	 50.129%	  1252.000	        2	ModifyGraphWithDelegate/0
	         AllocateTensors	 1607.685	  803.867	 49.871%	100.000%	     0.000	        2	AllocateTensors/0

Number of nodes executed: 2
============================== Summary by node type ==============================
	             [Node type]	  [count]	  [avg ms]	    [avg %]	    [cdf %]	  [mem KB]	[times called]
	 ModifyGraphWithDelegate	        1	  1616.047	    50.129%	    50.129%	  1252.000	        2
	         AllocateTensors	        1	  1607.735	    49.871%	   100.000%	     0.000	        2

Timings (microseconds): count=1 curr=3223782
Memory (bytes): count=0
2 nodes observed

Operator-wise Profiling Info for Regular Benchmark Runs:
============================== Run Order ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	     TfLiteNnapiDelegate	    6.458	    6.441	  9.446%	  9.446%	     0.000	        1	[Identity]:219
	   TfLiteXNNPackDelegate	    5.023	    5.078	  7.448%	 16.894%	     0.000	        1	[tfl.quantize4]:222
	     TfLiteNnapiDelegate	   10.697	   10.688	 15.675%	 32.569%	     0.000	        1	[model/tf.math.add_33/Add;model/conv2d_12/Conv2D;model/conv2d_32/Conv2D;model/tf.math.add_33/Add/y1, model/tf.nn.relu_24/Relu;model/tf.math.add_35/Add;model/conv2d_12/Conv2D;model/conv2d_34/Conv2D;model/tf.math.add_35/Add/y, model/tf.math.add_71/Add;model/conv2d_9/Conv2D;model/conv2d_66/Conv2D;model/tf.math.add_71/Add/y1, model/tf.math.add_5/Add;model/conv2d_12/Conv2D;model/conv2d_5/Conv2D;model/tf.math.add_5/Add/y11, model/tf.math.add_56/Add;model/conv2d_12/Conv2D;model/conv2d_53/Conv2D;model/tf.math.add_56/Add/y1]:218
	   TfLiteXNNPackDelegate	   10.060	    9.159	 13.432%	 46.001%	     0.000	        1	[tfl.quantize1, tfl.quantize3]:221
	     TfLiteNnapiDelegate	   15.087	   15.096	 22.140%	 68.141%	     0.000	        1	[model/tf.math.add_14/Add;model/conv2d_12/Conv2D;model/conv2d_14/Conv2D;model/tf.math.add_14/Add/y11, model/tf.math.add_29/Add;model/conv2d_12/Conv2D;model/conv2d_28/Conv2D;model/tf.math.add_29/Add/y1, model/tf.math.add_99/Add;model/conv2d_transpose/stack;model/conv2d_transpose_7/conv2d_transpose;model/tf.math.add_99/Add/y1, model/tf.math.add_2/Add;model/conv2d_9/Conv2D;model/conv2d_2/Conv2D;model/tf.math.add_2/Add/y1, model/tf.math.add_2/Add;model/conv2d_9/Conv2D;model/conv2d_2/Conv2D;model/tf.math.add_2/Add/y11, model/tf.math.add_75/Add;model/conv2d_12/Conv2D;model/conv2d_70/Conv2D;model/tf.math.add_75/Add/y1]:217
	     TfLiteNnapiDelegate	    8.404	    8.342	 12.235%	 80.376%	     0.000	        1	[tfl.dequantize, model/tf.strided_slice/StridedSlice31, model/tf.math.add_11/Add;model/conv2d_9/Conv2D;model/conv2d_11/Conv2D;model/tf.math.add_11/Add/y11, model/tf.math.add_47/Add;model/conv2d_9/Conv2D;model/conv2d_44/Conv2D;model/tf.math.add_47/Add/y1]:216
	   TfLiteXNNPackDelegate	   12.543	   13.381	 19.624%	100.000%	     0.000	        1	[tfl.quantize, model/tf.math.add_94/Add;model/conv2d_9/Conv2D;model/conv2d_79/Conv2D;model/tf.math.add_94/Add/y11, tfl.quantize2]:220

============================== Top by Computation Time ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	     TfLiteNnapiDelegate	   15.087	   15.096	 22.140%	 22.140%	     0.000	        1	[model/tf.math.add_14/Add;model/conv2d_12/Conv2D;model/conv2d_14/Conv2D;model/tf.math.add_14/Add/y11, model/tf.math.add_29/Add;model/conv2d_12/Conv2D;model/conv2d_28/Conv2D;model/tf.math.add_29/Add/y1, model/tf.math.add_99/Add;model/conv2d_transpose/stack;model/conv2d_transpose_7/conv2d_transpose;model/tf.math.add_99/Add/y1, model/tf.math.add_2/Add;model/conv2d_9/Conv2D;model/conv2d_2/Conv2D;model/tf.math.add_2/Add/y1, model/tf.math.add_2/Add;model/conv2d_9/Conv2D;model/conv2d_2/Conv2D;model/tf.math.add_2/Add/y11, model/tf.math.add_75/Add;model/conv2d_12/Conv2D;model/conv2d_70/Conv2D;model/tf.math.add_75/Add/y1]:217
	   TfLiteXNNPackDelegate	   12.543	   13.381	 19.624%	 41.764%	     0.000	        1	[tfl.quantize, model/tf.math.add_94/Add;model/conv2d_9/Conv2D;model/conv2d_79/Conv2D;model/tf.math.add_94/Add/y11, tfl.quantize2]:220
	     TfLiteNnapiDelegate	   10.697	   10.688	 15.675%	 57.439%	     0.000	        1	[model/tf.math.add_33/Add;model/conv2d_12/Conv2D;model/conv2d_32/Conv2D;model/tf.math.add_33/Add/y1, model/tf.nn.relu_24/Relu;model/tf.math.add_35/Add;model/conv2d_12/Conv2D;model/conv2d_34/Conv2D;model/tf.math.add_35/Add/y, model/tf.math.add_71/Add;model/conv2d_9/Conv2D;model/conv2d_66/Conv2D;model/tf.math.add_71/Add/y1, model/tf.math.add_5/Add;model/conv2d_12/Conv2D;model/conv2d_5/Conv2D;model/tf.math.add_5/Add/y11, model/tf.math.add_56/Add;model/conv2d_12/Conv2D;model/conv2d_53/Conv2D;model/tf.math.add_56/Add/y1]:218
	   TfLiteXNNPackDelegate	   10.060	    9.159	 13.432%	 70.871%	     0.000	        1	[tfl.quantize1, tfl.quantize3]:221
	     TfLiteNnapiDelegate	    8.404	    8.342	 12.235%	 83.106%	     0.000	        1	[tfl.dequantize, model/tf.strided_slice/StridedSlice31, model/tf.math.add_11/Add;model/conv2d_9/Conv2D;model/conv2d_11/Conv2D;model/tf.math.add_11/Add/y11, model/tf.math.add_47/Add;model/conv2d_9/Conv2D;model/conv2d_44/Conv2D;model/tf.math.add_47/Add/y1]:216
	     TfLiteNnapiDelegate	    6.458	    6.441	  9.446%	 92.552%	     0.000	        1	[Identity]:219
	   TfLiteXNNPackDelegate	    5.023	    5.078	  7.448%	100.000%	     0.000	        1	[tfl.quantize4]:222

Number of nodes executed: 7
============================== Summary by node type ==============================
	             [Node type]	  [count]	  [avg ms]	    [avg %]	    [cdf %]	  [mem KB]	[times called]
	     TfLiteNnapiDelegate	        4	    40.564	    59.495%	    59.495%	     0.000	        4
	   TfLiteXNNPackDelegate	        3	    27.616	    40.505%	   100.000%	     0.000	        3

Timings (microseconds): count=50 first=68272 curr=66794 min=66156 max=70634 avg=68184.7 std=1022
Memory (bytes): count=0
7 nodes observed

Delegate internal:
============================== Run Order ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	        DelegateOpInvoke	    0.265	    0.283	  1.025%	  1.025%	     0.000	        1	Delegate/Convert (NC, F32, QS8):5
	        DelegateOpInvoke	    1.737	    2.685	 29.222%	 30.247%	     0.000	        3	Delegate/Convolution (NHWC, F32) IGEMM:0
	        DelegateOpInvoke	    0.035	    0.035	  0.382%	 30.629%	     0.000	        3	Delegate/Convert (NC, F32, QS8):1
	        DelegateOpInvoke	    0.978	    4.353	 31.581%	 62.210%	     0.000	        2	Delegate/Convolution (NHWC, F32) IGEMM:2
	        DelegateOpInvoke	    0.133	    0.149	  1.085%	 63.295%	     0.000	        2	Delegate/Convert (NC, F32, QS8):3
	        DelegateOpInvoke	    9.371	   10.118	 36.705%	100.000%	     0.000	        1	Delegate/Convolution (NHWC, F32) IGEMM:4

============================== Top by Computation Time ==============================
	             [node type]	  [first]	 [avg ms]	     [%]	  [cdf%]	  [mem KB]	[times called]	[Name]
	        DelegateOpInvoke	    9.371	   10.118	 36.705%	 36.705%	     0.000	        1	Delegate/Convolution (NHWC, F32) IGEMM:4
	        DelegateOpInvoke	    0.978	    4.353	 31.581%	 68.286%	     0.000	        2	Delegate/Convolution (NHWC, F32) IGEMM:2
	        DelegateOpInvoke	    1.737	    2.685	 29.222%	 97.508%	     0.000	        3	Delegate/Convolution (NHWC, F32) IGEMM:0
	        DelegateOpInvoke	    0.265	    0.283	  1.025%	 98.533%	     0.000	        1	Delegate/Convert (NC, F32, QS8):5
	        DelegateOpInvoke	    0.133	    0.149	  1.085%	 99.618%	     0.000	        2	Delegate/Convert (NC, F32, QS8):3
	        DelegateOpInvoke	    0.035	    0.035	  0.382%	100.000%	     0.000	        3	Delegate/Convert (NC, F32, QS8):1

Number of nodes executed: 6
============================== Summary by node type ==============================
	             [Node type]	  [count]	  [avg ms]	    [avg %]	    [cdf %]	  [mem KB]	[times called]
	        DelegateOpInvoke	        6	    27.562	   100.000%	   100.000%	     0.000	       12

Timings (microseconds): count=50 first=27574 curr=26304 min=26187 max=29665 avg=27565.3 std=973
Memory (bytes): count=0
6 nodes observed

After updating TensorFlow I got the following conversion log. TensorFlow version is tensorflow==2.10.0. This issue isn't solved.
WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 92). These functions will not be directly callable after loading.
Estimated count of arithmetic ops: 32.554 G  ops, equivalently 16.277 G  MACs
fully_quantize: 0, inference_type: 6, input_inference_type: INT8, output_inference_type: INT8
Estimated count of arithmetic ops: 32.554 G  ops, equivalently 16.277 G  MACs

Hi @sachinprasadhs !
Could you look at this issue.
Thank you!

Hi @ksekine, some operations cannot currently be quantized, that is why you see Dequantize (8-bit -> 32-bit) nodes and Quantize (32-bit -> 8-bit) nodes), so that we can continue the conversion despite those operations not being supported.
Currently we do not support different precision weights & biases, we do support mixed precision weights & activations though (we call this 16x8 quant mode), please review this for more information: https://www.tensorflow.org/lite/performance/post_training_integer_quant_16x8

How can I quantize all operations to int8 weights and int32 biases?

The current framework is unable to for you, there is probably a way if you go very deep into the code, if you happen to solve this, please feel free to submit a PR where we will review it.

Also, will quantizing all operations to int8 improve inference speed?

Almost assuredly yes, please review this (somewhat older) benchmark data to get a better idea: https://www.tensorflow.org/lite/performance/model_optimization#quantization . This is with Pixel 2 devices using a single big core CPU. New hardware is more optimized for int8 computations, I suspect their inference improvements would be even better.
Does this answer your questions?

Hi @pkgoogle, thank you for replying. I understood the situation and what I need to do. I'll go deep into the code. Please feel free to close this issue.
I'm grateful for your support. 👍

Hi @ksekine, please feel free to close as unplanned if you have no more open items.


Temporary Travis action for security checker can be removed when upgrading to PHP 7.2 or 7.1.18

In the build.xml, a temporary fix was introduced in order to deal with Symfony's security checker change to HTTPS / TLS and Travis' troubles dealing with this.
This has been fixed in Travis for PHP versions 7.2 and 7.18 and up by using OpenSSL instead of GnuTLS.
When upgrading to a more modern PHP version, consider using the correct security-checker action in the build.xml instead.
See: sensiolabs/security-checker#73, travis-ci/travis-ci#6339, sensiolabs/security-checker#77.
The PR that introduced this: OpenConext/OpenConext-engineblock#407.

@MKodde

This temporary fix has been removed in 54126f55 and has been in EB releases since release 5.9.
Closing this issue


bugfix: server callback dont need new heartbeat

don't need create new heartbeat timer per server callback call

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhaohui.yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add a button for image upload

#371 How it looks

LGTM, works fine, thank you. The only thing I'd like to change a little bit - the image icon looks larges compared to others. Maybe make it smaller or use a different icon?

another thing - currently hint is saying "Attach the image". Will be nice to change "Attach image, drag & drop, or paste from clipboard"

I changed hint and decrease icon size. But before all icon had 16px height.

So, added a bit of review, if it's not hard to change, will be great. Otherwise good work, @Mavrin thank you so much!


Inline context creation and custom list for empty annotations

This PR address issue #493 .
Compact/brief/inline context has been created and contextualized in Chaise.
The default display is changed to MARKDOWN for newly created context.
Chaise repo PR has been raised for review.

Before I review this PR, can you address the white space being changed unnecessarily by your editor?
@RFSH asked you about this a month ago in a different PR and I asked you about this in your batch add association PR in chaise last week. He asked me to make the same change and I have since then so that PR reviews are much easier to go over without having to find what the actual changes are.

I have changed the editor setting for this one. but it seems not working; I will check this again.


Support multiple languages

Here it is @erickgnavar, @ZuraGuerra, and @3100.  This pull request is first draft at implementing multiple language support on elixirschool.com.
To create a new language:

Create a folder for the 2 character language code (e.g. jp, en, es, etc)
Add lessons/{basics,advanced,specifics} folders inside it.
Move translated lessons over.
Add lang: XX to the lesson page meta data.
Add the language to _config.yml as part of languages and the sections translations.

This is awesome! Great work :+1:
I tried adding some Japanese lessons and it worked.  There seem to be some improvements:

Langages' links (e.g. jp) below the sidebar redirect us to https://elixirschool.com and it's a bit inconveninent when debugging. (Other links such as lessons are relative.)
The sections are not translated in my environment.

Sorry @3100 I should have addressed your first point in my original PR comments:

As a work around to how Jekyll handles paths I'm relying on the url value in _config.yml to provide the base for assembling the language links.  For me locally, the value http://localhost:4000 does the trick.  I agree there could be a better solution than repeatedly changing that value.  I'll keep at it :grinning:

Could you be more specific when you say the sections are not translated?  Do you mean the section headers (Basics, Advanced, Specifics) or the actual lessons themselves?

Thanks for your help!

@doomspork Thanks for your information and now I see how to config languages' link paths on the sidebar for development.

Could you be more specific when you say the sections are not translated? Do you mean the section headers (Basics, Advanced, Specifics) or the actual lessons themselves?

Sorry, I mean the section headers.

I'll look at the section headers this morning for you @3100 :grinning:

@3100 I pushed a change to the PR, could you take a look?  You'll need to update the _config.yml:
sections:
  - tag: basics
    label:
      en: Basics
      jp: 目次
  - tag: advanced
    label:
      en: Advanced
      jp: 目次
  - tag: specifics
    label:
      en: Specifics
      jp: 目次

@doomspork Thanks, now it translates perfectly :+1:

That's great news @3100!
I'm going to poke at this a bit more over the weekend and then deploy these changes.  After that we can start getting translations online.

Thanks again for your help @3100! :+1:


Support missing import.meta.env

Currently vite storybook builder breaks when any env var used in code via import.meta.env is missing while building storybooks.
Apparently that happens because Rollup does direct inline replacements and turns code like
const getMyVar = () => import.meta.env.VITE_MISSING_VAR === 'true'

into something like
const getMyVar = () => {"BASE_URL":"/","MODE":"production","DEV":false,"PROD":true}.VITE_MISSING_VAR === "true";

which is syntactically incorrect.
See my reproduction repo for an example — https://github.com/princed/vite-sb-meta-env-repro.
To mitigate this vite itself adds a replacement from import.meta.env. to ({}). to catch missing direct replacements and produce correct code. I opted for identical solution here.
A similar workaround is also possible on the user side:
viteFinal(config) {
   config.define = {
     'import.meta.env.': `({}).`,
   };
   return config;
}

It seems like maybe the vite solution still has a kink to work out? https://github.com/vitejs/vite/issues/8663. Maybe we should hold off until that issue is solved, before adding this.

Happy to wait and see whether Vite team finds another approach to the problem, but it seems unlikely though.
We also could just merge this for now, and then handle changes (if any) when adding Vite 3 support (which will surely require some dedicated effort).

Vite 3 has been released, and https://github.com/vitejs/vite/issues/8663 is not yet solved.  I'm happy to proceed with this if the underlying problem is still an issue in Vite 3 (would you mind confirming?).

Don't mind at all, but will only be able to do that in a week.

So with Vite 3 and https://github.com/vitejs/vite/issues/8663 not fixed, even this PR doesn't fix building storybooks ¯\_(ツ)_/¯


NC gradient background widget

The widget is not released yet.

Hey @ConnorLand , the widget is released and we are ready to proceed with this PR