How to mount an API under a base path

Say I’ve got an API with endpoints /a and /b
How could I create a server which would serve them at /prefix/a and /prefix/b?
thanks!

Maybe there's a better API for that in @effect/platform but something like this should do
const app = RouterBuilder.make(api).pipe(
  ...,
  RouterBuilder.build,
  (app) => HttpServer.router.empty.pipe(HttpServer.router.mountApp("/prefix", app))
)

RouterBuilder.build returns the @effect/platform's App, so from that point you can do whatever with that using App / Router combinators.
One more thing, if you're adding a prefix, you could also benefit from making this information available in the OpenApi using servers field when defining an Api
const api = Api.make({ servers: [{ url: '/prefix', description: 'my server name' }] })

Thanks! My first attempt was adding url in servers, but that didn’t work, lol
I’ll try that tomorrow and report back

@adrian-gierakowski you did not report back

My apologies. This approach worked for me, thanks!

Would be awesome if this feature would be support natively in effect-http! I often have the case that I want to prefix some endpoints with /v1 etc. and having to remember to keep the docs in sync can be cumbersome


Adding script for deploying flannel

This script is meant to deploy flannel on a cluster with working etcd and config file for flannel is already in etcd database.

No the best place to put it... Move it to our internal repo.


refact(blockdevice): make changes to core blockdevice struct

added Identifier field consisting of unique IDs which can be used to identify the blockdevice
added Capacity field having all storage related information
added DeviceDetails field consisting of hardcoded information that may be available on the blockdevice
refactored the exporter code to make use of new fields in BlockDevice

Codecov Report

Merging #373 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage      51%   51.49%   +0.49%
==========================================
  Files          55       55
  Lines        2637     2637
==========================================
+ Hits         1345     1358      +13
+ Misses       1182     1172      -10
+ Partials      110      107       -3

Impacted Files
Coverage Δ

db/kubernetes/convert.go
57.14% <100%> (ø)
:arrow_up:

cmd/ndm_daemonset/probe/udevprobe.go
65.64% <0%> (+5.34%)
:arrow_up:

cmd/ndm_daemonset/probe/eventhandler.go
53.94% <0%> (+7.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca1c22...80b6a8f. Read the comment docs.


Add tests for CASSANDRA-10134

+1 after nits. I'm not really sure what Travis is upset about. I think it's safe to ignore.

Thanks, I've fixed the nits, rebased, squashed and merged.


feat(amoy): add amoy to chain config

Ralated to https://github.com/gakonst/ethers-rs/pull/2723

please run cargo t --all-features once and commit the changed spec

Done @mattsse


Scanning for "IHost" implementations does not seem to ignore abstract classes

Hi,
We've implemented an abstract base class for our IHost implementations, but the host .exe is generating an exception, "Shuttle.Core.Host doesn't support hosting of multiple IHost type implementations...."
Given our base class is abstract, it's not possible to instantiate it, so the service should be able to exclude that from the check.
Would it be possible for the scanner to ignore abstract classes please?
Many thanks!
Cheers,
Clayton

Since logging this, I've realised that I can probably workaround it by explicitly setting the host on the command line

Hi,
Not a bad idea to only scan for classes that can be instantiated.  I'll get around to that at some stage.
In the meantime, though: Shuttle.Core.ServiceHost is a new generic hosting option that runs off a console application.  There are some advantages such as not having to substitute the configuration file at runtime and there are also options to start and stop the service.  It shouldn't be a lot of work to switch so something to consider :)
Regards,
Eben

Okay, great. Thanks for that, will look into it.
And thanks for your prompt reply, yet again :)


Separation of plotting from computation

If a system is passed in, both the root locus and bode functions do both computations and produce a plot. In my opinion, it would be better to separate the computation from the plotting. The plotting commands should then return matplotlib axes and maybe figure instances and the computation methods would return the results of the computations, e.g. roots, mag/phase, etc.
Right now there aren't clean ways to get hold of the figure and axes (I don't consider .gca() and .gcf() that "clean"). And if you are using a plotting library other than matplotlib you may not want to call functions that create matplotlib plots.
There maybe other plotting functions in the library that I haven't play with yet too that this is applicable too.

I was thinking along the same lines.  This would be more in line with other libraries like Pandas.  I wrote a draft for how this might work here:

New plotting paradigm

Is this what you had in mind @moorepants ?

This issue has been moved to #645.


Cannot save entity M2.1.7 - reguired field 'behave as tree'

Hi,
I've just installed the latest version of UMC on a vanilla install of M2.1.7 and cannot save the module.  On the entity create screen I am getting an validation message 'This is a required field.' which appears near the Entity Type (flat) select box.  However looking at the code of the message, it is related to hidden field 'Behaves As Tree'

so if i make the field unhidden and add value '0' I can save.  Not sure if selecting 'flat' in the entity type is supposed to trigger this value. but as 'flat' is the only value, the trigger doesnt fire.

@tomdollarmpd Thanks for the heads up I will take a look.


Ensure frontend options are applied appropriately to all frontends

The HTTP frontend now supports accept-proxy.

Bugs where accept-proxy was not honored during mutual TLS have been
resolved

ha_proxy.client_cert is no longer required to enable TLS. It is
still honored to enable mutual tls, but the boshrelease will also
use the presence of the following parameters to enable mutual TLS:

ha_proxy.client_ca_file
ha_proxy.client_revocation_list
ha_proxy.crt_list.<i>.client_ca_file
ha_proxy.crt_list.<i>.client_revocation_list
ha_proxy.crt_list.<i>.verify - only when value is not "none"

The following options are now honored in the :4443 backend:

ha_proxy.cidr_whitelist
ha_proxy.cidr_blacklist
ha_proxy.block_all
ha_proxy.hsts_*
ha_proxy.rsp_headers

The X-Forwarded-Client_Cert now is set for requests in the :4443
backend.

The X-Forwarded-Proto header behavior in the :4443 backend now
matches the behavior in the :443 backend

Fixes #95

@dueckminor, @jgf can I get a sanity check on this update ? Hoping to resolve the bugs found in #94 (and a few others found in the process of resolving them), and make it less likely for updates to the TLS bind settings to be missed in certain backends

Go for it, otherwise I can hopefully get to it in the next few days. Have been fighting fires elsewhere this week, but I appreciate you both taking a look and finding my bugs :)
Sent from my iPhone

On Mar 13, 2018, at 1:14 PM, Juergen Graf<EMAIL_ADDRESS>wrote:
@jgf requested changes on this pull request.
Overall great stuff! This change makes it much more readable. Thanks!
I have found some smaller issues that I commented on. If you'd like I can put our findings and suggestions on top of your branch.
In jobs/haproxy/templates/haproxy.config.erb:

frontend http-in
mode http

bind <%= p("ha_proxy.binding_ip") %>:80
<% if_p("ha_proxy.cidr_whitelist") do %>

bind <%= p("ha_proxy.binding_ip") %>:80 <%= accept_proxy %>
According to spec the accept_proxy property enables the proxy protocol for all TLS/SSL frontends. This change now enables it also for pure http/tcp frontends. I generally like the idea that the global flag should influence all frontends, but this will break backwards compatibility. I would vote for keeping the original behaviour and may change it in a later release.

In jobs/haproxy/templates/haproxy.config.erb:

<% tcp_proxy["backend_servers"].each_with_index do |ip, index| %>

<% tcp_proxy["backend_servers"].each_with_index do |ip, index| -%>
The -%> writes all server node definitions in a single line.

In jobs/haproxy/templates/haproxy.config.erb:

@@ -416,7 +433,7 @@ end %>
<% end -%>
<% end -%>

<% if tcp_proxy["health_check_http"] then %>

<% if tcp_proxy["health_check_http"] then -%>
-%> indents the following line by 2 whitespaces (the ones form the start of this line). Thats probably unwanted.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@geofffranks I'll try to come with something from our side by tomorrow


LocalCache met IndexOutOfBoundsException when read file

Alluxio Version:
Master branch
commit hash 6f8c5d26
Describe the bug
cat /data/wangzhe/mbl/testa12.txt
cat: /data/wangzhe/mbl/testa12.txt: Input/output error

Fuse.log

2021-07-20 14:57:11,033 ERROR AlluxioJniFuseFileSystem - Failed to read, path: /test.sh size: 4096 offset: 0
java.lang.IndexOutOfBoundsException
        at java.nio.Buffer.checkBounds(Buffer.java:567)
        at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:357)
        at alluxio.client.file.cache.LocalCacheFileInStream.read(LocalCacheFileInStream.java:115)
        at alluxio.fuse.AlluxioJniFuseFileSystem.readInternal(AlluxioJniFuseFileSystem.java:377)
        at alluxio.fuse.AlluxioJniFuseFileSystem.lambda$read$5(AlluxioJniFuseFileSystem.java:352)
        at alluxio.fuse.AlluxioFuseUtils.call(AlluxioFuseUtils.java:280)
        at alluxio.fuse.AlluxioJniFuseFileSystem.read(AlluxioJniFuseFileSystem.java:352)
        at alluxio.jnifuse.AbstractFuseFileSystem.readCallback(AbstractFuseFileSystem.java:180)
2021-07-20 14:57:11,037 ERROR AlluxioJniFuseFileSystem - Failed to read, path: /test.sh size: 4096 offset: 0

To Reproduce
Using the following config to start Alluxio fuse and read the file contents of alluxio fs
alluxio.user.client.cache.enabled=true
alluxio.user.client.cache.dir=/tmp/alluxio_cache
alluxio.user.client.cache.size=4GB

cat /data/wangzhe/mbl/testa12.txt

Expected behavior
Output the file contents
Urgency
Urgent
Additional context
No

I guess the issue is broke by #13406 , please take a look @neuyilan

I guess the issue is broke by #13406 , please take a look @neuyilan

Thanks for pointing it out, I'll take a look.

@neuyilan Thanks for the quick response!

Hi @maobaolong , I did a lot of tests locally according to your steps. There were different file sizes and local cache sizes, but they were not reproduced. However, through the code review, a possible bug is indeed found. I have submitted a pr. if possible, please reproduce your issue based on this PR to see if it has been solved.
Thanks.
https://github.com/Alluxio/alluxio/pull/13849


DS-144: Accordion deep linking

Jira
https://pegadigitalit.atlassian.net/browse/DS-144
Summary
Add deep linking functionality to Accordion component.
Details
Deep linking setup is modeled after same feature on Tabs. It uses the query param ?selected-item=ITEM_ID to deep link to an Accordion item.

Added scroll_offset_selector, and scroll_offset props to Accordion
Added id prop to Accordion Item
Deprecated uuid from Accordion Item. It's only used internally for the no-JS functionality, does not need to be customized.

How to test

Review code
Review two new demo pages
Verify no regressions to other Accordion demos

Release notes
uuid prop is deprecated on Accordion Item. I do not believe this prop is in use on any properties.

The Code looks good. The two new demo pages show this update working. I didn't find any regressions with other demos.
I think the answer is no, but should this work with JS disabled?
I also wonder if we should call -item something less indistinct. for example -bellows. I am worried that we will need to deep link another component and have to use selected-item elsewhere.

I think the answer is no, but should this work with JS disabled?

Good question. No, it's a JS-only feature.

I also wonder if we should call -item something less indistinct. for example -bellows. I am worried that we will need to deep link another component and have to use selected-item elsewhere.

Also, a good call. Tabs uses ?selected-tab=. Maybe accordion should use ?selected-accordion-item=? @mikemai2awesome  you're good naming things - any suggestions?


Train with the provided hyperparameters and cannot get a small model with 78.8% acc1 and 3.6G FLOPs

Hi, Thanks for your interesting work.
I try to train avit-small model with the provided hyperparameters. Finally, I get a model with 79.8% acc1 and 4.3G FLOPs. The performance is different from that of the pretrained A-ViT.
would you mind sharing the detail of hyperparameters to reproduce the model with 78.8% acc1 and 3.6G FLOPs.

Hello, I want to ask you, how can you get the FLOPs?

Hello, I want to ask you, how can you get the FLOPs?

I get the FLOPs of each sample on the ImageNet Val dataset and average the FLOPs.

use which library? thop?

Hello, I am interested in this work. I installed the packages in the requirements.txt, but I got the error like this.
'Traceback (most recent call last):
File "/data/ML_document/A-ViT/main_act.py", line 504, in
main(args)
File "/data/ML_document/A-ViT/main_act.py", line 443, in main
train_stats = train_one_epoch(
File "/data/ML_document/A-ViT/engine_act.py", line 67, in train_one_epoch
rho_token = torch.mean(model.module.rho_token)
File "/home/zjlab/miniconda3/envs/ad_vit/lib/python3.8/site-packages/torch/nn/modules/module.py", line 771, in getattr
raise ModuleAttributeError("'{}' object has no attribute '{}'".format(
torch.nn.modules.module.ModuleAttributeError: 'VisionTransformer' object has no attribute 'module''
I installed the timm=0.3.2 in the virtual env but the version is 0.4.12 in the project. Is this was caused by the mismatch of the imports?

Hi, i am also trying to understand how you calculate the FLOPs, and which library you used

Hello, I am interested in this work. I installed the packages in the requirements.txt, but I got the error like this. 'Traceback (most recent call last): File "/data/ML_document/A-ViT/main_act.py", line 504, in main(args) File "/data/ML_document/A-ViT/main_act.py", line 443, in main train_stats = train_one_epoch( File "/data/ML_document/A-ViT/engine_act.py", line 67, in train_one_epoch rho_token = torch.mean(model.module.rho_token) File "/home/zjlab/miniconda3/envs/ad_vit/lib/python3.8/site-packages/torch/nn/modules/module.py", line 771, in getattr raise ModuleAttributeError("'{}' object has no attribute '{}'".format( torch.nn.modules.module.ModuleAttributeError: 'VisionTransformer' object has no attribute 'module'' I installed the timm=0.3.2 in the virtual env but the version is 0.4.12 in the project. Is this was caused by the mismatch of the imports?

Hi there. I met the same issue. Have you solve it? Can you share your way?


⚠ Bofrost.be has degraded performance

In ba9388f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2512 ms

Resolved: Bofrost.be performance has improved in 35c406d.


Issue 1094 : GitHub Actions

GitHub Actions
This PR contains 3 GitHub actions that use Office 365 CLI.

login action : Log in to a tenant
deploy action: Add, deploy and install  an app
runscript action: Runs any o365 script - accepts either one line or a file containing commands

Documentation
All the documentation is present under '\docs\cmd\actions'. There is also a document which shows a complete workflow that can be used for SPFx CI/CD.

Coverage remained the same at 100.0% when pulling cd08d55c0fd6e2291a1981cc5b95a1aa098d1b13 on anoopt:issue-1094 into 3042bbe08f8c20d16fa959c4b6a0c5a07f5415d8 on pnp:dev.

Nice! Just for my understanding: since runscript is not really related to Office 365 CLI, does it make sense for us to include it? Doesn't GitHub already have a generic action to allow running any arbitrary script?

Ah sorry. It is actually run-office365cli-script. The only advantage of using this action over directly running the script is that there will be no need to install office 365 CLI before the script. This is because the corresponding docker container will take care of cli installation. What are your thoughts on this?

Very nice review @VelinGeorgiev and I agree with you: let's try to make it as clear and as easy as possible for everyone who'd like to use these actions. @anoopt is Velin's input sufficient for you to evolve the PR?

Thank @VelinGeorgiev for the detailed review. It is very helpful. Please find below my comments:
Manual tasks
I like the idea of the command you are suggesting that creates a YAML file. So if we go ahead with that, should the command output a YAML file, with some manual instructions on how to add that file in the GitHub repository? In that way at least some manual tasks will be reduced.
Extending .sh files
I did think about this, hence I submitted the "runscript" action as part of this PR. The runscript action takes any number of Office 365 CLI commands.
So the idea being

If the only step that needs to be done as part of the workflow is deploy solution then, we can use 'login' and 'deploy' action.
If more steps need to be executed then, use the 'runscript' action with all the extra steps. OR
If more steps need to be executed then, use 'login' action first followed by 'runscript' action for the other steps.

Please let me know what you think about this.

Fantastic review @VelinGeorgiev 👏🏻
I’ve not looked into GitHub Actions much so not that knowledgeable on this subject but it is certainly a great area to explore. Great suggestion @anoopt 👍🏻
Agree with @waldekmastykarz that making things easier in the first instance is the way forward.
@VelinGeorgiev I really like your suggestion of using a command to generate the necessary files to reduce the number of manual steps that developers have to go through, this way we could easily expand to include more tasks and cater for different automation tools in the future. This also gives the developer the option to update or edit these files to their own needs, if required.

@garrytrinder @VelinGeorgiev It seems like the right way of distributing GitHub actions is through the marketplace, so following it, we wouldn't need a command in the CLI to help people set up our actions in their project. Instead, they'd acquire them from the marketplace.
@anoopt after setting up action in their project, devs have ownership of all files, so could adjust them as they need so, in theory, they wouldn't need a separate runscript action because they could adjust existing .sh files, or are you suggesting a separate runscript task so that it's easier to maintain and upgrade our tasks if need be without affecting changes that folks might have done to have the actions meet their needs?

Thank you all for your response. Please find below my thoughts
Marketplace
@waldekmastykarz @VelinGeorgiev @garrytrinder - From what I know there are 2 ways of hosting the action:

Publish it in the marketplace - for which each action would need it's own repo. Once that repo has a release, GitHub provides us a UI in which we accept T&Cs so that the action in that repo can be published in the marketplace. I have published once such action called "Create an event using Microsoft Graph" (as shown below and sorry for bit of marketing). So this action has it's own repo and whenever there is a new release the version keeps changing. When this action is referenced in a workflow/yaml (by someone else in their repo) they will need to specify anoopt/ms-graph-create-event@v1. If we decide to go ahead with marketplace, then according to me, for Office 365 CLI actions, there would be a repo for each action - login, deploy and runscript (more on this later).

Hosting the action without publishing in the marketplace - With this option we can host all the actions in one place. (This is what I have submitted in the PR currently). In this case, all we have to do is have a parent folder which contains all the actions we need, and have sub-folder for each action. The way we would reference these actions in a workflow would be by specifying the path to action and it's branch. Say for example if I had not published the above action and would have kept it in the master branch of a repo called sample-actions in a folder called ms-graph. Then if someone needed that action, they wouldn't find it in the marketplace. So they would need to know that this action exists and the way they would add it in their workflow is anoopt/sample-actions/ms-graph@master. The reason why I chose this approach for the CLI actions I have submitted was:

There would be no need to create a separate repo for each action
We can keep adding more actions to in the CLI repo easily
The master branch will always have the right version of the action so there would be no need for someone to change from say v1 to v2

Runscript action
@waldekmastykarz - Yes I agree with you. So devs will setup a workflow in their project - which is a yaml file. So they can choose to not use any of the actions (that are part of this PR) and decide to directly write the commands in the yaml file itself, like we do in Azure pipelines. The extra bit they would need to do is install Office 365 CLI in the workflow.
However, if they use the runscript action instead in their workflow - there would be no need to install Office 365 CLI and they will have 2 options:

Supply a command to that action in the yaml file
Supply a file path in the repo to that command - that file (say cmds.p1 or cmds.sh) will have all the commands that need to be executed. So with regards to maintenance, there would no need to modify the yaml file, instead modify the cmds.p1.

Option of no actions
The actions that are part of this PR basically run some Office 365 CLI commands i.e. login action runs the o365 login command, deploy action runs  o365 add, deploy and install app commands and so on. We can achieve all this directly in the workflow yaml file without referring to actions. So instead of having actions, maybe we can think of just some documentation on how to create a workflow and how to use Office 365 CLI commands in that workflow. In that way, devs can easily extend the workflow with all the commands they need.
Or - have both actions and no actions documentation and leave the devs to create a workflow in their repo either with the actions or without actions.

This is a good discussion. I gave you a few options above, but now, here is my opinion.
1. I would go for the marketplace if our target is users that can use the public Github repos for two reasons:
The marketplace will give us a little bit more discoverability at no cost.
The easiest way for the user to discover the Github action is from the marketplace because the user will be there with a specific purpose to search for actions. We can, of course, amplify this discoverability by promoting the action ourselves, but having the action in the marketplace with give us additional discoverability without extra efforts.
Users prefer one-click setup over referencing and reading about stuff (from my experience)
If the user has workflow wizard to click here and there and set it up in 2 mins ... that will be the preference. This is what my experience shows. Even I as an experienced developer would try to save some time (in many situations) if I have a wizard and one-time click setup.
2. I would go with CLI command that spawns the action if our target is users that can NOT use the public Github repos for one reason:
Some companies are not allowed to use public Github because of VNETS, DMZs, PROXYs or other restrictions. Then the CLI spawns the action in their source code and this will be a good alternative so they can use it with Github enterprise.
My suggestion. We start with option 1 and we implement option 2 if there is a demand for it.

Creating separate repo per action should not be an issue
We can create good documentation around the action in the CLI docs and how they can find it and use it.

I am in agreement with @VelinGeorgiev stated approach.
Using the marketplace allows us to promote the use of the CLI in yet another platform, one which at the moment has a lot of focus as it’s relatively new so we can benefit from the wider marketing and interest in GitHub Actions.
Option one appears to me to give us quicker time to market at lower effort, this allows use to gain feedback quicker which will help drive the decision making as to whether we implement option two.
Sticking to the marketplace approach, we could look into adding a similar actions into Azure DevOps marketplace, much like the PnP PowerShell action currently available. https://marketplace.visualstudio.com/items?itemName=s-kainet.pnp-powershell
From a marketing perspective

Thanks everyone and I appreciate your opinions. Great to have discussions based on solid arguments 👍
Preference-wise, I'd like to avoid offering actions in two ways, because it will mean that every change will need to be managed in two places which duplicates effort and maintenance. So ideally, we settle on one way. Since the code is open source anyway, even if we chose to publish only to the marketplace, organizations that can't use it, are still free to grab the code and build their own actions off of our code, which would address the scenario @VelinGeorgiev described.
Since the CLI is a part of the PnP org where we host a number of different initiatives, let me check with others what's the best way around it so that we keep things clean and discoverable for other users. I'll get back to you as soon as I know more.
Sorry for the delay @anoopt and I appreciate your patience. We'll get it in for sure, just need to find the best way to do it 😊

Thank you all. Great discussion. Yes, I completely agree - let's do it the best way.

Together with the PnP crew we decided that we should put these actions, each in its own repo in the PnP org, so that we can publish them in the GitHub marketplace.
@anoopt shall we close this PR and instead, create separate ones to thew newly created repos (I'll put the links in here as soon as we have them).
As for the docs for the action, it would be good to keep them here. Additionally, do you think it would help to have a generic intro page to getting started using actions or would it end up copying GitHub docs and a link to these docs would be sufficient?
Thanks again for your support 👏

The three repos are here:
https://github.com/pnp/action-cli-login
https://github.com/pnp/action-cli-deploy
https://github.com/pnp/action-cli-runscript
They're currently empty so we'll likely need a readme page as well, but we can add that later.

Brilliant 👍
With respect to documentation, the ones submitted as part of this PR need to be updated - in particular the usage section - they would need to point to the newly created repos. So if needed, this PR can be closed and I can create a new PR in this repo with just the documentation (sorry if that is not the right way).
Also, yes it makes sense to have a generic page on getting started with actions - it would be mix of our own words and links to GitHub documentation.

How about we wait with docs until the actions are available in the GitHub marketplace so that we don't need to point people just to the repo but we can use the marketplace as the primary location and use the repo as a fallback and contribution location?

Yes. Good idea. Maybe we can have the generic intro to GitHub Actions document here in which we, along with overview of GitHub Actions, briefly explain how to set up a workflow for an SPFx repo followed by how to use the CLI actions in that workflow?
This is based on Velin's earlier feedback.

That would be awesome and a nice fit into the examples section of the docs. 👍

So for next steps @anoopt:

Could you please submit three new PRs to the corresponding action repos in the PnP org?
Once the PRs are merged, we'll publish the actions to marketplace
When the actions are in the marketplace, could you submit a new PR with docs here

Aggreed? 🙂

Umm, I thought I submitted the PRs to the new repos a couple of days ago.
Are you able to see the request? If not, please let me know. Thank you.
On Fri, 13 Dec 2019, 18:34 Waldek Mastykarz<EMAIL_ADDRESS>wrote:

So for next steps @anoopt https://github.com/anoopt:

Could you please submit three new PRs to the corresponding action
repos in the PnP org?
Once the PRs are merged, we'll publish the actions to marketplace
When the actions are in the marketplace, could you submit a new PR
with docs here

Aggreed? 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pnp/office365-cli/pull/1228?email_source=notifications&email_token=ACJ6YEICK5FGEPRFYFA6P3LQYPIUXA5CNFSM4JTHSAM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG23LVY#issuecomment-565556695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACJ6YEPGCBLII5XIJAQM7FTQYPIUXANCNFSM4JTHSAMQ
.

Thanks @anoopt! We'll check the other repos in the following days.
Thanks for the example as well! We'll review it asap.

Thank you @VelinGeorgiev 👍

@anoopt we can keep this PR but if you could push another commit removing the action files, then we could keep everything else, including our discussions in place. Thank for your help! As @VelinGeorgiev mentioned, we'll go through the actions asap.

Thank you @waldekmastykarz . I have deleted the files related to actions in one of the previous commits

I am marking this as 'work in progress' because I will try to process this right after we have published the GitHub actions.

Merged manually


[plot]change condition for choosing the dock widget area

Use the legacy pymca condition w > 1.25*h to initialize docks in the RightDockWidgetArea instead of the BottomDockWidgetArea.
Closes #2011.
Closes https://github.com/vasole/pymca/issues/277

LGTM


[Feature Request] UI: Grouping / classing overlay elements (low priority)

I had some time today so I started brainstorming possible things that might be useful additions.  The process below will probably only save a few clicks so I put the [Low Priority] on the title.
One thing I've noticed is when selecting edits to the file, I always wonder if I need to select all the frames before continuing. As such, I tried to figure out was how to separate the operations that affect the whole animation vs. those that just affect the entire file.  I'm not sure if this addresses a real problem or is something users wouldn't just figure out through the course of using the program but maybe it's worth exploring.
Of course the easy thing is just to throw everything under a separate tab:

... but this is probably confusing since it duplicates a number of UI elements.  And I think the current categories make a lot of sense, especially for new users.
Another possibility is just marking the items a little differently with some kind of legend, either a marker or a different text color:

... anyway some ideas.

I'm planning a redesign for that UI.
I'll reorganize the features based on how they interact with the project.


Create a new block manager when writing files

Currently the same block manager is used for all writes of the same AsdfFile object, and it retains state between calls to write_to. This is not good because it leads to confusing and sometimes erroneous behavior with respect to the storage type of certain arrays (see #599 and #618 for one particular example).
When creating an AsdfFile object with the intent to write a new file, there is no need to create a block manager until actually calling write_to. This should help resolve ambiguities without introducing any other user-visible effects.

https://github.com/asdf-format/asdf/pull/1537 largely rewrote block management. Read and written blocks are now separated. Write blocks are not created until writing and are not shared across writes.


Deprecated Usage of $.proxy() in ZeroClipboard jQuery Plugin

The ZeroClipboard jQuery plugin currently uses the deprecated $.proxy() method, which has been removed from jQuery starting from version 3.3. This may lead to compatibility issues with newer versions of jQuery. To address this, the code should be updated to use the standard Function.prototype.bind() method instead. This will ensure better compatibility with the latest jQuery versions.
Proposed Changes:
Replace instances of $.proxy() with Function.prototype.bind() throughout the code.

Why is balsamiq repository dead ? Why there is no activities in the repos ?


JSDoc : support @interface and @implements

TypeScript Version:  2.3.3
Code
In a JavaScript file, with checkJs option :
/**
 * @interface Movable
 */

/**
 * @function
 * @name Movable#move
 * @param {number} distance
 */

/**
 * @implements {Movable}
 */
class Vehicle {}

Actual behavior:
No error.
Expected behavior:
An error should be raised. It's important in checkJs mode as JavaScript doesn't have native interfaces.

hi @cyrilletuzi , any reason for closing this?

First because when checkJs mode was released I was very excited to be able to have the power of static types but staying in native JS. But in the end it's really more painful than to be in real TypeScript, especially for that kind of advanced features.
Second, because there was no reaction, so I supposed my early enthusiasm was really not such a good idea.

But in the end it's really more painful than to be in real TypeScript, especially for that kind of advanced features.

wondering if you can elaborate about your experience with checkJS..

In my case I'm still a bit reluctant to transpile my node.js code or use something like ts-node.  Even if its a bit verbose, having the option to define interfaces in .d.ts files and use them in actual js code is really useful for some compile time type checking.

My main use case for checkJs is in Node, but I wouldn't go as far as writing interfaces in jsdoc, it's already quite heavy and messy to just write @typedef for objects, and to manage to have the types for all the libraries used.

Even if its a bit verbose, having the option to define interfaces in .d.ts files and use them in actual js code is really useful for some compile time type checking.

Why is not @typedef not sufficient?

My main use case for checkJs is in Node, but I wouldn't go as far as writing interfaces in jsdoc, it's already quite heavy and messy to just write @typedef for objects, and to manage to have the types for all the libraries used.

Have you considered adding .d.ts for your types and using these in your .js files?

Well, no :/ In my head it was "full JS" or "full TS", but I didn't thought I could mix both worlds. Therefore, jsdoc for interfaces is really not needed.

@mhegazy I did try using .d.ts files. But I couldn't figure out how to use the interfaces defined there on the js files.

did try using .d.ts files. But I couldn't figure out how to use the interfaces defined there on the js files.

were both modules?

Voting for reopening this issue and support '@interface' and '@implements'
@cyrilletuzi

First because when checkJs mode was released I was very excited to be able to have the power of static types but staying in native JS. But in the end it's really more painful than to be in real TypeScript, especially for that kind of advanced features.

But if pain comes from lack of supported jsdoc features then let's support it, right (why close the issue)?
Or there are any other concerns about ts annotations vs jsdoc annotations?


Move ~grpc_server_security_connector() = default to .cc file

When the implementation is in the header file, there's an "incomplete type" error caused by grpc_server_credentials.
Compiling with clang version 11.0.0 (https://github.com/llvm/llvm-project.git 8697d443ab24d1652d09393efca768cdf4c22b39), Target: x86_64-apple-darwin19.4.0
through cmake's add_subdirectory( lib/grpc ) in a parent project
[...] Building CXX object lib/grpc/CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o
FAILED: lib/grpc/CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o
/usr/local/opt/llvm/latest/bin/clang++  -DCARES_STATICLIB -D__CLANG_SUPPORT_DYN_ANNOTATION__ -I../../lib/grpc/third_party/zlib -I../../lib/grpc/include -I../../lib/grpc -I../../lib/grpc/third_party/address_sorting/include -I../../lib/grpc/third_party/boringssl-with-bazel/src/include -I../../lib/grpc/src/core/ext/upb-generated -I../../lib/grpc/third_party/upb -Ilib/grpc/third_party/zlib -Ilib/grpc/third_party/cares/cares -I../../lib/grpc/third_party/cares/cares -I../../lib/grpc/third_party/abseil-cpp -stdlib=libc++ -nostdinc++ -ibuiltininc -I /usr/local/opt/llvm/latest/include/c++/v1 -fcxx-exceptions -fassociative-math -freciprocal-math -march=native -mtune=native -fforce-emit-vtables -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.15 -fPIC -std=c++2a -MD -MT lib/grpc/CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o -MF lib/grpc/CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o.d -o lib/grpc/CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o -c ../../lib/grpc/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc
In file included from ../../lib/grpc/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc:21:
In file included from ../../lib/grpc/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.h:28:
In file included from ../../lib/grpc/src/core/lib/gprpp/ref_counted.h:36:
../../lib/grpc/src/core/lib/gprpp/ref_counted_ptr.h:103:34: error: member access into incomplete type 'grpc_server_credentials'
if (value_ != nullptr) value_->Unref();
^
../../lib/grpc/src/core/lib/security/security_connector/security_connector.h:154:3: note: in instantiation of member function 'grpc_core::RefCountedPtr<grpc_server_credentials>::~RefCountedPtr' requested here
~grpc_server_security_connector() override = default;
^
../../lib/grpc/include/grpc/grpc_security.h:465:16: note: forward declaration of 'grpc_server_credentials'
typedef struct grpc_server_credentials grpc_server_credentials;

@yashykt

Fixing  EasyCLA email address issue, irrelevant to the pull request

The CLA check is still failing.  We can't look at this code until that passes.

I'll try closing and re-opening the PR.

@markdroth Seems to be working now. Do you need me to rebase onto head? The change is trivial, moving the (default) definition from the header to the implementation file.

It's not clear to me what's causing this problem or why this fix helps, but the change itself seems fine.  Let's see if the tests are happy.

@markdroth Right, I'm not sure about the incomplete type at that point, could very well be a recent LLVM thing -- maybe https://reviews.llvm.org/D79945 ? -- but since the change should make no functional or performance difference... :)

This looks good to me.  @yihuazhang, can I get a second review from you?  Once you approve, I'll go ahead and merge.


consideration length enforced

Added a check for total original consideration items and the consideration array length during order validation.  If the original items amount and the consideration array length doesn't match it reverts by MissingOriginalConsiderationItems()
Added a test case: "Reverts if consideration array length doesn't match"

Codecov Report
Base: 99.63% // Head: 99.54% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (fe07cf4) compared to base (68a0364).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.2     #719      +/-   ##
==========================================
- Coverage   99.63%   99.54%   -0.10%
==========================================
  Files          47       47
  Lines        2209     2211       +2
  Branches      342      343       +1
==========================================
  Hits         2201     2201
- Misses          4        5       +1
- Partials        4        5       +1

Flag
Coverage Δ

production
99.81% <ø> (ø)

reference
99.29% <0.00%> (-0.18%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reference/lib/ReferenceOrderValidator.sol
97.81% <0.00%> (-1.09%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


split climate projections

Hi @crgoddard,
Could you please review this PR?

waiting for the toc fix (and possibly .md removal)


Older extensions won't load in CLI 2.0.67 due to missing kwarg min_profile

The 2.0.67 release of Azure CLI removed a kwarg min_profile that several older extensions used. If you run into this error, please first update your extension with:
az extension update  -n <NAME>

This has been socialized. Closing.


New Rule Proposal: enforce return in render() method

It sometimes happens to me that I forget to return JSX content in the render method. This rule would warn if the return statement is missing.

I run into this use case as well. It's fairly easy to catch with the React errors in the browser, but having a rule to help catch it before hand would be great. @yannickcr I can put together a PR for this if it's a rule we want to add.
Proposed Rule Name: require-render-return

What about returning null? What about returning the contents of a function call (which may or may not contain jsx)?
If this is just ensuring that a render method returns something, that's fine, but I'm skeptical about the value it will add.

In my mind the rule would just check for a return statement in the render method. It wouldn't care about what it's returning. The value add would probably depend on the project and the component. I'm not sure how to measure that value, but I know it'd be useful for our projects at MX (especially for newbie devs)

If this is just ensuring that a render method returns something, that's fine, but I'm skeptical about the value it will add.

Same for me, but if you send a PR for this @bsbeeks don't really see reasons to refuse it.

You can always bypass certain rules in some way, you can do const { props } = this and now using props.foo won't check if foo is defined in propTypes.
If a component returns an invalid value, there's not much the plugin can do about it. This rule is a faster way to see that you forgot to return the JSX. If the user returns something which does not resolve to JSX, that's on them. This distinction is clear to me.


feat: working behind proxy

What/Why/How?
Closes #529
Reference
Testing
Screenshots (optional)
Check yourself

[ ] Code is linted
[ ] Tested with redoc/reference-docs/workflows
[ ] All new/updated code is covered with tests

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

I suggest moving proxy logic to utilities to follow the principle of DRY.

@andriyl I think this is fine in the current way. This is copied just 2 times and moving it to utilities will make code harder to read. Let's  keep it duplicated and move it to utils if only we need to copy this code one more time.

@andriyl I think this is fine in the current way. This is copied just 2 times and moving it to utilities will make code harder to read. Let's keep it duplicated and move it to utils if only we need to copy this code one more time.

I suggest having it only in core and I hope it makes sense.


[RELEASE] mc RELEASE.2023-11-15T22-45-58Z

mc RELEASE.2023-11-15T22-45-58Z has changes that impact the docs:

[ ] mc admin commands now support using STS tokens (PR #4754)
[x] mc admin trace --stats outputs an additional column of info (PR #4757)
[x] Adds mc alias export (PR #4759)
[ ] Additional mc environment variables (PR #4763)

As per Harsha, do not document 4763 as it requires further refinement and fixups.


Fix script for player hurt/killed entity

Please make sure this works because I don't trust it.

👍


Vue-Clamp and slots

I am trying to get this working with a slot, but can't seem to get it working. When I load the page, the content is missing, but there are no errors. I didn't see examples, so I tried to follow what you had in the App.vue in the repo. Here is what I have.
Communications.vue
I loop through and call the instances of communications

   <CommunicationInstance>

       {{ communication.date }}

{{ communication.content }}

   </CommunicationInstance>

And then in the CommunicationsInstance.vue I have for the part that I was vue-clamp to be used:

                <v-clamp class="communication-instance-content" :max-lines="lines" auto-resize>
                    <slot name="content"></slot>
                </v-clamp>

Then within the script tag I have
import VClamp from 'vue-clamp'
export default {
    data() {
        return {
            lines: 3,
            expanded: false
        }
    },
    components: {
        VClamp
    }

}

And in the vue.config.js file I have:
module.exports = {
  transpileDependencies: ['vue-clamp', 'resize-detector']
};

What am I doing wrong here?

I was calling from the parent, when I should have called from the child. Works now.

@mituller I'm looking at a very similar situation - can you clarify what you changed to make your example work?


transfer native token to sourceTokenAddress

Signed-off-by: cyl19970726<EMAIL_ADDRESS>

Further, please use
npm run prettier:fix
to auto-format the code.

Should BridgeDestination.withdraw() also handle the native token logic?

BridgeDestination.withdraw() already supports native token transfer


Add docs for adding tests

This adds some docs to make the python testing :sparkles: easier to understand.

@calvix I would love your opinion here as well :heart:

LGTM, not python expert and I found the explanation nice and complete. Maybe I would add the test outputs of the example for clarity

I added some sample output at the end.


Add a parse(File) method and review exceptions thrown by parser

A convenience method that parses a file  with SDA content.
This would also allow us to throw exceptions with a reference to the file.

While we're at it we might as well add convenience methods for the Formatter.


Fix path to rollup in gulpfile

Thank you for the PR. I have incorporated the changes into v2.0.0-beta.1 with da32dc3, so close this. Gulp will be removed soon, though.


TypeScript syntax highlighting issue with arrow functions

VSCode Version: 1.33.1
OS Version: Solus 4

Steps to Reproduce:

Setup code like so:

public constructor(authService: AuthService) {
		super(GoogleStrategy.options, async (
			req: Request, // eslint-disable-line @typescript-eslint/no-unused-vars
			accessToken: string,
			refreshToken: string, // eslint-disable-line @typescript-eslint/no-unused-vars
			profile: Profile, // eslint-disable-line @typescript-eslint/no-unused-vars
			done: VerifyFunction // eslint-disable-line @typescript-eslint/no-unused-vars
		): Promise<User> => {
			const user = await authService.validateUser(accessToken);
			if (user === undefined) {
				throw new UnauthorizedException();
			}

			return user;
		});
	}

Then change it to this

public constructor(authService: AuthService) {
		super(
			GoogleStrategy.options,
			async (
				req: Request, // eslint-disable-line @typescript-eslint/no-unused-vars
				accessToken: string,
				refreshToken: string, // eslint-disable-line @typescript-eslint/no-unused-vars
				profile: Profile, // eslint-disable-line @typescript-eslint/no-unused-vars
				done: VerifyFunction // eslint-disable-line @typescript-eslint/no-unused-vars
			): Promise<User> => {
				const user = await authService.validateUser(accessToken);
				if (user === undefined) {
					throw new UnauthorizedException();
				}

				return user;
			}
		);
	}

Does this issue occur when all extensions are disabled?: Yes

The syntax even breaks in GitHub highlighting haha

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Also, what is the issue? The wrong color keywords in the arrow func?

Not sure why the second image did not get posted. The textmate grammar classifiers change significantly in the second example. async becomes a function name. The parameters are no longer classified as such. This reproduces in insiders on macOS.

Thanks for the clarification.
This is a duplicate of https://github.com/Microsoft/TypeScript-TmLanguage/issues/705 which has been marked as wont-fix due to the limitations of textmate grammars
Closing as a duplicate


add partitioning scheme for unresolved shuffle and shuffle reader exec

Which issue does this PR close?

Closes https://github.com/apache/datafusion-ballista/issues/16.
Rationale for this change

unresolved shuffle and shuffle reader exec does not have partitioning info. This becomes a problem when a stage has InterleaveExec, which requires all its children to have hash partitioning on the same expressions. Currently even though the partitioning satisfies InterleaveExec's requirements, because children show UnknownPartitioning planning such plans into stages fail.
What changes are included in this PR?

Carry partitioning scheme through shuffles
Are there any user-facing changes?

Changes I think look good. Can we add a test for it?

@Dandandan should be ready for another look

Thanks @onursatici


test: add molecule test for everything

Proposed feature
including executing commands like curl with specific options set that fail if a specific cert thing is not ok
Rationale
before releasing v1 i want to have proper CI in place
Additional context
this will for example also include additionaly configuring apache and simple vhost and simple etc/hosts etc pp

coudln't do it, /etc/hosts can not be edited in a docker container. creating own create.yml is too much boilerplate and unsureness. what one could maybe to is to check if ca store file changed after execution of role, by copying a backup of it before execution of role and comparing in verify.yml


release instruction for HotpotQA

Can you also release the code and instruction for the HotpotQA dataset tasks?

Do you have plan to release the code and instruction for the WikiHop dataset task?

Any update on the HotpotQA instructions?


Fix in main file

Fix in main file

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Native support for TypedDict.

Allow using instances of TypedDict as a type for data kwarg.
Support openapi docs, and Partial.
PR Checklist

[ ] Have you followed the guidelines in CONTRIBUTING.md?
[ ] Have you got 100% test coverage on new code?
[ ] Have you updated the prose documentation?
[ ] Have you updated the reference documentation?

I don't think DTO.from_model_instance() can be supported for TypedDict - correct me if I'm wrong - there is no typing info retained when a dict is constructed from a TypedDict.
It doesn't look like we actually use that method internally for anything though:


Merge r3.0 into master

@gbbr, I just updated branch r3.0 to compile against the latest nodb branch of go-sourcegraph. When that is merged, can you merge r3.0 into master?

Thank you. Yes, of course

Note that the majority of r3.0 branch was already merged into master (rebased, with minor fixes) in #11.
So you'd only need to merge the new commits on r3.0 branch: it currently appears to be a single commit 22d8200cdad3fcc3cd0de2550ec6cf482f8ba43e.

You can just cherry-pick it on top, it merges nicely (I tried locally).

I'll take care of this since I happened to have it done locally and it's easy. @gbbr said he doesn't mind.

Of course not. Thank you!
On 28 April 2015 at 18:02, Dmitri Shuralyov<EMAIL_ADDRESS>wrote:

I'll take care of this since I happened to have it done locally and it's
easy. @gbbr https://github.com/gbbr said he doesn't mind.
—
Reply to this email directly or view it on GitHub
https://github.com/sourcegraph/syntaxhighlight/issues/12#issuecomment-96982611
.

Made #13 to close this issue. Once nodb branch of go-sourcegraph is merged, I'll test the PR if it needs updating, and merge it into master.


Doc error

In the README.md, the following script:
git clone https://github.com/mkaz/lanyon
cd lanyon/src
go get github.com/russross/blackfriday
go build -o lanyon

It should be:
git clone https://github.com/mkaz/lanyon
cd lanyon
go get github.com/russross/blackfriday
go build -o lanyon

Thus cd lanyon instead of cd lanyon/src.

I've updated the build instructions


iOS requires two touches to set date

iOS 8, safari & chrome both require two touches to set the date, which feels very unresponsive

I did see this behavior in IOS 7.0.4 in Safari (haven't tested on Chrome) with the statusBar enabled such as on Demo#2.  It worked for me with one tap when I removed the statusBar like in Demo#1.  Seems like a definite bug.

This problem also exists when using staticPos.


Fixed the typo

Fixed the typo targetGrpoup

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls


NanoPi R5C

Would this build work with NanoPi R5C as well?

Some people reported to me that it works. I could not confirm because I don't own a device.


Generate statement (genvar, generate)

It has been implemented in to_verilog.py and from_verilog.py


Please allow to set the same hotkey for recording and playback device.

I would like to be able to switch my recording and playback devices with one hotkey. Right now this is not possible because it makes me use a new hotkey for the recording vs the Playback.

Check out https://github.com/xenolightning/AudioSwitcher_v1/issues/1969
It has a full run down of a similar feature request


Added RouteComponent interface and jest env variable to setupTest.ts

@jorilindell Couple changes/suggestions for codebase


Nginx reverse proxy setup returns bad request error with documentation config

Description
Not sure if this is a bug tbh, I recently setup gitea 1.22.0 via docker image (never used gitea before), following the documentation on nginx reverse proxy.
Seems the proxy_set_header Host $host is causing a 400 bad request error.
Removing it fixes access to the webgui. However, when performing a git clone command, it would redirect to the webgui for authentication and authorization, which works, but an ERR_SSL_PROTOCOL_ERROR is thrown right after.
server config looks like this
[server]
APP_DATA_PATH = /data/gitea
DOMAIN = domain.com
SSH_DOMAIN = domain.com
ROOT_URL = https://domain.com/
DISABLE_SSH = false
SSH_PORT = 22
SSH_LISTEN_PORT = 22
LFS_START_SERVER = true
LFS_JWT_SECRET =
OFFLINE_MODE = false

proxy config like this
server {
    listen 443 ssl;
    listen [::]:443 ssl;

    server_name domain.*;

    include /config/nginx/ssl.conf;

    location / {

        include /config/nginx/proxy.conf;
        include /config/nginx/resolver.conf;
        set $upstream_app gitea-ip;
        set $upstream_port 3000;
        set $upstream_proto http;
        proxy_pass $upstream_proto://$upstream_app:$upstream_port;
        proxy_set_header Connection $http_connection;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Host $host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;

    }
}

I also tried the $http_host variable, but this also throws a bad request error
also tried the provided swag template for gitea
server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;

    server_name domain.*;

    include /config/nginx/ssl.conf;

    client_max_body_size 0;

    location / {

        include /config/nginx/proxy.conf;
        include /config/nginx/resolver.conf;
        set $upstream_app gitea-ip;
        set $upstream_port 3000;
        set $upstream_proto http;
        proxy_pass $upstream_proto://$upstream_app:$upstream_port;

    }

    location ~ (/gitea)?/info/lfs {
        include /config/nginx/proxy.conf;
        include /config/nginx/resolver.conf;
        set $upstream_app gitea-ip;
        set $upstream_port 3000;
        set $upstream_proto http;
        proxy_pass $upstream_proto://$upstream_app:$upstream_port;

    }
}

which does work for the webgui, but no git cloning.
cloning without the reverse proxy through http does work
Gitea Version
1.22.0
Operating System
Unraid
How are you running Gitea?
Gitea runs on docker
Postgresql 15 docker as a database
Swag docker as reverse proxy (nginx)
each docker container has a unique LAN IP address, 443 is forwarded to swag
Database
PostgreSQL

I am not sure whether you have mixed some different web servers together.

Seems the proxy_set_header Host $host is causing a 400 bad request error: the question is "which program reports that 400 error"? UnRAID web server or Gitea?
but an ERR_SSL_PROTOCOL_ERROR is thrown right after: it means that your web server's SSL part doesn't work properly.

If you use Gitea under the same domain as UnRAID web, then you must put Gitea in a sub-path.
If you use Gitea on a dedicated domain, which doesn't conflict with UnRAID, then you could try to look into the logs to figure out which part fails (nginx or Gitea)

The official document is here: https://docs.gitea.com/administration/reverse-proxies

Thx for the fast response,
I have a subdomain config for each of my services running, so there should be no collision between any requests.
It's a bit weird to my that the webgui does work perfectly when removing the "proxy_set_header Host $host;", only thing that is not working is git.
I also checked the error log on both the proxy and the gitea server (error level set to debug), with no errors in both

Could you try to only use the sample from official doc?
https://docs.gitea.com/administration/reverse-proxies#nginx
server {
    #add here:
    server ...
    listen ...
    ssl ....

    # the official config
    location / {
        client_max_body_size 512M;
        proxy_pass http://localhost:3000;
        proxy_set_header Connection $http_connection;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Host $host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
    }
}

This config gives me a 400 bad request error for the webgui, which is fixed when removing the "proxy_set_header Host $host;", I get no errors in both gitea log or the swag log (checking now if maybe I can set a better log level on the reverse proxy to make sure I get them all)

That's really weird. Most users are using Gitea behind nginx, this is the first report for "400" error. It's highly likely related to the reverse proxy config in my mind.
TBH I have no more idea about it. If you could provide a reproducible setup (eg: a docker compose) and it could reproduce on my machine, then I could try to continue to figure out.

Hi,
so this is really weird, I just removed the whole proxy subdomain config file and started from scratch, copy pasted the config in the docs you also linked.... and now it seems to be working.
Been raging on this for a week, but it seems to work now with the following config:
server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;

    server_name subdomain.*;
    add_header X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
    include /config/nginx/ssl.conf;
    add_header Strict-Transport-Security "max-age=15768000; includeSubDomains; preload;";
    client_body_buffer_size 400M;

    location / {
        client_max_body_size 512M;
        proxy_pass http://ip:3000;
        proxy_set_header Connection $http_connection;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Host $host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
    }

}

I think the issue was some config files that swag includes by default in their templates that are incompatible with gitea, the "include /config/nginx/proxy.conf;" line probably. Not sure what specific setting causes the error though.
Thank you very much for your help, really appreciate it

Glad to help. I think this issue could be closed. Feel free to open a new issue if there is anything wrong.


[WIP] Refactor waveform loader

@nsteinme @marius10p @yger little question: how should I normalize waveforms (directly extracted from the raw data file) to compare them to templates? Can I assume that unwhitened templates and the traces are in the same space and can be directly compared, i.e. there's no need for a scaling factor? (for template subtraction in the trace view, and for displaying waveforms and templates in the same view)

In our case, but I guess this is the same for KiloSort, because we have non-binary amplitudes, there is, for every waveform, a scaling factor to establish a proper match with the template. To be more precise, when a waveform is detected at time step t with an amplitude k, it means that the spike in the raw data has been fitted by k.template. Most often, k is close to 1, but not exactly, because of drifts. So to be more precise, you should substract k*unwhitened template from the raw data if you want to have a precise view of what are the residuals considered by the algorithm in the TraceView. Conversly, when you are plotting groups of waveforms on top of the template in the Waveform view, then all those waveforms should be scaled by 1/k
Hope this helps

Yes same for Kilosort. Those amplitude scaling factors - amplitudes.npy -
should in general be around 1 for Kilosort but I believe the mean of them
for any given template is not required to be.
Do you currently use a scaling factor?
On Thu, Nov 10, 2016 at 10:23 PM, Pierre Yger<EMAIL_ADDRESS>wrote:

In our case, but I guess this is the same for KiloSort, because we have
non-binary amplitudes, there is, for every waveform, a scaling factor to
establish a proper match with the template. To be more precise, when a
waveform is detected at time step t with an amplitude k, it means that the
spike in the raw data has been fitted by k.template. Most often, k is close
to 1, but not exactly, because of drifts. So to be more precise, you should
substract k*unwhitened template from the raw data if you want to have a
precise view of what are the residuals considered by the algorithm in the
TraceView. Conversly, when you are plotting groups of waveforms on top of
the template in the Waveform view, then all those waveforms should be
scaled by 1/k
Hope this helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259825534, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHPUP2QIVV5JUvgBkXeTC28syBme7RCJks5q85logaJpZM4Kurcu
.

What do you mean by "do we use" ? The answer is yes. SpyKING CIRCUS can
take care of small drifts or burst by using those scaling factors, and this
is a valuable information to see to understand what has been done by the
algorithm. In the MATLAB GUI, currently, waveforms are scaled by those
amplitudes values when compared to the template. Because for me cases
amplitudes can be pretty large, I strongly think they should be integrated
in the TraceView or the waveform view of phy. if not taken into account
when displaying the residuals, spikes can appear to still be there while in
fact they have been properly fitted. (We just submitted a small review
paper on biorxiv that should be online tomorrow I guess, discussing
template-matching based approaches and talk about those amplitudes. I can
send you the pdf.)
Best
Le ven. 11 nov. 2016 00:36, nsteinme<EMAIL_ADDRESS>a écrit :

Yes same for Kilosort. Those amplitude scaling factors - amplitudes.npy -
should in general be around 1 for Kilosort but I believe the mean of them
for any given template is not required to be.
Do you currently use a scaling factor?
On Thu, Nov 10, 2016 at 10:23 PM, Pierre Yger<EMAIL_ADDRESS>wrote:

In our case, but I guess this is the same for KiloSort, because we have
non-binary amplitudes, there is, for every waveform, a scaling factor to
establish a proper match with the template. To be more precise, when a
waveform is detected at time step t with an amplitude k, it means that
the
spike in the raw data has been fitted by k.template. Most often, k is
close
to 1, but not exactly, because of drifts. So to be more precise, you
should
substract k*unwhitened template from the raw data if you want to have a
precise view of what are the residuals considered by the algorithm in the
TraceView. Conversly, when you are plotting groups of waveforms on top of
the template in the Waveform view, then all those waveforms should be
scaled by 1/k
Hope this helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259825534, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AHPUP2QIVV5JUvgBkXeTC28syBme7RCJks5q85logaJpZM4Kurcu
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259839941, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABmE_9yXnOKyTVLyDDKcWFf8Vprflf5Kks5q86pfgaJpZM4Kurcu
.

Sorry Pierre! I wasn't clear, I was addressing that question to Cyrille.
Because TraceView does already show the residual after subtracting the
templates, and it appears to do this [at least mostly] successfully so I
wondered whether Cyrille was already using a scaling factor. Definitely I
did not forget that Spyking Circus has always had this necessary feature :)
On Fri, Nov 11, 2016 at 6:06 AM, Pierre Yger<EMAIL_ADDRESS>wrote:

What do you mean by "do we use" ? The answer is yes. SpyKING CIRCUS can
take care of small drifts or burst by using those scaling factors, and this
is a valuable information to see to understand what has been done by the
algorithm. In the MATLAB GUI, currently, waveforms are scaled by those
amplitudes values when compared to the template. Because for me cases
amplitudes can be pretty large, I strongly think they should be integrated
in the TraceView or the waveform view of phy. if not taken into account
when displaying the residuals, spikes can appear to still be there while in
fact they have been properly fitted. (We just submitted a small review
paper on biorxiv that should be online tomorrow I guess, discussing
template-matching based approaches and talk about those amplitudes. I can
send you the pdf.)
Best
Le ven. 11 nov. 2016 00:36, nsteinme<EMAIL_ADDRESS>a écrit :

Yes same for Kilosort. Those amplitude scaling factors - amplitudes.npy -
should in general be around 1 for Kilosort but I believe the mean of them
for any given template is not required to be.
Do you currently use a scaling factor?
On Thu, Nov 10, 2016 at 10:23 PM, Pierre Yger<EMAIL_ADDRESS>wrote:

In our case, but I guess this is the same for KiloSort, because we have
non-binary amplitudes, there is, for every waveform, a scaling factor
to
establish a proper match with the template. To be more precise, when a
waveform is detected at time step t with an amplitude k, it means that
the
spike in the raw data has been fitted by k.template. Most often, k is
close
to 1, but not exactly, because of drifts. So to be more precise, you
should
substract k*unwhitened template from the raw data if you want to have a
precise view of what are the residuals considered by the algorithm in
the
TraceView. Conversly, when you are plotting groups of waveforms on top
of
the template in the Waveform view, then all those waveforms should be
scaled by 1/k
Hope this helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259825534, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/
AHPUP2QIVV5JUvgBkXeTC28syBme7RCJks5q85logaJpZM4Kurcu
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259839941, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABmE_
9yXnOKyTVLyDDKcWFf8Vprflf5Kks5q86pfgaJpZM4Kurcu>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259888219, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHPUP7TGsY3is4o5IbiNlPoTy2gSbXuJks5q9AXjgaJpZM4Kurcu
.

My bad :-) !  I am not sure that phy is handling amplitudes at the moment.
At least not in the waveform view, Cyrille, am I right ?
Le ven. 11 nov. 2016 10:01, nsteinme<EMAIL_ADDRESS>a écrit :

Sorry Pierre! I wasn't clear, I was addressing that question to Cyrille.
Because TraceView does already show the residual after subtracting the
templates, and it appears to do this [at least mostly] successfully so I
wondered whether Cyrille was already using a scaling factor. Definitely I
did not forget that Spyking Circus has always had this necessary feature :)
On Fri, Nov 11, 2016 at 6:06 AM, Pierre Yger<EMAIL_ADDRESS>wrote:

What do you mean by "do we use" ? The answer is yes. SpyKING CIRCUS can
take care of small drifts or burst by using those scaling factors, and
this
is a valuable information to see to understand what has been done by the
algorithm. In the MATLAB GUI, currently, waveforms are scaled by those
amplitudes values when compared to the template. Because for me cases
amplitudes can be pretty large, I strongly think they should be
integrated
in the TraceView or the waveform view of phy. if not taken into account
when displaying the residuals, spikes can appear to still be there while
in
fact they have been properly fitted. (We just submitted a small review
paper on biorxiv that should be online tomorrow I guess, discussing
template-matching based approaches and talk about those amplitudes. I can
send you the pdf.)
Best
Le ven. 11 nov. 2016 00:36, nsteinme<EMAIL_ADDRESS>a écrit
:

Yes same for Kilosort. Those amplitude scaling factors -
amplitudes.npy -
should in general be around 1 for Kilosort but I believe the mean of
them
for any given template is not required to be.
Do you currently use a scaling factor?
On Thu, Nov 10, 2016 at 10:23 PM, Pierre Yger <
<EMAIL_ADDRESS>wrote:

In our case, but I guess this is the same for KiloSort, because we
have
non-binary amplitudes, there is, for every waveform, a scaling factor
to
establish a proper match with the template. To be more precise, when
a
waveform is detected at time step t with an amplitude k, it means
that
the
spike in the raw data has been fitted by k.template. Most often, k is
close
to 1, but not exactly, because of drifts. So to be more precise, you
should
substract k*unwhitened template from the raw data if you want to
have a
precise view of what are the residuals considered by the algorithm in
the
TraceView. Conversly, when you are plotting groups of waveforms on
top
of
the template in the Waveform view, then all those waveforms should be
scaled by 1/k
Hope this helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259825534,
or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/
AHPUP2QIVV5JUvgBkXeTC28syBme7RCJks5q85logaJpZM4Kurcu
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259839941, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABmE_
9yXnOKyTVLyDDKcWFf8Vprflf5Kks5q86pfgaJpZM4Kurcu>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259888219, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AHPUP7TGsY3is4o5IbiNlPoTy2gSbXuJks5q9AXjgaJpZM4Kurcu
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kwikteam/phy/pull/724#issuecomment-259912181, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABmE_wGPWvuti6al8bGlhGETCRxUXW2cks5q9C7agaJpZM4Kurcu
.

I'm cleaning up the code a bit as it was developed organically, and I noticed that there is a scaling factor based on the mean waveform amplitude, the template amplitude, and other factors. I think it was mostly equivalent to the template amplitude, so I'll just use that now...

I'm not sure to understand what your scaling factor is.... This should be simpler, by just using the amplitudes plotted in the AmplitudeView


'StrictRedis' object has no object called 'geoadd'

import redis
 conn = redis.StrictRedis(host="localhost", port=6379, db=0)
conn.geoadd('location', 12.97, 77.59, 'Bangalore')
I printed the contents of StrictRedis by doing:
print dir(StrictRedis) and 'geoadd' was missing from the contents.

The most recent version of redis-py available on pip is 2.10.5, which was released on November 2, 2015. geoadd and friends weren't added until https://github.com/andymccurdy/redis-py/commit/4c331411b6f761226cdefb90250912db325d01e4 (11 months ago).
See #823.
You can either use the fork mentioned in that issue (preferred) or pip install git+https://github.com/andymccurdy/redis-py.git.

you could also give http://pyredis.readthedocs.io a try, which is a from scratch python 3 redis client implementation.

2.10.6 is on PyPI now!


Give me my Python A+

Fixed the single issue that (I think) was preventing the initial A+
Updated badges to match other cisagov projects.

This pull request fixes 1 alert when merging 55fe1cf8bf3843051a1db03862771a4bff84ade2 into 3ea292b283383c0e6f49c4f990fb91a603c323b7 - view on LGTM.com
fixed alerts:

1 for Unused import

Comment posted by LGTM.com


Settings for editor panes extending

Currently 'minimized' panes' extending goes in all directions even if some other panes are not 'minimized'

("2" in the picture should not be 'minimized' but currently are)
it verry inconvenient/bothering and should have a setting or/and be disabled by default.
Also is there a way to disable to extending at all?

@bpasero The current grid minimizes all views in order to make space for the newly maximized view. I guess the user only wants to minimize views which are in the same splitview as the newly maximized view (in the previous example that would only be the editor view on the right).

@bpasero i was meaning that it should minimize only previously maximized this way windows, but thanks to pointing me at the description issue

please reopen it .


Remove dataplane-operator references

Now that the dataplane-operator is combined and
not installed  through a separate repo.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

Note alternative review: https://github.com/openstack-k8s-operators/ci-framework/pull/1907


support disabling mmap and using regular file I/O

The file system directory implementation now invokes a
configurable function upon opening a segment.  The default
implementation creates an mmap backed segment.Data structure.
An alternative implementation, does not use mmap, and creates
a file backed segment.Data structure.
Users can choose between these functions through the config,
or they can build their own, which dynamically chooses to
mmap or not on a per segment-load basis.

This relates to https://github.com/blugelabs/bluge/issues/61


Remove reference to the deprecated SPDX + syntax

The "+" is supported but now deprecated and should be avoided.
Signed-off-by: Philippe Ombredanne<EMAIL_ADDRESS>
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

The "+" is supported but now deprecated and should be avoided.

@pombredanne Can you elaborate a bit more on this? This updates only the documentation but none of the cases that use this or the code auditing it. Ideally some documentation and pointers as to what replaces this syntax.

Can you provide a source for the deprecation? It's still listed in the SPDX license identifier guidelines without any mention of being deprecated.
Also, what's the replacement? If a formula specifies AFL-2.0+ and we aren't allowed to use that expression what would be do? While SPDX may have deprecated them, they're still present and I think we would be misrepresenting these licenses if we change this when upstream doesn't. It's our job to list what the license is not what it should be.


Removed underscore prefix for Angular 7 buildWebpackConfig

In the @angular/devkit/build-angular v7 the buildWebpackConfig method is no longer private and renamed to 'buildWebpackConfig' without the underscore prefix.

Closed the PR, after viewing your package.json I noticed you were using the angular/devkit 0.10.3 while we were running the 0.11.0 from the Angular 7 update.

I will reopen it once devkit is updated. Thanks anyways!


[Doc]: PIPELINE_PARALLEL_SIZE not found in the doc

📚 The doc issue
How to use PIPELINE_PARALLEL_SIZE?
And what's the impact for inference performance and gpu mem usage?
Suggest a potential alternative/fix
No response

Pipeline parallel is not supported right now. We will add the documents once it gets supported :)


How make ngIf globally visible in all project?

I have a code <div class="flex-container" *ngIf="mail"> Some data </div>
And i have a error Can't bind to 'ngIf' since it isn't a known property of 'div'.
How i can fix it?

Please give the solution while closing your own issue.
Other developer may get the same issue and your solution may help while googlizing.


Unrecognized list

I haven't been able to make Parameters section to work, I always get these kind of warnings and it gets ignored:

Line 22: ignoring unrecognized list, expected parameter discussion, e.g. ' ... lorem ipsum' (warning code 5)
Line 20: no parameters specified, expected a nested list of parameters, one parameter per list item (warning code 3)
Line 83: ignoring unrecognized list, expected enumeration of parameter values, e.g. 'Values' followed by a nested list of possbile values (warning code 5)

The above output was thrown when using an official example from apiary:
https://raw.githubusercontent.com/apiaryio/api-blueprint/master/examples/07. Parameters.md
Any idea?
PD. I'm using 1.18.0, latest (aglio-1.18/Dockerfile)

I've tried using 1.16-frozen and I get the same result

So I managed to solve it using aglio version 2.1.1 instead of 1.18.0 in the Dockerfile. Just in case someone jumps into the same problem
I'm still waiting to be able to run aglio on nodejs version 4


queue_unbind error

queue_unbind takes the following arguments, but nowait is not allowed:
def queue_bind(self, queue, exchange, routing_key='', callback=None):
self.send_method(_queue.Bind(ticket      = 0,
queue       = queue,
exchange    = exchange,
routing_key = routing_key,
nowait      = False,
arguments   = dict()), callback)
File "/opt/ZN/Packages/stormed/channel.py", line 120, in queue_unbind
arguments   = dict()), callback)
File "/opt/ZN/Packages/stormed/util.py", line 25, in init
raise AttributeError('invalid field name/s: %s' % unvalid_kargs)
AttributeError: invalid field name/s: set(['nowait'])

Hi @christiancadieux, let me check this ...


Fix the knownHostPolicy missing file error

Please merge this fix.

@ioanvranauhp can you take this one?

yes I will.


LightGBM: Launch container failed when predicting with spark 2.3 scala 2.11

Describe the bug
We trained a model with LightGBM and tried to make prediction on about 500 Million data. The prediction process always has "Launch Container failed" Error and finally it will fail:
[WARN ] dispatcher-event-loop-31 [org.apache.spark.scheduler.cluster.YarnSchedulerBackend$YarnSchedulerEndpoint:69]  Requesting driver to remove executor 23 for reason Container from a bad node: container_e446_1593685215274_1605926_05_210384 on host: n196-083-020.byted.org. Exit status: 134. Diagnostics: Exit Code: 134
Exception from container-launch.
Container id: container_e446_1593685215274_1605926_05_210384
Exit code: 134
Stack trace: org.apache.hadoop.yarn.server.nodemanager.containermanager.runtime.ContainerExecutionException: Launch container failed:
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(DockerLinuxContainerRuntime.java:635)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DelegatingLinuxContainerRuntime.launchContainer(DelegatingLinuxContainerRuntime.java:91)
	at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:474)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:459)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:96)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:748)

When we looked into the executors, we got core dump messages like:

To Reproduce
spark settings:
spark.driver.cores=12
driver-memory=24G
executor-cores=4
executor-memory=32G
spark.dynamicAllocation.maxExecutors=1000

Spark Version 2.3 & 3.0
Scala Version 2.11 & 2.12

We have tried on spark 2.3, scala 2.11 and  spark 3.0, scala 2.12. Make prediction and then write the result to parquet can always reproduce this problem.
We also found that if we just print the result instead of writing it to parquet, the job could success. It seems that an executor can't do more tasks after it finished one. (not sure about that, just suspect)
please take a look at that
Thanks!

@ZixinChen0520 any way to reproduce this failure?  I'm not sure I can reproduce it from the given description, sorry.  I haven't seen this error before, but it looks like it is failing in the native code somewhere.


Same notification is being repeated for the same mention in post body

Expected behavior
There should be only one notification, as there was only one event about to be notificated
Actual behavior
Multiple notifications being added. Like in screenshot. Maybe the same as issue #285

Browser: Firefox 58.0.2
Operating system: macOS 10.13.3 es-ES

I think this happening when user edit his comment/post.

I don't know. The last time has happened to me has been with https://busy.org/@hildemaro/10-post-en-steemit-super-utiles-e-interesantes-que-seguro-no-viste-en-spanish-nueva-serie-n1--1519878270 post, which corresponds to the post mentions on the screenshot.
Opening the See More notifications lists many many many many many times that notification. I think it was listed 64 times and then more than 10.
I don't know any way to see if that post was edited.


Add support for triggering policies via slash commands in Slack

We've seen a repeated pattern of groups wanting to manually trigger votes in Slack. So far we have implemented this via Trigger Policies with action type slackpostmessage and filter step action.text.startswith("some-trigger-prefix"). A better way to implement this would be via slash commands, which are supported in Slack and Discord. This definitely requires work in Gateway, and still needs to be scoped out and defined.

The Discord integration supports a generic slash command like /policykit command: "hello world" where the user can pass any string and it creates a DiscordSlashCommand.


Write a R program to convert octal to binary

Description
Write a R program to convert octal to binary
Octal is a base-8 number system. It uses only eight digits: 0, 1, 2, 3, 4, 5, 6, and 7. The digits are called octits. An octit is the smallest unit of information in a computer. An octit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, or 7, or it can be used to represent a single state, such as on or off.
Binary is a base-2 number system. It uses only two digits: 0 and 1. The digits are called bits. A bit is the smallest unit of information in a computer. A bit can be either 0 or 1. A bit can be used to represent a single value, such as 0 or 1, or it can be used to represent a single state, such as on or off.
To convert an octal number to binary, we can use the following algorithm:

Convert the octal number to decimal.
Convert the decimal number to binary.

Input  : 12
Output : 1010

How to contribute

Save the solution in program/convert_octal_to_binary.r file
Add convert_octal_to_binary.r file in convert-octal-to-binary folder

!assign


How to add labels to query metrics?

Is it possible to add labels to query metrics? I only noticed that function in MySQL exported
https://github.com/braedon/prometheus-mysql-exporter/blob/master/exporter.cfg
"QueryValueColumns = ni,ptang"
thank you.

Hi @alexadmin I'll invite you to explain your use case a bit further, in particular where to obtain these labels from...?
@braedon will correct if I'm wrong, but I think the "hits" metric is taken from the results of ES, which is basically a count(*) aggregation on all results which will therefore be absent of any field, by definition - if your intention was to use those as labels, as your reference to mysql's exporter' QueryValueColumns seems to suggest.
I do have a use case for labels, and they could even be static: we run the same query for multiple namespaces and, in order to distinguish between them, we have to use 'agg' (aggregation) which will then produce a metric "by_namespace". The problems with this approach are 1) that we have these multiple queries all running the same query, multiple times and 2) there is an inevitable overlapping with the "hits" metric, obviously.
I just had a look at the code, it's fairly simple to add static labels... @braedon would you be willing to merge a PR for this?


Dropdown does not auto-close when inside react-beautiful-dnd

Bug Report
Hi there,
I'm not sure if this issue belongs here or at react-beautiful-dnd, but here we go:
I have an issue with Dropdown component not closing itself after chosing an option when put inside react-beautiful-dnd.
Steps
Create a simple Dropdown like this: <Dropdown selection options={options} />
When chosing an option from the select menu, the dropdown automatically closes itself.
But now place the Dropdown component inside a Draggable component (from the react-beautiful-dnd library), and now the Dropdown isn't closed automatically after chosing an option.
You have to click a second time (on another option, or outside the Dropdown) to close it.
Expected Result
The dropdown should close automatically when clicking an option.
Actual Result
The dropdown does not close automatically after clicking an option for the first time.
Version
0.88.2
Testcase
https://codesandbox.io/s/semantic-ui-react-l813n

Hey @doguh
Just add closeOnChange={true} to you Dropdown.
<Dropdown selection options={options} closeOnChange={true} />

Hi @saaucorp , thank you for your answer, but closeOnChange={true} does not resolve the problem.
I've added it to the codesandbox above and the Dropdown still doesn't close until a second click.
Also I believe the default value for closeOnChange is true?
I found that if I add search prop to the Dropdown, it will now work as expected because react-beautiful-dnd disable drag and drop on interactive elements. Maybe this has something to do with react-beautiful-dnd default preventing some events?

@doguh it's extremely hard to find a root reason there, I suggest to open an issue in React DnD repo to find a proper workaround.
What happens? On item click Dropdown closes and then it gets focus back and opens again 😨
https://github.com/Semantic-Org/Semantic-UI-React/blob/40903c29a0592a6cb7060e68a107eeb1446ae84b/src/modules/Dropdown/Dropdown.js#L149-L156
The focus management is definitely done on React DnD side. To workaround it temporary you can use the openOnFocus=false: https://codesandbox.io/s/semantic-ui-react-forked-z22g7?file=/index.js. With it works perfectly.
If this is an issue on our side it will be great to get a repro without third party libraries, in this case it will be definitely easier to find it and fix.
Going to close the issue for now for housekeeping. Sorry for the delay in a reply.


Change instructions to not use forks

Here's a draft of how the instructions could be changed, since it seems that using forks is not a good idea.
BTW, I set up some branch protection rules for the main branch of this repository. They should prevent anyone from committing directly to main without making a PR. PRs also require approval from a "code owner." The intention is to add some extra safeguards so nobody accidentally modifies skelBML while working on their own private repository. I think the rules don't apply to me though! 😂

it seems that using forks is not a good idea.

It's still not a bad idea for users who don't care about keeping their libraries private.

it seems that using forks is not a good idea.

It's still not a bad idea for users who don't care about keeping their libraries private.

Fair point. However, I would prefer to just provide one set of instructions that will work for everyone, regardless of whether they want a private or public repository. The experts will probably know that they could use a fork. But, seeing a bunch of options might be confusing to some people who might not really understand all the git-related terminology.


Cannot generate terraform when NSG have Rules

Hi,
I have 3 NSG.. Validation was FINE on okit console, had to look in LOGS to find the issue -- strange because validation succeeded when I hit the option.
I had to end up removing all the security rules for my NSG. I tried one at a time, keeping rules and then deleting. Eventually all 3 had everything deleted, and it worked.
First one failed, deleted all rules eventually, then it passed, repeat for 2 and 3.
This is the log
INFO: Processing Network Security Group Information Dbnsg
ERROR: 'description'
Traceback (most recent call last):
File "/github/oci-designer-toolkit/okitweb/okitWebDesigner.py", line 504, in generate
generator.generate()
File "/okit/visualiser/generators/okitGenerator.py", line 171, in generate
self.renderNetworkSecurityGroup(network_security_group)
File "/okit/visualiser/generators/okitGenerator.py", line 1402, in renderNetworkSecurityGroup
jinja2_security_rule["description"] = self.generateJinja2Variable('security_rule_{0:02d}_description'.format(rule_number), rule["description"], standardisedName)

@LotToLearn I can not reproduce this but it looks like your json is missing the description element for the rules which is rather odd. Can you check the original json in the json view to see if description is there.


feat: expanded vpx structure

WIP

We probably want the json field names to match the ini file?
eg
[DefaultProps\Light]
Falloff =
FalloffPower =
LightState =
TimerEnabled =
TimerInterval =
Color =
ColorFull =
...

We probably want strings for types instead of numeric values
eg for reflectionmode "dynamic" instead of 5 or at least support both

We probably want to store all editor_layer_visibility and similar values in a separate file to avoid touching all items when the user shows or hides layers.

What about storing gameitems in a folder per type, currently github won't show all gameitems as thee are too many files in the folder.

Can we de-duplicate the obj files by having them all point to the same file?

This is pretty much ready for a release. Further optimizations can be added later


OCPBUGS-5069: Stabilize UDP LB testcases

Include logic to wait until the members going to the expected status before checking the connectivity and the LbMethod applied.

Adapt LbMethod on testcase where the ETP:Local is not configured (Further info on https://issues.redhat.com/browse/OCPBUGS-2350)

/retest

/retest

I rebased the thing, let's see.

/cherry-pick release-4.12

/bugzilla refresh

/jira refresh


update

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I signed the CLA.
[ ] All existing and new tests are passing.
[ ] The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

update


Text yield should strip HTML automatically

We may need to pay a close attention to this commit which should resolve it because I'm not sure that's the best way. commit sha : 3a2f42cc51e6d691fd9e660bd0c00d5d2369d4c7


Incompatible With Optifine 1.12

I have an issue with "OptiFine 1.12 HD U C2" where the text/buttons and gui aren't showing
Regular:

Optifine:

Could you post your json file / resources? Can't reproduce this with the default menu. Also is the third screenshot a custom gui by you or a vanilla gui?

Yes the third screenshot is the vanilla gui. Here is my resources and config
CMM.zip

If the third screenshot is a vanilla gui and it's still not working maybe the issue is between optifine and vanilla? Do Vanilla GUIs work if CMM isn't installed?

No, it's Emojiful.


Redo the mapper source code generation

This is bullshit, very fast but very inconvenient

Look something like razor but for c# code, i want it to be as similar as possible to regular code, but with the ability to use loops and branching to generate method lists

upd: it's not even fast


pull request for e2e test at 12/05/2016 03:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


TextBox selection between words

Right now when double clicking then dragging, selection will completely ignore spaces (and only include them in selection when selecting the next word in the direction of the drag).
Instead, all non-words (special characters/symbols/spaces) should be individually added to the selection.
selectable ranges currently:
this is a sentence
corrected:
this   is   a   sentence

Just to clarify what should happen when there are no simple separators (e.g. a URL):
https``://``github``.``com``/``ppy


Use schema-repo instead of built in Avro / schema repo implementation

Instead of using our own patched Avro and custom schema repository implementation we can use https://github.com/schema-repo/schema-repo.

Commit 666680f6dffd61a2c1384591677beb4f42fd06ac starts this work.

In master now, need to figure out why we have to pull in jersey-servlet and jersey-core.


enhancement: Provide some kind of event loop ticker to properly run animations

Make animations run based on ticker provided by the event loop, this way the animations run on sync with the renderer FPS

I think something like https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame would be perfect here. I had some success using https://docs.rs/tokio/latest/tokio/sync/struct.Notify.html to send new frames when they're available. That way animations can use async and request new frames when needed

I think something like https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame would be perfect here.

Yeah! I just noticed I already have an issue opened https://github.com/marc2332/freya/issues/159 😂

I had some success using https://docs.rs/tokio/latest/tokio/sync/struct.Notify.html to send new frames when they're available. That way animations can use async and request new frames when needed

Nice, I'll note that!