[SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

What changes were proposed in this pull request?
With suggestion from @cloud-fan https://github.com/apache/spark/pull/28222#issuecomment-620586933
I Checked with both Presto and PostgresSQL, one is implemented intervals with ANSI style year-month/day-time, and the other is mixed and Non-ANSI. They both add the exceeded days in interval time part to the total days of the operation which extracts day from interval values.

presto> SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:00' as timestamp)));
_col0
-------
14
(1 row)

Query 20200428_135239_00000_ahn7x, FINISHED, 1 node
Splits: 17 total, 17 done (100.00%)
0:01 [0 rows, 0B] [0 rows/s, 0B/s]

presto> SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:01' as timestamp)));
_col0
-------
13
(1 row)

Query 20200428_135246_00001_ahn7x, FINISHED, 1 node
Splits: 17 total, 17 done (100.00%)
0:00 [0 rows, 0B] [0 rows/s, 0B/s]

presto>

postgres=# SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:00' as timestamp)));
date_part
-----------
14
(1 row)

postgres=# SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:01' as timestamp)));
date_part
-----------
13

spark-sql> SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:01' as timestamp)));
0
spark-sql> SELECT EXTRACT(DAY FROM (cast('2020-01-15 00:00:00' as timestamp) - cast('2020-01-01 00:00:00' as timestamp)));
0

In ANSI standard, the day is exact 24 hours, so we don't need to worry about the conceptual day for interval extraction. The meaning of the conceptual day only takes effect when we add it to a zoned timestamp value.
Why are the changes needed?
Both satisfy the ANSI standard and common use cases in modern SQL platforms
Does this PR introduce any user-facing change?

No, it new in 3.0
How was this patch tested?

add more uts

Test build #122002 has started for PR 28396 at commit 34735f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26675/
Test PASSed.

Test build #122002 has finished for PR 28396 at commit 34735f2.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122002/
Test FAILed.

retest this please

Test build #122022 has started for PR 28396 at commit 34735f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26695/
Test PASSed.

Test build #122022 has finished for PR 28396 at commit 34735f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122022/
Test PASSed.

thanks, merging to master/3.0!


Enhancement Request - Increase Size of EndtoEndIdTxt Variable and Add Event for Report SEPA ISO20022

Describe the request
Report ID: 10883
Report Name: SEPA ISO20022
At the local procedure ExportPaymentInformation() for the SEPA ISO20022 report, there is a need to enhance the functionality by increasing the size of the EndtoEndIdTxt variable from Text[30] to Text[35]. Additionally, an event named OnBeforeAddEndtoEndIdToXmlAsElement needs to be introduced after the initialization of the EndtoEndIdTxt variable and before the execution of the AddElement function. This event is essential for allowing users to modify the value of the EndtoEndIdTxt variable based on certain conditions.
Details:
// Inside the local procedure "Export Payment Information"

// Existing code
EndtoEndIdTxt := PaymentLine."Document No.";
if DelChr(EndtoEndIdTxt, '<>') = '' then
    EndtoEndIdTxt := 'NOTPROVIDED';

// New requirement
OnBeforeAddEndtoEndIdToXmlAsElement(EndtoEndIdTxt, PaymentLine);

AddElement(XMLNodeCurr, 'EndToEndId', CopyStr(EndtoEndIdTxt, 1, 35), '', XMLNewChild);

// New event definition
[IntegrationEvent(false, false)]
local procedure OnBeforeAddEndtoEndIdToXmlAsElement(var EndtoEndIdTxt: Text[35]; var PaymentLine: Record "Payment Line")
begin
    // User-defined logic goes here
end;

Additional context
Additional Information:

The EndtoEndIdTxt variable should be expanded from Text[30] to Text[35].
The OnBeforeAddEndtoEndIdToXmlAsElement event should be triggered after the initialization of EndtoEndIdTxt and before the AddElement function.
Users need the ability to customize the value of EndtoEndIdTxt based on specific conditions within the event.

This enhancement will provide greater flexibility for users to customize the behavior of the SEPA ISO20022 export process.
Dispose d???un menu contextuel
Internal work item: AB#501828

Availability update: We will publish a fix for this issue in the next update for release 24.
Build ID to track: 18665.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18666.


Fixed typo in german docs

Hi @kersten , welcome to k8s docs. Thanks for finding and fixing this typo :tada:
/lgtm
/approve


Add loc to text, comment, and attribute nodes.

@fivetanley + @rwjblue - Pairing === Love.

Since this is mostly additive, I'm going to land (and add to htmlbars).  I'm happy to iterate on anything that y'all find/want to change.


Release <IP_ADDRESS>

OpenSearch 1.3.3 has been released, see release notes.
Official OpenSearch release ticket: https://github.com/opensearch-project/opensearch-build/issues/2101
Checklist:

[x] Compatibility Matrix is updated
[x] Release <IP_ADDRESS> tag is present in the repo
[x] Release artifacts are available and downloadable
[x] Release notes published
[x] Forum announcement published

Done.


Fix safe navigation method call causing "syntax error" if used as statement

This now causes some wonky behaviour:
local t = {}
print(t:bla?()) -- nil     table: 0000016C422C2D20

May be worthwhile to consider adjusting this syntax error, since the code generation is working fine, it's just that it cries because Lua doesn't like certain expressions being statements.


categories show up in wrong orientation

holding ipad landscape, tap explore, tap categories get-->

I've struggled to replicate this in the sim, moving to device.

Could be related: https://github.com/artsy/eigen/issues/448

Im looking at it
On Tue, Jul 21, 2015 at 13:53, artsy/eigen
<EMAIL_ADDRESS>wrote:
Could be related: #448 [https://github.com/artsy/eigen/issues/448]
—
Reply to this email directly or view it on GitHub
[https://github.com/artsy/eigen/issues/650#issuecomment-123414932] .[https://github.com/notifications/beacon/ADBlTjMXFIB9w9wzht0Dk2cr4rNcm2kWks5ofn6LgaJpZM4FYRt-.gif]

Repro'd on my beta on an iPad iOS 8.4.
Go into categories, tap through to anything, rotate, go back.

Closed by #694


Update to opening paragraph (INTAKE-4927)

Updates the intro paragraph (and adds a second intro paragraph) per this document:
Find a housing counselor - final.docx
Checklist

[ ] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Future todos are captured in comments and/or tickets
[ ] Project documentation has been updated, potentially one or more of:

This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
CFGOV/platform wiki on GHE – for internal CFPB developer guidance
CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing
Visually tested in the following supported browsers:

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Edge 18 (the last Edge prior to it switching to Chromium)
[ ] Internet Explorer 11 and 8 (via emulation in 11's dev tools)
[ ] Safari on iOS
[ ] Chrome on Android

Accessibility

[ ] Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
[ ] Screen reader friendly
[ ] Does not introduce new errors or warnings in WAVE

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Does not introduce new lint warnings
[ ] Flexible from small to large screens

Intake ticket, for reference: https://jira.cfpb.gov/browse/INTAKE-4927

I'm not authorized to merge this PR; @niqjohnson would you be able to merge and deploy this today?

@csebianlander, this is merged and will go out with the next deployment.


Fix Trustwave Parser API: properly checking for null data fields

Fix Trustwave Fusion API parser fails to detect null fields.
@valentijnscholten

@damiencarol Could you look into this pr please? Thanks!


Set User Handle to a salted hash or random

The current User Handle (a.k.a user ID) is a hash of the user name.
https://github.com/line/line-fido2-server/blob/22d5aa954efe4e1a383c9eea3b2dc109e700f973/rpserver/src/main/java/com/linecorp/line/auth/fido/fido2/rpserver/controller/CredentialController.java#L147
The documentation appears to recommend it with salted hash or random, so should we change that?

This includes hash values of personally identifying information, unless the hash function is salted with salt values private to the Relying Party, since hashing does not prevent probing for guessable input values. It is RECOMMENDED to let the user handle be 64 random bytes, and store this value in the user’s account.

https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#sctn-user-handle-privacy

Yes, you are right.
Thank you for your opinion.
I think it would be better to provide a random value:slightly_smiling_face:

Yes, you are right. Thank you for your opinion.
~I think it would be better to provide a random value🙂~

I realized that there might be a lot of parts that need to be fixed to provide random values.
I think we might have to find another way.


PI can see link but can edit

The PI of a funding source does not see a link on the funding source list, but can visit the funding source update URI, for example: en-gb/funding/1/update/
Logic for validation on the update URI and displaying the link should ideally be the same (potentially using the same code?).

For completeness, the owner of the project can edit as well (if they happen to be different). Haven't tested for any other types of user.

I don't see this? Going to /update redirects to /detail, unless the user has the funding.approve_funding_sources permission.

I think I can guess what's going on here, I had permission that approving users have. And because the logic related to her workflow is funny (i.e. relies on multiple redirects) that's not reflected in the links..


Question about the inception_resnet_v1 implementation

At the end of the function inception_resnet_v1(...) in inception_resnet_v1.py after adding 5 x Inception-Resnet-C it calls the function block8() again and assigned the result to end_points['Mixed_8b']:
net = slim.repeat(net, 5, block8, scale=0.20) # 5 x Inception-Resnet-C
 end_points['Mixed_8a'] = net

 net = block8(net, activation_fn=None) # what is this?
 end_points['Mixed_8b'] = net

In the paper, C Szegedy - 2016 - Inception-v4, Inception-ResNet and the Impact of Residual Connections on Learning
there is only an Average Pooling after 5 x Inception-Resnet-C.
Also at the end of the whole function, after dropout:
net = slim.fully_connected(net, bottleneck_layer_size, activation_fn=None, scope='Bottleneck', reuse=False)
Why do we need that full connected bottleneck, I also cannot find it in paper.
Could someone please give me some hints? Thanks.

@Ao-Lee you are right.
@helloyide for the first question, there is indeed an error, the additional block8 should not be there at least according to the original paper that has only 5x "block8" (inception-resnet-C)
I don't think it will make a huge difference in the results though.


getting Error: Maximum call stack size exceeded after ng serve

Command
serve
Is this a regression?

No response

Angular version 11 is no longer supported. Please update to a more recent version. If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.
See https://angular.io/guide/releases#support-policy-and-schedule for more information about our support policy.


feat!: Custom patterns for parsing logged metadata in ASC files

Description
Fixes #758
Implemented changes

[x] BREAKING: Return metadata dictionary from from_asc()
[x] Add argument matadata_patterns to from_asc() and parse_eyelink()
[x] Default value of None for metadata keys specified in metadata_patterns that are not present in the ASC file

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change is or requires a documentation update

How Has This Been Tested?

[x] Metadata returned
[x] Test default None values

Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

NOTE: #510 says:

Don't care about integrating this into the 'gaze.from_asc()` function yet.

So not sure if this breaking interface change in from_asc() is acceptable, but I think it would be useful...

I think this is a great addition and the benefits outweigh the breaking change.

@prassepaul @dkrako I'd liked to have a second pair of eyes on this breaking change


[proposal] Provide an evolvable End to End Solution for Koordinator Device Management

What is your proposal:
Provide an evolvable End to End Solution for Koordinator Device Management
Why is this needed:
Koordinator already supports two functions in the scheduler: GPU shared scheduling and GPU & RDMA joint allocation. It supports users to apply for GPU or RDMA resources using kubrenetes extended resources and Hints defined on Pod Annotation. The extended resource method was originally introduced into Kubernetes mainly to describe discrete and countable node resources. The Kubelet Device Plugin interface is the main way for the Kubernetes community to support such resource reporting and allocation.
However, the allocation logic of Kubelet Device Manager does not support the refined joint allocation of multiple resources according to the device topology, such as the scenario where GPU and RDMA need to be allocated under a PCIESwitch. The only topology allocation supported by Kubelet is allocation according to NUMA. However, even in the scenario where only NUMA allocation is required, Kubelet intervenes in NUMA access a little late. Users will have to face the failure of a successfully scheduled Pod to start due to topology mismatch.
To solve this problem, Koordinator moved the device allocation logic from Kubelet to the scheduler, and used cri-runtime-proxy on the stand-alone side to set up device isolation and visibility. However, the cri-runtime-proxy approach is indeed heavy and inconvenient to install. In addition, although the Koordinator scheduler provides the GPU and RDMA joint allocation function, there is no end-to-end solution available overall, especially on the stand-alone side, it has not yet been connected to the community standard RDMA logic. This proposal attempts to solve the above problems for Koordinator and provide an end-to-end feasible solution.
Finally, in the field of device management, the community proposed Dynamic Resource Allocation after the Device Plugin interface to overcome the various limitations of the current Device Plugin solution. This proposal will also show how Koordintor's GPU sharing and GPU & RDMA joint allocation are implemented under the DRA mode, and how the current solution evolves to DRA.
Key Results:

[ ] Provide a convenient End to End Solution for Koordinator Device Magement, especially solution as a replcament for runtime-proxy. This will be checked on the GPU Share use case.
[ ] Collabrate with Device Sharing and Isolation Solution Providers, such as HAMI, cGPU, MIG and vGPU, to enhance Koordinator GPU Share Solutions. This will be checked on the GPU Share use case with strict gpu usage limit.
[ ] Collabrate with rdma and SRIOV solution Providers, such as sriov-device-plugin, multus, to provide an end to end solution for GPU & RDMA joint allocation.
[ ] Provide a End to End Solution with DRA structured parameters on k8s version 1.31. This will be checked on the GPU Share use case and GDR use case.

/area koord-scheduler

ref #2187

ref #2171

ref #583 GPU 共享隔离方案

/area koordlet /area koord-manager

I am the maintainer of HAMi and I look forward to in-depth cooperation with koordinator in the area of device management.

I am the maintainer of HAMi and I look forward to in-depth cooperation with koordinator in the area of device management.

Hello, I‘m the issue planner, nice to meet you in github! I have some questions abount HAMI:

Through which component does HAMI expose GPU utilization metrics?
Do GPUs from different manufacturers use the same DP?
How does HAMI core participate in GPU isolation?
Is HAMI core a library or environment variable? Is it done through the DP standard interface or through a customized Container Runtime?


add dep for managing dependencies

Added https://github.com/golang/dep to manage dependencies, which will help ensure reproducible builds.
Added a Makefile with steps to build the project:
make deps
make build

oh nice, TIL that you can version control your dependencies :)


404 Not Found [IP: 185...]

Hello,
When run the main or the dev branches with docker it can not find the related IP adress in [12/45]

+1

We had a recent change of dependencies, you might want to try adding a --no-cache flag at the end of the docker build command in run-docker.sh and rerun to make sure your container is not building from cache. Like it is done in this (reversed) commit: https://github.com/Xilinx/finn/commit/20e2bbd4bbde6ef78524e05d5fb463a31cba7852

@auphelia Thanks for your comment. I have tried the solution and still encountered the same problem.

Thank you @auphelia It is working after the building without the cache.


create ZK data dirs first

we do similar today for kafka-broker role already.

@soenkeliebau can you make sure this PR is approved? thanks!

I think someone with write access needs to approve. I already gave my approval.

Alright thanks. I guess the approval has to come from someone who has
commit access to the repo :)
On Wed, May 8, 2019 at 4:40 PM Sönke Liebau<EMAIL_ADDRESS>wrote:

I think someone with write access needs to approve. I already gave my
approval.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/confluentinc/cp-ansible/pull/86#issuecomment-490642663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHGTLIVZFCGFFK2ACVWF7DPUM3EJANCNFSM4GXPKUBQ
.

--
Kaufman Ng
+1<PHONE_NUMBER>
Solutions Architect | Confluent | www.confluent.io

This shouldn't be nesecary as it's group writeable. When i run this, my zk runs as cp-kafka, where as the directory is owned by zookeeper zookeeper. when i ran the playbook again, the ownership changed to cp-kafka:confluent which also works... so check that.

@coughman please see @astubbs response.  If you still feel there is an issue here, please rebase this to 5.3.0-post and we can review further.

According to @astubbs 's comments above, seems like the first time it will fail (because ZK running as cp-kafka will not be able access ZK data dir owned by zookeeper, but the 2nd time you run the playbook it will succeed?

doesn't look like it's an issue anymore. Closing...


Using removed Babel 5 option

After cloning the repo, "npm install" and "npm run dev" I get the following error:
ERROR in ./demo/app.jsx Module build failed: ReferenceError: [BABEL] /Users/x/Websites/component-playground/demo/app.jsx: Using removed Babel 5 option: base.stage - Check out the corresponding stage-x presets http://babeljs.io/docs/plugins/#presets     at Logger.error (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/file/logger.js:39:11)     at OptionManager.mergeOptions (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:20)     at OptionManager.init (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:465:10)     at File.initOptions (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/file/index.js:194:75)     at new File (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/file/index.js:123:22)     at Pipeline.transform (/Users/x/Websites/component-playground/node_modules/babel-core/lib/transformation/pipeline.js:45:16)     at transpile (/Users/x/Websites/component-playground/node_modules/babel-loader/index.js:14:22)     at Object.module.exports (/Users/x/Websites/component-playground/node_modules/babel-loader/index.js:88:12)  @ multi app
Is this a known issue?

Fixing the webpack config as described in #55 worked. Thanks a lot!
Unfortunately page is loading with errors. Console in Chrome:
Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of Index.warning @ main.js:2258 main.js:1181 Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of Index.

Should be all set


Add PR labeler and update templates

Description

Task, update templates and add PR labeler configuration and workflow.

LGTM! See comment on labeler. Also are you missing ISSUE_TEMPLATE for feature_request too - https://github.com/napari/napari/blob/master/.github/ISSUE_TEMPLATE/feature_request.md should be feature

Fixed.

Note that now we could use these labels in our release notes more easily too!!


Capabilities DB Configuration Tool:  Will not allow associating multiple ODM databases with one region

horsburgh[CodePlex] When I try to add a new database to an existing region in the HydroServer Capabilities Database using the Capabilities Database Configuration tool it will not write the new association to the Capabilities Database.

horsburgh[CodePlex] Couldn't reproduce this error as reported. We are marking the status as fixed.


Add setup-devstack-swift option to README

Available here:
https://github.com/canonical/operator-workflows/blob/main/.github/workflows/integration_test.yaml#L24

We'll probably want to add this parameter to the test_and_publish_charm workflow too


canvas for facebook messenger

what about for facebook messenger, is it not applicable on facebook messenger app build using dialogflow ?

This sample only supports Interactive Canvas for Actions on Google.


docs: rollover

cc @avkonst
https://overnode.org/docs/rollover-upgrade
Is there a possible delay (healthy for at least 2 hours)?
Is there a way to interrupt it, say if the health check does not exist, or did not capture an error, but the admin sees it clearly (preventing seeing your infra fall apart, without having a way in preventing it).
Docs: What happens if the rollover fails? Does it just stop, leaving say one instance in an upgraded unhealthy state?
Some images, such as Samba have health checks built in. Can you override (disable) them? I'm also assuming that by default, they do get accounted for.
If the rollover --delay is 7200 (2 hours), then it's probably best to exit with 0 before the rollover is completed. Though with usage in scripts, a possibility to wait for the completion should be there (cron: attempt a rollover, if exit 1, webhook the admin).
And if the command exits with 0 before completion, something like rollover status would be very nice. The status could be monitored by the forementioned script, removing the need for a 'wait for completion' and also provides some overview for the admin who was notified via the webhook.

Is there a possible delay (healthy for at least 2 hours)?

Your health check process can do it. This relies on the docker feature: https://docs.docker.com/engine/reference/builder/#healthcheck

Is there a way to interrupt it, say if the health check does not exist, or did not capture an error, but the admin sees it clearly (preventing seeing your infra fall apart, without having a way in preventing it).

Yes, just press Ctrl+C. It will interrupt the process.

What happens if the rollover fails? Does it just stop, leaving say one instance in an upgraded unhealthy state?

Yes, it stops in partially upgraded state. The expectation is that the distributed system is still functional because it is usually the first instance breaks things. It gives time to understand the cause and take the required actions. One of the default actions could be to restore a configuration to a previous version and do up again. Or can be different action depending on a fault. At least we use this procedure.
Makes sense?
PS: I will extend the documentation on these questions.

Some images, such as Samba have health checks built in. Can you override (disable) them? I'm also assuming that by default, they do get accounted for.

I think you can override them. I believe it is how the Docker / Docker Compose actually works - you can override any image setting during container launch / creation. And yes, the health checks defined in an image are taken into account.

If the rollover --delay is 7200 (2 hours), then it's probably best to exit with 0 before the rollover is completed. Though with usage in scripts, a possibility to wait for the completion should be there (cron: attempt a rollover, if exit 1, webhook the admin).
And if the command exits with 0 before completion, something like rollover status would be very nice. The status could be monitored by the forementioned script, removing the need for a 'wait for completion' and also provides some overview for the admin who was notified via the webhook.

Do you mean the case if rollover takes a lot of time? I guess you can do overnode pull to speed up the process. And after overnode up --rollover - the time will be proportional to a number of containers multiplied by health check status, which is typically should be within milliseconds or in worst case seconds. Still too long? I have not experienced much of an issue with waiting for the console output for a few minutes. But maybe larger systems might have such an issue. I guess if there is enough need for this, it can be put into a background process, which emits some status info. Makes sense?
Hope it answers your questions..

Yes, it stops in partially upgraded state. The expectation is that the distributed system is still functional because it is usually the first instance breaks things. It gives time to understand the cause and take the required actions. One of the default actions could be to restore a configuration to a previous version and do up again. Or can be different action depending on a fault. At least we use this procedure.
Makes sense?
https://blog.linuxserver.io/2019/10/01/updating-and-backing-up-docker-containers-with-version-control/
almost, well yes.. I think it would be very nice if ^ was built-in. 'rollback'

also, can you nuke the affected containers and keep the system overall running?

the last one about 'speeding up'

The point wasn't getting it faster, on an occasion that I have a health check, that is sleep 7200, intentionally slowing it down (to see if anything is wrong on the user side). When I actually get to using it myself, I'll check back if needed.

almost, well yes.. I think it would be very nice if ^ was built-in. 'rollback'

I guess this needs to be separated into it's own ticket. Most frequently asked feature I think. But not easy to do. Maybe version 2 of the tool could do it, once the feedback for this like this is accumulated.

also, can you nuke the affected containers and keep the system overall running?

not sure... need more details on what the "overall system" is.... and how to identify the "affected containers"...

Talking of version 2 (ffs github there is never a place to talk about the project in general), how are you with languages? Most of my things have been in bash and in those cases I have felt it restricting. I was quite surprised that this thing is all shell, knowing it, my first reaction was 'no way it is all in shell'. I'm probably starting to move on to the go train myself, what about you?

also, can you nuke the affected containers and keep the system overall running?

not sure... need more details on what the "overall system" is.... and how to identify the "affected containers"...

well I meant a workflow of:
while we have a new version available; do
we have 4 nodes
starting rollover on the first node
oh no it is bad, abort
ok, now with 3 nodes, 1 node offline (or are we with 4 nodes and when an user hits node 1 they are reaching the unhealthy instance? placing a node offline is what I mean by nuking)
let's rollback (maybe even automatically, if the rollover fails)
now with 4 nodes, 1 has been 'downgraded' (actually just 'reimaged')
let's figure out what the heck went wrong, hopefully fix it
done

OK. I see what you mean. 3 related things to consider there.

Usually exclusion of a node happens at the level of HAProxy, which automatically detects faulty backend instances and stops sending traffic there.

An upgrade can happen not node-by-node but layer-by-layer. For example:

4 nodes, a haproxy and a backend servers on each node.
sudo overnode up --rollover backend haproxy will upgrade in the following order:
node1 backend
node2 backend
node3 backend
node4 backend
node1 haproxy
node2 haproxy
node3 haproxy
node4 haproxy
So a node can be only partially broken.

It is possible that an upgrade of a container on node 1 causes a crash of another peer layer container on node 2 or a crash of an entire upper layer. It usually means there was no enough testing done before an upgrade, but I have seen it. Currently Overnode health checks all containers on a node where it performed the last action. It can be improved to do cluster wide health checking, but it will slow things down. Do you think this feature is needed? Shall it be separated to a dedicated ticket?

Usually exclusion of a node happens at the level of HAProxy, which automatically detects faulty backend instances and stops sending traffic there.

Err.. I'd strive for DNS level HA*. Client picks random one, when a node goes down, client picks an another one (you have multiple DNS entries with the target being different nodes).
You have to host HAProxy somewhere as well. What if that part fails?

node1 backend
node2 backend
node3 backend
node4 backend
node1 haproxy
node2 haproxy
node3 haproxy
node4 haproxy

Shouldn't it be done node1, node1, node2, node2? This way you don't have all nodes partially broken (if the combination/full upgrade doesn't go well).

Shouldn't it be done node1, node1, node2, node2? This way you don't have all nodes partially broken (if the combination/full upgrade doesn't go well).

If you omit service arguments for the up command, it will do as you said.

The distributed systems are updated a layer by layer, where each layer is updated node by node. This is typical architecture.

Err.. I'd strive for DNS level HA*. Client picks random one, when a node goes down, client picks an another one (you have multiple DNS entries with the target being different nodes).

Yes, you can do it. Your front facing servers are HAProxy instances with the same DNS resolved to multiple IP addresses.

You have to host HAProxy somewhere as well.

You host it in the same cluster. Checkout weavescope stack example. It does it.

What if that part fails?

That is why the update is done a layer by layer.


new books here

great works.
Do you accept new books here?

Hi @lucasnuic  sure, we do accept books, just those books need to fit into the main goal of this project.


Update to Spring Security OAuth 2.3.8

Related to https://github.com/spring-projects/spring-security-oauth2-boot/issues/147#issuecomment-551891658

Fixed via 2c3ea416f625af8a66a827d5a3b967671ca35281


on_error doesn't return enough information

I had to get inside of streaming.py and add a couple of prints to find out what was going wrong with my code. Would be better to have on_error(self, status_code, reason=None, text=None) and pass the response reason and text on to make debugging easier.

Might be quite easy to implement some sort of error_print function which takes in the error code and prints out the text and description from the twitter api errors page: https://developer.twitter.com/en/docs/basics/response-codes

It would be better to have these codes in a lookup table inside of tweepy.


feat: support Vector input for Scripts and Predicates, improve overall Vector input support

Fixes #1015
This is a total rewrite of how Vectors work, removing the previous version I implemented and packing Vector data alongside its pointer, to be dynamically appended at the last step of the Abi Coder, see concatWithVectorData.

Improves support for Vectors across the board

For context, existing support (currently available) for Vector is - Vector, Struct in Vector, Enum in Vector, Numbers/Strings in Vector
This PR adds more advanced usage, matching what is supported in the Rust SDK, such as Vector in a struct, Vector in a Vector, Vector in an array, Vector in an enum etc

Adds support for Vectors in Scripts

Vector input to Scripts was never tested or explicitly supported by TS-SDK
Luckily the change was to set correct offset instead of the default 0

Adds support for Vectors in Predicates

Vector input to Predicates was also never tested or explicitly supported by TS-SDK
Likewise we just had to set correct offset instead of the default 0
Currently this is only tested with Predicate Coins

Adds new tests to validate Sway types in Vectors across all three Program modes

these were copied from Rust SDK, see https://github.com/FuelLabs/fuels-rs/pull/718

Also see:

https://github.com/FuelLabs/fuels-ts/pull/910
https://github.com/FuelLabs/fuels-ts/pull/497

@camsjams This seems like a reasonably big PR; I'm turning off auto-merge so more than 2x people can review it before it's merged, ok?


The code color is pure white, and the configuration file association is correct

What is the expected configured file association?

Does this reproduce in the latest VS Code insiders build with all extensions disabled?


Buggy scenario

Endpoint#write *1
$4
info

Redis#write $2688
# Storage info
sophia.version = 1.2.3
sophia.build = 59ff278
sophia.error =
sophia.path = ./serenity_db
sophia.path_create = 1
memory.limit =<PHONE_NUMBER>0
memory.used = 0
compaction.node_size = 67108864
compaction.page_size = 65536
compaction.page_checksum = 1
compaction.0.mode = 3
compaction.0.compact_wm = 2
compaction.0.branch_prio = 1
compaction.0.branch_wm = 10485760
compaction.0.branch_age = 40
compaction.0.branch_age_period = 40
compaction.0.branch_age_wm = 1048576
compaction.0.backup_prio = 1
compaction.0.gc_wm = 30
compaction.0.gc_db_prio = 1
compaction.0.gc_prio = 1
compaction.0.gc_period = 60
compaction.0.async = 2
compaction.80.mode = 2
compaction.80.compact_wm = 4
compaction.80.branch_prio = 0
compaction.80.branch_wm = 0
compaction.80.branch_age = 0
compaction.80.branch_age_period = 0
compaction.80.branch_age_wm = 0
compaction.80.backup_prio = 0
compaction.80.gc_wm = 0
compaction.80.gc_db_prio = 0
compaction.80.gc_prio = 0
compaction.80.gc_period = 0
compaction.80.async = 2
scheduler.threads = 6
scheduler.zone = 0
scheduler.checkpoint_active = 0
scheduler.checkpoint_lsn = 0
scheduler.checkpoint_lsn_last = 0
scheduler.checkpoint = function
scheduler.on_recover =
scheduler.on_recover_arg =
scheduler.on_event =
scheduler.on_event_arg =
scheduler.event_on_backup = 0
scheduler.gc_active = 0
scheduler.gc = function
scheduler.reqs = 0
scheduler.run = function
scheduler.0.trace = sleep
scheduler.1.trace = sleep
scheduler.2.trace = sleep
scheduler.3.trace = sleep
scheduler.4.trace = sleep
scheduler.5.trace = sleep
metric.dsn = 1
metric.nsn = 1
metric.bsn = 0
metric.lsn = 0
metric.lfsn = 1
metric.tsn = 0
log.enable = 1
log.path = ./serenity_db/log
log.sync = 0
log.rotate_wm = 500000
log.rotate_sync = 1
log.rotate = function
log.gc = function
log.files = 1
log.two_phase_recover = 0
log.commit_lsn = 0
backup.path =
backup.run = function
backup.active = 0
backup.last = 0
backup.last_complete = 0
db.db_0.name = db_0
db.db_0.id = 1
db.db_0.status = online
db.db_0.format = kv
db.db_0.path = ./serenity_db/db_0
db.db_0.sync = 1
db.db_0.mmap = 1
db.db_0.compression_key = 0
db.db_0.compression = none
db.db_0.branch = function
db.db_0.compact = function
db.db_0.deadlock = function
db.db_0.index.memory_used = 0
db.db_0.index.node_count = 1
db.db_0.index.node_size = 232
db.db_0.index.node_origin_size = 232
db.db_0.index.count = 0
db.db_0.index.count_dup = 0
db.db_0.index.read_disk = 0
db.db_0.index.read_cache = 0
db.db_0.index.branch_count = 1
db.db_0.index.branch_avg = 1
db.db_0.index.branch_max = 1
db.db_0.index.branch_histogram = [1]:1
db.db_0.index.page_count = 1
db.db_0.index.update =
db.db_0.index.update_arg =
db.db_0.index.key = string

Endpoint#write *2
$6
select
$1
0

Redis#write +OK

Endpoint#write *2
$6
select
$1
0

Redis#write +OK

Endpoint#write *2
$6
select
$1
0

Redis#write +OK

Endpoint#write *3
$6
config
$3
get
$8
database

Redis#write -ERROR bad request

Endpoint#write *2
$6
select
$1
0

Redis#write -ERROR bad request

Endpoint#write *2
$6
select
$1
0

Redis#write -ERROR bad request

after some actions, the server always answer with "ERROR bad request", it may be in an inconsistent state

i'll fix this as soon as i peek some time :) thanks


Update snagit to 2018.0.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

2018 is correct.
ls -1 /Volumes/Snagit
Applications -> /Applications
Snagit 2018.app

@commitay
Snagit 2018 is the app (display) name, like Office 2016.
2018.0.1 is the CFBundleShortVersionString defined in Info.plist

2018 is only used in the app stanza
https://github.com/caskroom/homebrew-cask/blob/8649dc5d5998d8bc04415671badf524d38388f48/Casks/snagit.rb#L1-L10

Oh, I see..

Then this cask will not need to update anymore unless the developer released a different name like "Snagit 2019"?

Maybe it should be:
version '2018.x.x'
sha256 '............'

url 'https://download.techsmith.com/snagitmac/enu/Snagit.dmg'
app "Snagit 2018.app"

Then this cask will not need to update anymore unless the developer released a different name like "Snagit 2019"?

Correct.


make pligos a helm plugin

Following the decision of Making Pligos a Helm Plugin, we need to just do it.
Support documentation of the design draft can be found in here.
https://github.com/real-digital/pligos/wiki/Design-Draft:-Pligos-as-a-helm-plugin

PR #22 closes this issue


Fix incomplete circuit draw on combinational analysis

Fixes #1651
Describe the changes you have made in this PR -
combinationalAnalysis.js: Added a patch to handle cases where output is independent of input(all DONT CAREs).
Added comments describing the working of the draw function.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Sorry this is not mergeable. Didn't consider refactored code.

Coverage increased (+0.07%) to 84.444% when pulling 0e5c38492c49ac9712ec6d540291149b7465e34d on gr455:combinationalAnalysisFixNew into f90d68617bac5f6b68f72674bfea1d8255607e87 on CircuitVerse:new_UI.

@gr455 make WIP PRs as Draft PRs

Reopening to recheck circleci

@gr455 what is the actual input that your fix is helping for?
It did not pass for this one

@gr455 what is the actual input that your fix is helping for?
It did not pass for this one

Ohh, I will look into this. I guess all 0s / all DONT CAREs are not working. It does fix the inputs in the issue though

Solved by #1703


Bump elliott

git log --oneline 1223f58522c0ad4e5e640c5df202906d06070400..daf8a6e79004ff385905a6f92dd45ca011640768
daf8a6e (HEAD -> master, origin/master, origin/HEAD) resolution obj can't compare with str
158c73b Revert "exclude placeholder bug in bug sweep and fix RHSA check (#395)" (#405)
804ab1b update blocker filter list (#404)
59b190b exclude placeholder bug in bug sweep and fix RHSA check (#395)
6f0d703 Commands can recognize different bugids (#402)
b9e2928 Add tests for verify-bugs (#401)
484a4b4 Make use_jira default true (#393)

/lgtm


Background effects do not work in Safari

The package does run flawlessly after some work in Chrome, but in Safari as soon as I activate the filters the video gets black and the browser slow. Any ideas on why? Is it a bug or just not possible in Safari at the time

Thank you for the hint, I'll then add an feature support check and do not show the feature when it's not supported.


Update dependencies

Still not working. Building network I get:
src/Ouroboros/Consensus/Shelley/Node.hs:100:34: error:
    • Couldn't match expected type ‘cardano-ledger-<IP_ADDRESS>:Cardano.Chain.Common.Address.Address’
                  with actual type ‘SL.KeyHash discriminator0 crypto0’
    • In the pattern: SL.KeyHash h
      In the pattern: SL.AddrBootstrap (SL.KeyHash h)
      In a case alternative:
          SL.AddrBootstrap (SL.KeyHash h) -> pseudoTxIn h
    |
100 |       SL.AddrBootstrap          (SL.KeyHash    h)        -> pseudoTxIn h

Would also want  https://github.com/input-output-hk/cardano-ledger-specs/pull/1477 and https://github.com/input-output-hk/cardano-ledger-specs/pull/1476

I'll update the code (and bump to the latest of cardano-ledger-specs)

I bumped the dependency to include https://github.com/input-output-hk/cardano-ledger-specs/pull/1477 but https://github.com/input-output-hk/cardano-ledger-specs/pull/1476 hasn't been merged yet.

bors merge


Add MAINTAINERS file

cc @ehazlett

@ehazlett I also added an initial CONTRIBUTING.md here, so if you'd be willing to take a look, I'd appreciate it :pray:

Other than the comment, looks good!

LGTM

:heart:

yay :fireworks:


Custom server, filesystem-defined routes: TypeError: Cannot read property 'replace' of undefined

I use the following as index.js (a simpler version of the example at https://zeit.co/blog/next2#programmatic-api):
const express = require('express')
const next = require('next')

const dev = process.env.NODE_ENV !== 'production'
const app = next({ dev })
const handle = app.getRequestHandler()

app.prepare().then(() => {
  const server = express()

  server.get('/r', (req, res) => {
    return app.render(req, res, '/b', req.query)
  })

  server.get('*', handle)
  server.listen(3000)
})

I also a have a dumb component page as pages/b.js:
export default () => (

Welcome to b.js!

)

After starting the server (node index.js), route /r responds correctly (with page b) but route /b responds with an internal server error.
(Also note route /b responds correctly with page b when running the standard Next server yarn dev.)
Stack trace:
TypeError: Cannot read property 'replace' of undefined
    at toRoute (/Users/arnaudrenaud/nvh4/node_modules/next/dist/lib/router/router.js:821:14)
    at new Router (/Users/arnaudrenaud/nvh4/node_modules/next/dist/lib/router/router.js:128:18)
    at renderPage (/Users/arnaudrenaud/nvh4/node_modules/next/dist/server/render.js:150:25)
    at Function.getInitialProps (/Users/arnaudrenaud/nvh4/node_modules/next/dist/server/document.js:79:25)
    at _callee$ (/Users/arnaudrenaud/nvh4/node_modules/next/dist/lib/utils.js:36:30)
    at tryCatch (/Users/arnaudrenaud/nvh4/node_modules/regenerator-runtime/runtime.js:64:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (/Users/arnaudrenaud/nvh4/node_modules/regenerator-runtime/runtime.js:299:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/Users/arnaudrenaud/nvh4/node_modules/regenerator-runtime/runtime.js:116:21)
    at step (/Users/arnaudrenaud/nvh4/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /Users/arnaudrenaud/nvh4/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14

package.json:
{
  ...
  "dependencies": {
    "express": "^4.15.2",
    "next": "^2.0.1",
    "react": "^15.4.2",
    "react-dom": "^15.4.2"
  },
  "scripts": {
    "dev": "next",
    "build": "next build",
    "start": "next start"
  }
}

I use node v6.9.2.

try https://github.com/zeit/next.js/blob/master/examples/custom-server-express/server.js#L20

If this doesn't fix your issue, you may need to provide a sample repo for us.

The solution provided by @aranajhonny solved the issue.

Okay. Gonne close this then.


Readme with broken links

The readme file has 2 "broken" links:

We will wait for the structure definition of documentation on #4.
We have discussed that the samples link should point towards an intermediate documentation structure and that documentation points toward the samples' source code on the repository.

Also change README file to set the requirements to .NET Standard 2.0 instead of .NET Core 2.1.

This issue has been fixed with the creation of the wikipage.


** Note this is for two different pages, page:/ https://claim-tax-benefits.azurewebsites.net/trillium/propertyTax and page/ https://claim-tax-benefits.azurewebsites.net/trillium/propertyTax/amount  **

** Note this is for two different pages, page:/ https://claim-tax-benefits.azurewebsites.net/trillium/propertyTax and page/ https://claim-tax-benefits.azurewebsites.net/trillium/propertyTax/amount  **
Please replace page with:
Heading:  - Apply for OTB: property tax
Did you pay property tax for the place you lived most of  2018?
Continue Cancel
Next page
Heading - Enter your property tax payments to apply for OTB
The government might ask for your property tax receipts.

Continue Cancel

Closing as 200 has been merged


Use the count (*) interface of query to replace the num_entities () interface

Describe the feature:

num_entities () interface is inaccurate, using the query count (*) interface can more accurately count the number of data.
Describe a specific use case for the feature:

query count (*) is only applied on loaded collection.  may be we  can update the card in  loaded collections section.


More Intelligent IntelliSense

I would like IntelliSense to be more geared to editing existing code, in addition to adding new code.  Right now, it is only geared to adding new code.  Here is an example of what I mean:

Let's say we have a method defined with 3 parameters.  Let's also say that I have an existing method call of that same method, with 3 values corresponding to those 3 parameters.  Let's say I erase the middle (2nd) parameter so that the code looks like this:
someFunction(345,,"test");
With the cursor at the position indicated, at the spot where the 2nd parameter should go, I would like to see the IntelliSense show the following:    Parameter: String name

If all parameters are present in the method call, then no IntelliSense help would be shown.

Basically, IntelliSense should not show any help box unless there is no code at all in the spot where the cursor is, or the code that is there is different from what is already there.  When I say there is no code there at all, I mean that the statement is incomplete to the right of the cursor.

Ok, lets start with the language you are using and the extension that is providing the smarts. A real code snippet would help be helpful


Fix of mandatory inliner's handling of unowned and guaranteed captures

And fix it's handling of guaranteed closure contexts.
Guaranteed/unowned captures and guaranteed contexts are not released
by a call of the closure.
I assume we have not seen this because we don't see code that would
trigger this comming out of the frontend ...
SR-5441
rdar://33255593

@swift-ci Please test

@swift-ci Please source compatibility

@swift-ci Please test source compatibility


TextEditor.decorateMarker is deprecated.

Decorations of type: 'gutter' have been renamed to type: 'line-number'.
TextEditor.decorateMarker (C:\Users\Patrick\AppData\Local\atom\app-0.196.0\resources\app.asar\src\text-editor.js:1228:9)
<unknown> (C:\Users\Patrick\.atom\packages\atom-typescript\dist\main\atom\editorSetup.js:22:45)

4.1.4


Wrappers for conversions from duration types from the 'time' library

Added simple wrappers for conversions from the duration types that the "time" library (the canonical time library in Haskell), in case you wanted them.
This does incur a dependency on a new library, time; however, time does come "built in" to GHC and is always installed in all but exceptional circumstances.  But, if this is against the spirit of the library, or if you think it clutters up the API, feel free to close and move on :)

Great! Thanks, I've written this lib in a hurry. I didn't wanted to add Text or Bytestring dependency in this one. But adding time will be a nice addition.


Copy / Paste Bug from Word

Report by @gabrielhase :
To reproduce

Take any Microsoft Word Document and open it in a recent version of Microsoft Word
Select all content and copy
paste into an empty paragraph in the editable zone

Observed Behavior
The content is pasted into separate paragraphs and the first paragraph contains styling information.
Expected Behavior
The content is pasted into separate paragraphs but no styling information should be pasted
Video
https://drive.google.com/file/d/0Bya_F0ISZ6F8ckU2Q2p1ajRGTDg/view
Fix
https://github.com/upfrontIO/editable.js/pull/148

Close in #148


text copy and paste adds new line under pasted line

How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
MacOS
What is the issue affecting?
Formatting
Expected Behaviour
When I copy a text in a line, I don't expect a new line to be added underneath
Actual Behaviour
When I copy something into a line, it adds an additional line below now
Reproduction steps
local test = "hello"
print()
print()
copy test and paste into the second line parenthesis:
local test = "hello"
print(test)
<--- new line inserted here
print()
Additional Notes
https://user-images.githubusercontent.com/22533048/193159462-024e342d-2f6a-46ff-88ab-6ddf73512cce.mov
Log File
I cannot provide, the logs have critical information

Likely a duplicate of https://github.com/sumneko/lua-language-server/issues/1538. Please try disabling the format on paste option in VS Code.


nginx: some http3 module fixes

Motivation for this change
Make it better
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Yes. It's only possible to have one virtual server listening with reuseport. Creating multiple fails. https://trac.nginx.org/nginx/ticket/2179

Could you mention that in the commit message?

Added it

I'm not really in favor of just disabling reuseport. AFAIR, you can only specify it once in the config, but that means it will just be enabled. So basically, it just needs to be specified in the first http3 listening directive.

@mkg20001 @ajs124
Option reuseport don`t needed. Because of this, the HTTP3 protocol does not work with multiple hosts.
Minimal working configuration without reuseport:
pid /run/nginx/nginx.pid;
error_log stderr;
daemon off;
events { }
http {
  include /nix/store/qd3g8rk5hx5zkb70idjh6fa12sh6bipg-mailcap-2.1.53/etc/nginx/mime.types;
  include /nix/store/mwibmbkyhimr43bkbrpz9sway6krcniq-nginx-quic/conf/fastcgi.conf;
  include /nix/store/mwibmbkyhimr43bkbrpz9sway6krcniq-nginx-quic/conf/uwsgi_params;
  default_type application/octet-stream;
  ssl_protocols TLSv1.2 TLSv1.3;
  ssl_ciphers ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-G>
  client_max_body_size 10m;
  server_tokens off;

  server {
    listen <IP_ADDRESS>:443 http3;
    listen <IP_ADDRESS>:443 ssl http2;
    server_name test1.local;
    root /var/www/test1;
    ssl_certificate /var/certs/test1.crt;
    ssl_certificate_key /var/certs/test1.key;
  }

  server {
    listen <IP_ADDRESS>:443 http3;
    listen <IP_ADDRESS>:443 ssl http2;
    server_name test2.local;
    root /var/www/test2;
    ssl_certificate /var/certs/test2.crt;
    ssl_certificate_key /var/certs/test2.key;
  }
}

Also in the current version of the module, duplicate parameters are created:
  server {
    listen <IP_ADDRESS>:443 ssl http2 ;# UDP listener for **QUIC+HTTP/3
    listen <IP_ADDRESS>:443 http3 reuseport;
    # Advertise that HTTP/3 is available
    add_header Alt-Svc 'h3=":443"';
    # Sent when QUIC was used
    add_header QUIC-Status $quic;
    listen [::0]:443 ssl http2 ;# UDP listener for **QUIC+HTTP/3
    listen [::0]:443 http3 reuseport;
    # Advertise that HTTP/3 is available
    add_header Alt-Svc 'h3=":443"';
    # Sent when QUIC was used
    add_header QUIC-Status $quic;
    server_name test1.local ;

Optimized patch:
diff --git a/nixos/modules/services/web-servers/nginx/default.nix b/nixos/modules/services/web-servers/nginx/default.nix
index 3c5ae36652d..8d3cf043297 100644
--- a/nixos/modules/services/web-servers/nginx/default.nix
+++ b/nixos/modules/services/web-servers/nginx/default.nix
@@ -254,20 +254,19 @@ let
             else defaultListen;

         listenString = { addr, port, ssl, extraParameters ? [], ... }:
-          "listen ${addr}:${toString port} "
-          + optionalString ssl "ssl "
+          (if ssl && vhost.http3 then "
+          # UDP listener for **QUIC+HTTP/3
+          listen ${addr}:${toString port} http3 "
+          + optionalString vhost.default "default_server "
+          + ";" else "")
+          + "
+
+            listen ${addr}:${toString port} "
           + optionalString (ssl && vhost.http2) "http2 "
+          + optionalString ssl "ssl "
           + optionalString vhost.default "default_server "
           + optionalString (extraParameters != []) (concatStringsSep " " extraParameters)
-          + ";"
-          + (if ssl && vhost.http3 then ''
-          # UDP listener for **QUIC+HTTP/3
-          listen ${addr}:${toString port} http3 reuseport;
-          # Advertise that HTTP/3 is available
-          add_header Alt-Svc 'h3=":443"';
-          # Sent when QUIC was used
-          add_header QUIC-Status $quic;
-          '' else "");
+          + ";";

         redirectListen = filter (x: !x.ssl) defaultListen;

@@ -317,6 +316,13 @@ let
             ssl_reject_handshake on;
           ''}

+          ${optionalString (hasSSL && vhost.http3) ''
+            # Advertise that HTTP/3 is available
+            add_header Alt-Svc 'h3=":443"; ma=86400';
+            # Sent when QUIC was used
+            add_header QUIC-Status $quic;
+          ''}
+
           ${mkBasicAuth vhostName vhost}

           ${mkLocations vhost.locations}

On one of hosts, you need to necessarily add the parameter reuseport. Otherwise, it stops working normally.
 curl --http3 --head -4 https://example_site
curl: (56) Failure when receiving data from the peer

can you create a PR with that? Otherwise I would close this.

@SuperSandro2000 already implemented in this PR - https://github.com/NixOS/nixpkgs/pull/146917


Overridden method "GetHashCode" should use/invoke "HashCode.Combine()"

In case the method GetHashCode gets overridden, it should use the method HashCode.Combine to create a hash code.

Note that Combine allows to use at most 8 parameters.
In case there are more, we have to call following:
public override int GetHashCode()
{
    HashCode hash = new();
    hash.Add(M11);
    hash.Add(M12);
    hash.Add(M13);
    hash.Add(M21);
    hash.Add(M22);
    hash.Add(M23);
    hash.Add(M31);
    hash.Add(M32);
    hash.Add(M33);
    return hash.ToHashCode();
}

We should also be aware of calls to base.GetHashCode().
Such calls should be combined such as
HashCode.Combine(base.GetHashCode(), someField);


Cache the request IP

Resolves #695

Nice work, if no one objects to it -- it'd be nice to backport this fix to koa 1 as well

Since removeAddress calls into native code, I wonder what the performance hit this will add to every request, for those bot even getting the IP in their code.

Travis is running benchmarks now, let me check

There doesn't seem to be a noticeable difference on my machine, on Travis it's 10% faster but I'd assume that's not reliable.

So sounds negligible.

Shouldn't the stable major-point release of Koa (v1) be patched as well instead of just the v2 version that's not going to be stable until async/await lands in v8?

@kraghack I'm pretty sure v2 is going to be stable sooner than async/await.

Okay I changed a bunch of things up but it can't be backported to 0.12 easily now.

looks fine to me. anyone else? @Koajs

@PlasmaPower i think the tests will pass again if you rebase. i upgraded the eslint packages

Yep, tests seem to be passing now.

It now defaults to '' at the request of @dead-horse.

LGTM

+1

I just rebased, tests are still passing, this should be ready to merge.

+1. Should we also make a PR for koa v1.x then?


Feature Request: Companion v2 Preset icons

Add Companion v2 preset icons to allow devs to continue using them across modules
List of icons:
https://github.com/bitfocus/companion/commit/0a9550e907cafad69e50dd1ef1cd6886c90918e1

Sorry for the delay in getting these added, as I've been ill over the Christmas period so have only now been able to get these added in the version I just published, 0.4.0.
https://github.com/thedist/companion-module-utils/blob/main/docs/graphics.md#icon has the docs for how to generate the icons, and as Presets don't support an imagebuffer like a feedback does, you'll need to use https://github.com/thedist/companion-module-utils/blob/main/docs/graphics.md#topng64 to convert the buffer into a png64 for use in Presets.


add LongZ NFT

add LongZ NFT

@FishMeat thanks for the PR. Congrats!
Please note that supporting displaying in explorer and ioPay are still under development. You will see them once they are there.

@guo Good job!


Get Azure access token using SAML assertion

Hi Team,
I have been trying to get azure access token using SAML assertion from last many days, but no success. I followed the approach mentioned in below link.
[https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-saml-bearer-assertion]
Every time I get below error.
AADSTS50107: The requested federation realm object 'https://sts.windows.net/xxxxxxx/' does not exist.
Kindly assist in get it issue resolved.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f168986-8f8f-4e97-cba8-547564c97eb5
Version Independent ID: 12ac4571-4f35-300e-9119-8d13673f3722
Content: Microsoft identity platform & SAML bearer assertion flow
Content Source: articles/active-directory/develop/v2-saml-bearer-assertion.md
Service: active-directory
Sub-service: develop
GitHub Login: @kenwith
Microsoft Alias: kenwith

@darshangithub, Thank you for reaching out. The OAuth 2.0 SAML Bearer Assertion Flow is intended for federated domains only. More info can be found here, that thread has a more in depth discussion of the scenario.
Hope this helps. We are closing this thread for now. In case any more queries, please feel free reach out to us so that we can get-this case reopened and hep you further.

Hi,
Thank you for your prompt response.
Can you guide me or share the link on how to make Azure AD federated. As I
can see my directory "Federation" value is "disabled". If I enable it will
my problem be solved?. As of now I got the links which mentions how to
federate enterprise app with Azure AD.
On Tue, 22 Sep 2020, 2:19 pm souravmishra-msft<EMAIL_ADDRESS>wrote:

Closed #63015 https://github.com/MicrosoftDocs/azure-docs/issues/63015.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/63015#event-3792133924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6CWQGMBCFBH6VHDIFWRQDSHBQJJANCNFSM4RVNNBAA
.


O365 phishlet

Tested and catches all logins from ADFS and O365. Depending on the local ADFS implementation this might need to be extended with community feedback.
In addition, there is a workaround for the missing detection of the :443. Fields on the sub_filters & proxy_hosts need to be manually filled into the yaml before launch. By allowing to use params for those things (separate PR) this can be avoided in the future.

Great work! Does this phishlet work with Office 365 MFA-enabled account?
I installed phishlet successfully but after importing cookie to Chrome I am getting prompt for second-factor (no prompt for login name or password). MFA is activated on the account by Azure AD.
When account is not MFA-enabled I can get full way in with ESTSAUTH and ESTSAUTHPERSISTENT cookies.

I think the reason might be that first pair of ESTSAUTH + ESTSAUTHPERSISTENT cookies is issued after username+password auth (https://login.microsoftonline.com/common/login). Then new pair of ESTSAUTH + ESTSAUTHPERSISTENT cookies with new values is issued after second factor auth https://login.microsoftonline.com/common/SAS/ProcessEnd). However evilginx only captures first pair of cookies. It confirmed that with "all authorization tokens intercepted!" despite the fact that I still had to perform 2nd factor auth.
@kgretzky can you confirm that evilginx is not greedy? If it has all the cookies defined in the phishlet to be capture it will not overwrite them with new cookies that arrive after 2nd factor authentication?

Just commenting to echo I have the experience with the authentication cookies as @pawp81. It would be great to hear from @kgretzky if there is a means to overwrite this behaviour in the phishlet or any other way?

OK I made it work. I added to @JamesCullum  phishlet following code:
`auth_urls:

'/kmsi'`
Thanks to that evilginx will capture cookies until user is redirected to login.microsoftonline.com/kmsi which happens after 2nd factor authentication. It will save last ESTSAUTH cookie.
Btw I am not sure if ESTSAUTHPERSISTENT cookie needs to be captured at all. I was importing only ESTSAUTH cookied and it worked fine.

Can confirm that @pawp81 MFA change works for me, using all the MFA auth types I tried (SMS, call, authenticator app) - I'm able to capture and recreate the sessions.
However I've noticed that this does break my redirect_url on the lures, whereas before it would redirect after authentication, it no longer is able to, unless I re-visit the initial lure URL for a second time. Any idea how to get this functionality back while keeping the MFA token capture??

Would it be possible for you to provide me with access to such a MFA login (for a dummy/debugging account)? Then I can support you in this. As my organization doesn't utilize MFA, I can't test it myself.

How can I communicate with you privately?

You can send me an email to<EMAIL_ADDRESS>(will edit this comment later to remove).

Thanks to @pawp81 I was able to test it for 2FA and was able to fix it, so that the redirect_url works and cookies always get captured. This works for me independantly if the user remembers log ins or not.
Compatibility with ADFS is tested and still works, so it shouldn't break anything.
@pawp81 @gettheguru
Can both of you test the newest version and verify whether or not it works?

@JamesCullum  I tested and new phishlet works fine with 2FA and without 2FA. I have a small problem though with federated account authenticating via ADFS. There is no message that all tokens have been intercepted. However the session with cookies, username and password is being saved.

Thanks to @pawp81 I was able to test it for 2FA and was able to fix it, so that the redirect_url works and cookies always get captured. This works for me independantly if the user remembers log ins or not.
Compatibility with ADFS is tested and still works, so it shouldn't break anything.
@pawp81 @gettheguru
Can both of you test the newest version and verify whether or not it works?

Mind sharing it here also<EMAIL_ADDRESS>. Will test with ADFS.

Hi @JamesCullum - all working for me except the redirect_url only works on 2nd visit to the lure address. I do see 'all authorization tokens intercepted!' in the console though. You mentioned that the redirect_url works now for you - any idea what I'm doing wrong? FYI there is no overlap between the phishing URL and the redirect URL

Hey @gettheguru,
With the new method it redirects immediately for me.
Do you have a lure configuration for me I can try?
@pawp81 Is redirect_url working for you?

Hey @JamesCullum, thanks for the swift reply.
Pretty simple really;
lures create o365
lures edit redirect_url 0 https://www.google.com
Second visit takes me to google as expected. First visit holds me on the office.com proxied via my phishing site (www.xxxxx/?auth=2) with no re-direct. I've tried both selecting "no" and "yes" on the remember my details page.

Alright, I took a closer look into this now. The issue appears to be in the main code itself - it triggers the redirect at the wrong time.
O365 redirects the user to the final www.office.com landing page with a JS form press. However, the browser (for me, FF) triggers a favicon page. Before, this is always a 404, that's why it retries it. That page is redirected to redirect_url but the submitted page isn't.

Theoretically, this would require code changes on the intercept. As the other PRs look like @kgretzky is not a big fan of changing the code base, this is out of scope for now.
It was also not possible to use the new javascript injection possibilities. Due to missing debugging capabilities, it is not easy to find out why.
However, to still be able to use just the plugin to use the desired redirect, I added a rewrite of the final submission. You can see in the newest commit that I added a small manual for that. Basically, uncomment the line for the redirect and put the desired URL.
@gettheguru Can you test and confirm whether or not this works for you as well, please?

Hi @JamesCullum,
Thank you very much for your efforts on this, it is much appreciated. I also found I was unable to implement the javascript injection for whatever reason.
I can confirm your workaround is working perfectly for me. And everything else appears fully functional that I am able to test.
Given how prevalent o365 is at the moment I think this would make a great addition to the evilginx2 base branch.
Thank you again!

Ok, so as I understand the redirect triggers for the favicon.ico only and later it doesn't redirect?
I've changed the redirection to trigger only once in latest version, so this may be causing the issue.
I think the reasonable way to counter it would be to set a maximum number of redirects to trigger for each session (currently default is 1) and only trigger redirects for text/html Content-Type.

Hey @kgretzky, that appears to be the issue. I think the main part is the filtering for the content type, which should be easy to imlement.
Do you want to merge the PR then? It probably makes sense to track the bug in a different issue.

Thanks. I will try to fix it over the weekend in the code and then the phishlet should work fine in its original form, so I don't think a merge now is needed.
Thanks for the screenshot of the requests history - it made it clear to me where the issue resides.
Will let you know here.

@JamesCullum I've just pushed the redirection fix. Can you pull and tell me if you still have an issue with redirection not triggering for proper request?

I need to build with the latest master, right? Or is there a compiled version?

Alright, I build it from source and tested it.
I now get redirected without having to activate the workaround.
I will therefore remove that part from the phishlet.

Great job @JamesCullum
Thank you for your contribution! Merging.

Many thks, work fine with ADFS

hey frdaz. sorry for being ignorant but I wonder if you please let me know how that ADFS worked for you. I have a test organization with ADFS configured. I used the O365 phishlet and followed all the necessary steps. I got the O365 page even but upon redirecting to my Organization login page it says that I am not authorized to use this location (something like that). If possible could you please drop few lines how you achieved this.
Thanks in advance.

Did you put the correct ADFS url into the config file? Maybe show us your config, so that we can help.

Hi James, thanks for your swift reply. Sure, will do once I login to my droplet. Thanks again.

Hi, I just checked the o365.yaml file but couldn't find a way to set my ADFS URL. Neither, I could find the redirect_url option. Please advice and I apologize again for my ignorance. Thanks.

There are placeholders in the file that you need to replace. If it doesn't work, you probably didn't do that. There are instructions in the file to support you.

Thanks a lot for your speedy replies and help...

Hello, i used ADFS, and i modified the yaml placeholders by my company but nothing work, in login page cannot find my username@federated domain. i search if i find anything.

@pawp81 please share your email address.
Thanks

@pawp81  email me once at<EMAIL_ADDRESS>Big Thanks

Hi,
i have used this O365 [phishlet]
O365 phishlet.txt
and i have changed the ADFS values corresponding to my company, but it doesn't work for me.
id  | phishlet  |         username          |    password      |  tokens   |  remote ip    |       time        |
+-----+-----------+---------------------------+------------------+-----------+---------------+------------
| 17  | o365      |                                    |                          | none      |                 | 2019-11-27 17:21  |
Thank you for help.

Hi!
I'm trying to use this phishlet but on typing my email it redirects me to a https://login.live.com/ page displaying "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application."
does this have something to do with the phishlet, or it's on my side?

That’ll mean it’s not an office 365 account, it’s more like a Hotmail or Live account.
On 17 Feb 2020, at 21:51, YusufHegazy<EMAIL_ADDRESS>wrote:

Hi!
I'm trying to use this phishlet but on typing my email it redirects me to a https://login.live.com/ page displaying "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application."
does this have something to do with the phishlet, or it's on my side?
—
You are receiving this because you were mentioned.

Hey @JamesCullum
There seems to be an issue when I try to use it on my own ADFS.
I've commented out the lines on the o365.yaml like this:
- {phish_sub: 'adfs', orig_sub: 'adfs', domain: 'originadomain.com', session: true, is_landing:false}
- {phish_sub: 'adfs', orig_sub: 'adfs', domain: 'originaldomain.com:443', session: true, is_landing:false}
.
.
- {triggers_on: 'adfs.originaldomain.com', orig_sub: 'login', domain: 'microsoftonline.com', search: 'https://{hostname}', replace: 'https://{hostname}', mimes: ['text/html', 'application/json', 'application/javascript']}

But when I enter my credentials I get the following error:
The requested federation realm object ;http://adfs.phishdomain.com:443/adfs/services/trust; does not exist.
When I try to remove the :443 from the request I get redirected properly and asked for 2FA, but you will need to be in the client's machine to do it (I did it with match/replace in Burp while proxying the traffice from Evilginx2)
Is there a way to add a trigger that will do it for me?
Thanks 😄

but you will need to be in the client's machine to do it what do you mean with that?

Yea that sentence does not really make sense..
One hacky way of solving the issue was to proxy the Evilginx server through Burp and add a match/replace rule which replaces every :443/adfs/services/trust to /adfs/services/trust it finds.
I tried to write a sub_filter but failed horribly 😅.
My final solution was to edit the http_proxy.go file by adding some code which searches for the string :443/adfs in the req.Body for the specific url path, in my case /login.srf  and remove the :443.
This worked great, however I'm pretty sure that this should be possible with a sub_filter.
I can make a pull request so that you have a more clear of idea of my workaround.
Cheers 😄

The bug with the :443 is known and was reported already. Not sure if it has been fixed, but thats why the sub_filter is there - in most cases it works well, but its impossible to tell from here why it doesnt for you.

I think the issue with the suggested sub_filter is the is that the request is for http://originaldomain.com:443 and not https.
Shouldn't an extra trigger like this catch the above?
 - {triggers_on: 'adfs.originalsubdomain.com', orig_sub: 'login', domain: 'microsoftonline.com', search: 'http://{hostname}', replace: 'http://{hostname}', mimes: ['text/html', 'application/json', 'application/javascript']}

Are there any gotchas or special processes when taking the authorisation cookies with office 365? I did a quick test this evening but wasn’t able to make use of the stolen cookies (imported with editthiscookie) but seemingly unable to get login.microsoftonline.com to pay attention to them

i get an ssl certificate and put it in ./evilginx/crt/ and it working well , and when i run apache2 and check the certificate it run correctly with no error and the browser trust my domain , but when i stop apache2 and run evilginx the browser still not trust the certificate and the facebook page not like the real one , i already catch the token but it give me
WARN: Cannot handshake client static.xx.fbcdn.net remote error: tls: bad certificate
please any one can help me<EMAIL_ADDRESS>

Tested and catches all logins from ADFS and O365. Depending on the local ADFS implementation this might need to be extended with community feedback.
In addition, there is a workaround for the missing detection of the :443. Fields on the sub_filters & proxy_hosts need to be manually filled into the yaml before launch. By allowing to use params for those things (separate PR) this can be avoided in the future.

is there a workaround to make ADFS autodetect domain instead of having to manually specify domain? I'm think maybe a regex implementation? Thank you .

Hello, has anyone else tested Evilginx2 with O365 using MFA recently? If so is it still working for you?
I would like to confirm whether the issue is on my end or if something has changed in O365 to prevent this.
I am having issues similar to what is mentioned earlier in this pull request. My phishing page will capture username/password and session tokens before MFA prompts. When I enter the username/pass (captured), my phishing page is directed to office.com (www.xxxxx/?auth=2). Here I can only click on Outlook and/or apps(as the signed in user), once I click on Outlook I leave my phishing page and am prompted to put in my MFA (authenicator app) back at login.microsoftonline.com but not on my phishing page.
I have tried using auth_urls in the o365.yaml, specifying '/kmsi' as mentioned earlier. Though this does not work because "/kmsi" happens before I am prompted for MFA.
I am running Evilginx2 latest, built from source.

Tested and catches all logins from ADFS and O365. Depending on the local ADFS implementation this might need to be extended with community feedback.
In addition, there is a workaround for the missing detection of the :443. Fields on the sub_filters & proxy_hosts need to be manually filled into the yaml before launch. By allowing to use params for those things (separate PR) this can be avoided in the future.

is there a workaround to make ADFS autodetect domain instead of having to manually specify domain? I'm thinking maybe a regex implementation? Thank you .

You should cc @JamesCullum

As long as @kgretzky is not merging changes outside of phishlets, I don't believe it is possible. I'm also not sure I understand your organizational setup, which would allow you to phish several ADFS domains. If it is different organizations and you are a professional pentesting company, you should separate the data anyways and put it on different servers.

That’ll mean it’s not an office 365 account, it’s more like a Hotmail or Live account.
…
On 17 Feb 2020, at 21:51, YusufHegazy @.***> wrote:  Hi! I'm trying to use this phishlet but on typing my email it redirects me to a https://login.live.com/ page displaying "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application." does this have something to do with the phishlet, or it's on my side? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

is there any hotmail or live account yaml available ?

Yep the outlook.yaml phislet

On 11 Jul 2020, at 16:07, donjuanme<EMAIL_ADDRESS>wrote:

That’ll mean it’s not an office 365 account, it’s more like a Hotmail or Live account.
…
On 17 Feb 2020, at 21:51, YusufHegazy @.***> wrote:  Hi! I'm trying to use this phishlet but on typing my email it redirects me to a https://login.live.com/ page displaying "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application." does this have something to do with the phishlet, or it's on my side? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
is there any hotmail or live account yaml available ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

greetings,
i have found a problem in the current Facebook phishlet, it only records the password on the first attempt only
say per example the victim has entered a wrong pass,  the wrong pass will be recorded as the first attempt, but after the user inserts the correct one or other attempts it doesn't record it on #sessions, however the username is being recorded each time and works fine.
can somebody check if its an actual bug or its just happening with me?
thanks

Hi @JamesCullum,
I seem to be having the same http......:443 issue.

My companies O365 uses ADFS.  Any ides what I can do as a workaround?
I have tried a subfilter, but can't seem to get it to work.
@0mikron, did you get something working?  Looks like you had the same issue.
Cheers

That’ll mean it’s not an office 365 account, it’s more like a Hotmail or Live account.
…
On 17 Feb 2020, at 21:51, YusufHegazy @.***> wrote:  Hi! I'm trying to use this phishlet but on typing my email it redirects me to a https://login.live.com/ page displaying "invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application." does this have something to do with the phishlet, or it's on my side? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

is there any hotmail or live account yaml available ?

I also have that problem. redirect_uri' is not valid
Why is that?

Hi @JamesCullum
I had the same issue http......:443
I've created a sub_filter to fix it:
  - {triggers_on: 'adfs.phishingdomain.com', orig_sub: 'login', domain: 'microsoftonline.com', search: 'adfs.phishingdomain.com/adfs/services/trust', replace: 'adfs.phishingdomain.com.au/adfs/services/trust', mimes: ['text/html', 'application/json', 'application/javascript']}
But I found out that the sub_filters created by evilgix2 are executed after the sub_filters created by users, making my filter useless.
So I've this dirt sub_filter:
  - {triggers_on: 'adfs.phishingdomain.com', orig_sub: 'login', domain: 'microsoftonline.com', search: 'adfs.phishingdomain.com/adfs/services/trust', replace: 'adfs.phishingdomain.com.au/adfs/services/trust', mimes: ['text/html', 'application/json', 'application/javascript']}
By replacing the . per its HTML encoded representation (.), it is not matched by the filters automatically created by evilginx2.
It worked for me, it may help others.

nice, thanks for that @cauan

Hi everyone,
We have been trying to setup a Phishing for ADFS using the o365.yaml template. A user is able to enter his/her username and is then redirected to adfs.phishing.com where he/she should be able to enter his password. However, when the user is redirected to the adfs.phishing.com domain, the browser gives the following error message:
Secure Connection Failed
In the EvilGinx console, we receive the following error message:
WARN: Cannot read TLS response from mitm'd server local error: tls: no renegotiation
The adfs.phishing.com/ endpoint itself is accessible (error 404) and the certificate is trusted.
We are not using any other proxies.
Does anyone know what we are missing here?
Thanks in advance!
Best regards.


[$1000]  App does not translate 'reacted with' to spanish in new reacted with emoji tooltip

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open settings
Open Preferences
Open Language
Change language to spanish
Open any report
React to any message
Hover on reacted emoji

Expected Result:
App should translate 'reacted with' text as it translates 'You' above it
Actual Result:
App only translates 'You' in tooltip and does not translate 'reacted with' to spanish
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.86-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/225697504-de080bb4-37e8-4291-ac5f-01672b8a13f9.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678961850453749
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0a0323d7f5b83e2
Upwork Job ID:<PHONE_NUMBER>419566080
Last Price Increase: 2023-03-16

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Looks like this was introduced alongside https://github.com/Expensify/App/issues/15127, where reacted with is hardcoded in, rather than in the translation file.
@stitesExpensify and @hannojg , I will put this thorough the usual Extenal process, unless you two want to take it for some other reason?

Job added to Upwork: https://www.upwork.com/jobs/~01a0a0323d7f5b83e2

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Reacted emoji tooltip does not translate reacted with  word in to Spanish
What is the root cause of that problem?
Within ReactionTooltipContent.js at line 65 'reacted with' text hardcoded. This is the root cause of the problem.
https://github.com/Expensify/App/blob/0efe6acf41eb985a0d6e42b47a8d91ab9cef6559/src/components/Reactions/ReactionTooltipContent.js#L65
What changes do you think we should make in order to solve the problem?
We have to add translation key within en.js and es.js and update line 65 as shown below.
Within src/languages/en.js add below translation key
reportActionContextMenu: {
  ...
  reactedWith: ({emojiName}) => `reacted with :${emojiName}:`,
},

Within src/languages/es.js add below translation key
reportActionContextMenu: {
  ...
  reactedWith: ({emojiName}) => `reaccionó con :${emojiName}:`,
},

Within  ReactionTooltipContent.js at line 65 change code as shown below
  { props.translate('reportActionContextMenu.reactedWith', {emojiName: props.emojiName}) }

What alternative solutions did you explore? (Optional)
None

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Issue Root Cause:
Spanish translation is not available in es.js file
Solution:
Adding translation string in es.js & en.js file and modify the code by removing hard coded English text and updating translation trigger point in ReactionTooltipContent.js file’s 65th line., “reacted with” text is translated into Spanish text.

Below are the changes in es.js & en.js language files.

Expected Output:

@stitesExpensify and @hannojg , I will put this thorough the usual Extenal process, unless you two want to take it for some other reason?

I think this is simple enough to just be fixed internally. Sorry to those that have already submitted proposals, but this seems like cleanup from a new feature that was added recently.

@stitesExpensify @jasperhuangg I have a related issue here https://github.com/Expensify/App/issues/16086
Should we treat these separately or get both fixed here?

@stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@stitesExpensify any advice on the above comment?

Apologies for the delay, I'm currently sick and (mostly) OOO. These are definitely separate issues @tjferriss .
I'll fix this internally next week.

PR is up

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.91-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/16555

If no regressions arise, payment will be issued on 2023-04-05. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [] Determine if we should create a regression test for this bug.
[ ] [@stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@stitesExpensify can you confirm we're not paying out @eVoloshchak for the contributor plus role?

@tjferriss puneet decided that we actually did want a contributor plus here, so we should pay them for a review

Thank you for confirming. @dhanashree-sawant and @eVoloshchak I've sent you both offers via Upworks.

Hi @tjferriss , ping for upwork.

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

Sorry @dhanashree-sawant @eVoloshchak I missed this before heading out of office. I just invited you both to the job on Upworks: https://www.upwork.com/jobs/~013ae3f2bb593b09f0

Hi @tjferriss , sure that's okay, there is already a job with offer for the same task. I will message you on upwork in that offer. If possible, can you only accept that offer?

Same thing, I already have an active job for this task

Got it. Payments have been sent using the original job post.
@stitesExpensify can you complete the check list?

@stitesExpensify Still overdue 6 days?! Let's take care of this!

Completed checklist! Closing


Frontend should handle if existing entity(conversation, prompt, file or folder) has dots in the end

EPAM AI DIAL chat version
0.6.9
What happened?
Frontend should handle if existing entity(conversation, prompt, file or folder) has dots in the end:
API doesn't allow to modify such paths - 400 error
two cases:

existing entities with dots in the end
create manually file/folder with dots in the end in storage which allows it

Confidential information

[X] I confirm that do not share any confidential information

Example of current issue:

Verified on staging, reported #1022 #1229


[aws-bootstrap] plural destroy fails to destroy Terraform resources

Summary
Running plural destroy on aws-bootstrap always fails with this Terraform error:
│ Error: Unsupported attribute
│
│   on aws-bootstrap/locals.tf line 6, in locals:
│    6:     worker_private_subnet_ids = var.create_cluster ? module.vpc.worker_private_subnets_ids : var.worker_private_subnet_ids
│     ├────────────────
│     │ module.vpc is object with 98 attributes
│
│ This object does not have an attribute named "worker_private_subnets_ids".

I get the same error if I manually try terraform destroy inside bootstrap/terraform directory in the workspace.
Just to get to the root cause, I set create_cluster to false and then it makes a little progress but fails again further along. Not sure but I suspect create_cluster set to true is causing issue related to resource ordering when destroying.
Reproduction

I can replicate it with these commands:
$> plural bundle install kafka aws-kafka
...
$> plural bundle install console console-aws
...
$> plural build
..
$> plural deploy
...
$> plural destroy

UI/UX Issue Screenshots

Additional Info about Your Environment

PLURAL CLI:
   version	0.6.8
   git commit	308cf3858b8d26dd5a7c93613bbbf2879d8372b8
   compiled at	2023-02-24T19:18:19Z
   os/arch	darwin/arm64

Message from the maintainers:
Impacted by this bug? Give it a 👍. We factor engagement into prioritization.

Thanks for the report, we'll try to get this figured out soon.  It's odd, because I'm pretty sure we have done some successful destroys recently

@tusharm Are you still running into this issue? I did 6 cycles of creating and destroying clusters and wasn't able to replicate it. So if you are still running into this I would love to setup a call so we can further debug this.

Thanks @DavidSpek, let me know how to schedule.

I've just had the same issue when trying to destroy, I noticed some references to a worker_private_subnets_ids variable, and other references to a worker_private_subnet_ids variable, is it possible the wrong variable name has been used somewhere?