feature/neg_binomial_2_log_glm

Submission Checklist

[x] Run unit tests: ./runTests.py test/unit
[ ] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
Adds primitive for Neg_binomial_2 regression with log link function.
Intended Effect:
Speed up such regressions.
How to Verify:
Run performance test (commented out in unit test file).
Side Effects:
Fix typo in Logistic Regression primitive.
Documentation:
Copyright and Licensing
Matthijs Vákár
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Jenkins, test this please.

According to my tests, this is >6 faster than a similar regression built from existing primitives (using neg_binomial_2_log_lpmf).

Jenkins, ok to test.

Hi @seantalts , as far as I'm concerned this is done and can be merged.

Hey, there was a change recently such that now cpplint runs on test files as well, and this is failing there: http://d1m1s1b1.stat.columbia.edu:8080/job/Math Pipeline/view/change-requests/job/PR-658/2/execution/node/23/log/

OK, I've satisfied cpplint for the test as well now.

Jenkins, retest this please.

This is now ready to be merged, pending a decision on whether to remove the unaryExpr and binaryExpr.

Thanks again for all of these! Beautiful.

Regarding https://github.com/stan-dev/math/pull/658#discussion_r150299248, symbolic derivatives use much less memory than autodiff as there's nothing in the expression graph but the inputs and output.  Because the calculations are compiled with double values, they're almost always faster because autodiff is essentially interpreted.  Now having said that, the autodiff algorithm isn't bad and it does the dynamic programming right if you happen to use shared computations in the code being autodiffed.

Why is this:
[](T_partials_return xx, T_partials_return yy) {
  return log_sum_exp(xx, yy);
}

written this way rather than with const T_partials_return& as the argument?

@bob-carpenter , could you explain a bit? I'm quite new to C++ and am not familiar with proper use of const and passing by reference. Would this speed things up?

@VMatthijs Could you take a quick look at the merge conflict here in the includes? I think we want scalar_seq_view still, not sure about the others...

Hi @seantalts , I just had a look at it:
#include <stan/math/prim/scal/fun/size_zero.hpp>
doesn't even exist anymore so it is not needed;
#include <boost/random/bernoulli_distribution.hpp>
is not needed;
#include <stan/math/prim/scal/meta/scalar_seq_view.hpp>
should be required; I must've accidentally deleted it.
The real mystery though is why the code still runs as it should be required. I just tested it and it runs just fine. Moreover, it seems that the only includes I cannot delete are
#include <stan/math/prim/scal/meta/partials_return_type.hpp> and
#include <stan/math/prim/scal/meta/include_summand.hpp> .
Then it complains, but all the others seem redundant. Do you have any idea why that might be?
Thanks!

So good practice is to be explicit about what you need via including the
files. But the way C++ is compiled is essentially concatenating everything
included (recursively) into one giant file. So as long as something else
you rely on includes the stuff you use, it will compile.
On Tue, Nov 14, 2017 at 10:35 Matthijs Vákár<EMAIL_ADDRESS>wrote:

Hi @seantalts https://github.com/seantalts , I just had a look at it:
#include <stan/math/prim/scal/fun/size_zero.hpp>
doesn't even exist anymore so it is not needed;
#include <boost/random/bernoulli_distribution.hpp>
is not needed;
#include <stan/math/prim/scal/meta/scalar_seq_view.hpp>
should be required; I must've accidentally deleted it.
The real mystery though is why the code still runs as it should be
required. I just tested it and it runs just fine. Moreover, it seems that
the only includes I cannot delete are
#include <stan/math/prim/scal/meta/partials_return_type.hpp> and
#include <stan/math/prim/scal/meta/include_summand.hpp> .
Then it complains, but all the others seem redundant. Do you have any idea
why that might be?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/658#issuecomment-344297109, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7AxkqO81zWpXdh7xwG8z9-vEC44Jks5s2bNYgaJpZM4QFAiL
.

Thanks for explaining! That makes sense!

Seems like you might need some new size_zero


create session class to hold objects

thinking through the basic framework used in Pyxy3D. Core classes are made as granular as possible with dependency injection to build increasingly complex levels of functionality.
But then the GUI will only interact with the session object which will load/manage/save all of these various elements.

I'm wondering if this needs to be the next step. I don't know. This might still be a bit too big and unweildy...

session should be able to query openrouter for available models and remaining key budget

no longer the direction things are headed.


Cannot edit text

Hi,
I'm using this as such
               <EditableLabel text={hotspot.title}
                    labelClassName='title'
                    inputClassName='title'
                    inputWidth='200px'
                    inputHeight='20px'
                    inputMaxLength={50}
                    onFocus={this._handleFocus}
                    onFocusOut={this._handleFocusOut}
                  />

But the label is not editable. No characters show when I type. The value comes from state. What am I missing?

Hi it brings up input editor.. but cannot change text. It's something else React related I had this fixed without my hack and it's come back.

I have to hold the mouse down to edit it

It's because it's in a draggable. My bad.


Implements workflow repo

Describe your changes and why you are making these changes
This PR implements the workflow repo.
Key Decisions

Each table's table name and column names are placed in the relevant model file. Ex: models/workflow.go. This is how the implementation in repos will have access to the column and table names.
A helper method is used internally for querying one or multiple models. Ex: getWorkflows and getWorkflow

Related issue number (if any)
ENG 1901 and 1902
Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan I'm working on a PR rn to setup the integration tests. We can merge these PRs once the tests have been implemented and are passing.
The final PR for each collection will be to replace the existing reader and writers used by each server Handler with these new repo objects.


Typescript compilation fails

Steps
Compile with typescript 2.6.1
Expected Result
No errors
Actual Result
All components give error similar to following:
[ts]
JSX element type 'Component<MenuProps, ComponentState>' is not a constructor function for JSX elements.
  Types of property 'render' are incompatible.
    Type '() => ReactNode' is not assignable to type '{ (): ReactNode; (): string | number | false | Element | Element[] | ReactPortal; (): string | nu...'.
      Type 'ReactNode' is not assignable to type 'string | number | false | Element | Element[] | ReactPortal'.
        Type 'true' is not assignable to type 'string | number | false | Element | Element[] | ReactPortal'.

Version
x.y.z
Testcase
This is with types/react 16.0.25

Please make a minimal reproduction repo.
I've tried rokoroku/react-redux-typescript-boilerplate with manually updated deps:
{
  "devDependencies":  {
    "@types/react": "^16.0.25",
    "typescript": "^2.6.1"
  },
 "dependencies": {
    "semantic-ui-react": "^0.76.0"
  }
}

All compiled without errors and warnings.


Rectangle showArea option

Added an option to showArea on Rectangles. Defaults to true. Also updated the README with the new option and added the showRadius option to the docs as well (it was in the code already, but not documented).

@kingfisher13 I've introduced this with v0.4.3 - forgot to reference this PR 😭

@ddproxy Great! Thanks. I guess I'll survive the loss of not having my name associated in a small way with this great library. 😭


[BUG] org.opensearch.snapshots.DeleteSnapshotIT.testDeleteShallowCopySnapshot is flaky

Describe the bug
The test fails intermittently. Build where it failed: https://build.ci.opensearch.org/job/gradle-check/37349/testReport/
Related component
Storage:Snapshots
Expected behavior
The test should not fail unless there is issue

Related to #9115

[Triage - attendees 1 2 3 4 5 6 7]
@jainankitk Reopening the previous issue as the call stack looks the same as was previously reported.


Fix clamping for nested elements

Fix clamping for nested elements by ensuring that some core function is always called with an Array, not a NodeList.
The new example from the index.html includes an example that would cause an Exception without the newly added code. I figured that the internal method findBestFit is sometimes called with an Array, and sometimes with a NodeList. Since the latter does not implement the same methods (like slice) an error is raised.

I guess this was accidently broken when moving from a jQuery to a vanilla JS implementation:
https://github.com/makandra/superclamp/commit/506b609c5d14d5de571251098c3bdb578b4fde02#diff-1c2c0eb52d18a088fe5dfb45f1bd5382L319


main-highlighter.zsh: hang when highlight word matches dead remote mount in pwd

Brief Description
In some circumstances, the main highlighter can hang the shell. This can occur when the word being typed matches a directory in $PWD, and that directory is a mounted remote filesystem (NFS in this case) which has since died (mounted but non-responsive). Adding the directory to X_ZSH_HIGHLIGHT_DIRS_BLACKLIST has no effect.
Steps to replicate

Create directory in $PWD with any arbitrary name (eg. ~/myoldhost)
Mount an NFS share to this directory
Make the NFS share non-responsive (in my case: break networking on remote host)
Attempt to type a command where an argument happens to be the same name (eg. ssh myoldhost)

Expected result
Command to be successfully entered and ready to execute
Actual result
Shell hangs before last character appears
Details
This appears to be caused by the highlighter attempting to probe the named directory, in some cases regardless of whether the argument is a directory/path type, while the mount is dead. Because the system still sees it mounted, the probe is queued waiting for a response resulting in the shell hanging waiting for the syscall to return.

Fixed with #529.


Make Api::patch simpler (continuation)

Continuation from #380
I felt there was a simplification there from @MikailBag . Tests might not universally pass yet, but I've fixed it for crd_apply.rs example.

IMHO it's really easier to use than #380. Should I close that PR?

IMHO it's really easier to use than #380. Should I close that PR?

IMHO it's really easier to use than #380. Should I close that PR?

Yeah, may as well. I have already taken all your commits in here.
Glad we are on the same page :-)
Will merge this later today.

IMHO it's really easier to use than #380. Should I close that PR?

Yeah, may as well. I have already taken all your commits in here.
Glad we are on the same page :-)
Will merge this later today.

Released in kube 0.48.0

Released in kube 0.48.0


[stable/redis-ha] haproxy unable to set NodePort

Describe the bug
I want to connect to redis (haproxy) outside the kube cluster, so I change the redis port (for example to 30204) and set haproxy.service.type to NodePort.
Then the redis slave device cannot connect to the master device and all redis nodes will restart.
It seems to me that this is because the default redis port has been hardcoded in several files and although I change the pods port it still connects to the default.
Which chart:
stable/redis-ha 3.7.3
What happened:
Redis wont start
How to reproduce it (as minimally and precisely as possible):
Change default Redis port (for example to 30204) and set haproxy.service.type to NodePort

@kfkawalec Good suggestion. I hadn't considered people wanting to change the HAProxy exposed port.
The Redis port is hard-coded in the HAProxy configmap right now:
    # decide redis backend to use
    frontend ft_redis
      bind *:6379
      use_backend bk_redis

We can change it pretty easily to be flexible. I'll have a look see if I can get this in.


Error Handling

Is there a way to handle errors other than infinite retries? For example, if I search a page where an element does not exist, can it timeout rather than retry infinitely?

This is already baked into context...
eg: ctxt, cancel := context.WithTimeout(context.Background(), 5*time.Second) 	defer cancel()


Moment.js.2.14.1.nupkg File contains corrupted data

Hi,
After installing the new release yesterday, I can no longer install/update any other package.
I get this error in the package manager console.
Unable to read package from path 'Moment.js.2.14.1\Moment.js.2.14.1.nupkg'.
File contains corrupted data.
I am using VS2015, nuget <IP_ADDRESS>8
Regards

@corydeppen hey, I released 2.14.1 from a mac, using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Can you have a look, because I did experience trouble publishing the nuget from the website with some issue about dates in the future, but I did managed to push with the CLI (grunt package).

After extraction the content with 7zip, I noticed a difference:
2.13.0

Content
- Scripts
- moment.js, etc

2.14.1

Content%5CScripts

moment.js , etc

I just packaged it myself and the file structure looks good.
Moment.js.2.14.1.nupkg.zip

I guess there should be a 2.14.2 as soon as possible otherwise this problem can affect a lot of people.
Nuget in VS2015 simply does not install/update any packages because this one is corrupted.
So there is really to manual solution:
1 -
in the folder \packages\Moment.js.2.14.1 replace the .nupkg with the new one.
2-
edit packages.config
from
to
and wait for a new release.

@vascofernandes Are you using nuget.exe 3.4.4?

yes, I did create the new nupkg with nuget.exe 3.4.4.
Regards

@ichernev Can you try updating nuget.exe to 3.4.4 and see if that resolves the issue?

I pushed 2.14.2, I packaged on my own after deflating, and fixing the dates. @vascofernandes @corydeppen can you give it a try?

I was using <IP_ADDRESS>16 -- that came with grunt-nuget. And the Mac nuget had the right version but apparently can't create a zip file properly.

Hi
2.14.2 is still not packaged correctly.
Just compare the contents of 2.13.0 and 2.14.2 and you'll see the the Content folder is missing.
Regards

I just created a package locally using nuget.exe 3.4.4-rtm-final and the Content folder appears as I'd expect. I did run into the File contains corrupted data message as originally reported, but I was able to get around it by deleting the Moment.js.2.14.1 folder in the packages folder, uninstalling moment, then installing the version I just created.
I don't mind pushing a new version manually, but I'm concerned about bumping the version because it will a) be further out of sync with the other package managers, and b) require the next release to have knowledge of this out of sync version number. Bumping it follows semver, so I guess the next release may need to take this into account.
Please let me know if you'd like me to push a new release.

@corrydeppen -- you can use grunt bump_version:2.14.3, then grunt release, and use that to build/deploy version 2.14.2 only for nuget.

@ichernev Following grunt release it looks like grunt nuget-publish should be called to push to NuGet - correct?

@corydeppen well, this uses some obscure NuGet.exe that is shipped with grunt-nuget, so I wouldn't count on it too much, or at least check if the version is ok. My linux box used to work but now it doesn't, so it might be caused by a bad version there.
Other than that -- yes. You can do grunt nugetpack, and verify that the produced package is good. Then grunt nugetpush.

2.14.3 has been pushed. I was able to install it into a project without an issue.
Turns out the nugetpush task was failing using the current nuget.exe (3.4.4). I discovered there's a new mandatory Source option for the push command. I'm planning to log an issue in the grunt-nuget repository asking for nuget.exe to be updated as well as adding a way to pass an argument for Source.

@corydeppen thank you so much!
Now I figured out what happened with 2.14.2 -- I tried to zip it manually but evidently the first argument to zip is the target file, which happened to be Content, and it was not included in the zip itself. I did figure out the -Source argument, at least with the new nuget on my mac. On the linux box I was stuck with some old nuget, which was still producing dates in the future, so I tried to fix it with the manual zip.

2.14.3 seems to be working Ok for now..

I think this can now be closed. 2.14.3 works Ok.
Regards

Closing since everybody seems happy with 2.14.3. Thanks Iskren and Cory.


As a developer I'd like a standard interface for adding data to tables on the server

Feature Request
For editing data on the server, we'd like to use a similar mechanism as we use with menu actions, where the UI can use generic callback functions for setting data into particular fields. On order to do this we would need a workflow something like the below.
Client                                                                                Server
------                                                                                ------
* Invoke Menu Action (ex. SetSeqNum). =>                    SetSeqNum on server rpc service gets called
                                                                 <=                     Server returns an instruction to OpenAndEditViewPort(tablename, form)
* UI Sends CREATE_VP_REQUEST on named table  =>
(and renders into specified form)
* UI sends generic instructions to setdata                 =>
(ex. VIEWPORT_SET_CELL (key, column, value)
each time a user modifies a value,
this puts the data on the server
* When editing is complete, UI sends VP_SUBMIT_FORM  => this invokes a specific onFormSubmit call on the server side, the server then gets the data from the table and sends it further on.

The key to this approach is that all the calls for the UI are generic, it doesn't have any extra definition for the calls.

If we want to keep this entirely generic, and want a reasonable user experience, we need the ability to send a few additional pieces of metadata to the client.

a title for the dialog that will be displayed
some kind of explanatory text to present to the user so they understand what they are being asked to submit
a user friendly label for each form field UI displays

Few more things we may want to specify for each field:

Label (different from protocol field name)
Help text (description)
Enum choices or autocompletion list
Optional/mandatory (separate from validation, as you want display indication too)
Validation (regex?, standard patterns?, groups?) - alternatively, the validation may be a roundtrip to the server side

All except the last bullet are present in the form metadata for our PoC.


404 in the readme

The tutorials link on the homepage is https://rustwasm.github.io/book/tutorials.html and it's 404

Fixed in 784b52d -- thanks for reporting!


:: in package name produces weird error

Including :: in the package name on Windows 10 gives the following error:
The filename, directory name, or volume label syntax is incorrect. (os error 123)

If the first two lines of my Cargo.toml are:
[package]
name = "library::core"

I get the above error. If I replace them with:
[package]
name = "library-core"

The package builds correctly.

Windows doesn't allow : (and some other characters) in file/folder names so it's probably good that cargo stops you from this. Idk if there could be a way around this. https://support.microsoft.com/en-us/kb/177506

I don't think there needs to be a way to work around this if the error message is improved to something like package name "library::core" may not contain ":".

So, it's easy enough to add a better error message for this by just validating the name when constructing a package id. But uh...are there rules somewhere about what constitutes a valid name?
But what are the actual rules? Is it just the union of all invalid path characters on all supported platforms are invalid characters in package names?

But what are the actual rules?

It depends on the scenario.

For rustc, the only restriction is that it contains alphanumeric or _ characters.
If publishing on crates.io, then the restrictions are:

Must match regex [A-Za-z][A-Za-z0-9_-]*
Max 64 chars.
Not in the reserved listed (which I think is currently): alloc, arena, ast, builtins, collections, compiler-builtins, compiler-rt, compiletest, core, coretest, debug, driver, flate, fmt_macros, grammar, graphviz, macro, macros, proc_macro, rbml, rust-installer, rustbook, rustc, rustc_back, rustc_borrowck, rustc_driver, rustc_llvm, rustc_resolve, rustc_trans, rustc_typeck, rustdoc, rustllvm, rustuv, serialize, std, syntax, test, unicode, nul, con, prn, aux, com1, com2, com3, com4, com5, com6, com7, com8, com9, lpt1, lpt2, lpt3, lpt4, lpt5, lpt6, lpt7, lpt8, lpt9

For cargo init or cargo new:

Is alphanumeric or _ or - (dash is converted to _ when passed to rustc).
Must not start with a number.
Must not be in the reserved list (which is oddly not the same as crates.io):

Rust keywords: abstract, alignof, as, become, box, break, const, continue, crate, do, else, enum, extern, false, final, fn, for, if, impl, in, let, loop, macro, match, mod, move, mut, offsetof, override, priv, proc, pub, pure, ref, return, self, sizeof, static, struct, super, test, trait, true, type, typeof, unsafe, unsized, use, virtual, where, while, yield,
If it is a binary, cannot be: deps, examples, build, native, incremental

(I'm not 100% certain on this list, but I believe it is correct from looking at the code.)

So it seems like the sanest thing to do here is just to restrict the package name at parse time to the same restrictions it would have as a package name for cargo new? That seems like a pretty reasonable restriction, though it could break existing packages somebody has manually created, which would still successfully build with Cargo as long as they didn't contain invalid path characters.
I'll put together a PR for that and it will at least spur discussion, I guess!

Actually, on further thought, it seems like the most straightforward and least potentially broken thing to do is just restrict it to alphanumeric characters, _, and -. That satisfies the rustc case, adds no additional restriction, and removes the potential for broken paths which was the original point here.


Add a few signatures around window messages (CreateDialog, PeekMessage, DefWindowProc, ...)

With this signatures we can use rc.exe to compile a windows dialog, embed
it as a resource in a .Net executable then load and display it.
There is a working minimal sample in this repository :
https://github.com/vbfox/PInvoke.Forms.Test

Looks good. I'd love to learn about that Pack=2 question I asked above though.
I filed a support request with GitHub regarding the poor diffing in this PR.
Please merge when ready.

we can use rc.exe to compile a windows dialog, embed it as a resource in a .Net executable then load and display it.

Super cool, BTW.

Super cool, BTW.

It was a fun experiment, the only problem I found was that I need to manually add a #include <windows.h> each time the Visual Studio editor edit the dialog resources for them to build. I suspect the editor generate includes depending on the project type or some default configuration that C# projects are lacking (In fact I was happy to get the editor to show itself at all, I was expecting to have to craft the file by hand).


如何在代码中动态指定持久化到哪个storage中？

Describe the bug
如何在代码中动态指定持久化到哪个storage中？
Reproduction
11
System Info
11

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible of the bug.

As it is, I do not see a proper solution that would work all the time. Maybe doable with a custom storage ?

As it is, I do not see a proper solution that would work all the time. Maybe doable with a custom storage ?

maybe we can try to receive a reactify variable to achieve dynamic settings.

As for now this cannot be achieved in a "clean" way, maybe this can be considered for an eventual v4, but that would require running a function to return the storage everytime the persistence is called, and giving access to lots of things from this function.
Closing this for now but i'll consider it if v4 ever sees the light 🙏


Critical cases

Other api's do have critical cases, but this api not. Any alternative source?

Why no filter on contents? ASia, africa etc

Also many countries. Togo for example does not have any data. Why is his? Is it because there are no reported cases in Tonga, Tuvalu, Tajikistan etc ?

Hi @danman12345

I've seen a few API's showing critical count but there hasn't been any evidence of it being reliable. We are currently with Johns Hopkins data as this is the most accurate one which I could find.
If you have any data source in mind let me know, I'll be glad to test it out and also possibly integrate

That's a very good suggestion. We are working on v2 of the APIs with a few more endpoints and plan to get it out by coming Tuesday. Will surely have this in it

Yes, if a country does not feature in the list then there are no records of it. Just to be sure, I checked for Tajikistan and here is a link which confirms the same

Thank you for the feedback.

Thanks , But lots of countries do have data, while they have cases.

one is PRI (puerto rico).
Here are more ISO -3 codes that are not reachable here some have cases:

ASM
BMU
SLB
CYM
COM
COK
GUF
FLK
FSM
PYF
GRL
GUM
PRK
KIR
MTQ
MSR
NCL
NUI
ABW
AIA
HKG
MNP
FRO
GIB
IMN
MAC
PSE
MYT
ALA
NFK
CCK
ATA
BVT
ATF
HMD
IOT
CXR
UMI
VUT
NRU
REU
LSO
TKL
TON
TUV
TKM
VGB
VIR
WLF
WSM
GLP
ANT
PCN
PLW
MHL
SPM
SHN
TCA
SJM
MAF
BLM
GGY
JEY
SGS

I do not know any data source that I can get the critical cases, but i have seen it for example here:
https://www.worldometers.info/coronavirus/
Thanksfor the updates! keep ur the good work!

HEllo. How are you, You wrote a couple days ago:

That's a very good suggestion. We are working on v2 of the APIs with a few more endpoints and plan to get it out by coming Tuesday. Will surely have this in it

Is it about to go online?
THe continents would be great.
Cheers
Danny


npm start problem/issue

<EMAIL_ADDRESS>start /Applications/MAMP/htdocs/react/ReduxSimpleStarter
node ./node_modules/webpack-dev-server/bin/webpack-dev-server.js

events.js:182
throw er; // Unhandled 'error' event
^
Error: getaddrinfo ENOTFOUND localhost
at errnoException (dns.js:50:10)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:95:26)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node ./node_modules/webpack-dev-server/bin/webpack-dev-server.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/shikongo/.npm/_logs/2017-06-13T04_45_44_375Z-debug.log

+1

got it working by installing yarn
and adding host:8080 to my webpack.config.js
devServer: {     historyApiFallback: true,     contentBase: './',     host:8080   }


Brackets does not open the browser to perform Live Preview on installations via Snap packages.

Prerequisites

[x] Can you reproduce the problem with Debug -> Reload Without Extensions?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?
[x] Did you read the Troubleshooting guide?

Description
When using Brackets using Snap Packet Installation, Live Preview does not work correctly.
Steps to Reproduce

Install Brackets via Snap package (in my case I installed on Ubuntu 17.10);
Open an HTML file in the Brackets application;
Press the Line Preview button (highlighted by the lightning bolt icon in the upper right of the application);
The icon modifies its color to show that it is enabled, but does not open the browser to perform the Live Preview.

Expected behavior: [What you expected to happen]

A new browser window with a new tab to open Live Preview.

Actual behavior: [What actually happened]

The new browser window is not displayed for Live Preview.

Versions

Brackets -- sprint 11 version 1.11.0-17524 (release 86b5e2d4e);
Linux Ubuntu 17.10.

Hi @erickmajor
I saw this problem, so try it.
While I was looking for a solution, I knew one fact.
According to another user's github comment, while Brackets is not available as a Snap Package, the Linux Friendly fork Brackets-Electron is available as a similar Universal AppImage.
More information about Brackets-Electron and installing the AppImage is available at my

[ https://nathanjplummer.github.io/Brackets/ ] Brackets  Linux Installation Guide.

Hi @JungGaBin, thanks for the reply!
I'm using this version while the Brackets Snap is not yet stable. Ubuntu allows both to coexist without influencing each other. The Brackets Eletron had another bug that made it unusable in Ubuntu 17.10, but now it has a correction allowing its use.
Is there any provision for fixing this bug in Brackets Snap?
Thank you in advance.

Hi @erickmajor. Sorry to answer late.
I searched a lot for the regulations, but there was not much information about that.
So I actually tried, but I could not find it.
If you know the answer, please let me know.
I'm sorry for not getting the perfect answer.

Hello @JungGaBin, thanks for the reply.
I have not looked at the Brackets source code with caution. I'm still new to Snap packages.
For the little that I know, I believe it may be the lack of connection to the environment, just like the application Gradio does. In this way, Brackets would find the Google Chrome browser installed on the system (Live Preview option) or the browser used by the system (experimental Live Preview option) and would enable this functionality.
I recommend that you contact Häcker Felix to resolve this issue. Meanwhile, I follow the development of this solution and add some observation if I get some success in developing the fix.

Thank you @erickmajor  👍

Hello @JungGaBin!
Any news?

Hello , @erickmajor
I have tried, but nothing has improved.

Hi @JungGaBin, no problem.
I await the correction of this bug.

I'm facing the exact same problem on the same OS. Weird thing is that it used to work just fine but now after a couple of month when I was going to use this app, it disappointed me.

Had the same issue, turned out I just needed to choose "Enable Experimental Live Preview" option from File menu. Now it is working again.

Issue still happening as of today on Ubuntu 20.04 but enabling experimental live preview as @dariushm2  mentioned works.
Would be great if Brackets can recognize it's running as a snap and auto enable this feature.


Fix #495 - Bump ansible version to 1.9.4

lgtm as far as it is compatible with our current version of docker-py

I road tested provisioning a new cluster on it, which appeared to work out OK


Provide visual indication in frontend when the Starlark script succeeds/errors

Background & motivation
Right now, it's unclear when the Starlark script is done, or a step is just taking a while.
Desired behaviour
When the Starlark script succeeds, I get a green indicator indicating that the Starlark is done. If it fails, I get a red indicator showing that it errored.
A nice design might be, having a thing under the log display with three states:

Running...
Succeeded
Failed

How important is this to you?
Nice to have; this feature would make using Kurtosis more enjoyable.

Even better idea: show the progress bar

Done


Prism.lex mismatches on Heredoc with comment <<~EOM # comment

I ran the lexer on every ruby file I had locally and found one failure. Prism fails on the seeds.rb file in rubygems/rubygems.org.
The minimum failing snippet reduced from that file is:
<<~MESSAGE # rubocop:disable Rails/Output
MESSAGE

bin/lex output:
nil   [[3, 0], :on_nl, "MESSAGE\n", BEG]   [:EOF, [50, 0]]

An interesting thing about this bug is that the original file (but not this snippet) causes bin/lex itself to fail with a NoMethodError, but only if you run the whole file. I submitted a patch for the necessary fix that allows you to see the actual mismatch: #1873.
If you would like to cause the failure in bin/lex also, then use this snippet. Adding text inside the heredoc causes Prism.lex to return nil (with the patch in #1873) or crash (without the patch) instead of showing [:EOF, [50, 0]].
<<~MESSAGE # rubocop:disable Rails/Output
  hello
MESSAGE

bin/lex output (with the fix in #1873)
nil   [[4, 0], :on_nl, "  hello\nMESSAGE\n", BEG]   nil

This is a possible solution, though I don't know if it will have implications. I'm making the assumption that this is very much an edge case cause specifically by the comment coming immediately after the heredoc end, so I'm only excluding the extra on_nl token only in this specific situation.
diff --git i/lib/prism/lex_compat.rb w/lib/prism/lex_compat.rb
index b6d12053..9f4d4749 100644
--- i/lib/prism/lex_compat.rb
+++ w/lib/prism/lex_compat.rb
@@ -724,6 +724,7 @@ module Prism
             Token.new([[lineno, column], event, value, lex_state])
           when :on_eof
             previous_token = result_value[index - 1][0]
+            before_token = result_value[index - 2][0]

             # If we're at the end of the file and the previous token was a
             # comment and there is still whitespace after the comment, then
@@ -732,7 +733,7 @@ module Prism
             start_offset = previous_token.location.end_offset
             end_offset = token.location.start_offset

-            if previous_token.type == :COMMENT && start_offset < end_offset
+            if previous_token.type == :COMMENT && before_token.type != :HEREDOC_END && start_offset < end_offset
               if bom
                 start_offset += 3
                 end_offset += 3


Design new information architecture

Consider the existing information architecture, and apply improvements/refinements as necessary.
Current interpretation here

Consider new elements:

information provenance
date last modified (hmm, maybe take from document modified date if at concept level)
lower level protective marking (paragraph)
links to documents of supporting content

Pursuing new structure, as documented here:


Error in an OSGI bundle when trying to acquire a token, "failed to create an XPathFactory."

Hi :)
We fixed the issue, but who knows, other people might have the same problem, so please find our findings below, it might help other people.
Kudos to my colleague Devraj who found out. He will give in a comment more accurate details, as I'm just a UI developer who just plays with Java.
So long story short, we have a server running with OpenJDK 11 and OSGI.
We have a bundle that uses msl4j to acquire a token, so something like that. the code will not work correctly of course, it was just a test:
    @Action(scope = Scope.PUBLIC)
    public String azureToken(
            @ActionParameter(name = "scope") @NotBlank String scope,
            @ActionParameter(name = "authority") @NotBlank String authority,
            @ActionParameter(name = "clientId") @NotBlank String clientId,
            @ActionParameter(name = "username") @NotBlank String username,
            @ActionParameter(name = "password") @NotBlank String password
    ) throws Exception {
        Set<String> scopeSet = new HashSet<>();

        scopeSet.add(scope);

        PublicClientApplication pca = PublicClientApplication.builder(clientId)
                .authority(authority)
                .build();

        UserNamePasswordParameters parameters =
                UserNamePasswordParameters
                        .builder(scopeSet, username, password.toCharArray())
                        .build();

        // Try to acquire a token via username/password. If successful, you should see
        // the token and account information printed out to console
        CompletableFuture<IAuthenticationResult> call = pca.acquireToken(parameters);
        IAuthenticationResult res = call.join();

        return "ok";
    }

Problem:
At runtime, the code was failing in the call.join() with this error message:
java.lang.RuntimeException: XPathFactory#newInstance() failed to create an XPathFactory for the default object model: http://java.sun.com/jaxp/xpath/dom with the XPathFactoryConfigurationException: javax.xml.xpath.XPathFactoryConfigurationException: No XPathFctory implementation found for the object model: http://java.sun.com/jaxp/xpath/dom

The "funny" part is that on some servers it worked, on some it did not and it took us quite some time to figure it out.
Devraj will give more clear details, but in a nutshell when using CompletableFuture the OpenJDK code will using common pool rather than spawning a new ThreadPerTaskExecutor IF the the number of cpu is > 2.
https://github.com/openjdk/jdk11u/blob/73eef16128417f4a489c4dde47383bb4a00f39d4/src/java.base/share/classes/java/util/concurrent/CompletableFuture.java#L429
    private static final boolean USE_COMMON_POOL =
        (ForkJoinPool.getCommonPoolParallelism() > 1);

Later used in:
    private static final Executor ASYNC_POOL = USE_COMMON_POOL ?
        ForkJoinPool.commonPool() : new ThreadPerTaskExecutor();

On some of our QAs environments we did not see the issue because they had only 2 CPUS.
Since getCommonPoolParallelism() returns the number of CPU - 1 (something like that), on our QA system we would not see the error because we would use a new ThreadPerTaskExecutor.
In our case, using the common pool triggered the error because the thread context is different. It is bundle in our "default" thread or in a new ThreadPerTaskExecutor() and it is basically the "jvm default context" when using the common pool. So our specific jar files could not be found in the common pool thread context.
We could have added some jar files in the JVM library path, but it would not have solved the issue if the jars were inside the OSGI bundle for example.
Workaround:
The workaround Devraj found is to force not using the common pool but an ExecutorService to the pca object, so something like that:
    private static final ExecutorService executorService = Executors.newFixedThreadPool(1);
// (...)
        PublicClientApplication pca = PublicClientApplication.builder(clientId)
                .authority(authority)
                .executorService(executorService)
                .build();

"full" code:
// LMA:: Necessary for the workaround.
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;

public class Azure {
    // LMA:: Necessary for the workaround. You can change the number of threads.
    private static final ExecutorService executorService = Executors.newFixedThreadPool(1);

    @Action(scope = Scope.PUBLIC)
    public String azureToken(
            @ActionParameter(name = "scope") @NotBlank String scope,
            @ActionParameter(name = "authority") @NotBlank String authority,
            @ActionParameter(name = "clientId") @NotBlank String clientId,
            @ActionParameter(name = "username") @NotBlank String username,
            @ActionParameter(name = "password") @NotBlank String password
    ) throws Exception {
        Set<String> scopeSet = new HashSet<>();

        scopeSet.add(scope);

        // LMA:: The workaround is to add an executorService to the pca object.
        // Original code:
        // PublicClientApplication pca = PublicClientApplication.builder(clientId)
        //        .authority(authority)
        //        .build();

        // LMA:: Adding the executorService to the pca object:
        PublicClientApplication pca = PublicClientApplication.builder(clientId)
                .authority(authority)
                .executorService(executorService)
                .build();

        UserNamePasswordParameters parameters =
                UserNamePasswordParameters
                        .builder(scopeSet, username, password.toCharArray())
                        .build();

        // Try to acquire a token via username/password. If successful, you should see
        // the token and account information printed out to console
        CompletableFuture<IAuthenticationResult> call = pca.acquireToken(parameters);
        IAuthenticationResult res = call.join();

        return "ok";
    }
}

Hope this helps someone :)

Thank you Laurent for mentioning me, though you have introduced me to this library and the current use case.
Laurent has covered the entire picture here. I will add the few remaining details.
The PublicClientApplication.acquireToken(UserNamePasswordParameters) method uses one of the methods below to execute the request

CompletableFuture.supplyAsync(Supplier)

CompletableFuture.supplyAsync(Supplier, Executor)

depending on whether the builder of the PublicClientApplication instance was provided with an Executor or not.
The problem with not providing an Executor, as seen in our case, was that CompletableFuture will use ForkJoinPool.commonPool() if the parallelism is greater than 1, which is true when the number of processors in the JVM environment is greater than 2. ForkJoinPool worker threads do not have the same context ClassLoader of the calling thread. So, the context ClassLoader of the worker threads may not have access to the classes provided or accessible from the calling thread context, as it happened in our case.
So, if there is a similar issue when acquiring the token, it would be recommended to provide the PublicClientApplication builder with a custom Executor. ForkJoinPool.commonPool() is great for executing tasks and we have used its advantages in other scenarios, but does not seem to be in this current scenario.

Hey @lmame and @devr-b , thanks for all this info! We've had a couple users report other issues when using OSGI, so I'm sure there are other users who will run into this issue.
We'll definitely get this workaround into our documentation/error messages to try to help anyone else who encounters this, and will look into adjusting our default executor setup so hopefully a workaround isn't needed.


adding google analytics to the web app

Coverage remained the same at 72.04% when pulling e2cbfffad191e48295ca3bfda3e4144439f7a024 on GA into 0d9c559e7b62f4936d4edfec2cbc089b749ea6a5 on master.


[shuffle] add n_reducers and reducer_ordinal to shuffle operands

What do these changes do?
This PR add n_reducers and reducer_ordinal to all shuffle operands, which enable further meta and scheduling optimization for shuffle in future.

Related issue number

#3054
#3040
#2916
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

Can you add some checks to the CheckedTaskPreprocessor or CheckedSubtaskProcessor to make sure all the n_reducers and reducer_ordinal assignments are correct.

Can you add some checks to the CheckedTaskPreprocessor or CheckedSubtaskProcessor to make sure all the n_reducers and reducer_ordinal assignments are correct.

@fyrestone I've added n_reducers and reducer_ordinal checks in CheckedTaskPreprocessor, could you review again?

Could you fix the checks and failed learn ut? Overall the pr looks good to me.


Medtronic Direct: User suspend followed by LGS suspend

Handles situation where a regular user suspend is directly followed by a LGS suspend a couple of minutes later.

Agreed. Thanks!


Jupyter: Importing dace twice partially breaks renderer

After running the same cell twice with import dace, some scripts (popover, fonts) do not reload, and the end result looks like this:

Fixed.


RDK-36108: Add JSPP support

On behalf of @jack-howgate and @filipe-norte-red - adding JSPP support required by webkit 2.28 upgrade activities

@MFransen69  could you please review it as well?


Updating dependencies, refactoring code and tests

Update to the latest dependencies
Refactor files to improve architecture
Add missing info about firmware
Change integration with nyc (stopped working after updates)

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


🎉 HttpPush consumer working in dev

#128  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


PowerBI connection issue

Hello, I'm trying to do testing on powerBI but I get this error , the file pbix is opened  in the background , the error shows that the process name is opened and correct but why the connection is failing?
,NBi.NUnit.Runtime.TestSuite.Power BI : - Data Completeness - Validate Row Count:
System.AggregateException : One or more errors occurred.
----> NBi.Core.ConnectionException : No parent process found with the name 'logs'. Existing parent names were 'logs', ''',.
The connection string used was 'PBIX = logs'

NBi was using a hack to connect to PowerBI and Microsoft refactored some code on this. Right now, NBi doesn't support anymore to connect to Power BI Desktop (the last versions). There is an alternative for this and it's probably available in my other project DubUrl.Adomd I let you check it and potentially work on your fork of NBi. I won't work to fix this.


refactor remove function context impl class

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.56 seconds
stream load tsv:          474 seconds loaded<PHONE_NUMBER>9 Bytes, about 150 MB/s
stream load json:         40 seconds loaded<PHONE_NUMBER> Bytes, about 56 MB/s
stream load orc:          74 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230313114656_clickbench_pr_113572.html


Hard to drag an item when "Open items with a single click" is turned on

Explain the bug
Since the item cannot be dragged before getting activated, when "Open items with a single click" is turned on, you can only right-click onto it, close the context menu, then do the dragging. In File Explorer, the item will be activated when I do a LMB (left mouse button) down onto the file, enabling dragging instantly.
To reproduce

Go to "Settings" -> "Files and Folders"
Turn on "Open items with a single click"
Go to a random directory
Try dragging an item by simply holding down LMB

Expected behavior
The item is dragged
System Information

OS Version: Windows 11 Pro for Workstations 21H2 Build 22000.65
App version: <IP_ADDRESS>

Thanks for this report. This is fixed in latest beta version.


Revert "fix #1154: submit application will accept launch arguments"

Reverts intel-hadoop/gearpump#1167

Revert this, as it is not functional.


Optim does not handle cloned weights

While playing with the example for MarginRankingCriterion at https://github.com/torch/nn/blob/master/doc/criterion.md#nn.MarginRankingCriterion, I noticed that optim does not seem to be able to handle cloned weights and biases, due a size mismatch of the flattened parameters and flattened gradient params. Here's a simple example:
require 'nn'
require 'optim'

p1_mlp = nn.Linear(5, 2)
p2_mlp = p1_mlp:clone('weight', 'bias')

prl = nn.ParallelTable()
prl:add(p1_mlp)
prl:add(p2_mlp)

mlp1 = nn.Sequential()
mlp1:add(prl)
mlp1:add(nn.DotProduct())

mlp2 = mlp1:clone('weight', 'bias')

mlpa = nn.Sequential()
prla = nn.ParallelTable()
prla:add(mlp1)
prla:add(mlp2)
mlpa:add(prla)

criterion = nn.MarginRankingCriterion(0.1)

x, y, z = torch.randn(5), torch.randn(5), torch.randn(5)

parameters, gradParameters = mlpa:getParameters()
print(parameters:size(), gradParameters:size()) -- show size difference

function feval(params)
    local pred = mlpa:forward({{x, y}, {x, z}})
    local err = criterion:forward(pred, 1)
    local gradCriterion = criterion:backward(pred, 1)
    mlpa:backward({{x, y}, {x, z}}, gradCriterion)
    return err, gradParameters
end
optErr = optim.sgd(feval, parameters, {learningRate=0.01})

Which gives me:
 12
[torch.LongStorage of size 1]
 48
[torch.LongStorage of size 1]
luajit: .../share/lua/5.1/optim/sgd.lua:81: inconsistent tensor size at /tmp/luarocks_torch-scm-1-5221/torch7/lib/TH/generic/THTensorMath.c:456
stack traceback:
        [C]: in function 'add'
        .../share/lua/5.1/optim/sgd.lua:81: in function 'sgd'
        example.lua:37: in main chunk
        [C]: in function 'dofile'
        .../lib/luarocks/rocks/trepl/scm-1/bin/th:131: in main chunk
        [C]: at 0x00406260

The example in the documentation uses updateParameters(), which handles the parameter updating differently from optim's addition: see e.g. https://github.com/torch/optim/blob/master/sgd.lua#L81 versus the following in nn/Module.lua:
for i=1,#params do
   params[i]:add(-learningRate, gradParams[i])
end

This is a bit confusing. Of course I could somehow resize the gradParameters in feval, but that doesn't seem to be the right way to do this? I would say that if something works with the simple backward-updateParameters loop it should also work with optim. Am I missing something here?

when you are cloning weights/biases, the usual practice is to also clone gradWeight / gradBias
If you do that, you wont have this issue.

@soumith I have a question on sharing. When I shared weight,bias,gradWeight,gradBias, the model performs forward and backward without any problem. The gradient of  each parameter is correctly estimated. However, when I call updateParameters(), each parameter is updated by too much amount. Say, if you share some layer three times, then the parameter of that layer is subtracted by three times of estimated calculate. It is because each layer calls updateParameter though gradient is summed.
How can I solve it?


fix: just udeps failing

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.04 :warning:

Comparison is base (805de15) 63.73% compared to head (956c2a0) 63.69%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   63.73%   63.69%   -0.04%
==========================================
  Files         137      137
  Lines       27023    27023
==========================================
- Hits        17222    17212      -10
- Misses       9801     9811      +10

Impacted Files
Coverage Δ

modules/fedimint-dummy-client/src/lib.rs
100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I didn't notice this at first, but when checking out the PR I get changes in Cargo.lock after running cargo check, this would happen in every PR building on top of this one.


Words cropping in the tagline 'the free food products database'

Checklist

[x] Bug Report - The issue you are reporting might be there already. Please search on the issues tracker before creating or reporting an issue.
[x] Before reporting, please ensure (if you can) that you have tested it with the latest (dev) version of the software.
[x] Don't forget to tag your issue, it makes it easier to discover.

Summary:
Cropped Title in launch screen and main page
Expected behavior :
The height should be increased a little in the tagline 'the free food products database'
Observed behavior :
The words are cropping a little in the tagline 'the free food products database'
Device and Android version:
OnePlus 5 running 8.1.0
Screenshots:

Hie @snuff4, I tried to regenerate this issue on Google Pixel XL , running 8.1, but couldn't find any such problem. However, if we simply set the height of textview as wrap content and define a textsize then, i don't think that we'll face such kind of issue in future.

Hello @SaumiaSinghal I used the beta version available on the Play Store. Let me build it on my phone on the latest master.
And in the screenshot in #1696, I think the tagline of the logo should be in a single line, like this -

Hie @snuff4, sorry for those unnecessary commits, but actually i was trying to fix the travis build error. But, as that is solved now, please test it with my latest commit. Thanks..:)

@teolemon @huzaifaiftikhar isn't it in a single line?

Yup. Justified with the edges of the barcode

Closed due to issue being resolved.


Add gate.io wallet

It has been verified that the GateWallet wallet plug-in cannot be connected on the PC, and the link cannot be cut after the mobile phone is connected.


Proto transform cleanup

This is cleanup for the prototype transforms. It includes the following changes that were put in individual commits for easier review:

Fix the TenCrop transform. The calls for PIL and simple tensor images were missing the vertical_flip flag.
Use the F.adjust_{brightness, saturation, contrast, hue} dispatchers in RandomPhotometricDistort rather than relying on the ColorJitter transform.
Add a convert_color_space dispatcher and use it in the ConvertColorSpace as well as in the deprecated Grayscale and RandomGrayScale transforms.

As discussed offline, this PR will also replace the apply_recursively calls with torch.utils._pytree.tree_map to avoid custom code.

query_recursively can also be removed, but it is a little more complicated. I'll do that in a separate PR when we have finished porting the transforms.


logging: Is there a way to capture HTTP request data?

Is there a way to capture HTTP request data and have it show up like the appengine request log?

Read http.Request.Body from your Handler and log it?

@fd: There's no way to group the way that App Engine does. IMO, that's one of the most valuable features of GAE and the one I'd like to see duplicated with this package.

Stackdriver Logging v2 allows you to associate an HTTP request with a log entry. We'll have a Go client for logging v2 soon.

I think this is done (logging v2 client is in). @jba plz reopen if I'm wrong.


Scoped storage

In this library it needs READ/WRITE external storage, as a result, we cannot use this library in android 11+. Kindly remove any external library used in this library which uses READ/WRITE external storage
Summary

Code to reproduce

Android version

Impacted devices

Installation method

SDK version

Other information

-scope storage


Discrepancies in first figure of README.md

This linked code in the README.md does not exactly produce the subsequent figure shown in the file. I strongly recommend you adjust the code to include everything needed to reproduce the figure (including any custom rcParams settings) so that new users have a quick and easy way to validate their installation with this realistic use case.
This issue was made as part of the review for https://github.com/openjournals/joss-reviews/issues/6202

Similarly, the code in the documentation page does not reproduce the shown figure:
https://github.com/GalagaBits/JWST-FGS-Spelunker/blob/b0d2cc40c9d8f9872ba1c160bb43765176453de1/docs/simple_quickstart.rst?plain=1#L36-L45

Okay, I have fixed this issue!


Main funcs

Partially refactored app
Main func for spacemesh
Main func for hare

add make commands for each cmd in the make file

please remove empty main file in app


Protocol handler: URL length limits for non-DNS names

(This is a low priority, purely exploratory question)
In the future, distributed protocols may move to hash functions that produce longer outputs (more than 63 or 255 characters), and need to be able to use them in "authority" part of URLs.
I was unable to find formal length limits in WHATWG URL Spec. I know that FQDN length limits exist and are respected by DNS registrars (RFC1034: 63 characters per label, 255 in total), but what are limits for native protocol handler API, which does not formally depend on DNS spec?
Namely:

what is the length limit of "authority" (origin) part ?
what is the length limit of string produced by new URL(...).toString() ?

Good question. We use nsIStandardURL that extends nsIURL that extends nsIURI. Last one mention refers to bunch of rfcs among them to RFC3490: Internationalizing Domain Names in Applications (IDNA)  that as far as I understand suggests 255 limit (quoting inline below):

URI producers should use names
that conform to the DNS syntax, even when use of DNS is not
immediately apparent, and should limit these names to no more than
255 characters in length.

How fathefully we follow that limit, that I do not know (should be easy enough to test). But I'm worried that would be a problema never the less, as OS or some other URL parsers may follow the 255limit.

Does not seems actionable


Correctly specify dependency on typing_extensions

Syntheseus previously depended on typing_extensions without specifying this in the pyproject.toml file, causing a fresh install to fail the tests. This PR fixes this by:

Wrapping the second import of typing_extensions in an if/else block to only run if python < 3.8 is used (otherwise an import from typing can be used directly). This was already present in the first import of typing_extensions.
Modify pyproject.toml to specify that typing_extensions is required, but only if python < 3.8.

(I noticed this issue when investigating #106 )

@kmaziarz the tests are failing in this PR due to a segmentation fault, but this doesn't seem very related to the PR? I've tried re-running 3 times now but it still won't pass. Not sure what's going on here...

Modify pyproject.toml to specify that typing_extensions is required, but only if python < 3.8

My thinking was that we should drop support for Python 3.7 soon anyway; we only maintained it due to being required by GLN, but as of #103 this is no longer the case.
Perhaps we should release 0.5.0 to have a final numbered version that still supports Python 3.7, and then bump the version requirement after that?

Tests are failing in this PR due to a segmentation fault, but this doesn't seem very related to the PR

Yeah, doesn't seem related to the PR. It also happens from main, and seems to also be caused by torch-scatter... 😆 I'll need to take a closer look at what's going on

Update: I don't think the environment issues are really caused by torch_scatter, and rather by the fact that installing syntheseus[all] now reinstalls the torch despite it already being present in the env. This is due to another package updating upstream. I'll send a fix soon although we may want to set things up a bit more robustly in the long term...

Great Kris, thanks for looking into this! I agree about not supporting python 3.7 anymore- that makes our lives a lot easier. Releasing a final python 3.7 version and then dropping support sounds good.

The issue should be fixed as of #108. I think this is not everything, as I also get problems with building torch-scatter as reported in the other issue. I'll look into that too, but I think that's separate, and doesn't seem to happen in CI. At the very least #108 should unblock your PR, which I imagine we still may want to merge in order to get a fully working 0.5.0 version (before we drop support for Python 3.7 and strip out some of the changes from your PR)?

Sounds good, once #108 is merged lets re-run CI, merge this if there are no issues, make a new release, then drop python 3.7 support!

Sounds good, once #108 is merged lets re-run CI, merge this if there are no issues, make a new release, then drop python 3.7 support!

I've rebased the PR onto main now; lets see if the CI passes this time around.

Looks like it passes @kmaziarz. Should I merge?

Seems good to merge, maybe just add a CHANGELOG entry.

Sorry, didn't see your comment re CHANGELOG

@kmaziarz fixed CHANGELOG in #109


Android notifications not showing up when options.at not set

The problem is that we set the default value to:
options.atTime = options.at ? options.at.getTime() : new Date().getTime();

So, by the time the notification is created in NotificationRestoreReceiver.java, it's already in the past.
The solution would be to change that line to:
options.atTime = options.at ? options.at.getTime() : 0;

And in NotificationRestoreReceiver.java check whether atTime is 0. If it is, we just create the notification and do not create any Intent.
Fix coming today.

Resolved.


Handle task retries gracefully in Spark ACID OSS

Tasks writing data into Hive ACID if failed then would be retried like normal Spark Tasks. But if failed task would have created bucket file under delta directory, then new task would fail like specified in this issue: #41
In Qubole's Hive fork are overwriting the file instead of throwing error and hence things work. We need to solve this for Open source.

@amoghmargoor : Currently, does the retried task not start another transaction when trying to write to the table because then it would have created new delta directories before writing into bucket file?

@sourabh912 Task retries should not start new transaction. Different tasks of query will get executed in different transactions in that case which will be contradictory to the meaning of transactions.


silence "no symbols" warnings on apple

Description
This change fixes the "no symbols" warning when building the .ar files with both CMake and Makefile under Mac OS X. This PR superseeds https://github.com/ARMmbed/mbedtls/pull/1600 and adds a ChangeLog entry and ports the change to Makefile.
Status
IN DEVELOPMENT
Requires Backporting
Yes
Mbedtls 2.1:
Mbedtls 2.7:
Additional comments
The change adds an APPLE_BUILD (and APPLE) option for Makefiles. Use the following command to build Mbed TLS on OS X:
make APPLE=1

or
make APPLE_BUILD=1

Note that having both variables APPLE and APPLE_BUILD is analogous to the WINDOWS and WINDOWS_BUILD system, so I have added both to be consistent (though one is redundant).
Todos

[ ] Tests: I tested the change on Linux and Mac, but it would be good to check that the makefiles still work under Windows. Also, I think the CMake change does not take into account setting the - before the options to the archiver as it is the case in make. I am not sure this is a problem though...

@Patater: What command did you run to build the library? It builds without comments in my system. Please note that I have updated the PR description to explain that you need to set the APPLE make variable for it to work (as in make APPLE=1).

And I don't get warnings from the RL step anymore, but it looks like the Makefile changes cause the RL step not to get run anymore. Is APPLE_BUILD correct?

I modified the Makefile so that on Linux the ar and ranlib (RL) steps are executed in a single invocation or ar, thats why if APPLE=1 is not set, then RL is not printed. However, please note that the output archive should be the same in Linux as before the patch because ar is executed with the -s flag.
When APPLE build is set in make, then the ar and ranlib steps are split because some additional flags need to be passed to ranlib to not emit warnings when some object files do not have symbols. Note that this warning occurs when for example a module is disable, so it has no functions but it is still "compiled". Then ranlib finds that there are no symbols for some object files and issues a warnings in OS X.

@Patater: Given that there is a new build option (APPLE) I will wait for the changes to be approved before backporting.

I expected APPLE_BUILD or APPLE to be automatically set, so I just ran make. It's a bad experience to have to manually specify the OS. It should be possible to do something like ifeq ($(shell uname -s),Darwin) from the Makefile and set APPLE_BUILD automatically (with ?= I suppose).

@Patater: I like the idea that the build system will autodetect the underlying OS is apple, but I did not add this because it was not done for Windows. Should I then add the autodetection?

@Patater: I have now added autodetection of OS X in the library/Makefile and removed the APPLE option.

@Patater: Reworked PR according to your comments.

@sbutcher-arm: Building with Makefiles for OS X should work without any issues now. Cross compilation on OS X also works, but because of the autodetection of the underlying system that we have added, we need to tell the makefile to not alter the flags to ar and ranlib. So, make must be executed with APPLE_BUILD=0 in that case, for example:
make APPLE_BUILD=0 CC=arm-none-eabi-gcc AR=arm-none-eabi-ar LD=arm-none-eabi-ld lib

Is that acceptable? Alternatively, a fix for this cross compilation issue would be your suggestion to check the contents of AR, LD and CC, but I that seems fragile to me, so I would prefer to avoid it.
Please note that as far as I can tell, the cross compilation issue is not a problem for our tests. I think all.sh is the only place where such tests are run, but that works only on Linux. The changes have no usage impact on any system except cross compiling on Mac OS X

@Patater @sbutcher-arm: To avoid the problem of having to define APPLE_BUILD=0 manually in the commandline when cross compiling, I added a check to ensure that the apple-specific arguments to the archiver are only set when we are using the system archiver. To do that, the makefile first checks whether it is running under Mac OS X, if that succeeds then it checks if $(AR) == "ar" and if both checks succeed, then APPLE_BUILD is set to 1. In the other cases, (e.g. running under windows, running under linux, cross compiling) the makefiles are expected to behave as it was before without the need of setting any flags.

@sbutcher-arm: Just to clarify:

No further changes/adjustments are necessary for the Makefile builds.
The CMake builds do not correctly support cross-compilation, but this is a preexisting problem. This problem will be addressed in a separate ticket.
CMake builds do not automatically detect they are running on OS X.

Last time I tried this on OS X it was working without having to specify -DAPPLE=On. Also, my understanding from the CMake docs is that the APPLE variable is set by CMake, so there should not be a need to set that on the command line argument to CMake. I will take a look again.
If CMake does automatically set APPLE then there might be issues with the archiver once again under OS X when cross compiling. Should we leave that to be fix when the cross compilation actually works on that build system?

@andresag01 - When I looked into if it was possible to detect OS X, inspecting CMAKE_SYSTEM_NAME  to see if it matches "Darwin", seemed to be the best solution. If it's not possible or practical, I can accept the PR as it is.

@sbutcher-arm:

When I looked into if it was possible to detect OS X, inspecting CMAKE_SYSTEM_NAME to see if it matches "Darwin", seemed to be the best solution

There is a difference between what system CMake is compiling for (CMAKE_SYSTEM_NAME) and what system is running the build (CMAKE_HOST_SYSTEM_NAME). These should be set automatically, but the one we want for this specific change is CMAKE_SYSTEM_NAME as we need to modify the archiver flags only if we are compiling an Mbed TLS binary for OS X.
The APPLE variable should be automatically defined by CMake as well. However the docs for APPLE are confusing because they describe it differently depending on the CMake version you look at. Since this was unclear, I preferred to use CMAKE_SYSTEM_NAME in this PR, this should also help when later on the cross compilation problem is fixed (see here)

@Patater - Could you please re-approve?


modbus.write_register

Home Assistant release with the issue:
0.88.0
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
hass.io
Please provide details about your environment.
just using hass.io to communicate with modbus tcp. reading registers work ok
Component/platform:
modbus service
Description of problem:
Unable to write negative values to registers (example : -100)  error message says value must be at least 0. I dont see the problem to send values below 0
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

Not all manufacturers allow negative values. The implementation doesn't support this.
Please use the forum for a feature request. Thanks.


IPyWidget tests are completely broken on CI

Not sure if they are broken in WebViews.
hence could be a regression in code or merely a regression in tests.

They seem to be ok now


Fix cypress command.

Motivation and context
Periodic test crashes when using Firefox.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Also added fix for case 44 in the form of additional verification when interacting with the dropdown menu.


[enhancement]: Save and Load Canvas As Project / Full Project Management

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
It would be great if we had the ability to save the entire stack of layers (and their settings) all at once, as a single file or image.
Ideally looking for a "Save Project" button, saving the information and settings for Global Reference, Regional Guidance, Control Layers, etc.  May as well include the generation settings also, making it a true project management solution.  Perhaps a save button at the top of the stack next to the opacity drop-down called "Save Canvas As Project".
If we're working on a complex session and then move on to another project, it would be nice to come back to the previous workflow at some point, and still have the settings from that last session, without piecing everything back together.  Invoke could save the projects in the Assets tab, but it would be more sensible to have a Projects tab (or a Load Project button somewhere more conspicuous).
This is similar to the way Photoshop or Affinity files retain the settings and effects in each layer of the document.
Alternatives
No response
Additional Content
No response

It's been on the list since work commenced on Canvas V2, but we didn't have time to implement it yet. I'm not sure when we will get to it, but this is the natural next step for Canvas and would really make it feel like a "proper" application.
This would also provided a solution for the intermediate images issue. Intermediate images are image files created during generation, but not the final output image. Intermediates are not shown int he gallery.
Currently, the canvas's image data is typically stored as intermediate images. If you clear the intermediates, your previous canvas states can't be recalled, which is a major bummer.
With Canvas Projects, we'd save all of the canvas images separately and be able to not worry about the intermediate images.

It's been on the list since work commenced on Canvas V2, but we didn't have time to implement it yet. I'm not sure when we will get to it, but this is the natural next step for Canvas and would really make it feel like a "proper" application.
This would also provide a solution for the intermediate images issue. Intermediate images are image files created during generation, but not the final output image. Intermediates are not shown in the gallery.
Currently, the canvas's image data is typically stored as intermediate images. If you clear the intermediates, your previous canvas states can't be recalled, which is a major bummer.
With Canvas Projects, we'd save all of the canvas images separately and be able to not worry about the intermediate images.

My heart nearly jumped when I saw the Gallery Session and Canvas Session menu options, thinking I would find a Save Session somewhere.  No worries though @psychedelicious, I know Invoke is in your capable hands.  With such a prolific team of contributors, I can only imagine how full the plate is.
I've been using Invoke since version 2.3.1 so I don't mind the wait.  I still use ComfyUI for professional projects, but nothing beats the "feel" of playing and experimenting with artistic concepts in Invoke.
I have another "heavy lift" enhancement related to dual-monitor support, but that will be in a separate enhancement entry.  Keep up the stellar job.


Option to run cucumber scenarios in parallel

I have made each of my test scenarios completely independent by using cucumber-guice ScenarioScoped objects. Now, I have the ability to run my cucumber scenarios in parallel. I have tried setting up the forkEvery and maxParallelForks in my gradle task. That doesn't seem to do the magic with JUnit. I am running my Cucumber feature files using the JUnit @Runwith option.
Please suggest if there are any options that I could try in being able to run my cucumber scenarios in parallel. Also, I am interested in running the scenarios in a multi-threaded fashion rather than running them in multiple JVMs.

Please ask for help on the mailing list - http://groups.google.com/cukes
Typed with my Thumbs.

On 27 Feb 2015, at 20:14, nnarendravijay<EMAIL_ADDRESS>wrote:
I have made each of my test scenarios completely independent by using cucumber-guice ScenarioScoped objects. Now, I have the ability to run my cucumber scenarios in parallel. I have tried setting up the forkEvery and maxParallelForks in my gradle task. That doesn't seem to do the magic with JUnit. I am running my Cucumber feature files using the JUnit @Runwith option.
Please suggest if there are any options that I could try in being able to run my cucumber scenarios in parallel.
Thank you very much in advance!
-Narendra.
—
Reply to this email directly or view it on GitHub.

Did that, thanks!


Update the text area colors

Fixes

Fixes #5026 by @obulat
Description

This PR updates the colors of the text area inside the content report form to match the Figma designs.
https://github.com/user-attachments/assets/87c3096d-d655-4b70-b54e-94bd3dd413c9
Testing Instructions

Run the app using ov just frontend/run dev
Go to a single result page and click on "Report content".
Select a reason other than the first one. You should see the text area. It should look well in both dark and light themes, and should match the designs.
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I see this on staging. Is this an unexpected style?

I see this on staging. Is this an unexpected style?

It was an unexpected style, fixed in #5076


Update request: osu-lazer 2023.815.0 → 2023.1026.0

Package name: osu-lazer
Latest released version: 2023.815.0

Current version on the unstable channel: 2023.815.0
Current version on the stable/release channel: 2023.511.0

[x] Checked the nixpkgs pull requests

Notify maintainers
@oxalica
@thiagokokada

Note for maintainers: Please tag this issue in your PR.

https://github.com/NixOS/nixpkgs/pull/265909


hidden_size parameter

The track_condenssation_network files use parameter hidden_size of IN, but that doesn't exist anymore (probably now relational_hidden_size and object_hidden_size)

fixed!


TzTok-Jad task does not register properly

When you have a Jad task, the slayer counter goes to 0 once you kill any fight caves creature instead of after you fight Jad.

🎉 nice!


SS and group options "exec_repeat" can cause shader execution to repeat.

The default is 1, which is the old behavior: each call to
ShadingSystem::execute() will run the shader group once.
How is this useful? Suppose you have a very complicated app like a
renderer, and you're curious how much total time is attributable to the
actual execution of the shader. Each individual shader execution may be
so quick that putting timers around the calls may throw off the overall
time of the app (it takes time to retrieve the time, so by measuring
you are changing the timing characteristics; Heisenberg would
be proud).
So you set exec_repeat to 2, running each shader TWICE per call to
execute(). If you time this and compare it to shading the usual 1 time
per execution, the difference should be the total time spent shading for
an ordinary run. (But NOT including texture I/O time, since the "first
shade" will include any I/O that is triggered by needing non-resident
tiles, which will then already be resident for the "second shade." But
the OIIO TextureSystem stats should also tell you the amount of I/O
time).
Setting exec_repeat=0 will skip texture execution. I'm not sure how that's
helpful, since it changes appearance, duh.
You can set the exec_repeat for the whole ShadingSystem, and also override
it for individual groups.
Beware that a few things with side effects (printf, error calls, and
pointcloud_write) may change overall rendering behavior by doing them
multiple times. But everything else should be safe and yield the same
rendered results, if I've done this all correctly.

Any opinions on this?

Assuming the extra logic isn't slowing down the regular case at all, LGTM

Too small to time it.


Footer text in darkmode

Currently is the Footer text in darkmode black. Would be nice to make it white on dark mode detection.

Duped by #109 .  @jordywitteman can this be closed?  It sounds like it's already planned for released.

The FooterText provides better contrast since v2.5 and should be easier to read


Increment version for identity releases

Increment package version after release of com.azure azure-identity

Closing this PR as it is not for master branch.
Master one is manually created here:
https://github.com/Azure/azure-sdk-for-java/pull/19090


Specify versions

Pin filestore to mongoengine 0.8.7 too

@ericdill Done. See also https://github.com/NSLS-II/filestore/pull/55


RENAME appCode to projectToken

https://github.com/chromaui/chromatic/issues/3285
do not merge yet, must wait for chromatic-cli package to be released and then updated

@ndelangen I made some tweaks to the README so be careful when merging this as you'll have to manually resolve a couple of (trivial) conflicts.

I think i resolved it @zol


Validate vlan mtu not greater than base iface

fixes #1047
A new validator is added that verifies that the
MTU of VLAN is less than or equal to MTU of base iface
Signed-off-by: Adwait Thattey<EMAIL_ADDRESS>

@ffmancera Can u please check if this is what is required.
If yes, I will make changes to the tests (if required)

Done. I am running tests locally. Will push after that
One doubt:
Is it okay to directly put the validation in _validate_vlan or should I create another method
_assert_vlan_mtu_not_greater_than_base_iface and call that from the _validate_vlan
because I find the latter approach used at multiple places in validator.py

I had to make a few changes considering a few existing tests

Added condition to check only if VLAN is up.
Changed an existing test that was setting MTU greater than the default value of base eth

After this, some tests are still failing. In these tests, the base and the VLAN are being created at the same time. So the base exist in the desired_state and not the current_state and the error is thrown.
How do you propose I handle this?
Should I check for the base first in the desired state and then in the current state?
In such a situation, if the value of base MTU is not provided in desired_state, should I default it to 1500?

squashed the commits
Also, I am thinking of adding a test that deliberately adds a VLAN with MTU greater than the base to check if an error is thrown

squashed the commits
Also, should I add a test that deliberately adds a VLAN with MTU greater than the base to check if an error is thrown?

Yes, you should do it.

Updated with validator
I tried writing the test for this like this in vlan_test.py
def test_add_vlan_with_mtu_greater_than_base(eth1_up):
    desired_state = {
        Interface.KEY: [
            {
                Interface.NAME: VLAN_IFNAME,
                Interface.TYPE: InterfaceType.VLAN,
                Interface.STATE: InterfaceState.UP,
                VLAN.TYPE: {VLAN.ID: 101, VLAN.BASE_IFACE: eth1_up[Interface.KEY][0][Interface.NAME]},
                Interface.MTU: eth1_up[Interface.MTU] + 1
            }
        ]
    }

    with pytest.raises(ValueError):
        libnmstate.apply(desired_state)

The problem I am facing is that eth1_up does not seem to have a parameter "mtu". Thus it gives a KeyError. How do I get the mtu of eth1?

Added test and Rebased

Looking into this tomorrow. Thanks for your contribution! :-)

Made the changes

Travis CI seems blocked, I am restarting it..

For some reason, CI is not working on this PR. All the jobs are passing but it is not reporting back. Do you why? @tyll @cathay4t?

For some reason, CI is not working on this PR. All the jobs are passing but it is not reporting back. Do you know why? @tyll @cathay4t?

I guess it is a Travis problem, saw this with the network role, too. Best would be to rebase which needs to be done anyhow IMHO.

@ffmancera  Rebased
But one of the builds is failing with
error: db5 error(17) from dbenv->open: File exists
error: cannot open Packages index using db5 - File exists (17)
error: cannot open Packages database in /var/lib/rpm
Error: Error: rpmdb open failed

Not sure what this is due to...

We have made a lot of changes in the validator, could you rebase this an adapt it to the new code? The code looks good but it needs to be adapted to the new design. Thanks!

@ffmancera rebased and adapted the code for the new design
Please review

@cathay4t
If mtu for vlan doesn't exist, I am raising an exception. Ref. ifaces/ifaces.py, Line 184
This is causing some other tests to fail
Instead of raising an exception should I just skip the validator if mtu for vlan doesn't exist?

@cathay4t
If mtu for vlan doesn't exist, I am raising an exception. Ref. ifaces/ifaces.py, Line 184
This is causing some other tests to fail
Instead of raising an exception should I just skip the validator if mtu for vlan doesn't exist?

I will look into the failures once you fixed all my changes requests.

@cathay4t made the changes. Tests are also passing

@cathay4t Done

also rebased


Added test data for Hi-C

Hi @nservant,
Please first make a new branch on the repo, named after whatever your pipeline will be called:

Then edit this PR so that it's against that branch instead of master please.
Thanks!
Phil

Done. Thanks.


FIX delete enable_map/struct_type switch

Proposed changes
Issue Number: close #xxx
here is not need enable map/struct switch

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.9 seconds
stream load tsv:          505 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>5 Bytes


Update viewing-and-managing-updates.md

Added line shifts after headings.
Added bold to part of sentences to improve readability.
Removed unnecessary spaces.

Learn Build status updates of commit 1b00c36:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

WindowsServerDocs/administration/windows-server-update-services/manage/viewing-and-managing-updates.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@robinharwood, @Xelu86
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Setup Search

This includes the doctype and the searchengine some details here #24

I can have a crack at this over the weekend if you like.

I like! Sure leave a comment that you will handle this one, so we don't get 2 folks working on the same item :)


Enable dependabot updates for github actions

This doesn't update anything currently. We don't use actions much currently here (unlike aspire-samples) but there are some uses and this will keep them up to date.
Microsoft Reviewers: Open in CodeFlow

@danmoseley I've not looked into it. For the recent bumps to locker.yml though, I don't expect dependabot would have caught that since the reference to node16 was indirect through the vscode-github-triage-actions repo.
I don't see why not though--we can always disable it if the signal-to-noise ratio is poor.


convert qwen2-0.5b-instruct failed when using smoothquant

System Info
GPU Type: A6000
Who can help?
No response
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
git clone https://huggingface.co/Qwen/Qwen2-0.5B-Instruct
python3 ./convert_checkpoint.py --model_dir ./Qwen2-0.5B-Instruct --output_dir ./tllm_checkpoint_1gpu_sq --dtype float16 --smoothquant 0.5
Expected behavior
Successfully convert and save model checkpoints
actual behavior
Cloning into 'Qwen2-0.5B-Instruct'...
remote: Enumerating objects: 33, done.
remote: Counting objects: 100% (30/30), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 33 (delta 12), reused 0 (delta 0), pack-reused 3 (from 1)
Unpacking objects: 100% (33/33), 3.60 MiB | 6.54 MiB/s, done.
[TensorRT-LLM] TensorRT-LLM version: 0.12.0.dev2024073000
0.12.0.dev2024073000
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
/usr/local/lib/python3.10/dist-packages/datasets/load.py:1429: FutureWarning: The repository for ccdv/cnn_dailymail contains custom code which must be executed to correctly load the dataset. You can inspect the repository content at https://hf.co/datasets/ccdv/cnn_dailymail
You can avoid this message in future by passing the argument `trust_remote_code=True`.
Passing `trust_remote_code=True` will be mandatory to load this dataset from the next major release of `datasets`.
  warnings.warn(
calibrating model:   0%|                                                                                | 0/512 [00:00<?, ?it/s]We detected that you are passing `past_key_values` as a tuple and this is deprecated and will be removed in v4.43. Please use an appropriate `Cache` class (https://huggingface.co/docs/transformers/v4.41.3/en/internal/generation_utils#transformers.Cache)
calibrating model: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 512/512 [00:20<00:00, 24.44it/s]
Weights loaded. Total time: 00:00:18
Traceback (most recent call last):
  File "/app/tensorrt_llm/examples/qwen/./convert_checkpoint.py", line 309, in <module>
    main()
  File "/app/tensorrt_llm/examples/qwen/./convert_checkpoint.py", line 301, in main
    convert_and_save_hf(args)
  File "/app/tensorrt_llm/examples/qwen/./convert_checkpoint.py", line 228, in convert_and_save_hf
    QWenForCausalLM.quantize(args.model_dir,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/qwen/model.py", line 380, in quantize
    convert.quantize(hf_model_dir,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/qwen/convert.py", line 1207, in quantize
    safetensors.torch.save_file(
  File "/usr/local/lib/python3.10/dist-packages/safetensors/torch.py", line 284, in save_file
    serialize_file(_flatten(tensors), filename, metadata=metadata)
  File "/usr/local/lib/python3.10/dist-packages/safetensors/torch.py", line 480, in _flatten
    raise RuntimeError(
RuntimeError:
            Some tensors share memory, this will lead to duplicate memory on disk and potential differences when loading them again: [{'transformer.vocab_embedding.weight', 'lm_head.weight'}].
            A potential way to correctly save your model is to use `save_model`.
            More information at https://huggingface.co/docs/safetensors/torch_shared_tensors

additional notes
transformer version: 4.42.4
TensorRT-LLM version: "0.12.0.dev2024073000"

It has been fixed. Can you have a try again on the main branch?


Upload to AWS/Azure Services

Document "how to deploy/infer" using the above mentioned service

we can close this issues as well as we have hosted in Azure @p-s-vishnu


How to get rows from a specified row number?

If a  file has 1000 lines of data, I don't want to read them at once.

You can call f.GetRows() and use slices to get the specific rows you want.
rows, err := f.GetRows("SheetName")

// rows[row][col]
// get first 10 rows
slicedRows := rows[:10][:]

Or you can call f.Rows() and iterate yourself.
It looks like the whole sheet is read in f.Rows() function.

The Rows return a rows iterator, used for streaming reading data for a worksheet with a large data.
And you can skip a row with Next.

In the case of a large amount of data. I need specific data for row 10,000. I need to run 10,000 times with an iterator. Get the data I want. Is there a better way to get the specified row. Really, very much needed.

Using the rows iterator will cost less memory, but you can also use the GetRows function to get all cell values for the worksheet, and access specified rows by index in a 2D array.


Update and rename content/github/administering-a-repository/finding-i…

…nformation-in-a-repository/filtering-issues-and-pull-requests-by-labels.md to Nội dung/github/quản lý một kho lưu trữ/tìm kiếm thông tin trong một kho lưu trữ/filtering-issues-and-pull-requests-by-labels.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

4AEE18F83AFDEB23


[Question] Missing couple options

Hey, I have been skipping many updates (specifically, since 2.0.0), and right now I can't find some very important options: --exclude-forks and --github-user. I have been using them heavily in the past and now can't find a way to make similar behaviour. Is there a way to do this?

@c0rvax sorry there is not. v7.x.x removed github/gitlab integrations and I don't plan on supporting them in the future.
You can use v6.2.0 if you want to use a more recent version with github/gitlab integrations


Router Route animate property does not work with (vaadin-app-layout) child views

Description of the bug
Router Route animate property does not work with (vaadin-app-layout) child views.
Minimal reproducible example
https://github.com/johannest/v23-hilla-animate
Expected behavior
When navigating between Home and About views, the transition animation (fade) should be shown.
Actual behavior
No animation is shown
Versions:
- Vaadin / Hilla version: V22.0.4 and Hilla 1.0.0.beta1 tested
- Node version: v16.14.0 and v14.17.0 tested
- Java version: 11.0.13
- OS version: Win 11 and Ubuntu 20.04.3 LTS tested
- Browser version (if applicable): at least Chrome

Can reproduce with any child view (does not work with a custom one) on both firefox and chrome on vaadin v22.0.0-5

Seems that it turns out to be a CSS issue in the application. With the > selector, it only selects the direct child. Could you apply this change and see if it works for you?

This fixes in part the problem (now navigating between hilla defined routes works), but navigating between two flow defined routes (using Router.go) with serverSideRoutes does not work.
From my testing, it seems because serverSideRoutes is seen in the routes variable as only a single route, not animating between them.

That explains everything then
Thanks for the pointer, I will try using the add-on you recommended, or making an alternative for this specific case only (triggering the hilla animation when changing flow routes)
Thanks for the quick response and have a great day!

Thank you, then I would like to close this ticket, as it's not a bug in Router.


cannot produce any sound

i run the example but no sound whatsoever.
phone : Xiaomi 9t pro.
android 10.

no error on logcat. only debug line.
D/AudioTrack( 4542): stop(4781): called with 19584 frames delivered
D/AudioTrack( 4542): stop(sessionID=20153)

wow wait...
it made sound after i connect to my bluetooth headphone.
wth?

alright my bad there is no sound because the volume master for notification is turned to 0.
you should add to readme this problem. :)
so my bad.


Bug fix: Get only verification links of related users (Needs to be tested in prod)

Test this as ASAP, Once this PR is merged. Text me the necessary feedback if it working correctly.