Resource labels selector does not take effect

Describe the bug

Steps to reproduce

Create a resource definition and add a resource label selector.

Using the above definition to create a resource.

Result

Unable to select the definition with resource labels selector.

Expected behavior

Environment

Walrus version: main a12b753f2e823aa7a7456110215dceed4da46ba1
UI version: dev-07fa8db

Additional context
Add any other context about the problem here.

Environment

Walrus version: main 50709d6d68b3f34858a63684418af0bfb19e7585
UI version: dev-88faa21

Test Result:
Failed to deploy during batch deployment.

https://github.com/seal-io/walrus/assets/26084756/76996b17-40ed-44b5-a680-874ba0660c29

Environment

Walrus version: main 66a2214c8ea5dfb7fd8542fecb5e87a3778fc07e
UI version: dev-7449733

Test Result: pass


Capitalize the first letter of each word for the preview actions

Storage Explorer Version: 1.9.0
Build: 20190821.3
Platform/OS: Windows 10/ Linux Ubuntu 18.04
Branch: master
Architecture: ia32/x64
Regression From: Previous release
Steps to reproduce:

Launch Storage Explorer.
Navigate to 'Preview' -> Check the shown actions under the 'Preview'.

Expect Experience:
Capitalize the first letter of each word.
Actual Experience:
Only capitalize the first letter of the first word.

Non-localization suggestion


[OSB] Shades of morton - gold coffin boost

🐛 Bug Report
Currently the golden coffin isnt extending the maximum trip length
This is sending a trip with golden coffin equipped in skilling: +4m max trip length but defaults to 30m trip regardless
I would have expected this boost to atleast give +1 to shades used
Looking at the code the "bonusTime" variable is never used to influence duration/trip time
https://github.com/oldschoolgg/oldschoolbot/blob/821496ddd0f26dd4ce1ba097a9fe832a32cc7526/src/mahoji/lib/abstracted_commands/shadesOfMortonCommand.ts#L264-L270

@TastyPumPum
BadgeHunter just sent me this. the coffin still isn't working


Support Go 1.5

There are many benefits to using Go 1.5, including the new pause-less GC. However, we have run into several issues using Go 1.5 to build the registry, both at compile time and runtime. Let's collect them here and burn down towards getting there for the next registry release.

[x] #887
[ ] #910
[x] #913

cc @RichardScothern

[ ] #1124
Leaving #910 until after the release.

Any reason we are holding this up? We shouldn't have released 2.2 without the upgrade. There are going to be massive performance benefits.

Nope.  I'll put it on the list.
On Tue, Nov 10, 2015 at 12:42 PM, Stephen Day<EMAIL_ADDRESS>wrote:

Any reason we are holding this up? We shouldn't have released 2.2 without
the upgrade. There are going to be massive performance benefits.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/distribution/issues/937#issuecomment-155559821
.

Wicked!

Any plans to build a 2.2.x point release to include this change?


New architecture support for React Native 0.76+

Hey!
Does this library support the new react native architecture? Link.
Sorry to spam issues across your repos 👀 This one is the one I meant to ask on. Cheers

This library is JavaScript only, you will need to upgrade the react-native-webview to support New Arch.

Thanks for confirming!


use drop_out=0.2 in the inference mode, isn't wrong way?

Hi
In the efficient-net model used dropout layer in the final prediction layer and also used in the Conv layers with rate 0.2 for training mode, Why in the inference mode didn't set rate of these layers to 1.0, and these layers don't operate in the inference mode?

Keras automatically disable dropout during inference stage

@qubvel
That means, when we use model.predict the keras automatically put the dropout and BN layers in the inference phase?

No, it is default keras behavior for a long time


✨ rename imbs to its

Summary
Rename imbs to its.
This is part of issue #2024 (fixed by PR #2033) in the kubestellar repo.
Related issue(s)
Fixes #

@effi-ofer the commit is not signed..

What am I missing?  https://github.com/kubestellar/ocm-transport-plugin/pull/13/commits/327e2c07d69d3a92232cdff6d114be150fc20ba0
Signed-off-by: Effi Ofer<EMAIL_ADDRESS>

I don't remember exactly but git needs to mark your commit as "verified", which in this case it doesn't do that

this should appear next to your commits

Done.  This repository requires gpg signing which is different from the ks requirements.  We should align the requirements for the two repos.


[PORT] fix for OnUnknownIntent title.

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4229

Fixes #3959
Changed projects

Microsoft.Bot.Builder.Dialogs.Adaptive

[Adaptive,R10]

We don't have this in JS, closing this issue.


Add giphy generator workflow

/giphy hope this works

/giphy this is so cool

/giphy another one

/giphy another one

/giphy another one

/giphy another one

/giphy haza

/giphy dreams be dreams

/giphy motivation


Unified Error type

Would it make sense to follow the pattern introduced by other serde libraries of exposing a top-level Error type that unifies the error types possible within the crate?
Some references:
JSON
XML
YAML
bincode
If people think this is a desirable feature I'd like to submit a PR

I like the split, but having an impl From<…> unifying one for convenience might indeed be nice to have. And given the number of example crates using unifying errors, there might be enough desire to do this here as well.
What I like about such splits is that one can exhaustively match on error cases that are possible to occur, there are no impossible ones.
Disclaimer: Am no ron user. Just dropping my opinion on good API design. =)

@Mathspy looks like all these crates use different representation of Error, so it's not clear to me how the unified one would look like.
Another small concern I have is - who would benefit from these types being shared? It's not very likely that many different formats would be used in the same app, and they'd need a place where the errors are merged.

What I like about such splits is that one can exhaustively match on error cases that are possible to occur, there are no impossible ones.

This is precisely why Rust's Enum's should have OCaml's Polymorphic Variants support.  OCaml Variants are like Rust Enum's as they are now, but OCaml's Polymorphic Variants allow for a syntax to specific what specific head with what specific types could possibly be returned from (or accepted into) a function.  This would allow you to specify all possible error types and all handling of it through functions is known for what could possibly come out, so you don't have to worry about match's being incomplete or 'too' busy without putting in a default case (I really really hate default cases, it makes adding more heads invisible in that location, which is really bad for refactoring and maintainability).
It would be a fairly simple extension of Rust's Enum system type, maybe someday...

@kvark my idea personally was a simple enum with two variants SerializeError/DeserializeError, it's not much of a huge enchantment besides a simple convenience-y instead of people having to create that enum for each of their applications that uses ron (if they care about both serializing and deserializing in same application)

Oh wait, so you want an enum over the types for ron/json/other? I don't know if this is useful, but it wouldn't be a part of the ron crate, if I understand your idea correctly.

Sorry for not being clear!
This is basically my idea (and something I already implemented in my code using RON):
pub enum RonError {
    Deserialize(ron::de::Error),
    Serialize(ron::ser::Error),
}

Though there is definitely better ways to do this (P.S: I am relatively new to Rust) so I am not attached to the idea, but simply proposing an enhancement to think about (others probably can come up with better designs than this)

Oh, so you are proposing to expose this enum to users, but perhaps not even return it explicitly from any function? @torkleyy do you have a stance on this?

Yeah, that‘s sensible. Should be sufficient to add this to lib.rs, together with the trait implementations.


pynmstar failure to compile sub package

HI
if I do uv tool install nef-pipelines it all appears to work
However, when I run the command nef [the main entry point to my application in nef-pipelines], I get
raise ImportError('Could not import cnmrstar sub-module! Your installation appears to be broken.')
This appears to be because the dependant c file from the package pynmstar.cnmrstar doesn't appear to be compiled properly. I appear to have had similar but different problems  as the c component seems to require the latest setup tools to compile. So when using pip I have to do
pip install --upgrade wheel setuptools
and sometimes
pip install  --upgrade wheel setuptools backports.tarfile
to get the installation to work, this is on a centos 7 system but I have had this problem elsewhere
this is with the latest uv at time of writing  0.4.13

this is also discussed here, binary wheels are provided so it shouldn't need to build the c

Can you share the output of uv tool install with --verbose?

here you go
output.txt

So for one: pynmrstar only ships wheels for Python 3.9 and earlier. You're on Python 3.12, so I think it's correct that it's building from source.

See here (look at cp39 etc.).

It seems to install ok for me:
❯ nef
Usage: nef [OPTIONS] COMMAND [ARGS]...

Options:
  --install-completion [bash|zsh|fish|powershell|pwsh]
                                  Install completion for the specified shell.
  --show-completion [bash|zsh|fish|powershell|pwsh]
                                  Show completion for the specified shell, to
                                  copy it or customize the installation.
  --help                          Show this message and exit.

Commands:
  chains     - carry out operations on chains
  csv        - read [rdcs]
  deep       - read deep [peaks]
  echidna    - read echidna data [peaks]
  entry      - carry out operations on the nef file entry
  fasta      - read and write fasta sequences
  fit        - carry out fitting operations [alpha]
  frames     - carry out operations on frames in nef files
  globals    - add global options to the pipeline [use save as your last...
  header     - add a header to the stream
  help       - help on the nef pipelines tools and their usage
  loops      - carry out operations on loops in nef frames
  mars       - read and write mars [shifts and sequences]
  modelfree  - write modelfree [relaxation data]
  nmrpipe    - read nmrpipe [peaks shifts & sequencess]
  nmrstar    - read NMR-STAR [sequences & shifts]
  nmrview    - read and write nmrview [peaks, sequences & shifts]
  pales      - read and write pales/dc [rdcs]
  pdbx       - read pdb [sequences]
  peaks      - carry out operations on nef peaks
  rpf        - write rpf shifts
  save       - save the entries in the stream to a file / files or stdout...
  series     - carry out operations on a data series
  shifts     - carry out operations on shifts [average]
  shiftx2    - read shiftx2 data [shifts]
  shifty     - write shifty [shifts]
  simulate   - simulate data
  sink       - read the current stream and don't write anything
  sparky     - read sparky files [shifts]
  stream     - stream a nef file
  talos      - read and write talos files [shifts & restraints]
  test       - run the test suite
  xcamshift  - write xcamshift for xplor [shifts]
  xeasy      - read xeasy files [flya dialect: sequence]
  xplor      - read xplor [sequences, dihedral & distance restraints]

Do you see a failure when running just nef? Or when you run nef within a project, some specific subcommand, etc.?

just running it as a command as you did...

Are you able to put together a reproduction, e.g., with Docker?

Hi Charlie
I should be able to, but it will take a little while as I am currently on holiday till the 24th and I will need an hour or two to sort something out.
gary

No problem, thanks for following up. Enjoy your holiday.

hi Charlie so back from holidays illness and family emergencies
here is a docker build file to make a working centos 7 system
FROM centos:7
RUN useradd -u 1000 -p test test
RUN cat /etc/yum.repos.d/CentOS-Base.repo
RUN sed -i -e 's/mirrorlist.centos.org/vault.centos.org/' /etc/yum.repos.d/CentOS-Base.repo
RUN sed -i -e 's/mirror.centos.org/vault.centos.org/' /etc/yum.repos.d/CentOS-Base.repo
RUN sed -i -e 's/#baseurl/baseurl/' /etc/yum.repos.d/CentOS-Base.repo
RUN cat /etc/yum.repos.d/CentOS-Base.repo
RUN yum -y groupinstall 'Development Tools'
RUN su test
RUN echo pwd
USER test
WORKDIR /home/test
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN curl -LsSf https://astral.sh/uv/install.sh | sh
RUN source $HOME/.local/bin/env
CMD ["/bin/bash"]
once run  with
docker build  -f uv_nef_test.docker --progress=plain -t uv_nef_test  .
login with
docker run  -it uv_nef_test
and do
uv tool install --python 3.12 nef-pipelines
this does a complete installation of nef-pipelines but when nef is run it reproduces the error with installing pynmrstar described above
have fun
gary

I did some ore digging...
with the same image if I do
1  uv python install 3.12
2  uv venv test
3  source test/bin/activate
4  uv pip install pynmrstar
5  python

and then

import pynmrstar
import cnmrstar

it all seems to be fine

Ack, thanks.

If you look at the build logs:
DEBUG /usr/bin/aarch64-linux-gnu-gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -fPIC -fPIC -I/home/test/.cache/uv/builds-v0/.tmpYyg39I/include -I/home/test/.local/share/uv/python/cpython-3.12.8-linux-aarch64-gnu/include/python3.12 -c c/cnmrstarmodule.c -o build/temp.linux-aarch64-cpython-312/c/cnmrstarmodule.o -funroll-loops -O3
DEBUG warning: build_ext: building extension "cnmrstar" failed: command '/usr/bin/aarch64-linux-gnu-gcc' failed: No such file or directory

Oh sorry, I need to emulate x86

Ok, so it looks like the issue is that nef ultimately installs pynmrstar==3.3.2 due to its dependency graph. And that version is reported as failing on that operating system: https://github.com/bmrb-io/PyNMRSTAR/issues/126.
If you look at the build logs:
DEBUG c/cnmrstarmodule.c: In function 'str_to_lowercase':
DEBUG c/cnmrstarmodule.c:149:5: error: 'for' loop initial declarations are only allowed in C99 mode
DEBUG      for(int i = 0; orig[i]; i++){
DEBUG      ^
DEBUG c/cnmrstarmodule.c:149:5: note: use option -std=c99 or -std=gnu99 to compile your code
DEBUG warning: build_ext: building extension "cnmrstar" failed: command '/usr/bin/cc' failed with exit code 1

So, it seems like a somewhat irresolvable problem.
What you can do is add an overrides.txt file:
pynmrstar>=3.3.3

And then run uv tool install nef-pipelines --overrides overrides.txt.
That would instruct uv to ignore any dependency declarations and use a newer version of pynmrstar. But other than that, I think you need to find a way for nef to raise its pynmrstar constraint.


[GLUTEN-1275] Fix cast double to decimal

Can you help take a look? Relevant gluten PR https://github.com/oap-project/gluten/pull/1276/files


Runtime error on Mac: Could not load the file 'Plugin.BLE'

Steps to reproduce

Create a Xamarin.Forms application including a Mac project.

Add Plugin.BLE version 2.1.1 to the shared Xamarin.Forms project.

Build and run.

Expected behavior
The app should start up without errors.
Actual behavior
The app crashes with the error: Could not load the file 'Plugin.BLE'
Crashlog
System.IO.FileNotFoundException: Could not load the file 'Plugin.BLE'.
  at System.AppDomain.Load (System.Reflection.AssemblyName assemblyRef, System.Security.Policy.Evidence assemblySecurity) [0x00073] in /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/src/Xamarin.Mac/mcs/class/corlib/System/AppDomain.cs:758
  at System.AppDomain.Load (System.Reflection.AssemblyName assemblyRef) [0x00000] in /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/src/Xamarin.Mac/mcs/class/corlib/System/AppDomain.cs:724
  at at (wrapper remoting-invoke-with-check) System.AppDomain.Load(System.Reflection.AssemblyName)
  at System.Reflection.Assembly.Load (System.Reflection.AssemblyName assemblyRef) [0x00000] in /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/src/Xamarin.Mac/mcs/class/corlib/System.Reflection/Assembly.cs:440
  at ObjCRuntime.Runtime.CollectReferencedAssemblies (System.Collections.Generic.List`1[T] assemblies, System.Reflection.Assembly assembly) [0x00085] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/ObjCRuntime/Runtime.cs:545
  at ObjCRuntime.Runtime.CollectReferencedAssemblies (System.Collections.Generic.List`1[T] assemblies, System.Reflection.Assembly assembly) [0x00085] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/ObjCRuntime/Runtime.cs:545
  at ObjCRuntime.Runtime.RegisterEntryAssembly (System.Reflection.Assembly entry_assembly) [0x00032] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/ObjCRuntime/Runtime.cs:506
  at ObjCRuntime.Runtime.RegisterAssemblies () [0x00001] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/ObjCRuntime/Runtime.cs:482
  at AppKit.NSApplication.Init () [0x00022] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/AppKit/NSApplication.cs:56
  at WTD.Mac.MainClass.Main (System.String[] args) [0x00001] in /Users/janus/git/wtd.apps.dfs.de/WTD.Mac/Main.cs:9

Configuration
Version of the Plugin: e.g. 2.1.1
Platform: MacOS Big Sur (11.2.3)
Device: MacBook Pro

Hi @janusw,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

This issue looks very related to #430, and it might actually be fixed by #431 (I couldn't check this yet because there is no release which includes the fix).

After I managed to build a nuget package (with the fixes from #493), I could indeed verify that the runtime error reported here goes away with nupkg built from current master (9d4ec4d4f718971a1aac0ef8bf986b8bfa492de9) plus PR #493. Thus I conclude that it was in fact fixed by ce2dd84fe619d333f4e3538ca01aff15c268ad76 (#431).
IMHO this issue can be closed once a release is available on nuget.org which includes this fix.


Question: How to pickup / harvest?

Thanks for your addon. The planting part is working great for me but I can't figure out, how to mass-harvest.

I tried to focus an item I want to harvest and press the key
I tried to just press the key

How does it work? :)
Thanks in advance

Hold the modifier key, then press your normal "harvest" button.
It's a little more obvious when planting, since the extra plants only show a preview when holding the button.

awww... Love it. This is perfect, thanks.
You might want to clarify it in the README - this is great!


Skins

Using the latest version of spigot and ViaVersion with no other plugins it show no console errors the skin hats pants etc... (Not the entire skin just the second layer) will not show up for 1.9 clients

Fixed  #103


Translate

[ ] Add a way to see untranslated texts
[ ] Add spanish

@adcpm there are some heavy conventions in this PR that needs to be addressed as comments to be understandable for others. May you please add some lines of detailed explanation in wrapper.js where you are loading the translations and include a direct link to the post that translations exist in it?

Thank you i've made the requested changes.


New Hub: Justice Innovation Lab

Background
The Justice Innovation Lab is a non-profit law+data organization. They have credits on Azure, and
Setup Information

Hub auth type: Google using the justiceinnovationlab domain
Hub administrators:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hub url: https://justiceinnovationlab.pilot.2i2c.cloud/
Hub logo: https://images.squarespace-cdn.com/content/5ee35ddb35affc21b29c0fd6/1596634079158-KLDENW5BSW2HQW4ZO0EH/JIL-Logo-Digital.png?format=1500w&content-type=image%2Fpng
Hub logo URL:  https://www.justiceinnovationlab.org/
Hub type: Dask Hub
Hub cluster: 2i2c
Hub image:

Important Information

Link to leads issue: https://github.com/2i2c-org/leads/issues/37
Hub config name: justiceinnovationlab
Community champion: rory.pulvino
Hub start date:
Hub end date:
Hub important dates:

Notes
This hub originally began on our Pilot cluster on GCP. However, they have data that exists on Azure (as well as credits) so we need to move their hub over to Azure. This might require a few steps first, so tracking this in the to-do item below.
Deploy To Do

[x] Initial Hub deployment
[ ] Move the hub to Azure

[ ] Confirm that we have got the correct Administrative access to the hub
[ ] ...figure out next steps

[ ] Administrators able to log on
[ ] Community Champion satisfied with hub environment
[ ] Hub now in steady-state

cc @yuvipanda who already deployed this hub. However, we need to move it to Azure!

There's a pilot running they are using right now, but we should move to Azure pretty soon. Should we wait for a contract, @choldgraf?

Hmmm, I think there are two main questions:

How much pain will it be to switch to Azure in the future, if we continue down the path of not using Azure?
How much would we learn / improve from switching this hub to Azure right now?

What do you think?

Moving hub to Azure shouldn't be a problem, since we'll just have to move the hub db sqlite file and home directories.
We currently have experience running Azure clusters (https://github.com/utoronto-2i2c/jupyterhub-deploy/tree/staging/terraform) and we should try porting it. However, I think I'd like to prioritize new development right now, if that's ok with the JIL folks. We can come back to this in a couple weeks (or once we have more hires?)

Note - I've opened up https://github.com/2i2c-org/pilot-hubs/issues/373 to track adding Azure deployment infrastructure to our pilot-hubs/ repository. I think that this will need to be resolved before we can migrate the JIL hub to Azure.

@JILPulvino  if I remember correctly, you have azure credits still. What would be next steps for us to get access to those so we can start working on getting a hub there?

Added you as a guest user. I need to figure out what roles to assign you too. Would you happen to know what resources in Azure you'll need access to e.g. global administrator, though that would be the broadest.

@JILPulvino yeah, can we start with the broadest role and we can go from there?

Yep, I can add that role to your profile.
On Fri, Jun 11, 2021 at 5:53 PM Yuvi Panda @.***> wrote:

@JILPulvino https://github.com/JILPulvino yeah, can we start with the
broadest role and we can go from there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/pilot-hubs/issues/288#issuecomment-859928382,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARUMUBDG2EJQC6PX4JUM5QDTSKAU5ANCNFSM4YUF6KBQ
.

@yuvipanda do you have availability next week to discuss the global admin role?

@JILPulvino i just responded to your email. Sorry about the delay

@JILPulvino recently re-worked the permissions on their Azure project to give us administrative privileges. He asked if we can confirm that we have this access. I added an item to our to-do list above.

I've updated https://github.com/2i2c-org/pilot-hubs/issues/373 and opened https://github.com/2i2c-org/pilot-hubs/issues/512 for more actionable tasks. Completing those should make the hub go live! It'll be deployed from this repo.

Great, thank you!
On Tue, Jul 13, 2021 at 6:51 AM Yuvi Panda @.***> wrote:

I've updated #373 https://github.com/2i2c-org/pilot-hubs/issues/373 and
opened #512 https://github.com/2i2c-org/pilot-hubs/issues/512 for more
actionable tasks. Completing those should make the hub go live! It'll be
deployed from this repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/pilot-hubs/issues/288#issuecomment-878984936,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARUMUBDTJTP6C2RNO457SM3TXQLCNANCNFSM4YUF6KBQ
.

@JILPulvino we have something for you to try! Take a look at https://justiceinnovationlab.2i2c.cloud? It's using the image specified in https://github.com/2i2c-org/justiceinnovationlab-image, and we should be able to figure out a way to let you update it without needing intervention from us. This infra isn't final yet, but try it out and let me know what you think?

@yuvipanda Thank you! The log in works, but when trying to start a notebook it doesn't find a kernel and there is not the same shared folder as in the other hub.
And, yes, that would be great for us to be able to make updates to the image at some point.

@JILPulvino yeah, shared folders aren't there yet but will be soon. I'll work on the kernel issue as well.
https://github.com/2i2c-org/justiceinnovationlab-image has instructions on how to make changes to the image and test it. Wanna give that a shot in the meantime?

@JILPulvino the kernel is working now, no shared dir yet. At some point, we'll just move over the shared directories from the old hub to the new hub, and then decomission the old one?
TODOs left:

[ ] Get shared directory working
[ ] Check the image, make sure it has things you need
[ ] Validate that authentication is ok
[ ] Configure resources as you wish (you can get more RAM / CPU now if you like!)
[ ] Setup grafana / prometheus for monitoring
[ ] Move shared dir (and maybe home dirs?) from old cluster to new

Try it out now and let me know what you think?

Great, thank you! I don't think the shared directory is a priority as we'll be storing everything elsewhere in Azure.

@JILPulvino I've now made you admin again, so you should be able to add users.
If you have a sense of what kinda options for resources you might want, we can make that happen. Users will see something like this:

And they can pick the size they want. Aligning those to individual VM sizes on Azure is probably a good way to think about this. Each user gets the resource equivalent of an entire VM. https://azure.microsoft.com/en-in/pricing/details/virtual-machines/linux/ has the list of available VM sizes. I'd suggest looking in the A, D, and maybe E series for inspiration.
I'll think about the other questions and get back to you.

@yuvipanda Thank you, this is great. With regards to our requirements on this end, I think generally people will need just 16 GB of RAM - I don't think we'd want less than that ever. The number of CPUs matters less to us, but I imagine scaling something like 2 CPU, 16 RAM; 4 CPU, 32 RAM; 8 CPU, 64 RAM; and possibly a very large option of 32 CPU and 256 RAM.

@JILPulvino I've provided 4 options for CPU / RAM sizes. Take a look and see if that works for you?

I also noticed that the hub doesn't automatically spin down?

Are you talking about your user session? Or the whole hub in general?

@yuvipanda Those look good and are working great.
As for the spinning down, I'm not quite sure which I mean actually, but I noticed that if I close the browser and leave for a day, when I go back to the site, it was still running. This doesn't seem to be happening now though.

@yuvipanda a few additional questions.

Can you start to include @lilygrierjil on these messages/add her to the repo? She is our new data engineer and is also working on this project.
Where should we make requests for additional packages to be added to the hub?
Can you point me to where I can see the code for the docker container/terraform/requirements.txt etc. for this hub? We are still working on our own container and we are hoping to use it as an example/work to modify this one on our own.

Welcome, @lilygrierjil!
@JILPulvino the image is built off https://github.com/2i2c-org/justiceinnovationlab-image, and there are instructions in the README there on how you can add / remove packages, test them, and make the hub use them without any involvement from us! Can you give it a shot?

Hey all - since this one has been running for a couple months now, I'd like to close this issue and consider the hub "deployed", with the knowledge that we may need to upgrade and improve things but it'll be better to do this via new support requests rather than doing it all in this mega-issue.
I'll close this, but if others object don't hesitate to suggest another approach!


Fix README links

Currently the SVG displays in GitHub's viewer which is broken, link to the raw svg instead.
Also change the TrivialBruteforce link to point to the directory with a README instead.

Please merge from main and the CI checks will pass.
I have just fixed a mistaken blueprint declaration.

LGTM! Thanks.


add regex support to the jq status

Current situation
As a flatcar user i would like to use regex capabilities of the JQ tool. However, it is not possible because it was built without ONIGURUMA library support
echo '["xabcd", "ABC"]'| jq '.[] | test("a b c # spaces are ignored"; "ix")'
jq: error (at <stdin>:1): jq was compiled without ONIGURUMA regex libary. match/test/sub and related functions are not available.

Impact
It is not possible to use JQ regexp functionality, which prevents me from using filtering or search in jq. Also it makes many shell recipes not compatible with the Flatcar linux.
Ideal future situation
JQ is linked with ONIGURUMA. Test should pass:
$ echo '["xabcd", "ABC"]'| jq '.[] | test("a b c # spaces are ignored"; "ix")'
true
true

Implementation options
Build jq with regex support (see https://github.com/flatcar-linux/portage-stable/blob/flatcar-master/app-misc/jq/jq-1.5-r2.ebuild), using static or dynamic link option.
Additional information
If you think its a good change which will be accepted - i can work on the PR. And thank you very much for keeping container linux up and running!

Commented in the PR: https://github.com/flatcar-linux/coreos-overlay/pull/320#issuecomment-620513858

@dongsupark i think we can close this ticket, just short q, do you know any ETA when it would come to alpha->beta->stable builds?

Yes, we are working on new releases, starting from a new Alpha.
After that, a new Beta release will follow.
Not sure exactly when. We will keep you informed.


V0.7.1

NLS without which mount -t vfat gave "IO charset iso8859-1 not found" for ordinarry created mkfs.vfat -F 32

@tetatetit can you rebase this please? there's alot of changes in this PR, and i'm not sure which you intended.


README.md wrong syntax in example: feature => features

The syntax in the example is wrong

D:\Repos\GitHub\sqlparser-rs\examples>cargo run --feature json_example --example cli FILENAME.sql
error: Found argument '--feature' which wasn't expected, or isn't valid in this context
Did you mean --features?
USAGE:
cargo.exe run --features ...
For more information try --help

it should be --features
I never used Rust before. I don't plane to be a rust developer, I am a database specialist. But of course I am ready to learn some basics. That's why examples are important and it should be easy to use them.
You could add some more first step documentation:

install rust using rustup
use the examples by calling: ...
what to do to convert the example script into an application which can be uses outside the current project

Thanks, I fixed the typo in the README.
If you're willing to submit specific improvements in a PR, that would be welcome as well!
I don't think we're ready to be marketed to people, who are not ready to learn Rust, yet, as we only have enough manpower to merge PRs.


Laravel drivers for queue and kv

Hi, @tarampampam. Is there a plan to implement larval drivers for RR KV and jobs module? It would be very useful, or, maybe, some samples you tried to implement. Thanks!

Hi @pvs9!
Currently, I have no plans to implement them (sorry for this, but I haven't enough free time for this) but would be great if someone (like you) make a Pull Request with a working solution or a separate package for this!


[Bug]: Broken Date is empty filter

Contact Details
No response
What happened?
Whenever I try and filter my view by a date property and ask if is empty, nothing happens to the view.
What platform were you using?
Desktop
Version of the plugin
2.8.3
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

It was an error on my end, there was a Date property and date property so the Date was taken as a priority.


Backend Mentors/Mentor Managers Certificate -Admin-App - Sprint 3

Create API EndPoints for  Certificate Lists
https://github.com/ALCOpenSource/Mentor-Management-System-Team-6/issues/27
@Munalula-Sikazwe please comment I want to assign to you.

@askinss
How are the certificates generated ?

@Munalula-Sikazwe good question, @peculiaruc is going to share with us on the TTL group, someone asked the question too.


LED Loading Effect

Description
Created a LED effect loading page using CSS
Fixes #94
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Explain the Testing instructions
Test Configuration:

Operating system:Windows
Text-editors used:Sublime Text Editor

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@photon149 please adjust the loader in the centre

Hey , I have updated it. Can you check once again.

I dunno why it shows the css file updated but the html one is showing updated in my forked directory but isnt showing to me in the request.It would be great if you can check that as well.

ok no problem @photon149 good work keep it up


Update request: binutils 2.40 → 2.41

Package name: binutils
Latest released version: 2.41

Current version on the unstable channel: 2.40
Current version on the stable/release channel: 2.40

[x] Checked the nixpkgs pull requests

Notify maintainers
@Ericson2314 @lovesegfault

Note for maintainers: Please tag this issue in your PR.

d0f26a4af195bf03b7e1a8fac387555ec7c80020 updated binutils.


Add subject_as_feature=True flag to Cora.load

This adds a flag to include the paper subject as one-hot encoded feature elements when loading the Cora dataset into a graph: Cora().load(subject_as_feature=True). This can then be used in the link predictions demos.
See: #1039

That's true, the change here was just reproducing the logic from the notebook, which was included when it was first added (https://github.com/stellargraph/stellargraph/pull/543). I'll try running the notebook without that, and see if the results change significantly. If not, we can potentially not add this extra complexity.

The accuracy seems to drop from consistently above 0.7 (usually around 0.75) to consistently below for the GCN example, so I'll leave it as it was with the subject included.


Option to Disable AI?

I work for a school district that restricts the use of AI in instructional technology tools online. Is there an option to disable the AI functionality of Excalidraw? If there is not an option, is that something that could be added to the service?

You can already disable the AI functionality with:
const options = { aiEnabled: false };

@Mrazator I'm not sure if you'd like to implement something more accessible in the UI to disable the AI functionality, but this could also make it easier for students to toggle the features back on, right?

Yeah, though I assumed the question was about the UI, as this prop isn't exposed to be turned on / off from the end user perspective.

To elaborate further, as of now, it's already exposed in https://plus.excalidraw.com/.


Added alt attributes to images for better lighthouse score

Added alt attributes to images (also the nunjucks file had a lot of spaces at line end, so fixed those as well).
The alt text added in template is: alt="{{language.value}} example of {{title}} in {{theme}} mode"
So for HTML light mode example will read: alt="html example of Anonymous Pro in light mode"
This bumps up the accessibility score:

also the lighthouse SEO score goes up from 80 => 90

It's still registering those lines as changed. Meh. I dunno. Not a huge deal it just makes it harder to understand the nature of the exact change.

Very good move having the proper alt text


Another plugin usage example

Similar to #31, but for remark-frontmatter and remark-mdx-frontmatter, which are plugins I'm interested in getting working (and since the main README claims remark-frontmatter as a working plugin, it'd be nice to document how to set that up). #31 should be merged first and then I can rebase on top of it--for now the history of the branch is ugly because I just forked that example (thanks for the project structure @icew4ll!), but I can clean that up (probably by integrating the two versions of the example into one).
I actually set out to document how this does not work right now, but with some help from remark-mdx-frontmatter maintainers, I got it working.
TODO:

[ ] wait for #31 to land
[ ] rebase
[ ] also update preact example

See also #30.

No need to review anything yet--I created the PR in draft mode because I think #31 should land first (though I guess it's been a while--if you think that PR is abandoned by the author, I can merge their changes into my PR and we can just continue here instead.)


[ScrollArea] Hardcoded div styles prevent text ellipsis from functioning reactively

Bug report
Current Behavior
In the ScrollAreaViewport component the styles applied to the hard-coded div
<div ref={context.onContentChange} style={{ minWidth: '100%', display: 'table' }}>
    {children}
</div>

don't allow a text ellipsis placed inside the viewport to behave responsively and resize along with its container. In particular it's the display: table which doesn't allow the would-be container to shrink.
This becomes a problem when more complex components than the one in my example are used as horizontal scrolling comes into place.
Problem video example
Expected behavior
Expected behavior example
Reproducible example
CodeSandbox Template
Suggested solution
Make the styles overwritable
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-scroll-area
0.1.4

React
react
18.1.0

Browser
firefox
100.0

Browser
Chrome
101.0.4951.54

Node
node
17.3.1

npm/yarn
yarn
1.22.18

Operating System
WSL2 - Ubuntu
20.04

Duplicate of #926


[datadog] add env var for dd agent host and port when apm is enabled

This PR adds 2 environment variables when APM is enabled, datadog agent host and port.  These changes reflect the datadog documentation for Tracing Kubernetes Applications.
@xvello @irabinovitch @hkaj
fixes #5671

Hello @JessicaGreben and thanks for your PR
From my understanding of the documentation, these envvars are to be used by your business application, on order to reach the service. What value do you expect in adding them to the agent's container itself?
To enable the service, one needs to update the service definition to be enabled with a common .Values.datadog.exposeService option instead of only the  .Values.deployment.enabled option. This is in our roadmap for the next weeks, but a contribution would be welcome on that.
The "big plan" is to merge back all .Values.daemonset and .Values.deployment options into the .Values.datadog object, in order to homogenise the two deployment cases, that diverged too much.
/hold

/assign

@xvello Thanks for your comments.  I misread the documentation and I see now that those env vars are for the application container. Brain fart! Thanks for the clarification.
Good to know the roadmap for exposeService. Thanks for the info!


feat(bootstrap): support Bootstrap 4 Beta

What kind of change does this PR introduce? feature
Fixed #501

This change is

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   93.65%   93.65%
=======================================
  Files          16       16
  Lines         725      725
  Branches      205      205
=======================================
  Hits          679      679
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dac2b9...a0f84b2. Read the comment docs.


Remove unused lifecycle hook from intro example

For #73. Small readme change for intro example, to remove lifecycle hook reference from previous example code.

Thanks!


<EMAIL_ADDRESS>download via aria2 failed

Looks like the link is invalid
Updating 'hwinfo' (7.42-5030 -> 7.44-5100)
Downloading new version
Starting download with aria2 ...
Download: 05/10 10:44:45 [ERROR] CUID#8 - Download aborted. URI=https://download.fosshub.com/Protected/expiretime=1683790686;badurl=aHR0cHM6Ly93d3cuZm9zc2h1Yi5jb20vSFdpTkZPLmh0bWw=/30b122bd168c16d7fe3da0797d6ea9c1b5a1e98e992f40607f464288d44Download: Exception: [AbstractCommand.cc:351] errorCode=3 URI=https://download.fosshub.com/Protected/expiretime=1683790686;badurl=aHR0cHM6Ly93d3cuZm9zc2h1Yi5jb20vSFdpTkZPLmh0bWw=/30b122bd168c16d7fe3da0797d6ea9c1b5a1e98e992f40607f464288d4447Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: e969b9|ERR |       0B/s|C:/Users/.../scoop/cache/hwinfo#7.44-5100#https_www.fosshub.com_HWiNFO.html_hwi_744.zip
Download: Status Legend:
Download: (ERR):error occurred.
Download: aria2 will resume download if the transfer is restarted.
Download: If there are any errors, then see the log file. See '-l' option in help/man page for details.
ERROR Download failed! (Error 3) Resource was not found
ERROR https://download.fosshub.com/Protected/expiretime=1683790686;badurl=aHR0cHM6Ly93d3cuZm9zc2h1Yi5jb20vSFdpTkZPLmh0bWw=/30b122bd168c16d7fe3da0797d6ea9c1b5a1e98e992f40607f464288d4447d1f/5b969867e5c78775cb187a52/645b9703a47d49012f526bf4/hwi_744.zip
referer=https://www.fosshub.com/HWiNFO.html/
dir=C:\Users...\scoop\cache
out=hwinfo#7.44-5100#https_www.fosshub.com_HWiNFO.html_hwi_744.zip

I'm not in a corporate or firewalled environment. There's no proxy configured. All other apps download fine.
I disabled the aria and retried the download with the same results:
~ ❯ scoop cache rm hwinfo                                                                                10:52:59
Removing https_www.fosshub.com_HWiNFO.html_hwi_730.zip...
Removing https_www.fosshub.com_HWiNFO.html_hwi_732.zip...
Removing https_www.fosshub.com_HWiNFO.html_hwi_734.zip...
Removing https_www.fosshub.com_HWiNFO.html_hwi_736.zip...
Removing https_www.fosshub.com_HWiNFO.html_hwi_740.zip...
Removing https_www.fosshub.com_HWiNFO.html_hwi_742.zip...
Deleted: 6 files, 58.5 MB
~ ❯ scoop update                                                                                10:53:07
Updating Scoop...
Updating 'extras' bucket...
Updating 'games' bucket...
Updating 'java' bucket...
Updating 'main' bucket...
Updating 'nirsoft' bucket...
Updating 'nonportable' bucket...
Updating 'versions' bucket...
Scoop was updated successfully!
~ ❯ scoop config aria2-enabled false                                                                          10:53:24
'aria2-enabled' has been set to 'false'
~ ❯ scoop update hwinfo                                                                                10:53:36
hwinfo: 7.42-5030 -> 7.44-5100
Updating one outdated app:
Updating 'hwinfo' (7.42-5030 -> 7.44-5100)
Downloading new version
OperationStopped: C:\Users...\scoop\apps\scoop\current\lib\install.ps1:111
Line |
111 |          throw $e
|          ~~~~~~~~
| The remote server returned an error: (404) Not Found.


Make callback optional when using set method

Hello! I show user some rating with pre-initialized values. I initialize them using  ('select').barrating('set', value); method and I don't want it to trigger any callback, I need callback only when user himself clicks rating. Could you make an option to disable callback when using  $('select').barrating('set', value); metod?

And just for fun - here's what I've done with the help of your rating plugin:

Looks phantastic @jehy
You are the second person to request that the callbacks are not fired when the rating is controlled with the set method. The silent option will help in your case I think. You can try it out by getting the plugin from master.

Thanks!


fixes Output domain "!=" constraint

typo?

Indeed. Output domain checks solved values, to be used in conditions and such.


BF: Update joblib parallel args

This PR fixes an import error in newer versions of sklearn but removing the _joblib_parallel_args functions and passing prefer directly to joblib.Parallel.

Coverage decreased (-0.002%) to 97.028% when pulling 3688b5a32aae5c482177f151cc8872da47974d9b on enh/update-joblib-parallel-params into 3b953e26dcff25eab87c3ca03e786569065b6e92 on main.


Disabling nodes doesn't work as explained in the article

I followed this guide step by step without making any modifications and I am at the step where I disable the nodes on the original scaleset. Currently it runs for more than 16 hours and there doesn't seem anything to happen. The nodes are marked as disabling and it just stays like that. When I check system services they are still running on NTvm1* nodes. Also the template seem kind of questionable as in the documentation it mentions that the new scaleset is added to the primary scale set using the setting properties->virtualMachineProfile->extensionProfile->extensions->properties->settings->nodeTypeRef but this property currently points to vmNodeType2Name which is the new scaleset that we add and not primary scale set.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f10dbe04-cac1-df88-d2d8-38436eb0b256
Version Independent ID: 5db6c5bd-6670-0bf6-08fe-c40fb82b661c
Content: Scale up an Azure Service Fabric node type - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-scale-up-node-type.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

@sistoimenov
Thanks for bringing these issue to out attention and providing the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@athinanthny
Can you please check and add your comments on this doc update request as applicable.

I am doing some more tests and experiments with this and I will keep you updated.

We recently overhauled this document and the changes address the issues/suggestions raised here, including nodetype naming discrepancies and step-by-step templates included in the sample repo. #please-close

We recently overhauled this document and the changes address the issues/suggestions raised here, including nodetype naming discrepancies and step-by-step templates included in the sample repo. #please-close


Add info on env variables for Formula Cookbook

This explains the levels of environment variable filtering present in Homebrew, explaining how and why variables without a HOMEBREW_ prefix or those which contain TOKEN etc are made unavailable to a Formula.
Previously, this behaviour was unclear (eg HOMEBREW_FOO works but HOMEBREW_TOKEN didn't) so I've added this documentation with references explaining the process.   There may be other env filtering at work, but these are the two levels that were influencing my attempts to figure out why a third party formula written some time ago was no longer able to see its environment variable.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] ~Have you written new tests for your changes? Here's an example.~
[ ] ~Have you successfully run brew style with your changes locally?~
[ ] ~Have you successfully run brew tests with your changes locally?~

@MikeMcQuaid PR updated with the changes, plus some improvements in readability for the rest.

Thanks so much for your first contribution!  You rock, @davidjb!


Port Applaunch

Addressed comments above.
Additionally:

Added commits to alter the way assets are deployed to be able to be used more generically.
Applaunch now deploys required uiauto apk files as assets.
Fixed applaunch not cleaning up after itself properly.


Detailed Description
Playing a 5 requires the player to discard a card, then draw 3, but the dialog is bugged to allow you to "discard" the card you discarded last time even if it's not in your hand.
Current Behavior
No response
Expected Behavior
No response
Steps to Reproduce

Play a 5
Play a second 5 and hit "Discard and draw" without selecting a new card for discard
You'll draw 3 cards without discarding

fixed by #902


Remove amf and smf from free5gc-cp packages

Looks like a bunch of other commits got mixed in, can you try again?


[Cognitive Services - Language - Text API] Enable resolutions for Named Entity Recognition

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue: https://github.com/Azure/azure-rest-api-specs/issues/20051

Is this review for (select one):

[ ] a private preview
[X] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@bidisha-c should the output of PII also updated from the plain entities to the new ones?

No for now resolutions are only being added for NER. For PII it might not be essential to resolve to a PII entity to a normalized value as the objective of the service is to detect the PII and redact PII.


Manufacturer Specific Data is improperly parsed

I switched from https://github.com/NordicSemiconductor/Android-BLE-Library to use this library today and during scanning, manufacturer specific data is not being parsed properly. I am seeing two ids when there should be one and both DataByteArrays are empty. I can see the proper bytes in the bytes property of the scan record. Android-BLE-Library parses it correctly and so does NRFConnect.

I am also running into this issue. From what I've seen in a debugger, this seems to be happening during the conversion from a ScanRecord to a BleScanRecord in the "ScanRecord.toDomain" function in no.nordicsemi.android.kotlin.ble.scanner.data. The SparseArray mapping in no.nordicsemi.android.common.core:
fun <T, R> SparseArray<T>.map(
    modifier: (T) -> R,
): SparseArray<R> {
    val newArray = SparseArray<R>(this.size())
    for (i in 0..this.size()) {
        newArray[i] = modifier(this[i])
    }
    return newArray
}

treats the SparseArray as a dense array in the for loop. I don't expect this to map the data correctly unless the SparseArray keys are exactly inside that [0, this.size()] range.
I am working with a peripheral that advertises one piece of manufacturer specific data but the conversion also returns a SparseArray with two empty elements.

Thanks for the detailed analysis. It helped a lot. The fix should be included in a next version - 1.0.9.


Updated raw mission example + removed deprecations

Updated MAV_FRAME command from 6 (deprecated) to 3 (newly updated WGS84 + rel. system)

Also added a few comments to make comprehension easier

Refactored file

Looks like it just needs the style fixes and then it's good to go.

Looks like it just needs the style fixes and then it's good to go.

Made the styling fixes :+1:

Thanks!


Example of text-generation from model

Our code also allows you to turn your suffix array index into an efficient n-gram language model, which can be used to generate text or compute the perplexity of a given text.

Looking for a simple demo of this, thanks

Hey, thanks for the question! Here's a text generation example: https://colab.research.google.com/drive/1CEHoIjLboGl8YPbIqnWJlPYMm1wVOrrj?usp=sharing
Let me know if you have any issues!


MM-20437 - migrate close channels to typescript

Summary
This converts the close channel component  to TypeScript.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/16137

Hello @pablovelezvidal,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hello @pablovelezvidal,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

/update-branch

/update-branch

/update-branch

/update-branch

/update-branch


jQuery.ui.sortable not working

Hello,
I cant get the sortable function to work for my example. See following plnkr for a working example: https://plnkr.co/edit/cYVEf4K4vE3whB6g?preview
Trying to drag the items will result in a console error Uncaught TypeError: Cannot read property 'msie' of undefined
Am I doing something wrong? Other than that I love this library, as I was building a expandable form with nested arrays before myself 👍

Hi @SteveG3R
You can try this example: https://jsonform.github.io/jsonform/playground/index.html?example=templating-idx and look at the playground page code to see how it is done. you might be missing a dependency somewhere
BR

Hi @SteveG3R
You can try this example: https://jsonform.github.io/jsonform/playground/index.html?example=templating-idx and look at the playground page code to see how it is done. you might be missing a dependency somewhere
BR

Hello @tchapi ,
any idea what that could be as I followed the Documentation and implemented all Files.
Apart from the default that got listed here: https://github.com/jsonform/jsonform/wiki#getting-started

deps/jquery.min.js
deps/underscore.js
deps/opt/jsv.js
lib/jsonform.js

I added the ones that got listed here: https://github.com/jsonform/jsonform/wiki#dealing-with-arrays

deps/opt/jquery.ui.core.js
deps/opt/jquery.ui.widget.js
deps/opt/jquery.ui.mouse.js
deps/opt/jquery.ui.sortable.js

I updated the plnkr (https://plnkr.co/edit/cYVEf4K4vE3whB6g) with your mentioned playground page. It is the same form now but is still not working with the same error.

Sorry to bother again, but any Idea? The Documentation does not state to implement any other library.

Hello @tchapi ,
any idea what that could be as I followed the Documentation and implemented all Files.
Apart from the default that got listed here: https://github.com/jsonform/jsonform/wiki#getting-started

deps/jquery.min.js
deps/underscore.js
deps/opt/jsv.js
lib/jsonform.js

I added the ones that got listed here: https://github.com/jsonform/jsonform/wiki#dealing-with-arrays

deps/opt/jquery.ui.core.js
deps/opt/jquery.ui.widget.js
deps/opt/jquery.ui.mouse.js
deps/opt/jquery.ui.sortable.js

I updated the plnkr (https://plnkr.co/edit/cYVEf4K4vE3whB6g) with your mentioned playground page. It is the same form now but is still not working with the same error.

Sorry to bother again, but any Idea? The Documentation does not state to implement any other library.

I think jQuery UI sortable needs more than these dependencies. You should include the whole jquery-ui package (like in the playground).
Keep me posted if that works

I think jQuery UI sortable needs more than these dependencies. You should include the whole jquery-ui package (like in the playground).
Keep me posted if that works

Got it working with the JS File jquery-ui.js
Removed all the mentioned JS Files from https://github.com/jsonform/jsonform/wiki#dealing-with-arrays

deps/opt/jquery.ui.core.js
deps/opt/jquery.ui.widget.js
deps/opt/jquery.ui.mouse.js
deps/opt/jquery.ui.sortable.js

Probably should update the documentation with that information since you dont need these.

Got it working with the JS File jquery-ui.js
Removed all the mentioned JS Files from https://github.com/jsonform/jsonform/wiki#dealing-with-arrays

deps/opt/jquery.ui.core.js
deps/opt/jquery.ui.widget.js
deps/opt/jquery.ui.mouse.js
deps/opt/jquery.ui.sortable.js

Probably should update the documentation with that information since you dont need these.

I have updated the documentation — thanks !

I have updated the documentation — thanks !


Feature Request: No-op feature flag

When using flamegraph profiling rayon pollutes the call stack making it very hard to find my code in the graph, and I have to manually replace all instances of par_. It'd be nice if I could instead enable a feature flag in rayon so that I don't have to change every code instance and just have to change Cargo.toml that simply made all parallel iterator calls sequential. I've included two graphs below with and without rayon calls to show the disparity between the two.
With rayon

Without rayon

Making this a feature makes me a bit nervous — if you accidentally committed it, or published with it, it would propagate to all your dependencies etc...
We could make a cfg setting that you have to set up with RUSTFLAGS easily enough though.

Is it good enough for you to just use RUST_NUM_THREADS=1 in your environment?  You'll still see some rayon in your callstack this way, but it should be greatly reduced.
AIUI flamegraph does a lot of post-processing in scripts.  I wonder if you could just filter unwanted rayon symbols from your stacks that way?  Then you'll still be representing the parallel workload otherwise, which could be helpful.

@nikomatsakis That concern is completely valid. I was just using feature as an example. Any solution that is a single switch to flip is equally satisfactory.
@cuviper I've attached below what it looks like with RUST_NUM_THREADS=1 while it is shallower, it is still far from readable in my opinion.

We could make a cfg setting that you have to set up with RUSTFLAGS easily enough though.

That sounds like a great solution!

We could make a cfg setting that you have to set up with RUSTFLAGS easily enough though.

Hi. Is there any update on this? I see that the issue has been open for 4 years now. Just wanted to check if it will be picked up some time later this year. I also have the same use case (cleaning up perf output) and would love to have this!
If no one is taking a shot, I can try making a pull request (disclaimer: I haven't looked at rayon internals till now). Any pointers would be really helpful!

Also see the discussion in #861, but I'm not aware of anyone actually working on it yet.

I believe this was closed by #1019 / #861?

Not entirely -- I think OP wanted this on platforms that do support threads well, but all the work-stealing makes it hard to decipher what's going on in tools that look at backtraces, like flamegraph.
I have had luck using cargo flamegraph --skip-after=SYMBOL when there a decent entry point into the parallel work to filter on, or even just using the rayon_core::join::... functions in some cases. Then it can run fully parallel and still get a decently understandable flamegraph image.

Not entirely -- I think OP wanted this on platforms that do support threads well

Ah so the functionality is there, but the --cfg opt-in is still missing.

You could also set threads=1 and use_current_thread (#1063).


Please help me get the rotary knob to work

Okay, so I gave up on the sound issues and a few other things and I installed this box around a 50 times now, threw >150 EUR at things like soldering iron, cables etc. I want to conclude this section now and just live with a semi-working box where I can at least change the volume properly.
I bought exactly the hardware specified here: https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Audio-RotaryKnobVolume
I used female to female cables to connect the pins as in the ASCII image.
I installed the script(s) as instructed, The service phoniebox-rotary-encoder is running. When typing sudo systemctl status phoniebox-rotary-encoder it returns
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK MPD 0.21.4
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: expr: syntax error: unexpected argument '10'
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: ./scripts/playout_controls.sh: Zeile 214: [: -le: Einstelliger (unär
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK MPD 0.21.4
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: expr: syntax error: unexpected argument '10'
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: ./scripts/playout_controls.sh: Zeile 214: [: -le: Einstelliger (unär
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK MPD 0.21.4
Feb 25 18:11:31 raspberrypi rotary-encoder.py[448]: OK
I can turn the knob like hell, but it won't change the volume at all...........
I bought a second knob. Same result.
I triple checked all the cables.
CLK -> PIN29
DT -> PIN31
GND -> PIN30
plus symbol -> PIN17
I am using an external USB sound card, maybe this is the reason?
For the love of god, please help me end this torture. The phoniebox turned out to be far more expensive and a pain in the ... than simply buying a toniebox. I just want this to work and then never touch it again :) I'm desperate and tired, sorry :(

@veloxidSchweiz worked on the rotary knobs and maybe can help.

I can see that line 214 in playout_controls.sh has changes in develop to master, but need to investigate further, what's the exact issue. I don't have any experience with rotary knobs.

Hi @hoodvisions ,
You could try my branch to check  at least the functionality.
I am still working on the code but yesterday I tried it and it was working perfect.
https://github.com/veloxidSchweiz/RPi-Jukebox-RFID/blob/feature/configureableGPIOButtons/components/gpio_control/GPIODevices/rotary_encoder.py
Executing this file (with python3) will allow you test the knob. It will ask you for the pins and then when turning the knob you see if increase/decrease are recognized.
You LL be a

@veloxidSchweiz I tried this, thanks. Now, it asks me for the PINS and then says "running". When turning the knob nothing happens.
I have used these cables here: https://www.amazon.de/gp/product/B01EV70C78/ref=ppx_yo_dt_b_asin_title_o00_s00?ie=UTF8&psc=1 Is it possible these don't work?

Okay so when I HOLD the rotary knob in one of these tiny "edges" (you know, that little resistance when turning it) I get a signal. So a friend wrote me a script that spills out all GPIO signals each second and holding or turning the knob like hell leads to signals sometimes being recognized.
So I think the issue here is the Phoniebox simply cannot read these signals due to python being too slow maybe? Right now the knob https://www.amazon.de/gp/product/B07TKK4QQD/ref=ppx_yo_dt_b_asin_title_o04_s00?ie=UTF8&psc=1 is not working out of the box. :(

Hi @hoodvisions,
I do have the same knobs and do not have any problems at all...
The cables look fine as well. At the moment my box is closed and i cannot check to which supply voltage i connected the knob (5V vs 3.3V).

This is weird... I have reinstalled everything from scratch again, but same results. I will assume that the knobs are simply both nonfunctional and purchase another one from a different vendor maybe.

In the meantime a friend of me bought the exact same hardware. Run the setup etc but the rotary simply doesn't work. And he found out that it is about the external soundcard. So the rotary only changes volume when using the internal soundcard, but not an external USB soundcard.
Is there any setting somewhere to be found to tell the script to use the correct soundcard instead?

Please check here https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Troubleshooting-FAQ#audio-is-not-working how to change the alsa.conf

Many thanks!!
Okay, so here is how it works when using "my" USB external Soundcard with the CM108 chipset by Sabrent:
sudo nano /usr/share/alsa/alsa.conf
Change defaults.ctl.card 0 and defaults.pcm.card 0 to defaults.ctl.card 1 and defaults.pcm.card 1 depending on your soundcard. ( https://learn.adafruit.com/usb-audio-cards-with-a-raspberry-pi/updating-alsa-config )
SO if you now end up like me where a hardware knob and software volume buttons don't do anything, you need to do this:
sudo nano /etc/mpd.conf
and look for this:
` # An example of an ALSA output:

audio_output {
        type            "alsa"
        name            "My ALSA Device"
#       device          "hw:0,0"        # optional
#       mixer_type      "software"      # optional
#       mixer_device    "default"       # optional
#       mixer_control   "PCM"           # optional
#       mixer_index     "0"             # optional
}`

and uncomment (delete # in front of) mixer_type "software".
sudo reboot
Now not only the playback works but also the volume settings do as well as the rotary knob linked in the manual :)
Thanks a lot for your help, guys!


Update README for Smart Answer flows

Add save_input_as to the list of methods that can be used to store data for
use later in the flow.

Move save_input_as further down in the example flow to illustrate when it's
actually called.

LGTM


[video_player] Caching for network data source

Description
This PR improves other PR to speed up the process of merging of this feature
Adapt caching to the new structure of video plugin.
Add tests.
Pass maxCacheSize and maxCacheFileSize to platform only on plugin initialization because it is unnecessary to pass it on each creation of VideoController.
Pass useCache property to platform only for network data source.
Fix bug with disposeAllPlayers which wasn't called on plugin initialization as intended.
Also on platform side in init wasn't called result.success after success which leads to hangs.
Related Issues
https://github.com/flutter/flutter/issues/28094
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

@googlebot I consent.

Occasionally video jam and green screen appear on IOS platform

I signed the CLA or whatever you need to finish this or whatever I don't know.

Are there any updates on merging this PR?

What's blocking this from being merged? Should https://github.com/flutter/plugins/pull/2130 be closed as a duplicate of this PR?

@lukepighetti Hello.
We are waiting for review.
#2130 can be closed as PR owner absent for a very long time.

Is there any way to get this review more visibility? Our production app would benefit greatly from this landing and we've been tracking it for a few months now.

I'm running the dependency by overriding it in chewie directly from git and it works great! Kudos to the author @sanekyy really saved me a lot of trouble!

I'm running the dependency by overriding it in chewie directly from git and it works great! Kudos to the author @sanekyy really saved me a lot of trouble!

This PR has been carted around GitHub quite a bit. Original work was done by @999eagle, I patched a few things. PR can be seen here. https://github.com/flutter/plugins/pull/2130/commits For some reason that PR was cannibalized into this one when @sanekyy did a considerable amount of work bringing it up to date. However, it has unfortunately now been stale for a while and people are releasing their own versions on pub instead of this getting finalized into video_player.

@lukepighetti you're right while searching for possible solutions the ones I came across were to use (flutter_cache_manager)[https://pub.dev/packages/flutter_cache_manager] to cache and stream the video which basically downloads the video twice. The other package I came across was cached_video_player while this works very well, its a lot more trouble to build all the controls from scratch.
I wish I could do anything to help fast track this process.

Hi @sanekyy,
The PR works great, do you know how to use your updated video_player with packages like chewie, that use the "default" video_player?
I have tried this:
dependency_overrides:
  video_player:
    git:
      url: https://github.com/sanekyy/plugins.git
      ref: caching
      path: packages/video_player/video_player

But I get this error
Because my_flutter_project depends on dependency_overrides from unknown source "video_player", version solving failed. pub get failed (1; Because my_flutter_project depends on dependency_overrides from unknown source "video_player", version solving failed.) exit code 1

Hey Jonas,
Could you send your entire pubspec.yaml file because I pretty much did the exact same thing and it worked like a charm.
Regards,
Ajay Rajnikanth

On 3 Jul 2020, at 6:57 PM, JonasJW<EMAIL_ADDRESS>wrote:

Hi @sanekyy,
The PR works great, do you know how to use your updated video_player with packages like chewie, that use the "default" video_player?
I have tried this:
dependency_overrides:
video_player:
git:
url: https://github.com/sanekyy/plugins.git
ref: caching
path: packages/video_player/video_player
But I get this error
Because my_flutter_project depends on dependency_overrides from unknown source "video_player", version solving failed. pub get failed (1; Because my_flutter_project depends on dependency_overrides from unknown source "video_player", version solving failed.) exit code 1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @Raikan10,
Sure, this is my pubspec.yaml
name: my_flutter_project

version: 1.0.0+1

environment:
  sdk: ">=2.2.2 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  provider:
  rxdart:
  cupertino_icons: ^0.1.2
  flutter_svg: ^0.17.1
  flutter_tts: ^0.9.1
  audioplayers: ^0.15.1
  wakelock: ^0.1.4+1
  flutter_html: ^0.11.1
  url_launcher: ^5.4.2

  # video_player: ^0.10.8+1
  dependency_overrides:
    video_player:
      git:
        url: https://github.com/sanekyy/plugins.git
        ref: caching
        path: packages/video_player/video_player
  chewie: ^0.9.10

dev_dependencies:
  flutter_test:
    sdk: flutter

  build_runner:
  json_serializable: ^3.3.0
  flutter_launcher_icons: "^0.7.3"

I'm running the dependency by overriding it in chewie directly from git and it works great!

How exactly did you override it in chewie? Do you mean you forked chewie, override the video_player dependency and installed your git repo as the chewie package? That is what works for me but overriding the video_player in my flutter project won't work for some reason.

Hey,
so you can use chewie as you would normally use it with the regular
video_player pub. The mistake I seem to notice here is that you need to
have your dependency_overrides block of code outside of your dependencies
block.
Basically just sub-indent that block of code and it should work fine.
Regards,
Ajay
On Sat, 4 Jul 2020 at 2:08 PM, JonasJW<EMAIL_ADDRESS>wrote:

Hi @Raikan10 https://github.com/Raikan10,
Sure, this is my pubspec.yaml
name: my_flutter_project
version: 1.0.0+1
environment:
sdk: ">=2.2.2 <3.0.0"
dependencies:
flutter:
sdk: flutter
provider:
rxdart:
cupertino_icons: ^0.1.2
flutter_svg: ^0.17.1
flutter_tts: ^0.9.1
audioplayers: ^0.15.1
wakelock: ^0.1.4+1
flutter_html: ^0.11.1
url_launcher: ^5.4.2
video_player: ^0.10.8+1
dependency_overrides:
video_player:
git:
url: https://github.com/sanekyy/plugins.git
ref: caching
path: packages/video_player/video_player
chewie: ^0.9.10
dev_dependencies:
flutter_test:
sdk: flutter
build_runner:
json_serializable: ^3.3.0
flutter_launcher_icons: "^0.7.3"
I'm running the dependency by overriding it in chewie directly from git
and it works great!
How exactly did you override it in chewie? Do you mean you forked chewie,
override the video_player dependency and installed your git repo as the
chewie package? That is what works for me but overriding the video_player
in my flutter project won't work for some reason.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/plugins/pull/2429#issuecomment-653739444, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5XXFFQP5RA4BJOH2LFCUDRZ3S7TANCNFSM4J4BVYPA
.

Thank you @Raikan10, it works now

Hey, so you can use chewie as you would normally use it with the regular video_player pub. The mistake I seem to notice here is that you need to have your dependency_overrides block of code outside of your dependencies block. Basically just sub-indent that block of code and it should work fine. Regards, Ajay
…
On Sat, 4 Jul 2020 at 2:08 PM, JonasJW @.***> wrote: Hi @Raikan10 https://github.com/Raikan10, Sure, this is my pubspec.yaml name: my_flutter_project version: 1.0.0+1 environment: sdk: ">=2.2.2 <3.0.0" dependencies: flutter: sdk: flutter provider: rxdart: cupertino_icons: ^0.1.2 flutter_svg: ^0.17.1 flutter_tts: ^0.9.1 audioplayers: ^0.15.1 wakelock: ^0.1.4+1 flutter_html: ^0.11.1 url_launcher: ^5.4.2 # video_player: ^0.10.8+1 dependency_overrides: video_player: git: url: https://github.com/sanekyy/plugins.git ref: caching path: packages/video_player/video_player chewie: ^0.9.10 dev_dependencies: flutter_test: sdk: flutter build_runner: json_serializable: ^3.3.0 flutter_launcher_icons: "^0.7.3" I'm running the dependency by overriding it in chewie directly from git and it works great! How exactly did you override it in chewie? Do you mean you forked chewie, override the video_player dependency and installed your git repo as the chewie package? That is what works for me but overriding the video_player in my flutter project won't work for some reason. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2429 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5XXFFQP5RA4BJOH2LFCUDRZ3S7TANCNFSM4J4BVYPA .

Is it possible for us to work on merging this in. I guess this has been a super slow review process and I'm guessing the original owner wasn't active?

Hello @ngoctranfire
I'm here and waiting for review.

For some reason I'm having issues using VideoPlayerController.file() with this PR. It seems to work fine with the master.
I'm using flutter_cache_manager to download a file.

I have created this PR to address the described issue above

Any update on this?

Does anyone know how I can use video_player: ^0.10.12 with this PR? When I upgrade video_player: ^0.10.8+1 to video_player: ^0.10.12 it doesn't seem to actually use the new version because the new videoPlayerOptions parameter is not available.

any progress on this ?

Can anyone tell me why this hasn't been reviewed? Is it missing something that is needed for review?

Any update?

This is a great feature or even must have for any apps playing lots of videos. Any way to expedite it?

I also don't understand why this is taking so long. Maybe it's because this PR is not on the radar of anybody from the flutter developer team?

@dnfield Sorry to ping you but I'm out of ideas. Is there any way for us to get visibility on why this hasn't been reviewed?

I don't have much context here.  @amirh may know.  It does need to be merged up to head.

It would be really lovely to get this merged.
This is a really important feature to me,
and the packages that float around that do this arent really any good or maintained it seems.

Trying to get some answers on Twitter... hope to hear back from someone soon: https://twitter.com/luke_pighetti/status/1312126777527988224

@mklim Is there a chance for you to review this in the next time?

I need this feature.

I need this feature.

Google has a different opinion

I need this feature.

Google has a different opinion

I need to play hls; cached_video_player has some other bugs; and it seems flutter_cache_manager only cache a single file

This PR needs to be merged up to head so it can properly be reviewed. If that can happen we can look at reviewing it and getting it merged. If the original author is not able to do that and someone else wants to try that's fine.
This is not an issue of whether "Google" wants this or not, it's an issue of getting the work needed done and getting someone to review it :)

@sanekyy are you able  to merge this up to head? I would do it but it's your branch ATM.

@lukepighetti, yes I plan to do it ASAP

This isnt using the flutter cache manager, right?
Wouldve been cool to be honest, because it would allow to precache files.

This isnt using the flutter cache manager, right?
Wouldve been cool to be honest, because it would allow to precache files.

This is for a different use case. Buffer streaming a video and simultaneously caching it. Not pre-downloading videos and then playing them as a file.

@sanekyy  when will you merge it . thanks;

@iskakaushik @cyanglaz  @mklim  could you please help review the code?

This still has merge conflicts.  It also appears that you've added other people's commits into this PR, perhaps unintentionally. Can you fix up the problems?

@sanekyy could you please help fix the problem.

it seems the process is stopped again.

Hello @wanjm. We will fix this ASAP.

When do you think this will be merged to the official video_player plugin?
Also, @sanekyy I understand that if we set useCache: true in a Network data source, the streamed video will simultaneously be cached. Next time we create a video_player with the exact same network source url, the cached file will be used instead of downloading again which is great.
However, do we have a reference to the cached file with this API? or a callback to notify us if the file is complete and ready to be used by other processes?
For instance when the cache file is ready, let's say I would like to save the video to the gallery of the user. How can I do that?

That feature was outside the scope of the original PR.

@lukepighetti I understand. Do you advise me to open up a new issue for the use case I stated above?
My first priority is this PR to land too:) But I think next to video caching, it is not too hard to implement an API to return the file's reference.

Just my opinion but an issue like that is unlikely to get traction. I'd recommend starting a new PR based on this one, ideally after it merges.

Just my opinion but an issue like that is unlikely to get traction. I'd recommend starting a new PR based on this one, ideally after it merges.

I hope this gets merged this week. It has taken much longer than necessary. Once it does, I will do as you said and start a new PR

We cannot review, let alone merge, this PR until it's merge conflicts are fixed up.
It will also need appropriate tests to be merged.
If the original author is not available to fix this, I would recommend someone who is interested and able take it over.

We cannot review, let alone merge, this PR until its merge conflicts are fixed up.
It will also need appropriate tests to be merged.
If the original author is not available to fix this, I would recommend someone who is interested and able take it over.

The author constantly corrects conflicts, but you so rarely enter this PR that new conflicts appear

Ahh, sorry about that. There's a lot going on these days. I'll try to start reviewing this, but it should probably get a lookover by @cyanglaz and @ditman as well.

any update on this?

Hello @gabdsg
Don't have enough time for now.
Will continue working on with PR ASAP.

Hi @sanekyy ,
Hope you have a nice day.
Because the project I am developing now needs to use network video caching, thank you for your help. I forked your branch into my project and found that there are some areas for improvement.

We can increase the parameter of “cacheKey”. Now many caches have developed such parameter settings, because only using url as the cache key will encounter some thorny problems. For example, the video address obtained from the server is changed, and the request is multiple times. The url of the same video address is different. But the cacheKey we keep is the same.
Fortunately, Android exoplayer has such a method to set the cached Key, as follows:

        return new ExtractorMediaSource.Factory(mediaDataSourceFactory)
            .setExtractorsFactory(new DefaultExtractorsFactory())
            .setCustomCacheKey(cacheKey)
            .createMediaSource(uri);

But the VIMediaCache you use in IOS lacks such a way to customize the cache key. I tried to change the source code of
VIMediaCache to achieve this function.
I believe “cacheKey” is still needed for most people.

IOS cache directory is inconsistent with Android. The cache address in Android is video in the cache directory, while IOS is placed in the tmp directory by default. The IOS address can be changed, I hope the two can be consistent.

The above is my suggestion, thank you.

waiting waiting

hurry up

hurry up

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

@sanekyy I know you are busy lately, but could you please sign the CLA? This PR is very important for the community. We can save megabytes of wasted bandwidth :D

@sanekyy I know you are busy lately, but could you please sign the CLA? This PR is very important for the community. We can save megabytes of wasted bandwidth :D

There are three PRs with varying CLA status. I cannot see the CLA bot status to see who is missing, but here are the three PRs that I'm aware of. If the bot is looking for CLA from the first PR, those are complete, but in a different PR.
https://github.com/flutter/plugins/pull/2130
https://github.com/flutter/plugins/pull/2406
https://github.com/flutter/plugins/pull/2429

There are three PRs with varying CLA status. I cannot see the CLA bot status to see who is missing, but here are the three PRs that I'm aware of. If the bot is looking for CLA from the first PR, those are complete, but in a different PR.
https://github.com/flutter/plugins/pull/2130
https://github.com/flutter/plugins/pull/2406
https://github.com/flutter/plugins/pull/2429

I've been babysitting this PR for 15 months. I have never in my life seen such a complete disregard for the time of contributors. I'm done.

I've been babysitting this PR for 15 months. I have never in my life seen such a complete disregard for the time of contributors. I'm done.

@hixie @cyanglaz Can we come up with a plan to resolve CLA. I think @999eagle is not available to sign CLA. I can sign another CLA. @sanekyy might be available to sign another CLA? If we can resolve that I think we will have a clear path to victory.

@hixie @cyanglaz Can we come up with a plan to resolve CLA. I think @999eagle is not available to sign CLA. I can sign another CLA. @sanekyy might be available to sign another CLA? If we can resolve that I think we will have a clear path to victory.

Here's the info about missing CLAs for this PR (I'm removing email addresses):

user
status

@lukepighetti
need_author_consent

@wwwdata
need_author_consent

@includecmath
need_author_consent

@hiiamalanou
need_author_consent

@999eagle
need_author_consent

@yuwen-yan
need_author_consent

Here's the info about missing CLAs for this PR (I'm removing email addresses):

user
status

@lukepighetti
need_author_consent

@wwwdata
need_author_consent

@includecmath
need_author_consent

@hiiamalanou
need_author_consent

@999eagle
need_author_consent

@yuwen-yan
need_author_consent

@cyanglaz I don't have Contributor perms so I can't handle these dangling PRs.
https://github.com/flutter/plugins/pull/2130 can be closed
https://github.com/flutter/plugins/pull/2406 can be closed
https://github.com/flutter/plugins/pull/2429 status unclear until we have a plan methinks

@cyanglaz I don't have Contributor perms so I can't handle these dangling PRs.
https://github.com/flutter/plugins/pull/2130 can be closed
https://github.com/flutter/plugins/pull/2406 can be closed
https://github.com/flutter/plugins/pull/2429 status unclear until we have a plan methinks

@googlebot I consent.

@googlebot I consent.

@lukepighetti @sanekyy
I apologize for causing confusions. I closed this PR because it can't be merged due to CLA issues. I'd recommend fixing the CLA issue or fork a new PR. If the CLA issue is fixed, I'm more than happy to re-open it.

@lukepighetti @sanekyy
I apologize for causing confusions. I closed this PR because it can't be merged due to CLA issues. I'd recommend fixing the CLA issue or fork a new PR. If the CLA issue is fixed, I'm more than happy to re-open it.

Also, it seems this PR touches all video_player_* packages, but those can't be merged all at the same time (we can't publish git dependencies, for example).
This PR will need to be split in 3 different PRs and merged in the correct order (normally): video_player_platform_interface, video_player_web (if it's independent to the video_player code, or backwards compatible), and then the video_player package.

Also, it seems this PR touches all video_player_* packages, but those can't be merged all at the same time (we can't publish git dependencies, for example).
This PR will need to be split in 3 different PRs and merged in the correct order (normally): video_player_platform_interface, video_player_web (if it's independent to the video_player code, or backwards compatible), and then the video_player package.

Honestly I don't think this thing is going to get across the finish line if that's the case.

Honestly I don't think this thing is going to get across the finish line if that's the case.

I know this isn't my PR but I've been following it from day one and I feel I can take responsibility for saying it's time to kill this PR. Perhaps someone can gain insight from it and take another stab at it, but it really should be done from a fresh fork and reimplementation.

I know this isn't my PR but I've been following it from day one and I feel I can take responsibility for saying it's time to kill this PR. Perhaps someone can gain insight from it and take another stab at it, but it really should be done from a fresh fork and reimplementation.

I agree with @lukepighetti. Even though we welcome all the work done on this PR, it's been way too long. Sadly, I haven't gained much knowled about its inner workings, so it would be great if someone else takes over this project startin with a fresh PR.

I agree with @lukepighetti. Even though we welcome all the work done on this PR, it's been way too long. Sadly, I haven't gained much knowled about its inner workings, so it would be great if someone else takes over this project startin with a fresh PR.

I have been following and waiting for this very basic feature to be a part of the video player for a long time. I am sad that contributors/authors of this PR are fed up with the lack of interest from the google team. I understand that they now lost interest to go forward with this PR. If this was taken care of a year ago, there would not be such extra work needed to merge this. You can not expect community developers to take action for some code they wrote months ago when you or a bot feels like it.
For a video extensive app done with Flutter, here are the current two options:
1- since there is no caching, every single time app is opened, user will download the same videos over and over again. This results in excessive Firebase bills. Only 1 GB bandwidth is free per day. End-users of this app when checking the bandwidth use instantly deletes the app from their phones.
2- integrate flutter video cache which is basically downloading the videos before supplying them to video player. So no setdatasource.network but always setdatasource.file. This drops the bandwidth use substiantilly but if a user would have only streamed the first 2 seconds of a video and passed to the next video, with this strategy we are still downloading the whole file. Dart http does not support partial downloads and interestingly not even canceling an ongoing download. So still wasted beandwidth but as much. However from end-users point of view, when the apps video feed opens, they will see the circular progress indicator for a long time waiting for the whole video to be downloaded instead of instantly starting to stream the video
So what I am saying is, there is a working PR, and if because of the late interest of google there are now extra steps involved to merge it, than google can take it from here and move some resources for this subject.

I have been following and waiting for this very basic feature to be a part of the video player for a long time. I am sad that contributors/authors of this PR are fed up with the lack of interest from the google team. I understand that they now lost interest to go forward with this PR. If this was taken care of a year ago, there would not be such extra work needed to merge this. You can not expect community developers to take action for some code they wrote months ago when you or a bot feels like it.
For a video extensive app done with Flutter, here are the current two options:
1- since there is no caching, every single time app is opened, user will download the same videos over and over again. This results in excessive Firebase bills. Only 1 GB bandwidth is free per day. End-users of this app when checking the bandwidth use instantly deletes the app from their phones.
2- integrate flutter video cache which is basically downloading the videos before supplying them to video player. So no setdatasource.network but always setdatasource.file. This drops the bandwidth use substiantilly but if a user would have only streamed the first 2 seconds of a video and passed to the next video, with this strategy we are still downloading the whole file. Dart http does not support partial downloads and interestingly not even canceling an ongoing download. So still wasted beandwidth but as much. However from end-users point of view, when the apps video feed opens, they will see the circular progress indicator for a long time waiting for the whole video to be downloaded instead of instantly starting to stream the video
So what I am saying is, there is a working PR, and if because of the late interest of google there are now extra steps involved to merge it, than google can take it from here and move some resources for this subject.

Probably the best way forward for the community is to release this as a package and hop it rots slowly enough to work until someone can take a fresh look at the problem and do a new PR.

Probably the best way forward for the community is to release this as a package and hop it rots slowly enough to work until someone can take a fresh look at the problem and do a new PR.

It's really unfortunate that this PR went so long without getting a review. I know a number of people have either worked on this PR or eagerly awaited it landing. I'm part of that group, having taken some time to review it, although I certainly only became aware of it months after it was originally opened. Having the PR closed without resolution is disappointing.
This repository can't accept PRs that have CLA issues. It also can't accept PRs without a positive review - more importantly, a PR that has outstanding issues that will cause more work for Flutter contributors both inside and outside of Google. (This is what we refer to as "the team".) It also creates headaches for users if they end up with a problematic implementation. Finally, we can't leave PRs open that are not actively being worked on. See our process.
IMHO, this PR should have been closed much earlier than it was, if nothing else until the CLA issues were resolved. @cyanglaz did the right thing here. I should have done it myself sooner when there was no response from the author(s).
One other thing is that this patch is acutally tackling a non-trivial, somewhat challenging area, and trying to do it for multiple platforms. That's great, but it certainly increases the difficulty and time involved in getting it to land. Landing this feature in this repository will require non-trivial amounts of work. It may be more work than someone who has other professional responsibilities is willing to take on. The team's approach to this is that it would be better to wait until someone is available (whether a current or new team member) to drive this to completion than to accept a problematic patch.
We have several options to move this forward.

If you are happy with the state of the code in this PR for your own uses, you can apply the patch to a fork and pull it into your project, either via git or by publishing it yourself to pub. Given a number of unresolved issues with this patch, I would not pursue that path myself.
Open another patch in this repo. You will have to make sure you follow our contributing guidelines, which include things like signing a CLA, writing tests for any new functionality, following the Style guide, and potentially engaging in a design document process for larger/more complex features.
Fork this plugin and create your own patch to do this. This will involve maintaining your own fork. If you're doing a good enough job of that, it's even possible to just take over ownership of that plugin as far as the Flutter team is concerned.

I understand that last option is a lot of work. You may not want to do that work. That's fine. Just bear in mind that it's still a lot of work to land such a patch in this repository.
Please feel free to discuss this further in the #hackers-ecosystem chat or the #hackers chat - see chat.

It's really unfortunate that this PR went so long without getting a review. I know a number of people have either worked on this PR or eagerly awaited it landing. I'm part of that group, having taken some time to review it, although I certainly only became aware of it months after it was originally opened. Having the PR closed without resolution is disappointing.
This repository can't accept PRs that have CLA issues. It also can't accept PRs without a positive review - more importantly, a PR that has outstanding issues that will cause more work for Flutter contributors both inside and outside of Google. (This is what we refer to as "the team".) It also creates headaches for users if they end up with a problematic implementation. Finally, we can't leave PRs open that are not actively being worked on. See our process.
IMHO, this PR should have been closed much earlier than it was, if nothing else until the CLA issues were resolved. @cyanglaz did the right thing here. I should have done it myself sooner when there was no response from the author(s).
One other thing is that this patch is acutally tackling a non-trivial, somewhat challenging area, and trying to do it for multiple platforms. That's great, but it certainly increases the difficulty and time involved in getting it to land. Landing this feature in this repository will require non-trivial amounts of work. It may be more work than someone who has other professional responsibilities is willing to take on. The team's approach to this is that it would be better to wait until someone is available (whether a current or new team member) to drive this to completion than to accept a problematic patch.
We have several options to move this forward.

If you are happy with the state of the code in this PR for your own uses, you can apply the patch to a fork and pull it into your project, either via git or by publishing it yourself to pub. Given a number of unresolved issues with this patch, I would not pursue that path myself.
Open another patch in this repo. You will have to make sure you follow our contributing guidelines, which include things like signing a CLA, writing tests for any new functionality, following the Style guide, and potentially engaging in a design document process for larger/more complex features.
Fork this plugin and create your own patch to do this. This will involve maintaining your own fork. If you're doing a good enough job of that, it's even possible to just take over ownership of that plugin as far as the Flutter team is concerned.

I understand that last option is a lot of work. You may not want to do that work. That's fine. Just bear in mind that it's still a lot of work to land such a patch in this repository.
Please feel free to discuss this further in the #hackers-ecosystem chat or the #hackers chat - see chat.

there is hope or not?


fix: updated pin accessibility labels

Signed-off-by: wadeking98<EMAIL_ADDRESS>Summary of Changes
changed the accessibility labels for the pin show/hide input
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jcdrouin21 French look ok?
@cvarjao Portuguese look ok?