WindowBuilder::with_decorations behaviour inconsistent across platforms.

On Windows, using .with_decorations(false) correctly causes all window decorations to be hidden including the toolbar and window frame. In other words, if nothing is drawn to the window by the user, the window appears entirely transparent.
On OS X 10.10.5 building a window using .with_decorations(false) builds the window without the title bar, however the red, yellow and green x - + buttons still show in the top left corner.
Here's the window with decorations:

And here is the same window without decorations:

The Windows behaviour more closely matches my expectations and I think it'd be nice if we could change OS X to match it by removing the x - + buttons somehow.

This was fixed by #152.


FileFinder test fails randomly (Arrays of filenames not sorted)

When running file_finder_spec.rb, this part may fail
  context 'and there are SCSS files under the current directory' do
    before do
      `touch blah.scss`
      `mkdir -p more`
      `touch more/more.scss`
    end

    it { should == ['blah.scss', 'more/more.scss'] }

with the error message
 Failure/Error: it { should == ['blah.scss', 'more/more.scss'] }

   expected: ["blah.scss", "more/more.scss"]
        got: ["more/more.scss", "blah.scss"] (using ==)

This is because Find.find does not guarantee a certain order.
There are two possible solutions for this, modify the test or the  implementation. Not sure which one is better.
In both cases, the easy fix consists in sorting the array of found items. Either
subject { super().find(patterns).sort }

in file_finder_spec.rb:11
or
  files.uniq.sort

in file_finder.rb:50

I'm happy to have FileFinder#find return its files in a well-defined order.
Fixed in fe04ca9.


Unstable behavior of server

Bug Report
I had been testing the write operation of the data_objects endpoint. At some point I saw some strange behaviors:

Looked like the server got stuck,
It didn't response anything, even to the authentication request,
Client operations hanged.
The only thing I had to do was kill the process (restart the server).

Here is an example of what I encountered:
[irods@dev-u0137480 go-http-client]$ time curl -H "Authorization: Bearer $token" 'http://localhost:9000/irods-http-api/0.1.0/data-objects' -F  'op=write' -F 'lpath=/u0137480/home/rods/myfile.txt' -F 'count=125000' -F 'bytes=abcdfg'
^C

real    0m16.016s
user    0m0.006s
sys     0m0.004s
[irods@dev-u0137480 go-http-client]$ token=$(curl -X POST -su rods:hunter2 'http://localhost:9000/irods-http-api/0.1.0/authenticate')
^C

logs (I post older ones too):
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (Host, localhost:9000)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (User-Agent, curl/7.61.1)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (Accept, */*)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (Authorization, Bearer 57136313-b9ac-4c20-a127-01e95b7a2343)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (Content-Length, 466)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Header: (Content-Type, multipart/form-data; boundary=------------------------b8b5044cece33b29)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Method: POST
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Version: 11
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Target: /irods-http-api/0.1.0/data-objects
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Keep Alive: true
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Has Content Length: true
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Chunked: false
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] on_read: Needs EOF: false
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] PARAM = (name=boundary, value=------------------------b8b5044cece33b29)
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] parse_multipart_form_data: CAPTURED CONTENT SIZE = [5]
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] parse_multipart_form_data: CAPTURED CONTENT SIZE = [30]
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] parse_multipart_form_data: CAPTURED CONTENT SIZE = [6]
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] parse_multipart_form_data: CAPTURED CONTENT SIZE = [6]
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] resolve_client_identity: Authorization value: [Bearer 57136313-b9ac-4c20-a127-01e95b7a2343]
http-api stdout | [2023-12-22 15:24:25.273] [P:571486] [debug] [T:571537] resolve_client_identity: Bearer token: [57136313-b9ac-4c20-a127-01e95b7a2343]

http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Header: (Host, localhost:9000)
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Header: (Authorization, Basic cm9kczpodW50ZXIy)
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Header: (User-Agent, curl/7.61.1)
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Header: (Accept, */*)
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Method: POST
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Version: 11
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Target: /irods-http-api/0.1.0/authenticate
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Keep Alive: true
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Has Content Length: false
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Chunked: false
http-api stdout | [2023-12-22 15:24:54.022] [P:571486] [debug] [T:571486] on_read: Needs EOF: false

http-api stdout | [2023-12-22 15:26:34.170] [P:571486] [debug] [T:571537] Evicted bearer token [7ff2dc9d-cdd8-4671-845b-b4d8dcfba47a].
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Header: (Host, localhost:9000)
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Header: (Authorization, Basic cm9kczpodW50ZXIy)
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Header: (User-Agent, curl/7.61.1)
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Header: (Accept, */*)
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Method: POST
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Version: 11
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Target: /irods-http-api/0.1.0/authenticate
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Keep Alive: true
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Has Content Length: false
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Chunked: false
http-api stdout | [2023-12-22 15:27:25.647] [P:571486] [debug] [T:571486] on_read: Needs EOF: false
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Header: (Host, localhost:9000)
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Header: (Authorization, Basic cm9kczpodW50ZXIy)
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Header: (User-Agent, curl/7.61.1)
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Header: (Accept, */*)
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Method: POST
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Version: 11
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Target: /irods-http-api/0.1.0/authenticate
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Keep Alive: true
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Has Content Length: false
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Chunked: false
http-api stdout | [2023-12-22 15:29:22.030] [P:571486] [debug] [T:571536] on_read: Needs EOF: false
2023-12-22 15:30:08,977 WARN exited: http-api (terminated by SIGKILL; not expected)

The only thing that stands out here is the mismatch between the count param and the bytes param.
As you already know, the HTTP API does not verify those values align. It just trusts the client passed the correct values. I feel that is probably the reason for the weird behavior (or part of it).
We'll get that fixed.

Feels like we just need to compare the bytes and count at the start of the operation...
If count isn't defined (or also possibly if count=0)... then perhaps we're in streaming mode.
If they are present and don't match, error immediately.

I think this is resolved by #194.
With that resolved, there's no known way to write more bytes than what's available.

I think we can close this for now.  If we see unstableness/inconsistency again (for whatever reason)... we'll open a new issue.


Add verbose flag to zip action

This PR adds support for a verbose mode with the zip action.  I've kept the default to true as this is the current behavior of this action.
See Issue #7729
Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:

[x] Run bundle exec rspec from the root directory.
[x] Run bundle exec rubocop -a to ensure the code style is valid
[x] Read the Contribution Guidelines
[x] We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

Before submitting a pull request, we appreciate if you create an issue first to discuss the change :+1:

Thanks @rbaumbach for the PR! 💯


Delete assigned student from project

The button (x) to delete a student from a project doesn't work

#351 this is the current draft to fix this. Waiting for issue #407 to merge this with development

Fixed in #467


build.sh additional-namespaces.jsonnet throws an RUNTIME ERROR: couldn't open import "kube-prometheus/main.libsonnet": no match locally or in the Jsonnet library path

What happened?
I've tried to install kube-prometheus and customized it to monitor several namespaces, but after executing build.sh additional-namespaces.jsonnet  I've got RUNTIME ERROR: couldn't open import "kube-prometheus/main.libsonnet": no match locally or in the Jsonnet library path.
Did you expect to see some different?
Generated yml files that I can apply and set prometheus to monitor several namespaces.
How to reproduce it (as minimally and precisely as possible):
I've followed installation guide https://github.com/prometheus-operator/kube-prometheus#customizing-kube-prometheus
jb init
jb install<EMAIL_ADDRESS># 0.7 throws same error
wget https://raw.githubusercontent.com/prometheus-operator/kube-prometheus/release-0.8/build.sh -O build.sh

Then I've created .jsonnet file with configs by example https://github.com/prometheus-operator/kube-prometheus/blob/main/examples/additional-namespaces.jsonnet (just namespace names has been changed)
local kp = (import 'kube-prometheus/main.libsonnet') + {
  values+:: {
    common+: {
      namespace: 'monitoring',
    },

    prometheus+: {
      namespaces+: ['my-namespace', 'my-second-namespace'],
    },
  },
};

{ ['00namespace-' + name]: kp.kubePrometheus[name] for name in std.objectFields(kp.kubePrometheus) } +
{ ['0prometheus-operator-' + name]: kp.prometheusOperator[name] for name in std.objectFields(kp.prometheusOperator) } +
{ ['node-exporter-' + name]: kp.nodeExporter[name] for name in std.objectFields(kp.nodeExporter) } +
{ ['kube-state-metrics-' + name]: kp.kubeStateMetrics[name] for name in std.objectFields(kp.kubeStateMetrics) } +
{ ['alertmanager-' + name]: kp.alertmanager[name] for name in std.objectFields(kp.alertmanager) } +
{ ['prometheus-' + name]: kp.prometheus[name] for name in std.objectFields(kp.prometheus) } +
{ ['grafana-' + name]: kp.grafana[name] for name in std.objectFields(kp.grafana) }

But in the step "Compiling" build.sh additional-namespaces.jsonnet thrown an error:
+ set -o pipefail
++ pwd
+ PATH='/c/Users/eliseev/jb-folder/monitoring-stack/tmp/bin:/c/Users/eliseev/bin:/mingw64/bin:/usr/local/bin:/usr/bin:/bin:/mingw64/bin:/usr/bin:/c/Users/eliseev/bin:/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/c/Program Files/Python39/Scripts:/c/Program Files/Python39:/c/Program Files (x86)/Common Files/Oracle/Java/javapath:/c/WINDOWS/system32:/c/WINDOWS:/c/WINDOWS/System32/Wbem:/c/WINDOWS/System32/WindowsPowerShell/v1.0:/c/WINDOWS/System32/OpenSSH:/c/Program Files/Java/jdk1.8.0_281/bin:/c/Progra~1/maven/apache-maven-3.6.3/bin:/c/Program Files (x86)/Bitvise SSH Client:/cmd:/c/ProgramData/chocolatey/bin:/c/Program Files/PuTTY:/c/Program Files/Go/bin:/c/Python34/Scripts:/c/Users/eliseev/go/bin:/usr/bin/vendor_perl:/usr/bin/core_perl'
+ rm -rf manifests
+ mkdir -p manifests/setup
+ jsonnet -J vendor -m manifests example.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml' -- '{}'
RUNTIME ERROR: couldn't open import "kube-prometheus/main.libsonnet": no match locally or in the Jsonnet library paths
        example.jsonnet:1:13-52 thunk <kp> from <$>
        example.jsonnet:13:81-83
        <std>:1293:24-25        thunk from <function <anonymous>>
        <std>:1293:5-33 function <anonymous>
        example.jsonnet:13:64-99        $
        example.jsonnet:13:1-101
        example.jsonnet:13:1-101
        During evaluation

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:12:29Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
Anything else we need to know?:
jsonnet --version:
Jsonnet commandline interpreter v0.17.0
jb --version:
dev

I tried to reproduce the issue by following the step you provided and everything went fine. Could you perhaps try again from scratch?
If the problem persist, could you please verify that:

vendor/kube-prometheus/main.libsonnet exists
jsonnetfile.json points to the release of kube-prometheus you installed

It seems that cause in jb on windows.
after jb install<EMAIL_ADDRESS>has been completed
vendor look like this
drwxr-xr-x 1 eliseev 1049089  0 Jul 29 15:19 ./
drwxr-xr-x 1 eliseev 1049089  0 Jul 29 15:33 ../
lrwxrwxrwx 1 eliseev 1049089 57 Jul 29 15:19 alertmanager -> github.com/prometheus/alertmanager/doc/alertmanager-mixin
drwxr-xr-x 1 eliseev 1049089  0 Jul 29 15:19 github.com/
lrwxrwxrwx 1 eliseev 1049089 44 Jul 29 15:19 grafana -> github.com/brancz/kubernetes-grafana/grafana
lrwxrwxrwx 1 eliseev 1049089 47 Jul 29 15:19 grafana-builder -> github.com/grafana/jsonnet-libs/grafana-builder
lrwxrwxrwx 1 eliseev 1049089 42 Jul 29 15:19 grafonnet -> github.com/grafana/grafonnet-lib/grafonnet
lrwxrwxrwx 1 eliseev 1049089 30 Jul 29 15:19 ksonnet -> github.com/ksonnet/ksonnet-lib
lrwxrwxrwx 1 eliseev 1049089 70 Jul 29 15:19 kube-prometheus -> github.com/prometheus-operator/kube-prometheus/jsonnet/kube-prometheus
lrwxrwxrwx 1 eliseev 1049089 67 Jul 29 15:19 kube-state-metrics -> github.com/kubernetes/kube-state-metrics/jsonnet/kube-state-metrics
lrwxrwxrwx 1 eliseev 1049089 73 Jul 29 15:19 kube-state-metrics-mixin -> github.com/kubernetes/kube-state-metrics/jsonnet/kube-state-metrics-mixin
lrwxrwxrwx 1 eliseev 1049089 49 Jul 29 15:19 kubernetes-mixin -> github.com/kubernetes-monitoring/kubernetes-mixin
lrwxrwxrwx 1 eliseev 1049089 37 Jul 29 15:19 mixin -> github.com/etcd-io/etcd/contrib/mixin
lrwxrwxrwx 1 eliseev 1049089 51 Jul 29 15:19 node-mixin -> github.com/prometheus/node_exporter/docs/node-mixin
lrwxrwxrwx 1 eliseev 1049089 63 Jul 29 15:19 prometheus -> github.com/prometheus/prometheus/documentation/prometheus-mixin
lrwxrwxrwx 1 eliseev 1049089 78 Jul 29 15:19 prometheus-operator -> github.com/prometheus-operator/prometheus-operator/jsonnet/prometheus-operator
lrwxrwxrwx 1 eliseev 1049089 64 Jul 29 15:19 prometheus-operator-mixin -> github.com/prometheus-operator/prometheus-operator/jsonnet/mixin
lrwxrwxrwx 1 eliseev 1049089 67 Jul 29 15:19 promgrafonnet -> github.com/kubernetes-monitoring/kubernetes-mixin/lib/promgrafonnet
lrwxrwxrwx 1 eliseev 1049089 33 Jul 29 15:19 thanos-mixin -> github.com/thanos-io/thanos/mixin

ls github.com shows that github.com folder is empty, symlinks link to nothing.

downgrading version of jb to 0.2.0 helps to fix this error, but, just for @release-0.4 version, installation of newer versions cause  jb.exe: error: failed to install packages: downloading: failed to create tmp dir: CreateFile vendor\.tmp: The system cannot find the path specified..
I've tried to repeat all steps in 2 different windows systems, same error occurs, but on ubuntu it works as expected with last jb version

May be it is related with such jb install output, which says that folders in github.com are cleaned


GitHub Actions workflow to block CI if files have been moved but redirects haven't been added

Which Cloudflare product(s) does this pertain to?
Style Guide
Subject Matter
N/A
Content Location
Whilst there is a link crawler that will alert you to dead links on the docs pages, there is nothing that stops a user from moving pages, updating links but not adding a redirect - meaning third party links (i.e search engines) will 404.
As an example, https://github.com/cloudflare/cloudflare-docs/pull/11162/ moved /workers/runtime-apis/websockets/websockets.md and /workers/runtime-apis/websockets/use-websockets.md but did not add a redirect.
This means that https://developers.cloudflare.com/workers/runtime-apis/websockets/use-websockets/ and https://developers.cloudflare.com/workers/runtime-apis/websockets/websockets/ are both dead links.
Maybe this could leverage Git's own heuristics to figure out if a file has been moved? There may be false positives with that, or sufficiently changed files that it doesn't recognize, but it would be beneficial nonetheless.
Additional information
No response

cc @kodster28

This has come up quite a bit recently.
a) Thanks for the fix!
b) I need to noodle on this a bit. As discussed in this comment, this gets a bit hard b/c Pages supports dynamic redirects (and we use them quite a bit + wouldn't want to discourage them as an action). My initial thought would be an MVP that just comments on the PR with a checklist for all the changed / deleted files.
cc: @WalshyDev for any additional thoughts

My initial thought would be an MVP that just comments on the PR with a checklist for all the changed / deleted files.

I would love this

Gotcha. Let me block off some time Friday and see how far I can get.

Yeah, this is sadly a bit of a hard problem to solve.
I like the MVP idea.
Another possible idea is to diff the files between production and the branch, look for any removals and look for a redirect.
It's easy to implement but, branches are sometimes a little behind so potentially it could cause false flags however, if a file is gone even 10 commits ago there should be a redirect so the action should have failed for that pr
Happy to contribute some eng resources for that or to help with the MVP if you need Kody :)

I think I'm good on the MVP. If that gets up and we get more requests around this, might circle back to take you up on this offer though.

cc @irvinebroque

Note that this may not work on the /support/ section because their filenames are non-standard.


Optimize 0020-valid-parentheses.java implementation

Set the HashMap initial capacity
Boxed types should be compared using "equals()".
Use String#charAt instead of String#toCharArray to avoid using O(n) space
Simplify return statement

File(s) Modified: 0020-valid-parentheses.java
Language(s) Used: Java

Submission:
Before:

After:

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

Thanks!


High memory usage after having a extened session

I relized this problem when I forgot to terminate the asitop and let it run overnight. The next day I relized the some program is using a huge amount of memory. After terminated the asitop it released nearly 15 gigs of memory. Is this the inteded behavior because of the nature of logging?

Yeah it could be the case that the powermetrics process started by asitop could have been accumulating memory. I don't think asitop itself will use so much memory, it only logs maximum 30s of power information.
Although it is not intended, if the issue is powermetrics, I don't have a solution for that short of restarting the process at an interval of maybe a few hours.

After read though the man page of powermatrics I guess this could be eliminated by giving an -n argument to limit its periodic sample instead of the default unlimited samples. But i am just gessing, I will do some testing tonight.

Yes, previously I had just called powermetrics with -n1, it was the most logical to me at that time. However, every time the powermetrics process starts and stops, there is a overhead that results in a performance hit (for example, if you are doing any form of benchmarking.
So probably there should be a kind of balance...


Replace deprecated linters

replace deprecated maligned linter with govet: fieldalignment
replace deprecated scopelint linter with exportloopref

fixes GH-202

CI failure is expected: the issue is with the existing project source code and not the golangci-lint config file changes included with this PR.

Also, the earlier "success" by some of the containers is due to the latest v0.3.19 atc0005/go-ci containers only being partially finished uploading. Had this PR landed a little earlier, it is likely that no issues would have been flagged with the source.


How do I convert the converted format to double ?

How do I convert the converted format to double ?
Example: 2,500.25 € -> 2500.25

@Patrick386
String source = "2,500.25 €".replaceAll(RegExp(r"\D"), "");
double result = (int.tryParse(source) ?? 0) / 100;

I've just uploaded a new version (1.2.1) to pub.dev that supports parsing formatted strings to numbers using CurrencyFormatter().parse(). I hope it is what you wanted.


Please can we have a 'quit' option from top menu on Mac

Using OS Catalina

Thank you for the suggestion. Will be happy to accept a PR for it 👍
ps - FYI you can already use the keyboard shortcuts CMD + W or CMD + Q


Fix REST URL of file

@pkdash @aphelionz @hyi quick fix for URL botch in REST API. Testing now.

@pkdash @hyi Here is my proposed fix for the REST URL problem. See what you think.

@alvacouch Looks good to me. +1

@hyi @pkdash Trailing slash removed from URLs.... but we really, really need to respond properly to URLs we generate in the future, even if it means changing what we respond to!

@alvacouch +1


Signature extraction failed

instantmusic -q -s Nightstep - Radioactive
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 828, in _decrypt_signature
video_id, player_url, s
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 755, in _extract_signature_function
cache_res = res(test_string)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 807, in
return lambda s: initial_function([s])
File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 254, in resf
res, abort = self.interpret_statement(stmt, local_vars)
File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 55, in interpret_statement
v = self.interpret_expression(expr, local_vars, allow_recursion)
File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 135, in interpret_expression
self._objects[variable] = self.extract_object(variable)
File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 220, in extract_object
fields = obj_m.group('fields')
AttributeError: 'NoneType' object has no attribute 'group'
(caused by AttributeError("'NoneType' object has no attribute 'group'",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Fixing id3 tags
file not found: Nightstep - Radioactive.m4a
error getting album and lyrics
Nightstep   Radioactive
local variable 'audiofile' referenced before assignment
couldnt get album art
Downloaded: Nightstep - Radioactive
MacBook-Alex:Nightcore remix alex$

You are using an out-dated version. Please update to the latest version (2015.11.24). Check this FAQ on how to update.


Color scheme Switcher

An interactive Live Color Scheme Switcher built on HTML, CSS and JavaScript to provide ease of choosing colors.  Instructions at the bottom provides ease of navigation and makes the application user friendly
🛠 Fixes Issue (Number)

👨💻 Changes proposed and Brief Description
An interactive Color Scheme Switcher with various colors to choose from. The color selected by the user is translated to the chosen language.

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@ashu9807 No issue is assigned to you related to this PR.


Support (x) and (+)

They are used in digital signal block graphs.

Can you give more context about this? x and + are already used crossing diagonals and intersection in the diagrams.

For example,

Svgbob is limited to the available characters you can type.
The plus sign inside circle may be expressed with
  .-.
 ( + )
  `-'

I tried graphing your diagrams and it seems fine.
            ____________________________________________________
           |                                                    |
  .------->|                N samples delay                     |------->.
  ^        |____________________________________________________|        |
  |                                                                      |
  |                            1/2 .                                     |
  |                    .-.        /|                                     V
  `<------------------( + )<-----+ |---------------------------+---------'
                       `-'        \|                           |
                        ^          '                           |
                        |      1/2.          +--------+        |
                        |        /|          |    -1  |        V
                        `<------+ |<---------|  Z     |<-------'
                                 \|          |        |
                                  '          +--------+

             +---------------------------------------------------+
             |                                                   |
             |                                              V(z) |
             |      .                                            |
             |      |\            .-.                            |
  -----------|------| +----------( + )----------------------+----|-------->
             |      |/            `-'          ________     |    |
             |      '              |     .    |        |    |    |
             |    1 + v            |____/|____|    -1  |<---'    |
             |                          \|    |  Z     |         |
             |                       -v  `    |________|         |
             |                                                   |
             +---------------------------------------------------+

This is how it looks like when rendered.

This diagram is complex, however svgbob does a pretty job doing the best it can to render it nicely.
If you have much more complex diagrams, svgbob may not be the right tool for this, you can use proper diagramming tools for circuit programs.

Well, I hoped to keep it small.


Bug: XAML Controls Gallery: Accessibility: [MAS 4.2.1]: The narrator does not read the tooltip info using Caps+0 for the image available in the Tooltip window of the Xaml controls gallery.

Tags
Accessibility, A11yCT, A11yMAS, A11yLowImpact, MAS4.2.1, Narrator, Sev4, XAML Controls Gallery (Debug), Win32, Wipro
Steps to reproduce the bug

Launch the XAML Controls Gallery (Debug) App
Go to the Status and Info-> Tooltips-> Image.
Navigate to the image under "An image with a tooltip using placement react" heading
Use Caps+0 to read the tooltip of the image and observe the narrator announcement.

Actual behavior
The narrator does not read the tooltip info using Caps+0 for the image available in the  Tooltip window of the Xaml controls gallery.
Narrator says as no advanced info available while user hit on the Caps+0 keys to read the tooltip info of this image(i.e. Non occluding ToolTip)
Expected behavior
Using Caps+0 , narrator should read the tooltips info of the image.
User Impact
If the tooltips info available for the image is not being read by the narrator then, additional info could not be conveyed to the narrator user
Attachment
Narrator-Tooltip-NoAnnouncement_edit.zip
Version Info
Microsoft OS: 21313.1000
App: XAML Controls Gallery (Debug) (Version <IP_ADDRESS>)

I'm able to repro the problem but am not certain how to fix this. Perhaps by setting AutomationProperties.Name or AutomationProperties.FullDescription.

@anawishnoff  fixed this


Please support nested bullets

Can't figure out how to create this:

top level

nested bullet

I have to do it manually.

https://github.com/Saul-Mirone/milkdown-vscode/issues/36


Fake Promise is a breaking API change

The fake promise that was introduced in #709 is a BREAKING change and not backwards compatible.
I wrote a little scenario involving an async action via a promise. Before this change was made, this was perfectly valid until the fake promise was added to the library. For this scenario, I used native promises but have also tested with a promise library with the same result.
var http = require('http')
var fs = require('fs')
var superagent = require('superagent')
var dest = fs.createWriteStream('response.txt')

// stand up a simple http server
var server = http.createServer(function(req, res) {
  console.log('got request')
  res.end('hello superagent!')
})

// Start listening
server.listen(1234, function() {

  console.log('server listening')

  // Generate dummy data
  var promise = new Promise(function(resolve, reject) {

    resolve({ hello: 'superagent' })

  }).then(function(data) {

    // generate a dummy request
    return superagent.post('http://localhost:1234').send(data)

  }).then(function(res) {
    // At this point, we should have a request
   // that hasn't been fired yet, based on the docs.

    // Pipe to the dest, fires the request and streams to the file
    res.pipe(dest)
    // kill the program
    dest.once('close', function() {
      console.log('wrote response')
      process.exit()
    })

  })

})

With<EMAIL_ADDRESS>the code works as expected and you will see a wrote response and the response.txt will have the correct text hello superagent!.
The problem with<EMAIL_ADDRESS>the request ( that should not have fired based on the docs ) is seen as a "thenable" and so the promise chain will call the then() method which fires off the request and returns the buffered response to the next promise chain call. Because of this, the pipe method will not work because the stream has already been exhausted, the program will never end, and the response.txt will have no content.

I agree this does change behavior indeed. I'm not sure if we can do anything about this? Reverting this change now will be another backwards-compatibility break.

Yeah this is unfortunate. If we do anything, I'd vote to remove the fake promise API entirely and bump semver major. I'd personally rather stick with a callback API that follows node core conventions and let folks do something like Promise.promisifyAll(request.prototype) (with bluebird) if they want Promises.

If we bump major semver #854, we could as well upgrade thenable to a native Promise API.


Azure DDOS Protection pkg update

Change(s):

New Schema for Data connector: DDOS.json

New Schema for Create UI Definition
Version Updated:

2.0.3

Resolved PR #7217

Testing Completed:

Yes
Link:- https://microsoft-my.sharepoint.com/:w:/p/v-prasadboke/Eaj09KRcJy1DuAbU3mJAZU0BAZt5vuw9KM7ebHaVgHQ16g?e=ol0mp3

Checked that the validations are passing and have addressed any issues that are present:

Yes

Looking into this

Hi @v-prasadboke, will provide you an update on this ASAP.

Hi @v-prasadboke, data connector description link not showing.

Do Not merge

Hi @v-prasadboke, data connector description link not showing.

I think that's expected. My understanding is that the 1P connectors are hard-coded in the UI. I've updated the description so we can pull the description down into Microsoft Sentinel Documentation (from the repo). @prtanej


Simple Example

What is the purpose of the change
add a example.md
Brief changelog

Simple Example
Order Example
Schedule Example
Batch Example
Filter Example
Transaction Example
Logappender Example
OpenMessaging Example

Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.02%) to 43.162% when pulling 9d0e4296c0b95525edfde6c171c932ccad1f3c45 on yejunyu:develop into 5c46048dcc28e3546c1312959d80d24b24d7f878 on apache:develop.


electron-packager fails with error (1.22.0 beta2)

Running electron-packager on /var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/out/app with app name "atom"

... and 1 more
/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/lib/package-application.js:141
        throw new Error(err)
        ^

Error: Error: read ECONNRESET
  at electronPackager (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/lib/package-application.js:141:15)
  at /var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/electron-packager/index.js:211:23
  at end (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/run-series/index.js:8:15)
  at done (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/run-series/index.js:11:10)
  at each (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/run-series/index.js:16:43)
  at /var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/electron-packager/index.js:114:25
  at /var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/electron-packager/node_modules/electron-download/index.js:61:61
  at Request.done (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/electron-packager/node_modules/nugget/index.js:58:9)
  at emitOne (events.js:115:13)
  at Request.emit (events.js:210:7)
  at Request.onRequestError (/var/tmp/portage/app-editors/atom-1.22.0_beta2/work/atom-1.22.0-beta2/script/node_modules/request/request.js:878:8)
  at emitOne (events.js:115:13)
  at ClientRequest.emit (events.js:210:7)
  at TLSSocket.socketErrorListener (_http_client.js:385:9)
  at emitOne (events.js:115:13)
  at TLSSocket.emit (events.js:210:7)
  at emitErrorNT (internal/streams/destroy.js:64:8)
  at _combinedTickCallback (internal/process/next_tick.js:138:11)
  at process._tickCallback (internal/process/next_tick.js:180:9)

ECONNRESET indicates a network error.  Try again later.

@50Wliu is it possible to bundle all needed sources together to avoid such errors during the building process?

Possible, yes.  Whether it's feasible or not is an entirely different question - Atom currently comes with 92 different core packages, all of which have their own npm dependencies.  That is not to mention Atom's own npm dependencies and its dependency on apm and Electron (which have their own dependencies, and so on).  Therefore there would be an incredible amount of churn if everything was to be bundled together, and is also why node_modules is almost universally git-ignored.

ended with success on second run


Allowing "." character in tuple creation

If I post to http://localhost:3476/v1/tenants/t1/relationships/write with data
{
    "metadata": {
    },
    "tuples": [
        {
            "entity": {
                "type": "organization",
                "id": "org.2WffVF27PL5VO00JcqYYhiq42m6"
            },
            "relation": "member",
            "subject": {
                "type": "user",
                "id": "acct.2WffVEDWStT0jfiBlcO9vjcwQpd"
            }
        }
    ]
}

Invalid RelationshipWriteRequest.Tuples[0]: embedded message failed validation | caused by: invalid Tuple.Entity: embedded message failed validation | caused by: invalid Entity.Id: value does not match regex pattern \"^(([a-zA-Z0-9_][a-zA-Z0-9_|-]{0,127})|\\\\*)$\"",

We tend to use these style of ids in our app to make it easier to identify some entity ID.
Is there a work around? The only thing I can think of is making a custom client which can encode/decode values... which is not really fun.

Hi sir, can i work on this issue?

Hi @nguyenluan2001 assigned to you. Happy hacking ✌🏻

Hi,
I can look into this issue.
Could you assign it to me?

Hi @ahmethakanbesel yes you can. Happy hacking ✌🏻


Run window not getting focus when opened with certain applications in focus

Microsoft PowerToys version
0.79.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Open the application and focus the window by clicking on it.
Hit the Shortcut for PowerToys Run.
Run window does not get keyboard focus.
Applications that show this behavior are PowerToys Settings, GPU-Z, MSI Afterburner
This is similar to other keyboard focus issues like #20043
✔ Expected Behavior
Run window opens and has focus.
❌ Actual Behavior
If centralised hook is disabled, the run window does not open at all, if activated it opens but does not get focus.
Other Software
GPU-Z v2.57.0
MSI Afterburner v4.6.5

this problem also had to when windows start menu already open.

I've been reproducing this issue a lot, and often in the same style of https://github.com/microsoft/PowerToys/issues/20043
This has made using Run a lot harder to use as there's no simple way to refocus the run window without dropping it via the keyboard.
I wouldn't mind an option to just force focus for power toys run. If it ever loses focus I'd be happy for it just to close.


feat: upgrade chart to v1.5.2

Description of the changes
Upgrade Longhorn chart to v1.5.2.
This upgrade is required to be able to add recurring jobs to automate filesystem trim.
Upgrading from v1.4.x to v1.5.x is straight forward and can be done in-place (cf. https://longhorn.io/docs/1.5.3/deploy/upgrade/longhorn-manager/ and tested on SKS cluster)
Breaking change

[x] No
[ ] Yes (in the Helm chart(s)): indicate the chart, version & release note link
[ ] Yes (in the module itself): give an explanation of the breaking change

Tests executed on which distribution(s)

[ ] KinD
[ ] AKS (Azure)
[ ] EKS (AWS)
[ ] Scaleway
[x] SKS (Exoscale)

This is the comment I made on the other PR about the issue, I'll need to restart my research about the issue to freshen up my memory... -> https://github.com/camptocamp/devops-stack-module-longhorn/pull/12#issuecomment-1695378469

I can wait until v1.6.0
My cluster is currently deployed on the pre-release/v3.1.0 branch where I merged my PRs to be able to keep working until the v3.1.0 (or v4 depending of the final changelog) is released :+1:

Closed in favor of #12


Support maxUnavailable in rollout

What type of PR is this?
/kind feature

What this PR does / why we need it
Which issue(s) this PR fixes

part of https://github.com/kubernetes-sigs/lws/issues/3
Special notes for your reviewer
Does this PR introduce a user-facing change?

Support maxUnavailable in rollout

/hold

Main changes:

The general mechanism is we'll have a templateRevisionHash label for leaderStatefulst, leaderPod, workerStatefulset, workerPod, it will be used to verify that this is the new revision, so when leaderTemplate or workerTemplate is updated, we'll trigger a rolling update of the leader statefulset, which means a group of pods(leader+worker) will be updated the same time.
The rolling update number of replicas is defined by maxUnavailable, which means when we set maxUnavailable to 2, and we have a lws with 5 replicas, the rolling update index will looks like: 4,3 -> 2,1, -> 0.

Other updates:

the maxUnavailable is default to 1 because 0 is not allowed in Statefulset
the maxSurge(implementation not included in this PR) is default to 0, then the default behavior will rolling update a replica each time, I think this is more cautious.

Another concern is about the leaderWorkerTemplate.size, I have an implementation locally,  it behaves as when we increate or decrease the size, it will not lead to the statefulset rollingupdate, only scalilng up/down the worker pods. But I may need your inputs for this, and this is now conflict with several things:

we have a size annotation in the leaderPod, which will lead to the statefulset rolling update each time we change the size
the restart policy RecreateGroupOnPodRestart is somehow conflict with decreasing the size because when a pod is deleted, the leaderPod will also be deleted.

so I remove the rolling update for size update right now, and make it immutable as original.
Please take a look and sorry for the slow response because I'm right at kubecon last week. cc @ahg-g @liurupeng

/hold cancel
we may need e2e test as well. I'll add the e2e test framework later.

@kerthcet we have someone working on the e2e test already, that work is in progress, thanks!

I'll push the commits tomorrow. Only parts of the comments solved.

Regarding updating the size will trigger the StatefulSet upgrade, could you elaborate more on this?

As you said, we have an annotation on the leaderPod, so each time we update the size we'll trigger the whole rolling update of the pods. My assumption is when updating the size should we trigger the rolling update, or just scaling up and down, because the template is not updated.

/test pull-lws-test-integration-main

/test pull-lws-test-integration-main

/test pull-lws-test-integration-main

/hold
Just so it doesn't get merged by mistake, I would like to take a look at this once the forst round of review is done

/test pull-lws-test-integration-main

/test pull-lws-test-integration-main

so I remove the rolling update for size update right now, and make it immutable as original.

I think an immutable size is fine and a reasonable tradeoff to simplify the rolling update logic

Last 2 commit:

Add on e2e test
Solve the performance issue when calculating the partition field

All set @ahg-g

lgtm as well, I will wait for @ahg-g to approve

/label tide/merge-method-squash
/lgtm
/hold cancel
Great work!


Make buttons less molasses at low fixed timesteps

Swapped the exponential decay in InteractionButton for a friction-and-drag model, and tuned the coefficients to produce reasonable results at physics timesteps of 1/30, 1/45, 1/60, and 1/90 (seconds).
Note that at a timestep of 1/30 (and to a lesser extent 1/45), buttons are still noticeably slower than their 1/60 & 1/90 counterparts. (Making the button motion truly timestep-independent is nontrivial and honestly unnecessary). If it's important to be able to make the buttons faster in lower-frequency-timestep situations, we should expose button friction & drag in the inspector for user tuning. This could be done in this hotfix but should probably be done as a v1.1 release feature.
Qs for John:

[ ] Does the model make sense?
[ ] Should we expose friction and drag coefficients in the inspector?

Qs for QA:

[ ] Do buttons behave acceptably on Android now given the 1/60 timestep?
[ ] Do buttons and sliders still behave acceptably on all UI example scenes?

@nickjbenson I second the above regarding a 1.1.0 release. What prompted this fix was an Android issue. The Android package would be going to only select OEMs so honestly, I think the above changes should be held for a future release and we cut a special build for OEMs on this occasion only. If we go this route we would need to cut the build for OEMs and then re-target this PR for develop. Thoughts?

Closed in favor of #747.


ENH: added compression kw to to_csv GH7615

This closes #7615 and represents work that started in #2636.

I need help from pandas people (@jreback ?)
I get this single error on Travis-CI:
Traceback (most recent call last):

  File "/home/travis/build/pydata/pandas/pandas/tests/test_frame.py", line 7364, in test_to_csv_compression

    df.to_csv(filename, compression="gzip")

  File "/home/travis/build/pydata/pandas/pandas/core/frame.py", line 1294, in to_csv

    formatter.save()

  File "/home/travis/build/pydata/pandas/pandas/core/format.py", line 1460, in save

    self._save()

  File "/home/travis/build/pydata/pandas/pandas/core/format.py", line 1546, in _save

    self._save_header()

  File "/home/travis/build/pydata/pandas/pandas/core/format.py", line 1542, in _save_header

    writer.writerow(encoded_labels)

io.UnsupportedOperation: not writable

I assume "not writable" means that the file I'm trying to write to, which I got using ensure_clean(), is not writable. I don't understand why, I copied the test code from test_to_csv_float_format.

and does it work locally for you?

I couldn't build pandas on my windows pc or on a digitalocean ubuntu droplet - does pandas have a docker image you can recommend?
I'll try again, but please have a look at the travis build - some builds passed, does that make sense?

pls read the contributing docs here
creation of the proper build env is pretty easy using conda (and even local tools on linux, but windows we recommend conda as its dead simple). docker is much too heavyweight for most things iMHO.
pls build and debug locally first.

I had problems building pandas (python setup.py develop), but I managed to locally build pandas, see below.
Test problem and solution
The test error was caused because the compressed file was opened as read-only. I had to change the mode argument used to create compressed file handles in pandas.core.common._get_handle(). The function has a mode arg, but it was overriding it with rb for compressed files.
Anyway, thanks for helping me out with this!!
Build problem and solution
Building on my Windows laptop, I had other versions of gcc.exe installed. Calling which gcc should return C:\Anaconda\envs\pandas_dev\MinGW\bin\gcc.exe (depending on the path to Anaconda).
On my system I had to manually add C:\Anaconda\envs\pandas_dev\MinGW\bin to the begining of PATH:
set PATH=C:\Anaconda\envs\pandas_dev\MinGW\bin;%PATH%

and if you already tried python setup.py develop once, then you probably need to do python setup.py clean before trying again.

pls add a release note in 0.17.1 (enhancements section), and squash.

Sure thing. I've never 'squashed' before - any comments/instructions beyond the contributing.html doc?

nope, that says it all

Fixed following code review (9bd5d24).

OK this was fun, I learned a lot. Thanks.

looks good. pls add a whatsnew note in enhancements for 0.17.1

Right. I did it but it got lost when I squashed. I'll do it again and squash properly.

Anything else comes to mind?

thank you sir!

Thank you, I've enjoyed the process and learned much.


Merge 2nd: gofumpt

Gofumpt code formatting provides a clear standard to
how your code should be formatted.

So, more or less-- the sctricter formatting of gofumpt standardizes the code better.  We've begun to use it across osmosis, the cosmos-sdk, and gaia.


Calculations with PolyHeavisides are incorrect

We find:
ghci> wait1 = PWP.constructDelta (1::Double)
ghci> wait2 = PWP.constructDelta (2::Double)
ghci> wait1
PDF (Pieces {getPieces = [Piece {basepoint = 0.0, object = Pd (Poly [0.0])},Piece {basepoint = 1.0, object = D 1.0},Piece {basepoint = 1.0, object = Pd (Poly [0.0])}]})
ghci> PWP.firstToFinish wait1 wait2
CDF (Pieces {getPieces = [Piece {basepoint = 0.0, object = Ph (Poly [0.0])},Piece {basepoint = 1.0, object = Ph (Poly [1.0])},Piece {basepoint = 2.0, object = Ph (Poly [1.0])}]})
ghci> PWP.firstToFinish wait2 wait2
CDF (Pieces {getPieces = [Piece {basepoint = 0.0, object = Ph (Poly [0.0])},Piece {basepoint = 2.0, object = H 0.0 1.0},Piece {basepoint = 2.0, object = Ph (Poly [1.0])}]})

Note that there is a jump but no Heaviside in the first result!

We also find:
ghci> PWP.allToFinish wait1 wait2
CDF (Pieces {getPieces = [Piece {basepoint = 0.0, object = Ph (Poly [0.0])},Piece {basepoint = 1.0, object = H 0.0 1.0},Piece {basepoint = 1.0, object = Ph (Poly [0.0])},Piece {basepoint = 2.0, object = H 0.0 1.0},Piece {basepoint = 2.0, object = Ph (Poly [0.0])}]})

which has two Heaviside jumps of 1!

The operations on PolyHeavisides are too simplistic - combining a polynomial and a Heaviside requires evaluating the polynomial at the point where the Heaviside occurs, whereas the current implementation ignores this.

The simplest solution is to remove Heavisides altogether, and encode them as simply jumps that occur between polynomial pieces. This complicates the implementation of piecewise differentiation, making it more symmetrical with piecewise integration, which has to evaluate at the piece boundaries to join things up, but saves a whole module!

Unfortunately this breaks the current abstraction, which relies on being able to differentiate an 'object' in each piece: without a Heaviside to differentiate, there's no way to create a delta! So this is not a quick fix. The other approach of doing additions and multiplications of Heavisides, requires passing in the value of the polynomial at the point (or at least the point so that the polynomial can be evaluated, which breaks the abstraction of binary operations on objects - no no quick fix here either!

I assume that the two representations are isomorphic to each other? Could we not convert to the appropriate form at the appropriate time?

The complication is that the number of intervals varies between the two versions, and the current implementation is structured on the assumption that most operations can be performed purely piece-wise.

On 7 Nov 2024, at 14:45, Neil Davies @.***> wrote:
I assume that the two representations are isomorphic to each other? Could we not convert to the appropriate form at the appropriate time?
—
Reply to this email directly, view it on GitHub https://github.com/DeltaQ-SD/dqsd-piecewise-poly/issues/15#issuecomment-2462416731, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUQ5PAP2627YUHDBJKGKA3Z7N4H3AVCNFSM6AAAAABRIXYBA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGQYTMNZTGE.
You are receiving this because you authored the thread.

http://pnsol.com/
Peter Thompson http://uk.linkedin.com/in/peterthompson, Consultant Scientist
Predictable Network Solutions Ltd. http://pnsol.com/,
+44 (0)333.340.7713 tel:+443333407713 • Twitter: @PNSolLtd http://twitter.com/PNSolLtd

This issue is fixed by the further commits to PR #14 that remove PolyHeavisides, with discontinuities in the CDF differentiated into deltas and v.v.

Need to consider the impact on the computation of centiles in the presence of jumps in the cdf.

Yes.

On 28 Nov 2024, at 15:43, Neil Davies @.***> wrote:
I have merged the fix-centiles branch/PR - does that close off this issue?
—
Reply to this email directly, view it on GitHub https://github.com/DeltaQ-SD/dqsd-piecewise-poly/issues/15#issuecomment-2506395225, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUQ5PHIOTUGF55Z2BYTSKL2C42ZPAVCNFSM6AAAAABRIXYBA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBWGM4TKMRSGU.
You are receiving this because you authored the thread.

http://pnsol.com/
Peter Thompson http://uk.linkedin.com/in/peterthompson, Consultant Scientist
Predictable Network Solutions Ltd. http://pnsol.com/,
+44 (0)333.340.7713 tel:+443333407713 • Twitter: @PNSolLtd http://twitter.com/PNSolLtd


Support rerouting output and exit code handlers.

Adds support for setting output writers and the exit code handler at the scope of the application.
While a CLI application most commonly does want to call os.Exit to handle exit codes, and print errors or usage information to the stderr file descriptor... it's also useful to be able to control these.  In this PR, that ability is introduced.
The main motivation for this (at least for me!) is for testing.  By allowing these to be user-controlled, it becomes possible for users to write tests of their CLI behavior.  (This is a big win, in my book!  IMO, it's very important to be able to write end-to-end tests of CLIs, because UX bugs in the last mile are otherwise very easy to accumulate.  To try to do this without the ability to control exit behavior and where messages are written, the next nearest fallback option is to invoke the whole program as a subprocess... but this is a fairly awful fallback, and carries considerable complexity burdens; invoking go-install in the middle of go-test... well, let's say it "does not spark joy".)
Previously, within this library, the needs for the library's own self-testing were satisfied by using package-scope variables, which aside from being global, were also unexported.  This is no longer necessary.  The internal tests now use the same mechanisms that will be available to users. (As a bonus, the tests could now be parallelized without issue, though I haven't taken that step in this commit.)
I've tried to implement this change in a minimally invasive way, and I think it's pretty safe.  Tests all still pass :)  There are a couple requests for review embedded in the comments in the diff (mostly for stylistic things).
I'm not sure if there were open issues for all of this, but at least https://github.com/jawher/mow.cli/issues/112 is addressed by this.

Agree that it is very useful (and much needed) addition.
I did another PR before I noticed this one (which is a bit light touch): https://github.com/jawher/mow.cli/pull/130


Fix argument reporter rendering with short text

Resolves
https://github.com/LLK/scratch-blocks/issues/1129
Proposed Changes
Fix argument reporter width when the text is short:

give the text area a minimum width
use the normal min block width, not the shadow min block width

Reason for Changes
Fixing #1129
Test Coverage

is a rendering of the following xml immediately after a load:
<xml xmlns="http://www.w3.org/1999/xhtml">
  <variables></variables>
  <block type="argument_reporter_string_number" id="dt3k(J)yIyA4%iipD2#=" x="121" y="1">
    <field name="VALUE">a</field>
  </block>
  <block type="procedures_defnoreturn" id="]){{Y!7N9ezN+j@Vr`8p" x="20" y="138">
    <statement name="custom_block">
      <shadow type="procedures_callnoreturn_internal" id="_m7RK@PTyvbq*RR:+u~^">
        <mutation proccode="do a barrel roll %n times" argumentnames="["x"]" argumentdefaults="[1]" warp="false"></mutation>
        <value name="input0">
          <shadow type="argument_reporter_string_number" id="@r$9K1DqSuWg%e/)@i*1">
            <field name="VALUE">a</field>
          </shadow>
        </value>
      </shadow>
    </statement>
  </block>
</xml>

Question in the code. Everything works as expected, I just wanted to learn a bit more about why it was needed.


[Quest/Malawi Core] Android App : Sync Inactive recently changed Resources which are being filtered

Fixes #73
Engineer Checklist

[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

@BuchiNy can redo the tests you did on syncing inactive resources on this branch, especially with patients


Add modulo option, simplify init, remove aux

Add Modulo option for both AndersonAcceleration and AndersonWrapper. Simplify their init() method by pushing the first iterates in update().
We observe that using modulo=history_size instead of modulo=1 does not decrease dramatically the convergence speed (see examples).

I added the examples of Anderson in the changelog.


Write 0.8 upgrading guide (and maybe write a cargo fix-like tool)

Progress

[ ] Write upgrading guide
[ ] (optional) Write upgrading tool

[ ] Commit example zerocopy project along with CI test that tests the upgrade tool (this will help us keep the tool up-to-date as we make further API tweaks)

Details
As described in https://github.com/google/zerocopy/discussions/1288#discussioncomment-9476006, and in my own personal experience upgrading the version of zerocopy vendored in Fuchsia, upgrading from 0.7 to 0.8 creates a large amount of churn. This falls into a few primary buckets:

Many APIs now require Immutable and/or KnownLayout
#[derive(FromZeroes, FromBytes)] now breaks, and needs to be replaced with just #[derive(FromBytes)]
FromZeroes and AsBytes have been renamed to FromZeros and IntoBytes, respectively
Many methods have been deprecated and need to be replaced by calls to different methods
The return type of fallible methods has gone from Option to Result
Some APIs that previously required B: ByteSlice now require B: SplitByteSlice

Upgrading guide
We should at a minimum write a detailed upgrading guide that explains what changes will need to be made, and what compiler errors to expect.
We may also want to include a note about the byteorder feature being removed.
Upgrade tool
We may also want to write a cargo fix-like tool that performs some of the upgrade automatically, as much of this can be done mechanically. In particular, the following set of transformations would result in code which is nearly semantically identical under 0.8:

Rename FromZeroes and AsBytes to FromZeros and IntoBytes
Everywhere FromZeros, FromBytes, or AsBytes is used (especially in derives and in trait bounds), add Immutable and KnownLayout as well
Everywhere both FromZeros and FromBytes are derived, remove FromZeros
Replace calls to deprecated methods with calls to their replacements
Add .ok() to most FromBytes methods and Ref constructors
Replace ByteSlice with SplitByteSlice in trait bounds

Some of these could be done with a relatively low false positive rate just using standard unix shell tools. Some of them would be better served by a more powerful tool that can parse Rust code and resolve item paths (e.g., detecting whether a use of Ref::new refers to zerocopy::Ref or some other Ref).
A few suggestions from this thread:

ast-grep

Here's an example of rewriting a #[derive]

"If you do not mind changing the formatting, you may use the syn crate with the visitor feature to browse and edit the code, then prettyplease to get a readable output."
Write a rustc-driver plugin
rust-analyzer search and replace
gritql
VSCode refactoring action

I'm going to use this comment to draft the upgrading guide.
Zerocopy 0.7 -> 0.8 Upgrading Guide
Thank you for using zerocopy! Our new 0.8 release includes a number of changes which are backwards-incompatible with 0.7. This guide describes these changes and gives advice for how to make the upgrade process as painless as possible.
Implied derives
The FromBytes trait is a sub-trait of FromZeros. On 0.7, in order to derive FromBytes, you also had to derive FromZeros explicitly:
#[derive(FromZeros, FromBytes)]
struct Foo { ... }

On 0.8, deriving a trait automatically derives its super-traits. This code will now fail to compile since the FromBytes derive will emit an impl of FromZeros, which will conflict with the impl derived by the explicit FromZeros derive. Instead, simply write:
#[derive(FromBytes)]
struct Foo { ... }

New names
The AsBytes trait has been renamed to IntoBytes. The FromZeroes trait has been renamed to FromZeros.
A number of Ref methods have been renamed or deprecated in favor of a more general method. The old methods are preserved and marked as #[doc(hidden)] #[deprecated], including a deprecation message that indicates which API should be preferred in 0.8. We recommend using these compilation warnings as a guide for how to upgrade individual call sites.
New traits
FromBytes and IntoBytes
Some properties that were previously required by FromBytes or IntoBytes (previously AsBytes) have now been split into separate traits. APIs that still require those properties now add bounds on these new traits.
The new traits in question are KnownLayout, which encodes certain layout information about a type, and Immutable, which indicates that a type does not contain any UnsafeCells.
We recommend that you simply derive KnownLayout and Immutable on any type with existing zerocopy trait derives. Alternatively, for a more fine-grained approach, use compilation errors as a guide to which types should derive these traits.
ByteSlice
The ByteSlice trait now supports byte slices which cannot be cheaply split in two. The new SplitByteSlice trait extends ByteSlice with this behavior. In 0.8, SplitByteSlice is analogous to what ByteSlice was in 0.7. The same holds for ByteSliceMut and SplitByteSliceMut.
If you don't care about maximum flexibility, we recommend simply replacing all instances of ByteSlice[Mut] with SplitByteSlice[Mut]. Alternatively, if you wish to support ByteSlice[Mut] types which cannot be split, use compilation errors as a guide to where you need to add SplitByteSlice[Mut] bounds.
New return values
Many methods that previously returned Option now return Result, and include a finer-grained error type. If you wish to preserve the 0.7 behavior and minimize the code change needed to upgrade, simply add .ok() to these call sites in order to convert Results back into Options. However, we recommend that most code should try to migrate to the new error types eventually, as they will help you ensure that you're only handling errors that you expect. For example, having to handle an AlignmentError where you don't expect it is an indication that you could use a different API that guarantees freedom from alignment errors (e.g. one of the Ref methods with unaligned in the method name).
Miscellaneous
The byteorder feature has been removed; in 0.8, the byteorder module is always present, and is not optional.

Upgrading guide is published in our release announcement. We won't write an upgrading tool.


Question regarding js dependency for custom viewer

What would be the best way to make a js dependency (in this case https://timeline.knightlab.com/) available to use in a custom viewer? I have it available in my project, but unsure how to load it into the portal UI.

Hi @maacl, currently there isn't an easy way to bring in js dependencies outside of manually injecting a script tag.

OK. Where should I place the files, if I want cross scripting issues?
On Fri, 6 Jan 2023, 17:38 Chris Badahdah, @.***> wrote:

Hi @maacl https://github.com/maacl, currently there isn't an easy way
to bring in js dependencies outside of manually injecting a script tag.
—
Reply to this email directly, view it on GitHub
https://github.com/djblue/portal/issues/164#issuecomment-1373874840, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPUXCYP2GWM6EKPOYGCZ3WRBC6ZANCNFSM6AAAAAATMH5C7U
.
You are receiving this because you were mentioned.Message ID:
@.***>

@maacl I think https://github.com/djblue/portal/commit/70ce1a2622ac4b25a029b7bb14f0053d76070064 might end up solving your problem in the next release. It will allow cljs code loaded via sci to pull js from node_modules.

This issue should be resolved as of 0.37.0. Please let me know if you run into any issues.

Thanks, I will give it a try.


[HelpDot] article content for both platforms is shown by default

Problem:
When you open an article that has content for both old dot and new dot, the content is shown for both.
Solution:
Hide content of the platform that is not selected.

issue resolved


tests: fix api.sh gcp ssh connection timeout

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the READMEs listed here
[ ] submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

I've been trying different variations over the week while working on other stuff and I've finally found something that seems to work :sweat_smile:

Unfortunately it looks like it doesn't help resolve our issue https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7807093869
I'm going to try something else.

I was unable to come into agreement with the gcloud command so I've decided to implement our own retry mechanism which worked when I tested it on the side, I hope other tests are fine with it as well. Here is where it helped prevent the timeout https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7809695856


[Bug]: Wordlist upload speed slow

Version of the software
0.2.3
Operating system
Linux
Browser / Native
Browser
What happened?
Upload speed is slow. I'm not sure if it's the issue with the blazor file upload method, but uploading a file on websocket in 27kb chunks of base64 encoded bytes takes forever.
Relevant LoliCode if needed
No response

New web client should fix this. If not, it might be your connection


[Python] Make CacheOptions configurable from Python

Describe the enhancement requested
When doing parquet reads from high latency storage e.g. S3 or Azure blob storage its beneficial to use fragment_scan_options=ParquetFragmentScanOptions(pre_buffer=True).
As far as I can tell pre_buffer=True does 2 important things:

It reads all the parquet metadata at the beginning then makes all the data block reads.
It coalesces adjacent data blocks so that it can read the data in a smaller number of larger reads. Coalescing is done based on CacheOptions, in particular hole_size_limit and range_size_limit.

In my use-case I have found that while point 1 is very beneficial for performance point 2 is actually detrimental. Point 1 though is still enough to make pre_buffer=True a net advantage. I found that setting range_size_limit to a much smaller value (in combination with pyarrow.set_io_thread_count(<large number>)) can give me ~6X performance improvement on my usecase because it increases the parallelism. I would therefore like to make these parameters configurable from python.
If you are interested in my use-case I'm loading a single parquet file from US East Azure blob storage to a workstation in the UK. Probably the current defaults would be sensible if it wasn't for the trans-Atlantic latency. (Pyarrow does not natively support Azure yet but I'm making use of https://github.com/apache/arrow/pull/12914 even though its not in an official release yet)
I can make a PR that implements this if others agree that its a sensible idea.
Component(s)
Python

cc @westonpace @lidavidm @AlenkaF

It seems reasonable.

The CacheOptions is also already explicitly exposed in the IpcFragmentScanOptions (on the C++ side, this class it not yet exposed in Python).
All the other options of ArrowReaderProperties are exposed in the pyarrow equivalent (in ParquetReader in _parquet.pyx), so indeed seems to make sense to expose the cache options as well.
In the ParquetFragmentScanOptions, currently only pre_buffer is exposed.

take

I've opened a PR for review to address this https://github.com/apache/arrow/pull/36627.
I don't have much experience with C++ or Cython and this is my first contribution to arrow so hopefully what I've done makes sense.


team-teaching: re-work based on review in chat

Focus on models not abstract roles
Rename the roles to be more unique
Overall, try to make it more practical and less theoretical.
Review:

Someone should give it a good read, but could be done either
before or after committing.  This includes both content and
syntax, I wrote it quickly.
Again, I have inserted some of my opinions.  These should be
identified and made more general.

Thanks! I will send a follow-up PR hopefully today.


UnsupportedKerasConfigurationException: No SameDiff Lambda layer found for Lambda layer ctc.

Issue Description
when i import keras model ,it shows that
Exception in thread "main" org.deeplearning4j.nn.modelimport.keras.exceptions.UnsupportedKerasConfigurationException: No SameDiff Lambda layer found for Lambda layer ctc. You can register a SameDiff Lambda layer using KerasLayer.registerLambdaLayer(lambdaLayerName, sameDiffLambdaLayer);. Please file an issue at http://github.com/deeplearning4j/deeplearning4j/issues.
Version Information
Please indicate relevant versions, including, if relevant:

Deeplearning4j 1.0.0beta4
no CUDA

Take a look at https://github.com/SkymindIO/deeplearning4j/blob/master/deeplearning4j/deeplearning4j-modelimport/src/test/java/org/deeplearning4j/nn/modelimport/keras/e2e/KerasLambdaTest.java
There's basically no documentation on it, but that example should be what you need.

i follow your suggestion,but when i "import org.nd4j.resources.Resources;",it shows that "can not resolve resources",how can i import org.nd4j.resources.Resources?and where is the jar file that builded  deeplearning4J?

Its for accessing test resources, you shouldn't need to use it.  It lets the test access files from the dl4j-test-resources project, which is where we store model files and stuff for tests, that don't need to go into production.
You should be able to use whatever existing code you have for accessing the model file and doing the import, just add on the KerasLayer.registerLambdaLayer and the SameDiffLambda classes and instances.

Hello everyone, I am trying to import my Python Tensorflow Keras model to a ComputationGraph  using importKerasModelAndWeights and get the same error as described by @ziyuwzf. I was following the provided example but can't seem to figure out a solution for my specific case.
Within the Tensorflow Keras model I use a lambda layer to squeeze a tensor:
x_cnn = tf.keras.layers.Lambda(lambda x: tf.keras.backend.squeeze(x, 1))(x_cnn)
squeeze of org.nd4j.linalg.factory.Nd4j returns an INDArray so that I am somewhat lost. After all defineLayer returns a SDVariable. Can you guys give me a hint how to get the squeezing layer to work in the ComputationGraph?
Any help is highly appreciated

@fxbronk There's 2 APIs to be aware of here:

ND4J, which is like numpy (i.e., INDArray)
SameDiff, which is like tensorflow

you need to use SameDiff API not ND4J. In summary, the defineLayer(SameDiff sd, SDVariable x) method should for your lambda layer should look like:
 public SDVariable defineLayer(SameDiff sd, SDVariable x) {
    return sd.squeeze(x, 1);
}

Hello @AlexDBlack, thank you, you made my day! Works like a charm.
I was not yet familiar enough with dl4j to figure the difference between ND4J and SameDiff. Anyways, problem solved :).


Warning: "Result of call to 'hide(_:animated:)' is unused"

Hi,
Your loading indicator works well. However, Xcode alaway gives warnings of "Result of call to hide(_:animated:)' is unused and also in the case of show(). How could I deal with this?

You just need to do this:
_ = EZLoadingActivity.show("Loading...", disableUI: true)

Let me know if you need any help and I can reopen the issue! 😉

Don't we have discardable result in those funcs?

@lfarah yap! the warning disappeared

@goktugyil Xcode 8 still gives warning....

Then what good does discarable result do?


Cannot change default CPU and Memory for inferenceservices

/kind bug
kubectl -n kfserving-system edit configmap inferenceservice-config
        "sklearn": {
            "image": "gcr.io/kfserving/sklearnserver",
            "defaultImageVersion": "v0.4.0",
            "memoryRequest": "100Mi",
            "memoryLimit": "1Gi",
            "cpuRequest": "100m",
            "cpuLimit": "1"
        },

kfserving/sklearn.yaml
apiVersion: "serving.kubeflow.org/v1alpha2"
kind: "InferenceService"
metadata:
  name: "sklearn-iris"
spec:
  default:
    predictor:
      sklearn:
        storageUri: "gs://kfserving-samples/models/sklearn/iris"
#        resources:
#          limits:
#            cpu: 1
#            memory: 500Mi
#          requests:
#            cpu: 100m
#            memory: 250Mi

kubectl apply -f kfserving/sklearn.yaml -n kfserving-test
but i still get
Spec:
  Default:
    Predictor:
      Sklearn:
        Resources:
          Limits:
            Cpu:     1
            Memory:  2Gi
          Requests:
            Cpu:          1
            Memory:       2Gi
        Runtime Version:  v0.4.0
        Storage Uri:      gs://kfserving-samples/models/sklearn/iris

What did you expect to happen:
Spec:
  Default:
    Predictor:
      Sklearn:
        Resources:
          Limits:
            Cpu:     1
            Memory:  1Gi
          Requests:
            Cpu:          100m
            Memory:       100Mi
        Runtime Version:  v0.4.0
        Storage Uri:      gs://kfserving-samples/models/sklearn/iris

Environment:

Istio Version:
Knative Version:
KFServing Version:
Kubeflow version:
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version:
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

same as #1593


🚀 Feature: Addition of showCommonExtensions Prop to SwaggerUI Component in plugin-api-docs

🔖 Feature description
We would like to add the configuration parameter 'showCommonExtensions' to Swagger UI. This would allow us to show constraints within the view. ###
🎤 Context
We would like to be able to see constraints like "limit 1<=value<=100" within the Swagger view. This can be done by enabling the showCommonExtensions configuration.
✌ Possible Implementation
The showCommonExtensions could be a boolean that could be passed to the OpenApiDefinitionWidget similar to how we do it for "supportedSubmitMethods" https://github.com/backstage/backstage/pull/22227
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hej @theparthshukla - thanks for raising this. Feel free to give it a go & raise a PR!:)


Release needed after fix provided in #728

After the fix provided in https://github.com/readthedocs/sphinx_rtd_theme/pull/728, a release is needed as we are several users blocked by that.
Could you provide one release, please? Thanks.

Same as #821 :wink:


Contributed TradingEnvDaily

TradingEnvDaily is a high-level wrapper of TradingEnv tailored for daily data. It lowers the barrier to entry for some applications.
Before being commited to master, it requires further testing, refactoring and documentation.

Added TradingEnvXY with a few tests. Also fixed some documentation issues here for convenience, but should have really been done in a separate repo. Ready to merge.


Multidat

This touches some of the same code as https://github.com/datproject/dat-desktop/pull/173. I think once this patch is merged we can move to some of the ergonomics #173 provides (e.g. using getters and the like for state access). This patch should provide us with some robust underpinnings to work on top :sparkles:
changes

removes all dependencies on level which preps us for the upcoming SLEEP release
moved state into ~/.dat-desktop-db.json using toiletdb
renamed some methods on model/repos to be more in line with the dat cli
moved our custom dat management code into multidat library. It's fully tested to make sure it works as expected and relies on multidrive and the latest dat-node
made all unhandled errors call back instead. Might lead to crashes where errors were previously swallowed
added a test to catch unused deps
removed a whole bunch of unused deps
removed more code than was added which is always :cool:

todo

[x] use the multidat.readManifest() method to determine author and title
[x] fix key restart regression in https://github.com/datproject/dat-node/commit/508de80063bf87b90e4142bf5803b7d5d5d23c21

notes

placing this under the public launch milestone because moving off level should be done sooner rather than later
I thought #173 was merged already before submitting this PR; apologies that there's some overlap there!
during the writing of this patch we found a few subtle bugs in dat-node; they're solved now but we'll probably run into more
there's less DB lock errors it seems, but we're hitting different state corruptions now; I think we'll need to focus on debugging for the next week or so to have it stable enough for a release

@juliangruber doneeeeee :sparkles:

just arrived at a place with internet so pushed final changes based on comments you made; tried pushing yest but somehow github wouldn't let me. Should be all good now I think - feel free to merge.
Big warning on that this might cause all sorts of bugs to pop up b/c we're handling more errors now; if you folks could go ahead and test things that'd be very valuable I reckon. Cheers!

you force pushed over the commits i pushed to this branch, that's why it didn't let you

you force pushed over commits i added to this branch, that's why github didn't let you


feature: add message compliance check

Codecov Report
Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.20%. Comparing base (72e6b71) to head (aec4767).
Report is 1 commits behind head on main.

Files
Patch %
Lines

gischat/models.py
86.95%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   92.62%   92.20%   -0.42%
==========================================
  Files           4        4
  Lines         122      154      +32
  Branches       14       21       +7
==========================================
+ Hits          113      142      +29
- Misses          6        8       +2
- Partials        3        4       +1

Flag
Coverage Δ

unittests
92.20% <90.90%> (-0.42%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Loopback V3 With $metadata Issue

Hi , i try to get meta data from loopback v3

i can access /odata/$metadata without User and AccessToken in model-config.json

2)if i put User and AccessToken in model-config.json i get bellow error

Please give guide to solve this issue
thanks & regards
umayaraj.b

Sorry but I stopped development on this package cause of lack of response. If you find a solution fix it and send a PR with documentation. I will then merge this into the repo.


Cannot read property 'transform' of undefined thrown when use precomputeStyle

I read the code 'precomputeStyle.js', at line 66:
function _processor(key: string, validAttributes: Object) {
  var process = validAttributes[key] && validAttributes[key].process;
  if (!process) {
    process =
      ReactNativeStyleAttributes[key] &&
      ReactNativeStyleAttributes[key].process;
  }

  return process;
}

when the validAttribute is null, the error is thrown.
Should this line
  var process = validAttributes[key] && validAttributes[key].process;

changed to:
  var process = validAttributes && validAttributes[key] && validAttributes[key].process;

?

send pr?

I haven't seen validAttributes be null. I guess we add an invariant to make the error message be clearer.

Maybe third-party components cause this error. If this is a behavior change，should we give warning in current version?
Ide, we really need change log for 0.12 ~~

Everyone is too busy so we linked to the commit history. Sorry about 0.12. Hopefully 0.13's changelog is helpful.

@tdzl2003 Could you please tell me where should to replace the line to temporary fix this bug? I can't find precomputeStyle.js anywhere...thank you!

undefined is not an object (evaluating 'validAttributes[key]')

As the error message say, in 'precomputeStyle.js'
It's in node_modules/react-native/Libraries/StyleSheet

@tdzl2003 right, didn't find it at first. Thank you!

seems the precomputeStyle have no default validAttributes value, can be added manually to avoid this problem, but seems it's more like a bug.
it works for me to manually pass a second variable to set the validAttributes like below:
let nativeProps = precomputeStyle({ transform: [{rotate: '45deg'}] }, {transform:true});

This issue should already be fixed after 0.15. Closing this.


Bump version to 0.23.11

Why
Cutting a new release so we can ignore service/procedure removal when checking schemas for breakage
What changed
256c02a Add options to ignore service/procedure removal during diffing (#198)

Versioning

[ ] Breaking protocol change
[ ] Breaking ts/js API change

Current dependencies on/for this PR:

main:

PR #199 👈

This comment was autogenerated by Freephite.


Now Without log-in user can't navigate to bottom navigation page

Description
In the case of email and password auth, if the user came from the sign-up-additional-page to the log-in page and if close the app and reopen the app, without log-in even without registered email verification, the user can navigate to the bottom navigation page... That breaks auth.... I improve it.... Without proper log-in user can't navigate to bottom navigation page.....
Fixes #101
Replace #101 with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

I don't know how to add a screenshot for that bug fix..... Sorry.... But my change works properly...
Hope you review it and merge it soon .... Thanks @HimeshNayak  @avinashkranjan

Description
In the case of email and password auth, if the user came from the sign-up-additional-page to the log-in page and if close the app and reopen the app, without log-in even without registered email verification, the user can navigate to the bottom navigation page... That breaks auth.... I improve it.... Without proper log-in user can't navigate to bottom navigation page.....
Fixes #101
Replace #101 with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x]  Yes
[ ]  No

Type of change

[x]  Bug fix (non-breaking change which fixes an issue)
[ ]  New feature (non-breaking change which adds functionality)
[ ]  Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x]  My code follows the style guidelines(Clean Code) of this project
[x]  I have performed a self-review of my own code
[x]  My changes generate no new warnings
[ ]  I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

I don't know how to add a screenshot for that bug fix..... Sorry.... But my change works properly...
Hope you review it and merge it soon .... Thanks @HimeshNayak @avinashkranjan

@HimeshNayak please review that pull request

Great @SamarpanCoder2002 !
LGTM @avinashkranjan you can merge this PR.

Thanks for review @HimeshNayak ..... Hopw you merge it soon @avinashkranjan

Great @SamarpanCoder2002 !
LGTM @avinashkranjan you can merge this PR.

Thanks for review @HimeshNayak ..... Hopw you merge it soon @avinashkranjan

If there is no problem... please merge it @avinashkranjan


Unable to Construct a Typed Object with a String Literal

Bug Report
🔎 Search Terms
mapped type
[index: string]
🕗 Version & Regression Information

type Keys = "one" | "two"

// { [x: string]: {}; } is not assignable to type
const createMappedKeyObject = <K extends Keys>(k: K): { [I in K]: {} } => {

  return { [k]: {} }
}

// "one" does not exist on type
const createRecordWithkeys = <K extends Keys>(k: K): Record<K, {}>=> {

  return { "one": {}, "two": {} }
}

// unhappy  '{ [x: string]: {}; }' is not assignable to type
const createRecordFromGenericKeys = <K extends Keys>(k: K): Record<Keys, {}> => {

  return { [k]: {} }
}

// unhappy  '{ [x: string]: {}; }' is not assignable to type
const createObjOneKey = <K extends string>(k: K): Record<K, {}> => {

    return {[k]: {}}
}

// This should be satisfied isn't
const createMappedKeyObjectOneKey = <K extends Keys>(k: K): { K: {} } => {

  return { [k]: {} }
}

// This is happy
const createMappedKeyObjectWorks = (k: "one", j: "two"): Record<Keys, {}>=> {

  return { [k]: {}, [j]: {} }
}

🙁 Actual behavior
There is weirdness behind using the mapped type object. After reading the FAQ it does seem to stem from evaluation of the generic as a string.
createObjOneKey always requires assertion to get to Record<K, {}>
You can never satisfy the compiler when trying to build an object like this.
🙂 Expected behavior
createObjOneKey should work like this
const newSingleton: Record<"one", {}> = createObjOneKey("one");

createMappedKeyObjectOneKey should be fine as well it's not using a mapped type.

Annotated:
type Keys = "one" | "two"

const createMappedKeyObject = <K extends Keys>(k: K): { [I in K]: {} } => {
  return { [k]: {} }
}
// Correct error.
// The function is unsound; it claims to create an object with two properties
// under the call createMappedKeyObject<"one" | "two">("one")
const m = createMappedKeyObject<"one" | "two">("one")
m.two; // <- not present!

// "one" is not necessarily present; excess property checking is conservative:
const createRecordWithkeys = <K extends Keys>(k: K): Record<K, {}>=> {

  return { "one": {}, "two": {} }
}

// Same as createMappedKeyObject
const createRecordFromGenericKeys = <K extends Keys>(k: K): Record<Keys, {}> => {

  return { [k]: {} }
}

// Same as createMappedKeyObject
const createObjOneKey = <K extends string>(k: K): Record<K, {}> => {

    return {[k]: {}}
}

// Same as createMappedKeyObject
const createMappedKeyObjectOneKey = <K extends Keys>(k: K): { K: {} } => {

  return { [k]: {} }
}

// Actually works, so is OK
const createMappedKeyObjectWorks = (k: "one", j: "two"): Record<Keys, {}>=> {
  return { [k]: {}, [j]: {} }
}

It's amazing how many generic patterns that look acceptable on the surface are rendered immediately unsound by the existence of untagged union types.

It would be one thing if inference widened my K to string, but I can't get a record whose keys are K to work without an assertion, which makes me think this is a broader issue than the original poster's input being a union of two strings.


Add support to track for multiplayer

Will need to adjust data.json model to have a top level player id field. The tracking outside of shipping and store will be fragile because it won't account for multiple transactions within the span a player's menCchanged events fire for open and close

Will probably focus on multiplayer when there's demand and/or SMAPI expands the multiplayer API


Approvals number on pull request list

If the approvals number displayed on pull request list, that will help.

Any indication on when this feature will be implemented? Our team processes a large number of PRs a day, and we use a system of 2 needed approvals. The PRs that have already been approved by one reviewer could more easily be prioritized by the other reviewers if this number was shown in the list.

I think it's being worked on as should be available in 1.12

https://github.com/go-gitea/gitea/pull/10238

@otbutz #10238 almost completes this feature but it doesn't give an idea of how many reviews are required - which is why I didn't close this bug with that pr.

Ah, thanks for that insight. But nevertheless, it's progress ;)

This feature is asked by SPIP community as we have many PR. It'll helpful to process final review/merge with a one page to check state approval :)

I think this one could be closed now :)

@otbutz #10238 almost completes this feature but it doesn't give an idea of how many reviews are required - which is why I didn't close this bug with that pr.

Is that one covered?


Kconfig: introduce CONFIG_64BIT

This is the generic symbol to select or otherwise test for when 64-bit
compilation is desired. Two trivial usages of this symbol are also
included.

On Mon, 3 Jun 2019, Andy Ross wrote:

This gets a little murky with x86_64 hardware, where the use of the
x32 ABI is a legitimate optimization choice and probably does want to
be under the control of the app.  I'd suggest just dropping the last
sentence, or alternatively I could make x32 tuning a separate kconfig
that transitively selects this one (but then inevitably someone is
going to ask why native_posix and x86_64 use different tunables for
the same purpose).

I think we should do the later. Whether or not 64-bit may be a choice is
platform dependent. On x86-64 you have the choice of using the x32 ABI
because the toolchain supports it. On RISC-V this depends on the SOC
implementation. On other platform it would be selected unconditionally.

@aescolar:
I beg to differ. This symbol has no prompt on purpose. As mentioned in
its help text, this is meant to be selected by the actual target and not
at a generic level.
The "64bit-ness" of a target is largely dependent on the target itself.
For example:

The x86-64 target currently uses the x32 ABI to compile Zephyr, but a
user could decide to use the native 64-bit mode instead.

On Aarch64 (if supported someday) the choice of using the x32 ABI does
not exist as it has not been implemented in the toolchain IIRC. In
that case the selection would be unconditional.

On RISC-V this depends on the SOC implementation. Some are 32-bit
only, some allows for both modes, and some will work in 64-bit mode
only (I may confirm one case that corresponds to the later which is
the primary motivation behind this work). And if the ilp32 ABI gets
implemented for RV64 then you will end up with 3 choices: RV32, pure
RV64 and RV64 with the ilp32 ABI.

The native-posix target may support either or both depending on the
host system and its installed libs.. Sometimes you may have the
choice, sometimes not.

So I really think that the generic CONFIG_64BIT symbol should be
selected in the context of the target configuration menu where the
conditions for its usage are well known, similar to the little vs big
endian config symbol.
I have further patches enabling 64-bit for native-posix. The
CONFIG_64BIT gets selected from the user choice there.

FWIW: I think this is fine.  This can be our internal "the target is a LP64 environment at runtime" flag for spots where we want the ABI to be visible to code, and the various arch/soc/board/app layers can provide their own tunables for how to set it given their own quirks.

@npitre Note that I had dismissed my own review. Your point was understood from your previous response to @andyross. No need for further discussion from my side.


improve(AcrossV3): Drop gas introspection in handler contract

Which Jira task belongs to this PR?
n/a
Why did I implement it this way?
The Across message handler function does not require any gas introspection. Cross-chain intents under Across instead outsource gas considerations on the destination chain to the relayer function.
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] This pull request is as small as possible and only tackles one problem
[x] I have added tests that cover the functionality / test the bug
[x] I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

[ ] I have checked that any arbitrary calls to external contracts are validated and or restricted
[ ] I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
[ ] I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on  by <company/auditor>

Changes have been incorporated in this PR https://github.com/lifinance/contracts/pull/897


feat: support https://theplanttokyo.atlassian.net/browse/QOR5-389

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Add all credits for libraries we use

I believe their licenses mean we don't need to but I feel like it's a good courtesy

Closed by #134


Enable scroll through

Hi, great library that you built! I'm placing multiple player composables into the LazyRow but I can't scroll it by swiping on the player. Can you help me pass scroll gesture to the parent composable?

I'm trying to scroll horizontally through the list of videos. If I just place YouTubePlayer in a LazyRow item - nothing specific code-wise, it will scroll but it will trigger actions on the player itself regularly, which disturbes the UX.
I tried doing some fancy logic disabling the gestures on YouTubePlayer via modifier but it's been pretty inconsistent - sometimes it won't scroll at all, at other times it will scroll but also invoke some action on the player itself.
https://github.com/IlyaPavlovskii/YouTubePlayer/assets/17719689/06ddb0eb-ce1f-4029-9dca-cdc8bb9cefab

Investigated problem. The major trouble that webview interprets touches as a click. Continue searching for how to solve that problem.

Any further findings @IlyaPavlovskii, should I contribute somehow?

Sorry, didn't find any good solution(
Sure, if you have any idea I'll be very grateful
Thanks


Provide reproductible binary (if possible)

To ease the validation process in case of potential corruption.
For information: https://blog.filippo.io/reproducing-go-binaries-byte-by-byte/
Related #4167

Seems like this should be fixed by: https://github.com/go-gitea/gitea/pull/18193#pullrequestreview-846150669


⚠ Bofrost.lu has degraded performance

In b89ec26, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1478 ms

Resolved: Bofrost.lu performance has improved in 2f20ae5 after 1 hour, 22 minutes.


Feature/version 1 additions

I basically went trough classes and resolved whatever phpstorm inspections reported

Coverage decreased (-0.04%) to 84.586% when pulling 5e05b0836be9cdbd63741ba9efd92681a2a752d2 on ivanstan:feature/version-1-additions into ace54e4496775b38df885a836fe2ba4e13fcf74e on yswery:version-1.

I like 90% of this PR. You have gone in the right direction with renaming the methods to remove underscores.
Is there a particular code style, in addition to PSR-2, that your are following? Because there is no programmatic need to have a leading slash before inbuilt function calls such as chr().


can't add pets

Describe the bug
A clear and concise description of what the bug is.
Screenshots
Please send screenshots of the developer console (Right-click > Inspect > Console) on the pages where the bug is occurring.
Additional context
Add any other context about the problem here.

I think I have this, too. When trying to spawn a new pet (either via command palette or the plus sign in the panel), the list of new pet options flashes for a moment and disappears. The "default" pet I specify in the settings doesn't show up anymore, either. It was there initially, but I removed all once, and can never get them back.
This issue only occurs for me in explorer mode. Panel mode works fine.
@catherineabcde , if you set  "vscode-pets.position": "panel", in your settings, are you able to add pets then? I'd definitely like to use this extension in explorer mode!

I have the same problem!

I cannot reproduce this error when using "vscode-pets.position": "panel", and the other option of "vscode-pets.position": "explorer",. Are you using the latest versions?

I did updated to the latest version and it didn't work. but now it works somehow.

I have same problem as well

the issue come up after 1.24.0

Also have this issue. I just downloaded v1.25.0 it was working just fine. Once I changed the position to panel and back to explorer the explorer view no longer works. trying to start a new session doesn't spawn anything and when you try to add additional pets as mentioned above the list just flashes. even after a complete fresh install. It is still not opening properly.

I have the same problem, using "vscode-pets.position": "explorer" i cannot add pets, however i was able to add pets by switching to "vscode-pets.position": "panel",then exporting and finally switching to "vscode-pets.position": "explorer" and importing.