Add guidelines about the prisma command

Style guide: add guidelines about the prisma command, following discussion in the tech writers/developer advocacy meeting.
@nikolasburk  , @TasinIshmam , @ruheni , @keerlu , @zachtil, @tanberry , @ObamaTheLlama114  feel free to add your thoughts. We did discuss a special case for prisma migrate, but not I'm writing the guidelines up, I am not sure we need this - if you think we do, please add a comment or suggestion in the PR.

LGTM!
I don't think there's a special case for any of the prisma migrate commands. We did talk about 'Prisma Migrate', the product name, which covers all the prisma migrate commands, but that's a bit different and I don't think it matters here.


i18n(en): add a comment for translators on the data structure in localized nav.ts files

Description (required)

I misunderstood how to update nav.ts for Japanese (ref. https://github.com/withastro/docs/pull/6985#issuecomment-1961828452). I also saw the same error in French translation.
To prevent incorrect data structure in nav.ts in the future, This adds a comment for translations in en/nav.ts.
/cc @Yan-Thomas
Related issues & labels (optional)

Closes #
Suggested label:

!coauthor

It's really clear and easy-to-understand instruction! Thanks for the improvement @sarah11918  👍🏻


WIP: fix: Moved release profiles into root pom and added release.sh

Relates to: #126

Hi @rhuss , @iocanel ,
I added release.sh to perform mvn release:prepare release:perform, and moved release related profiles into root POM. Mainly because I thought release should run only if build.sh successfully complete. So we can run build.sh to build and then release.sh for release from Jenkins. WDYT?
@cunningt ,
I'm also wondering if this change affects product build or not (GitHub wisely suggested you as a reviewer :-). Can you take a look?

I added release.sh to perform mvn release:prepare release:perform, and moved release related profiles into root POM. Mainly because I thought release should run only if build.sh successfully complete. So we can run build.sh to build and then release.sh for release from Jenkins. WDYT?

Normally a release includes a full build, so I actually would not separate them (as it also probably shares common functionality). Maybe adding an option to build.sh to enable the profile and then call the proper mvn targets ?

@rhuss thanks for the comment, OK that works for me.
I added --release-version and --development-version into build.sh, and if --release-version is specified, it invokes release:prepare release:perform release:clean targets at last.

Alright, @iocanel is this enough to get you work on adding Jenkins job for AtlasMap release?


DataUtilities.createData() gives unexpected results

When Invoking DataUtilities.createData(), if the existing data was an address the result seems to be a pointer to the DataType I am attempting to create, even if I specify CLEAR_ALL_CONFLICT_DATA.  I have to clear the listing before invoking createData() to get consistent results.
To Reproduce
Invoke DataUtilities.createData to create some data, let's say some structure X.  If the existing data is "address", this will end up creating a pointer to structure X.  If the existing data is anything else, or if it is undefined, it will end up creating a structure X.
Expected behavior
The result should be an instance of the DataType passed in existing at the address specified, regardless of whatever existed or not before the call (at least, if CLEAR_ALL_CONFLICTING_DATA is specified).

Try setting the stackPointers parameter to false.

Yea, Okay..  I had been moving around some old code and came across my working around this.  From the comment in the code, I gather that this parameter used to be called "convertPointers" and seemed to be less well documented.  I believe that I set it to true without looking a lot deeper with the thought "Of course.  Convert everything to my new DataType.  I don't care what was there."
But, although it seems like a weird option to have, and kind of strange behavior, it is documented well enough (and I can no longer speak to how well it may have been described previously).  I still don't know that "stackPointers" encompasses the idea, but I certainly couldn't suggest anything better.


Bus not found error

When I open xjoy it always says bus not found. The problem is I correctly installed the driver and restarted my computer. Any help?

Are you sure you installed the vigem bus driver correctly? Try running this setup: https://github.com/ViGEm/ViGEmBus/releases/tag/setup-v1.16.116

acctually i get this exact problem
although i installed both the bus and the driver
why? IDK

acctually i get this exact problem
although i installed both the bus and the driver
why? IDK


Implement asynchronously reading TDMS files using tokio::fs

Asynchronously reading large TDMS files using tokio::fs could be beneficial for performance. I am willing to create a pull request for this and draw on my experience from implementing reading TDMS files in F#.

I'm all for it! I don't spend as much time on this library as I'd like, between my day job etc. so any and all help is awesome. I wrote this before I actually became familiar with async/await and tokio at all - so there absolutely can be some changes here.


fix(rich-text-link): Markdown pasting broken with conflicting linkOnPaste option

Overview
With the latest Tiptap version (https://github.com/Doist/typist/pull/407), the Link extension came with a new built-in linkOnPaste option (default: true), which conflicted with our own paste rules with support for Markdown syntax (in the RichTextLink extension), and our own PasteMarkdown extension with full support for Markdown pasting.
This PR simply forces linkOnPaste to be false, and disallows the option from being set to true in consumer apps. This is a workaround, as I believe this linkOnPaste option is not working as expected, and made an upstream comment about it here. If this is eventually fixed/improved in Tiptap, we can probably revert this change.
Making this a show PR so that I can push a quick fix to Todoist and Twist (we already started receiving reports about this).
PR Checklist

[x] Pull request title follows the Conventional Commits Specification

Test plan

Open the preview Storybook deployed to Netlify
Open the Rich-text → Default story
Copy the following content: [Doist](https://doist.dev)
Paste it into the editor with Ctrl + Shift + V (or the macOS equivalent)

[x] Observe that the editor will show the word "Doist" linked to https://doist.dev (visible in the "Markdown Output" section on the right side)

Demo

Before
After

👌


Setup CI

Motivation
We need to know when something breaks.
Feature
Initially, a simple CircleCI job that at least run builds and tests.
Alternatives
CI jobs can be implemented in several ways. We could use prow jobs. I don't have strong opinions.
@leodido wdyt?
Additional context

The first prow job was implemented, and it works!

Initial setup is done. :partying_face:
Ofc, further improvements can come later.


Semantic sil objc deallocator fixes

This fixes a few issues with emitting of deallocators/destroyers for objc. With this, the objc_dealloc test passes the ownership verifier.
rdar://33358110

@swift-ci smoke test and merge


PDF content is not shown, a message suggesting the usage of Adobe Reader is shown instead

Attach (recommended) or Link to PDF file here:
First PDF from #13143, 5e70058f-de74-4412-b7ec-0d02124fbd7f.pdf
Steps to reproduce the problem:

Open the PDF

What is the expected behavior?
See the actual contents of the PDF
What went wrong?
A message suggesting the usage of Adobe Reader is shown instead of the actual content

Duplicate of #4282


Sometimes when using sync_all structs get broken

Description
Happens in sync_all from user jeff on deenzone for DC Quals 2024. When you do syncall, sometimes you get a type or struct that looks like #47 a1.
Steps to reproduce the bug
No response
Environment
No response
Additional context
No response

If this is IDA related, when exporting your types make sure to use replace_ordinal_typerefs to convert from a numbered type to a named one.


Fix silent cache bugs in native flow

This PR fixes two bugs:

Fix a typo that is passing browserStorage instead of nativeStorage in RedirectClient for native flows.
Rewrite cache look ups based on cache optimization to perform correct look ups in silent cases.

Codecov Report

Merging #6067 (44e4fbc) into dev (81d34b4) will decrease coverage by 1.85%.
The diff coverage is 82.72%.

Flag
Coverage Δ

msal-angular
96.73% <96.63%> (+0.22%)
:arrow_up:

msal-browser
85.19% <87.13%> (-1.27%)
:arrow_down:

msal-common
83.21% <ø> (-1.33%)
:arrow_down:

msal-core
?

msal-node
79.98% <ø> (-3.41%)
:arrow_down:

msal-node-extensions
69.28% <59.25%> (-6.36%)
:arrow_down:

msal-react
94.24% <ø> (-0.45%)
:arrow_down:

node-token-validation
?

Impacted Files
Coverage Δ

...ions/msal-node-extensions/src/utils/Environment.ts
17.94% <0.00%> (-24.65%)
:arrow_down:

lib/msal-browser/src/cache/MemoryStorage.ts
100.00% <ø> (ø)

lib/msal-browser/src/crypto/CryptoOps.ts
93.54% <ø> (+1.88%)
:arrow_up:

lib/msal-browser/src/crypto/GuidGenerator.ts
100.00% <ø> (ø)

lib/msal-browser/src/crypto/ModernBrowserCrypto.ts
100.00% <ø> (+6.66%)
:arrow_up:

lib/msal-browser/src/crypto/MsBrowserCrypto.ts
9.75% <ø> (-13.17%)
:arrow_down:

lib/msal-browser/src/crypto/MsrBrowserCrypto.ts
33.33% <ø> (-31.38%)
:arrow_down:

lib/msal-browser/src/crypto/PkceGenerator.ts
89.47% <ø> (-5.99%)
:arrow_down:

lib/msal-browser/src/crypto/SignedHttpRequest.ts
92.30% <ø> (-1.81%)
:arrow_down:

lib/msal-browser/src/encode/Base64Decode.ts
93.75% <ø> (-0.99%)
:arrow_down:

... and 89 more

... and 145 files with indirect coverage changes


TEAMNADO-7508 - Link Sub-Inv Widgets to Product Table Filtering

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (5.0.5) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (5.0.5) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (5.0.5) is older than required version (6.0.0)


[Bug]  Cornerstone3D tools does not build with vite

Describe the Bug
I am currently using cornerstone3D in a react app. I get this error when running an npm run build during build:
Error: Could not load<EMAIL_ADDRESS>(imported by node_modules/@icr/polyseg-wasm/dist/index.js): "ESM integration proposal for Wasm" is not supported currently. Use vite-plugin-wasm or other community plugins to handle this. Alternatively, you can use `.wasm?init` or `.wasm?url`. See https://vitejs.dev/guide/features.html#webassembly for more details.
    at Object.load (file:///home/gideonp/ChRIS_ui/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:62695:19)
    at file:///home/gideonp/ChRIS_ui/node_modules/rollup/dist/es/shared/node-entry.js:18692:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///home/gideonp/ChRIS_ui/node_modules/rollup/dist/es/shared/node-entry.js:18592:28)
    at async file:///home/gideonp/ChRIS_ui/node_modules/rollup/dist/es/shared/node-entry.js:17762:33
    at async Queue.work (file:///home/gideonp/ChRIS_ui/node_modules/rollup/dist/es/shared/node-entry.js:18802:32)

I tried instaling vite-plugin-wasm with no luck. Anyone else seeing this error ?
Steps to Reproduce

Install Vite and the cornerstone3D tools
npm run build

The current behavior
N/A
The expected behavior
N/A
OS
Linux
Node version
Nodejs 20.7
Browser
Chrome

I'm @PintoGideon's coworker.
For anyone else here looking for a workaround, see https://github.com/FNNDSC/ChRIS_ui/pull/1060
UMD seems to be working but ESM (the default) does not. So create an alias in vite.config.ts to prefer the UMD build of @cornerstonejs/tools:
import { defineConfig } from "vite";

export default defineConfig({
  resolve: {
    alias: {
      "@cornerstonejs/tools": <EMAIL_ADDRESS>    },
  },
});

seems like someone tried this and works for now
alias: {
'@cornerstonejs/tools': <EMAIL_ADDRESS>}
}`

I know :( we will fix it in next version since it will be a breaking change

seems like someone tried this and works for now
alias: { '@cornerstonejs/tools': <EMAIL_ADDRESS>} }`

The code can be bundled, but it cannot run properly.

While the "alias" workaround fixes some issues the current version still cannot run on vitest for example and gives the following error:
Module node_modules/@cornerstonejs/core/src/index.ts:1 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "@cornerstonejs/core" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.

Are there plans for a proper fix?

<EMAIL_ADDRESS>is not packed to umd module and polyseg worker is not worked

Since there are many other people complaining about web workers and Vite as well, I'm adding this here.
https://github.com/vitejs/vite/issues/8427

I modified the registerPolySegWorker.js code:

can be build，
But there are still errors when starting in Nginx

I'm working on cornerstone3D 2.x and have made progress in removing circular dependencies and publishing the types for the DICOM image loader. I'm trying to make it work with Vite, but there are numerous issues with Vite in dev mode, which are not directly related to Cornerstone. Multiple mentions of Vite problems with import.meta.url, web workers, and WebAssembly can be found on the Vite GitHub repository:
https://github.com/vitejs/vite/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+import.meta.url
I have started a template project for Vite, React, and cornerstone3D beta 2.x here. I appreciate your help in making it work.
https://github.com/cornerstonejs/vite-react-cornerstone3d

seems like someone tried this and works for now
alias: { '@cornerstonejs/tools': <EMAIL_ADDRESS>} }`

@sedghi
There is no umd file in version 2 or above
How to solve it? （Vue+Vite）

Look at the dedicated vite configs https://www.cornerstonejs.org/docs/getting-started/vue-angular-react-etc


Collections conversion to normal or inline class

Description
Like discussed in the issue #97, we would like to convert the types in the kotools.types.collection package to a normal class (or an inline class if possible).

This is breaking change: the copy function will be unavailable after this migration.

Checklist

[ ] Migrate the NotEmptyList type.
[ ] Migrate the NotEmptySet type.
[ ] Migrate the NotEmptyMap type.
[ ] Test.
[ ] Refactor.
[ ] Check the generated documentation.
[ ] Check and update the public API binaries.
[ ] Update the Unreleased section in changelog.

We will migrate the NotEmptyList type in the issue #136.

We will migrate the NotEmptySet type in the issue #137.

We will migrate the NotEmptyMap type in the issue #138.


Merging in changes to prep for 1.0 release

To slim down on the merge to main, all feature/bug work was branched from release-prep and then merged back into it so that we would just have this one merge back into main.

One thing that wasn't addressed: this legend and arguably the pie chart title don't match the data. For example, I selected "Digital Device: Desktop/Laptop." The pie chart changed, as expected, but the legend still says "Internet Access / No Internet Access". I'll take a deeper look right now to see if I can find a solution.

One thing that wasn't addressed: this legend and arguably the pie chart title don't match the data. For example, I selected "Digital Device: Desktop/Laptop." The pie chart changed, as expected, but the legend still says "Internet Access / No Internet Access". I'll take a deeper look right now to see if I can find a solution.

OHHHHHH... as soon as I looked more deeply I saw the problem, and I recall commenting on it in the Jira ticket: we can't change magically change the visualization to refer to Digital Device. It really is hard-coded to "Access in Residence". Let me just think about improving the title on it.

One thing that wasn't addressed: this legend and arguably the pie chart title don't match the data. For example, I selected "Digital Device: Desktop/Laptop." The pie chart changed, as expected, but the legend still says "Internet Access / No Internet Access". I'll take a deeper look right now to see if I can find a solution.

OHHHHHH... as soon as I looked more deeply I saw the problem, and I recall commenting on it in the Jira ticket: we can't change magically change the visualization to refer to Digital Device. It really is hard-coded to "Access in Residence". Let me just think about improving the title on it.

Yup that was it. I was typing a response about this and then saw your own reply here. Changing the legend labels to be more clear is easy so if there are better names, we can make that change.


For instance x64 tests times look like:
[2022-06-27T18:39:00.952Z]   couch_db: is_owner_test...ok
[2022-06-27T18:39:00.952Z]   module 'couch_db_tests'
[2022-06-27T18:39:00.952Z]     Database create/delete tests
[2022-06-27T18:39:01.301Z]       couch_db_tests:93: should_create_db...[0.015 s] ok
[2022-06-27T18:39:01.301Z]       couch_db_tests:102: should_delete_db...[0.013 s] ok
[2022-06-27T18:39:01.301Z]       [done in 0.034 s]
[2022-06-27T18:39:01.301Z]     Multiple database create/delete tests
[2022-06-27T18:39:01.651Z]       couch_db_tests:112: should_create_multiple_dbs...[0.063 s] ok
[2022-06-27T18:39:01.651Z]       couch_db_tests:125: should_delete_multiple_dbs...[0.069 s] ok
[2022-06-27T18:39:01.651Z]       [done in 0.138 s]
[2022-06-27T18:39:01.651Z]     Continious database create/delete tests
[2022-06-27T18:39:02.001Z]       couch_db_tests:138: should_create_delete_database_continuously (10 times)...[0.116 s] ok
[2022-06-27T18:39:03.209Z]       couch_db_tests:138: should_create_delete_database_continuously (100 times)...[1.107 s] ok

(From https://ci-couchdb.apache.org/blue/rest/organizations/jenkins/pipelines/jenkins-cm1/pipelines/FullPlatformMatrix/branches/jenkins-bring-back-ppc64le/runs/2/nodes/218/log/?start=0)
And PowerPC ones are quite a bit slower
[2022-06-27T18:50:16.187Z] couch_db: is_owner_test...ok
[2022-06-27T18:50:16.187Z] module 'couch_db_tests'
[2022-06-27T18:50:16.187Z]   Database create/delete tests
[2022-06-27T18:50:18.270Z]     couch_db_tests:93: should_create_db...[1.548 s] ok
[2022-06-27T18:50:19.869Z]     couch_db_tests:102: should_delete_db...[1.461 s] ok
[2022-06-27T18:50:19.869Z]     [done in 3.016 s]
[2022-06-27T18:50:19.869Z]   Multiple database create/delete tests
[2022-06-27T18:50:25.216Z]     couch_db_tests:112: should_create_multiple_dbs...*timed out*
[2022-06-27T18:50:25.216Z]     undefined
[2022-06-27T18:50:30.124Z]   couch_db_tests:125: should_delete_multiple_dbs...*timed out*
[2022-06-27T18:50:30.124Z]   undefined
[2022-06-27T18:50:30.602Z] [done in 10.003 s]
[2022-06-27T18:50:30.602Z] Continious database create/delete tests
[2022-06-27T18:50:48.560Z] couch_db_tests:138: should_create_delete_database_continuously (10 times)...[15.361 s] ok
[2022-06-27T18:52:01.403Z] couch_db_tests:138: should_create_delete_database_continuously (100 times)...[73.174 s] ok
[2022-06-27T18:52:01.403Z] [done in 88.542 s]
[2022-06-27T18:52:01.403Z] Database open tests

(From https://ci-couchdb.apache.org/blue/rest/organizations/jenkins/pipelines/jenkins-cm1/pipelines/FullPlatformMatrix/branches/jenkins-bring-back-ppc64le/runs/2/nodes/72/log/?start=0)
should_create_delete_database_continuously (100 times) is about 73x slower and should_create_db at 1.548 vs 0.015 s which also 100x slower.
It could disk I/O or CPU throttling, haven't dove in to check yet, but I think will hold off enabling it for as it would make the full build flaky.

A new VM was built with an NVMe disk which fixed the problem, so it looks good to go.
Eunit tests runs in 15 vs 12 on other nodes but interestingly, elixir and other tests run a bit faster, even.


How to read a classification model to do classification

I am learning migraphx recently. But I do not know how to read a classification model(such as resnet50) to do classification  by using migraphx.At the same time,I also want to know how to use SSD detector by migraphx

Here's a simple example that shows how to classify an image, but the load_image function is not shown:
import numpy as np
import migraphx

# Load the resnet50 onnx file
model = migraphx.parse_onnx("resnet50.onnx")
# Compile the model for the gpu
model.compile(migraphx.get_target("gpu"))

# Load image as a numpy array
image = load_image()

# Run the model, and pass the image as parameter '0'
result = model.run({'0': migraphx.argument(image)})

# Convert to numpy array
npresult = np.array(model.run(params), copy=False)

# Image classification index
idx = np.argmax(npresult[0])

Here is an end-to-end example of classifying images with a webcam. This requires python-opencv and a json file for the labels:
import numpy as np
import cv2
import json
import migraphx

# video settings
cap = cv2.VideoCapture(0)
cap.set(cv2.cv.CV_CAP_PROP_FRAME_WIDTH, 320)
cap.set(cv2.cv.CV_CAP_PROP_FRAME_HEIGHT, 240)
ret, frame = cap.read()

# neural network settings
model = migraphx.parse_onnx("resnet50.onnx")
model.compile(migraphx.get_target("gpu"))

# get labels
with open('imagenet_class_index.json') as json_data:
    class_idx = json.load(json_data)
    idx2label = [class_idx[str(k)][1] for k in range(len(class_idx))]

# primary loop to read webcam images
count = 0
while (True):
    # capture frame by frame
    ret, frame = cap.read()

    if ret: # check - some webcams need warmup operations on the frame
        cropped = frame[16:304,8:232]    # 224x224

        trans = cropped.transpose(2,0,1) # convert HWC to CHW

        # convert to float, normalize and make batch size = 1
        image = np.ascontiguousarray(
            np.expand_dims(trans.astype('float32')/256.0,0))

        # display the frame
        cv2.imshow('frame',cropped)

        params['0'] = migraphx.argument(image)

        result = np.array(model.run(params),copy=False)

        idx = np.argmax(result[0])

        print idx2label[idx], " ", result[0][idx]

    if cv2.waitKey(1) & 0xFF == ord('q'):
        break

# when everything is done, release the capture
cap.release()
cv2.destroyAllWindows()

Here's a simple example that shows how to classify an image, but the load_image function is not shown:
import numpy as np
import migraphx

# Load the resnet50 onnx file
model = migraphx.parse_onnx("resnet50.onnx")
# Compile the model for the gpu
model.compile(migraphx.get_target("gpu"))

# Load image as a numpy array
image = load_image()

# Run the model, and pass the image as parameter '0'
result = model.run({'0': migraphx.argument(image)})

# Convert to numpy array
npresult = np.array(model.run(params), copy=False)

# Image classification index
idx = np.argmax(npresult[0])

Here is an end-to-end example of classifying images with a webcam. This requires python-opencv and a json file for the labels:
import numpy as np
import cv2
import json
import migraphx

# video settings
cap = cv2.VideoCapture(0)
cap.set(cv2.cv.CV_CAP_PROP_FRAME_WIDTH, 320)
cap.set(cv2.cv.CV_CAP_PROP_FRAME_HEIGHT, 240)
ret, frame = cap.read()

# neural network settings
model = migraphx.parse_onnx("resnet50.onnx")
model.compile(migraphx.get_target("gpu"))

# get labels
with open('imagenet_class_index.json') as json_data:
    class_idx = json.load(json_data)
    idx2label = [class_idx[str(k)][1] for k in range(len(class_idx))]

# primary loop to read webcam images
count = 0
while (True):
    # capture frame by frame
    ret, frame = cap.read()

    if ret: # check - some webcams need warmup operations on the frame
        cropped = frame[16:304,8:232]    # 224x224

        trans = cropped.transpose(2,0,1) # convert HWC to CHW

        # convert to float, normalize and make batch size = 1
        image = np.ascontiguousarray(
            np.expand_dims(trans.astype('float32')/256.0,0))

        # display the frame
        cv2.imshow('frame',cropped)

        params['0'] = migraphx.argument(image)

        result = np.array(model.run(params),copy=False)

        idx = np.argmax(result[0])

        print idx2label[idx], " ", result[0][idx]

    if cv2.waitKey(1) & 0xFF == ord('q'):
        break

# when everything is done, release the capture
cap.release()
cv2.destroyAllWindows()

Do you know how to use SSD detector by migraphx?

@qianqing13579 do you have a specific SSD model you are testing?

Here is the link: https://github.com/qianqing13579/SafetyHelmet/tree/master/Resource/Models/Detector. It is a caffemodel

Here is the link: https://github.com/qianqing13579/SafetyHelmet/tree/master/Resource/Models/Detector. It is a caffemodel

MIGraphX currently does not support caffe models. Can you try converting to onnx? Depending on the SSD model implementation, MIGraphX may be able to support it.

Here is the link: https://github.com/qianqing13579/SafetyHelmet/tree/master/Resource/Models/Detector. It is a caffemodel

MIGraphX currently does not support caffe models. Can you try converting to onnx? Depending on the SSD model implementation, MIGraphX may be able to support it.

Here is the link: https://github.com/qianqing13579/MIGraphX_SSD_Model

Here is the link: https://github.com/qianqing13579/SafetyHelmet/tree/master/Resource/Models/Detector. It is a caffemodel

MIGraphX currently does not support caffe models. Can you try converting to onnx? Depending on the SSD model implementation, MIGraphX may be able to support it.

Here is the link: https://github.com/qianqing13579/MIGraphX_SSD_Model. I do not know how to use this SSD model by MIGraphX

There are onnx operators in this model that MIGraphX doesn't support natively. We have opened issues (#611, #612) to track their development. Once complete, we can provide additional support to help run this model using MIGraphX.

@qianqing13579 Can you reopen the link then we can access the model? Looks like the above link is invalid now.

@kahmed10 ,I have developed the SSD detector inference code by MIGraphX. Here is the link:https://github.com/qianqing13579/MIGraphX_Samples. Recently I have been developing the YOLOV3  inference code.


[Question] - Migration from Resolver

Hi Michael,
great to see another dependency injection library from you. I am a long time Resolver user and now questioning myself if it is possible to migrate from Resolver to Factory and how. I hope it is fine to ask some question about this in this format.
Currently Resolver is used in a MicroFeature architecture. So I have a lot of distinct features, all with an interface target and an implementation target. These features then are getting packed together in the final application target.
Each feature implementation only knows the interface of other features AND the Resolver framework. The application target in the end knows each features interface and each features implementation and registers appropriate implementations to the interfaces for other features to consume.
Some Code examples below.
Feature A
// FeatureA interface

protocol FeatureAInterface {
    func fetchResourceA() async -> ResourceA
}

// FeatureA implementation

protocol FeatureAImplementation: FeatureAInterface {
    func fetchResourceA() async -> ResourceA {
        return ResourceA()
    }
}

Feature B
// FeatureB interface

protocol FeatureBInterface {
    func fetchResourceB() async -> ResourceB
}

// FeatureB implementation

final class FeatureBImplementation: FeatureBInterface {

    @Injected private var featureA: FeatureAInterface

    func fetchResourceB() async -> ResourceA {
        let a = await featureA.fetchResourceA()
        return ResourceB()
    }
}

App
import FeatureA
import FeatureAInterface

import FeatureB
import FeatureBInterface

register { FeatureAImplementation() }
    .implements(FeatureAInterface.self)

register { FeatureBImplementation() }
    .implements(FeatureBInterface.self)

When I now look at Factory I saw that it is now required to create an extension on Container to make services explicitly type safe available to consumers. Maybe I misunderstood the new library a little bit, but do you have some suggestion of how the behaviour I described will be working with Factory ? What I want to avoid is to expose the implementation of features to other features. Exposing implementations inside the place where everything is registered is fine though.
Maybe another question - will it also be possible to have a @OptionalInjected functionality again ? Maybe I oversaw it.
Thanks a lot in advance, and again thanks a lot for all your work so far !

That one's tough.
What you're currently doing is what Resolver does. Basically the code is hoping that someone, somewhere, has registered a factory to provide an instance of the needed interface.
Factory, on the other hand, works by ensuring that there's an implementation to be seen, hence it's compile-time safe. It doesn't hope. It knows.
I'll have to think about that one a bit.

Thanks a lot for thinking about it. I was also wondering if the approach described by me will even be possible with Factory. Because it is exactly what you said.
The features just rely on, that there will be some implementation conforming to the given protocol. They have no guarantee however and the application will crash if a developer has forgotten to add a certain dependency.

Still thinking, but one option might be something like this...
protocol FeatureAInterface {
    ...
}
extension Container {
    static var featureA = Factory<FeatureAInterface?> { nil }
}

Which allows...
import FeatureA
...
class FeatureBImplementation: FeatureBInterface {
    private var featureA = Container.featureA()
    func fetchResourceB() async -> ResourceB {
        let _ = await featureA?.fetchResourceA()
        return ResourceB()
    }
}

Then at app launch you call setup...
func setup() {
    Container.featureA.register { FeatureAImplementation() }
    Container.featureB.register { FeatureBImplementation() }
}

Each interface publishes an optional Factory that returns nil so it doesn't expose implementation. Anyone who uses it has to handle optional aspect, but no crash if not provided. Setup function on app registers implementations and wires the world together, much as you did before.

Oh, and note

class FeatureBImplementation: FeatureBInterface {

   @Injected(Container.featureA) private var featureA

    func fetchResourceB() async -> ResourceB {
        let _ = await featureA?.fetchResourceA()
        return ResourceB()
    }
}

If the type of the factory is optional, then the type @Injected is optional. No need for OptionalInjected.

Very interesting, thanks a lot for providing the suggestions. This means, that, in the context of the example: FeatureB then needs to validate that necessary injected types are not nil, right ? So basically what previously was done by Resolver internally, now needs to be done by the different Feature implementations.
So the general idea high level idea would be:
In the Interface we provide a "cutout" for the injected service, but set it to nil. Inside the app we fill it out with the correct implementation.
I need to think a little bit about it - I quite liked this "dynamic" approach of Resolver - or better said, the "implicit unwrapped optional" approach. But with your suggestions, I think, I could atleast keep the base functionality.
Also very nice, that @OptionalInjected is not needed any longer :)

But I think compile time safety is definitely a very nice approach ! Great to see this improvement :) So really good work.

I mean, there's nothing stopping you from explicitly unwrapping it on your own...
class FeatureBImplementation: FeatureBInterface {

    @Injected(Container.featureA) private var featureA: FeatureAInterface!

    func fetchResourceB() async -> ResourceB {
        let _ = await featureA.fetchResourceA()
        return ResourceB()
    }
}

Other than losing the main benefit of Factory, this is. ;)
I'll still noodle on this. Let me know if you come up with something.

Another conversation on this is occurring in issue 3.

@hmlongco Thanks a lot for linking the other issue !


Add toggle component

Feature/component description
We would like to have a toggle component.
Use case
In some cases it makes more sense to use toggle and not checkbox, since the user expect immediate reaction.

Switch looks like it would be the relevant base here.

After some discussion we've decided to stick with only checkboxes for now to maintain alignment with VS Code core.


Mismatch in logmap representation of SE(2) states

AIKIDO assumes [\theta, x, y] while DART assumes [x, y, theta]. Everytime the the skeleton is set to a position the coordinates are set incorrectly.
One clean solution would be to have the state representation to be equivalent to that of DART, OMPL:
[x, y, theta].
Is there any particular reason we chose this representation?

The general convention in DART is that angular terms come first followed by linear term like FreeJoint. PlanarJoint (SE(2) joint) complied the rule when it's created, and then for some reason "I" changed the order, which I don't remember the reason. :disappointed:
I personally prefer angular term first, but this is just a matter of convention. So I'm open to follow DART's convention or OMPL's as long as we're consistent.

We do not have to follow OMPL's convention since we never use their states anyway. It'd be better to stick to DART's convention IMO. I personally prefer angle at the end haha! Can we change it in DART then?


Add OPDB OpenType feature to all fonts

Most Latin fonts don't include a OPBD OpenType feature, which means they are left aligned by bounding box, so when you have a title with a left flat side on the first glyph, it appears indented. Eg,

Banana
wrap

So, lets write a script to add a OPBD feature to all the fonts that solves this.

This might be a good idea - but it's out of scope for fontbakery!

@behdad could you shed more light on this? :)

FWIW HarfBuzz now has API for this (hb_ot_layout_lookup_get_optical_bound). But no client uses it as far as I know. Might be wrong. @matthiasclasen

Are there any example fonts which have opbd?
I have only found examples of lfbd and rtbd.
EB Garamond 12 (2014) has lfbd and rtbd.
Linux Libertine (incl. with LibreOffice) has lfbd and rtbd.
Catalyst (commercial) has lfbd and rtbd.
And I have tested these.
LibreOffice supports lfbd and rtbd.
Have not tested opbd (no font), but I assume if HarfBuzz supports it that it is supported.
Update: Tested opbd with Adam Twardoch's Nadyezhda SL One font (for testing OpenType features support) - and it shows it is supported in LibreOffice
Affinity Publisher supports lfbd and rtbd, and not opbd.
Their comment was basically why bother with opbd if you have lfbd and rtbd.
So at least two fairly prominent applications support it.

@khaledhosny for LibreOffice status.

I’m not aware of any special handling of these features in LibreOffice. It might appear to work if affected punctuation occur only at line edges.


Provide indexed search integration with ElastiSearch for geo points within a circle

ElastiSearch provides support to perform an indexed search for elements that are located within a given radius of a geo-point.
Since this is already built into ElastiSearch, please provide support within Titan to search (using an index) for vertices having a geo-point property that are within a given radius of a geo-point.   Currently (according to the Titan documentation) one can only use an index to search for a given geo-point.
Reference: (http://www.elasticsearch.org/blog/geo-location-and-search/)
https://github.com/thinkaurelius/titan/wiki/Using-Elastic-Search
Would defining new Titan datatype called "geo-point" or "geoPoint" facilitate this integration?

As far as I can tell this is supported (0.9-M1)
You can do something like
graph.V().has("location", Geo.WITHIN, Geoshape.circle(0.1, 0.1, 16)).next()

You need to make sure you use a mixed index
TitanManagement mng = graph.openManagement();
PropertyKey location = mng.makePropertyKey("location").dataType(Geoshape.class).make();
mng.buildIndex("byLocation",Vertex.class).addKey(location).buildMixedIndex("search");
mng.commit();

Please open if you still think there is an issue.


CLI should install package controller with namespace

Currently, the helm chart creates the namespace and this is potentially fragile, the helm command in the CLI should be passed the namespace and create if needed

Done


(SERVER-1131) Throw a better error message for commands with arguments

Previously if a command with arguments were passed to
shell-utils/execute-command, it would throw an error about
'/usr/bin/echo foo' command does not exist. This commit updates the
validation to throw an error if the command does not exist, but the
first part when split on a space does exist.

:+1:

I think once this is merged, I or someone could add something to validate-config! in versioned-code-service to make sure that the settings for vcs are valid commands and fail if not.

:+1:


Achievements page improvements based on uat

Description
As title
Type of change

[ ] Bug fix
[x] New feature
[x] Refactoring
[ ] Documentation
[ ] Improvement

Solution description

Replace the triple-dot with hovering to show the edit and delete button
New functionality for multi-select to delete
Add a success toast message when successfully create/edit/delete team members (consistency)
Dropdown to select year when creating achievements to make it consistent with the publications page
Make the achievement form validation consistent with the backend

Tests
All unit tests pass? N/A
Builds successfully? Yes
Do all SA checks pass? Yes
Attach screenshot of the expected result (e.g. UI of the website/ postman api call result/ database changes)

Relevant document/ link (if any)
https://trello.com/c/0bo1eVyz/176-achievements-page-improvements-based-on-uat
Risk
Low for UI modification, Medium for the implemented rest api

Personal opinion:  I wonder if it was just me, or De-Select All is kinda confusing for me 😆, like a double negative thing. For example, a tick beside De-Select All as in the picture for me is like de-select-all = TRUE which means select-all = FALSE
But LGTM overall!

+1, seems like this should be a usability anti pattern, but ig it’s fine for now

Personal opinion:  I wonder if it was just me, or De-Select All is kinda confusing for me 😆, like a double negative thing. For example, a tick beside De-Select All as in the picture for me is like de-select-all = TRUE which means select-all = FALSE
But LGTM overall!

Make sense! Fixed


[Bug]: VS Code Server Websocket

Is there an existing issue for this?

[X] I have searched the existing issues

Example public repository
coolify
Description
Websocket are not enabled so HMR with Next.js does not work
Steps To Reproduce

Install VS Code Server
In VS Code Server, init a node.js server like next.js : npx create-nextapp
Run that server : cd myapp; npm run dev
Visit the url : <VSCODE_SERVER_URL>/proxy/3000
Edit index.jsx
Page should change thanks to HMR through Websockets

Version
2.5.2

in fact, it's because VSCode server uses a /proxy/<port> URL but not Next.js


manga doesn't update in the update section

Steps to reproduce
when i go to the updates section and refresh the manga page
it only updates like 10 of my manga
and i have to update the others manually by refreshing them
Expected behavior
when i go to the updates section and refresh the manga page, all the manga in my library should update
Actual behavior
https://user-images.githubusercontent.com/112913777/188529462-f7c64a9f-f7d2-4a53-a855-1c0ea9d312ff.mp4
Crash logs
No response
Aniyomi version
App version: <IP_ADDRESS> (standard, dc8d1af, 72, 2022-08-25T23:30Z) Android version: 10 (SDK 29) Android build ID: MAR-L21MEB <IP_ADDRESS>3(C185E3R3P1) Device brand: HUAWEI Device manufacturer: HUAWEI Device name: HWMAR Device model: MAR-LX1A Device product name: MAR-LX1A
Android version
Android version: 10 (SDK 29)
Device
Android build ID: MAR-L21MEB <IP_ADDRESS>3(C185E3R3P1) Device brand: HUAWEI Device manufacturer: HUAWEI Device name: HWMAR Device model: MAR-LX1A Device
Other details
Anime updates normally
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Ooh, that's because the other mangas that's on your library are unread. It will only update the mangas that you've completed reading all the recent chapters, otherwise you need to manually update it. Idk why but that's how it is.

Try turning off your smart update in the settings


Safe_Landing_Planner explanation

Hi everyone, my name is Rynaldi Maydrian Lauren. I am interested in the safe_landing_planner package from this px4 avoidance page. Is there any explanation on how the program or code actually works? Because I can see that there are explanations for the global_planner and local_planner packages, but not for the safe_landing_planner.
Thank you very much.

Hi @rynaldi95 , no there isn't any document detailing the algorithm. You can find an high level overview of what the planner does scattered across the readme


Focus on second dose instead of first dose

Currently, the design of the pass in Apple Wallet seemed to "focus" on the first dose of vaccine (with the larger font size on the name of the vaccine the user get). To my understanding, the inequal font size is a result of the limitations on the pass's layout.
In such a case, is it more intuitive to focus on the second dose since it means a single person is fully vaccinated, and is certified for a vaccination certificate?

You're correct to intuit that the pass layout forces font sizes. To my knowledge it also forces the first one ("secondary field") to be larger than the second one ("auxiliary field"), so the only way to achieve that effect would be to list the doses in reverse chronological order (dose 2 on top). I'm afraid of straying too far from the original format. Thoughts?
https://github.com/scomma/vaxwallet/blob/d91b4877016655d74e773e573976a861978788a8/functions/index.js#L59-L60

From my perspective, if the pass clearly indicates the arrangement of the dose, then I don't have any kind of problems, chronologically reversed ordering is not something uncommon (social media feed for example).
But I forgot to take the original vaccination certificate's design into consideration, thus I would say I could not give any constructive feedbacks or comments when considering such a limitation.

Ok, I'll leave this issue open for while in case anyone wants to pile on. In the meantime since we're not importing directly from MOPH API (yet), anyone who prefers reverse chronology is free to swap their first/second dose data in the interface.

I tried the reversed chronological order with some text added to clarify the ordering. Interestingly, it appears that the text in both fields shrinks in font size to fit a longer line length to the screen size.
Not sure if we can apply whitespace hacks to make the size of the two lines as close as possible.


Determine if it's possible to support transactions without savepoints

Some discussion at https://code.djangoproject.com/ticket/28263.
Possibly cockroach will add support for savepoints which may obsolete this issue...
https://github.com/cockroachdb/cockroach/issues/10735

Some work at https://github.com/cockroachdb/cockroach-django/pull/40#issuecomment-544541585.

Addressed by https://github.com/cockroachdb/cockroach-django/pull/79.


[Deserialization] Output a diagnostic for invalid decls or types

47b068d4453776cd0feba754a4e41c416039ea26 output a diagnostic if a
deserialized decl was invalid (checking Decl::isInvalid). It had two
major issues:

It incorrectly output diagnostics for valid modules
It did not catch call invalid declarations

(1) is caused by isInvalid falling back to checking the storage for
accessors when the interface type hasn't already been computed (a
fallback to prevent a cycle due to SimpleDidSetRequest typechecking
the body). Since the VarDecl hasn't finished deserializing, it returns
true for its isInvalid check (even though it would later return
false).
For (2), only ValueDecls would ever be invalid, since other
declarations use a bit in Decl to check for validity. As that's not
serialized, those would always be valid in deserialization.
To avoid both these issues, instead output a flag for each declaration
representing whether it is invalid (or not). Read that during
deserialization and output a diagnostic if it is invalid. To be extra
sure that a diagnostic is always output on an error, also output one
when deserializing any ErrorType. This ensures that SILGen does not
run when allowing errors (and an error is present), as it is likely to
crash when presented with an invalid AST.
Resolves rdar://74541834

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 1d51dc5cc3f82f305b075e72175746f86a5d9aba

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 62f3b8d93aebe639192c09f1004c2e393651c7cf

@swift-ci please test macOS platform

@swift-ci please test Windows platform

@swift-ci please test Windows platform

Build failed
Swift Test OS X Platform
Git Sha - 62f3b8d93aebe639192c09f1004c2e393651c7cf

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 59d4b7422965bed95144656557759736d22e7701

@swift-ci please clean test Linux platform

@swift-ci please smoke test

@swift-ci please test source compatibility release


Error from server (BadRequest): a container name must be specified for pod istio-telemetry-78c647b78c-zp5gs, choose one of: [mixer istio-proxy]

Describe the feature request
Use helm to deploy this error in the version of isti 1.1.1
kubectl logs -f istio-telemetry-78c647b78c-zp5gs -n istio-system
Error from server (BadRequest): a container name must be specified for pod istio-telemetry-78c647b78c-zp5gs, choose one of: [mixer istio-proxy]
Describe alternatives you've considered
nothing
Additional context
no

The istio-telemetry pod has two containers - mixer and istio-proxy. Because of this, you need to specify which one you want to pull the logs from.
You have three options:

kubectl logs -f istio-telemetry-78c647b78c-zp5gs -n istio-system -c istio-proxy to get proxy logs
kubectl logs -f istio-telemetry-78c647b78c-zp5gs -n istio-system -c mixer to get telemetry logs
kubectl logs -f istio-telemetry-78c647b78c-zp5gs -n istio-system --all-containers to get all logs

This is all Kubernetes by the way, and happens any time you have two containers in a pod, unrelated to Istio.
Feel free to reopen this if that does not solve your problem.


Rename OrgRule* to "IamRule*"

This is the first step in trying to make the "Rules Engine" modular. The current OrgRulesEngine is actually specifically for IAM rules. Thus, the module name and class name should reflect that.

Coverage remained the same at 82.4% when pulling e9925ef36d4988896c9941fcbabfa842b4a0a248 on refactor-rules-class into 7c4b8b53d206c4a4348146705f7045b1d84a7ee7 on master.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Invalidation mechanism

Hi,
I am using CAAT (canvas implementation) on several platforms, including mobile devices.
This is a really great framework :)
I just have a question.
On desktop, clearing the whole canvas has no real impact on small canvases, but on mobile this is really a performance bottleneck.
I would like to know if a kind of invalidation mechanism is planned for CAAT, in order to clear only areas that have to be redrawn (based on actor dirtiness).
Thanks a lot !

Just for info, a little jsfiddle : http://jsfiddle.net/mgbUc/6/.
I have different results, very surprising results ...

iPhone 4 / iOS 5.0.1 : same results.
iPhone 4, iPad 1, iPad 2 / iOS 4.2.1 : 4 times faster with invalidation.
Samsung Teos / Android 2.1 : 10 times faster without invalidation Oo
Samsung Galaxy Note / Android 2.3.6 : same results.

Of course this is a a very basic example, there is no clipping algorithm, and just one square moving ^^ ...
Clear operation is meant to be quite expensive on not accelerated device, but apparently some progress have been done in recent versions of iOS / Android.
I would like to test a very basic invalidation algorithm with CAAT to ... invalidate ^^ or validate if it can be useful or not.
Can you tell me how to you build CAAT ? And where do you think is the best place to put this code ?
Thanks a lot :)

Hey there,
I've made some code changes regarding coordinate clamping from float to integer. You should notice a performance improvement while in mobile canvas. Could you confirm it ?
Despite I think in most situations is not worth it, I'm taking seriously the possibility of setting a dirty rectangle redraw mechanism which should be explicitly allowed by the developer. Unfortunately, I can't tell when.
Thanks,
-ibon

Yeah that's a very cool improvement ;)
I think this will improve performances on non-hardware accelerated devices (every mobile devices indeed).
I will update CAAT and report any changes in perfs.
The solution of giving the programmer the ability to specify a list of dirty rectangles and apply it, is a great compromise.
Anyone could adapt his own invalidation mechanism following his needs.
My test results are very strange, I would like to know if I get the same results in a much more complex scene using CAAT.
So, this update will be very interesting for me ;)
Thanks a lot.


Updating deployment.yaml with entry point binary and version number

Hi @cshivashankar. Thanks for your PR.
I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


Questions re html layout, classes, etc.

  Helping a golf fanatic (watching Masters) with taxes.  I keep looking for YARD info in yard-js...
Anyway, wondering about some things in the YARD html.  I'm more or less done with the code for yard-t2, and I was looking at changes to make the 'content to markup' ratio a little higher, but it may involve code outside the 'template system.'  Also, you're probably a lot more familiar with what people have done as far as other templates / plugins, and their assumptions about markup.
Hence, would pull requests for the following be okay (don't have the code done yet)?

Summary Section(s) Items - Many of the li elements have a class 'public'.  Can't find that word anywhere in the css or script files.  See templates/default/module/html/item_summary.erb, line 1.

Anchors - many are surrounded by a span element with a class of 'object_link'.  css and script files have the class in them, but it is always in a selector paired with a, like '.object_link a'.  Hence, could the element be removed?  See YARD::Templates::Helpers::HtmlHelper#link_object, line 278.

There's more, thought I'd just start with two.  Having spent a bit of time with a 'Method List' of 20k items (AWS Ruby SDK), anything to remove elements, classes, etc helps with both rendering time and retrieval time.
Thanks,
Greg

Summary Section(s) Items - Many of the li elements have a class 'public'. Can't find that word anywhere in the css or script files. See templates/default/module/html/item_summary.erb, line 1.

The visibility of an object is passed into the className of each li element and other locations for styling. It might not be used in the default template, but the idea is that you could customize YARD's template/stylesheets to style based on object visibility-- like, for example, organizing all public/protected/private methods into separate searchable lists, or creating a custom toggle button that shows/hides objects of a given visibility. This information is in the template for semantics, basically.

Anchors - many are surrounded by a span element with a class of 'object_link'. css and script files have the class in them, but it is always in a selector paired with a, like '.object_link a'. Hence, could the element be removed? See YARD::Templates::Helpers::HtmlHelper#link_object, line 278.

While technically it could, this would be a breaking change to the templates with a pretty wide blast radius, and I would be concerned about such a change.

There's more, thought I'd just start with two.

In general I would recommend creating incremental PRs with individual suggestions, see below for why. Note that backwards compatibility will always be a concern-- if the change knowingly affects a large set of users, I'm unlikely to accept it unless the benefits strongly outweigh the breakage (like, say, a significant performance boost).

Having spent a bit of time with a 'Method List' of 20k items (AWS Ruby SDK), anything to remove elements, classes, etc helps with both rendering time and retrieval time.

If you can show (in each PR) the actual rendering time improvements per element/class removal, we can look at optimizing based on actual results. My hypothesis is that the extra classes and elements don't provide significant overhead in the general case, but if you can show examples of page elements that contribute to render time disproportionately, we can fix those on a case-by-case basis.

'pretty wide blast radius' - didn't know you could search GitHub like that.  Thanks.
Seems most of those are from a couple of gems, but thread_safe's had 40M downloads.  The change wouldn't break any code, just styling.  But it would break/change.
Understand compatibility issues.  In yard-t2 I'll add visibility as a data- attribute, so available in code, but not css.
As you know, re rendering time, for many 'normal' modules/classes, it's a matter of one blink of the eye or two.  I was looking at the AWS JS 'class' EC2 that's about 2 meg in size (as html), with a lot of methods.  Not a normal use case.  Like so big that the browser chokes on list resizing because of all the reflow in the main doc. And that's a PC, haven't tried it on a tablet...
Re PR's, going forward, I'll never submit one without discussion.
Thanks for the reply.

I was looking at the AWS JS 'class' EC2 that's about 2 meg in size (as html), with a lot of methods.

I understand the edge cases-- I guess my point is: does removing a single element, like the object_link span, reduce the render time that significantly on such a page? Or, perhaps in the same line of questioning: are there equivalent optimizations that could be applied that have the same goal but without changing structure? For example, if reducing file size does indeed have a significant impact, then there are better ways to do this-- removing extraneous whitespace would be one.

does removing a single element, like the object_link span, reduce the render time that significantly on such a page?

I doubt it with just one, but for instance the default/docstring/html/index.erb template is two nested divs, both with classes --

    <%= yieldall %>

I doubt one change would make a difference, but several together might, with an emphasis on 'might'.  And maybe only for edge cases where there's a lot of methods/properties, etc.
I've worked with the extraneous whitespace issue before; tricky when white space is part of the content in pre/code elements, even worse when they're highlighted.  Obviously, can't do it globally.  Have you dealt with it before, or, any suggestions as to how best to implement?
I reduced the element count in my lists, and it did make a rendering difference, but was only apparent with large lists, like AWS or Rails.
Lastly, re operations that globally hide/show elements, tonite I just changed the last remaining ones from using style.display to css, and some operations were twice as fast.  Then again, one blink vs two.  Haven't uploaded to GitHub.io yet.
Never asked, what do you think of using XHR in YARD?

Never asked, what do you think of using XHR in YARD?

I've looked into it before. I wanted to create a modern template based on Angular/Ember/etc for a long time, but the lack of statically rendered content has historically made it a non-starter for SEO and such. Admittedly, I don't know what advancement these frameworks / search engines have made in the last little while, but server-side rendering is simply not feasible for this project, at least not in the default template.
Assuming these constraints are blocking, I wouldn't be opposed to a separate template with a more modern XHR style approach-- it would work very well for local docs or coupled with the YARD server.
Exporting the Registry to a json file, or set of json files, would be the first step to making that happen. I've also experimented with doing this before, and that's a whole other technical challenge.

When I mentioned XHR, I didn't really mean JSON or data oriented XHR.
What I did with yard-t2 was use XHR for the following:

Once a YARD doc is loaded, all script & css are in the shell, and aren't loaded again
Lists (and search results) remain when new docs are loaded.
When loading another doc, the XHR removes everything but the body element, then pulls out the content and the 'menu', processes them, then adds to the DOM.
Content added to the main doc via script is added before the doc content is added to the DOM.
List search data is gathered before the list info is added to the DOM.

I've updated a lot of things in the script since I sent you the link a while ago, much from working with the edge cases like Rails and AWS Ruby / JS.  Got a lot better with Chrome timeline...
It works with both YARD server & YARD doc.
I've changed a lot of things, so it will break other plugins, but it was relatively easy to get it working with AWS.
That link again --
http://msp-greg.github.io/
Also, note the app.js library, which is the script file, doc'd with yard-js, but I used a different JS parser (RKelly).

I'm closing out old issues. It doesn't seem like there are any other action items / open questions here. Feel free to re-open if I hadn't responded to something. The work on yard-t2 certainly looking interesting.

I think we're fine.  Thanks for the help.  Very recently I uploaded new libraries to GitHub.io, four versions of Ruby and two versions of Rails.  If you get a minute, have a look; I did a few things to the C parser, changed the summary method signatures to pick up overload info, etc.
I've been trying to think of what things I've changed that might be added back into YARD, but a lot of it is integrated with other changes I've made.  I've also changed many of the ERB templates to make use of the '-' option...
I'm looking at the AWS-SDK now, trying to see how they have so many method duplicates, etc
Greg


Linearzoom false option not behaving as expected

Subject of the issue
If I set the linearZoom to false as below, the zooming still behaves linearly (is becomes progressively slower once you get to beyond a zoom of 1.5 or 2).
$("#rec2").panzoom({
linearZoom: false,
panOnlyWhenZoomed: false,
maxScale: 8,
contain: false
});
Your environment

version of jquery.panzoom
v3.2.2
version of jquery
3.1 (http://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js)
which browser and its version
Safari on iPhone 5 (iOS 9.3.5)

Steps to reproduce
Tell us how to reproduce this issue.
Working demo: http://www.ancestryux.net/demo/rd/home-brim.html

Swipe up to activate full screen mode and trigger panzoom.
Pinch zoom

Expected behaviour
Expect the zooming to roughly track directly to where the users fingers are pointing on the image being zoomed while pinching out and in.
Actual behaviour
Zooming slows as you scale the image up, so the fingers start slipping on the image.
Kudos
This is a fantastic plug-in. I love it! Thanks for all of your hard work and diligence in making it come to life. It works like a dream. Super-responsive and just what I needed to get my project up and going. You are totally awesome!!

Thanks for opening an issue! It's hard to tell what's going on in the demo, or what to focus on in the code. Perhaps you could create a reduced test case on jsbin.com.
Keep in mind that calculating zoom in a non-linear fashion does not guarantee that zooming will not seem to slow down at points. The default setting is false, which guarantees that the zoom will increment by larger values, but that still may not be large enough in your case. The increment option is also there to increase the increments.
I'll close this issue for now because it's been a while and the action item is unclear. I will reopen pending further investigation. Thanks!


Can't join on 1.17.1 with Panilla installed

When i try to join the server with 1.17.1 installed i will get kicked  with this error
Internal Exception: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.util.List (java.lang.Integer and java.util.List are in module java.base of loader 'bootstrap')

Fixed with the latest commit. I pushed an update on SpigotMC


LIB-293 modify closed attribute in message entity to boolean

Modified the closed attribute in Message entity data type from integer to boolean

Test Evidence

[closed-true.txt](https://github.com/AngKokLeong/LibraryPortalBackend/files/12846611/closed-true.txt)

[closed-false.txt](https://github.com/AngKokLeong/LibraryPortalBackend/files/12846612/closed-false.txt)


Focus in tvOS app

fixed #261

Coverage remained the same at 94.597% when pulling bf5f1781ec7375c743a309b50425c5d369923957 on shuhrat10:master into 1c44991e62b772e046b07cd6ff32eb9fd94b01b7 on Instagram:master.

Thanks @shuhrat10 ! 🎉
Looks good to me, but I don't know tvOS very well.
cc @Sherlouk

@jessesquires Never done tvOS before this either haha, was very pleased to get it working as far as it did but if this makes it better then great!


List of Compiler errors and warnings

We should have a page listing every possible compiler error and warning so it is the first result hit in a search.
The page could have an explanation of the error and ways to fix it, ie:

http://chessboardjs.com/docs#errors:1001
http://autocompletejs.com/docs#errors:1002

related: https://github.com/oakmac/cljsbuild-ui/issues/3

This should be added to: https://github.com/cljsinfo/cljs-api-docs
So that we simply pull it into the application with a central place for managing docs.

Not a bad idea.  I suppose we could use a error/<id> and warning/<id> taxonomy in cljs-api-docs.  Warnings will be pleasant to parse and version since they're in one place.  Errors are just every possible exception in the cljs compiler, library, tools.reader, and clojure core.  That won't benefit from any parsing and will just have to be manual.


Make it possible to upgrade a lock for destruction without holding it.

The ability to upgrade for destruction without holding the lock is useful for cleaning up from the error handler.
Add various tests to detect regressions in the unlock function.

I think this looks good.  I wonder if it would be sensible to add a force parameter to the upgrade function.  Any graceful destruction should involve an upgrade from an owned lock, it's only destruction from an error handler that should require upgrading a non-owned lock.

I think this looks good. I wonder if it would be sensible to add a force parameter to the upgrade function. Any graceful destruction should involve an upgrade from an owned lock, it's only destruction from an error handler that should require upgrading a non-owned lock.

I agree that it's only destruction from an error handler that should require upgrading a non-owned lock. However I'm not sure what the force parameter would do?
Currently the upgrade function does not acquire the lock - it expects the lock to be already held. In this commit we are simply saying that the lock does not need to be held to call the function (and making sure that no races are possible with other functions of the API).
I do not think that it would make sense to acquire the lock in the upgrade function, as in the normal case you would only call upgrade on a lock that is already held.

Huh, I thought that priority-inherited mutexes checked that they were owned by the calling thread before upgrade.  It looks like they didn't, so I think this is fine.


Add workspace setting to not read flat config eslint file

Description
Temporal Temporary solution for eslint-vscode to work as expected as long as we are in eslint v8.54.0. Without this setting, hpc_service eslint.config.js interferes with eslintrc.json config file of hpc-cdm
TODO:
Upgrade eslint to latest v9 minor version available and remove this newly added setting

Temporal ≠ Temporary :P

A temporal solution indeed would be a crazy thing to be adding in a PR :)


Adding color and adjusting animation for alien

@melissa-rodriguez I took out the use of sin() here. It's very clever but I think opens up a big can of worms in terms of angles and mapping!


Possibility to render *.mjml templates to *.html templates

Rendering templates by a template tag every time the mjml template is accessed might require too much computing power or network bandwidth, especially, if you are trying to send a mass email referring each user personally.
My proposal is to add a management command that goes through the template folder and searches for *.mjml files with whatever Django template variables and template tags. Then the command would render *.html template files with the same template variables and template tags and place them in the same folders.
Django email sending commands could use those Django HTML templates to send emails, whereas the mjml conversion would happen only when there are changes in the template structure.

@archatas for your case you just can use caching e.g. {% cache %} the template tag https://docs.djangoproject.com/en/4.1/topics/cache/#template-fragment-caching.
Note, that you cannot render MJML until django-template is rendered inside the MJML-tag.


Connection tester

What does this PR do?

It actually does two things (that I should have separated)
1st it fixes the wrong filename selection when a plugin script was used. Before, it was first making a file name "0-SNEWS_ALERT..." saving this, and when plugin script was called it was making a new file name by increasing the count "1-SNEWS_ALERT...". If fixed this by returning the saved file name to the plugin.
2nd I made a CLI tool for testing connection snews_pt test-connection
The logic behind the connection is (following this issue https://github.com/SNEWS2/SNEWS_Coincidence_System/issues/11)
I open two streams one for publishing and one for reading. I add a time stamp and submit a "test-connection" message, within the other stream I read the last message within last 5 seconds, if the time stamp in that message is the same with the one we published, I display connection verified message.

This PR checks the connection to the kafka brokers, however using the same logic and making some adjustments to the snews_cs backend we can also test connections to the servers.
In that case server should submit another message when it sees "test-connection" in the id, and we try to see that message on the user side.


FEEDBACK

It appears there's a decent amount of people that dislike this update and prefer the old version. If you're one of these people, or not (I'll take any feedback from users), could you give me feedback on why you dislike / like the changes? What should be different and / or change?

I'll give my two cents:
I strongly preferred the old theme because of the consistent dark across the platform. Some of the recent changes you made to v2 are a step in the right direction, and I especially like the gray background behind emojis now, but here's a few things that seem to be broken:

Quick picker menu built into Discord (CTRL + K)

A couple of plugins that add to the Discord app have been broken, I assume because of their use of default variables. The tabs on the top come from BetterDiscord ChannelTabs 2.5.6, and the member count on the right comes from BetterDiscord MemberCount 2.2.9

Some of the built-in BetterDiscord stuff seems to be using the default Discord gray as well
The BetterDiscord plugins are probably a little niche, but I know a lot of them build off the default CSS variables, so I'm not sure how you'd like to address that to handle future occurrences. Just giving some feedback :)

I'll give my two cents: I strongly preferred the old theme because of the consistent dark across the platform. Some of the recent changes you made to v2 are a step in the right direction, and I especially like the gray background behind emojis now, but here's a few things that seem to be broken:
 Quick picker menu built into Discord (CTRL + K)
 A couple of plugins that add to the Discord app have been broken, I assume because of their use of default variables. The tabs on the top come from BetterDiscord ChannelTabs 2.5.6, and the member count on the right comes from BetterDiscord MemberCount 2.2.9

Some of the built-in BetterDiscord stuff seems to be using the default Discord gray as well
The BetterDiscord plugins are probably a little niche, but I know a lot of them build off the default CSS variables, so I'm not sure how you'd like to address that to handle future occurrences. Just giving some feedback :)

+1 on this -- I was going to make a post myself about some of the unthemed sections, and I put in the original code from here into the theme file on BetterDiscord so I could darken some parts to how dark they were in 1.0 but thats just my personal preference. Apart from the unthemed sections, it was overall pretty good update.

thank you for the feedback, ill also make sure to theme the things i've missed (so if you notice more, let me know)
if you notice any other particular plugin that needs an area themed, let me know.

this is looking a lot better @LuckFire, thanks for the changes 🙂

glad to her that

Stylus style just doesn't work at all, even after refreshing or reopening Firefox.

thank you for the feedback, ill also make sure to theme the things i've missed (so if you notice more, let me know)
if you notice any other particular plugin that needs an area themed, let me know as well.

The window to choose "which window to stream" where you can click applications/share screen is also unthemed.

Hey there! Just noticed that the Stages background is back to the Discord standard grey gradient—any tips on how to override that to go back to pure black? Or else skin it otherwise? Not familiar with which element I'd need to change in the CSS editor.
I was enjoying this theme for saving wear and tear on my OLED + being able to easily color key away the backdrop in OBS for a weekly Stages podcast I record; with the grey gradient, this isn't cleanly possible.

Change connections to this, please. I like that you added color to it but I would like a border, not the entire thing filled in. I don't know if others agree or not but I( think it would look better. Also with rounded corners too.
`/profile connection borders/
.connectedAccountIcon-3_EQqg ~ div::before {
content: "";
top: 0; bottom: 0; left: 0; right: 0;
border: 1px solid var(--border-color);
position: absolute;
display: block;
pointer-events: none;
}
.connectedAccount-2Jb-Z0{
overflow: hidden;
position: relative;
}
/* Spotify /
.connectedAccountIcon-3_EQqg[src="/assets/eaeac24163b35f7526704a3d9b3c7722.svg"] ~ div::before {--border-color: #1ED760;}
/ Github /
.connectedAccountIcon-3_EQqg[src="/assets/6a853b4c87fce386cbfef4a2efbacb09.svg"] ~ div::before {--border-color: #fff;}
/ Twitch /
.connectedAccountIcon-3_EQqg[src="/assets/ca71e0b8818221eea1deebbaf8dc6518.svg"] ~ div::before {--border-color: #563194;}
/ Twitter /
.connectedAccountIcon-3_EQqg[src="/assets/85cf2b49d2a185c98ec8e383ad5a05d6.svg"] ~ div::before {--border-color: #0099E4;}
/ XBOX /
.connectedAccountIcon-3_EQqg[src="/assets/1fa6585cbb8c0fe21188e26d19fc6609.svg"] ~ div::before {--border-color: #5EC220;}
/ Reddit /
.connectedAccountIcon-3_EQqg[src="/assets/f3224f560c8f5974355596a4f7e9ce19.svg"] ~ div::before {--border-color: #FF4500;}
/ Battle.net /
.connectedAccountIcon-3_EQqg[src="/assets/37f15a06d062bdd0fc252d2b35d0b0bb.svg"] ~ div::before {--border-color: #0099E4;}
/ Steam /
.connectedAccountIcon-3_EQqg[src="/assets/d897626dfa2016ea3ad0af935acb6070.svg"] ~ div::before {--border-color: #000000;}
/ YouTube /
.connectedAccountIcon-3_EQqg[src="/assets/57ee9535485efae7eb923ed4893abb57.svg"] ~ div::before {--border-color: #D9252A;}
/ Facebook /
.connectedAccountIcon-3_EQqg[src="/assets/32045743cb7670855ae726743c949e0c.svg"] ~ div::before {--border-color: #1877F2;}
/ LOL */
.connectedAccountIcon-3_EQqg[src="/assets/94dc6f30a819026fa295d85f1f72b4ab.svg"] ~ div::before {--border-color: #CEA146;}`

I've changed to 2.0 because of the "broken" search bar menu as was mentioned in #12 and it is fixed after changing, but I'm kinda sad that the "Jump to present" bar showing after scrolling too much into the history is Discord-gray (#4c4c4c) and I would expect it to be at least #0a0a0a as is in the server column on the right side of the window.
And one more thing, would it be hard to change the color under "number-limited voice channel status" to be full black on the left side? I just feel it should be completely black to not be recognisible with the background, but that's maybe only my way of seeing that.

Debug info:

thank you for the feedback, ill also make sure to theme the things i've missed (so if you notice more, let me know)
if you notice any other particular plugin that needs an area themed, let me know as well.

The window to choose "which window to stream" where you can click applications/share screen is also unthemed.

sorry for spliting into two messages The buttons used for webcam/stream/activity looks a little bit too light in my opinion

Stylus style just doesn't work at all, even after refreshing or reopening Firefox.

did you redownload the theme?


Ensure REQUEST_URI and RAW_URI stay in sync with path

Attempt to fix #2151 - let me know if this warrants a regression test or a different approach.

The alternative probably is to change the lines further below where builder.path is set to also modify request_uri. Would be happy for some guidance there, then.

if this warrants a regression test or a different approach.

Changes need tests. It's one of the checkboxes you removed from the PR template ;-)

if this warrants a regression test or a different approach.

Changes need tests. It's one of the checkboxes you removed from the PR template ;-)

Huh, I honestly haven't seen the template for some reason. Can't remember if I used a weird incantation to create the PR. Sorry about that.

Were you going to write a test for this?


end-to-end testing from platform to native

It would be helpful to have tests using the platform code to execute flows with an echo server in order to verify end-to-end piping of correct behavior.
This would help test all the bridging portions (between platform and c bridge, and c bridge to native code) in the library which currently lack the greatest in test coverage.

Approach using an envoy filter: #974


auro-accordion: expanded not working

Describe the bug
Using the expanded feature on the component does not appear to be pre-expanding the UI as expected.
To Reproduce
Steps to reproduce the behavior:
Using <auro-accordion expanded> doesn't work.
Expected behavior
The component should be expanded on load.
Desktop (please complete the following information):

Browser [chrome, safari]

I'm going to try to fix this. I think it's related to how the height transition is performed.

:tada: This issue has been resolved in version 1.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Consider removing the S : Service bound on Middleware<S>

It is not a requirement for the trait. The bound can be set as needed by the specific implementation. This would also enable using aliases like HttpService as the bound.

Closed by #53 ?

Yes!


[feature request] topology.kubernetes.io values in metrics

It would be awesome if the metrics could include the node's topology.kubernetes.io/region & topology.kubernetes.io/zone (not sure what the non-AWS fields are called). That would help quickly identify patterns in the results. e.g., zone "a" is slower than zone "b" or that cross-zone traffic is what's causing a large spike in response times. Not sure if this is possible within the framework of this tool.
keep up the great work & thank you!

These annotations seem to be popular.
I think that's a great idea. It would need to (optionally) broaden the privs to also list nodes, and then match its own pod to the node to populate the extra labels. It's a 👍 from me.
Now just someone needs to find a couple of hours to add it :)

haha the even present "find the time" bug. i hear that. :)

@seeker89 I'd like to work on this as I do have some spare time. As I'm relatively new to the project and code base, which are some of the files I should be taking a look at?

A very necessary feature. Any updates?


how can i update the electron version to the new version

if i want to update the electron version to newer version, waht should i do ,  or ,,,,the electron-vue can update the base devdependencies ?

i tried updating electron on my app by running below command , updated from 2.0.4 to 3.0.8, seems working fine so far :)
npm i -D electron@latest

See #871


"Use standard style"

standard has seen pretty incredible adoption! 1700+ packages already depend on it.
But how can we bring the benefits of standard to more packages? What about getting the top 200 packages to adopt it?
Developers get better by inspecting how popular packages work and looking at their package.json files. Getting more of the top 200 to adopt standard would likely have an outsize effect on overall adoption.
I see two possible approaches:

Use standard --format and/or manual work to transform packages and send PRs. This would probably be most effective for simple, small packages.
Open an issue ("Use standard style"), explain the benefits of standard, answer any questions the maintainers might have. This would probably be most effective if the issues are opened by existing contributors, or users who are invested in the package.

Points to mention in PRs, issues:

1700+ npm packages already use standard, including Google's Karma and npm itself. Full list.
Link to the website: http://standardjs.com/
Link to the full list of rules: http://standardjs.com/rules.html

Who wants to help?
This is the current top 200 list:

[ ] 1. mocha 50696
[ ] 2. chai 21354
[ ] 3. grunt 19903
[ ] 4. lodash 15819
[ ] 5. should 13148
[ ] 6. async 12897
[ ] 7. grunt-contrib-jshint 12357
[ ] 8. request 12028
[ ] 9. gulp 11845
[ ] 10. underscore 11280
[ ] 11. coffee-script 10246
[ ] 12. express 9987
[ ] 13. istanbul 8819
[ ] 14. tape 8717
[ ] 15. sinon 8179
[ ] 16. grunt-contrib-clean 7601
[ ] 17. grunt-contrib-watch 7263
[ ] 18. browserify 7125
[ ] 19. jshint 6885
[ ] 20. commander 6694
[ ] 21. chalk 5710
[ ] 22. debug 5666
[ ] 23. gulp-util 5505
[ ] 24. mkdirp 5347
[ ] 25. coveralls 5078
[ ] 26. grunt-contrib-nodeunit 5060
[ ] 27. grunt-contrib-uglify 5013
[ ] 28. q 4901
[ ] 29. babel 4861
[ ] 30. colors 4835
[ ] 31. bluebird 4535
[ ] 32. glob 4442
[ ] 33. through2 4418
[ ] 34. uglify-js 4254
[ ] 35. jshint-stylish 4167
[ ] 36. eslint 4153
[ ] 37. rimraf 3909
[ ] 38. grunt-cli 3817
[ ] 39. moment 3568
[ ] 40. gulp-rename 3535
[ ] 41. gulp-mocha 3517
[x] 42. karma 3437
[ ] 43. yeoman-generator 3418
[ ] 44. gulp-uglify 3358
[ ] 45. optimist 3348
[ ] 46. load-grunt-tasks 3328
[ ] 47. gulp-jshint 3217
[ ] 48. expect.js 3157
[ ] 49. grunt-mocha-test 3113
[ ] 50. minimist 3071
[ ] 51. sinon-chai 2961
[ ] 52. grunt-contrib-concat 2815
[ ] 53. grunt-contrib-copy 2757
[ ] 54. react 2716
[ ] 55. tap 2715
[ ] 56. body-parser 2617
[ ] 57. supertest 2545
[ ] 58. cheerio 2518
[x] 59. fs-extra 2509
[ ] 60. jquery 2488
[ ] 61. jade 2477
[ ] 62. webpack 2367
[ ] 63. nodeunit 2284
[ ] 64. babel-core 2162
[x] 65. karma-chrome-launcher 2160
[x] 66. karma-phantomjs-launcher 2151
[ ] 67. del 2129
[ ] 68. semver 2120
[ ] 69. node-uuid 2060
[ ] 70. redis 2039
[ ] 71. socket.io 2025
[ ] 72. connect 1987
[ ] 73. grunt-contrib-coffee 1963
[ ] 74. gulp-concat 1961
[ ] 75. babel-eslint 1956
[ ] 76. handlebars 1912
[ ] 77. jscs 1904
[ ] 78. mocha-lcov-reporter 1850
[ ] 79. winston 1807
[ ] 80. mongoose 1794
[x] 81. yargs 1763
[ ] 82. through 1753
[ ] 83. karma-jasmine 1740
[ ] 84. phantomjs 1690
[x] 85. standard 1661
[x] 86. karma-mocha 1660
[ ] 87. time-grunt 1646
[ ] 88. shelljs 1645
[ ] 89. ember-cli 1637
[ ] 90. vows 1624
[ ] 91. yosay 1621
[ ] 92. ejs 1619
[ ] 93. mongodb 1618
[ ] 94. jsdom 1611
[ ] 95. jasmine-node 1589
[ ] 96. broccoli-asset-rev 1589
[ ] 97. marked 1575
[ ] 98. ember-cli-inject-live-reload 1573
[ ] 99. superagent 1572
[ ] 100. vinyl-source-stream 1566
[ ] 101. underscore.string 1560
[ ] 102. ember-cli-qunit 1554
[ ] 103. gulp-sourcemaps 1532
[ ] 104. babel-loader 1522
[ ] 105. ember-cli-ic-ajax 1516
[ ] 106. ember-export-application-global 1514
[ ] 107. extend 1511
[ ] 108. mime 1494
[ ] 109. karma-firefox-launcher 1489
[ ] 110. grunt-contrib-connect 1480
[ ] 111. ember-cli-content-security-policy 1468
[ ] 112. chai-as-promised 1441
[ ] 113. xml2js 1437
[ ] 114. ember-cli-dependency-checker 1427
[ ] 115. event-stream 1417
[ ] 116. grunt-release 1407
[ ] 117. bower 1380
[ ] 118. js-yaml 1351
[ ] 119. gulp-plumber 1347
[ ] 120. nock 1336
[ ] 121. less 1327
[ ] 122. concat-stream 1307
[ ] 123. ember-cli-htmlbars 1302
[ ] 124. ember-data 1298
[ ] 125. run-sequence 1296
[ ] 126. watchify 1285
[ ] 127. gulp-babel 1284
[ ] 128. grunt-bump 1275
[ ] 129. xtend 1251
[ ] 130. gulp-load-plugins 1247
[ ] 131. ember-cli-uglify 1246
[ ] 132. ember-cli-app-version 1244
[ ] 133. gulp-istanbul 1234
[ ] 134. object-assign 1212
[ ] 135. tap-spec 1210
[ ] 136. grunt-shell 1198
[ ] 137. gulp-coffee 1196
[ ] 138. grunt-browserify 1152
[x] 139. karma-coverage 1138
[ ] 140. ember-cli-babel 1130
[ ] 141. inquirer 1101
[ ] 142. babelify 1067
[ ] 143. co 1060
[x] 144. grunt-karma 1059
[ ] 145. matchdep 1059
[ ] 146. requirejs 1035
[ ] 147. ws 1034
[ ] 148. blanket 1022
[ ] 149. webpack-dev-server 1005
[ ] 150. gulp-eslint 996
[ ] 151. promise 991
[ ] 152. stylus 987
[x] 153. minimatch 987
[ ] 154. mysql 980
[ ] 155. morgan 970
[ ] 156. grunt-simple-mocha 969
[ ] 157. proxyquire 967
[ ] 158. es6-promise 964
[ ] 159. prompt 961
[ ] 160. eslint-plugin-react 946
[ ] 161. ember-disable-prototype-extensions 941
[ ] 162. cookie-parser 930
[ ] 163. babel-runtime 929
[ ] 164. gulp-minify-css 926
[ ] 165. ember-try 924
[ ] 166. aws-sdk 910
[ ] 167. when 907
[ ] 168. readable-stream 897
[ ] 169. gulp-jscs 891
[ ] 170. pre-commit 876
[ ] 171. esprima 868
[ ] 172. backbone 866
[ ] 173. inherits 860
[ ] 174. grunt-contrib-cssmin 860
[ ] 175. gulp-header 839
[ ] 176. jasmine-core 832
[ ] 177. wrench 806
[ ] 178. open 804
[ ] 179. gulp-bump 801
[ ] 180. gulp-watch 799
[ ] 181. uuid 791
[ ] 182. lab 778
[ ] 183. socket.io-client 773
[ ] 184. koa 745
[ ] 185. ember-disable-proxy-controllers 738
[ ] 186. css-loader 738
[ ] 187. grunt-coffeelint 732
[ ] 188. grunt-jscs 729
[ ] 189. style-loader 724
[ ] 190. jsdoc 721
[x] 191. npm 715
[ ] 192. temp 708
[ ] 193. nan 705
[ ] 194. benchmark 702
[ ] 195. path 700
[ ] 196. browser-sync 698
[ ] 197. assert 693
[ ] 198. vinyl-buffer 690
[ ] 199. ava 682
[ ] 200. passport 681

coffee-script 10247

lol

How about getting Node core to adopt standard? I thought about it before, but never felt in a comfortable enough position to suggest it.
A possible entry point into Node core could be the readable-stream repo, which contains the streams implementation used in core.

ping @calvinmetcalf

naw readable-stream is just a bunch of regexes that pull it out of node core

I would love to help out! :rocket:
Could we maybe draft a good pull request text that we can use?

First pull request submitted!

After discussion on IRC, consensus was that this approach is a little too aggressive. I agree. Was worth sharing the idea for feedback, nonetheless!

@feross Maybe we could try and find repositories that already have a similar coding style, and make pull requests to them?
It would be really cool to run standard on every npm package and count the number of errors, then start from the bottom at that list.

@feross : I staunchly oppose your "standard style", your preference for hideous 2-space soft tabs and your blatant disregard for common sense. Seriously dude, stop trying to fix what isn't broken.

Just because you have made a repository called "Common Sense Coding" doesn't mean that it's actually common sense. If you prefer tabs, then by all means, use them. Two spaces seems to be the most widely used in the JavaScript community though, a standard style needs to take that into account in order to get adoption.

@Alhadis No one's forcing anyone to use standard. If it's not your cup of tea, feel free to not use it. Cheers!


Tiny ImageNet Training Configuration

Excuse me, we fail to adversarially train RobNet family on tiny-imagenet from scratch that the accuracy and adversarial accuracy on validation set don't rise at all. Only the learning rate decay strategy is mentioned in your article. Could you please tell me the whole detailed training configuration on tiny-imagenet?

Try two things: 1. increase the batch size; 2. for the first 10-20 epochs, train the network on the clean dataset, then use PGD training.

Sorry, can it be more detailed? For example, how much is the batch size?

It depends on the model and the GPU memory you can access. All of the experiments in the paper are conducted by fulfilling 32 1080TI GPUs. e.g. for RobNet_large, the batch size is 512, and for RobNet_free, the batch size is 320. (The batch size here may be different if you use the model file in this repo, since before submitting the paper, we used the supernet with masks forming RobNet_large and RobNet_free to get performances on Tiny-Imagenet.)

Thank you.


Typos (plural dimensions) in section H

There are few examples in section H with inconsistent dimensions alternating between plural and singular:

profiles x profile
station x stations

See http://cf-trac.llnl.gov/trac/ticket/XXX

[ ] Added link from trac ticket to this PR?

Applied via https://github.com/cf-convention/cf-conventions/pull/XXX

[ ] Updated "Revision History"? (Use the date you applied the changes.)

Three weeks have passed, and @dblodgett-usgs  and myself agree with defect fix, so this issue will be closed and merged.
Thanks to @castelao for sorting it out.


Lots of URLs (even within the site) are hardcoded in faqsbody.mustache

Do we want to move this to a central place on view? As these urls are used on every single page on the site because of intro. Or do we want to abandon a slavish devotion to url_for given that we already had to abandon it within the furious prepare loops in view for perf reasons. Make a decision and implement.

e686a30 moves them to view.py


Open AggregateRepository dispatchers

From now, AggregateRepository exposes 3 new protected methods:

createCommandDispatcher(): CommandDispatcher;
createEventDispatcher(): ExternalizedEventDispatcher;
createRejectionDispatcher(): ExternalizedRejectionDispatcher.

Here Externalized*Dispatcher is a dispatcher capable of wrapping itself into an ExternalMessageDispatcher.
This is done to make it possible to change the repository behavior upon a message dispatching.

Since another approach has been approved.


Incorrect text passed to Operator.operate() when entities overlap

Background
When recognized entities partially overlap, Presidio passes incorrect text argument to the Operator.operate(text, params) function.
In EngineBase._operate() the text get dynamically replaced as it's being anonymized. The text_to_operate_on that's passed to Operator.operate(text=text_to_operate_on) is taken from this partially anonymized text instead of the original one.
text_to_operate_on = text_replace_builder.get_text_in_position(
    operator.start, operator.end
)

This can cause a problem, because in certain cases this doesn't correspond to the originally found entity. It is not noticeable when operators don't use the original text (e.g. replacing by entity type) or when the found entities are far enough from each other.
Example
Let's say we have a custom operator that replaces entity by <ENTITY_TYPE: original_text>.
There are two entities, credit card number and URL, that partially overlap.
text = "Fake card number 4151 3217 6243 3448.com that overlaps with nonexisting URL."

expected_result = "Fake card number <CREDIT_CARD: 4151 3217 6243 3448><URL: 3448.com> that overlaps with nonexisting URL."
actual_result = "Fake card number <CREDIT_CARD: 4151 3217 6243 <URL><URL: 3448.com> that overlaps with nonexisting URL."

The anonymization is done backwards, so the URL is anonymized correctly. But when anonymizing the credit card, instead of the original text 4151 3217 6243 3448, the operator gets partially replaced one 4151 3217 6243 <URL.
While this is just an artifical example, it could cause real issues for example when hashing the original values - the hashes for the same entities would be different.
Proposed solutions

Instead of taking text_to_operate_on from the text_replace_builder, take it from the original text.
The original text could be an attribute of PIIEntity (handled during analysis), and it would be used as text_to_operate_on.

Minimal code example
Python 3.9, presidio_anonymizer 2.2.28, presidio_analyzer 2.2.28
from presidio_analyzer import AnalyzerEngine, RecognizerRegistry
from presidio_analyzer.nlp_engine import SpacyNlpEngine
from presidio_analyzer.predefined_recognizers import CreditCardRecognizer, UrlRecognizer

from presidio_anonymizer import AnonymizerEngine
from presidio_anonymizer.entities import OperatorConfig
from presidio_anonymizer.operators import Operator, OperatorType

class CustomReplaceOperator(Operator):
    def operate(self, text: str, params: dict = None) -> str:
        return f"<{params['entity_type']}: {text}>"

    def validate(self, params: dict = None) -> None:
        pass

    def operator_name(self) -> str:
        return "custom_replace_operator"

    def operator_type(self) -> OperatorType:
        return OperatorType.Anonymize

recognizer_registry = RecognizerRegistry()
recognizer_registry.add_recognizer(CreditCardRecognizer())
recognizer_registry.add_recognizer(UrlRecognizer())

analyzer_engine = AnalyzerEngine(
    registry=recognizer_registry,
    nlp_engine=SpacyNlpEngine(models={"en": "en_core_web_sm"}),
    default_score_threshold=0,
    supported_languages=["en"]
)

anonymizer_engine = AnonymizerEngine()

text = "Fake card number 4151 3217 6243 3448.com that overlaps with nonexisting URL."
recognizer_results = analyzer_engine.analyze(text, language="en")
anonymized_text = anonymizer_engine.anonymize(
    text, recognizer_results, operators={"DEFAULT": OperatorConfig("custom_replace_operator")}).text

print(anonymized_text)

Thanks, will look into this. Would you be interested in creating a pull request? We'd be happy to review.

I've pushed a fix for this issue. It is now on main.