VS 2022 color issue

Looks like everything is of the default color when using it in the latest VS2022 (Version 17.2.0 Preview 1.0)

Not sure if I'm right, I notice there are no default values for the Classifier Pattern (Regex)

I agree. It looks like the settings file got nuked.

That worked :)

Awesome, thanks, finally solved my problem


Safely unregisterNetworkCallback

Task/Issue URL: https://app.asana.com/0/72649045549333/1201814931393696/f
Description

The NetworkTypeCollector registers a network callback to know when we have a network switch (eg. WIFI → CELLULAR)
There seems to be an edge case where the unregisterNetworkCallback method is called however the registerNetworkCallback is not
This seems to happen when we fail to create the TUN interface
In such case the unregisterNetworkCallback method throws an Exception

This PR try-catches and proceeds.
Steps to test this PR
Code review

Current dependencies on/for this PR:

develop

PR #1745   (this PR)

This comment was auto-generated by Graphite.


[Scope Change Request] - "Post Code Lookup - Table" - FindStreetNameFromAddress

Please delete the scope 'OnPrem' on procedure FindStreetNameFromAddress so we can use this function in our cloud solution.
codeunit 11402 "Post Code Lookup - Table"
[Scope('OnPrem')]
procedure FindStreetNameFromAddress(var StreetName: Text[50]; HouseNo: Text[50]; var PostCode: Code[20]; var City: Text[50]; var PhoneNo: Text[30]; var FaxNo: Text[30]): Boolean
var
    ForcePopup: Boolean;
begin

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add argument list for the command in the Toolkit

There is currently no way to know how many arguments are required by a command.

Multiple commits involved
https://github.com/Sygmei/ObEngine/commit/b3442e6d55aff0849cc579aae4f19ad77a33d179


Multiple Statement Execution (SERVER_MORE_RESULTS_EXISTS)

Hello Felix,
how difficult would it be to support multiple statements in one query, like BEGIN; SELECT 1; SELECT 2; COMMIT?
I think both having query(...) invoke the callback function multiple times and introduce something like multiQuery(...), where the callback gets arrays of rows and fields, would work fine.
Best regards,
René

Check out this implementation... https://github.com/bminer/node-mysql-queues

I have added transaction support to node-mysql.  Check out this project:
https://github.com/bminer/node-mysql-queues


Toml configurations for several features needs to be added to the templates

Describe the issue:
The template configurations for the following features are not available.

Per-user account locking feature and template NotifyUserExistance.
Auto-login after password recovery.
Skip returning the challenge question recovery option, if the user doesn't have challenge questions answer.
Numeric only OTP for password recovery and REST API to disable/enable SMS based password recovery.
Revoke tokens in logout.
https://github.com/wso2/product-is/issues/9425

Environment information

Product Version: IS 5.10.0-KM Only

https://github.com/wso2-support/update-artifacts/pull/736


Updated min recommended versions for java and spring data cosmos sdk

Updated min recommended versions for java and spring data cosmos sdk
Updated guidance on spring data cosmos v3 SDK

#sign-off

#sign-off


Tidy plotter arguments

Why are material_name, temp, and conc, needed in the plotter? E.g. https://github.com/WMD-group/PyTASER/blob/953968c3f0044e79644744415b33647dc7b2dae3/plotter.py#L38
The docstring makes it sound like the temp will impact the plot but I don't think it should as the TAS has already been generated.
If these are just for additional labels and titles, then they should all be optional arguments with no default value (e.g., an empty string).

Done. The title will only be generated if material_name, temp and conc are defined in the plotter - so people can generate without a title now.

Just wondering if it would be a good idea to just use an bool called labels to determine whether someone wants their graph labelled? If True, we could extract the info (material name, temp, conc, etc) from the container class instead of them having to type out the stuff. Or would that be too much potentially redundant info between classes (and babying the user)?


Add DCO check

Status

[x] Add DCO app to scottrigby/prometheus-helm-charts
[ ] Authorize and re-add app after transferring repo to prometheus-community (#11)

Original issue
A simple approach is to install https://github.com/apps/dco

@torstenwalter Yes, in the helm org we use https://github.com/probot/dco. I can not seem to add integrations to my personal github repo but we should definitely add this after moving to the prometheus-community org in #11
PS I saw there was an action https://github.com/marketplace/actions/dco-check but it doesn't seem to be widely used so I just put it off until after we transfer ownership.

Changed title to make sure we track this as a to-do instead of a question. Thanks!

I added a new project to track work that needs to be done after repo transfer, and added this issue as a to-do item https://github.com/scottrigby/prometheus-helm-charts/projects/2


Help needed: how to implement PinDialog

I am currently trying to port my app to UWP using Template10, but there is one thing left: I've implemented some sort of pin dialog. Basically, everytime you resume the app, you first need to enter a pin to grand access.
Requirements:

the pin dialog is optional
navigation is restored after you entered the correct pin

I managed to implement it the following way: In my App.xaml.cs I have a event handler for the VisibilityChanged event of the current Window.
private void OnVisibilityChanged(object sender, Windows.UI.Core.VisibilityChangedEventArgs e)
        {
            var navigationService = base.NavigationService;

            if(pinFrame == null)
            {
                pinFrame = new Frame();
            }

            if(!PinHelper.IsPinActive() || !e.Visible)
            {
                return;
            }

            if (Window.Current.Content != pinFrame)
            {
                restore = Window.Current.Content;
            }

            if (Window.Current.Content != pinFrame)
            {
                Window.Current.Content = pinFrame;
            }

            if (!(pinFrame.CurrentSourcePageType == typeof(EnterPinDialog)))
            {
                pinFrame.Navigate(typeof(EnterPinDialog));
                var dialog = pinFrame.Content as EnterPinDialog;
                dialog.Granted += delegate
                {
                    Window.Current.Content = restore;
                    pinFrame = null;
                    restore = null;
                };
            }
        }

The only problem is, that when calling Windows.Current.Content = restore an exception is thrown:
System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at Template10.Controls.HamburgerMenu.NavButton_Loaded(Object sender, RoutedEventArgs e)

So my final questions are

should we fix the loaded event (this should not be hard)
is there maybe a better way to implement my feature? :)

Have you looked at the Login project in Samples?


Let DMA use descriptor chaining

DMA was always using the same descriptor.
It now uses the descaddr to switch to the next descriptor in case they are chained.
With this fix, the emulator now correctly draws the screen for mode DISPLAY_MODE_INDEX.

@erwinbonsma - Thank you so much!!! This bug had frustrated me so much that I had given up on figuring it out.

@aoneill01 - No problem. I have used the emulator extensively myself, so I am happy to contribute something back. So let me instead thank you for your work on the emulator.


Header-only targets support

Description
Swift Package Manager doesn't support header-only targets.
A header-only target is the target without any sources (.m, .cpp, .c, .mm etc) but having just the headers .hh, .h, etc)
While this issue is of limited importance for Swift / Objective-C ecosystem, with the Swift Interop support it's becoming more important.
Expected behavior
Header-only targets are commonly used in C++ world, having a native support for them would allow for better C++ package ecosystem available to be used with Swift.
Example: https://github.com/nlohmann/json - the most popular package for handling JSON in C++
Actual behavior
It's impossible to build a header-only target, an error occurs.
To work around this issue, at least a single empty file should be present and declared as a target's source.
Example:
https://github.com/nlohmann/json/pull/2807/files
_SwiftPackageManagerFile.cpp is added together with the package manifest in order to make the target build
https://github.com/apple/swift-numerics/blob/main/Sources/_NumericsShims/include/_NumericsShims.h
The same approach is used by the swift-numerics package in order to work around this issue.

target 'json' referenced in product 'json' is empty

Other references:
https://forums.swift.org/t/header-only-library-using-swift-package-manager/42700
Swift forums post discussing the same issue
Steps to reproduce

Create a target with only headers. Or use one of the examples listed above
Try to build the target, observe the error
Add a single .m file to the Sources with an import statement, importing the headers
Try to build again and now the build succeeds.

Swift Package Manager version/commit hash
No response
Swift & OS version (output of swift --version && uname -a)
swift-driver version: 1.62.1 Apple Swift version 5.7 (swiftlang-<IP_ADDRESS>.7 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx12.0
Darwin **************** 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64
json_not_working.zip
json_working.zip

cc @abertelrud @neonichu

Any news?

Partially fixed here:
https://github.com/apple/swift-package-manager/pull/6006
Similar issue: https://github.com/apple/swift-package-manager/issues/4806
The problem is still reproduced, but at the linker stage, it's still not feasible to work with the header-only targets, example with the following json package manifest:
// swift-tools-version:5.9
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "json",
    platforms: [
        .iOS(.v9), .macOS(.v10_10), .tvOS(.v9), .watchOS(.v2)
    ],
    products: [
        .library(
            name: "json",
            targets: ["json"]),
    ],
    targets: [
        .target(
            name: "json",
            dependencies: [],
            path: ".",
            exclude:
                [
                    "appveyor.yml",
                    "benchmarks",
                    "cmake",
                    "ChangeLog.md",
                    "doc",
                    "include",
                    "test",
                    "third_party",
                    "CMakeLists.txt",
                    "CODE_OF_CONDUCT.md",
                    "LICENSE.MIT",
                    "Makefile",
                    "meson.build",
                    "nlohmann_json.natvis",
                    "README.md",
                    "wsjcpp.yml",
                ],
            sources:
                [
//                    "_SwiftPackageManagerFile.cpp"
                ],
            publicHeadersPath: "./single_include/")
    ],

    cxxLanguageStandard: .cxx11
)

Error:

Build input file cannot be found: '/Users/user/Library/Developer/Xcode/DerivedData/Pragma-byueqyrrcrksgzcqwsdlfcjpwjhr/Build/Products/Debug-iphonesimulator/json.o'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it?

If I remove the sources component completely, I'm getting the following issue:

x-xcode-log://80F109DD-40DD-4B22-9B16-877DE1E67D92 library product 'json' should not contain executable targets (it has 'json')

So the issue is technically "resolved" at the SPM side, but it's still not possible to work with header-only targets in Xcode at all.

Another, problem occurs when I try to link with test binary using swift test
Seems it cannot link to C++ standard library even when I pass .linkedLibrary("c++")

C++ Interop Office Hours:

Is it possible to make it work (build) with the SPM only (command line)? If yes, then some workaround can be applied to the SPM and Xcode later
Looks like C++ Interop mode is not enabled, how does flipping that mode on/off affects the result (same result, i.e. getting a failure)
Need to localize the problem. Whether the current problem is related to the Xcode or to the SPM. If we can make the package build somehow with the SPM, then it's an Xcode problem

swift-mmio has a header-only target. They resolved the issue by .systemLibrary.
apple/swift-mmio#54

Could you please clarify how does this work?

swift-mmio has a header-only target. They resolved the issue by .systemLibrary.
apple/swift-mmio#54

Could you please clarify how does this work?

I'm trying to get Eigen to work https://eigen.tuxfamily.org/index.php?title=Main_Page as we use it a lot, it's also header only,
but I'm having no luck.
I tried the systemLibrary approach, it just needs the manual creation of the module.modulemap you see in the PR.
Unfortunately it still fails to build when it get to:
// Does the compiler support C99?
// Need to include <cmath> to make sure _GLIBCXX_USE_C99 gets defined
#include <cmath>

and it can't find cmath

Actually just creating the module.modulemap works as an alternative to creating a .m or .mm file for a target

Could you please provide an example?

Could you please provide an example?

Sure, but it's not working, I just have the same problem but without having to provide the .m or .mm file.
So for my Eigen example
Directory looks like so (I chopped some stuff out for brevity)
spm-eigen
├── Package.swift
├── Sources
│   └── Eigen
│       ├── include
│       │   └── eigen3
│       │       ├── Eigen
│       │       │   ├── Cholesky.hpp
│       │       │   ├── CholmodSupport.hpp
│       │       │   ├── Core
│       │       │   ├── Dense
│       │       │   ├── Eigen
│       │       │   ├── Eigenvalues
│       │       │   ├── Geometry
│       │       │   ├── Householder
│       │       │   ├── IterativeLinearSolvers
│       │       │   ├── Jacobi
│       │       │   ├── KLUSupport
│       │       │   ├── LU
│       │       │   ├── MetisSupport
│       │       │   ├── OrderingMethods
│       │       │   ├── PaStiXSupport
│       │       │   ├── PardisoSupport
│       │       │   ├── QR
│       │       │   ├── QtAlignedMalloc
│       │       │   ├── SPQRSupport
│       │       │   ├── SVD
│       │       │   ├── Sparse
│       │       │   ├── SparseCholesky
│       │       │   ├── SparseCore
│       │       │   ├── SparseLU
│       │       │   ├── SparseQR
│       │       │   ├── StdDeque
│       │       │   ├── StdList
│       │       │   ├── StdVector
│       │       │   ├── SuperLUSupport
│       │       │   ├── UmfPackSupport
│       │       │   └── src
│       │       │       ├── ....
│       ├── module.modulemap
└── Tests
    └── spm-eigenTests
        └── spm_eigenTests.swift

module.modulemap is simply:
module Eigen {
    header "include/eigen3/Eigen/Eigen"
    export *
}

And package.swift:
// swift-tools-version: 5.10
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "spm-eigen",
    products: [
        // Products define the executables and libraries a package produces, making them visible to other packages.
        .library(
            name: "Eigen",
            targets: ["Eigen"]),
    ],
    targets: [
        // Targets are the basic building blocks of a package, defining a module or a test suite.
        // Targets can depend on other targets in this package and products from dependencies.
        .target(
            name: "Eigen",
            cxxSettings: [
                .headerSearchPath("Sources/Eigen/include")
            ],
            swiftSettings: [.interoperabilityMode(.Cxx)],
            linkerSettings: [.linkedLibrary("std")]
        ),
        .testTarget(
            name: "spm-eigenTests",
            dependencies: ["Eigen"]),
    ],
    //cLanguageStandard: .c11
    cxxLanguageStandard: .cxx11
)

So with your solution you still need to add m/mm file to make it compile? Also what kind of error are you getting, cause it has changed, there have been some tweaks made under the hood in the Xcode/SPM and the error has changed since I've reported the issue.

So with your solution you still need to add m/mm file to make it compile? Also what kind of error are you getting, cause it has changed, there have been some tweaks made under the hood in the Xcode/SPM and the error has changed since I've reported the issue.

Not quite no, I get the same result if I use the module.modulemap or if I create an empty .m or .mm file.  I get further than if I don't use either.
If I remove the module.modulemap I get an error: target 'Eigen' referenced in product 'Eigen' is empty
But now, with module.modulemap, When I try to run a simple test, it tires to build, but fails when a header file tries to include <cmath> , So it at least detects the header files now, just doesn't seem to find stdlib I think?

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "spm-eigen/Sources/Eigen/include/eigen3/Eigen/Cholesky.hpp"
        ^
spm-eigen/Sources/Eigen/include/eigen3/Eigen/Cholesky.hpp:11:10: note: in file included from spm-eigen/Sources/Eigen/include/eigen3/Eigen/Cholesky.hpp:11:
#include "Core"
         ^
spm-eigen/Sources/Eigen/include/eigen3/Eigen/Core:19:10: note: in file included from spm-eigen/Sources/Eigen/include/eigen3/Eigen/Core:19:
#include "src/Core/util/Macros.h"
         ^
spm-eigen/Sources/Eigen/include/eigen3/Eigen/src/Core/util/Macros.h:679:10: error: 'cmath' file not found
#include <cmath>
         ^
spm-eigen/Tests/spm-eigenTests/spm_eigenTests.swift:2:18: error: could not build Objective-C module 'Eigen'
@testable import Eigen

I finally got Eigen working. Though I've been through so many iterations, I'm not quite sure what the precise issue was.
I have conan package up all my cpp libraries for ios, and now the Eigen headers it generated, I think I managed to grab a wrong version from somewhere during this process.
I get errors unless I add my own Eigen.cpp file that includes the umbrella header and I add a module.modulemap
I still have not got it to work with a swift test target, which threw me off track for some time, but it now works for my other packaged swift libraries as a depnedency


C extension only supports 6 timestamp precision.

Right now C extension only supports at most 6 timestamp precision, it would be nice to support more.
E.g., 2016-02-02T00:00:30.12345678901234-00:00 will be read as 2016-02-02T00:00:30.123456-00:00

It would be good to support at least 9 digits for QLDB users.

Above commit changed C extension to support 9 digits subseconds now.


Outdated Makefile examples rule

🐞 Problem
After switching to MyST format, the Makefile rule make examples became outdated, as it tries to find for *.md format notebooks, instead of *.mystnb ones.
💡 Possible solutions
A simple solution is to change previous file extension.
📋  Steps to solve the problem
Change the *.md from the following line:
https://github.com/poliastro/poliastro/blob/b1ea3ede8672da782cb3a989b52a17c78fad8ca1/docs/Makefile#L57
into a *.mystnb.

Can I pick this one up? Seems like a quick fix.

Sure @OBITORASU!

Closing this!


Show error message if delete user fails

Problem
Sometimes deleting a user fails because of FK constraints, however, the error message only shows a generic message.

Solution
Show the error message from GraphQL to make it easier for the user to understand why the deletion failed and how to fix it.
E.g:
Foreign key violation. update or delete on table \"users\" violates foreign key constraint \"profile_id_fkey\" on table \"profile\"

I think what we could do is that if we run into a Foreign key violation we should warn our users that removing their users would result in a cascade delete of their attached tables, say, with an alert. wdyt?

wdyt?
Not needed (and not possible, I think, because if the FK is set to Cascade Delete you won't see the FK violation error when deleting).


remove support for legacy device node references

After practicing with this project in the real world™, I see why relying on /dev/sd? is not a good idea. On my machine each disk seems to randomly become sd[a-g]
It's almost always better to be explicit than implicit.

in practice, this shorthand helps me to keep things in place for a new build, even if I am having to map them by hand, mostly because I'm still not used to referencing devices by-id

probably not worth the effort to change this behavior, leaving it for now.


Signature help pop up persist on screen after move cursor to new line and are duplicated.

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 6.3.9600
Windows 8.1 & Linux Ubuntu 16.04 Gnome 3
Extensions:

Extension
Author (truncated)
Version

cpptools
ms-
0.14.3

Steps to Reproduce:

npm install electron, jquery and<EMAIL_ADDRESS>create main.js, write code from https://electronjs.org/docs/tutorial/quick-start , when you are writing loadURL section, sometimes tooltips persist on screen after move cursor to new line.

Reproduces without extensions: Yes

Please provide screenshots

Also more tooltips overlaps

@Mlocik97-issues  The overlap between the suggestion widget and the signature help widget is covered in #32511
@joaomoreno This issue is about the Signature help persisting in the new line

and also, tooltips are duplicated (2x)

1/2 is the same as 2/2
On pictures up, are 1/4 and 3/4 the same,.. and 2/4 and 4/4 are the same.

join takes in any number of paths. So no matter how many parameters you enter, the signature help will say the same thing. That is as designed

n, I think, if you press ↓ on second slide is written the same text as on first slide. And it's useless.

cc @mjbvz for the actual contents of the signature help

@joaomoreno This issue is about the Signature help persisting in the new line

This is as designed. The API lets each language decide what happens when the cursor changes.

Yes, the signature help persistence is by-design
@Mlocik97-issues Can you please run Peek definition on join in path.join. I suspect we are pulling in two definitions from somewhere

I believe this is a a duplicate of https://github.com/Microsoft/TypeScript/issues/22106 which itself was closed as a duplicate of https://github.com/Microsoft/TypeScript/issues/1150
Closing as upstream


Please add rectiifier functions

f(x) = max(0, x) (ramp)
f(x) = ln(1 + e^x) (smooth)

Nevermind. It's in the source, but not on the website.


Transparent window or Upcoming windows versions

Problem: when we are working with PC or Laptop (only primary screen and
no other screens). Its very hard to work with two windows in same time simultaneously , Even if we have open some tabs in side by side ( cascade windows )

Example :
if I work with Microsoft word. Then I want to refer some pdf. I have few option.

Minimize current working window and open required software ( pdf reader ) .
Use cascade windows. ( if we use this technique, The efficiency becomes less and since the
screen size is limited all area cannot be achieved )

Solution: to overcome this problem I suggest transparent windows . ( Windows Service or Feature )
How Its works
When we want that feature, We can activate through windows notification center. Then that feature will be activated.
After that by pressing a special key ( as example alt key ) long time the window that has in maximize mode is starts to transparent ( Like a glass, We can see through it the minimized windows ). Then we can work on that window ( The newly opened minimized window or application interface ).
All minimized windows are displayed   as small icon some corner of display. if we want to select some particular window  we can use special key with number  ( alt key + number ).
When we want to come back to the current working window by pressing the special key ( Short pressing ) it comes automatically.
The concept has uploaded as pdf file here
Transparent window or Upcoming windows versions.pdf

This is primarily the repo for just the Windows Terminal application, not all of Windows. I'm actually not sure where the best place to put Windows feature requests is - probably the Feedback Hub? Actually this might fit in over in the microsoft/powertoys repo
(Even though this thread is off topic for this repo) - I'm not sure why this is needed as an alternative to just Alt+Tab'ing between active windows. That's been the traditional Windows workflow for this kind of scenario (multi-tasking between two full-screen apps) since I've been born.

here i have mentioned its a transparent. Then we can see through the current working window.
here the same problem i have experienced,
If we code something by looking at some reference code as i mentioned in the issue, its very hard .
So i think if we have something like this would helps to everyone.


SDL310 - Do not use banned C functions

Follow Criteria in Intel Beta Release SDL

Klockwork check most of the functions under Banned Microsoft APIs. I also did a manual search and looks like we are clean.


[Bug]:EufySecurityERRORNot connected can't continue!

What happened?
It won't connect, using HOOBS 4.2.1
Device Type
Doorbell (Supported)
Plugin Version
v1.0.x (Supported)
HomeBridge Version
v1.4.x (Supported)
NodeJS Version
v16 (Supported)
Operating System
Other (UnSupported)
Relevant log output
4/9/2022, 3:15:35 PMEufy Security BridgeConfiguration change
4/9/2022, 3:15:35 PMeufysecuritybridge stopping
4/9/2022, 3:15:40 PMEufy Security Bridge starting
4/9/2022, 3:15:46 PMEufy Security BridgeLoaded plugin 'homebridge-eufy-security'
4/9/2022, 3:15:46 PMEufy Security BridgeLoading 1 platforms...
4/9/2022, 3:15:46 PMEufy Security BridgeEufySecurityFinished initializing Eufy Security Platform
4/9/2022, 3:15:47 PMEufy Security BridgeBridge is running on port 51836.
4/9/2022, 3:15:47 PMEufy Security BridgeEufySecurityERRORNot connected can't continue!

Hello,
Unfortunately, HOOBS doesn't support the new UI to pass through CAPTCHA and 2FA.
Regards,
Aurelien


u-boot: only a predefined key can delay or abort boot

connect https://github.com/resin-os/resinos/issues/80

@agherzan @floion

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@agherzan and @michal-mazurek what is happening with this one?


rename test files to test_type (html/json)

otherways the language used displayed might only be HTML instead of Go in GitHub. This language is only used for testing and would display a distorted code language usage:

added some documentation to function

Language display was fixed


Disable enter (new line) during the new game session.

When you start a new game, pressing enter during the talking will cause a new line, which is not pleasant.

I fixed this issue, thanks for finding the bug for me.


[DRAFT] buho: init at 2.1.0

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Hm I'm able to run the application but somehow the icons are missing :(

Three independent packages modifying five frakking files, and you did it in only one commit?
Please split them accordingly.
In case you need documentation help:
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
https://emmanuelbernard.com/blog/2014/04/14/split-a-commit-in-two-with-git/
https://stackoverflow.com/questions/6217156/break-a-previous-commit-into-multiple-commits

Hm I'm able to run the application but somehow the icons are missing :(

@dotlambda Does the Mauikit app index-fm is working for you including styling? For me icons etc is missing :(

Usually the missing icons imply that the app expects the icons in a certain place, however that place does not exist. Sometimes it can be solved by wrapping the app, setting some environment variable in order to tell the app where are the icons.

The app is now compiling and running fine for me, ready for review :)

@dotlambda Does the Mauikit app index-fm is working for you including styling? For me icons etc is missing :(

No, icons are also missing for me. I've stopped worrying about that though as I don't run KDE and just hope that it works on Plasma. But even if that's not the case I'm not motived enough to dig into the issue.

Missing icons might be related to https://bugs.kde.org/show_bug.cgi?id=435236

I solved the issue with missing icons, see here https://github.com/NixOS/nixpkgs/issues/168102
Good point in splitting the commits, I‘ll do this tomorrow :)

New PRs for dependencies / required libraries:

mauikit-accounts https://github.com/NixOS/nixpkgs/pull/170110
mauikit-texteditor https://github.com/NixOS/nixpkgs/pull/170112

No need for three PRs, just three commits in this PR.

@AndersonTorres Excuse me??

@grahamc Why did ofborg not color things red here?
error: Function called without required argument "mauikit-accounts"

@grahamc Why did ofborg not color things red here?
error: Function called without required argument "mauikit-accounts"

@cole-h Could you have a look?


CORS problems with registry management feature

Bug description
I'm getting this error:
OPTIONS https://registry.mydomain.com/v2/
CORS Preflight Did Not Succeed

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://registry.mydomain.com/v2/. (Reason: CORS preflight response did not succeed). Status code: 401.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://registry.mydomain.com/v2/. (Reason: CORS request did not succeed). Status code: (null).

In the browser console when i try to browse added registry. It resides on the other subdomain than portainer and i add it by domain name (i.e. registry.mydomain.com while portainer is on portainer.mydomain.com). I have tried adding it by IP and port, but i get an error stating that it's not possible to connect to the HTTPS resource by HTTP (my registry uses wildcard SSL cert issued to my domain).
Expected behavior
Expected Portainer registry management feature to work on registry that resides on the other subdomain.
Portainer Logs
These actions are not showing up in Portainer container logs, both "browse" action and "test configuration" action.
Steps to reproduce the issue:

Setup SSL secured registry on the other subdomain than portainer
Go to portainer's domain and "Registries" on the sidebar of it's UI
Add registry by it's domain name and correct authentication credentials
See error in the devtools

Technical details:

Portainer version: BE 2.12.2
Docker version: Docker version 20.10.14, build a224086
Kubernetes version: Not using Kubernetes with Portainer
Platform: accessing Portainer web UI on windows, and Portainer is running on linux
Command used to start Portainer: docker run -d -p 8000:8000 -p 9000:9000 -p 9443:9443 --name=portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data -e VIRTUAL_HOST=portainer.mydomain.com -e VIRTUAL_PORT=9443 -e CERT=shared  portainer/portainer-ee:latest
Browser: Firefox Developers Edition
Use Case: Using Portainer in a Commercial setup.
Have you reviewed our technical documentation and knowledge base? Yes

Additional context
My registry is deployed behind NGINX reverse proxy, but image pulls from the portainer UI do work with this registry just fine (despite the above management problem).
While trying to fix the issue, I have already inserted this to my registry's config.yml
http:
  addr: :5000
  headers:
    X-Content-Type-Options: [nosniff]
    Access-Control-Allow-Origin: ['https://manage.gamerzero.dev']
    Access-Control-Allow-Credentials: [true]
    Access-Control-Allow-Headers: ['Authorization', 'Accept']
    Access-Control-Allow-Methods: ['HEAD', 'GET', 'OPTIONS']

@WildlandHerald
I'll be escalating this to our engineering for investigation.
You mention that image pulls work despite the error in the console. Is there any other functionality that doesn't work because of this?
Thanks

@WildlandHerald Which registry are you using? If its docker registry, have you seen this You mention that image pulls work despite the error in the console. Is there any other functionality that doesn't work because of this? Thanks

Yes it is docker registry, and as I've mentioned I've already enabled CORS in config.yml for it. The registry management feature isn't working. (so I can't browse images in it for example)

The issue seems to be with docker registry and not Portainer.
I've deployed a registry, behind NPM.
My registry docker-compose below
registry:
  restart: always
  image: registry:2.8.0
  ports:
    - 5000:5000
  environment:
    REGISTRY_AUTH: htpasswd
    REGISTRY_AUTH_HTPASSWD_PATH: /auth/htpasswd
    REGISTRY_AUTH_HTPASSWD_REALM: Registry Realm
  volumes:
    - /volumes/registry/data:/var/lib/registry
    - /volumes/registry/auth:/auth

NPM
https://reg.mydomain.com (with *.mydomain ssl) --> registryhost:5000
I'm able to browse registry as well as pull images.

With the exact same configs, behind a jwilder/nginx-proxy container as proxy, it doesn't work for me. Pulls (both in portainer UI and in the command line) are working fine. But when I try to browse the registry it results in this answer to the portainer's OPTIONS request, which I can see in the registry container logs:
error authorizing context: basic authentication challenge for realm "Registry Realm": invalid authorization credential

If I turn off authentication on registry completely, it responds with 200 to this OPTIONS request, but in portainer I still see this message:
Portainer was not able to use this registry management features. You might need to update the configuration used by Portainer to access this registry.

Note: Portainer registry management features are only supported with registries exposing the [v2 registry API](https://docs.docker.com/registry/spec/api/).


Use asteriks for password input.

This pull request fixes #1424.
Co-authored-by: Mwiza Simbeye<EMAIL_ADDRESS>

Closing, we discussed this in chat and I added an explanation to the linked issue.


Use default theme for mobile and classic for desktop

Is it possible to use the default theme on mobile devices and the classic theme on desktop devices?

 There's no better way to do so until v4 is out.
Cheers!


Clarification on Additional Token Usage and Embedding in Maskgit-pytorch Transformer

Hi. Thanks for the great work. I have two questions.

Can you please clarify what the second 1 is used for?
codebook_size is 1024, so its indices are between [0, 1023]. The first 1 in the code is for the mask token, which is 1024. nclass is 1000 for ImageNet. I do not understand the purpose of increasing the nn.Embedding with another 1.
Link to code

In the following code, why is self.codebook_size+1 used instead of self.codebook_size? What is the purpose of the additional token when after that we compute the cross-entropy loss?
Link to code

Hello,

The second "+1" is used for masking the class tokens for the classifier free-guidance. When the condition is dropped, it defaults to the last value of the embedding layer.

This was primarily for an internal experiment I conducted. It allows the model to also predict the  token, but can be safely removed if predicting masked tokens is not your objective.

Best,
Victor


 I've tried running
cmake .

in the root directory of the repo, but I get the error:
...
godot_debug_editor_executable = <some path>/godot-roguelite/extern/godot-engine/bin/godot.linuxbsd.editor.dev.x86_64
Godot engine debug binaries not found, invoking debug build of engine...
CMake Error at CMakeLists.txt:157 (execute_process):
  execute_process error getting child return code: No such file or directory

Maybe a I need a refresher in CMake 😄 . Do you know what command CMake: Configure actually runs?
Another thing: why did you choose to recompile the engine for this demo game? Did I understand something wrong?

Yeah, I knew it was something basic xD

The reason the engine is built is so it can be debugged easily while the gdextension...

Got it. Thanks


Missing using statement

The C# example for output binding fails with:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fff7ae2f-4f02-7ed9-c2ed-a2715e407975
Version Independent ID: 542016c1-3c25-f6af-cc83-0c5b6218e0ce
Content: Azure Blob storage bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-blob.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

This is the complete output with all the errors that the C# example spits out:

2019-12-13T20:36:21  Welcome, you are now connected to log-streaming service. The default timeout is 2 hours. Change the timeout with the App Setting SCM_LOGSTREAM_TIMEOUT (in seconds).

2019-12-13T20:36:33.048 [Information] Executing 'Functions.BlobTriggerImageResize' (Reason='This function was programmatically called via the host APIs.', Id=41605cbd-1a23-4bfb-9cc5-24c3d62b2ecf)
2019-12-13T20:36:33.103 [Error] Function compilation error

Microsoft.CodeAnalysis.Scripting.CompilationErrorException : Script compilation failed.

   at async Microsoft.Azure.WebJobs.Script.Description.DotNetFunctionInvoker.CreateFunctionTarget(CancellationToken cancellationToken) at C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\DotNet\DotNetFunctionInvoker.cs : 314

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at async Microsoft.Azure.WebJobs.Script.Description.FunctionLoader`1.GetFunctionTargetAsync[T](Int32 attemptCount) at C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\FunctionLoader.cs : 55

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at async Microsoft.Azure.WebJobs.Script.Description.DotNetFunctionInvoker.GetFunctionTargetAsync(Boolean isInvocation) at C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\DotNet\DotNetFunctionInvoker.cs : 183
2019-12-13T20:36:33.169 [Error] run.csx(4,7): error CS0246: The type or namespace name 'SixLabors' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.252 [Error] run.csx(5,7): error CS0246: The type or namespace name 'SixLabors' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.341 [Error] run.csx(6,7): error CS0246: The type or namespace name 'SixLabors' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.470 [Error] run.csx(7,7): error CS0246: The type or namespace name 'SixLabors' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.623 [Error] run.csx(29,32): error CS0246: The type or namespace name 'Image<>' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.697 [Error] run.csx(29,38): error CS0246: The type or namespace name 'Rgba32' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.835 [Error] run.csx(29,84): error CS0246: The type or namespace name 'IImageFormat' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.895 [Error] run.csx(11,6): error CS0246: The type or namespace name 'BlobTriggerAttribute' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:33.990 [Error] run.csx(11,6): error CS0246: The type or namespace name 'BlobTrigger' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.048 [Error] run.csx(12,6): error CS0246: The type or namespace name 'BlobAttribute' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.181 [Error] run.csx(12,6): error CS0246: The type or namespace name 'Blob' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.253 [Error] run.csx(13,6): error CS0246: The type or namespace name 'BlobAttribute' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.306 [Error] run.csx(13,6): error CS0246: The type or namespace name 'Blob' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.367 [Error] run.csx(15,5): error CS0246: The type or namespace name 'IImageFormat' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.437 [Error] run.csx(17,12): error CS0246: The type or namespace name 'Image<>' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.538 [Error] run.csx(17,18): error CS0246: The type or namespace name 'Rgba32' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.603 [Error] run.csx(17,34): error CS0103: The name 'Image' does not exist in the current context
2019-12-13T20:36:34.661 [Error] run.csx(23,12): error CS0246: The type or namespace name 'Image<>' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.754 [Error] run.csx(23,18): error CS0246: The type or namespace name 'Rgba32' could not be found (are you missing a using directive or an assembly reference?)
2019-12-13T20:36:34.849 [Error] run.csx(23,34): error CS0103: The name 'Image' does not exist in the current context
2019-12-13T20:36:34.947 [Error] Executed 'Functions.BlobTriggerImageResize' (Failed, Id=41605cbd-1a23-4bfb-9cc5-24c3d62b2ecf)

Script compilation failed.

Also, the exampes for the C# and C# scripts are comletely different. The documentation not only doesn't describe how to create the output binding but adds a lot of confusion.

@toddysm
Thanks for your feedback! We will investigate and update as appropriate.

@toddysm Thanks for reporting this issue and helping us drive improvements towards MS Docs! I've updated the csharp sample demonstrating the output binding with a fix and the changes should be live shortly after the PR merge.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[Bug] gogoanime.tv: cannot stream nor download

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the latest version.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Aniyomi version
<IP_ADDRESS>
Android version
11
Device
S10+
Steps to reproduce

Open gogoanime.tv extension library
Click on any anime to watch
Click on an episode
Click download

Expected behavior
Start the episode or download it
Actual behavior
Crashes the app and if you try the download it crashes saying list empty
Crash logs
tachiyomi_crash_logs.txt
Other details
No response

I also have the same issue and came to report this bug

I'm also facing the same issue. Whenever I am trying to watch an anime, the app gets crashed. Manga is working fine though.

Other extensions are working fine only gogoanime is crashing. Use other extension to watch anime then the app will work properly 😉.

Yeah other extensions are working but gogoanime have a lot anime which is
not there in other extensions and the extentions are limited to
On Wed, Jul 28, 2021, 13:13 Bawalian @.***> wrote:

Other extensions are working fine only gogoanime is crashing. Use other
extension to watch anime then the app will work properly 😉.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jmir1/aniyomi/issues/122#issuecomment-888090121, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU764OHHGAE4DGA6VTBMSLLTZ6YJ7ANCNFSM5BDOTI4Q
.

So I would like u to fix this bug please..
On Wed, Jul 28, 2021, 13:13 Bawalian @.***> wrote:

Other extensions are working fine only gogoanime is crashing. Use other
extension to watch anime then the app will work properly 😉.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jmir1/aniyomi/issues/122#issuecomment-888090121, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU764OHHGAE4DGA6VTBMSLLTZ6YJ7ANCNFSM5BDOTI4Q
.

Bruh, this happens often , you have noticed it just now?

I started using this recently....
On Wed, Jul 28, 2021, 17:00 VashTheStampede0 @.***>
wrote:

Bruh, this happens often , you have noticed it just now?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jmir1/aniyomi/issues/122#issuecomment-888235769, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU764OARHDBMLUV7FWPBBB3TZ7S5VANCNFSM5BDOTI4Q
.

Same i just discovered the app this week so i'm still new to it

just fyi, open all extension related issues in jmir1/aniyomi-extensions
it's also fixed now.

Thanks for fixing the bug... It made my day realy thanx


'del' method bug

Hello Guys.
Today when we where using  superagent with express together, we found an issue with 'del' method.
Here, you are pushing 'del' method inside methods package, because it is simple required(package) and array of methods is not copied or something - https://github.com/visionmedia/superagent/blob/master/lib/node/agent.js#L58
The problem -  express also using methods package and because it was used after you added 'del' method it comes into an error from express that mentioning that they does not have function to handle 'del' method.
As i understood how node packages works, you are modifiying 'methods' package directly from yours correct? Is it possible to fix it?(Just make copy of methods list or something). Thanks!
P.S. Sorry for my bad English.

We've run into the same issue.

I've posted a pull request which fixes the issue - but for now a workaround is to require() superagent before express. The problem occurs in express because the methods list changes between the time the handler functions are created and then enumerated over - if superagent is required before express, the del method is on the list the whole time and there is no mismatch between the list of handler functions created and the list to enumerate over

Fixed in 1.7.1


Lookup Rules

I hope ppl don't mind but I'm starting a new thread about lookup rules, since the "import discussion" is too long and isn't just about syntax. The right syntax to implement is the simplest most brain dead least capable one to start with, IMHO, then go on from there.
So will someone explain, if I say
import X

what does that do? Does it put X in scope? And nothing else?
What if I say
import X.Y

What symbols are no in scope? Note that in Python, X is in scope, as well as Y. Which is inconsistent.

My thinking as of now is that only the last item gets pulled into scope.

@skaller wrote:

import X
what does that do? Does it put X in scope? And nothing else?

I'm thinking that import is the wrong way to introduce a package or library, this should be done with a separate command like addLibrary() or library() otherwise you couldn't permit to name a module with the same name in your current project.
@shelby3
What is if a library requires you to provide to implement some functions, you will need some builtin support for that in repls.
Import statement should only provide aliasing functionality, therefore import X is without meaning, if you want to import ingredients then wildcards might be appropriate or a open X

@sighoya wrote:

otherwise you couldn't permit to name a module with the same name in your current project.

As long as your module has a different directory prefix (or repository id), then it can be uniquely qualified by the prefix.

What is if a library requires you to provide to implement some functions, you will need some builtin support for that in repls.

I don’t understand this comment.

I don’t understand this comment.

You said that importing modules can require the importer to provide some implementations of imported signatures.
You said you will handle this in interface files, but how you will handle this in the REPL?

@sighoya wrote:

You said that importing modules can require the importer to provide some implementations of imported signatures.

Where did write that?

Where did write that?

Maybe I misunderstood it, but you said something like that in connection with strong versus weak modularity.

@sighoya wrote:

Where did write that?

Maybe I misunderstood it, but you said something like that in connection with strong versus weak modularity.

I found the discussion in the Modularity issues thread #39, that you’re referring to and added a new post on that subject.
I have never coded a REPL so probably @keean is the one who should comment on your question.


Add renovate to this repository

and remove dependabot

@soenkeliebau can you provide any documentation for implementation ? i want to try this

You should pretty much be able to simply copy the config from any of the operators repositories.
For example here: https://github.com/stackabletech/kafka-operator/blob/main/renovate.json
Regarding dependabot, it should be as easy as removing the config from this repo: https://github.com/stackabletech/docker-images/blob/main/.github/dependabot.yml

@soenkeliebau please assign me

Done.
While you are at it, this ticket has a sister and a brother, if you have the time :)
https://github.com/stackabletech/product-config/issues/53
https://github.com/stackabletech/integration-tests/issues/173

@soenkeliebau sure i will try to do that too , you can assign me that too

fixed by #171


Add Slab-and-Spike prior

It might be a good idea to add a slab-and-spike prior into Turing.
Currently, user can only do the following:
s ~ Bernoulli(p)
z ~ Normal(0, v)
b ~ s*z

In this case the user would have to use SMC, PG or a combination of PG and HMC/NUTS. A custom distribution would allow users to use HMC only, which would be a good feature. Something like:
b ~ SlabAndSpike(p, v)

I should have a look how this is handled in Stan link.

I could easily be wrong here as I've never used Stan, but as I understand it, they don't allow discrete distributions, so they can't have Dirac deltas making distributions discontinuous. As a result, they have a hack to avoid having a true spike in their slab-and-spike - I think they use a product of two or more normals(?) - product_normal() - that approximates a spike as the scale parameters tend to infinity... so it's not a real slab-and-spike either.
Although it would obviously be great to have a true slab-and-spike implemented directly in Turing.jl, my plan is to work on expanding the functionality of Distributions.jl to allow discontinuous distributions in general, and to help with the work to allow discrete distributions have support over any countable set rather than just integers - see JuliaStats/Distributions.jl#925 for both thoughts at the moment. Then the broader question would be how to allow these to be used in Turing, and in particular from the Distributions end, what information would we have to provide you and how for you to be able to automatically handle such distributions?

This is correct. I'll have to check what the product normal actually does.
A real slab-and-spike prior will anyhow only be usable if the user is using any particle-based algorithm. Other methods involve gradients, while SMC and co. only need to be able to sample from the prior using rand and to evaluate a samples likelihood using logpdf. There are no additional constraints. I think using such a custom distribution / extension should be working without any additional efforts on the Turing side.

Okay. The reason I assumed that might not be the case is that the documentation says that to use a custom distribution you need to define logpdf() for that distribution, and I wasn't confident how to do that given that the Dirac delta would just be a rather unhelpful Inf at that value?

True. I think logpdf is unfortunately used for the log mass function in the Distributions package. Or it’s a alias, not sure. Anyways, we assume logpdf = log pdf in the continuous case and logpdf = log pmf in the discrete. I know this is not nice but for now simplifies the interface.

We could also dispatch on the ValueSupport and use logpdf or logpmf respectively. However, I’m not sure how to handle mixed support in such a setting. I suppose this is what you are worried about.

Yes, that's exactly it. At the moment there is only (log)pdf, which works for both. I'm proposing to replace pdf with pmf for discrete distributions in Distributions.jl but to alias pdf to pmf for backwards compatibility. Then dispatching on ValueSupport would work fine for Turing.jl (though I have to admit I still don't really understand how you can handle this kind of thing in the likelihood ratio).

So, any thoughts about this? I would really like to have a go at updating Distributions.jl's handling of discrete / continuous / discontinuous distributions before it hits 1.0, but there's no point (to me!) in doing that unless I know what would be usable you all... on which note, I would also like to know how you would (like to?) handle a discrete distribution that has support over any countable set (e.g. of strings, symbols) rather than just integers, and there is also a discussion of how to handle them in Distributions.

Hi, we will not be able to handle discrete distributions over any countable set as we internally assume that values of any distribution are sub-typed by Real. But I assume we could relax this if necessary without much performance issues. @mohamed82008 is this correct?
Regarding mixing discrete and continuous distributions in the log joint. I don't see why this would be a problem, but I might easily misunderstand the issue you are raising. For discontinuous distributions (assuming IS based inference) this seems unproblematic too. At least in my opinion.

Handling non-real values would be great if it's possible, because there is already one PR - JuliaStats/Distributions.jl#916 - to allow non-numeric discrete distributions, and I would be hoping to generalise that.
As far as mixing discrete and continuous distributions, again great if it already works - as I've said before I'm simply a user of this stuff and I was assuming that you'd be calculating some kind of acceptance ratio in some MH-like world, and I wasn't sure what that even means if the priors didn't have equivalent terms on the top and bottom - one is a mass and the other is a density. However, are you suggesting that you wouldn't use that kind of approach at all and just sample repeatedly from the prior(?) for some kind of particle-based IS approach? So that kind of ratio never gets in to the equations. Isn't that incredibly inefficient not making proposals based on the current state and the prior ratio? Sorry for being so ignorant, I'm just many years out of touch with this stuff obviously...

Mixing discrete and continuous RVs in particle-based samplers is not an issue.
Thanks for sharing the PR. Having non-numeric discrete distributions would be really nice for many applications. I'm happy to open a PR on the Turing side once your generalisation is in Distributions.jl. Please keep me in the loop.

Will do.

Did this ever materialize and left open or was it perhaps downprioritized? Just curious as i think the spike and slab prior is an interesting and useful beast. 😊

I was very keen on the JuliaStats/Distributions.jl PRs that might have helped enable it, but after a few months I ran out of time and it seemed that no-one really wanted to merge it anyway, so I gave up (the final version was JuliaStats/Distributions.jl#951 fwiw). I'd love to have it merged, or this worked on independently of that PR...

I feel this is better done in another package, e.g. Distributions.

@yebai - in the unlikely event that I have time to take this back up again in Distributions.jl, it would be good to know what actually needs to be implemented for this to work inside Turing.jl... is there a specification anywhere? I know I knew this a couple of years ago, but I'd just like to get myself back up to date...

in the unlikely event that I have time to take this back up again in Distributions.jl, it would be good to know what actually needs to be implemented for this to work inside Turing.jl

thanks, @richardreeve for the message.  Turing is compatible with Distributions API, so there is nothing to do from the Turing side!

allow discrete distributions have support over any countable set rather than just integers

This is supported by Distributions nowadays, e.g. DiscreteNonParametric and Dirac allow non-integer support. It seems Discrete and DiscreteDistribution are (more or less commonly) understood as a countable support and distributions with countable support (i.e., distributions of discrete random variables in line with e.g. the simple notion on Wikipedia), and Continuous and ContinuousDistribution are viewed to refer to uncountable support and distributions with uncountable support (i.e., distributions of continuous random variables). This seems to deviate from their original interpretation but is consistent with the implemented DiscreteDistributions and ContinuousDistributions, allows to characterize each distribution as either DiscreteDistribution or ContinuousDistribution, and seemed the practically most useful approach for e.g. defining product distributions of discrete and continuous distributions (as e.g. in https://github.com/JuliaStats/Distributions.jl/pull/1391) without having to break or change the type structure.
However, unfortunately multiple (fallback) definitions still incorrectly assume that the support of DiscreteDistributions is integer-valued. In general, I think a better type system for the support of discrete (but also continuous) distributions, possibly partly inspired or taken from e.g. DomainSets, would be very very helpful. This could e.g. also fix some bugs with countably infinite support such as for Poisson.


fix: bump GO modules and address lint

@bharathkkb - I think this was a bug, but let me know if I misunderstood the intention: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/pull/1541/files#diff-c6acc5475eea7a39fa709e7981e723f9ddd138438088b2e044cd484c9b013303L94


Regression: Brain mask and brain tissue segmentation of the T1w worsened from 20.1.3 to 20.2.0-LTS

What version of fMRIPrep are you using?
Tested with all releases from 20.1.1 to 20.2.0-LTS
What kind of installation are you using? Containers (Singularity, Docker), or "bare-metal"?
Singularity containers
What is the exact command-line you used?
singularity run --cleanenv -B /path:/path fmriprep-singularity-<version> bids_dataset output_<version> participant --fs-no-reconall --fs-license-file license.txt --participant_label 1003 --output-spaces MNI152NLin2009cAsym:res-native --anat-only -w tmp/work<version> --nprocs 4 > tmp/<version> 2> tmp/<version>

Where <version> ranged from 20.1.1 to 20.2.0 LTS including the release candidates
Have you checked that your inputs are BIDS valid?
Yes, with bids-validator v1.5.3
Did fMRIPrep generate the visual report for this particular subject? If yes, could you share it?
Yes, I'm sending the reports to<EMAIL_ADDRESS>and put at the bottom of this issue screenshots of the issue.
Can you find some traces of the error reported in the visual report (at the bottom) or in crashfiles?
No errors are reported by fmriprep in the reports or in crashfiles
Are you reusing previously computed results (e.g., FreeSurfer, Anatomical derivatives, work directory of previous run)?
Everything started from a clean work and output folder
fMRIPrep log
I saved the logs, they were sent to<EMAIL_ADDRESS>Encountered bug
The normalization of the anatomical files used to work with 20.1.1, but were horribly distorted with 20.2.0-LTS. I tried all versions available as singularity containers in between to find out what happened and summarize what I found below:

Version
Anat normalization
Details shared by email

20.1.1
✅
no

20.1.2
✅
no

20.1.3
✅
yes

20.2.0rc0
❓
no

20.2.0rc1
❓
yes

20.2.0rc2
❌
no

20.2.0-LTS
❌
yes

Below, a screenshot of the expected result (taken from 20.1.3), a screenshot from the intermediate result (taken from 20.2.0rc1)
and one from the 20.2.0-LTS version:
20.1.3, seems OK

20.2.rc0, forgot some prefrontal areas?

20.2.0-LTS not OK

Summary of the report (identical for all reports except 20.1.2 that doesn't print the "Anatomical Conformation"):
Summary

Subject ID: 1003

Structural images: 1 T1-weighted
Functional series: [...]
Standard output spaces: MNI152NLin2009cAsym
Non-standard output spaces:
FreeSurfer reconstruction: Not run

Anatomical
Anatomical Conformation

Input T1w images: 1
Output orientation: RAS
Output dimensions: 240x320x320
Output voxel size: 0.65mm x 0.65mm x 0.65mm
Discarded images: 0

I'm happy to help in debugging this, however I can only run singularity versions so I could not bissect more to find the relevant commit(s).
EDIT for additional information.
I'm showing the output when starting from defaced images (with pydeface), but the same bug occurs without defacing. It also occurs when I remove the --fs-no-reconall flag, and it is similarly distorted for four out of my five subjects so far, with possible issues that I didn't investigate in the fifth.

These appear to be different subjects. Have you run the same subjects with the different versions?

I just checked from the reports and, unless I'm mistaken, these are from the same subject and different versions. The commands all shared the same input bids folder and the flag --participant_label 1003 — in fact, as described above, the commands were entirely the same except for the version numbers. I'm happy to look deeper into this if this is the main suspicion (maybe remove all other participants from the bids folder?).

Would it be possible for you to privately share this T1w image?

What kind of T1w sequence is this?

Update: I shared the defaced T1w privately by email just now at<EMAIL_ADDRESS>Thanks again,

Hi @mathias-sm, thanks much for sharing the image - it has been useful.
As I was hinting above, by the realization of noise in the background but impressive contrast of the parenchyma I was guessing this is an MP2RAGE dataset. Your image just confirmed that.
Unfortunately, MP2RAGE has remained an open issue for fMRIPrep for a long while: https://github.com/nipreps/fmriprep/issues/431#issuecomment-352908217, nipreps/smriprep#18, nipreps/smriprep#35
What happened here is that prior to 20.1.2 fMRIPrep was working on this particular T1w just by chance. How large is this the full dataset? Have you been lucky with other subjects' T1w?


minio: 2020-05-01T22-19-14Z -> 2020-08-08T04-50-06Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/minio/minio/releases.
meta.description for minio is: "An S3-compatible object storage server"
meta.homepage for minio is: "https://www.minio.io/"
meta.changelog for minio is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2020-08-08T04-50-06Z with grep in /nix/store/si3ksk8jj66v3ygj4fhla9zdrdf487k6-minio-2020-08-08T04-50-06Z

directory tree listing: https://gist.github.com/d8a654b37e8a7723d942b1ece211e88b

du listing: https://gist.github.com/5e36b5506b3e03b66be660cc55a97a72

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
minio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/si3ksk8jj66v3ygj4fhla9zdrdf487k6-minio-2020-08-08T04-50-06Z \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A minio https://github.com/r-ryantm/nixpkgs/archive/9d0129aed23dca662f2d863251e5a555ec0801c5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/si3ksk8jj66v3ygj4fhla9zdrdf487k6-minio-2020-08-08T04-50-06Z
ls -la /nix/store/si3ksk8jj66v3ygj4fhla9zdrdf487k6-minio-2020-08-08T04-50-06Z/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

minio

Maintainer pings
cc @edolstra @bachp @kalbasit for testing.

Result of nixpkgs-review pr 95258 1

1 package built:
- minio

Duplicate of https://github.com/NixOS/nixpkgs/pull/95111


Nasingla/subscription text

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

@stankovski please review the PR

Hi @stankovski could you pls review the PR?

@navysingla any update on this PR?

@navysingla  could you pls resolve comments on required fields?

HI @navysingla  are you still on this PR? could you pls update based on comments?

hi @navysingla are you still there to update the PR?

Made the changes based on feedback

Can we merge this pull request?

Can we merge this PR?
From: Yunge Zhu<EMAIL_ADDRESS>Sent: Friday, July 26, 2019 12:39 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Navy Singla<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Nasingla/subscription text (#6339)
@yungezz commented on this pull request.

In specification/subscription/resource-manager/Microsoft.Subscription/preview/2018-11-01-preview/examples/createSubscription.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6339%23discussion_r307621865&data=02|01|Navy.Singla%40microsoft.com|857805faec5248e6ed2c08d7119c4495|72f988bf86f141af91ab2d7cd011db47|1|0|636997235172200230&sdata=7c5S%2FYyk4qINiLlqUpBAWNU%2Fh5kARr0sDiNv6XWj99A%3D&reserved=0:

   "owner": {

     "objectId": "973034ff-acb7-409c-b731-e789672c7b31"

 },

 "additionalParameters": {}

is this deletion by intention?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6339%3Femail_source%3Dnotifications%26email_token%3DALLQV2H2BO4YI5KQRQFZ2VDQBKSXXA5CNFSM4HYANKHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7VJVHA%23pullrequestreview-267033244&data=02|01|Navy.Singla%40microsoft.com|857805faec5248e6ed2c08d7119c4495|72f988bf86f141af91ab2d7cd011db47|1|0|636997235172200230&sdata=moJGmVHpVy3ZzhxY8VQTZhcpyrDgjF6nqOiAOK7ZDec%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALLQV2FCAU623UVST2PBE6LQBKSXXANCNFSM4HYANKHA&data=02|01|Navy.Singla%40microsoft.com|857805faec5248e6ed2c08d7119c4495|72f988bf86f141af91ab2d7cd011db47|1|0|636997235172210223&sdata=7yGgEDOxswGG7SL2tlSXqgj1aVvGxA0Vr1cTsMZbFmo%3D&reserved=0.

Can we merge this pull request?

hi @navysingla  i swa you just added one new property to SubscriptionCreationParameters https://github.com/Azure/azure-rest-api-specs/pull/6339/files#diff-a8bd61b800905d5cefcf05d0af580fb9R195, will need codeowner review.

@yungezz we own this code and this property is already being used in Production. It was just not mentioned in swagger. If we want further review for this property, I can create another PR for that

@navysingla then I'm ok to merge it since it's already on Production.


Some past year paper

Guys I have found some past year papers over here:
https://nus-cs2030.github.io/1718-s2/final/index.html
https://nus-cs2030s.github.io/2021-s2/final-with-answers.pdf
Hope it helps and if you have found other pyp please share over here as well. Let's survive this module together!!!

Thank you dear stranger

Thanks Brandon!

here is another one but no answer
https://www.dropbox.com/sh/mhmysh6b1bo5bdo/AAAI05jxKfJJqlRq2Zog6Zv6a?dl=0&preview=1819SEM1-CS2030.pdf

Thanks Brandon! Helped al lot for the revision~

Thanks Brandon!

Thanks!

Thanks Brandon!

Thanks!

Thanks Brandon!
AY17/18 Sem1: https://www.comp.nus.edu.sg/~cs2030/1718-s2/final-1718s1-no-solution.pdf
https://www.comp.nus.edu.sg/~cs2030/1718-s2/final-1718s1-w-solution.pdf
AY17/18 Sem2: https://www.comp.nus.edu.sg/~cs2030/1718-s2/final-1718s2-w-solution.pdf
AY18/19 Sem1(no answers): https://www.dropbox.com/sh/mhmysh6b1bo5bdo/AAAI05jxKfJJqlRq2Zog6Zv6a?dl=0&preview=1819SEM1-CS2030.pdf
AY20/21 Sem2: https://nus-cs2030s.github.io/2021-s2/final-with-answers.pdf

Hi guys, wondering if anyone has additional PYPs with solutions? I don't want to do those without because I wouldn't be able to verify anyways.
Thanks!!

Box should have quite a few


[Maintenance] Add tests for testing security of endpoints

Relevant template
refarch-backend
Problem description (optional)
Currently no automated tests are available to test the security of the @Authorized annotated endpoints.
Desired solution
Tests for authorized and unauthorized cases must be added.
Considered alternatives (optional)
No response
Additional context (optional)
No response
No duplicate

[X] I confirm that this issue is not a duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Before adding the tests, we will write the example #96. The Ticket will be set to blocked


Removing the line-height rule for text input, select, and option elements & adding new Grid modifier

LGTM


Splitting component tests leads to build errors

Hi, thanks for making such a great package.
cypress: 12.7.0
cypress-split: 1.19.0
command in my project: npm run  cy:run
I tried to implement splitting for angular component tests and all my attempts failed, so I created a repository with a code based on your examples to provide you with a reproducible example.
There are some webpack-related errors:

And without splitting there are no errors:

Hmm, it needs the specs to be relative to the project, ughh, I need to think about and experiment with other situations. Right now it returns all absolute filenames
cypressSplit(on, config);
// config.specPattern
// has a list of absolute spec filenames

In your case, it seems that it only works if the config.specPattern is relative filenames.

Ok, I think the simplest solution is to transform the specs to relative form, then your project works. I added the code example to the README, see it https://github.com/bahmutov/cypress-split?tab=readme-ov-file#relative-specs-output


[tutorial] fix code snippets in 2-4

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

Removed one of the duplicate title tags.
Made a diff in code more explicit.
Added the font-style defined at the top of the page to the subsequent styles.

You're learning so much Astro.. you're even learning how to author our fancy code snippets!  😆


chore: use compiled cmak for docker build

Resolves #27
Resolves #24
Resolves #22
Resolves #11

@hleb-albau plz review

@hleb-albau since the CMAK version didn't change, but the Dockerfile drastically did, I suggest not to override an image at Dockerhub with the same version <IP_ADDRESS>, but instead create a new Dockerhub repository hlebalbau/cmak.

Hi, thanks for PR, will check it out in 1-2 days

test on local pc, seems good!

Thank you.
Do you have plans to release new docker image anytime soon ?

Yeah, right now I suggest next plan:

release new latest version. test it for some time
tag current stable with same as latest after testing

also, I did a small research. cmak name is so popular as c-make tool. Try to search cmak on dockerhub. May be it's better to leave name as is for now?

it's up to you about naming thing.
from my side I just interested in some fixed tag - not a stable or latest, to be able to use it it my CMAK operator :)

it's up to you about naming thing.
from my side I just interested in some fixed tag - not a stable or latest, to be able to use it it my CMAK operator :)

latest rebuilt
than you can use full tag(sha) located  here.

@eshepelyuk
docker pull hlebalbau/kafka-manager@sha256:1138c4fe077e873e10c614c3e54ad111382d1cbc3aa829cc45ad5d98291ce56f

example of immutable digest pull

BTW, don't you object that I'm putting links to your project on my CMAK operator page ?

@eshepelyuk
docker pull hlebalbau/kafka-manager@sha256:1138c4fe077e873e10c614c3e54ad111382d1cbc3aa829cc45ad5d98291ce56f

example of immutable digest pull

yeah this will be the last resort if no strict version will be release :)

BTW, don't you object that I'm putting links to your project on my CMAK operator page ?

it's open source, do want you want!

yeah this will be the last resort if no strict version will be release :)

I can create special tag for you, if you need (beside latest and master-7e7a22e). just name it.

I can create special tag for you, if you need (beside latest and master-7e7a22e). just name it.

Yeah, it would be great. Could you create a tag <IP_ADDRESS>+7e7a22e ?

+ is illegal char for tag, so I created hlebalbau/kafka-manager:<IP_ADDRESS>-7e7a22e

Great, thank you very much.


Having a +layout.server.ts file makes the client session undefined

Describe the bug
Having a +layout.server.ts file  in routes, even if it's empty, makes the client session undefined from this:
// file - client.ts
import { HoudiniClient } from '$houdini';
import { PUBLIC_GRAFBASE_API_URL } from '$env/static/public';

export default new HoudiniClient({
    url: PUBLIC_GRAFBASE_API_URL,
    fetchParams({ session }) {
        console.log("session", session)
        return {
            headers: {
                Authentication: `Bearer ${session?.authToken}`,
            },
        }
        return {}
    },
})

Severity
annoyance
Steps to Reproduce the Bug
Put file  +layout.server.ts file  in routes
Reproduction
No response

Having the same problem.. :(

@saveliy-kremen
Maybe it helps you.
https://discord.com/channels/1024421016405016718/1131236758890233977

I tried this solution. But in my case it doesn't matter what is in this file. Message "debug" not  displayed.
`export const load: LayoutServerLoad = async (event) => {
console.log("debug")

 return {
    session: event.locals.session
}

}`

I tried this solution. The session appears in PageData.
But it still disappears in client.ts. As far as I understand, +layout.server.ts overwrites the session that hooks.server.ts sets.
It would be nice to supplement the documentation on how to proceed in this case.

I'm not able to reproduce this in the project's e2e tests. I'm going to close this since it doesn't seem to be wide spready but If you have the time to put together a reproduction, i'd gladly take a closer look

I'm also having the same issue. It may not be very widespread but it does seem like a real/major issue

If you have the time to put together a reproduction using this project's e2e tests it would go a long way to helping me debug the issue. I unforunately wasn't able to reproduce it when I tried


IM-37 Added a route for adding data to the product table.  Also creat…

…ed a database convenience module called impdb.js

Other than the usage comment, this all looks good. Will sign off on merge once that is handled, so we can start setting a standard.

More work to do


fix: Update to the latest plugin names and links

Fixed in https://github.com/neo-project/neo-dev-portal/pull/69 and changes will be reflected in the new neo dev portal: https://developers.neo.org/docs/


Version information in controller log is not correct

Running latest image, controller shows the following log messages:
I1004 20:54:16.093347       1 main.go:77] Version: {Version:v0.0.1-alpha.0 GitCommit:unknown GitTreeState:unknown BuildDate:unknown GoVersion:go1.10.1 Compiler:gc Platform:linux/amd64}

...which are not correct.

Fixed by #315.


Fixed typo

Just a small typo. Figured I'd save you a minute. Thanks for the FAQ.

@aethant Thank you for catching that and your welcome for the FAQ hope it helps someone - https://twitter.com/timarney/status/767663357344288768 .


HBASE-27086 Fix graceful_stop cannot take previous balancer status by incompatibility of hbase shell prompt

https://issues.apache.org/jira/browse/HBASE-27086
There're 2 issues

hbase shell shows prompt always even through echo "balance_switch false" | hbase shell -n (noninteractive mode or piped)
irb now shows an empty line at end of the output, so tail -1 retrieve the empty line. need tail -2 | head -1 to retrieve true/false for previous balancer status

Need this patch in branch-2.4, 2.5, 2, 3, master

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
1m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
spotless
0m 56s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 51s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

11m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4490

Optional Tests
dupname asflicense spotless shellcheck shelldocs javac rubocop

uname
Linux d8ba6d329f3d 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 12a9e6e5ec

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
71 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 31s
master passed

+1 :green_heart:
javadoc
2m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
javadoc
1m 57s
the patch passed

_ Other Tests _

-1 :x:
unit
213m 43s
root in the patch failed.

227m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4490

Optional Tests
javac javadoc unit

uname
Linux 51658f48cfff 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 12a9e6e5ec

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/testReport/

Max. process+thread count
2441 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
1m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s
master passed

+1 :green_heart:
spotless
0m 37s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s
the patch passed

-0 :warning:
rubocop
0m  9s
The patch generated 1 new + 8 unchanged - 0 fixed = 9 total (was 8)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

10m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4490

Optional Tests
dupname asflicense spotless shellcheck shelldocs javac rubocop

uname
Linux 6043e5b5e80b 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-1.8.0_282-b08

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
61 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
master passed

+1 :green_heart:
javadoc
2m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s
the patch passed

+1 :green_heart:
javadoc
2m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
251m 18s
root in the patch passed.

265m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4490

Optional Tests
javac javadoc unit

uname
Linux 2d5d3a07d442 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/testReport/

Max. process+thread count
3799 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Adding schema/table in realtime mode

Hello.
Have you changed something in terms of adding schema/table in realtime (kafka) mode?
I'm using the same files for schema/table that i've been using since my first test last week, and always after a command './pinot-admin AddSchema ...' there was a feedback line printed to stdout with some info, as well as after the '/pinot-admin AddTable ...' command.
I add schema and table after running broker, controller and server.
Since last Jun26 there no such printouts anymore, and the query returns 'no table hit' error, and there's no consumption from kafka, as expected...
Thanks.

Please try the -exec switch with these commands (refer to pinot-admin wiki), and let us know if you still see an issue. As for messages not being printed, we will resolve those shortly.

Class AddTableCommand:
code:
if (!_exec) {
LOGGER.warn("Dry Running Command: " + toString());
LOGGER.warn("Use the -exec option to actually execute the command.");
return true;
}
##_exec == false(default)  return true


Regex Catastrophic Backtracking

Information

Server version: Paper version git-Paper-119 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: f25facb)

Full output of /mv version -p: https://paste.gg/p/anonymous/2875486d61984fc58695bd9bbfd2573b

Server log: https://paste.gg/p/anonymous/2c711e7c2d5d4ded9619db009b75599e

Details
Multiverse core crashes the server if any player issues the command /mv ^(.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.++)$^.
Description
Regex abuse (Catastrophic Backtracking).
Steps to reproduce
Type /mv ^(.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.*.++)$^ as any player. Regardless of permissions.
Expected behavior
Deny access to the command
This has been actively abused on multiple servers.
As a temporary workaround I recommend checking permissions before parsing the command so can be limited only to players with permissions.

Duplicate of #2703. Update your multiverse plugin.


Errors due to streams not being lazy

When PUTting an invalid turtle document to a server with the config-sparql-endpoint.json config it is going to crash. I'm currently under the impression that this is because the RdfToQuadConverter starts parsing the data before an arrayifyStream is called on the stream. The last one would throw an error which would get propagated back to the ResponseWriter, but this never happens.
The stream probably starts parsing at some point when the DataAccessor is doing a SPARQL request to get the metadata (to see if the resource already exists). My guess is that while the server is waiting there it uses this time to start filling a buffer in one of the streams.
If I add an error listener to the parsing stream when it gets created and some more logging, the logs seem to indicate that this is exactly what happens. At that point the server is no longer crashing either since the error is "handled", but is going to get stuck infinitely waiting for arrayifyStream since that call is never going to see an error or end event (since it already passed).
As far as I know there is no immediate way to prevent this from happening using Node.js streams as there is no way to force them to be completely lazy (there are libraries for that though at a first glance). There is the pause function that could be called on the input request but that doesn't seem that clean.
Open for new ideas that I don't know exist yet as this can probably pop up in other situations in the future. Going to check some more to make sure nothing else is calling the data stream without me knowing and I'm wrong here.

before an arrayifyStream is called on the stream

That should not happen though 😉
Let's generate a streaming POST body to the SPARQL endpoint, so we don't buffer on large inserts.

there is no immediate way to prevent this from happening using Node.js streams as there is no way to force them to be completely lazy

https://nodejs.org/api/stream.html#stream_readable_pause

https://nodejs.org/api/stream.html#stream_readable_pause

Calling pause on a stream only works if it is the last one in the chain, since pipe sets the stream to flowing mode. Also, if it is not the last stream in the chain that throws the error it is not going to work since the error stream is still going to buffer results.
After reading the docs I'm not even sure it would work if it was the last stream

The readable.pause() method will cause a stream in flowing mode to stop emitting 'data' events, switching out of flowing mode. Any data that becomes available will remain in the internal buffer.

So even then it still tries to parse the incoming data.

Any data that becomes available will remain in the internal buffer.

So even then it still tries to parse the incoming data.

Yeah, but there is backpressure protection, so it will signal that it prefers not to receive data. I assume HTTP signals this.
I'd be very surprised if buffers start filling up endlessly.
That is, I expect so see the behavior above if the error occurs in one of the first chunks, but not if it is in one of the last chunks (even if we make DataAccessor pause artificially for 10 seconds or so).

the RdfToQuadConverter starts parsing the data before an arrayifyStream is called on the stream

Why does it though? We should start listening to the stream ASAP.
Could you show the code with arrayifyStream? Is it conditional?
And if we cannot attach arrayifyStream ASAP, we should definitely attach an error handler immediately.

That is, I expect so see the behavior above if the error occurs in one of the first chunks, but not if it is in one of the last chunks (even if we make DataAccessor pause artificially for 10 seconds or so).

Yes probably, I'm using a small example right now, but I don't think we can disable those buffers since it's a stream from an external library.

Why does it though? We should start listening to the stream ASAP.
Could you show the code with arrayifyStream? Is it conditional?
And if we cannot attach arrayifyStream ASAP, we should definitely attach an error handler immediately.

The problem is not with arrayifyStream, it would also happen if we streamed it.
The problem occurs in the DataAccessorBasedStore here.
We first do a getMetadata call to the SparqlDataAccessor to check if we already have a resource for that identifier. This will cause the data accessor to send a SPARQL query to the endpoint to get results. It is at this point that I think the stream starts buffering since we are waiting for a response from the endpoint. It is only after all the checks have passed (is there metadata, is there no conflict, etc.) that the writeDocument call gets made where we (would) look at the data here.
Random idea to throw at the wall: a class that encapsulates streams and re-emits error events to new listeners that get added listenening to 'error' would actually solve the issue. Also not that clean of course.

It is at this point that I think the stream starts buffering

Indeed, so we need to pause it here, or at least attach an error handler?

Indeed, so we need to pause it here, or at least attach an error handler?

Pausing the stream does not prevent buffering though. We could attach an error handler but what do we do with it then? Store the thrown error in a variable somewhere and at the point we need the data check if there is an error in that variable?

Pausing the stream does not prevent buffering though.

Does it not halt errors either? Hmm.

We could attach an error handler but what do we do with it then?

400

  public async setRepresentation(identifier: ResourceIdentifier, representation: Representation): Promise<void> {
    this.validateIdentifier(identifier);

    // For the duration of this method, we are responsible for the representation
    let representationError: Error | null = null;
    const captureError = (error) => {
      representationError = error;
    };
    representation.data.once('error', captureError);

    // Ensure the representation is supported by the accessor
    await this.accessor.canHandle(representation);

   // All of our other stuff

   // Release responsibility over representation
   if (representationError !== null) {
      throw new BadRequestError(representationError);
   }
   representation.data.removeListener('error', captureError);

    // Potentially have to create containers if it didn't exist yet
    await this.writeData(identifier, representation, isContainer, !oldMetadata);
  }

Or, we can even abstract the above nicely with a function
  public async setRepresentation(identifier: ResourceIdentifier, representation: Representation): Promise<void> {
    this.validateIdentifier(identifier);

    // For the duration of this method, we are responsible for the representation
    const monitor = monitorStream(representation);

   // All of our other stuff

   // Release responsibility over representation
   monitor.release();  // can throw
   // monitor.release(e => new CustomError(e));  // if you need custom throw

    // Potentially have to create containers if it didn't exist yet
    await this.writeData(identifier, representation, isContainer, !oldMetadata);
  }

I went through the code and did a count of how many classes would need to be changed if we added the monitor solution, and how many if we used the wrapper solution. So for the monitor solution that would be every class that has a function that takes as input a representation/stream and does an async call to a function that does not take that stream as input. For the wrapper it's every time we create a new stream (even simple calls such as streamifyArray(metadata.quads())). Both ended up at 6 classes that would need the extra functionality actually (4 of them the same, so 8 in total if we do both). I checked this on all classes relevant for the default sparql config. The routing store would add 1-2 extra for the monitor but that class needs to be rethought anyway.
Would have preferres either any of those numbers to be lower since that is still quite often we have to take this situation into account.

It is what it is.


BouncyCastle Java 1.70 Vulnerabilities, No Fix Available

Hi, I am working on a spring boot java project and ran a scan with raven cli tool to see if my packages had any vulnerabilities.
The scan found two vulnerabilities in Bouncy Castle with no fix available...

org.bouncycastle:bcprov-jdk15on - 1.70 - Information Exposure - V4 - NotAvailable - https://security.snyk.io/vuln/SNYK-JAVA-ORGBOUNCYCASTLE-5771339

org.bouncycastle:bcprov-jdk15on - 1.70 - Uncontrolled Resource Consumption ('Resource Exhaustion') - V4 - NotAvailable - https://security.snyk.io/vuln/SNYK-JAVA-ORGBOUNCYCASTLE-6084022

Just wondering if anyone has any recommendations on what I should do here in this situation...  🤔
Thanks!

Hi, you should if possible be migrating to bcprov-jdk18on, that has versions above 1.70.
See bouncycastle latest releases for more information