StyledComponent uses defaultProps for theme instead of theme provided by ThemeProvider after initial render

Version
1.4.2
Reproduction
http://www.webpackbin.com/4Jdl6JjwM
Steps to reproduce
Click the button at least once and the click count text will turn from blue (the given value for theme.color) to red (the default prop for theme.color).
Expected Behavior
StyledComponents that are children of ThemeProvider should always use the provided props.theme instead of defaultProps.theme.
Actual Behavior
On initial render props.theme is correct, every subsequent render props.theme is defaultProps.theme.

If you check the browser console on the linked webpackbin you will see that Text gets rendered once on the initial render and twice on every subsequent button click.

@diegohaz Did we missed something in https://github.com/styled-components/styled-components/pull/345?

I think the issue is that we need to do the same isDefaultTheme check that we do on line 56, on 72 as well
https://github.com/styled-components/styled-components/blob/master/src/models/StyledComponent.js#L72

I'm also curious why it would be double rendering.

Oh, we really missed that setState use case.

I think the double rendering is because of how ThemeProvider is working.

@k15a yeah, I just checked, and it's because the theme object changes on every click (new object literal)

+1 on this, I've tried upgrading a few different projects to the latest 1.x release to make use of the withTheme HOC and was facing the same issue. Glad to see that it's nothing wrong with my codebase, anxiously awaiting a fix :+1:


fix: stricter props types

At the moment, mount() offers strong typing of props, but this strong typing is lost when dealing with the VueWrapper through either the props() or setProps() methods.
This change strengthens the typing of these methods to help raise compile-time errors when trying to get or set incorrect props.

We may need to just find some wild code bases to validate if this breaks anything. Maybe GitLab (not sure if they are on Vue 3 yet) or Cypress (cypress/vue uses Test Utils)

@alecgibson if you change the mount to:
export function mount<
  T,
  C = T extends ((...args: any) => any) | (new (...args: any) => any)
    ? T
    : T extends { props?: infer Props }
    ? DefineComponent<
        Props extends Readonly<(infer PropNames)[]> | (infer PropNames)[]
          ? { [key in PropNames extends string ? PropNames : string]?: any }
          : Props
      >
    : DefineComponent
>(
  originalComponent: T,
  options?: ComponentMountingOptions<C>
): VueWrapper<
  ComponentProps<C> & ComponentData<C> & ComponentExposed<C>,
  ComponentPublicInstance<
    ComponentProps<C>,
    ComponentData<C> & ComponentExposed<C>
  >
>

it should work without needing to cast on functional components
const wrapper: VueWrapper<any> = mount(Title, {

LGTM 👍 (Sorry for the delay!)

This PR (released in 2.4.2) breaks existing TypeScript projects, because setProps is too strict. I see this has already been addressed in https://github.com/vuejs/test-utils/commit/e9fe51fb10d265e4bcb25d5d4a0ea8474f244fc4 by making it Partial. When can we expect this fix to be released?


re: Enable some off-by-default lints.

wildcard_enum_match_arm
broken_intra_doc_links - this one actually says that it's warn by default, but it only started working for me after manually enabling it

#22  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @elenakrittik and the rest of your teammates on  Graphite


MEC1501 ADC is missing in HAL

Looks like there is no definitions for the ADC IP block.
@scottwcpg please fix.

PR for HAL is at https://github.com/zephyrproject-rtos/hal_microchip/pull/2.


paperless: fix uploading files via local folder

Description of changes
The consumer service needs to be in the same namespace as the task-queue, otherwise they cannot see each others temporary files. Same as for web uploading.
See also the discussion here:
https://github.com/paperless-ngx/paperless-ngx/discussions/5606

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please merge - this fixes paperless-ngx for Nixos.

I thought I understood the failure, but cannot reproduce it locally (without the fix). Do I need any special settings for this to happen or what do I need to do?
Context: I try to build a regression NIxOS test

Do I need any special settings for this to happen or what do I need to do?

I use the following configuration:
    # Enable Paperless-ngx
    services.paperless = {
        enable = true;
        mediaDir = "/data/paperless-ngx/Media";
        dataDir = "/data/paperless-ngx/Data";
        consumptionDir = "/data/samba/Paperless";
        consumptionDirIsPublic = true;
        address = "<IP_ADDRESS>";
        port = 58080;
        settings = {
            PAPERLESS_OCR_LANGUAGE = "deu+eng";
            PAPERLESS_FILENAME_FORMAT = "{created_year}/{created_month}/{correspondent}/{created_year}-{created_month}-{created_day} - {correspondent} - {title} - {document_type} - {tag_list}";
            PAPERLESS_OCR_USER_ARGS = "{\"invalidate_digital_signatures\": true}";
        };
    };

And before the fix I got that here:
https://github.com/paperless-ngx/paperless-ngx/issues/5943


Release PR

Proposed changes

fixed issue with price change representation;
fixed issue with broken links on dashboards.

Types of changes

[x] Bugfix
[ ] New feature or Enhancement
[ ] Others

Checklist

[x] I have read the CONTRIBUTING GUIDELINES doc
[x] I have signed the CLA by posting "I have read the CLA Document and I hereby sign the CLA" in the comment
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Accept

I have read the CLA Document and I hereby sign the CLA


Possible bug? -> VRTK seems to prevent SteamVR camera rig prefab from working...

Environment

Asset Store
3.2.1 [6 July 2017 release]
5.6.1f1
Vive
SteamVR 1.2.2 [29 June 2017 release]

Steps to reproduce

Start a new project and import SteamVR then VRTK.
Run any VRTK example scene.
Open a new, clean scene and drop in the SteamVR camera prefab.
Hit play.

 Note that I'm not referring to the new(ish) Steam Home beta, that is not running at all.

The VRTK_SDKManager that sits in (every) example scene(s) has a checkbox to auto-manage the needed VR settings. You can disable that checkbox and manage the list yourself. You have to make sure it works with the used VRTK SDK Setups if you use VRTK, though, so it's recommended to leave it checked.
If you don't load the VRTK scenes with an SDK Manager in them that has that checkbox checked the settings won't be changed, too.
You can find them at Edit > Project Settings > Player.

Thanks, didn't even think to check player settings.

Is this good to close now?

Yeah, just had to move openvr to the top of the list as suggested. I should have explicitly stated that everything is sorted - still new to all this github stuff...


"Tătaru", "Podgoria" and "Siliștea" villages are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Tătaru" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Tătaru, PRAHOVA (Tătaru)".

Step 2
Type "Podgoria" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Podgoria, PRAHOVA (Tătaru)".

Step 3
Type "Siliștea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Siliștea, PRAHOVA (Tătaru)".


Additional GPU-Accelerated Video Codec Support?

Describe the problem
My team is working to add support for encoding video frames generated within Unity with a hardware-accelerated video codec, without unnecessary CPU<->GPU copies (AsyncGPUReadback).  The use-case is related to streaming RGBD acquired with a Kinect Azure DK unit.  This feature would require solving at least two related design challenges, but I'm opening this ticket as a starting-point for discussion.
First challenge: Registering additional video codecs with WebRTC and making them available for SDP negotiation. This looks like it's handled inside the low-level WebRTC implementation from Google, so we need to study that codebase and see how codec name strings are resolved to implementations, and how to register new implementations.
Second challenge: Using the codec with Unity and DirectX.  We need a mechanism to pass encoded frames as a byte array into WebRTC on the sending end, and submit bytes received on the wire to our native plugin on the receiving end.  The current API surface operates in terms of video frames, which is extremely convenient but makes it hard to implement a solution that encodes frames on the GPU without first copying raw pixels to the CPU, and vice-versa.  It looks like the concept of a VideoFrame is deeply integrated into Google's WebRTC code so this may not even be possible without a fairly significant fork of that codebase, but I'd be happy to hear otherwise.
Describe the solution you'd like
We're unsure how to best achieve this, but if this is a use-case that is of interest, we'd be happy to contribute whatever we come up with upstream. If you have pointers where to inject this functionality with minimal disruption, I'd be happy to base my work on that.
I think our ideal interface on the transmitting side looks something like video_track.SubmitFrame(NativeArray<byte> encoded_frame) or similar.
Implementing our own rtc::VideoSink almost looks like the right answer, but that doesn't seem to address our need to accept already-encoded bytes (avoiding "download from GPU with AsyncGPUReadback; upload again to on-GPU encoder, then download resulting bytes and transmit that.").
Describe alternatives you've considered
We're not able to reach performance targets with VP8/VP9, so we need to look into alternatives. We're also noticing some latency that might be attributable to AsyncGPUReadback, and we'd like to minimize that.
Additional context
N/A

Hi @alterscape,
We already have some insights about all of this, and there are some works by the Media Foundation team on the Chromium video capture code (which unfortunately we don't use yet, but hope to use once WinRTC make it available to us) to avoid copies and pass the frames directly in VRAM from capturer to hardware encoder.

First challenge: Registering additional video codecs with WebRTC and making them available for SDP negotiation.

This can be done in Google's implementation by registering a custom video codec factory, which injects your codec into the mix. See how WebRTC UWP SDK is creating a custom video codec factory then injecting it into the peer connection when it's created.
However, WebRTC cannot handle random codecs out of the box, and normally requires that the codec be supported by RTP. For each supported codec, there is a corresponding RFC describing how to transport it via (S)RTP; see for example the H.264 RFC here. It is my (limited) understanding that you will not be able to inject a codec for which Google did not already write an RTP implementation, but I might be wrong. This is also likely to break compatibility with other implementations, which is only a problem if you are not controlling both client apps on both peers.

Second challenge: Using the codec with Unity and DirectX. We need a mechanism to pass encoded frames as a byte array into WebRTC on the sending end, and submit bytes received on the wire to our native plugin on the receiving end. The current API surface operates in terms of video frames, which is extremely convenient but makes it hard to implement a solution that encodes frames on the GPU without first copying raw pixels to the CPU, and vice-versa.

There are 2 separate issues here:

The performance implication of copying frames from VRAM to CPU after capture, then re-uploading from CPU to VRAM for hardware encoding before finally copying back again to CPU for network sending. The Media Foundation team is looking at fixing that for Chromium. The way this can be done is to use the special video frame type kNative. In short, you generate a kNative frame buffer containing only the D3D handle to the VRAM surface, and not any data, then pass that "frame" around from the capturer to the encoder, which can use it directly. The only issue is to make sure both your custom capturer and your custom encoder are used at the same time, otherwise other ones won't understand what that kNative frame is and nothing will work.

A special enum value 'kNative' is provided for external clients to implement their own frame buffer representations, e.g. as textures. The external client can produce such native frame buffers from custom video sources, and then cast it back to the correct subclass in custom video sinks. The purpose of this is to improve performance by providing an optimized path without intermediate conversions.

and submit bytes received on the wire to our native plugin on the receiving end.

It is unlikely to ever be possible to transmit any random bytes. You have to use a supported codec, and on the receiving side you will get back your frame in CPU memory. You could argue there's a similar optimization to be done there from decoder to renderer, and to some extent it is maybe possible using the same kNative trick, but I am less comfortable that it can be done here (I never really looked into it).

Related, note that @eanders-MS was writing a native renderer for Unity to optimize performance of async GPU readback, if that's of any help. I think this work is not underway anymore, but the basic implementation is there at https://github.com/AltspaceVR/MixedReality-WebRTC/tree/eanders/native-rendering.

Just to manage expectations though, although I did have a look at all of this when looking at potential performance optimizations for HoloLens 2, we never wrote a single line of code for it. This is a very large chunk of work for us given our resourcing and it is therefore unlikely we'd be able to do it by ourselves while also managing this project. Of course we are welcoming contributions! 😉

Thank you for the extensive documentation on what you looked at so far! I'll share this on with my team and see what we can do.

@djee-ms, I'm glad you mentioned the native renderer. Work on this is still underway. It has been taken over by @rygo6-MS, who is working out the last issues with running on Android.

#586 Native Video Render is currently open for testing.


More history?

I'm getting about ~800 data points for history.
Any possibly way to grab all points from a chart?
A way to use this on a chart rather then an idea?

@thisisloze
Pan backwards on the chart before you publish, or just use the GOTO function to search for a date long ago. This will load all data since the last-available date. THEN click publish, your published chart will have a longer history and so will the CSV when you scrape it.
Made a quick video tutorial: https://cl.ly/195183


With 0.3.0, when using ng-model, the value is not changed after autocomplete

Hi,
The issue can be reproduced with the LIVE DEMO listed in https://github.com/Siyfion/angular-typeahead:
http://plnkr.co/edit/cMvm7Z4REuIP69Uk4Tzz?p=preview

Type "s" in the model textfield
Notice the model value changes to "s"
In the typeahead dropdown, select "seven" and hit enter.
The model value does not change
-> it should have changed to "{"num": "seven"}

0.2.4 does not have the issue. It seems to come from this change: https://github.com/Siyfion/angular-typeahead/commit/5a82689175e49a01e3372c1bfed2c2fb229b8481
where getAllElements do not return any of the "typeahead:" event types.
regards,
-fred

I'm having the same issue!
I also left a comment about a rogue >

I too have the same issue. Thanks I saw this post otherwise I was thinking that this is something from angular.

There's a fundamental issue with #76 that's causing this... It will need investigating, or reverting.

I've reverted the event binding code for the time being.

updated. tested. works fine, thanks!


VPC Fails to Delete in Loom 0.1.1

Seems to be an intermittent issue where a fabric VPC will fail to delete when a user deletes and then recreates a fabric.
Usually the issue is the Internet Gateway and 1 or more Route Tables are left behind. This should not occur.

I think the Terraform state is not being fully updated before another request occurs this leads to Terraform using old / invalid state which causes issues.

Maclt-004:~ redacted$ curl -v localhost:7000/fabrics/REDACTED/cluster
[4:59]
and got:
[5:00]
* Connected to localhost (::1) port 7000 (#0)
> GET /fabrics/foodev/cluster HTTP/1.1
> Host: localhost:7000
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Tue, 23 May 2017 20:24:41 GMT
< Content-Type: application/json
< Transfer-Encoding: chunked
< Server: Jetty(9.3.z-SNAPSHOT)
<
{
 "errors" : [ {
   "code" : "1100",
   "title" : "FABRIC_NOT_EXISTS",
   "detail" : "The fabric does not exist"
 } ]
* Connection #0 to host localhost left intact```

[5:00]
So I assumed I was deleted so I then did:

[5:01]
`Maclt-004:~ redacted$ curl v -X POST -H "Content-Type: application/json" -d '{"name": "foodev", "model": "cf-v3"}' localhost:7000/fabrics`

[5:01]
and got:

[5:01]
```*   Trying ::1...
* Connected to localhost (::1) port 7000 (#0)
> POST /fabrics HTTP/1.1
> Host: localhost:7000
> User-Agent: curl/7.43.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 36
>
* upload completely sent off: 36 out of 36 bytes
< HTTP/1.1 204 No Content
< Date: Tue, 23 May 2017 20:32:24 GMT
< Content-Type: text/html;charset=utf-8
< Server: Jetty(9.3.z-SNAPSHOT)
<
* Connection #0 to host localhost left intact```

[5:02]
Then a waited a sec and did :

[5:02]
`Maclt-004:~ redacted$ curl -v localhost:7000/fabrics/foodev/cluster`

[5:02]
Got back:

[5:02]
```*   Trying ::1...
* Connected to localhost (::1) port 7000 (#0)
> GET /fabrics/foodev/cluster HTTP/1.1
> Host: localhost:7000
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Tue, 23 May 2017 20:33:53 GMT
< Content-Type: application/json
< Transfer-Encoding: chunked
< Server: Jetty(9.3.z-SNAPSHOT)
<
{
 "errors" : [ {
   "code" : "1200",
   "title" : "CLUSTER_NOT_FOUND",
   "detail" : "The cluster does not exist"
 } ]
* Connection #0 to host localhost left intact```

[5:03]
At which time I jumped windows and saw the stuff I posted earlier


chore: remove unused vars

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Context

[x] Fix [@vue/compiler-sfc] defineProps is a compiler macro and no longer needs to be imported. for nuxt3
[x] Fixes @typescript-eslint/no-unused-vars and force it to error

Copilot Summary

🤖 Generated by Copilot at 52ee20e
The pull request removes unused code, imports, variables, and parameters from various files to improve code quality and performance. It also updates the ESLint configuration to use a newer version of ECMAScript and to check for unused variables in TypeScript code. Additionally, it adds comments to disable a linting rule for some unused variables that are placeholders for future features. It also renames a deprecated test file and makes some minor changes to the generative minting logic.

🤖 Generated by Copilot at 52ee20e

Sing, O Muse, of the valiant code reviewers who purged the files
Of unused imports, variables, and parameters, those cunning scribes
Who, like Zeus hurling his thunderbolts, struck down the linting errors
And, like Athena weaving her tapestry, wove comments for future bearers

let's resolve conflicts and merge @preschian


Allow routes to have extra options

Right now, datasette routes can only be a 2-tuple of (regex, view_fn).
It was possible for datasette to handle extra options, like standard Django does, it would add flexibility for plugin authors.
For example, if extra options were enabled, then it would be easy to make a single table the home page #1284. This plugin would accomplish it.
from datasette import hookimpl
from datasette.views.table import TableView

@hookimpl
def register_routes(datasette):
        return [
        (r"^/$", TableView.as_view(datasette), {'db_name': 'DB_NAME',
                                                'table': 'TABLE_NAME'})
    ]

This all looks promising! I will need detailed documentation on how to upgrade datasette once it's available, and how to implement. (@fgregg example looks very straightforward on the plugin front.)
I'll be so excited if I can get:
https://list.saferdisinfectants.org/
instead of
https://list.saferdisinfectants.org/disinfectants/listN

A nudge on this.


conf: drop meta-yocto layer

The meta-yocto layer has be dropped for Yocto since poky commit
145c245a56ff [meta-yocto: Drop meta-yocto directory] so we need to
drop the associated line from the bblayers.conf.sample file.
Signed-off-by: Mark Asselstine<EMAIL_ADDRESS>

merged


Separate grader/submitter ("submit" command) from the runner program

The submitter logic is not tied to spec files at all. We should extract this out to a separate program. A benefit is that this submitter can be reused by other applications.

This is included in #152


Document (more prominently?) that serde_json allows sequences to be deserialized into structs

Last time I saw this was https://old.reddit.com/r/rust/comments/1332t9b/ji7oo8m/, but I've also seen it earlier and found it surprising both times.
Basically both {"hello": "test", "value": 42} (expected) and ["test", 42] deserialize perfectly fine into the following struct:
#[derive(Serialize, Deserialize)]
pub struct HelloParams {
    hello: String,
    value: i32,
}

Since this is not mentioned anywhere, this can accidentally become a used API when serde is used to parse JSON (Hyrum's law).
It would be nice if this could be featured somewhere prominently in the docs. I couldn't actually find it there, even looking for it.

Probably serde_json should not call visit_seq if deserialize_map / deserialize_struct was requested by the type. Then deserialization structs from JSON arrays would be impossible. That also can be a configurable behavior of serde_json deserializer.

Actually, this is duplicate of #1587.

I don't see how this is a duplicate, @oli-obk. This is about documenting behavior of serde_json, not about changing it. The other issue asks for behavioral changes that are likely backward incompatible and thus unlikely to happen.


use latest temurin 8 jdk instead of 8u312

This PR will make the java 8 image use latest Temurin Java 8 JDK instead of using 8u312

This PR will make the java 8 image use latest Temurin Java 8 JDK instead of using 8u312

It was hard locked for a reason , read the comment in the Dockerfile


Tutorial: undo but no redo

Describe the bug
In the tutorial you can undo the last changes.
But it's not possible to redo the undone - which would be the intuitively expected behavior from my point of view (at least for me).
Reproduction

open svelte tutorial
write something into the code editor
press CTRL+Z (undo)
press CTRL+Y to see that nothing happens

Logs
No response
System Info
- Win 10
- Firefox 116.0.1 (64-bit)

Severity
annoyance

Redoing changes works for me (on Windows 11 Firefox) so I think this issue is outdated and should be closed


add support of basic file descriptors

To generalize the interface to the hardware, UNIX-like file descriptors is introduced. As long term solution, file descriptors are also used for sockets and other I/O interfaces.

I created https://github.com/hermitcore/rusty-hermit/pull/385 to resolve the CI failure.

Thanks! Now it works!


Make CI 3x faster

Motivation
Already approved and tested here: https://github.com/ProvableHQ/snarkVM/pull/8

Any reason we shouldn't just set them to 1 or 5 or 10?

No valid reason, agree with @gluax ' comment and its worth investigating a refactor in the future. Somewhat related: there are some heavy #[ignore]'d tests which could potentially also fit in a separate fuzzing / CI / integration testing flow.


Needs README

How do I get started?

added readme here: https://github.com/AmiStrn/opensearch-plugin-template/pull/7
@dblock please let me know if this is enough to get started with:)


Generate proper filenames

Should be possible to add some form of detection based on addresses (as seen in TFEhpLoader).

done in https://github.com/xan1242/EHPScanner/commit/d23a0b8935d801a5ee10e3d834022a8b8b1dc6ea


ZEP-18: Add cloudbuild kubectl

This repo comes with a cloudbuild.yaml. But it takes time to run due to the docker build of all 10 images.
This PR adds a cloudbuild-kubectl.yaml file to deploy the applications with pre-built container images

@cc-nadzir This will need to be done in the context of the cldcvr.yaml format that is being defined by @petmal - probably you guys should sync up on this.
One other Q - I thought the microservices-demo used skaffold to build/deploy?

sure. will sync up with him.
oh there's several options to deploy the app.
the kubectl seems to be the fastest as there is no need to rebuild the docker images
Option 3: Using Pre-Built Container Images
💡 Recommended if you want to deploy the app faster in fewer steps to an existing cluster.

oh there's several options to deploy the app.
the kubectl seems to be the fastest as there is no need to rebuild the docker images
Option 3: Using Pre-Built Container Images
💡 Recommended if you want to deploy the app faster in fewer steps to an existing cluster.

Right - I guess we need to find out if the requirement is deployment time or if we are trying to show that the containers are being built from scratch and then deployed - need to clarify this with @vizkid

moving this to vanguard repo


feat!: price-feeder: add the ability to configure asset deviation thresholds

Description
Adds a field in our config which allows validators to configure how many standard deviations away from the mean they want to allow prices to be for a given asset.
closes: #977

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Please note @RafilxTenfen this will change the interface of the price feeder that peggo uses - when we release another price feeder version, just let me know and I'll help with the peggo update

@adamewozniak What do you think about having a max value for the standard deviations ?

@adamewozniak What do you think about having a max value for the standard deviations ?

Good idea, I'll max it out at 3 @RafilxTenfen

@adamewozniak What do you think about having a max value for the standard deviations ?

Good idea, I'll max it out at 3 @RafilxTenfen

Added in 430a3f47d67d5f00e176ac552ef47cae31475329 @RafilxTenfen 🎊

@Mergifyio backport release/price-feeder/v0.2.x


libapache2-mod-php5, php5-mysql no installation candidate

I recently got error's trying to build this Dockerfile. Shown below:
$ docker build --rm -t mutzel/all-in-one-hackazon .
Sending build context to Docker daemon 79.87 kB
Step 1/25 : FROM ubuntu:latest
latest: Pulling from library/ubuntu
8aec416115fd: Pull complete
695f074e24e3: Pull complete
946d6c48c2a7: Pull complete
bc7277e579f0: Pull complete
2508cbcde94b: Pull complete
Digest: sha256:71cd81252a3563a03ad8daee81047b62ab5d892ebbfbf71cf53415f29c130950
Status: Downloaded newer image for ubuntu:latest
 ---> f49eec89601e
Step 2/25 : MAINTAINER Chris Mutzel<EMAIL_ADDRESS> ---> Running in d3a6bc3ba9e4
 ---> ebc13a270c89
Removing intermediate container d3a6bc3ba9e4
Step 3/25 : RUN apt-get update # Fri Oct 24 13:09:23 EDT 2014
 ---> Running in 1ecb1f4e5206
Get:1 http://archive.ubuntu.com/ubuntu xenial InRelease [247 kB]
Get:2 http://archive.ubuntu.com/ubuntu xenial-updates InRelease [102 kB]
Get:3 http://archive.ubuntu.com/ubuntu xenial-security InRelease [102 kB]
Get:4 http://archive.ubuntu.com/ubuntu xenial/main Sources [1103 kB]
Get:5 http://archive.ubuntu.com/ubuntu xenial/restricted Sources [5179 B]
Get:6 http://archive.ubuntu.com/ubuntu xenial/universe Sources [9802 kB]
Get:6 http://archive.ubuntu.com/ubuntu xenial/universe Sources [9802 kB]
Get:7 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages [1558 kB]
Get:8 http://archive.ubuntu.com/ubuntu xenial/restricted amd64 Packages [14.1 kB]
Get:9 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages [9827 kB]
Get:9 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages [9827 kB]
Get:10 http://archive.ubuntu.com/ubuntu xenial-updates/main Sources [279 kB]
Get:11 http://archive.ubuntu.com/ubuntu xenial-updates/restricted Sources [2392 B]
Get:12 http://archive.ubuntu.com/ubuntu xenial-updates/universe Sources [152 kB]
Get:13 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages [590 kB]
Get:14 http://archive.ubuntu.com/ubuntu xenial-updates/restricted amd64 Packages [12.0 kB]
Get:15 http://archive.ubuntu.com/ubuntu xenial-updates/universe amd64 Packages [488 kB]
Get:16 http://archive.ubuntu.com/ubuntu xenial-security/main Sources [68.5 kB]
Get:17 http://archive.ubuntu.com/ubuntu xenial-security/restricted Sources [2392 B]
Get:18 http://archive.ubuntu.com/ubuntu xenial-security/universe Sources [20.5 kB]
Get:19 http://archive.ubuntu.com/ubuntu xenial-security/main amd64 Packages [257 kB]
Get:20 http://archive.ubuntu.com/ubuntu xenial-security/restricted amd64 Packages [12.0 kB]
Get:21 http://archive.ubuntu.com/ubuntu xenial-security/universe amd64 Packages [87.9 kB]
Fetched 5978 kB in 6min 11s (16.1 kB/s)
Reading package lists...
 ---> 5456e8e9c1fd
Removing intermediate container 1ecb1f4e5206
Step 4/25 : RUN apt-get -y upgrade
 ---> Running in cc48da9a56d0
Reading package lists...
Building dependency tree...
Reading state information...
Calculating upgrade...
The following packages will be upgraded:
  apt libapt-pkg5.0 libsystemd0 libudev1 systemd systemd-sysv
6 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 5778 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 libapt-pkg5.0 amd64 1.2.19 [707 kB]
Get:2 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 apt amd64 1.2.19 [1042 kB]
Get:3 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 libsystemd0 amd64 229-4ubuntu16 [205 kB]
Get:4 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 systemd amd64 229-4ubuntu16 [3756 kB]
Get:5 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 systemd-sysv amd64 229-4ubuntu16 [12.7 kB]
Get:6 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 libudev1 amd64 229-4ubuntu16 [55.2 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 5778 kB in 27s (210 kB/s)
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../libapt-pkg5.0_1.2.19_amd64.deb ...
Unpacking libapt-pkg5.0:amd64 (1.2.19) over (1.2.18) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
Setting up libapt-pkg5.0:amd64 (1.2.19) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../archives/apt_1.2.19_amd64.deb ...
Unpacking apt (1.2.19) over (1.2.18) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
Setting up apt (1.2.19) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../libsystemd0_229-4ubuntu16_amd64.deb ...
Unpacking libsystemd0:amd64 (229-4ubuntu16) over (229-4ubuntu13) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
Setting up libsystemd0:amd64 (229-4ubuntu16) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../systemd_229-4ubuntu16_amd64.deb ...
Unpacking systemd (229-4ubuntu16) over (229-4ubuntu13) ...
Setting up systemd (229-4ubuntu16) ...
Initializing machine ID from random generator.
addgroup: The group `systemd-journal' already exists as a system group. Exiting.
Operation failed: No such file or directory
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../systemd-sysv_229-4ubuntu16_amd64.deb ...
Unpacking systemd-sysv (229-4ubuntu16) over (229-4ubuntu13) ...
Setting up systemd-sysv (229-4ubuntu16) ...
(Reading database ... 7256 files and directories currently installed.)
Preparing to unpack .../libudev1_229-4ubuntu16_amd64.deb ...
Unpacking libudev1:amd64 (229-4ubuntu16) over (229-4ubuntu13) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
Setting up libudev1:amd64 (229-4ubuntu16) ...
Processing triggers for libc-bin (2.23-0ubuntu5) ...
 ---> 16593a4143cf
Removing intermediate container cc48da9a56d0
Step 5/25 : RUN DEBIAN_FRONTEND=noninteractive apt-get -y install mysql-client mysql-server apache2 libapache2-mod-php5 pwgen python-setuptools vim-tiny php5-mysql  php5-ldap unzip
 ---> Running in 80f95d6c708a
Reading package lists...
Building dependency tree...
Reading state information...
Package libapache2-mod-php5 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package php5-mysql is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'libapache2-mod-php5' has no installation candidate
E: Package 'php5-mysql' has no installation candidate
E: Unable to locate package php5-ldap
The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive apt-get -y install mysql-client mysql-server apache2 libapache2-mod-php5 pwgen python-setuptools vim-tiny php5-mysql  php5-ldap unzip' returned a non-zero code: 100

Hey,
This image have a lot of issues but you can build it by replacing :
FROM ubuntu:latest
By
FROM ubuntu:14.04
Regards,
Pierrick


found illuminate/console[v9.0.0-beta.1, ..., 9.x-dev] but these were not loaded

Larastan Version: 2.0
--level used: dev
Pull request with failing test: N/A
PHP version: 8.1
Server: Apache 2.4 + nginx
OS: Windows 10
Development environment: local
Commands issued as: administrative privileges console or non-administrative.

Description
On a fresh Laravel 10.10 project created by: composer create laravel/laravel test.local while trying to install Larastan 2.0 I got the following message;
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires nunomaduro/larastan 2.0 -> satisfiable by nunomaduro/larastan[2.0.0].
    - nunomaduro/larastan 2.0.0 requires illuminate/console ^9 -> found illuminate/console[v9.0.0, ..., v9.52.15] but these were not loaded, likely because it conflicts with another require.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Retried creating multiple times the project using alternative method: Laravel new test.local and still got the same issue but any other module required by the project got installed (e.g. filament, pint etc)

Try installing a newer version of Larastan
composer require --dev "nunomaduro/larastan:^2.0"

Well, I've tried issuing the suggested command and got still the same reply.
Any other ideas or suggestions? I am not sure why but I've tested on few spare PCs I have at home by just installing npm/composer, creating a new project and trying to install larastan and they all failed the same way stating that I have the required illuminate/console but it is not loaded because of some conflict.

OS: Windows 10

Oh no!
The caret character may be misinterpreted on Windows.
Could you edit composer.json directly?


analyze SOR results

Need to analyze the collected SOR metrics.
Is the new SOR faster?
Is the new SOR performant in terms of CPU/MEM? Do we need to decouple?
How do they compare for swap performance? (it's expected that v1 is better, but how much worse is v2?)
Strange routes:
1 wFTM>BEETS (3.9% price impact, through 6 pools)
1 COMB>BEETS (convoluted route, could be simpler with better price)
check whether this is sor v1 or v2

above results are from sor v2, sor v1 broke with DB schema changes we did before christmast...
need to investigate why it routes through such strange pools for 1wftm->beets

waiting until a fix for getNormalizedLiquidity is in place

Finally found time to analyze results. Swaps from March 26-29 (4 days) have been analyzed, total of 270k swaps:

v1 was better
115937
42.38%

v2 was better
157633
57.62%

no v2 result
24820
9.07%

no v1 result
37709
13.78%

v1 was faster
16491
6.03%

v2 was faster
256829
93.88%

total
273570
100.00%

I'll investigate the cases where v2 did not yield a result and see if we can bring down that number (although I think 9% is already good)

tracked under #311


enable sidebar collapse feature

Explanation
I made the sidebar collapsible, so users can focus better on the content.
What type of PR is this
Additional features

Nice work. Thank you so much! @Mackenzie-OO7

Could we choose sidebar collapse or not freely?

Yes we can 😅


All golang types to be highlighted the same

Custom types/structs are syntax highlighted in white whereas the primitive/built-in types are highlighted in the usual turquoise-ish green, I believe that it would make more sense for all types to be the same (turquoise-ish green) colour
P.S. I was thinking of posting this issue in bug reports but I am unsure if it is a bug or intentional
P.P.S I am using the default Dark + theme

Can you add a small code sample?


Do not log failing fetch retry attempts

It's annoying for the user to see all the retries done by our retrying-fetch under the hood, especially with the so frequent SocketError we still have. We should only show an error if all retries have been consumed.
Requested on Discord along with #2007

QoL request re: makeFetch errors
when testing, I send a tx that I know will fail. it will print the error foundation:retry ERROR Error: Assertion failed: '...' three times via the makeFetch retry. This doesn't have any positive purpose IMO since the ts interface will throw an error for the dev to handle. It should probably also short-circuit the retry loop if the error is Assertion failed:
the fetch failed error SocketError: other side closed is common and clutters the cli too. Instead of logging this error, it should just throw if all retries fail and let the dev handle it
I know the api optionally takes DebugLogger but I am not providing it. I think the ideal situation would be to log retry errors only if the debug logger is provided.

Fixed in #2015


Generated code for string array query parameter is not right

What version of kubb is running?
2.23.2
What platform is your computer?
Windows
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
"@kubb/plugin-oas": "^2.23.2",     "@kubb/swagger-client": "^2.23.2",     "@kubb/swagger-ts": "^2.23.2",

What steps can reproduce the bug?
We have an openapi-file that defines a query parameter "ids" that is a string array.
Kubb correctly defines the field for that query parameter as string[] but when the request is made, the query parameter looks like this &ids[]=12&ids[]=1234 what is not accepted by the respective endpoint.
How often does this bug happen?
Every time
What is the expected behavior?
Openapi parameter serialization for query parameter is working correctly.
Swagger/OpenAPI file?
  /tests:
    get:
      operationId: getTests
      parameters:
        - in: query
          name: ids
          required: false
          schema:
            type: array
            items:
              type: string
              format: uuid
      responses:
        200:
          description: OK
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/TestPaginated'

Additional information
No response

Thank you for that hint!
Now it works 👍


Documentation: package name in README.md Migration section is wrong.

Environment details

Specify the API at the beginning of the title (for example, "Places: ...") [documentation, n/a]
OS type and version [n/a]
Library version and other environment information [n/a]

Steps to reproduce

check https://github.com/googlemaps/js-markerclusterer/blob/main/README.md
the first sentence refers to<EMAIL_ADDRESS>twice -- the first one should probably refer to the current package instead.

@yuethomas Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.


Add doc string to lifted functions

I noticed that the lifted function had no docstrings,
with this change they get

I don't know, why the build fails.
Seems to be unrelated to my tiny change.

I'll check it today. Fail seems to be unrelated to your change.


The notification modal not clearing previous notifications.

9af13ffc
When i updated the bus status continuously to 10 or more , the clear button in notification modal hides somehow, please see to it.
Also and you need to check , when i am logged in  in as coordinator_ in one instance, and someone on diff side logged in as student both belonging to same bus say 8840, notifications of coordinator must not been available on students notification modal.

Scenario : Driver of 8840 pushes breakdown , only the coordinator 's notification modal should receive this notification msg.

We need to create separate socket channels for that..this is a test version showing how the notifications will work.

Modal clear notifications that are less than 10..it hides the clear button bcz modal doesnt have a scroll controller..i wil implement the scroll in it soon


about Mi Humidifier

Recently, I got a Mi Humidifier and making a homebridge plug-in.
All functions you developed works fine. but I can't find the function to control Target Humidity.
Is there any functions to read or write current TARGET Humidity - not the sensor value but user selected value - ?
Please let me know.

I don't actually know what command controls the target humidity. I'm very interested in adding support for it. Did you figure out which protocol commands that control the target?

Hi Nunobet,
I'm very interested in Mi Humidifier homebridge plug-in. Is it possible for you to share it?


It keeps saying "Nothing found after 50 attempts, Shutting down"

Title.
log file here:
http://pastebin.com/Hua4ER3i
Tried multiple options for wallpapers selection "top week/day/month"
I'm only pulling from /r/wallpapers, and i have windows 10
Yet the app still works but still throws the notification.

Looking at the log file, it looks like most wallpapers it's pulled have already been used.
At the moment, RWC treats that as a failed attempt to grab a new paper. Closing/reopening to clear the history will sort it, or disable the 'Suppress duoplicates' option. Long term I think I'll just do away with the 50 retrys cap.


Updated to work with the latest version of sentence transformers

The latest version of sentence transformers changed the arguments to the _load_sbert_model and changed the download system. This is a small update to make it compatible.

cc @hongjin-su I haven't tested this myself, but this seems quite important to prevent the critical failures currently encountered when installing, e.g. #106.
For others, I would recommend the following:
pip install git+https://github.com/SilasMarvin/instructor-embedding.git@silas-update-for-newer-sentence-transformers

After which your code should work with the most recent Sentence Transformers version again.

Tom Aarsen

Hello @SilasMarvin
First, thanks for this fork and thanks to @tomaarsen for pointing it out.  I'd been trying to get instructor models to work with sentence-transformers library ever since they started updating it in January after not issuing a new release in a few years.  Have you gotten response from the maintainers of instructorembedding?  I've found them to be unresponsive and/or unhelpful.  Apparently, their library was created as part of some college project in Washington State (my home state BTW) and presumably they've moved onto real jobs.  ;-)
Regardless of the reason, I've asked sentence-transformers to update their code instead and perhaps you could help?  This is not my expertise...  Here's a link to our discussion.  Again, thanks for this fix...
https://github.com/UKPLab/sentence-transformers/issues/2567

Hey! @BBC-Esq I have not gotten any response from the maintainers. This honestly is not the best fix. The new version of sentence-transformers has some nice utilities for loading in files and managing different versions which I did not implement, but this should work as a hot fix for people having issues. I'll take a look at the discussion!

Hey! @BBC-Esq I have not gotten any response from the maintainers. This honestly is not the best fix. The new version of sentence-transformers has some nice utilities for loading in files and managing different versions which I did not implement, but this should work as a hot fix for people having issues. I'll take a look at the discussion!

Please do take a look, and thanks again.  I think you'll understand my challenge.

This is great, I hope it could get merged.

Thanks for all your help! I will merge it after conflicts are resolved.

Thanks for all your help! I will merge it after conflicts are resolved.

Awesome! Conflicts resolved

@hongjin-su will there be a new PyPi release soon?
Also for anyone who needs this fix in the meantime, you can pin this:
git+https://github.com/xlang-ai/instructor-embedding.git@5cca65eb0ed78ab354b086a5386fb2c528809caa

Please a new pypi release.  These maintainers are slow to act.

@SilasMarvin I just realized one thing: the  https://github.com/UKPLab/sentence-transformers/blob/66e0ee30843dd411c64f37f65447bb38c7bf857a/sentence_transformers/util.py#L544 from which you took the code includes the https://github.com/UKPLab/sentence-transformers/blob/66e0ee30843dd411c64f37f65447bb38c7bf857a/sentence_transformers/util.py#L552-L554 too which lets you use the model locally without the connection to the internet, is there any reason why it's not included or why you haven't used the load_dir_path directly?

Is this why when I specify a path on my computer it gives an error saying it's not a correct repository ID on huggingface or what not?

It's not working, so i did this pull request to try and make it work.  TO BE CLEAR, however, I don't think this addresses @racinmat 's message:
Here's my pull request:
https://github.com/xlang-ai/instructor-embedding/pull/113

My most recent pull request solves it

yes, exactly, that's why it complains about the repository ID, because it went straight to the validation without prior check for local drive


Failing deepcopy test

Test corresponding to issue https://github.com/giacomov/hawc_hal/issues/1, the point source one succeeds, the extended source one fails.

Travis test 59.2 fails once as intended.
I don't understand the many failures in Travis test 59.1.

This is ready for merging AFAIK.


Cannot replace single character, when using regexp

Describe the bug
Cannot replace selected number character at field
To Reproduce
Regexp allow to input single number, or two numbers in a field.
Input single number, then select it with a mouse (by double click),
then try to input new number.
Expected behavior
Should replace current one, but it doesn't work
Live example
https://embed.plnkr.co/22ypXV9CybCQ0WdW56cx/

doesnt reproduce on raw plugin, without my own modifications


Bump version to 2022.501.0

Lots of commits for the database structure alone.

Bumping version now

Update complete.


make it to swap

I've already spent a lot of time, but anyway I couldn't make it to  swap the dragged item with the item where it dropped. Now, as I drag the item, each next one items' position changes to 'current-1'.
Need get exactly as in this example:
http://htmlpreview.github.io/?https://github.com/fatlinesofcode/ngDraggable/blob/master/example-reorder.html

@AlbertHambardzumyan you need this only within one bucket? i.e one sortable list.

yes, one vertical list

right now this is not supported, but this can be doable. by providing an option.

@a5hik can you give me an idea on how to I achieve this? I want to swap the source and dest index before saving.

+1


[MB-6615] uncommented out line in prime-api-demo script

Description
This PR uncomments out a line in the script that creates the DDFSIT service item
Setup
make db_dev_e2e_populate && make server_run
make client_run
prime-api-demo 9c7b255c-2981-4bf8-839f-61c7458e2b4d

Go through the flow up to the point where the service items are created. In the office app and the TOO view, find the move with the move code RDY4PY. Navigate to the Move Task Order tab and ensure that Dom. Destination First day SIT has been added to the move
Acceptance
Run in staging

Messages

:book:
:link: MB-6615

  Generated by :no_entry_sign: dangerJS against 29c2a5d20c7bafd0b0b3ad76fc23459b5e6baea3


[Draft] FIPS tests added for gnutls library

[CI:TOXENVS] fips
fixes #495

@rcmadhankumar why did you revert https://github.com/SUSE/BCI-tests/pull/574?

@rcmadhankumar why did you revert #574?

PR itself was buggy. i merged it without testing.

created a clean PR: https://github.com/SUSE/BCI-tests/pull/578

@rcmadhankumar if you update the branch (usually with -f if you change history) for a given PR, the PR gets updated. No need to create multiple PRs. It just confuses what I'm supposed to review.


Skin Issue

Buenas Tardes a todos.
Mi problema con el mod es que la armadura de O-yoroi, especificamente el casco, no permite visualizar mi skin. Probe quitando el optifine y tampoco se ve. Alguno sabe como arreglar esto y cual es la causa? Tengo otros mods agregados como el Mo´bends, pero no resulto ser el problema y ya lo quite para probar si era este el problema.
/////
Good afternoon everyone.
My problem with the mod is that O-yoroi's armor, specifically the helmet, doesn't allow me to see my skin. I tried removing the optifine and it doesn't show either. Does anyone know how to fix this and what is the cause? I have other mods added like Mo'bends,
but it did not turn out to be the problem and I already removed it to test if this was the problem.

Hey !
I'm not sure to understand your problem. Can you show me a screenshot ?

Yes sir, but Im not at home now. In 4 hours I will so, when I come back Ill
post it
El vie., 1 de julio de 2022 1:37 p. m., Poulpinou @.***>
escribió:

Hey !
I'm not sure to understand your problem. Can you show me a screenshot ?
—
Reply to this email directly, view it on GitHub
https://github.com/Poulpynou/dawnoftimebuilder/issues/23#issuecomment-1172572297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ4D355EQXVXPHA2VCW7ACTVR4UEVANCNFSM52NK623Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey ! I'm not sure to understand your problem. Can you show me a screenshot ?

apparently it's not just that mod, it happens with others too.

Ho you are using an animation mod ! Is it Epic Fight Mod ? Anyway, custom armors are not compatible with these mods.
I talked to the developper of EFM and this problem will be fixed in 1.18. There wont be a fix for 1.16

Ho you are using an animation mod ! Is it Epic Fight Mod ? Anyway, custom armors are not compatible with these mods. I talked to the developper of EFM and this problem will be fixed in 1.18. There wont be a fix for 1.16

Oh, well.


Cleanup timers so process shuts down cleanly

Part of T158248
/cc @wikimedia-services

Could also use a version bump so that it can be picked up in service-runner and upper deps.

Will do when I get this out of WIP

Needed for https://github.com/wikimedia/service-runner/pull/150

LGTM, @gwicke as an author of the library could you have a look to? it's now pretty pressing since it's needed for another PR.

LGTM overall. Minor naming proposal inline.
We should also document this method in the README.

We should also document this method in the README.

Added a line for that.


WARN - Azure Devops reports NODE must be upgraded  because v6 is deprecated

Azure Devops reports that the extension currently require Node 6.
This is EOL and developers must upgrade. Preferred latest maintained version which is 20.*
https://nodejs.org/en/download/package-manager
Error/Warning from Azure devops
##[warning]Task 'SonarCloud create project' version 1 (sonarcloud-create-project@1) is dependent on a Node version (6) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

In the latest release (v1.0.5), the task runner was updated to the newest Node version available within the agent environment (Node20_1). You can review the specific changes in PR #6


Re TokenizerStepContractions, TODO: this is slow. This should be handled in the Antlr grammar

The TODO comment was found in the code, so here is a reply.
It may be that these are somehow optimized away, but when regular expressions are involved I've sometimes had success speeding things up by moving them to the class or even object level.  So, instead of
  override def process(inputs:Array[RawToken]): Array[RawToken] = {
    for(input <- inputs) {
      else if ("""^[wW][oO][nN]'[tT]$""".r.findFirstIn(input.raw).isDefined) {

it might be
class TokenizerStepContractions extends TokenizerStep {
  val wont = """^[wW][oO][nN]'[tT]$""".r

  override def process(inputs:Array[RawToken]): Array[RawToken] = {
    for(input <- inputs) {
      else if (wont.findFirstIn(input.raw).isDefined)

This could prevent "recompilation" of the regular expression for every iteration of the loop.  The may also be a flag for case insensitive matching which could make the expressions more readable and could affect performance.  Alternatively, the input could be normalized to one case or the other.

Regular expressions are sometimes cached and looked up, probably based on the string that specified them, but just storing them in a variable would still eliminate the lookup.

Thanks! Good catch. I'll take a look soon.
If you already addressed this, please let me know.

It may need to go all the way to the pattern:
val eopPattern: Pattern = """^(\.?)(\s*)\n(\s*)\n(\s*)$""".r.pattern // End of paragraph

I may be suggesting an additional change for the benefit of Eidos that would justify a 0.0.1 version change.  They might be checked in at the same time.

I was revising the code in TokenizerStepContractions to make it faster, smaller, and simpler, but then I was worried about whether it was getting the correct or best answer anyway and then why it was doing this in the first place.  I think it is done to help other components figure out ambiguous contractions (e.g., 's may indicate possessive, is, has, or even does).  There are also some "productive" contractions that can go on almost anything (at least in speech), but which might without separation result in words out of vocabulary: "Shannon'll not be in today."  Shannon'll isn't in the dictionary, but both of the parts are.  I'm doubtful, though, because that theory doesn't hold for 've.  'd is separated and seems productive, but then it is also ambiguous (would or had and maybe did).
Anyway, here is a small list of problem cases:

let's might not be divided into let 's, but be kept whole or divided into "let us".  Which?
can't shouldn't be "ca not" but "can not"
ain't shouldn't be "ai not" but be left alone.  The ai is even ambiguous.
shan't shouldn't be "sha not" bit instead "shall not"
aren't has an exception in "aren't I" when it would be am and in general the word order with not would need to be changed in a question: aren't you -> are you not.  The tokenizer doesn't look at more than one word at a time and this is probably out of bounds.
It is possible to distinguish between genitive 's and non-genitive in some cases, but there is still ambiguity especially in British English, because it can mean is, has, or apparently even does (in why's, but perhaps only in speech).  In particular, he's, she's, it's, there's, and who's cannot be possessive because for that we have his, her, its, their, and whose.  In some cases it is not possessive because the thing can't possess: here's, how's,  when's, where's, which's, why's.  Since there is still ambiguity, the parts may still need to be separated: when's -> when is or when does.
Lists at places like grammerly and wikipedia think the 'd in that'd and what'd can only be would and where'd can only be did, but I'm not convinced.
Double contractions like we’d’ve and wouldn’t’ve aren't being handled.  They probably aren't encountered.

It seems safe to handle the first four of those.  Others like 've and 're are easy, but depend on the why.  Should they be changed to have and are?
FYI @MihaiSurdeanu

I think the line
            tokens += RawToken("will", input.beginPosition, input.endPosition)

is incorrect because it is changing the raw value to "will".  It should be more like
            tokens += RawToken(input.raw, input.beginPosition, "am")

in which the word is transformed to "am" while keeping the same raw value.

Thanks @kwalcock !

I agree with moving the regexes at object level.
The first parameter of RawToken should be the "raw" token, i.e., exactly what appears in the text. The last one is the normalized word. So, you might be right about the RawToken("will",...) situation, IF the original text says something else.
"'s" is indeed ambiguous. I struggled to do something intelligent there. If you have an idea, please let me know!
Double contractions are not that common, so I am Ok skipping them for simplicity.
The other cases should all be handled. If they're not, can you please add unit tests?

The new tests were placed in TestContractions rather than TestTokenizer.  If contractions are not expanded because of ambiguity, should "'ve" be changed to "have"?  I'm not aware of other possibilities there.

Yes, "'ve" should be "have".

Completed by #706


feat: add checksum verification for downloaded models

What does this PR do?
It display an error if the downloaded model has a different sha than the expected value
Screenshot / video of UI
On the models page

On the recipe page (it still shows the old error mesage with the double Something went wrong but it has been cleaned)

What issues does this PR fix or reference?
it resolves #977
How to test this PR?

change the sha value of a model in ai.json and download it. You should see an error

Rebased. Ready to be reviewed.

@jeffmaury updated

Moved the error displayed on the top as suggested by @axel7083 . TBH i preferred the error on the row as it was in line with desktop but as we rely on the top banner for showing the download in progress it makes sense to show it there