plot_prior_predictive() gives error "RuntimeError: The model hasn't been fit yet, call .fit() first"

Hello!
Using the example mmm notebook on the pymc marketing page, I created a basic model using the DelayedSaturatedMMM class.
I am able to .fit() the model and run through all the functions outlined in the notebook, however when I try to run .plot_prior_predictve() I get the above error. Any ideas why this may be?

You probably have to call model.sample_prior_predictive first, but the error message could be improved, you don't have to fit it first

Thanks for the reply @ricardoV94 .
It seems that calling sample_prior_predictive did not fix the issue. After digging into the plot_prior_predictive it appears that maybe it is related to this line?
It seems to be setting prior_predictive_data equal to self.prior_predictive? But it looks like my fitted model doesn't have the prior_predictive property. Calling mmm.prior_predictive() returns the same runtime error.
Replacing that line with the following worked for me me:
prior_predictive_data = mmm.sample_prior_predictive(X, combined=False)

This is because self.idata is always None at that part of the code, so self.prior_predictive will always raise the error (definitely an undesired behavior).
A work-around for now is to build the model manually, and then run plot_prior_predictive:
mmm.build_model(X=X, y=y.to_numpy())

with mmm.model:
    mmm.idata = pm.sample_prior_predictive()

mmm.plot_prior_predictive();

However, this solution doesn't work to solve the bug in the codebase, because everything is None at that time -- self.X, self.y and self.model. I'm not sure that's expected, or even desirable. WDYT @ricardoV94 ?

Thanks @AlexAndorra  this worked perfectly! Is this the only workaround at the moment?
If I understand correctly, X and y are only needed to get the dates and the preprocessed y to plot the target variable, so the data has not been preprocessed yet because that happens until we call the fit method and not calling build_model. Should we only use this workaround after fit then?
Just wondering if X and y need to be the X_train and y_train respectively to have the same length for other plots.

Thanks @AlexAndorra this worked perfectly! Is this the only workaround at the moment?
If I understand correctly, X and y are only needed to get the dates and the preprocessed y to plot the observed data, so the data has not been preprocessed yet because that happens until we call the fit method and not when we call build_model. Should we only use this workaround after fit then?
Just wondering if X and y need to be the X_train and y_train respectively to have the same length for other plots.

Hi @AlfredoJF
The X variable does make a difference as it will provide the information for scaling, media inputs, and control variables as well.
Since this is a regression model, the y is a function of X. For instance, having media inputs as zero will result in no media contributions in the prior predictive
A similar workflow comes from the lift tests integration:
mmm = DelayedSaturatedMMM(...)
mmm.build_model(X_train, y_train) # This does work with y_train = pd.Series now!
mmm.add_lift_test_measurements(...)
mmm.fit(X_train, y_train) # duplicated input as the build model

From https://github.com/pymc-labs/pymc-marketing/blob/916dce42b39c67ee3a04188ba492ac53f5e6504d/pymc_marketing/mmm/base.py#L256C72-L256C72:
def plot_prior_predictive(
        self, samples: int = 1_000, **plt_kwargs: Any
    ) -> plt.Figure:
        prior_predictive_data: az.InferenceData = self.prior_predictive

self.prior_predictive is None because pm.sample_prior_predictive() hasn't been called yet. This should be a relatively easy fix.
However, after a model has been fit, self.prior_predictive will get wiped from model.idata  due to how these properties are currently written in the base ModelBuilder class. We would need to prioritize https://github.com/pymc-labs/pymc-marketing/pull/414 for that one because it's not an easy fix.
In the meantime, to hack together a prior predictive plot, the internals of the above plotting method could probably be copy/pasted into a notebook and tweaked into a solution.


CRLF line endings make this unusable on UNIX systems

Trying to use Hammer on a UNIX system (macOS Monterey) throws this error:
$ hammer
env: node\r: No such file or directory

The CRLF line endings cause env to be unable to find node, instead it strips the \n character but leaves the \r.
See https://stackoverflow.com/questions/29045140/env-bash-r-no-such-file-or-directory.
The fix appears to be as easy as using LF line endings instead of CRLF.
The same issue exists in Smoke-Task.

I am using hammer on an every day basis on both Mac OSX Monterey and Linux, so what you are describing is most likely unrelated to hammer.

Hm, I'm not sure what the underlying cause of this issue is then. I tested a few different shells (fish, zsh, bash) on the same system and all of them had the same issue.

what happens when you enter 'node -v' on a console?

@jonahsnider Hi! Would you be willing to submit a PR for the LF update? Unfortunately, I don't have access to OSX to test locally, but may look at setting up GH Action around this in future.
You should be able to test locally by running the following on the fresh clone of the project.
$ npm install
$ npm run install_cli       # install hammer globally
$ hammer version            # test it

Cheers
S

what happens when you enter 'node -v' on a console?

The node version gets printed. This isn't the issue, the node binary itself isn't even being run because env thinks you're trying to run node\r.

@jonahsnider Hi! Would you be willing to submit a PR for the LF update?

#6


fix: test 3

Description
fix: test 3

💔 All backports failed

Status
Branch
Result

❌
release/v0.54
Backport failed because of merge conflictsYou might need to backport the following PRs to release/v0.54: - fix: test 2 (#71)

Manual backport
To create the backport manually run:
backport --pr 74

Questions ?
Please refer to the Backport tool documentation and see the Github Action logs for details

💔 All backports failed

Status
Branch
Result

❌
release/v0.54
Backport failed because of merge conflictsYou might need to backport the following PRs to release/v0.54: - fix: test 2 (#71)

Manual backport
To create the backport manually run:
backport --pr 74

Questions ?
Please refer to the Backport tool documentation and see the Github Action logs for details

💚 All backports created successfully

Status
Branch
Result

✅
release/v0.54

Questions ?
Please refer to the Backport tool documentation and see the Github Action logs for details


Allowed displaying all matching results

Summary
Allows displaying all search results, not just those starting with saerch term
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-51197
Fixes https://mattermost.atlassian.net/browse/MM-30399
Related Pull Requests

Has server changes - https://github.com/mattermost/mattermost-server/pull/22466

Release Note
NONE

Closing this in favor of mono-repo PR at - https://github.com/mattermost/mattermost-server/pull/22505


"redux-oidc/USER_EXPIRED" after "persist/REHYDRATE" in new tab

My setup
I Have followd the example to implement this with a reactjs webapplication. I'm using redux with redux-persist to persist and rehydrate my store for offline storage and ment to keep users logged in with in the webapp.
Im not using the middleware do to more issues
Configure store
/redux/config/index.js
import createHistory from "history/createBrowserHistory";

import configureMiddleware from "./configureMiddleware";
import configurePersist, { persistConfig } from "./configurePersist";
import configureReducers from "./configureReducer";
import configureStore from "./configureStore";
import configureSaga, { sagaMiddleware } from "./configureSaga";
import configureMiddleware, { userManager } from "./configureUserManager";
import { initializeState } from "../modules";
import { rootSaga } from "../sagas";
import { loadUser } from "redux-oidc";

export const configure = () => {
  try {
    const reducer = configureReducers(persistConfig);
    const history = createHistory();
    // const { userManager, oidcMiddleware } = configureUserManager();
    const { middleware } = configureMiddleware(
      history,
      sagaMiddleware,
      // oidcMiddleware
    );
    const { store } = configureStore(initializeState, reducer, middleware);
    const { persistor } = configurePersist(store, () => {
      configureSaga(rootSaga);
      loadUser(store, userManager); // <===== loading user after "persist/REHYDRATE"
    });

    return { reducer, history, middleware, store, persistor, userManager };
  } catch (error) {
    console.error(error);
  }
};

/redux/config/configureReducer.js
import { persistCombineReducers } from "redux-persist";

import { routerReducer } from "react-router-redux";
import { localeReducer } from "react-localize-redux";
import { reducer as oidcReducer } from 'redux-oidc';

import { appReducer } from "../modules";

export default (config, injectedreducer: any) => {
	return persistCombineReducers(config, {
		router: routerReducer,
		locale: localeReducer,
		oidc: oidcReducer,
		app: appReducer,
		...injectedreducer
	});
};

/redux/config/configurePersist.js
import { persistStore, persistReducer} from "redux-persist";

import localforage from 'localforage'

export const persistConfig = {
	key: "root",
	storage: localforage
};

export default (store: any, doneCallback) => {
    const persistor = persistStore(store, null, doneCallback);
    return { persistor }
};

/redux/config/configureUserManager.js
import createOidcMiddleware, { createUserManager } from "redux-oidc";

const config = {
....
};

export const userManager = createUserManager(config);

export default () => {
  const oidcMiddleware = createOidcMiddleware(userManager);

  return { userManager, oidcMiddleware };
};

/index.js
import React from "react";
import ReactDOM from "react-dom";

import { Provider } from "react-redux";

import { PersistGate } from "redux-persist/es/integration/react";

import { ConnectedRouter } from "react-router-redux";

import { configure } from "./redux/config";

import { OidcProvider } from "redux-oidc";

import App from "./App";
import registerServiceWorker from "./registerServiceWorker";

import services from "./services";

import "./scss/style.scss";
import "./index.css";

let { history, store, persistor, userManager } = configure();

ReactDOM.render(
  <Provider store={store}>
    <OidcProvider store={store} userManager={userManager}>
      <PersistGate loading={null} persistor={persistor}>
        {/* ConnectedRouter will use the Store from Provider automatically */}
        <ConnectedRouter history={history}>
          <App store={store} />
        </ConnectedRouter>
      </PersistGate>
    </OidcProvider>
  </Provider>,
  document.getElementById("root")
);
registerServiceWorker();

/package.js
{
....
    "react": "16.0.0",
    "redux": "^3.7.2",
    "redux-persist": "^5.9.1",
    "redux-oidc": "^3.0.0-beta.16",
....
}

My Issue
My login works fine and refresh page after login with works too.

But in a new tab or if I close and open my browser again I can see the rehydrate working setting the old sate of oidc with user, access_token, expires_at and more. But it fails after loding user do to "redux-oidc/USER_EXPIRED" and sets user to null.

The expires_at is set to one hour after granted access token and I know in fact that i has not expierd do to its the same expires_at as the other tab and it has not gone one hour beetween tab switching.
Question
Why whould this happen and/or am I misunderstanding somthing?

After reading your i see that loadUser just uses getUser() from oidc-client:s user manager instead of getting it from redux store. Thats probobly why. But dosent that lose the whole purpose of saving it to redux store? Im closing this one its not a bug just a undeveloped feature.
Closes#99

When the app is initially loaded, the user is undefined and the redux store is (usually) empty. By 'usually', I mean when the redux store is in-memory only. This is why we need the loadUser helper. I guess if you are using redux-persist, that you propably won't need to use loadUser to load the user info.
My guess is that when loadUser is called, the userManager tries to find user data in sessionStorage. Since it can't find any valid user data there, USER_EXPIRED is dispatched. Try your config without loadUser and see if it helps.

Any updates on this?

yes sorry it work

Your setup with redux-persist and localforage is interesting and something I haven't encountered before so I can't offer a definitive solution for your issue. However I hope to be able to give you a few pointers on where to look for possible solutions.
The most likely cause I see is that the userManager uses sessionStorage by default to store the user data (including the access token). Since sessionStorage is only active for a single tab, it explains why you need to log in again when you open a new tab. Luckily oidc-client offers settings for the user store where other storage mechanisms can be attached. Maybe implementing the user store to use localforage can solve the issue.
The loadUser helper function is used, as I've previously stated, to load existing user data to the store. When it is run right after the redux-store is created, it makes sure that existing user data is available to the app on startup and you don't have to worry about coming up with a manual solution. I'm faily confident that if you can configure the userManager to use localforage, the issue will get resolved. Best of luck!

I'll close this for now. Feel free to comment if the issue persists.


feat: integrate governance

Signed-off-by: Gregory Hill<EMAIL_ADDRESS>Integrate relevant governance packages into the parachain runtime. These include, pallet_democracy, pallet_council and pallet_membership.

Do we have a design document or something describes the desired governance?

We do have one here: https://docs.google.com/document/d/1nVS5OnNsBnPElmgc9ynDtJDuxxOmZHyLdsoHYIMn--s/edit?usp=sharing


Warning of out of bounds for uint32 when use zipline ingest

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:
Environment

Operating System: osx10.11
Python Version: python2.7
Python Bitness: ..
How did you install Zipline: pip
Python packages: ..

  A lot of data seem missing because of that weird uint32 limit:
zipline/data/us_equity_pricing.py:171: UserWarning: Ignoring 2366 values because they are
out of bounds for uint32:
               open     high      low    close       volume
date
2007-05-29  0.14200  0.14490  0.13780  0.13950<PHONE_NUMBER>
2007-05-30  0.13770  0.13900  0.13550  0.13850<PHONE_NUMBER>
2007-06-15  0.14690  0.14750  0.14400  0.14450<PHONE_NUMBER>
...
2017-02-15  0.06780  0.06885  0.06720  0.06777<PHONE_NUMBER>
2017-02-16  0.06818  0.06818  0.06759  0.06799<PHONE_NUMBER>
2017-02-17  0.06824  0.06824  0.06755  0.06793<PHONE_NUMBER>0

[2366 rows x 5 columns]
  winsorise_uint32(raw_data, invalid_data_behavior, 'volume', *OHLC)

Help please?

Hey @zhangzheng88 thanks for opening up this issue. The size limit has to do with some stuff in BColz (which you can look through if you're curious, in this repo)
Currently we don't support volumes that are larger than the size of uint32 (you can see that number with numpy (np.iinfo(np.uint32)), but we can keep this issue in the backlog and if we need to discuss changing the limit to something like uint64 then reference this issue again.

@FreddieV4 I have the same issue when I try to ingest data which on some dates is NaN. How should I treat this?

@JoaoAparicio where are you ingesting data from? My default action to something like that is just fillna(0) then ffill and then see what happens but I'm not sure why you're getting so many NaN values (missing some context here)

Seems the same int32 limit is hit for zipline ingest -b quandl - only for one date though:
Ignoring 1 values because they are out of bounds for uint32:
            open  high   low  close        volume  ex_dividend  split_ratio
2011-04-11  1.79  1.84  1.55    1.7  6.674913e+09          0.0          1.0
winsorise_uint32(raw_data, invalid_data_behavior, 'volume', *OHLC)

I think this issue comes from here https://github.com/quantopian/zipline/blob/master/zipline/data/us_equity_pricing.py#L139
The default behavior seems to be "warn" but I think that does not make sense for Volume since the major use cases for it should all be okay with a "bigger than big" answer.
I think the expected behavior should be more like constrain or coerce with the value being set to 2³²-1.
For instance, when used to evaluate slippage, max_int is a fine response even if the real number would have been 10 or 20 times that since the effect will be to fill even the largest possible order.
In the case of a strategy using Volume as a signal source, the effect would similarly have to be independent of just how many more than 2.147 billion shares were traded that day.
Regardless of what the actual number is, the meaning would still be "an extraordinarily large number of shares".

@zhangzheng88 @adegtyarev @freddiev4 @JoaoAparicio @amarin15
I have mentioned a temporary solution in a post and save the missing data.
Basically, replace 'uint32' with 'uint64' in those two files: us_equity_pricing.py and minute_bars.py

Has there been any other progress on this issue?  I cannot find any us_equity_pricing.py file.  Is it enough to replace all instances of uint32 by uint64 in minute_bar.py as @0xboz mentioned above?
More generally, is there a plan to support volumes which are larger than UINT32_MAX, or to just set larger volumes equal to UINT32_MAX when they are read in?

any update?

@.***邮箱联系我，谢谢！


Skip function arguments prefixed with _ in D417 check

These arguments have been marked private. As such,
it should be okay for the checker to not validate their
existence in the docstring,
Thanks for submitting a PR!
Please make sure to check for the following items:

[x] Add unit tests and integration tests where applicable.
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under tests/test_cases/ and add
it to the list under tests/test_definitions.py.
If you've added or changed a command line option,
you should probably add or change a test in tests/test_integration.py.
[ ] Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.
Fixes #438

@Nurdok review please :)

Please also add a release notes line.

@Nurdok done. Sorry for the late update. Holiday time.

@Nurdok bump


Clean up Content HTML

It's on seed.ts (in the future it will be a util that we'll use to clean data before updating the database with contributions)
Let's discuss what we should clean in the HTML that we are importing. We for sure want to leave all the HTML tags (p, ul, etc) but maybe we want to remove some stuff: some attributes? buttons? should we keep all links?
We should also have a basic styling for the HTML (tables, p, ul list, etc)
cc @amy-jung

I think we can start implementing a default sanitizer using https://github.com/apostrophecms/sanitize-html and then we can change the configuration to only have the tags and attributes we want, but at least in the meantime, we avoid things like XSS.

Sounds great! @damianmarti
It's a good start.

@damianmarti Also, I think we can remove the the "style" attr (The most important one) and maybe "class" too.
What do you think?

Let's index all the content from each HTML document, show a summary (or a small text around the searched term) for each document at the search result and then link to the original content. Something like Google does.
Sounds good to you?

Sorry @carletex , the previous comment was more related to https://github.com/amy-jung/collectivedaoarchives.catalog/issues/22 too. I was replying here, but thinking about this...


Remove unimplemented parameter extension points from HTML5 plug-in

The HTML5 plug-in declares two "parameter" type extension points:
  <extension-point id="dita.conductor.html5.param" name="XHTML XSLT parameters"/>
  <extension-point id="dita.conductor.html5.toc.param" name="HTML/XSLT XSLT parameter"/>

However, these can't be used because they aren't implemented in an Ant build template <xslt> step. That wasn't done (rightly, I think) because the HTML5 plug-in uses the base HTML Ant templates.

Implementing the missing extension-points would require duplicating the templates from the base HTML plug-in, which would be a maintenance problem and just bad generally.
Implementers who want to add parameters to the HTML5 transformation can instead:

require the base HTML plug-in as well as the HTML5 plug-in
extend the base HTML plug-in's parameter extension points

Keeping the un-implemented HTML5 extension points obscures that fact and creates confusion because implementers should rightly expect these extension points to work.

I'll submit a PR to remove these.

Closed with #2314

See also #2181.

Hmm - I did check with Jarno before adding this in to 2.2.5, and he was fine with it, while planning to re-implement these in 3.0.


Arrow Colour not changing

Is there a way to change the arrow color for the country picker.??

Use renderDropdownImage prop to display custom arrow image


[WebUI] Direct link to a torrent

[x] I have checked the existing issues to avoid duplicates
[x] I have redacted any info hashes and content metadata from any logs or screenshots attached to this issue

Is your feature request related to a problem? Please describe
It would be nice to be able to 'directly link' to a torrent based on a info hash.
Describe the solution you'd like
My bitmagnet is located at <IP_ADDRESS>, but if I have a info hash of a torrent, I would like to be able to quickly look it up with an URL like this:
http://<IP_ADDRESS>/#INFO_HASH#
This would be similar to how open DHT crawlers do it, for example BTDigg:
https://btdig.com/#INFO_HASH#
If I would host this publicly (or share internally), it would also be an nice way to share links, so one could inspect the files and size first.
Describe alternatives you've considered
Alternative is to do nothing and just let the user share a hash and search for it, which is 5 steps compared to 1 step (click on the link).

Go to the page
Copy the given hash
Paste the given hash
Press enter/hit the search/refresh icon
Click on the result to see info

Additional context
Low priority, more a QOL feature than a real necessity.

Agreed on this! At some point the web UI will become more than just a single page application - which is a bit of work in itself involving setting up Angular routing. I can think of plenty of stuff (including this) that would be great to expose as a dedicated URL in the UI. It'll be a case of prioritisation.
For me the single biggest win would be encoding the current search UI state into the URL allowing copy-paste into the same view. The search query should already be working with info hashes so that would give you a basic way of linking to a particular torrent though it wouldn't be a "pretty" URL or a dedicated view for individual torrents. You could also link to particular tags in a similar way for building shareable lists. Aside from that, some sort of status/monitoring page is high priority.
We probably need an overall plan for what a more fleshed out UI would look like and what fits in where, before implementing any piecemeal bits of it in isolation.
If anyone is interested in contributing work on the web app that could accelerate things of course - frontend stuff isn't my main area, I'm figuring out the Angular stuff but I've probably missed plenty of tricks and best practices. There are some basic structural and performance issues I'm aware of that will need addressing as it continues to be built out.

Added in https://github.com/bitmagnet-io/bitmagnet/pull/280


Offline usage?

Hi Arian! I'm sorry for opening an issue again but here is a feature request:
Is it possible to use graphein offline?
I am trying to run graphein in a supercomputer to perform massively parallel graph construction.
However, as you can expect, the nodes do not allow internet access so graphein ends up error like:
urllib.error.URLError: <urlopen error [Errno -2] Name or service not known>
It will be nice if graphein can be used offline. :)

Is the problem with protein graphs?
If so, you’re in luck! Graphein can be used on local PDB files - I expect the part that is failing is the download from the PDB. If you use the pdb_path Parameter in construct_graph() you can simply provide a path to the PDB. Eg
g = construct_graph(config=config, `pdb_path="../graphein/examples/pdbs/3eiy.pdb")

The only other thing that could fail as far as I can tell is if you’re downloading the pre-trained ESM model for extracting sequence embeddings.
I should also point out that we have a multiprocessing-based implementation in #73 to speed things up. It’s not in master yet, but if it’s a high priority for you I can bundle it in with the next minor update in the next few days.

Hi @johnnytam100 how did you get on? Can I close the issue?

Hi Arian! I'm sorry for the late reply! I am testing it right now. Possibly you can close it first. :)
Thanks!!

Alright, let me know if you have some trouble. Happy to help! :)


[svcat] Allow svcat bind to be given a blob, store it in a given secret, and then use that secret for the binding.

See https://github.com/kubernetes-incubator/service-catalog/pull/1889#discussion_r178322653

I'm taking off the help-wanted label until we have laid out what this would look like in this issue first.

@pmorie halp


Online status is wrong position

if you observe in the top left corner the online is being shown there that too half cutoff

I don't think I can do something for that, tooltips are not targetable and anyway who cares don't hover the status dot


Reminder: Hokuyo nodes.

Once the wheelchair is put back together:
Add the hokuyo_multi.launch file to the main package (addition to wheelchair_description?). Make sure to separate between simulation and non-simulation (simulation doesn't need this node).
Fix udev device names. http://wiki.ros.org/hokuyo_node#Using_udev_to_Give_Hokuyos_Consistent_Device_Names

Any progress?


Updated the "usePGP" module

Addresses #990 by using absolute paths while loading the OpenPGP script.

@franckc
In the latest commit, I have introduced a workaround wherein the required OpenPGP module files are copied into each theme's dist folder at build time. Would you please review?

@nick You are more familiar than I am with this area of the code. Does that look good to you?


Fix signature of previousDayOfWeek, similar to https://github.com/tel…

Similar to https://github.com/telepathylabsai/OpenDF/issues/7
Testcase:
 do(
    Let(
       x0 ,
       FindEvents(
          AND(
             starts_at(
                nextDayOfMonth(
                   Today(
                      ) ,
                   27 ) ) ,
             has_subject(
                biking in the park ) ) ) ) ,
    Let(
       x1 ,
       DateTime?(
          date= previousDayOfWeek(
             :date(
                :start(
                   $ x0 ) ) ,
             DayOfWeek(
                SATURDAY ) ) ,
          time= HourMinuteAm(
             hours= 11 ,
             minutes= 30 ) ) ) ,
    UpdateEvent(
       $ x0 ,
       AND(
          starts_at(
             $ x1 ) ,
          ends_at(
             AND(
                GE(
                   $ x1 ) ,
                NumberPM(
                   3 ) ) ) ) ) )

Is this still relevant?

No, it's fixed.


[DO NOT MERGE] cat the lcov.info file to the log, and make no other changes

Codecov Report

Merging #27 (28aa138) into master (ff2f1bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   66.66%   66.66%
=======================================
  Files           3        3
  Lines         681      681
=======================================
  Hits          454      454
  Misses        227      227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2f1bb...28aa138. Read the comment docs.

On Julia nightly on Ubuntu, here's what the lcov.info file looks like for this PR:


Revert "feat: buildCustomTx stringified number value (#4287)"

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4317   👈

This comment was auto-generated by Graphite.


[Chip] Color is not applied when using *ngFor

Bug:
Color does not get applied to "mat-chip" if using *ngFor and selected is not set to "true".
What is the expected behavior?
I would expect:
<mat-chip *ngFor="let chip of availableColors" [color]="chip.color">
          {{chip.name}
</mat-chip>

To work the same as:
<mat-chip *ngFor="let chip of availableColors" selected="true" [color]="chip.color">
          {{chip.name}}
</mat-chip>

What is the current behavior?
In the above examples modified from https://material.angular.io/components/chips/examples
The first example does not apply color to the chips
The second example does.
What are the steps to reproduce?
http://plnkr.co/edit/cboYDev2KVgN6d0eSFkd?p=preview

It seems to be because the theming is only scoped to selected chips: https://github.com/angular/material2/blob/master/src/lib/chips/_chips-theme.scss#L44. @tinayuangao do you remember the reasoning behind it?

This is working as intended.
I think we need a way to differentiate selected chips from unselected chips.
In our docs we said "The selected color of an <mat-chip> can be changed by using the color property. " See https://github.com/angular/material2/blob/master/src/lib/chips/chips.md


Spin up a service on demand

I've got a stack overflow asking a question, I can duplicate it here if needed:
https://stackoverflow.com/questions/61731313/should-i-use-a-container-service-fabric-guest-executable-for-a-scheduled-daily-w
It seems like its a mix of two highly requested feature requests:
https://feedback.azure.com/forums/293901-service-fabric/suggestions/13714716-support-scheduled-tasks
and
https://feedback.azure.com/forums/293901-service-fabric/suggestions/13714473-ability-to-stop-disable-services-without-removing
I also see that Vaclav has a "Job Creator" project out there, its title sounds similar but I haven't dug into the code.
Can someone take a look at the stackoverflow and give some guidance?

Will this solve it?
https://docs.microsoft.com/en-us/azure/service-fabric/run-to-completion

Marco...

As you noted this has been a long time feature request, but unfortunately we still do not have plans to natively support scheduled tasks in the runtime yet.
There are a couple of approaches we've seen(@masnider may chime in more).
https://www.dajbych.net/azure-service-fabric-scheduled-tasks
or stateless service setup with appropriate instance count such as -1 to run everywhere that would just loop with a delay timer such as Task.Delay(TimeSpan.FromDays(n))
Hope that helps

unfortunately it really doesn't, but thank you for trying.  We are stuck using task scheduler to call one line powershell to tickle the rest APIs via invoke rest method.  So now we have to manage the applications in two spots instead of one.


fix(pci.project.user): update onboarding component

fix(pci.project.user): update onboarding component
Description of the Change
c6fc4ec1 — fix(pci.project.user): update onboarding component
ref: MANAGER-2748

Is there any internal ticket reference related to this pull request?

@antleblanc The description has been updated


Don't generate nested routes when no file name is the same as the folder name

What is Expected?
Provide an option to make it the same as the route structure generated by nuxtjs or vite-plugin-pages.
Reproduction Link:
https://stackblitz.com/edit/github-u3cz5i?file=nuxt.config.ts,pages%2Findex.vue,.gitignore

As mentioned in other issues, this works fine as this is a feature of vue router so adding an option seems unnecessary. Note you can still modify the array with extendRoutes() to fit your personal preferences. Do you have any particular use cases that cannot work with this vue-router routes structure?

const router = createRouter({
  history: createWebHistory(import.meta.env.BASE_URL),
  extendRoutes(routes) {
    function unnestChildren(routes: RouteRecordRaw[]) {
      return routes.reduce((a, b) => {
        if (b.children?.length)
          b.children = unnestChildren(b.children)

        if (!b.component && b.children?.length) {
          a.push(
            ...b.children.map(i => ({
              ...i,
              path: b.path + (i.path ? `/${i.path}` : ''),
            })),
          )
        } else {
          a.push(b)
        }
        return a
      }, [] as RouteRecordRaw[])
    }
    return setupLayouts(unnestChildren(routes))
  },
})
``` ts
'extendRoutes' can resolved it, thank you.

Thanks. Yeah, sidebars can be implemented in many ways and are therefore out of scope of vue-router and this plugin but they shouldn't be in the way either.


Stuck on flashing minimal build on RGB plugn (AP only with ESP-xxxxx)

Hello,
I just solved one problem - and out of my own stupidity - I flashed with a second device not the tasmota basic bin but the minimal bin I downloaded for local update language version before.
I was a bit confused and didn't check twice: the script does not recognise bin files with several dots like tasmota.8.2.0.bin. So it didn’t offer all files within the folder.
Now I have the problem as other before (1 year ago), Flashing was successful but the device opens only a AP with ESP-XXXXXX. With gateway <IP_ADDRESS> and my PC getting <IP_ADDRESS> if connected. However, no UI to update / access. No ssh.
Restarting flashing fails - of course as the ESP is individually generated.
Is there a way to start the process anyway? Probably by changing the name of the connecting Wifi SSID to "ESP-XXXX" in one of the scripts. As I am not a pro on this, any help would be highly appreciated. Bad luck number 2: the plug is not easily to open...
Regards,
Mario

tuya-convert only works on stock Tuya firmware. It cannot install firmware on a device once it is running a third party firmware like Tasmota. You will need to seek help from the Tasmota community to figure out how to recover from a minimal installation on a blank device.

the script does not recognise bin files with several dots like tasmota.8.2.0.bin. So it didn’t offer all files within the folder.

This however sounds like a bug in tuya-convert that I can address, thank you for bringing this to my attention. I will push a fix out shortly.

@mhofer2011 did you manage to solve the problem?

No I did not - but any help would still be highly appreciated.
Regards, Mario


add new combined user mart

What are the relevant tickets?
https://github.com/mitodl/hq/issues/1644
Description (What does it do?)
creates the marts__combined__users by sourcing de-duplicated mitx data as well as bootcamp and xpro platform data from the intermediate layer
How can this be tested?
dbt build --select marts__combined__users

@KatelynGit Can you take another look? It looked like user_joined_on and user_last_login are all NULL for MITx Online users, which doesn't seem right.
SELECT * FROM "ol_data_lake_production"."ol_warehouse_production_rlougee_mart"."marts__combined__users"
where platforms='mitxonline'

You may want to change that ELSE to coalesce since they don't have data on edX.org. That's the only thing I noticed

@rachellougee I changed them to coalesce statements to fix it


grafana maps under drives and charges dashboards are not visible

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Updated dashboards in my grafana custom instance to version in latest master.
The graphs appear completely black on black. However mouse hover shows the correct values are there.
Tried changing to from dark theme to light theme, now graphs appear white on white.
Expected Behavior
Graphs should appear as before.

Or go to charges dashboard, and click on charge to go to charge dashboard.
Relevant log output
N/A

Screenshots

Additional data
Out of time to debug this is more detail right now. Apologies in advance if I have somehow messed up :-)
Type of installation
Manual
Version
master

Thanks for reporting. Could not reproduce with 1.29.1

Firefox 126.0.1
Grafana 10.4.3
WTF? Today it is fine...
I had to reboot my computer for unrelated reasons, maybe restarting Firefox fixed it.
Anyway, nothing wrong with Teslamate, closing.


⚠ Bofrost.at has degraded performance

In 0863388, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2454 ms

Resolved: Bofrost.at performance has improved in 4350f54 after 9 minutes.


sysdump: distil events in to a nice filterable HTML table

Kubernetes events are, as-is, pretty hard to use. Let's make them easier to grok:

sort by time
write in a nice table
make the table filterable / sortable, etc.

Signed-off-by: Casey Callendrello<EMAIL_ADDRESS>

Attached is a sample output.


Added docs for Google Cloud Storage Integration

Could you please send PR to dev branch
Is this code tested?
Are you okay if I'll add some changes corrections to your docs? For example there is typo in the first sentence: shoes, I believe shows is meant

Thank you for contribution, everything except three questions above looks great to me.

Oh, I'm sorry, didn't mean to commit to the wrong branch. Code is tested and seems to function as intended thus far. However, I'm still in development stages on my app. As for changes, by all means feel free.

Waiting for PR on dev branch


Preference setting to see more direct import labels in context menu

TS Template added by @mjbvz
TypeScript Version: 4.5.4
Search Terms

code actions
quick fixes
add missing import

TL;DR
I would appreciate a setting which would allow me to see simplified, less verbose import commands in the cmd-. context menu.

Currently the menu items are very verbose, changing their description depending on whether other symbols had been imported from the same package.
If this were your first import from 'rxjs', you would see something like:
import 'switchMap' from module 'rxjs'
If there had been other symbols imported from this library before:
Add 'switchMap' to existing import declaration from "rxjs"
My preference would be to always see the final import command instead:
import { switchMap } from 'rxjs'
I personally don't care if this command would be precise in describing the current state, or not, I would just prefer to see a clear  import statement for the symbol I am focused on.
 Seeing a very direct and "constant" import statement will immediately pop into my eye.

@mjbvz I think it would be cool to see a little inline diff display in that window. You have the full text changes at that point; would that be possible?


Add .codecov.yml and set threshold

Fixes #572
See .codecov.yml spec

Codecov Report

Merging #573 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #573     +/-   ##
=========================================
+ Coverage   82.55%   82.65%   +0.1%
=========================================
  Files          73       73
  Lines        2000     2000
  Branches      147      147
=========================================
+ Hits         1651     1653      +2
+ Misses        349      347      -2

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Decoder.scala
88.12% <ø> (+0.38%)
:white_check_mark:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
45.94% <ø> (+2.7%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9366ed9...24f091f. Read the comment docs.

Thanks for researching this, @n4to4!


Gitcoin: Solhint linter

Description

Added solhint version ^1.1.9
Did basic linting of .sol files
Combined lint command with eslint

Issues

#100

Todo
[x] add override config
[x] add badges to README.md

Updated with completed todos

Sorry for the delay here. We've made a fairy major update to the code, which is currently on the staging branch. I can take responsibility for linting that new code though, and its good to see that you've been rewarded for the bounty. I'll do my best to ensure you make it into the commit history too.

Hey @maurelian I don't see that the bounty went through. Also, this PR still is un-merged. Glad to hear that the linting has helped. Let me know if there is anything else.
Cheers!

The bounty itself was actually opened by @owocki
I merged your changes with the updated code base here: https://github.com/ConsenSys/Tokens/tree/Elaniobro-Gitcoin-linter, I'd like to update that to eslint with airnbnb before merging it, and some of the badges don't appear to reflect reality..

@maurelian there could be rate limit issue(s). Are you able to add the shields application to the repo?

remitting the bounty now

remitted https://github.com/ConsenSys/Tokens/issues/100#issuecomment-353030746

Thanks all!


Epic: Messages: New Observability features for streaming

This is an epic to track progress on introducing more observability-focused features to messages functionality.
The list:

Replay messages from the topics (the same topic and from a different one) (possibly edit them before producing) #247
Load messages from a file
paste from the clipboard
Bulk produce
https://github.com/kafbat/kafka-ui/issues/323

Copying messages improvements:

#323
#688

Hi @Haarolean,
can you please assign me to #688 ?
I already implemented it for myself, will create a PR later this week?


ESP32-WROVER-32-AT-V<IP_ADDRESS> firmware cannot connect to Azure IOT hub.

Answers checklist.

[X] I have read the documentation ESP-AT Programming Guide and the issue is not addressed there.
[X] I have used the latest released firmware or have updated my ESP-AT branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hello Espressif Team,
I flash newest ESP-AT firmware into my ESP32-WROVER board
I run following AT command as https://docs.espressif.com/projects/esp-at/zh_CN/latest/esp32/AT_Command_Set/MQTT_AT_Commands.html :
AT+CIPSNTPCFG=1,8,"pool.ntp.org"
AT+CIPSNTPTIME?
AT+MQTTUSERCFG=0,3,"attest","hansHub.azure-devices.net/attest/?api-version=2021-04-12","",0,0,""
AT+MQTTPASSWORD=0,"MY_SAS_TOKEN"
AT+MQTTCONN=0,"hansHub.azure-devices.net",8883,1
Get error in the last step. Same configuration works in MQTTX/MQTTBox tool. Here is the output of serial tool:

Would you like to told me:

If ESP-AT firmware can connect to(or support) Azure IOT hub?
2.Is there any way to output detail client/device side logs of AT-command?

Thanks!

Thanks, let me try it on.

@zh0903 Hello!
Regarding the first point: You are correct. AT has not formally released the v<IP_ADDRESS> firmware for ESP32-WROVER-32, but you can download firmware close to v<IP_ADDRESS> according to docs.
Regarding the second point:
We suggest using v<IP_ADDRESS> or later versions. You can update configurations such as certificates and private keys in one of the following ways:

Use the AT+SYSMFG command to dynamically update certificates and private keys.
Use the at.py Tool script to statically update certificates and private keys.
Update certificates and private keys directly during compilation, refer to How to Update PKI Configuration for more details.

Thanks for your instruction!


Assignment_5

⚠It is important to note that submitting pull requests after the deadline is not allowed. Late submissions will not be accepted and will not be eligible for grading. Ensure your academic success by submitting your work on time.

⚠It is important to note that submitting pull requests after the deadline is not allowed. Late submissions will not be accepted and will not be eligible for grading. Ensure your academic success by submitting your work on time.

⚠It is important to note that submitting pull requests after the deadline is not allowed. Late submissions will not be accepted and will not be eligible for grading. Ensure your academic success by submitting your work on time.

Hi Kiran, Actually I pulled  my code before the deadline. But somehow it did not pulled. After the deadline, i think the next day when i opened the assignement-6. i realized that my code is not pulled to the github. Then I pulled agian to the github. This is the reason why I got submitted lately. Since this assignments are very important to me, Requesting you could you please excuse me this time and from next time onwards I wont repeat it agian.


Restore parse-only to rustc

It seems that https://github.com/neomake/neomake/pull/613 deleted the args passed to rustc, as introduced in https://github.com/neomake/neomake/pull/276, causing a regression as described in https://github.com/neomake/neomake/issues/275.
This PR restores the args (-Z parse-only).

Ping @fuine

I decided to remove parse-only for two reasons:

it doesn't show whole class of errors (-Z no-trans does however)
all -Z flags are currently unstable (see this issue for more information)

Current solution is especially bad for cargo maker, as the cargo build command can take quite some time to recompile whole project. We could get around that by calling cargo/rustc with -Z flag and ignore the warning message in the errorfmt. For cargo maker we would also have to decide whether we want to call it with --lib or --bin, as there is no way of calling cargo with custom flags for rustc in the project with multiple targets without specifying the target (--lib or --bin) explicitly (maybe this should be left to user).

Also let me know if you have regression as described in #275, I use cargo maker for development of several crates and so far the new errorfmt works flawlessly.

@xcambar
What do you think?

Closing this for now, feel free to re-open.

Sorry I'm late to reply. I'm fine with closing the PR.
Note that I'm a super extra noob to Rust, still figuring out the environment, and as such I may not be the best person to discuss the choices of more seasoned Rust devs such as @fuine until I'm more comfortable with the ins and outs of Rust's tooling.

@xcambar
That is very reasonable - I'm even much more a noob in this regard, and happy that @fuine helps out.. :)

@fuine what kind of Neomake configuration are you running with now then? I'm now getting a lot of "unresolved import" errors with make-on-save when working on files in a Cargo-managed project. Have you just disabled the rust maker altogether?

The Cargo maker is also significantly slower than the Rust maker, so relying only on the former is a bit of a chore. For my current project, it takes 23 seconds from save until the errors are shown..

@jonhoo these are selected lines from my ftplugin/rust.vim
let g:neomake_enabled_makers = ['cargo']
autocmd! BufWritePost * Neomake! cargo

The time to show warnings is not an issue of neomake, but rather it's the time it takes cargo to perform the whole debug build of your project. That being said 23 seconds is still suspiciously high number - usually cargo will take much longer compile time if:

it has to recompile dependencies
project actually builds

the latter could be avoided with -Zno-trans, but as mentioned earlier it is currently unstable.
Usually when there are errors in the project cargo will stop the build almost immediately so you should see errors quite fast. As for warnings you need to wait for the full build, so it might take some time.
Rust community is currently working on implementing incremental compilation, alpha version of which is currently in the nightly compiler, so you might take a look at it, if the build time is really bugging you. Note that this feature is of course unstable. To learn more about it visit this link.

Following this change, I'm currently using, which amounts to about the same
let g:neomake_rust_enabled_makers = []
autocmd! BufWritePost * Neomake
autocmd BufWritePost *.rs Neomake! cargo

I'm working on a decently sized project, and ~23 seconds is the build time if the previous build did not complete (but with all dependencies compiled). Note that the errors appear almost instantly, so I wonder if there's a flag we can pass to Cargo so that it will terminate early if any part of the compilation process fails with an error:
$ cargo build -v
       Fresh rustc-serialize v0.3.21
       Fresh libc v0.1.12
...
       Fresh thread_local v0.2.7
       Fresh regex v0.1.80
   Compiling foobar v0.1.0 (file:///home/jon/dev/projects/foobar)
     Running `rustc src/lib.rs --crate-name foobar --crate-type lib -g -C metadata=52b528dae9da63ec -C extra-filename=-52b528dae9da63ec --out-dir /home/jon/dev/projects/foobar/target/debug/deps --emit=dep-info,link -L dependency=/home/jon/dev/projects/foobar/target/debug/deps [more externs] -L /home/jon/dev/projects/foobar/target/debug/build/randomkit-c6d77419a385d677/out`
error[E0428]: a type named `Domain` has already been defined in this module
  --> src/flow/alt.rs:51:1
   |
8  | struct Domain(usize);
   | --------------------- previous definition of `Domain` here
...
51 | pub struct Domain(usize);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^ already defined

[various other errors]

error: aborting due to previous error

[~20 seconds pause]

error: Could not compile `distributary`.

To learn more, run the command again with --verbose.
Command exited with non-zero status 101
20.99user 0.06system 0:21.08elapsed 99%CPU (0avgtext+0avgdata 153860maxresident)k
0inputs+352outputs (0major+21988minor)pagefaults 0swaps

I see the same behavior when I run the rustc command Cargo reports directly.

Upon further inspection, this is probably related to https://github.com/rust-lang/rust/issues/37477. Once that is fixed, this would hopefully be much more manageable.

For others with the same issue, unsetting RUST_BACKTRACE (or setting it to 0) fixes this issue, and is a decent temporary workaround.

Nice, i wanted to note that i couldnt observe this, and now i know why. Sadly at the moment there isn't any way of getting errors/warnings faster without using unstable features. If compile times are that much of a problem, then i'd suggest you try them out - -Zno-trans and incremental compilation should do the trick. Please note that if you are going to use any of those things, then you most probably should append a line to errorfmt in order to ignore the warning about using unstable features. I hope that i cleared the situation out for you.

For future record, we should probably also track rust-lang/cargo#1313, as that command sounds like exactly what we want here.

rust-lang/cargo#1313 has already landed in nightly Cargo.


demo panic

hi. when i used the case of README.md demo. there was an incredible panic.
env: go version go1.13.4 darwin/amd64

Nice catch. Thank you.


Update the non-tchap contacts list display

User story: Invitation des contacts

Apply the requested design on the non-tchap contacts list
Prepare the multi-selection, but do not support it

Keep the same behaviour than the current non-tchap contacts list when a contact is selected, by displaying at least the selection icon.
Design: https://zpl.io/VDOejMw

blocked by #173

unblocked


Disable a watchdog for stuck processes

High-level description
Disable a watchdog for stuck processes.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-38600 Deadlock when SSL sockets are simultaneously sending/receiving data and buffers are full.
SOAK-112 l4lb and autoip address not connectable - constantly failing tasks.

Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: internal change
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot label [Work In Progress]

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot label [Ship It]

@mesosphere-mergebot override-status mergebot/enterprise/has_ship-it https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status mergebot/enterprise/has_ship-it https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot override-status teamcity/dcos/build/tox/windows https://jira.mesosphere.com/browse/DCOS-41240

@mesosphere-mergebot merge-it

@mesosphere-mergebot merge-it


Roller

From @talapadi on July 24, 2018 14:59
Should be able to mask an image using roller. Wherever the roller is used, it will mask using a plain color or a pattern
Copied from original issue: chimple/maui#640

This issue was moved to chimple/tahiti#1


gutter icons without borders

So the gutter icons didn't really work with my theme (should they switch automatically?). After deleting all the white/grey parts from the SVGs they look pretty good to me

Do you like them better with the icon borders? If not I'd be happy to submit a PR removing them.

That icon looks huge. Did you increase circle radius relatively to the icon itself?

Those icons are taken from vscode repo and borders are probably for accessibility, so if you want to make a PR - make it as an additional icon set (their size is negligible ~300 bytes per icon).
I was fiddling with icon sizes today and decided that it's not possible to make them look good at different settings editor.fontSize & editor.lineHeight.
That means that gutter icon size should be exposed as a setting.
To recap what would be nice to see in the PR:

6 borderless icons that take ~90% of the icon size (without deleting the old files)
As a bonus: change 6 old icons to take the same amount of space ~90% of the icon size

After that (before publishing) I will add 2 settings:

Gutter icon set (Will enable to add different icon sets in the future)
Gutter icon size

I didn't increase the icon size, the icon with the border was actually clipping before. I think it has to do with having a large font size combined with a small line height. All similar extensions have huge icons as well. I'm fine with the size though. My theme is technically a light theme but uses dark editor colors, and I think that's why I had issues with the borders.
If it works with the theme as intended, isn't the border pretty much invisible anyway? That's why I thought using only transparent icons might be fine. I don't see a big accessibilty concern, since the colors provide good contrast on any common gutter color. I tried to make some bad examples and they still look ok.

But having an option for it is good as well of course.
Here's a PR with transparent / borderless icons and all icons scaled down 90% https://github.com/usernamehw/vscode-error-lens/pull/6. I had no idea how to scale the svg paths so I added a group with a transform around all icons. That also makes it easy to adjust the scaling by just doing a find and replace (eg translate(1,5, 1,5) scale(0.9) to translate(3, 3) scale(0.8)).

Starting from version 2.3.1 there's 2 new settings:
"errorLens.gutterIconSize": "110%",
"errorLens.gutterIconSet": "borderless",

I deleted the transformation from icons since there's no need for it.


Add Makefiles for chapters 5, 6

these are missing. just copy paste modify from other chapters

Seems outdated. Can we close @fabian-s @tpielok ?

yup


ProgressBar should use stderr by default

A minor change (I think), but it makes sense when we have commands that we want to pipe or redirect the "real" output, not the  progressbar.
If accepted I'll add a note in documentation.
I'm not sure if this change is testable, but I can try to add a test too.
I saw other PR targeting master branch instead of the maintenance branches pointed in the contributing guideline, tell me if I need to change the target branch.

@blueyed yes, maybe just changing the logic here: https://github.com/pallets/click/blob/master/click/_termui_impl.py#L197-L199
It should skip the label or just return I guess. I'll try to write a test and validate this idea.


Using someone else's work

If you feel the need to take someone else's hard work. Then at least be professional enough to give them the credit they are due!
Free2View works hard to provide their work for all to use. At least give them the credit for doing the work you decided was good enough for you to take. Better yet, you should ask before taking!

this was meant to be removed due to it messing up the main list, and untill i can fix the main list, i've removed...
Added all the credits to those that have helped.. normally this is done straight away, but had covid and still got long covid.


The materialized view destination table does not support materialized columns?

Question
I built Byconity based on tag 0.4.0 of the code, and when creating a materialized view, I encountered the following message:
[2024-05-29 14:00:26] Code: 44, e.displayText() = DB::Exception: Cannot create materialized view kafka_view.test_app_10001_base_useless (5d67d99f-7ea2-45eb-8012-7cfd2e4f1cc6) to target table ods.test_app_10001_base_useless_01 (4027cab0-a5df-4ddd-8c76-955756b0898c) with materialized columns columns format version: 1
[2024-05-29 14:00:26] xxx columns:
[2024-05-29 14:00:26] `ck_to_1_min` DateTime
[2024-05-29 14:00:26] `ck_to_5_min` DateTime('Asia/Shanghai')
[2024-05-29 14:00:26] `ck_to_hour` DateTime('Asia/Shanghai')
[2024-05-29 14:00:26] `ck_to_week` Date
[2024-05-29 14:00:26] `ck_to_month` Date

[2024-05-29 14:00:26] SQLSTATE: 42P10 (version <IP_ADDRESS>)

Possibly related code:
https://github.com/ByConity/ByConity/blob/8d79cb5776ef3a9c33ca65fc8daf9f47d8d85771/src/Interpreters/InterpreterCreateQuery.cpp#L1553-L1579

#1645


my pull

commit change

Hi @TemitopeAwe, thanks for opening. If you have a change you'd like to discuss, please open a PR just with that change (this PR has 300+ commits and 500+ files changed). Thank you!


Basic HTTP Implementation

Provide a simple interface for the user to interact with the database.

GET (for querying one resource)
POST (for creating one resource)
DELETE (for deleting one resource)

Done in one of the latest commits


Add Total.js

Under framework
https://www.totaljs.com

Total.js is full-featured server-side framework which effectively improves the most important aspects of your project during its lifetime. Super fast development, extremely low maintenance costs, rock solid stability, incredible performance and easy scaling.

https://github.com/sindresorhus/awesome-nodejs/pull/680#issuecomment-299787963


flutter run --watch

flutter listen is being removed. Should we implement flutter run --watch that automatically reloads the application if any file in the application changes?

I don't think we need it at this time.
On Tue, Oct 4, 2016 at 06:35 Dan Rubel<EMAIL_ADDRESS>wrote:

flutter listen is being removed
https://github.com/flutter/flutter/pull/6198. Should we implement flutter
run --watch that automatically reloads the application if any file in the
application changes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/6199, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAVZxpf2z9zSN9aRydGrx2TGpi1GYIJks5qwlYKgaJpZM4KNrsT
.

I think it'd be a fine feature, but is not a high priority. We have bugs to deal with before we add features.

Closing.

Some of us newcomers to Flutter out here are not using VSCode and IDEs. A flutter run --watch would be very useful.

Coming over from React Native and the likes I today installed Flutter for doing my first experiments with it and truth be told this was the first thing I was looking for …
As I'm unfamiliar with Flutter at this time, is there any technical reason to not include this low-effort huge-impact #DX improvement?