New out-of-box default theme

As discussed in weekly meeting 2016-02-09, I'd like to try and drive the efforts towards a new default theme for Orchard. I thought the first step should be laying down a set of design goals and requirements, so I've been doing some background thinking this weekend and here is a summary of what I'd like to accomplish.
Design Goals
Visually appealing yet customizable/extensible
Whereas TheThemeMachine heavily favors customizability and extensibility over visual appeal, the new theme should strive to serve both these needs. The markup should be very clean and semantic (not littered with presentational classes) while the stylesheets should render that markup in a visually appealing way.
We should consider the following scenarios of customization:

Customizing the theme "in-place" by changing out LESS/SASS variables
Customizing by adding new overriding stylesheets, but leave most markup (shape templates) intact
Customizing by overriding shape templates

By carefully considering how stylesheets are structured, by basing the theme on a known framework such as Bootstrap, and by utilizing preprocessor variables, I think we can both be beautiful and make life a breeze for theme authors when using the new theme as a base.
Generic yet unmistakably Orchard
I have approached @ryandrewburnett to help with the visual design, and he has responded enthusiastically.
The theme should look generic enough to appeal to a wide audience and work well for most simple web sites, but it should also have a few key elements which make it look "unmistakably Orchard". There is a balance to be stricken here, but I think a good starting point would be to use a few Orchard visuals (such as the logo and icons) along with using the traditional Orchard green as an accent color.
In any case, all of these things should be configurable. The theme should look slightly Orchard out of the box, but site owners should be able to easily change out these logos, visuals and colors from the admin UI.
Heavier or layouts, lighter on global zones
TheThemeMachine was constructed for a world without layouts. Layouts were sort of bolted on as an afterthought. The new theme, by contrast, should fully embrace layouts and elements, which means going easier on global zones and widgets.
This does not mean the new theme should have no global zones - it just means it doesn't need nearly as many of them as TheThemeMachine. Having some global zones is still very much necessary to place navigation widgets, to emit INotifier messages to the front-end, and so on.
In the new theme these global zones should be primarily vertically oriented (positioned above and below the Content zone) leaving the Content zone to span the full width of the page to enable greater control by site editors of page layout. It's probably important for most editors these days to be able to use modern design constructs right from the layout editor, such as "stage" visuals and full-width page sections with alternating background visuals.
Responsive
Needless to say, the new theme should be fully responsive.
Scope
TheThemeMachine still remains
First of all, TheThemeMachine should not be removed. It should still be considered the "core" theme of Orchard from a module development perspective. Today TheThemeMachine is really not contained in the theme only - it is actually spread out across all modules in the code base. Most core modules today containing core templates for their shapes do so assuming TheThemeMachine as the target. This means the theme itself contains very few templates. This should continue to be the case, i.e. we will not be touching the shape templates in modules.
Instead the new theme will contain overrides of all these shape templates, which means the new theme will contain a lot of shape templates. This should be considered a good thing, as it will also make customization much easier. Custom theme authors will no longer have to search the whole codebase to find the original shape template to override, instead they can base their theming effort on what they see right in front of them in the new theme, systematically going through all the shape templates and make sure they adhere to their customization needs.
Covers all non-deprecated functionality
The new theme should contain shape templates and styling for all non-deprecated functionality in Orchard, not just the features enabled by default. For example, if you enable Orchard.Search on your site, it should already just work and look good.
Also comes with new out-of-box recipes
As part of this effort we need to refresh the out-of-box recipes also, for multiple reasons:

They should enable the new theme instead of TheThemeMachine.
They should create content that is more taylored to the new theme.
The current ones are generally outdated and use commands for things that should now be done using proper recipe steps.

We might keep the old recipes but deprecate them.
Includes overhaul of setup page to match
To create a smooth and coherent out-of-box experience for Orchard, as part of this effort we should also update the look and feel of the setup page to match the visual design of the new theme.
Functional Requirements
Skinnable
As mentioned above, the new theme should have a default appearance that is generic yet unmistakably Orchard. However it should also be sufficiently configurable from the admin UI to allow site owners to differentiate their sites visually, and change these "Orchardy" defaults to something that's more unique to them.
There are many potential ways to do this, but I believe a good starting point would be:

Make the site logo configurable from the admin UI
Make the primary and accent colors configurable from the admin UI
Make the fonts configurable from the admin UI
Allow custom stylesheets to be added from the admin UI, either by URL or by pasting in the actual stylesheet contents. The theme should render the custom stylesheets after any theme stylesheets in the document head.

We might potentially utilize the work done by @sfmskywalker on a framework for theme settings.
RTL support
The new theme should fully support right-to-left cultures.
Technical Requirements
Based on Bootstrap 3/4
The general consensus in the community seems to be that the new theme should be based on Bootstrap. There are two main reasons for this:

Not re-inventing too many wheels
Making it easy to extend/customize the theme

In particular no. 2 means anyone who is familiar with Bootstrap markup and stylesheet structure will find it immediately familiar and easy to adapt the theme to their needs. Theme authors don't have to spend a lot of time learning and understanding the theme; instead they can just employ the knowledge and experience they already have because the theme is structured in a very predictably Bootstrap kind of way.
Bootstrap 4 is currently in alpha 3, and it's reasonable to expect it will reach RTM this year. We may consider going straight to Bootstrap 4 for the new theme. There are many benefits over Bootstrap 3 - flexbox support stands out as a personal favorite. This would also require adding support for SASS to the Gulp pre-processing pipelines, which is something we have already wanted to do.
Built for modern browsers
The new theme should not compromise cleanness for compat. The general workflow should be to implement according to web standards/specs, develop/test on a modern browser of choice, and finally do a round of wider browser testing close to release to ensure compat across the gamut of modern, standards-compliant browsers.
In particular, IE10 now has a market share of 0.6 % globally, and we should consider it an unsupported browser for the new theme. This allows us to rely on flexbox support among other things to keep the quality high and the implementation clean.
For the few people out there who feel they need compat with older browsers, we can refer them to TheThemeMachine which is still kept around.
Uses Gulp preprocessing pipeline for everything
The new theme should fully utilize the Gulp preprocessing pipeline, both for its own resources but also for its dependencies such as Bootstrap. By integrating with Bootstrap on the LESS/SASS layer, the new theme can override styling of Bootstrap constructs by overriding LESS/SASS variables and overriding/augmenting Bootstrap mixins. This dramatically reduces the amount of actual output CSS needed.
For example, instead of the browser having to load both bootstrap.min.css and theme.min.css where the latter is largely an override of things in the former, the Gulp pipeline can render one bootstrap.min.css from the Bootstrap LESS/SASS files combined with variable/mixin overrides provided by the theme.
In line with the principles already employed for client-side resources in Orchard, internal and dependency resources alike should go through the same preprocessing pipeline including transformation, minification and bundling.
No compat with TheThemeMachine
The new theme should not strive to acheive any kind of markup compat with TheThemeMachine; there is no reasonable use case for this. There are likely very few sites that use TheThemeMachine for production use, most site owners will have built a custom theme or used another. Folks who have built custom modules that target TheThemeMachine can optionally update them to be compatible with the new theme instead, but they don't have to. As mentioned above, the cases where people are actually using these modules' default TheThemeMachine-based rendering for production use are probably very few anyway.
Feedback
Do you agree with these goals and requirements? Do you disagree with anything in particular? Is there something I haven't covered that you think should be called out? Please voice your opinions in the comments, and I'll regularly update this text as the discussion unfolds and a sense of agreement emerges on specific points.
I'll give this a few weeks to bake and mature before moving on to implementation.

Summoning @bleroy @BenedekFarkas @Piedone @sfmskywalker @sebastienros @ryandrewburnett @pszmyd - your input is needed on this. Anyone else's input is also highly welcomed!

I agree with everything that you have said here. I thought I’d just pitch in and hopefully contribute something towards this…
I’ve been working on a theme called Bindery – I would appreciate it if you can go and take a look at how I have constructed the theme to see if you agree. Here’s a few things that I’d like to emphasise are going to change:

Use the Orchard Gulp pipeline - no idea why I haven’t changed this already since it’ll take a matter of minutes to implement.
Move over to Bootstrap 4 – relative units are a must.
Deciding how many and what zones are needed, version 1.1.0 added more than a dozen zones.
I need to add LESS variables to customise the design.
Remove more presentational classes – version 1.1.0 removed a huge amount of classes but some still remain.
Remove all support for pre IE10 browsers. Document.cshtml includes HTML5shiv, it contradicts that I don’t test or care for old IE with these themes.

I have two more themes coming soon that are more business orientated and constructed in the same manner. If any of these designs are of any use – take them. All of the design belongs to me so you can take what you like, you can even use the entire theme if you wish.
My stance on Bootstrap is to consume what you need and nothing you don’t, which is how Bindery is constructed. I’m not a huge fan of including modals, tabs, accordions and every imaginable navigation configuration possible in a theme. Maybe I’m wrong however and including just what you need is backwards, but could this be a consideration for the new theme?
One idea that I’d like to share with regards to configuring the visual appearance of themes is site logos. I feel that this isn’t something that should belong to the theme, since the logo of a site doesn’t necessarily change with the theme. I also believe that this option should encompass favicons and mobile icons. With my themes I was going to build a module which adds settings to the site in order to add branding assets. These settings would then be consumed by themes which support the module. Users could then set branding assets and have them appear across any theme they choose. The settings was to compromise of:

Site logo.
Site favicon.
Mobile icons, ask for the largest size used and then produce all smaller icons using the media library.

Would this be something to consider as a core feature?
I think this is everything that I can think of for now. Aside from conveying Orchard's visual identity, are there any requirements in terms of the visual design or is this completely open?

I created this last year (I think) as an experiment. I was wondering what everybody thought of it.

I'll read the original post thoroughly once I'm retired and have more time ;-).
I didn't catch anything that I'd be particularly disagree with.
Not sure how having fewer zones is something that would be an improvement, despite Layouts. Having a variety of zones like in TheThemeMachine (and I'd add, for similar-purpose zones keep using the same zone names - like Navigation, Footer - that became kind of a de facto standard) keeps options open without drawbacks if you don't use them all. And especially since we're talking about a theme here that most possibly would also be widely used as a base them, keeping options open is an important aspect.
To add to the previous: I'd also design the theme as a base theme, i.e. a theme that can be widely used for theme developers to build on (as this wouldn't compromise but logically extend the above listed design goals): code-level configurations building on existing ones in Bootstrap, fine-grained ability for overrides, a variety of element CSS classes and IDs, etc. allow these. For an inspiration take a look at Pretty Good Bootstrap Base Theme which was specifically built as a base theme (but in contrast without caring about the OOTB aesthetics).

I completely agree with Daniel's outlined goals and requirements. I especially like the modern, clean and attractive design based on Bootstrap 4 (not 3) and that it is more heavy on layouts, or at least less heavy on zones. It would be simple for theme developers to add new zones of they wanted to die to the Bootstrap factor.
I am really fond of having a configurable theme framework baked into Orchard, similar to what Wordpress and Shopify have, where theme developers can simply provide a theme settings schema, and all users need to do is provide values for those settings. This potentially unlocks a whole new set of new themes that allow the user to customize them, without theme developers having to code settings themselves, unifying the way theme settings work.
Regarding design, I love Ryan's design style, very happy he is onboard with this.

@ryandrewburnett Thanks for the input, and for being willing to help - your design skills will be crucial. I'll take a look at the theme you linked to.
I agree with your stance on Bootstrap - we should use what we need, but not compulsively try to cram every gadget in their arsenal into the Orchard shape templates. However, it would probably be helpful to themers if the customizations/overrides we make on the Bootstrap level in terms of visuals also work across the whole Bootstrap framework so that people are free to apply Bootstrap constructs even if we don't use them in Orchard.
I also agree with your thought on making branding assets configurable through a module rather than by a theme. I think a reasonable approach would be to add a few key such assets to the general site settings (along with the existing site name, culture etc). As you say, it would then be a responsibility of themes to render these where necessary.
Love the logo, colors and typography - definitely something we could base the aesthetics on!

@Piedone Thanks for pitching in!
You are right, there isn't necessarily any conflict between embracing layouts and providing lots of global zones, except in one way: the layout is one rectangular region, and we currently cannot mix zones into it. There's a hard boundary between layouts whose elements live within that region, and widgets which live outside of it. So if we want editors to have the full width of the page at their disposal when creating layouts (which I'm reasonably sure we want) we unfortunately can't also have widget zones in the same horizontal section of the page.
So, we could have the same abundance of global zones as in TheThemeMachine, but they would all need to be positioned above/below the content zone if we want people to really be able to utilize the full potential of layouts.
I have struggled with this in a couple of theming projects, and it's proven a very tough nut to crack. For example, it might sound simple to create a page layout that has aside zones to the right/left of the content zone. But as soon as you place anything in one of those zones, a whole column to the left/right of your content turns into empty wasted real estate, and that's rarely what you want. You can start messing around with floats to try and improve that, but that really only works reliably if your content is basically only a flowing text - not so much if it's a grid-based layout, itself heavily reliant on floats... yada yada, you get the picture. It gets real hairy real fast. ;)
As an aside, this is why we suggested a while back adding the ability to designate column elements as zones. This would allow for exactly that kind of "positional blending" of layouts with widgets that's impossible today.
PS. Oh and thanks for the obligatory "OMG wall of text, who has time to read, we are programmers here man" jab. Those are always encouraging... ;)

@sfmskywalker Thanks! Do you think it would be worth revisiting your work on configurable theme settings for this, as a general feature addition to Orchard? I always believed in the idea, not sure why it was never incorporated?

@DanielStolt Absolutely, it was designed to be a general feature addition to Orchard from the start. I believe the general consensus was that if themes need settings, those settings could be provided from the theme itself using C# code. Which is true of course, but I think it's a repetitive task enough to justify this be a core feature of Orchard. This also means a more streamlined story when multiple themes are installed and enabled, without cluttering the admin menu. Accessing theme settings is done via the Themes screen, where a "Settings" button appears next to the current theme. Also, theme settings are stored in profiles, which means you could have different sets of settings for a theme.

Only Zones: Header, Navigation, Messages, Content and Footer.
Use Layouts it gives us the versatility for all the other areas and zones. Maybe some hidden zones for comments, contact, and even login and registration. I hide my forms and open them in a Colorbox window = less clutter and helps on spam as the forms are initially hidden. Add a Elements folder with Element alternatives. No Styles, Assets, or Scripts folders are needed use Orchard.Resources.

I don't think it should include any Orchard branding by default, I want to be able to run a site out of it, no config needed. Who would use the Orchard branding? You imply you always have to configure. I'd say if you want the ORchard branding, tweak the configuration ;) Neutral branding is better IMHO.
We should have recipes for well-known site types: a blog, a corporate site, .. (can't think about another useful recipe), so I don't disagree with you here. More specific recipes should be on the gallery.
Configuration should not impact performance. How configuration is implemented is important. And I hope you won't go into too much there.
It should still be used as a base theme, as templates can be fixed over time. It's compatible with less/sass.
Ok to have less Layout zones, but at least keep the ones all around the main Content (left, top, right, bottom) and, Navigation, Messages, Header, Footer (would be good to have an OuterLeft and OuterRight too to create full longitudinal column (c.f., http://haacked.com/, https://wordpress.org/themes/twentyfifteen/)

So far I think nobody disagreed with everything you said, just details/confirmations. Keep it up! And thank you @ryandrewburnett for you support.

@sebastienros

You are right, no Orchard branding (i.e. no logo etc). Only an Orchard "feel" (colors, typography).
We will pay close attention to the perf.
What do you mean by the "it should still be used as a base theme" remark? Do you agree with something or disagree with something? What? :)
I like the OuterLeft/OuterRight idea as a concept to enable a full, sticky-positioned longitudinal column, but as a feature of a generic theme it raises some questions we would need to decide on:

How determine the width? The preferred width probably depends on what content you want to put in that column. Make it configurable?
Make it scroll-to-fix always, or never, or configurable?
How determine what happens on smaller viewports. Should it collapse into a hamburger menu like in Twenty Fifteen? Or stack vertically, like Haacked? Again, probably depends on what you use it for. Make it configurable?

For me, the proposals from @DanielStolt are a logical step forward and very welcome indeed. But, here is some feedback you asked for Daniel.
I think an Orchard Theme has always been focused on transforming content for the web, delivering html/css/js, to the browser. In that scope, there is a lot going on, related to web technologies. That scope is huge and growing and we're constantly trying to adapt to the situation. HTML5/CSS3, SPA, all kinds of Javascript frameworks, ECMAScript 6, HTTP/2, Webcomponents, ServiceWorker, web assembly, ... the list goes on and on.
But, what is a 'Theme'? If you take the word 'theme', it's all about the graphical appearance, nothing else. Basically that's the visible layout, colors, fonts, assets, etc. It's not about the ever evolving web technology.
The 'Theme' thing, the whole as we know now, should be all about the experience for the (end) user. The user's own capabilities, the user's device (form factor, input capabilities, connectivity). And possibilities are enhancing in future.
Or maybe it shouldn't be called 'Theme'. It's getting too big to be responsible for. Some people (like Lombik) already do some form of separation of concern, by inheriting from a base theme. That might work for one situation, but there is a dependency/binding; I don't think you can switch base themes.
Isn't it time to decompose the Orchard 'Theme'?
The theme or graphical appearance is built using layout/zones and other visual aspects. We can have recipes for that. Visual aspects are mostly LESS/SAAS/CSS related.
The processing/rendering in the middle (between shapes and the actual html/css/js) is an intelligent step. That step can(should) incorporate graceful degradation and progressive enhancement (ICYMI - I love this - https://www.youtube.com/watch?v=EVEiIlJSx_Y) and whatever technology/framework you're using, for instance bootstrap 3/4. The technical requirements are all related to this, none to the graphical appearance / theme.
Or maybe this is an opportunity for Orchard2...

@geertdoornbos Thanks for chiming in! What you're saying makes sense in a lot of ways.
Indeed, I think part of what you're suggesting is what we're trying to accomplish by making the theme "skinnable" or configurable. The technical aspects could then be implemented once, in one single theme, while the pure visuals could be configurable aspects of that theme.
As described in the issue text, we're considering allowing site owners to inject their own custom CSS as configuration of the theme. This is conceptually very similar to what you are describing, right? It basically creates a separation between "theme" and "skin", where the former is about rendering markup and making technology choices, and the latter is about adapting the aesthetics to your taste.
Going even further than that (i.e. formally decomposing the concept of a "theme" into two aspects that are independently selectable) is an interesting thought, but one that I think is better left for O2 or even beyond.

Finally got time to read all this and answer the summon. Great proposal.
I'd actually deprecate the theme machine, with the goal to remove it entirely, at least in Orchard 2.
I'm in favor of aiming for Bootstrap 4.
More templates?
I'm not super-enthusiastic about putting more templates in the theme. This sounds like a very WordPressy approach, one that we know hurts extensibility, as theme authors have to worry about way too much stuff that is module responsibility. It's common in the WP ecosystem to see themes having to explicitly support this or that well-known plugin. Because trends in plugins shift all the time, themes become obsolete faster, and are harder to use with lesser-known modules.
I think our approach of having neutral templates in the modules that can be overridden by specialized themes is the right one. It does make it a little harder to hunt for the right template to override, but with the help of shape tracing, we win in the end because we have way more flexibility. Notice the distinction between a generic base theme (that has few templates) and a specialized, almost non-reusable derived theme (that has lots of overrides, including for optional module templates). WordPress does not make that distinction nearly well enough.
Should new module templates target the new theme eventually when the theme machine is phased out, or should we just make sure that the existing and new templates are neutral and semantic enough that they work well with TTM, the new theme, and any well-designed theme out there? <- rhetorical question
It may be appropriate to have a couple of overrides built-into the theme for some very core features such as notifications and navigation (because Bootstrap does some interesting stuff with those), but I'd advise against going much farther than that.
Logo and favicon
I disagree with Ryan about logo and favicons: those really aren't site settings. Proof: when you change the theme, will you typically have to change what logo file you use? A: yes, because it must be visually consistent with the theme, so the setting belongs on the theme, not the site. (fun fact: I started by agreeing with Ryan, and changed my mind when I started to try to prove his point).
Zones
I'd vote for less zones, aimed at layout. I'd keep a zone for notifications, footer, and navigation because that is usually outside of what layouts typically address (I guess it would be fun but impractical to have a theme that is just one big zone under the body tag), and because they are not item concerns, but are global.
Users who need more zones can add them: it's easier to add than to remove, and less zones would streamline the experience by showing a clear way to do things instead of confusing new users with multiple solutions to the same problem. I'd cut left and right zones: they should be easy enough to add on a derived theme, and as Daniel showed, there are so many caveats that we won't be able to satisfactorily address in a general theme, but that would be easy choices to make for people enhancing a derived theme.
+1,000,000 on allowing elements to act as zones. Not a new idea, but let's do it already. It does blur the lines between item and global concerns, but this can probably be mitigated using master layouts or whatever those are called.

@bleroy About less zones, yes for less, no for no zones. One of the goals of this theme is to provide an out of the box theme that users would use straight away without coding, one that is appealing enough for this. Now imagine a Blog, which is not that uncommon on Orchard (how many do you have?) where do you put an Archive widget if there are no zones for it. If you tell users you want a blog? Create a new theme and add zones. I don't see it as a good offer. And what about controllers that are not using the Layout Part, like Lists, Taxonomies and any custom controller.
I discussed it offline with Daniel and he would agree about having Outer left/right zones, something like this: https://cdn.colorlib.com/wp/wp-content/uploads/sites/2/Entrepreneurship-clean-blog-theme.jpg
I would have considered something like this instead https://colorlib.com/wp/wp-content/uploads/sites/2/spike-clean-blog-theme.jpg (where the asides are under the navigation) but it's a compromise that solves the Blog Archives example.

Where you see problems, I see opportunity ;)
How if blog, list, taxonomy, etc. could actually also use layouts?
The layout template in the theme could also explicitly render a master layout that is site-wide.
Adding zones seems easier on the surface, but let's consider our options here.

Processing ...

Ok ,doesn't work, with a new Widgets module maybe, but it's not the case today, and out of scope. Another opportunity in mind?

It's out of scope, yes, until we decide to put it in scope. But yes, it would work best with a new widget editor. I have some ideas on that, let's talk about it for Orchard 2. I'm happy with a compromise for this theme. Left and right sound fine.

@bleroy Thanks, excellent input!
More templates: Having a default theme that doesn't provide nice rendering of all core functionality would be unacceptable IMO.
The way I see it, we have two options:

As part of this work, tweak the theme-neutral shape templates in core modules to emit truly neutral markup, and make the necessary changes to both TheThemeMachine and the new theme to ensure they render nicely in both.
Leave the theme-neutral shape templates in core modules untouched, and my necessity have more templates in the new theme.

As hinted by your rhetorical question, I think 1 would be preferable.
We might also consider providing the new theme in two layers: one base theme that simply provides the basic overall layout and general styling, and one child theme also adds shape templates for remaining core functionality.
Logo and favicon: You should listen to your first instinct. ;) I agree with Ryan on this. I disagree that the logo changes with the theme. And definitely not the favicon. They are like the site title, only in a different form (image instead of text), and as such I think they belong as site settings.
Zones: I initially thought the same as you, but as @sebros mentioned he's convinced me that some longitudinal zones are actually needed and we've reached a compromise. Your idea that the theme layout template could be driven by a predefined master layout which is editable from the admin UI is very interesting though! In combination with designating elements as zones, that could really achieve the ultimate flexibility. But I think we should consider that idea out of scope for this effort - let's start with building a theme for the Orchard of today.

Devil's advocate on option 1: that may result in breaking changes. Themes that work today could start rendering weirdly.
Not to insist, but really, at least the logo is a theme property: size, proportions, color palette all may vary with the theme.

I've worked a lot on bootstrap but one year ago, so here it's as i remember.
With .less, jquery and views overriding
I could do many things with .less .mixins() and &:extend(), e.g it was quite easy to deal with the content and aside zones sizes, but you can't do all. I've tried some jquery functions to adapt some html structures, but i don't like to mainly use this option. Finally, i've overrided views, e.g to use full bootstrap classes with column elements, but quickly you will have many overriden views to maintain.
Bootstrap
I like things as bootstrap when you can say i don't want to be specific but i know that i will use it. This because some concepts become natural and finally required.  Then, it can be a guideline e.g for view structures, not to be tied with bootstrap but ready to be bootstrapped as much as possible.
So,here the idea is to mainly use .less files, and each time you need to override a view, try to see if it can be solved by updating the core view without breaking changes. Maybe an useless or missing wrapper tag, a missing attribute to identify a category, a singularity, a different structure for the same thing...
Note: Most of Orchard objects are well formed, but the remaining can cause the main difficulty.
Layouts editor & Zones
Maybe zones composition is the responsability of the theme, and layouts editor is at the content item level. But the Welcome page already uses it to make some "zones". Then here the need of the Layout Template feature, but too complex to update items when a shared template is modified, with nested elements...
So, here my feeling is that Layouts is like a framework in a framework and we have to find compromises between two worlds. E.g we could keep the concepts of widgets zones, layer rules, but with the layouts editor experience for zones composition (with some required zones).
Ideally, a theme would only be a style file and maybe some settings for colors, fonts, spacings...
Layout editor & others
At the content item level, one approach i had is to use the layouts editor as a general placement tool. And i've worked on TinyMce by making plugins and templates. Here also, to have well adapted  structures to be themed and easily become bootstrap objects.
But here also i had the feeling of a mix of 2 frameworks. TinyMce enhancement seemed to me easier but i already felt that it would be better to depend and to do the same with layouts elements. This was a little confirmed with some new simple layouts elements as the Break and the Heading ones.
So, here the same idea to first enhance the ability to create well adapted html structures. This not to use too many workarounds through a theme. E.g a panel element (not sure it's a good example), not as a bootstrap panel but based on the panel concept.
Favicon
Seems to be tied e.g to a company, but i agree, you may want a variant when using in a specific theme... Anyway, we need a Favicon that is fully implemented. Not only in the <head> of the document but also as a file served from the site root as requested by some tools. I know how to do that but better if out of the box.
Note: Idem for robots, sitemap and other SEO features.
Finally
Sorry if some points are out of scope, and i understand that you have to work with the existing without making breaking changes. But I wanted to present a few ideas I have for some time.
Anyway, great idea, good luck

Based on the conversation in the podcast meeting I wanted to throw in another point of view, that of the noob. The discussion revolved around making a theme that had all the bells and whistles, that could support the marketing style template layout and a more traditional left right col widget area layout.
The consensus was that the theme should support everything. I think it would be fine to do an advanced one but what about the people that just want a simple clean theme for their design?
The problem is that we are just setting up a minefield of options in the theme so that as a developer you are overwhelmed by all the conditional code. It's not easy to trigger every scenario so you can't see how all these combinations are used. Some are mutually exclusive. You need to enable and learn how to use every module in Orchard by the sounds of it because there was discussion about supporting search and other features when they are enabled. This means you don't know what you have to handle and what you can safely strip out for your template.
On the flip side it means that the user/admin is presented with a thousand design options that are "supported" but would blow up in their face and break the design if used.
If you're building a theme to sell then you should have to handle everything but I expect the more likely scenario will be individual developers just trying to build their own site.
In reality an individual site is only likely to use one specific combination and the extra features aren't any use. I know it's not easy to say which features should be in which but a couple of small, simple, opinionated themes would be more useful to people just trying to get started.

@rtpHarry I think the thought was that the Theme code would support a lot of functionality, but the recipe selected at setup would populate only the minimal requirements for that function (i.e. blog vs marketing, etc.).  That way, if you are building a theme, you can see how the zones interact and work, as well as how recipes can be used to manipulate the theme content and structure.

Thanks @DanielStolt

Indeed, I think part of what you're suggesting is what we're trying to accomplish by making the theme "skinnable" or configurable. The technical aspects could then be implemented once, in one single theme, while the pure visuals could be configurable aspects of that theme.

I see, the technical and configurable aspects of a theme, would that be something baked into the theme? Or more like a dependency (like Orchard.Resources), a separate module, that can be reused for other themes?
Something to note; you're referring to w3schools for market share. The page says it very clear: 'following figures are based on W3Schools' users, and are extracted from our Browser Statistics'. So the value of 0.6% is very inaccurate. Only devs visit that site :smile:
Another source tells a more realistic number I think; https://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0 where market share is 17.3% for desktop users that use IE <= 10. Statistically 1 out of 5 users. StatCounter says 24% for 'other' browsers than current up-to-date browsers.
Don't know what you think about it, but there is an option to go for Progressive Enhancement, which is a strategy that emphasizes accessibility for everyone, every browser, every connection. I know that is too idealistic perhaps, but you can see it as acting on feature detection. 'html5 support' is easily detectable for instance. You can deal with flexbox support (modernizer) and you'll be able to handle it all the way back to IE6, if you want to (not that you want to). Also, for instance, BS4 can support IE8 with some extra scripts http://v4-alpha.getbootstrap.com/getting-started/browsers-devices/#supporting-internet-explorer-8. So, that could be a configurable aspect of the theme.
Hope you're thoughts are baking and maturing :smile:

@jtkech Thanks for all the input.
@rtpHarry and @dcinzona Agree with the points made in favor of simplicity. My conclusion from the meeting discussions and a few follow-up conversations with @ryandrewburnett and @sebastienros is that the default theme should favor simplicity, elegance, an appealing first impression, and be somewhat prescriptive. I.e. make some assumptions at the expense of not showcasing all of Orchard's flexibility.
Specifically regarding the zones, we will create OuterLeft and OuterRight zones as per Seb's initial suggestions. These will span the full height of the window, and their contents will be sticky-positioned (scroll-to-fix). They will collapse to vertically stacked on smaller viewports. And they will render with a light border between them and the rest of the page, so the rest of the page won't look weird even if it contains striped sections that span the full width of the page.
@geertdoornbos Indeed, not a good source of statistics to use... :) Thanks for pointing that out. We will obviously need to cater to IE10 users if they are 17% of desktop users. Progressive enhancement is a good principle, but it does not liberate us from the burden of coming up with a defined and implemented behavior for the lower-end experiences. I'm looking to make some trade-offs here for the new theme so we can get something out there that will work on modern browsers, and not have to spend too much time and effort implementing fallback behavior for downlevel browsers.

Some ideas could be taken out of this nice Drupal theme engine.
https://www.drupal.org/project/omega

Is anything being developed?

Yes, @ryandrewburnett is working on it.

@sfmskywalker is there a project for it on github?

Not yet, we're still in the design phase. But once that's done, a repo will soon follow.

@roballred Not correct @sfmskywalker - theme is being developed in the feature/canopy branch of the main repo. Not many commits yet, but there will be more to come soon hopefully.

I stand corrected, forgot about that one.


Creating Tabs completely on the fly where each tab will hold another component which is added at runtime

Bug, feature request, or proposal:
The problem is there is no information i could find as of today to get to know how can i create a material2 tabs component dynamically.
I want to do something like this
let group = new MdTabGroup(...);
let tab 1 = new MdTab(...);
let tab2 = new MdTab(...);
// here i will put more code to add components to tab1 and tab2
//finally i would do this so that my tabs are rendered
group.add(tab1);
group.add(tab2);
What is the expected behavior?
Either documentation is incomplete or i am unable to find information
What is the current behavior?
No documentation or API information i could find
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
Allow using material components to be created dynamically in TS or JS code
Which versions of Angular, Material, OS, browsers are affected?
2..4.0
Is there anything else we should know?
There article over here https://blog.thoughtram.io/angular/2015/04/09/developing-a-tabs-component-in-angular-2.html clearly demonstrate what i am looking for. The only difference is i want to use material components directly rather than building my own component for this need.

Typically you'd use ngFor for something like this, and add to the iterable whenever new data becomes available.   Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


How to set maxlines in MardownBody ?

Anyone help Me how to set maxlines in MardownBody

@DazzlingCVa
Your question is better suited for support channels like Stackoverflow so please ask the same there.
Closing, as this is not a bug or feature request.


Move entityRefLink icon to the left

Been thinking about this for a bit.
Because of a CSS 'feature', the text wrapping div width won't collapse to each word. This means that the Icon when placed on the right becomes very removed from the text content:

By moving this Icon to the left of the content, we circumvent this 'feature' entirely.

We could fix this by using some library like: https://vercel.com/blog/react-wrap-balancer which has some whole spiel about the problem in the first place.
But looking at some of the MUI styleguide it looks like these icons are normally treated as adornments.
https://mui.com/material-ui/react-chip/#chip-adornments
So was thinking about moving this to the left.
There's an argument that this shouldn't really be used for the name of the entities in the first column of the Catalog table at all, as the dimensions are on the kind anyways, so they're all gonna be the same, but to be honest I think thats just a small thing now.

Thanks for this! Adding a little more context for posterity on why this is happening, https://stackoverflow.com/questions/37406353/make-container-shrink-to-fit-child-elements-as-they-wrap. For folks that are thinking of using the react-text-wrap library in the future, it injects its own ResizeObserver script and throws errors when resizing the window. It might be possible to fix, but seemed like a non-trivial thing.

↔
rebased and made api reports


watch suppress-markers value

Hi!
Is it possible to have two-way binding for suppress-markers directive?
Here is my plunker:
http://plnkr.co/edit/mPdo2euvMygXAU4FGAep?p=preview
Thanks!

Unfortunately, there is no get/set method for suppress-markers, which means it does not respond to two-way bindings. However you can do this in native coding
http://plnkr.co/edit/0IJYPT?p=preview

This should work for me just fine.
Thanks a lot for your help!


kind/question: Adding hooks during repository creation

Gitea version (or commit ref): v1.1
Git version: 1.7
Operating system: OSX/Ubuntu
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Hi, in case that your discourse forum currently is empty, I hopefully may ask this question here.
I currently use gitolite for a fine granulated rights management but like to replace it due to the nice interface from gitea and easier user experience.
It seems to me easy just to create some additional git-hooks to gitea which are working like gitolite.
Where is the "best place" to automatically integrate such kind of hooks. As I saw, the hooks from gitea, are prepared at models/repo.go->createDelegateHooks

https://github.com/go-gitea/gitea/blob/master/models/repo.go#L948-L981

Would this be the right place to also add some additional default hooks?
Thanks for a short hint how you would suggest to proceed.
Tom

You can add your hooks on the UI. on every repository's settings -> hooks

Hi @lunny
thanks for your feedback.
Yes I know, that I can do this manually every time on a repository. I am looking for a solution to do this automatically every time a repo is newly created.
I would like to check also, if there could be an option to integrate within gitea, that maybe also the groups and rights for a user could be used for a granulated rights management.
So my question is: How to add additional hooks by default during gitea repo creation.
Thanks for help

You can change default hook templates system-wide in /usr/share/git-core/templates/hooks/

Hi @lafriks
ok, that is also an option but in case that they will only make sense to gitea integration and I also want them to be administrateable via the gitea gui, I think those should be added into gitea.
That is at least what I would prefer.

Hi, I have tested some simple scripts from here:

https://git-scm.com/book/uz/v2/Customizing-Git-An-Example-Git-Enforced-Policy

and put that as update-hook via Git-Hooks->update
#!/usr/bin/env ruby

$refname = ARGV[0]
$oldrev  = ARGV[1]
$newrev  = ARGV[2]
$user    = ENV['USER']

puts "Enforcing Policies..."
puts "(#{$refname}) (#{$oldrev[0,6]}) (#{$newrev[0,6]})"

But it seems that the ARGV is empty.
Also a very simple
#!/bin/bash
echo "$1 $2 $3"

doesn't print out anything.
From where in the "hook call" of gitea I will be able to read the refs?

maybe this PR will fix that? @TomFreudenberg #1975

Hi @lunny thanks for guiding me to that PR. It might resolve my issue too, but I can't test it. The patch cannot be cherry-picked to release/v1.1 branch in case of missing integrations/gitea-integration-meta/gitea-repositories/...
I will check if the master branch is working for me with that applied.

Hi @lunny
Still no success, the arguments $1, $2, $3 should have been available be they are not.
Seems to me that this might be a bug?

Ok, I did a default git test
git create --bare hooks.git

and then put that above ruby example into hooks.git/hooks/update and run a test push.
That works like expected:
git push

Counting objects: 3, done.
Writing objects: 100% (3/3), 304 bytes | 0 bytes/s, done.
Total 3 (delta 0), reused 0 (delta 0)

remote: Enforcing Policies...
remote: (refs/heads/master) (5317c5) (c59a55)

To /tmp/hooks.git
   5317c5f..c59a55c  master -> master

Hi @lunny
should I do something else. If you marked that as feature and proposal, this means it can`t work currently? Correct?
Thanks for some guidiance.
Tom

It's marked as proposal for initial issue. Not having values in script arguments is other issue and is probably bug

Just checked and hooks seems to work just fine.
pre-receive:
#!/bin/sh

read oldrev newrev refname
echo "(pre-receive) Old revision: $oldrev"
echo "(pre-receive) New revision: $newrev"
echo "(pre-receive) Reference name: $refname"

update:
#!/bin/sh

refname="$1"
oldrev="$2"
newrev="$3"

echo "(update) Old revision: $oldrev"
echo "(update) New revision: $newrev"
echo "(update) Reference name: $refname"

post-receive:
#!/bin/sh

read oldrev newrev refname
echo "(post-receive) Old revision: $oldrev"
echo "(post-receive) New revision: $newrev"
echo "(post-receive) Reference name: $refname"

When pushing to repository I get output:
~/tmp/repo1$ git push
Username for 'http://localhost:3000': user1
Password for 'http://user1@localhost:3000':
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 979 bytes | 0 bytes/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: (pre-receive) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (pre-receive) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (pre-receive) Reference name: refs/heads/master
remote: (update) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (update) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (update) Reference name: refs/heads/master
remote: (post-receive) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (post-receive) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (post-receive) Reference name: refs/heads/master
To http://localhost:3000/user1/repo1.git
   da71e16..0d3b361  master -> master

@TomFreudenberg I added this proposal and feature that you said

I am looking for a solution to do this automatically every time a repo is newly created.

This is a feature that Gitea didn't support. We need some PRs to do that, So I marked this as kind/feature and kind/proposal. Maybe you can try to do that?
Another issue you mentioned above is that custom hooks is not triggered when push, @lafriks has answered that.
Thanks,
Lunny

To do not overload this ticket, I have created a separate one and moved relevant content away. Hopefully you agree to that procedure.

Replaced by #7365


Parameter is missing from Timeline callbacks

Version

Phaser Version: 3.20.1

Description
If you use a Timeline callback with extra parameters (e.g. onStart and onStartParams) the first extra parameter is missing when the callback is called.
Example Test Code
https://codepen.io/samme/pen/rNNMGyR
Should log
Timeline, 'one', 'two', 'three'

but instead logs
Timeline, undefined, 'two', 'three'

Additional Information
https://github.com/photonstorm/phaser/blob/e762a892231bd79279acd1edd9a1196950fb810b/src/tweens/Timeline.js#L286-L288

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the master branch and attributed the work to you in the Change Log. If you need to tweak the code for whatever reason please submit a new PR.


rename oragono.io/bnc and bouncer config section

"Bouncer" is confusing nomenclature for a feature that only provides sharing of nicks. It also conflicts with kiwibnc's planned "bouncer" cap.
However, "nicksharing" is not a good name. Maybe "multiclient"?
It should be easy to keep supporting old config files that use the bouncer name.

This is also exposed as the name of an account setting.

Given that we now recommend server operators make multiclient an opt-out feature, and that there is no way to opt out via the cap system as yet, it's unclear that multiclient even needs to be a cap at all.

Closed in #792


Fixed some typos

Fixed some typos and added missing word in documentation.

@swift-ci please test Linux


Maven: explode final WAR instead of using intermediate exploded WAR directory

Fixes #1091.
I will have to see if packaging a WAR file in tests works on Windows.

Yeah, as I feared, test code has problems on Windows.

Yeah, I tend to forget that recently. :laughing:


"expected one argument" error when building tensorflow-env

Invoking the following command: ./open-ce/open-ce/open-ce build env --python_versions 3.7 --build_types cuda --cuda_versions 11.0 --docker_build ./open-ce-environments/envs/tensorflow-env.yaml
results in the following error
...
Successfully tagged open-ce:open-ce-builder-cuda11.0-1000
34ae9afeb7e4b4452a024fc3ca5db06f533da3e7c8cc480065a7d8d7e95cbf96
open-ce-builder-20210217003513
usage: open-ce build env [-h] [--conda_build_config CONDA_BUILD_CONFIG]
                         [--output_folder OUTPUT_FOLDER]
                         [--channels CHANNELS_LIST] [--packages PACKAGES]
                         [--repository_folder REPOSITORY_FOLDER]
                         [--python_versions PYTHON_VERSIONS]
                         [--build_types BUILD_TYPES] [--mpi_types MPI_TYPES]
                         [--cuda_versions CUDA_VERSIONS]
                         [--skip_build_packages] [--run_tests]
                         [--docker_build] [--git_location GIT_LOCATION]
                         [--git_tag_for_env GIT_TAG_FOR_ENV]
                         [--test_labels TEST_LABELS]
                         [--docker_build_args DOCKER_BUILD_ARGS]
                         env_config_file [env_config_file ...]
open-ce build env: error: argument --python_versions: expected one argument
open-ce-builder-20210217003513
[OPEN-CE-ERROR-4] Error executing build in container: "open-ce-builder-20210217003513"

My top-level looks like:
(build_TF) $ ls
condabuild  local_files  open-ce  open-ce-environments

The pre-requisites are as follows:
(build_TF) $ conda --version
conda 4.9.2
(build_TF) $ conda list conda-build
# packages in environment at /home/<user>/anaconda3/envs/build_TF:
#
# Name                    Version                   Build  Channel
conda-build               3.20.5                   py37_1
(build_TF) $ docker --version
Docker version 19.03.8, build afacb8b7f0

Can you try moving --docker_build argument before --python_versions?
So, it should be like this -
./open-ce/open-ce/open-ce build env --docker_build --python_versions 3.7 --build_types cuda --cuda_versions 11.0 ./open-ce-environments/envs/tensorflow-env.yaml

Looks like on master branch this command isn't working due to some issue which I'm checking.
@suhailshergill - Could you please try using open-ce-v1.1.2 tag of open-ce repo? Or if you want to use master branch, please use = between python_versions and 3.7 and same for other arguments.

Copying from slack for the record
@Nishidha Panpaliya running on master with =, it seems to be progressing further than before.


Listing documents: column doctype_id does not exist in table docs

Spurious column reference.

Fixed with PR #45 .


Notify after Jenkins lisk-service-nightly job fails

What was the problem?
This PR resolves #1329
How was it solved?
The Jenkinsfile of lisk-service-nightly has been modified.
How was it tested?
After merging to the development branch, if the lisk-service-nightly task fails, an e-mail will be sent to<EMAIL_ADDRESS>

@paveleu I do not see the group<EMAIL_ADDRESS>defined in https://groups.google.com/u/1/all-groups. Could you please double check?

Destination email has been corrected and set to the newly created group.


Helm Chart v26.0.0 broke K8s Ingress management

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?
26.0.0
What version of Traefik are you using?
2.10.6
What did you do?
Our organization recently updated from using chart v24.0.0 to v26.0.0. Afterwards, whenever we would create a new ingress in our cluster it would never be assigned an Address from Traefik. The logs simply showed messages of it not being able to find endpoints even though we confirmed there were some for our respective services.
What did you see instead?
After comparing the difference between our previous manifests and the latest we discovered this line missing from the Pod's options:
"--providers.kubernetesingress.ingressendpoint.publishedservice=kube-system/traefik"

Manually adding it back in via the additionalArguments key in the Helm chart solved the issue.
What is your environment & configuration?
K8s version: 1.26.9-do.0
Traefik version: 2.10.6
Helm Chart version: 24.0.0 -> 26.0.0
Additional Information
No response

I don't see any changes in the changelog between v24 and v26.
Would you please share the values.yaml you used in v24 ? and in v26 ?

It seems this issue is solved, since there is no answer. Feel free to re-open it if needed.


Move to bvssvni

Unless there are any objections, I will move this project to my personal account in 24 hours.
While the project has been useful for bootstrapping the meta language in piston_meta, it is far from usable in the current shape. I'd like to work on it as a personal long term project.

Done.


What package should I get?

i use pacaage
npm i socket.io
npm i express

I downloaded the package and received a lot of requests like an image.
What package should we apply?
The code is the same as the original code.

Change the script on the index.html to https://cdnjs.cloudflare.com/ajax/libs/socket.io/2.3.0/socket.io.js it should work again.

I think this is due to a mismatch between the version of the client and the one of the server. This should be fixed by https://github.com/socketio/chat-example/commit/c16c98540d43c4ad5033aadf7cc2df468f1b9652.

I think this is due to a mismatch between the version of the client and the one of the server. This should be fixed by https://github.com/socketio/chat-example/commit/c16c98540d43c4ad5033aadf7cc2df468f1b9652.


how many ppl use ur xlr8 daily? acc to that, i will add more email ids in my email bomber api and also, tell me how many email ids shall i add?

@anubhavanonymous
@adityakrcodes ask @anubhavanonymous about the numbers of users
and
@adityakrcodes  y i can not bomb this number???
7970933131
is that ur number ? @anubhavanonymous

Why TF you want to know about the users of XLR8 🤔.

I don't know why you are not able to bomb that number!

@adityakrcodes that email bombing api will be improved i have made 20 email ids 1 account = 500emails/day so i added 19 more email ids in it so now, they r 20 so, 10k mails per day but, i havent pushed it in heroku yet

@adityakrcodes
@anubhavanonymous
y u close pr

@anubhavanonymous
https://xlr8-finder.herokuapp.com/find

@adityakrcodes
@anubhavanonymous
y u close pr

Cuz, we don't fking need your crap in our code!
As simple as that!🙄
BAKA!

@anubhavanonymous
https://xlr8-finder.herokuapp.com/find

Crap🙃


Difference between FeatureManagement and FeatureBits.Core

Looks like both these packages offers similar functionalities. Any particular reason to choose one over the other?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa18f095-325a-628d-9c05-551c09f7392e
Version Independent ID: 5db3af04-a314-24fd-6202-772aaa62a28d
Content: Tutorial for using feature flags in a .NET Core app
Content Source: articles/azure-app-configuration/use-feature-flags-dotnet-core.md
Service: azure-app-configuration
GitHub Login: @yegu-ms
Microsoft Alias: yegu

@anuraj Thanks for your question, we will look into and get back to you at the earliest.

@anuraj If you need to run your management onpremises, then FeatureBits will allow that via SQL Server.
FeatureManagement is backed by the Azure App Configuration service which is specifically designed for feature management. I'm not too familiar with FeatureBits abut it does look like FeatureManagement has some additional features like caching values and the ability to designate backup configuration sources if the primary is unreachable.

@anuraj FeatureManagement is a collection of libraries officially released by Microsoft and supported by a product team. FeatureBits is an open-source project. Please keep these in mind when you make a choice. Thanks!


Unable to access FortiGate site after deploying GWLB BYOD template.

I deployed FortiGate to Azure from the site below.
FortiGate Next-Generation Firewall in Azure GWLB
https://github.com/fortinetsolutions/Azure-Templates/tree/master/GWLB
When deploying, if I select "fortinet_fg-vm_payg_20190624" for the "Forti Gate Image SKU", I can access the FortiGate site,
but if I select "fortinet_fg-vm", I will not be able to access the FortiGate site.
How can BYOD use FortiGate?

Hi,
Please use the official template from the Fortinet repository:
https://github.com/fortinet/azure-templates/tree/main/FortiGate/AzureGatewayLoadBalancer
or our early release repo here:
https://github.com/40net-cloud/fortinet-azure-solutions/tree/main/FortiGate/AzureGatewayLoadBalancer
In these templates, you can select BYOL or PAYG.
Hope this helps you in your deployment.
Joeri

Hi Joeri-san,
Thank you for reply.
I have used the official template to deploy.
The deployment was successful, but the FortiGate site was still inaccessible
https://github.com/fortinet/azure-templates/tree/main/FortiGate/AzureGatewayLoadBalancer
I have summarized the situation in the attached excel.
Could you please confirm?
Best Regards.
ALSI Murakami
From: Joeri @.>
Sent: Tuesday, August 8, 2023 5:18 PM
To: 40net-cloud/fortinet-azure-solutions @.>
Cc: 村上 諒介 Ryosuke Murakami @.>; Author @.>
Subject: Re: [40net-cloud/fortinet-azure-solutions] Unable to access FortiGate site after deploying GWLB BYOD template. (Issue #322)
Hi,
Please use the official template from the Fortinet repository:
https://github.com/fortinet/azure-templates/tree/main/FortiGate/AzureGatewayLoadBalancer
or our early release repo here:
https://github.com/40net-cloud/fortinet-azure-solutions/tree/main/FortiGate/AzureGatewayLoadBalancer
In these templates, you can select BYOL or PAYG.
Hope this helps you in your deployment.
Joeri
—
Reply to this email directly, view it on GitHubhttps://github.com/40net-cloud/fortinet-azure-solutions/issues/322#issuecomment-1669137829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE54Y5DNQDE2RBE34QBSU2LXUHY2ZANCNFSM6AAAAAA3H2DNPM.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Hi Joeri-san,
I'm sorry, I couldn't attach the file.
I will attach it again.
Could you please confirm?
Murakami
FortiGate_error_20230808.xlsx

Hi Murakami-San,
I've reviewed your submitted errors in the xlsx file. There seems to be an issue with FortiOS version 7.4.0 on the routing it seems combined with our config we supply in the template. This is however not the default FortiOS version we currently recommend.
Can you try again with version 7.2.5? That should work accordingly. Alternatively you can remove the static route number 2.
Let us know how it goes.
Joeri

Hi Joeri-san,
Thank you for youre reply.
I tried version 7.2.5 and I can access the site both PAYG and BYOL.
Thank you very much !
Best Regards.
Murakami.


APP-3557: Add Registry Item External Usage, Updated, Created fields

Adds fields that return external usage of the registry item (both orgs and robots) as well as Created and Updated fields.

Hey @hexbabe / @ehhong can one of you re-approve the PR? The compile protos job didn't kick off.


Fix and simplify delete_project_users(), add refresh option

Closes #355

Codecov Report

Merging #356 (2907ac1) into main (01f6ece) will decrease coverage by 0.08%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   94.14%   94.05%   -0.09%
==========================================
  Files          55       55
  Lines        2543     2556      +13
  Branches      326      328       +2
==========================================
+ Hits         2394     2404      +10
- Misses        111      113       +2
- Partials       38       39       +1

Impacted Files
Coverage Δ

pyinaturalist/session.py
96.55% <66.66%> (-1.07%)
:arrow_down:

pyinaturalist/v1/projects.py
93.33% <89.47%> (-2.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f6ece...2907ac1. Read the comment docs.


The docs would be better readable if not expanded by default

As I learned today about your docs, this is our automatically generated docs and looks useful. But as a developer I'm overloaded with attributes. Instead I would like to see root entries at the start only (for our API and the "vrp" endpoint this would be just algorithm, relations, services, ...) and then expand just one entry like services to see address, allowed_vehicles, etc

@karussell great idea! Thanks.
I will definitely implement this for the first public release.

@karussell I've implemented the feature.
You can check your spec look now!

Cool, looks good!
Will include this then in our docs -> https://github.com/graphhopper/directions-api/issues/32


undefined reference to STATUS_SUCCEEDED

[Enter feedback here]

The quick start guide forgot to mention this line.
const STATUS_SUCCEEDED = "succeeded";
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef96562d-099d-9400-c88c-ba0439e136a6
Version Independent ID: 049314ea-8e68-50ee-3469-4d39c801fc54
Content: Quickstart: Computer Vision client library - Azure Cognitive Services
Content Source: articles/cognitive-services/Computer-vision/quickstarts-sdk/client-library.md
Service: cognitive-services
Sub-service: computer-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@yajnesh
Thanks for the feedback! We are currently investigating and will update you shortly.

@PatrickFarley I can not make the change since it's not in Azure-doc-pr repo, could you please help to fix it? Thanks a lot.

I've added the missing snippet to the docs
#please-close


Generation of multi target bup

Hello,
i have a question about the generation of bup payloads. Is it possible to generate some kind of multi target payloads? I would like to generate a single payload that can be used for the different hardware revisions of TX2 hardware which is around.
Thanks,
Klaus

All of the branches based off L4T R32.3.1 and later generate multi-spec BUP payloads, similar to the l4t_generate_soc_bup.sh script that comes with L4T. The TEGRA_BUPGEN_SPECS variable controls the set of specs used.

Thank you very much for this quick info and your great work on meta-tegra.


Start creating Mentat documentation using Sphinx.

Setup the basic Sphinx setup to create documentation. The first step will be to simply create the basics so we have a working sphinx framework.

There is documentation now live at docs.mentat.ai


Ticket Functionality

Feature Summary
Exchanging Messages and responses on Tickets. This project will require both UI and backend work to create the features that make up the core function of osTicket.
This project should start off with Mockups that are discussed and redesigned as needed before coding.
Features

[ ] Messages
[ ] Responses
[ ] Internal Notes
[ ] Alerts/Auto Responses
[ ] Create Ticket from a Message/Response

Reference a message or response as the first post on a new Ticket

[ ] Create Task from a Message/Response
[ ] Add a Canned Response to the Ticket

We should be able to search for keywords in Canned Response title

I think it would be great if tickets were "on hold" and the ability to set scheduled return to "open" status.


 We probably shouldn't be printing a confusing warning about it not being a supported file when calling tc.load_images:
Unsupported image format. Supported formats are JPEG and PNG file: style/.DS_Store`

Issues filed due to user feedback in #636.

Agreed, let's silently skip files named .DS_Store.

We identify image formats only by inspecting file extensions, so to me it makes the most sense if this code simply ignored all files that don't have a supported extension. If no supported files are found, we can emit a warning then. It seems more likely that a user might have auxiliary data in these directories that they want us to ignore, then that they will be confused if we silently ignore some unsupported file format, especially if we document load_images clearly.


musikcube: Fix build on macOS

Description of changes

#214077 broke the build on macOS, which failed with:
error: Dependency is not of a valid type: element 15 of buildInputs for musikcube

This PR addresses this by

enabling pipewire only on Linux
adding CoreAudio buildInput when coreaudioSupport is true

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Sorry for breaking the macOS build :sob:. Thx for taking care and fixing it :smiley:

Thanks!

Not to worry, @tuxinaut :) Out of curiosity: How come #214077 passed the GitHub tests? Shouldn't these have caught the broken macOS build?
Thanks for merging this so quickly, @aanderse :pray:


Viewer does not like properties that start with "@"

I have this json content, and it causes a very strange output from demo viewer.
{
        "@context": "http://purl.imsglobal.org/ctx/caliper/v1/Context",
        "@type": "http://purl.imsglobal.org/caliper/v1/AssessmentEvent",
        "action": "http://purl.imsglobal.org/vocab/caliper/v1/action#Started"
}

Ironically, this issue is not present in the current json.human.js project

Thanks for reporting @oravecz. I think someone else brought up the same issue before but I couldn't figure it out. I would welcome a PR if you know how to fix it! =D
Also, this project is inspired by json.human.js but it's not a direct port or anything so the bugs in this project are irrelevant to the bugs in json.human.js.


Cannot Load File: Failed to open diagnostics file. json_reader.dia

Hi im having some issues trying to compile the FlareSwift, bellow an screenshot:

On the ./make_dependency.sh I received just one message about a HEAD referral:

Any help would be appreciated.
OSX 10.15.4 (19E266)
Xcode Version 11.4 (11E146)

Hey, have to solved this issue @brokenheist, can you help me with this? I'm facing this right now 😢


[AutoPR keyvault/data-plane] Update Auto rest specs for KeyVault

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5759

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/2714


Port codebase into vuejs

@heysagnik Thanks for telling me this, I will do it.
But as my changes are pretty big + breaking, it's much better to review and merge this PR, then I will do that in another PR.

@heysagnik As I am doing the contributions to be part of the hacktoberfest, may you add the hacktoberfest-accepted label please ?
Note : remember to review and leave an approval before merging, to avoid adding that label manually.


Support the parameters whose type is Optional for annotated services

e.g.
@Get("/users/{userId}")
public HttpResponse getUser(@Param("userId") Optional<String> userId) {
    ....
}

... which would let a user choose to use our @Optional annotation or JDK's Optional.

/cc @hyangtack

If this is implemented well, we may want to remove our @Optional annotation in favor of JDK's Optional.

@trustin
I tried to implement this issue here.
But I'm not sure yet whether it's useful or not. A user may specify a default value when he or she uses an optional parameter. In this case, there might have no advantage. For example,

Old implementation with @Optional

        @Get
        @Path("/param/default1")
        public String paramDefault1(RequestContext ctx,
                                    @Param("username") @Optional("hello") String username,
                                    @Param("password") @Optional("world") String password,
                                    @Param("extra") String extra) {
            return username + "/" + password + "/" + extra != null ? extra : "(null)";
        }

New implementation with Optional and @Default

        @Get
        @Path("/param/default1")
        public String paramDefault1(RequestContext ctx,
                                    @Param("username") @Default("hello") Optional<String> username,
                                    @Param("password") @Default("world") Optional<String> password,
                                    @Param("extra") Optional<String> extra) {
            return username.get() + "/" + password.get() + "/" + extra.orElse("(null)");
        }

To specify a default value clearly, I needed to add @Default annotation which is very similar to @Optional used before. I think that it might be general use-cases, so the old implementation seems like more clear, from this point of view. What do you think?

A user could simply use Optional.getOrElse()?

@trustin Yes, it's enough on the above example code. But a user may write as follows if the variable uses several times in the codes, so one more unnecessary variable may be required. It's my worry. :-)
final String name = username.orElse("someDefaultValue");

@hyangtack Yes, I think a user can just declare a new local variable if he or she needs to access the parameter more than once.

@trustin As we discussed on LINE chat,

Change @Optional to @Default
Support Optional as the same with @Optional
Thanks! :-)

Fixed via #775


travis.yml: 1.4.2, also try -race.

also reduce paasio concurrency a bit to pass with -race.
-race makes sense with a couple of exercises now using concurrency.  (This doesn't have to go ahead of ledger, it could wait its turn.)

Wouldn't this give intermittent failures when running the tests? As I read the example code there's a big fat race in Write() since that calls Write() on the io.Writer outside of the mutex. the TestWriteTotal test runs multiple goroutines that call Write() and the implementation of bytes.Buffer doesn't seem to be thread-safe.

Paasio may have some issues.  They should probably be filed as a separate issue.

What's the status of this? Did Paasio ever get updated?

Issues of potentially unsynchronized writes in Paasio are independent of this PR.  Running the race detector can't cause any problems that aren't already there, it can only find problems.  I'll rebase this after the current travis PR goes in.

OK, cool (and merged).

Katrina, take a look if you like.  The change to Paasio lowers the number of goroutines from 10000 to 8000 because the race detector has a limit of 8192 goroutines.

That makes sense. Thanks!


[v1.5] SortCommand for Tasks + Junit tests for Sort for tasks/persons

Coverage decreased (-0.9%) to 82.41% when pulling 3e1b794ca80bd1aceeae27145096a95212fe69bf on charlesgoh:altersize-buttons into 2e2b97b46b881441b7fb28ecf6e6748dc79e472d on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.9%) to 82.41% when pulling 7275c197344b00a83f0ae1cd467f73a4945828f4 on charlesgoh:altersize-buttons into 2e2b97b46b881441b7fb28ecf6e6748dc79e472d on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.3%) to 82.97% when pulling 15750f0622ffba37bb49e9757a0979fb398b87d1 on charlesgoh:altersize-buttons into 3a4bb2dd24f600d4b763c66b6b0ed2aad644a668 on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.3%) to 82.97% when pulling 8f4a5eace39c8fa232b440ebd07ae547dda539a4 on charlesgoh:altersize-buttons into 3a4bb2dd24f600d4b763c66b6b0ed2aad644a668 on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.3%) to 82.97% when pulling c303ff66e476de982854563e28902e143271b5f0 on charlesgoh:altersize-buttons into 3a4bb2dd24f600d4b763c66b6b0ed2aad644a668 on CS2103AUG2017-W09-B2:master.


Update avif.json

Firefox 93 released in nightly channel also does support avif

Thanks! This and the othe features work in the default version on iOS and Android, but not the proxy version which is used by the majority of Opera Mini users on feature phones, which is what is tracked on caniuse.
As shown on the site:

Hi, This pull request was for Firefox 93 not opera mini

Ah you're right, looks like I put the comment in the wrong place. The Firefox 93 data has also been updated though, so no need for this PR. Thanks!


Products page have not correct link for "Book a demo"

It should be: https://gatling.io/book-a-demo?hsLang=en
but is same as "Start for free":

Fixed, thanks a lot!


Develop

Hello @kaulketh! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bots/telegramBot.py:

Line 94:25: E128 continuation line under-indented for visual indent


Accessibility: Error and success messages have no icons

Error and success messages do not have an icon indicating the state of the message for users that cannot use color information.

Checkboxes as viewed with protanopia (8 percent of men and 0.5 percent of women)
Add checkmark and exclamation mark icons to error messages.

This is handled by a new design for valid states. Will create style update tickets when design is ready.


Tooltip on Barchart: index out of range

[Short description] I get an index out of range when switching between different BarCharts with different length of BarChartGroupData when tooltip is always showing.
I have lots of BarCharts with multiple BarChartGroupData each. I switch between different BarCharts with a slider. The number of BarChartGroupData for each Barchart differs!
The tooltip is always showing by setting "showingTooltipIndicators: [0]".
When I switch between a Barchart with 10 BarChartGroupData to a Barchart with 11 BarChartGroupData everything works fine!
However, when I switch from 11 to 10, the exception occurs.
Important:
I am only able to reproduce this bug when the tooltip is always showing with "showingTooltipIndicators: [0]".
I use most recent version of flutter and fl_chart
EDIT:
here is code to reproduce:
class MyWidget2 extends StatelessWidget {
  final int max;
  const MyWidget2(this.max, {Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Container(
      height: 100,
      child: BarChart(
        BarChartData(
          barGroups: [
            for(int i=0; i<max; i++)
              BarChartGroupData(
                x: i,
                showingTooltipIndicators: [0],
                barRods: [
                  BarChartRodData(
                    y: 1,
                  ),
                ],
              ),
          ],
        ),
      ),
    );
  }
}

If you switch between different max values, for example MyWidget2(11) to MyWidget2(10), an Index out of range exception occurs.

The problem is caused by the animation when changing. Ideally, the tooltips should be deactivated in the package during animation. Alternatively, the chart can be used in a stateful widget and the permanent tooltips can be activated via a PostFrameCallback.
The simplest workaround is to disable the animation.
BarCart(
    ...
    swapAnimationDuration: Duration.zero,
)

Hi guys.
Can you please check it with the latest version?

If it still happens, please give me a reproducible code.

If it still happens, please give me a reproducible code.

I get the same error with the code I have attached in the initial post.

Specifying unique key on BarChart() fixes this
key: UniqueKey(),


Fix radius multiple bug

We allow radius multiple to be set to other than 1.5, but the math for calculating the switchover from Gaussian to quadratic is for a fixed value.
Truncated Gaussian if multiple <= 1.0

071fc2:


Hang on click of Done button after selecting images

After selecting images. I'm clicking on Done button and then it hangs for 2 or 3 seconds.

Yes, this library should show a loading indicator as it downloads the images from the cloud - that's the issue with the hang.

Instead of hanging, you can just use the asynchronous downloading and can show loading indicators for the cells.

Thanks for bringing this to my attention. I am deprecating the selectImages closure and delegate function in the next version. Instead of working with UIImage, I think it makes more sense for the users of the library to download their desired resolution from the cloud using the selectAssets and PHAsset and show a loading indicator after the picker has been dismissed.


Formal equiv diff asicworld_code_tidbits_fsm_using_always.v

Test yosys/tests/asicworld/code_tidbits_fsm_using_always.v
The plugin generates parameters that are 32 bit wide where they should be 3 bits wide.

Fixed by https://github.com/chipsalliance/yosys-f4pga-plugins/pull/402.


Use mime-types instead of send.mime

The mime-types module has a few small differences compared
to mime:

mime-types API for getting charsets is slightly different
to mime

mime-types uses mime-db which has a comprehensive list of
charsets for mime types, whereas mime uses a simple rule:
UTF-8 for any type starting 'text/' and a caller-defined
fallback for anything else

mime-types will return false if it cannot find a particular
mime type in mime-db, whereas mime will default to
'application/octet-stream' if it does't find the mime type
in its types.json file

This commit makes the necessary changes to address these
differences.
The mime module to use is now populated by
require('mime-types') rather than reaching into the send
module with require('send').mime.
One of the tests has been updated as a result of the charset
lookup differences in mime-types, since mime-types gives
UTF-8 as the charset for 'application/javascript' whereas
mime returned the caller fallback (undefined in this case.)
From what I can tell both the resulting values are valid in
the Content-Type header (either 'Content-Type:
application/javascript; charset=utf=8' or 'Content-Type:
application/javascript') so I have updated the testcase to
test for the former instead of the latter.

I have added mime-types as a dependency at ~2.1.10, let me know if that is not the version we should take.
This PR is to address the item "Use mime-types instead of mime" from the Release 5.0 checklist.

We should always be using the export from send. This change requires getting send changed first, then pulled down here.
The reason is because people can add custom types, and we want them all combined together.

OK, I noticed that send 2.x is already using mime-types, but it doesn't seem to expose it in its exports. This is why I assumed that we were moving to a direct require.
Since that isn't the case, is the plan to release send 1.x and then move Express 5.0 up to that version (it's currently pointing at 0.13.1)? Do we just need to update send 1.x to export mime?


Emissions subgraph - Wrong Event for UpdatedDials

The event that is being triggered UpdatedDial(indexed uint256,bool) on updating the dials, this Event is wrong and does not match the event actually triggered.
The correct event is UpdatedDial(indexed uint256,bool,bool)

fixed and redeployed
https://github.com/mstable/mStable-subgraphs-monorepo/pull/31/files#diff-918ececaa70bafc5d123f4555519d812a745c17a2acc8e2bf04743040c87efdd

can we close this issue? @calvinkei

@dimsome yes


Unit test on travis failure on push

Unit test on travis run fails on push
But works ok on local environment.

Written by @xqliu
Created at 2016-06-02T15:46:37.000+0800
Link to http://betterlife.atlassian.net/browse/BE-231

This is related to https://github.com/flask-admin/flask-admin/issues/1263

Written by @xqliu
Created at 2016-06-06T11:27:17.109+0800


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: D3rek sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


chore/MM-39425 : Migrate ModalStore modals to use ModalController and remove ModalStore

Summary

This pr migrates following the pending modals still dependent on ModalStore event listeners to redux modal implementation:

[x] ImportThemeModal
[x] GetPublicLinkModal
[x] KeyboardShortcutsModal
[x] LeavePrivateChannelModal

Unused modal listeners in ModalStore cleared for :

[x] ChannelPurposeUpdateModal
[x] QuickSwitchModal
[x] ToggleDeletePostModal
[x] ShowGetTeamInviteLinkModal
[x] ToggleChannelNameUpdateModal

Ticket Link

https://mattermost.atlassian.net/browse/MM-39425
Related Pull Requests

Has server changes (please link here) - none
Has mobile changes (please link here) - none

Screenshots

Release Note

@hmhealey added more review changes

/release-note-none

/update-branch

Error trying to update the PR.
Please do it manually.

E2Es results look good, no PR related failures.

/update-branch


Smoketest: Bring back data migration tests again

The data migration tests were lost in the last couple of months when the smoketests underwent a big refactoring.
@bpasero I wonder if we can perhaps test data migration in unit/integration tests instead, since they aren't necessarily UI tests (involving clicks, keyboard action, DOM nodes, etc).

@joaomoreno isn't the migration test starting stable first and then insiders to see if the UI state is the same? Given this is about starting 2 different milestones of the product, I do not see how we could test this with unit tests.

I don't know where that notion of stable+insiders came from, but I think it is wrong. It should be two consecutive stable versions, right? The flavour should remain the same.
I guess we can have the smoketest download a version -1 of the current version off the internet and use it for the tests.

@joaomoreno yeah it is stable vs stable-1, but typically when we run this test we do not have a stable release yet, so we use the last insiders before declaring that one stable.


Bugfix: Add github action to generate an app token for automated PR on documentation

Description
What's new?

Fix #1245

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

@kbeaugrand I added the bot's secrets to the project


[Input] Incorrect easing function.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

https://github.com/mui-org/material-ui/blob/bfbf4ed7f765ebf6760b22a598ad6e4eb9f6f244/src/Input/Input.js#L50
Easing function that used in this line does not exists in theme definition. easeInOut will used instead as default value.

@strayiker You are correct, it does no longer exist. What about simply removing this line? material-components-web is using easeInOut (.mdc-line-ripple).


Adding css-modules with a custom Rollup config breaks the build.

Current Behavior
Create a new project with react template: npx tsdx create mylib

Add postcss plugin and extend Rollup config with tsdx.config.js

yarn add -D rollup-plugin-postcss

const postcss = require('rollup-plugin-postcss');
module.exports = {
  rollup(config, options) {
    config.plugins.push(
      postcss({
        modules: true,
      })
    );
    return config;
  },
};

Add a test css-module file /src/style.module.css, import and use it in /src/index.tsx

.test {
  color: red;
}

import * as React from 'react';
import styles from './style.module.css';

// Delete me
export const Thing = () => {
  return
the snozzberries taste like snozzberries
;
};

Build the library

yarn build

The build script exits with this error:

Suggested solution(s)
Apparently, the custom configuration added in tsdx.config.js  is not interpreted and the parser doesn't seem to know how to manage the .test css class in style.module.css.
If you downgrade TSDX to 0.9.3 the build passes.
This issue happens with TSDX >= v0.10.0
Your environment

Software
Version(s)

TSDX
0.10.5

TypeScript
3.6.4

Yarn
1.19.0

Node
v10.15.3

Operating System
macOS 10.14.6

I dug inside the code, and from what I've seen, the issue started when @medelman17 added @wessberg/rollup-plugin-ts in place of rollup-plugin-typescript2 two weeks ago.
Here: https://github.com/jaredpalmer/tsdx/commit/bfc0590e0fbce68fc2594c4c2be12400272eebab#diff-85d99c527c01407b9055b07762a4ad45L11
On my computer I just reverted the changes only on that file, and with the old configuration the build passes, but I don't know how to fix using @wessberg/rollup-plugin-ts.

I played a little more and I found that if I use typescript instead of babel as a transpiler in @wessberg/rollup-plugin-ts config, the build passes.
https://github.com/jaredpalmer/tsdx/blob/master/src/createRollupConfig.ts#L146

Last but not least, I found that probably the issue is not strictly related to css-modules or a custom tsdx.config.js but more simply to the import of a CSS file.
Removing tsdx.config.js file and importing the css, returns the same build error:
/src/style.css
.test {
  color: red;
}

/src/index.tsx
import * as React from 'react';
import './style.css';

// Delete me
export const Thing = () => {
  return
the snozzberries taste like snozzberries
;
};

do you mind retrying with v0.11? we reverted that change. reopen if still persists.

I can confirm @sw-yx, upgrading to v0.11 solves the issue. Thanks.


Maurille

Pat and Tap

Pat and Tap

Sup Mr. Benton,
You learning git?
On Thu, 2 Mar 2023 at 11:48 PM Maurille B Beheton @.***>
wrote:

Merged #3 https://github.com/rh-impact/pl-pygifsicle/pull/3 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/rh-impact/pl-pygifsicle/pull/3#event-8653574218, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE6TGAXW63F6Q5Z77GOOHDW2EBSLANCNFSM6AAAAAAVN3HMSU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sup Mr. Benton, You learning git?
…
On Thu, 2 Mar 2023 at 11:48 PM Maurille B Beheton @.> wrote: Merged #3 <#3> into main. — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6TGAXW63F6Q5Z77GOOHDW2EBSLANCNFSM6AAAAAAVN3HMSU . You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes, I am.

Awesome,
Let me know what you need. How was Citrix scholarship, congratulations...
On Sat, Mar 4, 2023, 12:21 AM Maurille B Beheton @.***>
wrote:

Sup Mr. Benton, You learning git?
… <#m_-6289642729009192246_>
On Thu, 2 Mar 2023 at 11:48 PM Maurille B Beheton @.> wrote: Merged #3
https://github.com/rh-impact/pl-pygifsicle/pull/3 <#3
https://github.com/rh-impact/pl-pygifsicle/pull/3> into main. — Reply to
this email directly, view it on GitHub <#3 (comment)
https://github.com/rh-impact/pl-pygifsicle/pull/3#event-8653574218>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE6TGAXW63F6Q5Z77GOOHDW2EBSLANCNFSM6AAAAAAVN3HMSU
https://github.com/notifications/unsubscribe-auth/AAE6TGAXW63F6Q5Z77GOOHDW2EBSLANCNFSM6AAAAAAVN3HMSU
. You are receiving this because you are subscribed to this thread.Message
ID: @.>
Yes, I am.
—
Reply to this email directly, view it on GitHub
https://github.com/rh-impact/pl-pygifsicle/pull/3#issuecomment-1454145796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE6TGBZKNY2PXPXDOI2GYLW2JOGFANCNFSM6AAAAAAVN3HMSU
.
You are receiving this because you commented.Message ID:
@.***>


Add done custom action in wit

Every story in wit should trigger the done action to end a conversation. With this, the session will be removed from the server and a new one will be issued when a new conversation is started.

Will be closed in #16

Closed in #16


primary key in the update index method should be optionnal

Description
Currently the method to update an index requires a primary key as per the method definition:
pub async fn update(&self, primary_key: impl AsRef<str>) -> Result<(), Error>

As an example:
client.index("movies").update("movie_review_id"));

Expected behavior
In Meilisearch the update route accepts no primary Key field being defined, or one set to null. See spec.
Current behavior
The primaryKey is required. It should not and could introduce a big breaking change if a new parameter becomes updatable on the update index route. In which case the user is going to have to define a primary key even if they only want to update the other parameter(s).
Environment (please complete the following information):

Meilisearch version: v0.27.1

I'll mess around with this!

Fixed by #315


Showcase Submission for ml5/0-introduction/patt-vira

Thank you Neil Whaley for your contribution! A member of the Coding Train team will review it shortly.

Head tracking with ml5.js
Neil Whaley

Fantastic!


Trouble with schematica mod

When I use the linked key for schematica mod schematic selection on minemenu it gets kind of "stuck", it opens normaly (the schematic selection menu) but it cant be closed since it reopens again forcing one to reestart the client.
I made sure to try differents keys and verified that it as on press and not toggle

Known issue. Not sure when I will have time to take a look at fixing it though.


Update Copyrights to 2016

Might be better to be more future-proof by saying "2014-Present" instead.

I like the idea of "2014-Present", would you be able to update this PR to use that instead? :smile:

Sure

Updated :)

Manually merged in df0313d652b339b1f6cdbf59811da219611c0973 due to a conflict in one file. Thanks for your contribution, and sorry it took me so long to reply!


don't upload config layers for now

to match the rclone job, and focus on replacing it.

/lgtm
/hold
Remove the hold when ready.

/hold cancel


Tool to automatically open issues when TODO is found

There are quite a few TODO comments in the code and no issues associated. We should have a script that is run in travis (master) that:

looks for all the TODO comments in the JS code (we probably just split by line)
checks if the comment has a #ID somewhere or a url to the GitHub issue

if yes it doesn't do anything
if not

it creates a new issue in GitHub with the title as the TODO comment, and the body with the name of the file and the line number
adds the #id to the end of the comment and commits the changes

I don't think it will be super complicated and can probably be a separate project.
There are some projects that do similar things, check todo search in npm. My 5 minute search didn't trigger anything like what I want but we should look a bit more into it.

I've created this label for the issues created automatically.