PriorityQueue needs rework

As pointed out by #919 and #941, A* search is behaving incorrectly. This is partly due to the way the A* implementation interfaces with the PriorityQueue (in utils.py). Due to how __contains__ is implemented in PriorityQueue, if the heuristic function passed to A* produces non-unique values for the same state (As in the case of #919), A* would re-visit the same state multiple times.
#829 also raises some concerns about the implementation of __getitem__ and __contains__ in PriorityQueue. While these methods seem similar, they are quite distinct. Using __getitem__ instead of __contains__ should fix A*. However, since both these functions are confused many times (#828), we should include at least some documentation and test cases to illustrate this use. Another solution to this confusion would be altering the roles of __getitem__ and __contains__ such that for a priority queue A and element x:

x in A returns whether a copy is present regardless of its function value

A[x] returns the function value of a copy if it is present in the queue, else throws a KeyError like other dicts in python.

Is this issue resolved? If resolved, why is it still open?

Yes. My PR works to resolve this issue and those I've mentioned in it. I think they'll be closed once the PR is merged.


[new] PeerSwap usage

New feature as started to implement in:

[ ] #3202
Documenting the usage flow and quirks here.

https://github.com/ElementsProject/peerswap/blob/master/docs/usage.md
Commands in CLN:
lightning-cli peerswap-<command>.
peerswap-addpeer peer_pubkey
    Add peer to allowlist

peerswap-allowswaprequests allow_swap_requests
    Sets peerswap to allow incoming swap requests

peerswap-getswap swap_id
    returns swap by swapid

peerswap-lbtc-getaddress
    get new liquid address

peerswap-lbtc-getbalance
    get liquid liquidWallet balance

peerswap-lbtc-sendtoaddress address amount_sat
    sends lbtc to an address

peerswap-listactiveswaps
    Returns active swaps.

peerswap-listpeers
    lists peers supporting the peerswap Plugin

peerswap-listswaprequests
    Returns unhandled swaps requested by peer nodes.

peerswap-listswaps [detailed]
    list swaps

peerswap-reloadpolicy
    Reload the policy file.

peerswap-removepeer peer_pubkey
    Remove peer from allowlist

peerswap-resendmsg swap_id
    resends last swap message

peerswap-swap-in amt_sat short_channel_id asset
    swap In

peerswap-swap-out amt_sat short_channel_id asset
    swap out

For LND:
 ₿ pscli
NAME:
   pscli - PeerSwap Cli

USAGE:
   pscli [global options] command [command options] [arguments...]

VERSION:
   commit: baf6e4c38d16dcd922f94e777bcd892db5b0bc5f

COMMANDS:
   swapout             Perform a swap-out (sending lightning funds to receive onchain funds)
   swapin              Perform a swap-in (sending onchain funds to receive lightning funds)
   getswap             Get a swap by its id
   listswaps           lists all swaps
   listpeers           lists all peerswap-enabled peers
   listnodes           lists all peerswap-enabled nodes in the network
   reloadpolicy        reloads the policy file and polls all peers with the new policy
   listswaprequests    lists requested swaps by peers
   lbtc-getbalance     gets the current lbtc balance
   lbtc-getaddress     gets a new lbtc address
   lbtc-sendtoaddress  sends the sat amount to a lbtc address
   stop                stops the peerswap daemon
   listactiveswaps     list active swaps
   allowswaprequests   Sets peerswap to allow incoming swap requests (used for updating=
   addpeer             Adds a peer to the allowlist
   removepeer          Removes a peer from the allowlist
   help, h             Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --rpchost value  peerswapd grpc address host:port (default: "localhost:42069")
   --help, -h       show help
   --version, -v    print the version

Great post on the economics compared to Loop: https://stacker.news/items/382449

Finding peers using PeerSwap: https://amboss.space/community/181aad24-1871-4be9-ab6d-10ac71383c42


[4534] Add record_source field to trainee

Context
https://trello.com/c/fUMWQZqP/4534-add-record-source-field-to-trainee-to-show-us-when-its-only-been-trn-requested
We need a way of distinguishing between trainees who were created over the HESA TRN data endpoint and have never come to us over the HESA collection endpoint. These need to be excluded from the UI.
We decided to add a record_source field to track this. We can also use this to clean up our code elsewhere where we derive the record source from various things (see renamed def derived_record_source which can be removed once we do the backfill). Then we can swap the record source filter and all the various scopes to use this new field.
Changes proposed in this pull request

Add record_source field to trainees
Set manually created trainees record_source to manual
Save trainees created from Apply record source to Apply
For completeness, save trainees created from DTTP record source to DTTP
Save HESA record_sources on trainees created from HESA (HESA collection and HESA TRN data)
Handle swapping between HESA TRN data and HESA collection sources

If a trainee is seen over the TRN data endpoint, but was originally created via the collection
DO NOT set the record_source to be HESA TRN data.

Temporarily re-name current record_source method until we backfill

Note: no validation on new field until we do the backfill
Guidance to review

Check that the record sources still show on trainees as an admin
Check that the record source filter still works
Check that the download still contains the correct record source

Important business

[x] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Not PII

[x] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml
Confirmed no PII, added to analytics.yml

 Add record source field to trainee to show us when it's only been TRN requested

Record source filter is missing 'Apply'. Is this just because there are no 'Apply' trainees here?

When I click 'Imported from DTTP' it shows me Record Source: HESA. But I'm guessing this is because they originally came from DTTP, then later got updated from HESA, so we updated the Record source? This feels right to me. But when I looked at the timeline for some of these trainees, they just indicate the record was created, never updated? https://register-pr-2638.london.cloudapps.digital/trainees/BCveJLBi7AwZAhhxH8ZuGSnV/timeline

Thanks @claire-hughez ! Hopefully this clears things up:
No Apply filter

Record source filter is missing 'Apply'. Is this just because there are no 'Apply' trainees here?

Yep, looks like our seeds never actually create Registered Apply trainees, hence there's no filter for that.
HESA vs DTTP

When I click 'Imported from DTTP' it shows me Record Source: HESA. But I'm guessing this is because they originally came from DTTP

Yes, the seed data for these trainees has created_from_dttp set to true hence they appear in the DTTP filter. They also have a hesa_id set on them so should also appear in the HESA filter.
Remember the filter uses the old code still, not the new record_source field (which is currently nil for all trainees). There is a separate card for swapping over to use the new field.

then later got updated from HESA, so we updated the Record source?

We've never had a record_source field or a concept of "updating the record source" until now. Going forward this will be how it works.
These trainees have a hesa_id set on them, so the displayed text in the UI says "HESA" not "DTTP". This was a product decision. In production, trainees who originally came from DTTP with a hesa_id and who have never been updated via HESA will still show as "HESA" in the UI.

But when I looked at the timeline for some of these trainees, they just indicate the record was created, never updated?

The timelines for these trainees never really look correct because they're not real trainees, they're just seeds. They are created the moment the review app is created, and have never gone through any actual updates.

Thank you for explaining, obviously still learning a lot about how it all works :) Looks good!


Issue while starting Docker service.

Description

Steps to reproduce the issue:
sudo yum update
sudo yum install docker-engine
sudo service docker start

Describe the results you received:
Redirecting to /bin/systemctl start  docker.service
Job for docker.service failed because the control process exited with error code. See "systemctl status docker.service" and "journalctl -xe" for details.

journalctl -xe shows below result :-1:
Jan 22 21:48:30 va10dlvpoc145 sudo[3107]:  ac51178 : TTY=pts/0 ; PWD=/usr/bin ; USER=root ; COMMAND=/sbin/service docker start
Jan 22 21:48:30 va10dlvpoc145 polkitd[629]: Registered Authentication Agent for unix-process:3108:176305 (system bus name :1.64 [/usr/bin/pkttyagent --notify-fd 5 --fal
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: Cannot add dependency job for unit microcode.service, ignoring: Unit is not loaded properly: Invalid argument.
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: Starting Docker Application Container Engine...
-- Subject: Unit docker.service has begun start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit docker.service has begun starting up.
Jan 22 21:48:30 va10dlvpoc145 docker[3125]: Command "daemon" is deprecated, and will be removed in Docker 1.16. Please run `dockerd` directly.
Jan 22 21:48:30 va10dlvpoc145 docker[3125]: no sockets found via socket activation: make sure the service was started by systemd
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: docker.service: main process exited, code=exited, status=1/FAILURE
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: Failed to start Docker Application Container Engine.
-- Subject: Unit docker.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit docker.service has failed.
--
-- The result is failed.
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: Unit docker.service entered failed state.
Jan 22 21:48:30 va10dlvpoc145 systemd[1]: docker.service failed.
Jan 22 21:48:30 va10dlvpoc145 polkitd[629]: Unregistered Authentication Agent for unix-process:3108:176305 (system bus name :1.64, object path /org/freedesktop/PolicyKi
~

[ac51178@va10dlvpoc145 bin]$ docker version
Client:
 Version:      1.13.0
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Tue Jan 17 09:55:28 2017
 OS/Arch:      linux/amd64

Describe the results you expected:
The Docker Service start start as expected.
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
(paste your output here)

Output of docker info:
Client:
 Version:      1.13.0
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Tue Jan 17 09:55:28 2017
 OS/Arch:      linux/amd64

Additional environment details (AWS, VirtualBox, physical, etc.):
Its a virtual a Virtual machine with RHEL 7.3 with below details
Linux va10dlvpoc145 3.10.0-514.2.2.el7.x86_64 #1 SMP Wed Nov 16 13:15:13 EST 2016 x86_64 x86_64 x86_64 GNU/Linux
I have to setup Docker Data Center on couple of virtual machines. I was able to finish but then my virtual machine crashed and i need to redo this. Now am stuck with the docker  engine installer.
Would appreciate quick help.

Install docker-engine-selinux-1.13.0 and restart the vm and check.

Hi ,
I tried rebooting it multiple times but still the same.
Thanks
Varun
On Mon, Jan 23, 2017 at 12:31 AM SUbbu<EMAIL_ADDRESS>wrote:

Install docker-engine-selinux-1.13.0 and restart the vm and check.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274403723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0lv5lHlnjKvG8w8BZ8NM82kCu0wjks5rVDsegaJpZM4LqnhG
.

@vchibber looking at this message;
Command "daemon" is deprecated, and will be removed in Docker 1.16. Please run `dockerd` directly.

It looks like you are running with an outdated or customised systemd unit file. Can you show the content of your docker unit-file? This should probably work;
sudo systemctl cat docker.service

The message no sockets found via socket activation: make sure the service was started by systemd may be the reason it's not starting; see the "important" message at the top of the docker 1.12 release notes; https://github.com/docker/docker/releases/tag/v1.12.6

Thanks for the quick response. Let me check and get back to you.
On Mon, Jan 23, 2017 at 7:25 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

The message no sockets found via socket activation: make sure the service
was started by systemd may be the reason it's not starting; see the "
important" message at the top of the docker 1.12 release notes;
https://github.com/docker/docker/releases/tag/v1.12.6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274475505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0g6YYqq0c2-IXDpZshIdYdggsPAiks5rVJwugaJpZM4LqnhG
.

I amusing docker version1.13.0.
But the below details are for 1.12.6.
Thanks
Varun
On Mon, Jan 23, 2017 at 7:25 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

The message no sockets found via socket activation: make sure the service
was started by systemd may be the reason it's not starting; see the "
important" message at the top of the docker 1.12 release notes;
https://github.com/docker/docker/releases/tag/v1.12.6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274475505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0g6YYqq0c2-IXDpZshIdYdggsPAiks5rVJwugaJpZM4LqnhG
.

Correct, the change was made in docker 1.12, so mentioned in the changelog for 1.12. If you upgraded from (e.g.) 1.10, or 1.11 to 1.13 the same applies obviously

I followed that link and I don't see any issue.there Is no
Requires=docker.socket in the current file I have. In fact I compared the
1.12.0 and 1.13.0. I have the 1.13.0 on my system which has
firewalls.service after network.target.
I didn't have docker installed on this VM. I just did a yum update and
pulled the latest version I.e 1.13.0. And it's been giving this issue. I
tried removing docker engine and installing it back.
I have another VM which had previous version I.e 1.12.6 and that was
working fine. I upgraded the docker on that VM to 1.13.0 and that one is
still working. I mean even after upgrade.
On Mon, Jan 23, 2017 at 9:33 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

Correct, the change was made in docker 1.12, so mentioned in the changelog
for 1.12. If you upgraded from (e.g.) 1.10, or 1.11 to 1.13 the same
applies obviously
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274502639,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0qr-t15V-rMiEIHfBmJvuuwJit7xks5rVLowgaJpZM4LqnhG
.

What does your ExecStart look like? The Command "daemon" is deprecated message should come from somewhere, if it's not in your unit file
Do you have a drop-in file installed that overrides the ExecCommand?

You are right. I didn't see the drop-in files. Let me check that
On Mon, Jan 23, 2017 at 9:56 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

What does your ExecStart look like? The Command "daemon" is deprecated
message should come from somewhere, if it's not in your unit file
https://github.com/docker/docker/blob/v1.13.0/contrib/init/systemd/docker.service.rpm#L11
Do you have a drop-in file installed that overrides the ExecCommand?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274508700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0r72yzP9V3ymkCVYoDfZ49hqpU8aks5rVL-JgaJpZM4LqnhG
.

There was a drop-in file after removing which I was able to start it
successfully.
Thanks a lot for your prompt respons and support.
Thanks
Varun
On Mon, Jan 23, 2017 at 10:00 AM Varun Chhibber<EMAIL_ADDRESS>wrote:

You are right. I didn't see the drop-in files. Let me check that
On Mon, Jan 23, 2017 at 9:56 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:
What does your ExecStart look like? The Command "daemon" is deprecated
message should come from somewhere, if it's not in your unit file
https://github.com/docker/docker/blob/v1.13.0/contrib/init/systemd/docker.service.rpm#L11
Do you have a drop-in file installed that overrides the ExecCommand?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/30354#issuecomment-274508700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALKO0r72yzP9V3ymkCVYoDfZ49hqpU8aks5rVL-JgaJpZM4LqnhG
.

 Happy to hear it's resolved 👍 let me close this issue, but feel free to comment after that


[BUG] - @testdeck/jest index.d.ts not generated, package.json points to wrong location

Testdeck Version
0.3.0
Testdeck Package

[x] @testdeck/jest

NodeJS Version

[x] 14+

Actual Behaviour
There is no index.d.ts in dist.
package.json points to root index.d.ts which exists but is the wrong file.
Expected Behaviour

index.d.ts is located under dist.
package.json points to correct location.
remove handcrafted index.d.ts.

closing for now as it is not relevant


Documentation with simple overview of the wrangling process

Make a flowchart or/and documentation page, with a very simple overview of the wrangling process.
Target readers would be new wranglers as well as contributors.

not urgent


[Enhancement] (nereids)implement showCharsetCommand in nereids

showCharset command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following showCharset command in nereids:
unsupportedshowCharsetStatement
SHOW ((CHAR SET) | CHARSET) wildWhere?

@starocean999 @LiBinfeng-01 pls assign this to me


[Feature Request] Click thumbnail to switch to tab

I have this problem that an image board I browse frequently has issues with image delivery, thus, some images always fail when I do a pick across tabs.
As there is no way currently to switch to the tab the image is located, I have to work a lot to locate and refresh that specific tab.
So if this switch to image tab function can be added to the thumbnail of the image in the browser view, it will make my work very easy.

This is technically possible. But I think we need a better UX. Switch tabs when clicking on the image is kind of confusing. It also conflicts with the current behavior - toggle the selection.
There is an "Isolate tabs" option, which will group images in the same tab. I think we can add a switch tab button to the title of the group.
When "Isolate tabs" is not checked, we can probably add a context menu command?
The command could be "Show the source element". When clicked, switch the tab and scroll the page to the image.

BTW we should hide those "Pick images..." context menu commands in the picker since it makes no sense.

BTW have you tried the retry-on-failure feature?
https://github.com/eight04/image-picka?tab=readme-ov-file#retry-on-failure

Ok I'll try the retry rules feature. As for the feature request, yes, context menu option is fine.

BTW have you tried the retry-on-failure feature? https://github.com/eight04/image-picka?tab=readme-ov-file#retry-on-failure

Naah it won't work for that site as they have a distributed image distribution system, there are thousands of peers and the domains are dynamic unless of course the rule can accommodate wildcard for everything.

@eight04 It doesn't work for the case I wanted it for, failed images, No option is presented in the context money for such,

Hmm we don't display thumbnails for failure images.
I think we just have to give thumbnails a minimal width/height and set the default src to about:blank.


⚠ SceneTime has degraded performance

In 27dcd25, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 25272 ms

Resolved: SceneTime performance has improved in 0dbae0b.


Accessible Deadzones

Closes #398
The issue above describes the changes made and why really well.
To-Do:

[x] Fix tests
[x] Finish updating docs
[x] Turn back on missing_docs
[x] Update RELEASES.md

@rodolphito, if you do not mind/have to the time, a review from you would be helpful to ensure that this pr is consistent with your issue. :)


Implement AIP18

https://github.com/ArkEcosystem/AIPs/blob/master/AIPS/aip-18.md
See https://github.com/ArkEcosystem/core/tree/master/packages/crypto/src for reference once Core 2.6 is released.

I would like to see if I can tackle this.

I don't think I am going to be able to finish this.  I got started and hit a wall, and do not have the time to put into it.
If anyone wants to see how far i got and where I left off, here is my branch:
https://github.com/ciband/cpp-crypto/tree/feat/aip18

All good, thank you for giving it a shot, @ciband

Update: This is working using the newer-ish libtorsion for all platforms, just needs some final testing before I open a PR.

Update 2:
Using libtorsion for crypto operations (keys, hashing, b58, ecdsa/schnorr-sign/verify).

platform
progress
comments

Linux
✅
all tests passing

macOS
✅
all tests passing

Windows
✅
all tests passing

[PIO] ESP32
~75%
crashes, needs debugging

[Arduino] ESP32
~25%
builds, untested, needs additional packaging considerations

Yeah, so libtorsion uses a massive amount of static allocation which does not play nice on tiny platforms.
Desktop builds worked just fine.
I previously made some progress using the secp256k1 lib; however, some additional code was required as ARK’s schnorr is a legacy version incompatible with the one currently used by secp256k1.
This is in addition to the concerns regarding IoT platforms (secp256k1 would need custom packaging and configuration to support embedded platforms).


Cancel via Home Assistant not working for awning device

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
The same issue as mentioned in #283 and #263 is also present for an awning. I have an awning with a screen attached. This are two devices in Tahoma and Home Assistant. The attached screen is functioning correctly when I cancel it via Home Assistant. The awning is nog canceling correctly and behaving the same as mentioned by thijsdejong in #283.
Screenshot from Home Automation:

So to keep things clear; the "Volant" (UpDownExteriorScreen) is working fine with the stop/cancel function, the "Zonnescherm" (UpDownHorizontalAwning) does not cancel/stop when it's opening or closing (same issue as thijsdejong mentioned in #283).
Is it possible to create the same fix for the awning device as well? Thanks it advance!
What version of this integration (ha-tahoma) has the issue?
2.10.2
What version of Home Assistant Core has the issue?
2021.12.7
Which gateway / hub do you use?
Somfy TaHoma
Device model
UpDownExteriorScreen, UpDownHorizontalAwning
Home Assistant log
No response
Additional information
No response

Thanks for reporting!

Is it possible to create the same fix for the awning device as well? Thanks it advance!

Unfortunately not, since this is a different issue. Does the stop button work when the action is executed via Home Assistant? And how does it behave when you start the action outside HA?

I've tested it to be sure, but the stop button also does not work when the action is executed from within Home Assistant.
When I trigger it via the Tahoma app or webpage I can trigger the awning and stop it immediately also.
I hope this is information you can use.


Can't connect to URL after app installation starts

Hi,
As the title suggests, I get a 'cannot connect to sitexxx' alert after the installation of my app commences. The mobileprovisioning profile, plist and .IPA files are all in the Deployment Path as specified on the BetaBuilder App. I downloaded the  betaBuilder app from hanchorllc website.
Using an iPhone 3GS with iOS 5.0.1
Questions:

is iOS 5 actually supported

Does BetaBuilder access a different port in addition to the regular web server port# ?? It has obviously connected to the deployment server because I can see the app with the correct name.

Thanks for any pointers
Steve

Hello,

Yes, iOS 5 is definitely supported.

No extra port or other Web server craziness, no. If you look at the generated files, you'll see the various paths that the system uses for deployment. Have all of the files been uploaded to the Web server? Can you access them from a browser? This sounds like either the path included was specified incorrectly or one/some of the files didn't get uploaded.

Once the files are on the Web server, the operating system is responsible for everything else. The OS needs to be able to download the IPA as well as the manifest.

Hi again Hunter
I switched to your Appstore release (v1.6.5 vs v1.0.2) and I now get "Cannot connect to (null)" after tapping to install on the iPhone.
Steve
[I'll copy this to the gitHub issue]
On 2012-01-18, at 12:13 PM, HunterHillegas wrote:

Hello,

Yes, iOS 5 is definitely supported.

No extra port or other Web server craziness, no. If you look at the generated files, you'll see the various paths that the system uses for deployment. Have all of the files been uploaded to the Web server? Can you access them from a browser? This sounds like either the path included was specified incorrectly or one/some of the files didn't get uploaded.

Once the files are on the Web server, the operating system is responsible for everything else. The OS needs to be able to download the IPA as well as the manifest.

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3552340

Hi Hunter
It's working fine now. Yes, you were correct it was probably due to the deployment URL specification. The only thing I changed was the deployment directory to one which was not at the at my webservers document root. I'm wondering if the fact there were other files in the top level document root apart from the ones required to do the install which were somehow messing things up?Oh well .. moot point now, plus it's much tidier keeping things separated like this.
http://www.puddockplace.ca/betaApps
One other thing I did notice - when I clicked on "Generate Deployment files" at the Mac end, it would remove the .ipa file even though I had specified that exact location for the 'Choose IPA' input field, then say it could find the .ipa file it just deleted! I got round this for the moment by sticking the .ipa file in the read-only "/" folder - I'll see if I can figure out why it did this. I'm doing this development on an MBPro running OSX Lion. I also removed the trailing slash at the end of the deployment URL ... dunno if this is an issue. :)
Anyway thanks again for your assistance - this is an excellent tool and a HUGE timesaver for my testers!
Thanks again
Steve
On 2012-01-18, at 4:41 PM, HunterHillegas wrote:

There shouldn't be any problem with your bundle string as you've indicated below.
I'm still betting the URL is incorrect. Feel free to share it so that I can examine it. If that's not possible, I'd suggest double-checking that they are all accessible from the mobile device and that the paths are indeed correct.
On Jan 18, 2012, at 4:38 PM, Steve Howie wrote:

Yes all the files appear to have been uploaded correctly and the paths and filenames in the generated manifest file are correct.
Just to verify the files to be uploaded to the deployment URL: 1. manifest.plist 2. app.ipa 3. index.html 4. Readme.txt 5. Beta_archive.zip (not needed in my case)
Can the "bundle version" have embedded blanks?? In my case it's "1.0 (1.0)"
Steve

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3555988

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3556020

Great, glad to hear it!
re: the below - yeah, I believe this is an issue that I'm planning to fix for the next update.
On Jan 18, 2012, at 5:49 PM, Steve Howie wrote:

One other thing I did notice - when I clicked on "Generate Deployment files" at the Mac end, it would remove the .ipa file even though I had specified that exact location for the 'Choose IPA' input field, then say it could find the .ipa file it just deleted! I got round this for the moment by sticking the .ipa file in the read-only "/" folder - I'll see if I can figure out why it did this. I'm doing this development on an MBPro running OSX Lion. I also removed the trailing slash at the end of the deployment URL ... dunno if this is an issue. :)
Anyway thanks again for your assistance - this is an excellent tool and a HUGE timesaver for my testers!

Awesome!
p.s. You're not related to that other Hillegass guy by any chance (Aaron)? :)
Steve
On 2012-01-18, at 5:50 PM, HunterHillegas wrote:

Great, glad to hear it!
re: the below - yeah, I believe this is an issue that I'm planning to fix for the next update.
On Jan 18, 2012, at 5:49 PM, Steve Howie wrote:

One other thing I did notice - when I clicked on "Generate Deployment files" at the Mac end, it would remove the .ipa file even though I had specified that exact location for the 'Choose IPA' input field, then say it could find the .ipa file it just deleted! I got round this for the moment by sticking the .ipa file in the read-only "/" folder - I'll see if I can figure out why it did this. I'm doing this development on an MBPro running OSX Lion. I also removed the trailing slash at the end of the deployment URL ... dunno if this is an issue. :)
Anyway thanks again for your assistance - this is an excellent tool and a HUGE timesaver for my testers!

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3556685

As far as we know, it's very distance relation… but not directly. He's a great guy though!
On Jan 18, 2012, at 5:52 PM, Steve Howie wrote:

Awesome!
p.s. You're not related to that other Hillegass guy by any chance (Aaron)? :)
Steve
On 2012-01-18, at 5:50 PM, HunterHillegas wrote:

Great, glad to hear it!
re: the below - yeah, I believe this is an issue that I'm planning to fix for the next update.
On Jan 18, 2012, at 5:49 PM, Steve Howie wrote:

One other thing I did notice - when I clicked on "Generate Deployment files" at the Mac end, it would remove the .ipa file even though I had specified that exact location for the 'Choose IPA' input field, then say it could find the .ipa file it just deleted! I got round this for the moment by sticking the .ipa file in the read-only "/" folder - I'll see if I can figure out why it did this. I'm doing this development on an MBPro running OSX Lion. I also removed the trailing slash at the end of the deployment URL ... dunno if this is an issue. :)
Anyway thanks again for your assistance - this is an excellent tool and a HUGE timesaver for my testers!

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3556685

Reply to this email directly or view it on GitHub:
https://github.com/HunterHillegas/iOS-BetaBuilder/issues/6#issuecomment-3556713


Use the Login field as the user name, not Username

Summary
Apparently the Username in github is optional and different from the
Login field. We should use the login field to prevent authentication
issues e.g. when opening pull requests.
Fixes: https://github.com/stacklok/epics/issues/252
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
local testing with the stackloktest account
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 46.577% (-0.03%) from 46.609%
when pulling 4d8f40a40079c0f969ad44dabd28aa4ab2175d5e on jhrozek:login_for_pr
into e0569e6716a3aa3894dd984bb53caa6c1797e125 on stacklok:main.


Fix before_action :verify_bolt_request for SolidusBolt::WebhooksController

the computed_hmac doesn't match the header_hmac and we are unsure why. Need to check with Bolt and ask for guidance

Now that the problem is clear, we can address it into https://github.com/nebulab/solidus_bolt/pull/37

Fixed in commit 12df15f5b4e4e609ba30463aa8284955cde9009f


Fix postgres plan UUID

What
paas-billing relies on the unique name of service plans being a UUID
Billing breaks if the following happens:

we have a plan with a unique name that is not a valid UUID
someone uses that plan

This happened recently for the app-autoscaler, but is also a historical issue
This PR

fixes a typo in the unique name of medium-10-high-iops
add acceptance test which tests that all of the plans have UUID unique IDs

How to review
Code review
Deploy to your dev env
Observe that post-deploy fails during register-rds-broker task, with an unknown error
Run the following:
cd paas-bootstrap
make dev bosh-cli
bosh ssh api/0
cd /var/vcap/jobs/cloud_controller_ng
./bin/console
ServicePlan.find(name: 'medium-10-high-iops').delete

Restart post-deploy, it should go green
Who can review
Not @tlwr

I should point out, no one is using the medium-10-high-iops which is why it is okay to delete it, and also why we haven't observed billing throwing errors


UX for logging levels and offsets

Displays error/warning icons to trace message rows and displays the logging message offsets.
The icons are provided by FontAwsome, by way of the React library react-fa.

Sorry for the confusion guys, the unit "ms" should be at the value level!! I must have missed it in the mock!!

lgtm

Like so!

and the reason why I chose to show "ms" at the value level is because 1.) Phil was right on the spot about improve readability and understanding 2.) numbers within the column will generally be shorter than its title. If we add "ms" next to the title of the column, we would run into a lot of empty space within the column itself.
But yes! please put back in the unit. It's very important!

@avanderhoorn : if you look at the mock for Web services tab, you will see that "ms" is shown inside the column without a space--- (ex. 123ms). To keep it consistent with the logging page, please update for it to show with a space--- (ex. 123 ms). Thank you!

About font, font awesome is great and I think we can definitely leverage the use of that. However, @avanderhoorn is right that we are still going to need our own set of icon as well because font awesome will not have all the assets we need to show in the UI.

Abandoning this PR in favor of a more recent attempt.


LW_ERROR_PASSWORD_MISMATCH

Version: <IP_ADDRESS>4
OS/Distro: Ubuntu desktop 16.04 - unity desktop
Issue/Impact: Can't join domain
PBIS has been working fine since I finally got it working around 6 weeks ago. About a week ago I used clonezilla to clone this machine on which I run pbis, I refer to it as 'myserver' though it is running Ubuntu desktop. After cloning onto another computer, I successfully ran the cli-join command on that clone (though there was an issue on the clone yet to be solved, but that isn't the problem I'm reporting here).
When I replaced the clone with my regular computer (myserver), re-ran the cli-join command, much to my surprise I got the 'password_mismatch' error detailed below. I've spent several hours exploring this problem eg reading all issue reports here, eg #74 which has a similar error message but different symptoms, #27 which seems more similar though not quite, also tried all of the investigative/solving ideas given to no avail, and #22 leading me to try both removing samba and adding the lines listed in that issue report to the global section. I've also looked at several other pages I've googled with similar error messages, all to no avail.
Any ideas?
Thanks,
David
PS My best guess at the moment comes from this line in the syslog (also given below) which says it's using my computer username, not my AD username:

Nov  3 08:02:11 myserver lsass: [LwKrb5GetTgtImpl /builder/src-git/Platform/src/linux/lwadvapi/threaded/krbtgt.c:346] KRB5 Error code: -1765328360 (Message: Preauthentication failed)
Nov  3 08:02:11 myserver lsass: [lsass] The cached machine account password was rejected by the DC.
Nov  3 08:02:11 myserver lsass: [lsass] Failed to validate user for login (name = 'GIVEN IS MY SERVER USERNAME, NOT MY AD USERNAME') -> error = 40022, symbol = LW_ERROR_PASSWORD_MISMATCH, client pid = 5851

● lwsmd.service - BeyondTrust PBIS Service Manager

Loaded: loaded (/lib/systemd/system/lwsmd.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 2017-11-02 16:14:59 CDT; 7h ago
Process: 962 ExecStart=/opt/pbis/sbin/lwsmd --start-as-daemon (code=exited, status=0/SUCCESS)
Main PID: 971 (lwsmd)
CGroup: /system.slice/lwsmd.service
├─ 971 /opt/pbis/sbin/lwsmd --start-as-daemon
├─ 993 lw-container lwreg
├─1020 lw-container eventlog
├─1099 lw-container netlogon
├─1125 lw-container lwio
├─1151 lw-container lsass
└─1181 lw-container reapsysl

(repeated several times:) Nov 02 23:00:59 myserver lsass[1151]: [LwKrb5GetTgtImpl /builder/src-git/Platform/src/linux/lwadvapi/threaded/krbtgt.c:346] KRB5 Error code: -1765328360 (Message: Preauthentication failed)
Nov 02 23:00:59 myserver lsass[1151]: [lsass] The cached machine account password was rejected by the DC.

/opt/pbis/bin/lwsm list

lwreg          running (container: 993)
dcerpc         stopped
eventlog       running (container: 1020)
lsass          running (container: 1151)
lwio           running (container: 1125)
netlogon       running (container: 1099)
rdr            running (io: 1125)
reapsysl       running (container: 1181)
usermonitor    stopped

/opt/pbis/bin/domainjoin-cli query

Error: LW_ERROR_ACCESS_DENIED [code 0x00009cde]
Incorrect access attempt

pbis status

I subbed in (my domain) etc for site-specific info

/opt/pbis/bin/enum-users
[if I used "sudo..." on these commands, then command returned nothing and back to prompt]

Failed to enumerate users.  Error code 40022 (LW_ERROR_PASSWORD_MISMATCH).
The password is incorrect for the given account

attach logs

/opt/pbis/bin/lwsm set-log-target -p lsass -  file /tmp/lsass.log

Error: LW_ERROR_ACCESS_DENIED (40158)
Incorrect access attempt

/opt/pbis/bin/lwsm set-log-level -p lsass - debug

Error: LW_ERROR_ACCESS_DENIED (40158)
Incorrect access attempt

attach log
In syslog I get this repeated many dozens of times each our:

Nov  3 08:02:11 myserver lsass: [LwKrb5GetTgtImpl /builder/src-git/Platform/src/linux/lwadvapi/threaded/krbtgt.c:346] KRB5 Error code: -1765328360 (Message: Preauthentication failed)
Nov  3 08:02:11 myserver lsass: [lsass] The cached machine account password was rejected by the DC.
Nov  3 08:02:11 myserver lsass: [lsass] Failed to validate user for login (name = 'NOTE:THIS IS MY SERVER USERNAME, NOT MY AD USERNAME') -> error = 40022, symbol = LW_ERROR_PASSWORD_MISMATCH, client pid = 5851

Output/Error:
Shown above
Steps to Reproduce:

Domainjoin command

sudo /opt/pbis/bin/domainjoin-cli join MYDOMAIN ADusername
Error: LW_ERROR_PASSWORD_MISMATCH [code 0x00009c56]

The password is incorrect for the given account

[and just saw that you fixed the domainjoin-gui and ran that. The popup says that status was "Joined" (but still can't authenticate at clients) and when I pressed the 'Leave Domain' button I got: ERROR_ACCESS_DENIED message.]

It's saying the "The cached machine account password was rejected by the DC." which looks like the PBIS agent does not have the correct password for the computer account in AD.
Cloning the system may well have resulted in 2 agents using the same computer account in AD. The computer account password is changed during a join and periodically after that. Please ensure each machine is using a different computer account in AD (domainjoin-cli query), and then try leaving and re-joining to reset the password.

Thanks for quick reply! I'm a teacher and today don't have students so have most all of the day to try to solve this issue.
To do as you suggested, I re-connected up my cloned computer, changed the hostname back to the original computers name (the one from which I had cloned it), rebooted and successfully issued the join and then the leave commands. Then I shut that clone down then booted the computer (which provided the image for the clone--the computer I'm trying to get working again). Was that your suggestion?
Unfortunately, upon issuing the join-cli command, I still get the error:

Error: LW_ERROR_PASSWORD_MISMATCH [code 0x00009c56]
The password is incorrect for the given account

I wonder if there is a different cache I need to clear?

Did you say the domainjoin-cli leave gives an error too?

On the cloned machine (not the one I'm currently troubleshooting) I successfully joined and left the domain.
On the master computer (the one that provided the image, the one I'm trying to get to work again) I get the same error message trying to join or leave.

Odd the leave shouldn't need to communicate with AD unless you pass a username. Could you try running:
domainjoin-cli leave --keepLicense

Get same results w/that command.
Now might be a good time to bring up how I ended up solving #60 as shown on this comment: https://github.com/BeyondTrust/pbis-open/issues/60#issuecomment-331686391
I checked the lsassd.reg file and strangely the line which I had edited had returned to its default setting of:

"ActiveDirectoryPasswordPrompt" = {
default = ""

So I wonder, if that setting had gotten reset, I wonder if any other settings might have reset to default? [Thanks so much for your quick support! Just to let you know I've got a meeting and will be returning in about 2 hours so will be off-line... :-( ]

I just tried reproducing this locally. If I reset my AD computer password I get very similar results to you. However is I restart lsass my domainjoin-cli starts working correctly again. Could you try:
/opt/pbis/bin/lwsm restart lsass
domainjoin-cli leave
domain join-cli join

Wow, that fixed my problem that I mentioned on #74 where I couldn't even leave the domain as I was getting the password mismatch when trying to leave and join.  I even rebooted the laptop and still couldn't leave.  After doing the lwsm restart lsass it fixed my problem.

SUCCESS
love seeing when pbis prints that on the screen :-)
I did as you suggested and got the hoped-for results!
Thanks @RBoulton-BT for your close attention to this issue!
Am now working to get the clients to authenticate. Running into problem on #60 but solution described in https://github.com/BeyondTrust/pbis-open/issues/60#issuecomment-331686391  isn't working but am still exploring.
Again thanks for your help,
David

About authentication not working on client... Continuing to explore problem. Previous solution from #60 doesn't seem to have traction. Looking at the lsass.log from an unsuccessful client I'm wondering about a lot of the "lw" entries I see. I assume those are left over from the "likewise" days? At 1 point I know I added a legacy packet in search of domainjoin-gui and am wondering if there might be some problem with that? Wondering if I should open another issue and put this, there?
Thanks,
David

And finally, it works.
Not sure exactly why it finally does work, but it does. I applied basically the same strategy previously described in #60 however this time I had to change the default "" to "Password: " --this is different from #60 because at that point I could do any entry e.g. "passwerd" or whatever and it would work. Oh well, I'm sure there is a reason. Again, thanks for the help, my students have their computers back!

@RBoulton-BT Man you are awesome


Reddit: Exclude subreddit submission/comment links from being ripped.

I use ripme in the terminal so it'd be great if there was a flag/option to exclude multiple subreddits submission & comment  links from being scraped when ripping a user profile on reddit.

Could you provide an example profile and describe exactly the sort of thing you'd like to modify with it?
I think I know what you're talking about - some reddit users post annoyingly marketing-style on some subreddits like /r/sexsells and sometimes post highly-catered content to fetish subreddits that I'm not interested in. I could see myself excluding those subreddits from the rips.


Entropy analysis on all channels

Hello,
I'm trying to use your entropy analysis algorithm on 2-minute resting-state EEG with 64 channels. Is there a way to create a df_feat that includes in columns or rows all the channels?
This is the code I have thus far.
#P1
Load data as a eeglab file
raw = mne.io.read_raw_eeglab('E:/study/EEGLAB/restingstate/1_restingstate.set', montage=None, eog=(), preload=True, uint16_codec=None, verbose=None)
Load data
data = raw._data * 1e6
sf = raw.info['sfreq']
chan = raw.ch_names
#ch_names = chan
#times = np.arange(data.size) / sf
times = np.arange(data.shape[1]) / sf
print(data.shape, chan, times)
data = data[0, :] # 0 indicates first electrode location, change number to change electrode - to see which number is each electrode look at variable 'chan'
print(data.shape, np.round(data[0:5], 3))
Convert the EEG data to 120-sec data
times, data_win = yasa.sliding_window(data, sf, window=120)
Convert times to minutes
times /= 60
data_win.shape
from numpy import apply_along_axis as apply
df_feat = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win, normalize=True),
'svd_entropy': apply(ent.svd_entropy, 1, data_win, normalize=True),
'spec_entropy': apply(ent.spectral_entropy, 1, data_win, sf=sf, nperseg=data_win.shape[1], normalize=True),
'sample_entropy': apply(ent.sample_entropy, 1, data_win),
# Fractal dimension
'dfa': apply(ent.detrended_fluctuation, 1, data_win),
'petrosian': apply(ent.petrosian_fd, 1, data_win),
'katz': apply(ent.katz_fd, 1, data_win),
'higuchi': apply(ent.higuchi_fd, 1, data_win),
}
df_feat = pd.DataFrame(df_feat)
df_feat.head()
def lziv(x):
"""Binarize the EEG signal and calculate the Lempel-Ziv complexity.
"""
return ent.lziv_complexity(x > x.mean(), normalize=True)
df_feat['lziv'] = apply(lziv, 1, data_win)  # Slow
Any help will be greatly appreciated!

Have you labeled this as a bug? Not sure how the github system works. My understanding is that in order for df_feat to display entropy for each channel, something has to be changed in data = data[0, :] to make it include all channels but I am terrible at programming so everything I've tried doesn't work! Is including all channels in df_feat possible currently or will there need to be major changes in the YASA source code to do this?

Hi @apavlo89! Just removed the "Bug" label :-) So the issue here is not with YASA but rather with Entropy, which is designed to work only with one-dimensional array. In other words, if you want to create a df_feat dataframe with all the channels, you need to create a for loop in which you loop across all the channels
df_all = []
for i, c in enumerate(chan):
    data = data[i, :]

    # Calculate entropy for this channel
    df_chan = {'perm_entropy': apply(...), }
    df_chan['Channel'] = f

    # Append to a larger dataframe
    df_all.append(df_chan)

df_all = pd.DataFrame(df_all, ignore_index=True)

Something like that should work, let me know! Thanks

It is giving me an error: too many indices for array
import yasa
import mne
import numpy as np
import matplotlib.pyplot as plt
import seaborn as sns
import pandas as pd
import entropy as ent
sns.set(font_scale=1.2)
#P1
Load data as a eeglab file
f = mne.io.read_raw_eeglab('E:\REEG MU HIGHLOW\EEGLAB\P1_postICA.set', montage=None, eog=(), preload=True, uint16_codec=None, verbose=None)
Load data
data = f._data * 1e6
sf = f.info['sfreq']
chan = f.ch_names
times = np.arange(data.shape[1]) / sf
print(data.shape, chan, times)
data = data[0, :] # 0 indicates first electrode location, change number to change electrode - to see which number is each electrode look at variable 'chan'
print(data.shape, np.round(data[0:5], 3))
Convert the EEG data to 120-sec data
times, data_win = yasa.sliding_window(data, sf, window=120)
Convert times to minutes
times /= 60
data_win.shape
from numpy import apply_along_axis as apply
df_feat = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win, normalize=True),
'svd_entropy': apply(ent.svd_entropy, 1, data_win, normalize=True),
'spec_entropy': apply(ent.spectral_entropy, 1, data_win, sf=sf, nperseg=data_win.shape[1], normalize=True),
'sample_entropy': apply(ent.sample_entropy, 1, data_win),
# Fractal dimension
'dfa': apply(ent.detrended_fluctuation, 1, data_win),
'petrosian': apply(ent.petrosian_fd, 1, data_win),
'katz': apply(ent.katz_fd, 1, data_win),
'higuchi': apply(ent.higuchi_fd, 1, data_win),
}
df_feat = pd.DataFrame(df_feat)
df_feat.head()
def lziv(x):
"""Binarize the EEG signal and calculate the Lempel-Ziv complexity.
"""
return ent.lziv_complexity(x > x.mean(), normalize=True)
df_feat['lziv'] = apply(lziv, 1, data_win)  # Slow
df_all = []
for i, c in enumerate(chan):
data = data[i, :]
# Calculate entropy for this channel
df_chan = {'perm_entropy': apply(...), }
df_chan['Channel'] = f

# Append to a larger dataframe
df_all.append(df_chan)

df_all = pd.DataFrame(df_all, ignore_index=True)
I wasn't sure if the three dots in this line  df_chan = {'perm_entropy': apply(...), } meant to just copy paste from df_feat all the values so I also tried like this
df_all = []
for i, c in enumerate(chan):
data = data[i, :]
# Calculate entropy for this channel
df_chan = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win, normalize=True),
'svd_entropy': apply(ent.svd_entropy, 1, data_win, normalize=True),
'spec_entropy': apply(ent.spectral_entropy, 1, data_win, sf=sf, nperseg=data_win.shape[1], normalize=True),
'sample_entropy': apply(ent.sample_entropy, 1, data_win),
# Fractal dimension
'dfa': apply(ent.detrended_fluctuation, 1, data_win),
'petrosian': apply(ent.petrosian_fd, 1, data_win),
'katz': apply(ent.katz_fd, 1, data_win),
'higuchi': apply(ent.higuchi_fd, 1, data_win),

}
df_chan['Channel'] = f
# Append to a larger dataframe
df_all.append(df_chan)

df_all = pd.DataFrame(df_all, ignore_index=True)
Again I got same error :(
Also how do I get lziv complexity analysis into this loop?

You need to remove this line from your script;
data = data[0, :]
Yes the three dots meant copy-paste everything.
For LZiv just define this function at the beginning of the script:
def lziv(x):
"""Binarize the EEG signal and calculate the Lempel-Ziv complexity.
"""
return ent.lziv_complexity(x > x.mean(), normalize=True)

and then add
df_chan = {...,
'lziv': apply(lziv, 1, data_win),
}

I've done as you have explained but now I get
Error: order*delay should be lower than x.size
This is my code now
import yasa
import mne
import numpy as np
import matplotlib.pyplot as plt
import seaborn as sns
import pandas as pd
import entropy as ent
sns.set(font_scale=1.2)
#P1
Load data as a eeglab file
f = mne.io.read_raw_eeglab('E:\REEG MU HIGHLOW\EEGLAB\P1_postICA.set', montage=None, eog=(), preload=True, uint16_codec=None, verbose=None)
Load data
data = f._data * 1e6
sf = f.info['sfreq']
chan = f.ch_names
times = np.arange(data.shape[1]) / sf
print(data.shape, np.round(data[0:5], 3))
Convert the EEG data to 120-sec data
times, data_win = yasa.sliding_window(data, sf, window=120)
Convert times to minutes
times /= 60
data_win.shape
from numpy import apply_along_axis as apply
def lziv(x):
"""Binarize the EEG signal and calculate the Lempel-Ziv complexity.
"""
return ent.lziv_complexity(x > x.mean(), normalize=True)
df_all = []
for i, c in enumerate(chan):
data = data[i, :]
# Calculate entropy for this channel
df_chan = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win, normalize=True),
'svd_entropy': apply(ent.svd_entropy, 1, data_win, normalize=True),
'spec_entropy': apply(ent.spectral_entropy, 1, data_win, sf=sf, nperseg=data_win.shape[1], normalize=True),
'sample_entropy': apply(ent.sample_entropy, 1, data_win),
# Fractal dimension
'dfa': apply(ent.detrended_fluctuation, 1, data_win),
'petrosian': apply(ent.petrosian_fd, 1, data_win),
'katz': apply(ent.katz_fd, 1, data_win),
'higuchi': apply(ent.higuchi_fd, 1, data_win),
'lziv': apply(lziv, 1, data_win),
}

df_chan['Channel'] = f
# Append to a larger dataframe
df_all.append(df_chan)

df_all = pd.DataFrame(df_all, ignore_index=True)

Ok it's hard for me to debug without having the data and code but the issue is that data_win is now a three-dimension array, so you first need to create something like:
data_win_ep = data_win[i, :, :]

and then use this data_win_ep in the df_chan = {...} code, possibily changing the axis argument of the numpy.apply_along_axis.
df_chan = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win_ep, normalize=True),
}

As this is not directly related to YASA or Entropy I will close this issue now. I recommend that you read on Numpy axis and shape.
Thanks

Merci beaucoup, you are a rockstar! It worked perfectly! Thank you for your time. The only thing I had to change from your code was to remove ignore_index=True as it was giving me an error: unexpected keyword argument 'ignore index'. Not sure what it does but removing seemed to have fixed all errors.
For anyone wanting to analyze more than 1 channel in one go for their analysis this is an example of code they could use
import yasa
import mne
import numpy as np
import matplotlib.pyplot as plt
import seaborn as sns
import pandas as pd
import entropy as ent
sns.set(font_scale=1.2)
#Participant 1
Load data as a eeglab file
f = mne.io.read_raw_eeglab('E:\study\P1_nonlinear.set', montage=None, eog=(), preload=True, uint16_codec=None, verbose=None)
Load data
data = f._data * 1e6
sf = f.info['sfreq']
chan = f.ch_names
times = np.arange(data.shape[1]) / sf
print(data.shape, np.round(data[0:5], 3))
Convert the EEG data to 120-sec data
times, data_win = yasa.sliding_window(data, sf, window=120)
Convert times to minutes
times /= 60
from numpy import apply_along_axis as apply
def lziv(x):
"""Binarize the EEG signal and calculate the Lempel-Ziv complexity.
"""
return ent.lziv_complexity(x > x.mean(), normalize=True)
df_all = []
for i, c in enumerate(chan):
data_win_ep = data_win[i, :, :]
# Calculate entropy for this channel
df_chan = {
# Entropy
'perm_entropy': apply(ent.perm_entropy, axis=1, arr=data_win_ep, normalize=True),
'svd_entropy': apply(ent.svd_entropy, 1, data_win_ep, normalize=True),
'spec_entropy': apply(ent.spectral_entropy, 1, data_win_ep, sf=sf, nperseg=data_win_ep.shape[1], normalize=True),
'sample_entropy': apply(ent.sample_entropy, 1, data_win_ep),
# Fractal dimension
'dfa': apply(ent.detrended_fluctuation, 1, data_win_ep),
'petrosian': apply(ent.petrosian_fd, 1, data_win_ep),
'katz': apply(ent.katz_fd, 1, data_win_ep),
'higuchi': apply(ent.higuchi_fd, 1, data_win_ep),
'lziv': apply(lziv, 1, data_win_ep),
}
df_chan['Channel'] = f
# Append to a larger dataframe
df_all.append(df_chan)
df_all = pd.DataFrame(df_all)
df_all.to_csv(r'E:\study\1_nonlinear.csv')


avoid unnecessary HTML string building+parsing

Rather than building a string of HTML and then parsing it, which is overkill and comparatively slow, this simply creates a new blank <div> and then adds the requisite classes via jQuery.
This could be further tweaked to use className instead of jQuery's addClass at the cost of a bit more verbosity; I opted to be conservative.

CC: @hnrch02 @XhmikosR

I couldn't find any references that this is faster. Do you have any numbers? Also, are these the only cases?
The idea seems fine to me, just wondering.

Do you have any numbers?

Yes: http://jsperf.com/dom-constr-42

(Firefox won't upload due to bad CSRF token problem for some reason.)

Also, are these the only cases?

Yes, except for the unit tests.

Wow, huge difference! Definitely :shipit: .
How did you spot this?

I was reminded about it when nitpicking an instance of it in some new unit tests in a PR the other day.


Store pagination settings in local storage

Depends on PR #104

Codecov Report
Base: 37.67% // Head: 38.61% // Increases project coverage by +0.93% :tada:

Coverage data is based on head (75bdf90) compared to base (4d82fb3).
Patch coverage: 66.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   37.67%   38.61%   +0.93%
==========================================
  Files          72       76       +4
  Lines        2426     2525      +99
  Branches      649      674      +25
==========================================
+ Hits          914      975      +61
- Misses       1400     1438      +38
  Partials      112      112

Impacted Files
Coverage Δ

pkg/web/src/app/client/helpers.ts
28.86% <0.00%> (-0.31%)
:arrow_down:

pkg/web/src/app/queries/mocks/providers.mock.ts
100.00% <ø> (ø)

src/components/StandardPage/userSettings.ts
18.75% <18.75%> (ø)

src/hooks/useSearchParams.tsx
36.36% <36.36%> (ø)

src/utils/localStorage.ts
50.00% <50.00%> (ø)

src/components/StandardPage/useFields.tsx
97.29% <96.66%> (-2.71%)
:arrow_down:

src/components/StandardPage/StandardPage.tsx
76.00% <100.00%> (-2.95%)
:arrow_down:

src/components/StandardPage/index.ts
100.00% <100.00%> (ø)

src/components/StandardPage/usePagination.tsx
100.00% <100.00%> (ø)

src/components/TableView/TableView.tsx
95.65% <100.00%> (+0.41%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add datasource management UI

Overview
This PR is a first pass at creating a user-interface for the management of datasources. This ballooned a bit so I am drawing the line here. A lot of this will need design work, so I don't want to devote any more time to this before that happens. This PR handles:

creating a path for a user to get to their datasources
listing a user's datasources (see next list)
UI editing default color-corrections for a datasource
UI for creating, updating, and deleting false-color composite presets

Things this PR does leave some things that need to be addressed:

connecting the front-end to the API (the datasource service)
the API support for filtering datasources by user
UI to create a new datasource (will probably be like the new project create workflow)
UI polish and validation (sliders for default color correction? intelligent band mapping ui, etc)

Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Notes
There is no imported scene listing. You'll see a button for that but it doesn't go anywhere.
Various buttons intentionally don't do anything yet: 'Start an Import', 'Create a new Datasource', 'Create and new False Color Composite', 'Save', etc.
The editing of the JSON fields is built on top of a buffering concept. We create a buffer (copy of the JSON object) and make the changes to the buffer. If the user want to persist the changes, we replace the entities JSON field with the buffer. If editing is cancelled, we re-init the buffer to match the object's JSON.
Demo

Testing Instructions

Click around the new imports page
Ensure you can see the list of datasources
Ensure pagination works for datasources (you can adjust the pageSize param on the list.controller.js file to be less than the number of datasources you have
Ensure you can get to the pages to edit any datasource
Check that you can get to the color correction edit and color composite edit
Changes to color correction of color composites should be able to be cancelled; make changes to these and hit cancel, navigate away, or anything else you can think of and verify that the changes are reset.

Connects #1164

I think I can get the datasource service hooked up so we have some actual data persistence. Will see if I can fit that in today.


is remote config has any parameter or key?

@TheAlphamerc can i have screen shot of your remote config at firebase?

@dextermax3  There is no use of remote config in this project.


Scrolling from mouse, not working in web mode, only on desktop

I tested your example mode, and it doesn’t work either

Sorry, please turn off text selection by enableTextSelection: false. It affects the scrolling.

Woops, there seems another issue with Web.
0.4.9 fixes the issue anyway.


Hookshot bot doesn't receive room invitation

I run my own Synapse homeserver. I registered the app service. I can see the user was created in PostgreSQL:
matrix-synapse=> SELECT name FROM users;
                  name
----------------------------------------
 @puffnfresh:chat.home.brianmckenna.org
 @hookshot:chat.home.brianmckenna.org
(2 rows)

Here's part of my registration file:
sender_localpart: hookshot
namespaces:
  users:
    - regex: "@hookshot.*:chat.home.brianmckenna.org"
      exclusive: true
  rooms: []

I invited @hookshot:chat.home.brianmckenna.org to my public room:
{
  "type": "m.room.member",
  "sender": "@puffnfresh:chat.home.brianmckenna.org",
  "content": {
    "membership": "invite",
    "displayname": "hookshot"
  },
  "state_key": "@hookshot:chat.home.brianmckenna.org",
  "origin_server_ts":<PHONE_NUMBER>869,
  "unsigned": {
    "age": 106
  },
  "event_id": "$Bw65kVN7yJY8YS71WVVwIKSeYVZQJweovy5FtB-9aWQ",
  "room_id": "!XXX:chat.home.brianmckenna.org"
}

I see nothing in the Hookshot logs but I expect to see:
Got invite roomId=${roomId} from=${event.sender} to=${event.state_key}

Restarting the service just gives:
INFO 07:10:50:380 [Bridge] Connecting to homeserver and fetching joined rooms..
DEBUG 07:10:50:382 [MatrixHttpClient (REQ-1)] GET http://localhost:8008/_matrix/client/r0/joined_rooms
INFO 07:10:50:421 [Bridge] Found 0 rooms

Which makes some sense since the bot hasn't fully joined the room yet. Why would Hookshot not receive the invitation event?

I had the wrong URL in my registration file. Accidentally put my homeserver:
url: "http://localhost:8008"

Instead of the appservice!
url: "http://localhost:9993"

:facepalm:


How can I integrate it with cloudwatch_metric_alarm?

How can I integrated it with
https://www.terraform.io/docs/providers/aws/r/cloudwatch_metric_alarm.html
?
Let's say I'd like to notify slack about idling machines?

There is an example for this - https://github.com/terraform-aws-modules/terraform-aws-notify-slack/tree/master/examples/cloudwatch-alerts-to-slack

Thanks, how come I overlooked it? Nvm.
Could we write here where encryption should be?
Now it's written where, so for someone less experienced it's enigmatic. :)

You are right, the comment in the code is not perfect. URL can be there and it is fine that it is visible as it is in most cases. That URL will be persisted in stdout and tfstate file anyway.

Thanks for help, I'm closing it.


Longhorn hardening

At this point Longhorn driver is backed up by Claudie node OS disks - this creates issues when for example: upgrading OS version can result in data loss.
The desired state would be to decouple the OS disk and Storage Disk.
This link can be helpful when designing the change: https://longhorn.io/docs/1.4.0/best-practices/#configuring-default-disks-before-and-after-installation
Tasks:

[ ] get rid of the field that controls the OS disk size, and use a hardcoded sensible default size
[ ] replace that field by the "storage-disk" disk size, which is used exclusively for longhorn
[ ] reconfigure longhorn to always use the "storage disk" only

I think we should check what are the constraints on the cloud provider's site. For example, Hetzner minimum disk size is 10GB : ref

I would choose to define a global minimum value, and probably specify it to be the minimum of all supported providers.
I think 10GB is OK.
I would go with this as the simplest solution, despite it not necessarily being the best.


Update GeoGrid base class access modifier to support extensibility

Description

Change access modifier from default to protected. This will help to build new geo based aggregation outside OpenSearch, by keeping GeoGrid Classes as base class.

Updated GeoTileGrid and GeoHashGrid classes accordingly.

Updated doc to reflect base class as api

Renamed API class to reflect that it is not internal anymore

Signed-off-by: Vijayan Balasubramanian<EMAIL_ADDRESS>Issues Resolved
Check List

[x] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB all this classes are desribed as internal, we need to update that to reflect that API is public now
* ...
* @opensearch.internal
* ...

See please the relevant discussion here: https://github.com/opensearch-project/OpenSearch/pull/3716#discussion_r908594187

@VijayanB all these classes are desribed as internal, we need to update that to reflect that API is public now
* ...
* @opensearch.internal
* ...

See please the relevant discussion here: #3716 (comment), CC @nknize
Thanks @reta . I updated the abstract class and interface that will be extended/inherited by plugins outside this repository. Is there anything else pending other than updating doc to convey that these classes are public?

We have changed the modifier for both HashGrid and TileGrid classes. As this of GeoH3 I am not sure we need to make this amount of changes.

Do we have these changes available in another PR? if not, i believe these changes are required if we want to add new aggregation outside this repository.

We have changed the modifier for both HashGrid and TileGrid classes. As this of GeoH3 I am not sure we need to make this amount of changes.

@navneet1v Do we have these changes available in another PR? if not, i believe these changes are required if we want to add new aggregation outside this repository.

What I was saying is in this PR we are making changes in both HashGrid and TileGrid so do we need both?

We have changed the modifier for both HashGrid and TileGrid classes. As this of GeoH3 I am not sure we need to make this amount of changes.

@navneet1v Do we have these changes available in another PR? if not, i believe these changes are required if we want to add new aggregation outside this repository.

What I was saying is in this PR we are making changes in both HashGrid and TileGrid so do we need both?

Yes. We are changing access modifier in their base class.

Oh my bad. The changes in base class are tricking up to the top level classes.

@dblock @nknize Can i get review for this? Thanks. This will be blocker to develop https://github.com/opensearch-project/geospatial/issues/98 . Thanks.

Codecov Report

Merging #4572 (5a15f1f) into main (e354461) will decrease coverage by 0.14%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##               main    #4572      +/-   ##
============================================
- Coverage     70.72%   70.57%   -0.15%
+ Complexity    57667    57512     -155
============================================
  Files          4655     4655
  Lines        277008   277008
  Branches      40529    40529
============================================
- Hits         195919   195506     -413
- Misses        64672    65121     +449
+ Partials      16417    16381      -36

Impacted Files
Coverage Δ

...gregations/bucket/geogrid/BucketPriorityQueue.java
75.00% <ø> (ø)

...ions/bucket/geogrid/GeoGridAggregationBuilder.java
75.67% <ø> (ø)

.../bucket/geogrid/GeoHashGridAggregationBuilder.java
100.00% <ø> (ø)

.../bucket/geogrid/GeoTileGridAggregationBuilder.java
100.00% <ø> (ø)

...ions/bucket/geogrid/InternalGeoHashGridBucket.java
100.00% <ø> (ø)

...ions/bucket/geogrid/InternalGeoTileGridBucket.java
100.00% <ø> (ø)

...rch/aggregations/bucket/geogrid/ParsedGeoGrid.java
100.00% <ø> (ø)

...egations/bucket/geogrid/GeoHashGridAggregator.java
80.00% <50.00%> (ø)

...egations/bucket/geogrid/GeoTileGridAggregator.java
80.00% <50.00%> (ø)

.../main/java/org/opensearch/geo/GeoModulePlugin.java
100.00% <100.00%> (ø)

... and 485 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta Updated all classes inside geogrid package to reflect access modifier based on usage and updated documentation accordingly. Please let me know if i missed anything. Thanks.

precommit failure looks like irrelevant to this PR.
> Task :qa:evil-tests:thirdPartyAudit FAILED
Unnecessary exclusions, following classes have no violations:
   * com.google.common.hash.Striped64$Cell
  * com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper

@reta Can this be merged? Thanks

@VijayanB since we already released this functionality in 2.3 , it will be a breaking change in bacported to 2.x / 2.3, so backport label was not applied

@reta Since this is just refactor ( compile time ) and not affecting existing scope, Will releasing in 2.4 break backward compatibility?

The classes / interfaces were renamed, beside just visibility changes, we will just break people's code if someone is building on top of the GeoModulePlugin ...

The classes / interfaces were renamed, beside just visibility changes, we will just break people's code if someone is building on top of the GeoModulePlugin ...

Thanks for clarifications. The visibility change  is prerequisite for https://github.com/opensearch-project/geospatial/issues/98 . Do you have any recommendation on how to make those visibility changes available to 2.x?

The classes / interfaces were renamed, beside just visibility changes, we will just break people's code if someone is building on top of the GeoModulePlugin ...

Thanks for clarifications. The visibility change is prerequisite for opensearch-project/geospatial#98 . Do you have any recommendation on how to make those visibility changes available to 2.x?

I think it will be very difficult to refactor this pull request into something which is backward compatible (with 2.x). We may either make the effort to do that, or break the rule of backward compatibility on the ground this is a new module with high probablility not being used widely (or not backport at all which I belive is not desirable), @andrross @dblock what do you think guys?

@reta For this specific case it looks like we've already backported some breaking changes to 2.x with the rename GeoPlugin->GeoModulePlugin in #4179. Assuming that was released in 2.3 without issue then we can probably continue the pattern here.

Given what @andrross is saying we either have to revert/update #4179, or we can keep YOLOing it and backport this change to 2.x.
To provide a backward compatible interface we could implement InternalGeoHashGrid that extends from the newly refactored GeoHashGrid. The other idea that @VijayanB had in a brainstorm is to backport the change without doing the renaming (don't rename InternalGeoHashGrid to GeoHashGrid in 2.x). I think I really like this last option, WDYT?

The classes / interfaces were renamed, beside just visibility changes, we will just break people's code if someone is building on top of the GeoModulePlugin

GeoModulePlugin does not implement ExtensiblePlugin so it, in and of itself, is not extendable. Technically it should be marked @opensearch.internal w/ a final modifier.

To provide a backward compatible interface we could implement InternalGeoHashGrid that extends from the newly refactored GeoHashGrid.

A couple things here:

Technically the Elasticsearch aggregation framework never provided a formal API. This is (partially) why InternalGeoHashGrid was marked @opensearch.internal thus third party users are not guaranteed bwc.
GeoHash is legacy, the boundaries of a geohash grid do not align w/ mapping layers (which are technically web mercator grid). This is why there's geo_grid.
Moving to a more formalized API in 3.0 w/ the rename from InternalGeoHashGrid to GeoGrid is a good move here that we don't have to guarantee bwc support.

@nknize I really like the idea that introducing a formal contract for Geo Plugin/Geo features, to enable other plugins to build on top of it with BWC support. Given there is no commitment so far and this PR only refactored Classes that are marked internal, should we back port this PR to 2.x?

should we back port this PR to 2.x?

Yes. Given 3.0 is not far off this would be a good time to introduce a formal contract marked w/ @opensearch.api.


Contact Info form

@Bharathravi1995
Please check whether the app runs without an error.

In case you get this working some day: I would highly recommend that you combine your commits into one. The commit history looks awful :D
My suggestion is even to start with a fresh branch: Create a new branch that is up-to-date. Then manually incorporate your changes. And then push the changes. I can assist with this if you like.

@MBuchalik pls leave commit history in there since it is one part of the grading...

I would highly recommend that you combine your commits into one.

@MBuchalik pls leave commit history in there since it is one part of the grading...

Alright 👍 I thought that with this particular case (35+ commits) the author should simply (on his own) squash all into one. Wouldn't have changed the content or anything, but made his own history more clean. But let's leave it as it is :)

@Bharathravi1995
I pushed the working code to my branch. Please let me know whether it is visible for you?
If not I can create a new pull request.

Will be merging from a different branch


Send out interest form to organizers

-[ ] meetup attendees
-[ ] potential organizers who did not attend
-[ ] current organizers from past years

I emailed to the potential organizers.

And asked last year's organizers to update their contact info. @jhibbets messaged on the meetup page.

Actually the email to last year's organizers will go out tomorrow


Java Version installed is less than the required version of: Java 17.0.0 or isn't installed at all

Artix Linux x64
Using appimg
I have jre-openjdk 22.0.1.u0-1
I also tried installing jre17-openjdk but it didn't do anything
I do have the daemon installed from source

fixed by fixing java path


build(oxygen): add-on v0.0.7

Following #711, this pull request publishes the latest master via Oxygen add-on channel.
I tested this change on Oxygen 22.0 build<PHONE_NUMBER> using https://github.com/AirQuick/xspec/raw/oxy-addon_0-0-7/oxygen-addon.xml

I'm merging this, and directly I will verify the add-on online.

I'm merging this, and directly I will verify the add-on online.

Done. The upgrade from v0.0.6 was offered and v0.0.7 is working fine on Oxygen 22.0 build<PHONE_NUMBER>.


🐛 [ODM] generated orderBy methods do not support aliases

Bug report
Describe the bug
When the name is defined in the JsonKey for a field that has a different name on the class and in the field in cloud firestore the generated orderBy methods return no results.
Steps to reproduce
Steps to reproduce the behavior:
Define a model with a aliased name
class MyModel{
  MyModel({
    this.name,
    this.displayOrder,
  })

  @JsonKey()
  string name;

  @JsonKey(name: 'display_order')
  int displayOrder;
}

Notice that in the generated orderByDisplayOrder method on the MyModelQuery class the query line is var query = reference.orderBy('displayOrder', descending: false);
This causes zero documents to be returned when using the ordering method.
Expected behavior
It is expected that the the query is var query = reference.orderBy('display_order', descending: false);, using the name from the JsonKey annoatation.

Renaming properties is not supported at the moment.

This should have been closed before. Renaming is supported now, although it requires enabling a specific json_serializable flag (createFieldMap)
So closing


Added support for rtm.connect. Fixes #190

Summary
Added support for rtm.connect. Fixes #190
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

With rtm.start:
Print channel count (should be 13)
>>> if sc.rtm_connect():
...     while True:
...         event = sc.rtm_read()
...         print(len(sc.server.channels))
...         time.sleep(1)
... else:
...     print("Connection Failed")
...
13

With rtm.connect:
Print channel count (should be 0)
>>> if sc.rtm_connect(with_team_state=False):
...     while True:
...         event = sc.rtm_read()
...         # Print channel count (should be 0)
...         print(len(sc.server.channels))
...         time.sleep(1)
... else:
...     print("Connection Failed")
...
0

so for the lines you just uncommented, if we actually removed them, wouldn't that also solve #181? jeez we should really have some tests. 😢

@aoberoi it would, but if a dev is explicitly checking if rtm_connect is True as opposed to just seeing if it's truthy, it'd be a breaking change... 🤔

ah, thanks for pointing that out @roach.
we spoke about it in person and realized we can still fix the issue regarding the visibility of thrown exceptions (by not catching them and returning False) while leaving the return type the same (so that successful connections still return True).
we should pop back into conversations where people wanted the entire rtm.start Web API payload and direction them to inside the rtm.server Python object.

Merging this with tests coming in a future release in order to resolve a customer issue.

I am getting the below error:
TypeError: rtm_connect() got an unexpected keyword argument 'with_team_state'


Add Environment Canada component

Description:
Add a component which adds Environment Canada weather, sensor, and camera platforms.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#5685
Example entry for configuration.yaml (if applicable):
environment_canada:

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

How is this different from #15774, #15775, and #15776?

The other three PRs are standalone but related platforms. The idea with the component is to give the user the option to easily instantiate all three of the platforms with a single config line.

@michaeldavie Got it. You may consider adding a note to those PRs that instructs reviewers not to merge them until this one gets merged.

The dependency actually runs the other way, but that's a good point. I'll add a note up top.

No we don't add platforms first and then the component. The first PR should be 1 component and 1 platform. Thisbeill be merged first. The rest of the platforms should go 1 per PR later.
Please don't open more than 1 related PR at a time.

Sorry, I'm new to this and was trying to approach it from a user's perspective. The component isn't really required, I just thought it would make things simpler. How would you suggest I structure the functionality?

Sorry about spreading my feedback around between two PRs:
https://github.com/home-assistant/home-assistant/pull/15774#discussion_r207399583

No worries. I think I'll scrap the component and just go with separate platforms, since that seems to be a common approach for all of the similar weather-focused efforts.

That's ok if the platforms don't share any code, besides the library requirement.
I think it looks ok to just have them as separate platforms.


Fix fetch instrumentation

fix request headers stuff wip

refactor

This pr is meant to fix the fetch shim. The instrumentation currently doesn't use passed in Response objects well. It would overwrite the headers in the response object because fetch would see the option headers passed in through the headers carrier, and it would overwrite whatever may have been in the Response.headers property

Would you folks want me to send up the new build btw?


plex-desktop: enable passthru.updateScript

Description of changes
Enable automatic updates by setting  passthru.updateScript.

Things done
Tested with
nix-shell maintainers/scripts/update.nix --argstr package plex-desktop

And, we get the commit: plex-desktop: 1.96.0 -> 1.97.2

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Would the git add and git commit actions cause issues for @r-ryantm?

Looking at how other packages do this, my understanding is no this should be fine.
One example is  git itself which uses the same git add and git commit convention in the same script it passes to passthru.updateScript. If there is firm documentation that says this isn't correct, send it my way!

nixfmt makes this look like a bigger change, but there are only 2. In addition to  passthru.updateScript, I've added inherit meta to the buildFhsEnv step just so that search.nixos.org looks nicer.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4476

Should be resolved.
Thanks for the review!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1956


"Deploy to Kubernates" typo in README.md

Documentation Scope
main README.md
Describe the Change
Deploy to Kubernates => Deploy to Kubernetes
Screenshots

Additional context
Now let me fix it :)

Can you assign this to me also? @nikitakoselev

Thank you, @shebuel-oss , I have already resolved the issue. Could you please take a look at my pull request to double check it looks fine?

Hi everyone, I check #1963 , it looked alright, but I couldn't merge it since it was closed.

Hi everyone, I check #1963 , it looked alright, but I couldn't merge it since it was closed.

I saw he fixed it in #1966, hh

fixed by #1966


ci: updated ci config #6

Codecov Report

Merging #6 (7e6e893) into main (33c8b0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          30       30
  Lines          84       84
  Branches       10       10
=======================================
  Hits           82       82
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c8b0b...7e6e893. Read the comment docs.

Codecov Report

Merging #6 (7e6e893) into main (33c8b0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          30       30
  Lines          84       84
  Branches       10       10
=======================================
  Hits           82       82
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c8b0b...7e6e893. Read the comment docs.


Improve the Sequel benchmark to avoid many singleton classes

These singleton classes are expensive to create and also cause a lot of uncached method lookups.
Both Post.create and Post.where(id: i).first create a new singleton class per call (through #clone of a dataset object which has a singleton class).
With this commit, no singleton classes are created during insertion and in run_benchmark. And therefore also no uncached method lookup.

We discussed this in details on the CRuby Slack. @jeremyevans suggested using Post[i] or Post.first(id: i) instead of Post.where(id: i).first.
I think what's important is to benchmark something representative of what users would use.
@jeremyevans Do you know if Post[i] or Post.first(id: i) is frequently used by Sequel users? What's recommended in the documentation?
Numbers on 3.2.1 YJIT:

Post.where(id: i).first (original): 130ms
Post.first(id: i): 79ms
Post[i]: 68ms

For DB[:posts].insert() vs Post.create(), I think it would be more representative to use Post.create(), but OTOH this is only part of the setup, not of the measured time, and it seems good to avoid too much side effects during the setup (Post.create() does cause one uncached method lookup (for a literal_integer call site) for Post[i]).
I think this is something to improve in Sequel, Post.create() should be able to cache the dataset or avoid creating a new one, similar to what DB[:posts].insert() does. So once that's fixed in Sequel we could use Post.create() again.
Related: #205 #159

It seems to make sense to have more idiomatic/efficient use of sequel in the benchmark.
@jeremyevans any input?

Post[i] is definitely more idiomatic and efficient for Sequel.  However, if you are using models, Post.create is more idiomatic than DB[:posts].insert, though it is less efficient (create handles validations, callbacks, etc.).  I should be able to commit a change to Sequel today to avoid the use of singleton classes for datasets.

FWIW, all extensions and plugins other than timestamps should be removed from the benchmark.  The only one that has an effect is prepared_statements, and that's no longer recommended for general use.

Thank you Jeremy.

@jeremyevans @eregon My thinking for adding this benchmark is not find the most performant way to do a query in Sequel but to see if and how much YJIT can optimize code with the plugin strategy because it is a chain of method overrides using modules.
Sequel has multiple ways to do a query and maybe the strategy should be to see how the fastest and slowest query methods perform in YJIT optimizations. If I were developing JIT, I would want different code strategies and see how JIT compiles and optimizes it.

@hmistry I understand. I think what matters though is the benchmark is representative and benchmarks something meaningful, if it's benchmarking something nobody/very few use, then it's a not so useful benchmark, because it might lead to optimizing things that are irrelevant for actual performance in practice (and optimizing things take time).
In this case, many singleton classes and uncached method lookup are pretty much pointless to benchmark on YJIT, this stuff is handled by the interpreter, YJIT or even any JIT can do little about it. Basically we found a performance issue in Sequel and that's getting fixed (https://github.com/Shopify/yjit-bench/pull/208).
Regarding the plugin strategy, AFAIK that is still being benchmarked with this PR (at least the various plugins are in Post's ancestors).


Move /sshSSOPublicKey to /connectivity/sshSsoPublicKey

What this PR does / why we need it
Towards https://github.com/giantswarm/roadmap/issues/2142
Checklist

[x] Update changelog in CHANGELOG.md.

Trigger e2e tests
/test create
/test upgrade

What has triggered these e2e tests? They are expected to fail. Am I fine to merge?

What has triggered these e2e tests? They are expected to fail. Am I fine to merge?

You did

Yes, it's fine to merge.

OK. I somehow didn't expect to trigger tests from the main comment. :) Thanks for the hint.


Binary_Search_Java

What is the change?
Added Binary Search Algorithm in java, explained with an example.
Related issue?
closes: #38
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] I have followed the Code of Conduct.
[x] I have  checked there aren't other open Pull Requests for the same update/change.
[x] I have you tested the code before submission.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest'21 contributor.

Screenshots (if any)

Added the Binary Search Algorithm in Java with the help of an example. Wrote the code in simpler manner and added proper comments for better understanding.

You have to add this in the already created file.

okay sure I am adding this to Binary_Search.md

Removed the previous Binary_Search_Java and made changes in existing Binary_Search.

You can't delete it just try to make changes in existing one

Hello Siddhi sorry for the inconvenience but just merge the pull request from here Binary_Search java solution #69. I have made the changes as per your requirement, you may check the branch(akankshaa02-patch-2). Feel free to merge it into the code base.


Broken compilation when using es2019 lib

🐞 Bug Report
Describe the bug
Installing ts-toobelt v4.7.19 when using lib esnext or es2019 causes compilation error in
node_modules/ts-toolbelt/out/types/src/Tuple/Diff.d.ts:17:96 - error TS2589: Type instantiation is excessively deep and possibly infinite.

17 export declare type Diff<T extends Tuple, T1 extends Tuple, match extends Match = 'default'> = TupleOf<ODiff<ObjectOf<T>, ObjectOf<T1>, match>>;

Installing v4.7.18 does not cause this error

Reproduce the bug
Use this minimal tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "lib": ["es2019"],
    "strict": true
  }
}

Additional context
TypeScript 3.6.3
Only es2019.array is enough to trigger the error, although not clear what in https://github.com/microsoft/TypeScript/blob/master/lib/lib.es2019.array.d.ts causes it.

Hi @vogre, thanks for reporting this issue. Looking into it

It's fixed!


Component Rendering Problem

For a section, the API calls only once. Try making more API calls or fetch all the data on a single API call.

issue is fixed


Is this package deprecated?

This seems like it's a predecessor of https://github.com/nobleo/path_tracking_pid. Is this version deprecated? Because in that case, we should clean it up.

No, it uses a different principle.
path_tracking_pid has an open-loop forward velocity and uses a carrot-like algorithm to stay on a path.
This package does 3DOF control on such a carrot. Useful for example for vessels, where an open-loop velocity is tricky.


Add a |cancel| method to PDFDocumentLoadingTask

(Replaces PR #5234.)
Fixes #3485.
Fixes #4774.
Fixes #5228.
Fixes #5572.

/botio test

/botio-linux preview

It's more complex than I thought. We need to cancel it not only on the api.js side, but on the worker.js side as well. Which means any in-progress xhr must be terminated, any rendering operations terminated. Also, we probably need to add a callback similar to onProgress, on signify end of document loading (onComplete?) -- it might not fire on disableAutoFetch, but it will signify end of cancel method "effectiveness". We might even need to rethink whole PDFDocumentLoadingTask thing.

in-progress xhr must be terminated, any rendering operations terminated.

Maybe just terminate xhr and will not allow any I/O operations after that. PDFDocumentProxy.destroy shall worry about worker cleanup (the exception is when the document promise was rejected)

Maybe just terminate xhr and will not allow any I/O operations after that.

Isn't the patch already doing this, at least partially? See https://github.com/mozilla/pdf.js/pull/5629/files#diff-0ecad279ed2252e3eb47a4d96ec1463cR270 (which might need a slightly better comment).
Since api.js#L951 calls worker.js#L459, which in turns calls pdf_manager.js#L218 and then finally network.js#L262. As far as I can tell, this should be sufficient to close any open connections.
I've, so far, only tested this in the GENERIC viewer, where it appears to work as it should.
Is my understand of the code correct, or does the existing code not close everything you had in mind?

Yes. But we don't have exposed api for it at getDocument level. Also this api call shall not destroy the worker if getDocument is successfully resolved - we have destroy in PDFDocumentProxy. So this PR will be about refactoring mess with states we have atm


Exception thrown in activate function

Our remote monitoring indicates that some users receive Cannot read property 'length' of null exceptions from the element's activate() function.
Observed OS/browsers for which the exception was reported:

Chrome 52 on MacOS
Chrome 50 on Win 7

The problem was that I mixed up the querySelector and querySelectorAll functions - 1ce24f2 fixes that.


update to latest lean

@larsk21 , what are your thoughts on handing over maintenance of this project? I see you have not worked on this since the masters and I'm guessing you don't intend to work on it anymore.

Since for my PhD I'm working on a topic not involving Lean, I (at least for now) unfortunately don't have the time to work on this project. So, I'm more than happy if someone wants to continue working on it. If you have plans to maintain the project, how do you suggest we do this? Should I add you as a collaborator or transfer the project to, e.g., leanprover-community?

I discussed this with the other maintainers and we're on board with transferring the repo to leanprover-community. I think you won't be able to do it directly; the options I have found so far are for you to transfer the repo to my personal account and then I transfer it to leanprover-community; or you add me as an admin on this repo, whereupon I can trigger the transfer.

Great to hear! :) I can surely add you as an admin for this repo, such that you can then transfer it.
Before doing so, I figured it would be good to add a license to the repo. As most Lean-related repos seem to use the Apache-2.0 license and I don't have an interest in restricted the usage of the repo further, I would go with this one, if you don't have any objections.

Sounds good to me.

Oh, if we are making this repo look more like mathlib then we should probably put copyright headers on all the files, with you as author and the year you wrote this stuff.

Alright, I can do that.

Oh, if we are making this repo look more like mathlib then we should probably put copyright headers on all the files, with you as author and the year you wrote this stuff.

I don't mind either way, just curious (because I may have forgotten): is this a style the community simply copied from Lean, which copied it from MS style? Or is it something the community actively prefers? I find that for open-source projects, the GitHub generated contributors list is mostly sufficient and in particular more up to date (whole-repo copies from ports notwithstanding!)

As far as I know it was just copied. But the authors list is not easily replaced: it includes "significant authors" not just anyone who touched the file, and as you point out the port has probably permanently messed up the github author list for mathlib4.

Okay, I've deleted my repository (this PR was a casualty, but I can re-add it once the repo makes it to its new home). Hopefully you should be clear to transfer the repo to me now.


ConfigPush metrics in SCD mode should be labeled with dataplane's host

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
KIC reports ConfigPushCount and ConfigPushDuration Prometheus metrics. When running in SCD mode, it could be useful to have the reported metrics to be grouped by an instance of a dataplane.
Proposed Solution
Add dataplane_host label to both ConfigPushCount and ConfigPushDuration metrics.
Additional information
No response
Acceptance Criteria

[x] It's possible to group ConfigPushCount and ConfigPushDuration Prometheus metrics by dataplane address
[ ] Users can get information about this change from outside facing documentation https://docs.konghq.com/kubernetes-ingress-controller/latest/references/prometheus/

Relevant docs PR: https://github.com/Kong/docs.konghq.com/pull/5146

Closing this one since we have the separate docs milestone tracking that and the code is already in.


token-list repository is archived and read  only now! is there an alternative

I know this is not the appropriate place to ask this question, but I did want to add a token I made to the repository, and found it being archived and read only.
how can I achieve that?
and sorry again for asking this question here

You are right, this isn't the right place for this question. Please ask questions in the Solana Discord. The token list is not managed on Github, especially here.