Boss key hints

Added hints that point to the location of the boss key for required dungeons

boss key hints have to be added to the changelog
currently these changes do nothing so bk hints would need to be added to some existing hint distribution or a new one
if a BK is on LMF BK chest or 3rd small key, that's always hinted and not counted towards the fixed number of BK hints, I guess that's intended?

The last two points are likely meant to be solved by new hint distributions. The dungeon always hints would be downgraded to sometimes hints or removed, since the BK hint sort of takes the role those hints used to fill.

For the last two points, yep exactly as Yal said


Memory regression diff-maxend-maxend-medianend-min flutter_gallery__back_button_memory

See https://flutter-flutter-perf.skia.org/e/?begin=1602714272&end=1602741425&keys=X0394285421bc8feb15fab9583133b561&num_commits=50&request_type=1&xbaroffset=22015. Pretty clear signal.
Looks like commit https://github.com/flutter/flutter/pull/68148.

That engine roll contains 3 commits: one affects the linter, one affects vulkan, the other affects android.  The regressing test is running on android without vulkan which means the regression should have appeared in flutter/engine#21839.  @iskakaushik is it expected that that commit should increase resident memory by ~10,000 KB?

If I repeatedly suspend and resume Gallery and then run adb shell dumpsys meminfo I'm seeing the Native Heap metric increase by around 1MB on each cycle.
It looks like that started with https://github.com/flutter/engine/pull/21839

https://github.com/flutter/engine/pull/21918  Landed, we'll wait until the numbers drop before we close this.

Jason is confident the revert will fix the issue.

https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3Dend-max%26test%3Dflutter_gallery__back_button_memory
This change rolled to the engine and there was a drop in the memory usage.
end-max went from 63122KB to 55149KB
The regression was 49693KB to 60917KB
Considering the matter closed, thanks @jason-simmons


Remove schema.rb from git

Huginn supports MySQL and Postgres which generates conflicts in the schema
Remvoing it shows that schema.rb is not a source of truth

Closes TildeWill/huginn#13
Related Issue cantino/huginn#1195

Doesn't this break existing setup instructions?
I guess bin/raked db:setup would not work without the file.

We should test it, but I thought that rake db:setup db:migrate db:seed should still work fine?

@knu is correct, db:setup would not work without a schema.rb, so the user installing Huginn would have to call db:migrate. However, I searched cantino/huginn and did not find any references to db:setup. @knu, can you point to where this call is referenced in the instructions?

@TildeWill It is mentioned in seeds.rb, but I did not find any other occurrence of it either. One problem is the GitHub search does not cover the wiki :disappointed:, which makes me dislike it even more.

There's a Github Wiki Search Chrome extension, which shows no reference to db:setup when searching for "setup".

I think we could safely remove it then, but since it has been the only source for checking the database structures, I'd like to introduce the "annotate" gem so each model file includes the schema information of the corresponding table in database.

Wouldn't the annotate gem just move the commit message noise from schema.rb to the individual models?

I agree with @dsander, the annotate gem would move the problem into the models. Also, by removing schema.rb from git, developers will have a schema.rb as soon as they run db:migrate that accurately matches their local db, rather than whatever db last ran a new migration and got checked in.
But I didn't know about the annotate gem before this, I would have loved to use it on other projects where we supported a single database type/version. Thanks for the pointer!

Thought it would be OK because annotate doesn't bother with extra table/column options like character set and collate, but the problem may be the stuff like the order of columns in a table, etc.  I think I'll give it up then.

I think I agree with removing schema.rb.  We can always add annotate if we feel it lacking.  Perhaps it won't be as churny?
Merging!  Thanks @TildeWill!


Update Prana to Karyon 2.7.1

Hi,
I've updated Prana to karyon 2.7.1.
It solves issues like #1 and #14

@jaume-pinyol I've only been able to compile this branch by adding the following dependencies:
    compile 'com.netflix.hystrix:hystrix-core:1.4.14'
    compile 'com.netflix.ribbon:ribbon:2.1.0'
    compile 'com.netflix.ribbon:ribbon-eureka:2.1.0'

Thanks @nmdguerreiro !

@jaume-pinyol @nmdguerreiro Thank you for the contributions.  More will be coming, but please see http://ispyker.blogspot.com/2015/10/towards-being-better-about-open-source.html for a bit of context on the status of this project.

@aspyker thanks for the info!


Revert "Change playback rate with GST_SEEK_FLAG_INSTANT_RATE_CHANGE in rialto server"

Summary: Revert 'Change playback rate with GST_SEEK_FLAG_INSTANT_RATE_CHANGE in rialto server'
Type: Revert
Test Plan: UT
Jira: RIALTO-564

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/50125/

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/50127/


Time Range - unrecognized arguments on Mac Terminal

Hi!
First off, thanks for creating this - what an amazing resource! I'm having trouble executing a time_range argument when running command line terminals on Mac. I'm a complete newbie, so I may not be typing the command for time range correctly (have tried lots of variations with & without brackets, etc). Any guidance is appreciated!
I keep trying to run the below but get "unrecognized arguments" errors no matter what variation of the arguments i use:
`googleimagesdownload --keywords "economy chart" --limit 10  --time_range {"time_min":"01/01/2018","time_max":"04/01/2018"}
#result returned below
googleimagesdownload: error: unrecognized arguments: time_max:04/01/2018`
I've also received an error when using '-wr' in place of '--time_range'
`googleimagesdownload --keywords "economy chart" --limit 10  --wr {"time_min":"01/01/2018","time_max":"04/01/2018"}
#result returned below
googleimagesdownload: error: argument -w/--time: invalid choice: 'time_min:01/01/2018' (choose from 'past-24-hours', 'past-7-days')`
Thanks!

@mustafa3000 could you resolve your issue?

Hi @hardikvasa - onlyl partly :) I figured out how to use the command - BUT the "time range" filter doesn't seem to work (on Mac terminal).
rather when i compare the downloaded results against searching on google images, i get very different results when using "time range" argument.
For example:
when using a command without the time range filter like
googleimagesdownload --keywords "daily chart " --limit 10 --time 'past-7-days'
i will compare the results i download against a live google image search, and will see the SAME results.
However, when i add the time range argument,
googleimagesdownload --keywords "daily chart " --limit 10 --time_range '{"time_min":"01/01/2017","time_max":"05/01/2018"}'
i do NOT get the same results. it seems the time range throws the search off and not sure if anyone else has this issue. Any guidance is helpful.
Thanks!

Hi hardikvasa and nustafa3000,
I am glad to be here and I found that in source code the argument making for time_range is incorrect and I corrected it in my side but I am not sure how to push a new branch/commit to your project.
The issue is in around line 365,
if arguments['time_range']:
            json_acceptable_string = arguments['time_range'].replace("'", "\"")
            d = json.loads(json_acceptable_string)
            time_range = ',cdr:1,cd_min:' + d['time_min'] + ',cd_max:' + d['time_max']

after changing the d['time_max'], it should be working fine. :)

thanks @mustafa3000 and @ty-vincenthung for the inputs. The changes were merged in #152 so this should be fixed now.


Pressing Check for update does not update to new version

ℹ Computer information

PowerToys version: 0.22.0
Running PowerToys as Admin: Yes
Windows build number: 19042.541

✔ Expected result
It should start updating to v 0.23.
❌ Actual result
It reports saying Powertoys is up to date.

@Cyberdroid1
0.23 doesn't include the VideoConferenceMute module therefore it would be wrong to update 0.22 to 0.23.
Next week we will release 0.24 that will contain the updated VideoConferenceMute module.

Oh, ok. Thanks for letting me know. Any way to add this as disclaimer in the wiki maybe? Don't need it though. You may close this issue now.

This could be, because you are running an build from the preview-build string. The new preview-build is not released yet.

@crutkas
should we add a disclaimer to the Wiki, as @Cyberdroid1 suggested?

We can but like, are people going to go out and actively search for this?

What about adding it in Releases page?


navbar li active

changed the li background color to active

This is not the right way to do. Delete the repository that you forked from personal account ASAP.


breaking: delete Copy component

Closes #1156
The Copy component is used internally by CodeSnippet and CopyButton. It is not meant to be used or exposed to the end user. Having it exist in auto-generated documentation can be misleading.
Releasing this breaking change also requires an update to carbon-preprocess-svelte.

Released in v0.62.0.


Issue when running plugin

Hi,
i've tried this plugin and I think it's a great idea.
I have a problem when running this plugin. I tried master and 0.2.0 version.
After step 6, bundle exec rake redmine_elasticsearch:reindex_all RAILS_ENV=production, I got this error.

I'v corrected line in search_controller_patch.rb, line 204,  from
def get_search_fields(titles_only:, search_attachments:)
to
def get_search_fields(titles_only, search_attachments)
I've successfully reindexed document in Elasticsearch with version 0.2.0 but not with master.
Master gives me error in, index.rake, line 68.
estimated_records = ParentProject.count
ParentProject not initialized.
Thank you,
Nejc

Hi @frogec ,
I think you got this error because you are use old ruby.
And I can not guarantee that this plugin will work on Windows.

Yes, it was a problem with old version of ruby. I've got it to work by updating ruby/redmine by using latest Bitnami redmine-3.3.2-2. And all this is working on windows and for now no problems.
I'm closing the issue.


Ensure we're hiding non-message events

Both in /sync and in /event_relationships. Interesting Q is what to do when a thread references it - perhaps displaying something rather than breaking the thread is better?

We filter only m.room.message on the user page, and allow any event with a valid m.relationship on the status page to preserve threading.


Custom Colors / Gradients

I'd really like to create a rainbow gradient to use, but there's no option to create custom gradients. There's also no option to set custom colors.
I was looking through the code, and it's ridiculously well organized. I could very easily add this gradient into the program, and I could look at creating a gradient creator too. Would you be open to this?

Hi @ShiromMakkad,
Yes you are most welcome to add new effects.
Effects are defined in ledfx\ledfx\effects
I would also suggest to have a look at how the rainbow effect works for an idea of the pixel generation.
https://github.com/ahodges9/LedFx/blob/dev/ledfx/effects/__init__.py
Join our Discord LedFx server for general LedFx discussion and assistance via: https://discord.com/invite/wJ755dY
Once tested, do a pull request to: https://github.com/ahodges9/LedFx/tree/dev and comment on the Discord channel #dev_chat your pull URL.

There are two effects that look like what you are after, Gradient and Rainbow effect.
Are you using https://ledfx.app/download/ version: LedFx <IP_ADDRESS>?
The latest version has presets, which allows you to save this effect configuration as a preset.
I think this is what you are referring to?

Thanks for the help, I've actually realized looking at the code that Spectral is the name for rainbow. Personally, I'd rename that to be more clear.
I still really like the project and codebase, and I've got a lot of React experience so I'd be happy to help out.
Based on what you've said about the WLED effect here: https://github.com/ahodges9/LedFx/issues/47, I think that you want LedFX to be a universal controller for lots of RGB software, and I'd love to help with that. We could even potentially integrate with OpenRGB, so you can control all your PC peripherals with this too.

@ShiromMakkad agreed. We have renamed spectral to rainbow.
Your help would be appreciated! Integration with other projects is always nice - we have various senders at the moment, so integrating an i2c header control is possible, or utilizing OpenRGBs API.
We're going to try to squash some bugs.


bug: pulumi not deleting AWS Spot instances

Hello!

Vote on this issue by adding a 👍 reaction
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details
Hi everyone,
When i try to delete AWS spotinstances (aws-classic provider), it does not delete them. I need to terminate the instances by hand.
spotInstanceRequest, err := ec2.NewSpotInstanceRequest(ctx, "control-plane", &ec2.SpotInstanceRequestArgs{
				Ami:              pulumi.StringPtr("ami-05f7491af5eef733a"),
				InstanceType:     pulumi.StringPtr("c4.xlarge"),
				Ipv6AddressCount: pulumi.IntPtr(1),
				KeyName:          keyPair.KeyName,
				SubnetId:         subnet.ID(),
				VpcSecurityGroupIds: pulumi.StringArray{
					newSecurityGroup.ID(),
				},
			})
			if err != nil {
				return err
			}

Steps to reproduce

Create a pulumi deployment with the aws-classic provder, use  ec2.NewSpotInstanceRequest
pulumi up -> everything gets deployed
pulumi destroy -> Stuck on delete

Expected: Pulumi terminates spot instances
Actual: Not delete the spot instances

I tried reproducing this error today with the following program:
import * as aws from "@pulumi/aws";

const ami = aws.ec2.getAmi({
    filters: [
        { name: "name", values: ["amzn-ami-hvm-*-x86_64-ebs"] },
    ],
    owners: ["137112412989"], // Amazon
    mostRecent: true,
}).then(result => result.id);

const cheapWorker = new aws.ec2.SpotInstanceRequest("cheapWorker", {
    ami: ami,
    instanceType: "c4.xlarge",
    spotPrice: "0.03",
    tags: {
        Name: "CheapWorker",
    },
});

It succeeds both on up and destroy. I'll assume the issue has been fixed. If anyone still experience the problem, please provide a repro for it.


Doesn't work on MacOS Sierra

Short info header:

GFX version:0.3.0
OS: OSX 10.12.6
GPU: Intel Iris Plus Graphics 640 1536 МБ

It draws just a white screen
feature=metal
https://imgur.com/a/uHli2AF

I think this is the same issue as #2563 (Metal on Sierra)

I believe this is fixed by #3049


Advancements support

Describe the problem related to your feature request.
The ability create own advancements tabs.
What solution would you like?
An easy to use api to modify these tabs
What alternative(s) have you considered?
-\
Additional context
There are already packet structs for this but it seems they are not connected to the api.

Yep, we should probably make a valence_advancement crate and feature flag for this.


Question: Expiration time

Hello @nodh
I just wanted to ask if there is a requirement from EU to throw away the data if the signing is expired. I was searching for it but could not find.
    /**
     * `exp` claim SHALL hold a timestamp.
     * Verifier MUST reject the payload after expiration.
     * It MUST not exceed the validity period of the DSC.
     */
    var expirationTime: Instant? = null

That's from the hcert-spec: https://github.com/ehn-dcc-development/hcert-spec/blob/main/hcert_spec.md#335-expiration-time


content test: Aim taps on links more precisely at the text

By saying tester.tapAt(find.text('hello')), we had been aiming at the center of the Text widgets, and expecting that to hit the recognizer we've put on the span, even though the widget is much wider than the span and the latter doesn't reach the former's center. Effectively we were relying on the presence of issue #214.
But with an upstream change yesterday:

https://github.com/flutter/flutter/pull/140621
https://github.com/flutter/flutter/issues/43400

such a tap no longer hits the span.  That broke these tests.
To fix them, aim the taps near the start of the widget instead.

Also bump the Flutter version to require that upstream change, fixing #214.
Fixes: #475
Fixes: #214

Great, thanks! Merged.


Setting failOn does not work properly

Hi Freddy,
I specified the settings.json as below:
{     "country":  "us",     "AppSourceCopMandatoryAffixes":  [         <ourPrefixes>     ],     "appFolders":  [     ],     "enableCodeCop": true,     "enableUICop": true,     "failOn": "warning" }
However I do not get failOn warnings. It is still passing the build.

And here is what I can find in the build:

Is there anything that I should change in the settings?

In the build output, under Build, Run pipeline, expand the very first run line.
What is the value of failon there:

(Just to see if your setting is correctly found)

Thx the case - there is no such parameter in the parameters

Not in parameters - in env variables under the first > Run...

You can search the log

Ok now see it:

Ok, so the setting gets read correctly - will investigate

The error is in ContainerHelper - will be fixed in the next preview (which automatically is selected when using AL-Go preview).


Raw starstone texture doesn't load

When game first loads if Raw Starstone item is not in player inventory texture doesn't load
(item is invisible in chests, creative inventory tab...).
Texture only loads after item is in player inventory.
Method setItemModel(); should be called when game starts so I am not sure what exactly is problem here.
`public class RawStarstone extends Item {
public RawStarstone(Settings settings) {
    super(settings);
    setItemModel(1.0F);
}

public void inventoryTick(ItemStack stack, World world, Entity entity, int slot, boolean selected) {

    if (world.getTimeOfDay() > 22350 || world.getTimeOfDay() < 21980) {
        setItemModel(0.0F);
        stack.setCount(stack.getCount() - 1);
        BlockPos pos = entity.getBlockPos();
        Block.dropStack(world, pos, new ItemStack(MysticGemstonesItem.STARSTONE_DUST));
    }
    else {
        setItemModel(1.0F);
    }
}

public void setItemModel(float number) {
    FabricModelPredicateProviderRegistry.register(MysticGemstonesItem.RAW_STARSTONE,
            new Identifier("shining"), (itemStack, clientWorld, livingEntity, hmmmm) -> number);
}

}`

Fixed in<PHONE_NUMBER>fb1c7da17cee48c302102ae0107c17
Same problem still applies to Starstone Dust and Condensed Starstone Dust.

fixed in 19dfc38eceb736a9fa8cb13a0011c975946cbb22


Fix Lottie dependencies

Description
This PR resolves the dependency issues required for Lottie in the pull request https://github.com/dust-tt/dust/pull/4367. Rollup does not bundle .json files.

Risk

Deploy Plan

@Duncid FYI.


_Decorator.updateRenderObject does not update textAlignVertical

I noticed this when a text field's vertical alignment wasn't updating on a setState call. It looks like the _Decorator.updateRenderObject method in input_decorator.dart doesn't update the textAlignVertical property, though it does update all other _Decorator properties . Assuming this was an unintentional omission?

On the face of it, this sounds like a bug. Please provide the output of flutter doctor and a small self-contained app that demonstrates the problem, and we'll look into it.
CC @justinmc

Re. self-contained app, replace main.dart of a fresh flutter create with the below code:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: VerticalAlignDemo(),
    );
  }
}

class VerticalAlignDemo extends StatefulWidget {
  @override
  State<StatefulWidget> createState() {
    return _VerticalAlignDemoState();
  }
}

class _VerticalAlignDemoState extends State<VerticalAlignDemo> {
  TextAlignVertical _align = TextAlignVertical.top;

  void _cycleAlign() {
    List<TextAlignVertical> options = [
      TextAlignVertical.top,
      TextAlignVertical.center,
      TextAlignVertical.bottom,
    ];
    int newIndex = (options.indexOf(_align) + 1) % options.length;
    setState(() {
      _align = options[newIndex];
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          TextField(
            controller: TextEditingController.fromValue(
              TextEditingValue(text: 'Hello World'),
            ),
            textAlignVertical: _align,
          ),
          IconButton(
            icon: Icon(Icons.refresh),
            onPressed: _cycleAlign,
          ),
          Text('Vertical alignment that should be shown: \n$_align'),
        ],
      ),
    );
  }
}

Flutter doctor:
[✓] Flutter (Channel unknown, v1.18.0-10.0.pre, on Mac OS X 10.15.4 19E287, locale en-US)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
[!] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Android Studio (version 3.1)
[✓] IntelliJ IDEA Community Edition (version 2019.2.4)
[✓] VS Code (version 1.43.2)
[✓] Connected device (2 available)

! Doctor found issues in 2 categories.

Thanks for the follow up!  I was able to reproduce this.  Looks like it should be a quick fix.


India/UDISE - Number of Schools having Library by School Category and Management

Work In Progress: PR is ready but we are still getting data. We can merge once all the data is got.
--
@ajaits @pradh

Need to import UDISE Geography  first. This dataset uses udiseCode to resolve location.
Raw data is not committed. But raw data is here. Can be re-downloaded if required
Will do a separate PR for Schema project.

@beets Thank you. Done.

@beets shall I merge?

yes please, feel free to merge after approval (and addressing remaining comments).


RFP - flac-frontend

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : http://flacfrontend.sourceforge.net/
Direct download URL for the software / installer : https://sourceforge.net/projects/flacfrontend/files/FLAC frontend v2.1.msi/download
Software summary / short description: Graphical frontend for the official FLAC tools

I'll pick this and the flac package up.


Teams page vicki

Note: 🔺filed are required.

Summary 🔺 (Summarize what did you do)

LinkedIn and email info
About Us & Our Purpose

Issue Number 🔺 (Paste your issue link here)
https://github.com/UofT-VEEP/VEEP-Website/issues/44
New Proposal (Any new features/changes you think would work well/look good on this page)

Add bg img later
Short intro for our teams

Hi Vicki, the webpage looks great! One more thing that you may want to change is the responsiveness of the cards of all the members. When viewing the current form on a phone, the text for each member becomes so compact with only a few letters per line. Can you try to display only one card per row when the screen is squeezed to a certain size?


Hide circles

Hello. Can I hide all of the circles via some prop?
I can try to submit a PR if you don't mind.
Thanks!

it would be an easy prop to add but just try adding this prop
circleDefaultStyle={{ height: 0, width: 0}}


#7 Update .NET SDK TragetFramework from .net6.0 to .net7.0.

Update .NET SDK TargetFramework from .net6.0 to .net7.0. This is the only available SDK version for sandbox at the moment. Consider using .net8.0  (LTS version) as it becomes available for sandbox users in Microsoft Learn training exercises.

sorry, created with commit wrong github user


show errors only on submit

i see there is an option which mention
adds a trigger to show field validations after submmit
// show validation-messages on failed submit
setFormDirtyOnSubmit: true,
But whenever i am enterring wrong email address it shows before typing
http://plnkr.co/edit/dbeukAv774rnJ8jpmzqP?p=preview

Doesn't happen to me with your plunkr (had to fix the path to ng-fab-form: ).
Might be the autofill functionality. If the input is set by your browser, the validations will trigger.
Also: Which Browser are you using?

I am using mozilla;

Do you see; i can see error without clicking the submit button;
I want this error to be shown only after submit button is clicked and form is not valid;

Now I get you. That's the intended default behavior. setFormDirtyOnSubmit just means that the messages are also shown, when you trigger the submit without having entered anything.
If you only want to show errors on submit and never before, you can change the validation template like this:

to

Tell me if it works out for you.

it works thanks @johannesjo
woooooo !!!!!


Support for retries and timeout

Hi,
Is there support for retry and orchestrator side timeout option available in Semaphore?

👋 @Purushottamlpa, Thank you for submitting your issue. Currently is there no retry functionallity build into Semaphore. Flow retries could be implemented through middleware. Could you maybe elaborate a little bit on why you need this feature?

Orchestrator side timeout

It is possible to set request duration timeouts inside the listeners. There is currently no possibility of defining a custom timeout for a specific flow.

Thanks @jeroenrinzema. My query is within in a flow, if an HTTP call fails, is there any inbuilt support to put a delay in flow and retry failed service with configurable delay.

Hi @Purushottamlpa, There is currently no built-in support for such use-case. It should be possible to implement this inside the node caller (https://github.com/jexia/semaphore/blob/master/pkg/flow/caller.go#L77-L90). An additional option has to be introduced inside the specs.Node. This option should be populated inside the HCL syntax to configure the retry policy.
https://github.com/jexia/semaphore/blob/eed88a8f65fe33e2747aad66255db763e36a0f54/pkg/providers/hcl/specs.go#L545-L566


Jesse: Blacklist uncodemy.com

Jesse requests the blacklist of the website uncodemy\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

uncodemy\.com has been seen in 4 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


blank=False validation on RichTextField / RichTextBlock is applied inconsistently

Issue Summary
Submitting an empty RichTextField that has been defined as blank=False only produces a validation error if the user focuses on the field before submitting the form.
This happens because the spacer paragraph insertion logic in wagtail.admin.rich_text.converters.html_to_contentstate normalises empty rich text content to a single empty paragraph, whereas Draftail explicitly tests for this case and returns null. If the user never focuses on the field, Draftail is never activated, and so the final value of the field (following conversion back to dbHTML) ends up as

, which is considered non-empty by Django validation.
We propose that html_to_contentstate should catch empty content as a special case, and return null. (Doing this within html_to_contentstate, rather than checking the initial string value before html->contentstate conversion, ensures that we also catch HTML constructions that are semantically empty but not equal to the empty string, such as

.)
Steps to Reproduce
From a fresh wagtail start project:
./manage.py migrate
./manage.py createsuperuser

Update home/models.py:
from django.db import models

from wagtail.admin.edit_handlers import FieldPanel
from wagtail.core.fields import RichTextField
from wagtail.core.models import Page

class HomePage(Page):
    body = RichTextField(null=False, blank=False)

    content_panels = Page.content_panels + [
        FieldPanel('body'),
    ]

Run:
./manage.py makemigrations  # (set '' as the default value for the field)
./manage.py migrate
./manage.py runserver

Edit the homepage; click 'save draft' without focusing on the body field - no validation error
Edit the homepage; focus on the body field then click 'save draft'  - validation error
Technical details

Python version: 3.6.1
Django version: 2.0.5
Wagtail version: 2.0.1
Browser version: Chrome/66.0.3359.117 on OS X 10.12.6

Sharing my workaround for use in templates, in case it's helpful to anyone else. There are some pages in our sites that rely on a check like
{% load wagtailcore_tags %}

{% if model.text_field %}

        {{ model.text_field|richtext }}

{% endif %}

For those sites I've written this simple filter as a workaround:
from django import template

register = template.Library()

@register.filter
def richtext_isempty(value):
    """
    Returns True if a value is an empty string, none, or a string containing
    nothing but paragraph tags
    """

    return any([
        value is None,
        value == '',
        value == '

',
    ])

Which can be used like:
{% load wagtailcore_tags my_tags %}

{% if not model.text_field|richtext_isempty %}

        {{ model.text_field|richtext }}

{% endif %}

Wagtaildraftail defined empty_values on the TextField directly (see definition and json values) which I know was working for field validation but I don't think it would solve the templating issue. But this was before the whole converter things so I'm not even sure it would still work.

@harrislapiroff Thanks so much for the suggested workaround!
If anyone else stumbles upon this, I had to make one tweak in the filter code. The value that gets passed in is a wagtail.core.rich_text.RichText object. I had to access its source property to look for the empty paragraph string:
 return any([
     value is None,
     value == '',
-    value == '

',
+    value.source == '

',
    ])

Unsure if that also needs to be added to the line testing against the empty string or not, but this change worked for me.

Addendum: I didn't make it clear that I needed to make that tweak in order to test the value of a RichTextBlock (not a RichTextField). The valuethat gets passed in if your template usage is a simple{% if block|richtext_isempty %}is awagtail.core.rich_text.RichTextobject, so accessing itssource` property is necessary to look for the empty paragraph string.
Alternatively, you could use Harris's filter as-is and pass block.source to the filter, i.e., {% block.source|richtext_isempty %}`.

Hi everyone, this issue is available?

I am unable to reproduce this bug use using the steps described above. I had older projects that were impacted, but after updating them, it appears validation errors are raised as expected. Can this issue be closed?
Technical details
Python version: 3.8.3
Django version: 3.2.4
Wagtail version: 2.13.1
Browser version: Chrome/91.0.4472.77 on Mac OS

Thanks @cspollar! Yep, looks like this has indeed been fixed - not sure exactly when, but it looks like the relevant bit of activation in Draftail (i.e. the bit that normalises a single empty paragraph to null) now happens on page load rather than on focus.


Error in installing Plugin 'file:///home/gmarik/path/to/plugin'

The following plugin is given in the instructions in the README:
Plugin 'file:///home/gmarik/path/to/plugin'

However, when I follow the instructions to install Vundle and execute the command inside vim:
:PluginInstall

Vundle gives an error in installing it. By the looks of it, it should be a URL pointing to a custom plugin on the user's computer and therefore that line should be commented out. Any ideas?

Seems an example of an installation of a custom plugin. Removing that line should be enough.

Right, I found it from the README of this repo. Should we remove it and submit a pull request ?

我也被坑了


FF-2465 adds "environment" and "allocation.name" to details

FF-2465
Motivation and Context
This change was motivated by internal feedback.
Description
Adds environment and assignments[].name to the new "assignment details" functionality.
How has this been tested?
unit tests

I verified locally that the test data passes with this change.


chit: upgrade cargo fetcher and cargoSha256

Infra upgrade as part of #79975; no functional change expected.

@grahamcofborg build chit


List nested options chain missing requirements error

pydantic.error_wrappers.ValidationError: 1 validation error for NestedOptionChain
put-streamer-symbol
field required (type=value_error.missing)
This was working yesterday but now for any ticker I am receiving the above error, seems put-streamer-symbol is the issue, was this because it used to return "put_streamer_symbol" and now the dashes might be causing an issue?
Can you see if you can replicate?
Thank you

I see your _dasherize function is used to handle this case but I am not sure if it is either working properly or if it is something else altogether.

Hi, can you post the code that's not working for you and the symbol that you're fetching the chain for? Thank!


BFT Block Puller: isolate common subcomponents

Change-Id: I274d8883add91fac08da5202199d1bac53e99adb
Type of change

New feature

Description

Isolate subcomponents from the CFT Deliverer that can be used in the BFT Deliverer
A skeleton of the BFT Deliverer (no censurship monitor, no tests)

Related issues
#4293

why is this in internal though? This can be useful for other projects.

why is this in internal though? This can be useful for other projects.

Correct. The plan is to put the reusable components in common/deliver.


add tls_inspector for virtual inbound listener

fix https://github.com/istio/istio/issues/20039
add TLS inspector is HTTP inspector is used.

@yxue: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
2bffedcd6d5e59ea1a0ce3d733ef63b3a6f19054
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix mem usage % in Kubernetes nodes dashboard

What does this PR do?
Fixes the "Memory utilization % per node" and "Memory utilization per node" widgets in the "Kubernetes Nodes Overview" dashboard.
Those widgets were using the metric kubernetes.memory.usage_pct to calculate the mem utilization % of a node. The formula was: avg:kubernetes.memory.usage_pct{$cluster,$host} by {host}*100. That's not correct because memory_usage_pct is calculated dividing the mem a pod is using by its memory limits. The memory limits are different for every pod, so we can't just average them.
This PR changes the formula and uses system.mem.pct_usable instead.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

I just realized that this fix is not correct. Please don't merge.


NoSuchMethodError: The getter 'address' was called on null.

add a route to accept json, but some how ive sent in via postman as a invalid json and im getting this infinite loop after that:
[SEVERE] angel: Unexpected character
FormatException: Unexpected character (at line 3, character 1)
}
^

dart:isolate  _RawReceivePortImpl._handleMessage

[SEVERE] angel: NoSuchMethodError: The getter 'address' was called on null.
Receiver: null
Tried calling: address
NoSuchMethodError: The getter 'address' was called on null.
Receiver: null
Tried calling: address
dart:core                                               Object.noSuchMethod
package:angel_framework/src/http/angel_http.dart 23:40  AngelHttp.uri
package:angel_framework/src/core/driver.dart 212:62     Driver.handleRawRequest.<fn>.<fn>.<fn>.<fn>

[SEVERE] angel: NoSuchMethodError: The getter 'address' was called on null.
Receiver: null
Tried calling: address
NoSuchMethodError: The getter 'address' was called on null.
Receiver: null
Tried calling: address
dart:core                                               Object.noSuchMethod
package:angel_framework/src/http/angel_http.dart 23:40  AngelHttp.uri
package:angel_framework/src/core/driver.dart 212:62     Driver.handleRawRequest.<fn>.<fn>.<fn>.<fn>
[SEVERE] angel: NoSuchMethodError: The getter 'addre....(repeats )

my code:
app.group('/api/v1/', (Router router) {
    router
      ..get('/xxx/', (req, rep) async {
      app.logger.fine("uri? ${req.path}");
       req.parseBody();//this causes error, then infinite loop...
     }

});

sample json sent in as json body (ending comma)
{
	"order_id": "sss",
}

Seems like you haven't called AngelHttp.startServer. Until you call this, calling AngelHttp.uri will throw. That's the error here.

hI @thosakwe yes i did, was using hot reload
ar hot = new HotReloader(createServer, [
    new Directory('lib'),
    new Directory('bin'),
    new Directory('config'),
    'bin/dev.dart',
    Uri.parse('package:angel_hot/angel_hot.dart')
  ]);

  await hot.startServer('localhost', 3060);


Strange dragging.

Strange dragging. See my video.
2023-10-31 22-12-28.zip

I'm wondering if this may be related to the other issue on the camera targeter you mentioned? I'll try this once that is fixed.
Also, this is unrelated to this issue, but Godot 4.2 has a bug where sometimes node paths get unset, which is why your minimap isn't working. Could you set this property:

After that your minimap should look like this:

Ok this is happening because your CameraArea is updating the camera on _process. Everything that updates the camera needs to do so on the physics update. Adding that to the fixes

Please, let me know if I need to test anything again. Thanks a lot for fixing!


Support "+" character in file paths

Addresses #587 Preserve "+" in file paths.

Thank you @petethomas :)


Use CachedMemory in bulk-ops executors

Locally this yielded a performance improvement for our bulk-ops benchmark test case by roughly 3.5%.
The local test uses memory.copy and memory.fill with 5000 bytes per operation.
Note that performance wins for bulk-ops with smaller lengths are going to be way more significant.

Unfortunately, despite the triviality of the changes introduced by this PR local benchmarks indicate extreme performance regressions of 15-20% across the board. Probably the Rust/LLVM optimization heuristics for optimizing the loop+match construct in the interpreter's hot path got confused by this ... again.

https://github.com/wasmi-labs/wasmi/pull/1075/commits/afc3c5f82630346c9845a1cb8667fb580c684d00 helped to eliminate all locally observed performance regressions.


chore(release): 2.35.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: b2f8253007b1923909d179bb0352ccbbcba779ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Responsive Profile Page

Fixes #2465
Closes #2465
Changes proposed

Made profile page mobile responsive (especially 320px screens)

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

it's causing the profile icons to be centered on a desktop screen too
how it's supposed to be:
after this change:

I'll check that now @Aadarsh805

Yep it's all good now, good work  👍

Thanks man!

Thank you +1
I don't think package-lock.json are needed. Could you also make other changes for example to Event.js in another PR, this PR should focus on the profile

Actually after npm install package-lock.json was modified didn't wanna edit .gitignore so i rather left it. Anyways what updates would you like to see in the Event.js .

Actually after npm install package-lock.json was modified didn't wanna edit .gitignore so i rather left it

It is better to use npm ci so the lock file is not modified without changes to package.json file. It correct that we should  not ignore this file - maybe we need to improve the docs?

what updates would you like to see in the Event.js
I was suggesting the changes you made to the events file should be in another PR as I don't think they are related to the issue this PR is solving?

Actually after npm install package-lock.json was modified didn't wanna edit .gitignore so i rather left it

It is better to use npm ci so the lock file is not modified without changes to package.json file. It correct that we should not ignore this file - maybe we need to improve the docs?

what updates would you like to see in the Event.js

I was suggesting the changes you made to the events file should be in another PR as I don't think they are related to the issue this PR is solving?

Okay the Event.js was pull was merged already so i think i'll have to make a new pull use npm ci like you said then add these changes again , I guess that will do

Oh if the events.js was already merged, then you can update your current PR and these will disappear - it means this PR includes the other changes probably because you branched from a previous PR and not the main branch
You can revert your changes to the lock file, but also if easier you can create a new PR but the discussion/collaboration will be lost

Oh if the events.js was already merged, then you can update your current PR and these will disappear - it means this PR includes the other changes probably because you branched from a previous PR and not the main branch
You can revert your changes to the lock file, but also if easier you can create a new PR but the discussion/collaboration will be lost

I'm make a new PR and do it all over again , don't worry.

Ok, please reference this PR in the new PR, so it is all traceable


tight_layout vertically compresses PSD plots

The extension of spatial colors from Raw to Epochs in #6451 has revealed a bug with the use of tight_layout.
https://github.com/mne-tools/mne-python/blob/cc836c2635b7a720ec6c60074a1997fe52d7ca2f/mne/viz/utils.py#L3064-L3066
Tight layout often (but not always!) vertically compresses the PSD plots when spatial_colors are used with Epochs. I thought at first this had something to do with the changes in #6451, but it turns out to have always been there. It just wasn't apparent before because it only happens when the channels are relatively flat and uniform - which can sometimes happen with the multitaper psd method used by method Epochs.plot_psd, and also because because tight_layout was never used in the average=True case, which up until #6451 was the only option available for Epochs.plot_psd.
You can test that this is the case by taking the latest stable release and producing a vertically compressed PSD plot even for Raw.plot_psd, but setting the n_fft variable to an extremely low value - thus simulating the very broad window used in Epochs with multitaper fft, and the resultant flat, uniform PSDs.
What would then be the sensible thing to do here? Is simply removing the call to tight_layout an option? It was after all never used for average=True, and that seems fine?

please share a tiny script to replicate and share a picture of what looks
wrong. thx

For some reason, I cannot replicate the bug with the sample data, but here are some pictures of some Raw data from our lab, with a Magnes 3600 248 magnetometer system.
First, normal:
raw.plot_psd()

Now, compressed.
raw.plot_psd(n_fft=50)

I don't know if it's clear from the picture above, but the axis is significantly shorter than the figure.
Switching to development version, and Epochs.plot_psd(average=False), it can in some cases be really severe.

As I mentioned above, it's somehow fine for the sample/audvis...
path =  mne.datasets.sample.data_path()
raw = mne.io.Raw(path + '/MEG/sample/sample_audvis_raw.fif')
picks = mne.pick_types(raw.info,meg="mag")
raw.plot_psd(picks=picks,n_fft=50)

Not sure what to make of that...

In any case, removing tight_layout fixes all these problems, though I don't know whether that breaks something somewhere else.

tight_layout problems are usually indicative that something wrong is being done in the plot. Or possible there is some mpl bug. I don't want to get rid of it because in general it makes things cleaner.
Can you see if subplots_adjust works better for your data and still works for sample?

It looks good on my data, but with multiple channel type psd display for the sample data the subplot titles overlap onto the x-axis labels of the image above them, unless you increase the size of the figure.

subplots_adjust has some parameters you can probably tweak to get both to look good. Did you try? Probably hspace is what you'd need here

I did try several values between 0.1 and 0.4 and didn't have any luck, but I'll experiment a bit more with it tomorrow.

hspace=0.5 appears to do it.

+1 for PR to change it. In your PR, can you make some minor change to an example that uses raw.plot_psd (and/or epochs.plot_psd)? It will cause CircleCI to render it for us so we can easily see the output


Refactor generaterequest to not throw undefined errors

Requests are now waiting for this.params instead, to make sure the observer triggered first.
Also moved the Firebase request to rite-app to make sure you do not log in when browsing the home-page.
Fixes #183

Confirmed working!


Filter by cell not working

I have columns array:
  const columns = useMemo(
    () => [
      {
        Header: 'User',
        sortType: 'basic',
        accessor: row => row,
        Cell: ({ row }) => (

            {row.original.user.name}

        ),
      },
      {
        Header: 'Description',
        accessor: 'description',
        sortType: 'basic',
        Cell: ({ cell: { value } }) => shortText(value),
      },
      {
        Header: 'Created',
        accessor: 'createdAt',
        sortType: 'basic',
        Cell: ({ cell: { value } }) =>
          moment(value).format('DD-MM-YYYY HH:mm'),
      },
    ],
    [],
  )

Filter not working for User and Created column. In table I change data by Cell function and changing data is render inside table, but filterGobal method filtering by data. E.g: inside table I have fromat data: 11-11-2021 15-45, but in data (from backend) I have "2021-11-11T15:44:44.787Z"
I thing I have this same problem with User column. In table I have only image and name user. But in data I have object:
user: {
   id: 1,
   name: "Jack",
   age: 18,
}

Resolve: React table can't filtering when change data by 'Cell' option


aks addon list failed

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks addon list
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 556, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/__init__.py", line 515, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 313, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/commands.py", line 104, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 125, in arguments_loader
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 59, in get_op_handler
  File "importlib\__init__.py", line 127, in import_module
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Users\cnguyen\.azure\cliextensions\aks-preview\azext_aks_preview\custom.py", line 105, in <module>
    from ._helpers import (
  File "C:\Users\cnguyen\.azure\cliextensions\aks-preview\azext_aks_preview\_helpers.py", line 7, in <module>
    from azure.cli.command_modules.acs._helpers import map_azure_error_to_cli_error
ImportError: cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks addon list --name {} --resource-group {} -o {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.34.1 *

Extensions:
account 0.2.2
aks-preview 0.5.70

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

@congdnguyen Thank you for reaching out to us, can you please upgrade to latest version of azure cli 2.43.0 and retry? also consider upgrading you python


[spaceship] replace post_for_testflight_review with new public API

Fixes #13903
Description
The private API used in Spaceship::TestFlight's post_for_testflight_review was taken down by Apple and replaced with the new public official App Store Connect API. This PR is a fix for that.
Thing to note

This current solution is probably NOT a permanent one (the way that it is currently implemented)
This needed to get fixed and this works 😊
I put this in its own new Spaceship::API module so that it was easy to replace later on
I replaced the internals of Spacehip::TestFlight::Build to use the new Spaceship::API implementation so that there were less changes in the PR and that we can just get things working again

I believe this fix warrants the second half of this comment, do any maintainers agree?

I restored the branch so that the instructions in https://github.com/fastlane/fastlane/issues/13903#issuecomment-447535838 still work for now until this is released.


Windows 10 1809 Buffer issues with VSCode (windows ver)

After upgrading to W10 1809, I'm having issues running VSCode (the windows version) from the WSL terminal via code commands.
I reported the issue here: https://github.com/Microsoft/vscode/issues/63539 & https://github.com/Microsoft/console/issues/333
However after some additional testing, I've discovered it might be a issue with WSL instead of vscode.

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.18305.1003]

Copying from the other issue
Seems there might be some weird issue with the shell or something with the stdout buffer in the current version of wsl or ELECTRON_RUN_AS_NODE.
Note: I run this under a fresh install of Windows 10 1809 in a VM and a fresh install of WSL Ubuntu, and the VSCode x64 User Installer.
I ran vscode --version in the Ubuntu app shell and got this output with weird spacing:
$ code --version
1.30.1
      dea8705087adb1b5e5ae1d9123278e178656186a
                                              x64

Then I tried again with a cat to buffer the output, and it printed out fine:
$ code --version | cat
1.30.1
dea8705087adb1b5e5ae1d9123278e178656186a
x64

In the case where I opened the issue, I was running the shell via SSH and using a local ssh terminal emulator (SecureCrt):
$ code --version
--- NO OUTPUT ---

However if I use cat as I did above, it works just fine:
code --version | cat -
1.30.1
dea8705087adb1b5e5ae1d9123278e178656186a
x64

This also solves the issue where I don't regain control of the terminal when I run code ., if I pipe it through code . | cat -, it works perfectly like it used to.

Also Microsoft/vscode#62698.

@weikinhuang can you confirm that in v1803 it is working?

Also seeing this since the 1809 update — happy to provide any information / diagnostics as required.

@benhillis Can you please mark this as a bug.

I have a very similar issue. I have been following this thread and checking it every single day.
From what I have observed, if you have VSCode app already running, calling code . from wsl will return immediately.

Still seeing this in 1809. Has any progress been made? I've been holding onto 1803 for as long as I could but I was forcefully upgraded to 1809 yesterday so need to find a solution to this.

@robhawkes I'm assuming since the announcement of WSL2, this project is probably abandoned and everything in it will be closed.


AddonCollection: .addons should not be exposed, do .getAddons()

done in https://github.com/Stremio/stremio-addon-client/commit/b12e4c2cde544e82d0046a90baad991ec7681a6f


compile sdk version 31 and kotlin version update

Please approve this commit. I have fixed the specific code as the application compilation was failing.

@pinkfish - :)

Hi @iamzeeshanali. This package has not been updated for more than 18 months and the author is not responding to issues or pull requests.
Consider switching to flutter_timezone which is a fork of this repo.


Extract k8s package out of cilium-cli into pkg/common/k8s

This will allow us to re-use the same high-level k8s client in Hubble and replace the current kubectl-based port-forwarding commands with a native implementation (https://github.com/cilium/cilium/issues/34935, discussed in https://github.com/cilium/cilium/pull/35353).
I chose an arbitrary location but feel free to propose a different one and/or a package rename.
Also please take a look at the costs I extracted from the cilium-cli defaults. I left a TODO for us to discuss if we should move these to the global cilium defaults instead.

One suggestion of where to put the common library might be under pkg/k8s/common?

One suggestion of where to put the common library might be under pkg/k8s/common? Thus keeping all the k8s related code in one place?

That's fair. My first inclination was to put it under pkg/k8s but I wasn't sure how exactly, especially without clashing with the existing client generated package. I also fear pkg/k8s/common/k8s would be confusing ?
Any suggestion on a path/package rename ?

I also fear pkg/k8s/common/k8s would be confusing ?
yeah that would be a bit redundant.

One thing I'm wondering is the code in this library is that this code isn't supposed to be a general k8s client library used by the agent daemon, but rather is more specific to things like cilium/hubble cli.
Maybe k8s is just not a good package name for this anymore following the cli being moved to cilium/cilium?
Anyway I don't feel that strongly about this, so I'll approve for sig-k8s. Maybe one of the other reviewers will have some thoughts.

I also fear pkg/k8s/common/k8s would be confusing ?

yeah that would be a bit redundant.
One thing I'm wondering is the code in this library is that this code isn't supposed to be a general k8s client library used by the agent daemon, but rather is more specific to things like cilium/hubble cli.
Maybe k8s is just not a good package name for this anymore following the cli being moved to cilium/cilium?
Anyway I don't feel that strongly about this, so I'll approve for sig-k8s. Maybe one of the other reviewers will have some thoughts.

I agree that this package is more a high-level k8s-related helper client and therefore k8s is probably not the best name.
On the other hand, the refactor following a package rename will be much larger.
If someone else can propose a better alternative, I'd be happy to make the change. Otherwise we could wing it for now and revisit later if desired.

Seems reasonable. One alternative name could be pkg/cli (for packages used by the CLIs) since pkg/common seems a bit overly generic

I like it. Let me update the PR to reflect the change to use: pkg/cli/k8s as the new location.

I'm not completely convinced yet. The cilium-cli client still is pretty well coupled to cilium-cli --

no API stability guarantees
embedded names, e.g. FieldManager in ApplyGeneric
a separate Helm driver

Plus it's all a bit heavyweight.
If the goal is a functional port-forwarding implementation, then let's extract that, and have it take a k8s.ClientSet instead.

Closing in favour of introducing a new PortForwarder type that takes in a Kubernetes clientset.
Will update the linked PR shortly.


Syntax highlighting for code blocks in UI and option to keep history

Hi! First of all, a sincere thanks for building this plugin. I have been enjoying it for the past few days and would love to continue using and refining it. I had a couple of questions regarding the UI regarding some potential bugs/configuration issues, as well as some improvements.
First, my NeoAI UI does not highlight syntax as shown in the demos, and I was wondering if there was anything in particular I need to download to enable it (or just do I just need to enable LSP syntax highlighting in markdown?)
For example:

Second, I find myself frequently hiding and unhiding the NeoAI console since I often use splits and it obscures my code at times. However, this resets the context/erases the prior history when I toggle it off and on. Is it possible to keep add an option to keep NeoAI from erasing the history?

The syntax highlighting is easy to do with neovim 0.9 (I needed to upgrade), by using the treesitter API to register `neoai-output` with the markdown language parser.
This is what I added to do this:
vim.treesitter.language.register('markdown', 'neoai-output')

I also set vim.o.conceallevel = 1 so the backticks are invisible in the markdown response from gpt-3.5.


For uwp the ARM architecture needs to be in lower case

see   for details

Cherry picked into 3.0.3


some files are not full download

first of all i like the app verry verry much i try to download my course is about 5.10 gb the course was full download but the last some files like 30-40 videos are not proper download the files is only 1kb and not play but small courses like 200-300 mb is full and complete download but like 4-5 gb course is not download proper plzz plzz fix it love you bhai

Hello @Tanishqkat
I am glad you liked the app.
The issue you mentioned has been reported before and I am working on it. I will publish a new release in couple of days which will include some bug fixes related to downloading courses and that should improve the download stability.


Don't throw away query params when authenticating

We use some magic query params like assigned and milestone, but whenever we redirect someone to /auth/github for OAuth authentication we lose that state.
There's probably a couple of ways to do this:

Append the query params to the /auth/github redirect.

I'm not sure that GitHub won't just throw these away when redirecting with the OAuth code.

Store the query params in a JSON encoded blog in the state query param.

This probably isn't that great, because the state param is usually used for CSRF protection

Store the state in a cookie an HTTP, Secure cookie with a short timeout.

We can probably only choose to read this if we're redirecting from a successful authentication

Storing the URL in a session value and deleting it when authentication completes was the winning combo.

Fixed by #73


Add OLC Strikes to KP command

This adds the OLC strikes to the /kp command by updating the gamedata.json file.
The three achievements for OLC included are:

Old Lion's Court, Achievement ID: 6797
Old Lion's Court CM, Achievement ID: 6804
Old Lion's Court: Fear Not This Knight, Achievement ID: 6778

Link to the GW2 API with the achievement IDs: https://api.guildwars2.com/v2/achievements?ids=6797,6804,6778

Really sorry for taking this long!


Do not vendor tests in the wheel published to PyPI

When we tried out mpire for the first time, our application failed to import. After a fair amount of debugging, we realized that this is because the tests/ direction is not being properly excluded from the built wheel. It's okay to have this in the sdist if you like, as sometimes downstream distributors like to have unit tests in the source distribution.
The problem is that we get a ModuleNotFoundError when we try to import our own tests folder in our local directory (our own unit tests) because it is shadowed by the tests that is installed by the mpire wheel.
You can confirm this problem by downloading and unzipping the wheel here:

https://pypi.org/project/mpire/2.8.0/#files

You will see that there is a tests package in the wheel. This is almost certainly not what you to do as it will install this tests package into every user of mpire.

You probably want to modify this line:
https://github.com/sybrenjansen/mpire/blob/17d1897e17c272b615f6c39a818ca73c7cc94b92/setup.py#L18
To something like:

https://stackoverflow.com/a/61274968/

Good point. Thnx for raising the issue and providing a solution as well.
I made a PR to resolve this. I will release it shortly


metadata upload issue

it would be nice, if lighthouse cli users could upload additional nft pics and metadata from the same collection many times after first try. When i read medium tutorial first time, i thought its possible by default, but its not. If you create additional nft pics and related json files and try to continue uploading, it returns another token uri then the first time, even if it asks me to "use cache file from previous content".
2nd Q: can you do another contract, so users can execute "mint_native" with extra "image_url" field for nft token? it would be really nice ^_^ ( sometime you need custom pictures to mint)

lfg

it would be nice, if lighthouse cli users could upload additional nft pics and metadata from the same collection many times after first try. When i read medium tutorial first time, i thought its possible by default, but its not. If you create additional nft pics and related json files and try to continue uploading, it returns another token uri then the first time, even if it asks me to "use cache file from previous content". 2nd Q: can you do another contract, so users can execute "mint_native" with extra "image_url" field for nft token? it would be really nice ^_^ ( sometime you need custom pictures to mint)

update the metadata url for the collection doesn't fix your problem?


Error loading: myorgid-simple-panel

I read the grafana documentation and starting with this example and then working my way towards integrating the funnel part but I can't seem to get it working。I restarted the Server when I tried opening this Panel I got an error saying Error loading: myorgid-simple-panel.My grafana version is 6.4.4, node.js version is 12.13.1;How to solve this?

My development environment is Windows x64

Hello,Try npm install before yarn build

I have the same error.
This is what I found in the browser console:
backend.js:6 Error loading panel plugin: myorgid-simple-panel TypeError: r.PanelPlugin is not a constructor
    at Module.eval (module.js:1)
    at n (module.js:1)
    at eval (module.js:1)
    at eval (module.js:1)
    at i (system.js:4)
    at system.js:4
    at system.js:4
    at O (system.js:4)
    at k (system.js:4)
    at system.js:4

Ok, I think you have a problem because you don't have the latest version.
Therefore git pull and try again

Ok, I think you have a problem because you don't have the latest version.
Therefore git pull and try again

Hi Samuel,
I've pulled the latest version and it's still not working.
Still the same Grafana error, and the same console error.
Have you tried building and running it on Grafana?

Yes but I'm on Linux.
You have the same mistake here: https://github.com/grafana/grafana/issues/20338
And the last simple-react-panel pull repair that: https://github.com/grafana/simple-react-panel/commit/ca7f48c685aa94c40eeabf63efbdf5eebe6baa14 (in src/SimplePanel.tsx and src/SimpleEditor.tsx)
Did you install Grafana from the sources?

Yes but I'm on Linux.
You have the same mistake here: grafana/grafana#20338
And the last simple-react-panel pull repair that: ca7f48c (in src/SimplePanel.tsx and src/SimpleEditor.tsx)
Did you install Grafana from the sources?

I'm on the MacOS.
All my files look exactly like how it is in that repair. The "fixes" that the person in the thread you posted were already implemented by me in my files
I installed Grafana through homebrew.

I just got it working. PanelPlugin should be imported from @grafana/ui and not @grafana/data
My old module.ts looked like
import { PanelPlugin } from '@grafana/data';
import { SimpleOptions, defaults } from './types';
import { SimplePanel } from './SimplePanel';
import { SimpleEditor } from './SimpleEditor';

export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setDefaults(defaults).setEditor(SimpleEditor);

My new module.ts looks the same, but with the first line replaced to
import { PanelPlugin } from '@grafana/ui'

I just got it working. PanelPlugin should be imported from @grafana/ui and not @grafana/data
My old module.ts looked like
import { PanelPlugin } from '@grafana/data';
import { SimpleOptions, defaults } from './types';
import { SimplePanel } from './SimplePanel';
import { SimpleEditor } from './SimpleEditor';

export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setDefaults(defaults).setEditor(SimpleEditor);

My new module.ts looks the same, but with the first line replaced to
import { PanelPlugin } from '@grafana/ui'

I just got it working. PanelPlugin should be imported from @grafana/ui and not @grafana/data
My old module.ts looked like
import { PanelPlugin } from '@grafana/data';
import { SimpleOptions, defaults } from './types';
import { SimplePanel } from './SimplePanel';
import { SimpleEditor } from './SimpleEditor';

export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setDefaults(defaults).setEditor(SimpleEditor);

My new module.ts looks the same, but with the first line replaced to
import { PanelPlugin } from '@grafana/ui'

Module '"../node_modules/@grafana/ui"' has no exported member 'PanelPlugin'.
??

I just got it working. PanelPlugin should be imported from @grafana/ui and not @grafana/data
My old module.ts looked like
import { PanelPlugin } from '@grafana/data';
import { SimpleOptions, defaults } from './types';
import { SimplePanel } from './SimplePanel';
import { SimpleEditor } from './SimpleEditor';

export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setDefaults(defaults).setEditor(SimpleEditor);

My new module.ts looks the same, but with the first line replaced to
import { PanelPlugin } from '@grafana/ui'

I modified the mudule.ts according to your way,it still not working, I input 'yarn dev',got an error "/@grafana/ui"' has no exported member 'PanelPlugin'."

Sorry guys. I forgot to share my full module.ts file.
You need to add // @ts-ignore on the first line of your module.ts file.
So the final version looks like:
// @ts-ignore
import { PanelPlugin } from '@grafana/ui';
import { SimpleOptions, defaults } from './types';
import { SimplePanel } from './SimplePanel';
import { SimpleEditor } from './SimpleEditor';

export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setDefaults(defaults).setEditor(SimpleEditor);

That should solve your problem.
Don't ask me why that works though.

I also can't get this to work.
The plugin shows up in the panel list by clicking on it gives the error loading: myorgid-simple-pane
the console complains:
keybindingSrv.ts:20 Error loading panel plugin: myorygid-simple-panel SyntaxError: Unexpected token '<'
    at eval (<anonymous>)
    at st (system.js:4)
    at system.js:4
    at system.js:4
    at O (system.js:4)
    at k (system.js:4)
    at system.js:4

i solved the problem by upgrading grafana to 6.5.x .

In any case, there is a lot of mismatches between alpha plugins (i.e. piechart alpha panel) in Grafana core and this template. I think it would be reviewed and to propose an unified usage of @grafana libraries.

if this still exists... post again -- my guess is the plugin was not built


add computedStyle()

Vizzu.style should return only the user-set styles, and there should be another function computedStyle() which returns all the styles regardless of being set or not by the user.

implemented in #143


2448 X 3264 add image problem

2448 X 3264 add image not being saved in pdf with correct orientation.  I tried alll possible ways. .
Below is the code which i am attempting
var pdf = new jsPDF();
var img = document.getElementById('blah');
var left = 15, top = 40;
var imgData = $('#blah').attr('src');
        var width = pdf.internal.pageSize.getWidth();
        var maxWidth = (width - left * 2);
        var newWidth = img.naturalWidth < maxWidth ? img.naturalWidth : maxWidth;
        var newHeight = img.naturalHeight * newWidth / img.naturalWidth;

        var left = 15, top = 40;
        var pdf = new jsPDF('p', 'px', [img.naturalHeight + top * 2, img.naturalWidth + left * 2]);

        pdf.setFontSize(40);
        pdf.text(35, 25, "Octonyan loves jsPDF");
        pdf.addImage(imgData, 'JPEG', left, top, img.naturalWidth, img.naturalHeight);
        pdf.save();

Please find below image which I am using -

PDF File

When I am using addimage function with 2448 * 3264 dimensions of JPEG image, its getting rotated 270 degree clockwise automatically. Could you please help me why its getting rotated.

Seems to be a bug... I will investigate this when I find the time.

No, this is not a bug of JsPDF. The image itself is rotated 90 degree. You should check the image exif data, not simply relying on the file property from Windows, which automatically rotate the image for you. Check this URL out.

This is more like a Stack Overflow question instead of a GitHub issue to me.


Create Group Page

On the group page:

Layout is almost the same as the homepage
Suggest button on top-right corner

pop-up window to fill in details of event

This page should be groups/show.html.erb


Add post to contract view

Pull Request Test Coverage Report for Build 219

65 of 65 (100.0%)  changed or added relevant lines in 5 files are covered.
22 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.07%) to 95.854%

Files with Coverage Reduction
New Missed Lines
%

openregistry/lots/loki/tests/base.py
1
100.0%

openregistry/lots/loki/models.py
1
97.79%

openregistry/lots/loki/tests/blanks/auction_blanks.py
20
100.0%

Totals

Change from base Build 216:
0.07%

Covered Lines:
2936

Relevant Lines:
3063

💛  - Coveralls

Pull Request Test Coverage Report for Build 219

65 of 65 (100.0%)  changed or added relevant lines in 5 files are covered.
22 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.07%) to 95.854%

Files with Coverage Reduction
New Missed Lines
%

openregistry/lots/loki/tests/base.py
1
100.0%

openregistry/lots/loki/models.py
1
97.79%

openregistry/lots/loki/tests/blanks/auction_blanks.py
20
100.0%

Totals

Change from base Build 216:
0.07%

Covered Lines:
2936

Relevant Lines:
3063

💛  - Coveralls


Allow couchers images in markdown and add image upload

Closes #1590

Frontend checklist

[ ] Formatted my code with yarn format && yarn lint --fix
[ ] There are no warnings from yarn lint
[ ] There are no console warnings when running the app
[ ] Added any new components to storybook
[ ] Added tests where relevant
[ ] All tests pass
[ ] Clicked around my changes running locally and it works
[ ] Checked Desktop, Mobile and Tablet screen sizes

local media server has cors errors, so have to test on ci


Conv2D name usage confusion

In the function def of Conv2d, there is no name field:
https://github.com/ppwwyyxx/tensorpack/blob/a5dc2dd807aa4ab6df50b73469d68bd167ff7d50/tensorpack/models/conv2d.py#L23-L38
but in example, the first argument is assigned with a string of name:
https://github.com/ppwwyyxx/tensorpack/blob/a5dc2dd807aa4ab6df50b73469d68bd167ff7d50/examples/ShuffleNet/shufflenet.py#L73-L77
my IDE indicates that's an error, although it runs properly, but not clear about this, could you pls explain a bit?

See https://github.com/ppwwyyxx/tensorpack/blob/0ffdcc44a9288057be69ef9328a16dcc9526fa69/tensorpack/models/registry.py#L77-L101
The function wrapper adds this argument. This has some other subtle side effects like error messages like:

function expects 5 arguments, but 5 are given

which happens if you forget the name. This basically means:

function expects 6 arguments, but 5 are given

Please point people first to docs, not code.
There is a name argument in docs: http://tensorpack.readthedocs.io/en/latest/modules/models.html?highlight=conv2d#tensorpack.models.Conv2D
So there should be no confusion.

@PatWie @ppwwyyxx , thank you both. but showing code is also more precise, and help us learning programming skills


Multiple tile stitching

If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #351 and closes #332.
Also closes #357 (changing the name of the stitch_images folder to include the run name).
How did you implement your changes
Made the adjustments outline in the design doc. Also increased the testing to include multiple tiles in the same run.
Note: Pandas is pinned <2.0 temporarily so the build doesn't fail. Permanent fix is addressed in #358.
Remaining issues

[x]  increase testing even more
[x]  test on run file
[x]  tackle #357

Did you test this on the various likely permutations? Multiple tiles with a non-tiled region, multiple tiles without a non-tiled region, a single tile with a non-tiled region, etc etc.

I had the tests always including a non-tiled fov, so I just added a param to check for it without as well. Also got a multiple tiled run file from Christine and was able to check the notebook logic for the different possibilities and it all seems to be working!


Unable to run S3 transfer task successfully

Hi, I used to use data transfer hub to transfer S3 data from us-east-2 to cn-northwest-1. But recently I was not able to run the task successfully. I cannot see any error message regarding why the task failed. Do you have any suggestion on how to diagnose it?
Thanks

Hi @victorconan, what's the version of Data Transfer Hub and your failed DTH S3 plugin?
You can check the earliest error message in CloudFormation console Event page.

Hi @victorconan, what's the version of Data Transfer Hub and your failed DTH S3 plugin?
You can check the earliest error message in CloudFormation console Event page.
This is the version of DTH:

(SO8001) - Data Transfer Hub with aws-solutions-constructs: This template deploys an one-stop toolset for transferring data from different sources into AWS. Template version v2.0.4

Thanks!

@victorconan , v2.0.4 uses the python 3.6 so it can not be deployed anymore.
And I noticed that you are having problems during upgrading: https://github.com/awslabs/data-transfer-hub/issues/89.
There are two workaround:

Delete the old Data Transfer Hub and deploy the latest version.

Manually update the python version of your current Data Transfer Hub(v2.0.4), then upgrade to the latest version of Data Transfer Hub

Go to the AWS CloudFormation Console
Click your Data Transfer Hub main stack
Click Template tab
Click View in Designer button
Search for python3.6 in the template box at the bottom of the screen, and replace it with python3.9

Click "Create Stack" icon in the upper left of the screen

Click Next, Next, Create
Then follow the guide to upgrade to the latest version.

@victorconan , v2.0.4 uses the python 3.6 so it can not be deployed anymore.
And I noticed that you are having problems during upgrading: #89.
There are two workaround:

Delete the old Data Transfer Hub and deploy the latest version.

Manually update the python version of your current Data Transfer Hub(v2.0.4), then upgrade to the latest version of Data Transfer Hub

Go to the AWS CloudFormation Console
Click your Data Transfer Hub main stack
Click Template tab
Click View in Designer button
Search for python3.6 in the template box at the bottom of the screen, and replace it with python3.9

Click "Create Stack" icon in the upper left of the screen

Click Next, Next, Create
Then follow the guide to upgrade to the latest version.

Thanks! It works now!


camel-k doesn't create a service

Hi, after some playing around I have found out that camel-k doesn't create service on very simple use-case .. However I can create the service object manually but this suppose to be done out-of-box by the operator..
This is happening on company's k8s v1.18 cluster and I believe that it's related to some permissions but I'm unable to find any error, any relevant log or record. Any idea or tip what should I do here to find out what's going on?
Thanks,
-Alex
$ kamel version --operator
Camel K Operator 1.7.0
$ kamel version
Camel K Client 1.7.0
$ k describe it rest-dsl
Name:         rest-dsl
Namespace:    camel-system
Labels:       <none>
Annotations:  <none>
API Version:  camel.apache.org/v1
Kind:         Integration
Metadata:
  Creation Timestamp:  2021-12-02T21:41:20Z
  Generation:          1
  Managed Fields:
    API Version:  camel.apache.org/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:sources:
        f:traits:
          .:
          f:logging:
            .:
            f:configuration:
              .:
              f:enabled:
          f:service:
            .:
            f:configuration:
              .:
              f:auto:
              f:enabled:
              f:nodePort:
      f:status:
        .:
        f:capabilities:
        f:conditions:
        f:dependencies:
        f:digest:
        f:image:
        f:integrationKit:
          .:
          f:name:
          f:namespace:
        f:lastInitTimestamp:
        f:phase:
        f:platform:
        f:replicas:
        f:runtimeProvider:
        f:runtimeVersion:
        f:selector:
        f:version:
    Manager:         kamel
    Operation:       Update
    Time:            2021-12-02T21:41:59Z
  Resource Version:  42531004
  Self Link:         /apis/camel.apache.org/v1/namespaces/camel-system/integrations/rest-dsl
  UID:               bab51b6f-45b6-4c76-bc51-4ee2481b10cb
Spec:
  Sources:
    Content:
// camel-k: language=java trait=logging.enabled=true trait=service.enabled=true trait=service.auto=true trait=service.node-port=true
import org.apache.camel.CamelContext;
import org.apache.camel.Exchange;
import org.apache.camel.Processor;

public class RestDSL extends org.apache.camel.builder.RouteBuilder {
    @Override
    public void configure() throws Exception {
        rest()
            .get("/hello")
                .to("direct:hello");

        from("direct:hello")
            .setHeader(Exchange.CONTENT_TYPE, constant("text/plain"))
            .log("Hello World")
            .log(String.valueOf(simple("headers:${headers}")))
            .process(new Processor(){
                @Override
                public void process(Exchange exchange) throws Exception {
                    CamelContext ctx = exchange.getContext();
                    System.out.println("can be breakpoint on this line :" + ctx.getName());
                }
            })
            .transform().simple("Hello World");
    }
}

    Name:  RestDSL.java
  Traits:
    Logging:
      Configuration:
        Enabled:  true
    Service:
      Configuration:
        Auto:       true
        Enabled:    true
        Node Port:  true
Status:
  Capabilities:
    rest
  Conditions:
    First Truthy Time:     2021-12-02T21:41:20Z
    Last Transition Time:  2021-12-02T21:41:20Z
    Last Update Time:      2021-12-02T21:41:20Z
    Message:               camel-system/camel-k
    Reason:                IntegrationPlatformAvailable
    Status:                True
    Type:                  IntegrationPlatformAvailable
    First Truthy Time:     2021-12-02T21:41:49Z
    Last Transition Time:  2021-12-02T21:41:49Z
    Last Update Time:      2021-12-02T21:41:49Z
    Message:               kit-c6kjr0200nf56t743uqg
    Reason:                IntegrationKitAvailable
    Status:                True
    Type:                  IntegrationKitAvailable
    Last Transition Time:  2021-12-02T21:41:49Z
    Last Update Time:      2021-12-02T21:41:49Z
    Message:               different controller strategy used (deployment)
    Reason:                CronJobNotAvailableReason
    Status:                False
    Type:                  CronJobAvailable
    First Truthy Time:     2021-12-02T21:41:49Z
    Last Transition Time:  2021-12-02T21:41:49Z
    Last Update Time:      2021-12-02T21:41:49Z
    Message:               deployment name is rest-dsl
    Reason:                DeploymentAvailable
    Status:                True
    Type:                  DeploymentAvailable
    First Truthy Time:     2021-12-02T21:41:59Z
    Last Transition Time:  2021-12-02T21:41:59Z
    Last Update Time:      2021-12-02T21:41:59Z
    Message:               1/1 ready replicas
    Reason:                DeploymentReady
    Status:                True
    Type:                  Ready
  Dependencies:
    camel:direct
    mvn:org.apache.camel.k:camel-k-runtime
    mvn:org.apache.camel.quarkus:camel-quarkus-java-joor-dsl
    mvn:org.apache.camel.quarkus:camel-quarkus-platform-http
    mvn:org.apache.camel.quarkus:camel-quarkus-rest
  Digest:  vu01G5QnmdFAZbxtPCTMlU8BsfJDkuPXMjHdj1yaMSFw
  Image:   dockerhub/camel-k-kit-c6kjr0200nf56t743uqg@sha256:64c49fa077395c6519a6efbecba8b0913db31d29a2e69abc1b40ae7d9c357efb
  Integration Kit:
    Name:               kit-c6kjr0200nf56t743uqg
    Namespace:          camel-system
  Last Init Timestamp:  2021-12-02T21:41:20Z
  Phase:                Running
  Platform:             camel-k
  Replicas:             1
  Runtime Provider:     quarkus
  Runtime Version:      1.10.0
  Selector:             camel.apache.org/integration=rest-dsl
  Version:              1.7.0
Events:
  Type    Reason                       Age                    From                                Message
  ----    ------                       ----                   ----                                -------
  Normal  IntegrationConditionChanged  6m17s                  camel-k-integration-controller      Condition "IntegrationPlatformAvailable" is "True" for Integration rest-dsl: camel-system/camel-k
  Normal  IntegrationPhaseUpdated      6m17s                  camel-k-integration-controller      Integration "rest-dsl" in phase "Initialization"
  Normal  IntegrationPhaseUpdated      6m17s                  camel-k-integration-controller      Integration "rest-dsl" in phase "Building Kit"
  Normal  IntegrationConditionChanged  6m17s                  camel-k-integration-controller      Condition "IntegrationKitAvailable" is "False" for Integration rest-dsl: creating a new integration kit
  Normal  ReasonRelatedObjectChanged   6m17s                  camel-k-integration-kit-controller  Integration Kit "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Build Submitted"
  Normal  ReasonRelatedObjectChanged   6m17s                  camel-k-build-controller            Build "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Scheduling"
  Normal  ReasonRelatedObjectChanged   6m17s                  camel-k-build-controller            Build "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Pending"
  Normal  ReasonRelatedObjectChanged   6m17s                  camel-k-build-controller            Build "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Running"
  Normal  ReasonRelatedObjectChanged   6m17s                  camel-k-integration-kit-controller  Integration Kit "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Build Running"
  Normal  IntegrationConditionChanged  5m48s                  camel-k-integration-controller      Condition "Ready" is "False" for Integration rest-dsl: 0/1 updated replicas
  Normal  ReasonRelatedObjectChanged   5m48s                  camel-k-integration-kit-controller  Integration Kit "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Ready"
  Normal  IntegrationConditionChanged  5m48s                  camel-k-integration-controller      Condition "IntegrationKitAvailable" is "True" for Integration rest-dsl: kit-c6kjr0200nf56t743uqg
  Normal  IntegrationPhaseUpdated      5m48s                  camel-k-integration-controller      Integration "rest-dsl" in phase "Deploying"
  Normal  ReasonRelatedObjectChanged   5m48s                  camel-k-build-controller            Build "kit-c6kjr0200nf56t743uqg", created by Integration "rest-dsl", changed phase to "Succeeded"
  Normal  IntegrationConditionChanged  5m47s (x2 over 5m48s)  camel-k-integration-controller      Condition "DeploymentAvailable" is "True" for Integration rest-dsl: deployment name is rest-dsl
  Normal  IntegrationConditionChanged  5m47s (x2 over 5m48s)  camel-k-integration-controller      Condition "CronJobAvailable" is "False" for Integration rest-dsl: different controller strategy used (deployment)
  Normal  IntegrationPhaseUpdated      5m47s (x2 over 5m48s)  camel-k-integration-controller      Integration "rest-dsl" in phase "Running"
  Normal  IntegrationConditionChanged  5m47s (x2 over 5m47s)  camel-k-integration-controller      Condition "Ready" is "False" for Integration rest-dsl: 0/1 ready replicas
  Normal  IntegrationConditionChanged  5m38s (x2 over 5m38s)  camel-k-integration-controller      Condition "Ready" is "True" for Integration rest-dsl: 1/1 ready replicas

When you describe the integration, you should have some Event like:
  Normal  IntegrationConditionChanged  10s                camel-k-integration-controller  Condition "ServiceAvailable" is "True" for Integration rest-dsl: rest-dsl(http/80) -> integration(http/8080)
  Normal  IntegrationConditionChanged  10s                camel-k-integration-controller  Condition "ExposureAvailable" is "False" for Integration rest-dsl: no host or service defined

The same can be recovered via kamel describe, ie:
$ kamel describe integration rest-dsl
Name:	rest-dsl
Namespace:	default
...
  DeploymentAvailable	True	DeploymentAvailable	deployment name is rest-dsl
  ServiceAvailable	True	ServiceAvailable	rest-dsl(http/80) -> integration(http/8080)
  ExposureAvailable	False	IngressNotAvailable	no host or service defined
  Ready	True	DeploymentReady	1/1 ready replicas

Also, you can check the output of:
$ k get service
NAME         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)        AGE
...
rest-dsl     NodePort    <IP_ADDRESS>   <none>        80:31846/TCP   110s

Finally, you can have a look at the operator log. If there is some permission error like you're suspecting, I think there will be some useful trace. After all, the Service trait is in charge to create a Service resource and apply to the cluster.


Translate specific terms in readme.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

I translate some specific terms of the english version of aritmetic operators!

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


[hw,mbx,rtl] Qualify OMBX read ptr initialization with mbx_empty

Qualify the initialization of the outbound mailboy read pointer with mbx_empty to ensure that setting the range in the middle of an ongoing transfer does not change the pointer immediately.
This is a follow-up of https://github.com/lowRISC/opentitan-integrated/pull/700

I think the best solution to protect the registers during the operation would be again, a hardware-controlled REGWEN for those registers. While I think the RoT FW can be trusted, I still think it's better to lock them though. Maybe the mailbox is used in other use-case, where FW cannot be trusted for whatever reason. I think, we can tie the REGWEN again to the busy status of the mailbox.


how to change rsync command parameters

Hi
in my case, i need copy some symlink as a real server. so i want add -L parameters in the command,
but i don't know how to do it. can you guys help on that?
more thanks.

a sorry i got them,


Test Patch

This just for testing CI, clang errors and test

Can one of the admins verify this patch?

jenkins run tests please

add to approvelist