Ability to pre-download models

Unstructured-inference lazily downloads models which is likely the better choice for most use cases, however there are scenarios where the consumer would like to prefetch models.
Currently, this can be achieved for the default layout parser models, e.g. typically used for PDF's with:
from unstructured_inference.models.detectron2 import MODEL_TYPES
MODEL_TYPES[None]['model_path']
MODEL_TYPES[None]['config_path']

but, it be nice if there was a simple function (with parameter(s) to allow warming different models) call the user could make to ensure any needed artifacts are downloaded.

get_model(model_name) will also do this... is that sufficient? We could also wrap it with a name tailored to what you're after...

Not sure if this relate to my issue but my corporate proxy blocks the http call to huggingface so i would love to use the same model I have downloaded locally https://huggingface.co/unstructuredio/yolo_x_layout/tree/main
Would it be possible ?


Fix zerossl tutorial path

Signed-off-by: czomo<EMAIL_ADDRESS>Fixing url to zerossl tutorial as well as adding it to current version of docs.

/ok-to-test

/assign @jahrlin

Hi @czomo thank you for the PR!
/ok-to-test

@irbekrm Could you take a look? I fixed all test

Rebased and squashed. Added prerequisite to use cert manager 1.7.3/1.8.2, updated commands

@jakexks Can you take a look? Thanks

Anyone can look at it?

@czomo I was looking into how I could use zerossl with cert-manager and landed here (so thanks a lot for writing this up) I would appreciate this doc being included in the public doc of cert-manager as well.
@JoshVanL
@meyskens
@jakexks
@irbekrm
@maelvls
@SgtCoDFish
@jahrlin
@wallrj
@munnerz

Thanks!
/lgtm
/approve


[#XXXX] Priority broken for RegexRecognizer

Fixes # XXXX
#minor
Description
This PR updates the AdaptiveDialog's OnRecognizeAsync method to take into consideration the priority set for the intents when there is more than one result with the same score.
Specific Changes

Updated the OnRecognizeAsync method to choose the topIntent considering both score and priority.
Removed the break from the RecognizeAsync method to return all the intents that match the pattern.
Added a unit test to cover the priority scenario in RegexRecognizerTests.
Added test script RegexRecognizerTests_Priority.test.dialog

Testing
These images show the bot not recognizing the correct intent before and the bot returning the right intent according to its priority after the changes.

/promoted 6435


Bug: how to replace / update the trusted CA for fleet agents after replacing the rancher certificate

What kind of request is this (question/bug/enhancement/feature request):
Bug / missing documentation
Steps to reproduce (least amount of steps as possible):
After deploying rancher with self-signed certificate on rke2 and importing one downstream rke2 cluster fleet gets deployed automatically.
Now replace the certificate of rancher following the process in https://rancher.com/docs/rancher/v2.x/en/installation/resources/update-ca-cert/ with an other certificate from an other CA and re-configure the downstream cattle-agents..
Now do a deployment/adjustment of some fleet things - i.e. add labels to clusters and wait on the re-deployment of the fleet git repos...
Result:
We see that the deployment does not work and in the fleet-agent logs we see this:
time="2021-06-22T09:30:44Z" level=error msg="Current credential failed, failing back to reregistering: Get \"https://rancher.xxx.com/apis/fleet.cattle.io/v1alpha1/namespaces/cluster-fleet-default-c-7fjlx-a0996dafa2d3/bundledeployments\": x509: certificate signed by unknown authority"
time="2021-06-22T09:30:44Z" level=error msg="Failed to register agent: looking up secret fleet-system/fleet-agent-bootstrap or fleet-system/fleet-agent: looking up secret fleet-system/fleet-agent-bootstrap: secrets \"fleet-agent-bootstrap\" not found"

Expected Result:
After replacing the certificate of rancher - also fleet should continue to work.
In case manual adjustments are required - these should be documented.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.8
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): RKE2 imported
Machine type (cloud/VM/metal) and specifications (CPU/memory): metal and VM
Kubernetes version (use kubectl version): 1.20.7 rke2r2

Successfully re-created the behaviour here and opened a docs issue to include the required step in the Rancher Update CA documentation. My repro:

Provision a Rancher v2.5.8 cluster, with a private-CA signed certificate, i.e. create tls-ca and tls-rancher-ingress and -set privateCA=true and --set ingress.tls.source=secret
Add a single all role node custom cluster
Update tls-ca and tls-rancher-ingress secret with a new private-CA signed certificate.
Delete Rancher Pods to force re-schedule and verify /v3/settings/cacerts updated.
Reconfigure Rancher agents in the custom cluster to trust the new CA (I used https://github.com/rancherlabs/support-tools/tree/master/cluster-agent-tool)
Delete the fleet-agent Pod in the downstream cluster, to force re-scheduling and attempt to connect to Rancher
Observe certificate trust error in fleet-agent Pod logs
Observe mismatch between certificate-authority-data in kubeconfig configured for fleet-agent kubectl -n fleet-system get secret fleet-agent -o jsonpath={.data.kubeconfig} | base64 -d and the new CA for Rancher

Resolution:
In the Rancher Explorer UI navigate to the Continuous Delivery view, click clusters, select the custom cluster and click Force Update The fleet-agent will be redeployed with an updated fleet-agent secret containing the new CA.

Great - thanks a lot for this analysis and fix!
Could you explain what exactly the "force update" does or point me to the documentation for this button in Rancher?
Does this delete/redeploy any workload, too?
Might this cause any load or downtime for repos deployed to the target cluster?


Trigger CI build package when release is drafted

Now that release drafter is implemented, need to trigger the package builds corresponding to the tag when release is published.

When release is drafted or when release is published (tag pushed) ?
We can break the build into a separate workflow.
If you want it to run on draft, it's the same as on push but limited to master.
If you want published, we can do on push but with a tag.

@princemaple Ah, I think when release is published (tag pushed). The way it was working before, the release is created in the GH action when the tag is pushed, then the built artifacts are renamed accordingly and uploaded and attached to the release. I can take a look on this one -- probably involves dropping the create-release step and uploading to the existing drafted release, then publishing it.
https://github.com/firezone/firezone/blob/master/.github/workflows/ci.yml#L245

Fixed by #619 among others


Rounded Borders

It seems that that border_rounding property on NotificationBlocks only rounds the inside, and not the outside. I'd love for both to be rounded but for now, a workarounds might be to set the border_rounding property, show no border, use the NotificationBlock as a 'border' and have an inner NotificationBlock that that actually has the content you want.

This is by design.  If we round the outer borders there is no way for us to make the compositor understand, and so the compositor shadows will still be on the pointy corners.
Rounded outer corners should be done at the compositor level.  For Picom this is the corner-radius option.


refac: Actor no longer under Organization.

Codecov Report

Merging #1470 (a307510) into main (ee869a8) will increase coverage by 20.15%.
The diff coverage is 32.58%.

@@             Coverage Diff             @@
##             main    #1470       +/-   ##
===========================================
+ Coverage   31.41%   51.57%   +20.15%
===========================================
  Files          54       68       +14
  Lines         818     1204      +386
  Branches       47        0       -47
===========================================
+ Hits          257      621      +364
- Misses        551      568       +17
- Partials       10       15        +5

Impacted Files
Coverage Δ

...MarketParticipant/Dto/OrganizationWithActorsDto.cs
0.00% <0.00%> (ø)

...rollers/MarketParticipantUserOverviewController.cs
0.00% <ø> (ø)

...Controllers/MarketParticipantUserRoleController.cs
0.00% <0.00%> (ø)

...-dh/source/DataHub.WebApi/GraphQL/GraphQLSchema.cs
0.00% <ø> (ø)

...ataHub.WebApi/GraphQL/Types/OrganizationDtoType.cs
0.00% <ø> (ø)

....WebApi/Controllers/MarketParticipantController.cs
57.33% <25.00%> (-6.46%)
:arrow_down:

...on/Controllers/MarketParticipantControllerTests.cs
100.00% <100.00%> (ø)

...taHub.WebApi/Controllers/Wholesale/Dto/BatchDto.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...trollers/MarketParticipant/Dto/FilteredActorDto.cs
16.66% <0.00%> (-83.34%)
:arrow_down:

...gistration/HealthEndpointRegistrationExtensions.cs
45.45% <0.00%> (-36.37%)
:arrow_down:

... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ImprovementShow column stats even when error accured.

Before, show column stats will ignore column with error.
In this pr, when min or max value failed to deserialize, show column stats will use N/A as value of min or max, and still show the rest stats. (count, null_count, ndv and so on).

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.14 seconds
stream load tsv:          537 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>5 Bytes


DBN+BPNN for fault classification

I use DBN for the classification of bearing fault data sets at Case Western Reserve University. The data set includes 10 failures, but the final classification result is always a category. When you modify various parameters of the network in  nnsetup.m, the result will change accordingly. For example, when you change nn.learningrate to 1, the classification will change from 1 to 4. Many people have encountered this problem, but No suitable solution was found. Sincere hope that someone can help me

You can try to change the initial weight of the RBM and increase the number of training.

thanks for your help...

thanks for you help.
i tried to set the initial weight to a random number between 0 and 1, and increased the number of training.The result is still the same as before.

@joey0111
thanks for you help.
i tried to set the initial weight to a random number between 0 and 1, and increased the number of training.The result is still the same as before.

@joey0111
thanks for your help.
i tried to set the initial weight to a random number between 0 and 1, and increased the number of training.The result is still the same as before.

A random number between 0 and 1 is not enough. You can try multiplying all the initial weights by 0.01 or a smaller number. Also, have you normalized the input data?

@joey0111
thanks....but it si still not working...and All data has been normalized.
The data source is the open bearing fault data set of Case Western Reserve University, USA, which is the original time domain signal. The training samples include 10 types of faults, each of which has 600 training samples, a total of 6000 groups, and 128 data points per group (all normalized).

Can you upload your project to Github? I also do DBN fault classification and may have some help for each other.

Have you solved this problem? It seems that I have come across the same question.

i use the new matlab2018b。
| |
Eric
|
|
<EMAIL_ADDRESS>|
签名由网易邮箱大师定制
On 4/26/2019 15:07，Yunlong<EMAIL_ADDRESS>wrote：
Have you solved this problem? It seems that I have come across the same question.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I hava tried to use matlab2018b,but the result doesn't change at all.Is it possible that the code has a problem?
------------------ 原始邮件 ------------------
发件人: "Yi<EMAIL_ADDRESS>发送时间: 2019年4月26日(星期五) 下午3:44
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [rasmusbergpalm/DeepLearnToolbox] DBN+BPNN for faultclassification (#182)
i use the new matlab2018b。
| |
Eric
|
|
<EMAIL_ADDRESS>|
签名由网易邮箱大师定制
On 4/26/2019 15:07，Yunlong<EMAIL_ADDRESS>wrote：
Have you solved this problem? It seems that I have come across the same question.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I hava tried to use matlab2018b,but the result doesn't change at all.Is it possible that the code has a problem?
…
------------------ 原始邮件 ------------------ 发件人: "Yi<EMAIL_ADDRESS>发送时间: 2019年4月26日(星期五) 下午3:44 收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [rasmusbergpalm/DeepLearnToolbox] DBN+BPNN for faultclassification (#182) i use the new matlab2018b。 | | Eric | |<EMAIL_ADDRESS>| 签名由网易邮箱大师定制 On 4/26/2019 15:07，Yunlong<EMAIL_ADDRESS>wrote： Have you solved this problem? It seems that I have come across the same question. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

这个工具箱是没有问题的，就是不好调试，因为需要人工进行。
我用自己的数据，总共十类，用这个工具箱可以达到95的准确率。


Improve ClassifyContext rustdocs

Improve the rustdocs on the ClassifyContext enum by doing:

Use link for OP_RESERVED
Use term OP_SUCCESSx is done in BIP342 (no code link, does not exist in code).
Use enum::variant form for both variant mentions
Direct readers to BIP342 for full list of opcode re-names

I removed the link (and did not use it for Tapscript variant) because we are on the ClassifyContext enum already, linking to the variant seems unnecessary (and FTR just makes the page jump down a little bit then one has to scroll back up).


Consider adding support for flowcharts

Just an idea. It would be nice to be able to generate a flowchart designed in draw.io similar to what can be done with state machines. In this case I would like the generated code to just be a single function (perhaps with configurable parameters and return types).

Interesting idea. I wonder if a tool like this already exists?


default u-url to webmention source url

discovered by @khurtwilliams today: if an incoming webmention doesn't have a u-url, we happily convert it to an AS2 object without id, which mastodon accepts and returns HTTP 202, but never actually displays. i think the lack of id is the root cause.
example log: https://fed.brid.gy/log?start_time=1513114805&key=https%3A%2F%2Fislandinthenet.com%2Ftest-2-2%2F+https%3A%2F%2Fmastodon.social%2F%40khurtwilliams%2F99163372007448652

fixed! thanks again for reporting, @khurtwilliams. your reply shows up on https://mastodon.social/@khurtwilliams/99163372007448652 now.

Thank you.
https://islandinthenet.com
"Those that prosper consistently will think deeply, reevaluate, adapt,
and continually
evolve”. ~ Farnam Street
Schedule some time to chat! http://calendly.com/monkeyhill
From: Ryan Barrett<EMAIL_ADDRESS><EMAIL_ADDRESS>Reply: snarfed/bridgy-fed
<EMAIL_ADDRESS><EMAIL_ADDRESS>Date: December 12, 2017 at 21:21:08
To: snarfed/bridgy-fed<EMAIL_ADDRESS><EMAIL_ADDRESS>CC: Khürt Williams<EMAIL_ADDRESS><EMAIL_ADDRESS>Mention<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject:  Re: [snarfed/bridgy-fed] default u-url to webmention source url
(#20)
fixed! thanks again for reporting, @khurtwilliams

https://github.com/khurtwilliams. your reply shows up on
https://mastodon.social/@khurtwilliams/99163372007448652 now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/snarfed/bridgy-fed/issues/20#issuecomment-351260956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAp7e60fm1JyCJNlwk-iiwdHteMClp2Vks5s_zSUgaJpZM4Q_s3e
.


Update akka-stream-alpakka-unix-domain-socket to 3.0.3

Updates com.lightbend.akka:akka-stream-alpakka-unix-domain-socket from 2.0.2 to 3.0.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lightbend.akka", artifactId = "akka-stream-alpakka-unix-domain-socket" } ]

labels: library-update, semver-major

Superseded by #130.


Run on time based trigger

Script is perfect for generating images from within the sheets document itself, but is it possible to adjust it to be able to run on a trigger?
I think this would be difficult as much of the html based script would need to be moved into the .gs, which may not be possible?

Script is perfect for generating images from within the sheets document itself, but is it possible to adjust it to be able to run on a trigger?
I think this would be difficult as much of the html based script would need to be moved into the .gs, which may not be possible?

Hi,
This question bothers me too, for now I did not try, but possibly we could play around with UrlFetch to handle that.
Here Hustin shows an example of extending scipts possibilities:
https://justin.poehnelt.com/posts/apps-script-runtime-limitations-wintercg/
I'd be glad with any help here.

Yes, I think it would be a lot of slowly working through line by line to see if there are apps script alternatives for things.
I started taking a look at it yesterday, but this is new stuff for me. Will continue to try and chip away at it.

Hi @man-over-board  - grinding over the same issue. Please do share if you have found a solution! :)

In the end I went a different route - mostly because of my use case.
I was trying to take snapshots of chats with some surrounding cells with relevant information. I found I could convert chart objects to images (which requires using slides as an in-between, weirdly...). I set this up to auto generate all the charts I wanted on a schedule.
https://tanaikech.github.io/2020/06/23/workaround-correctly-exporting-charts-on-google-spreadsheet-as-images-using-google-apps-script/

The issue is resolved, see documentation for version 2
https://github.com/Max-Makhrov/range2image


Windows, Git., Atom

Salutations virtual acquaintances ^-^
I have been curious about something while using Atom, in my Project window I have 2 folders showing up called .git and .gitattributes in the tutorial videos and some screenshots of others work, I don't think I've ever come across them, I was just wondering if anyone else has these showing up if you use Atom and if it's normal for them to be there.

Thank you for the clarification!


PlaceholderAPI Placeholders

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No problem
Describe the solution you'd like
A clear and concise description of what you want to happen.
PlaceholderAPI placeholders for whether the player is currently sitting and whether player has their sitting toggled on or off
Additional context
Add any other context or screenshots about the feature request here.
Love that you continued this!

I am not familiar with PlaceholderAPI but if I understand it correctly, BetterChairs would add new placeholders for other plugins to use, right? Or is it meant to support placeholders in the messages BetterChair sends?

I mean, technically it can do both, but I just meant for it to provide placeholders for other plugins to retrieve data from, like strings basically. It's pretty simple to do and I could probably put in a PR myself. I'm personally only going to use them for DeluxeMenus. I can create an options menu with it that will be able to toggle sitting off and on in a gui. Retrieving their currently toggled state will allow me to provide custom buttons for on and off.

https://github.com/SpraxDev/BetterChairs/pull/115

I've already replied to your PR but for the sake of completion:
I've added PlaceholderAPI support with two placeholders: sitting and chairs_enabled
I took inspiration from your PR as it helped me understand the PlaceholderAPI a bit easier that with their Wiki alone.


Use resource views without proxy

I'd like to use resource views of geoview without a proxy, which is ok since I require resources to have proper CORS headers. However, when I disable the resource_proxy extension, the WMS viewer still uses the proxy URL and gets a 404. The GeoJSON viewer uses the correct URL though.

I've faced with the same issue and this PR solved my problem.


Fix(#87): Add Some Basic Validations For Better UX

[x] Max length limit for Tag Name while creation: 25 Characters

[x] All Tag Names Should Be In English, So Translate it or don't allow it

[x] Users Per Page Should Be 15, not 16

[x] Validate the language users are inputting, dont allow any abuses or curses

I have added a function censorBadWords (which can take string, object or array of strings as arguments and convert the bad words to censored words) to the services directory and it is being used in the formSubmit before dispatching.

Please review the PR and let me know if you want more changes.

@ozair-dev
Not able to see the censorship working actually,
https://stackoverflow-clone-fronten-git-fbdb88-mayank2aggarwal-gmailcom.vercel.app/tags/penis
https://stackoverflow-clone-fronten-git-fbdb88-mayank2aggarwal-gmailcom.vercel.app/questions/95e661a4-2364-4a1d-aa21-2fcf731d54d3
https://stackoverflow-clone-fronten-git-fbdb88-mayank2aggarwal-gmailcom.vercel.app/questions/957a9d9d-247d-4710-a55c-9bc2c99d388b
https://stackoverflow-clone-fronten-git-fbdb88-mayank2aggarwal-gmailcom.vercel.app/questions/371f797c-b749-43ff-83c8-b6607e1bdc7b

The censorship is applied when a new post, comment or answer is submitted. Please try adding a new post and test for yourself if it works.
And if you don't like it this way! then I'll apply censorship to the post, answer, comment preview instead of submission stage

@ozair-dev
I think you can remove censorchip from submission, as I think we can store uncensored data, and display with censorship

@Mayank0255
please review the PR,
I'hv censored the bad words in a way that only first and last letter is shown.
 This is just how the package (which I used for censoring) works. But you'll see that it works very well in common scenerios.

Tags are not censored. Instead, they are detected at post submission and an error is shown

@ozair-dev cool,
One suggestion, can change the tags censor text to, "Inappropriate words are not allowed"
As the current text seems like that only tags cannot be Inappropriate 😅, though they can write inappropriate words for title and body but why tell them that

One suggestion, can change the tags censor text to, "Inappropriate words are not allowed"

Can do, but

As the current text seems like that only tags cannot be Inappropriate sweat_smile, though they can write inappropriate words for title and body but why tell them that

If the title or body contain inappropriate words, it won't terminate the dispatching of the formData, so user  is actually allowed to write inappropriate words there, but If the tags contain the inappropriate words then dispatching is stopped, so I specifically mentioned tags cannot contains inappropriate words.
But I'll still make the changes as you have asked for.

@Mayank0255  Just a quick heads-up before you merge the changes!
While matching and replacing bad words, a bunch a regex operations happens behind the scenes on each post, comment and answer, and this makes the page loading very slow. And in my opinion, to avoid this, the data must be censored on each submission. So we don't have to use regex on page load.
I don't know how big companies do these censorship on data, but as far as I know, we just can't (or shouldn't) do it after data retrieval.

By how much is the page loading time increasing?

On my machine, it's taking about 43 seconds.
IMO, each post takes anywhere from 100-300ms,  (speed may vary depending on processor speed), so it is wise to censor bad words on submission.

I'm busy these couple of days. Will try when I am free In sha'Allah.

I'm busy these couple of days. Will try when I am free In sha'Allah.

Sure, no problem

I have removed censoring for posts on data retrieval and instead, I am censoring title and body of each PostItem.compoent component on render. It stills takes about 43 seconds for HomePage to load. And additional 43 seconds (more or less depending on amount of text and machine's speed etc) on each pagination.
Here in the screenshot, you can see in console how much time each text is taking to be censored. Even the amount of time taken to censor even a small string is not negligible
Long story short, censoring text on rendering also does not reduce the loading time.

Deploy the changes and see the time time taken to censor each text in console to get a better idea.

@ozair-dev
questions page is breaking

fixed

@ozair-dev looks good enough, just remove the logs and I will merge

Done

@ozair-dev
Merged🎉🎉


Add UI for scanning ports

Fixes #12
Frontend added. Suggested UI changes also done

Used camelCase and combined variable declarations as suggested by @vinitshahdeo
formatted index.css @Kashish121

@ishika1727 Awesome 👏

@Kashish121 Merged the UI changes into feature/frontend. Hopefully you're unblocked now.


feat(chat): redesign approve required modal (Issue #1676)

Description:
redesign approve required modal
Issues:

#1676

UI changes
https://www.figma.com/design/lwL5jneveZczAj5RLcLFH2/DIAL-Chat?node-id=9219-15631&t=5a91fUZl3J8DNkRN-4
Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review


Suggest HCM VM Size

It would be nice if there were a suggested VM size for the HCM.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9799b467-4163-cf32-1089-489ad5d5263e
Version Independent ID: acfb23b2-30a7-d79e-f821-6e7b390f8bb5
Content: Hybrid Connections overview
Content Source: articles/biztalk-services/integration-hybrid-connection-overview.md
Service: biztalk-services
GitHub Login: @MandiOhlinger
Microsoft Alias: ccompy

@markgar Thanks for the Comment. We are actively investigating and will get back to you soon.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@ccompy I think this one is yours.

#please-close Hybrid Connections created in BizTalk Services is deprecated. Use https://docs.microsoft.com/en-us/azure/app-service/app-service-hybrid-connections.


How to compile linux lib with MKL?

Hi! I found out that MKL flags is set by default:
https://github.com/FloopCZ/tensorflow_cc/blob/e1ad656883d16f404a5638a218cd197dbfdc0f08/tensorflow_cc/cmake/build_tensorflow.sh.in#L19-L20
But the compiled static lib seems not with MKL. How should I make it with MKL, should I add --config=mkl as below?
https://github.com/FloopCZ/tensorflow_cc/blob/e1ad656883d16f404a5638a218cd197dbfdc0f08/tensorflow_cc/cmake/build_tensorflow.sh.in#L100

update:
It may be good to compile a shared lib with MKL using current scripts. However, a static lib with MKL would be preferred.

Hi, unfortunately, the static build does not use the build_tensorflow.sh.in script at all, but instead, it uses contrib/makefile project from the official Tensorflow repository (called from here). I believe the contrib/makefile project does not support MKL and I don't believe it ever will, so I cannot really help you, sorry.


useRequestHeaders and useFetch are incompatible in 3.8.0

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.8.0
CLI Version:      3.9.1
Nitro Version:    2.7.0
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-mgk9r8
Describe the bug
#23462 introduced headers option value as one of the hash components for useFetch requests. This however broke the example of supplying headers: useRequestHeaders() as shown in docs, because on server side and client side the supplied value are different (on client side it will always return an empty object). This results in a cache miss and triggers a re-fetch data being null on hydration.
Additional context
No response
Logs
No response

Just hit this too and found that the opts.headers is part of the key hash, which is different between server and client when using cookie forwarding.
A workaround is to supply your own key in the useFetch options (or to use useAsyncData, even works without specifying the key manually as the first argument).


Enable negative bounds in ranges

Overcomes the issues in #517 by changing how the sort terms are
parsed.

Great, this was not trivial!


Make it clearer that playlists need to be published in order to be shared/appear on channels (updates too)

[ ] maybe add publish button on the right side of the tile on Lists page?
[ ] If I'm on my own playlists section of a channel and I have unpublished lists, give option to "publish to this channel".

Another suggestion was to add the publish option to the context menu


Bump argo workflows to v3.2.4 release

This release has general fixes. We don't require this upgrade for any specific changes or fixes.

@emileten just FYI, this is how we upgrade argo workflows on the cluster.
 We point to the yaml manifests we want ArgoCD to install with this kustomization.yaml file I'm modifying in this PR.
The other things in the kustomization file are other resources. There are also "overlays" that patch in our own changes and configurations to the install.


RET-1345: Update ave to support Xcode 8 and iOS 10

@honeybeep I'm concerned about the switch to otool-classic.  Any thoughts?

@seanhho

LGTM :shipit:


Start menu dialog popup is broken in KDE 5

Problem Description
When clicking on the start menu button in the dock, it's supposed to display the start menu:

However, with XMonad the start menu doesn't display at all. Sometimes it will display for a fraction of a second, but then it immediately closes. This makes it impossible to use the start menu.
This also happens with some other dialogs which are spawned from the dock, such as the Search button, the window list button, etc.
Here is the xprop for the start menu dialog:
_KDE_NET_WM_SHADOW(CARDINAL) = 33554595, 33554597, 33554599, 33555399, 33555399, 33555399, 33555399, 33555399, 0, 0, 1, 1
WM_STATE(WM_STATE):
                window state: Normal
                icon window: 0x0
_NET_WM_USER_TIME(CARDINAL) = 392810
WM_TRANSIENT_FOR(WINDOW): window id # 0x2000039
_KDE_SLIDE(_KDE_SLIDE) = 0xffffffff, 0x3
_KDE_NET_WM_BACKGROUND_CONTRAST_REGION(_KDE_NET_WM_BACKGROUND_CONTRAST_REGION) = 0x1, 0x1, 0x136, 0x1fb, 0x3fc689ca, 0xbeb90c0a, 0xbeb90c0a, 0x0, 0xbf9ba0a6, 0x3f32584f, 0xbf9ba0a6, 0x0, 0xbdfb5f1c, 0xbdfb5f1c, 0x3fe516dc, 0x0, 0x3f04ccca, 0x3f04cccd, 0x3f04ccd1, 0x3f800000
_KDE_NET_WM_BLUR_BEHIND_REGION(CARDINAL) = 1, 1, 310, 507
_NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_SKIP_PAGER, _KDE_NET_WM_STATE_SKIP_SWITCHER, _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP
_KDE_NET_WM_DESKTOP_FILE(UTF8_STRING) = "org.kde.plasmashell"
XdndAware(ATOM) = BITMAP
WM_NAME(STRING) =
_NET_WM_NAME(UTF8_STRING) = "Plasma"
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x1, 0x0, 0x0, 0x0
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DIALOG, _KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL
_XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1
WM_CLIENT_LEADER(WINDOW): window id # 0x200001b
WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                window id # of group leader: 0x200001b
WM_CLIENT_MACHINE(STRING) = "nixos"
_NET_WM_PID(CARDINAL) = 2018
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 33554523
WM_CLASS(STRING) = "plasmashell", "plasmashell"
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_NORMAL_HINTS(WM_SIZE_HINTS):
                user specified location: 0, 541
                user specified size: 312 by 509
                program specified minimum size: 312 by 509
                program specified maximum size: 312 by 509
                window gravity: Static

I believe the important part is the _NET_WM_STATE_SKIP_TASKBAR and _NET_WM_STATE_SKIP_PAGER, that is what distinguishes it from regular dialog popups.
Steps to Reproduce
Use the below configuration file, and then try to open the KDE start menu from the dock.
Configuration File
import XMonad
import XMonad.Config.Kde

main = xmonad $ kde4Config

Checklist

[X] I've read CONTRIBUTING.md

I tested my configuration

[X] With xmonad version 0.15
[X] With xmonad-contrib version 0.16

@TheMC47 IIRC you were also using KDE, right?  Can you reproduce this?

Can you provide exactly how you're using xmonad with KDE?

@TheMC47 It's just a standard setup. I use NixOS Unstable, so I use the following options:

services.xserver.desktopManager.plasma5.enable = true;
services.xserver.windowManager.xmonad.enable = true;
services.xserver.windowManager.xmonad.enableContribAndExtras = true;

This installs xmonad 0.15, xmonad-contrib 0.16, and Plasma 5.23.5
I also followed these directions by creating a ~/.config/plasma-workspace/env/set_window_manager.sh file which contains this code:
#!/bin/sh
export KDEWM="/nix/store/m4jxwgrkv4d1acppj6jzvw7b66zc6rqq-system-path/bin/xmonad"

(The exact filepath will vary, I used whereis xmonad to locate it)
Lastly I used the above XMonad config. Everything works fine, except for the dialog popups.
I've had this issue for years, but I just lived with it. I had fiddled around with my XMonad config to try and fix it, but nothing really worked.

The config doesn't reproduce the error. I spun up a VM running NixOS and I added the lines to the nix configuration. As you can see in the screenshot, it works

@Pauan Since you're using NixOS anyways, any chance you could get us a full config (modulo the hardware settings) that we can try in a VM or something?

Sorry for the delay, I've been busy moving to another country. I'll try and get some precise reproduction steps, ideally in a VM.

I have the same issue with both krunner and the start menu dialog.
I've installed xmonad yesterday via stack using the info from https://github.com/xmonad/xmonad/blob/master/INSTALL.md
Well, I'm not sure it's exactly the same issue. The menu does sometimes show (1 out of 10 times or something). So it can show, but most of the times it doesn't appear. But I do see something flicker very briefly.
versions:

xmonad: <IP_ADDRESS>
plasmashell 5.24.5

relevant portion of the xmonad config
myManageHook :: ManageHook
myManageHook = composeOne
  [ isKDETrayWindow -?> doIgnore <+> hasBorder False
  , (className =? "plasmashell") -?> doFloat <+> hasBorder False
  , (className =? "krunner") -?> doFloat <+> hasBorder False
  , (className =? "1Password") -?> doCenterFloat <+> hasBorder False
  , transience
  , isDialog -?> doCenterFloat
  ]

myKeys :: [(String, X ())]
myKeys =
  [ ("M-p", spawn "dbus-send --print-reply --dest=org.kde.krunner /App org.kde.krunner.App.display")
  , ("M-S-p", spawn "dbus-send --print-reply --dest=org.kde.plasmashell /PlasmaShell org.kde.PlasmaShell.activateLauncherMenu")
  , ("M-g", toggleScreenSpacingEnabled >> toggleWindowSpacingEnabled)
  , ("M-S-g", setScreenSpacing (Border 4 4 4 4) >> setWindowSpacing (Border 4 4 4 4) >> setScreenSpacingEnabled True >> setWindowSpacingEnabled True)
  ]

If I change (className =? "plasmashell") -?> doFloat <+> hasBorder False to (className =? "plasmashell") -?> doIgnore <+> hasBorder False then the window always shows, but of course it doesn't have focus and I can't type anything into it, so not a solution.

That looks indeed like that bug, thanks!

@tcoopman Well, I'm not sure it's exactly the same issue. The menu does sometimes show (1 out of 10 times or something). So it can show, but most of the times it doesn't appear. But I do see something flicker very briefly.

Yes, that's exactly the same issue I have. Except for me both krunner and the start menu are broken.

I will close this as a duplicate of https://github.com/xmonad/xmonad/issues/174 then


Remove version: Bitnami.Drupal version 9.4.1-0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Version still available.


Manage polls for the cooperation

As a cooperation administrator I want to have the ability to manage polls and collect feedback from cooperation users regarding important decisions.
Description
As polls are a mandatory part of making public decisions for the cooperation I would like to have the ability to:

initiate a poll
finish the poll (automatically or manually)
collect the poll results

Acceptance Criteria
I have enough API for managing polls for cooperation.
Epic link
Epic #3
ZenHub Epic
Tasks

[ ] TBD
[ ] ...

It was originally estimated as "13" but it was considered too large and requires splitting. I'm removing the estimation for now.


Control Net download failling

When I launch my Colab Pro notebook from https://github.com/TheLastBen/fast-stable-diffusion:  fast_stable_diffusion_AUTOMATIC1111.ipynb through
I get stuck on the line !git pull:

even when i have not selected any option:

The only solution that I have found is to stop de process and launch the start SD.

click once on the stop button, it will skip git pull and continue the rest of the cell

But why is it happening now?  before it did not.


fixed bugs for invalid psm

After deleting the invalid PSMs, We should synchronise the deletion of the Peptide Hits if the peptide hits is invalid and return new peptide hits results

What is an invalid PSM? @daichengxin


Chronograf cannot remove InfluxDB/Kapacitor Creds

Using Chronograf 1.7.2, if you go into Chronograf and decide you want to remove the InfluxDB user creds, you cannot without deleting the source and recreating it.
Also worth noting, if you try to edit the source, there is no way to cancel/close out of the panel without saving the connection or refreshing the page. Maybe two issues are needed?

Opened in kapacitor on accident. Recreated in chronograf.
https://github.com/influxdata/chronograf/issues/4784


Replacing Address with Readable Names

On Web3 we do have our wallet addresses which uniquely identify us. But we as humans are very used to dealing with readable names.

Currently on the website as shown in the image above, we get the creator's address, which is hard to remember.
Make a feature to use names mapped to wallet addresses. Which eventually should return creator names to be displayed on the website.
If you require more understanding, let's chat!

The website link is here Subvid streams https://subvid-stream.vercel.app/

Hey @Arun89-crypto, it will be great if you can work on this.
I am assigning this to you. 👍

PR created #8
Also added some requirements.
@aditya172926

The frontend repo is now open for Hacktoberfest! You can work on your enhancements under relevant issues.
Please comment there as well so I can assign you the issue. @Arun89-crypto
Frontend repo https://github.com/aditya172926/Subvid_stream

Ok @aditya172926 I commented assign that issue till then working on it. And please merge this issue also because without that I won't be able to use the username mapping.


Add: Open Government, Saudi Arabia

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

approved

Thanks for the contribution @hadialqattan!


Case-Sensitive search

Is there a way to make atuin search case-sensitive?
I'm often searching in my history for something that is case dependent, for example searching for ssh*-L will usually show me commands with that specific flag, with atuin I'm currently receiving a command that is ssh host-loop.mydomain.com.

It is my impression that atuin is already case sensitive, at least for the last few versions.
For example, searching for passcode will return commands containing that word or close matches, but not those containing Passcode. And searching for Passcode will return the one and only command in my history that contain this word.
PS: I came here looking for a way to make it case-insensitive :upside_down_face:

I just run echo passcode and then echo Passcode and it will show both results when I search for Passcode.
I'm using search_mode = "fulltext" in ~/.config/atuin/config.toml.

Oh, I'm using fuzzy search mode, that must be it.

Hmm we could add an option for case sensitivity 🤔
Also omg @norpol that's so much history 🤯
Are you having any performance issues?

Hi there, I'd also appreciate having case-sensitive search. I'm using --search mode prefix so, for example, when I search for commands starting with "git" I'd ideally like that just to match git commands but not e.g.
GIT_PAGER=less some-non-git-command


add support for node master

This PR allows to use NAN with current Node on master and should fix several fails in CITGM which use NAN.
Not sure if this should be really included in NAN at this time as Node plans to do further updates of V8 till v12 is released (see https://github.com/nodejs/node/issues/25060#issuecomment-447748949).
There is still a self deprecation warning in v8 left but I think this should be addressed inside v8 or in the patched v8 variant included in node.
Refs: https://github.com/nodejs/node/issues/25060
Fixes: #829

Looking good. Not too many breaking changes so far. Will hold off until Node 12 gets closer to release. Thank you.

Rebased to 2.12.1.
I'm fine with waiting.
I think there are quite some people out there which would be happy with a nan release working with node master. But it's up to them to convince you to take this maintenance burden 😏.
Maybe someone (or even myself) finds some time to port nan to use napi. This would help a lot in future but not sure if it is that easy. It would be for sure a good test for napi completeness.

I think there are quite some people out there which would be happy with a nan release working with node master. But it's up to them to convince you to take this maintenance burden .

Maintenance burden indeed. Unfortunately, I do not have time to follow a volatile moving target with actual releases, since every release comes with a risk of something unintentionally breaking. However, merging to master would not hurt. Whoever wants to be on the bleeding edge can easily do so then.

Maybe someone (or even myself) finds some time to port nan to use napi. This would help a lot in future but not sure if it is that easy. It would be for sure a good test for napi completeness.

I had originally thought of doing precisely that, but shelved the plans due to lack of time and motivation. A common feature set could likely be mapped onto NAPI, but AFAIK there are be some (rare) V8-specific features which arguably do not fit in napi, e.g. the garbage collection API.

@kkoopa do you think it's time to release a new version of nan with the modifications from this PR? Node 12 is scheduled to be released in April (https://github.com/nodejs/release.)

Yes, it is indeed time. Thank you for reminding me.

It's out now.


Document theme development workflow with Slate

If there is one thing we have discovered since launching Slate is the incredible number of different workflows developers have when developing themes. One of the objectives of Slate is to provide developers with a tested workflow. Part of Slates workflow can be inferred by the tools and features provided, but another part takes place outside of the development environment.
Lets document the workflow used by the Shopify Themes Team and open it up to the community. This will give developers new to Shopify a reliable reference, and experts tips on alternative approaches to their current workflow. Ideally this could also allow for feedback from the community, resulting in an even better workflow!

Related #333
Make sure we touch on Git workflow. Adding a theme to Git. Cloning the Git repo to a new device.

I'm in the process of trying to come up with a good workflow that works really well for team iteration. Would love to see some advice from your end on that.

Published https://www.shopify.ca/partners/blog/development-workflow
Will make a copy of it in the docs for future reference.


Porting app folder to TypeScript by transpiling locally

Reference - #3836
This PR tries to port app folder to TS by transpiling ts files in the folder itself.

Need to eslint to ignore generated js and js.map files
Current workaround: do git clean before running eslint (required to do before git push)

closing as alternate approach is merged


[Crash] guard against conversations_existence_check being null

The error message caused by this.props.me.conversations_existence_check being null:

After the null check:

Fails

:no_entry_sign:

No CHANGELOG added.

  Generated by :no_entry_sign: dangerJS

Awesome work - CHANGELOG please 👍

Ah, sorry we discussed offline:
This is a temporary issue due to a switch in some authentication thats out on staging currently. While there's nothing wrong with being extra defensive (IMO), we should understand and reason about the data we get back and only be defensive on actual scenarios, so we'll close for now.
Although...I suppose being defensive, even in a total red herring scenario thats not expected, is probably better than an outright crash, no? In that case maybe we should merge this in!
Reopening!

So that's what I was wondering... I think it's always worth guarding against a crash, though @xtina-starr rightly mentioned... maybe it should actually crash if something is truly amiss?

Fails

:no_entry_sign:

No CHANGELOG added.

  Generated by :no_entry_sign: dangerJS

Let's CHANGELOG and merge!
@mennenia I'd think in that case, we'd want to log/be notified of it, but I think gracefully handling it for the end user is 👌

ideally the metaphysics schema should tell us if this can be nil ( but we don't have strict checks on ) so more checking is better (to an extent )

👍 works for me


Not working with MAC

output:
"""
Obtaining authorisation for location services (required for WiFi scanning)...
error; Unable to obtain authorisation, exiting...
"""

For CoreWLAN-related bugs, please refer to issue #19.
If you receive the Unable to obtain authorisation, exiting... error, ensure Python has been granted Location Services permissions by going to System Settings > Privacy & Security > Location Services and checking next to Python.


SQL injection in Postgres Binder

SQL injection is currently possible in a couple of places in PostgresBinder
An example being:
https://github.com/Tesco/mewbase/blob/master/mewbase-core/src/main/java/io/mewbase/binders/impl/postgres/PostgresBinder.java#L63
It's easy to rectify using a PreparedStatement when the value is to be injected at condition position (e.g. WHERE key = '"+id+"';).
However in other cases values are injected at table name position (e.g. INSERT INTO "+name+" VALUES) as there is a table per binder. This is more problematic as JDBC drivers do not allow parameterisation in this position.
A couple of potential solutions could be:

Restrict binder names to be, e.g., alphanumeric and continue in current manner
Use a single table (indexed on binder name), shared between all binders

Would be interested to hear thoughts and other solutions, and happy to work on a PR to solve this issue

Fixed. Closing.


Pass on internal statsd_metrics data and generate additional backend metrics

As discussed in #6, also gather statsd_metrics data from the StatsD backend interface and send to InfluxDB when using the flush strategy and includeStatsdMetrics is true.
Also the influxdb backend now generatesflush_time, http_response_time, payload_size and num_stats metrics and sends these to InfluxDB if includeInfluxdbMetrics is true. These can also be seen via the TCP admin interface.

Thank you!


Improved domain validation

[x] Redmine Issue: https://redmine.pfsense.org/issues/9023
[x] Ready for review

Hello Jim, none of both are in fact FQDN and so should fail but from what I just discovered this function does not check, despite it's name, for FQDN intended as host names, but if it also needs to validate primary domain and domain DNS name the entire approach would be different, but fqdn doesn't include primary domain.
I've just tested is_domain() from utils.inc and it seems to do what you need, but "." and "_test._com" returns true, not sure if intended or not.
I would need some additional clarifications about the each function scope to help further.

I've uploaded a text file comparing if_fqdn, is_domain and my last changes (not yet pulled), please let me know if something isn't right.
It doesn't check maximum string (should be 253) or group (63) length, it also doesn't check how many groups there are.
is_fqdn.txt

Requested changes were applied, cheers.

Looks OK now but it needs testing, and it should wait for 2.4.5, not be included in 2.4.4-pX.


Syntax Highlighting for HTML template literals

Is it possible to enable syntax highlighting for html inside template literals in any popular editor? (VS Code, Webstorm, etc) Are there instructions on how to do so anywhere? Apologies if this is documented somewhere, I couldn't find it

Yes, there is a "preview" extension by @jhechtf, you can find it here: https://github.com/jhechtf/vscode-arrow-js
Anyway, if you already know Lit, you can use its extension, which seems to work pretty well (@justin-schroeder comment on https://github.com/justin-schroeder/arrow-js/discussions/23#discussioncomment-4227683)

P.S.: all this is referred to discussion #23.

We should add this to the docs!

Ok I added a little blurb to the docs. If @jhechtf decides to publish that project we'll include it on there too!

I mean I can go ahead and publish it but as it currently sits there's nothing particularly different about the arrow js extension vs the lit extension. Reply on the thread if you'd like to see that extension published.


EMPTY APK

everytime i build an apk the apk is empty with no python or enaml files how do i fix? thanks in advance

I CHANGED somethings and got this

Can you please attach the android/app/build.gradle and android/settings.gradle?
Gradle should create a bundle of everything named python.tar.gz in android/app/src/main/assets/python.


refactor(api): place move_to inside drop_tip implementation

Overview
Protocol API refactor work related to RCORE-134.
Begins work to move all instances of move_to in public facing PAPIv2 instrument context inside the private implementation/core classes.
Changelog

Changed method signature of drop_tip to accept Location
moved move_to to inside the drop_tip implementation

Review requests

[ ] Drop tip passes analysis and works on robot

Risk assessment
Low, this PR only changes one command.

Closing in favor of a fresh branch


Add support for aws profile credential resolution.

Codecov Report

Merging #93 (27b899b) into master (0ee738a) will decrease coverage by 80.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #93       +/-   ##
==========================================
- Coverage   90.47%   9.64%   -80.84%
==========================================
  Files           7      42       +35
  Lines          21     197      +176
  Branches        2      23       +21
==========================================
  Hits           19      19
- Misses          2     178      +176

Flag
Coverage Δ

nx-remotecache-s3
9.64% <ø> (?)

pellegrims-dev
9.64% <ø> (-80.84%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

apps/pellegrims-dev/components/social-icon.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/postcss.config.js
0.00% <0.00%> (ø)

apps/pellegrims-dev/constants.ts
0.00% <0.00%> (ø)

apps/pellegrims-dev/components/footer.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/components/date-formatted.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/components/bookmark.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/components/analytics.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/components/logo.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/pages/contact.tsx
0.00% <0.00%> (ø)

apps/pellegrims-dev/pages/snippets.tsx
0.00% <0.00%> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f4bd9...27b899b. Read the comment docs.

Thanks for your contribution! :+1:


Using Test Even in Lambda correctly runs a Glue Job and waits for it to finish but using aws invoke function locally says that a Job is already running.

I have this function that runs a Glue job and waits for it to finish by checking its status every 30s and returning if it sends a state.
def run_job(data, layer):
    s3 = boto3.client('glue')
    job_name = JOBS[layer]
    db_affix = DEV_DB_AFFIX[data]
    dest_affix = DEV_DEST_AFFIX[data]
    partition = DEV_PARTITION[data]

    job_response = s3.get_job(
        JobName=job_name
    )

    job_arguments = job_response['Job']['DefaultArguments']
    job_arguments['--database'] = job_arguments['--database'].replace("<dev>", db_affix)
    job_arguments['--s3_dest_prefix'] = job_arguments['--s3_dest_prefix'].replace("<dev>", dest_affix)
    job_arguments['--partition'] = partition

    try:
        response = s3.start_job_run(
            JobName = job_name,
            Arguments = job_arguments
        )

        status = s3.get_job_run(JobName=job_name, RunId=response['JobRunId'])

        state_error = False
        if status:
            state = status['JobRun']['JobRunState']
            while state not in ['SUCCEEDED']:
                time.sleep(30)
                status = s3.get_job_run(JobName=job_name, RunId=response['JobRunId'])
                state = status['JobRun']['JobRunState']
                if state in ['STOPPED', 'FAILED', 'TIMEOUT']:
                    state_error = True
                    break
        statusCode = UNSUCCESSFUL_JOB_RUN if state_error else SUCCESSFUL_JOB_RUN
    except Exception as e:
        print(e)
        statusCode = UNSUCCESSFUL_JOB_RUN
    return statusCode

Whenever I run it using a test event, It finishes running the Glue Job successfully.
**But whenever I invoke a function, in my local CLI using the command below, ** it returns unsuccessfully. The error is that a Glue Job is said to be already running.
Command
aws lambda invoke --function-name repopulate_dev_data --invocation-type RequestResponse --payload '{"data": "100", "layer": "T"}' response.json
{
    "StatusCode": 200,
    "ExecutedVersion": "$LATEST"
}

tldr, the test environment works but cmd invokation does not.

This does not seem to be a specific documentation problem. I think you should pursue this issue in the Lambda forum.


Fix SuiteRemoveCondition unit test

I fixed a SuiteRemoveConditionTest class which led to occasional tests failure.
Description
I noticed that running SuiteRemoveConditionTest caused different results each time. Out of 100 runs, 87 ended successfully and 13 failed. Each fail was caused from assertion error in evaluate_when8SuitesRemoveOlderThanButAlwaysKeepLatestVersion_expectTrue() when testing the following suite list:  A-1,A-2,B-3,B-4,C-5,C-6,D-7,E-8 ; 4 ; null ; C-5 ; 4.
In this test we check if suite created 4 days ago is marked as "to be removed" if cleaner removes suites 4 days old and older.
The problem resulted from incorrect order of initalizations: first we create SuiteRemoveCondition with max acceptable timestamp (now minus 4 days) and then mocked Suite (with creation date: now minus 4 days). The offset between "now" value in these cases led to the Suite being considered younger than 4 days from the condition's perspective. The difference is so small that in some cases the test passes, but the bug is evident if you use a breakpoint between the two initializations (increasing the time difference - then it fails every time).
I changed the order in all methods to prevent future mistakes.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

Update Changelog pls ;)


Add accessibility statement to the DS website

Copy this content and place into the accessibility link in footer of the design system website:
https://ukhodataupload.admiralty.co.uk/accessibility

PR: For accessibility changes


Add jsr305 dependency.

Fixes Issue
fixes #668
Changes proposed
[x] - Add maven dependency
Check List (Check all the applicable boxes)

Merged.
Thanks for your contribution !


Document theme.mixins.gutters()

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
I was following https://material-ui.com/layout/grid/ to get a basic app set up. After copying and pasting the examples on that page, the grid had no gutter on the left and right hand side of the page.
Adding theme.mixins.gutters() to the root class produced the behaviour I wanted.
const styles = theme => ({
  root: {
    ...theme.mixins.gutters(),
    flexGrow: 1
  }
});

Current Behavior
I first looked at the example apps, but these were all centred, so didn't suffer from the same issue. Next, I dug through the source code of the Toolbar, which did what I expected, where I found the mixin.
This seems pretty essential for building any left-aligned app, so I would have expected it to be in the getting started guide. I had a bad on-boarding experience due to this.

Please add this to the documentation asap, was about to implement my own breakpoint styles before I found this after pages of searching

@oliviertassinari does ListItem no longer use this?  It seems like it use to use it, but now I don't see any @media query in the ListItemgutters class.  Debatably a breaking change...I was using theme.mixins.gutters all over the place to align text fields and other things with the content of ListItems, and now it's not working...

What do you guys think of killing the theme.mixins.gutters method? I have never found a use case for it, working on different Material-UI applications. What are you guys using it for? Could the Container component replace it? https://next.material-ui.com/lab/layout/#container

A quick code search on GitHub lists lots of existing MUI sites using theme.mixins.gutters for responsive left and right padding (gutters) between desktop and mobile screens. Not sure if official documentation were ever added for the gutters mixin, but the fact that thousands (44k on a rough search albeit most should no longer be maintained) of repositories are using the same mixin in their existing MUI styles seem to suggest it being a popular method to settle responsive gutters. I guess a small article on migrating from the old theme.mixins.gutters to the mentioned Container component would be nice. I am thinking if there are uses for when we do not exactly need the Container component, even though it looks pretty lightweight and flexible

I created a demonstration of why I was using theme.mixins.gutters in #14751 (recent changes to ListItem gutters made my usage obsolete)

@oliviertassinari I think you're right, it would be better if we get rid of theme.mixins.gutters.  It's not being used in many places in the next branch anymore anyway.  Do you think I should get rid of it in #14754?

FYI the demo for Paper still mentions gutters: https://github.com/mui-org/material-ui/blob/master/docs/src/pages/demos/paper/PaperSheet.js#L9

@kaycebasques We focus on the next branch.


Remove usage of the "ssh_wait_timeout" key from the hyperv-iso builders

It seems that packer 1.5.1 doesn't support the "ssh_wait_timeout" key in the hyperv-iso builder. This results in Packer not being able to build some of the templates. It's very weird to me that this key isn't supported by the hyperv-iso builder and it smells like a Packer bug.
However, there's no open tickets for this so maybe it was done on purpose. Nonetheless, I collected these into their own PR so that when/if Packer re-introduces this key we can simply revert this PR.
This closes issue #194.

Force-pushed because apparently I used the --amend option to make the last commits.

This PR is part of a set: #195, #197, #199.

Results from merging PRs #195, #197, and #199
$ for name in *.json; do packer validate $name || echo $name; done
$


🐛 BUG: _headers file is not uploaded using wrangler pages publish

What version of Wrangler are you using?
2.0.8
What operating system are you using?
Linux
Describe the Bug
I started a chat in the discord here for some added context/troubleshooting, but I'll summarize here as well.
In CircleCI, I am running npx wrangler pages publish ./build --project-name=staging. But when I check in the Cloudflare UI, the _headers file is not included in the list of deployed files.
The build directory has 207 files, but when running the command it indicates it is only uploading 206 files. The missing file is my _headers file. I ssh-ed into the CIrcleCI instance running the job and confirmed the _headers file is in the build directory.
I looked through the pages.tsx file to try to understand what might be happening, but cannot make sense of the intended behavior. It does appear to be purposefully ignored to some degree, but also seems like it is POSTed in the form data of a request to Cloudflare. I assume someone with more familiarity with this code will have better luck.
Thank you!

@akosel Hi there! What you're seeing is the intended behaviour.
_redirects and _headers are POSTed to an endpoint for them to be added to the Pages deployment (and hence take effect) but they're not uploaded as static files since one typically doesn't want to serve them. That's why they are ignored and not showing up in the deployed files list.
You should however see them taking effect. If you don't, let me know and I'll investigate. Closing this in the mean time! Cheers.

Ahh, ok, thank you for the quick response!


Try html2canvas until viewTransition API allows keep old view.

We opened this issue to ask if view transition API allows keep old view after transition is performed. It seems it could be done. However, until that happens, we may experiment with html2canvas to capture old views.

We decided to go forward and not to wait for those changes. We will try to do out best efforts with
current tech developments


Post widget in different directory

Hi.
I'm currently trying to use the post widget for a different menu directory. I currently have the content/home/post.md file, which looks at recent I've created. Now I've created a menu with the following dropdown selection.
[[main]]
  name = "Home"
  url = "#about"
  weight = 10

[[main]]
  name = "Posts"
  url = "#posts"
  identifier = "dropdown"
  weight = 20
  hasChildren = true

  [[main]]
  name = "Finance"
  url = "/Finance"
  weight = 20
  parent = "dropdown"

  [[main]]
  name = "Economics"
  url = "/Economics/"
  weight = 20
  parent = "dropdown"

  [[main]]
  name = "Data Science"
  url = "/Data Science/"
  weight = 20
  parent = "dropdown"

  [[main]]
  name = "Machine Learning"
  url = "/Machine Learning"
  weight = 20
  parent = "dropdown"

  [[main]]
  name = "Programming"
  url = "/Programming/"
  weight = 20
  parent = "dropdown"

I've created a new post widget called finance.md, which my dropdown menu links to. I was hoping to have the finance.md show only posts in the finance category by changing the filter option in the widget, but that was unsuccessful. I was wondering what I was missing, what I'm doing wrong, or if I'm on the right track. I've looked at the documentation, but I couldn't really find anything related to what I'm trying to do.
Thanks in advance.

Please use the forums or chat for questions/troubleshooting. Also refer to the Academic and Hugo Documentation.


add sendFrom key pair array

Like native yii2 mailer
https://github.com/yiisoft/yii2-app-advanced/blob/master/frontend/models/PasswordResetRequestForm.php#L51

thanks


JWT Claim constraints (#7077)

Pull request opened by the merge tool on behalf of #7077

Merged in 79189bf9b9f3f2971d11ee8d0a8cb53ef17f3ef8


Impleted user search functionality

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
4, because the PR introduces a substantial amount of new functionality involving multiple Firebase services and React state management, which requires careful consideration of data handling, error management, and UI interactions.

 🧪 Relevant tests
No

 🔍 Possible issues

Possible Bug: The handleSearch function resets the searchUserName state immediately after setting up the subscription. This could lead to unexpected behavior where the user sees their input disappear as they type.

Performance Concern: The handleSelect function performs multiple asynchronous operations sequentially, which could be optimized to improve responsiveness.
 🔒 Security concerns
No

 Code feedback:
relevant fileClient/Client/src/components/FirebaseComponents/Search.jsx
suggestion

Consider debouncing the input handler for search to improve performance and reduce the number of queries made to Firestore. This can be achieved by using a debounce function from lodash or a custom implementation to delay the handleSearch call until the user has stopped typing for a specified interval. [important]

relevant lineonChange={(e) => setSearchUserName(e.target.value)}
relevant fileClient/Client/src/components/FirebaseComponents/Search.jsx
suggestion

Implement error handling in the handleSelect function to provide more detailed feedback to the user and to avoid console logs in production code. Consider using a modal or toast notification for displaying the error message. [important]

relevant lineconsole.log("There's an error")
relevant fileClient/Client/src/components/FirebaseComponents/Search.jsx
suggestion

Optimize the Firestore data retrieval by combining getDoc calls with Promise.all to fetch data in parallel rather than sequentially. This will likely reduce the waiting time for the user, especially when network conditions are suboptimal. [important]

relevant lineconst currUserChatsDocSnapshot = await getDoc(currUserChatsDocRef)
relevant fileClient/Client/src/components/FirebaseComponents/Search.jsx
suggestion

To prevent memory leaks, ensure that the unsubscribe function from onSnapshot is called when the component unmounts. This can be handled using the useEffect hook with a cleanup function. [important]

relevant lineconst unsubscribe = onSnapshot(q, (snapshot) => {

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


Build a static site

This is to propose porting static website template, implemented with Hugo, from Montreal repo to here. You can check the Montreal site in action here.
The site will be accessible on https://opensourcecities.github.io/toronto/. I would like to know if you have any suggestions, comments, concerns on this.

This is done in #13

Thanks, @khos2ow!


Change Story Pictures to pull from src instead of srcset

Currently the app pulls lower resolution photos when saving IG story pictures

Fixed #75


RefreshDisplay is not in sync

Display update should be synced with event time.
I think that in RefreshDisplayRunnable next update should be calculated like:
60000L - (currentTimeMillis() - pumpStatusData.getEventDate().getTime()) % 60000L

Fixed by #143


A link from create-an-odata-v4-endpoint.md is confusing

Before you open an issue
If the issue is:

A simple typo or similar correction, you can submit a PR. See the contributor guide for instructions.
A general support question, consider asking on a support forum site.
A site design concern, create an issue at MicrosoftDocs/Feedback.
A problem completing a tutorial, compare your code with the completed sample.
A duplicate of an open or closed issue, leave a comment on that issue.

Issue description
The document: https://github.com/dotnet/AspNetDocs/blob/master/aspnet/web-api/overview/odata-support-in-aspnet-web-api/odata-v4/create-an-odata-v4-endpoint.md#query-the-entity-set
It looks like the document talks about OData v4.
Under the section Query the entity set, it says:

The [EnableQuery] attribute enables clients to modify the query, by using query options such as $filter, $sort, and $page. For more information, see Supporting OData Query Options.

The address of the link Supporting OData Query Options is: https://github.com/dotnet/AspNetDocs/blob/master/aspnet/web-api/overview/odata-support-in-aspnet-web-api/supporting-odata-query-options.md
It's an article updated in 2013, and some of the query options were changed in OData v4, such as $inlinecount.
I think it might get improved by clarifying that the linked article is for an old version, or adding a new one for v4.

Any chance you could PR this? At the top right of the article, select the Edit pen icon:

Select the pen icon again. Save.


[SPARK-30667][CORE] Add allGather method to BarrierTaskContext

What changes were proposed in this pull request?
The allGather method is added to the BarrierTaskContext. This method contains the same functionality as the BarrierTaskContext.barrier method; it blocks the task until all tasks make the call, at which time they may continue execution. In addition, the allGather method takes an input message. Upon returning from the allGather the task receives a list of all the messages sent by all the tasks that made the allGather call.
Why are the changes needed?
There are many situations where having the tasks communicate in a synchronized way is useful. One simple example is if each task needs to start a server to serve requests from one another; first the tasks must find a free port (the result of which is undetermined beforehand) and then start making requests, but to do so they each must know the port chosen by the other task. An allGather method would allow them to inform each other of the port they will run on.
Does this PR introduce any user-facing change?
Yes, an BarrierTaskContext.allGather method will be available through the Scala, Java, and Python APIs.
How was this patch tested?
Most of the code path is already covered by tests to the barrier method, since this PR includes a refactor so that much code is shared by the barrier and allGather methods. However, a test is added to assert that an all gather on each tasks partition ID will return a list of every partition ID.
An example through the Python API:
>>> from pyspark import BarrierTaskContext
>>>
>>> def f(iterator):
...     context = BarrierTaskContext.get()
...     return [context.allGather('{}'.format(context.partitionId()))]
...
>>> sc.parallelize(range(4), 4).barrier().mapPartitions(f).collect()[0]
[u'3', u'1', u'0', u'2']

LGTM otherwise

Merged into master and branch-3.0. Thanks!

I'm reverting this commit because the jenkins test is not triggered. We can merge it again after the test passes.

add to whitelist

Jenkins retest please

retest this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, retest this please.

ok to test

Test build #118395 has started for PR 27395 at commit 74d14f5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23152/
Test PASSed.

Test build #118395 has finished for PR 27395 at commit 74d14f5.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118395/
Test FAILed.

Test build #118446 has started for PR 27395 at commit 6398066.

Test build #118446 has finished for PR 27395 at commit 6398066.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118446/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23203/
Test PASSed.

Test build #118452 has started for PR 27395 at commit 377d8d2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23209/
Test PASSed.

Test build #118452 has finished for PR 27395 at commit 377d8d2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118452/
Test FAILed.

Test build #118655 has started for PR 27395 at commit ff7f3dd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23407/
Test PASSed.

Test build #118655 has finished for PR 27395 at commit ff7f3dd.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118655/
Test FAILed.

Test build #118658 has started for PR 27395 at commit 24adef3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23410/
Test PASSed.

Test build #118659 has started for PR 27395 at commit d2fffe1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23411/
Test PASSed.

Test build #118659 has finished for PR 27395 at commit d2fffe1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118659/
Test FAILed.

Test build #118658 has finished for PR 27395 at commit 24adef3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118658/
Test FAILed.

retest this please

Test build #118681 has started for PR 27395 at commit d2fffe1.

Failed test seems irrelevant: org.apache.spark.sql.kafka010.KafkaDelegationTokenSuite.(It is not a test it is a sbt.testing.SuiteSelector)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23432/
Test PASSed.

Test build #118681 has finished for PR 27395 at commit d2fffe1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118681/
Test PASSed.

LGTM. Merged into both master and branch-3.0. Thanks!

It seems that this PR breaks the Mima test in the Jenkins PR builder job s(https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118684/console)
dev/mima -Phadoop-2.7 -Phive-2.3 -Pkinesis-asl -Phive -Phive-thriftserver -Pmesos -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pyarn

It seems that this PR breaks the Mima test in the Jenkins PR builder job s(https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118684/console)
dev/mima -Phadoop-2.7 -Phive-2.3 -Pkinesis-asl -Phive -Phive-thriftserver -Pmesos -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pyarn

hmm odd, this PR adds ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.RequestToSync")

Reverted from both master and 3.0
It seems the merge script provides a weird behavior: when you tried to merge this PR, it automatically cherry-picked the latest commit (which was reverted before).
The following output from my local environment:
Enter a branch name [branch-3.0]:
git fetch apache branch-3.0:PR_TOOL_PICK_PR_27395_BRANCH-3.0
remote: Enumerating objects: 307, done.
remote: Counting objects: 100% (307/307), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 692 (delta 288), reused 305 (delta 288), pack-reused 385
Receiving objects: 100% (692/692), 98.68 KiB | 5.48 MiB/s, done.
Resolving deltas: 100% (336/336), completed with 79 local objects.
From https://github.com/apache/spark
 * [new branch]            branch-3.0 -> PR_TOOL_PICK_PR_27395_BRANCH-3.0
 * [new branch]            branch-3.0 -> apache/branch-3.0
git checkout PR_TOOL_PICK_PR_27395_BRANCH-3.0
Switched to branch 'PR_TOOL_PICK_PR_27395_BRANCH-3.0'
git cherry-pick -sx 57254c9719f9af9ad985596ed7fbbaafa4052002
The previous cherry-pick is now empty, possibly due to conflict resolution.

@sarthfrey Please open a new PR instead and then let's try merge it again.


[Issue #452] Make the result JSON response more user friendly.

The json serialization for the Tuple class is not user-friendly. The backend needs to send a more user-friendly json response to frontend.
Previously, in PR #489 , we added the ability to make the Tuple class json serializable. However, the default json serialization for the Tuple class is not user-friendly.
This PR changes it back to the old format, which is more human readable.
Current:

After change:

LGTM.


Use json-ld for document description

I'm not sure if it is relevant but it may be interesting to use json-ld [1] for document description, may be even with the schema.org [2] vocabulary.
For example https://en.wikipedia.org/wiki/Jean-François_Champollion could be represented by (in an amazing future when Common search will be able to guess page topics):
{
  "@context": "http://schema.org",
  "@type": "WebPage",
  "@id": "https://en.wikipedia.org/wiki/Jean-François_Champollion",
  "name": "Jean-François Champollion - Wikipedia, the free encyclopedia",
  "description": "Jean-François Champollion (a.k.a. Champollion le jeune; 23 December 1790 – 4 March 1832) was a French scholar, philologist and orientalist",
  "inLanguage": "en",
  "image": "//upload.wikimedia.org/wikipedia/commons/thumb/6/6c/Leon_Cogniet_-_Jean-Francois_Champollion.jpg/220px-Leon_Cogniet_-_Jean-Francois_Champollion.jpg",
  "dateModified": "2016-03-01T14:47:00",
  "fileFormat": "text/html",
  "mainEntity":{
    "@type": "Person",
    "@id": "http://www.wikidata.org/entity/Q260",
    "name": "Jean-François Champollion"
  }
}

[1] http://json-ld.org
[2] http://schema.org

Thanks @Tpt!
Where in the pipeline do you think such a description would make sense? As output of an API?

Yes, it would be very nice as API output but it also could be used as the documents format inside of Elasticsearch.

Ok, let's keep it in mind for the API!
For Elasticsearch I don't think there would be any benefit. We should optimize for Elasticsearch storage and that will look very different from json-ld.

There is this google tool which extracts more than json-ld :
https://search.google.com/structured-data/testing-tool
For example :
https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fwww.tripadvisor.fr%2FAttraction_Review-g187103-d4744042-Reviews-Centre_Historique_de_Rennes-Rennes_Ille_et_Vilaine_Brittany.html
https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Flinuxfr.org%2Fnews%2Fse-passer-de-google-facebook-et-autres-big-brothers-2-0-1-les-moteurs-de-recherche
Some documentation about it :
https://developers.google.com/search/docs/guides/enhance-site


Updated tools and installers

some more updates

Updated gdb and fixed build on archlinux (hopefully this doesn't break builds on ubuntu/fedora)
fixed keystone install
don't use pwntools binutils ppa on xenial and later
apktool version bump
Find fastest mirror in archlinux Dockerfile
Fixes for #134 #135
don't add ctf-tools to PATH in .(bash|zsh)rc when manage-tools setup is called more than once

Thanks!
Looks like we were missing an ubuntu dependency for gdb, but I added it.


Switch from PGDG to PackageCloud

Closes #137
Closes #125
Blocked on https://github.com/citusdata/packaging/issues/8

@begriffs @jasonmp85 Was there a resolution on the use of curl | sudo bash? Are we OK with that for now?

I chatted with people in the general Slack channel about the security of curl | sudo bash and we agreed that it's no less secure than running other installers that you download from the internet. We thought that using tools like hashpipe is onerous and that a cautious user should download the script, inspect it, and then only run it if it looks safe.
This PR also closes #125

The steps and changes themselves look good to me.
A couple of questions:

Have we tried installing from PGDG first (say Citus 5.1), and then installing the packageCloud repo? Will they conflict with package names?

Also, since the same package name is available from both PGDG and PackageCloud, how does apt-get or yum decide where to install from?

I can take your two questions @sumedhpathak…

Have we tried installing from PGDG first (say Citus 5.1), and then installing the packageCloud repo? Will they conflict with package names?

The package names are the same, but the versions provided are not. Users would type e.g. apt-get install postgresql-9.5-citus and they'd get the latest Citus from whatever sources they've got available (PGDG and packagecloud).

Also, since the same package name is available from both PGDG and PackageCloud, how does apt-get or yum decide where to install from?

It'll install the package with the highest version. I'm about to run a test to see what happens when the version numbers are the same…

By version you mean 5.2.0? If we add to PGDG then both will be the same. So
do we need to stop adding our packages to PGDG to make sure the download
only happens from PackageCloud?

Sumedh

On Thu, Aug 11, 2016 at 3:34 PM, Jason Petersen<EMAIL_ADDRESS>wrote:

I can take your two questions @sumedhpathak
https://github.com/sumedhpathak…
Have we tried installing from PGDG first (say Citus 5.1), and then
installing the packageCloud repo? Will they conflict with package names?
The package names are the same, but the versions provided are not. Users
would type e.g. apt-get install postgresql-9.5-citus and they'd get the
latest Citus from whatever sources they've got available (PGDG and
packagecloud).
Also, since the same package name is available from both PGDG and
PackageCloud, how does apt-get or yum decide where to install from?
It'll install the package with the highest version. I'm about to run a
test to see what happens when the version numbers are the same…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/citusdata/citus_docs/pull/139#issuecomment-239314076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACeeC3znj8PFuB_NiiQHLiMATH91DrbLks5qe6ODgaJpZM4Jgptn
.

--
Sumedh Pathak
Citus Data
650.422.9797
<EMAIL_ADDRESS>

By version you mean 5.2.0? If we add to PGDG then both will be the same.

So it turns out package versioning is way more complicated than this. Debian has the epoch, upstream version, and debian revision fields, all of which affect ordering. Red Hat has Version and Release fields, but the method for comparing them is so complex it's easier to install a tool to tell you which of two versions is actually greater.
The important part is to ensure—for a given "upstream" (i.e. tag) version—that the packagecloud version sorts higher than the PGDG one. This should be pretty easy to tackle by abusing the release fields, though I need a sec to verify it.

For instance, the last version in both PGDG and packagecloud is Citus 5.1.1 for PostgreSQL 9.5, but the actual names of those two versions are 5.1.1-1.rhel7 (PGDG) and 5.1.1-1.el7.centos (packagecloud).

So the "-1" is the release right? Can modifying that force an ordering?
On Thu, Aug 11, 2016 at 3:52 PM, Jason Petersen<EMAIL_ADDRESS>wrote:

For instance, the last version in both PGDG and packagecloud is Citus
5.1.1 for PostgreSQL 9.5, but the actual names of those two versions are
5.1.1-1.rhel7 (PGDG) and 5.1.1-1.el7.centos (packagecloud).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/citusdata/citus_docs/pull/139#issuecomment-239317356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACeeCxfJdZWnJKrf70nyndHqZIoZkBWPks5qe6eVgaJpZM4Jgptn
.

--
Sumedh Pathak
Citus Data
650.422.9797
<EMAIL_ADDRESS>

Can modifying that force an ordering?

Yes. And it appears (for Red Hat) that simply changing -n to -n.0 is sufficient. Figuring out Debian now.

BTW there are ways of setting "priorities" for repositories, but that's something usually hand-set by a sysadmin if they care (and they probably wouldn't like us jacking up our priority). In addition, that's mostly a Debian feature, and to do priorities in Red Hat requires a non-standard Yum plugin. So I'm going to go with the "ensure our versions sort higher than theirs" solution.

Yes. And it appears (for Red Hat) that simply changing -n to -n.0 is sufficient. Figuring out Debian now.

OK, so the stupid-simple most easy solution is to just use the Epoch field, which I've so far been avoiding. It's used to break the timeline of a package for when the upstream provider changes versioning practices and you need to somehow force the newer versions to be higher than the older ones in the case where that wouldn't happen lexicographically (see stuff like OpenSSL with bizarre versioning practices).
So we'll just force our own builds to use an epoch higher than PGDG's. Since they won't change that number, we're in the clear.

I see. So is epoch only a Debian concept? Could you clarify on approaches
now for Debian and RHEL?
And how does this impact our packaging? Do our automated builds now have a
higher epoch and we special build for PGDG?
Thanks!
On Thu, Aug 11, 2016 at 4:05 PM, Jason Petersen<EMAIL_ADDRESS>wrote:

Yes. And it appears (for Red Hat) that simply changing -n to -n.0 is
sufficient. Figuring out Debian now.
OK, so the stupid-simple most easy solution is to just use the Epoch
field, which I've so far been avoiding. It's used to break the timeline of
a package for when the upstream provider changes versioning practices and
you need to somehow force the newer versions to be higher than the older
ones in the case where that wouldn't happen lexicographically (see stuff
like OpenSSL with bizarre versioning practices).
So we'll just force our own builds to use an epoch higher than PGDG's.
Since they won't change that number, we're in the clear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/citusdata/citus_docs/pull/139#issuecomment-239319799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACeeC7RoWq7S5rDtZwZAfe0EARpLdJkWks5qe6qigaJpZM4Jgptn
.

--
Sumedh Pathak
Citus Data
650.422.9797
<EMAIL_ADDRESS>

I added a minor note on a comment. Apart from that I tested this, and it looks good! Packages installed are also 5.2.0 release ones. Good to 🚢


Context timeout interceptor

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.anonymous seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Part of https://pachyderm.atlassian.net/browse/CORE-281


Include git or otherwise address "current commit information was not captured by the build: git was not found in the system: ..."

When I use the docker image as a build step in Google Cloud Build to perform buildx builds, I get the following warning:
WARNING: current commit information was not captured by the build: git was not found in the system: exec: "git": executable file not found in $PATH

I presume this has to do with provenance being enabled by default per https://docs.docker.com/build/attestations/slsa-provenance/#mode
I would like to be able to use the docker image to run docker buildx ... and have the provenance information captured as designed by the new default. I know about the option to suppress the warning by using BUILDX_NO_DEFAULT_ATTESTATIONS=1 to disable the feature entirely, but I would prefer to get it working instead.
As an end user I have no preference between what I presume are the two possible solutions:

Modify the provenance feature to extract the required information without running git as a child process.
Add git to the docker image.

(I'm opening this issue here because I presume the second option is much more reasonable to implement.)

Additional context:
Unlike CI/CD environments like GitHub Actions where you could have an apt-get install git step make git available to later docker buildx ... steps, in Google Cloud Build every step (including invocation of docker) happens in a new docker container of the step's specified image, with only specific shared mounts being available to persist/pass artifacts and state between steps.
To work around the lack of git in the upstream docker image by adding it in to steps that run buildx, you'd wind up doing something equivalent to docker run ... docker /bin/bash -c 'apt-get update; apt-get install git; docker buildx ..." for every "run docker" step in the build definition.

The docker:git image includes the git package. Please try using that.

That does work, thank you for pointing it out.
I guess there remains an open question of whether it's appropriate for the default to not include git, given the dependency on it added upstream. In other words: should 'docker' and 'docker:git' be made the same?

When looking through my (GitLab) build logs I ran into this and figured that #483 does not exactly solve this: it looks like this message requires the git binary within the cli variant rather than within the dind variant.
As an example, I set up a very minimal GitLab repo using a reduced version of GitLab's example Docker CI template to build a Hello World image. This results in the build reporting the aforementioned warning, which is not present when dind is also used to build the image (see https://gitlab.com/jnoordsij/test-docker-ci/-/jobs/7215262223).
Therefore I was wondering:

Is a follow-up to #483, moving the git install from dind to cli, appropriate? This might once again boil down to size comparison?
Or should instead GitLab's template be updated to use dind both as service and image? This feels a bit off to do, but given we're already pulling in the larger dind image, this probably is not an issue? Or is there some dind entrypoint logic that might hurt performance in some way?

Note: if this should be (re-)opened and/or discussed elsewhere, let me know!

Oof, yep, looks like Git is indeed appropriate in both CLI and DinD now. :disappointed:


If a value is already selected and then i open the dropdown, it gets autoscrolled to this preselected value.

1.Selected a value and clicked out
2.Opened the dropdown again
3.It gets autoscrolled to this previous selected value
It makes sense for large list, but not with 12-15 items.Please provide an option to turn this autoscroll off.
Thanks and Regards.

disableAutoScroll prop added to disable auto scrolling in v1.6


cognitive service tts

make http call to cognitive service for speech systhesis

@w-Yuan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


THEEDGE-1922: Add temporary indexes to relieve production issue

Description
Add temporary indexes to devices table to relieve production issue with pegged CPUs.  Index refinement will be addressed later.
Fixes # THEEDGE-1922
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[X] Tests update
[ ] Refactor

Checklist:

[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] I run go fmt ./... to check that my code is properly formatted
[X] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #787 (12d8de0) into main (0a85349) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   31.23%   31.23%
=======================================
  Files          44       44
  Lines        4809     4809
=======================================
  Hits         1502     1502
  Misses       3106     3106
  Partials      201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a85349...12d8de0. Read the comment docs.


MAINT: WIP: Add checks for NaN to peak finding functions

As suggested in #8705 this PR adds if statements that check for NaN in the supplied vector x and raise a warning if one is found to the functions find_peaks, peak_widths, peak_prominences in the signal module.
@larsoner I'm not to happy with this. The simplest  & fastest solution I could think of is to check with np.isnan(np.sum(x)) for a NaN value. However this adds a noticeable speed penalty (up to ~10%) for in my opinion very little benefit.
But I will leave this decision to more experienced devs. ;)

Hmm I didn't think of the performance penalty. You could put it in the Cython code but this will hurt, too.
This might be a good case for putting a .. warning:: in the Notes of the docstring, even it's something we otherwise do sparingly.

Some additional notes:

np.isnan(np.max()) or np.isnan(np.min()) are slightly faster but fail for empty arrays.
Using libc.maths isnan in Cython might be faster solution while iterating anyway. But makes the code more complex because not every relevant array is iterated in a straightforward way from 0 to end (e.g. nested loops, skipping edge samples, ...). So this would definitely require more thought.

This might be a good case for putting a .. warning:: in the Notes of the docstring, even it's something we otherwise do sparingly. -- @larsoner

That's in my opinion the best solution for the time being. For 1.2 I'll try to think of a to integrate libc's isnan in a non-intrusive way.

I suggest that the current notice in the docstring is enough until feedback shows that a raised warning or other measures are needed. Otherwise please feel free to reopen or comment.