2.x Minor update to batching integration test.

NetflixOSS » eureka » eureka-pull-requests #283 SUCCESS
This pull request looks good


Petition: Styled sidemenu

Hi, i was looking for some sidemenu styled for ios and android, can you add it as an example on your app?
Will appreciate it so much :)
Thank you so much

Hey @Fdom92, no problem at all.
Take a look at this branch I just pushed.
It's a work in progress, but you can start to get a few ideas from there.

I'll make a few other styles, but at the moment there are two new sidemenus:

One with avatar
Small one on the right side

Take a look:

Looks awesome :open_mouth: Great job!! :clap:

Added material design side menu too. I integrated everything on master, you should be able to get it from the latest commit: e1aca4f.

Thank you so much @yannbf 👍


Rename Labels to Attributes.

I did git mv on all the files, but don't know why git decided to not see all of them as moved files.

I did git mv on all the files, but don't know why git decided to not see all of them as moved files.

git only infers renames from the similarity of files, so git mv is just a shortcut for removing and then adding a file: https://git.wiki.kernel.org/index.php/GitFaq#Why_does_Git_not_.22track.22_renames.3F .  I think that git would be more likely to show files as moved if you moved them and edited them in separate commits.

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is 96.77%.

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     94.21%   94.21%
  Complexity      352      352
=========================================
  Files            47       47
  Lines          1038     1038
  Branches         65       65
=========================================
  Hits            978      978
  Misses           42       42
  Partials         18       18

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/google/instrumentation/trace/Span.java
100% <ø> (ø)
8 <0> (ø)
:arrow_down:

...va/com/google/instrumentation/trace/BlankSpan.java
100% <100%> (ø)
9 <2> (ø)
:arrow_down:

...a/com/google/instrumentation/trace/Attributes.java
100% <100%> (ø)
6 <6> (?)

...m/google/instrumentation/trace/AttributeValue.java
94.44% <85.71%> (ø)
17 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6294e...d835ecd. Read the comment docs.


[Enhancement] Allow conference search to use tags

Purpose
This PR resolves this issue: #2831
Changes

Treebeard has been updated to allow for including filtering on columsn that are not visible
Tags are provided as a data point in the back end
hiddenFilterRows option is added to conference

Side Effects
Because of the commit order issue with Treebeard to make sure this works it needs to go in AFTER this PR is merged: https://github.com/CenterForOpenScience/osf.io/pull/2852
Although this is not absolutely necessry (the changes in treebeard are not breaking changes) it's best to be safe with production code and not need to test things again. I will be more careful about order of commits for future fixes.

I don't know why this error is occuring.  @lbanner @GaryKriebel any ideas on who can take a look at this?

@caneruguz , might you know if the travis error revolves around search itself and perhaps @fabianvf could lend assistance?

Build failed because of flake8 issues.

Yes apparently I'm bad at reading build messages :/
Thanks Fabian!

@caneruguz, can you bring this up to date with develop? Looks like you have some merge conflicts.

@sloria this should be ready to look through.


FacebookUser picture field updated

I saw that the FacebookUser picture field was typed incorrectly. Facebook provides additional detail beside url, like width, height or is_silhouette, all within picture.data field

Can you update the type in the docs (documentation-v2)?


Feat/Nodes: Change Input to Textbox

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[X] No, because:
not yet, making pr to show

Have you updated relevant documentation?

[ ] Yes
[ ] No

Description
Temp Change Node String input to a textbox, to allow easier input of prompts and larger strings, it works for me but please tell me if I did it wrong and if the size is ok
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

It's an improvement over the current string input because it handles multiple lines, but it takes up a lot of space! Is there a way for the textbox to resize along with the node panel? When I try to resize, I can only do it horizontally and the textbox inside stays the same fixed size (see video). cinnamon-2023-07-20T094429-0400.webm

@lstein I made height smaller and and changed width to resize with node width
(Since only width can be resized on most nodes)

I'll defer to @blessedcoolant for approving this as an interim QOL improvement. We did just merge in some code quality changes so you may need to do a bit of fiddling with the PR to make it happy. (the lint frontend action needs to pass before merge)

I'll give this a run later today and see how it feels.

@blessedcoolant I made the code much more simple, if you feels its a good temp fix please use, if not worth while I can just close the pr

@mickr777 Sorry I didn't get to this earlier. Been so busy. Just went through it. Seems good. Thanks for the PR.
While this is not how we might do it in the long run, it works for now as a QoL feature. I made a few chanages.

I updated even the Style slot of the Refiner to take a text area.
I added a new Prompt node which is basically a duplicate of the String node but instead is named prompt so the frontend can display a text area rather than a input box. We can remove this node once we add proper support for conditional rendering of a node in the future.

Seems good. I'll merge in when checks pass.


Unreliable image cache due to hash collisions

In "FSImageLoader.m" on line 79 [NSString hash] method is used to create a cache key:
NSString *cacheKey = [NSString stringWithFormat:@"FSImageLoader-%lu", (unsigned long)[[aURL description] hash]];

This causes problems with long image URLs, because "hash" method of NSString only uses 96 characters to generate the hash (first 32, last 32 and middle 32). Basically if your URLs are over 96 chars in length, there is a good chance of getting the same cacheKey for two different URLs. I run into this problem because I had a bunch of long, similar URLs where the only difference was the product id (starting at char 39).
This article describes the problem in detail.
Would it be possible to use a more robust hash function? Here is an implementation using MD5 hash:
- (NSString *)getMD5ValueForURL:(NSURL*)aURL {
    const char *urlString = [[aURL absoluteString] UTF8String];
    unsigned char hashBytes[CC_MD5_DIGEST_LENGTH];
    CC_MD5(urlString, strlen(urlString), hashBytes);

    NSMutableString *hashString = [NSMutableString stringWithCapacity:CC_MD5_DIGEST_LENGTH * 2];
    for ( NSInteger i = 0; i < CC_MD5_DIGEST_LENGTH; i++ ) {
        [hashString appendFormat:@"%02x", hashBytes[i]];
    }

    return hashString;
}

Sorry for the delay - is now in version 3.0


[TypeScript] Add readMetadata() and readAttachments() methods to McapIndexedReader, add validateCrcs arg to readMessages(), export parseRecord and parseMagic

Public-Facing Changes

[TS] Adds readMetadata() and readAttachments() methods to McapIndexedReader
[TS] Adds validateCrcs arg to readMessages()
[TS] parseRecord() and parseMagic() methods for lower-level parsing of MCAP data

Description
Adds support for metadata and attachments in the TypeScript indexed reader, and exposes two lower level parsing methods for
situations where you are manually reading MCAP data and want to parse the header or individual records.

Unit tests?


Discrepancy in the operation of failureSeverities?

What
I am trying to test the failureSeverities. According to README

The other option is to provide failureSeverities if you still want to show the query in the results, but you don't want it to fail the execution. By default this is set to [Severity.HIGH, Severity.MEDIUM].

As per above understanding failureSeverities property will not fail the execution on HIGH and MEDIUM category severities as they are default in other words it will fail deployment on LOW severities.
This also means if I pass LOW as key it should pass the deployment.

Expected Behavior

I wanted to deploy and only see the report, going by the readme since high and medium are default, I tried to pass the LOW in order to pass the deployment

import { Duration, Stack, StackProps } from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import * as s3 from 'aws-cdk-lib/aws-s3';
import { Construct } from 'constructs';

export class CdkLeftShiftStack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    new s3.Bucket(this, 'MyFirstBucket');

    const queue = new sqs.Queue(this, 'CdkLeftShiftQueue', {
      visibilityTimeout: Duration.seconds(300)
    });

    const topic = new sns.Topic(this, 'CdkLeftShiftTopic');

    topic.addSubscription(new subs.SqsSubscription(queue));
  }
}

const app = new cdk.App({
    policyValidationBeta1: [new KicsValidator({
        failureSeverities: [Severity.HIGH,Severity.MEDIUM,Severity.LOW],
    })],
});

Even If I explicitly pass this it still fails the deployment.

Is the above behaviour intended?

Actual behaviour

No matter what value I pass deployment fails which contradicts README

PLUGIN.ts comments means the OPPOSITE

List of severities which should cause the

execution to fail

However the plugin.ts comments says the completely opposite which makes sense as per above comments and behaviour.

Additional context

IMO there is typo of dont.  It should be The other option is to provide failureSeverities if you still want to show the query in the results, but you want it to fail the execution. By default this is set to [Severity.HIGH, Severity.MEDIUM].

I tried to verify the above where I want to pass the deployment

const app = new cdk.App({
    policyValidationBeta1: [new KicsValidator({
        failureSeverities: [],
    })],
});

As expected deployment pass but this is 50 % correct as I was expecting it to show the findings in the report which it didnt and reported as success. Again is this too intended?

@cxMiguelSilva @gabriel-cx
Is the above intended?

Hi @jatinmehrotra,
Yes, I agree with you, the flag description is confusing. The following mapping represents how the flags are linked with the engine flags:

CDK Kics Validator Plugin
KICS engine

failureSeverities
--fail-on

excludeSeverities
--exclude-severities

engine docs: docs.kics.io
We will update the readme to better explain the fail-on/failureSeverities behavior
Regarding the Additional context, we will need to investigate and see that the report is shown even if is deemed as passed.

@cxMiguelSilva
Thank you for you acknowledging.
I would have send the PR for fix( since I understand how build works 😄 ) but  the additional context behaviour is unclear to me so I will wait for your results

Hi @jatinmehrotra, hope you are doing great!
Firstly, I want to apologize for the late response to this topic.
Regarding the doubt present in the additional context, I was able to see how the evaluation is done, and what is passed to the aws cdk. All that logic takes place here . The return parameters are defined by the interface available on the aws cdk (docs here).
Concluding, to present the violations, even though they are not specified as failure ones, there will need to be a specific logic implemented on the aws cdk side. Let me know what you think.


Adds an origin function

The origin consists of only the scheme and authority. This change adds the following ways to work with the origin:
URI.buildOrigin(parts);
u.origin()
u.origin(uri)

The PR only contains the unit tests at this point, right?

also please re-open the PR against the master branch

Whoops weird, I was in the test dir and git add . didn't work as expected. my bad. I will re-open sorry for the confusion.


Include movementId in JSON response

And as discussed in today's coordination call we'll support a URI for each worker and each movement, which will be included in all JSON responses everywhere, so that data can also be forwarded safely.

And as discussed in today's coordination call we'll support a URI for each worker and each movement, which will be included in all JSON responses everywhere, so that data can also be forwarded safely.

I'll try to find some time to work on this before our next coordination call.

I see that the JSON response to worked-hours currently echoes the movement.
I confirm we need the movement ID so I can later issue an update-entry for the same movement ('Entry' in timeld).

worked-hours now returns movementId and statementId, see #131.


Problema in Xamarin.Forms project for Android

I'm having the following problem in an XForms project for Android: Push notification error - CrossPushNotification - Register - Java.IO.IOException: Exception of type 'Java.IO.IOException' was thrown.
In this project that is working for iOS I use PushSharp on my server.

Seems to be a networking issue. Where are you calling the register method?

I call the method:
public partial class App: Application
{
...
     protected override void OnStart ()
     {
       // Handle When your app starts
       CrossPushNotification.Current.Register ();
     }
...
}
But OnRegistered event CrossPushNotificationListener class (IPushNotificationListener) is not firing.

Have you initialized the plugin?

Yes. I do the method CrossPushNotification.Initialize("") in MainActivity.cs of the Android project. And I do the method CrossPushNotification.Current.Register() in OnStart event of the PCL project (App.cs).

Did you get working?

No, I didn't. Works with iOS, but with Android not.

rdelrosario, I discovered the error. The problem is that in the Android application, OnRegistered event triggers only on the first application running on the device. After the first run the event does not fire. Not that it's a problem, but I did not foresee this.
Thank you.

Yes it prevents multiple time registration. Why you will like to register it if it's already registered?

I think this may be a mistake. IOS project this event is triggered every time the application starts. The Token value on evento OnRegistered for Android seems to me what's wrong. Do you have an example using the plugin for Android?

I will fix this for iOS, so it triggers just one time because shouldn't be registering each time.

I am using visual studio 2015 and XF 2.0. After adding these packages related to notification plugin to my solution, android application fails to deploy onto device (iOS is working properly). Any idea what might be causing this?

What error are you getting?

Strangely there are no errors. In the output window I see the following message
check to make sure that in your build configuration build and deploy both are checked (not exactly the same text, but semantically that is what it says).
Hope this helps.
I though I had enable some of the device permissions (such as INTERNET etc.). I tried to enable quite a few options. Still it was failing to deploy.

Ok here is my skype: rendyleonel

I concur about a sample project on the best way to implement everything. Not exactly sure how this all should work with Android.

I think this is the updated link from above.
Though, I'm still confused on how to implement in Android to receive the device token and when a message is received. Looking at part two from the link, it still doesn't seem to show that.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/networking 215bac9...aded181:
  > aded181 upgrade to latest dependencies (# 709)
bumping knative.dev/hack 8d1e4cc...36b2b3c:
  > 36b2b3c add flag (# 224)
  > 547a2ca Start Signing our Releases (# 198)
  > 6c30196 :broom: Rewrite unit tests in Golang (# 215)
  > f9dc722 Format go code (# 218)
  > 664eac5 Fixing go.mod foreach (# 217)
  > 97fd663 :gift: Support multiple Golang modules in a single project (# 205)
  > f472a96 fix go run invocation of github hub cli (# 212)
  > 7d3bed1 go run... (# 210)
  > e81d63a Update community files (# 209)
bumping knative.dev/pkg 4a03844...93b66e6:
  > 93b66e6 Update: report stats for request (# 2584)
  > a650186 Make request body available in admission context (# 2583)
  > a6afcab Fix # 2115, allow selective verbs / subresources for webhooks. (# 2547)
  > da71919 split warnings. Fix issue: 2581 (# 2582)
  > 0a3c1d6 upgrade to latest dependencies (# 2580)
  > 5fbe0c3 upgrade to latest dependencies (# 2579)
  > 2f06d64 Update community files (# 2578)
  > 2e08ca6 WaitForServiceEndpoints doesn't take into account not found endpoint (# 2576)
  > 766f70d fix double close of channel (# 2574)
bumping knative.dev/control-protocol f18dbde...9d1dfb4:
  > 9d1dfb4 upgrade to latest dependencies (# 211)
  > ca2ee05 Update community files (# 212)
  > a445e80 Update community files (# 210)
  > 135d247 upgrade to latest dependencies (# 209)
  > 6e8fbec upgrade to latest dependencies (# 207)
  > bc5f36a Update community files (# 208)
  > 70a130b Update community files (# 206)
  > afcea2f :broom: Accommodate to knative-sandbox/reconciler-test# 294 (# 197)

/lgtm
/approve


Avoid a crash with @typedef in a script file.

Scripts (as opposed to modules) do not have a symbol object. If a script
contains a @typdef defined on a namespace called exports, TypeScript
crashes because it attempts to create an exported symbol on the
(non-existent) symbol of the SourceFile.
This change avoids the crash by explicitly checking if the source file
has a symbol object, i.e. whether it is a module.

@DanielRosenwasser I'm a bit unsure whether this PR should go against release-3.6 or master. Let me know and I can re-cherry-pick/re-base, it applies cleanly against both.

@typescript-bot cherry-pick this to master

I'm not entirely sure about the fix, but I've (hopefully) requested a cherry-pick anyway.

@DanielRosenwasser bummer. Should I change this PR to be against release-3.6 or leave it like this?

Try retargetting the PR to master and let the bot cherry-pick to release-3.6 - I don't think it's setup to be capable of a clean squash and pick from an older release back to master, but the other way should be OK.

@typescript-bot cherry-pick this to release-3.6

@weswigham done, though I think @typescript-bot doesn't listen to my commands (and is wrong about the lib update).

@typescript-bot cherry-pick this to release-3.6

All good to merge @weswigham @sandersn?

@sandersn would you re-review now that I've pushed a different change up, that tackles the issue closer to the source?

@typescript-bot cherry-pick this to release-3.7 i guess now?


Use hash based renaming for dependencies

This patch implements content based renaming for dependencies.  So instead of giving variables names like: Light_2_3_4_..., the new naming scheme renames variables to Light_<hash> where hash is a hash of the dependency index and the arguments to the bundle.  This reduces code duplication due to nested dependencies and also makes reusing structures between modules (as in the complex dependency case) easier to do.
One problem right now though is that preprocessor macros aren't renamed.  I think that this is a bug in glsl-descope-tokens, but I'm not sure.  @hughsk or @mattdesl: Do you know how glslify-bundle handled renaming macro tokens (like #define PI 3.14...) previously?

Thanks @mikolalysenko! This looks super promising. Unsure what's causing macros not to be renamed, I believe that was working previously? It would rename any macros that weren't in the entry file. I'll review over this weekend and keep you posted :)

https://github.com/stackgl/glslify-bundle/commit/631d8176f09ce3bf8a679b700eb25f283b68bb18 made macro renaming work before :)

@hughsk thanks, all fixed now.

Maybe in the future it might make some sense to scope macros to individual files so that they don't leak out of a particular module.  As a hack, one way we could do this is just stick a bunch of #undef's at the end of each file after it is imported.


119 enhancement toolbar region

Added the toolbar buttons as Icons.

There're still some inconsistencies concerning both toolbar buttons' resizing and the Save button default theme.

There're still some inconsistencies concerning both toolbar buttons' resizing and the Save button default theme.

Resizing of the toolbar and colors will be fixed by @tesourinha in a second PR

Approved.
PS: The pr yet has some inconsistencies and bugs which need to be addressed in the next prs.


Add sticky warning footer for HF2

Somehow a bit more sketchy to add a top banner warning.
So instead it's a sticky red warning footer which does the job too.
Screenshot:

Good stuff @quentinlesceller! 👍 I had a quick glance but not tested myself, merging however and let’s improve as we go


C# 6.0 String Interpolation

Text highlighting for string interpolation is incorrect for C# 6 interpolation syntax
prettify (as used by stackoverflow) highlighting:

Visual Studio 2015 highlighting:

i.e. if the string is prepended with a $ then {something } should be highlighted as normal C# code, not as string literal.

:+1:

Currently the C# handler only detects:

single line strings, both 'single' and "double" quoted (with \ to escape)
verbatim strings: @"C:\some\path" (with "" to escape)

Interpolated string such as $"hello {name}" are treated as regular strings with a punctuation character in front.
While it would be nice to have, I doubt string interpolation could be fully handled using just regexps; These things can get complicated with embedded conditions $"result is {(condition ? if_true : if_false)}.", like another block of code inside the string, which IMO is difficult to properly prettify without a full parser.

Implementation-wise, here are the relevant parts from prettify.js:
  registerLangHandler(sourceDecorator({
          'keywords': CSHARP_KEYWORDS,
          'hashComments': true,
          'cStyleComments': true,
          'verbatimStrings': true,
          'types': C_TYPES
        }), ['cs']);

and
function sourceDecorator(options) {
    if (options['tripleQuotedStrings']) { ... }
    else if (options['multiLineStrings']) { ... }
    else {
      // 'single-line-string', "single-line-string"
      shortcutStylePatterns.push(
          [PR_STRING,
           /^(?:\'(?:[^\\\'\r\n]|\\.)*(?:\'|$)|\"(?:[^\\\"\r\n]|\\.)*(?:\"|$))/,
           null, '"\'']);
    }
    if (options['verbatimStrings']) {
      // verbatim-string-literal production from the C# grammar.  See issue 93.
      fallthroughStylePatterns.push(
          [PR_STRING, /^@\"(?:[^\"]|\"\")*(?:\"|$)/, null]);
    }
    ...
}


Add codecov

This is still work in progress (Draft), comments are welcome!
Codecov link:
https://codecov.io/gh/open-telemetry/opentelemetry-js/commit/3e91703b4528c55be22c2f001b2c957456b23ce9

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9a56922). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #64   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      2
  Lines             ?     12
  Branches          ?      0
=======================================
  Hits              ?     12
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a56922...4bfc111. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9a56922). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #64   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      2
  Lines             ?     16
  Branches          ?      0
=======================================
  Hits              ?     16
  Misses            ?      0
  Partials          ?      0


Error when powershell.exe is not in the PATH

I don't have C:\WINDOWS\System32\WindowsPowerShell\v1.0\ in my PATH because I use the portable PowerShell, which is installed as C:\Program Files\PowerShell\7\pwsh.exe. It could be possible to check if it exists and use it before trying the windows build-in?
jenv change openjdk17
'Powershell.exe' is not recognized as an internal or external command,
operable program or batch file.

This will be implemented in Version 2 a complete rewrite of this application which should be more scalable and support tests as well as being more close to the original

version 2 is now published and contains this feature.
Please report any bugs.
Thank you for your suggestion

Ah, damn it. Github closed it because of my commit message. I pushed an update. Now JEnv asks you to restart with admin rights so it can change the system path. Thank you for your suggestion. Please report any further problems


Implement Unobstructed-Area support

Please implement support for Unobstructed-Area (Since Pebble os 4.0) as described here: https://developer.pebble.com/guides/user-interfaces/unobstructed-area

This is a top priority item! Now that I've gotten builds working again, getting this implemented will be this weekend's project!

Added in latest version


strain: Implement canonical-data.json

We want to have a standard set of test inputs and outputs for each exercise to
make it easier to port them to new languages, as well as to help keep the
exercises in sync.
The Strain exercise can be found in the ./exercises/strain/ directory.
The step-by-step instructions for how to compile a canonical-data.json file is
described in this section of the contributing guide.
See http://exercism.io/contribute/canonical-data/strain for the up-to-date list of
language tracks that have an implementation of the Strain exercise.
The tracking issue has more context.

Strain should be folded into list-ops and deprecated.


Homepage UI overhaul

Progress

Stats section added

📝 Changed routes:

/

(view full size)

Commit f86c3fc1e89260f177a8d5fc68ab11c3e922f56d (https://thirdweb-d9sfd0rqr.thirdweb-preview.com).


Anonymous DNS relays not working for some of our servers

I can't seem to get some of our anon relays working correctly.
I think it's the same issue as https://github.com/DNSCrypt/dnscrypt-proxy/issues/1578 and  https://github.com/DNSCrypt/dnscrypt-proxy/issues/1346, with encrypted-dns as the server, dnscrypt-proxy (latest) as the client.
I get the "couldn't be reached anonymously" warning when I try scaleway-fr via our Switzerland relay @ sdns://gQ84MS4xNy4zMS4zNDo0NDM, but when I try our Latvia one @ sdns://gRMxMDkuMjQ4LjE0OS4xMzM6NDQz it works fine. If I turn on debugging I get that "[DEBUG] [scaleway-fr] drops fragmented queries" mentioned in https://github.com/DNSCrypt/dnscrypt-proxy/issues/1346
That's weird though because I can't think of any reason why fragmentation would be happening. The two servers are almost identical. Both have the same encrypted-dns version, same config (aside from different local/external/upstream IPs [all local IPs on the same server]), same kernel, same OS, same sysctl.conf, same iptables ruleset (cept different IPs). Ethernet driver is different (e1000e and r8169) since different NIC brands, but I don't think that's causing this. ifconfig shows the MTU and txqueuelen is the same for both. I even tried tcpdump on both servers (filtering out my ip) and I can't see any significant difference between the two UDP streams.
There probably is some UDP fragmentation going on somewhere, or the code that's detecting fragmentation isn't doing that correctly, because if I try the Switzerland and "force tcp = true" in the client's dnscrypt-proxy.toml, it relays for scaleway-fr correctly.
I dunno what else to try :-(

I had the same problem you described and in tickets #1578 and #1346. I couldn't figure it out and didn't make any sense why the anonymizing relaying wasn't working.
The way I got it to work was setting all of the dnscrypt parameters and anonymizing routes to what I wanted, setting
force_tcp = true (this is the key), and then restarting the container. Following this procedure, the servers were anonymized and everything worked as expected. After the connection was established and relaying working like I wanted it to, I simply changed force_tcp = false and restarted the container. Since then, I've restarted the container multiple times and the anonymizing has been fine over UDP.
(If, for whatever reason, the relaying stops working again, you should be able to set force_tcp = true again it should work over TCP.)

Unfortunately, I have no idea why this is happening. I've never had any fragmentation issues ever :(

hrm, if I remove from https://github.com/DNSCrypt/dnscrypt-proxy/blob/master/dnscrypt-proxy/serversInfo.go#L450 the code
	if knownBugs.fragmentsBlocked && relay != nil && relay.Dnscrypt != nil {
		relay = nil
		if proxy.skipAnonIncompatibleResolvers {
			dlog.Infof("[%v] couldn't be reached anonymously, it will be ignored", name)
			return ServerInfo{}, errors.New("Resolver couldn't be reached anonymously")
		}
		dlog.Warnf("[%v] couldn't be reached anonymously", name)
	}

it seems to work fine with the above CS Switzerland relay to scaleway-fr, so I'm guessing fragmentsBlocked is getting set.
Looks like that happens on the line after https://github.com/DNSCrypt/dnscrypt-proxy/blob/master/dnscrypt-proxy/dnsutils.go#L332 -
option := _dnsExchange(proxy, proto, query, serverAddress, relay, 480)
option.fragmentsBlocked = true

if I fiddle with that 480, it'll start working at 1440. 1439 or anything below will cause the "couldn't be reached anonymously" error. The MTU for eth0 is set to the default 1500 on both servers, so that's probably not it.
Reverting back to the original code and sniffing packets on our Moldova relay, which does work correctly shows:

So fragmentation is happening there.
On our Latvian relay, which does NOT work correctly it only shows:

So fragmentation isn't happening there. But the weird thing is that fragmentation works fine on that server. If I connect to the VPN there and do things that would cause UDP fragmentation, tcpdump -nni any '((ip[6:2] > 0) and (not ip[6] = 64))' shows it's happening correctly, nothing blocking it. Even simply connecting to the regular DNSCrypt part of the encrypted-dns-server running there will cause fragmentation to happen, and that goes through just fine. So something in either dnscrypt-proxy or encrypted-dns-server is causing that relay fragment test to fail.

The intent of that code is to simultaneously send packets padded to 1500 bytes (triggering fragmentation) and the same packets padded to only 480 bytes.
If 1500 bytes packets don't get a response, but 480 bytes do, if means that the server is functional, but blocks fragments.
Is the server detected as usable at all when you raise 480 to 1480 or more?
Maybe that parallel check doesn't work as intended. I need to take a closer look at it.
While disabling these checks, can you successfully get large responses? You check for example check with test-tcp.dnscrypt.info after having bumped up the max UDP packet size in EDNS.

Yes, the server is detected as useable with 1480 and up (tested 1480-1499). One thing I noticed is that dnscrypt-proxy starts up almost instantly with a server that's working correctly. The timestamp for startup, "[2021-03-29 16:14:31] [NOTICE] Anonymizing queries for [scaleway-fr]", etc. is all within the same second by the time it reaches "dnscrypt-proxy is ready". Whenever that padding is changed to something below 1440 (for the broken relays that require 1440+), there's at least a 5 second delay before it fails, or if set to 1440 and up, 5 seconds by the time it succeeds. Maybe a timer or timeout somewhere is the culprit?
And yes, large responses work too. I was testing with balancer.cstorm.is since it's got 46 IPs, but test-tcp.dnscrypt.info also resolves. With the padding still set to 1499, dig @<IP_ADDRESS> test-tcp.dnscrypt.info switches over to TCP for the response. This is DiG 9.16.13 btw, which has had a lot of EDNS improvements over the years.
Here's what dig +short rs.dns-oarc.net TXT @<IP_ADDRESS> returns:
rst.x1188.rs.dns-oarc.net.
rst.x1198.x1188.rs.dns-oarc.net.
rst.x1204.x1198.x1188.rs.dns-oarc.net.
"<IP_ADDRESS> DNS reply size limit is at least 1204"
"<IP_ADDRESS> sent EDNS buffer size 1232"

That's with the relay at sdns://gRMxMDkuMjQ4LjE0OS4xMzM6NDQz (<IP_ADDRESS>:443, Latvian server, doesn't work with padding below 1440).

Testing with TCP is not really useful here.
With dig I think +bufsize=4096 +notcp is what you should use to avoid tcp
dig is always running behind, but this extension has been around for 12+ years :)

weird, even with dig +bufsize=4096 +notcp balancer.cryptostorm.pw @<IP_ADDRESS> it still switches over to TCP:
18:44:19.446603 eth0  Out IP <IP_ADDRESS>.50339 > <IP_ADDRESS>.443: UDP, length 604
18:44:19.566126 eth0  In  IP <IP_ADDRESS>.443 > <IP_ADDRESS>.50339: UDP, length 304
18:44:19.566326 eth0  Out IP <IP_ADDRESS>.40774 > <IP_ADDRESS>.443: Flags [S], seq<PHONE_NUMBER>, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
18:44:19.601262 eth0  In  IP <IP_ADDRESS>.443 > <IP_ADDRESS>.40774: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 29200, options [mss 1460,nop,wscale 9], length 0

etc. etc. The response still comes through too. Maybe <IP_ADDRESS> (scaleway-fr) is forcing TCP somehow?
And yea, EDNS has been supported for more than a decade, but some improvements have been made as recently as last year.

I though you sent queries directly to a resolver.
Relays will switch to TCP if UDP fails, even though responses to clients will eventually be over UDP.

And yea, EDNS has been supported for more than a decade, but some improvements have been made as recently as last year.

Absolutely zero improvements, besides adding extensions unrelated to UDP packet size :)

I though you sent queries directly to a resolver.
I was sending to dnscrypt-proxy running on localhost on the system I'm testing with (<IP_ADDRESS>), which is relaying through the encrypted-dns-server on <IP_ADDRESS>:443 to scaleway-fr. I assume that the upstream resolver the encrypted-dns-server uses isn't relevant, since with relaying it should just be forwarding to scaleway-fr? Anyways, the DNSCrypt server part of the encrypted-dns-server on <IP_ADDRESS> seems to be working correctly, as is the upstream (PowerDNS recursor on <IP_ADDRESS>:53). The only thing that isn't working is relaying, unless I set that fragmentation to 1440 or higher.

Absolutely zero improvements, besides adding extensions unrelated to UDP packet size :)
heh, well the bind team calls them improvements, not sure if anyone else would though.

Just wanted to leave one last update here, just in case somebody else runs into this issue later with some other data center.
I switched everything over to Arch Linux, but 3 or so servers still suffered from this issue.
Some data centers do block either incoming or outgoing (or both) IP fragmentation for "security reasons".
My guess is that they still have some forgotten rule in some firewall for that ancient teardrop attack.
Anyways, I used this little python script to figure out if IP fragmentation packets were being blocked, and along with tcpdump, which direction the block was occurring:
#!/usr/bin/python
import sys
from scapy.all import *
dip=sys.argv[1]
payload="A"*496+"B"*500
packet=IP(dst=dip,id=53)/UDP(sport=1500,dport=443)/payload
frags=fragment(packet,fragsize=500)
for fragment in frags:
 fragment.show()
 send(fragment)

On the affected server I'd run ./that.py [remote ip] then on [remote ip] I'd run tcpdump to see if the IP frag packets came in.
If not, the server was blocking outgoing fragmentation.
Then I'd do the reverse, ./that.py running on [remote ip] and tcpdump on the affected server.
If that failed, the server blocking incoming fragmentation.
After showing the results of this test to the affected server's DCs, one said:
"It was exactly as your client suspected; we do block fragments for security reasons. We have just started permitting them."
Another said:
"I just removed some port security from the Top Of Rack switch port connected to your server. I think this might solve the problem of the fragmentation packets being blocked."
So if anyone else runs an encrypted-dns-server with Anonymized relaying enabled and dnscrypt-proxy is complaining about something blocking fragmented packets, check with the DC. Use that python script above to show them proof that it's happening and maybe they can remove the block.
I'm still waiting on a response from our Latvia and South Korea DCs, so in the pull request I just submitted that has the most recent resolver/relay IPs, those two aren't included in the relay list. Their DNSCrypt resolvers work fine, but the Anonymized DNS relays would only work with force_tcp = true because of the IP frag blocking.

Wow, thanks a lot for the followup!
This is very useful information and something that should probably added to the main documentation.
That script can also come in handy!
Thanks again, and also for working with these providers to have that issue solved!


gateway api: scope service VIPs to cluster

The current behavior could have a Gateway defined in cluster-1 that writes VIPs from all clusters. Perhaps this is valid for some kind of cross-cluster routing.
My thought is: If we were to have a waypoint in cluster-1 AND cluster-2, we likely only want the cluster-local VIPs being sent to zTunnels.

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test release-notes

lint_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test release-notes

lint_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test lint

gencheck_istio
3454f757c9477e291667b73d257b79cf008664f0
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

IIRC, we donot support multi-cluster gateways, is this for future use?

@hzxuzhonghu if we had a service with the same name in another cluster, this would have grabbed VIPs from those clusters too. This makes it so they're not multi-cluster.


Understanding manual PR comment triggers

I have a long validation build that I want to run only on new commits to master and when explicitly requested in a PR via a comment /azp run Validation.
The YAML for the Validation pipeline contains:
trigger:
- master
pr: none

When I post the "/azp .." comment in the PR then the bot responds with:
> Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
How should this work?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfba9a21-e0f9-4fc6-43fc-bfdc51af31d3
Version Independent ID: d93c7852-ce63-a6d0-417a-45f8cf2fc522
Content: Build GitHub repositories - Azure Pipelines
Content Source: docs/pipelines/repos/github.md
Product: devops
Technology: devops-cicd
GitHub Login: @DavidStaheli
Microsoft Alias: dastahel

I had the exact same problem but finally figured it out.
Setting pr: none in the YAML will disable this pipeline for any PR, even with comment triggers.
That's why AZP is reporting it can't run the pipeline.
So you should either not specify pr or set it to a branch you want to restrict it to. (like pr: master for only PRs targeting master)
Now the problem is that PRs will automatically trigger your pipeline.
To allow only comments to trigger it, you need to follow these instructions:
https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#build-github-pull-requests-only-when-authorized-by-your-team
Note that there is no way of letting one of your contributors (without access to Azure DevOps) to trigger a build with a comment.
The way the docs is structured is a bit misleading here.
Those instructions are mandatory to enable comment triggers, but is put in a subpart which can be understand as optional and there is no mention of pr: none disabling comment triggers.
It took me a while to understand how it was actually supposed to work.

@TimLariviere Thanks for your follow up- tagging as a doc-bug for triage on our side.

@thomps23 2 follow-up questions:

Should it be possible to have 2 Pipelines, where Pipeline1 is triggered automatically (for PRs), while Pipeline2 is (only) triggered via /azp run Pipeline2?

Within an executing Pipeline, do any Variables indicate the Build was Triggered from a PR Comment? I've noticed Build.Reason is still PullRequest for builds triggered with PR Comments.  Build.TriggeredBy.* are unrelated.

@JoeBrockhaus Thanks. We'll consider those questions during triage but I can't put a fine point on when. If this is urgent please consider creating a discussion at Azure DevOps on Stack Overflow.

@JoeBrockhaus We're doing 1, eg. having two pipelines, where one is always triggered (fast, just compiles and runs tests), and the other one only on comment triggers (slower, builds and deploys for QA)

I get similar problem, by run /AzurePipelines run, I get "
Azure Pipelines could not run because the pipeline triggers exclude this branch/path."
Then I tried /azp run slow-pipeline, then it gives "No pipelines are associated with this pull request". But after that, a pipeline actually get run, and I do include the branch. But I keep get the same message when run /azurePipelines run, while a pipeline is actually triggered.

I also have the same issue that @GuuBu  refers..
I get a message of No Pipelines are associated but then it starts

Thanks for the comments in this thread. We updated the doc to clarify the steps needed to enable comment triggers. There are no explicit variables indicating that the PR has been triggered by a comment.

@letmaik @TimLariviere
Hey guys, how you doing?
I hope you are very well!
We had the same problem and checked that is not possible to add a trigger by comment using yaml file.
We solved this problem config the pr flag, like:
trigger: none

pr:
  branches:
    include:
      - develop
      - master
  paths:
    include:
      - packages/*
      - .github/workflows/azure-pipelines # temporary
    exclude:
      - packages/_*

and configure in the azure devOps panel
steps:
Select the pipeline > Edit > Menu(three dots) aside Run > Triggers > Follow the image attached


Black formatting fixed

Add black formatting check in CircleCI and make it pass.
Merge after #24 . Fixes part of #20

I think this is also ready to merge right after #24

Can I fix? If so please approve @nikihowe


compile failed

OS: manjaro (archlinux)
error info:
cquery/build/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory

cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALPREFIX=$HOME/.cquery
-DCMAKE_EXPORT_COMPILE_COMMANDS=YES
make install

-- The CXX compiler identification is GNU 8.1.1
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using downloaded Clang
-- Downloading Clang 6.0.0 (https://releases.llvm.org/6.0.0/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04.tar.xz) ...
-- Extracting downloaded Clang with CMake built-in tar ...
CMake Error at cmake/FindClang.cmake:81 (message):
Error retrieving Clang resource directory with Clang executable.  Output:
/home/damon/.dev/cquery/build/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
Call Stack (most recent call first):
CMakeLists.txt:92 (find_package)
-- Configuring incomplete, errors occurred!
See also "/home/damon/.dev/cquery/build/CMakeFiles/CMakeOutput.log".

Either install libtinfo.so.5 from AUR, which is the supported solution, or use your system's libclang.

Thanks for taking a look, @bstaletic.

@bstaletic
thanks


Serialize performance config to binaries

This will serialize the configs to binary with metadata for version and solver ID(and it will check for mismatches). The binary config data can be added to the Context, which FindSolution will use when available.
The data is stored using msgpack binary data so that parsing is fast(vs text processing), compact, and secure(since the libraries are fuzz tested). I used nlohmann/json to write msgpack instead of the other msgpack library since it provides a simpler API.
Unit tests are added for this. There is no library API implemented yet, as there may still be a discussion about how the API is supposed to work. For now, this just implements the backend functionality.

Under my impression from the discussion last week (Wk46) this performance config issue is still under discussion. We'd both agree and hope this feature request to pass KD (Key Decision) process with full reviews before proceeding with implementation. Thanks!

Under my impression from the discussion last week (Wk46) this performance config issue is still under discussion.

This is why I held off on adding the library API. Those design discussion is mainly about how to interface to MIGraphX not about how MIOpen will implement it.

Closing this since the PR has gone stale.


Vumps

Starting the VUMPS pull request. This is not that close to being merged, as I realize there is a lot more changed in this branch than I realized. We've implemented single-site PW, half of multi-site PW, half of domain wall PW, and all the segment stuff we've done so far (so things work for U(1) but not Zn). I'll just start the PR so we can keep track of things that need to be fixed.

Since we aren't chatting for a week, I'll finalize multi-site PWE by then so that everything but the DW excitations with ZN charges can be pushed.

current state of the vumps branch:

[x] VUMPS single site
[x] VUMPS two-site
[ ] VUMPS with mixer
[x] GMRES
[ ] Switch from arnoldi to  GMRES for generating MPO environments
[ ] fix Zn charges for segment Domain wall excitations
[x] single site plane wave
[ ] multi-site plane wave (exponential scaling partially implemented)
[ ] mulit-site plane wave (DMRG-style with better scaling)
[ ] topological versions for all plane waves
[ ] getting environments in parallel (maybe? might have bad communication overhead....)


NLMCXR_dcm.tgz labels

Can anyone just upload the labels here?

Hi @AlibekJ
Unfortunately, the T&C's of the data sources ask us to direct people to the original source to get the data.


undefined namespace property will compile to "error" code since typescript v2.9.1

Hi guys,
A "error" will be happened when there is have a undefined namespace property, for example, I have such a namespace definition, but lack of some property:
export namespace com {
     export namespace alibaba {
         export namespace constant{
             export interface Constant{}
         }
     }
}

above example  I am forgetting to define a namespace test and the interface demo.
Then I use the v2.9.1 to compile this segment code:
function A(a: com.alibaba.test.demo) {}

Ts will generate the "error" code,
var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
function A([typeof (_e = ((_c = ((_d = (typeof com !== "undefined" && com).alibaba) && _d).test) && _c).demo)) === "function" && _e || Object)

the above code can not run.
I test other versions, only the version which > 2.9.0 will compile to this style.
< 2.9.1, eg, 2.9.0, will compile to :
function A(Object)

Any guys who know this compile rule is based on which feature, I read the changeLog but can not find any change which is related to this.
Thanks in advance.

It doesn't seem like you're giving us something we can compile that has the same issue; for example, running in our code playground doesn't seem to exhibit the problem you're running into.
What compiler options are you running, and do you have something closer to the original code you wrote?

@DanielRosenwasser
tsconfig.json as fowllowing:
{
  "compilerOptions": {
    "target": "es6",
    "lib": ["es6"],
    "typeRoots": ["./types", "node_modules/@types"],
    "outDir": "./dist",
    "sourceMap": true,
    "module": "commonjs",
    "moduleResolution": "node",
    "isolatedModules": false,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "noImplicitAny": true,
    "preserveConstEnums": true,
    "suppressImplicitAnyIndexErrors": true,
    "allowJs": true,
    "baseUrl": ".",
    "paths": {
      "ali-oss": ["./types/ali-oss.d.ts"]
    }
  },
  "include": ["lib"]
}

@DanielRosenwasser
original code is more complex, the main problem is why the ts will compile  a value which type is not defined to such this  format: typeof (_e = ((_c = ((_d = (typeof com !== "undefined" && com).alibaba) && _d).test) && _c).demo)) === "function" && _e
How can i switch off this feature if the function is feature

@DanielRosenwasser
I create a repo for this problem,  https://github.com/linxiaowu66/typescript-issue-25391
In the dist/index.js, you can find the code I mentioned above.
Thanks a lot


Add MNIST Redist UWP sample

Is it necessary to create a whole different project rather then modify the original mnist sample with optional preprocessor definitions to switch between inbox and redist versions of WinML? Squeezenet was changed to use the Redist in this style in this change : https://github.com/microsoft/Windows-Machine-Learning/commit/f850d3609225d88be3e30482c5a6e4f81e1f04d6

Can you add build configurations like "Debug_Inbox" "Debug_NuGet" "Release_Inbox" "Release_NuGet" that save USE_WINML_NUGET in the preprocessor definitions for the NuGet configuraitons?
Save Build Configurations
Right-click on the solution in the Solution Explorer and select Properties. In the Properties window, click Configuration Manager. Click the drop-down menu for Active solution configuration and click <New...>. Enter the name of the new solution configuration and make sure Create new project configurations is checked. Now, preprocessor definitions can be saved in desired build configurations.


Put delayed submission setting on a beta so it's not shown to Collect workspaces by default

Problem
As part of the plan changes we've considered for Collect in Wave 8, we are aiming to remove delayed submission as a configuration option in Collect. But since this configuration is going live in NewDot in the near future, we run the risk of showing something that we will take away in the near term, which is bound to upset any of our early adopters of NewDot who originally see it as an option.
Solution
Put the delayed submission configuration within Workflows behind a beta while we figure out how we want to tackle the potential transition of Collect being instant-only, so customers are not seeing this option in NewDot in the interim.

CC @lakchote

It's been deployed to production (https://github.com/Expensify/Web-Expensify/pull/41056#issuecomment-1977300280).
Closing the issue.


#52 Allow for Multiple Graphs

CHANGES:

Changed path.py to include a SelectMultiple instead of a Dropdown
Changed the data structures in _path_changed to allow support for multiple graphs

We are deferring on this work until we get determine a proper workflow.


Feature: Add headers onto http response.

Proposed Changes
Hello Maestro team, this is my first PR to an open source repo so please let me know if I've missed anything 🙂
As it stands right now, the response from an http request in maestro only returns fields:

ok
status
body

However there are use cases where the headers returned on a response are also needed.
This PR simply adds a headers property onto the response object.
Thankfully this is easy given that the okHttpClient under the hood exposes a way for us 🎉
This now means in our JS scripts we can call something like:
Script
const response = http.get("https://google.com");
console.log(response.headers);

Output (i.e the headers)
{
    alt-svc=[h3=":443"; ma=2592000,h3-29=":443"; ma=2592000],
    cache-control=[private, max-age=0],
    content-security-policy-report-only=[object-src 'none';base-uri 'self';script-src 'nonce-QTQrMThjMPBu5bXPTwTBuw' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp],
    content-type=[text/html; charset=ISO-8859-1],
    date=[Fri, 14 Jul 2023 12:30:22 GMT],
    expires=[-1], p3p=[CP="This is not a P3P policy! See g.co/p3phelp for more info."],
    server=[gws],
    set-cookie=[SOCS=CAAaBgiAoMKlBg; expires=Mon, 12-Aug-2024 12:30:22 GMT; path=/; domain=.google.com; Secure; SameSite=lax, AEC=Ad49MVHLRDm9QnY_9SIssRmo5IIk9Sw-FrE7VXB6rQcwBUiwrz5wGGiF2mc; expires=Wed, 10-Jan-2024 12:30:22 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax, __Secure-ENID=13.SE=bqLVDeIx1u4PZYKmvK1ZuMZU8Kt-3wEZR75Tu6kQaWbLS5BTPk-KWnhJGy987ESwGMW_Wa0JVHFTl66cmPwHU3ezWUjuCSSc26ZoeaD44uF6MyPQwpDan59XkkBniUWglc2yl6gzDX2SHttKUeskne5tqvem8U5gyxZH_595FCY; expires=Tue, 13-Aug-2024 04:48:40 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax, CONSENT=PENDING+642; expires=Sun, 13-Jul-2025 12:30:22 GMT; path=/; domain=.google.com; Secure],
    transfer-encoding=[chunked],
    x-frame-options=[SAMEORIGIN],
    x-xss-protection=[0]
}

Also if this change goes in we'll need to update the docs on the website here:

I'm happy to do this, but I'm not sure where to make the changes.
Thanks for taking a look at my PR 😁
Testing
I've done the following:

manual testing (via ./maestro) and got the headers output as shown above...
Added a unit test for the rhinoJSEngine.

I wasn't sure how to write a unit test that works in both rhinoJS/GraalJs engines simultaneously, so for now I've only added a unit test in RhinoJsEngineTest only.
Happy to add one if someone can help out 🙏🏾
Issues Fixed
No issues fixed, this is a new feature!

Super useful! 👍

@igorsmotto @artem888 Is it possible to get a review on this please? It's fairly simple and will unblock our development 🙂

Thanks so much for the review and the tip @artem888
Is it ok if I merge this PR in without adding the test for GraalJsEngineTest here?

@jlwillo I'm going to merge it, will write a test in a separate PR. Thanks for your contribution again!
And we'll also take care of documentation once it is released

Thank you so much @artem888 😁


feat: Add option to address "Rogue Referral" issue when tracking paid traffic via GTM+GA

Addresses Issue #114 by re-implementing the changes from PRs #74 and #86 against an updated base branch.
Thanks to @sahava for identifying what the issue actually is, and to @wusongliang (PR74) and @jeffski (PR86) for their effort to actually build a fix for this.

I could use some assistance to find out how to address the CI/testing issue that's occurred here.

@pi0 Could we get this PR look into, reviewed, and merged, please?

Happy birthday little PR! Hard to believe it's been a year. You've come so far since you were first opened.


Add support for new languages.

Add support for the languages specified in the table above.

I notice that for the acronym for the language are only two characters.  Shouldn't it be 4 characters?

I believe the overarching language is two characters, and the locale-specific language is 4.
hr is Croatian, which follows the same pluralization rules as russian.

Am i reading this incorrectly...They seem ddifferent
http://www.unicode.org/cldr/charts/33/supplemental/language_plural_rules.html

It's always possible we have a bug :-) if you want to open a separate PR with test cases for croatian, then we can get that fix in quickly.

i'll update this PR with it.  Also should we be using the locale-specific code?

I'd prefer it be a separate PR - this one is a semver-minor, adding new features - bugfixes are semver-patch and I'd like to get those in separately.

Any guidance on the language acronyms?  Is pluralization only based on the language code?  Is there no variation between different region(locale)?
https://www.science.co.il/language/Locale-codes.php
It looks like the current code only handles the language code and not really the locale id?

It supports both: https://github.com/airbnb/polyglot.js/blob/master/index.js#L86-L87

If it supports both, i'm guessing it will default to the language code.  Does that present any potential issues when a user uses it the method?  For example, they mistakenly pass in the language code vs. the local which might result in unexpected results?

@ljharb
I've removed the Croatian fix to another PR.  How long do you think this PR will take to get approved? ETA?
Thanks,
Derek

Thanks for filing #114 :-)
As for this one, I'm waiting on some internal l10n folks to review this PR - I'm hoping to merge it early next week.

has your team been able to verify the new languages?

Since we don't support these languages, it turns out our team won't be able to verify them. I'll rebase this, and give it a review myself.

It'd be great if you could rebase your branch on top of fe829c39638f4c26f109e48fe7953707a3dee505 :-)

addressed all your comments

sorry i'm not following...
if (n % 100 === 1))
101%100= 1(true), 1001%100 = 1 (true), 12301%100 = 1 (true) 11%100 = 11 (false)
I've also added test to validate it as well.
As for separating russian and croatian (done in previous PR), does it make sense because it's already done for other languages such as chinese/korea/thai/etc.


Emailing cii-badges-questions-owner does not work

PS. Emailing<EMAIL_ADDRESS>which is listed in the footer, doesn't work: 510 The group 'cii-badges-questions-owner' does not exist.

See #1206

The lf recently changed how mailing lists work. That change wasn't supposed to interfere with this functionality, but it appears that it did.  we'll have to track this down with support. Thanks for reporting this!

I need to remove the "-owner" part of the email address, and that will partly solve the problem. That's already in the staging tier for English, and the rest will follow over time.
However, the mailing list configuration for the new mailing list doesn't seem to actually work.  I've posted a help desk ticket with the Linux Foundation IT team, and we'll try to get that fixed.

We may need to just use GitHub issues, and remove the reference to email for help.


Revert release 1.1.0.Beta2

The release was done over a external repository. This PR revert those changes

Moved to: https://github.com/quarkus-qe/quarkus-test-framework/pull/424


Will want some way to validate cache files

https://github.com/flutter/flutter/issues/7308 is another example of someone getting a corrupted bin/cache and then being stuck.
Not sure there is anything specific to do at this time, but something to track and consider for future improvement.

@eseidel do you think there is still something to do?

I haven't heard of any of these recently.  I think @goderbauer and @gspencergoog may have fixed them all.


Knob controls being sent to incorrect FX module (delfx and revfx)

Describe the bug
Even if the FX mode is switched from delfx to revfx, the knob values is being sent to delfx, and vice-versa.
To Reproduce
Steps to reproduce the behavior:

Push DELAY button to set the FX mode to delfx.
Select any delay module by TYPE knob.
Use A or B knob to control the module.
Push REVERB button to switch the FX mode to revfx.
Without touching TYPE knob, twist the A or B knob.

(Issue) Then, the knob controls will be sent to the delfx module, although the FX mode is in revfx currently (due to the step 4 above).

Select any reverb module by TYPE knob.

Then, the knob controls will start to be sent to the correct revfx module.
Expected behavior
The knob controls should be sent  to the selected modules.
Screenshots
N/A
Desktop (please complete the following information):

OS:
$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.15.2
BuildVersion:   19C57

Version
$ ./logue-cli probe -i 0 -o 0

Device: nutekt digital
System version: 1.03
Logue API version: 1.01-0
Available modules:

Additional context
N/A

Hi, thanks for reporting this issue, however it is not related to the logue-sdk but rather to the NTS-1 itself. This has already been reported elsewhere and will be addressed in a future update. However product related issues will not be tracked on this repository.
Product-related issues should be reported through the appropriate customer support channels.


Question: Is there a way to define to_address and from_address when sending tokens?

Hi folks,
I'm wondering if there is a way to define sender and recipient when sending tokens. I saw that in older versions of Cosmwasm you could define both sender and recipient(in 0.13 if I recall correctly), but now you can't - from_address is predefined see here Is there any workaround? Or should I downgrade to an older version with the given functionality?
Thanks.

The contract is only allowed to send its own balance. For this reason we have

from_address is automatically filled with the current contract's address.

Why would you want to change that?

Hey, I'm trying to create a smart contract for atomic swaps, but it seems like my knowledge of smart contracts is not as good as I thought. I was trying to lock funds, and then send locked funds from the source to the recipient when the right preimage was given. Instead, I can lock these funds into a smart contract - and that's more elegant. Anyways, thank you so much, you solved my problem.

Instead, I can lock these funds into a smart contract - and that's more elegant

Exactly. See also the hackatom testing contract (https://github.com/CosmWasm/cosmwasm/tree/main/contracts/hackatom), which is an escrow contract (plus a lot of debugging stuff that is irrelevant for the escrow use case).


[BUG] @tsed/common is missing "accepts" dependency

Information
I'm trying to use PlatformTest to test a service (That actually does little with requests)

Version: 7.8.0
Packages:

@tsed/common
@tsed/core
@tsed/exceptions
@tsed/platform-params
@tsed/schema

Example
PlatformTest uses the "accepts" package, but it isn't defined in the package.json.
https://github.com/tsedio/tsed/blob/production/packages/platform/common/src/services/PlatformTest.ts
Acceptance criteria

[ ] @tsed/common has the "accepts" package defined in it's package.json, or the docs should be changed to reflect that you need to install it yourself (optional peerDependency)

Hello @jojoxd
Accepts is an express dependencies. Maybe it’s missing if you use koa.js.
You can make a PR to fix that if you have a time ;)
See you

Fixed


link.xml Assemblies Are Being Removed Upon Entering Project in Unity 5.3.5f1

As the documentation suggests, I have added the appropriate components to the link.xml file like:
<assembly fullname="AWSSDK.Core" preserve="all"/>
<assembly fullname="AWSSDK.CognitoIdentity" preserve="all"/>
<assembly fullname="AWSSDK.CognitoSync" preserve="all"/>
<assembly fullname="AWSSDK.DynamoDBv2" preserve="all"/>
<assembly fullname="AWSSDK.Lambda" preserve="all"/>
<assembly fullname="AWSSDK.MobileAnalytics" preserve="all"/>
<assembly fullname="AWSSDK.SecurityToken" preserve="all"/>
<assembly fullname="AWSSDK.IdentityManagement" preserve="all"/>

However, as soon as I open my project in the Unity editor, the above code is changed to:
<assembly fullname="AWSSDK.Core" />

Is this expected behavior? Builds are crashing on iOS because of this. If there is some other setting needed so that the editor does not overwrite this file, can it please be added to the documentation? I'm having a very frustrating time trying to get the AWS SDK to work on iOS...
I'm using Unity 5.3.5f1 and AWS SDK <IP_ADDRESS>

The code below fixed the issues for me. I see there is another PR to fix some of the documentation already, but that alone did not fix the issues for me. I will let someone more knowledgable about the link.xml file take it from here to document what is actually necessary out of the code below.
<assembly fullname="AWSSDK.Core">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.CognitoIdentity">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.CognitoSync">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.MobileAnalytics">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.SecurityToken">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.Lambda">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>
  <assembly fullname="AWSSDK.DynamoDBv2">
    <type fullname="Amazon.*" preserve="all" />
    <namespace fullname="Amazon.Util.Internal.PlatformServices" preserve="all" />
  </assembly>

Closing due to inactivity


WIP: Add validating webhook and webhook tls autoconfiguration

What this PR does / why we need it:
This PR adds support for ValidatingWebhookConfiguration for cert-manager resources.
This is comprised of a few parts that make it more complex, mostly around securing the TLS endpoint for the webhooks.
Roughly:

Adds 'webhook tls bootstrap' - when cert-manager starts, it will create an 'internal' CA issuer based on CLI arguments passed to it on startup. We do this because the APIService has failurePolice: Fail, meaning we cannot create real Issuers or Certificates.

Once the secret resource has been provisioned, the webhook will be able to start, and cert-manager will then create the Issuer and Certificate resource in the apiserver, allowing standard renewal to take place from then on.

Adds a 'apiextensions-ca-sync` CronJob as part of the standard deployment (repo here: https://github.com/munnerz/apiextensions-ca-helper). This periodically syncs Secret resources with APIService and {Validating,Mutating}WebhookConfiguration resources. This job is configured to automatically configure the cert-manager webhook configuration resources with the appropriate caBundle field.

This lays out a general pattern for how webhook TLS can be configured in Kubernetes more generally. I have a doc I'm putting together that details a recommendation for how to secure webhooks other than cert-manager's own webhooks.
Release note:
Add validation webhooks for API types

So a few more notes on the status of this:

We need to add a 'selfsigned' issuer first, to make this truly user intervention free. This will allow us to automatically provision the actual signing CA which is then used by the internal ca issuer. Right now, a signing cert still has to be manually provisioned (which cert manager uses to sign webhook serving certs)

In implementing this, a bug in kube-apiserver was discovered that causes validations to fail in 1/N cases (where N is the number of apiservers) in multi master setups only. This PR fixes that: https://github.com/kubernetes/kubernetes/pull/62649 and has been cherry picked into 1.10. We need to provide a way to disable validation checks for 1.10 clusters in the meantime, else nothing will work.

I am currently blocked on https://github.com/kubernetes/helm/pull/4231 being merged, and https://github.com/kubernetes/helm/pull/3982 making it into a tagged release.

/test e2e v1.9

I've tested this locally and it worked well for me. Releasing v0.5 with this turned off by default (and a note in the release notes of how to opt in), maybe defaulting it to on in v0.6 sounds like a good idea.
I got this error when deploying with helm:
helm upgrade cert-manager contrib/charts/cert-manager --reuse-values --set webhook.enabled=true
Error: found in requirements.yaml, but missing in charts/ directory: webhook

I moved webhook into contrib/charts/cert-manager/charts, which made helm happy.

Sorry @kragniz - didn't see your review of this PR until now!
Thanks for taking a look 😄

I got this error when deploying with helm:

Yes, if you run helm dep update contrib/charts/cert-manager first, it should build the .tgz in the charts/ directory. I structured it this way so that when the chart is published to helm/charts, it will be package up correctly.

/check-dco

As this is disabled by default, I'm going to go ahead and merge this so we can start gathering feedback from users 😄
There may be changes still to make, but let's see what the world thinks first!


WIP: Mutual tls support for falcosidekick authentication

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:
It adds mutual tls support to be used in alertmanager, elasticsearch, influxdb, NATs and webhook outputs
Which issue(s) this PR fixes:
Fixes #216
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign keisukeyamashita after the PR has been reviewed.
You can assign the PR to them by writing /assign @keisukeyamashita in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @jasiam! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

Can you complete the description of your PR please.

I'll include the mutualtls flag in all outputs which use the NewClient method.

Do we really want to add the mutualtls support for all outputs which use the NewClient method? For instance, Loki doesn't support this kind of authentication (or any) and you'd need a reverse proxy in order to use it.

Only for outputs which allow it. This is why it's a "by output" setting.

Do we really want to add the mutualtls support for all outputs which use the NewClient method? For instance, Loki doesn't support this kind of authentication (or any) and you'd need a reverse proxy in order to use it.

Only for outputs which allow it. This is why it's a "by output" setting.

So... I'm confused. Do you want to add the config.[OUTPUT].MutualTLS parameter in the NewClient method even if the output doesn't support mutual tls authN? I know the default value is false, but I'm afraid some users think they can use mutual tls when the actually can't.
If you want to, I can contact you over slack and discuss it.

Can you complete the description of your PR please.

I just realized it's empty! I don't know what happened since I filled it before the open action. I'll refill again.

@jasiam: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from issif after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Do we really want to add the mutualtls support for all outputs which use the NewClient method? For instance, Loki doesn't support this kind of authentication (or any) and you'd need a reverse proxy in order to use it.

Only for outputs which allow it. This is why it's a "by output" setting.

So... I'm confused. Do you want to add the config.[OUTPUT].MutualTLS parameter in the NewClient method even if the output doesn't support mutual tls authN? I know the default value is false, but I'm afraid some users think they can use mutual tls when the actually can't.
If you want to, I can contact you over slack and discuss it.

We can discuss about this on Slack, feel free to contact me 😉

The README is not up to date with config_example.yaml and it misses variables for MutualTLS and CheckCert in list of env vars.
In config.go, default values are missing for MutualTLS and CheckCert, they should all be there, to only have explicit values.
Thanks.

I think all required changes are now in the PR

can you check both README and config_example have same variables please

My fault, I forgot to update the env vars part in README file. Now README and config_example.yaml files are synchronized.

LGTM label has been added.  Git tree hash: 3d064bd02d27d3037c12c366a66340c2333994b1

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


ARM64 not compatible

Hey master, as you can see, there is no arm64 based docker image in your official repo.
I appreciate the Qiniu cost efficiency than Ali OSS, so we determine to switch to Qiniu OSS, but sadly there is no official arm64 image.
If yours can help add more arch support, we'll appreciate a lot.

Ok, we will do it later.


Gelocation optimize

Is your feature request related to a problem? Please describe.
Optimize gelocation so that is become more efficient
Describe the solution you'd like
Describe alternatives you've considered
Additional context
Do I want to work on this:

[x]  Yes
[ ] No

Please Describe in Brief what are the changes that you want to make.

Please Describe in Brief what are the changes that you want to make.

Removed unnecessary library imports (geolite2, termcolor, prettytable, requests).
Simplified the HTML table code by removing the termcolor library dependency.
Used geocoder.ip directly to retrieve IP address information.
Replaced geolite2.reader() with geocoder.ip for IP geolocation.
Simplified the table printing by using string formatting.
Removed unnecessary while loop for user input validation.
Removed the os library import since it was not used.
Minor code formatting improvements.

Go Ahead @shraddha761


stride-api: fix timestamp example in docs

oopsy, we have misleading docs, as described here https://github.com/hasadna/open-bus-stride-api/issues/13
example: https://open-bus-stride-api.hasadna.org.il/docs#/gtfs/list__gtfs_ride_stops_list_get
but probably everywhere..
Change this to an example that can easily be copy-pasted and work out of the box.

as far as i understand - the required change is at stride-api repo
am i right?

https://github.com/hasadna/open-bus-stride-api/issues/13 Solved. Unless there is another documentation with a different source 🤨

@Senior-ai Thanks for the donation!


fix: add pypi deployment to build

PR summary
Adds pypi deployment to the travis build
Fixes: n/a
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add additional information in the View Retained Data using a Flow section

Add additional information in the View Retained Data using a Flow  section.
If the retained data includes attachments from Annotation table, the returned value will be a base64 representation of the file. Large files may result in the Cloud Flow action to time-out or to exceed its output message size limit.
As a workaround, use Web API to perform the export action ExportRetainedData using Azure Functions or other custom development options.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5f214df6-a230-96b6-25f4-bbed1e3d8cd0
Version Independent ID: 5f214df6-a230-96b6-25f4-bbed1e3d8cd0
Content: View long term retained data in Microsoft Dataverse - Power Apps
Content Source: powerapps-docs/maker/data-platform/data-retention-view.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @pnghub
Microsoft Alias: gned

Thanks for your comment, @fooshen. This issue has been assigned to the doc author for review.

@fooshen the public doc has been updated per our discussion. Thx @Mattp123


Compile when few options are set

Description
When the stack is compiled with minimal extensions (without 0RTT, ALPN, MFL, and MPS) then compilation errors occur due to unused variables.
Status
DONE
Requires Backporting
NO
Migrations
NO
Additional comments
Todos

[x] Tests

Steps to test or reproduce
To reproduce the errors, use the config.h file from the EEMBC benchmark here:
https://raw.githubusercontent.com/eembc/mbedtls/eembc-setup/include/mbedtls/config.h

I'm hitting a new error:
/usr/bin/ld: CMakeFiles/fuzz_client.dir/fuzz_client.c.o: in function `LLVMFuzzerTestOneInput':
fuzz_client.c:(.text+0x5d): undefined reference to `mbedtls_test_cas_pem_len'
/usr/bin/ld: fuzz_client.c:(.text+0x67): undefined reference to `mbedtls_test_cas_pem'
collect2: error: ld returned 1 exit status
make[2]: *** [programs/fuzz/CMakeFiles/fuzz_client.dir/build.make:129: programs/fuzz/fuzz_client] Error 1
make[1]: *** [CMakeFiles/Makefile2:820: programs/fuzz/CMakeFiles/fuzz_client.dir/all] Error 2
make: *** [Makefile:130: all] Error 2


BUG: Bug fix implement reduce/setstate for Period pickle support

Fix Period pickle issue https://github.com/pydata/pandas/issues/10439

can you add some tests pls. you can use self.round_trip_pickle(..)

if you want to be adventurous, you could edit pandas/io/tests/generate_legacy_pickles.py, adding in an example Period/PeriodIndex. Then run this under 0.16.2! which will generate some older pickles. These can be committed and automatically tested.

added a test method in tseries.test.test_period.py

can you update / squash

done, please let me know if what I did was correct.
On Wed, Aug 5, 2015 at 5:19 PM, Jeff Reback<EMAIL_ADDRESS>wrote:

can you update / squash
—
Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/10441#issuecomment-128152118.

ok, if you can squash would be gr8. ping when green.

ok I think I did it, but im not quite sure what to do, I still see the
entire commit history on github but did put in a squashed commit.
On Thu, Aug 20, 2015 at 11:00 AM, Jeff Reback<EMAIL_ADDRESS>wrote:

ok, if you can squash would be gr8. ping when green.
—
Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/10441#issuecomment-133041214.

superseded by #10886

thanks.
On Thu, Aug 20, 2015 at 12:24 PM, Jeff Reback<EMAIL_ADDRESS>wrote:

Closed #10441 https://github.com/pydata/pandas/pull/10441.
—
Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/10441#event-387860976.


Can not set default filter for FilterDateRange

When you are trying to set default filter for FilterDateRange it is ending with:

Ublaboo\DataGrid\Exception\DataGridException
Filter [from] is not defined

It is because of calling $this->getFilter in Datagrid::setFilterContainerDefaults:
			if ($value instanceof \DateTime) {
				$filter = $this->getFilter($key);

				if ($filter instanceof IFilterDate) {
					$value = $value->format($filter->getPhpFormat());
				}
			}

$key is here from (and to) so it can not be found in filters ... it has to be changed (called with parent key name) - see pull request.
Steps to reproduce:

Create DataGrid with DateTime column and FilterDateRange filter - for example date:

$dataGrid->addColumnDateTime('date', 'Date')
	->setFilterDateRange();

Set default values for that column - for example:

$dataGrid->setDefaultFilter([
	'date' => [
		'from' => (new \DateTime())->sub(new \DateInterval('P3M')),
		'to' => (new \DateTime())->sub(new \DateInterval('P1D')),
	]
]);

It will crash with:

Ublaboo\DataGrid\Exception\DataGridException
Filter [from] is not defined

Will be in v6.2.15


server端注册ip没有过滤docker容器中的docker0网卡

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description
server端注册ip没有过滤docker容器中的docker0网卡
Ⅱ. Describe what happened
网卡信息

server注册信息

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Ⅴ. Anything else we need to know?
增加过滤docker0网卡
io.seata.common.util.NetUtil#getLocalAddress0
    private static InetAddress getLocalAddress0() {
        InetAddress localAddress = null;
        try {
            localAddress = InetAddress.getLocalHost();
            if (isValidAddress(localAddress)) {
                return localAddress;
            }
        } catch (Throwable e) {
            LOGGER.warn("Failed to retrieving ip address, {}", e.getMessage(), e);
        }
        try {
            Enumeration<NetworkInterface> interfaces = NetworkInterface.getNetworkInterfaces();
            if (interfaces != null) {
                while (interfaces.hasMoreElements()) {
                    try {
                        NetworkInterface network = interfaces.nextElement();
                        Enumeration<InetAddress> addresses = network.getInetAddresses();
                        while (addresses.hasMoreElements()) {
                            try {
                                InetAddress address = addresses.nextElement();
                                if (isValidAddress(address)) {
                                    return address;
                                }
                            } catch (Throwable e) {
                                LOGGER.warn("Failed to retrieving ip address, {}", e.getMessage(), e);
                            }
                        }
                    } catch (Throwable e) {
                        LOGGER.warn("Failed to retrieving ip address, {}", e.getMessage(), e);
                    }
                }
            }
        } catch (Throwable e) {
            LOGGER.warn("Failed to retrieving ip address, {}", e.getMessage(), e);
        }
        LOGGER.error("Could not get local host ip address, will use <IP_ADDRESS> instead.");
        return localAddress;
    }

Ⅵ. Environment:

JDK version :
OS :
Others:

http://seata.io/zh-cn/docs/ops/deploy-by-docker.html


When Breaking Dark oak or oak leaves with fist instead of dropping loot or nothing it drops the leaf block

When Breaking Dark oak or oak leaves with fist instead of dropping loot or nothing it drops the leaf block.
just in survival mode try to break oak leaves with your fist.
this bug ruins all features of the mod

Thank you for reporting the issue, it is now fixed.
Fixed version


fix(legend): fix dataItem undefined error

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Fix LegendModel error when dataItem is undefined
Fixed issues

Details
Before: What was the problem?

The possibility of dataItem being empty was not taken into consideration here, and its name is directly retrieved:

After: How does it behave after the fixing?

Exclude empty dataItem and empty legend names.
Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc
ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

Hi. Thanks for your contribution. If this PR doesn't have a related issue to describe the problem, please provide an online link with Official Editor, CodePen, CodeSandbox or JSFiddle for the reviewer to understand the problem. Thanks!

This pr is to fixed the null error by this commit: https://github.com/apache/echarts/commit/4fe4561eafc5d69d4b6295a593cf12513a907ba6
when v5.4.0 is display: https://codepen.io/roojay/pen/jOvvmQV
when v5.4.1 is error: https://codepen.io/roojay/pen/MWqqmZo

@Ovilia test case added.


Bump wasm-tools crates

Two major changes/reasons for this update:

Primarily pulling in support for semicolons-in-WIT files. Semicolons are not currently required, though, so I'll follow-up later with actual semicolons.

The syntax for parsing (if ...) was fixed in wast. Previously it did not require (then ...) but this is required by the spec. New spec tests require this as well. This breaks existing text format tests which don't use (then ...) inside of an (if ...). Most tests were updated by hand but embenchen_* tests were updated by running through the old parser to produce non-s-expression using code.

I grant myself 🦡 for deleting 18kloc. Disregard the fact that that's purely tests that someone must have checked in a long time ago.


HKEY_LOCAL_MACHINE\Policies registry path correct?

Many registry keys in this document reference HKEY_LOCAL_MACHINE\Policies

e.g. Create a REG_DWORD registry setting named LetAppsAccessLocation in HKEY_LOCAL_MACHINE\Policies\Microsoft\Windows\AppPrivacy with a value of 2 (two).

Is this a mistake? Shouldn't they all be replaced with HKEY_LOCAL_MACHINE\SOFTWARE\Policies?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e8228962-7158-6be1-e791-e6535b88f343
Version Independent ID: 46e4c7f3-e8b0-ebc9-da58-b69149803937
Content: Manage connections from Windows operating system components to Microsoft services (Windows 10)
Content Source: windows/configuration/manage-connections-from-windows-operating-system-components-to-microsoft-services.md
Service: unspecified
GitHub Login: @brianlic-msft
Microsoft Alias: brianlic-msft

Hi @nnpcYvIVl , thanks for raising this issue. It has been fixed.

Fixed


Vercel vs Coolify

Technical Comparison: Vercel vs Coolify
Overview
Write a technical comparison between Vercel and Coolify for the developer community, highlighting key differences, use cases, and decision factors.
Article Sections
1. Introduction

[ ] Brief overview of deployment platforms
[ ] Why deployment choice matters for developers
[ ] High-level introduction to Vercel and Coolify

2. Core Architecture & Philosophy

[ ] Vercel: Serverless-first, edge-focused architecture
[ ] Coolify: Self-hosted, privacy-focused approach
[ ] Key architectural differences and their implications

3. Deployment Features

[ ] Build processes comparison
[ ] Deployment strategies
[ ] Preview environments
[ ] Rollback capabilities
[ ] Branch management features

4. Developer Experience

[ ] Setup process comparison
[ ] CLI tools analysis
[ ] Dashboard/UI experience
[ ] Local development experience
[ ] Integration with Git providers

5. Performance & Scaling

[ ] Edge network comparison
[ ] Cold starts analysis
[ ] Resource allocation methods
[ ] Scaling limits
[ ] Geographic distribution capabilities

6. Framework Support

[ ] Next.js optimization (Vercel's specialty)
[ ] Other framework support
[ ] Static site capabilities
[ ] SSR capabilities

7. Self-hosting & Control

[ ] Coolify's self-hosting capabilities
[ ] Infrastructure requirements
[ ] Resource management
[ ] Cost implications of self-hosting

8. Cost Analysis

[ ] Pricing models comparison
[ ] Hidden costs identification
[ ] Resource usage pricing
[ ] Enterprise features pricing

9. Security & Privacy

[ ] Data residency options
[ ] Security features comparison
[ ] Compliance capabilities
[ ] Access control mechanisms

10. Real-world Use Cases

[ ] When to choose Vercel
[ ] When to choose Coolify
[ ] Migration considerations
[ ] Team size considerations

11. Monitoring & Observability

[ ] Built-in analytics comparison
[ ] Logging capabilities
[ ] Integration with monitoring tools
[ ] Error tracking features

12. Community & Support

[ ] Documentation quality assessment
[ ] Community size and activity
[ ] Support channels comparison
[ ] Update frequency and maintenance

Research To-Do

[ ] Gather deployment metrics
[ ] Test both platforms with sample applications
[ ] Collect community feedback
[ ] Document real-world case studies
[ ] check Twitter and https://serverlesshorrors.com/

Additional Resources to Include

[ ] Official documentation links
[ ] Community forums
[ ] Relevant blog posts
[ ] GitHub repositories

Writing Guidelines

Maintain objective tone
Include code examples where relevant
Add screenshots of key features
Include performance metrics
Add comparison tables for quick reference

Notes

Remember to include practical examples
Add performance benchmarks
Include migration guides
Consider adding a decision flowchart

hey @abhaysinghr516 as discussed, you can raise the PR once you're done with the task.

Noted, I'll raise the PR once done.