Add App and SubApp resource methods

Objective
Add helper methods to App and SubApp to ease plugin maintainers and less verbose code. It also adds examples to show how to use these methods.
It also deprecates the World::contains_non_send in favor of the more consistent World::contains_non_send_resource.

I can see how this makes the code nicer, but it's more to maintain and synchronize and makes the docs much worse. I don't think we should do this.

It also deprecates the World::contains_non_send in favor of the more consistent World::contains_non_send_resource.

I would happily approve a standalone PR for this though!

It also deprecates the World::contains_non_send in favor of the more consistent World::contains_non_send_resource.

The system param is NonSend, which is why the method is called contains_non_send

@alice-i-cecile ok, I'll create a PR only for the non_send_resource (and maybe 👇 ?).
Is there any other reasonable way to achieve the same result?
Or, does it make sense to have some of the world methods but not all of them? I mean only those related to resources only, since they are handled inside plugins.
@mockersf maybe the NonSend should be renamed to NonSendResource too? NonSend seems very generic (and also it's not strictly a noun 😊 )

@mockersf maybe the NonSend should be renamed to NonSendResource too?

Names should stay coherent, and if you update one you should update the others.
When adding NonSend, we decided to keep it short. changing the names to have the word resource would make them longer, without adding useful meaning in my opinion. I would prefer to keep them as they are currently.

I see, it makes sense to keep names short.
My 2c as a regular user: I found it confusing that regular resources are initialized as init_resource/insert_resource, derived as Resource and accessed through Res/ResMut, while main-thread-only are initialized as init_non_send_resource/insert_non_send_resource, and accessed through NonSend/NonSendMut.
I wouldn't care about the longer name, both since NonSend resources are way less used, and it wouldn't break consistency (so, I'd rename also NonSend as NonSendResource).
I can always define my own internal type (or a macro) to shorten the name.

I'd rename also NonSend as NonSendRes and NonSendMut as NonSendResMut

I think this is a good compromise. I also had no clue that a NonSend was a resource until I read the docs.

NonSend data is... not really a resource, and is definitely not going to remain a resource. See #5135 for more context.

NonSend data is... not really a resource, and is definitely not going to remain a resource. See #5135 for more context.

I created this to handle this specific topic.
I read the discussion there, and it seems that rather "not resource" they are treated as "thread-local" ones, right?


Make a CodeHost state machine

This simplifies much of the internal complexity of TreehouseApp. We can also delete FakeCodeHost because the single implementation is suitable for unit testing.
Closes: https://github.com/cashapp/redwood/issues/1660

I’d like to add tests before reviewing this.

⚠ stacked PR!


Lazy loading (chaining locators) not working for ElementsCollection if parent element is missing

The problem
If start searching collection from some element, and those element is missing - NoSuchElementException thrown
Reproducible only for collection, not for $element.$element
Actual - parent locator explicitly initiated before collection action
Expected - parent and child locator chained before collection action
Tell us about your environment

Selenide Version: 6.19.0

Code To Reproduce Issue [ Good To Have ]
Selenide.$("missingElement").$$("div"); -> NoSuchElementException
Selenide.$("div").$$("missingCollection"); -> lazy loaded

@maldm01 Why are you reporting a bug for an old Selenide version?
With the latest Selenide 7.3.1, the problem is not reproducible:
  @Test
  void justUseLatestVersion() {
    open("about:blank");

    assertThat($("div").$$("missingCollection"))
      .hasToString("{div}/[missingCollection]");

    assertThat($("missingElement").$$("div"))
      .hasToString("{missingElement}/[div]");
  }


Blue rectangle-based range selection in histograms

Good to merge.
Known limitations

After making a selection, the user might be tempted to cancel it by making a small selection that includes zero bins. However, it's not possible to 'unset' selectedRange by passing undefined to onSelectedRangeChange (it expects a defined argument).  This can be solved more generally with reset buttons maybe.
Range selection is still half-active in the viz panel where it's not needed. You see the graphical selection, but upon finishing the selection nothing happens (which is correct)

The requested changes are done and tested.
Upon merging in main some UX needs attention:

All good now - please approve!

No worries - and thanks for finding this edge case.  Sorry it's in a PR for another issue...
I added your change, and it works great for the non-required linked pair.
I added a story for a required linked pair.  The behaviour is passable but not ideal.
If you enter 100000000 in a box, let it update the other, then hit backspace, the last valid value (1) is notified to the consumer before the box is emptied.


Add lotabout/skim

https://github.com/lotabout/skim
Fuzzy Finder in rust!

https://github.com/lotabout/skim#installation

linux

skim-v0.9.4-arm-unknown-linux-gnueabihf.tar.gz
skim-v0.9.4-armv7-unknown-linux-gnueabihf.tar.gz
skim-v0.9.4-x86_64-unknown-linux-musl.tar.gz

darwin

skim-v0.9.4-x86_64-apple-darwin.tar.gz


how do i fix this?

What is your question?
I want to fix this but IDK how

when I compile the build and finish Freeplay song or week it goes to the bonus option

Make the variables separate. here you’re putting the code with the freeplay code.

Make the variables separate. here you’re putting the code with the freeplay code.

ohhhhhhh, alr


Validate form on Enter/return key pressed

If you add the pattern attribute to the input, it is nos being validated when you submit the form pressing "Enter" key.

Seems like a duplicate of #52, can you try on the develop branch and confirm?

@p-sam I'm using version 1.5.1 where the input is already inside a form. The pattern is being validated on submit with the "ok" button but not when I hit "Enter".
It is related with #52, we can close this and reopen that one if you wish.

I see, thanks for the clarification

Please confirm the issue is resolved on your end too in the develop branch, then I'll wrap up a new release

Thanks @p-sam ! I tried with develop branch and it is working as expected.


[Bug]: Ctrl + Enter in numpad does not run code in Playground

What happened?
Ctrl + Enter in numpad does not run code in Playground.
Issue Priority
Priority: 3 (minor)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[X] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take-issue


PDF download fails

moved from https://github.com/buda-base/library-issues/issues/342
Trent reported that he has been unable to download files from Cambodia works. I tested a few works and had issues as well.

https://library.bdrc.io/show/bdr:W1FEMC030140 — generating the PDF from the IIIF viewer never completed. The progress % would increase and decrease, and +45 minutes later still would not finish
https://library.bdrc.io/show/bdr:W1FEMC010933 — downloading PDF and Zip from the record completed. Downloading from the IIIF viewer did not work.
https://library.bdrc.io/show/bdr:W1FEMC010934 — downloading worked.
https://library.bdrc.io/show/bdr:W1FEMC030141 — generating the PDF got to 96% and then reset to 0%, restarted and worked.

Generating the PDF in the IIIF viewer got to 99% and reset to 0%. Generating the Zip worked after a while but when I tried to download I got a 502 Bad Gateway error.

a few pointers that could help

https://www.ehcache.org/apidocs/2.9/net/sf/ehcache/exceptionhandler/ExceptionHandlingDynamicCacheProxy.html


One battery won't discharge from 100%

hi there, since installing the experiment version of the software and using the fast charge function in the software, one of the batteries stays at 100% and doesn't discharge. There are 3 batteries, and 1 is paired together as one unit. The paired batteries do work as expected and are charging/discharging. The system sees 2 batteries, but the second one won't discharge at all.
LX F16.4-H x 3 stacks.
Invertor: GW25K-ET (AS4777-2 2020)
I've tried restarting the whole stack including batteries to no end. I've depleted the paired batteries and the 100% charge battery simply won't discharge. Is there a setting to check for this?
I do see these in the logs from time to time:
Diag Status changed to BMS: Discharge current low, APP: Discharge current too low, SOC delta too volatile, PF value set, Real power limit set.
Charge batteries: Error executing script. Invalid data for call_service at pos 1: expected str for dictionary value @ data['value']
Could it be the above values are not set properly? If so, what should the value be?
"yes", "no", null or something else?
Adam

Also found this in the logs:
Logger: homeassistant.helpers.entity
Source: helpers/entity.py:1176
First occurred: June 9, 2024 at 8:54:56 AM (5 occurrences)
Last logged: 1:34:36 PM
Updating state for sensor.pv8_voltage (<class 'custom_components.goodwe.sensor.InverterSensor'>) took 0.418 seconds. Please create a bug report at https://github.com/mletenay/home-assistant-goodwe-inverter/issues
Updating state for sensor.pv12_current (<class 'custom_components.goodwe.sensor.InverterSensor'>) took 0.409 seconds. Please create a bug report at https://github.com/mletenay/home-assistant-goodwe-inverter/issues
Updating state for sensor.battery_warning (<class 'custom_components.goodwe.sensor.InverterSensor'>) took 0.592 seconds. Please create a bug report at https://github.com/mletenay/home-assistant-goodwe-inverter/issues
Updating state for sensor.pv_channel (<class 'custom_components.goodwe.sensor.InverterSensor'>) took 0.464 seconds. Please create a bug report at https://github.com/mletenay/home-assistant-goodwe-inverter/issues
Updating state for sensor.today_battery_charge (<class 'custom_components.goodwe.sensor.InverterSensor'>) took 0.432 seconds. Please create a bug report at https://github.com/mletenay/home-assistant-goodwe-inverter/issues

Seems to be fixed by manually setting: battery_discharge_current comparing the 2 stacks to the same value.
Is there an officially recommended value for this? I'll check with Goodwe Support.

Seems 25 is the value based on this doc: https://www.goodwe.com.au/Ftp/Downloads/Datasheet/AU/GW_Lynx Home F PLUS+ Series (HV)_Datasheet-AU.pdf


feature/first-scaffolding

Features

Add gatsby basic scaffolding (emotion + typescript + gatsby)
Add basic README.md documentation

@Hansanghyeon
Which is mean deploy?
Is this mean about deployment of the source code or blog contents?
I think both of the ways to manage should be in the repository

Could any folks please review this?


Typo "Azure Monitor application insights"→"Azure Monitor Application …

…Insights"
https://learn.microsoft.com/en-us/azure/developer/javascript/tutorial/nodejs-virtual-machine-vm/azure-monitor-application-insights-logs https://github.com/MicrosoftDocs/azure-dev-docs/blob/main/articles/javascript/tutorial/nodejs-virtual-machine-vm/azure-monitor-application-insights-logs.md #PingMSFTDocs

Learn Build status updates of commit d26f55f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/javascript/tutorial/nodejs-virtual-machine-vm/azure-monitor-application-insights-logs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


New class loading safety

The most common failure for our unit tests is a DynamicExpresso bug. It's quite annoying too.
Every usage of DynamicExpresso is guarded by locks in our case however unit tests still fail. There appears to be a race condition in type loading, something that looks to require a global (app domain?) lock internally.
[xUnit.net 00:00:02.12]       DynamicExpresso.Exceptions.ParseException : No applicable constructor exists in type 'X4BFlow.Test.Nf9.TestTemplatePrototype+TemplateTest' (at index 55).
[xUnit.net 00:00:02.12]       Stack Trace:
[xUnit.net 00:00:02.12]            at DynamicExpresso.Parsing.Parser.ParseNew()

We can make this happen by running tests in xunit which occur in parallel between test fixtures. One interpreter per test case, however the loading of types on first use may still occur in parallel.

You're saying that a single run of your test works every time, but that it fails if it runs in parallel to another test? And that each test has its own instance of interpreter?
I find this surprising, because the only thing shared between instances of Interpreters are the primitive types. Custom types that are registered via Interpreter.Reference are scoped to their Interpreter instance. To resolve the constructor, the standard .NET API is used to get all the potential constructors from the type, and then candidates are filtered out.
It's also worth noting that if you see this error message, it means we successfully detected that you're trying to instantiate type X4BFlow.Test.Nf9.TestTemplatePrototype+TemplateTest, so the issue isn't type registration. The issue is that we can't find any constructor that matches the arguments provided.
Can you share an example of a test that fails? Maybe it's an issue with generics resolution.

@metoule Can do:
using System;
using System.Buffers.Binary;
using System.Collections.Generic;
using X4BFlow.Main.Nf9.Models;
using X4BFlow.Main.Nf9.NetflowParser;
using X4BFlow.Main.Nf9.NetflowParser.Attributes;
using X4BFlow.Main.Nf9.NetflowParser.FieldTypes;
using Xunit;

namespace X4BFlow.Test.Nf9
{
    public class TestTemplatePrototype: INetflowFlow
    {
        class TemplateTest: INetflowFlow
        {
            [NetflowFieldPropertySetter(FieldType.DIRECTION)]
            public byte u8;
            [NetflowFieldPropertySetter(FieldType.L4_SRC_PORT)]
            public UInt16 u16;

            [NetflowFieldPropertySetter(FieldType.CT_STATUS)]
            public UInt32 u32;
        }

        [Fact]
        public void TestUInt8()
        {
            TemplatePayloadPrototype payloadPrototype = new TemplatePayloadPrototype(typeof(TemplateTest), new NetflowParseRow[] { new NetflowParseRow(0, (ushort)FieldType.DIRECTION, 1) }, NetflowSession.Interpreter);

            Assert.Equal("new TemplateTest{u8=input[i]}", payloadPrototype.BuildFunctionBody());
            var fn = payloadPrototype.BuildTemplateFunc();
            Assert.NotNull(fn);
            var t = fn(new byte[] { 1 }, 0) as TemplateTest;
            Assert.Equal(1, t.u8);
        }

        [Fact]
        public void TestUInt16()
        {
            TemplatePayloadPrototype payloadPrototype = new TemplatePayloadPrototype(typeof(TemplateTest), new NetflowParseRow[] { new NetflowParseRow(0, (ushort)FieldType.L4_SRC_PORT, 2) }, NetflowSession.Interpreter);

            var fn = payloadPrototype.BuildTemplateFunc();
            Assert.NotNull(fn);
            byte[] input = new byte[2];
            BinaryPrimitives.TryWriteUInt16BigEndian(input, 1);
            var t = fn(new byte[] { 0, 1 }, 0) as TemplateTest;
            Assert.Equal(t.u16, 1);
        }

        [Fact]
        public void TestUInt32()
        {
            TemplatePayloadPrototype payloadPrototype = new TemplatePayloadPrototype(typeof(TemplateTest), new NetflowParseRow[] { new NetflowParseRow(0, (ushort)FieldType.CT_STATUS, 4) }, NetflowSession.Interpreter);

            var fn = payloadPrototype.BuildTemplateFunc();
            Assert.NotNull(fn);
            byte[] input = new byte[4];
            BinaryPrimitives.TryWriteUInt32BigEndian(input, 1);
            var t = fn(new byte[] { 0,0,0, 1 }, 0) as TemplateTest;
            Assert.Equal(1u, t.u32);
        }
    }
}

They share an interpreter, but all usage is controlled by a lock.
In this example there is only two interpreter usages:
public void BuildFunctionBody(ref Utf16ValueStringBuilder ret, Type targetType, HashSet<FieldType> alreadyConsumed)
    {
        lock (_interpreter)
        {
            if (_interpreter.ReferencedTypes.FirstOrDefault(a=>a.Type == targetType) == null)
            {
                _interpreter.Reference(targetType);
            }
        }
       // ...
}

    public Func<byte[], int, INetflowFlow> BuildTemplateFunc()
    {
        var body = BuildFunctionBody();
        Lambda l;
        lock (_interpreter)
        {
            l = _interpreter.Parse(body, ExpressionParams);
        }

        return l.Compile<Func<byte[], int, INetflowFlow>>();
    }

I'm well aware this is not a runnable example on its own. Creating a small test case that doesnt exercise our Netflow Template tooling is on my TODO list.

FYI I also tried locking the compile (although documentation suggests this is not necessary). This did not help.
These are the only functions called into Interpreter. lambda.Compile is called outside of the lock as is the Func<> returned.

I think that the problem is that you can have one thread that modify the Interpreter (calling Reference, ...) While another thread is calling Compile. This is not supported.
For unit testing I suggest to not share the instances. For real usage code I suggest to have an initialization phase where you configure it, and the call only read only functions.

I think that the problem is that you can have one thread that modify the Interpreter (calling Reference, ...) While another thread is calling Compile. This is not supported.

This is not the case. As you can see the only 2 usages of interpreter are locked against the interpreter object.
These are the only 2 calls in the interpreter object.
I do plan to make a small runnable replication test at some point.

@davideicardi If you are trying to say that Lambda.Compile is not threadsafe (I've verified that placing this in a lock does not solve the problem...) then the README definately needs to be changed.
After all it is explicit in stating:
```Lambda and Parameter classes are completely thread safe.````

Ok, I found the problem. For reference @davideicardi and @metoule.
When a type is referenced it's referenced by its Name, not it's FullName therefore when the types that do not exist in the interpreter are referenced one replaced the other.
This is probably worth a documentation note against public Interpreter Reference(Type type) using the alternative method with a typeName paramter would have resolved this issue.

I don't think using the other Reference overload would have prevented your issue. The typeName argument is the identifier that is used by DynamicExpresso to detect a referenced typed in an expression. For example in a constructor call:
new TypeName()

the TypeName identifier is used as the key to map it to a referenced type. You can't reference two types with the same name because there would be no way to know which type to use based on that single identifier. For example, :
namespace N1 { public class TypeName {} }
namespace N2 { public class TypeName {} }

var expr = "new TypeName()"; // <-- no way to know which type to use

We could use the type's FullName for resolution, and raise an AmbiguousTypeException if there's an ambiguity, but that would require supporting FullNames during the identifier resolution, which is far from trivial:
var expr = "new N1.TypeName()"; // <-- this is not supported at the moment


fix: update author and tag header with article feed

Description
update tag header and author header to consume new author and tag page import
Links

tag: https://tag-author-header--blog--adobe.hlx3.page/en/topics/creativity
author: https://tag-author-header--blog--adobe.hlx3.page/en/authors/scott-belsky
https://tag-author-header--blog--adobe.hlx3.page/?delayed=off

I fixed the conflicts with my best guess. @fkakatie I'll merge PR, could you verify the changes when back online ?


Revert "etcdhttp: add internalVersion"

This reverts commit a77bf97c147a93e5b78898b427d081ba11b8f118.
Conflicts:
version/version.go

lgtm


Recent tweets will only be scraped

This commit does

Recent tweets are only being scraped; logic being tweets scraped before the day the /start command is passed wont be sent to the telegram user
Converts the format of date being logged in tid_store.csv

If I get example screenshots with tid store etc would make the review process easier.

If I get example screenshots with tid store etc would make the review process easier.

I have posted it on slack

Apart from the few inline reviews yet to be clarified on how to handle the scraping if there is no previous date to pick from the tid store.


Holding shift shows two lines of symbols on tooltip of any item with aspects

https://github.com/Azanor/thaumcraft-beta/issues/233

Oh, sorry, nvm.


Fix the bug that commonjs doesn't work for @azure/web-pubsub-client-protobuf

Packages impacted by this PR
@azure/web-pubsub-client-protobuf
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/25703
Describe the problem that is addressed by this PR
As protobufjs is purely commonjs type but rollup bundle didn't add commonjs support. So only file in dist-esm/ works but in dist doesn't.
Are there test cases added in this PR? (If not, why?)
Test already added cjs() plugin in bundle, so it works.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

I believe dev-tool run bundle command generates commonjs to dist/index.js.  Is it missing anything that your need? I see that you have exports: "named", which is not in our base config.  /cc @willmtemple
https://github.com/Azure/azure-sdk-for-js/blob/e2d75d2863cdb7da5f058757a206672142b62b4a/common/tools/dev-tool/src/config/rollup.base.config.ts#L205

@jeremymeng Maybe I'm wrong, but I think dev-tool run build uses this config. Add tried to add cmj() to it locally to have a test and it works. https://github.com/Azure/azure-sdk-for-js/blob/e2d75d2863cdb7da5f058757a206672142b62b4a/common/tools/dev-tool/src/commands/run/bundle.ts#L68

@zackliu you are right!  I don't know why we don't have cjs() there. Could be a bug. @willmtemple do you remember?

I don't know why we don't have cjs() there.

maybe because the assumption is that all input are ESM.  But in your case, if I understand correctly, some generated CJS files got copied over?

@jeremymeng I tried, and it works. Yes in this case, protobufjs is cjs and needs to be copied in dist

builds failing likely because of missing rush update

@jeremymeng Test passed. Please help to merge it.


Add description to library and asset detail pages

The library schema has a description. That needs rendered above the dashboard on the library detail page.

[x] Link to redline @kingtraceyj
[x] Open issue so @aubrey-oneal can update existing library descriptions https://github.com/carbon-design-system/carbon-platform/issues/559

For visual reference, this is adding A.

Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @francinelucca

library redlines: https://ibm.box.com/s/s6btwm637udnek3pbjtfem412kgw83hp

@andreancardona I set sprint 16.

@mattrosno sounds good thank you!

is there a separate issue to update lib descriptions once #559 is complete? or is #559 blocking this one? @mattrosno

@francinelucca since we're in a beta still (kindof a private beta as you need IBM employee auth to view), I don't believe #559 to be a blocker. But definitely something we'll want to do prior to v1.


Print CVXPY information when verbose=True

Is your feature request related to a problem? Please describe.
Not related to a problem.
Describe the solution you'd like
When the argument verbose=True is passed to the Problem.solve method, print some status information about the CVXPY canonicalization, like canonicalization started, expression tree parsed, generating affine maps, sending to solver, etc...

I think this is a good idea.
I'm not sure about having verbose=True triggering cvxpy logging, but I definitely support the larger idea. As a possible alternative,Problem.solve could accept a keyword argument like canon_log. If someone called prob.solve(canon_log=True) then the behavior would log to sys.stdout. If someone called prob.solve(canon_log=my_stream) for some datastream my_stream, then sys.stdout would be untouched.
For an implementation, it would be most natural to have Reduction objects decide how to handle logging during their apply and invert phases. It would be easy to identify performance bottlenecks by having apply functions record time.time() when starting and finishing each reduction. There is a question of at what level these logs should be made, though.
Those are just some quick thoughts I have on the topic.

I also think this is a good idea! I’m hesitant to add new arguments unless absolutely required, though, since they make the interface more complicated. Using the verbose argument to trigger CVXPY logging seems natural.

love this thread ! Any sort of verbose would be incredibly useful.

Hi,
I think the idea of printing info on screen when "verbose = True" as actually implemented is good. However, low-level logging when "verbose = log" could be very useful. Think about deploying cvxpy in docker containers or in raspberry pi, then the logging option I think is a must-have.
If there are some advances in the implementation of the logging option I will love to be noticed! Currently, I'm needing it!
Regards

I would also support such a feature, would be very useful for checkiing progress on large problems with many constraints.

Addressed in https://github.com/cvxgrp/cvxpy/pull/1251


Update the docs link to googleapis.dev

This change is

@coryan
That is because we're still using the top page at https://googleapis.github.io/google-cloud-cpp/index.html. I'll migrate the library top page once we migrate it to googleapis.dev.


test: added tests to ensure correct uglify-es version is being used.

Fixes https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/67#issuecomment-313425627

Attack of the modules .... again ! :p

Jeez, i guess i was incorrectly assuming the uglify-es version as the cause. what does this print out for u?
node -v
npm -v
cat node_modules/webpack/package.json | grep version
cat node_modules/uglify-es/package.json | grep version
cat node_modules/uglify-js/package.json | grep version

@d3viant0ne can u try installing npm >= 5? I suspect it's related to package-lock.json not being respected.

It sometimes works locally (macOS) for me, but the test are definitely flaky. But what is this test actually testing here ? 🙃

@michael-ciniawsky the test in this PR is not actually intended to be merged. Just an attempt to find the cause of this issue.


NOISSUE: make jetDropRegister map

- What I did
Change jetDropRegister from list to map (to make it uniq and more easy to check fullness)
- How to verify it
Run tests

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   72.80%   72.80%
=======================================
  Files          47       47
  Lines        3104     3104
=======================================
  Hits         2260     2260
  Misses        697      697
  Partials      147      147

Impacted Files
Coverage Δ

etl/controller/controller.go
95.34% <100.00%> (+0.22%)
:arrow_up:

etl/controller/pulsemaintainer.go
86.91% <100.00%> (-0.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5819a...89fa5c3. Read the comment docs.


go/runtime/host/protocol: Add write timeouts

Fixes: #3289

While I expect this sort of thing to be exceedingly rare, should it be configurable? (No is a fine answer).

should it be configurable

Probably no need specially since on the runtime side the requests get queued so the write should not really get blocked by anything in case everything is fine.


[vcpkg] Fix unsupported modifiers for X_VCPKG_APPLOCAL_DEPS_INSTALL.

Issue #1653 and PR #14243 introduced support for automatic installation of dependencies when using cmake install. However, the current implementation raises an error, if the INSTALL(TARGETS) command is used with the EXPORT and/or INCLUDES DESTINATION modifier.
INSTALL(TARGETS mytarget EXPORT mytargetConfig ...) associates the specified targets with an config file that can be later be installed separately using INSTALL(EXPORT mytargetConfig ...), whilst the INCLUDES DESTINATION specifies a list of include directories that will be added to the export configuration.
The CMake documentation also lists those modifers.

Thanks for the PR!


The architecture link in Todo.elm is broken

Todo.elm points to http://elm-lang.org/learn/Architecture.elm, which 404's.

Should be better now. Thanks for reporting!


How to update file contents in Google Drive

I've been able to successfully upload a file using MediaFileUpload. But I'm wondering how you update the contents of an existing file? Can MediaFileUpload be used with update, or is there a way to somehow pass the new data to Files::update()? I've not been able to find any information about this pertinent to V3.

Thanks for this! I was searching for the same thing.


Missing 0.5.6 on pypi

We revert the update of 0.5.6 because the version is missed now on pypi.

That’s correct, v0.5.6 had an issue so I removed it (I only saw the version was bumped in HA after the PR was merged).
I am working on an updated version and on a PR for HA which I want to have ready for the next beta.

Fixed via https://github.com/home-assistant/home-assistant/pull/26098.


Add a new --precedence option to the resolvableConfigurations report to print attribute disambiguation rule priority in the report

Fixes #20956
When enabled, makes the bottom rules section look like:
Disambiguation Rules
--------------------------------------------------
The following Attributes have disambiguation rules defined.

    - flavor
    - org.gradle.category (1)
    - org.gradle.dependency.bundling (5)
    - org.gradle.jvm.environment (6)
    - org.gradle.jvm.version (3)
    - org.gradle.libraryelements (4)
    - org.gradle.plugin.api-version
    - org.gradle.usage (2)

(Attribute disambiguation precedence)

Is there any reason to not just always show this (IOW, we don't need a new option)?

I was just thinking not to surprise anyone with new data suddenly appearing.  But we could drop the option and make this the default if you 'd rather do it that way.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

@bot-gradle test and merge

OK, I've already triggered a build for you.


Keep k8s clients around to avoid cost of re-generating them all the time

We should measure how long it takes to build a client. My guess is that with the amount of times we re-build clients we may be incurring a significant cost.

Wow. I knew this was an issue but not how much of an issue.
I just ran a migration that took 3 minutes, 4 seconds to complete.
Summing up the time spent on constructing a client, mig-controller spent 217,123 milliseconds creating clients.
Total Migration Time: 184 seconds
Client Creation Time: 217 seconds (parallel controllers)
That's 3.6 minutes of controller time creating clients (this is possible because there are multiple controllers) but wow. Keeping the clients in memory instead of recreating all over the place looks like it could have a huge impact on how quickly things could run.

This is pretty awesome. Simply by using a client we already created, migration time was decreased from 184 seconds to 70 seconds!
This means the migration only took 38% as long as originally.

keepclient.txt

In-cluster results:
Not nearly as big of a difference, but definitely still a healthy improvement (10 seconds). It seems that the impact of this change may be related to latency. Running off my laptop it had a much bigger improvement. I suspect we would also see large improvement running across data centers, which is one of the performance areas for improvement we spotted.
Keep clients in memory (77 seconds)

Recreate clients (87 seconds)

Will be resolved by #1037


the example code doesn't update as per the selected wrap

https://user-images.githubusercontent.com/3253920/236715748-e490b2a6-d5c5-4f40-8e91-2380729f9343.mp4

was an issue with the code highlighter


Allow remoteOptions to be set from a function

When using asyncValidator, I found it very useful to be able to load remoteOptions dynamically - in the case where the values of other form inputs are needed to validate the target input. For example, a password validator that ensures the user's personal info (name, email, etc.) is not contained in the password.

There's already a mechanism to do this, using the field:ajaxoptions event (check http://parsleyjs.org/doc/index.html#remote-events).
Is that enough?

Yes! Sorry I guess I did not expect to use events in that way. I'm used to seeing it done with callbacks. Thanks!

Yeah, a function was also my first thought. A long discussion in #894 later and an event was used instead. Makes it easier to compound transformations if need be.


Mark block invalid if partial of full validation fails

After FV or PV fail we should mark blocks as invalid AND when we receive a header we check against invalid blocks list and if presented header is there- ban the peer.

fixed


[CLOSED] Error installing plug-in (error importing pandas)

 Issue by yipjackie
Wednesday Feb 26, 2020 at 17:21 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT
Originally opened as https://github.com/IBIGroupCanWest/CanFlood/issues/6

After a clean install of QGIS 3.10 (downloaded the long-term release for Mac OS from https://www.qgis.org/en/site/forusers/download.html) and the First Aid plug-in, the installing of the CanFlood plug-in gave an error as shown below - suggesting that it needs pandas 0.25.3 or higher.

Also included here the About QGIS page for reference

 Comment by s4lt3d
Wednesday Feb 26, 2020 at 18:57 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Pandas not installed or incorrect version installed
Some versions of QGIS may not come with all required python packages.
This issue can be solved with two simple commands shown below.
Example Error Message on Windows

Fixing the issue by installing Pandas manually
Open the Python Console in QGIS

The Python Console should appear in QGIS and should look similar to to this.

Type the following commands in the console.
import pip
pip._internal.main(['install', 'pandas'])

Conclusion
Running the two commands should correctly install pandas, which will allow CanFlood Alpha to open successfully.

 Comment by yipjackie
Wednesday Feb 26, 2020 at 23:50 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Thanks Walter! I've had to modify the command slightly as in the screenshot. I think it shows it is still using pandas 0.24.2

 Comment by cefect
Thursday Feb 27, 2020 at 17:51 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

If you installed QGIS through OSGeo, a better solution is to go through the OsGEO4w shell (executed from this .bat file... sometimes there is a shortcut). On Windows, ensure you right click > run as Administrator:

run these commands:
py3_env
python -m pip install pandas

If installing other dependencies, replace 'pandas' with whatever you're trying to install.
You can then test it was installed properly by executing these commands (in the same session):
python
import pandas
pandas.__version__

You should see '0.25.3' or higher displayed

If this still fails, try uninstalling qgis, and re-installing with the OSGeo4W Network Installer, Advanced Install option. On the 'Select Packages' page, type 'qgis-ltr-full' into the search bar, expand 'Desktop' and ensure the 'New' (or 'Current') version shows 3.10-2 or higher. Then type 'python3-pandas' into the search bar, and ensure 'New' shows 1.0.1-1 or higher. Click through and this should install Qgis 3.10 nicely with Pandas.
This procedure should work for any dependency error


frontend and guide added to dictionery

Description
previously there was no guide that how this will work and also there were some mistake in manifest.json file i ahve added frontend and tested it correctly
Fixes:  #778

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy
dictionary extension bug fixed and frontend added


[Enhancement] Add ExternalScanContextMgr Method #39616

Implement method 'get_active_contexts': Print '_active_contexts_message' detailed information
Implement method 'clear_inactive_scan_contexts': According to inactive_time_s, clear inactive scan
SQL 'admin execute' add method:

external_scan_context_mgr.get_active_contexts
external_scan_context_mgr.clear_scan_context
external_scan_context_mgr.clear_inactive_scan_contexts

Why I'm doing:
'starrocks_be_active_scan_context_count ' of be, need query detail #39616
What I'm doing:
SQL 'admin execute' implement method: get_active_contexts/clear_scan_context/clear_inactive_scan_contexts
Fixes #39616
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.huangjie25 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Git (Source Control): Panel does not show unstaged/staged changes while editing contents of an existing commit

Type: Bug

Start an interactive rebase with one commit marked as "edit"
When rebase is stopped at the commit to edit: Run git reset --soft HEAD~1
The source control panel should now show the contents of the commit as staged changes, but it does not
Edit any file in the repository
The source control panel should now show that edited file as an unstaged change, but it does not

So when you soft-reset while editing a commit in a rebase, vscode won't show any staged or unstaged changes anymore.
VS Code version: Code - Insiders 1.85.0-insider (eb56719ae7653bff54989385818ef39e1cd73d29, 2023-11-24T15:21:05.133Z)
OS version: Linux x64 6.7.0-rc2-273-tkg-eevdf
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 9 5900X 12-Core Processor (24 x 2240)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
31.28GB (18.20GB free)

Process Argv
--unity-launch --crash-reporter-id 8ca40cd8-565b-4147-b010-266434c9f2f1

Screen Reader
no

VM
0%

DESKTOP_SESSION
xfce

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
xfce

XDG_SESSION_TYPE
x11

Extensions (10)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

better-cpp-syntax
jef
1.17.2

remote-containers
ms-
0.321.0

remote-ssh
ms-
0.107.0

cmake-tools
ms-
1.16.31

cpptools-extension-pack
ms-
1.3.0

live-server
ms-
0.4.11

remote-explorer
ms-
0.4.1

scala
sca
0.5.7

cmake
twx
0.0.17

(4 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
vsc_aa:30263845
pythonptprofiler:30281269
vshan820:30294714
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
pythonmpswarning:30859870
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30871582
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Hello @lszomoru, it looks like in the time between me reporting this bug and now the bug has evaporated, possibly because of a VSCode Insiders update (I'm running a newer version now). Thank you for looking into it nonetheless! If I ever encounter it again I will make a screen recording first and then open a new bug with it attached.


Can't browse all video files in RealDebrid cloud upload

Hello, I have uploaded every episode of The Colbert Report to my Real Debrid cloud, as the formatting of the season/episode structure makes it so that it cannot be scraped from Cinemeta. However, when I browse the upload via the Others section, it only shows about 50 of the nearly 900 video files. Is there a limit to how many can be browsed? I also have every episode of Saturday Night Live, and have no issue browsing those, although there are less of them.
Thank you!

No, it's not limited and returns all video files that are available in the entry.


Adding streaming function to mistralrs server.

I added it here: https://github.com/EricLBuehler/mistral.rs/pull/986/files#diff-f5353372481ead383ebfd7ee987dac8fa54f0cc82d81fcce2a03526de5e801bbR79-R88
Where else do you think it should be added ?

Can you please add it as an example here: https://github.com/EricLBuehler/mistral.rs/tree/master/mistralrs/examples ?


cmd/go: go mod init . creates a module called .

What version of Go are you using (go version)?

% go version
go version devel +b388d6868f Thu Jun 13 03:58:18 2019 +0000 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?
(~/src/d) % go mod init .
go: creating new go.mod: module .
(~/src/d) % ls
go.mod  main.go
(~/src/d) % cat go.mod
module .

go 1.13

What did you expect to see?
My gopath is set to ~/src, tf. the modules name should be d.
What did you see instead?
The module is called . which is not valid
(~/src/d) % go test
build _/Users/dfc/src/d: cannot find module for path _/Users/dfc/src/d
(~/src/d) %

@davecheney I think expected should be an error, . is not a valid module path (emphasis by me):
$ go help mod init
usage: go mod init [module]

Init initializes and writes a new go.mod to the current directory,
in effect creating a new module rooted at the current directory.
The file go.mod must not already exist.
If possible, init will guess the module path from import comments
(see 'go help importpath') or from version control configuration.
To override this guess, supply the module path as an argument.

/cc @bcmills


Add Rush B by Sheet Music Boss

Song Name
Rush B
Artist Name
Sheet Music Boss
Source
Youtube
Youtube Link
5zo7BYoaqAA
Direct File Link
No response
Song ID
571236
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 101324845

accept


Improved README.md

Added a few more helpful links to the README.

 All I changed was the README

I'll include the link to MacVim, since that is directly related.  Adding links to alternatives and plugins doesn't really belong here.


Add support for Spaces

Motivation
We have added support for Spaces to the management api, so the SDK should support working with Spaces too.
Proposed solution
Extend the SDK to support operations with Spaces:

Create a space
Get a space
Get all spaces
Patch a space
Delete a space

SDK now supports all listed Space operations, and I'm adding support for WSL root items now. I think this issue can be closed.


[WIP] Add Travis configuration

This is an attempt at resolving #43.

Many thanks. Let me know when it's ready for merge.
I think it may be worth running a full make build before ./shake-build/build.sh. Otherwise we are long way of seeing the build succeed.

I'm in favor of omitting make, so that issues surface immediately and are not shadowed by prior make runs.
@bgamari can we run CI on Mac or Windows as well with Travis?

Is it possible to have two different instances of Travis? There are benefits to both from-the-scratch and from-make builds.

Instead of doing a full make why don't we simply enumerate precisely which targets need to be built? Not only will this keep the build time down, but it also gives us a check-list for which functionality remains unimplemented.

@bgamari :+1: I just never got the make system to only build certain targets, it always went ahead and built everything (or that's like how it felt).

@bgamari Sounds good! Some targets are very close to the full build (e.g. the ghc package), but many are really small almost independent ones.

I think this is now obsolete due to #93. @bgamari

Thanks @bgamari and @quchen! I'll close this.


Start compatibility work on SASS 2

Description
Fixes deprecation warnings starting in SASS 1.79 and fixes #40849
Motivation & Context
Plone is using Twitter Bootstrap with it's default theme. When doing JavaScript work, webpack presents a big warning and breaks execution of any other code.
We will silence the warnings as described in https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#silencing-warnings but for progressing, this issue needs to be fixed anyways.
Type of changes
It changes the usage of the deprecated red, green and blue converter functions.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[ ] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Tests do not pass. Therefore this PR is in draft mode. Help wanted.
Live previews
There are no documentation changes.
Here is a Preview to the SASS playground where I tested my changes:
https://sass-lang.com/playground/#eJyVj0EKwyAQRfeeYpAEFCQYSheNm1xF46ALqzDW+1fTRbPNapjPf4+Zdd1bReDV1rodJRXihl2it/3EnrCJ0G8wtoVKy16c3eWINmdMItYkXtpjgIee4alnqYB3hCug4KQ0bAqEmO8qTugicanhXcdg/gq2e3QtwHhIwe+qPkfJfAFc21KF
Related issues
https://github.com/twbs/bootstrap/issues/40849

Thanks for trying something for this issue @thet
Unfortunately, Bootstrap v5 still need to support node-sass too. So using sass:math nor sass:color won't probably be possible. This is why this issue will be tricky IMO.

Ah, node-sass is giving that error.
Thanks for pointing out!

Thanks for your work on this! I'm going to close it for now to help keep our backlog manageable. Feel free to reopen it if you come up with a different or new solution :)


moving preview version to public folder

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

    "operationId": "Monitors_ListMonitoredResources",

Pleasehttps://github.com/Azure/azure-openapi-validator/blob/main/docs/operation-id-noun-verb.md
Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore.

Refers to: specification/newrelic/resource-manager/NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json:826 in 076b64c. [](commit_id = 076b64ca7aaafec9f589761a16c79fedb85751a9, deletion_comment = False)

Please see if you can fix the linter errors https://github.com/Azure/azure-rest-api-specs/pull/22447/checks?check_run_id=11091771476

/azp run


Adding support for sleep function

I needed the sleep function too, so I did the patch. Hope you accept it.

Thanks for the contribution! Would you mind changing the printf to a preeny_debug? That way the program output can stay the same.

Done! I also modified the makefile to make it more generic. I don't get why this commit was automatically added to the pull request.

Thanks! That makefile looks really slick now!


Add ability to configure the full flavor when using the simple thumbnail mode

It would be great if the full flavor could be configured when using the simple thumbnail mode, where only a single thumbnail is created. Right now, only the sub-flavor can be configured.

Unfortunately, this does not seem to be an easy change to make. The editor currently heavily associates thumbnails with tracks by way of their main flavors (so much so in fact that thumbnail data is passed as part of the track data between backend and frontend). Allowing to freely configure the main-flavor would therefore be pointless, as configuring it to anything but a track-main-flavor (e.g. presenter or presentation) would simply not work. Properly rewriting the editor to disassociate between thumbnails and tracks would be quite a bit of work.

@Arnei, what main-flavor is used in simple mode in case you have 1, 2, or more videos?

The flavor you defined as thumbnail.priority.flavor in org.opencastproject.editor.EditorServiceImpl.cfg. in fact, you have to set thumbnail.priority.flavor or Simple Mode won't activate (falls back to Professional Mode).


ci: allow manually deploying code

Work done to match the deployment process https://github.com/customerio/mobile/blob/levi/deploy-docs/GIT-WORKFLOW.md

Pull request title looks good 👍. If this pull request gets merged, it will not cause a new release of the software.
Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0.
To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

:tada: This PR is included in version 1.0.0-alpha.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cannot use track pad to scroll / pan in the InteractiveViewer on web

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Run flutter run on the code sample on macos
Notice you can use the track pad to pan/scroll horizontally and vertically
Run flutter run on the code sample on web

Notice you cannot use the track pad to pan/scroll horizontally and vertically

Expected results
I expect to be able to use the trackpad to pan/scroll horizontally and vertically on web and macos
Actual results
I'm only able to use the trackpad to pan/scroll horizontally and vertically on macos. It only allows scaling on web.
Code sample
Code sample
It is the example from  https://api.flutter.dev/flutter/widgets/InteractiveViewer-class.html
or you can check-out https://github.com/ValentinVignal/flutter_app_stable/tree/flutter/scroll-with-interactive-viewer
import 'package:flutter/material.dart';

/// Flutter code sample for [InteractiveViewer].

void main() => runApp(const InteractiveViewerExampleApp());

class InteractiveViewerExampleApp extends StatelessWidget {
  const InteractiveViewerExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('InteractiveViewer Sample')),
        body: const InteractiveViewerExample(),
      ),
    );
  }
}

class InteractiveViewerExample extends StatelessWidget {
  const InteractiveViewerExample({super.key});

  @override
  Widget build(BuildContext context) {
    return Center(
      child: InteractiveViewer(
        boundaryMargin: const EdgeInsets.all(20.0),
        minScale: 0.1,
        maxScale: 1.6,
        child: Container(
          decoration: const BoxDecoration(
            gradient: LinearGradient(
              begin: Alignment.topCenter,
              end: Alignment.bottomCenter,
              colors: <Color>[Colors.orange, Colors.red],
              stops: <double>[0.0, 1.0],
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

macOS
Web

https://github.com/flutter/flutter/assets/32538273/53627f3c-e5aa-4dfd-952f-907b34f6786e

https://github.com/flutter/flutter/assets/32538273/ea6bcfe0-aded-4a87-9e98-31e153bd7a72

Logs
Logs
Macos:
Building macOS application...
Syncing files to device macOS...                                   110ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on macOS is available at: http://<IP_ADDRESS>:57712/HsQPfYA_1FY=/
The Flutter DevTools debugger and profiler on macOS is available at: http://<IP_ADDRESS>:9101?uri=http://<IP_ADDRESS>:57712/HsQPfYA_1FY=/
2023-11-07 11:48:55.545 flutter_app_stable[18836:163823] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

Application finished.

Web:
Launching lib/main.dart on Chrome in debug mode...
Waiting for connection from debug service on Chrome...             24.7s
This app is linked to the debug service: ws://<IP_ADDRESS>:58189/4L3YL0adXrc=/ws
Debug service listening on ws://<IP_ADDRESS>:58189/4L3YL0adXrc=/ws

🔥  To hot restart changes while running, press "r" or "R".
For a more detailed help message, press "h". To quit, press "q".

A Dart VM Service on Chrome is available at: http://<IP_ADDRESS>:58189/4L3YL0adXrc=
The Flutter DevTools debugger and profiler on Chrome is available at: http://<IP_ADDRESS>:9101?uri=http://<IP_ADDRESS>:58189/4L3YL0adXrc=

Application finished.

Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.13.9, on macOS 14.0 23A344 darwin-x64, locale en-GB)
    • Flutter version 3.13.9 on channel stable at /Users/valentin/flutter/flutter
    ! Warning: `dart` on your path resolves to /usr/local/Cellar/dart/3.1.2/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/valentin/flutter/flutter. Consider adding
      /Users/valentin/flutter/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (12 days ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /usr/local/Caskroom/android-sdk/4333796
    • Platform android-33, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.84.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.0 23A344 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 119.0.6045.105

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Thanks for filing this. I can reproduce this on the latest master and stable channels. Using Trackpad works fine on macOS but it only scales with Trackpad on Web.

MacOS
Web

stable, master flutter doctor -v

[!] Flutter (Channel master, 3.17.0-1.0.pre.60, on macOS 14.0 23A344 darwin-arm64, locale en-NG)
    • Flutter version 3.17.0-1.0.pre.60 on channel master at /Users/damilolaalimi/fvm/versions/master
    ! Warning: `flutter` on your path resolves to /Users/damilolaalimi/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/damilolaalimi/fvm/versions/master. Consider adding /Users/damilolaalimi/fvm/versions/master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/damilolaalimi/fvm/versions/master. Consider adding /Users/damilolaalimi/fvm/versions/master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6007b91a37 (8 minutes ago), 2023-11-07 02:43:32 -0500
    • Engine revision 7f4d56a7f4
    • Dart version 3.3.0 (build 3.3.0-102.0.dev)
    • DevTools version 2.30.0-dev.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.84.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        • android-arm64  • Android 14 (API 34) (emulator)
    • Damilola’s iPhone (mobile)  • 00008110-001964480AE1801E            • ios            • iOS 17.0.2 21A351
    • iPhone 15 Pro Max (mobile)  • 56A225C9-B8F6-4201-A0AE-8C3CFA4CE152 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)             • macos                                • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 119.0.6045.105

[!] Network resources
    ✗ A network error occurred while checking "https://github.com/": Operation timed out

! Doctor found issues in 3 categories.

[!] Flutter (Channel stable, 3.13.9, on macOS 14.0 23A344 darwin-arm64, locale
    en-NG)
    • Flutter version 3.13.9 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    ! Warning: `dart` on your path resolves to
      /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/damilolaalimi/sdks/flutter.
      Consider adding /Users/damilolaalimi/sdks/flutter/bin to the front of your
      path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (12 days ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio
      Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.84.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 14 (API 34) (emulator)
    • Damilola’s iPhone (mobile)  • 00008110-001964480AE1801E            • ios
      • iOS 17.0.2 21A351
    • iPhone 15 Pro Max (mobile)  • 56A225C9-B8F6-4201-A0AE-8C3CFA4CE152 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)             • macos                                •
      darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)                • chrome                               •
      web-javascript • Google Chrome 119.0.6045.105

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 3 categories.

Similar Google internal issue: b/307336053


SendKeys doesn't work for no reason

What versions are you running?

$ go list -m github.com/chromedp/chromedp
github.com/chromedp/chromedp v0.5.1
$ google-chrome --version
Version 78.0.3904.108
$ go version
go version go1.13 windows/amd64

What did you do? Include clear steps.
I'm trying to fill a textarea, with as a selector #message. (You can try on usernames.org, but you have to be logged in.),
func bumpThread(url, message string) chromedp.Tasks {
	return chromedp.Tasks{
		chromedp.Navigate(url),
		chromedp.WaitVisible(`#message`),
		chromedp.SendKeys(`#message`, message),
		chromedp.WaitVisible(`#quick_reply_submit`),
		chromedp.Click(`#quick_reply_submit`, chromedp.NodeVisible),
	}
}

What did you expect to see?
Fill the textarea and click the button
What did you see instead?
Hanging, even when I remove the WaitVisible, nothing appears. Tried to evaluate and set the value manually, it does the same. The weird thing is that on another MyBB Forum, this code works fine.

Try using ByQuery:
chromedp.WaitVisible(`#message`, chromedp.ByQuery),
chromedp.SendKeys(`#message`, message, chromedp.ByQuery),

I'm going to assume that @opennota's suggestion worked, because that's what I would suggest too.


Frenchdocs

Translation of React docs in French
I want to translate the react documentation in french to allow some people that doesn't understand the English to learn react. that is will allow at french people to be comfortable with our native language in the learning of React

Thanks for asking about the translations. The docs are translated using CrowdIn. You can sign up to to help here: https://crowdin.com/project/react


BeWord scaladoc uses invalid links to (deprecated) ShouldMatchers

The scaladoc of BeWord links to Should- and MustMatchers, but they don't exist (they were moved to matchers package).

Thanks for pointing that out. I fixed it in 2.3.x as well and a also a couple other mentions of ShouldMatchers.
https://github.com/scalatest/scalatest/commit/e227e5e981cd473aebe24f0745506e9291ca3fe3


WIP: Craete read and write access level roles and give grants

The prom_reader and prom_writer roles are created
and granted specific access to all the different schemas,
tables and functions. prom_writer inherits from prom_reader.
prom_reader has read-only access.
TODO:

[x] Idempotent role creation
[x] didn't know which of the functions are considered 'admin' functions so added the grants to all, please comment which shouldn't be granted at all to prom_read/write

Committed changes per comment suggestions. Additionally:

Also assumed set_chunk_interval functions are admin as set_retention
Granted only select on SCHEMA_METRIC since it has only views as SCHEMA_SERIES


Implement Belady's optimal cache for oracle-aware extractors.

This is a little tricky and I can't figure out a way to do it without a sort, which incurs a O(log n) pop/push compared to the O(1) of a simple LRU cache. But if there is any non-trivial reuse of chunks, LRU suffers a cache hit, which is probably worse than O(log n) look-up; the question is how to limit any performance degradation to the situation where we detect reuse.
We achieve this with a two-pass algorithm. In the first pass, we store the sequence of requested chunks as well as their future access times in a std::vector<Index_> with std::vector<size_t> where the latter is an index into the former. (The "access time" is counted in terms of the number of unique chunks that might enter the cache.) This can be created fairly easily by just creating a map of the last access time for each chunk ID, and then updating the future access vector during iteration. In fact, a more sophisticated version of this would use a just-in-time generator to avoid any intermediate allocations.
We then create the actual cache, a std::unordered_map<Index_, Chunk_> that holds the active chunk IDs and their contents. We also create a std::set<std::pair<Time_, Index_> > (yes, a sorted set) of chunk IDs sorted by the next access time in decreasing order. We perform another pass through the prediction sequence, adding chunks to the cache if they're not already there; this is accompanied by the addition of the same chunk's ID with its next access time to the sorted set. We recycle the front of the set as we progress through the sequence; if the first element's access time is equal to the current time, we delete that pair from the set and re-insert it with its new next access time, reflecting the re-use of a chunk. Whenever we need to evict a chunk from the cache, we pick the one at the back of the set (i.e., the farthest next access).
So far, this implements Belady's optimal cache. Now, how do we skip the set inserts and achieve LRU-like behavior if there is no re-use of chunks? I think it might be possible to do so by having a "staging deque", where new pairs are sorted before insertion into the set. Specifically, if a new pair would insert at the end of a set, and it is greater than the existing pairs in the staging deque, then it gets put into the staging deque; if not, the optimization collapses and everything in the staging deque is inserted into the set. If there really is no immediate re-use, there's no need for set insertion, allowing for a fast deque insertion. The recycling of stuff off the front of the deque works in the same way as the set; you could even use a vector with a moving start to avoid using a deque at all, if one were concerned about deque-related overhead.

As it turns out, the existing algorithm in OracleSlabCache was already optimal. Huh. It seems that a direct implementation of Belady's algorithm is kind of tricky as it involves some kind of sort for the farthest access time. Our existing algorithm operates on the same principle but does this all implicitly.


feat(aws): consolidated cloudtrail + multitenancy

Closes https://github.com/lacework/terraform-provisioning/issues/32
Enable New Consolidated CloudTrail Configuration
This example enables a new Consolidated CloudTrail and IAM Role for Lacework,
then configures both integrations with Lacework, finally, it configures a new
CloudTrail in an AWS sub-account that points to the main CloudTrail.
provider "lacework" {
  alias = "main"
}

provider "aws" {
  alias = "main"
}

module "main_cloudtrail" {
  source    = "github.com/lacework/terraform-provisioning/aws/modules/cloudtrail"
  providers = {
    aws      = aws.main
    lacework = lacework.main
  }
  consolidated_trail = true
}

provider "aws" {
  alias = "sub_account"
}

resource "aws_cloudtrail" "lw_sub_account_cloudtrail" {
  provider              = aws.sub_account
  name                  = "lacework-sub-trail"
  is_multi_region_trail = true
  s3_bucket_name        = module.main_cloudtrail.bucket_name
  sns_topic_name        = module.main_cloudtrail.sns_arn
}

Signed-off-by: Salim Afiune Maya<EMAIL_ADDRESS>

I've got to use my administrator powers to merge this!

If there are any issues please let us know by creating new issues in this repository, I will make sure to fix them promptly.


POWER_BI_DEVELOPER

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fe7888c3-14b3-8120-7fa5-80af7d1febba
Version Independent ID: af40d3fb-5ed4-fa37-0e1d-afd01b1faf1e
Content: Power BI embedded analytics overview - Power BI
Content Source: powerbi-docs/developer/embedded/embedded-analytics-power-bi.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @mberdugo
Microsoft Alias: monaberdugo

Thanks for your comment, @shivendra1-cyber. This issue has been assigned to the doc author for review.

Hi @shivendra1-cyber, you didn't provide any feedback in the feedback section so I'm going to assume this was a mistake and close this item. If you have any feedback to offer, you can open a new one.


Fixed octal literal to work with node 4 strict mode

Pull request for issue #720

LGTM. Will take a look at this in an upcoming meeting.

This was cherry-picked into 1.1


Latest release is causing invalid _output.conf files to be created

Hi guys,
As the title says the latest cookbook version is creating invalid config files. If you look at the below:
[[outputs]] [outputs.influxdb] database = "telegraf" ......
The [[outputs]] line is invalid and is not present in the accompanying _inputs.conf:
[inputs.cpu] drop = ["cpu_time"] percpu = true totalcpu = true [inputs.mem] [inputs.net] [inputs.netstat] [inputs.processes] [inputs.procstat] .......
I'm not convinced it is the cookbook code as this has not changed in the last few days. Furthermore the usage is standard as per you README. We only pinned the minimum & not maximum version of your cookbook.
Whilst I haven't delved too much into the why it would seem it is something to do with the TOML gem you are now using.
Thanks :)

@Dan-Kitchen What version are you using?  If you are running off of master, its possible to have this issue until we merge up the open PRs.  If you're using 0.3.4, you might see this issue if you installed the toml-rb gem after they released 0.3.13 which was breaking.  If you are using 0.3.5 (which is the latest as of yesterday), I think you should be okay.

@fishnix Yeah that makes a lot of sense. We were using 0.3.4. A bunch of servers we spun up in the last day obviously pulled in this gem. It would appear though that using the new cookbook doesn't fix the issue if it's already happened. Until you remove the toml-rb 0.3.13 gem it will still generate invalid config files. It might be worth putting out a bit of info somewhere about that.
Thanks for the response!

Yeah that's true, we will install and upgrade that gem but not downgrade it.  Sorry for the trouble, unfortunately the upstream gem released a breaking change on a patch release and we weren't pinning the version. :hushed: With the next version (0.4.0), we will pin to 0.3.x and fix the output.  :+1:

Thankfully it only affected two of our nodes :)
No worries buddy, these things happen :+1:


Enable gRPC-web dev tools in dev mode for MLMD client

Supports RHOAIENG-7338 and RHOAIENG-7335, but opening this PR separately since it may be generally useful for ongoing dev on other stories as well
Description

In dev mode, enables support for the gRPC-Web Developer Tools browser extension (Chrome install link) (Firefox install link) when initializing the gRPC client for MLMD in PipelinesContext.
This dev tool allows us to view gRPC responses in deserialized JSON instead of base64 encoded binary format. This should make it easier to capture example data for mocks for Cypress tests.
The initialization code comes from the Usage section of the extension's GitHub readme.
How Has This Been Tested?

Tested that it has no effect when not running in dev mode.
Tested that it has no effect when the browser extension is not installed.
Tested that our client's requests are appearing in the extension's log when it is installed.

Test Impact

N/A
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/approve


qa_crowbarsetup: fix horizon test for ssl deployments

This uses the fact that json values 'true' and 'false'
are also valid shell commands
note: change is slightly tested manually

it may still be wrong for a different reason.
https://ci.suse.de/job/openstack-mkcloud/70110/console
showed a connection refused on port 80
but then, when we enable horizon to serve HTTPS, it should still serve a redirect page on port 80,
so something is broken in SOC6.


Also notifications

I read about https://github.com/mrded/nvim-lsp-notify https://github.com/rcarriga/nvim-notify
Sounds good use it

I'm not interested now in fancy notifications.


Add tab dinamicaly

Hello! Thank you for the library! I have a question about dynamic addition of tabs. In pseudo code it's looks like this:
handleAddProfileClick() {
    this.refs.tabs.add(
     <UserProfileTab userId="123" />
    );
},
handleAddSettingsClick() {
    this.refs.tabs.add(
     <Settings  />
    );
}

It is also important that other tabs are not redrawn (kept its state).
How about tab closing?
Thanks a lot!

I have an example of dynamically adding/removing tabs here https://github.com/mzabriskie/react-tabs/tree/master/examples/dyno

Thank you!

Thanks for this! However I would like to add tabs dynamically by passing certain Component inside like:
addTab("tab text", <MyComponent />);

Any way to achieve this?


ninja doesn't support -Thost

Trying to build nng:
    let dst = Config::new("nng")
        .generator("Ninja")
        .define("CMAKE_BUILD_TYPE", "Release")
        .define("NNG_TESTS", "OFF")
        .define("NNG_TOOLS", "OFF")
        .build();

Fails:
--- stdout
running: "cmake" "D:\\dev\\runng-sys\\nng" "-Thost=x64" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DNNG_TESTS=OFF" "-DNNG_TOOLS=OFF" "-DCMAKE_INSTALL_PREFIX=D:\\dev\\runng-sys\\target\\debug\\build\\runng-sys-bd05e88b08c12743\\out" "-DCMAKE_C_FLAGS= /nologo /MD" "-DCMAKE_C_COMPILER=C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.15.26726/bin/HostX64/x64/cl.exe" "-DCMAKE_CXX_FLAGS= /nologo /MD" "-DCMAKE_CXX_COMPILER=C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.15.26726/bin/HostX64/x64/cl.exe"
-- Configuring incomplete, errors occurred!
See also "D:/dev/runng-sys/target/debug/build/runng-sys-bd05e88b08c12743/out/build/CMakeFiles/CMakeOutput.log".

--- stderr
CMake Error at CMakeLists.txt:30 (project):
  Generator

    Ninja

  does not support toolset specification, but toolset

    host=x64

  was specified.

Cause is [PR #47] which added -Thost=x64.
Rust version:
D:\dev\runng-sys>rustup show
Default host: x86_64-pc-windows-msvc

stable-x86_64-pc-windows-msvc (default)
rustc 1.28.0 (9634041f0 2018-07-30)

PR #63 fixes at least this particular use-case.


Remove access control notification banner

Is your feature request related to a specific problem?
In a future release, we should remove the warning about access controls being migrated.
Describe the solution you'd like
It's possible the NotificationBanner may be useful in the future, so it may be good to keep around but remove the calls to it.
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Originally introduced by https://github.com/ethyca/fides/pull/2842

Oh darn, I missed this on the HomeLayout component. will fix shortly

moving to done


sanitycheck: Fix the logic for jobs

multiprocessing.cpu_count() already returns the number of threads (not cores), no need to multiply it by 2.

Codecov Report

Merging #9501 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9501   +/-   ##
=======================================
  Coverage   52.22%   52.22%
=======================================
  Files         212      212
  Lines       25948    25948
  Branches     5577     5577
=======================================
  Hits        13551    13551
  Misses      10140    10140
  Partials     2257     2257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d529aef...40254be. Read the comment docs.

this is now slower though, on a subset of 300 tests this is almost 100s slower.

OK, addressed this. Please take a look.


fetch repoID from kopia is not found in config

Some events in have a empty repoID. This could be because of multiple config files used. And new config files might have repoID missing.
Solution- Fetch repoID from Kopia is not found locally in the config file.
Note: Since the Corso Start event happens before we connect to Kopia, it might have repoID missing if the config file is used for the first time. All the consecutive events will have correct values. Corso start event will start populating correct values if the config file is used once.
Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[ ] :clock1: Yes, but in a later PR
[ ] :no_entry: No

Type of change

[ ] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Supportability/Tests
[ ] :computer: CI/Deployment
[ ] :broom: Tech Debt/Cleanup

Issue(s)

https://github.com/alcionai/corso/issues/3388

Test Plan

[ ] :muscle: Manual

My habit of merging manually :( Forgot to add the merge-queue flag


Feature Request: Set image location to local path within tweets

Would it be possible to re-set the photo path to a local path automatically rather than leaving it as the pic.twitter link?

on the archive you mean? it should do that by default!


Migrate README to AsciiDoc

AsciiDoc attributes allow for sharing the same library version declaration across all snippets.

Abandoning because GitHub renders AsciiDoc with strange list item spacing.


Date field not displaying correctly

 Before clicking
After clicking

Current behavior 😯
Date field label overlaps
Expected behavior 🤔
Date field and placeholder look elegantly together
Context 🔦
Input starting and ending bill date

Resolved
TextField {
    sx {
        width = 40.pct
    }
    label = ReactNode("Start Day")
    variant = FormControlVariant.outlined
    onClick = {
        val target = it.target as dom.html.HTMLInputElement
        target.type = InputType.date.toString()
    }
    onBlur = {
        val target = it.target as dom.html.HTMLInputElement
        target.type = InputType.text.toString()
    }
}

Hi @DmitriyMalayev, this is a bug of the MUI Material UI library.
Please create an issue here https://github.com/mui/material-ui/issues
P.S. Also you can use 'Date Pickers' instead

Documentation
Kotlin Wrappers
Kotlin MUI Showcase


support for array items?

Do you have any plans or have done any work towards supporting array items?
"aList": {
    "type": "array",
    "items": {
        "type": "string",
        "title": "image"
    }
}

Anything else is needed to be done on this? I can contribute time to this is needed.
Merci :)

Thank you @Nepoxx for your help :-)
The Add support of array input items commit already adds support of array items, but its not yet fully tested. You can help by providing integration test for this case.
Actually all developments are made on the develop branch, so you'll need to start your code from this branch.
I'm planing to release a big update for the end of February, so any helps are welcome

Hey demsking! glad to hear there is an upcoming update. What will be the supported array item types?

@icosamuel All types except radio, checkbox, textarea and select elements.
Please read develop/README.md for more info.


[FEATURE]-Add new interfaces for DM RMC Devices

In the process of refactoring the DM RMC classes, I determined that some of the properties that are on the main base class, DmRmcControllerBase, would work better as an interface that is implemented on each device controller class.
There should be 2 interfaces: IHasEdidFeedback and IHasOutputResolutionFeedback, with each implementing properties specific to that interface.
In addition to this, the bridging of these properties for use in SIMPL will now be handled by each specific RMC controller instead of the base class.

Moving this to the 2.0.0 milestone, as I'm not sure there's a way to accomplish this in a backwards compatible manner.

DM will be moving to its own EPI for 2.0


fix: O2

fix: can not find icon resources
fix: DEF publish

Codecov Report

Merging #683 (f7a9f5c) into release/0.14.1 (4979f28) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/0.14.1     #683   +/-   ##
===============================================
  Coverage           57.14%   57.14%
===============================================
  Files                   1        1
  Lines                  70       70
  Branches               15       15
===============================================
  Hits                   40       40
  Misses                 30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4979f28...f7a9f5c. Read the comment docs.


Compilation with Clang

Using clang 3.5.0 under a mac I get compiler errors.
cmake -DCMAKE_CXX_COMPILER=clang-omp++  -DCMAKE_C_COMPILER=clang-omp   ..
make

This issue is fixed with 596b800


Exporting via route?

Would it be possible to export the file by accessing a route? Something like what Laravel Excel does: https://docs.laravel-excel.com/3.1/exports/#_5-minute-quick-start
I would like to initiate the export with a button placed in the dashboard, rather than from a headeraction/bulkaction.
Thanks in advance

Not sure how this would work, as a lot of the logic is coupled to the Livewire components.

@Sanabria in 4 steps i think:

Create a model with migration lets say Reports with name,path and generated_by columns(you can name them as you want).
create a listener for ExportFinishedEvent, this event has two parameters $filename and userId

public function handle(ExportFinishedEvent $event)
   {
       Report::create([
           'name' => substr($event->filename, 37),
           'path' => $event->filename,
           'generated_by' => User::find($event->userId)->name
       ]);
   }

Add this route:

Route::get('download-report/{path}', function (string $path) {
    return response()->download(
        Storage::disk('filament-excel')
            ->path($path),
        substr($path, 37)
    );
})
->where('path', '.*')
->name('download-report');

Create a resource with only the index page. you don't need the rest.
you can download the report either via column:

Tables\Columns\TextColumn::make('name')
      ->url(fn ($record): string => route('download-report', ['path' => $record->path])),

or table action:
          Tables\Actions\Action::make('download')
                    ->icon('heroicon-o-download')
                    ->color('warning')
                    ->button()
                    ->url(fn ($record): string => route('download-report', ['path' => $record->path]))
                    ->openUrlInNewTab()

@pxlrbt you can close it now i think.

Thanks @bezhanSalleh


Create 0000-01-02-PurplePitch4rks.md

Create first pull request 0000-01-02-PurplePitch4rks.md

Complete Module 3 of Training


Swerve Implementation

Looks good. We might want to add an offset option for the steering motors as they have absolute encoders.

That's a good point, though it may fit better to put that in the motor controller classes?

I'm leaving town to visit uiuc today so my contribution might be a little spotty, but I'll see you monday

Have a good time!


Automatic 12 hour time should only work on today times

@raphaelahrens
Continuation of #27
12 hour time works complementary, in that when you specify 8:00 in the afternoon, it will supply 8pm, which is 20:00 in 24-hour time.
Raphael has made me aware that it is not always obvious what is going to happen when specifying dates like "tomorrow" or other calendar dates. He suggested that it be only calculated this way for today dates, and I concur.
This will take a little bit of work to get right.

Another suggestion: leave a config bit to always force 24h time (turn 12h automatic time off entirely)


OCIO_ACTIVE_VIEWS does not filter view list

The ACTIVE_DISPLAYS envvar is used to both filter, and prioritize, the list of allowed displays. The ACTIVE_VIEWS envvars is only used for prioritization. Make it do both.

This was fixed in PR #875.  In OCIO 2.x, the Config getViews method only returns active views.


[0.8.1] File New immediately followed by close asks to save

Accurate.

New calls Validate_Save() but this gets overruled when the modifications to the nodes then calls modified as a signal saying something changed there. This probably got messed with after we fixed another issue where changing a operation value wouldn't trigger the save required dialog.


[WIP] @craigspaeth => Boolean support and handle description

The first commit is simple: adds boolean support to list of allowed GraphQL values.
The rest is what we worked on earlier today...and strangely everything works as far as I'm testing it. 😱 So now, it's only checking that desc exists and removes the other if (desc.items) stuff. I would like to understand why and how it's working so I'll continue to do some research and report back with more deets!

Pretty cray:

Nice! Mind adding a test to here if it's really tricky, even a pending one will do.

👏  Wohoo! Nice work!


Overflow in tf.raw_ops.Fill

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf2.17.0 tf2.16.1
Custom code
Yes
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Overflow in tf.raw_ops.Fill when there are too large values in dims.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1GDBN4lheNUIW704hsXVt3lW55UJue97S?usp=sharing

Relevant log output
Kill

Hi @LongZE666 ,
I am trying to open the Colab gist you provided, but I don't have access to it. Could you please grant access to your Colab gist?
Thank you!

https://colab.research.google.com/drive/1GDBN4lheNUIW704hsXVt3lW55UJue97S?usp=sharing

I changed the permissions, can you try again? terribly sorry


Parser: allow trailing comma after named arguments in index notation

Fix #4782
For example, current compiler cannot compile this:
a = [1, 2, 3]
a[
  index: 1,
]
# Syntax error in foo.cr:4: expected named argument, not ]

Because the compiler does not allow trailing comma after named arguments in index notation. This fixes it so above is now working.

Crystal::Parser#parse_named_args misses checking :"]" token following :"," token (this means the case of trailing comma in index notation.). I fixed this correctly.

🏓

Using that emoji made it really difficult for me not to approve this PR :D

Sorry. 🏓  means ping pong (table tennis), so I intended just "ping".


Add additional keys to the binary_flag dictionary in the util.data_format file

First of all, this is an excellent library and you guys did a great job!
I am pulling some options data from Polygon.IO and then options are labeled as 'CALL' and 'PUT', for this library
they need to be 'c' or 'p', which would require either creating a new DataFrame column or renaming the current column.
which really doesn't add much more time on our side, but can easily be handled in the library. there is a dictionary
"binary_flag" in the util.data_format file that converts the 'c' or 'p' to 1 and -1, I'm proposing adding additional keys to
cover more use cases than just 'c' and 'p'. My current workaround is to simply modify the dictionary after I import the library
as seen below.
import py_vollib_vectorized
Add some key_value pairs to the binary flag dictionary
py_vollib_vectorized.util.data_format.binary_flag['CALL'] = 1
py_vollib_vectorized.util.data_format.binary_flag['PUT'] = -1

Hi Timothy,
Can you do a simple PR for this? seems pretty straightforward, just make sure to add a test as well!