[PE-D][Tester B] Absence of deletesubject command

Since there is an addsubject command, I think there should be a deletesubject command, because users may input a wrong subject accidentally due to various reasons, and then there is no way to delete that subject, not even in Edit. Thus users will have to delete that student altogether along with other information and retype it all over again.

Labels: type.FeatureFlaw severity.High
original: kaikquah/ped#22

We can argue that this is actually possible to do with edit? Slightly confused why the tester believes that edit can't remove the subject. But I can add deletesubject as planned enhancement in DG


Customers can't enter their VAT ID

There's simply no field for this, neither on the personal information page, nor when going through checkout, nor on the addresses field.
There is such a field in back office -> Customers -> Addresses -> (edit a customer). This back office field works.

That's a matter of the theme in use.
There was an attempt to enhance this: https://github.com/thirtybees/community-theme-default/commit/ca55a29e435ecb1145874d4489e8a81d79625c74
This change (understandably) wasn't appreciated by the community, so it got reverted.

The secret is, one has to enter a company name and whooops, the VAT number field suddenly appears (earlier) or slides out (now in the default theme).


Update Azure Mappings to ATT&CK v9

As a user, I want the Azure Mappings update to ATT&CK v9, so that I can map security controls to the latest version of ATT&CK.
Acceptance Criteria:

ATT&CK v9 Mappings are added to this repository

this should be closed in lieu of a request to update to ATT&CK v11


refactor: runtime api spec gen scripts

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

refactor: runtime api spec gen scripts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 252 (0.0%)  changed or added relevant lines in 1 file are covered.
10 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 71.401%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/runtime/scripts/gen-api-spec.rs
0
252
0.0%

Files with Coverage Reduction
New Missed Lines
%

kclvm/sema/src/core/scope.rs
3
66.84%

kclvm/sema/src/core/symbol.rs
3
49.48%

kclvm/config/src/settings.rs
4
78.26%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
56565

Relevant Lines:
79222

💛  - Coveralls


Implement POST /v2/chain/:chainId/delegates

Depends on #1501
Summary
This PR adds the endpoint:
POST /v2/chains/:chainId/delegates

This endpoint expects the same payload and returns the same data structure as the v1 one, but calls the v2 version of the delegates endpoint of the Safe Transaction Service. A v2 version of the delegates endpoints is needed due to incompatibilities between the signatures.
Changes

Adds POST /v2/chains/:chainId/delegates endpoint.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

58 of 59 (98.31%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 92.175%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/datasources/transaction-api/transaction-api.service.ts
8
9
88.89%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
1
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
6959

Relevant Lines:
7276

💛  - Coveralls


pull-deps fails when not using --clean flag

--clean Will remove the extensions directory
If you call pull-deps without the flag, it should attempt to use the existing extensions directory without removing any existing extensions. However, in this case an exception is thrown:
Exception in thread "main" com.metamx.common.ISE: Unable to create extensions directory at [/usr/local/druid-0.9.0/extensions]
	at io.druid.cli.PullDependencies.createRootExtensionsDirectory(PullDependencies.java:453)
	at io.druid.cli.PullDependencies.run(PullDependencies.java:223)
	at io.druid.cli.Main.main(Main.java:105)

The problem is that the code will always attempt to create the extensions directory:
https://github.com/druid-io/druid/blob/master/services/src/main/java/io/druid/cli/PullDependencies.java#L223
    createRootExtensionsDirectory(extensionsDir);
    createRootExtensionsDirectory(hadoopDependenciesDir);

And createRootExtensoinsDirectory() will throw an exception if the directory already exists. This is because mkdirs() returns false if the directory already exists.
https://github.com/druid-io/druid/blob/master/services/src/main/java/io/druid/cli/PullDependencies.java#L451
    if (!atLocation.mkdirs()) {
      throw new ISE(
          String.format(
              "Unable to create extensions directory at [%s]",
              atLocation.getAbsolutePath()
          )
      );
    }

The workaround is documented here FWIW: http://imply.io/docs/latest/extensions

Thanks for reporting the issue @brwebb . It's unnecessary to crash the program if there is no conflicting extensions.

@fjy can that example be added to the official druid docs?

@fjy @drcrallen I met this problem too, is it a feature ?!

@drcrallen yes we haven't ported it yet. We actually need to rewrite all the extension installation docs for Druid

@zzl0 no, it is a limitation of the existing pull-deps tool. Overcoming this limitation for smarter pull-deps would be a feature.

@drcrallen thanks for your explanation


About the performance compare between other graph optimization framework.

Hi, is there any comparison of performance between this library and others( such as ceres solver, g2o, gtsam)?
And, since the jaxfg is based on Jax, can the jaxfg use cuda to significantly speed up optimization speed.?

Sorry for the delay in getting back here!
My general experience is that jaxfg will usually be slower than optimizers written in C++, particularly if you factor in JIT compilation overhead. You should see CUDA speedups if you're using the conjugate gradient solver, particularly when you want to solve many MAP inference problems in parallel, but in practice CPU-based Cholesky factorizations (eg CHOLMOD) will be noticeably faster than iterative CG solvers for smaller/non-parallel applications.

I test the performance in my data.
To solve a problem with 760x3 parameters [about 760x3x3 dim  ] and [760 x 4] factors uses jaxfg.
Each iterate costs 0.1 Seconds, but the process of jitting the graph costs 67 seconds.
So, this library may not be suitable for solving large-scale problems since the jit time is too long.
If the result is abnormal, please contact me.

Hi, this code cannot be provided now. But I found the may reason that the jit time is too long.
The main reason is that each factor contains a process like the pre-integration technique during calculating residuals.


Fix typo in languageConfigurationRegistry.ts

embeded -> embedded

https://github.com/microsoft/vscode/wiki/How-to-Contribute#spell-check-errors
PRs like this are not a good use of team resources IMO.

@eltociear as @gjsjohnmurray states and links, we don't typically take PRs like this.


[Configurations]Live Reload Shops

From Discord:

I added new item into the merchant store, so do i need to restart the server or client to take effect ?... by AdminPanel

We need to improve AdminPanel to support reloading configurations.
For example, when we change the items in the shop, we want to "hot" reload configurations for current game servers to instantly apply changes in the game without hard restart servers.

That should work now :)


Generator: Update SDK /services/sqlserverflex

Generated from GitHub run<PHONE_NUMBER>6

These changes are already merged https://github.com/stackitcloud/stackit-sdk-go/pull/636/files


⚠ Bofrost.de has degraded performance

In 11a6839, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1393 ms

Resolved: Bofrost.de performance has improved in 9bade8e after 6 minutes.


fix(page-button): the segement not work when the text is too short

by https://github.com/mefengl/chat-play/commit/3580069e34138f3157ad02c6ab95eb7baacf9c81


Module idea list

[x] sub message announcing
[x] commands

[x] hardcoded
[x] global
[x] channel group ? Not sure how useful ...

Alternative: multiple global emote "groups" and enable / disable per channel / connection

[x] per channel
[x] per connection

[x] triggers (regex based commands)
[ ] Per user commands
[ ] point system

[ ] Raffle
[ ] roulette
[ ] give points?
[ ] mod+ add / set points
[ ] web api / interface

[ ] (long time) raffle system
[ ] nuke

[ ] fetch
[ ] timeout
[ ] ban

[ ] moderation stuff
[x] logging to discord via web hooks
[ ] Emote combo stuff
[x] Daily danker
[x] Firehose mention system
[ ] Webinterface for commands and connections

Things that are not really modules but more features in modules:

[ ] A select random thing .... something like ${rand:xxx|yyy|zzz} and it would pick one

Channel point triggered commands

#11


Fix for audit issue "Withdrawal that reached the timeout can be reset"

Closes: #60
This pull requests addresses an issue reported during the audit: Withdrawal that reached the timeout can be reset.
Eve can initiateWithdrawal one more time but only during the withdrawal delay. This action will reset the withdrawal clock. Each initiateWithdrawal call increases the amount Eve will eventually withdraw from the pool, i.e. initiated withdrawals sum up.
This way, Eve can decide to reduce her position in the pool even more without having to wait for the remaining time of the withdrawal delay to complete the pending withdrawal and then, waiting for the entire withdrawal delay again. At the same time, we do not leave room for manipulation and we keep the mechanism simple.

@tomaszslabon I let myself modify the PR description so that it reflects the recent code changes in this PR.


What's new on 10.1.1148.0?

Why not keep this information as part of the Store listing under "What's new in this version"? There's nothing like having to type in the URL because it's not clickable in the Store app then find out this page is out of date.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 67b7b5a4-647e-fee3-6533-6ed88ae45bfa
Version Independent ID: d9102859-0147-346f-8268-6e2a75c8b0b7
Content: What's new in the Windows Store client
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/windows-whatsnew.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: helohr

10.1.1149.0 is out! Yay! What's new? 🤷🏽♂

10.1.1150.0 is out! The plot thickens!

Yeah, this page is not updated very frequently...

Seriously, there are some major bugs with this app on my SurfaceProX, it would be great to see some feedback on if this is being addresses in recent releases. This app is my favorite RD client because of proper screen scaling and usability improvements over the old mstsc client. However it is less reliable on all my devices. But on the SurfaceProX, it is more likely to freeze, cause the screen to flicker and flat our crash.

@eross-msft @davidbel @v-thepet We'd like to know what's new. Anyway to see change log right in the Microsoft Store entry?

Thanks for updating the page. I still wish you'd make use of the "What's new in this version" field in the Store.

Hi @myokeeh, thanks for the feedback. We generally update the What's new text in the Store with the content of the latest release. Since the Store allows only a certain amount of text in the What's new, we also keep a public page with information about the content of the previous releases for reference.

@davidbel I believe you have 1000 characters for that field, if I'm not mistaken. Surely, change log for the last three should fit there:
Store entry:

Text from page:

Thanks for the feedback. Seeing as this issue is raised for the Docs article which is up to date, I will close this.
#please-close


Lutron failure in 0.84.1

Home Assistant release with the issue: 0.84.1

Last working Home Assistant release (if known): 0.83.3
Operating environment (Hass.io/Docker/Windows/etc.): RPi3, Hass.io

Component/platform: https://www.home-assistant.io/components/lutron/

Description of problem:
Error while setting up platform lutron
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/lutron.py", line 23, in setup_platform
    dev = LutronLight(area_name, device, hass.data[LUTRON_CONTROLLER])
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/lutron.py", line 45, in __init__
    super().__init__(self, area_name, lutron_device, controller)
TypeError: __init__() takes 4 positional arguments but 5 were given

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
lutron:
  host: <IP_ADDRESS>
  username: lutron
  password: integration

Traceback (if applicable):

Additional information:
Lutron RA2 has a static assigned IP.

Please fill out the template.

Please fill out the template.

Was in process, thanks.

super().init(self, area_name, lutron_device, controller)
needs to change to
super(LutronLight, self).init(area_name, lutron_device, controller)

Blame #18650

I'm new to this process. Is there anything else I need to do to make sure this gets seen?

Was already seen.
~phnx

any workaround for this currently? All ~90 of my lutron lights are down :( maybe downgrade hass?

After applying this fix, the issue remains on my system as can be seen below:
Fri Dec 14 2018 03:02:34 GMT-0500 (Eastern Standard Time)

Error while setting up platform lutron
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/light/lutron.py", line 23, in setup_platform
    dev = LutronLight(area_name, device, hass.data[LUTRON_CONTROLLER])
  File "/config/custom_components/light/lutron.py", line 46, in __init__
    self, area_name, lutron_device, controller)
TypeError: __init__() takes 4 positional arguments but 5 were given

The stacktrace still looks like the old code.

had a mistake in the commit that was sent, use the latest file from the pr:
#19279

The latest file works.
Thanks for the fix


I wish /docs/api-reference/ pointed to the latest version of the API

I wish /docs/api-reference/ pointed to the latest version of the API, or at least didn't yield a 404.

The right link should be: http://kubernetes.io/docs/reference/
or: http://kubernetes.io/docs/api-reference/v1/definitions/
Unfortunately, the "I wish" feature doesn't include the origin URL :(


fix(elements|ino-datepicker): select default date according to prop

Closes #340
Proposed Changes

Fix not working ino-default-date property (forward missing prop to factory)
Ignore default props if a value is provided
Set flatpickr date after initialization to show the correct date in overlay

There currently is another bug within the datepicker that shows the disabled datepicker as invalid (see below).

I'll see if it's fixed easily or if a separate PR is necessary.

There currently is another bug within the datepicker that shows the disabled datepicker as invalid (see below).

I'll see if it's fixed easily or if a separate PR is necessary.

Done ✅
It's ready to review now


Consider updating travis.yml to deploy to Bluemix

There is a Bluemix Deployer that could be used to streamline the development flow w/ deploy to Bluemix.  Might be worth considering.  Bluemix CloudFoundry Deployer

Hi Todd, thanks for the suggestion.
We are currently using the Bluemix CLI along with a script to provide blue-green deployments.


v 3+ Hook up the 'Plant.id' API calls....

toDO: since the 12/6/22 revert in /develop/  (#346)  we need to redo a few things. On the frontend that is:
#331
#339
#350
These updates were all reverted when Mony confirmed that the Feature/tree validation wouldn't build.
This ticket is for commiting the background API calls (and their joins with the species.json).
There should be the following calls available (NOTE: don't forget to email the envVariables.ts which should contain the final paid for API key).

code enabling the camera taking pictures & getting an API response (if the TreeBot toggle is 'on'
code SAVING to firebase the list of species responses (and their percentages) to a single firebase field (called 'AI_results' - need this for cross-validation and device testing with Plant.id).
code for the different outcomes when user is interacting with the AI which are:

[ ] Outcome 1: Prompt user to enter the GENUS (when the Plant.id AI found a species that is not in our json file - we will try to match to the genus level).
[ ] Outcome 2: Prompt user to enter the Species name (when the AI and json file have a species match).
[ ] Outcome 3: Prompt user to enter Unknown (this is when there is no match at all - genus or species).
[ ] Outcome 4: Prompt user to take another picture (this is when the Plant.id says it is NOT 'a plant').

@jingsizou and @skymrsn - with PR #354 (thanks @mtalhadev !) we now have the TreeBot toggle, clear button, and TreeBot info modal front end complete. Can you help us hook up the backend API commands?

adding @mtalhadev for awareness...


thanks for the repo 🙌, issue running sshfs

hey thanks for taking the time to make this repo.
i just tapped and installed sshfs
and running the below cmd gives me this error message.
sshfs                                                                                0 (1.570s)
dyld: Library not loaded: /usr/local/lib/libfuse.2.dylib
  Referenced from: /usr/local/bin/sshfs
  Reason: Incompatible library version: sshfs requires version 12.0.0 or later, but libfuse.2.dylib provides version 10.0.0
fish: Job 1, 'sshfs' terminated by signal SIGABRT (Abort)

when i ran
brew install gromgit/fuse/sshfs-mac

i don't think it installed macfuse or the libfuse linux only 🧐

running
 brew install macfuse

resolved my issue.


Add aesthetic interface

Use nice looking UI elements

CSS from https://micah5.github.io/PSone.css/


Enabled hidden files

This PR is to fix hidden files. Hiding files starting with a dot was implemented sometime in the begining of development but didn't work. This will be also useful in locks.

Or, since in that mockup the frontend knows how many are hidden, I guess this should be functionality for the frontend, making this PR unecessary.


init() got an unexpected keyword argument 'lm_corpus_path'

Hi, I try to run the recipes/Librispeech, but got this error, what should I do to solve this problem? please help me, thank you

I'm not familiar with how that recipe is supposed to work but it seems something is broken here, other issues #1300 (also yours), and #1285, #954.
I think PR #1223 was meant to fix this, although I am not sure if that has made it into main (pip installed version) yet. Hopefully the discussion in the PR can help.

Should we and can we do a hotfix on the main for that particular PR ? @Gastron

Actually, now that I think about it, it's a recipe, so pip installed version does not matter here, and there's no hotfix to make.

Hi, I can confirm that it works with the latest develop branch (a9b373a9) using datasets==1.9.0.
It seems to break for datasets versions >1.9.0.

Hi, Mr Domik Wagner.
Thank you for replying about it. I wonder how to set the datasets version
to 1.9.0.version?
Regards,
Fadlan
Pada tanggal Min, 3 Apr 2022 pukul 18.03 Dominik Wagner <
@.***> menulis:

Hi, I can confirm that it works with the latest develop branch (a9b373a9)
using datasets==1.9.0.
It seems to break for datasets versions >1.9.0.
—
Reply to this email directly, view it on GitHub
https://github.com/speechbrain/speechbrain/issues/1302#issuecomment-1086837911,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSHHENTMN6235LB4V523BDVDF3GJANCNFSM5OKD4P7A
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
*Salam, *
Muhammad Fadlan Hidayat

Dear Mr. Domik Wagner,
I just figured out the dataset version you mean in previous email is for
the hugging face dataset right? when I want to install hugging face dataset
using Pip I need to mention the version right? Thank you
Regards,
Fadlan
Pada tanggal Sen, 4 Apr 2022 pukul 10.47 M Fadlan Hidayat <
@.***> menulis:

Hi, Mr Domik Wagner.
Thank you for replying about it. I wonder how to set the datasets version
to 1.9.0.version?
Regards,
Fadlan
Pada tanggal Min, 3 Apr 2022 pukul 18.03 Dominik Wagner <
@.***> menulis:

Hi, I can confirm that it works with the latest develop branch (a9b373a9)
using datasets==1.9.0.
It seems to break for datasets versions >1.9.0.
—
Reply to this email directly, view it on GitHub
https://github.com/speechbrain/speechbrain/issues/1302#issuecomment-1086837911,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSHHENTMN6235LB4V523BDVDF3GJANCNFSM5OKD4P7A
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
*Salam, *
Muhammad Fadlan Hidayat

--
*Salam, *
Muhammad Fadlan Hidayat

Hi,
I can confirm that it works with the latest develop branch (a9b373a9).
The unexpected keyword argument 'lm_corpus_path'  error disappears for datasets<=1.9.0.
However, for versions above 1.6.2, you are likely to run into the DuplicatedKeysError mentioned here #1223.
So you might have to do pip install datasets==1.6.2.

 We have to revise this ...


Add support for physical qubits

Example
The most basic example is
from qiskit_qasm3_import import parse

program = """
OPENQASM 3.0;

reset $2;
"""

circuit = parse(program)
circuit.draw()
print(circuit._layout)

which prints
0 ─|0>─

TranspileLayout(initial_layout=Layout({
2: Qubit(QuantumRegister(1, 'qr'), 0)
}), input_qubit_mapping={Qubit(QuantumRegister(1, 'qr'), 0): 2})

Tasks

[x] Refactor non-DRY parts
[x] Tests
[x] Raise some errors, for example when mixing types of qubits
[x] Doc strings [No need for doc strings]
[x] Release note

Additional Tasks

[x] Rewrite AddressingMode
[x] Split some tests into separate functions
[x] Test (and implement) rejecting references to hardware qubits in function body.
[x] Test hardware qubits in nested scopes.
[x]  [GJL] Test that layout is correctly generated for hardware qubits.
[x]   [GJL] Test hardware qubit first seen in local scope broken.
[x] Remove commented out cruft in OQ code.
[x] Second arg to resolve_condition should not be optional
[x] Second arg to resolve_condition should be of one type (State)
[x] Create and use a type for hardware qubits, eg type.HardwareQubit.
[x] In ValueResolver.visit no need to handle missing context explicitly.
[x] Check entry point resolve probably shouldn't accept None as an input to context here, since it's now required.
[x] Either pass all state data in resolve or store in class, but don't mix. See https://github.com/Qiskit/qiskit-qasm3-import/pull/2#discussion_r1088943129
[x] In ConvertVisitor.convert fix inefficiency in iterating through keys.
[x] Make protected-access lint exception more locally scoped.
[x]  Disable too many lines lint check globally
[x]  AddressingMode: use enum for the mode number. Or switch to using just an enum
[x] Add HardwareQubit to the docs/index.rst
[x] Remove dead code, old comments, etc.
[ ] test that the AddressingMode is being set correctly and propagated all the way up to the global scope
[x] add a test that we can use hardware addressing in the main program, but still have user-defined gates
[x] fairly sure Qiskit says that backends are required to label their hardware qubits starting from 0 with no gaps
[ ] add an option to the top-level convert function to allow the user to specify the total size of the backend
[x] Python Enum instances can (should) be compared by is checks
[x] the triple-nested if/else now, can we refactor this a little to do early return
[x] Rewrite SymbolTable with stack-like structure.
[x] test that hardware qubits can be used outside the local scope they're first seen in
[x] test that "hardware mode" being set in a local scope and then referencing virtual qubit after that scope is exited causes an error to be raised.
[x] Remove test involving identifer $q.
[x] Remove hardware_qubits method. use a different design.

Notes
EDIT: Regarding _layout and TranspileLayout below: PR https://github.com/Qiskit/qiskit-terra/pull/9486 now provides an interface and some documentation.
QuantumCircuit has an undocumented (including in comments) property _layout. It is initialized to None. It seems that sometimes it is set to a Layout and sometimes a TranspileLayout. I find that printing/drawing the circuit fails if _layout is a Layout, because the output methods reference _layout.initial_layout, which does not exist.  So I use TranspileLayout, which does have _layout.initial_layout.
The hardware qubits are referred to by numbers. These are mapped Qubits in a  QuantumRegister , "qr", in the order that they were seen in the OQ3 code; the first is mapped to qr[0] , and so on.
The references to hardware qubits are collected in ValueResolver.visit_Identifier. The layout is then created and attached to the circuit as the last step in the method ConvertVisitor.convert.
Here is the code that adds the layout
            names = filter(is_physical, symbols.keys())
            intlist = physical_qubit_identifiers_to_ints(names)
            qr = QuantumRegister(len(intlist), "qr")
            initial_layout = Layout.from_intlist(intlist, qr)
            input_qubit_mapping = dict(zip(qr, intlist))
            layout = TranspileLayout(initial_layout, input_qubit_mapping)
            state.circuit._layout = layout

Previously, the method ValueResolver.resolve takes only the node to be resolved and a symbol table. I added as a third argument the context (an instance of State) because it contains the circuit, and each physical qubit must be added to the circuit as are the virtual qubits in ConvertVisitor.visit_QubitDeclaration.
Closes #1
Closes the proxy issue https://github.com/Qiskit/qiskit-terra/issues/9435

pylint -sn -rn src tests is failing in CI. This command failed to run locally under Python 3.11 because I had wrapt v 1.12 installed in my virtual env. After upgrading to wrapt v 1.14, the command runs correctly.
Perhaps this requirement should be added somewhere. Presumably not in this repo, because wrapt is an indirect dependency. If this has actually been fixed by a version requirement in the direct dependency that is using wrapt, we could make a requirement here. I have not tracked this down.

It's transitive and already fixed - not our responsibility, and we'd just be polluting our repo if we did it.

I provided a tox configuration, so you can run tox -e py311 to run the tests under Python 3.11, or tox -e lint to run the lint tests in an environment isolated from your current one, which should alleviate a lot of out-of-date environment issues.

Running tox -e lint gives me the following
************* Module qiskit_qasm3_import.types
src/qiskit_qasm3_import/types.py:5:11: E1101: Module 'abc' has no 'ABC' member (no-member)
src/qiskit_qasm3_import/types.py:16:5: E1101: Module 'abc' has no 'abstractmethod' member (no-member)
src/qiskit_qasm3_import/types.py:58:4: W0231: __init__ method from base class 'Type' is not called (super-init-not-called)

Looking in .tox/lint/bin shows that this is using 3.11

That's pretty weird - looks like a bug in the pylint 2.14 series, because abc.abstractmethod and abc.ABC are defined as normal Python objects in the standard library.  There isn't even any weird C-extension re-exports for those.  I'll bump the pylint version to 2.15.x, since that has no errors with Python 3.11.
Fwiw, all the non-generated tox targets use the "system" python binary.  It's not super ideal, but if you have a Python 3.10 environment that also has tox installed, you can do /path/to/python3.10 -m tox [tox options] (or /<py310 venv>/bin/tox [tox options]) to get it to do what you want here.

@jakelishman , @kdk  This is nearly finished. You may want to take a look at this before I clean up rough edges it to see if we need structural changes to the implementation. In any case, I'll start polishing a bit.
In particular, the section "Notes" in the opening comment above describes the implementation.

Because there were several items requested in the review, I added another checklist in the opening comment. All items except adding some more tests have been addressed.
Handling of the addressing mode is encapsulated in a class. This is slightly more complex structure-wise than using just an Enum, but not by much. It has the advantage that mutable details of the state of addressing mode are not spread across classes in two files. In general, it seems Qiskit prefers spreading mutation of state throughout the code. I suppose it is simpler in a sense and often is not problematic.  In the present case in particular, reading and writing the Enum instead of using the present class is not really too complex; this code is not very big. I'm ok with using the Enum instead.
There are probably a few commented out print statements left to remove.

Hardware qubits seen for the first time in local scope do not appear in the global symbol table. Local symbols are, correctly, discarded. I think this and other clumsy manipulations might be ameliorated by storing hardware qubits in a separate structure.

But that's because you're adding them to the local scope and not the global scope.  They should be added to the global scope. That's not a clumsy manipulation, it's just following the rules of the language.  Having multiple symbol tables is clumsy, and going to be a massive source of edge-case bugs if every lookup has to look in more than one place.

I'm experimenting with implementing a class SymbolTable rather than using a simple dict. This does
fix the one test for broken behavior. (i.e. the test for broken behavior now fails because the tested behavior is correct)
However, other new bugs still exist.

@jakelishman what does "per-run state" mean here?
https://github.com/Qiskit/qiskit-qasm3-import/blob/246e999573c0d7a2162b779d9525b8b5b79c3cf0/src/qiskit_qasm3_import/expression.py#L56
I am updating doc strings. The doc string in question says that the instance state of ValueResolver is only symbols, which is no longer true.

Oh, and to answer that question: I think I meant that ValueResolver doesn't have any mutable state that it generated/tracked as it traversed the expression tree, it just had a static lookup.  That text isn't clear though, and I don't entirely remember what I was thinking.

@jakelishman I think that moving logic for visibility into the SymbolTable  (given that SymbolTable has a nice stack-like design for handling scopes) is the right thing for several reasons.  But in raising exceptions we want to include information on the node; in particular the location in the source file. I want to just pass this information, for example the call would be symbol_table.get(symbol_name, node). This doesn't feel right because node and source information make the interface less clean. They are only for diagnostics.  The same issue arose with AddressingMode and I chose the same solution; passing node.
Regarding the symbol table. We could do one of the following

Not pass node so that we lose the information for diagnostics. This results in a cleaner, less complex interface.
Pass node wherever it is needed for diagnostics. This means, even though symbol_table has a nice map-like interface to hide complexity, a simple lookup requires passing extraneous information (that will never be  used for a correct input program)
Note the the context and node are almost always passed together. On recursive calls a different node is passed and the same context (possibly modified) is passed. Passing a light-weight structure, perhaps a named tuple, with these two pieces of information would hide some complexity. The arguments for this decreasing bugs are the standard ones, which I have already run into here: argument order, typos, etc.  You have more complexity in one sense, but surface area for bugs is decreased. Same argument for why I like AddressingMode to be as struct.

At present, I think choosing 2. above is best. Get the kinks worked out, and then evaluate whether progressing to 3. is a good idea.

Yeah, I agree - it's not a perfect situation, but I don't think your number 2 is too tricky an interface, and still lets us emit diagnostics (at least the very limited set that we do).

Yes, number two is the easiest way forward and doesnt sacrifice the user facing behavior that we want.

@jakelishman I pushed more changes last night. Mainly this is using the new implementation of SymbolTable. Identifying errors in the test suite by checking strings was getting a bit complex. In the case of hardware qubits in a gate definiton, the error is raised in two places and would require keeping the strings in sync. I instead raise an error HardwareQubitInGateError.
I have yet to change the mapping of virtual to physical qubits. What I have now is in any case incorrect, because it ignores Qubit objects in the circuit and creates a new register. Further processing to take this to a backend would fail.

I think we don't in fact need to worry about the number of hardware qubits ...

https://github.com/Qiskit/qiskit-terra/issues/9609
We do need to do something to better support the problem in the issue above.

There's the question of "number of qubits in the backend", but let's do that in a follow-up.

A good idea. This PR discussion is already complicated.

@jakelishman I redesigned the symbol table. It is a stack rather than a recursive structure. I think this is much more in line with what you were thinking about above. Furthermore the stack is managed by context managers.


[EBPF] Fix minimum values reported in complexity PR comment

What does this PR do?
Fix a bug where decreases in complexity would not be reported correctly, as the minimum value was set to zero.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Create application to save Google keep note to CSV file and vice versa

Description
Create a command-line application/ script to save google keep notes to CSV file and vice versa.
Type of issue

[x] Feature (New Script)

Checklist:

[x] I have read the project guidelines.
[x] I have checked all the existing projects, before submitting a new project issue.
[x] I have checked previous issues to avoid duplicates.
[x] This issue will be meaningful for the project.

Hi there. By application, do you mean a command line application?

Hi there. By application, do you mean a command line application?

Yes

Ok sweet, is there any particular rational for using csv? Should the application be more of a note taking application linked to Google Keep or more of an batch import/export tool for Google Keep? Just trying to understand the scope. I'd love to contribute for Hacktoberfest 2020.

Ok sweet, is there any particular rational for using csv? Should the application be more of a note taking application linked to Google Keep or more of an batch import/export tool for Google Keep? Just trying to understand the scope. I'd love to contribute for Hacktoberfest 2020.

An import/export tool for google keep
Thanks for showing interest in our repository, we will be happy to receive a contribution from you.

Ok, that sounds actually useful! It may take a couple days because I'll probably have to do OAuth2 authentication, but I'll take this one on!

Ok, that sounds actually useful! It may take a couple days because I'll probably have to do OAuth2 authentication, but I'll take this one on!

Cool, you can take your time, I am assigning this issue to you, Good luck!

This issue is marked stale. Can I work on this if @grplyler agrees?

This issue is marked stale. Can I work on this if @grplyler agrees?

We'll wait for a day or two and will assign it to you if the concerned person doesn't responds


JreTypeSolver encounters NullPointerException when added to bootstrap classpath

On line 27 of JreTypeSolver, when you run
Class<?> clazz = JreTypeSolver.class.getClassLoader().loadClass(name);

and you import the code through the bootstrap classpath (i.e. -Xbootclasspath/a:path), getClassLoader() will return null as per https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#getClassLoader--.

Thanks for reporting this!


CSS comment caused an error

Hello, I probably found an issue.
I have in my components one component: print-names and in this component I have a style.css file
where is just:   div {color: red; } , that works fine. But I was trying to add a comment bellow something like:
div {color: red; }
/* My_comment /
and it caused an error in ember application: "Cannot read property 'map' of undefined".
When i put my comment like this:
div {
color: red;
/ My_comment */
}
it works fine.
Thank-you for your time.
Fetview development.

Both are like this:  /* My_comment */

This should be fixed on the master branch and will probably be included in the next version.
You can test this now by running:
$ ember install https://github.com/ebryn/ember-component-css.git


Eslint Error

For this code in vuex module
  mutations: {
    setBooks: (state, books) => {
      state.all = books;
    },
  },

It shows red in state.all and shows this error message.
Module Warning (from ./node_modules/eslint-loader/index.js):
error: Assignment to property of function parameter 'state' (no-param-reassign) at src/store.js:13:7:
  11 |   mutations: {
  12 |     setBooks: (state, books) => {
> 13 |       state.all = books;
     |       ^
  14 |     },
  15 |   },
  16 |   actions: {

Style is airbnb. I know i can hide it but there are show many such messages :(

please check you .eslintrc file, do it has below config:
    // disallow reassignment of function parameters
    // disallow parameter object manipulation except for specific exclusions
    'no-param-reassign': ['error', {
      props: true,
      ignorePropertyModificationsFor: [
        'state', // for vuex state
        'acc', // for reduce accumulators
        'e' // for e.returnvalue
      ]
    }],

i havd done clean install. there should be some issue with airbnb standard
On Sat, Sep 29, 2018, 9:13 PM Nfer Zhuang<EMAIL_ADDRESS>wrote:

please check you .eslintrc file, do it has below config:
// disallow reassignment of function parameters
// disallow parameter object manipulation except for specific exclusions
'no-param-reassign': ['error', {
  props: true,
  ignorePropertyModificationsFor: [
    'state', // for vuex state
    'acc', // for reduce accumulators
    'e' // for e.returnvalue
  ]
}],

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs-templates/webpack/issues/1449#issuecomment-425653425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuOYeive5EXXQuNaJOpcIg0aUCBZ_-4ks5uf5GJgaJpZM4W8tBJ
.

and there is no such config and ususally i dont like hacks because in
future it may be hard to maintain. Is there no effective solution
On Sun, Sep 30, 2018, 1:50 AM shirshak bajgain<EMAIL_ADDRESS>wrote:

i havd done clean install. there should be some issue with airbnb standard
On Sat, Sep 29, 2018, 9:13 PM Nfer Zhuang<EMAIL_ADDRESS>wrote:

please check you .eslintrc file, do it has below config:
// disallow reassignment of function parameters
// disallow parameter object manipulation except for specific exclusions
'no-param-reassign': ['error', {
  props: true,
  ignorePropertyModificationsFor: [
    'state', // for vuex state
    'acc', // for reduce accumulators
    'e' // for e.returnvalue
  ]
}],

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs-templates/webpack/issues/1449#issuecomment-425653425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuOYeive5EXXQuNaJOpcIg0aUCBZ_-4ks5uf5GJgaJpZM4W8tBJ
.


Create HUD to display game info on cube screen

Create a HUD on the cube screen to display overall game elements such as the timer, games completed etc.
done: when able to display game info on the canvas.

put timer on the HUD, can add other stuff later whatever is needed


Api server docker container runs on console?

Hi,
when I run the API server docker image, the server is executed in my console and not in background.
$ sudo docker run -p 3002:3000 xemle/home-gallery-api-server

Loading tensorflow and models
Load tensorflow width wasm backend in 253ms
Loading model from /app/models/mobilenet-1-100/model.json
Loaded mobilenet model in 1945ms
Loaded faceapi model in 934ms
Loading model from /app/models/coco-ssd-mobilenet_v2/model.json
Loaded coco ssd model in 8434ms
Starting server
Listen on port http://localhost:3000
Setup api routes
Server is up and running

How to run the server in background in the docker container? Or is there a different idea behind the API server?

You need to run the docker in detached mode with -d option, see docker run help:
$ sudo docker run -d -p 3002:3000 xemle/home-gallery-api-server

Thank you! I'm still new to docker.

I'm still new to docker.

That is fine.
I propose to use docker-compose which gives you nicer configuration file


'.cuda()' call in the training loop causes failure when running on CPU

The cuda call in the training loop
while self.step < self.train_num_steps:
    for i in range(self.gradient_accumulate_every):
        data = next(self.dl).cuda() #here
        ....

leads to cuda error when running on CPU AssertionError: Torch not compiled with CUDA enabled.

if name == 'main':
//code  here


HttpOnly cookies are exposed when cookies.getAll() is passed

The technique used in the demo is dangerous, since HttpOnly cookies will be written to the document body:
https://github.com/moshest/next-client-cookies/blob/main/demo/app/layout.tsx#L17
Instead, an explicit allowlist can be used to specify which cookie names get passed to the provider.

I guess we don't need to pass the cookies to the client. We just need a place to store then while rending on the server-side.

Fixed at v1.1.0-alpha.0


When specifying requireSignin false on sharing invite API the message specified is not used.

Category

[ ] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
When  I specify a message it should appear in the email invite.
Observed Behavior
I found that only when requireSignin is false the message specified is not used and just the default message of "Here's the document that xxxxxxx shared with you." is used.
Steps to Reproduce
Make call to POST /me/drive/items/{item-id}/invite
{
	"recipients": [{
			"email"<EMAIL_ADDRESS>		}
	],
	"message": "Here is the file!",
	"requireSignIn": false,
	"sendInvitation": true,
	"roles": ["read"]
}

This will not use the message specified.
{
	"recipients": [{
			"email"<EMAIL_ADDRESS>		}
	],
	"message": "Here is the file!",
	"requireSignIn": true,
	"sendInvitation": true,
	"roles": ["read"]
}

This will use the message specified.
[ ]: http://aka.ms/onedrive-api-issues
[x]: http://aka.ms/onedrive-api-issue
See screenshots below:

s

So... nothing yet?  Hmmm... maybe I did something wrong on how I reported this bug.

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


Fix crash when using OpenXR extension wrappers from GDExtension

Fixes https://github.com/godotengine/godot/issues/88613
This is an alternative to PR https://github.com/godotengine/godot/pull/88688 which tries to fix the pattern generally, whereas this PR is just a targeted fix for issue https://github.com/godotengine/godot/issues/88613

Thanks!

Looks like it should also fix GodotVR/godot_openxr_vendors#67?

Yes, it fixed this issue in my testing!

Cherry-picked for 4.2.2.


Pub/Sub:   Infinite Loop on sleep for a 1001 milliseconds in Rails app.

Environment:
Rails: 4.2.10
Ruby: 2.3.5
google-cloud-pubsub: 0.32.0
MacOS: 10.12.6 Sierra

In the rails console I run:
project = Google::Cloud::Pubsub.new(
    project_id: 'my-project-id',
    credentails: 'path-to-cred-file'
)

project.topics

When this runs with default settings the request just hangs.
I know that the config for Pubsub above is correct as I have used the same thing in a smaller Rails 5.2 application and it worked perfectly.
Also, when I run this against the pubsub emulator locally it works perfectly.
It seemed as though this issue was in the GRPC layer so I enabled these ENV variables.
GRPC_TRACE=all
GRPC_VERBOSITY=debug

When I ran the same code above with those enabled, I got a lot of startup logs and then it started looping with this output with incrementing values.

I just tried this from a rails app and it worked fine.
$ bundle exec rails console
Running via Spring preloader in process 4057
Loading development environment (Rails 5.2.1)
irb(main):001:0> require "google/cloud/pubsub"
=> true
irb(main):002:0> pubsub = Google::Cloud::Pubsub.new
=> #<Google::Cloud::Pubsub::Project:0x00007fe0e4bd7050 @service=Google::Cloud::Pubsub::Service(my-project-id)>
irb(main):003:0> pubsub.topics
=> [...]

A few thoughts here.  Since this works for me on a Rails app, and it works for you on a "smaller Rails 5.2" app, then the problem is very likely something to do with your specific Rails app.
The GRPC library is also used when connecting to the pubsub emulator, so again, I would look for other explanations before diving too deep in to GRPC. If GRPC ran into an unexpected problem it would raise an exception. The sleep message looks to be from a thread that manages timeouts, so I wouldn't be overly concerned about it.
Debugging is difficult, and unfortunately there just isn't enough information here for us to diagnose what is going on. Here is what I would suggest:

Create a new rails app, add google-cloud-pubsub, and verify it works
Start adding each dependency from the app that is failing, one at a time, and check to see that pubsub still works (using both the emulator and live API)
Add any other configuration from the failing app, and check to see that pubsub still works (using both the emulator and live API)

At some point pubsub will stop working, and you will then know which dependency or configuration is causing the problem.

@blowmage Thanks for the advice I will step through my dependencies and see what is causing a conflict with the Cloud Pub/Sub gem.
Since this doesn't seem to be a direct issue in the Cloud Pub/Sub gem you can close this issue and I can post my findings on StackOverflow or I can follow up here and post what is causing the conflict whichever you would prefer.

Are you seeing this in your local environment? Or your production environment?

Both, this happens locally when I remove the emulator variable and in production when deployed to GKE.

Are you running multiple threads locally? If so, are you creating a Pub/Sub client (or any other GRPC client) pre-fork?

I create a single Pub/Sub client pre-fork, make some GRPC calls to ensure that the connection is valid than fork treads to start multiple listeners against PubSub subscriptions.
If you are interested the gem/repo I created for this is public and available here: Subserver.
Note: The subserver gem works perfectly in the same Rails 5.2 environment mentioned before.

Unfortunately you can't create a GRPC client pre-fork. This is because GRPC is currently unable to be forked. You need to delay creating any GRPC client until after the web server forks the main thread to create worker threads. See the discussion on this in #691 and #1860, and the GRPC bug grpc/grpc#7951.
The workaround we suggest is adding something like the following to your config/application.rb file, or an initializer, and using this mechanism to acquire the Pub/Sub client in your app. This will share one client per thread. If the thread is killed and restarted, a new client will be created.
require "google/cloud/pubsub"

Google::Cloud::Pubsub.configure do |config|
  config.project_id = "..."
  config.credentials = "..."
end

module MyApplicationModule
  def self.pubsub
    Thread.current[:pubsub] ||= Google::Cloud::Pubsub.new
  end
end

Ahh, I see good to know.  I will update Subserver accordingly so that all threads create their own GRPC client after they are forked.  With that said how would you advise validating the
Google::Cloud::Pubsub.configure do |config|
  config.project_id = "..."
  config.credentials = "..."
end

In the main thread before the application forks?
Also, would this still have an impact on the originally posted hangup issue since it was occurring in the rails console in a single thread environment?

If you create a GRPC client and then fork the thread, the GRPC client will hang on the forked threads.
I don't know about the console, I'm not seeing that behavior. You will still have to debug what your app is doing to cause that. I would assume its related to your configuration and forking though.

@blowmage Thanks for your help.  It turns out it was related to some older google dependencies that we are no longer using.
specifically these
gem 'google-api-client', '= 0.17.0'
gem 'google-cloud-bigquery', '~> 0.30.0'
gem 'google-cloud-storage', '~> 1.9'

Removing those fixed the hangup issue.  Thanks for your help.
Now, I can open another issue / question on this if needed but as you pointed out above you can't create a GRPC client prior to forking threads. So, how do you recommend testing that valid GCP credentials were given?
For subserver I do the following
start CLI and import args
load configuration file

create a Pub/Sub client to test configuration <-
exit and throw error if invalid config.

load subscribers
fork per subscriber and call listen

Should each thread do its own check to validate the connection?  That seems redundant.

If each thread has a connection I would think each thread verifies the connection. You can do that as part of the creation process.

Okay sounds good.  Thanks again for your help, and for your work on this gem.
If you are at all interested and have the time, I would love any other feedback you may have on my implementation of Google Pubsub in Subserver.


An alternative multiply semantic.

A quantity with a conversion factor ratio<N,D,E> where N==1 and D==1 is a coherent quantity
A quantity with a conversion factor ratio<N,D,E> where N!=1 or D!=1 is an incoherent quantity
Compile time multiplication/division by itself on the incoherent quantity ratio cf (cf * cf, cf^n)  may overflow quite soon in N or D  This is not an academic issue.( see example referenced below).
Compile time math on the coherent quantity will never overflow in N or D and only ever overflow with q^integer<intmax_t>::max (unlikely!!!)
Here I show a different semantic for multiplication ( qq_multiply: line 378 /units/quantity.h which  doesn't suffer from compile time overflow.
I show an example in action in example/alternative_multiply_semantic.cpp
Note in there, the commented out part
(EDITED)
 auto xxxxx = xxxx * x ; compile fail : integer overflow
EXTENDED to emphasise thiis is not a 'one off corner case'
https://github.com/kwikius/units/blob/fix_multiply_ratio_overflow/example/alternative_multiply_semantic.cpp#L120
The other advantage of the semantic is you can raise quantities to arbitrary rational powers and roots, also demonstrated in the link (Roots would require ratio in mpusz units having a rational exponent)
I link also an example in my quan library, which shows raising to power 201 and returning back to original quantity using this semantic.
https://github.com/kwikius/quan-trunk/blob/master/quan_matters/examples/high_power_quantities.cpp
It is as always hard to get academics to understand these issue, so if you are happy with the current semantic, fair enough;)
Note that with current semantic in mpusz/units, it takes three(5 with mods to foot_us ratio) multiplies to get overflow with us foot, so with this semantic the library is useful for toy applications,
but not really for real industrial use.

I don't have the same level of experience as either of you with this sort of library.
But I am originally an Engineer (Electronics not Software). My instinct, when I first saw this code immediately asked:....
"Why all the infinite precision maths? Ratio this and exponent that? "

We are talking about physical units here. Scientists and engineers deal with significant figures. All their quantities have inaccuracies. They are very happy to get 4SF and over the moon if they get 8SF.

And the conversion factors? Well they are often approximate too. eg when Imperial and metric met, they got rounded. None of those are more than say 5-6SF either.

An ISO double is about 17SF in base 10.
Yes floating point is inaccurate in many ways but this only manifests itself when you are close to epsilon. When you have 17SF vs 8SF (at most) then this just will not come into it.
So the crazy idea is.... ditch all the complicated ratio based maths  and just use doubles. It's what everyone who is writing apps using physical units is using already. The intro motivation of the paper even says so.
Now such a radical move, would not completely eliminate the above distinction between coherent and non-coherent quantities, but it would trivialise it?
It is possible that I have misunderstood the issue and need to do more research into the design.
All I am saying, is that as an engineer I would be very comfortable doing quite long, many-step calculations for physical quantities using 17SF. I would not be concerned with rounding error / inaccuracies.

Caveat - Are we using Integers so that we can run on embedded where there are no floats (or only very slow ones)? Now that would be be a good reason, but I don't see the facilities or focus on that?

Ben Craig ("freestanding" guy in the ISO Committee) explicitly asks for int support and is already not too happy that we use double by default. Another thing is that until C++20 we were not able to use floating-point values as template NTTP. They were added during the last meeting before code freeze and some people still have doubts if the generated binaries will be portable.
I think that there may be another approach to this subject. Please look at @jansende Benri library https://godbolt.org/z/QedtLM and please let me know what you think about it.

I mean no disrespect to Ben Craig, but what was his reason for wanting ints? I think we need to ask likely users, ie engineers and scientists if they want to use ratio maths?

My understanding of @ben-craig's point of view is that on some embedded platforms there no floating-point support and on many it comes with a large cost (linking some additional big libraries needed).

I update my answer above with more detail. But on Ben Craig's point. Yes! As written in my original post, that is a very relevant reason for embedded work.
But is our lib actually taking that into account. Firstly we should assume 32bit ints. Secondly we should be cross compiling onto a popular embedded platform, or at least thinking about what would happen if we did. We also probably should be thinking about order of operations more.

Benri's lib looks interesting and quite complete. I have not quite understand what you mean to show with the godbolt link and how it's relevant to this discussion.
I found it interesting that he doesn't allow this:
https://godbolt.org/z/c8JPoB

What I meant with CE link was that benri::type::sorted_list<benri::pre<benri::prefix::international_foot, std::ratio<2, 1> > >. Most of the units libraries try to come out with one resulting ratio for the unit while benri decided to use a type list of factors. I am still not sure if this is the right solution but it seems to an interesting approach.

Regarding implicit/explicit conversions we discussed this subject a lot in SG6 in Prague. We decided to stay with chrono-like conversions for the units of the same dimension.

@mpusz Ahh, yes I did notice that, but it didn't strike me as that significant. I guess it means he doesn't face the "transform ratios" or "rounding error" challenges, and is basically deferring the maths until later.
A bit like expression templates do. But in this case it probably results in "more maths operations", as you have to multiply together all the conversion factors at each usage site. Have I understood that correctly?
BTW, I didn't particularly like the Benri 2_centi * metre , but 1_ohm is also possible. Seems like a slightly odd mix of UDLs and "ratio constants".

This is how a downcasting facility works ;-) I think this is a really important feature of our library that increases the user experience a lot. However, there are some issues with it. It might cause ODR violation issues when different headers are included in different translation units.

downcasting facility works

Yes, I know. It's an impressive feature. But it increases coimplexity a lot, has technical issues in its implementation and it suffers from the inevitable "i am going to perform magic and i'll get it right some/most of the time".

Regarding downcasting, I think I should link this here, since it is important but I think we strayed off the issue re semantics of multiplying conversion factors :)
https://github.com/mpusz/units/issues/32

Yes, let's keep this discussion focused. This a really important design point to design and we would better do it right. I still do not know that the best answer is though...

Closing this. Really it should be an issue rather than a pull request.


Any way to deal with unwanted version bumps while iterating on a generator?

I know there's already #485 open, but that one is about missing files, whereas this one is about what to do when the files are in place.
My problem statement is: When I am first making a generator or responding to feedback about a new generator, I will often have to iterate on it a lot. My personal style is that I regenerate the tests after a change I make to the example.tt, so that I can be sure that everything still works. This bumps the test version, which I didn't want in this case.
Current workaround: Manually decrement the version in the .version file before running generate, so that the version stays the same during this operation.
I can also envision perhaps a command-line flag to generate that will refrain from bumping the version. Depends on what behaviour should be the default (to bump or not to bump).
So with this issue I am wondering whether this experience is shared enough to warrant a solution like that flag. If it's unique to me I'll probably just continue with my workaround.

@petertseng I have had the same issue and usually have to remember to set the version to the correct number before opening the PR.  A flag might be useful
Something like:
bin/generate EXERCISE --skip-version

This issue is very close to the top of my todo list.

My current workflow is to comment out the increment lines in the bin/generator  file while I'm developing.

My current workflow is to comment out the increment lines in the bin/generator file while I'm developing.

I tried this out, and then found that a great many of the example.tt files use assert_equal <%= version.next %>, BookKeeping::VERSION (all except connect/example.tt in fact!)
So this successfully stops the .version and example.rb files from being modified, though the generated test file still has a bumped version, argh!
I hacked around it with:
  def version
    @version ||= File.read(path_to('.version')).strip.to_i - 1
  end

but it would be a bit tricky to understand "why is 1 being subtracted?" if this solution were taken. Kind of makes me wish the example.tt were using plain version instead of version.next, but that's a bit of an invasive change.

I have several ideas about this, not sure just yet which is best.

Add a flag to freeze the current version (-f / --freeze or -s / --skip-version)
Default to NOT update and add a flag to update the version (-u / --update-version)
Use an environment variable to toggle updating.
Compare the git sha1 hashes to detect json changes and only update version if json has changed. (And have flag to manually force an update.)

I don't think we should be too worried about making breaking changes, since there isn't anyone updating generators who won't be reading this thread, and we can easily update the documentation.
I think I like number 4 the most.
Opinions?

When I have done this, I have a script that just does a git checkout exericise/active/{filelist} to bring them back down.

@petertseng What if we named that negative 1 to "prior_version" then it would say what it is doing.

I prefer what peter is doing, I think.  Have it pre-set the version file.  Why the exception on the one exercise "connect"?

Another interesting thing to consider - however this is solved, I prefer "if the version number is going to stay the same, do not write the file at all" over "always write the file even if it results in no change since we kept the version number the same", since my editor warns me if something other than itself has changed the file in the meantime.

I have several ideas about this

It seems like 4 (auto-detect whether version bump needed based on sha) is a great benefit, as there should be no risk of people forgetting to bump when necessary, while handling the case of repeatedly re-generating based on the same set of tests (when iterating)!
I would consider 1 (add flag to not update) to be a worthy alternative in the meantime. Between 1 and 2 I chose to default to updating because I suspect that is the more usual reason to modify a generated test file - iterating on the generator seems to be the rarer case, though I may be wrong - y'all naturally know your track better than I do.

"if the version number is going to stay the same, do not write the file at all"

It is not uncommon for the file to be updated without the version number changing.
The version number should only change if there is a change in the test inputs/outputs.
Updating to fix a typo in a test name, a Rubocop warning or adding better failure messages would not cause a version update.

The change in warning does, and the better failure messages may cause a version update, if the conversation changes, we may be scratching our heads wondering which version of the test they are running against... when I say we, I mean anyone reviewing that does not have that problem.  I would say a bump may still be in order, though it may be a fractional number, such as 2.1.  This would be a manual set, rather than an full increment increase.
If this were to happen, we would need to for integer math which at the moment is ignored.  Any introduction of a float would continue to influence that number.

I've started working on this. There's a few things I need to put in place first: #503

Version freezing option is present in: #522
(as is only writing out changed files.)

#522 Has now been merged so I'm marking this as resolved.
Using the --freeze command line option will cause the version number to not be incremented when regenerating tests.
bin/generate --freeze exercise-name


Issue/scheduler backward compatibility (#4815)

Pull request opened by the merge tool on behalf of #4815

Merged into branches iso5 in 5d139b06ba845afbf11252eb0504ea6ff857de64


Fix un-SHA'd docker images

Are these images actually used anymore since the integrations tests don't build with Bazel?

No. Feel okay deleting them?

Are these images actually used anymore since the integrations tests don't build with Bazel?

No. Feel okay deleting them?

If they're unused, go for it. Feel free to submit this though and do a cleanup of unused stuff separately. It's not urgent to delete them or anything.


Broken code commenting in 1.6

VSCode Version: 1.6 September update
OS Version: OSX Mavericks

Previously, while editing JS code in an .html file, it was possible to use the CMD /  keyboard shortcut to comment a line or block of JS code.  Now, it is broken and it inserts HTML comments instead of JS comments.
This is a problem working with Polymer components, because JS and HTML are heavily intermixed in the same .html file.

Adding important since it seems like a regression and 3 users reported already

@isidorn, related to https://github.com/Microsoft/vscode/issues/12969 and "Updated HTML/Razor/Handlebar Support" section in https://code.visualstudio.com/updates/v1_6

@mrmlnc thanks a lot! I guess I should read our release notes :) Removing important, adding to October

duplicate of #11081


ALGORITHMIC: An algorithm that takes an arbitrary equation of any length and returns its number, or vice versa, in reasonable time

The existing scripts to generate equations and find their ids works well enough for equations of length up to 6, but become computationally difficult beyond that.   In principle, the recursive formulae at https://oeis.org/A376640 , https://oeis.org/A376620, https://oeis.org/A103293 may help.  See the discussion at https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Reconstructing.20the.204694.20expressions.20from.20the.20ground.20up.2E

Is it ok to only produce a python script like find_equation_id.py, with the risk of mistakes (especially with the subtle symmetry issues for even n) or should it be Lean code with a proof of correctness?

I think at this stage a python script would be sufficient, as currently the Lean project only treats individual extended equations rather than the whole class of extended equations.

Ok, I'd like to claim this issue.  I now have code that works for odd numbers of operations.  For instance, it reaches without trouble such monsters as
Equation<PHONE_NUMBER>: x = y ◇ ((z ◇ (x ◇ (((w ◇ y) ◇ (u ◇ (u ◇ w))) ◇ u))) ◇ z)
Equation<PHONE_NUMBER>000: x = (((y ◇ (z ◇ (z ◇ y))) ◇ w) ◇ (x ◇ y)) ◇ (((z ◇ u) ◇ (v ◇ r)) ◇ u)
Equation<PHONE_NUMBER>000000000000000: x ◇ y = (x ◇ (x ◇ ((z ◇ (((w ◇ ((u ◇ w) ◇ v)) ◇ u) ◇ r)) ◇ x))) ◇ ((((v ◇ (((s ◇ u) ◇ z) ◇ (r ◇ w))) ◇ x) ◇ z) ◇ r)

For even numbers of operations I have to carefully determine how symmetry interacts with the ordering, but I think it is doable.

OK, great! Can you post a single "claim" comment to make it official?

claim

propose #833

awaiting-review


[Feature Request] Compact with Biome Makeover, Sleep Tight & Snowy Spirit

More specifically, these types of blocks:
Biome Makeover: Terracotta Block and its block set & Tapestry
Sleep Tight: Hammock
Snowy Spirit: Glow lights & Gumdrop
I can provide help with textures.
(As I'm recently making a modpack, I want to ensure every tape of coloured blocks can access the new colours. Your mod almost helps me achieve that.)

Sorry! I found the wrong place.


Fix plugin build issue on non-macOS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f4c940) 4.59% compared to head (b1372fd) 4.59%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #20   +/-   ##
=====================================
  Coverage   4.59%   4.59%
=====================================
  Files         12      12
  Lines         87      87
=====================================
  Hits           4       4
  Misses        83      83

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dockerfile build for javascript not working

RDKit Version: 2<IP_ADDRESS>
OS: Mac
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? rdkit

ALSO: Docker version 19.03.5,
Hi, while trying to use rdkit/Code/MinimalLib/docker/Dockerfile, I ran into the following error around step 26/28
Removing intermediate container dbe2e8d54182
 ---> ca78db9b5857
Step 26/28 : RUN make -j2 RDKit_minimal &&   cp Code/MinimalLib/RDKit_minimal.* ../Code/MinimalLib/demo/
 ---> Running in 08503fd839d4
Adding directories to PATH:
PATH += /opt/emsdk
PATH += /opt/emsdk/upstream/emscripten
PATH += /opt/emsdk/node/12.9.1_64bit/bin

Setting environment variables:
EMSDK = /opt/emsdk
EM_CONFIG = /root/.emscripten
EMSDK_NODE = /opt/emsdk/node/12.9.1_64bit/bin/node

make: *** No rule to make target 'RDKit_minimal'.  Stop.
The command '/bin/bash -c -l make -j2 RDKit_minimal &&   cp Code/MinimalLib/RDKit_minimal.* ../Code/MinimalLib/demo/' returned a non-zero code: 2

This error was preceded by many warnings regarding cmake. For example,
CMake Warning (dev) at Code/cmake/Modules/RDKitUtils.cmake:47 (add_library):
  ADD_LIBRARY called with SHARED option but the target platform does not
  support dynamic linking.  Building a STATIC library instead.  This may lead
  to problems.

and also,
CMake Warning:
  Manually-specified variables were not used by the project:

    RDK_BUILD_MINIMAL_LIB
    RDK_USE_BOOST_IOSTREAMS

Any help would be much appreciated.

I just managed to get to this today and can reproduce the problem.
That's just a test failing and shouldn't impact the function of the library.
I'll look into it in order to see if I can figure out what's causing this particular problem.

I believe this is now resolved.


Bug with hot reloading behavior

Our current hot reloading flow preserves a single EcmascriptEngine instance (to keep a debugger session alive if you have one attached) by resetting the engine and then re-evaluating the changed bundle. See: https://github.com/nick-thompson/blueprint/blob/master/blueprint/core/blueprint_ReactApplicationRoot.h#L420.
That's all good, but our current reset() behavior on EcmascriptEngine only clears the Duktape stack and the persistent lambdas: https://github.com/nick-thompson/blueprint/blob/master/blueprint/core/blueprint_EcmascriptEngine.cpp#L206.
The risk here is that we may have polluted the global javascript environment (by way of registering native functions or storing callback references for js<>native communication, etc) during the prior execution flow, and our reset() behavior doesn't address any global environment pollution.
So I think the ideal fix here is to find a way to properly reset the Duktape context or at least the duktape global object back to its default state.

@JoshMarler tagged this one for you since I think you're planning to look at it

Fixed in #157. Thanks @JoshMarler


Make backquoted inline code only work on a single line

Andrei pointed out linker errors copy/pasted into Phobos doc are written `like this'. That would break things since the backtick was never closed.
This change does what github does in that case: the paired backticks must occur on the same line. If backtick is open when a newline is encountered, the tick is canceled and the text output normally.

awes

ddocbackticks.html kills the git experience on Windows for me, because it is considered modified, but nothing works to get it out of the way. A lot of operations are blocked by error: Your local changes to the following files would be overwritten by merge.
I suspect that this happens because ddocbackticks.html has CRLF line endings. ddoc10336.html has these aswell and has caused trouble in the past, but currently works.

Do you have autocrlf turned on?  You shouldn't have any problems when it's off.

Yes, but that's the default for git on Windows. Unfortunately, Visual Studio also adds CRLF whenever adding lines, so you get mixed line endings when using LF-only files.

It may be the default, but you can turn it off.  And you should, because it's horrible.
And yeah, if you're using visual studio you're going to need to watch out for mixed line endings.

I remember having tried turning autocrlf off when ddoc10336.html was causing troubles, but that was also a disaster. I guess I'll have to find/write some VS extension that handles this better...

So let's just use LF then, that's also what the editorconfig says (not yet for HTML though).


Migrate to ocamlmerlin-lsp

Original PR is here: https://github.com/reasonml-editor/vscode-reasonml/pull/264
Native LSP implementation was merged recently into merlin repository. This PR switches extension to use it instead of OLS. This goes with some features removed (temporarily, I hope):
— find occurances;
— symbol rename;
— case splitting;
— code lens.
Also, it adds support for ocamlformat/refmt, because it was handled by OLS.
What do you think? What else should be done here?

Could you write a summary of what's removed and what's added here?

@andreypopp, I edited the description to mention removed features and addressed your comments
I guess I also need to provide a guide on how to build ocamlmerlin-lsp?

from this list:

— find occurances;
— symbol rename;
— case splitting;
— code lens.

only "case splitting" is still unsupported by merlin-lsp, others were implemented in ocamlmerlin-lsp

Another question: what's the best way to keep compatibility with ocamlmerlin and BuckleScript projects? ocamlmerlin is a crucial part of this extension to jump to definition etc, but the historical way to do so (using reason-cli) hasn't been updated since last August.
Ideally, this extension could be used to run both BuckleScript and native projects, but I wonder what's the best way to use merlin with BS projects, considering it doesn't play well with esy yet? cc @andreypopp

@jchavarri I've been managing native dependencies with esy in bs projects so far — esy.json for esy and package.json for yarn/bs. It worked fine.

I included precompiled (with ocaml-4.02.3+buckle) versions of merlin-lsp and merlin-reason. Now extension should work with Bucklescript projects on mac and linux out-of-the-box.
Next steps are:
— do the same for windows (if it is possible)
— provide setup instructions for non-bs projects
— automate setup for non-bs projects.

One thing I'm noticing when testing this branch is that when opening .re files with comments like /* */, merlin seems to choke:
# 0.02 lsp - debug
send: {
  "jsonrpc": "2.0",
  "method": "textDocument/publishDiagnostics",
  "params": {
    "uri":
      "file:///Users/javi/Development/github/Foo.re",
    "diagnostics": [
      {
        "range": {
          "start": { "line": 0, "character": 0 },
          "end": { "line": 0, "character": 0 }
        },
        "severity": 1,
        "message": "invalidCharacter.orComment.orString",
        "relatedInformation": [],
        "relatedLocations": []
      }
    ]
  }
}

I guess it has to do with the version of the Reason parser that is included with ocamlmerlin-reason?

Hm. Can't repro with /* */ comments now. But // definitely make merlin unhappy.

That's probably because I included ocamlmerlin-reason from reason-cli. I'll fix that

So, I talked to @jchavarri and we agreed that the best workflow for now is esy because it install all required dependencies locally and prevents global switches mess.
But I still really want to provide a seamless experience for BS users who don't want to deal with esy/opam. So, I decided to leave two options:

If extension detects esy configuration, it asks you to specify all required binaries such as merlin-lsp and ocamlformat as devDependencies.
If extension detects bsconfig without esy.json, it tries to use precompiled binaries, but still allow you to override formatters.

If we can't detect either, we just stop and ask user to provide of these configurations, because we have no idea what to do.
Next, we can provide a creation or population of esy.json and probably run esy to install dependencies. Also, I wonder, if we can hide all of this into extension internals and detect compiler version based on project configuration.
@andreypopp @jchavarri @jordwalke what do you think?

Can we perhaps make the scope of this PR more limited and merge it? Like, if there's no ocamlmerlin-lsp in path, just add an error and say that it's not in the path? It would be a great improvement itself and any follow ups would be just icing on the cake!

@wokalski, makes sense to me. I'll prepare changes over the week

@wokalski, it was quite a long week :)
I dumbed down the extension. Now it requires ocamlmerlin-lsp and ocamlmerlin-reason in configuration and doesn't work otherwise. Also, instead of trying to provide a working configuration, I just added instructions to README.
I'll return to esy/opam and easier setup after this PR is merged.
cc @andreypopp @jchavarri @jordwalke

Is this abandoned? People were recommending vscode-reasonml as reason-language-server is pretty unreliable at the moment. This PR looks like a great improvement.

@jfrolich take a look at ocamllabs/vscode-ocaml-platform.


[Bug] Support for VOI LUTs

Describe the Bug
The VOI LUT Sequence specifies a (potentially non-linear) conversion from the output of the (conceptual) Modality LUT values to the input to the (conceptual) Presentation LUT but seems that VOI LUT is ignored by OHIF.
Maybe releated to #818 #2061
Steps to Reproduce
Open viewer at /local path
Select the example file
example file
The current behavior
VOI LUT is not applied to image
The expected behavior
VOI LUT is automatically applied
UI that lists all available LUTs (dropdown, LUTs can have names)
Ability to disable and use normal Window Leveling
OS
Mac OSX Sonoma
Node version
v22.3.0
Browser
Safari 17.5, Edge 126.0.2592.68

You can create non linear LUTs right now,
https://www.cornerstonejs.org/live-examples/stackvoisigmoid
We are definitely interested in using VOI LUTs from the header.

Hi Sedghi,
just to be clear, I need OIHF to apply the VOI LUT contained in tags (00283000).
I have seen that Cornerstone supports these tags (i tried here)
There is something that i can do?

Hi @sedghi is there any update in supporting VOI LUT in viewer? I have an MG image that is shown noisy and I think it is due to this problem as the image looks fine in some other viewers.

Also interested in this, or better yet if I want to implement this myself do you have any suggestions on some starting points.

Same here. You can download and test it using IHE's test dicom file.

VOI LUT does not open in ohif. How can I open it?

@AndreaPetrelli can you let us know what is expected rendering?


Fix typo

Came across this typo while trying to debug something else.

Cherry-picked to flatcar-master-beta, flatcar-master-alpha, and flatcar-master-edge.


Remove 'warm' build steps from the template pipelines

Remove 'warm' build steps from the template pipelines, because they don't have any effect in the new vCurrent build agent queues.
These queues don't run steps on the same EC2 instance so there is warming, pre-launching or other time-saved, only an uneccessary cost to run these.
This change does not change Skuba functionality, nor the build-compile of Skuba iteself.

Per the discussion, this isn't the right change. Sam made a better change by updating the docker-ecr-cache plugin and using the new skip-pull-from-cache here.


Improvement: commands via payload

With the current version, the user has to create a full JSON request and use this as an input. As MAC address, IP address are already configured, it would be better, to interpret the payload of the input message just as a command (ON/OFF/REPORT/...)
The settings for MAC and IP address should be used from the configuration node.

Hi hifiberry,
Cool Idea, it should be super easy to implement in the next update! I will make sure to close this issue once I have done so.
Quick question though: What is you use-case for injecting JSON object instead of using the property editor?
Cheers

I want to control a switch from other automations. Right now I have to create 3 different objects for this: ON/OFF and REPORT.

Actually this should already be possible. If you have a look at the advanced guide in the readme you can see how you can construct a JSON payload to progrmmaticall change what you want to do.

Closing due to inactivity


scan: proper parse for numeric elements (future validation pass)

add correct enum parsing according variable type.
This not take care about named enums, only fix correct exposing integer enums into spec.
Example:
enum: 1,2,3
result for int variable :
          "type": "integer",           "format": "int64",           "default": 1,           "enum": [             1,             2,             3           ],
fix https://github.com/go-swagger/go-swagger/issues/1672
actually this not fix only integer as uses type parse of provided values.

@casualjim hello. can you explain what is wrong with WIP? I've already created all permission to my fork

it wanted more permissions, i've uninstalled the app now because there are draft pull requests in github


Add viresclient to Projects

This package provides access to the ESA Swarm mission data and models. It's part of a larger server/client architecture "VirES" supported by ESA, principally for Swarm, though could evolve to other datasets in the future (VirES for Aeolus is in development). GUI access is at https://vires.services and there is also now a free "Virtual Research Environment" at https://vre.vires.services (a JupyterHub deployment) where we plan to provide ready-to-run notebooks soon.
The server can provide flexible access to time series of most of the Swarm products, together with on-demand evaluation of geomagnetic field models. viresclient accesses this server and returns requested data as pandas or xarray objects.

Merging it now, but note were about to add in a grading process for everyone's code base. Be on the lookout for an email about it.

Thanks! I will keep an eye out


Copies of emails still not appearing in users inboxes.  Mail only appears in the actual group folder

The instructions here have failed to function as described.  Users only receive the email in the group folder in the folder tree.  A copy of the email is not placed in the users actual inbox.  This causes users to often miss the communication.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d36ccf55-c8e6-e4a2-c99d-1feeb9e0b7ca
Version Independent ID: 24e94600-1f0d-9d8b-abae-73690a4a633d
Content: Create an Office 365 group in the admin center
Content Source: Office365-Admin/create-groups/create-groups.md
Service: o365-administration
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@officedocsbot assign @mypil

@kglick - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

@officedocsbot close


Derek/restructure

breaks navdata into navdata and operations
rewrites concat, sort, loop_time, interpolate, find_wildcard_indexes so their independent functions and not class functions
adds concat ability to concatenate an arbitrary number of NavData instances rather than just two
breaks out components of visualizations into independent files
updates ReadMe, etc. with updated directory structure
creates uniform tutorial structure with a notebook file at least for each file in gnss_lib_py
updates python packages

codecov says coverage percentage has decreased since the total number of lines of code has decreased. utils/filters.py is still the only file not covered.


Add for each with break method

I think this changes look good, maybe this could be PR to open on the main repo.

Closing since we don't need it anymore


Replace XFAIL with narrow skips to not clutter CI logs

What this PR does / why we need it:
Some of the XFAIL tests are now producing logs for more than a year.
Replace the XFAIL with narrow clear skips. Since xfail seems to be
mostly used to track external issues in some k8s versions, replacing
them with a skip with the implicit feature that it will break when we
introduce new k8s versions in CI which may have this feature fixed.
It is not optimal, since someone completely outside of the project may
want to run tests against their cluster and they may be confused, but it
adds a repeating non-ignorable re-evaluation point while keeping clear
what's supposed to work and what not.
For the seldom other cases where xfail was used I would recommend a clear skip pointing to an issue which is assigned to someone, since it does not seem to work out to get rid of xfails fast, which is not helpful when changing code or when refactoring.
Getting rid of xfail resolved the following issues:

whenever something really fails in that area it is very hard to understand if xfail tests are now failing more
it was still confusing for people  to read (X)FAIL during  their code changes, making it not clear to them if they should ignore it or not.
XFAIL does not seem to speed up fixing issues, which means that all engineers are exposed to additional CI logs which they have to parse for quite some time, increasing the cognitive load.
Since the skips were just continuing to happen on newer k8s versions it was not clear if failing tests still fail due to the original issue, but since CI jobs stayed green the incentive to check the tests again was low. As a result it was not clear what was supposed to work and what not.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
@AlonaKaplan it turns out that starting with k8s-1.22 most tests finally start to succeed. This finding is considered in the skips.
Release note:

NONE

/cc @AlonaKaplan

I agree that since the tests in the expose file are working since k8s 1.22, it makes sense to substitute them with skips. But why removing the XFail implementation? I suggest splitting the PR. Keeping the expose tests changes. And discussing the XFail complete removal in another PR. @EdDev

I was sceptical in letting it being added and I think it clearly did not add much benefit. Instead I got asked multiple times if the XFail is something to bother. During the removal I just found out that some of the XFails don't fail always anymore (which is again a hint that they don't add the value which @EdDev had in mind).


Use --ignore-source-errors option in javadoc

Per https://bugs.openjdk.java.net/browse/JDK-8268582 javadoc has such an option. Using this option to generate partial documentation is preferable to having blank content when Minecraft undergoes a big update and the fake source generated doesn't comply to the minimum compilation standards required by javadoc tool, such as package-private access, etc.

Note that 22w06a javadoc does not build due to the issue.


v3.3.2+ windows @ rb_sysopen errors

Hello,
Have Rails app for which some development activity is on Windows 10. Recent version releases of Sprockets > 3.3.1 on this OS generates errors like the following for all assets:
Started GET "/assets/favicon-users.ico" for <IP_ADDRESS> at 2015-08-24 10:47:13 -0400
Unexpected error while processing request: Invalid argument @ rb_sysopen - C:/Users/peter_000/immunQC_bs/C:/Users/peter_000/immunQC_bs/C:/Us
ers/peter_000/immunQC_bs/C:/Users/peter_000/immunQC_bs/C:/Users/peter_000/immunQC_bs/app/assets/images/favicon-users.ico
Note in error message above, path to rails app repeated 4 times before final complete path is provided.  Don't know if this repetition is diagnostic or not.
Raymond

My mistake. Meant to post this to main sprockets page.


feat(Text): Json parser

计算策略能放宽一点吗，用fix构造循环引用很不美观

All checks have failed.
I tried a few times and the test failed. What caused the test to fail?

@EMQ-YangM fixed,实际上是因为point-free无法骗过编译器的循环依赖检查


HAWQ-1360. Check privilege of sequence pass the wrong type to RPS.

When check privilege of query with ranger enabled, a json request will be send to RPS, including information about: privilege type, resource type and role name.
Currently, checking sequence privilege will send resource type "table" instead of  "sequence".

+1


problem installing latest development wheels directly from releases page

The links to the Python wheel artifacts are no longer part of the web page, so the pip install --find-links... doesn't work.
The solution is to explicitly add invisible links to the page. The only constraint is that there are no line-breaks between the links. When there are, it results in a significant amount of empty lines.
The template for the invisible links is:

The end result should be a single line inserted under the pip install... instructions:
 ...

The latest releases contain the required HTML for pip install to work from the release pages.


TwitterV2 cutting off contents of items at 137 characters with a … (single character ellipses)

Describe the bug
TwitterV2 cuts off contents of an item (single tweet) at 137 characters with a … (single character ellipses). TwitterBridges, and the API (as best as I can tell), allows the full 240 characters, with extras for certain links.
To Reproduce
Steps to reproduce the behavior: (I don't have a public instance I use, so I'll describe it)

Go to a TwitterV2 installation
Look for an item with more than 137 characters, it will end with a "…" in both the  and the  elements of the  section

Expected behavior
The entire tweet to be shown in the feed.
Desktop (please complete the following information):

OS: Windows, macOS
Browser Firefox
Version 103.0.2

Additional context
This working in TwitterBridge, though that doesn't use the API. I'd love to switch to the API version, but this ruins a number of feeds I follow. (LOLsuit threads are long winded.)

@quickwick

Specifically this tweet is one that comes up like that in my reader (and in the raw rss produced when viewed as code). https://twitter.com/AkivaMCohen/status/1564803550856855559

@kalaklanar
There is nothing I can find in TwitterV2 bridge that is deliberately truncating Titles. I'll keep looking, through, maybe I missed something.
I did some testing, both with the Twitter account you suggested as well as others, and saw lots of tweets with Titles longer than 137 characters. I was unable to pull up that one specific tweet you linked, even when pulling the maximum 100 items. That fella sure tweets a lot.
The only time I saw the single-character "..." at the end of a Title is when the Title ends with a URL. That's not being done by TwitterV2 bridge, as far as I can tell, so I started wondering if it was one of the functions outside the bridge doing this. I also realized my rss-bridge was a fair bit out of date, so I updated to master, and now my entire rss-bridge is broken. And I'm getting a migraine. I'll have to look at this further another day.

@kalaklanar Can you find a more recent result? The tweet you mentioned is too old for the max 100 limit.

@kalaklanar After updating my system to PHP7.4 and getting rss-bridge (specifically commit f40ed56) back up and running (thanks again dvikan!), I am now sort of seeing what you're seeing. Every Title is truncated at 150 characters. However, this is not being done by the TwitterV2 bridge. I also checked, and Titles are being truncated to 150 characters in the Twitter bridge.
I searched the rss-bridge codebase, and found a truncate function in lib/html.php which truncates to 150 characters by default. This truncate function must be applied to the Title of all bridges during the HTML generation process.
At this point everything appears to be working as designed. I assume you're on an older version/commit of rss-bridge? Please try updating and let me know if you are able to reproduce your issue on f40ed56 or later.

Here is a more recent post: https://twitter.com/timorousathome retweeted one from https://twitter.com/NeilRobinsonUL https://twitter.com/NeilRobinsonUL/status/1564722699485732870 on 8/30, but it off twitter or a bit now, so it's still only the 4th tweet in her timeline.
Right now, it shows up at https://kalak.fun/rss-bridge/?action=display&bridge=TwitterV2&context=By+username&maxresults=&format=Mrss&u=timorousathome with the ellipsis character at lines 190 and 204. (Downloaded version attached.)
FM2pBfnx.txt

Also, the version of the script matches the current git version (checked out today from https://github.com/RSS-Bridge/rss-bridge.git)

The data is coming truncated directly from twitter api. But the includes object has the entire tweet.

https://twittercommunity.com/t/twitter-api-v2-only-retweet-text-truncated/151128

@kalaklanar Thank you for the second tweet example. Based on that, and some additional checking of the NeilRobinsonUL feed, here's the behaviour I'm seeing: All regular and reply tweets are capped out at 150 characters in the Title and end in a three-character ellipsis. This is applied by the truncate function in lib/html.php, called by lib/FeedItem.php, which was added to rss-bridge in commit #2920. Most re-tweets are also truncated at 150 characters with a three-character ellipsis, but some re-tweets are truncated shorter than 150 characters and have that single-character ellipsis (unicode 2026), in both the Title and body.
The truncation to less than 150 characters and single-character ellipsis is not being applied by the TwitterV2 bridge or, as far as I can tell, by rss-bridge. So I checked the data coming from the Twitter V2 API, and indeed those particular retweets are truncated and have the single-character ellipsis in the data returned by the API.
I'm already making a second API call to get all retweets, to get their media info, so I can probably make an adjustment in the bridge to use the text of the retweets as well. Might take me a little while, though.

Thanks for digging into it. I know rewriting code takes time.
Also, thanks for the V2 bridge. I love it.

Well that turned out to be a pretty trivial fix. Yay.

Thanks. May all your bugs are trivial to fix.


Unrecognized option error when launching spring-cloud-starter-task-spark-yarn-1.2.0.RELEASE

Hi, I'm running spring-cloud-dataflow-server-yarn-1.2.0.RELEASE server in docker cloudera container with SPARK2-2.1.0.cloudera1-1.cdh5.7.0.p0.120904-el6.parcel and hadoop-2.6.0-cdh5.11.1.
Server starts without any issues, but when I'am submitting spark task it fails with:
Unrecognized option: --spark.app-jar=hdfs://app/spark/basic-spark-0.1-SNAPSHOT-jar-with-dependencies.jar Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit.
I'm registering app and creating task using:
app register --type task --name spark-yarn --uri hdfs:///app/spark/spring-cloud-starter-task-spark-yarn-1.2.0.RELEASE.jar
task create spark --definition  "spark-yarn --spark.app-name=my-test-pi --spark.app-class=app.SparkESIngester --spark.app-jar=hdfs://app/spark/basic-spark-0.1-SNAPSHOT-jar-with-dependencies.jar --sark.assembly-jar=hdfs://app/spark/spark-assembly-1.6.1-hadoop2.6.0.jar --spark.app-args=10"
task launch spark
If anyone is able to provide some assistance would me immensely appreciated, as nothing on the web makes sense to resolve this and get the spark task going!!!
Thank you!

HI, @mglebka: While we wait for someone to look at it closely, I wanted to point out that you have a typo in the stream definition. --sark.assembly-jar should be --spark.assembly-jar - worth retrying it with the right property.

Hi @sabbyanandan, thank you for quick feedback, I fixed this typo but it did not help, still the same issue.

Hi, the problem was that I was using spring-cloud-starter-task-spark-yarn.jar instead of spark-yarn-task.jar. Closing this issue.


Cherry pick #3152 into stable

This reverts commit 7d722d4d36debcf5bb79fa4006f455bd72caeee1.

Description:
Related issue (if exists):

Coverage remained the same at 97.079% when pulling ad5c7c6ce4a43d3db8c0218b914bfca1fdaaf3cb on kwonoj:cherry-pick into 6b6843b899f70f6255ef9aa52bf12df430d68cff on ReactiveX:master.

This was merged into master. Is that right?

Well, I think this targets the wrong branch too.

yes, re-cherrypicked. https://github.com/ReactiveX/rxjs/pull/3158


Fusion Installer/Uninstaller

Updated the installer and uninstaller scripts to work with Red Hat 7.  The scripts have been tested against Red Hat 7, Ubuntu 14.04 and Ubuntu 16.04.

Hey, @arjntc1 can you make sure you've signed the CLA and that the email listed on your commits matches the one you use for github? You can also add the email you're using on the commits to your github profile. See the FAQ for more info: https://github.com/google/earthenterprise/wiki/Frequently-Asked-Questions#2-ive-signed-a-cla-why-does-github-have-an-x-on-my-commit-and-it-says-failure-need-a-cla-for-one-or-more-commit-authors-when-i-hover-over-the-x


Add response handling in otelmiddleware

After the middleware calls the next function it gets diverted to the application code outside of the middleware. To capture the statuscode use something that resembles: https://github.com/urfave/negroni/blob/master/response_writer.go

Done, by implementing #74