De-Risk Provisioner Deletes

Tell us about your request
Is there any changes that could be made to de-risk deleting a Karpenter Provisioner?
Through operator error I've now twice un-intentionally deleted a Provisioner and Karpenter was able to take action and delete most nodes in our cluster within 30 seconds.
Could there be a configurable/larger batch window on contextually large deletes like this?
Introduce a post delete cooldown?
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
The analogy I've had in my head is that it is much harder to delete EC2 Instances or ASGs than it is for Karpenter to delete a provisioner & de-provision all nodes all in 1 go.
EC2 you would need to select all nodes you want to delete and delete them.
ASGs deletes on the CLI will not process if they contain instances without a force flag. Console will require a second confirmation.
This is all assuming the user persona taking these actions are already privileged.
Kubernetes RBAC also makes it difficult to disallow unsafe actions for privileged users since it does not and will not introduce a Deny action.
Are you currently working around this issue?
We're attempting to add more flags to the Provisioner through our deployment mechanism, but we've already hit once where the change did not interact with that protection. (ArgoCD annotation to disallow it from Pruning the resource, however because it was a Helm Hook performing the delete it did not take effect).
We could also introduce a Gatekeeper/Similar policy to disallow these deletes but I was hoping there might be things Karpenter can do to de-risk a default install of Karpenter.
Additional Context
Slack Discussion: https://kubernetes.slack.com/archives/C02SFFZSA2K/p1682364988166489
Ran into some edge cases with Hooks that I did not fully understand after implementing this on our provisioners: https://github.com/aws/karpenter/pull/3605
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Kubernetes RBAC also makes it difficult to disallow unsafe actions for privileged users since it does not and will not introduce a Deny action

Is it possible to just disallow Delete from the Provisioner RBAC, except for highly escalated users?

What is the Provisioner RBAC if not Kubernetes RBAC?

What is the Provisioner RBAC if not Kubernetes RBAC

I guess I'm trying to understand if you can remove the "delete" permission from the allow-listed clusterRole that is assigned to whoever is accessing the cluster. I get your point on the lack of Deny, I was mainly just trying to understand if removing Allow is an option.

I think if customers are following the normal best practices with Kubernetes, yes it'd be easier to not use the cluster-admin role or avoid granting delete to the privileged role. We're just assigning the builtin cluster-admin role which I am not sure can be modified...
At least in my case it was the cluster admin persona/cluster deployment tooling that had admin privileges and I still found it fairly dangerous to interact with Provisioner deletes due to lack of confirmation & how quickly Karpenter takes action with no cooldown.
Might it be possible to add a configuration flag to Karpenter that it will not delete nodes on a provisioner delete? It'll mark it for deletion and then require manual node cleanup?

You could look into a policy agent to prevent accidental deletes.

Closing, as this responsibility lies outside of this project.


Upgrade dependencies

Codecov Report

Merging #83 (a74fdaf) into master (73c8263) will decrease coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is 7.69%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   76.01%   75.91%   -0.10%
==========================================
  Files          12       12
  Lines        1088     1092       +4
==========================================
+ Hits          827      829       +2
- Misses        261      263       +2

Flag
Coverage Δ

unittests
75.91% <7.69%> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

lib/renderer.lua
97.22% <ø> (ø)

lib/request.lua
64.70% <ø> (ø)

lib/session.lua
97.09% <ø> (ø)

lib/exec.lua
94.11% <0.00%> (ø)

lib/response.lua
61.81% <11.11%> (-0.41%)
:arrow_down:

lib/reflex.lua
45.16% <6.06%> (+1.20%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


HUB-212: Create a prompt page on stub-idp Add new resource and related view for single IDP journey prompt page Use ServiceListService to retrieve list of services from Verify Hub

Minor change to update import statement to meet coding standards.


Split python SDK dependencies by config stores

Suggestion
More a point of discussion/idea rather than a concrete feature request. If this is not the direction Configu wishes to go in then please feel free to close this issue
Python dependency resolution supports the concept of package "extras" - we could split the dependencies by config store, where individual config stores/sets of similar config stores could be packaged as "extra" dependencies. e.g. the boto3 dependencies could be installed via "configu[aws]".
Motivation
With an ever increasing number of config store providers, the SDK's dependency tree will continue to increase going forward. This leads to:

Increased dependency resolution time
Increased likelihood of version incompatibilities with other packages

As far as I'm aware users will typically only require a single type of config store, in some cases at most 2-3 types. Thus most users won't actually require the ability to support all config store types.
Context
https://python-poetry.org/docs/pyproject/#extras
Running on Ubuntu Linux, installing a fresh project with only configu as a dependency took 15 minutes.
OS/Arch: Linux 20.04.1-Ubuntu x86_64`
pyproject.toml:
[tool.poetry]
name = "consumer"
version = "0.1.0"
description = ""
authors = ["lucas<EMAIL_ADDRESS>readme = "README.md"

[tool.poetry.dependencies]
python = ">=3.9,<3.12"
configu = "^0.6.1"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

poetry version: 1.5.1
python version: 3.9.16
Installation time: 942.7s
(Package operations: 53 installs, 1 update, 0 removals)

The Python SDK is deprecated in favor of the @configu/proxy server.


SPFx Application Customizer extension is not triggered

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Question
[ ] Typo
[ x] Bug
[ ] Additional article idea

Expected or Desired Behavior
SPFx extension that adds content to the page headers works in debug mode, but for shipped to CDN version - it does not work most of the time.
I am using per site manual installations, not using skipfeatureDeployment=true
Observed Behavior
I did some research, SPFx extension comes to the O365 website inside the default feature, and the feature references elements.xml file that specifies the ApplicationClientId from SPFx extension and the custom action exist to register this application Id for executing.
This ID is perfectly correct and sometimes it worked in O365 and then stopped.
No console errors are displayed.
Important observation:
On modern pages, I can see that HTML code has the custom action:
""customActions" : [{"title":"Top Navigation","location":"ClientSideExtension.ApplicationCustomizer","clientSideComponentId":"a4212e47-b76a-4e53-8985-625daedf5ec2","clientSideComponentProperties":"{"Top":"Top area of the page","Bottom":"Bottom area in the page"}","sequence":65536,"rights":{}}],
"
So since component with id a4212e47-b76a-4e53-8985-625daedf5ec2 exists and custom action exists on the page that triggers this component Id - it should work. But SharePoint does not even try to load my SPFX extension JS file from CDN.
My guesses:
1)Javascript code in O365 that is responsible for processing registered custom actions - is not running correctly, but not showing any errors in console
2)SPFx extension with specified Id is not deployed correctly and cannot be found by SharePoint. However, there no errors are displayed during deployment.

Hello IvanToronto,
Could you go to the SPFx developer tools (pressing Ctrl+F12) and see if you have any errors in the Trace logs? Also, double check that you can find the manifest for your component id in the Manifests tab.
Both your guesses can be checked in there. With the actual error from SPFx we can look at what went wrong.


Stackable#2

Fixes https://github.com/digitalbazaar/angular-stackables/issues/2
Also fixes a bug with z-indexes in Safari. JQuery, when getting a z-index from the computed stylesheet (i.e. doing element.css('z-index')) will ignore any z-index that has been set if an element's positioning has also not been set https://bugs.jquery.com/ticket/9667. The two fixes for this would be to either explicitly set a positioning for all of our dialogs, or just get the z-index value from the stylesheet (I did the latter).

Manual testing passes here.

Couple of minor things to address then LGTM, merge.


Redraw

I wanna know if there is some kind of Redraw function on the library. If there is, give me some example showing how to use the redraw function.
thanks a lot. ^^

The data is not render on chart.
Some times that kind of error happens with me. Maybe I can solve it using redraw.

I solved my problem!
The library can not reset the data and recalculate in the same vector, it makes a chart in trouble.
The tip to solve it is: If your application needs a redraw or recalculate a your chart data, do not reset your vector to a new informations! Get the new informations in a new vector and in the end atribute that at a main array.
See the examples below:
Do not do:
vector chart data = [1, 2 ,3];
vector chart data = [];
vector chart data = [4 ,5 ,6];
do like that:
vector chart data = [1, 2 ,3];
vector auxiliar redraw data = [4, 5, 6];
vector chart data = vector auxiliar redraw data;


compile-tests error

sudo npm run test

><EMAIL_ADDRESS>test /Users/aflyax/Documents/git/black-screen
> gulp typescript; gulp compile-tests; electron run-tests.js

[00:00:02] Requiring external module babel-core/register
[00:00:03] Using gulpfile ~/Documents/git/black-screen/gulpfile.babel.js
[00:00:03] Starting 'typescript'...
[00:00:06] gulp-notify: [Black Screen Watcher] TypeScript has been compiled.
[00:00:06] Finished 'typescript' after 3.38 s
[00:00:06] Requiring external module babel-core/register
[00:00:07] Using gulpfile ~/Documents/git/black-screen/gulpfile.babel.js
[00:00:07] Starting 'compile-tests'...
test/src/history_test.ts(1,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/mocha/mocha.d.ts' not found.
test/src/history_test.ts(2,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/chai/chai.d.ts' not found.
test/src/history_test.ts(5,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/history_test.ts(5,23): error TS2307: Cannot find module 'chai'.
test/src/history_test.ts(6,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/history_test.ts(9,1): error TS2304: Cannot find name 'describe'.
test/src/history_test.ts(11,5): error TS2304: Cannot find name 'afterEach'.
test/src/history_test.ts(11,31): error TS2339: Property 'clear' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(13,5): error TS2304: Cannot find name 'describe'.
test/src/history_test.ts(14,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(15,28): error TS2339: Property 'size' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(18,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(19,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(20,28): error TS2339: Property 'size' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(22,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(23,28): error TS2339: Property 'size' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(27,5): error TS2304: Cannot find name 'describe'.
test/src/history_test.ts(28,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(29,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(30,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(32,28): error TS2339: Property 'size' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(35,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(36,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(37,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(38,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(40,28): error TS2339: Property 'size' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(44,5): error TS2304: Cannot find name 'describe'.
test/src/history_test.ts(45,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(46,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(47,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(49,28): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(50,28): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(53,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(54,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(56,28): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(57,28): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(61,5): error TS2304: Cannot find name 'describe'.
test/src/history_test.ts(62,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(63,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(64,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(66,21): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(67,21): error TS2339: Property 'getPrevious' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(68,28): error TS2339: Property 'getNext' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(71,9): error TS2304: Cannot find name 'it'.
test/src/history_test.ts(72,21): error TS2339: Property 'append' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/history_test.ts(74,35): error TS2339: Property 'getNext' does not exist on type 'typeof "/Users/aflyax/Documents/git/black-screen/src/History"'.
test/src/providers/file_test.ts(1,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/mocha/mocha.d.ts' not found.
test/src/providers/file_test.ts(2,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/chai/chai.d.ts' not found.
test/src/providers/file_test.ts(5,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/file_test.ts(5,23): error TS2307: Cannot find module 'chai'.
test/src/providers/file_test.ts(6,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/file_test.ts(7,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/file_test.ts(8,9): error TS2305: Module '"/Users/aflyax/Documents/git/black-screen/src/Interfaces"' has no exported member 'Suggestion'.
test/src/providers/file_test.ts(9,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/file_test.ts(14,1): error TS2304: Cannot find name 'describe'.
test/src/providers/file_test.ts(15,5): error TS2304: Cannot find name 'describe'.
test/src/providers/file_test.ts(16,9): error TS2304: Cannot find name 'it'.
test/src/providers/file_test.ts(16,50): error TS7006: Parameter 'done' implicitly has an 'any' type.
test/src/providers/file_test.ts(17,30): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
test/src/providers/file_test.ts(20,13): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
test/src/providers/file_test.ts(20,69): error TS7006: Parameter 'results' implicitly has an 'any' type.
test/src/providers/file_test.ts(26,9): error TS2304: Cannot find name 'it'.
test/src/providers/file_test.ts(26,46): error TS7006: Parameter 'done' implicitly has an 'any' type.
test/src/providers/file_test.ts(27,30): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
test/src/providers/file_test.ts(30,13): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
test/src/providers/invocation_test.ts(1,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/mocha/mocha.d.ts' not found.
test/src/providers/invocation_test.ts(2,1): error TS6053: File '/Users/aflyax/Documents/git/black-screen/dts/typings/chai/chai.d.ts' not found.
test/src/providers/invocation_test.ts(5,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/invocation_test.ts(5,23): error TS2307: Cannot find module 'chai'.
test/src/providers/invocation_test.ts(6,1): error TS1202: Import assignment cannot be used when targeting ECMAScript 6 or higher. Consider using 'import * as ns from "mod"', 'import {a} from "mod"' or 'import d from "mod"' instead.
test/src/providers/invocation_test.ts(11,1): error TS2304: Cannot find name 'describe'.
test/src/providers/invocation_test.ts(12,5): error TS2304: Cannot find name 'describe'.
test/src/providers/invocation_test.ts(13,9): error TS2304: Cannot find name 'it'.
test/src/providers/invocation_test.ts(13,60): error TS7006: Parameter 'done' implicitly has an 'any' type.
test/src/providers/invocation_test.ts(14,30): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
[00:00:09] TypeScript: 75 semantic errors
[00:00:09] TypeScript: emit succeeded (with errors)
[00:00:09] Finished 'compile-tests' after 1.88 s
App threw an error when running [ReferenceError: chai is not defined]

Atom says:
Uncaught Exception:
ReferenceError: chai is not defined
    at Object.<anonymous> (/Users/aflyax/Documents/git/black-screen/compiled/test/src/history_test.js:4:14)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /Users/aflyax/Documents/git/black-screen/node_modules/mocha/lib/mocha.js:216:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/aflyax/Documents/git/black-screen/node_modules/mocha/lib/mocha.js:213:14)

Have you installed all dependencies? As I can see chai module don't installed when it should be.
Run npm install in black-screen folder and try again.

Tests don't work, and even if they did, they don't cover anything. It bothers me a lot and we have to do something about them.

➜  black-screen git:(master) npm install

><EMAIL_ADDRESS>preinstall /Users/aflyax/Documents/git/black-screen
> npm prune

><EMAIL_ADDRESS>install /Users/aflyax/Documents/git/black-screen/node_modules/electron-rebuild/node_modules/nslog
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/nslog/src/main.o
  CXX(target) Release/obj.target/nslog/src/nslog_mac.o
  SOLINK_MODULE(target) Release/nslog.node

><EMAIL_ADDRESS>install /Users/aflyax/Documents/git/black-screen/node_modules/ptyw.js
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/pty/src/unix/pty.o
  SOLINK_MODULE(target) Release/pty.node

><EMAIL_ADDRESS>postinstall /Users/aflyax/Documents/git/black-screen
> npm run recompile

><EMAIL_ADDRESS>recompile /Users/aflyax/Documents/git/black-screen
> HOME=~/.electron-gyp cd node_modules/ptyw.js; node-gyp rebuild --target=$npm_package_electronVersion --arch=x64 --dist-url=https://atom.io/download/atom-shell

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/pty/src/unix/pty.o
  SOLINK_MODULE(target) Release/pty.node
<EMAIL_ADDRESS>node_modules/electron-rebuild
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/ptyw.js
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Trying to install xcode now, will see if that helps.

Installed XCode. Now:
➜  black-screen git:(master) npm install

><EMAIL_ADDRESS>preinstall /Users/aflyax/Documents/git/black-screen
> npm prune

><EMAIL_ADDRESS>postinstall /Users/aflyax/Documents/git/black-screen
> npm run recompile

><EMAIL_ADDRESS>recompile /Users/aflyax/Documents/git/black-screen
> HOME=~/.electron-gyp cd node_modules/ptyw.js; node-gyp rebuild --target=$npm_package_electronVersion --arch=x64 --dist-url=https://atom.io/download/atom-shell

  CXX(target) Release/obj.target/pty/src/unix/pty.o
  SOLINK_MODULE(target) Release/pty.node
➜  black-screen git:(master) npm run package

><EMAIL_ADDRESS>package /Users/aflyax/Documents/git/black-screen
> gulp build && electron-packager . "$npm_package_productName" --overwrite --platform=darwin --arch=x64 --version=$npm_package_electronVersion --out='/Applications' --icon='./icon.icns'

[11:55:38] Requiring external module babel-core/register
[11:55:39] Using gulpfile ~/Documents/git/black-screen/gulpfile.babel.js
[11:55:39] Starting 'typescript'...
[11:55:39] Starting 'sass'...
[11:55:39] 'sass' errored after 30 ms
[11:55:39] Error: The `libsass` binding was not found in /Users/aflyax/Documents/git/black-screen/node_modules/gulp-sass/node_modules/node-sass/vendor/darwin-x64-46/binding.node
This usually happens because your node version has changed.
Run `npm rebuild node-sass` to build the binding for your current node version.
    at Object.sass.getBinaryPath (/Users/aflyax/Documents/git/black-screen/node_modules/gulp-sass/node_modules/node-sass/lib/extensions.js:158:11)
    at Object.<anonymous> (/Users/aflyax/Documents/git/black-screen/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:16:36)
    at Module._compile (module.js:435:26)
    at Module._extensions..js (module.js:442:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/aflyax/Documents/git/black-screen/node_modules/babel-core/node_modules/babel-register/lib/node.js:135:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/aflyax/Documents/git/black-screen/node_modules/gulp-sass/index.js:176:21)
[11:55:42] gulp-notify: [Black Screen Watcher] TypeScript has been compiled.
[11:55:42] Finished 'typescript' after 3.09 s

npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "package"
npm ERR! node v4.2.2
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>package: `gulp build && electron-packager . "$npm_package_productName" --overwrite --platform=darwin --arch=x64 --version=$npm_package_electronVersion --out='/Applications' --icon='./icon.icns'`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>package script 'gulp build && electron-packager . "$npm_package_productName" --overwrite --platform=darwin --arch=x64 --version=$npm_package_electronVersion --out='/Applications' --icon='./icon.icns''.
npm ERR! This is most likely a problem with the black-screen package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp build && electron-packager . "$npm_package_productName" --overwrite --platform=darwin --arch=x64 --version=$npm_package_electronVersion --out='/Applications' --icon='./icon.icns'
npm ERR! You can get their info via:
npm ERR!     npm owner ls black-screen
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/aflyax/Documents/git/black-screen/npm-debug.log

npm rebuild node-sass and rebuilding worked. Starts now.


Change topic

Hello again @mghaan! Sorry to bother you again sir...
Finally I've got the hang of this incredible project so it was time to deploy and integrate to my home automation system of choice (Home Assistant) and stumbled upon a major problem.
I have a total of 5 different Windows computers and coded all MQTT messages for all of them. When I've copied all files to the computer, edited the winthing.conf file to reflect the correct computer name as the unique client_id I've discovered that the topic was not changed...
Since all computers would have the same topic structure, this project becomes unusable for my use case.
So that is why I am here: do you plan on updating the code to be able to set a unique topic for different computers on the same network? That would be awesome to change just the winthing part from the topic...
Thanks a lot.

It seems I accidentaly removed this option from the docs which exactly solves your problem. Try to add this into winthing.conf:
prefix = somecomputer
Then that instance should listen on topics with "somecomputer" prefix instead of winthig, eg.:
somecomputer/system/online
somecomputer/system/commands/run
I have to fix the docs and re-add this option. If it doesn't work, I'll have a look.

Thanks for your help @mghaan! Will try now and let you know. Have a great day sir!

Amazing @mghaan! It worked!
11:46:37 INFO [main/c.f.w.systems.system.SystemCommander] Found whitelist of allowed commands to execute, using it...
11:46:37 INFO [main/c.f.w.systems.system.SystemCommander] Allowed commands: []
11:46:37 INFO [main/com.fatico.winthing.messaging.Engine] Connecting to tcp://<IP_ADDRESS>:1883 as notebook_antonio...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Connected.
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Subscribing to topics...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/keyboard/commands/press_keys
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/run
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/desktop/commands/set_display_sleep
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/hibernate
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/reboot
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/open
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/shutdown
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/suspend
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/desktop/commands/close_active_window
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Subscribed.
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Sending initial messages...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Engine started.

Thanks a lot, this program will help a great deal.

Amazing @mghaan! It worked!
11:46:37 INFO [main/c.f.w.systems.system.SystemCommander] Found whitelist of allowed commands to execute, using it...
11:46:37 INFO [main/c.f.w.systems.system.SystemCommander] Allowed commands: []
11:46:37 INFO [main/com.fatico.winthing.messaging.Engine] Connecting to tcp://<IP_ADDRESS>:1883 as notebook_antonio...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Connected.
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Subscribing to topics...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/keyboard/commands/press_keys
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/run
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/desktop/commands/set_display_sleep
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/hibernate
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/reboot
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/open
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/shutdown
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/system/commands/suspend
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine]   - notebook_antonio/desktop/commands/close_active_window
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Subscribed.
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Sending initial messages...
11:46:38 INFO [main/com.fatico.winthing.messaging.Engine] Engine started.

Thanks a lot, this program will help a great deal.

Just out of curiosity, it says:
Allowed commands: []
Did you just hide the commands before you posted or is it exact copy/paste? It should look something like this:
Allowed commands: [notepad, winword, wordpad, kodi]
You don't have to create winthing.ini. In that case it will allow to execute whatever you post in system/commands/run topic.

Original app didn't have a tray icon. Btw, I sure can add it as a statup parameter so no tray icon is created.

Hello sir!

Did you just hide the commands before you posted or is it exact copy/paste?

Since not having this file would allow any command to be run (as I understand), I've created a blank file, for this moment, to not allow any command to be run.

Original app didn't have a tray icon. Btw, I sure can add it as a statup parameter so no tray icon is created.

That would be awesome!
I am now testing how this app behaves with system restarts and start-up routines. One of my machines did not started the app like the others. I've copied the entire winthing folder to the hidden program data folder and created a shortcut to the system start up folder (RUN + shell:common startup). I had to log on the user to the app start up and connect to the broker.
Thanks!

Thanks for explanation, with empty file yes, it shouldn't allow any commands to run.
This is not a Windows service, user must be logged in - but user's automatic startup folder should work just like for any other app.
One note, winthing won't reconnect to the broker after wakeup from PC sleep/hibernate. I will look into this issue to make it work.

Thanks for explanation, with empty file yes, it shouldn't allow any commands to run.

No worries!

This is not a Windows service, user must be logged in - but user's automatic startup folder should work just like for any other app.

Yes, I need to find a workaround this. That would also be a great improvement for this project: install it and set as a system-wide auto-start as service on boot.

One note, winthing won't reconnect to the broker after wakeup from PC sleep/hibernate. I will look into this issue to make it work.

That is odd... I can assure that they can reconnect after sleep/hibernate since I've just done that with three different pcs and they connected without any input.
Thanks a lot for your great work here sir!


Opening terminal with 'ctrl+~' crashes VSCode

VSCode Version: 1.31.0 (occurs in 1.32.0 insiders too)
OS Version: Windows 10 x64

Steps to Reproduce:

Open VSCode (doesn't matter if any file or tab is open or not);
Quickly press 'ctrl+`' (open and then close terminal). Second press must occur before terminal opened (easier to reproduce on slow machines). VSCode crashes with this error:

`Microsoft Visual C++ Runtime Library
Assertion failed!
Program: ...es.asar.unpacked\node-pty\build\Release\winpty.d11
File: d:\a\1\s\node_modules\node-pty\deps\winpty...\winpty.cc
Line: 924
Expression: ASSERT_CONDITION("wp != nullptr && cols > 0 && rows > 0")
For information on how your program can cause an assertion failure, see the Visual C++ documentation on asserts
(Press Retry to debug the application -JIT must be enabled)`
After pressing any button it asks to reopen VSCode.
Occurs on latest insiders version without extensions.

I had the same problem. Fixed it by add this to my settings file
{
"terminal.integrated.windowsEnableConpty": false
}

@imorrish that setting should only do anything on Windows Insiders right now and the default true is to turn on conpty and not use winpty, it's winpty that's causing the error.

This is likely related to winpty, tracking in https://github.com/Microsoft/vscode/issues/45693

I had the same problem. Fixed it by add this to my settings file
{
"terminal.integrated.windowsEnableConpty": false
}

This fixed the issue, the terminal crashing issue was with Conpty

@puneet97 make sure you update to the 64-bit build if you're on 32-bit as well, there have been a few reports about that.


Add RMIZ workaround

This is the fix mentioned in https://github.com/rpearce/react-medium-image-zoom/issues/347 applied to your example.

While this works for gatsby develop, it's looking like this doesn't work after gatsby build because the onLoad isn't getting fired :(
I'll keep trying in the next couple of nights.

Got it! Check out my changes here. Basically, give<EMAIL_ADDRESS>a try, and let me know how it goes here: https://github.com/rpearce/react-medium-image-zoom/issues/347

Hello @rpearce, thanks for your effort (so quickly)! Going to test it out to give you a feedback!


Migrate to typescript and executable scripts

Migration to executables and Typescript
The build script now uses typescript (behind the scenes), since it allows for more customization and functionality of the script, such as loaders, automatic dependency downloading (files in wff-build-tools), and device selection. This is compiled as javascript and packaged as executables (e.g. .exe for windows) to include all node dependencies.
Notes
For building and publishing, follow the steps in the README.
Download

For the record, @Turtlepaw and I discussed this PR. I was uneasy about merging it due to my unfamiliarity with the language and tools used in the PR, and I felt that I shouldn't publish a repo that I couldn't understand. Moreover, the change of language from Windows batch script to compiled Typescript seemed like a significant change worthy of its own branch, if not its own repo.
Turtlepaw's clockwork fork (from which this PR originated) is more powerful, flexible and extensible than wff-build-script. It will probably supersede wff-build-script soon. I will modify wff-build-script's README to recommend the use of clockwork instead of this repo.


Matching a keyword

Hey, great library!
Sorry if I'm being a bit dumb, but I'm struggling with how I would match a keyword without it being part of another word. Essentially, what I'm trying to achieve is they way the var keyword is highlighted below:
var my_var;var anothervar; var yet1varmore;

I want it to match the word exactly, but taking into consideration what came before it (i.e. anything that isn't an alphanumeric or _ character).
So far I've got:
"key": /^(var|true|false)\b/

but that highlights the matches, no matter where they are.

I think what you should do is create a proxy object of a regex. from there, when you call the test or match function, you can add traps to decide based on context if the token is a variable or a keyword.
const patterns: [{
    pattern: new Proxy(/^[$_a-zA-Z][$_a-zA-Z0-9]*\b/, {
        get(target: any[], prop: string, receiver: any) {
            if (prop in RegExp.prototype)
                if (prop === "test")
                    return function (param: string): boolean {
                        // do logic here
                    }
                else
                    return Reflect.get(target, prop, receiver); // do the expected behaviour
            else
                return null; // the requested parameter doesn't exit
        }
    });
}];

it's not elegant but it'll work...


PublishAsync fails with ObjectDisposedException on 'AsyncLockWaiter'

Verification
Describe the bug
Running an application with an MQTT client connected to a VerneMQ broker running as a docker container on a different host.
The client is publishing successfully at a rate of 92 msg/s.
When the vernemq container is paused to simulate a communication failure, each PublishAsync operation times out due to the corresponding CancellationToken (created with the designated timeout time).
client.DisconnectedAsync handler is never called also after waiting for KeepAlivePeriod to be elapsed.
After the vernemq container is resumed, some PublishAsync that may be still pending completed with the following exception:
MQTTTransportDataSource...Publish(messageid:bd169c58-e910-4c63-bdec-8e7743f2f9e0)..Communication error with the broker: Cannot access a disposed object.
      Object name: 'AsyncLockWaiter'.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'AsyncLockWaiter'.
   at MQTTnet.Adapter.MqttChannelAdapter.SendPacketAsync(MqttPacket packet, CancellationToken cancellationToken)
   at MQTTnet.Client.MqttClient.PublishAtMostOnce(MqttPublishPacket publishPacket, CancellationToken cancellationToken)

and then, finally DisconnectedAsync handler is triggered:
warn: Opc.Ua.PubSub.MQTTDataSource[0]
      Mqtt client disconnected: NormalDisconnection

Which component is your bug related to?

Client

To Reproduce
Steps to reproduce the behavior:

Using this version of MQTTnet '<IP_ADDRESS>1'.
See description of the bug.
See error.

Expected behavior
I expect all the PublishAsync tasks to complete with exeption or to be cancelled and client.DisconnectedAsync to be invoked after MqttClientOptions.Timeout or given CancellationToken.

you can transfer timeout CancellationToken for PublishAsync。


Editorial: use pretty quotes (“”) instead of straight ones ("")

Maybe it’s just me, but I really like so-called “smart” quotes over "straight" ones.
I can whip up a PR for it!

Unfortunately, this is the ABSOLUTE WRONG DECISION TITUS.

Richard, author of this excellent module, named “smart-to-dumb-quotes”.

:D

But, for real: I don't think that using smart-quotes is a good move. Mainly because I think it puts onus on the contributors to find out how to use them. I don't naturally have them set up. I also think they can be finicky with the wrong quotes being chosen, and I don't think they add anything.

Oh yeah I get that. Okay that’s fine!


feat: add transaction delta action

This PR adds the option to create transactions when adding data to the table.
The AddOptions is extended with a new Transaction property.
var appId = "4366b1f6-8029-4368-8907-ea7a615e2a79";
var version = 1;
var lastUpdated =<PHONE_NUMBER>324;  // optional

 var table = new DeltaTable.Builder()
            .WithFileSystem(fs)
            .WithSchema(schema)
            .EnsureCreated()
            .Add(data, options => { options.Transaction = new(appId, version, lastUpdated); })
            .Build();

This PR adds the option to create transactions when adding data to the data table.
The AddOptions is extended with a new Transaction property.
 var table = new DeltaTable.Builder()
            .WithFileSystem(fs)
            .WithSchema(schema)
            .EnsureCreated()
            .Add(data, options => { options.Transaction = new(expected.AppId, expected.Version, expected.LastUpdated); })
            .Build();

We might want to change this later. But merging now since we need it


satchel doesnt keep items when taken out of trinket slot.

i keep taking it out and losing mending books and stuff, but its random for some reason? some times it doesnt do that.

oh btw, it does open with forgotten graves, its just that if i die the satchel or pouch disappears with all the items

I also experienced the same behavior with the upgraded satchel. Some items placed into the satchel or removed were not reflected in the tooltip preview even though they were present in the actual satchel, but removing and re-adding the satchel made items disappear (or duplicate) to reflect the tooltip preview.


Azure RG name regex doesn't allow underscores

What kind of request is this (question/bug/enhancement/feature request):
bug
Details:
The Azure resource name regex doesn't allow underscores in the name. A customer is getting the following error:
Operationalinsights.WorkspacesClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=workspaceName constraint=Pattern value="rg_redactedname-EUS" details: value doesn't match pattern ^[A-Za-z0-9][A-Za-z0-9-]+[A-Za-z0-9]$

In order to not change their naming conventions internally, they would like for this regex to allow for underscores in the RG names.

@bentastic27 This error looks like it's coming from the azure client, have you checked if they have open issues about this? Also does azure support this in general?

https://github.com/rancher/kontainer-engine/blob/b43cc6eaa9f4bb4b88f31b4f764f8fdc588dac7f/drivers/aks/aks_driver.go#L1016
Rancher generates the workspace name based off of the resource group name but doesn't ensure the generated name conforms with the constraints set by Azure:

Workspace name: The name to use for the Azure Machine Learning workspace that will be created. The workspace name must be between 3 and 33 characters. It may only contain alphanumeric characters and '-'.

Source

Workaround: Disable Azure Analytics for the cluster by setting the monitoring cluster option to disabled.

This issue appears to apply to cluster provisioning in general as well even when using an existing resource group name that contains an underscore.
Containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="The value of parameter dnsPrefix is invalid. Error details: DNS prefix 'c-92f2-**vn_SDA**-860170-master' is invalid. DNS prefix contains only letters, numbers, and hyphens. It must start and end with alphanumeric values. Please see https://aka.ms/aks-naming-rules for more details.. Please see https://aka.ms/aks-naming-rules for more details." Target="dnsPrefix"
Can logic be added to transform the underscores to hyphens where required/used as variable in the template?


Fix issue on international transactions

For German users on this case, they will have only these options:

billingLine1
billingLine2
billingPostalCode
billingCity

I think it's fine to do it on the 0.x series


Radio Group Button not updating its value

Discovered this issue with @chakra-ui/react": "1.1.0", the radio group buttons won't update its value upon selection.
This problem does not occur with version 1.0.3 as in your sandbox example.
                  <RadioGroupControl                     name="favoriteColor"                     label="Favorite Color"                   >                     <Radio value="#ff0000">Red</Radio>                     <Radio value="#00ff00">Green</Radio>                     <Radio value="#0000ff">Blue</Radio>                   </RadioGroupControl>

It looks like the issue resolves when I updated my dependencies.

It looks like the issue resolves when I updated my dependencies.


[BEAM-13470] Support JSON Column for Spanner Table Schema

My pipeline failed when I added the newly supported JSON column to a Spanner table.
I'm unsure if it requires more adjustments to the source code, but at this point, my pipeline is not actually reading the value of a JSON column from a Spanner table, or performing a write mutation on a JSON column.  It looks like it still fails because the full table schema has to be read for the purposes of serialization.  For now, I just want to resolve the following exception.
Error message from worker: java.lang.IllegalArgumentException: Unknown spanner type JSON
  org.apache.beam.sdk.io.gcp.spanner.SpannerSchema$Column.parseSpannerType(SpannerSchema.java:179)
  org.apache.beam.sdk.io.gcp.spanner.SpannerSchema$Column.create(SpannerSchema.java:142)
  org.apache.beam.sdk.io.gcp.spanner.SpannerSchema$Builder.addColumn(SpannerSchema.java:74)
  org.apache.beam.sdk.io.gcp.spanner.ReadSpannerSchema.processElement(ReadSpannerSchema.java:63)

I don't normally contribute to this repository, so let me know if there's any other information that I should provide! 🙏

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Looks like this is already being resolved in https://github.com/apache/beam/pull/16530.


LoopRotate: remove redundant phis after ssa-update

This is needed after running the SSAUpdater in loop-rotate, because the updater can insert unnecessary phis in the middle of the original liverange of a value which breaks up the original liverange into smaller ones:
   %1 = def_of_owned_value
   %2 = begin_borrow %1
   ...
   br bb2(%1)
 bb2(%3 : @owned $T): // inserted by SSAUpdater
   ...
   end_borrow %2      // use after end-of-lifetime!
   destroy_value %3

Fixes an ownership error.
Also, remove the replace-arg-with-struct peephole optimization from loop-rotate. It not belong to loop-rotate and does not work with OSSA. This peephole is covered by other optimizations.

@swift-ci test

@swift-ci benchmark


error

Line 129 Error: Process completed with exit code 2.
Repo worked just fine then just poped up this error what do you think it can be?

I'm not psychic enough to know the lines of code by heart.
Pls send me a screenshot of the log.

Refork repository


fix(Explore): "Customize" tab rendering behavior

SUMMARY
The bug was the consequence of different issues.
Issue with getDerivedStateFromProps:
This PR removes the getDerivedStateFromProps introduced by PR #14493 that was causing the Collapse to not re-render when changing viz type as the new props were not propagated down to the render phase. The removal does not seem to affect the functionality for which that PR was made. @villebro your confirmation will be appreciated here.
Issue with the Antdesign Collapse:
This problem seems related to a bug with Antdesign when multiple re-renders happen while the Collapse is opening up, causing the Collapse to render invisible (0 height). By forcing the component to render a Loading component after changing the viz type/datasource, Antdesign is then able to properly re-render the Collapse.
Fixes: #15829
BEFORE
https://user-images.githubusercontent.com/60598000/126671260-2cd0c0ab-30aa-4e8c-8fcc-8c65a7b84c2f.mov
AFTER
https://user-images.githubusercontent.com/60598000/126671313-c8ea5078-1baf-4e89-b961-3281ccb6548c.mp4
TESTING INSTRUCTIONS

Open a chart in Explore
Go to the Customize tab and make sure it opens correctly
Change viz type
Go again to the Customize tab and make sure it opens correctly

ADDITIONAL INFORMATION

[x] Has associated issue: #15829
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@rosemarie-chiu @jinghua-qa

/testenv up

@geido I'm not sure if this is related to this fix, but see my video
Steps:

Select pie chart
Go to customize tab and collapse charts option
Go back to data tab and select bar chart
Go to customize tab and observe that the charts option is collapsed
On the first click of expand, nothing happened
Click collapse and expand again then finally options are showing

I think the first click need to be fixed?
https://user-images.githubusercontent.com/52086618/126680120-e053c527-c926-4001-b96f-3e68635078b6.mp4

@rosemarie-chiu thanks for spotting that one. From a first look, it appears to be a problem related to the original one. I will try to fix this issue as well with this PR. I'll ping you once I am done with this additional change.

@junlincc @rosemarie-chiu this should be good to go for another round of testing. I have updated the description as well.

/testenv up


use skaffold build

Command has changed to skaffold build

I don't know what's going on with CI here but we do need this change to build in latest JX.


Logitech G403 (Wireless) mouse wheel LED

I'm using the G403 Wireless mouse. In piper I can configure the Logitech logo LED (bottom) but I have no option to control the mouse wheel LED.

PS: I hope I'm here at the right place, because I think its an issue with the device definition in libratbag and not a front end thing with piper.

Can you confirm this also doesn't work in ratbagctl?

Ok I get 2 LEDs, it doesn't seem to be ratbag then :sweat_smile:
$ ratbagctl 'Logitech USB Receiver' led get
LED: 0, depth: rgb, mode: off
LED: 1, depth: rgb, mode: off

This should be fixed in the latest release, could you check? Make sure you are running linux 5.2.


Update registry.json

Added 777 Royalties Standard to Registry

This probably should be added post  #116 - shouldn't be merged before (or could be added to?)


QEMU 4.2.0 on Windows 10 host --enable-whpx or -enable-whpx both give invalid option

Subject says its all.   I desire to use acceleration. With WHPX or HAX
I tried both - both give invalid option.
Am I doing something wrong - or is the program wrong.
Jerry

The correct parameter is --accel whpx
This worked.


Different stubs are sharing arguments

stub1 = sinon.stub()
stub2 = sinon.stub()
stub1(1, 2, 3)
stub2(4, 5, 6)
print stub2.getCall(0).args # [(1, 2, 3)]
print stub2.args # [(4, 5, 6)]

The call to stub2.getCall(0).args should return (4, 5, 6). Somehow this call is returning the arguments from stub1!

Please reference the comment of current design HERE first.
This issue's root cause is because the design of args_list and _queue are two separated concept. stub2.getCall(0) in current design will get the first call of all Spies/Stubs. I believe that to fix this, we need to redesign some structure behind base. (Maybe move it to spy/wrapper)
I currently might not be able to fix it quickly. Feel free to dig this issue deeply. :)


Two minuses next to currency after applying the discount coupon

Current behavior
Two minuses next to currency after applying the discount coupon (cart & checkout).

Expected behavior
There should by only one minus, eg. -$34.50
Steps to reproduce the issue

Add product to the cart
Apply coupon code (e.g. mmtest)

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Environment details

Browser:
OS:
Code Version:

Additional information

Fixed in Vue Storefront in https://github.com/DivanteLtd/vue-storefront/issues/4353
Now it works as expected:


cohort field - mv_downloads  LESQ-602

Description
Music year: 2018

Updates GQL query and schemas
Adds downloadsFixture2023
updates isDownloadLegacy check

Issue(s)
Fixes #LESQ-602
How to test

Go to https://deploy-preview-2215--oak-web-application.netlify.thenational.academy

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.335.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


batch inserts (and updates)

The Vert.x client does have an API for batching inserts (and updates?) but currently we have commented out the code which handles batching in Hibernate (which was very JDBC-specific).
We should add support for at least batch inserts, since that can make a big difference to performance.

This is now implemented in #312.


Update Helm release shoot-rsyslog-relp to v0.4.3 (main)

This PR contains the following updates:

Package
Update
Change

shoot-rsyslog-relp
patch
0.4.2 -> 0.4.3

Release Notes

gardener-community/gardener-charts (shoot-rsyslog-relp)
v0.4.3
Compare Source
[gardener/gardener-extension-shoot-rsyslog-relp]
🏃 Others

[OPERATOR] If the certificates used for the rsyslog-relp tls connection are changed, the rsyslog service on the nodes is restarted so that it can properly load the new certificates. by @plkokanov [#107]

Docker Images

gardener-extension-shoot-rsyslog-relp-admission: europe-docker.pkg.dev/gardener-project/releases/gardener/extensions/shoot-rsyslog-relp-admission:v0.4.3
gardener-extension-shoot-rsyslog-relp: europe-docker.pkg.dev/gardener-project/releases/gardener/extensions/shoot-rsyslog-relp:v0.4.3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Unsupported class file major version 62 on android export.

Godot version
3.4.4
System information
Manjaro, Vega 8, Ryzen 3200 G
Issue description
I got this error when trying to compile an apk with godot.
Could not compile settings file '/home/cris/Documentos/Git/Godot/Sheriff 22/android/build/settings.gradle'.
startup failed:
General error during conversion: Unsupported class file major version 62
java.lang.IllegalArgumentException: Unsupported class file major version 62
Steps to reproduce
Download Godot from the website.
Install android studio.
Install dependencies.
Follow instructions.
Try to export.
Minimal reproduction project
No response

This occurred for me, it seemed to be to do with the java version installed.
I needed to install Openjdk-17-jdk (19 did not work) and use
sudo update-alternatives --config java

to select 17.
Note it seems to need the development version not the JRE.


Update CHANGELOG.md

I will create the issue later and then merge.

Created https://github.com/kubewarden/kubewarden-controller/issues/30


Add warning for IE11 users

Since some features may suddenly break for IE11, this pull request adds a warning in the about page that recommends users to switch to a modern browser. The warning is only present in the about page and doesn't actually stop the user from using the editor.
Demo available at https://dev.openapi.design/feature/ie11-warning

can you refix the size of the warning popup/panel? Ideally if you make the width equal to width of tabs group  in OpenAPI Designer, it would be of compact size. or perhaps show it at the top right corner, under the tabs. Right now the position and size of the warning is losing the aesthetics of the UI.

@Nazarah I'll try implementing a different position it today after doing some stuff to openapi/space.

@Nazarah It's a bit less intrusive now, but i'm going to fix the alignment tomorrow. You can see the newer version at dev.openapi.design/feature/ie11-warning. It also made me think, would it be a good idea to use a popup notify for this? Then it would clearly inform the user that they are using a browser that may have problems but user could then dismiss it.

@xylix I'd suggest not to use POPUP as I read an article that it actually brings bad UX in this.
What I suggest in the current solution is to add a X (or close button), so that after reading this, people can always discard the message.
Also may be make the description text 14 px (similar to the About tab description text size). I opened it from my laptop and its too small to read now.

I added support for dismissing the warning and also made it a bit bigger.
Here's what it's supposed to look like:

Someone should probably make sure it actually looks like that on IE.

Looks good to me, at least on a big enough screen.

Looks good enough to me. Good works guys.


Changing config for auto-targeting doesn't have an effect.

No matter what the value of the 'ion-cannon-min-cannons-ready' variable, only the first two cannons ever fire on auto. Given more than 2 cannons, none of the remaining cannons get used for autofire.

Problem seems to be that the value in settings["ion-cannon-min-cannons-ready"] never gets updated with new values from mod-settings.json. Not sure if this is a problem on your (mod) end or Factorio's API

Could not replicate using Factorio v0.17.9.


PCB Schematic

Hi @gobbyo,
Thank you for this repository, excellent work. Additionally, could you please include the schematic of this circuit? Also, if you could elaborate a bit more on the details, it would be helpful.
Thanks & regards,
Hiru

Isn't this what you are looking for? https://github.com/gobbyo/clock/wiki/circuitassembly

Hi @ThEWiZ76,
Yes, I asked for this. Thanks


Theming POC and Color Palette 2.0

16 Oct - Button set almost done, share with teams to review.

Mock up completed using the Figma theming poc

Mostly done, had a meeting with stakeholders with a meeting to be arranged to discuss top 5 goals for a new theme. Waiting from feedback from stakeholders

17 Nov - Same update from #2610. @joshwooding working on color 2.0 on a next branch.

20 Nov - Splitting out GitHub tickets, https://github.com/jpmorganchase/salt-ds/issues/2747, https://github.com/jpmorganchase/salt-ds/issues/2748, https://github.com/jpmorganchase/salt-ds/issues/2749, https://github.com/jpmorganchase/salt-ds/issues/2750


HotJar Analytics/Metrics: Heatmap

As we discussed in our weekly meeting, we decided to split up the implementation of the Heatmap from the other engagement metrics we wanted to implement.

Once the script is added to staging and the main app. We will be able to pin the pages we want like the home page and rooms to see a recorded heat map on hotjar


[Build] Execution failed for task ':app:processDebugMainManifest'.

Build issue(s)

...
Platform
other
Anything else?
Hi,
I want to build Chip-tool apk but unfortunately I didnt get it.
2024-10-11 00:59:32 INFO    Building APP android-arm64-chip-tool
2024-10-11 00:59:34 INFO    > Task :app:preBuild UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:preDebugBuild UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:preBuild UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:preDebugBuild UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:compileDebugAidl NO-SOURCE
2024-10-11 00:59:34 INFO    > Task :app:compileDebugAidl NO-SOURCE
2024-10-11 00:59:34 INFO    > Task :chip-library:packageDebugRenderscript NO-SOURCE
2024-10-11 00:59:34 INFO    > Task :app:compileDebugRenderscript NO-SOURCE
2024-10-11 00:59:34 INFO    > Task :app:dataBindingMergeDependencyArtifactsDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:dataBindingMergeGenClassesDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:generateDebugResValues UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:generateDebugResources UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:compileDebugRenderscript NO-SOURCE
2024-10-11 00:59:34 INFO    > Task :chip-library:generateDebugResValues UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:generateDebugResources UP-TO-DATE
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    > Task :chip-library:packageDebugResources
2024-10-11 00:59:34 INFO    Execution optimizations have been disabled for task ':chip-library:packageDebugResources' to ensure correctness due to the following reasons:
2024-10-11 00:59:34 INFO      - Gradle detected a problem with the following location: '/home/gercek/Matter/connectedhomeip/out/android-arm64-chip-tool/generated/res/resValues/debug'. Reason: Task ':chip-library:packageDebugResources' uses this output of task ':app:generateDebugResValues' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
2024-10-11 00:59:34 INFO      - Gradle detected a problem with the following location: '/home/gercek/Matter/connectedhomeip/out/android-arm64-chip-tool/generated/res/rs/debug'. Reason: Task ':chip-library:packageDebugResources' uses this output of task ':app:compileDebugRenderscript' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    > Task :app:mergeDebugResources UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:dataBindingGenBaseClassesDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:generateDebugBuildConfig
2024-10-11 00:59:34 INFO    > Task :chip-library:writeDebugAarMetadata UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:checkDebugAarMetadata UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:extractDeepLinksDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:extractDeepLinksDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:processDebugManifest
2024-10-11 00:59:34 INFO    > Task :chip-library:compileDebugLibraryResources UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:parseDebugLocalResources UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :chip-library:generateDebugBuildConfig
2024-10-11 00:59:34 INFO    > Task :chip-library:javaPreCompileDebug UP-TO-DATE
2024-10-11 00:59:34 INFO    > Task :app:javaPreCompileDebug
2024-10-11 00:59:34 INFO    > Task :app:processDebugMainManifest FAILED
2024-10-11 00:59:34 WARNING
2024-10-11 00:59:34 WARNING FAILURE: Build failed with an exception.
2024-10-11 00:59:34 WARNING
2024-10-11 00:59:34 WARNING * What went wrong:
2024-10-11 00:59:34 WARNING Execution failed for task ':app:processDebugMainManifest'.
2024-10-11 00:59:34 WARNING > com.android.manifmerger.ManifestMerger2$MergeFailureException: java.io.FileNotFoundException: /home/gercek/Matter/connectedhomeip/out/android-arm64-chip-tool/intermediates/merged_manifest/debug/AndroidManifest.xml (No such file or directory)
2024-10-11 00:59:34 WARNING
2024-10-11 00:59:34 WARNING * Try:
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    See https://docs.gradle.org/7.1.1/userguide/command_line_interface.html#sec:command_line_warnings
2024-10-11 00:59:34 INFO
2024-10-11 00:59:34 INFO    Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
2024-10-11 00:59:34 INFO    Please consult deprecation warnings for more details.
2024-10-11 00:59:34 INFO    20 actionable tasks: 6 executed, 14 up-to-date
2024-10-11 00:59:34 WARNING Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
2024-10-11 00:59:34 WARNING
2024-10-11 00:59:34 WARNING * Get more help at https://help.gradle.org
2024-10-11 00:59:34 WARNING
2024-10-11 00:59:34 WARNING BUILD FAILED in 2s
Traceback (most recent call last):
File "/home/gercek/Matter/connectedhomeip/./scripts/build/build_examples.py", line 241, in
main(auto_envvar_prefix='CHIP')
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
rv.append(sub_ctx.command.invoke(sub_ctx))
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/gercek/Matter/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "/home/gercek/Matter/connectedhomeip/./scripts/build/build_examples.py", line 231, in cmd_build
context.obj.Build()
File "/home/gercek/Matter/connectedhomeip/scripts/build/build/init.py", line 73, in Build
builder.build()
File "/home/gercek/Matter/connectedhomeip/scripts/build/builders/builder.py", line 107, in build
self._build()
File "/home/gercek/Matter/connectedhomeip/scripts/build/builders/android.py", line 482, in _build
self.gradlewBuildSrcAndroid()
File "/home/gercek/Matter/connectedhomeip/scripts/build/builders/android.py", line 291, in gradlewBuildSrcAndroid
self._Execute(
File "/home/gercek/Matter/connectedhomeip/scripts/build/builders/builder.py", line 112, in _Execute
self._runner.Run(cmdarray, title=title)
File "/home/gercek/Matter/connectedhomeip/scripts/build/runner/shell.py", line 73, in Run
raise Exception('Command %r failed: %d' % (cmd, code))
Exception: Command ['/home/gercek/Matter/connectedhomeip/examples/android/CHIPTool/gradlew', '-p', '/home/gercek/Matter/connectedhomeip/examples/android/CHIPTool', '-PmatterBuildSrcDir=/home/gercek/Matter/connectedhomeip/out/android-arm64-chip-tool', '-PmatterSdkSourceBuild=true', '-PbuildDir=/home/gercek/Matter/connectedhomeip/out/android-arm64-chip-tool', 'assembleDebug'] failed: 1
Why looking for AndroidManifest in debug folder and Why does not exist?
Is there any one solve this issue?

A new one ...
My current kotlin version is Kotlin version 1.9.0-release-358 (JRE 17.0.12+7-Ubuntu-1ubuntu222.04)
2024-10-11 02:57:39 WARNING e: file:///home/gercek/Matter/connectedhomeip/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/util/TlvUtil.kt:52:24 Class 'matter.tlv.Tag' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.0.0, expected version is 1.8.0.
2024-10-11 02:57:39 WARNING The class is loaded from /home/gercek/.gradle/caches/transforms-3/7ea3a36eaa4bab10a8fcd158662fa9a4/transformed/jetified-libMatterTlv.jar!/matter/tlv/Tag.class
2024-10-11 02:57:39 WARNING
2024-10-11 02:57:39 WARNING FAILURE: Build failed with an exception.
2024-10-11 02:57:39 WARNING
2024-10-11 02:57:39 WARNING * What went wrong:
2024-10-11 02:57:39 WARNING Execution failed for task ':app:compileDebugKotlin'.
2024-10-11 02:57:39 WARNING > A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
2024-10-11 02:57:39 WARNING    > Compilation error. See log for more details
2024-10-11 02:57:39 WARNING
2024-10-11 02:57:39 WARNING * Try:
2024-10-11 02:57:39 WARNING Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
2024-10-11 02:57:39 WARNING
2024-10-11 02:57:39 WARNING * Get more help at https://help.gradle.org
2024-10-11 02:57:39 WARNING
2024-10-11 02:57:39 WARNING BUILD FAILED in 16s

@gercekcetinkaya
Try changing the Gradle or AGP version set in your Android project.
It seems that the existing version 7.1.1 is not compatible, causing the issue.
In my case, I configured it this way and successfully built the project.


Navi planning

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):18.04
Apollo installed from (source or binary):source
Apollo version (3.5, 5.0, 5.5, 6.0):5.5

I try the navi mode following the "https://github.com/ApolloAuto/apollo/blob/master/docs/technical_tutorial/navigation_mode_tutorial_cn.md". I get the all channels ready except the planning.
cyber_monitor picture

problems of planning

It looks like your vehicle is positioned at [x=0, y=0]. It's out of range of map.

It looks like your vehicle is positioned at [x=0, y=0]. It's out of range of map.

How can I solve this problem？Thank you

In this case, apollo always turns the steering wheel 90 degrees to the right. How can I solve it? Please help me!

In this case, apollo always turns the steering wheel 90 degrees to the right. How can I solve it? Please help me!

@ydhongHIT It seems you have had success with navigation mode on the newer version of apollo over 3.0. Could you please tell me how you are able to collect route (as rosbag), smooth line data (without the python tools that don't work), and send it to dreamview. Can you please provide me with brief instructions on how you can do this? I'm using 5.0. Also, do you know if perception module needs gps and imu data to function? I have camera feed (from 12mm and 6mm) but the perception module won't turn on. Any instructions, input, or help would be greatly appreciated. How is your progress on this? Thank you


[reactive-element] Fix Node build auto-shimming of HTMLElement to respect existing global shim

Fixes #3559
The replace of extends HTMLElement with extends (globalThis.HTMLElement ?? HTMLElement) was not happening due to the includes option for @rollup/plugin-replace not working properly. Updating the version fixes this.
Note: To keep a single version of the plugin in the monorepo, the version was also updated for the starter kits.
Now the outputs look like:
Dev Node build:
class ReactiveElement
 extends (globalThis.HTMLElement ?? HTMLElement) {

Prod Node build:
class v extends(globalThis.HTMLElement??i)

I added another test in the vein of the node-import tests. It feels like there are a lot of scripts for the node tests now but unsure if there's a better way to do this.

Filed https://github.com/lit/lit/issues/3562 for better handling of the node tests.


Ember 2.10.0 introduces "Cannot call Ember.get with an empty string"

Environment

Ember Version: 2.13.0
Ember CLI Version: 2.10
Ember CP Validations Version: 2.9.7

Steps to Reproduce
model:
import Ember from 'ember';
import DS from 'ember-data';
import { validator, buildValidations } from 'ember-cp-validations';

const { get } = Ember;
const { Model, attr } = DS;

const Validations = buildValidations({
  reason: validator('number', {
    integer: true,
    gt: 0,
    lt: 7
  }),
  other: validator('presence', {
    presence: true,
    ignoreBlank: true,
    disabled(model) {
      return get(model, 'reason') !== OTHER;
    },
    dependentKeys: ['reason']
  })
});

export default Model.extend(Validations, {
  reason: attr('number'),
  other: attr('string')
});

To reproduce, just run any test against the model, e.g.
import Ember from 'ember';
import { moduleForModel, test } from 'ember-qunit';
const { get } = Ember;

moduleForModel('foo', 'Unit | Model | foo', {
  // Specify the other units that are required for this test.
  needs: ['validator:number', 'validator:presence']
});

test('It considers a whitespace "other" reason invalid', function(assert) {
  let model = this.subject({ reason: 4, other: ' ' });
  assert.ok(get(model, 'validations.isInvalid'), 'it should be invalid');
});

Ember 2.10 introduced an assertion against using Ember.get with the empty string as a key. In my tests I'm seeing this change cause test failures due to failed assertions stemming from here (attribute === 'reason'):
https://github.com/offirgolan/ember-cp-validations/blob/91b8e922e74de2393d15477a9cae67cce060f1e6/addon/validations/factory.js#L306
https://github.com/emberjs/ember.js/issues/14572

Fixed by updating to ember-cp-validations 2.9.8 (my bad, didn't see that was available)


[BUG] > and < are not filtered from Sametime subjects

HCL Product Version
12.0
Describe the bug
If my meeting subject includes either a < or > character (e.g. "Chocolate > Vanilla") then I get an error trying to schedule a Sametime meeting.
Error Message
Problem creating meeting (HTTP/1.1 403 Forbidden) [E: 1403; L: 115]
To Reproduce
Steps to reproduce the behavior:

Create a new meeting and give it the subject "Chocolate > Vanilla"
Click on Schedule Online Meeting / Sametime
See error

Expected behavior
I would expect any unsupported characters for a Sametime meeting to be filtered out by cleanupSTMeetingName().  The current list of filtered characters is incomplete.
Screenshots
N/A
Desktop (please complete the following information):

OS: Win10 Enterprise

Additional context
The enhanced logging output for the failed request is:
2021/07/13 14:14:59 Library: NotesRESTconsumer.Class: NotesRESTconsumer.PROCESSREQUEST():
Response Code: HTTP/1.1 403 Forbidden
2021/07/13 14:14:59 Error #4842: Unable to Parse JSON string:
Invalid value. offset 0
Library: NotesRESTconsumer.Class: NotesRESTconsumer.PROCESSREQUEST();  line #371
POST https://stpoc.cwp.pnp-hcl.com/meeting-catalog/api/v1/meetings
HTTP/1.1 403 Forbidden
Stack Logging is Disabled
URL: https://stpoc.cwp.pnp-hcl.com/meeting-catalog/api/v1/meetings
Method: POST
response: Forbidden
strippedResponse: Forbidden
responseCode: HTTP/1.1 403 Forbidden
Headers JSON
{
"accept":"application/json",
"X-CSRF-Token":"",
"cookie":"_csrf=; sametimeJwt=**********; Max-Age=7200; Domain=*****; Path=/; Expires=Tue, 13 Jul 2021 23:14:58 GMT; HttpOnly; Secure; SameSite=None",
"Content-Type":"application/json"
}
Body JSON
{
"meeting":{
"name":"Chocolate_>_Vanilla_BKAN-C4VSWT",
"moderators":[
<EMAIL_ADDRESS>],
"allowGuestUser":false,
"mode":"Open"
}
}
In the JSON body we can see the subject has been HTML encoded, twice.  The > was converted to its HTML equivalent of > and then the ampersand was also encoded so the final sequence contains >
Since ampersands are not allowed by the Sametime REST API this causes the request to be rejected.
The list of characters filtered by cleanupSTMeetingName() looks to be the one the Sametime web UI shows.  It does not take into account that some characters, when encoded, will result in unsupported characters being used.
The fix is simply to add these 2 lines:
' Adding  < > to avoid HTML encoding of them before sending
badList("<") = "_"
badList(">") = "_"

into cleanupSTMeetingName() before the For loop that does the cleanup work.

Resolved by pull request #88


fixing ANR on large files

see https://stackoverflow.com/q/57067507/192373

use StringBuilder to accumulate the output text
convert it to String inside doInBackground, not on Main thread

Actually, I don't think it's always necessary to aggregate all intermediate output lines into one huge output string. In the case the output is short, and especially if onProgress() is empty, it may be OK. But for big files, this puts too much stress on the Garbage Collector, and the info is available anyways, timely: in the overridden ExecuteBinaryResponseHandler.onProgress() callback.


@bugsnag/plugin-vue not working in ssr

Hi,
I moved to the new Plugin init function as in the upgrade guide, but I noticed it doesn't work with SSR Apps.
There is a reference to the window on this line and another one a little further down.
As for now I can just use the old method but would be cool to fix this bug!
Thanks for the great Plugin :)

Hey @JulianMar, thanks for letting us know about this. At the time of the server side render window is not available, and would throw an error like (as I believe you're seeing):
ReferenceError: window is not defined

We'll take a look into a fix!

A fix for this was released in v7.2.1


no error if password not provided but is required

Nothing comes up if we don't provide a password while the server demands it.
'use strict'

var co = require('co')
var Redis = require('ioredis')
Redis.Promise.onPossiblyUnhandledRejection(function(error) {
  console.log('unh error:', error)
})

// this one raises authError
co(function*() {
  var r = new Redis({
    port: 6379,
    host: '<IP_ADDRESS>',
    password: 'foo',
    autoResendUnfulfilledCommands: false
  })

  r.on('ready', () => console.log('ready'))
  r.on('error', (error) => console.log('error:', error))
  r.on('authError', (error) => console.log('authError:', error))
})

// this one doesn't
co(function*() {
  var r = new Redis({
    port: 6379,
    host: '<IP_ADDRESS>',
    password: '',
    autoResendUnfulfilledCommands: false
  })

  r.on('ready', () => console.log('ready'))
  r.on('error', (error) => console.log('error:', error))
  r.on('authError', (error) => console.log('authError:', error))
})

node v 5.6.0, OS X 10.11, ioredis 1.12.2
Am I doing something wrong?

authError event is only emitted when the password provided is wrong. If the password is empty, ioredis won't send the AUTH command to the Redis, so that there's no chance can ioredis know the password is wrong.
However, if you send any command manually, you'll get the NOAUTH error returned by Redis server.

Thanks for responding so quickly, @luin :)
This works, yes. I'll try sending some info request if available, right after connecting to check up on that.
But why aren't you emitting a new error upon this? Or an authError? Since you emit it if the password is wrong, you should emit it when there's no password, but it's required.
Regards!

@mkozjak That makes sense. I added it to the 2.x list. Thank you for pointing this out!

Thanks!

Closing this issue in favour of #246.


Add docs site

Description

Resolves #101

Refer to the checklist in #101.
I wasn't able to programmatically add the vscode settings files from the docs repo to the codespace JSON file, so I'll probably need some help there. The not so great alternative is to copy and paste.

I changed the dev container to use docker compose instead of just a docker file. This allows it to run multiple containers. My plan is for each website (or other app that is purely for development purposes) to be in its own container (isolated environment). Will be talking more about this in the sailbot workspace overview meeting tonight.

One downside of the current implementation is that the repositories need to be cloned before the dev container can be built. Still thinking of the best way to automate this, but will probably not do so in this PR.
pip install vcs-tool
vcs import < src/new_project.repos src

VS Code settings should be resolved now

cspell: uses existing file
extensions.json: manually added them to devcontainer.json
launch.json: not needed anymore
settings.json: manually added to sailbot_workspace.code-workspace


Downloading SAVANA 1.0.0 and not the newest version with conda

Hi :)
When i run:
conda install -c bioconda savana
I get the 1.0.0 version of SAVANA, and thus can't use many of the arguments.
Do you have a way of fixing this other than downloading from source (which is a bit difficult on our cluster).
Best
Jesper

Hi there! Are you able to specify the version by running conda install -c bioconda savana=1.2.5? From running conda search savana on my cluster, I'm able to see all versions on the bioconda channel, so later than 1.0 should be available to install.
> conda search savana
Loading channels: done
# Name                       Version           Build  Channel
savana                         0.2.1    pyhdfd78af_0  bioconda
savana                         0.2.3    pyhdfd78af_0  bioconda
savana                         1.0.0    pyhdfd78af_0  bioconda
savana                         1.0.3    pyhdfd78af_0  bioconda
savana                         1.0.4    pyhdfd78af_0  bioconda
savana                         1.0.5    pyhdfd78af_0  bioconda
savana                         1.2.0    pyhdfd78af_0  bioconda
savana                         1.2.0    pyhdfd78af_1  bioconda
savana                         1.2.1    pyhdfd78af_0  bioconda
savana                         1.2.2    pyhdfd78af_0  bioconda
savana                         1.2.3    pyhdfd78af_0  bioconda
savana                         1.2.4    pyhdfd78af_0  bioconda
savana                         1.2.5    pyhdfd78af_0  bioconda

I will close this but feel free to re-open if you still have issues installing the latest version of SAVANA


Sort by association with postgres not working

I have followed the belongs_to/has_many/sortable_fields instruction as in the readme, but I still get PG::UndefinedColumn: ERROR:  column users.location.name does not exist.  Is this not supported in postgres, or am I doing something wrong?

@arcreative which version of JR are you using? Sorting on relationship fields is only enabled in > 0.7.0.

Thanks, I'm using 0.7.0

And if you need more information, let me know!

Maybe misunderstood that--do you mean > 0.7.0 or >= 0.7.0?

0.7.0, realized I was looking at the documentation for master, thanks for clearing that up :-)


#4 Build homepage for app

Description
A registered/unregistered user should be able to land on a homepage
New dependencies

materialize-css

This PR fixes #4
Screenshots

How should this be manually tested?

Get this branch to local with git fetch upstream
Run git checkout upstream/homepage-responsive on your terminal
Install dependencies npm install
Run the app npm start

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added necessary inline code documentation
[x] New and existing unit tests pass locally with my changes

Extra notes

We'll need to discuss the exact text and links to add to the page on slack or any other workgroup channel

looking good
but i believe the page should have more items for sale

It is not the landing page. It is the home page.
A modification may be to add a link to the markets page
What do you think?


/github/home/.gitconfig: Permission denied

Describe the bug
giving following error
/github/home/.gitconfig: Permission denied
To Reproduce
With the version v2.0 any Terragrunt command will give the error
Run gruntwork-io/terragrunt-action@v2
/usr/local/bin/docker run --name ed5a447e040ba0420f4672a13e1571e88a6ec2_85fc57 --label ed5a44 --workdir /github/workspace --rm -e "VAULT_URL" -e "VAULT_NAMESPACE" -e "TERRAFORM_VERSION" -e "TERRAGRUNT_VERSION" -e "AWS_ACCOUNT" -e "ENVIRONMENT" -e "AWS_ASSUME_ROLE" -e "AWS_REGION" -e "GITHUB_TOKEN" -e "GITHUB_USERNAME" -e "AWS_DEFAULT_REGION" -e "AWS_ACCESS_KEY_ID" -e "AWS_SECRET_ACCESS_KEY" -e "AWS_SESSION_TOKEN" -e "TF_VAR_vault_role_id" -e "TF_VAR_vault_secret_id" -e "INPUT_TF_VERSION" -e "INPUT_TG_VERSION" -e "INPUT_TG_DIR" -e "INPUT_TG_COMMAND" -e "INPUT_TG_COMMENT" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_EVENT_PATH" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "GITHUB_ACTION" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/runner/_work/_temp/_github_home":"/github/home" -v "/runner/_work/_temp/_github_workflow":"/github/workflow" -v "/runner/_work/_temp/_runner_file_commands":"/github/file_commands" -v "/runner/_work/dim-apic-k8s-cluster-infra/dim-apic-k8s-cluster-infra":"/github/workspace" ed5a44:7e040ba0420f4672a13e1571e88a6ec2
2023-11-[27](https://github.com/xxxxxxxxx/dim-apic-k8s-cluster-infra/actions/runs/7009370600/job/19067683357#step:20:28) 18:41:20 Starting Terragrunt Action
error: could not lock config file /github/home/.gitconfig: Permission denied
2023-11-27 18:41:20 Finished Terragrunt Action execution

Expected behavior
A clear and concise description of what you expected to happen.
Nice to have
2023-11-27 18:41:20 Starting Terragrunt Action
error: could not lock config file /github/home/.gitconfig: Permission denied
2023-11-27 18:41:20 Finished Terragrunt Action execution
Pipeline steps
- name: Set GitHub Creds
  run: |
    git config --global --add safe.directory /github/workspace
    git config --global url."https://${{ env.GITHUB_USERNAME }}:${{ env.GITHUB_TOKEN<EMAIL_ADDRESS>"https://github.com"
  shell: bash

- name: Terragrunt init
  uses<EMAIL_ADDRESS>  with:
    tf_version: ${{ env.TERRAFORM_VERSION }}
    tg_version: ${{ env.TERRAGRUNT_VERSION }}
    tg_dir: vars/${{ env.ENVIRONMENT }}
    tg_command: 'init'
  env:
    TF_VAR_vault_role_id: ${{ secrets.DIM_VAULT_ROLE_ID }}
    TF_VAR_vault_secret_id: ${{ secrets.DIM_VAULT_SECRET_ID }}
    GITHUB_TOKEN: ${{ env.GITHUB_TOKEN }}

Versions

Terragrunt Action version:  2.0
Environment details (Terragrunt version, Terraform version, etc.):  TF version 1.4.6

Additional context
Add any other context about the problem here.

Hello,
can be shared an example repo where this issue occurs?

Hi,
Unfortunately those repos are private repos and I am unable to share a example repo but when I tried with the version version 1.0.10 it worked

I have this on v2 also, but only when I run on a "larger runner". On standard github hosted runners v2 works fine for me.
I don't know if this is because the runners are behaving differently (possibly one is running the container as root by default?) or because of an artifact on the runner.
Looks like /github/home/.gitconfig is a mount of: /home/runner/work/_temp/_github_home

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

Same issue for me as well on a self hosted runner.

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

Same issue for me as well on a self hosted runner.

Used old version and it worled for me

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

Same issue for me as well on a self hosted runner.

Used old version and it worked for me or you can manually run those terragrunt commands except using the action

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

Same issue for me as well on a self hosted runner.

Used old version and it worked for me or you can manually run those terragrunt commands except using the action

Used old version

Can you please be more specific, what tag/version are you referring to when you say old version

I'm seeing the same problem on self hosted runner.
The volume mount config is the following:
-v "/home/ubuntu/actions-runner/_work/_temp/_github_home":"/github/home"

.gitconfig is to be created in /home/ubuntu/actions-runner/_work/_temp/_github_home.
I've made the ubuntu user to be the owner of the folder /home/ubuntu/actions-runner/_work/_temp additionally I recursively made it 0777 but it didn't help.
Any suggestions how to bypass it on the self hosted runner?

Same issue for me as well on a self hosted runner.

Used old version and it worked for me or you can manually run those terragrunt commands except using the action

Used old version

Can you please be more specific, what tag/version are you referring to when you say old version

I have tried on v1.0.9 and v1.0.8

Add USER root to docker file worked for me.
diff --git a/Dockerfile b/Dockerfile
index 76c2023..7ccc2ce 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,4 +4,6 @@ MAINTAINER Gruntwork<EMAIL_ADDRESS>
 COPY ["./src/main.sh", "/action/main.sh"]

+USER root
+
 ENTRYPOINT ["/action/main.sh"]

Hey folks, thank you for your work.
Why is this closed? The issue still persists and above workaround is not a solution

I got it fixed somehow. Need to find what I did

I got it fixed but forgot to publish the solution here. In my case it was about the fact that runner agent is being executed under ubuntu while inside container the user is root.
Every execution was re-setting the permissions for the .git* files and folders
I had the following command insider the workflow:
 - name: Job_name
    run: |
        docker run --rm -t -v ./:/app -w /app \
          .... \
          -u 1000 \
          docker_image:image_tag command

The fix was about adding -u 1000. The uid corresponds with the Linux userid that starts github runner process.
Additionally I've added the workspace cleanup stage:
  cleanup:
    runs-on: [runner_lable]
    needs: [Job_name]
    steps:
    - name: cleanup
      run: |
        sudo rm -rf ${{ github.workspace }}/*


Add link to Portuguese from Portugal

Portuguese from Brazil and Portuguese from Portugal are a bit different.  Actually, the Portuguese translation just points to Portuguese from Brazil translation, but Portuguese from Portugal translation is already available at translations folder.

Thank you for fixing this @OtacilioN 🖖 🎉 .
I understand that you're really thorough when you look through a project.


Feature request: Cell level VIM edit mode

With the current vim extension, one can append/delete/edit the cells as a whole, but when it goes into a cell, it is just normal edit mode. When you hit esc key, it will leave the cell and you can't edit the cell unless you hit the Enter key.
It used to have plugin in Jupyter (not in VSCode) that allows VIM to edit the cell, using vim key-binding to edit the content of the cell.

We already supports this with native notebook.


firefox 108.0.2 crash webapp

DatabaseClosedError: UnknownError The operation failed for reasons unrelated to the database itself and not covered by any other error code.
UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code.
at undefined (DatabaseClosedError: UnknownError The operation failed for reasons unrelated to the database itself and not covered by any other error code.:undefined:undefined)
at undefined ( UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code.:undefined:undefined)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:16621:1)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:16809:1)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:15448:1)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:10180:1)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:10937:1)
at from (../node_modules/dexie/dist/modern/dexie.min.mjs:11298:1)
DatabaseClosedError: UnknownError The operation failed for reasons unrelated to the database itself and not covered by any other error code.
UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code.
at s_@https://ntfy.sh/static/js/main.226af0b6.js:2:1080827
at Dm@https://ntfy.sh/static/js/main.226af0b6.js:2:924178
at Vm@https://ntfy.sh/static/js/main.226af0b6.js:2:926532
at n@https://ntfy.sh/static/js/main.226af0b6.js:2:980772
at i@https://ntfy.sh/static/js/main.226af0b6.js:2:983951
at C@https://ntfy.sh/static/js/main.226af0b6.js:2:346370
at S@https://ntfy.sh/static/js/main.226af0b6.js:2:346090
at O@https://ntfy.sh/static/js/main.226af0b6.js:2:346479
at Km@https://ntfy.sh/static/js/main.226af0b6.js:2:925792
at wv@https://ntfy.sh/static/js/main.226af0b6.js:2:979224
at Suspense
at d_

Sorry, problem with my profile firefox.