Split collections to allow dropping Kubernetes import

For https://github.com/istio/istio/issues/26232
This code is admittedly pretty bad - but gets the job done
Importing k8s libraries adds up to 40mb to the binary. This, along with many other changes, allows completely dropping the imports and cutting the agent binary size in half. See https://github.com/howardjohn/istio/pull/new/agent/tiny-binary-full-branch for this end state.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

lint_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test lint_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test unit-tests_istio

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-multicluster-k8s-tests_istio

lint_istio
73efc9623c1eec0503301c1a5275028f466cecb9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test release-test_istio

integ-distroless-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-ipv6-k8s-tests_istio

integ-helm-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9859ad8da495d5257245d6406899319e20bde026
link
/test integ-multicluster-k8s-tests_istio

lint_istio
73efc9623c1eec0503301c1a5275028f466cecb9
link
/test lint_istio

unit-tests_istio
73efc9623c1eec0503301c1a5275028f466cecb9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
73efc9623c1eec0503301c1a5275028f466cecb9
link
/test unit-tests_istio

lint_istio
1d0d4827bf915466cf2e39eb4a2104ec3c47ee38
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


create production migration script

This is about periodic migration of the production database to refresh the dev database.
Current state: Production to dev migration is manual.
Solution: There should be a script or set of instructions in place to ensure that there are planned and managed refreshes.


.net 6

Breaking change

Proposed change

.NET 6 is released and this PR upgrades all the project files etc to the new version and use version 10 of C#.

[x] Upgrade projects and dependencies to .net 6
[x] Upgrade CI to use .net 6 bits and some clean-up
[x] Fix all new warnings for .net 6 compiler
[x] Devcontainer to .net 6

Type of change

[x] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]
[x] The code compiles without warnings (code quality chek)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

Codecov Report

Merging #519 (82a6f73) into dev (a17f802) will decrease coverage by 0.04%.
The diff coverage is 32.22%.

@@            Coverage Diff             @@
##              dev     #519      +/-   ##
==========================================
- Coverage   59.80%   59.75%   -0.05%
==========================================
  Files         139      138       -1
  Lines        5864     5882      +18
  Branches      845      851       +6
==========================================
+ Hits         3507     3515       +8
- Misses       2072     2076       +4
- Partials      285      291       +6

Flag
Coverage Δ

unittests
59.75% <32.22%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...pp/NetDaemon.App/Common/Reactive/ObservableBase.cs
86.53% <0.00%> (ø)

...mon/NetDaemon.Daemon/Daemon/DaemonAppExtensions.cs
57.69% <0.00%> (ø)

...n/NetDaemon.Daemon/Daemon/EntityStateManagement.cs
86.27% <0.00%> (ø)

src/Daemon/NetDaemon.Daemon/Daemon/HttpHandler.cs
57.69% <0.00%> (ø)

...nner/DaemonRunner/Service/App/DaemonAppCompiler.cs
0.00% <0.00%> (ø)

...nRunner/DaemonRunner/Service/App/DaemonCompiler.cs
75.58% <0.00%> (ø)

...DaemonRunner/Service/App/LocalDaemonAppCompiler.cs
0.00% <0.00%> (ø)

...DaemonRunner/DaemonRunner/Service/RunnerService.cs
0.00% <0.00%> (ø)

src/Fakes/NetDaemon.Fakes/HassClientMock.cs
61.42% <0.00%> (-0.48%)
:arrow_down:

...Model/NetDaemon.HassModel.CodeGenerator/Program.cs
0.00% <0.00%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0871882...82a6f73. Read the comment docs.


Only Menu bar mode

It would be nice if I can choose to only open the window in the Menu bar instead of the whole application.

@anubra266 you can update GitLight and this should be fixed!

@colinlienard If I click the link of any of the items in the menu bar window, it opens the main window
https://github.com/colinlienard/gitlight/assets/30869823/7121de18-528f-43c3-a2db-7cf821b240da

I'm sorry, I don't think I can do better right now with Tauri, at least the big window is not focused
It might change in the future if the dock api is finally released

I understand @colinlienard Thanks for your work on this


add new system calls to block and unblock tasks

these system calls are required to support the latest nightly compiler

rust-lang/rust#77147 simplifies things by splitting this Mutex type into two types matching the two use cases: StaticMutex and MovableMutex. To support the behavior of StaticMutex, we move part of the mutex implementation into libstd. Consequently, we introduce new system calls.
I will accept this PR to create a PR for libstd


Update Client.php

Sorry no, this check is to make sure it doesn't attempt to load repositories starting with .


Clean up master branch

The master branch had a major overhaul. It is merged with was previously the satay_processing branch. This branch won't be updated anymore. The old master branch is now called developercodes.

Indeed, the master branch should be the working branch of the repository, so no pushes should be made to this branch that concerns the main working code . If you would like to modify a function to your own needs and you require to push  your changes to the remote repository (because you want to show it to someone) create a new branch for that.


Non-default ships

Is is possible to add non Default ships like the T70 or K-Wing ?
They are not included by default in HOTAC but in the official FAQ rules are suggested to use them.
Thanks !

I had some of these in an earlier test version (and they might still be in the codebase).
I was under the impression these ships are generally thought of as being overpowered in regular hotac (as mentioned in the FAQ I think), and on top of this, everyone plays these in a different way with slightly different rules or stat cards. This means without "official" hotac rules, there is no way to add them in a way which would work for everybody.
At the moment, I am keeping the app restricted to the basic hotac rules for simplicity. I may consider adding this a lot further down the line, but it would likely need to be done in a generic way which allowed different types of custom ship.


Not allowed to load local resource

On start, just shows window and menu, but not content.
Console shows:
Not allowed to load local resource: file:///E:/reactjs/electron-demo/dist/index.html
Console windows:
lost

Ooops.
Need to run:
npm run build:react
npm run build
npm run start


How to clone a virtual machine using pvc？

I use CDI to import the local centos image into the pvc. The command is as follows
virtctl image-upload \
  --image-path='CentOS-7-x86_64-Minimal-2009.iso' \
  --pvc-name=centos \
  --pvc-size=4G \
  --uploadproxy-url=https://<IP_ADDRESS>:443 \
  --storage-class='managed-nfs-storage' \
  --insecure

Then after creating a 20G pvc, I used the following yaml to create the virtual machine
apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  name: vm-centos
spec:
  running: true
  template:
    metadata:
      labels:
        app: centos
    spec:
      domain:
        cpu:
          cores: 4
        devices:
          disks:
            - bootOrder: 1
              name: cdromiso
              cdrom:
                bus: sata
            - disk:
                bus: sata
              name: disk1
          interfaces:
          - masquerade: {}
            model: e1000
            name: default
        machine:
          type: q35
        resources:
          requests:
            memory: 4Gi
      networks:
      - name: default
        pod: {}
      volumes:
      - persistentVolumeClaim:
          claimName: centos
        name: cdromiso
      - name: disk1
        persistentVolumeClaim:
          claimName: pvc-vm1

I have completed the installation of the system and performed some operations on the system. For example, I downloaded docker using yum, and now I want to use this virtual machine as a template to create an identical virtual machine. The new virtual machine also has docker downloaded by yum, and the new virtual machine also uses pvc as disk.
How to do it？

The above line break is a little uncomfortable, let me send yaml again
apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
name: vm-centos
spec:
running: true
template:
metadata:
labels:
app: centos
spec:
domain:
cpu:
cores: 4
devices:
disks:
- bootOrder: 1
name: cdromiso
cdrom:
bus: sata
- disk:
bus: sata
name: disk1
interfaces:
- masquerade: {}
model: e1000
name: default
machine:
type: q35
resources:
requests:
memory: 4Gi
networks:
- name: default
pod: {}
volumes:
- persistentVolumeClaim:
claimName: centos
name: cdromiso
- name: disk1
persistentVolumeClaim:
claimName: pvc-vm1

Does it meet your needs?
https://github.com/kubevirt/containerized-data-importer/blob/main/doc/datavolumes.md#pvc-source

@iholder101 you looked at cloning, not?

@iholder101 you looked at cloning, not?

Yes, implemented it :)
@binweee I'm sorry for the late response.
Today the only supported source kinds for a clone are VMs, or VMSnapshots, so in order to create a "golden image" you'd have to start the VM, create a VM snapshot, possibly shut down the VM, then clone the snapshot into VM instances (possibly with some modifications).
I recommend reading more on our user guide on the subject: https://kubevirt.io/user-guide/operations/clone_api/.
I do think however that supporting PVC as a source for cloning is definitely something to consider. You're more than welcome to open an issue about it and/or take part in implementing it! :)

/remove-lifecycle rotten


VersionBot: Allow a VB merge without any reviewers

TLDR: this would be useful for early development where you want to take advantage of auto changelog and auto versions, but don't care too much about branch protection.
https://www.flowdock.com/app/rulemotion/r-process/threads/EmHclV3Oc_OdaR_5TCUGMvv6_3v

We're going to discuss this in a process meeting (and I'll drag you in @LucianBuzzo). I think this'd have to initially work by disabling review protection on the repo, and getting VB to read that protection and simply blanket passing anything on the Reviewers check if it sees the protection is off. A maintainer would then have to re-enable review protection once the repo's in such a state as to require all PRs to be reviewed again.

We're going to go ahead with this. If the review branch protection for master is off, then the Reviewers status will automatically pass. If it's enabled, then the Reviewers status will go through the usual checks.


Web Deployment

local-web
Introducing the web deployment configuration.
The deployment uses the servlet-based Spine web API and its Firebase implementation. The command and query endpoints are defined under the /command and /query paths respectively.
The local-web module uses the Gretty plugin to run locally. Run ./gradlew :local-web:appRun to start the server.
Prerequirements
The deployment uses the Firebase Realtime Database. It is required that the Firebase credentials are available under the local-web/src/main/resources/spine-dev.json.
To use a custom Firebase project (not spine-dev) put the credentials into the module classpath end edit the io.spine.examples.todolist.server.FirebaseClient class accordingly.
client-web
Introducing the TodoList Web client.
Currently, the client is capable of creating and displaying simple tasks (i.e. tasks with a description only).
To run the client, open the client-web/app/index.html with the most convenient way (e.g. from IDEA).
Prerequirements
In order to launch the Web application successfully

start the local-web server (see above);
if the server uses a custom Firebase project (not spine-dev), point the client to that project in client-web/lib/firebase_client.js;
build the client-web Gradle project with ./gradlew :client-web:build (the general ./gradlew build works as well).

@armiol, PTAL.

@dpikhulya, @YegorUdovchenko, @PaulAgeyev, FYI. This is the examplar usage of the Spine web API (the JS part, in particular).

@armiol, PTAL again.


Allow button-related parameters for submit in form_for

For the button and button_to helpers, you can specify additional parameters such as context and layout, which are translated into appropriate btn-* classes. However, these parameters do not work with the submit helper in form_for.
Consider the following example:
<%= form_for @article, layout: :basic do |form| %>
    <%= form.submit context: :warning, layout: :block %>
<% end %>

The "expected" output would be something like:
<button type="submit" name="commit" value="Create Article" class="btn btn-warning btn-block">

However, what is actually produced is:
<input type="submit" name="commit" value="Create Article" context="warning" layout="block">

Would it be possible for submit to accept the same parameters as button and button_to? Currently, as a workaround, we can specify the class explicitly, e.g.:
<%= form.submit class: 'btn btn-warning btn-block' %>

But that somehow feels a bit "hacky" when the other helpers do it automatically.

Hello @chrisbouchard – the behavior you describe is not expected, and I think you might have found a partial bug.
As you can see in this line of code, submit is mean to respect the :context option passed.
The problem is that if you don't specify a caption for the submit button, then the context is ignored, and this is a bug.
While I fix the bug, you can get the :context working by explicitly specifying the caption, such as:
<%= form_for @article, layout: :basic do |form| %>
    <%= form.submit 'Create', context: :warning %>
<% end %>

The :layout option is not accepted by submit… but that's more of a feature-request that I can deal with separately, whereas the :context is supposed to work, and therefore is a bug.


Complex custom resources: workflow problems

Godot version:

488884178e773a6e80070663d92cc53cb820bff9
Issue description:

There are a number of open issues and comments surrounding the usage of custom resources in Godot, but I didn't find anything which comprehensively covers the problem, so I thought I'd create an issue on it here, since now the problems surrounding loading custom resources are resolved when using C#.  The following text uses C# examples, but the same applies to GDScript.
Consider we have the following hypothetical data structures saved into different scripts:
public class MonsterInfo : Resource
{
    [Export]
    public Stats stats;
    [Export]
    public ElementalResistances resistances;
    [Export]
    public DropChance[] dropChances;
    [Export]
    ...
}

public class Stats : Resource
{
    [Export]
    public int strength;
    [Export]
    public int defense;
    [Export]
    public int magic;
    [Export]
    public int resistance;
    [Export]
    ...
}

public class ElementalResistances : Resource
{
    [Export]
    public int fire;
    [Export]
    public int water;
    [Export]
    public int holy;
    [Export]
    public int unholy;
    [Export]
    ...
}

public class DropChance : Resource
{
    [Export]
    public Item item;
    [Export]
    public float chance;
}

So, our MonsterInfo resource will hold various other resources which describe its make-up; we can save this to disk and have our own database editable right there in the editor.  Great!  But once you create a new MonsterInfo resource, you run into this problem: every property exported gives just a big list of resources to create from, none of which are what you really want:

In order to assign something to these slots, it is required to create them first in the FileSystem, save them to disk, then drag and drop them into the slot.  So your project winds up littered with all these extra resources that exist just to be placed into those slots, when what you really want is the ability to just create a resource right there and have them 'built-in' to the file, as you can do with other resources.
This is especially egregious with DropChance: for every entry you'd like to create describing what items this monster will drop when killed, that's another resource you have to go through the process of creating.
One proposed solution to this problem is to keep everything within the one resource:
class MonsterInfo : Resource{
    [Export]
    public int strength;
    [Export]
    public int defense;
    ...
    [Export]
    public int fireRes;
    [Export]
    public int waterRes;
    ...
    [Export]
    public Item itemA;
    [Export]
    public float itemADropChance;
    [Export]
    public Item itemB;
    [Export]
    public item itemBDropChance;
    ...
}

However, this introduces a problem where, if you have another resource of type PlayableCharacterInfo, which also uses Stats, ElementalResistances and so forth, you must copy/paste your code, or try to refactor it by introducing a base class, which can have its own problems (since multiple inheritance isn't a thing in either GDScript or C#.)
Another possible solution (at least for DropChance) is to use a dictionary, where you manually define an entry that takes one resource (or path to a resource) and one float; however, dictionaries aren't really designed for this usage, and if you needed to introduce a 3rd variable, the problem gets even worse, where you now have to associate an array as the value to the dictionary which contains the rest of the info.  This entire solution is unwieldy due to the fact that you don't have any guarantee of what's in these dictionaries or if the array is in the right order, so extra care must be given here and you must reference back to this resource when working with it in code to ensure you're accessing them properly, as there's no names associated with this data, nor any type safety; the same applies in the case of foregoing custom resources for, say, Stats, and just using an int array instead: you have to count how many entries you're adding, and you have to memorize the order in which they're meant to go, as there's no names to go by here either.
A third solution is to just forego custom resources all together and use JSON or some other text format, which has the drawback of being more difficult to work with (no inspector, so none of the benefits which can come from it), and since you still have to figure out what to do with all your data once it's parsed, introducing more work on behalf of the developer; it's something which can break easily in ways that are hard to debug, as another developer who works in this manner has revealed to me.  One could create an inspector of their own to work with all this data, but that's yet more work for each new resource introduced, not leveraging the power of Godot already present.
Perhaps the most robust solution right now is to also forego custom resources but to instead define your data into one big script that contains just definitions; while less than ideal, as you still have much typing to do, you can at least be certain that you have a name associated with all your data, with type safety, and neatly organized into sub-objects which can just be associated with any data type of your choosing:
private static readonly Dictionary<MonsterList, MonsterInfo> MonsterDefinitions = new Dictionary<MonsterList, MonsterInfo> {
...
stats = new Stats {
	strength = 381,
	psionics = 412,
	defense = 255,
	resistance = 307,
        ...
},
elements = new Elements {
	sun = 2,
	moon = 2,
	...
},
skills = new Skills {
	trainer = 3,
	smash = 3,
	...
},
...

And then there's the business where you create a plugin for this stuff, but that's also unwieldy and shrouded in mystery.
In an ideal Godot, you would simply be able to create a resource of the exported type right there in the slot, and then modify the built-in entry that way; now you don't need to clutter up the project with possibly hundreds (or more, depending on the complexity of your data) of resources that do nothing but provide the makeup of other more complex resources (say, you have 100 different monsters in your game, each of which requires 5 other resources to describe it), or try to come up with some other less-than-ideal solution.
Compare this situation to Unity3D's ScriptableObject/Serializable attribute, the parallel to Godot's custom resources:
public class MonsterInfo : ScriptableObject{
    public Stats stats;
    ...
}

[System.Serializable]
public class Stats{
    public int strength;
    ...
}

In this case, all the public values of Stats will just show up in the inspector when a MonsterInfo file is inspected, and can thus be assigned to right there, in its own collapsible menu; it makes creating complex data simple and intuitive, again, bringing all the benefits of the inspector with it.
I think Godot can be just as easy and simple to work with data in this regard, but currently it is not.

Moved to https://github.com/godotengine/godot-proposals/issues/18


Fix 5993 - Remove Usage of Shared Materials with Clipping Primitives

Overview
This change fixes an issue where clipping primitives were modifying a renderers shared material in the editor. Materials are now cloned (much like how renderer.material works at run time). This was done to support edit time manipulation without leaking materials into the scene.
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/6001 relies on this change.
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5993

Verification
Please try using a scene that uses primitive clipping such as the ClippingExamples or MaterialGallery scenes.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

@julenka of course! This PR shouldn't change any performance characteristics (clipping primitives still have to create material clones to change shader keywords, like clipping primitives did before this change). The public API also remains the same, so hopefully no breaking changes.
The biggest difference is that in edit mode the original system would call renderer.sharedMaterial rather than renderer.material because calling renderer.material at edit time emits this Unity error:

Instantiating material due to calling renderer.material during edit mode. This will leak materials into the scene. You most likely want to use renderer.sharedMaterial instead.

But, using renderer.sharedMaterial will affect all instances that use that material (I thought at edit time all shared materials were unique but I was wrong about that).
So, now I always call renderer.sharedMaterial (at edit and run time) and create a material clone to assign. This keeps the code path the same at edit time and run time since renderer.material does a similar thing. From the renderer.material docs:

This function automatically instantiates the materials and makes them unique to this renderer. It is your responsibility to destroy the materials when the game object is being destroyed. Resources.UnloadUnusedAssets also destroys the materials but it is usually only called when loading a new level.

The material clone's lifetime gets managed now and destroyed when the clipping primitive is destroyed and when a renderer is removed.
I've seen other projects write a generic material referencing system to avoid some of this bespoke logic. But, that would be a somewhat substantial change to the MRTK (maybe for anther day?). Also, we can luckily lean on material property blocks more and more these days, so that helps too!
The TL;DR is this change should fix situations where global materials were erroneously modified while making sure all cloned created materials are tracked and destoryed, and not accidently serialized into a scene.


chore(sdk): update to latest afgo, use new afgo components

Codecov Report
Patch coverage: 63.63% and no project coverage change.

Comparison is base (69ac92e) 89.78% compared to head (a117c80) 89.78%.

:exclamation: Current head a117c80 differs from pull request most recent head 46bcab8. Consider uploading reports for the commit 46bcab8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   89.78%   89.78%
=======================================
  Files          79       79
  Lines        2947     2947
=======================================
  Hits         2646     2646
  Misses        199      199
  Partials      102      102

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/api/diddocresolution.go
74.07% <ø> (ø)

cmd/wallet-sdk-gomobile/api/jsonwebkey.go
89.47% <ø> (ø)

cmd/wallet-sdk-gomobile/credential/inquirer.go
96.07% <ø> (ø)

cmd/wallet-sdk-gomobile/credential/signer.go
86.66% <ø> (ø)

cmd/wallet-sdk-gomobile/credential/status.go
61.29% <ø> (ø)

...-sdk-gomobile/credential/submission_requirement.go
100.00% <ø> (ø)

cmd/wallet-sdk-gomobile/did/create.go
76.47% <ø> (ø)

cmd/wallet-sdk-gomobile/did/keywrapper.go
100.00% <ø> (ø)

cmd/wallet-sdk-gomobile/display/resolve.go
80.64% <ø> (ø)

cmd/wallet-sdk-gomobile/openid4ci/interaction.go
87.75% <ø> (ø)

... and 25 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unable to install nautobot_netbox_importer plugin

Hello, I'm trying to install nautobot_netbox_importer but, I'm not able to build image with plugin configured.
Environment

Python version:  3.8.5
Nautobot version:  Nautobot-Lab 1.0.0b4
nautobot-netbox-importer version: Version 1.2.1

Expected Behavior
Nautobot-lab image built with nautobot_netbox_importer plugin
What happened instead?
Unable to find plugin nautobot_netbox_importer
#17 61.21 TASK [RUN MAKEMIGRATIONS] ******************************************************
#17 61.57 fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["/opt/nautobot/bin/nautobot-server", "makemigrations"],
"delta": "0:00:00.184857", "end": "2021-04-22 07:25:17.981318", "msg": "non-zero return code", "rc": 1, "start": "2021-04-22
07:25:17.796461", "stderr": "Traceback (most recent call last):\n  File \"/opt/nautobot/lib/python3.8/site-
packages/nautobot/extras/plugins/utils.py\", line 63, in load_plugin\n    plugin = importlib.import_module(plugin_name)\n  File
 \"/usr/lib/python3.8/importlib/__init__.py\", line 127, in import_module\n    return _bootstrap._gcd_import(name[level:], package, level)\n  File \"<frozen importlib._bootstrap>\", line 1014, in _gcd_import\n  File \"<frozen importlib._bootstrap>\", line 991, in
_find_and_load\n  File \"<frozen importlib._bootstrap>\", line 973, in _find_and_load_unlocked\nModuleNotFoundError: No
module named 'nautobot_netbox_importer'\n\nThe above exception was the direct cause of the following
exception:\n\nTraceback (most recent call last):\n  File \"/opt/nautobot/lib/python3.8/site-
packages/nautobot/core/runner/runner.py\", line 118, in settings_callback\n    initializer(\n  File
\"/opt/nautobot/lib/python3.8/site-packages/nautobot/core/cli.py\", line 178, in _configure_settings\n    load_plugins(settings)\n  File \"/opt/nautobot/lib/python3.8/site-packages/nautobot/extras/plugins/utils.py\", line 53, in load_plugins\n
 load_plugin(plugin_name, settings)\n  File \"/opt/nautobot/lib/python3.8/site-packages/nautobot/extras/plugins/utils.py\", line 66, in load_plugin\n    raise PluginNotFound(\nnautobot.extras.plugins.exceptions.PluginNotFound: Unable to import plugin
nautobot_netbox_importer: Module not found. Check that the plugin module has been installed within the correct Python
environment.", "stderr_lines": ["Traceback (most recent call last):", "  File \"/opt/nautobot/lib/python3.8/site-
packages/nautobot/extras/plugins/utils.py\", line 63, in load_plugin", "    plugin = importlib.import_module(plugin_name)", "  File \"/usr/lib/python3.8/importlib/__init__.py\", line 127, in import_module", "    return _bootstrap._gcd_import(name[level:], package, level)", "  File \"<frozen importlib._bootstrap>\", line 1014, in _gcd_import", "  File \"<frozen importlib._bootstrap>\", line 991
, in _find_and_load", "  File \"<frozen importlib._bootstrap>\", line 973, in _find_and_load_unlocked", "ModuleNotFoundError: No module named 'nautobot_netbox_importer'", "", "The above exception was the direct cause of the following exception:", "",
"Traceback (most recent call last):", "  File \"/opt/nautobot/lib/python3.8/site-packages/nautobot/core/runner/runner.py\", line
118, in settings_callback", "    initializer(", "  File \"/opt/nautobot/lib/python3.8/site-packages/nautobot/core/cli.py\", line 178, i
n _configure_settings", "    load_plugins(settings)", "  File \"/opt/nautobot/lib/python3.8/site-
packages/nautobot/extras/plugins/utils.py\", line 53, in load_plugins", "    load_plugin(plugin_name, settings)", "  File
\"/opt/nautobot/lib/python3.8/site-packages/nautobot/extras/plugins/utils.py\", line 66, in load_plugin", "    raise
PluginNotFound(", "nautobot.extras.plugins.exceptions.PluginNotFound: Unable to import plugin nautobot_netbox_importer:
 Module not found. Check that the plugin module has been installed within the correct Python environment."], "stdout": "",
"stdout_lines": []}

PluginNotFound(", "nautobot.extras.plugins.exceptions.PluginNotFound:
Unable to import plugin nautobot_netbox_importer: Module not found.
Check that the plugin module has been installed within the correct Python environment."], "stdout": "", "stdout_lines": []}

Steps to Reproduce

Edit templates/requirements.txt

Add line nautobot-netbox-importer

Edit templates/nautobot_config.py

Edit variable PLUGINS = ["nautobot_netbox_importer"]

Edit Dockerfile

trying to install nautobot-netbox-importer extra  RUN pip3 install nautobot-netbox-importer

Build nautobot-lab image

docker build -t nautobot-lab:latest .

Error occurs

Am I missing some other configuration?

I think with the approach you’re using the plugin is getting installed to the global Python library, rather than the Nautobot virtualenv. Instead of your steps 1 and 3, try adding the following to pb_nautobot_install.yml  between the INSTALL NAUTOBOT and RUN NAUTOBOT-SERVER INIT steps:
- name: "INSTALL PLUGIN"
  ansible.builtin.pip:
    name: "nautobot-netbox-importer==1.2.1"
    virtualenv: "{{ nautobot_root }}"
    virtualenv_command: "python3 -m venv"

Hi @Kani999, @glennmatthews's approach should work perfectly. Let us know if that doesn't work for you.

(If we don't already have plans to add some documentation on how to do exactly this, I'd recommend it. :-) )

Everything works fine now.
Thank you.


Error when trying to use the 'data_server' data transformer on altair 4.0

When I try to use the data_server by enabling with altair.data_transformers.enable('data_server'), I get this error: NoSuchEntryPoint: No 'data_server' entry point found in group 'altair.vegalite.v4.data_transformer'.
I am on altair version 4.0.0 and altair_data_server version: 0.4.1

How did you install altair_data_server?
If you run from altair_data_server import data_server do you see any errors?

Apparently this turned out to be an installation issue at my end. Thanks for checking on this Jake. I am closing the issue.

Great!

How did you install altair_data_server?
If you run from altair_data_server import data_server do you see any errors?

it works for me!


docs: fix typo in golang/webhooks.md

fix typo for error link

Description of the change:
Fix typo for error link in docs/building-operators/golang/webhooks.md
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

Hi @FrankYang0529,
Thank you for your contribution. However, we ought to do this change against the master. It could be a cherry-pick against 1.0 branch. Could you please check it?

@camilamacedo86 this document was removed in master, so this PR is fine.


Aws::Route53::Errors::Throttling still happening

Cookbook version
1.2.1
Chef-client version
12.14.77
Platform Details
Centos 7 and Ubuntu 16.04
Scenario:
We're able to trigger the rate limit error easily. We have test-kitchen setups that test full clusters, and some of these setup do deploy a lot of instances in AWS. They end up hitting that limit frequently.
Expected Result:
The cookbook handling rate limits errors by the Route 53 API. It should then sleep for 1 second, try, if still fails, sleep for last_sleep * 2, retry, etc.
Actual Result:
Chef run fails.
I'm working on a patch. If you guys are interested, I'll submit it. Open to suggetions on behavior.

@ls-jftheroux Could you provide more information. Definitely interested in hearing more about this issue and what you think might help.

@ls-jftheroux Have you attempted using the chef built-in properties retries and retry_delay when you declare your route53_record resource in a recipe? I haven't been able to test this myself but it I believe it should work in this case.
https://docs.chef.io/resource_common.html#properties

Well, we ended up writing some custom code and stopped using the resource itself since I opened this issue. We needed more in the end than record creation. We wrote a lib that does a few things for us with R53.

Ahh. Thanks for the update @ls-jftheroux. I'm going to go ahead and close this.


Wrap type assist

Sometimes we have functions like the following:
void f(T parameter) {
  //...
}

And we want to make this void synchronous function into an asynchronous one, so we must add the async keyword at least but also, at least most of the time, we'd like to make the result of this function become Future<void>.
Other times we have parameters like parameter but we change our minds while programming and decide that we'd like for example to receive a List<T>, not simply T.
I see this happening a lot while I'm coding, so I suggest adding a simple assist to help wrap types with options like List, Set, Future and FutureOr. Similar to what we have for Widgets today.
Edit
I know that we already have the "Convert to async function body" assist, but the point here was to "have more options" by being able to wrap any written type with these options.
Also to be more explicit, I think this assist should appear on type words.

I don't feel that this is a useful feature. Converting to async happens relatively often as APIs evolve, and has reasonable semantics. Wrapping arbitrary type into another container type, this is rare IMHO, and an assist would be not more useful than just writing it manually.


Add a new Symfony securty guard

GitHub Issue
Part of:
https://github.com/Islandora-CLAW/CLAW/issues/565
What does this Pull Request do?
A new guard that we can use in Silex that should have the same behavior
as the java Syn code, so we can secure our microservices in the same way
and use the same tokens everywhere.
It also adds a new ServiceProvider that will setup all the Islandora services for an app.
How should this be tested?
There are a bunch of unit tests with this, but to test we will need the pull request to Crayfish that will actually use this component.
Pull request to use this is here:
https://github.com/Islandora-CLAW/Crayfish/pull/24
Interested parties
@Islandora-CLAW/committers

Don't think this will ever go fully green because the master is missing codecov, travis is happy though.

@jonathangreen this needs a rebase please.

Rebased. Should be good to go.


fix: style tweak for auto api

Fix display issues for type hints in API documentation with sphinx-autoapi.
To be able to better check this, this PR also adds a small mock Python module,
with a demo page for documenting it.
Styling is not 100% perfect, as the page now includes double lines (one for the heading 'Module contents' and one for the function signature). But still better than before.
@vict0rsch I hope it's ok that I took your function from issue #2056 and put it as an example in these docs.
Fixes #2056.

Hello, I tried to fix the issue
This is what I did:
This change adds custom CSS to improve the display of type hints in API documentation generated by sphinx-autoapi. It addresses the issue of type hints being displayed on separate lines, making them harder to read. The new CSS ensures that type hints are displayed inline with the function parameters.
I also created pull request: https://github.com/kai687/sphinxawesome-theme/pull/2058

[!CAUTION]
Disclaimer: This fix was created by Latta AI and you should never merge before you check the correctness of generated code!
The fix provided by Latta AI might not be complete and it can serve as an inspiration.

This bug was fixed for free by Latta AI - https://latta.ai/ourmission
If you no longer want Latta AI to attempt fixing issues on your repository, you can block this account.

LGTM thanks a lot for your promptness!


Convert metadata handling to dictionaries

A bunch of metadata items have been converted to dictonaries - in a new ProcessingOptions class. This in my Mac right now. Will push when everything's converted.

Fixed in v2.3.


Update polly dependencies to the latest supported

This addresses issue https://github.com/emccode/polly/issues/102
Please note that this commit changes the reference from github.com/clintonskitson/libstorage to github.com/dvonthenen/libstorage. This was done in order to update gofig to the latest as well as preserving the mock driver for CI testing.
Also, the commit looks messy only because it provides structure/organization to the file. What the file looks like in the end.
package: github.com/emccode/polly
import:
  - package: github.com/Sirupsen/logrus
    ref:     feature/logrus-aware-types
    repo:    https://github.com/akutz/logrus

  - package: github.com/emccode/libstorage
    ref:     ca8ecf16a73fff0be5918deffa42c8f2983b41c2
    vcs:     git
    repo:    https://github.com/dvonthenen/libstorage

  - package: github.com/akutz/gofig
    version: v0.1.4
  - package: github.com/akutz/gotil
    version: v0.1.0
  - package: github.com/akutz/goof
    version: v0.1.0
  - package: github.com/akutz/golf
    ref:     v0.1.1

  - package: github.com/docker/libkv
  - package: github.com/boltdb/bolt
    ref:     dfb21201d9270c1082d5fb0f07f500311ff72f18
  - package: github.com/coreos/etcd/client
    ref:     v2.3.3
  - package: github.com/samuel/go-zookeeper/zk
    ref:     5250732bd2ed71d1e374212ebfc32760eca10c0a

  - package: github.com/blang/semver
    ref:     v3.0.1
  - package: github.com/cesanta/validate-json
  - package: github.com/stretchr/testify
  - package: github.com/spf13/pflag
    ref:     b084184666e02084b8ccb9b704bf0d79c466eb1d
    repo:    https://github.com/spf13/pflag
  - package: github.com/spf13/cobra
    ref:     363816bb13ce1710460c2345017fd35593cbf5ed
    repo:    https://github.com/akutz/cobra
  - package: github.com/spf13/viper
    ref:     support/rexray
    repo:    https://github.com/akutz/viper.git

[Current coverage][cc-pull] is 67.95%

Merging [#108][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #108   diff @@
==========================================
  Files             6          6
  Lines           543        543
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            369        369
  Misses          122        122
  Partials         52         52

Powered by Codecov. Last updated by [9f6a490...f519b39][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/polly/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/polly/compare/9f6a49005fe3eb7f544826d87da10115a806630e...f519b39db37307f70aea63570589251b361f132b
[cc-pull]: https://codecov.io/gh/emccode/polly/pull/108?src=pr


New errorfmt for Rust

This PR closes #592. Stable 1.12 version of Rust, which introduces new errorfmt as default, will land in a few days and i think that it's reasonable to switch to the new errorfmt.
Introduced makers try to remove unnecessary informations, while maintaining error/warning messages, error description taken from the pointer line and note/help lines. The only thing that is missing is proper parsing of error/warning width, as pointer line contains both markers (^^^^) and error description.
More information about new format can be found here. I decided against parsing lifetime messages, because in my opinion they can't be shown in a sane way.

Thanks!
Do you feel like fixing the vint issues in the touched files?  (just add abort to all functions, i.e. function! neomake#makers#cargo#cargo() abort)
(Ref https://github.com/Kuniwak/vint/issues/181)
I think we should not merge this before the new version is released, should we?

Sure, I will fix vints issues for rust. I'm not sure if we shouldn't leave old errorfmt for the time being and just add new to makers. People might still use older versions of compiler for some time and maybe it'd not be the worst idea. That said i have almost no experience with errorfmts and neomake and i'm not sure if long list of errorfmts doesn't induce some kind of performance hit.

Please check https://github.com/neomake/neomake/issues/549#issuecomment-250550544.

@antoyo i decided against putting = note and = help in the errorfmt because the only place i have seen them were clippy error messages and it looks like they don't come in one chunk (neomake interprets error/warning message as one chunk and then slurps additional = note/help lines as another chunk and we lose information about line/file at this point. If you've seen other examples where this is not the case feel free to describe it and we will try to put this in the errorfmt.
@YorickPeterse i removed -Zno-trans from the rustc call. Now neomake will just call rustc without any flags which will build whole file and emit binary. I'm not sure if it's desired behaviour, but i wasn't able to find any other stable flags that would prevent emission of binary and only report errors/warns. One solution would be to keep on using -Zno-trans and ignore the warning in the errorfmt, but i don't think that is a good solution.
@blueyed I think the PR is ready to be merged. One thing that is interesting is the json error format which currently is unstable but will probably stabilize soon. Do you have any plans to support such format? As you can see here it contains a lot more precise information to work with (locaction list contains current output of the new errorfmt and on the right you can see the 'normal' error message and json output). Currently there's no sane way to parse the lifetime annotations and show them in neomake.

neomake interprets error/warning message as one chunk and then slurps additional = note/help lines as another chunk and we lose information about line/file at this point

Sounds like it's related to buffer_output (https://github.com/neomake/neomake/issues/598)?!  Or do you mean something else?
As for json: there is json_decode and we could map it to location list entries I guess?!
See https://github.com/neomake/neomake/issues/428.

neomake interprets error/warning message as one chunk and then slurps additional = note/help lines  as another chunk and we lose information about line/file at this point

Sounds like it's related to buffer_output (#598)?! Or do you mean something else?

Hmm, i had the impression that it chopped the output of the clippy (one consistent warning message was parsed as 2 lines of output), but i have just tried it again and this time it works.  Anyways it works now and i have added additional help annotations that sometimes appear in the compiler output.
I noticed that we use the same errorfmt in three different files (clippy.vim, cargo.vim, rust.vim). Wouldn't it make more sense if we define it in one place and then use the definition in these three makers?
As for json i will look into it after that error format stabilizes. I think that we should merge this PR first and if it will be more beneficial to parse json then new PR should be opened.

Hmm, i had the impression that it chopped the output of the clippy (one consistent warning message was parsed as 2 lines of output), but i have just tried it again and this time it works.

It depends on when it's flushed and e.g. if it is received during the "1st second" (but with only second-based resolution) - very fragile code there.. working on it in https://github.com/neomake/neomake/pull/607.

I noticed that we use the same errorfmt in three different files (clippy.vim, cargo.vim, rust.vim). Wouldn't it make more sense if we define it in one place and then use the definition in these three makers?

Totally..! You should use the existing/leading/main function then to just return it in the other maker definitions.
Do you want to do this in this PR?  Should be a separate commit then I'd say.

JFI: #598 has been merged - maybe it helps?! (i.e. please rebase)

I have rebased and introduced a single definition of rust's errorfmt (in rust.vim). Please note that i have almost no experience in writing vimscript so any feedback on that small refactor would be helpful.
I have also decided to add ignore patterns against 3 error messages that i feel are redundant.
Do you want me to squash my commits before you merge this PR?

LGTM, please squash and address the comment I've left.

Removed the trailing comma and squashed, feel free to merge.

Thanks a lot!

@fuine I'm not too familiar with the internals of neomake, so I don't know how hard this would be to do, but currently most type errors are simply rendered as cargo: mismatched types. This is not a particularly helpful error message. I suspect the reason is that Rust's new error messages include the type information on later lines of the output, and not in the error: line. Is there some way to still match the type information and emit it in the neomake output?

@jonhoo you are right, but the maker matches these lines. If you open quickfix/loclist you will see the rest of the error. There's no easy way to make it appear by deafult without opening lists.

That's true, but running :cope and :cclo (even with hotkeys) is sort of tedious. If we could come up with a good regex to bring the types in question into the statusline, that would be awesome! I don't even know where to begin implementing something like that though :/

I agree, can you open an issue about that problem? I will try to do something about it in the nearest future, because that is one of the few inconveniences that i hit with the current state of things.

@fuine see #793.


iOS build fails with 'Flutter/Flutter.h' file not found

Steps to reproduce

Clone https://github.com/banool/auslan_dictionary
Check out this PR: https://github.com/banool/auslan_dictionary/pull/209
flutter run

Actual results
I can't build or run the ios build. The Android version of the app builds fine (as you can see from the CI in the PR above).
I have tried everything I've read online, various hacks with Podfile to set the target IOS deployment target (of the app and its dependencies, and I've tried many different versions like 12, 13, 16, etc), exclude simulation targets, etc. I have tried reinstalling flutter from scratch, I've tried the latest stable and main versions of flutter. I confirmed that the build settings in Xcode look correct (correct order, "for install builds only" unticked). I have reinstalled various versions of ruby, cocoapods, XCode, etc. I've cleaned every cache I can find in every permutation. I have tried deleting the ios folder and regenerating it. Deleting various generated files in the ios/Flutter directory. Pretty much anything that pops up from searching for this error on Google, you name it (definitely everything here and in a few other posts: https://stackoverflow.com/q/64973346/3846032). Even things that I wouldn't expect to work, like building using the Flutter extension from Android studio.
I have updated every dependency to the latest, including across major version boundaries, and transitively via that dictionarylib dep.
The error message tends to change, but I think it's related to any dependency that requires a platform integration (so some pod gets installed), e.g. sqflite, http_proxy, the splash page package, device_info_plus, package_info_plus, etc.
Worth noting that this app used to build fine, but is now failing on the latest version of Flutter / XCode / etc. I can't quite tell which thing broke it.
Logs
The verbose output is too long for an issue, you can find it in this gist: https://gist.github.com/banool/32c02eaf030a56d8477be5697acb0260.
Flutter Doctor output

Doctor output
$ flutter doctor -v
[✓] Flutter (Channel stable, 3.24.4, on macOS 15.0.1 24A348 darwin-arm64, locale en-US)
    • Flutter version 3.24.4 on channel stable at /Users/dport/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 603104015d (3 days ago), 2024-10-24 08:01:25 -0700
    • Engine revision db49896cf2
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/dport/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

⣷^⣟[✓] Connected device (5 available)
    • Daniel iPhone (mobile)          • 00008110-001270480A0B801E            • ios            • iOS 18.0.1 22A3370
    • iPhone 15 Pro Max (mobile)      • 85EDB580-EEF0-4F6E-B721-2A6BA72B46E7 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-4
      (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 15.0.1 24A348 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 15.0.1 24A348 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 130.0.6723.70

[✓] Network resources
    • All expected network resources are available.

• No issues found!

same issue for me - my older builds from 24h ago are now failing as well.

I'm facing this issue too.
Adding config.build_settings['CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER'] = 'NO' in Podfile didn't help

I have successfully build my app, just remove cocoapods and reinstall cocoapods using homebrew.

Well I'll be damned, the solution was indeed to install cocoapods with brew instead of gem:
sudo gem uninstall cocoapods
brew install cocoapods

@banool wow, that actually worked - I reinstalled cocoapods via homebrew and it compiled on the first attemp
I had the latest version of cocoapods installed via non-system<EMAIL_ADDRESS>managed globally by mise. I have been using this setup for years, and this is the first time I've encountered any kind of issue with it. I wonder what could be the reason for this issue to appear out of nowhere

Still work for me

@banool do you mind reopening the issue, I have the exact issue as you did but the fix doesn't work for me

Adding my build logs here:
`Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running pod install...                                           1,856ms
Running Xcode build...
Xcode build done.                                           151.6s
Failed to build iOS app
Error (Xcode): double-quoted include "SqfliteImportPublic.h" in framework header, expected angle-bracketed instead
/Users/adnitkamberi/Documents/GitHub/blue-esim/blue_esim_flutter/ios/Pods/Target%20Support%20Files/sqflite_darwin/sqflite_darwin-umbrella.h:12:8
Error (Xcode): 'Flutter/Flutter.h' file not found
/Users/adnitkamberi/.pub-cache/hosted/pub.dev/sqflite_darwin-2.4.1-1/darwin/sqflite_darwin/Sources/sqflite_darwin/include/sqflite_darwin/SqfliteImportPublic.h:14:8
Error (Xcode): (fatal) could not build module 'sqflite_darwin'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c++_arm64-apple-ios12.0-simulator_gnu++20/Test/Test.framework/Headers/Test.h:0:8
Error (Xcode): (fatal) could not build module 'Test'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c++_arm64-apple-ios12.0-simulator_gnu++20/Test/Test.mm:0:8
Error (Xcode): (fatal) could not build module 'sqflite_darwin'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c++_x86_64-apple-ios12.0-simulator_gnu++20/Test/Test.framework/Headers/Test.h:0:8
Error (Xcode): (fatal) could not build module 'Test'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c++_x86_64-apple-ios12.0-simulator_gnu++20/Test/Test.mm:0:8
Error (Xcode): (fatal) could not build module 'sqflite_darwin'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c_arm64-apple-ios12.0-simulator_gnu17/Test/Test.framework/Headers/Test.h:0:8
Error (Xcode): (fatal) could not build module 'Test'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c_arm64-apple-ios12.0-simulator_gnu17/Test/Test.m:0:8
Error (Xcode): (fatal) could not build module 'sqflite_darwin'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c_x86_64-apple-ios12.0-simulator_gnu17/Test/Test.framework/Headers/Test.h:0:8
Error (Xcode): (fatal) could not build module 'Test'
/Users/adnitkamberi/Library/Developer/Xcode/DerivedData/Runner-bjtkyvsfwetfungwwnieasbodziw/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/sqflite_darwin.bu
ild/VerifyModule/sqflite_darwin_objective-c_x86_64-apple-ios12.0-simulator_gnu17/Test/Test.m:0:8
Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.`

1.15.2

adnitkamberi@Adnits-Mac-mini ~ % ruby --version
ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [arm64-darwin24]

adnitkamberi@Adnits-Mac-mini ~ % where ruby
/opt/homebrew/opt/ruby/bin/ruby
/usr/bin/ruby

adnitkamberi@Adnits-Mac-mini ~ % where pod
/opt/homebrew/bin/pod```

I am running macOS 15.0.1, Xcode 16.0, flutter stable channel

```adnitkamberi@Adnits-Mac-mini ~ % flutter --version
Flutter 3.24.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 603104015d (4 days ago) • 2024-10-24 08:01:25 -0700
Engine • revision db49896cf2
Tools • Dart 3.5.4 • DevTools 2.37.3```

My Podfile is like this:

```# Uncomment this line to define a global platform for your project
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
  'Debug' => :debug,
  'Profile' => :release,
  'Release' => :release,
}

def flutter_root
  generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), __FILE__)
  unless File.exist?(generated_xcode_build_settings_path)
    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
  end

  File.foreach(generated_xcode_build_settings_path) do |line|
    matches = line.match(/FLUTTER_ROOT\=(.*)/)
    return matches[1].strip if matches
  end
  raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_ios_podfile_setup

target 'Runner' do
  use_frameworks!
  use_modular_headers!

  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
  target 'RunnerTests' do
    inherit! :search_paths
  end
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
  end
end

I realized that the issue only happens when I build the ipa with --release, --dev and --profile work without any problem.  I attached flutter doctor output and error below. Interestingly, the problem occurred on Sunday and I was not able to even trigger older builds off GitHub after that.  Would love to understand root cause and certainly looking forward to a fix.
 flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.4, on macOS 15.0.1 24A348 darwin-arm64, locale
    en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.95.0-insider)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
Archiving ...
Running pod install...                                              4.9s
Running Xcode build...
Xcode archive done.                                         273.0s
Failed to build iOS app
Error (Xcode): double-quoted include "SmartAuthPlugin.h" in framework header, expected angle-bracketed instead
/Users/david/development/mobile_app/ios/Pods/Target%20Support%20Files/smart_auth/smart_auth-umbrella.h:12:8

Error (Xcode): 'Flutter/Flutter.h' file not found
/Users/david/.pub-cache/hosted/pub.dev/smart_auth-2.0.0/ios/Classes/SmartAuthPlugin.h:0:8

Error (Xcode): (fatal) could not build module 'smart_auth'
/Users/david/Library/Developer/Xcode/DerivedData/Runner-aknjobheqjstsiavbbyipmgzkiup/Build/Intermediates.noindex/ArchiveIntermediates/dev/IntermediateBuildFilesPath/Pods.build
/Release-dev-iphoneos/smart_auth.build/VerifyModule/smart_auth_objective-c++_arm64-apple-ios16.0_gnu++20/Test/Test.framework/Headers/Test.h:0:8

Error (Xcode): (fatal) could not build module 'Test'
/Users/david/Library/Developer/Xcode/DerivedData/Runner-aknjobheqjstsiavbbyipmgzkiup/Build/Intermediates.noindex/ArchiveIntermediates/dev/IntermediateBuildFilesPath/Pods.build
/Release-dev-iphoneos/smart_auth.build/VerifyModule/smart_auth_objective-c++_arm64-apple-ios16.0_gnu++20/Test/Test.mm:0:8

Error (Xcode): (fatal) could not build module 'smart_auth'
/Users/david/Library/Developer/Xcode/DerivedData/Runner-aknjobheqjstsiavbbyipmgzkiup/Build/Intermediates.noindex/ArchiveIntermediates/dev/IntermediateBuildFilesPath/Pods.build
/Release-dev-iphoneos/smart_auth.build/VerifyModule/smart_auth_objective-c_arm64-apple-ios16.0_gnu17/Test/Test.framework/Headers/Test.h:0:8

Error (Xcode): (fatal) could not build module 'Test'
/Users/david/Library/Developer/Xcode/DerivedData/Runner-aknjobheqjstsiavbbyipmgzkiup/Build/Intermediates.noindex/ArchiveIntermediates/dev/IntermediateBuildFilesPath/Pods.build
/Release-dev-iphoneos/smart_auth.build/VerifyModule/smart_auth_objective-c_arm64-apple-ios16.0_gnu17/Test/Test.m:0:8

Encountered error while archiving for device.```

Same problem... I tried a lot of things here... I also reinstalled cocoapods using brew... macos using Sonoma with Intel.
I reinstalled flutter, I have create an entire new project, just added sqflite lib, and same problem... missing Flutter/Flutter.h file

@klaussk8 try following

check xcodeproj version

sh xcodeproj --version

if it is 1.26.* then uninstall and install version 1.25.0
sh gem uninstall xcodeproj
sh gem install xcodeproj  --version=1.25.0"

I have successfully build my app, removed cocoapods, and reinstall cocoapods 1.16.0v
sudo gem uninstall cocoapods
brew uninstall cocoapods
sudo gem install cocoapods

then clear cache data
sudo rm -rf ~/Library/Developer/Xcode/DerivedData/; sudo rm -rf ~/Library/Caches/CocoaPods/
rm ios/Podfile.lock
rm -rf ios/.symlinks
rm -rf ios/Pods
flutter clean
flutter pub get
cd ios
pod deintegrate && pod install --repo-update

finally
flutter build ios --release

I hope this helps you. 🥳
pod version: 1.16.0
ruby version: ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [x86_64-darwin23]
Xcode version: 15.4
Flutter version:
Flutter 3.24.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 603104015d (5 days ago) • 2024-10-24 08:01:25 -0700
Engine • revision db49896cf2
Tools • Dart 3.5.4 • DevTools 2.37.3

@klaussk8 try following

check xcodeproj version

 xcodeproj --version

if it is 1.26.* then uninstall and install version 1.25.0
gem uninstall xcodeproj
gem install xcodeproj  --version=1.25.0"

Okay this did it

2. gem install xcodeproj  --version=1.25.0"

Thank you so much!
I initially had version 1.26 installed, but I removed all RVM versions to downgrade to 1.25. After doing this, xcodeproj --version correctly shows 1.25. I also tested by creating a new empty project, which worked perfectly. Then, I added the necessary sqflite library to the dependencies, and it installed without issues!
I did encounter some problems with the CocoaPods repo update in my main project, but after resolving that, everything is working, and I can run my project again! Thanks again for the help!

@klaussk8 try following

check xcodeproj version

 xcodeproj --version

if it is 1.26.* then uninstall and install version 1.25.0
gem uninstall xcodeproj
gem install xcodeproj  --version=1.25.0"

Thank you so much!
I initially had version 1.26 installed, but I removed all RVM versions to downgrade to 1.25. After doing this, xcodeproj --version correctly shows 1.25. I also tested by creating a new empty project, which worked perfectly. Then, I added the necessary sqflite library to the dependencies, and it installed without issues!
I did encounter some problems with the CocoaPods repo update in my main project, but after resolving that, everything is working, and I can run my project again! Thanks again for the help!

Xcode version 16.1 was my problem.
This worked for me.

Xcode 15.4 (Xcode CLT 16.0 or 16.1 did not work)
Pod 1.16.1
xcodeproj 1.26.0
cocoapods 1.16.1

and clearing cache as described above https://github.com/flutter/flutter/issues/157694#issuecomment-2443321940


kadane's algorithm for maximum sum subarray

hello admins I would like to add kadane's algorithm for maximum sum subarray please assign this work to me

@tarun26091999 @rudrakshi99
sir,
i am a participant of gssoc21 and would like to code kadane's algorithm for maximum sub array in java
please assign this issue to me

I can do this program using C,C++ and python
please assign me this issue.

#178 is same


Feat: fenced code blocks

Changes the representation of
 to fenced code blocks instead of indented code blocks in Markdown.
Fenced code blocks allow for user-friendly addition of language syntax, e.g.:
```python
print("hello")
```

Syntax highlighting for these types of fenced code blocks is today widely available and make code snippets more legible.
I therefore suggest to replace this as the default rendering of
.

Fixes https://github.com/dlon/html2markdown/issues/11

Thanks! I'm not necessarily opposed to the idea.

Unlike other formats markdown doesn't really have an 'official' spec, and fenced code blocks are kinda of the standard across almost all users of markdown for code.
If anything https://commonmark.org/ is probably 'the standard', and does have fenced back tick codeblocks as part of it. :)


Update the docs to include new features in 4.9.0

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
The latest version of the docs on https://netbasal.gitbook.io/akita/ is 4.7.0. The latest version of Akita is 4.10.8.
The last several versions seem to be exclusively bug fixes which may not require doc updates, but there are some new schematics and cli features introduced in 4.9.0 that are currently undocumented.
At the least, we should bump the version on the docs to indicate that they are still current.
What is the motivation / use case for changing the behavior?
The docs are great. Let's keep them up to date.

Thanks, done.


Add header option to SjppAntTask

This pull request adds a header optional parameter to the sjpp ant task completing #1 .
As there is currently some functionality around the GENERATED line that is unknown for me at the moment (e.g. see this), any header is added after the generic "this file has been autogenerated..." line.
I have used it to add license headers to auto-generated PlantUML codebases. I'll submit a PR to the plantuml repository next.

I've detected a bug due to the added header being removed, working on it.

It is finished and ready for review now.

Sounds good!
I've sent you an invitation, so you could make a new release by yourself (if that's fine for you).
We should also probably remove sjpp.jar from plantuml repository and instead modify the CI/CD of PlantUML so that it fetches sjpp from an official release here.
Any idea on how to do that? :-)

Hi,

I've sent you an invitation, so you could make a new release by yourself (if that's fine for you).

Github releases/actions are not my strong suit, but this seems like a good opportunity to learn. Any pointers?

We should also probably remove sjpp.jar from plantuml repository and instead modify the CI/CD of PlantUML so that it fetches sjpp from an official release here. Any idea on how to do that? :-)

That sounds like a great idea that I have no clue how to do :D. I'll have a look, I suppose Github Actions would allow doing some sort of clever wget / curl to fetch the latest release.


Where is Microsoft?

FOR THE LOVE OF GOT, WILL SOMEONE PUT OUT THE F-ING  ANSWER??  95% of us are trying to load the same software on the same version of windows the same way.  And where the F- is microsoft in all this.  Is there some embargo against the developers actually getting out there and helping a bit.  Or they just eat their free sushi lunch and give 2 $jits whethe it works or not?  I've read  40 different websites with "answers" now.  Fu<|< all works.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52db1d76-fb68-c44f-1162-3e30e8c2b793
Version Independent ID: 696aa3ee-bd95-2acf-9021-ef4b67663f1a
Content: Supported Ubuntu virtual machines on Hyper-V
Content Source: WindowsServerDocs/virtualization/hyper-v/Supported-Ubuntu-virtual-machines-on-Hyper-V.md
Service: na
Product: windows-server-threshold
GitHub Login: @shirgall
Microsoft Alias: kathydav

Hi
@altimmons if you have a question about a specific step I will try to find the right person to answer.
Best,
Dawn


Filter is not working

Here is my example, I've set it up based on the documentation but can't get it to work.  In this example index.html from folder1 should be copied to folder2.
node -v
v8.9.4
var options = {};
options.filter = new RegExp('index.html');

ncp('folder1', '../folder2', options,
    function (err) {
        if (err) {
            return console.error(err);
        }
        console.log('done!');
    }
);

This happens because ncp also applies the filter to directories. So when running the filter will be applied to ${absPath}/folder1. Since this path doesn't match processing of stops.
It would be nice to either change the behaviour of the filter to not apply to directories or to add another option (say, fileFilter) which is only applied to the basename of file paths.

So what is the solution here? When you add folder name to the regexp it will copy all files within.
Any way to specify folder as a target and filter out certain files only?

well i managed to stumble upon the same issue and my take on that was like in answer to SO: node ncp filter not working
hope it comes useful to someone

Looking at the source code it seems like the filter function takes in a function too, I am using it like this to copy only .css files
    ncp(workDir, outputPath, {filter: (source) => {
        if (fs.lstatSync(source).isDirectory()) {
            return true;
        } else {
            return source.match(/.*css/) != null;
        }
    }}, function (err) {
        if (err) {
            return console.error(err);
        }
    });


Tag new release?

Hi, thank you for making and maintaining this library.
Is there any way you could tag a new release?
I'm particularly concerned about this commit not being in the latest release, but maybe I'm misunderstanding it:
https://github.com/StackExchange/wmi/commit/b12b22c5341f0c26d88c4d66176330500e84db68
I like using semantic versions where possible so I'd really appreciate it.
Thank you!

Hello, any feedback on this request?

This is on our wishlist as well.
@captncraig you seem to be the last active maintainer, do you have time to create a new tag? Preferrably adhering to Go module requirements, ie prefixed with a v, so something like v1.1.0.

Tagged 1.1.0


[PE-D][Tester E] App does not save data on force quit

Reporting this because I noticed that yall save data on cmd+Q, so yall might want to cover force quits and crashes also!
Steps to produce:

Delete any existing data files
launch the app (the app should start with sample data)
force quit the app with task manager
the app doesn't save data

Labels: severity.Low type.FunctionalityBug
original: seanlim/ped#9

Similar to https://github.com/AY2425S1-CS2103T-F14b-1/tp/issues/225#issuecomment-2466640163.


[Slight Issue]

Hello, thought I'd say that I love your mod, just a slight issue I noticed.
I'm using the version on Curse forge, and the config, at default, is set to render the player model invisible when the camera gets too close. It does that just fine, however it also renders all other players invisible as well. I checked the version here on Github as well and it appears to do the same thing.
I'd appreciate a possible fix to this if possible.

Thanks for the report!
The issue will be fixed for version 1.12.2-1.13

Wow, that was fast.
Thanks for looking into that!


July 27 - Let's Chat about Chatbots

Event Information

Category
Details

Reactor Topic
AI

Monthly Topic (if applicable)
Connecting with Our World Through Data

Weekly Topic (if applicable)
All About Bots

Stream Topic
<2-5 words describing the topic>

Stream Date
July 27, 2020

Stream Time
4pm PT

Stream Duration
60 Min

Title
Let's Chat about Chatbots

Description
Chatbots let users communicate what they need while staying in the applications they're already using. If you're curious about how this revolutionary form of interaction works, what goes into building a bot, and how things work behind the scenes, join this one-hour session. We’ll spend time with creators of Bot Framework and answer your questions while showing off reasons why you might want to create your own bot.

Speaker
Christopher Harrison, Gary Pretty, and Ben Brown

Moderator

Event ID
7805

Additional Resources:

Event Checklist
10 Weeks Prior

[X] Reactor Content Team (RCT) or Speaker opens a new issue for an upcoming stream filling in the Event Information table. Both RCT and Speaker are marked as assignees.
[X] RCT and Speaker discuss details of the event in the comments of this issue. RCT adds a confirmed-event label and global-twitch-event tag to the issue and adds event to the Global Live Streams project. Issue will appear in the Upcoming Streams column
[X] Speaker adds a ready-for-marketing-edit label so the RCT can review title and description

8 Weeks Prior

[X] RCT does a review of title and description and removes the ready-for-marketing-edit label
[X] RCT moves the issue to the Ready for SharePoint column
[X] RCT informs the Reactor Marketing Team of the new event information
[ ] RCT provides speaker with assets (e.g. slides, overlays) and the survey data for the event
[X] RCT moves the issue to the MONTH Streams Prep column (according to the month it will be streamed in)

2 Weeks Prior (Done in /microsoft/Reactors)

[ ] Speaker opens a PR with the new content for the stream on the customer-facing Reactor repository and adds the content-development and global-twitch-event tag to the PR.
[ ] Speaker adds to the same PR a modification to the Streaming README to include their stream information.
[ ] Speaker adds the RCT assigned to the issue as the reviewer when it is ready for review/merge
[ ] RCT reviews, approves, and merges the changes

1 Week Prior

[ ] Speaker and Moderator test setup for streaming (instructions coming soon)
[ ] RCT checks in with the speaker and moves the issue to the Ready to Stream column

During and After Stream

[ ] Speaker and Moderator run the stream
[x] RCT submits recording to be uploaded to the Reactor YouTube and to be made available on LearnTV
[x] RCT moves issue to the Stream Complete column

@GeekTrainer can you send me Ben Brown's alias? there are quite a few Ben Browns in the address book.
Thanks!

 Issue closed.


chore: release 1.1.2

:robot: I have created a release *beep* *boop*
1.1.2 (2021-12-14)
Bug Fixes

query was discarded by proxy.module (5aefaef)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/keq-request/keq-proxy/releases/tag/v1.1.2 :sunflower:


Added module existance check.

Added module existance check to make JsonApiDataStore work with non-nodejs and/or non-browserify environments without exceptions.

LGTM, merging!

Hi,
When I installed jsonapi-datastore through Bower this change was not reflected- I ran into this same problem and ended up implementing this fix manually. Is the bower.json correct?
Thanks,
Karl

same thing on my side, the module existence check isn't there.

@ahmadhsalim you need to use github master branch until @beauby releases new bower version

Hi guys, sorry about that, I kinda forgot about bower once I set up the automated npm deploy. Will release a new bower version ASAP.

Just released a new bower version.


Cannot compile on Debian 12 kernel 6.1.0-23: errors in Card.h

When I attempt to run make  from the latest release version I get the following output:

FLAGS="-isystem./include -isystem./include/uapi -Werror -Wextra -Wall -Wno-error=missing-field-initializers -Werror=sign-compare -Wmissing-prototypes -Wstrict-prototypes -Werror=discarded-qualifiers " make -C module
make[1]: Entering directory '/home/thomas/downloads/evdi-1.14.5/module'
make -C /lib/modules/6.1.0-23-amd64/build M=$PWD
make[2]: Entering directory '/usr/src/linux-headers-6.1.0-23-amd64'
MODPOST /home/thomas/downloads/evdi-1.14.5/module/Module.symvers
make[2]: Leaving directory '/usr/src/linux-headers-6.1.0-23-amd64'
make[1]: Leaving directory '/home/thomas/downloads/evdi-1.14.5/module'
CFLAGS="-I../module -Werror -Wextra -Wall -Wno-error=missing-field-initializers -Werror=sign-compare -Wmissing-prototypes -Wstrict-prototypes -Werror=discarded-qualifiers " make -C library
make[1]: Entering directory '/home/thomas/downloads/evdi-1.14.5/library'
make[1]: Nothing to be done for 'default'.
make[1]: Leaving directory '/home/thomas/downloads/evdi-1.14.5/library'
CXXFLAGS="-I../module -I../library -Werror -Wextra -Wall -Wno-error=missing-field-initializers -Werror=sign-compare " make -C pyevdi
make[1]: Entering directory '/home/thomas/downloads/evdi-1.14.5/pyevdi'
g++ -I../library $(python3 -m pybind11 --includes) -std=c++20 -fPIC -fvisibility=hidden -I../module -I../library -Werror -Wextra -Wall -Wno-error=missing-field-initializers -Werror=sign-compare  -c Card.cpp
In file included from Card.h:11,
from Card.cpp:6:
Stats.h:25:26: error: ‘chrono’ is not a member of ‘std’
25 |         std::vectorstd::chrono::microseconds grabPixelStats;
|                          ^~~~~~
Stats.h:25:46: error: template argument 1 is invalid
25 |         std::vectorstd::chrono::microseconds grabPixelStats;
|                                              ^
Stats.h:25:46: error: template argument 2 is invalid
Stats.h:25:14: error: ‘’ in namespace ‘std’ does not name a type
25 |         std::vectorstd::chrono::microseconds grabPixelStats;
|              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Stats.h:26:26: error: ‘chrono’ is not a member of ‘std’
26 |         std::vectorstd::chrono::microseconds bufferStats;
|                          ^~~~~~
Stats.h:26:46: error: template argument 1 is invalid
26 |         std::vectorstd::chrono::microseconds bufferStats;
|                                              ^
Stats.h:26:46: error: template argument 2 is invalid
Stats.h:26:14: error: ‘’ in namespace ‘std’ does not name a type
26 |         std::vectorstd::chrono::microseconds bufferStats;
|              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:33: Card.o] Error 1
make[1]: Leaving directory '/home/thomas/downloads/evdi-1.14.5/pyevdi'
make: *** [Makefile:19: pyevdi] Error 2

Debian 12 (Bullseye)
kernel version: 6.1.0-23-amd64 (64-bit)
X11 version number: 11.0
X.Org version: <IP_ADDRESS>
KDE Plasma: 5.27.5
NVIDIA GeForce GT 710 with proprietary drivers

There seems to bee something wrong with the latest evdi version and debian. However..
add the synaptic repo to your system.  Be aware not to install apt install evdi at this moment, the compiled version here has a problem with Debian (even 12.6 bookworm). Instead do this;
sudo apt install evdi=1.14.6-10 (= forces the version)
Do not forget
sudo apt-mark hold evdi
to avoid evdi upgrading to the faulty version.
This will work in debian and you will be able to install displaylink-driver as well from this repo.

I ran into a similar problem @AngelBlue01 , but forcing version 1.14.6-10 as recommended by @HanSyt wasn't possible because this version isn't available in the repository. The closest available version for me was 1.14.5-93 and it installed correctly.
# apt install evdi=1.14.5-93
# apt-mark hold evdi

I am not able to reproduce it on evdi-1.14.5 with debian bullseye.
Please with latest main. Or raise an issue again.

I still have it on Bookworm (Bullseye is old and eol since Aug 14: https://endoflife.date/debian) And yes with Bookworm/Amd64 12.8 it is still an issue, however, old versions are stil working on newer kernels, see image

I still have it on Bookworm (Bullseye is old and eol since Aug 14: https://endoflife.date/debian) And yes with Bookworm/Amd64 12.8 it is still an issue, however, old versions are stil working on newer kernels, see image

I don't understand what problem you see. Card.h file is from pyevdi - python bindings that are not available in evdi.deb package.
What errors do you have?
I tried to compile pyevdi on bookworm 12.8 and I don't see any issues.


Mix between subjects?

These two plots for the brain and spinal cord show a different number of sessions. I suspect a mixup between subject numbering (eg: subject 4 in spinal cord corresponding to subject 5 in the brain):

If understood correctly the issue is the correct subjects displayed in the plots.  But, according to this output, which extracts the values/sessions/subjects, what it displays in coresponds to the csv data.

Output/plotting in code:

Rows in spinal data [csa-GM_T2s.csv]:

Rows in brain data [results-neuromod-anat-brain-qmri.csv]:

OK, it should be fine then. So we need to understand why the number of sessions differ between the brain and the spinal cord results. Do you mind digging into that?

Sure, I will look into it. Brief you tomorrow

Pinging @zelenkastiot – any ETA on looking into this?

Bug resolved in V2


[BUG] Sendgrid API key is used even when empty

Describe the bug
If I do not provide SENDGRID_API_KEY I see the following error message in my container logs: API key does not start with "SG."
This seems to be coming from here: https://github.com/AmruthPillai/Reactive-Resume/blob/main/server/src/mail/mail.service.ts#L10
Looks like we're initialising the mail service even if SendGrid tokens aren't available/are empty?
It would be nice if we only set the API Key if it's not an empty string/null.
Product Flavor

[ ] Managed (https://rxresu.me)
[X] Self Hosted

Got it, will fix this in an upcoming commit.


[ASCII-1604] Improve logging around secrets resolving and forwarder initialization

What does this PR do?

Improve logging around secrets resolving and forwarder initialization.
Motivation

We've observed cases where the forwarder seemed to start before secrets were resolved.
We noticed that there were very few logs showing what happened in secrets, which prevented having an quick understanding of what starts when.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge