Unable to connect with self-signed certificate

I'm trying to set up a client and server locally on my machine using a self-signed certificate generated with openssl. The server setup is copied from the readme, and the client initiation is rsp, conn, err := d.Dial(context.Background(), "https://localhost:443/webtransport", nil). The error I'm getting is "CRYPTO_ERROR 0x12a (local): tls: failed to verify certificate: x509: certificate signed by unknown authority" on the Dial call. Is there some other configuration I'm missing?

This is unrelated to WebTransport. You'll get exactly the same error when using crypto/tls over TCP with your certificate configuration.

Part of the reason I selected WebTransport was because it was supposed to be able to support connections using self-signed certificates through the certhash: https://blog.libp2p.io/2022-12-19-libp2p-webtransport/#meet-webtransport
I'd also like to connect via QUIC, not TCP, and from the readme it should be opening a UDP port on 443. Is this not the case?

Part of the reason I'm investigating WebTransport was because it was supposed to be able to support connections using self-signed certificates through the certhash: https://blog.libp2p.io/2022-12-19-libp2p-webtransport/#meet-webtransport

There seems to be some severe confusion here. This applies to the browser API only.

This doesn't appear to be specified in the RFC, and none of the documentation makes mention that this is only a browser behavior. If non-browser clients are explicitly not supported, then can this at least be reflected in the documentation?

This is wrong again.
I encourage you to read the RFC and the W3C specification, and to familiarize yourself with crypto/tls.

I understand that much of the reference material discusses browsers as this is the primary targeted use case. I have not seen mention that non-browser clients are explicitly not supported though. I've reviewed these references in addition to the first link I posted:
https://www.w3.org/TR/webtransport/#certificate-hashes
https://github.com/libp2p/specs/tree/master/webtransport
https://datatracker.ietf.org/doc/draft-ietf-webtrans-http3/
The closest I've found that any come is this:

The most exciting feature for libp2p (other than the numerous performance benefits that QUIC gives us) is that the W3C added a browser API allowing browsers to establish connections to nodes with self-signed certificates

I get that it specified "browser API allowing browsers", but much of the documentation uses the terms browser and client interchangeably and prior to this conversation, I haven't seen anything differentiate between browser clients and non-browser clients. If that's the case, that's fine, and I'll look into other approaches, but could I at least propose adding a line to the readme stating that non-browser clients are not permitted to use self-signed certs?

This is wrong again. Browsers are supported.

I think there was some miscommunication here. I'm not saying browsers aren't supported, just that it was unclear this was a browser-only feature based on what I'd reviewed.

I understand that much of the reference material discusses browsers as this is the primary targeted use case. I have not seen mention that non-browser clients are explicitly not supported though.

You haven't seen this because this is not correct. As I said before, the behavior you're seeing is equivalent to what you'd see when using crypto/tls. WebTransport isn't doing anything special regarding certificate verification, it just uses the Go standard library crypto/tls package, giving you all the flexibility that comes with that. Please refer to the documentation of the standard library.
Specifically, if you want to accept self-signed certificates, you need to set InsecureSkipVerify to true, and implement certificate verification yourself. See the go-libp2p implementation for how to verify certificate hashes.

Is use of the certhash endpoint a browser-only feature or not? In this reply, you state "This applies to the browser API only." But now you're saying that my statement that non-browser clients are explicitly not permitted to use the certhash endpoint is incorrect.

Non-browsers are free to implement whatever certificate validation logic they please.

But the library doesn't come with support for it and this is a conscious design choice correct?

Support for what?

Using the certhash endpoint as an alternate means of validating a certificate.

You're confusing the layers here. webtransport-go doesn't concern itself with certificate verification. It is simply an implementation of the IETF draft.

I see. I was mistaking links in the connectivity page. This appears to be what I was looking for. Apologies for the confusion.

No worries, I know it's a bit confusing having one IETF and one W3C WebTransport spec.


Some websites seem to not render fonts correctly

Example: https://mrchromebox.tech/#home
Must be missing fonts or something

In this case it was ttf-adobe-fonts that fixed it


[Server] - API interface - Implementation

Pull Request check list

[ ] Proper tests/regressions included?
[ ] Documentation updated?

Affected functionality

Description of change
Defined the Server and made the Server implement (dummy initially) functions for the API
Which issue this PR fixes

@jufantozzi I think this PR is a bit outdated. Does it still make sense to leave it open?

@thisab you're right, we can close this


database configuration mismatch with '--tmpdir=/tmp/user/$USER/libpod/tmp'

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Not able to change path to the tmp directory for libpod state content
Steps to reproduce the issue:

podman --tmpdir=/tmp/user/$USER/libpod/tmp info --debug

Describe the results you received:
podman --tmpdir=/tmp/user/$USER/libpod/tmp info --debug
Error: could not get runtime: database libpod temporary files directory (tmpdir) "/run/user/1000/libpod/tmp" does not match our libpod temporary files directory (tmpdir) "/tmp/user/mdhillon/libpod/tmp": database configuration mismatch
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Same issue is reproducible on podman v1.8.1
Output of podman version:
podman version 1.8.0

Output of podman info --debug:
podman info --debug
debug:
  compiler: gc
  git commit: ""
  go version: go1.13.6
  podman version: 1.8.0
host:
  BuildahVersion: 1.13.1
  CgroupVersion: v2
  Conmon:
    package: conmon-2.0.1-1.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.1, commit: 5e0eadedda9508810235ab878174dca1183f4013'
  Distribution:
    distribution: fedora
    version: "31"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>6
  OCIRuntime:
    name: crun
    package: crun-<IP_ADDRESS>-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version <IP_ADDRESS>
      commit: cd7cea7114db5f6aa35fbb69fa307c19c2728a31
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>6
  SwapTotal:<PHONE_NUMBER>0
  arch: amd64
  cpus: 16
  eventlogger: journald
  hostname: localhost.localdomain
  kernel: 5.3.7-301.fc31.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.3+dev
      commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e
  uptime: 543h 54m 19.25s (Approximately 22.62 days)
registries:
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /home/mdhillon/.config/containers/storage.conf
  ContainerStore:
    number: 94
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.6.4-2.fc31.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.6.4
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /home/mdhillon/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 154
  RunRoot: /run/user/1000
  VolumePath: /home/mdhillon/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.8.0-2.fc31.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
NAME=Fedora
VERSION="31 (Workstation Edition)"
ID=fedora
VERSION_ID=31
VERSION_CODENAME=""
PLATFORM_ID="platform:f31"
PRETTY_NAME="Fedora 31 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:31"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f31/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=31
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=31
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

The reason for this error is that, if we move part of Libpod's state but not all of it (the static content - database, container images, etc) we can end up with undesired behavior. We'd end up with content from running containers in the old temporary directory missing, for example. Furthermore, Libpod detects reboots by checking a file in the temporary directory, so assigning a new directory would invoke our reboot handling, which would wipe the state on the assumption that all running containers cannot be running anymore because the system rebooted.
Can I ask what you're trying to do here? There are ways around this, but knowing what's needed would help understand how.

Unprivileged users need to run rootless container in kubernetes pods. Users don't have access permissions to /run/user/$(id -u) path due to security policy. So we need to change this to /tmp/user/$(id -u) .

@rhatdan Do we have anything in containers.conf to fix this?
For now, I recommend that you remove the libpod database and files at ~/.local/shared/containers/storage/libpod (which will also remove all containers for the user - unfortunate, but necessary to ensure no breakage). Then, run one Podman command with --tmp-dir set - this will write the new location in the database when it is recreated, and all subsequent Podman calls will use the new path.
You may also wish to set --runroot - I think that may also live in /run/user by default

Still the same issue: could you please test on your setup
Error: could not get runtime: database libpod temporary files directory (tmpdir) "/run/user/1000/libpod/tmp" does not match our libpod temporary files directory (tmpdir) "/tmp/user/mdhillon/libpod/tmp": database configuration mismatch

Something must be recreating the database before the Podman command. Can you verify that ~/.local/share/containers/storage/libpod/bolt_state.db exists? I wonder if your Podman isn't using another directory for the database

Your are correct I am using /b/workspace/.local/share/containers/storage/libpod :) . tmpdir issue got fixed by cleaning up this path. But now I am stuck on this https://github.com/containers/libpod/issues/5488


Update release process to include updating homebrew formula

Spin is now installable via brew! During releases, we should update the homebrew formula to point to the latest release artifacts.
ref #641

@vdice From my understanding, it is common practice to only support one Homebrew formula, namely the latest version of the project. If you want to support earlier versions ("pinned version formulas"), they become separate formula (like you mentioned) and you cannot simply brew upgrade to get the latest. For example, notice how Nomad's install instructions for macos only provide homebrew as an option for latest release; otherwise, you have to do a binary install: https://developer.hashicorp.com/nomad/docs/install.
in contrast, postgres releases each version as it's own package: https://www.postgresql.org/download/macosx/. Latest postgres is version 15; however if i install 14 and then brew upgrade, i stay on 14:
$ brew install postgresql@14
$ brew upgrade
$ brew list | grep postgresql
postgresql@14
$ brew install postgresql@15
$ brew list | grep postgresql
postgresql@14
postgresql@15

The only way to upgrade is to uninstall the old version and instal the new one (otherwise you get two installs) -- very unideal
My main concern here is that for some reason someone installs an older version and never moves up. But like you mention, we could take the hybrid approach and have latest always in spin.rb and then keep older versions as pinned. I'm happy with that. We should also have a retirement plan in that case -- aka we will only support the last X versions... but we probably arent there yet

@vdice I don't think it would be too hard to manage (just extra .rb files) -- i just feel there may be a reason that many other projects only support latest ... maybe to encourage that upgrade story? I do feel like we will hit this question actually in a week when we release 1.5

@vdice issue to track on supporting other versions https://github.com/fermyon/homebrew-tap/issues/7


Images posted to server via fetch get their size inflated significantly

React Native version:
System:
OS: macOS 10.15
CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
Memory: 181.84 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh

Binaries:
Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
Yarn: 1.17.3 - /usr/local/bin/yarn
npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman

SDKs:
iOS SDK:
  Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0

IDEs:
Xcode: 11.1/11A1027 - /usr/bin/xcodebuild

npmPackages:
react: 16.8.1 => 16.8.1
react-native: 0.61.3 => 0.61.3

react-native-cli: 2.9.0
Description
After upgrading to RN 0.61.3, we observed that the hash of an image received on the server differs with the hash of the original picture on the phone.
The size is actually inflated significantly
jpg on the phone: 264KB
jpg received on the server: 628KB
This issue happens on iOS (13.1 tested only)
No issue detected on Android
Downgrading to 0.59 fixes the issue.
_body
  const formData = new FormData()
  formData.append(`files`, {
    uri: 'file://' + filepath,
    name: 'test.jpg',
    filename: 'test.jpg',
    type: 'application/octet-stream'
  })

Headers
      {
        Accept: 'application/json',
        // doesn't work with 'application/octet-stream' neither
        'Content-Type': 'multipart/form-data'
      }

Request
  // prepare form data
  // send post request
  fetch(`http://localhost:3000/upload`,
  {
    method: 'POST',
    headers: {
      Accept: 'application/json',
      // doesn't work with 'application/octet-stream' neither
      'Content-Type': 'multipart/form-data'
    },
    body: formData
  }).then(resp => {
    console.log('success: ' + JSON.stringify(resp))
  }).catch(err => {
    console.log('error: ' + err.message)
  })

The image size is unchanged until it is posted.
Image received by the server is modified.
Steps To Reproduce
Clone test repository
https://github.com/ivzeus/test-uploader
Start local node server to receive file uploads
The server sample is based on this repository
# in project root
cd server
npm i
node ./server.js

It starts a server at localhost:3000 and accepts file upload through /upload POST request. Uploaded files will be stored in server/uploads folder.
Run ReactNative sample
This sample was created by initializing a blank React Native project
To run the demo:
# in project root
npm i
cd ios
pod install
cd ..
npm run ios

First click on DOWNLOAD IMG and DOWNLOAD BIN to save an image and a binary file to app storage (original image size: 260,062 bytes)

Then try clicking on UPLOAD IMG or UPLOAD BIN and observe the server console

Notice how the image file has been changed when uploaded, but not the binary file (new image size: 718,367 bytes)

We are now refactoring using rn-fetch-blob instead of axios.

same happens with me when trying to convert image to blob to send over network:
const img = await fetch(MY_IMAGE_URI);
const blob = await img.blob();
console.log(blob.size);

the blob size is 2x the size of the original picture. The problem appears to only affect ios. Android is fine.
I now use react-native-fetch-blob to work around this.

We are now refactoring using rn-fetch-blob instead of axios.

Hey @thmsl Could you please offer some insight into why this change was made?
Also, if we don't want this size increase how would you suggest we prevent it?

Facing the same issue on iOS. Uploaded image with fetch is inflated and loses all its metadata, what's going on? Why is the file even tampered with?

the reason is that：when we upload a jpg image，react native will use RCTImageLoader to load the image , in RCTImageLoader:

(id)sendRequest:(NSURLRequest *)request withDelegate:(id)delegate
{
__block RCTImageLoaderCancellationBlock requestToken;
requestToken = [self loadImageWithURLRequest:request callback:^(NSError *error, UIImage *image) {
if (error) {
[delegate URLRequest:requestToken didCompleteWithError:error];
return;
}
  NSString *mimeType = nil;
  NSData *imageData = nil;
  if (RCTImageHasAlpha(image.CGImage)) {
      mimeType = @"image/png";
      imageData = UIImagePNGRepresentation(image);
  } else {
      mimeType = @"image/jpeg";
      imageData = UIImageJPEGRepresentation(image, 1.0);
  }

  NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL
                                                      MIMEType:mimeType
                                         expectedContentLength:imageData.length
                                              textEncodingName:nil];

  [delegate URLRequest:requestToken didReceiveResponse:response];
  [delegate URLRequest:requestToken didReceiveData:imageData];
  [delegate URLRequest:requestToken didCompleteWithError:nil];

}];
return requestToken;
}

when a jpg image upload,RCTImageLoader will use UIImageJPEGRepresentation(image, 1.0) to get the blob ,while UIImageJPEGRepresentation function get the size is different of the origin image size.that the reason why jpg image size is different, png size is same

Why does react native need all that? Can't it just treat the image as a
regular file? Loading the whole image in memory and doing professing on it
is definitely a bad idea; it should be treated as any file.
El sáb., 21 de marzo de 2020 06:00, MrZhaoCn<EMAIL_ADDRESS>escribió:

the reason is that：when we upload a jpg image，react native will use
RCTImageLoader to load the image , in RCTImageLoader:

(id)sendRequest:(NSURLRequest *)request withDelegate:(id)delegate
{
__block RCTImageLoaderCancellationBlock requestToken;
requestToken = [self loadImageWithURLRequest:request
callback:^(NSError *error, UIImage *image) {
if (error) {
[delegate URLRequest:requestToken didCompleteWithError:error];
return;
}
 NSString *mimeType = nil;

 NSData *imageData = nil;

 if (RCTImageHasAlpha(image.CGImage)) {

     mimeType = @"image/png";

     imageData = UIImagePNGRepresentation(image);

 } else {

     mimeType = @"image/jpeg";

     imageData = UIImageJPEGRepresentation(image, 1.0);

 }

 NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL

                                                     MIMEType:mimeType

                                        expectedContentLength:imageData.length

                                             textEncodingName:nil];

 [delegate URLRequest:requestToken didReceiveResponse:response];

 [delegate URLRequest:requestToken didReceiveData:imageData];

 [delegate URLRequest:requestToken didCompleteWithError:nil];

}];
return requestToken;
}
when a jpg image upload,RCTImageLoader will use
UIImageJPEGRepresentation(image, 1.0) to get the blob ,while
UIImageJPEGRepresentation function get the size is different of the origin
image size.that the reason why jpg image size is different, png size is same
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/27099#issuecomment-602016225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALU263F3JJ4PEOHEUCNHDOLRIR63VANCNFSM4JIOYWIA
.

https://stackoverflow.com/questions/56682109/react-native-through-upload-image-on-s3-bucket-using-aws-sdk

add node-module 'base64-arraybuffer'

yarn add base64-arraybuffer

import {decode} from 'base64-arraybuffer';

 const base64 = await RNFS.readFile(filePath, 'base64');
  // console.log('base64', base64); //get base64 data

  const arrayBuffer = decode(base64);
  //console.log('arrayBuffer', arrayBuffer.byteLength);

 await Storage.put(uploadPath, arrayBuffer, {
    progressCallback(progress) {
      image.progress = (progress.loaded / progress.total) * 100;
      // dispatch or setState image progress
    },
    contentType: mime,
  })

@cristianoccazinsp Did you succeed to fixe it or found a workaround ?

@MayoudP I ended up using rn-fetch-blob to upload files.

@MayoudP I ended up using rn-fetch-blob to upload files.

I wasn't able to make this library works with a pre-signed URL for an upload on S3... By any chances, do you have any snippet code or example ?

Actually, now that I look again, I'm using https://github.com/Vydia/react-native-background-upload (my own fork actually https://github.com/cristianoccazinsp/react-native-background-upload) for iOS uploads, and regular fetch for Android.
I don't have an AWS example, but it shouldn't be any different, just a bunch of headers/query string parameters.

My workaround using expo-file-system
  // Workaround for https://github.com/facebook/react-native/issues/27099
  if (Platform.OS === 'ios' && blob.type === 'image/jpeg') {
    const originalUri = uri;
    uri = `${FileSystem.documentDirectory}resumableUploadManager-${fileName}.toupload`;
    await FileSystem.copyAsync({ from: originalUri, to: uri });
    blob = new Blob([await getBlobForUri(uri)], { type: 'image/jpeg' });
  }

Stale-bot, it looks like there hasn't been an official fix or workaround. 🙂

Hello everyone in the future still struggling with this. I was struggling with a similar issue trying to upload images to AWS S3 through a PreSigned PUT URL with metadata (specifically EXIF data like GPS coordinates). RNFS uploadFiles doesn't play nicely with signed S3 urls, so I was trying to use the built in XMLHttpRequest. I was able to upload files, but their metadata was just being silently removed due to things discussed earlier in this thread. Following through on @ganzik83 's train of thought, I was able to finally get metadata to stick through the upload process by converting the image to base64, fetching the base64, converting the result of the fetch into a blob, and then uploading that blob. The code ended up looking like this:
import RNFS from 'react-native-fs';

const uploadImageToSignedURL = async (signedURL, imagePath) => { // NOTE: In my case, Signed URL was configured with Content-Type: 'image/jpeg'
        const getBlob = async (fileUri) => {
            const base64 = await RNFS.readFile(fileUri, 'base64');
            const resp = await fetch(`data:image/jpeg;base64,${base64}`);
            const imageBody = await resp.blob();
            return imageBody;
        };

        const uploadImage = async (uploadUrl, imagePath) => {
            const imageBody = await getBlob(imagePath);

            return fetch(uploadUrl, {
                method: "PUT",
                body: imageBody,
            });
        };

        return uploadImage(signedURL, imagePath)
}

@ShogunPanda is this definitely resolved in 0.64.2? I can't find anything about it in the release notes! I'm not 100% sure I want to do the workaround you've posted as seems a bit hacky which could result in future bugs 😬

@simonmitchell It is hacky. :)
Unfortunately I couldn't update the project I'm currently on so I have no idea if 0.64.2 fixes for real or not. I trust RN devs on this.

I tried in the end @ShogunPanda and seemed not to be fixed :( I think I'll go for hacky solution for now and try and keep an eye on when this issue is resolved! Thanks for the help ☺

It seems this issue still exist on latest react-native version 0.65.1

It's fixed in 0.66 (https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0660)

I'm experiencing this issue on react-native 0.66.4

Having the same issue on 0.66.4. Looks like the fix was reversed pretty quickly, so I'm wondering if it ever actually got included in a release...

This is indeed still an issue in the latest release. It only happens when you have a file uri that has the jpeg extension however, as beautifully found out by @MrZhaoCn.
I find the easiest solution to be to rename the file with RNFS
const newUri = originalUri.replace(/\.jpe?g$/i, '.bin');
await RNFS.moveFile(originalUri, newUri);


fix(ci): Set package access level to public.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve documentation of the libwdog supervisor API

Implements the changes proposed in https://github.com/troglobit/watchdogd/discussions/33
Signed-off-by: Andreas Helbech Kleist<EMAIL_ADDRESS>

lgtm. I'll probably build on this later, for the next release, adding to the ci pipeline and setting up some host (probably https://codedocs.xyz/) to publish.  Thanks so much for this, very appreciated!


Some missing test coverage

In this PR, I made a few mistakes that weren't caught by tests: https://github.com/quantopian/zipline/pull/1327
We should have some tests for those code paths.  One is a method that creates mock daily data, and another handles when overwrite_sim_params is True.

Those issues were actually caught by the new test I added here: https://github.com/quantopian/zipline/pull/1313
The one with sim_params was for Panel data, which hasn't had a a test that actually runs an algorithm before this PR.
The one with create_daily_df_for_asset was caught incidentally, since the test algo got to the second bar and expected to be able to look back a full day. So that part might deserve its own new test.


Add documentation for how to use actors with the go-sdk

Actors support is now available in the go-sdk. Let's add the necessary documentation on how to use actors with the sdk.
Content should be located in the daprdocs directory of the repo, which will appear here: https://docs.dapr.io/developing-applications/sdks/go/. It should look similar to how other sdks approached this: https://docs.dapr.io/developing-applications/sdks/python/python-actor/

Shall I pick this?

@saranvasu - Are you still interested in creating any docs here?

@msfussell I'd be interested in writing the docs if I had an example to go by.

Ok - I'm a dummy.  I see it in the examples/ folder.

Addressed by #431


rapidjson: make compatible with C++20

(by stealing the relevant patch from Fedora)

Motivation for this change
upstream does not compile with C++20
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 120235 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.kalzium
python39Packages.google-cloud-bigquery

57 packages built:

arrow-cpp
ccls
clickhouse
discord-rpc
gawk-with-extensions
gawkextlib.json
geonkick
hal-hardware-analyzer
ja2-stracciatella
kodi (kodiPackages.kodi)
kodi-gbm
kodi-wayland
kodiPackages.a4ksubtitles
kodiPackages.inputstream-adaptive
kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.joystick
kodiPackages.kodi-platform
kodiPackages.netflix
kodiPackages.pvr-hdhomerun
kodiPackages.pvr-hts
kodiPackages.pvr-iptvsimple
kodiPackages.steam-controller
kodiPackages.vfs-libarchive
kodiPackages.vfs-sftp
laminar
libsForQt5.kalzium (libsForQt515.kalzium ,plasma5Packages.kalzium)
libsForQt5.mapbox-gl-native (libsForQt515.mapbox-gl-native ,plasma5Packages.mapbox-gl-native)
libsForQt5.mapbox-gl-qml (libsForQt515.mapbox-gl-qml ,plasma5Packages.mapbox-gl-qml)
libsForQt512.mapbox-gl-native
libsForQt512.mapbox-gl-qml
libsForQt514.kalzium
libsForQt514.mapbox-gl-native
libsForQt514.mapbox-gl-qml
monero
monero-gui
mysql-workbench
openbabel (openbabel3)
pure-maps
python38Packages.awkward
python38Packages.datasets
python38Packages.google-cloud-bigquery
python38Packages.intake
python38Packages.openbabel-bindings
python38Packages.pyarrow
python38Packages.rdkit
python39Packages.datasets
python39Packages.intake
python39Packages.openbabel-bindings
python39Packages.pyarrow
python39Packages.rdkit
rapidjson
sortmerna
vowpal-wabbit
wownero
yuzu-ea
yuzu-mainline


option to resolve alerts that fired inhibited

Added new option to let resolve notifications flow from inhibited
alerts, if they fired unmuted.
Attempts to address #226

Any movement on this? A feature we desperately need!

Hi @edevil 👋
This change is interesting for us and probably for many others, possibly even important. Is there any progress with this pull request? Or is there something delaying the merge? Thank you 🙂

Adding onto this, would really really love to see this get merged into a release. Real bummer this has been stale for so long, this would be a huge feature for my org.

Adding onto this, would really really love to see this get merged into a release. Real bummer this has been stale for so long, this would be a huge feature for my org.
@edevil If you aren't interested in cleaning up the merge conflicts here, I'm happy to take a stab at this.

@edevil If you aren't interested in cleaning up the merge conflicts here, I'm happy to take a stab at this.

At this point I have resolved conflicts several times. I would like some signal from the maintainer that there is a path forward otherwise it is time wasted.

I reached out in the #prometheus-alertmanager channel on the CNCF Slack asking for some maintainer eyes. It worked for me with OpenTelemetry so figured it was worth a shot ¯_(ツ)_/¯

@gotjosh sorry to bug ya but any chance we can push this forward?

I reached out in the #prometheus-alertmanager channel on the CNCF Slack asking for some maintainer eyes.

was there a response on this?
i don't understand what's blocking this PR from being merged. in https://github.com/prometheus/alertmanager/issues/226#issuecomment-725597523, @brian-brazil seemed to object to having a configuration option for this in the first place, and there were lots of different ideas in that thread...
i'm just not sure exactly what the way forward is, but i do know that it's pretty confusing that inhibited/silenced alerts don't show resolution, as the recipient of those notifications.


This PR implements the NopCloser()-like function NopReadSeekCloser() and some other cleanups related to the removing of isReallyNil().

Fixes #2922
Supersedes #3120

@krnowak thanks a lot for chiming in! o/ :-) I just took over, and you are very right in your assertion regarding the above leaks, thanks!

build failures are caused by a known flake TestNetDefaultRestrictedConnectivity, hence merging.


Make version documentation clearer.

Now in pubspec.yaml, semver.org is refered for more about versioning.
However, versionCode/versionName could differ on different platforms(iOS,Android,Dart).
So I think more clear and complete information could help users to understand it better.
See: https://github.com/flutter/flutter/issues/27251

Thanks for the PR! Fix that minor change I suggested, and I'll commit it.

@gspencergoog
Done.


v22.8.16 clean main YAML configs

Current coverage is 100% (diff: 100%)

Merging #684 into master will not change coverage

@@           master   #684   diff @@
====================================
  Files          29     29
  Lines         439    439
  Methods       111    111
  Messages        0      0
  Branches        0      0
====================================
  Hits          439    439
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update a4c49c3...94bd7b5


Create vccs

@Shay-repos lib/domains/edu/vccs/email: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Shay-repos lib/domains/edu/vccs/email: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Shay-repos lib/domains/edu/vccs/email: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Shay-repos This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


community: Advanced filtering for HANA Cloud Vector Engine

Description:
This PR adds support for advanced filtering to the integration of HANA Vector Engine.
The newly supported filtering operators are: $eq, $ne, $gt, $gte, $lt, $lte, $between, $in, $nin, $like, $and, $or

Issue: N/A

Dependencies: no new dependencies added

Added integration tests to:
libs/community/tests/integration_tests/vectorstores/test_hanavector.py
Description of the new capabilities in notebook:
docs/docs/integrations/vectorstores/hanavector.ipynb

Thanks @baskaryan for approving this PR.
I have another PR on HANA Vector Engine open since more than 3 weeks (https://github.com/langchain-ai/langchain/pull/19922). Would you mind taking a quick look at that one? If there's something that I need to change in that other PR, I'm happy to do it. But currently I simply don't know what I am expected to do.


Fix Bug 63455 (XPath Assertion: "True if nothing matches" does not work if XPath expression returns a boolean)

Description
UbikLoadPack team is happy to contribute this bugfix to JMeter.
Twitter: @ubikloadpack
Blog: https://www.ubik-ingenierie.com/blog/
Youtube channel: https://www.youtube.com/channel/UCUv5MHnWDyD-bDkRgOr5lmw
Motivation and Context
It fixes :

https://bz.apache.org/bugzilla/show_bug.cgi?id=63455

It also:

Clarifies the
Moves up the Validate button and the "Invert"

How Has This Been Tested?
JUnit test case + manual testing
Screenshots (if appropriate):
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.

Codecov Report

Merging #460 into trunk will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##              trunk     #460      +/-   ##
============================================
- Coverage     53.36%   53.34%   -0.02%
+ Complexity     9294     9292       -2
============================================
  Files           996      996
  Lines         61235    61235
  Branches       6900     6900
============================================
- Hits          32680    32668      -12
- Misses        26160    26173      +13
+ Partials       2395     2394       -1

Impacted Files
Coverage Δ
Complexity Δ

...s/org/apache/jmeter/assertions/gui/XPathPanel.java
57.14% <100%> (ø)
11 <0> (ø)
:arrow_down:

src/core/org/apache/jmeter/util/XPathUtil.java
65.66% <100%> (+1.28%)
47 <0> (+3)
:arrow_up:

...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java
54.83% <0%> (-2.16%)
15% <0%> (ø)

.../jmeter/protocol/http/sampler/HTTPSamplerBase.java
66.21% <0%> (-1.75%)
203% <0%> (-5%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76fd79...10f15f3. Read the comment docs.

Hello,
Any update on this PR ?
Regards
Philippe

Hello,
I'll merge PR this evening unless there's a volunteer.
Regards


Fix reading output when all child processes exited

Reproducible with e.g. alacritty -e ls (app panics when reading
output).
Hopefully this won't break #14.

Thanks for the PR!
I thought we might solve this in a little different way. The error handling in the event loop was only ever half finished, so I've gone ahead and cleaned it up in #505. Swapping the hup check to the front of event handling prevented either a panic or error condition from being hit in the first place.


Issue 111

Fix for issue 111.
It can happen sem_wait to return -1 and EINTR errno is set. We retry in this case.

Adding _GNU_SOURCE compile flag
Use GNU macro TEMP_FAILURE_RETRY to retry on EINTR
Change errno setting from EINTR to EBADF

I don't like the -DUSE_GNU=1 ...
Anyways, I think the other changes are nice and a must have.


Player does not test against codec attribute

Hello,
While High Sierra is not out of beta yet, one of the things I'm working towards here is getting H.265 support in for devices that support it.
http://seventhcycle.net/mejs/codectest/
You'll see here that the video does not play since there is not h265 support for the 2160p variant here.
http://seventhcycle.net/mejs/codectest/?nome
On the other hand, you'll see if MediaElements is not called, the regular HTML5 player properly falls back to the next item in the list - 1080p.
Are there any flags to let MEJS emulate this behavior?
There are secondary constraints to think about, too.
For example, an iPhone may not be able to play back 4k content. Ideally, it should load the next format.
Note: If you know offhand the codec string to use for HEVC / mp4, that would be very, very helpful :) But in any case, this example should still work without the proper string. The main issue here is that the codec attribute is being ignored.

Hi. The player should do it automatically but in this case since it requires to know the codec it doesn't move to the next item. I'll check what's needed to include it and keep you posted. Thanks foe reporting this

If you download the master branch and test it with this and other scenarios, let me know if it solved your issue completely. Seems that we don't need to standardize the MIME type anymore given the new way we are doing things. Please let me know and thanks again

Hi,
Okay, it looks like the player is properly detecting the codec hint now. I'm still not able to play HEVC in browser on the MacOS beta, but I think that's on Apple's side. :)
I found a related issue when it comes to fallback players.
MEJS: http://seventhcycle.net/mejs/codectest/
HTML5: http://seventhcycle.net/mejs/codectest/?nome
In this example, all of these are H.264 videos. There's a 4k video on top, followed by 1080p, 720p, etc.
In the HTML5 example on iOS 10, the browser is able to tell that the video is 4k, and is beyond the playback capabilities of the device/OS. Therefore, it falls back to the 1080p version.
In the MEJS example on iOS 10, it tries to play the 4k version, and fails.
(In the MEJS example on iOS 11 beta, it can play the 4k version. Just letting you know in case you are on the beta).
Can you take a look on your end?

Thanks for reporting this however starting today I won't be maintaining this project anymore. I appreciate the time you spent testing this and reporting things back

I'll check this as my last task later and if I have the fix I'll push it tonight, but it won't go until the next release

As an update: iOS consider flagged that media with maybe and it tries to play it. IDK exactly how Safari attempts to do it, but it won't be easy for the player to detect this. One solution you can implement is to put a conditional around that particular file for Safari 11 on iOS so it is accessible:
var txt = '<video style="width:640px; height:360px;" id="mediabox_inline" autoplay="true" >' + "\n";
		if (!mejs.Features.isiOS || (mejs.Features.isiOS && mejs.Features.isSafari && /Version\/11/i.test(window.navigator.userAgent))) {
		    txt += "  <source type='video/mp4; codecs=\"hevc.42E01E, mp4a.40.2\"' src=\"http://seventhcycle.net/mejs/codectest/out/2160p-h264.mp4\" />\n"
        }
        txt += "  <source type='video/mp4; codecs=\"avc1.42E01E, mp4a.40.2\"' src=\"http://seventhcycle.net/mejs/codectest/out/1080p-h264.mp4\" />\n"
			+ "  <source type='video/mp4; codecs=\"avc1.42E01E, mp4a.40.2\"' src=\"http://seventhcycle.net/mejs/codectest/out/720p-h264.mp4\" />\n"
			+ "  <source type='video/mp4; codecs=\"avc1.42E01E, mp4a.40.2\"' src=\"http://seventhcycle.net/mejs/codectest/out/480p-h264.mp4\" />\n"
			+ '</video>';

Just to clarify here, the example that's here (2160p-h264.mp4) should be using codec avc1.42E01E, mp4a.40.2, not hevc.42E01E, mp4a.40.2.
I don't know if it's a typo up above, or if you tested against that codec.
I had changed the page for that example so that all of the videos are using h264. The issue here is that certain devices are resolution constrained.
Is it possible to send hints on what the video resolution is within the source? Or at least make it where it tries the next video if playback fails?
Please let me know if there's anybody else I should tag that does maintenance on the project. Thanks.

I tested under that codec. As far as resolution wise it currently can't send this within the player; may be work on your side to determine the proper sources based on resolution by creating the video tag as you are doing with different sources

If there are no more issues can you close this one please?

Hi,
Realistically, I'm thinking here that detection isn't the solution. I think the bigger problem here is that the player isn't skipping to the next source if it can't play. Fixing codec detection was a partial solution.
This code example was really helpful in making the fallback work:
https://gist.github.com/rafa8626/2ce220b30b7e2ef2dc2e277df6a697ce
I'm at a point where I can move forward on my end. Thank you so much!
I'm curious, though. Shouldn't this behavior be the default? It would be closer to the behavior of the HTML5 player.
Or, if even this wasn't the default behavior for MEJS, perhaps an attribute such as "auto_fallback" that automatically does this if the movie does not load?
I imagine this will help the next person who comes along.
Anyhow, thank you so much for your time and work on this.

Probably yes but it should be in the future. Thanks for reporting this and you are welcome

Can you test the master branch again, please? I was curious about how the browsers handle this and I think I was able to replicate their behavior inside the core, so at least native files will have this behavior. Let me know

http://seventhcycle.net/mejs/4k_h265/
Good news is that it seems to automatically failover on Safari.
Bad news is that on Chrome (mac), it is skipping the 1080p option and going straight to 720p.
Also, on both Safari / Chrome, MEJS isn't honoring the style tag determining the size of the player.
Looks like a fairly recent regression.

Ok I'll doble check. What is the style tag that is not being honored?

Nevermind I see what you mean. I'll check this in a moment

@SeventhCycle ready both issues are fixed now. Please download the master branch and confirm this. Thanks for testing this again

I went ahead and tried the following URLs on iOS and Mac
http://seventhcycle.net/mejs/4k_h264/
http://seventhcycle.net/mejs/4k_h265/
It looks good and doesn't have any issues on Chrome / Firefox / Safari.
If you have access to a Windows machine or image, can you try the URLs on Windows browsers? If it plays fine, you should be able to close this out.

I will try on Browserstack with edge and IE11 but I suspect it will work fine. Thanks for testing this again

As I suspected, everything is working on Windows as well. Thanks again and good catch

Many thanks! I'm going to go ahead and close this out for now.
I'll do some more tests once I can properly get High Sierra and Safari working with HEVC. I'll re-open or submit a new ticket if any issues come up.
Thanks again!

Actually, looks like there's an issue with HLS. I went ahead and created an example here:
MEJS:
http://seventhcycle.net/mejs/hls/
Native:
http://seventhcycle.net/mejs/hls/?nome
Here, I have two HLS files: one using mp4 fragments and H264. The other with mp4 fragments and H265.
Since the H265 is unplayable, it should fall over to the H264 stream.
Let me know if you need any better examples here.

Thanks this example will be enough. I'll take a look and keep you posted

I tried to test this in my local machine but is giving me CORS error, can you help me with that please?

Also, I tried the native example on Safari 10.1.2 and it doesn't work

@rafa8626 What should I do on my end to help with the CORS error? Would you like a zip of the folder?

Yeah a zipped file will be better

http://seventhcycle.net/mejs/hls.zip
Should include everything in the folder, including the build script I'm using to create these files.

Would you mind testing the master branch again with your example on Chrome, please? I just did an adjustment for the HLS media in browsers that need hls.js. I'll check this on Safari

No luck on my end testing Chrome on Mac.
Please let me know if there's anything else I can do on my end.

I don't know even I downloaded the scripts on Chrome they don't work. It says: no audio/video samples found which IDK why. Even on my Safari the example you sent it doesn't work on neither one of the files. I don't know what to do with this one

@rafa8626 Okay, I would say close this out for now. I'm going to try and come up with a better, more complete example of things once MacOS High Sierra is out of beta, and once I get H.265 / HLS working. That may take a while since I'm waiting on an FFmpeg fix.
Thanks for your help.


Implementations for new Enum API

The new Configmanager Enum API will return "originalName" & "displayName" for every enum value.
UI should show displayName in select-boxes and use original name for comparison and set original name in data for Configmanager.

Implemented in commit 111f379 on branch "enums"

branch "enums" can be merged into dev, we merged our pull-request into our dev


Move beta.packages to release.sbom_cyclonedx

resolves: #816

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f752b59) 100.00% compared to head (d4acaa5) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #847   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           91        89    -2
  Lines         4118      4117    -1
=========================================
- Hits          4118      4117    -1

Files
Coverage Δ

policy/release/sbom_cyclonedx.rego
100.00% <100.00%> (ø)

policy/release/sbom_cyclonedx_test.rego
100.00% <100.00%> (ø)


update libthrift to the version depended on by hive 1.1.0-cdh5.13.0

A few minor tweaks to hadoop classpath jars to reflect latest version of Hadoop, plus more importantly a bump in libthrift to a version which will work with hive.
Haven't tested this yet. How do you test new versions of uniform now? Do you use auto wrangler?

Hi @rowandavies @jdcba @andynygard could I get one more reviewer please?
Also want to talk with one of you about how to trickle down uniform changes to all the dependant projects until presumably we update etl plugin and these changes affect the actual Hadoop jobs.

Oh, sorry, didn't see Rowan's review before making my last comment ... thanks Rowan!

@rowandavies @andynygard based on the comments I'm thinking I'll merge this into master ... but what about trickling the version change to downstream projects and testing?
Do you just roll out changes into master, let auto wrangler do it's thing and hope everything works out ok? Or do you manually upgrade all the downstream dependencies and run a test job?

To automate it, we'll need to make a change in autowrangler, to support the cdh-513 branch suffixes.
Otherwise, it's a long and bumpy road 😓.

Alright, I'll take a look at that

Andy and I already went down the long and bumpy road all the way to etl-plugin and etl-util.  I don't get to touch code directly that much these days, so it was soothing for me, but enhancing autowrangler would be a better road.
I also started on bumping towards etl-template which sits above Maestro and is used by a good proportion of projects.   So, we'll need this at some point to test those.  Houston is done, but util.houston had an issue and I couldn't spend more time on it.


Hangs on "Reading Game Data"

Exactly what the title says. The app just hangs on reading the data.

You probably have some corrupt YML or similar. Open developer tools and see what the app says at startup/when reading data.

The package.json is missing the module js-yaml.

Which is still going on, even after I've installed it multiple times.

THe directory selected was wron;g; edited main.js and enabled devtools.  Devtools reported it couldn't load 'src/Config' which isn't in Ranviermud, but in Ranviermud/node_modules/ranvier (/src/Config) but when I select THAT directory, it says there are no bundles.

I managed to get it to work after rerunning npm install in both repos.

and then selecting what as the Specify your Ranvier repo directory ?
My directory structure is
/home/d3x0r/work/mud/

ranviermud (.git)

npm install
npm run init
npm run start ... mud server starts, and is able to be connected to.

soma (.git)

npm install

Neuro (.git)

using ranviermud
internal/modules/cjs/loader.js:602 Uncaught Error: Cannot find module '/home/d3x0r/work/mud/ranviermud/src/Config'
using ranviermud/node_modules/ranvier (which has src/Config)
then I get a popup

all up to date.  Arch linux.  Electron installs with system package manager.

I selected the root ranviermud directory (with .git and ranvier script)


Ref convenience methods

View RFC

Thanks for the RFC!
We have generally avoided convenience methods like this. There is a fixed cost for every extra field or lookup so it's not ideal from performance point of view if it can be avoided. It hides the meaning behind some indirection. If you know about the existence of this indirection, you might as well check for .current yourself. In my experience, people who don't check .current  also won't know to call .ifCurrent(). So I don't think this RFC would solve the issues outlined in the motivation. Combined with other concerns, I think it's not worth the benefit, but I appreciate you writing it up.


Composable config

Add a resolver that allows loading that part of the configuration from another yaml file.
For example:
train_dataset:
        _target_: torchvision.datasets.CIFAR10
        download: True
        root: ./.datasets/
        train: True
        transform: ${load_yaml: <YAML_PATH>}  # This line

Is it a good idea?

Now that we switched to monai bundle config, we get it for free https://docs.monai.io/en/stable/config_syntax.html#to-textually-replace-configuration-elements


Added Tests

Good work but @PunitLodha just write comments so that everyone knows what's going on in that part of code. It will helpful for you to refer the comments later.


annotations datasets format

Hello, what is the data format of annotations, I downloaded the kitti data but did not find this annotations

I think you want to know how to get the *.json ?  execute  kitti.py


ENG-2217 - fix: add polyfill for os module for webpack users

Description

Adds polyfill for os module
Bundle size increases around 1kb.

Testing required outside of automated testing?
Install this version of the package on a React project created w/ CRA

[ ] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.22.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Consider how to recover from all nodes going offline for an extended period

So far we're confident that this would challenge a lot of assumptions. This ticket is to give it some more direct attention. Specifically:

When would it be at all feasible to recover?
If ever, have we made any unnecessary assumptions that make that recovery more difficult/less possible?
Etc.

Some concrete motivating examples would be great to record as part of our conclusions.

3.5 years later, I think this Issue should now be interpreted as: re-assess the disaster recovery plan, which seems like a good thing for us to do with some coarse frequency.


Support Error Handling for All Relevant Endpoints

Need to Add Mocking support in Unit Tests.
Should research for best mocking dependency (Mockito, Retromock or Retrofit Mock Adapter)


[Streaming API] Key Manager Configurations are not shown in WebSocket runtime configurations

Description:
The key manager configuration box is not shown on the WebSocket runtime configuration page.  And the configuration box that's already there doesn't work
Steps to reproduce:

Create a WebSocket API
Goto Runtime configurations
Key Manager Configs are not shown

This is not a bug. This functionality was not supported since the beginning. And bringing in this requires changes in the gateway

Removed 4.0.0 as this is postponed.


Qiskit's execute function doesn't pass shots value to the device

Steps to reproduce the problem
aws_device = AwsDevice("arn:aws:braket:::device/quantum-simulator/amazon/sv1")
sim = AWSBraketBackend(device=aws_device)
qc = QuantumCircuit(1)
qc.h(0)
execute(qc, sim, shots=10)

What is the current behavior?
The circuit is executed with shots = 0 (which is the Braket SDK default)
What is the expected behavior?
The circuit should execute with shots = 10 (what is specified in the execute function).
Note: You can work around this by doing the following:
sim.options.update_options(shots=10)

Relevant code: https://github.com/Qiskit/qiskit/blob/main/qiskit/execute_function.py#L325

The deprecated function execute has been recently been removed from Qiskit. Instead, please use:
sim.run(qc, shots=10)

For more details, check out the documentation for running circuits on Braket devices.


[Bug]: Help search doesn't work

Bug Description
Hi
for some reason oh command returns empty result
when you type oh icon with search text briefly appears and then alfred fallbacks to default search
Debug log has non printing characters, i've attached screenshot
log.txt
Relevant Screenshot

To Reproduce
type oh
Debugging Log
Attached file in description

Workflow Configuration

Version & System Information
-------------------------------
INTERNAL WORKFLOW CONFIGURATION
Vault Path: /Users/Library/Mobile Documents/iCloud~md~obsidian/Documents/main
.obsidian: exists
Metadata JSONs: 4/4
metadata.json String Length: 246920
-------------------------------
WORKSPACE DATA
'workspace.json' exists
-------------------------------
SYSTEM
macOS: 13.3.1
Alfred: 5.1
-------------------------------
INSTALLED VERSION
Obsidian: 1.3.4
This Workflow: 3.9.4
Advanced URI Plugin: 1.35.0
Metadata Extractor: 1.1.0
-------------------------------
LATEST VERSION
Obsidian: 1.3.4 (Insider: 1.3.4)
This Workflow: 3.9.4
Advanced URI Plugin: 1.35.0
Metadata Extractor: 1.1.0
-------------------------------

Last working version
No response
Make sure you have done the following

[X] I have updated to the latest version of this workflow.
[X] I am using Alfred 5. (Alfred 4 is not supported by this workflow anymore.)
[X] I have updated to the latest version of the Metadata-Extractor and the Advanced URI plugin.
[X] If the o… main search does not work, I made sure that I haven't changed any of the default settings of the Metadata-Extractor. Furthermore, I have tried rerunning osetup and it still does not work.
[X] If notes in general can be found, but recently created or renamed notes cannot, I used the oupdate command to manually update the metadata.
[X] I have not renamed my Obsidian config folder, it's still .obsidian (About → Advanced → Override config folder).
[X] If I updated to version 3+ for the first time, I have disabled migrating workflow cutomizations. (If you haven't, you can simply re-download and install the latest release from GitHub and uncheck Migrate my workflow customizations.)

Could you use oupdate and run Re-Index Documentation Search, and then try oh again?

Sadly result is the same,  some characters appended before json: ]697;OSCLock=]697;PreExec

I've remembered that i had similir problem in other workflow when zsh was used to run script
just changed it to bash and it works fine now.

huh, that is really weird, but good to know 🤔
will be added to the next release


glibc-static dependency on RHEL

Looks like it is hard to find a blessed version of glibc-static rpm. Wondering if there is a way around this dependency.
I am having a lot of trouble installing this cookbook due to this issue.
Appreciate any help.

Shekar

glibc-static is needed by runit-2.1.1-6.el6.x86_64 and is generally available in rhel repositories. What do you mean by "blessed" and what platform specifically are you having issues with?

I imagine a CentOS 5.
CentOS 5.11
[vagrant@service-centos-511 ~]$ yum info glibc-static
Loaded plugins: fastestmirror
base                                                                                | 1.1 kB     00:00
base/primary                                                                         | 1.3 MB     00:12
base                                                                                3667/3667
extras                                                                               | 2.1 kB     00:00
extras/primary_db                                                                    | 173 kB     00:00
updates                                                                              | 1.9 kB     00:00
updates/primary_db                                                                   | 302 kB     00:00
Error: No matching Packages to list

CentOS 6.6
[vagrant@service-centos-66 ~]$ yum info glibc-static
Loaded plugins: fastestmirror
Determining fastest mirrors
 * base: mirror.cisp.com
 * extras: mirror.cisp.com
 * updates: mirror.unl.edu
Installed Packages
Name        : glibc-static
Arch        : x86_64
Version     : 2.12
Release     : 1.149.el6_6.5
Size        : 6.5 M
Repo        : installed
From repo   : updates
Summary     : C library static libraries for -static linking.
URL         : http://sources.redhat.com/glibc/
License     : LGPLv2+ and LGPLv2+ with exceptions and GPLv2+
Description : The glibc-static package contains the C library static libraries
            : for -static linking.  You don't need these, unless you link statically,
            : which is highly discouraged.


RichMarker support?

I was able to get the RichMarker utility library working with ngmaps by changing one line of code. I know you would like to keep to the base google maps API, but what do you think about adding this in?

As long as you send me a pull request, I will review it. I welcome a new feature.

Ok sounds good.


Get 5.0.0 & changelog

When can we expect get 5.0.0 to be stable & have the changelog since 4.6.1 ?

Hi @jonataslaw, any update on this one?

Are there any breaking changes in getx 5, or is it only an update to support desktop ?


AppVeyor artifact upload debug

Debugging issue on phone don't merge 😎

AppVeyor new images confirmed solved issue.


Python can't import polygames or mcts, but can import tube.

Python 3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import pypolygames
import tube
import polygames
Traceback (most recent call last):
File "", line 1, in
ImportError: generic_type: type "ForwardPlayer" referenced unknown base type "core::ActorPlayer"
import mcts
Traceback (most recent call last):
File "", line 1, in
ImportError: generic_type: type "MctsPlayer" has a non-default holder type while its base "core::ActorPlayer" does not

Very strange, I've imported it in this order and it worked.
Make sure to export PYTHONPATH=/polygames before

Strange, it works for me too on 4cf3f4a


ci: smoke test improvements

Describe pull-request
This PR includes a different approach to make sure the right version of core i installed in wrappers. By making use of "npm pack" and upload/download artifacts.
How to test
You can run it locally using this act script:
act -W .github/workflows/smoketest-webhook.yml -P ubuntu-latest=catthehacker/ubuntu:act-latest -s GITHUB_TOKEN={YOUR_GIT_TOKEN}
Checklist before submission

[ ] All existing tests pass

Additional context
When I run this I got the impression it's a bit slower, but more reliable, since we now make sure we get the right version. Thoughts?

I think the command in "How to test" might be wrong as file does not exist so I used this one:
act --container-architecture linux/amd64 -W .github/workflows/smoke-test-failure-webhook.yml -P ubuntu-latest=catthehacker/ubuntu:act-latest -s GITHUB_TOKEN=*******
Is that correct one?


turn off old system collections

Scope & Purpose
Turn off old system collections, as already announced in CHANGELOG and release notes.
For some reason the config variable had a wrong value in devel, potentially this happened when porting the changes across different versions.
3.7 and 3.6 also introduced the config option to control the creation and usage of old system collections, but there the default value of true is correct. Only in devel we want to change it to false.
The CHANGELOG entry for this already existed in devel, however, the change was not carried out here as announced.

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[x] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[x] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] This change is already covered by existing tests, such as JavaScript tests.

Link to Jenkins PR run:
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12895/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12902/

Tests blue


changing MessagesBubbleImage

New issue checklist

[ ] I have read all of the README, documentation, and FAQ.
[ ] I have reviewed the contributing guidelines. Confirmation: ____
[ ] I have searched existing issues and this is not a duplicate.

General information

Library version(s):
iOS version(s):
Devices/Simulators affected:
Reproducible in the demo project? (Yes/No):
Related issues:

Bug report
Expected behavior

...

Actual behavior

...

Steps to reproduce

...

Crash log? Screenshots? Videos? Sample project?

...

Question or Feature Request

...
can we change the MessagesBubbleImage to some thing like this

Thanks @bikram109 ! 😄
This is possible, see the demo project, or previous questions about this.


Move YAPF checks to separate CI integration

The issue with the yapf test is that its results will depend on the version of yapf used. Consider removing the test and have a separate CI yapf test.

@joachimmetz  How does moving it to a separate CI test fix the problem of YAPF versions?  We could also pin the version of YAPF in the dev dependencies if we really want to do that.  I agree it is a little annoying to have tests fail in Travis when they succeed locally, but no matter where we pin the version and what we pin it to, I think this will be an issue.
One somewhat ugly option would be to run it with the last few (2-3?) versions and if any of them pass, then the overall test passes.  This would at least reduce the churn/pain.
One reason I like having YAPF as a project test is that it makes breakages more obvious to the developer during development time instead of finding out after creating the PR, seeing the CI errors, and then having to do another commit to fix things.

So the issue is that every dev environment that wants to run the test needs to have the same version of yapf. By moving it to a separate CI test, this limitation goes away. Worst case you as the maintainer can run yapf the right version of yapf on the PR before merge

I'm going to close this issue out as this hasn't been a problem in practice since the issue was filed.  If it starts being a pain we can re-open.


tests/utils: move & refactor UpdateKubeVirtConfigValueAndWait method

This PR does 4 things:

Rename the method UpdateKubeVirtConfigValueAndWait in tests/utils to PatchKubeVirtConfigValueAndWait.
the method actually calls another method (UpdateKubeVirtConfigValue) that uses Patch operation to change the
kubevirt config field
Rename UpdateKubeVirtConfigValue to be PatchKubeVirtConfigValue.
Move PatchKubeVirtConfigValueAndWait to the testsuite package.
introduce new helper func waitForConfigToBeApplied , instead of the waitForConfigToBePropagated .
the new function is based on the kubevirt resource status conditions

Release note
None

/test pull-kubevirt-e2e-k8s-1.31-sig-compute

/test pull-kubevirt-e2e-k8s-1.31-sig-compute

https://github.com/kubevirt/kubevirt/blob/fd5562ca5cfda6c4f3feb026b6064158b151f746/tests/hotplug/affinity.go#L41
This looks like a potential flake to me

could you explain what do you mean ?

I see that @alromeros got https://github.com/kubevirt/kubevirt/pull/12292 merged. @dasionov  I have a vague memory that your original PR has had more cleanup value. On its own, I don't think that the name change merits a PR. The important thing is that the function changes the state of the KubeVirt operator; it does not matter if it uses Update or Patch.

/test pull-kubevirt-e2e-k8s-1.31-sig-compute

/test pull-kubevirt-e2e-k8s-1.31-sig-compute

/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations

/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations

/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations

/close
Closing this as the PR has gone through many iterations. Will continue in a new PR.


Fixes handling of kill and unreachable ops in inlining.

Fixes #1527

Adds handling for copying OpKill and OpUnreachable and forces the
generation of a new basic block
Adds tests to check

While I will be the first to admit that this logic is not the easiest to work with, it feels like there might be a way to avoid creating a new (dead) block with a similar amount of additional logic. Let me stare at the code a bit more.

Actually, I think this solution may actually generate invalid SPIR-V. Consider the case where the called function contains a KILL but it is not the last instruction in the function before the OpFunctionEnd. Also this does not fix the case where the last instruction before the OpFunctionEnd is a non-Return terminator like OpBranch, which would also be a problem.
I do agree with your general solution, though. And yes, there is a potential to generate a dead block after the call but we will just have to rely on following passes to clean it up. Trying to avoid this would just be overly complicated.
Here is a solution that I think will work:
Start over.
Create a new boolean prevInstNonReturnTerminator. Initialize to false.
Also, at the beginning of the OpLabel case, prevInstNonReturnTerminator= false.
At the end of the default case, if the opcode is a terminator, prevInstNonReturnTerminator= true. We know it is not a Return because those are caught by their own cases.
Finally, at the beginning of the OpFunctionEnd case:
if (prevInstNonReturnTerminator && returnLabelId == 0) returnLabelId = this->TakeNextId();
If it is easier, I can just create my own pull request. Let me know how you want to proceed.

I don't see the problems you're describing. Do you have a case that doesn't work?  I just tried one where the branch is the last instruction before the OpFunctionEnd and it seems ok.
               OpCapability Shader
               OpMemoryModel Logical GLSL450
               OpEntryPoint Fragment %1 "main"
       %void = OpTypeVoid
       %bool = OpTypeBool
       %true = OpConstantTrue %bool
          %5 = OpTypeFunction %void
%_ptr_Function_bool = OpTypePointer Function %bool
          %1 = OpFunction %void None %5
          %7 = OpLabel
          %8 = OpVariable %_ptr_Function_bool Function
          %9 = OpLoad %bool %8
         %10 = OpFunctionCall %void %11
               OpStore %8 %9
               OpReturn
               OpFunctionEnd
         %11 = OpFunction %void None %5
         %12 = OpLabel
               OpBranch %13
         %13 = OpLabel
               OpLoopMerge %14 %15 None
               OpBranch %16
         %16 = OpLabel
               OpKill
         %14 = OpLabel
               OpReturn
         %15 = OpLabel
               OpBranch %13
               OpFunctionEnd

Turns into (minus the inlined function):
               OpCapability Shader
               OpMemoryModel Logical GLSL450
               OpEntryPoint Fragment %1 "main"
       %void = OpTypeVoid
       %bool = OpTypeBool
       %true = OpConstantTrue %bool
          %5 = OpTypeFunction %void
%_ptr_Function_bool = OpTypePointer Function %bool
          %1 = OpFunction %void None %5
          %7 = OpLabel
          %8 = OpVariable %_ptr_Function_bool Function
          %9 = OpLoad %bool %8
               OpBranch %17
         %17 = OpLabel
               OpLoopMerge %18 %19 None
               OpBranch %20
         %20 = OpLabel
               OpKill
         %18 = OpLabel
               OpBranch %21
         %19 = OpLabel
               OpBranch %17
         %21 = OpLabel
               OpStore %8 %9
               OpReturn
               OpFunctionEnd

I can add this as a unit test.

@greg-lunarg : I seems to me your solution is functionally the same, but you're trying to frame it more generically.  There are only so many terminator instructions, and the only ones that "leave" the function are the returns, and Kill and Unreachable.   @alan-baker 's proposed change explicitly enumerates those in the big switch statement.
It would possibly improve the MR if a comment were added to emphasize the generic reason why OpUnreachable and OpKill require this behaviour, and that therefore any potential future instruction that had the same property of "leaving" the CFG should also be treated similarly.
How about:

Handle the case of a block terminator that does not transfer control to another block in the CFG.  Aside from OpReturn and OpReturnValue (handled elsewhere), only OpUnreachable and OpKill are like this.

My apologies. Actually running the cases I was worried about revealed forgotten logic in the original code which covered those cases.
Given that, it seems the following similar but slightly simpler logic passes all the inlining tests:
Start over. Add the following at the beginning of the OpFunctionEnd case:
// If previous instruction was not return, we will need a label
if (!prevInstWasReturn && returnLabelId == 0)
returnLabelId = this->TakeNextId();

Take or leave as you wish.

Rebased, squashed and submitted as 4246abdc74a18c60b49316d5d9863ca2be61127a


CSS, JavaScript and assets being imported from node_modules

The CSS on the code snippet examples and the JavaScript/assets are being directly imported from the node_modules into pages. These should be compiled within the application via Sass/ES6 modules to give us more flexibility and customisation if we require.

The JavaScript on regular pages is also being imported directly from the NHS.UK frontend node_module folder <script src="/service-manual/nhsuk-frontend/nhsuk.min.js" defer></script>


added pixel

Checklist

[ x] I ran npm test locally and it passed without errors.

[ x] I only edited the _data/pixels.json file.

[ x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x ] I acknowledge that all my contributions will be made under the project's license.

I've only added a pixel and have checked that the username that is said to be deleted is still in the file. Not sure why the tests are unable to locate the username.


Error during Manual Install

Using an updated Ubuntu 16.04.06 VM.
Getting the following error during installation:
"Update Returned Exit code Not Zero"
See the attached image for the error. Please suggest.

There is a log file that was referenced at the start of the run that will have further info.

@sahoo8920 if you'd like help, please attach the log file.

am having the same issue exactly but using ubuntu 18.14. I've also tried with the 16.04 before and same results.
Attached you'll find the log file.
saltstack.log

Looks like unicode issues.
- "Rendering SLS 'base:sift.config.user.terminal_bionic' failed: while parsing a block
  mapping\n  in \"<unicode string>\", line 17, column 9\ndid not find expected key\n
  \ in \"<unicode string>\", line 17, column 112"
- "Rendering SLS 'base:sift.config.user.theme_bionic' failed: while parsing a block
  mapping\n  in \"<unicode string>\", line 24, column 9\ndid not find expected key\n
  \ in \"<unicode string>\", line 24, column 112"

What are your language settings?

I'm running into an install problem as well.. seems to fail at the same point in terminal but my log says it can't use pip. pip is installed and available, not sure what to do... I've been trying to troubleshoot this for two days now. Ubuntu 18.04.4, saltstack.log attached.
saltstack.log

@Asaph208 looks like your python might be broken. 18.04? Can you please provide dpkg -l | grep python output.

@Asaph208 looks like your python might be broken. 18.04? Can you please provide dpkg -l | grep python output.

python.txt

@Asaph208 when you run python --version what's the default?

@Asaph208 when you run python --version what's the default?

2.7.17

@Asaph208 it also looks like you are having apt problems.  Can you provide ls of /etc/apt/sources.list.d and then run apt-cache showpkg libesedb

@Asaph208 it also looks like you are having apt problems.  Can you provide ls of /etc/apt/sources.list.d and then run apt-cache showpkg libesedb

$ ls /etc/apt/sources.list.d
docker.list
docker.list.distUpgrade
docker.list.save
gift-ubuntu-stable-xenial.list
gift-ubuntu-stable-xenial.list.distUpgrade
gift-ubuntu-stable-xenial.list.save
noobslab-ubuntu-icons-xenial.list
noobslab-ubuntu-icons-xenial.list.distUpgrade
noobslab-ubuntu-icons-xenial.list.save
noobslab-ubuntu-themes-xenial.list
noobslab-ubuntu-themes-xenial.list.distUpgrade
noobslab-ubuntu-themes-xenial.list.save
openjdk-r-ubuntu-ppa-xenial.list
openjdk-r-ubuntu-ppa-xenial.list.distUpgrade
saltstack.list
saltstack.list.distUpgrade
saltstack.list.save
sift-ubuntu-stable-xenial.list
sift-ubuntu-stable-xenial.list.distUpgrade
sift-ubuntu-stable-xenial.list.save

$ apt-cache showpkg libesedb
N: Unable to locate package libesedb

cat /etc/os-release

cat /etc/os-release

$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

ok so this was an upgrade from 16.04, can you show me the contents of  gift-ubuntu-stable-xenial.list and  sift-ubuntu-stable-xenial.list

gift is empty
sift:
deb http://ppa.launchpad.net/sift/stable/ubuntu bionic main # disabled on upgrade to bionic
deb-src http://ppa.launchpad.net/sift/stable/ubuntu xenial main

Remove
gift-ubuntu-stable-xenial.list
gift-ubuntu-stable-xenial.list.distUpgrade
gift-ubuntu-stable-xenial.list.save
gift-ubuntu-stable-xenial.list
gift-ubuntu-stable-xenial.list.distUpgrade
gift-ubuntu-stable-xenial.list.save

Then try again.

Failed again in the same spot with the same reason (i think). Since this is an upgrade from 16, maybe I should just do a totally fresh 18 install and try again.
secondsaltstack.log

I'm at a loss. I re-installed fresh from an Ubuntu 18 DVD I made, erased the whole hard drive and installed. I did the update/upgrade/autoremove trio, followed the directions for the CLI process and it still fails. There is a spot in the middle of the installation asking for a github username and password, am I correct in typing in my credentials here? Could that be the issue?
The failure this time is different, but is still obviously a failure. Attached are the saltstack logs.
saltstack2.log

use the --pre-release flag, we had to fix an issue with regripper and hadn't officially released the change.
does the gift and sift apt repo files now have the right data in them at least?

am having the same issue exactly but using ubuntu 18.14. I've also tried with the 16.04 before and same results.
Attached you'll find the log file.

Looks like unicode issues for you @tompolth
- "Rendering SLS 'base:sift.config.user.terminal_bionic' failed: while parsing a block
  mapping\n  in \"<unicode string>\", line 17, column 9\ndid not find expected key\n
  \ in \"<unicode string>\", line 17, column 112"
- "Rendering SLS 'base:sift.config.user.theme_bionic' failed: while parsing a block
  mapping\n  in \"<unicode string>\", line 24, column 9\ndid not find expected key\n
  \ in \"<unicode string>\", line 24, column 112"

What are your language settings?

I am using spanish keyboard layout. In any case, I have changed it again to the english US again -layout and format- and then tried again. I get the same results.

Does your username or home directory path use any utf-8 characters?

sudo sift install  --pre-release

Was successful! Thank you very much for taking the time to troubleshoot this with me. Whatever change there was with the --pre-release option made the difference.

Does your username or home directory path use any utf-8 characters?

No, my username and home directory are siftforensics@siftWS
I used the same that the OVA virtual machine in order to avoid issues. But, obviously, I didnt manage , he, he

@tompolth Can you provide the output of the locale command and salt-minion -V ? The error you've provided regarding the unicode string is an error that previously popped up in 2018.3 and early versions of salt-minion 2019.
Thanks

Hi,
The complete output is this:

I've seen that there is some complains about the installed Python's vesion (2.7) I don't if this has something to do with those errors.
Best

The Python 2.7 message is just informative, and doesn't actually generate an error in the saltstack process. Can you also send the output of the locale command?
One potential way to work around this is to install the 1.9.0-rc1cli, which uses salt-minion 3001. This is a python3-based salt installation which will get rid of the python2.7 warnings. However, I'd like to see the locale output before you try this.
Cheers

Here it is:

Thanks for your help

Can you try running export LANGUAGE=en_US.UTF-8 and try running the cli installer again? It's possible the Unicode error is due to the language variable being empty.
If that doesn't work, then we can try the sift RC1 cli.

I've tried and I've got the same errors.
I've also realize that during the apt update command I get this other warning related with salt:
N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'http://repo.saltstack.com/apt/ubuntu/18.04/amd64/2019.2 bionic InRelease' doesn't support architecture 'i386'

That apt warning doesn't actually have an effect on the installation, as it's just a warning. If you have already done the export LANGUAGE command, and the environment variable still shows as empty, then try preceding your sift cli command with it, like this: LANGUAGE=en_US.UTF-8 sudo sift install --pre-release
Even with your LANGUAGE env blank, this will force the command to run under this context.
What version of the cli are you currently using? Perhaps the move to 1.9.0-rc1 might be better for you and should resolve this issue.

I am using the 1.8.5 version. The same errors. I will try it with the 1.9.0-rc1

Could you provide a copy of your last saltstack.log? I'd like to see if there are any other indicators which may be causing the error.
Thanks!

Now, with the 1.9.0 version I have other errors :-(
_root@siftWS:/home/siftforensics# sift install --pre-release

<EMAIL_ADDRESS>sift-version: notinstalled

mode: desktop
Installing and configuring SaltStack properly ...

Command failed: apt-get install -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" -y --allow-change-held-packages salt-minion
debconf: delaying package configuration, since apt-utils is not installed
E: Sub-process /usr/bin/dpkg returned an error code (2)
Error: Command failed: apt-get install -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" -y --allow-change-held-packages salt-minion
debconf: delaying package configuration, since apt-utils is not installed
E: Sub-process /usr/bin/dpkg returned an error code (2)
at ChildProcess.exithandler (child_process.js:303:12)
at ChildProcess.emit (events.js:315:20)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)

----- PLEASE READ ----------------------
A lot of failures are caused by the apt system being locked
or unhealthy.
Before opening an issue in GitHub, please check to see if
your apt system is healthy.
Try running 'apt-get update' then remove any packages that
aren't used by running 'apt-get autoremove'_

That one's actually easy to fix. Try the following:
 sudo apt search salt-minion and make note of the version. Should be 3001. If it is, then run:
sudo apt install salt-minion salt-common -y
Once that finishes, run the sift cli again, using the --pre-release option.

Installed salt-minion.
This is the saltstack.log in the last execution. Same issues
saltstack.txt

Can you confirm that your /home/siftforensics/ directory is owned by siftforensics:siftforensics recursively? Including the .dbus directory.
I see this error just prior to the Unicode error, when it's trying to setup your terminal preferences:
[DEBUG   ] env command: ('su', '-s', '/bin/bash', '-', 'siftforensics', '-c', '/usr/bin/python3')
# [DEBUG   ] stdout: dbus[19128]: Unable to set up transient service directory: XDG_RUNTIME_DIR "/run/user/0" is owned by uid 0, not our uid 1000 unix:abstract=/tmp/dbus-LIrXEKq4NK,guid=428acc25931324ee47f640995f2ff940
# [DEBUG   ] output: dbus[19128]: Unable to set up transient service directory: XDG_RUNTIME_DIR "/run/user/0" is owned by uid 0, not our uid 1000

Looks like the cause of the Unicode error is due to an error message being returned in place of the expected DBUS_SESSION_BUS_ADDRESS and salt is trying to parse the error message. The message contains invalid/unexpected characters, and as such is throwing the Unicode error. Let me know if the permissions in your home directory are out of whack.

mmm, yes probably is that. I don't know why but the .dbus directory is root owned
drwxr-xr-x 17 siftforensics siftforensics 4096 Aug  9 14:19 .
drwxr-xr-x  3 root          root          4096 Jul 29 09:33 ..
-rw-------  1 siftforensics siftforensics  271 Aug  9 13:58 .bash_history
-rw-r--r--  1 siftforensics siftforensics  220 Jul 29 09:33 .bash_logout
-rw-r--r--  1 siftforensics siftforensics 3771 Jul 29 09:33 .bashrc
drwx------ 14 siftforensics siftforensics 4096 Jul 30 19:55 .cache
drwx------ 13 siftforensics siftforensics 4096 Jul 29 10:37 .config
drwx------  3 siftforensics root          4096 Jul 29 10:09 .dbus
drwxr-xr-x  2 siftforensics siftforensics 4096 Aug  9 15:37 Desktop
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Documents
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 30 20:16 Downloads
-rw-r--r--  1 siftforensics siftforensics 8980 Jul 29 09:33 examples.desktop
drwx------  3 siftforensics siftforensics 4096 Jul 29 09:46 .gnupg
-rw-------  1 siftforensics siftforensics 3180 Aug  9 14:19 .ICEauthority
drwx------  3 siftforensics siftforensics 4096 Jul 29 09:46 .local
drwx------  5 siftforensics siftforensics 4096 Jul 29 10:05 .mozilla
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Music
-rw-r--r--  1 siftforensics siftforensics  310 Jul 30 08:36 .pam_environment
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Pictures
-rw-r--r--  1 siftforensics siftforensics  807 Jul 29 09:33 .profile
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Public
drwx------  2 siftforensics siftforensics 4096 Jul 29 09:46 .ssh
-rw-r--r--  1 siftforensics siftforensics    0 Jul 29 10:06 .sudo_as_admin_successful
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Templates
drwxr-xr-x  2 siftforensics siftforensics 4096 Jul 29 09:46 Videos

Bingo!! That was!!
Now the sift install is working. Let's hope that is enough. Thanks a lot.
In any case, I don't know why the .dbus directory was owned by root.
Thank you very much.

This can happen for any number of reasons, but I have a few (unvalidated) reasons as to why it happened.
Glad everything worked out for you!


Cannot access env variables from client

I use Nuxt.js v. 2.14.12.
The problem is, that I can't get the value of env variables.
The Dockerfile:
FROM node:12-alpine

…

EXPOSE 8000
ENV NUXTHOST=<IP_ADDRESS>
ENV NUXTPORT=8000

CMD ["npm", "start"]

In nuxt.config.js I do:
env: {
  baseUrl: process.env.NUXT_HOST || '123',
}

When I console.log the process.env.baseUrl in nuxt.config.js - on client side (in browser) I get '123' and in console I get '<IP_ADDRESS>'.
Meanwhile console.log(process.env.NUXT_HOST) also gives the undefined in browser.

Thanks a lot, it helped

Thanks a lot, it helped


Clarified filePath argument

CLI bug that prevented uploading other formats has been fixed. Closing.

CLI bug that prevented uploading other formats has been fixed. Closing.


Prototype scheme- and intervention-level fields for a new pipeline sc…

…hema. #355
Demo: https://acteng.github.io/atip/pipeline_forms/scheme.html?authority=LAD_Adur&schema=pipeline

[ ] Use .geojson file extension instead of .txt, at least for this mode, since we're not using SmartSurvey
[ ] Make the scheme details more prominent -- maybe ask it upfront, or make the button way more obvious
[ ] Make a component for numeric input (and note https://design-system.service.gov.uk/components/text-input/ recommends against it...)
[ ] Think through how the "is alternative?" would work
[ ] Figure out how to ask for the coverage polygon
[ ] Add warnings for the new per-intervention fields
[ ] Mark required vs optional fields, and maybe re-order things

From a quick glance, looking great to me!

Switching between snapping and straight line mode with Shift feels great, smoother than before? Niggle: I think the text with "Shift" is different from the nice text we now use as default:

Robin, this PR and the demo link is for new forms both intervention- and scheme-wide. Please try out snapping/freehand points in routes at https://github.com/acteng/atip/pull/376.

Robin, this PR and the demo link is for new forms both intervention- and scheme-wide. Please try out snapping/freehand points in routes at #376.

Aha I see what you mean. Will give it a go now!

Overall: looking really great, I love the big form for scheme level details.


Chore/modify work template

Type of PR

[x] Feature
[ ] Bugfix
[ ] Hotfix
[ ] Chore

Merge strategy

[x] Squash (default)
[ ] Merge commit (branch merges, usually used for merges to master)
[ ] Rebase (preserve individual commits without merge commit)

Purpose

Add respnsibilities to work section
Add styles for work section

Relevant tickets
22843

Before

After


strokeColorConfig doesn't work IOS

Following the example on NPM, strokeColorConfig doesn't work and crashes the app.
I get this screenshot:

Could you please provide a reproducible example link so that I can try this on my end?

Same problem here. Started after upgrade to the latest expo (48)


Add cli flag to handle duplicate tag keys

Signed-off-by: Ashmita Bohara<EMAIL_ADDRESS>
Which problem is this PR solving?
Resolves https://github.com/jaegertracing/jaeger/issues/3203
Short description of the changes

As recommended by Yuri in the ticket, this PR adds a cli flag with three possible values: "drop", "keep" and "replace". Using "keep" as the default behaviour to maintain backward compatibility.

The build is failing, looks like the first error is:
+ make create-baseimg-debugimg
docker buildx inspect jaeger-build > /dev/null || docker buildx create --use --name=jaeger-build --buildkitd-flags="--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host" --driver-opt="network=host"
jaeger-build
docker inspect registry > /dev/null || docker run --rm -d -p 5000:5000 --name registry registry:2
error: no builder "jaeger-build" found
Error: No such object: registry
Unable to find image 'registry:2' locally

Updated the PR with feedbacks.

Thank you so much @albertteoh I didn't know we can unit test for log.Fatal too. I agree without we should just fail on invalid parameter.


Copyright updated.

This PR closes the following issue:
closes #39
Changes made:

Copyright 2022 the original author or authors. changed to Copyright 2022-2023 the original author or authors.
Copyright 2012-2020 the original author or authors. changed to Copyright 2012-2023 the original author or authors.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please review my changes...


Populate ollama models autocompletion with locally available models

Created this one to supply list of model choices with locally installed models. In case of ollama it may have more sense, because there is way more available options compared to closed models like openai. Also, someone can use 30B or 70B version models if PC is strong enough.

I love this as an idea however it doesn't work as I expected it to:
https://github.com/olimorris/codecompanion.nvim/assets/9512444/1f06973c-fbda-44eb-9c78-9ef04628b1b8
Clearing the model name, I would expect to see the dropdown appear as I can't recall what Ollama models I have installed. I suspect this might be the cmp implementation.

Do you expect autocompletion to trigger autmatically when field is empty? For me it works when I trigger autocompletion with keymap (C-SPACE in my  case). I can tinker about it more

Ahhhh. I didn't manually trigger it. Great suggestion and thanks for the PR.


Weird Formatting after save

VSCode Version: Version 1.33.1 (1.33.1)
OS Version: mac
Steps to Reproduce:
1 change files
2 format is changing after auto save
Does this issue occur when all extensions are disabled?: Yes
I switched off all extensions and it still occurs.
I have video recording as well and can send.

Only what helps me, it's removing VS code and install again (as well as all settings and extensions)

Please update this issue after reading https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions#writing-good-bug-reports-and-feature-requests. Thanks.

Hm, what is not enough in my description?
I can't attach file here, it's only possible with the file size 10MB

Hm, what is not enough in my description?

It's perfect because it doesn't specific and name anything. I selfhost on format-on-save with TypeScript using the default TS formatter, works just the way I want. That means I can close this issue because it's not reproducible, I can optionally also point to a random commit if you like.
Alternatively you put yourself into my shoes, you open an empty project, and you provide reproducible steps from there

Okay, I hope it will help with screenshots

Open any .js file (attach file action-1.png)

It's enough putting just spacing

New weird formatter applied

All reproducible with all disable extensions.

The problem is reproducible with disable extensions.

There are six extensions enabled, one of them is a formatter. Try reproduce without extensions enabled

no actionable information provided

It seems the reason is a Prettier extension. After disabling and reloading VS code, the issue is gone. Thanks


Run esnext on lib directory

Auto upgrading to latest ES syntax using esnext. Experimented with server/libs (some extra fixes were necessary in non standard code):
find server/lib/*.js -exec esnext -I {} \;
Can run on other places if you like the principle:
find . -name "*.js" -not -path "./node_modules/*" -exec esnext -I {} \;
BTW wonder why eslint still allowed various var to be in the code
@asood123 @xdamman

@sedubois It's because of this line that overrides the original config: https://github.com/OpenCollective/opencollective-api/blob/master/.eslintrc#L6. At the time, we had to upgrade node to use let. Shouldn't be a problem now, so we can remove it.

Looks good to me, so feel free to run it everywhere


Removing _ prefix from views like _Layout.cshmtl

Since now there's a wwwroot folder and views are no longer available from the server, is there any reason to leave the _ on ViewStart, Layout, and even partials ?

I believe it was only used as a convention, because you don't necessary need to specify _ in any razor view names.

_ViewStart and now _GlobalImport are the only ones that require the _ prefix. The prefix is optional for other view files. It might be simpler to leave the prefix for _ViewStart to make it easier to port applications. Additionally, the plan is to eventually bring back a Web Pages \ Razor pages based framework built on top of Mvc which might require the underscore convention to denote files that cannot be directly requested.


BUG: Hover effect is not good

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
@Suchitra-Sahoo
check this out,

when i hover on card it overlap with other cards and also there are very few space between 2 cards
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Issue is resolved.


onAuthStateChange doesn't get called If I delete a user from the firebase console

I tried to put a breakpoint to the auth listener, if I delete a user using the api then I get the update on my auth listener, If I delete the user from the console then I don't get the update. Any idea why??

please follow the issue template, we cannot help you with out any code, picture, minimum repository

@juanlet You likely did not enable auth in the console. Please follow the issue template in a new issue if the problem persists.

Yo missread my question. This does not require any code display. The listener is being called if user logs in or out. But if I link or unlink a provider like facebook or twitter the listener doesn't receive the new state, hence the data is not being broadcasted if a user links or unlinks a provider( all of this being logged in)....


As a dev, I want to adapt the build_inspection_import function to the new analysis data format in fertiscan

Description
The build_inspection_import function in the datastore is currently tailored to an outdated format of the fertilizer label analysis. However, a new format for the fertilizer label analysis has been introduced, requiring an update to ensure proper data handling and compliance with the new structure. The goal is to update the function to handle this new JSON format.
Acceptance Criteria

Update the build_inspection_import function to parse the new fertilizer label analysis JSON format.
Ensure backward compatibility, so old data formats are still processed correctly if necessary.
Test cases are provided or updated to reflect the changes in the function and ensure both old and new formats are handled accurately.

Additional Information

ref: Additional information section of https://github.com/ai-cfia/fertiscan-frontend/issues/229

I'm sorry but this is already done in #149

Closing this as done in #171.


Question: is it possible to access the settings without the esp32 connected to computer?

As title says. I can't access the settings when it's not connected to the computer via cable. Also what is the repo for the clock club? That default url lands me on a GitHub startup page? Im running via local server right now but would prefer to use the clock club server. Thanks

nvm, I realized that I need to have the same wifi for both esp32 and my computer. closing this.


Explain how to disable app config reload in ASP.NET Core 5.0

Fixes https://github.com/dotnet/AspNetCore.Docs/issues/17373
Internal review page

@Tratcher Ready for another look. The section only appears for 5.0+ now.