Fixes process metrics when the application has not sent/received any request

backport of #1225

Codecov Report
Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.92%. Comparing base (98352a7) to head (99887ac).

Files with missing lines
Patch %
Lines

pkg/export/otel/metrics.go
0.00%
1 Missing and 1 partial :warning:

pkg/export/otel/traces.go
0.00%
1 Missing and 1 partial :warning:

pkg/export/prom/prom.go
0.00%
2 Missing :warning:

pkg/internal/request/span.go
50.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (98352a7) and HEAD (99887ac). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (98352a7)
HEAD (99887ac)

unittests
1
0

k8s-integration-test
1
0

integration-test
1
0

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.8    #1236       +/-   ##
================================================
- Coverage        82.00%   36.92%   -45.09%
================================================
  Files              140      139        -1
  Lines            11565    11565
================================================
- Hits              9484     4270     -5214
- Misses            1558     6864     +5306
+ Partials           523      431       -92

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
36.92% <57.89%> (+0.01%)
:arrow_up:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[hotfix][table-planner] Roll back the StreamExecNode version

What is the purpose of the change
This pull request reverts the ExecNodeMetadata version for some exec nodes that translate to stateful operators.
The reason can be found in the discussion of https://github.com/apache/flink/pull/22593
Brief change log
Roll back the version and adapt test cases.
Verifying this change
This change is already covered by existing tests, such as tests under org.apache.flink.table.planner.plan.nodes.exec.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

The test failure is not relevant to this PR, https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_apis/build/builds/51630/logs/203
2023-07-24T07:10:52.4550104Z Jul 24 07:10:52 [FAIL] 'Run Kubernetes test' failed after 4 minutes and 28 seconds! Test exited with exit code 1

@flinkbot run azure

The e2e-1 keeps failing and is not relevant to this PR, https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_apis/build/builds/51630/logs/203
2023-07-24T07:10:52.4550104Z Jul 24 07:10:52 [FAIL] 'Run Kubernetes test' failed after 4 minutes and 28 seconds! Test exited with exit code 1

A similar issue
https://issues.apache.org/jira/browse/FLINK-31825


Excel Importer - Reference Property

Hello,
I have a import model with reference property but sometimes the value is empty in the excel file.
The property is not mandatory in my BO.
When i try to import, it looks that the module is trying to create a record using the empty value.
Can we consider that when the field is empty (String.IsNullOrEmpty) there is no record to check or create.
BR
ISA

sorry I missed this one please ping me if I delay again. I think we should link this ticket to the new column strategies discussed in #176

Sorry, these days are quite busy in my side too. I saw the #176 and i agree.
BR
ISA


Enable "commit/rollback" only if the action is possible

Buttons "commit" and "rollback" should be only enabled, if particular action is really possible. It will help to determine, whether the user have any uncommited changes or not.

Tricky to do as some dbms vendors have operations where a commit (for example) is implied and you'd have to have good knowledge of them in order to not leave the commit/rollback buttons enabled when they wouldn't do anything.. for example:

-- Run these statements with auto-commit off one by one
CREATE TABLE test(id numeric);
INSERT INTO test SELECT 1 FROM dual;
ALTER TABLE test ADD blah varchar2(256);
-- Click on rollback at this point
-- Now run this
SELECT * FROM test;
-- Only run this is you want to clean up at the end - be careful in case you already had a table called 'test' in your system !
DROP TABLE test;

At the point of issuing the rollback, you could be led to believe that it would do something and should have been enabled, but in Oracle the above would do nothing and the subsequent select would return a single row with the value '1' in it.
So there was already an implied commit from the DDL (but this may not be true of all DBMS or all versions or even of all DDL) - quite tricky to know the actual state all the time.


Each page that uses [...permalink] gives 404 since latest Directus update?

Hi guys,
My application was working well, and the portal still is, but somehow all my pages are now giving a 404 since I used the latest Directus docker image. Version: 11.0.1. Has something changed? It seems like the page variable is not found anymore.
It is working fine when calling: /posts
Hope you guys know how I can fix this.
Thanks in advance!

Okay, so I've fixed this. This had to do with the "buttons" key in some 'block' collections. I see @bryantgillespie had the same issue, and fixed this in this commit: https://github.com/directus-labs/agency-os/commit/78d36dddf74289719249053165cd879cf9fdbeea
So this one is (luckily) solved.


Some cloud apps fail to download icons

Bug Report
Some cloud apps fail to download icons because the HTTP request gets rejected by the server. When that happens, the cloud app gets an error message like this:
Unable to download file - https://searchengineland.com/figz/wp-content/seloads/2015/12/google-amp-fast-speed-travel-ss-1920-800x450.jpg - Server returned HTTP response code: 403 for URL: https://searchengineland.com/figz/wp-content/seloads/2015/12/google-amp-fast-speed-travel-ss-1920-800x450.jpg

It seems that this happens because the user agent is not set in the HTTP request and some servers reject the request when the agent is not set.
Reproduction Steps

Create a cloud app and use this as an icon:

https://searchengineland.com/figz/wp-content/seloads/2015/12/google-amp-fast-speed-travel-ss-1920-800x450.jpg

Start the cloud app
Observe the app icon on HMI

Expected Behavior
The app icon gets downloaded and displayed correctly on HMI
Observed Behavior
The app icon download fails
OS & Version Information

Android Version: N/A
SDL Android Version: 4.12.0
Testing Against Core 7.0/ Generic HMI

Closed via #1514


Text for building

Oops. Good catch.
I updated the text. The new link is not live yet but will be soon


_define_property() is mistakenly used for !-properties of the class

Describe the bug
Vanilla TypeScript compiler doesn't add class properties marked with ! to the class instance (see example). TypeScript Playground Link, try both es2021 and es2022.
As opposed to it, SWC (starting from 1.3.40 and till now on) does add them as undefined properties. In particular, it's most damaging for constructor property: in TS, defining ["constructor"]!: typeof MyClass is a way to allow methods call static functions like this.constructor.myStatic().
Input code
class MyClass {
  ["constructor"]!: typeof MyClass;
  other!: number;

  static myStatic() {
    console.log("myStatic")
  }

  myMethod() {
    this.constructor.myStatic();
  }
}

Config
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true
    },
    "target": "es2021",
    "minify": {
      "mangle": false
    }
  },
  "module": {
    "type": "commonjs"
  }
}

Playground link (or link to the minimal reproduction)
https://play.swc.rs/?version=1.4.11&code=H4sIAAAAAAAAA0vOSSwuVvCtdAbT1VwKCtFKyfl5xSVFpckl%2BUVKsYpWCiWVBan5aTBF1kA1%2BSUZqUVAmbzS3KTUImsuoFBxSWJJZrJCbmUwmKGhCTZMQQFkWH5Oql5OfrqGEkxWSRMoVwvSllvpm1qSkZ8CV1%2BSkVmsh%2BQCPYSJ1mBNtQBzcM%2B%2BswAAAA%3D%3D&config=H4sIAAAAAAAAA01OOw6DMAzdc4rIc4eWsbexgkEg8pFtpEaIu9ehadXN7%2Bt3OO9hlQBPf9hpoCAL8Q8bIzUpvowBrYUk8FIUbl91pJAZNbOYQ3mnSzg%2FOijyTNqyJMN9ePQcxCUtU%2F3%2FEjHNGxkz4Sa9xPUiiHncL7GPbENaacgx5rQKNKc73xj6roLOAAAA
SWC Info output
1.4.11 (see playground link)
Expected behavior
class MyClass {
    static myStatic() {
        console.log("myStatic");
    }
    myMethod() {
        this.constructor.myStatic();
    }
    constructor(){
        // there should be NO _define_property() calls here!
    }
}

Actual behavior
class MyClass {
    static myStatic() {
        console.log("myStatic");
    }
    myMethod() {
        this.constructor.myStatic();
    }
    constructor(){
        _define_property(this, "constructor", void 0); // <-- WRONG
        _define_property(this, "other", void 0); // <-- WRONG
    }
}

Also, try es2022: it generates the properties as well (directly, not with _define_property). Which is not what vanilla TypeScript does:
class MyClass {
    ["constructor"]; // <-- WRONG
    other; // <-- WRONG
    static myStatic() {
        console.log("myStatic");
    }
    myMethod() {
        this.constructor.myStatic();
    }
}

Version
1.4.11
Additional context
Reproducible starting from version 1.3.40

When you enable useDefineForClassFields: truePlayground 1 or set the target: es2022Playground 2, TypeScript will behave consistently with SWC.
This is correct according to the ECMAScript specification.
To mimic the behavior of TypeScript, set useDefineForClassFields to false.
Alternatively, if you wish to express the code's intention more accurately, you can utilize declare.
class MyClass {
    declare ["constructor"]: typeof MyClass;
    declare other: number;

    static myStatic() {
        console.log("myStatic")
    }

    myMethod() {
        this.constructor.myStatic();
    }
}


[New Port Request] npcap

Library name: npcap
Library description: Packet capture library for Windows
Source repository URL: https://github.com/nmap/npcap
Project homepage (if different from the source repository): https://nmap.org/npcap/
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
Related comment:  https://github.com/microsoft/vcpkg/pull/10731#issuecomment-614938011

Unlike WinPcap, Npcap is 1) currently being developed and maintained and 2) is based on a reasonably up-to-date version of libpcap.

Note that to get kernel driver that works on Windows without TESTSIGNING enabled, Kernel-Mode Code Signing certificate is required. For Windows 10, also Attestation Signing is required which requires EV Kernel-Mode Code Signing and uploading the package to Microsoft Hardware Dev Center - which is pretty much impossible to do in vcpkg port IMHO.
As such, as far as the kernel driver goes, the only viable option for majority of users would be to use official releases.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

As suggested also in other issues, probably to avoid confusion in the users if the policy of "leaving the new port request open for some time and then close it" would be written in a clear way somewhere. Furthermore, it would probably make sense to edit or clarify existing documentation (see https://docs.microsoft.com/en-us/cpp/build/vcpkg?view=vs-2019#contribute-new-libraries) that suggests that issues that request new ports are welcome. As a final suggestions, it is  now impossible to navigate new port requests that have not been solved, as both solved and unsolved new port requests are listed as Closed Issues with the category:new-port , so it would be great to have a specific label applied to new port request that are still unsolved.

Good point! @traversaro, thanks for bringing up this!


Support for C#

Hi there, I work at Rokt, and we are using type share for writing our domain models and creating Kotlin, Swift and TypeScript models. However, we also use C#, which is currently unsupported. I have created a PR for supporting C# version 11 https://github.com/1Password/typeshare/pull/155
Could anyone have a look? Would love to get feedback and work on it until this can be merged.

Hello and thank you for your contributions and enthusiasm! We're currently having internal discussions on how we can better support Typeshare as a project (and new languages in particular). I want to thank you for your patience thus far and let you know that we need a bit more time for these discussions, though I want you to know we haven't forgotten about Typeshare!


Using mmap for random reads for TableCache files uses a lot of memory

Fix db/db_bench.cc to respect open_files --
http://code.google.com/p/leveldb/issues/detail?id=115 -- and then run a test
with a database that has 10,000 files and --cache_size=1G. RSS for the db_bench
process will be greater than 20G because each file used by an entry in the
TableCache uses 2MB.

Given that LevelDB uses small files by default, big LevelDB databases will have
many files and this is too much memory to use for the table cache. Or is the
use of small files by db_bench not the right way to run big LevelDB databases?

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 14 Sep 2012 at 11:39

I ran into the mmap issue causing the app to crash on iOS. Any ideas how to
reduce memory usage on iOS?I wish the documentation was clearer on tuning
leveldb...

Original comment by<EMAIL_ADDRESS>on 15 Sep 2012 at 11:26

Fixed in 1.6.0

Original comment by<EMAIL_ADDRESS>on 12 Oct 2012 at 8:02

Changed state: Fixed

More details on the performance impact from this are in this thread:
https://groups.google.com/forum/?fromgroups=#!topic/leveldb/mkKRKA4XGb0

The basic problem is that a LevelDB process will try to get as much memory as
possible as reported by RSS to cache the database in its address space. I don't
that is good behavior either for an embedded or a server database.

Original comment by<EMAIL_ADDRESS>on 18 Sep 2012 at 4:02


Not working with ELF dll's

Unable to decompress assemblies in this apk. I get this output,
Checking: libaot-Xamarin.filename.dll.so
b'\x7fELF\x02\x01\x01\x00'

Compressed assemblies begin with the string XALZ (see https://github.com/xamarin/xamarin-android/pull/4686). The example you've given shows an ELF file header (\x7fELF), not a compressed Xamarin assembly.


Install fails on OS X Yosemite

Not sure if I should file this against npm or not, even though the output clearly say to.
 Error: No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! ["2.0.0","2.0.1","2.1.0","2.1.1","2.1.2","2.1.3","2.1.4","2.1.5","2.1.6","2.1.7","2.2.0"]
npm ERR!     at installTargetsError (/usr/local/Cellar/node/0.10.12/lib/node_modules/npm/lib/cache.js:719:10)
npm ERR!     at /usr/local/Cellar/node/0.10.12/lib/node_modules/npm/lib/cache.js:641:10
npm ERR!     at saved (/usr/local/Cellar/node/0.10.12/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:138:7)
npm ERR!     at Object.oncomplete (fs.js:107:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     http://github.com/isaacs/npm/issues
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR!  Additional logging details can be found in:
npm ERR!  /absolute/path/to/web_rtc/npm-debug.log
npm ERR! not ok code 0

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10667185-install-fails-on-os-x-yosemite?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

@exceptDefeat try to update your node version and npm .
take a look at n or nvm

This is a problem with npm itself. Update your npm version.


Nil on encrypt on XCode 9.0

It seems that SecItemCopyMatching doesn't return a keyref. Having problems with SwiftyRSA key creation as well, was working before the XCode update. Relevant code:
guard let heimdall = Heimdall(
            publicTag: "sometag",
            publicKeyModulus: modulusData,
            publicKeyExponent: Data(bytes: [0, 1, 0, 1])) else {
                print("Could not obtain encryptor")
                return
        }
guard let cipher = heimdall.encrypt(someData) else {
            print("Could not encrypt data")
            return
        }

Likely a duplicate of #46


Allow newer version of openai-php/client

Fix #5

@nunomaduro Hey, would be nice to have an update!


San Francisco court scraper

PDAP is going to take a crack at this one. If anyone else is interested in helping, feel free to comment.

Everything in a quote block is from @zstumgoren, and is therefore more authoritative than anything I have to say.

Goal

Our scraping framework generally requires:

A way to search case filings by date, in order to backfill cases systematically by compiling an index of cases going back a few years in time.
A way to search for case filings by case number. This allows us to update case detail information on an ongoing basis.

Properties to collect

case number
date generated
case title

In terms of case details, so far our framework has generally focused on scraping metadata about a case directly available from the web. We are not currently downloading case files, though we wouldn’t be opposed to having that functionality available if you chose to implement it. But our v1 base goal is the ability to compile a docket of all cases and related metadata.

From some basic searching, it seems like the SF court search is somewhat spotty on case details, at least for a handful of recent cases I clicked through. But even if we can get nothing more than the date of filing and a case number, that’s enough for us to check in on a case for details on a regular basis (perhaps those details get posted some window of time after initial filing date).

Hopefully that provides enough detail for you all to get started. Shout back if you have any other questions.

Scraping target
For this court: https://www.sfsuperiorcourt.org/
Case query takes us here: https://webapps.sftc.org/ci/CaseInfo.dll
Search by new filings → date gives us a scrapable paginated table (fig. 1)
Clicking a case number gives us a page with a date (fig. 2)
fig. 1

fig. 2

Other helpful info
Follow this guide: https://court-scraper.readthedocs.io/en/latest/writing_a_scraper.html

Note that there’s no need for CLI integration (we’re planning to deprecate that in the future).

Hello hello,
Happy to get involved where I can.
I have data analytics skills in addition to research and structure around data governance and visualization. Very basic programming skills but happy to learn.

Hey, @abnor. What sort of help might you need to get started? I've taken a look at the target site and have some notes, but I'm not sure what else might be helpful to you.


DateTimeFormat options

Intl.DateTimeFormat has a whole bunch of options, are those represented here? it seems like more configurability is needed
example:

July 24 - 27, 2018
Jul 24 - 27, 2018
July 24 - 27, 18
July 24 - July 27, 2018

The "Jul" vs "July" should be controlled by the month option in DateTimeFormat.  The more interesting question is how to control whether you repeat the month/year even if it would be redundant.
Somewhat related: an API I proposed for currency range formatting in ICU.  I added a knob called collapse to support this for currency ranges (for example, "$3-5" or "$3-$5").  If we wanted to add an option for this, it could be called something like rangeCollapse on the main DateTimeFormat options object.

As @sffc mentioned, there are two types of configuration options in the examples given by @devsnek:

Control the display length of each calendar field.
Being able to expand or collapse fields in the formatted range.

1. This is already being controlled through the options object when instantiating a new Intl.DateTimeFormat. For example:

{year: 'numeric', month: 'long', day: 'numeric'} --> July 24 - 27, 2018
{year: '2-digit', month: 'short', day: 'numeric'} --> Jul 24 - 27, 18

2. Currently, the formatter will choose the date interval pattern solely based on which is the largest different calendar fields between the two dates. This follows the rules defined in TR-35 with the goal of formatting the range as concisely as possible.
For example, for {year: 'numeric', month: 'short', day: 'numeric'}, the interval patterns are:
y: 'MMM dd, y - MMM dd, y'
M: 'MMM dd - MMM dd, y'
d: 'MMM dd - dd, y'
If the day is the largest different calendar field, the interval will be formatted with the d pattern, producing: Jul 24 - 27, 2018.
A possible way to 'expand' the formatted interval could be to force the use of the interval pattern for a larger calendar field, such as for M, producing: Jul 24 - Jul 27, 2018.
Based on @sffc's suggestion,  we could add a new option (rangeCollapse) for this. The user could use it to indicate the smallest calendar field for which they want to use an interval pattern. Something like:

{year: 'numeric', month: 'long', day: 'numeric'} --> July 24 - 27, 2018
{year: 'numeric', month: 'long', day: 'numeric', rangeCollapse: 'month'} --> July 24 - July 27, 2018
{year: 'numeric', month: 'long', day: 'numeric', rangeCollapse: 'year'} --> July 24, 2018 - July 27, 2018

For rangeCollapse, I would expect "month" to mean that months and higher are collapsed, rather than the behavior @fabalbon suggested.  I think good names could be:

Most aggressive collapse behavior: "all", "auto", "day"

i.e., July 24 – 27, 2018

Less aggressive: "year", "year-only"

i.e., July 24 – July 27, 2018

No collapsing: "none", "disabled", "no-collapse"

i.e., July 24, 2018 – July 27, 2018

Another question: how does this work with non-Gregorian calendars?  Or is that out of scope for date interval formatting?

We discussed the rangeCollapse option in the Feb 2019 ECMA-402 meeting. It was decided to leave out for now, as there is no clear demand for it.
Closing this issue for now, we can revisit this on a second version.


Rasa setting a platform specific matplotlib backend fails

Rasa version:
1.4.0
Python version:
3.7.4
Operating system (windows, osx, ...):
Linux Ubuntu 18.04.3 LTS
Issue:
Rasa tries to set a matplotlib backend which is environment specific (and IMO also unnecessary) and fails in headless environments. According to matplotlib docs:

Likewise, the Tk framework (TkAgg backend) does not require any external dependencies and is normally always available. On certain Linux distributions, a package named python-tk (or similar) needs to be installed.

I think this line is the culprit and would be best to just delete it as it is not clear what the motivation is for that line anymore (seems to be based on an old OSX specific issue).
https://github.com/RasaHQ/rasa/blob/5119efcb208fb9b14232f77d313a07c8cd970245/rasa/core/test.py#L19-L21
In addition it would be better if matplotlib is imported inside the function call and not module wide (see here for rationale).
Error (including full traceback):
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
~/test/test-testsuite/source/initializer/tests/test_datapoint.py in
----> 1 from rasa.core.interpreter import RegexInterpreter

~/miniconda3/envs/test/lib/python3.7/site-packages/rasa/__init__.py in
      7
      8 from rasa.run import run
----> 9 from rasa.train import train
     10 from rasa.test import test
     11

~/miniconda3/envs/test/lib/python3.7/site-packages/rasa/train.py in
      5 from typing import Text, Optional, List, Union, Dict
      6
----> 7 from rasa.importers.importer import TrainingDataImporter
      8 from rasa import model
      9 from rasa.core.domain import Domain

~/miniconda3/envs/test/lib/python3.7/site-packages/rasa/importers/importer.py in
      5
      6 from rasa.core.domain import Domain
----> 7 from rasa.core.interpreter import RegexInterpreter, NaturalLanguageInterpreter
      8 from rasa.core.training.structures import StoryGraph
      9 from rasa.nlu.training_data import TrainingData

~/miniconda3/envs/test/lib/python3.7/site-packages/rasa/core/__init__.py in
      4
      5 from rasa.core.train import train
----> 6 from rasa.core.test import test
      7 from rasa.core.visualize import visualize
      8

~/miniconda3/envs/test/lib/python3.7/site-packages/rasa/core/test.py in
     19 import matplotlib
     20
---> 21 matplotlib.use("TkAgg")
     22
     23 logger = logging.getLogger(__name__)

~/miniconda3/envs/test/lib/python3.7/site-packages/matplotlib/cbook/deprecation.py in wrapper(*args, **kwargs)
    305                 f"for the old name will be dropped %(removal)s.")
    306             kwargs[new] = kwargs.pop(old)
--> 307         return func(*args, **kwargs)
    308
    309     # wrapper() must keep the same documented signature as func(): if we

~/miniconda3/envs/test/lib/python3.7/site-packages/matplotlib/__init__.py in use(backend, warn, force)
   1307         if force:
   1308             from matplotlib.pyplot import switch_backend
-> 1309             switch_backend(name)
   1310     else:
   1311         # Finally if pyplot is not imported update both rcParams and

~/miniconda3/envs/test/lib/python3.7/site-packages/matplotlib/pyplot.py in switch_backend(newbackend)
    234                 "Cannot load backend {!r} which requires the {!r} interactive "
    235                 "framework, as {!r} is currently running".format(
--> 236                     newbackend, required_framework, current_framework))
    237
    238     rcParams['backend'] = rcParamsDefault['backend'] = newbackend

ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running

Command or request that led to error:
from rasa.core.interpreter import RegexInterpreter

# or more directly

from rasa.core.test import test

Thanks for the issue, @Ghostvv will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@elyase Thanks for raising the issue. In general we are open to making matplotlib optional.
I added the lines back then in rasa/core/test, but cannot remember the exact reason. I just tried to run rasa test nlu (which plots some graphs) without those lines and it was working fine for me. So, I guess we can do as you suggested.
Do you want to clean it up by yourself and create a PR for it?


Render external services in offer layout

This PR adds external services to the offer printout (PDF)

 Extend offer HTML template

Nice, it worked!
I found that the overheads for external services is not listed in the overview of overheads but you provided it in the template. Was that on purpose?

Thank you Jenny.  Yes, it is only shown when overheads for external services are applied, to reduce unnecessary complexity of no information content.

The only thing I can criticize is, that its not clear that VAT is only applied to the external service. This might cause confusion because its not transparant where the VAT is coming from and to what it is applied.

Yes, i left it open to provoke discussions about that issue.

Thank you Jenny. Yes, it is only shown when overheads for external services are applied, to reduce unnecessary complexity of no information content.
For consistency, I would expect then the same for the other product groups as well.

Yes, i left it open to provoke discussions about that issue.
I see 👌🏼

Thank you Jenny. Yes, it is only shown when overheads for external services are applied, to reduce unnecessary complexity of no information content.

For consistency, I would expect then the same for the other product groups as well.

I argue, that consistency is not helpful, when we provide an information that represents a special case for external services.


Add support for efficiently inlining SVGs

This PR adjusts the webpack config to efficiently inline SVGs into CSS (following this webpack documentation).
data:image/svg+xml, is used instead base64 which reduces the overhead significantly.
It also updates two loaders (css-loader and url-loader) to add the required options and compatibility.
The node-sass package is also updated to make npm install on platforms like WSL working.

Hm, node v8 isn't compatible with the new releases of these two loader packages, hence the CI build fails.


Remove redundant output_with_attributes from python builder

Another part of #2267 that makes sense to live on it's own. Sorry for so many small PRs! But whittling things down like this is helping me better remember where everything stands

This function isn't used anywhere else and all tests passed. Merging!


Fix hosted docs

Now using travis-cargo to automatically host the docs on github.io
This needs manual intervention before it can land: It needs an encrypted GH_TOKEN set in the Travis setting or .travis.yml to upload the docs to the gh-pages branch. Refer to the travis-cargo docs for details.

Ping @brendanzab

Maybe what docs.rs hosts is sufficient. In that case, perhaps a link should be added to the readme instead.


Minor fixes for interactive window message & code cells

Today (webview based)

Current (too many spaces in info message & trailing spaces in code)

After the fix

Codecov Report

Merging #6631 (2be21eb) into main (d20d44f) will increase coverage by 4%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##            main   #6631     +/-   ##
=======================================
+ Coverage     64%     69%     +4%
=======================================
  Files        352     410     +58
  Lines      24542   28282   +3740
  Branches    3750    4205    +455
=======================================
+ Hits       15930   19611   +3681
+ Misses      7194    7009    -185
- Partials    1418    1662    +244

Impacted Files
Coverage Δ

...ence/interactive-window/nativeInteractiveWindow.ts
5% <0%> (ø)

src/client/datascience/jupyter/kernels/kernel.ts
68% <0%> (ø)

src/client/datascience/types.ts
100% <0%> (ø)

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (ø)

src/client/common/application/encryptedStorage.ts
44% <0%> (ø)

...ent/datascience/notebook/notebookEditorProvider.ts
81% <0%> (ø)

src/client/extensionActivation.ts
97% <0%> (ø)

src/client/datascience/notebook/remoteSwitcher.ts
91% <0%> (ø)

src/client/common/application/languageService.ts
60% <0%> (ø)

...ience/notebook/emptyNotebookCellLanguageService.ts
76% <0%> (ø)

... and 167 more


Investigate removing role=“group” from date input fieldset

What
We set role="group" on the fieldset of the date input component.
The W3C Markup Validator flags it as warning

The group role is unnecessary for element fieldset.

It seems it was added to improve accessibility with Jaws
https://github.com/alphagov/govuk-frontend/pull/681#issuecomment-386665516 and https://github.com/alphagov/govuk-frontend/commit/759fd5a506bda929eaf0c23a43eadac92175bf98
I’ve done some preliminary testing as part of documenting warnings. I did this with the error message present on the page as the comments suggest that was part of the initial problem. I found no difference in announcements with Jaws 15, Jaws 2018 or NVDA with Firefox with/without role="group". However in Jaws 16 the addition of role="group" made the announcements less helpful:

with role="group", Jaws announced “day edit type of text”
without role="group", “expiry date day edit type of text”

I also tested in Jaws 15, 16 and 2018 by skim reading the page (Ctrl+Insert+PageDown) and didn't hear any difference with role="group" present/removed.
We should do a bit more testing as my initial investigation might have not covered all the possible scenarios.
Why
Who needs to be involved in this
Developers
Done when

We did some testing:
While role="group" seems to make no difference in most cases, we did find that:

Using role="group" makes Jaws 2020 in IE11 read out the hint and error message.

Removing role="group" makes Jaws 16 and IE11 read out the question.

Unfortunately we don't have access to Jaws 17 and 18 at the moment so couldn't test in those versions.

Based on the testing we've done we've decided to keep this attribute as it improves IE11 for JAWs users as they will hear the hint and error message being read out, we'll review this if anything changes.


implement track_process

see https://manpages.debian.org/unstable/keepalived/keepalived.conf.5.en.html for the advantages of track_process

implemented on branch  track_process
upstream pr opened


[Cache] Cache improvements

This is an generic issue to list ideas/improvements that can be done to the normalized cache

[ ] add pagination APIs
[ ] Implement LRU to make sure the SQLite cache doesn't grow bigger than a given size
[ ] Implement a garbage collector to remove nodes that are not reachable anymore
[ ] Allow to manually evict entries (already possible with apolloStore.remove()?)
[ ] Diagnostics for cache HIT/MISS (see https://github.com/apollographql/apollo-android/issues/2397)
[ ] Different strategies for memory vs disk caches
[ ] Allow to bypass normalization
[ ] Allow to update deeply nested fields (https://spectrum.chat/apollo/apollo-android/update-cache-using-previous-query-data-ios-parallel~bd005192-cbf7-440b-9482-8adb028e283d)
[ ] Typename in CacheKeyResolver (https://github.com/apollographql/apollo-android/issues/2496)
[ ] Network before stale (https://github.com/apollographql/apollo-android/issues/2502)
[ ] Cache redirects  ?
[ ] Query optimization ?

I assume this requires weigher API if you're still planning to use Dropbox/Store/cache? Are there any other features / API changes you'd like to see from cache to enable these improvements?

@ychescale9 I think multiplatform is a big one. I don't think Store supports multiplatform yet?
Multiplatform would be required for the LruNormalizedCache to be used from apollo-runtime-kotlin

@martinbonnin multiplatform support for Store itself has been deprioritized. I’m keen to push for KMP support for the cache module first which currently is JVM only and does not depend on coroutines, so we can unblock apollo-android.

That's be great! I think cache4 is all we need. I don't think we use store at the moment.

@martinbonnin  Could this be also part of these improvements related to cache eviction:
https://github.com/apollographql/apollo-android/issues/2507


[Question]: What is the difference in configuration between headless:true and headless:false

Bug description
Hi, I wanted to know the difference between headless:false & headless:true mode?
This can help me to figure out why certain functionalities such as downloading a pdf etc, works in headless:false but not in headless:true.
Can someone please help? Or provide some configuration/setup details?
Puppeteer version
puppeteer-extra(3.1.16)
Node.js version
12
npm version
6.14
What operating system are you seeing the problem on?
Linux
Relevant log output
No response

Headless:true runs puppeteer in the background without opening a new browser page in contrast Headless: false opens a new browser page for you to see the process running


Installation

Hi Peter,
Firstly, this is not an issue but rather expression of appreciation for an excellent project.
I have a query regarding installation.
Do I pass "action:install" as a command line parameter?
Many thanks
Fig

I believe it would be something like this cd to your bin folder of you project.
yourservice.dll action::install
I tried this with the sample project though and got an issue where its looking for a System.Runtime 4.2.0 and could not find this dependency.

Thanks Peter. I will give it a try.


To restrict the ip address can access smartconsole

Describe the Issue
To restrict workstation ip address that can access smartconsole
Additional Context
System and Setting -> Permission & Administration -> trusted client
Acceptance Criteria

[ ] not any source
[ ] trusted ip address
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Closing this issue as we no longer intend on using smartconsole


Allow pass opts to Repo in custom_index_query and custom_show_query callbacks

I'm building an app that uses foreign key strategy to implement multi-tenants, identical to the example presented in Ecto Guides (https://hexdocs.pm/ecto/multi-tenancy-with-foreign-keys.html).
To make this possible, I need to pass options to Repo. Like the example shown on Ecto guide:
MyApp.Repo.all(Tenant, skip_tenant_id: true)

Kaffy does not support passing opts to Repo from custom_index_query and custom_show_query. The purpose of this pull request is to eliminate this limitation, without introducing breaking changes.
# Introduced by this pull request
defmodule MyApp.Accounts.TenantAdmin do
  def custom_index_query(_conn, _schema, query) do
    {query, skip_tenant_id: true}
  end
end

# It's still support the old way
defmodule MyApp.Blog.PostAdmin do
  def custom_index_query(_conn, _schema, query) do
    from(r in query, preload: [:tags])
  end
end

Closed in favor of #172


[builder.names] set empty weight string if 'Regular'

same as we do for the 'width'.
Fixes https://github.com/googlei18n/glyphsLib/issues/300

I solution is to put all pieces in an OrderedSet and remove "Regular" if it has more than 1 elements. Because you normally what to keep the "Regular" if there are not other elements.

yeah, but that is already handled by the build_style_name function
def build_style_name(width='', weight='', custom='', is_italic=False):
    """Build style name from width, weight, and custom style strings
    and whether the style is italic.
    """

    return ' '.join(
        s for s in (custom, width, weight, 'Italic' if is_italic else '') if s
    ) or 'Regular'

I could bake the logic of "treat the string 'Regular' as a special one but only for the width and weight attributes" inside the build_style_name function itself.
However, I prefer to leave it to the caller to pass correct input (and that is what we were already doing for the width -- where Regular was special-cased by the caller - but not for the weight).
Garbage in, garbage out.


Layout autoresize

Can someone test this new feature? Please feedback.

How much of this could be achieved by using width:100% in non-containers?
In other words is all this work necessary because everything has hard coded sizes instead of inheriting what they can inherit from their parents in the HTML?

Yes, this is necessary because of the hardcoded size. Are you thinking about removing layout control?

I'm not really thinking of removing it, just trying to think if it is
necessary in evey widget
On 20/11/2015 4:20 PM, "Davide"<EMAIL_ADDRESS>wrote:

Yes, this is necessary because of the hardcoded size. Are you thinking
about removing layout control?
—
Reply to this email directly or view it on GitHub
https://github.com/dddomodossola/remi/pull/80#issuecomment-158429899.

Mixing sizes in "%" and in "px" can have negative effects. The "exception" have to be managed in the library layouting functions. Furthermore, inheriting size from parents, the children in a container will have the same size.

Hi John, following the discussion we got about the Container class you would like to make, do you think that I can merge these changes? Or it is better to add autoresize capabilities only to Containers?

I would not merge this yet, I think it is better left to containers.
I think non container widgets could have expand properties, which could translate into width=100% or width=parent-margin, if the widget is inside a container.
I think it needs more thought.


Meow

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

95 of 118 (80.51%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+2.6%) to 89.833%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

aio_pika/connection.py
7
8
87.5%

aio_pika/tools.py
3
5
60.0%

aio_pika/queue.py
45
65
69.23%

Files with Coverage Reduction
New Missed Lines
%

aio_pika/queue.py
1
80.08%

Totals

Change from base Build<PHONE_NUMBER>:
2.6%

Covered Lines:
1965

Relevant Lines:
2149

💛  - Coveralls


implementing V2 inside V1 instead

@jpslav I made some fixes and cleaned up code. It's ready for review :slightly_smiling_face: Sorry it took so long, but I was working on other issues with higher priority and couldn't look at this earlier.


Roll Engine from b0f3c0f7e478 to dd28b6f1c8e6 (19 revisions)

https://github.com/flutter/engine/compare/b0f3c0f7e478...dd28b6f1c8e6
2021-09-22<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from NM9FaaYay... to nblJjRFDA... (flutter/engine#28803)
2021-09-22<EMAIL_ADDRESS>[canvaskit] Fix bug when overlays are disabled (flutter/engine#28790)
2021-09-22<EMAIL_ADDRESS>Roll Dart SDK from 4e396689de4f to 6e17953f4e7e (1 revision) (flutter/engine#28800)
2021-09-22<EMAIL_ADDRESS>Disable failing unit tests on UWP (flutter/engine#28785)
2021-09-22<EMAIL_ADDRESS>Roll Dart SDK from 715a98df1828 to 4e396689de4f (1 revision) (flutter/engine#28797)
2021-09-22<EMAIL_ADDRESS>Roll Skia from<PHONE_NUMBER>f5 to cb25d566c21d (3 revisions) (flutter/engine#28796)
2021-09-22<EMAIL_ADDRESS>Roll Dart SDK from c2429dee845e to 715a98df1828 (1 revision) (flutter/engine#28795)
2021-09-22<EMAIL_ADDRESS>Roll Skia from bb30fc16e1be to<PHONE_NUMBER>f5 (1 revision) (flutter/engine#28794)
2021-09-22<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from JD40LpEJO... to bWZcp2jnx... (flutter/engine#28793)
2021-09-22<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 3k3-vCrm5... to NM9FaaYay... (flutter/engine#28792)
2021-09-22<EMAIL_ADDRESS>Roll Skia from a48e7b0186b3 to bb30fc16e1be (1 revision) (flutter/engine#28791)
2021-09-22<EMAIL_ADDRESS>Roll Dart SDK from 86a21d182523 to c2429dee845e (1 revision) (flutter/engine#28789)
2021-09-22<EMAIL_ADDRESS>Set MinimumOSVersion to iOS 9 in Info.plist (flutter/engine#28783)
2021-09-22<EMAIL_ADDRESS>Eliminate unnecessary canvaskit imports (flutter/engine#28787)
2021-09-21<EMAIL_ADDRESS>Roll Skia from e32309d771ee to a48e7b0186b3 (10 revisions) (flutter/engine#28782)
2021-09-21<EMAIL_ADDRESS>[web] clear surfaces on hot restart (flutter/engine#28675)
2021-09-21<EMAIL_ADDRESS>Roll Dart SDK from a0243abd09e3 to 86a21d182523 (6 revisions) (flutter/engine#28779)
2021-09-21<EMAIL_ADDRESS>Replace jcenter() for mavenCentral() (flutter/engine#28777)
2021-09-21<EMAIL_ADDRESS>Implement a default font manager for Fuchsia. (flutter/engine#28673)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from JD40LpEJOINC to bWZcp2jnxHum
fuchsia/sdk/core/mac-amd64 from 3k3-vCrm5vcT to nblJjRFDAh-l
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Documentation ordering

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Reading the documentation in a sequential order needs to be more ... sequential.
As an aside, there probably needs to be a separate issue category for documentation, if Doc issues are intended to be entered as issues.  For now I used the bug category:
Background: I decided to read the documentation systematically from scratch as if I had never used tasks before. I think some people do that with reasonably complex software. I must admit I found the ordering a bit jarring.

You start in "Getting Started" which has two separate Tables of Contents, one at the top and another at the bottom. The Bottom TOC is partially unrelated to the Top TOC, some bits refer to stuff outside of the getting started section, and the material in the Getting started section really isn't novice material at all.

The ordering really needs tweaking as well - Someone reading the getting started section is going to get launched, as almost the first thing they read, onto Custom Statuses in Getting started on the left menu -- which is almost the most complex area of the plugin.

Some of the items in the How Tos really should be elsewhere. I'd have thought the How to should really be reserved for odd single (per page) topics and hints that don't fit easily anywhere else. Two of the sections in How To are about statuses -- which should go with Statuses (and then more status stuff appears under References). Most of the things under Advanced could just as easily go in the How Tos. Some things in advanced (Quickadd and Reminders) should logically appear under other Plugins (which at the moment just has Dataview).

Some of the stuff that a person "Getting Started" needs to know is not in the getting started section at all, for example the entire Query section would be missed if all they read was getting started - and all they would have read is one single Query example, so would not be able to start anything at all.

Pages should not have a TOC at the top (for that page) and then a separate thing also called a TOC at the bottom, which is something very different, and which bears no relation to the side TOC.

Current behaviour
As above
Steps to reproduce
Reading it
Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version
Not relevant
Tasks Plugin Version
Not relevant
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
I know the above isn't very constructive, So the below is a constructive suggestion as to structure. I am happy to help
========
I suggest: After the installation section what is needed is the following and everything can fit within that structure:
A) Getting started : This should be a genuine getting started - someone reading through it should be started. They should be able to write simple tasks, have read about most simple queries, and should not have read anything about Statuses, using filenames as dates, or a lot of the other stuff there.
B) Advanced: And under that
B1) Statuses (everything about Statuses here - not in four different places)
B2) More Advanced Queries
B3) Autosuggest
C) How Tos and advanced

Use filename in date
Find tasks for coming 7 days
Find tasks with invalid data
How to get tasks in current file
How to style backlinks
Show tasks in a calendar
Daily Agenda
Styling
(Urgency should go with advanced queries)

D) Other Plugins

Notifications
Quickadd
Dataview

E) Quick reference

Hi @aubreyz,
The problems
I agree with a lot of this.
I had already logged some of the pain points with the current documentation system, from the perspective of authoring the docs - the tables of contents would be another one:
https://github.com/obsidian-tasks-group/obsidian-tasks/issues/1508
Brave new world
This post is great timing, as yesterday I got an invitation from the Obsidian team to use Obsidian Publish for Tasks docs, if I wanted.
So I am probably soon to rework the Tasks docs to use Obsidian Publish - so it's a good time to improve the structure, as all the URLs will change anyway.
I had a bit of a sleepless night last night thinking about ways to improve the structure of the docs, and then this came in 🤣 . I haven't typed up my ideas yet.
Ordering of sections in side bar
One thing to say is that the menus in the new system will end up looking somewhat similar to that of the Obsidian docs:
https://help.obsidian.md/Obsidian/Index
As I understand it, there is currently no easy way to control the order of the pages and the sections - it is alphabetical order. This may have a bit of an impact on your proposal.
Divio Documentation system
If you haven't seen it already, you might like to have a read about the Divio system for structuring documentation.
https://documentation.divio.com
Given a blank slate, I was thinking of adoption this kind of structure, so that each page has a clear purpose.
With a system backed by Obsidian, it will be very easy to have smaller, more focused pages, rather than the big long amorphous blobs that we currently have.

I've set up issues for migrating to Obsidian publish:

#1705
#1706

After this, it will be very feasible to improve the structure of the docs.

Hi @aubreyz, FYI I've made some initial improvements to the structure of the docs site now.
See the summary, and maybe the diffs too, in:

#1935

Places that may be of interest:

https://publish.obsidian.md/tasks/Introduction#Navigation+around+this+site
The 'About...' files in every folder - particular ones:

https://publish.obsidian.md/tasks/Getting+Started/About+Getting+Started
https://publish.obsidian.md/tasks/Queries/About+Queries

Let me know if you are interested in having a chat to discuss possible future improvements... (Email address in GitHub profile)

I'm sorry I have been somewhat absent over recent weeks. Will take a look over the weekend. I think the important thing is for me to try read as if I have never used the plugin at all, and probably also as if you don't fully know what a markdown task is at all.

Hi @aubreyz, I hope you're well.
I've been thinking about this a lot recently - as the number of features in Tasks has grown, the documentation has become even harder to navigate... Filters, Sorting and Grouping are enormous...
And there are some new features coming in soon that will add yet more docs pages...
With using Obsidian Publish now, it's become fairly easy for me to add redirects, to divide up pages, and to detect broken links.
I have a few baby ideas of how to improve the structure but nobody really to discuss it with and bounce ideas off.
So.... Is there any chance you might be able to spare a little time for a chat about how to get started on this? We could do some experiments and see what works...
Email address in GitHub profile here, if you're interested...

Hi @aubreyz, I hope you're well.
I've been thinking about this a lot recently - as the number of features in Tasks has grown, the documentation has become even harder to navigate... Filters, Sorting and Grouping are enormous...
And there are some new features coming in soon that will add yet more docs pages...
With using Obsidian Publish now, it's become fairly easy for me to add redirects, to divide up pages, and to detect broken links.
I have a few baby ideas of how to improve the structure but nobody really to discuss it with and bounce ideas off.
So.... Is there any chance you might be able to spare a little time for a chat about how to get started on this? We could do some experiments and see what works...
Email address in GitHub profile here, if you're interested...

I'd be delighted - will E-mail you privately


Lightning detection sensor?

Is your feature request related to a problem? Please describe:
It's frustrating to not be able to use lightning detection to trigger automations in HomeKit
Describe the solution you'd like:
The ability to configure a contact sensor that triggers when lightning has been detected. Configuration parameters might include the maximum lightning distance that triggers the sensor, and how long to keep the contact sensor closed after an in-range strike is detected. So the contact sensor could be configured to, for example, trigger when lightning has been detected within 10 miles in the past 15 minutes.

Great idea. I'll include this in my next minor version update.

As reference, I did something similar in my homebridge-awair2 plug-in adding limit switches for VOC and PM2.5 using occupancy sensors.

@jlg89 I have noted this feature request. I am going to close this issue. We'll try and work this idea into an upcoming feature release. Thanks for the feedback!

I want to add some context to this feature request, because I know that the frequency of thunderstorms is widely variable. Where I live, we have thunderstorms up to 30% of the time, mostly in summer months, and all our outdoor activities are ultimately governed by lightning. If a strike has been detected within 6-7 miles (typically) within the last 15 minutes (typically), everything from public swimming pools to airport fueling crews comes to a halt. It's a Really Big Deal(tm). So, being able to trigger automations based on the proximity & timing of the last lightning strike would be an immensely useful feature for those in thunderstorm-heavy areas.

Hey @jlg89
I started working on this in a release branch. https://github.com/chasenicholl/homebridge-weatherflow-tempest/tree/release-4.2.0
I will publish a beta on npm. Could you help me test this feature?

Be glad to. Sorry for the delayed response, I was finishing some classwork.

Looking at the config for 4.2.0, I have a couple comments/questions.
The lightning sensor is currently under "contact_properties" which I assume you'll update to something more informative at some point. I'd say either "lightning_properties" or "strike_properties" or something like that.
"trigger_distance" is understandable, using e.g. "6" would make the contact activate only when lightning is detected up to 6km away.
I have a question about the "trigger_time" value. The description seems to indicate that it is like "trigger_distance" in that multiple strikes must be detected within the set time interval in order to activate the contact. Is this correct? The behavior I'm after would be for the contact to remain active for the "trigger_time" duration after each strike that is detected within the "trigger_distance" range. This could also be accomplished by simply keeping the contact active for a few seconds (maybe refresh interval minus 1s?), and using the contact to trigger a timed switch in another plugin like homebridge-dummy, or an automation.

Great observation. I am going to remove the trigger time and instead have it trigger for a few seconds and then reset itself.

So a usage scenario would be:
Most outdoor public swimming pools in Texas require everyone to stay out of the pool if lightning has been detected within a 10-mile radius with the past 30 minutes. Same rule for indoor pools, but with a 3-mile radius.
Let's say you want to know when lightning has struck within 10 miles of your weather station within the past 30 minutes.
In homebridge-weatherflow-tempest, configure the lightning sensor with a trigger_distance of 16 (16km=10mi).
(Question: how does the "units" setting affect this, if at all?)
In the homebridge-dummy plugin, configure a "Resettable Timed Switch" with a 30-minute timer:
    "accessories": [
        {
          "accessory": "DummySwitch",
          "name": "Lightning Alert",
          "time": 1800000,  <== number of milliseconds in 30 minutes
          "resettable": true
        }
    ]

Create a HomeKit automation that turns on the "Lightning Alert" dummy switch whenever the lightning sensor turns on.
Create other automations or shortcuts  based on the state of that Lightning Alert switch. One idea would be to set one or more smart lights to turn red as long as the Lightning Alert switch is on. Red lights mean stay out of the pool!

I have realized a similar scenario directly in HomeKit making use of a Shortcut. In my case, I wanted to know if I left either of my garage doors open for more than 30 minutes. I used Controller for home to make the OR scenario which started the timer when either of the garage doors opens. At end of the timer, a check is performed on the garage door state and if still open I get a notification.
Bringing up as going the Shortcut route may provide more flexibility than hardcoding in the plugin.

If you close & reopen the garage door while the timer is running, does it reset the timer? That would be important for this application. I went this route since I'm already running homebridge and using homebridge-dummy for other things, and I know that the "Resettable Timed Switch" does exactly what's needed...but a Shortcut-based solution would be more elegant and flexible.

I am using Controller for HomeKit app in combination with the HomeKit automation and Shortcut. Controller for Home allows the OR function of the 2 garage doors (which you would not need) as well as providing the notification message if either garage door is open at the end of the 30 minutes. Needed to use Controller for HomeKit for the notification message as this functionality is not native to Shortcuts.
I believe each time the garage door open that the timer is reset but may need to do some tests to find out.
I purchased Controller for HomeKit app ages ago when it first came out and was pretty reasonable. Now it is a bit more expensive.

Just installed 4.2.4b2 and setup seems to work properly, but the lightning contact sensor is going on and off at least every minute.

Just installed 4.2.4b2, and the lightning sensor is going on and off randomly.

{
            "name": "Lightning Detected",
            "sensor_type": "Contact Sensor",
            "contact_properties": {
                "trigger_distance": 16
            }
        }

Oddly, the random triggers stopped after a couple of hours, and have remained quiet. But we've had thunderstorms today, and lightning has been detected within the set radius, but the plugin hasn't triggered. I don't see anything particularly amiss in the logs -- let me know what debug setting to use, if you want those. When I start the plugin, this is the typical log:
[14/12/2024, 09:17:04] [WeatherFlowTempest] Launched child bridge with PID 149276
[14/12/2024, 09:17:04] The plugin "homebridge-weatherflow-tempest" requires Node.js version of ^18.20.4 || ^20.15.1 which does not satisfy the current Node.js version of v22.12.0. You may need to upgrade your installation of Node.js - see https://homebridge.io/w/JTKEF
[14/12/2024, 09:17:05] Registering platform 'homebridge-weatherflow-tempest.WeatherFlowTempest'
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loaded homebridge-weatherflow-tempest v4.2.4-beta.2.0 child bridge successfully
[14/12/2024, 09:17:05] Loaded 5 cached accessories from cachedAccessories.0EFE4724592E.
[14/12/2024, 09:17:05] [WeatherFlowTempest] Finished initializing platform: WeatherFlowTempest
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loading accessory from cache: Temperature
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loading accessory from cache: Relative Humidity
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loading accessory from cache: Light Level
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loading accessory from cache: Wind Speed
[14/12/2024, 09:17:05] [WeatherFlowTempest] Loading accessory from cache: Lightning Detected
[14/12/2024, 09:17:05] [WeatherFlowTempest] Executed didFinishLaunching callback
[14/12/2024, 09:17:05] [WeatherFlowTempest] Initializing by Socket
[14/12/2024, 09:17:05] [WeatherFlowTempest] Using Tempest Local API.
[14/12/2024, 09:17:05] [WeatherFlowTempest] TempestSocket initialized.
[14/12/2024, 09:17:05] [WeatherFlowTempest] Waiting for first local broadcast. This could take up to 60 seconds...
[14/12/2024, 09:17:05] Homebridge v1.8.5 (HAP v0.12.3) (WeatherFlowTempest) is running on port 44257.
[14/12/2024, 09:17:05]

NOTICE TO USERS AND PLUGIN DEVELOPERS
> Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> Please visit the following link to learn more about the changes and how to prepare:
> https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0

[14/12/2024, 09:17:06] [WeatherFlowTempest] Initial local broadcast recieved.
[14/12/2024, 09:17:06] [WeatherFlowTempest] Restoring existing accessory from cache: Temperature
[14/12/2024, 09:17:06] [WeatherFlowTempest] Restoring existing accessory from cache: Relative Humidity
[14/12/2024, 09:17:06] [WeatherFlowTempest] Restoring existing accessory from cache: Light Level
[14/12/2024, 09:17:06] [WeatherFlowTempest] Restoring existing accessory from cache: Wind Speed
[14/12/2024, 09:17:06] [WeatherFlowTempest] device.sensor_type not defined
[14/12/2024, 09:17:06] [WeatherFlowTempest] Restoring existing accessory from cache: Lightning Detected
[14/12/2024, 09:17:06] [WeatherFlowTempest] discoverDevices completed
[14/12/2024, 09:17:06] [WeatherFlowTempest] removeDevices completed

I think I know what’s going on. I designed the contact sensor loop to “re-engage” after 5 seconds. In other words, if lightening detected in the last 5 seconds, within the range specified, open contact sensor for 5 seconds. After those 5 seconds close sensor.
so if there was a storm I’m realizing this will give an on/off effect. I should update the logic to remain open after 5 seconds if there is still valid strikes.

There wasn't a storm when it was randomly going on/off, it was doing that on its own somehow, and only for a couple of hours -- but then when there was a storm, it didn't do anything at all. Maybe something with the way the plugin interprets the "time since last strike" value?
I think it's correct behavior to close after 5 seconds, and only reopen if another strike is detected after the 5 seconds have elapsed. That allows the user to determine how to handle multiple strikes. In my case, I want each strike to reset the 30-minute counter on the dummy alert switch. If two strikes occur within one 5s period, I'm not too concerned about that.

I'm curious how the Tempest reports lightning strikes. When you look at the app or the web page for the device (e.g. the one I'm working with is https://tempestwx.com/station/129765/grid), it shows how long ago lightning was last detected, and the distance, and a counter for the number of strikes in the last three hours. But the app only sends me a notification right when lightning strikes -- so there must be a particular boolean that goes true when a strike is detected, but I wonder how long that boolean stays true?

The API reports the latest singular event like so.
"lightning_strike_last_epoch":<PHONE_NUMBER>
"lightning_strike_last_distance": 22
"lightning_strike_count_last_3hr": 0

I assume the iOS app and website have a separate database or cache that records each on of these instances so they can provide the historical graph.
Anywho back to your observation of funny-ness at plugin start, and then no behavior during an actual storm. I'll have to look into this more myself. Next week I'll have more time to play around, hopefully we can get this feature out the door before the new year. Thanks!

Turns out it isn't just at plugin start. Every now and then, it just triggers on/off. It happened one time yesterday evening, and today it's been doing it every minute for the past 20 minutes or so, it will probably stop soon. According to the app, the last lightning detected was 2 days ago.

I wonder, in platformAccessory.ts, line 650, if you moved the (current_epoch_now - lightning_strike_last_epoch) calculation outside the "if" statement? It shouldn't matter, but maybe worth a try. Plus if you set another variable there it would be easier to log that value to sanity check the output.

Just an update, we've had several thunderstorm days over the past week. Oddly enough, there doesn't seem to be any connection between this contact sensor and actual lightning strikes.  During thunderstorms, it might not trigger at all.
I'm hoping you'll spot some obvious issue in the code, but if you don't, then just add whatever logging data would be most useful, and I'll run it in debug mode and give you the output.


fix issue labels

This can be closed when @katyhuff has fixed the issue labels for this repo.

@katyhuff I made some changes to the labels. Could you please review the current labels and give me feedback whenever possible? I'd be happy to assign myself to this issue and fix them.

I have a script that will fix them using the github api. If you don't mind waiting, I'll try to do it this weekend to all the repsitories and upload the script to a gist.
These are the ones I like: https://github.com/arfc/mlmc


[Feature][Task]Task plugin spi

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (task-plugin@4715de1). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             task-plugin    #6116   +/-   ##
==============================================
  Coverage               ?   42.01%
  Complexity             ?     3528
==============================================
  Files                  ?      660
  Lines                  ?    25888
  Branches               ?     2850
==============================================
  Hits                   ?    10877
  Misses                 ?    13990
  Partials               ?     1021

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4715de1...30e1551. Read the comment docs.


Should include steps for MBR and other filesystems like XFS

The article should also include steps for MBR disks (fdisk) and other filesystems such as XFS (xfs_growfs).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06c61c5a-d9e4-742b-36e5-b9effa33d903
Version Independent ID: cb9dbd59-460d-a1a0-9863-5213d6a1093e
Content: Expand virtual hard disks on a Linux VM in Azure
Content Source: articles/virtual-machines/linux/expand-disks.md
Service: virtual-machines-linux
GitHub Login: @roygara
Microsoft Alias: rogarana

Also, some distros don't have the latest version of parted which doesn't have the resize command.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@msLinuxNinja Sorry for the delayed response but thank you for reaching out. We won't be adding that into the article at this time but, I have taken an item for my backlog to evaluate whether or not we would like to do so later.
Again, we really do appreciate you reaching out.
#please-close


Upgrade artifact actions

GitHub has announced that v3 of the actions/upload-artifact and actions/download-artifact actions will be deprecated on November 30, 2024^1. The action has been upgraded to its most recent version to continue functioning after this date.

Hm, any idea why the tests for Windows failed?


[FR] hide notifications entry

My simple user using kiosk mode should not see or open any notifications.
Still I'd like to have the sidebar. Can a hide_notification be added?

Hi @pkoevesdi,
I‘ll take a look at the code to check if your proposal can be achieved.
I‘ll let you know, leting this issue open until then.
Regards

Hi @pkoevesdi,
After this gets merged and a new version of the library is released, this feature will be available in kiosk-mode.
Regards

Wow, that was fast, thank you soo much!


C#: Use explicit native extension loading whenever possible

Tentatively fixes the hang issue described in https://github.com/grpc/grpc/issues/25208.
The problem is a side effect of https://github.com/grpc/grpc/pull/24744.

CC @jskeet

Adhoc package/distribtest build: https://fusion2.corp.google.com/invocations/8ea33ee1-a3d8-4d75-bc37-89071a20ab4e/targets

One more adhoc run of packages/distribtests: https://fusion2.corp.google.com/invocations/03d594b8-1240-43e2-9cb3-b505e14318fc/targets

Also fixes https://github.com/grpc/grpc/pull/7303

The adhoc build of nugets is here:
https://storage.cloud.google.com/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/master/linux/grpc_build_packages/15732/20210218-065115/github/grpc/artifacts/csharp_nugets_windows_dotnetcli.zip
@jskeet do you want to test the nugets and see if that fixes the problems you've encountered?
All the distribtests seem to be passing.

I'll do a test tomorrow, thanks.

My specific "hang test" worked, as did the smoke tests for an actual API - great! Thanks very much :)


Title: update redme.md file with latest correcction under (gssoc-23)

Is your feature request related to a problem? Please describe.
Hi @agamjotsingh18
as our readme file is outdated, which means changes are not displayed in the current readme file.
I am contributing under gssoc'23.
Please label it.
Thank you
Describe the solution you'd like.
Replace Sneak Peek of the Website: section with the new image.
Describe alternatives you've considered.
The new readme looks like this:

Add any other context or screenshots about the feature request here.
No response

Sure @gulshanjakhon , Capture the ss again, some changes are there, also check the documentation whereever changes required


Reverse generation: spreadsheet to bitmap image.

Add a feature to allow the program to turn an existing spreadsheet into an image. Not sure what the rules would be I. E pixel to pixel or cell to pixel representation but can be sorted during scoping of this feature.

To do tonight (no lapping!)


Support EF from another project

Hello,
In my project there is the same edmx for API and WPF clients.
Is it possible to create the pattern with an external project with EDMX as the only files in it ?
Regards

Hi tematim,
Yes, its possible.
Your external project must have a folder named "Models" (for example) in the root of the project with EDMX file in it.
After that, click on Generate button located on Visual Studio menu and, in settings panel, put the name of that external project and the name of models" folder" with .edmx file.
Regards


Add compute_null_per_col

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9d18ce8) 99.89% compared to head (54305c5) 99.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   99.89%   99.89%
=======================================
  Files          47       48    +1
  Lines         980      988    +8
  Branches       98       98
=======================================
+ Hits          979      987    +8
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[dv/kmac] add manual coverage exclusions

This PR adds the initial round of manual coverage exclusions for both
variants of the KMAC.
These exclusions only include:

LOW_RISK exclusions that remove entire modules from coverage
collection (such as adapter TLUL logic).
UNSUPPORTED exclusions that exclude, for example, masking-related
logic in the unmasked KMAC variant, or app-interface-related logic
that does not have a use-case in the overall OpenTitan chip.

Have discussed and approved these with the designer.
Signed-off-by: Udi Jonnalagadda<EMAIL_ADDRESS>

LGTM

Latest force push removes all exclusions in these files marked as UNR, pending some discussion with Synopsys AEs.
Only exclusions remaining are UNSUPPORTED or LOW_RISK, as explained in the commit message.
Thanks to @matutem for the suggestion to do this.

latest force push removes the common TLUL modules from coverage exclusions - total code coverage for both KMAC variants is still remaining above the 90% threshold for V2 status.


Suggestion for multi-lines comments and folding

VSCode Version: 1.17.1
OS Version: Windows 10

Steps to Reproduce:

Write a multi-lines comment using /** */. Eg:

/**
 * This is my comment
 * on multiple lines.
 */

Fold up the comment

 /** ...

Reproduces without extensions: Yes
Suggestion:
It would be good to have the first line of the comment when folded. Eg:
/** This is my comment...

Best regards

Thanks. Looks like we are already tracking this with #31966
Closing as a duplicate of #31966


Find and Remove: Delete Whole Line

When the entire contents of a line are deleted (with the exception of white space) in the remove Remove Matches option, remove the entire line if it is empty. Instead of just having a blank line.

I think this works fine?

good call

actually nevermind


Not compatible with Magento 2.4.5

The module is not compatible with Magento 2.4.5.
Could you please update the module?

Thanks for the feedback. There is a new release, that should work.


Change URLs of some of the clients to point to new API infrastructure

Use RequestHost.Initialize to initialize imodelhub-client in integration tests, to be able to capture requests with Fiddler
Changed URL resolution to use the first resolved URL, in this order:

Check if Client.baseUrl is set
a. If imjs_url_prefix configuration setting exists, prepend its value to Client.baseUrl hostname
Use BUDDI to resolve URL, i.e. the previous functionality

Set super.baseUrl for APIs that were migrated to new infrastructure

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@laurynasr should have caught this one earlier but you'll also need to run rush extract-api.  All these steps in the README are good to run locally to make sure everything is up-to-date.

@laurynasr should have caught this one earlier but you'll also need to run rush extract-api. All these steps in the README are good to run locally to make sure everything is up-to-date.

extract-api also found some changes in common/api/ui-core.api.md that were not made by me, I left the only change that was caused by my PR in common/api/itwin-client.api.md

Edit: All of our integration tests are failing with  Error: { "statusCode": 401, "message": "Invalid JWT." } after the changes. I'll have to pull the branch to dig into it a bit. Any ideas?

This is because .env file was missing imjs_url_prefix variable, I pushed a change for that to imodeljs-config

@laurynasr should have caught this one earlier but you'll also need to run rush extract-api. All these steps in the README are good to run locally to make sure everything is up-to-date.

extract-api also found some changes in common/api/ui-core.api.md that were not made by me, I left the only change that was caused by my PR in common/api/itwin-client.api.md

Edit: All of our integration tests are failing with  Error: { "statusCode": 401, "message": "Invalid JWT." } after the changes. I'll have to pull the branch to dig into it a bit. Any ideas?

This is because .env file was missing imjs_url_prefix variable, I pushed a change for that to my earlier PR in imodeljs-config repo

@laurynasr sounds good.  I'll update the variable groups used by the integration test job with new ones.

@Animagne mind taking another look?  I updated the mocks in imodelhub-client-tests to work with the new approach.

@laurynasr looks like we're getting rated limited again in the integration tests.  We routinely run a 10+ test suites at the same time so if it's getting rate limited with just 3 running I'm a bit worried that this won't work moving forward.
Is there something I need to do to my client to increase it?
https://bentleycs.visualstudio.com/iModelTechnologies/_build/results?buildId=811109&view=logs&j=11a1ff10-dba1-50ce-27e2-db260e9900bf&t=b816ccd9-b4fc-5b5f-cf60-71a48b089fc2

@laurynasr looks like we're getting rated limited again in the integration tests. We routinely run a 10+ test suites at the same time so if it's getting rate limited with just 3 running I'm a bit worried that this won't work moving forward.
Is there something I need to do to my client to increase it?

Yes, currently all clients need to be upgraded manually in developer.bentley.com (appropriate environment). After client registration is removed from itwinjs.org, I'll migrate all clients with a script, but for now it needs to be done manually.
Some of your test clients were already upgraded couple of months back, but I see that you are using several more, all of them are owned by @ramanujam-raman
I'll tag you both in the message regarding client upgrade

@laurynasr looks like we're getting rated limited again in the integration tests. We routinely run a 10+ test suites at the same time so if it's getting rate limited with just 3 running I'm a bit worried that this won't work moving forward.
Is there something I need to do to my client to increase it?

Yes, currently all clients need to be upgraded manually in developer.bentley.com (appropriate environment). After client registration is removed from itwinjs.org, I'll migrate all clients with a script, but for now it needs to be done manually.
Some of your test clients were already upgraded couple of months back, but I see that you are using several more, all of them are owned by @ramanujam-raman
I'll tag you both in the message regarding client upgrade

@laurynasr thanks. I own one of them as well. Let me try updating it and see if that helps.


mustache time complexity

Hi, where can I find some general details about mustache time complexity or algorithm details (without dive into the code)?
how the size of the template / dictionary influence the time complexity?
thanks!

Can't seem to remember having encountered what you're asking for I'm afraid. Historically I've stumbled upon some performance benchmarks done with the intention of comparing different templating engines and their raw performance, but those would be very misleading today because they were created a long time ago, and it wouldn't really answer your question anyways.
I would happily assist in digging into any concrete performance issues if you have any. But I'm surely not the best suited developer to write those kinds of general details about the algorithm chosen and how performance gets degraded based off of different factors.

Closing this for now as there's no clear answer to your questions ATM.
If anyone with the necessary knowhow and interests would like to dive into this, that would surely be interesting to see the outcome of.


Form Validation: required_with and required_without implementations

In the Form Validation Class, required_with and required_without are validation methods where the descriptions and implementation are for fields exist in $data or not.
But according to logic, it should be like,
[confirm_password => required_with[password]]
The confirm_password is required when the password is there in data and its value is non-empty
[email => required_without[mobile]]
The email is required when the mobile is there in data and its value is empty or blank

Right, but if we check that confirm_password exists first, we reduce checks we have to do. Even if the other field exists (i.e. password in your required_with example), we still want the test to pass if confirm_password is there. So that is handled first, and then if that's not there, we check the remaining fields in $data to see if the test should pass or not.
What am I missing?

For the above case, I can explain with the help of the campaign for which I kept the registration process the same.
For normal signup, password and confirm_password is mandatory. But in case of the campaign, I password and confirm_password is not compulsory to fill. So this check will work as the confirm_password is required_with password

Should I generate the PR for the same?

I'm still confused. In the case of campaign, if they enter password, then confirm_password is required when using the required_with method. However, if they don't provide password, then confirm_password isn't required.
Looking at the code, it first checks if confirm_password is present. If it is, it allows the test to pass because if password is present, this field is here (hence required_with), and if password is not present we don't want to break the test. The test doesn't say it only exists when the other field is present. Only that the field must be there. In this case, if confirm_password is present it would make no difference on what would happen when password was missing.
If confirm_password is not present, then it checks to see if any of the fields we are required to be with are present. If they are present, then we have to fail the test because we've already determined that confirm_password isn't present, and now one of the fields this was required is present and has data.
That matches the intended usage of the method, doesn't it? The tests in RulesTest.php support that unless there's a flaw in that test.


update.html

@Ja936 this is not a meaningful change. Please close this.

Hacktober spam. Whoever is maintaining the repo now, please add a label invalid or spam (source).


Galaxy 22.05 BCOs have malformed URIs

The Ebola Sudan BCO coming from galaxy.hyphy.org (using Galaxy release 22.05) has some malformed URIs, e.g.:
https://galaxy.hyphy.orghistory_content?history_id=0dd44cc0f0d96662&id=9eed52cc5810c0e6
A correct one would instead be
https://galaxy.hyphy.org/api/datasets/318faa28bc2f2134/display?to_ext=fasta
Two questions that arose were:

is this fixed in a later version of 22.05, or in pre-release 22.09?
can/should the existing converter script be updated for 22.05 BCOs?

I am currently editing only critical portions by hand, which is messy and will not scale.

We will still have to add the filename manually for the time being. That will involve more of a hack of Galaxy code I think. Unless we add to the converter script. Maybe the dataset extension could have an additional object in it that could be parsed into the BCO.


wiki out-of-date?

I'd appreciate it for the project's informative and categorical documentations.
Unfortunately,  some of the docs seem inaccurate.
CppAst.NET type-system gives a clarified description of the possible variants of CppTypes, but CppTemplateParameterType is not included.
I'd ask if the wiki is up-to-date, or anything else I'd take care if I use this project?

Yes, the doc is not up-to-date, some folks made PRs to bring support for template parameters.


Default migrations directory refactor

I needed to modify Create to also respect the new migrationsDirectory default in box.json.
NOTE: I changed the create argument to match the rest of the commands ("migrationsDirectory" instead of simply "directory")

Can you rebase off of master and force push?

I've made another pull request that merges.  Thanks Eric!


Doc updates

@kpolnitz @tremaineeto  Wanna review this request?  I know we're not active maintainers, but fresh eyes, especially on documentation is good.

Does the README read well, does it all make sense. Also, just let me know if you don't want to be a part of pull requests. I may submit some every now and again.

Yes! It definitely feels a lot more structured. You can definitely include
me in some of the pull requests.
On Wed, Mar 6, 2019 at 9:55 PM Jeff Ohrstrom<EMAIL_ADDRESS>wrote:

Does the README read well, does it all make sense. Also, just let me know
if you don't want to be a part of pull requests. I may submit some every
now and again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/att/deadline/pull/13#issuecomment-470395826, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATKyAKUZDJXGZUdzo1t3woKzDpNhqpW4ks5vUKnMgaJpZM4biR2o
.

Awesome! Thanks.


use the input interface

Hi,
i am surprised to find out you can not access the input interface, as simple as it is for the output.
Requesting confirmation before updates can be very usefull and much nicer than displaying the query in the command line interface for the user to run it ...
Has anyone faced anything related to this feature ?
Cheers :)

Strangely enough, looking at this right now. We have custom commands based around Phinx and needed to do some work in the init() method based upon the input criteria. Requires https://github.com/rquadling/phinx/tree/feature/SetOutputBeforeInit, which I'm waiting on some feedback from @robmorgan. I've nearly finished a new branch adding InputInterface throughout the code base (allowing a custom migration to access input parameters for custom commands).

Take a look at https://github.com/rquadling/phinx/tree/feature/AddSupportForInputInterface.
This is sitting in PR #859.

Released in 0.6.1


Roadmap to new release

I really like envoy, and I like how the project develops, but I am getting tired of always checking out the git version.
The last release was on 2011-10-15, what needs to be fixed until you release a new version?
Thanks,
Daniel

Ping!  How goes, @kennethreitz?


modules: hal_nordic: nrfx: Add nrfx_config_ext.h

Taking a cue from nrfx/templates, introduce this file so that it can be overridden out-of-tree to add external nRF product definitions.

@anangl @hubertmis Mind taking a look?


Make the make install output less daunting

The current output is a bit daunting for first-time users as it outputs
things like the following a few times:
customresourcedefinition.apiextensions.k8s.io/patterns.gitops.hybrid-cloud-patterns.io created
configmap/patterns-operator-config created
subscription.operators.coreos.com/patterns-operator created
error: resource mapping not found for name: "rhoai-patterns-demo" namespace: "openshift-operators" from "STDIN": no matches for kind "Pattern" in version "gitops.hybrid-cloud-patterns.io/v1alpha1"
ensure CRDs are installed first

Let's switch to something a bit more user-friendly:
make -f common/Makefile operator-deploy
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Checking repository:
  https://github.com/mbaldessari/multicloud-gitops.git - branch 'luis-demo': OK
Checking cluster:
  cluster-info: OK
  storageclass: WARNING: No storageclass found
Installing pattern: Done
...

Do some magic with file descriptors so we still manage to capture the
helm template stderr and the oc apply stdout+stderr and output them at
the end in case of failure.
In such cases the output will be something like the following:
Installing pattern: .....Installation failed [5/5]. Error:
Pulled: quay.io/hybridcloudpatterns/pattern-install:0.0.3
Digest: sha256:dd2d35d462b75aa8358ff278757dca0ee3c878cadafa64df8c68f880b59569ef
E1015 18:41:31.585465  196315 memcache.go:265] couldn't get current server API group list: Get "https://api.sno3.ocplab.ocp:6443/api?timeout=32s": tls: failed to verify certificate: x509: certificate signed by un
known authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "kube-apiserver-lb-signer")
...

Suggested-by: Luis Tomas Bolivar<EMAIL_ADDRESS>

If there's some kind of error without the runcount being maxed, will it be visible?

Yes and no. If there is an error in the first try and none in the subsequent ones we won't show it (which makes sense). If there is an error in the first try, chances are it will show up in the subsequent runs as well and it will be shown in the last one.


MAILBOX-405 Add a retry upon rename

Cassandra do not leverage transactionnality, hence we should try
to minimize half performed operations. Retries is a way to achieve
this and could be seen as a short term mitigation.

Merged


Discord PTB, unable to open the thread in discussion

Versions
Ptb 201348 (82b31d7)
Host 0.0.73
OS X 10.15.7 (22.5.0)

BetterDiscord Core v1.9.2

on Original Theme

on surCord
No thread is opened. Expected a floating window displaying the thread in the right side.

https://github.com/TakosThings/Fluent-Discord/blob/develop/src/modules/popouts/_threads.scss
use this as a refrence on how to theming threads


IPv6 Causes IPAddr::InvalidAddressError

The Geocoder::Request#geocoder_remove_port_from_addresses method expects IPv4 addresses. When passed an IPv6 address, it incorrectly tries to remove the port by splitting on :. The syntax for specifying a port with an IPv6 address is specified in RFC 3986. An example:
[3ffe:1900:4545:3:200:f8ff:fe21:67cf]:80

@alexreisner , I have doubts this is an issue. At least, Geocoder.search returns empty-like results if we search by ipv6 address without passing the port. Check out:
Geocoder.search("3ffe:1900:4545:3:200:f8ff:fe21:67cf", ip_address: true)

 =>
[#<Geocoder::Result::Ipstack:0x00007fa592d9d700 @data={"ip"=>"3ffe:1900:4545:3:200:f8ff:fe21:67cf", "type"=>"ipv6", "continent_code"=>nil, "continent_name"=>nil, "country_code"=>nil, "country_name"=>nil, "region_code"=>nil, "region_name"=>nil, "city"=>nil, "zip"=>nil, "latitude"=>nil, "longitude"=>nil, "location"=>{"geoname_id"=>nil, "capital"=>nil, "languages"=>nil, "country_flag"=>nil, "country_flag_emoji"=>nil, "country_flag_emoji_unicode"=>nil, "calling_code"=>nil, "is_eu"=>false}, "time_zone"=>{"id"=>nil, "current_time"=>nil, "gmt_offset"=>nil, "code"=>nil, "is_daylight_saving"=>nil}, "currency"=>{"code"=>nil, "name"=>nil, "plural"=>nil, "symbol"=>nil, "symbol_native"=>nil}, "connection"=>{"asn"=>nil, "isp"=>nil}}, @cache_hit=true>]

^ Almost all the values are nil.
 Should it work with pure ip_address as it works with port?

@vbyno Good question. Currently, the port is not stripped before this sort of query happens, only when deriving the user's IP address in a controller. I'm hesitant to always strip it out, because it would make it impossible to do a query for an IP address that included a port, which someone might want to do. Does that make sense?

@alexreisner , it looks like my mistake. I thought Geocoder.search("[...]:80") returns correct results, but it doesn't. For example, this is Canada ip: 2607:fea8:1360:f7d:dce7:b7f0:e0b6:1014. and the result of Geocoder.search("[2607:fea8:1360:f7d:dce7:b7f0:e0b6:1014]:80") is Switzerland (it uses Bing search). Although, Geocoder.search("2607:fea8:1360:f7d:dce7:b7f0:e0b6:1014") works fine and uses ip_stack search as expected.

@vbyno you're right. Can you open a new issue to discuss? I'd call it: IP Address Not Detected for IPv6 with Port

@alexreisner , Sure! Here is the issue https://github.com/alexreisner/geocoder/issues/1396. If any additional clarification is needed, I will provide it.


Consider renaming Response::text

This specifically to me implies plain text, as if some work is done stripping HTML from the output. It makes a lot more sense to call it Response::string, considering how the function simply returns the response as a string.

This doesn't seem worth it, so, I'm just going to close this.


Allow for piping output of ./b commands

This enables things like:

./b format > format-report.txt - save the formatting report to a file
./b format | grep some_file.cpp -A 5 - see the results of formatting a specific file

Yeah, I think it currently directs both stdout and stderr to stdout on the host.

Yeah, I think it currently directs both stdout and stderr to stdout on the host.


Issue108 flexibleamount is broken

Codecov Report

Merging #110 (05b746a) into main (e3d117f) will decrease coverage by 0.04%.
The diff coverage is 96.77%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   99.86%   99.82%   -0.04%
==========================================
  Files          88       88
  Lines        5082     5110      +28
==========================================
+ Hits         5075     5101      +26
- Misses          7        9       +2

Files Changed
Coverage Δ

...es/gui_structure_classes/flexible_amount_option.py
98.76% <88.88%> (-1.24%)
:arrow_down:

tests/gui_structure_for_tests.py
100.00% <100.00%> (ø)

..._structure_elements/test_flexible_amount_option.py
100.00% <100.00%> (ø)


Handling of manuals

This is a reply to https://github.com/zotero/zotero-bits/issues/35
I am not exactly sure what you wanted me to report, but here is my best guess... :)
Generating @manual entries in bibtex files with bbt can be done by either setting tex.referencetype: manual in the extra field, or by setting the report type to manual. In neither case zotero's institution is correctly translated to bibtex' organization but is put into institution. The following script fixes that.
if (Translator.BetterTeX) {
  if (item.itemType == 'report' && entry.entrytype == 'manual') {
    if (item.publisher) {
      if (item.author) {
        entry.add({ name: 'organization', value: item.publisher });
      } else {
        entry.add({ name: 'author', value: item.publisher, enc: 'literal' });
      }
      entry.remove('publisher')
    } else {
      Zotero.debug("No institution for " + item.citationKey);
    }
  }
}

This is a reply to https://github.com/zotero/zotero-bits/issues/35
I am not exactly sure what you wanted me to report, but here is my best guess... :)

I thought you meant that you think the behavior in the postscript ought to be the default behavior of BBT. Is that not the case?

Well, the bit about the organization yes, that seems like a bug to me. I guess the institution comes from the switch(reftype) and the missing organization from the extra report handling (item.itemType === "report" etc.) a bit earlier in doExport().

shut up, you waste of bits.

I do actually need a sample item that covers the situation you describe. I'll shut up label-gun, but he's here precisely as an impersonal prompt to avoid confrontations between me and reporters. The debug log is just a few clicks to generate and helps me enormously. It is missing enough that this was just pragmatically the best way to keep my frustrations manageable.


added cloudflare dns provider support

Hi @mysticaltech ,
not sure if you still want it, but here is an added example integration of cloudflare.
Cheers
Michael

It's great, thanks @michaelsstuff, appreciate it very much! About the Cloudflare record for the LB, why do you need it on top of external DNS (that configures ingresses automatically), just curious?

The reason I have hesitant about that, is that sometimes the IP changes if we update the number of nodes, for instance, it gets "refreshed" by the CCM and sometimes assigned a new IP.

Hmm sorry I cant quite follow. Assume for a moment I know nothing 🙃
The ingress does not have an inherit capability to change public dns records, rigth? I could run external-dns which might be more flexible for deployments.
If so then the Cloudflare record for the LB would only be usefull to address your kube with a name... so not too usefull.

Basically, what I do, is connect external-dns to cloudflare, then on each ingress definition I create, I add these annotations:
    external-dns.alpha.kubernetes.io/hostname: "nameiwant.myrootdomain.dev"
    external-dns.alpha.kubernetes.io/cloudflare-proxied: "true"

So basically, and that in turn will point to the LB automatically. I never have to create a direct entry for the LB manually. You do not do this?

Jup that makes a lot more sense. Just tried it, works like a charm.
Then lets throw this pr away :-D
Thank you very much for the hints and explanation!
Cheers
Michael


Stratos Metering Service Dashboard

This P/R includes following:

Adding database creation sql command to mysqlscript.sql file
Adding a ues-pacth to apply it to DAS locally to publish data from dashbaord to gadget.

Thanks for the pull request Thanuja! It's now merged to stratos-4.1.x branch.

Closing this P/R since it is merged.


UI to create shopcarts

Made the following changes:

UI code to create shopcarts
BDD test to create shopcarts

The test uses retrieve shopcart, so will merge after that is implemented

Good Job!


Please make proper 3.7.0 release

There is a 3.7.0 tag but it doesn't include a .tar.gz file, and the autogenerated github tar.gz is not usable by setuptools_scm. Please upload a proper .tar.gz and/or make a pypi release. Thank you!

Re-pushed the tag. Not sure why CI didn't trigger the first time. :thinking:
It ran now, tarball, wheel and pypi showed immediately.


Change event handler registration pattern

Event handlers will only be allowed to register event handlers before calling Register() to account for notification ordering.

/azp run