TypeError: DRLEnsembleAgent.run_ensemble_strategy()

Describe the bug
I was trying the code in FinRL_Ensemble_StockTrading_ICAIF_2020.ipynb.
In Part 6, when I tried to run the following code snippet.
A2C_model_kwargs = {
'n_steps': 5,
'ent_coef': 0.005,
'learning_rate': 0.0007
}
PPO_model_kwargs = {
"ent_coef":0.01,
"n_steps": 2, #2048
"learning_rate": 0.00025,
"batch_size": 128
}
DDPG_model_kwargs = {
#"action_noise":"ornstein_uhlenbeck",
"buffer_size": 1, #10_000
"learning_rate": 0.0005,
"batch_size": 64
}
timesteps_dict = {'a2c' : 1, #10_000 each
'ppo' : 1,
'ddpg' : 1,
}
df_summary = ensemble_agent.run_ensemble_strategy(A2C_model_kwargs,
PPO_model_kwargs,
DDPG_model_kwargs,
timesteps_dict)
I am getting the following error message:

TypeError                                 Traceback (most recent call last)
 in <cell line: 32>()
30                  }
31
---> 32 df_summary = ensemble_agent.run_ensemble_strategy(A2C_model_kwargs,
33                                                  PPO_model_kwargs,
34                                                  DDPG_model_kwargs,
TypeError: DRLEnsembleAgent.run_ensemble_strategy() missing 2 required positional arguments: 'TD3_model_kwargs' and 'timesteps_dict'
When I looked at the function definition of run_ensemble_strategy() in models.py, it looks like this:
def run_ensemble_strategy(
self,
A2C_model_kwargs,
PPO_model_kwargs,
DDPG_model_kwargs,
SAC_model_kwargs,
TD3_model_kwargs,
timesteps_dict,
):
I wonder if the code or the example is outdated. Can you provide any help?
I ran it in a google colab environment.

I found the fix in a previously posted issue. So I am closing it.


Agency filter behaviour corrupt in search

Steps to reproduce:

The CVS page is opened at the root path; e.g.:  https://vocabularies-staging.cessda.eu/
Proceed by setting 1 agency in the filter.
Click in the search and type something to perform a search.
The Agency filter is empty, but is should stay as set in step 2)
If repeating step 2) here, another or the same agency can be added to the filter.
We can repeat steps 3) to 5) and we can end up having the same Agency in the filter 3 times.

Originally posted by @Stifo in https://github.com/cessda/cessda.cvs.two/issues/969#issuecomment-2505633135

work in progress branch: https://github.com/cessda/cessda.cvs.two/tree/bugfix/972

added language filter to the left-side filtering panel
changed the left-side filtering panel behaviour from optional (boolean query using should) to compulsory (boolean query using must) when dealing with multiple values of the same filter; e.g. if language filter contains values en, ja, fi then only those vocabularies are shown, which contain all the three languages, either SL or TL.


Support caching results on Win32-based systems

…ct creation

Thanks for your PR, @dbehmoaras! This is the central function to normalize paths to posix format. So I'm not sure whether this is the right location to fix the issue. What's the exact issue you're trying to solve here?

Hmm - I see your point. Maybe then it should be addressed in file that handles the caching of the results ? The issue we run into is that Knip fails to update the cache on windows systems because it resolves a posix file path when windows env expects a win32 path from node.js

Alright, clear.
Maybe you can import path from 'node:path in file-entry-cache.ts and take it from there? Fix this.filePath with path.resolve, etc.

Ok let me try that

Great, I'm asking so you can directly test it works properly on Windows. If you create a PR, you will automatically get a version that you can npm install anywhere, if that helps.

Apologies for the delay on this. My schedule get away from me. Will try to update this over the next couple of days. Thank you for your patience!

@webpro PR is updated and ready for your feedback. Confirmed that it works on posix systems (used Mac OSX 15.1 to confirm). Still running some smoke tests on PC. Will update when complete.

@webpro I think the change is finished from a functional standpoint. format fails due to this biome rule. In principle I agree with the rule. Importing join and resolve, so we would need to expose an env agnostic (or win32) version of each of those functions in that file.
Thoughts on joinEnvAgnostic and resolveEnvAgnostic ? I'm afraid if we change the current exports it may have unintended side effects.
Alternatively we can add the // biome-ignore lint/nursery/noRestrictedImports: ignore rule to this file. Let me know which you prefer.

Alternatively we can add the // biome-ignore lint/nursery/noRestrictedImports: ignore rule to this file. Let me know which you prefer.

Sorry I missed that. Please ignore the violation, we should use node:path here.

Sure thing - just pushed the latest with the rule ignored.

:rocket: This pull request is included in v5.41.1. See Release 5.41.1 for release notes.
Using Knip in a commercial project? Please consider becoming a sponsor.

Thanks again, @dbehmoaras!

Of course! Happy to contribute


add parameters to request body

Hey @alfespa17 !
Do you think it would work ? From my understanding we only need to add parameters to the payload body of the post/update request for the module so that it can creates with the values. Did I miss something ?

I think it looks good

The build failed I think it is related to the go version change that you added, can you rollback that part @BenjaminDecreusefond ?

Once you fix the build issue I can merge the change

Okay, will do thanks !

@alfespa17 done it ! :)

@alfespa17 my bad I forget a little whitespace, just added it ! :)

It is failing @BenjaminDecreusefond

Very sorry, I ran gofmt it should be good now @alfespa17 !

@alfespa17 CI passed ! :)


Adding corenlp deps as non optional ones

Resolves #1725

An alternative solution #1727.

Let's just go with #1727. Thanks @pykler


Filtering for tasks with a due date only should use the api to filter

Here:
https://github.com/go-vikunja/app/blob/c62848b2acb866ec9536c3a556fc9369440b6d02/lib/pages/landing_page.dart#L278-L282
We're filtering tasks after loading them. This should be done using the api instead. A filter like due_date > 0001-01-01 in combination with the filter_include_nulls parameter set to false should do the trick.

Absolutely! When I wrote that, the api (afaik) wasn't able to do that yet. I'll change it.

Fixed! FYI the filter needs a due_date > 0001-01-01 00:00. If it's just 0001-01-01, it throws a server error 500. A more meaningful error would probably be great.


Add dockershim shortcode to appropriate pages

This is a follow-up to PR #32826, which created a shortcode note describing the dockershim removal. This PR will actually add that shortcode to appropriate pages. The note will be placed at the top of each page and read as follows:
Dockershim has been removed from the Kubernetes project as of release 1.24. Read the Dockershim Removal FAQ for further details.
The recommendation is to keep these short codes in place until at least until release 1.25.

This is the list of pages I'm suggesting we add the shortcode note to. Most have direct references to "Docker Engine". Please comments with any suggested changes to this list:
./concepts/services-networking/service.md
./setup/production-environment/container-runtimes.md
./setup/production-environment/tools/kubeadm/kubelet-integration.md
./tasks/administer-cluster/kubeadm/adding-windows-nodes.md
./tasks/administer-cluster/migrating-from-dockershim/migrating-telemetry-and-security-agents.md
./tasks/administer-cluster/migrating-from-dockershim/migrate-dockershim-dockerd.md
./tasks/administer-cluster/migrating-from-dockershim/change-runtime-containerd.md
./tasks/network/customize-hosts-file-for-pods.md

@chrisnegus you should squash this down to 1 commit, and also verify that the new shortcode definitely works as expected.

If you want to, you can include the commit from the other PR in this one; if you want this just to be a single commit, you should /hold it pending the merge of the other PR.

@sftim Okay. I'm going to try to get PR #32826 merged today. Then this PR should "just work".

Here you can see the shortcode showing up as a note at the top of the container-runtimes page.

/lgtm
https://deploy-preview-32941--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/container-runtimes/

/approve

(nit) Did we add this too early? The wording suggests that the removal (and the release that performed the dockershimectomy) has happened already.

(nit) Did we add this too early? The wording suggests that the removal (and the release that performed the dockershimectomy) has happened already.

Yeah, maybe. Sigh.

@sftim @chrisnegus , I created PR https://github.com/kubernetes/website/pull/33045 to revert most of the changes in this PR (except for a page that had a single line deletion)
After the weekly sync of dev-1.24 with main, I'll create a PR to dev-1.24 branch with the changes made in this PR.
At the moment, there will be a merge conflict if I add the shortcode to some of the pages in the dev-1.24 branch

@sftim @chrisnegus , I created PR #33045 to revert most of the changes in this PR (except for a page that had a single line deletion)
After the weekly sync of dev-1.24 with main, I'll create a PR to dev-1.24 branch with the changes made in this PR. At the moment, there will be a merge conflict if I add the shortcode to some of the pages in the dev-1.24 branch

Okay. Thanks!


Add Copilot Usage Summary for Organization

Github has a Rest API to get the usage summary of Copilot within the organization. This PR implements the functionality to fetch that data.
API Docs: Here
Please let me know what you think!

@gmlewis i will close this PR due to CLA signing issues. I opened #3321 which also contains a commit with the requested changes. Please review that one, i hope it should be good!


johnstonmatt/--port

I added the ability to use a long form of port, --port as it is backwards compatible, makes the api more discoverable and declaritive. See #466.

the Travis check failed, but I'm quite certain that is not because of my change

@johnstonmatt correct. It was something breaking at Travis and unrelated to your code. 😄 I've just rerun it and it ran great.
Thanks for this! Merging shortly.


CONTRIBUTING.md is outdated

The CONTRIBUTING.md is bit outdated - you can't build with ant now, you should with maven, etc.
Also: build.xml should be updated (at least update java version to match maven) or deleted
Also: coding guidelines would be appreciated

what Java version compatibility do you go for? Can we use Java 7/8/9/10/... features? From maven config I guess 1.7...

I think we may set source compatibility to java 1.8 which features are mostly common to android programmers
What about ant - may be it is time to drop it`s support - cause maven do same + some extra features.
@vidstige - what do you think about ant?

Yes, I doubt anyone uses the ant build anymore. Even travis uses maven as can be seen in the build log. It won't be missed - Lets burn it with fire! :-)

As for java compatibility, as this is library that does not see super much development, being compatible is more worth than somewhat cleaner code. I'm not against 1.8, but this is not an app or so, and you can still use this library in your 1.8 Java android app or whatever. The compatibility is just the minimum version needed. Unless a very compelling argument can be made to drop compatibility, I feel staying on 1.6 (or whatever current version is) is a better choice for the people using the library.

Maven specs 1.7, ant specs 1.6 but fails to build the source due to diamond operator:
compile.module.jadb.production:
    [mkdir] Created dir: XXX\jadb\bin
    [javac] XXX\jadb\module_jadb.xml:65: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 28 source files to XXX\jadb\bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] XXX\jadb\src\se\vidstige\jadb\managers\PackageManager.java:58: error: diamond operator is not supported in -source 1.6
    [javac]         ArrayList<String> arguments = new ArrayList<>();
    [javac]                                                     ^
    [javac]   (use -source 7 or higher to enable diamond operator)
    [javac] XXX\jadb\src\se\vidstige\jadb\managers\PropertyManager.java:26: error: try-with-resources is not supported in -source 1.6
    [javac]         try (BufferedReader bufferedReader =
    [javac]             ^
    [javac]   (use -source 7 or higher to enable try-with-resources)
    [javac] XXX\jadb\src\se\vidstige\jadb\managers\PropertyManager.java:33: error: diamond operator is not supported in -source 1.6
    [javac]         HashMap<String, String> result = new HashMap<>();
    [javac]                                                      ^
    [javac]   (use -source 7 or higher to enable diamond operator)
    [javac] 3 errors
    [javac] 1 warning

BUILD FAILED

There you go, just one more reason to rip it out 👍

Pull requests open for business! I won't have time to remove it personally during upcoming weeks, but perhaps later on.

Adressed in #104


Add $columnSpan to the widget

Can we add a support to customize widget width?
protected int | string | array $columnSpan = 'full';

The widget extends Filament's widget class so this is already in place.

The widget extends Filament's widget class so this is already in place.

I extended the class that you have, it duplicate the widget.

Sorry, i'm not sure what you're asking here.


Create approval UI

AC:

Placed on normal wiki pages
If there is no approval, show "This page has not been approved yet". If the user is an approver for the category, also show an Approve button
If there is approval, show "John Doe approved this page on 2024-04-22". If the user is an approver for the category, also show a button to un-approve
Only show on latest revision

We need to figure out ourselves what the UI looks like
For follow up

Show only on pages in at least one approval category
https://github.com/ProfessionalWiki/PageApprovals/issues/22
Talk to new endpoints for approval/un-approval

@waximabbax this is done, right?


Bump mongo_java_driver to 3.12.11 and embed.mongo to 3.0.0

Related to #21646. mongodb unit tests does not run on M1 Mac because the test dep embed.mongo is too old. Bumped to a support version in preparation of future upgrade of Driver. (https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues/329#issuecomment-757362959)
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python MongoDBIO_IT

Run Java MongoDBIO Performance Test

Run Python_PVR_Flink PreCommit

Run Java_Spark3_Versions PreCommit

Run Go PreCommit

Python precommit unrelated failure
11:19:59 > Task :sdks:java:extensions:protobuf:compileJava
11:19:59 warning: Memory constraints are impeding performance; please increase max heap size.
11:20:10 error: warnings found and -Werror specified

ready for review

R: @aromanenko-dev

Run Python PreCommit


Upgrade to hawkular-parent 16 - upgarde to WildFly 9

agent was moved to v16 in a previous commit. closing this PR


Feature Request: Only show one notification at a time

I would like to propose a feature request that fits with the Material Design mindset that only displays one message a time to the user.
This would require a queue to be added, and after the timeout of the current notification, the next notification will automatically show.

Sounds great +1


html fragments doesn't work in a match branch

html!{
  match ... {
    A::AA =>{
      <>

      </>
    }
    A::BB =>{

    }
  }
}

doesn't compile. wrapping the first branch in {} doesn't help either. You have to wrap it in html!{}

Removing the {} solves this, as the braces in html! are an entry point for Rust code inside HTML

:exploding_head: thanks


Usability improvements for 1.13

Create DiskStore REST API

One question - I see a bunch of commits with titles like "Fix spotless issues". Are these how this commits all went on develop? Is the below really just all one change?

GEODE-8283: Provide REST interface for disk-store creation 3bbaca9
Fix spotless issues 49b361b
Add missing documentation files to assembly 9dddcc0
Updating assembly validation txt (#4) 0dbc3e8
Remove Id field from DiskStore 7d0e6fb
Fix jq issues 7f744d2
Disk store rest api (#5) 985368f
Add JQ testing for disk-store controller dc228d0
Change DiskDir size to be Integer 470783c
Fix serializables b5b3479
Remove Id field from DiskStore cf3406c

@upthewaterspout unfortunately, those are how they were merged into develop.  I think someone clicked merge instead of squash and merge.  Those are all part of a set of commits for one feature/change.


Fix an issue with a late binding closure

This was intended to be made as a draft, was trying to quickly test via a fork made via web interface. This doesn't fix it, I'll get a tested fix up in a moment.


Parsing timestamps

I see in changelog that parsing timestamps is planned but it seems it is not yet implemented?

Its implemented and merged, but unreleased. I could cut a beta version if this is helpful

It would be nice if it was on the npm, yes. :-)

Hi!
I just cut an alpha version that has both Date and DisplayString support. The main reason I'm not calling it Beta is because I think I want to include a Dictionary class that makes it less frustrating to build dictionaries from scratch.

Awesome.

I want to include a Dictionary class that makes it less frustrating to build dictionaries from scratch.

I must say I do not get why JavaScript libraries for structured headers use the structure of data from the spec. JavaScript is flexible enough that you could just have arrays and objects and those additional parameters could just be a non-enumerable property accessible with a symbol on JavaScript objects. It would be much more idiomatic for JavaScript.

Using built-in arrays and object with a symbol for parameters is an interesting suggestion, but I'm a little worried it's still a bit too weird for users to generate those and read those out. It also gets more complicated when dealing with parameters on scalar values.

but I'm a little worried it's still a bit too weird for users to generate those and read those out

Then just provide simple getter and setter. getParams() and setParams(). It feels pretty natural to me.

It also gets more complicated when dealing with parameters on scalar values.

Why? JavaScript supports boxed scalar values.


[Incubator][VC]Clean up - Refactor resource controller - Part 3

This change touches secret/serviceaccount resources. It mainly does the followings:

Move downward syncer logic to a separate dws.go for better code structure.
Add an serviceaccount informer Lister and add WaitForCacheSync for service account dws thread. This will avoid create duplicated resource without querying super master .
Add more comments.

/lgtm
/approve


Is this plugin also using wifi siginal or phone siginal to speed up the location

Is this plugin also using wifi siginal or phone siginal to speed up the location?
For example, if I am in the building, it is very slow to get the location updated.  If outside, it is no problem.  Therefore I ask if possible to use wifi or cell phone siginal to speed it up.
Thanks!

Yes it does for both iOS and Android. The later only if the target device has Google Play Services installed and you are not explicitly forcing the use of the LocationManager SDK (e.g. by setting the forceAndroidLocationManager parameter of the getCurrentPosition or getPositionStream methods to true).
For one of the Baseflow App we are the plugin in combination with WiFi location services to handle indoor navigation in large buildings which works extremely well.


test that array-items/prefixItems adjusts the starting position for schema-items/additionalItems

I noticed this gap in the test coverage when implementing prefixItems for 2020-12.

Array items isn't a thing in 2020-12.
https://json-schema.org/draft/2020-12/json-schema-core.html#rfc.section.<IP_ADDRESS>

The value of "items" MUST be a valid JSON Schema.

oh damn, yes.. I'll rework to preserve the spirit of the tests.

Also.. I wish we had a CI check that ran the schemas against their respective metaschemas :)

I've fixed the tests to as best match what I was going for as possible, as this scenario isn't clearly tested by the other cases: that additionalItems (or schema-items in 2020-12) does not start with the first item when array-items/prefixItems validated that first item already.

rebased one last time for merge


Make Math Quiz Generator

Because math is always more fun with a little friendly competition.
Generate a random math quiz with problems at different difficulty levels, allowing users to answer and see their score.

Please assign this issue to me @sumanth-0 . Thank you .


[1.19.2] Painting name collision with Dark Painting mod (enderman)

Please, change the name of the painting for Enderman. When include this mod together with the Dark Painting mod, no paintings from Builders Additions are included, with the server-side crashes like following:
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.IllegalArgumentException: Multiple entries with same value: Reference{ResourceKey[minecraft:painting_variant / buildersaddition:enderman]=net.minecraft.world.entity.decoration.PaintingVariant@1bc9f1c3}=DARKPAINTINGS_ENDERMAN and Reference{ResourceKey[minecraft:painting_variant / darkpaintings:enderman]=net.minecraft.world.entity.decoration.PaintingVariant@50a89074}=DARKPAINTINGS_ENDERMAN [in thread "Server thread"]
at com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:376) ~[guava-31.0.1-jre.jar%23105!/:?]

OR, is there a way to change it or remove it using the data pack? If yes, please, provide an example for the workaround.
(Submitting this to both Builders Addition and Dark Painting mods issues)

Further investigation shows that the clean installation of the Forge + Dark Painting (1.19.2) still does not allow placing the new paintings from the Bilder Additions mod in the world. So it is not related to Dark Paintings at all.


loading semantic.js with defer attribute on script tag triggers "no css animation matching" error

Hi,
this usually happens on chrome or webkit with something like
<link href="semantic.css" />
<script defer src="semantic.js"></script>
<script defer src="custom.js"></script>
...
<select multiple class="ui dropdown"><option value="me" selected>me</option></select>

where custom calls $('.ui.dropdown').dropdown()
Is the missing "a.ui.label.hidden.transition" animation that important  - semantic could just ignore it instead of erroring out ?
I'll make a jsfiddle to demo the issue if support for "defer" loading is something you want.

Oh, i didn't explained what was happening: semantic.js + custom.js are run before semantic.css is loaded - which results in missing css.

Stylesheets should be blocking, I'm not sure in what way they could be affected by deferring javascript.

Here's a test case
http://kiwi.edagames.com/~eda/semantic-defer-2613.tar.gz
i've put it online, but odds are against me and the problem doesn't reproduce with my bandwidth.
It does everytime on localhost.
The problem is triggered by initializing a multiple select with one selected option - it animates the adding of the option before the stylesheet is fully loaded.
After a while i read this
http://www.html5rocks.com/en/tutorials/speed/script-loading/
and stopped using defer...


IE10 - orphaned iframe detected as popup window

This is causing issues when the frame is removed from the DOM. Suspect there's a link with https://github.com/krakenjs/post-robot/issues/9 since it doesn't appear to be detected as a closed frame.

Fixed.


Merge rules: no-throw, no-try (possibly also no-reject)

See #11

@jonaskello I'm not sure about merging these rules as they are designed to stop different things.

no-throw is designed to prevent creating exceptions.
no-try is designed to prevent handling exceptions (which often can't be avoided when it comes to
using non-functional 3rd-party libraries)
no-reject is designed to prevent rejecting promises, making them act as a single type (rather than acting as a union of two types) [I consider this to be an anti-pattern but it's available for those that want it] (note: this rule must be used with no-throw)

If anything, I kind of feel like the no-try rule could be split into two rule; no-catch and no-finally (or maybe those should just be options).

I think we can keep them the same as in tslint-immutable, that will also make it easier to migrate.


spacemacs freezes when editing todays journal

Whether I try to make an entry through org-journal-new-entry or with calendar, spacemacs freezes up and I have to close the window. I can make entries for any other day without issue.
 (org :variables
          org-enable-org-journal-support t
          org-journal-dir "/mnt/c/Users/poste/Dropbox/journal/"
          org-journal-file-format "%Y-%m-%d.org"
          org-journal-date-prefix "#+TITLE: "
          org-journal-date-format "%A, %B %d %Y")

org-journal-20200305.1909
spacemacs<EMAIL_ADDRESS>

Hey!
Can you quite the current loop using C-g? If yes, please call
toggle-debug-on-quit and press it.
postelrich<EMAIL_ADDRESS>writes:

Whether I try to make an entry through org-journal-new-entry or with calendar, spacemacs freezes up and I have to close the window. I can make entries for any other day without issue.
(org :variables
org-enable-org-journal-support t
org-journal-dir "/mnt/c/Users/poste/Dropbox/journal/"
org-journal-file-format "%Y-%m-%d.org"
org-journal-date-prefix "#+TITLE: "
org-journal-date-format "%A, %B %d %Y")
org-journal-20200305.1909
spacemacs<EMAIL_ADDRESS>—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, I was able to get back control with C-g. I ran toggle-debug-on-quit, what does that do?

If you call toggle-debug-on-quit and you call the function which hangs in a loop and press C-g, the debugger will be opened. You will see the current stacktrace in the debugger, please post the stacktrace here.

Debugger entered--Lisp error: (quit)
  org-scan-tags(org-decrypt-entry (lambda (todo tags-list level) (progn (setq org-cached-props nil) (or (and (member "crypt" tags-list))))) nil)
  org-decrypt-entries()
  org-journal-decrypt()
  org-journal-finalize-view()
  org-journal-open-entry("No previous journal entry before this one" t no-select)
  org-journal-open-previous-entry(no-select)
  org-journal-carryover()
  org-journal-new-entry(nil)
  funcall-interactively(org-journal-new-entry nil)
  call-interactively(org-journal-new-entry nil nil)
  command-execute(org-journal-new-entry)

This is on ubuntu wsl on win10 btw.

Hmm, I cant really see anything obvious strange in the backtrace, must be some problem occurring only in Windows/Ubuntu combination. I guess it has something to do with crypt, but that is actually not a org-journal thing.
Please can you try the following:
Change the defun
(defun org-journal-decrypt ()
  (when (fboundp 'org-decrypt-entries)
    (let ((buffer-read-only nil))
      (org-decrypt-entries))))

---->
(defun org-journal-decrypt ()
  (when (fboundp 'org-decrypt-entries)
    (let ((buffer-read-only nil))
      ;;(org-decrypt-entries)
)))

And re-evaluate it, and try if that fixes your problem?

There can be funky issues at the interface between Windows and Linux. Are you running this entirely inside the WSL (Linux Emacs on the Linux file system)?

With commenting out that line it still freezes, looks it hangs on the regex. Maybe its searching some higher level directory it shouldnt be.
Debugger entered--Lisp error: (quit)
  re-search-forward("^\\*+  *\\(\\<\\(DONE\\|TODO\\)\\>\\)? *\\(.*?\\)\\([ \011]:\\(?:[[:alnum:]_@#%]+:\\)+\\)?[ \011]*$" nil t)
  org-scan-tags(org-decrypt-entry (lambda (todo tags-list level) (progn (setq org-cached-props nil) (or (and (member "crypt" tags-list))))) nil)
  org-decrypt-entries()
  org-journal-decrypt()
  org-journal-finalize-view()
  org-journal-open-entry("No previous journal entry before this one" t no-select)
  org-journal-open-previous-entry(no-select)
  org-journal-carryover()
  org-journal-new-entry(nil)
  funcall-interactively(org-journal-new-entry nil)
  call-interactively(org-journal-new-entry nil nil)
  command-execute(org-journal-new-entry)

I'm afraid, but I think you are at the wrong spot to search for help for this kind of issue.

With commenting out that line it still freezes, looks it hangs on the regex. Maybe its searching some higher level directory it shouldnt be.

That's impossible. If you did, than org-journal-decrypt shouldn't have been called. Did you re-evaluate the function?

The function org-journal-decrypt will now only proceed if org-journal-enable-encryption is t. If you install that version org-decrypt-entries shouldn't be called.

Closing, as the root cause is somewhere else!


Do we setup the "None" OptionGroup

Around here

I think we should create a default record - will make it easier when cleaning things on onBeforeDelete. However, I don't like "None" - would be weird on a ProductPage.
How about something generic like "Options"? If it ever got used in production, at least it would make some sense as the title for the drop down. Open to other suggestions as well.

Just had an afterthought, if we add a validator for ProductOptionGroupID we can force that they add a new one per OptionItem or select an existing one, but the OptionItem wouldn't save without that relation being set.

That's a good idea.

closed via #172


🐛 Fix hashtags search on LowerDPI devices + Check if the keyboard is open with adb

:gift: Create a method for check if the keyboard is open or not:
adb shell dumpsys input_method | grep mInputShown

:cat2: :bug: On device with LowerDPI the search function not work correctly. If the keyboard is open, close and then do a little swipe DOWN

:heavy_plus_sign: Why we don't use go back instead of swipe UP to close the keyboard? (for example https://github.com/GramAddict/bot/blob/master/GramAddict/core/views.py#L315) I mean elsewhere in the code, a good idea It's to create a method:
def close_keyboard_if_is_open(self)
    if self.device.is_keyboard_show():
        self.device.back()

We stopped using back for some reason. I think we couldn't detect if a keyboard was up according to what @mastrolube  was saying. Since you were able to add a check for that, we should be able to use back now.

We stopped using back for some reason. I think we couldn't detect if a keyboard was up according to what @mastrolube  was saying. Since you were able to add a check for that, we should be able to use back now.

We stopped because in some apps (cloned apps)/devices(emulator memu for example) the first click on search didn't open the keyboard. For that reason, the script crashed badly going back even if the keyboard wasn't open and changing the view.
I did a quick fix with a little swipe up to avoid that problem (the swipe didn't change anything in the view so it was perfect).
Now @Tkd-Alex found a way to detect it using adb, I think we can use the back again.. Maybe the guy with the cloned app should try it before :)

We stopped because in some apps (cloned apps)/devices(emulator memu for example) the first click on search didn't open the keyboard. For that reason, the script crashed badly going back even if the keyboard wasn't open and changing the view.
I did a quick fix with a little swipe up to avoid that problem (the swipe didn't change anything in the view so it was perfect).
Now @Tkd-Alex found a way to detect it using adb, I think we can use the back again.. Maybe the guy with the cloned app should try it before :)

That returns an error for the oneplusone 1 of a user (UnicodeDecoreError), I'll make and except with the old code to let him use the bot. If someone has other ideas, let me know


How to selectively use SSR on some routes?

Two pages, one for the server rendering, and the other not.
const Router = require('vue-router');
const Page1 = require('./page1.vue');
const page2 = require('./page2.vue')
module.exports = new Router({
  routers: [
    // page1 need to be render by server and client
    { path: '/page1', component: Page1 },
    // page2 need to be render by client only
    { path: '/page2', component: Page2 }
  ]
})

I encourage you to use our forum or gitter. The issue list is reserved exclusively for bug reports and feature requests.
Thanks.


ci: set up GitHub actions

is this ready to be merged?

is this ready to be merged?

yes, it done

yes, it done


Quote with image component

Trello card
https://trello.com/c/7hcN0Ksx/6623-phase-4-amend-quote-component-design-and-include-images
Context
GIT users need to feel inspired to teach and reassured that teaching is a viable career for them
Changes proposed in this pull request
Create a QuoteWithImageComponent that accepts a title, html safe text content, image, background color, and option to toggle quotation marks on or off.
Guidance to review

Hey @spencerldixon I noticed if use links or headings it adds extra space above or below them, is there a way to tell it to ignore the extra space?
also at certain sizes the links and headings appear a different size to the other text?

@spencerldixon also do you know which is the right section or div class to have them sit in, so that they have space above and below when used on a page? the one I've used has white space on the right and left and would be better without

going to add the guidance in a separate PR for this (as I've recently updated it and this PR is behind). Have tested in a markdown file and it works fine. All looks good to me now!

@jenhadfield-dfe @spencerldixon I'm very happy for you to merge this if Jen is happy design-wise - as long as the changes to the /explore-teaching-advisers page and the images are backed out first!


Move state(for: Product) functionality to purchase storage

This is a relatively simple refactoring of state(for: Product).
The goal is to enable easy checking for keychain purchase storage from an app extension where a full-blown merchant is not a viable option since StoreKit API are unavailable in an extension.
I'm using this in my app extension as follows:
    guard let serviceName = Bundle.main.bundleIdentifier else {
      return
    }

    let keychain = KeychainPurchaseStorage(serviceName: serviceName)

    switch keychain.state(for: myProduct) {
    case .unknown, .notPurchased:
       // show purchase link
    case .isPurchased(_):
      // do the work
    }

Do you think this is materially better than letting the app logic handle it itself? For instance, the way I handle this in Daily Dictionary is storing a Bool value to the extension's container. I simply update this value in the  merchant(_:, didChangeStatesFor:) delegate.

I like this approach better for the consumers because it offloads it to the library and uses the same source of truth, the keychain, as opposed to duplicating state in the extension container. Less to go wrong…

I'm not sure the purchase storage should be viewed as the source of truth though. It's certainly the place where the Merchant stores its data, but that's technically a different concept. It's possible in the future that the Merchant wants to employ logic that resolves the PurchasedState using more than just the storage.
If you don't mind, I'd rather be cautious on a refactor like this. All the purchase storage API is public so you can implement this in your own project as an extension if you really want to do it. But I think funnelling via the delegate is a better pattern to promote in general.


i can't visit isar inspector

I've visited the url given isar, but the result is not isar inspector, but dart vm

You got put it in the inspector mac app instead of browser. But there is an issue, check out #251 for workaround.

Anda memasukkannya ke dalam aplikasi mac inspektur alih-alih browser. Tapi ada masalah, lihat #251 untuk solusinya.

I didn't find an error like that, the problem is when I open the given link it redirects to the dart vm, not the inspector page.

Anda memasukkannya ke dalam aplikasi mac inspektur alih-alih browser. Tapi ada masalah, lihat #251 untuk solusinya.

I didn't find an error like that, the problem is when I open the given link it redirects to the dart vm, not the inspector page.

As far as I know, the inspector only has macOS client. You have to install the app to use it.

I don't have Mac OS, I have Linux, hopefully in the future there will be applications for Linux, especially Debian.


support html output from the library

It would be nice if there was a library method for outputting the html nodes from the library, similar to how it is done in the cli, which is difficult to copy since it references internal functions.
https://github.com/markusmobius/go-trafilatura/blob/main/cmd/go-trafilatura/output.go#L81-L147

In the latest version there is a helper function named CreateReadableDocument which expose that functionality. So now you can use it like this:
result, _ := trafilatura.Extract(r, opts)
readableDoc := trafilatura.CreateReadableDocument(result)

// To print the HTML output, you can use it with go-shiori/dom package
fmt.Println(dom.OuterHTML(readableDoc))


adjust schema validation error message

Scope & Purpose
Fix misleading error messages for the schema validation, when an invalid schema definition is provided.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)

Related Information

[x] There is a JIRA Ticket number: https://arangodb.atlassian.net/browse/QA-22

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10627/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10628/

Tests blue except unrelated error.


@jonataslaw Please Dear, Kindly upgrade this OUR WHOLE CAREER IS DEEPENING ON YOU UPDATING this project :( otherwise they will move to Bloc-cubit :( PLEASE

@jonataslaw Can you please upgrade this project? This upgrade is extremely important because, if you don’t do this, they will move to Bloc-cubit. The status of my entire career depends on you updating the project.

I have been waiting for the update from getx, but after such a long time, I have been disappointed more and more times,
I dare not use getx for new projects anymore. It's a headache to use the existing project, and migrating to other plugins is a huge workload

@chenjiangmin  can u advise some alt projects to move?

@chenjiangmin can u advise some alt projects to move?

https://pub.dev/packages/refreshed

I hope to meet all expectations. Is there any critical issue that you need to update before Christmas?

Please Just change the version 4 stable to version 5 stable and use the latest build, so more people can use and find out ACTUAL bugs and ask for improvements, Also please test against Flutter 3.27 as well. @jonataslaw

USE GETX version 5 here, PLEASE IT would prompt more users to upgrade and update and then it would help us find many issues and upgrade

Please ate least say COMING SOON on Getx.site

I hope to meet all expectations. Is there any critical issue that you need to update before Christmas?

Dear Thanks :)

it's teribble, that this big project depends on single developer. I think it's over... so may be we need to find some live fork?

it's teribble, that this big project depends on single developer. I think it's over... so may be we need to find some live fork?

I think there are several reasons for this
1: Open source does not mean freelancing, especially for individual developers who require actual financial income;
2: Other maintainers are not very familiar with the design concept of this version
3: The design concept was incorrect and encountered obstacles. Causing slow progress. Need to redesign the mindset


remove explicit use of rdiscount for markdown

Related to #360, but I didn't want to clutter that up. This will work on it's own, but should be merged after that goes in (since that'll grab kramdown and everything will be butterflies and rainbows then)

@brntbeer should we also :ship: this one?

@crichID yesssss.


changed the s2geometry with the native one & add proto for encounter …

…& catch pokemon & partially CatchPokemon & EncounterPokemon Method

Sorry i forgot to remove bignum dependency from package.json

Really good work man, solid stuff!


Add output to export runner

Added a simple test passing message to the output.

@armanio123,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


How to get ShadInput validation error.

Hello,
I have this field with a custom validator. How can I access the error message from the validator and display it in my custom Text widget?
ShadInputFormField(
  id: 'account_number',
  enableSuggestions: false,
  error: Padding(
    padding: EdgeInsets.symmetric(horizontal: 6.w),
    child: Text(errorText, style: theme.textTheme.small.copyWith(color: theme.colorScheme.destructive)),
  ),
  label: Padding(
    padding: EdgeInsets.symmetric(horizontal: 6.w),
    child: Text('Account Number', style: theme.textTheme.small.copyWith(fontWeight: FontWeight.bold)),
  ),
  placeholder: Text('$providerType account number'),
  validator: (v) {
    if (v.length < 13) {
      return 'Account must be 13 characters.';
    }
    return null;
  },
),

I  want to assign it to errorText

Will add it, meanwhile use setState errorText in the validator

If you're just changing the text style and padding, consider using errorStyle and errorPadding passing the decoration

If you're just changing the text style and padding, consider using errorStyle and errorPadding passing the decoration

Thanks, I did not notice this parameter.

Will add it, meanwhile use setState errorText in the validator

I have multiple fields, this is just one of them so this approach might quickly get complicated.

Will add it, meanwhile use setState errorText in the validator

I have multiple fields, this is just one of them so this approach might quickly get complicated.

You can change it from the theme level to all form fields:
ShadThemeData(
    decoration: ShadDecoration(
        labelStyle: TextStyle(color: Colors.blue),
        errorStyle: TextStyle(color: Colors.orange),
        errorPadding: const EdgeInsets.symmetric(horizontal: 6),
        labelPadding: const EdgeInsets.symmetric(horizontal: 6),
  ),
),

or just for the Input fields
ShadThemeData(
  inputTheme: ShadInputTheme(
    decoration: ShadDecoration(
      labelStyle: TextStyle(color: Colors.blue),
      errorStyle: TextStyle(color: Colors.orange),
      errorPadding: const EdgeInsets.symmetric(horizontal: 6),
      labelPadding: const EdgeInsets.symmetric(horizontal: 6),
    ),
  ),
)

or for each single field widget passing the decoration

Thanks


Update test doc

Add /doc folder
Refactor main README to include images and move User Guide to separate file.

The rest looks good to me. :)

Please add Signed-off-by in commit msg. Thanks.

@llxia - I have made some additional changes to the User Guide, can you please re-review?


Add off method

Context
While following the thread https://github.com/cardano-foundation/CIPs/pull/151 I noticed some work was done very recently to support the on() proposal. I also notice a couple of issues with it, being 1) using .name of the callback to identify which to clear out and 2) Support to remove the callback was removed, while a lonely removeListener function was left
Solution

Added off method, based on removeListener
Refactored the methods to use the callback reference, not the .name

About using .name:
This would only work when the given callback would not be an anonymous function.
Examples:
function normalFn() {}
normalFn.name // normalFn

const arrow = () => {}
arrow.name // arrow

(() => {}).name // empty string

In order to identify which callback is which, the function reference works fine.
About the off method:
When firing it, all the matching callbacks assigned to a given event are removed and cleared from the window event listener.
Other notes

the import of 'react-icons/Go' was breaking my build due to the uppercase char
tests were added to support the on/off methods
I was not really sure about injecting the on/off to window.cardano right away, so I decided to return { remove: () => off() } at the on method, which in the end is backwards compatable with the previous version
I noticed that after the very latest push, the events were not working anymore. But with this PR they are. I am not sure if it is something I fixed, or it I was doing something wrong after I pulled.

Great, thanks!

I was not really sure about injecting the on/off to window.cardano right away, so I decided to return { remove: () => off() } at the on method, which in the end is backwards compatable with the previous version

Yes, I was not even sure someone knew that you can remove the event with that function. That is why I removed it and the idea of having a seperate function in the API called removeListener or off is much better. I'm still waiting with implementing it until the discussion progresses a little bit more.

I noticed that after the very latest push, the events were not working anymore.

Events are still working for me? Or do you you mean only the removing part here?

So, let me know if I should remove the remove method from the return.
I think exposing both on and off definitely makes more sense in the long term.

Yes, I was not even sure someone knew that you can remove the event with that function.

It was not obvious, but evident by reading the source code

Events are still working for me? Or do you you mean only the removing part here?

So probably I was doing something wrong, don't mind it.

So, let me know if I should remove the remove method from the return.

It's fine, we can leave it in for now, until the event listeners become part of CIP-0030
I'm gonna merge this PR now. Looks good👍🏻


Support Android on testfairy action

Feature Request
Motivation Behind Feature
I would like to automate my test build uploads to TestFairy for both iOS and Android, for what I've read in the documentation it is only possible for iOS at the moment.
Feature Description
Support build uploading to TestFairy for Android, I have already seen the feature requested here: https://github.com/fastlane/fastlane/issues/4111 (I opened a new issue because I am unable to reply to that one as it got closed for inactivity)
testfairy(
  api_key: "...",
  apk: "./apk_file.apk",
  comment: "Build #{lane_context[SharedValues::BUILD_NUMBER]}",
)

Alternatives or Workarounds
I am unsure if there are any alternatives existing, any help on the topic would be greatly appreciated.

@Dor3nz Its poorly named but if you pass the APK path into the ipa option it actually works 😉  I will update the action and docs to say this 🙃

Oh! Alright, thank you!


Microsoft Sculpt remap the split space bar

Hello,
I was wondering if it would be possible to remap the spacebar on MS sculpt (a split-ish keyboard, which has two keys for spacebar) to different keys?
For example, I would like to remap the left spacebar to my command key.
Thanks!

I seem to remember having tried just that with the old, full-featured Karabiner.
In the end I'm fairly certain that it couldn't be done because the Sculpt sends the exact same key code for both spacebars and has no internal remapping capabilities.

Thanks @frankrei! That is too bad. I like the keyboard but wish the command key was nit so far to right. I would love to remap the left spacebar to command. Oh well. C'est la vie. Thanks again for your help and reply. :)

@mhulse
Hi- I want to do the exact same thing as you (left space bar on a split keyboard -> command).  Have you found a keyboard that allows you to do this?

Actually, kinda, but no. Hehehe.
(writing this quickly … Sorry in advance if spelling or grammatical errors)
Right now I'm using Microsoft Sculpt from a standing position. For some reason, I am not as bothered by the command key being so far to the left (under my palm).

But, this is a body thing. For me, RSI and aches/pains come and go, sometimes over a period of months. Right now, my left thumb is feeling OK about the command key where it is (at least, from the standing position).
With that said, a few other options I have tried ...
1. Using Karabiner to do a split keyboard:

This works great!
I think this is a much better, and cheaper, alternative to my next option ....
2. ErgoDox EZ
https://ergodox-ez.com/
Super awesome for programming, but I didn't really enjoy using it for Design work. If I just programmed all day long, I'd still be using that keyboard.
The huge advantage that keyboard has is the ability to map the keys to whatever you want.
The negative is the number of keys is a little less than standard, so you have to get creative about some of your favorite key placements (though, there are layers, but I never got fast at switching).
Here's a pic:

ErgoDox EZ has a nice configurator:
http://configure.ergodox-ez.com/keyboard_layouts/new
The default layout of the keyboard can be seen via that link above.
ErgoDox in general is a keyboard that is supposed to be ergonomically optimized in terms of key layout and positioning. Lots of people build their own ErgoDox, and (FWIK) there are varying styles of ErgoDox blueprints (check https://www.massdrop.com/). ErgoDox EZ build it for you, which I liked, as I don't have time to do all the soldering and such myself.
2. Japanese keyboard
I also tested a Japanese keyboard.
After using the EgoDox, I found that I actually prefer the low profile keys, and the membrane "switch" type of my mac keyboards.
Looking around at various low profile keyboards, and with option 1 above in mind, I was on the search for any keyboard that had a smaller space bar. Out of all the keyboards I researched (with membrane/low profile keys) the best looking ones were the Japanese keyboards.

I was able to use Karabiner to remap the Japanese keys (I could maybe dig up my Karabiner config file if interested), but, IIRC, the return key was kinda funky as it ate a key normally used on an EN keyboard.
Other than that, I don't remember disliking the keyboard. My plan was to get two of these Japanese keyboards and use Karabiner to do the split keyboard thing.
I don't think I explored this option well enough to have an opinion. What I love is the space bar is short, which allows the command key to scoot over to the right.
Anyway, that's all I can think of off the top of my head. I hope it helps!

@mhulse -
Fantastic! That really helps, glad to know there's someone else with the exact same problem as me.  Left thumb hurts after years of reaching underneath my palm for the command key.  Like you said, it's on and off but it's gotten pretty unbearable in the last week and it's directly affecting my concentration when typing.
I may try the ergodox, that looks to be the only one that solves my ergonomic problem... not the angle of my wrists, but reaching position of my thumb for the integral CMD, ALT keys.

Yah, it's pretty frickin' lame that the space bars are SOOO big for EN keyboards. I honestly don't think there's a good reason for it, other than "it's the norm".
Alternatively, you could map your command to something like capslock. I have tried this, but I am so used to command being a thumb thing, the capslock reach was a bit tough.
That's the thing with ErgoDox, you do have to change some muscle memory things.  That really helps to speed up the learning.
Check out Ebay for used EgoDox. You might find something cheaper than a new model.
If interested, I created a repo for my ergo (which I no longer own):
https://github.com/mhulse/ergodox
That repo is a little outdated though. I ended up just using the online configurator at the EgoDox site. I don't think this was my latest keymap, but it was close to what I had before I sold it:
http://configure.ergodox-ez.com/keyboard_layouts/qgvpok/edit
I do programming and design at work, so the above map was my preferred coding layout (easy access to angle/square brackets, etc.)
Definitely don't think you can go wrong choosing an Ergodox. Just be prepared for keyboard that is louder than the MS one, and be prepared to change up some key placement muscle memory.
Good luck dude! Post back here if you find or learn something good!

Just found the thread that has info on how to remap Japanese keyboards:
https://github.com/tekezo/Karabiner-Elements/issues/167#issuecomment-331133220
@steveonjava just posted a complete example! I am looking forward to trying his config as I remember not being totally satisfied with the config I cobbled together. :)

@mhulse Thanks for your story. My left thumb is the same. These big spacebars are horrible from an ergonomic perspective. I'm trying what you did with the japanese keyboard, but since I'm such a noob, I am having trouble copying and pasting @steveonjava 's code correctly. I can't get it work.
Are there any obvious pitfalls that I'm doing incorrectly?

I just discovered that in my keyboard (R-go Split) I can detect which spacebar is pressed even if they send the same keycode by using different device selector for each halve.
:devices {
	:macbook [{:product_id 631 :vendor_id 1452}]
        :rgo-split [{:product_id 8584 :vendor_id 2321}]
        :rgo-left [{:product_id 8584 :vendor_id 2321 :location_id 336789504}]
        :rgo-right [{:product_id 8584 :vendor_id 2321 :location_id 336736256}]
}

So then, you can use something like that to map one of the spacebar halves to enter:
[ :spacebar :return_or_enter :rgo-right ]

I just discovered that in my keyboard (R-go Split) I can detect which spacebar is pressed even if they send the same keycode by using different device selector for each halve.

Oooh, nice! Thanks for sharing!
Cool keyboard too! Looks affordable!

Yes! it is affordable enough to have one at  the office and another one at home
I would like to share with you my own layout, using one of the spacebars as layer modifier is a great advantage!

I would like to share with you my own layout.

Started! Thanks!


Can't start from source on Ubuntu 20.04

Describe the bug
After cloning the repo, running yarn, and running npm start, an error occurs that prevents GB-Studio from running.
To Reproduce
Steps to reproduce the behavior:

Clone repo
Enter gb-studio directory, run yarn
Run npm start

Expected behavior
The program starts successfully
Screenshots
(Nothing visual happens, nothing to screenshot)
Platform (please complete the following information):

OS: Ubuntu 20.04 x86-64
App version 1.2.1 (latest git source)
npm version 6.14.4
yarn version 1.22.4

Additional context
Terminal output:
iling:~$ git clone https://github.com/chrismaltby/gb-studio.git
Cloning into 'gb-studio'...
remote: Enumerating objects: 164, done.
remote: Counting objects: 100% (164/164), done.
remote: Compressing objects: 100% (115/115), done.
remote: Total 25358 (delta 80), reused 97 (delta 48), pack-reused 25194
Receiving objects: 100% (25358/25358), 46.35 MiB | 9.71 MiB/s, done.
Resolving deltas: 100% (12734/12734), done.
iling:~$ cd gb-studio/
iling:~/gb-studio$ yarn
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
Done in 23.50s.
iling:~/gb-studio$ npm start

><EMAIL_ADDRESS>start /home/iling/gb-studio
> electron-forge start

✔ Checking your system
✔ Locating Application
✔ Preparing native dependencies
✔ Launching Application
No language pack for user setting, falling back to en
Add a language pack by making the file src/lang/en-US.json
(node:16387) UnhandledPromiseRejectionWarning: Error: Exited with code 9
    at ChildProcess.<anonymous> (/home/iling/gb-studio/node_modules/cross-unzip/index.js:38:21)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
(node:16387) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16387) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
<... hangs here indefinitely ...>

See here. You should fix it like this:
https://github.com/electron/fiddle/issues/454
https://github.com/electron/fiddle/pull/455/files/40f9164044a4464cc54c4a815d7c1a78a5b04066
So I want to request electron-devtools-installer version to upgrade.
diff --git "a/package.json" "b/package.json"
index a37370b7..7bc6627d 100644
--- "a/package.json"
+++ "b/package.json"
@@ -42,7 +42,7 @@
"classnames": "^2.2.5",
"deepmerge": "^3.1.0",
"electron-compile": "^6.4.4",

"electron-devtools-installer": "^2.1.0",

"electron-devtools-installer": "^3.1.1",
"electron-is": "^3.0.0",
"electron-settings": "^3.2.0",
"electron-squirrel-startup": "^1.0.0",

same error


UglifyJs Webpack build error when updated to the 3.0.4 version

ERROR in app.js from UglifyJs
Unexpected token: punc (.) [./~/redux-logger/src/core.js:17,0][app.js:921,61]
Coming from a react+redux+typescript project built for production with webpack 2
the project used 3.0.1 until now.
any ideas?

@avivshafir could you please update the version to 3.0.6

@thiamsantos it is now working.
Thanks

Good to hear. The problem was some mistakes that In made at #227.


New release number?

Can you guys tag a release when you are next stable, I am about to push a few clusters and would love to be up to date!

I know its kinda late but we will release a new version soon.
I've contacted the original author to get me setup so I can do it myself.

New version 1.6.0 have been released. Note that it is a under a new group ID io.soabase.exhibitor.
Closing issue for now.


Update layers/meta-balena digest to 03d8e7b

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
47781bd -> 03d8e7b

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@balena-ci I self-certify!

@resin-jenkins test this please


Ambiguity warning

While running my Java project, which uses webcam and native code using OpenCV I'm getting this at runtime printed on console after
final Webcam webcam = Webcam.getDefault();
objc[1337]: Class CaptureDelegate is implemented in both /usr/local/lib/libopencv_videoio.3.3.dylib (0x12917b918) and /var/folders/l6/_fk71njs2r52jbvp4b9y52_h0000gp/T/BridJExtractedLibraries8002541723609415571/libOpenIMAJGrabber.dylib (0x10f6a59e0). One of the two will be used. Which one is undefined.
Any ideas what this might mean? And how to prevent?

As a consequence it seems I'm not getting called back
Following your example:
https://github.com/sarxos/webcam-capture/issues/581
Having done this:
    mCameraAPI = Webcam.getDefault();
    mCameraAPI.setViewSize(WebcamResolution.VGA.getSize());
    mCameraAPI.setImageTransformer(new WebcamImageTransformer() {
        @Override
        public BufferedImage transform(BufferedImage bufferedImage) {
            return null;
        }
    });
    mCameraAPI.open();

The expectation is to get called back with every frame. Should that happen?

Hi @neilyoung,
It says that implementation of CaptureDelegate exist in two different native binaries:

libOpenIMAJGrabber.dylib
libopencv_videoio.3.3.dylib

One comes from OpenIMAJ extracted by BridJ and the other comes from OpenCV. Excluding BridJ from dependencies should be enough IMO, so you can try adding BridJ exclusion into your pom.xml:
<dependency>
	<groupId>com.github.sarxos</groupId>
	<artifactId>webcam-capture</artifactId>
	<version>${project.version}</version>
	<exclusions>
		<exclusion>
			<groupId>com.nativelibs4java</groupId>
			<artifactId>bridj</artifactId>
		</exclusion>
	</exclusions>
</dependency>

If you are not using Maven then simply get rid of BridJ from your classpath.
Please also make sure to set JavaCvDriver at the very beginning, ideally in static block in your main class, to prevent default driver from being initialized.
static {
  Webcam.setDriver(new JavaCvDriver());
}

@neilyoung I forgot to ask you - which driver are you using? Default or JavaCvDriver? Because when you exclude BridJ you will be using JavaCvDriver, but this may not be what you need.

@sarxos Default

@sarxos Well, I'm not using maven to build, I'm using the dependency management of IntellijIdea. Indeed, once I add a dependency to com.github.sarxos:webcam-capture:0.3.112, these JARs are added automatically:
bridj-0.7.0.jar
slf4j-api-1.7.2.jar
webcam-capture-0.3.11.jar
If I remove the first manually I'm catching an exception like so:
Exception in thread "main" com.github.sarxos.webcam.WebcamException: java.util.concurrent.ExecutionException: com.github.sarxos.webcam.WebcamException: Cannot execute task
	at com.github.sarxos.webcam.WebcamDiscoveryService.getWebcams(WebcamDiscoveryService.java:124)
	at com.github.sarxos.webcam.Webcam.getWebcams(Webcam.java:874)
	at com.github.sarxos.webcam.Webcam.getDefault(Webcam.java:937)
	at com.github.sarxos.webcam.Webcam.getDefault(Webcam.java:914)
	at com.github.sarxos.webcam.Webcam.getDefault(Webcam.java:892)
	at com.mycompany.myproject.sdk.myclass.<init>(myclass.java:81)
	at com.mycompany.myproject.myclassMain.preparemyclass(myclassMain.java:185)
	at com.mycompany.myproject.myclassMain.<init>(myclassMain.java:263)
	at com.mycompany.myproject.myclassMain.main(myclassMain.java:301)
Caused by: java.util.concurrent.ExecutionException: com.github.sarxos.webcam.WebcamException: Cannot execute task
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at com.github.sarxos.webcam.WebcamDiscoveryService.getWebcams(WebcamDiscoveryService.java:116)
	... 8 more
Caused by: com.github.sarxos.webcam.WebcamException: Cannot execute task
	at com.github.sarxos.webcam.WebcamProcessor$AtomicProcessor.process(WebcamProcessor.java:72)
	at com.github.sarxos.webcam.WebcamProcessor.process(WebcamProcessor.java:140)
	at com.github.sarxos.webcam.WebcamTask.process(WebcamTask.java:46)
	at com.github.sarxos.webcam.ds.buildin.WebcamDefaultDriver$WebcamNewGrabberTask.newGrabber(WebcamDefaultDriver.java:45)
	at com.github.sarxos.webcam.ds.buildin.WebcamDefaultDriver.getDevices(WebcamDefaultDriver.java:117)
	at com.github.sarxos.webcam.WebcamDiscoveryService$WebcamsDiscovery.call(WebcamDiscoveryService.java:36)
	at com.github.sarxos.webcam.WebcamDiscoveryService$WebcamsDiscovery.call(WebcamDiscoveryService.java:26)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NoClassDefFoundError: org/bridj/cpp/CPPObject
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at com.github.sarxos.webcam.ds.buildin.WebcamDefaultDriver$WebcamNewGrabberTask.handle(WebcamDefaultDriver.java:55)
	at com.github.sarxos.webcam.WebcamProcessor$AtomicProcessor.run(WebcamProcessor.java:81)
	... 3 more
Caused by: java.lang.ClassNotFoundException: org.bridj.cpp.CPPObject
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 17 more

This happens as a direct response to Webcam.getDefault()

Regards

@neilyoung
I see. In this case, if you are using default driver, removing BridJ is not an option. There are two ways to solve your issue imo:

Remove OpenCV from your Mac, or
Prevent BridJ from loading libopencv_videoio.3.3.dylib.

Option 1) is obvious, but let us discuss option 2).
I took a brief look at the BridJ source code and I found the following lines:
https://github.com/nativelibs4java/BridJ/blob/f221b3650ebe0d74931898dbaa88b5fe18b2d10c/src/main/java/org/bridj/BridJ.java#L697-L702
As we can see in the code there are two ways of adding library to the BridJ search paths. First is by setting ENV variable and the second one is by using -D property of Java. Let's start by finding which property/ENV variable is causing OpenCV dylib to be added to the BridJ:
System.out.println("java.library.path ---------------- ");
System.out.println(System.getProperty("java.library.path");
System.out.println("sun.boot.library.path ---------------- ");
System.out.println(System.getProperty("sun.boot.library.path");
System.out.println("gnu.classpath.boot.library.path ---------------- ");
System.out.println(System.getProperty("gnu.classpath.boot.library.path"");

And for ENVs:
System.out.println("LD_LIBRARY_PATH ------------------ ");
System.out.println(System.getenv("LD_LIBRARY_PATH"));
System.out.println("DYLD_LIBRARY_PATH ------------------ ");
System.out.println(System.getenv("DYLD_LIBRARY_PATH"));
System.out.println("PATH ------------------ ");
System.out.println(System.getenv("PATH"));

Run these snippets and take a close look at the output. Your goal is to find out which one of them is adding the following directory (with file, or without file):
/usr/local/lib

Right now all properties and ENV variables which contains this directory need to be modified (but not permanently). Property can be reset very simple by setting it to some empty value. This need to be done in a static block at the very beginning of your main class:
static {
  System.setProperty("property.name", ""); // replace property.name with a real property
}

The ENV is a bit more tricky. If you are using InteliJ then you have to edit your Run/Debug Configuration (somewhere in menu) and set ENV variable to empty value. Thing's are more tricky when you are running your application from console because you will have to save previous values of ENV variables, run your application, and then change ENV variable to what it was before.

@sarxos Thanks for your patience. Currently this problem is not that important for me, because I don't have to use the image transformer callback (as I intended to to first). I'm happy with what getImageBytes delivers on a separate thread.
However, in order to find the root of this problem, let's continue to analyze:
Here is the output of the snippets above:
java.library.path ----------------
./lib
sun.boot.library.path ----------------
/Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/lib
gnu.classpath.boot.library.path ----------------
null

LD_LIBRARY_PATH ------------------
null
DYLD_LIBRARY_PATH ------------------
null
PATH ------------------
/Users/me/.atom/packages/platformio-ide/penv/bin:/Volumes/case-sensitive/esp-open-sdk/xtensa-lx106-elf/bin:/usr/local/sbin:/usr/local/git/bin:/usr/local/heroku/bin:/Users/me/tools:/Users/me/.rvm/gems/ruby-2.2.4/bin:/Users/me/.rvm/gems/ruby-2.2.4@global/bin:/Users/me/.rvm/rubies/ruby-2.2.4/bin:/opt/local/bin:/opt/local/sbin:/opt/subversion/bin/:/Users/me/android-sdk-mac_x86/tools:/Users/me/android-sdk-mac_x86/platform-tools:/usr/local/bin/:/cal/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/share/dotnet:/usr/local/git/bin:/Library/Frameworks/JRuby.framework/Versions/Current/bin:/Users/me/.rvm/bin:/Users/me/bin:/Users/me/Documents/ESP-32/xtensa-esp32-elf/bin:/usr/local/Cellar/mysql/5.6.27/bin

AFAIK there is no /usr/local/lib  entry, isn't it?

Dammit. Yes, indeed, there is no /usr/local/lib :(

Another dive into BridJ code and I found it:
https://github.com/nativelibs4java/BridJ/blob/f221b3650ebe0d74931898dbaa88b5fe18b2d10c/src/main/java/org/bridj/BridJ.java#L734
Unfortunately this one cannot be workaround ;(

But lets go back to your initial comment:

Having done this:

    mCameraAPI = Webcam.getDefault();
    mCameraAPI.setViewSize(WebcamResolution.VGA.getSize());
    mCameraAPI.setImageTransformer(new WebcamImageTransformer() {
        @Override
        public BufferedImage transform(BufferedImage bufferedImage) {
            return null;
        }
    });
    mCameraAPI.open();

The expectation is to get called back with every frame. Should that happen?

No. This won't be called with every frame. This will be called every time you invoke getImage(). In async mode (when open(true) is used) this will be, indeed, invoked on every frame, because webcam updater silently call getImage() in a background.
If you want this method to do nothing you should return source image instead of null:
    mCameraAPI.setImageTransformer(new WebcamImageTransformer() {
        @Override
        public BufferedImage transform(BufferedImage bufferedImage) {
            return bufferedImage;
        }
    });

In regards to the warning I think you will either have to live with it or remove OpenCV.

@sarxos OK, thanks for clarification. As said, I'm happy with what I have now and I can live with the warning.
Thanks

Hi, I'm having this error. Did you find a solution? I'm using opencv openpnp and I can not remove it.
The error message is:
objc[6899]: Class CaptureDelegate is implemented in both /private/var/folders/j1/_q1t_00d0fg66bsgtgf8zjgc0000gp/T/opencv_openpnp5786236370894680416/nu/pattern/opencv/osx/x86_64/libopencv_java320.dylib and /var/folders/j1/_q1t_00d0fg66bsgtgf8zjgc0000gp/T/BridJExtractedLibraries4705987337836921372/libOpenIMAJGrabber.dylib.
One of the two will be used. Which one is undefined.
Thanks


Eureka Server Multi-Instance Issue in service Discovery

I have three Eureka server which is cluster each other. Let say Eureka1,Eureka2 and Eureka3. Now i register my service in Eureka1 for service Discovery. Then from another UI application i Call Eureka2 and Fetch the registered service URL, it will work because three servers are cluster. It was working fine for me.
The issue is, Now i stopped the Eureka1, then now i tried to fetch the registered service details in Eureka2 from UI application, it is throwing error. Because the service initially registered in Eureka1. Is there any configuration needed to solve this issue? Can any one help me to resolve this, thanks in advance.

Is the service also configured to register with Eureka2 or just Eureka1?

@ryanjbaxter  Thanks for your intrest. Actually the service Registered in Eureka 1, since it is cluster it is affected in Eureka 2 also. If the Eureka 1 is running, then i can able to fetch registered service details from Eureka 2 also. The issue is when i stop Eureka1, i could not fetch the details from Eureka 2.

Probably because the service can no longer contact Eureka1, you should configure the service to register with all three Eureka servers so if Eureka1 is not reachable it will go to Eureka2 etc.  I believe you can do something like this
eureka.client.service-url.defaultZone=http://eureka1/eureka/,http://eureka2/eureka/,http://eureka3/eureka/

hi @ryanjbaxter  i already used the above property which you mentioned, though it is not working.

Yes but did you add all 3 eureka server urls?  If so can you provide a sample that reproduces the problem?

@karthikrajakandasamy
In my mind, if your client only configure one eureka server such as
eureka.client.service-url,defaultZone=http://eureka1

When eureka server1 is UP you can fetch all client information because , client will send heartbeat
to eureka server1 and eureka server1 will replicate the information to eureka2, so you can fetch information from eureka server2. if eureka server1 is DOWN(and your client not configure the eureka server2), then eureka server2 will not receive the replicate information from eureka server1 so, you can not fetch the information.
So I think the best way is every client will configure the all eureka server.such as
client configure:
eureka.client.service-url,defaultZone=http://eureka1, http://ureka2, http://eureka3

at above configure if eureka server1 is DOWN then your client will auto register itself information to eureka server2.
welcome communication : )
thanks

@karthikrajakandasamy is this still accurate?
If you put multiple eureka servers' addresses in default zone property and it is still not working, the problem might be that your eureka instances run on the same server and they share the same IP which you are using in combination with different ports to create urls which you put in the default zone property. Like this:
eureka.client.service-url,defaultZone=http://localhost:8001, http://localhost:8002, http://localhost:8003
If multiple instances of eureka servers are run on the same IP and they interconnected, each eureka instance might see the others as itself. In that case if you turn one instance off while there are services registered on it, services might be lost for a short time, untile they register on the another eureka host. So there is a short downtime if one eureka fails. Anyway, this is not normal behavior.
Try to create different hostnames for different eureka instance (the easiest way is to do that in hosts file), and change the defaultZone property:
eureka.client.service-url,defaultZone=http://eureka-primary:8001, http://eureka-secondary:8002, http://eureka-tertiary:8003

Closing due to lack of feedback.  Please reopen if you still have issues.


Pagination resets back to page 1 when updating other table

I am using 2 tables, 1 is a custom table(table1) under paginationProvider and the other one(table2) is plain BootstrapTable.
table2 list will be loaded when a row from table1 is being selected (through the load button).
However when i try to navigate any pages other than page one then i try to select a row the pagination from table1 resets
Reproduction:
https://codesandbox.io/s/101nw1m6o3
Versions:
"react-bootstrap-table-next": "^3.0.2",
"react-bootstrap-table2-paginator": "^2.0.4",

@rexatgithub I think this is not a bug. Everytime you click on "Load" button in Actions column will trigger rerender DataContainer, that's why you go back to first page.
the best solution will be: Avoid StudentList get rerender when state.selected_student change by shouldComponentUpdate

@AllenFang ow right. Thanks.


Autocomplete classes and functions from other namespaces

Hi! You did a great job! Autocompletion inside a single namespace is working great!
But if I want to use another namespace, autocompletion doesn't know anything about it, even if it's specified inside the same file. Is it possible to fix it?

@vovanmix could you provide some code to reproduce the problem you are explaining?


Cannot set TESSDATA_PREFIX when building tesseract-4.0.0

I am unable to set -DTESSDATA_PREFIX=/usr/local/share/tesseract-ocr/4.00/tessdata with cmake or  TESSDATA_PREFIX="/usr/local/share/tesseract-ocr/4.00/tessdata" ./configure --prefix=/usr/local --enable-tessdata-prefix with autotools.
Are users meant to be able to do this?

No, it not possible. And IMO it does not make sense nowadays.

No, it not possible. And IMO it does not make sense nowadays.

Thanks for the reply, but it's kind of inconvienient to have to set TESSDATA_PREFIX and also means, for example, that gImageReader looks in "/" for the data files...

You can use --tessdata-dir to specify data path or use tesseract API to specify data path at init...
Regarding gImageReader we can do nothing - it is external project.

@juanitotc, try ./configure --datadir=/usr/local/share/tesseract-ocr/4.00 [...].

@stweil: I am not sure if 4.0 branch make sense...

It was there, so it should be in an acceptable state. Removing that branch would be another option, but I don't think that would be good.

We should check if all commits in 4.0 are in also in master and 4.1...

@juanitotc: try master code now (cmake .. -DTESSDATA_PREFIX=/usr/local/share/tesseract-ocr/4.00/tessdata)

Thanks for that - there is a slight problem in that "cmake .. -DTESSDATA_PREFIX=/usr/local/share/tesseract-ocr/4.00/tessdata" will cause tesseract to look in "/usr/local/share/tesseract-ocr/4.00/tessdata/tessdata" i.e. "tessdata" is repeated in the path.

@juanitotc: you miss the point: I just used your example - you can specify whatever path you want. It is not tesseract problem, but your decision.


PANIC: Could not figure out an ID in create

Hi Prisma Team! My Prisma Client just crashed. This is the report:
Versions

Name
Version

Node
v10.16.2

OS
windows

Prisma Client
2.9.0

Logs
  prisma-client { engineConfig:
  prisma-client    { cwd:
  prisma-client       'C:\\Users\\jayan\\Desktop\\Ubiq\\critiqueapp\\critique_backend\\prisma',
  prisma-client      enableDebugLogs: false,
  prisma-client      enableEngineDebugMode: undefined,
  prisma-client      datamodelPath:
  prisma-client       'C:\\Users\\jayan\\Desktop\\Ubiq\\critiqueapp\\critique_backend\\node_modules\\.prisma\\client\\schema.prisma',
  prisma-client      prismaPath: undefined,
  prisma-client      engineEndpoint: undefined,
  prisma-client      generator:
  prisma-client       { name: 'client',
  prisma-client         provider: 'prisma-client-js',
  prisma-client         output:
  prisma-client          'C:\\Users\\jayan\\Desktop\\Ubiq\\critiqueapp\\critique_backend\\node_modules\\@prisma\\client',
  prisma-client         binaryTargets: [],
  prisma-client         previewFeatures: [],
  prisma-client         config: {} },
  prisma-client      showColors: false,
  prisma-client      logLevel: undefined,
  prisma-client      logQueries: undefined,
  prisma-client      flags: [],
  prisma-client      clientVersion: '2.9.0',
  prisma-client      enableExperimental: [],
  prisma-client      useUds: undefined } }

Hey @jayanth1991
Sorry for the late reply here. This looks like an automated report to me. Can you still reproduce this? If yes, please share more details on how to reproduce this. Thanks!


Revert https://issues.redhat.com/browse/JBTM-3954

Revert https://issues.redhat.com/browse/JBTM-3954
https://github.com/jbosstm/jboss-as/pull/94

I think this partially revert this: https://github.com/jbosstm/lra/pull/15, related to https://github.com/jbosstm/jboss-as/pull/93
Could I ask you @tomjenkinson to check the JBTM number please.

JACOCO profile tests failed (https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-lra/PROFILE=JACOCO,jdk=openJDK17,label=jnlp-agent/81/): LRA Test failed with failures in arq profile

The failures are related to our jboss-as project which needs to revert https://github.com/jbosstm/jboss-as/pull/93 too.

Thanks Marco, I had the wrong JBTM in the original message - I have corrected it in the title and description of this pull request

And thank you for raising https://github.com/jbosstm/jboss-as/pull/94

I stopped JACOCO myself as getting the test coverage wouldn't help with the decision to merge this


Improve accuracy of registered EventTypes' source

The registration of the EventTypes supported by AWS Sources is delegated to the reconcilers. Currently those reconcilers do not do anything with the credentials from Source objects and merely pass them to the adapters in a shape that suits them (env var, reference to secret, ...).
One of the shortcomings of the current approach is that reconcilers can only register event types with a partial context.
Take the example of DynamoDB:
$ kubectl get eventtypes.eventing.knative.dev
NAME        TYPE                         SOURCE                                         SCHEMA   BROKER    DESCRIPTION   READY   REASON
1b6034...   com.amazon.dynamodb.modify   aws:dynamodb:eu-central-1:table/sample-table            default                 True
9357f3...   com.amazon.dynamodb.remove   aws:dynamodb:eu-central-1:table/sample-table            default                 True
e1092d...   com.amazon.dynamodb.insert   aws:dynamodb:eu-central-1:table/sample-table            default                 True

The source field contains a pseudo ARN, but not quite the actual ARN generated by AWS, which typically contains the account id as well (e.g. arn:aws:dynamodb:eu-central-1:044455340429:table/sample-table). Without this account id, we could potentially have multiple AWS Services with the same name in different accounts that will be registered with the exact same name in Kubernetes.
We should investigate whether the reconciler could instead make use of the credentials to retrieve real ARNs, and surface them as the source field in the EventTypes.

I have an idea about how we could tackle this one.
I would hate to see the controller connecting to users' AWS accounts just for the sake of retrieving an account ID. It would make things harder to secure, and we would have to ensure the controller can read arbitrary Secrets, or get credentials via kube2iam.
Instead, how about we change our Sources' spec slightly and ask users to pass an arn instead of a combination of region + resourceName (table, stream, ... depending on the AWS service we're taking about). ARNs are great because they contain a lot of useful information for our sources, and they're easy to parse.

I suggest to check the serverless framework to see how the connect to various AWS services.
I am not 100% sure about the sensitivity of ARNs, can they be exposed publicly ?

@sebgoa The issue here is not about connecting to AWS services, but about building a meaningful catalog of event types.
Without the account ID, you would end up with duplicates in case customers use the same name for a given service across multiple AWS accounts. Example:
"Antoine creates a DynamoDB source called triggermesh-events in account 01234"
"Sébastien also creates a DynamoDB source called triggermesh-events in account 04567"
Our DynamoDBs receive unrelated events. Yet, internally the TriggerMesh controller currently creates a single event type:
NAME        TYPE                         SOURCE                                       SCHEMA   BROKER    DESCRIPTION   READY   REASON
e1092d...   com.amazon.dynamodb.insert   aws:dynamodb:eu-central-1:table/triggermesh           default                 True

You can't tell both sources apart.
However, you can if you include an ID to tell them apart:
NAME        TYPE                         SOURCE                                              SCHEMA   BROKER    DESCRIPTION   READY   REASON
e1092d...   com.amazon.dynamodb.insert   aws:dynamodb:eu-central-1:01234:table/triggermesh            default                 True
e1092d...   com.amazon.dynamodb.insert   aws:dynamodb:eu-central-1:05678:table/triggermesh            default                 True

I believe it wouldn't be sensible to use ARNs, especially since we wouldn't expose them to the public. Those ARNs stay inside the cluster, just like any other information that the frontend currently uses to generate ContainerSources.

:100: on this
If I'm not wrong we need to add a different status.ceAttributes[*].source value here, which might mean:

exposing it at the adapter status
gathering it at the controller and adding to the source status

What @sebgoa makes a lot of sense as long as the event registry is not multitenant. I think we need a new ticket for that despite the outcome of this one.

I am just wondering about the multi-tenancy indeed.
If the eventtype registry is cluster scoped, some users could see the ARN of other users in different namespaces.

The registry is namespace-scoped, otherwise we would have to put a cross on it completely because users would be able to see each other's sources, ARN or not.

Good, so I would just spend 20 minutes looking at the serverless framework. They use ARN in their manifests, for example.
https://github.com/serverless/examples/blob/master/aws-node-dynamodb-backup/serverless.yml
I would just make sure exposing the account ID is not problematic

I couldn't think about a scenario where having the account ID visible in the event type could be problematic since it's only "exposed" to the users themselves, who by definition know their own account ID.
Google returned a few discussions on the topic (sorry for quoting StackExchange as if it was the ultimate source of truth 😊):

An AWS Account ID can be shared, when required.
Like the documentation says, the main thing anyone can use your AWS Account Number for is to construct ARN's. For example, if I had an AWS Account which held an AWS Lambda function, and someone on another account, who I had explicitly granted permission to, wanted to manipulate it, they would use by account number in the ARN.
-- https://security.stackexchange.com/a/192547/105952

Sharing AWS Account numbers is fairly safe among business partners. There is not much if anything that anyone can do with just the account number. To assume a role, the account number is required, but the authorizing account must also setup a trust relationship for the policy.
-- https://stackoverflow.com/a/47586088/4716370

I'd say it should generally remain private. But you will need to provide it if you want to set up cross account access with a 3rd party.
If you trust the 3rd party enough to set up cross-account access then it should be fine to provide them your account number.
-- https://acloud.guru/forums/aws-certified-solutions-architect-professional/discussion/-KRUT9T6gFZ4Ebyv0hLp/my-aws-account-id-should-it-remain-private

@sebgoa did you come up with a final decision regarding this? If identifying AWS event sources by their ARN is a no-go, do you have any other suggestion for uniquely identifying them?

Let's go with arn


[GH-313] Fixed HTTP server endpoint bug

Resolves #313

@Artur64 no other places where this is called?


Download large test repo once, then store in image

This allows us to skip the lengthy step of downloading elawa.zip from Google Drive every time skaffold delete gets run, or the hg-repos volume gets deleted.
Fixes #758.

I suspect the docker build -t local-dev-init data/ line in task setup will turn out to be unnecessary now that I added the skaffold.yaml config, but I ran out of time to test that today. If you want to test this out, try deleting that line and see if the populate-test-repos container still runs correctly.


gDNA page blocks the webserver without UI indication

While working through testing of #468, I added a plate on the gDNA plate extraction page. This took about 30 seconds to do, with high observed load on postgres (less so on the python process). During this time, the webserver was unresponsive, demonstrated by the subsequent portion of the .gif below where plates are added followed by attempts to navigate away from the page.
My test database has an additional 10 amplicon plates, and 10 shotgun 384-well plates as loaded by the stress testing script. It is unclear if the volume of data in the local test database is associated with this issue.

It seems like if the page is waiting for a response for the first plate getting plated, it should at least disable the Add new plate button.


go

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

What did you expect to see?
What did you see instead?

This issue appears to be empty. Did you mean to open it?


Improvement: handle hexdump in a better way.

There is a common mistake and that is that users make a lot of mistakes in providing the correct packet.payload. We should cover their mistakes and/or show the appropriate error if possible.
For example, if the hexdump didn't start with '4' (i.e, IPv4 -- currently supported), show an error. Or try Ether(hexdump) instead of IP(hexdump), and see if there is an IP layer, export packet.payload or packet[IP] to remove the Ethernet layer

fixed in https://github.com/wikicensorship/tracevis/commit/36873badc84ada7dfc9e23a30266857e5e2fa751 and  #63


Width of text drop-down menu

What should be the minimum and maximum widths of this menu?

Happy with it presently!


Compatibility with sensu enterprise

I am extending this repo so that it can deploy sensu enterprise.
Do you guys think it would be interesting to merge it back to sensu/sensu-ansible?

See related wip pull request #82

👍 in concept, there are a couple details regarding compatibility with non-enterprise users in the PR I'll note.

Close since #82 is merged to master.


gradle depends on an insecure third-party JAR package that contains the CVE vulnerability cve-2020-13956.

gradle version: gradle-6.3 / gradle-6.5 / gradle-6.7
an insecure third-party JAR package ： gradle-6.3\lib\plugins\httpclient-4.5.10.jar
CVE INFO: https://nvd.nist.gov/vuln/detail/CVE-2020-13956
httpclient needs update to the lastest version

i found another jar. the similar problems.
jar : gradle-6.7\lib\plugins\jackson-databind-2.10.2.jar
CVE INFO: https://nvd.nist.gov/vuln/detail/CVE-2020-25649

i found another jar. the similar problems.
jar : gradle-6.7\lib\plugins\jackson-databind-2.10.2.jar
CVE INFO: https://nvd.nist.gov/vuln/detail/CVE-2020-25649

For Gradle 7.0:

httpclient will be updated to 4.5.13
jackson-databind will be updated to 2.12.1

Both of these versions are no longer impacted by the CVEs reported here.

This is merged - closing


Adds support for Ultra disks

Adds support for Ultra Disks by enabling the option
ultra_ssd_enabled - (Optional) Used to specify whether the UltraSSD is enabled in the Default Node Pool. Defaults to false. See the documentation for more information.

Hi @digiserg , thanks for opening this pr! We've just released v6.0.0 and in this new major release we've added a new CI pipeline. Would you please update your pr with the latest master branch so we can leverage our CI pipeline to do the check and tests for us? We also provided a docker image so we can run the code check and tests on our local machine, appreciate if we can read the latest README and do the check first, thanks!

I'll send a new clean PR, this has become a mess


Error when trying to use Falcon-7B

I get the same error when Falcon 7B pod starts. Looks like the model file was deleted: https://huggingface.co/TheBloke/WizardLM-Uncensored-Falcon-7B-GGML/commit/7343df6eea4cfef162077380d075b49fdc9364ee
Deploy
helm install falcon-7b ialacol/ialacol -f examples/values/falcon-7b.yaml

Pod logs:
INFO:     Started server process [1]
INFO:     Waiting for application startup.
Error downloading model: 404 Client Error. (Request ID: Root=1-64d11005-11d0783d650eb9652ee63f84)

Entry Not Found for url: https://huggingface.co/TheBloke/WizardLM-Uncensored-Falcon-7B-GGML/resolve/main/wizard-falcon-7b.ggmlv3.q4_1.bin.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

Thank you, they might have changed the file name, newest seems to be https://huggingface.co/TheBloke/WizardLM-Uncensored-Falcon-7B-GGML/blob/main/wizardlm-7b-uncensored.ggccv1.q4_0.bin

@chenhunghan yes, this new model at least can be loaded when the pod starts, but I hit the issue with when I try to make any request:
INFO:     Started server process [1]
INFO:     Waiting for application startup.
Downloading (…)ored.ggccv1.q4_0.bin: 100%|██████████| 4.06G/4.06G [01:24<00:00, 48.0MB/s]
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
error loading model: unknown (magic, version) combination: 67676363, 0000000a; is this really a GGML file?
llama_load_model_from_file: failed to load model
INFO:     <ip>:56448 - "POST /v1/chat/completions HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 428, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 276, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 227, in app
    solved_result = await solve_dependencies(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/dependencies/utils.py", line 622, in solve_dependencies
    solved = await call(**sub_values)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/get_llm.py", line 44, in get_llm
    return AutoModelForCausalLM.from_pretrained(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/ctransformers/hub.py", line 168, in from_pretrained
    return LLM(
           ^^^^
  File "/usr/local/lib/python3.11/site-packages/ctransformers/llm.py", line 214, in __init__
    raise RuntimeError(
RuntimeError: Failed to create LLM 'llama' from './models/wizardlm-7b-uncensored.ggccv1.q4_0.bin'.

Helm values:
deployment:
  env:
    DEFAULT_MODEL_HG_REPO_ID: TheBloke/WizardLM-Uncensored-Falcon-7B-GGML
    DEFAULT_MODEL_FILE: wizardlm-7b-uncensored.ggccv1.q4_0.bin

Thank you for testing, unfortunately it's because the model file name doesn't contain falcon therefore the naive (silly) detection of model type failed, we can add a way to manually specify the model type via env.

Hi @chenhunghan 👋
Looks like the fix was incomplete, since the MODE_TYPE was not added to the deployment.yaml


[Workers]: Update HTMLRewriter Tutorial

This tutorial was previously written with Workers Sites. With worker-sites deprecated, it's now updated to use Cloudflare Pages.

[x] Migrate tutorial to /pages/tutorials

@lauragift21, yeah, think it'd probably make sense to move over to Pages as you mentioned (and set up a corresponding redirect).

closes #14414


ssh-keys: give linus access

Finish the on-boarding so he can contribute to the project.

Sounds good to me.

I feel like people should make the conscious effort to self-onboard. It is not a big ask.


[Bug]: Airtime balance for safaricom fails 'waiting for safaricom message..'

Description
Airtime balance not update despite requesting it severally
Steps to reproduce

Open stax app
Navigate to Sim tab
Check balance
Wait for update

Expected result
Safaricom airtime balance should update immediately on the app after requesting.
Actual result
Airtime balance not updated. Status shows 'waiting for safaricom message'
Link to screenshots/screen recordings
https://drive.google.com/file/d/1s2jbNajg4AM7pnlQs4Z_uSwk5frv2XNo/view?usp=drivesdk
Device name
Huawei y5 2019
Android OS
9
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
<EMAIL_ADDRESS>

Relates to #733