jackett: 0.17.311 -> 0.17.598

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Jackett/Jackett/releases.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.17.598 with grep in /nix/store/9v2nhmla3fwf2fs41f0fm0myqkizf8lm-jackett-0.17.598

directory tree listing: https://gist.github.com/e0fb97d69e1ccf0fd3a8a09c559a181b

du listing: https://gist.github.com/22ca3fa39596e30b1fe99ec2eff58be6

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9v2nhmla3fwf2fs41f0fm0myqkizf8lm-jackett-0.17.598 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/f35fbf2f793f18f7791aa3f635fad4603d8a0674.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9v2nhmla3fwf2fs41f0fm0myqkizf8lm-jackett-0.17.598
ls -la /nix/store/9v2nhmla3fwf2fs41f0fm0myqkizf8lm-jackett-0.17.598/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Result of nixpkgs-review pr 114662 at f35fbf2f run on aarch64-linux 1

1 package built:

jackett

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/jackett/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/servers/jackett/default.nix:26:5:
   |
26 |     license = licenses.gpl2;
   |     ^


Fixed reference to shared manager in test example code

I copied the code and noticed it didn't work.

The convenience reset on container was added back in May in 2.1. Locked on earlier version?


BackgroundDownloader not working on a headless app

When using BackgroundDownloader on a background/headless UWP running on Windows 10 IoT Core. It just hang on this part:
await download.StartAsync().AsTask(_cts.Token, progressCallback);
The storage file is also 0 byte, but when you stop the app that is the time the file contents are dumped. Funny is that this was working several days ago. But after an Windows Update on Windows 10 IoT Core few days ago it stops working.

What version of the OS was installed with that update?

Hi, Thank You for the reply I am actually writing another post on MS site regarding this matter.
The version of IoT Core was v.10.0.15063.483
I also downloading an insider build to deploy and test the issue on my spare RPI3.
The problem lies on StartAsync method of BackgroundDownloader class. It just stalls forever there. To easily replicate this issue, just download official MS GitHub UWP samples and look for
So basically right now, all our IoT devices is useless because we need to download images from bunch of CCTV/IP Cameras to be send in MS Cognitive service for analysis.
When I mean bunch of cameras, I mean hundreds of them because its a entire village's cameras and tens of RPi's that was running W10 IoT Core.
Someone also posted this issue on StackOverFlow https://stackoverflow.com/questions/45472159/backgrounddownloader-on-windows-10-iot-core-does-not-complete-on-raspberry-pi
Hope it can be resolved as soon as possible. Thank you for the quick response by the way.
P.S: I'm excited for the Microsoft IoT Roadshow!
Michael
From:   David Goll<EMAIL_ADDRESS>To:   Microsoft/Windows-universal-samples<EMAIL_ADDRESS>Cc:   Spawnkid<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent:   8/5/2017 10:47 AM
Subject:   Re: [Microsoft/Windows-universal-samples] BackgroundDownloader not working on a headless app (#711)
What version of the OS was installed with that update?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

One more question about versions. Was this an upgrade from 14393, or one of the monthly updates for 15063?

Hmm.. It was just a monthly update I think. Because one of my cloned/developer board who also having an issue was just formatted and installed by IoT dashboard a few weeks ago (not more than a month) so I assumed that the OS on was latest stable build.

Update: Doesn't work also with v.10.0.16247.1000 Insider Preview build.

Thanks for the info. Since this is a product bug, and not a sample bug, I plan to close this issue and open a new issue in our internal issue database. Before I do that however...

Hi, Thank You for the reply I am actually writing another post on MS site regarding this matter.

Did you write this post? Assuming so, please reply with a link.

https://social.msdn.microsoft.com/Forums/en-US/ce9b7807-0bff-4881-932f-0f16e22f9a01/backgrounddownloader-doesnt-work-anymore-when-running-on-a-headless-app?forum=WindowsIoT

Thanks. I'll look for the Feedback Hub issue (as was suggested in reply to your post). That's the preferred way to report issues because it ties directly into our internal issue database.


Slack message not sent when updating incident status

Describe the bug
Slack message not sent to #dispatch-x channel when updating incident status from Active to Stable. It only happens when we have not yet executed /dispatch-report-tactical command.
To Reproduce
Steps to reproduce the behavior:

Create an incident (admin UI or Slack command)
Update incident status from Active to Stable (admin UI or Slack command)
There is no slack message telling the incident status already changed.

Expected behavior
The slack message should be sent when updating the incident status.
Screenshots

@rilutham are there any errors in the logs that might help us?

@rilutham are there any errors in the logs that might help us?

After having some troubleshooting, it was caused by a missing document with type google-docs-incident-review-document.

After having some troubleshooting, it was caused by a missing document with type google-docs-incident-review-document.

Thanks for following up, I'll add a task to harden incident update so as not to fail if it's missing an incident review document.

Thanks for following up, I'll add a task to harden incident update so as not to fail if it's missing an incident review document.


Some bug reports and suggestions

Rather than continuing step_counter when not finetune, suggests continuing when resume, e.g.: here
Suggest treating step differently in wandb.log --- step has special meaning in wandb.log. See here.
Suggest adding option for turning off saving spectrograms in training/finetuning
BUG: Pretty sure "or" should be "and" here

resume does not automatically mean that we resume a training run. Originally this was the case, but it changed in the past and now the name is misleading. I will think about renaming it in the future. resume means that we load the checkpoint with the highest step count in its filename in the current model directory. It's just a short form of explicitly writing out the most recent checkpoint in the path_to_checkpoint. We can still finetune from this checkpoint that we get when we set the resume flag, in which case the step counter should start from 0. So this should be intended behavior with a misleading name.
Yes, that's why we log "Steps" not "step". This way you can set the x-Axis to "Steps" on the website to see all training runs aligned by their number of updates rather than epochs. Did I log "step" somewhere accidentially? I can't find any case where I log "step".
I'm not sure why you would want to disable this, it's the only way of seeing whether a model has collapsed, since the losses don't indicate this well. Visually inspecting the outputs is pretty important when using probabilistic models such as the normalizing flow postnet, because the loss can go down significantly, but the spectrograms turn into nonsense. Is there maybe another way of changing this? What part about the spectrogram logging is the reason for wanting to disable it?
I think you're right, that looks like a mistake. Thank you!

Thanks for your reply! Here's to continue the discussions:
2. I mean why don't we do wandb.log(log_dict, step=step_counter) rather than having step_counter as one of the data points within log_dict? This means that if we continue a run, we don't start from 0 step again... But perhaps this is related to the fact that you use a different name (in wandb.init) for every run (including the continuation of previous runs). However, my practice is to define project and group only in wandb.init. In this case, runs from the same group are automatically grouped together.
3. It seems to me the codes already run pretty well. So for example, when I finetuned your model on my data, I didn't experience any problems. In general, I don't expect to be modifying your architecture much. Anyway, I guess the bottom line is if the model is already well developed, and the user can expect very little chance of it going awry then they can switch off saving spectrograms. In any case, they would be able to tell if the output audio doesn't sound right.

Regarding 1: finetuning means starting from scratch, but using a previous checkpoint as initialization. So when finetuning, the step counter always starts at 0. If you are finetuning a model and the run crashes and you want to resume this finetuning run, leave out the --finetune the next time you start it, because after the first checkpoint is made, you don't want to start over, but resume from this checkpoint. Only the init before the very first epoch should be made with the --finetune flag.
Regarding 2: Now I understand what you mean. Good point, I will change this.
Regarding 3: I think this is an important safeguard, because since the introduction of the postflow we are dealing with a sensitive stochastic model, that can at any point randomly collapse while its loss is still decreasing.


Can't open the app at all, no pop up no activity in Task Manager

Unable to open the app, there is no pop up and no activity in task manager. Even when trying to open as admin. Tried reinstalling didn't work :/

Unable to open the app, there is no pop up and no activity in task manager. Even when trying to open as admin. Tried reinstalling didn't work :/

You need to install the Runtime. You can install it from the link below or join the Discord where you can find it in #general-help
https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/runtime-desktop-6.0.2-windows-x64-installer

No response from thread starter.


UserWarning: Couldn't import ipywidgets properly, progress bar will use console behavior

/data/private/custom_environment/pointcnn/lib/python3.8/site-packages/fastprogress/fastprogress.py:102: UserWarning: Couldn't import ipywidgets properly, progress bar will use console behavior
warn("Couldn't import ipywidgets properly, progress bar will use console behavior")

NameError                                 Traceback (most recent call last)
/tmp/ipykernel_1885/2333630497.py in
----> 1 export_point_dataset(path,output_path,
2                      block_size = 100.0,
3                      max_points = 8192)
/data/private/custom_environment/pointcnn/lib/python3.8/site-packages/arcgis/learn/init.py in export_point_dataset(data_path, output_path, block_size, max_points, extra_features, **kwargs)
1553
1554     from ._utils.pointcloud_data import  prepare_las_data
-> 1555     prepare_las_data(data_path, block_size, max_points, output_path, extra_features, **kwargs)
1556
1557
/data/private/custom_environment/pointcnn/lib/python3.8/site-packages/arcgis/learn/_utils/pointcloud_data.py in prepare_las_data(root, block_size, max_point_num, output_path, extra_features, grid_size, blocks_per_file, folder_names, segregate, **kwargs)
852
853     folders = [os.path.join(root, folder) for folder in folder_names]  ## Folders are named train and val
--> 854     mb = master_bar(range(len(folders)))
855     for itn in mb:
856         folder = folders[itn]
NameError: name 'master_bar' is not defined

Even though i have  IPython and matplotlib.pyplot

Any fix for this issue?

Was using .ipynb in conda environement, in VScode, had the same issue.
conda install -c anaconda ipywidgets inside my env fixed it.


Initial inline panel forms don't have order field set. Causes crash on form submission

When you have an inline panel with the min_num attribute set, Wagtail will automatically add some blank forms when you create a new page.
These forms don't have their -ORDER set though, this means that if you add additional forms manually and don't alter the order before submitting, Wagtail will crash with the error TypeError: unorderable types: int() < NoneType().

Now getting KeyError: 'ORDER' errors. probably the same issue

I can't replicate this as described. The steps I'm taking are:

Edit wagtaildemo's models.py so that EventIndexPage requires a minimum of 3 related links:
  EventIndexPage.content_panels = [
      FieldPanel('title', classname="full title"),
      FieldPanel('intro', classname="full"),
      InlinePanel('related_links', label="Related links", min_num=3),
  ]

Add a new EventIndexPage

Fill in the page title, intro, and titles for each of the initial related links

Click 'Add related links' and fill in a title for the new related link

Click 'Save' (also tried Publish)

The page then saves successfully.

Closing as unable to replicate

We recently experienced the same type of crash/error multiple times on forms with the min_num attribute set (using v1.13.1), but now I'm unable to replicate the crash. I just wanted to report that the issue still exists.


Invalid path parsing

Start nowin sample browse to
http://localhost:8888/Åsna
The decoded URL will be wrong. /Ãsna see the tilde instead of the ring?

The problem is resolved by
var result = new string(chs, 0, used);
byte[] bytes = Encoding.Default.GetBytes(result);
return Encoding.UTF8.GetString(bytes);
in the ParsePath. Maybe there is a better way to do it, but it seems to fix the problem with UTF-8 escaped paths.

This would be too slow for my taste. Fix/Implementation published in nuget.


Remove invoking grunt:prod on production mode

Hi all.
It's more a question to community.
May be we could remove invoking grunt when running sails in production mode and run grunt commands manually ?
Problem for me is this:
I'm using sails.js v0.10.5 in production on live website.And using CI service.
Also my application has lot of jade, js and css files for frontend.
So when I need to restart my app or make a small change into sources it it compiles all this resources every time even if I don't need it.
For my installation I made a hook and disabled grunt for production.
But might be it will be a good way to for this for others ?
What do you think ?

@konstantinzolotarev or @m-bodmer are either of you interested in submitting this as a PR?

@jdcauley DO we really need it ? Because as I see from conversation and PR comments we could disable it using .sailsrc file like this:
{
  "hooks": {
    "grunt": false
  },
  "paths": {
    "public": "assets"
  }
}

@konstantinzolotarev if you're happy I'm happy


Support systems that take references as input

Objective

Fixes #14924
Closes #9584

Solution

We introduce a new trait, SystemInput, that serves as a type function from the 'static form of the input, to its lifetime'd version, similarly to SystemParam or WorldQuery.
System functions now take the lifetime'd wrapped version, SystemInput::Param<'_>, which prevents the issue presented in #14924 (i.e. InRef<T>).
Functions for running systems now take the lifetime'd unwrapped version, SystemInput::Inner<'_> (i.e. &T).
Due to the above change, system piping had to be re-implemented as a standalone type, rather than CombinatorSystem as it was previously.
Removes the Trigger<'static, E, B> transmute in observer runner code.

Testing

All current tests pass.
Added additional tests and doc-tests.

Showcase
let mut world = World::new();

let mut value = 2;

// Currently possible:
fn square(In(input): In<usize>) -> usize {
    input * input
}
value = world.run_system_once_with(value, square);

// Now possible:
fn square_mut(InMut(input): InMut<usize>) {
    *input *= *input;
}
world.run_system_once_with(&mut value, square_mut);

// Or:
fn square_ref(InRef(input): InRef<usize>) -> usize {
    *input * *input
}
value = world.run_system_once_with(&value, square_ref);

Migration Guide

All current explicit usages of the following types must be changed in the way specified:

SystemId<I, O> to SystemId<In<I>, O>
System<In = T> to System<In = In<T>>
IntoSystem<I, O, M> to IntoSystem<In<I>, O, M>
Condition<M, T> to Condition<M, In<T>>

In<Trigger<E, B>> is no longer a valid input parameter type. Use Trigger<E, B> directly, instead.

I'd personally rather InMut<Foo> be named InRefMut<Foo> to match Rust's ref foo and ref mut foo syntax.

I'd personally rather InMut<Foo> be named InRefMut<Foo> to match Rust's ref foo and ref mut foo syntax.

But it doesn't match how bevy names things:

Ref/Mut
Ptr/PtrMut
Res/ResMut

Makes sense, nvm then.

Do we need SystemInput::unwrap method? It seems only wrap is needed.

Do we need SystemInput::unwrap method? It seems only wrap is needed.

It's not currently used anywhere but might prove useful in the future.

Do we need SystemInput::unwrap method? It seems only wrap is needed.

I asked because:
Currently it creates an artificial limitation than SystemInput::Inner has to be able to converted back to SystemInput. It will prevent us from implementing SystemInput for some weird objects, which only makes sense to convert in one way but not back.
Anyway It's generally better to keep Trait methods minimal.

It's not currently used anywhere but might prove useful in the future.

Okay. Though I feel it would have been better to add it later when needed. Also thanks, for the work.

My guess is that unwrap was needed in an earlier iteration but the code that was using it has been removed/changed.

@ItsDoot sorry, merge conflicts ahead with the run_system_cached PR. That one's older so it takes priority. You'll need to fix those later today; ping me when they're done.

@alice-i-cecile Should be good to go as long as this addition is correct: https://github.com/bevyengine/bevy/pull/15184/commits/c08d85382b47c3dcd3b0d5cf35e5ecc5673279a4 (from #15276)

Yep, that validation is correct. Thanks!

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to https://github.com/bevyengine/bevy-website/issues/1695 if you'd like to help out.


Submenu offset

Fix #150 by adding main_offset and cross_offset
main_offset moves all the menus in the vertical open direction
cross_offset moves each menu in the horizontal open direction
Before

After (main_offset = 13,  cross_offset = 16)

Is the naming ok? main and cross were borrow from flex::Axis, they sound kinda obscure, but I can't think of better ones, vertical and horizontal is a bit misleading, "moving all" and "moving each (relative to their parents)" is different

Honestly, I don't even know what "submenu offset" means lol, it's random name came to my mind

I think it is fine as long as documentation describes what they are for.

Can this be merged now? Do you think the docs aren't detailed enough or are there other problems I should look at?

Can this be merged now? Do you think the docs aren't detailed enough or are there other problems I should look at?

I was waiting for you to tell me it was ready. XD

@latidoremi
Thanks a lot for your implementation!
Just a question, if I reduce main_offset and cross-offset to 0, I will get a one-after-another (for vertical menus) and side-by-side (for horizontal menus) behavior, right? Or will a minimal amount of offset always be present?

try to see what occurs i guess.

If you set both to 0, you'll get exactly what it looks like before. The default background_expand is [6;4], so you need to set main_offset=6, cross_offset=12 to get the one-after-another behavior
In a more general case when background_expand=[top, right, bottom, left], you need to set main_offset=top or bottom, cross_offset=2*(right or left), you won't get the one-after-another behavior if either top!=bottom or right!=left

Thanks a lot @latidoremi for your explanation!
Can we add this information in a README.md into this directory? In this way, anyone can consult it anytime

Good idea, I should probably explain all the other parameters as well, I'll do it asap


True tile rendering?

Is your feature request related to a problem? Please describe.
I have true tiles enabled and while playing I noticed most of the time I look at the tile markers and not the models.
And then I wondered if it would be feasible to just render the models on their true tiles.
It would deftly make the game feel more responsive.
Describe the solution you'd like
Would it be feasible to render models on their true tile?
Describe alternatives you've considered
Is it possible to do this without breaking animations?
Can this be applied to more than just the player model?
Additional context
Currently when moving the player they lag behind their true tile.
This will result in the player "chasing" their true location.
I think this is caused by a delay before starting the move animation.
I think I'd be really cool if we could make these be more in-sync.

I looked at this a while back, moving the actual player is not a good idea as people are used to how it is. Another issue with moving the player is maybe Projectiles and other things would have to be moved also and could be confusing when bossing. I did look into showing maybe a ghost version of your player on the actual tile but, it was kinda confusing to play with

I suppose this would have to be implemented fairly low-level so that projectiles, 2d graphics (hit splats, overheads, etc.) all take this change into account. Even then I think it'll a experimental feature at most.
However, you could also argue that Jagex's own implementation isn't accurate either. Especially if you consider animation stalls.

This is rlly outside the scope of this plugin, While what you suggest could be done it would just confuse people, and would have to do a lot of work as I outlined above, Sorry


Items wind up in hand after sorting a container on a server.

This only occurs with enchanted items for me.
Running Paper 1.16.5 and Forge 36.0.42

And If i keep sorting, the game sometimes crashed


New transforms

WIP
Starts by reorganizing transforms.
Does not atm contain the rewrite of spatial transforms, but does contain new color transforms.

[x] Add parameterized homography with sane defaults as replacement for all spatial transforms
[ ] Maybe: allow creating non-random transforms?
[ ] decide on arguments for color transforms (e.g. saturation needs to allow asymmetric distribution if we want it to have an effect in expectation)
[ ] Add benchmark confirming homographic projection is faster than old standard transforms

Pull Request Test Coverage Report for Build 309

90 of 169 (53.25%)  changed or added relevant lines in 6 files are covered.
8 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.7%) to 71.679%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lucid/optvis/transform/spatial.py
38
39
97.44%

lucid/optvis/transform/init.py
10
16
62.5%

lucid/optvis/transform/gradient.py
3
16
18.75%

lucid/optvis/transform/color.py
9
68
13.24%

Files with Coverage Reduction
New Missed Lines
%

lucid/modelzoo/other_models/init.py
2
100.0%

lucid/modelzoo/slim_models/init.py
2
100.0%

lucid/modelzoo/vision_models.py
2
100.0%

lucid/modelzoo/caffe_models/init.py
2
100.0%

Totals

Change from base Build 305:
-0.7%

Covered Lines:
1430

Relevant Lines:
1995

💛  - Coveralls

Thank you again for help and attention, @ckamm! :-) Unfortunately it looks like this PR isn't happening. I will leave the branch up, though, in case anyone wants to take this up again in the future.


Use rules_cc to try to clean up CI runs which are failing on gcc

This does not fix all the problems, but it does fix one example. I want to merge in spite of CI not being clean.
The other CI failures look like repository caching problems.


Subselect in WHERE clause doesn't work

At @jdegoes's direction, closed SlamData Issue #1048 and reopening here.  Initial summary below:

The following query:
SELECT * FROM `/devguide/devdb/patients` AS p
WHERE state IN (SELECT state FROM `/devguide/devdb/states`)

gives the error:
An unknown error ocurred: 500 "{ \"error\": { \"status\": \"Unsupported function.\",
\"detail\":{ \"message\": \"The function 'WHERE' is recognized but not supported
by this back-end. (in JS planner)\", \"functionName\": \"WHERE\", \"logicalPlan\": {
....

Current usable workaround provided by @sellout:
SELECT p.* FROM `/devguide/devdb/patients` AS p
INNER JOIN `/devguide/devdb/states` AS s
ON p.state = s.state

Maybe this just goes away with the new Mongo Connector - so we just need to check that !

I spoke with @sellout today about this error and after some effort to reproduce we realized the following:

In old mongo we are now seeing this error:

💪 $ SELECT * FROM `/mongo/test/patients10` AS p WHERE state IN (SELECT state FROM `/mongo/test/zips`)
Quasar error: Plan execution failed: MongoDB Error: Command failed with error 16722: 'exception: TypeError: Object [object Object] has no method 'indexOf'
    at _funcs1 (_funcs1:1:44) near '!== this.indexOf(thi' ' on server <IP_ADDRESS>:27019. The full response is { "errmsg" : "exception: TypeError: Object [object Object] has no method 'indexOf'\n    at _funcs1 (_funcs1:1:44) near '!== this.indexOf(thi' ", "code" : 16722, "ok" : 0.0 }, cause=Some(Command failed with error 16722: 'exception: TypeError: Object [object Object] has no method 'indexOf'
    at _funcs1 (_funcs1:1:44) near '!== this.indexOf(thi' ' on server <IP_ADDRESS>:27019. The full response is { "errmsg" : "exception: TypeError: Object [object Object] has no method 'indexOf'\n    at _funcs1 (_funcs1:1:44) near '!== this.indexOf(thi' ", "code" : 16722, "ok" : 0.0 })

this error is actually further along in the execution process than what @damonLL reports. So something has been fixed since the issue was created that pushes Damon's query along a little further. In this case the error above comes from mongo whereas Damon's error comes from the LogicalPlanner.

In new mongo we get an entirely different error:

💪 $ SELECT * FROM `/mongoq/test/patients10` AS p WHERE state IN (SELECT state FROM `/mongoq/test/zips`)
Quasar error: couldn’t merge array

which upon further inspection using debug=2 shows some multi EquiJoins:
QScript (Mongo-specific):
Map
├─ Subset(Take)
│  ├─ Unreferenced
│  ├─ From
│  │  ╰─ Filter
│  │     ├─ EquiJoin
│  │     │  ├─ Unreferenced
│  │     │  ├─ ShiftedRead(ShiftedRead(/test/patients10, IncludeId))
│  │     │  ├─ EquiJoin
│  │     │  │  ├─ Unreferenced
│  │     │  │  ├─ Map
...

It is likely that once #1943 and #1929 are complete this error may be fixed in new mongo.
I suggest that we re-evaluate this ticket once the two tickets above are resolved. If we still bump into this error then we can continue debugging using the queries posted in this comment and by Damon.
@zeeiyerWork, maybe we punt this issue out to a future milestone after the two issues above are completed? Let me know if that's ok with you.

Agreed that any join-related qscript issues should be re-evaluated after #1943 (new LP joins) and #1929 (qscript provenance issue) land.

@nicflores -> @sellout advises to try this again.
#1943  is fixed.

Running the above query in the new-mongo branch I'm now seeing a similar error that Doug reports in #2466.
query:
💪 $ SELECT * FROM `/mongo/testdata/patients.data` AS p WHERE state IN (SELECT state FROM `/mongo/testdata/zips`)

Quasar error: Plan execution failed: MongoDB Error: Command failed with error 13070: 'exception: value too large to reduce' on server <IP_ADDRESS>:27019. The full response is { "errmsg" : "exception: value too large to reduce", "code" : 13070, "ok" : 0.0 }, cause=Some(Command failed with error 13070: 'exception: value too large to reduce' on server <IP_ADDRESS>:27019.  (See it/src/main/resources/tests/couchbase/ for examples of joins that will work in couchbase.)
Both marklogic and spark have standard joins implemented, so it would be useful to see what happens in those two backends. For large (and even not very large) datasets marklogic joins are not very performant so to get a result in marklogic you'll probably need to use a small dataset.

Thanks @alissapajer for that info. I'm about to run the same query in Marklogic to see what happens there.

Sounds good. Also when you paste further results feel free to omit the qscript. It will be similar for all backends, and the ticket will be easier to read through if we don't have those large trees.

Ah, yeah – Couchbase and joins don’t really mix (yet). Marklogic is probably a good bet, though.
I see that the both joins are crosses. And that probably explains the Mongo error – as, in Mongo, a cross is handled by turning each collection into a single array, then $unwinding each of them. So you’re turning all of both collections into one document, and that’s probably what “value too large to reduce” is complaining about.
I would like the QScript to look like
EquiJoin(
  Unreferenced(),
  ShiftedRead("/mongo/testdata/patients.data", ExcludeId)
  Reduce(
    Map(
      ShiftedRead("/mongo/testdata/zips", ExcludeId)
      ProjectField(Hole, "state")),
    List(Hole),
    Nil,                 // although this probably will be `List(Arbitrary(Hole))`
    ReduceIndex(0.left)) // and this will be `0.right`
  List((ProjectField(Hole, "state"), Hole)),
  Inner,
  LeftSide)

I wrote that from the original query, but my common workaround when users have a problem like this is to tell them to make the join explicit, like
select p.*
  from `/mongo/testdata/patients.data` as p
  join (select distinct state from `/mongo/testdata/zips`) z
  on p.state = z.state

which matches the QScript I’ve written. Note that for the explicit join approach to work that distinct needs to be added.
I feel like the conversion of in to within() is maybe getting in the way – that’s what triggers the UnshiftArray reduction. But I don’t know if that’s what’s causing the query failure – just that it’s making the QScript more complicated than it could be.

Finally got the query to work on marklogic. I had to significantly reduce the size of the patients and the zips file:
 [366] → cat zips | wc -l
      83
 [367] → cat patients.data | wc -l
     111

@nicflores to confirm, is the query returning correct results on marklogic?

The ML query was successful, I didn't verify the result to make sure it was correct.

It is likely that some of QScript work that @wemrysi and @alissapajer are doing will resolve this issue. Specifically we are looking to remove the extra EquiJoin we are seeing in the QScript output.

Running the equivalent version of the query mentioned above by @sellout we get a different error:
💪 $ select p.* from `/mongo32/local/patients` as p join (select distinct state from `/mongo32/local/zips`) as z on p.state = z.state

Quasar error: Plan execution failed: MongoDB Error: Command failed with error 139: 'TypeError: value[0] is undefined :
@:5:49
@:5:1
@:4:1
' on server <IP_ADDRESS>:27021. The full response is { "ok" : 0.0, "errmsg" : "TypeError: value[0] is undefined :\n@:5:49\n@:5:1\n@:4:1\n", "code" : 139 }, cause=Some(Command failed with error 139: 'TypeError: value[0] is undefined :
@:5:49
@:5:1
@:4:1
' on server <IP_ADDRESS>:27021. The full response is { "ok" : 0.0, "errmsg" : "TypeError: value[0] is undefined :\n@:5:49\n@:5:1\n@:4:1\n", "code" : 139 })

I ran the query
SELECT * FROM patients AS p where state in (SELECT state FROM zips)

against PR #2902 and it gives the error
Quasar error: Plan execution failed: MongoDB Error: Command failed with error 13070: 'value too large to reduce'

So this will crash mimir as well.  It's just a really bad query because of how IN has to work.  I'm relatively certain the following constitutes a valid workaround:
SELECT * FROM patients AS p where state in (SELECT DISTINCT state FROM zips)

@alissapajer Is this one rightfully skulled? Qsu doesn’t really fix this, because at the end of the day, the problem stems from the user asking us to page a very large dataset into memory. If this sort of thing is really really important, then we could hard code some behavior in the case that IN is applied to a subselect, but ultimately what the user is requesting here is just not evaluable in general.

@djspiewak since the originally reported bug has been fixed, and we have a workaround to avoid paging the entire dataset into memory, I think we can unskull this.
Let's write a couple integration tests for
SELECT * FROM patients AS p where state in (SELECT state FROM extraSmallZips)

and
SELECT * FROM patients AS p where state in (SELECT DISTINCT state FROM zips)

and then close this issue.

Actually, we do want both those above queries to work, so I'm going to add the skull back, knowing that this issue will be closed when we write those two tests. If those two tests don't pass for other reasons, then we'll open new issues for them.

Both of these queries work now.  I'll create integration tests.

@djspiewak last time I checked this, in the version without distinct we were getting multiple rows returned per state, which is incorrect. The integration tests you added don't check for this property. Can you see if this is still happening?

Actually, because of the order by in the integration test, I think you are testing this property implicitly.

@alissapajer Multiple rows per state is correct.  What we don't want is rows to get duplicated because of the join.  A quick check of count(*) with and without the distinct, things appear to be fine.

Oh yeah, and I guess the order by does check that.  :-)

@djspiewak I may have not understood the in operator correctly. Does it not treat the values that follow it as a set, thus implicitly distincting them?

I think we are on the same page now, actually. There can be multiple rows per state returned, but we don't want them duplicated, as you said above.


TrollStore and Dopamine can not open

TrollStore and Dopamine can not open
But other app can.
Updated to 1.1.1
It's like this after waking up
https://github.com/opa334/Dopamine/assets/131627176/6cd602ee-942b-4237-8a3d-7cb4b5e7c2f7

This is a known issue related to TrollStore.

The CoreTrust bug used in TrollStore is only capable of installing "System" apps. This is because FrontBoard has an additional security check (it calls libmis) that runs every time before launching a user app. Unfortunately, it is not possible to install new "System" apps that persist through an icon cache reload. As a result, when iOS reloads the icon cache, all apps installed through TrollStore, including TrollStore itself, will revert back to the "User" state and will no longer launch.

To resolve this issue, you need to open GTA Car Tracker or use the Persistence Helper installed via TrollStore to re-register the relevant apps as System apps.

But Filza is also installed by TrollStore.
And Filza can run.
NewTerm is installed by Sileo.

But Filza is also installed by TrollStore. And Filza can run. NewTerm is installed by Sileo.

To be honest, I'm somewhat skeptical. It seems unlikely from a technical standpoint. If you are convinced that this is a problem worth investigating, providing more information would be helpful. However, this discussion should be directed to the issue tracker of TrollStore rather than Dopamine.
Moreover, it is more important to address the problem you are currently facing. So, did refreshing the app's system state resolve the issue for you?

Yes, Reinstall TrollStore and Dopamine fix this issue.
But I'm telling the truth.
Close the issue now and I'll report more when it happens again.

Hope not to see it happens again :)


Introduce ownership_timeout

Closes #22.
The fix is not quite the same as suggested by #22. We don't want the pool to timeout the connection and disconnect it but the owner process to continue handing out the dead connection with divergent state from the pool. Therefore we pass timeout: :infinity to the pool and do a timeout in the owner process. This will allow people to set ownership_timeout: :infinity to play with sandboxes in dev/shell.

@ericmj can you check the hex error on the failed test here? I assume this is a http timeout?

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

@fishcakez It is timing out, probably when loading the ETS table from a file. I will increase the timeout.


Created a design doc and base structure for the Library #1

Greeting @kiranharidas187
I have created base structure for the library having 3 components(login, signup and forgotpassword) also added routing to it.
It closed the issue #1

closed due to wrong mode


Should CMSPageRenderer support rendering non CMS templates?

Is the CMSPageRenderer meant to support only rendering of CMS pages via apphooks?
I have a case where using apphooks to set the urls is optional. So for example you could attach an apphook of CatalogListApp to a page, or include the catalog urls manually. In which case I get an error: 'NoneType' object has no attribute 'publisher_is_draft' because request.current_page is None.
By checking for current page before setting edit mode enables this:
if request.current_page:
    # set edit_mode, so that otherwise invisible placeholders can be edited inline
    template_context['edit_mode'] = request.current_page.publisher_is_draft

Yes, the CMSPageRenderer assumes an apphook attached to a django-cms page. Can you solve your problem by using a custom renderer?

@rfleschenberg Yes, I have created a modified renderer to support this.


Update dependencies

Update dependencies
Description

Updates the base dependencies across patch and minor version changes (including a rename of go-jose which was moved to a different package name)
Updates go-jose to v4
Updates the rapid package and the associated tests to v1

The motivation is that some of the underlying dependencies are very out of date notably including go-jose which has been archived and is two major versions behind. If dropping the testing changes associated with updating rapid is desirable that's IMO totally acceptable.
I'd also appreciate if this package could be tagged after merging
How Has This Been Tested?
So far only unit tests in this repo. I'm happy to test by bubbling up to kubo as well, but I suspect the test coverage here will handle most of the work.
Definition of Done
Before submitting this PR, please make sure:

[x] The work addresses the description and outcomes in the issue
~[ ] I have added relevant tests for new or updated functionality~
[x] My code follows conventions, is well commented, and easy to understand
[x] My code builds and tests pass without any errors or warnings
[x] I have tagged the relevant reviewers
~[ ] I have updated the READMEs of affected packages~
~[ ] I have made corresponding changes to the documentation~
[x] The changes have been communicated to interested parties

This PR serves as the notification, if there's anything else I should do let me know

References:
Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

Probably most relevant is the go-jose release notes https://github.com/go-jose/go-jose/releases particularly for v4

cc @smrz2001 @warpfork, but maybe someone else is better to review here


ChartApplier now takes interface{} as value

What this PR does / why we need it:
Reworked various parts of the public interface of ChartApplier to make it more composable. Extra methods With... are now removed and customization can be applied with implementing ApplyOption andDeleteOption interfaces.
Both Delete and Apply now can use interface{} instead of map[string]interface{} as values. With this change is now possible to pass a predefined struct such as
type Foo struct {
	Baz string `json:"baz,omitempty"`
	Foo bool `json:"foo,omitempty"`
}

to it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This entire change is also needed so we can start testing individual components e.g. for the DNS provider deployment/deletion
type DNSProvider struct {
	Values         DNSProviderValues
	ShootNamespace string
	*kubernetes.ChartApplier
}

type DNSProviderValues struct {
	Name       string            `json:"name,omitempty"`
	Purpose    string            `json:"purpose,omitempty"`
	Provider   string            `json:"provider,omitempty"`
	SecretData map[string][]byte `json:"secretData,omitempty"`
	Domains    IncludeExclude    `json:"domains,omitempty"`
	Zones      IncludeExclude    `json:"zones,omitempty"`
}
type IncludeExclude struct {
	Include []string `json:"include,omitempty"`
	Exclude []string `json:"exclude,omitempty"`
}

func (d *DNSProvider) Deploy(ctx context.Context) error {
	if err := d.Apply(ctx, filepath.Join(dnsChartPath, "provider"), d.Values.Name, kubernetes.Values(d.Values)); err != nil {
		return err
	}

	return waiter() // TODO...
}

With this, botanist can construct the DNSProvider when it starts working on a Shoot.
Release note:

NONE

bump @gardener/gardener-maintainers

PR updated with rename DefaultApplierOptions -> DefaultMergeFuncs

rebased the PR to fix the merge conflicts

fixed nit in ceb2aed69f54e6ab1bf8be1a12c23f6e1c837072

Can you rebase again?


redocly: 1.25.11 -> 1.26.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/redocly/versions.
meta.description for redocly is: Makes OpenAPI easy. Lint/validate to any standard, generate beautiful docs, and more
meta.homepage for redocly is: https://github.com/Redocly/redocly-cli
meta.changelog for redocly is: https://redocly.com/docs/cli/changelog/
Updates performed

NPM version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.26.0 with grep in /nix/store/gmzv9mkcq5g8j729d75iqaz0makxhcxk-redocly-1.26.0
found 1.26.0 in filename of file in /nix/store/gmzv9mkcq5g8j729d75iqaz0makxhcxk-redocly-1.26.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

redocly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gmzv9mkcq5g8j729d75iqaz0makxhcxk-redocly-1.26.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A redocly https://github.com/r-ryantm/nixpkgs/archive/0ef1b4172ae75f15ed25483c35416a40dae57fcd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0ef1b4172ae75f15ed25483c35416a40dae57fcd#redocly

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gmzv9mkcq5g8j729d75iqaz0makxhcxk-redocly-1.26.0
ls -la /nix/store/gmzv9mkcq5g8j729d75iqaz0makxhcxk-redocly-1.26.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

redocly

Maintainer pings
cc @szlend for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

1 package built:
redocly
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365672

aarch64-darwin

:white_check_mark: 1 package built:

redocly


translation of short month

the short version of the dutch version of March is incorrect, it has been fixed in this pull request

According to http://web.library.yale.edu/cataloging/months.htm and opthers it should be maart

maart is the full name of the month, for 3 letter abbreviations mrt is advised by this website:
http://taaladvies.net/taal/advies/vraag/1727/afkortingen_van_de_namen_van_de_maanden/
That website is ran by the official Dutch Language Union (https://en.wikipedia.org/wiki/Dutch_Language_Union), you can verify that in their footer.

Ok, thanks for the info.


Add missing tags to instance_profile

Tags are missing on instance_profile resource.
This MR for adding it.

/test all

/test all

@Gowiem security group 4.x is still blocking here. i've set the release to pre-release.


[SPARK-35931][CORE][YARN] Ability to override Yarn Cluster Submit Class with Configuration

What changes were proposed in this pull request?

This PR allows to add a custom implementation of YARN_CLUSTER_SUBMIT_CLASS as a configuration.
This is useful when there is a custom variant of Yarn cluster running which requires a modified Yarn client.
Users can implement a class similar to YarnClusterApplication which can invoke a custom Yarn client. Users should add the relevant dependencies in the classpath.
Default value of the configuration is set to the current class: org.apache.spark.deploy.yarn.YarnClusterApplication.

Why are the changes needed?
This is required when there is a custom variant of Yarn cluster running which requires a modified Yarn client. For example, there may be different handling of credentials required in a custom Yarn cluster.
Does this PR introduce any user-facing change?
Yes, this PR introduces a new configuration key but the behaviour is unchanged without explicitly modifying the config. Documentation is added for the new configuration.
How was this patch tested?
Tested following in a local Yarn cluster:
Tested without the config added - Existing client is used to submit application
Tested with config added - New client is used to submit application
Tested with config added but class not present - Spark-submit throws error:  Could not load YARN classes.
Unit tests:
Added unit tests when the configuration is enabled.
Existing unit tests which validate the current YarnClusterApplication class name are passing.

Can one of the admins verify this patch?

@srowen @HyukjinKwon @tgravescs Could you kindly help in reviewing this PR?

I just don't know enough about YARN to review this one --

I'm pretty hesitant about this without more information.  I do not want yet another plugin place that we have to maintain and is a one off use.  These are all internal Spark classes as well, so making a config for it without some public or developer interface doesn't make a lot of sense.  cc @mridulm  as well
Can you give more details about exactly what requires changing here?

there may be significant (non-generic) changes required in Yarn client

If its a different yarn Client, if its way different it should just be a separate resource manager perhaps. If its something smaller (which it doesn't sound like from the description) perhaps something else needs to be more flexible.

Thanks @tgravescs for looking into this. Please find my responses below.

Can you give more details about exactly what requires changing here?

We have a custom implementation of setting up tokens for Yarn applications. This involves invoking some native libraries to generate different kinds of tokens and these needs to be set in AM Container launch context. Similarly, there are some changes required in Yarn configuration for running on multi-tenant Federated Yarn cluster. For this purpose, we are adding a new client similar to yarn/Client.scala along with a bunch of helper utility classes related to token handling.

If its a different yarn Client, if its way different it should just be a separate resource manager perhaps. If its something smaller (which it doesn't sound like from the description) perhaps something else needs to be more flexible.

We are adding a new folder under /resource-managers/yarn such as /resource-managers/yarn/customyarn. This way it can leverage all existing internal classes and we can add custom implementation for Client in this new folder along with other utilities.

Another question - the ApplicationMaster doesn't need modified as well?

ApplicationMaster does not change since only changes required are in how application submission is done.

These are all internal Spark classes as well, so making a config for it without some public or developer interface doesn't make a lot of sense.

Will it be a good idea to make the fields in Client.scala to make protected to allow developers to extend the Client? Currently, it can not be extended since many methods are private.

We have a custom implementation of setting up tokens for Yarn applications. This involves invoking some native libraries to generate different kinds of tokens and these needs to be set in AM Container launch context.

Can you just implement your own HadoopDelegationTokenProvider to gets tokens for you?  We use service loader to find any user defined ones (https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala#L260)

Yarn configuration for running on multi-tenant Federated Yarn cluster.

you can point spark to any set of Hadoop/yarn configuration files or pass them in, is there something special about these?  Otherwise I would have expected your normal HADOOP_CONF_DIR to point to yarn specific configs.
Just for reference since talking about different cluster managers, not sure what is going to happen to this pr but mention it here -> https://github.com/apache/spark/pull/31896


Add CONTRIBUTORS file

Add CONTRIBUTORS file
This PR is created automatically by Matks PrestaShop Repositories Bulk Editor

CONTRIBUTORS file not sorted alphabetically


pod goes to CrashLoopBackOff state (switching to "cassandra": operation not permitted) while creating CassandraDatacenter with non root user

oc version:
Client Version: 4.6.0-202101301510.p0-18d7461
Server Version: 4.6.16
Kubernetes Version: v1.19.0+e49167a
I am running entire steps with non-root user with admin access
cass-operator is up and running:
NAME                             READY   STATUS    RESTARTS   AGE
cass-operator-5996fbb889-59ftb   1/1     Running   0          17h

when i try to create CassandraDatacenter, its pods goes into CrashLoopBackOff state
kubectl logs -f cluster1-dc1-default-sts-0 cassandra
Starting Management API
Running java -Xms128m -Xmx128m -jar /opt/mgmtapi/datastax-mgmtapi-server-0.1.0-SNAPSHOT.jar --cassandra-socket /tmp/cassandra.sock --host tcp://<IP_ADDRESS>:8080 --host file:///tmp/oss-mgmt.sock --explicit-start true --cassandra-home /var/lib/cassandra/
error: failed switching to "cassandra": operation not permitted

I am using example-cassdc-minimal.yaml and only change done is storageClassName to rook-cephfs
below is the file
cat example-cassdc-minimal.yaml
# Sized to work on 3 k8s workers nodes with 1 core / 4 GB RAM
# See neighboring example-cassdc-full.yaml for docs for each parameter
apiVersion: cassandra.datastax.com/v1beta1
kind: CassandraDatacenter
metadata:
  name: dc1
spec:
  clusterName: cluster1
  serverType: cassandra
  serverVersion: "3.11.7"
  managementApiAuth:
    insecure: {}
  size: 3
  storageConfig:
    cassandraDataVolumeClaimSpec:
      storageClassName: rook-cephfs
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 5Gi
  config:
    cassandra-yaml:
      authenticator: org.apache.cassandra.auth.PasswordAuthenticator
      authorizer: org.apache.cassandra.auth.CassandraAuthorizer
      role_manager: org.apache.cassandra.auth.CassandraRoleManager
    jvm-options:
      initial_heap_size: "800M"
      max_heap_size: "800M"
      additional-jvm-opts:
        # As the database comes up for the first time, set system keyspaces to RF=3
        - "-Ddse.system_distributed_replication_dc_names=dc1"
        - "-Ddse.system_distributed_replication_per_dc=3"

I even tried the following:
Granted "privileged" SCC to "deployer"  and "cass-operator" service account in a cass-operator project and "vdemo" nonroot user in the cluster scope.
verified RoleBinding and ClusterRoleBinding which is related with "privileged" scc for "deployer" and "cass-operator" service account and "vdemo" nonroot user, we can see the SCC is managed by RBAC
oc adm policy add-scc-to-user privileged vdemo
clusterrole.rbac.authorization.k8s.io/system:openshift:scc:privileged added: "vdemo"
oc get rolebinding system:openshift:scc:privileged -n cass-operator -o json | jq '.subjects'
[ { "kind": "ServiceAccount", "name": "cass-operator", "namespace": "cass-operator" }, { "kind": "ServiceAccount", "name": "deployer", "namespace": "cass-operator" } ]
oc get clusterrolebinding system:openshift:scc:privileged
NAME ROLE AGE
system:openshift:scc:privileged ClusterRole/system:openshift:scc:privileged 21h

oc get clusterrolebinding system:openshift:scc:privileged -o json | jq '.subjects'
[ { "kind": "ServiceAccount", "name": "cass-operator", "namespace": "cass-operator" }, { "kind": "ServiceAccount", "name": "deployer", "namespace": "cass-operator" }, { "apiGroup": "rbac.authorization.k8s.io", "kind": "User", "name": "vdemo" } ]

Hi @dasuresh
The default 3.11.7 image is not built to run as a non-root user. Take a look at the images listed here. These are all built to be run with non-root user.
Note that you will also need to set dockerImageRunsAsCassandra: true in your spec.

Thanks @jsanda, set dockerImageRunsAsCassandra to true and also used the recommended image in statefulset and all the pods for datacenter are now created and running fine.
Thanks for yours help !


Bump VERSION to 0.0.2.

Sets a minimal baseline version for IDEs to verify a hot-reload supporting SDK.
Fixes: https://github.com/flutter/flutter-intellij/issues/293
/cc @abarth
FYI @danrubel


PDF does not render in expander in Safari

Wave SDK Version, OS

Wave 1.0.0+
Safari (Chrome works as expected)

Actual behavior

When a PDF is in an expander with a ui.text or ui.markup object, if you open and close the expander, the PDF will no longer render

Safari on left, chrome on right. Pic one is visiting the app, pic two is closing and opening the expander

Steps To Reproduce
from h2o_wave import main, app, Q, ui

@app('/')
async def serve(q: Q):

    q.page["meta"] = ui.meta_card(
        box="",
        layouts=[
            ui.layout(
                breakpoint="xs",
                height="100vh",
                zones=[
                    ui.zone("main", direction="row", size="1"), # size=1 to take up all the space on the screen
                ]
            )
        ]
    )

    q.page["pdf_from_public_website"] = ui.form_card(
        box="main",
        items=[
            ui.expander(name="test", items=[
                ui.markup(
                    content="<object data='https://arxiv.org/pdf/2401.16818.pdf' "
                            "type='application/pdf' width='100%' height='1000px'></object>")
            ])
        ]
    )

    await q.page.save()

Seems like Safari has some weird bug (probably related to caching?) when switching between display: 'none' and display: 'block' CSS props for ancestor elements of <object> tags containing pdf files.
You can use <iframe> instead:
ui.markup(
   content='<iframe src="https://arxiv.org/pdf/2401.16818.pdf" style="width: 100%;height: 1000px; border: none;"></iframe>'
)

@mturoci, there is also the option to use height: 0, width: 0, visibility: 'hidden' instead of display: 'none', but this solution would load pdfs even if the user never opens the expander.
The question is whether we are going to implement a new ui.document component OR a docs section suggesting the use of iframe for pdfs would be enough.
Either of the solutions would target both #2291 and #2292.

Would something like this work?
q.page['example'] = ui.form_card(box='1 1 4 4', items=[
    ui.frame(path='<pdf_path>')
])

It would, but when inside expander, the first page appears blank in Safari until scrolled:
https://github.com/h2oai/wave/assets/23740173/37afa6df-6e44-4e07-91b4-478488f5d743
  q.page["example"] = ui.form_card(
      box="1 1 8 8",
      items=[
          ui.expander(name="test", items=[
              ui.frame(path='<pdf_path>', height='1200px', width='100%')
          ])
      ]
  )


Windows CLI is gone

Summary
What do you want to know about this project?
What happened to the Windows CLI app?
Motivation
Why do you need to know this, any examples or use cases you could include?
I have been going through some due diligence to test/adopt this project at T-Mobile, but right before we were about to deploy, the Windows CLI downloads seemed to disappear.  This could potentially be a dealbreaker. If support for testing a Windows CLI is necessary, we may be able to assist.

The windows CLI is available in our latest release page:
https://github.com/argoproj/argo/releases/tag/v2.9.2
https://github.com/argoproj/argo/releases/download/v2.9.2/argo-windows-amd64
Am I missing something?

Sorry, forgive me, I'm not sure what I was thinking.


crash switching from basic to advanced Eq

Disclaimer:
Please go through existing issues to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[X] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
The app crashes when trying to switch from basic equalizer to advanced equalizer,
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Go to front page at startup of the app
Click on the arrow next to "basic equalizer"
See error

Expected behaviour
the app not to crash
Setup information:

Audio device used for playback: whatever, tested on Mac speakers, AirPods and headphones
Audio transmission interface: none (speakers), bluetooth and audio jack 3,5mm
macOS Version: 11.2.1 (20D74)
eqMac Version: 0.3.7
eqMac UI Version: 1.2.2

Screenshots or Console.app logs

Process:               eqMac [956]
Path:                  /Applications/eqMac.app/Contents/MacOS/eqMac
Identifier:            com.bitgapp.eqmac
Version:               v0.3.7 (0.3.7)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           eqMac [956]
User ID:               501

Date/Time:             2021-02-26 20:29:49.271 +0100
OS Version:            macOS 11.2.1 (20D74)
Report Version:        12
Bridge OS Version:     5.2 (18P4346)
Anonymous UUID:        5F2870C1-7E41-66DD-55A7-4F734C889A35

Time Awake Since Boot: 1200 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
*** Terminating app due to uncaught exception 'com.apple.coreaudio.avfaudio', reason: 'required condition is false: IsFormatSampleRateAndChannelCountValid(hwFormat)'
terminating with uncaught exception of type NSException
abort() called

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fff207446af __exceptionPreprocess + 242
1   libobjc.A.dylib                     0x00007fff2047c3c9 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff2076d512 +[NSException raise:format:arguments:] + 88
3   AVFAudio                            0x00007fff379ed324 _Z19AVAE_RaiseExceptionP8NSStringz + 156
4   AVFAudio                            0x00007fff37a87f9f _ZN17AVAudioIONodeImpl15SetOutputFormatEmP13AVAudioFormat + 835
5   AVFAudio                            0x00007fff37a6e63f _ZN18AVAudioEngineGraph8_ConnectEP19AVAudioNodeImplBaseS1_jjP13AVAudioFormat + 5291
6   AVFAudio                            0x00007fff37a74266 _ZN18AVAudioEngineGraph7ConnectEP11AVAudioNodeS1_mmP13AVAudioFormat + 586
7   AVFAudio                            0x00007fff37a9808e _ZN17AVAudioEngineImpl7ConnectEP11AVAudioNodeS1_mmP13AVAudioFormat + 1036
8   AVFAudio                            0x00007fff37a92594 -[AVAudioEngine connect:to:format:] + 116
9   eqMac                               0x0000000104063032 eqMac + 77874
10  eqMac                               0x00000001040635c9 eqMac + 79305
11  eqMac                               0x0000000104075d01 eqMac + 154881
12  eqMac                               0x00000001040759ee eqMac + 154094
13  libdispatch.dylib                   0x00007fff204277c7 _dispatch_client_callout + 8
14  libdispatch.dylib                   0x00007fff2042a195 _dispatch_continuation_pop + 423
15  libdispatch.dylib                   0x00007fff2043a550 _dispatch_source_invoke + 2079
16  libdispatch.dylib                   0x00007fff20433a3f _dispatch_main_queue_callback_4CF + 613
17  CoreFoundation                      0x00007fff20707970 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
18  CoreFoundation                      0x00007fff206c9852 __CFRunLoopRun + 2731
19  CoreFoundation                      0x00007fff206c86ce CFRunLoopRunSpecific + 563
20  HIToolbox                           0x00007fff28950630 RunCurrentEventLoopInMode + 292
21  HIToolbox                           0x00007fff2895042c ReceiveNextEventCommon + 709
22  HIToolbox                           0x00007fff2895014f _BlockUntilNextEventMatchingListInModeWithFilter + 64
23  AppKit                              0x00007fff22ee89b1 _DPSNextEvent + 883
24  AppKit                              0x00007fff22ee7177 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1366
25  AppKit                              0x00007fff22ed968a -[NSApplication run] + 586
26  AppKit                              0x00007fff22ead96f NSApplicationMain + 816
27  eqMac                               0x0000000104052ba9 eqMac + 11177
28  libdyld.dylib                       0x00007fff205ed621 start + 1
29  ???                                 0x0000000000000001 0x0 + 1

Additional information
the app work and I can access the advanced equalizer by relaunching the app several times.
thanks for giving us a future great equalizer, because otherwise it works fine (still a lot of work but it's working and its working great, so Thanks !

Same issue.  Frequent crashes when changing between basic and advanced and sometimes just clicking away from the app.

I have also been facing the same bug. Whenever I go from advanced equaliser to basic, the app straight up crashes on me.
I will be happy share the logs from the Console app if needed :)

Thanks for being patient with me.
I have just released v1.0.0. You can download it here: https://github.com/bitgapp/eqMac/releases/tag/v1.0.0
Or from the website: https://eqmac.app
Could you please let me know if this issue is still present.
Thanks again.
Roman

I am happy to report that this issue seems to be resolved! 🎉

I'm doing some cleanup of the issues.
This has probably been fixed long time ago, I encourage people to try v1.7 by download it from the website: https://eqmac.app
Closing for now, any new issues with eqMac should be submitted through the website.
Thank you!


GOBBLIN-970: Pass metric context from the KafkaSource to the KafkaWor…

…kUnitPacker for emission of metrics from the packer.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-970

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Pass metric context from the KafkaSource to the KafkaWorkUnitPacker for emission of bin packing related metrics.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Modified KafkaWorkUnitPackerTest.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@autumnust @ZihanLi58 Please review.

Codecov Report

Merging #2815 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #2815      +/-   ##
============================================
- Coverage     45.56%   45.56%   -0.01%
+ Complexity     8954     8951       -3
============================================
  Files          1900     1900
  Lines         71213    71215       +2
  Branches       7856     7856
============================================
  Hits          32451    32451
+ Misses        35780    35775       -5
- Partials       2982     2989       +7

Impacted Files
Coverage Δ
Complexity Δ

...bblin/runtime/StateStoreBasedWatermarkStorage.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...in/source/extractor/extract/kafka/KafkaSource.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...act/kafka/workunit/packer/KafkaWorkUnitPacker.java
15.87% <40%> (-0.17%)
6 <0> (ø)

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0%> (-7.15%)
4% <0%> (ø)

...ava/org/apache/gobblin/fsm/FiniteStateMachine.java
73.48% <0%> (-3.04%)
18% <0%> (-3%)

.../org/apache/gobblin/metrics/RootMetricContext.java
78.12% <0%> (-1.57%)
15% <0%> (-1%)

...lin/elasticsearch/writer/FutureCallbackHolder.java
61.42% <0%> (-1.43%)
4% <0%> (ø)

...main/java/org/apache/gobblin/util/HadoopUtils.java
30.53% <0%> (+0.33%)
24% <0%> (ø)
:arrow_down:

...lin/restli/throttling/ZookeeperLeaderElection.java
72.22% <0%> (+2.22%)
13% <0%> (ø)
:arrow_down:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
39.25% <0%> (+3.73%)
13% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24bc26...3c518c3. Read the comment docs.


Report retags as distinct from real memory accesses for data races

This changes the error reporting for data races such that reference invariants are no longer reported as real read and writes.
Before:
Data race detected between (1) non-atomic write on thread `unnamed-6` and (2) non-atomic read on thread `unnamed-5` at alloc1034971+0x10c. (2) just happened here

After:
Data race detected between (1) non-atomic write on thread `unnamed-8` and (2) shared reference invariant on thread `unnamed-6` at alloc1018329+0x190. (2) just happened here

Non-atomic read accesses from the other thread don't have this information tracked so those are called some potential non-atomic read access here.

Should I change the race tests to look for race detected? Matching the entire string as they currently do seems quite redundant.

This is great, I was just thinking that we should finally tackle this issue. :)
In terms of interface, I would suggest to simply extend the existing read with an NaReadType parameter. I don't quite see why we'd want functions like assert_immutable_memory, that just makes the API surface one has to understand so much bigger. (I see for write we have this internal unique_access function; I think it'd be fine to remove this and just rename unique_access to write and expose that. In fact na_read and na_write or non_atomic_read/non_atomic_write would probably be better.)
In terms of wording, "shared reference invariant on thread" does not make a lot of sense to me. I would say something like "implicit non-atomic read due to retag". (Cc @saethlin in case you have better ideas)

Should I change the race tests to look for race detected? Matching the entire string as they currently do seems quite redundant.

The point of these tests is to ensure that we call out the right thread names and access types. So just saying "race detected" would risk regressions of those aspects.
I am surprised that there are so many test failures, even for tests that involve actual accesses.  Take for instance the classic read_write_race.rs:
  -error: Undefined Behavior: Data race detected between (1) non-atomic read on thread `unnamed-ID` and (2) non-atomic write on thread `unnamed-ID` at ALLOC. (2) just happened here
  +error: Undefined Behavior: Data race detected between (1) some potential non-atomic read access on thread `unnamed-ID` and (2) 4-byte non-atomic write on thread `unnamed-ID` at ALLOC. (2) just happened here

That is a completely different error. It now started mentioning the access size as well, and what is "some potential access"? There's a very clear non-atomic read access in the source. So something is definitely wrong with the diagnostics here.

implicit non-atomic read due to retag

I do find calling it a read quite confusing. I did initially go looking for a real read operation when I found a race, which is what promted the PR.

The point of these tests is to ensure that we call out the right thread names and access types. So just saying "race detected" would risk regressions of those aspects.

The usage in rustc is more to have the .stderr catch such regressions and the test source code just ensures the right kind and location.

It now started mentioning the access size as well

I fixed that now.

and what is "some potential access"

Maybe calling it "read or retag" is better? Tracking the information on reads would be nicer, but I don't know where to do that.

I do find calling it a read quite confusing. I did initially go looking for a real read operation when I found a race, which is what promted the PR.

This is the common terminology. These are reads, they are just implicit side-effects of retags rather than explicit in the source.
Calling it an "invariant" doesn't even make semantic sense. An invariant is a property that is maintained throughout execution.  We're not talking about a property here but about an operation.

The usage in rustc is more to have the .stderr catch such regressions and the test source code just ensures the right kind and location.

I don't agree, in rustc we alsu use the annotations to ensure that the right things show up in the message. Otherwise we'd just use //~ERROR and never //~ERROR: message.

Maybe calling it "read or retag" is better? Tracking the information on reads would be nicer, but I don't know where to do that.

Why does "unknown" even happen? "read or retag" will be even more confusing for the common case where it is a regular read.

they are just implicit side-effects of retags rather than explicit in the source.

Maybe calling them speculative reads would be better?

Why does "unknown" even happen?

We only know the read type on the current thread, not on the other conflicting operation, so I wanted a hint to the user that it could be either.

Maybe calling them speculative reads would be better?

Hm... that sounds a bit like what CPUs are doing, which is unrelated. OTOH these reads are indeed related to the compiler's ability to insert read (or write) operations. So maybe the term makes sense. But then we should also use it for the aliasing errors (eventually, not in this PR).
@rust-lang/miri any opinions on terminology here?

We only know the read type on the current thread, not on the other conflicting operation, so I wanted a hint to the user that it could be either.

That sounds like it could cause a lot of confusion. Is there any way we can store that one bit of information (implicit/speculative read vs explicit read) somehow so that it is available later when computing the error? We already store an entire span, storing one more bit can't be so bad...

Hm... that sounds a bit like what CPUs are doing, which is unrelated. OTOH these reads are indeed related to the compiler's ability to insert read (or write) operations. So maybe the term makes sense

Speculative retag reads or retag reads could also be options that relates them back more to the borrow model.

Is there any way we can store that one bit of information (implicit/speculative read vs explicit read) somehow so that it is available later when computing the error?

Very likely, but I wasn't able to locate where it would go. The span logic seemed quite weird to me with it's handling of dummy spans too.

"retag read" also works for me, though using "retag" as an adjective seems a bit odd.

Very likely, but I wasn't able to locate where it would go. The span logic seemed quite weird to me with it's handling of dummy spans too.

VTimestamp probably needs a bool that indicates whether the read is "real" or not. That should likely be packed into time to avoid making it 4 bytes bigger.

I think our diagnostics should be informative for people who were completely unaware of this property of references until seeing the error. If we call them something like "a speculative retag read" we should provide a link or some other kind of reference to documentation that explains what that terminology refers to, or a separate help: message that says something like:
help: Retags permit optimizations that insert speculative (or hoisted) reads/writes. Therefore from the perspective of aliasing and data race invariants, a retag has the same implications as a read/write.

Tweaking the wording of that message:

help: Retags permit optimizations that insert speculative (or loop-hoisted) reads/writes. Therefore from the perspective of aliasing and data race models, a retag has the same implications as a read/write.

Or maybe "restrictions" instead of "models"? I don't like the use of "invariants" there, that's a specific technical term and this is too far outside its regular meaning.

"retag read" also works for me, though using "retag" as an adjective seems a bit odd.

 That makes it more clear that there's no correspondence to reads in the source code.

Note that whether unique retags are reads or writes depends on the aliasing model (in SB they are writes, in TB reads).
Is the idea that you would the entirely relegate the explanation that "shared retag" means a form of read into the help? That would also work for me.
Further editing on the help text, since it is specifically for data races so I think we can remove the "aliasing model" part:

help: Retags permit optimizations that insert speculative (or loop-hoisted) reads/writes. Therefore from the perspective of data races, a retag has the same implications as a read/write.

Note that whether unique retags are reads or writes depends on the aliasing model (in SB they are writes, in TB reads).

I stuck with retag read and retag write then. It's useful from the data race perspective to know if they're reads or writes.

I like the current wording.

@rustbot author

Just one final tweak of the message. Then please squash all the commits.

Looks good, thanks for working through all these revisions with me. :)
Please squash, then we can land this.

@bors r+

:pushpin: Commit 3cf20a2703fbad75ca22b118b94be6a8e3f26f85 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 3cf20a2703fbad75ca22b118b94be6a8e3f26f85 with merge 367082342f6287ffe209d956a33115f3d1d024e7...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 367082342f6287ffe209d956a33115f3d1d024e7 to master...


State out of sync

I use a utility called LSwitch on my laptop to quickly turn the bulbs on or off. This works great except for one thing, HomeBridges knowledge of the power state of my lights goes out of sync.
This means that if I turn the lights off this way when I go to bed, to get them to turn back on in the morning I have to ask HomeBridge to turn them off (even though they are visibly off), and then on.
I believe the culprit is this line of code. Are those if clauses necessary for anything other than to minimise traffic?

I experience this issue as well if I use the Lifx app or a flic button to change the lights. Homebridge goes out of sync and I have to do the same thing, telling Siri to turn them off and then on again to make it work.

@abjugard @AmpacheUser i've released a new version (0.2.2) that removes the highlighted section of code...hopefully that resolves it.

This does seem to have fixed the issue. Thanks

Hi dev. Still having the same issue here as well. Using any other software (LIFX app, Echo, Lightbow, etc) to flip a LIFX and Homebridge-lifx-lan goes out of status sync. A bit annoying.... is there some sort of status update feature you can implement? Thank you

I found the following bit of code from the documentation for node-lifx
I am not a programmer. So don't really know what to do with it. But it seems like it will give us status updates on the lights if we can set this bit of code to run every few minutes...
https://www.npmjs.com/package/node-lifx#requesting-light-state-and-info

G'day @Jinsterrrr,
Are you able to provide for more detailed info that than it's not working ? Are you changing the state and checking the status on the same device ? Which HomeKit app are you using ?
What versions of homebridge-lifx-lan and homebridge are you using ?
Please watch the video linked below, as it shows the Home app keeping in sync as it should...
https://www.smugmug.com/gallery/n-wzcB3J/i-XpMPsqK
Thanks,
David

Hi David. Thanks for providing the video. I am using the latest versions of homebridge and the lifx-lan plug-in, both were installed just a few days ago with the npm command.
The problem exists. I will explain the full setup and how to replicate it.
For simplicity, I have an iPhone, and an iPad. The iPad is permanently fixed to the wall as an automation switch. I have the LIFX app and the Home app installed on both the iPhone and the iPad. Homebridge and LIFX-lan are both running inside a VM (Ubuntu guest, Windows host).
If I operate the LIFX lights via the LIFX app on the iPad, then switch to the Home app on the iPad, then the status does indeed update itself in the Home app. This is consistent with the video you have shown.
If I operate the LIFX lights via the LIFX app on the iPhone, however, the Home app on the iPad does NOT update the light status, UNLESS I briefly switch to the LIFX app on the iPad first, to allow the LIFX app on the iPad to update its status, and then go back to the Home app on the iPad. This way, the Home app updates the status. But NOT if I wait too long (let's say a minute). If I don't swipe to the LIFX app on the iPad within a minute or so, even though the LIFX app still updates its status, Home no longer does....
So in summary:
change LIFX on iPad -> Home on iPad updates
change LIFX on iPhone -> quickly swipe to LIFX on iPad to allow status update -> Home on iPad updates
change LIFX on iPhone -> delayed or not swiping to LIFX on iPad -> Home on iPad does not update
Operate LIFX in any other way not on the iPad (e.g: via Echo) -> quickly swipe to LIFX on iPad to allow it to update -> Home on iPad updates
Operate LIFX in any other way not on the iPad (e.g: via Echo) -> delayed or not swiping to LIFX on iPad first to allow it to update -> Home on iPad does not update

I had the same error with this plugin got frustrating, so i decided to go another path. Used node-red-contrib-node-lifx plugin with node-red and everything works great. If anyone is interested just let me know.


can vscode run in a browser window ?

I was wanting to put vscode into a docker container, but would obviously need to be able to run vscode in a browser window - is this possible ?

Very hard to achieve nowadays. There are many references to node modules by now.

Wait - what has node_modules got to do with this ? I was wanting to show the UI in a browser, not run the application in a browser ;) The application would be running in the docker container on the server, with all the access to node_modules that it needs.

Most of the workbench code has dependencies not only on the DOM but also on native functionality, only available in node, which would make it impossible to run in a browser. Take shell.ts as an example.


55 enhance info for file links

Description
This PR changes the display of asset links in the dataset pages. Where currently it shows the file extension only, we'll now show the filename if one has been provided by the publisher, it will still show the file extension (filetype) if there is no known filename.
Made changes to the usmart.py scraper also to return these needed filenames.

ckan was done before
arcgis and dcat don't seem to provide filenames,
sparkql_statistics looks incomplete anyway so I abandoned that one.
The only other ones maybe worth updating are the web_scrapers.

Motivation and Context
Addresses issue #55
How Has This Been Tested?

Ran ckan.py and usmart.py locally, checked their csv output. Ran merge_data.py and export2jkan.py and checked their outputs too. Main point of check was that "File Name" in merge_data.csv and resources/name in JKAN dataset files are as expected.
Can't test JKAN locally.

help.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[N] My change requires a change to the documentation.
[N] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I need to wait a couple weeks to test this but will get to it. This has been helpful so far: https://jekyllrb.com/tutorials/using-jekyll-with-bundler/

Tested with new docker container from https://github.com/OpenDataScotland/jkan/pull/6 instructions: https://github.com/OpenDataScotland/the_od_bods/wiki/How-to:-Run-frontend-locally and behaves as expected
Ready for review @JackGilmore

Not sure why this is happening but when I run through all the scripts and create the merged_output.csv the header appears to split over multiple lines.

Not sure if it's linked but then I think the wrong categories are then getting written to JKAN and that also includes a blank one

ahaha... hard reset the branch? or at the least delete merged_output.csv and rerun merge_data.py. Changes in this PR don't go so far upstream so that would seem to be an existing repo issue.


remove duplicated checks

In #56 it's been said that the CI checks performance should be better for the time that It takes, so I checked all linters and removed possible duplicates, this way we should get a lower time in CI.

Thanks for your contribution. Can you look I to the circle issue(s)? Thanks!

Hi  @tmc , didnt find a link between this PR and the CIs break, btw there are a few things that can be added into gometalinter, such as --fast or --concurrency=X flags. The first only allows fast linters and the second runs X linters concurrently.

Can you address this and re-run ci?


"common_server_1.DConfig.getRaw is not a function" error shows when publishing using dendron-cli

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[x] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
when follow the document "publish quick start", the first step dendron publish init,  it show the error, detail message:
(node:17709) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
dendron publish <cmd>

commands for publishing notes

位置：
  cmd  a command to run
                      [字符串] [必需] [可选值: "init", "build", "dev", "export"]

选项：
  --version    显示版本号                                                 [布尔]
  --help       显示帮助信息                                               [布尔]
  --wsRoot     location of workspace
  --vault      name of vault
  --quiet      don't print output to stdout
  --dest       override where nextjs-template is located                [字符串]
  --attach     use existing dendron engine instead of spawning a new one  [布尔]
  --noBuild    skip building notes                        [布尔] [默认值: false]
  --overrides  override existing siteConfig properties                  [字符串]
  --target     export to specific destination                 [可选值: "github"]
  --yes        automatically say yes to all prompts                       [布尔]
  --sitemap    generates a sitemap: https://en.wikipedia.org/wiki/Site_map[布尔]

TypeError: common_server_1.DConfig.getRaw is not a function
    at PublishCLICommand.validateConfig (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/lib/src/commands/base.js:123:55)
    at CLICommand.eval [as handler] (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/lib/src/commands/base.js:49:28)
    at Object.runCommand (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/node_modules/yargs/build/lib/command.js:196:48)
    at Object.parseArgs [as _parseArgs] (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/node_modules/yargs/build/lib/yargs.js:1043:55)
    at Object.get [as argv] (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/node_modules/yargs/build/lib/yargs.js:986:25)
    at Object.<anonymous> (/Users/walker/.nvm/versions/node/v22.5.1/lib/node_modules/@dendronhq/dendron-cli/lib/bin/dendron-cli.js:42:52)
    at Module._compile (node:internal/modules/cjs/loader:1504:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1588:10)
    at Module.load (node:internal/modules/cjs/loader:1282:32)
    at Module._load (node:internal/modules/cjs/loader:1098:12)

To Reproduce
just run dendron publish init
Desktop (please complete the following information)

OS: macOS 14.5
Browser (if with published websites; include version): -
Versions (all that apply to bug):

Dendron Extension: v0.124.0
VS Code version: 1.92.0
Dendron CLI: 0.124.2

Additional context
Add any other context about the problem here.
Dendron Log file
Please attach the output of > Dendron:Dev: Open Logs here

This is an issue with the latest version, there was a breaking change, and the DConfig module has been deprecated. I am using the template provided on the official website. The version of dendron-cli being used there is 0.106.0. I installed this version under the current project and then called it by setting a script in package.json like this: "dev": "dendron publish dev", which allows you to call the local version in the current folder, bypassing the globally installed version. You can try this. Of course, you can also check the version numbers mentioned by other users to see which newer version is available.

This error is also happening on my end. I'm running Windows 11, and I also tried with WSL.

The version of dendron-cli being used there is 0.106.0. I installed this version under the current project and then called it by setting a script in package.json like this: "dev": "dendron publish dev", which allows you to call the local version in the current folder, bypassing the globally installed version.

You can also install that version by running npm install -g<EMAIL_ADDRESS>I did that and it seems to be working, for now.


Add sharing to Facebook and Twitter for posts

Add sharing functionality for Facebook and Twitter to the blog.

templates/base.rs.html

Add Facebook and Twitter sharing links in the main header.
Add Facebook and Twitter sharing links in the footer.

src/blog.rs

Add facebook and twitter_share fields to BlogConf struct.
Add generate_facebook_twitter_links method to Blog struct to generate sharing links for Facebook and Twitter.

For more details, open the Copilot Workspace session.

you are missing readme.md updates


ACQ/ERM - Derived table agreements_package_content_item updated

Closes #836
The derived table agreements_package_content_item needed an update. The relationship between the title_instance and identifier_occurrence tables has changed.

The PR is blocking the development and needs a review before we can start with the next update for the table.


Corrected import path for themes

Issue:
Incorrect import path for themes in example.
What I did
Corrected import path for themes.
How to test

Is this testable with Jest or Chromatic screenshots? No
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? Yes

If your answer is yes to any of these, please make sure to include it in your PR.

Thank you @tzkuei ! 👍


wrong package

On this site
https://apps.owncloud.com/content/show.php/roundcube?content=151523
it is possible to download a package with the name 151523-roundcube_v2.6.1_build429.zip.
But if you have a look on roundcube/appinfo/version you can see: 2.5.4.
This is a old version where I have login problems.
Can you give me please the right package with the content of 2.6.1?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24212769-wrong-package?utm_campaign=plugin&utm_content=tracker%2F308690&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F308690&utm_medium=issues&utm_source=github).

My login problem still exists. Roundcube says that the session is expired. I found this:
Solution: set $rcmail_config['ip_check'] = false; in the round cube config file main.inc.php
but I can't find the main.inc.php file.
Can you help me please?

The firts, i noted that.. the mistake are in https://github.com/hypery2k/owncloud/blob/master/roundcube/src/main/php/appinfo/version  .... but i wan to research the proper way to avoid this king of problems with multiple files that defined version info..
then ask to main developer and author about what are thinking respect that..
About the second.. u must see if there's a already opened ticket with the same problem (there's one with a problem with autologin).. if the problem are different open a new ticket and always paste the log, the info of the environment and all neeed other info for provide some help..


Revise Scholastic Standing Functionality and Content

User Story
As an institution user, I want the Scholastic Standing reporting options to fully align with policy, and to provide better wording around each option so I am aware which option is more appropriate to use.
Acceptance Criteria

[ ] UI Label Changes

change "Student Withdrew From Program" to "Student Withdrew from funded period"
change "Student completed program early" to "Student completed funded study period offering early"

[ ] Display Different Label Conditional on PT or FT application

If FT app: "Student did not complete program" should become "Student was unsuccessful in completing their funded study period offering", and add FT-specific tooltip
If PT app: "Student did not complete program" should become "Student did not complete courses they were funded, and add PT-specific Tooltip

[ ] Remove Label and Back-End Process for "Student went from Full-Time to Part-Time..."
[ ] Add new option

label should read "Student is transferring to a different institution or campus"
sub-question should ask "Last day the student is attending your institution" (ignore this mockup which says something different)
response to sub-question should become new end date during re-assessment. Impact should function identically to "completed early", i.e. re-assess with new end date, but apply no restrictions or other penalties.
store this event in database as a distinct option from "completed early" (so they can be distinguished in future reporting)

[ ] Add Tooltips next to certain options consistent with Fig 1
[ ] Adjust the sub-question of the "completed early" to be consistent with the mock-up below.

Mock-Ups
Fig 1

Biz Context

See Fig 2 for mapping of old to new options
Separate ticket will be pursued for adjusting Student Application Status Tracker, as needed,

Technical Context

@CarlyCotton @Joshua-Lakusta
These are primarily content changes landed by policy. Only functional change is removing the redundant 4th radio button called "change from part-time to full-time" which functions identically to withdrawal.
Ready to lather?

@HRAGANBC can you please ensure that the content is aligned with said policy? also the user story is vague- is that REALLY what they want- to simply align with policy? why do they want to revised scholastic standing functionality and content.

Additional Context for reference
[Uploading... image.png]

@HRAGANBC @CarlyCotton the IR12  has the current mapping for Scholastic Standing code.
Student did not complete program: UC.
Student completed program early: EC
Change in intensity: CI
As part of this ticket the code for Change in intensity is being removed. Is there an alternative code to be mapped to the new Student transfer option?

@andrewsignori-aot
Please use "ST" to denote "School Transfer" and you can remove "CI" altogether. Thx
@CarlyCotton FYI

@HRAGANBC currently formio does not support a tooltip at the option level, only at the component level (same for Student Application).
Is it possible to achieve the same content in a different way?

@andrewsignori-aot
Please use "ST" to denote "School Transfer" and you can remove "CI" altogether. Thx
@CarlyCotton FYI

@HRAGANBC we need an AC updated to reflect it.

@andrewsignori-aot
Can you please merge all ToolTips into a single ToolTip to be placed next to the "Report a Change" Heading? The text should read:
*(The - denotes a bullet point)

Student withdrew from funded study period offering
According to StudentAid BC policy, a student may need to be reported as withdrawn if:

Student drops below 60% attendance (40% for students with a disability) for three consecutive calendar weeks of study
Student increases course load from Part-Time to Full-Time studies
Student misses two consecutive calendar weeks of study
Student misses sufficient days/hours that they can no longer successfully complete the study period offering
student transfers to a new institution

Student completed funded study period offering early

Enter the revised completion date of the student

Student was unsuccessful in completing their funded study period (Full-time students only)
If a Full-Time student was unsuccessful in completing their funded study period offering, enter the total length of the study period offering in which the student was unsuccessful.

Student did not complete courses they were funded for (Part-time students only)
If a Part-Time student did not complete courses they were funded for, enter the total length of the study period in which the student was unsuccessful.

Student is transferring to a different campus
If a student is transferring to another school, report the last day of classes that they will attend at your school

This will allow the student to submit a new application to the correct school without penalizing them in any way for the transfer.

@HRAGANBC according to our chat this would be the adjusted content.
Part-time

Full-time

Common content for both

Demo
Student (Basic BCeID): andrew_signori_1 (Andrew Boni Signori_1)
Institution: SIMS_COLLE
Full-time:<PHONE_NUMBER>
Part-time:<PHONE_NUMBER>
Steps:
1 - Student: Show the student applications.
2 - Institution: Show the application "Report a change"
3 - Institution: Show the content change and the differences between Part-time and Full-time radio options.
4 - Institution: Report the new scholastic standing on both applications setting May 30 as the new end date.
5 - Student: Show new NOA for both applications with the offering end date.


some issues about bug reports

What criteria are used to filter the original set of defect reports after crawling them?

Hello,
When this paper was published, the detects4j, which relied on how explicit bug report links were made, so we crawled the original repos to find the commits of defects4j and their corresponding bug reports. You can find the details of the criteria listed in 4.1 Dataset & Benchmark in the paper. https://anilkoyuncu.github.io/papers/FSE2019.pdf


fix: use correct serviceAccountName in deployment

resolves #2
Looks like this doesn't need anything else than the serviceAccountName reference change.

LGTM, thanks!