Added linear search

Related Issue

Add linear Search.

[x] DevIncept Participant

[ ] Contributor

Closes: #23
Describe the changes you've made
I have added linear search algorithm.
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
I ran the program in my laptop as well as online ide.
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added test cases that prove my fix is effective or that my feature works.

Add compilation steps and elaborate your workflow of the project in README of the project.
Add appropriate comments in code wherever needed. Provide basic description about project.
@siddhi-244

Done maam

Cool, PR approved. You're blazing high. Great going. 🤩🙌@siddhi-244

Thank you maam


False positive for AnnotationRule

Expected Behavior
private fun getErrorMessage(value: String): String =
        @Suppress("DEPRECATION")
        customMessage.takeUnless { it.isEmpty() } ?: String.format(DEFAULT_ERROR_MESSAGE_WITH_NO_REASON, value)

above code should not report(customMessage is deprecated property). The above code also doesn't conflict with IntelliJ default formatting
Observed Behavior
Ktlint reports Expected newline warning on this. An example can be found at detekt PR at https://github.com/detekt/detekt/pull/5981#discussion_r1194221436
Your Environment
detekt uses 0.49.0 version

Looking at the exact offset (3:46), it is the elvis operator (or more precise the code leaf after the annotated expression) which is to be pushed to the next line. So the expected format is:
private fun getErrorMessage(value: String): String =
    @Suppress("DEPRECATION")
    customMessage.takeUnless { it.isEmpty() }
        ?: String.format(DEFAULT_ERROR_MESSAGE_WITH_NO_REASON, value)

When analyzing with the PsiViewer plugin in IntelliJ, it is clear that the ANNOTATED_EXPRESSION is following only:
    @Suppress("DEPRECATION")
    customMessage.takeUnless { it.isEmpty() }

The reasoning that default IntelliJ formatter accepts this format is less relevant as the format provided by Ktlint is also accepted by IntelliJ formatter. If the Ktlint format would not be accepted by IntelliJ formatter then the argument would be valid.
I am not sure whether this is an unintended side effect or intended behavior but I tend to the latter.

Would the same be true without the annotation present? i.e. the elvis should be on a new line. What really confused me is the "new line expected" from the "annotation" rule, when the annotation looked ok.
İs there any way to report the message or location in this case? Or maybe just add this example to the docs, because we checked it and it wasn't clear from the examples what is wrong with the code.

I had another look and discovered a problem. This may or may not be the same problem that you encountered but the original issue does not contain enough information to check that.
In the end, it really depends on the code style what is actually happening.
When code style is not set, or when set explicitly to ktlint_official, official or intellij_idea the violation is what I reported before:
With .editorconfig:
[{*.kt,*.kts}]
ktlint_standard=enabled
ktlint_experimental=enabled

the command ktlint --relative results in
17:37:42.462 [main] INFO com.pinterest.ktlint.cli.internal.KtlintCommandLine - Enable default patterns [**/*.kt, **/*.kts]
src/main/kotlin/Foo.kt:3:46: Expected newline (standard:annotation)

Summary error count (descending) by rule:
  standard:annotation: 1

The violation message and the offset are in sync and it should be clear how the code is to be fixed. With ktlint-0.49.1 --relative -F the code is formatted as:
private fun getErrorMessage(value: String): String =
    @Suppress("DEPRECATION")
    customMessage.takeUnless { it.isEmpty() }
        ?: String.format(DEFAULT_ERROR_MESSAGE_WITH_NO_REASON, value)

When code style is set to android or android_studio there are more violations reported:
With .editorconfig:
[{*.kt,*.kts}]
ktlint_code_style = android
ktlint_standard=enabled
ktlint_experimental=enabled

the command ktlint --relative results in
17:41:39.417 [main] INFO com.pinterest.ktlint.cli.internal.KtlintCommandLine - Enable default patterns [**/*.kt, **/*.kts]
x.kts:6:97: Unnecessary trailing comma before ")" (standard:trailing-comma-on-call-site)
src/main/kotlin/Foo.kt:1:53: First line of body expression fits on same line as function signature (standard:function-signature)
src/main/kotlin/Foo.kt:3:1: Exceeded max line length (100) (standard:max-line-length)
src/main/kotlin/Foo.kt:3:31: Missing newline after "{" (standard:wrapping)
src/main/kotlin/Foo.kt:3:46: Expected newline (standard:annotation)
src/main/kotlin/Foo.kt:3:64: Argument should be on a separate line (unless all arguments can fit a single line) (standard:argument-list-wrapping)
src/main/kotlin/Foo.kt:3:102: Argument should be on a separate line (unless all arguments can fit a single line) (standard:argument-list-wrapping)
src/main/kotlin/Foo.kt:3:107: Missing newline before ")" (standard:argument-list-wrapping)

Summary error count (descending) by rule:
  standard:argument-list-wrapping: 3
  standard:annotation: 1
  standard:function-signature: 1
  standard:max-line-length: 1
  standard:trailing-comma-on-call-site: 1
  standard:wrapping: 1

When running format the output changes to:
17:44:18.369 [main] INFO com.pinterest.ktlint.cli.internal.KtlintCommandLine - Enable default patterns [**/*.kt, **/*.kts]
src/main/kotlin/Foo.kt:1:53: Expected newline before annotation (standard:annotation)

Summary error count (descending) by rule:
  standard:annotation: 1

This log message is rather confusing when you compare it with the original code sample. However, it should not be compared with the original but with the modified code to make sense.
and the file is formatted as:
private fun getErrorMessage(value: String): String = @Suppress("DEPRECATION")
customMessage.takeUnless { it.isEmpty() }
    ?: String.format(DEFAULT_ERROR_MESSAGE_WITH_NO_REASON, value)

What happened is following:

The android code style has a default max-line-length (100)
The first line of the body expression has been merged with the function signature as the total length of the merged line is less than the max-line-length. But in this case the body expression should not have been merged as it conflicts with another rule. I have to check whether this can be resolved.
Once the formatting is done, KtlintRuleEngine executes a linting step. Normally this should only reveal lint errors which can not be automatically corrected. However, in this case it reveals that autocorrect has introduced a new problem. The user can however not fix this problem by manually inserting the newline before the annotated expression.
This problem can also be reproduced with other code styles by setting .editorconfig properties that set the max line length and/or function signature rules.

Would the same be true without the annotation present? i.e. the elvis should be on a new line

Without the annotation the elvis operator is not pushed down. If pushing down would be needed in that scenario, it should be done by another rule but no such rule is in place. I know of at least one other situation (a chained method call) in which the elvis is also pushed down.
The annotation-rule pushes the elvis down to make more clear what the scope is of the annotation.

İs there any way to report the message or location in this case?

When calling the lint or format function on the KtlintRuleEngine any LintError is reported via a callback. This LintError contains the offset (line and position) on which the error was found. Ktlint CLI uses exact this same mechanism to produce the output shown above.

Or maybe just add this example to the docs, because we checked it and it wasn't clear from the examples what is wrong with the code.

I don't think that adding this example to the docs would be helpful as the same could be said for all unit tests which are not explicitly described in the docs.

Nice investigation! Thanks for the replies, all makes sense. I have two small clarification to make:

This may or may not be the same problem that you encountered but the original issue does not contain enough information to check that.

The issue is from the detekt project's CI on a PR (running ktlint via detekt's wrapper), so I think what you're looking for is:
https://github.com/detekt/detekt/blob/main/.editorconfig

Is there any way to report the message or location in this case?

This LintError contains the offset (line and position) on which the error was found.

In the screenshot you showed there's a range of characters highlighted in PSIViewer (the ANNOTATED_EXPRESSION node), same as in GitHub which is Sarif uploaded from detekt's execution. The fact that you said "This LintError contains the offset (line and position)" made me realize that it's not ktlint highlighting that full node (which made this confusing), but detekt's wrapper.
Looking at pure ktlint output, it's actually very clear where the problem is (│):
private fun getErrorMessage(value: String): String =
        @Suppress("DEPRECATION")
        customMessage.takeUnless { it.isEmpty() }│ ?: String.format(DEFAULT_ERROR_MESSAGE_WITH_NO_REASON, value)

and "Expected newline" makes perfect sense.
But detekt re-maps this single-location finding to the node that was being visited while it was emitted
(notice how the offset (_) parameter is ignored):
https://github.com/detekt/detekt/blob/948276a8db4578b962bf24c63eee3b8548bac627/detekt-formatting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRule.kt#L97

Based on:

"Looking at the exact offset (3:46), it is the elvis operator which is to be pushed to the next line."
"The annotation-rule pushes the elvis down to make more clear what the scope is of the annotation."

I think this issue is resolved by explanation, not a false positive, nothing to do from our report.
Based on:

"This LintError contains the offset (line and position)"
"detekt re-maps this single-location finding to the node that was being visited"
"the offset parameter is ignored"

I think this explains the confusion about the message vs. location -> https://github.com/detekt/detekt/issues/6105
So you can either close this, or keep it open for your other found issue.


Refactor Bot.ts

Cleaned up Bot.ts
There still is ESLINT error on L336, which could be fixed by making onPricelist synchronous.

I will let sir @joekiller review this since he made these changes.

Hi @arik123 if you bind the way it is setup then each binding is an anonymous function created at that moment of the method call and this can have unintended side effects. For instance if the bot restarts after a crash then you will get double the events. If it crashed again, it would setup triple events. Also because the functions are anonymous if you call removeAllListeners on the socket, it will not be able to remove those functions.
If I am mistaken please let me know. Otherwise I would reject this.

Hi @arik123 if you bind the way it is setup then each binding is an anonymous function created at that moment of the method call and this can have unintended side effects. For instance if the bot restarts after a crash then you will get double the events. If it crashed again, it would setup triple events. Also because the functions are anonymous if you call removeAllListeners on the socket, it will not be able to remove those functions.
If I am mistaken please let me know. Otherwise I would reject this.

Is there a way how I reproduce this behaviour ? And is there a way how to debug with PM2 ?

I think you could just call !restart several times and then you'll see
duplicate price update events and such.
Sent via mobile
On Thu, Mar 4, 2021, 8:58 AM Maximilián Maliar<EMAIL_ADDRESS>wrote:

Hi @arik123 https://github.com/arik123 if you bind the way it is setup
then each binding is an anonymous function created at that moment of the
method call and this can have unintended side effects. For instance if the
bot restarts after a crash then you will get double the events. If it
crashed again, it would setup triple events. Also because the functions are
anonymous if you call removeAllListeners on the socket, it will not be able
to remove those functions.
If I am mistaken please let me know. Otherwise I would reject this.
Is there a way how I reproduce this behaviour ? And is there a way how to
debug with PM2 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TF2Autobot/tf2autobot/pull/399#issuecomment-790636257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHZXR3Z63UQEUF4SU6NNYDTB6GWZANCNFSM4YR34DCA
.

You can put this in your .env to see socket activities (credit to @joekiller):

Read this: https://medium.com/@DavideRama/removeeventlistener-and-anonymous-functions-ab9dbabd3e7b

that should not be a problem, because there does not seem to be any removeListener used

I tried restarting the bot, but it did not seem to do anything as it should be.

To shutdown the bot cleanly the socket manager shutdown call uses this.
socket.removeAllListeners()
https://github.com/TF2Autobot/tf2autobot/blob/master/src/classes/BotManager.ts#L244
So it is used.
https://github.com/TF2Autobot/tf2autobot/blob/master/src/classes/MyHandler/SocketManager.ts#L70
One could argue that only a subset of the functions actually need to be
bound to a named instance and I would support that refactor if you want but
anything that gets bound to socket events need to have named instances not
anonymous functions.
Sent via mobile
On Thu, Mar 4, 2021, 11:21 AM Maximilián Maliar<EMAIL_ADDRESS>wrote:

that should not be a problem, because there does not seem to be any
removeListener used
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TF2Autobot/tf2autobot/pull/399#issuecomment-790739939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHZXRYQRUMRAUHNQ4WLSVDTB6XQRANCNFSM4YR34DCA
.

Even if removeAllListeners() was somehow unable to remove anonymous listener, if you restart the bot, there should be no problem with double registration of handlers.
Also as far as I can tell, the only two cases, when events are bound to socketManager are Pricelist and inside SocketManager itself, and in both cases there are no anonymous functions

I'd prefer best practices.

and what are the best practises ?

and what are the best practises?

from the reference provided by @joekiller and his further explanations?

Okay I think we encapsuled the part that could blow up in the socket
manager so I'll pass this
Sent via mobile
On Thu, Mar 4, 2021, 12:46 PM IdiNium<EMAIL_ADDRESS>wrote:

and what are the best practises?
from the reference provided by @joekiller https://github.com/joekiller
and his further explanations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TF2Autobot/tf2autobot/pull/399#issuecomment-790803227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHZXR6Y463ZOITRFKENZD3TB7BPNANCNFSM4YR34DCA
.

alright, now let me see the cause of the error.

But make sure you fix the linting problem which may require a named
reference or some syntax update to bind to the async functions
Sent via mobile
On Thu, Mar 4, 2021, 1:05 PM Joseph Lawson<EMAIL_ADDRESS>wrote:

Okay I think we encapsuled the part that could blow up in the socket
manager so I'll pass this
Sent via mobile
On Thu, Mar 4, 2021, 12:46 PM IdiNium<EMAIL_ADDRESS>wrote:

and what are the best practises?
from the reference provided by @joekiller https://github.com/joekiller
and his further explanations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TF2Autobot/tf2autobot/pull/399#issuecomment-790803227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHZXR6Y463ZOITRFKENZD3TB7BPNANCNFSM4YR34DCA
.


Should commands that are no-ops should return a non-zero exit code?

Discussion
This was brought up by @kiryph in https://github.com/koekeishiya/yabai/issues/186#issuecomment-517900103.

However, the exit code of yabai -m window --swap largest; echo $? is always zero, even when no swapping occurs (e.g. terminal window is the largest window where I execute this command).
Is this intentional?

I am really unsure about this and want to discuss a possible change here.
This affects the focus, swap and warp commands. Note that the focus command can also be used for its side-effect of raising an already focused window that was not raised (e.g. from ffm set to autofocus), so it's not really a no-op sometimes.

Just another confirmation that the swap command with the window itself returns the exit code 0:
$ yabai -m window --swap $(yabai -m query --windows --window | jq -r '.id'); echo $?
0

The original intention was if swapping 'fails' the last swap is repeated.

I think this makes sense for swap and warp commands, but not necessarily for focus commands as they have a potential sideeffect of raising the window, as mentioned in the original post. I'll probably do an overhaul of the exit codes for all commands when I have time.
My focus is currently on making the current functionality more robust, and to make sure the interface is good and clean, before looking at adding any kinds of major new functionality.

This would be really helpful for "resize" as well (for BSP layouts). I'm a BSPWM user trying to replicate my setup, and I'm really fond of being able to fallback when resizing. For instance I have hotkeys that will grow the window to the right, but if it can't (i.e. it's against the edge) fall back to shrinking from the left. Without this there's no way to have a hotkey that always grows/shrinks a window.

This would be really helpful for "resize" as well (for BSP layouts). I'm a BSPWM user trying to replicate my setup, and I'm really fond of being able to fallback when resizing. For instance I have hotkeys that will grow the window to the right, but if it can't (i.e. it's against the edge) fall back to shrinking from the left. Without this there's no way to have a hotkey that always grows/shrinks a window.

I have set an alternate key binding for shrinking (meh + jikl) and growing (hyper + jikl) in BSP layout. It works well and avoids this particular case of the non-zero exit code. Yabai won't be able to be a direct replication of BSP - it is absolutely a lifesaver as a legitimate twm for macOS which we otherwise wouldn't have.

window swap, warp, insertion, grid, move, resize, and ratio, will now report a non-zero exit code upon failure.


CREATE/ALTER CLUSTER command enhancement

Hi,
What about the following enhancement request:
new SIZE attribute for CREATE CLUSTER and ALTER CLUSTER commands:

CREATE CLUSTER - to specify initial size (replace the defaults)
ALTER CLUSTER - shrink/enlarge cluster's size

Thank you.

Not relevant anymore. Closing it.


Ethan: Blacklist<PHONE_NUMBER>47

Ethan requests the blacklist of the number<PHONE_NUMBER>47. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Makyen in Charcoal HQ


Rancher backup configuration is not set/updated correctly

master 29/01
Steps to reproduce:

Create an RKE cluster with default backup settings
Try to edit the cluster after it's provisioned
issues:
1 - UI shows the message:

This cluster was configured with a legacy ectd snapshot api. The new api replaces the creation time and retention time durations with a simpler creation time in hours and retention count. We have migrated your creation period automatically. Retention count has been configured to the default of 6 backups (current retention duration: 72h), if you're okay with this setting no further action is required. If not, you may change the setting in the advanced settings section.

2 - The API view shows snapshot: true, which is only related to RKE local backup. For rancher provisioned clusters, this should be false
3- When S3 configuration is added to to the backup configuration it works correctly, but if you try edit it again, the UI shows the default settings again and the S3 configuration is discarded.

Version: Master 2.2 (2/1/19)
Confirmed fix. In API (assuming default config for DO RKE cluster) snapshot indeed is false now.
I successfully edit the cluster and saved without any issues; I did not get the UI mentioned in the issue description.
Regarding #3 under the steps to reproduce this was recently tested in a separate issue and is resolved. You can edit a cluster and it will correctly show the previous s3 settings you set when you created it. You can save without issues with s3 as well.


[5.2][CSRanking] Detect cases where overload choices are incomparable

Explanation:

If constraint system is underconstrained e.g. because there are
editor placeholders, it's possible to end up with multiple solutions
where each ambiguous declaration is going to have its own overload kind:
func foo(_: Int) -> [Int] { ... }
func foo(_: Double) -> (result: String, count: Int) { ... }

_ = foo(<#arg#>).count

In this case solver would produce 2 solutions: one where count
is a property reference on [Int] and another one is tuple access
for a count: element.

Issue: rdar://problem/49712598

Scope: Affects expressions which placeholders and only in narrow cases where it's possible to produce a solution with overloads of different kind.

Risk: Very Low.

Testing: Added compiler regression tests.

Reviewed by: @hborla and @nathawes

Resolves: rdar://problem/49712598
(cherry picked from commit 288a7765fc3f3eece215267b8dca043c1260e5b2)

@swift-ci please test


Troubleshooting steps shall be using Powershell and not curl command

Troubleshooting steps specify curl command which is by default in Windows powershell aliased to Invoke-WebRequest and commands would just fail. I'm confused why somebody who is writing instruction for Windows only would put curl in a first place as part of troubleshooting.
Any curl command in document shall be replaced with Invoke-Webrequest instead
For example curl -H Metadata:true "http://<IP_ADDRESS>/metadata/instance?api-version=2017-08-01" shall be replaced with Invoke-webrequest -Headers @{"Metadata"="true"} -uri "http://<IP_ADDRESS>/metadata/instance?api-version=2017-08-01" -UseBasicParsing

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c946fe0f-e18d-2529-2fbf-bce04759fbca
Version Independent ID: 885a61d1-6096-5aa0-fe8d-f1ec8d55e542
Content: Log in to a Windows virtual machine in Azure by using Azure AD - Microsoft Entra
Content Source: articles/active-directory/devices/howto-vm-sign-in-azure-ad-windows.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@artisticcheese
Thanks for your feedback! We will investigate and update as appropriate.

@artisticcheese
Thanks for pointing this out. I am assigning this case to author. @MicrosoftGuyJFlo Please review it

I will forward the feedback to the PM who owns the feature. Thanks!
#please-close


Integrate Dash.

Description
As we have talked about, I am creating this issue to track the progress and necessary steps that are needed for the v1 goal of integrating Dash..
The full doc on how anyone can implement dash. on their websites, is written down here.
TODOs

[x] Add simple widgets to the page (The widget creator might be of great help for that)
[x] Pass the theme and optionally custom colors to the widget using the correct parameters (Documented here, but again the widget creator might be of great help)
[x] Query the speed-test results, using the /info REST endpoint
[ ] Query the /config REST endpoint, to gather the following information:

Is multiView enabled for the storage widget (config.enable_storage_split_view)
Which widgets are enabled in general (config.widget_list)

[x] Allow configuration for the following options in Homarr:

[x] CPU multiView
[x] Storage multiView, if enabled
[ ] Usage of Homarr Theme colors, instead of Dash. colors
[x] A full view and a more compact view (+ maybe an ultra-compact view)
[x] Each graph should be able to be toggled off

[ ] Update docs to describe the integration to Dash.

Priority
Low (Nice-to-have)

Notes about the open points:

There is currently no point in querying the /config endpoint, because options cannot be dynamically set or removed anyway.
I have tried using the theme colors, but in my opinion it does not look that great.
Docs should be done when the integration is finalized. Also, I would love it if someone else could write them - I am not that good at writing.

Would you consider using the dash. GPU option?

What do you mean with that? AFAIK you can enable the GPU option from the options menu @jeryd.


Random crashes

I don’t know whose mod can cause crashes, but this only happens when this mod is installed :(
They are all different.
Crash going on when i start any world. In crash folder appears two diffirent files:
Server: https://gist.github.com/Ibirtem/54e25e7186e42dcdc2ca7e0c62a6d605
Client: https://gist.github.com/Ibirtem/a0b3b680a5e85e3c8f8f73f155698b02

Thank you. I'm trying to fix it, but I couldn't reproduce it. I'm so confused now.

i found what it can be (if it help you)
Biomes O' Plenty
There clear crash report: https://gist.github.com/Ibirtem/a3882eff1fea8c09236902ac9cdc2d31

That's helpful, thanks very much.

OK, I know why it crashed. I'll fix it soon.

The bug has been fixed. Thank you!


Check base path

Strip basePath from path if basePath set.
Otherwise, setting basePath can break URLs in swagger-ui.
@sloria: I think this is a reasonable feature to add to smore, but you could also argue that it's the user's responsibility to strip the base path from all paths if they're going to set basePath. I don't have a strong intuition about this--mostly wanted to log for discussion.
Depends on #13.

+1


Lint/MissingSuper false positive

There are cases where I'm explicitly avoiding calling super in an initializer, however this cop complains on all of them. This doesn't seem very useful.

There's also a request to have a list of accepted superclasse exceptions, would that resolve the issue for you?
I'm curious of examples where there are good reasons to explicitly not call super.

I'm curious of examples where there are good reasons to explicitly not call super.

👍

There's also a request to have a list of accepted superclasse exceptions, would that resolve the issue for you?

Not really. I just don't think this should be a rubocop.

I'm curious of examples where there are good reasons to explicitly not call super.

One concern would be for performance (though this is not a primary concern).  Another is that this makes the code harder to read as I might have to navigate to another file to see what logic is happening there (and this could be hard to find if it's in a gem).  Mostly I'm concerned that this is not idiomatic for libraries like view_component (https://github.com/github/view_component#implementation) If a new coder sees super calls they may wonder why the last developer didn't use the patterns promoted by the library authors.

I might have to navigate to another file to see what logic is happening there

The idea is that if there was no initialize method, say, would you actually go to another file to see what the inherited initialize does?
That said, if others feel this Cop should be disabled by default, I won't stand in the way.

Sorbet is one counter-example where you don't want to call super necessarily, born out of @will's post on standard https://github.com/testdouble/standard/issues/195
It'd be really awesome if this was configurable for which callbacks, because I think there are fewer cases where you'd intentionally skip calling super on method_missing than on initialize. Any chance of that?

Speaking of those two cases (notice no parent class):
        class Foo
          def method_missing(*args)
            super

        class Foo
          def self.inherited(base)
            super

Is super really necessary? Why?
@fatkodima can you please provide an example of what will break for a missing super with no parent class?

Yes, without parent classes those are not really strictly necessary.
For the example with M module, that was fixed on master, if I remember correctly.

Not necessary, but can't hurt.
I also don't think we are dealing with:
        class Foo
          extend ModDependingOnInheritedCallback
          def self.inherited(base)
            super

or
# base.rb
      class Foo < Bar
      # ...

# extension.rb
       class Foo
         def self.inherited

Here's an example of method_missing not calling super but perfectly working.  https://github.com/faker-ruby/faker/blob/9ea5a3d/lib/helpers/unique_generator.rb#L17-L27
Falling back to raise instead of super seems like a possible scenario for a method_missing (but I'm not sure if we should allow this here in this cop).

I just bumped into this with some Exception classes.  To me, the exception to this rule is that the ancestors of a class do not initialize ivars.  Of course, a static tool is going to be hard pressed to keep up with every possible case.  However, it seems to me that the vast bulk of these exceptions can be caught without too much trouble.

During scanning, an ancestor map is created.  (This cannot be absolutely perfect, but will work generally.)
A list of classes and modules from ruby and the ruby core can be maintained which do not initialize ivars.
Any class with a high-confidence ancestor map whose ancestors either lack an initialize instance method, or which are on "the list" are good.

Because it's REALLY annoying to write:
class MyError < RuntimeError
  # rubocop:disable Lint/MissingSuper
  def initialize(var)
    @ivar = var
  end
  # rubocop:enable Lint/MissingSuper

I've just run into the same issue when creating a dsl and using self.inherited() only once in the base class. It would be nice if that edge case was considered by this cop. Though at the end of the day it's not too hard to just write a one line exception to the rule.
def self.inherited(subclass) # rubocop:disable Lint/MissingSuper

@marcandre, how come nothing happened with this?

There's also https://github.com/rubocop-hq/rubocop/pull/8376#issuecomment-670428314 to have a list of accepted superclasse exceptions, would that resolve the issue for you?

This would definitely solve my problem, while allowing me to keep the cop everywhere else.

Thanks @koic!


ssh not available

Having trouble w/ssh to instance with ami-07be40433001d2433. I'm near certain this is an issue w/the AMI itself as I launched it in different vpc, subnets, w/different keys, etc. To reproduce simply launch the AMI with default settings, attempt to ssh with assigned key, the result will be: Permission denied (publickey).
AMI is derived from https://github.com/prabhatsharma/kubernetes-the-hard-way-aws/blob/master/docs/03-compute-resources.md#instance-image
IMAGE_ID=$(aws ec2 describe-images --owners<PHONE_NUMBER>77 \
  --filters \
  'Name=root-device-type,Values=ebs' \
  'Name=architecture,Values=x86_64' \
  'Name=name,Values=ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-*' \
  | jq -r '.Images|sort_by(.Name)[-1]|.ImageId')

I'm unsure if I've ever used an Ubuntu instance :-). I've become so accustomed to ec2-user I didn't think the username could be the issue! So this works just fine against your AMI:  ssh -i kubernetes.id_rsa<EMAIL_ADDRESS>What clued me in:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/TroubleshootingInstancesConnecting.html#TroubleshootingInstancesConnectingSSH
And this (note the scp command and username being used here):
https://github.com/prabhatsharma/kubernetes-the-hard-way-aws/blob/master/docs/04-certificate-authority.md#distribute-the-client-and-server-certificates


Contract drafts

Fixes https://github.com/reform-org/reform/issues/301
Closes https://github.com/reform-org/reform/issues/364

Saving a draft (as draft - without finalizing) should route to the contract drafts page

Saving a draft (as draft - without finalizing) should route to the contract drafts page

For me that works.


net/http: DefaultTransport documentation should describe HTTPS_PROXY

What version of Go are you using (go version)?

go version go1.12.4 linux/amd64

Does this issue reproduce with the latest release?
Affirmative.
What operating system and processor architecture are you using (go env)?
go env Output
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/howard/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/howard/gopath"
GOPROXY=""
GORACE=""
GOROOT="/home/howard/go"
GOTMPDIR=""
GOTOOLDIR="/home/howard/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build043222332=/tmp/go-build -gno-record-gcc-switches"

What did you do?
In https://golang.org/pkg/net/http/#RoundTripper, the online manual explains the following for RoundTripper:

DefaultTransport is the default implementation of Transport and is used by DefaultClient. It establishes network connections as needed and caches them for reuse by subsequent calls. It uses HTTP proxies as directed by the $HTTP_PROXY and $NO_PROXY (or $http_proxy and $no_proxy) environment variables.

Although DefaultTransport uses proxy settings from system environment via ProxyFromEnvironment, which not even recognises HTTP proxy, but HTTPS proxy also:

ProxyFromEnvironment returns the URL of the proxy to use for a given request, as indicated by the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY (or the lowercase versions thereof). HTTPS_PROXY takes precedence over HTTP_PROXY for https requests.

DefaultTransport indeed behaves correctly and recognises both HTTPS and HTTP proxy settings from system environment. Therefore, please elaborate about the support of HTTPS proxy in the documentation for DefaultTransport.
Thanks!

Please let me know if I am understanding this issue. To summarize:
The documentation for DefaultTransport says that it supports HTTP_PROXY and NO_PROXY, but does not mention that it supports HTTPS_PROXY, and your suggestion is that it should describe this additional environment variable. Correct?

/cc @rsc (since Brad is on leave)

Thanks @katiehockman and yes indeed.

@HouzuoGuo with the changes from https://go.dev/cl/430135 is there anything to improve for the issue?
See the tip's documentation for the reference https://pkg.go.dev/net/http@master#DefaultTransport

That's amazing - thank you!


Move off screwdriver and stop EL 7 and Ubuntu 18 support

[x] Create sanitize build and tests in github actions - finished in #2685
[x] remove everything from screwdriver except last commit EL7 (including all release items)
[x] update old downloads page to only have EL7 for last commit
[x] remove all main builds from s3 except EL7

for now i've left 18 & 7 in screwdriver


Execute shell windows stay open for only a short period of time

Describe your issue here
Our users make use the the Execute Shell feature quite a bit.  We've noticed that with version 1.1.3 we are seeing an issue where these windows stay open only for a short period of time.  Also, the length of time seems to be very random as to how long the window (shell) does stay open.

Useful
Info

Versions
Rancher v1.1.3 Cattle: v<IP_ADDRESS> UI: v1.1.12

Access
github admin

Orchestration
Cattle

Route
admin-tab.settings

I believe there is nothing in the UI that actually closes the window. Its more the byproduct of something terminating the connection, after inactivity, and timing out.

Yes, the UI does not close the connection.  A load balancer, proxy, or other device is closing the connection.

I have this issue as well, possibly related to #4983 ?

If thats the case @smazurov can you try extending the ELB timeout by following this doc: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/config-idle-timeout.html#config-idle-timeout-console

I also noticed in an HA stack that the load balancer has a client and server connection timeout of 50. That can be modified manually, but if one of those containers gets recreated, the configuration for that container would revert.

Following @aemneina over here... I've been hitting this issue too. Is there an ETA on the fix?

We had this issue too when accessing the Rancher UI through an AWS ELB.
Increasing the Idle Timeout to 1200 seconds fixed the issue for us.

When you're running a self-hosted Rancher behind a HAProxy, it helps to set "timeout client 1h" in the frontend and "timeout server 1h" in the backend. After this change the "Execute Shell" window stays open. Before that it would disappear, more or less after 1min (which is the default timeout in my HAProxy setup).

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.

For the benefit of future Googlers like me: There is a hack you can use to work around your Rancher pod shells timing out... Just run this in the shell you want to keep alive:
$ while sleep 30 ; do echo -en "\025" ; done &
All this does is occasionally put traffic on the terminal websocket, so it doesn't auto-close.
\025 is ASCII 'NAK' which doesn't seem to affect the terminal.
Seems to work. Happy days!

For the benefit of future Googlers like me: There is a hack you can use to work around your Rancher pod shells timing out... Just run this in the shell you want to keep alive: $ while sleep 30 ; do echo -en "\025" ; done &
All this does is occasionally put traffic on the terminal websocket, so it doesn't auto-close. \025 is ASCII 'NAK' which doesn't seem to affect the terminal.
Seems to work. Happy days!

This worked. Thanks !


Fix cylinder axis orientation, update deps, bump version to 0.10.0

Fixes #13
Related to #28

@marcofugaro Do you think this is likely to break any of the examples using Cylinder bodies in this repo?

Thanks for the heads up! I'll do a check!

I can help check it out tomorrow morning too if needed (just now going to bed). I was in the middle of the cannon-es-debugger stuff when it occurred to me that I may have caused bugs in the examples 😅 I wanted to make sure I mention it somewhere before it leaves my mind forever 😔


Bkg callback

Review note:
There are three major changes in this PR-

All callbacks that create a figure become background_callbacks. The dcc.Graph component that they return to is wrapped in a dcc.Loading object. The callbacks themselves wait for the data they need (all of the data for the repo_choices input vector to be satisfied) to be populated in Redis.
Queries to Augur are Celery tasks that download all of the requested data at once and then chunk it post-download, saving it to Redis per-repo.
job_manager module has been dropped at the cache_manager module has been added.

Lots of miscellaneous formatting changes have been made because the 'black' for matter started working in VSCode.
Also, switched from pipenv to requirements.txt because pipenv was givign a lot of trouble.

pre-commit failing because it doesn't like the 8knot module name. it thinks that it should follow pep8 and be all lower-case and non-numeric/non-special-characters

@cdolfi changes made to address your comments- let me know if there's anything else to address or please feel free to merge when convenient!

@cdolfi okay done!


Version computation for mono-repo-mode

Description
Please include a summary of the change, motivation and context.

Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:

[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

logs
next_version_tag: notification-sender-tv-5.0.9
next_version: 5.0.9

rm: can't remove '/tmp/updated_workloads.sh': No such file or directory
NAME                  READY   AGE
notification-sender   1/1     8d
current_version_tag: notification-sender-tv-5.0.9
current_version: 5.0.9


Update the ws Library

New versions of ws contain security patches which we should probably have.

Bump - working wih a project that depends on this lib.


Create debug mode

Export video with recognized gestures shown in it, as well as with their classification probability.

TODOs:

[] draw hands keypoints frame by frame;
[] draw text on top of the video with the recognized sign and its classification confidence;
[] export video without any modifications.


SQLite SuppressForeignKeyEnforcement is not working after upgrate version 2.0

I have a helper method for unit test my repositories using SQLite as store, really I'm not interested in verify Foreign Keys in Test mode, then I used SuppressForeignKeyEnforcement config method in order to avoid that validation, before I upgrade to version 2.0.1 it worked like a charm, as soon I make the upgrade it started validating FKs when I insert test data causing my tests to fail. I noticed if I manually run PRAGMA FOREIGN_KEYS=OFF as sql statement the FK enforcement was removed again, but that is not a so clean workarround.
Exception message:
Stack trace:

Microsoft.Data.Sqlite.SqliteException : SQLite Error 19: 'FOREIGN KEY constraint failed'.

Steps to reproduce
 var options = new DbContextOptionsBuilder<TContext>()
                    .UseSqlite(connection, x => x.SuppressForeignKeyEnforcement()) //SuppressForeignKeyEnforcement broke in 2.0.1 version, it does not remove FK Enforcement anymore
                    .Options;

As soon I added some data to my DBContext and call
await context?.SaveChangesAsync();
it fails
This is my complete test helper

```c#
 public static async Task UseSQLiteAsync<TContext>(Action<TContext> seedMethod, Func<TContext, Task> test) where TContext : DbContext
        {
            // In-memory database only exists while the connection is open
            var connection = new SqliteConnection("DataSource=:memory:");

            try
            {
                connection.Open();
                var options = new DbContextOptionsBuilder<TContext>()
                    .UseSqlite(connection, x => x.SuppressForeignKeyEnforcement()) //SuppressForeignKeyEnforcement broke in 2.0.1 version, it
                    .Options;

                // Insert seed data into the database using one instance of the context
                using (var context = Activator.CreateInstance(typeof(TContext), options) as TContext)
                {
                    //it removes the FK enforcement again, but is kind of nasty
                    //context?.Database.ExecuteSqlCommand("PRAGMA FOREIGN_KEYS=OFF");
                    // Create the schema in the database
                    context?.Database.EnsureCreated();
                    seedMethod.Invoke(context);
                    await context?.SaveChangesAsync();
                    await test(context);
                }

            }
            finally
            {
                connection.Close();
            }
        }

Here I consume the method
[Fact]
        public async void
            GetByLocation_ExcludeProductsAreNotActive_2ProductsExcluded()
        {
            //It failes with In Memory Database
            await Helper.UseSQLiteAsync<MyDbContext>(
                context =>
                {
                    context.LocationCatalog.Add(Only_Active_ProductsDS.GetLocationCatalog());
                    context.Product.AddRange(Only_Active_ProductsDS.Get3Products1Inactive());
                    context.ProductExternalProvider.AddRange(Only_Active_ProductsDS.Get3ProductExternalProviders());
                },
                async context =>
                {
                    var repo = new HotelRepository(context, _mockLoggerFactory.Object);
                    var result = await repo.GetByLocation(1);
                    result.Should().NotBeNullOrEmpty().And.HaveCount(2);
                    result.Should().OnlyContain(e => e.Id == 1 || e.Id == 2);
                });
        }

Further technical details
EF Core version: 2.0
Database Provider: Microsoft.EntityFrameworkCore.Sqlite
Operating system: Win10 Pro
IDE: Visual Studio 2017

Have you tried upgrading to version 2.0.1?

I update that part, actually I'm using the latest version (2.0.1) I started a laborious task to migrate our aspnet core 1.1 applications to 2.0 and as a part of this all packages were upgraded to lastest version, so yes this happens to me in Microsoft.EntityFrameworkCore.Sqlite version 2.0.1.

Out of curiosity, looking at something here, you can change
this:
x => x.SuppressForeignKeyEnforcement ()
by:
x => x.SuppressForeignKeyEnforcement (false)

@ralmsdeveloper no difference :(

I believe @bricelam, have any idea about this.

Breaking change as per #7527
In 1.1 EF used to send out PRAGMA command whenever connection internally opened in EF Core. With 2.0 release, we send out command only if the connection actually gets opened. In this case since you are passing open connection, we do not send PRAGMA command.
While I am leaving this open so that we can discuss in the meeting if this was intentional breaking change. But it is highly likely that if user is giving us open connection, user is also responsible to set any special things need to be set in connection.

I tried out to open connection after configure the dbcontext but SuppressForeignKeyEnforcement is still validating FKs.

If you are passing an open connection to DbContext using UseSqlite then order of dbcontext configuration does not matter. You are supposed to configure the connection yourself whenever you want.

We discussed this in triage and decided that the current behavior is correct. That is, if EF opens the connection, then EF will send a PRAGMA based on the value of SuppressForeignKeyEnforcement. This is true regardless of whether or not EF created the connection. However, if the application opens the connection, then it is the responsibility of the application to send any pragmas desired for that open connection.

Got it.


Update README.md

The client is a spring-boot app, therefore camel:run doesn't work

Thanks for the PR it has been merged. Do you mind closing this?


Rustup to rust-lang/rust#97447

Fixes #316
Signed-off-by: Yuki Okushi<EMAIL_ADDRESS>

@bors r+

:pushpin: Commit aa8ccf258e1cabc9f7e8af3a6c3b7da830188731 has been approved by JohnTitor

:hourglass: Testing commit aa8ccf258e1cabc9f7e8af3a6c3b7da830188731 with merge 127312f94a661509710cf51130f098c311aca043...

:sunny: Test successful - checks-actions
Approved by: JohnTitor
Pushing 127312f94a661509710cf51130f098c311aca043 to master...


0.0.25

Added

OpenCage Geocoding API

Fixed

#11

Changed

child_no to watch_ids

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Error

I get this error while running the generator script:
ERROR: marker not found - (} mainnet_hard_forks[] = {)[^;]+(};)

Maybe you have already finished with this a long time ago, but who will have an error,
check whether you have made your config file and changed it.
Remove core/monero.json from extensions in config file.
At least it worked for me.


Can't preview image file -- download in menu appends .txt file extention

OS: Linux
Version of IPFS Desktop https://github.com/ipfs-shipyard/ipfs-webui/commit/7a8f695

Describe the bug
I am looking at the Apollo archive (listed in the explore tab) at this image (on my local gateway)
http://<IP_ADDRESS>:8080/ipfs/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDEwIE1hZ2F6aW5lIDM1L1U=/21328560323_6b33f5d4c3_o.jpg
In the explore tab I also navigated to find the raw CID of the image, which is here (Qmdgqdddt3F2uszEaE7zph7kXbwHX3iTDCWeQjdtNGnQgz):
http://<IP_ADDRESS>:8080/ipfs/Qmdgqdddt3F2uszEaE7zph7kXbwHX3iTDCWeQjdtNGnQgz

Bug 1:
Using the Brose search bar up top for that CID gives:

The "Try downloading it instead." link correctly gives a .jpeg extension.

Bug 2:
BUT the ... More menu download yields a "Save As..." menu with a .txt file named the CID.

Bug 3:
I try to pin/unpin this to my node in the same menu, and receive an error:

Bug 4 :wink:
I can't find this on the GUI anywhere, though I am directed to by the issue template:
ATTACH LOGS

If possible:
1. Go to `Advanced` → `Open Logs Directory`
2. Find `*.log` files
3. Attach `error.log` and `combined.log` to this issue.

I only found the attached logs as I get the notification when I run the application from a terminal
info: [meta] logs can be found on ...../.config/IPFS Desktop

combined.log
2020-09-30T22:23:57.625Z info: [meta] logs can be found on /home/dan/.config/IPFS Desktop
2020-09-30T22:23:59.123Z info: [web ui] window ready
2020-09-30T22:23:59.125Z info: [web ui] navigate to /
2020-09-30T22:23:59.173Z info: [tray] starting
2020-09-30T22:23:59.233Z info: [tray] started
2020-09-30T22:23:59.234Z info: [ipfsd] start daemon STARTED
2020-09-30T22:24:00.988Z info: [daemon] PeerID is Qmb61NjeYWBAUHHfXdZQp2MED8XuXRWrRgrFDG4xtBTQvA
2020-09-30T22:24:00.989Z info: [daemon] Repo is at /home/dan/.ipfs
2020-09-30T22:24:00.999Z info: [ipfsd] start daemon FINISHED 1.7648615709999576s
2020-09-30T22:24:01.033Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-09-30T22:24:01.041Z info: [npm on ipfs] 1st time running and package is not installed
2020-09-30T22:24:01.048Z info: [launch on startup] disabled
2020-09-30T22:25:04.825Z info: [web ui] window hidden
2020-09-30T22:25:09.306Z info: [ipfsd] stop daemon STARTED
2020-09-30T22:25:09.591Z info: [ipfsd] stop daemon FINISHED 0.2849655619999394s
2020-09-30T22:25:09.602Z info: [ipfsd] start daemon STARTED
2020-09-30T22:25:12.081Z info: [daemon] PeerID is Qmb61NjeYWBAUHHfXdZQp2MED8XuXRWrRgrFDG4xtBTQvA
2020-09-30T22:25:12.082Z info: [daemon] Repo is at /home/dan/.ipfs
2020-09-30T22:25:12.082Z info: [ipfsd] start daemon FINISHED 2.4798767619999125s
2020-09-30T22:25:19.510Z info: [web ui] navigate to /
2020-09-30T22:25:21.520Z info: [web ui] navigate to /peers
2020-09-30T22:25:27.988Z info: [web ui] navigate to /settings
2020-09-30T22:25:35.808Z info: [web ui] window hidden
2020-09-30T22:25:39.293Z info: [ipfsd] stop daemon STARTED
2020-09-30T22:25:39.339Z info: [ipfsd] stop daemon FINISHED 0.04602136099990457s
2020-10-06T00:46:25.316Z info: [meta] logs can be found on /home/dan/.config/IPFS Desktop
2020-10-06T00:46:26.913Z info: [web ui] window ready
2020-10-06T00:46:26.914Z info: [web ui] navigate to /
2020-10-06T00:46:26.973Z info: [tray] starting
2020-10-06T00:46:27.028Z info: [tray] started
2020-10-06T00:46:27.028Z info: [ipfsd] start daemon STARTED
2020-10-06T00:46:29.373Z info: [daemon] PeerID is Qmb61NjeYWBAUHHfXdZQp2MED8XuXRWrRgrFDG4xtBTQvA
2020-10-06T00:46:29.374Z info: [daemon] Repo is at /home/dan/.ipfs
2020-10-06T00:46:29.374Z info: [ipfsd] start daemon FINISHED 2.3457141930013896s
2020-10-06T00:46:29.400Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-10-06T00:46:29.408Z info: [ipfs on path] no action taken
2020-10-06T00:46:29.410Z info: [launch on startup] disabled
2020-10-07T01:50:24.447Z info: [meta] logs can be found on /home/dan/.config/IPFS Desktop
2020-10-07T01:50:25.710Z info: [web ui] window ready
2020-10-07T01:50:25.711Z info: [web ui] navigate to /
2020-10-07T01:50:25.811Z info: [tray] starting
2020-10-07T01:50:25.860Z info: [tray] started
2020-10-07T01:50:25.861Z info: [ipfsd] start daemon STARTED
2020-10-07T01:50:26.143Z info: [daemon] removing api file
2020-10-07T01:50:27.602Z info: [ipfsd] start daemon FINISHED 1.7408583110049367s
2020-10-07T01:50:27.631Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-10-07T01:50:27.636Z info: [ipfs on path] no action taken
2020-10-07T01:50:27.639Z info: [launch on startup] disabled
2020-10-07T02:14:46.318Z info: [web ui] launching web ui
2020-10-07T02:22:28.788Z info: [web ui] window hidden
2020-10-07T02:22:36.966Z info: [web ui] launching web ui

error.log
2020-09-30T22:24:01.033Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-10-06T00:46:29.400Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-10-07T01:50:27.631Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'

I figured these were minor enough as I discovered them to group here, I can parse into separate issues if you see fit 🙏🏼


picture on artist page bugs when scrolling

Do you have the latest versions of Spicetify, Spotify and Better Bloom?

[X] I'm using the latest versions of Spicetify, Spotify and Better Bloom

Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Is your problem definitely caused by the theme?

[X] I have checked the app behavior without the theme and it is different

Environment & Computer Info
- Spotify version: <IP_ADDRESS>8.g0ea3f38b
- Installed from: Spotify site
- Spicetify version: 2.36.12
- Color scheme:
- Extensions:
- Custom apps:
- Better Bloom installation method: Spicetify Marketplace

Description

picture on artist page just like doesn't  move when scrolling

Screenshots

artist page when normal

when scrolling

sorry for the issue caused i will address it rn ! it only works when scrolled slowly i will make a fix for it

maaf atas masalah yang ditimbulkan, saya akan mengatasinya rn! ini hanya berfungsi ketika digulir perlahan saya akan memperbaikinya

Thank you so much


refactor: Remove sprintf-js dep in favor of logform only

Changes Unknown when pulling 4e600e8a032abb49c369c1d19c0179da5d7bfaa7 on refactor/sprintfjs into ** on master**.

Changes Unknown when pulling 5ebac8868e3b36451314149bb85da91467cad00e on refactor/sprintfjs into ** on master**.


Add AOT Support

I decided against adding compilation flags, as I'm not totally sure which platforms require AOT and which do not. Also, it would create a eternal maintenance point for the library, as new platforms are added, the lib would need to be updated each time to add another flag.

That's a valid point.


Config Policy Evaluator - component interface

Signed-off-by: Shlomit Koyfman<EMAIL_ADDRESS>Related to https://github.com/fybrik/fybrik/issues/794
This PR documents the interface of the config policy evaluator with the manager.

Great idea to do it this way!  See my comments


Revert tomlplusplus recipe revision pin

Description
An update to the Conan recipe for tomlplusplus meant that exceptions were disabled and there was no way to re-enable them, so we had to pin the recipe to the previous revision.
An upstream fix has now been pushed (conan-io/conan-center-index#24385), so we can revert the recipe revision pin.

Intentionally not reverting the allow-revisions variable? I suppose it dosen't hurt to leave it.

No that wasn't intentional. :thinking: In general I would say its useful global config to have, but since its explicitly specified as an env var it raises the question of "why?" to anyone reading it.  I'm of a mind to remove it.


Error messages not printed properly

When I try to read secrets from a vault that I forgot to setup an Access Policy for the service principal, it causes an error. However the error is not printed in the proper plugin format so you can't tell what's wrong
$ porter install -c myclaim --tag carolynvs/myapp:v0.0.3
installing myapp...
Error: could not load credentials: 3 errors occurred:
	* unable to resolve credential myapp.azure_client_id from secret myapp-client-id: could not connect to the secrets.porter.carolynvs plugin: Unrecognized remote plugin message:

This usually means that the plugin is either invalid or simply
needs to be recompiled to support the latest protocol.

We should reverify with this change
https://github.com/deislabs/porter/pull/1028


fixed Night mode problem #110

What changes you have made; can you please justify them with screenshots?

these are the two changes done by me
On Wed, 8 Feb 2023 at 21:18, Hritambhar Ray @.***>
wrote:

[image: Screenshot from 2023-02-08 21-18-29.png]
On Wed, 8 Feb 2023 at 17:47, Arpit Ghura @.***> wrote:

What changes you have made; can you please justify them with screenshots?
—
Reply to this email directly, view it on GitHub
https://github.com/arpitghura/typing-test/pull/114#issuecomment-1422504849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV2PR6VUKFDQVKT2MTALSXDWWOFFNANCNFSM6AAAAAAUTQOGAQ
.
 One thing you can do is reply with images over GitHub not in emails.

What problem does this PR solve?


Using Camellia 1.0 with Chromium Edge would cause the option page to display incompletely

When searching for a bookmark manager in GitHub, I was quite impressed by how Camellia fits my needs and gave it a try. The new tab looks pretty good with simple interface and clear listing of my tons of bookmarks
The only flaw I found is that when I want to configure the extension, the option window cannot display completely in my Edge browser. The most bottom of the option list I can reach is here (as the screenshot shown below), and the "save" button is beyond the option frame.

Currently I used F12 to expand the option window to reach the "save" button, so it does not cause much difficulty
for me, but it would be better if this could be fixed (or does not appear again in Camellia 2.0).
Thanks.

I close the issue because it was related to old Camellia. New Camellia officially announced and will be shipped soon, so the issue is irrelevant now.


Has the koa-vs-express document been finished?

The document koa/docs/koa-vs-express.md has a note at the top.

THIS DOCUMENT IS IN PROGRESS. THIS PARAGRAPH SHALL BE REMOVED WHEN THIS DOCUMENT IS DONE.

Is the document done so this header can be taken off? Is there anything else that should be added before removing this header?
EDIT: linked the document above

Yea I think that header can be removed.


first pass at placing the HTTPS instructions in the app

It's still a little bit messy but I think that this UI is a lot nicer for our users:

Add "HTTPS" as the 3rd getting started step. Makes opening the app for the first time a little bit less overwhelming.
Shortens up the instructions and embeds a youtube video screencast
Displays checkmarks depending on whether the app is running as HTTPS and whether the certificate is installed on the system (which is done by fetching against the connector.plot.ly/secure and parsing the result)

Still some things to work out that I'll leave to you @alexandresobolevski :

Check out the commit for several inline TODOs
Clicking "run" sometimes causes that JS address already in use error
The fetch logic to check if the certificates are installed doesn't seem to quite work right yet.
Replace the /secure instructions page with a nice /status page that users can visit to check if their app is running on HTTPS
Remove the rest of the static HTML server assets - the images and the unused HTML

In general, the code is looking really good and is pretty easy to understand and navigate! A few things that came up:

Can we rename callback inside messageHandler to be more descriptive? it took me a while to figure out how messages were actually being sent to the front-end
Can we move all of the backend files into a folder called backend instead of keeping them in the root directory? This includes main.development.js. Maybe we can re-name App to be frontend too.
I found it a little confusing to know what is actually available in IPC since functions deep down inside our backend end up determining that front-end state. could we add a comment comment in reducers/ipc.js that describes the state? I started one of them.

[x] Check out the commit for several inline TODOs
[x] Clicking "run" sometimes causes that JS address already in use error
[x] The fetch logic to check if the certificates are installed doesn't seem to quite work right yet.
[x] Replace the /secure instructions page with a nice /status page that users can visit to check if their app is running on HTTPS
[x] Remove the rest of the static HTML server assets - the images and the unused HTML
[x] Can we rename callback inside messageHandler to be more descriptive?
[x] Comment in reducers/ipc.js that describes the state


Including @vueuse causes the vue instance to initialize twice @4.0.0-beta.4

This took me a while to track down, but after upgrading to @4.0.0-beta.4 my whole app started throwing a million errors as the main instance got initialised twice.
I used @4.0.0-beta.2 fine.
Not even sure how to describe this bug.
The library has great potential! Thank you for your work. I only use one function from it so i will be removing it for now.
I wish i could provide a simple bug, but at the moment we're in crunch mode to launch production and this has cost me 2 days already :(
I might return back with a proper issue once i have time.

Which one are you using?

beta.2 was working fine, beta.4 broke it and for some reason i can't get it to work even after downgrading it :(

@Neophen Can you show me the error logs so I can better help with this? and which utilities are you imported from vueuse? Thanks

"@vue/composition-api" should put in to peerDependencies not dependencies in package.json. Otherwise, It will throw an error by initializing twice if your project  in use composition-api. @antfu

Can you try with the latest version? I don't think we have vca in our dependencies.

Can you try with the latest version? I don't think we have vca in our dependencies.

I can see Vue.use(VueCompositionAPI) in vue-demi. Due to vueuse vca is put in dependencies , if vueuse-vca version is different form project-vca it will download in node_module/vueuse/node_module/@vue/composition-api

Neither VueUse nor Vue Demi have @vue/composition-api in dependencies. And Vue Demi does have a mechanism to prevent duplicated installation.
https://github.com/antfu/vueuse/blob/38e304c48b708c6e4ff2c1ce19de9ec6f4fd5c02/packages/core/package.json#L29
https://github.com/antfu/vue-demi/blob/d43e2e6906677c1629fc2db79ecbd1854931ea9a/package.json#L17
Please be sure to use the latest version of VueUse and Vue Demi. If you have multiple packages installed, you should consider rebuilding your lock file to keep them up-to-date.
Close this for now as the original issue does not seem to be active. If the problem still occurs to you, please open another issue with a minimal reproduction.

OK, Thanks a lot


Fix crash in NSValue.isEqual() when it is passed an NSNumber

NSNumbers are not added to the side table, so we can't find them.
I don't think that NSValue.isEqual() is correct in general, but this gets us closer to the correct implementation and unblocks https://github.com/apple/swift/pull/4621 . For example, subclasses that have custom storage -- like NSNumber -- should compare equal to an NSValue as long as they have the same bytes and the same type, but the current implementation of NSValue.isEqual() can only return true if two references are equal.
Note: this issue blocks https://github.com/apple/swift/pull/4621 (after we change the hashing algorithm, the test TestNSKeyedArchiver.test_archive_set starts to compare NSValue to NSNumber where it previously wasn't doing that just because we got lucky in the hash table order).

@phausler @itaiferber Could you review, please?

@swift-ci Please test


Speech: Expose the GAPIC client config on the manual layer.

This PR is a response to #3165 but I somewhat doubt we should take it exactly as-is. This is meant to be a discussion starter.
Context
Definitely go read #3165 to understand the whole thing, but the basic situation is that the OP had a problem with the Speech API that he got around by overriding the GAPIC client_config. He did this by modifying the actual JSON file in the installed GAPIC, which probably is something we should not force our users to do.
Solution
The first and most obvious thing we should do is set a more sane default for this one configuration option in Speech. I am going to do that momentarily.
Additionally, I assert that we should expose the client_config as an option in our Client classes, so that our users do have the option to override these things.
This PR makes this change only for Speech, which is almost certainly the wrong final solution. Either we should do this in every API that depends on a GAPIC or we should do it in none of them. I wanted to put this in place so we can see what the solution looks like and discuss whether it should be done everywhere or nowhere. (If we do it everywhere, then the self._client_config part in Speech's Client class would migrate into core.)
Discussion
Should we do this?

@dhermes Can I get some feedback on the substance of the change? :-) As noted in the text, I am not sure whether we should actually do this.

@lukesneeringer Sorry I didn't notice the text.
ISTM a better option would be to take the entire GAPIC client as an optional Client argument? It's strange having constructor args that only apply to one of the transports.

@lukesneeringer I 2nd @dhermes. We should also test to see if this is happening on the HTTP side as well.  If it is, I'm not sure how to pass the config parameters?

@dhermes I like that idea. Sold.

So, the API would look something like...
class Client(BaseClient):
    def __init__(self, credentials=None, http=None, gapic=None, use_gax=None):

I have to say I am kind of not a fan of a separate http and gapic argument, only one of which makes sense based on the ultimate _use_gax value. But, I hate backwards-incompatible changes more, so I think that ship has sailed.
(Also, it is a crying shame that we use the terms "gapic" and "gax" nearly interchangably, but that ship has also sailed.)
Should it be spelled gapic or gapic_client? The former would match http but the latter would be clearer.

@lukesneeringer Why don't we bring the ship back to harbor? I'm fine dumping usage of GAX (GAPIC was not a term in use when the first use_gax argument was added).
I'm also fine overloading what WAS http as transport_object and then verifying that object based on which transport has been chosen.

Editor's Note: Pulling this discussion into a chat for expediency.

Discussed with @dhermes offline and we decided to punt on this question.
Summary:

We should fix the default client config for Speech. (googleapis/googleapis#297)
We should take a custom GAPIC, but we are not quite sure yet how we want that to look, based on possible features that we hope the GAPICs will get in Q2.


qemu: nios2: Enable UART 16550 driver for QEMU

Enable UART 16550 driver for Nios-II QEMU platform.
Note: This PR is tested with patched version Qemu 3.0.0 which
adds support for altera_10m50_zephyr machine type.
Signed-off-by: Ramakrishna Pallala<EMAIL_ADDRESS>

Note: This PR is tested with patched version Qemu 3.0.0 which
adds support for altera_10m50_zephyr machine type.

you have the patch?

"
Note: This PR is tested with patched version Qemu 3.0.0 which
adds support for altera_10m50_zephyr machine type.
you have the patch?
"
Yes Anas, i have the patch, I can attach it in the bug.

@nashif now the PR has support for both Jtag and NS16550 uarts and by default, we have selected jtag uart which is working with current SDK.
If we need to select ns16550, we have to change the following line in boards/nios2/qemu_nios2/qemu_nios2.dts:

zephyr,console = &jtag_uart;

zephyr,console = &ns16550_uart;

rebase please @ramakrishnapallala

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@461a9de). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #9979   +/-   ##
========================================
  Coverage          ?   52.5%
========================================
  Files             ?     213
  Lines             ?   26140
  Branches          ?    5634
========================================
  Hits              ?   13726
  Misses            ?   10159
  Partials          ?    2255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461a9de...d219d7b. Read the comment docs.


Problem to include pagination in an other controller

Hello,
I have a problem only when I try to include a controller with pagination, in another.
{% block product %}
    		{% render "ShopBundle:Product:list" %}
    	{% endblock %}
An exception has been thrown during the rendering of a
template ("Route "_internal" does not exist.") in KnplabsPaginatorBundle:Pagination:sliding.html.twig at line 20.
I use symfony2 master branch, Have you ever seen this problem?
Thanks

I will add exception for that, _internal route cannot be handled. Now you can setRoute for the pagination to use in the view


derpibooru completion

Feel free to reject this.

It looks good, but I'm not sure if I want to include it in the main repo since to my knowledge pretty much only pony-diffusion was trained on derpibooru tags compared to multiple big models for danbooru and e621, and e621 also has a decent amount of tag overlap to it. So I don't know how much the average user would get out of it (feel free to correct me on this point).
So I would rather suggest posting it in the Discussions, or we could also add a custom tags section to the readme where you can link to it.

🤷 might as well fork entirely


OpenShift Support

Describe your problem
As a Platform Ops Engineer I would like to make use of Kpt within a OpenShift 4x cluster along with  having the ability to make use of LDAP for authentication.

@regicsolutions Support for OpenShift is probably not something that will be prioritized by the kpt team, but we are happy to provide support and assistance if you or anyone else wants to contribute to kpt.


Release Google.Cloud.BeyondCorp.AppConnectors.V1 version 1.3.0

Changes in this release:
New features

Add IServiceCollection extension methods for client registration where an IServiceProvider is required. (commit 022fab2)

Created release for Google.Cloud.BeyondCorp.AppConnectors.V1-1.3.0


Integration Test - Release - 2020/12/15 02:54:59

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


xfreerdp/clipr: fix self owned test and hardening

xf_cliprdr_is_self_owned() lied if multiple xfreerdp instances were running.
fixed a few unchecked callocs
added/modified and handled some return values in compliance with the new hardened channel api

+1 LGTM


Nest Back up and Restore Data in side nav

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b96c28f6cfcebb7e372b79a8dd3eddffee092d0b/


Please, add coquicash icon

Hi, i work for the komodo platform team and would like to have the coquicash logo added to the icon pack. Here is the file, can tip for addition. Thanks!

@siulynot can you host the SVG version and link that here too?

Since github doesnt allow svg file upload, here i attach a .zip with the .svg version.
coqui.svg.zip

Since github doesnt allow svg file upload, here i attach a .zip with the .svg version.
Uploading coqui.svg.zip…

Added - thanks for the images

Thank you for your support. If you’d like to tip me for my time in maintaining and updating this project, it would be very much appreciated.


testing: no tests to run warning when running benchmarks

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version devel +517a44d Tue Oct 25 12:23:49 2016 +0000 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/mvdan/go"
GORACE=""
GOROOT="/home/mvdan/tip"
GOTOOLDIR="/home/mvdan/tip/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build943520682=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
go test -run='^$' -bench=. on a package of mine with benchmarks.
What did you expect to see?
 $ go test -run='^$' -bench=.
BenchmarkFprint-4         300000              5056 ns/op
PASS
ok      github.com/mvdan/sh/printer     1.574s

What did you see instead?
 $ go test -run='^$' -bench=.
testing: warning: no tests to run
BenchmarkFprint-4         300000              5056 ns/op
PASS
ok      github.com/mvdan/sh/printer     1.574s [no tests to run]

The [no tests to run] doesn't bother me, but the extra line at the beginning does. I think this should be turned off if any benchmarks are run.
Happy to submit a patch today if this makes sense.

CC @rsc @mpvl

I'm fine with turning this off when running benchmarks.

Cool, will send a CL soon.


Accents in script path

Hello,
I was wondering if there is a way to execute a powershell script containing accents in the path with the addCommand method.
A path like C:\Users\Léonie Pamaton\src\scripts.ps1
Thanks for your answer

ps.addCommand(& "${require('path').resolve(__dirname, ./scripts.ps1)}")
This will work if its running from the same path. You will need to configure it otherwise to for the path you specified.
Look into require(path)

You can also do this
const user = 'david.charles'
ps.command(`

Get-AdUser -identity ${user}
`)

So just copy paste your script, this way you don't even have to use params if you're using a server or running locally.


The content is covered by the banner

Describe the bug
The content is covered by the banner and also scrolling the text it's not possible to read the last part.
The problem was reproduced with this demo(https://github.com/capacitor-community/admob/tree/master/demo/angular) on the iPhone 11
Screenshots

Smartphone (please complete the following information):

Device: iPhone11
OS: iOS14

I had the same problem, the code provided in https://github.com/capacitor-community/admob/issues/10#issuecomment-694441518 fixed my problem.

I had the same problem, the code provided in #10 (comment) fixed my problem.

unfortunately that code does not solve the problem definitively there are always parts covered

What I did before with Cordova and also do here is to have a component below the main content which reacts dinamically to the height of the banner. In that way I am sure that no content is hidden in all screen sizes.

the problem is only on iPhone x (all iPhone without the home button). I believe the problem was caused by an incorrect calculation of the safe-area-inset-bottom

the problem is only on iPhone x (all iPhone without the home button). I believe the problem was caused by an incorrect calculation of the safe-area-inset-bottom

Yes, you are right! Have the same on my iPhone 11 ...
I found a (quite hacky) solution for this:
this.eventOnAdSize = AdMob.addListener('onAdSize', (info: any) => {
        const appMargin = parseInt(info.height, 10);

        if (appMargin > 0) {
          const bodyStyles = window.getComputedStyle(body);
          const safeAreaBottom = bodyStyles.getPropertyValue("--ion-safe-area-bottom");

          const app: HTMLElement = document.querySelector('ion-app');
          app.style.marginBottom = `calc(${safeAreaBottom} + ${appMargin}px)`;
        }
      });

the problem is only on iPhone x (all iPhone without the home button). I believe the problem was caused by an incorrect calculation of the safe-area-inset-bottom

Yes, you are right! Have the same on my iPhone 11 ...
I found a (quite hacky) solution for this:
this.eventOnAdSize = AdMob.addListener('onAdSize', (info: any) => {
        const appMargin = parseInt(info.height, 10);

        if (appMargin > 0) {
          const bodyStyles = window.getComputedStyle(body);
          const safeAreaBottom = bodyStyles.getPropertyValue("--ion-safe-area-bottom");

          const app: HTMLElement = document.querySelector('ion-app');
          app.style.marginBottom = `calc(${safeAreaBottom} + ${appMargin}px)`;
        }
      });

Thank you for the tip. It seems to work fine with ion-router-outlet too
this.eventOnAdSize = AdMob.addListener('onAdSize', (info: any) => {
          this.appMargin = parseInt(info.height, 10);
          if (this.appMargin > 0) {
            const body = document.querySelector('body');
            const bodyStyles = window.getComputedStyle(body);
            const safeAreaBottom = bodyStyles.getPropertyValue("--ion-safe-area-bottom");

            const app: HTMLElement = document.querySelector('ion-router-outlet');
            if (this.bannerPosition === 'top') {
              app.style.marginTop = this.appMargin + 'px';
            } else {
              app.style.marginBottom = `calc(${safeAreaBottom} + ${this.appMargin}px)`;
              //app.style.marginBottom = this.appMargin + safeAreaBottom + 'px';
            }
          }
        });

I found, that the problem still is there for toasts and action-sheets ... I try to solve this by changing the swift code with reference to https://github.com/admob-plus/admob-plus, but I'm not that into native iOS programming 😀

For action-sheets and toasts the definitive solution is to hide the banners during use.
I have inserted the following code in my css as a workaround:
// fix admob actionsheet
ion-action-sheet.ios .action-sheet-wrapper {
    margin-bottom: 84px !important;
}

ion-action-sheet.md .action-sheet-wrapper {
    margin-bottom: 54px !important;
}

Yes, that's correct but I don't find the solution very satisfying.
I just recently moved from cordova to capacitor and I used cordova-admob-plus before. I had no styling problems at all with it. But I do not know what is done differently there.

@fabmesto Thanks for great suggestion. I will check this👍

@NLueg I don't know how to work cordova-admob-plus. But this is not issue of plugin. The processing on the web sholud to be in the web.

Thanks issue. I changed demo code:
https://github.com/capacitor-community/admob/blob/master/demo/angular/src/app/home/home.page.ts#L70-L84

Thanks issue. I changed demo code:
https://github.com/capacitor-community/admob/blob/master/demo/angular/src/app/home/home.page.ts#L70-L84


NixOS option defaults referring to store paths should display in manual

Relevant: 89e983786a4e2cf6dd238af4df6da373cc01e62b #10036

Maybe something like:
  mkOption {
    default = "${pkgs.xxx}";
    default-for-manual = "\${pkgs.xxx}";
  }

That would be bad due to the code duplication.

We might do the context discarding as before 5b8dae8ef3 and then delete /nix/store/hash- substrings (during eval-time). It would likely be relatively expensive, unless we restrict it to the beginnings of defaults, but that seems to be vast majority in 89e9837.
Perhaps a cleaner way would be to have something like "${config.sanitizeDrv pkgs.foo}/bar/baz". The sanitizeDrv function would normally be an identity but for manual it would e.g. return .name instead (or perhaps some other hack in case the argument didn't have .name, e.g. the same strategy of discarding context and deleting hash).

How about evaluating the manual with pkgs = mapAttrs (name: value: "\${pkgs.${name}}") pkgs?

Yeah, that's probably the best way (so far) to cover most cases.

@vcunat removing the /nix/store/hash- would only remove one of the issues, which is that the manual contains references, but this does not solve the problem which is that the manual is rebuilt when you generate your configuration.
The sanitizeDrv sounds like an interesting idea, except that you probably expect to have a string input for the documentation.
@Mathnerd314 This sounds like a good idea! Are you interested in taking this issue?

@nbp: I meant to strip the dependencies at evaluation time, i.e. the same derivation would be generated if only the hashes have changed, I believe.

Implementation: #12357.


Can this be used for augmented reality?

World tracking, for example.

Hey marcusx2. I don't know if you found this yet, but De-Panther has a fork that implements AR: https://github.com/De-Panther/unity-webxr-export


Can't register an Error event to determine what went wrong

Related to GH-24
cover.js in that example, will not tell me what went wrong. It will fail silently.
Ideally, I could do:
var instance = coveraje.cover(
  "console.log('1'); var foo = require('./hi.js'); console.log('2');",
  function (context, inst) {
    console.log(context.module.exports);
  },
  { globals: "node", colorizeShell: false }
);

instance.on('error', function (err) {
  // do whatever i want with err.
});

or use the onError callback, whatever.
For this to work though, the runInConsole() function would need to be deferred.
Alternatively, if the API were restructured it could look something like:
var cover = new Coveraje({ global: "node" });
cover.on('error', function () { });
cover.on('done', function () {
   // \o/ We're done!
});

// context is returned from this function.
var context = cover.run(fs.readFileSync('etc.js'));

Thoughts?

Hmmm, I have to think about a redesign..
For now, I added an onError-Parameter to the cover()-function.
It's not well tested, yet (I'll try to catch up *g*)

that's fair for now.


[WIP] Introduce Arcan

Motivation for this change
From arcan(1):

Arcan is a portable and fast self-sufficient multimedia engine for advanced visualization and analysis work in a wide range of applications e.g. game development, real-time streaming video, monitoring and surveillance, up to and including desktop compositors and window managers.

This is a work in progress, expect force pushes to my repository.
Things written

[x] Built with all relevant dependencies

[x] Arcan
[x] Xarcan

[x] Written expressions for selected appls

[x] Durden
[x] Pipeworld

[ ] Create security wrapper for Arcan
[ ] Write documentation describing Arcan's optional dependencies.

How Things is built

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a work in progress, expect force pushes to my repository.

It's easy to miss, but there's a way to mark the PR as a draft (which will free you from worrying about anyone merging it). Before you open the PR, it's hiding under the drop-down button attached to the create buton. After creation, there's an option under the "Reviewers" section in the sidebar to convert it.

It's easy to miss, but there's a way to mark the PR as a draft (which will free you from worrying about anyone merging it). Before you open the PR, it's hiding under the drop-down button attached to the create buton. After creation, there's an option under the "Reviewers" section in the sidebar to convert it.

Thanks for the tip! I've done it now.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/problems-statically-link-luajit/13130/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/problems-building-xarcan/13133/1

First things first: Welcome to Nix Packages! 🎊🥳🥳
I will be your guide.
Next thing next: please, put everything inside stdenv.mkDerivation rec {. This is the "nixpkgs way" of doing the things here. Indeed it is almost impossible to review your code without rewriting it first. There are many fine points I need to point you out.

First things first: Welcome to Nix Packages! confetti_ballpartying_facepartying_face
I will be your guide.
Next thing next: please, put everything inside stdenv.mkDerivation rec {. This is the "nixpkgs way" of doing the things here. Indeed it is almost impossible to review your code without rewriting it first. There are many fine points I need to point you out.

Done!
With the exception of having the name; gitCommit; and the srcs attributes in a let expression. This seems to be the correct way in nixpkgs after doing some searches in the codebase.
Note the use of gitCommit is a temporary measure while needing to be on HEAD @ master. And in the future we'll hopefully not need the arcan-openal dependency (there's a fork of openal that upstream plan to use instead).
The comment marks in the attribute set that's Arcan's parameter is for (currently unwritten) documentation what the different optional dependencies enables. I haven't seen this done in nixpkgs, but I think this is a good idea.
Statically link the dependencies listed in the OP isn't strictly necessary, and is primarily done for my education. But it enables Arcan to function in more restricted environments. It's possible that I'll scrap that part when I figured out how to statically link Luajit.

@a12l
About desktopItems, this is not hard.
Just look how dirdiff implements this:
https://github.com/NixOS/nixpkgs/blob/8284fc30c84ea47e63209d1a892aca1dfcd6bdf3/pkgs/tools/text/dirdiff/default.nix
Focus on the lines 12, 37-46.

When I apply the patch
diff --git a/pkgs/development/libraries/arcan/default.nix b/pkgs/development/libraries/arcan/default.nix
index 1682d3206a1..23d9b1f93cc 100644
--- a/pkgs/development/libraries/arcan/default.nix
+++ b/pkgs/development/libraries/arcan/default.nix
@@ -90,10 +90,13 @@ in stdenv.mkDerivation rec {
   src = srcs.arcan;

   postUnpack = ''
-    # ln -sv ${luajit.src} $sourceRoot/external/git/luajit
-    ln -sv ${freetype.src} $sourceRoot/external/git/freetype
-    ln -sv ${srcs.openal} $sourceRoot/external/git/openal
-    ln -sv ${libuvc.src} $sourceRoot/external/git/libuvc
+    mkdir -p $sourceRoot/external/git/{luajit,freetype,openal,libuvc}
+    pushd $sourceRoot/external/git/
+    # cp -r ${luajit.src}/* luajit
+    # cp -r ${freetype.src}/* freetype/
+    cp -r ${srcs.openal}/* openal/
+    # cp -r ${libuvc.src}/* libuvc/
+    popd

     # Generate manpages
     pushd $sourceRoot/doc/

I get the following error when I try to build arcan
$ nix-build -A arcan
this derivation will be built:
  /nix/store/9z7sw5chiaw4rgas70892hjirkl8v4b3-arcan-0.6.1pre1+unstable=2021-05-27.drv
building '/nix/store/9z7sw5chiaw4rgas70892hjirkl8v4b3-arcan-0.6.1pre1+unstable=2021-05-27.drv'...
unpacking sources
unpacking source archive /nix/store/v066ac46wkrkgr4n4l93yx666vnlb83f-source
source root is source
/build/source/external/git /build
/build
/build/source/doc /build
/build
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file source/tests/security/shmpuncher/shmpuncher.c
patching sources
configuring
fixing cmake files...
/nix/store/yb03if8wrzdzd4f4rnmaxkj7mr58l0w5-cmake-3.19.7/nix-support/setup-hook: line 10: ./external/git/openal/utils/alsoft-config/CMakeLists.txt.tmp: Permission denied
error: builder for '/nix/store/9z7sw5chiaw4rgas70892hjirkl8v4b3-arcan-0.6.1pre1+unstable=2021-05-27.drv' failed with exit code 1

Do you have any suggestion of how to solve it?

This is certainly something about writing permissions. Try a chmod -R 777 on the relevant dir and report us if it runs OK.

This is certainly something about writing permissions. Try a chmod -R 777 on the relevant dir and report us if it runs OK.

That did it! Thanks!

@SuperSandro2000 Thanks for your review! I've changed the code in some places that you asked for. But some of your suggestions straight up add bugs to the code, so I would like for you to clarify why I should do those things.

@SuperSandro2000 I've now defined
preBuild = ''
    # Generate manpages
    pushd $sourceRoot/doc/
    mkdir mantmp
    ruby docgen.rb mangen
    popd
  '';

in arcan/default.nix, and commented out the lines in postUnpack. My problem is that I now can't build Arcan.
$ nix-build -A arcan
this derivation will be built:
  /nix/store/v878zfm34f5w64pz5xfjmsz9x40ncgxn-arcan-0.6.1pre1+unstable=2021-06-02.drv
building '/nix/store/v878zfm34f5w64pz5xfjmsz9x40ncgxn-arcan-0.6.1pre1+unstable=2021-06-02.drv'...
unpacking sources
unpacking source archive /nix/store/l7cm2dkvza7q19lmiy92r97wn53k5c96-source
source root is source
/build/source/external/git /build
/build
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file source/tests/security/shmpuncher/shmpuncher.c
patching sources
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/share/doc/arcan -DCMAKE_INSTALL_INFODIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/include -DCMAKE_INSTALL_SBINDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/7m6p435s1c9ysfs266n9ppfw9zkii697-binutils-2.35.1/bin/strip -DCMAKE_RANLIB=/nix/store/7m6p435s1c9ysfs266n9ppfw9zkii697-binutils-2.35.1/bin/ranlib -DCMAKE_AR=/nix/store/7m6p435s1c9ysfs266n9ppfw9zkii697-binutils-2.35.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02 -DBUILD_PRESET=everything -DISTR_TAG=Nixpkgs -DENGINE_BUILDTAG=0.6.1pre1+unstable=2021-06-02+Nixpkgs ../src

Build Presets:
        -DBUILD_PRESET=everything client

Audio/Video/Input Support:
        -DVIDEO_PLATFORM=egl-dri, sdl, sdl2, egl-gles
        -DAGP_PLATFORM=gl21, gles2, gles3, stub

VIDEO_PLATFORM=egl-dri options:
        -DHYBRID_SDL=[Off|On] - Enable arcan_sdl output build
        -DHYBRID_HEADLESS=[Off|On] - Enable arcan_headless output build

Cmake Options:
        -DCMAKE_BUILD_TYPE=[Debug|Release|Profile|DebugTrace]
        -DENABLE_WALL_SPAM=[Off|On] - More build warnings
        -DENABLE_SIMD=[On|Off] - Enable SIMD optimized instructions
                -DSIMD_ALIGNED=[Off|On] - SIMD support assumes 16-byte alignment
        -DENABLE_LTO=[Off|On] - Build with Link-Time Optimizations

Dependency Management:
        -DSTATIC_SQLite3=[Off|On] - In-source SQLite3
        -DSTATIC_OPENAL=[Off|On] - In-source OpenAL, see external/README
        -DSTATIC_FREETYPE=[Off|On] - In-source Freetype
        -DSTATIC_LIBUVC=[Off|On] - In-source libuvc

Optional engine flags:
        -DENABLE_LWA=[Off|On] - Build LWA Arcan client (nesting support)
        -DDISABLE_JIT=[Off|On] - Don't Link with luajit51 (even if found)
        -DBUILTIN_LUA=[Off|On] - Static build lua51 (with disable_jit)
        -DNO_FSRV=[Off|On] - Build Arcan without support for frameservers
        -DSHMIF_DISABLE_DEBUGIF=[Off|On] - Remove server- controlled debug layer

Frameserver flags:
Decode:
        -DFSRV_DECODE_UVC=[Off|On] - Add support for libuvc- USB video cameras
Terminal:
        -DFSRV_TERMINAL_NOEXEC=[Off|On] - Lock down 'exec' path from scripts

Install / Autodetection Overrides:
        -D(DISABLE_FSRV_ (encode, decode, net, remoting, terminal, game)=ON
        -D(APPL_DEST, RES_DEST, APIMAN_DEST, MAN_DEST, SCRIPTS_DEST)=/some/path

------------- Configuration Results ---------------

-- Stage 1: dependencies and configuration
evdev           libxkbcommon
linux-usb       detected

---- Configuration results:
compiler        GNU
video           egl-dri
                        +support sdl platform
                        +support headless platform
accel           gl21
audio           openal
input           evdev
headless        egl-dri-rnode
lua             luajit51 dynamic

-- Stage 2, Frameservers and external clients
(a12)  ffmpeg support found, H264 enc/dec enabled
wayland support enabled
game/retro      3D support (lwa)
(decode) addding support for  text-to-speech
(decode) adding support for  probe (libmagic)
encode+opts     tesseract+leptonica(ocr) vnc
encode-opts
remoting support:       a12 vnc
frameservers    terminal game net decode encode encode remoting avfeed

-- Stage 3, LWA Build

-- Stage 4, Linking / Packaging (=>/nix/store/2aiiw26m99lkfin6cv0grs9a32b08c28-arcan-0.6.1pre1+unstable=2021-06-02)
-- Appending sdl platform build--
-- Appending headless platform build--
egl-dri+privsep installing SUID
API- manpages   no mantmp, run ruby docgen.rb in arcan/doc

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025
    ISTR_TAG

-- Build files have been written to: /build/source/build
cmake: enabled parallel building
building
/nix/store/lgp6bl9sjqd7frsr6szcq82b51ayp9y1-stdenv-linux/setup: line 82: pushd: source/doc/: No such file or directory
error: builder for '/nix/store/v878zfm34f5w64pz5xfjmsz9x40ncgxn-arcan-0.6.1pre1+unstable=2021-06-02.drv' failed with exit code 1

@SuperSandro2000 @AndersonTorres The PR is almost finished. The only thing left is adding a security wrapper. Could you please make a final review before merging?

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 123287 run on x86_64-linux 1

4 packages built:

arcan
durden
pipeworld
xarcan

Looks like this and more was merged in #128970 . I haven't checked individual files, but that merge seems to be a superset of this one. Don't want to underplay sustained efforts of @a12l , but I think this can be closed now?

Looks like this and more was merged in #128970 . I haven't checked individual files, but that merge seems to be a superset of this one. Don't want to underplay sustained efforts of @a12l , but I think this can be closed now?

Yes, it seems that @AndersonTorres choose to merge his PR.


PR for issue #38

Coverage increased (+0.02%) to 20.89% when pulling 8c0af80726212795af707122ce2a77d5368d8497 on thliebig:master into bc744e660b3f3eff651e53d9321a009d7c19e81e on hgrecco:master.

Thanks a lot!

@hgrecco How do you test use your development version of pyvisa-py? I had to run python setup.py install after every change to test it, otherwise pyvisa would always use the installed version of pyvisa-py only...

I have an isolated virtualenv with a symlink in to my development folder.

You can use python setup.py develop. When doing so only a link to your development folder is added to pythonpath.


Adjust heading class styles

Prevent <h5> and <h6> styles from leaking into .h1, .h2, .h3, and .h4 classes. Fixes #783
Additions

Add letter-spacing and text-transform overrides for .h1, .h2, .h3, and .h4 classes.

Testing

Pull branch and follow https://github.com/cfpb/capital-framework/blob/canary/CONTRIBUTING.md#testing-components-locally

Screenshots
Before

After

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

Dan, this is very exciting!!! Yeah open source!
Can you share more about what happened with the before state? Example code for context? I don't think our uppercase / text-shadow css should be affecting headings other than h5 and h6 like that, just want to make sure I understand the problem you're solving here!

OK I'm reading the bug now which has more info! My bad :)

We JUST recently removed that text-shadow from the h5/h6 so if that affects the code here you can take that into account.

@dcmouyard this looks good, tested it on a branch on origin and Travis passes fine so I think that failure is something we're going to have to deal with on our end. Before we merge it, can you add an entry to the changelog. Take a second to check out an example from this merged PR to understand the format that the release bot can ingest. You're change would be the same component and [PATCH] flag with the obvious change to the description.

Travis failure is due to our script not supporting PRs from forks, unfortunately. Merging!