gst_all_1.gst-plugins-bad: adds voaacenc support

Motivation for this change
Adds vo-aacenc packaging and add support for voaacenc in gstreamer-plugins-bad
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113822 run on x86_64-linux 1

7 packages marked as broken and skipped:

gnome3.gnome-books
gnome3.gnome-documents
libsForQt512.kdenlive
libsForQt514.kdenlive
openmodelica
termplay
xmonad_log_applet

12 packages failed to build and already failed to build on hydra master:

citrix_workspace: log was empty
(citrix_workspace_21_01_0): log was empty
citrix_workspace_20_04_0: log was empty
citrix_workspace_20_06_0: log was empty
citrix_workspace_20_09_0: log was empty
citrix_workspace_20_10_0: log was empty
citrix_workspace_20_12_0: log was empty
gnunet-gtk: plain log  |  pretty log
gtkd: log was empty
ib-controller: log was empty
libsForQt512.dragon: log was empty
tilix: log was empty

1 package failed to build and are new build failure:

fractal: plain log  |  pretty log

293 packages built:

adapta-gtk-theme
almanah
apostrophe
aravis
areca
astroid
audio-recorder
azureus
balsa
baresip
birdfont
bookworm
brasero
brasero-original
bubblemail
byzanz
calls
cawbird
chrome-gnome-shell
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
claws-mail-gtk3
cog
denemo
dropbox-cli
eclipse-mat
eclipses.eclipse-committers
eclipses.eclipse-cpp
eclipses.eclipse-java
eclipses.eclipse-modeling
eclipses.eclipse-platform
eclipses.eclipse-rcp
eclipses.eclipse-rust
eclipses.eclipse-scala-sdk
eclipses.eclipse-sdk
elementary-planner
empathy (gnome3.empathy)
enlightenment.rage
eolie
ephemeral
epiphany (gnome3.epiphany)
evince (gnome3.evince)
evolution
evolution-data-server (gnome3.evolution-data-server ,gnome3.evolution_data_server)
evolution-ews
evolutionWithPlugins
farstream
fcitx5-gtk
fcitx5-with-addons
feedreader
feeds
folks (gnome3.folks)
formiko
gajim
gcompris
gfbgraph (gnome3.gfbgraph)
glade (gnome3.glade)
glom
gmrender-resurrect
gnome-builder
gnome-keysign
gnome-network-displays
gnome-online-accounts (gnome3.gnome-online-accounts ,gnome3.gnome_online_accounts)
gnome-photos (gnome3.gnome-photos)
gnome-podcasts
gnome-recipes
gnome-tour
gnome3.bijiben (gnome3.gnome-notes)
gnome3.cheese
gnome3.devhelp
gnome3.file-roller
gnome3.geary
gnome3.gnome-applets
gnome3.gnome-boxes
gnome3.gnome-calendar
gnome3.gnome-clocks
gnome3.gnome-contacts
gnome3.gnome-control-center (gnome3.gnome_control_center)
gnome3.gnome-flashback
gnome3.gnome-initial-setup
gnome3.gnome-maps
gnome3.gnome-music
gnome3.gnome-online-miners
gnome3.gnome-panel
gnome3.gnome-screenshot
gnome3.gnome-session (gnome3.gnome_session)
gnome3.gnome-shell (gnome3.gnome_shell)
gnome3.gnome-software
gnome3.gnome-sound-recorder
gnome3.gnome-terminal (gnome3.gnome_terminal)
gnome3.gnome-todo
gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
gnome3.gnome-user-share
grilo-plugins (gnome3.grilo-plugins)
gnome3.gvfs
libgdata (gnome3.libgdata)
libgepub (gnome3.libgepub)
libzapojit (gnome3.libzapojit)
gnome3.nautilus
gnome3.nautilus-python
gnome3.polari
gnome3.pomodoro
gnome3.rygel
gnome3.seahorse
shotwell (gnome3.shotwell)
gnome3.sushi
gnome3.totem
tracker-miners (gnome3.tracker-miners)
webkitgtk (gnome3.webkitgtk)
yelp (gnome3.yelp)
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
gnucash
gnvim
gnvim-unwrapped
gscrabble
gst_all_1.gst-editing-services
gst_all_1.gst-plugins-bad
gst_all_1.gst-rtsp-server
gst_all_1.gst-vaapi
gthumb
gtk4
haskellPackages.reflex-dom
haskellPackages.webkit2gtk3-javascriptcore
ipscan
kicad-small
kicad-unstable-small
libhandy
libreoffice-fresh
libreoffice-fresh-unwrapped
libreoffice-qt
libreoffice-still
libreoffice-unwrapped (libreoffice-still-unwrapped)
libsForQt5.dragon (libsForQt515.dragon ,plasma5Packages.dragon)
libsForQt5.kdenlive (libsForQt515.kdenlive ,plasma5Packages.kdenlive)
libsForQt5.phonon-backend-gstreamer (libsForQt515.phonon-backend-gstreamer ,plasma5Packages.phonon-backend-gstreamer)
libsForQt5.telepathy (libsForQt515.telepathy ,plasma5Packages.telepathy)
libsForQt512.phonon-backend-gstreamer
libsForQt512.telepathy
libsForQt514.dragon
libsForQt514.phonon-backend-gstreamer
libsForQt514.telepathy
liferea
lispPackages.cl-webkit2
lispPackages.nyxt
lollypop
luakit
lutris
lutris-free
lutris-unwrapped
mailnag
mailnagWithPlugins
mapmap
marker
mate.atril
mate.mate-user-guide
mavproxy
meteo
midori-unwrapped
mmex
mopidy-iris
mopidy-local
mopidy-mopify
mopidy-mpd
mopidy-mpris
mopidy-musicbox-webclient
mopidy-scrobbler
mopidy-somafm
mopidy-soundcloud
mopidy-spotify-tunigo
mopidy-subidy
mopidy-tunein
mopidy-youtube
nasc
newsflash
notes-up
nyxt
odpdown
onboard
osmo
pantheon.elementary-calendar
pantheon.elementary-camera
pantheon.elementary-capnet-assist
pantheon.elementary-code
pantheon.elementary-greeter
pantheon.elementary-gsettings-schemas
pantheon.elementary-music
pantheon.elementary-onboarding
pantheon.elementary-photos
pantheon.elementary-session-settings
pantheon.elementary-videos
pantheon.extra-elementary-contracts
pantheon.notes-up
pantheon.switchboard-plug-a11y
pantheon.switchboard-plug-onlineaccounts
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-datetime
pantheon.wingpanel-with-indicators
parlatype
pdfpc
picard
pidgin
pidgin-carbons
pidgin-latex
pidgin-mra
pidgin-msn-pecan
pidgin-opensteamworks
pidgin-osd
pidgin-otr
pidgin-sipe
pidgin-skypeweb
pidgin-window-merge
pidgin-xmpp-receipts
pipelight
pithos
pitivi
playonlinux
portfolio
printrun
pulseeffects-legacy
pulseeffects-pw
purple-discord
purple-facebook
purple-hangouts
purple-lurch
purple-matrix
purple-plugin-pack
purple-slack
purple-vk-plugin
purple-xmpp-http-upload
python37Packages.kicad
python37Packages.kivy
python37Packages.wxPython_4_0
python37Packages.wxPython_4_1
python38Packages.kicad
python38Packages.kivy
python38Packages.wxPython_4_0
python38Packages.wxPython_4_1
python39Packages.kicad
python39Packages.kivy
python39Packages.wxPython_4_0
python39Packages.wxPython_4_1
pytrainer
qgroundcontrol
qt-video-wlr
quilter
quisk
quodlibet
quodlibet-full
quodlibet-without-gst-plugins
quodlibet-xine
quodlibet-xine-full
qutebrowser
radiotray-ng
rednotebook
remmina
run-scaled
sayonara
setzer
shortwave
skype4pidgin
sound-juicer
sparkleshare
subtitleeditor
surf
surf-display
swt
swt_jdk8
tangram
telegram-purple
telepathy-farstream
telepathy-haze
tootle
toxprpl
tunefish
tuxguitar
ulauncher
unoconv
vala-language-server
vimb-unwrapped
vo-aacenc
vocal
vokoscreen-ng
vuze
webkit2-sharp
xfce.parole
xiphos
xpra
yaxg

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

adapta-gtk-theme:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/data/themes/adapta/default.nix:45:5:
   |
45 |     license = with licenses; [ gpl2 cc-by-sa-30 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

aravis:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/development/libraries/aravis/default.nix:85:7:
   |
85 |       license = lib.licenses.lgpl2;
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/aravis/default.nix:86:7:
   |
86 |       maintainers = [];
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

areca:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/backup/areca/default.nix:50:5:
   |
50 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/backup/areca/default.nix:36:3:
   |
36 |   buildPhase = "ant";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/backup/areca/default.nix:38:3:
   |
38 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/backup/areca/default.nix:15:15:
   |
15 |   patches = [ ./fix-javah-bug.diff ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

audio-recorder:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/audio/audio-recorder/default.nix:40:5:
   |
40 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

azureus:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/networking/p2p/azureus/default.nix:13:3:
   |
13 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/tools/networking/p2p/azureus/default.nix:13:3:
   |
13 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

birdfont:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/misc/birdfont/default.nix:31:5:
   |
31 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/tools/misc/birdfont/default.nix:24:3:
   |
24 |   buildPhase = "./build.py";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/misc/birdfont/default.nix:26:3:
   |
26 |   installPhase = "./install.py";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

bookworm:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/office/bookworm/default.nix:61:4:
   |
61 |    meta = with lib; {
   |    ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
desktop-file-utils is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/office/bookworm/default.nix:28:3:
   |
28 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: gnome3.
Near pkgs/applications/office/bookworm/default.nix:1:108:
  |
1 | { lib, stdenv, fetchFromGitHub, pantheon, vala, python3, python2, pkg-config, libxml2, meson, ninja, gtk3, gnome3, glib, webkitgtk, libgee
  |                                                                                ^

bubblemail:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

byzanz:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/video/byzanz/default.nix:28:5:
   |
28 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/video/byzanz/default.nix:30:5:
   |
30 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/byzanz/default.nix:22:3:
   |
22 |   buildInputs = [ which gnome3.gnome-common glib intltool libtool cairo gtk3 xorg.xwininfo ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/byzanz/default.nix:22:3:
   |
22 |   buildInputs = [ which gnome3.gnome-common glib intltool libtool cairo gtk3 xorg.xwininfo ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/byzanz/default.nix:22:3:
   |
22 |   buildInputs = [ which gnome3.gnome-common glib intltool libtool cairo gtk3 xorg.xwininfo ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
wrapGAppsHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/byzanz/default.nix:22:3:
   |
22 |   buildInputs = [ which gnome3.gnome-common glib intltool libtool cairo gtk3 xorg.xwininfo ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/video/byzanz/default.nix:13:15:
   |
13 |   patches = [ ./add-amflags.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

calls:

Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.
Near pkgs/applications/networking/calls/default.nix:39:3:
   |
39 |   nativeBuildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/meson-cmake.md
Unused argument: xorg.
Near pkgs/applications/networking/calls/default.nix:22:3:
   |
22 | , xorg
   |   ^

Unused argument: libxml2.
Near pkgs/applications/networking/calls/default.nix:24:3:
   |
24 | , libxml2
   |   ^

cawbird:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/cawbird/default.nix:76:5:
   |
76 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

chrome-gnome-shell:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/extensions/chrome-gnome-shell/default.nix:67:5:
   |
67 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/gnome-3/extensions/chrome-gnome-shell/default.nix:32:3:
   |
32 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

cinnamon.cinnamon-common:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/cinnamon/cinnamon-common/default.nix:166:5:
    |
166 |     license = [ licenses.gpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/cinnamon/cinnamon-common/default.nix:73:3:
   |
73 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

cinnamon.cinnamon-control-center:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:116:5:
    |
116 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: gnome-menus.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:11:3:
   |
11 | , gnome-menus
   |   ^

Unused argument: systemd.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:13:3:
   |
13 | , systemd
   |   ^

Unused argument: upower.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:14:3:
   |
14 | , upower
   |   ^

Unused argument: ibus.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:19:3:
   |
19 | , ibus
   |   ^

Unused argument: libpulseaudio.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:20:3:
   |
20 | , libpulseaudio
   |   ^

Unused argument: isocodes.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:21:3:
   |
21 | , isocodes
   |   ^

Unused argument: kerberos.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:22:3:
   |
22 | , kerberos
   |   ^

Unused argument: gnome3.
Near pkgs/desktops/cinnamon/cinnamon-control-center/default.nix:30:3:
   |
30 | , gnome3
   |   ^

cinnamon.cinnamon-gsettings-overrides:

Unused argument: paths.
Near pkgs/build-support/trivial-builders.nix:284:12:
    |
284 |          , paths
    |            ^

cinnamon.cinnamon-screensaver:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/cinnamon/cinnamon-screensaver/default.nix:104:5:
    |
104 |     license = [ licenses.gpl2 licenses.lgpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/desktops/cinnamon/cinnamon-screensaver/default.nix:104:5:
    |
104 |     license = [ licenses.gpl2 licenses.lgpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/cinnamon/cinnamon-screensaver/default.nix:59:3:
   |
59 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/cinnamon/cinnamon-screensaver/default.nix:41:5:
   |
41 |     (fetchpatch {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

citrix_workspace_20_04_0:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

citrix_workspace_20_06_0:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

citrix_workspace_20_09_0:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

citrix_workspace_20_10_0:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

citrix_workspace_20_12_0:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

citrix_workspace:

A likely typo in dontAutoPatchelf argument was found, did you mean dontPatchELF?
Near pkgs/applications/networking/remote/citrix-workspace/generic.nix:195:3:
    |
195 |   dontAutoPatchelf = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

claws-mail-gtk3:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/mailreaders/claws-mail/gtk3.nix:117:5:
    |
117 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/mailreaders/claws-mail/gtk3.nix:61:3:
   |
61 |   buildInputs =
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/mailreaders/claws-mail/gtk3.nix:44:15:
   |
44 |   patches = [ ./mime.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

cog:

A likely typo in depsBuildsBuild argument was found, did you mean depsBuildBuild?
Near pkgs/development/web/cog/default.nix:50:3:
   |
50 |   depsBuildsBuild = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Unused argument: fetchpatch.
Near pkgs/development/web/cog/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

Unused argument: glib.
Near pkgs/development/web/cog/default.nix:11:3:
   |
11 | , glib
   |   ^

denemo:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/audio/denemo/default.nix:37:5:
   |
37 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

dropbox-cli:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/dropbox/cli.nix:63:3:
   |
63 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/dropbox/cli.nix:31:5:
   |
31 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

eclipse-mat:

makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/eclipse-mat/default.nix:83:3:
   |
83 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/eclipse-mat/default.nix:83:3:
   |
83 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: buildEnv.
Near pkgs/development/tools/eclipse-mat/default.nix:1:3:
  |
1 | { buildEnv
  |   ^

eclipses.eclipse-committers:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-cpp:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-java:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-modeling:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-platform:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-rcp:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-rust:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-scala-sdk:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

eclipses.eclipse-sdk:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/editors/eclipse/build-eclipse.nix:58:3:
   |
58 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/eclipse/build-eclipse.nix:20:3:
   |
20 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

elementary-planner:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/office/elementary-planner/default.nix:72:5:
   |
72 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

empathy:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/core/empathy/default.nix:144:5:
    |
144 |     license = [ licenses.gpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

ephemeral:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/browsers/ephemeral/default.nix:69:5:
   |
69 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

epiphany:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/core/epiphany/default.nix:110:5:
    |
110 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

evolution-data-server:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/core/evolution-data-server/default.nix:60:5:
   |
60 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/core/evolution-data-server/default.nix:19:5:
   |
19 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

evolution:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/mailreaders/evolution/evolution/default.nix:117:5:
    |
117 |     ./moduledir_from_env.patch
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

evolutionWithPlugins:

Unused argument: paths.
Near pkgs/build-support/trivial-builders.nix:284:12:
    |
284 |          , paths
    |            ^

farstream:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/farstream/default.nix:63:5:
   |
63 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/farstream/default.nix:59:3:
   |
59 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

fcitx5-gtk:

gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/inputmethods/fcitx5/fcitx5-gtk.nix:42:3:
   |
42 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: fetchurl.
Near pkgs/tools/inputmethods/fcitx5/fcitx5-gtk.nix:2:3:
  |
2 | , fetchurl
  |   ^

fractal:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/fractal/default.nix:94:5:
   |
94 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: fetchpatch.
Near pkgs/applications/networking/instant-messengers/fractal/default.nix:4:3:
  |
4 | , fetchpatch
  |   ^

gfbgraph:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/development/libraries/gfbgraph/default.nix:47:5:
   |
47 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

glade:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/development/tools/glade/default.nix:70:5:
   |
70 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

glom:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/glom/default.nix:127:5:
    |
127 |     license = [ licenses.lgpl2 licenses.gpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/glom/default.nix:127:5:
    |
127 |     license = [ licenses.lgpl2 licenses.gpl2 ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gmrender-resurrect:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/networking/gmrender-resurrect/default.nix:42:7:
   |
42 |       license = licenses.gpl2;
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/networking/gmrender-resurrect/default.nix:23:7:
   |
23 |       (fetchpatch {
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnome3.bijiben:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/gnome-notes/default.nix:82:5:
   |
82 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.cheese:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/cheese/default.nix:114:5:
    |
114 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.
Near pkgs/desktops/gnome-3/apps/cheese/default.nix:108:3:
    |
108 |   enableParallelBuilding = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

gnome3.geary:

checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/desktops/gnome-3/misc/geary/default.nix:126:3:
    |
126 |   checkPhase = ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: fetchpatch.
Near pkgs/desktops/gnome-3/misc/geary/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

gnome3.gnome-boxes:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/gnome-boxes/default.nix:141:5:
    |
141 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.gnome-calendar:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/gnome-calendar/default.nix:90:5:
   |
90 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.gnome-clocks:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/gnome-clocks/default.nix:84:5:
   |
84 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.gnome-flashback:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/misc/gnome-flashback/default.nix:194:7:
    |
194 |       license = licenses.gpl2;
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.gnome-initial-setup:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/core/gnome-initial-setup/default.nix:82:5:
   |
82 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnome3.gnome-maps:

gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/gnome-3/apps/gnome-maps/default.nix:50:3:
   |
50 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

gnome3.gnome-screenshot:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/core/gnome-screenshot/default.nix:40:5:
   |
40 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.gnome-session:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/core/gnome-session/default.nix:18:5:
   |
18 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnome3.gnome-shell:

gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/gnome-3/core/gnome-shell/default.nix:120:3:
    |
120 |   buildInputs = [
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

gnome3.gnome-software:

appstream-glib is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/gnome-3/core/gnome-software/default.nix:75:3:
   |
75 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/core/gnome-software/default.nix:53:5:
   |
53 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnome3.gnome-user-share:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/core/gnome-user-share/default.nix:93:5:
   |
93 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.polari:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/apps/polari/default.nix:51:5:
   |
51 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnome3.seahorse:

Unused argument: fetchpatch.
Near pkgs/desktops/gnome-3/apps/seahorse/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

gnome-builder:

vala is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/gnome-builder/default.nix:65:3:
   |
65 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/applications/editors/gnome-builder/default.nix:118:3:
    |
118 |   checkPhase = ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: glib.
Near pkgs/applications/editors/gnome-builder/default.nix:38:3:
   |
38 | , glib
   |   ^

gnomeExtensions.easyScreenCast:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/gnome-3/extensions/EasyScreenCast/default.nix:16:5:
   |
16 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnomeExtensions.night-theme-switcher:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/gnome-3/extensions/night-theme-switcher/default.nix:27:5:
   |
27 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/gnome-3/extensions/night-theme-switcher/default.nix:14:3:
   |
14 |   buildInputs = [ glib gnome3.gnome-shell unzip ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

gnome-photos:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/graphics/gnome-photos/default.nix:49:5:
   |
49 |     ./installed-tests-path.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gnome-podcasts:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/audio/gnome-podcasts/default.nix:78:5:
   |
78 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: fetchpatch.
Near pkgs/applications/audio/gnome-podcasts/default.nix:4:3:
  |
4 | , fetchpatch
  |   ^

gnome-recipes:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/misc/gnome-recipes/default.nix:76:5:
   |
76 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gnucash:

perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/office/gnucash/default.nix:37:3:
   |
37 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
swig is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/office/gnucash/default.nix:37:3:
   |
37 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

gnunet-gtk:

patchPhase should not be overridden, use postPatch instead.
Near pkgs/applications/networking/p2p/gnunet/gtk.nix:37:3:
   |
37 |   patchPhase = "patchShebangs pixmaps/icon-theme-installer";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md

gnvim-unwrapped:

buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/build-support/rust/default.nix:209:3:
    |
209 |   buildPhase = with builtins; args.buildPhase or ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/build-support/rust/default.nix:259:3:
    |
259 |   installPhase = args.installPhase or ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

grilo-plugins:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/grilo-plugins/default.nix:98:5:
   |
98 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gst_all_1.gst-editing-services:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/gstreamer/ges/default.nix:69:3:
   |
69 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/gstreamer/ges/default.nix:33:5:
   |
33 |     ./fix_pkgconfig_includedir.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

gst_all_1.gst-plugins-bad:

gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/libraries/gstreamer/bad/default.nix:118:3:
    |
118 |   buildInputs = [
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/gstreamer/bad/default.nix:103:5:
    |
103 |     ./fix_pkgconfig_includedir.patch
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/development/libraries/gstreamer/bad/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

Unused argument: config.
Near pkgs/development/libraries/gstreamer/bad/default.nix:7:3:
  |
7 | , config
  |   ^

gthumb:

Unused argument: fetchpatch.
Near pkgs/applications/graphics/gthumb/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

gtk4:

A likely typo in setupHooks argument was found, did you mean setupHook?
Near pkgs/development/libraries/gtk/4.x.nix:63:3:
   |
63 |   setupHooks = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Unused argument: gmp.
Near pkgs/development/libraries/gtk/4.x.nix:31:3:
   |
31 | , gmp
   |   ^

Unused argument: x11Support.
Near pkgs/development/libraries/gtk/4.x.nix:38:3:
   |
38 | , x11Support ? stdenv.isLinux
   |   ^

gtkd:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/gtkd/default.nix:132:3:
    |
132 |   meta = with lib; {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Unused argument: gnome3.
Near pkgs/development/libraries/gtkd/default.nix:1:67:
  |
1 | { lib, stdenv, fetchzip, fetchpatch, atk, cairo, dmd, gdk-pixbuf, gnome3, gst_all_1, librsvg
  |                                                                   ^

haskellPackages.webkit2gtk3-javascriptcore:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/haskell-modules/generic-builder.nix:640:3:
    |
640 |   meta = { inherit homepage license platforms; }
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

ib-controller:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/office/ib/controller/default.nix:158:5:
    |
158 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/office/ib/controller/default.nix:14:3:
   |
14 |   buildInputs = [ unzip jdk ib-tws ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/office/ib/controller/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

ipscan:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/security/ipscan/default.nix:36:5:
   |
36 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/security/ipscan/default.nix:15:3:
   |
15 |   buildInputs = [ makeWrapper jdk ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/security/ipscan/default.nix:17:3:
   |
17 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

kicad-small:

agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.
Near pkgs/applications/science/electronics/kicad/default.nix:254:5:
    |
254 |     license = lib.licenses.agpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/science/electronics/kicad/default.nix:215:3:
    |
215 |   installPhase =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: opencascade.
Near pkgs/applications/science/electronics/kicad/default.nix:18:3:
   |
18 | , opencascade
   |   ^

Unused argument: opencascade-occt.
Near pkgs/applications/science/electronics/kicad/default.nix:21:3:
   |
21 | , opencascade-occt
   |   ^

Unused argument: swig.
Near pkgs/applications/science/electronics/kicad/default.nix:27:3:
   |
27 | , swig
   |   ^

Unused argument: valgrind.
Near pkgs/applications/science/electronics/kicad/default.nix:30:3:
   |
30 | , valgrind
   |   ^

kicad-unstable-small:

agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.
Near pkgs/applications/science/electronics/kicad/default.nix:254:5:
    |
254 |     license = lib.licenses.agpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/science/electronics/kicad/default.nix:215:3:
    |
215 |   installPhase =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: opencascade.
Near pkgs/applications/science/electronics/kicad/default.nix:18:3:
   |
18 | , opencascade
   |   ^

Unused argument: opencascade-occt.
Near pkgs/applications/science/electronics/kicad/default.nix:21:3:
   |
21 | , opencascade-occt
   |   ^

Unused argument: swig.
Near pkgs/applications/science/electronics/kicad/default.nix:27:3:
   |
27 | , swig
   |   ^

Unused argument: valgrind.
Near pkgs/applications/science/electronics/kicad/default.nix:30:3:
   |
30 | , valgrind
   |   ^

libgdata:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/libgdata/default.nix:34:5:
   |
34 |     ./installed-tests-path.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

libhandy:

checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/development/libraries/libhandy/default.nix:74:3:
   |
74 |   checkPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: gnome3.
Near pkgs/development/libraries/libhandy/default.nix:12:3:
   |
12 | , gnome3
   |   ^

libreoffice-fresh:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/office/libreoffice/default.nix:66:15:
   |
66 |   patches = [ ./xdg-open-brief.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/applications/office/libreoffice/default.nix:1:21:
  |
1 | { stdenv, fetchurl, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
  |                     ^

libreoffice-fresh-unwrapped:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/office/libreoffice/default.nix:66:15:
   |
66 |   patches = [ ./xdg-open-brief.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/applications/office/libreoffice/default.nix:1:21:
  |
1 | { stdenv, fetchurl, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
  |                     ^

libreoffice-qt:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/office/libreoffice/default.nix:66:15:
   |
66 |   patches = [ ./xdg-open-brief.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/applications/office/libreoffice/default.nix:1:21:
  |
1 | { stdenv, fetchurl, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
  |                     ^

libreoffice-still:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/office/libreoffice/default.nix:66:15:
   |
66 |   patches = [ ./xdg-open-brief.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/applications/office/libreoffice/default.nix:1:21:
  |
1 | { stdenv, fetchurl, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
  |                     ^

libreoffice-unwrapped:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/office/libreoffice/default.nix:66:15:
   |
66 |   patches = [ ./xdg-open-brief.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: fetchpatch.
Near pkgs/applications/office/libreoffice/default.nix:1:21:
  |
1 | { stdenv, fetchurl, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
  |                     ^

libsForQt512.dragon:

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt512.phonon-backend-gstreamer:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/phonon/backends/gstreamer.nix:17:5:
   |
17 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt512.telepathy:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/telepathy/qt/default.nix:30:5:
   |
30 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/telepathy/qt/default.nix:27:3:
   |
27 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Unused argument: fetchpatch.
Near pkgs/development/libraries/telepathy/qt/default.nix:2:40:
  |
2 | , telepathy-farstream, telepathy-glib, fetchpatch }:
  |                                        ^

libsForQt514.dragon:

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt514.phonon-backend-gstreamer:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/phonon/backends/gstreamer.nix:17:5:
   |
17 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt514.telepathy:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/telepathy/qt/default.nix:30:5:
   |
30 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/telepathy/qt/default.nix:27:3:
   |
27 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Unused argument: fetchpatch.
Near pkgs/development/libraries/telepathy/qt/default.nix:2:40:
  |
2 | , telepathy-farstream, telepathy-glib, fetchpatch }:
  |                                        ^

libsForQt5.dragon:

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/kde/dragon.nix:13:5:
   |
13 |     license = with lib.licenses; [ gpl2 fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt5.kdenlive:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/kde/default.nix:48:9:
   |
48 |         meta = {
   |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
wrapGAppsHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/kde/kdenlive.nix:43:3:
   |
43 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

libsForQt5.phonon-backend-gstreamer:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/phonon/backends/gstreamer.nix:17:5:
   |
17 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt5.telepathy:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/telepathy/qt/default.nix:30:5:
   |
30 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/telepathy/qt/default.nix:27:3:
   |
27 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Unused argument: fetchpatch.
Near pkgs/development/libraries/telepathy/qt/default.nix:2:40:
  |
2 | , telepathy-farstream, telepathy-glib, fetchpatch }:
  |                                        ^

liferea:

gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/newsreaders/liferea/default.nix:40:3:
   |
40 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

lispPackages.cl-webkit2:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/lisp-modules/define-package.nix:110:3:
    |
110 |   meta = {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/development/lisp-modules/define-package.nix:110:3:
    |
110 |   meta = {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/lisp-modules/define-package.nix:77:3:
   |
77 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

lispPackages.nyxt:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/lisp-modules/define-package.nix:110:3:
    |
110 |   meta = {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/development/lisp-modules/define-package.nix:110:3:
    |
110 |   meta = {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/lisp-modules/define-package.nix:77:3:
   |
77 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

lutris-free:

Unused argument: paths.
Near pkgs/build-support/trivial-builders.nix:284:12:
    |
284 |          , paths
    |            ^

lutris:

Unused argument: paths.
Near pkgs/build-support/trivial-builders.nix:284:12:
    |
284 |          , paths
    |            ^

lutris-unwrapped:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Unused argument: fetchpatch.
Near pkgs/applications/misc/lutris/default.nix:1:49:
  |
1 | { buildPythonApplication, lib, fetchFromGitHub, fetchpatch
  |                                                 ^

mailnag:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

mailnagWithPlugins:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

mapmap:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/video/mapmap/default.nix:73:5:
   |
73 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/video/mapmap/default.nix:56:3:
   |
56 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/video/mapmap/default.nix:44:5:
   |
44 |     (fetchpatch {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

marker:

pandoc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/marker/default.nix:33:3:
   |
33 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

mate.atril:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/mate/atril/default.nix:73:5:
   |
73 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

mate.mate-user-guide:

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.
Near pkgs/desktops/mate/mate-user-guide/default.nix:26:5:
   |
26 |     license = with licenses; [ gpl2Plus fdl12 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

nasc:

Unused argument: libsoup.
Near pkgs/applications/science/math/nasc/default.nix:12:3:
   |
12 | , libsoup
   |   ^

notes-up:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/office/notes-up/default.nix:65:5:
   |
65 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

nyxt:

A likely typo in gstBuildInputs argument was found, did you mean buildInputs?
Near pkgs/applications/networking/browsers/nyxt/default.nix:16:3:
   |
16 |   gstBuildInputs = with gst_all_1; [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/applications/networking/browsers/nyxt/default.nix:46:3:
   |
46 |   checkPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/browsers/nyxt/default.nix:33:3:
   |
33 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: sbcl.
Near pkgs/applications/networking/browsers/nyxt/default.nix:1:30:
  |
1 | { stdenv, lib, lispPackages, sbcl
  |                              ^

odpdown:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

onboard:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern '/usr/bin/yelp' doesn't match anything in file './Onboard/LanguageSupport.py'

Please check the offending substituteInPlace for typos or changes in source.
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/onboard/default.nix:51:5:
   |
51 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: glibcLocales.
Near pkgs/applications/misc/onboard/default.nix:9:3:
  |
9 | , glibcLocales
  |   ^

osmo:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/office/osmo/default.nix:20:5:
   |
20 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

pantheon.elementary-greeter:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/pantheon/desktop/elementary-greeter/default.nix:89:5:
   |
89 |     ./sysconfdir-install.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pantheon.elementary-gsettings-schemas:

Unused argument: paths.
Near pkgs/build-support/trivial-builders.nix:284:12:
    |
284 |          , paths
    |            ^

pantheon.elementary-session-settings:

lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix:158:5:
    |
158 |     license = licenses.lgpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: substituteAll.
Near pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix:4:3:
  |
4 | , substituteAll
  |   ^

pantheon.extra-elementary-contracts:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/pantheon/desktop/extra-elementary-contracts/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/desktops/pantheon/desktop/extra-elementary-contracts/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/pantheon/desktop/extra-elementary-contracts/default.nix:20:5:
   |
20 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pantheon.notes-up:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/office/notes-up/default.nix:65:5:
   |
65 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

pantheon.switchboard-plug-a11y:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/pantheon/apps/switchboard-plugs/a11y/default.nix:29:5:
   |
29 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pantheon.switchboard-with-plugs:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/desktops/pantheon/apps/switchboard/wrapper.nix:47:3:
   |
47 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/pantheon/apps/switchboard/default.nix:55:5:
   |
55 |     ./plugs-path-env.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pantheon.wingpanel-indicator-datetime:

Unused argument: elementary-calendar.
Near pkgs/desktops/pantheon/desktop/wingpanel-indicators/datetime/default.nix:18:3:
   |
18 | , elementary-calendar
   |   ^

pantheon.wingpanel-with-indicators:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/desktops/pantheon/desktop/wingpanel/wrapper.nix:45:3:
   |
45 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/pantheon/desktop/wingpanel/default.nix:61:5:
   |
61 |     ./indicators.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

parlatype:

Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.
Near pkgs/applications/audio/parlatype/default.nix:51:3:
   |
51 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/audio/parlatype/default.nix:53:3:
   |
53 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

pdfpc:

Unused argument: fetchpatch.
Near pkgs/applications/misc/pdfpc/default.nix:1:72:
  |
1 | { lib, stdenv, fetchFromGitHub, cmake, pkg-config, vala, gtk3, libgee, fetchpatch
  |                                                                        ^

picard:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern '‘' doesn't match anything in file 'setup.cfg'

Please check the offending substituteInPlace for typos or changes in source.

pidgin-carbons:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/carbons/default.nix:22:5:
   |
22 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/carbons/default.nix:24:5:
   |
24 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-latex:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-latex/default.nix:29:5:
   |
29 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

pidgin:

intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/instant-messengers/pidgin/default.nix:32:3:
   |
32 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/instant-messengers/pidgin/default.nix:52:15:
   |
52 |   patches = [ ./pidgin-makefile.patch ./add-search-path.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/instant-messengers/pidgin/default.nix:52:39:
   |
52 |   patches = [ ./pidgin-makefile.patch ./add-search-path.patch ];
   |                                       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pidgin-mra:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-mra/default.nix:32:5:
   |
32 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-mra/default.nix:29:3:
   |
29 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-msn-pecan:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/msn-pecan/default.nix:10:3:
   |
10 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/msn-pecan/default.nix:10:3:
   |
10 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

pidgin-opensteamworks:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-opensteamworks/default.nix:33:5:
   |
33 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

pidgin-osd:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-osd/default.nix:28:5:
   |
28 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-osd/default.nix:25:3:
   |
25 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-otr:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/otr/default.nix:17:5:
   |
17 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/otr/default.nix:12:3:
   |
12 |   buildInputs = [ libotr pidgin intltool ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

pidgin-sipe:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/sipe/default.nix:21:5:
   |
21 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/sipe/default.nix:18:3:
   |
18 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-skypeweb:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-skypeweb/default.nix:27:5:
   |
27 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-skypeweb/default.nix:29:5:
   |
29 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-window-merge:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/window-merge/default.nix:17:5:
   |
17 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/window-merge/default.nix:19:5:
   |
19 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

pidgin-xmpp-receipts:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-xmpp-receipts/default.nix:27:5:
   |
27 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-xmpp-receipts/default.nix:19:3:
   |
19 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

pipelight:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/pipelight/default.nix:24:15:
   |
24 |   patches = [ ./pipelight.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pitivi:

Unused argument: fetchFromGitHub.
Near pkgs/applications/video/pitivi/default.nix:2:3:
  |
2 | , fetchFromGitHub
  |   ^

portfolio:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/office/portfolio/default.nix:45:3:
   |
45 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

purple-discord:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-discord/default.nix:23:5:
   |
23 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

purple-facebook:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-facebook/default.nix:61:5:
   |
61 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-facebook/default.nix:50:3:
   |
50 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

purple-hangouts:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-hangouts/default.nix:21:5:
   |
21 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

purple-lurch:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-lurch/default.nix:27:5:
   |
27 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-lurch/default.nix:20:3:
   |
20 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

purple-matrix:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-matrix/default.nix:34:5:
   |
34 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

purple-plugin-pack:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-plugin-pack/default.nix:15:5:
   |
15 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-plugin-pack/default.nix:10:3:
   |
10 |   buildInputs = [ pidgin intltool python ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

purple-slack:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-slack/default.nix:23:5:
   |
23 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

purple-vk-plugin:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-vk-plugin/default.nix:28:5:
   |
28 |     license = lib.licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-vk-plugin/default.nix:25:3:
   |
25 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

purple-xmpp-http-upload:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-xmpp-http-upload/default.nix:21:5:
   |
21 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/purple-xmpp-http-upload/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

python37Packages.kicad:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern 'unknown' doesn't match anything in file 'CMakeModules/KiCadVersion.cmake'

Please check the offending substituteInPlace for typos or changes in source.
Unused argument: fetchFromGitLab.
Near pkgs/applications/science/electronics/kicad/base.nix:2:3:
  |
2 | , fetchFromGitLab
  |   ^

Unused argument: fetchpatch.
Near pkgs/applications/science/electronics/kicad/base.nix:21:3:
   |
21 | , fetchpatch
   |   ^

Unused argument: callPackage.
Near pkgs/applications/science/electronics/kicad/base.nix:23:3:
   |
23 | , callPackage
   |   ^

Unused argument: baseName.
Near pkgs/applications/science/electronics/kicad/base.nix:26:3:
   |
26 | , baseName
   |   ^

python37Packages.wxPython_4_0:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/wxPython/4.0.nix:72:3:
   |
72 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: numpy.
Near pkgs/development/python-modules/wxPython/4.0.nix:13:3:
   |
13 | , numpy
   |   ^

Unused argument: pillow.
Near pkgs/development/python-modules/wxPython/4.0.nix:14:3:
   |
14 | , pillow
   |   ^

Unused argument: six.
Near pkgs/development/python-modules/wxPython/4.0.nix:15:3:
   |
15 | , six
   |   ^

python37Packages.wxPython_4_1:

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: pyopengl.
Near pkgs/development/python-modules/wxPython/4.1.nix:9:3:
  |
9 | , pyopengl
  |   ^

python38Packages.kicad:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern 'unknown' doesn't match anything in file 'CMakeModules/KiCadVersion.cmake'

Please check the offending substituteInPlace for typos or changes in source.
Unused argument: fetchFromGitLab.
Near pkgs/applications/science/electronics/kicad/base.nix:2:3:
  |
2 | , fetchFromGitLab
  |   ^

Unused argument: fetchpatch.
Near pkgs/applications/science/electronics/kicad/base.nix:21:3:
   |
21 | , fetchpatch
   |   ^

Unused argument: callPackage.
Near pkgs/applications/science/electronics/kicad/base.nix:23:3:
   |
23 | , callPackage
   |   ^

Unused argument: baseName.
Near pkgs/applications/science/electronics/kicad/base.nix:26:3:
   |
26 | , baseName
   |   ^

python38Packages.wxPython_4_0:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/wxPython/4.0.nix:72:3:
   |
72 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: numpy.
Near pkgs/development/python-modules/wxPython/4.0.nix:13:3:
   |
13 | , numpy
   |   ^

Unused argument: pillow.
Near pkgs/development/python-modules/wxPython/4.0.nix:14:3:
   |
14 | , pillow
   |   ^

Unused argument: six.
Near pkgs/development/python-modules/wxPython/4.0.nix:15:3:
   |
15 | , six
   |   ^

python38Packages.wxPython_4_1:

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: pyopengl.
Near pkgs/development/python-modules/wxPython/4.1.nix:9:3:
  |
9 | , pyopengl
  |   ^

python39Packages.kicad:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern 'unknown' doesn't match anything in file 'CMakeModules/KiCadVersion.cmake'

Please check the offending substituteInPlace for typos or changes in source.
Unused argument: fetchFromGitLab.
Near pkgs/applications/science/electronics/kicad/base.nix:2:3:
  |
2 | , fetchFromGitLab
  |   ^

Unused argument: fetchpatch.
Near pkgs/applications/science/electronics/kicad/base.nix:21:3:
   |
21 | , fetchpatch
   |   ^

Unused argument: callPackage.
Near pkgs/applications/science/electronics/kicad/base.nix:23:3:
   |
23 | , callPackage
   |   ^

Unused argument: baseName.
Near pkgs/applications/science/electronics/kicad/base.nix:26:3:
   |
26 | , baseName
   |   ^

python39Packages.wxPython_4_0:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/wxPython/4.0.nix:72:3:
   |
72 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: numpy.
Near pkgs/development/python-modules/wxPython/4.0.nix:13:3:
   |
13 | , numpy
   |   ^

Unused argument: pillow.
Near pkgs/development/python-modules/wxPython/4.0.nix:14:3:
   |
14 | , pillow
   |   ^

Unused argument: six.
Near pkgs/development/python-modules/wxPython/4.0.nix:15:3:
   |
15 | , six
   |   ^

python39Packages.wxPython_4_1:

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: pyopengl.
Near pkgs/development/python-modules/wxPython/4.1.nix:9:3:
  |
9 | , pyopengl
  |   ^

pytrainer:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/pytrainer/default.nix:39:5:
   |
39 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

qgroundcontrol:

A likely typo in gstInputs argument was found, did you mean qtInputs?
Near pkgs/applications/science/robotics/qgroundcontrol/default.nix:16:3:
   |
16 |   gstInputs = with gst_all_1; [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.
Near pkgs/applications/science/robotics/qgroundcontrol/default.nix:20:3:
   |
20 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

quodlibet-full:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/quodlibet/default.nix:19:15:
   |
19 |   patches = [ ./quodlibet-feedparser6.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

quodlibet:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/quodlibet/default.nix:19:15:
   |
19 |   patches = [ ./quodlibet-feedparser6.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

quodlibet-without-gst-plugins:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/quodlibet/default.nix:19:15:
   |
19 |   patches = [ ./quodlibet-feedparser6.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

quodlibet-xine-full:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/quodlibet/default.nix:19:15:
   |
19 |   patches = [ ./quodlibet-feedparser6.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

quodlibet-xine:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/quodlibet/default.nix:19:15:
   |
19 |   patches = [ ./quodlibet-feedparser6.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

radiotray-ng:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/audio/radiotray-ng/default.nix:94:5:
   |
94 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/audio/radiotray-ng/default.nix:64:15:
   |
64 |   patches = [ ./no-dl-googletest.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

remmina:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/remote/remmina/default.nix:54:5:
   |
54 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

run-scaled:

makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/X11/run-scaled/default.nix:14:3:
   |
14 |   buildInputs = [ makeWrapper ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/X11/run-scaled/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

sayonara:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/audio/sayonara/default.nix:60:5:
   |
60 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

shortwave:

Unused argument: rust.
Near pkgs/applications/audio/shortwave/default.nix:17:3:
   |
17 | , rust
   |   ^

skype4pidgin:

patchPhase should not be overridden, use postPatch instead.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/skype4pidgin/default.nix:14:3:
   |
14 |   patchPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/skype4pidgin/default.nix:35:3:
   |
35 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/skype4pidgin/default.nix:20:3:
   |
20 |   buildPhase  = "make libskype.so libskype_dbus.so";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/skype4pidgin/default.nix:22:3:
   |
22 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

sound-juicer:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/audio/sound-juicer/default.nix:37:5:
   |
37 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

sparkleshare:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/version-management/sparkleshare/default.nix:88:5:
   |
88 |     license = lib.licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
patchPhase should not be overridden, use postPatch instead.
Near pkgs/applications/version-management/sparkleshare/default.nix:51:3:
   |
51 |   patchPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md

subtitleeditor:

desktop-file-utils is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/video/subtitleeditor/default.nix:29:3:
   |
29 |   buildInputs =  [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

surf-display:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/surf-display/default.nix:54:5:
   |
54 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/surf-display/default.nix:29:15:
   |
29 |   patches = [ ./pdf-makefile.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

swt_jdk8:

A likely typo in NIX_LFLAGS argument was found, did you mean NIX_LDFLAGS, ninjaFlags or CXXFLAGS?
Near pkgs/development/libraries/java/swt/default.nix:41:3:
   |
41 |   NIX_LFLAGS = toString (map (x: "-L${lib.getLib x}/lib") [ xorg.libX11 pango gdk-pixbuf glib ]) +
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
A likely typo in fullVersion argument was found, did you mean version?
Near pkgs/development/libraries/java/swt/default.nix:23:3:
   |
23 |   fullVersion = "${version}-201506032000";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/libraries/java/swt/default.nix:44:3:
   |
44 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/libraries/java/swt/default.nix:57:3:
   |
57 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

swt:

A likely typo in NIX_LFLAGS argument was found, did you mean NIX_LDFLAGS, ninjaFlags or CXXFLAGS?
Near pkgs/development/libraries/java/swt/default.nix:41:3:
   |
41 |   NIX_LFLAGS = toString (map (x: "-L${lib.getLib x}/lib") [ xorg.libX11 pango gdk-pixbuf glib ]) +
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
A likely typo in fullVersion argument was found, did you mean version?
Near pkgs/development/libraries/java/swt/default.nix:23:3:
   |
23 |   fullVersion = "${version}-201506032000";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/libraries/java/swt/default.nix:44:3:
   |
44 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/libraries/java/swt/default.nix:57:3:
   |
57 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

telegram-purple:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/telegram-purple/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/telegram-purple/default.nix:26:3:
   |
26 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

telepathy-farstream:

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/telepathy/farstream/default.nix:19:5:
   |
19 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/telepathy/farstream/default.nix:15:3:
   |
15 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

telepathy-haze:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/telepathy/haze/default.nix:25:3:
   |
25 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
Package is missing a license
Near pkgs/applications/networking/instant-messengers/telepathy/haze/default.nix:25:3:
   |
25 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

tilix:

Unused argument: fetchpatch.
Near pkgs/applications/terminal-emulators/tilix/default.nix:3:3:
  |
3 | , fetchpatch
  |   ^

Unused argument: glib.
Near pkgs/applications/terminal-emulators/tilix/default.nix:16:3:
   |
16 | , glib
   |   ^

tootle:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/misc/tootle/default.nix:68:5:
   |
68 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: fetchpatch.
Near pkgs/applications/misc/tootle/default.nix:4:3:
  |
4 | , fetchpatch
  |   ^

toxprpl:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/tox-prpl/default.nix:24:5:
   |
24 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/instant-messengers/pidgin-plugins/tox-prpl/default.nix:21:3:
   |
21 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

tuxguitar:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/applications/editors/music/tuxguitar/default.nix:41:5:
   |
41 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/editors/music/tuxguitar/default.nix:17:3:
   |
17 |   buildInputs = [ makeWrapper ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/editors/music/tuxguitar/default.nix:19:3:
   |
19 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

ulauncher:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/ulauncher/default.nix:73:5:
   |
73 |     ./fix-path.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/ulauncher/default.nix:74:5:
   |
74 |     ./0001-Adjust-get_data_path-for-NixOS.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/ulauncher/default.nix:75:5:
   |
75 |     ./fix-extensions.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

unoconv:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/text/unoconv/default.nix:36:5:
   |
36 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
asciidoc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/text/unoconv/default.nix:20:3:
   |
20 |   buildInputs = [ asciidoc makeWrapper ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/text/unoconv/default.nix:20:3:
   |
20 |   buildInputs = [ asciidoc makeWrapper ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

vala-language-server:

vala is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/vala-language-server/default.nix:44:3:
   |
44 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

vimb-unwrapped:

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/browsers/vimb/default.nix:30:5:
   |
30 |     license = lib.licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/networking/browsers/vimb/default.nix:31:5:
   |
31 |     maintainers = [];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

vuze:

makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/networking/p2p/vuze/default.nix:12:3:
   |
12 |   buildInputs = [ makeWrapper jdk ant ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/networking/p2p/vuze/default.nix:14:3:
   |
14 |   buildPhase = "ant";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/p2p/vuze/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

webkit2-sharp:

error: no-flags-array
installFlagsArray is only intended to be used in Bash, not as a Nix attribute.
Near pkgs/development/libraries/webkit2-sharp/default.nix:37:3:
   |
37 |   installFlagsArray = ["GAPIXMLDIR=/tmp/gapixml"];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-flags-array.md

webkitgtk:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/webkitgtk/default.nix:74:5:
   |
74 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/webkitgtk/default.nix:78:5:
   |
78 |     ./libglvnd-headers.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

xfce.parole:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xiphos:

A likely typo in wafConfigureFlags argument was found, did you mean configureFlags?
Near pkgs/applications/misc/xiphos/default.nix:40:3:
   |
40 |   wafConfigureFlags = [ "--enable-webkit2" ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
docbook2x is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/misc/xiphos/default.nix:27:3:
   |
27 |   buildInputs = [ python intltool docbook2x docbook_xml_dtd_412 libxslt
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
docbook_xml_dtd_412 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/misc/xiphos/default.nix:27:3:
   |
27 |   buildInputs = [ python intltool docbook2x docbook_xml_dtd_412 libxslt
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/misc/xiphos/default.nix:27:3:
   |
27 |   buildInputs = [ python intltool docbook2x docbook_xml_dtd_412 libxslt
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

xpra:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/X11/xpra/default.nix:16:7:
   |
16 |       ./0002-Constant-DPI.patch
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/X11/xpra/default.nix:17:7:
   |
17 |       ./0003-fix-pointer-limits.patch
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/X11/xpra/default.nix:18:7:
   |
18 |       ./0005-support-for-30-bit-depth-in-dummy-driver.patch
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/X11/xpra/default.nix:41:5:
   |
41 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/X11/xpra/default.nix:46:5:
   |
46 |     ./fix-41106.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: callPackage.
Near pkgs/tools/X11/xpra/default.nix:1:18:
  |
1 | { lib, fetchurl, callPackage, substituteAll, python3, pkg-config, writeText
  |                  ^

yaxg:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/graphics/yaxg/default.nix:18:3:
   |
18 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

yelp:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Installing fractal-gtk/res/org.gnome.Fractal.desktop to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/applications
Installing fractal-gtk/res/org.gnome.Fractal.metainfo.xml to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/metainfo
Installing fractal-gtk/src/fractal to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/bin
This file does not have an rpath.
b'/nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/lib64:/nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/lib:/nix/store/a'
Installing /build/source/fractal-gtk/res/icons/hicolor/scalable/apps/org.gnome.Fractal.svg to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-frs
Installing /build/source/fractal-gtk/res/icons/hicolor/symbolic/apps/org.gnome.Fractal-symbolic.svg to /nix/store/nycs8azfyr1389faagscm16wm0s
Installing /build/source/fractal-gtk/res/org.gnome.Fractal.gschema.xml to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/gls
Running custom install script '/nix/store/i33nc1kgmlsqyrgnxr5jld39w6l2f70b-meson-0.56.0/bin/meson --internal gettext install --subdir=fracta'
Installing /build/source/build/fractal-gtk/po/ca.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/ca/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/cs.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/cs/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/de.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/de/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/el.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/el/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/en_GB.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/en_GB/LC_Mo
Installing /build/source/build/fractal-gtk/po/eo.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/eo/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/es.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/es/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/eu.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/eu/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/fi.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/fi/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/fr.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/fr/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/fur.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/fur/LC_MESSAo
Installing /build/source/build/fractal-gtk/po/hu.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/hu/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/id.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/id/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/it.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/it/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/kk.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/kk/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/nl.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/nl/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/pl.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/pl/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/pt_BR.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/pt_BR/LC_Mo
Installing /build/source/build/fractal-gtk/po/ro.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/ro/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/ru.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/ru/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/sk.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/sk/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/sv.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/sv/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/tr.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/tr/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/uk.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/uk/LC_MESSAGEo
Installing /build/source/build/fractal-gtk/po/zh_CN.gmo to /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/locale/zh_CN/LC_Mo
Running custom install script '/build/source/scripts/meson_post_install.py'
Update icon cache...
gtk-update-icon-cache: Cache file created successfully.
Compiling gsettings schemas...
glibPreFixupPhase
glibPreFixupPhase
gappsWrapperArgsHook
dropIconThemeCache
Removing /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/share/icons/hicolor/icon-theme.cache
post-installation fixup
Wrapping program '/nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/bin/fractal'
shrinking RPATHs of ELF executables and libraries in /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0
shrinking /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/bin/.fractal-wrapped
strip is /nix/store/9f8y44vmjnwdjvzlff0gm3f3g6ycyyqy-binutils-2.35.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0/bin
patching script interpreter paths in /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0
checking for references to /build/ in /nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0...
/nix/store/nycs8azfyr1389faagscm16wm0mlf133-fractal-4.4.0

My guess is that it got killed, running tests needs to recompile pretty much everything (slow!), but does not emit any output.
I included a patch for the various small fixes on gst_all_1.gst-plugins-bad

@SuperSandro2000 anything else I can do here?
Thank you

Removing gobject-introspection caused a regression:
Run-time dependency orc-0.4 found: YES 0.4.32
Program orcc found: YES (/nix/store/h666gplxlbp6bx926cwr7cm7vmay37xc-orc-0.4.32-dev/bin/orcc)
Header <gst/gstconfig.h> has symbol "GST_DISABLE_GST_DEBUG" with dependency gstreamer-1.0: NO
Message: GStreamer debug system is enabled
Program python3 found: YES (/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/bin/python3.8)
Program g-ir-scanner found: YES (/nix/store/9348f0896syjsfsx76kf4vpxgxp003m9-gobject-introspection-1.66.1-dev/bin/g-ir-scanner)
Using 'PKG_CONFIG' from environment with value: 'pkg-config'
Found pkg-config: /nix/store/1m90ppkamm4wk81l7ig65ircwiw7wiaa-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
Did not find CMake 'cmake'
Found CMake: NO
Build-time dependency gobject-introspection-1.0 found: NO (tried pkgconfig)
gst-libs/gst/audio/meson.build:22:2: ERROR: Dependency "gobject-introspection-1.0" not found, tried pkgconfig
A full log can be found at /build/gst-plugins-bad-1.18.2/build/meson-logs/meson-log.txt
builder for '/nix/store/1rlgmirl51ayivby585f69rvll8wxx0l-gst-plugins-bad-1.18.2.drv' failed with exit code 1
error: build of '/nix/store/1rlgmirl51ayivby585f69rvll8wxx0l-gst-plugins-bad-1.18.2.drv' failed

just checking, that was the result of a cross compilation error right?