FEAT: Enable whitelist for compiling specific files

It would be useful to have the ability to parse certain files only through the use of a whitelist (environment variable). The whitelist could then be used by the extension to skip writing a lecture not in the list during the Builder phase.
One use case is CI to check / compile specific lectures that hopefully can be inferred from the git environment.
We will need to keep in mind references and links if we only build some lecture files. I think the full doctree would be parsed and links resolved prior to our Builder phase. If this is not the case we can then implement an execution whitelist feature instead and build the whole lecture set as that doesn't take much time.

Compiling specific files can be don using an environmental variable FILES= using Makefile or through the jupinx --files tool.


[Bug] Group ubuntu does not exist, causing a boot-time startup to not work

Describe the bug
Startup fails with matter-th.service: Failed to determine group credentials: No such process (when checked via systemctl status matter-th.service)
Steps to reproduce the behavior

Install on a fresh RPI5 with ubuntu 24.04.
service does not start after boot

Service can be manually started
Expected behavior
Boot time startup
Log files
$ systemctl status matter-th.service
Warning: The unit file, source configuration file or drop-ins of matter-th.service changed on disk. Run 'systemctl daemon-reload' to reload units.
× matter-th.service - Matter Test Harness
     Loaded: loaded (/etc/systemd/system/matter-th.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Fri 2024-08-09 19:03:49 UTC; 31min ago
   Main PID: 841 (code=exited, status=216/GROUP)
        CPU: 9ms

Aug 09 19:03:49 harnesspi systemd[1]: Starting matter-th.service - Matter Test Harness...
Aug 09 19:03:49 harnesspi (start.sh)[841]: matter-th.service: Failed to determine group credentials: No such process
Aug 09 19:03:49 harnesspi systemd[1]: matter-th.service: Main process exited, code=exited, status=216/GROUP
Aug 09 19:03:49 harnesspi systemd[1]: matter-th.service: Failed with result 'exit-code'.
Aug 09 19:03:49 harnesspi systemd[1]: Failed to start matter-th.service - Matter Test Harness.

PICS file
No response
Screenshots
No response
Environment
No response
Additional Information
No response

Underlying reason seems to be that I used a different username than ubuntu when I customized my image (when I selected a wifi connection option).
The test harness seems to assume this user (and and as a result this group) exists. Further issues like #342 also result if you use a different user from ubuntu.

@andy31415 Thank you for your feedback.
The user name must be UBUNTU for the system to work correctly.
With this in mind, we will make the installation instructions clearer so that they are not changed.

@andy31415  Please take a look and if everything is ok, could you close the issue?
User guide link:
https://github.com/project-chip/certification-tool/blob/fall2024/docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc#th-installation-on-raspberry-pi

PR with script to verify the current user is 'ubuntu': https://github.com/project-chip/certification-tool/pull/346

PR with script to verify the current user is 'ubuntu': https://github.com/project-chip/certification-tool/pull/346
Feel free to reopen this issue if needed.


Outputs twice

upgrading to 0.19 from 0.18 makes the test result output happen twice
gulp.task('phpunit', function() {
	var options = {debug: false, notify: false};
	gulp.src('phpunit.xml').pipe(phpunit('./vendor/bin/phpunit', options));
});

@sephvelut Thanks for report, I will have a look at this shortly.  Seems there was regression issue when 0.19 update was released (I have addressed this issue at some point many releases ago).

Issue has been fixed with v0.20.0 release
https://www.npmjs.com/package/gulp-phpunit


[BUG]why can't I open my own datasets in yolov8 format？

Describe the problem
HELLO! I'm just a new guy to use the fiftyone which is a good tool. I want to open my own datasets in yolov8 format and see the marked rectangle box. It can add sample to my dataset but turn to be wrong when it opens the fiftyone website and report an error "No dataset selected"
Code to reproduce issue
import glob
import os
import fiftyone as fo
from fiftyone import Sample, Detection, Dataset
图片和YOLO标注文件的路径
images_dir = r"D:/auto_Detection/鸟类检测/数据集/fiftyone下载10000/train/images"
annotations_dir = r"D:/auto_Detection/鸟类检测/数据集/fiftyone下载10000/train/labels"
支持的类别
classes = ["bird"]  # 根据你的数据集替换类别列表
获取所有图片路径
images_patt = os.path.join(images_dir, "*.jpg")  # 假设图片是.jpg格式
image_paths = glob.glob(images_patt)
创建数据集
dataset_name = "bird_dataset"
dataset = Dataset(name=dataset_name)
遍历所有图片
for image_path in image_paths:
# 生成YOLO标注文件的完整路径
annotation_path = os.path.join(annotations_dir, os.path.splitext(os.path.basename(image_path))[0] + ".txt")
# 初始化一个空的样本
sample = Sample(filepath=image_path)

# 读取YOLO标注文件
if os.path.isfile(annotation_path):
    with open(annotation_path, "r") as f:
        lines = f.readlines()
        detections = []
        for line in lines:
            # YOLO格式通常为 <class_index> <x> <y> <width> <height>
            parts = line.strip().split()
            if len(parts) < 5:
                continue
            class_index = int(parts[0])
            x, y, width, height = map(float, parts[1:5])
            # 转换为(x_min, y_min, x_max, y_max)格式
            x_min = x - width / 2
            y_min = y - height / 2
            x_max = x + width / 2
            y_max = y + height / 2
            label = classes[class_index]

            # 创建检测标注并添加到样本中
            detection = Detection(
                label=label,
                bounding_box=[x_min, y_min, x_max - x_min, y_max - y_min],
                confidence=1.0  # 假设分数为1.0
            )
            detections.append(detection)

# 将检测标注添加到样本
sample["ground_truth"] = fo.Detections(detections=detections)

# 将样本添加到数据集
dataset.add_sample(sample)

启动FiftyOne App并可视化标注的矩形框
session= fo.launch_app(dataset)
session.wait()
![LFZH0)P897HT5F4KW}P(X$U](https://github.com/user-attachments/assets/8c55c177-ee98-4037-bc56-34a030b36376)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 22.04):Windows
Python version (python --version):3.10.14
FiftyOne version (fiftyone --version):0.24.1
FiftyOne installed from (pip or source):pip

Other info/logs
Include any logs or source code that would be helpful to diagnose the problem.
If including tracebacks, please include the full traceback. Large logs and
files should be attached. Please do not use screenshots for sharing text. Code
snippets should be used instead when providing tracebacks, logs, etc.
Willingness to contribute
The FiftyOne Community encourages bug fix contributions. Would you or another
member of your organization be willing to contribute a fix for this bug to the
FiftyOne codebase?

[ ] Yes. I can contribute a fix for this bug independently
[√ ] Yes. I would be willing to contribute a fix for this bug with guidance
from the FiftyOne community
[ ] No. I cannot contribute a bug fix at this time

Hi @Edward-YS 👋 ThisFAQ might help


[compiler] Move React 17/18 section to its own subheading

Currently it's a little hidden, let's move it to its own subheading for more prominence

git can't diff this properly but this was just moving the section out with no edits


Rename test workflow

This pull request renames the test workflow to tests in plural.

coverage: 100.0%. remained the same
when pulling ba12c9c47c01a4f73dbc0b0ca081c6427c535aec on rename_test_workflow
into 0618dfd148b1c6cb7c9e9920fc9b260a59ef04a0 on master.


Immersive Technology Steam Turbine makes Fresh Water, Not Exhaust Steam

The TFC Tuesday crew are finding that the IE cooling tower is useless as there is no way to make IE Exhaust Steam.

Fixed in 12.2.64


Wrong keyof behaviour for generic with extends types in 2.9

TypeScript Version:  2.9.1, 3.0.0-dev.20180601

Search Terms: keyof 2.9 generics extract extends string number symbol
Code
type StringKeyof<T> = Extract<keyof T, string>;

type Omit<T, K extends StringKeyof<T>> = any;

type WithoutFoo = Omit<{ foo: string }, "foo">; // ok

type WithoutFooGeneric<P extends { foo: string }> = Omit<P, "foo">; // Error: Type '"foo"' does not satisfy the constraint 'Extract<keyof P, string>'.

Expected behavior:
Omit should pass "foo" as valid type for keyof because generic type extends a type that has this string key.
Actual behavior:
Error: Type '"foo"' does not satisfy the constraint 'Extract<keyof P, string>'.
Playground Link: Link

This is also true for function-bound generics:
interface Foo {
    foo: number,
}

function run<T extends Foo>() {
    // ERROR: `Type '"foo"' is not assignable to type Extract<keyof T, string>`
    let key: Extract<keyof T, string> = 'foo';

    // Okay
    let key2: Extract<keyof Foo, string> = 'foo';
}

Playground

let key: Extract<keyof T, string> = 'foo'; shouldn't work. Substitute never for T (which is allowable), and you'd be attempting to assign 'foo' to never, which shouldn't work.

Huh, interesting, how is that different from using a bare keyof?
function run<T extends Foo>() {
    // Okay
    let key: keyof T = 'foo';
}

If T is never in this case, keyof T is also never, so we're still assigning 'foo' to never.

Is this the same issue?
type FormFields = { someField: string };

// Typescript should allow only keys of "FormFields" to be
// used as fieldName
class GenericForm<T extends FormFields> {
    public fieldA = new FormField<T>({ fieldNameA: "someField" }); // works as expected
    public fieldB =  new FormField<T>({ fieldNameB: "someField" }); // throws an error
}

interface FormFieldOptions<T extends FormFields> {
    fieldNameA?: keyof T;
    fieldNameB?: Extract<keyof T, string>;
}
class FormField<T extends FormFields> {
    public fieldNameA: string;
    public fieldNameB: string;

    constructor(options: FormFieldOptions<T>) {
        // Does not work because fieldNameA is of type "symbol | number | string"
        this.fieldNameA = options.fieldNameA;

        // Does work because fieldNameB is ensured to be a string
        this.fieldNameB = options.fieldNameB;
    }
}

Playground Link

Please note: my older comment on this issue is incorrect - keyof never is now string | number | symbol, so Extracting anything from unknown is just the thing extracted.

Is this the same issue ?
`function run<T extends { foo: string }>() {
let key: {
[K in keyof { foo: string }]:
{ foo: string }[K] extends String ? K : never
}[keyof { foo: string }];
key = 'foo'; // OK
let key2: {
[K in keyof T]:
T[K] extends String ? K : never
}[keyof T];
key2 = 'foo'; // NOT OK
}`

@amoscatelli No, the issue there is that conditional types ignore the constraints on type parameters when checking assignability, so T[K] extends string ? K : never does not get simplified to K.

Knock knock three years later 😄
What is the update, if any, on this? Extract with keyof Something works as expected for any concrete Something, but as soon as you throw generics into the mix Extract doesn't enforce anything at all... it still is effectively keyof T. I feel like IntelliSense should be able to figure this out, i.e. looking at a simple generic isAGreaterThanB function:
// only extract those types from keyof T which make sense with the '<' operator
function isAGreaterThanB <T>(a: T, b: T, compareOnProperty: Extract<keyof T, string | Date | number>) {
  return a[compareOnProperty] > b[compareOnProperty];
}

Full Playground example.

@princefishthrower Your issue is not related to the original issue. I think you might have misunderstood the usage of the keyword Extract or keyof T.
Taking back the interface ISomething with slight alteration to the names:
interface ISomething {
    foo: string;
    bar: Date;
    baz: number;
    qux: () => void;
    quux: { foo: string; };
    corge: symbol;
}

type Keys = keyof ISomething; // 'foo' | 'bar' | 'baz' | 'qux' | 'quux' | 'corge';
type ExtractOfKeys = Extract<Keys, string | Date | number>; // 'foo' | 'bar' | 'baz' | 'qux' | 'quux' | 'corge';

Since the keys of ISomething are all strings, Extract returns the full list of keys.
My guess is you want only the keys foo, bar or baz, since they are of ordered types. Instead of Extract, you might be looking to use the following "FieldOfType" type:
type FieldOfType<Type, ValueType> = { [K in keyof Type]: Type[K] extends ValueType ? K : never }[keyof Type];
function isAGgreaterThanB<T>(a: T, b: T, compareOnProperty: FieldOfType<T, string | Date | number>) {
    return a[compareOnProperty] > b[compareOnProperty];
}

type FieldsOfType = FieldOfType<ISomething, string | Date | number>; // 'foo' | 'bar' | 'baz'

Here's a Playground Link if you want to play with it.

We're very unequipped to deal with this sort of code.
The core question being posed this code is, in essence, does any possible instantiation of WithoutFooGeneric produce a type such that Extract<keyof P, string> produces a supertype of "foo" ?
That's sort of an easy question when the constraint is a simple object type like { "foo": string }. But I don't see a tractable path forward in the general case. Consider other constraints you could write:
type WithoutFooGeneric<P extends Partial<Record<"foo" | "bar", string>>> = Omit2<P, "foo">;

This should be an error, since writing
type A = WithoutFooGeneric<Record<"bar", string>>

violates the constraint of Omit2
But how is this error even found? It's not through instantiation of the constraint; that won't work - that fails to catch the error here
// k: "foo" | "bar"
type K = Partial<Record<"foo" | "bar", string>>;

Given an arbitrary constraint T extends C, there are very few things that can be readily determined about any possible instantiation of T -- you can't just use C as-is and get correct answers out of the other side, as shown by the Partial example. We have some logic in place when relating T as a subtype, but once you take a contravariant operation like keyof T, all bets are off.
So TL;DR this isn't the kind of thing someone can just put up a bugfix for - it implies a very large new kind of reasoning to be able to fix beyond the specific case presented here (aside: fixing only specific cases usually makes everything much worse later).


⚠ Samsung has degraded performance

In a11464b, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2684 ms

Resolved: Samsung performance has improved in 3a735b1.


Sometimes reg_loss ==0 and it always on cpu

Thanks for your code,I have benefited a lot
torch.stack(regressions_losses).mean(dim=0, keepdim=True)
All input tensors must be on the same device. Received cuda:0 and cpu

I have the same problem, and I found that the problem occurred when the image has no annotations.
About some coco Images missed the annotation can see:
https://github.com/cocodataset/cocoapi/issues/76
/retinanet/losses.py  line 51~73 is designed for solving the problem of missing annotations, but in line 64, 78 probably have some error.
For me, just change /retinanet/losses.py 64, 78, and then the problem can be solved
from:
regression_losses.append(torch.tensor(0).float())
to:
regression_losses.append(torch.tensor(0).float().cuda())

Problem has been reported here as well : #197 and #174
I hope @yhenon finds some time to fix it in the master branch.
Create PR ?

I have the same problem, and I found that the problem occurred when the image has no annotations.
About some coco Images missed the annotation can see:
cocodataset/cocoapi#76
/retinanet/losses.py  line 51~78 is designed for solving the problem of missing annotations, but in line 64 probably have some error.
For me, just change /retinanet/losses.py 64 and then the problem can be solved
from:
regression_losses.append(torch.tensor(0).float())
to:
regression_losses.append(torch.tensor(0).float().cuda())
Yes, I fixed it, thank you


Update stuff to use provenanceio-bot

Summary
Update the following to use provenanceio-bot.

The  .github/workflows/proto-registry.yml action should use that account to create the PR.
The protoBindings/gradle.properties stuff should use it for maven publishing.

Problem Definition
Currently, the PRs are created by Ergel's account. We should not be doing that anymore.
Proposal
Update the secrets, workflow and the provenanceio-bot account so that the workflow creates a PR using the bot account.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Forgot to link the PR. This was resolved with #1605.


Pseudo-class :hover styles should also be enabled with the class selector .hover

It's not uncommon to have to enable the hover state of an element, even if the element isn't actually being hovered. For example, highlighting multiple related table rows, showing a link/button that will be pressed when a user performs an action, or the need to activate hover states if you have custom mouse/keyboard input.
Adding .hover to any selectors that implement :hover will allow elements to manually activated with js.
The current workaround involves copying the style and manually implementing .hover.
It would be a nice, relatively simple feature that will resolve this common anti-pattern.
Note: Psuedo-classes :active and :focus have .active and .focus respectively already for buttons. So you can style a button as being active or focused even if they aren't, so I believe it makes sense to style a button as being hovered too.

If admins feel this is worthwhile I would be able to put together a PR for this

Looks good @kkirsche. Thanks!

My pleasure :smiley:

:+1: but documentation tho?

.focus is used for our JS button behaviors and .active is used for our dropdowns. Currently we make no use of .hover and I'm not too keen on adding a bunch of duplicate selectors to our CSS on the chance folks might use them.
Moreover, we're not adding features to v3 anymore, if we indeed classify this as one.

Punting per my last comment.


Update: Remove the Understanding Projects, Resources, and Services page from the Introduction.

The Understanding Projects, Resources, and Services page makes the introduction section feel cluttered. Also, the page contains outdated definitions. The terms "Project" and "Service" get defined in the quick start guides already. If we need these terms explained, my recommendation is to have a separate "Concepts" page where we define Amplication-specific words.

This issue is taken care of in #389 in this specific commit.


[Overview] Issues reg. EU digital COVID certificates

This is an overview over all open Issues regarding EU digital COVID certificates (to keep track and avoid duplicates). Please note that the issues that only affect vaccination certificates are listed in #312.

Issue
Title
Status
JIRA

#611
Check different schema versions if certificates stored for the same person / vaccination...
OPEN
EXPOSUREAPP-9052

#621
Proof of non-vaccination
OPEN
EXPOSUREAPP-9059

#637
Remove technical expiration date for test certificates
OPEN
EXPOSUREAPP-13584

#672
Visualize (medically) expired test certificates in the presentation screen
OPEN
not mirrored

#694
Button "Gültigkeit Prüfen" on the Certificate tab is misleading about its purpose: Suggestion for a gamified
OPEN
EXPOSUREAPP-10703

#704
Photo(s) of identity card
OPEN
EXPOSUREAPP-10778

#708
Improve User and Certvalidation with Userphoto
OPEN
EXPOSUREAPP-11178

#711
Add information about the test used in certificates
OPEN
EXPOSUREAPP-10987

#715
Combined Test + Vaccination QR Code for 2G+
OPEN
not mirrored

#727
Accept new type of certificates
OPEN
EXPOSUREAPP-11343

#730
Printfeature for proof in credit card format
OPEN
EXPOSUREAPP-11154

#761
Enhancement to New G-level label display
OPEN
EXPOSUREAPP-11430

#769
Discourage "visual validation" of DCCs
OPEN
EXPOSUREAPP-11546

#783
Deleting a test DCC should delete the corresponding test
OPEN
EXPOSUREAPP-11781

#797
Cannot request QR code for already existing negative test certificate
OPEN
EXPOSUREAPP-12150

#802
Set the "Status Nachweis" to invalid while tested positiv
OPEN
EXPOSUREAPP-12148

#812
Automatische Löschung abgelaufener Zertifikate
OPEN
EXPOSUREAPP-12137

#823
"Certificate Grouping" based on NON-standardized names ("nam/fn" and "nam/gn") instead of standardized names
OPEN
EXPOSUREAPP-12910

#834
Importing renewed certificate makes certificate duplicate
OPEN
EXPOSUREAPP-13457

#849
Display certificate on locked screen to avoid authority abuse
OPEN
not mirrored

#857
Button to increase brightness for QR certificate tab
OPEN
EXPOSUREAPP-12360

This overview was last updated on 21.02.2023 (dd.mm.yyyy).

As CWA development is ending, I'm discontinuing this overview.


iohook\iohook-master\builds\node-v57-win32-ia32\build\Release\iohook.node is not a valid Win32 application

Current Behavior
module.js:664
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: \\?\D:\xx\iohook\iohook-master\builds\node-v57-win32-ia32\build\Release\iohook.node is not a valid Win32 application\\?\D:\xx\iohook\iohook-master\builds\node-v57-win32-ia32\build\Release\iohook.node

I installed it and did not complain
npm install
npm run build
Your Environment

Version used: 0.1.15
Environment name and version: nodejs 8.9.3  32bit
Operating System and version: windows10 64bit

Hi there ! We're happy to help :)
Could you please use the template we provide for the issue ? i.e. What are you trying to do ? How did you install the package ? (from npm ? from this repository ?)
Thanks!

iohook.node is:

actually a 64-bit module
32-bit module, but it's linking to a 64-bit module

Perhaps CMake or Visual Studio is installed as a 64-bit causing it compile a 64 bit binary (instead of 32bit)?

I'm having the same issue with @jesperjohansson.

I'm having the same issue too

same issue for MacOS

I was getting the same error while running an electron app on a Windows 7 32 bit machine with the ia32 target, same as @lixinxiaobai
I setup a true 32bit Windows enviroment to rebuild the iohook native addons and subsequently the electron app and happily shipped today.
I believe @matthewshirley is correct in saying that the ia32 prebuilds currently published were infact 64bit wrapped in 32bit somehow.
My electron app had other native addon dependencies, namely active-win which required an electron-rebuild on the 32bit environment.
I have pushed the ia32 builds for node and electron ABI 57 to this repo - as those I can confirm work. I did add a readme with links to the tools used and steps followed to create these builds.
For now, as a workaround in my electron app, I store these builds in the project and replace the addon files downloaded by yarn for iohook in a postbuild script.
Hopefully the builds in the repo work for the guys having issues and help figure out the root issue on the published ia32 windows builds.

Hi there, closing this as we now have theses binaries.

I am running into the same issue with "node-64", "electron-64"..
Please help

Hi @aizaku , could you please open a new issue with your problem ? Thanks !

@Nubuck It works perfectly. Thanks you so much.


Migration to Swift 3

Create a new swift3 branch and update the APIs to be conform to the Swift API Guideline.

There's a branch for PromiseKit now: https://github.com/mxcl/PromiseKit/tree/swift-3.0

I'm waiting for https://github.com/CocoaPods/CocoaPods/issues/5864 before to be able to publish the new version.

Will this library be using PromiseKit 4.0?

@jonybur Yes of course! The new version will be released today. ;)

V.2.0.0 is now out!


404 when generating app

Hi there,
i receive a 404 when trying to generate an electron app for win32:
My code:

electron-packager ./ video-call --platform=win32 --arch=x64 --version=0.0.1

Error:

Downloading electron-v0.0.1-win32-x64.zip
Error: GET https://github.com/atom/electron/releases/download/v0.0.1/electron-v0.0.1-win32-x64.zip returned 404
[ [Error: GET https://github.com/atom/electron/releases/download/v0.0.1/electron-v0.0.1-win32-x64.zip returned 404] ] undefined

thanks,
Daniel

This sounds like the same thing as #137.  The value of --version is the electron version you want to use, not your app's version.

Renaming --version to --electron-version atleast removed that 404 error. Now the package is downloading. Will update here is this solution fixed it completely or not

--electron-version was never implemented. --version is now an optional parameter, it will be inferred from the version of electron-prebuilt that you have installed if you do not specify it.

Also, the --app-version parameter was added in the same release (5.2.1).


[STORM-3494] use HdfsLoginUtil singleton to login to hdfs

refer to https://issues.apache.org/jira/browse/STORM-3494
Use HdfsLoginUtil singleton to login to hdfs exactly once for a process.

Travis build failed due to non default config of storm.hdfs.login.plugin available. Will look into it.

Will redo this when ready


[Enhancement] Auto-Verification on page-update.

Check via API call if the latest page_verification hash of the page is the current on buffered.
If not run the verifier again and override the buffered data.

Done in https://github.com/FantasticoFox/VerifyPage/commit/8421afa2f5c83e308814283a2c100e7437eb8d59


stable_id mapping updates: replace production-rh7 queue to production-rh74

…-rh74
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
Review the contributing guidelines for this repository; remember in particular:

do not modify code without testing for regression
provide simple unit tests to test the changes
if you change the schema you must patch the test databases as well, see Updating the schema
the PR must not fail unit testing

Description
The "production-rh7" was hardcoded in many places. I replaced them with production-rh74.
Using one or more sentences, describe in detail the proposed changes.
Use case
we are not using production-rh7, so jobs couldn't run.
Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
Benefits
Now things are running.
If applicable, describe the advantages the changes will have.
Possible Drawbacks
We many need to remove hardcoded parts.
If applicable, describe any possible undesirable consequence of the changes.
Testing
I did run a full run and it looks ok.
Have you added/modified unit tests to test the changes?
no
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?

There is an issue with copyright dates. I will fix that.

There is an issue with copyright dates. I will fix that.

Coverage increased (+0.07%) to 82.232% when pulling f4c2b179bf0a100a423f1648e3b30b23836d77d8 on kbillis:master into e426879461aa94ebc8f063f3e9c58f135262c093 on Ensembl:master.

Coverage increased (+0.07%) to 82.232% when pulling f4c2b179bf0a100a423f1648e3b30b23836d77d8 on kbillis:master into e426879461aa94ebc8f063f3e9c58f135262c093 on Ensembl:master.


Right panel empty

When I make a change (remove a couple of lines for example), save and then toggle split diff. The left shows everything red as removed and the right panel just shows an empty file and 1 empty line.

Yes, this package opens a new panel if there isn't two open so that you can paste the text you want to diff your original file with.
If there are already two panels open, it will diff the two panels. So if you have two files you want to diff, you would open them side by side and then toggle this package.
Let me know if you need any further clarification.

Wow, sorry for creating this "issue" for some reason I thought this would show my difference based on git, so last committed version compared to the what you are currently doing.

Definitely not a problem! I am hoping too add ability to diff with last committed at some point. ( #8 )
For now, https://atom.io/packages/git-time-machine might fulfill your need.


HHH-15500 Cache key is huge since migration to 6

https://hibernate.atlassian.net/browse/HHH-15500
Alternative to https://github.com/hibernate/hibernate-orm/pull/5295
The main motivation for the alternative is to not change existing contracts and thus keep backwards compatibility. In https://github.com/hibernate/hibernate-orm/pull/5295 BasicType does not implement CacheKeyValueDescriptor anymore and all subtypes of AbstractStandardBasicType now return a JavaTypeCacheKeyValueDescriptor.
This implementation instead implements delegation to a new JavaType#toCacheKeyDescriptor method in the concrete BasicType implementations, as well as some racy caching. Certain java types that might be used as primary key types have been adapted to return constant CacheKeyValueDescriptor instances, to reduce the serialization footprint of cache keys.
Another optimization has been implemented which reduces serialization footprint even further and also removes a megamorphic call site in the most common case, which is when the CacheKeyValueDescriptor is DefaultCacheKeyValueDescriptor.INSTANCE, in which case we initialize null for CacheKeyImplementation#cacheKeyValueDescriptor. The code was adapted to use standard equals/hashCode methods when that is null.

I'll go ahead and merge this, as this is a general improvement, not just for Redis as cache provider. We can do further improvements in additional PRs in case you have specific ideas @Sanne


[go] Fix a minor code-example bug

In the Zero-value fields section there is a minor mistake in the code examples, this change removes that.
PS: Thanks for making these styleguides publicly available!

Thanks for the patch! This repository is managed internally so we cannot merge it directly. I'll get this integrated in our repo and have it pushed this week.

Thanks for the patch! This repository is managed internally so we cannot merge it directly. I'll get this integrated in our repo and have it pushed this week.

Yes, I saw that in the issue-template. Perfect! Thanks for the quick response!!

The fix has been applied upstream and pushed. Thanks again; I'm closing the pull request now.


[FLINK-5417][DOCUMENTATION]correct the wrong config file name

As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them.

I use Illustrator to edit svg file, which will add some header infos that cause CI failed. Is there any prefered svg editor?

you should be able to open the svg file with any text editor and add the license manually.

I will take a look at these changes.
Just a small note: We are not getting notified of pushed changes, a small comment is always good to get attention ;)

When viewing the documentation in firefox there is now a lot of whitespace above the diagram. The dimensions have slightly changed as well :/

Hi @zentol , I've updated the svg using Inkscape.
Is the whitespace you refer to on the topest(the red highlighted part)? I think it's normal as the original one has them to. It would not affect view in documents.

well that's the thing, i did rebuild the documentation and in the new version the whitespace was shown. The old version didn't have that. I'll try the updated version and will make screenshots if i see it again ;)

Nice, the updated version is better :)

I guess it is probably that the illustrator added sth.

Could be; it's a bit frightening to see how much the results differ based on which application one uses :/
Anyway, I will add this to my batch of commits to merge. However, the massive diff drove me crazy, so I massaged the svg file a bit and the diff is now a bit smaller (see here: https://github.com/zentol/flink/commit/4c8d2bde83aeb9d066845c26ea937228d077f867). Hope you don't mind that.

Surely not :)


How we could know if the result for addAdditionalSuccessPurchaseListenerIOS is false?

How we could know if the result for addAdditionalSuccessPurchaseListenerIOS is false?
  try
    // Will return a purchase object with a receipt which can be used to validate on your server.
    const purchase = await RNIap.buyProduct('com.example.coins100');
    this.setState({
      receipt: purchase.transactionReceipt, // save the receipt if you need it, whether locally, or to your server.
    });
  } catch(err) {
    // standardized err.code and err.message available
    console.warn(err.code, err.message);
    const subscription = RNIap.addAdditionalSuccessPurchaseListenerIOS(async (purchase) => {
      this.setState({ receipt: purchase.transactionReceipt }, () => this.goToNext());
      subscription.remove();
    });
  }

Should I put another try/catch block around addAdditionalSuccessPurchaseListenerIOS?

Hi! Thank you for the concern. Since listener is just sending an event, you don't need to wrap that with try and catch statement.


Can't login:  POST http://localhost:8080/api/login 500 (Internal Server Error)

If adding your routes inside the web middleware doesn't work for any reason then try adding this to $middleware into Kernel.php
protected $middleware = [
        //...
        \Illuminate\Session\Middleware\StartSession::class,
        \Illuminate\View\Middleware\ShareErrorsFromSession::class,
];

If adding your routes inside the web middleware doesn't work for any reason then try adding this to $middleware into Kernel.php
protected $middleware = [
        //...
        \Illuminate\Session\Middleware\StartSession::class,
        \Illuminate\View\Middleware\ShareErrorsFromSession::class,
];

Thanks! It worked.


Block explorer UI edit: create validators page

We decided we're going to have a separate validators and connected peers page; we currently only have a connected peers page that it called "validators".
Create a page solely for validators.

ready for review @hoffmannjan. this is basically exactly like what is in cspr.live, but it's a decent enough set up and we can modify from here.

For now we will miss Validator Name because we don't have a list like this... But otherwise looking fresh 👍


[Bug] Deletion fails in Flink SQL Client with an UnsupportedOperationException

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
Paimon 0.4.0-incubating
Compute Engine
flink-1.17.0
Minimal reproduce step
Following https://paimon.apache.org/docs/0.4/concepts/file-operations/

Create the catalog and the table in Flink SQL Client and insert some lines into the table.
Set runtime-mode to 'batch'.
Try to delete some of the lines.

What doesn't meet your expectations?
Throwing an exception:
[ERROR] Could not execute SQL statement. Reason:
java.lang.UnsupportedOperationException: Can't perform delete operation of the table paimon.default.T because the corresponding dynamic table sink has not yet implemented org.apache.flink.table.connector.sink.abilities.SupportsRowLevelDelete.

Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi, this is because DELETE/UPDATE syntax is supported in Paimon-0.5 (current master). Please use 0.5 snapshot jar to do the test.


Document default interpretation of http layer

The http library assume a lot of defaults for encoding, status code etc. I don't believe we have a documenation on that
Encoding

bytes does base64 when inside of json payload
utcDatetime and offsetDateTime, use rfc3339 unless in header and then use rfc7231
duration use iso8601

Other

default  status code is:

400-5xx if @error
200 otherwise

Random thoughts:

collection format for array in query ?

I just ran into this error after upgrading to 0.44

53:5 - error @typespec/http/query-format-required: A format must be specified for @query when type is an array. e.g. @query({format: "multi"})
53 |     @query id: string[]
|     ^^^^^^

I'm hoping we can find an alternative to bringing bad OpenAPI v2 design forward and confusing it with JSON Schema "format".


Take a look at the the quick getting started guide. For Cluster Manager users, learn more about where you can find you favorite features in the Dashboard UI.

Setup

Rancher version:
Browser type & version:

Describe the bug

To Reproduce

Result
Expected Result

Screenshots

Additional context

Detailed Description

Context

the Last You should be Your...?

@busyboy77 Please can you provide more detail, specifically filling out the issue template including the version in which you see that typo? Is this in the UI or separate documentation?

This is in the Getting Started box in HOME section in the Rancher UI
Image attached


Feature: Kinesis Event Source Mapping - 'Enabled' property as per the console/cloudF.

Hi,
Can an 'enabled' property of the kinesis event source mapping be added inline with console and raw cloud formation:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html
At least based on the documentation for SAM this does not appear to be supported?
Thanks

Looks like it's in there: https://github.com/awslabs/serverless-application-model/blob/0bb8ef767eff54640297e52115fd84b0e2b85165/samtranslator/model/lambda_.py#L57
It's not mentioned in https://github.com/bedge/serverless-application-model/blob/f1d2a879b1bacc52c1f8a31c21f4a5eabb62bd51/versions/2016-10-31.md#kinesis but the following should work:
Type: Kinesis
Properties:
  Stream: arn:aws:kinesis:us-east-1:123456789012:stream/my-stream
  StartingPosition: TRIM_HORIZON
  BatchSize: 10
  Enabled: True

Awesome thanks will close this then
On Thu, 3 May 2018 at 08:18, Joris Conijn<EMAIL_ADDRESS>wrote:

Looks like it's in there:
https://github.com/awslabs/serverless-application-model/blob/0bb8ef767eff54640297e52115fd84b0e2b85165/samtranslator/model/lambda_.py#L57
It's not mentioned in
https://github.com/bedge/serverless-application-model/blob/f1d2a879b1bacc52c1f8a31c21f4a5eabb62bd51/versions/2016-10-31.md#kinesis
but the following should work:
Type: Kinesis
Properties:
Stream: arn:aws:kinesis:us-east-1:123456789012:stream/my-stream
StartingPosition: TRIM_HORIZON
BatchSize: 10
Enabled: True
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/serverless-application-model/issues/414#issuecomment-386209968,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATIvhaXDsLwp4eplUJz5WEdHhRgH97Yhks5tuq9UgaJpZM4TwEQF
.


Add support for #include directives in shader code

As the code base gets bigger, it is expected that some utility functions and SSBO will appear across multiple shader files. To reduce the quantity of duplicate shader code, it would be useful to support #include directives for shaders (see glCompileShaderIncludeARB and glNamedStringARB).

Issue transfered to https://github.com/scilus/dmri-explorer/issues/3


Rename .NET Core to .NET

.NET Core is EOL and the new name is simply ".NET"

Hi @sander1095. Thanks for raising this issue. I fixed the items you mentioned, plus several other locations in this repo where a simple .NET Core to .NET change was enough. There are some other topics where making the change will be more complicated. I've created a list of those so we can address them in the future. The changes should be live today.

Hi @alvinashcraft . Im glad to hear you fixed it, but my PR that I created for this is still open


HTML real-time report can't be loaded due to insecure WebSocket connection

There's already a thread regarding this issue: https://github.com/allinurl/goaccess/issues/2522. However, I'm not using docker, so that solution won't work for me. I use GoAccess to monitor apache2 logs of a site working on the port 80, while the GoAccess real-time report is set to be accessible from the port 8080. Both of my virtual hosts operate under the same TLS certificate. The non-real-time HTML report can be accessed just fine. However, real-time updates use the port 7890, too, and I don't know how to prevent browser from saying it's insecure.
Mixed Content: The page at 'https://example.com:8080/stats.html' was loaded over HTTPS, but attempted to connect to the insecure WebSocket endpoint 'ws://example.com:7890/'. This request has been blocked; this endpoint must be available over WSS.
Uncaught DOMException: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.

Just noticed that the file where the magic takes place on in the linked issue is the GoAccess' config, not Docker's. I had to specify ssl-cert and ssl-key there, as well as to rebuild GoAccess with the --with-openssl option. The issue is solved now.


Set GENESIS_FORK_VERSION to a bytes4 constant

Issue
It's suboptimal that we have to convert GENESIS_FORK_VERSION with int_to_bytes4(GENESIS_FORK_VERSION) everytime we use it.
Solution
We define that a "fork version" is a bytes4 object universally.

Agreed this is an improvement :)
FYI, @djrtwo disagrees with us—see here. I still think this is the way forward :)

@JustinDrake @djrtwo
Whoops! Sorry for that I missed that #764 was there!
If human-readability is a problem, we could have both ForkVersion: bytes4 and ForkNumber: uint32.


Update kullo to 53.0.0

After making all changes to the cask:

[x] `brew cask audit --download {{cask_file}}` is error-free.
[x] `brew cask style --fix {{cask_file}}` left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 5b0aee760af6c0105c949417d65bc03e02af7c45. Your contribution is still credited to you.


Job doesn't find appspec file

I'm trying to build and deploy on a Jenkins node, and as long as the appspec has no "Per Deployment" configuration, the job completes (i.e., regular appspec.yml)
If I choose the option of "Appspec.yml per Deployment Group", the job never completes with the following error:
Failed CodeDeploy post-build step; exception follows.
/appspec.staging.yml file does not exist
java.lang.IllegalArgumentException: /appspec.staging.yml file does not exist
	at com.amazonaws.codedeploy.AWSCodeDeployPublisher.zipAndUpload(AWSCodeDeployPublisher.java:349)
	at com.amazonaws.codedeploy.AWSCodeDeployPublisher.perform(AWSCodeDeployPublisher.java:230)
	at hudson.tasks.BuildStepMonitor$2.perform(BuildStepMonitor.java:32)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:736)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:682)
	at hudson.model.Build$BuildExecution.post2(Build.java:186)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:627)
	at hudson.model.Run.execute(Run.java:1749)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:419)
Build step 'Deploy an application to AWS CodeDeploy' marked build as failure
Finished: FAILURE

I've tried using a custom Workspace, and even copying the file to the remote FS root to no avail.
Any help on how to successfully build and deploy from a node would be greatly appreciated.

Merging this with https://github.com/awslabs/aws-codedeploy-plugin/issues/63 as they appear to be overlapping issues.


kubeblocks  集群版本目前还是0.11.0 麻烦抽空更新到最新版本吧

Feature request / 功能建议

Motivation / 动机

Your contribution / 您的贡献

Now Xinference on kubeblocks is maintained by Kubeblocks team, refer to https://kubeblocks.io/docs/preview/user_docs/kubeblocks-for-xinference/manage-xinference for more information.


change default setting "local" to others

After install splunk universal forwarder (agent) , the input and outputs are set to folder /opt/splunkforwarder/etc/system/local.
With which variable I can use to change to my defined folder? For example, set to
/opt/splunkforwarder/etc/system/ABC

@SydOps in init.pp there is a parameter called $splunkhome   $splunkhome/etc/system/local is the location that Splunk wants you to put local site-wide configs. If you want app specific config changes, you could deploy them in a Splunk App/TA which you could deploy either with this module or with a Deployment server.
http://docs.splunk.com/Documentation/Splunk/6.2.5/Admin/Configurationfiledirectories

$SPLUNK_HOME/etc/system/local
Local changes on a site-wide basis go here; for example, settings you want to make available to all apps. If the configuration file you're looking for doesn't already exist in this directory, create it and give it write permissions.

Thanks, I am fine with this issue now.


Fix all warnings and enable warnings as errors in CI

We'll soon merge #39, which fixes #36. The next step is to fix all the current warnings in the code, and enable warnings in CI to avoid new warnings sneaking in. To enable warnings as errors in CI, change DWARNINGS_AS_ERRORS to ON in linux\build.sh.
There might be some warnings we don't want to fix, those should be added per compiler in CompilerOptions.cmake

Just merged #47 , so this should be simpler now.

This was fixed in #52


Running vaccum in Docker  introduces an EOF error.

Hi,
I'm trying to check a yaml file within docker.
Locally, vacuum does not creates this error with the same yaml file.
I searched for the cause of this error in the source-code and in the libopenapi dependency, but i wasn't able to find it.
I would like to fix this, but i need at least a hint what goes wrong or which component is creating the error.
Error:
# Schemas Issues

Line / Column | Severity | Message                                        | Path
(1:1)         | error    | Swagger specification cannot be validated: EOF | $

Dockerfile
FROM alpine:latest
RUN apk --no-cache add curl && \
    curl -fsSL https://quobix.com/scripts/install_vacuum.sh | sh

COPY ./openapi /tmp/api

WORKDIR /tmp/api/core/
RUN vacuum lint -d test.yaml

test.yaml
openapi: 3.0.3
info:
  version: 1.0.0
  description: test
  title: test
servers:
  - url: 'https://test.de'
tags:
  - name: xxx
    description: xxxx
components:
  schemas:
    Version:
      type: object
      properties:
        version:
          type: string
          description: The version of the service
          example: 2<IP_ADDRESS>33
      required:
        - version
paths:
  /core/tenant/v1/version:
    get:
      operationId: version
      tags:
        - xxx
      description: Gets the version of the service
      responses:
        '200':
          description: version of the service
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Version'

I'll take a look a this today, it feels like an IO error of some kind

I think this is a bug that I introduced the other day when adding support for OpenAPI 3.1 schemas. The 'Swagger specification' part of the message is the giveaway, it thinks its a swagger spec, not an OpenAPI spec. The patch version of the spec is the culprit I think. I am going to run a couple of tests.
This error persists outside of docker, so it's not a docker issue, I think its a bug from me.

This should now be resolved on 0.0.26, it was an oversight on my part in libopenapi.
https://github.com/pb33f/libopenapi/commit/c099e0def5e5f2cc646785ca71dd5322b6bd994e

Hi, the version 0.0.26 works and the EOF error is gone.
Thank you so much!


[CORE] Rework planner C2R / R2C code with new transition facilities

Transition will stand for interchanges between different in-memory data formats.
The enhancement includes:

Union current C2R / R2C / C2R2C / (future) C2C code together with centralized management for transitions.

Remove old rules for inserting C2R / R2C / C2R2C transitions.
Remove C2R / R2C creation APIs from SparkPlanExecApi.

Extensible convention API:

Convention will be bound to each individual plan operator to describe its supported output in-memory format.
Convention will consist of RowType and BatchType
BatchType is extensible with predefined API
When a new BatchType is defined, the relevant to-row / from-row / to-other-batch / from-other-batch transitions can be defined at the same time.

Insert transitions:

Remove old rules for inserting C2R / R2C / C2R2C transitions.
Remove code that will remain unused from PlanUtil.
Add a new rule to add transitions using the new facility. In the new rule, Gluten will find the cheapest defined transition for two adjacent plan operators.

Fixed in https://github.com/apache/incubator-gluten/pull/5767


Content-Type in config.yml doesn't work

i try to setup a handler in config.yml, but the "Content-Type" doesn't work in request.
config.yml:
guzzle:
  clients:
    test:
      base_url: "testurl"
      options:
        auth:
          - "username"
          - "passwort"
        verify: false
        debug: true
        headers:
          Content-Type: "application/x-www-form-urlencoded; charset=utf-8"

Now when i call:
$client = $this->get('guzzle.client.test');
$request = $client->post(url, ['form_params'=> $body]);

the charset is not set.
But when i set the headers in post-call:
$request = $client->post(url, ['form_params'=> $body, 'headers' => [
                'Content-Type' => 'application/x-www-form-urlencoded; charset=utf-8'
            ]]);

The Charset is correct set

You are totally right. I will fix that asap.
Until than you can use a workaround to set headers by the deprecated approach (using headers directly on root hierarchy  of client.
Example:
guzzle:
  clients:
    test:
      base_url: "testurl"
      ## START: DEPRECATED BUT WORKING APPROACH
      headers:
          Content-Type: "application/x-www-form-urlencoded; charset=utf-8"
      ## END: DEPRECATED BUT WORKING APPROACH
      options:
        auth:
          - "username"
          - "passwort"
        verify: false
        debug: true

I try that too but that also doesn't work.
Only when i set the Content-Type in Post-Call it work.

I've tried it again and it works for me by using following code:
config.yml:
guzzle:
    logging: true
    clients:
        httpbin:
            base_url: "https://httpbin.org"
            headers:
                Content-Type: "application/x-www-form-urlencoded; charset=utf-8"
            options:
                verify: false
                debug: true

Controller:
    public function indexAction(Request $request)
    {
        $client = $this->get('guzzle.client.httpbin');
        $params = ['form_params'=> ['test' => 'aha']];

        $response = $client->post('/post', $params);
        $body = $response->getBody()->getContents();

        var_dump($body);

Output Request:

I used dev-master which is similar to latest stable version 5.2.1.

 Didn't saw this, sorry.
Unfortunately this is something that comes from Guzzle Client. By using form_params this header will be overridden by Guzzle: https://github.com/guzzle/guzzle/blob/master/src/Client.php#L303
So without using form_params everything works like expected (except using headers in options, which is still a bug).

I created a new ticket regarding the override of content-type to split this two "bugs": https://github.com/8p/GuzzleBundle/issues/84

Released v5.2.2, fix: headers in options
https://github.com/8p/GuzzleBundle/releases/tag/v5.2.2
Issue with form_params and content-type will be continued in #84


Add monospace as fallback for "Fira Code"

If "Fira Code" is unavailable on the user's system, the presence of the font-family rule causes code to fall back to the default serif font. The monospace font should be added after, e.g., font-family: "Fira Code", monospace;, in order to fall back to the system monospace font.

Here is a screenshot of the issue:

Thanks, that’s a good point. I’ll fix this ASAP.

Please check update and refresh. It should be fixed RN.
Thanks again for the issue.


Add statsName field on stream while constructing PersistedStateStats

Description
_nodes/stats is failing due to recently added cluster state stats. This PR fixes that issue by writing statsName field on the stream and reads from it to properly created the PersistedStateStats object.
Related Issues
Resolves #10961
Check List

[x] New functionality includes testing.

[x] All tests pass
~- [ ] New functionality has been documented.~
~- [ ] New functionality has javadoc added~

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shwetathareja @Bukhtawar - looking for feedback and review.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29143/
CommitID: 3f295e8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Flaky CardinalityWithRequestBreakerIT - https://github.com/opensearch-project/OpenSearch/issues/10154
Flaky testThreeNodesNoClusterManagerBlock - https://github.com/opensearch-project/OpenSearch/issues/10006

@sachinpkale

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29181/
CommitID: 3f295e8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Another flaky testCancelReplicationWhileSyncingSegments : https://github.com/opensearch-project/OpenSearch/issues/10902
Flaky testThreeNodesNoClusterManagerBlock - https://github.com/opensearch-project/OpenSearch/issues/10006

LGTM!


We have a duplicate of kirya reported.

Here are the accounts.

thank you for pointing this out

I'll raise a PR for this


Add - Javascript The Right Way

Nice guide to javascript.
:)

double this one 👍

This looks fantastic!
@weber97 - can you fix the merge conflicts and I'll merge the PR? Thanks

@bmorelli25 - It's done.

moved it into the courses/tuts section.


Long org/repository names can cause conflicts on the state machine naming

This line (https://github.com/CloudSnorkel/cdk-github-runners/blob/main/src/webhook-handler.lambda.ts#L179) in the webhook handler lambda tries to calculate a unique name for the statemachine execution.
However, if the org name and/or repo name is long enough, then there is not enough space for the (actually unique) x-github-delivery header.
I have encountered collisions with a 19 character org name, and a 42 character repository name, as this results in a combined 63 characters (including separators), leaving only 1 character for the x-github-delivery header.
I suggest reducing each component individually, and maintaining a minimum hash length that the  x-github-delivery header cannot go below.

Thanks 🤦🏻

I'm using the following patch in case it helps others
-  let executionName = `${payload.repository.full_name.replace("/", "-")}-${getHeader(event, "x-github-delivery")}`.slice(0, 64);
+  let deliveryId = getHeader(event, "x-github-delivery");
+  let executionName = `${payload.repository.full_name.replace("/", "-").slice(0, 64-deliveryId.length-1)}-${deliveryId}`;


SlimScrollDirective should be exported

After upgrading to v4/5. The directive reference is missing, causing the reference error.
SlimScrollDirective should be exported in public_api.ts.

Can you be more specific what is your issue?
I just tried to include the module in fresh angluar-cli project and have no issues doing it. Also, public_api.ts is included in src/ folder.

@jkuri sorry, i thought the public_api.ts would live in ng-slimscroll folder. Didn't notice its existence.
I've change the title and description

why it should be exported? you can use NgSlimScrollModule just as it says in readme.

@jkuri Could you make a patch release for supporting Angular v5? Some of the users might not be able to upgrade v6 for now, like my team.

The problem is rxjs compatibility.

Another tiny problem is you didn't release git tags for recent release.


feat(swaps): Adding support for new tokens and search box

Description
Adding search box and new tokens to the swaps bottom sheet.
Adding sticky header feature to the Bottom Sheet component.
Test plan
Turn on the config in the swapping_non_native_tokens statsig experiment.
Related issues

Fixes #RET-611

Backwards compatibility
The changes are backward compatible.
Demo
https://user-images.githubusercontent.com/12504748/229369125-821c8221-a82a-4a6a-b687-262dbb9833f5.mp4

@dievazqu I think we can remove a lot of the debounce logic if we use use-debounce for search analytics instead.
const [searchTerm, setSearchTerm] = useState('')
const [analyticsSearchTerm] = useDebounce(searchTerm, 1000)

  // Fire Analytics event when search term changes and is not empty
useEffect(() => {
  if (analyticsSearchTerm) {
    ValoraAnalytics.track(TokenBottomSheetEvents.search_token, {
      origin,
      searchInput: analyticsSearchTerm,
    })
  }
}, [analyticsSearchTerm])

@dievazqu also for some reason this is crashing for me on Android, I have only been able to test on iOS. Since we don't have swap e2e tests this is something to keep in mind.

@dievazqu I think we can remove a lot of the debounce logic if we use use-debounce for search analytics instead.

I'd recommend not adding another dependency which we can be covered by lodash
https://github.com/valora-inc/wallet/pull/3602#discussion_r1157001660

@jeanregisser @silasbw @MuckT - Thanks for the reviews! I have done all the suggested changes
Also I created a PR only with the changes in the bottom sheet to add the sticky header, so it's easier to review :)


Microphone and other improvements

I'm using:

Device name: Redmi Note 9s
Device type (phone/TV): Phone
Android version: 12

I want to suggest these features:

Enable microphone for games

Prevent the app from restarting when connecting a controller, (it's annoying because it closes the game, which doesn't happen in the Kiwi browser)

Create the option for games to enter popup mode when leaving the app, (it's a feature that I think is very good in browsers, it prevents the game from closing, which is good when you need to do something else on your phone without worrying about loading the game again)

Fixed
Fixed

Create a separate issue


Make child reaper private again

We do not have to expose it via the public API so we make it crate public again via getset.

/honk

/release-note-none

woops!


feat(event): include original error for more context

This PR changes the encoding for errors to include the original error in order to see more context in the JSON-ified logs, especially for more complex errors like pgx.Error. The current implementation loses a lot of this context by only include the type and error message, so this hopes to remedy that.
I'm not sure if this could be a bad idea in the event of some error including fields that cannot be marshalled, but I suspect that's probably not very common.

What happens if the underlying type contains a field that can't be encoded?

@tejasmanohar good question, I added a test to make sure that case is handled as well. In summary, anything that cannot be encoded is simply dropped from the payload.

LGTM, get approval from @achille-roussel too

This change breaks unmarshaling of EventErrors:
json: cannot unmarshal object into Go struct field EventError.origError of type error
I don't think it's unreasonable to expect that a type intended to be marshaled into json should also support unmarshaling. I'd also argue we should try to avoid changing public exported types if at all possible.
I propose we roll this back.

I don't think we should roll this back given that it was merged 4 months ago. What are our alternatives? Maybe we could ignore the field in a custom UnmarshalJSON function?

That seems like a pretty reasonable solution.

Just a heads up, the custom unmarshal approach doesn't really work (or at least I couldn't make it work in a way that gave more information than was already available in the error field).  We have a few projects now (ecs-logs, ecs-logs-kinesis, s3logs) that are having to pin older versions because events marshalled by the HEAD of this library cause decode errors when unmarshalled using the HEAD of this library.

Apparently this custom UnmarshalJSON never got written. This is super broken, as DF points out. Anything with the OrigError field set will fail to unmarshal. I propose we either:

switch OrigError to type interface{} so that it unmarshals generically
write UnmarshalJSON so that it discards this field on unmarshalling


Automatically load other assertion libraries

We often get asked a question to which the answer is:
World(Test::Unit::Assertions)

We automatically include RSpec's assertions if the RSpec gem is visible, I think we should fall back and include Test::Unit::Assertions if not. It would just make Cucumber easier to use. Maybe we should also try falling back to Wrong on the way:

Try RSpec
Try Wrong
fall back to Test::Unit::Assertions

I'll try to patch this in myself unless anyone objects.

Sounds good!

+1!


go live

Hello there,
I need your help, I'm new at coding, and I can't see the " go live" option. I downloaded the app for it but I can't see it even when I save my file...
I probably miss something but I really don't know what.
Thanks

/question


Scan panics when passed a pointer to pointer to array

GORM Playground Link
https://github.com/go-gorm/playground/pull/506
Description
In v1.21.15 I was able to Scan into a pointer to a UUID, which is a type alias for [16]byte. This now panics in v1.23.8. I want to scan into the pointer so that the nil value represents the record not existing. Debugging the issue, it looks as if the code attempts to call reflect.MakeSlice on an array type, which leads to the panic.

I tried it in v1.21.15 and it didn't work. The problem here is that if the user scan [16]byte, we don't know if he wants to query multiple records or one record.

I updated the playground PR to be closer to what we have in our actual code -- the Where clause seems to make a difference.

Pointer is unwrapped https://github.com/go-gorm/gorm/blob/master/finisher_api.go#L543 it make scan pointer in pointer possible https://github.com/go-gorm/gorm/blob/master/tests/scan_test.go#L36
So the problem still exists

The problem here is that if the user scan [16]byte, we don't know if he wants to query multiple records or one record.

The problem here is that if the user scan [16]byte, we don't know if he wants to query multiple records or one record.

I agree that it's not clear what the expected behaviour should be. Maybe it would be best to return an error when Scan is passed an array that isn't wrapped in a slice or struct (and document the restriction)? Not sure if that would break API guarantees though.
fwiw I'm working around the issue by wrapping the UUID in a struct, e.g.:
    var result struct {
        MyID *uuid.UUID
    }
    DB.Table("foo").Select("my_id").Where("bar = 12").Scan(&result)

Maybe it would be best to return an error when Scan is passed an array that isn't wrapped in a slice or struct (and document the restriction)? Not sure if that would break API guarantees though.

We can't support both at the same time, so we chose one ( guess user always query multiple records  ), unfortunately you belong to the other, sorry you can only wrap the UUID in a struct.
I think this does have to be stated in the documentation, @chradcliffe are you interested in helping us improve it?


Call for maintainers

Hey FlightJS community!
Twitter is looking for external committers and maintainers for Flight. Are you or your team interested?
If you would like to take responsibility for Flight’s continued development, please say hello in this issue so we can talk.

It would sound promising, but all I see is that you guys are ditching Flight internally? :(

I'm maybe interested.

I'm interested as well.

Hey Tom. Would be happy to join! Some members of my team are interested as well.

I am interested as well.

My team is very small, but we would love to contribute in some small ways.

I am really interested as well.

Would you please invite me to the FlightJS organization(https://github.com/flightjs) so that I can contribute more examples apps for FlightJS?

Hey Tom, count on me if you need some project management help and want to speed up the v2 release.

We are using flightjs a lot and I probably can contribute.

Great, thanks everyone!
If you're up for contributing, I'd love to see some work on some of the open issues for v2. To get started have a look at the helpwanted label, or start submitting and fixing issues on your own!

Hello, what is a status regarding to flightjs? Is it abandoned or not?


Unexpected output from glint -fix and -check plugins

I added the next example to *.gjs test file:
/**
 * JSDoc
 *
 * @param {number} a
 * @param {UnavailableType} b
 *
 * @return {void}
 */
export function think(a, b) {
  return console.log(a, b);
}

and got:
/**
 * JSDoc
 *
 * @param {number} a
 * @param {UnavailableType} b
 *
 * @return {void}
 */
{{! @glint-expect-error @rehearsal TODO TS80004: JSDoc types may be moved to TypeScript types. }}
{{! @glint-expect-error @rehearsal TODO TS7006: Parameter 'a' implicitly has an 'any' type. }}
{{! @glint-expect-error @rehearsal TODO TS7006: Parameter 'b' implicitly has an 'any' type. }}
export function think(a, b) {
  return console.log(a, b);
}

in the example above the expected output is a: number, b: UnavailableType and comment about UnavailableType type.
There are a few problems to fix:

Seems Glint's getCodeFixes doesn't return TS standard fixes... and defiantly not rehearsal ones. We need to make sure all available code fixes are used.
Multiple comments are added to the same error line... but only one comment is expected

@cafreeman ^^^


<_UIKBFeedbackGenerator: 0x28240bd00>: Couldn't update haptics muting for dictation audio recording. No engine.

Bug Report
Overview
when dictation on keyboard is attempted this occurs
<_UIKBFeedbackGenerator: 0x28240bd00>: Couldn't update haptics muting for dictation audio recording. No engine.
To Reproduce
Steps to reproduce the behavior:

Build to iOS device
try to input text using the mic for dictation
notice the static

Expected behavior
the static should not sound
should not see this in xcode

Unsure how this is related to my package.

Sorry, this was for your eleven labs unity plugin


HTTP API support opt outs

In response to the card: https://trello.com/c/6rJ76cdx/1-24-ndoh-http-api-to-support-opt-outs

Do we maybe want whether opt outs are handled here to be configurable somehow (and enabled by default) instead of always being enabled?

Left minor comments, looks good.

Would this be configurable just a global on/off config switch, or should it be per account?

I was thinking a per-conversation on/off switch, but not at all set on that. @rudigiesler @hodgestar thoughts?

If we do a per-conversation or per-account on/off switch, then it would require a migration? Unless we keep a separate table with a list of all the conversations that have opt outs switched off for the HTTP API?

@rudigiesler I was thinking we look it up as a config field in the conversation's config. Sorry, should've been clearer in my previous message.

From the slack discussion, happy with us using the account level opt out flag here instead. We can worry about a per-conversation opt out flag when we need one.

:+1: when travis is happy


Change Stylesheet on Request Bodies to Improve Curly Brace Readability

The choice of style for the request body in the terminal pseudo-emulator for HTTP requests makes the curly braces unreadable. The background and font color are too close to be readable. In particular see the image below for an empty body:
Context

I'd like the text to be more readable.
Current Behavior

The image below of an empty body demonstrates in particular the illegibility of the curly brace text.

Expected Behavior

Possible Solution(s)

Using white or a lighter gray color as you do for the headers would be more legible. The choice of color for the elements, as shown below, make those readable. It's only the curly braces that are difficult to see.

Could you provide a minimal example of how are you are using this? It is possible that one of your classes is overriding the style, as we are not able to reproduce this with any of our example apps.

Using your Bootstrap example with no custom stylesheets:
<!-- Elements: Web Component -->
<script<EMAIL_ADDRESS><link rel="stylesheet"<EMAIL_ADDRESS>
<!-- Twitter Bootstrap -->
<link rel="stylesheet" href="https://stackpath.bootstrapthecdn.com/bootstrap/4.5.2/css/bootstrap.min.css">
<!-- Twitter Bootstrap: Sticky Footer Example -->
<link rel="stylesheet" href="https://getbootstrap.com/docs/4.5/examples/sticky-footer-navbar/sticky-footer-navbar.css">

I certainly can modify one of the stylesheets to get what I want, but I was hoping to avoid customization for ease of maintenance.


How to Deploy Ollama LLM on Cloud-Managed Kubernetes (OCI) (pvc/init container)

How to Deploy Ollama LLM on Cloud-Managed Kubernetes (OCI)
I'm looking for guidance on deploying Ollama LLM using Helm charts on a cloud-managed Kubernetes service, specifically Oracle Cloud Infrastructure (OCI). I have a few questions regarding the deployment process:

Persistent Volume and Data Volume Mounting:

From the values in the Helm chart, how does the ollama-data volume mountPath: "" match the persistentVolume if it's enabled? It's unclear how these values are connected.
Do we need to create the storage class or PersistentVolumeClaim (PVC) manually for the persistentVolume.values to be effective? There isn't much clarity on this in the documentation, and it would be helpful to have an example.

Loading Models with Init Containers:

Is there a way to load the models using an init container into the mountPath before the main pod is spun up? This feature would be useful for preloading models and ensuring they're ready when the main container starts.

The documentation seems limited, making it challenging to proceed. Any examples or additional guidance would be greatly appreciated.
Thank you

@jdetroyes thank you so much for the answers !!

First, if ollama.mountPath is set, it overrides the default mount path of /root/.ollama. In most cases, this value doesn't need to be changed. When persistentVolume is enabled, there are two scenarios:

If persistentVolume.existingClaim is set:
The volume will be attached to the container.
If persistentVolume.existingClaim is not set:
If persistentVolume.storageClass is specified (or left empty), a PVC will be created by the provisioner and attached to the container (See pvc.yaml).

You can specify a StorageClass that is already configured in your infrastructure to automatically create a PVC. Alternatively, if you already have a PVC configured, you can set the persistentVolume.existingClaim field. To disable automatic provisioning, set persistentVolume.storageClassName: "-".

If  I understand well , ollama.mountPath matches either:

The existing claim if specified
Else a new one that is created by the chart through dynamic provisioning by the storageClass

but if StorageClass doesn't exist , the option 2 will not really work am I right .
for now I tried creating local PV and pvc and specified the existing claim but I had below error

I hit  Docker Hub rate limits so I needed to add dockerhub  secret but it's complaining .

W0829 17:43:50.092448    9912 warnings.go:70] unknown field "spec.template.spec.initContainers[0].imagePullSecrets"
Release "ollama" has been upgraded. Happy Helming!

am I missing something ? is it included in the template ?
initContainers:
  - name: install-and-setup-model
    image: python:3.9  # Use an image with Python and pip pre-installed
    imagePullSecrets:
      - name: dockerhub-sec
    command: [sh, -c]
    args:

Hey @brokedba
Docker secrets are shared with all containers in the deployment.
You don't have to add a line in the initContainers, you just have to populate in the values.yaml
# -- Docker registry secret names as an array imagePullSecrets: []

my bad I had corrected   before I could update the post.
the container is still in pending mode now after that change
Events:                                                                                │
│   Type     Reason            Age                    From               Message                                                                                │
│   ----     ------            ----                   ----               -------                                                                                │
│   Warning  FailedScheduling  9m32s                  default-scheduler  0/3 nodes are available: persistentvolumeclaim "ollama" is being deleted. preemption: 0/3 nodes are available: 3 Preemption │
│  is not helpful for scheduling.
││   Warning  FailedScheduling  4m59s (x3 over 9m14s)  default-scheduler  0/3 nodes are available: persistentvolumeclaim "ollama" not found. preemption: 0/3 nodes are available: 3
Preemption is not  helpful for scheduling.

I also noted that the result of the modelfile is truncated  where any line between {{}}} was ignored .
Although the echo or printf commands works manually after the pod is ready.
the below is the final version after I logged in to the container.
FROM /root/.ollama/download/Meta-Llama-3.1-8B-Instruct-Q4_K_S.gguf

# Set custom parameter values
PARAMETER temperature 1.0
PARAMETER stop "<|start_header_id|>"
PARAMETER stop "<|end_header_id|>"
PARAMETER stop "<|eot_id|>"

# Define the model template
TEMPLATE """<|start_header_id|>assistant<|end_header_id|>       <------lines below were all ignored
<|eot_id|>
"""

# Set the system message
SYSTEM You are a helpful AI assistant named e-llmo Assistant.


What counts as a Unicode engine?

From TeX.SX chat (after addition of \Uchar and \Ucharcat)

https://chat.stackexchange.com/transcript/message/52535726#52535726

I guess we might need to talk to them about what counts as a Unicode engine

https://chat.stackexchange.com/transcript/message/52535833#52535833

what does it leave as the Unicode status of upTeX (I'm even more confused by pTeX): as I understand it, upTeX isn't a Unicode-compliant engine

FYI, \Uchar and \Ucharcat are described in 19f0847.

In the base latex2e code there is in most places a binary choice

The engine can load OTF fonts ("fontspec would work") and defaults to TU (Unicode) encoding

The engine is restricted to 256-character tfm fonts and defaults to OT1 ("fontspec will not work")

during format creation latex.ltx  more or less arbitrarily tests \ifx\Umathchar or \ifx\Umathcode to distinguish these, not because math handling is involved, they were just convenient markers that were in xetex and luatex, we could have picked \Uchar..
Clearly the (u)ptex variants make the split between valid input character ranges and allowable font formats somewhat different from the binary split described above, which is OK, as long as we  don't accidentally break it because we don't understand it:-)
In particular is it possible that uptex would need extended character codes in math and add something like \Umathcode?, if it did would the current tests in latex.ltx do the right thing or the wrong thing?
The expl3 expandable upper-lower case changing functions for example assume that \Uchar is available in "unicode engines"  to generate the character, or that you can do an expandable 256 character switch (in non-unicode engines where \Uchar is not available, but 256 characters is all you need)
It may be that most of the tests are OK and will remain OK as  \Uchar is added. We could add some tests, but speaking for myself it is not clear what the right thing is for many of the cases.

@davidcarlisle Sorry for my late response:

In particular is it possible that uptex would need extended character codes in math and add something like \Umathcode?

I don't think \Umath... is possible in the future; we already have \omath... derived from Omega.  Each math fonts can have only 256 characters (compared to 65536 of Omega) because they are defined by TFM not OFM.  We don't have any plan to use JFM for math fonts, partly because JFM can define only 256 different widths (cf. Omega OFM can define 65536 different widths).

The expl3 expandable upper-lower case changing functions

I don't think such functions should be enabled for Japanese character code.  You would not be happy to deal with the strange beasts lying in Japanese encoding ;-)

It may be that most of the tests are OK and will remain OK as \Uchar is added.

It seems that no package in TeX Live uses \Uchar or \Ucharcat to detect Unicode-compliant engines; all of such codes are using \Umath....  Thus, I think it's safe enough.

@aminophen  thanks for the feedback


v2: requests support for back end

Context
part of #248
part of #32
Requirements

[ ] check data integrity of requests table, ensure it is up to date with Airtable

we will likely need to adjust the schema

[ ] create, read, update, delete endpoints for requests
[ ] allow people to click "interested" on a request and store that link
[ ] integrate with GitHub to create issues for requests, and read their status from the app

here's a project. We will pare down the potential status options before we migrate.
we can use github Projects and Labels to keep things organized in a way that can sync to our db
new requests should get a github issue, but admins might need a way to manage their details and vet them for the time being

maybe they go into a private repo at first, and get moved into a public repo when they're ready for volunteers
maybe there's a retool middle layer
doing this in-app feels like a natural extension of #163

@josh-chamberlain Do we want a separate Github project for requests for to funnel them into the current data sources app one?

@mbodeantor definitely a separate project, main comment adjusted

@josh-chamberlain Navigating Airtable is still a challenge for me -- could you point me to the relevant Airtable for PDAP at the moment?

@josh-chamberlain For the data_requests table in PostgreSQL, I'd like to make the following modifications in addition to developing the endpoints:

Change status_last_changed to date_last_changed, for clarity
Add triggers to automatically update the date_created and date_last_changed columns when the relevant actions occur.
Replace request_status's text type with an enum to enforce the permitted statuses (Intake, Active, Complete, Request withdrawn, Waiting for scraper, Archived)
Have all newly created rows have request_status be "Intake" by default

Here is the Airtable Requests table: https://airtable.com/app473MWXVJVaD7Es/tblV2ftkAwaNJfDTJ/viwtwWW7t6Rwaev8X?blocks=hide

Part of the reasoning behind replacing Airtable is to not have to make changes in multiple places (Airtable itself, the script mirroring Airtable to Postgres, Postgres itself). Not sure it makes sense to start make these changes before we move off of Airtable for tracking requests.

@maxachis @mbodeantor yep, this issue = replacing Airtable for requests.

Change status_last_changed to date_last_changed, for clarity

status_last_changed only updates when the status property changes, does that make the name make more sense?

Add triggers to automatically update the date_created and date_last_changed columns when the relevant actions occur.

yep, Airtable handles this automatically but we'd need to

Replace request_status's text type with an enum to enforce the permitted statuses (Intake, Active, Complete, Request withdrawn, Waiting for scraper, Archived)

makes sense

Have all newly created rows have request_status be "Intake" by default

makes sense

@josh-chamberlain @maxachis okay just wanted to be clear that these changes are happening to a new requests table and not the current one

@mbodeantor whatever's best from your perspective, I could see an argument either way. Your call

status_last_changed only updates when the status property changes, does that make the name make more sense?

@josh-chamberlain In which case, I'd like to rename to date_status_last_changed just to make it extra super-duper clear 🙃. It's a minor thing, but I figure if it threw me off it'd throw others off as well. I can add a trigger for that as well.

@josh-chamberlain Do we want to enforce the form of contact information? Looking at the current submitter_contact_info column, a number of the submissions given are of limited use (some just give names or contextless phone numbers, one even simply says "Mail".  Maybe break it down into name, email, and phone number, but also allow them to select an anonymous option?

Current proposed design

ID, Primary Key, Bigint, serial
Submission_Notes, text
Request_status, enum (‘Intake’, ‘Active’, ‘Complete’, ‘Request withdrawn’, ‘Waiting for scraper’, ‘Archived’), defaults to ‘Intake’
Submitter_contact_info, text *
Agency_described_submitted, text
Record_type, text**
Archive_reason, text
Date_created, set to current datetime by default
Date_status_last_changed, update with current datetime whenever the request_status is modified.

*Pending above question
**We may want to look into whether we want enums for this as well.

@maxachis

submitter contact info can just be text for now. the worst offenders were added by me, usually people submit decent info—we can't respond to them if we don't have their contact info. In the future, we may have blank requests, or requests associated with PDAP user IDs
let's also add a column for the github integration
let's add a column linking to the users table, something like submitter_user_id, for logged-in users

@josh-chamberlain Acknowledged! Design updated.

allow people to click "interested" on a request and associate it with their profile

In addition to the above table design, this would likely require an additional linking table to express this relationship. Probably called something like user_interested_data_request

@josh-chamberlain Here is the current structure of the post request, which also details my expectations for what the front end will provide:
    @api_required
    @handle_exceptions
    def post(self) -> tuple[dict, int]:
        """
        Handles the creation of a new data request.
        Expects 'submission_notes' and 'submitter_contact_info' in the request body.
        """
        request_info = RequestInfo(
            submission_notes=request.json["submission_notes"],
            submitter_contact_info=request.json["submitter_contact_info"],
            submitter_user_id=request.json["submitter_user_id"],
            agency_described_submitted=request.json["agency_described_submitted"],
            record_type=str_to_enum(RecordType, request.json["record_type"])

        )
        record_id = self.data_manager.create_request(
            request_info
        )
        return {"message": "Created successfully", "id": record_id}, 201

My questions:

Should I expect this to be the relevant information provided by the frontend?
The post request currently expects all data requests to be submitted. Are there times where we'd want to reject a request, such as if an identical request already exists?

@josh-chamberlain Additionally, what data should be returned on a GET/Read request for a single record? For clarity, here is the current design of the table:
CREATE TABLE requests_v2 (
    id BIGSERIAL PRIMARY KEY,
    submission_notes TEXT NOT NULL,
    request_status request_status NOT NULL DEFAULT 'Intake',
    submitter_contact_info TEXT,
    submitter_user_id BIGINT REFERENCES users(id),
    agency_described_submitted TEXT,
    record_type record_type,
    archive_reason TEXT,
    date_created TIMESTAMP NOT NULL DEFAULT NOW(),
    date_status_last_changed TIMESTAMP NOT NULL DEFAULT NOW(),
    github_issue_url TEXT CHECK (github_issue_url IS NULL OR github_issue_url ~* '^https?://[^\s/$.?#].[^\s]*$')
);

@maxachis

small note: we should probably require "agency or area described"
yes, I think so—attached is a rough screenshot. "project description" is probably just "submission notes".
let's not worry about rejecting them unless they're missing required info; at this point they're all going to be human-reviewed anyway.

@josh-chamberlain
Read/Get
To make sure I'm understanding properly, will each get request return:

submission_notes
agency_described_submitted
record_type
Not Github Issue URL?

Are we additionally returning other information (i.e., the Tasks and Relevant Agencies, if any?). I'm not sure if we have the table set up for that yet.
Update/Put
Will put be used by the user, or by us? In either case, what attributes do we want to be able to modify?

@maxachis

yes, we'll use github issue URL where #NNN is in the screenshot.

Don't worry about tasks and relevant agencies for now—we can iterate from a basic endpoint, which will get us very deep into prototyping.
I peeled off the github integration as a separate issue, plus there's auth. I wonder if we should be scoping those out + progressing there before making it too far down this path anyway?
#299 #296

@maxachis this one is still not at the top of the list or anything, but for posterity: I made many updates to the parent issue reflecting much of what we have discussed.

@josh-chamberlain When users specify the location for a request, I'm wondering if it would be useful to have them select from locations in a manner similar (or identical to) our /typeahead_suggestions endpoint. i.e., they type in the location, and we generate location suggestions for them. Just a thought.

I left a comment on the wireframe to that effect, but I realize I failed to share the theming wireframe (most up to date)


ARROW-12006: [Java] Fix checkstyle config to work on Windows

On Windows checkstyle will fail if you preserve LF endings but this change looks for LF explicitly.

LGTM, can merged once CI is green.

Integration failure is unrelated.


Fix jpeg images uploading rotated in weird ways

Required updating to latest filestack APIs, which is good

Great! 👍  LGTM, except the broken test


Cannot deploy to Azure Container Apps

Please provide us with the following information:

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
I am getting the following error trying to deploy to my Azure container app environment. I have changed no settings with the environment or the container that I am deploying. The same container was able to be deployed last night
Error code
BadRequest
Message
{"type":"https://tools.ietf.org/html/rfc7231#section-6.5.1","title":"One or more validation errors occurred.","status":400,"traceId":"00-33fa8c75329467ff0514954b42323bb4-9b331f3e3dc78d2b-01","errors":{"$":["Unknown properties additionalPortMappings in Microsoft.ContainerApps.WebApi.Views.Version20230501.ContainerAppIngress are not supported"]}}
Steps to reproduce

Deploy revision on Azure container app
..

Expected behavior [What you expected to happen.]
Container to be deployed
Actual behavior [What actually happened.]
Sending this error code:
Error code
BadRequest
Message
{"type":"https://tools.ietf.org/html/rfc7231#section-6.5.1","title":"One or more validation errors occurred.","status":400,"traceId":"00-33fa8c75329467ff0514954b42323bb4-9b331f3e3dc78d2b-01","errors":{"$":["Unknown properties additionalPortMappings in Microsoft.ContainerApps.WebApi.Views.Version20230501.ContainerAppIngress are not supported"]}}
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Ex. Did this issue occur in the CLI or the Portal?
Portal

I am getting the same error when using the Portal to create a new revision via the UI.

Thanks for the bug report. We are investigating.

Issue Update: We've discovered a bug in Portal where an incorrect API version is being utilized for a subset of our users. This affects the updating of the additionalPortMappings property.
Our team is actively working on a fix. We'll provide an updated timeline for deployment soon. We appreciate your patience

same here

Issue Update 3: We have rolled out a fix for this issue across all regions, please let us know if you still face any issue


Grids offset by taskbar on launch if user has set remove_task_bar in config

Version (which release did you use?)
ce4eb76 on development branch
Describe the bug
If the user has "enable remove_task_bar" in their config when launching nog, workspaces will be offset by the size of the taskbar until the user toggles visibility of the taskbar.
To Reproduce
Steps to reproduce the behavior:

Set config "enable remove_task_bar"
Restart nog
Manage a window in a workspace
Note the window doesn't take up the full space of the view

Expected behavior
Managed windows should take up space available if the taskbar is hidden
Actual behavior
Managed windows don't fill the taskbar space if nog is started with the taskbar hidden

This should be resolved by https://github.com/TimUntersberger/nog/pull/153

@keepitsane this should resolve the issue you were describing about the workspaces not using available room from a hidden taskbar

Hmm still seem to be getting the bug with the latest dev build.

@keepitsane interesting..

Can you tell me more about your setup and what your config file looks like and where you keep your taskbar (I'm assuming bottom)?
I know this might seem like a silly question but that screenshot is definitely your browser managed by nog, is that correct? Is that like... you started nog and then launched the browser and managed it manually or do you have it set to automanage?

I did notice the issue on my machine after changing the config, this looks pretty similar to what you're seeing, I think. This is on my build left is the commit before the changes and right is the latest development release build. Steps were... taskbar at the bottom of the screen, start nog with config to hide taskbar & show appbar and then I opened notepad and let nog automanage it.

My config file follows the same structure as the example one provided and yes my taskbar is at the bottom.1. My config file follows the same structure as the example one provided and yes my taskbar is at the bottom.

import "nog/components" as C;

import "modes/resize";
import "keybindings";
import "rules";

set min_height 200;
set min_width 200;

bar #{
font: "FiraCode NF",
font_size: 17,
color: 0x4B326E,
components: #{
left: [C::workspaces()],
center: [C::time("%l:%M:%S %p")],
right: [C::active_mode(), C::padding(5), C::date("%e %b %Y"), C::padding(1)]
}
};

disable work_mode;

enable launch_on_startup;
enable multi_monitor;
enable display_app_bar;
enable remove_title_bar;
enable remove_task_bar;

workspace 4 #{
monitor: 1,
};
workspace 5 #{
monitor: 1,
};
workspace 6 #{
monitor: 1,
};
workspace 7 #{
monitor: 2,
};
workspace 8 #{
monitor: 2,
};
workspace 9 #{
monitor: 2,
};

Yes browser being managed by Nog. I start Nog and have a keybind to open my browser and a custom rule for firefox.

rule "firefox.exe" #{
    has_custom_titlebar: true,
    firefox: true
};

Ah! Got it! Thanks, @keepitsane

disable work_mode;

I think this is the clue, because the code to handle setting up the appbar/taskbar when nog starts first checks to see if work_mode is enabled.
I suspect the code that runs when work_mode gets enabled needs to be modified. I'll see if I have some time for that today. In the mean time, the work around is again to either toggle the taskbar or change the config to enable work_mode. Thanks for providing your config and the log file, that helped a ton!

@keepitsane does the newest build fix this for you?

@TimUntersberger it fixes the bug on my two secondary monitors, but not my primary monitor.

I am not sure if you changed anything in the last dev build you pushed, but the bug seemed to have gone away. Will continue to test before closing.

I think it is safe to close this issue now, I haven't experienced this bug any more.