Fix for bug where mouse coordinates are wrong

This occurs when our main react view is not the contentView of a
window.  Touch coordinates are in window coordinates, but hitTest
expects coordinates in the coordinate system of our superview.
This is my first PR, let me know what I can do to get this in.

When does self.view not have a superview?
Also, please try out #228, which is the future of "touch" handling in react-native-macos.

According to apple's docs, NSViews have a nil superview when they are not in a view hierarchy.  I think the most common case for this is when it's the contentView of the window.  I'm not familiar enough with react to know if react views can never be the contentView - if this is the case, I'm happy to remove the check.
Thanks for the tip on #228!  I'll try out the branch soon and let you know how it goes.

I just checked, #228 first of all still has this problem, and additionally has another problem for clients that don't use RCTWindow - it seems that line 90 on RCTContentView.m on that branch flips the coordinate system - but this is inappropriate when not using RCTWindow.  After un-flipping, that branch showed the same problems as master.  I can see what happens if I use RCTWindow instead, but in my use case I'm a view in a window someone else created, so this approach won't work for me.

Sorry, I don't have the ability to move to RCTWindow as it stands now since my NSWindow is created long before my RCTBridge!

I've just added another, related commit to this branch; I hope that's okay.  More than happy to split these out into separate PRs if that's more convenient for you.
An explanation:  I am trying to use lottie views as interactive controls.  The current logic of checking if something is an RCTView doesn't work for this, because the actual type is LOTAnimationView.  I've replaced this logic with the logic used in the ios version here, I think this makes more sense and is less surprising.  Using this method I think is much more robust.

Anyone had time to give this another look?  I'm still motivated to land this; and am willing to help however I can!


Nag on bugs with obviously wrong priority

If a bug is P1 but had no activity for weeks, we can needinfo to ask to lower the priority.
If a bug is P2 but had no activity for months, we can needinfo to ask to lower the priority.

We've some (unplugged) code to do that:
https://github.com/mozilla/relman-auto-nag/blob/master/auto_nag/scripts/workflow/p1_no_activity.py
https://github.com/mozilla/relman-auto-nag/blob/master/auto_nag/scripts/workflow/p2_no_activity.py
We need to make few modifications in order to have something working and mainly we need to have a signoff before enabling them.

This might be too noisy, also considering that some teams are not using priority at all (maybe we can enable it only for teams that are actually using it, but the information would still be not so useful for people looking at bugs as they can't fully rely on it).
@pascalchevrel you mentioned there might be some regression triage queries depending on priority which could make this useful if we get people to lower priority, could you verify and let us know?


Default double encoding of strings

If a string message is sent via the library, the default JSON stringify converts it to a double quoted string.
For example, Rapport.create(WebSocket).send('hello') will send ""hello"" to the peer.
We need to add a string check to the default stringify function, to prevent doubling up encoding on strings.

Resolved in 0.0.5.


Stop making a working copy in /srv/zulip.git, edge cases in de-mirror'ing

A follow-up to #22046.
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Tested:

With no /srv/zulip.git
With /srv/zulip.git a git clone --mirror, fetch refspec +refs/*:refs/* -- the state prior to #22046.
With /srv/zulip.git a git clone --bare but fetch refspec +refs/heads/*:refs/heads/* -- the state observed on czo
With /srv/zulip.git a working copy, remote refs in refs/remotes/origin/ -- the buggy state for new git clones after #22046.  It leaves the repo non-bare in place but otherwise works.
With /srv/zulip.git a git clone --bare and fetch refspec +refs/heads/*:refs/remotes/origin/* -- the steady-state for pre-existing git clones after #22046.

Merged, thanks for doing all the testing here!


Move falco gitrepo CR to falco namespace

Follow up to #21
Reconciling the kustomization failed because the gitrepo was in the flux-system namespace.
@nikimanoledaki @incertum Should we keep both resources in the falco ns? I'm not sure what the best practice is here.

Looking at the Flux docs for GitRepository, it mentions that Flux can support multiple so that shouldn't be the issue. flux-system should be the right namespace.
I'm wondering if Flux needs to be bootstrapped a second time, this time to be able to watch the falcosecurity/cncf-green-review-testing repository:
flux bootstrap github --owner=$GITHUB_USER --repository=https://github.com/falcosecurity/cncf-green-review-testing --path=./kustomize

Did changing the GitRepository namespace work for you

Yes when I created the GitRepository manually the changes were applied.

I'm wondering if Flux needs to be bootstrapped a second time, this time to be able to watch the falcosecurity/cncf-green-review-testing repository:

That's a good shout. I'll do some more investigating on this.


Document type converters available for parameters

Right now, we support a few different ways things can be converted into a parameter. However, we don't tell this to the user... in any way. So, they don't know what we don't tell them. We would need to add an attribute onto the generated cmdlets that says what input types via type conversion are allowed. Then, the documentation generator can render that into the Parameters section of the markdown document. I don't know if this would get displayed in the Get-Help.

p4


Regex literal parsing fails if character class contains unescaped slash

The following line produces errors as shown:
var r = /[^/]+/;
Errors:
index.js: line 1, col 9, Invalid regular expression.
index.js: line 1, col 13, Missing semicolon.
index.js: line 1, col 13, Expected an identifier and instead saw ']'.
index.js: line 1, col 15, Unclosed regular expression.
index.js: line 1, col 15, Unrecoverable syntax error. (33% scanned).

According to my reading of the ES6 standard, a forward slash should not need escaping inside a character class within a regex literal.
I get these errors with jshint 2.10.0 or later, on default configuration.
No errors are reported when using 2.9.7 or earlier.

A fix is on the way: https://github.com/jshint/jshint/pull/3357
This bug also effects some more edge cases involving ES6's "unicode" RegExp flag. The curious can check out the regression tests in that patch.

Sorry for the delay on this! Version 2.10 has a lot of new features, so if you'd like to use it before we patch the bug, then you can work around this issue by creating RegExps with the RegExp constructor:
-var r = /[^/]+/;
+var r = new RegExp('[^/]+');


Clean up references to FIPS

This makes the fips configure option always error out. This option is broken as the
required FIPS code is not available.
FIPS_mode() and FIPS_mode_set() are retained for compatibility, but
FIPS_mode() always returns 0, and FIPS_mode_set() can only be used to
turn FIPS mode off.

Hmmm, this needs completing.  I noticed references to util/fipsas.pl in crypto/bn/build.info that I don't dare touch.  @dot-asm, could you have a look?


CI: pin Sphinx version to 1.8.5

Sphinx 2.0.0 (just released) breaks the doc build. So fix CI first, investigate later.

will merge this straight away to prevent more CI failures

Thanks for the quick fix

I can try to use 2.0 locally tomorrow. Last I worked on docs I was probably on a 2.0+ dev branch so I'm optimistic that it shouldn't take too much work

thanks, that would be nice!


e.g Could not install on Windows Anaconda [replace with your environment]

Operating system, environment, python version
Linux Ubuntu 20.04, Python3.8.5
What you tried
pip install PyPortfolioOpt
Error
The terminal just freeze and never finish instalation (picture below)

I've solved it installing directly from GitHub repository


Not able to connect to External Hive Metastore which is deployed in mysql

Affected module
Does it impact the UI, backend or Ingestion Framework?
Ingestion Framework
Describe the bug
A clear and concise description of what the bug is.
Trying to connect the external hive metastore deployed in Mysql using delta lake connector. Unable to Connect because of bug in deltalake connector which is confirmed by OpenMetadata Support Team.
Screenshots or steps to reproduce

@mukheshnarra for Hive connector we are not using hivemetastore, why not use hive connector directly to fetch the data? also for hive we need hiverserver 2 connection

Reference: https://openmetadata.slack.com/archives/C02B6955S4S/p1662025121552689
@harshach to give some more context here, we are configuring the Deltalake ingestion setting hive.metastore.uris to the Spark Session to reach the metastore. Looks like @mukheshnarra is able to use instead spark.hadoop.javax.jdo.option.ConnectionURL and directly pass the MySQL instance and not the Hive service


FUSETOOLS2-391 - removed log output for unimplemented function

Signed-off-by: Lars Heinemann<EMAIL_ADDRESS>

sounds better to completely remove the function instead of having empty method

I disagree since there are TODO notes in there and it's a work in progress.

I think this is no longer relevant as the unimplemented function will be a requirement for the release now. Merging the PR anyways.


Add HashMap tests and instances

Add PartialOrd instance for HashMap
N.B. This is a bit unsatisfying since there's no HashMap.isSubsetOfBy so we do something with difference and intersection.
Add BoundedLattice, BoundedMeetSemiLattice and Lattice instances for HashMap
Add HashMap lattice laws test
Fix HashMap JoinSemiLattice and MeetSemiLattice to be lawful instances.  Fixes #50

Fixed indentation.

Thanks!


Interfaces for C++

I would love to integrate LanceDB in a C++ application (and in the future C#). Is there any documentation of how I could bridge from Cpp to Rust?

We dont current have a C++ interface.  Many successful rust projects are being integrated into C++. Need to use these FFI / bindgen project to build a C++ interface.
https://slint.dev/blog/rust-and-cpp

we are starting to chat with some folks to work towards a C++ implementation of the Lance format itself, but that's likely at least many months away. I agree with Lei that your best bet today is to use rust-cpp FFI for now. Would love to know if you're able to get it working.

One of my teams will start implementing C# support for LanceDB using an FFI layer.
Is there some one on the LanceDB team we could discuss the API definition and approach to ensure the pull requests will go in smoothly?

@brooksyott Sorry for the late reply.  That would be awesome.    That's may be the easiest place for real-time conversation / discussion.  Otherwise, if you email us (LanceDB) directly (you can use the support link on our website to get our email) then we'd be happy to meet / have a call and work through your plans.


[FEATURE] Design changes

Redesign it using the following logo and banner.

This will also need the change of the favicon then and maybe a bit of the color scheme.

Implemented with pull request #69 .


HoverPushOut is missing for piechart

How to reproduce?
First of all, thanks for livechart, it has helped me a lot
I've been working on a piechart, to make a circular menu. However, I have tried to set the distance in which the slides are separated from the graph when the mouse is placed over and I could not. Searching the web, i found the command HoverPushOut, but I could not use it, because I can not find it or is not available.
I am using

Live-Charts version
0.95

.Net Version
.NET Framework 4.5.2

Windows
Windows 7 professional

thx, and sorry for my english

Hello
I am sorry It works for me, am I missing something?

<lvc:PieChart LegendLocation="Bottom" HoverPushOut="50">
        <lvc:PieChart.Series>
            <lvc:PieSeries Title="Maria" Values="3" DataLabels="True" PushOut="20"
                           LabelPoint="{Binding PointLabel}"/>
            <lvc:PieSeries Title="Charles" Values="4" DataLabels="True"
                           LabelPoint="{Binding PointLabel}"/>
            <lvc:PieSeries Title="Frida" Values="6" DataLabels="True"
                           LabelPoint="{Binding PointLabel}"/>
            <lvc:PieSeries Title="Frederic" Values="2" DataLabels="True"
                           LabelPoint="{Binding PointLabel}"/>
        </lvc:PieChart.Series>
    </lvc:PieChart>

Hi Beto, sorry, I forgot to mention that it was for winforms not for XML.
However, thanks for defining me that it works for XML, I will program the piechart in XML.
If Hoverpushout works in winforms, let me know
Greetings and thanks

You were right, this property was not accesible in WinForms, the referenced commit exposes the property, this will be included in the next version of the library (0.9.6) thanks for the report!

thanks to you


add new gzip section in compression chapter

Things to check before submitting a PR

[x] the tests are passing locally with cargo test
[x] cookbook renders correctly in mdbook serve -o
[x] commits are squashed into one and rebased to latest master
[ ] PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge

if issue does not exist consider creating it or remove the clause

[ ] spell check runs without errors ./ci/spellchecker.sh
[ ] link check runs without errors link-checker ./book
[ ] non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
[ ] links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
[ ] example has standard error handling
[ ] code identifiers in description are in hyperlinked backticks

[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpack

Things to do after submitting PR

[ ] check if CI is happy with your PR

Thank you for reading, you may now delete this text! Thank you! :smile:

I have to admit no

OK, no problem.  Maybe next week I'll take a look at getting this to the finish line.  Thank you so much for your contribution.


Feature request: screen orientation in default event properties

A great addition to the default event properties would be the screen orientation at the time the event happened. This was a very important state for us to know in some analysis and I guess many more people would benefit from this one if it is available in the SDK from the beginning.
An even more nicer addition would be to let us developers set some sort of event interceptor that we could use to add needed properties for events as they happen. Perhaps an API like MixpanelAPI.getInstance(this, MIXPANEL_API_TOKEN, new EventInterceptor()).

@jfsso I agree that this would be killer, and I'm going to put in a request to get this added. for now you might want to try grabbing orientation with Activity.getResources().getConfiguration().orientation or something similar. you can then manually add this to the event:
JSONObject props = new JSONObject();
try {
props.put("orientation", this.getResources().getConfiguration().orientation);
} catch (JSONException e) {
e.printStackTrace();
}
mMixpanel.track("some event", props);
ORIENTATION_PORTRAIT=1 and ORIENTATION_LANDSCAPE=2 - you can parse these names out if you want more human-readable info. you can also infer the orientation by the default screen height and screen width properties - if width > height you know the device is in landscape mode.
can you explain this EventInterceptor a bit more - I just want to make sure I understand the use case before I bring it to engineering. thanks for all the feedback here!

Thanks @arittr !
Explaining about the "EventInterceptor" a bit more... in an app we're building, there are a few properties we want to add to events to know about the device's current state at the time the event happens. One example in our case is the speed a car is traveling when interacting with our app. This isn't something that can't be done using global properties, but it is just so inefficient to keep updating those properties every time there's a increase/decrease in speed and would be great to only care about querying our speed calculator module to grab the current speed when the event happens.
So a class implementing the EventInterceptor will receive all Events and there it has the opportunity to add more properties to them. I understand that this will make more sense only for edge cases and that the majority of Mixpanel SDK users wouldn't care, but will be great deal for apps like ours that need a few extra properties to analyse user behaviour. :)

oh i see - thanks for the detail @jfsso ! I think the best thing to do here would be to just wrap the .track call with some code that adds in the property before calling .track - it would look like the above code, just synchronized to the mixpanel object and called something a bit different (like TrackWithIntercept). that way you can just call your custom track without the JSON puts to keep the code clean. that being said I'm going to put this into our feedback tracker to see if i can get it added for a later release. thanks for all the info here!

@jfsso this actually sounds like a broadly useful tool- being able to install some sort of computed property sees like it would solve not only your case, but a number of advanced Mixpanel cases. There is a lot to think about to make it work, but I think this feature, or something like it, should probably go into the library!


PriorityClassName for Istio Operator

Describe the feature request
The CLI should allow specifying priorityClassName for the operator. It allows setting for the istio-system K8s objects (via spec.values.global.priorityClassName in the CR) , but there does not seem to be a way to specify this via istioctl for the operator itself.
Describe alternatives you've considered
One can manually dump the deployments, etc. to YAML, and add by hand, but the upgrade path between versions here gets rocky.
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Additional context

We're try to avoid adding two many values for the istio operator itself, only the required parameters are now support to set with operator init. You can consider to dump the istio operator manifests and the apply youe overlay before creating them in the cluster.


RTL Support

Hey!
It seems like this package is incompatible with RTL layouts (scrolling horizontally). Here's a fork of your example with dir="rtl" on the HTML element: https://codesandbox.io/s/scrollbooster-examples-gfu7d
Do you think this is something you can fix?
Thanks1

Yup. I need the same functionality. I'll se if I can contribute.


Test the socket interaction by mocking the socket

This provides almost 100% coverage of __init__.py. I am not sure about the missing lines. Sockets are weird, in particular checking whether a socket is closed / no longer usable.
Also the struct.error is not sensible in my opinion, but this should be discussed elsewhere.
Edit: And with the tests, I found a typo :)

Nice 😎
I was tempted to implement tests for __init__.py but failed on mocking socket.socket, good work @gerw


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   90.14%   90.14%
=======================================
  Files           1        1
  Lines          71       71
=======================================
  Hits           64       64
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32dd61...33017d9. Read the comment docs.


rustbot sometimes pings everyone twice

Occasionally, rustbot pings the same ping group twice in a PR, re-subscribing me even if I already un-subscribed.
See https://github.com/rust-lang/rust/pull/133701 for an example: "The Miri subtree was changed" was printed when the PR was initially created, and then again later after more commits were added to the PR.

Oh, I already reported this last year. 😂
https://github.com/rust-lang/triagebot/issues/1738


add xspectar

Adding xSpectar FTSO

Do you mind updating the image/logo to have less text? The text won't be readable on most websites and wallets.

Do you mind updating the image/logo to have less text (just the graphical element)? The text won't be readable on most websites and wallets.

Hello,
I have updated the logo


Writes indexed access of an index signature are not sufficiently constrained

🔎 Search Terms
"return type" "generic" "type parameter" "indexed access" "index signature" "assignable" "constraint"
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about index signatures

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.2#code/C4TwDgpgBAogHgQwLZgDbQLxQN4CgpQIBcUA5AqflANoDWEIJAzsAE4CWAdgOYC6zbLt1wBfXLgAmEAMaoEraNID2nFlAiIU6EvGRoIuZauBR6IAIwCOPKFnKUNe9HQbnetspyUmKUAPR+UF7qrKxKrOJSsvKKKmpmAEwk9lAAPmQARg6a+i4gCe52Xj6k-oEQoeEANIRM6nCQ0sAQEkA
💻 Code
type Example = {
  a: 'a'
  [key: string]: string
}

declare const example: Example
const key1: string = 'a'
example[key1] = 'not a' // no error

declare const key2: 'a' | 'b'
example[key2] = 'not a' // error, as expected
//^^^^^^^^^^^
// Type '"not a"' is not assignable to type '"a"'.

🙁 Actual behavior
The index signature allows any string value to be assigned, ignoring the narrower type of a.
🙂 Expected behavior
Both property assignments in the above code should raise errors, for the same reason.
Additional information about the issue
This is a more generalized version of #60700. @MartinJohns helped me realize that type parameters need not be involved.
Here's another pair of examples (1, 2) which I expected to be reasoned through similarly:
type WiderType = { a?: string, b?: string }
type Example = { a: 'a' } & WiderType
declare const example: Example
declare const key: keyof Example
example[key] = 'not a'
//^^^^^^^^^^
// Type '"not a"' is not assignable to type '"a"'.

type WiderType = { [key: string]: string }
type Example = { a: 'a' } & WiderType
declare const example: Example
declare const key: keyof Example
example[key] = 'not a' // no error

In both cases Example carries with it the information that the property a must have a value assignable to 'a' (as can be seen with example.a = 'not a'). But this is not enforced when assigning to dynamic property using a key whose type matches the index signature.
Here's another example which does produce the error I expect:
type WiderType = { [key: string | symbol]: string }
type Example = { [key: string]: 'a' } & WiderType

declare const example: Example
declare const key: string | symbol
example[key] = 'not a' // error, as expected
//^^^^^^^^^^
// Type '"not a"' is not assignable to type '"a"'.

Phrased as a feature request:
When checking assignability of x to Type[K], if Type has an index signature over K, today it seems that only the index signature's property type is considered. I propose that additionally TypeScript should check whether x is assignable to all other properties of Type whose keys are subtypes of K, similar to what happens when there is no index signature over K.

It's still the same design limitation.

TS is often unsound in the face of writes. Reminds me of https://github.com/microsoft/TypeScript/issues/9825#issuecomment-234115900. A cure might well be worse than the disease.

A cure might well be worse than the disease.

It wouldn't surprise me, however it's not immediately obvious to me that fixing this particular soundness issue would cause more bad fallout than any other type system change (this bug doesn't seem like something people would intentionally rely on). But what do I know? I guess the only way to be sure is for somebody to implement it and then get @typescript-bot to run the ecosystem tests?

I'm not opposed to looking at a PR for this and assessing the fallout.


Not detecting exhentai links

When opening http://exhentai.org/* links in other apps, EhViewer does not show up as an option on the 'Complete action using' dialog box. However, when opening http://g.e-hentai.org/* links, EhViewer is present in the 'Complete action using' dialog box and works properly.

It has been fixed. f3db305ceed710cb035594d2877e0756fe43d8ee


Upgrade pyowm to 2.4.0

Description:

Upgrade to pyowm 2.4.0
Add default name
Update schema to use extend

Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: openweathermap
    api_key: !secret owm_api
    forecast: 0
    monitored_conditions:
      - weather
      - temperature
      - wind_speed
      - humidity

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

We should note that this is a breaking change in the release notes.
🐬

The initial blog post for 0.28 was pushed to next with that change.


Should we cache access secret request response?

Hi! Please help me to understand what are the best practices of using this library.
I see that AWS Secret Manager goes with explicit client side caching strategy.
https://aws.amazon.com/about-aws/whats-new/2019/05/Secrets-Manager-Client-Side-Caching-Libraries-in-Python-NET-Go/
I've tested GCP Secret Manager making multiple identical access secret requests in a row and the result timing was
1st     ~500ms
2nd   ~100ms
3d     ~100ms
4th    ~100ms
5th    ~100ms
In second test I delayed 4th and 5th by 30 sec and the result timing was
1st     ~500ms
2nd   ~100ms
3d     ~100ms
4th    ~200ms
5th    ~100ms
So, my questions are:

Are there a built-in caching for client.accessSecretVersion({ name: ... })?

If there are no built-in caching, should we implement caching ourself or is it a bad Idea? I do understand that with caching enabled I will have to redeploy instance every time I update the secret value.

Thanks in advance!

We have project level secrets only. We will use caching db instance pattern as you described.
Thanks for your help @bcoe and @sethvargo !

@serhiipalash are you using Cloud SQL? If so. I would recommend against storing username/password in Google Secret Manager. Use native IAM auth instead.

@sethvargo Is there any examples of that actually being used? For example, this line in the nodejs samples is given in the documentation but it is still using username and password from the environment. nodejs example
It also states that the iam login uses the database's username and password as well, see authenticate.
I'm not sure if I'm missing something but what is the purpose of this functionality if you are still required to pass in the credentials? The access is already handled in the firewall rules to allow only connections from my app engine services, so it seems a little redundant - but of course more security isn't really a bad thing I suppose, maybe someone has a setup that needs to use it for that. However in my use case I don't see a way to provide the credentials besides Secret Manager - which is one of the use cases for that product.
For reference I am using Postgres on Cloud SQL, so correct me if its different for the mysql example. I've linked. Im accessing that database with services hosted on standard app engine running nodejs. Any tips would be helpful for me and others I'm sure.


Adding doc generation using typedoc.

This pull request adds a script in misc/package.json in order to generate docs into a misc/docs folder.
Run the following to create a docs folder:
cd misc
yarn
yarn generatedocs

The folder itself is gitignored, in order to generate Github Pages hosted documentation, you want to create a new empty gh-pages branch, move the docs folder into the root of that branch, then update a few configuration files for github pages (specifically a .nojekyll file and adding a _config.yml in the gh-pages branch like https://github.com/Flux159/ECMAScript/commits/gh-pages)
The reason I didn't move this into the Github action to automate is because it requires work from the repository owner to setup push permissions via Github Actions, so this is just a manual way of generating docs for now.

References #65

Is misc/yarn.lock is required?

Is misc/yarn.lock is required?

Technically it should be committed to have more deterministic package installs. I don't think it matters too much in this case, but it's fairly standard to know if deps end up changing.

@Geequlim Thoughts about closing this since it has not been updated in 3 years?
If there's any interest, I think the proposal is still doable.

Closing to to lack of response.


WIP: robust DCE for object pattern

Proof-of-concept fix for #4
As I was working on this I decided to reimplement the DCE algo from scratch and found some improvements / simplifications.

Obsoleted by #12


New Sonos developer API

I recently discovered that Sonos has released a new developer API at developer.sonos.com.
It is aimed at music service companies like Spotify who would like to include Sonos controls in their app.
Some aspects I have found out:

Officially supported by Sonos
Cloud-based communication over HTTP
Requires the developer to register their integration with Sonos
Requires the user to authorize the integration with their Sonos account (over OAuth)
Contains only a subset of the features of the UPnP API - For instance, there's no way to play a music library item (only stream or cloud queue), set an alarm or access the player settings.

On the one hand, the official support is promising, but the required registration and limited feature set are major drawbacks. Still, it might help us resolve issues like #557. Sonos will also probably expand the API in the future (and might even replace the UPnP API with it?).
What do you think? Is it worth it to support this new API in our project?

This is good news. Sonos have been promising a proper API for some while.
Our current UPnP works for most things but can't any longer work for music services.

I'm very supportive of enhancing SoCo to use the Sonos API to access the Music Services.
Willing to help but will be very busy on other stuff for the next 2 months.
Regards Daivd

My preference would be that SoCo doesn't support the new Sonos developer API. I see SoCo and the new API as alternative (and possibly complimentary) ways of interacting with Sonos speakers. There's nothing to stop someone with an app that uses SoCo from also using the new API. But I think SoCo would become unwieldy and complex if it tried to do both. I hope SoCo continues to focus on what it does (i.e. it's a library for a LAN based Sonos controller) and do it well.
I also don't see this new developer API replacing SoCo any time soon. For me, the requirement for cloud-based communication over HTTPS is a deal breaker. If my Internet connection goes down, I can play music from my local collection and control my Sonos system on the LAN using SoCo (or the Sonos app on my phone). Also, registration and authentication are a pain (and obviously a necessary consequence of the developer API being cloud-based), although I have those problems already with the Spotify API.
As to Music Service Authentication, I abandoned Sonos for searching and use the music service provider's API, being Spotify's in my case. The Spotify API is quicker, easier to use and has more features.
Spotify Connect (now part of the Spotify API) can also be used to control Sonos speakers, but is too limited to replace SoCo as a controller. However, if one wants to add new items to a Spotify queue being played over Sonos via Spotify Connect (and lots of people now use Spotify Connect in this way), then one has to use the Spotify Connect API, because the queue exists only on a Spotify device, and not on the Sonos device. So, developers of Sonos controllers may find they want to use more than one API.

I agree with @relevitt that trying to do both would risk making the library more complex, with limited benefit. In my opinion the project should keep its focus on the UPnP-based API, and do that well. A client library for the Cloud API could (should) be a separate project.


Issue #1452: remove reachedEndOfTopic in addConsumer

Motivation
Fixes #1452
In issue #1452 , reachedEndOfTopic was called twice if a topic has been terminated before subscription.
It may be better to call reachedEndOfTopic, when real read/ack happened to the subscription, so delete the calling in addConsumer to avoid dup calling.
Modifications
remove dup calling in addConsumer .
add related ut.
Result
Expected all ut passed.

merge
0cc5e81 in branch-2.1


CRF layer conversion failed

Hi team,
i was trying to convert (BILSTM + CRF) network from keras  to onnnx . i am getting following error
with keras2onnx (1.6.5) and keras (2.3.1) and tensorflow(2.0)
.........................................................................................
tf executing eager_mode: True
The tf.op node crf_1/cond of type StatelessIf cannot be converted
There is an error(<class 'AssertionError'>) happened during optimizing on the converted model!
Traceback (most recent call last):
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\keras2onnx\topology.py", line 315, in convert_topology
target_opset=container.target_opset)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\onnxconverter_common\optimizer.py", line 1614, in optimize_onnx_graph
initializers)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\onnxconverter_common\optimizer.py", line 303, in build_from_onnx
assert var_ == '' or var_ in inputs
AssertionError
....................................................................................................................
Code:
import keras2onnx
import onnx
from keras.models import Model, Input
from keras.layers import LSTM, Embedding, Dense, TimeDistributed, Dropout, Bidirectional, Lambda
from keras_contrib.layers.crf import CRF
onnxfilepath= "E:/xyz/xyz.onnx"
maxlen = 100;
n_tags = 100
n_words=100
input = Input(shape=(maxlen,),name="input_1")
model = Embedding(input_dim=n_words + 1, output_dim=250,
input_length=maxlen)(input)
model = Bidirectional(LSTM(units=150, return_sequences=True,
recurrent_dropout=0.1))(model)  # variational biLSTM
model = TimeDistributed(Dense(150, activation="relu"))(model)  # a dense layer as suggested by neuralNer
crf = CRF(n_tags)  # CRF layer
out = crf(model)  # output
model = Model(input, out)
model.compile(optimizer="rmsprop", loss=crf.loss_function, metrics=[crf.accuracy])
model.summary()
onnx_model = keras2onnx.convert_keras(model,target_opset=9);
onnx.save_model(onnx_model,onnxfilepath)

From the log, we see that The tf.op node crf_1/cond of type StatelessIf cannot be converted, this means that keras2onnx cannot support this op in CRF (possibly because you have loop inside CRF?). The solution is that you get the tensorflow frozen graph from the keras model, and then use tf2onnx to convert it.

hi @jiafatom hi @jiafatom , i tried your solution of getting the tensorflow frozen graph and then using tf2onnx to convert it. I am getting following error:
..........................................................................................................................................
2020-03-30 00:41:37.689103: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_100.dll'; dlerror: cudart64_100.dll not found
2020-03-30 00:41:37.701017: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
WARNING:tensorflow:From C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\verbose_logging.py:72: The name tf.logging.set_verbosity is deprecated. Please use tf.compat.v1.logging.set_ve
rbosity instead.
2020-03-30 00:41:41,006 - WARNING - From C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\verbose_logging.py:72: The name tf.logging.set_verbosity is deprecated. Please use tf.compat.
v1.logging.set_verbosity instead.
2020-03-30 00:41:41.009392: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library nvcuda.dll
2020-03-30 00:41:41.756002: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1618] Found device 0 with properties:
name: GeForce GTX 1050 major: 6 minor: 1 memoryClockRate(GHz): 1.493
pciBusID: 0000:02:00.0
2020-03-30 00:41:41.767085: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_100.dll'; dlerror: cudart64_100.dll not found
2020-03-30 00:41:41.773644: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cublas64_100.dll'; dlerror: cublas64_100.dll not found
2020-03-30 00:41:41.782547: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cufft64_100.dll'; dlerror: cufft64_100.dll not found
2020-03-30 00:41:41.801789: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'curand64_100.dll'; dlerror: curand64_100.dll not found
2020-03-30 00:41:41.811840: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cusolver64_100.dll'; dlerror: cusolver64_100.dll not found
2020-03-30 00:41:41.830418: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cusparse64_100.dll'; dlerror: cusparse64_100.dll not found
2020-03-30 00:41:41.841328: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudnn64_7.dll'; dlerror: cudnn64_7.dll not found
2020-03-30 00:41:41.855089: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1641] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you woul
d like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2020-03-30 00:41:41.890716: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2
2020-03-30 00:41:41.909786: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1159] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-03-30 00:41:41.919578: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1165]
2020-03-30 00:41:42,547 - WARNING - inputs [input_1:0] is not in frozen graph, delete them
2020-03-30 00:41:42.886264: I tensorflow/tools/graph_transforms/transform_graph.cc:317] Applying fold_batch_norms
2020-03-30 00:41:42.906852: I tensorflow/tools/graph_transforms/transform_graph.cc:317] Applying fold_old_batch_norms
2020-03-30 00:41:43.283588: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1159] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-03-30 00:41:43.292791: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1165]
2020-03-30 00:41:43,296 - INFO - Using tensorflow=1.15.0, onnx=1.6.0, tf2onnx=1.5.5/3c8f90
2020-03-30 00:41:43,296 - INFO - Using opset <onnx, 8>
2020-03-30 00:41:43,881 - ERROR - Tensorflow op [bidirectional_1/ReverseV2: ReverseV2] is not supported
2020-03-30 00:41:43,893 - ERROR - Tensorflow op [bidirectional_1/ReverseV2_1: ReverseV2] is not supported
2020-03-30 00:41:44,016 - ERROR - Tensorflow op [crf_1/ReverseV2: ReverseV2] is not supported
2020-03-30 00:41:44,067 - ERROR - Tensorflow op [crf_1/ReverseV2_1: ReverseV2] is not supported
2020-03-30 00:41:44,067 - ERROR - Failed to convert node crf_1/one_hot
OP=OneHot
Name=crf_1/one_hot
Inputs:
crf_1/Squeeze:0=Squeeze, [-1, 100], 6
crf_1/one_hot/depth:0=Const, [], 6
crf_1/one_hot/on_value:0=Const, [], 1
crf_1/one_hot/off_value:0=Const, [], 1
Outpus:
crf_1/one_hot:0=[-1, 100, 100], 1
Traceback (most recent call last):
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\tfonnx.py", line 356, in tensorflow_onnx_mapping
func(g, node, **kwargs)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\onnx_opset\tensor.py", line 1053, in version_1
raise ValueError("onehot op: only rank1 is supported")
ValueError: onehot op: only rank1 is supported
2020-03-30 00:41:44,070 - ERROR - Unsupported ops: Counter({'ReverseV2': 4})
Traceback (most recent call last):
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\convert.py", line 161, in
main()
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\convert.py", line 145, in main
inputs_as_nchw=args.inputs_as_nchw)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\tfonnx.py", line 579, in process_tf_graph
raise exceptions[0]
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\tfonnx.py", line 356, in tensorflow_onnx_mapping
func(g, node, **kwargs)
File "C:\Users\rahul\Anaconda3\envs\Review Conflation\lib\site-packages\tf2onnx\onnx_opset\tensor.py", line 1053, in version_1
raise ValueError("onehot op: only rank1 is supported")
ValueError: onehot op: only rank1 is supported
......................................................................................................................................................................................................
Code(to convert (BILSTM + CRF) model to tf frozen model):
import os
import keras;
from keras import backend as K
import tensorflow.compat.v1 as tf
from keras.models import Model
from keras.layers import LSTM,Input, Embedding, Dense, TimeDistributed, Dropout, Bidirectional, Lambda
#from keras_contrib.layers.crf import CRF
from tensorflow.python.tools import freeze_graph
from keras_contrib.layers.crf import CRF, crf_loss, crf_viterbi_accuracy
#K.set_learning_phase(0);
print(keras.name)
def create_model():
maxlen = 100;
n_tags = 100
n_words = 100
input = Input(shape=(maxlen,), name="input")
model = Embedding(input_dim=n_words + 1, output_dim=250,
input_length=maxlen)(input)
model = Bidirectional(LSTM(units=150, return_sequences=True,
recurrent_dropout=0.1))(model)  # variational biLSTM
model = TimeDistributed(Dense(150, activation="relu"))(model)  # a dense layer as suggested by neuralNer
crf = CRF(n_tags)  # CRF layer
out = crf(model)  # output
model = Model(input, out)
model.compile(optimizer="rmsprop", loss=crf.loss_function, metrics=[crf.accuracy])
# model.compile('adam', 'binary_crossentropy', metrics=['accuracy'])
model.summary()
return model
model = create_model()
save_dir = "C:\Users\rahul\PycharmProjects\Review Conflation\model"
tf.saved_model.simple_save(K.get_session(),
save_dir,
inputs={"input": model.inputs[0]},
outputs={"output": model.outputs[0]}
)
freeze_graph.freeze_graph(None,
None,
None,
None,
model.outputs[0].op.name,
None,
None,
os.path.join(save_dir, "frozen_model.pb"),
False,
"",
input_saved_model_dir=save_dir
...................................................................................................................................................................................................
Then i use
python -m tf2onnx.convert --input frozen_model.pb --output model.onnx --outputs crf_1/cond/Merge:0 --inputs input_1:0
to convert into onnx model.
Can you please look into it ?

In this case, the suggestion is to provide the frozen tensorflow graph and post the issue in tf2onnx.

thanks @jiafatom  , i will post it in tf2onnx

@jiafatom , if CRF layer looks a little common, we should a converter for this layer as well, like a demo code in the application folder.


Fix attempt for next branch

Using vite instead of rollup
Wasn't able to get cypress to run (yet)

It seems that cypress doesn't run on master as well.

Awesome!
Thanks @marcus-herrmann
@shwilliam Would you like to finish the tests?


Sitemap mysql undefined domain

Hi!
Thanks for implementing the sitemap for mysql.
I have a problem below in the screenshot.

Wikijs in a container according to the examples. Tried to proxy through nginx and haproxy.
Could you suggest what is the problem.
Why is the domain not visible (undefined)?
Maybe I forgot to specify it somewhere?

Is the “Site URL” set in your Wikijs dashboard? That is what it uses.

Yes.

But I planned to use several languages ua and ru.
Now only ru and default url https://wiki.mydomain.pp.ua/ru/home but even with this language, the problem does not go away.

I also tried to change the domain in the control panel to https://wiki.mydomain.pp.ua/ru/home this also didn't work(((

If I disabled multilanguages in control panel it doesn't help either.

I will have a look on the code.

I tried it on MYSQL 8 and couldn't reproduce the bug.
Can you let me know your MYSQL version? Are you running it on docker?

Yes I am running in docker.
I am using mariadb version 10.5.19

I will try it on MariaDB and give feedback.

Change your DB_TYPE to DB_TYPE=mariadb.

Thanks it's worked


Bluetooth: When receiving "PAST received" event, recv_enabled can be set based on option provided when PAST is enabled

When application calls bt_le_per_adv_sync_transfer_subscribe() it can provide an option BT_LE_PER_ADV_SYNC_TRANSFER_OPT_REPORTING_INITIALLY_DISABLED to prevent generating of sync reports.
However, when processing "PAST received" event in bt_hci_le_past_received_common() function, this option doesn't take an effect: sync_info.recv_enabled field is not set according to option provided earlier in bt_le_per_adv_sync_transfer_subscribe, it is only set to true by default.
More detailed description from the comment in related PR:
Whether this value should be true or false, depends on whether the BT_LE_PER_ADV_SYNC_TRANSFER_OPT_REPORTING_INITIALLY_DISABLED bit was set in the options when bt_le_per_adv_sync_transfer_subscribe was called.

We don't have any way of storing that information currently, so this may be a bit tricky to implement.

Effectively we should do the same as

	sync_info.recv_enabled =
		!atomic_test_bit(pending_per_adv_sync->flags,
				 BT_PER_ADV_SYNC_RECV_DISABLED);
but where the issue here is that we don't have pending_per_adv_sync->flags.

To fix this issue, we need to store the mode from bt_le_per_adv_sync_transfer_subscribe in a way that we can retrieve it again here.

@ivaniushkov do I understand correctly that #69908 was just a partial fix for this? Are you planning to work on a follow-up PR to fix the remaining issue(s)?

@ivaniushkov do I understand correctly that #69908 was just a partial fix for this? Are you planning to work on a follow-up PR to fix the remaining issue(s)?

No, my intention was only to fix a bug reported by UBSAN - #69908 fixed an issue when bt_hci_le_past_received_common() returned uninitialized value in sync_info.recv_enabled which is unsafe.
I am not planning to fix #69927 unfortunately but I will be happy if someone else can do that


Fix Reviews Modal Issues

Summary

Hey, thanks for the great Browser extension! I noticed that the GIF toolbar button wraps to a new line in the Github "Reviews" modal. When the GIF button is clicked the Giphy popover shows cropped in the modal, see GIF above for reference.
Sadly this makes it difficult to add GIFs when reviewing a Pull Request. I'm not sure if this affects all GitHub users or relates to a beta UI change.
Why this happens?
Runtime GitHub JS adds an element style of width: 640px to the reviews modal, which causes the toolbar to wrap as there is not enough space, this also affects the Giphy popover causing it to overflow outside of the modal.

The Fix
I've opted for a simpler fix which identifies when the toolbar is a child of the Review Changes Modal and adds the class ghg-in-reviews-modal.
This CSS class overrides the width of the reviews modal to accommodate the GIF toolbar and popover:

Also seeing this effect on my side. Version 85.0.4183.121. +1 for the fix!


Display delay in status bar after switching to Normal mode

It needs approximately 1s for status bar changing from blue to yellow after pressing <escape> button. If press any key immediately after quitting Insert mode, the status bar will change to yellow at no time.
I fail to configuring out why this happens. I would be appreciated if someone could provide some advice.

Might be related to vim's timeout as it waits for possible character mappings to be typed. Try :help ttimeout and see if adjusting it makes a difference.

Setting ttimeout on or off doesn't change anything, or literally, 1 second display delay still exist. I reckon it may abuse to plugin showing colourful state bar.

https://github.com/vim-airline/vim-airline/issues/124 suggests that this happens when we have keybindings which start with <esc>, but I don't think that applies.
https://github.com/vim-airline/vim-airline/issues/1199 says that using neovim will fix the problem, and haskell-vim-now does support neovim as well.

Yes, Haskell-vim-now doesn't have key binding with . I think it may due to the mechanism of vim interacting with the terminal emulator.
Gvim works well for me now. Thank you.

OK, I'll close this issue.
Wish we knew how to fix it for the terminal vim but at least the delay disappears if you type anything rather than preventing you from typing.


Add Cookie Store API

https://wicg.github.io/cookie-store/

This feature will be shipped with Chrome 87.

Data was recently added (#5626) so should be on site soon once reviewed.

Re-opening until data has been reviewed and is available on the site.

Finally stumbled on this api after seeing nothing but the cookie api for extension, surprised it took so long for us to get this API, the amount of npm librairies to handle cookie is pretty crazy 😄
Hopefully the moment it gets reviewed, this API will get gain more exposure 😀

Available by now: https://caniuse.com/cookie-store-api
I believe this issue can be closed :)


Trouble with path url when deploy to server develop

I have a trouble with path url
In local:

everythings okay.
Ex:
In Backend: enter to menu Builder Plugin with path url http://localhost/vgaming-octobercms/backend/rainlab/builder => Ok

==================================
In server develop:

When I enter to menu Builder (Builder Plugin - http://my-domain/backend/rainlab/builder) in navigation bar, October CMS return 404 not found page. I don't know what wrong is here
Most of the functions are working properly, but there are some areas where the path url has problems.

======================================
Sorry for my english

@khoanndang Are you sure your app.url configuration value is set correctly on the server? You could also try running php artisan cache:clear on the server if you have copied any cache files to the server.

@khoanndang Bạn có chắc chắn app.urlgiá trị cấu hình của mình được đặt chính xác trên máy chủ không? Bạn cũng có thể thử chạy php artisan cache:cleartrên máy chủ nếu bạn đã sao chép bất kỳ tệp bộ đệm nào vào máy chủ.

Ya, I checked again variable url in config/app.php . Everythings ok. I have also run the command php artisan cache:clear php artisan cache:config . And nothing changes :(

I cannot imagine where the problem is arising from, because in local server everything is very smooth
Additional:

In local: Window 10, xampp, php version 7.4
In develop server: Linux Ubuntu 18.04, nginx, php version 7.3

Is there a solution to handle this situation without having to re-deploy the code from scratch

In local server (window 10):
Enter to menu Builder (Builder Plugin)

Enter to view detail News

==================================

In develop server (linux Ubuntu 18.04)

Bug in backend - enter to menu Builder (Builder Plugin)

Bug in frontend - enter to view detail News => url change, but layout the same, not directly

Define page for list News and Pagination

Define page for view detail News with slug

==============================================
Hope everyone has enough information to understand my problem. Thanks all

Hope everyone has enough information to understand the problem I'm having. Tks all

@khoanndang enable app.debug to see what the problem is. Looks to me like you're encountering a server error (500), but your theme does not have a 500 error page configured so instead it's showing the 404 error page instead.

@khoanndang bật app.debug để xem vấn đề là gì. Có vẻ như tôi đang gặp phải lỗi máy chủ (500), nhưng chủ đề của bạn không có trang lỗi 500 được định cấu hình nên thay vào đó nó hiển thị trang lỗi 404.

I've do it, Can u show me where can I see the problem.

@khoanndang go to the URL that you were having problems with

@khoanndang go to the URL that you were having problems with

I still get this error  :(

Do any of the other plugins work or is it just the builder plugin?

The plugins built from the Builder Plugin still work fine. Only the Builder Plugin has problems.
Currently I can only use the builder plugin on the local server

@khoanndang what are all the other plugins you have installed? And what is the APP_ENV set to on your linux server?


Fix German translation

This PR fixes the German translation and fixes a typo on the way.

Thank you.


Improved quality of old Images and added four new cards released in the March update.

Awesome job! Thanks!


[AutoPR postgresql/resource-manager] Add support for PG 10

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3355

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/2181


IE11 and Edge doesn't display a grid

Getting this error in edge:
SCRIPT5022: SyntaxError
FilterTree.js (116,1)

@bahrus Hey! Sorry for the delay in getting back to you. We were away on holiday.
Thanks for pointing this out. We will address this soon and have full support for the evergreen browsers

To further elaborate. The filtering module will get externalized from HyperGrid Core and be used as add-on as described here
Its one our major goals for this summer

I also saw an issue on IE; namely that this line (16962) in the typeOf function fails as the name property is undefined.
return something.constructor.name.toLowerCase();
This jsfiddle shows the issue.

@allanelder Ah ok. Thanks will note that as well

PR is being reviewed https://github.com/openfin/fin-hypergrid/issues/227

PR's for fixing the bootstrapping on IE are merged. Note however that their are still some lingering IE bugs to be fixed.


New data types

Codecov Report

Merging #2419 into dev will decrease coverage by 2.87%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2419      +/-   ##
==========================================
- Coverage   96.75%   93.88%   -2.88%
==========================================
  Files          65      161      +96
  Lines       12808    19172    +6364
==========================================
+ Hits        12393    18000    +5607
- Misses        415     1172     +757

Impacted Files
Coverage Δ

qiita_db/test/test_util.py
99.64% <ø> (ø)
:arrow_up:

...lers/artifact_handlers/tests/test_base_handlers.py
95.29% <ø> (ø)

...pet/handlers/api_proxy/tests/test_prep_template.py
98.76% <ø> (ø)

qiita_db/artifact.py
98.28% <100%> (ø)
:arrow_up:

...lers/analysis_handlers/tests/test_base_handlers.py
99.23% <100%> (ø)

qiita_db/test/test_artifact.py
99.85% <100%> (ø)
:arrow_up:

...ta_pet/handlers/artifact_handlers/base_handlers.py
93.75% <100%> (ø)

qiita_pet/handlers/analysis_handlers/__init__.py
100% <0%> (ø)

qiita_pet/handlers/base_handlers.py
76.92% <0%> (ø)

qiita_pet/test/test_util.py
97.67% <0%> (ø)

... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5d77d...3df26de. Read the comment docs.


Change "invite" to "invitation" (text only, not filenames)

Fix a grammar bug before anyone else falls victim to it.

@gschier, anything I can do to make this more merge-worthy or easier for you to review? Happy to do my part to save you time, or try to :)

ping :) This should be safe to merge as-is.

@troy thanks for poking us. Our grammar be no good.

:+1:


could not find sql_types in schema on every DBEnum

Every time DBEnum is used, an error "could not find sql_types in schema" appears.
My config:

diesel = { version = "2.0.0", features = ["postgres", "r2d2", "chrono", "uuid", "serde_json"] } with Diesel-CLI 2.0.0
diesel-derive-enum = { version = "2.0.0-rc.0", features = ["postgres"] }

Try deleting and recrating your schema, the print-schema macro should pick up the enum types in your database


Withdrawal reversion: make sure all the committee group exists before sending email notification

This is fixed in the NeurIPS 2023 venue.

Celeste, could you work on this issue?
We should check the existence of the group before sending the email in the Withdrawn_Submission and Withdrawal_Revision process functions.
https://api2.openreview.net/logs/process?id=oe9Z67KZZM


Expected budget timeframe

Issue #275
Important:
I merged pr #287 because I needed a function implemented in that branch, I recommend reviewing that first
Description:
This pr contains the necessary changes for adding an expected_budget_timeframe into each project, an all the process that involves the project, as creating editing, and DB storage.
Breakdown:

I created a migration named addExpectedBudgetTimeframeToProjects to add the attribute expected_budget_timeframe into the DB. To make this I had to create a new config file and a .sequelizerc file for config the migrations
I added the necessary changes in the ProjectType and ProjectResolver to be able to fetch and mutate this new attribute
I added a selector to choose between different options as a timeframe when creating/ editing a project. These are daily , weekly, monthly, yearly
The timeframe is showed in the ProjectInfo component next to the budget amount

Testing:
I tested the following scenarios

[x] Create a project adding a timeframe and store info correctly into the DB
[x] Edit a project and change the timeframe and update info correctly into the DB
[x] Leave the timeframe empty when creating/editing a project, and not being able to process with the DB transaction

Proof of implementation:
https://www.loom.com/share/688a0cc23bc1422f8b65f55da148a5c8

@otech47 changes requested reviewed, ready for merge


Intellisense package for Xamarin

Intellisense for Xamarin doesn't come with the Visual Studio package.
This can cause a bit of discomfort and end up awkward for newer developers like myself heading into a newer area of development, so I would suggest you put a notice somewhere about the Nuget package you can download for the project.
Lucky for me  had read several forums where people had this problem so I got intellisense installed in my project right as I started.
Thank You and have a good day :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2de3e72c-8948-4dd5-e37f-9cf81e62c127
Version Independent ID: 7b7c5c7f-4102-8e91-fbe6-7d21fcc8f5be
Content: Xamarin.Forms Quickstart - Xamarin
Content Source: docs/xamarin-forms/get-started/hello-xamarin-forms/quickstart.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @JKleinsasser
You don't need to install an additional package to get intellisense for Xamarin.Forms. It ships as part of Xamarin.Forms.

It doesn't come with just the visual studio package though... I installed Visual studio and added the Xamarin packages. You probably have to download directly from Xamarin to get the intellisense which is probably why it's confusing

Xamarin.Forms ships as a NuGet package, available from the NuGet gallery. That NuGet package includes the intellisense data.

Hi @JNickVA1
I just tried VS2017 15.8.1 and Xamarin.Forms <IP_ADDRESS>7729 and received intellisense in the XAML editor.


Update configuration to always download HTML/JS Bitstreams (no inline display)

Description
This PR updates our default settings for webui.content_disposition_format to include HTML and JavaScript by default.  This ensures that bitstreams of these formats are always downloaded and never loaded inline by a user's browser.  Loading these formats inline may cause the browser to open them & attempt to execute any JavaScript contained within them.
This also adds JavaScript to the list of default formats in the Bitstream Format Registry to ensure it is a recognized format (by default).
Instructions for Reviewers

Deploy this PR
Upload one or more HTML or JS bitstreams to a new or existing Item
Attempt to download those bitstreams.  Ensure do not open in your browser window.  Instead, they should download directly to your machine.

Related work
For more on webui.content_disposition_format see #8891

@mwoodiupui : Thanks for the note!  It appears we have an IT which is still hardcoding a specific count of BitstreamFormats (sigh).  Since this PR added a single new BitstreamFormat those counts all failed.  So, it's really a flawed test & not a sign of an issue in this PR.
Nonetheless, I'll get the test fixed (hopefully later today) so that it succeeds.  (If I can figure out a way to easily remove the hardcoded numbers, I'll do so...but not sure how much effort that'd be)

@mwoodiupui : I fixed the failing tests by ensure the BitstreamFormatRestRepositoryIT no longer hardcodes the number of BitstreamFormats.  The updated code now loads that count from the BitstreamFormatService before tests run, ensuring it will update dynamically for the future.

Perhaps, separate from this issue, we should have a discussion about why the test should depend on a magic number that has to be changed when unrelated improvements are made.

XML files (text/xml) also allow XSS.

I've updated this PR today to include the following:

Added XML (text/xml) to the list of formats to always download
Added automated tests to BitstreamRestControllerIT to verify that HTML, JS & XML are all downloaded by default.  (This is to simply protect us and other sites from removing these configs in the future)

I hate to drag this out further, but if we list text/xml then we probably also need application/xml.  https://stackoverflow.com/q/4832357/2916377

@abollini and @mwoodiupui :  I've made some changes to this PR today which I hope are improvements, so I'd appreciate a re-review.  See the updated PR description for all the details...but here are the highlights:

I've hardcoded some file formats into Java code to avoid misconfiguration.  While I don't tend to like hardcoded settings, I think it may be best to do so in this situation.  For example, I cannot think of a use case where these settings should NOT be in place.
I've added a new wildcard (asterisk: *) option to disable inline opening for all files.
I've added more automated tests to verify everything is working as it should.

@mwoodiupui : We don't need to include application/xml in this PR as that's not a format in our DSpace Format Registry: https://github.com/DSpace/DSpace/blob/main/dspace/config/registries/bitstream-formats.xml
Any file format that is NOT in that registry will be returned as application/octet-stream.  Browsers seem to always download application/octet-stream.  But, I've also added some automated tests & minor code cleanup in my last commit to force anything that comes back as application/octet-stream to use content-disposition: attachment

Final note for today:  Because everything that comes back as application/octet-stream now uses content-disposition: attachment, we could now remove text/javascript from the registry (i.e. revert those changes from this PR).  I don't believe it is needed anymore.  But, I'll wait to do anything like that until I have further feedback on the directions of this PR.
(We could also wait until this week's Developer's Meeting to discuss all this in greater detail together.)


TCRE needs fitting (calibration)

This one is up for debate, because I think it is the weakest and most speculative of the AR6 climate assessments (other than projected SSP warming - which I only sense check).
With everything else calibrated and distribution-fitted (ECS, TCR, observed warming, observed OHC, aerosol forcing), the TCRE has not been. In AR6 we used the Chapter 5 assessment and calculated TCRE from TCR and airborne fraction. This is annoying for calibration as we need to do separate 1% runs on top of the 1.5 million member emissions-driven ensemble.
It's come to light when I use the FaIR (non-TCRE calibrated) calibration in other work. FaIR 1.6-AR6 had a median ZEC50 of -0.05 K in the 750 and 1000 Tg bell experiments (compare MAGICC -0.09 K, CMIP6 ESMs -0.078 K). FaIR 2.1-AR6 has a median ZEC50 of zero - so we're bang on chapter 5, but further from chapter 4 😆

TCRE as assessed by AR6 is a poor constraint, so while it has been included as a diagnostic, we don't constrain to it (present day CO2 does this). Addressed in #84.


TSS-2213 - TRS DBT Migration - Upgrade backing services

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.14%. Comparing base (95b1f1c) to head (15f756e).

Additional details and impacted files
@@               Coverage Diff               @@
##           paas-migration     #485   +/-   ##
===============================================
  Coverage           56.14%   56.14%
===============================================
  Files                 215      215
  Lines               12647    12647
  Branches             1481     1481
===============================================
  Hits                 7101     7101
  Misses               5546     5546

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support StringDecoder encoding

I need to parse a latin1 stream, but there is no option to set decoder: new StringDecoder('latin1') .
I think this is a missing feature.

Closing due to lack of activity.


Pattern porting

@bplaxco looks good to me. What caused the tags to change order?

I had changed the order just to have them read better to me.
This is kinda how I'm reading them when I skim the tag order:
<type> [should <action>] [for <groups>]
On Thu, Aug 8, 2024, 5:06 PM thewizzy @.***> wrote:

@bplaxco https://github.com/bplaxco looks good to me. What caused the
tags to change order?
—
Reply to this email directly, view it on GitHub
https://github.com/leaktk/patterns/pull/38#issuecomment-2276651168, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK7YCRKPWRISR4OGXTVDFLZQPMUVAVCNFSM6AAAAABMHBE2WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGY2TCMJWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Punctuation warnings are too strict for Spanish

I really like the whitespace and punctuation consistency checks.
However, in Spanish questions and exclamations also get an inverse punctuation mark at the beginning.
Source: https://en.wikipedia.org/wiki/Inverted_question_and_exclamation_marks
Example:

Are you sure you want to restore the factory database?
¿Está seguro que desea restaurar la base de datos de fábrica?

This leads to the warning: The punctuation at the start of the messages doesn't match up. No punctuation was expected at the start of the message.
I wouldn't go as far as to say that the inverted has to be there at the start (as there are sentences that have the inverted punctuation halfway in the sentence), but a way to switch of the leading punctuation check for these symbols would be nice.

Duplicate of #283


Update installation docs to match readme

Added tailwind config for finding stwui content so that the readme guidance matches what we see in the web doc site. Low priority for sure because you are going to rework the docs.

I just pushed the update for this along with a few other items I had been working on so I am going to close this one. Changes should already be live. Thanks!


Fix negative caching for Hive metadata

Fixes #1540

looks good

@electrum I still found a problem. If you create a table in hive, first show tables can't get the table, and you must show tables twice. Maybe this problem is also caused by cache.
Description:
1: Create a table in hive, maybe named test;
2. Show tables in Presto,  the test table is not appeared
3. Show tables in Presto again, then the test table appeared
This table also exists in drop table.

@alexingcool, that is expected behavior.  If you need that level of consistency, you will need to disable the cache in Presto.  We run with the cache at FB because our metastore is not reliable (or performant) enough for interactive users.

@dain electrum use 'Optional' to label whether the item cached is empty or not, so one second refresh interval already let the cache know what happened in metastore. Is this behavior caused by CacheBuilder? return an old value immediately and the get a refresh.
Once, I was curios about this cache mechanism. Now I know why you do this. I don't know whether disable cache will affect online tasks, but I can show tabls or partitions before select to get a refresh.


Undefined index: generic_warning

File: E:/apache/php/localhost/www/elki/t1/sources/Load.php
Line: 1977

It is a new install?

The generic_warning is from $txt['generic_warning'] that should be in index.english.php
Do you have it there?

this error appeared after I moved the folder with the forum files.
...\themes\default\languages\english\index.english.php:
$txt['generic_warning'] = 'Warning';

As this is 5 years old ... I'm going to say not an issue 😇


Fine-tune time is faster than BERT

I fine-tuned the XLNet model on the same data set I did with BERT and it looks like XLNet is completely faster than BERTs (like 10-15 times). Is this a case?

Can you link me with the code u used to fine tune XLNET ?


_posts/0000-01-02-iFrank21.md

,created a branch,created a file, made my first commit, created a pull request,

fixed file name

fixed file name


DEPS is not deleted on test dir if deleted on source dir

DEPS is not deleted on test dir if deleted on source dir.

It's likely the same for the DELETED file.


Custom next config is ignored

When I use next-compose-plugins, my custom next config is ignored and I can't get environment variables. When I don't use it, there's no problem.
Am I doing something wrong or is this a bug?
const withPlugins = require('next-compose-plugins')
const withTM = require('next-transpile-modules')
const withCss = require('@zeit/next-css')
const webpack = require('webpack')
module.exports = withPlugins(
  [
    withTM({
      transpileModules: [
        '@my/custompackage'
      ]
    }),
    withCss
  ],
  // Ignored
  {
    webpack: config => {
      const env = {} // some env variables
      config.plugins.push(new webpack.DefinePlugin(env))
      return config
    }
  }
)

Same here, webpack doesn't run

Is your app crashing when running the server in dev/prod mode?
I noticed that I had a custom server that had require('./next.config.js') in it. next.config.js doesn't export an object anymore after using next-compose-plugins. It uses phases so it exports a function.
In my case, webpack wasn't running because it was crashing trying to access variables from the exported function, expecting it to be an object. If you still need the next config object, you can see my comment in another post.
const isDev = process.env.NODE_ENV !== 'production';
const { PHASE_DEVELOPMENT_SERVER, PHASE_PRODUCTION_SERVER } = require('next/constants');
const nextConfigModule = require('../next.config');

let nextConfig;
if (typeof nextConfigModule === 'function') {
  nextConfig = nextConfigModule(isDev ? PHASE_DEVELOPMENT_SERVER : PHASE_PRODUCTION_SERVER, {});
} else {
  nextConfig = nextConfigModule;
}

Note that you have to determine isDev to get the correct next config. isDev is probably part of your environment configuration. So if you only need the environment configuration object, you probably would have already gotten it elsewhere and don't need to get the next config.

@mehmetnyarar the code you have posted should work as you expect it to work. If the solution which @dosentmatter posted does not work, can you share a minimal reproduction example so I can take a look?

@cyrilwanner, My code that I posted isn't meant for next.config.js. I just mentioned that I had a somewhat related problem where my build was crashing because I was trying to access environment variables (env, serverRuntimeConfig, publicRuntimeConfig) inside a custom nextjs server.js.
I just wanted to bring to attention that if you are doing require('./next.config.js'), remember that next-compose-plugins exports a phase function and not a JS object, so you can't just use it directly. The code snipped I posted is a method of calling the exported phase function to grab the returned nextjs config object.
In my case, webpack wasn't running but only because it was crashing when trying to get serverRuntimeConfig from the exported function. Everything works fine for me now.

same

withTM in that case defines a webpack function in the settings it returns.
So maybe the custom webpack function settings passed in withPlugins is already overrided by the above plugin ( withTM ) and thus ignored

+1 I'm having this issue in a major way
minimal reproduction here, it's just the typescript +css module starter from next.js. If you open next.config.js you'll see we try to log when our custom webpack "hook" runs
module.exports = withPlugins([[withCSS, cssConfig]],{
  webpack: config =>{
    console.log("This never runs :(");  // <<<<<<<<<<<<<<<< Here's the issue
    return config;
  }
});

but if you run the dev script you'll never hit that line of code.

@antontsvil
You define the webpack function twice in your file (once with the css plugin and once at the bottom) and the way next works, they overwrite each other so only one gets executed. You can simply change your next.config.js to only have one webpack definition like this:
const withCSS = require('@zeit/next-css')
const withPlugins = require('next-compose-plugins');
/* With additional configuration on top of CSS Modules */
const cssConfig = {
  cssModules: true,
  cssLoaderOptions: {
    camelCase: true,
    namedExport: true
  },
};

module.exports = withPlugins([[withCSS, cssConfig]],{
  webpack: (config, options) =>{
    console.log("This now runs :)");

    if (!options.isServer) {
      for (let entry of options.defaultLoaders.css) {
        if (entry.loader === 'css-loader') {
          entry.loader = 'typings-for-css-modules-loader'
          break
        }
      }
    }
    return config;
  }
});

I'm thinking if next-compose-plugins should manually parse the webpack definitions, but I'm not sure if that could break some special use-cases..

@cyrilwanner thanks for clearing that up. What's odd is that I've since found a workaround for this issue without removing the webpack function in the sassConfig. In my full project my next.config looks like this:
const extendWebpack = require("./extend-webpack");
const withPlugins = require("next-compose-plugins");
const withImages = require("next-optimized-images");
const withFonts = require("next-fonts");
const withSASS = require("@zeit/next-sass");

const SASSConfig = {
  cssModules: true,
  cssLoaderOptions: {
    importLoaders: 1,
    camelCase: true,
    namedExport: true
  },
  webpack(config, options) {
    if (!options.isServer) {
      for (let entry of options.defaultLoaders.sass) {
        if (entry.loader === "css-loader") {
          entry.loader = "typings-for-css-modules-loader";
        }
      }
    }
    return config;
  }
};

module.exports = withPlugins([
  [withSASS, SASSConfig],
  [withFonts],
  [withImages],
  [extendWebpack]
]);

The additional changes to my webpack config are made with this extendWebpack "plugin", which is simply a mock of a plugin structure that accomplishes what I need it to do. It looks like this:
const webpackAliasSupport = require("./lib/dev/webpack-alias-support");
const webpackEnableGlobal = require("./lib/dev/webpack-enable-global-sass");
module.exports = (nextConfig = {}, nextComposePlugins = {}) => {
  return Object.assign({}, nextConfig, {
    webpack: (config, options) => {
      config = webpackEnableGlobal(config);
      return webpackAliasSupport(config, options, nextConfig);
    }
  });
};

I'd like to apply your solution, since I'm sure there is still something wrong with my approach. Unfortunately I think I'm misunderstanding the order of the plugins being executed or something? When I try your suggested approach, the options.defaultLoaders object has no sass key, as if the withSASS plugin hasn't run yet. Am I incorrect in assuming that this final custom next config receives the webpack config at it's final state, after it's been transformed by all preceding plugins?

Ah, I see. The config gets passed to the plugins before they run so they are aware of the values set there (e.g. the publicPath etc).
I think your current solution works well, but I'll see if I find a more convenient way for overwriting the webpack config.

As a workaround, I wrote simple compose function:
function compose(plugins) {
  let cfg = {};
  return plugins.reduceRight(
    (prevFn, plugin) => {
      // console.log('-->', plugin);
      if (plugin[1]) cfg = { ...cfg, ...plugin[1] };
      return (...args) => plugin[0](prevFn(...args));
    },
    (value) => {
      // console.log('Combined config:', { ...cfg, ...value });
      return { ...cfg, ...value };
    }
  );
}

So your config will have the following view:
const plugins = const plugins = [
  [
    // https://github.com/zeit/next-plugins/tree/master/packages/next-css
    require('@zeit/next-css'),
    {
      cssModules: false,
      cssLoaderOptions: {},
    },
  ],
  [
    // https://github.com/zeit/next-plugins/tree/master/packages/next-sass
    require('@zeit/next-sass'),
    {
      sassLoaderOptions: {},
    },
  ],
];

const nextConfig = {
  distDir: '../dist',
};

module.export = compose(plugins)(nextConfig);

@antontsvil
You define the webpack function twice in your file (once with the css plugin and once at the bottom) and the way next works, they overwrite each other so only one gets executed. You can simply change your next.config.js to only have one webpack definition like this:
const withCSS = require('@zeit/next-css')
const withPlugins = require('next-compose-plugins');
/* With additional configuration on top of CSS Modules */
const cssConfig = {
  cssModules: true,
  cssLoaderOptions: {
    camelCase: true,
    namedExport: true
  },
};

module.exports = withPlugins([[withCSS, cssConfig]],{
  webpack: (config, options) =>{
    console.log("This now runs :)");

    if (!options.isServer) {
      for (let entry of options.defaultLoaders.css) {
        if (entry.loader === 'css-loader') {
          entry.loader = 'typings-for-css-modules-loader'
          break
        }
      }
    }
    return config;
  }
});

I'm thinking if next-compose-plugins should manually parse the webpack definitions, but I'm not sure if that could break some special use-cases..

Thanks for this reply. My expectation was different: I thought with every plugin I use in the chain, I can define a dedicated webpack function and these functions would be composed onto each other. Having only one webpack functions for multiple plugins make this a mess over time. For instance, the following would be my desired usage:
const nextConfig = {
  env: {
    BASE_URL: process.env.BASE_URL,
  },
};

const lessWithAntdConfig = {
  lessLoaderOptions: {
    javascriptEnabled: true,
    modifyVars: lessToJS(
      fs.readFileSync(
        path.resolve(__dirname, './assets/antd-custom.less'),
        'utf8'
      )
    ),
  },
  webpack: (config, { isServer }) => {
    if (isServer) {
      const antStyles = /antd\/.*?\/style.*?/;
      const origExternals = [...config.externals];
      config.externals = [
        (context, request, callback) => {
          if (request.match(antStyles)) return callback();
          if (typeof origExternals[0] === 'function') {
            origExternals[0](context, request, callback);
          } else {
            callback();
          }
        },
        ...(typeof origExternals[0] === 'function'
          ? []
          : origExternals),
      ];

      config.module.rules.unshift({
        test: antStyles,
        use: 'null-loader',
      });

      console.log(config.node);
    }

    return config;
  },
};

const mdxConfig = {
  webpack: (config, { isServer }) => {
    if (!isServer) {
      config.node = {
        fs: 'empty',
      };
    }

    return config;
  },
};

const withBundleAnalyzer = bundleAnalyzer({
  enabled: process.env.ANALYZE === 'true',
});

module.exports = withPlugins(
  [
    [withMDX, mdxConfig],
    [withLess, lessWithAntdConfig],
    [withBundleAnalyzer],
  ],
  nextConfig
);

Instead I have to group all webpack functions in one shared webpack function:
const nextConfig = {
  env: {
    BASE_URL: process.env.BASE_URL,
  },
  webpack: (config, { isServer }) => {
    // Less with Antd
    if (isServer) {
      const antStyles = /antd\/.*?\/style.*?/;
      const origExternals = [...config.externals];
      config.externals = [
        (context, request, callback) => {
          if (request.match(antStyles)) return callback();
          if (typeof origExternals[0] === 'function') {
            origExternals[0](context, request, callback);
          } else {
            callback();
          }
        },
        ...(typeof origExternals[0] === 'function'
          ? []
          : origExternals),
      ];

      config.module.rules.unshift({
        test: antStyles,
        use: 'null-loader',
      });
    }

    // MDX
    if (!isServer) {
      config.node = {
        fs: 'empty',
      };
    }

    return config;
  },
};

const lessWithAntdConfig = {
  lessLoaderOptions: {
    javascriptEnabled: true,
    modifyVars: lessToJS(
      fs.readFileSync(
        path.resolve(__dirname, './assets/antd-custom.less'),
        'utf8'
      )
    ),
  },
};

const withBundleAnalyzer = bundleAnalyzer({
  enabled: process.env.ANALYZE === 'true',
});

module.exports = withPlugins(
  [[withLess, lessWithAntdConfig], [withMDX], [withBundleAnalyzer]],
  nextConfig
);

In fact the config must be passed as array item together with plugins.
const cssConfig = {
  cssModules: true,
  cssLoaderOptions: {
    camelCase: true,
    namedExport: true
  },
};

module.exports = withPlugins([[withCSS, cssConfig]])


chore(deps): update @typescript-eslint/eslint-plugin

:tada: This PR is included in version 11.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: account nonce discrepancies tests

Description:

There are no e2e tests for checks that are happening between the ingestion of the transaction and its evm execution.
Add e2e tests based on these in services and on the current test plan.
Related issue(s):
Fixes #653
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

A draft PR for nonce discrepancies tests. Several PRs need to be merged and released before we can run these tests in the CI. Locally I've tested it against a custom build of services (PR#11045) and mirror node importer (PR#7617) and it's all green which is such a relief right now :four_leaf_clover:.

@natanasow I attempted to run the test locally using the latest version<EMAIL_ADDRESS>Unfortunately, all the units failed as null values were compared to the expected ones. After tracing down the issue, I identified that the error is originating from test/hts-precompile/utils.js:getAccountId().
Specifically, within the getAccountId() function, the error is triggered by the line await query.execute(client), resulting in the following error:
TypeError: Cannot read properties of undefined (reading 'accountId')

Any thoughts on what I might have missed?

@natanasow I attempted to run the test locally using the latest version<EMAIL_ADDRESS>Unfortunately, all the units failed as null values were compared to the expected ones. After tracing down the issue, I identified that the error is originating from test/hts-precompile/utils.js:getAccountId().
Specifically, within the getAccountId() function, the error is triggered by the line await query.execute(client), resulting in the following error:
TypeError: Cannot read properties of undefined (reading 'accountId')

Any thoughts on what I might have missed?

@quiet-node Just pushed some fixes and added a new pipeline for these tests. Could you try again locally, and keep in mind that if you're using the latest local node, some tests will fail because there are still no official images for HIP-844.

@natanasow I attempted to run the test locally using the latest version<EMAIL_ADDRESS>Unfortunately, all the units failed as null values were compared to the expected ones. After tracing down the issue, I identified that the error is originating from test/hts-precompile/utils.js:getAccountId().
Specifically, within the getAccountId() function, the error is triggered by the line await query.execute(client), resulting in the following error:
TypeError: Cannot read properties of undefined (reading 'accountId')

Any thoughts on what I might have missed?

@quiet-node Just pushed some fixes and added a new pipeline for these tests. Could you try again locally, and keep in mind that if you're using the latest local node, some tests will fail because there are still no official images for HIP-844.

Thanks for the update! I have tried it out locally and looks like the 2nd and the 4th units failed.
 Discrepancies - Nonce Test Suite
    ✔ should not update nonce when intrinsic gas handler check failed (65ms)
    1) should not update nonce when offered gas price and allowance are zero handler check failed
    ✔ should not update nonce when offered gas price is less than current and sender does not have enough balance handler check failed (2062ms)
    2) should not update nonce when offered gas price is less than current and gas allowance is less than remaining fee handler check failed
    ✔ should not update nonce when offered gas price is bigger than current and sender does not have enough balance handler check failed (1712ms)
    ✔ should not update nonce  when sender does not have enough balance handler check failed (1397ms)
    ✔ should update nonce after evm reversion due contract logic (1574ms)
    ✔ should update nonce after evm reversion due insufficient gas (1324ms)
    ✔ should update nonce after evm reversion due insufficient transfer amount (1077ms)
    ✔ should update nonce after evm reversion due sending value to ethereum precompile 0x2 (1572ms)
    ✔ should update nonce after evm reversion due sending value to hedera precompile0 x167 (1324ms)
    ✔ should update nonce after successful internal call (1070ms)
    ✔ should update nonce after successful internal transfer (2935ms)
    ✔ should update nonce after successful internal contract deployment (1323ms)

  12 passing (23s)
  2 failing

  1) Discrepancies - Nonce Test Suite
       should not update nonce when offered gas price and allowance are zero handler check failed:

      AssertionError: expected 2 to equal 3
      + expected - actual

      -2
      +3

      at expectNonIncrementedNonce (test/discrepancies/Nonce.js:90:36)
      at Context.<anonymous> (test/discrepancies/Nonce.js:135:5)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

  2) Discrepancies - Nonce Test Suite
       should not update nonce when offered gas price is less than current and gas allowance is less than remaining fee handler check failed:

      AssertionError: expected 4 to equal 5
      + expected - actual

      -4
      +5

      at expectNonIncrementedNonce (test/discrepancies/Nonce.js:90:36)
      at Context.<anonymous> (test/discrepancies/Nonce.js:182:5)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Just like in the CI.
So as you said some tests will fail because there are still no official images for HIP-844, I'm not sure if we should approve failing tests or we should wait for the official images for HIP-844.
@Nana-EC thoughts?

@natanasow I attempted to run the test locally using the latest version<EMAIL_ADDRESS>Unfortunately, all the units failed as null values were compared to the expected ones. After tracing down the issue, I identified that the error is originating from test/hts-precompile/utils.js:getAccountId().
Specifically, within the getAccountId() function, the error is triggered by the line await query.execute(client), resulting in the following error:
TypeError: Cannot read properties of undefined (reading 'accountId')

Any thoughts on what I might have missed?

@quiet-node Just pushed some fixes and added a new pipeline for these tests. Could you try again locally, and keep in mind that if you're using the latest local node, some tests will fail because there are still no official images for HIP-844.

Thanks for the update! I have tried it out locally and looks like the 2nd and the 4th units failed.
 Discrepancies - Nonce Test Suite
    ✔ should not update nonce when intrinsic gas handler check failed (65ms)
    1) should not update nonce when offered gas price and allowance are zero handler check failed
    ✔ should not update nonce when offered gas price is less than current and sender does not have enough balance handler check failed (2062ms)
    2) should not update nonce when offered gas price is less than current and gas allowance is less than remaining fee handler check failed
    ✔ should not update nonce when offered gas price is bigger than current and sender does not have enough balance handler check failed (1712ms)
    ✔ should not update nonce  when sender does not have enough balance handler check failed (1397ms)
    ✔ should update nonce after evm reversion due contract logic (1574ms)
    ✔ should update nonce after evm reversion due insufficient gas (1324ms)
    ✔ should update nonce after evm reversion due insufficient transfer amount (1077ms)
    ✔ should update nonce after evm reversion due sending value to ethereum precompile 0x2 (1572ms)
    ✔ should update nonce after evm reversion due sending value to hedera precompile0 x167 (1324ms)
    ✔ should update nonce after successful internal call (1070ms)
    ✔ should update nonce after successful internal transfer (2935ms)
    ✔ should update nonce after successful internal contract deployment (1323ms)

  12 passing (23s)
  2 failing

  1) Discrepancies - Nonce Test Suite
       should not update nonce when offered gas price and allowance are zero handler check failed:

      AssertionError: expected 2 to equal 3
      + expected - actual

      -2
      +3

      at expectNonIncrementedNonce (test/discrepancies/Nonce.js:90:36)
      at Context.<anonymous> (test/discrepancies/Nonce.js:135:5)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

  2) Discrepancies - Nonce Test Suite
       should not update nonce when offered gas price is less than current and gas allowance is less than remaining fee handler check failed:

      AssertionError: expected 4 to equal 5
      + expected - actual

      -4
      +5

      at expectNonIncrementedNonce (test/discrepancies/Nonce.js:90:36)
      at Context.<anonymous> (test/discrepancies/Nonce.js:182:5)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Just like in the CI.
So as you said some tests will fail because there are still no official images for HIP-844, I'm not sure if we should approve failing tests or we should wait for the official images for HIP-844.
@Nana-EC thoughts?

IMO, we should NOT merge this into develop till official images of HIP-844 are released. Once they are released, we should update the local node first and release a new version of it with the updated images. After that, I have to circle back here and bump the local node version in this repo. With the newest version, which must include HIP-844, these tests have to succeed and we will be free to merge it.