Unable to install dependencies following instructions

Getting following error message during installation:
PS C:\Users\TBA\sourcecode\cumulocity-app-builder> npm i<EMAIL_ADDRESS>leaflet2<EMAIL_ADDRESS>
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/angular-resize-event
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\TBA\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!      C:\Users\TBA\AppData\Local\npm-cache\_logs\2021-06-28T06_58_20_864Z-debug.log

Is there actually a requirement for angular-resize-event? Can't we just listen for the changeEnd EventEmitter of the parent component (DashboardChildComponent)?

@reey I had the same issue, this is resolved by installing the version of Node JS mentionned in the README file (v12.19.0). You can use something like node version manager to install it easily.
After that installing the dependencies and running npm run build should work.
NB this plugin will still be incompatible with the latest versions of Cumulocity AFAIK...


fetchbranches: add support for access tokens

With this patch fetchbranches is able to read a github
access token from /etc/fetchbranches/token, ff this file
does not exist or cannnot be read the github client with
a nil http client because we can still the github API without
an access token
fixes #269
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

the hard wired path to /etc/fetchbranches for the token file feels a little, well, hard-wired. But, if nobody else objects or has a better suggestion:
lgtm

lgtm


(Question, not bug:) Porcupine SwiftPM support on iOS

Have you checked the docs and existing issues?

[X] I have read all of the relevant Picovoice Porcupine docs
[X] I have searched the existing issues for Porcupine

SDK
iOS
Porcupine package version
Porcupine-iOS-v3.0.1
Framework version
Xcode 16
Platform
iOS
OS/Browser version
iOS 16
Describe the bug
Our project is using Swift Package Manager, not CocoaPods, for dependency management. Does Porcupine iOS support SPM?
Steps To Reproduce
Attempt to use Porcupine iOS with Swift Package Manager
Expected Behavior
Porcupine iOS can be used with Swift Package Manager

Porcupine does not currently support SPM. We've had a few requests for moving to SPM and we are looking to make the switch. Unfortunately we don't have an estimate when the change will be done. I'll leave this issue up for now and close it when an SPM package for Porcupine is available.

@pipacs - Porcupine is now available on SPM (3.0.4). Let us know if you have any problems adding it.

Closed as this feature has been added - reopen if there are any issues with it


Add support to disable hyperv dynamic memory management

...during VM creation
addresses #4477
Signed-off-by: Shahid Iqbal<EMAIL_ADDRESS>

Do I need to tag assign someone to get a review of this or is it a waiting game?
Unsure of the process

LGTM


image

Hey @Mojalefa99 - was there any other context to go with this issue? Or is it ok for me to close this?

You can close it
On Tue, 19 Nov 2019, 22:54 Eric Fleming<EMAIL_ADDRESS>wrote:

Hey @Mojalefa99 https://github.com/Mojalefa99 - was there any other
context to go with this issue? Or is it ok for me to close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ardalis/CleanArchitecture/issues/59?email_source=notifications&email_token=ALMIWZUGIJ5OOXHNATGIC6TQURG7LA5CNFSM4HDEV7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEPXCRY#issuecomment-555708743,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALMIWZVXR27O7FWAH5BAO5LQURG7LANCNFSM4HDEV7IQ
.


BUG-Scatter Plot doesn't update colors, needs page reload

Description
Currently when modifying the data in a scatter plot, the position of the points accurately change but the colors don't update. This leads to incorrect coloring of points:

And after a page reload, the points' colors update:

How to reproduce
Create and modify a pandas dataframe with data and color:
state.visual_data = pd.DataFrame(
        {
            "x": state.X[::1000, 0],
            "y": state.X[::1000, 1],
            "color": state.km.labels_[::1000],
        }
    )

Add a chart markers visual element
<|{visual_data}|chart|mode=markers|x=x|y=y|color=color|>

Run the app then modify the data, the points should move but the colors won't update before a page reload.
Expected behavior
When the data of a chart visual element is modified, the color data should be re-evaluated to display the correct colors without a page reload.
Runtime environment
Please specify relevant indications.

OS: Windows
Browser: Chrome

Color is part of the chart config
The chart should be updated if the rebuild property is specified and color is set as a variable
color = "color"
<|{visual_data}|chart|mode=markers|x=x|y=y|color={color}|rebuild|>
(one might need to update the var => state.color = state.color)

Understood thanks, maybe this should be added in the docs

I think there's a paragraph coming on rebuild for table and chart.

@AlexandreSajus Does this section helps?

I did not see the section when going through the doc. Ideally, maybe we should add this:

Here and in all the other plots' arguments lists:

Also, why is rebuild not True by default?
You can close this issue if you want

As for why it's not the default, that's for performance reasons.
'rebuild' requests the entire generation of the component, potentially entirely redefined.
When set to False, it allows for far faster feedback in response to a user action.

The recommendation is captured in a dedicated taipy-doc issue.


Break TensorGroup into InputTensorGroup and OutputTensorGroup.

This allows array to conform to InputTensorGroup and participate as an input to a #tfop.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

Updated with fixes.

@swift-ci please test tensorflow

Thanks for the updates! I re-reviewed it.
Is swift-ci still not listening to you? Let me know if you want me to trigger it.

Also, my conflicting PR is submitted now so expect a few conflicts. Let me know if you want help resolving them. Sorry :)

All good now.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow


Janitorial stuff

Commits pretty much say it all. Really like your dotfiles, based my 'supercharged' ones on them so thought I'd contribute back for a bit.

Changing NSGlobalDomain to -g makes it less prone to problems if Apple changes things
Commenting out all the stuff that either does nothing or spits out an error should clear up output
Reordering is just more logical (categorical, then alphabetical)
Removal of superflous text isn't necessary but does look nicer :)
Don't write .DS_Store files to USB volumes

Cheers!

I've googled around for a bit and sudo nvram SystemAudioVolume=" " (or %80, %%) etc seems to only work on older Macs. Can't test that for sure since I don't have older Macs lying around.
sudo nvram boot-args="mbasd=1" gives the error nvram: Error setting variable - 'boot-args': (iokit/common) general error
file=/Applications/Dropbox.app/Contents/Resources/emblem-dropbox-uptodate.icns  -[ -e "${file}" ] && mv -f "${file}" "${file}.bak"		 [ -e "${file}" ] && mv -f "${file}" "${file}.bak"
does work, but after a reboot (or restarting Dropbox and then killall Finder), the green checkmark returns.
I'm almost 100% certain that
defaults write com.apple.dock expose-animation-duration -float 0.1
doesn't work since Sierra and that animation speed is now tied to touchpad gesture intensity. If a keyboard key/shortcut is used, a default value is used instead that cannot be changed (or at least not by said command).


Tidy up to hosted services doc

Fixes https://github.com/aspnet/AspNetCore/issues/8945
The customer in the linked issue had some confusion about why ExecuteAsync wasn't being called when they had overridden StartAsync, and it's because they didn't call the base class method. Added some content to clarify that.
Also, I rephrased some content here since I thought it was important to call out that StartAsync and StopAsync are optional methods that give you additional control over the lifetime of the service, if you want it.

I'm going to edit directly to just fix a few small things ... 2nd person and future tense. Stand-by!


Adding a run in editor feature

Is your feature request related to a problem? Please describe.
When I want to debug a new project on xenko, it  always opens a new window,
The first issue with this comes from the fact that it creates a new window.
It isn't a good thing for people with only one screen, since it makes it harder to see the editor while playing when the game window hides the editor window
The second and biggest issue is that on laptops having integrated graphics + an nvidia gpu , it tends to confuse the intel technology not knowing wether it should use the integrated graphics or the nvidia drivers for the newly opened process (in my case, it was chosing the worst option, the integrated graphics for the game instead of my gtx 1060 while using the 1060 for the editor, which forced me to always manually set for all the binaries new projects the default gpu to use, which shouldn't be required when using a game engine)
Describe the solution you'd like
Having an option allowing to directly play the game in the editor, the same way as Unity Engine, Unreal Engine and Lumberyard Engine
it would allow to still look at the engine while playing (and maybe allow to edit in real time variables)
and allow to set only once the editor to use the nvidia gpu and all the projects would properly work with the high performances gpu without setting each executable manually
Describe alternatives you've considered
I don't really know any possible alternative that could fix the second issue I mentionned, but for the first issue, it should be possible to still use an other process but instead of making a new window simply rendering it in the editor.
Additional context
Here is an example where the integrated gpu was automatically chosed instead of my gtx 1060 because of the way it works  (it's saying that no app except the editor  is using the nvidia gpu, which means that because the game is an external process it automatically uses the integrated graphics)

it could indeed be possible to make it so that the pc always uses the nvidia gpu in the system settings, but if there is this feature automatically using the integrated gpu it's because it's useful and necessary since it allows to reduce heat and power consumptions, which is normal for gaming laptops so we should be able to use properly the xenko engine without having to modify it and just add an exception for the xenko editor

A run in editor feature (like the other game engines) saves time compared to building the files especially for people that have a low end processor (including me). Some humans leave the CPU unchanged and already have a good performance GPU. At least some individuals prefer to spend seconds of waiting instead of minutes so this feature may benefit anyone that uses Stride regardless of the being's skill level. It might be as simple as pressing F5. Allowing the person to edit the variables in real-time could let the human continue to test a scene without having to change the program, try to run it, wait, test it, stop it, repeat. The session may become more convenient to update and the progress doesn't have to be reset every time or as often.


Correction for raw affiliation Department of Medical Biophysics, Schulich School of Medicine and Dentistry, Western University

Correction needed for raw affiliation Department of Medical Biophysics, Schulich School of Medicine and Dentistry, Western University
raw_affiliation_name: Department of Medical Biophysics, Schulich School of Medicine and Dentistry, Western University
new_rors: 02grkyz14
previous_rors: 02agqkc58
works_examples: W4389726444;W4380272571;W4389296200
contact: b1091c7219eb303326228cfe56b1040f:5fce4bb72f181580 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


How much jaggery do I add?

I get that the recipe says to add jaggery powder to taste, but how much specifically do you put? I struggle to find the right balance

All right so for me I hit about three teaspoons before I'm happy, and for my better half, she likes it at about 3.5 teaspoons. I'll update the recipe on the next iteration with some rough guidelines


new pass of improvements in the dashboard

splitting variables are now human readable
added a "total number of publications" metric
removed "%" in the y-axis values when not using a percent metric
tooltip : the values are sorted descending
fixed aggregation

I have tried adding a % in the tooltip values, as well as the total number of publications, but I don't have a straightforward way. I'll have to build a custom tooltip which could take me 2 to 4 hours.

Looks good, thanks.


futures_open_interest()

    def futures_open_interest(self, **params):
        """Get present open interest of a specific symbol.
        https://binance-docs.github.io/apidocs/futures/en/#open-interest-market_data
        """
        return self._request_futures_api('get', 'ticker/openInterest', data=params)

the final line needs to be changed to
        return self._request_futures_api('get', 'openInterest', data=params)

I think your point is valid. I noticed this just now. a PR would be great.

I will review + merge if we can get a PR + some confirmations from both of you that it works


Make browser list more useful

Changes proposed in this pull request:

Hyperlink browser list to their homepages
Add Safari as support WebKit browser
Correct WebKit capitalisation ;-)

I hope it's correct to update all */versioned_docs/version-*/ files as well.

[ ] Discuss, whether the list has to be duplicated in running.md & installing.md files

Thank you, @ostephens! I guess the list has to be duplicated in running.md & installing.md files ;-D

@katrinleinweber the way it's currently structured I think it's safer because we may find someone reads one page but not the other? Perhaps a better alternative approach would be to have a page on browser compatibility which is linked from both locations?

Good point! I've started https://github.com/OpenRefine/OpenRefine/issues/5234 as a follow-up to this.


K8SPG-334: PMM fixes and improvements

CHANGE DESCRIPTION
Problem:

postgres-exporter doesn't work with passwords with commas.
reconciliation errors if user defines monitor user in CR.
we need to restart PG pods if PMM API key is rotated.
CR status is ready right after cluster is created and then becomes initializing.

Solution:

Use only alphanumeric characters for monitor user.
Ignore monitor user in CR.
We watch for changes in PMM secret and update pod annotations with secret hash to restart pods.
If size is 0 and cluster is not paused, state should be initializing.

CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PG version?
[x] Does the change support oldest and newest supported Kubernetes version?

PLEASE DON'T SQUASH AND MERGE, COMMITS ARE SEPARATE.

Test name
Status

init-deploy
passed

demand-backup
passed

start-from-backup
passed

monitoring
passed

We run 4 out of 4

commit: https://github.com/percona/percona-postgresql-operator/pull/412/commits/fa19ee945f4fb7fef5051ad17d67a8ab7cf44800
image: perconalab/percona-postgresql-operator:PR-412-fa19ee945

Test name
Status

We run 0 out of 4

commit: https://github.com/percona/percona-postgresql-operator/pull/412/commits/1c55cf912c13b53a19aee1332ac35f6ccba08d86
image: perconalab/percona-postgresql-operator:PR-412-1c55cf912

Test name
Status

init-deploy
passed

demand-backup
passed

start-from-backup
passed

monitoring
passed

We run 4 out of 4

commit: https://github.com/percona/percona-postgresql-operator/pull/412/commits/aad3c5b3c9654b2baac6462398eb8167e49464d0
image: perconalab/percona-postgresql-operator:PR-412-aad3c5b3c


SDFSOF-66: RPC Actions - implement Jobs (payments/trust)

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Trustline check job
Why
Platform should check whether trustline is set to proceed with payment
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr987.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr987.previews.kube001.services.stellar-ops.com/


Genericize tool

Comma is coded to wok specifically with the Linux kernel, but most of the logic is not Linux-specific and could work with other forked projects.
Outside of some hard-coded values, the only logic that appears to be Linux-specific is the parsing of the maintainers file to get paths. This can likely be done through an plugin referenced in a config file.

Much of this work was done in #67, but there are still some remaining tasks.

Hardcoded values

#50
#65
#66

Move some functionality to plugins and support plugins in config
get_tracked_paths for upstream paths
references on downstream targets


Dragging the column clears the active edit

During design meeting today @brettfiedler noticed that when you click on the draggable tab to resize the columns the active edit is cleared. This is annoying, we should prevent this.

Fixed, closing.


Fix display of contracts on activation

Fixes #60

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

Lgtm :+1:


build: switch to poetry, add development dependencies

This PR includes a number of small changes.

Switch to the poetry package manager.

poetry is a modern python package manager, taking advantage of the standardized pyproject.toml configuration format
⚠ This requires a colcon plugin that isn't in the default ubuntu install. I don't know if ROS likes this, and if they don't I'll either need to get the plugin upstreamed (😢) or figure out some other clever solution.
dependencies are now pinned and locked with hashes (before, the latest version was always pulled via an unversioned requirements.txt, which means fogros2 could just break all of a sudden and we’d have to scramble to fix it)

Add code formatting tools (black, isort, flake8)
Add mypy to check types

safety!

https://github.com/python-poetry/poetry/issues/761#issuecomment-521124268

Note: to test this PR, you need https://discourse.ros.org/t/use-poetry-in-your-ros2-packages-with-colcon-poetry-ros/25096 installed atm


Pikaday field error 'Converting circular structure to JSON' when the 'pikadayOptions' property is used

I'm submitting a ...

[-] bug report

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
Currently when I try to use the Pikaday field and pass the 'pikadayOptions' property, then the form gives me the following error after the date is selected from the date piker calendar:

TypeError: Converting circular structure to JSON (in Chrome)
and
TypeError: "cyclic object value" (in Firefox)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via

https://jsfiddle.net/allexg/6hxq2rbo/19/ - check this jsfiddle to see issue

What is the expected behavior?
The expected behavior is to not have the js error.

Please tell us about your environment:
Vue.js v2.5.20
vue-form-generator v2.1.0
pikaday v1.8.0
moment.js v2.20.1

Browser: [all | Crome Version 70.0.3538.110 | Firefox 63.0.3 (64-bit)  ]

Other information
Does anyone know how to fix this issue ?

Thank you.

This appears to be caused by the fieldPikaday component modifying the 'pikadayOptions' object that was passed in ... it calls lodash's defaults method and adds a field and onSelect to it.  The field is a reference to this.$el which is likely where the circular reference is coming from.
Also - it looks like your sample was a bit off, you had format setup in the pikadayOptions as "D MMM YYYY" but the date in the model was "DD, MM YYYY" (or MM, DD YYYY)
A working version of your example is here: https://jsfiddle.net/4za6tmuv/ - due to the odd date format, I added the format and toString options to the example so it can parse and update the values properly as well.
You can't JSON.stringify the schema because of the circular reference, and attempting to do so causing the component to fail ...
I'm creating a PR that should resolve this issue, in the mean time ... just don't JSON.stringify the schema.

Thank you @zoul0813!
Your solution fixed the issue.


many stars than expected returned to aloy by the server

for me i got 210 stars on aloy, excepted to be 5 stars

Wait is it seriously giving 210 stars now? In 2.1 I had to fix aloy having 105 and now this. I swear mihoyo ain't thinking straight.
Gonna fix tomorrow once I get to a computer.

i wish i could open a pr. im also moving my home. thanks for the hard work tho


Neckro Null Object

What commit is this?

I'm thinking it can only be _monsterAI:
        private Container GetNearestDropOffPoint() {
            // Container closestContainer;
            Container closestContainer = FindClosest<Container>(DropoffPointRadius.Value, pieceMask,
                c => c.GetInventory().GetEmptySlots() > 0);
            if (closestContainer == null) return null;

            // move toward that piece
            _monsterAI.SetFollowTarget(closestContainer.gameObject);
            return closestContainer;
        }
        ```

What's the NeckroStatus when this error occurs? Can't recreate the error by removing nearby containers.

It's a problem with the FindClosest method. Probably happens when no Containers or something. Thanks for finding this!

Maybe this line? .Where(t => t.GetComponent<ZNetView>().IsValid()) // TODO: explain
Perhaps no ZNetView is there

That seems to fix it for now, so I am going to release that as a hotfix and we can investigate better solutions later. Just gotta stop ppls games crashing etc.


repl package name for pub

I'm happy to see you are keen to progress this work on a Dart REPL, you've made excellent progress so far and I currently don't have time to keep working on it, so if you would like, I'd happy to move the repl package name on Pub over to your publisher account so that you can make use of it for this package and I can deprecate and archive my repo.

Thank you! But I like the "interactive" name as well.

and I can deprecate and archive my repo.

This reminds me of a common practice in github community: When user A does not have time keep maintaining a package, will add a line README saying "please see user B's package B" and archive the github repo / deprecate the pub. Anyway this surely depends on you :)

I've now updated my packages Readme to point to this package. Thanks again for making a fully usable Dart REPL! 👍🏻

You are welcome and thanks for your prior work!


Develop

Please delete the .vs, bin, obj folders and have them in gitignore.
Check-in the app as file and have it in a folder called app/.

done

LGTM


NoSuchMethodError: The method 'doWhenOpened' was called on null.

What I was trying to do
Trying out moor-ffi, I followed the guide but it doesn't seem to be working as expected. I verified that this does work no problem on moor-flutter
What is happening
When I try and initialize the database, I see this in the logs
flutter: NoSuchMethodError: The method 'doWhenOpened' was called on null.
Receiver: null
Tried calling: doWhenOpened<List<Map<String, dynamic>>>(Closure: (QueryExecutor) => Future<List<Map<String, dynamic>>>)

db.dart:
import 'dart:io';

import 'package:moor/moor.dart';
import 'package:moor_ffi/moor_ffi.dart';
import 'package:path_provider/path_provider.dart';
import 'package:path/path.dart' as p;

part 'db.g.dart';

@UseMoor(include: {'./db.moor'})
class Database extends _$Database {
  // we tell the database where to store the data with this constructor
  Database() : super(inDatabaseFolder(path: 'db.sqlite'));

  static inDatabaseFolder({String path}) {
    LazyDatabase(() async {
      final dbFolder = await getApplicationDocumentsDirectory();
      final file = File(p.join(dbFolder.path, path));
      return VmDatabase(file);
    });
  }

  // you should bump this number whenever you change or add a table definition. Migrations
  // are covered later in this readme.
  @override
  int get schemaVersion => 1;
}

db.moor
CREATE TABLE totp(
  id INTEGER PRIMARY KEY,
  name TEXT NOT NULL,
  secret_key TEXT NOT NULL,
  image_url TEXT NOT NULL
);

getTotpList: SELECT id, name FROM totp;
getTotp: SELECT * FROM totp WHERE id = :id LIMIT 1;
addTotp: INSERT INTO totp (name, secret_key, image_url) VALUES (:name, :secret_key, :image_url);

pubspec.yaml (dependencies + devDependencies):
dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2
  bloc: ^0.14.0
  flutter_bloc: ^0.18.0
  equatable: ^0.2.0
  path: ^1.6.2
  otp: 1.0.3
  moor: ^2.0.0
  moor_ffi: 0.1.0-dev.1
  # moor_flutter: ^2.0.0
  path_provider: ^1.4.0
  path_provider_fde:
    path: ../flutter-desktop-embedding/plugins/flutter_plugins/path_provider_fde

dev_dependencies:
  flutter_test:
    sdk: flutter
  moor_generator: ^2.0.0
  build_runner: ^1.7.2

I think your inDatabaseFolder function is just missing a return statement:
static inDatabaseFolder({String path}) {
    return LazyDatabase(() async {
      final dbFolder = await getApplicationDocumentsDirectory();
      final file = File(p.join(dbFolder.path, path));
      return VmDatabase(file);
    });
  }

Yep that was it, can't believe I missed that 😭


Refactor FDO2 Sensor for longer setup (up to 5 sec) & non-blocking I/O

This PR:

Refactors the FDO2 Sensor to use non-blocking I/O by decomposing management of states and state transitions into a StateMachine.
Fixes problems observed in FDO2 sensor initialization when the Nucleo-H743ZI2 board was reset using the RESET button rather than by unplugging and plugging in the USB cable: in some cases, setup would fail. What I have observed in the logic analyzer is that sometimes multiple start-broadcast requests need to be sent before a response is received in a reasonable time. The fix is to increase the duration of time that the setup routine retries sending requests before giving up and reporting a failure. I have adjusted this to increase from 1 sec to 5 sec, though in testing I have always seen the sensor either complete setup quickly (<1 sec) or take ~3 sec to complete setup successfully.

@Tanmay06 Can you and the rest of your team test this PR to check whether it fully fixes the problem you reported? I expect that you should now see that the Nucleo board's LED1 sometimes starts with a brief (<1 sec) solid ON before transitioning into the setup success indicator pattern (2 sec of brief blinks before transitioning into solid OFF), while other times it will start with a longer (~3 sec) solid ON before transitioning into the setup success indicator pattern. It should never start with a very long (5 sec) solid ON before transitioning into the setup failure indicator pattern (very rapid flashing forever).
This PR is in the critical path of development, passes clang-tidy and clang-format checks, is needed for to support hardware bring-up at Bharat Forge, is of at least comparable quality to the rest of the firmware codebase, and is a bugfix. I will merge in this PR after the Bharat Forge team tests this and confirms that it fixes the problem they have reported, but before a full code review is completed.
For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
Were any of these contributions also part of work you did for an employer or a client? No
Does this work include, or is it based on, any third-party work which you did not create? No


how to delete a property from an object?

In JavaScript:
delete obj["foo"]

In TickTick/Bash perhaps this would be more appropriate:
obj["foo"].delete()

unset name

woops ... that won't work. Let me think.

Fixed as of
https://github.com/kristopolous/TickTick/commit/7537095b6508b824bc60e03a7f81df30ca3570ce
Synopsis:
Your .delete() suggestion was used. a new test tests/delete.sh has been added. Thanks!


Fixing the sqlite and database functional tests

In the action, these two functional tests are failing: https://github.com/AgnostiqHQ/covalent/actions/runs/6419279034/job/17428797774, we need to fix that.

@kessler-frost is this gtg with latest pipeline fix and Mem PR merge ?

@santoshkumarradha they are currently skipped and will likely fail again. We'll need to take a slightly deeper look as to why the process is failing in them.


add only created_at timestamp to the table

Laravel Version: 5.3.0
PHP Version: 5.6.25
Database Driver & Version: MySql 5.0.11

Description:
I want to set only the created_at timestamp in my notification table instead of both the timestamps
is it possible
Steps To Reproduce:

you can use $table->timestamp('created_at'); Check https://laravel.com/docs/5.3/migrations#columns
Please ask questions in the forums, this repo is for bug reporting only.


(973) Convert incorrect date formats to dd/mm/yyyy

NB: The CSV which contains the date corrections is not included here, so should be copied over to the server before running.
rails runner db/data_migrate/20190408132216_fix_american_dates.rb

I don't think we want to merge db/data_migrate/correct_american_date_formats.rb or the addition of roo in this do we?

@james Yeah! Forgot about that.. will take it out!

This worked for me locally, so I'll approve as soon as running task is fixed in the comment!


LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

Description
This PR is WIP for implementing basic dynamic pruning support for CombinedFieldsQuery
Tests
Added a randomized test to compare and verify top 100 results match between top_score (with pruning) and complete scoring.

Perf tests result for commit 2ba435e5c83f870be9566
Run 1:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                     CFQHighHigh        3.53      (3.3%)        2.92      (5.3%)  -17.2% ( -25% -   -8%) 0.000
                        PKLookup      108.13      (7.7%)      119.85      (8.2%)   10.8% (  -4% -   28%) 0.000
                      CFQHighLow       14.88      (3.9%)       16.69     (12.5%)   12.2% (  -3% -   29%) 0.000
                      CFQHighMed       21.11      (4.1%)       25.87     (11.8%)   22.6% (   6% -   40%) 0.000
Run 2:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                     CFQHighHigh        6.64      (3.1%)        5.63     (10.2%)  -15.2% ( -27% -   -1%) 0.000
                      CFQHighLow        8.35      (2.8%)        8.05     (15.0%)   -3.6% ( -20% -   14%) 0.297
                      CFQHighMed       24.51      (5.3%)       24.90     (19.9%)    1.6% ( -22% -   28%) 0.733
                        PKLookup      110.06     (10.0%)      128.54      (7.9%)   16.8% (  -1% -   38%) 0.000
Run 3:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                      CFQHighMed       13.01      (2.9%)        9.82      (7.8%)  -24.5% ( -34% -  -14%) 0.000
                        PKLookup      107.85      (8.1%)      111.79     (11.2%)    3.7% ( -14% -   24%) 0.236
                     CFQHighHigh        4.83      (2.6%)        5.06      (8.6%)    4.7% (  -6% -   16%) 0.018
                      CFQHighLow       14.95      (3.0%)       18.31     (19.0%)   22.5% (   0% -   45%) 0.000
Run 4:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                      CFQHighMed       11.11      (2.9%)        6.69      (4.1%)  -39.7% ( -45% -  -33%) 0.000
                      CFQHighLow       27.55      (3.8%)       25.46     (11.0%)   -7.6% ( -21% -    7%) 0.003
                     CFQHighHigh        5.25      (3.2%)        4.96      (6.1%)   -5.7% ( -14% -    3%) 0.000
                        PKLookup      107.61      (6.7%)      121.19      (4.6%)   12.6% (   1% -   25%) 0.000

Perf test result from 1a71469bf7afa3
Run 1
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CFQHighHighHigh        4.64      (6.5%)        3.30      (4.7%)  -29.0% ( -37% -  -19%) 0.000
                     CFQHighHigh       11.09      (6.0%)        9.61      (6.0%)  -13.3% ( -23% -   -1%) 0.000
                        PKLookup      103.38      (4.4%)      108.04      (4.3%)    4.5% (  -4% -   13%) 0.001
                   CFQHighMedLow       10.58      (6.1%)       12.30      (8.7%)   16.2% (   1% -   33%) 0.000
                      CFQHighMed       10.70      (7.4%)       15.51     (11.2%)   44.9% (  24% -   68%) 0.000
                   CFQHighLowLow        8.18      (8.2%)       12.87     (11.6%)   57.3% (  34% -   84%) 0.000
                      CFQHighLow       14.57      (7.5%)       30.81     (15.1%)  111.4% (  82% -  144%) 0.000

Run 2
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CFQHighHighHigh        5.33      (5.7%)        4.02      (7.7%)  -24.4% ( -35% -  -11%) 0.000
                   CFQHighLowLow       17.14      (6.2%)       13.06      (5.4%)  -23.8% ( -33% -  -13%) 0.000
                      CFQHighMed       17.37      (5.8%)       14.38      (7.7%)  -17.2% ( -29% -   -3%) 0.000
                        PKLookup      103.57      (5.5%)      108.84      (5.9%)    5.1% (  -6% -   17%) 0.005
                   CFQHighMedLow       11.25      (7.2%)       12.70      (9.0%)   12.9% (  -3% -   31%) 0.000
                     CFQHighHigh        5.00      (6.2%)        7.54     (12.1%)   51.0% (  30% -   73%) 0.000
                      CFQHighLow       21.60      (5.2%)       34.57     (14.1%)   60.0% (  38% -   83%) 0.000

Run 3
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CFQHighHighHigh        5.40      (6.9%)        4.06      (5.1%)  -24.8% ( -34% -  -13%) 0.000
                   CFQHighMedLow        7.64      (7.4%)        5.79      (6.3%)  -24.2% ( -35% -  -11%) 0.000
                     CFQHighHigh       11.11      (7.0%)        9.60      (5.9%)  -13.6% ( -24% -    0%) 0.000
                   CFQHighLowLow       21.21      (7.6%)       21.22      (6.6%)    0.0% ( -13% -   15%) 0.993
                        PKLookup      103.15      (5.9%)      107.60      (6.9%)    4.3% (  -8% -   18%) 0.034
                      CFQHighLow       21.85      (8.1%)       34.18     (13.5%)   56.4% (  32% -   84%) 0.000
                      CFQHighMed       12.07      (8.4%)       19.98     (16.7%)   65.5% (  37% -   98%) 0.000

Run 4
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                     CFQHighHigh        8.50      (5.8%)        6.85      (5.2%)  -19.5% ( -28% -   -8%) 0.000
                   CFQHighMedLow       10.89      (5.7%)        8.96      (5.4%)  -17.8% ( -27% -   -7%) 0.000
                      CFQHighMed        8.41      (5.8%)        7.74      (5.6%)   -7.9% ( -18% -    3%) 0.000
                 CFQHighHighHigh        3.45      (6.7%)        3.38      (5.3%)   -2.0% ( -13% -   10%) 0.287
                   CFQHighLowLow        7.82      (6.4%)        8.20      (7.5%)    4.8% (  -8% -   20%) 0.030
                        PKLookup      103.50      (5.0%)      110.69      (5.4%)    6.9% (  -3% -   18%) 0.000
                      CFQHighLow       11.46      (6.0%)       13.16      (6.7%)   14.8% (   1% -   29%) 0.000

I re-ran perf test after https://github.com/mikemccand/luceneutil/commit/0550148b67f82d446e07bd0b4fdbde24f1d6228d has been merged:
Results from python3 src/python/localrun.py -source combinedFieldsBig:
Run 1:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
     CFQHighHigh        3.69      (1.8%)        2.49      (6.2%)  -32.5% ( -39% -  -24%) 0.000
      CFQHighMed        4.95      (2.1%)        4.19      (5.9%)  -15.5% ( -22% -   -7%) 0.000
        PKLookup      125.72      (4.5%)      126.86     (10.3%)    0.9% ( -13% -   16%) 0.719
      CFQHighLow       19.92      (2.2%)       20.80      (9.5%)    4.4% (  -7% -   16%) 0.043

Run 2:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
     CFQHighHigh        3.61      (2.8%)        2.48      (2.9%)  -31.4% ( -36% -  -26%) 0.000
        PKLookup      116.67      (7.1%)      123.97      (5.5%)    6.3% (  -5% -   20%) 0.002
      CFQHighMed        4.97      (3.6%)        5.29      (5.5%)    6.6% (  -2% -   16%) 0.000
      CFQHighLow       11.96      (4.5%)       13.99      (6.5%)   17.0% (   5% -   29%) 0.000

Run 3:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
     CFQHighHigh        3.51      (4.2%)        2.44      (6.5%)  -30.5% ( -39% -  -20%) 0.000
        PKLookup      105.72     (11.9%)      108.81     (11.2%)    2.9% ( -18% -   29%) 0.424
      CFQHighMed       10.85      (4.2%)       11.60     (11.4%)    6.9% (  -8% -   23%) 0.011
      CFQHighLow       15.11      (5.6%)       16.16      (9.8%)    7.0% (  -7% -   23%) 0.006

Results from python3 src/python/localrun.py -source combinedFieldsUnevenlyWeightedBig
Run 1:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
        PKLookup       93.42     (13.7%)       88.23     (11.7%)   -5.6% ( -27% -   23%) 0.168
      CFQHighMed        4.69     (10.7%)        5.00     (18.0%)    6.6% ( -20% -   39%) 0.160
     CFQHighHigh        4.51     (10.6%)        5.17     (17.7%)   14.6% ( -12% -   48%) 0.002
      CFQHighLow       14.13      (8.5%)       23.11     (32.3%)   63.5% (  20% -  114%) 0.000

Run 2:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
      CFQHighMed        4.77      (4.5%)        4.10      (8.3%)  -14.2% ( -25% -   -1%) 0.000
        PKLookup       98.99     (12.3%)      101.47     (12.5%)    2.5% ( -19% -   31%) 0.522
     CFQHighHigh        4.88      (5.3%)        5.98     (11.5%)   22.6% (   5% -   41%) 0.000
      CFQHighLow       11.57      (5.6%)       18.86     (18.8%)   62.9% (  36% -   92%) 0.000

Run 3:
            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
     CFQHighHigh        3.55      (5.1%)        2.38      (9.0%)  -32.9% ( -44% -  -19%) 0.000
        PKLookup      101.29      (7.0%)       94.22     (15.4%)   -7.0% ( -27% -   16%) 0.065
      CFQHighLow       15.43      (5.8%)       16.60     (11.2%)    7.6% (  -8% -   26%) 0.007
      CFQHighMed        3.12      (5.1%)        3.83     (15.0%)   22.7% (   2% -   45%) 0.000

For one of the most negatively impacted query (-42.0%): CFQHighHigh: at united +combinedFields=titleTokenized^4.0,body^2.0 # freq=2834104 freq=1185528, the JFR CPU profiling result looks like the following
PERCENT       CPU SAMPLES   STACK
15.82%        13099         org.apache.lucene.sandbox.search.CombinedFieldQuery$1$1#doMergeImpactsPerField()
11.46%        9487          org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer$MultiFieldNormValues#advanceExact()
4.69%         3883          org.apache.lucene.search.DisiPriorityQueue#downHeap()
3.66%         3027          org.apache.lucene.search.similarities.BM25Similarity$BM25Scorer#score()
1.93%         1598          org.apache.lucene.search.DisjunctionDISIApproximation#advance()
1.92%         1590          org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#freq()
1.92%         1588          org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1#collect()
1.77%         1467          org.apache.lucene.sandbox.search.CombinedFieldQuery$WeightedDisiWrapper#freq()
1.68%         1392          org.apache.lucene.search.DisiPriorityQueue#top()
1.60%         1326          org.apache.lucene.search.DisiPriorityQueue#topList()
1.54%         1276          org.apache.lucene.util.PriorityQueue#downHeap()
1.50%         1243          java.lang.Math#round()
1.45%         1201          org.apache.lucene.codecs.lucene90.Lucene90NormsProducer$3#longValue()
1.38%         1145          java.util.HashMap#resize()
1.35%         1115          org.apache.lucene.store.ByteBufferGuard#ensureValid()
1.33%         1100          org.apache.lucene.sandbox.search.CombinedFieldQuery$1$1#mergeImpactsPerField()
1.21%         1001          java.util.HashMap$HashIterator#nextNode()
1.17%         972           java.util.LinkedList#linkLast()
1.13%         934           org.apache.lucene.codecs.lucene90.Lucene90PostingsReader#findFirstGreater()
1.07%         883           org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#score()
1.06%         878           org.apache.lucene.store.ByteBufferGuard#getByte()
1.02%         841           org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer#getNormValue()

suggesting quite some CPU time is spent on merging impacts within the same field. I'm suspecting this may occur when the max score is being computed too frequently, as frequent term's skip list would be "dense" and is also used to determine upTo for max score:
https://github.com/apache/lucene/blob/2a9adb81df314ffeb92951bbf2d99fecc94fa581/lucene/core/src/java/org/apache/lucene/search/ImpactsDISI.java#L78-L82

Hi @jpountz @jimczi, when I was doing some more deep dive to see how this PR can be improved further, I noticed a difference of field-weight parameter passed to createMultiNormsLeafSimScorer in CombinedFieldQuery:
CombinedFieldQuery#scorer:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L420-L421
CombinedFieldQuery#explain:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L387-L389
For the CombinedFieldQuery#scorer one, fields may contain duplicated fields:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L404-L414
, whereas fieldAndWeights.values() should not contain duplicated fields.
I feel CombinedFieldQuery#scorer should be updated to use fieldAndWeights.values() as well? What do you think?

Hi @jpountz @jimczi, when I was doing some more deep dive to see how this PR can be improved further, I noticed a difference of field-weight parameter passed to createMultiNormsLeafSimScorer in CombinedFieldQuery:
CombinedFieldQuery#scorer:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L420-L421
CombinedFieldQuery#explain:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L387-L389
For the CombinedFieldQuery#scorer one, fields may contain duplicated fields:
https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L404-L414
, whereas fieldAndWeights.values() should not contain duplicated fields.
I feel CombinedFieldQuery#scorer should be updated to use fieldAndWeights.values() as well? What do you think?

For now I have created a spin-off issue https://issues.apache.org/jira/browse/LUCENE-10236 and a separate PR https://github.com/apache/lucene/pull/444 for this. Please let me know if they look good to you.

Thanks for making progress on this and sorry for the slow review cycles.

No worry and thanks for the review and feedback!

I just had a quick look and it seems that some computations can be move up-front such as deciding what field we use as a lead since field weights do not change during query execution?

Yup I can move it out to avoid repeated computation there. Just a quick check though, from the perf results so far (https://github.com/apache/lucene/pull/418#discussion_r754091056 & https://github.com/apache/lucene/pull/418#discussion_r759006970), it seems using the most weighted field to decide on the leading impacts may not yield the best result, as matches in most weighted field may also give a high docId upTo bound. If we were to drop that approach and revert the commit https://github.com/apache/lucene/pull/418/commits/db2446f0337e5860bb8c731df1f6c16281efb6bb that introduced it, then it won't be computing most weighted field at all. Are you trying to see if perf tests can be further improved if most weighted field only gets computed once?

I wonder if there's things we can do to make the code simpler, such as sharing the logic to combine multiple terms together within the same field with SynonymQuery.

Yeah I have the same thought there. I wasn't sure earlier as SynonymQuery and CombinedFieldsQuery sit in different modules / packages, so extracting common code out may potentially require a new public specialized API / class (in the core module ?). Let me give that a try and see how it looks!

from the perf results so far, it seems using the most weighted field to decide on the leading impacts may not yield the best result
Are you trying to see if perf tests can be further improved if most weighted field only gets computed once?

Yes. I liked this approach because it felt like it should work relatively well since the field with the highest weight should drive scores anyway, and deciding about which clause leads impacts up-front felt like it could simplify the logic a bit. But if it doesn't yield better results, let's fall back to the previous approach. Let's maybe just double check with a profiler that the reason why this approach performs worse is actually because we get worse score boundaries and not because of some avoidable slow code like iterating or lookip up the various hash maps?

wasn't sure earlier as SynonymQuery and CombinedFieldsQuery sit in different modules / packages, so extracting common code out may potentially require a new public specialized API / class (in the core module ?). Let me give that a try and see how it looks!

Maybe we could have a SynonymImpactsSource or something like that as a public @lucene.internal class in core that would provide this logic.

Maybe we could have a SynonymImpactsSource or something like that as a public @lucene.internal class in core that would provide this logic.

Ah yes using @lucene.internal makes sense! I have made a new class to extract out the impacts merging within same field logic in https://github.com/apache/lucene/pull/418/commits/0a9bdccf01d568b0239cf894ff626e47d8333df3, and use that in CombinedFieldsQuery https://github.com/apache/lucene/pull/418/commits/808fec28ab6d7179974665e7fa069270845811fa. I've also moved up the  repeated max weight field computation in https://github.com/apache/lucene/pull/418/commits/8a7ea9998b189649ccdc75ecdd4b096460abb0af .

Yes. I liked this approach because it felt like it should work relatively well since the field with the highest weight should drive scores anyway, and deciding about which clause leads impacts up-front felt like it could simplify the logic a bit. But if it doesn't yield better results, let's fall back to the previous approach. Let's maybe just double check with a profiler that the reason why this approach performs worse is actually because we get worse score boundaries and not because of some avoidable slow code like iterating or lookip up the various hash maps?

I see. The latest two commits https://github.com/apache/lucene/pull/418/commits/808fec28ab6d7179974665e7fa069270845811fa & https://github.com/apache/lucene/pull/418/commits/75c5b046f8af4e73341a26a1828e97e006115a6b used max weight field to drive scoring, and overall they had around -20% impacts to tasks from combinedFieldsUnevenlyWeightedBig so far. A sample CPU JFR results between candidate and baseline look like the following:
Candidate CPU JFR:
PERCENT       CPU SAMPLES   STACK
15.13%        13191         org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer$MultiFieldNormValues#advanceExact()
7.42%         6466          org.apache.lucene.search.similarities.BM25Similarity$BM25Scorer#score()
7.29%         6354          org.apache.lucene.search.DisjunctionDISIApproximation#advance()
6.79%         5921          org.apache.lucene.search.DisiPriorityQueue#downHeap()
4.34%         3785          org.apache.lucene.search.DisiPriorityQueue#topList()
3.97%         3465          org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1#collect()
3.85%         3360          org.apache.lucene.sandbox.search.CombinedFieldQuery$WeightedDisiWrapper#freq()
3.18%         2777          java.lang.Math#round()
3.01%         2624          org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#freq()
3.01%         2624          org.apache.lucene.search.DisiPriorityQueue#top()
2.33%         2036          org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#score()
2.20%         1917          org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer#getNormValue()
2.07%         1809          org.apache.lucene.util.SmallFloat#longToInt4()
1.81%         1580          org.apache.lucene.codecs.lucene90.Lucene90NormsProducer$3#longValue()
1.78%         1555          org.apache.lucene.codecs.lucene90.Lucene90PostingsReader$BlockImpactsDocsEnum#advance()
1.77%         1545          org.apache.lucene.store.ByteBufferGuard#ensureValid()
1.51%         1316          org.apache.lucene.codecs.lucene90.Lucene90PostingsReader#findFirstGreater()
1.39%         1210          org.apache.lucene.search.DisiPriorityQueue#updateTop()
1.29%         1124          org.apache.lucene.search.ImpactsDISI#docID()
1.22%         1063          jdk.internal.misc.Unsafe#getByte()
1.19%         1037          org.apache.lucene.store.ByteBufferGuard#getByte()
1.08%         938           org.apache.lucene.search.DisiPriorityQueue#prepend()
0.97%         849           org.apache.lucene.search.Weight$DefaultBulkScorer#scoreAll()
0.86%         750           org.apache.lucene.codecs.MultiLevelSkipListReader#skipTo()
0.82%         717           org.apache.lucene.util.SmallFloat#intToByte4()
0.78%         683           java.lang.Math#toIntExact()
0.62%         540           org.apache.lucene.codecs.lucene90.PForUtil#decode()
0.61%         529           org.apache.lucene.codecs.lucene90.Lucene90PostingsReader$BlockImpactsDocsEnum#freq()
0.51%         441           org.apache.lucene.search.ImpactsDISI#nextDoc()
0.50%         435           org.apache.lucene.search.ImpactsDISI#advanceTarget()

Baseline CPU JFR
PERCENT       CPU SAMPLES   STACK
16.38%        13363         org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer$MultiFieldNormValues#advanceExact()
8.67%         7073          org.apache.lucene.search.similarities.BM25Similarity$BM25Scorer#score()
8.05%         6569          org.apache.lucene.search.DisjunctionDISIApproximation#nextDoc()
6.50%         5305          org.apache.lucene.search.DisiPriorityQueue#downHeap()
5.17%         4220          org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#freq()
4.40%         3587          org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1#collect()
4.30%         3505          org.apache.lucene.search.DisiPriorityQueue#topList()
3.37%         2751          java.lang.Math#round()
2.77%         2263          org.apache.lucene.search.DisiPriorityQueue#top()
2.64%         2156          org.apache.lucene.sandbox.search.CombinedFieldQuery$WeightedDisiWrapper#freq()
2.62%         2135          org.apache.lucene.sandbox.search.CombinedFieldQuery$CombinedFieldScorer#score()
2.12%         1729          org.apache.lucene.sandbox.search.MultiNormsLeafSimScorer#getNormValue()
2.11%         1723          org.apache.lucene.util.SmallFloat#longToInt4()
2.06%         1678          org.apache.lucene.search.Weight$DefaultBulkScorer#scoreAll()
2.01%         1640          org.apache.lucene.store.ByteBufferGuard#ensureValid()
1.77%         1442          org.apache.lucene.codecs.lucene90.Lucene90NormsProducer$3#longValue()
1.62%         1325          org.apache.lucene.search.DisiPriorityQueue#updateTop()
1.26%         1028          org.apache.lucene.codecs.lucene90.Lucene90PostingsReader$BlockDocsEnum#nextDoc()
1.10%         899           java.lang.Math#toIntExact()
1.10%         898           org.apache.lucene.util.SmallFloat#intToByte4()
1.09%         888           org.apache.lucene.codecs.lucene90.Lucene90PostingsReader$BlockDocsEnum#freq()
1.06%         864           org.apache.lucene.store.ByteBufferGuard#getByte()
0.80%         652           jdk.internal.misc.Unsafe#getByte()
0.74%         605           org.apache.lucene.codecs.lucene90.PForUtil#decode()
0.68%         552           org.apache.lucene.search.DisiPriorityQueue#prepend()
0.60%         492           org.apache.lucene.codecs.lucene90.PForUtil#decodeAndPrefixSum()
0.55%         451           java.io.RandomAccessFile#readBytes()
0.38%         314           org.apache.lucene.codecs.lucene90.PForUtil#innerPrefixSum32()
0.38%         307           org.apache.lucene.codecs.lucene90.ForUtil#expand8()
0.32%         260           org.apache.lucene.codecs.lucene90.PForUtil#expand32()

As they look very similar, based on my previous debugging, it may suggest the max score being computed is high and most of the docs are not being skipped, hence the candidate implementation ended up examining the same amount of docs with baseline.

 Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)
Regarding the new utility class, I was hoping that it could be a higher-level abstraction, eg. a SynonymImpactsSource, rather than low-level utility methods?

These numbers are super interesting. Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)

No problem! It's actually quite enjoyable for me to explore different approaches and compare their performance characteristics. I may also miss certain aspects as well, so this discussion helps to verify my understanding also! I've re-implemented the other approach in https://github.com/apache/lucene/pull/418/commits/cbbd28bb2964228542e72b112f3b2f5f3164fae7.

Regarding the new utility class, I was hoping that it could be a higher-level abstraction, eg. a SynonymImpactsSource, rather than low-level utility methods?

Yeah I did give that a try earlier, but I ended up with the utility methods approach as I saw some potential issue. I implemented it again in https://github.com/apache/lucene/pull/418/commits/502d44e7ff0b6de6061a4899589e4523e9bf74e8.
If my understanding was correct, the intention of using higher-level abstraction there was to reduce code duplication by using a loop over Map<Field, SynonymImpactsSource> or even  Map<Field, SynonymImpacts> in the numLevels, getDocIdUpTo and (in particular) getImpacts implementations in CombinedFieldsQuery?  However, I noticed that for getImpacts, it doesn't seems to be easily decomposable / delegate-able to getImpacts of  SynonymImpactsSource or SynonymImpacts. As that method takes in a level and internally looks up a docIdUpTo of the field to get a list of impacts with that boundary, for CombinedFieldsQuery we actually need a docIdUpTo that would be valid across all fields, hence it couldn't be abstracted away in the loop https://github.com/apache/lucene/pull/418/commits/502d44e7ff0b6de6061a4899589e4523e9bf74e8#diff-62e151fca32e7560ef90ee8eab1adaffac3073f23701aaf0c17a02e250727ed3R547-R550 . Given this restriction, I feel using utility methods may work better in removing duplication in code?

These numbers are super interesting. Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)

No problem! It's actually quite enjoyable for me to explore different approaches and compare their performance characteristics. I may also miss certain aspects as well, so this discussion helps to verify my understanding also! I've re-implemented the other approach in cbbd28b.

Regarding the new utility class, I was hoping that it could be a higher-level abstraction, eg. a SynonymImpactsSource, rather than low-level utility methods?

Yeah I did give that a try earlier, but I ended up with the utility methods approach as I saw some potential issue. I implemented it again in 502d44e.
If my understanding was correct, the intention of using higher-level abstraction there was to reduce code duplication by using a loop over Map<Field, SynonymImpactsSource> or even Map<Field, SynonymImpacts> in the numLevels, getDocIdUpTo and (in particular) getImpacts implementations in CombinedFieldsQuery? However, I noticed that for getImpacts, it doesn't seems to be easily decomposable / delegate-able to getImpacts of SynonymImpactsSource or SynonymImpacts. As that method takes in a level and internally looks up a docIdUpTo of the field to get a list of impacts with that boundary, for CombinedFieldsQuery we actually need a docIdUpTo that would be valid across all fields, hence it couldn't be abstracted away in the loop 502d44e#diff-62e151fca32e7560ef90ee8eab1adaffac3073f23701aaf0c17a02e250727ed3R547-R550 . Given this restriction, I feel using utility methods may work better in removing duplication in code?

Hi @jpountz , just want to circle back to this discussion and see if you may have further suggestions to the above analysis?

Hi @jpountz , just want to check again to see if I have addressed your concern with the utility approach?
To better illustrate the potential issue I'm considering with the higher level abstraction approach, I've copied over some key code snippets here:
If we were to extract out SynonymImpactsSource (from SynonymQuery), it may look something like this:
public class SynonymImpactsSource implements ImpactsSource {

  private final ImpactsEnum[] impactsEnums;
  private final Impacts[] impacts;
  private final float[] boosts;
  private Impacts lead;

  public SynonymImpactsSource(ImpactsEnum[] impactsEnums, float[] boosts) {
    ...
  }

  @Override
  public Impacts getImpacts() throws IOException {
    // Use the impacts that have the lower next boundary as a lead.
    // It will decide on the number of levels and the block boundaries.
    if (lead == null) {
      Impacts tmpLead = null;
      for (int i = 0; i < impactsEnums.length; ++i) {
        impacts[i] = impactsEnums[i].getImpacts();
        if (tmpLead == null || impacts[i].getDocIdUpTo(0) < tmpLead.getDocIdUpTo(0)) {
          tmpLead = impacts[i];
        }
      }
      lead = tmpLead;
    }
    return new Impacts() {

      @Override
      public int numLevels() {
        // Delegate to the lead
        return lead.numLevels();
      }

      @Override
      public int getDocIdUpTo(int level) {
        // Delegate to the lead
        return lead.getDocIdUpTo(level);
      }

      @Override
      public List<Impact> getImpacts(int level) {
        final int docIdUpTo = getDocIdUpTo(level);
        return ImpactsMergingUtils.mergeImpactsPerField(
            impactsEnums, impacts, boosts, docIdUpTo, false);
      }
    };
  }

  @Override
  public void advanceShallow(int target) throws IOException {
    for (ImpactsEnum impactsEnum : impactsEnums) {
      if (impactsEnum.docID() < target) {
        impactsEnum.advanceShallow(target);
      }
    }
  }

  public Impacts[] impacts() {
    return impacts;
  }
}

However, the above SynonymImpactsSource#getImpacts(level) may not be directly usable for CombinedFieldsQuery, as illustrated below
Impacts CombinedFieldsQuery$ImpactsSource#getImpacts {
   for (entry : Map<Field, SynonymImpactsSource>) {
        // this is potentially problematic, as this methods only takes in level info, and it internally looks up a field-specific docIdUpTo to get valid impacts (see definition above). However, for CombinedFieldQuery, docIdUpTo may be different among different fields with same level
        combine SynonymImpactsSource.getImpacts(level)
   }
  return combined Impacts
}

Hence we may actually need to change some APIs if we were to make SynonymImpactsSource to work in CombinedFieldQuery use case ?


"AttributeError: 'NoneType' object has no attribute 'get'" in LambdaClient.captureMessage()

'NoneType' object has no attribute 'get'
I added LambdaClient to my AWS Lambda functions. Using the latest version of sentry installed using pip I get AttributeError: 'NoneType' object has no attribute 'get' when calling client.captureMessage().
This happens inside my Lambdas on AWS as well as on my local computer.
Steps to reproduce
$ pip install raven
$ python3.6
>>> from raven.contrib.awslambda import LambdaClient
>>> client = LambdaClient('https://********')
>>> client.captureMessage('My event just happened!')
Error in sys.excepthook:
Traceback (most recent call last):
  File "/****/raven/base.py", line 274, in handle_exception
    self.captureException(exc_info=exc_info, level='fatal')
  File "/****/raven/base.py", line 814, in captureException
    'raven.events.Exception', exc_info=exc_info, **kwargs)
  File "/****/raven/contrib/awslambda/__init__.py", line 67, in capture
    user_info = self._get_user_interface(event)
  File "/****/raven/contrib/awslambda/__init__.py", line 128, in _get_user_interface
    if event.get('requestContext'):
AttributeError: 'NoneType' object has no attribute 'get'

Original exception was:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/****/raven/base.py", line 792, in captureMessage
    return self.capture('raven.events.Message', message=message, **kwargs)
  File "/****/raven/contrib/awslambda/__init__.py", line 67, in capture
    user_info = self._get_user_interface(event)
  File "/****/raven/contrib/awslambda/__init__.py", line 128, in _get_user_interface
    if event.get('requestContext'):
AttributeError: 'NoneType' object has no attribute 'get'

Just noticed that I get a similar Exception when using client.captureException().

There is a fix in the works.


a bug when the bot enter ina tt5Srv in ubuntu:

hy guys. how are you? well, i'm trying to use this bot and i can't. i follow the instructions as here in gitup, but i can't get the correct funcion of the bot. how can i do it?
INFO [2022-04-08 01:28:40,566]: Started in MainThread file: init.py line 89 function run
INFO [2022-04-08 01:28:55,621]: New message h from sanagui in MainThread file: init.py line 94 function run
ERROR [2022-04-08 01:28:55,623]:  in Thread-4 file: init.py line 110 function _run
Traceback (most recent call last):
File "/home/music/TTMediaBot/bot/commands/init.py", line 95, in _run
self.ttclient.send_message(
File "/home/music/TTMediaBot/bot/TeamTalk/init.py", line 156, in send_message
message = TeamTalkPy.TextMessage()
File "/home/music/TTMediaBot/TeamTalkPy/TeamTalk5.py", line 727, in init
assert(DBG_SIZEOF(TTType.TEXTMESSAGE) == ctypes.sizeof(TextMessage))
AssertionError

Hey there. Are you using the latest TeamTalkSDK? If yes, you need to
downgrade to version 5.8.1 (at least). You can find the TeamTalkSDK from
the below link. Download the version 5.8B. Thanks.
https://bearware.dk/teamtalksdk
On Fri, Apr 8, 2022, 7:39 AM sanagui-dj @.***> wrote:

hy guys. how are you? well, i'm trying to use this bot and i can't. i
follow the instructions as here in gitup, but i can't get the correct
funcion of the bot. how can i do it?
INFO [2022-04-08 01:28:40,566]: Started in MainThread file: init.py
line 89 function run
INFO [2022-04-08 01:28:55,621]: New message h from sanagui in MainThread
file: init.py line 94 function run
ERROR [2022-04-08 01:28:55,623]: in Thread-4 file: init.py line 110
function _run
Traceback (most recent call last):
File "/home/music/TTMediaBot/bot/commands/init.py", line 95, in _run
self.ttclient.send_message(
File "/home/music/TTMediaBot/bot/TeamTalk/init.py", line 156, in
send_message
message = TeamTalkPy.TextMessage()
File "/home/music/TTMediaBot/TeamTalkPy/TeamTalk5.py", line 727, in init
assert(DBG_SIZEOF(TTType.TEXTMESSAGE) == ctypes.sizeof(TextMessage))
AssertionError
—
Reply to this email directly, view it on GitHub
https://github.com/gumerov-amir/TTMediaBot/issues/66, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM64WYUTJEOQH3FRG3HIODLVD5W37ANCNFSM5S24X4XQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@sanagui-dj Hello.
Are you still experiencing this problem? As @lbk2907 noticed, you should use TeamTalk sdk version 5.8.
If you use TeamTalk sdk 5.8 and latest version of TTMediaBot and issue still persists please reopen this issue or create new one with complete logs and exact versions of all components you use.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/213 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 22fb32f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-11-14-06-58-28 has been deleted or has been force pushed: fatal: couldn't find remote ref Archive_master_2019-11-14-06-58-28

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Translate Goal-setting dialog from Beyza

[ ] Translate the dialog itself
[ ] Translate the testimonials included in the goal-setting dialog

https://github.com/PerfectFit-project/goal_setting_virtual_coach/blob/main/experiment_data/goals.csv

Goal-setting dialog:

Which testimonial is shown is determined by the algorithm from Nele - so this should be implemented in the dialog
Although the step goal per day is system-initiated, we still want the user to think about the higher-order goal / motivation to become more physically active / increase steps. This part of the dialog from Beyza needs to be integrated in the Goal-setting dialog.
The only time that users will be asked to reflect on the higher-order goal, will be during the closing dialog - integrate this in the dialog


Sensor CMakeFile and Kconfig cleanup

Clean and sort the include/source list, use the allow empty lib cmake thing. Saves trying to figure where to add new stuff.
Note: I don't have the slightest hope that this is enough to keep them consistent over time (the other lists I sorted are already off), so I think I'll followup with a precompliance validate that the block stays sorted (https://github.com/zephyrproject-rtos/zephyr/pull/58149).

Ok it should be good now, the merge conflict markers were a bit odd not sure why, had to redo it from scratch.

rebase

Rebased, will get there eventually :-)

Re-re-rebased. Adding sensors is a popular activity these days.

Re-re-rebased. Adding sensors is a popular activity these days.

Probably one of the most active areas with first time and one time contributors


Nethack 4 breaking tap

Trying to tap the repo returns this:
Cloning into '/usr/local/Library/Taps/homebrew/homebrew-games'...
remote: Counting objects: 169, done.
remote: Compressing objects: 100% (168/168), done.
remote: Total 169 (delta 1), reused 38 (delta 0), pack-reused 0
Receiving objects: 100% (169/169), 131.54 KiB | 0 bytes/s, done.
Resolving deltas: 100% (1/1), done.
Checking connectivity... done.
Error: Invalid formula: /usr/local/Library/Taps/homebrew/homebrew-games/nethack4.rb
undefined method `rebuild' for #BottleSpecification:0x007fa8f3aea3f0
Error: Cannot tap homebrew/games: invalid syntax in tap!

It means you need to brew update
If you already did, then you were a victim of https://twitter.com/MacHomebrew/status/763686348041641984 and need to follow those directions.


Upgrade terraform provider terraform provider artifactory to v8.1.0

Major version upgrade.
Fixes https://github.com/pulumi/pulumi-artifactory/issues/352.
Note that we did not upgrade to v8 of the upstream provider due to a resource replacement bug: https://github.com/pulumi/pulumi-artifactory/issues/345

Closing this due to too many dirty schemas.


Fix #101 - update SpacyLanguage class to support spaCy v2.3+ models

As the title says. However, there are two additional points:

Instead of loading all the vocab when instantiating the class (i.e. in __init__ method), I decided to implement a separate method for this in order to comply with the  original goal of spaCy maintainers which is reducing the loading time of the model (in this library, this point is useful when the user only want to get embeddings from the model, and not doing something like similarity search). Although, in this implementation, this reduction may come at the annoyance of calling self._load_vocab method every time we want to iterate over vocab in the code (which currently happens only once).

I have not included a spaCy model (e.g. en_core_web_md) in the tests yet, until it's decided how to go about this; however, I tested the class manually after modifications and it's working properly.

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

Grand. I might push this to pypi today together with some documentation updates.


Bug: Remove Scroll bar visibility

Problem
is Unacceptable that the scroll bar is visible inside the app. we are not building a website, this is an app and we should be able to control what appears and what not.

You mean the scrollbar in the sidebar?

FWIW, Apple Notes app has a sidebar in the list of notes. So I wouldn't say it's unacceptable to have a scroll bar in an app.

FWIW, Apple Notes app has a sidebar in the list of notes. So I wouldn't say it's unacceptable to have a scroll bar in an app.

@burdiyan Apple Notes does show you the scrollbar when necessary. not all the time. this is the behavior we should copy. not showing the scrollbar all the time.
https://github.com/MintterHypermedia/mintter/assets/725120/99339044-588a-490b-9705-3aae07fb41b2


joe contract does not work.

Issue Summary:
The problem lies in the deployment script for the Joe core contracts. The script fails because it attempts to access a contract named "JoeToken" that appears not to have been deployed. The error emerges during the execution of the deployMasterChefJoeV2.js script.
Possible Causes and Objectives:

Non-deployment of "JoeToken" Contract: The "JoeToken" contract may not have been deployed, or the script is not referencing the correct deployment.
Incorrect Deployment Script: There might be a logical bug within the deployment script resulting in an attempt to grab a contract that hasn't been deployed.

Strongest Solutions:

Deploy the "JoeToken" Contract: Ensure that the "JoeToken" contract is correctly deployed before any scripts that depend on it are run.
Ensure Correct Contract Reference: Double-check references within the script to ensure they point to the correct contracts.

Ethical Hacker Expert Simulation:
Simulation Criteria:

Immediate Effectiveness
Ease of Implementation
Long-Term Reliability
User Experience Impact

Overall Simulation Ratings (Hypothetical):

Deploy the "JoeToken" Contract:

Success Rate: 98%
Star Rating: ⭐⭐⭐⭐⭐

Ensure Correct Contract Reference:

Success Rate: 93%
Star Rating: ⭐⭐⭐⭐

Solution Implementation:
1. Deploy the "JoeToken" Contract:

Steps:

Check Deployment Script:

Open the previously executed deployment scripts in chronological order.
Ensure that there is a dedicated script to deploy the "JoeToken" contract.

Manually Deploy JoeToken:async function deployJoeToken() {
  const JoeToken = await ethers.getContractFactory("JoeToken");
  const joeToken = await JoeToken.deploy();

  await joeToken.deployed();

  console.log("JoeToken deployed to:", joeToken.address);
}
deployJoeToken()
  .then(() => process.exit(0))
  .catch(error => {
    console.error(error);
    process.exit(1);
  });

- **Validate:**
   - Verify that the "JoeToken" contract address is now being logged and that the deployment is successful.
   - Re-run the problematic script to confirm the issue is resolved.

Simulation Rating:

Success Rate: 98%
Star Rating: ⭐⭐⭐⭐⭐

2. Ensure Correct Contract Reference:

Steps:

Inspect Deployment Script:

Open deployMasterChefJoeV2.js.
Verify that the contract name "JoeToken" is correctly referenced.

Update Script if Necessary:const { deployments, getNamedAccounts } = require("hardhat");
const { deploy } = deployments;

async function main() {
  const { deployer } = await getNamedAccounts();

  // Ensure JoeToken is deployed before referencing it
  if (!await deployments.getOrNull("JoeToken")) {
    await deploy('JoeToken', {
      from: deployer,
      log: true,
    });
  }

  const joeToken = await ethers.getContract("JoeToken");

  // Proceed with other deployments that depend on JoeToken
}

module.exports = main;

Validate:

Re-test the script to ensure the "JoeToken" contract is properly deployed and referenced.

Simulation Rating:

Success Rate: 93%
Star Rating: ⭐⭐⭐⭐

Conclusion and Steps:
The issue arises due to the missing deployment of the "JoeToken" contract. The strongest solution is to ensure that "JoeToken" is deployed before executing any dependent scripts. This solution is expected to have a success rate of 98% with a five-star rating.

Check Deployment Scripts:

Verify the existing deployment scripts to ensure "JoeToken" is included.

Deploy JoeToken if Missing:

Add a deployment script if necessary.
Manually deploy "JoeToken" to confirm successful setup.

Validate and Test:

Run the script to ensure the "JoeToken" contract is deployed appropriately.
Execute the deployMasterChefJoeV2.js script again to confirm that the issue is resolved.

By following these steps, you can ensure the successful deployment of the "JoeToken" contract, thereby resolving the script error and allowing for seamless contract deployments within the joe-core project.


Auto-rename uploaded talk, publication filenames

I just noticed that we don't automatically rename talk filenames on upload. Oops. We should do this (and check to make sure we do it for pubs too).
For talks, the format should be AuthorLastName_TalkTitle_Year.pdf

To be sure, multiple speakers would = SpeakerLastName1_SpeakerLastName2_SpeakerLastNameN_TalkTitle_Year.pdf

No, just do SpeakerLastName1_TalkTitle_Year.pdf

PR Merged, closing issue.

Auto-renaming files has a problem. We should have this exactly:
AuthorLastName_TalkTitle_Year.pdf where TalkTitle is camel case and no underscores between words.


Feature Request: Exclude/whitelist path in block

It would be great for quirky things (like WordPress) to be able to exclude/whitelist some path(s) in an ipfilter allow stanza, like so:
ipfilter /wp-admin {
  if {path} not /wp-admin/admin-ajax.php
  allow
  ip ::1
  strict
}

This example follows the syntax used by rewrite, minify, etc., but it could take other forms; possibly something like:
ipfilter {
  regex /wp-admin(?!/admin-ajax\.php).*
  allow
  ip ::1
  strict
}

you can use as many ipfilter blocks as you please, I think what you are trying to do with your first example is
ipfilter /wp-admin/admin-ajax.php {
    rule block
    ip ::/0
    strict
}

I'm not sure how useful regex in paths would be, they will be fairly easy to add though, I prefer the following:
ipfilter /wp-admin(?!/admin-ajax\.php).* {
    rule allow
    ip ::1
    strict
}

happy to get a PR ;)

Ah, no, what I'm trying to do with the first one is the same as what I'm trying to do with the second one: don't apply the ipfilter if the path is /wp-admin/admin-ajax.php, but apply the ipfilter to everything else under /wp-admin.
What you say is interesting. I didn't realize that overlapping paths would be processed the way I want them to: with more specific paths matching first and taking precedence over more general paths. This combination of ipfilters actually works great for this use-case:
ipfilter /wp-admin {
    rule allow
    ip 1:2:3:4::/56
    strict
}

ipfilter /wp-admin/admin-ajax.php {
    rule block
    strict
}

Does that all make sense?

Yup, multiple paths work as you described.

Beautiful. Thank you for the help, and for a great Caddy feature!


Add ConfirmPreviousInputStep

For validating your previous input (e.g. if you need to revalidate a password during account creation)

Bad merge broke the build, should be easy fix. It can't find the file since it was renamed.

Thanks for catching that!  Import sorting + the following merge conflict was not fun to look at 😅


Add composite provider to support multiple network providers

Ⅰ. Describe what this PR does
Currently, only a single trafficRouting network provider is supported even multiple ones are defined.
To accomplish this, a composite provider is needed. A composite provider is just an array of NetworkProvider.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@lujiajing1126 There is no problem with the code logic and implementation. We didn't implement it before mainly because we didn't think through the scenarios, so would it be convenient for you to participate in a community meeting? Time: 7.11. Alternatively, you can join the dingding group and we'll talk further!

@lujiajing1126 There is no problem with the code logic and implementation. We didn't implement it before mainly because we didn't think through the scenarios, so would it be convenient for you to participate in a community meeting? Time: 7.11. Alternatively, you can join the dingding group and we'll talk further!

Yes, sure. I've already in the Dingtalk group and will attend the community meeting on 11, Jul.

Test cases have been moved to v1beta1 file and a workflow has been added. @myname4423

/lgtm


[stable/kuberos] fix typo

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test
/assign


ci: understand timeout test flakes

I have an open issue running with Travis to investigate. Will report updates here.
Flakes always appear to be related to content we end up fetching from GitHub's CDN:
ok  	github.com/myitcv/govim	21.699s
--- FAIL: TestInstallScripts (316.44s)
    --- FAIL: TestInstallScripts/scripts (0.00s)
        --- FAIL: TestInstallScripts/scripts/install_pathogen (300.29s)
            testscript.go:290:
                # Test the Pathogen install approach (300.265s)
                > [!net] skip
                > env HOME=$WORK/home
                > env GOPATH=$CURRENT_GOPATH
                > exec git clone -q $PLUGIN_PATH $HOME/.vim/bundle/govim
                [stderr]
                Note: checking out 'c72fe631bf545ad16e36132ed00b047f7ed08d4f'.

                You are in 'detached HEAD' state. You can look around, make experimental
                changes and commit them, and you can discard any commits you make in this
                state without impacting any branches by performing another checkout.

                If you want to create a new branch to retain commits you create, you may
                do so (now or later) by using -b with the checkout command again. Example:

                  git checkout -b <new-branch-name>

                > mkdir $HOME/.vim/autoload
                > mkdir $HOME/.vim/bundle
                > exec curl -LSso $HOME/.vim/autoload/pathogen.vim https://raw.githubusercontent.com/tpope/vim-pathogen/master/autoload/pathogen.vim
                [stderr]
                curl: (28) Operation timed out after 300180 milliseconds with 0 out of 0 bytes received
                [exit status 28]
                FAIL: testdatainstall/install_pathogen.txt:12: unexpected command failure

curl exit status 28 is a timeout:
https://curl.haxx.se/libcurl/c/libcurl-errors.html

Have merged #215 as a means of collecting more details here. @milesbxf - if you see any further flakes, please can you copy-paste the raw build log into a gist and link from here?

Sorry, commented in wrong issue.

Now an official incident:
https://www.traviscistatus.com/incidents/kyf149kl6bvp


Focus target Overlay comes up when no focus target is selected

When selecting a target, the focus target overlay comes on screen without a focus target chosen.  The focus target overlay does not disappear when target is no longer selected.

This is not an issue with this plugin.
Refer to https://github.com/ravahn/FFXIV_ACT_Plugin/issues/51

You are correct, got confused as to what plugin i was looking at


US date format

add mmddyyyy option for date conversion, with specs and doc

Hey, hi! Thanks again for your contribution!
Just a few comments on this PR:
I personally don't like the name of the parameter (mmddyyyy).
Maybe there is another way to handle your specific need without adding a very specific parameter.
I think that maybe the best way would be to have some optional global configuration, which you could put in a Rails initializer where you could define the default parsing format.
Something like:

RailsParam::Config.options do |config|
   config.default_date_parsing '%m/%d/%Y'
end

Then all the dates would be parsed using this option.
And you could override this parameter by using an option like :

  param! :date_of_birth, Date, format: '%Y'

Great suggestion.  I'll look into implementing that when I get a chance.


Random clipped part appearing on editor

Issue Type: Bug
VS Code Version: 1.28.2
OS: Windows 10 - OS Build - 15063
A random clipped part of the navigation frame appears on the editor. If I click on that it blinks and eventually goes away.

/duplicate #59682


Fix typo in templates docs

This fixes a minor typo in the parameters to ngettext in the templates docs.
I left out changes.rst from this as it's just a single word, and I don't think it necessarily justifies a changelog entry

duplicate of #1881


Determine the return type to use for ResultSet::stats()

The skeleton for ResultSet::stats() returns the proto ResultSetStats type.  Determine if this is sufficient, or if we should provide other types to return here.

Some notes:

There are three main things (currently) returned: the query plan, the statistics, and a row count (which can be approximate or exact based on the query).
QueryPlan in particular may benefit from a friendlier type.
it's unclear if the structure of query_stats is fixed enough to use a C++ struct, or if has to be a key/type/value like Struct.
row counts are pretty simple.

Is there anything in the stats that we think we really need in Alpha? Or is this mostly a post-alpha (likely "beta") issue?

could probably be beta?

Note this also applies to the return value of Client::ExecuteBatchDml()

query_stats is a collection key-value pair (both strings) statistics that have been aggregated from the key-value pair statistics present in the individual nodes in the query_plan.


Incorporate PEP corner onto site

Per @ekontos , there will be PEP Q&As coming out regularly now. We will start by posting them on the forum. This issue is for the step beyond that where these Q&A are published elsewhere on the site (e.g. linked from Team page) as static pages. We may want to have further discussion about how to fit them in.

Clearing milestone until we know more about how this will be structured, and until we have more than one. I could see them being incorporated as links from the team page, with their own separate page

myapnea.org/team/matt-epstein

Susan would like a dedicated space for this ASAP. We will have another highlight every month. A link from their team page is fine. We need another solution besides forum post.
On Nov 6, 2015, at 11:36 AM, Kyle Rand <notifications<EMAIL_ADDRESS>wrote:
Clearing milestone until we know more about how this will be structured, and until we have more than one. I could see them being incorporated as links from the team page, with their own separate page
myapnea.org/team/matt-epsteinhttp://myapnea.org/team/matt-epstein
—
Reply to this email directly or view it on GitHubhttps://github.com/myapnea/www.myapnea.org/issues/853#issuecomment-154462385.
The information in this e-mail is intended only for the person to whom it is
addressed. If you believe this e-mail was sent to you in error and the e-mail
contains patient information, please contact the Partners Compliance HelpLine at
http://www.partners.org/complianceline . If the e-mail was sent to you in error
but does not contain patient information, please contact the sender and properly
dispose of the e-mail.


[Q] XLSX to CSV stream

Hi, I need to convert the "workbook.xlsx" previously read from a stream, to csv format to be able to write it in another stream. Currently what I have is the following
async transformExcelToCsvStream(entryStream, fileName, finalStream){
   const workbook = new Exceljs.Workbook()
   await workbook.xlsx.read(entryStream)
   await workbook.csv.write(finalStream,{ sheetName: `${fileName}.csv` })
 };

When checking the write result I find an empty .csv file.

@JonatanAlcaraz did you find a solution?
I'm having a similar issue when writing a XLSX with a stream... the result file is empty despite committing all rows, sheets and the workbook.

hi @sneko, I had to create this kind of frankestein to make it work for me, if there is a "better" way to do it I would like to know it, I hope it helps you:
  async transformExcelToCsvStream(xlsxStream) {
    const workbook = new Exceljs.Workbook();
    const csvWriter = format({ headers: true }); //import { format } from "fast-csv";
    const passThroughStream = new PassThrough();
    csvWriter.pipe(passThroughStream);
    await workbook.xlsx.read(xlsxStream).then((wb) => {
      const sheet = wb.getWorksheet("Sheet1");
      sheet.eachRow((row) => {
        csvWriter.write(row.values);
      });
      csvWriter.end();
    });
    return passThroughStream;
  }

the xlsxStream parameter is a file download made with axios with property responseType = "stream".


Closes #220.

As far as I can tell, disallowing ALEX_MONAD_USER_STATE and ALEX_MONAD_BYTESTRING together was unintentional.

Since you created this PR from your master, I cannot amend it.
Closing in favor of

#254


Should we move the button that fixes an issue, closer to the issue's message ?

It's great that we prompt the user to run pub get. However, I wonder if we could make a stronger connection between "these problems HERE can be solved by doing this action HERE"
The UI as it is doesn't seem to indicate a connection between the "problems view" and the toast.
It might make more sense to help the user draw a connection: "we think these problems might be solved by running pub get. Run it now?"

cc @lukechurch for any thoughts

Captured in #523


Output directory customization

We need to be able to customize the output directory on the analysis job.
The output directory needs to be settable for the analysis.
There needs to be some logic that is able to calculate output directories.
The first part of the directory structure, the base directory (for us the mount point to networks storage) should be taken from the config file.
Note: this is not the same as the working directory. The working directory is where the executable operates from, but not the output destination for the files. The working directory code should remain unchanged

See also: https://github.com/QutBioacoustics/baw-server/issues/207

@atruskie this is per analysis?

Although #16 is a little out of date, in particular the

Note these changes only affect the enqueue portions of the code.

Ideally the dequeuer (the part of the code that actually executed jobs) will remain the same.

portion is a good philosophy.
So, the actually job runner itself simply sets the output directory to whatever is set in the payload.
The "per analysis" phrasing I find confusing. The output directory will be calculated every time an analysis is enqueued by the code in #20. Does this answer the question?


NFS share appears to mount read-only

Can someone please share their NFS config for their server AND the mount config from one of their camera config.inc files please?
I finally got telnet access after running remote_install.sh from the version 5.02 release. My camera (v3 btw) is also rebooting frequently and I think it has something to do with the NFS share not being mounted properly.
Edit: here's my NFS export from my server
/media/cameras/         *(rw,sync,no_subtree_check)

And the mounting options for the config inc
export NFS_OPTIONS='-o nolock,rw,noatime,nodiratime'

Thanks in advance!

Nevermind, I figured it out. The probably was that my NFS share directories were still owned by root, so changing the owner with chown -R nobody:nogroup /media/cameras did the job.


[WFCORE-3907] Rename wildfly-component-matrix-builder to

wildfly-core-component-matrix-builder to be able to import it into
Eclipse
https://issues.jboss.org/browse/WFCORE-3907
@jmesnil could you please review?

@kabir is the change in the artifact name impacting your plugin?

@jmesnil It should not, nothing should depend on the builder and the resulting artifact name is configured in https://github.com/wildfly/wildfly-core/pull/3344/files#diff-7bb8c0b1e1e088871585c4eaae3cdd26R58


Add support for rotating, planar LIDAR

The 3D mode wants things via a a PointCloud2 topic and requires externally adding a conversion from scan data to PointCloud2. To remove that dependency and for convenience, supporting plain LaserScan input for 3D could be beneficial.
Additionally, this would allow Cartographer to handle the aggregation of partial revolutions, similar to how Velodyne data is handled.

Upon further consideration, this really only requires a node that converts LaserScan messages into PointCloud2 messages. Everything else should just work TM. @skohlbr, thoughts?

In principle yes, there are some detail questions about the target frame used for the conversion and resulting accuracy.
For highest accuracy, one would like to use high fidelity projection, taking motion of the LIDAR during scan acquisition into account. If one assumes odometry is good, it would make sense to aggregate scan points in the odom frame, but the sensor pose is lost then.
Another option is to convert to a cloud in a non-rotating frame relative to the spinning LIDAR to compensate for scan distortion from rotation and then provide this to cartographer. This requires the robot to provide a suitable non-rotating frame however.
The easiest option is to just use simple projection and ignore scan distortion from rotation. This will likely introduce a bias in the map over time, however.
A small conversion node is this one: https://github.com/team-vigir/vigir_lidar_proc/blob/master/vigir_laserscan_to_pointcloud/src/laserscan_to_pointcloud_node.cpp
If use_high_fidelity_projection is false, it will convert the scan to the same frame as the original scan using simple projection. If true, it converts to a frame given by target_frame using high fidelity projection.

For the VLP data, we treat each UDP packet of data as rigid. The laser scan to point cloud converter could subdivide the laser scan into n segments to simulate that behavior.

Yes, that should indeed be a workable solution. Our VLP hasn't arrived yet, was not aware that it delivers data in such small chunks.

Small heads up, created a fully working example setup of a robot with a spinning LIDAR here: https://github.com/tu-darmstadt-ros-pkg/cartographer_hector_tracker
Launch setup currently uses aforementioned vigir_laserscan_to_pointcloud to convert from scan to cloud.
There is a simulation-based bag file example available, but I'm also preparing a real robot dataset.

Without odom it simply give bad results.


Space Travelers - React Group Project

This is the Kanban board setup for our group project of two persons:
https://github.com/fbclh/space-travelers/projects/4
https://github.com/fbclh/space-travelers

Hi, team (@fbclh & @sediqullahbadakhsh),
Your project is complete!  There is nothing else to say other than... it's time to work on the project :shipit:
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.