[WIP]HBASE-26510 Separate the blockcache enabled key and cache data on read key

https://issues.apache.org/jira/browse/HBASE-26510

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
4m 34s
master passed

+1 :green_heart:
checkstyle
1m 42s
master passed

+1 :green_heart:
spotbugs
3m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 54s
the patch passed

+1 :green_heart:
compile
4m 27s
the patch passed

-0 :warning:
javac
3m 28s
hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)

-0 :warning:
checkstyle
0m 31s
hbase-client: The patch generated 1 new + 249 unchanged - 0 fixed = 250 total (was 249)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 36s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
3m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

57m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3892

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux c824bd0fdf8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f1089970cf

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 43s
master passed

+1 :green_heart:
compile
1m 59s
master passed

+1 :green_heart:
shadedjars
9m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 41s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
10m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 20s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 26s
hbase-client in the patch failed.

-1 :x:
unit
168m 31s
hbase-server in the patch failed.

213m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3892

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b52aee28184b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f1089970cf

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/testReport/

Max. process+thread count
3826 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 29s
master passed

+1 :green_heart:
compile
2m 20s
master passed

+1 :green_heart:
shadedjars
12m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 32s
the patch passed

+1 :green_heart:
compile
2m  4s
the patch passed

+1 :green_heart:
javac
2m  4s
the patch passed

+1 :green_heart:
shadedjars
10m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 27s
hbase-client in the patch failed.

-1 :x:
unit
235m 43s
hbase-server in the patch failed.

286m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3892

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d41164f451ea 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f1089970cf

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/testReport/

Max. process+thread count
3715 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3892/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Increment version for formrecognizer releases

Increment package version after release of com.azure azure-ai-formrecognizer

Closing old PR.


GLB Model with Animations Doesn't Load in Model Viewer, But Works in Babylon Viewer?

Description
I am having issues loading a GLB model with animations into the model viewer. When loading the model, it is just a white screen with nothing on it.

The warning error that was shown here does mention that there is a node with a skinned mesh that is not root, but that shouldn't be causing this type of issue in the model viewer.

When I take that same exported GLB into another model viewer, like Babylon, then the model appears as expected with the animation playing properly.

For reference, here are the components of the model within Blender:

When I place the model in another Google product like Google Poly, then the viewer is also initially blank, but when zoomed out, we start to see a large version of the model that is then clipped by the camera.

When launched in AR, this model similarly looks huge in comparison to what it should be in a normal viewer.

This is very strange that a viewer like Babylon was able to interpret the GLB correctly, but the model viewer here looks like it is either picking up a lingering default pose of the model, or just breaking a connection within the rig, which then breaks the model.
Browser Affected

[ X ] Chrome

OS

[ X ] Android

Interesting. I would take those validator warnings pretty seriously. Can you update the model to fix that? Also, recall that glTF specifies that units are meters, so you've probably exported this in mm or something, which is why it looks huge. Also, we set our camera based on the resting pose of the model, so make sure you animation isn't applying some crazy scale or translation.


Additional items for 2.5

Some clients are not equivalent. For 2.5 or 2.6 I suggest the following features:
The client should have a generic post method that takes a path, a token, and (possibly) some arguments to allow easy access to the parts of the API we haven't explicitly generated (implemented in Ruby)
The client should have a generic get method (as above)

Tag it!


Add Tooltip Property for Icon in DataGrid Component

I would like to request the addition of a tooltip feature that displays when the cursor is hovered over an icon within the card component.
Use Case
In my specific use case, the text might be in draft mode, and I need to provide users with additional context or instructions. For example, I want to inform users to be extra careful while reading the transcript.
Proposed Solution
Implement a tooltip that appears when the user hovers over the icon. The tooltip should be customizable, allowing developers to specify the tooltip text according to their needs.
Example
When a user hovers over an icon, a tooltip should appear with a message like "Draft mode: Please review carefully."

Good feature! Do you think the tooltip should appear only on the icon? It would probably be more logical to have a tooltip over the entire element.
Pull request welcome!

great idea, so it will be a top-level parameters


Revert static IP allocation logic in Azure CNI, PR 1966.

…NI. (#1966)"
This reverts commit 767932c98562bd9b31d45be01dc43da5c50f803c.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2301
Special notes for your reviewer:
Pending for testing results.
Release note:

Hi @jackfrancis, Could you provide some details explaining this revert?
In which situation was this change causing problems?
Thanks!

@serbrech The main issue behind this revert is that upgrading clusters deployed prior to v0.13.0 is failing now, as shown in #2301. We are working on a patch release to address this issue.

@jackfrancis - IIUC, does it mean that pod CIDR should be in vnet address space ?

@yastij I do not think this issue is related what you mentioned. Basically PR 1966 introduces new ways of assigning IPs to master nodes and pods, and it causes conflict for clusters deployed with a prior version of acs-engine.


Vanilla nodejs tests are labelled as @phantomjs

When running magellan's own tests using magellan itself, the environment claimed to be running those tests is @phantomjs, but in reality it's just vanilla node. This is incorrect.

Mostly fixed in magellan 5 unless a non-mocha test framework is used for nodejs testing.


add Ameer to README.md

Hey @ameerthehacker ,
Can you mention a bit more about stacks you work and interested in taking sessions on
or let me know I will add

@gkanishk I have updated the PR


Force Update or Update when Service is called

Is your feature request related to a problem? Please describe.
Hi, that can be interesting to force an updating. For example, I take the app and edit some settings, I need to wait the update interval.
Also, if I call a service like "start climate", the climate is updated when the update interval is reached. So how to know if the command is right received by the car ?
Describe the solution you'd like

Force updating
Update when service is called

I completly agree. unless there is a way on how to "know" that changes will be updated ?  like, there is no update button right now no ?
In my case, when i plug the car i wait for the charger status to change to connected (i have two cars so i need to guess which car is connecting) so when the status from the charger changes to "car connected"  (my easee charger is quite inmidiatly updating its value) then i wait for either car to update.
We have one Tesla and one ID. Buzz, the tesla integration has a service to update o fetch data on demand, when you call that one (or press the button on the device page) the value upates super fast like latest after 15 sec uasually after 5. then if the tesla is connected i change the polling invertall to much shorter value since i know the car is connected and wont drain battery if the integration will polls more often.
Can the polling values of this  integration be changed? or how do we force update the sensors values ?
Thanks

I try some things from ha and app, I conclude the propagation time to the car is around 30 seconds. So the update interval is set to 30 seconds.
@t112013 What is the time you need to wait to see the refresh of the value ?

I more or less agree on 30 sec, but i havnt done anything anywhere, where can you edit the update intervall ?
What my automation does is when the charger-box status changes to connected then i wait for one of the cars to change its charger value to connected so i guess the car that is connected, also i we cannot connect both cars at the same time.

@t112013 you can edit here: https://github.com/mitch-dc/volkswagen_we_connect_id/blob/main/custom_components/volkswagen_we_connect_id/init.py line 69
Here is more info about the update, it seems the car sends these updates every 10 mins, I am currently trying a small modification to change the update time to 15 mins without losing the update when we call a service.

A related PR : https://github.com/mitch-dc/volkswagen_we_connect_id/pull/72

The data in de API is not that fast. There is a big delay in sending thr request (ex stop/start charging) and see it in the app or api.
It's not something a "force update" will fix. :(


[Errno 28] No space left on device when importing SigProfilerExtractor

Hi,
I ran across this error when importing SigProfilerExtractor
>>> from SigProfilerExtractor import sigpro as sig /home/hannan/anaconda3/lib/python3.7/site-packages/joblib/_multiprocessing_helpers.py:53: UserWarning: [Errno 28] No space left on device.  joblib will operate in serial mode   warnings.warn('%s.  joblib will operate in serial mode' % (e,))
I checked both the memory and disk space and there is sufficient memory on both of them.

Here is the traceback when I tried to run the tool
Traceback (most recent call last):   File "<stdin>", line 1, in <module>   File "/home/hannan/anaconda3/lib/python3.7/site-packages/SigProfilerExtractor/sigpro.py", line 823, in sigProfilerExtractor     i = i)   File "/home/hannan/anaconda3/lib/python3.7/site-packages/SigProfilerExtractor/subroutines.py", line 789, in decipher_signatures     results = parallel_runs(excecution_parameters, genomes=genomes, totalProcesses=totalProcesses, verbose = False)   File "/home/hannan/anaconda3/lib/python3.7/site-packages/SigProfilerExtractor/subroutines.py", line 685, in parallel_runs     pool = multiprocessing.Pool()   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/context.py", line 119, in Pool     context=self.get_context())   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/pool.py", line 158, in __init__     self._setup_queues()   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/pool.py", line 251, in _setup_queues     self._inqueue = self._ctx.SimpleQueue()   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/context.py", line 112, in SimpleQueue     return SimpleQueue(ctx=self.get_context())   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/queues.py", line 332, in __init__     self._rlock = ctx.Lock()   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/context.py", line 67, in Lock     return Lock(ctx=self.get_context())   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/synchronize.py", line 162, in __init__     SemLock.__init__(self, SEMAPHORE, 1, 1, ctx=ctx)   File "/home/hannan/anaconda3/lib/python3.7/multiprocessing/synchronize.py", line 59, in __init__     unlink_now) OSError: [Errno 28] No space left on device
I was wondering if this error could be coming from the SigProfiler package or from the joblib/multiprocessing package? Any suggestions/insights would be much appreciated, thanks!
Warmest regards,
Hannan

Hi @hannanw,
Could you please verify if this is from the joblib/multiprocessing package by starting an interactive python session and importing the multiprocessing package?
import multiprocessing
Thanks!

Hi,
I still see the error even after importing the multiprocessing package.
Python 3.7.11 (default, Jul 27 2021, 14:32:16)  [GCC 7.5.0] :: Anaconda, Inc. on linux Type "help", "copyright", "credits" or "license" for more information.
>>> import multiprocessing
>>> from SigProfilerExtractor import sigpro as sig
/home/hannan/anaconda3/lib/python3.7/site-packages/joblib/_multiprocessing_helpers.py:45: UserWarning: [Errno 28] No space left on device.  joblib will operate in serial mode warnings.warn('%s.  joblib will operate in serial mode' % (e,))
>>>
I asked the person in charge of the server where I am trying to run the SigProfiler package and he said that there is still 1.1TB on the / and /tmp so I don't really know why I am getting this error. Sorry, I'm still quite new to computer science any help/suggestion would be greatly appreciated.
Warmest regards,
Hannan

Hi Hannan,
I hope you are doing great and thanks for your interest in our tool! I would strongly suggest using an exclusive conda environment for running SigProfilerExtractor since your error could be due to incompatibilities in your base anaconda environment. You can do that by using the following commands, hope that helps.
conda create --name sigprofilerextractor -y
conda activate sigprofilerextractor
conda install python -y
git clone https://github.com/AlexandrovLab/SigProfilerExtractor.git
cd SigProfilerExtractor
pip install .

Hi Marcos,
Nice to see you again! Thanks for your suggestion, but it still seems like the same error is still occurring as seen in the screenshot below.

Warmest regards,
Hannan

Hi again Hannan!
Please have a look at the first answer here. That should solve your issue since it seems that your /dev/shm is full. Hope that helps.
Best wishes,
Marcos

Hi Marcos,
Thanks! That suggestion worked, I am able to import and run SigProfilerExtractor now without issue.
Warmest regards,
Hannan


Migration from JCenter

Since JCenter annouced that it will close February 1st 2022, I deleted all jcenter references from my project and now I cannot compile because this error is occurring:
A problem occurred configuring root project ''.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find com.archinamon:android-gradle-aspectj:4.3.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/archinamon/android-gradle-aspectj/4.3.0/android-gradle-aspectj-4.3.0.pom
       - https://dl.google.com/dl/android/maven2/com/archinamon/android-gradle-aspectj/4.3.0/android-gradle-aspectj-4.3.0.pom
     Required by:

Do you have any plan to migrate to mavenCentral or any other platforms?

The same here

UPDATE 4/27/2021: We listened to the community and will keep JCenter as a read-only repository indefinitely. Our customers and the community can continue to rely on JCenter as a reliable mirror for Java packages.


accumulate: Correct the readme

Solves #1070.

Happy to pick this up, @sebito91, if the OP isn't available.

@bitfield Since we've not heard back for almost 5 months, I think the right move here is to carry it!

+1 I ran into this problem


fix: encord sdk bad datetime format

Encord SDK is sending a bad format for the datetimes with comma valued datetimes like the following 2022-08-10 17:34:58.649359 and it affects the refresh capability as this error only occurs at label row metadata level, not the label row itself. Now, we trim the faulty numbers and leave it in the proper format while the Encord SDK push a fix and new version.

I am not sure why clipping off the microseconds would fix the issue? The ISO format of the timestamp should be correct no?

We save label rows' metadata with the method encord_project.list_label_rows() while we use encord_project.label_rows() in other places as it guarantees that we only fetch annotated data because of the must exist label_hash restriction. Problem is that list_label_rows() sends dates with the trailing .000000, where label_rows() doesn't which creates the difference when comparing the supposedly same date. This event causes that all label rows are refreshed in each refresh call since the difference between stored date and new date is the same.
We could use label_rows() instead of list_label_rows() for saving but I'm not aware if that's a good idea as the later was supposed an improved version of the first and could cause some unexpected disruption with other metadata fields. Upgrading the Encord SDK version still doesn't solve the issue as list_label_rowsV2() uses the same endpoint as the first version and the dates are also corrupted. This problem should go away with a fix on Encord SDK or when we start fetching all the data, including those with no label hash, as we will use only one method of the SDK and if gets corrupted then it will sort itself out (corrupted == corrupted).

Now I understand - approved


SetContext is under documented

Summary
SetContext function signature can be improved to make it clear to users that it only accept maps. Unless it is not a case and there is a bug to be fixed.
I searched the repository for usage but it seems the same (the tests are using the same approach as mine above). In online documentation there is a following statement:

The best practice to attach custom data is via structured contexts. A context must always be a dictionary or map, and its values can be arbitrary.

Why the function doesn't have in its signature that it accepts only map[string]interface{} but instead there is interface{}? Current signature seems counter-intuitive.
Also, is there a way to enrich the context under a given key later? Right now the object under the key is being overwritten so the namespace can't be enriched.
Steps To Reproduce

hub := sentry.CurrentHub().Clone()
hub.ConfigureScope(func(scope *sentry.Scope) {
	scope.SetContext("tx_type", batch.ttype)
	scope.SetContext("strategy", batch.strategy)
})
_ = hub.CaptureMessage("Message")

Expected Behavior
Values to be rendered correctly.
Screenshots

Environment
SDK

sentry-go version:  	github.com/getsentry/sentry-go v0.12.0
Go version: 1.16
Using Go Modules? yes

Sentry

Using hosted Sentry in sentry.io? Yes
Using your own Sentry installation? Version:
Anything particular to your environment that could be related to this issue?

Additional context

Fixed in v0.14.0 via https://github.com/getsentry/sentry-go/pull/444


Eliminate dependency on plotutils

Fixes #47, because I don't want to package plotutils too.

Ahhh, Leo---you're such a slacker.  Why don't you want to package up everything I've got on GitHub?

Ahhh, Leo---you're such a slacker. Why don't you want to package up everything I've got on GitHub?

Grumble grumble grumble... why don't you do it :-)


Delete TaskQueueUtils

For push queues, use CloudTasksUtils. Pull queues for now directly calls
the GAE task queue APIs. The usage of pull queues will be soon replaced.
Also refactored NordnUploadAction to not rely on the App Engine Task
Queue API to enqueue push queue tasks, which should have been by
TaskQueueUtils in the first place and be converted to using
CloudTasksUtils when it was introduced.

This change is

OK, should be ready for renew now. Will deploy to alpha for testing once alpha is free.


Status Bars - Allow all 4 bars to be displayed

Currently Status Bars only allows for two bars. Expand this to allow for all four bars please.

This main question with this is how should the classic layout be handled? Currently, since there are two, the plugin puts the bars on the pillars at either side of the interface.

I hadn't thought about that as I don't use that mode. There's still some space to the left of leftBar and right of rightBar. I'd guess 20-25% of the current width is free. I think the only way it would work is to make them narrower to allow for two to fit in that space. So a Left1, Left2, Right1, Right2, shrunk width wise by maybe 40%. (my eyeball estimate)
I've been looking through the code, but I'm a novice (student) and unsure of actual implementation into runelite to even test adding bars myself. I'm going to try and learn a bit more over the weekend on this side of runelite and plugin development.
I personally would like to be able to move them similar to how I can move the info boxes around. I'd like options for horizontal too. (I think someone else requested this already) I've started playing with my minimap hidden, and thought it'd be nice to have all 4 across the top. If that didn't look great, it'd be nice to have them on the side in the usual Modern layout.

Being able to have them side by side would be pretty neat.


fix warning on dialog

This is breaking one test. What's is your warning?

missing key on actionObjects

argh - typo - fixed React.Children not React.children

Return the children opaque data structure as a flat array with keys assigned to each child. Useful if you want to manipulate collections of children in your render methods, especially if you want to reorder or slice this.props.children before passing it down.

If we follow this page, I think that we can remove the key effectation from _getAction().
Another way to do is with cloneElement
What's best?

I think removing the key is cleanest

I'm ok with this. Could you squash down the commits?
I will merge, unless @subjectix has any feedbacks, thanks!

@oliviertassinari squished

@oliviertassinari Actually, I believe all usage of JSON must be replaced with composing. But that's for later on. For now this is good :+1:

@chrismcv Thanks


Accepting Timeout value from the Configuration

Hi,
In my application I try to join to couple of server nodes (so if the one hard coded server is temporary down, I'm covered :))
However I've seen in Client.cs that you initializing the ConsulClient.HttpClient.Timeout with a hard coded value of 15 minutes:
HttpClient.Timeout = TimeSpan.FromMinutes(15);
(Which mean for me if one Consul node is down or have difficulties responding  I need to wait 15 minutes for the result)
I was wondering why this is the value and if I can refactor this to be a configurable value from the ConsulClientConfiguration
By the way, I saw there is a Wait property in the ConsulClientCofiguration is it for consul usage?
Thank you very much.

Due to a limitation of how HttpClient works, the Timeout property on the HttpClient must be set to at least as long as any long poll (blocking queries) requests that you want to do, or the request will fail with an error while waiting for the long poll to complete because the request is timing out waiting for data. This means that the timeout must be set to a fairly long interval by default to support blocking queries in the general use case.
If you know that your application will not be using any blocking queries during the lifetime of a specific ConsulClient (this includes use of the Lock and Semaphore classes since they use blocking queries under the hood) there is a constructor overload that accepts a user-provided HttpClient.
You'd use it like so:
using (var hc = new HttpClient()) {
    hc.Timeout = Timespan.FromSeconds(5);
    // You should reuse a Client many times since it adds
    // overhead/garbage to make one per request
    using (var c = new ConsulClient(new ConsulClientConfiguration(), hc) {
        // Do your tasks
    }
}

If you provide your own HttpClient/WebRequestHandlers (e.g. for SSL validation skipping), you are responsible for disposing of them, but you can reuse a single HttpClient between multiple ConsulClients with no problem as well, if needed.
The  WaitTime configuration property provides an upper bound on how long a blocking query will wait before returning data if nothing has changed. It is part of the "blocking query" functionality and maps directly to the wait parameter on the Consul HTTP API.

Oh, and I'm adding CancellationToken arguments to everything when I get some time to do it (see #55 and #56), so with that you could "fake" your own timeouts by awaiting and cancelling after a delay if needed, while keeping a long Timeout value. This is not possible today, though.

Thank you for your answer.
I really prefer if I wouldn't have to create my own HttpClient because of several reasons:

I don't want to be coupled to the HttpClient because maybe ,someday, you would find it necessary to replace the implementation with other library, and I will have to change my code, which make the upgrade process a little bit nasty.
If I provide my own HttpClient, then somewhere in the future, Consul will ask for another header, or change the existing one, and I won't be able to just update the package, I will have to make the changes manually (copy from you :grin:).

I can offer the following solution: Create another constructor which will look like this:

ConsulClient(ConsulClientConfiguration config, Action<HttpClient> overrideClient):this(config)
{
     overrideClient(HttpClient);
}

This way, you are still the owner and creator of the HttpClient and You can add / remove / change the headers and change the properties as necessary (by the way if you use this approach the if in Client.cs line 467 is redundant),and still give me the opportunity to override the default values.
And if I mess something up is my problem :)
what do you say?
Thanks a lot.

The approach of "pass your own HTTPClient" came from #42 because someone else wanted to do the same thing.
Your approach is very interesting and I didn't know you could even do that with Actions. It's a much cleaner way, I agree, though it does not allow one to add Handlers (e.g. for proxied requests or custom cert validation) since handlers must be provided at construction time.
I have no problem adding such a constructor, but it does not seem to cover all use cases around modifying the HttpClient due to how Handlers are added to the client. Any thoughts on those, or am I stuck with a custom HttpClient constructor?

Now that I look through it, I can just do the same thing with the handler, since proxy settings and such are just properties of the handler.

I think I managed to implement something that covers all the use cases that I've seen in https://github.com/PlayFab/consuldotnet/commit/6db3fec382f40a7eea3fcd5d815257b52720da9c - any feedback is nice, but it seems to be what is needed. I'd like to deprecate config object sharing in 0.7.0 as well since it's thread-unsafe to share a config and definitely unsafe to edit it after it's been "consumed" by a ConsulClient.

Well I thought about only one Action but you have three, which make the code a little bit harder to test and maintain.
I consulted with a friend of mine, and I make another implementation
The solution is basically to unify all actions under one class (IConsulClientFactory) and create a base class which hold the basic implementation (BaseConsulClientFactoty).
This way the user is not aware of the internal design (which makes it really ease for you to change in time).
And of course the user can override your implementation if they wish to.
This solution is more oop and encapsulated, The actual ConsulClient does not know how the object are created and does not need to update them, it just uses them where needed.
By the way, nor the ConsulClient nor the IConsulClientFactory know about the HttpHandler, because neither of them actually uses it (So they doesn't suppose to know it exists). The only entity that known about the CreateHttpHandler action is the BaseConsulClientFactory which actually uses it in the CreateHttpClient method.
It  makes the code a little bit better.
What do you think?

I don't like the Factory pattern here since this is going to effectively turn it back into "make your own HttpClient/HttpHandler, just by a long proxy route via a Factory class." I'm not sure how making it an Action makes it harder to test - you get type safety to tell you if you've incorrectly specified a property name or value, you still get exceptions based on setters if needed, and you can store Actions in a variable and pass them to multiple constructors, e.g.:
Action<ConsulClientConfiguration> cfgAction = (cfg) => { cfg.Datacenter = "foo"; };
using (var c = new ConsulClient(cfgAction)) {}
using (var otherc = new ConsulClient(cfgAction,
    (client) => { client.Timeout = TimeSpan.FromSeconds(30); })) {}

You could even compose them (which would be more useful in other contexts but it is possible):
Action<ConsulClientConfiguration> cfgAction1 = (cfg) => { cfg.Token = "yep"; };
Action<ConsulClientConfiguration> cfgAction2 = (cfg) => { cfg.Datacenter = "foo"; cfgAction1(cfg); };

If anything it could be easier to test/maintain because it would be more simple to mock, at least in my mind. I'd gain the ability to guarantee that the configs and clients/handlers were safe because they would not be shared between multiple objects and could not be modified after construction.

I don't like the Factory pattern here since this is going to effectively turn it back into "make your own HttpClient/HttpHandler, just by a long proxy route via a Factory class."

I'm not sure why you feel that way, I'm not asking for the user to implement the IConsulClientFactory on his own. Only "special users" who wish to override the default behavior (which won't be so many) will inherit from

My problem with the Factory approach is that effectively you'd need to create your own Factory if you wanted to make a differently configured Config object, or create a Factory that accepted and copied a ConsulClientConfiguration.
It is a very common use case to set a bunch of different stuff in the ConsulClientConfiguration class and pass it to the constructor, and the only reason it's a separate class as compared to a bunch of properties on the ConsulClient class is that I couldn't think of a way to construct multiple clients with the same properties easily. The Action method solves that and I might end up axing the entire ConsulClientConfiguration class to move all the properties into ConsulClient, and make setting them part of the constructor action for the ConsulClient to make them "readonly-esque".

Closing since you've got a workaround until 0.7.0 (you'll have to make your own HTTPClient for now) and we've figured out a method to allow changes post 0.7.0.

Sorry for the late response, but I had to consult with my colleges to regard your answer.
The factory approach forces to create a Factory class only if you want to change something (it is NOT the common case).
Moreover, if you want to change one thing you don't need to override 3 functions but only one, so you should be aware only to the functions you want to override (as C# intended to ).
To achieve this with Actions you will have to overload the constructors in various format which will make the code messy.
Using class is more OOP solution than invoking Actions.
Actions are meant to answer the question of

"How to execute a business logic unit".

this is not your question in this case, because you don't have a business logic to execute, it does not belong to how to retrieve KV data or how to connect to agents. in those cases you really have a process that you ask the user something and the user should know and care about this.
A better question is

"How to configure a middle-ware in my system"

here you can get a Model to answer the question, be ware that you are in control of what this Model exposes and how it configures your middle-ware.
If you use an action you don't have those restrictions, The user can change a value that you do not know about and mess up your HttpClient.
It is not an encapsulated solution, and C# (as oppose to js or slimier languages) uses the power of the Objects to encapsulate data.
Please try to discuss with your colleges and ask for their opinions the matter (and if they will find me wrong please do share).
Thank you for your time.


Fix invalid syntax in documentation

Description
Fix issue in the docs where invalid syntax is used to defined a regex-based type.
Self Check:

[ ] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x]  Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] End user documentation is included or an issue is created for end-user documentation
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master, iso7 in 3daf29f3868e14a653485c35bdc694430003de0b


Sent command

Hi, i can scan codes and are displayed on server web when i want send the command via web “http://xxx.xxx.xxx.xxx:port/msg?code=A90:SONY:12&pass=yourpass” say “code sent ok” but don’t work. Any problem with led emitter?
what’s happen? i used 100 ohm to resistor....

Probably a hardware problem
Verify using an IR capable camera (most front facing cameras on cell phones) that your LED is lighting up when you issue a command
If not then double check all your wiring (feel free to post a picture of your build and I can take a look)

Ok i will send a pic and check wired and led polarity too...

monitor output:
Connection received - MSG
Blasting off
Blocking incoming IR signals
FFD02F:nec:32
Transmission complete
Reenabling receiving
Turning off the LED to save power.
Success! code sent... but don't happens anything
the address opcion field is "0X0" when i learn any code...

The address behavior is normal. Only Panasonic codes use that. Wiring looks good so I would check resistors and LED polarity. Use a camera to see if the LED is lighting up as well. If no light then you’ll need to check all your hardware for a bad component

Mmmmm  if the LED is not lighting up i will try another resistor (120 ohm for example). I think the led polarity is good. 5,5v —-> resistor 100 ohm —-> + LED (longest pin).

It seem that you have the V3 Revision of the NodeMCU.
I have had the same problem, and I had roundabout 1V only on Pin 30  Vin. Ive used Pin 18 VV instead. Ive meassured 5V on this pin, and it works for me since several days.

@thommy6102 Works Fine!! i changed to Pin VV
Thank you!


Crash on closing tab in fullscreen mode

Feedback Hub: https://aka.ms/AA7kn4w
Environment
# Windows build number:

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

# Windows Terminal version (if applicable):

0.9.433.0

Steps to reproduce

F11 to enter fullscreen mode
ctrl+shift+space to open a shell (MUST be different to current shell, like powershell to cmd)
ctrl+tab to switch tab
ctrl+shift+w to close tab

Then it crash :) This is ok if we don't enter fullscreen mode.
Expected behavior
Switch between tab correctly.
Actual behavior
Application crash.

I don't know whether this may help, but it say Unhandled exception at 0x00007FFEFCAC600E (TerminalControl.dll) in WindowsTerminal.exe: 0xC000041D if I choose vs2019 to "debug" after it report something to Microsoft.

Thanks for the report! Would you mind filing feedback?

/feedback

Yes, I have submitted to Feedback Hub above. And what's more?

and paste the link here so we can more easily find your crash information on the back end?

Do you mean https://aka.ms/AA7kn4w ? I pasted it in the first line above.

Sorry! I tend to read bugs that follow the template by starting at the headings :smile:

Hope that will help😊

Yup, I can reproduce this. What on earth?

Okay, this is another instance of /dupe #4613


Replacing Current vs-debug-button.png

Propose replacing of image in order to show consistent target device with Create a project -> Select the target device

Thank you for this suggestion. However, because the image cuts off the text, and the original source image (paint.net PDN file) would be out of sync with this image, I'm going to close this PR. I don't think this will trip users up as we've already received feedback of people successfully completing the tutorial. The text around that image talk about the "play" button, not the device target, so hopefully people will understand what to do.


adds a --force option to override existing projects

With this pr, spacchetti local-setup exits with an error in case of existing packages.dhall or psc-package.json files.
A --force option has been added to overwrite existing projects.
There's a bit of a lazy implementation of a unsafePathToText to print file paths in the error message, but I suppose it's good enough for now.

Thanks


Add support for Apache HttpClient 5.x

5.0 is almost 2 years old

Hi @eyalkoren , I took it to work

@kananindzya thanks a lot!! 🙏
Please try to reuse code as much as possible with former versions.
Testing should rely on the existing one we share for all HTTP clients as much as possible.

Additional acceptance criteria: Ensure that feign requests made via apache http client v5 are correctly captured:
https://github.com/elastic/apm-agent-java/issues/2942#issuecomment-1576630990


Common Lisp

Fairly simple implementation in Common Lisp. I've only checked SBCL, but Clozure, ECL, and LispWorks should all work. Matmul is frustratingly slow, but I'm not smart enough to make it fast without punting off to Bordeaux-threads or Lparallel. And we're doing no libraries so... slow but steady it is.
Despite being Lisp it's done in a more imperative style, I might try doing an FP version in Scheme one of these days (if that sounds interesting).
The programs can also be timed in the REPL:
$ sbcl
* (load "nqueens.lisp")
* (time (main))

Thanks! I installed sbcl v2.4.0 to /usr/local. When I ran make, I got the following error:
sbcl --load nqueen.asd \
                --eval "(ql:quickload :nqueen)" \
                --eval "(asdf:make :nqueen)" \
                --eval "(quit)"
This is SBCL 2.4.0, an implementation of ANSI Common Lisp.
More information about SBCL is available at <http://www.sbcl.org/>.

SBCL is free software, provided as is, with absolutely no warranty.
It is mostly in the public domain; some portions are provided under
BSD-style licenses.  See the CREDITS and COPYING files in the
distribution for more information.

debugger invoked on a SB-C::INPUT-ERROR-IN-LOAD in thread
#<THREAD "main thread" RUNNING {7005550003}>:
  READ error during LOAD:

    Package ASDF does not exist.

      Line: 1, Column: 15, File-Position: 14

      Stream: #<SB-INT:FORM-TRACKING-STREAM for "file pathto/plb2/src/cl/nqueen.asd" {7005512623}>

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

Does this mean I need to install asdf?

SBCL ships with ASDF, but it doesn't automatically load it, I'll fix the Makefile. I'll also remove the quicklisp invocation while I'm at it because we're not pulling in external dependencies anyway.


Bug: Pandas ValueError occurs during task_instance.render_template()

We have a code change in (0.11.0) https://github.com/OpenLineage/OpenLineage/pull/870/files which has
following added:

in integration/airflow/openlineage/airflow/listener.py
here's the snippet of exception trace:
[2022-08-12 00:02:08,729] {taskinstance.py:1909} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 1471, in _run_raw_task
    self._execute_task_with_callbacks(context, test_mode)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 1575, in _execute_task_with_callbacks
    task_orig = self.render_templates(context=context)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 2232, in render_templates
    rendered_task = self.task.render_template_fields(context)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/baseoperator.py", line 1188, in render_template_fields
    self._do_render_template_fields(self, self.template_fields, context, jinja_env, set())
  File "/usr/local/lib/python3.9/site-packages/airflow/utils/session.py", line 71, in wrapper
    return func(*args, session=session, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/abstractoperator.py", line 341, in _do_render_template_fields
    if not value:
  File "/usr/local/lib/python3.9/site-packages/pandas/core/generic.py", line 1537, in __nonzero__
    raise ValueError(
ValueError: The truth value of a DataFrame is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

and looks like when the listener was calling the render_templates() on task instance,
In this part of the code in airflow:
https://github.com/apache/airflow/blob/fe0f903f750d79cdb7ae0cfe105397eedc9af141/airflow/models/abstractoperator.py#L360
got ValueError() raised.
the Error seems to be coming from the pandas package - and seeing the DAG file of which caused this error, looks like
pandas DataFrame was used:
from datetime import datetime, timedelta
from pandas import DataFrame
from typing import Any, Dict
import yaml
...
def xcom_to_list(xcom, cols: Dict[str, str]) -> list:
    """
    Take xcom and return a list of dictionaries.
        Parameter:
            xcom: Data from upstream task.
            cols (dict): Dictionary of column name mapped with old column name.
        Return:
            results (list)
    """
    import pandas as pd

    df = pd.DataFrame(xcom)[cols.values()]
    df.columns = cols.keys()
    results = df.to_dict(orient="records")

    return results
...

And looks like the value error was coming from the fact that
panda DataFrame was given as the value and python was trying to see if
    if not value:

was true or not, and got the value error : ValueError: The truth value of a DataFrame is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().
So, would like to see if this can be fixed, and therefore have OpenLineage avoid error when Airflow DAG is using pandas DataFrame .

>>> from pandas import DataFrame
>>> df = DataFrame()
>>> if not df:
...   print("hey")
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.9/site-packages/pandas/core/generic.py", line 1527, in __nonzero__
    raise ValueError(
ValueError: The truth value of a DataFrame is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

Running a simple test to see if DataFrame is compatible with if not value can be tested out quite easily.

Hey @howardyoo,
as you pointed correctly, the render_templates method is called during task execution which makes it Airflow specific issue. Pandas DataFrames are for sure not supported in Airflow XComs (I'm not really sure what's the connection between xcom_to_list method and rendered template fields). However, the Airflow code snippet shows that you cannot set Pandas DataFrame (or anything that raises exception on if not value check) as template field in Airflow Operator.
Would you like to elaborate more on what's the example Pandas DataFrame as the template field and how xcom_to_list is used?

Also, just my two cents, but it may be better to perhaps put the render_template() in try .. catch statement so that if the rendering fails for some reason, we may be able to get the error and even populate the error message as errorFacet - for more graceful error handling.


Support creating Signals for leaf node data that doesn't exist yet

Legend-state allow you to create a Signal for a piece of data in an object/state tree that doesn't yet exist and will run effects/computed signals once that data is set. I think it's worth considering support for that use case. I think it's API should be looked at for inspiration as it's close to what is proposed in this repo.
https://legendapp.com/open-source/state/intro/introduction/

@littledan @mhevery This sounds like it might be related to some of the resumability conversations that we had. Thoughts?


build.sh and deploy.sh not copying latest code

I run these two scripts below, it looks like the build.sh copies the app code. When I run the deploy command and then go inside (exec /bin/bash) the container, I can't see the code changes.
 I thought I would be able to build and deploy without removing them from the stack, since this would cause some minor downtime if I need to docker stack rm each time.
Sorry if this is just a basic misunderstanding of my docker knowledge, I'm very new to it.

I also get this when I run DOMAIN=xxx.com \ TRAEFIK_TAG=xxx.com \ STACK_NAME=xxx-com \ TAG=prod \ bash ./scripts/deploy.sh
image backend:prod could not be accessed on a registry to record its digest. Each node will access backend:prod independently, possibly leading to different nodes running different versions of the image.
I don't get that for the other images except from celeryworker:prod

I also get this when I run DOMAIN=xxx.com \ TRAEFIK_TAG=xxx.com \ STACK_NAME=xxx-com \ TAG=prod \ bash ./scripts/deploy.sh
image backend:prod could not be accessed on a registry to record its digest. Each node will access backend:prod independently, possibly leading to different nodes running different versions of the image.
I don't get that for the other images except from celeryworker:prod
Also, the image ID shown on docker ps after running deploy does not match the backend:prod image ID when I run docker images, unless I take down the stack and rebuild then deploy again.
I guess this is some kind of private registry issue.

Regarding the error, this just indicates, that the image can't be found in a registry but your local. This means, that you built your image locally and other nodes could not access this image. This would result in two nodes with different images. If you only have one node, you can ignore this but if you have two or more you should definitely use a registry.
Why is this only shown for celeryworker ? - > The message is only printed for updated containers, this means only your celeryworker changed and the other containers not. Change the frontend or the backend and the error will be shown for them too.
You should not run docker stack rm as this would result in a downtime and loss of the logs and other stuff, always update with the deploy script. If your code isn't updated you can add - - no-cache to the build script. This will always include all changes. I did this by adding $@ to the end of the build script and provide it to build if needed.
I hope this helped, I'm on mobile and can't be as informative as I'd like to :)

@Biskit1943 thank you for your help, I'm still struggling to get this working, any more help would be appreciated.
I did the build with --no-cache flag which took a few mins, then deployed, then I exec bin/bash into the backend container and did an ls -la. It still hasn't updated the code in the app directory.

If I do ls -la outside the backend container in the host machines backend/app directory it has thisisatest.md

If I run docker images I get the following output, with the latest Image ID

My backend image that is running has the Image of 50a8920aeaa6 rather than backend:prod or the ID shown on the screenshot above

Could you try to run docker service update --force <name> not sure right now but this should do a force update of the container, which should in theory deploy the latest image.

Some more testing:
Build, deploy, then docker images

docker ps

Change code, build,  then docker images The previous backend and celeryworker images are still their, they have lost their repository and tag and are now

docker ps shows the following. It is now running the Image ID with the repository  and tag , as the build has made a new image with backend:prod and I assume two images can't have the same repo:tag:

Then finally I deploy and run 'docker ps' and I'm still stuck on the image tagged with   and latest backend:prod image isn't deployed.
docker ps

@Biskit1943 I will try the command you sent

Ok, let's recap.
 I think you got things messed up by using docker-compose up to deploy the stack otherwise it won't be possible that the container is deployed with tag <none>...

I think this is the same issue that is described here https://github.com/moby/moby/issues/31357, regarding docker stack deploy not updating to the latest image. This does not seem solved.
In the end I worked around it by adding these lines to the end of scripts/deploy.sh (add any other services you need).
docker service update --force ${STACK_NAME}_backend
docker service update --force ${STACK_NAME}_frontend

A cleaner solution would be to tag the images incrementally and deploy a different tag on every update.


How to send an HTTP response when using app.oauthPersistenceCallback

When calling oauthPersistenceCallback during installation, though the installation happens successfully but URL doesn't get redirected to OAuth completion URL and it stuck to below URL. Below is my code for oauthPersistenceCallback
https://XXX/slack/oauth_redirect?code=2447194999527.4425044381062.4781a36ed78b69cd472e3820e44c76b836acdfbe34ded25363366933d5a84b0e&state=4420b3fb-766c-4d84-b371-c3a007b8ad7d
 app.oauthPersistenceCallback(new OAuthV2SuccessPersistenceCallback() {
            @Override
            public void handle(Arguments args) {
                String cookiesHeader = args.getRequest().getHeaders().getFirstValue("cookie");
                List<HttpCookie> cookies = HttpCookie.parse(cookiesHeader);
                Optional<HttpCookie> httpCookie = cookies.stream().filter(cookie -> cookie.getName().equalsIgnoreCase("orgId")).findAny();
                if (httpCookie.isPresent()) {
                    saveSlackInstallationInfo(args, httpCookie);
                }
            }
        });

Hi @rishisaraf11, the arguments object provides the response object for the URL access. Your callback is responsible to set a valid status, headers, and body. See the default implementation https://github.com/slackapi/java-slack-sdk/blob/v1.27.1/bolt/src/main/java/com/slack/api/bolt/service/builtin/oauth/default_impl/OAuthV2DefaultSuccessHandler.java#L137-L152 to learn how to do it.


Develop

I would like to contribute a bug fix related to this library and Internet Explorer.  The issue is outlined in this blog post.  https://blogs.perficient.com/2017/03/27/troubleshooting-the-redirect-issue-of-net-cas-integration-in-ie/

Which versions of IE does this effect?

Which versions of IE does this effect?

Did you also try the most recent version of the nuget package to see if the problem actually still existed?  The problem they described in the four year old blog article is a TLS related problem for a cyclical redirect issue.  From what I can tell they just made a bandaid fix, but the problem was still there in reality.
If I am wrong, please provide fully reproduction scenario, including version of IE, with most current nuget package, step by step, so that we can test and verify the problem still exists.

Did you also try the most recent version of the nuget package to see if the problem actually still existed?  The problem they described in the four year old blog article is a TLS related problem for a cyclical redirect issue.  From what I can tell they just made a bandaid fix, but the problem was still there in reality.
If I am wrong, please provide fully reproduction scenario, including version of IE, with most current nuget package, step by step, so that we can test and verify the problem still exists.

Sorry, this is my first time trying to contribute to a project on Github.  I forked, pushed my changes and created a new pull request.

Sorry, this is my first time trying to contribute to a project on Github.  I forked, pushed my changes and created a new pull request.

@jffcovey you didn't have to close the issue, just answer the questions I asked. I mean, you put in all that effort writing that blog post back in 2017 and the investigative debugging, I figured it wasn't too much to ask of you to test your problem against the latest release in nuget to see if the problem was still there or not.

@jffcovey you didn't have to close the issue, just answer the questions I asked. I mean, you put in all that effort writing that blog post back in 2017 and the investigative debugging, I figured it wasn't too much to ask of you to test your problem against the latest release in nuget to see if the problem was still there or not.

I didn't write that blog.  I ran across it while triaging a bug that we have with the latest nuget package(1.3.2).  If you try to use it with IE 11 I think you will see the same behavior.  I created a new pull request with the code change we implemented that fixed the issue.  We're fine with maintaining our own customized version of the code, but just thought it would be helpful to contribute back to the project.

I didn't write that blog.  I ran across it while triaging a bug that we have with the latest nuget package(1.3.2).  If you try to use it with IE 11 I think you will see the same behavior.  I created a new pull request with the code change we implemented that fixed the issue.  We're fine with maintaining our own customized version of the code, but just thought it would be helpful to contribute back to the project.

What version of TLS is both the web application server running and the CAS server running?  What version of. Net is your application compiled against (be specific)

What version of TLS is both the web application server running and the CAS server running?  What version of. Net is your application compiled against (be specific)

Both servers are running TLS 1.2 and we using .NET Framework 4.6.1 to compile our application.  Also, version 1.3.2 of DotNetCasClient.

Both servers are running TLS 1.2 and we using .NET Framework 4.6.1 to compile our application.  Also, version 1.3.2 of DotNetCasClient.

Is there anything else you need from me?

Is there anything else you need from me?


Catastrophic failure when i try to debug specific scene

When i right click on a .tscn file and click on debug scene
the rider shows below:
Catastrophic failure (exception from HRESULT: 0x8000FFFF (E_UNEXPECTED)) The error code is E_ UNEXPECTED, or 0x8000FFFF
but when i click run the scene,it just work successfully
it appear on my every project,and im not sure if this can reproduce on other PC,so i can't give any further infomation.
here are some pictures:

Thank u!

Would it be possible for you to share the project?
If you don't want to share it here, available to everyone, I can propose to use https://uploads.jetbrains.com/ and sent here just the name of the attachment.

Would it be possible for you to share the project? If you don't want to share it here, available to everyone, I can propose to use https://uploads.jetbrains.com/ and sent here just the name of the attachment.

yeah,of course
but there's nothing different from the new project
the project is exactly the same one that pictures above shows
(Please ignore the scripts inside,it is unimportant
GDScriptIssue.zip
thanks for your time!

Thank you for reporting. Fix is targeting 2024.1.
Temporary workaround is to change the Runtime manually in the generated run-configuration.


Short-Circuit Manifest Application / Pod Health Checks if not provided

If no manifests are provided we could skip the attempt to apply them. Same for the pod health checks.

Possibly something like so:
https://github.com/mumoshu/terraform-provider-eksctl/blob/master/pkg/resource/cluster/cluster.go#L40
if len(cluster.CheckPodsReadinessConfigs) == 0 {
  return nil
}

https://github.com/mumoshu/terraform-provider-eksctl/blob/master/pkg/resource/cluster/cluster.go#L93

@MMartyn Thanks! That makes senes. It's fixed in master now.


Installation fails for M9+

Describe the bug
Unexpected error occurs when trying to add ne integration to my HA system. I have M9Plus (version2, latest firmware) router and Deco's own Ui is only asking for password, not username.
Debug log
I tried with 3 different option
Host: <IP_ADDRESS>, then http://<IP_ADDRESS> and last https://<IP_ADDRESS> and they all gave this same error message
2022-03-21 19:40:44 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials: Cannot connect to host <IP_ADDRESS>:80 ssl:default [Connect call failed ('<IP_ADDRESS>', 80)]
2022-03-21 19:41:03 ERROR (MainThread) [custom_components.tplink_deco] Fetch keys client error: Cannot connect to host http:80 ssl:default [Try again]
2022-03-21 19:41:03 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials: Cannot connect to host http:80 ssl:default [Try again]
2022-03-21 19:41:13 ERROR (MainThread) [custom_components.tplink_deco] Fetch keys client error: Cannot connect to host https:80 ssl:default [Try again]
2022-03-21 19:41:13 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials: Cannot connect to host https:80 ssl:default [Try again]
Add your logs here.
2022-03-21 19:50:56 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials: Cannot connect to host https:80 ssl:default [Try again]
2022-03-21 19:51:02 DEBUG (MainThread) [custom_components.tplink_deco] aes_key=3138964353424714
2022-03-21 19:51:02 DEBUG (MainThread) [custom_components.tplink_deco] aes_iv=1693287201126418
2022-03-21 19:51:02 ERROR (MainThread) [custom_components.tplink_deco] Fetch keys client error: Cannot connect to host <IP_ADDRESS>:80 ssl:default [Connect call failed ('<IP_ADDRESS>', 80)]
2022-03-21 19:51:02 DEBUG (MainThread) [custom_components.tplink_deco] Finished fetching tplink_deco-decos data in 0.041 seconds (success: False)

<IP_ADDRESS> is the right format for the config. Can you confirm you are able to connect to your deco admin UIthrough a browser at http://<IP_ADDRESS>?

I suspect that your router requires SSL requests, but the integration isn't connecting over SSL. Could you try using <IP_ADDRESS>:443 in the config?

Did not help, it was scrolling very long time and then unexpected error occured again.
2022-03-23 22:24:01 DEBUG (MainThread) [custom_components.tplink_deco] aes_key=1497349308090915
2022-03-23 22:24:01 DEBUG (MainThread) [custom_components.tplink_deco] aes_iv=1116728406226652
2022-03-23 22:24:31 DEBUG (MainThread) [custom_components.tplink_deco] Fetch keys timed out
2022-03-23 22:25:01 DEBUG (MainThread) [custom_components.tplink_deco] Finished fetching tplink_deco-decos data in 60.000 seconds (success: True)

That seems to be a step in the right direction since the error is Fetch keys timed out instead of Fetch keys client error: Cannot connect to host <IP_ADDRESS>:80 ssl:default [Connect call failed ('<IP_ADDRESS>', 80)] in your previous log post.
Not clear why it is taking over 60s. Considering that it is using https and the fetch keys is timing out, I'm guessing that M9+ might have different calls for its authentication scheme.
Can you check the http paths being called in the browser network history when you login manually? This integration assumes it is calling "http://{self.host}/cgi-bin/luci/;stok=/login", but would help to check if its calling different paths.

This is first related command it it get status 200 code
POST https://<IP_ADDRESS>/cgi-bin/luci/;stok=/admin/system?form=envar
this is next
/cgi-bin/luci/;stok=00eefafcea7104024d157b7f95c37461/admin/device

these are post commands when I open deco admin UI:
POST | https://<IP_ADDRESS>/cgi-bin/luci/;stok=/admin/system?form=envar
POST | https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=check_factory_default
POST | https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=keys
When I click login:
POST | https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=auth
POST | https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=login

2022-03-28 17:23:51 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
response_json = await self._async_post(
File "/config/custom_components/tplink_deco/api.py", line 345, in _async_post
raise AuthException from err
custom_components.tplink_deco.exceptions.AuthException

Another thing to check is if you can copy and execute the call manually. Specifically for the https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=keys call. In chrome you can right click on the call and go to "Copy" menu, then either copy and paste in Powershell or curl and verify that the call succeeds.
Could you get more request info for the https://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=keys call? Such as request payload and headers?

See attached files. As you can see Powershell commands are giving errors.

Sorry, can't understand the error message since it's in a different language, but it seems like there's a problem with running Invoke-WebRequest on your computer related to SSL/TLS. Please try and see if you can fix whatever is preventing the request so that you can confirm if the manual request works.

Hi!
I have the same issue with my X50.
the errors are the same, and portal also o lay requests password, not username.
I got these logs from the router itself, maybe useful?
Wed Jun 8 16:18:59 2022 authpriv.warn dropbear[17055]: Login attempt for nonexistent user from <IP_ADDRESS>:54834 Wed Jun 8 16:18:59 2022 authpriv.warn dropbear[17055]: invalid username b2d84f085dd572011ca3b40e81ab7e5aecd7651b Wed Jun 8 16:18:59 2022 authpriv.warn dropbear[17055]: Bad password attempt from <IP_ADDRESS>:54834

Hi, I seem to be facing the same issue. I can log in fine over the web interface. My login is over http and definitely not over https: Logs are as follows:
2022-06-23 02:16:57 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
2022-06-23 02:18:09 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
2022-06-23 02:19:43 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
2022-06-23 02:23:51 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
2022-06-23 02:27:37 WARNING (MainThread) [custom_components.tplink_deco] Error testing credentials:
Running the login via powershell returns a 200:
Invoke-WebRequest -UseBasicParsing -Uri "http://<IP_ADDRESS>/cgi-bin/luci/;stok=/login?form=keys" `

-Method "POST" -WebSession $session
-Headers @{
"Accept"="application/json, text/javascript, /; q=0.01"
"Accept-Encoding"="gzip, deflate"
"Accept-Language"="en-GB,en-US;q=0.9,en;q=0.8,de;q=0.7"
"Origin"="http://<IP_ADDRESS>"
"Referer"="http://<IP_ADDRESS>/webpages/index.html"
"Sec-GPC"="1"
"X-Requested-With"="XMLHttpRequest"
} -ContentType "application/json"
-Body "{"operation":"read"}"

StatusCode        : 200
StatusDescription : OK
Content           : { "result":{ "username":"", "password":[ "D1E79FF135D14E342D76185C23024E6DEAD4D6EC2C317A526C811E835
38EA4E5ED8E1B0EEE5CE26E3C1B6A5F1FE11FA804F28B7E8821CA90AFA5B2F300DF99FDA27C9D2131E031EA11463C47944C
05...
RawContent        : HTTP/1.1 200 OK
Connection: close
Transfer-Encoding: chunked
Cache-Control: no-cache
Content-Type: text/plain
Expires: 0
                { "result":{ "username":"", "password":[ "D1E79FF135D14E342D76185C23024...

Forms             :
Headers           : {[Connection, close], [Transfer-Encoding, chunked], [Cache-Control, no-cache], [Content-Type,
text/plain]...}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        :
RawContentLength  : 331

Please enable HA debug logs for the integration and paste the debug logs. Your logs only show warning logs that it failed so it's not clear if it's failing at the same get keys request or some other request.

Could be. What is the error about the certificate? Is it expired? Self-signed?

Self-signed, tp-link provided that, I have not done anything

Sorry for delayed response, I think setting verify_ssl = False may fix that. Could you verify this by modifying
custom_component/tplink-deco/api.py at line 340 and add that parameter. So code there should look like:
                response = await self._session.post(
                    url,
                    params=params,
                    data=data,
                    headers=headers,
                    verify_ssl=False,
                )

Let me know if that works for you, if it does I'll look into adding it as a setting

great! Now i was able to get it installed!

I added a new config option for verifying the SSL certificate in https://github.com/amosyuen/ha-tplink-deco/releases/tag/v2.2.0. So you should upgrade and turn that off in the options.


Make admin server host configurable

This PR sets the admin server URL to be http://localhost:8080 in development and https://admin.rilldata.com in production.

Instead of using the NODE_ENV, how about we increase flexibility and make the admin host itself a build variable (process.env.RILL_ADMIN_HOST) and just default to http://localhost:8080 if it's not set? Then we can set RILL_ADMIN_HOST as a build env var in Netlify and easily customize it for staging/preview in the future.

Cool, that works.
I prefixed the environment variable with VITE_ given Vite's documentation here: https://vitejs.dev/guide/env-and-mode.html#env-files


Cannot access the data download website

The website https://spateodata.aristoteleo.com/ for downloading the processed data seems cannot be accessed.

@Yao-14 Hey Jiajun, how is the data access now?

Mouse_E9.5_embryo.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/mouse_E9.5_embryo.h5ad
Mouse_E11.5_embryo.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/mouse_E11.5_embryo.h5ad
Mouse_E9.5_heart.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/mouse_E9.5_heart.h5ad
Mouse_E11.5_heart.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/mouse_E11.5_heart.h5ad
Dorosphila_S11_cellbin_clean.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/dorosphila_S11_cellbin_clean.h5ad
Dorosphila_S13_cellbin_clean.h5ad: https://ftp.cngb.org/pub/SciRAID/stomics/STDS0000058/stomics/dorosphila_S13_cellbin_clean.h5ad

@Yao-14 can you please update the page of https://spateodata.aristoteleo.com/ and automatically redirect it to the CNGB pages?

Sure, i will update the website later!

@Yao-14 did you get a chance to update the page?

@Sichao25 please help us to update the link. there are several reader is complaining about this

Thanks to @Sichao25 for the help, the link of spateodata has been updated! Please download sample data from  https://spateodata.aristoteleo.com/

great. thanks all! so this issue is fixed and close it now


upsscp.py throws exception on N-SET

Setup
Python tool based on pynetdicom issuing a send_n_set() command.
Observed behavior
After sending the n_set command, in upscp.py the handle_nset handler is properly called. But then internally, in handlers.py, line 646, search() throws an exception with the statement: AttributeError("The corresponding event is not a C-FIND, C-GET or C-MOVE request and has no 'Identifier' parameter").
Due due to error message, it is not fully clear, whether this is an internal issue, or whether something provided in the N-SET command has an issue.

Please paste in screen content/log from upsscp.py --debug
Ideally from the start of the specific association for the N-SET-RQ.
The message listed is not present in the main branch, but might be in commits earlier than July 2024.
The message can be found in pynetdicom when accessing event.identifier
event.identifer is still being accessed in upsscp.py for N-GET and C-FIND (N-GET is optional in TDW-II, and that hasn't been tested... a brief code inspection indicates it would fail and give that message, so I'll add a separate issue for "support N-GET")
I haven't been bumping the version (semantic versioning) on each commit, so I'll start doing so to help in tracking.

PR #61 Seems to be where the major change happened that switched from trying to use "event.identifier" to the decoded dataset in the N-SET-RQ.

This was fixed in #61
confirmed with @christof-schadt-bl that after synchronising his social fork and fetch/pull main that this issue went away


Indicate own happiness and notifications for users

Resolved the following stories in this branch:
As a team member I want to indicate how happy I am
As a team member I want to indicate how happy the team is
As a team member I want to input my happiness on a small scale to more easily decide for a value
As a team member I want to have fewer steps and better descriptions during input to save time
As a team member I want to be reminded to input my happiness at different times each day to not get biased (Restriction: Feature is not enabled yet, due to an error when deploying it to heroku)
As a team member I want to be reminded regularly when ignoring the notification to not forget the input (Restriction: Notifications don't yet stop an hour before the next notification schedule starts)
As a team member I want to postpone notifications to be not disturbed during busy work hours

seams all fine

Accidentally created this pull request to the wrong repository. Please delete it


Close socket on nextTick. Fixes #205

Please take a look at https://github.com/feross/bittorrent-tracker/pull/208 which I think solves this in a cleaner way.


Feature/cds 1390 firehose

Description

Added custom naming for resources
Added ability to data reference global resources (s3 & iam)
🛑 Breaking changes 🛑
Update variables: private_key renamed to api_key with type string instead of any.

How Has This Been Tested?
Locally
Checklist:

[x] I have updated the relevant example in the examples directory for the module.
[x] I have updated the relevant test file for the module.
[ ] This change does not affect module (e.g. it's readme file change)

I have to ask why this change was released and you didn't release a major version change, since after all swapping arguments is a breaking change to your consumers. I am specifically referring to moving from private_key to api_keyin firehose-metrics
And the documentation for the module has no note of the change, its only visible in the commit, and never made it in the release notes.

Hi @gregops312, many apologies I should have written it in the PR, it was documented in the ChangeLog.md: https://github.com/coralogix/terraform-coralogix-aws/blob/feature/cds-1390-firehose/CHANGELOG.md#v10105
There will also be another change to the coralogix_region soon to follow https://coralogix.com/docs/user-guides/account-management/account-settings/coralogix-domain/

Hi @gregops312, many apologies I should have written it in the PR, it was documented in the ChangeLog.md: https://github.com/coralogix/terraform-coralogix-aws/blob/feature/cds-1390-firehose/CHANGELOG.md#v10105
There will also be another change to the coralogix_region soon to follow https://coralogix.com/docs/user-guides/account-management/account-settings/coralogix-domain/

Thanks for that, I stupidly didn't actually look at the ChangeLog.md that is definitely on me. Thanks I will put a note in our usage so we are ready for when that changes.


MudField, MudMask: Support typography customization

Description

Follows up on #8754 and Resolves #9412, also reported in https://github.com/MudBlazor/MudBlazor/pull/8754#issuecomment-2231442930.
MudField and MudMask are not using a standard inheritance so were missed in the original PR. This brings parity for the application of typography classes to them.
How Has This Been Tested?

visually
Type of Changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

Thanks!

Easy thing to miss; inheritance is such a fickle mistress. ;)
This has fixed our sizing issues with both MudField and Mask.
Thanks so much for the quick fix @danielchalmers!

@gabephudson No problem, it was a lot easier thanks to your detailed comment!


BUG: use uarray static strings to prevent negative refcounts in free-threaded Python

Reference issue

Fixes gh-21214
What does this implement/fix?

This PR addresses the segfaults caused by the occurrence of negative refcounts when uarray static strings were being released when the interpreter didn't exist.
Additional information
This applies the comments of @albanD in the reference issue

This will fix your issue, but I want to make sure there is no misunderstanding.
The problem here is really that we call decref after the python runtime is dead.
There are two ways to avoid this:

In the destructor, only call decref if python is still in a good state
skip calling this destructor altogether (by storing a pointer instead of an instance)

Doing either of these would be enough to fix the issue. In this PR, you're doing both which is technically not necessary.

@colesbury @albanD the global variables are now pointers without destructors, please let me know if this works for you.
@rgommers, do you know who should I ping to request a review from someone in SciPy?

Shouldn't this PR be made upstream first, as this is vendored code? That should ping Hameer and Peter (the sole authors of this file).

@lucascolley I think reviewing here and upstreaming after is fine (the upstream repo doesn't have free-threaded CI).
@andfoy I'll have a look at this soon.

I would suggest keeping py_ref everywhere and surgically using an immortal wrapper around global state which will prevent the destructor from being called.

I'm happy with any outcome here that fixes the problem, and both solutions seem reasonable. I personally find the "don't use py_ref for globals, use plain PyObject's and leak them" rule a bit easier to understand than "use py_ref as a smart wrapper for everything, then add another wrapper for globals to avoid calling their destructor". Probably a matter of taste though. More code comments will help either way.

The problem is that the code is written with automatic decrefing in mind, so to do this change properly requires you to audit every single line of code to see if there is a potential leak introduced by moving to a dumb pointer. IMO limiting the change to only the global descriptor calls would be much less error-prone.

I also wonder if reverting https://github.com/Quansight-Labs/uarray/pull/256 might fix most of the issue? I guess the thread_local calls would still be incorrect though.

I guess the thread_local destructors would still be incorrect though.

Yeah, looks like it, not sure reverting that would help.

The problem is that the code is written with automatic decrefing in mind, so to do this change properly requires you to audit every single line of code to see if there is a potential leak introduced by moving to a dumb pointer. IMO limiting the change to only the global destructor calls would be much less error-prone.

That's a fair assessment, yes. @andfoy perhaps it's time to try the immortal approach that @peterbell10 proposes? Probably good to do in a separate PR to be able to compare, rather than changing this one completely.

I'll bump the milestone given that branching for 1.15.0 is imminent, with a brief explanation:

It doesn't matter too much because this is a bug fix and bug fixes are generally the main types of backports we do anyway.
The discussion above is complex, and involves folks that I know work more on low-level C/C++-matters than I do, and it hasn't quite reached a conclusion--now at the point where exploring an alternative approach has been requested for comparison. So merging would likely be premature.


Compare a report to an atom feed

Sounds like the same issue than #30. This bug is fixed and available in the nightly builds. This iteration of the nighly buillds should be equivalent to the next release (1.8) and include a few fixes for the CsvReader (compared to the iteration built a few days ago).


Fix navbar wrapping between 997 and 1157px

name: Bug fix
about: Fixing a styling problem with Redux website
PR Type
Does this PR add a new feature, or fix a bug?
Fix a bug. Resolves #3839
Why should this PR be included?
Without this PR the navbar items will wrap between 997 and 1157px.
Checklist

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Is there an existing issue for this PR?

Resolves #3839

[x] Have the files been linted and formatted?
[ ] Have the docs been updated to match the changes in the PR?
[ ] Have the tests been updated to match the changes in the PR?
[x] Have you run the tests locally to confirm they pass?

Bug Fixes
What is the current behaviour, and the steps to reproduce the issue?
Website navbar overflows between 997 and 1157px. Can be viewed on any browser.
What is the expected behaviour?
Navbar items shouldn't wrap if this behaviour breaks layout and impedes user interaction.
How does this PR fix the problem?
PR will modify the flex-wrap rule on the navbar to keep items on one line.

Thanks!


[Feature] CheckItem with Data

CheckItem should store data and this data also available to set from MixDialog#Builder

Feature is available on v2.0.1


Add mempool txs for getUtxosForAmount and getUnusedAddress

Description
This PR adds mempool txs for getUtxosForAmount and getUnusedAddress which allows for the creation of multiple swap transactions without txn-mempool-conflict
Submission Checklist :pencil:

[x] Add mempool txs for getUtxosForAmount and getUnusedAddress

I've created a development branch from Master, and merged this pr with it. Closing


Arrays with numeric keys are not correctly displayed

I have this message in my log file
[2024-03-13 12:57:30] local.DEBUG: This is a log message {"array":{"10":"value1","20":"value2"}}
In the log viewer this message is displayed like

As you can see the numeric keys are gone in the log viewer.

hey @jarno-hh , thanks for the bug report and the clear instructions :) Was easy to reproduce and it is now fixed in the latest versions of both v2 (v2.6.0) and v3 (v3.6.0) of Log Viewer.


[FEATURE] Setting proper flags in c_cpp_properties.json

Currently on Linux the intellisense is annoyed by the clock_gettime(CLOCK_MONOTONIC, &now); situation.
This fix is simple actually and requires a simple change to cStandard to be set to gnu17 instead of c17

Thank you for this! Was also able to resolve this by adding _GNU_SOURCE to defines.


Saving files (directory not in tree)

I'm saving a file on jupyter (deployed on heroku).
I cannot see the saved file in the local working tree.
However, the program is able to read the file.
This is odd. I'd like to be able to see the files I save and download them locally.
Any help is appreciated.

Depends on quantopian/pgcontents#28. You could try using Python 2.

@gmaijoe Today I retried the standard configuration and saving works fine now.
Can you check if you problem is still existing?

Closed. Seem to be no issue.

Closed. Seem to be no issue.


schema, ovs: Change bridge VLAN schema

Sync the OVS bridge port vlan schema with the one of the Linux bridge.
As the port vlan has never been implemented, this change is backward
safe and requires no production code changes.

Coverage increased (+7.4%) to 70.717% when pulling 5ca35e0eac8fba1482ab903160c665f4d1630f30 on EdDev:ovs-bridge-port-schema into b8e180851a9c6f7ed778c93b34656dc80810531f on nmstate:master.


dhcp-proxy: use better error when connection fails

Wrap the tonic status errors in the netavark error type, this allows us to create better error messages.
Also a bit complicated but special case when the socket is not found and return a message to consider enabling the netavark-dhcp-proxy.socket. old error:
unable to obtain lease: status: Internal, message: "transport error", details: [], metadata: MetadataMap { headers: {} } new error:
unable to obtain lease: socket "/run/podman/nv-proxy.sock": No such file or directory (os error 2), is the netavark-dhcp-proxy.socket enabled?

yeah code LGTM

/lgtm


Switch to uv

Working attempt at #32530
Before we switching, we're waiting on:

[ ] multi-platform locking https://github.com/astral-sh/uv/issues/3347
[ ] doesn't install all the dependency groups, but maybe that's just the poetry ones?

@maxime-desroches ready to close this?


Trying to incorporate trt_yolov3.py script in another python script

Hello,
I am trying to be able to call the trt_yolov3.py script from inside another python script while passing arguments like it currently takes from the command line. I am able to import trt_yolov3 however I don't know how I can pass arguments to the main function within a python script, would I have to modify the code so that the main function takes in parameters?

There are multiple ways to solve your problem.  For example, you could use SimpleNamespace to replace args in the original code:
def trt_yolov3_main(args):  # rename main() as trt_yolov3_main() to avoid function name collision
    # args = parse_args()  -> comment out this line
    if args.category_num <= 0:
        raise SystemExit('Bad category_num: %d!' % args.category_num)
    ......

In your own code, initialize "args" with SimpleNamespace:
from types import SimpleNamespace

args = SimpleNamespace()
args.use_file = True
args.filename = 'test.mp4'  # use this video file as input
args.model = 'yolov3-416'
trt_yolov3_main(args)


Architecture as Code - Working Group Meeting - Tuesday 24th September

Date
Tuesday 24th September - 11:00 EST / 16:00 BST
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene, roll call, welcome new people
[x] Approve previous meeting minutes
[ ] OSFF Reminder (@dc-ms)
[ ] Observable, Secure Architectures: Using FINOS Architecture as Code (@jpgough-ms / @nickebbitt)

We're fortunate to have Jim and Nick give us a preview of their ScotSoft presentation.

[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom info
Join Zoom Meeting

https://zoom.us/j/94904595244
Meeting ID: 949 0459 5244
Passcode: 545224
Find your local number: https://zoom.us/u/aesEqmNODb

Github Repo: https://github.com/finos/architecture-as-code/
Project Board: https://github.com/orgs/finos/projects/98
Mailing List: Email<EMAIL_ADDRESS>to subscribe to our mailing list

Yan Tordoff/Morgan Stanley

Fleur Edwards | Nomura

Karl Moll / FINOS

Denis Coffaro / Morgan Stanley

Amit Popat | Nomura

Aidan McPhelim / Morgan Stanley

Leigh Finegold/ Morgan Stanley

Matt Smith | Red Hat

Matthew Gardner / Morgan Stanley

Jonathan Smith / Azure Open Source Incubations, Microsoft

Konadu Appiah / Turntabl

Joe Giordano | Red Hat

Dario Bevilacqua LSEG

Unfortunately I couldn't make this - is there a recording link posted anywhere?

The recording has been posted to our docs - https://finos.github.io/architecture-as-code/talks/

Elisha Amenuveve | Turntabl

The recording has been posted to our docs - https://finos.github.io/architecture-as-code/talks/

Thank you Matt!!!!
Mark

James Gough / @jpgough-ms

Approved at https://github.com/finos/architecture-as-code/issues/627


Add Withdrawals to CompleteBlockTask

Duplicate of https://github.com/hyperledger/besu/issues/4976


Help needed - Days interval grouping in distributed bar chart

Hi all,
I have a requirement to draw a distribution bar chartin Superset. Its Schema is of customers and product purchase for different purchase dates. In this case, product is not relevant. The schema is like this:
Customer_name   Purchase_amount   Purchase_date
A                16500             10-15-2019
A                1200              3-9-2019
B                7800              2-25-2020
B                5300              8-19-2019
C                12000             5-14-2019
D                6500              1-19-2020
In Bar chart, need to show 'day interval' in groups of 30 days in X axis. The 'day interval' means the day difference between today's date and 'Purchase_date'. I tried to create one more column in sql query to find out the 'day interval group' like 0-30, 31-60 etc. Then created the chart. It looks fine. But the ordering is based on the amount. But I want it in  the order of 'day interval'.

Thanks in advance,
Sreedevi

In the customize tab you have an option to sort based on the series.

However you have to have the intervals sorted. In my example you can see that I add 1-<30 days, 2-30-60 days, etc.
I am not sure how you did the interval section. In my example :
1- I took your data and loaded in a table
CREATE TABLE sales_test (
	customer VARCHAR(10)
	,ammount NUMERIC(9, 2)
	,sales_date DATETIME
);

2- I created a view at the top of the table to calculate the interval with Sysdate() so it is updated
CREATE VIEW sales_test_interval AS
SELECT *
	,datediff('day', sales_date, sysdate()) AS sales_interval
FROM sales_test;

3- I use Calculated fields in superset to put the interval in 'buckets'

It is just a case statement that most query engine accept
CASE
		WHEN sales_interval <= 30
			THEN '1- < 30 Days'
		WHEN sales_interval BETWEEN 31
				AND 60
			THEN '2- 30-60 days'
		WHEN sales_interval BETWEEN 61
				AND 180
			THEN '3- 60-180 days'
		WHEN sales_interval > 180
			THEN '4-More 180 Days'
END

HTH.

Note: that you could had done step 2 and 3 in just one step in the DB view or in Superset Calculated field.

🗑🏷 #question

🏷 🗑 #question

🏷 bug

Thanks eugeniamz for the detailed reply and the effort you spent for this.
I also did the same steps. I also used case when for finding out the interval buckets. Steps 2 and 3 are done in the view itself. The difference between my approach and yours, is in the interval bucket labels. You created the interval buckets like 1- <30 days, 2 - 30-60 days etc. I created like 0-30, 31-60, 61-90, 91-120, 121-150, 151-180, 180+ . I think Superset is correctly ordering your labels since it starts with 1, 2 etc. In my case, it orders like 0-30, 121-150, 151-180, 180+, 31-60, 61-180 . This is the issue. I need it like in the following order itself - 0-30, 31-60, 61-90, 91-120, 121-150, 151-180, 180+ . I tried it by adding the prefix with the labels like 1 - 0-30, 2 - 31-60 etc. Its working , but as per the client, label should not have the prefix numbers. Please give your suggestions.

In the moment that you add '-' between the numbers it will be considered a String and it will be sorted as String.
The other option will be to add a '.' instead of '-' so it will still be a number and it will be sorted as such. For example :

Make sense?

Hi eugeniamz,
Got the issue of putting '-' in the data and string sorting. But if we change hyphen to dot, then also there is a problem. We won't be able to give 180+.
Is there any other type of charts that supports this requirement and allow us to group days. I am a newbie to Superset and last month, I got another requirement like this. Then I tried this kind of alternatives and got a workaround. But later on I saw there is an option in Superset to create time series bar chart and it supports my requirement. Then I changed the previous work-around and changed the chart type from bar chart to time series bar chart. Any suggestions?
Thanks,
Sreedevi

Also the requirement is done in Microsoft excel by client. Sorting is working fine in charts created in excel sheet. So he believes there is a similar straight forward option in Superset.


[AMHACK] Could not generate an access token with a scope as scope is not available

Description:
Unable to add a scope to a application as mnetioned in [1]
[1]  https://docs.wso2.com/display/AM210/Subscribe+to+an+API
Suggested Labels:
Bug
Affected Product Version:
APIM wum updated - wso2am-<IP_ADDRESS>0928473100.zip
OS, DB, other environment details and versions:
Standalone
DB - H2
Browser - Chrome Version 58.0.3029.96 (64-bit)
Steps to reproduce:

Create an API
Create an application and subscribe the API to the application
generate access token with a scope as mentioned in [1]

[1] https://docs.wso2.com/display/AM210/Subscribe+to+an+API
Observations
The option is disabled. (ex: showing No scopes found in the field )

In your steps you haven't mentioned about registering a scope to the API. you need to create a scope and assign it to the API. If scopes are not set for the api, scopes won't be shown in the token generation page. So please set a scope and check this.


Two seemingly same structures different

I have two structures:
NEXT Map { "entries": List [ "Trainspotting" ], "vote": Map { "pair": List [ "Brak", "Forest Gump" ], "history": List [ Map { "X": 3, "Y": 1 }, Map { "Trainspotting": 3, "Shawshank": 1 } ] }, "key": "val" }
EXPE Map { "entries": List [ "Trainspotting" ], "vote": Map { "pair": List [ "Brak", "Forest Gump" ], "history": List [ Map { "X": 3, "Y": 1 },Map { "Trainspotting": 3, "Shawshank": 1 } ] }, "key": "val" }

So they are seemingly the same (note the missing space in bottom one). But when I run toJSON() method on them:
 AssertionError: expected { Object (entries, vote) } to equal { Object (entries, vote) }
      + expected - actual

                   "ownerID": {}
                 }
                 "size": 2
               }
      +        {
      +          "__altered": false
      +          "__hash": [undefined]
      +          "__ownerID": [undefined]
      +          "_root": {
      +            "entries": [
      +              [
      +                "Trainspotting"
      +                3
      +              ]
      +              [
      +                "Shawshank"
      +                1
      +              ]
      +            ]
      +            "ownerID": {}
      +          }
      +          "size": 2
      +        }
             ]
      -      {
      -        "Shawshank": 1
      -        "Trainspotting": 3
      -      }
           ]
           "pair": [
             "Brak"
             "Forest Gump"

The piece of code that changes the Map is:
  const tally = voteState.has('tally') ? voteState.get('tally') : false;
  console.log('TALLY', tally); // TALLY Map { "Trainspotting": 3, "Shawshank": 1 } <--- so it's a map

  const resultState = state
    .setIn(['vote', 'pair'], entries.take(2))
    .setIn(['entries'], entries.skip(2))
    .removeIn(['vote', 'tally']);
  if (tally) {
    return resultState.updateIn(['vote', 'history'], new List(), history => history.push(tally)); // <---- it's somehow turned into plain JS object here?
  }

What am I doing wrong? It seems like a bug. (note the missing space in the dumped structure in first code block.
The full code can be seen in https://github.com/tomasfejfar/redux-voting/commit/d76b11f4e6cce5b364afa0638291b4e57bc21746

Can you share the explicit piece which is performing the toJSON and comparison? It appears that one side of the comparison is peering into the implementation-details of a Map instance, while the other is a JS Object.

It's here https://github.com/tomasfejfar/redux-voting/commit/d76b11f4e6cce5b364afa0638291b4e57bc21746#diff-28a6632d75cca173e3381ccb03a73e50L73

Closing this aging issue - I hope you were able to solve this. If not, please feel free to open a new issue with a minimal failing test case.