JAVA-1287: Add CDC to TableOptionsMetadata and Schema Builder

In support of CASSANDRA-12041, add support for parsing cdc from table
options and add support for specification using schema builder.
For JAVA-1287.

👍
It's odd because the C* ticket also mentions a syntax change for keyspaces, e.g.:
CREATE KEYSPACE ks WITH replication... AND cdc_datacenters= {'dc1','dc2'...};
ALTER KEYSPACE ks DROP CDCLOG;

But I couldn't find any reference to these changes in the current C* trunk, so I guess it's been abandoned.

But I couldn't find any reference to these changes in the current C* trunk, so I guess it's been abandoned.

I'll look into that, I would think there should still be a way to drop the existing logs, maybe it's not done through CQL now.

I'll look into that, I would think there should still be a way to drop the existing logs, maybe it's not done through CQL now.

Didn't find anything in the C* commit other than the with CDC option for CQL, also didn't see any other way to drop the cdclogs from what I can tell.

Changed base to 3.x, make sure you use that branch for future rebases.


Added italian stopwords

Hi,
I've added the support for italian stopwords. The added stopwords come from the nltk corpus

Hi @prof18! Thank you for your contribution!


feat: [hca db] create component for displaying three buttons in a row  (#697)

Ticket
Closes #697
Reviewers
@NoopDog
Changes

Added components in preparation for displaying three buttons in a row.
Refactored the content MDX name for generated matrices text.

@NoopDog this PR is dependent on https://github.com/clevercanary/data-explorer/pull/20


ListView separatorColor="transparent" don't work

Environment
✔ Component nativescript has 6.8.0 version and is up to date.
✔ Component tns-core-modules has 6.6.0-next-2020-05-08-112112-01 version and is up to date.
✔ Component tns-android has 6.5.3 version and is up to date.
✔ Component tns-ios has 6.5.2 version and is up to date.
Describe the bug
I have my ListView inside ScrollView using ng-template to render dynamic content.
I'm trying to remove the separatorColor with all the methods I know but no one works.

Expected behavior
I would like to remove the separator line between the elements in my ListView
Sample project
<ScrollView row="1" col="0">
            <ListView height="100%" [items]="menuItems" (itemLoading)="onItemLoading($event)" android:listSelector="@android:color/transparent" separatorColor="transparent">

                <ng-template nsTemplateKey="defaults" let-item="item">
                    <StackLayout orientation="vertical">
                        <GridLayout [id]="item.id" [class.-selected]="item.selected" columns="*" rows="auto, *" (tap)="onNavItemTap($event)">
                            <ImageCache col="0" row="0" styling="image" placeHolder="res://menu" errorHolder="res://menu" fallback="res://menu"
                                stretch="fill" width="50" height="50" [src]="item.icon"></ImageCache>

                        </GridLayout>
                    </StackLayout>
                </ng-template>

                <ng-template nsTemplateKey="webViews" let-item="item">
                    <StackLayout orientation="vertical">
                        <GridLayout [id]="item.id" [class.-selected]="item.selected" columns="*" rows="*" (tap)="onNavItemTap($event)">

                        </GridLayout>
                    </StackLayout>
                </ng-template>

            </ListView>
        </ScrollView>

Additional context
Thanks all for the support.

UP!

Please have a news or solutions?
Thks.

UP!

working fine...


EventStore StreamProvider?

Was looking into EventStore and then came across Orleans, looks like it could be a nice match and it appears you have made some great progress with this repo.
Have you investigated at all supporting Orleans streaming on EventStore by chance?

Hi. Support for Event Sourcing has been integrated into the main Orleans repo but hasn't been released yet. It contains extensibility point in a form of a provider. Once it's released this report will become obsolete and you will be able to create a provider for your favourite event store. I plan to create one for GetEventStore and Streamstone.

Very cool.  Glad to hear it.


Migration Jenkins Build from Freestyle Job to Jenkins Pipeline.

This PR aims to migrate our current Build from Jenkins Freestyle Job to Jenkins Pipeline.
This PR only target master and same kind of modification should be done to 1.x branch. It will be done in another PR.
Why?

Eclipse IT are planning to recommend switching to Jenkins pipelines soon and will eventually stop supporting freestyle builds.
(Build-)configuration-as-code has become an industry best practice, so overall support for freestyle jobs is fading away.
This allow to reduce the number of Jenkins Job. (using multi-branch-pipeline)

source :

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3435#note_1185195

Solution:
Each branches we need to build will contains a .jenkins folder containing :

ci.jenkins file : describe how to build the branch for continuous check.
nightly.jenkins file : describe how to release nightly to eclipse repository.
release.jenkins file : describe how to release stable/milestone version to maven central.

Documentation :

https://www.jenkins.io/doc/book/pipeline/
https://wiki.eclipse.org/Jenkins

Temporary jobs to test :

https://ci.eclipse.org/leshan/job/leshan-mbp/ to test ci.jenkins
https://ci.eclipse.org/leshan/job/leshan-mbp-nightly/ to test nightly.jenkins.
https://ci.eclipse.org/leshan/job/leshan-bp/ to test release.jenkins

LGTM


Can't create secret via bicep

Bicep version
Bicep CLI version 0.4.613 (d826ce8411)
Describe the bug
I can't create keyvault with secret:
{"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"NotFound","message":"{\r\n  "error": {\r\n    "code": "BadRequest",\r\n    "message": ""\r\n  }\r\n}"}]}}
To Reproduce
resource footestkv 'Microsoft.KeyVault/vaults@2019-09-01' = {
name: 'footestkv'
location: resourceGroup().location
properties: {
tenantId: subscription().tenantId
sku: {
family: 'A'
name: 'standard'
}
enabledForTemplateDeployment: true
accessPolicies: [
]
}
resource foosecret 'secrets@2019-09-01' = {
name: 'foosecret'
properties: {
attributes: {
enabled: true
}
value: 'foo'
}
}
}

Ok my mistake, it works now.


Crash on startup

Describe the bug
With forgified fabric enabled it crashes
Steps to reproduce

start the game
crash

Logs
https://paste.ee/p/BSNPY
Additional context
probably a mod incompatibility, i can't tell though

Forgified Fabric API requires Forge 47.1.3, as described in #15

oh mb thx


requirements.txt error

hi , i keep getting this error when trying to sudo requirements..... i need help asap

i have even tried installing feedparser but the same error still occurs

I have the same error! Only i can't even install the requirements.
See my issue: https://github.com/HackerHouseYT/Smart-Mirror/issues/82

I ran this command and it fixed it for me.
pip install -r requirements.txt --user


ci: migrate to shared workflows

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Long time to delete playlist

https://forums.slimdevices.com/showthread.php?109624-Announce-Material-Skin&p=948777&viewfull=1#post948777

I am not getting consistent behavior, but when it fails to delete a recently created playlist, I get a popup that says: Failed to delete playlist! (Error: Network Error)

Craig, I might owe you a huge apology. This issue might have been entirely of my own making. My server is using Ubuntu 18.04 OS, which might be involved but regardless, I had the plugin AutoRescan running, with a delay of 5 seconds.
Running AutoRescan appears to conflict with adding and deleting playlists, and may have nothing to do with Material at all.
Additionally, I have my Playlist folder inside my FLAC music folder, which might be a blunder on my part as well.

He he :) no problem. Would explain why I've not seen the issue...

I think this can be closed, as it appears to work as long as a scan is not going on while trying to save or delete a playlist. However, is it possible to give a more descriptive error message that explains that the operation should be tried again later, that a scan of the user's library is in progress?

Done :-)


Add maintenance notes for this recipe

Just added a README file under the recipe/ dir. No need to bump the build number.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


merge PR#14, add support for protobuf, format on save now works and etc.

these code has merged PR#14 and add some more functions. That's

add protobuf support(work with https://marketplace.visualstudio.com/items?itemName=peterj.proto)
allow different style & fallback style option for different languages
format on save is available now(just like https://github.com/Microsoft/vscode-go/blob/master/src/goMain.ts)

@xaverh , I have tested in my vscode, but please review the code because there are many changes.

Is there anything I can do to assist with making a new release?  I am sorry to bug you but I'm eager to use the new version.  :)

@martine I don't  know the release plan of @xaverh ,but you can build this plugin yours self and replace the directory in $HOME/.vscode/extensions/xaver.clang-format-0.6.1 for temporary use.
$HOME is c:\Users\[UserNanme] in Windows 7 or later.

I pushed the new version to the marketplace. Apologies for the delay, I had a very busy week. Thank you very much for your valuable contributions!

Does formatting on protobuf still works? Why doesn't it work for me? Is there any dependency that I need to install to make it work?

I never used Protobuf, so I do not really know. Have you installed https://marketplace.visualstudio.com/items?itemName=peterj.proto as well?

Protobuf support is required if you want to format .proto files.
It works well and I have used it for a long time.

@owt5008137
I know why now, I have vscode-proto3 installed, and it seems like to have conflicts,
Any chance of making them compatible? The vscode-proto3 has better highlighting.

This plugin registers protobuf as Language:proto3 but not Language:proto. I will try to adapt it later.
After tested, I will create another RP.

@owt5008137 Thank you so much!

@willdzeng #41 has been pushed and please wait for next release of this plugin.
@xaverh

... and is also available in the marketplace right now


allow to add additional attributes and tags to autoscaler

what
This is to avoid adding a region prefix to dynamodb tables because the autoscaler IAM role requires additional region indicator in its names
why

IAM policies and roles need to be unique
DynamoDB tables should not have a region indicator as they are regional

/codefresh run test

@etwillbefine why not just pass required tags directly using attributes and tags? Why do you need separate variables to merge with existing attributes and tags?

Because only the autoscaler module conflicts with its IAM roles when deploying multiple modules into different regions. Usually the dynamodb table itself does not need to have a "region indicator". But the IAM roles do need a prefix for the region in role names. Thats why I intend to pass additional tags to the autoscaler only

/rebuild-readme

@etwillbefine thanks!
please rebase

/rebuild-readme

@etwillbefine thanks!
please rebase

I had one confusing commit from the actions bot in the History, which I removed. Can someone rebuild the README automatically?

/rebuild-readme

/test all

need someone with admins permissions to merge this PR
@aknysh @osterman


apply new line

the latest version makes {"status" => "abc\\ndef"} from -d "status=abc\ndef"

Can you explain the purpose of this (admittedly old) PR? Thanks!


 If not, let me know, I might've missed something on my most recent release. (I rewrote a bunch of stuff)

rolling back to beta.9 made it work..
Thanks

Odd... I've only seen the "Task does not support cancellation, or is already canceled." error on versions above beta.9. The demo is using beta.9 and doesn't throw that error on close. I wonder what could be different.
When you downgraded your angular version to beta.9 did you also downgrade your zone.js to 0.5.15? I think beta.12 relies on 0.6.5 and the "Task does not support cancellation, or is already canceled." error is related to zone.js.

Aww yes the magical dance of version matching.. downgrading zone.js to 5.15 worked.
to close this out final versions used with this version: 0.4.2
"angular2": "2.0.0-beta.9",
        "bootstrap": "^3.3.6",
        "es6-promise": "^3.1.2",
        "es6-shim": "^0.35.0",
        "font-awesome": "^4.5.0",
        "reflect-metadata": "0.1.3",
        "rxjs": "^5.0.0-beta.3",
        "systemjs": "^0.19.24",
        "zone.js": "0.5.15",

Thanks

I'm getting this too.
  "dependencies": {
    "angular2": "2.0.0-beta.9",
    "es6-module-loader": "^0.17.8",
    "es6-shim": "^0.33.3",
    "ng2-bootstrap": "^1.0.5",
    "ng2-cookies": "^0.1.4",
    "ng2-file-upload": "^1.0.0-beta.1",
    "reflect-metadata": "0.1.2",
    "rxjs": "5.0.0-beta.3",
    "systemjs": "~0.19.24",
    "underscore": "^1.8.3",
    "ws": "^1.0.1",
    "zone.js": "^0.5.15"
  }

angular2.js?1459916752966:23597 TypeError: this.$modal.appendTo(...).modal is not a function
    at ModalInstance.init (http://localhost/node_modules/ng2-bs3-modal/components/modal-instance.js:50:38)
    at new ModalInstance (http://localhost/node_modules/ng2-bs3-modal/components/modal-instance.js:12:14)
    at ModalComponent.ngAfterViewInit (http://localhost/node_modules/ng2-bs3-modal/components/modal.js:27:25)
    at AbstractChangeDetector.ChangeDetector_TasksForm_0.afterViewLifecycleCallbacksInternal (viewFactory_TasksForm:579:82)
    at AbstractChangeDetector.afterViewLifecycleCallbacks (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8206:12)
    at AbstractChangeDetector.runDetectChanges (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8145:14)
    at AbstractChangeDetector._detectChangesInViewChildren (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8218:14)
    at AbstractChangeDetector.runDetectChanges (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8143:12)
    at AbstractChangeDetector._detectChangesInViewChildren (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8218:14)
    at AbstractChangeDetector.runDetectChanges (http://localhost/node_modules/angular2/bundles/angular2.js?1459916752966:8143:12)

@nikkwong what version of ng2-bs3-modal are you using?

No response, closing issue.

Please open a new issue if you are still experiencing problems.

having same issue
EXCEPTION: Error in ./UsersDetails class UsersDetails - inline template:1:2 caused by: this.$modal.appendTo(...).modal is not a function
  ErrorHandler.handleError
  next
  schedulerFn
  SafeSubscriber.__tryOrUnsub

with angular-cli
any ideas?


Incorrect Endpoint sample

Endpoint file instructions define 7 columns, yet the field order and example are with 6 fields which is incorrect:
"There must be seven columns for each row and the columns must be in the following order:
Field order:
EndpointName, EndpointModel, EndpointType, EndpointLabel1, EndpointLabel2, EndpointLabel3"

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb8d8b48-561b-6817-1ce0-4b2aedc261a8
Version Independent ID: dfd5cf4a-509a-3ed1-0267-6281c251fbef
Content: Turn on and use Call Quality Dashboard
Content Source: Teams/turning-on-and-using-call-quality-dashboard.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@bilginbaldji  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @bilginbaldji, thank you for your feedback.
I'm adding a column (Endpoint Make).

@bilginbaldji Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


[Feature] Integrate Maps on User Page

Maps should be integrated with the user's location. An editable text location should also show on the web page.

Partially working #113


tsc -b parse time is much higher comparing to tsc -p when there is a big d.ts file in node_modules

Bug Report
Using a third-party package with heavy .d.ts files (eg aws-sdk) slows down tsc -b drastically comparing to tsc -p compilation time.
Comparison of the tsc extendedDiagnostics:

tsc -b api/tsconfig.json -w --preserveWatchOutput (or run npm run dev:api:b)
Much slower after adding a change to the code (eg console.log in a TS file).

Files:                         412
Lines of Library:             8664
Lines of Definitions:       577202
Lines of TypeScript:            34
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Nodes of Library:            23282
Nodes of Definitions:      1689642
Nodes of TypeScript:           137
Nodes of JavaScript:             0
Nodes of JSON:                   0
Nodes of Other:                  0
Identifiers:                626998
Symbols:                    367869
Types:                         261
Instantiations:                276
Memory used:               512906K
Assignability cache size:       29
Identity cache size:             1
Subtype cache size:             10
Strict subtype cache size:       0
I/O Read time:               0.24s
Parse time:                  2.67s
ResolveModule time:          0.09s
ResolveTypeReference time:   0.00s
Program time:                3.18s
Bind time:                   0.93s
Check time:                  0.04s
transformTime time:          0.02s
commentTime time:            0.00s
printTime time:              0.04s
Emit time:                   0.04s
Source Map time:             0.00s
I/O Write time:              0.00s
Total time:                  4.20s

tsc -p api/tsconfig.json -w --preserveWatchOutput (or run npm run dev:api:p)
Much faster after adding a change to the code (eg console.log in a TS file).

Files:                         412
Lines of Library:             8664
Lines of Definitions:       577202
Lines of TypeScript:            34
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Nodes of Library:            23282
Nodes of Definitions:      1689642
Nodes of TypeScript:           137
Nodes of JavaScript:             0
Nodes of JSON:                   0
Nodes of Other:                  0
Identifiers:                626998
Symbols:                    367869
Types:                         261
Instantiations:                276
Memory used:               513037K
Assignability cache size:       29
Identity cache size:             1
Subtype cache size:             10
Strict subtype cache size:       0
I/O Read time:               0.00s
Parse time:                  0.00s
ResolveModule time:          0.00s
Program time:                0.01s
Bind time:                   0.00s
Check time:                  0.05s
transformTime time:          0.02s
commentTime time:            0.00s
printTime time:              0.05s
Emit time:                   0.05s
Source Map time:             0.00s
I/O Write time:              0.00s
Total time:                  0.11s

🔎 Search Terms
tsc, typescript compiler, build mode, watch mode
🕗 Version & Regression Information
Tested on typescript 3.9.3, 4.4.2, 4.4.3. Same behaviour.
⏯ Playground Link
https://github.com/zofiag/tsc-test - it is a super simple repo project with almost no code, except for the aws-sdk dependency installed that seems to drastically slow down the compilation in build mode.
After cloning the repo, run npm install and:
run npm run dev:api:b for the tsc -b compilation
run npm run dev:api:p for the tsc -p compilation
💻 Code
Project structure:
api/tsconfig.json
{
  "extends": "../tsconfig.base.json",
  "compilerOptions": {
    "rootDir": "src",
    "outDir": "dist"
  },
  "include": [
    "src"
  ],
  "references": [{
      "path": "../libs/shared"
  }]
}

api/src/aws-encryption.ts
import type { KMS } from "aws-sdk";

export class AwsEncryption {
  constructor(private readonly kms: KMS) {}

  encrypt(): Promise<string> {
    return new Promise((resolve, reject) => {
      this.kms.encrypt({ KeyId: "", Plaintext: "" }, (err, data) => {
        if (err) {
          reject(err);
        } else {
          resolve("ok");
        }
      });
    });
  }

  decrypt(): Promise<string> {
    return new Promise((resolve, reject) => {
      this.kms.decrypt({ KeyId: "", CiphertextBlob: "" }, (err, data) => {
        if (err) {
          reject(err);
        } else {
          resolve("ok");
        }
      });
    });
  }
}

shared/tsconfig.json
{
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
    "rootDir": "src",
    "outDir": "lib"
  },
  "include": [
    "src"
  ],
  "references": []
}

tsconfig.base.json
{
  "compilerOptions": {
    "sourceMap": true,
    "strict": true,
    "moduleResolution": "node",
    "module": "commonjs",
    "esModuleInterop": true,
    "skipLibCheck": true,
    "target": "es6",
    "lib": [
      "es2020"
    ],
    "noFallthroughCasesInSwitch": true,
    "noImplicitReturns": true,
    "noUncheckedIndexedAccess": true,
    "forceConsistentCasingInFileNames": true,
    "allowSyntheticDefaultImports": true,
    "allowJs": false,
    "resolveJsonModule": true,
    "isolatedModules": true,
    "declaration": true,
    "composite": true,
    "incremental": true
  },
}

🙁 Actual behavior
Running tsc -b -w is much slower (total time 4.20s) than tsc -p -w (total time  0.11s). The library that seems to be slowing it down is aws-sdk package which is the only dependency in this small repro project.
Why would the same package be parsed much slower in the build mode?
🙂 Expected behavior
Compilation time after adding a change (eg console.log in the TS file) should be nearly the same between tsc -b -w and tsc -p -w when there are no project references specified.

Duplicate of https://github.com/microsoft/TypeScript/issues/45082


Add reports - I cracked

@jamesjefferies I don't think we have the resources to maintain these as we add to the alerts process and adding them sets a bad precedent.


Organize EDA methods into folders

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes
Look #710. Folders were changed a little.
Closing issues
Closes #710.

Codecov Report

Merging #1198 (0c4a0ce) into master (0b3229a) will decrease coverage by 79.80%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master   #1198       +/-   ##
==========================================
- Coverage   87.52%   7.72%   -79.80%
==========================================
  Files         166     185       +19
  Lines       10137   10548      +411
==========================================
- Hits         8872     815     -8057
- Misses       1265    9733     +8468

Impacted Files
Coverage Δ

etna/analysis/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/analysis/decomposition/__init__.py
0.00% <0.00%> (ø)

etna/analysis/decomposition/plots.py
0.00% <0.00%> (ø)

etna/analysis/decomposition/search.py
0.00% <ø> (ø)

etna/analysis/decomposition/seasonal_plot.py
0.00% <0.00%> (ø)

etna/analysis/eda/__init__.py
0.00% <0.00%> (ø)

etna/analysis/eda/plots.py
0.00% <0.00%> (ø)

etna/analysis/eda/utils.py
0.00% <0.00%> (ø)

etna/analysis/feature_relevance/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/analysis/feature_relevance/plots.py
0.00% <0.00%> (ø)

... and 6 more

... and 164 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Calculator JEI Recipes not working

Issue Description:
So, I noticed that after recent updates, JEI doesn't show changed Calculator recipes anymore even though the recipes work. I tested around a little bit and noticed that the latest CraftTweaker update breaks it, with 3.0.16 everything seems to work fine, but with 3.0.17 JEI doesn't show the recipes anymore. I already let the Calculator dev know as he did the CraftTweaker integration himself as I can see, but as the CraftTweaker update broke it (as I just found out), I want to you let know. Maybe you can figure out what's wrong and if necessary contact Ollie Landsdell if he has to change something to make it work again.
What happens:
Calculator recipe changes don't show up in JEI anymore, neither removed recipes are removed, nor added recipes are added even though the recipe changes work.
What you expected to happen:
That JEI reflects those changes
Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):
http://pastebin.com/yzVdHrLj
(for adding the recipe you need Immersive Engineering)
Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):
http://pastebin.com/QcWu0exh

Affected Versions (Do not use "latest"):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>2
Crafttweaker: 3.0.17
Calculator: 3.1.5
SonarCore: 3.2.0
JEI: <IP_ADDRESS>1

Your most recent log file where the issue was present:
https://gist.github.com/davqvist/0b70ef21c4a43769692e459047411747

Post to Calculator github. The Minetweaker API changed and now mods need to update.


Dock icons for chrome and iterm are ?'s

I noticed that restarting the computer helps.

Try killall Dock

I see, these apps are not installed yet when we run the dock cleanup action.  I'll switch them around.
→ grep -n applications-com *sh
setup.sh:32:source ${MY_DIR}/applications-common.sh

  |2.3.1| rose in ~/workspace/workstation-setup/scripts
→ grep -n ion-osx *sh
setup.sh:28:source ${MY_DIR}/configuration-osx.sh


When selectorLink is upgrade to a selector link having "in" to link to more services , links to to new service are not aviailable.

Rancher Version: Build from master

Create service s3 with selectorLink foo=bar
Add service  s1 with label foo=bar
Add service  s2 with label foo=bar1
Activate service s3. Link to s1 is available.
Update service s3 and set selectorLink to foo in (bar,bar1)

s2 is not getting linked to s3.
Expected behavior:
s2 should get linked to s3 and S3 continue to be linked to s1.

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.


chore: only allow pnpm

I think may be we may add preinstall because here we have pnpm-lock.yaml that means we should install deps with pnpm only.

I don't think we need to add this as we already have packageManager set, and we tell people to run corepack enable before development

i think corepack already gives enough guards. it can break ability to test runtimes such as bun/deno even if without lockfile they are compatibile.

Oh, Thanks a lot @danielroe and @pi0 . I feel so lucky that you both comment on my PR 😄


Tracking issue for Darwin stdenv LLVM update

This is a tracking issue to update the version of LLVM in the Darwin stdenv. I am breaking this out of #229786 into a tracking issue so I can submit and track PRs for the work I have done while I work through the ofborg outPath check failures. The longer I wait, the greater the risk of merge conflicts.
This issue was prompted by #229210 because the 13.3 SDK requires a newer Clang than the Darwin stdenv provides currently. To facilitate easier LLVM updates in the future, I have created a PR to rework the Darwin stdenv to decouple it from the versions of programs included in the bootstrap tools. I have also reworked it to follow the patterns used in the Linux stdenv.
See the comments in PR explaining the rework. My hope is it will make maintenance easier and more approachable. It should also make experimentation a little safer due to evaluation-time failures that stop “obvious” mistakes from turning into wasted build time. Possible areas for future exploration: removing ICU (in favor of the icu in nixpkgs) and libiconv (in favor of libiconvReal), using LTO during bootstrap.
Previous PR

#229786

Rework Prerequisite PRs
These PRs are required for the stdenv bump. They reflect breakage due to stricter checks by clang or as required by the stdenv rework. Most of these PRs are required for clang 15. Some are required for clang 16. They should work with clang 11.

[x] #234859
[x] #234857
[x] #234869
[x] #234714
[x] #234870
[x] #234854
[x] #234855
[ ] #234861
[x] #235052

This PR was dropped.

#234856

LLVM Bump Prerequisite PRs
These PRs are not required for the rework, but they are required prior to the bump because it prevents the bootstrap from completing with clang 16.
Related PRs
These fail to build due to the changes or pertain to some other issue uncovered while working on the bump. They are not required for the bump, but they’ll make it go more smoothly after it is merged.

[ ] #234863
[ ] #235487
[x] #234866
[ ] #235498
[x] #235120
[ ] #235505
[x] #234715
[ ] #235501
[x] #234117
[x] #234219
[x] #235506
[x] #234865
[x] #234864
[ ] #234868
[ ] #235121
[x] #235503

This PR was dropped.

#234900

These are Darwin sandbox-related fixes. They’re not strictly necessary, but they allow Darwin users to build more things with the sandbox enabled.

[x] #234106
[x] #234119
[x] #234132
[x] #234129
[x] #234115
[x] #234111
[ ] #234122
[x] #234125

This fix is related to running the store on case-sensitive APFS. It’s the first thing that has broken for me. Most case sensitivity issues during builds are due to /tmp being insensitive.

[x]  #234105 (this fix should be included upstream in 1.11.2).

Things are looking pretty good, but alas I have another round of PRs that I’ll be opening up soon. Some of them are required for the stdenv rework while others are required for the actual bump. My current thinking is to bump to LLVM 16 because that will match what Apple will ship with Xcode 15. However, that requires fixing a number of packages to build with clang 16, which is more strict about function prototypes and some other stuff. Those are the additional PRs I will be submitting.
The only potential blocker with LLVM 16 is clang 16 sometimes fails with a bad file descriptor error. I think it has to do with the response file used to pass arguments to it in cc-wrapper. It usually succeeds if you run it again, so reproducing to debug and determine where the fix needs to go has been challenging.

@reckenrode it's a long shot, but is https://github.com/NixOS/nix/issues/6516 related to your bad file descriptor error? Only relevant if you're testing in CA mode.

@reckenrode it's a long shot, but is NixOS/nix#6516 related to your bad file descriptor error? Only relevant if you're testing in CA mode.

Unfortunately, probably not. CA mode doesn’t even work on aarch64-darwin. #178280 might be related. I haven’t really dug into it too deeply because I can restart the build when it happens. That’s not good for a final PR, but it lets me get everything else building before I try to dig into root causes. The big difference for me compared to NixOS/nix#6516 is it’s always the same FD (63). Bash’s process substitution starts counting at 63, which is why I believe cc-wrapper is involved. The question is why the FD doesn’t live long enough and what is trying to read it once it’s gone.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/darwin-again/29331/14

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/darwin-again/29331/16

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-macos-monthly/12330/40

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-macos-monthly/12330/41

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/macos-system-integrity-protection-and-dy-dl-library-path/31729/5

Linked some fix PRs ^ found from my home-manager failing to build from the branch. I'll do another batch soon.

Full report at https://gist.github.com/tobim/5ce3c6d6f49f29ac43b3ad76b96bd1e4.
 It’s heartening that the most severe offenders are fixed already on staging or have open PRs with fixes.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-macos-monthly/12330/44

The LLVM update has been merged into master.


Fix message after failed retry

We had a bug in the retry sequence where the tables that failed to extract were not listed in "keep going" mode. What we'd like to see is that we can run the extract pipeline (with --keep-going) and then see a list of failed relations which simplifies restarting the extract just for those relations that still need.
Testing
One way to test this it to create a new settings file like this:
{
    "arthur_settings": {
        "extract_retries": 2
    }
}

Then "break" the extract by setting a bad password or connection and observe:
INFO etl.monitor (extract-source_0) [monitor.py:202] Starting extract step for '...' (1/3)
DEBUG etl.util.retry (extract-source_0) [retry.py:29] Starting on first of 3 attempt(s)
WARNING etl.util.retry (extract-source_0) [retry.py:43] Encountered the following error, but retrying 2 more time(s) after 1 second sleep: failed to fetch table size for '...'
DEBUG etl.util.retry (extract-source_0) [retry.py:31] There are now only 2 of 3 attempt(s) left
WARNING etl.util.retry (extract-source_0) [retry.py:43] Encountered the following error, but retrying 1 more time(s) after 5 second sleep: failed to fetch table size for '...'
DEBUG etl.util.retry (extract-source_0) [retry.py:31] There are now only 1 of 3 attempt(s) left
WARNING etl.monitor (extract-source_0) [monitor.py:226] Failed extract step for '...' (7.23s)
WARNING etl.extract.sqoop (extract-source_0) [extractor.py:105] Extract failed for non-required relation '...':
Traceback (most recent call last):
  File "/opt/src/arthur-redshift-etl/python/etl/extract/sqoop.py", line 56, in extract_table
    table_size = self.fetch_source_table_size(source.dsn, relation)
  File "/opt/src/arthur-redshift-etl/python/etl/extract/database_extractor.py", line 151, in fetch_source_table_size
    with closing(etl.db.connection(dsn_dict, readonly=True)) as conn:
  File "/opt/src/arthur-redshift-etl/python/etl/db.py", line 103, in connection
    cx = psycopg2.connect(**dsn_values)
  File "/opt/local/redshift_etl/venv/lib64/python3.7/site-packages/psycopg2/__init__.py", line 127, in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
psycopg2.OperationalError: FATAL:  password authentication failed for user "etl"

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/src/arthur-redshift-etl/python/etl/util/retry.py", line 33, in call_with_retry
    func(*args, **kwargs)
  File "/opt/src/arthur-redshift-etl/python/etl/extract/sqoop.py", line 58, in extract_table
    raise DataExtractError("failed to fetch table size for '%s'" % relation.identifier) from exc
etl.errors.DataExtractError: failed to fetch table size for '...'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/src/arthur-redshift-etl/python/etl/extract/extractor.py", line 100, in extract_table_with_retry
    call_with_retry(extract_retries, self.extract_table, source, relation)
  File "/opt/src/arthur-redshift-etl/python/etl/util/retry.py", line 37, in call_with_retry
    raise RetriesExhaustedError("reached max number of retries ({:d})".format(max_retries)) from exc
etl.errors.RetriesExhaustedError: reached max number of retries (2)

...

INFO etl.extract.sqoop (extract-source_0) [extractor.py:137] Finished extract from source '...': 0 succeeded, 3 failed (20.97s)
ERROR etl.extract.sqoop (MainThread) [extractor.py:159] Failed to extract from these source(s): '...'
WARNING etl.extract.sqoop (MainThread) [extractor.py:172] Failed to extract 3 relation(s): ...

Other changes

This PR starts a etl.util module with retry being the first inhabitant. Over time we'll move other supporting modules there.
Raises minimum log level for botocore.credentials to INFO. (Lower again to DEBUG if you want to know the places that boto looks for credentials.

Closes #162 by cleaning up our code. A library would be nice but it would also take the logging away.

Yes, the pipeline would still be happy.

We have summarize_events to see whether any fail events happened in the extract.
We could change the extract to return an error if any failures are found.

We don't want 2 to be the default so that the rebuild ETL continues even if a non-required table is missing. But we could add a command line option for the extraction pipeline.


Lighting Bug World Generation

I have generated a new world using TerrainControl for 1.6.4 and CB build #2889
After placing blocks in the air and then leaving the area and returning, the area underneath is completely black like so:
http://gontroller.com/caps/e6858604b9.png
The darkness can be removed with torches but comes back as soon as they are removed.
This is a world with only TerrainControl and Essentials installed.
I have tried to fix the lighting using mcedit but it doesn't get rid of it.

Closing due to inactivity, comment here again if the same issue in happening. Thanks.


Bundler::GemNotFound: Could not find multi_json-1.0.4 in any of the sources

In one of my Rails apps, I’m getting:

Error starting application
Your Rack app raised an exception when Pow tried to run it.
   Bundler::GemNotFound: Could not find multi_json-1.0.4 in any of the sources
   ~/.rvm/gems/ruby-1.9.3-p125/gems/bundler-1.1.3/lib/bundler/spec_set.rb:90:in `block in materialize'
   [...]

Interesting / Details / Tried:

This happens in one (big, complex) rails app, and not in another one.
This one has an .rvmrc file and the other app does not.
I have no problems running the app outside of pow with rackup -p 3000 (or just bundle exec rails s).
I am using Pow + Apache.
I am using the latest bundler and rvm.

rvm env . -- --env > .powenv
Returns 'Unrecognized command line argument(s): '. --env' ( see: 'rvm usage' )'. Any other idea?


[DG] Update Developer Guide for fuzzy search

Each member should describe the implementation of at least one enhancement she has added (or planning to add).

Expected length: 1+ page per person

The description can contain things such as,

How the feature is implemented (or is going to be implemented).
Why it is implemented that way.
Alternatives considered.

Closed by #133


Remove moment.js

momentjs has its all functions as member function. So you have to import all functions even you need only some function. Once you create a instance, all function are included.
and on the other side date-fns is divided by function level. So you can import and use only what you need and this removes a lot of unused and unnecessary code.

ref #37

Maybe we can even use standard date functions nowadays (instead of another dependency)?

yes @joaquimrocha date-fns supports only javascript date APIS so i think it will be better to rather use the Date Api directly as we dont have much use of moment will see if it requires to create custom method will create that as well


Organisation docker image

Docker image completed with cleaned code and Readme.

Little problem to solve with em-core-md.


Bug when masking spine animation.

Version

Phaser Version: 3.16 +
Operating system: Windows 10
Browser: All

Description
WHAT HAPPENS: When masking a container and adding a spine animation to it, any additional GameObjects added to the container will not be masked.
EXPECTATION: Any subsequent GameObjects added to the masked container will be masked.
Example Test Code
var game = new Phaser.Game({
    type: Phaser.WEBGL, width: 800, height: 600,
    scene: {
        preload: preload,
        pack: { files: [ { type: 'scenePlugin', key: 'SpineWebGLPlugin', url: 'https://labs.phaser.io/plugins/SpineWebGLPlugin.js', sceneKey: 'spine' }]},
        create: create
    }
});

function preload()
{
    this.load.image('logo', 'https://labs.phaser.io/assets/sprites/phaser.png');
    this.load.setPath('https://labs.phaser.io/assets/animations/spine/');
    this.load.spine('boy', 'spineboy.json', 'spineboy.atlas');
}

function create()
{
    var maskedContainer = this.add.container(20, 20);
    var maskShape = this.add.graphics({fillStyle: { color: 0xff0000 }}).fillRectShape(new Phaser.Geom.Rectangle(20, 20, 400, 400));
    maskShape.alpha = .5;
	maskedContainer.setMask(new Phaser.Display.Masks.GeometryMask(this, maskShape));

    var image1 = this.add.image(400, 200, 'logo');
    var image2 = this.add.image(400, 100, 'logo');
    var spine = this.add.spine(200, 400, 'boy', 'run', true);

    maskedContainer.add([image1, spine, image2]); //** BUG: Notice how image2 is not masked. **//
}

https://codepen.io/JakeCaron/pen/ErpMKx

I've noticed this too.  The rebindPipeline function is called when the spine renderer swaps back to the phaser rendering, it resets the stencil to a certain state, thus losing the stencil you'd like to be kept and applied to subsequent rendering.
It also resets viewport, blendmode and texture binding which may not show as a problem but could cause some unnecessary webgl calls.  This could impact performance for a large number of spine objects.
The simple fix is to have rebindPipeline reinstate the correct stencil.  A better fix would be for rebindPipeline to have parameters to control what does and doesn't get reset, which in this case the spine renderer would not want the stencil reset because it knows it hasn't used it.

This is fixed in Phaser 3.17.


feat: Add steps to join organization on public homepage

It would be helpful if the steps required to join the organization were indicated on the organization's public homepage.
These steps could include a link to the invitation Issues template in the Support repo.

That sounds like a great idea! Did you want to go ahead and add that or shall I?

That sounds like a great idea! Did you want to go ahead and add that or shall I?

Sure, I can add it

Added in https://github.com/AccessibleForAll/.github/commit/070673e679cf3dab867fb1af25147302077891b0 Thanks so much for contributing!


No Data in database after Nessus scans

I have a very good working Seccubus 2.31.4-90.1 version that has been working very well on a CentOS release 6.9 from quite some months. My Nessus version is   6.11.1.
I am working towards going to the latest Seccubus release ( 2.46-1 ) on a new Ubuntu16 box and a CentOS Linux release 7.4 box. But i am not able to see any data being populated after successful nessus scans on both the installs.
The Nessus scans runs smoothly on both the boxes and i see them running in Nessus dashboard as well. The Status tab also shows all green, only 1 yellow.

But no data is being populated in DB. Neither any issues being reported in verbose mode.
Try1 with basic network scan:
root@ubuntu1604:/opt/seccubus/bin# ./do-scan -w 6_1_1_0 -s nessus_scan -n -v
Starting scan 'nessus_scan' from workspace '6_1_1_0'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/Nessus6/scan --workspace '6_1_1_0' --scan 'nessus_scan'     -s 10.xxx.xx.xx --port 8834 -u admin --policy 'Basic Network Scan' --hosts /tmp/seccubus.hosts.12047 --pw 'abc123'  --nodelete
Exporting report in nessus format
$VAR1 = {
'status' => 'ready'
};
Scan export status: ready
Exporting report in html format
$VAR1 = {
'status' => 'ready'
};
Scan export status: ready
Exporting report in pdf format
Exporting scan to pdf failed, skipping
Delete not supported on this platform
Delete not supported on this platform
Delete not supported on this platform
Converting /tmp/seccubus.6_1_1_0.nessus_scan.12049.nessus to /tmp/seccubus.6_1_1_0.nessus_scan.12049.ivil.xml
Importing ivil
Scan imported, adding files to scan nessus_scan in workspace 6_1_1_0
Done
Sending notifications for scan end...
0 notification(s) sent
Done
Try2 with custom policy:
[root@barlam-centos-1 bin]# ./do-scan -w <IP_ADDRESS> -s nessus_scan -n -v
Starting scan 'nessus_scan' from workspace '<IP_ADDRESS>'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/Nessus6/scan --workspace '<IP_ADDRESS>' --scan 'nessus_scan' -s 10.xxx.xx.xx --port 8834 -u admin --policy 'DISA STIG RHEL 5' --hosts /tmp/seccubus.hosts.3742 --pw 'abc123'  --nodelete
Exporting report in nessus format
$VAR1 = {
'status' => 'ready'
};
Scan export status: ready
Exporting report in html format
$VAR1 = {
'status' => 'ready'
};
Scan export status: ready
Exporting report in pdf format
Exporting scan to pdf failed, skipping
Delete not supported on this platform
Delete not supported on this platform
Delete not supported on this platform
Converting /tmp/seccubus.<IP_ADDRESS>.nessus_scan.3745.nessus to /tmp/seccubus.<IP_ADDRESS>.nessus_scan.3745.ivil.xml
Importing ivil
Scan imported, adding files to scan nessus_scan in workspace <IP_ADDRESS>
Done
Sending notifications for scan end...
0 notification(s) sent
Done
================= No data in MYSQL DB ========================
root@ubuntu1604:/opt/seccubus/bin# mysql -u root -p
Enter password:
Welcome to the MariaDB monitor.  Commands end with ; or \g.
Your MariaDB connection id is 3
Server version: 10.0.34-MariaDB-0ubuntu<IP_ADDRESS> Ubuntu 16.04
Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.
Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.
MariaDB [(none)]> connect seccubus;
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A
Connection id:    4
Current database: seccubus
MariaDB [seccubus]> show tables;
+-----------------------+
| Tables_in_seccubus    |
+-----------------------+
| asset2scan            |
| asset_hosts           |
| assets                |
| attachments           |
| checkpoints           |
| config                |
| customsql             |
| events                |
| finding_changes       |
| finding_status        |
| findings              |
| groups                |
| host_names            |
| issue2finding_changes |
| issue_changes         |
| issue_status          |
| issues                |
| issues2findings       |
| notifications         |
| rights                |
| runs                  |
| scans                 |
| severity              |
| user2group            |
| users                 |
| workspaces            |
+-----------------------+
26 rows in set (0.00 sec)
MariaDB [seccubus]> select * from findings;
Empty set (0.00 sec)
MariaDB [seccubus]>

The only table that has been populated is Workspaces.
MariaDB [seccubus]> select * from runs;
Empty set (0.00 sec)
MariaDB [seccubus]> select * from workspaces;
+-----+---------+
| id  | name    |
+-----+---------+
| 100 | <IP_ADDRESS> |
| 101 | 6_1_1_0 |
+-----+---------+
2 rows in set (0.00 sec)

Cleaning up older issues. Feel free to open a new one if you still need any assistance.


Support effectless components

Allow components to return supple nodes directly (JSX / string / etc.) instead of having to return a supple node effect.
It will still be possible to return an effect, but not mandatory.
When returning a node directly, developers must be aware that the component won't be wrapped in a render effect and thus, the returned JSX must not be tracking any signal.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

src/core/dom.ts
96.57% <100.00%> (-0.99%)
:arrow_down:

... and 10 files with indirect coverage changes


Add project_configurator for the generate_asset_id function

Depends on https://github.com/openprocurement/openprocurement.api/pull/335

Coverage increased (+0.3%) to 50.773% when pulling 86ea91d4eef18692d1c9b021de60df0733744d7f on MichaelYusko:feature/add_configurator into 89e2a2bb9e44ef19e7c4778117bb19114ef67d5a on openprocurement:master.


chore: change repo_host_type to repo_platform

📚 Documentation preview 📚: https://ss-python--533.org.readthedocs.build/en/533/

BTW, this change makes jinja conditional judgment easier, and I would follow thoes changes to ss-cpp.😀

I've done reviewing. If we have no problem with my suggestion, I will pass it an approval.

I've done reviewing. If we have no problem with my suggestion, I will pass it an approval.

Hi msclock, I did not see any review comments, maybe you forget to send it out? Let me know if I nissed anything.

Just a note, we should mention supporting different platforms in Features.

If we have no problem with my suggestion

Good cache, buddy~ Changed as suggested.


No icons for Research Gate and Google Scholar in \socail[][]{}

This is fixed with the latest git version


Add integration tests

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Codecov Report

Merging #40 into master will decrease coverage by 0.80%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   89.17%   88.37%   -0.81%
==========================================
  Files          12       12
  Lines         573      757     +184
==========================================
+ Hits          511      669     +158
- Misses         46       72      +26
  Partials       16       16

Impacted Files
Coverage Δ

...taDog/datadog-lambda-go/internal/trace/listener.go
0.00% <0.00%> (ø)

...atadog-lambda-go/internal/metrics/kms_decrypter.go
19.04% <19.04%> (ø)

...DataDog/datadog-lambda-go/internal/metrics/time.go
66.66% <66.66%> (ø)

...r/github.com/DataDog/datadog-lambda-go/ddlambda.go
75.00% <75.00%> (ø)

...ataDog/datadog-lambda-go/internal/trace/context.go
87.09% <87.09%> (ø)

.../DataDog/datadog-lambda-go/internal/metrics/api.go
89.15% <89.15%> (ø)

...ataDog/datadog-lambda-go/internal/metrics/model.go
91.42% <91.42%> (ø)

...og/datadog-lambda-go/internal/metrics/processor.go
93.40% <93.40%> (ø)

...Dog/datadog-lambda-go/internal/metrics/listener.go
96.55% <96.55%> (ø)

...aDog/datadog-lambda-go/internal/metrics/batcher.go
100.00% <100.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84014d3...1571e13. Read the comment docs.


Service: Update tracking job ID

Summary
Updating the tracking job ID
Contributor Tasks
These tasks are for the pull request creator to tick off.

[ ] Relevant changelogs have been updated with user-visible changes

[ ] TouchFree Windows
[ ] TouchFree BrightSign
[ ] TouchFree Web Tooling

Reviewer Tasks
Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

[x] Developer testing
[x] Code reviewed
[x] Non-code assets reviewed
[x] Documentation reviewed - includes checking documentation requirements are met and not missing e.g., public API is commented

Does it matter that the artifact expires in 6 days?


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://neverball.org/download.php
Publisher: neverball.org
Package Name: Neverball
Description: Deftly Guide a Rolling Ball through Many Slick 3D Levels.
Package Version: 1.6.0
Installer URL: https://neverball.org/neverball-1.6.0.zip

[Policy] zip binary

[Policy] Unblocked; Will require ManifestVersion: 1.9.0 with ArchiveBinariesDependOnPath: true


jetpack in inventory

When opening inventory while flying flight is still on
https://youtu.be/LYAlQQo05Lc

To be fair, I'd prefer that over plummeting to my doom.
On Tue, Aug 23, 2016, 4:31 PM bludde<EMAIL_ADDRESS>wrote:

When opening inventory while flying flight is still on
https://youtu.be/LYAlQQo05Lc
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/190, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJzt6rNNfQZ-Fru4ETx5YqCb7bi1euV1ks5qi2a3gaJpZM4JraUy
.

May not have been intended originally but I think @TheGuyRunningSouth is right, it's probably better than it cutting out and killing you.


Add support for #[sqlx(flatten(with_prefix="...))] to allow unmarshalling (FromRow) and modular composition of structs

Is your feature request related to a problem? Please describe.
When using query_as (not !) to unmarshal a query into a nested struct it can be difficult to avoid name clashes. Consider the structure
#[derive(FromRow)]
pub struct Nested {
    updated_at: DateTime<Utc>,
}

#[derive(FromRow)]
pub struct Struct {
    #[sqlx(flatten)]
    item: Nested,
    updated_at: CollectionRoll,
}

and query
select a.updated_at, b.updated_at from table_a a inner join table_b b using (id);

In the example, there might be two (real world) objects which have different updated_at timestamps.
Describe the solution you'd like
It we be great if you could specify a prefix to be applied to each field in a flattened struct e.g.
#[derive(FromRow)]
pub struct Struct {
    #[sqlx(flatten(with_prefix="nested_")]
    item: Nested,
    updated_at: CollectionRoll,
}

Then the following query could be unmarshalled
select a.updated_at, b.updated_at as nested_updated_at from table_a a inner join table_b b using (id);

This would allow some modularity when composing structs. If a solution like this doesn't exist it can cause copying of the nested struct as the field exist in a namespace large then itself.
Describe alternatives you've considered
Another possible solution https://github.com/launchbadge/sqlx/issues/2186.
Additional context
I would be happy to give it a go if the idea is agreed upon. I searched for a while in the issues for this, but I think I might have been this is a proposed solution somewhere, sorry if this is the case.

As an alternative API, I think it would be good to specify the . separated prefix rather than a string, so that you can say
#[derive(FromRow)]
struct Struct {
  #[sqlx(flatten(with_namespace="b")]
  item: Nested,
  updated_at: CollectionRoll
}

and use a query like
SELECT a.updated_at, b.updated_at FROM table_a a INNER JOIN table_b b USING (id);

(or whatever your relevant sql dialect requires).
Composition is a huge pain in SQLx at the moment without this.


Migrating to latest version of this plugin

Cordova CLI version and cordova platform version
cordova --version                                    7.1.0
cordova platform version android (6.3.0) iOS (4.5.4)

Plugin version
cordova plugin version | grep phonegap-plugin-push   1.10.5

I noticed that more recent versions of Android are not getting push notifications through my App using 1.10.5 version of this plugin. Reading through the issues on this forum I understand I need to upgrade the plugin. I have two questions.

What is the version I can upgrade to without having to make too many changes to my App and have notifications work in more recent Android versions? Can I move to the most recent version 2.2.2, or perhaps 2.2.3 released a few days back? Or are there any significant changes required in moving to 2.x version from 1.10.x.
Do I need to move from GCM to FCM to use a more recent version of this plugin? On a related note, and sorry for the basic nature of this question, how do I know if my App is using GCM or FCM? Part of the reason I ask is because when I go to Firebase to try to migrate the project to FCM (as indicated in a FireCast video) I don't see that as an option which makes me wonder if I am already using FCM.

I understand that GCM won't work after April 2019 so, if needed, I am looking to move to FCM sooner than later.
Thanks,
Sanjay.

Try to upgrade to 1.10.6, it works for me...

@stib if by recent versions of Android you mean Android 8+ then yes, support for message channels which are required by Android 8 are introduced in the 2.1.0 version of the plugin.

There are no API level changes with the plugin. Instead of passing a SENDER_ID in at run time you need to supply a google-services.json file at build time.
You should still be able to send a GCM push to a device registered for FCM but upgrading the project to FCM is not terribly difficult. If you are going to Firebase you are probably already using FCM. Are you able to generate a google-services.json file from that project?

@macdonst thank you for the info. I generated the google-services.json file a while back and have that in my project. The changes I see from Installation section of your documentation for the plugin are

Add this to the ios section of the config.xml

<platform name="ios">
  <resource-file src="GoogleService-Info.plist" />
</platform>

This file has been use from the beginning so I am assuming the addition to the config.xml is a requirement for the new version of the plugin
2. Add this to the android section of the config.xml
<platform name="android">
  <resource-file src="google-services.json" target="app/google-services.json" />
</platform>

Same as Info.plist - don't have this in config.xml and will add - assuming it is a requirement for the new version of the plugin
3. I have this in package.json already so that should be good
    {
      "variables": {
        "SENDER_ID": "XXXX"
      },
      "locator": "phonegap-plugin-push"
    },

Is there anything else I need to do, besides the three things above, to make sure I am using the new version of plugin correctly and also using FCM? On a related note, how do I know if I the plugin is using GCM or FCM?
Thank you for your thoughts.
Sanjay.

@stib you only need to do 1 and 2. Adding the resource file lines into your config.xml will deliver the file to the right spot.

Thanks @macdonst

Should I remove the entry in package.json (3 above) or leave it there or it doesn't matter? It's been there so far.
I don't see an app directory in my ionic App (it's ionic v1). So where should google-services.json target for android point to?
If I have different Firebase projects for Development and Production what's the best way to switch the google-services.json and GoogleService-Info.plist files above?
Trying to understand how to make sure or find out if I am using GCM or FCM. Would be great if you have any pointers on that.

Thank you for your help.
Sanjay.

@stib I think you are going to need to ask for help on the Ionic forums. There CLI works slightly differently than the Cordova/PhoneGap one.

@macdonst to make sure I am not mixing things, are you referring to asking for help on Ionic forum with respect to where the google-services.json target for android should point to? Or were you referring to something else?
I hope I am not the first Ionic v1 user trying to use the updated version of this plugin.

@stib I'm sure you are not but I don't know the Ionic CLI that well. I'm not sure if the resource file paths are 100% correct.


Advanced reversible simulator

This PR extends the simple reversible simulator with more advanced features. In order to have a simple "Hello World" style project to illustrate IQuantumProcessor I suggest to keep both projects, potentially adding other advanced features to the advanced reversible simulator in the future, keeping the other simulator project simple.
For this purpose, I also renamed reversible-simulator to reversible-simulator-simple and added some information the README.md from runtime.

@cgranade Thanks for the review and the helpful comments. I addressed all of them, including lower case versions for true and false as input parameters. I initially used capitalised versions, because Q# outputs True and False for the return value.


Add codec support for chrone

I am writing a typed wrapper for sled database using bincode-2.0.0-rc3 based on the typed-sled which use bincode-1 to do the codec thing.
When I writing the example part of bincode-sled, I found that a struct which contains chrono::DateTime<chrono::Utc> cannot auto-derive the Encode and Decode trait, I could only turn to using a SystemTime as a work around.
source code is here

Typed-sled use derive marco of serde, which could derive the chrone::Datetime successfully.

For interop with bincode’s derive feature, you can use the #[bincode(with_serde)] attribute on each field that implements serde’s traits.

https://docs.rs/bincode/2.0.0-rc.3/bincode/serde/index.html
Would this work?


Channel onReady received twice

Hi,
I made a simple test and added some log in the lib sources. Here you can find the code:
AMQP::Channel myChannel(this->conn);
// install a generic channel-error handler that will be called for every
// error that occurs on the channel
myChannel.onError([](const char *message) {
     // report error
     std::cout << "channel error: " << message << std::endl;
});

// install a generic callback that will be called when the channel is ready
// for sending the first instruction
myChannel.onReady([]() {
     std::cout << "onReady myChannel" << std::endl;
});

If I send an email is because I found the behaviour a bit strange.
Here is my output.
New channel created... (Channel constructor)
onReady from lib (channel.h)
onReady from lib (channelimpl.h)
onReady myChannel (callback)

reportReady from lib (channelopenokframe.h)
onReady myChannel (callback)

As you can see, the "onReady" callback is executed twice: once in the onReady function from channelimpl class and once in the reportReady function from channelopenokframe class.
Is it a "wanted" behaviour?

It seems weird indeed, I don't think it is wanted behavior, do you think you can fix it yourself and send in a pull request?

I can try to comment hte onReady call in channelopenokframe.h but I am not sure that it wouldn't create other problems.

I have been trying to reproduce the behavior described here, and I am unable to. The code you posted is - obviously - not a complete application, so I have done my best to replicate what you're doing here. This is the script I have created:
/**
 *  Dependencies
 */
#include <reactcpp/amqp.h>

/**
 *  Enable additional literals to be used
 */
using std::literals;

/**
 *  Main application function
 *
 *  @param  argc    Number of command-line arguments
 *  @param  argv    Array of command-line arguments
 */
int main()
{
    // the event loop, amqp connection and channel to use
    React::MainLoop         loop;
    React::AMQP::Connection connection(&loop, nullptr, "localhost"s, 15672, { "guest", "guest" }, "/");
    React::AMQP::Channel    channel(&connection);

    // check for errors on the channel
    channel.onError([&](const char *message) {

        // oopsie, this is an error, report it
        std::cerr << "Channel error: " << message << std::endl;

        // close the connection
        connection.close();

        // stop the loop
        loop.stop();
    });

    // wait for the channel to become ready
    channel.onReady([&]() {

        // this should be output only once, as this test-script correctly does
        std::cout << "Channel is ready, waiting before closing" << std::endl;

        // wait a little bit, maybe the duplicate ready-event arrives twice
        loop.onTimeout(10, [&]() {

            // we're done waiting now
            std::cout << "Timer expired, closing channel" << std::endl;

            // close the channel down
            channel.close().onSuccess([&]() {

                // stop the connection too
                connection.close();

                // and now the loop can be stopped
                loop.stop();
            });

            // timer may be stopped
            return false;
        });
    });

    // start the loop
    loop.run();

    // swipe any errors under the rug
    return 0;
}

I have used REACT-CPP and REACT-CPP-AMQP, also created by us and available on github. I think this should be functionally more-or-less identical to the code you posted. I have set it up so that the channel stays ready for 10 seconds, so that there is time for the onReady callback to be invoked.
If you are convinced this is a bug in the AMQP-CPP library, please provide more detailed code that demonstrates this bug.


ci: use preinstalled clang

Codecov Report

Merging #92 (51dd497) into main (d5c4a6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         1    -1
  Lines           93        27   -66
  Branches         4         3    -1
=========================================
- Hits            93        27   -66

Flag
Coverage Δ

macos-12-clang
?

ubuntu-22.04-clang
100.00% <ø> (ø)

ubuntu-22.04-gcc
?

windows-2022-cl
?

windows-2022-clang
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lib/math/include/math/math.hpp
100.00% <0.00%> (ø)

test/math/math-test.cpp

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Deleting and re-adding a trigger causes it to not be added to workflow definition

Describe the Bug with repro steps
The following steps can be performed in DesignerStandalone (nx serve) or Power Automate local portal

Create a flow with a Recurrence trigger and Initialize Variable action.
Observe Code view. It should contain the definition of the trigger.
Delete the trigger.
Re-add the Recurrence trigger.
Observe Code view. Note that although the Recurrence trigger has been visually added to the canvas, Code view does not contain the recurrence trigger.

Expected:
The trigger should get re-added correctly.
Actual:
Trigger is not added correctly. In practice, in Power Automate, this causes us to be unable to load the flow again.
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using Preview Designer or GA Designer
Preview
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
Initial (correct) workflow:

Workflow after re-adding Recurrence trigger:

What is seen in the canvas:

Browser
Edge
Additional context
I verified locally in DesignerStandalone by reverting this commit that it fixes the issue: https://github.com/Azure/LogicAppsUX/pull/2685
AB#24249911

@Eric-B-Wu @rllyy97 - Can one of you debug to see if isAddingTrigger is correctly reset after readding the trigger from recommendation again.
@Ram-G - that commit should not be reverted to fix this issue, the issue might be in some state not getting set correctly.


moved updateToStore call in CreateEndPoint before we call addEndpoint

Signed-off-by: selansen<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:selansen/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354469720
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9bca9a4). Click here to learn what that means.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #2024   +/-   ##
=========================================
  Coverage          ?   39.94%
=========================================
  Files             ?      137
  Lines             ?    22117
  Branches          ?        0
=========================================
  Hits              ?     8835
  Misses            ?    11979
  Partials          ?     1303

Impacted Files
Coverage Δ

network.go
63.29% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bca9a4...a277a3f. Read the comment docs.

review comments are taken care.

All the code review comments incorporated. @fcrisciani could you pls merge it into main stream?

LGTM


Testing and Refactoring CommonDataRequesterImpl

The first changeset is probably pretty harmless it mostly contains unit tests for CommonDataRequesterImpl. The second changeset creates a delegate class to separate most of the logic out of the Servlet, I think it is good practice to move logic into POJOs and it will make it easier to integrate into TINT but it is understandable if you do not see that as desirable.
Thanks for your time,
-John

Hello John,
The DB Curator code is very old. I would like to revisit it and improve it so it is less of a hassle for you to integrate. Thank you for your contribution!


failAfterError prevents opening eslint report

Hello, hope to find some answers here. Been struggling for some time now and can't get it fixed in a proper way.
On gulp 4.0!
I have a lint task that is called from a build task in series (gulp.series('lint', 'clean', 'templates', 'scripts'));. So I wantto have the lint task to be succesfully finished before the other tasks in the build start. This is why failAfterError is important for me.
I'm using the eslint html reporter (great output!) and when there are errors I want to open the eslint-result.html for the user (using gulp-open). The problem is that, whenever I use failAfterError, the lint task is immediately closed after linting the files, preventing the openReport task to actually open the html report.
See here my code:
var gulp = require('gulp');
var $ = require('gulp-load-plugins')({ lazy: true });
var config = require('../gulp.config');
var path = require('path');
var fs = require('fs');
var eslintReporter = require('eslint-html-reporter');

if (!fs.existsSync(config.folders.report)) {
  fs.mkdirSync(config.folders.report);
}

function lint() {
  return gulp.src(config.filesPatterns.appNoHtml2Js)
    .pipe($.using())
    .pipe($.eslint({
      configFile: config.folders.root + '.eslintrc',
      fix: config.lint.autofix
    }))
    .pipe($.eslint.format(eslintReporter, function (results) {
      fs.writeFileSync(path.join(config.folders.report, config.lint.reportFile), results);
    }))
    .pipe($.eslint.results(function (results) {
      var message;
      if (results.errorCount > 0) {
        message = 'There are ' + results.errorCount + ' ESlint errors. You have set noErrorsBeforeBuild to: ' + config.lint.noErrorsBeforeBuild + '. ';
        if (config.lint.noErrorsBeforeBuild) {
          message += 'Build and deploy cannot be performed.';
        } else {
          message += 'Build can still be performed.';
        }
        $.util.log($.util.colors.red(message));
        if (config.lint.openReport) {
          openLintReport();
        }
      } else {
        $.util.log($.util.colors.green('Good job: no ESLint errors found!'));
      }
    }))
    .pipe($.if(config.lint.noErrorsBeforeBuild, $.eslint.failAfterError()))
    .pipe($.if(isFixed, gulp.dest(config.folders.app)));
}

function openLintReport() {
  return gulp.src(config.folders.report + config.lint.reportFile)
        .pipe($.open());
}

function isFixed(file) {
    // Has ESLint fixed the file contents?
  return file.eslint != null && file.eslint.fixed;
}

gulp.task('lint', lint);`

Now I can easily bypass this problem using gulp-wait, and set some wait time after opening the report. But this feels cheap and dirty? Any suggestion on how I could get this to work in clean-code way?
A second thing: when there are errors, the output in the console looks like below (replaced some private stuff with ***):
Is there any way to clean this up a bit. Those Details (Domain etc.) and all the NPM stuff don't add any value. Is this a gulp-eslint thing or just the way gulp errors a task?
I have tried to clean this up with things like plumber, pump etc. But that always result in async errors.
Thanks a big bunch!!
[19:14:22] There are 4 ESlint errors. You have set noErrorsBeforeBuild to: true. Build and deploy cannot be performed.
[19:14:22] 'lint' errored after 23 s
[19:14:22] ESLintError in plugin 'gulp-eslint'
Message:
    Failed with 4 errors
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

npm ERR! npm  v3.3.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>lint: `gulp lint`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>lint script 'gulp lint'.
npm ERR! This is most likely a problem with the *** package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp lint
npm ERR! You can get their info via:
npm ERR!     npm owner ls ***
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\git\Repos\***\npm-debug.log

I have the same issue, did you figure out what was causing this?

Hi, nice to see I'm not alone in the world :). Anyways: I haven't got any feedback on this, and still have this issue. I think it is because of the fact the gulp eslint plugin doesn't trully support gulp 4 yet.

I think you're right

@EvtK's code doesn't ensures that $.open is called before $.eslint.failAfterError is called. Instead of using failAfterError,

emit error event inside openLintReport function.
handle it inside function (results) { ... } function.

I think you're right

@haluvibe No.


[SP-3778][PDI-16441] ${Internal.Job.Repository.Directory} and ${Internal.Transformation.Repository.Directory} kettle variable are not working in 6.1,7.0 and 7.1 versions

[SP-3778][PDI-16441] ${Internal.Job.Repository.Directory} and ${Internal.Transformation.Repository.Directory} kettle variable are not working in 6.1,7.0 and 7.1 versions
fixing loading a transformation and a job

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .97%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change:  + 1.01%
Complexity Change:  + 1.06%
Instruction Change:  + .17%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.job.Job

Branch Change:  + 3.17%
Complexity Change:  + .38%
Instruction Change:  + 2.26%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + .66%
Complexity Change:  + .91%
Instruction Change:  + .96%
Line Change:  + .67%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.08%:small_red_triangle_down:
Complexity Change: -2.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.TransMeta

Branch Change:  + .77%
Complexity Change:  + .82%
Instruction Change:  + .37%
Line Change:  + .32%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/test-src/org/pentaho/di/trans/TransMetaTest.java

:heavy_exclamation_mark: 'member def type' have incorrect indentation level 5, expected level should be one of the following: 6, 8. at Line: 415

:heavy_exclamation_mark: 'object def' child have incorrect indentation level 5, expected level should be one of the following: 6, 8. at Line: 415

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Newly Fixed Tests:
org.pentaho.di.job.entries.checkdbconnection.JobEntryCheckDbConnectionsTest.testMillisecondWait:
:large_blue_circle: org.junit.runners.model.TestTimedOutException
org.junit.runners.model.TestTimedOutException: test timed out after 10000 milliseconds
	at java.io.FileDescriptor.sync(Native Method)
	at org.h2.store.fs.FileObjectDisk.sync(FileObjectDisk.java:28)
	at org.h2.store.FileStore.sync(FileStore.java:453)
	at org.h2.store.PageStore.writeVariableHeader(PageStore.java:664)
	at org.h2.store.PageStore.setLogFirstPage(PageStore.java:660)
	at org.h2.store.PageStore.compact(PageStore.java:409)
	at org.h2.engine.Database.closeOpenFilesAndUnlock(Database.java:

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .97%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change:  + 3.17%
Complexity Change:  + .38%
Instruction Change:  + 2.26%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + .66%
Complexity Change:  + .91%
Instruction Change:  + .96%
Line Change:  + .67%

org.pentaho.di.trans.step.StepMeta

Branch Change: -.68%:small_red_triangle_down:
Complexity Change: -.58%:small_red_triangle_down:
Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1.04%:small_red_triangle_down:
Complexity Change: -1.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change:  + .06%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.TransMeta

Branch Change:  + .77%
Complexity Change:  + .82%
Instruction Change:  + .37%
Line Change:  + .32%

org.pentaho.di.www.TransformationMap

Branch Change:  + 11.36%
Complexity Change:  + 9.23%
Instruction Change:  + 11.29%
Line Change:  + 11.54%

@mchen-len-son Could you please review and merge it?


Adds flag to use own AWS key pair

What this PR does / why we need it:
Adds a flag to use an existing key pair in AWS.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #312
Release note:
NONE

/cc @dippynark

/assign @dippynark

/assign @simonswine

I think this should be a configuration option in the tarmak.yaml for the aws provider (and should have the option to be overriden in AWS specific sections of environment,clusters or instancePools)
/unassign
/assign @JoshVanL


Remove caret from force minimist version

Closes #36
Signed-off-by: David Thompson<EMAIL_ADDRESS>

Succeeded by #43


Add more icons for participants

Icons are used in sequence diagrams to represent certain elements (e.g. Actor) or to add notes for clarification(e.g. Boundary, or Entity), show that an participant belongs to a type (e.g. Service).
In ZenUML, we use the following syntax to link an icon to a participant:
@IconName participantName

We already support a list of icons. This issue is to add more icons to the support list.
Checklist

[ ] Add the support of icons in the below list
[ ] Create a page to document all supported icons - https://github.com/ZenUml/docs/issues/11

They have been split into groups so we don't have to finish all in one release.
Primary participant types

Client
Server
Browser
Service
Controller
API (Application Programming Interface)
UI (User Interface)
Mobile
ExternalSystem

Secondary participant types

Application
LoadBalancer
Network
Cache
WebServer
MessageQueue
Scheduler
Gateway
AuthenticationService
MailServer

Common applications and services

GitHub
Docker
GitLab
Jenkins
PostgreSQL
MongoDB
Kubernetes
Apache Kafka
Elasticsearch
Auth0
Redis

Feel free to create sub tasks for a subset of the icons. Use [sub] in the title and link back to this issue if you are going to create sub tasks.


Update Readme policy section automatically like terraform-docs

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

this is done along with hooks


governance: Add Bartek to team

We had a unanimous vote for adding Bartek, so adding him here.

:+1:

:tada:


Support for other frameworks that not expose raw request at req.raw.req

Hello guys:
After jump from previous version (0.1...0.2)  to 1.0 i found that my REQ object isn't logged anymore...
Digger into the code, i found that the expected shape of the req object (IncomingMessage) is now: req -> raw-> req , and other frameworks, like fastify,  expose that at req -> raw directly.
I have a fix to support this (and possibly others (?) frameworks), let me know to send PR.
thx

Is there going to be any action taken on this issue?

@nicomf1982 Thanks for the issue. My apologies for never having replied. I understand if you have moved on by now.
If this is still relevant to you, I would like to discuss it now and look into a fix.
I believe the code block you are referring to is this:
  if (req.raw && req.raw.req && req.raw.req.httpVersion) {
    // This looks like a hapi request object (https://hapi.dev/api/#request),
    // use the raw Node.js http.IncomingMessage that it references.
    // TODO: Use hapi's already parsed `req.url` for speed.
    req = req.raw.req
  }

This was added to support @hapi/hapi.
My expectation is that this would not have broken usage for Fastify, which has req.raw (https://fastify.dev/docs/latest/Reference/Request/) ... unless I am mistaken and req.raw.req is actually truthy.  The repo does not have a specific test case for Fastify, however. I will look into adding one.

I can reproduce the issue. The change that broke this is #69. That "defensive" handling:
  // Use duck-typing to check this is a `http.IncomingMessage`-y object.
  if (!('httpVersion' in req && 'headers' in req && 'method' in req)) {
    return false
  }

results in formatHttpRequest() returning early.  I will get on a fix for this now.


Manual merge of ECDSA timing fix

Address a timing side channel whereby it is possible to determine some
information about the length of the scalar used in ECDSA operations
from a large number (2^32) of signatures.
Thanks to Neals Fournaise, Eliane Jaulmes and Jean-Rene Reinhard for
reporting this issue.
Refer to #4576 for further details.

Amended this fix to match the other PR.  Using BN_set_bit instead of additions and updated the test cases.

Re-approval will be required.

Failures seem unrelated.

https://github.com/openssl/openssl/pull/4576#issuecomment-340713697

Merge of fix from main PR to 1.0.2.

@bernd-edlinger Could you perform the same service here? :-)

Sure :-)

Awesome - thanks! @levitte I will assume your approval still holds?

Pushed. Thanks.

Thanks folks.


autocomplete new definitions just typed

jay looks promising, normally we will create new variables etc under jay but jay seems ignore them for autocomplete, it will be nice is jay can remember any new definitions in current session and provide autocomplete for them on the go, so I don't need retype "superlongvariable" after the first time I did "let superlongvarible", instead jay will help to autocomplete it

I did some work on the global-lexical-scope-names branch in this repo but I'm not sure it's 100% stable yet, would you mind checking it out @laoshaw ? Building instructions are on the bottom of the readme.

I did 'npm run build' and after that how to run jay?  how to build and run is unclear to me still

works well in my case, tried both variable names and functions names, can keep autocomplete for xzy123,xyz1233, xyz12333 with TAB key

nice, thanks for reporting & testing :)


Leading spaces of texts are lost when pulling

My application has a class pool with a text pool whose some symbols start with a leading space.
When pushing it to the Git repository, no issue, the XML is correctly serialized, the leading space is kept:
<item>
 <ID>I</ID>
 <KEY>013</KEY>
 <ENTRY>   and</ENTRY>
 <LENGTH>6</LENGTH>
</item>

When pulling from another system, the deserialization removes the leading space, consequently a difference is always shown for this object in the abapGit repository main view (and the application will behave differently too).

Reason: the method PARSE of ZCL_ABAPGIT_XML does a li_parser->set_normalizing( iv_normalize ) whose parameter has the default value "true", which strips leading spaces.
Possible solution: I tried li_parser->add_strip_space_element( ) instead of using the normalization, which seems to work in my case, but I fear of side effects throughout all abapGit features. Note that li_parser->set_normalizing( abap_false ) is not sufficient alone, add_strip_... is the shortest way to solve.
Of course, putting a space at the beginning of a text can be considered a bad practice, but I feel that abapGit should not impact the way developers work. But if it's too dangerous to change abapGit, then it will just be a usage limit which needs to refactor the application (are there other ones, by the way?)

In my opinion this is a bug in abapGit and should be fixed. Should also be possible to have this checked in abapGit/CI.

Another effect of the normalization is to remove the trailing spaces. Here is one issue with another type of object (ENHO of type clasenh, where a standalone type is added to a standard class):

I could check that add_strip_space_element also solves this issue. I'm unable to evaluate the impact of changing the method PARSE of ZCL_ABAPGIT_XML. I guess that add_strip_space_element could lead to issues too.

Another effect of the normalization is to remove the trailing spaces. Here is one issue with another type of object (ENHO of type clasenh, where a standalone type is added to a standard class):

I could check that add_strip_space_element also solves this issue.
I'm unable to evaluate if the change of the method PARSE of ZCL_ABAPGIT_XML can lead to side effects elsewhere. To avoid side effects, one simple solution is to derive ZCL_ABAPGIT_XML_INPUT into ZCL_ABAPGIT_XML_INPUT_STRIP to do a strip instead of a normalize, and use this latter class wherever the "strip" is needed & tested.

Added some additional text elements in abapGit-tests/CLAS_textpool@a34e23e.
I was unable to maintain any trailing spaces (by directly inputting them or using the sync feature) so I assume that's just not possible.
I tried to figure out when li_parser->set_normalizing was added but git blame on GitHub breaks somewhere 3 years ago (7618cada582de26569a0fe918295e3795d277a7c), when there was only one huge file.
I'd suggest to first try and fix it in a general way and run the unit tests + abapGit/CI. That should at least indicate if everything is broken afterwards.
It also seems like trailing and leading spaces as well as other special characters are not included in the XML test classes.