Automated tests for Unread Indicators feature and final polish

Details
There are several changes introduced in this PR, but most of them exist to enable UI testing for the entire app.

Several modules needed to be mocked
Prevent editing or deleting of report actions that are pendingAction === 'add' (this is temporary but I noticed this feature is pretty broken so disabled it for now until we are totally migrated to using reportActionID for reportAction_* values keys)
Report sequenceNumber were being set to clientID which made it impossible to mark a "pending" comment as unread. Instead we use a guessed sequenceNumber for this. I suspect this may need to change in the future or depend on reportActionID as well.
When deleting a message we were not optimistically adding in the type field (Fixed)
Strike-through for deleted messages also was not working correctly as the message was entirely unset and when going offline there was no comment to show with the strike-through. The message is entirely lost when we do this so I moved it to a previousMessage field that we can use as a fallback.

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/228076
$ https://github.com/Expensify/App/issues/10799
$ https://github.com/Expensify/App/issues/10753
Tests

Automated tests were added, but these testing flows laid out in the Unread Indicators doc should be performed.

Testing Unread LHN Status, “New Messages” badge, and New Line Indicator

Start a chat between User A and User B.
Ensure User A is not looking at the chat.
Send a message as User B
Verify the LHN row shows in bold for User A to indicate unread messages
Visit the chat as User A and verify the LHN row no longer shows in bold
Verify there is a “----- New” line above the message sent by User B
Scroll up and verify that the “New Messages” button appears floating above the content.
Verify that tapping this button will scroll you to the bottom of the chat but not clear the “---- New” line marker.
Mark a comment as “unread”
Verify the “---- New” line marker appears
Mark as unread comments above and below the existing new marker
Verify the marker appears in the correct position each time
While the new marker is active leave a comment as User A
Verify the new marker and new messages badge both disappear
Mark another comment as unread.
Navigate away from the chat
Navigate back to the chat
Verify the chat in the LHN shows as read
Verify the New Line marker and new messages badge is still present
Navigate away one more time and back
Verify the new marker and new messages badge both disappear
Mark another comment as unread.
Navigate away from the chat
Navigate back to the chat
Minimize the app and reopen it
Verify the new marker and new message badge both disappear
Switch to a mobile view (small screen) and mark a message as unread
Tap the header to reveal the LHN
Verify the chat in the LHN shows as “unread”
Tap the chat
Verify the new marker and badge are present
Tap the header to reveal the LHN
Verify the chat in the LHN shows as “read”
Tap the chat
Verify the new marker and badge are no longer present.
Scroll up in the chat so that last comment is out of view
Leave a comment as User B
Verify the “new messages badge” shows for User A
Scroll down and verify the “new line marker” shows for User A in the correct position.
Scroll back up and leave another comment as User B
Scroll down as User A
Verify the new marker is in the same position as it was before

Testing Deleted Comment Edge Case

Start a chat between User A and User B.
Ensure User A is not looking at the chat.
Send a message as User B.
Navigate to the chat as User A
Mark the most recent message as “unread”
As User B delete that message
Verify that the report no longer shows as “unread” for User A and that the new marker has disappeared.

[ ] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as Tests above

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

This one is testing well for me locally, but going to wait until the Auth PR for reportActionCount is deployed before taking off draft (as I am testing against that branch locally).

Reworked the tests here a bunch based on @tgolen's feedback. Feeling pretty good about the changes. The one thing I'm not 100% sure on is the usage of act(). When I tried to refactor it to not use async/await it stopped working and I saw errors that seemed to suggest we had to use async/await. Here's what I've got for an alternative...
https://github.com/Expensify/App/blob/7b76284a011aa08a4ad24aab7b867eaed725b395/tests/utils/waitForPromisesToResolveWithAct.js#L1-L21

Updated. Thanks for the additional comments @tgolen and @neil-marcellini

Oh shoot are we supposed to add a reviewer checklist in a comment or edit the description? I’m not sure 🥲
This was not an emergency. Just the contributor checklist check.

🚀 Deployed to staging by @marcaaron in version: 1.2.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Beta] Crashes in explorable area (Lethenda Bog)

I experienced two crashes in relatively quick succession after playing without issues for about 30 minutes.
Here are the crash dumps:
6.23beta1-20240910-191253-52764-13220.dmp
6.23beta1-20240910-191959-29312-48176.dmp
Thank you very much for your support!

What were you doing in the first crash? Looks like something to do with armor slots, so may be related to using the armory module

I don't remember exactly, I was in the area for vanquishing and exploration. I think I was salvaging something just before the second crash (manually, not via the toolbox right-click menu), but I do not remember what exactly I was doing before the first crash. I have never really used the armory module, but I know that I looked through some modules that day, since this was the first session with the Beta update.

ok thanks. The second crash has been found and will be fixed


Add EVP_PKEY API to retrieve raw OSSL_PARAM values from a provided key

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

Since these are values that the caller knows (or should know) the name of, I don't see why OP_keymgmt_get_params() isn't used for this?  And yeah, it means that we need to add cases for the get_params functions.
In a way, it means that OP_keymgmt_export() and OP_keymgmt_get_params() do more or less the same thing, but with a twist; OP_keymgmt_export() is meant for those who do not know and do not need to know the exact contents of the key beforehand, all the caller wants is a bunch of data, while OP_keymgmt_get_params() is meant for those who do know, and that may want to extract very specific data.
I've probably made the mistake of saying (even documenting) that op_keymgmt_get_params() should only be concerned with key meta-data -- I lost track of the need for what this PR is trying to achieve.  That was a mistake, there's really nothing that says that an asymmetric key implementation couldn't let OP_keymgmt_get_params() return any data they want, including the key data.

And yeah, it means that we need to add cases for the get_params functions.

I guess I was trying to prevent having to duplicate nearly identical code in multiple places.
(It may lead to some out of synch bugs as we move forward over time).

I guess I was trying to prevent having to duplicate nearly identical code in multiple places.

I haven't looked too closely, but I wouldn't be surprised if one can be made in terms of the other.
The other option could be to expose the export function to the public, including the callback.  I'm not too keen on that, but

Does requiring something like PEM serialization, which has a standard format for all keys, lessen the need for this?

Does requiring something like PEM serialization, which has a standard format for all keys, lessen the need for this?

DER serialization should suffice...  but no, not in the general case.  We want something that helps applications to extract data from a key, such as n from an RSA key, or xyzzy from a BLARGH key (the latter being fictional, of course, but serves the purpose of reminding us all that we need to be able to deal with what's unknown to us)

So perhaps for 3.0 we only support DER serialization, and once we get more data-points we try to solve the general case.

That's easy, just tell the application authors serialize the key to DER using OSSL_SERIALIZER, then de serialize the result with the appropriate d2i function to convert it to whatever the type may be (DH is the popular example du jour). That can be done, here and now, yeah.

So you're saying that the problem we know about is solved?  And we can put this aside for 3.0?

For once, yeah it's possible to do, limited to the key types we know internally.

So perhaps for 3.0 we only support DER serialization, and once we get more data-points we try to solve the general case.

Wouldnt recommend it.
The PEM format allows extra data to be added onto the end, which may be real useful (for key validation for example).

@slontis,what you quote says DER, why did you go back to PEM?

Replaced by #11365


Fancy Zones using one zone across both displays

Microsoft PowerToys version
0.83.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
use fancy zones to place a window (hold shift while dragging)
✔ Expected Behavior
I have my primary display cut into 4 corners and my secondary display into thirds horizontally.
❌ Actual Behavior
it only uses the zone from my display 1 (cut into 4 corners) but it is stretched across both displays. I have 2 displays at 10801920 with one vertical and powertoys, and respectively the fancy zones editor show the two displays as one 19203000 display.

Other Software
Windows 22H2 22621.4037
Windows Feature Experience Pack 1000.22700.1027.0

I enabled the "Allow Zones to span across multiple monitors" by accident (or possibly as i updated?) issue is resolved.

Hi @Seborah ,,
Thank you for your share for multiple screen resolution.
Disable "Allow zone to span across monitor" it's working.


/root/Cpp/HARM/googletest does not contain a CMakeLists.txt file.

I follow your instruction:

Download and install CMake.
git clone https://github.com/cpearce/HARM.git
cd HARM # I added this step
git submodule init
git submodule update
mkdir build
cd build
cmake ..

1. The error logs as below:
CMake Error at CMakeLists.txt:9 (add_subdirectory):
The source directory
/root/Cpp/HARM/googletest

does not contain a CMakeLists.txt file.
-- Configuring incomplete, errors occurred!
2. copy the CMakeLists.txt file into googletest and rerun cmake ..- error as :
CMake Error at googletest/CMakeLists.txt:9 (add_subdirectory):
add_subdirectory given source "googletest" which is not an existing
directory.
CMake Error at CMakeLists.txt:11 (add_library):
add_library cannot create target "harm_main" because another target with
the same name already exists.  The existing target is a static library
created in source directory "/root/Cpp/HARM/googletest".  See documentation
for policy CMP0002 for more details.

need to cd HARM/src/lib
then mkdir build and cmake


chore(deps) Update the Narwhal pointer

Update Narwhal

Auto-generated by create-pull-request an the scripts/update_narwhal.sh script

Closing in favor of #4655


Adding parent and children rest calls to subject area omas

I could not find the issue for a pr so am raising this issue to track it

I have PR https://github.com/odpi/egeria/pull/3925. I have raised this issue for it. I would like some view points on the following issue:

I changed the code in Subject Area as part of the pr to introduce paging to various API requests.
Talking with @mandy-chessell there is a standard way of doing this using the InvalidParameterHandler which has a validatePaging method. This method throws Exception org.odpi.openmetadata.commonservices.ffdc.exceptions.InvalidParameterException
This method is used by Asset Owner Asset Catalog , discovery engine and other places in the Egeria code.
@immmus has raised a review comment twice indicating he would like this Exception removed, I assume because it is a common Exception not a SubjectArea one
InvalidParameterHandler, it has standard specific common messages indicating things like -
NEGATIVE_START_FROM(400, "OMAG-COMMON-400-008",
NEGATIVE_PAGE_SIZE(400, "OMAG-COMMON-400-009",
Very good for debugging from logs.

I think we either:

Not use the InvalidParameterHandler, so we do not throw the common exception. This means we have to implement duplicate code in the subject area with Subject Area messages and Exceptions.
Use the InvalidParameterHandler and expose the common Exception in the Subject Area API
Use the InvalidParameterHandler and create duplicate Subject ares equivalent messages for all the common messages.

I am thinking that option 2) is preferable. @immmus @grahamwallis @planetf1 @mandy-chessell . What are your thoughts?

I have PR #3925. I have raised this issue for it. I would like some view points on the following issue:

I changed the code in Subject Area as part of the pr to introduce paging to various API requests.
Talking with @mandy-chessell there is a standard way of doing this using the InvalidParameterHandler which has a validatePaging method. This method throws Exception org.odpi.openmetadata.commonservices.ffdc.exceptions.InvalidParameterException
This method is used by Asset Owner Asset Catalog , discovery engine and other places in the Egeria code.
@immmus has raised a review comment twice indicating he would like this Exception removed, I assume because it is a common Exception not a SubjectArea one
InvalidParameterHandler, it has standard specific common messages indicating things like -
NEGATIVE_START_FROM(400, "OMAG-COMMON-400-008",
NEGATIVE_PAGE_SIZE(400, "OMAG-COMMON-400-009",
Very good for debugging from logs.

I think we either:

Not use the InvalidParameterHandler, so we do not throw the common exception. This means we have to implement duplicate code in the subject area with Subject Area messages and Exceptions.
Use the InvalidParameterHandler and expose the common Exception in the Subject Area API
Use the InvalidParameterHandler and create duplicate Subject ares equivalent messages for all the common messages.

I am thinking that option 2) is preferable. @immmus @grahamwallis @planetf1 @mandy-chessell . What are your thoughts?

I raised the issue of dropping the package before the exception in a try {} catch construct, rather than dropping the exception itself

@immmus OK great - my misunderstanding. We are on the same page :-)


Add YouTube link to navigation

Loving the new site - would appreciate a link to get people to the YouTube channel. Hopefully this is a reasonable way, but no issues if y'all would rather use a different icon/placement 🙇🏻

Nice one! Made the icon inherit the text color to match what the Twitter one does, and also added it to the footer 🎉


Change progress type from Double to Decimal

I faced a bug with loss of precision because Double type is used.
Are there any difficulties with transition to Decimal type?

The precision inaccuracies of Double is not visible to the human eye in a spinner, so I'm curious what exactly the problem is? Can you elaborate?

In my app updating other UI elements can be done only when progress property is receiving >= 1.0 value, but with loss of precision I get 0.9998...
If progress property will be Decimal typed then users of this library will not getting bugs.

That sounds more like a bug in how you calculate the percentage. Try some rounding.
I don't plan to switch to Decimal. None of Apple's APIs, for example, Progress accepts a Decimal. It's always a Double. That's for a reason. Changing to a Decimal would also be a huge breaking change.


Fixed a typo in Condition docstring

Coverage increased (+1.6%) to 99.924% when pulling 3761ff141d593894191cd6a1feb930d0397ee331 on adippel:patch-1 into 1c9ea6345d82d9fd099b3d6ae5d84e9604706a15 on tyarkoni:master.

Coverage increased (+1.6%) to 99.924% when pulling 3761ff141d593894191cd6a1feb930d0397ee331 on adippel:patch-1 into 1c9ea6345d82d9fd099b3d6ae5d84e9604706a15 on tyarkoni:master.

thank you 👍


Add setting switch to disable assets compilation

Like ActionCable: https://github.com/rails/rails/blob/main/actioncable/lib/action_cable/engine.rb#L27
Useful when using Webpacker to manage static assets

[ ] My code follows the style guidelines of this project
[ ] Checks (StandardRB & Prettier-Standard) are passing
[ ] This is not a documentation update

Thanks @n-rodriguez! I thought we had that already, but seems like we don't!
I'm wondering if we should do it like turbo-rails does it?
https://github.com/hotwired/turbo-rails/blob/6db05d69d5f060bd142defe247550b5da5c47228/lib/turbo/engine.rb#L23-L35

I'd prefer to not touch CableReady::Config so let's do it à la Turbo :)

I'd prefer to not touch CableReady::Config

@n-rodriguez Do you have any specific reason for that?

@n-rodriguez Do you have any specific reason for that?

to keep things simple

Actually I don't use the main branch of CableReady, I use 5.0.0.pre9 for both Ruby and JS so I'm not aware of the changes in the APIs.
Maybe this is better :
# config/initializers/cable_ready.rb
CableReady.configure do |config|
  config.precompile_assets = false # new configuration accessor

  config.on_failed_sanity_checks = :ignore

  config.add_operation_name :notify
  config.add_operation_name :progress_bar
end

but it may requires some tests. wdyt?

FWIW :
Turbo : https://github.com/hotwired/turbo-rails/blob/main/lib/turbo/engine.rb#L31
ActionText: https://github.com/rails/rails/blob/main/actiontext/lib/action_text/engine.rb#L33
ActionCable: https://github.com/rails/rails/blob/main/actioncable/lib/action_cable/engine.rb#L27
ActiveStorage: https://github.com/rails/rails/blob/main/activestorage/lib/active_storage/engine.rb#L189

@n-rodriguez I like the version where we have it in config/initializers/cable_ready.rb 👍🏼
but we can also keep the PRECOMPILE_ASSETS constant so you could also do it the other way if you like.
For ActionText, ActionCable and ActiveStorage it makes sense that they do it that way because the already have their regular a config on application.config

One more thing: Would you mind adding it commented out to: https://github.com/stimulusreflex/cable_ready/blob/29b7e063465acb0468ecd3d4034b0c00696c7f07/lib/generators/cable_ready/templates/config/initializers/cable_ready.rb#L3
Then we can merge this, imo 🚀

Then we can merge this, imo rocket

Do you think it's possible to cut a new pre-release for both Ruby and JS?

Yes, pre10 is going out this week!

Yes, pre10 is going out this week!

Thanks!


Fix a major error in the call to nn_recv()

nn_recv() buffer is best when allocated by the user or client who knows the exact length of the message instead of using max buffer. We are freeing the memory allocated by user using the nn_freemsg()

As discussed in scrum our assumption of malloc heap space can be shared across socket is wrong

nn_recv() or any other recv() socket call MUST allocate the buffer, doing otherwise would be a clear error.

As described here http://nanomsg.org/v0.1/nn_recv.3.html, nn_recv (s, &buf, NN_MSG, 0); means nanomsg allocates the buffer and should be freed nn_freemsg (buf);


dm people

Is your feature request related to a problem? Please describe.
i am kinda confused to dm someone myself
Describe the solution you'd like
a native method to dm people, possiblity User.send
Describe alternatives you've considered
trying to use the raw api
Additional context
Add any other context or screenshots about the feature request here.

This library uses the Webhook API to respond to interactions. The rationale for this is documented here. As such, you can only respond to a command in a few ways, listed here.
If you just want to run commands in a DM, this is documented here.
If you want your bot to DM people directly in response to a command run in a server, you need to use a library which connects to Discord using a websocket -- webhook libraries like this one can't support that feature unless Discord adds support.
If you just want to send the user a message that others in the channel can't see, consider an ephemeral message.

i see. thanks for clarification.


Quadratic Equation root

Before jumping into Pr first comment for assign.
Problem statement : Create a function to find only the root value of x in any quadratic equation ax^2+bx+c. The problem will take 3 arguments :

a as the co-efficient of x^2
b as the co-efficient of x
c as the constant term

Problem Link :  https://edabit.com/challenge/nasKYub6qEAfQcFuy
Choose one category - Very Easy, Easy, Medium, Hard, Very Hard, Expert
Question category : Medium

Before submitting a PR please Check some details.

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Choose label for Problem , example- "good first issue", "easy"
[ ]  In file there should be problem statement and link to problem

/* Problem-Task : This program will add two numbers
 * Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
*/
int main() {
    int bla;
    return 0;
}

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

@aayushi-droid Please assign this issue to me.

Can I do this using Python?

Can you assign this to me?
I would like to do this in C++

Can you assign this to me? This is my First attempt for Open source. I want to develop it using c++.

Please assign me this task.


Add Search And Edit Apllication

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
.install Python 3.5+ and vs code
.In your command prompt
-import tkinter
-pip install wikipedia
.Install python extension in VS Code Editor
.A gui application will appear after execution the code in editor.
Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Name it SEARCH_AND_EDIT_GUI_APPLICATION
Don't create a separate README. Add it in the orignal README only
Add some screenshots in the folder as well

Please do this asap.

Please do this asap.


add test for sketchy vtable

Blocked on https://github.com/rust-lang/rust/pull/67254

@bors r+

:pushpin: Commit bbd512d52f5203672452a8c476775bf27fe4b110 has been approved by RalfJung

:hourglass: Testing commit bbd512d52f5203672452a8c476775bf27fe4b110 with merge 60c75092deb189ddad6360cbab203d14dade7889...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 60c75092deb189ddad6360cbab203d14dade7889 to master...


03/31/2018 02:56 : Create Pull Request for branch master -> prTesting1_2018033102

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


3rd-party Wiimote is not recognized

I'm using Arch Linux with kernel 3.13.4-1. I installed the bluez 5.15-1 and xwiimote 2-1 packages (the latter from the AUR), started bluetooth.service, and the bluetooth adapter began to blink (it identifies as "0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode)").
After that, no matter what command-line or GUI tool I use, none of them even detect that any device is visible via Bluetooth (yes, I am pressing 1+2/sync and the remote's LEDs start blinking). The adapter is definitely in reach (< 30 cm).
I bought the remote on eBay. Interestingly, the one I got has exactly one label on it below the LEDs: "Motion 2in1". Other than that, is has no identifying features whatsoever; no CE sign, no serial number, nothing inside the battery compartment. Should I open it up and take a look at the PCB?

Any news here? I have the exact same problem and I hope you guys found a solution.

Could be an issue with the bluetooth key? I have meet this problem with my Wiimotes (official and derivate) with an bad bluetooth usb key.

I did create a thread on the bluez mailing list:
http://marc.info/?l=linux-bluetooth&m=140926604113933&w=2
But I never came to a solution. From my understanding, a new plugin "wiimote-clone" will need to be created that inserts the correct SDP records when scanning for them fails.

i got the exact same problem with a "AGPtek® Weiß Dual Analog Wireless Gamepad Controller für Nintendo Wii U Pro".
Anyone had any further success to get further than pairing with short connects/disconnects?

hey all, I came to the same issue, any solution?

sadly, no. i sold my AGPteks and went for the Original. Those work flawlessly

thanks, I also went for original, it works out of box.

I have the same problem with a 3rd-party WiiMote on Fedora 24 / Latitude E7450 / built-in BT controller.

im using win 10. in settings it does not detect my controller but it does for original remote.

xwiimote doesn't run on Windows, so let's ignore that comment.
I was wondering why my device wasn't being picked up, but mine also has "Motion 2in1" below the leds so it's probably the same on as OP mentioned. It's 2021 now, 7 years after OP created the issue. Has nobody identified a fix yet?
Interestingly enough the Dolphin Emulator connects without any problems.

xwiimote doesn't run on Windows, so let's ignore that comment.
I was wondering why my device wasn't being picked up, but mine also has "Motion 2in1" below the leds so it's probably the same on as OP mentioned. It's 2021 now, 7 years after OP created the issue. Has nobody identified a fix yet?
Interestingly enough the Dolphin Emulator connects to it without any problems.

Same problem here...
I'v found an closed issue at Dolphin github where they said something about enabling bluetooth scanning devices using LIAC protocols, like hcitool does. If we just finds how to do this inside BlueZ, may be the solution...


[HOLD 22712] View distance details in App

HELD on https://github.com/Expensify/App/issues/22712

Please follow the plan in the design doc: View distance details in App

Still held

Still on hold

I'll start progress on this

No real progress atm. This has hard dependencies for helper functions coming from https://github.com/Expensify/App/issues/22710. Good thing is that it should be easy to move on once that issue is done

Posted a draft PR. Not as many dependencies as I thought because we actually don't have to recompute the merchant text ("171 miles @ $0.55 / mile") since it is already saved on the transaction.
Still need to make a slight change to display the route image as it won't be saved exactly the same as a normal receipt (something we might want to change later)

Implemented and reviewed internally so no payment. Closing


Fix specification for Duration

Currently, the specification requires that a parsed duration shall match the following RegEx in total:
([0-9][0-9])h-([0-9][0-9])m-([0-9][0-9][0-9])s

This seems wrong, since normally seconds are only written using two digits.
Additionally, it allows second and minute values larger than 59.
Therefore, I suggest that the requirement is changed to this RegEx instead:
([0-9][0-9])h-([0-5][0-9])m-([0-5][0-9])s

I agree


proposal: encoding/json: allow merging unmarshalled map value into existing map value

What version of Go are you using (go version)?
go version go1.8 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/b.gaifullin/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qn/p8wx9pvd3dd90xmd6w_kx50c0000gn/T/go-build536782081=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
https://play.golang.org/p/Cv7cGN6hdv
What did you expect to see?
I expect that structure will not be re-created during decoding and result will be:
"a": &main.T{S0:"a", S1:"c"}
What did you see instead?
I see that json.Decode overrides values in map by new items.
the result is:
"a": &main.T{S0:"", S1:"c"}

I thought I'd seen this before, but I can't find another issue in this tracker.
Have you tried alternatives, such as merging the maps afterward?
I also assume that if we're to make the decoder incremental, it should be consistent across all types - struct fields and slices too, for example.

I have tried to merge map afterwards, but I encountered the following issues:

detecting that field does specified in input data, using of pointer allows to resolve this, but it also not convenient
I cannot use the map[string]T which predefined items, where T is an interface.

enconding/json do not override struct fields, I also think about wrapping map into structure by using package reflect to create appropriate structure on runtime.

Because it wasn't clear to me, this is not about reusing a map during Unmarshal, which Unmarshal already does, but instead about some way to merge a specific values contained in the map already under a given key with the new data in the JSON value with the same key. In general this is not a well-formed operation, so it would have to be opt-in. It seems too specialized to be worth the complexity it would incur in package json. (Package json is already quite complex.)
If you really need this, my suggestion would be to write a custom merger or to fork the json package and modify your own copy.

@rsc I do not agree. When I unmarshal structure, the fields already reused.
when I unmarshal map, the items always re-created. IMHO, the behaviour should identical.
and this is not about merge, it is about re-using existing map values instead of creating a new one, which also implemented for struct fields.

In both the struct and the map case, a specific element is being updated.  In your example, you are updating the map element for the key "a".  You are asking for something further: you want to say that if the map element for the key "a" already exists, you want to update only specific fields.  As Russ said, you want a merge operation.

in case of struct, elements which are not specified in json keeps they original values.
in case of using map, the whole map will be constructed from scratch.
https://play.golang.org

@bgaifullin, I see your point, and if we were designing json from scratch, we'd probably sit down and think about whether the struct semantics should be changed or the map semantics should be changed or it's OK for them to be subtly different in this way. But we're not designing json from scratch. We have many existing uses that must be taken into account, and I am sure that we cannot change the default behavior here without breaking some existing uses. That leaves us with adding an option that we must maintain, or encouraging people who need this merge semantics to build their own. For now at least we are choosing the latter. If evidence accumulates that merging into existing map values is needed by many users then we will certainly revisit this.

@rsc I got it. thank you.


first draft header ond footer - only text

this is the draft content for Header and Footer components.  The actual example components need to be added.  This may mean tweaking the content

I think this needs to be merged in with the pages I added in #48

Merged into #48


Reproducible Builds - Part 2

[ ] Migrate to modern Gradle actions
[ ] Support generating official releases from GH (including Maven publish)
[ ] Support generation of Artifact Attestations
[ ] Update internal doc

This should remove any effort I make locally to produce a release and be verifiable by community.

https://gist.github.com/sualeh/ae78dc16123899d7942bc38baba5203c


Termux [cookies from browser]

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
Is it possible to use the --cookies-from-browser option from termux in android?

No. Apps running inside termux normally do not have access to other apps' data.
Perhaps it can be done if the phone is rooted? I am not sure. @mbway any idea?

I use yt-dlp with termux but this never crossed my mind. I think you're right that without rooting it's not possible (i checked with find . -iname '*cookie*' and found nothing.
I assume that the mobile versions of the desktop browsers share a lot of code, whether that extends to cookie management I have no idea. I don't have a rooted phone so I can't look into this myself but I am happy to help where I can if anyone is interested in adding support for android

No. Apps running inside termux normally do not have access to other apps' data.
Perhaps it can be done if the phone is rooted? I am not sure. @mbway any idea?

No. I dont rooted my phone


Why not provide an off option? ---> " CommonJS or AMD dependencies can cause optimization bailouts."

🚀 Feature request
Command (mark with an x)

[x] serve
[ ] new
[ ] build
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
Provide a configuration to turn it off，ingore warning！
WARNING in .... depends on 'core-js/modules/es.regexp.to-string'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in .... depends on 'core-js/modules/es.function.name'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in .... depends on 'core-js/modules/es.array.slice'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
....

Describe the solution you'd like
"allowedCommonJsDependencies": "ture"

Describe alternatives you've considered
Provide a wildcard。
allowedCommonJsDependencies:['file-saver',"core-js/*"]

Hi @sguot,
You can use the module ID, to allow the entire CJS module to be used.
Example:
allowedCommonJsDependencies":["core-js"]

The reason why it is not possible to turn off this feature entirely is so that users don't accidentally introduce new CJS modules in their application.

Hi @sguot,
You can use the module ID, to allow the entire CJS module to be used.
Example:
allowedCommonJsDependencies":["core-js"]

The reason why it is not possible to turn off this feature entirely is so that users don't accidentally introduce new CJS modules in their application.

I tried and failed before, but now I can, thank you!


Grammar and options

can we call it something more descriptive than queue_size?
here's the paper's description (they call it "ef closest neighbors", I'm actually not sure what that's supposed to stand for)

The first phase of the insertion process starts from the top layer by greedily traversing the graph in order to find the ef closest neighbors to the inserted element q in the layer. After that, the algorithm continues the search from the next layer using the found closest neighbors from the previous layer as enter points, and the process repeats. Closest neighbors at each layer are found by a variant of the greedy search algorithm described in alg. 2, which is an updated version of the algorithm from [26]. To obtain the approximate ef nearest neighbors in some layer lс, a dynamic list W of ef closest found elements (initially filled with enter points) is kept during the search. The list is updated at each step by evaluating the neighborhood of the closest previously non-evaluated element in the list until the neighborhood of every element from the list is evaluated.

and they describe it here as "size of dynamic candidate list"

Lucene calls this beam width which didn't ring a bell with me either but apparently it's a well known thing in the search space (https://en.wikipedia.org/wiki/Beam_search)
some ideas:

neighbor_beam_width
construction_beam_width
construction_queue_size
candidate_queue_size
construction_search_width

WDYT?

I have gone with construction_beam_width because, according to the lucene docs and usage, this is specifically used during construction of the graph.


Need a checklist for adding new matchers

Component
CONTRIBUTING
Description
Adding matchers has become more complicated now that the matcher and core functionality are split. Additionally, having multiple entry points in the package means multiple environment load scripts to maintain.
A checklist that organizes all of these steps in a logical order would help ensure no steps get missed.
This should extend to the pull request template as well.
Are you able/willing to make the change? (It's ok if you're not!)
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: fix typo in flow_control.md

Signed-off-by: spacewander<EMAIL_ADDRESS>
Commit Message: fix typo in flow_control.md
Additional Description:
Risk Level: Low
Testing:
Docs Changes: yes
Release Notes:
Platform Specific Features:

@phlax
Do you have a plan to add typo linter in the CI? So we can detect these errors automatically.

Do you have a plan to add typo linter in the CI? So we can detect these errors automatically.

there is a spellcheck currently but it only checks certain files - there used to be another which check other files - but again not all and was not working so well so was removed
i have a vague plan to add something better but its a surprisingly hard thing to do efficiently


Compilation fails in Ubuntu 13.10

Hello,
compilation from master branch fails. Since it seems to fail in the epoll section, I have checked it also with the " USE_POLL=poll" as mentioned in #1 but I get the same result.
This is the error output:
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o callback.o ../../../event/callback.cc
In file included from ../../../event/event_poll.h:32:0,
from ../../../event/event_system.h:29,
from ../../../event/callback.cc:27:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o callback_thread.o ../../../event/callback_thread.cc
In file included from ../../../event/callback_thread.h:31:0,
from ../../../event/callback_thread.cc:26:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o event_main.o ../../../event/event_main.cc
In file included from ../../../event/event_poll.h:32:0,
from ../../../event/event_system.h:29,
from ../../../event/event_main.cc:28:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o event_poll.o ../../../event/event_poll.cc
In file included from ../../../event/event_poll.h:32:0,
from ../../../event/event_poll.cc:27:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o event_thread.o ../../../event/event_thread.cc
In file included from ../../../event/callback_thread.h:31:0,
from ../../../event/event_thread.h:32,
from ../../../event/event_thread.cc:27:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o timeout_queue.o ../../../event/timeout_queue.cc
../../../event/timeout_queue.cc: In member function ‘Action* TimeoutQueue::append(uintmax_t, SimpleCallback*)’:
../../../event/timeout_queue.cc:36:11: warning: declaration of ‘deadline’ shadows a member of 'this' [-Wshadow]
NanoTime deadline = NanoTime::current_time();
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o timeout_thread.o ../../../event/timeout_thread.cc
In file included from ../../../event/timeout_thread.h:29:0,
from ../../../event/timeout_thread.cc:39:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o event_poll_poll.o ../../../event/event_poll_poll.cc
In file included from ../../../event/event_poll.h:32:0,
from ../../../event/event_poll_poll.cc:34:
../../../common/thread/thread.h: In member function ‘virtual void WorkerThread::signal(bool)’:
../../../common/thread/thread.h:123:2: warning: declaration of ‘stop’ shadows a member of 'this' [-Wshadow]
{
^
../../../event/event_poll_poll.cc: In constructor ‘EventPoll::EventPoll()’:
../../../event/event_poll_poll.cc:40:14: error: no matching function for call to ‘Thread::Thread()’
state_(NULL)
^
../../../event/event_poll_poll.cc:40:14: note: candidates are:
In file included from ../../../event/event_poll.h:32:0,
from ../../../event/event_poll_poll.cc:34:
../../../common/thread/thread.h:42:2: note: Thread::Thread(const string&)
Thread(const std::string&);
^
../../../common/thread/thread.h:42:2: note:   candidate expects 1 argument, 0 provided
../../../common/thread/thread.h:34:7: note: Thread::Thread(const Thread&)
class Thread {
^
../../../common/thread/thread.h:34:7: note:   candidate expects 1 argument, 0 provided
../../../event/event_poll_poll.cc:40:14: error: no matching function for call to ‘Mutex::Mutex()’
state_(NULL)
^
../../../event/event_poll_poll.cc:40:14: note: candidates are:
In file included from ../../../event/event_poll.h:31:0,
from ../../../event/event_poll_poll.cc:34:
../../../common/thread/mutex.h:39:2: note: Mutex::Mutex(const string&)
Mutex(const std::string&);
^
../../../common/thread/mutex.h:39:2: note:   candidate expects 1 argument, 0 provided
../../../common/thread/mutex.h:34:7: note: Mutex::Mutex(const Mutex&)
class Mutex : public Lock {
^
../../../common/thread/mutex.h:34:7: note:   candidate expects 1 argument, 0 provided
../../../event/event_poll_poll.cc: At global scope:
../../../event/event_poll_poll.cc:96:23: error: no ‘void EventPoll::wait(int)’ member function declared in class ‘EventPoll’
EventPoll::wait(int ms)
^
make[3]: *** [event_poll_poll.o] Error 1
make[3]: Leaving directory /tmp/wanproxy/crypto/example/aes128-cbc-speed1' make[2]: *** [all] Error 2 make[2]: Leaving directory /tmp/wanproxy/crypto/example'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/wanproxy/crypto'
make: *** [all] Error 2

I'm seeing something similar when trying on CentOS 7:
make[3]: Entering directory `/root/wanproxy/crypto/example/aes128-cbc-speed1'
g++ -I../../.. -Wno-deprecated -Wnon-virtual-dtor -include common/common.h -pipe -O -g -W -Wall -Wno-system-headers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Wreorder -DTHREADS -c -o event_poll_poll.o ../../../event/event_poll_poll.cc
../../../event/event_poll_poll.cc: In constructor ‘EventPoll::EventPoll()’:
../../../event/event_poll_poll.cc:40:14: error: no matching function for call to ‘Thread::Thread()’
   state_(NULL)
              ^
../../../event/event_poll_poll.cc:40:14: note: candidates are:
In file included from ../../../event/event_poll.h:32:0,
                 from ../../../event/event_poll_poll.cc:34:
../../../common/thread/thread.h:42:2: note: Thread::Thread(const string&)
  Thread(const std::string&);
  ^
../../../common/thread/thread.h:42:2: note:   candidate expects 1 argument, 0 provided
../../../common/thread/thread.h:34:7: note: Thread::Thread(const Thread&)
 class Thread {
       ^
../../../common/thread/thread.h:34:7: note:   candidate expects 1 argument, 0 provided
../../../event/event_poll_poll.cc:40:14: error: no matching function for call to ‘Mutex::Mutex()’
   state_(NULL)
              ^
../../../event/event_poll_poll.cc:40:14: note: candidates are:
In file included from ../../../event/event_poll.h:31:0,
                 from ../../../event/event_poll_poll.cc:34:
../../../common/thread/mutex.h:39:2: note: Mutex::Mutex(const string&)
  Mutex(const std::string&);
  ^
../../../common/thread/mutex.h:39:2: note:   candidate expects 1 argument, 0 provided
../../../common/thread/mutex.h:34:7: note: Mutex::Mutex(const Mutex&)
 class Mutex : public Lock {
       ^
../../../common/thread/mutex.h:34:7: note:   candidate expects 1 argument, 0 provided
../../../event/event_poll_poll.cc: At global scope:
../../../event/event_poll_poll.cc:96:23: error: no ‘void EventPoll::wait(int)’ member function declared in class ‘EventPoll’
 EventPoll::wait(int ms)
                       ^
make[3]: *** [event_poll_poll.o] Error 1

I haven't tried to debug much yet, but I can confirm that USE_POLL=poll doesn't make any apparent difference, even though it's in event_poll code.


[Task]: Investiage outage in release-cluster and propose exit-strategies

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
Observation:
1- Few appsmith pods were stuck in pending .
kubectl describe pod <appsmith-pod> shows that there is a problem getting the efs mount
2- efs-csi-node-cqhp9 belonging to kube-system namespace was in crashloopback state.
3- helm uninstall appsmith and re-install also didnt work after the efs-csi-node is back up and running
How to access the cluster:
aws eks update-kubeconfig --region ap-south-1 --name test-cluster  --profile eksadmin
Temporary-resoultion:
Used the secondary cluster to start appsmith
End-goal:
1- Determine the root cause for the issue
2- Come-up with solutions to make sure we have a strategy to get things back on track.

The instance used in release is a t3.large instance and the network bandwidth doesn't support efs traffic. therefore there were a lot of restarts for the efs-csi-node daemon-set.


Move m365 yammer commands to m365 viva engage

With the rebranding of Yammer to Viva Engage, the cli should also adapt and move all the m365 yammer commands under the m365 viva engage command.
If the team agrees, I would like to work on this issue.

If I remember it correctly we had an internal discussion about this a few months ago. I thought the conclusion was not to include it in the v7 release because it had a quite low priority and we had a load of other work for v7.
So I think we can definitely do this if we keep the original command as an alias so it's not a breaking change.
Any objections @pnp/cli-for-microsoft-365-maintainers?

@milanholemans When I try to run npm run build I always get this error message<EMAIL_ADDRESS>implicitly has an 'any' type.
Try npm i --save-dev @types/azure__msal-common if it exists or add a new declaration (.d.ts) file containing declare module '@azure/msal-common';"

Odd, did you follow our guide on how to setup your local environment?
https://pnp.github.io/cli-microsoft365/contribute/environment-setup#setting-up-your-local-project

Odd, did you follow our guide on how to setup your local environment? https://pnp.github.io/cli-microsoft365/contribute/environment-setup#setting-up-your-local-project

Yes. NPM i shows no errors. I even tried in the Dev Container, same result.

Which version of Node are you using?

Which version of Node are you using?

Node.js v18.18.2

Weird, could you check:

You have the latest version of the code locally
Run npm ci just to be sure and try again
What typescript version is targeted?

Run npm ci just to be sure and try again

This worked. Weird.... Thank you!

Another problem: Now no command works for every input I just get
CLI for Microsoft 365 v7.1.0
Manage Microsoft 365 and SharePoint Framework projects on any platform

What do you see if you run npm list -g --depth=0?

@milanholemans
PS K:\cli-microsoft365> npm list -g --depth=0
C:\Users\aaron\AppData\Roaming\npm
├──<EMAIL_ADDRESS>-> .\K:\cli-microsoft365
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Which shell are you using? PowerShell? Have you tried running it in another shell?

Which shell are you using? PowerShell? Have you tried running it in another shell?

Yes. It's the same for command shell.

Well, it looks like the CLI cannot find any command for your build. Usually, this should work when the entire project is built. Running npm run clean and npm run build doesn't do anything?

npm run clean

Now it's working. Thanks for your help.

Resetting as available due to lack of response


No module named 'skbuild' for pip 21.1.2

Expected behaviour
this happens on python setup.py bdist_wheel
Actual behaviour
Error: ModuleNotFoundError: No module named 'skbuild'
Steps to reproduce
cloned open-cv python
cd into open-cv python
run python setup.py bdist_wheel
Suggested solution on README is pip install --upgrade pip, but it does not work in pip version 21

You must run pip wheel . --verbose. The command you used does not use pip and is not recommended as explained in the README. pyproject.toml defines the build-time dependencies which are used by pip and only pip.
If you need to use the python setup.py bdist_wheel command, then install the dependencies manually: https://github.com/opencv/opencv-python#manual-debug-builds

i see, i was reading off https://github.com/opencv/opencv-python/issues/126#issuecomment-580201939
is python setup.py bdist_wheel simply not recommended now?
I fixed the issue by reinstalled opencv-python + recompile opencv, but was wondering if there is a way to do that through pip like pip install opencv-contrib-python-non-free or some pre-built wheels for non-free opencv libs.

Yeah, that's an old comment. However, it still works if you install scikit-build and numpy before running it.
Manual local build (by cloning this repository and submodules):

git clone --recursive https://github.com/opencv/opencv-python.git
cd opencv-python
pip install scikit-build numpy
export CMAKE_ARGS="-DOPENCV_ENABLE_NONFREE=ON"
python setup.py bdist_wheel

Manual build with pip from PyPI source tarballs (the easiest way, as documented in the README):

export CMAKE_ARGS="-DOPENCV_ENABLE_NONFREE=ON"
pip install --no-binary opencv-python opencv-python

I fixed the issue by reinstalled opencv-python + recompile opencv, but was wondering if there is a way to do that through pip like pip install opencv-contrib-python-non-free or some pre-built wheels for non-free opencv libs.

It's not legal to redistribute commercial / patented algorithms as pre-built binaries so there are no such packages available. This is explained in the FAQ in the README as well as in the issue you linked.

@skvark all good, closing the issue. thanks for the explanations.


Improve xml version extraction

Questions
Answers

Description?
Improve xml version extraction - Add exception

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
-

Sponsor company
-

How to test?
Try to use xml file without version

@M0rgan01 is this the expected result?

@Quetzacoalt91 I adjusted the wording to have "We couldn't find a PrestaShop version in the .zip file that was uploaded in your local archive. Please try again."


Failure in the generation of PDF

Expected Behavior
Using the non-dockerized version of pandoc-resume. Previously, prior to the docker version, I never had an issue.
Actual Behavior
When doing a make, it seems that the html document is created, but hangs at creation of the pdf.
Steps to reproduce the behavior
[kcc@elite pandoc_resume]$ make
mkdir -p output
PANDOC_VERSION=`pandoc --version | head -1 | cut -d' ' -f2 | cut -d'.' -f1`; \
if [ "$PANDOC_VERSION" -eq "2" ]; then \
        SMART=-smart; \
else \
        SMART=--smart; \
fi \

for f in markdown/*.md; do \
        FILE_NAME=`basename $f | sed 's/.md//g'`; \
        echo $FILE_NAME.html; \
        pandoc --standalone --include-in-header styles/chmduquesne.css \
                --lua-filter=pdc-links-target-blank.lua \
                --from markdown --to html \
                --output output/$FILE_NAME.html $f; \
done
resume.html
[WARNING] This document format requires a nonempty <title> element.
  Please specify either 'title' or 'pagetitle' in the metadata,
  e.g. by using --metadata pagetitle="..." on the command line.
  Falling back to 'resume'
for f in markdown/*.md; do \
        FILE_NAME=`basename $f | sed 's/.md//g'`; \
        echo $FILE_NAME.pdf; \
        pandoc --standalone --template styles/chmduquesne.tex \
                --from markdown --to context \
                --variable papersize=Letter\
                --output output/$FILE_NAME.tex $f > /dev/null; \
        mtxrun --path=output --result=$FILE_NAME.pdf --script context $FILE_NAME.tex > output/context_$FILE_NAME.log 2>&1; \
done
resume.pdf

This is were the process hangs!
Versions
pandoc 2.7.3
mtx-context     | ConTeXt Process Management 1.02
mtx-context     |
mtx-context     | main context file: /usr/share/texmf-dist/tex/context/base/mkiv/context.mkiv
mtx-context     | current version: 2019.03.21 21:39
Pandoc and context versions
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling

Try downgrading to pandoc 2.2.1 and/or context 1.02. Those are the versions that seem to work for me on ubuntu 18.04.
If you'd like the debug the issue, try running the commands in the Makefile manually. There should be a verbose option in both pandoc or context. If you can provide that, maybe the error will be more obvious.

Same-ish problem here. I will try downgrading. But wanted to paste the error as it's slightly different.
    mtxrun --path=output --result=$FILE_NAME.pdf --script context $FILE_NAME.tex > output/context_$FILE_NAME.log 2>&1; \

done
resume.pdf
Makefile:9: recipe for target 'pdf' failed
make: *** [pdf] Error 1

I managed to fix the issue by using Docker,  and tick off the gRPC experimental feature in Docker's preferences settings.

I am having a similar issue on macOS (Sonoma 14.1) using pandoc 3.2.
I have tried make, make all, or make pdf. In all cases, resume.pdf is not created.
make pdf

mkdir -p output
PANDOC_VERSION=`pandoc --version | head -1 | cut -d' ' -f2 | cut -d'.' -f1`; \
	if [ "$PANDOC_VERSION" -eq "2" ]; then \
		SMART=-smart; \
	else \
		SMART=--smart; \
	fi \

for f in markdown/*.md; do \
		FILE_NAME=`basename $f | sed 's/.md//g'`; \
		echo $FILE_NAME.pdf; \
		pandoc --standalone --template styles/chmduquesne.tex \
			--from markdown --to context \
			--variable papersize=A4 \
			--output output/$FILE_NAME.tex $f > /dev/null; \
		mtxrun --path=output --result=$FILE_NAME.pdf --script context $FILE_NAME.tex > output/context_$FILE_NAME.log 2>&1; \
	done
resume.pdf


mobile & control fixes

READY TO merge :)
This PR adds a few fixes and tweaks for the mobile & desktop '3d' controls, and simplifies handling considerably as far as camera controls go.

Can you complete this PR? I need to make some major changes to the Viewer code, which broke the canvas layout in HTML pages.

This will take quite a while still , please go ahead and do your changes will try to merge after that.

@z3dev  this one is now ready for review :)


Find by optional field returns documents with None

Hi!
I have model with Optional[int] indexed field and I want to query via that field. In results I see documents with None in that field. Why? How to avoid it?
class Page(JsonModel):
    id: int = Field(index=True)
    base_id: Optional[int] = Field(index=True)

Migrator().run()
pages = Page.find(Page.base_id == 1).all()

In results I see docs with base_id = None

Thanks for bringing this up! Seems like right now the easiest way to get around this is to add a default value that would never exist in your data. I'll take a look through the source code and see what's going on!

Has it already been fixed?
Can't reproduce it
redis-om = "^0.1.2"


type error when converting Resnet50 average pooling from darknet to IR

I originally posted this in another issue, but was not free since then so the issue was closed but still exists.
Platform (like ubuntu 16.04/win10):
ubuntu16.04
Python version:
python 3.5.3
Source framework with version (like Tensorflow 1.4.1 with GPU):
darknet
Destination framework with version (like CNTK 2.3 with GPU):
Intermediate representation
Pre-trained model path (webpath or webdisk path):
resnet50 model from darknet
Running scripts:
mmtoir -f darknet -n resnet50.cfg -w resnet50.weights -o vgg16 --darknetStart 0
File "/home/bin/mmtoir", line 11, in
load_entry_point('mmdnn', 'console_scripts', 'mmtoir')()
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/_script/convertToIR.py", line 192, in _main
ret = _convert(args)
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/_script/convertToIR.py", line 115, in _convert
parser.run(args.dstPath)
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/common/DataStructure/parser.py", line 22, in run
self.gen_IR()
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/darknet/darknet_parser.py", line 68, in gen_IR
func(current_node)
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/darknet/darknet_parser.py", line 274, in rename_Pooling
assign_IRnode_values(IR_node, kwargs)
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/common/utils.py", line 52, in assign_IRnode_values
assign_attr_value(IR_node.attr[name], val)
File "/home/local/lib/python3.5/site-packages/mmdnn/conversion/common/utils.py", line 37, in assign_attr_value
attr.list.i.extend(val)
TypeError: 8.90625 has type float, but expected one of: int, long
Originally posted by @mwessley in https://github.com/microsoft/MMdnn/issues/643#issuecomment-515016794

Hi @mwessley, please change conv_width and conv_height to return (width + 2*padding - kernel_size)//stride + 1 and return (height + 2*padding - kernel_size)//stride + 1

Also had to convert to the number to int to fix the type error, but otherwise solves the issue


[Feature]  Themed Redesign for Sign-Up Page

Description
The current sign-up page in the Waste Management project looks quite simple and lacks a cohesive theme. A more visually appealing, themed design would enhance user engagement and create a more polished, professional look for the site. This request proposes to redesign the sign-up page with a modern, attractive theme that aligns with the overall brand of the project.
Motivation
The sign-up page should feature a cohesive theme that complements the overall design of the project.
Implement modern UI elements such as smooth animations, visually attractive forms, and themed buttons to provide a more dynamic user experience.
The page should be responsive and accessible across all devices.
Screenshots

Additional Context
PLease assign this issue to me as I would like to work on fixing it. also add the label GSSoC 2024 Extd relaevant .
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct.
[X] The changes don't break the code.
[X] I will attach screenshots and videos of the development work once it is done.

Priority
Low

@GarimaSingh0109 please assign me


Expose HiddenInput in the public interface?

Would it be possible to expose the HiddenInput struct in the public interface of the crate? I have a somewhat complicated usecase and I would like to use it directly.

Hello @ifd3f, no sorry, that's not the point of this library, but feel free to copy/paste de code provided you keep the licensing information in there (Apache 2 license + copyright notice). It's only a couple of dozen lines of code after all :wink:


Crashes when confirming a vsnip option

Checkhealth
Put result of :checkhealth compe.
health#compe#check
========================================================================
## compe:snippet
  - OK: snippet engine detected.

## compe:mapping
  - OK: `compe#complete` is mapped: (`i  <C-Space>   * compe#complete()`)
  - OK: `compe#confirm` is mapped: (`i  <CR>        * compe#confirm('<CR>')`)
  - OK: `compe#close` is mapped: (`i  <C-E>       * compe#close('<C-E>')`)
  - INFO: `compe#scroll` is not mapped

Describe the bug
I tried creating a snippet today that had options in it. compe correctly lists the options but as soon as I confirm one option compe crashes.
To Reproduce
Steps to reproduce the behavior with the minimal config:

Install vsnip and compe with the following bindings:

      inoremap <silent><expr> <C-Space> compe#complete()
      inoremap <silent><expr> <CR> compe#confirm('<CR>')
      inoremap <silent><expr> <C-e> compe#close('<C-e>')

Use a snippet file like:

{
  "demo": {
    "prefix": "cl",
    "body": "console.log('${1|foo,bar|}')"
  }
}

Expand cl snippet and pick bar options. Use CR to confirm.

Actual behavior
vsnip crashes and does not confirm choice. Errors with:
Error detected while processing function compe#confirm:
line   18:
E716: Key not present in Dictionary: "item.word, 'n')"
Press ENTER or type command to continue

Expected behavior
It should confirm the choice like the vsnip jump does, which works perfectly.
Screenshots (optional)
https://user-images.githubusercontent.com/2284724/123330082-d8aefc80-d53d-11eb-8b46-9f25d593c16c.mp4

I've fixed it. Thank you.

@hrsh7th After this fix manual confirmation doesn't work. The following code now do nothing: vim.fn['compe#confirm']({keys = '<C-Space>', select = true}).

Sorry for the annoying. I've fixed it.


Delete ocs-on-a-disconnected-environment.md

This document is out of date. there is a formal document regarding disconnected env in Red-Hat customer portal

/ok-to-test


UI Issues

Hi Team,
Here are some of the issues I faced while trying to review the application:

Logout functionality is not working and taking too long. Ends up with timeout error.
After signing up and logging into the application using traditional way, I could see the password printed in the console in plain text. Is hashing/encoding of password implemented in the backend?

A small suggestion:
Sometimes, images and data do not get loaded on the home screen. Trying to refresh the page redirects to the login page which I think should not be the case. Refreshing the page should be allowed/handled.
Otherwise,
OAuth is working fine. Other functionalities are perfectly fine as well.
Please let me know if I understood any of the points wrongly.
Thanks,
Shweta

The logout issue or any particular page taking too long is related to IU or TACC servers and is something beyond our control. I also faced a similar issue. We have not implemented hashing/encryption of password in the backend as there were other things which we thought are more important and needed prior attention. But yes we should ideally hash the password for security reasons.

Rest all looks good. Closing this issue.


Add timeout for wait approval

What this PR does / why we need it:

Currently, there is no way to configure the timeout value for the WAIT_APPROVAL stage.

Which issue(s) this PR fixes:
Fixes #1371
Does this PR introduce a user-facing change?:

NONE

@sanposhiho Many thanks for your great effort.
I have just left some comments. Please take a look.

@sanposhiho Many thanks for your great effort.
I have just left some comments. Please take a look.

@nghialv Thanks you for your reviews, fixed them :D

@nghialv Thanks you for your reviews, fixed them :D

Thank you.
/lgtm

Thank you.
/lgtm

thank you
/approve

thank you
/approve


Uniform Skeleton for Course and Professor Overview components

What did you expect to happen?
When loading, since the course number / professor name is already known, it does not "load" in the RHS components.
What happened?
For visual consistency, the course number / professor's loading should be chained to a different component that actually loads
Version
Beta 0.1.0
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@TyHil Is this a valid request?

How do we handle if the rest of the component doesn't load?

@AbhiramTadepalli what does "chained to a different component that actually loads" mean. I'm not sure what the desired change is for this issue

Intended change: the course number / professor name should appear to load as long as the other data in the component is loading.
Why: so it looks uniform
"chained to a different ~component~ piece of data that actually loads" means: the loading state of the course number / professor name should change when the loading state of a different piece of data in the same component changes.

You can always just make it look like its loading until the rest of the data is ready. I kinda like the way it shows you what's loading tho. Maybe this could be a question for designers.


cleanup reachset projection for plots

Pull Request Test Coverage Report for Build 518022479

0 of 25 (0.0%)  changed or added relevant lines in 1 file are covered.
1497 unchanged lines in 43 files lost coverage.
Overall coverage decreased (-30.6%) to 12.461%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Flowpipes/recipes.jl
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Algorithms/TMJets/TMJets.jl
2
0%

src/Initialization/init.jl
2
60.0%

src/Algorithms/ORBIT/ORBIT.jl
3
0%

src/Algorithms/GLGM06/post.jl
4
82.14%

src/Hybrid/constructors.jl
4
62.5%

src/Algorithms/LGG09/LGG09.jl
5
0%

src/Algorithms/INT/post.jl
6
74.07%

src/Flowpipes/solutions.jl
7
23.73%

src/Algorithms/ASB07/ASB07.jl
8
0%

src/Algorithms/BOX/BOX.jl
10
0%

Totals

Change from base Build 517877168:
-30.6%

Covered Lines:
566

Relevant Lines:
4542

💛  - Coveralls

Pull Request Test Coverage Report for Build 518022479

0 of 25 (0.0%)  changed or added relevant lines in 1 file are covered.
1497 unchanged lines in 43 files lost coverage.
Overall coverage decreased (-30.6%) to 12.461%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Flowpipes/recipes.jl
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Algorithms/TMJets/TMJets.jl
2
0%

src/Initialization/init.jl
2
60.0%

src/Algorithms/ORBIT/ORBIT.jl
3
0%

src/Algorithms/GLGM06/post.jl
4
82.14%

src/Hybrid/constructors.jl
4
62.5%

src/Algorithms/LGG09/LGG09.jl
5
0%

src/Algorithms/INT/post.jl
6
74.07%

src/Flowpipes/solutions.jl
7
23.73%

src/Algorithms/ASB07/ASB07.jl
8
0%

src/Algorithms/BOX/BOX.jl
10
0%

Totals

Change from base Build 517877168:
-30.6%

Covered Lines:
566

Relevant Lines:
4542

💛  - Coveralls


Fixed bug on 1.17 servers

Added commons-io to the plugin.yml because on 1.17 servers, NoClassDefFoundError would be spammed and chat would not send.

Oh, I didn't know it would close if I deleted the repo.


Add swift41 settings gradle

include swift41 project in settings so it's picked up by distDocker

Should we add this to the exclude list of travis?

Ah you mean the swift41 exclude to distDocker yes I agree I missed that would give use back a minute or 2

@markusthoemmes #3444


Make mixer a first class service

Pilot creates a special cluster for mixer with a CB configuration hard-coded.
We should treat mixer as another first-class service (with EDS and secure naming), and convert CB settings to a destination policy.

Issue moved to istio/istio #1358 via ZenHub


Add Best Buy listings for FTW and FTW3 Ultra

Best buy (US) added listings for FTW and FTW3 Ultra:
FTW3:
https://www.bestbuy.com/site/evga-geforce-rtx-3080-10gb-gddr6x-pci-express-4-0-graphics-card/6436191.p?skuId=6436191
FTW3 Ultra:
https://www.bestbuy.com/site/evga-geforce-rtx-3080-10gb-gddr6x-pci-express-4-0-graphics-card/6436196.p?skuId=6436196

#421 but isn't merged yet.


select2_from_ajax_multiple bugfix

This should solve the #491 issue, not listing the n-n-relationships correctly

Well, but this solution still needs me to tweak my CrudController ... i.e. when having a N-N relation field called "keywords":
public function update(UpdateRequest $request) {
	// your additional operations before save here
	$t = request();
	$t->request->set('keywords', preg_split('~,~', $request->get('keywords', '')));

	$redirect_location = parent::updateCrud();
	// your additional operations after save here
	// use $this->data['entry'] or $this->crud->entry
	return $redirect_location;
}

Hi @stevenbuehner ,
Thanks a lot for the PR - it was really really helpful. I've merged it into dev and improved upon it a bit. I hope :-)
I upgraded all select2 fields to the latest version of select2.js, so that we could use ajax on select elements, not only input[type=hidden]. It was such a drag to do it, because the syntax and css changed between select2 versions, but the good news is that we no longer need that 	$t->request->set('keywords', preg_split('~,~', $request->get('keywords', ''))); fix now :-)
You should be able to test all brand-new select2 fields on the dev branch this week, then next week it will be on master, available to everyone.
Thanks again for this fix, it's been really valuable.
Cheers!


Enable SRGB (fix #921)

This fixes #921, the error Error creating GL context; Couldn't find any pixel format that matches the criterias..
I'm not sure whether this is right and ideal solution, but this change actually fix the issue for some people including me.

Might be interesting to see how this works on MacOS. Even without the issue present it seems to work fine on my linux machine.


Place Details field list has "review" instead of "reviews"

According to the Place Data Fields table, the field name should be reviews plural. Currently, review singular is listed.

Note: both work in the API. Justification for updating:

Consistency with the table
The response delivers multiple reviews (if available), so the request should match the plural nature of the expected response.


Empty voice file

I want to download a voice message:
bot.on('voice', (msg)=>{       const voiceId = msg.voice.file_id;       bot.downloadFile(voiceId,'./').then((resp) => {         console.log(resp);       });  });
But the downloaded file is empty.  Maybe this is due to the fact that I use a proxy? (Telegram is blocked in Russia)

It is not empty. I try to use getFileStream() and I have same problem. It's work, when I use request module with socks5-https-client, I can save it by url from getFileLink(), but I can't understand why downloadFile and
getFileStream doesn't work.

Maybe you can try with adding logs inside downloadFile function and discover the problem.

It could either be because of the proxy or because of #583. Needs further investigation.


initial move to k3s-io

Signed-off-by: Jacob Blain Christen<EMAIL_ADDRESS>

Part of https://github.com/rancher/k3s/issues/2189


Please rename class, method, variable ...

Please change the name to:
Class: a => C00001a; b => C00002b ...
Method: a => m0001a; b => m0003b ...
Variable: a => f0001a, b => f0001b ...
Because in a class there are many "a" namesake methods so it is easy to confuse and compile errors. The variables are the same, especially the variable "i". It will be duplicated if there is a "for" loop inside.
The classes located in the java directory should be put inside p000.
JADX has done very well in this recent update.
Please follow.

We will not be doing this, we only parse what baksmali returns.


importRDF won't work in Neo4j Enterprise 3.1.2 (Educational)

I've been struggling to import my N-Triples file into neo4j using the neosemantics plugin. When I try to import my RDF file ...
CALL semantics.importRDF("file:///home/jones/wmss/data/statements.nt","N-Triples",{shortenUrls: true});
... I get the following error message:
Failed to invoke procedure semantics.importRDF: Caused by: java.lang.RuntimeException: Error executing in separate transaction: java.lang.UnsupportedOperationException: Creating new transactions and/or spawning threads are not supported operations in store procedures.
I've tried everything I could find in the web and had no success, including the following changes in the neo4j.conf:
dbms.memory.heap.initial_size=15g
dbms.memory.heap.max_size=20g
dbms.unmanaged_extension_classes=semantics.extension=/rdf
dbms.connectors.default_listen_address=<IP_ADDRESS>
dbms.security.procedures.whitelist=semantics.*

Ubuntu Server 16.04 LTS
Neo4j Enterprise 3.1.2 (Educational License)
Neosemantics: neosemantics-<IP_ADDRESS>.jar
What am I missing here? Any suggestion will be much appreciated. Thanks!
Note: Using the community / desktop editions the import works just fine.

Hi Jim, thanks for trying out neosemantics and sorry for the late reply.
I believe you're having a version compatibility issue: neosemantics-<IP_ADDRESS> is built for Neo4j 3.4.x
Can you upgrade your neo4j instance to a more recent version?
The earliest version of neosemantics is <IP_ADDRESS> built for Neo4j 3.2.x
(check the releases page https://github.com/jbarrasa/neosemantics/releases)
Might be worth a try on your 3.1 if upgrading is not an option?
I hope this helps.
JB.

Hi there! Thanks for the answer, unfortunately it reached me on my vacations: that's why the late answer.
I wish I could upgrade the version of my Neo4j Enterprise. Unfortunately, the Educational License just covers the Enterprise Server 3.1.2. I definitely could get rid of this version and install a newer one, but our research group cannot afford the newest enterprise.
Which version of neosemantics would be compatible with Neo4j 3.1.2?
Greetings from the University of Münster,
Jim

Hi Jim,
I've not tried it but I guess, all we'd need to do is build it against 3.1 and that should do the job.
However, and before we do any of that, the version lock on your license does not make sense to me. You should be able to upgrade to the latest version of our software within your Educational License. Let's take this offline. Can you email me on jesus at 'the graph database that we love' dot com.
Thanks,
JB


Working with list of list of triple bytes + BMP/PNG on Linux (Ubuntu) + Emacs + Fsharpi (Any CPU)

Please provide a succinct description of the issue.
I have this non-deterministic behaviour when I try to convert pixels from an image to a list of list of triple bytes (R,G,B) on my Linux box in combination with Emacs + Fsharpi and Mono
Repro steps
Download the following PNG file and use the code from the following GIST

Evaluate code in Emacs by marking it (CTRL+SPC) and (CTRL+C CTRL+R). You will see some non-deterministic errors (related to memory of Object references, see GIST for more info)

Expected behavior
I would expect to create a list of list of triple bytes (R,G,B)
Actual behavior
As mentioned before, it provides some non-deterministic errors
Known workarounds
In order to make this work I store all pixels in a single list and then store the width and height of the picture.
Related information
Provide any related information

Operating system: Ubuntu 17.10
Branch: Microsoft (R) F# Interactive version 4.1 | /usr/lib/mono/fsharp/fsiAnyCpu.exe
.NET Runtime, CoreCLR or Mono Version: Mono JIT compiler version <IP_ADDRESS>
Editing Tools (e.g. Visual Studio Version): GNU Emacs 25.2.2
Indications of severity: I guess low-priority as everything related to Linux right?

There must be a repro for this without using Emacs?

I can't recreate it from the terminal by just executing ./SpiseMisu.Minecraft.Picture.fsx
That seems to work.

I'm going to close this since I think we need a repro based on the command line tools, not FSI in emacs.  Strange problem though


network_state review

Need to use a better name, I believe even NetworkMap is a bettername, if we must create a type definition, also there's no reason not to export it?

inconsistently, we have this NodeIPs exported, and deploymentIps unexported, also is it a node to IP or a node to multiple IPs?

Linter should have complained about having a factory function for an unexported type?

GetNetwork returns an Interface Network, which I argue we don't really need it you should use a concrete type, also returning an interface in general from functions, well maybe except for the error interface is redflag, let aside that you're also returning a pointer to network

why didn't we not return n.NodeIPs[nodeID] directly ?

you can safely call delete on an uninitialized map
also, all of the exported functions need to have proper comments , and a package comment as well https://tip.golang.org/doc/comment

why didn't we not return n.NodeIPs[nodeID] directly ?

because we need the ips of the deployments

for readability and correctness, lets

replace deploymentIPs with deploymentHostIDs as it's a map from deployment to reserved host IDs
replace NodeIPs, to NodeDeploymentHostIDs map

should reflect also in the remaining functions to denote it's a HostID not an IP, maybe we can add IPs based on the subnet, but never treat the hostID as an IP


[Addition] NormalASM

Checklist

[X] I've checked that my mod suggestion hasn't already been added to one of the lists.
[X] I've checked the latest issues to make sure that this mod hasn't already been suggested.

What is your mod's name?
NormalASM
What is your mod's main version?
1.12.X
What is your mod's other versions?
No response
What is your mod's type?
Preformance
What side dose your mod need to run on?

Optimize RAM Usage
(OPTIONAL) Give some extra information about the mod.
rebranded fork of CensoredASM
incompat with VanillaFix, TexFix, CensoredASM

https://github.com/TheUsefulLists/UsefulMods/issues/60#issuecomment-1085609985
If this is the case then why is CensoredASM still here?

NormalASM was removed from CurseForge and the last commit was almost a year ago. CensoredASM meanwhile had several updates since then. I'd say it's safe to close this.