Validating number ranges

I couldn't find anyway to validate that a number is above/below some value or inside a range. Neither for inclusive ranges or exclusive ones.
In Zod this is done with the gt and lt for exclusive ranges and gte and lte for inclusive ranges. (Zod also has positive, negative, nonpositive and nonnegative for ranges bounded by 0).
https://zod.dev/?id=numbers
(It is possible that this feature is already implemented in valibot and I just couldn't find it)

That works with minRange and maxRange:
import { maxRange, minRange, number } from "valibot";

const NumberSchema = number([minRange(0), maxRange(50)]);

Thank you! are these inclusive ranges? (would 0 and 50 be valid in your example?)
I think minRange/maxRange has slightly unintuitive names for me. Maybe it won't matter once the documentation site is up but I believe the order of names I looked for was something like this before I posted the issue:

gt/lt - based on Zod's names
min/max
minVal/maxVal - (minSize and maxSize exists so I kind of expected a parity with the function names there)
range

Yes, 0 to 50 are valid values in this example. I know how this is implemented in other libraries, however, the approach I chose has a comprehensible reason.
Valibot is a completely modular library, which consists of many small functions. Some functions like minRange can be used in several contexts.
minRange uses the < operator to validate whether a value is at least as large as the specified value. If we only look at the source code of minRange, the name is exactly right.
minRange can now be used for validation in the pipeline of string, number, bigint and date. This approach reduces the bundle size and prevents duplicate code within the library.
Since there are several validation functions that validate a minimum value, for example also minLength and minBytes, the naming min is not possible. minNumber would be more suitable for number, but confusing for string and date.
However, I welcome alternative ideas to further improve the API. Feel free to share your thoughts here or create new issues if you have ideas or feedback on other areas of the library.

The nice thing about valibot is that you can easily create your own validation functions:
export function gt<
  TInput extends string | number | bigint | Date,
  TRequirement extends TInput,
>(requirement: TRequirement, error?: string) {
  return (input: TInput, info: ValidateInfo) => {
    if (input <= requirement) {
      throw new ValiError([
        {
          validation: 'gt',
          origin: 'value',
          message: error || 'Invalid range',
          input,
          ...info,
        },
      ])
    }
    return input
  }
}

export function lte<
  TInput extends string | number | bigint | Date,
  TRequirement extends TInput,
>(requirement: TRequirement, error?: string) {
  return (input: TInput, info: ValidateInfo) => {
    if (input > requirement) {
      throw new ValiError([
        {
          validation: 'lte',
          origin: 'value',
          message: error || 'Invalid range',
          input,
          ...info,
        },
      ])
    }
    return input
  }
}

parse(number([gt(5), lte(80)]), 6)  // returns 6
parse(number([gt(5), lte(80)]), 5)  // throws
parse(number([gt(5), lte(80)]), 80) // returns 90
parse(number([gt(5), lte(80)]), 81)  // throws

Yes, or you can simply rename the exports:
import { maxRange as lte, minRange as gte, number } from "valibot";

const NumberSchema = number([lte(0), gte(50)]);

You can also easily export minRange yourself under several names like minNumber and minDate.
export { minRange as minNumber, minRange as minDate } from "valibot";

I understand that I can just create my own validation function or even make named imports to have it the way that fits my personal preferences. But the concern I was raising is that minRange might be unintuitive for other developers as it was for me. This can make it harder to find the right function (which was the problem I had) and it can make the code harder to reason about (it's unrealistic that everyone will make the same named import - that only happens in Python land).

minRange uses the < operator to validate whether a value is at least as large as the specified value. If we only look at the source code of minRange, the name is exactly right.

It might describe exactly what it does, but from the perspective of a user it might not be the most useful name. Try to read the following code and consider how a user might understand it:

string([minLength(x)]) -  validates that a string  has the minimum length of x.
map([minSize(x)]) -  validates that a map has the minimum size of x.
number([minRange(x)]) -  validates that a number has the minimum range of x.

But it doesn't make sense to say that a number or date has a "minimum range". You would maybe say a number has a minimum value of x or that a date has a minimum date of x. I am not sure if I can come up with a scenario where it would be make sense to use the comparison operator to validate a string, but I suspect that in such a scenario you wouldn't say that you are validating that the string has a minimum range of x.

minNumber would be more suitable for number, but confusing for string and date.

I agree that minNumber would be bad for string and date, but I also think it would be bad for number. It doesn't make sense to say that the minimum number of a number is x. Also the code would haver "number" twice which is a bit redundant: number([minNumber(x)]).

since there are several validation functions that validate a minimum value, for example also minLength and minBytes, the naming min is not possible.

I would argue neither of those functions validates minimum value. They validate the minimum length and the minimum byte length respectively. Why does it make renaming minRange to min impossible? Is there some technical reason I am missing here or do you think it will be confusing for developers using it? The typings would still prevent people from using the wrong one, in case they thought they could use min on an array or something.

However, I welcome alternative ideas to further improve the API. Feel free to share your thoughts here or create new issues if you have ideas or feedback on other areas of the library.

In summary:
I think min/max would be preferable to minRange/maxRange. It intuitively makes more sense to me.
If it isn't possible for technical reasons I think it would be preferable to have separately named API's for number and date so we could use minVal/maxVal and before/after for them respectively (I understand that you like the modular approach where the same functions are used for multiple types, but I am just telling you what I find most sensible).

Thank you for taking the time to go into this in such detail. 💙 I agree with you that minRange is not intuitive.
What would you think about renaming minRange and maxRange to minValue and maxValue? That would make sense to me, especially after your input, since we validate the length with minLength, size with minSize, and then value with minValue.

For what it's worth, the Web standard simply uses min/max

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#:~:text=of autocomplete options-,max,-date%2C month

I see. My thought comes from the fact that besides minLength and maxLength there is also length. The same with size and bytes. To test an explicit value, we could also add value.
Also, when the other validation functions are taken into account, the approach with minValue makes the API more consistent for me. However, I also understand your thoughts.

I have now implemented it this way, but I am still open for discussion.

I actually had the exact same issue as @emilbonnek. I think I too would prefer min/max for numbers as it is what I intuitively reach for without checking the docs.

For what it's worth, the Web standard simply uses min/max

This is a strong point for using min/max too.
Also, having written a few zod schemas involving dates, I think I would actually prefer separate before/after aliases for validating date ranges. This is because I often have to mentally process the concept that a minimum date means all dates larger and therefore after it are valid. Having the function named after could help with easier understanding and a self-documenting API. 😊

Thank you for your feedback. I will think about it and look forward to other people's opinion about it.

Since this library is all about modularity I don't understand why we have these multipurpose functions. I'd think that I can validate different sizes and lengths like this:
number([gte(0), lte(50)]);
string([prop("length", [gt(10)]))])

These functions are not multipurpose. They each have a single and clearly defined task. If a function can be used in different places, it would not make sense to write the same code twice. Please explain in more detail what your statement refers to, so that I can better understand it and include it in the further development of the library.

Yes, 0 to 50 are valid values in this example. I know how this is implemented in other libraries, however, the approach I chose has a comprehensible reason.
Valibot is a completely modular library, which consists of many small functions. Some functions like minRange can be used in several contexts.
minRange uses the < operator to validate whether a value is at least as large as the specified value. If we only look at the source code of minRange, the name is exactly right.
minRange can now be used for validation in the pipeline of string, number, bigint and date. This approach reduces the bundle size and prevents duplicate code within the library.
Since there are several validation functions that validate a minimum value, for example also minLength and minBytes, the naming min is not possible. minNumber would be more suitable for number, but confusing for string and date.
However, I welcome alternative ideas to further improve the API. Feel free to share your thoughts here or create new issues if you have ideas or feedback on other areas of the library.

@fabian-hiller here you say that this once function can be used in different contexts such as string, number, bigint and date. I don't think that's very "pure".

@yamiteru, just remember this is @fabian-hiller's project. Even if you disagree, please keep it respectful.
You can always create your own custom functions. That's the reason I think this is better than existing libraries like zod. It is fully extensible while remaining slim.

@yamiteru here is the source code. As you can see, it makes no difference if I allow only string or  also number, bigint and Date as input.

@kiliman How am I not respectful?


fix:player automatic stops after few minutes for some songs

Player stopes with this error after few minutes while playing.

Hey can you assign this issue to me?

Hey can you assign this issue to me?

Assigned


HDDS-11914. Snapshot diff should not filter SST Files based by reading SST file reader

What changes were proposed in this pull request?
Snapshot diff should not filter SST Files based by reading SST file reader and instead should rely on rocksdb's liveMetadataFile which also includes tombstone entries.
When creating dag compaction log as well, key ranges should also look at liveMetadataFile.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11914
How was this patch tested?
Existing Unit tests and adding more

Thanks @hemantk-12 @prashantpogde for reviewing the patch


[Backport release-0.47] tests and testing changes

Description of your changes
Backporting some test/testing fixes from main.
The elasticache replication group example had a fix in upjet, so this is a good test to run to see if we've picked that into the release branch correctly.

Fixes #
I have:

[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The above uptest run for the examples/elasticache/replicationgroup.yaml is expected to fail because we need to bump the upjet dependency to get it working. Please refer to #1163.


Quicksilver hangs when huge files stored to clipboard

I was just copying and pasting large Adobe Illustrator files (>500MB) into my clipboard for image editing work. Quicksilver was storing these files in its clipboard, and then subsequently saving them to disk using [QSLibrarian saveShelf:] every time the clipboard changed (clipboardChanged notif).
This was causing QS to hang indefinitely (writing a 1GB file to disk every time I copy/paste)
Solutions that come to mind:

Have an option to limit the filesize saved to the QS clipboard
Don't save the clipboard to disk every time the clipboard changes, but either:
a) save it periodically (e.g. every 30s) if anything's changed - downside is some things might be lost if QS crashes before saving the latest clipboard
b) Use some binary file format for saving to disk and only make incremental edits. Or maybe just something like SQLite to 'insert' new items at the top of the list and 'pop' old items off the bottom of the list.

Open for discussion, but noting this issue here now

I could have sworn we put something in there to ignore data past a certain size for this exact reason. Maybe we just talked about it. 🤷♂

I think we probably just talked about it!

Oh it's in there, just hidden and unimplemented.

OK, so a bit more debugging shows there are actually 2 places that are causing QS to hang.
Let's say you have a clipboard item from Powerpoint, it has the following types available:
(lldb) po [pboard types]
<__NSArrayM 0x600000d61890>(
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1fa551qz3fa55mr34c4qmwf22c4wpssvw1e5xbru0zg4dbsbw1g,
com.microsoft.PowerPoint-12.0-Internal-Shapes,
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1e82xnqzv1kpneqz30g6xmsb4g86u,
com.microsoft.Object-Descriptor,
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1fa551qz3fa55mr34c4qmwf22c4wpssvw1e5xbru0zk4dfrzwu,
com.microsoft.PowerPoint-12.0-Internal-Theme,
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1fa551qz3fa55mr34c4qmwf22c4wpssvw1e5xbru0yg55qr73c4y5drbw043k,
com.microsoft.PowerPoint-12.0-Internal-Color-Scheme,
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1ec6xyfy0yszwrmu0yg5dmsbdg86xrqf4a,
com.microsoft.Art--GVML-ClipFormat,
com.adobe.pdf,
Apple PDF pasteboard type,
public.tiff,
NeXT TIFF v4.0 pasteboard type,
dyn.ah62d4qmxhk4d425try1g44pdsm11g55gsu1ek2pyqfh0e4xfqr4a,
com.microsoft.DataObject,
com.microsoft.appbundleid
)

As per QSObject_Pasteboard.m:L91 when we want to add this item to the QS Clipboard we iterate through ALL types and create a QSObject with data for each type on the Pasteboard Type list. So if, for example our pasteboard item is an 8MB PDF, and we have types public.tiff, NeXT TIFF..., com.adobe.pdf, Apple PDF pasteboard type all representing some kind of PDF/image equivalent, we will be adding all these data types to QS. That means an 8MB clipboard object could well bloat to 100+MB if there are lots of different types.
QS then reads all these objects from the clipboard to save into the QSObject, reading 100MB of data from the clipboard can be slow (since the clipboard has to go ask the original app for the content in that specific type. So e.g. Powerpoint would have to then convert its internal object to a TIFF to supply to the clipboard).
That's roadblock no.1.
Roadblock no.2 is what my original post referred to - having to save all this info to the disk. It's compounded by the fact that one 8MB image might actually be 100+MB in RAM inside QS (in the form of a QS object with a huge data dictionary).
Needs more debugging/thinking through

I just downloaded Yippy and Maccy - two pasteboard apps for macOS and they both exhibit the same issue. Was hoping we could just fork one of those for this, but it looks like not. I think I'll implement the filesize limiter first, although my guess is that might not actually work - since we won't know the size of the data until we've got it.


Add make_quadratic to the documentation

https://github.com/dwavesystems/dimod/blob/54303f184427d1b3a2741cfb7ea1b1263f68a361/dimod/higherorder.py#L82

Needs to be added to the read-the-docs as well as getting a documentation refactor.


Closes #20, #31 feature request decision needed for initial envsetup.yml

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately.
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

@mstackhouse Snapshot test fails on R4.0, but passes on 4.1 and release.  4.1 and release have one fail but that is fixed in your PR.    I believe the checks are fine as is and can be merged if you agree w/the code/implementation.

@mstackhouse Snapshot test fails on R4.0, but passes on 4.1 and release. 4.1 and release have one fail but that is fixed in your PR. I believe the checks are fine as is and can be merged if you agree w/the code/implementation.

I found snapshot variants to cover this.
r_version <- function() paste0("R", getRversion()[, 1:2])

test_that("can capture version nickname", {
  expect_snapshot(version$nickname, variant = r_version())
})

https://www.tidyverse.org/blog/2021/10/testthat-3-1/#snapshot-tests
The admiralci tests though use an old snapshot date for R4.0, where these variants are not available yet.  I've requested an update with admiral ci, https://github.com/pharmaverse/admiralci/issues/61.
I don't want to hold this PR back though due to this.

@mstackhouse Snapshot test fails on R4.0, but passes on 4.1 and release. 4.1 and release have one fail but that is fixed in your PR. I believe the checks are fine as is and can be merged if you agree w/the code/implementation.

That's fine with the snapshot tests and part of the intent - since they change over time. you don't want to have to rewrite the messages constantly to maintain the tests


Using cli-color as in a module

Here is a very simple example:
File node_functions.js:
var clc = require('/usr/lib/node_modules/cli-color');

module.exports = {
  pass: function () {
    console.log(clc.bgGreen.white.bold("PASS"))
  },
  fail: function () {
    console.log(clc.bgRed.white.bold("FAIL"))
  }
};

File test.js:
var tools = require('node_functions.js');
console.log(tools.fail());

The expected result would be simply the word FAIL in bold white over red backgroud.
However the result is:

I have no idea where the "undefined" comes from.
Running<EMAIL_ADDRESS>with node v0.10.39

It comes from console.log(tools.fail()), it logs result of tools.fail() call which returns undefined.

Doh !
Changed the module for:
var clc = require('/usr/lib/node_modules/cli-color');

module.exports = {
  pass: function () {
    return(clc.bgGreen.white.bold("PASS"));
  },
  fail: function () {
    return(clc.bgRed.white.bold("FAIL"));
  }
};

Works great. Thanks.


Add log_url table to MariaDB

Which Issue(s) this Pull Request Resolves

Resolves #606
Release Note

NONE

Notes for Reviewers

rebasing to get changes from main

@maruiz93 PTAL when you have time. This is low priority though so no rush :smiley:

@maruiz93 PTAL when you have time. This is low priority though so no rush 😃

Ops! Sorry I totally forgot I have this PR pending to review, thank you for the reminder :)

rebasing from main so this PR can be merged


Suggest removing "group" from readme examples

Is your feature request related to a problem? Please describe.
Wanting to get the demo up and running:

I pasted the dependencies in
added <notifications group="foo" />
selected an element in the Vue devtools
in the console, ran $vm.$notify('hello')

Nothing happened.
Took quite a white to:

poke about in the HTML (maybe it was being hidden by existing markup / CSS)
add a debugger breakpoint in the source
wonder if it was not adding CSS, so started searching online

Finally copied the demo code including group and it works.
Then:

deleted the group="foo" attribute from the component markup
ran $vm.$notify('hello')

It worked.
The group stuff at best just seems to be additional hurdles to get in the way of at least testing the lib works, and at worst, a wild goose chase to track down issues that may not exist.
Describe the solution you'd like
Just remove the group stuff from the basic demo. People can add this later if they need it.
Might save lots of people 10 minutes each, or even prevent them from giving up and discarding the library before they've even tried it.
Thanks.

By the way, now I am up and running, I really like how it's put together!
It's really easy to completely replace the default styles, add your own content in a slot etc.
Well done :)


toc fixes

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

bread/toc.yml
:white_check_mark:Succeeded

docs-ref-conceptual/toc.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

bread/toc.yml
:white_check_mark:Succeeded

docs-ref-conceptual/node-azure-tools.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-conceptual/overview.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-conceptual/toc.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Schema integration test

A-la https://github.com/ctco/nodejs-graphql-template/blob/master/server/graphql/tests/joke.test.ts

a high level overview of what an integration test should cover (green color) vs what e2e test should cover (yellow and green colors)


[BFCL] Adding actionGemma model handler

ActionGemma is a Gemma2 9b based fine-tuned model for function calling. This PR adds model handler for the it.

Thank you for the PR and welcome! We’re currently busy with a new dataset release. I’ll review your submission later this week and aim to provide feedback by next Monday. Apologies for the delay.


Must have configurable list of topics for sink connector

Delimited String [or JSON array] that includes a list of topics from which messages will be retrieved and sent to Cosmos DB.
This is a required configuration.
No Default value.

We should think about how we map a topic name to a CosmosDB collection.
Do we insert in to CosmosDB collection matching the topic name?
If collection does not exist, do we create it?
If so, what defaults do we use when creating collections?
Do we offer some configuration that maps Topic -> Collection name?

Do we put all messages in to a single collection with a "topic" field so we know where they came from and allow users to be able to easily filter by the topic-name?

For P0 do we only support a single topic, and add multiple topics in P1 or later?

E.g. config could be -
##1:1 mapping between collection & topic
simplest P0 case 1 topic, and 1 collection
cosmosdb.collection=foo
topic=foo
extended P1 case, mult collections and multiple topics
cosmosdb.collections=foo,bah,blah
topics=foo,bah,blah
OR
##1:many mapping between collection and topics
will result in all documents being saved to DocumentCollection{coll} with a {"topic":} value being inserted in to each document
cosmosdb.collection=coll
topics=foo,bah,blah


Add option to remove logged in/out messages

Closes #9240

It's already possible to have the logged in/out messages disappear after a few seconds using an ingame option. Is this really necessary?

It's already possible to have the logged in/out messages disappear after a few seconds using an ingame option. Is this really necessary?

Like you just said the messages still appear which some people find annoying. Since the option is not on by default there is no harm in adding it.

this should not allow users to filter arbitrary LOGINLOGOUTNOTIFICATION messages
are there any messages besides the login/logout messages that use LOGINLOGOUTNOTIFICATION?

this should not allow users to filter arbitrary LOGINLOGOUTNOTIFICATION messages
are there any messages besides the login/logout messages that use LOGINLOGOUTNOTIFICATION?

Not that I am aware of, but if anyone knows if there are other messages I will gladly make changes.

DNM

What is DNM?

I think I would try blanket filtering LOGINLOGOUTNOTIFICATION since I don't think there are any other messages with that chattype.


Dev/2.0.1 Update

Multiple Change Requests for VDA 5050 Release Version 2.0.1.

Same changes done in PR #218 due to merge conflicts.


Add GRPC server and Python client

Add gRPC server (from proto codegen, using buf to handle/enforce proto best practices)
Add codegen'd Python client (usable as a pip dependency via git ref, no published package yet)
Use of the gRPC server is optional, Go deps can just keep including access-pdp as a straight library by importing the normal way:

import (
	 "github.com/virtru/access-pdp/pdp"
	 "github.com/virtru/access-pdp/attributes"
)

Add tests around server.go ?

Add tests around server.go ?

There are not because server.go is mostly a main function that initializes codegen'd server code, and there's not much to test.
The most I could write tests for would be the helper routines to translate between the codegen'd server interface types and the internal PDP types, but that seemed relatively low value so I didn't - no real gotchas there, just boilerplate.


Getting error when using path_on_compute in Input

Package Name:   Azure.ai.ml
Package Version:
Operating System: windows10
Python Version: 3.10.0

I am using Input with command job to run my python file on azure ML studio but I need to map my dataset at specific location on compute machine which I created and on that machine I am running my code here is my code for input
Input(
type=AssetTypes.URI_FOLDER,
path=DATASTORE_PATH1,
description="test data 1",
path_on_compute="/data",
)
Whenever I try to add path_on_compute variable according to this documentation but I am getting this error if anyone have idea how to use this then please let me know I am fiting with this issue since a week.

This is my error image
here us my full command code
job = command(
experiment_name="exp_test",
inputs=dict(
data=Input(
type=AssetTypes.URI_FOLDER,
path=DATASTORE_PATH,
description="test data",
path_on_compute="/data"
),
data1=Input(
type=AssetTypes.URI_FOLDER,
path=DATASTORE_PATH1,
description="test data 1",
path_on_compute="/data",
),
mlflow_url=azureml_tracking_uri
),
code=SCRIPT_FOLDER,
command="python train_classification_model.py --data-folder ${{inputs.data}} --mlflow-tracking-url ${{inputs.mlflow_url}}",
environment=custom_env_name+"@latest",
display_name="exp_test",
compute=COMPUTE_NAME,
)

Hi @arpitjivanitecan - Thanks for opening an issue! We'll investigate asap.

I'm getting the same error when attempting to submit a job with a simple Input using a datastore with mode = "download" and path_on_compute specified:

Package: azure-ai-ml
Package version: 1.19.0
Operating System: macOS Sonoma 14.6.1
Python Version: 3.10.0

my_inputs = {
    "data": Input(
        type=AssetTypes.URI_FILE,
<EMAIL_ADDRESS>        mode=InputOutputModes.DOWNLOAD,
        path_on_compute="inputs/bar.csv",
    )
}

# SNIP - MLClient and Environment defined

my_cmd = command(
    command="ls -a",
    environment=my_env,
    compute="my-cluster",
    inputs=my_inputs,
)
my_job = ml_client.jobs.create_or_update(my_cmd)
print("Job submitted to Azure ML:")
print(my_job.studio_url)

results in KeyError:
Class AutoDeleteSettingSchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Class AutoDeleteConditionSchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Class BaseAutoDeleteSettingSchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Class IntellectualPropertySchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Class ProtectionLevelSchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Class BaseIntellectualPropertySchema: This is an experimental class, and may change at any time. Please see https://aka.ms/azuremlexperimental for more information.
Traceback (most recent call last):
  File "/Users/jonny/sandbox/amltest/examples/submit_data_read_job.py", line 44, in <module>
    my_job = ml_client.jobs.create_or_update(my_cmd)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/core/tracing/decorator.py", line 94, in wrapper_use_tracer
    return func(*args, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_telemetry/activity.py", line 372, in wrapper
    return_value = f(*args, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/operations/_job_operations.py", line 660, in create_or_update
    self._validate(job, raise_on_failure=True)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_telemetry/activity.py", line 372, in wrapper
    return_value = f(*args, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/operations/_job_operations.py", line 562, in _validate
    validation_result = job._validate(raise_error=raise_on_failure)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/entities/_validation/schema.py", line 120, in _validate
    result = self.__schema_validate()
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/entities/_validation/schema.py", line 153, in __schema_validate
    data = self._dump_for_validation()
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/entities/_validation/path_aware_schema.py", line 53, in _dump_for_validation
    return typing.cast(dict, convert_ordered_dict_to_dict(super()._dump_for_validation()))
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/entities/_validation/schema.py", line 86, in _dump_for_validation
    res: dict = self._schema_for_validation.dump(self)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/schema.py", line 549, in dump
    result = self._serialize(processed_obj, many=many)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/schema.py", line 517, in _serialize
    value = field_obj.serialize(attr_name, obj, accessor=self.get_attribute)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/fields.py", line 341, in serialize
    return self._serialize(value, attr, obj, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/fields.py", line 1623, in _serialize
    result[keys[k]] = self.value_field._serialize(v, None, None, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_schema/core/fields.py", line 472, in _serialize
    return field._serialize(value, attr, obj, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/fields.py", line 645, in _serialize
    return schema.dump(nested_obj, many=many)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/schema.py", line 549, in dump
    result = self._serialize(processed_obj, many=many)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/schema.py", line 517, in _serialize
    value = field_obj.serialize(attr_name, obj, accessor=self.get_attribute)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/marshmallow/fields.py", line 341, in serialize
    return self._serialize(value, attr, obj, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_schema/core/fields.py", line 472, in _serialize
    return field._serialize(value, attr, obj, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_schema/core/fields.py", line 160, in _serialize
    return super(LocalPathField, self)._serialize(self._resolve_path(value).as_posix(), attr, obj, **kwargs)
  File "/Users/jonny/sandbox/amltest/.venv/lib/python3.10/site-packages/azure/ai/ml/_schema/core/fields.py", line 126, in _resolve_path
    base_path = Path(self.context[BASE_PATH_CONTEXT_KEY])
KeyError: 'base_path'

Same issue occurs with azure-ai-ml 1.20.0
If I don't specify path_on_compute, the job is successfully created and completes. However, the file isn't downloaded to the compute's working directory - as is the case with a script passed via the code arg to command.
How is InputOutputModes.DOWNLOAD supposed to be utilised?


emits error on slapp for slack api errors inside msg.say and msg.respond

Goal of this PR is to make sure we're logging/emitting errors that may occur from calls to msg.say() and msg.respond.  Adds a call to msg._slapp.emit('error', err) inside of the slack api callbacks in msg.say() and msg.respond()

Had to change ava to run tests serially due to mocking some global functions, i.e. slack.chat.postMessage().  Adding another test that mocks that seems to have hit some threshold where they were running concurrently and the sinon stubs were clashing.
Refactored the msg.respond() request callback to avoid some redundancy and normalize the errors prior to calling the callback and emitting the error if it exists.

👍


Floor/integer division

Add support for floor division of integers (// operator). Currently you would have to do true division, floor it, then cast from float to int. This is unwieldy and may have precision issues.
Example:
df = daft.from_pydict({"a": [4, 6, 9], "b": [2, 4, 4]})
df = df.select(df["a"] // df["b"])
# should output [2, 1, 2]

Hi @Vince7778  I've tried to add support for floor division with my PR. Looking forward to your feedback.

I will pick this up for a try since @yadomkar is not working on this anymore.

Thanks @ConeyLiu! Assigned


data

Hi, I want to know that did you train the network again using your own UAV datasets? and how do you label the train data? Or you test your data using the trained model in NCnet? Thanku

we'll be making our dataset public after acceptance of the publication and the paper has details regarding model and optimization.

Data has been open-sourced. Check README.md

Data has been open-sourced. Check README.md


[NFC] Refactor self type computation to return a Param

Remove a user of InOutType::get and flip a few users of
FunctionType::get to pass Params instead of naked input
types.

@swift-ci please smoke test

@swift-ci please test and merge


Nicer smoothed player position

I changed the smoothing of the player position to be relative to the camera position as already done by gw2Taco.
This should result in a much smoother player position unless you rotate the camera and move at the same time.

Once CI gets a build of this spit out, we'll definitely want a few folks to test and weigh in on the differences it provides.

In my initial testing of this, I am seeing a slight improvement from the current implementation, but I'm seeing far worse tracking when the camera is moved making this perhaps not a good overall replacement.  Are you experiencing these same results?
No Smoothing:
https://gfycat.com/equalhiddencrustacean
Current Implementation:
https://gfycat.com/admirableexcitableasiansmallclawedotter
This PR's Implementation:
https://gfycat.com/keynegligiblehawaiianmonkseal

The current implementation is pretty good with high fps. If you limit your fps to for example 30, you will see the circle lagging behind the character.
I tried to fix that. Problem with using the camera as reference is if you turn the camera, you get lagging behind the camera movement (which is much worse than lagging behind the character). So I added a flush of the ringbuffer on camera movement. This results in nice results if moving the camera and if moving the character but it stutters if you try to do both at the same time.
Maybe a much simpler solution would be to increase the update rate independent of the framerate. At least for the player position.

Seems like the ideal setting has the overlay set to update synced with the in-game refresh rate as is the default.  I think locking to 30 or 60 is only good if you don't have in-game 3D elements moving around. 🤔

At least for me synced with in-game refresh rate is resulting in lagging player position updates. Maybe this is because my framerate drops to about 40 in some regions. If I choose unlimited the current implementation is working pretty well.
I tried another approach using the map position, which results in a different set of problems. So i've got no good alternative to the current implementation for low frame rates without disconnecting frame update and player position update.

We may wish to either make this dynamic so that it uses a different method depending on the FPS or keep discussing our options.  What issues did you run into with the map method?  That's unfortunate to hear.  😕

I tried doing this camera-syncing for Burrito too and found most of the same issues. Many attempts later I did come up with a solution, which turned out to be quite simple. A basic rolling average with a 5 element lookback. Here is a chart I used to decide on the solution.

Here is the c code I used, it is a conflicting license with Blish HUD but I wrote it myself so dont worry about it.
https://github.com/AsherGlick/Burrito/blob/55fff1edc7b2bd4861cb72c9609d3fe14ba95fb3/burrito_link/gw2mumbleudp.c#L6-L34
https://github.com/AsherGlick/Burrito/blob/55fff1edc7b2bd4861cb72c9609d3fe14ba95fb3/burrito_link/gw2mumbleudp.c#L232-L239
And this is the result, and old dev video but shows the smoothness. The two rings are obvious but there is also a small dot at the feet if you zoom in.
https://user-images.githubusercontent.com/603989/138618167-d2c04b36-7e5d-409c-8c92-d37fbe6760d6.mp4
Hope that helps you develop your solution!


Unable to get raw HTML code inside an element

Is there any ways to get the raw HTML code (keeping all tags) inside an element? I have read through the documentation but found no section that mention about it.

Hi, @junnstudio !
Could you tell me the specific example you want to get as the raw HTML?
I'll implement and update nest-crawler for you or tell you the best library :)

Hi, @saltyshiomix !
I am developing a crawler that scrapes the content of some pieces of news.
Instead of getting back the results with all the tags removed, I'd like to get the raw HTML code so that I can easily embed it into my pages and use some extra css to re-format the HTML tags inside it in my own way.
Of course I can use other libraries for this problem but I really love your nest-crawler package and hope this issue will be tackled soon :)

@junnstudio
Oh, the best words for me!
Big thanks to your kindness and I'll implement it later today 👍

@junnstudio
Let me know how do you think this API like below?
interface ExampleCom {
  title: string;
  info: string;
}

const data: ExampleCom = await this.crawler.fetchRawHtml({
  target: 'http://example.com',
  fetch: {
    title: 'h1',
    info: {
      selector: 'p > a',
      attr: 'href',
    },
  },
});

console.log(data);
// {
//   title: '
Example Domain
',
//   info: 'More information...'
// }

@saltyshiomix
Sometimes, I don't really need to get the raw HTML code for all of the attributes inside fetch, but just some of them.
In my opinion it'd be great if your package simply provide me with something like rawHtml: true:
interface ExampleCom {
  title: string;
  info: string;
}

const data: ExampleCom = await this.crawler.fetch({
  target: 'http://example.com',
  fetch: {
    title: 'h1',
    info: {
      selector: 'p > a',
      attr: 'href',
      rawHtml: true
    },
  },
});

// {
//   title: 'Example Domain',
//   info: 'More information...'
// }

Another solution that you can reference is the how: 'html' attribute of the scrape-it package at https://github.com/IonicaBizau/scrape-it.

@junnstudio
Yes, I formally used scrape-it, but it can't resove cheerio types at the moment.

It internally uses scrape-it, and you can use its options like how: 'html' 👍

nest-crawler fetches data by default using scrape-it, but sometimes we need to wait until DOM loaded like single page applications.
If you specify the option waitFor, nest-crawler fetches data by using puppeteer.
In this way we can retrieve any web data from the crawler server :)

By the way, if you want to use puppeteer on Ubuntu, we must install other dependencies like this:
$ sudo apt install gconf-service libasound2 libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget

If you use Ubuntu, please remember this :)

@saltyshiomix
I have tried out the new version of the nest-crawler package and it works exactly as what I expected.
I highly appreciate your work. Thank you sooo much! :)

@junnstudio
Glad to hear that!
And thank you for your PR #2 , I just merged 👍


why not an official documentation available for beaker

ignore me if I make mistakes.
I didn't see too much documentation page except some overview and get-started?
Also some dead-link in the wiki.
if I want to contribute a doc/wiki,  how to start?

Hi you are right but the doc really needs to be written from scratch, or ported from the old tutorials.
Beaker has recently transformed to become BeakerX and a lot of stuff is out of date.
In BeakerX, I would start by comparing the demoFiles directory with the tutorials from old Beaker and using the converter and copy/paste to flesh out the demoFiles.  Some will need to be deleted or substantially rewritten, but much content especially prose was lost in the port and it needs to be restored.


fix 'npm run watch' docs

The command npm run watch no longer exists. It's now npm run server. This PR fixes the README.

you can just do npm start.


feat: Add UserSettings component to design system

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
Th PR:

creates a LanguagePill component to the atoms directory
adds LanguagePill to design system
adds the user settings screen to the storybook(design system)
updates existing checkbox style to match the brand color

Notes:

This has no functionality yet, just the UI
The current UI checkbox was replaced with the default checkbox in the design system

Related Tickets & Documents
Fixes #783

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[x] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

I want to point out the importance of https://github.com/open-sauced/insights/issues/791 😂
This Page is not in the Page folder. Not a big deal, but just pointing out the confusion of our current design system setup.

We should provide the list of timezones in the dropdown.
This should be in a lib - https://stackoverflow.com/questions/38399465/how-to-get-list-of-all-timezones-in-javascript
Perhaps it can be done in a new PR though

Opening a new issue to implement the form functionality, and this can be included also🍕

@bdougie A general observation, but can we separate updating Email Preferences from  Profile. There isn't a clear distinction between the two sections.

Yes, my original thought was adding it on the right. But wasn't sure if it would get buried on mobile.

Everything should float left on large screens.

This is just the form component without a wrapper... once it is plugged into a page the wrapper will be used to handle the float 🍕

We will adjust the timezone fields in implementation


PM1 / PM2.5 / PM10 Readings are incorrect (Firmware >= 17)

I am using py-opc to read out an opc-n2 - firmware version 17. The reading of PM1 / PM2.5 / PM10 should be in a range of 10-40 µg. Using your library the converted floats in the histogram are somewhat between 2000.00 - 2200.00. Any ideas? Maybe the MSB / LSB are inverted? Even when forcing bad air through the inlet the readings never really change.

Interesting. When you say you are using the converted floats in the histogram, do you mean you are using the values labeled 'pm1', 'pm25', and 'pm10'? Or are you integrating across the bins to get those values? Also, are you performing an instantaneous reading? Or are you averaging/summing across multiple iterations?  I have seven OPC-N2's here that are running great; this is quite curious and I'd love to help!

Yes. I am using those values labeled 'pm1' ... 'pm10'. I am directly reading the output I get when calling the 'read_histogram()' function. I am doing this once every second. I haven't figured out yet what went wrong.

Interesting. What are the values like across the 16 bins?

Well they are somehow strange two. The first to bins (start at bin0) are somewhere between 20-30. Bin4 is always in a range of 1500 - 1600 no matter what you do. The last bins are always 0 and only moving up to 1 - even if applying a test aerosol ...

Interesting. There is clearly something strange going on. Have you tried running it with their software? If so, do you see something similar?

Yes I have done that. And everything is running as expected. I will clean the system and do a reinstall of the whole software - hopefully that will help. I will let you know. - However, I was hoping this might be a known issue and that there might exist a fix. Thanks anyway!

You are using the opc.OPCN2 class, correct?

After doing a clean reinstall of almost everything I found out what caused the bad reading. I somehow installed it to a +3.3V rail. Interesting that communications where still possible. I really had no clue because the everything seem to work - except for the software.
The Values I get are now much more useful. I will close this for now. Anyway I might still have some questions concerning average calculations, etc. I will use the email that if seen here somewhere! Thanks,
Simon


Repo name?

Thank you for the project! I have some feedback from using this.
I'm already used to the current repo name at this point but before I forget!  Would this repo be better named zap2docker-auth-weekly, or something else? The reason I ask is:

the docker image itself is ictu/zap2docker-weekly
the use of zap-baseline conflicts with an individual script of OWASP, but this project can (and often does) trigger zap-api-scan.py and zap-full-scan.py in addition to zap-baseline.py (e.g. it uses owasp/zap2docker-weekly)

Hi, you are right. The name was because the project started as a modified baseline scanner, but eventually evolved into an authentication hook.
I'll look at chaning the repo name. Changing the Docker image name may have more implications because many projects are already using it.

Noted on how the project evolved from a baseline scanner! That makes sense!
Also thankfully I was just referring to the name of the github repo for this case, so changing this GH repo's name is safer since it will forward from the old name to the new one, also it won't be disruptive as the docker side of things. If you wanted to.
Should I close this for now? I assume my point has been taken (thank you!). Or it can wait until you feel fit to change the name sometime (if you ever do)

@tony change, thanks for the feedback!

Much less ambiguous  Nice!


Fix and enable core unit test coverage

I was able to track down what was causing the coverage to hang, but in the end I don't have a fully clear idea of why it's failing for us and presumably not for VS Code.
The line in question that led me to the fix was this :
[4225:0318/190144.273645:INFO:CONSOLE(109)] "Uncaught SyntaxError: Unexpected token '??'", source: vm.js (109)
After digging around in loader.js for a bit I was able to get it to spit out what file it came from and from there was just a matter of seeing which one of the ??'s was causing the issue.
There are numerous other reports of similar invalid code generation being done by instanbul, but since this fixes the issue and is relatively scoped I chose to end my investigation here since there isn't much value to be gained currently from digging into it more.
https://coveralls.io/builds/47508431

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.7%) to 44.343%

Totals

Change from base Build<PHONE_NUMBER>:
-3.7%

Covered Lines:
31297

Relevant Lines:
65329

💛  - Coveralls

Can we map so that we're not comparing the out directory but instead the sql directory?

I'll take a look at it if I have time (but not going to prioritize it unless we have a specific need for that asap), but first order of business is to at least get these up and running again.

@chlafreniere Ok, this should fix generating coverage for the ts files now. The line commented out was added as part of the last merge - I'm going to follow up with VS Code to see if I can understand why it was added since there isn't any clues in the commit and I'm not sure why this would need to be done.
https://github.com/Microsoft/vscode/commit/43552705438d57a706cba465ee3a2c354124a082
This should be safe to do since it's only affecting local build - product builds weren't affected by this to begin with.

Filed issue in VS Code repo as well since this happens in their repo as well : https://github.com/microsoft/vscode/issues/145598

@chlafreniere Thoughts on the marked.js file showing up separately? Since it's not compiled I'm not sure there's a way to map it back to the one under src/.
So we could either leave it as it is or just remove it from the report completely.

@chlafreniere Thoughts on the marked.js file showing up separately? Since it's not compiled I'm not sure there's a way to map it back to the one under src/.
So we could either leave it as it is or just remove it from the report completely.

Personally, I'd vote for just removing it. Not convinced the value add (which itself is probably not very high -- it's not like we've made lots of changes in this file) is worth it enough to have this confusion over why the "out" folder shows up for just one file.


Publish OIDC beacon in branch

I'm not sure if I'm fully convinced about this yet myself but I'll push this for comments:
This branch

removes the GH Pages publish as it just did not work
publishes the token in "current-token" branch (force pushed: it's always current main plus the token commit)
provides a GH action to download the token from the branch (we could just use actions/checkout but then the issue is that sometimes even the current token is not valid: we want retries)

I think this might be pretty good for GH actions, see an example in https://github.com/jku/oidc-token-test/blob/main/.github/workflows/test.yml. Basically this is enough to get a oidc-token.txt pretty reliably:
- uses: sigstore-conformance/extremely-dangerous-public-oidc-beacon@main

for sigstore-conformance specifically might still want to include a copy of download-token.py from this PR in that repository (in place of the GitHub API using script):

this would improve the local testing use case (no more need for GH token)
even in the GH actions case, since the conformance action may soon run the suite twice we may want both of those runs to fetch a token (to minimize possibility of expiry during run)

There is no hurry with this one: I'll let the test run at least through the weekend and see what it looks like

This is missing a README update

Notes:

This is marked draft because GIT_URL in the action currently points to my fork (for testing)
The new action is very spartan: Nothing is configurable (retry time, token filename)
It's a also a bit of a hack: uses default Python and assumes pyjwt is installed. GitHub could change things

That said, it seems to work nicely so far: see https://github.com/jku/oidc-token-test/actions/workflows/test.yml.

430 runs, one (unrelated) failure
retires seem to work fine: https://github.com/jku/oidc-token-test/actions/runs/8046303999/job/21973264075

I'm going to update this branch and make it ready for review: I've been running a test workflow for 640 runs

success rate so far 99.7%
one unrelated failure
one actual failure to get a token: https://github.com/jku/oidc-token-test/actions/runs/8053928505/job/21997397045
My stetson estimate is that >95% of runs find a good token immediately, the remaining runs find it after one sleep of 30secs


Update api to be inline with superstore-sync

Brings in the new changes from superstore-syncallowing users to supply a storage type local or session and creates a bower.json mainfest so as to publish to bower.
/cc @matthew-andrews

:+1:


ToggleButton component problem

I am trying to customize the ToggleButton element.
I can use the onLabel and the offLabel attributes just fine. However, the onClass and offClass attributes do not work.

Hi, as far as i know ToggleButton does not support the onClass and offClass ...

Yes. I know, but the primeToggleButton component still "supports" those attributes in this repo.
I managed to solve my problem with a pass-through setting for the PrimeVue toggle button.

Not in the current Version:
      v-model="context._value"
      :input-id="context.id"
      :disabled="attrs._disabled ?? false"
      :readonly="attrs._readonly ?? false"
      :input-style="attrs.style"
      :input-class="styleClass"
      :tabindex="attrs.tabindex"
      :aria-label="attrs.ariaLabel"
      :aria-labelledby="attrs.ariaLabelledby"
      :on-label="attrs.onLabel ?? 'Yes'"
      :off-label="attrs.offLabel ?? 'No'"
      :on-icon="attrs.onIcon ?? 'pi pi-check'"
      :off-icon="attrs.offIcon ?? 'pi pi-times'"
      :icon-pos="attrs.iconPos ?? 'left'"
      :pt="attrs.pt"
      :pt-options="attrs.ptOptions"
      :unstyled="attrs.unstyled ?? false"
      @change="handleChange"
    />

Should i close ?
Greetings,
Tom

Sorry for the late response.


Can OS/2's usMaxContext be automatically determined during compilation?

If so, that might be a nice feature.

My one request in adding to & changing FontTools is to keep the philosophy that it doesn't do anything 'magic' to a font. In other words, one can roundtrip a font via TTX with no changes to the data, other than what someone may have changed in the ttx file by hand. If you want it to automatically do things, great, but these should be turned on with switches, not part of the default behavior.

That field is extremely bogus.  That said, yes, we can add code to calculate it.

yes, I also think feaLib should be responsible for calculating this.
we can reuse @jamesgk's code from
https://github.com/googlei18n/ufo2ft/blob/master/Lib/ufo2ft/maxContextCalc.py

Put it in otlLib? Then it can also work for other feature file formats, such as Monotype’s feature files or (eventually, once Denis finishes his library) VOLT.


feat(MeasureTheory/MeasurableSpace/Basic): sigma-algebra generated by an element

We give an explicit characterization of the sets in a σ-algebra generated by a singleton.

If there were a way to directly rewrite ∃ x : Set Prop, p x as p Ø ∨ p {True} ∨ p {False} ∨ p {True, False}, the proof could be simplified a bit.

Thanks!
bors r+

bors r-

Thinking about it. If we really want to prove results about cardinalities of finite sigma-algebras, it'd be better to prove that the sigma-algebra generated by n elements has cardinality at most 2^(n + 1), instead of only having the case n = 1.


2.x Fix menu item compatibility with WPML

Issue
WPML uses a custom nav menu item class: WPML_LS_Menu_Item.
When this menu item is passed to MenuItemFactory::from(), the method ignores it and returns null which violates the return type of the array map closure in Menu::convert_menu_items() leading to a fatal error:
PHP Fatal error:  Uncaught TypeError: Timber\Menu::Timber\{closure}(): Return value must be of type Timber\MenuItem, null returned in vendor/timber/timber/src/Menu.php:289
Stack trace:
#0 [internal function]: Timber\Menu->Timber\{closure}(Object(WPML_LS_Menu_Item))
#1 vendor/timber/timber/src/Menu.php(288): array_map(Object(Closure), Array)
#2 vendor/timber/timber/src/Menu.php(213): Timber\Menu->convert_menu_items(Array)
#3 vendor/timber/timber/src/Factory/MenuFactory.php(276): Timber\Menu::build(Object(WP_Term), Object(stdClass))
#4 vendor/timber/timber/src/Factory/MenuFactory.php(101): Timber\Factory\MenuFactory->build(Object(WP_Term), Array)
#5 vendor/timber/timber/src/Factory/MenuFactory.php(47): Timber\Factory\MenuFactory->from_location('site-header...', Array)
#6 vendor/timber/timber/src/Timber.php(986): Timber\Factory\MenuFactory->from('site-header...', Array)
#7 web/app/themes/foobar/includes/Site.php(966): Timber\Timber::get_menu('site-header...')
#8 web/app/themes/foobar/includes/Site.php(296): App\Theme\Site->get_timber_menus()
#9 web/wp/wp-includes/class-wp-hook.php(308): App\Theme\Site->filter_timber_context(Array)
#10 web/wp/wp-includes/plugin.php(205): WP_Hook->apply_filters(Array, Array)
#11 vendor/timber/timber/src/Timber.php(1278): apply_filters('timber/context', Array)
#12 vendor/timber/timber/src/Timber.php(1169): Timber\Timber::context_global()
#13 vendor/locomotivemtl/wp-lib-theme/inc/Template/AbstractTemplate.php(40): Timber\Timber::context()
#14 web/app/themes/foobar/includes/Template/BaseTemplate.php(19): App\Theme\Template\AbstractTemplate->__construct()
#15 web/app/themes/foobar/theme/404.php(9): App\Theme\Template\BaseTemplate->__construct()
#16 web/wp/wp-includes/template-loader.php(106): include('...')
#17 web/wp/wp-blog-header.php(19): require_once('...')
#18 web/index.php(18): require('...')
#19 {main}
  thrown in vendor/timber/timber/src/Menu.php on line 289

Solution
I propose adding a hook to MenuItemFactory::from() to allow integrations to convert any non-standard menu item into an acceptable menu item: WP_Post.
In WpmlIntegration, I've added a callback on this new hook to convert WPML's WPML_LS_Menu_Item into WP_Post.
The hook is named timber/menuitem/pre_from but the suffix, pre_from, is not my favourite name. I'm open to suggestions.
Impact
Adding an extra hook could affect performance but I should be minor.
Considerations
Alternatively, a filter to convert non-standard menu items could be applied to a late-callback on wp_get_nav_menu_items but that risks affecting any logic elsewhere that expects that custom menu item.
Testing
A unit test for the filter has been added to TestMenuItemFactory: testMenuItemPreForm().

Hey @mcaskill, that’s a good catch! Thanks for putting together this pull request!
I recently ran into a similar issue and I think a filter for menu items is a great solution.
@nlemoine and I recently discussed that factory methods don’t have strict parameter types. In the future, we might want to use a function signature that forces a type. We already started to do this in a lot of other places. So the from() method could then look like this:
public function from(WP_Post $item, Menu $menu): ?MenuItem {}

(To handle post IDs, we would maybe need a from_id()` method.)
When the filter is inside the from method, it would not be possible to add strict types. So I’m thinking about a different place to do this. Maybe Menu::convert_menu_items() would be a better place for the filter?
Or even a filter in Menu::build(), before $nav_menu->convert_menu_items() is called? This way, we could make sure that as soon as the menu items are processed by Timber, they will always be WP_Post objects.
$sorted_menu_items = apply_filters('timber/menu/items', $sorted_menu_items, $menu);

// Create Menu object
$nav_menu = new static($menu, (array) $args);
$nav_menu->sorted_menu_items = $sorted_menu_items;

// Convert items into MenuItem objects
$sorted_menu_items = $nav_menu->convert_menu_items($sorted_menu_items);

As you said, I wouldn’t hook into wp_get_nav_menu_items either.
I would also like to get @nlemoine’s opinion before proceeding with this.

Or even a filter in Menu::build(), before $nav_menu->convert_menu_items() is called?

Sounds good to me!

So, should this filter be applied to each menu item or to the batch as a whole?
$sorted_menu_items = array_map(function ($item) use ($args) {
    return apply_filters('timber/menu/pre_convert_menu_item', $item, $args);
}, $menu_items);

// Convert items into MenuItem objects
$sorted_menu_items = $nav_menu->convert_menu_items($sorted_menu_items);

$sorted_menu_items = apply_filters('timber/menu/pre_convert_menu_items', $sorted_menu_items, $args);

// Convert items into MenuItem objects
$sorted_menu_items = $nav_menu->convert_menu_items($sorted_menu_items);

I actually stumbled upon PagesMenu::pre_setup_nav_menu_item() which could be added to Menu (or similarly named method) and have the filter called there.

Coverage: 88.773% (-0.03%) from 88.806% when pulling 7224a97a6cd81b2551fa888146e6a060b07fa5a4 on mcaskill:2.x-fix-wpml-menu-item into 2b6c87a2359f3ec335e56b4291bea81abe42c381 on timber:2.x.

Feels better to apply the filter on the array of items, more similar to wp_get_nav_menu_items, what do you think @gchtr?

Intuitively, I would loop over the whole array and not over each item individually. This has the added benefit that you could filter items, too. But the intended usage would definitely be to convert the items.

I actually stumbled upon PagesMenu::pre_setup_nav_menu_item() which could be added to Menu (or similarly named method) and have the filter called there.

This method is used to convert items that are not native menu items yet. It works for posts. For terms, this it would have to be a little different for maximum compatibility. I wouldn’t use this method on all menu items. But it could be used for items added to a menu dynamically.
We sometimes use a function that contains this logic in our projects if we want to add all child pages of a page as sub nav items. Or automatically adding terms a subitems to a nav menu item, if they contain posts.
A Menu::pre_setup_nav_menu_item() function could make sense if we filtered each item individually. But if we loop over the array, we prepare and convert the items before they are added to the Menu object. For working with the items in the Menu object, this could make things easier if can expect that they always have the same type.
Or did you have something different in mind?

I've updated the pull requests initial description and force-pushed the new solution as proposed by @gchtr which I had somehow missed/misread.

Thanks for the suggestions.
I agree that timber/menu/pre_convert_menu_items gives the impression of short-circuiting given WordPress' usage of pre_ in hook names.
The name timber/menu/item_objects seems like the best option so far.


Add transparent exclude tab theme

add exclude tab dark theme
To avoid collapse of pinned and unpinned tabs
like this

Thanks for the contribution!


add user paths for version check, fix path field access

The initial version check is done before adding the path variables specified in the user's config file, so if the user is counting on that to set the lean path, the version check will always fail. exec defaults to /bin/sh, so if that's not your login shell, the vscode config is kind of the only way to do it. Alternatively, the extension could use SHELL to figure out what shell is actually being used and pass that to exec.
    const user_shell = process.env.SHELL
...
        const { stdout, stderr } = await promisify(exec)(cmd, {cwd: folderPath, shell: user_shell })

I took the code to update the process path from leanclient.ts, but I think paths.join(path.delimiter) + path.delimiter + process.env.Path needs to be broken up into either process.env.Path (for windows) and process.env.PATH for everything else, as you did with the pathKey getter. As of 122c7e3, the process ends up with :undefined tacked onto the end of PATH for non-windows systems.

Oh wait, exec uses the shell?  That's really unnecessary.  Unless you want to look into that, I'll refactor it.
Could you please extract the whole environment variable setup into a separate function, so that it is not duplicated between the two files?

As of 122c7e3, the process ends up with :undefined tacked onto the end of PATH for non-windows systems.

Well spotted!

Could you please extract the whole environment variable setup into a separate function, so that it is not duplicated between the two files?

It's now in src/config.ts with the other utility functions for the user config.

Oh wait, exec uses the shell? That's really unnecessary. Unless you want to look into that, I'll refactor it.

The docs say exec spawns a shell by default but execFile doesn't:
The child_process.execFile() function is similar to child_process.exec() except that it does not spawn a shell by default. Rather, the specified executable file is spawned directly as a new process making it slightly more efficient than child_process.exec().

f7feac1 swaps out execFile for exec.


Unicode 8.0 Support

With Apple announcing imminent support for Unicode 8.0 emoji, it seems like we'll need support for it sooner than when the Unicode 8.0 spec is due to be finalised.
Do you folks have any plans for implementing this, or how to tackle the various parts of it? Are there places where the wider community can assist?

@pento wrote:
With Apple announcing imminent support for Unicode 8.0 emoji

The update is out now, see:
http://blog.emojipedia.org/apple-2015-emoji-changelog-ios-os-x
Regards

Talking about JS logic, the biggest change to consider is diversity
I need to implement a smart way to both catch all possible diversity aware emoji and transform them as single image.
The API should be ideally backward compatible, no changes to the current logic, skin-tone related char eventually passed around instead of the variant one to keep it simple.
The initial idea was also to eventually style directly SVG images but this does not seem practical so as soon as I have assets diversity aware I'll be more than happy to find some spare time and implement this on top.
All generators and RegExp aggregators logic will be affected, and same thing might happen for flags, beside the fact that for these no skin-tone or variant char would be passed around.
This was just a heads up from my side, but again I won't work on it until I know there are/will be assets.

I've been playing around with generating the diversity variations from the SVG files - it's not too tricky so far, though I expect there'll need to be a bunch of variations. For example:

Apart from the colours needing some tweaking, clearly the eyes in black Santa need to be changed, too.

@pento twemoji assets sources are AI files, SVG are automatically generated. Please do not waste too much time on SVG only, unless you think is beneficial for quick comparison, 'cause we are not going to modify SVG at runtime via JS, we need assets to reflect already different skins

Yeah, I've written it as a function in svg.sh. I'm generating from SVG, because that's easier to deal with than generating from AI.
skintone() {
  local f
  local key
  local tonecode
  local tone
  local content

  local tonecodes=(1f3fb 1f3fc 1f3fd 1f3fe 1f3ff)
  local tones=(ffe0c4 e2b98f dfa675 d79e84 5b0000)

  local normal=(1f385 1f466);

  for f in "${normal[@]}"; do
    for key in "${!tonecodes[@]}"; do
      tonecode="${tonecodes[$key]}"
      tone="${tones[$key]}"

      content=$(
        cat "svg/$f.svg" |
        sed "s/#d79e84/#$tone/g"
      )

      echo "svg/$f-$tonecode.svg"
      echo "$content" >"svg/$f-$tonecode.svg"
    done
  done
}

interesting. How would you automate this procedure in order to bring all tones to every tone-code aware emoji?

normal would be an array of all of the emoji which currently have #d79e84 skin tone. There'd be a similar array for emoji with the yellow skin tone. I'm not sure that there's a way to make it less unwieldy than that - at some point, we need to maintain a list of the emoji that have tone modifiers.
There are at least two exceptions I haven't figured out the best way to handle, yet:

When the skin tone change doesn't fit with other colours in the emoji (ie, black santa)
The handful of emoji with different default skin tones (purple and red, in particular)

The great advantage of Twemoji is that this approach works - all of the images are flat, so we don't need to worry about handling shadows.
This would generate all of the variations for SVG. It doesn't help for PNG, sadly. I'm wondering if it's possible to do this against the AI files, instead.

at some point, we need to maintain a list of the emoji that have tone modifiers.

all generators parse directly from Unicode .org files in order to reflect standards as much as possible. I really wish we don't have to maintain manually a thing ;-)
About your concerns, that is why I think we should have ad-hoc assets (AI) so that we are sure the emoji will be a good looking one.

Good points. It'll probably end up being just as much (or more) effort to maintain the tone generator, as it would be to create individual assets.

@pento wrote:
I've been playing around with generating the diversity variations from the SVG files

Please note that the latest Draft Unicode Technical Report 51:
http://www.unicode.org/reports/tr51/
says this:

When a human emoji is not immediately followed by a emoji modifier character,
it should use a generic, non-realistic skin tone—such as (RGB #FFCC22),
one of the colors typically used for the smiley faces.

Apple and Google already have begun doing this, as their default "humans" are now yellow, see:
http://blog.emojipedia.org/apple-2015-emoji-changelog-ios-os-x
http://blog.emojipedia.org/android-50-emoji-changelog
So IMHO the default Twemoji humans should also be yellow.
Regards

Hello,
if you will modify/add the skin colors as part of the skin tone modifier feature, it would be nice if you could also take a look at the following issues:
https://github.com/twitter/twemoji/issues/71
https://github.com/twitter/twemoji/issues/72
and change those colors as well.
Regards

Hey @WebReflection, sorry to pester, have you had any updates from your contacts within Twitter on the state of Unicode 8 emoji?

nope ¯_(ツ)_/¯

The Apple Emoji set soon will feature Unicode 8.0 Emojis, see:
http://blog.emojipedia.org/ios-9-1-includes-new-emojis/
Regards

Just to give an update, this is something we're working on within Twitter.
Look for updates in the near future within twemoji!

@caniszczyk That's great to hear. Don't forget @pento's point about the eye colour for black skin tones.

Great news!

iOS 9.1 is now out with over 150 new Unicode 8.0 emoji.

@kurisubrooks Indeed, I had the beta some time ago which help me create this list and update my own emoji library:
http://rodrigopolo.com/files/emojilist/
https://github.com/rodrigopolo/minEmoji

great!
On Thu, Oct 22, 2015 at 10:58 PM, Rodrigo Polo<EMAIL_ADDRESS>wrote:

@kurisubrooks https://github.com/kurisubrooks Indeed, I had the beta
some time ago which help me create this list and update my own emoji
library:
http://rodrigopolo.com/files/emojilist/
https://github.com/rodrigopolo/minEmoji
—
Reply to this email directly or view it on GitHub
https://github.com/twitter/twemoji/issues/48#issuecomment-150297737.

@caniszczyk Any update on this? Sorry to pester, just anxious for Unicode 8 support :smile:

Hi, when will the new emoji assets be added to this repo? Thanks.

Strange to see Twitter open-source a project, then completely abandon it. That's not how open-sourcing something works, Twitter.

V2 has landed with 1661 covered emoji VS just 874 in previous version.
Easy way to update?
prefix /twemoji.min.js from MaxCDN via 2/twemoji.min.js and you're good to go.


Add Onion.tube

Description of your pull request and other information

Add https://onion.tube as Invidious Instance
Fixes #
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Why is this needed? yt-dlp can now detect working invideous instances without hard-coding the URL. The old instance list is kept just for compatibility and we are no longer adding to it.

Youtube is trying to block invidious. So sometime it returns Status code 500.
If the domain is not in the list yt-dlp returns that error.

First two with current yt-dlp, and last one is when onion.tube domain in list.


TK (Techniker Krankenkasse) and possibly other insurers have switched to updated XML schema version 3.0

Problem
Attempting to validate codes results in the error:
Caused by: javax.xml.bind.UnmarshalException: unexpected element (uri:"http://www.gkv-datenaustausch.de/XML-Schema/EDFC0_Pruefung/3.0", local:"Pruefung_Freischaltcode"). Expected elements are <{http://www.gkv-datenaustausch.de/XML-Schema/EDFC0_Pruefung/2.0.0}Pruefung_Freischaltcode>

Hi thanks for opening an issue! I have time to look into this some time next week, as I am currently on vacation. If urgent (which it sounds like), I can review PRs on the subject from here.
Did you see any news on this subject? Feels kind of strange to start using a new version and stop supporting the old one just like that..
On this official page where I got the original files with version 2.0 there is no update, you still get 2.0 if you download from there. Do you by any chance know where to find the version 3 files?
All information will be helpful, if anyone else sees this and can confirm the issue it would help too

Hi,
we received the information from TK, that it was planned from GKV-SV to switch to 3.0 on 25.08.
but that this information has not reached all involved parties.
We received information about 3.0, too:
The problem from our view is, that for the moment only TK switched to 3.0 already.
Please find informations about 3.0 attached.
EDFC0-basis_3.0.0.xsd.txt
EDFC0-Pruefung_3.0.0.xsd.txt
EDRE0-MVZ_3.0.0.xsd.txt
Krankenkassenverzeichnis_DiGA.xml.txt
XML-Schema Änderungen Stand 20220524.pdf

Thanks a lot for providing the files along with the info @ManfredfromHH ! I will look into a solution next week unless someone else gets there before me, I guess one way to handle it would be to send a v3 request first and then a v2 if it fails, as it seems that we won't really know which insurances upgrade or when. It's not the prettiest solution but then again neither is it for the insurances to do major upgrades without supporting both versions for an interim period.. ;)

the new version is now officially published on
https://www.gkv-datenaustausch.de/leistungserbringer/digitale_gesundheitsanwendungen/digitale_gesundheitsanwendungen.jsp

I can second that only TK has switched so far to 3.0.
@fongie if you could provide a PR, i would be happy to review/test it asap. Unfortunately i don't have much time to work on it on my own this time

Ive got this in mind but have had more urgent things to do at work, just so you know. Ill get to it when I have a chance :)

it's a bit of a hack but I understand it's a pressing situation for you guys who are running this in production right now, so sure let's do it! If you PR against the v3-support branch I just created here I will merge into that and then release 1.25.0-v2 and 1.25.0-v3 (or similar) versions from the main and v3-support branches respectively. Then, once we create a solution that supports both, we can go back to normal releases.

#98

1.2.5-v3-xml
and
1.2.5-v2-xml
are now up on github packages and on their way to maven
the v3 one should support the new xml schemas whereas the v2 one supports the old ones
I will still try to work on a fix for the main branch to support both when I have time, but this can give you a workaround like @gtuk suggested (thanks for providing the v3 PR)

Thanks for the fast merge and release

Hey,
https://kkv.gkv-diga.de/ doesn't provide a new file with the specification of 3.0.0.
You can replace the first line in the XML, then it seems to run:
<n1:Kostentraeger_Mappingverzeichnis xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:n1="http://www.gkv-datenaustausch.de/XML-Schema/EDRE0_MVZ/3.0" xmlns:bas="http://www.gkv-datenaustausch.de/XMLSchema/EDFC0-basis/3.0" version="003.000.000" gueltigab="2022-08-25" xsi:schemaLocation="http://www.gkv-datenaustausch.de/XML-Schema/EDRE0_MVZ/3.0 EDRE0-MVZ_3.0.0.xsd">

Almost all Endpoints switched to v3 today so v2 will be obsolete soon

thanks @jakob-p that's good news! then I don't think we should worry about supporting both this time, I havent had time to do that either.. we will just merge the v3 branch into main and release from that on next release

Unfortunately the situation is much more messy/complicated.
Most of the insurances switched to v3, that is true, but only for the validation requests, not the billing requests (they are still on v2).
That means that for the validation you need to use the insurance mapping file that got released here https://kkv.gkv-diga.de/ (v3), but for the billing request you need to use a mapping file in v2. For this to work you need to update the mapping file manually as described here https://github.com/alex-therapeutics/diga-api-client/wiki/Modifying-the-insurance-company-mapping-file-(Krankenkassenverzeichnis_DiGA.xml)
There is still a problem with insurance endpoints da-api.gkvi.de and kubus-it.da-api.aok.de, based on their validation response they use version v3, but the schema that you should validate is actually v2.
<Pruefung_Freischaltcode xmlns="http://www.gkv-datenaustausch.de/XML-Schema/EDFC0_Pruefung/2.0.0" nachrichtentyp="FEH" verfahrenskennung="TDFC0" absender="XXXXXX" empfaenger="XXXXXX" version="003.000.000" gueltigab="2022-08-25">
The problem is  that the diga-api-client is checking the supported version. xsd against version from the xml response and that is not matching.
The summary/overview for the different endpoints from my side is the following:
Validation:
v3 diga.bitmarck-daten.de
v3 diga-api.tk.de/diga/api/public/rest
da-api.gkvi.de -> see comment above
kubus-it.da-api.aok.de -> see comment above
v3 diga.kkh.de
v3 itscare.da-api.aok.de
v3 arge.da-api.aok.de
diga.apimisc.de -> timeout with a test code request, so no information
Billing:
v2 diga.bitmarck-daten.de
v2 diga-api.tk.de/diga/api/public/rest
da-api.gkvi.de -> see comment above
kubus-it.da-api.aok.de -> see comment above
v2 diga.kkh.de
v2 itscare.da-api.aok.de
v2 arge.da-api.aok.de
diga.apimisc.de  -> timeout with a test code request, so no information

uhh that does sound like a mess... how are you coping with this right now? is there anything reasonable we can do on the library side to combat this?

After contacting the insurances maintaining the api endpoints da-api.gkvi.de and kubus-it.da-api.aok.de yesterday and told them about the bug on their end they released a hotfix today.
So it seems that now finally all the endpoints are using v3 for the validation. The billing is still using v2 everywhere.
For the moment we still have to maintain both versions of the library, because of version difference between the validation and the billing.
It would probably be good to separate the clients for the validation and the billing as the versions can differ as we see right now and be able to instantiate one client per method (billing, validation

One idea (far from ideal) to tackle these version problems for now is to release the different schema versions under different artifactIs e.g
<groupId>com.alextherapeutics</groupId>
<artifactId>diga-api-client-vXXXXX</artifactId>

Like this we could at least quickly react to a version change, by creating a new library with a new artifactId and we can import multiple libraries simultaneously and instantiate different clients for different scenarios (validation, billing, even by insurance prefix)

I just tried the v3 branch and send test bills to all endpoints and its working (exept for bitmarck as they dont accept the test bill as mentioned in the Readme
So v3 billing seems to be working now?

@jakob-p in the v3-support branch only the xsd files for the validation under https://github.com/alex-therapeutics/diga-api-client/tree/v3-support/src/main/resources/code-xsd are using the v3 version.
The xsd files for the billing under https://github.com/alex-therapeutics/diga-api-client/tree/v3-support/src/main/resources/billing-xsd are still using the old version

i see, thank you for the clarification and your fix!

that was just an short issue with the endpoint, not related to V3. They are still running V2 for billing.

@uvinw so far it's still the same as before as far as we can observe, only the validation moved to v3.
As far as i know there are also no immediate plans of bumping the version for billing.
Additionally has every insurance moved to v3 validation it should be much easier now to implemented everything in one library again, instead of having two versions v3 and v2 of the library

Does this mean we can merge v3-support branch into main and release from that? Or are there other updates that should be made in regards to this? I was gonna have a hand at supporting both versions but if there's no point anymore I'll avoid it hehe

Seems like this can be closed if every api is now using "v3"


Get package from local instead of URL

Use package_dir instead of a URL which is no longer open to public use
or is out-of-date.  Fixes Issue https://github.com/google-research/lottery-ticket-hypothesis/issues/2.

hello,i have run setup.py with your help successully,thank you very much.
But after that,when i try to run the download_data.py,it comes an error:ModuleNotFoundError:No Module named 'lottery_ticket'. I have checked the code,and i have never seen the method to import like that in this code.Is it correctly？How to fix it?
please help me
thanks again!

@mapleyuen96 I was using this code for a project and figured out how to get it to run.  I don't know much about python modules but this commit seems to do the trick.
Another thing is, my python isn't python3 by default, so I had to switch all appearances of "python" in the scripts to instead be "python3".
Enjoy!

@mapleyuen96 I was using this code for a project and figured out how to get it to run. I don't know much about python modules but this commit seems to do the trick. Main thing is I did pip3 install . in the main directory.
Another thing is, my python isn't python3 by default, so I had to switch all appearances of "python" in the scripts to instead be "python3".
Enjoy!

thank you for kindly replying!
I have solved the problem by 'unzip xxx.egg'(xxx.egg is generated by setup.py,i think) in python/site-packages.Although i do not know the reason,but it does work.
Howerver,when i try to run the runner/lottery_experiment.py,other bugs occur.

Initial component
('The function received no value for the required argument:', 'output_dir')

I noticed that mnist/lottery_experiment.py defines a train function,but i haven't found where to define the variable ‘output_dir’. Is it defined in a certain .py file?Or could i just insert a line of code like "output_dir = './xxx/xxx' "before using the train func?
Please give me your advice.Also,my english is not very good.If you are good at Chinese,please answer me in Chinese so that I can understand you better.
Thank you very much!


Setting up 2.0 Cluster, Can't Set Admin Password

Rancher versions:
rancher 2.0rc1, deployed on RKE
Trying to setup the cluster, but can't set an admin password. Nothing jumps out in the logs

You didn't include a full screenshot - but I've only seen this error if you're not connect w/ https.

SSL, either directly to the container or through a proxy, is required.  The UI session cookie has the secure flag set and is only transmitted over SSL.

@scottadair - not sure if you saw the comments.  please connect through https.  Will close, if you are using ssl and still have problem.  Please reopen.


REFPLTB-1015: Getting correct Operating frequency band value

Signed-off-by: Manigandan Gopalakrishnan<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/7530/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/29237/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/2450/ started


AggregatedAPIDown is keep triggering after the upgrade

What happened?
After the recent prometheus-operator upgrade, AggregatedAPIDown alert is keep triggering
Did you expect to see something different?
Excepts not to see this alert. Do we need to silence or remove this alert until the issue is fixed? https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/397
How to reproduce it (as minimally and precisely as possible):
Install/upgrade prometheus-operator version 8.13.0
Environment
All the environments

Prometheus Operator version:
quay.io/coreos/prometheus-operator:v0.38.1

Kubernetes version information:
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.9-eks-f459c0", GitCommit:"f459c0672169dd35e77af56c24556530a05e9ab1", GitTreeState:"clean", BuildDate:"2020-03-18T04:24:17Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
AWS EKS

Alert expression:

sum by(name, namespace) (sum_over_time(aggregator_unavailable_apiservice[5m])) > 0

I think silencing this for a long time is the best choice here. I'm closing this here, as this project is about the prometheus operator controllers only, the full solution with alerts etc. is the kube-prometheus project.


DRILL-8438: Bump YAUAA to 7.19.2

Updating Yauaa to latest version + fixing a bug in the caching in a test.
See https://github.com/apache/drill/pull/2807/
@cgivre
I did 2 things here:

Update Yauaa and use the built in selection mechanism to the caching.
Fix a bug in the test that still used the Client Hints caching.

Let's see what the CI build thinks of this.

@nielsbasjes Thanks for this.  I'll rerun the failed test.   Not sure why we're getting network issues but that seems unrelated to this PR.


[FEATURE] Create a better readme

Is this a unique feature?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.
Hello:)
This project is missing a readme.
Proposed Solution
The readme should have a preview and badges and a description.
Screenshots
No response
Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
No response

I might have a look at it when I have some time, any idea at what kind of badges you want to display?

I might have a look at it when I have some time, any idea at what kind of badges you want to display?
Sure. You can make it similar to this: https://github.com/Bashamega/WebDevTools/blob/main/README.md


raidboss: DSR p7 Gigaflare direction to run

Calls out clockwise or counterclockwise based on the atan2 of determinant and dot product of first and second gigaflare NetworkStartsCasting locations. Negative angle should mean one direction, positive angle should mean the other.
Possible we could also replace this with relative to boss since I imagine most groups are facing the boss?
To be tested. It's probably okay now. I only ran with it once and didn't have a problem with in/out tts over this tts, but it's easy enough to test out with raidsim or fflogs data and typescript sim.

Possible this also calls out the first safe spot such as Southwest => Clockwise or Southwest => Left.

Another note, this currently happens 1 second before an in/out call, and given TTS lengths it likely leads to multiple callouts at once.

I've added the starting location to the callout. The only oddity I ran into was switching the value of X and Y, normally it's cosine that gets X and sine that gets Y, but I am guessing since the Y value is flipped (North is negative) the X,Y calculation here had to be flipped.
Another thing to note, it's a radius 14 for the gigaflares from boss. Calculate the point the boss would be facing to on this "circle", then used the same math for determining clock/counterclock between this point and the first gigaflare to know where to move to behind the boss. Since the heading of the boss and the angle of the gigaflares may not be exact data, I used an alternate method for determining the front/back one that looks to be consistent.

The math for if it's front is not correct, but the counter/clockwise portion does seem to be. I need to come up with a better method for front.

I see, the X and Y seem to be flipped for the atan2 to method to work. The reason the others work is probably because the angles are just relative and since both are calculated the same way it produces a result that works.

Sorry for leaving this PR for so long.  For some reason I thought it still needed testing?  Is this ready to go once the lint issues are solved?

Sorry for leaving this PR for so long. For some reason I thought it still needed testing? Is this ready to go once the lint issues are solved?

It was good with all the values I tested.
I think the lint checker is actually broken though, the fix it is doing does not make sense to me. It wants to add a comma inside the conditional...

I think the lint checker is actually broken though, the fix it is doing does not make sense to me. It wants to add a comma inside the conditional...

I think the statement is so long that it thinks it's an item in a list?
You could always break it into smaller statements that don't need to be wrapped, and then there'd be no need for a comma either.

Ok, I broke the conditional into statements, this removes a set of parenthesis since order is now preserved in the statement instead which the variable can then be operated.

It should be ready to go, and this is verifiable in raid emulator as well. I think it was last pending that you wanted to trial run it, but never had the time to get around to it.


prometheus-junos-exporter: init at 0.10.1 + module

Description of changes
This PR adds the JunOS Prometheus exporter package and a NixOS module for it.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

How does this relate to https://github.com/NixOS/nixpkgs/pull/235423?

It's actually not related at all, it's just a funny coincidence that we opened a PR for the same package on the same day (with this PR additionally containing a module).
But I am unsure how to proceed now, since both PRs want to add different junos_exporters as a package.

Rename both of them to prometheus-juneos-exporter-${repo-owner} ?

Sounds good to me, but what about the module? Do you also plan to add a module for the exporter you are adding? If yes, I would do the same naming for the module.

Yes I planed to write a module at some point, keeping the naming consistent there sounds good.

Renaming is done, but I chose prometheus-junos-${repo-owner}-exporter as the naming, because all the other exporters end with "exporter" and I don't want to have a inconsistency there.

@ajs124 can you merge this?


whois.extract_domain doesn't handle second-level-only TLDs correctly

If a domain doesn't have any top-level TLDs in the public suffix list (see, for example, the .za TLD - there is no .za, only .co.za, .ac.za, etc.), then whois.extract_domain returns an incorrect result. For example, whois.extract_domain('google.co.za') returns 'za' instead of 'google.co.za'. Patch coming shortly.

thanks - have merged PR


alpha parameter in sq.pl.spatial_scatter

I am trying to use the 'alpha' parameter in spatial_scatter, but regardless of what value I try between 0 and 1, the spot opacity doesn't seem to change. On the other hand 'img_alpha' works perfectly Am I doing something wrong?
sq.pl.spatial_scatter(adata, alpha = 0.1, color='texturefeatures_cluster_05')

Hi @jnmark ,
I've tried running:
import squidpy as sq

adata = sq.datasets.visium_hne_adata()
sq.pl.spatial_scatter(adata, color="Sox8", alpha=0.5)

and it works. However, running this for categorical observation, it has no effect. Is texturefeatures_cluster_05 categorical in your case?

Yes, it is categorical. These are the texture based features extracted from
Squidpy. I would like to make them opaque or fully transparent with just
the spot outline so I can see the H&E and understand the underlying
texture.
On Thu, May 5, 2022, 4:55 PM michalk8 @.***> wrote:

Hi @jnmark https://github.com/jnmark ,
I've tried running:
import squidpy as sq
adata = sq.datasets.visium_hne_adata()sq.pl.spatial_scatter(adata, color="Sox8", alpha=0.5)
and it works. However, running this for categorical observation, it has no
effect. Is texturefeatures_cluster_05 categorical in your case?
—
Reply to this email directly, view it on GitHub
https://github.com/theislab/squidpy/issues/540#issuecomment-1119038294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARKDXM4BJOF4WRDL5I46FX3VIQYVDANCNFSM5VDJVWDA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks so much! I installed the latest git version to test this, however, now I get another error:
AttributeError                            Traceback (most recent call last)
 in
3 sc.settings.set_figure_params(figsize = [10,10])
----> 5 sq.pl.spatial_scatter(adata, alpha = 0.1, color='textfeatures_cluster_05')
AttributeError: module 'squidpy' has no attribute 'pl'

@jnmark Did you manage to get transparent spots for this method? I would like to plot a spatial image with gene counts but have transparent spots for spots that have zero counts. Do you know if I can do this with squidpy?


feat: add file extension jpg on ImageType

Adding a jpg extension file, and fix a bug when call downloadImageFromWeb. The argument imageType was not pass to the method downloadImageFromUInt8List.

Update:
After some investigation, toDataUrl seams to not working properly when adding jpg format. The image is never downloaded. Works fine with png format, but not jpg. Looking for a solution..


Pipelines Cleanup

Closes https://github.com/CDCgov/pyrenew-hew/issues/253.

This is working locally but broken on azure.

I could not get this to work in azure, so I have reduced the scope to simple file renames.