Fix issue #604

Closes https://github.com/hotwired/turbo/issues/604
When quickly clicking between frames, even though the fetch request is canceled, the page's HTML is mutated, setting a new src to the frame element. This change will cause the pageSnapshot to be incorrect, so when we navigate back, the turbo-frame will have an incorrect src causing a new fetch and the bug shown in the issue.
This PR updates frames to know what was their previousSrc so they can revert back in case the request is canceled.

Cc @seanpdoyle

@manuelpuyol I've cherry-picked the test coverage you've introduced in this PR to https://github.com/hotwired/turbo/pull/430, and the test suite passes.
Having said that, I've applied the following diff to main, and the suite also passes, without any changes to the implementation:
diff --git a/src/tests/functional/frame_navigation_tests.ts b/src/tests/functional/frame_navigation_tests.ts
index 3a2fadd..ac6eb03 100644
--- a/src/tests/functional/frame_navigation_tests.ts
+++ b/src/tests/functional/frame_navigation_tests.ts
@@ -1,5 +1,12 @@
 import { test } from "@playwright/test"
-import { getFromLocalStorage, nextEventNamed, nextEventOnTarget, pathname, scrollToSelector } from "../helpers/page"
+import {
+  getFromLocalStorage,
+  nextBeat,
+  nextEventNamed,
+  nextEventOnTarget,
+  pathname,
+  scrollToSelector,
+} from "../helpers/page"
 import { assert } from "chai"

 test("test frame navigation with descendant link", async ({ page }) => {
@@ -97,3 +104,38 @@ test("test promoted frame navigations are cached", async ({ page }) => {
   assert.equal(await page.getAttribute("#tab-frame", "src"), null, "caches one.html without #tab-frame[src]")
   assert.equal(await page.getAttribute("#tab-frame", "complete"), null, "caches one.html without [complete]")
 })
+
+test("test canceling frame requests don't mutate the history", async ({ page }) => {
+  await page.goto("/src/tests/fixtures/tabs.html")
+
+  await page.click("#tab-2")
+
+  await nextEventOnTarget(page, "tab-frame", "turbo:frame-load")
+  await nextEventNamed(page, "turbo:load")
+
+  assert.equal(await page.textContent("#tab-content"), "Two")
+  assert.equal(pathname((await page.getAttribute("#tab-frame", "src")) || ""), "/src/tests/fixtures/tabs/two.html")
+  assert.equal(await page.getAttribute("#tab-frame", "complete"), "", "sets [complete]")
+
+  // This request will be canceled
+  page.click("#tab-1")
+  await page.click("#tab-3")
+
+  await nextEventOnTarget(page, "tab-frame", "turbo:frame-load")
+  await nextEventNamed(page, "turbo:load")
+
+  assert.equal(await page.textContent("#tab-content"), "Three")
+  assert.equal(pathname((await page.getAttribute("#tab-frame", "src")) || ""), "/src/tests/fixtures/tabs/three.html")
+
+  await page.goBack()
+  await nextEventNamed(page, "turbo:load")
+
+  assert.equal(await page.textContent("#tab-content"), "Two")
+  assert.equal(pathname((await page.getAttribute("#tab-frame", "src")) || ""), "/src/tests/fixtures/tabs/two.html")
+
+  // Make sure the frame is not mutated after some time.
+  await nextBeat()
+
+  assert.equal(await page.textContent("#tab-content"), "Two")
+  assert.equal(pathname((await page.getAttribute("#tab-frame", "src")) || ""), "/src/tests/fixtures/tabs/two.html")
+})

Were you able to force the tests to fail?

@seanpdoyle hmm maybe the test is not ideal, since I still can see the bug in main
https://user-images.githubusercontent.com/11280312/204885305-e6b636f2-2749-428f-8c50-88ba41af2f4e.mov


upload of multiple large files doesn't work

I wanted to upload eight 4-GB files to the workspace; I selected all and it attempted to upload all of them in parallel. This was on a machine with a gigabit wired connection at the lab and it ended up swamping the browser and hanging. The upload queue should only allow a certain number (perhaps client-configurable) to run at once.

[9/14/17, 4:23:41 PM] olsonanl: current approach is fine, they just have to not all upload at once
[9/14/17, 4:23:53 PM] neal conrad: ah, i see
[9/14/17, 4:23:53 PM] neal conrad: ok
[9/14/17, 4:24:04 PM] olsonanl: dd if=/dev/zero of=bigfile bs=1000000 count=4000

@nconrad is this still an issue?


Fix/capacitor support

The scope of this task is to do the necessary changes required for getting the code push working from the Appcenter client perspective when bundling a Capacitor app. This includes not wrapping a folder within CodePush directory when the type of the project in Appcenter is of type React Native.

Regarding the npm publishing part, please follow the guide we have https://gesundheitscloud.atlassian.net/wiki/spaces/ENG/pages/1953497105/D4L+NPM+registry+process+workflow I'll provide you with the publish access token.


ci: fix ci pipeline to test all envoy versions

This PR is failing due to the changes introduced in https://github.com/envoyproxy/envoy/pull/23049

Superseeded by https://github.com/corazawaf/coraza-proxy-wasm/pull/126. Thanks a lot for pointing out this @sts !


Co-Management on Azure AD registered devices

Hi team. From this article it's not really clear that an on-prem AD joined device must be also Azure AD joined for co-management (MDM enrollment) to work. It doesn't seem to work with on-prem AD and Azure AD registered devices. Please clarify. Thx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f24ae716-bf27-7d45-cb15-0bc6eea64374
Version Independent ID: f444ef64-9b7d-999f-3fb3-6ac6cda3ef88
Content: Co-management for Windows 10 devices - Configuration Manager
Content Source: sccm/comanage/overview.md
Product: configuration-manager
Technology: configmgr-client
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Hi @ClientAdmin, see Prerequisites - Azure AD:

Windows 10 devices must be joined to Azure AD....

In the prerequisites it's written that the Windows 10 devices must be joined to Azure AD... under the bullet point it's written that the the device must be on-prem AD joined an Azure AD registered. Also the image looks like it only has to be registered. No Azure AD join. Registration and join aren't the same thing. I'm I missing anything?

Thanks for the clarification, those are incorrect terms. The prerequisite is that the device is AAD joined.

I've submitted a change to the prereq terminology that will publish later this morning. I'm also trying to track down the graphic source from a colleague to change that.

Thank you very much! This will help to explain to our customer.

Hi Aaron. Already an idea when the modified content will be published?

Hi Aaron. The text part was already corrected. What about the graphic? This is really relevant. Thank you in advance

Still trying to track down the original source content from the original author. We're currently working on finalizing the content updates for the upcoming 2002 release, which is the current priority.

Currently tracking the diagram changes with newer issue MicrosoftDocs/memdocs#220


Fix in radar calculations of class StatisticalDescriptor

When statistical calculations are made with radar reflectivity (in dBZ), it is necessary to convert it to mm^6 m^-3 before the calculations because dBZ is a logarithm scale (https://glossary.ametsoc.org/wiki/Dbz).
The best solution I found was to add the flag is_radar in the class StatisticalDescriptor that, when True, apply the necessary conversions to return the results in the same unit as the original data.
I believe the only additional changes that will be necessary are the radar examples, including this new flag.

Hi @cclopes. Thanks for the PR.
Okay, this is really necessary.
Idea: we can create a new descriptor called DBZStatisticalDescriptor and implement this arithmetic operation in this new class.
In this way we keep the StatisticalDescriptor class generic and dBZ logic will be in a specific entity.
Usage:
from tathu.tracking import descriptors
descriptor = descriptors.DBZStatisticalDescriptor()
descriptor.describe(grid, systems)

I think it looks better than a boolean flag and fits with the package's conceptual model.
What do you think?

That's a great idea! Closing the PR and turning into issue #5.


feat(Tab): add renderActiveOnly prop

Fixes #1877.

Codecov Report

Merging #1976 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1976      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%
=========================================
  Files         148     148
  Lines        2568    2570       +2
=========================================
+ Hits         2563    2565       +2
  Misses          5       5

Impacted Files
Coverage Δ

src/modules/Tab/Tab.js
100% <100%> (ø)
:arrow_up:

src/modules/Tab/TabPane.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4780cd...a2b4a24. Read the comment docs.

Has merge conflicts

Released in<EMAIL_ADDRESS>

Fyi, this change does not work. Setting renderActiveOnly={false} results in no panes being rendered.

It's not enough to set this prop to false, take a look on this and this examples.

It's not enough to set this prop to false,

We should make it so.

Thanks for pointing out those examples. They worked. I'm still having trouble with the example that the OP in #1877 provides of Leaflet, but perhaps this is a Leaflet issue.


memory consumption

Hey tleyden!
I'm looking into memory consumption by both the worker and the http daemon. And in can be very high. Starting with a low memory profile just under 1MB it grows with every request. On my test the memory consumption grew to over 2GB for 10 requests with TIFF image about 30Mb of size.
I tried to debug a little bit, but lacking the experience I only found out - the most memory is allocated on the heap by make.Slice. This example is showing consumption after one Request with 30Mb payload total.
File: cli_httpd
Type: inuse_space
Time: Dec 14, 2018 at 3:32pm (CET)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top20
Showing nodes accounting for 83.50MB, 100% of 83.50MB total
Showing top 20 nodes out of 25
      flat  flat%   sum%        cum   cum%
      83MB 99.40% 99.40%       83MB 99.40%  bytes.makeSlice
    0.50MB   0.6%   100%     0.50MB   0.6%  net/http.init.2
         0     0%   100%       32MB 38.32%  bytes.(*Buffer).ReadFrom
         0     0%   100%       51MB 61.08%  bytes.(*Buffer).Write
         0     0%   100%       83MB 99.40%  bytes.(*Buffer).grow
         0     0%   100%       51MB 61.08%  encoding/base64.(*encoder).Write
         0     0%   100%       51MB 61.08%  encoding/json.(*encodeState).marshal
         0     0%   100%       51MB 61.08%  encoding/json.(*encodeState).reflectValue
         0     0%   100%       51MB 61.08%  encoding/json.(*structEncoder).encode
         0     0%   100%       51MB 61.08%  encoding/json.(*structEncoder).encode-fm
         0     0%   100%       51MB 61.08%  encoding/json.Marshal
         0     0%   100%       51MB 61.08%  encoding/json.encodeByteSlice
         0     0%   100%       83MB 99.40%  github.com/xf0e/open-ocr.(*OcrHttpHandler).ServeHTTP
         0     0%   100%       32MB 38.32%  github.com/xf0e/open-ocr.(*OcrRequest).downloadImgUrl
         0     0%   100%       83MB 99.40%  github.com/xf0e/open-ocr.(*OcrRpcClient).DecodeImage
         0     0%   100%       83MB 99.40%  github.com/xf0e/open-ocr.HandleOcrRequest
         0     0%   100%       32MB 38.32%  github.com/xf0e/open-ocr.url2bytes
         0     0%   100%       32MB 38.32%  io/ioutil.ReadAll
         0     0%   100%       32MB 38.32%  io/ioutil.readAll
         0     0%   100%     0.50MB   0.6%  main.init
(pprof) list makeSlice
Total: 83.50MB
ROUTINE ======================== bytes.makeSlice in /usr/lib/go/src/bytes/buffer.go
      83MB       83MB (flat, cum) 99.40% of Total
         .          .    226:   defer func() {
         .          .    227:           if recover() != nil {
         .          .    228:                   panic(ErrTooLarge)
         .          .    229:           }
         .          .    230:   }()
      83MB       83MB    231:   return make([]byte, n)
         .          .    232:}
         .          .    233:
         .          .    234:// WriteTo writes data to w until the buffer is drained or an error occurs.
         .          .    235:// The return value n is the number of bytes written; it always fits into an
         .          .    236:// int, but it is int64 to match the io.WriterTo interface. Any error
(pprof) list DecodeMessage
Total: 83.50MB

I'm trying to understand where additional 50 Mb came from, but i can't figure it out.
I assume the memory load comes from storing the payload as []byte by the function url2bytes.
Is it possible to rewrite the function to store the payload on a file system and passing over rabbitmq the path to the file instead of the whole payload?
The memory consumption by the worker is even bigger. I think for the same reason, but i can't prove it because I was not able to get the pprof data for this part of open-ocr.
I would try to rewrite the code. I just need to know which parts are involved(I don't understand if the rabbitmq part will be involved).
Are you interested in elaborating this problem together and provide me some hints?
Regards!

Is it possible to rewrite the function to store the payload on a file system and passing over rabbitmq the path to the file instead of the whole payload?

I don't see how that will work since typically the processes will be running on different machines.  It would only work if there was a shared/common filesystem, which won't be on every system.

Sorry, i accidentally closed the issue. It was not intended.
My testing procedure:

Started cli_worker and the cli_httpd.
Pushed x requests to cli_httpd by issuing
curl -X POST -H "Content-Type: application/json" -d '{"img_url":"http://localhost:8000/testimage2.tif","engine":"tesseract"}' http://localhost:8080/ocr
Watched the RES(RSS) memory values for both processes and took the heap pprof curl http://localhost:8080/debug/pprof/heap > heap.pprof for cli_httpd(i posted the example above. The values there conform.

All request got valid reply from open-ocr and the memory usage went down to just 40Mb and 9Mb after ca. 10 Minutes upon delivery.

So it sounds like you are saying the memory is eventually being reclaimed to the OS?  Are you just trying to avoid the memory spikes from happening at all?  Or are you seeing what appears to be a leak where it just keeps increasing.   You mentioned you saw it grow to 2 GB.

The gctrace section here might shed some more light on it: https://dave.cheney.net/tag/godebug

Where are two problems with memory footprint.

First one are the spikes special in cli_httpd. The memory area is being held by cli_http is always factor 3 bigger than the actual payload. I don't know(i hope) if it can be reduced. The good news is, it will be reclaimed by OS at some point, but it could be too late if you got enough workers with one httpd. In my tests, 10 requests with 30Mb each are claiming 700-800MB RAM. The memory is freed after ca. 8-10 Minutes after last request is delivered. I'm planning to have 40-50 workers.

Second problem is the memory leak in cli_worker. The memory is reclaimed by the OS only if the ocr requests are delivered. For test purpose I have reduced the timeout delivery an fired up 10x requests at one worker. Only 5 request were delivered, the last 5 all got
"Unable to perform OCR decode.  Error: Timeout waiting for RPC response". Although the tesseract was running for each of them properly. The memory demand was about 980Mb for this particular case. After some time only the half of the memory was released to the OS. The non successful requests(with timeout) are still holding the memory.

You can see how the memory footprint looks over the time(thanks for gctrace link!).
The memory used by cli_worker won't be released completely.

Thanks!

The non successful requests(with timeout) are still holding the memory.

I think the problem is here:
https://github.com/tleyden/open-ocr/blob/4fd4a2ac2a09c30684729d9c41d145ebafa5d4cc/ocr_rpc_client.go#L215
If it times out waiting for a worker response, then nothing will be listening on that rpcResponseChan and so rpcResponseChan <- ocrResult will block forever.
Do you see "send result to rpcResponseChan" messages without corresponding "sent result to rpcResponseChan" messages?
 Last sucsesed ocr request and the rest what didn't make in time:

22:57:28.143282 OCR_CLIENT: got 20356B delivery: [1] "Lorem ipsum"
22:57:28.143302 OCR_CLIENT: send result to rpcResponseChan
22:57:28.143304 OCR_CLIENT: sent result to rpcResponseChan
22:57:28.144554 OCR_HTTP: ocrResult: {Lorem Ipsum}
22:57:34.550229 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80
22:57:34.550242 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40
22:57:36.157883 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80
22:57:36.157894 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40
22:57:37.794640 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80
22:57:37.794651 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40
22:57:39.532304 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80
22:57:39.532317 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40

There is no  "send result to rpcResponseChan" at all.

I wonder if the memory leak would be reproducible in a simpler case -- what if there is no worker running?  Do you see the memory just keep increasing as you add jobs that are never processed?

There are minimum 2 cases with leaking memory. Both could be reproduced really easy.
The first case:

what if there is no worker running?

only cli_httpd and rabbitmq running:
Then the all requests timeouts, the cli_httpd will release the memory at some point:

21:26:27.431007 OCR_HTTP: Starting listener on :8080 21:26:58.560339 OCR_HTTP: serveHttp called 21:26:58.561176 OCR_CLIENT: dialing "amqp://guest:guest@localhost:5672/" 21:26:58.569238 OCR_CLIENT: callbackQueue name: amq.gen-ZpRyOndmB4PozCcbS6ZOGg 21:26:58.569582 OCR_CLIENT: looping over deliveries.. 21:26:58.648990 OCR_CLIENT: ocrRequest before: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:26:58.649003 OCR_CLIENT: publishing with routing key "decode-ocr" 21:26:58.649008 OCR_CLIENT: ocrRequest after: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:27:50.653017 OCR_HTTP: serveHttp called 21:27:50.653074 OCR_CLIENT: dialing "amqp://guest:guest@localhost:5672/" 21:27:50.657004 OCR_CLIENT: callbackQueue name: amq.gen-gfWBqIeFQ6RMFHzS0KoSXA 21:27:50.657382 OCR_CLIENT: looping over deliveries.. 21:27:50.684407 OCR_CLIENT: ocrRequest before: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:27:50.684417 OCR_CLIENT: publishing with routing key "decode-ocr" 21:27:50.684431 OCR_CLIENT: ocrRequest after: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:28:01.923367 OCR_HTTP: serveHttp called 21:28:01.923432 OCR_CLIENT: dialing "amqp://guest:guest@localhost:5672/" 21:28:01.928467 OCR_CLIENT: callbackQueue name: amq.gen-lIBccn0D6zWnrXaBaedItw 21:28:01.928843 OCR_CLIENT: looping over deliveries.. 21:28:01.966831 OCR_CLIENT: ocrRequest before: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:28:01.966842 OCR_CLIENT: publishing with routing key "decode-ocr" 21:28:01.966846 OCR_CLIENT: ocrRequest after: ImgUrl: , EngineType: ENGINE_TESSERACT, Preprocessors: [] 21:28:58.778786 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80 21:28:58.778826 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40 21:29:50.780741 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80 21:29:50.780766 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40 GC forced 21:30:02.062150 ERROR: Timeout waiting for RPC response -- open-ocr.HandleOcrRequest() at ocr_http_handler.go:80 21:30:02.062169 ERROR: Unable to perform OCR decode.  Error: Timeout waiting for RPC response -- open-ocr.(*OcrHttpHandler).ServeHTTP() at ocr_http_handler.go:40 GC forced GC forced scvg2: 0 MB released GC forced GC forced scvg3: 382 MB released
The rabbitmq will preserve the messages:

What we are missing at this point is deleting corresponding messages from the rabbitmq queue.
Then we start cli_worker now it immediately gets all messages from the queue an performs ocr on it. Which is bad, since no one will ever get them. But there is no memory leakage in this case

21:43:44.248453 OCR_WORKER: Creating new OCR Worker 21:43:44.248482 OCR_WORKER: Run() called... 21:43:44.248496 OCR_WORKER: dialing "amqp://guest:guest@localhost:5672/" 21:43:44.253650 OCR_WORKER: got Connection, getting Channel 21:43:44.254781 OCR_WORKER: binding to: decode-ocr 21:43:44.255152 OCR_WORKER: Queue bound to Exchange, starting Consume (consumer tag "foo") 21:43:44.354363 OCR_WORKER: got 40648128 byte delivery: [1]. Routing key: decode-ocr  Reply to: amq.gen-ZpRyOndmB4PozCcbS6ZOGg 21:43:44.841885 OCR_TESSERACT: Use tesseract with bytes image 21:43:44.851449 OCR_TESSERACT: cmdArgs: [/tmp/23e0f1dd-85ca-4a31-772a-91960491d9db /tmp/23e0f1dd-85ca-4a31-772a-91960491d9db] 21:44:09.915722 OCR_TESSERACT: checking if exists: /tmp/23e0f1dd-85ca-4a31-772a-91960491d9db.txt 21:44:09.917860 OCR_WORKER: Sending rpc response: {Lorem Ipsum} 21:44:09.917870 OCR_WORKER: sendRpcResponse to: amq.gen-ZpRyOndmB4PozCcbS6ZOGg 21:44:09.917975 OCR_WORKER: sendRpcResponse succeeded 21:44:09.917982 OCR_WORKER: got 40648128 byte delivery: [2]. Routing key: decode-ocr  Reply to: amq.gen-gfWBqIeFQ6RMFHzS0KoSXA 21:44:10.349823 OCR_TESSERACT: Use tesseract with bytes image 21:44:10.359666 OCR_TESSERACT: cmdArgs: [/tmp/8752631a-1be0-4905-74de-8f262e405049 /tmp/8752631a-1be0-4905-74de-8f262e405049] 21:44:36.289734 OCR_TESSERACT: checking if exists: /tmp/8752631a-1be0-4905-74de-8f262e405049.txt 21:44:36.292069 OCR_WORKER: Sending rpc response: {Lorem Ipsum} 21:44:36.292081 OCR_WORKER: sendRpcResponse to: amq.gen-gfWBqIeFQ6RMFHzS0KoSXA 21:44:36.293107 OCR_WORKER: sendRpcResponse succeeded GC forced GC forced scvg1: 0 MB released GC forced scvg2: 231 MB released GC forced
The second case
Is described before this post. We have cli_httpd, cli_worker and rabbitmq running.
Now we are pushing just enough requests into the queue there at least one won't make in time. If we got enough RAM on cli_httpd and rabbitmq machines we won't crash here. Now the workers kicks in... All request which timeouts will not release the memory which belonging to such requests.
Actually really ease to reproduce:

start one cli_httpd, one cli_worker and the rabbitmq. Standard timeout if 120 Seconds in the sources.
now on one tty or more just call curl -X POST -H "Content-Type: application/json" -d '{"img_url":"http://localhost:8000/testimage.tif","engine":"tesseract"}' http://localhost:8080/ocr X times. There X is depends on the test image. In my case it is a 30Mb image  with 6 pages on it. The 4th or 5th and on wards requests(on my test machine) will receive a timeout and cli_worker will leak memory for such requests.

I got a workaround for leaking memory by cli_worker, but I think we should address the actual issue, since this workaround would not help if the request which is being processed times out.
w.channel.Qos(1, 0, true) in orc_rpc_worker.go in Run() function will prevent worker for getting more than one message at a time from the queue.

Ok thanks for the explanations and the steps to repro.


Some questions about features

This is a great project, i'm using it in conjuction to sequelize-auto to totally automate creation of graphql service from pre-existibg mysql db... but i would ask you 3 things that are makes me crazy:

All integer primary keys are trasformed in graphql ID scalar type. So i cannot do for example { mytable(id: 4) } since that values is not recognized. Is there a solution?

In sequelize i've tons of fields that are "not null" but have a default value. But the graphql schema is created with "!" (not null) so i cannot omit them when mutate/create. Is there any way to configure it in a way to avoid it when default value is present in sequelize model?

How can i set a middlewares in resolvers to implement security checks? I need to filter queries/mutations based on user roles.

I've created a fork where i've fixed 1. and 2.
About 3., since graphql-sequelize-crud produces a GraphQLSchema, i've used Apollo Transformation to wrap queries with middlewares.
However i think this project is dead


IO: Added ProfileEvents to Open/Read/Write failures

I've added metrics for file Open/Read/Write failures:

ProfileEvents::FileOpenFailed
ProfileEvents::ReadBufferFromFileDescriptorReadFailed
ProfileEvents::WriteBufferFromFileDescriptorWriteFailed

The reason is detecting disk failures from metrics is easier than parsing logs.

Okay, fixed.


Make sparql endpoint publicly available

We will remove all references to our old servers from the e-link templates. Therefore we need to update the SPARQL endpoint. Please make the SPARQL endpoint publicly available at
https://api.freme-project.eu/sparql
This should be a proxy redirect from /sparql to http://localhost:8890/sparql .
We are updating the e-link template endpoints in this issue: https://github.com/freme-project/basic-services/issues/117

Endpoint is now available


⚠ Bofrost.de has degraded performance

In 0b1db69, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 933 ms

Resolved: Bofrost.de performance has improved in effcea4 after 13 minutes.


command+w could not close vs code window on macos

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.0
OS Version: Darwin x64 20.5.0

Steps to Reproduce:

Open vscode
Using command+w to close all the tabs and the window.

https://code.visualstudio.com/updates/v1_57#_removed-cmdw-ctrlw-keybinding-to-close-window-when-no-editor-is-opened


FIP-6 Transfer locked tokens

Tracks comments, development and deployment of FIP-6: https://github.com/fioprotocol/fips/blob/master/fip-0006.md:

Discussion moved to: https://fioprotocol.atlassian.net/browse/WP-108


Create pipeline

Create pipeline using: azure/arm-deploy
Should be able to deploy on subscription  level

Fully implemented

Fully implemented


ratelimiter how does it work?

I'm sorry I don't understand what a token is or a request? Is it like amount of data? Or amount of commands? Or ssh connections? I understand the lru and the ip address part, and conceptually the token thing, but I don't understand how to control this interface or what it exactly means. I tried looking but couldn't find out.

hey!
the provided rate limit implementation limits the amount of connections a source can make in X amount of time.
Docs should be better on this though, will improve them.
Thanks for the issue 🙏


Slack Button Design - Session of Buttons

Inline with our "session of Buttons", We would be building different kinds of buttons..
Design a Button that looks like the button in this image...
Create a file "Your_Button_Name.html" in the modules/buttons folder.
Use simple HTML and CSS to create the button. You can use the interface development https://kwickerhub.com (This project) or you can code it.
For some additional info, You should read the instructions.txt file in "buttons" folder.

you are free to use imported icon libraries...

hi can you assign this to me?

Already assigned one button design to you. After that design, You can try this out too.

hi can you assign this to me?


"Add simplestyle properties" broken

See above image. In geojson popup - clicking the "Add simplestyle properties" errors. Expected behavior would be the addition of those parameters to the geojson style under properties.

Console captures the following error.

same issue


My model flies up

My model is lighter than h1, and it flies up when start gazebo. Which code should I change to accommodate the lighter model?
Thanks,
Yili

I have written a readme on how to implement your own robot. Hope it would be helpful :)

It is fine now. urdf file issue.
Thanks!


Add Qt

Android? iOS?

What would be strategies for adding support for Qt?

Download the platform dependent pre-compiled compressed file and just uncompress it into <root-id>/Install
Download the open source source compressed, compile it locally and install it to <root-id>/Install
Make it in a way where both of the above options will be possible

For iOS + Qt support, what would be best to figure out how the makefiles are generated?

Look into qmake's source code to see how the make files are generated for iOS
Reverse engineer the Makefiles generated by qmake when run -spec macx-ios-clang CONFIG+=iphoneos

Download the platform dependent pre-compiled compressed file and just uncompress it into /Install

I think no because it's not possible to apply patches in this case. Also it would be nice to have configuration options (like with/without OpenSSL, shared/static, ...)

Download the open source source compressed, compile it locally and install it to /Install

Yes

Make it in a way where both of the above options will be possible

I don't think it's worth it to make only for one package. Downloading binaries should be implemented in more general way, see https://github.com/ruslo/hunter/issues/75.

For iOS + Qt support, what would be best to figure out how the makefiles are generated?

We just need to follow official instructions and save all knowledge in build scheme.

We just need to follow official instructions and save all knowledge in build scheme.
Sorry for not being clear. I was not referring to Qt, but the iOS projects based on Qt, once at the moment is done by qmake -spec macx-ios-clang CONFIG+=iphoneos.

Sorry for not being clear. I was not referring to Qt, but the iOS projects based on Qt, once at the moment is done by qmake -spec macx-ios-clang CONFIG+=iphoneos.

I think Qt is CMake-friendly, i.e. to integrate Qt into CMake project we just need find_package(Qt*) ?). I haven't tried iOS variant of Qt yet.

Qt for Desktop was indeed CMake-friendly and straight forward, but I haven't yet managed to get it to work for iOS. I will investigate this further later on.
I made a work in progress project-qt branch on my fork: https://github.com/pretyman/hunter/tree/project-qt
What is happening is that the prefix seems not respected and the installation is landing in /tmp/Hunter.dst/... as per:
install -m 644 -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qttranslations/translations/qtxmlpatterns_ko.qm /tmp/Hunter.dst/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Install/translations/
install -m 644 -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qttranslations/translations/qtxmlpatterns_ru.qm /tmp/Hunter.dst/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Install/translations/
install -m 644 -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qttranslations/translations/qtxmlpatterns_sk.qm /tmp/Hunter.dst/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Install/translations/
install -m 644 -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qttranslations/translations/qtxmlpatterns_uk.qm /tmp/Hunter.dst/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Install/translations/
cd /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source && /opt/local/bin/cmake -E touch /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Build/Qt-prefix/src/Qt-stamp/Debug-iphoneos/Qt-install

What is happening is that the prefix seems not respected

I see you're using:
    CONFIGURE_COMMAND
    ${configure_command}
    ${configure_opts}
    "--prefix=@HUNTER_PACKAGE_INSTALL_PREFIX@"

But from documentation we need -prefix. So I guess it should be:
    CONFIGURE_COMMAND
    ${configure_command}
    ${configure_opts}
    -prefix
    "@HUNTER_PACKAGE_INSTALL_PREFIX@"

?

I also noticed that, but since Qt for desktop went smoothly, I thought it would be ok. I will make your suggested change and try again.

@pretyman Hi Alexandre. I've pushed your changes to branch project-qt since I want to experiment how it works on iOS. Please don't rebase your local branch since we may have tons of conflicts :) Also feel free to update/merge from it.

Some links to test Qt for iOS:

http://jwintz.me/blog/2013/03/08/qt-on-ios-examples/
http://stackoverflow.com/questions/25042916/run-time-error-for-qt-application-on-ios-built-via-cmake
https://github.com/jwintz/qt-ios-examples

@ruslo I tried your suggested change of the -prefix yesterday, but still got the same result of the installation going to /tmp/hunter.dst/... however, у меня нето лицензии, я сделал изменения в исходный код в mkspecs и, наверное, поэтому не работал. If you have a proper setup, it should work.

If you have a proper setup, it should work

Qt is building all day today :) This in progress. I will let you know.

Also:
у меня нето лицензии -> у меня нет лицензии
я сделал изменения в исходный код в mkspecs -> я внёс изменения в исходный код в mkspecs
or
я сделал изменения в исходный код в mkspecs -> я сделал изменения в исходном коде в mkspecs
Though I'm not sure what is mkspecs exactly, is it a directory or name of an option?
поэтому не работал ->  поэтому не работает (not working)
or
поэтому не работал ->  поэтому не сработало (haven't work)
or
поэтому не работал ->  поэтому не работало (didn't work)

Still in progress. I will let you know

@pretyman It works! Amazing :) I've pushed updates to branch qt-project. Thank you again!

TODO
-skip option can be used to exclude the module from the build. List of the modules can be taken from the list of submodules:
qt3d
qtactiveqt
qtandroidextras
qtbase
qtcanvas3d
qtconnectivity
qtdeclarative
qtdoc
qtdocgallery
qtenginio
qtfeedback
qtgraphicaleffects
qtimageformats
qtlocation
qtmacextras
qtmultimedia
qtpim
qtqa
qtquick1
qtquickcontrols
qtrepotools
qtscript
qtsensors
qtserialport
qtsvg
qtsystems
qttools
qttranslations
qtwayland
qtwebchannel
qtwebengine
qtwebkit
qtwebkit-examples
qtwebsockets
qtwinextras
qtx11extras
qtxmlpatterns

Links:

Submodules
Configure options

Note that you cannot -skip the qtbase module
Sorry for not being complete, I was at lunch time. The reason I got the .dst problem was that я добавил CODE_SIGN_IDENTITY=\"\" CODE_SIGNING_REQUIRED=NO в архив mkspecs/macx-ios-clang/features/default_post.prf в строке 99:
xcodebuild = "xcodebuild CODE_SIGN_IDENTITY=\"\" CODE_SIGNING_REQUIRED=NO $$action -scheme $(TARGET) -sdk $$sdk -configuration $$title($$cfg)"

mkspecs is the directory which keeps the building specifications used by qmake
I did try the polly build.py --toolchain ios-nocodesign toolchain, but it seems to be failing at qxmlpatterns with the log message at the end. I'll just invest in a developer license from Apple when my app matures.
Thanks for the Russian cases, I jotted them down and will break them down. I've been learning for years, but still can't communicate properly.
Log of the failed build with polly toolchain ios-nocodesign, in case you have tried and got a different result:
codebuild build -scheme xmlpatternsvalidator -sdk iphoneos -configuration Release
Build settings from command line:
    SDKROOT = iphoneos8.1
Build settings from configuration file '/Users/discipline/polly/scripts/NoCodeSign.xcconfig':
    CODE_SIGNING_REQUIRED = NO
Build settings from command line:
    SDKROOT = iphoneos8.1
Build settings from configuration file '/Users/discipline/polly/scripts/NoCodeSign.xcconfig':
    CODE_SIGNING_REQUIRED = NO
2015-07-14 16:07:18.940 xcodebuild[34073:1007] +dataWithFirstBytes:1024 ofFile:"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/.qmake.cache" failed, errno = 2
2015-07-14 16:07:18.940 xcodebuild[34076:1007] +dataWithFirstBytes:1024 ofFile:"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/.qmake.cache" failed, errno = 2
=== BUILD AGGREGATE TARGET Qt Preprocess OF PROJECT xmlpatterns WITH CONFIGURATION Release ===
=== BUILD AGGREGATE TARGET Qt Preprocess OF PROJECT xmlpatternsvalidator WITH CONFIGURATION Release ===
Check dependencies
Check dependencies
Write auxiliary files
/bin/mkdir -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build
write-file /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
chmod 0755 /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
write-file /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
chmod 0755 /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
Write auxiliary files
/bin/mkdir -p /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build
write-file /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
chmod 0755 /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
write-file /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
chmod 0755 /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
PhaseScriptExecution Qt\ Qmake .obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
    cd /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns
    /bin/sh -c \"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh\"
PhaseScriptExecution Qt\ Qmake .obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh
    cd /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator
    /bin/sh -c \"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-5E618435888B9D49F8540165.sh\"
make[5]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
make[5]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
make[5]: `xmlpatternsvalidator.xcodeproj/project.pbxproj' is up to date.
make[5]: `xmlpatterns.xcodeproj/project.pbxproj' is up to date.
PhaseScriptExecution Qt\ Preprocessors .obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
    cd /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator
    /bin/sh -c \"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatternsvalidator/.obj/xmlpatternsvalidator.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh\"
PhaseScriptExecution Qt\ Preprocessors .obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh
    cd /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns
    /bin/sh -c \"/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Source/qtxmlpatterns/tools/xmlpatterns/.obj/xmlpatterns.build/Release-iphoneos/Qt\ Preprocess.build/Script-7EF0942E79C014DCEC8976BC.sh\"
make[5]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
make[5]: Nothing to be done for `preprocess'.
make[5]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
=== BUILD TARGET xmlpatternsvalidator OF PROJECT xmlpatternsvalidator WITH CONFIGURATION Release ===
Check dependencies
make[5]: Nothing to be done for `preprocess'.
=== BUILD TARGET xmlpatterns OF PROJECT xmlpatterns WITH CONFIGURATION Release ===
Check dependencies
Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) matching the team ID “(null)” were found.
Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) matching the team ID “(null)” were found.
** BUILD FAILED **
The following build commands failed:
        Check dependencies
(1 failure)
** BUILD FAILED **
The following build commands failed:
        Check dependencies
(1 failure)
make[4]: *** [iphoneos-release] Error 65
make[3]: *** [iphoneos] Error 2
make[2]: *** [sub-xmlpatterns-make_first] Error 2
make[2]: *** Waiting for unfinished jobs....
make[4]: *** [iphoneos-release] Error 65
make[3]: *** [iphoneos] Error 2
make[2]: *** [sub-xmlpatternsvalidator-make_first] Error 2
make[1]: *** [sub-tools-make_first] Error 2
make: *** [module-qtxmlpatterns-make_first] Error 2
make: *** [/Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt/Build/Qt-prefix/src/Qt-stamp/Debug-iphoneos/Qt-build] Error 2
Showing first 200 notices only
Showing first 200 warnings only

** BUILD FAILED **

The following build commands failed:
        PhaseScriptExecution CMake\ Rules Build/Hunter.build/Debug-iphoneos/Qt.build/Script-A81159A750F149B9B13D6B5F.sh
(1 failure)

[hunter ** FATAL ERROR **] Build step failed (dir: /Users/discipline/.hunter/_Base/xxxxxxx/d1a0cd4/34d19ed/Build/Qt
[hunter ** FATAL ERROR **] [Directory:/Users/discipline/.hunter/cmake/projects/Qt]

------------------------------ WIKI -------------------------------
    https://github.com/ruslo/hunter/wiki/error.external.build.failed
-------------------------------------------------------------------

CMake Error at /Users/discipline/.hunter/cmake/modules/hunter_wiki.cmake:12 (message):
Call Stack (most recent call first):
  /Users/discipline/.hunter/cmake/modules/hunter_fatal_error.cmake:20 (hunter_wiki)
  /Users/discipline/.hunter/cmake/modules/hunter_download.cmake:384 (hunter_fatal_error)
  /Users/discipline/.hunter/cmake/projects/Qt/hunter.cmake:27 (hunter_download)
  /Users/discipline/.hunter/cmake/modules/hunter_add_package.cmake:87 (include)
  CMakeLists.txt:12 (hunter_add_package)

-- Configuring incomplete, errors occurred!
See also "/Users/discipline/.hunter/examples/qt-widgets/_builds/ios-nocodesign/CMakeFiles/CMakeOutput.log".
Command exit with status "1": [/Users/discipline/.hunter/examples/qt-widgets]> "cmake" "-H." "-B/Users/discipline/.hunter/examples/qt-widgets/_builds/ios-nocodesign" "-GXcode" "-DCMAKE_TOOLCHAIN_FILE=/Users/discipline/polly/ios-nocodesign.cmake" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DPOLLY_STATUS_DEBUG=ON" "-DHUNTER_STATUS_DEBUG=ON"

Log: /Users/discipline/.hunter/examples/qt-widgets/_builds/ios-nocodesign/_3rdParty/polly/log.txt
*** FAILED ***

It works!

Well it was about libcxx toolchain. With ios toolchain I have the same install issue :(
Looks like Qt use additional prefix /tmp/Hunter.dst. So my package installed to /tmp/Hunter.dst/<root-id>/Install instead of /<root-id>/Install just like in your case.

List of the modules can be taken from the list of submodules

configure script reports that this modules doesn't exist:
qtdocgallery
qtfeedback
qtpim
qtqa
qtrepotools
qtsystems

Some links to test Qt for iOS:
http://jwintz.me/blog/2013/03/08/qt-on-ios-examples/
https://github.com/jwintz/qt-ios-examples

Adapted: https://github.com/forexample/qt-ios-examples

@pretyman I've merged some updates to branch develop (release v0.12.0):

iOS install work for me now. It was fixed accidentally actually :) I was working on cache size optimization and create a CMake script instead of make install. Looks like some environment variable wreak havoc before.
Qt splitted into the components (see wiki)
Qt now support CONFIGURATION_TYPES. You can set Release, Debug or Release;Debug (release + debug works only on OSX (?))
Qt is cacheable
Support static/shared variants. Note that default variant is static for Hunter. For Qt it means that you need to link some extra libraries. See example.

Components + configuration type + cache feature will save huge amount of build type. For instance qt-widgets example now builds ~ 15 minutes (qtbase/Release only, desktop) instead of 5+ hours (all components, Debug/Release). Note that default build variant is Debug;Release
iOS build have some extra peculiarities:

simulator's libraries not found by find_package though they built and installed. Hence it make no sense to use universal iOS toolchain
even if only one build type specified (like '-release') Qt5Core.cmake trying to find debug variant of library and failed. Hence only '-debug-and-release' (default) variant can be used
for now Qt do configuration with iOS default settings (i.e. it ignores settings from toolchain and will build 8.2 target with Xcode 6.2 instead of 8.4 target with Xcode 6.4)
architectures not controlled by toolchain, e.g. it always arm64 + armv7 for device
@headupinclouds minimal build time because of this issues is about 1 hour (2 architectures x 2 variants)

List of the modules can be taken from the list of submodules

I've looked at qtbase/configure and discovered that component is just a directory with name qt*. So for now list of components determined automatically.

@ruslo Wow, this is great news man! Well done!

(release + debug works only on OSX (?))

Yep, as per qtbase/configure script:
if [ "$XPLATFORM_MAC" = "no" -a "$CFG_DEBUG_RELEASE" = "yes" ]; then
    echo
    echo "WARNING: -debug-and-release is not supported outside of Mac OS X."
    echo "Qt can be built in release mode with separate debug information, so"
    echo "-debug-and-release is not necessary anymore"
    echo
fi

even if only one build type specified (like '-release') Qt5Core.cmake trying to find debug variant of library and failed.

Seems that CMake support is still rough on its edges. I was trying to get an app which uses QtQuick + QtMultimedia compiling and running on iOS last night and was running into linking errors. I was compiling for Release and  Qt5QmlConfig.cmake was not including all the needed dependencies, it included automatically its plugins with the following line:
file(GLOB pluginTargets "${CMAKE_CURRENT_LIST_DIR}/Qt5Qml_*Plugin.cmake")

and the files in the directory are:
Qt5Qml_QTcpServerConnection.cmake
Qt5Qml_QtQuick2Plugin.cmake

Meaning Qt5Qml_QTcpServerConnection.cmake, which was no Plugin suffix, was not being picked up. Upon fixing this, I was able to get the app to compile, but not yet run. I see you did some changes to the main of qt-widgets example, so I will try the same, however my app works with QtCreator + qmake.
Question: do you know how can I access the C++ (and C) compiling flags when using the iOS toolchain? They are not being written to CMAKE_CXX_FLAGS nor CMAKE_C_FLAGS. I was trying to see if xcodebuild had any option for that, but the furthest I got was xcodebuild -showBuildSettings, but it doesn't give me all compile flags. The aim of accessing this is to use the autotools based projects.
Thanks a lot for getting this work

even if only one build type specified (like '-release') Qt5Core.cmake trying to find debug variant of library and failed. Hence only '-debug-and-release' (default) variant can be used

It's not true, my bad. I was testing version with bug.
@headupinclouds minimal time of build for iOS is ~30min (qtbase, Release, device only)

I was trying to get an app which uses QtQuick + QtMultimedia compiling and running on iOS last night and was running into linking errors

@pretyman Yes, some extra libraries needed. See example. Note that static build is default for Hunter, for dynamic Qt variant some of them not necessary.

Meaning Qt5Qml_QTcpServerConnection.cmake, which was no Plugin suffix, was not being picked up

I guess if you're sure that this is an error you can open a bug: https://bugreports.qt.io

Question: do you know how can I access the C++ (and C) compiling flags when using the iOS toolchain? They are not being written to CMAKE_CXX_FLAGS nor CMAKE_C_FLAGS.

They are added by Xcode itself, so yes, you can't use CMAKE_{C|CXX}_FLAGS. If you're using Polly toolchain there are some help variables like IOS_SDK_VERSION or IPHONESIMULATOR_ROOT. Also you may take a look at OpenSSL iOS scheme.

simulator's libraries not found by find_package though they built and installed. Hence it make no sense to use universal iOS toolchain

https://bugreports.qt.io/browse/QTBUG-47314

From the second thought I can add extra install step which will fuse simulator and device libraries into one universal lib using lipo tool. This will fix both find_package can't find Qt when only simulator libs built and can't run both device and simulator in one Xcode project.
@headupinclouds @pretyman let me know if you're interested in simulator archs

@ruslo Thanks for the heads with the OpenSSL's iOS build scheme, it was very useful.
To tell you the truth, I am more interested in seeing Qt in the real device, although the simulator is useful, I haven't used it often myself. My process is to compile for the desktop with the device aspect ratio and when I am satisfied with the results, I try it on the device. But I do it mainly as a hobby and university, not real work, so "your milage may vary".

https://bugreports.qt.io/browse/QTBUG-47314

I think that we might be a bit disappointed, if I remember well, the CMake scripts for Qt were written by a guy called Stephen Kelly, who used to work at KDAB, but left around a year ago. The CMake scripts are actually built at build time (maybe install? I am not 100% sure). They are created by qtbase/mkspecs/features/create_cmake.prf using qtbase/mkspecs/features/cmake_functions.prf. When I get around to reproduce their generation, I will post it here.

I just want to memorize the fact that it's not a Hunter problem. Issues in Qt must be solved in Qt's bugtracker. If somebody want to add a note or fix it - do it there.
Also I think it's not a big deal. As I already mentioned I can apply a workaround in Hunter. Since we are controlling install process we can customize it. For example I've added extra plugin to aviod explicit linking of frameworks and other missing libraries/flags in user's code: https://github.com/ruslo/hunter/commit/2b2143f299a5ab5b071adc97d05321de38c63ec8 (I will test and add similar plugin for desktop today). Also this is how Boost imported-style libraries added (like Boost::system or Boost::filesystem): https://github.com/ruslo/hunter/commit/80f057704b68aed3931ef8a30f055273c553f62e

For example I've added extra plugin to aviod explicit linking of frameworks and other missing libraries/flags in user's code

https://bugreports.qt.io/browse/QTBUG-47336

Sorry about discussing Qt's internals here.
Your approach of creating the Qt5Widgets_HunterPlugin.cmake was excellent,  this pattern of having cmake list files as Qt5Module_*Plugin.cmake makes much faster to test the fixes, which could later be pushed upstream, if that is to be the case.

I will test and add similar plugin for desktop today

Applied to branch develop: https://github.com/ruslo/hunter/commit/e6bd59c58f96b07d5c2b824843a5d971da73f4e1
(note that you must use CMake 3.1+ to use INTERFACE_SOURCES feature or add ${QT_ROOT}/src/static_qt_plugins.cpp to the target manually)
Qt bug: https://bugreports.qt.io/browse/QTBUG-47349

Android should work now. New HelloGL2 example: https://github.com/forexample/android-cmake/tree/master/05-qt-hellogl2

У нас проблема building Qt components related to qtdeclarative separately the way we do components today: if a component has qml (declarative) bindings, for example qtmultimedia, they will only be installed and compiled if qtdeclarative is not skipped. If qtdeclarative is compiled by itself, it does not take into account qtmultimedia.
The components that generate qml bindings are (at least):
qt3d
qtcanvas3d
qtconnectivity
qtenginio
qtgraphicaleffects
qtlocation
qtmultimedia
qtsensors
qtwebchannel
qtwebkit
qtwebsockets

Do you have any idea what we could do to fix this? I tried looking around how the component build rules are done, but the design seems to be to compile them one by one.
I think that providing a meta component all that doesn't skip anything could be used as a fallback for cases where we don't foresee these interdependencies.

Do you have any idea what we could do to fix this?

We can write explicit rules about each component. Quite the same happenning with qtbase - every component must not skip it by -skip qtbase. Otherwise nothing will be build at all. We can apply same logic here. We need to create list depends_on_qtdeclarative_component and check if the current component is in list. If so do not do the skip. Take a look at scripts/qt-configure.cmake. I will be testing it now.

Понял. But I understand that we end up always building qtdeclarative, even when it might not be desired.
What I was trying to do and didn't succeed, was from a hunter_add_package line like hunter_add_package(Qt COMPONENTS qtmultimedia qtdeclarative), I was trying to make all packages available in a list during scripts/qt-configure.cmake time, to check if qtdeclarative is present, if so to not skip it.  But the full package list information is only available to<EMAIL_ADDRESS>and not carried on.
I am not sure that was a trying to do was a good idea from the caching point of view, if someone wanted qtmultimedia  without qtdeclarative for example. The way you proposed, of always building qtdeclarative, we avoid any complexity on the cache side.

for example qtmultimedia

Works for me actually:
hunter_add_package(Qt COMPONENTS qtmultimedia)
find_package(Qt5Multimedia REQUIRED)

can you please add an example with error

But I understand that we end up always building qtdeclarative, even when it might not be desired.

No, same as qtbase. Qt use special directory for building which doesn't removed after build done (unlike the regular packages). So if you build one component qt3d + extra qtdeclarative, then qtcanvas3d + qtdeclarative - at the end qtdeclarative will be built once.

Sorry for not being clear. qtmultimedia does compile by iteself, yes, however when compiling by iteself, it does not generate its QML bindings under the directory <root-id>/Prefix/qml/QtMultimedia, when both qtdeclarative and qtmultimedia are compiled together, the directory is created, and populated with the following files inside:
Video.qml
libdeclarative_multimedia.prl
libdeclarative_multimedia_debug.prl
qmldir
libdeclarative_multimedia.a
libdeclarative_multimedia_debug.a
plugins.qmltypes

and populated with the following files inside

thanks, see no such files indeed

I've pushed new branch qt-dev with updates. Looks like qml files installed too. Also now 7z archive used for Qt since it's smaller and have configure.exe for windows. I've decide to merge this two updates because in this case we don't need to make a change of PACKAGE_INTERNALS_DEPS_ID. Want to test it more before merging to develop.

Thanks, I see the changes. However I didn't manage to download the 7z archive, for reasons I don't know. I tried many times (10?) however it always fail to download
-- [download 38% complete]
-- [download 39% complete]
-- [download 40% complete]
-- [download 41% complete]
-- [download 42% complete]
CMake Error at Build/Qt/__qtbase/Build/Qt-qtbase-prefix/src/Qt-qtbase-stamp/download-Qt-qtbase.cmake:27 (message):
  error: downloading
  'http://download.qt.io/official_releases/qt/5.5/5.5.0/single/qt-everywhere-opensource-src-<IP_ADDRESS>z'
  failed

    status_code: 18
    status_string: "Transferred a partial file"
    log:   Trying <IP_ADDRESS>...

  Connected to download.qt.io (<IP_ADDRESS>) port 80 (#0)

  GET
  /official_releases/qt/5.5/5.5.0/single/qt-everywhere-opensource-src-<IP_ADDRESS>z
  HTTP/1.1

  Host: download.qt.io

Did it work ok for you?

Did it work ok for you?

Yes, on several platforms.
What version of CMake you have?

What version of CMake you have?

3.2.3 on that machine, but must have been a network issue, I tried several hours later and the download was successful.
Thank for the update, I see the <root-id>/Install/qml/QtMultimedia now with its contents! :-)

Just finished windows build (visual studio, mingw). It works fine so I've removed qt-dev branch and merge it to develop.
@pretyman I'm closing this since Qt work all platforms I've tested: Visual Studio, MinGW, Linux, OS X, iOS, Android. Please open new issue if you'll have any problems in future.

architectures not controlled by toolchain, e.g. it always arm64 + armv7 for device

Link: https://github.com/ruslo/hunter/issues/247

hunter_add_package(Qt COMPONENTS qtmultimedia qtdeclarative)

I'm trying something similar, but am getting errors with qtdelcarative.  I'm curious if it is related.
The following dies for me (android and libcxx toolchains tested) with the latest hunter on the Qt5Declarative include.
if(BUILD_QT)
  hunter_add_package(Qt COMPONENTS qtbase qtmultimedia qtdeclarative)
  find_package(Qt5Widgets REQUIRED)
  find_package(Qt5Multimedia REQUIRED)
  find_package(Qt5Declarative REQUIRED)
endif()

Results in:
CMake Error at CMakeLists.txt:60 (find_package):
  By not providing "FindQt5Declarative.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "Qt5Declarative", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Declarative"
  with any of the following names:

    Qt5DeclarativeConfig.cmake
    qt5declarative-config.cmake

  Add the installation prefix of "Qt5Declarative" to CMAKE_PREFIX_PATH or set
  "Qt5Declarative_DIR" to a directory containing one of the above files.  If
  "Qt5Declarative" provides a separate development package or SDK, be sure it
  has been installed.

@pretyman Were you able to pull in the qt5declarative lib in any project?

Hi,
For the declarative module use find_package(Qt5Qml REQUIRED), however there are some dependencies missing for linking. Unfortunately my machine broke nearly 2 months ago and I couldn't generate Hunter patches to correct the dependencies. I had problems linking in MacOS, iOS and in Linux with the declarative module.
If you get around to working out the dependencies, you can use the Qt5Widgets_HunterPlugin.cmake tecnique that @ruslo used.
Be warned that he put depencies of QtCore together with the Qt5Widgets together into his plug-in, which is not a problem if you are using Qt5Widgets. Since I was not using Qt5Widgets, only declarative, the linking dependencies of Qt5Core didn't come.


[Feature request] Long press on search button opens directly the search filters

long pressing this button should make the option filters appear directly instead of the normal 2 step. Also i ask if you can make the appearance of the option filter faster, it is a bit slow compared to other feature. it is used quite a bit so the speed of its appearance should be improved.
This feature would be quite good and popular if implemented but it is an hidden one so i suggest to add a tutorial or something similar. for example the first time an user clicks the search button tge app should show the user the existence of this shortcut.

Did you install the snapshot app and tried to open search from there?

yes

Is it still slow?

iyes

The idea of adding the filter option after a long press on the search button, I find that it is not too useful. Because the time to do a long press or do the 2 steps will be exactly the same. But if instead of putting exactly the same filter option, we put a much simplified version of the filter option, that would be a good idea.
Like after a long press, it directly offers us the choice between "Upcoming", "Top 100", "Seasonal" etc...
and for the idea of the tutorial, if you could also add the choice of theme.
 But I'm not saying not to put this feature but just  put a simplified filters after a long press.


SW-5518 Localize species enum values on details page

We were showing JSON values, not human-readable names in the user's locale,
for enum fields like growth form on the species detail view.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2718  👈
#2717
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


Add fullscreenWidth and fullscreenHeight properties to Stage

https://github.com/openfl/openfl/commit/8c0aecebd746b7e625a25618e442ac838fca3ddb


GAWB 2778 - Delete error clusters

Changes to allow deletion of error clusters(ClustErrs)
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] I've documented my API changes in Swagger

In all cases:

[ ] Get two thumbsworth of review and PO signoff if necessary
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

jenkins retest

I didn't test, but it looks good, pending minor comments.

jenkins retest

jenkins retest


Basic biological questions: genetic diversity, HWE

By marker type:

[x] SNPs @smanel
[x] Sequence data @mmlopezu
[ ] Microsatellite @mgiresi

Feel free to refer to this issue as each is completed by adding the issue number in your pull request.

@smanel has offered to take up the Microsatellite vignette.


Layer Swipe example does not handle view rotation in OpenLayers 6

Describe the bug
For some layer types the canvas can be rotated in OpenLayers 6 and the example does not handle that.
To Reproduce
As the Bing layer isn't working in the online examples compare rotating the views here
with v5.3.0 https://codesandbox.io/s/layer-swipe-k35iz and with v6.1.1 https://codesandbox.io/s/layer-swipe-8i88c
Expected behavior
Both versions should behave similarly.

@mike-000 Thanks for reporting. Would you be able to create a pull request with a fix?

The Layer Spy, Layer Clipping and possibly the Magnify examples are also affected.  I'll take at look at each of them.


400 Client Error: Bad Request for url

Hi,
i installed Indra using IndraComposed and have problems to get the "nearest neighbors" running. While pair relatedness, OTM nearest neighbors work, i get an error for the nearest neighbors relatedness:
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:8916/neighbors/relatedness
The code i am using is as follows:
data = {'corpus': 'wiki-2018',
             'model': 'W2V',
             'language': 'EN',
             'topk' : '3',
             'terms': ['house', 'engine']
           }
res = requests.post("http://localhost:8916/neighbors/vectors", data = json.dumps(data), headers = headers)
res.raise_for_status()
print('[Nearest neighbor vectors]', res.json())

Hi @efiltz, I can't make a test now, but I guess the problem is because you didn't define a scoreFunction. Include "scoreFunction": "COSINE" in your json to test.

That was it, thanks! I took the code from the paper and did not think of the scoreFunction.


Typo sniping, V2

No mod is safe from my typo sniper.


Retry DB connection on Migration

Fixes #2017
Retries the database connection after encountering any error while connecting for a migration task, specifically within the getMigrate(params params.Database) function. Both lakefs run and lakefs setup connect to the db to perform migration tasks, and will retry the connection if they encounter an error.

Single minor comment. Also - how was this tested?

@itaiad200 This was tested by running the lakeFS image through VSCode. I put break points within both the 'lakefs run' code (where the first connection is made through BuildDatabaseConnection()) and 'lakefs setup' code (where the first connection is through migrate.newWithSourceInstance()), and I was able to confirm that running either command will perform the db connection retries before exiting execution, if postgres is not running yet.


Insiders: Context menu (right click), Manage, and Accounts don't show up after mid-day update

Type: Bug
After second update today it's no longer possible to get context meny in editor, Explorer and everywhere else in app.
Also it's not possible to open Manage and Accounts from activity bar, or click on ... for views.
Shift+F10 does nothing as well.
Looks like from menus only main menu works as expected.
I don't see any errors in DevTools console
VS Code version: Code - Insiders 1.85.0-insider (1ef160d5bc6aab85b74e34c98d7861c7727a37ec, 2023-11-03T11:39:32.113Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.50GB (13.49GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Probably duplicate or related to #197252
@sandy081 is it possible to have another build today, because it's really hard to use VS Code without all context menus?

A new Insiders is en-route

Update is available and it works as expected with it!
Thanks!


Add zip package

unzip command is available, but zip isn't

See "What's included?" in https://hub.docker.com/_/buildpack-deps (https://github.com/docker-library/docs/tree/master/buildpack-deps#whats-included). :eyes:
Can you describe which category you think zip would belong in, and maybe provide some example modules/packages in an ecosystem or two that rely on it? :sweat_smile: :bow:

Right, let me try to rephrase.  The goal of our set of packages is installing modules, which does commonly require un-zipping, but not commonly zipping (that's more of a packaging creation concern, which is not the intent of this image). :sweat_smile:

Going to close for now, but happy to reconsider if we can find example modules which fail to install because they're missing zip :eyes:


Failed to build plugin @nativescript-community/ui-material-core

Hello,
When trying to launch my project with  "ns run android --emulator", I get the following error :

FAILURE: Build failed with an exception.
Build file '.\platforms\tempPlugin\ui_material_core\build.gradle' line: 108

What went wrong:
A problem occurred evaluating root project 'ui_material_core'.

Could not find method compile() for arguments [androidx.appcompat:appcompat:1.2.0] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
Failed to build plugin @nativescript-community/ui-material-core :
Error: Command gradlew.bat failed with exit code 1

I recently cleared my npm cache, I didn't have the problem before. Could it be linked ?
Thank you.

@pkowalezyk what version of the plugin are you using ? we are not using compile anymore as it is not supported by gradle 7

I'm using the 5.3.0 version of the plugin

@pkowalezyk we are at 7.x ;)

It seems that this issue is linked to recent Nativescript dependencies changes.
I solved my issue by updating NativeScript (from 8.01 to 8.2.2).

I have updated the Nativescript (by running ns update).
i now have this issue:
Build file '/Users/liamcharmer/Projects/TraxApp/platforms/tempPlugin/ui_material_core/build.gradle' line: 140

* What went wrong:
A problem occurred evaluating root project 'ui_material_core'.
> Could not find method compile() for arguments [androidx.appcompat:appcompat:1.2.0] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@liamcharmer look at the comment. It is a setup/clean issue


Support Python3.10/3.11, documentation fixes, and general codebase cleanup

Overview
This PR does a bit of cleaning in the code base:

Many unused imports have been removed.
Many Markdown and reST formatting issues (outside the docs) have been corrected.
Some docstrings for functions have been cleaned up for typos and better rendering in the documentation.
Some URL targets that pointed to insecure addresses (http://) have been promoted to secured ones (https://).
References to the master branch have been changed to main
Updated Installation instructions to reflect modern approaches
Added builds on GitHub CI for Python3.10 and Python3.11

Related Issue / Discussion
Closes #637
Closes #590
Addresses some comments in the following issues:
#669
#336
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[ ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

coverage: 81.322% (-0.03%) from 81.35% when pulling 934a43346eb77a88a59ce4a7a98d124f59e5daa9 on Zeitsperre:housekeeping into d0bb9787207e670f4cf8ec5fc3d56abb284226e1 on geopython:main.

I'm happy with this for now. There are more than a few modules that looks to be obsolete, so I'll stop here.
@cehbrecht I'll leave the final review, merge, and release to you.
If you'd like me to add more to the CI/pre-commit side of things, let me know and I'll open another PR for those.

@Zeitsperre looks all good 👍 Thanks for the clean-up 🙂


#428 clarify that global default registry doesn't work when using namespaced registry on downstream RKE2

Resolves #428
I started revamping this page to make it more clear, and to adhere more closely to the style guide. To complete the request, I still need to verify the steps suggested, which requires access to a downstream cluster.

Since my access is still pending, I contacted tlatino to provide screenshots of the downstream cluster UI.

@btat This is still blocked but I don't see any open requested changes.


flexible timestamp format

added daily offset partitioning to support following format to have partiotions backup up per day with hour and minute granularity
/mnt/secor_data/message_logs/backup/28248_12/EnigmaProxyStaging/20161021/02/of fset\=0/1_0_00000000000000025658.gz


Install some Python requirements for supporting local testing.

Companion of https://github.com/apache/incubator-airflow/pull/3933

cc @Fokko :)

Thanks @holdenk Can you add python3 as well? For now we have Python 2 and 3 in one single image. Not the prettiest solution, I know.


stable/grafana Grafana statefulset pod labels

What this PR does / why we need it:
Statefulset does not use the podLabels variable, unlike deployments.
New PR for #21874 which got closed as i had not DCO signed..
Checklist
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x] DCO signed
[ x] Chart Version bumped
[ x] Variables are documented in the README.md
[ x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @zanhsieh

/ok-to-test

/test pull-charts-e2e

/test pull-charts-e2e

/lgtm


Avoid large intermediate product in LCM

Changed the implementation of BigUint LCM from
((self * other) / self.gcd(other))
to
self / self.gcd(other) * other
The division is exact in both cases, so the result is the same, but the new code avoids the potentially-large intermediate product, speeding things up and using less memory.
I also removed the unnecessary parentheses, because I think it's clear what order everything will be executed in. But if others think differently I can add them back.

Don't worry, the build is failing because the syntax API changed again, which is expected from nightlies. My PR #348 is suffering from this too.

Ugh, num-macros... I'm inclined to finally let that die.
This PR is good though -- we already did similar to avoid overflowing primitives in #167.

#351 nuked num-macros, so let's give this a try:
bors r+


Add FTP Support

Hi,
Can you please add FTP protocol support beside WebDAV? Thank you in advance

There is no plan to support other protocols than webdav yet.


Store chain length in header

This adds the chain length (i.e. number of ancestors of a block) to the block header. Note that the chain length is not currently verified anywhere.

Codecov Report

Merging #527 into master will decrease coverage by <.01%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   43.31%   43.31%   -0.01%
==========================================
  Files         175      175
  Lines       15422    15434      +12
==========================================
+ Hits         6680     6685       +5
- Misses       8742     8749       +7

Impacted Files
Coverage Δ

chain-impl-mockchain/src/block/mod.rs
50% <ø> (ø)
:arrow_up:

chain-impl-mockchain/src/block/builder.rs
0% <0%> (ø)
:arrow_up:

chain-impl-mockchain/src/block/header.rs
60.63% <100%> (+1.07%)
:arrow_up:

network-core/src/server/transaction.rs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8bf4d...3120df0. Read the comment docs.


Added Juelich Forschungzentrum

@jayeshbadwaik lib/domains/de/fz-juelich.de: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@philipto  Sorry for the error earlier. I think I have fixed the issue now. Thanks. :-)

@jayeshbadwaik Thank you for the update! Could you please clarify if the organization teaches any students? It looks like as a purely research organization without any education. Am I mistaken?

While the organization itself is a research organization, it does have some courses and hires graduate students as you can see in the links below:

Master Student Hiring
Doctoral Student Hiring
Bachelor's Course
Master's Course

There are probably more courses like this in other departments of the research center.

@jayeshbadwaik Thank you for the clarification. Pull request merged.
Please notice that free educational subscription for JetBrains tools is for students and teachers only, and is valid for using the tools for educational purpose only. If employees of this Institute who are not students, nor teachers, also need a license for JetBrains tools, they are eligible for an academic discount for the tools. They can get the discount by email to<EMAIL_ADDRESS>Thank you!

Thank you!


Explosion radius upgrade

In this PR:

Created button to allow users to upgrade explosion radius
Created attemptUpgrade() function to remove duplicate code when attempting upgrade

LGTM


Can I use "fun App() { MaterialTheme {xxx}}" in html.core?

Hello, I just started learning compose-multiplatform.
I want to use compose-multiplatform to develop html pages.
I found MaterialTheme, which looks better on Android.
I want to use it on the html platform, but I got an error,
ERROR: Compose targets. '[jscanvas]' are experimental and may have bugs!
My original code sourceSets {
         val jsMain by getting {
             kotlin.srcDir("src/main/kotlin")
             resources.srcDir("src/main/resources")

             dependencies {
                 implementation(compose.html.core)
                 implementation(compose.runtime)
             }
         }
     }

added code

     sourceSets {
         val jsMain by getting {
             kotlin.srcDir("src/main/kotlin")
             resources.srcDir("src/main/resources")

             dependencies {
                 implementation(compose.html.core)
                 implementation(compose.runtime)
                 implementation(compose.material)
             }
         }
     }

Just got this error
ERROR: Compose targets '[jscanvas]' are experimental and may have bugs!
Is it because MaterialTheme is rendered using canvas, so it does not support html?
I saw related questions,
https://github.com/JetBrains/compose-multiplatform/issues/1010
https://github.com/JetBrains/compose-multiplatform/issues/2186
I don't know if this is what I understand, I want to confirm, thank you

MatheriaTheme works in Compose WASM target for browser.
You can check examples here: https://github.com/Kotlin/kotlin-wasm-examples/tree/main
MaterialTheme not working for Compose HTML library

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Op not registered 'LSTMBlockCell' in binary running on..

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 x64
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: 1.13.1
Python version: 3.6.7
Installed using virtualenv? pip? conda?: virtualenv
Bazel version (if compiling from source): 0.20.0
GCC/Compiler version (if compiling from source): MSVC 2019
CUDA/cuDNN version: none
GPU model and memory: none

Describe the problem
I exported a .pb model from python. I managed to import this model into Tensorflow C++, but receive the following error message when I add the graph to my session:
"Not found: Op type not registered 'LSTMBlockCell' in binary running on MYDESKTOP. Make sure the Op and Kernel are registered in the binary running in this process. Note that if you are loading a saved graph which used ops from tf.contrib, accessing (e.g.) tf.contrib.resampler should be done before importing the graph, as contrib ops are lazily registered when the module is first accessed.
Press any key to continue . . ."
Provide the exact sequence of commands / steps that you executed before running into the problem
#include "stdafx.h"
#include <stdio.h>
#include "tensorflow/core/public/session.h"
#include "tensorflow/core/platform/env.h"
using namespace tensorflow;
int main(int argc, char* argv[]) {
// Initialize a tensorflow session
Session* session;
Status status = NewSession(SessionOptions(), &session);
if (!status.ok()) {
std::cout << status.ToString() << "\n";
return 1;
}
GraphDef graph_def;
status = ReadBinaryProto(Env::Default(), "C:\Users\workaccount\Documents\werk\hexachord\pycharm\magenta\frozen_test.pb", &graph_def);
if (status.ok()) {
std::cout << status.ToString() << "\n";
}
// Add the graph to the session
status = session->Create(graph_def);
if (!status.ok()) {
std::cout << status.ToString() << "\n";
system("pause");
}
}
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
thank you kindly for your response

@JesseBerdowski Is this issue resolved?

Closing this issue as it has been inactive for more than 2 weeks. Please add additional comments for us to open this issue again. Thanks!


Pilosa feature sync

Fixes #190

Coverage decreased (-0.04%) to 99.546% when pulling daad374a3a155012c023ec39a71831d03bd91305 on yuce:pilosa-feature-sync into e2b8b99542184b68c8f12ae32f23849bc731a39a on pilosa:master.

Hey @yuce, let me (or someone) review these again before you merge them.


incremental load files

multiple yasl source files can be load incrementally.

What would this look like for users of YASL?

I was planning on adding a module system eventually (as in, a way to import YASL files from other YASL files), not sure what you have in mind here

Hi. as you said, importing file and string is what i expected, i guess. "require" in ruby, "import" in python.
"dofile", "dostring" in lua.
behavior and use case is

at first, bootstrap script is loaded
next step, when script calls "loading other script" API, then on the fly compilation is executed,
user can call function in the other bigger script.

bootstrap script like the following
load("foo.yasl"); //  file or string
foo();  // <- foo function is defined in foo.yasl, if foo.yasl cannot be loaded, foo is not found.
it looks like dynamic loading.

Yea, I was planning on adding something like this eventually. I've detailed my plan here: https://github.com/yasl-lang/yasl-enhancements/blob/master/modules.md
Were you planning on working on this or was this just a feature request for me?

no, i'm looking forward to.


Detect button do not recognize Pipfile/Pipfile.lock already present

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add NASNet models

Adds the model builder code for NASNet models - based on the paper Learning Transferable Architectures for Scalable Image Recognition.
Contains pre-built models for NASNet-Large (6 @ 4032), NASNet-Mobile (4 @ 1056) and NASNet-CIFAR (6 @ 768), along with custom NASNet model builder.

@ahundt @farizrahman4u Is the test suite completely broken at this point? It shows that the tests didnt even begin at this point.

It should get to the tests now if you merge with master

Don't forget to include an example & simple test initializing the models.

@ahundt Seems like there are no application tests for some reason in contrib. Also, seems like CRF tests are failing.

yeah I noticed the CRF issue, but I don't know enough about it to make a good fix myself. A bunch of theano code is broken upstream in keras due to a new theano release (and probably here too).

@ahundt Hmm, should I merge this then ? I've tested it extensively locally, and it seems to train properly.

I'm looking through it, does it actually load the imagenet weights from an hdf5 file? I can't find them anywhere but it looks like they are the default

No it doesn't have the ImageNet weights. It simply warns that it was set, but that no weights are available so it continues.
I should probably fix that.

Also any idea what people should see on cifar? Can a note be added? Sorry for so many litttle things

The paper simply mentions the final performance on all models and stresses on ImageNet. Not much on Cifar so I can't add anything for that sadly.

Sorry, wrt cifar I meant the pre-trained cifar weights expected performance.

I don't have the resources to train such models.

oh sorry I thought there was a pre-trained model. LGTM then!


Update dependencies of setup.py for python 3.11 compatibility

Description
This pull request updates the setup.py file to use updated dependencies compatible with Python 3.11.
Changes

Updated dependency versions in setup.py to work with Python 3.11.

Reason
The current dependencies specified in setup.py were not compatible with Python 3.11, causing installation and runtime issues. This update resolves those issues and allows the project to run smoothly with the latest Python version.
Please review the changes and merge if appropriate. Thank you!

lgtm


ValueError: Eval mode argilla not supported.

Hello @andysingal , this is still WIP and should be integrated through a PR with llama-index or manually changing their set_global_handler method.

Awesome, looking forward to it

Hey @andysingal, for a simple workaround for now, you can go to this Pull Request, download the 2 files there and copy-paste them to your local llama-index/callbacks folder. Then, please install the packaga via pip install argilla-llama-index, and then you shoud be fine to go for now. Until the work is merged, this should work.


Update email instrumentation

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1203393655574807/f
iOS PR: TBD
macOS PR: TBD
What kind of version bump will this require?: Minor (new public API added, no incompatibility introduced)
Optional:
Tech Design URL:
CC:
Description:
This PR updates the email instrumentation. See the parent Asana task for specifics.

Steps to test this PR:

Open the Asana task and check that each pixel is fired when expected

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Marked as Do Not Merge as this is pending an upstream Autofill release to get the changes from https://github.com/duckduckgo/duckduckgo-autofill/pull/249.


How to Customize Publishing

ASP.NET 5 -> Publishing and Deployment -> How to Customize Publishing

Hi @danroth27, is there any update on it?
Following http://docs.asp.net/en/latest/fundamentals/environments.html I understand that it is possible and simple to determine environment at runtime.
But, I would like to deploy only the right configuration for each environment, is it possible?
cc: @abriscioli

@sayedihashimi Do we have any notion of environment specific deployment at this point?

just checking in on this. i was linked via pdf render of read the docs aspnet.pdf

And I finally stumbled upon via website now. I've went full circle 🎱

Published as of https://docs.asp.net/en/latest/publishing/web-publishing-vs.html.

Strange, the docs page says you're working on it, and this page says you won't do it. Which one is outdated?

Opened #1643 to track removing the article stub.

Here is the page that include the content https://docs.asp.net/en/latest/publishing/web-publishing-vs.html


HTTP API Shim Implementation

This PR implements a Mesos to SchedulerDriver adaptor which helps current frameworks consumes the new HTTP interface via HTTP Shim without making any changes, when using dcos-commons.
PS: Don't merge it yet, as this PR still depends on locally committed jars (mesos-1.1.0-SNAPSHOT). We are working on getting those published.

This branch doesn't build and it has conflicts

retest this please.

@kow3ns The failure was due to inability to pull an artifact from maven repo. I made a config change, that should fix it.
This branch will likely have merge conflicts for a while, as this will stay as an independent branch until Mesos ships 1.1.0. I'm going to rebase this with master occasionally to keep it sane.

retest this please

Code coverage falls to 75.5% from 79.2%.  Code coverage doesn't have to monotonically increase, but this is too drastic a change.

Under what circumstances could this code be merged?  This needs to support 0.28.x and 1.0.0.

@gabrielhartmann As per the initial discussion, we intended to support this with Mesos 1.1.0. I don't know when we decided to support this for 0.28.x.

Test coverage is now: 79.8%. A net 0.6% increase!

@mohitsoni:  Is this PR going to get to a position, where it will be mergeable (backwards compatible) in DC/OS 1.9?  It is currently getting into disrepair.  It's not passing tests.    If it's not going to be maintained, and/or isn't going to make it into 1.9, I'd prefer that it be closed.

@gabrielhartmann This PR now has a position. We are going to aim for 1.9, and can make it work in a backwards compatible way by shipping our own libmesos.so binaries via unified c11r.
I am the one who should maintain this, I'll spend sometime to do so.

Thanks, Mohit.  Let's revisit this in ~a month.

@triclambert 👍

Closing this one now. Will re-open a new one which uses https://github.com/mesosphere/mesos-http-adapter.


Have Start new trip disappear when trip is in progress

possible solution:  http://stackoverflow.com/questions/30266831/hide-show-components-in-react-native
[--- Commented from Asana.com
#commenter Jeff Schneider
---[aa]


change: widen the modal and improve visibility

Increase the log sheet modal width and also improve the visibility of the log that's being shown by using a darker color to highlight the table row and by decreasing the opacity of the sheet overlay.
Closes #595
Visual Reference
Before

After

The ticket also asks to check if it is possible to decrease the font size of the log to fit more lines which I think we can do. I would also try decreasing the line height.

The ticket also asks to check if it is possible to decrease the font size of the log to fit more lines which I think we can do. I would also try decreasing the line height.

Currently

Font Size
Line Height

16 px
24px


Return errors with context

We should return line numbers if possible for every warning/error/suggestion.
When we build a SDP Explorer it would allow people to highlight a field and it could tell people exactly what it means.

Implemented with 5814c3e3d11c4834883fd97adf80460432c695e1


chore(main): release 0.6.0

:robot: I have created a release beep boop
0.6.0 (2022-10-08)
Features

Add deployment workflow (#7) (5454083)
Add Registration Form (c739f61)
Add remaining upload (#22) (0558e57)
Disassociate Documents and Info Models (#19) (3cefbe9)
Registration overview (#29) (5deae0f)
Require email to be verified to access application (6700fe3)

Bug Fixes

composer.lock contains all dependencies (#45) (336c6ff)
deploy: Source user_bashrc before running script (#15) (ab87cb5)
don't change package-lock.json as part of deploy (b3fe3c2)
Hide registration overview for non-rotex user (964714f)
Make faker available in release build (#41) (91b63e3)
Move faker to release deps in composer.lock too (#43) (031aa31)
workflows names (#8) (2a7f024)

Miscellaneous Chores

Add script to prepare the dev environment (#39) (2fb9f99)
Add shellcheck (#14) (f5c4fe6)
check: Add actionlint (b570927)
check: Add actionlint (#16) (33c9adb)
check: move gitleaks scan to check workflow (5acf9a4)
check: move gitleaks scan to check workflow (#18) (6fd2e94)
check: remove explicit name (1417403)
deploy: Display url (02176a7)
deps: bump axios from 0.27.2 to 1.0.0 (64f0e9b)
deps: bump axios from 0.27.2 to 1.0.0 (#23) (dd812ef)
deps: bump axios from 1.0.0 to 1.1.0 (e001eaa)
deps: bump axios from 1.0.0 to 1.1.0 (#32) (3bfe367)
deps: bump axios from 1.1.0 to 1.1.2 (c422f17)
deps: bump axios from 1.1.0 to 1.1.2 (#35) (742b733)
deps: Bump laravel-vite-plugin from 0.5.4 to 0.6.1 (#4) (bb48127)
deps: Bump laravel/dusk from 6.25.2 to 7.1.1 (#5) (42e81e9)
deps: bump laravel/fortify from 1.13.3 to 1.13.4 (2be90a2)
deps: bump laravel/fortify from 1.13.3 to 1.13.4 (#27) (92d8cc3)
deps: bump laravel/framework from 9.33.0 to 9.34.0 (fad9840)
deps: bump laravel/framework from 9.33.0 to 9.34.0 (#25) (7bf45a2)
deps: bump laravel/sail from 1.16.1 to 1.16.2 (62cd444)
deps: bump laravel/sail from 1.16.1 to 1.16.2 (#24) (f15729a)
deps: bump nunomaduro/larastan from 2.2.0 to 2.2.1 (38efaa3)
deps: bump nunomaduro/larastan from 2.2.0 to 2.2.1 (#33) (bf0285b)
deps: Bump postcss from 8.4.16 to 8.4.17 (#6) (b386a70)
deps: bump spatie/laravel-ignition from 1.5.0 to 1.5.1 (6d15626)
deps: bump spatie/laravel-ignition from 1.5.0 to 1.5.1 (#26) (276b432)
deps: bump tailwindcss to 3.1.8 (9d6f4d9)
deps: bump vite from 3.1.4 to 3.1.6 (c88a498)
deps: bump vite from 3.1.4 to 3.1.6 (#34) (dd7b2d0)
Engage deploy.sh (#13) (5fed68f)
main: release 0.1.2 (2ec2937)
main: release 0.1.2 (#12) (dce179d)
main: release 0.1.3 (09ea578)
main: release 0.1.3 (#17) (b8789c4)
main: release 0.2.0 (b452ffd)
main: release 0.2.0 (#21) (4d62f25)
main: release 0.3.0 (4ce42c4)
main: release 0.3.0 (#28) (46ce642)
main: release 0.3.1 (56e5769)
main: release 0.3.1 (#30) (edb04c7)
main: release 0.4.0 (df0e4cd)
main: release 0.4.0 (#36) (e1d16ec)
main: release 0.5.0 (8b69b9d)
main: release 0.5.1 (c775cb7)
main: release 0.5.1 (#42) (9c84641)
main: release 0.5.2 (dbf9690)
main: release 0.5.2 (#44) (a30132d)
main: release 0.5.3 (82fd9a5)
main: release 0.5.3 (#48) (5c4daaf)
main: release 1.0.0 (baea969)
main: release 1.0.0 (#9) (6ad979e)
remove package name (9329a38)
remove package name (#11) (4659c3b)
Run pint (baefb24)
Set default reviewers for dependabot PRs (#31) (b0b07b9)
Show version in Main Navigation (#46) (1a70375)
update dependencies (24f07a1)
update dependencies (a2200d6)
Use draft releases for sandbox deployment (4a46f2c)
Use draft releases for sandbox deployment (#47) (7cfb0ab)
Use personal access token for release please action (#10) (3095293)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rotex1800/registration/releases/tag/untagged-5e1ac86aebed31290c6f :sunflower:


Add more debug fields to FunctionExecutionStateMachine

Adding some temporary flags to help with debugging in automation

@dotnet-bot test Windows 10 ci_lite_x64_debug please


correct solution not accepted - correct EOL required

The first exercise "HELLO WORLD" in how-to-markdown workshopper states as challenge:

You first challenge is pretty simple. Just create a new file (for example
using touch) and add a single line:
Hello, world!
If you already did this, run how-to-markdown verify to verify your
solution or how-to-markdown run to run your file in the browser.

Notice how the challenge explicitly mentions "a single line".
After completing the exercise the solution is not accepted.
It appears a linefeed (\n) at the end is required, effectively creating an empty second line.
To add insult to injury, in Windows an extra carriage return is given with the linefeed (\r\n), that also invalidates the solution.
The same issue also exists in other exercises within the workshopper.
Suggested fix would be to not require an EOL at the end of the solution.
And to translate all \r\n into \n (windows), and left over \r into \n (macintosh) in the attempted solutions before matching.

Thanks for reaching out!
I've noticed that { position: false } doesn't affect to output. It still keep position information in AST.
@wooorm, I'm guessing you've changed the API? Unfortunately, can't find related options for unified or remark. Can you help?

Hi! 👋
If you use remark-parse directly, it’s simplest (L37):
   const parseAST = str =>
-     Promise.resolve(remark().parse(str, { position: false }));
+     Promise.resolve(unified().use(parse, { position: false }).parse(str));

...or, with the current set-up:
   const parseAST = str =>
-     Promise.resolve(remark().parse(str, { position: false }));
+     Promise.resolve(remark().data('settings', { position: false }).parse(str));

What about converting solution files from CRLF to just LF?
const attempt = fs.readFileSync(filename, 'utf8').replace('\r\n', '\n');

Yeah I think that's a good solution to line endings!

@schellingerhout please, check the latest version from master. Works fine for me.

Shouldn't \r (macintosh) also be replaced by a \n, as I had mentioned in the first post? Or is that ancient history?

I think that’s ancient history indeed!