xmegadrive

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS> (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Bulgaria
Example URLs
https://www.xmegadrive.com/videos/brazzers-presents-violet-starr-kimmy-kimm-call-of-booty-22-06-2022/
https://www.xmegadrive.com/tags/violet-starr/
https://www.xmegadrive.com/categories/milf/
Description
NSFW
Verbose log
[debug] Command-line config: ['-vU', 'https://www.xmegadrive.com/videos/ftvmilfs-jessica-canadian-curves-perfectly-natural-7/']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2<IP_ADDRESS> [a86e01e] (win32_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19042-SP0
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg N-102355-g7c451b609c (setts), ffprobe N-102355-g7c451b609c
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2<IP_ADDRESS>, Current version: 2<IP_ADDRESS>
yt-dlp is up to date (2<IP_ADDRESS>)
[debug] [generic] Extracting URL: https://www.xmegadrive.com/videos/ftvmilfs-jessica-canadian-curves-perfectly-natural-7/
[generic] ftvmilfs-jessica-canadian-curves-perfectly-natural-7: Requesting header
WARNING: [generic] Could not send HEAD request to https://www.xmegadrive.com/videos/ftvmilfs-jessica-canadian-curves-perfectly-natural-7/: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)>
[generic] ftvmilfs-jessica-canadian-curves-perfectly-natural-7: Downloading webpage
ERROR: [generic] Unable to download webpage: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)> (caused by URLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)')))
  File "yt_dlp\extractor\common.py", line 647, in extract
  File "yt_dlp\extractor\generic.py", line 2836, in _real_extract
  File "yt_dlp\extractor\common.py", line 790, in _request_webpage

  File "urllib\request.py", line 1354, in do_open
  File "http\client.py", line 1252, in request
  File "http\client.py", line 1298, in _send_request
  File "http\client.py", line 1247, in endheaders
  File "http\client.py", line 1007, in _send_output
  File "http\client.py", line 947, in send
  File "http\client.py", line 1421, in connect
  File "ssl.py", line 500, in wrap_socket
  File "ssl.py", line 1040, in _create
  File "ssl.py", line 1309, in do_handshake
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "yt_dlp\extractor\common.py", line 772, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3594, in urlopen
  File "urllib\request.py", line 525, in open
  File "urllib\request.py", line 542, in _open
  File "urllib\request.py", line 502, in _call_chain
  File "yt_dlp\utils.py", line 1464, in https_open
  File "urllib\request.py", line 1357, in do_open
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)>

Could you check the same with this build and let me know what you get?
https://github.com/pukkandan/yt-dlp-dev/releases/download/2<IP_ADDRESS>733/yt-dlp.exe

I'll fix the single video issue ASAP. Rest will have to wait for someone else


Connecting to GCS locally works, on remote server DNS lookup breaks

Describe the bug
Running locally object_store connects to GCS just fine, on a remote Ubuntu server it seems to attempt to resolve a google cloud local address and fails to resolve it. Resulting it errors like this:
Encountered request e
rror (error sending request for url (http://metadata/computeMetadata/v1/instance/ser
vice-accounts/default/token?audience=https%3A%2F%2Fwww.googleapis.com%2Foauth2%2Fv4%
2Ftoken): error trying to connect: dns error: failed to lookup address information:
Temporary failure in name resolution) backing off for 0.5767765 seconds, retry 5 of
10

To Reproduce
Run object_store with a downloaded service account key on a OVH dedicated server.
Obviously this will mostly be for me to figure out but I'm fairly lost as to what's different between my local machine and the server. I've checked the service account key file three times, tried installing gcloud and authenticating on the remote machine (I can list the buckets with gcloud storage ls now), still same DNS resolution error.
Here's the keyfile just to rule out there's a problem in there.
{
  "type": "service_account",
  "project_id": "ultra-sound-relay",
  "private_key_id": "5e9cfc9bca6d86a0a3940e2579e0d4e009dcb697",
  "private_key": "****",
  "client_email"<EMAIL_ADDRESS>  "client_id": "115776541199447156360",
  "auth_uri": "https://accounts.google.com/o/oauth2/auth",
  "token_uri": "https://oauth2.googleapis.com/token",
  "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
  "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/migrate-payloads%40ultra-sound-relay.iam.gserviceaccount.com",
  "universe_domain": "googleapis.com"
}

Could OVH be breaking the lookup somehow?

Okay, think I found my answer. Tried to lookup the token_uri on the server and my local machine. Server gives:
nslookup oauth2.googleapis.com
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>#53

Non-authoritative answer:
Name:   oauth2.googleapis.com
Address: <IP_ADDRESS>

That looks broken. Can probably close this. I'll report back if I find a solution just in case others end up here.

The error response suggests it is trying to communicate with the local metadata endpoint, which would suggest it isn't picking up the service account credentials.

Thanks that helped! Found it.  At some point copilot rewrote the with_service_account_path to using the env based setup. But there was nothing in the server's env. Error message could be a bit more helpful than simply hanging forever in this case but either way, user error, thanks for the pointer in the right direction ❤ !


how to start the docusarus app permentely?

📚 Documentation
(A clear and concise description of what the issue is.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)

@madhu6759 Sorry, please describe the problem clearer by updating the description. Feel free to reopen.


add functions to handel merge requests

I added the following functions to support handeling of merge requests:

New-GitLabMergeRequest
Get-GitLabMergeRequest
Set-GitLabMergeRequest
Remove-GitLabMergeRequest
Close-GitLabMergeRequest

Love the additions. Running some tests by hand. Sorry I didn't check these earlier!


Issue 75: IMPLEMENT NAMES sendraw and 353 and 366 callbacks

Here you go.
1 new func, 2 new callbacks, and 2 global vars.
There's likely a cleaner way to do the concurrency and the global vars, but you don't know how many 353 events you will have before a 366. Also, there may be use cases where someone is calling a ton of different irc channels and receiving 353 events from multiple channels (i.e. at initial connection to all channels).
It's a little dirty, but it's working fantastically for my single-irc-channel bot at the moment. Might need some concurrency cleaning up with mutexes / better channels than my implementation in the future.

A few things:

Since all callbacks aren't in goroutines by default, we shouldn't need to communicate between callbacks... There's got to be a better way.
When you JOIN a channel, you should get RPL_NAMREPLY and RPL_ENDOFNAMES automatically, so I'm not sure if you need the additional GetNicksOnChan function.
The name maps should probably be attached to the client, rather than global.
I personally prefer https://tools.ietf.org/html/rfc1459#section-4.2.5 because rfc2812 has a number of inconsistencies with the protocol and isn't widely implemented (even though parts of it are).

The GetNicksOnChan function is so the client can trigger RPL_NAMEREPLY etc...
Issue 75: thoj invited a PR, I attempted. Do you have a better way of containing this functionality in the library and not the client? I won't be offended if you rip it to shreds or change it. (I'll likely just keep using my fork for the time being).
I also used rfc2xxx because that's what was linked to me in issue 75.
Feel free to change it and improve it.

Sorry if I came across as harsh. It's awesome you were willing to do this. Also keep in mind that I'm not the owner of this repo, just someone with a vested interest in golang irc libraries. I haven't gotten around to implementing this in my go IRC library either because of how complicated it can be.
I was imagining something similar to https://github.com/belak/python-seabird/blob/master/seabird/modules/track.py (store which nicks are in which channels) but without all the mode tracking, as it removes a bunch of race conditions, but that's a completely different direction.
Both methods have downsides.
Downsides of your method:

Can't be used by multiple callbacks - nicks will be lost
Will (currently) leak goroutines if the channels are not serviced.

Downsides of the more complicated method:

It's much more complicated and error prone.
Has the potential to do work that isn't needed.

If I change the 366 callback to blocking instead of a go-routine, it shouldn't leak, right?
How does it lose nicks? No other callback other than 353 should be triggering it, so... what am I missing? :)

Ok, I guess I misunderstood the code before and this should actually work. Really sorry about the confusion.
The channel could be avoided completely by changing the maps to something like this:
var tempNickMap = map[string][]string{}
var NickChanState = map[string][]string{}

Then, any time 353 is called, it would add the nicks to the tempNickMap and when 366 is called, the nicks could be moved from nickStaging to NickChanState.
It would be best to attach those to the *Connection struct though, as they're scoped to the connection.
You could avoid compiling the regex on each call of the hander by moving that to a global variable, as that's scoped to the package, not the handler.

Thanks for the PR! :) This has given me some ideas :+1:
I feel global variables are unnecessary. Why no store channel data in the Connection struct? If you do that you can create a Channel struct. Something like this:
type Connection struct {
	sync.WaitGroup
	Debug     bool
...
        Channels  map[string]Channel
....

type Channel struct {
     Name string
     Users map[string]User
     etc...
}

type User struct {
   Name string
   Host string

   etc..?
}

That is likely smart to do it in the Connection struct. Just haven't had time to do any more work on it.

You where way to fast :+1: . I updated my comment. hehe.

That does look good. :)

My fault for not groking the Connection struct enough.

Hacked together this:
https://github.com/thoj/go-ircevent/commit/ad4ec27e859f4964f82912a733f76b86d8f72982
It needs to track joins and parts too and we probably need to split out modes and stuff. Maybe you can build a bit on this? I need to go to bed. Hehe.

+1 Love watching the progress guys.
Let me know if any way I can contribute!

@kevinpostal @jrmiller82 @belak
New commit needs testing and comments: https://github.com/thoj/go-ircevent/commit/9f2cfa5f5abb9dd3934d00e6f122da2329328c0d on nick tracker branch. Seems to work fine for most stuff at my end. Se tests how to use.
irccon.SetupNickTrack() will add the necessary callbacks that will populate irc.Channels.

Example:
package main

import (
        "fmt"
        "github.com/thoja/go-ircevent"
        "sort"
        "time"
)

const channel = "#whaterver"
const serverssl = "irc.whatevernet.net:6667"

func main() {
        ircnick1 := "blatibalt1"
        irccon := irc.IRC(ircnick1, "blatiblat")
        irccon.VerboseCallbackHandler = true
        irccon.Debug = true
        irccon.AddCallback("001", func(e *irc.Event) { irccon.Join(channel) })
        irccon.AddCallback("366", func(e *irc.Event) {})
        irccon.SetupNickTrack()
        err := irccon.Connect(serverssl)
        if err != nil {
                fmt.Printf("Err %s", err)
                return
        }
        go func() {
                t := time.NewTicker(1 * time.Second)
                for {
                        <-t.C
                        var keys []string
                        if _, ok := irccon.Channels[channel]; ok == true {
                                for k, _ := range irccon.Channels[channel].Users {
                                        keys = append(keys, k)
                                }
                                sort.Strings(keys)
                                fmt.Printf("%d: ", len(keys))
                                for _, k := range keys {
                                        fmt.Printf("(%s)%s ", irccon.Channels[channel].Users[k].Mode, k)
                                }
                                fmt.Printf("\n")
                        }
                }
        }()
        irccon.Loop()
}

See #79


NTRs: more specimen assay terms

Requesting terms that follow the same definition/axiom pattern as 'blood assay' and 'urine assay' already in OBI:
cerebrospinal fluid assay
endotracheal tube aspirate assay
induced sputum assay
lung aspirate assay
milk assay
feces assay
umbilical cord blood assay
saliva assay
Requesting terms that follow the same definition/axiom pattern as 'blood microbiology assay' already in OBI:
cerebrospinal fluid microbiology assay
endotracheal tube aspirate microbiology assay
induced sputum microbiology assay

2021-09-20. OK to add following same pattern as 'blood assay'.


Security Vulnerability - Action Required: XXE vulnerability in the newest version of the gpmall

I think the module xml may be vulnerable to Improper Restriction of XML External Entity Reference. It shares similarities to a recent CVE disclosure CVE-2021-3878 in the stanfordnlp/CoreNLP. The vulnerable methods are as follows:

com.gpmall.pay.biz.payment.channel.wechatpay.WeChatBuildRequest.doXMLParse(String xml) in the file pay-service/pay-provider/src/main/java/com/gpmall/pay/biz/payment/channel/wechatpay/WeChatBuildRequest.java.

The source vulnerability information is as follows:

Vulnerability Detail:
CVE Identifier: CVE-2021-3878
**Description: **: corenlp is vulnerable to Improper Restriction of XML External Entity Reference
Reference:https://nvd.nist.gov/vuln/detail/CVE-2021-3878.
Patch: https://github.com/stanfordnlp/corenlp/commit/e5bbe135a02a74b952396751ed3015e8b8252e99.

Vulnerability Description:
This vulnerability occurs because of the Improper Restriction of XML External Entity Reference. Given that the XML schema files which is compromised by a hacker, the victim conducts regular process may result in an XML External Entity (XXE) Injection attack.
Recommended Actions:
The corresponding fixes are similar to CVE-2021-3878 to some extent. I have provided the following fixes by applying several patching statements, ensuring that the external entities and DTDs are not loaded when parsing and processing XML documents using the document builder. You can call the function safeDocumentBuilderFactory I defined below instead of directly calling DocumentBuilderFactory.newInstance() to create a DocumentBuilderFactory object to avoid XXE attacks.
  public static DocumentBuilderFactory safeDocumentBuilderFactory() {
    DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
    try {
      dbf.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
      dbf.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
      dbf.setFeature("http://xml.org/sax/features/external-general-entities", false);
      dbf.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
      dbf.setFeature("http://apache.org/xml/features/dom/create-entity-ref-nodes", false);
      dbf.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
    } catch (ParserConfigurationException e) {
      log.warn(e);
    }
    return dbf;
  }

Considering the potential riskes it may have, I am willing to cooperate with your to verify, address, and report the identified vulnerability promptly through responsible means. If you require any further information or assistance, please do not hesitate to reach out to me.
Thank you and looking forward to hearing from you soon.

我已经收到您的来信啦 Thanks~

烦请您验证一下，谢谢~
如果有必要，我也可以帮忙提交PR，谢谢~


Create dependabot.yml

I configure the dependabot to check for new version of dependencies in requirements.txt, it should automatically create a pull request.
I think it might be useful and prevent dependencies conflict with other package. (For example, I run in a version conflict when a try to install rich).
What do you think ?

eh, sure


User unable to install custom contract

Create a special screen with list of installed contracts, and a form to install one

[ ] Show installed contracts
[ ] Add ABI for existing contract on blockchain
[ ] Deploy new contract on blockchain

@dulanov For rpc('emerald_addContract', [{...}])  do you want address, name, ABI?

everything I think, it will store it as is.
Right now we have:
{
  "version": "0.1",
  "address": "0x085fb4f24031eaedbc2b611aa528f22343eb52db",
  "name": "BitEther",
  "features": ["erc20"],
  "abi": [],
  "options": {
    "erc20": {}
  }
}

where:

version is contract's JSON format version
options -> erc20 can be overrides for erc20 for example (decimals, symbol, etc)

Will add the following for "Deploy new Contract". (It seems odd to have them for simply installing a new contract, because ordinary users will probably be confused by version, features, options)

[ ] Specify features, options, version
[ ] validate ABI JSON


DS-9323 - part 2: Updates creative commons license to 4.0 in example patch operation and geonames.org test data

References
Related to #9625
Ported to 7.x in #9683
Description
This PR just updates the CC license URLs to version 4.0.
Checklist

[X] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[X] My PR passes Checkstyle validation based on the Code Style Guide.
[X] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[X] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[X] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
[X] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[X] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[X] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[X] If my PR fixes an issue ticket, I've linked them together.

You're right. The title only described the change to CCLicenseAddPatchOperation.java. I've updated it to hopefully make it more clear.


x/tools/gopls: noisy results for the undeclaredname analyzer in code with parse errors

Reported by @heschi: the new analysis driver in<EMAIL_ADDRESS>results in very noisy analysis for code that contains parse errors, due to the undeclaredname analyzer.

We should not run this analyzer (or any analyzer, AFAICT) if there are parse errors.
CC @adonovan

The underlying issue here is poor error recovery in go/parser; see https://github.com/golang/go/issues/58833
Running the analyzer only in the presence of zero parse errors, or a small number, or a set of errors whose locations suggest a narrow "blast radius", seems like a good practical step.

I must be missing something, because every time I say this nobody bites, but I'm going to say it again for the record :)
I don't understand why the type checking in the analyzer behaves differently than the type checking gopls does for itself. Aren't they doing essentially the exact same thing? How is the analyzer seeing errors syntactically earlier in the file than the gopls type check run?
(A wild guess: is the file being fixed and the analyzers run on the original content?)

@heschi why do you think the analyzer type checker is behaving differently? This seems clearly to me like a bug introduced when we refactored analysis: we now run analyzers in the presence of parse errors, when we didn't before.

(A wild guess: is the file being fixed and the analyzers run on the original content?)

They both use the same parsing logic.

Er, because the analyzer is reporting a bazillion errors and the "compiler" source only has one...no? Maybe this is the part I'm missing.

What's happening here is:

the parser encounters a type error at "io". That's the red squiggly.
during recovery it consumes a bunch of tokens and produces a bad tree.
the type checker generates an enormous number of spurious "undeclared" errors from the bad tree.
the type-error analyzers in gopls try to augment those errors with quick fixes, but in doing so end up "owning" the errors. That's why the type errors have gold squigglies.

The ultimate fix is in the parser, but we could also do one or more of

make the type checker more cautious about bad trees;
make gopls' type-error analyzers less gung ho in the face of bad trees; and
keep the red (compiler) not gold (analysis) state for those errors.

Thanks both, I get it now. I probably wrote the code that's claiming the errors. Sorry :)

@adonovan I think the problem is slightly more subtle: if we weren't suppressing the type error, the diagnostics would be merged into the 'compiler' diagnostic. But we do suppress the type-checker errors, so there is nothing to merge with.


Game rules change. Whether it is possible to change the way cards are selected

Hello, When I check the human-model Deployment data you provided, I find that when the agent wants to get the card in front, it inevitably passes the card under its feet, so the card under its feet is automatically selected, but it is not the card it wants to select. Could I change the rules so that standing on a card for a certain amount of time that the card is selected, or could I have a button that indicates that the card is selected when the button is tapped? If so, what part of the code should I change?

Yes, you are free to do this. It's in src/cb2game/server/state.py. Look for CardSelection. Note that the logic includes both updating the game state and generating animation events -- you'll need to change both. Also, we wouldn't accept this change if you wanted to contribute upstream CB2, as it changes the rules of the game.
Unfortunately this part of the codebase is still a bit messy. Most of it has been cleaned up.
I recommend just letting users learn to "double step" on a card if they wish to pass without selecting -- doing the shuffle of stepped forward, backward, and then forward again.


Low quality render

I have implemented this library in a React + Electron project, but I am facing issues with low quality. This is the standard code that I have implemented:
function ViewSTL() {
    return (
      <StlViewer
        extraHeaders={{}}
        floorProps={{
          gridWidth: 300
        }}
        modelProps={{
          color: '#008675',
          positionX: 150,
          positionY: 150,
          ref: {
            current: '[Circular]'
          },
          rotationX: 0,
          rotationY: 0,
          rotationZ: 0,
          scale: 1
        }}
        orbitControls
        shadows
        showAxes
        width={400}
        height={400}
        style={{
          backgroundColor: 'white',
          height: '100vh',
          left: '0vw',
          position: 'absolute',
          top: '0vh',
          width: '100vw'
        }}
        url="https://storage.googleapis.com/ucloud-v3/ccab50f18fb14c91ccca300a.stl"
      />
    );
}

Am I doing something wrong?

This is very likely related to https://github.com/gabotechs/react-stl-viewer/issues/35, checkout this comment and see if it helps: https://github.com/gabotechs/react-stl-viewer/issues/35#issuecomment-1675792703.
In short: there seems to be an issue with three library on version 0.155.0, if you are using that version that might be the problem, downgrading to 0.154.0 seems to do the trick

I checked, and indeed I was using version 0.156.0 of three.
I forcefully installed three version 0.154.0 with the following command:
css
npm install<EMAIL_ADDRESS>
Now it works fine.
Thank you.


Indent Guide Colour

One small Quality of Life thing for the indent guides (in my opinion) would be highlighting the most relevant indent guide for the current cursor position.
Ie, for this code in the Oni repo with an example from VSCode:

The most relevant guide is ever so slightly highlighted, just so the current scope can be seen.
@Akin909, I can see a colour variable is being passed over for each guide...would this be as simple as find the indent level one above the cursor and pass over a colour that is slightly lighter for that single guide? If it is, may be worth tagging this as good-first-issue and linking to the code and what needs doing.

Took a peek at vscode's indent implementation to see how they do this here, the function is fairly involved so its not immediately clear (to me) how it works at a glance but for putting it here for inspiration


Improved Grunt compatibility.

Switched to inline array annotation for dependencies, rather than inject annotation. The latter requires a lot more work to uglify with Grunt, the former is much easier and is also Angular's preferred style.

Hi @Hamms thanks for the PR!
Looks fine, but I've been thinking of implementing it with this grunt task when I have time next week. Please let me know if you have the time to help with that, it'd be awesome :p

That grunt task will certainly automate the conversion, but it will also make packaging up this project for bower installation more difficult.
Given the relatively small scope of this project, I'd argue it makes sense to skip the syntactic sugar of injection. At least until the project becomes complex enough to justify a build tool.

Hmm you're right. In fact I haven't got the time to do it (shame).


Need help on a tick script

Hi all:
I'm new to Kapacitor and I'm having trouble coming up with an alert in my mind related to influxdb.
The alert should be triggered when the latest value is greater than the mean() value for the past 24hrs in my current measurement. This alert should apply to any series.
I came up with some TICK script fragments, but have no idea how to put them together:
var last_day_mean = batch
    |query('''SELECT mean("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)

var last_value = batch
    |query('''SELECT last("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)

I thought above nodes are able to join based on the tags(series):
last_day_mean
    |join(last_value)
        .as('last_day_mean', 'last_value')
    |alert()
        .crit(lambda: "last_day_mean.mean" < "last_value.last")
        .log('/tmp/test/log')

but apparently join() would only join on timestamp according to the documentation, which is kind of useless to me, because I want to compare the results for each pair of (site, paa).
I'm in desperate need for a solution like this, I hope I made myself clean enough. Sorry for not being to do enough research as my time is limited. Thanks.

@shang-wang You are on the right track. The pieces your are missing are the align property of the QueryNode or the tolerance property of the JoinNode.
The join operation is time and the group by dimensions (aka tags/series). So all you need to do is ensure that the times match. There are two ways to do this:

Use align so that the queries are performed on the hour every hour
Use tolerance to allow points that are within the same hour to join

An align example
var last_day_mean = batch
    |query('''SELECT mean("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)
        .align()

var last_value = batch
    |query('''SELECT last("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)
        .align()

last_day_mean
    |join(last_value)
        .as('last_day_mean', 'last_value')
    |alert()
        .crit(lambda: "last_day_mean.mean" < "last_value.last")
        .log('/tmp/test/log')

A tolerance example
var last_day_mean = batch
    |query('''SELECT mean("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)

var last_value = batch
    |query('''SELECT last("twoway_delay_min") FROM "latency_prod"."default".latency''')
        .groupBy(site, paa)
        .period(1d)
        .every(1h)

last_day_mean
    |join(last_value)
        .as('last_day_mean', 'last_value')
        .tolerance(1h)
    |alert()
        .crit(lambda: "last_day_mean.mean" < "last_value.last")
        .log('/tmp/test/log')

Hope that helps.

@nathanielc That's super helpful. Please correct me if I'm wrong, but I think the value for tolerance might not be 1h. Because doing a mean() on a period of 1d will not guarantee to give you a timestamp that's within 1h difference of last(), right? But since both mean() and last() only yield one result for each dimension, there would always be a one to one match if I do torlerance(1d).

The tolerance also rounds the resulting points' time so you will only get 1d resolution on your timestamps output for the output of the join node. Is it possible that you do not get at least one point per hour?

It's not possible in theory, but there's no guarantee, like the program that sends data to influxdb crashes. Do I need to have special action for possible empty data like using fill()(just learnt from the doc)?

@shang-wang Yes, fill would work, as well as using the deadman switch

Cool. That's all. Thanks for all this.


change branch reference to 'main' in CONTRIBUTING

Summary

whilst submitting my first PR (# 999), i noticed that the CONTRIBUTING doc referenced master, but it seems that main is the primary branch now.

Set of changes

:memo: changes master to main in the CONTRIBUTING doc
:x: not a breaking change

Note: someone more familiar with this project should review this search for master and update any other relevant references. To my untrained eyes, these likely need updates:

Travis CI badge https://github.com/FormidableLabs/urql/blob/095855302f7dc4e809c7fee6e245981ecbf8aab1/packages/next-urql/README.md#L9
changelog referencing master -- should probably be a permalink too? https://github.com/FormidableLabs/urql/blob/0b43066c28aae9c7567c3057778820826801c55b/packages/react-urql/CHANGELOG.md#L317
changelog referencing master -- should probably be a permalink too? https://github.com/FormidableLabs/urql/blob/8f3c75722a4b6327c686cabf91ee61bbfe507560/exchanges/graphcache/CHANGELOG.md#L294

This PR is open to maintainer edits, so feel free to add any other changes you might need to include :+1:

We don't retroactively change the CHANGELOG so that's fine ✌


🐛 BUG: Durable Object tests won't run, .sqlite error

Which Cloudflare product(s) does this pertain to?
Workers Vitest Integration
What version(s) of the tool(s) are you using?
0.1.19 [@cloudflare/vitest-pool-workers], 1.3.0 [vitest]
What version of Node are you using?
v20.7.0
What operating system and version are you using?
Mac Sonoma 14.4.1
Describe the Bug
Observed behavior
Tests fail with a fatal error when a fetch response body is not consumed by tests.
/Users/maxime/.nvm/versions/node/v20.7.0/bin/node /Users/maxime/Code/NC/lalala/node_modules/vitest/vitest.mjs --run --reporter ../../../Applications/WebStorm.app/Contents/plugins/javascript-impl/helpers/vitest-intellij/node_modules/vitest-intellij-reporter-safe.js --testNamePattern=^ ?smoke checks 404s on non-consume path$ /Users/maxime/Code/NC/lalala/src/durable_objects/Lalala.test.ts
▲ [WARNING] Processing wrangler.toml configuration:

    - "unsafe" fields are experimental and may change or break at any time.

[vpw:inf] Starting single runtime for vitest.config.js...

================================================================================
Failed to pop isolated storage stack frame in src/durable_objects/Lalala.test.ts's test "404s on non-consume path".
This usually means your Worker tried to access storage outside of a test.
In particular, we were unable to pop Durable Objects storage.
Ensure you `await` all `Promise`s that read or write to these services.

- AssertionError [ERR_ASSERTION]: Expected .sqlite, got /var/folders/47/5fsq322s5dx9y0f1c2shbvvh0000gn/T/miniflare-0d475a4a00fc573e720de1f3fdc5d38f/do/vitest-pool-workers-runner--__VITEST_POOL_WORKERS_USER_OBJECTLalala/88e8e9cf16735464763622e7564089aa29822a772684bb26d1a72a7edc321ec8.sqlite-shm
================================================================================

Error running worker: AssertionError [ERR_ASSERTION]: Isolated storage failed. There should be additional logs above.
    at new AssertionError (node-internal:internal_assertionerror:419:15)
    at Function.strictEqual (node-internal:internal_assert:200:11)
    at WorkersTestRunner.updateStackedStorage (Users/maxime/Code/NC/lalala/node_modules/@cloudflare/vitest-pool-workers/dist/worker/lib/cloudflare/test-runner.mjs:107:12)
    at WorkersTestRunner.onAfterRunSuite (Users/maxime/Code/NC/lalala/node_modules/@cloudflare/vitest-pool-workers/dist/worker/lib/cloudflare/test-runner.mjs:142:5)
    at runSuite (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:875:5)
    at runFiles (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:896:5)
    at startTests (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:905:3)
    at Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:114:7
    at withEnv (Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:82:5)
    at run (Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:103:3)

Failure cause not provided for '404s on non-consume path'

Isolated storage failed. There should be additional logs above.
AssertionError [ERR_ASSERTION]: Isolated storage failed. There should be additional logs above.
    at new AssertionError (node-internal:internal_assertionerror:419:15)
    at Function.strictEqual (node-internal:internal_assert:200:11)
    at WorkersTestRunner.updateStackedStorage (Users/maxime/Code/NC/lalala/node_modules/@cloudflare/vitest-pool-workers/dist/worker/lib/cloudflare/test-runner.mjs:107:12)
    at WorkersTestRunner.onAfterRunSuite (Users/maxime/Code/NC/lalala/node_modules/@cloudflare/vitest-pool-workers/dist/worker/lib/cloudflare/test-runner.mjs:142:5)
    at runSuite (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:875:5)
    at runFiles (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:896:5)
    at startTests (Users/maxime/Code/NC/lalala/node_modules/@vitest/runner/dist/index.js:905:3)
    at Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:114:7
    at withEnv (Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:82:5)
    at run (Users/maxime/Code/NC/lalala/node_modules/vitest/dist/chunks/runtime-runBaseTests.0UwIvo_U.js:103:3)

That error is very confusing.
Please provide a link to a minimal reproduction
https://github.com/punkeel/repro-5629
Run make to run tests.

We're having the same issue, commenting out assert.strictEqual(res.status, 204, await res.text()); inside of /node_modules/@cloudflare/vitest-pool-workers/dist/worker/lib/cloudflare/test-runner.mjs:107 works as a temporary solution.

I ran into this issue, so sad I spent time digging. Is there any updates on the PR that was raised to fix it?

Hi @shonubijerry, I'm not sure how to fix this one as I don't know enough about SQLite. I've patched the node module for now (using yarn patch)

hi, I'm going to share my experience which worked for me. According to docs (https://developers.cloudflare.com/workers/runtime-apis/rpc/lifecycle/#explicit-resource-management) you must dispose stubs after have used them, doing:
stub response have a dispose interface on them, which must be called as stubInstance[Symbol.dispose]()
const stub = env.DURABLE_BJECT.get(...);

try {
    // you test condition here
} finally {
    stub[Symbol.dispose]!();
}

or just use:
import { runInDurableObject } from 'cloudflare:test';

described here https://developers.cloudflare.com/workers/testing/vitest-integration/test-apis/#durable-objects

Thanks everyone, and thanks @feliperohdee for the links. It looks like it's worth at the very least making this error message more helpful. I'll add it to our work backlog.

Was getting the same error and the natural thing to try was disposing my DO like @feliperohdee.
This didn't help, but the error was gone when I tried to [Symbol.dispose]() the RPC result, even though it's a plain { string, string } struct which I expect should be just cloned.


Variable Flag Proposal

I'd like to propose the addition of a variable flag (-v, --var) to pass arbitrary variables to Jsonnet. For example:
{

  important_var: error 'must set this',

  grafanaDashboards+:: {
    ...
  },
}

I'd like to be able to run something like grr apply path/to.jsonnet -v important_var=foo.

Discussed this with @malcolmholmes. Requiring variables like this is considered an anti-pattern. Punting on this for now.


when in lifecycle created commit mutation not be logger

Hi!
Please make sure to follow the Issue Reporting Guidelines before opening an issue.
You can ask questions on the forum, the Discord server, gitter or StackOverflow.


Dataset fill does not work like in v2

Expected behavior
Creating a circular dataset (starts and ends in the same coord) it should fill the inside of the generated path.
Current behavior
Creating a circular dataset (starts and ends in the same coord) it does not fill the inside of the generated path.
Reproducible sample
https://codesandbox.io/s/chartjs-fill-tookxv
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
When using v2 of the library i was able to draw a square (and several other shapes) and fill it using a combination of coords that start and end at the same coord and a semi-transparent backgroundColor.
Now it seems this is not possible. It simply does not fill the generated square.
It also seems it can not fill the dataset when going below y = 0, only fills for above 0.
chart.js version
v3.9.1
Browser name and version
Chrome 106.0.5249.91
Link to your project
No response

Has anyone been able to check on this?

Have you tried the 'shape' filling mode created for this purpose?

@kurkle Thank you very much. I didn't know about 'fill' property having new values as in v2 it seemed to only work with true or false.
This has fixed my issue.

@etimberg this issue can be closed.


Detection reproduction

@xiaoaoran Hi, the paper said you apply your method to object detection based on the OpenPCDet toolbox, where is the code? It is also noticed the compared baseline is much lower than OpenPCDet released results (such as pointpillars). I hope to see the code and checkpoints/logs for reproduction. Thanks.

Thanks for your comments.
We would clarify that this paper mainly focuses on semantic segmentation task. This work also conducted preliminary experiments on the task of object detection to verify the effectiveness of PolarMix, e.g., simple experiments with OpenPCDet repo.  As for the baseline,  this work only used two GPUs (instead of 8 GPUs in the OpenPCDet)  for training due to resource constrain and removed some data augmentation processes for faster and simple implementations of experiments. So the baseline performance is a bit lower as compared with OpenPCDet released results. For a fair comparison,  this work directly implemented polarmix on top of the baseline.


你好，关于鼠标移动方面的问题（Machine translation：Hello, I have a question about mouse movement）

已知目前的鼠标移动方案是，通过计算屏幕中心到目标位置的偏移量来进行移动，因此当屏幕中心距离目标位置越近，移动时的偏移量就会越低，从而使屏幕中心到达目标位置的速度就会变慢，因此当目标进行移动时，准心很难跟上目标，哪怕速度的数值加大（这只会导准心晃动），因此能否更换一套鼠标移动的方案，使得这个问题解决，无论目标如何移动，准心都能立刻移动到目标中心位置？我了解了一下，貌似通过pid之类的方式可以实现这个方法，但是由于项目的代码结构比较复杂，我目前无法完成这个，55555555...........
Here is the machine translation：
It is known that the current mouse movement scheme is to move by calculating the offset from the center of the screen to the target position. Therefore, when the center of the screen is closer to the target position, the offset during movement will be lower, so that the speed of the center of the screen reaching the target position will be slower. Therefore, when the target moves, it is difficult for the center to keep up with the target. Even if the value of the speed is increased (which only causes the center to shake), can you change a set of mouse movement scheme, so that the problem is solved, no matter how the target moves, the center can immediately move to the center of the target? I have learned about it, it seems that this method can be realized through pid or other ways, but due to the complex code structure of the project, I cannot complete this at present, 55555555...........

I have submitted a possible patch to allow users to dynamically alter settings to eliminate this issue. PID won't resolve this issue fully due to its heavy reliance of sigmoids.


DOMException: Failed to execute 'querySelectorAll' on 'Element': '[df-excelData-0-Full Name]'

I receive this error and I'm not sure what the exact solution is. I have tried doing const updatedColumnName: string = columnName.replace(/\s/g, "_"); but the issue persists. Thank you in advance for your assistance.

Try without spaces and without capital letters.

thank you it works without capital letters


Edit User Guide to change opening paragraph, add Delete Members & List All Members and Events features and command summary

List should be a single command that displays all members and events.

Ok noted, will fix this ASAP.


CPU Frequency sampling some times causes freeze

I think it might be related to #186 - or even the very same, but I'm not sure, and would like to find the root cause.

Have yet to see this happen again recently, and we are all using different machines with different setups. Closing this for now.

I might have a reproduction of this bug. Although... not sure that it's one that you care about, my development environment is a bit silly.
I have a windows computer, but I do all of my development inside a virtualbox VM running ubuntu. Thus, I think I might actually be getting binary translation when I run the VM, but qemu is very good at that, so it's not unusably slow.
If (and only if) I use grub to boot my service, then it errors out in a manner that appears as if it might be related to this.
Poor man's script to boot an IncludeOS service named IncludeOS_service using grub2 (assuming it's installed on the computer):
#!/bin/bash

make
mkdir -p mkdisk
rm mkdisk/disk.raw
touch mkdisk/disk.raw
truncate -s100M mkdisk/disk.raw

LO=$(losetup -f)

losetup $LO mkdisk/disk.raw

mkfs.fat $LO

mount $LO /mnt

cp -r boot /mnt/
cp IncludeOS_service /mnt/boot/

grub-install --force --boot-directory /mnt/boot/ $LO

umount $LO

losetup -d $LO

qemu-system-i386 -drive file=mkdisk/disk.raw,format=raw,if=ide -device virtio-net,netdev=net0,mac=c0:01:0a:00:00:2a -netdev tap,id=net0,script=/home/marcus/IncludeOS_install/etc/qemu-ifup -nographic -smp 4 -m 128 -k en-us

Assuming boot is a directory with a subdirectory named grub which has a file grub.cfg where boot/grub/grub.cfg contains:
set default="0"
set timeout=5
serial --unit=0 --speed=9600
terminal_input serial; terminal_output serial

menuentry IncludeOS_service {
  multiboot /boot/IncludeOS_service
}

When I run the above commands I get the following output consistently, which seems like it might be related to this:
output.txt

Eh... never mind I think it's actually something else... I commented out the line this bug concerns and it still keeps auto crashing halfway through boot.
I vaguely recall grub having some mechanism that it uses to determine if a boot was successful, and that it kills the machine if that mechanism fails... Wonder if I can actually figure out if that mechanism exists, and if it can be turned off.

It definitely could be, as the CPU freq measuring is the first time in the boot sequence where things take time.. The rest of the boot is barely a few micros.

Actually now I'm thinking it actually does have something to do with the interaction with the PIT.
I commented out the first line, and then it got as far as measuring the APIC timer and would reboot again. Commented out the measuring of the APIC timer and I actually got to the point of booting (although, with everything I commented out timers did not actually work).
At this point though I have a disk.raw that boots with grub, and at least outputs something over the serial port once it is up and running.

Yes, both cpufreq and APIC timer uses PIT :) Guess something funky is going on there

Im going to the conference center now.. if you are there we could have a look :D

Yea! Sorry, I also was just heading out to the conference. I'm in the back of the main hall for both talks this morning.

Okay narrowing down on this: It seems that after the OS::halt in calculate_cpu_frequency, grub just starts again. I've never actually dealt with what x86 does after a halt before, so I guess I'm off to do some intel manual reading and/or code grepping to figure out next steps.

Okay for future people who find this bug:
CPU frequency sampling is the first time that IncludeOS requires interrupts to be working in order to make forward progress (if using multiboot, at the time of this writing).
Therefore, if you came across a comment that lead you to this issue, it might just be indicative of interrupts not working correctly on your boot for some unknown reason.  (For me it was because the IDT had entries that assumed segment 0x8 was executable, and the GDT that was set up by grub had segment 0x8 as a null descriptor. After modifying the GDT to have more IncludeOS friendly content, I could boot past the comment in the code that leads to this issue.)


Retro Artifacts not appearing in tool

Retro Artifacts don't appear in the draft tool. Below is a screenshot of Taken Cards where you can see they are not showing, but they also don't show during the draft. I see the Retro Artifacts on 17Lands. Is there an issue with my download of the card data maybe?

I just checked the downloaded card data and I'm seeing Bone Saw and Gilded Lotus. It's possible that there's a log parsing issue.
Could you attach your DraftLog_BRO_PremierDraft file from the Logs folder? This file contains the Arena log entries from which this application is pulling the draft data.
Thanks.

DraftLog_BRO_PremierDraft_ddf560ea-6278-4804-bc7d-4d71428c3c9d.log
Attached. Thanks.

I'm seeing the missing cards when I read your log (File->Open).

If you open up the debug.log file in the Debug folder, and you search for the word error, do you see any entries?
Also, could you re-download the set, open the log file, and confirm that you're still not seeing those cards?

The issue has gone away after re-downloading the set. Thanks for your quick and attentive responses!


Build Error

Hi, I'm trying to build plasp but I'm getting the following error when I'm trying to make the module and cannot figure out the reason why. Any help will be much appreciated!
/Library/Developer/CommandLineTools/usr/include/c++/v1/experimental/optional:163:4: error:
"<experimental/optional> is deprecated and will be removed in the next
release. Please use C++17's  instead." [-Werror,-W#warnings]
warning "<experimental/optional> is deprecated and will be removed i...
^
In file included from /Users/thestlucas/Desktop/ASP_explainability/plasp/lib/pddl/src/pddl/Parse.cpp:1:
In file included from /Users/thestlucas/Desktop/ASP_explainability/plasp/lib/pddl/include/pddl/Parse.h:6:
In file included from /Users/thestlucas/Desktop/ASP_explainability/plasp/lib/pddl/include/pddl/ASTForward.h:10:
/Users/thestlucas/Desktop/ASP_explainability/plasp/lib/pddl/include/pddl/Variant.h:4:10: fatal error:
'mapbox/variant.hpp' file not found
#include <mapbox/variant.hpp>
^~~~~~~~~~~~~~~~~~~~
2 errors generated.
make[2]: *** [lib/pddl/src/CMakeFiles/pddl.dir/pddl/Parse.cpp.o] Error 1
make[1]: *** [lib/pddl/src/CMakeFiles/pddl.dir/all] Error 2
make: *** [all] Error 2

I'm getting the <mapbox/variant.hpp> error too.

Sorry for the long turnaround. That’s most likely because of extended C++ language support by more recent GCC and Clang versions. I may have to write a fix for that, and I’ll try to do that as soon as I have the time.

@TheStLucas, @jcsi225: Can you point out which compiler version you’re using? I can’t reproduce this exact issue with Clang 9.0.1 and g++ 9.3.0.

Thanks for having a look at this! I'm using g++ 7.4.0.

@jcsi225: Are you on macOS? The explanation could be that I’m building against libstdc++, while the error message posted by @TheStLucas seems to be related to libc++. Dou you know which of the two you’re using?

I'm on Linux --- I'm not certain, but I think that means I have libstdc++. The equivalent error message I'm getting is:

In file included from /plasp/lib/pddl/include/pddl/ASTForward.h:10:0,
from /plasp/lib/pddl/include/pddl/Parse.h:6,
from /plasp/lib/pddl/src/pddl/Parse.cpp:1:
/plasp/lib/pddl/include/pddl/Variant.h:4:10: fatal error: mapbox/variant.hpp: No such file or directory
#include <mapbox/variant.hpp>
^~~~~~~~~~~~~~~~~~~~
compilation terminated.
lib/pddl/src/CMakeFiles/pddl.dir/build.make:62: recipe for target 'lib/pddl/src/CMakeFiles/pddl.dir/pddl/Parse.cpp.o' failed
make[2]: *** [lib/pddl/src/CMakeFiles/pddl.dir/pddl/Parse.cpp.o] Error 1
CMakeFiles/Makefile2:194: recipe for target 'lib/pddl/src/CMakeFiles/pddl.dir/all' failed
make[1]: *** [lib/pddl/src/CMakeFiles/pddl.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Oh, you may just be missing the mapbox submodule.
Did you run
$ git submodule update --init --recursive```

after cloning? If not, the mapbox directory, which is a dependency of plasp as of now and populated by a Git submodule will be empty. Let me know if that’s all there is to the issue you’re seeing.

Oops, that was it. Thank you!

@TheStLucas: I was distracted by the warning about experimental language features, so I missed the part where the submodule wasn’t initialized. Can you check whether the same solution that helped @jcsi225 also works for you?

@TheStLucas: Rereading the error message, I’m almost 100 % sure that it’s just the variant submodule that’s missing. I’m going to close this one assuming that’s the case, but feel free to comment here if you need further help.


[SchemaRegistry] investigate json serializer dependency

[ ] check underlying dependencies
[ ] check for good community support
[ ] supporting Python 3.7+/3.11

Options:

marshmallow: https://pypi.org/project/marshmallow/
pydantic: https://pypi.org/project/pydantic/
jsonschema: https://pypi.org/project/jsonschema/


VW experimental long: Sudden Deceleration From Stop

Describe the bug
Sudden braking when the gas pedal is pressed from a stop and OP engaged.
The issue occurred in Segment 26.
Previous conversation for reference
you were engaged down to a standstill, and successfully went into standstill (a specific state of the ACC subsystem)
[4:23 AM]
you then pressed the gas pedal, and you appear to have disengage on gas enabled
[4:24 AM]
the drivetrain/stopping coordinator will drop the EPB if ACC is disengaged while at standstill
[4:24 AM]
we actually don't have control over that
it's a feature with the car, that I'll have to think about how to deal with
[4:27 AM]
if you were to use stock ACC to follow someone to a stop, and while stopped, press the cancel button, the EPB would drop to prevent rollaway. this is by design.
[4:27 AM]
there are some different ACC control states, which I don't use right now, that are meant for use when the driver is using accel to override. it may be time to do that.
[4:28 AM]
right now this looks to the car like a disengage, and I probably need to show it as driver override to avoid the EPB drop
[4:28 AM]
there are some other nuances to why I'm not doing so now, and I will have to think about them
[4:30 AM]
TSK-side handling of the EPB is a safety thing, like, if the ACC radar suddenly failed/broke/crashed while you were behind a stopped car, the process of dropping the EPB is automatic and taken care of by the TSK independent of the ACC radar
[4:31 AM]
that's why EPB is required for stop-and-go cars, because the driver may not be fully attentive if the car has been at standstill for a while, so the car needs to safely handle the case of radar failure

Which car does this affect?
VW Tiguan R-Line 4Motion 2020 (US)
Provide a route where the issue occurs
4e144f64a2535890|2023-03-27--18-14-02--26
openpilot version
master-ci V0.9.1
Additional info
@jyoung8607

Putting it in the override state and sending 0/inactive accel sounds like the plan.

Currently having some end users test a potential fix.

@jyoung8607 Has the test been working? I'm not sure if its fixed since I never accelerate from stops because now I intervene at every stop to prevent it.


Inventory Difference Operation

I've seen Union and Intersection already exist, but I'd like to retrieve the difference between two inventories too. Could this operation be added? Thanks beforehand for your time.

The difference between the contents/items or the slots of an inventory?

Slots. https://github.com/SpongePowered/SpongeAPI/blob/bleeding/src/main/java/org/spongepowered/api/item/inventory/Inventory.java#L543

How would the difference look like? Or are you looking for a left difference / right difference.
e.g.
difference(a,b) would show the slots in a that are not in b. but not the slots in b that are not in a.
so you could simply call it difference(b,a) ?

Given that Union and Intersection are Formalized set operators, and the results of the methods give resultant sets that correspond to formalized operation results, with formal properties, any method to return 'the difference' should correspond to the formalized difference operation :  ( P - Q )   and should give the corresponding formal results.
While the Union and Intersection operators both have commutative properties   A ∪ B = B ∪ A
A ∩ B = B ∩ A   the Difference operation is not commutative:
(A - B) is not equivalent to (B - A)
A – B = {x : x ∈ A and x ∉ B}              B – A = {x : x ∉ A and x ∈ B}
The difference operation would have to have a unique representation ,most reasonably:
( P - Q ) corresponding to the result of method  .difference(P,Q)
( Q - P ) corresponding to the result of method  .difference(Q,P)

===
Its like how we use And and Or in our communication, yet they take on very different meaning , with strict properties as logical operators: a serving of "Fish and Chips" would be an empty plate logically; a "PeanutButter and Jelly" sandwich just two pieces of bread.

Yes, I understand set theory.
My point was about naming, and API Design / Docs so we knew which operation was being performed by the order of the operators.


What type of JST connector for the solar charge does this board have?

Hi,
can you confirm this board has a  JST PH 2-Pin connector for the solar charge? That's what it looks like.
Thanks

Hello. Is that what you're talking about?

2.0


feat: add support for S3 Extra arguments in Seed file upload to s3

Description
This M.R. (still in draft) adds a profile parameters adding predefined ExtraArgs when making a call to upload_to_s3, during the seed file upload.
resolve #389
Models used to test - Optional

Checklist

[ ] You followed contributing section
[ ] You kept your Pull Request small and focused on a single feature or bug fix.
[ ] You added unit testing when necessary
[ ] You added functional testing when necessary

overall the code looks good to me.
The parameter name should be definitely fixed, I like naming which @nicor88 has offered.
Also it would be nice to add boto3-stubs[s3]~=1.28 row to dev-requirements.txt.
BTW @nicor88 WDYT about migrating from dev-requirements.txt and dependencies in setup.py to poetry ? It may help with dependencies management.

@svdimchenko I think that we discussed that with @Jrmyy back then - we decided to use pip with requirements to adapt a bit with the landscape of other dbt adapters - but I'm happy to reconsider to use it again.

Hi @nicor88 , @svdimchenko - made some changes following the initial review:

Changed the parameter name to seed_s3_upload_args
Applied formatting to the markdown tables
Added an example on how to use the arguments in readme
Added  boto3-stubs[s3]~=1.28 to dev-requirements
Merged on top of current main


[SPARK-11701] dynamic allocation and speculation active task accounting wrong

I am using dynamic container allocation and speculation and am seeing issues with the active task accounting. The Executor UI still shows active tasks on the an executor but the job/stage is all completed. I think its also affecting the dynamic allocation being able to release containers because it thinks there are still tasks.
There are multiple issues with this:

If the task end for tasks (in this case probably because of speculation) comes in after the stage is finished, then the DAGScheduler.handleTaskCompletion will skip the task completion event
race in the task committer where it was ignoring tasks is already committed in some cases.

Test build #50216 has started for PR 10951 at commit 574000d.

Test build #50216 has finished for PR 10951 at commit 574000d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class BitArray
public abstract class BloomFilter
public class BloomFilterImpl extends BloomFilter
        \"Cannot merge bloom filter of class \" + other.getClass().getName()
class CountMinSketchImpl extends CountMinSketch implements Serializable
          \"Cannot merge estimator of class \" + other.getClass().getName()
public class IncompatibleMergeException extends Exception
class TaskMetrics(initialAccums: Seq[Accumulator[_]]) extends Serializable
class ExecutorsListener(storageStatusListener: StorageStatusListener, conf: SparkConf)
class DefaultSource extends HadoopFsRelationProvider with DataSourceRegister
class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):
class ChiSqSelector(JavaEstimator, HasFeaturesCol, HasOutputCol, HasLabelCol):
class ChiSqSelectorModel(JavaModel):
 public static final class Array extends ArrayData
 public static final class Struct extends InternalRow
public class ColumnVectorUtils
 public static final class Row extends InternalRow

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50216/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50219 has started for PR 10951 at commit 249fc78.

Test build #50219 has finished for PR 10951 at commit 249fc78.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50219/
Test FAILed.

@tgravescs Don't we need to make the events posted in the right order, otherwise we'll still run into SPARK-11334? I agree with the high level idea in this patch, but what does it actually fix in terms of dynamic allocation? What were the original symptoms that you observed?

hey @andrewor14.  Yes these changes fix the issue. Its really easy to reproduce if you want to test it out yourself just check the instructions in the jira.  dynamic allocation is pretty broken right now with speculation on.  At least if you want it to give executors back.  Here I changed what was necessary (kind of the minimum) to make it work, all the tests I ran passed.  I ran many times because its all timing dependent on the order in which the events come in and whether speculative tasks finish before original, etc..  Honestly the speculation code needs some cleanup and rework.  I am going to file another jira for that though.
In my opinion, you can try to make things happen in the right order as much as possible, but this is a distributed system and you have to be able to handle things coming out of order.

Test build #51058 has started for PR 10951 at commit 5fc19c7.

Test build #51058 has finished for PR 10951 at commit 5fc19c7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51058/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, test this please

Test build #51099 has started for PR 10951 at commit 5fc19c7.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51099/
Test FAILed.

Merged build finished. Test FAILed.

jenkins, test this please

Test build #51112 has started for PR 10951 at commit 5fc19c7.

Test build #51112 has finished for PR 10951 at commit 5fc19c7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51112/
Test FAILed.

I have no idea why these tests are failing since they shouldn't be related to this change, I'll try to run them locally today.

Actually I see now a couple of the failures are due to throwing the Exception for commit denied so I'll look at those tests closer

Since some of the unit tests are having issues with me change it to throw a commit denied exceptions rather then ignore when needsTaskCommit=false I'm removing that and we can handle it under 	SPARK-13343.
Just sending out the TaskEnd fixes the issue with the accounting being wrong.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51378/
Test FAILed.

Jenkins, test this please

Test build #51381 has started for PR 10951 at commit 7ea0b3a.

Test build #51381 has finished for PR 10951 at commit 7ea0b3a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51381/
Test PASSed.

@andrewor14  this should be basically the same change you had made with addition of the test now.

LGTM. Let's quickly pass this by @kayousterhout before merging.

@kayousterhout  any comments

Its been 2 weeks on this, unless there are other comments I'd like to commit this. @andrewor14  any objections?
not sure this will cherry-pick back into 1.6 cleanly but if not I'll put another pull request up for that.

Sorry for being insanely slow to look at this.  I'm concerned about this code because of this line of code:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L793
We call taskEnded (which results in the code you modified getting called) when an executor is lost, for all of the tasks on that executor.  I think it's possible, as a result, to get multiple task-end events for a particular task, in theory (if messages get re-ordered), so I think this could result in multiple SparkListenerTaskEnd events for the same task.  I didn't look at this super thoroughly so let me know if you think this is a non-issue.

thanks for the feedback, I'll check into that.

So I don't  think this PR changes that. https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L793
sends the reason as Resubmitted so even before this change it would have sent the event because it checks to see if its != Success.
https://github.com/apache/spark/pull/10951/files#diff-6a9ff7fb74fd490a50462d45db2d5e11L1149
The only time it now sends the taskEnd that it didn't before is:
if (!stageIdToStage.contains(task.stageId)) {

To add some more detail,  the executorLost function only calls taskEnded  (which is task failed) if the task was in the list of successful tasks.  handleSuccessfulTask calls the taskEnded and then adds it to the list of successful tasks. since taskEnded ends up sending the CompletionEvent it is possible for the events to show up in either order.
But the DAGScheduler.handleTaskCompletion before this PR handled both of those already and sent SparkListenerTaskEnd in both cases. This PR doesn't change that behavior for those 2 events.
The messages are success and resubmitted (which is failed).  Both of which DAGScheduler.handleTaskCompletion would send the SparkListenerTaskEnd event for both with this PR and before this PR.
If there is anything else you think I missed let me know.

some minor comments, otherwise lgtm

Test build #53086 has started for PR 10951 at commit 68b64ae.

I'm merging this into master since DAGSchedulerSuite already passed.

Test build #53086 has finished for PR 10951 at commit 68b64ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53086/
Test PASSed.


Fix "Run single instance listener" feature

As reported on the mailing list, at least on Windows, the "Run single instance listener" option does not work.

Hi dscho,
here at EMBL, Heidelberg, we also used the single instance ImageJ to call a script from another program. At the moment I just reverted to IJ1 but this is definitely not a solution.
May be there is another way? for instance build a socket communication with Fiji and send commands, scripts through it.
Thanks
Antonio

@manerotoni: Realistically, there is no one on the core development team who can reimplement this feature for ImageJ2 any time soon. However, pull requests are very welcome. The patch would go in the ImageJ Legacy component's LegacyCommandline class. A starting point is the OtherInstance class of ImageJ1, which would need to be adapted for use in ImageJ2. The OtherInstance code takes care to connect to the existing ImageJ1 instance in a secure (local and user-specific) way, so is worth studying.

Fixed by imagej/imagej-legacy#116.

Hi! I was just trying to open some images from the command-line in linux, in an existing FIJI instance.
The relevant checkbox under Edit -> Options -> Misc... is checked.
However, after starting FIJI with ./ImageJ-linux64, and running ./ImageJ-linux64 images/icon.png, another instance is started instead of using the previous one.
After reading #184, I figured that it is not the expected behavior.
If I try using the --ij1 flag to launch FIJI, or if I try using ImageJ1, the image opens as expected. This is sufficient for my current need, but I'd prefer using FIJI instead.
Is there a way of opening images in an existing instance of FIJI? Was the feature removed?
I'm using GNU/Linux.

PS: Thanks for all the work on ImageJ :)


ensure int and float cols get treated separately

as it appears the return type from getStatsVal() is always float due to the mix of types in that class.
Note: there could be an argument for having the counts and pixCount also being handled differently as they are uint32 rather than int32. But because they are written to (currently) int32 columns maybe we should store them as int32 to reduce the confusion...

Decided that the current behaviour wasn't doing any harm.


lint error

Hello.
I just created a react project using dooboo-cli (v3.6.1), installed the package, and ran yarn lint.
Then I got several errors as below.
    1:8  error  'React' was used before it was defined  no-use-before-define

I didn't change any codes after creating a project using dooboo-cli.
How can I fix them ?

@bumjoo Sorry for the delay! I think this is now fixed. Please feel free to reopen when you still face the issue.


OpenCV Android - Cannot Resolve Corresponding JNI Function/No implementation found for

I'm trying to build https://github.com/SandroMachado/openalpr-android for Android. It builds and launches, but after calling native method for recognizing it makes an exception. Thanks for your time and help!
The error
Caused by: java.lang.UnsatisfiedLinkError: No implementation found for java.lang.String be.mike.licenseplate.AlprJNIWrapper.recognizeWithCountryRegionNConfig(java.lang.String, java.lang.String, java.lang.String, java.lang.String, int) (tried Java_be_mike_licenseplate_AlprJNIWrapper_recognizeWithCountryRegionNConfig and Java_be_mike_licenseplate_AlprJNIWrapper_recognizeWithCountryRegionNConfig__Ljava_lang_String_2Ljava_lang_String_2Ljava_lang_String_2Ljava_lang_String_2I)
Also the function recognize,etc are red " Cannot resolve corresponding JNI function "

Note that SandroMachado version calls JNI with different package name (org.openalpr vs com.openalpr.jni) and library name from the original openalpr. If you are somehow mixing these two, it won't work with the given exception. This repo specifially references uploaded binary SO under jniLibs folder so it may not work if the device is not a compatible architecture.


Reproduce FIM Evaluation

Hello, thanks a lot for your great work.
Could you kindly advise on how to reproduce the evaluation results of FIM as shown in Table 6 of your paper?
I tried to use bigcode-evaluation on Santacoder_FIM with the Insertion prompt structure from this repository, but it still generates very long content and I can't reproduce the results in the paper.

<｜fim▁begin｜>def quick_sort(arr):
if len(arr) <= 1:
return arr
pivot = arr[0]
left = []
right = []
<｜fim▁hole｜>
if arr[i] < pivot:
left.append(arr[i])
else:
right.append(arr[i])
return quick_sort(left) + [pivot] + quick_sort(right)<｜fim▁end｜>
you need to use this prompt


validate.validators.myAsyncValidator fix example?

Async validators should resolve with the error, not reject.


Edit Keycloak OpenID endpoint url

What kind of change does this PR introduce?
OpenID Endpoint Configuration as mentioned in realm admin panel is not included '/auth/' in URL. keycloak documents describe endpoint URLs.
EXTERNAL_KEYCLOAK_URL = https://keycloak.example.com/auth/realms/myrealm IS NOT Correct.
EXTERNAL_KEYCLOAK_URL = https://keycloak.example.com/realms/myrealm IS Correct.
Bug fix, feature, docs update, ...
What is the current behavior?
Readme show a bad URL example.
Please link any relevant issues here.
What is the new behavior?
This PR can help users to have a better deploy without confusion.
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Thanks for spotting this and filing the PR! Seems like this was updated in later versions of Keycloak


How to make subcommand required?

I would like to make a subcommand required, could you please advise how to do it? ;>
Let' say I have one main command defined like this:
@CommandLine.Command(name = "main", subcommands = { LoadCommand.class, ValidateCommand.class, RenderCommand.class }, subcommandsRepeatable = true)
public class MainCommand

How can I make LoadCommand subcommand required and other subcommands optional?
I use the basic parsing approach with ParseResult.
I would appreciate your help :)

To make it mandatory for users to specify a subcommand (so they cannot specify the top-level command on its own), the easiest way is for the top-level command class to not implement Callable or Runnable, and start the application with the execute API.
This makes any subcommand mandatory.
To make the LoadCommand required and the ValidateCommand and RenderCommand optional, I would suggest making these last two commands subcommands of the LoadCommand:
main
  |
  +-- load
       |
       +-- verify
       +-- render

I am not sure what you mean by "I use the basic parsing approach with ParseResult".
Are you not using the execute API? That makes it a bit harder. :-) You will basically need to duplicate the RunLast execution strategy in your application. Can you clarify why the execute API does not meet your requirements?

Thank you for your answer :)
Yes, you got it right :P I fell like I cannot use execute API, but maybe I am missing sth :P
My scenario:
In my application I have couple of steps that are launched in a pipeline manner:
load -> validate (validation_1,  validation_2) -> render (rendering_1, rendering_2)
Validate step requires artifacts that are created in the load step
Render step requires artifacts that are created in the load step and in the validate step
Now when I thought about how to design a command line interface i came up with sth like this

where:

load, validate, render are commands

validation_1, validation_2 are validate subcommands

rendering_1, rendering_2 are render subcommands

This is how I designed it and I feel like it would be hard to fit execute API here. Thus I decided to use only ParseResult to have more control over the application flow and so on.
Another thing is repeatable subcommands not going up hierarchy (#1149), which makes it impossible to parse command line args using the above interface.
But maybe I misunderstood sth and I chose not neceserriily the best path, thus if you feel like there is a better aproach to it, I would be glad to hear :)

Perhaps you could consider the RunAll execution strategy?
This section in the user manual has a short example.
If you do need to create your own handling of the ParseResult, I recommend you start with these two lines, to handle requests for --help or --version for any of the subcommands:
        Integer helpExitCode = CommandLine.executeHelpRequest(parseResult);
        if (helpExitCode != null) { return helpExitCode; }

Ok, thank you, I will give it a try and will come back with some remarks if I have any ;)


can't validate for presence

Hi, I would like to ensure my ranked model never has nil in the ranked position, but for some reasons if I do that it doesn't populate the position attribute with a default value:
class Item < ActiveRecord::Base
  include RankedModel
  ranks :position

  validates :text, :position, presence: true
end

And these are my specs:
it "should not be valid without position" do
  @item.text = "Test text for item"
  @item.position = nil
  @item.should_not be_valid
  @item.should have( 1 ).errors_on( :position )
end

it "should have relevant default position" do
  @item.text = "Test text for item"
  @item.save
  @item.should be_valid
end

Results in:
should have relevant default position (FAILED - 1)
should not be valid without position

Failures:

1) Item creation: should have relevant default position
 Failure/Error: @item.should be_valid
   expected #<Item id: nil, text: "Test text for item", position: nil, created_at: nil, updated_at: nil> to be valid, but got errors: Position can't be blank
 # ./spec/models/item_spec.rb:25:in `block (3 levels) in <top (required)>'

Obviously if I remove the validation inside my model the default position is populated but the validation fails.
Can I have both behaviors? Is this a bug?

Closing this. This is a column the gem user shouldn't be too concerned with. Trust that the code is well tested :D


Smarty View support for Slim 4

Please release Smarty View support for Slim 4

Not sure what you mean. Have you tried this package for Smarty and Slim 4?

https://github.com/mathmarques/Smarty-View

This question is not directly related to Slim. The Slim 4 issue for the Smarty-View package can be found here.


[SASS-2756] TailoringAddIncomeSourcesDetail Audit

Description
Please include a brief summary of the change you've made and the issue that it fixes.
Add a link to the relevant story in Jira
SASS-2756
Checklist PR Reviewer
Before Reviewing

[ ]  Have you pulled the branch down?
[ ]  Have you assigned yourself to the PR?
[ ]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of main?

Whilst Reviewing

[ ]  Have you run the tests?
[ ]  Have you run the journey tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current main that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

Checklist PR Raiser
Before creating PR

[ ]  Have you run the tests?
[ ]  Have you run the journey tests? (where applicable)
[ ]  Have you addressed warnings where appropriate?
[ ]  Have you rebased against the current version of main?
[ ]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[ ]  Have you checked the PR Builder passes?

Could this be rebased please?


Hybrid Metric - Clinical Blood Draw Completeness for Henry Ford

NOTE: Issue is a continuation of #31.
Requestor(s): Biospecimen Team
Table or Figure title: Baseline Clinical Blood Draw Completeness by Collection Location, Henry Ford Health System
Metrics to be updated or created: Create new table for this metric.
Variables needed (include variable name and Concept ID):

Verification status (821247024 = 1)
Finalized Collection (410912345 = 1)
Clinical Setting (650516960 = 1)
Clinical Location ID (185243482)

1050010095 = HF Wyandotte Hospital
1060010063 = HF Macomb Medical Pavilion
1040010047 = HF West Bloomfield Hospital

Specify numerator and denominator by variable name where applicable:

Denominator = Verified status (821247024 = 1)

Mock-up table if applicable:

Table layout should match that of tables 7, 7.1, & 7.2, in the weekly biospecimen metrics report (posted on 7/10)

Notes:

Table should exclude verified participants with no complete collection.

Approved by: Biospecimen Team

@KELSEYDOWLING7 In reference to your comment in #31, can you post what the table looks like currently?

@HopkinsDC The final version of the tabel can't be run yet but this is what it looks like for now. All blood tubes are showing as collected

@KELSEYDOWLING7 I'm a little confused about why it can't be run. Wouldn't the "Partial Blood" and "No Blood" columns be zeroed out for number and percent if all the draws are complete? So it should look like Table 7.1 (screenshot below) but with zeros for the partial blood and no blood columns and the totals for the locations (3 and 5) in the far right column.

@KELSEYDOWLING7 This table looks good. Please add to the next weekly biospecimen report (7/17).
I'll keep an eye on HF's clinical collections for incomplete blood collections and will open a new issue when this table needs to be recoded (or will you automatically know when this happens?).

@HopkinsDC Great! I think the new code will break once we have incomplete collections, but just in case if you could let me know that would be great

@KELSEYDOWLING7 Will do! Thanks.


Add macCatalyst support

It adds SUPPORTS_MACCATALYST = YES, so it is possible to build for macCatalyst directly from Xcode without doing any changes to the project.

How can I see failures from Jenkins? I am unable to access it.

It works fine with Swift Package Manager!


Add runtime implementation for Set & Map

Closes #117.
The only down-side of this addition are the trait bounds T: Clone + Eq + Hash that now lie on the
types used. However, in our test suite, only one test had to be modified to fit that change.

Can we change the signatures of the methods to take arguments by value instead of by ref to avoid cloning internally?

Can we add a test for Set and Map which uses the #[test] annotation to ensure that we get the expected results at runtime?

This is now ready.


box-shadow always gets larger and larger on effect 'fade'

This is a bug.

Swiper Version: 4.3.5
Platform/Target and Browser Versions: macOS
Live Link or JSFiddle/Codepen or website with isssue: https://codepen.io/SilencerWeb/pen/XPpdvO

Expected Behavior
box-shadow should be always the same and it should not get larger on every slide
Actual Behavior
box-shadow gets larger and larger on every slide

@SilencerWeb yes, because all elements are rendered together for the fade effect.

@kukac7 any hack to fix this?

@SilencerWeb are you just giving the first slider elements shadows?

but it doesn't work if elements have different sizes

Or
fadeEffect: {
    crossFade: true
},

@kukac7, @nolimits4web yup, this works :)


Respect ignore label on node removal

as we do respect the special name from settings
https://github.com/rancher/rancher/issues/23983
to fix the use case described in https://github.com/rancher/rancher/issues/23983#issuecomment-559210627

TF is unrelated; logged a separate issue for tracking https://github.com/rancher/rancher/issues/24365


[BUG] Paths for file uploads are hard coded

Describe the bug
Flowise uses a hard coded folder path for some file uploads. This breaks on read-only file systems and cannot be configured.
To Reproduce
Steps to reproduce the behavior:

Try to run flowise in a read-only file system
See error

Error: EROFS: read-only file system, mkdir
'/usr/local/lib/node_modules/flowise/uploads'
Code: EROFS

Expected behavior
File uploads should respect the storage settings passed in via env variables (ie either BLOB_STORAGE_PATH if using local storage or the S3_* variables).
Setup

kubernetes (official docker image), read-only file system, S3 storage, Postgres DB
Flowise Version 2.1.3
OS: Linux

Additional context
Hardcoded paths are here:

https://github.com/FlowiseAI/Flowise/blob/d0571291b76883a60cec7a004069a4175647172c/packages/server/src/routes/attachments/index.ts#L8
https://github.com/FlowiseAI/Flowise/blob/d0571291b76883a60cec7a004069a4175647172c/packages/server/src/routes/openai-assistants-vector-store/index.ts#L7
https://github.com/FlowiseAI/Flowise/blob/d0571291b76883a60cec7a004069a4175647172c/packages/server/src/routes/predictions/index.ts#L8

And multer will try to create the destination directory if passed as a string and if it does not exist:

Note: You are responsible for creating the directory when providing destination as a function. When passing a string, multer will make sure that the directory is created for you.
https://www.npmjs.com/package/multer#diskstorage

There seems to already be some functionality for getting the right paths elsewhere: https://github.com/FlowiseAI/Flowise/blob/d0571291b76883a60cec7a004069a4175647172c/packages/server/src/controllers/get-upload-path/index.ts#L4

Yep, I think we should definitely change the hard coded multer path to either whatever env variables that was set, if not, default to the hard coded path

Would this be as simple as just replacing __dirname with imported getPathForUploads()?

Would this be as simple as just replacing __dirname with imported getPathForUploads()?

I think so, but I do not know enough TypeScript or about the internals of Flowise to confirm or deny.

Unfortunately it didn't work, I tried several variations but I also don't know ts that well.
Given the controller is async it was a little complicated to get a string out,
otherwise we could convert to a sync func perhaps.

@HenryHengZJ This then only works for storing the blobs locally, right?


[BEAM-1964] Pin versions in tox script

R: @aviemzur @sb2nov

LGTM

On a side note I think we should also think about a long term strategy of upgrading things. It'll be great to be able to configure https://www.versioneye.com/ for Beam. As that will allow us to keep track of security issues as well. Thoughts?
cc @davorbonaci

(Maven has versions plugin that does this. Other good tools welcome too.)

Changes Unknown when pulling ce44e10b66600c9155523e1621375a1bc19b4f15 on aaltay:lint into ** on apache:master**.


(core//): Added DLA support for NVIDIA platforms

Signed-off-by: Anurag Dixit<EMAIL_ADDRESS>Description
Changes include:

Device selection API introduced (For multi-GPU systems)
DLA support for NVIDIA Jetson AGX platform
Test script for API validation on DLA in half-precision
An abstraction of device selection based on TensorRT engine

Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.

Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation and have regenerated the documentation (make html in docsrc)
[x] I have added tests to verify my fix or my feature
[x] New and existing unit tests pass locally with my changes

Closing this PR. The device metadata serialization part seems to be merged here as well somehow. Splitting this PR into:

DLA support only  + Review comments from here
Device meta data serialization/deserialization


Question on dynamic module

I apologize for opening an issue when my question isn't an actual issue.  I don't know if there is a forum where I can ask questions about t3js.  I am new to t3js so please bare with me.  Please let me know if it's possible to do what I am asking currently or I need to make code for it. I am also open to suggestions on alternative approaches that I can use to solve these questions.  thanks

A lot of our app UI modules are loaded dynamically, and I would like the modules to be as self contained as possible.  Currently the only way I see a module can be loaded is insert some markup into the dom and call Application.start on it.  I would like to be able to start a module without the markup in the dom.  I want my module to be able to inject itself into the dom element I am passing in, and clean up itself.
Is it possible to configure the context?  I am plugging in other modules developed by other teams that doesn't use t3js. They be looking for contextObj.viewport instead of contextObj.element or contextObj.getElement().  I would like to be able to augment some additional method to the context so that I can customize it for the various modules I am using.
thanks

Modules are designed to be in the DOM, there's no way to start a module that isn't in the DOM already.
No, context is specifically designed to not be configured. It's job is to provide a consistent interface that is the same for every module. If you need to expose other functionality, then you would do so by creating a service and adding the extra functionality there.


Language in titles

Hello!
I have an issue with changing language of countries from English to any others (Russian, in my case). Is there in option to set another language in titles list?

@erselnordlys There is no localization support. But you can pass the countries yourselves as a prop - onlyCountries
You can localize the list yourself by requiring it from the package country-telephone-data
var ReactTelInput = require('react-telephone-input');
var countryTelData = require('country-telephone-data')
var onlyCountries = countryTelData.allCountries.map(localizeCountryNames)

// in your jsx
<ReactTelInput
    {...otherPropsForReactTelInput}
    onlyCountries={onlyCountries}
        />


"Asciidoc Prose Fixup" Command

Added an "Asciidoc Prose Fixup" Command. See FIXUP_CONVERTED.adoc for details.


Hosting: Supabase Edge Functions doesn't work

Hello,
I've been following the current hosting tutorial as show on this documentation page : https://grammy.dev/hosting/supabase.
Deployment is successful and the webhook is correctly set, but despite following all these steps, Edge Functions logs keeps serving me the following message when I sent one of the examples commands :
TypeError: cannot read headers: request closed
at get headerList (ext:deno_fetch/23_request.js:118:17)
at request. (ext:deno_fetch/23_request.js:571:60)
at get [headers] (ext:deno_fetch/23_request.js:253:46)
at get headers (ext:deno_fetch/23_request.js:453:16)
at stdHttp (https://deno.land/x/grammy@v1.23.0/convenience/frameworks.ts:224:17)
at https://deno.land/x/grammy@v1.23.0/convenience/webhook.ts:24:75
at Object.handler (file:///home/deno/functions/telegram-bot/index.ts:20:18)
at respond (ext:sb_core_main_js/js/http.js:162:38)
at handleHttp (ext:sb_core_main_js/js/http.js:122:5)
at eventLoopTick (ext:core/01_core.js:64:7)
event loop error: Interrupted: operation canceled
at async readableStreamCollectIntoUint8Array (ext:deno_web/06_streams.js:1074:19)
at async consumeBody (ext:deno_fetch/22_body.js:241:9)
Curiously, this doesn't happen whenever I use the decrepated version of Grammy (1.8.3) as shown on this tutorial : https://github.com/grammyjs/examples/blob/main/setups/supabase-edge-functions/supabase/functions/telegram-bot/index.ts
Any help would be appreciated,
Thanks

It turns out that this code excerpt taken from a recent repository using this hosing method works:
import {
  Bot,
  webhookCallback,
} from<EMAIL_ADDRESS>
const token = Deno.env.get("BOT_TOKEN");
if (!token) throw new Error("BOT_TOKEN is unset");

const bot = new Bot(token);

bot.command("start", (ctx) => ctx.reply("Welcome! Up and running."));
bot.command("ping", (ctx) => ctx.reply(`Pong! ${new Date()}`));

const handleUpdate = webhookCallback(bot, "std/http");

Deno.serve(async (req) => {
  const headers = req.headers;
  try {
    const url = new URL(req.url);
    if (url.searchParams.get("secret") !== Deno.env.get("FUNCTION_SECRET")) {
      return new Response("not allowed", { status: 405 });
    }

    return await handleUpdate(req);
  } catch (err) {
    console.log(headers);
    console.error(err);
  }
  return new Response();
});

Even tough very few changes have been made from the recent example shown in the documentation. If anyone has an explanation why this is happening, let us know.

Is the only difference the version of the grammY core library? If so, then it could be a regression in grammY. Can you narrow this down?

Sure, it seems that the import serve method is decrepated, and now use the Deno.serve. While I tried to import the latest version of grammY into the older method, it kept looping on the error I've shown above. Now, it seems to work like a charm even with the latest version of grammY. It was just a beginner mistake I guess.


Focus/RawKeyboardListener widgets don't receive events in some cases

I tried to create a simple flutter app which used a RawKeyboardListener. It worked well under the android emulator using the non-Fuchsia flutter workflow, but when I moved it to Fuchsia and ran it as a Fuchsia app, it did not receive keyboard events.

See https://fuchsia.atlassian.net/browse/FL-270 for discussion & related work.


Added chatscreen

Created the UI for chat screen and also resolved the floating action button problem

1.Solved the overflow issue
2. Removed physics: NeverScrollableScrollPhysics(),
3. Modified the AppBar and shifted it to individual screens.

flutter analyze is failing
and this branch has conflicts with master branch


Hackerrank problems solutions.

Solutions on questions of Hacker-rank are missing from this repository.

GFI  @Harshit9369 👍


Apisauce Plugin

Fetch is out of the box.  Apisauce requires axios.  Even though I'm big fan of it (and think the author is very handsome), we should provide this as a plugin.

We don't plan to build this plugin, so I'm going to close it. apisauce is part of Andross and Bowser anyway.


Create API to listen to device orientation change events

Ability to read device orientation and register a listener for when it changes.

+1. Would also be nice to control orientation on a per route basis in a Navigator

Also, it would be nice to be able to "lock" the screen programatically.

@joewalnes  Is this sort of API what you're looking for? (generally mirrors the UIDevice API)
DeviceIOS = {
  Orientation : {
    Unknown
    Portrait
    PortraitUpsideDown
    LandscapeLeft
    LandscapeRight
    FaceUp
    FaceDown
  }
  getCurrentOrientation
  addChangeListener
}

// Flux-esque change callback:
DeviceIOS.addChangeListener(() => {
  var currentRotation = RotationStore.getCurrentRotation() // one of DeviceIOS.Orientation
})

@jlevine22 you mean force certain routes to be either landscape or portrait?
@randomer unfortunately locking the screen is a private API, can't be used in production apps: http://stackoverflow.com/questions/18388150/lock-screen-on-device-programmatically

Well, actually I meant locking the orientation, not the screen. Sorry for the confusion

@randomer - agreed, that would be nice

@clayallsopp The API looks like a good start. My concern would be the race condition due to the async nature of ReactNative.
For example, in between reading the initial device rotation and registering a change listener, the rotation may have been changed on the main thread so an event would be missed.

@joewalnes is this a thing we're worried about? It looks like AppStateIOS has exactly the same problem (it is initially undefined, and at some async point it gets its value from the native code)

the pattern I use is to treat these states as eventually consistent in my application code. implementing the JS portion of the module then involves three parts:

passing the initial value from Obj-C to JS when the module is first -[init]'d. this ensures that JS always has access to a state value (e.g. app state, device orientation, screen size) even if it is potentially stale.
subscribing to updates from Obj-C via the DeviceEventEmitter. this runs the first time the JS module is set up.
asynchronously fetching the latest value from Obj-C. this also runs the first time the JS module is set up.

the race condition is still there, but it usually isn't an issue as long as the JS app is guaranteed to catch up to the native state. when the race condition is an issue (e.g. you need to make some method calls that only make sense in certain states) then I write a bit of Obj-C that handles the native notifications synchronously.

@clayallsopp That said if you look into Stringwire app you will see that their streaming view is locked in landscape. However, I suspect they just rotated elements to look like it's landscape. (look at animation when you push/pop view from display)

:+1:

Related to #2031, @yamill's project https://github.com/yamill/react-native-orientation looks like a good place to look for this - API needs a bit of work but he is on that and you can submit a PR there if you are so inclined :smile_cat: