Send Contact Us Form Response to Admins

Issue that this pull request solves
Closes: #499
Proposed changes
Brief description of what is fixed or changed
Contact Us Model to store the response of the users is created and as soon as the user sends the response, an email is sent
to the admins following a template mentioned in utility folder.
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

Screenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request

@yadvi12 On what basis you are merging PR's?

May i know why have you reverted the commit? @jackfrost13

@yadvi12 On what basis you are merging PR's?

will check it again

May i know why have you reverted the commit? @jackfrost13

Hi, yes I am definitely answerable to you.
I believe the merge was done by @yadvi12 without proper feedback, hence I had to revert it,
Can you please raise a fresh PR for it?

Sure !
@jackfrost13


Build: failed to connect to some link, how to use manually downloaded file?

Hi, my server can't connect to https://github.com/ApolloAuto/apollo-contrib/releases/download/v3.0.0/plat-sw-<IP_ADDRESS>.zip when executing ./apollo.sh build_opt_gpu.
But I can manually download this zip file and upload it to the server.
How can I modify the script or where to put this zip file so that it will use the file I manually uploaded instead of downloading from the link?
Or are there any better solutions?
The command corresponding to this error is:
https://github.com/ApolloAuto/apollo/blob/a7f171f4e59c44afa5695a880279c66679d3d43a/apollo.sh#L147
The output is as follows:
System check passed. Build continue ...
[WARNING] ESD CAN library supplied by ESD Electronics does not exist. If you need ESD CAN, please refer to third_party/can_card_library/esd_can/README.md.
Running build under GPU mode. GPU is required to run the build.
[INFO] Start building, please wait ...
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
[INFO] Building on x86_64...
[INFO] Building with --jobs=80 --ram_utilization_factor 80 for x86_64
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
ERROR: (04-17 06:33:15.848) /apollo/modules/drivers/camera/BUILD:49:1: no such package '@adv_plat//': Error downloading [https://github.com/ApolloAuto/apollo-contrib/releases/download/v3.0.0/plat-sw-<IP_ADDRESS>.zip] to /home/user/cache/bazel/_bazel_user/540135163923dd7d5820f3ee4b306b32/external/adv_plat/plat-sw-<IP_ADDRESS>.zip: Connection refused (Connection refused) and referenced by '//modules/drivers/camera:camera'.
ERROR: (04-17 06:33:15.970) Analysis of target '//modules/drivers/camera:libcamera_component.so' failed; build aborted.
INFO: (04-17 06:33:15.970) Elapsed time: 15.525s
============================
[ERROR] Build failed!
[INFO] Took 16 seconds
============================

good question

You can try in file "apollo\WORKSPACE.in", and change
#adv_plat
new_http_archive(
    name = "adv_plat",
    build_file = "third_party/adv_plat.BUILD",
    sha256 = "0a58dadab924b520d5b5a58ef82fc0f76c2aa4feaaabd49ec9873228c125d513",
    url = "https://github.com/ApolloAuto/apollo-contrib/releases/download/v3.0.0/plat-sw-<IP_ADDRESS>.zip",
)

to
now
Put the download file in "/usr/local/apollo/adv_plat"
#adv_plat
new_local_repository(
    name = "adv_plat",
    build_file = "third_party/adv_plat.BUILD",
    path = "/usr/local/apollo/adv_plat",
)

@daohu527
Hi, thanks a lot!
But this raises another problem.
I run the following commands:
$ sudo mkdir -p  /usr/local/apollo/adv_plat
$ sudo mv plat-sw-<IP_ADDRESS>.zip  /usr/local/apollo/adv_plat
$ cd /usr/local/apollo/adv_plat
$ sudo unzip plat-sw-<IP_ADDRESS>.zip
Archive:  plat-sw-<IP_ADDRESS>.zip
   creating: bin/
  inflating: bin/adv_trigger
   creating: include/
  inflating: include/bcan.h
  inflating: include/adv_trigger.h
   creating: include/linux/
  inflating: include/linux/bcan_defs.h
  inflating: include/linux/zynq_api.h
   creating: lib/
  inflating: lib/libadv_trigger.so.<IP_ADDRESS>
  inflating: lib/libadv_trigger.a
  inflating: lib/libadv_bcan.a
    linking: lib/libadv_bcan.so.1    -> libadv_bcan.so.<IP_ADDRESS>
    linking: lib/libadv_trigger.so.1  -> libadv_trigger.so.<IP_ADDRESS>
  inflating: lib/libadv_bcan.so.<IP_ADDRESS>
finishing deferred symbolic links:
  lib/libadv_bcan.so.1   -> libadv_bcan.so.<IP_ADDRESS>
  lib/libadv_trigger.so.1 -> libadv_trigger.so.<IP_ADDRESS>

Then run build again
in_dev_docker$ ./apollo.sh build
System check passed. Build continue ...
[WARNING] ESD CAN library supplied by ESD Electronics does not exist. If you need ESD CAN, please refer to third_party/can_card_library/esd_can/README.md.
Running build under GPU mode. GPU is required to run the build.
[INFO] Start building, please wait ...
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
[INFO] Building on x86_64...
[INFO] Building with --jobs=80 --ram_utilization_factor 80 for x86_64
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: (04-18 14:24:54.337) Found 4479 targets...
ERROR: (04-18 14:24:54.686) missing input file '@adv_plat//:include/linux/zynq_api.h'.
ERROR: (04-18 14:24:54.699) /home/user/.cache/bazel/_bazel_user/540135163923dd7d5820f3ee4b306b32/external/adv_plat/BUILD.bazel:5:1: @adv_plat//:adv_plat: missing input file '@adv_plat//:include/linux/zynq_api.h'.
ERROR: (04-18 14:24:54.719) /home/user/.cache/bazel/_bazel_user/540135163923dd7d5820f3ee4b306b32/external/adv_plat/BUILD.bazel:5:1 1 input file(s) do not exist.
INFO: (04-18 14:24:54.720) Elapsed time: 4.303s, Critical Path: 0.11s
============================
[ERROR] Build failed!
[INFO] Took 6 seconds
============================

I thought that's because I didn't have read permission for some files (e.g. files in adv_plat/include/linux/), so I changed the permission:
$ sudo chmod -R +r /usr/local/apollo

But it still can't build. (Similar error, not always the same missing input file)
Did I do something wrong?
Have I provided enough information?

There is an option  "--distdir=/path/to/predownloaded/packages" for bazel commands.
Maybe you can have a try.

@siahuat0727

As @storypku metioned you can mofify the file
https://github.com/ApolloAuto/apollo/blob/a7f171f4e59c44afa5695a880279c66679d3d43a/apollo.sh#L147

to
 bazel build $JOB_ARG $DEFINES -c $@ $BUILD_TARGETS --distdir=/media/download

Be sure to check the sha256 of download package is equal in the "WORKSPACE.in"

sha256sum plat-sw-<IP_ADDRESS>.zip

https://github.com/ApolloAuto/apollo/blob/a7f171f4e59c44afa5695a880279c66679d3d43a/WORKSPACE.in#L248-L253

@storypku  @daohu527
Thanks! !
Now comes:
ERROR: Unrecognized option: --distdir=/media/download/bazel

The version of bazel installed in the docker is 1.0.1.
Is it the WORKSPACE.in should be revert to the original version?
And, where should I put the downloaded zip file?
Since I have no idea why distdir is set to /media/download/bazel, how can it find the downloaded file?

@daohu527
Sorry, the version looks like 0.5.3.
in_dev_docker:/apollo$ bazel version
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
Build label: 0.5.3
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Fri Jul 28 08:34:59 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

But if I try to installed with apt, the output is as follows:
in_dev_docker:/apollo$ sudo apt install  bazel --upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
bazel is already the newest version (1.0.1).
The following packages were automatically installed and are no longer required:
  libgail-common libgail18 libgtk2.0-0 libgtk2.0-bin libgtk2.0-common
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 144 not upgraded.

Here is a question about the problem, If the bazel version update will cause other problems, I will check the problem and provide a solution later

@daohu527
Hi, I got into a lot of trouble...
First, if I apt-key add follow step 1 here, I will get connection timed out.
Then, I try some apt update and apt install bazel --upgrade -f (Sorry for not being able to describe it accurately)
Now if I execute
in_dev_docker:/apollo$ sudo apt install bazel --upgrade
Building dependency tree
Reading state information... Done
bazel is already the newest version (3.0.0).
0 upgraded, 0 newly installed, 0 to remove and 5 not upgraded.

It shows that bazel is already the newest version 3.0.0.
But if execute
in_dev_docker:/apollo$ sudo apt upgrade bazel
Reading package lists... Done
Building dependency tree
Reading state information... Done
bazel is already the newest version (3.0.0).
Calculating upgrade... Done
The following packages have been kept back:
  libcudnn7 libcudnn7-dev libnccl-dev libnccl2
The following packages will be upgraded:
  tzdata
1 upgraded, 0 newly installed, 0 to remove and 4 not upgraded.
Need to get 190 kB of archives.
After this operation, 3072 B of additional disk space will be used.
Do you want to continue? [Y/n]
Get:1 http://us.archive.ubuntu.com/ubuntu bionic-updates/main amd64 tzdata all 2019c-0ubuntu0.18.04 [190 kB]
Fetched 190 kB in 2s (109 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 88906 files and directories currently installed.)
Preparing to unpack .../tzdata_2019c-0ubuntu0.18.04_all.deb ...
Unpacking tzdata (2019c-0ubuntu0.18.04) over (2018i-0ubuntu0.18.04) ...
dpkg: error processing archive /var/cache/apt/archives/tzdata_2019c-0ubuntu0.18.04_all.deb (--unpack):
 unable to make backup link of './usr/share/zoneinfo/UTC' before installing new version: Invalid cross-device link
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 76.)
debconf: falling back to frontend: Readline
Errors were encountered while processing:
 /var/cache/apt/archives/tzdata_2019c-0ubuntu0.18.04_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

I tried several solutions from some posts, likes
$ sudo apt autoremove
$ sudo apt clean
$ sudo dpkg -i --force-overwrite /var/.../..._all.deb
$ sudo dpkg --configure -a
$ sudo apt -o Dpkg::Options::="--force-overwrite" upgrade bazel

All failed.
The file /var/cache/apt/archives/tzdata_2019c-0ubuntu0.18.04_all.deb doesn't exist.
Then, I tried to build from source follows bazel doc
$ wget https://codeload.github.com/bazelbuild/bazel/zip/3.0.0
$ unzip "3.0.0"
$ cd bazel-3.0.0/
env EXTRA_BAZEL_ARGS="--host_javabase=@local_jdk//:jdk" bash ./compile.sh
🍃  Building Bazel from scratchfind: 'derived/jars': No such file or directory

ERROR: Must specify PROTOC if not bootstrapping from the distribution artifact

--------------------------------------------------------------------------------
NOTE: This failure is likely occuring if you are trying to bootstrap bazel from
a developer checkout. Those checkouts do not include the generated output of
the protoc compiler (as we prefer not to version generated files).

* To build a developer version of bazel, do

    bazel build //src:bazel

* To bootstrap your first bazel binary, please download a dist archive from our
  release page at https://github.com/bazelbuild/bazel/releases and run
  compile.sh on the unpacked archive.

The full install instructions to install a release version of bazel can be found
at https://docs.bazel.build/install-compile-source.html
For a rationale, why the bootstrap process is organized in this way, see
https://bazel.build/designs/2016/10/11/distribution-artifact.html
--------------------------------------------------------------------------------

How can I do now?
Sorry for the trouble...

@siahuat0727 I found anyother method, pls ignore the above method and follow this steps.

modify the WORKSPACE.in

new_http_archive(
    name = "adv_plat",
    build_file = "third_party/adv_plat.BUILD",
    sha256 = "0a58dadab924b520d5b5a58ef82fc0f76c2aa4feaaabd49ec9873228c125d513",
    url = "file:///home/tmp/plat-sw-<IP_ADDRESS>.zip",
)

download the file and put it in docker "/home/tmp"
Then run ./apollo.sh build

@daohu527
It works, thanks!
Indeed, after puttting it in docker /home/tmp, I have to run
in_dev_docker:/apollo$ exit
$ ./docker/scripts/dev_start.sh
$ ./docker/scripts/dev_into.sh
in_dev_docker:/apollo$ ./apollo.sh build

Just a reference to someone who got into the same situation later.
Again, thank you very much!

I'm glad the problem is solved, and I'll add some to the first method.
new_local_repository
The adv package is already install by "apollo\docker\build\installers\install_adv_plat.sh" when build the docker file, the path is "/usr/local/apollo/adv_plat". But the version is older.
So bazel repull the package through network and use the new version. here is a step to build offline.

modify the WORKSPACE.in

#adv_plat
new_local_repository(
    name = "adv_plat",
    build_file = "third_party/adv_plat.BUILD",
    path = "/usr/local/apollo/adv_plat",
)

download the file and unzip it in "/usr/local/apollo/adv_plat"(remove the older version),

sudo chmod 755 -R /usr/local/apollo/adv_plat

then use "./apollo.sh build"

new_http_archive

modify the WORKSPACE.in

new_http_archive(
    name = "adv_plat",
    build_file = "third_party/adv_plat.BUILD",
    sha256 = "0a58dadab924b520d5b5a58ef82fc0f76c2aa4feaaabd49ec9873228c125d513",
    url = "file:///home/tmp/plat-sw-<IP_ADDRESS>.zip",
)

download the file and put it in docker "/home/tmp"
Then run ./apollo.sh build


Error

Hi
I have the following error reading some GPX file. I guess one GPX could be corrupted but it could be good that the program is more robust and walk over:
Reading activity_Afternoon_spring_walk_on_19_04_2021_22MWC2ctUdab3XyRBzGowTNJtTM.gpx
Reading activity_Afternoon_walk_in_the_☀on_28_02_2021_22MR1PQbnlYKSLZy3ZatOHsNev7.gpx
Traceback (most recent call last):
File "C:\temp\GPX\strava_local_heatmap.py", line 349, in
main(args)
File "C:\temp\GPX\strava_local_heatmap.py", line 123, in main
for line in file:
File "C:\Users**\AppData\Local\Programs\Python\Python310\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 433: character maps to

with open(gpx_file, encoding='utf-8') as file: seems to solve it


Refactor import and use of argon2

Now follows the proper usage described in https://github.com/ranisalt/node-argon2#typescript-usage
Closes #30 .

Just tested this and it seems to work, but I'm still getting an error:
 ERROR  Vue app aliases are not allowed in server routes. [importing #app from<EMAIL_ADDRESS>

Just tested this and it seems to work, but I'm still getting an error:  ERROR Vue app aliases are not allowed in server routes. [importing #app from<EMAIL_ADDRESS>
I'm not well versed in the nuxt+vite magic, but this should do the trick

Thanks @Voltra for the quick help here! @JacobArrow, were you already able to confirm that it works now? Would love to push out this fix soon 💯

I just tested again and everything seems to work as expected
Thank you @Voltra !

Fix is merged, release is done, check out:

notes: https://github.com/sidebase/nuxt-session/releases/tag/0.2.5
fixed package<EMAIL_ADDRESS>
@JacobArrow please do write here / in the issue if the bug persists ❤
Thanks again for everybody involved, you're awesome 💯


types/models: Add user_application_membership to the User & Team

Change-type: minor
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


fix: remove duplicate tags in search when case is different

Fixes Issue
Closes #4676
To fix this issue I  converted all the tags to lowercase and passed it to the component.
Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Before

After

Note to reviewers

Hey @eddiejaoude what do you think about this solution?

Hey @amandamartin-dev can you take a look at it

Sorry for my slow reply, it is on my list to do soon

Hey Eddie I checked this and the search looks good, but I noticed on the map that it appears not to have the same code currently on production so I"m not sure if something is up or it's just an oddity of gitpod. The things i noticed were the map bounds and the clear filters code seems to be missing from this

hi @amandamartin-dev thank you for checking. It will be because the branch is not up to date. I will do an update

Hi @joeshajan! 😄 I made a suggestion on how to improve this line of code. Consider using <div> tags sporadically because they can make the code inaccessible.

Thanks 😊

Hello! You have a build failure in this file here due to changing only the opening tag to a different type:
"./pages/search.js 181:8 Error: Parsing error: Expected corresponding JSX closing tag for < article >. (181:8)"
If you need assistance on how to fix this please let us know!

Sorry, I didn't notice that. I have made the needed changes.

Due to lack of activity I will be closing this Pull Request.


Push To Master: Add parameter sweep results

320 files storing results across epochs for the sweep over hyperparameters

not much to review here @jaclyn-taroni - these are a series of small text files that store results of parameter sweep. They setup the visualization scripts I will include in the next PR.
I felt they were small enough to include in the repository


Updated CONTRIBUTING.md link in README.MD

The link was https://github.com/CodingTrain/website/blob/master/docs/CONTRIBUTING.md and it showed 404 page not found !
I updated it to the working one i.e https://github.com/CodingTrain/website/blob/master/CONTRIBUTING.md

Community Contribution
Link to live project, video, or image:

Sharing

[x] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

hey thanks for making a PR but it seems this has already been fixed.


Refactor or remove SiteStatistic identifier_stats

This method runs a query that takes a very long time and causes performance problems. This should be refactored in a way that makes it much faster - ideally finishing in seconds or a minute or two. Recently the query has taken up to 3 hours, when the entire rest of SiteStats queries needed for generate_stats_for_day finished in under 2 minutes. This method should have similar performance. If we can't achieve that, we may need to remove these stats from the daily stats so it doesn't cause daily performance problems

Stats calculation was paused in f1dda85, returning the previous days stats (as we have been doing recently to prevent the very long query), or returning 0 when there is no previous days stats. I'll close this ticket as this addresses the performance problem. But we need a long term-solution so we're not presenting out-of-date stats. We'll need to decide to continue to stop calculating these entire and have the UI handle when the "identifier" stats are missing, or invest some time into refactoring to get the same or similar kinds of statistics.
I can't think of a couple queries that will be able to generate these data efficiently, but I could see how it might be done by a bit of brute force - looping through all observations generated in the last week and assessing their IDs


TIM-300 Remove social icons on header

#44  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


Compilation error when implementing interface using object expressions and tuple argument

Surprising compilation error when trying to implement an interface using object expressions.
Repro Steps
type IInterface =
    abstract Function : (int32 * int32) -> unit

{ new IInterface with
    member this.Function (i, j) = ()
}

Expected
Compilation without errors like this:
type IInterface =
    abstract Function : int32 -> unit

{ new IInterface'with
    member this.Function (i) = ()
}

Actual
The compilation error is:

FS0768: The member 'Function' does not accept the correct number of arguments, 1 arguments are expected

Severity

Confusing for newcomers.
Cumbersome to remember.
But easy workaround.

Version

F# 4.0 (FSharp.Core, <IP_ADDRESS>)
F# Compiler version 14.0.23413.0
.NET Runtime, Framwork 4.6
Windows 10
Visual Studio Community 2015 version 14.0.2513.00 Update 2

Workaround
Surround the error producing parameter with additional brackets:
type IInterface =
    abstract Function : (int32 * int32) -> unit

{ new IInterface with
    member this.Function ((i, j)) = ()
}

I reproduced this with the current master.
I think what you want to do is:
type IInterface =
    abstract Function : int32 * int32 -> unit

{ new IInterface with
    member this.Function (i, j) = ()
}

Apaprently there is a difference between
    abstract Function : int32 * int32 -> unit

and
    abstract Function : (int32 * int32) -> unit

The latter one is making it a tuple.

@dsyme Am I right that this is actually by design?
If so then let's discuss if we could improve the error message instead.

it should be singular
it could hint the signature of Function
it could tell something about tuples vs. "C# style parameters"

@forki My thoughts exactly. If this becomes a fully fledged "improve error message" I'll add it to the (growing!) list.

Apaprently there is a difference between
abstract Function : int32 * int32 -> unit

and
abstract Function : (int32 * int32) -> unit

The latter one is making it a tuple.

Ah ok, I wasn't aware of that particular behavior. I added the brackets only in an attempt to increase readability. But still, I would expect the pattern matching of tuples to handle the situation without the additional brackets (@forki: maybe that's the design you mentioned?).
Of course, an improved error message would have helped. I think the error-message should also mention the reason why the additional brackets are necessary in the first place. So one might deduce the possibility to remove the brackets in the definition instead.
Nevertheless, personally I would appreciate if I had to make double brackets in the definition when it should become a tuple. This would also lead to a "symmetric" syntax at the declaration and at the implementation side, and would feel more explicit (at least for me).
type IInterface =
    abstract Function : ((int32 * int32)) -> unit

{ new IInterface with
    member this.Function ((i, j)) = ()
}

let f   (a, b)  = () // val f  : a:'a * b:'b -> unit
let f' ((a, b)) = () // val f' :   'a *   'b -> unit

let g   (a, b)  x = () // val g  : a:'a * b:'b -> x:'c -> unit
let g' ((a, b)) x = () // val g' :   'a *   'b -> x:'c -> unit

The latter part should be a UV request as a language change. Could you create a new issue though for the error message one as per the other ones that have recently been created with same format (what / why / how)?

Closing as this is by design (and error message improvement is tracked by a separate bug)


Update shapemaps to 0.1.74

Updates es.weso:shapemaps from 0.1.66 to 0.1.74.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "es.weso", artifactId = "shapemaps" } ]

labels: library-update, semver-patch

Superseded by #393.


Update "az sig gallery-application version" to include new parameter

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute


Stuc on firmware 2<IP_ADDRESS>

New miner, i could add it to my wallet and give it his location. Wont sync to blockchain and is stuc on firmware 2<IP_ADDRESS>. Block 1. See this kind of problems on discord.

This is not a support forum. Please contact<EMAIL_ADDRESS>

They dont reply

All support tickets are being replied but allow for a few days.


Unused local incorrectly reported

Version: 0.11.5
Example code
local hit_txt, dmg_txt
if hit then
 hit_txt = "You were hit"
 dmg_txt = "10"
else
 hit_txt = "The attack missed"
 dmg_txt = "0"
end

Expected behavior
Both hit_txt and dmg_txt should be recognized as used local variables.
Observed behavior
In some cases, some of the variables is not recognized as being used and is getting reported in diagnostics Unused local. In this particular example, dmg_txt is reported as unused. There are cases in which in a similar code, the first declared variable is reported as unused.

Unlike non-local variables, assigning values to local variables does not trigger any event or meta-method.
Therefore, local variables of only assignment operation are meaningless.

I guess I just didn't expect it to be that clever in this context.
Kudos for doing it the right way.
Thank you :)


Status Page to include Cert Expiry Date/days to Expiry and ability to be sorted based on Expiry Date/days to Expiry

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Have the ability to include the Cert Expiry date and/or Days to Cert Expiry on Status Pages with the option to sort the rows on the Status Page by Cert Expiry
✔ Solution
I would like to be able to determine which sites have upcoming expiring certs so having a status page that can be sorted to show which sites have certs that are expiring first would be very useful.
❓ Alternatives
No response
📝 Additional Context
No response

+1

+1


batch image detection test

    loader = Loader(roidb=roidb,
                    transform=transform,
                    data_name=data_name,
                    label_name=label_name,
                    batch_size=2,
                    shuffle=False,
                    num_worker=4,
                    num_collector=2,
                    worker_queue_depth=2,
                    collector_queue_depth=2,
                    kv=None)

I set batch_size 2 in detection_test.py of loader,  config is retina_r50v1_fpn_1x,  model can give true batch detection result  (r) .  but config is tridentnet_r50v1c4_c5_1x , get  following error.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/imdl/Desktop/pycharm-2019.1.1/helpers/pydev/pydevd.py", line 1741, in
main()
File "/home/imdl/Desktop/pycharm-2019.1.1/helpers/pydev/pydevd.py", line 1735, in main
globals = debugger.run(setup['file'], None, None, is_module)
File "/home/imdl/Desktop/pycharm-2019.1.1/helpers/pydev/pydevd.py", line 1135, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/home/imdl/Desktop/pycharm-2019.1.1/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/home/imdl/workspace/simpledet/detection_test_batch.py", line 120, in
mod.bind(data_shapes=loader.provide_data, for_training=False)
File "/home/imdl/workspace/simpledet/core/detection_module.py", line 446, in bind
state_names=self._state_names)
File "/usr/local/lib/python3.6/dist-packages/mxnet-1.5.0-py3.6.egg/mxnet/module/executor_group.py", line 280, in init
self.bind_exec(data_shapes, label_shapes, shared_group)
File "/usr/local/lib/python3.6/dist-packages/mxnet-1.5.0-py3.6.egg/mxnet/module/executor_group.py", line 376, in bind_exec
shared_group))
File "/usr/local/lib/python3.6/dist-packages/mxnet-1.5.0-py3.6.egg/mxnet/module/executor_group.py", line 670, in _bind_ith_exec
shared_buffer=shared_data_arrays, **input_shapes)
File "/usr/local/lib/python3.6/dist-packages/mxnet-1.5.0-py3.6.egg/mxnet/symbol/symbol.py", line 1629, in simple_bind
raise RuntimeError(error_msg)
RuntimeError: simple_bind error. Arguments:
data: (2, 3, 800, 800)
im_info: (2, 3)
im_id: (2,)
rec_id: (2,)
Error in operator decode_bbox: broadcast_mul0: [18:34:56] src/operator/tensor/./elemwise_binary_broadcast_op.h:68: Check failed: l == 1 || r == 1: operands could not be broadcast together with shapes [3,600,1] [6,300,1]

Because during training tridentnet creates to separate data providers for landscape and portrait images. During testing everything is taken from one iterator, since batch size = 1 it doesn't matter. You can't combine images with different dimensions inside one batch.
ps. batching images during inference usually doesn't improve performance.


I can't see images.

When my friends send me images, I get the error , and I can not see the images. Also, when I send images, I can only send in .jpg format, and some of them are not sent. Please, correct that error. Thank you.

whenever someone sends me an image it says "' if this continues I will consider deleting the app

same over here


add PPC course to the materials list

adding the link to the course, as well as to the actual exercises

Thanks for the link! :-)


Core docker container does not start properly

Expected behavior
All almighty-core  and almighty-core-deploy containers up and running.
Actual behavior
The core docker container is not started:
$ docker ps core
2c624017290c        almighty-core-deploy           "bin/alm"                48 seconds ago      CREATED       <IP_ADDRESS>:80->8080/tcp      core
275c70062c1f        almighty-core                  "/bin/bash"              2 minutes ago       Up 2 minutes                                  almighty-core-local-build

and after:
$ docker logs core

the following log is shown: http://pastebin.com/6BaLZRV9
Steps to reproduce the problem
# Run the DB docker image (detached) that the core requires
docker run --name db -d -p 5432 -e POSTGRESQL_ADMIN_PASSWORD=mysecretpassword centos/postgresql-95-centos7

make docker-rm
sleep 10
make docker-start
sleep 10
make docker-build
sleep 10
make docker-image-deploy
sleep 10

# Run the docker core image (detached)
docker run -p 80:8080 --name core -d -e ALMIGHTY_DEVELOPER_MODE_ENABLED=true -e ALMIGHTY_POSTGRES_HOST=$(docker inspect --format '{{ .NetworkSettings.IPAddress }}' db 2>/dev/null) almighty-core-deploy

Specifications

Which version of almighty-core are you running?
Which operating system do you use?

Already fixed by https://github.com/almighty/almighty-core/commit/e1ce117a9b970563f100cf202b673cc30f8a9858


Upgrade to LaxarJS v2

Upgrade control and infrastructure to LaxarJS v2

Implemented on master (v2.0.0).
BREAKING CHANGE
The laxar-layer-control (previously aka ax-layer-control) was upgraded to LaxarJS v2.
The control should now be installed using npm.


Do remove volume only on expunge

Description
This PR includes the changes to remove volume only on expunge.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Manually tested destroy and recover volumes.

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 566

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1292)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5213-t1292-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Merging this based on approvals and test results.


Support additional GitOps tooling (fleet)

Is your feature request related to a problem? Please describe.
Zarf should support more GitOps tools than just flux, fleet (https://fleet.rancher.io/) is another tool commonly used for this task that also has CRDs that should be modified by Zarf.
Describe the solution you'd like
Additions to the agent to support fleet CRDs
Describe alternatives you've considered
Manifests could be mutated beforehand but this can be cumbersome across updates/larger projects
Additional context
https://kubernetes.slack.com/archives/C03B6BJAUJ3/p1676395239817589

Why close this? And there were unmerged code commits related to this that are being thrown away?

The associated PR was closed two months ago (the PRs branch was not deleted however 1360-initial-fleet-support), and this effort has not seem much progress for almost a year.
The Zarf team is going through all current issues and closing all that are either stale or do not reflect project goals. Making Zarf more GitOps native is definitely a nice feature to have, but it is not a current top priority of the team.
If you, or others you know have the bandwidth to support adding this, feel free to reach out to the team on which parts of the codebase would need changes! With the upcoming donation to OpenSSF, this project is going to be more community owned and maintained.


Release v0.15.3

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

🚀
/approve


Add support for !infraction last

Closes #1803.
Adds !infraction last, which will view details of the last infraction the user made. Also changes the Infraction converter to use the expanded endpoint

Tested it simply, and works. Can we just get a comment that the Infraction converter special-cases last as getting the last infraction from the author?
I thought last was a subcommand at first and was confused.

Done :+1:

I've tested this, good stuff. Thanks Tizzy!


"Assertion failed" - The game won't start (Latest Steam Version)

Validation

[X] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)
Error:

Game Version:

I set the dinput8.log too be verbose, still didn't find an error in the logs. However it seems that version 1.0.6 should be 1.0.18384.1, while my version is 1.0.18384.2

Do you happen to have the censored German build of the game?

That's odd. I don't think there have been any updates.
Can you please zip your bio4.exe and upload it here so I can take a look?

Looks like you have the German version. You can confirm it by checking if The Mercenaries is missing from the extras:

I've recently fixed compatibility with the German .exe, but I haven't made a new release yet.
This development build should work fine, though:
dinput8.zip
Btw, where are you from? Did you buy the game from the Steam store? AFAIK this censored .exe was only distributed with German copies of the game. Hmm.


MainWindow.KeyDown doesn't register as many keys as KeyUp

System info
OS: Ubuntu 18.04 x64
DE: Cinnamon
Device: MacBook Pro Retina 2014
Hardware Keyboard Layout: Thai
Software Keyboard Layout: Canadian English
.NET Core 2.1.302
Avalonia 0.6.2-build5674-beta
Problem
The KeyDown event doesn't seem to fire for a lot of keys when typing in English (i.e. none of the letter keys work, some keys display "None" when using e.Key.ToString())
For KeyUp those things seem to work fine.
KeyDown code
this.KeyDown += MainWindow_KeyDown;
void MainWindow_KeyDown(object sender, KeyEventArgs e) {
    Debug.WriteLine(e.Key.ToString());
}

KeyDown output
<pressed a> (nothing)
<pressed s> (nothing)
<pressed d> (nothing)
<pressed f> (nothing)
<pressed Esc> Escape
<pressed Tab> None
<pressed Shift> None

KeyUp code
this.KeyUp += MainWindow_KeyUp;
void MainWindow_KeyUp(object sender, KeyEventArgs e) {
    Debug.WriteLine(e.Key.ToString());
}

KeyUp output
<pressed a> A
<pressed s> S
<pressed d> D
<pressed f> F
<pressed Esc> Escape
<pressed Tab> Tab
<pressed Shift> None

Cleaning up label a bit, we are not using GTK for input anymore (at least for input), and I believe this issue was fixed.


Support --export-area-page option like in Inkscape

--export-area-page                     Exported area is the entire page

I think this feature goes back to my suggestion over here: https://github.com/RazrFalcon/svgcleaner/issues/216#issuecomment-626681710
What's the status of this? Inkscape is only getting slower for me :wink:

Don't really have much free time lately. Will see what can be done on the weekends.

No pressure whatsoever, just curious. :bow:


Can i use my own nginx configuration within interlock

I have a swarm cluster , it consists of two nginx already which is doing all the stuffs . If i implement interlock is there any way that i can use the nginx configuration within the interlock container ?

Yes. You can turn it into a template that interlock can use. Here is an
example
https://github.com/ehazlett/interlock/blob/master/docs/examples/nginx/nginx.conf.template.example
On Oct 28, 2016 9:36 AM, "viveky4d4v"<EMAIL_ADDRESS>wrote:

I have a swarm cluster , it consists of two nginx already which is doing
all the stuffs . If i implement interlock is there any way that i can use
the nginx configuration within the interlock container ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ehazlett/interlock/issues/207, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP6InwWmnG7c_9vNRQCVW3ZxX97nEvaks5q4fpigaJpZM4Kjcjk
.


[BUG]: Emergency Response App, Supply Counts are not Submitted

Describe the bug
One out of 30+ users, Jamie Bogart, is having to submit updated supply numbers 4+ times in order for them to actually get updated in the back end.
To Reproduce
Steps to reproduce the behavior:

Open the '[Emergency Response - Supplies Reporting App](https://apps.powerapps.com/play/f9587a10-639d-4c3d-b376-6036fdde0080?tenantId=b50daf19-b943-4734-9bb2-292a55b4e912&source=portal&screenColor=rgba(0%2C%20176%2C%20240%2C%201))'
Select 'LHIN', 'Toronto Central', 'Toronto Central SDC', then hit 'Next'
Enter supply numbers for multiple items and hit 'Submit'
Go back home then re-do step 2
Error as per Jamie's view will be that these numbers entered previously have not been updated, they would appear as 0 to him (takes him 4+ tries to update these values)

Interface(please complete the following information):

Browser [e.g. chrome (V81), firefox (V68)]

Smartphone (please complete the following information):

Devices: [e.g. Toshiba Tecra Z40, Samsung (SM-T597W)]
Browsers [e.g. chrome (V81), firefox (V68); firefox (V61, on tablet)]

Are records not being created when you check the admin app for the Supply Tracking entity? Is this only happening for one user? If possible, can you provide some screenshots or a video showing the issue?


require a series on a bar chart in the UI

CATEGORY

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

Marks the series as required, allowing the UI to indicate requirements before making the request rather than after
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #8726 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8726      +/-   ##
==========================================
+ Coverage    65.4%   65.55%   +0.15%
==========================================
  Files         482      482
  Lines       24083    24083
  Branches     2763     2763
==========================================
+ Hits        15751    15788      +37
+ Misses       8152     8115      -37
  Partials      180      180

Impacted Files
Coverage Δ

superset/views/core.py
71.82% <0%> (+0.2%)
:arrow_up:

superset/models/core.py
83.21% <0%> (+0.57%)
:arrow_up:

superset/dataframe.py
94.48% <0%> (+1.57%)
:arrow_up:

superset/db_engine_specs/mysql.py
92.59% <0%> (+51.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871af05...c8296fa. Read the comment docs.

Thanks @john-bodley! Can I get a merge?


I’ll have you know I ( ͡° ͜ʖ ͡°) top of my class in the ( ͡° ͜ʖ ͡°) , and I’ve been involved in numerous secret raids on ( ͡° ͜ʖ ͡°), and I have over 300 confirmed ( ͡° ͜ʖ ͡°). I am trained in ( ͡° ͜ʖ ͡°) and I’m the top ( ͡° ͜ʖ ͡°) in the entire ( ͡° ͜ʖ ͡°). You are nothing to me but just another ( ͡° ͜ʖ ͡°). I will ( ͡° ͜ʖ ͡°) you the ( ͡° ͜ʖ ͡°) out with ( ͡° ͜ʖ ͡°) the likes of which has never been ( ͡° ͜ʖ ͡°) before on this ( ͡° ͜ʖ ͡°), mark my ( ͡° ͜ʖ ͡°) words. You think you can get away with saying that ( ͡° ͜ʖ ͡°) to me over the ( ͡° ͜ʖ ͡°)? Think again, ( ͡° ͜ʖ ͡°). As we ( ͡° ͜ʖ ͡°) I am contacting my secret network of ( ͡° ͜ʖ ͡°) across the ( ͡° ͜ʖ ͡°) and ( ͡° ͜ʖ ͡°) is being ( ͡° ͜ʖ ͡°) right now so you better prepare for the ( ͡° ͜ʖ ͡°), ( ͡° ͜ʖ ͡°) . The ( ͡° ͜ʖ ͡°) that wipes out the ( ͡° ͜ʖ ͡°) little thing you call your ( ͡° ͜ʖ ͡°) . You’re ( ͡° ͜ʖ ͡°), ( ͡° ͜ʖ ͡°), kiddo. ( ͡° ͜ʖ ͡°) can be ( ͡° ͜ʖ ͡°), and I can ( ͡° ͜ʖ ͡°) you in over seven hundred ( ͡° ͜ʖ ͡°), and that’s just with my bare ( ͡° ͜ʖ ͡°).


Videos are not working

Description

On some website, like Crunchyroll and UCSD podcast, the videos are not working when the extension is enabled.
Steps to Reproduce

go to crunchy or UCSD podcast on Firefox
try to play any of the videos on these platform.

Expected behavior:

The video to play.
Actual behavior:

On crunchyroll it just keeps loading forever.
ON UCSD podcast I gets the following message from the website: "we're sorry this content is only available in certain.domains"
Versions

Extension: 2022.3.30
Browser: Firefox
OS: Macc

I can't replicate the crunchyroll issue is this still happening? (we've had previous breakage on this site)
I can replicate on https://podcast.ucsd.edu/watch/sp22-b/anar156_a00 that there's a domain issue:

This appears to be referrer trimming causing the issue @GuiltyDolphin

It seems that the crunchyroll issue is not there anymore.


KAFKA-5697: prevent poll() from blocking forever

As the name says, currently KafkaConsumer#poll may block forever
despite having a timeout parameter, since that timeout only applies to
the ConsumerNetworkClient#poll and not the ConsumerCoordinator#poll.
This change applies the timeout to the entire poll operation, allowing us to
ensure threads won't hang forever in the event, e.g., that we can't talk to the
coordinator.
Several tests depended on being able to send a timeout of 0, but still
have the coordinator poll take non-zero time to do its work. I updated
them to send a long enough timeout for the coordinator to to the
required work.
I believe our testing suite should be sufficient to validate this change.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang I think this change is a good solution to the problem you reported in https://issues.apache.org/jira/browse/KAFKA-5697. WDYT?
Who else should review a change like this?

Thanks for the patch. I knew we should be pretty close to being able to do this by now after some of the recent work. Note, however, that ConsumerCoordinator.refreshCommittedOffsetsIfNeeded still blocks.
The main thing to be careful of is probably the case you mentioned where users have depended on poll(0) in order to ensure they have a valid assignment. I think this is the only thing that has kept me from finishing this. We could do a KIP to be on the safe side, but I'm on the fence whether it's actually needed. Maybe the question is whether we should give users an alternative API to await an assignment.

Hey @hachikuji, Thanks for taking a look!
I'll add a timeout to refreshCommittedOffsetsIfNeeded as well, and also look at the failing integration tests.
I was unaware that folks would use poll(0) to wait for an assignment without fetching. I was thinking it was just to "drain" the consumer of previously fetched records. Although, now that you mention it, that should have been obvious from the tests I changed.
In that light, I do think I should go ahead and do a KIP, since with this change there would be no way to wait for an assignment without polling. That will also be a good way to seek feedback on whether or not we need the drain-previously-fetched use case, since that will also no longer be possible. And of course, users may need to increase their timeout value since the metadata updates will now count against it.
If it's not too distracting to you, I'll keep this PR open to sketch out the new method and to update the tests and work though any failures while I write the KIP.

@vvcephei Yeah, that sounds good to me. I'm not sure how common that usage is--it's definitely convenient in testing--but it's probably a good idea to get some more visibility for the change to be on the safe side. Thanks for picking this up, by the way!

Just to record my current state on this...
I decided a good way to approach this was to lay the groundwork by introducing timeouts to every call in the poll path that can block, but not changing any semantics presented by the KafkaConsumer itself (by passing Long.MAX_VALUE to all the new internal timeout parameters).
I found in testing that altering the semantics of poll's timeouts was very disruptive to our unit and integration tests both, hence my taking the conservative approach for now.
Of course, the new timeouts are of no value unless they are exposed in some way, and that's what I'm going to work on tomorrow. Once I have poked around enough to have a decent proposal, then I'll write the promised KIP.

rebased

rebased to bring in the new scala streams tests (which failed last time).
fixed a race condition in ConsumerCoordinator

It's been a while since I've recorded status on this. I have a theory that poll can strike a balance between blocking and async by being fundamentally async and optionally blocking while it polls for async operations to complete.
Thus, if we need to refresh metadata, and let's say that metadata operation would take 3s and then we have some records to grab, and that would also take 3s, then all these scenarios would work as expected:
completely async:
poll(0) => [] // fires off the metadata update requests
sleep(1s)
poll(0) => [] // metadata updates are still pending
sleep(1s)
poll(0) => [] // metadata updates are complete. sends fetch request.
sleep(1s)
poll(0) => [] // fetch request is still pending
sleep(1s)
poll(0) => [] // fetch request is still pending
sleep(1s)
poll(0) => [record1, record2] // response was available

completely sync:
poll(5s) => [record1, record2] // sent metadata update request, waited 2s for response, sent fetch request, waited 3s for response

sync, but not long enough to complete the full operation:
poll(3s) => [] // sent metadata update request, waited 2s for response, sent fetch request, waited 1s for response
sleep(1s)
poll(3s) => [record1, record2] // waited 1s and got the fetch response.

In other words, we make poll completely async but leave in the option to block for responses, since that makes some use cases (especially tests and POCs simpler).
Even with some timeout bigger than 0 but less than infinity, it's ok to block as long as we can and then return an empty list if we didn't finish, whether the thing we didn't finish was a metadata update or a fetch request. This is ok because callers are supposed to poll poll, aka just keep calling it repeatedly until they get what they want or forever (whichever comes first).
I needed to validate that metadata updates can actually function in an async manner, so (after I added a timeout to the metadata update) I set the metadata update timeout to 0 and put it in a tight loop that would continue until it completed. This is equivalent to the current "block until metadata update completes", but it'll only work if async metadata updates is implemented correctly.

The tests passed on JDK7 and JDK10.
The failure on JDK8 looks like an unrelated failure out of Zookeeper:
org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists for /config/topics/topic
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:119)
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
	at kafka.zookeeper.AsyncResponse.maybeThrow(ZooKeeperClient.scala:472)
	at kafka.zk.KafkaZkClient.createRecursive(KafkaZkClient.scala:1424)
	at kafka.zk.KafkaZkClient.create$1(KafkaZkClient.scala:262)
	at kafka.zk.KafkaZkClient.setOrCreateEntityConfigs(KafkaZkClient.scala:269)
	at kafka.zk.AdminZkClient.createOrUpdateTopicPartitionAssignmentPathInZK(AdminZkClient.scala:99)
	at kafka.zk.AdminZkClient.createTopic(AdminZkClient.scala:56)
	at kafka.utils.TestUtils$.createTopic(TestUtils.scala:296)
	at kafka.integration.KafkaServerTestHarness.createTopic(KafkaServerTestHarness.scala:123)
	at kafka.api.BaseConsumerTest.setUp(BaseConsumerTest.scala:71)
	at sun.reflect.GeneratedMethodAccessor156.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
	at com.sun.proxy.$Proxy1.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:108)
	at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:146)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:128)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
	at java.lang.Thread.run(Thread.java:748)

Retest this, please.

Now that I've validated the approach, I've added the new methods I'm proposing and deprecating the old poll.

One remaining task before this is mergable is to update at least some tests to use either the new awaitAssignmentMetadata or the new poll, as appropriate.

@hachikuji @ConcurrencyPractitioner ,
I've updated this PR with the latest state from KIP-266, as a more concrete example of the proposal. WDYT?
Two things came up for me going through this...

The methods Jason proposed to include actually all already used the configs to set a timeout (request.timeout.ms). I was previously unaware of the use of this config in some of Consumer's methods. I'm still in favor of the current approach, but just to point out that a less dramatic change exists... to keep all the old method signatures and just make them respect request.timeout.ms .

I've learned that Duration lets you choose durations much greater than Long.MAX_VALUE (which is 25 days). If you try to get millis out of it, though, you get an exception. In contrast, TimeUnit.toMillis will just coerce larger values to Long.MAX_VALUE.  I flirted somewhat with using Duration "all the way down", and you can see some examples of that in KafkaConsumer, but I think it would become unwieldy. Instead, I think a good approach would be to check up front that the duration is "in bounds" and throw an IllegalArgumentException if not.

Alternatives: we could coerce to MAX_VALUE ourselves, or we could use a loop to actually wait for any duration specified.
Note that the tests for this PR won't pass until the CIT agents are updated to java 8 (but you should be able to build it yourself if desired).

Hi @vvcephei,
Thanks for setting up the basic methods in the interfaces, but you could just stick with implement poll.
I could take over the rest once you are done.

@vvcephei KAFKA-5697 has been fixed via GitHub Pull Request #4930, so I'm wondering if it is more for KIP-266 itself?

@vvcephei  I noticed that in KIP-266, we have several methods which does not seem to have a problem with blocking indefinitely, e.g. offsetsByTimes, beginningOffsets, endOffsets, so do we need to change those methods?

retest this please

@ConcurrencyPractitioner Sure thing; I'll pull the extra stuff back out. it wasn't as trivial as I thought it would be, evidenced by the fact that the tests broke, so I agree that poll alone is a big enough piece for one PR.

@tedyu Thanks for the reivew! The test failures were related. Something in the "extra methods" I popped in caused the test failures, but I'm about to take them back out, so we should be green again.

Ok, bringing this PR back to life. I've pulled out the "extra" methods I'd added. I expect the tests to pass.
Next up, I need to write a few tests for the deprecated method and migrate the rest of the code base and tests away from it.
@hachikuji should I just migrate the clients code base and leave the rest of kafka alone? Or migrate the whole project? I'm not sure what the norm with this project is.

@vvcephei thanks for the updated PR, please ping me and @hachikuji whenever it is ready to be reviewed. Please do the following to help reviewers better understand the PR diffs:

For the old API implementation, if we HAVE TO make any changes to it (personally I'd prefer to not make any changes to keep its scope small, but I'll leave it to you), state clearly in the description what are those and making sure they do not change any semantics of the old API.

For the new API implementation, describe its semantics that given a (possibly zero) timeout value, what will happen if a) it need to send metadata, b) it needs to (re-)join group, c) its metadata is fresh and group is stable, and there is inflight fetch request, d) its metadata is fresh and group is stable, and there is NO inflight fetch request.

Also it would help to add a few more bullet points on the actual changes in KafkaConsumer and AbstractCoordinator to help better understanding the diff details.

@hachikuji and @guozhangwang , this PR is ready for review.
@guozhangwang, I tried to address your requests in the PR description. Please let me know if my explanation is not adequate.

@ConcurrencyPractitioner I've finally finished this PR. WDYT?

Hi @vvcephei, it looks good to me. I don't really know if the changes to refreshCommittedOffsetsIdNeeded are practical as you stated, but other than that. I couldn't find any problems.

Allrighty, @hachikuji,
Thanks so much for the thorough review. I think I've addressed all your concerns.
Regarding the timeout-vs-deadline discussion. I've refactored all my timeout handling in terms of elapsed time and minimized the system calls. I think this is good enough for now. I would agree with switching over to deadlines in the future, but it feels too big to lump in with this work.
Thanks,
-John

Ok, @hachikuji , I think this PR is gtg now, supposing the tests pass.

Cherry-picked to 2.0 since it is an important bug fix to improve operational experience.


Improve network.export_shp function

Fix the network.export_shp function so that default shapefiles output by the networkx write_shp module are renamed to a user-defined file output name.

I decided to just change the output name to something slightly more descriptive (i.e. "network_lines" and "network_nodes") instead of multiple user-defined file names.
See commit:
https://github.com/SouthForkResearch/pyGNAT/commit/14f05b11e852fb71d37527e632bf86ca14f00120


fixing the link issue with the calculator and making the code more cleaner

Fixes

merging the if statements in bot.py line 109
fixing the issue where if you send a link which contains any "mathematical equations" the calculator opens
removing alot of unused imports

feels good to finally contribute, more fixes and code coming soon

I will fix this today

I approve

I approve

thank you ropra very cool 👍


Issues with running prolog2curry: missing modules?

I'm quite eager to try out the conversion of Prolog to a functional (logic) language. (My long-term goal is to attempt a transformation to an imperative language, or, at least, see how far I can get.) I found my way here after reading the associated paper.
After installing pakcs (and haskell), trying to run the prolog2curry module gives me the following errors:
Prelude> :load prolog2curry/src/Main.curry
Switching to directory "prolog2curry/src"...
Compiling Curry program "Main"...

Language/Prolog/Read.curry:18:8-18:27 Error:
    Interface for module Language.Prolog.Show not found
    |
 18 | import Language.Prolog.Show  ( showPlProg, showPlClause, showPlTerm )
    |        ^^^^^^^^^^^^^^^^^^^^

Language/Prolog/Read.curry:19:8-19:28 Error:
    Interface for module Language.Prolog.Types not found
    |
 19 | import Language.Prolog.Types
    |        ^^^^^^^^^^^^^^^^^^^^^
ERROR occurred during parsing!

(Disclaimer - I'm not sure whether this is the right way to run the module.)
I know these are found in the prolog module, but, when trying to add the relevant files from there, I get the following error:
Prelude> :add prolog/src/Language/Prolog/Types.curry
ERROR: Illegal module name: prolog/src/Language/Prolog/Types
ERROR: Source file of module "prolog/src/Language/Prolog/Types.curry" not found!

The contents of that folder under pakcs:
% ls prolog/src/Language/Prolog/
Goodies.curry	Show.curry	Types.curry

Using the following syntax (I believe this is suggested in the manual?)
Prelude> :add prolog
ERROR: Source file of module "prolog" not found!

I am clearly missing something :-)

Yes, you missed something :-)
Since this is a Curry package and has some dependencies, it cannot be loaded/compiled by just loading
the main file. If you have already installed PAKCS, you also find in the bin directory the executable cypm
of the Curry Package Manager (CPM).  If you never used cypm, the following way should work:
Initialize CPM's repository index by
> cypm update

If you already downloaded the source code of this package (otherwise you can also do it by
cypm checkout prolog2curry), go into its main directory prolog2curry and run
> cypm install

This downloads all dependencies, compiles the main program and generates the executable pl2curry in the
directory ~/.cpm/bin. If you add this into your path, you can run the translator by executing pl2curry with appropriate arguments (see pl2curry --help).
If you only want to load the source code of the translator (e.g., to modify and try it manually), you can also
install the package by
> cypm install --noexec

and start PAKCS by
> pakcs :load Main

Note that pakcs sets the CURRYPATH with all necessary directories, in particular, src, using cypm.
Therefore, you don't need to use :load src/Main (and it is also not recommended to do it).
I hope this helps!

that works, many thanks :-)


main.css not being injected in browsersync

[x] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[x] This is a bug report
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse forums

What is the current behavior?
BrowserSync does not inject main.css.
What is the expected or desired behavior?
BrowserSync should inject main.css or main.css should become enqueued instead of the dist build (main-[hash].css)

Bug report
I followed directions to install Sage 8.5.1 through composer.  I updated my development URL in the manifest and ran gulp, gulp --production and gulp watch.  (My IDE is set to automatically upload changes)
BrowserSync opens up (http://localhost:3000) and my local development URL is correctly proxied and I can see site loaded correctly with styles.  When I look in inspector I can see that the styles are given from the production css files, e.g. main-23hg4234gh.css which I will refer to as main-[hash].css.
When I make a change to my main.scss file, the changes are detected and a file main.css is generated in the dist folder.  However, the BrowserSync site does not use this file.  It only takes the file from the server that was created with gulp --production (main-[hash].css).
I gather that what is meant to happen is that BrowserSync injects the local main.css file that contains the changes but that is not happening for me.
Here is console output:
[19:13:16] Starting 'watch'...
[19:13:16] Finished 'watch' after 62 ms
[BS] Proxying: http://zanewoo.localdev
[BS] Access URLs:
 -------------------------------------
	   Local: http://localhost:3000
	External: http://<IP_ADDRESS>:3000
 -------------------------------------
		  UI: http://localhost:3002
 UI External: http://<IP_ADDRESS>:3002
 -------------------------------------
[BS] Watching files...
[19:14:49] Starting 'wiredep'...
[19:14:49] Finished 'wiredep' after 210 ms
[19:14:49] Starting 'styles'...
[BS] 1 file changed (main.css)
[19:14:53] Finished 'styles' after 3.74 s

It is generating the main.css file fine.  I can see my changes in there, it's just the browsersync site does not use main.css.  It uses main-[hash].css
Please describe your local environment:
WordPress version: 4.7.3
OS: Windows 10
NPM/Node version: X
NPM 4.5.0
Node 6.10.0
(I have also ran npm update -g)
Where did the bug happen? Development or remote servers?
Development
Is there a related Discourse thread or were any utilized (please link them)?
https://discourse.roots.io/t/browsersync-proxy-ineffective/9393

Other relevant information:
My development server is Ubuntu 16.04 running easy engine

This is a personal support request, not a bug.


Add support for Footer in Landscape mode

Changes: Add support for Footer section in Landscape mode.
Test: Run app locally and test survey in landscape mode with different screen sizes. See if we are able to view Footer section & also able to see opt out in Landscape mode. We can also check more if everything's working as expected.
Screenshots:

@ambarwootric tested this and it works as expected!
Test screenshots

Hope this is good for https://github.com/Wootric/WootricSDK-Android/issues/86
Let's wait to see if they can test this on their side and are ok with the fix. Also, let's wait until https://github.com/Wootric/WootricSDK-Android/pull/90 is ready to merge to release both PR in the same version.


Potential timing side channel

We detected a potential timing side channel. We received a counterexample that shows:

a CJAL instruction setting the PC to an address outside of the PCC bounds,
an instruction is then fetched from outside the bounds, and
due to the bound violation an exception and a pipeline flush is triggered.

This is normal, legal behavior in our understanding.
However, the timing of the exception depends on the bits [17:16] of the fetched data: if the bits are not equal "11", the exception is triggered earlier. The reason is that the core assumes the upper halfword holds a compressed instruction.
An attacker could potentially exploit this issue by measuring overall execution time or by reading a performance counter to probe if the two bits are equal to "11" for any word outside the PCC bounds. However, we did not write SW to exploit the vulnerability to confirm if the CHERIoT HW/SW model would allow exploitation in such a case.
We will check now if commit 876a46a solves the issue.
Best regards,
Anna and Johannes

According to our proofs, commit 876a46a solves the issue, thanks!

Great, thanks for confirming.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: kangoojim @.>
Sent: Monday, May 13, 2024 5:09:38 AM
To: microsoft/cheriot-ibex @.>
Cc: Subscribed @.***>
Subject: Re: [microsoft/cheriot-ibex] Potential timing side channel (Issue #38)
Closed #38https://github.com/microsoft/cheriot-ibex/issues/38 as completed.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/cheriot-ibex/issues/38 or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3V7IMCWIO7DCOMWLJP2EMTZCCUQFBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJVHEYDCMZWGU4DTAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMRYGUYTSNZYHEZ2O5DSNFTWOZLSUZRWY33TMVSA.
You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Hierarchy level access issue

Folders and SubFolder in real

How LibrePhoto can access, folder1 only

This issue is tracked here: https://github.com/LibrePhotos/librephotos/issues/136
It will still scan all the subfolders, but they are not shown yet, because of an inefficient implementation. I will close this ticket as it is a duplicate.


Combine AxisToAxis plugins

As per our Discord conversation, I suggest a kind of logical grouping for Axes. I propose a modifications to actual AxisToAxis plugin to be able to accept 1 to 3 input/output - linear, circular, spherical movements - so to avoid cluttering the select dropdown with three different plugins.
@Snoothy @evilC
It could be done implementing a dropdown control inside the plugin witch permits to choose between 1, 2 or 3 i/o, and an hook which reload the plugin with the current configuration.

I don't think it could be done like this without fairly major changes - how many inputs a plugin has is controlled by the source code of the plugin.
This is also potentially less efficient at run-time, as more checks need to be made etc.
Additionally, when moving from 1 to 2 to 3 axes, you may well want different DeadZone code etc (AxesToAxes has a circular dz).


Issue when using more than one loader

Hi @ellmetha
This issue is easily reproducible.
require "i18n"

I18n.config.loaders << I18n::Loader::YAML.new("#{__DIR__}/locales")
I18n.config.loaders << I18n::Loader::YAML.new("#{__DIR__}/new_locales")
I18n.config.default_locale = "en"

I18n.init

puts I18n.t("message")
puts I18n.t("new_message")

en:
  message: "Message"

en:
  new_message: "New Message"

Output:
missing translation: en.message
New Message

The problem is in this line: https://github.com/crystal-i18n/i18n/blob/732fbc9194752cfd26cc47ddbf395c760770dc31/src/i18n/config.cr#L138
The solution is to use deep_merge method from https://github.com/peterhoeg/deep-merge.cr or implement something similar inside this shard.
What do you think?

Hey, thanks a lot for reporting this! This should be fixed by 8d6f29eb49178d09e7dd64697ef7e8877435c57f (I ended up using a similar implementation inside the shard itself). 😉
Version 0.1.4 was released with the fix too.

Hey, thanks a lot for reporting this! This should be fixed by 8d6f29eb49178d09e7dd64697ef7e8877435c57f (I ended up using a similar implementation inside the shard itself). 😉
Version 0.1.4 was released with the fix too.

Thanks for the quick fix.
Btw, yesterday I ended up with this code with the same result:
def deep_merge_translations_hash(target, other_hash)
  target.merge!(other_hash) do |key, this_val, other_val|
    if this_val.is_a?(Hash) && other_val.is_a?(Hash)
      deep_merge_translations_hash(this_val, other_val)
    else
      other_val
    end
  end
end

Thanks for the quick fix.
Btw, yesterday I ended up with this code with the same result:
def deep_merge_translations_hash(target, other_hash)
  target.merge!(other_hash) do |key, this_val, other_val|
    if this_val.is_a?(Hash) && other_val.is_a?(Hash)
      deep_merge_translations_hash(this_val, other_val)
    else
      other_val
    end
  end
end


Tested and working with e-up! 60 kW (82 PS) model 2014

Great project. I have tested it with my  e-up! 60 kW (82 PS) model 2014 and it is working great.
I am using it with Homeassistant

great! Thanks for letting me know!


added notes

Added a note-taking app with local storage support.
In reference to issue #298

Thanks for contributing @srbmaury 👏


Discoverd improvements

This PR is pulling out some of the work @lmars has done to support updating discoverd so that PR can be more focused on the actual deployment/update process when it's opened.

LGTM


Naming conflicts in LogGroupNames using similar function names

The logic to get the LogGroupName is wrong. It searches for a function whose short name ends with the argument, not whose name equals the argument.
That means if you have two functions name lambdafunction and anotherlambdafunction, you can end up with resource conflicts because the LogGroupName for lambdafunction is used for both functions.

Actually a dupe of PR #2. Please merge one of them


vim8 dvorak

could you please incorporate a setting in the new version of vim so it makes more sense for us dvorakers to use it?
thanks!

On Wednesday, April 13, 2016 at 9:53:32 PM UTC-5, Tim Gregg wrote:

could you please incorporate a setting in the new version of vim so it makes more sense for us dvorakers to use it?

Well, there's a script to do some mappings for you. Previously it was in $VIMRUNTIME/macros/dvorak, it's been moved to a package for the next release.
But personally I don't use it and don't have any problems with Vim in Dvorak. I likewise don't use any language mappings for the same purpose: http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout
What's giving you trouble? Just muscle-memory from using Vim before learning Dvorak? Either of those solutions should help with that if you don't want to retrain on Vim. I had the advantage of learning Dvorak before I learned Vim.

Closing, as this seems more like a user question. Please ask user questions on the vim-use ml. thanks.


[ParticleEmitterConfig] Speed options ignored in conjunction with moveTo

Version
3.55.2
Description
Particle emission speed-related options, speedX, speedY and speed, are ignored when used in conjunction with moveToX or moveToY.
However, in terms of resulting visuals, reducing the lifespan of the particles increases visual speed although it slightly shifts the target.
Proposal
If 'moveTo' and 'speed' options are intended to not be used with one another, it should be communicated to the programmer that this is the case through types, docs, an error throw, or a runtime warning. Although I do believe that the use case of source, target and speed used together should be a common one, therefore warranting some sort of fix.
Example Test Code
The following configs can be used on the related example page: https://labs.phaser.io/edit.html?src=src/game objects/particle emitter/move to.js

ParticleEmitterConfig w/ speed:
    var emitter = particles.createEmitter({
        frame: { frames: [ 'red', 'green', 'blue' ], cycle: true, quantity: 2 },
        x: -400,
        y: -100,
        moveToX: 400,
        moveToY: 600,
        speed: 1000000, // <--
        lifespan: 1000,
        scale: 0.5,
        quantity: 4,
        _frequency: 20,
        blendMode: 'ADD',
        emitZone: { source: rect }
    });

ParticleEmitterConfig w/ target-vector-shifting reduced lifespan:
    var emitter = particles.createEmitter({
        frame: { frames: [ 'red', 'green', 'blue' ], cycle: true, quantity: 2 },
        x: -400,
        y: -100,
        moveToX: 400,
        moveToY: 600,
        lifespan: 500,
        scale: 0.5,
        quantity: 4,
        _frequency: 20,
        blendMode: 'ADD',
        emitZone: { source: rect }
    });

Velocity assignment code when moveTo coords specified:
https://github.com/photonstorm/phaser/blob/aa5f54cfa268c86823bf1dd52c83099fa0ef9ac2/src/gameobjects/particles/Particle.js#L346-L352

One way to do this is
particles.createEmitter({
  angle: (p) => Phaser.Math.RadToDeg(Phaser.Math.Angle.BetweenPoints(p, target)),
  speed: SPEED
});

One way to do this is
particles.createEmitter({
  angle: (p) => Phaser.Math.RadToDeg(Phaser.Math.Angle.BetweenPoints(p, target)),
  speed: SPEED
});

@samme How does this guarantee target vector apart from angle?

Guarantee how?

@samme The snippet you posted does not move emitted particles to a specific xy point. It requires lifespan to be calibrated in relation to speed so that the particles are destroyed on desired xy point.
In essence, conjunction of x, y, angle, speed and lifespan with proper callibration of speed and lifespan can emulate conjunction of x, y, moveTo and lifespan.

That could be done by adding a death zone or using
particles.createEmitter({
  moveToX: target.x,
  moveToY: target.y,
  lifespan: (p) => Phaser.Math.Distance.BetweenPoints(p, target) / SPEED
});

@samme Haven't tested if it produces desired effect but in the case that it does, the internal speed on following line,
https://github.com/photonstorm/phaser/blob/aa5f54cfa268c86823bf1dd52c83099fa0ef9ac2/src/gameobjects/particles/Particle.js#L346
will be in essence computed as:
 var speed = DistanceBetween(p, target) / ((DistanceBetween(p, target) / SPEED) / 1000);

If you want to avoid that then use
particles.createEmitter({
  angle: (p) => Phaser.Math.RadToDeg(Phaser.Math.Angle.BetweenPoints(p, target)),
  lifespan: (p) => (1000 * Phaser.Math.Distance.BetweenPoints(p, target)) / SPEED,
  speed: SPEED,
});

@samme I validated your latest reply (angle x lifespan x speed) and it seems to be working based on this demo: https://pastebin.com/UywaC3NH
The topic of this issue which is that speed is being ignored when used with moveTo & lifespan without notifying the developer or suggesting valid usage through code docs still stands though. In the case that this is implemented through a console warning, in order to block the message from production environments, an env var could be set and checked before printing the message, f.e:
diff --git a/src/gameobjects/particles/ParticleEmitter.js b/src/gameobjects/particles/ParticleEmitter.js
index c6bb7d9b3..7f58a9591 100644
--- a/src/gameobjects/particles/ParticleEmitter.js
+++ b/src/gameobjects/particles/ParticleEmitter.js
@@ -21,6 +21,10 @@ var StableSort = require('../../utils/array/StableSort');
 var Vector2 = require('../../math/Vector2');
 var Wrap = require('../../math/Wrap');

+function warn(message) {
+    process.env.NODE_ENV === 'dev' && console.warn(message)
+}
+
 /**
  * @classdesc
  * A particle emitter represents a single particle stream.
@@ -312,6 +316,8 @@ var ParticleEmitter = new Class({
          */
         this.moveTo = false;

+        (config.moveToX || config.moveToY) && config.lifespan && (config.speed || config.speedX || config.speedY) && warn('ignoring speed in favor of lifespan since moveTo provided')
+
         /**
          * The x-coordinate emitted particles move toward, when {@link Phaser.GameObjects.Particles.ParticleEmitter#moveTo} is true.
          *

I updated the docs (#6073).
I guess a warning is possible. The thing is it's not completely wrong to set both moveToX and speed etc. because you can toggle moveTo on or off after the emitter is created if you want.

@samme Conditions for warning can be checked when particle emission occurs (in Particle#fire) since speed and moveTo state does not change across lifecycle of particle, they only get evaluated when the particle fires.

I think fromJSON() would be the best place for a warning.

So basically on particle emitter initialization too apart from fromJSON() since it's being called there. The problem you described above still stands if done so:

The thing is it's not completely wrong to set both moveToX and speed etc. because you can toggle moveTo on or off after the emitter is created if you want.

It's probably better to check for the warning whenever a dependent property is assigned, so apart from the json method, which is the only place that moveTo props are assigned, setSpeed, setSpeedX and setSpeedY should also have the check & message.

Well, Rich can decide. I think the docs change should be enough.

I agree, docs change is enough, although I've also added the information to the config docs, as I think it's more likely to be spotted there.


Style guide updates

In progress: updating styling across the site to adhere to the style guide and match the hugo site's styling. Besides straightforward updates, I removed some outdated code and removed three of the callout styles that were currently unused, as the style guide prefers the three in use going forward. We haven't done a visual QA on our end yet, so there will be more changes coming.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8377c22d95099262de463d0e1df0f83d7563dd8e/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f0701b85ebb0c965786bcfff88cfd6b3db711968/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4260115d5e33d951cb9c06e66a1a18c55acba2e0/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/68b7511d24eec06c79dc33c8899f89a2eba9916d/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/231618cb91848819d8ddc9a2bdf816fa625ab7a1/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/22ecafb681aa0c73adf04f7cb51f47342d48ee0b/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/520feb571d471838327c0f5380bbbaf7d422ea43/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3d2b55e8744f636adfcb80590004908a0d68d731/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d38954827fcfbfc4c873c218dbc4aca17591fb08/

@jseldess, I'm planning on merging the hugo style guide updates after you merge here. There's a dev project on the hugo repo that requires getting those changes integrated before I can start, so I was hoping we could get this merged by the end of the day.

@deronjohnson, the last commit doesn't seem to have actually change the toc bullet size. Did you mean to revert to 14px? Let me know what you intended and then I'll merge.

This was a change Andy asked me to make until we make a final decision on table of content type sizing, which was changing the size of the bullet itself. I had originally thought you wanted to reduce the size of the bullet, not the type, and Andy thought it should stay consistent. Removing the 14px rule makes the bullet the same size as the font (17px).

I see. OK. I'll just merge now. In my opinion, the type size and spacing is too large/spacious in comparison to the sidenav. But I don't want to block this.


remove specific version from coreos-overlay repo

that link will probably break with every release, why not just keep the link to the files and skip the specifics.

@PI-Victor Thanks for the contribution!
 Other than that LGTM

@tmrts done, my bad, sorry :)

@PI-Victor no problem at all :smile:


Remove netpol e2e test generator

How to categorize this PR?

/area testing
/kind cleanup
What this PR does / why we need it:
This PR removes the netpol e2e tests for the following reasons:

Repetition in the extensions (example configured CP components)
Double maintenance in gardener/gardener (example labels)
Used code generation for this test is intricate, no documentation exists, only maintainable with increased effort
Tests are designed in a provider-dependend way although most of the netpols (in many cases all netpols) come from Gardener and aren't modified by extensions.
Tests have been having issues and have been skipped for a longer period of time (see #4581 for more reasons and linked issues)

Which issue(s) this PR fixes:
Fixes #4581
Special notes for your reviewer:
Today, we already unit test netpolds in gardener/gardener and also added a lot of unit tests for involved components, i.e. we make sure they get necessary labels.
In the future, we are still open to add netpol integration tests to Gardener in a more readable and maintainable fashion. Imho, there is too much technical debt to continue with the current test implementation. I think about recycling some of the generated e2e test (example) and add them to gardener/gardener in the near future.
Release note:

The e2e test network policy generator has been removed from `gardener/gardener` because it has been out of maintenance for a longer period of time. Please remove any references to `github.com/gardener/gardener/extensions/test/e2e/framework/networkpolicies/generators`.

> Generate / Vendor Check
>> make generate
>> make revendor
make revendor needs to be run:
 M go.mod
make: *** [Makefile:193: check-generate] Error 1

/merge squash


Take a bunch of commits into the release branch

Codecov Report

Merging #9238 into release-2019.12 will decrease coverage by 0.09%.
The diff coverage is 30.17%.

@@                Coverage Diff                 @@
##           release-2019.12    #9238     +/-   ##
==================================================
- Coverage            56.82%   56.72%   -0.1%
==================================================
  Files                  551      551
  Lines                28947    29012     +65
  Branches              4450     4466     +16
==================================================
+ Hits                 16448    16458     +10
- Misses               11556    11607     +51
- Partials               943      947      +4

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.48% <ø> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterNotebook.ts
5.04% <0%> (-0.02%)
:arrow_down:

...ractive-window/interactiveWindowCommandListener.ts
56.88% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
99.68% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
94.73% <100%> (+0.04%)
:arrow_up:

src/client/datascience/jupyter/jupyterExecution.ts
48.31% <30.55%> (-3.66%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
69.38% <40%> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterSession.ts
66.33% <42.85%> (-1.18%)
:arrow_down:

.../datascience/interactive-common/interactiveBase.ts
17.7% <5.71%> (-0.49%)
:arrow_down:

src/client/datascience/datascience.ts
24.61% <60%> (-0.08%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab0e26...c33e872. Read the comment docs.


Bug: Error in your GraphQL query due to example page query

I get the following error:
There was an error in your GraphQL query:
Error: RelayParser: Encountered duplicate defintitions for one or more documents: each document must have a unique name. Duplicated documents:

SiteTitleQuery

the mentioned query is used duplicated in the gatsby v1 example and gatsby v2 example in the layouts/index.js
/node_modules/gatsby-plugin-mailchimp/examples/gatsby-v1/src/layouts/index.js
during yarn dev and build

https://stackoverflow.com/questions/55381810/why-is-it-not-possible-to-have-the-same-name-of-two-staticquery-elements-on-two/55394443
using the useStaticQuery hook or ommiting the name of the query should fix this problem

are you still on gatsby v1?   is it possible to upgrade to gatsby v2?  if so, then you can use the v2 version of this plugin.
if not, then you (or me) needs to open a PR and merge the equivalent to this PR but for the gatsby-v1 branch: https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/pull/40
i can do it this weekend if you're unavailable

no i am at v2 but it was related to this issue here
https://github.com/gatsbyjs/gatsby/issues/15344
so i fixed it by updating your plugin. thanks for the help though. have a nice weekend!

fixed by updating to "gatsby-plugin-mailchimp": "^5.1.2"