Cycles in object graph lead to wrong mapping based on entry point

Hi there,
thank you for building modelmapper: it's a great library!
If have found out that cycles are not always correctly detected and this can lead to incorrect mappings (beside creating unnecessary instances). Consider the following structure where:

A chessboard contains a list of nodes and a node has a reference to the board it belongs to.
A node has a list of pieces (e.g. like in checkers)
A player has a favourite piece and a favourite node of the chessboard.

Now let's say we have two identical class structures: one representing the persistence layer and one for domain objects (Apologies for the long snippet).

// domain entities
@Getter
@Setter
@NoArgsConstructor
public class ChessBoard {
    private List<BoardNode> nodes;
}

@Getter
@Setter
@NoArgsConstructor
public class BoardNode {
    private List<ChessPiece> pieces;
    private ChessBoard board;
    private int x;
    private int y;
}

@Getter
@Setter
@NoArgsConstructor
public class ChessPiece {
    private String id;
    private BoardNode node;
}

@Getter
@Setter
@NoArgsConstructor
public class Player {
    private BoardNode favoriteTile;
    private ChessPiece favoritePiece;
}

// DB equivalent
@Getter
@Setter
@NoArgsConstructor
public class DBChessBoard {
    private List<DBBoardNode> nodes;
}

@Getter
@Setter
@NoArgsConstructor
public class DBBoardNode {
    private List<DBChessPiece> pieces;
    private DBChessBoard board;
    private int x;
    private int y;
}

@Getter
@Setter
@NoArgsConstructor
public class DBChessPiece {
    private String id;
    private DBBoardNode node;
}

@Getter
@Setter
@NoArgsConstructor
public class DBPlayer {
    private DBBoardNode favoriteTile;
    private DBChessPiece favoritePiece;
}

Finally here is a test that creates some DB entities and maps them to domain ones:
    @Test
    public void test() {
        ModelMapper mapper = new ModelMapper();

        DBBoardNode dbNode1 = new DBBoardNode();
        dbNode1.setX(0);
        dbNode1.setY(0);

        DBBoardNode dbNode2 = new DBBoardNode();
        dbNode2.setX(1);
        dbNode2.setY(1);

        DBChessPiece dbChessPiece = new DBChessPiece();
        dbChessPiece.setId(UUID.randomUUID().toString());
        dbChessPiece.setNode(dbNode1);
        dbNode1.setPieces(Arrays.asList(dbChessPiece));

        DBChessBoard dbChessBoard = new DBChessBoard();
        dbChessBoard.setNodes(Arrays.asList(dbNode1, dbNode2));
        dbNode1.setBoard(dbChessBoard);
        dbNode2.setBoard(dbChessBoard);

        DBPlayer dbPlayer = new DBPlayer();
        dbPlayer.setFavoritePiece(dbChessPiece);
        dbPlayer.setFavoriteTile(dbNode2);

        ChessBoard chessBoard = mapper.map(dbChessBoard, ChessBoard.class);
        Player player = mapper.map(dbPlayer, Player.class);
        System.out.println();
    }

If you debug this and get to the last line, you will notice that:

chessBoard is correctly mapped and instances are created exactly once.
player is not mapped correctly. Multiple instances of ChessBoard are created, even though there is one instance of DBChessBoard. More importantly, the path player.favoritePiece.node.board.nodes is incorrectly mapped as nodes contains node [1, 1] twice, whilst node [0, 0] has disappeared.
If dbPlayer.setFavoriteTile is commented out (favoriteTile is null), the behaviour is even more bizarre: player.favoritePiece.node.board.nodes is almost correct (values are but multiple instances of ChessBoard are created), however, player.favoriteTile is not null!

Please let me know if there's anything I can do to help as this bug is putting a big a chunk of my business logic at risk and I don't want to replace modelmapper.

@jhalterman  @chhsiao90 I'm happy to take on this myself and contribute a fix, however, I'd need any of you to give me a primer on how you approached circular dependencies management. I could only find a test here org.modelmapper.bugs.CircularMappingBug, but it seems to only consider the simplest case.
Happy to jump on a call if of you is available.
Thanks

Unfortunately I had to give up on this and ultimately switch to MapStruct, however this could be solved fairly quickly if it was possible to inject a behaviour similar to the one described here https://github.com/mapstruct/mapstruct-examples/tree/master/mapstruct-mapping-with-cycles/src/main/java/org/mapstruct/example/mapper
Best

ModelMapper 2.4.0 released.


Handle Packet::None, update deps & optimize

Handle Packet::None
Update Flatbuffers to use the new version on crates.io (finally works)
Update glam
Avoid excessive allocations in RLBotConnection
Minor clippy stuff

Thanks!


feat: Make T3 edge ready

Is your feature request related to a problem? Please describe.
I think it would be a great addition to the T3 stack if he gets edge ready.
Describe the solution you'd like to see
Dont rly know. Maybe switch the ORM.
Describe alternate solutions

Additional information
No response

Maybe Drizzle (after the last video)

I think it would be a good thing to give an ORM select option where you could use either prisma or drizzle instead of fully switching.

The T3-Stack team has expressed a preference for avoiding the use of "bleeding edge" technologies. Consequently, while Drizzle represents an interesting potential upgrade, they advise waiting until it matures and reaches its first release (v1) before considering a switch. During this interim period, a viable solution might be to create a community-maintained package or branch dedicated to implementing all the latest features. This approach could allow us to explore and take advantage of emerging technologies on smaller projects, while maintaining stability and reliability in our primary branch.

The T3-Stack team has expressed a preference for avoiding the use of "bleeding edge" technologies. Consequently, while Drizzle represents an interesting potential upgrade, they advise waiting until it matures and reaches its first release (v1) before considering a switch. During this interim period, a viable solution might be to create a community-maintained package or branch dedicated to implementing all the latest features. This approach could allow us to take advantage of newer technologies on smaller projects, while maintaining stability and reliability in the primary branch.

Understandable, I was mainly in the boat of including the choice between prisma and ie drizzle when it's ready 👍

We're a bit blocked by https://github.com/nextauthjs/next-auth/pull/7443 but other than that #1461 & #1446 should address this

Awesome! Glad to hear. Haven't gotten around to use drizzle a whole lot myself yet but from what I've experienced in some smaller projects I got bothe the setup and perf is so much better than prisma.

I've mostly been using Kysely lately but there I do something like this:

genId is an alias to nanoid in this project but you can do cuid, uuid, ulid or whatever you want really

I've mostly been using Kysely lately but there I do something like this:

genId is an alias to nanoid in this project but you can do cuid, uuid, ulid or whatever you want really

Haven't used kysely yet. It's similar to drizzle right? (In the sense of it being a edge-ready prisma alternative)
And if so. In case it uses some form of a schema, what does this look like in this case when using a uuid as the primary key?

Just use a varchar with the size you need. For uuid this should be 36B

Just use a varchar with the size you need. For uuid this should be 36B.
If your db support uuid natively use that

Gotcha, mainly been using the cuid binding in prisma in previous project but couldn't find a similar binding for the drizzle schema.

Gotcha, mainly been using the cuid binding in prisma in previous project but couldn't find a similar binding for the drizzle schema.

Then you've used a VARCHAR(191) which is quite a bit larger than you need:

Gotcha, mainly been using the cuid binding in prisma in previous project but couldn't find a similar binding for the drizzle schema.

Then you've used a VARCHAR(191) which is quite a bit larger than you need:

Gotcha🤙

We're a bit blocked by nextauthjs/next-auth#7443 but other than that #1461 & #1446 should address this

Is this really completed when nextauthjs/next-auth#7443 is still open?
Incidentally, I recently tried:

@auth/core
next-auth@experimental
@auth/drizzle-adapter
@planetscale/database

with create-next-app and it worked on the Vercel edge runtime no problem.

https://github.com/nextauthjs/next-auth/pull/7443 just merged. Should drop as v5.0.0-beta.0 soon.
However, I agree. I think this issue should still be open until it is stable and t3 includes a dependency bump.

Since the T3 pages router is not using the fetch API and is for this reason not edge runtime ready I think this issue should stay open until this is also solved.
If you want I can also work on this.

Edge is no longer recommended by vercel

We'll still get it edge ready if you wanna deploy to workers or whatever other reason you have.
Just straight up listening and following everything Vercel says isnt the goal of this project so we definetely still want to make it edge ready.
But it do that we need next-auth v5 stable


RangeError: Maximum call stack size exceeded when using recursive schema's

When generating our postman collection for our open api spec we get an exception.
Our schema's do have some recursive calls, for example:

This is a part of our open api spec file
 "menuEntryGroups": {
                      "items": {
                        "oneOf": [
                          {
                            "title": "menuGroupEntry",
                            "properties": {
                              "name": {
                                "example": "drinks",
                                "type": "string"
                              },
                              "color": {
                                "example": "blue",
                                "type": "string"
                              },
                              "menuEntry": {
                                "$ref": "#/components/schemas/menuEntry"
                              },
                              "type": {
                                "enum": ["group", "menuItem", "menuDeal"],
                                "example": "group",
                                "type": "string"
                              }
                            },
                            "type": "object"
                          }

Is this a bug or could I fix this by adding some extra options?

error:  RangeError: Maximum call stack size exceeded
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:39:16)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
    at crawl (/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apidevtools/json-schema-ref-parser/lib/bundle.js:77:11)
/Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apideck/portman/dist/Portman.js:217
                                throw new Error("Parsing " + openApiSpec + " failed.");
                                      ^

Error: Parsing ./tmp/converted/spec.yml failed.
    at /Users/liesbeth.de.keyzer/Documents/workspace/api-platform/node_modules/@apideck/portman/dist/Portman.js:217:39
error Command failed with exit code 1.

@ls-liesbeth-dekeyzer Thanks for sharing your issue.
Is the OpenAPI file publicly available? That way we can try to reproduce it.

Its not yet publicly available. I added here (I couldnt add it as a openapi.json file)
openapi.txt

Thanks for sharing @ls-liesbeth-dekeyzer  - will try to repro and see if we can get this sorted

Hi @ls-liesbeth-dekeyzer - might have a fix, but is it possible that the postman collection hosted here: https://developers.lightspeedhq.com/ecom/introduction/postman/ is from a different spec?
Just comparing our current output from Portman...

Ah sorry have just seen: "Lightspeed Restaurant K Series API" vs "Lightspeed eCom V2" in the collections

Yeah ecom is a different product inside lightspeed. So not the same api spec

Hey @ls-liesbeth-dekeyzer, just to inform you there is an impending release that will allow you to ignoreCircularRefs.
Ideally the spec should not contain any circular references, but this will at least maintain the rest of Portman's value.
Do note that this means for requests with a response schema containing circular refs, schema validation will not be included in your test suite.
Let you know when the release is published, but would guess within the next couple hours.

v1.12.0 has been released. Please give it a spin and let us know if this suits your case.
Your options are described here: https://github.com/apideck-libraries/portman/blob/main/docs/ERRORS.md.
I'll closed this issue for now, but please reopen or create a new one if needed.


Please add the detailed setting method of autotuning to this public information.

Please add the detailed setting method of autotuning to this public information.
Even if the user does not contact the support desk, you can set it just by reading this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ef45327-7cdf-fc60-2a04-b785bc12f4cf
Version Independent ID: b4f8c915-9651-14df-92d7-fa1387780a41
Content: Enable automatic tuning for Azure SQL Database
Content Source: articles/sql-database/sql-database-automatic-tuning-enable.md
Service: sql-database
GitHub Login: @danimir
Microsoft Alias: danil

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


[FEATURE REQUEST] - Remove Firestore caching by default

Is your feature request related to a problem? Please describe.
Firestore caching has caused us a ton of problems, from occasionally sending people into offline mode when they shouldn't be, to just causing weird errors. We'd like to get rid of it.
Describe the solution you'd like
It should be easy enough to remove, or at the least just turn off by setting the flag for it to false by default instead of true.
Describe alternatives you've considered
Users could do this manually, but if it's so buggy, they should not have to.
Additional context

I Agree with this. I also had multiple issues with it and forgot that it existed and was on by default at first which caused me about a week of headaches trying to troubleshoot.


(PUP-6850) Exclude commits unrelated to a PR

TRAVIS_COMMIT_RANGE uses triple dots, which includes commits that are in
the base branch that are not in the PR. For example, if a commit is
pushed to master with an incorrect summary, then every PR created before
that commit will include the unrelated commit, causing the PR to fail
the summary check.
As suggested in https://github.com/travis-ci/travis-ci/issues/4596#issuecomment-139811122,
replace triple dots with double dots.

@puppetlabs/puppet-maintainers for review

CLA signed by all contributors.

Good point @Iristyle. I pulled that change in:
$ env TRAVIS_COMMIT_RANGE=upstream/LTS-1.7...HEAD bundle exec rake commits
Checking commits upstream/LTS-1.7..HEAD
(PUP-6850) Exclude commits unrelated to a PR
...passed
(maint) Fix rake task that checks commits
...passed

/cc @puppetlabs/puppet-maintainers

@MikaelSmith there's a travis-ci issue about the triple dots https://github.com/travis-ci/travis-ci/issues/4596#issuecomment-139811122. The behavior doesn't match the documentation, not sure why.
It's only been a problem now, because a commit was pushed directly to puppet with a broken subject, and for example, PR https://github.com/puppetlabs/puppet/pull/5415, was based off of stable, but the merge was targeted against master. So the triple-dot causes the commit check to run against all of the commits in the PR and master since their common ancestor 89b724dad18cb2cfd62be462f3b4ccb98d21d258.

TravisCI now says Checking commits 49cf1fdfc4f9f9128c6bfc48f8286fb66ec1914d..c6a75fc1419fc2ff4a4a85233ea2018bc3dab8b0
👍

Merged up to stable in https://github.com/puppetlabs/puppet/commit/ffabfc3d3019b1a4653c3015182a8996c8a86cde
Merged up to master in https://github.com/puppetlabs/puppet/commit/9dda0a424b5067cabdfd70f72b286fa7f29f604a


README.md: use brew instead of brew cask for handbrakecli

This should not be merged yet, but I’m submitting now in case you want to take a look or prepare something that needs preparing.
We’re moving HandbrakeCLI from homebrew-cask to homebrew. See PR removing from HBC and PR adding to HB.
Still not certain on the name, it could be handbrakecli (I’ll update the PR if that’s the case).
You seem to have dependencies in alphabetical order, but since HandbrakeCLI is the most important one, it makes sense to have it at the top. If you want it any other way just let me know and I’ll change it. Or feel free to edit it yourself if you want, I’ve left “Allow edits from maintainers” checked.
Happy holidays!

LOL - was just preparing a similar PR when I noticed the discussion about this move. This just went live a on Homebrew core a few minutes ago, and it can be done via brew install handbrake.

@vitorgalvao @timsutton Thanks for the patch! I may take this or make a similar change soon, even before my next update/bug fix, but I'll likely wait until after Christmas. It's a little busy around here today. :)

@donmelton As @timsutton mentioned, this is already live, so as of now brew cask install handbrakecli will not work, but brew install handbrake will. This does not break existing installs, so there is absolutely no rush. Everything will keep working just fine.
The name was kept as in this PR, so it can be merged as is.
Happy holidays to you both!

@vitorgalvao OK, it's merged and thanks again for the patch!
BTW, I tweaked your wording after the merge but not by much.


[Backport 2.x] Moving concurrent-search out of sandbox plugin to core behind feature…

… flag (#7203)
Signed-off-by: Sorabh Hamirwasia<EMAIL_ADDRESS>(cherry picked from commit fde8fa47a14b4dbb17a670604ab0ff357eeb5b95)

Description

Backports #7203 to 2.x
Fixes changelog diff b/w main and 2.x

Related Issues
N/A

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #7408 (5e7f5f6) into 2.x (175ea44) will increase coverage by 0.13%.
The diff coverage is 52.94%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #7408      +/-   ##
============================================
+ Coverage     70.28%   70.41%   +0.13%
- Complexity    59750    59817      +67
============================================
  Files          4864     4863       -1
  Lines        287384   287391       +7
  Branches      41744    41748       +4
============================================
+ Hits         201988   202373     +385
+ Misses        68568    68124     -444
- Partials      16828    16894      +66

Impacted Files
Coverage Δ

...pensearch/common/settings/FeatureFlagSettings.java
50.00% <ø> (ø)

.../main/java/org/opensearch/search/SearchModule.java
95.28% <0.00%> (-0.96%)
:arrow_down:

...main/java/org/opensearch/search/SearchService.java
71.61% <ø> (-0.14%)
:arrow_down:

...rch/search/query/ConcurrentQueryPhaseSearcher.java
58.33% <ø> (ø)

...n/java/org/opensearch/search/query/QueryPhase.java
77.85% <ø> (-0.72%)
:arrow_down:

...ain/java/org/opensearch/threadpool/ThreadPool.java
83.82% <0.00%> (-0.71%)
:arrow_down:

...rk/src/main/java/org/opensearch/node/MockNode.java
82.05% <ø> (ø)

.../java/org/opensearch/search/MockSearchService.java
96.00% <ø> (-4.00%)
:arrow_down:

...va/org/opensearch/extensions/ExtensionRequest.java
68.00% <40.00%> (-2.84%)
:arrow_down:

...ch/extensions/rest/RegisterRestActionsRequest.java
75.00% <78.94%> (+5.76%)
:arrow_up:

... and 1 more

... and 496 files with indirect coverage changes


8/2/2022 Publish

removed broken link, file not found

Docs Build status updates of commit 71bdf98:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/AzureActiveDirectory.md
:white_check_mark:Succeeded
View (azureadps-2.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[SUSHI-05] Gathering files for the website

YouTrack: PMI-60
Linked PR: BB-05
Context
The purpose of this PR is to extract data from the AI (big brain) prediction.
From this, we are using it to gather data from the assets of ressources (safely deployed during the workflow).
We are sending to the website a JSON format:
{
    "prediction": ...,
    "files": [
        "name": ...,
        "data": ...
        ...
    ]
}

From the above image we can see on the left size the API sending the json.
From the right side, we see the website successfully receiving the data for all files.

I would like to end this PR, and open a new one for the better Error handling display.
As for now, when the website fail to interact with the API, the error will be handled but no good messaging system to the user.


Move cron job out of cloudinit

It'd be nice if this wasn't in cloudinit so we could get some shell-check love.
The script would need to get the domain variable at runtime. This would also make it tolerant to domain changes. (which will probably never happen)
I couldn't find a k-command to spit out the realms, but something like this maybe?:
[mark.feldhousen@ipa ~]$ grep "default_realm" /etc/krb5.conf | awk '{print $3}'
COOL.CYBER.DHS.GOV

With that change it could be installed back in ansible land.

I am out of time now, but I will look into determining the domain at runtime when I have a chance.
Originally posted by @jsf9k in https://github.com/cisagov/freeipa-master-tf-module/pull/12#issuecomment-538002251

@jsf9k, @felddy - I don't think this issue is relevant anymore.  Can it be closed out?

The cron job now lives in cisagov/ansible-role-freeipa-server.

Issue moved to cisagov/ansible-role-freeipa-server #9 via ZenHub


Release 3.0.0-RC9

Current coverage is 71.55% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files            25         25
  Lines           348        348
  Methods         336        336
  Messages          0          0
  Branches         12         12
==========================================
  Hits            249        249
  Misses           99         99
  Partials          0          0

Powered by Codecov. Last update ffc8c0c...3f3e9a7


[BUG] Unexpected Behavior of CI Test For Recent Commits

Describe the bug
Unexpected Test Behavior for [build-and-test (ubuntu-2204, ubuntu, false, usdt_minimal, ./usdt_minimal, ./victim, false, bpf:)]
(https://github.com/eunomia-bpf/bpftime/actions/runs/10548526359/job/29222607476#logs)
Test CLI failed but report the test ran succsessfully.

It's a bug of the execution script, I'll fix it


Pinned window via Always On Top unpins after adding a hyperlink to text

Microsoft PowerToys version
0.66.0
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Always on Top
Steps to reproduce

Pin OneNote application
Copy a MS Edge link from other window
Select OneNote text
Ctrl+K to open hyperlink window
Paste link
Enter
OneNote is no longer pinned

✔ Expected Behavior
OneNote stays pinned.
❌ Actual Behavior
OneNote unpinned.
Other Software
I tested this with an Outlook email as well and the same behavior occurs.  Also tried copying links from Chrome and the File Explorer in Windows.

Not able to repro this, going to close. Let us know if you see this again!


Plugin crashes during connection

Followed the setup instructions and I get "Plug has crashed. Retry." every time I try to Connect the plug-in in settings.  Any advice?

Same for me...
have ranamed and put the Plugin into the correct folder, updated API-Key, bsnes Folder and Rom Folder (Network-Drive).
After connection of the plugin, in works for about 20 seconds and then crashes.

I had the same problem and investigate a bit, from what i got,
the plugin crash with some roms (for me it was Kyle Petty's No Fear Racing.smc
the last logged line before the plugin crashed was
2020-05-16 12:04:58,295 - galaxy.task_manager - DEBUG - Task manager jsonrpc server: creating task 7 (import_local_games)
After removing this rom from my rom folder, the plugin stopped crashed.


Proposed update to RestrictionType.md

Adding several proposed values for road closures to the RestrictionType Enumerated Type so that there can be a central place where that information is stored and referenced from.

I'm not sure what is being proposed. Based on #255, it may help for you to check out VehicleImpact, which may be a better way to represent closures.

We are proposing adding values to RestrictionType which can give an explanation for why a road is closed (e.g. maintenance, seasonal, unspecified).

Alex, Jacob would like us to sett up an issue to host discussions.  Ill show you how.

@DeraldDudley, @imcurtis, this is the Issue. There is just not enough information about what is desired or proposed in the initial issue comment. Please expand on what you are proposing changing and the value of that change—thanks.

Closing as @DeraldDudley noted this will be address in a different manner, though a new issue and PR.


Mail notification improvements

Some things I found while working on the integration with my mail server:

Added the notifyMailHostname because my mailserver required a fully qualified domain for authentication. It falls back to the hostname (as before) when initializing the config option. This is an optional flag, so it should not hurt users who already activated notifications.
Allowed to pass through additional flags from the config.scripts/blitz.notify.sh send call to XXsendNotification.py, which is useful for configuring individual mails one might want to send. (e.g. with different subjects or with custom from addresses)
Allow setting a custom From header
Uppercased the sSMTP config options for consistency

@frennkie this one would be for you to check
@dennisreimann when contributing bigger scripts updates it would be best to make PR to the v1.6 branch

Ah, ok, didn‘t know about the branch. Can adjust it if the changes are wanted and @frennkie gives a tACK :)


Fix parallel access

Try again, this time giving "true" instead of "false" in the condition of https://github.com/fsprojects/Paket/issues/3606

failure seems unrelated


Chrome Manifest v3?

Would you consider updating this extension to conform to the new v3 manifest for Chrome extensions? Chrome already won't load this extension as-is right now, and manifest v2 will be completely deprecated in 2023.

+1


Weird pagination

hello there
i used
$sailsBind.bind("resource", $scope);
in my project to listen to realtime updates via socket of resource model, but it only display the first 30 records, like it was paginating the results. This a default behavior or some king of pagination that sails do??

Hi @maikelohcfg,
You probably don't care about the solution anymore, but in case you were still interest - this is a server-side setting in Sails in config/blueprints.js   called defaultLimit  which defaults to exactly 30 records.   Modify that value to whatever you need (-1 brings up all records) .

thanks a lot for the answer i will take in consideration


angluar-cli is not FIPS Compatible

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
Description
Much like https://github.com/angular/angular/issues/42577 the angular-cli also uses md5 hashes and fails to run a build on a Red Hat(Rocky) 8 system with FIPs enabled.
🔬 Minimal Reproduction
On a Red Hat(Rocky) 8

# Enable FIPS Mode and Reboot
sudo fips-mode-setup --enable
sudo reboot now
# Install Red Hat 8 Node JS 16
sudo dnf module install nodejs:16

ng new my-app
cd my-app
# Fix FIPS issue in babel-loader
sed -i'' 's~md4\|md5~sha256~g' node_modules/babel-loader/lib/cache.js
ng build

🔥 Exception or Error

./src/main.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: error:060800C8:digital envelope routines:EVP_DigestInit_ex:disabled for FIPS
    at /home/sweeks/Projects/my-app/node_modules/@ngtools/webpack/src/ivy/loader.js:81:18
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

./src/polyfills.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: error:060800C8:digital envelope routines:EVP_DigestInit_ex:disabled for FIPS
    at /home/sweeks/Projects/my-app/node_modules/@ngtools/webpack/src/ivy/loader.js:81:18
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

🌍 Your Environment

Angular CLI: 13.3.3
Node: 16.13.1
Package Manager: npm 8.7.0
OS: linux x64

Angular: 13.3.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1303.3
@angular-devkit/build-angular   13.3.3
@angular-devkit/core            13.3.3
@angular-devkit/schematics      13.3.3
@schematics/angular             13.3.3
rxjs                            7.5.5
typescript                      4.6.3

Anything else relevant?

Replacing md5 in the following files seems to resolve the issue so this should be fairly easy to fix.
sed -i'' 's~md5~sha256~g'<EMAIL_ADDRESS>sed -i'' 's~md5~sha256~g'<EMAIL_ADDRESS>

Closed via https://github.com/angular/angular-cli/pull/23039/


Windows Defender false positives

Duplicate of https://github.com/CloneTrooper1019/Roblox-Studio-Mod-Manager/issues/54


Separate UpdateTime and DataTime in DatadogMetric controller

What does this PR do?
The data age might be significantly in the past even for fresh data,
in particular when using a large rollup(<duration>). This makes it
impractical to use because you intially need to wait up to maxAge to
see your metric being updated.
This change distinguishes the two things. DataAge is still being used
for the update time condition to avoid breaking the printer behavior, but
the plan is to eventually introduce a new field for the data age.
Motivation
The VPA is going to make an extensive use of rollup()
Additional Notes
N/A
Possible Drawbacks / Trade-offs
N/A
Describe how to test/QA your changes
Tested locally in minikube by increasing the duration value of a rollup:
$ k get datadogmetric hamster-test -w
NAME           ACTIVE   VALID   VALUE               REFERENCES   UPDATE TIME
hamster-test   True     True    425621517.9319728                87m
hamster-test   True     True    413520790.4969697                3h27m

the metric is now updated correctly.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Tested on local minikube ✅


stress test the catalog - 1000 projects in dev db

The purpose here is to get a feel on the UI's performance when the catalogue is in its full expected load of 800 projects.
We should check:

[ ] load time
[ ] search time
[ ] sort time

Include payload size testing with the number of projects

Testing done with 1000 projects
UI Load time

Time to contentful paint: 3.3s (lighthouse reported)
Catalogue endpoint load time (throttled slow 3g): 21.68s
Catalogue endpoint load time (throttled fast 3g): 6.73s

Search time

Thanks.How do the numbers look with 500 projects? On Jun 7, 2021 22:26, Jacob Windsor @.***> wrote:
Testing done with 1000 projects
UI Load time
Time to contentful paint: 3.3s (lighthouse reported)Catalogue endpoint load time (throttled slow 3g): 21.68sCatalogue endpoint load time (throttled fast 3g): 6.73s
Search time
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

@amnonkhen See updated comment above

@amnonkhen and I agreed this was not a problem. It would be nice to have a loading whirly to help communicate its loading, which I will make a separate ticket for.


maintain file context when invoking Python scripts through relay

Without the patch the stacktrace only show <string> for the file the relay scripts are redirecting to.
With this patch the stacktrace contains the correct file path of the Python script.

+1


[Request] Add form entries to PDF

Be able to place, move and resize form elements around PDF pages and save the resultant PDF and its Forms
https://jsfiddle.net/Hopding/bct7vngL/4/ as example for pdf-lib form adding
Should support
createCheckBox
createDropdown
createOptionList
createRadioGroup
createTextField
I expect this to look somewhat like the sign PDF, with a add entry type button, draggable and resizable entry, which then results in a output from pdf-lib

there is already a base branch add-elements but its like 9 months ago and needs big rebasing
Gave some feedback on it a while ago and it still needs some work
Feedback was
"Dropdown and Option lists are always square and take their horizontal size only
Moving the entries and reseizing them is awkward, could we have the user hold shift or something to have them resize and control to move
and alt to keep ratio while resizing or something... idk...
trying to move a rectangle is impossible if its height or width is small as the resize takes presedent
being able to edit/type/click the boxes while moving them is really awkward, would be nice if that required a double click or something"


Issue: Lack of 'Home' Navigation Item on Key Pages

The omission of a 'Home' navigation item on essential pages like Projects and About Us can create a frustrating and disorienting user experience. This navigation gap leaves users without a straightforward way to return to the homepage, potentially leading to disengagement and decreased user satisfaction.
Impact:

Reduces ease of navigation and may confuse users.
Forces users to use indirect methods to return to the homepage.
Increases the chance of users exiting the site, especially for those unfamiliar with the navigation structure.

Solution: Including a consistent 'Home' link on all main pages allows users to easily return to the homepage, enhancing usability and improving the overall navigation experience.

see in some pages, there isn't any requirement for home button, as when user clicks the ml fusion lab logo, then it automatically redirects to home page.
so we don't require this.
so i am closing this issue.
please understand.
And please don't create multiple issues at a single time. this is the warning.
And one more thing this project and me are inactive for sometime due to some of my works.
please do work on other projects.
i hope you understand.

can you please assign me this under gssoc'24 extended edition and I had solved the issue

sorry i have said it before for now we don't require this.
please understand.

sorry to say this brother but  i have raised the issue to explain and to get the work.
hope you understand brother

@umar-farooq-shaik can you do this now.
i will assign you this issue only.
as i have said before this project and i am are going to be inactive from today night.

i will assign you this issue only.
as i have said before this project and i am are going to be inactive from today night.

brother i will complete today itself

@umar-farooq-shaik assigning this issue to you.
Make sure to complete this.
i will assign you this issue only.
and please don't disturb anything.

and please don't disturb navbar and remaining headers of the pages that you are working.
and make the design same.

@umar-farooq-shaik have you done with the task.

@umar-farooq-shaik make sure to update your branch and then do commit the changes and then create the new pull request.
waiting for your Pull Request.

@vivekvardhan2810 completed and have a look at it.


Consistent naming of struct variables

The struct members between the Win and Linux C implementation often have different names where they mean the same thing actually. This could be improved to have a consistent variable naming within a specific driver (and even throught the whole library).

Sometimes also the implementations are quite a bit different. Don't think that it is a big issue if variable names differ a bit. I don't mind If you want to change the Windows part to be closer to the Linux, but I don't think it is very worthwhile and I would rather avoid to enter a time consuming discussion about how to (re)name variables. Maybe worth to have a bit of an eye on it in new developments, but I currently wouldn't dig into it for the existing code.


Calibrate Shooter

Set kV and kP to zero.
Set kV to its theoretical value. Crank it up or down until the steady-state actual shooter speed matches the desired speed for both motors.
Increase kP until shooter speed starts oscillating. Then back it off a bit.
Should be good enough.

https://docs.wpilib.org/en/stable/docs/software/advanced-controls/introduction/tuning-flywheel.html
Needs a robot, but you can practice offline! ^^^^

Done on practice.


Run number

Description
Allow filtering on computed fields
Motivation
At PSI we allow runNumber to either be an object or a number. This allows the ordering and filtering to work in both cases
Changes:

common/models/mongo-queryable.js add computed field which replaces runNumber.value in aggregation pipeline

Tests included/Docs Updated?

[x] Included for each change/fix?
[x] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?
[ ] New packages used/requires npm install?
[ ] Toggle added for new features?

@sbliven as discussed this morning the addFields mongo functionality could be leveraged to define RI custom calculated columns, the logic of which could be provided in a config file


Exposed ReactNative's Platform.select function.

Interested in having this!
Could you rebase/resolve conflicts please?

@MoOx : Rebased. Please review.

We need to figure out why ci doesn't want to test this pr... (like lot's of others)

I am having second thoughts about this binding. Please take a look to
https://github.com/reasonml-community/bs-react-native/issues/316


add wait to createSecretForServiceAccount

Problem
peermanager in HA uses token from service account secret on startup. It doesn't error out or complain if the token is empty and uses it https://github.com/rancher/rancher/blob/release/v2.6/pkg/tunnelserver/peermanager.go#L113. This results into cluster not found errors because we cannot find the cluster by token for tunnel authentication.
2022/07/06 03:38:02 [ERROR] error syncing '_all_': handler user-controllers-controller: failed to start user controllers for cluster c-m-mfhzj6w6: ClusterUnavailable 503: cluster not found, requeuing
2022/07/06 03:39:20 [ERROR] Failed to handle tunnel request from remote address <IP_ADDRESS>:34690 (X-Forwarded-For: <IP_ADDRESS>): response 401: failed authentication

Solution
We don't have checks for empty token in peermanager or agent before using it to tunnel, adding wait to not return secret until token exists in data. All calls to create should wait for token to be populated now.
Issue
https://github.com/rancher/rancher/issues/38199
https://github.com/rancher/rancher/issues/38247
https://github.com/rancher/rancher/issues/38222

Testing

Tested using custom image kinarashah/rancher:v2.6.6-rc6 and kinarashah/rancher-agent:v2.6.6-rc6
HA RKE1 v1.24.2-rancher1-1

Downstream clusters - 1cp, 1etcd, 1 worker

[ ]  RKE1 Fresh Install v1.23.8-rancher1-1
[ ]  RKE1 Fresh Install v1.24.2-rancher1-1
[ ]  RKE1 Upgrade from v1.23.8-rancher1-1 to v1.24.2-rancher1-1
[ ]  RKE1 Custom Fresh Install v1.23.8-rancher1-1
[ ]  RKE1 Custom Upgrade from v1.23.8-rancher1-1 to v1.24.2-rancher1-1
[ ]  RKE2 Fresh Install v1.23.8+rke2r1
[ ]  RKE2 Fresh Install v1.24.2+rke2r1
[ ]  RKE2 Upgrade from v1.23.8+rke2r1 to v1.24.2+rke2r1

Observed

[ ] No docker dialer errors
[ ] Clusters come up active, no waiting for API msg + cluster agents are running
[ ] Clusters come up active after upgrade, no pods in terminating


wowsims/wotlk | mage

on a mage in crit in buffs it shows +0.36 crit even if you take off clothes, cancel all raid buffs and talents
in crit in buffs it shows +0.36 crit even if you remove clothes, cancel all raid buffs and talents
and accordingly, in the end it shows 0.36% more crit than I actually have if I put on clothes, add raid buffs and talents
troll mage without any clothes, buffs, talents:

It's probably Arcane Intellect
But I switch of it in buffs

Classes receive their own buffs be default as it's assumed you'd have them. This logic is from the raid sim, but I get why it's confusing from a UI aspect.

Yep, working as intended. Sorry for the confusion!


why was my rfc closed?

          Do not make PRs like this.

Originally posted by @Noratrieb in https://github.com/rust-lang/rfcs/issues/3743#issuecomment-2546886446
Sorry, I am new to this RFC thing. I just got on GitHub and I saw rust was cool, so I wanted to make good first impressions by submitting what I think is a nice idea for Rust. I had chatGPT help me with the formalizing, I admit. What should I correct in the RFC, and may I resend a fixed version?

if you want to genuinely help improve the language, go to https://internals.rust-lang.org and talk about the problems you want to solve


Send slack notification when build completes

Indicate devsite url, build url, build outcome, deploy outcome

test comment


newlib: Bump to <IP_ADDRESS>30120

Urgh, the Ubuntu RISC-V toolchain seems too old
error: ../../newlib/rv32/rv32imac/libc.a(libc_a-exit.o): Mis-matched ISA version for 'i' exetension. 2.1 vs 2.0

I'll try rebuilding with something older

Hmm... After more testing I'm seeing odd crashes. It seems to be with the new newlib. I'm going to close this until I figure out what's going on


Make deploy scripts generic

Currently the deploy scripts assume a static project name of "keytransparency"

Relevant PRs:
#960
#959
#861


where is the assembler?

Hi
where is the assembler file for FFT?

This module is written in MicroPython and targeted on STM processors (e.g. the Pyboard). MicroPython supports inline Arm Thumb assembly language so if you look at dft.py you'll find the assembler code. The MicroPython compiler automatically emits machine code in response to the @micropython.asm_thumb decorator - see the tutorial and the docs.
Please note that I wrote this integer version at a time when the inline assembler didn't support floating point arithmetic; this has now been addressed. Please use the floating point version which is equally fast but more accurate.

Thank you.
Since ESP32 has a dual 240Mhz ARM-based processor, do you see a value to export this ASM to ESP32 chip, as one chip FFT solution?
Can you offer some Python base runtime graphics XY drawing, so I can see the result in real time over UART terminal connection?

I haven't studied the ESP32 architecture - if it supports the Thumb instruction set the code should be portable. However I'm not sure whether the ESP32 port yet supports the @micropython.asm_thumb decorator as the port is still classed as "experimental".
I suggest you experiment with a trivial test case of assembler code to see if the port actually supports it yet. If it succeeds you should have a good chance of porting the library.
As for graphics there are various libraries available depending on the display hardware you wish to use.

From a quick test it's evident that the official ESP32 port doesn't (yet?) support the @micropython.asm_thumb decorator. So, alas, there's currently no chance of porting this library.

It seems that there is already support.
See https://e2e.ti.com/support/dsp/c5000/f/109/t/127082
the file asmarm.h  https://goo.gl/Zsv9AL

The file asmarm.h is in the Loboris build. I only tested against the official build. If you're using the Loboris build I suggest you try this code sample to see if there is basic support (if called it just returns 42).
@micropython.asm_thumb
def fun():
    movw(r0, 42)

If that works I'd then check that the floating point instructions are supported, as these were the last to be added to the official STM build. The official STM board supports a subset of Arm Thumb - if Loboris supports at least this subset then the library should work. Please report your findings.

I try that, it does not work.
The decorator @micropython.asm_thumb can be found in any file (.)
@micropython.asm_thumb
def fun():
movw(r0, 42)
print(fun())
running that shows:
File "main.py", line 82, in
SyntaxError: invalid micropython decorator
I believe in Loboris the asm is declared differently in the C files. See the url: https://goo.gl/YpZ9o8

I've now taken a look at the ESP32 chip. From the technical reference manual:

The ESP32 is a dual-core system with two Harvard Architecture Xtensa LX6 CPUs.

The Xtensa LX6 is a Tensilica design and from the Tensilica datasheet its instruction set bears no resemblance to Arm Thumb. If this is correct the FFT code would evidently need to be rewritten.

You are right.
But easily can a be replace line by line.
The problem is that I do not know how to embed it with Loboris code.
I use Loboris code, because he is the only code with MicroPhyton that support large added external RAM
If you can help on the Python side, I will replace the ASM Arm Thumb of  Tensilica

The Python really extends only to the test programs which are very short and may well work unchanged. If you look at dft.py you'll see it's all assembler. In fact the import statements seem unnecessary.
If you port that file to Xtensa, then dfttest.py should work.
I'd be glad to offer advice but I'm busy with another project so I'm not in a position to contribute significant coding effort. I trust that you'll make your solution available here under the MIT licence?

of course I will make my  solution available under the MIT licence.
The help I need is not in coding. The ASM command part I can do my self.
I lack knowledge how to embeded your code in the project : https://github.com/loboris/MicroPython_ESP32_psRAM_LoBo
And I must use it since I needed the extra ram.

I don't follow what you mean by "embedding my code in the project". My code isn't embedded in the MicroPython project - it runs on a standard build of STM32 firmware. If Loboris supports a decorator for the Xtensa assembler you will be able to port it. If the decorator is unsupported you'll need to talk to the Loboris maintainers: I lack the skills to implement this decorator.

I see, I was hopping it some ASM code, covered by C lib, that can be called as MicroPython code.
Thank you.
If in any stage you will like to do FFT on ESP32 I will be happy to assist.
<EMAIL_ADDRESS>


Add Composer script handler

This is required before merging symfony/symfony-standard#248

This PR should be done on master.


Unable to uninstall Microsoft Visual C++ packages

It seems Microsoft is changing the names of Microsoft Visual C++ packages, which may be the reason why it's not possible to uninstall them through WingetUI (as admin and interactive also don't work). Installing works fine, though.
This is likely a WIP, since there are still duplicates of Microsoft Visual C++ 2008 packages in CLI, but I was able to successfully uninstall all Microsoft Visual C++ packages through CLI, while WingetUI failed for all of them.
Besides, WingetUI doesn't correctly identify the package source as Winget and the package ID of some of them is messed up on WingetUI (but not on winget-cli):

Possibly related to https://github.com/martinet101/WingetUI/issues/198

Same problem with Microsoft.DotNet.DesktopRuntime:
I am unable to uninstall Microsoft.DotNet.DesktopRuntime.3_1 and Microsoft.DotNet.DesktopRuntime.6 using WingetUI, but through Winget-cli it is possible.
For Microsoft.DotNet.DesktopRuntime.5, it's impossible to uninstall using both Winget and Winget-cli, since it's not recognized by Winget-cli...
It's kinda ironic Microsoft products having problems with Winget. Anyway, I am gonna complain to Microsoft. I am not sure there's much you can do though

Yes, this is winget-cli things. .NET and C++Redist have always caused problems.

I have managed to get the some ids to fully show in the uninstall section, could you please try uninstalling again with the latest head?

Yes, this is winget-cli things. .NET and C++Redist have always caused problems.

I think this is the same bug as https://github.com/martinet101/WingetUI/issues/198:
winget uninstall --id Microsoft.VCRedist.2005.x64 -e --silent
fails, but
winget uninstall --id Microsoft.VCRedist.2005.x64 -e
does not, so I am gonna suggest again to automatically try to uninstall without silent parameter as a fallback.
I've also noticed that WingetUI install message doesn't show the full package name in this case, couldn't this also be a problem?

I have managed to get the some ids to fully show in the uninstall section, could you please try uninstalling again with the latest head?

Anyhow, I've tried to reinstall 2005/2008 x86 and x64 versions and I don't get it why they are showing fine on Winget-cli, but messed up on WingetUI (after install they appear fine initially, however refreshing makes them like this again):

I've opened issues on Winget Github page about .NET and C++Redist, so hopefully someone from Microsoft will fix some of those problems on their end.


Failed import when attempting to run `python cli.py test'

I am attempting to follow the steps here: https://github.com/victordibia/neuralqa/blob/master/notes.md#notes-on-runningtesting-locally to run neuralqa locally. Everything seems to install fine, but when I run:
$ python3 neuralqa/cli.py test

I get the error:
Traceback (most recent call last):
  File "neuralqa/cli.py", line 2, in <module>
    from neuralqa.server import launch_server
ImportError: cannot import name 'launch_server'

Thanks @GrantCuster. I updated the steps for testing locally.


Pub install fails since IDE update

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?
http://stackoverflow.com/questions/17054191/dart-pub-error-on-package-install
What is the expected output? What do you see instead?
What version of the product are you using? On what operating system?
Dart Editor version 0.5.16_r23799
same sdk
Please provide any additional information below.

This issue has been moved to dart-lang/pub#580.


Modularisation

Core pure Java module with core services
Http module with Http Component
Module per feature

Modules will be connected by deep links. Need to involve mechanism of dynamic url resolving

Need Module with providing TopActivities

Need mechanism how to initialise stuff on application start

Depends on #120

Depends on #121


Adding NASA GISS Institution / Models to CMIP6Plus

institution_id = NASA-GISS
institution = NASA Goddard Institute for Space Studies, New York, NY 10025, USA
Models (same as CMIP6):
GISS-E2-1-G
GISS-E2-1-G-CC
GISS-E2-1-H
GISS-E2-2-G
GISS-E2-2-H
GISS-E3-G

Hi Alex,
Can I check which models, activity id and MIP you will be contributing to?
Institution ROR: https://ror.org/01cyfxe35
Thanks,
Daniel

Hi Daniel,
Sure thing - here are the models, activity IDs, and MIPs that we'll be contributing to:
Models:
GISS-E2-1-G
GISS-E2-1-G-CC
GISS-E2-1-H
GISS-E2-2-G
GISS-E2-2-H
GISS-E3-G
Activity ID: DAMIP
MIP: LESFMIP
Please let me know if there's any additional information I can provide that would be helpful.
Best,
Alex

Understood. In that case, let's just stick with GISS-E2-1-G (Activity ID: DAMIP, MIP: LESFMIP) for now.
Thanks for all your help.

@wolfiex, can you check the process -- the GISS model has not made it into the CMIP6Plus_CV.json, but there is another file alongside it with the change.

The create script did not trigger for some reason. Pushed through with the latest updates.


[lsc] Rewrite scraper for new website

Fixes #233. Some older reports, especially those related to the "mapping project," have broken links. I plan on dealing with those as part of #204, by extracting the relevant files from https://www.oig.lsc.gov/images/mapping/mapping.zip.

Tested, and it works great. Do you have a sense of whether the unique IDs have changed between versions of the site/scraper?

I didn't pay too much attention to that, but I think most IDs stayed the same, while some changed. In most cases, we still use the report numbers, or failing that, the filenames. Both numbers and filenames were preserved, as far as I could tell. I did have to handle a new edge case between audit report 00-001 and special report 00-001, so there were some changes.


Some qualifiers in Wikidata are non-discriminatory and new statements added by OpenRefine should be merged into existing ones with the same value

Whenever OpenRefine tries to import a statement into an item but sees an existing statement of the same property and with the same value, it will merge the statements together, leading to eg. one statement with two references. Situation changes when OpenRefine sees the same value, but qualified with a qualifier. It will then create a new statement, because qualifiers are usually discriminatory - they specify the circumstances under which a statement is true.
However, some Wikidata qualifiers are non-discriminatory, they merely specify some aspects of the value itself. For example, reason for preferred rank (https://www.wikidata.org/wiki/Property:P7452) or reason for deprecation (https://www.wikidata.org/wiki/Property:P2241). These should be always kept but new statements with the same value should be imported into them.
Example of erroneous behaviour:
https://www.wikidata.org/w/index.php?title=Q2634996&type=revision&diff=1486438858&oldid=1465342427
Fixed like this: https://www.wikidata.org/w/index.php?title=Q2634996&type=revision&diff=1489850300&oldid=1487541248

I am classifying this as an enhancement request, because the current logic works as expected, although I totally agree with you that a more granular control of the merging strategy would be extremely useful for a lot of imports.
See this related issue (duplicate?): #2116

In Wikidata we have the following2 subclasses that could be used to sub-categorize ? :

non-restrictive qualifier
restrictive qualifier

Although I am not 100% sure of who/what maintains the members within each of those above subclasses.
There might be a need to further review the members within this subclass as well:

Wikidata property used as "depicts" (P180) qualifier on Commons

Getting consensus might be worrisome for a few that are not already members of any one of the restrictive/non-restrictive qualifier subclasses, but still probably approachable.

This should be in the forthcoming release (3.6). In the meantime, feel free to use our snapshot releases to try it out and tell us if you see ways to improve it.


suggest CMD to check/get current value

suggest to add this to check current status:
Get-CsTeamsMeetingPolicy | select Identity, WhoCanRegister, AllowMeetingRegistration, AllowPrivateMeetingScheduling

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b2fe730-a95d-d12d-adb8-49d1397c77c7
Version Independent ID: 1f6077c3-6114-cb5e-8b1a-7587188f2cdf
Content: Set up for webinars in Microsoft Teams - Microsoft Teams
Content Source: Teams/set-up-webinars.md
Service: msteams
GitHub Login: @KarliStites
Microsoft Alias: kastites

@TiloGit Thanks for your feedback, we will consider adding this to the documentation


[BUG] Zebra preset is not working

Describe the bug
The Zebra preset is not working after chosen and saved.
A respring does not help too.
To Reproduce
Steps to reproduce the behavior:

Choose the Zebra preset
Save
Press on "Add to Cydia" link
See error

Expected behavior
It should open Zebra instead of an invalid URL alert.
Extra Info
Please include

Device model: iPhone XS
iOS version: 13.5
Evil Scheme version: 0.1.0

Thanks for the bug report. Can you clarify what you mean by "invalid URL alert"? Are any apps launched after clicking on an "Add to Cydia" link?

No apps are launched after clicking.
And I have Cydia uninstalled btw.
The alert look like this.

Aha, that would be why. This tweak relies on redirecting requests from one app to another, and the Zebra preset targets Cydia. Do you have Sileo installed? If so, changing the Old Bundle ID from com.saurik.Cydia to org.coolstar.SileoStore should work.

Assuming that was the solution, I'm going to look into allowing multiple target Bundle ID's in a single preset in the next Evil Kit update.

I just have Zebra installed.
So I cant change my default package manager without installing the others?

As of now, yes. I'm looking into ways to change this in a future release, but it is low priority.

I am looking forward to the implementation of that feature. Thanks for your work!


App for ubuntu

When is it planned to release an application for Ubuntu?
And how can you listen to Endel now on Ubuntu now without an application (the browser does not work - it has a limited version of Endel)?
Thank.

Sorry i was wrong


Setup rollup for bundling for browser usage

The rollup configuration bundles a separate file which does not do fs.readFileSync, and uses the YAML plugin to precompile YAML files into JSON, which also allows us to avoid bundling the js-yaml dependency.

The compiled bundle looks fine, and seems to work without errors when doing a simple require(".") in the Node.js REPL. I'll look at integration with the frontend tomrorrow. Also might want to look at https://github.com/wessberg/rollup-plugin-ts for generating TS definitions as well.

Merging first, will send another PR for the bundle deploy step.


Display shared frames (shallow copy)

Let the user know how frames are shared.

This is mostly done, under the form of a marker in the top left of the frames, showing linked frames when you select one.


Make loss a kwarg in gcp

Currently, loss is treated differently from constraints since it is a positional argument rather than a keyword argument:
https://github.com/dahong67/GCPDecompositions.jl/blob/03f3b875f2e53ad326d62d2c90a990dd1898b707/src/GCPDecompositions.jl#L54-L61
This PR makes the behavior consistent by making both keyword arguments.
https://github.com/dahong67/GCPDecompositions.jl/blob/ade9f9e30b46740bfb980082274ce31b23728c45/src/GCPDecompositions.jl#L55-L62
Alternatives considered:

make both positional arguments:

pros: distinguishes arguments that define the decomposition problem (i.e., X, r, loss, constraints) from the algorithm parameters (i.e., algorithm, init)
cons: need to remember whether loss comes first or constraints, a bit awkward to specify constraints without also specifying loss

leave as is

pros: highlights the loss as central part of defining the decomposition problem (together with X and r)
cons: treats loss and constraints differently

define a combined loss-constraints type and pass that in as a single positional argument

pros: distinguishes arguments that define the decomposition problem (i.e., X, r, loss, constraints) from the algorithm parameters (i.e., algorithm, init)
cons: feels a bit "over-engineered", perhaps less user-friendly

All tests are passing (except the failures on Julia nightly that are likely unrelated). Merging!


[Feature] Add custom steam grid images for imported games.

So, with the new app this might be possible, using it together with a web site that provides Steam grid images for games, the problem is: I can't figure out how does Steam generates the id it uses to tie non-steam games with their images on /config/grid.

It seems that Steam uses a CRC hash generated from the path to the exe and game name, i'll look further this weekend and try to understand this better.

@BrianLima yes, you are correct; however, that's only by default. You can tell steam to use a custom image. The following is an example of Minecraft UPW with a custom image.


Sending Enter key is wiping out the username and password on the screen when username is set using SetTextAtCursorPosition

When Username and password are set using SetTextAtCursorPosition and then if Enter key is send , it is clearing the screen instead of navigating to next screen.

Sorry, but I am no longer updating this.


Base URL Config

I am running excalidraw under an alias ( https://example.com/exalidraw ). However, when I use it, the requests are made without the alias (for instance, https://example.com/static/js/1.d708ec08.chunk.js - 404).  Is there a place where I can configure the base URL to add this alias?
Thank you

I struggled with the exact same thing this morning! I got it working with the following changes.
In public/index.html
replace
window.EXCALIDRAW_ASSET_PATH = "/";

by
 window.EXCALIDRAW_ASSET_PATH = "/excalidraw/";

In src/service-worker.js
replace
importScripts("/workbox/workbox-sw.js");

workbox.setConfig({
  modulePathPrefix: "/workbox/",
});

by
importScripts("/excalidraw/workbox/workbox-sw.js");

workbox.setConfig({
  modulePathPrefix: "/excalidraw/workbox/",
});

Thank you very much, it works and saved us a lot of troubles!


feat: check existing file

This PR merges one function to check the existance of a file in the filesystem and test it


Add namviet.edu.vn to the list of domains

@VTrngNghia Regrettably, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Can you share the download link for the Imagenet10 and imagenet100

Hello, I want to reproduce your result on Imagenet10 and imagenet100. However there is a question for that there are so many kind of Imagenet10 and imagenet100. So can you please give us a official link to get the Imagenet10 and imagenet100, which is the same as yours.
Thank you  for your sincere help.

Hello! The class list for ImageNet10 and 100 can be found in ./misc/class100.txt in this repository (where ImageNet10 uses the first 10 classes). Note that the file is loaded at data.py L92-105.

Yeah, got it. Thank you.
So I simply put the full imagenet in the data diretory, the class list will automatically load class100.


Why do I always pull the new gcr.io/kfserving/pytorchserver image when I deploy the isvc of pytorch?

/kind feature
Why do I always pull the new gcr.io/kfserving/pytorchserver image when I deploy the isvc of pytorch?

This is the same as #1699


⚠ Bofrost.de has degraded performance

In 0fffbc1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2159 ms

Resolved: Bofrost.de performance has improved in c5a06d4 after 17 minutes.


Compatibility with julia 1.0

It seems that the project files requires julia v1.3. Could that bound be lowered, or are you using certain new features?

I have tests passing locally on v1, but it takes about 3 times longer than tests on 1.5.
That means tests on v1.0 will very likely take well over an hour to run on Travis, and thus timeout.
However, v1.0 requires adding a compat dependency and an additional roughly 20 lines of code to support it which would then be uncovered by tests. Not sure if it's worth merging.


Add files via upload

Hello @booberry46 ! Thank you for interest in the project. You are the very first Data Needed contributor from the outside of our colleagues (:
Unfortunately, this Data Needed is already present in the repo, take a look:
https://github.com/atc-project/atomic-threat-coverage/blob/master/data_needed/DN_0062_4663_attempt_was_made_to_access_an_object.yml
I will close this PR, but please don't hesitate to contribute anything else in the future!

shrug, I missed the existing repo. I'll chip whenever I can!


Add warning/flag if segmentation needs to be modified

This pull request aims to fix issue 42

@jcohenadad  I did a clone of this branch under joplin. To access the simulated server use the ssh tunnelling explained in : https://github.com/neuropoly/sct_testing_management#development. Once you do the tunnelling, open the link in your internet browser. Username and password information available here

In your terminal run :
ssh -L 8100:joplin.neuro.polymtl.ca:8000<EMAIL_ADDRESS>Use the password for local neuropoly account. Do not close the terminal window.

In your web browser go to : link. Use username: sct_test_user; passwd: management.

On the lower right side of the page you should see the filter by label needs correction. If you edit one of the images, a checkbox should be present in the labeled images section.

@alexfoias fantastic!!! great job 👍
could you pls add this explanation under new section: "How to test the DB from a specific branch".
and i assume that you already configured neuropoly_local to be in-tuned with this branch, so could you pls also give explanation as to how to update to a specific branch (with git checkout), thx

@jcohenadad I created the wiki page here


fix(users): GitHub strategy missing email

Fixes an issue with an empty/missing/null Email coming from GitHub's
OAuth call response.
Also, introduces the sparse index option on the User model's Email
field. This will ensure that we can have multiple User documents without
the Email field.
Related #1145

I'll add some tests to this PR, sometime tomorrow.

Added a test to ensure the sparse option is working properly.
@lirantal WDYT?

I think it's overall ok, although I'm wondering if there's really a case where GitHub will return no email for a user?

If a user chooses the "Don't show my email address" option in their Profile settings for Public email. Then GitHub won't return the email address. Also, Twitter doesn't send user's email at all.

Which only make you wonder how twitter ever worked, right? :)
Ok, let's see if anyone else has anything else to contribute

Twitter worked, because we allow empty/missing email fields in our User model. The issue will only show itself if there's an attempt to save a new User without the email field. Thus, mongodb treats both of those as the same, and won't allow it since we have the unique index setting on that field; there's a violation of the unique constraint in that case.
We don't run into this issue with local testing, since most of us just use one User for any particular Social Account. I guess User's of this framework haven't ran into this issue, or reported it. Until @farajfarook did.

That's what I was referring to - that probably users of MEAN.JS who used GitHub did get this problem for such cases where the user opted out from sharing the email detail.
Anyway, it looks like a correct way of handling it.
LGTM.
@codydaig maybe another pair of eyes?

@mleanos BTW you are definitely able to run some manual tests with local users signup, GitHub as well as another strategy, right? just to make sure we're not breaking anything larger here.

@lirantal I've been going through the Social Accounts implementation & testing. I've noticed some issues with the other providers as well. This fix is part of a bigger initiative to get the Social Providers working 100%. I have a list of issues I've come across, but haven't organized it yet.
I have tested this with the other provider's and there aren't any issues, other than the other aspects of the Social Provider's implementation that are broken. However, this does also take care of the issue raised in #1145.
I did extensive testing with the sparse option, and it won't have any adverse effects. The only nuance is that when this is integrated into an existing application, the index on the email field in the MongoDB instance would need to be drooped. The next time the application is run, Mongoose will rebuild the index using the sparse option. I added a comment in the Schema for that.
Also, the test I added will ensure that the sparse index works; regardless of which Provider is being used.

@mleanos ok, that's clear.
Do users have to manually drop the index or will mongodb rebuild it automatically for them?
If it's manually, I'm not sure users will understand that straight away - is it possible to catch the error from mongodb on that and show a message to guide them?

User's do have to manually drop the index. However, we can probably add a Gulp task that is executed with one of our other tasks, that start the server; default, prod, test. Do you think that would work?
Another option might be to add something to our mongoose server config, that ensures the index is dropped if the sparse option is not set for it. Or we simply display a message in this case. I haven't looked into that, but I think it will be possible. One caveat to this option is that this check will be performed every time the database is started; I'm not sure how I feel about that.
I'd like to make it as easy as possible for our users. However, it might be more trouble for us than it's worth. As it stands, it's technically not a breaking change. Users will only run into any issue when a duplicate user is saved that violates the indexes unique constraint; in this case, a missing/empty email field.
I'm happy to do more work on this to make it easier on our users. But I just wanted to throw those options out there. And the inline comment might suffice for now.

We would like to be unobtrusive but in the same time not break things horribly.
This has been a recurrent issue for us with other updates we had before like fixing the users table's salt which was accidentally binary and that messed things up and was a breaking change too when we fixed it.
I would like to suggest that we have an UPGRADE.md (and possibly accompanying wiki page or whatever else helps as well) that states the big changes that require user involvement when the version changes.
@ilanbiala WDYT?

If we do like Angular does and put in our Changelog the breaking changes and the fixes, then I think that is sufficient.

sounds good to me.
@mleanos can you include this kind of update with this PR about the index change and instructions of what should be done?

I added a UPGRADE.md to this PR. However, I may need help with the markup. I don't have a way of testing the markup locally, since I'm on Windows. And AFAIK Jenkins isn't supported on Windows.

@mleanos added my comment and also you can see how the markup renders through GitHub, check this URL for your file: https://github.com/mleanos/mean/blob/fix/users-github-strategy-email/UPGRADE.md

@lirantal I know how to test it once it's in a remote GitHub repo. I just can't view the rendered markup locally. It's not a problem. I can just push to my fork, and test there.

@lirantal @ilanbiala @codydaig I updated this PR to include a companion upgrade script, for dropping the index using Mongoose. I also updated the UPGRADE readme to include directions on how to use the script.
How does the UPGRADE.md file look to y'all?

Coverage remained the same at 70.615% when pulling 07b56f6c3802a41f1be539431b9111aecf5af86f on mleanos:fix/users-github-strategy-email into bc0b4a62e1fff40e96a2888af3a1078efc3fa9ab on meanjs:master.

Coverage remained the same at 70.615% when pulling 07b56f6c3802a41f1be539431b9111aecf5af86f on mleanos:fix/users-github-strategy-email into bc0b4a62e1fff40e96a2888af3a1078efc3fa9ab on meanjs:master.

Upgrade.md looks fine to me. In the upgrade script, I don't want to start abbreviating package names. I'd rather keep it as mongoose.

@codydaig I addressed your comment. For clarification, mg was referencing our mongoose configuration & mongoose was already used by the reference to the Mongoose library; the latter was not used in this script so I removed it and renamed the other reference :)
@lirantal How does this look to you now, in regards to your comments about the upgrade instructions?

Coverage remained the same at 70.615% when pulling 570b69b74cf7e5c5588004e46f23b6fdfeeedd69 on mleanos:fix/users-github-strategy-email into bc0b4a62e1fff40e96a2888af3a1078efc3fa9ab on meanjs:master.

LGTM

Great, let's add.

Coverage remained the same at 70.615% when pulling 9c57a79d4fdfea28cd230864b6a4463acc61d639 on mleanos:fix/users-github-strategy-email into f2a6bf9afd578373d4274c2dacc292cf13f527e8 on meanjs:master.

Coverage remained the same at 70.615% when pulling 9c57a79d4fdfea28cd230864b6a4463acc61d639 on mleanos:fix/users-github-strategy-email into f2a6bf9afd578373d4274c2dacc292cf13f527e8 on meanjs:master.

@ilanbiala I've cleaned up those long lines of code. LGTY?

:+1:

@mleanos strangely we don't have a linting rule for line length. Adding that would be nice for the future so we can catch extra long lines more easily.

Coverage remained the same at 70.615% when pulling bd6473738e138ad5fa4a7a5b2aa7f0d6979d918d on mleanos:fix/users-github-strategy-email into e3cd65f8d847dabb34bcab8b965ceb3af86c01fe on meanjs:master.

@ilanbiala I shortened the lines in the upgrade script to be less than 80 chars. As for the test line you mentioned, I shortened it as much as possible but it's still about 105 chars long. I didn't see any other way of shortening that line. Quite a bit of our describe() lines are longer than 80 chars.
If this looks good to you now, I'll merge.

LGTm.


HDFS-16218 RBF: Use HdfsConfiguration for passing in Router principle

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 20s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 16s

trunk passed

+1 :green_heart:
shadedclient
34m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 20s

the patch passed

+1 :green_heart:
shadedclient
33m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
30m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

146m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3444/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3444

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux fed5b022bdad 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4621602fa9024d4929d50b556c3281973d940892

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3444/1/testReport/

Max. process+thread count
2405 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3444/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Remove unnecessary characters from SQL queries

When a map is  instantiated, CARTO VL tries by default to do a GET request to the Maps API. If the request is too big, it switches to a  POST request. This prevents the request to be cached. When using carto.source.SQL the (lazy?) developer, usually just by convenience, can format the SQL query using plenty of carriage returns and tabs or spaces. If the library could remove those unnecessary spaces some requests would end up being made as GET, improving the general performance of the application with more requests cached.
Am I missing something? Are we doing already this at CARTO.js?

In CARTO.js, we try to use the user-defined SQL as it is with a GET request. If that doesn't work, we try to go with LZMA and a GET request. If all that fails, we go with a POST request. Reference: https://github.com/CartoDB/carto.js/blob/v4.1.11-0/src/windshaft/client.js#L79-L96
In CARTO VL, we are not attempting that LZMA compression step.
For reference, in the last 30 days, only 7% of the CARTO VL map instantiations happened via POST requests.
As you are proposing, let's start by applying what you are mentioning and see how that number changes. Otherwise, we should go with LZMA as it proved to be quite effective.


[Epic] Small business lending filing home

Milestone: View financial institution details
The small business lending filing app will be used by financial institutions to file their annual lending data, view past filings, view financial institution details for past filings and review data files for errors and warnings.
Epic: Small business lending filing home
Overview
The small business lending filing home is the starting point for filing small business lending data.
Tasks

[X] Make a list of the parts of the SBL filing home (based on HMDA filing home)
[X] Document any remaining filing home SBL components that have not been discussed in other issues
[X] Create a sketch of the full page

User stories
MVP (Beta release)

[ ] https://github.com/cfpb/sbl-project/issues/120
[ ] https://github.com/cfpb/sbl-project/issues/121
[ ] https://github.com/cfpb/sbl-project/issues/122
[ ] https://github.com/cfpb/sbl-project/issues/123
[ ] https://github.com/cfpb/sbl-project/issues/127

Backlog (post-MVP)

[ ] As a filer, I can see a list of inactive institutions I have filed for in the past.
[ ] As a filer, I can view the institution data snapshot for a past filing season.
[ ] As a filer, I can view the actions I have taken for a given filing period

Questions

How much consideration do we need to give now to all of the 2nd year+ scenarios?

A filer is told by SEFL they need to re-file after an exam.
A filer didn't file for a past year.

Are we going to have a 3-year window where we allow refiling like HMDA?

Requirements
Technical requirements

List item
List item

Content

Comprehensive instructions on the steps of the filing process.
Restart the filing process for a filing that was previously submitted

User testing
Research goals

Add here

Task ideation

Add here

Current mock-ups
Updated: MM/DD/YYYY
The purpose of this mock-up is to give an impression of how the components that I have shared might fit together. The details are all subject to change based on the design and functionality of the rest of the filing platform screens.

SBL filing home

@angelcardoz @natalia-fitzgerald three last questions for the task flow related to how we handle progress:

If a filing has been submitted, what actions can the user take? Currently we will show them that the filing is submitted. But should they be able to review the submission?
When it comes to showing progress for the filing process, one approach is to include the date that a page was last accessed or updated (or, a bit more user friendly, whether it's been updated since they last viewed the page). To me, this seems like a good way to go for steps like reviewing financial institution details where there's not as clear of a linear flow like there is for the file upload step. For the file upload step we would still include the progress indicator. What do you think of this proposal?
I've modified the task flow so that what the user sees on this page depends on what they've done:

If they haven't started, they only have a way to start the process
If they've started the process but haven't completed the file upload step, they see all the steps except the final one
Once their file is error free, they see the final step

The thought behind this approach is that it's another way to indicate progress: as you complete more steps, you have more actions available to you. Do you think this approach is worth pursuing?

@dan-padgett
I have some additional questions that are a little jumbled together (definitely broader than this epic) but hopefully some useful morsels in here.
Questions for discussion
What does a user gain in knowing that a step is in progress but not completed? If in progress simply means that any change was made (box checked, file uploaded, text input populated) wouldn't a user need to know what change was made for this progress status information to be useful? If they know something was done but don't know what then don't they have to review everything again anyway?
Zooming out a little further if a user can revisit any step in the filing process (or even if they can't) then no step is really ever complete until the filing is signed and submitted. The filing is in progress in all respects until the submit filing button is clicked. So when we say completed for a step or task what do we mean and what does this mean to a user?
Can a user come back and resubmit (changing whatever they wish) as many times as they wish until the filing deadline is reached or until a certain period is reached (3 years for HMDA?)?
Is the "Review financial institution details" step (which doesn't fit in the sequential flow) the one that is leading us to the need for prioritizing the visualization of the status of each step in the process on the homepage? If the steps were sequential would we still need this?
What does a user lose if they only see the current status more broadly (not started, in progress, complete) and they return to the next step (in other words the step which they have not yet clicked the save and continue for). If there is a need to allow them to jump around in the flow? If yes, an alternative to explore is giving them a way to do this within the filing process instead of from the filing home.
If "Review financial institution details" is outside of the sequential steps should we consider separating it out from the sequential steps/the filing flow without sacrificing the rest of the sequential flow? Maybe we could include a link on the financial institution card. And then we could include a review FI step (read-only) at the end of the filing process as a part of provide financial institution point of contact and sign and submit. Just brainstorming.
Or we can leave the review/update at the beginning and also put it at the end. So it doesn't stop the user from proceeding but it gets them to start thinking that they will need these details to be accurate before they file. At the end it could be an actual confirmation of the financial institution details (read-only) they are about to submit with their filing.
Speaking of which, what language do we need to communicate that the financial institution details must be accurate to file? Thus far there is no language to this effect in what we've built/are building. As a part of the "Review fi details" step we'll want to provide context as to why this content needs to be accurate.
What happens if the financial institution profile details (in our system) change before the filing deadline (either because of user requests OR because of data source updates)? Does the user's filing get updated with whatever is current in our system on the filing deadline date or does the information only reflect the financial institution details as true on the date of submission?

Reorganized epic content to match new epic template.


Conditionally required fields/columns

Currently, validation only applies to required (mandatory) columns - the exception MissingRequiredColumnError is raised whenever a column marked R in the respective schema is missing from a specific input file for that schema - but not conditionally required (CR) columns. CR columns such as deductibles and limits in, say, a loc. file, are required if there are policy financial terms applying to the locations relating to those columns, and there are some CR columns such as deductible and limit type and code columns which depend on the existence of deductible and limit columns.

Currently, querying the schemas (via oed columns info) does not allow querying for CR columns.

https://github.com/sr-murthy/oedtools/pull/11


[WIP] Electron 10 and other goodies

I'm using this as a status tracker for my progress in upgrading the app to electron 10. I have a bit of work to do still, but currently it loads the respective player interfaces and a good majority of stuff works on Ubuntu. This list is not exhaustive and I may update it as more issues arise. I will publish a branch as soon as I fix a few more smaller issues.
To Do:

[x] Refactor translation provider to use customElement since registerElement is obsolete.
[x] Get electron-rebuild working in electron 10
[ ] Figure out all of the "global" stuff like Settings / TranslationProvider / Emitters
[x] Upgrade build tooling / gulp so we can use node 12+

Upgraded to gulp 4, node 12/14 works. Removed all the release code in favor of electron forge.

[x] Remove obsolete settings that no longer apply
[ ] Test chrome flags for compatibility with newer version of electron such as hardware acceleration / 5.1 audio, etc.
[x] Retool release packagers / tooling

Upgraded to electron-forge. I don't have signing keys so that is untested. If the documentation is correct it should work.

[x] Linux
[ ] Windows
[ ] macOS

[ ] Ensure all tests still work with any modifications
[ ] Ensure all security related dependencies are up to date
[ ] Set YouTube music to the primary or only player (if GPM goes EOL before this is done)
[ ] Test Windows / Mac / Linux for native module support.
[ ] Upgrade mouse-forward-back to work with newer versions of electron and Context Switching
[ ] Sound appears to not work intermittently, need to do root-cause analysis.
[ ] Settings save, but don't update the UI live currently, seems like a react issue.
[x] Convert ll-keyboard-hook-win to NAPI for compatibility with electron 10. https://github.com/MarshallOfSound/node-lowlevel-keyboard-hook-win/pull/3

Being that this is going to be a slightly large over-haul, maybe we should upgrade to v5? I'll leave that open for discussion.
Now with code!

:wave: Is there anything Simple on your To do List which might be worth attempting to do?
Additionally is there any testing ETC needed done.
I'm interested in getting this project started back up, but don't know if I'm biting to much than I can chew.

Removing GPM would probably be an easier one considering it's just removing a bunch of code, if you want to fork my repository and make a PR there so this can remain as one PR that would work.

Additionally are you looking to update to NodeJS 12?
As for Win10 the Optional Dependencies for for the nodert-win10 collection of packages, ALL still required NodeJS 6->10 due to the warning C4996: '{TYPE OF SOME FORM}': was declared deprecated
Otherwise I'll look to stripping the features of only GPM as that'll probably be a good start to this 😄

There are a ton of issues in Mac / Windows that I haven't gotten to yet. I run primarily Linux so that's what I tackled first.

Thank you for working on this!

I am hopeful to see an update to GPMDP. Love to use it for my workdays full of background music.
Thank you 🌸.

The work has stopped apparently, unfortunately. And I know it's out of topic, but YTM isn't as nice as GPM was. So motivation to work on such software maybe less than it used to be.

I wish someone would fork this and continue the work. This repository is basically abandoned.
But I agree YTM isn't as nice and maybe people jump ship to Spotify.


RFC: Avoid double-indirection of Arc<Vec> by using Arc<[u8]> directly

The second commit removes any per-access overhead to WritablePage but at the cost of some unsafe code relying on the uniqueness that was asserted once by calling Arc::try_unwrap before this change.

I'm not seeing a speed-up in https://github.com/cberner/redb/blob/master/benches/lmdb_benchmark.rs
Is there a benchmark where you were able to measure a significant speed-up from this?

I'm not seeing a speed-up in https://github.com/cberner/redb/blob/master/benches/lmdb_benchmark.rs
Is there a benchmark where you were able to measure a significant speed-up from this?

This was not driven by benchmarks for me. I just stumbled over this while looking something else up in the code.
I would say that there is usually never a reason to use Arc<Vec<T>> instead of Arc<[T]> as the Arc layer implies shared access. For redb, these pages are also never resized so that even with temporary mutable access, the unused capacity of the Vec is not necessary. So for me, this was this was strictly a simplification.
Of course, the situation is a bit more complex here as the WritablePage depends on mutable access through the Arc which I would agree that it is not a trivial change.
So if there are benchmark changes, I would expect them to be positive, but this was not my motivation. I would sort any performance changes under "distributed fat" as I would expect increased TLB/cache pressure from the additional indirection and possible heap fragmentation.

Got it, I see. The first commit looks good then, but I don't want to add the unsafe commit unless there's a really clear performance benefit. I'd like to remove the last of the unsafe code from redb, but need to get file lock support into std to replace the libc usage.
Want to remove the second commit, and I'll merge the first?

Want to remove the second commit, and I'll merge the first?

I did put that into a separate commit to make it easy to drop. I added it all because Arc:get_mut is then called for each mutable page access and I feared that this would actually impact performance. Did you already run the benchmark without the last commit? If so, I'll just drop.
Otherwise, I'll do that and if it has an impact I'll try to figure something to avoid that without unsafe.

but need to get file lock support into std to replace the libc usage.

Not sure if you want to take on another dependency, but rustix does have safe file locking: https://docs.rs/rustix/latest/rustix/fs/fn.flock.html (rustix is really widely used and almost similar to libc in scope. It is also already a transitive dev-dependency via tempfile. So while not obvious, I think it might make sense to replace this.)

Not sure if you want to take on another dependency, but rustix does have safe file locking: https://docs.rs/rustix/latest/rustix/fs/fn.flock.html (rustix is really widely used and almost similar to libc in scope. It is also already a transitive dev-dependency via tempfile. So while not obvious, I think it might make sense to replace this.)

Ok, I tried but while it does work, there is still Windows which is out of scope for rustix and F_BARRIERSYNC on macOS which it does not yet support.

I dropped the last commit after running the lmdb_benchmark on my notebook. The results are somewhat noisy so I think you'll want to run this again yourself to make sure. I do see small but consistent improvements for random reads, and without the second commit I rarely see small regressions for writes, but not always.
As I said, it is quite noisy and I am not sure what to make of it. (My hardware especially the disk are decidedly consumer-grade.)

Ah, I found a way to at least avoid the option dance without unsafe code at the cost of an otherwise unnecessary reference increment-decrement-pair. Pushed that as a separate commit.

Ok, I also reran the benchmark after changing to run from a ramdisk to take my shitty reasonably-priced disk out of the picture and tease out the CPU overhead of managing the cache.
With that I am now reasonably confident that this does not introduce undue overhead and yields small but consistent improvements:

PR
master

bulk load
2673ms
2791ms

individual writes
3ms
3ms

batch writes
1291ms
1299ms

len()
0ms
0ms

random reads
1137ms
1335ms

random reads
1026ms
1203ms

random range reads
2864ms
3080ms

random range reads
2861ms
3069ms

random reads (4 threads)
275ms
321ms

random reads (8 threads)
171ms
193ms

random reads (16 threads)
148ms
157ms

random reads (32 threads)
131ms
137ms

removals
2000ms
2069ms

Merged. Thanks!


Wont install on BS 1.28

{
"_QPVersion": "0.1.1",
"name": "Adblock",
"id": "adblock",
"author": "Waffle",
"version": "0.1.0",
"packageId": "com.beatgames.beatsaber",
"packageVersion": "1.27.0_3631150051",
"description": "???",
"dependencies": [
{
"version": "^0.32.0",
"id": "codegen",
"downloadIfMissing": "https://github.com/sc2ad/BeatSaber-Quest-Codegen/releases/download/v0.32.0/Codegen.qmod"
}
],
"modFiles": [
"libAdblock.so"
],
"libraryFiles": [
"libbeatsaber-hook_3_14_0.so"
],
"fileCopies": [],
"copyExtensions": []
}

Says its for BS 1.27

Wrong package version and wrong codegen version in mod.json file

An update to 1.28 would be nice.


Progress Indicator Bar

Progress bars on the months list page to show percentage progress through the required fields list for each month.
Could base in on http://dotnet.dzone.com/news/building-star-rating-system

Progress doesn't make sense since we cannot determine what progress looks like.  Implemented summary as an alternative b064c125b30400274174ced6467fbc4892d448df