Question: component props type definition

Hi!
You are using export const Component: VueConstructor<Vue>; for component typings. Do I correctly understand that there is no way to add props type definition in Vue 2?
I looked at how Vuetify did this.
https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/types/lib.d.ts#L17
It uses the same solution. Will it be enough for users?
Thanks.

This question is not something that directly affects how vue-sfc-rollup works, and as you indicated, the scaffolded code already matches some pretty well documented usage. Closing as a non-issue, though it is a good thing to research independently.


Update cancel-machine-action.md

Update the document permissions

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/6062


don't call subgraph methods, they're broken

SubgraphWith{Leaves,Roots} doesn't seem to work, and aren't effectively called by anything today anyway. Remove those calls while Jon fixes the methods, and we can readd them.

😢

They'll be back!


Update Cargo.lock

Update libc to v0.2.154 to support LoongArch64.
Release notes :https://github.com/rust-lang/libc/releases

Thanks!


fix(versions): update Activiti/activiti-cloud-api versions into develop

UpdateBot pushed maven dependency: org.activiti.dependencies:activiti-dependencies to: 7.1.118

UpdateBot commands:
updatebot push-version --kind maven org.activiti.dependencies:activiti-dependencies 7.1.118 org.activiti.api:activiti-api-dependencies 7.1.58 org.activiti.core.common:activiti-core-common-dependencies 7.1.65 org.activiti.build:activiti-parent 7.1.32

Covered by https://github.com/Activiti/activiti-cloud-api/pull/96


Appending to an undefined array produces a new array

Hey again folks.
Looks like doing R.append('hey', undefined) returns ['hey'], not sure if this is intended behavior or not, but it seems to me that this should throw an error, seeing as appending to undefined is an invalid operation. Happy to submit a fix if so.
https://ramdajs.com/repl/?v=0.25.0#?R.append("hey"%2C undefined)

Nope, thats perfectly reasonable. Just wanted to make sure this was intentional. Thanks!


How can I use @context?

[ ] The API section says that @context exists. It's obvious to some Ember users that you mean <Toggle @context=..., but not to all an example how to pass in context would be good
[ ] Can I then grab the mutated @context data back in my template? How?

I think you PR'd both of these? (and they're now merged?)

Fixed in #192


[BUG] Rancher pods are restarting periodically on latest version (v2.7.5)

Rancher Server Setup

Rancher version: v2.7.5
Installation option (Docker install/Helm Chart): Helm Chart From Rancher Stable

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): EKS 1.23

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.23.17-eks-***
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions:

Describe the bug

Rancher pods are restarting periodically, From the logs it appears somewhere it is triggering a race condition and the error from golang Stack trace is
fatal error: concurrent map iteration and map write
Expected Result

No pod restarts
Screenshots

This is what we see in logs before the restart happens

The same issue happens in the cluster agents. Random restarts because of a concurrent map write error.

@00r2 Can you post the full stack trace? It looks like it's cut off at encode.go, the full stack trace would make it much easier to diagnose.

@jakefhyde  Thank you Jake for responding. The stack trace has over 100k lines, but here is a sample from one of the restarts
extract-2023-11-20T22_58_23.777Z.csv


Add Mission Journeys

Related to Issue #92

TODO: once we have implemented both BE and FE parts of this feature, the team will need to do some manual testing before merging with master.


IREE compilation fails on TOSA-imported tflite models since candidate-20230525.530

What happened?
Since IREE candidate-20230525.530, iree compllation has failed for TOSA-imported tflite models. The error message is error: 'tosa.avg_pool2d' op requires attribute 'acc_type'. The issue doesn't exist for candidate-20230524.529 or earlier releases.
Steps to reproduce your issue

Build IREE
Use person.detect.tflite as an example, which can be downloaded from https://storage.googleapis.com/iree-model-artifacts/person_detect.tflite
Import TFLite model
/path/to/iree-import-tflite /path/to/person_detect.tflite -o=/tmp/person_detect.mlir
Use iree-compile to compile TOSA MLIR
/path/to/iree-compile -iree-input-type=tosa -iree-hal-target-backends=llvm-cpu /tmp/person_detect.mlir
See error
error: 'tosa.avg_pool2d' op requires attribute 'acc_type'
note: see current operation: %114 = "tosa.avg_pool2d"(%113) <{kernel = array<i64: 3, 3>, pad = array<i64: 0, 0, 0, 0>, quantization_info = #tosa.unary_quant<input_zp = 0, output_zp = 0>, stride = array<i64: 2, 2>}> : (tensor<1x3x3x256xi8>) -> tensor<1x1x1x256xi8>
note: in bytecode version 0 produced by: MLIR17.0.0git

What component(s) does this issue relate to?
Compiler
Version information
IREE candidate-20230525.530
Additional context
I further nailed down the issue to this commit: https://github.com/openxla/iree/pull/13666

@jpienaar @hcindyl

It appears that the issue is that the tf-nightly version in our side did not match with IREE (https://github.com/openxla/iree/blob/main/integrations/tensorflow/test/requirements.txt), so it's not an IREE issue. Closing it.

It appears that the issue is that the tf-nightly version in our side did not match with latest IREE (https://github.com/openxla/iree/blob/main/integrations/tensorflow/test/requirements.txt), so it's not an IREE issue. Closing it.

@jpienaar What's the plan for the tensorflow package dependency? Do we plan to always pick the latest TOSA API change via tf-nightly, or Does IREE plan to pin to an TensorFlow stable release? I know 2.13.0-rc0 was cut, but not sure what the plan of the team is.

We plan on pinning to latest nightly needed, unfortunately we are missing an interchange/set of functions here that would enable pinning to stable alone. I'll start a discussion on that, but we might have to rely on the same nightly for a bit.

Can we encode the compatible version range in pyproject.toml or requirements.txt, so that python-m pip install --find-links https://openxla.github.io/iree/pip-release-links.html --upgrade iree-tools-tflite gets people something usable (or fails early)?

At the expense of risking some cargo-culting of only partially considered Python code, have a look here: https://github.com/openxla/openxla-pjrt-plugin/blob/main/python_packages/openxla_cuda_plugin/setup.py#L41
That grabs version pins dynamically in setup.py from the project requirements.txt file and converts the (CI friendly) specific version pins with user friendly(er) ranges.


Automator: update istio/gogo-genproto@master dependency in istio/istio@master

Generated by Automator - 2021-06-30T14:35:17+00:00

@istio-testing: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
5315a885127e28d435137e32d6d1b0f8923dc30e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio


Make sure any pointer being passed to RustPOSIX is 8-byte aligned

We're updating our rust compiler version when we merge the domain socket branch. This fortunately/unfortunately revealed a bug where it was possible to convert pointers that arent 8-byte aligned that rust just let slide before this version (even though thats technically undefined behavior).
@RusherRG found this bug with the updated compiler when testing bind"
thread '<unnamed>' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0x64c810067d1c', src/interface/types.rs:435:61

This has the effect of giving a venue to force a trusted fault from user code. We should check all pointer alignment in NaCl before we call to RustPOSIX, and if theyre not aligned return an error.

We should be able to do this easily in our pointer conversion functions since we use them for all pointer translation. Let's do a check in NaClUserToSysAddrRangeProt and NaClUserToSysAddrProt for 8-bit alignment and if not return an error.

We'll need to run all tests for this to make sure it doesn't break anything.


chore: bdd-nh-1589804949 to 0.0.1

chore: Promote bdd-nh-1589804949 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Make the lib usable in browser, commonjs and esm environments

I want to be able to use the library in all environments mentioned in the title

[ ] ESM
[ ] CJS
[ ] Browser (bundle crc32 function)

[ ] ESM
[ ] Global window object

Additionally to ensure proper support in all major browsers, the following section of generateZipData need some attention:
https://github.com/makl11/zipper.js/blob/0b628aee58234f3384f9b48b91dee9b3a3ff29e4/index.js#L310-L314
Currently only Firefox implements @@asyncIterator for ReadableStream


Fix required prop types for classes with annotated methods.

The react/prop-types rule incorrectly considers  flow type
annotations on class methods with arguments named props as
prop type declarations for the class, even though flow itself
gives them no such weight.
When a react component is defined as a class extending React.Component,
and it defines a method that takes an annotated argument named props,
then, even though flow still thinks the props have any type, the
prop-types rule will not produce 'missing in props validation' errors.
A pattern that gets used a lot in React components is as follows:
type Props = {...};
class Comp extends React.Component {
  constructor(props: Props) {
    super(props);
    // do something...
  }

  // ...
}

which makes this especially nefarious.

I've rebased this to fix the merge conflicts and bring the branch up to date -- could we get it merged this time?

@yannickcr it'd be great to get a release out with this fix in it; any chance you'll have time soon?

@ljharb, I think this one is actually fixed by the latest flow (first change listed here) -- might be irrelevant now or possibly even wrong. I haven't tested the new flow, but I suspect this should be reverted.

We need to support both versions of flow, so reverting it wouldn't work by itself


function: catch earlier programming error

Place at first line of the function body a function type safe guard
check.

@duke-git please review this pull request.

Codecov Report

Merging #8 (5e5ae92) into main (0b0eb69) will increase coverage by 0.06%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   78.02%   78.08%   +0.06%
==========================================
  Files          21       21
  Lines        1397     1410      +13
==========================================
+ Hits         1090     1101      +11
- Misses        206      207       +1
- Partials      101      102       +1

Impacted Files
Coverage Δ

function/function_util.go
80.95% <80.00%> (-0.87%)
:arrow_down:

function/function.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0eb69...5e5ae92. Read the comment docs.

@duke-git please review this pull request.

@donutloop reasonable, will merge it.


fix RMC soundness bug

This did change where one error was issued in BindChannel.java, which seems to be the test case that changes the most. I think that's fine. The reason is that there's a two-alias set in defs before bind is called containing both locals, but after there's only the one-alias set containing the second local (so the error is issued at the second local instead of the first).
I believe that this aligns the implementation with what you were describing for the paper, for the most part - there's still the split between the MCC and MCIC, but that's probably okay.
I did keep the owning logic in place, so reset.not.owning errors do still get issued. The basic premise of the owning logic is that there has to be something which takes ownership of the result. I think we only track must-alias for things in the def set, but if that's not the case this might still be unsound.

@msridhar I ran with this change on Zookeeper, and it produces four new false positives. Of these one looks like this:
            this.ss = ServerSocketChannel.open();
            ss.socket().setReuseAddress(true);
            LOG.info("binding to port {}", addr);
            ss.socket().bind(addr); // This call to bind is now rejected
            ss.configureBlocking(false); // <- note that this is a TP...

The call to bind is now rejected, because ss.socket() isn't an owning expression, and we no longer allow resolving an owning expression via a resource alias, which is what's going on here.
I think this is a false positive, but I'd appreciate your opinion.
The other three cases are very similar. There's a class that extends ServerSocket. It overwrites most of ServerSocket's methods to look like this:
        /**
         * See {@link Socket#connect(SocketAddress, int)}. Calling this method does not trigger mode detection.
         */
        @Override
        @ResetMustCall("this")
        public void connect(SocketAddress endpoint, int timeout) throws IOException {
            getSocketAllowUnknownMode().connect(endpoint, timeout);
        }

We issue errors on the three overwrites of ServerSocket's reset methods, because we can't check that getSocketAllowUnknownMode's result is okay. Here's its definition:
        @NotOwning private Socket getSocketAllowUnknownMode() {
            if (isSecureSocket()) {
                return sslSocket;
            } else { // Note: mode is UNKNOWN or PLAINTEXT
                return prependableSocket;
            }
        }

(those are both owning fields of the class)

            this.ss = ServerSocketChannel.open();
            ss.socket().setReuseAddress(true);
            LOG.info("binding to port {}", addr);
            ss.socket().bind(addr); // This call to bind is now rejected
            ss.configureBlocking(false); // <- note that this is a TP...

One thing that bothers me about this example is that I don't know how to rewrite the code so that it would type check.  My intuition is that maybe we can eventually extend the checker to verify this case.  My argument is that since ss.socket() is MCC with an @Owning field, we should treat this case like code that overwrites a non-final @Owning field.  I.e., if there is a @ResetMustCall("this") annotation on the enclosing method, it should pass our checker.  I haven't worked out the details, though, and it's not urgent.

One thing that bothers me about this example is that I don't know how to rewrite the code so that it would type check. My intuition is that maybe we can eventually extend the checker to verify this case. My argument is that since ss.socket() is MCC with an @Owning field, we should treat this case like code that overwrites a non-final @Owning field. I.e., if there is a @ResetMustCall("this") annotation on the enclosing method, it should pass our checker. I haven't worked out the details, though, and it's not urgent.

I think this is a fundamental design problem with @ResetMustCall. It abstracts away the details of what is actually being reset, and in this case we need to know that bind is going to overwrite the underlying socket specifically, as opposed to the more general "reset" to the Socket object. In theory these two are equivalent - since Socket only has one resource - but the abstraction has no way of being aware of that (right now).


Add ForDifferenceRange & use it for gs neg loops

Adds new ForDifferenceRange node for loops that specify start and a different between start and end
Renames range's low/high to start/end since step can be negative
Fixes type inference for ranges with negative steps
Adds tests

An issue seems to arise from forRangeToForDifferenceRange being a final emit plugin and generating a sub polygolfOp.  This doesn't work for the diff range plugin, I assume because golf plugins aren't run after final emit plugins.
$a:-10..10 <- -4;
for $i $a 1 {
  println $i;
};

compiles to gs as
-4:a;a-1*1+,{a+:i;i puts}%

rather than the preferable
-4:a;1 a-,{a+:i;i puts}%

Otherwise looks good :thumbsup:

That issue is actually unrelated to the PR,
$a:-10..10 <- -4;
println (1 - $a);

compiles to
-4:a;a-1*1+puts

The emit plugin mapToUnaryAndBinaryOps should be improved to better handle these.


Swap (unsigned long long) for (long long) to fix narrowing error

I'm going to assume that long long is wide enough for the macro.  Thank you @edawson for the PR!


[types] move AuthenticationKey to TransactionAuthenticator

plus associated refactoring/simplifications:

add separate type for AuthenticationKeyPreimage
use an enum for signature scheme

Motivation
Cleanup promised in 24f1673da36d9562711222de4747163ead29c7bf
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Should be pure refactoring

@bors-libra r=davidiw

:pushpin: Commit fda6990 has been approved by davidiw

:hourglass: Testing commit fda699047067ff48330f8ad93435d1d324557744 with merge c5fbd56ab9593aa8674b017cb678cbe16d78d5fc...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=davidiw

:pushpin: Commit e22117e has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit a3a1ef7 has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit 3ba4099 has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit be8a284 has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit 4dacb9d has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit bd3c9a0 has been approved by davidiw

@bors-libra retry

@bors-libra r=davidiw

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #3009

:pushpin: Commit bd3c9a0 has been approved by davidiw

@bors-libra r=davidiw

:pushpin: Commit 1d483ba has been approved by davidiw

:hourglass: Testing commit 1d483ba189c5f1fc52d61a676d34c2e30baa1d38 with merge 8530581d485aa99f7fa67ca85fde926fe97d2d8a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 8530581d485aa99f7fa67ca85fde926fe97d2d8a to master...


esp_restart() issue (IDFGH-6566)

Environment

Development Kit:  none
Module or chip used: ESP32-WROOM-32U
IDF version:  v5.0-dev-382-g098dfe8a08
Build System: CMake
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2020r1) 8.2.0
Operating System: Linux
Power Supply: external

Problem Description
LoadProhibited exception on boot after calling esp_restart()
....
W (4458) device: Factory reset
I (5118) wifi:state: run -> init (0)
I (5118) wifi:pm stop, total sleep time: 2392006 us / 3791625 us
W (5118) wifi:idx
I (5118) wifi:new:<9,0>, old:<9,1>, ap:<255,255>, sta:<9,1>, prof:1
I (5138) wifi:new:<9,1>, old:<9,0>, ap:<255,255>, sta:<9,1>, prof:1
I (5138) wifi:state: init -> auth (b0)
I (5138) wifi:state: auth -> assoc (0)
I (5148) wifi:state: assoc -> run (10)
I (5158) wifi:state: run -> init (0)
I (5158) wifi:new:<9,0>, old:<9,1>, ap:<255,255>, sta:<9,1>, prof:1
I (5218) wifi:flush txq
I (5218) wifi:stop sw txq
I (5218) wifi:lmac stop hw txq
I (5238) wifi:Deinit lldesc rx mblock:4
W (5298) device: Factory reset done. Rebooting ...
ets Jun  8 2016 00:22:57
**rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0038,len:9612
ho 0 tail 12 room 4
load:0x40078000,len:24908
load:0x40080400,len:3464
0x40080400: _init at ??:?
entry 0x40080638
Fatal exception (28): LoadProhibited
epc1=0x4007bf1b, epc2=0x00000000, epc3=0x00000000, excvaddr=0xa34f0000, depc=0x00000000
ets Jun  8 2016 00:22:57**
rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0038,len:9612
ho 0 tail 12 room 4
load:0x40078000,len:24908
load:0x40080400,len:3464
0x40080400: _init at ??:?
entry 0x40080638
I (832) cpu_start: Pro cpu up.
I (832) cpu_start: Starting app cpu, entry point is 0x400816bc

Hi @fpgamaster ,
I tried to reproduce the issue, with the same issue and the same board and same commit ID, but I was unable to. Can you provide a minimal example to reproduce the issue?

Hi @o-marshmallow,
Unfortunately it is not a small project and it is not easy to extract something as a minimal example :(
The project was moved from  v4.2 where this issue had never happened.
I saw that the esp_restart() function is refactored in v5 but I have not looked too deep in it.
Best regards

@fpgamaster
Fatal exception (28): LoadProhibited happens before cpu_start: Pro cpu up.
Can you provide the sdkconfig?

Hi @AxelLin,
All diffs of the sdkcondid are in sdkconfig.default
CONFIG_BOOTLOADER_SKIP_VALIDATE_IN_DEEP_SLEEP=y

CONFIG_BOOTLOADER_LOG_LEVEL_WARN=y
CONFIG_SECURE_BOOT=y
CONFIG_SECURE_BOOTLOADER_REFLASHABLE=y
CONFIG_SECURE_FLASH_ENC_ENABLED=y
CONFIG_ESPTOOLPY_FLASHSIZE_4MB=y
CONFIG_PARTITION_TABLE_CUSTOM=y
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="parts_ota.csv"
CONFIG_PARTITION_TABLE_OFFSET=0x10000
CONFIG_COMPILER_OPTIMIZATION_SIZE=y
CONFIG_BT_ENABLED=y
CONFIG_BTDM_CTRL_BLE_MAX_CONN=4
CONFIG_BTDM_CTRL_FULL_SCAN_SUPPORTED is not set
CONFIG_BT_NIMBLE_ENABLED=y
CONFIG_SPI_MASTER_ISR_IN_IRAM is not set
CONFIG_SPI_SLAVE_ISR_IN_IRAM is not set
CONFIG_ESP32_REV_MIN_1=y
CONFIG_ESP32_ULP_COPROC_ENABLED=y
CONFIG_ESP32_ULP_COPROC_RESERVE_MEM=7936
CONFIG_ESP32_RTC_CLK_SRC_EXT_OSC=y
CONFIG_ESP32_RTC_CLK_CAL_CYCLES=1024
CONFIG_ETH_USE_ESP32_EMAC is not set
CONFIG_ETH_USE_SPI_ETHERNET is not set
CONFIG_ESP_HTTP_CLIENT_ENABLE_HTTPS is not set
CONFIG_ESP32_UNIVERSAL_MAC_ADDRESSES_TWO=y
CONFIG_ESP_NETIF_TCPIP_ADAPTER_COMPATIBLE_LAYER is not set
CONFIG_ESP_PHY_INIT_DATA_IN_PARTITION=y
CONFIG_PM_ENABLE=y
CONFIG_ESP32_WIFI_STATIC_RX_BUFFER_NUM=4
CONFIG_ESP32_WIFI_DYNAMIC_RX_BUFFER_NUM=8
CONFIG_ESP32_WIFI_DYNAMIC_TX_BUFFER_NUM=16
CONFIG_FREERTOS_GENERATE_RUN_TIME_STATS=y
CONFIG_FREERTOS_USE_TICKLESS_IDLE=y
CONFIG_LWIP_SO_RCVBUF=y
CONFIG_LWIP_DHCP_DOES_ARP_CHECK is not set
CONFIG_LWIP_TCP_SYNMAXRTX=6
CONFIG_MBEDTLS_SSL_IN_CONTENT_LEN=4096
CONFIG_MBEDTLS_PSK_MODES=y
CONFIG_MBEDTLS_KEY_EXCHANGE_PSK=y
CONFIG_MBEDTLS_SSL_PROTO_TLS1 is not set
CONFIG_MBEDTLS_SSL_PROTO_TLS1_1 is not set
CONFIG_MBEDTLS_SSL_PROTO_DTLS=y
CONFIG_MBEDTLS_DHM_C=y
CONFIG_MQTT_PROTOCOL_311 is not set
CONFIG_MQTT_TRANSPORT_SSL is not set
CONFIG_MQTT_TRANSPORT_WEBSOCKET is not set
CONFIG_NVS_ENCRYPTION is not set

It seems that sometimes esp_restart() does not trigger this exception, mostly after the first power on.
If someone wants to reproduce this let's wait for a few restarts.
Also, I am observing some issues with the ULP code running after a reboot using esp_restart().
It looks like the hardware is not in the same state as it is after a power on.
I get strange readings from ADC1 which may be related to GPIO state or ADC registers state or something else.

Does this issue happen when ULP is disabled?

Marking this one as closed as with the current information it wasn't possible to reproduce or give much debug feedback.
If you are still experiencing this issue and want to continue debugging it please re-open the issue and ill take a look at it


Connectivity Issue with pgcat after AWS Aurora PostgreSQL DB Failover

After an AWS Aurora PostgreSQL failover, the pgcat connects to the read replica and fails to automatically recover. The client expects to connect to the write replica, but the connection on pgcat remains connected to the read replica. This issue may be related to DNS cache. We need a viable solution to resolve this problem.

close by https://github.com/postgresml/pgcat/pull/249


Transition to JupyterLab 2.0.0

JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. This PR is me following the JupyterLab migration guide referenced below, as I have now done for many other repositories successfully.
PR Summary

I bump the version of this npm package to 0.2.0 from 0.1.6 in package.json.
I bump the @jupyterlab/... dependencies one major version.
I replace @phosphor with @lumino.
I updated this extension to align with practices from the cookiecutter template used to generate the repo initially, this was done in the final commit 1f9c504.
Releasing this will not break existing use of JupyterLab 1, but they will stay behind if new features are added, and the new features will only be available in JupyterLab 2.

References

Change log for developers
A migration guide

I think you can delete package-lock.json and update tsconfig.json like this

@zhytang ah that would make everything more in line with the current cookiecutter template to create a jupyterlab extension, but I didn't see package-lock.json be in the .gitignore, so I think the cookiecutter is opinionated towards including it.
https://github.com/jupyterlab/extension-cookiecutter-ts/tree/master/{{cookiecutter.extension_name}}

when NPM is used to publish packages, package-lock.json will not be published, so I think we can add it to the .gitignore.
It's just a suggestion

@zhytang i updated this extension based on the jupyterlab extensions cookiecutter repo: https://github.com/jupyterlab/extension-cookiecutter-ts
I didn't remove package-lock.json as it would go against the typical practice I've seen across many other jupyterlab extensions as well as this repo.

@chaoleili if you have time, this is ready for review/merge I'd say!

@chaoleili if you have time, this is ready for review/merge I'd say!

Thanks a lot for your contribution! 🎉


ViewportTexture is vertically mirrored in GLES2

Godot version:
Godot 3.1 alpha 4
OS/device including version:
Manjaro Linux, Radeon RX 560
Issue description:
ViewportTextures appear mirrored in GLES2, but look correct in GLES3. Here is a simple 3D scene captured by a camera and displayed in TextureRect:
GLES3:

GLES2:

Minimal reproduction project:
ViewportTexture.zip

8b77dac56e375698cdd28bc6033d076c600a5a19


Adds config commands

Coverage remained the same at 100.0% when pulling 4da1a77fb6e87acffd702acaeb4b6540bef8ea39 on command/config into ab1a7796a514273f65c9995684f04c8c2c93c8a6 on master.


RSS links into Twitter and Facebook

Hi Adam,
I was previously using IFFT to link the RSS feeds from the newsblog into our twitter and facebook feeds. I'm guessing this creates a security vulnerability if we have to give them our twitter and facebook log in details. Is it still worth using them? Do you have any alternative suggestions for linking it up so we get automatic posts from any newsblog stories.
Also when you link to the newsblog we could do with pulling through some better social media data. Perhaps pulling through our NO2ID logo etc. If we called the Newsblog the NO2ID Newblog that would make more sense too I think.

https://jetpack.com/support/publicize/ is enabled (linking to social accounts through this plugin uses oauth, not passwords).


RG353M: after using HDMI, can't use built-in screen anymore

Describe the Issue (If applicable)
After using HDMI, on reboot I can no longer use the built-in screen (it's blank) despite the fact that the system is otherwise fully functional (it's not frozen or locked).
How can the issue be reproduced? (If applicable)
If I boot into ArkOS with the HDMI cable, everything works great on my monitor. After a proper shut-down, I remove the cable and boot, on the built-in screen, I see the ArkOS boot logo, and the ArkOS booting "dots" and then the screen goes blank. I can still navigate and launch games (you can hear the games launch, you just can't see them). If I shut down (Fn-Power) and then boot with HDMI cable again, everything is fine through the monitor.
So the system is fine, but using HDMI basically puts it permanently into an HDMI-only mode and get's stuck that way, whether HDMI plugged in or not.
The only fix I've found is a full restore from backup of the boot SDCARD.
What device are you using?
RG353M v2 screen
What version of ArkOS are you on?
v2.0 02/25/2023 Update (v<IP_ADDRESS>.2023)
Anything else you'd like to include that may help to review this issue or feature request?

Try replacing the dtb again..

First, thank you for giving a great thorough description of the issue using the issue template.  I truly appreciate this!  I was able to easily replicate the issue following the description and found that this issue happens due to the color profile feature I added from the last update.  On shutdown, it saves an updated profile and if it can't find a good value, it just makes that particular value 0.  When brightness, contrast, saturation, and hue are set to 0, you get a black screen.  I'll put a failsafe in place to prevent that in an update I'll release shortly.

First, thank you for giving a great thorough description of the issue using the issue template. I truly appreciate this! I was able to easily replicate the issue following the description and found that this issue happens due to the color profile feature I added from the last update. On shutdown, it saves an updated profile and if it can't find a good value, it just makes that particular value 0. When brightness, contrast, saturation, and hue are set to 0, you get a black screen. I'll put a failsafe in place to prevent that in an update I'll release shortly.

Thank you! Glad it was helpful, and I look forward to the fix.

Update is released.  Thanks again for reporting this issue.


RFP - GeoGebra Geometry

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://www.geogebra.org/download
Direct download URL for the software / installer : https://download.geogebra.org/package/windows-geometry
Software summary / short description: Basicly a geometry calculator. New program, not included in geogebra or geogebra6 community packages.

Status: Review
https://chocolatey.org/packages/graphingcalculator

Status: Review
https://chocolatey.org/packages/geogebra-geometry

Thank you.

Status: Published

https://chocolatey.org/packages/geogebra-geometry

Can be closed.


www/web-proxy-useracl: Non-existent method called

https://github.com/opnsense/plugins/blob/3fba5e1ca1839f3814fa0b9e9343927c724fa6d0/www/web-proxy-useracl/src/opnsense/mvc/app/controllers/OPNsense/ProxyUserACL/Api/SettingsController.php#L96
https://github.com/opnsense/plugins/blob/3fba5e1ca1839f3814fa0b9e9343927c724fa6d0/www/web-proxy-useracl/src/opnsense/mvc/app/controllers/OPNsense/ProxyUserACL/Api/SettingsController.php#L160
No such method OPNsense\Proxy\Api\SettingsController::encode.
Therefore, group addition in plugin interface not working.

It use https://github.com/opnsense/core/pull/1892

we haven't even built the first dev version yet :D
this will take a while, also needs a tools git refresh for php70-intl

Okay, thanks a lot!
@kekek2 very wonderful plugin! (offtop) Are you planning to implement filtration by categories, not only by URLs? I'm ready to help if you need.

was merged to core just now, thanks! https://github.com/opnsense/core/commit/baab54de6

@mmorev could you tell in detail about the categories ?

@kekek2 I mean URL Filtering configured on page "Services->Web Proxy->Administration->Remote ACLs". Currently, if I block public mail services there, for example, they are blocked for all users. Can we combine squid acl entries created by URL filtering with ones created by your plugin into single http_access rule set?
For example: "http_access allow ext_group_ldap_0 remoteblacklist_publicmail".
squid http_access directive uses 'and' logic in case multiple acl names specified.
Minor changes to remoteACLs module may be needed.


Lint errors: renter/proto + hostdb/hosttree

Also added renter/hostdb/hosttree, but didn't have any lint errors.
#2702

thanks!


Desktop GUI has some features not appearing in French

Describe the bug:

XFCE VNC does not get fully localized into French (first image below) after installing the locale and setting the environment variables.
Expected behaviour:

The XFCE installed applications (using thunar as an example) to appear in French (second image below).
Steps to reproduce the issue:
In a docker file
FROM mltooling/ml-workspace-minimal:0.12.1
RUN \
    apt-get update && \
    apt-get install -y locales && \
    sed -i -e 's/# fr_FR.UTF-8 UTF-8/fr_FR.UTF-8 UTF-8/' /etc/locale.gen && \
    locale-gen && \
    dpkg-reconfigure --frontend=noninteractive locales && \
    clean-layer.sh
ENV LANG=fr_FR.UTF-8 LANGUAGE=fr_FR.UTF-8 LC_ALL=fr_FR.UTF-8

Build: sudo docker build -t mltest
Run: sudo docker run --rm -p 8080:8080 mltest
Navigate to desktop gui
Technical details:

Workspace version: 0.12.1 (base)
Docker versionL: 20.10.0
Host Machine OS (Windows/Linux/Mac): Linux
Command used to start the workspace : sudo docker run --rm -p 8080:8080 mltest
Browser (Chrome/Firefox/Safari): Firefox

Possible Fix:
I don't know :(
Additional context:
I've looked at and extended just an xfce specific image here and was able to get the UI to fully appear in French (see second image below). That image is based on ubuntu:16.04.

I would instead expect something like

Hey @Ito-Matsuda,
could you try out the following please:

Open a terminal in your running workspace

Execute the following commands to set the locale:
echo 'export LC_ALL=fr_FR.UTF-8' >> ~/.xsessionrc
echo 'export LANG=fr_FR.UTF-8' >> ~/.xsessionrc
echo 'export LANGUAGE=fr_FR.UTF-8' >> ~/.xsessionrc

sed -i -e 's/# fr_FR.UTF-8 UTF-8/fr_FR.UTF-8 UTF-8/' /etc/locale.gen && \
locale-gen && \
dpkg-reconfigure --frontend=noninteractive locales

Restart vnc: supervisorctl restart novnc vncserver

Refresh the noVNC page

Hey @Ito-Matsuda,
could you try out the following please:

Open a terminal in your running workspace

Execute the following commands to set the locale:
echo 'export LC_ALL=fr_FR.UTF-8' >> ~/.xsessionrc
echo 'export LANG=fr_FR.UTF-8' >> ~/.xsessionrc
echo 'export LANGUAGE=fr_FR.UTF-8' >> ~/.xsessionrc

sed -i -e 's/# fr_FR.UTF-8 UTF-8/fr_FR.UTF-8 UTF-8/' /etc/locale.gen && \
locale-gen && \
dpkg-reconfigure --frontend=noninteractive locales

Restart vnc: supervisorctl restart novnc vncserver

Refresh the noVNC page

Hi there,
Unfortunately that doesn't seem to work.

then

I also get the vncserver failing / continuously exiting after running the restart vnc.
. I get the same result if I stop novnc and then vncserver in the Supervisor status page.

Hi there,
Unfortunately that doesn't seem to work.

then

I also get the vncserver failing / continuously exiting after running the restart vnc.
. I get the same result if I stop novnc and then vncserver in the Supervisor status page.

Hm, I have not found any solution yet so maybe the problem is the version of Thunar? If that is the case, the problem might be solved as soon as it is updated.

Hm, I have not found any solution yet so maybe the problem is the version of Thunar? If that is the case, the problem might be solved as soon as it is updated.

I think some mo files are not being generated correctly or there is something messing with it. If I get a Thunar.mo file from an ubuntu:16.04 image from this other desktop project

and place it in either /usr/share/locale/fr/LC_MESSAGES or /usr/share/locale-langpack/fr/LC_MESSAGES and it becomes localized.

I think some mo files are not being generated correctly or there is something messing with it. If I get a Thunar.mo file from an ubuntu:16.04 image from this other desktop project

and place it in either /usr/share/locale/fr/LC_MESSAGES or /usr/share/locale-langpack/fr/LC_MESSAGES and it becomes localized.

Hey @Ito-Matsuda, thanks for the hint with the Thunar.mo file!
So, I have figured out that the translation files for Thunar are in the thunar-data package (e.g. here).
When I install the package in a ubuntu:16.04 docker container, then the *.mo files are copied to the /usr/share/locale/* directory, while they are not copied in a ubuntu:18.04 or ubuntu:20.04 container.
How to try out:
# in (brackets) the command for 18.04 if different
docker run -it --entrypoint /bin/bash ubuntu:16.04 (docker run -it --entrypoint /bin/bash ubuntu:18.04)

apt-get update && apt-get install -y wget
wget http://ports.ubuntu.com/pool/universe/t/thunar/thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb (wget http://ports.ubuntu.com/pool/universe/t/thunar/thunar-data_1.6.15-0ubuntu<IP_ADDRESS>_all.deb)

dpkg -i thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb (dpkg -i thunar-data_1.6.15-0ubuntu<IP_ADDRESS>_all.deb)

find / -name Thunar.mo
# This shows a list of the Thunar.mo files under /usr/share/locale/ on 16.04 but not on 18.04

# Check that the Thunar.mo files are in the actual package, for example the french translation:
mkdir /temp
dpkg -x  thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb /temp
ll /temp/usr/share/locale/fr/LC_MESSAGES/

I guess you could just copy the translation file from the extracted directory. I have not found anything yet why the .mo files are not copied automatically when installing the package.

Hey @Ito-Matsuda, thanks for the hint with the Thunar.mo file!
So, I have figured out that the translation files for Thunar are in the thunar-data package (e.g. here).
When I install the package in a ubuntu:16.04 docker container, then the *.mo files are copied to the /usr/share/locale/* directory, while they are not copied in a ubuntu:18.04 or ubuntu:20.04 container.
How to try out:
# in (brackets) the command for 18.04 if different
docker run -it --entrypoint /bin/bash ubuntu:16.04 (docker run -it --entrypoint /bin/bash ubuntu:18.04)

apt-get update && apt-get install -y wget
wget http://ports.ubuntu.com/pool/universe/t/thunar/thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb (wget http://ports.ubuntu.com/pool/universe/t/thunar/thunar-data_1.6.15-0ubuntu<IP_ADDRESS>_all.deb)

dpkg -i thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb (dpkg -i thunar-data_1.6.15-0ubuntu<IP_ADDRESS>_all.deb)

find / -name Thunar.mo
# This shows a list of the Thunar.mo files under /usr/share/locale/ on 16.04 but not on 18.04

# Check that the Thunar.mo files are in the actual package, for example the french translation:
mkdir /temp
dpkg -x  thunar-data_1.6.11-0ubuntu<IP_ADDRESS>_all.deb /temp
ll /temp/usr/share/locale/fr/LC_MESSAGES/

I guess you could just copy the translation file from the extracted directory. I have not found anything yet why the .mo files are not copied automatically when installing the package.

debian:xxx is okay.
debian:xxx-slim: the xx.mo will not gen when one app newly installed.  just like ubuntu18.04/20.14

Great @huapox, thanks a lot for the answer! I just tested it and the entry in /etc/dpkg/dpkg.cfg.d/excludes is also the reason for the Ubuntu 18.04/20.04 images! If you comment the line out as you suggested and install the package again (e.g. dpkg -i thunar-data_1.6.15-0ubuntu<IP_ADDRESS>_all.deb as described in the comment above), the translations are copied correctly! I think we are going to comment out that line in future versions of the workspace image by default then.


(Re)define produce() method

As discussed informally, this is a simple approach to enabling both keyed and unkeyed message produce-requests.

A few things maybe still worth discussing:

would we want to enable passing partition_ids (which would override the partitioner)? That might get slightly unwieldly if we'd stick to unnamed tuples
when passing in a single message, should it be possible to just pass a single bytestring?
is it a problem that passing two unkeyed messages or one keyed message looks very similar, syntactically?

:+1: Looks good. Don't worry about Travis, I've fixed this on my branch and will cherry-pick the change to master shortly.

Ah, forgot to answer the questions:

I've seen the partition ids in the Scala code too, where it isn't sent to Kafka. I think that's excessive, personally, and would just be confusing to use.  We can add it later to the partitoner code if someone needs it.
I think adding that would just complicate it. It's not unreasonable to ask someone to send an iterable instead of a message. Again, we can add it later if we're wrong. It won't be hard to change.
Ah, nuts. That is a problem, isn't it? Those two are exactly the same.  I'll make a ticket so we can address it.

@yungchin I don't the the last question is an issue, actually.  It only becomes an issue if the method accepts individual strings.  If we define it as always accepting an iterable of messages, it's fine.  It's the difference between this:
producer.produce(['test', 'test'])

and
producer.produce([('test', 'test')])

Mandating that it always be an iterable of messages removes the ambiguity.  This is how I implemented it on the python side: https://github.com/Parsely/pykafka/blob/feature/py_producer/kafka/pykafka/producer.py#L121-L126

Thanks!
Re 1: yeah, I wouldn't have any use for it either - librdkafka, like the scala driver, does have it, which is why I started wondering if we should.
(In fact, we make use of librdkafka's facility for it here https://github.com/Parsely/pykafka/blob/30ce2a161ec5407e83b0a2abe4f0389ab08e6e16/kafka/rdkafka/producer.py#L67 - because the pykafka partitioner has already decided a partition at that point)
Re 3: sorry, that was confusing wording on my part! Indeed, I just meant that the difference is very small - a single pair of brackets - so I was thinking people with bracket-blindness might hate it. On second thought it's fine though.


GUI Version with Tkinter

This pull request adds a new GUI edition of the app (tkinter), making it more user-friendly for people who don't want to see the console. This doesn't add any new dependencies though, so it's more of plug-and-play.
However, the GUI edition doesn't automatically copy your password. Instead, there is a copy button below. Or, the password can be copied by simply selecting everything in the output widget and copying that text.

Thanks for the PR @LyubomirT
However, the primary focus of this project is on the functionality behind password creation, and I do not currently plan to incorporate a GUI. Nevertheless, I appreciate your contribution, and I will leave the pull request open for future reference.


Bug/repair warnings for thrashbar

In this ticket, I repaired several defined but never used warnings:
./src/components/pages/Gamemode/Thrashbar.jsx
Line 1:17: 'useState' is defined but never used no-unused-vars
Line 1:27: 'useEffect' is defined but never used no-unused-vars
Line 1:38: 'Component' is defined but never used no-unused-vars
Line 3:20: 'Button' is defined but never used no-unused-vars
./src/components/pages/GamePlay/GamePlayMain.js
Line 3:10: 'connect' is defined but never used
In Thrashbar.jsx, there was a useState,useEffect,and Component import that I removed that were never implemented on #1.  I removed the Button import on #3 because it was never used.
In GamePlayMain, that warning is outdated. Somebody else has implemented connect.
On galleryReducer.js I commented out what I assume where suppose to be comments on #4 and #29. I'm making the assumption that when changes to the reducer were being made, these accidentally slipped through.
Trello card: https://trello.com/c/YoMUWFUK/602-defined-but-never-used-e
PR submission video: https://drive.google.com/file/d/1lyC2sd09PnqdlQRQVwCZJplpGf5WSXWQ/view?usp=sharing

I removed the merging conflicts


Customizable Rollups: support for percent fields

Rollups should allow for percent fields as target and source fields.

Included in beta release 3.130 (Beta 3)

Included in production release 3.130


Make callout link more flexible

Description of the change:
Homogenizes "AcademyLink" React component into a more flexible "CalloutLink".

Hello @justinwhall,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Fixes Nunjucks syntax for accessing _seoCanonical URL

Summary
The original code is attempting to access a property that doesn't exist on the array object, the associated page reference is only accessible as the first item of the array.
What kind of change does this PR introduce?
(Check at least one)

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other

Make sure the PR fulfills these requirements:

[ ] It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
[x] The changelog is updated
[ ] Related documentation has been updated
[ ] Related tests have been updated

Hello team, did you get a chance to review this PR?

Not sure if this PR remains valid.


Expose SCC's through ceph-csi package

Describe the feature you'd like to have
The ceph-csi project is imported by several projects, typically Kubernetes operators.
When running on environments like OpenShift, Security Context Constraints need to be imported for Ceph-CSI to operate normally.
It would be nice if ceph-csi could export its own SCCs through its API (one of the packages). An exported function that returns the minimum SCCs.
What is the value to the end-user? (why is it a priority?)
This will reduce friction for consumers of Ceph-CSI who don't need to know or hardcore the SCCs in their own code. They can just pull the required SCC from any given branch.
How will we know we have a good solution? (acceptance criteria)
SCCs can be imported from ceph-csi.
Additional context
Rook-Ceph does that already https://github.com/rook/rook/blob/dcb88a71d1668f1b9a74c4af3fd2053fc39c0045/pkg/apis/ceph.rook.io/v1/scc.go#L30

is it only to export SCC or pod/service templates also?

is it only to export SCC or pod/service templates also?

I'll open a different one for the templates :-)

Could this easily be used to generate the deployment/Helm yaml files too? That would be idea!

Yes, we need to unmarshal the file and expose that as a function in the cephcsi package. main note here we don't have CI to test the SCC atleast

What I meant is that I hope we can maintain a single location (as a public API) where the SCC (and other templates) are maintained. When these are updated, we would need to run a small tool that takes the templates from the API and generates the files under charts/ and deploy/.

Sounds good :+1:

Could this easily be used to generate the deployment/Helm yaml files too? That would be ideal!

Yes definitely, I have opened https://github.com/ceph/ceph-csi/issues/2542 separately, we can merge both if you want.

Hmm, I have been looking at this, and considered giving it a try. But there is no reference to SecurityContextConstraints or security.openshift.io in the Ceph-CSI repository. Where is a SCC for Ceph-CSI maintained now?

@leseb please have a look at the commit at https://github.com/ceph/ceph-csi/pull/2551/commits/6ba498f5cc2b77a04f87e89a9f5a619562c37992 and see if that is what you would like to have.
This is a separate Go module, so that importing it does not pull in the whole Ceph-CSI pieces. It should be possible to keep the API part of Ceph-CSI relatively small and self-contained that way. Other projects that deploy Ceph-CSI can then opt-in to only import the part(s) of the API that are relevant for them (OpenShift deployers will want to import the ocp and future k8s package, but Kubernetes environments should not need any OpenShift dependencies).

@leseb please have a look at the commit at 6ba498f and see if that is what you would like to have.
This is a separate Go module, so that importing it does not pull in the whole Ceph-CSI pieces. It should be possible to keep the API part of Ceph-CSI relatively small and self-contained that way. Other projects that deploy Ceph-CSI can then opt-in to only import the part(s) of the API that are relevant for them (OpenShift deployers will want to import the ocp and future k8s package, but Kubernetes environments should not need any OpenShift dependencies).

Yes it really matches the expectation. Thanks.

@leseb, the PR has been updated to reflect what we want to do. There are unit tests that show how to get the SecurityContextConstraints object, by passing a struct that contains keys to replace in a template. If this is an API that Rook still can use easily, we'll continue along this path.


Highlight/underline code with warnings/errors

Hello, how can I get VIM/Flake8 to highlight/underline code where there are errors/warnings in context? At the moment I have to run flake8 each time to see what the issues are (screen grab below)?

This is not something this plugin supports directly. This plugin will simply run the Flake8 command, and then parse/forward all reported issues in the Vim quicklist. If you want to continuously run that while typing, perhaps there is another plugin that can wrap this plugin to run it continuously on typing and highlight/underline all issues in the quickfix window?


Integration tests

This PR add integration test for travis. It deploys the examples present in the repository.

Right now the test for the ruby examples are disabled (until https://github.com/kubeless/kubeless/pull/257 gets released) and the event-trigger-python was failing for me locally due to an issue with the kafka PVC.
Those should be fixed before landing this PR.

Also the deployment fails with   Unable to find user information for context dind so we will need to debug that issue.


Listen on keyPress on text fields

I need to listen to what key what pressed in a text field, but from what I can see there is no support to add onKeyPress on the textfield. Why is that?

Please follow the issue template.


Build on Darwin machine

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

I gave up to build using Xcode at this time 😢


The game is laggy on the latest update from unleashed (0.60)

Hey @teeebor, hello again!
I'm seeing some lag on the game after this new update (maybe in the update that brought the store to the flipper app), kind of running smoothly for 5s and then I need to wait a long time to move the selector again, and then, it repeats this behavior...
This could be my flipper or is this happening with you too?

Hi!
Did you get it from the store? Because I did not made it compatible with it yet. Also, no, the game shouldn't slow down after any time and the navigation should be instant, there is no long running or parallel logic present in the current release. I don't have unleashed installed, but haven't noticed anything similar on ofw, I can play for hours there.
Maybe you could try to change the log level on your flipper? Anything below info level will slow down the device.

I confirm, I have the same problem. I also disabled the logs at all. It didn't help.
Flipper freezes Every ~5 seconds of running Solitaire.
Firmware version: unlshd-062e [20-08-2023].

Have to look into it, it seems wierd to me since I haven't touched the game in a long time. It may have some problem with something in unleashed

@acme4j , @thiago-s-medeiros  can you please try the 1.1.3 release?

Just tested. Works perfect!
Thank you for quick response.

Feels like 120hz right now, hahaha, thank you!!


Delete old resources with same ARK.

Closes 750.

Coverage remained the same at 100.0% when pulling d8ec19964c342bf5a4768ec7b9773d97bba4c95e on check_arks into 00acad315a72d68b7a1db10b178b8c7dca86e8e9 on master.


Keystrokes cause content to scroll down

macOS Sierra 10.12.1
Atom 1.12.6
Term3 0.22.1

I can no longer replicate this.  It may have been a consequence of splitting the panel.

i can confirm that splitting the panel causes this.  would love to see a fix

I get this problem too


Earned rewards Not available or 0.00 HNT on Wallet

I have hotspots earning HNT but the wallet (Helium wallet) does not reflect any earned HNT. wondering if this is common and i have had the hotspot for two weeks now.

This is related to the API issue we found in the app. If you update to 3.0.5, it will be fixed. closing.

I actually have the updated version 3.0.5. It is not the old one.

I just started my miners and currently have the latest version of Helium wallet and have this same issue issue. Today the wallet part disappeared that states O funds.
Please advise.  Thanks DR

I have the exact same issue

I have the exact same issue... Someone can help me, PLEASE!!!

Update the app to 4.1.0 if it's not already, then sign out, then sign back in.

I did... Many times... Says Zero Balance yet


Add pip usage hint for mac users

Mac is (nowerdays) using zsh per default - which has fancy  command line name globbing that interferes with pip.
https://github.com/mu-editor/mu/issues/852
http://zsh.sourceforge.net/Guide/zshguide05.html#l137
Solution for mac users is to do:
pip install "autobahn[all]"

or
pip install -e ."[all]"

interesting .. there seems to be agreement that actually pip intall -e ".[all" is the way to go https://github.com/mu-editor/mu/issues/852#issuecomment-499870171 :+1:

linux: works on bash and csh
macos: works on zsh
windows: works on powershell and cmd.exe


multiple FileChange events are returned out of order

Description
I'm trying to monitor file creations and deletions using awatch.  I'm expecting that if files are rapidly created and then deleted, watchfiles would either:

report them, in order, as a creation followed by a deletion (ideally); or
not report them at all (acceptable).

I'm getting a Set[FileChange] back with two entries for the same file as expected, but when I enumerate over the set, the deletion is being reported before the addition.
I've tried setting debounce=0 and step=0 in my awatch call in the hope that this will prevent the events from being bundled within the same set, but this doesn't work.
Debug output suggests that the raw events are being emitted in the correct order.  Possibly awatch should be returning a Sequence rather than a set?
Example Code
import asyncio
import watchfiles

async def go():
    async for changes in watchfiles.awatch(
        "/REDACTED", debounce=0, step=0, debug=True
    ):
        print("---")
        for change in changes:
            print(change)
        print("---")

asyncio.run(go())

Example Code Output
raw-event: Event { kind: Create(File), paths: ["/REDACTED/bee309868d89bfa2"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }
raw-event: Event { kind: Modify(Name(Any)), paths: ["/REDACTED/bee309868d89bfa2"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }
raw-event: Event { kind: Modify(Data(Content)), paths: ["/REDACTED/bee309868d89bfa2"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }
---
(<Change.deleted: 3>, '/REDACTED/bee309868d89bfa2')
(<Change.added: 1>, '/REDACTED/bee309868d89bfa2')
---

Operating System
macOS 12.4 (21F79)
Environment
No response
Watchfiles Version
0.14.1
Python Version
Python 3.10.4

After digging around within watchfiles, and in case it helps:
https://github.com/samuelcolvin/watchfiles/blob/acea996e0081cfa323056c6195729b6a749c41c5/watchfiles/main.py#L224
raw_changes receives the events out of order at this point, so it seems to be a RustWatcher-internal problem.  I don't speak Rust, but I'm almost willing to bet that the use of a HashSet is causing the issue:
https://github.com/samuelcolvin/watchfiles/blob/acea996e0081cfa323056c6195729b6a749c41c5/src/lib.rs#L38
especially given the prevalence of the phrase "arbitrary order" in Rust's std::collections::HashSet docs.
If a set data structure is really desired then maybe a BTreeSet is more appropriate—but on further reflection, is a set really appropriate?
Suppose a scenario where, within one "cycle", a file is rapidly:

created
deleted
created again.

Whether or not this situation is actually possible, I would want to be told that either:

the file was created, deleted, and then created; or
the file was created (and not be told about the additional deletion/creation).

What I really would not want in this situation is for one of the creation events to be treated as a duplicate, and filtered out with the deletion remaining in the result.  I suspect that currently, this is exactly what would occur.  Perhaps a Sequence-type structure is the only appropriate option.

Well python sets don't maintain order, so it doesn't really matter what type we use in rust.
I assume that offer doesn't matter, but de-duplication does, hence the use of sets.

Why is deduplication important?

Because depending on the OS there can easily be duplicates in the file changes. For example two "file modified" events because the data is modified and also the timestamp. E.g. look at your example above.

Well python sets don't maintain order, so it doesn't really matter what type we use in rust.

Yes, use of a set in either space will destroy the ordering, so even if the Rust was using a data type that maintained the raw event order, the Python would be losing it.
But the data is losing its order before being emitted from the Rust side of things, so I'm reasonably convinced that the data type being used in the Rust space does matter here also.

Because depending on the OS there can easily be duplicates in the file changes. For example two "file modified" events because the data is modified and also the timestamp.

Okay, I can understand the utility in deduplicating modification events.
I'm still persuaded to believe that naïvely deduplicating creation/deletion events is dangerous though.
To paraphrase my earlier example, would you agree that given three consecutive raw events (create → delete → create), removing one of the create events (and nothing else—a "naïve" deduplication) paints a false picture?
A more appropriate deduplication strategy for these events (if deduping is even really needed) might be to remove pairs of creation/deletion events, leaving the single creation event.

E.g. look at your example above.

In my example I see two raw events of kind Modify.  Is that what you're referring to?
Are they truly duplicate events though?  They have different "sub-kinds" and one of them seems to actually concern file deletion.

What you miss is that filesystem changes are often delayed by seconds or even tens of seconds, and can arrive or of order.
The delay issue is particularly prevalent on MacOS, but can also happen on Windows.
The other thing I think you miss is that most users of watchfiles (and watchgod before that), don't actually care much about exact order, many of them don't even care about which files changed.
I'm therefore :-1: on changing the interface and adding lots of extra logic for a minority of users.
However I'd be willing to accept a pr to add a new interface to return details of every change so they can be used in python. Would you like to have a go at that?

The other thing I think you miss is that most users of watchfiles (and watchgod before that), don't actually care much about exact order, many of them don't even care about which files changed.

This remark makes me feel that maybe I've again missed the mark in describing the core problem, so I hope you don't mind my attempting one final rephrase:

I (personally, like other users in your description) don't care about the order of operations across separate files.

However, if:

watchfiles is simultaneously telling me that the same file has been both created and deleted; and
watchfiles can't tell me which of those events is more recent; and
even if it could, naïve deduplication of these events has removed the latest creation/deletion event;

then I have to resort to explicitly testing the file's existence outside watchfiles to get the true story.

If the Rust and Python code were collecting these events in an ordered data structure, part of the problem would be solved.

I'm therefore 👎 on changing the interface and adding lots of extra logic for a minority of users.

Understood and accepted.
In case anyone else lands on this bug report with the same problem I've faced, I've implemented this Python workaround:
def without_multifile_events(changes: set[watchfiles.main.FileChange]):
    """
    Prevent simultaneous reports of creation and deletion of one file.

    `watchfiles` might report creation and deletion of the same file at once,
    and since results are returned in an unordered set, the latest event can't
    be deduced from the results alone.  This function explicitly tests for the
    existence of paths in this ambiguous situation and emits only the events
    that represent the current path state.

    Specifically, for each unique path in `changes`:

    - Emit `Change.modified` events as is.
    - Emit one `Change.added` event if and only if:
        - there are no `Change.deleted` events for this path; or
        - there are also `Change.deleted` events, but the path exists.
    - Emit one `Change.deleted` event if and only if:
        - there are no `Change.added` events for this path; or
        - there are also `Change.added` events, but the path doesn't exist.

    See the related GitHub issue for further details:
    https://github.com/samuelcolvin/watchfiles/issues/148

    ```
    from collections import defaultdict
    from pathlib import Path
    import watchfiles

    for changes in watchfiles.watch("/path"):
        for change, path_str in without_multifile_events(changes):
            ...
    ```
    """
    changes_by_path = defaultdict[str, set[watchfiles.Change]](set)
    for change_tuple in changes:
        change, path = change_tuple
        if change is watchfiles.Change.modified:
            yield change_tuple
        else:
            changes_by_path[path].add(change)
    for path, changes_only in changes_by_path.items():
        if len(changes_only) == 1:
            (single_change,) = changes_only
        else:
            single_change = (
                watchfiles.Change.added
                if Path(path).exists()
                else watchfiles.Change.deleted
            )
        yield single_change, path

However I'd be willing to accept a pr to add a new interface to return details of every change so they can be used in python. Would you like to have a go at that?

This would involve making changes to the Rust code and I have no Rust experience, so I respectfully decline.

Ok, the rust wouldn't be that hard.
I'll leave this open as a python interface to the underlying changes would be useful.

can't tell me which of those events is more recent

In my experience your OS also can't reliably tell you this. And it may have changed in between your notification and you using that file. So checking is definitely the right way.
That said I can understand wanting to correctly handle the case where it does actually work as expected.

@samuelcolvin - you obviously have a much closer relationship to the typical use cases of end users utilizing this package, but in my case (monitoring many files simultaneously on a shared network drive for updates which then trigger downstream processes) @Lx's assessment and workaround has been critical in accurately identifying inflection points relative to a particular file.
It seems to me (and I only offer this since the topic is still open) that a package-native solve would be something a substantive percentage of users would find utility in having, rather than having to run this out to pathlib and defaultdict to manage externally.
As you mentioned above, I don't believe the request to be outside the scope of the Notify implementation this leans on, so it should be fairly simple to implement.

Maybe @Lx is right and this is an issue with the use of HashSet.
Maybe we could use https://docs.rs/indexmap/latest/indexmap/set/struct.IndexSet.html and thereby maintain order.
Pr welcome to implement this, we should be able to tell just from creating the pr if it fixes the issue.


chore: reproduction for Nx bug (it installs deps with legacy-peer-deps=true)

Getting started
nvm use 18

npm ci

Pay attention that project does NOT use legacy-peer-deps!
Case 1
Run the following command
nx migrate --run-migrations

it will logs:
 NX   Running 'npm install' to make sure necessary packages are installed

removed 297 packages, and audited 2714 packages in 4s

and then it will throw error:
Cannot find module 'ts-morph'

Case 2
Reset all environment (revert package-lock.json changes and run again npm ci).
Then run the following command:
npm_config_legacy_peer_deps=false nx migrate --run-migrations

No error. Migrations are executed successfully!

DONT MERGE


[2pt] Replace clipping rasters by HUC boundary with filter method

This is a subtask of #4. The boundaries of the WBD dataset do not represent the extent of the rem, slope, and catchment layers.
Current behavior
Catchment layers on the outer boundary of the unit HUC are being clipped out in run_by_unit.sh. This creates gaps between HUCs of the same unit size. This also causes inconsistency in area between different HUC units.
Expected behavior
The catchments can be subset using unique HydroIDs instead and the resulting catchment boundary can be used to define the raster extents.
Steps to replicate behavior (include URLs)

Screenshots

Can we close this one?


⚠ Thumbnails API Endpoint has degraded performance

In d15994a, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1588 ms

Resolved: Thumbnails API Endpoint performance has improved in 385ff36 after 11 minutes.


[BACKLOG-26358] Fixes issue that allowed users to create folders with…

… special slash characters
This seems to be caused due to https://github.com/pentaho/pentaho-kettle/pull/5821
I'm not sure if this is really the best solution but this solution should mimic it's old behavior. Right now the only characters that shouldn't be allowed are '/' and '\'.
Since the validation of the folder name string is happening client-side, my thoughts were to update the javascript to check for any slash characters. If it detects them, it passes the string on normally (without URL encoding) and fails like it used to. If the string is fine, it will encode it as was updated in PR #5821  . Please let me know if this makes sense.

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -f 'pom.xml' -pl 'plugins/file-open-save/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/file-open-save/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/file-open-save/core/src/main/javascript/app/services/data.service.js


Adding folder history to windows task view on windows 10

Hello, I'm a VS Code windows user. Maybe it's a little bit too much to ask folder history to be appear on windows 10 task view, but I want some kind of history of my folder project workspace on windows task view history. Is there anyway to add it to the windows task history? Thanks

/duplicate https://github.com/Microsoft/vscode/issues/49096


align the units of koordinator.sh/batch-cpu

Signed-off-by: Tao Li<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

lgtm

/lgtm
/approve


Feature: Support BizTalk 2016 on the v5.x line

Add support for BizTalk 2016 on the 5.x line
This work item was migrated from CodePlex
CodePlex work item ID: '11152'
Vote count: '27'

[tif@1/23/2017]
Hi,
when can expect to have a supported Version for BizTalk 2016 ready to test?
kind regards,
Trond Ivar

[tfabraham@1/23/2017]
Code changes are underway both to support BizTalk 2016, and to raise the minimum .NET Framework version to v4.0 and Visual Studio to 2010, causing the removal of support for BizTalk 2006 and 2009.  That's largely because Visual Studio 2008 does not support VSIX-based add-ins and NuGet.  In addition, portions of the build process are being simplified.
The first available build will likely be a release candidate without a Visual Studio add-in for VS 2015.
I don't have a date, but I'm hoping within the next 2-4 weeks.  (My testing involves four versions of BizTalk.)
Tom

[UnknownUser@1/24/2017]

[UnknownUser@1/24/2017]

[UnknownUser@1/25/2017]

[UnknownUser@1/27/2017]
Associated with changeset 79714.

[UnknownUser@1/30/2017]

[UnknownUser@2/2/2017]

[sajid08@2/2/2017]
Hi Tom,
Really curious how this is coming along....we are ready to migrate to BTS 2016...just this is the missing bit. Also by when do you thing the VS 2015 Add in would be done.
Thanks alot for all your efforts, really appreciate it!
-Syed

[sajid08@2/8/2017]
How is this supposed to work? How can I generate the MSI for deployment without the Visual Studio 2015 Add in? Appreciate any work arounds as well.

[sajid08@2/8/2017]
Great, didn't know that it can be done from command prompt! thanks!

[tfabraham@2/8/2017]
In addition to the command-line approach, please see Matt Corr's blog with a great short-term workaround.
The upcoming v5.7 add-in for VS 2010-2015 has fully functional menus now, but still needs work on the new project wizard and testing in all versions.  I'm continuing to work on it.
Tom

[UnknownUser@2/10/2017]

[UnknownUser@2/16/2017]

[UnknownUser@2/16/2017]

[UnknownUser@2/16/2017]

[UnknownUser@2/16/2017]

[UnknownUser@2/16/2017]

[UnknownUser@2/17/2017]

[UnknownUser@2/20/2017]

[UnknownUser@2/20/2017]

[UnknownUser@3/1/2017]

[UnknownUser@3/13/2017]

[UnknownUser@4/18/2017]

[UnknownUser@8/2/2017]

Issue closed by tfabraham with comment
Feature complete
Reason closed
Fixed


Fix issues with the expression filter keys

Pull Request (PR) description
Fixes an issue with the expression filter template where all else if keys would be treated as the same key (as YAML does). Added new documentation and template logic that now looks for user-defined keys that are descriptive to the check, with the exception of the first condition and the last condition, which have specific keywords assigned to them:
First Condition (required):

if - for backwards compatibility
main - Descriptive as the main condition of the filter.
Required and must use one of the keywords in the YAML or Puppet code.

Last Condition:

else - for backwards compatibility
default - Descriptive as the "default" or "fall through" condition of the filter.
Required if more than one condition is defined.

This Pull Request (PR) fixes the following issues
Fixed #164

Any sufficiently complicated Go program contains an ad-hoc, informally-specified, bug-ridden, slow implementation of half of Lua.
— me, August 31, 2017

iit's been three years ssince i've last worked on YAML DSL, and this still holds ⬆


View dont update

After the calendar is loaded, the array variable used for fill the calendar don't update view, I call the push method and view don't is updated. Is only this part that view isn't updated.

I finished one test now, I retired the calendar directive and the view is updated. The calendar component is lock the view.

This is working fine in the demo: https://github.com/mattlewis92/angular-bootstrap-calendar/blob/master/index.html#L122
Please can you share a plunker that reproduces the issue you're experiencing. Thanks.

You closed the issue without giving me a chance to explain. This is arrogance. The example have libs  out updated.


[SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

What changes were proposed in this pull request?
Spark already support LIKE ANY syntax, but it will throw StackOverflowError if there are many elements(more than 14378 elements). We should implement built-in function for LIKE ANY to fix this issue.
Why the stack overflow can happen in the current approach ?
The current approach uses reduceLeft to connect each Like(e, p), this will lead the the call depth of the thread is too large, causing StackOverflowError problems.
Why the fix in this PR can avoid the error?
This PR support built-in function for LIKE ANY and avoid this issue.
Why are the changes needed?
1.Fix the StackOverflowError issue.
2.Support built-in function like_any.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Jenkins test.

Test build #131537 has started for PR 30465 at commit 53be0fd.

Test build #131537 has finished for PR 30465 at commit 53be0fd.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class LikeAllBase extends MultiLikeBase
abstract class LikeAnyBase extends MultiLikeBase
case class LikeAny(child: Expression, patterns: Seq[UTF8String]) extends LikeAnyBase
case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends LikeAnyBase

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131537/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36140/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36140/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36140/
Test FAILed.

cc @wangyum @cloud-fan

Test build #131542 has started for PR 30465 at commit 1d222b8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36145/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36145/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36145/
Test PASSed.

Test build #131542 has finished for PR 30465 at commit 1d222b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131542/
Test PASSed.

Test build #131587 has started for PR 30465 at commit 1d222b8.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36188/

Test build #131587 has finished for PR 30465 at commit 1d222b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131587/

Test build #131640 has started for PR 30465 at commit 8280665.

Test build #131643 has started for PR 30465 at commit 985352e.

Test build #131640 has finished for PR 30465 at commit 8280665.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131640/

retest this please

Test build #131651 has started for PR 30465 at commit 985352e.

Test build #131643 has finished for PR 30465 at commit 985352e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Test build #131651 has finished for PR 30465 at commit 985352e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131651/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36241/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36243/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36252/

retest this please

Test build #131708 has started for PR 30465 at commit 985352e.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36307/

Test build #131708 has finished for PR 30465 at commit 985352e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131708/

Test build #131829 has started for PR 30465 at commit 5b94e07.

Test build #131830 has started for PR 30465 at commit d29f514.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36427/

Test build #131829 has finished for PR 30465 at commit 5b94e07.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #131830 has finished for PR 30465 at commit d29f514.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Build finished.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131829/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131830/

Test build #131843 has started for PR 30465 at commit d29f514.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36440/

Test build #131843 has finished for PR 30465 at commit d29f514.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131843/

Test build #131873 has started for PR 30465 at commit 3157b08.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36470/

Test build #131873 has finished for PR 30465 at commit 3157b08.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131873/

Test build #131942 has started for PR 30465 at commit 2be24d1.

Test build #131942 has finished for PR 30465 at commit 2be24d1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131942/

retest this please

Test build #131957 has started for PR 30465 at commit 2be24d1.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36554/

Test build #131957 has finished for PR 30465 at commit 2be24d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131957/

thanks, merging to master!

@cloud-fan Thanks for your work!
@wangyum @dongjoon-hyun Thanks for your review.


Clarify that filtering by prefix is not required in completers

See #137

really?
argcomplete.autocomplete(parser, validator=lambda x, y: True)
will not show anything.
I have to use
argcomplete.autocomplete(parser, validator=None)
for argcomplete to work

The problem seems to be related to zsh.
output_stream.write('/usr/hello'.encode(sys_encoding))
only works if the prefix of '/usr/hello' matches the suffix in the terminal

I feel like the choices completer (and probably the others too) should not filter their results and defer to the validator to do the filtering. As it stands, if I want to do something like case-insensitive completion, I have to override the choices completer because the results are already filtered before they get to the validator. Or am I misunderstanding the purpose of the validator?

@haifengkao, it would be really awesome if a test could be added for this behavior. I'd like to create a pexpect test that would verify completions end-to-end in bash and zsh. Do you want to help?
@evanunderscore, the choices completer is presented as an example. The validator was added to this architecture after I first designed it, so I'm treating it as a general purpose filtering step. One of its functions is to filter the completions by prefix. The completer may also do so, for example if filtering will reduce the amount of work done (like when requesting completions from a remote API). Case insensitive completion is not generally supported. If you want it supported, please open another issue. We'll need to update the docs, think about how to communicate case insensitivity to completers, and add a CaseInsensitiveValidator.

@kislyuk sure. what do you need?

A test for the zsh behavior that you described (positive and negative test assertions). You may have to modify travis.yml to get zsh and pexpect installed.

The current tests are pure python and they don't involve the shell at all.
Do you want me to set up a new test framework for you?

We would need a new test case that uses pexpect. I would like to have it added in a new class in test/test.py.

I was doing a little research (http://www.zsh.org/mla/users/2013/msg00612.html).
Zsh has its own filtering system, which can be turned off by compadd -U. However, the link above suggests this -U option is not available in bash compatibility mode.

Assuming zsh is sufficiently covered by #10 and #141.


Make sure MemPoolService.TransactionHashes don't overflow

In MemPoolBehavior:
foreach (var inv in invPayload.Inventory.Where(inv => inv.Type.HasFlag(InventoryType.MSG_TX)))
{
	// if we already have it continue;
	// ToDo: Make sure TransactionHashes don't overflow
	if(!MemPoolService.TransactionHashes.Add(inv.Hash))
	{
		continue;
	}

	payload.Inventory.Add(inv);
}

Trying to get an OverflowException with brute force
I wasn't able to make it overflow, in fact it freezes my machine after 50,000,000 of UInt256 instances. In my machine (w/ 8GBs RAM) the test below can add successfully 40,000,000 of UInt256.
C# Demo Code
using System;
using System.Threading.Tasks;
using ConcurrentCollections;
using NBitcoin;

namespace test_mempool
{
    class Program
    {
        static void Main(string[] args)
        {
            var hashes = new ConcurrentHashSet<uint256>();
            var count = 0UL;

            while(count < 40*1000*1000)
            {
                var hash = new uint256(++count);
                try{
                    if(count % 100000==0){
                        Console.WriteLine($"{count} items");
                    }
                    if(!hashes.Add(hash))
                    {
                        Console.WriteLine("Failed!");
                        break;
                    }
                    }catch{
                        break;
                    }
            }
            Console.WriteLine($"Capacity = {hashes.Count}");
        }
    }
}

Code review
Checking the code of the ConcurrentHashSet class I can see that it can only overflow in this line so, it can overflow when there is 2,147,483,648 in one. We will run out of memory before our mempool reaches that amount of transaction hashes.
Other considerations
The following is just an imaginary situation:
Given an average transaction of 500 bytes (currently is much bigger) and a maximun blocksize of 4mb (currently we dont have this) we could have 8,000 transaction per block (one each 10 minutes in average). Considering that in my 8gb ram machine it was able to store 40,000,000 transaction hashes then, that could be enough for keeping transaction hashes for 500 blocks (3.4 days more or less) without flushing the hashset. Clearly, under real conditions it can keep the hashset many many more time.
Conclusion
It is almost impossible to make it overflow.

You're overkilling it:) Removed ToDo comment: https://github.com/nopara73/MagicalCryptoWallet/commit/83be736126e6602dba25f5702eb0465d2e3b617a


Fix dicom seg panel sizing issue

Context
Dicom Seg Panel Sizing is incorrect. The panel is being cut when there are too many items

Changes & Results
The changes applied were to fix the flex layout sizing for the entire right panel + seg panel.
The seg panel had a fixed height but instead its height should be the remaining flex space. The strategy applied were:

Avoid grow/shrink of some items, but ensure it for panel seg and its direct parents. Also who put min-height:0 for such items which will ensure there is a initial minimum value allowing it to grow as needed.

Testing

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] "OS:
[] "Node version:
[] "Browser:

The thumbnails are squashed


Crash 4.6.1-1 on opensuse Tumbleweed

OS: openSUSE Tumbleweed
GPMDP Version: 4.6.1
Issue Descriptions: The app crashes when try to start. On cli says:
~> google-play-music-desktop-player
Violación de segmento ('core' generado)
I don't known how to get better info about this issue, if you can give me some instruction I'll try to get more info.
Steps to Reproduce: Start my computer, try to start GPMDP.

Look through #3391 #3400 . The same issue happens on Ubuntu 18.10 as I had run that as my main distro about 3 weeks ago. So in general, you're going to want to look through CircleCI and download an older version of the binary.

@davidv171, thanks! I downloaded the RPM from #3391 and it's works as a charm.


Added radio_button.jsx component

Added radio_button.jsx component
The purpose of this Pull Request is to fix #91
Screenshots
https://user-images.githubusercontent.com/92046906/197019915-849ef07f-61b0-46ea-b6da-881d49be1c60.jpg
Checklist

[x] I have Made this contribution as per the CONTRIBUTING guide in this repo
[x] I have tested in local Environment.
[x] I have made the fix as per issue conversaion
[x] I have starred the repository ⭐

@streetcodec , looks and working perfect as per requierment.
BTW, look for other issues (contact forms) and star the repo ⚡

@jsvigneshkanna Already starred the repo and will be looking for more issues, don't worry!


Hash check failed for whatsapp

>scoop install whatsapp
Installing 'whatsapp' (latest).
WhatsAppSetup.exe (77,7 MB) [=================================================================================] 100%
Checking hash of WhatsAppSetup.exe... Hash check failed for 'https://web.whatsapp.com/desktop/windows/release/x64/WhatsAppSetup.exe#/dl.7z'.
Expected:
    4dbdb96f143fc286e625e6a1bd2e932663cd9fbc31aa07f92ba401b8de2319aa
Actual:
    ca9697c9adce4a41734f985634bc14d59ab63b30fdfacadbf36a1de3cecf7958

Fixed with https://github.com/lukesampson/scoop-extras/commit/5d8c0841131c85c4e935fc1a52b264e100b7cb3d


[removed] Remove typeahead (fixes #40, #111)

I initially started by trying to fix a regression to #80 which was introduced
in 2fbafa, but after having evaluated the code I discovered that there's no
easy way to both fix the regression and make the typeahead logic work again.
This is sadly a side-effect of no longer keeping value in state, since we
can no longer diff previous state and next state in the same fashion.
Since the current typeahead situation is very poor on mobile, not to mention
how broken it is in IE, I decided the best way forward is to temporarily remove
the typeahead logic.

I'll update the CHANGELOG and README (to mention that we currently don't have typeahead) once this is merged. I noticed we're missing a few entries in the former. Oh, and during my bug hunt I discovered a substantial amount of code that can be removed/simplified now that value only changes when passed in by the consumer. I'll get to work on that this weekend.

Just to be crystal clear: I really do want to figure out how to make typeahead work across platforms and devices, because I think it's a really cool feature. I'm not sure in which form though, because after som a11y testing I discovered that the current implementation which uses text selection ranges is...not great if you're using a screen reader.

Heya, sorry for the radio silence there - and for chasing the yaks on my build PR/comments. This looks good to me, and I think this gets us pretty close on the next release then if I'm not mistaken.
Anything else new that should go in the next minor/patch (need to look in to whats there. I'll open a PR with the changelog/version proposal here shortly if the milestone looks pretty clear.

Heya, sorry for the radio silence there - and for chasing the yaks on my build PR/comments.

No worries; here to help! :)


Adding GitHub Workflow

Github action workflow added to compile Thunder code and run Unit test for every PR and Push.
Also, landed fix the unit test build failures

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/1012/rdkcentral/Thunder

Commit: 21fa8d4bf67ce7fad8e98b20bf2dd177374a53c7

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/1012/rdkcentral/Thunder

Commit: 025373f4e995fb9bd4c7f9e7ad81b75173aaf856

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 3 files pending identification.


add random walk noise for GPS (like gazebo)

I found there is no GPS noise with jMAVSim.
I developed the random walk noise like gazebo SITL.

Seems like a good idea to me. @TSC21 is it useful/reasonable that anyone would ever want to tune this - turn off the noise, or control the level of noise?

Good idea, @hamishwillee
I will add the plan to make control panel for noise level. ;-)

@stmoon Sounds good. Though I have no idea whether a control panel is the normal/right way to do this for jMAVSim :-) I'd have "guessed" a command line argument.

Thank you @hamishwillee
First time, I will develop simple control panel which can control the noise parameter.
Then, I will improve the control panel.  :-)

Hi, @bkueng
I added sqrt(dt) to all generated noised. It seems to be more stable.
And, I put the the computation of noise inside setGlobalPosition()
Thanks.

Hi, @bkueng
I modify gps noise function according to your comments.
please check it.

Thanks @stmoon , this looks good now. I just had to increase gpsNoiseStdDev = 0.01f; to 10.f to get to a noticable range (which seems reasonable):

What do you think?

Hi @bkueng
OK. I think it is better than before.
I will modify the default parameter.

Thanks, I merged it

Thanks!!!