refactor: Replaced unwraps with Results for discord api implementation

Codecov Report
Patch coverage: 32.39% and project coverage change: -1.73 :warning:

Comparison is base (5c04fb3) 69.49% compared to head (f9494ea) 67.77%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   69.49%   67.77%   -1.73%
==========================================
  Files          58       58
  Lines        3731     3826      +95
==========================================
  Hits         2593     2593
- Misses       1138     1233      +95

Flag
Coverage Δ

disma
72.53% <32.62%> (-2.07%)
:arrow_down:

disma-cli
30.73% <0.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

disma-cli/src/infra/diff/formatter.rs
99.25% <0.00%> (-0.75%)
:arrow_down:

disma/src/infra/discord/api.rs
0.00% <0.00%> (ø)

disma/src/utils/http.rs
0.00% <0.00%> (ø)

disma/src/application/changes.rs
100.00% <100.00%> (ø)

disma/src/domain/category/diff.rs
96.42% <100.00%> (ø)

disma/src/domain/channel/diff.rs
96.91% <100.00%> (ø)

disma/src/domain/permission/diff.rs
98.61% <100.00%> (ø)

disma/src/domain/role/diff.rs
100.00% <100.00%> (ø)

disma/src/utils/option.rs
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Registry doesn't accept valid JWT auth token "error while unmarshalling raw token: unable to decode signature: illegal base64url string"

Problem description
NOTE the authentication with the docker daemon and client works in my setup only if I want to do it manually, there seem to be an issue which I describe below.
To access my secured self-hosted registry (v2) with curl I have to follow a few steps:

I query my registry's /v2/_catalog route and get an HTTP/1.1 401 Unauthorized
I request a token from my auth server with the service and scope as returned in the response on 1.
I pass the token as Authorization: Bearer MYTOKEN to my docker registry when requesting the /v2/_catalog route.

Everything is fine except that the registry won't accept my token due to this error:
time="2015-10-13T09:35:49Z" level=error msg="error while unmarshalling raw token: unable to decode signature: illegal base64url string"
time="2015-10-13T09:35:49Z" level=warning msg="error authorizing context: malformed token" http.request.host="<IP_ADDRESS>:5000" http.request.id=e41329cd-760b-4e4a-89ff-5f726b77fd0d http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:55231" http.request.uri="/v2/_catalog" http.request.useragent="curl/7.35.0" instance.id=75c575c0-6b14-4c90-8cdf-c1910f42ad47 version=v2.1.1
<IP_ADDRESS> - - [13/Oct/2015:09:35:49 +0000] "GET /v2/_catalog HTTP/1.1" 401 161 "" "curl/7.35.0"

I've double checked that my token is valid using the JWT Debugger and pasting the token as well as the certifiate and the private key (no real secret since it is a demo cert/key which can be found here):

Background
I have secured my registry using a token server. My exact setup can be found here.
Expected results
The registry accepts my token.
Actual result
Registry complains about malformed token.
Detailed steps
1. Request token
$ curl -H "Authorization: Basic MYBASE64ENCODEDSECRET" -vk "https://<IP_ADDRESS>:5001/auth?service=my.docker.registry&scope=registry:catalog:*"

* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 5001 (#0)
* successfully set certificate verify locations:
*   CAfile: none
  CApath: /etc/ssl/certs
* SSLv3, TLS handshake, Client hello (1):
* SSLv3, TLS handshake, Server hello (2):
* SSLv3, TLS handshake, CERT (11):
* SSLv3, TLS handshake, Server key exchange (12):
* SSLv3, TLS handshake, Server finished (14):
* SSLv3, TLS handshake, Client key exchange (16):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSL connection using ECDHE-RSA-AES128-GCM-SHA256
* Server certificate:
* 	 subject: C=AU; ST=Example State; L=Example city; O=Example company; OU=Example unit; CN=example.com<EMAIL_ADDRESS>* 	 start date: 2015-09-16 13:10:20 GMT
* 	 expire date: 2016-09-15 13:10:20 GMT
* 	 issuer: C=AU; ST=Example State; L=Example city; O=Example company; OU=Example unit; CN=example.com<EMAIL_ADDRESS>* 	 SSL certificate verify ok.
> GET /auth?service=my.docker.registry&scope=registry:catalog:* HTTP/1.1
> User-Agent: curl/7.35.0
> Host: <IP_ADDRESS>:5001
> Accept: */*
> Authorization: Basic MYBASE64ENCODEDSECRET
>
< HTTP/1.1 200 OK
< Content-Type: application/json
< Date: Tue, 13 Oct 2015 09:33:51 GMT
< Content-Length: 1108
<
{"token":"eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6IkdWNU06M0FGVDpaUVRYOlhHQUI6TFlZWDo1S1I1Olg2RUw6RTZTTzo3Q0E0OkJBWUU6RUdGTjo2UEtYIn0.eyJpc3MiOiJBY21lIGF1dGggc2VydmVyIiwic3ViIjoia29ucmFka2wiLCJhdWQiOiJteS5kb2NrZXIucmVnaXN0cnkiLCJleHAiOjE0NDQ3Mjk3MzAsIm5iZiI6MTQ0NDcyODgyOSwiaWF0IjoxNDQ0NzI4ODMwLCJqdGkiOiI3ODY2MDE5Mjk2MDYwMzY0MjYxIiwiYWNjZXNzIjpbeyJ0eXBlIjoicmVnaXN0cnkiLCJuYW1lIjoiY2F0YWxvZyIsImFjdGlvbnMiOlsiKiJdfV19.LSxAbsi1Okh3cjtEwEu1wl0aRjlVj7y-e7Ur2srvMyGKr--u1iwd5NANg_ZZiORjGt5MzSlEI9YDWrAoo2iZLCz80OWO7E1p32X7__4tsOEgOQFEBu5snrJJH64HDMcAFXKhXODP2h1G1Nm7eEz5K66MDn49nNe32fYBo8VUBXuHWuiVSox8YRUiPe4mVTt6nQ2iLbIdttsloMGSRHPp216ntgr9JGlrVv5dHt1Lkb8jCoIKToXzT5ctzqQkk-N1-yUoQPVhD5M624EUBb_II3iY6lAQ2A4CUILdrbx4nL8vLQOadt-N24wnbcwDCivf2hxmJTGEm5UYUeAICAwgj-bdPNw0F4lWGkaQiNYUspp_VhItiYRxXx3FW3MnOMM21BZoYPwrRA9JXlWYyNF097WGNjAI8J5284hf6QvQMK90ivNeNY7U-3CBLnuER4-6KEl5GlnQ5VVF-LfGkFS3i-cWa_5OizbaPZ9-onscOvrgsk7kboHu84jBUqh0Lo5_0a6Q1O0K0fjmn_90L231yvRJ8cz4bgxdUPdbTmmrkCi2UjMtQlWzKc7MqHDZWr7Rwv7jliG_dwZKZfu11YkMn0an8* Connection #0 to host <IP_ADDRESS> left intact
JgSmMfDt_SIHdeu8pzEXLvUYmpu0gIa6XwfZfooNTvijYXJ8Wsy5xAltE8EEXxmd1zdCcjhMlC3drEZ8EA"}

2. Using the token to request catalog from docker registry
 curl -vk -H "Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6IkdWNU06M0FGVDpaUVRYOlhHQUI6TFlZWDo1S1I1Olg2RUw6RTZTTzo3Q0E0OkJBWUU6RUdGTjo2UEtYIn0.eyJpc3MiOiJBY21lIGF1dGggc2VydmVyIiwic3ViIjoia29ucmFka2wiLCJhdWQiOiJteS5kb2NrZXIucmVnaXN0cnkiLCJleHAiOjE0NDQ3Mjk3MzAsIm5iZiI6MTQ0NDcyODgyOSwiaWF0IjoxNDQ0NzI4ODMwLCJqdGkiOiI3ODY2MDE5Mjk2MDYwMzY0MjYxIiwiYWNjZXNzIjpbeyJ0eXBlIjoicmVnaXN0cnkiLCJuYW1lIjoiY2F0YWxvZyIsImFjdGlvbnMiOlsiKiJdfV19.LSxAbsi1Okh3cjtEwEu1wl0aRjlVj7y-e7Ur2srvMyGKr--u1iwd5NANg_ZZiORjGt5MzSlEI9YDWrAoo2iZLCz80OWO7E1p32X7__4tsOEgOQFEBu5snrJJH64HDMcAFXKhXODP2h1G1Nm7eEz5K66MDn49nNe32fYBo8VUBXuHWuiVSox8YRUiPe4mVTt6nQ2iLbIdttsloMGSRHPp216ntgr9JGlrVv5dHt1Lkb8jCoIKToXzT5ctzqQkk-N1-yUoQPVhD5M624EUBb_II3iY6lAQ2A4CUILdrbx4nL8vLQOadt-N24wnbcwDCivf2hxmJTGEm5UYUeAICAwgj-bdPNw0F4lWGkaQiNYUspp_VhItiYRxXx3FW3MnOMM21BZoYPwrRA9JXlWYyNF097WGNjAI8J5284hf6QvQMK90ivNeNY7U-3CBLnuER4-6KEl5GlnQ5VVF-LfGkFS3i-cWa_5OizbaPZ9-onscOvrgsk7kboHu84jBUqh0Lo5_0a6Q1O0K0fjmn_90L231yvRJ8cz4bgxdUPdbTmmrkCi2UjMtQlWzKc7MqHDZWr7Rwv7jliG_dwZKZfu11YkMn0an8" https://<IP_ADDRESS>:5000/v2/_catalog
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 5000 (#0)
* successfully set certificate verify locations:
*   CAfile: none
  CApath: /etc/ssl/certs
* SSLv3, TLS handshake, Client hello (1):
* SSLv3, TLS handshake, Server hello (2):
* SSLv3, TLS handshake, CERT (11):
* SSLv3, TLS handshake, Server key exchange (12):
* SSLv3, TLS handshake, Server finished (14):
* SSLv3, TLS handshake, Client key exchange (16):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSL connection using ECDHE-RSA-AES128-GCM-SHA256
* Server certificate:
* 	 subject: C=AU; ST=Example State; L=Example city; O=Example company; OU=Example unit; CN=example.com<EMAIL_ADDRESS>* 	 start date: 2015-09-16 13:10:20 GMT
* 	 expire date: 2016-09-15 13:10:20 GMT
* 	 issuer: C=AU; ST=Example State; L=Example city; O=Example company; OU=Example unit; CN=example.com<EMAIL_ADDRESS>* 	 SSL certificate verify ok.
> GET /v2/_catalog HTTP/1.1
> User-Agent: curl/7.35.0
> Host: <IP_ADDRESS>:5000
> Accept: */*
> Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6IkdWNU06M0FGVDpaUVRYOlhHQUI6TFlZWDo1S1I1Olg2RUw6RTZTTzo3Q0E0OkJBWUU6RUdGTjo2UEtYIn0.eyJpc3MiOiJBY21lIGF1dGggc2VydmVyIiwic3ViIjoia29ucmFka2wiLCJhdWQiOiJteS5kb2NrZXIucmVnaXN0cnkiLCJleHAiOjE0NDQ3Mjk3MzAsIm5iZiI6MTQ0NDcyODgyOSwiaWF0IjoxNDQ0NzI4ODMwLCJqdGkiOiI3ODY2MDE5Mjk2MDYwMzY0MjYxIiwiYWNjZXNzIjpbeyJ0eXBlIjoicmVnaXN0cnkiLCJuYW1lIjoiY2F0YWxvZyIsImFjdGlvbnMiOlsiKiJdfV19.LSxAbsi1Okh3cjtEwEu1wl0aRjlVj7y-e7Ur2srvMyGKr--u1iwd5NANg_ZZiORjGt5MzSlEI9YDWrAoo2iZLCz80OWO7E1p32X7__4tsOEgOQFEBu5snrJJH64HDMcAFXKhXODP2h1G1Nm7eEz5K66MDn49nNe32fYBo8VUBXuHWuiVSox8YRUiPe4mVTt6nQ2iLbIdttsloMGSRHPp216ntgr9JGlrVv5dHt1Lkb8jCoIKToXzT5ctzqQkk-N1-yUoQPVhD5M624EUBb_II3iY6lAQ2A4CUILdrbx4nL8vLQOadt-N24wnbcwDCivf2hxmJTGEm5UYUeAICAwgj-bdPNw0F4lWGkaQiNYUspp_VhItiYRxXx3FW3MnOMM21BZoYPwrRA9JXlWYyNF097WGNjAI8J5284hf6QvQMK90ivNeNY7U-3CBLnuER4-6KEl5GlnQ5VVF-LfGkFS3i-cWa_5OizbaPZ9-onscOvrgsk7kboHu84jBUqh0Lo5_0a6Q1O0K0fjmn_90L231yvRJ8cz4bgxdUPdbTmmrkCi2UjMtQlWzKc7MqHDZWr7Rwv7jliG_dwZKZfu11YkMn0an8
>
< HTTP/1.1 401 Unauthorized
< Content-Type: application/json; charset=utf-8
< Docker-Distribution-Api-Version: registry/2.0
< Www-Authenticate: Bearer realm="https://<IP_ADDRESS>:5001/auth",service="my.docker.registry",scope="registry:catalog:*",error="invalid_token"
< Date: Tue, 13 Oct 2015 09:35:49 GMT
< Content-Length: 161
<
{"errors":[{"code":"UNAUTHORIZED","message":"access to the requested resource is not authorized","detail":[{"Type":"registry","Name":"catalog","Action":"*"}]}]}
* Connection #0 to host <IP_ADDRESS> left intact

Error reported by the registry
time="2015-10-13T09:35:49Z" level=error msg="error while unmarshalling raw token: unable to decode signature: illegal base64url string"
time="2015-10-13T09:35:49Z" level=warning msg="error authorizing context: malformed token" http.request.host="<IP_ADDRESS>:5000" http.request.id=e41329cd-760b-4e4a-89ff-5f726b77fd0d http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:55231" http.request.uri="/v2/_catalog" http.request.useragent="curl/7.35.0" instance.id=75c575c0-6b14-4c90-8cdf-c1910f42ad47 version=v2.1.1
<IP_ADDRESS> - - [13/Oct/2015:09:35:49 +0000] "GET /v2/_catalog HTTP/1.1" 401 161 "" "curl/7.35.0"

Docker info
$ sudo docker info
Containers: 27
Images: 468
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 522
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.19.0-30-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 8
Total Memory: 15.63 GiB
Name: kkleinework
ID: A5PC:FL5L:UJM6:4P7S:KXTW:B3PT:74OK:M3OL:DOJD:DDGH:DQK3:6FLY
Debug mode (server): true
File Descriptors: 42
Goroutines: 58
System Time: 2015-10-13T12:05:49.419286601+02:00
EventsListeners: 0
Init SHA1: 1f4a3c648015cae3b3d76c5ba2980d8c1f88f388
Init Path: /usr/lib/docker/dockerinit
Docker Root Dir: /var/lib/docker
WARNING: No swap limit support

The error is obviously raised in the function NewToken (token.go:114):
	parts := strings.Split(rawToken, TokenSeparator)

	// ...
	if headerJSON, err = joseBase64UrlDecode(rawHeader); err != nil {
		// ...
	}

	if claimsJSON, err = joseBase64UrlDecode(rawClaims); err != nil {
		// ...
	}

	token := new(Token)
	token.Header = new(Header)
	token.Claims = new(ClaimSet)

	token.Raw = strings.Join(parts[:2], TokenSeparator)
	if token.Signature, err = joseBase64UrlDecode(parts[2]); err != nil {
		err = fmt.Errorf("unable to decode signature: %s", err)
		return nil, ErrMalformedToken
	}
	// ...

As we can see, the signature is treated as a base64 URL encoded string. Is that correct, because the signature part of the JWT Token doesn't look like it is base64 encoded
LSxAbsi1Okh3cjtEwEu1wl0aRjlVj7y-e7Ur2srvMyGKr--u1iwd5NANg_ZZiORjGt5MzSlEI9YDWrAoo2iZLCz80OWO7E1p32X7__4tsOEgOQFEBu5snrJJH64HDMcAFXKhXODP2h1G1Nm7eEz5K66MDn49nNe32fYBo8VUBXuHWuiVSox8YRUiPe4mVTt6nQ2iLbIdttsloMGSRHPp216ntgr9JGlrVv5dHt1Lkb8jCoIKToXzT5ctzqQkk-N1-yUoQPVhD5M624EUBb_II3iY6lAQ2A4CUILdrbx4nL8vLQOadt-N24wnbcwDCivf2hxmJTGEm5UYUeAICAwgj-bdPNw0F4lWGkaQiNYUspp_VhItiYRxXx3FW3MnOMM21BZoYPwrRA9JXlWYyNF097WGNjAI8J5284hf6QvQMK90ivNeNY7U-3CBLnuER4-6KEl5GlnQ5VVF-LfGkFS3i-cWa_5OizbaPZ9-onscOvrgsk7kboHu84jBUqh0Lo5_0a6Q1O0K0fjmn_90L231yvRJ8cz4bgxdUPdbTmmrkCi2UjMtQlWzKc7MqHDZWr7Rwv7jliG_dwZKZfu11YkMn0an8

From looking at your output, I see a problem:
Your token from the auth server ends with ...8EA
The token you pass to the registry ends with ...0an8.  This is not a valid token - the JWT debugger cannot verify the signature.
The token you verify with the JWT debugger is the correct token (...8EA)
I note there is some curl output interleaved with you token just after ...8EA (* Connection #0 to host <IP_ADDRESS> left intact)

@RichardScothern thank you for spotting the issue with my requests. I've tried it many times but only copied'n'pasted the token and never did so by scripting the requests. I must have copied the output of a former request without noticing it.
Nevertheless, this script works perfectly fine except that it doesn't check for any errors. I hope it will be of use for somebody trying to grasp the flow of HTTP requests:
# This is the operation we want to perform on the registry
registryURL=https://<IP_ADDRESS>:5000/v2/_catalog

# Save the response headers of our first request to the registry to get the Www-Authenticate header
respHeader=$(tempfile);
curl -k --dump-header $respHeader $registryURL

# Extract the realm, the service, and the scope from the Www-Authenticate header
wwwAuth=$(cat $respHeader | grep "Www-Authenticate")
realm=$(echo $wwwAuth | grep -o '\(realm\)="[^"]*"' | cut -d '"' -f 2)
service=$(echo $wwwAuth | grep -o '\(service\)="[^"]*"' | cut -d '"' -f 2)
scope=$(echo $wwwAuth | grep -o '\(scope\)="[^"]*"' | cut -d '"' -f 2)

# Build the URL to query the auth server
authURL="$realm?service=$service&scope=$scope"

# Query the auth server to get a token
token=$(curl -ks -H "Authorization: Basic YOUR_BASE64_ENCODED_CREDENTIALS" "$authURL")

# Get the bare token from the JSON string: {"token": "...."}
token=$(echo $token | jq .token | tr -d '"')

# Query the registry again, but this time with a bearer token
curl -vk -H "Authorization: Bearer $token" $registryURL

NOTE A critical part is that one has to put the request to the auth server URL in quotes ("$authURL"); otherwise the asterisk (*) will be expanded by the shell prior to making the request which is not what we want.

I've included this documentation into my almost ready to use but certainly ready to function registry setup: https://github.com/kwk/docker-registry-setup#manual-token-based-workflow-to-list-repositories


Multiple users & sites

The current behaviour with multiple users is intended, so its not really a bug.
Should be easier if I explain it with an example:

User ABC creates a website ABC
User ABC creates a user XYZ
User XYZ logs into Umami and the dashboard is empty
User XYZ creates a website XZY
User ABC only sees site ABC
User XYZ only sees site XYZ

What I was expecting was:

User ABC creates a website ABC
User ABC creates a user XYZ
User XYZ logs into Umami and can see website ABC

I know that I could enable the share URL, but that also means that user XYZ needs several links if I have several sites (and the stats are visible to everyone with the link). The only solution for me right now is to share my account.
I'm aware that a proper permission system is quite a bit of work, but that would cover all usecases with more granular control over users and which sites they can access.
An easier solution for now might be a .env var that is calling a getAllWebsites() method here that selects all sites, instead of executing this query that only selects sites created by the user.
Not a perfect fix since were either showing all available sites or not enough sites (for my usecase anyways), thats why I first wanted to create an issue. To see if there is a point to a cruel .env parameter or if a permission system is something that other people want/need.

Can you explain your use case a little more? Trying to understand what you're trying to accomplish.
Most people will never need to create an account because they are using it for their own websites, so they will just use the default account. Accounts are for people who have clients and they want to host stats for their client's websites. The client can log in with their account and manage everything themselves. You definitely don't want different clients seeing each other's data.
If you're asking if the admin account should be able to see all websites, I think that can be possible. But other accounts should only see their own websites.

My specific use case would already be solved if the admin-account could view all sites regardless of who created it. Haven't thought about that at all.
The goal is to use Umami for different 3 sites (+ subdomain), which means I would create 3 different users and create with every one of them the necessary sites.
But right now I as the admin have no access to any of those sites because the admin account didn't create a website. Which means if I want to look at the stats I need share the login details.
With a .env param I could spin up 3 instances of Umami where every user can see all sites.
Like I said, not a great solution but it'd be quite a bit easier than a fully fledged permission system.
Anyway, just giving the admin access to all sites would do the trick for me.

But why are you creating separate accounts instead of having all websites under a single account?

Like I said: Those sites are for clients, and ideally they'd get access to the dashboard.
If the admin creates those sites then no other user can see any stats. If the users create those sites then the admin has no access to any of the sites.
Giving the admin the ability to view all sites regardless of who created them would fix this.

Got it. Ok I can update it so the admin can access other websites. Will probably need to make it a different screen so you don't get mixed up with your own sites.

@joshinat0r This is now available in the dev branch. Under Accounts there is a new button that let's you jump to an account's dashboard.

Thanks for resolving this so quickly.
Personally would've preferred it if they all showed up on the admins dashboard, but I get why they are separated like they are.
Can bookmark the different users dashboards anyways, so it's not like I need to make several clicks every time I want to check all sites.

Is this available in Main?

Yes, in Umami v1 the admin could just view a users complete dashboard.
In v2 that changed, the admin can't jump to a users dashboard anymore, but you can still view all sites.
Just go to Settings > Users > Edit-Button > Websites-Tab > View-Button. Easier to just bookmark the URL if you need to visit them often.
v2 also has Teams. The owner of a website can create a team, add their websites to it and then share an access code.
Other users can use that access code to join the team which allows them to view those shared websites.


Documentation is missing for some functions

Take a look at UnitQuaternion::from_scaled_axis. It’s just not there :(

Arf, that looks like a bug in rustdoc and I don't think there is a workaround! I guess I could add the list of methods on the type alias description, but that's far from optimal...

Yeah, I read libc has a broken doc as well :/.

I prefer to keep this issue open. Just as a reminder and to notify others until the bug is fixed.

for reference: rust-lang/rust#32077


fix: add new redis events

Ok, I did apply all the changes we have in the current master of redis as they are mostly cosmetic.
All tests pass with the current version, old deployment scripts also work on this new version.
Important changes for this task are

we already have round emitted for commit here so it's not needed to add
https://github.com/ethersphere/storage-incentives/blob/83d585bf0f6e1a6fb86b4266128d5392e5875e64/src/Redistribution.sol#L303
line 398 https://github.com/ethersphere/storage-incentives/blob/83d585bf0f6e1a6fb86b4266128d5392e5875e64/src/Redistribution.sol#L398
where we emit current round and anchor
line 669 https://github.com/ethersphere/storage-incentives/blob/83d585bf0f6e1a6fb86b4266128d5392e5875e64/src/Redistribution.sol#L669
where we add the current round to the winner event, so we can associate the winner with the winning round and/or just fetch the current round for this claim
line 670 https://github.com/ethersphere/storage-incentives/blob/83d585bf0f6e1a6fb86b4266128d5392e5875e64/src/Redistribution.sol#L670
where we now have validChunkCount added as an event, also added pot size, which could be useful but can remove

Additional note, there is also round number emmited for reveal in each reveal event
https://github.com/ethersphere/storage-incentives/blob/83d585bf0f6e1a6fb86b4266128d5392e5875e64/src/Redistribution.sol#L427
but as we need to emit anchor, it seemed ok to emit also round number there.

Closing this one as we want to apply all of this on v0.4.0 so this PR is not valid.


Fixed "undefined" name for extensions

Added logic to the networkLabel(entity) method in entity.js to use entity.extendedEntityName instead of entity.name if entity.name is
undefined.
If you'd prefer to go in a different direction with this I'd be happy to make any changes you want. This was just my quick and dirty fix to get this working for myself and I figured I'd share.

Looks good! 👍  Thank you very much for the improvement!

Looks good! 👍  Thank you very much for the improvement!


Multi-column merge and switch between hash and sort-based approaches

This pull request adds the following:

a new function merge that calls the multi-column libgdf code
a new test test_dataframe_multi_column_join that checks the merge function
a new type argument in join that allows to switch between the hash and sort-based implementations

Depends on https://github.com/gpuopenanalytics/libgdf/pull/52

Adding notes: this PR depends on https://github.com/gpuopenanalytics/libgdf/pull/52

@sklam I’m ok if you push changes directly to this PR

Looks good to me and the build failed on something completely unrelated. Restarted it and upon successful completion I'll merge. Thanks!

Looks good to me! Merging. Thanks all!


chore(dec-config): add tests to role updater

Description
Increase test coverage for the role updater in declarative config.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

see CI.

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#10421
#10420
#10419  👈
#10418
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dhaus67 and the rest of your teammates on  Graphite

/retest

Merge activity

Apr 7, 1:20 AM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.


Fix bug in SI set_vacuum_chamber

This bug has been lurking for almost four years now, when model SI_V20_01 was created ...
It was introduced in commit 116daf7886f0ea9dda05e6fe12d851a82a5377ce when the model was shifted in order to introduce physical limits for ID vacuum chambers. The shifting function creates a new the_ring which was not passed back to the main create_lattice function.
Although this bug affects only SI model, I standardized the code for the other accelerators.

I'm  not sure about the origin of this bug, @xresende. I think it is new and I introduced it when I changed the behavior of pyaccel in some refactoring I have done recently....
I think might worked before, because a copy, at least a copy of the elements, was not done, so the return of the ring model was not needed.
I'm not sure about this either.... For now it is just a feeling.

I'm not sure about the origin of this bug, @xresende. I think it is new and I introduced it when I changed the behavior of pyaccel in some refactoring I have done recently....
I think might worked before, because a copy, at least a copy of the elements, was not done, so the return of the ring model was not needed.
I'm not sure about this either.... For now it is just a feeling.

I understand. You might be right: it may have been introduced when trackcpp python lib was changed. Anyway, I think we did not use pyaccel for any calculation from which specs were defined, so the bug probably did not compromise anything. Even the study of IDs was performed mainly with matlab AT, I think.

I have commented out ID vacuum chambers or now.
fixed hmax in injection section.
added 4 mm vchamber limits also in marks in high field BC regions.


What is the unique key that you provides in android to understand each device , Also  serial number always shows unknown

What is your question?
import 'dart:developer';
import 'dart:io';
import 'package:device_info_plus/device_info_plus.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(),
);
}
}
final DeviceInfoPlugin deviceInfoPlugin = DeviceInfoPlugin();
class MyHomePage extends StatelessWidget {
const MyHomePage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ElevatedButton(
onPressed: () async {
if (Platform.isAndroid) {
AndroidDeviceInfo androidDeviceInfo =
await deviceInfoPlugin.androidInfo;
print(androidDeviceInfo.serialNumber);
} else {
IosDeviceInfo iosDeviceInfo = await deviceInfoPlugin.iosInfo;
String? deviceId = iosDeviceInfo.identifierForVendor;
//log(iosDeviceInfo.data.toString());
// print(iosDeviceInfo.identifierForVendor);
}
},
child: const Text('Authticate')),
),
);
}
}
class UniqueIdentifier {
/// Define a Method channel with 'unique_identifier' name
static const MethodChannel _channel = MethodChannel('flutter/platform');
// Static function for getting the identifier
// Returns Future<String?>
static Future<String?> get serial async {
final String? identifier = await _channel.invokeMethod('getSerialNumber');
return identifier;
}
}
here my code
What is the unique key that you provides in android to understand each device , Also  serial number always shows unknown
Checklist before submitting a question

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Unique device identifiers (like serial number) is something that both Google and Apple don't allow developers to get in recent versions of their OSes.
For example, here is Google's guide on this topic: https://developer.android.com/training/articles/user-data-ids
Thus, Plus plugins have no way to get such identifiers.


README - fix broken links

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Hey @sureemo
It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


css variable --mdc-select-ink-color not affecting mwc-select

** PLEASE READ THIS BEFORE FILING AN ISSUE **
I'm submitting a:

[ x] bug report
[ ] feature request

What OS are you using?
Chrome on OSX
Current behavior:

The CSS variable --mdc-select-ink-color is supposed to control the text color of the selected value in mwc-select, but it doesn't.
Steps to reproduce:
https://jsbin.com/jifipinini/edit?html,console,output

nice catch


fix(panic): fix panic when censoring utf-8

Summary

https://github.com/TwiN/go-away/issues/43
Modified indexToRune to correctly count runes up to the given byte index. Adjusted Censor function to handle multi-byte characters properly, ensuring accurate index calculations during the censoring process. Updated incrementation of currentIndex to consider byte length, facilitating correct string iteration.
Checklist

[x] Tested and/or added tests to validate that the changes work as intended, if applicable.
[x] Updated documentation in README.md, if applicable.

My bad, flubbed the PR and accidentally opened a new one here: https://github.com/TwiN/go-away/pull/64


⚠ Bofrost.de has degraded performance

In 4cb967f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1505 ms

Resolved: Bofrost.de performance has improved in 138deef after 6 minutes.


calc with square brackets doesn't work

Reproduction link
Put the below code in Template part of https://vueuse-playground.netlify.app

    Text

Reference from Windi post
Steps to reproduce

See in the Preview
Background doesn't turn to red
Inspect in the console

What is expected?
Utility is properly generated.
What is happening?
Utility is not properly generated.

It's interesting, I found that the expression only works if you add spaces to the calc. such as height: calc(100% + 1rem). You can temporarily use h-[calc(100%_+_1rem)], _ will be replaced with a space. It's actually a css bug.

Thanks @voorjaar

You are welcome. I'm thinking about whether I should  to solve this issue.

Whitespace is required for + and -, but not for * and /. But it is recommended to add whitespace for consistency.
MDN Ref
So I think showing autocompletion for calc with _ would solve this issue.

yeah. that's a good idea.

Is that fixed the issue? It doesn't worked for me with this code: w-[calc(100% + 10px)] or even w-[calc(100%_+_10px)] on WindiCSS v3.1.9

Mine works with h-[calc(100%_-_44px)]


Different registry return different signingPayload

I accidentally creating signingPayload by using another registry since I thought I can do it. The result is it creating incorrect payload that I can not submit to network. Here is the reproduce code:
import * as api from '@polkadot/api';
import * as util from '@polkadot/util';
import * as txwrapper from '@substrate/txwrapper';
import axios from 'axios';

const url = 'http://localhost:8080';

async function main() {
	const material = (await axios.get(`${url}/transaction/material`))
		.data as Record<string, any>;

	const keyring = new api.Keyring();
	const alice = keyring.addFromUri('//Alice', { name: 'Alice' }, 'ecdsa');

	const registry = txwrapper.getRegistry(
		material.chainName,
		material.specName,
		Number(material.specVersion),
	);

	const unsigned = txwrapper.methods.balances.transfer(
		{
			value: '10000',
			dest: '5DpGPTju2gHJKo8cjWRGwzyUPKHBkGVm7d9HH6XUyn5qi1p6', // random address
		},
		{
			tip: 0,
			nonce: 2,
			address: alice.address,
			eraPeriod: 10000,
			blockNumber: Number(material.at.height),
			blockHash: material.at.hash,
			genesisHash: material.genesisHash,
			metadataRpc: material.metadata,
			specVersion: Number(material.specVersion),
			transactionVersion: Number(material.txVersion),
		},
		{
			registry,
			metadataRpc: material.metadata,
		}
	);

	const extrinsicPayload = registry.createType(
		'ExtrinsicPayload',
		unsigned,
		{
			version: 4,
		}
	).toU8a({ method: true });

        const anotherRegistry = txwrapper.getRegistry(
		material.chainName,
		material.specName,
		Number(material.specVersion),
	);
        const anotherExtrinsicPayload = anotherRegistry.createType(
		'ExtrinsicPayload',
		unsigned,
		{
			version: 4,
		}
	).toU8a({ method: true });

        console.log('These payload are different:');
        console.log('extrinsicPayload:', util.u8aToHex(extrinsicPayload));
        console.log('anotherExtrinsicPayload:', util.u8aToHex(anotherExtrinsicPayload)); // This one will always fail after sign and submit to network
}

main().catch(console.log);

Is this behavior expected?

Yes, this is expected behaviour.
tl;dr you need to set the metadataRpc on the registry for it to work correctly. The first registry implicitly has the metadataRpc set on it when you call txwrapper.methods.balances.transfer but this never happens for the second registry (anotherRegistry).
Below is a modified version of your code snippet that shows one approach using getRegistry to to make sure the metadata is set on the registry. Look at the in code comments for a detailed explanation and links to relevant txwrapper code.
Feel free to ask any clarifying questions.
import * as api from '@polkadot/api';
import * as util from '@polkadot/util';
import * as txwrapper from '@substrate/txwrapper';
import { metadataRpc } from '@substrate/txwrapper/lib/util';
import axios from 'axios';

const url = 'http://localhost:8080';

async function main() {
	const material = (await axios.get(`${url}/transaction/material`))
		.data as Record<string, any>;

	const keyring = new api.Keyring();
	const alice = keyring.addFromUri('//Alice', { name: 'Alice' }, 'ecdsa');

	const registry = txwrapper.getRegistry(
		material.chainName,
		material.specName,
		Number(material.specVersion)
	);

	const unsigned = txwrapper.methods.balances.transfer(
		{
			value: '10000',
			dest: '5DpGPTju2gHJKo8cjWRGwzyUPKHBkGVm7d9HH6XUyn5qi1p6', // random address
		},
		{
			tip: 0,
			nonce: 2,
			address: alice.address,
			eraPeriod: 10000,
			blockNumber: Number(material.at.height),
			blockHash: material.at.hash,
			genesisHash: material.genesisHash,
			metadataRpc: material.metadata,
			specVersion: Number(material.specVersion),
			transactionVersion: Number(material.txVersion),
		},
		{
			registry,
			// The metadaRpc is used to set the metadata on the registry when this method is being executed.
			// Because of this, the registry you pass in here will now have the metadata set everytime you use it
			// after this method executes.
			// See here for how the method sets the metadata on the registry:
			// https://github.com/paritytech/txwrapper/blob/18960c95a6830653fc48e098698a8d8b15fd5808/src/util/method.ts#L60
			metadataRpc: material.metadata,
		}
	);

	const extrinsicPayload = registry
		.createType('ExtrinsicPayload', unsigned, {
			version: 4,
		})
		.toU8a({ method: true });

	// Pass in the optional 4th param to `getRegistry` so the metadataRpc will be set on the registry
	// for you
	const anotherRegistry = txwrapper.getRegistry(
		material.chainName,
		material.specName,
		Number(material.specVersion),
		// Here, we can pass in the metadataRpc, and `getRegistry` will set it on the registry for us.
		// However, if we don't pass it in then it will not be set on the registry for us and it will need
		// to be done at some later point with `registry.setMetadata(createMetadata(registry, metadataRpc));`
		// See here for how `getRegistry` sets the metadata on the registry:
		// https://github.com/paritytech/txwrapper/blob/18960c95a6830653fc48e098698a8d8b15fd5808/src/util/metadata.ts#L125
		metadataRpc
	);
	const anotherExtrinsicPayload = anotherRegistry
		.createType('ExtrinsicPayload', unsigned, {
			version: 4,
		})
		.toU8a({ method: true });

	console.log('These payload are different:');
	console.log(
		'The two payloads are the same because they have the same metadata set on the registry: ',
		util.u8aToHex(extrinsicPayload) ==
			util.u8aToHex(anotherExtrinsicPayload)
	);
}

main().catch(console.log);


CellRank integration

Hi there, I was really happy to see the CellRank interface you guys created! Does this work yet/is there anything we can do from our side to further push this integration?

Hi Marius,
Thanks for your interest! Still working on getting it fully functional, e.g. with some of the downstream analysis functionality offered by CellRank.
At the moment I'm mostly occupied with other things, but I'm planning to look further in this direction in the coming weeks. Would be great if I could ask some questions about the CellRank API.
Stephen

Hi Marius,
Thanks for your interest! Still working on getting it fully functional, e.g. with some of the downstream analysis functionality offered by CellRank.
At the moment I'm mostly occupied with other things, but I'm planning to look further in this direction in the coming weeks. Would be great if I could ask some questions about the CellRank API.
Stephen

Hi Stephen, absolutely, I'm more than happy to help here, just let me know when something comes up.

Hi Stephen, absolutely, I'm more than happy to help here, just let me know when something comes up.

Congrats to the preprint!

Regarding integration into CellRank, I had the following idea: we could create a cellrank.external module, similar to how this is handled in scanpy. In this external API, we could expose your statOT kernel so it can be used conveniently form within CellRank, again similarly to how this is done in scanpy. We would of course explicitly reference statOT in the docstring and link to your package for documentation and support. Accessing statOT in this way would still require users to install your statOT package, hence it would only benefit your download numbers.
From your side, it would have the advantage that it would increase visibility & download numbers, plus access to some of CellRank's efficient downstream functionality, e.g. our implementation of abs. probabilities, which uses PETSc's GMRES implementation parallelised across subproblems, which allows us to compute abs. probs for 100k cells in 2 min without GPU acceleration.

Hi Marius,

Congrats to the preprint!
Thanks! Hopefully StationaryOT can offer some complementary functionality to CellRank.

Regarding integration into CellRank, I had the following idea: we could create a cellrank.external module, similar to how this is handled in scanpy.

Yes I agree that sounds like a good way to interface the two methods (at least tentatively -- am yet to mention this to my coauthors). I suppose the idea would be that we can use CellRank in cases where RNA velocity seems too noisy or may be not so applicable. Would you suggest something the lines of exposing the OTKernel in the current StationaryOT code to the CellRank internals?

Hi @zsteve, exactly, that's it, in extends CellRank to situations where RNA velo currently isn't applicable. At the same time, it makes it really easy for everyone already used to the CellRank API to use StationaryOT, i.e. it would also generate more users for StationaryOT.
Re integration, did you already check out how this is done in scanpy external? Basically, the idea would be to have something very similar where there is a shallow wrapper in CellRank that imports and calls the kernel that you already have implemented in StationaryOT.

Hi @zsteve, that makes sense - let's prioritize the quadratic regularized OT for the integration then. We'll set up a prototype for the integration and link the PR here so you can review it and give us feedback! Does that sound good to you?

Yes, that sounds good! Looking forward to hearing back.


Feature request: Rotation?

Since images are fake item frame entities (as far as I know), it would be great to allow:
item-rotation
Useful for image of an arrow (won't have to make four images for four directions), etc.
entity rotation (free pitch and yaw)
Useful for roadsigns on 45° diagonal roads, etc.
Thanks!

Hello @Kinboise,
At this time I don't have plans to implement rotation. IMO, it will add too much complexity to both the code and the usage (i.e., new arguments will be needed for the "place" command).


Styles are not included in the template

It would be important to specify in the README that styles or other template assets must be added manually after also manually creating the dist/ folder.

@Abdur-rahmaanJ I was thinking of including the assets of each template in the jamstack package, I know that it might increase a little the size of the package, but I think it would be the most logical, because it is assumed that if you offer a template, it should be with all the "toys", it would only include the minimum for the template to work, css files, js, and images that include, replace them using lorem picsum. I think that way the package would be more complete.

Misrerferenced issue

Misrerferenced issue

How?

@Jalkhov i closed this by mistake on commit. I said close this wrong issue

Well, you can close it anyway, I think, and it has been implemented to add the assets of each template.


please review and merge if happy with it

it replace with scratch ver

pls reply

IS this the branch you were talking about


No definition found(when open vscode.app)

I've searched google and github for this issue. But I do not find the key to fix this issue.
Environment data
With Python 3.7.2 installed:
vscode 1.32.3
Mac Mojave 10.14
pylint 2.3.1
astroid 2.2.5
Python 3.7.2 (default, Feb 12 2019, 08:15:36)

➜ pydemo$ code --list-extensions --show-versions
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
I've set the interpreter:
{
     "python.pythonPath": "/usr/local/opt/python/libexec/bin/python",
}

Expected behaviour
Go to denifition successfully
Actual behaviour
I find that if I open code cli from Iterm2 or terminal .
The code  works well with go to definition.  (vscode will analyze project with 100% cpu usage at the
same time)
$ '/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code'

If I open vscode.app through dock or terminal or iterm2,
vscode will not analyze my project, and vscode will say No definition found for ...
$ open /Applications/Visual\ Studio\ Code.app

Steps to reproduce:

Install python plugin and config:  "python.pythonPath": "/usr/local/opt/python/libexec/bin/python",
Open /Applications/Visual\ Studio\ Code.app
create a simple file to test go to definition.

Logs
There is no logs output.
The following is Screen Shot of Develop Tool:

I find that if I open code from Iterm2 or terminal .
The code will work well with go to definition.
$ code

If I open code.app through Mac OSX dashboard.  It tell me No definition found for ...

I find that if I open code cli from Iterm2 or terminal .
The code  works well with go to definition.
$ /usr/local/bin/code

If I open vscode.app through dock or terminal or iterm2.  It tells me No definition found for ...
$ open /Applications/Visual\ Studio\ Code.app

Another issue, it also does not work for go to variable's definition.
from .user.config import name

Click name's position and type F12 also get error: No definition for ...

Please check the gif you mentioned in Steps to reproduce . Can you please try uninstalling the second item Python for VS Code from the list?

<EMAIL_ADDRESS>
Make sure its not there by checking the above line is no longer present on running code --list-extensions --show-versions.

I've uninstalled tht13.python and problem  doesn't appear.
➜ www$ code --list-extensions --show-versions
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>➜ www$

At present, if I open /bin/code , a segment error appears from python-language-server.

# config.py
name = "Jack"

Could not go to  variable's definition:
# main.py
# Could not go to  `name` definition:
from config import name

Any update on this? Same is happening here.
<EMAIL_ADDRESS>

Remove tht13.python and problem is still at there
➜ www$ code --list-extensions --show-versions
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>➜ www$

At present, if I open /bin/code , a segment error appears from python-language-server.

This seems like a separate issue, can you please open another issue for this? thanks

@mplachter @ahuigo Also, meanwhile while I am trying to reproduce this, can you please confirm if this particular to Python extension? i.e if other languages also pose the same issue, it maybe a bug on the vscode end.

@karrtikr No worries I totally for got about this.
I actually found my issue on this.
I updated my Python from 3.7.1 to 3.7.3 and my pipenv symlinks broke which vscode was using.
After a quick
pipenv --rm and another pipenv install i was back up and running.
@ahuigo I don't know if this was your issue ^

After I update python-language-server, the problem seems to gone.
https://github.com/Microsoft/python-language-server/issues/875#event-2277618550


Color Wrapping Error

When you have enough health to use up every entry in a given list, the colors start again from the first entry. This is expected behavior, but what isn't expected is which two colors the wrap causing health bar assumes.
Given the 10 color values seen below (vanilla red hearts enabled)

This is what happens in the health bar after the wrap, visualised is the 11th row of health being overlayed by row 12's color in this case 13 hp worth. But since there are only 10 colors defined, it instead wraps back to color 1 and 2 respectively, which is what I observed below working as intended.

What about rows 10-11? What I expected to happen is as before, full health on row 10's Maroon means it gets overlayed by row 11's aka row 1's Red, right?

But instead, this happens, red (color1) overlayed by orange (color2), which mind you occurs when you run out of row 11 health, meaning ingame it looks like your row 12 health glitches back to full after losing it all. Losing the miscolored row 10-11 row hp then skips to the correct 9-10 row hp

This bug occurs on a color list of any size, and is most noticable on the default lists of damaging status effects; Poison, Wither, and Freezing. As those lists are only 2 entries long, having any more than 40 max health will cause each full row lost to refill to color 2 when depleted until you reach the last 20 hp (10 Hearts)

I hope that this fixed the issue, the testing I've done makes it seem like the colors are wrapping fine now

That seems to work, thank you very much!


Ben/oct debt

Buen trabajo. veamos si puedo ayudar

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Yurzan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


RevEng and Migrations: Consider testing schema roundtripability

While EF will always only understand about a subset of the database constructs,
we have done work to improve the fidelity of database reverse engineering, e.g. in https://github.com/aspnet/EntityFramework/pull/3579 we made sure that names of indexes were preserved in the model. From https://github.com/aspnet/EntityFramework/issues/2840#issuecomment-151241655:

Thinking on this some more. If we want the model to be as "round-trippable" as possible, we will need to specify at least the index's name for all indexes. The name we would otherwise generate through migrations is not likely to be the same as it depends on whatever tool the DBA used to create the index in the first place (@lajones)

I would like to propose that we deliberately test how good the experience is when the user:

Points reverse engineering to an existing database to produce an EF model
Points migrations using the resulting model back to the database to make changes

Note that I don't think the goal of this should be to achieve 100% fidelity but to understand the gaps and possibly identify low hanging fruit that we can tackle to improve both reverse engineering and migrations.
cc @Eilon

We could consider adding an automated end-to-end test for a database that we know roundtrips in this way. It could help detect regressions, but I am not sure about the cost/benefit.

Great idea, I will do that for the SQLCE provider!

Closing this for now, with the understanding that we will likely have similar things to test as part of update-model-from-database, and we should do what we need to do in the context of that feature.


New style ConvolutionND/DeconvolutionND

Related to #2745. This challenging PR aims to update ConvolutionND/DeconvolutionND functions to support double back propagations.
(I finally want to integrate Convolution2D and ConvolutionND, and derive Convolution2D as a special case of ConvolutionND, however, in the first stage this PR aims to rewrite ConvolutionND with reference to Convolution2D, and support double back propagations.)

I finished implementation. After merging this PR I would like to unify Convolution2D and ConvolutionND.
(It includes implementation of dilated convolution and grouped convolution in ConvolutionND)


Spacing issue in runtime error message/request for more in-depth message

Per @mflaxman10 https://github.com/omnisci/mapd-core/commit/c1e25fb72394553591a7990d252d9060fe178ba5#r31212210
This line needs a space after the word column:
https://github.com/omnisci/mapd-core/blob/master/Parser/ParserNode.cpp#L3005
Also, there is an additional request to have an example printed when the error occurs:

would be nice to have an example of intended correct syntax.
At the time of creating a new geometry column, seems odd to be required to generate a default > geometry. The default I would want is “NULL” until/unless a sensible value is imported or UPDATEd.

Per https://github.com/omnisci/mapd-core/commit/c1e25fb72394553591a7990d252d9060fe178ba5#r31251338, this should be resolved


Fix command execution in mac osx

Fix for #669. The OSX shell script would break if you didn't have bash rather than printing and exiting gracefully.

merge with master and the build should stop erroring

Pull Request Test Coverage Report for Build 4148

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.884%

Totals

Change from base Build 4140:
0.0%

Covered Lines:
8774

Relevant Lines:
9549

💛  - Coveralls


How to make use of own docker registry

Hi,
How to make use of own private docker registry or export/import of docker image for deployment. Is it possible for both the methods.
Regards,Vikas

When using this project, you can use docker images from the docker hub or from where ever you want. You specify that in the image. If you dont want to upload an image to eg. the docker hub, you can copy the image to the nodes before deployment. Then the node will already have the image, and use that instead of pulling one from the hub.

Hi,
Please assist , details below
[vagrant@k8s-worker-1 ~]$ sudo docker images
REPOSITORY                             TAG                 IMAGE ID            CREATED             SIZE
mongodb                                latest              ad627cd74195        17 minutes ago      437MB
weaveworks/weave-npc                   2.3.0               21545eb3d6f9        2 months ago        47.2MB
weaveworks/weave-kube                  2.3.0               f15514acce73        2 months ago        96.8MB
gcr.io/google_containers/pause-amd64   3.0                 99e59f495ffa        2 years ago         747kB
vikas@ubuntu:~/working$ more mongodb.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: mongodb
labels:
app: mongodb
spec:
replicas: 3
selector:
matchLabels:
app: mongodb
template:
metadata:
labels:
app: mongodb
spec:
containers:
- name: mongodb
image: mongodb
imagePullPolicy: Never   # tried with Never and IfNotPresent
vikas@ubuntu:~/working$ kubectl get pods
NAME                       READY     STATUS                 RESTARTS   AGE
mongodb-5fd8dfd8c6-jhbhn   0/1       ErrImageNeverPull      0          11m
mongodb-5fd8dfd8c6-k55m8   0/1       CreateContainerError   0          11m
mongodb-5fd8dfd8c6-ldgt4   0/1       CreateContainerError   0          11m
mongodb1-6dd5768c5-6t7s4    0/1       ErrImageNeverPull      0          4m
mongodb1-6dd5768c5-gflfp    0/1       CreateContainerError   0          4m
mongodb1-6dd5768c5-k7xcd    0/1       CreateContainerError   0          4m
mongodb2-55dbfd9449-4dqjw   0/1       ImagePullBackOff       0          3m
mongodb2-55dbfd9449-5dz5p   0/1       ImagePullBackOff       0          3m
mongodb2-55dbfd9449-8tmsx   0/1       ImagePullBackOff       0          3m

Regards,Vikas

How many workers did you make?
Try
kubectl get pods -o wide
Then you can see which node the pod is scheduled on.

Hi,
I need to deploy the existing imported docker image ,getting below message.Please let me know how to do so.
[vagrant@k8s-worker-2 ~]$ sudo docker images
REPOSITORY                                             TAG                 IMAGE ID            CREATED              SIZE
mongonew                                               latest              f6e11dbc36f9        About a minute ago   437MB
weaveworks/weave-npc                                   2.3.0               21545eb3d6f9        2 months ago         47.2MB
weaveworks/weave-kube                                  2.3.0               f15514acce73        2 months ago         96.8MB
gcr.io/google_containers/k8s-dns-sidecar-amd64         1.14.7              db76ee297b85        8 months ago         42MB
gcr.io/google_containers/k8s-dns-kube-dns-amd64        1.14.7              5d049a8c4eec        8 months ago         50.3MB
gcr.io/google_containers/k8s-dns-dnsmasq-nanny-amd64   1.14.7              5feec37454f4        8 months ago         41MB
gcr.io/google_containers/pause-amd64                   3.0                 99e59f495ffa        2 years ago          747kB

Events:
Type     Reason                 Age               From                   Message

Normal   Scheduled              7m                default-scheduler      Successfully assigned mongodb2-9f7b4c9c5-p4zwb to k8s-worker-1
Normal   SuccessfulMountVolume  7m                kubelet, k8s-worker-1  MountVolume.SetUp succeeded for volume "default-token-xh8sk"
Normal   SandboxChanged         6m (x2 over 6m)   kubelet, k8s-worker-1  Pod sandbox changed, it will be killed and re-created.
Normal   Pulling                6m (x3 over 6m)   kubelet, k8s-worker-1  pulling image "mongonew"
Warning  Failed                 5m (x3 over 6m)   kubelet, k8s-worker-1  Failed to pull image "mongonew": rpc error: code = Unknown desc = Error response from daemon: pull access denied for mongonew, repository does not exist or may require 'docker login'
Warning  Failed                 5m (x3 over 6m)   kubelet, k8s-worker-1  Error: ErrImagePull
Normal   BackOff                5m (x6 over 6m)   kubelet, k8s-worker-1  Back-off pulling image "mongonew"
Warning  Failed                 1m (x20 over 6m)  kubelet, k8s-worker-1  Error: ImagePullBackOff
vikas@ubuntu:~/working$ kubectl get pods -o wide
NAME                       READY     STATUS                 RESTARTS   AGE       IP           NODE
mongodb-cf496b778-4w98q    0/1       CreateContainerError   0          6m        <IP_ADDRESS>   k8s-worker-2
mongodb-cf496b778-n8d5j    0/1       ErrImageNeverPull      0          6m        <IP_ADDRESS>     k8s-worker-1
mongodb-cf496b778-zm8z6    0/1       CreateContainerError   0          6m        <IP_ADDRESS>   k8s-worker-2
mongodb2-9f7b4c9c5-j6trp   0/1       ImagePullBackOff       0          8m        <IP_ADDRESS>   k8s-worker-2
mongodb2-9f7b4c9c5-jvpt4   0/1       ImagePullBackOff       0          8m        <IP_ADDRESS>     k8s-worker-1
mongodb2-9f7b4c9c5-p4zwb   0/1       ImagePullBackOff       0          8m        <IP_ADDRESS>     k8s-worker-1
Type     Reason                 Age               From                   Message

Normal   Scheduled              3m                default-scheduler      Successfully assigned mongodb-cf496b778-n8d5j to k8s-worker-1
Normal   SuccessfulMountVolume  3m                kubelet, k8s-worker-1  MountVolume.SetUp succeeded for volume "default-token-xh8sk"
Warning  ErrImageNeverPull      1m (x12 over 3m)  kubelet, k8s-worker-1  Container image "mongonew" is not present with pull policy of Never
Warning  Failed                 1m (x12 over 3m)  kubelet, k8s-worker-1  Error: ErrImageNeverPull
Regards,Vikas

Hi,
rephrasing the question
I need to deploy the  imported docker image in one node to all the nodes in the cluster, how to do so
Regards,Vikas

If you dont push it to a registry, you will have to import it to all nodes manually. One at the time.

try tagging it with something like vikas/mongodb:4 . Save it, copy it to worker nodes, and import it.
Then in your yaml file, reference to it as vikas/mongodb:4.
It should work.


[CMAKE] cmake.exe v3.5 crashes when building opencv

I discovered a bug in latest CMake 3.5 that affects OpenCV.
In the file cmake\cl2cpp.cmake, the code attempts to strip comments from *.cl files using some regular expressions.
This was working fine in 3.4.3, until I tried to build OpenCV using the latest CMake 3.5.1... Something must have changed between 3.4.x and 3.5.x, and now cmake itself crashes during the process! It occurs when it reaches the bioinspired module when processing the retina_kernel.cl file.
This was confirmed with cmake 3.5.1, opencv/opencv_contrib 3.1.0, windows 10 (the cmake compilers/generators don't matter). It only manifests on Windows platforms.
After a chat on #cmake, I tracked the issue using the --trace flag to this line:
  string(REGEX REPLACE "/\\*([^*]/|\\*[^/]|[^*/])*\\*/" ""   lines "${lines}") # multiline comments

Apparently CMake regex-matching is implemented recursively, and that pattern on certain inputs ends up with a call depth too deep  running out of stack space and crashing..
To give an example, here is minimal test case that triggers the bug (happens on Windows, Linux cmake didn't crash):
file(READ "C:/opencv_contrib/modules/bioinspired/src/opencl/retina_kernel.cl" lines)
string(REGEX REPLACE "/\\*([^*]/|\\*[^/]|[^*/])*\\*/" "" lines "${lines}")
file(WRITE out.txt "${lines}")

C:\> cmake -P strip.cmake

Parsing C/C++ code this way using regexps is usually a bad idea. Ideally a proper parser or comment-stripping tool should be used for this task...
For now and as a workaround, we could delete comment lines like //**************** from that file. It makes it easier to regex-match that way, and avoid the recursion error for the moment.  :)

Actually we trying to minimize a set of 3rdparty dependencies. So I'm not sure that we will use some cross-platform comments stripping tool in the near future.
Thanks for workaround again!

I got the same issue with cmake 3.6.2 under windows.

This should be workarounded in upstream.


Property docker_package_build_image unused

To change the name of the docker image I add the following property to build.py:
project.set_property('docker_package_build_img','myrepo/myimage:{}'.format(project.version))
docker_package_build_image seems to be unused.
Additional suggestion: if the name does not contain a colon, append project.version.

And there seems to be an inconsistency concerning the expected return value of get_build_img. If docker_package_build_img is unset, the version is appended.
However, do_docker_push appends the version a second time, so I think get_build_img should not return the version at all.


The Travis CI badge is not working

It says the build is faling. But if I click the badge then I see a page that is saying "This is not an active repository"

@niccokunzmann I'm not sure what is the problem. You probably should know what is going wrong.

Oh, there are more texts below :)

You don't have sufficient rights to enable this repo on Travis.
Please contact the admin to enable it or to receive admin rights yourself.

Seems like collaborators do not have admin rights.

I think, I resolved the issue. Please check and close.

It works now!


ISPN-11427 RestMetricsResource#testMicroprofileMetricsMetadata can ti…

…meout
https://issues.redhat.com/browse/ISPN-11427
Metrics are really slow with a lot, thus it is the first run test in the suite.

CI has some strange failures, but I did not get those failures locally. Merged. Thanks @wburns !
Should I let the jira still open as this does not really fix the underlying issue ?

Fine by me. However we want to proceed.
On Sat, Mar 7, 2020, 9:41 AM Adrian Nistor<EMAIL_ADDRESS>wrote:

CI has some strange failures, but I did not get those failures locally.
Merged. Thanks @wburns https://github.com/wburns !
Should I let the jira still open as this does not really fix the
underlying issue ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/infinispan/infinispan/pull/8002?email_source=notifications&email_token=AAE6H3Z55QFWLJ26G67UWADRGJMKZA5CNFSM4LCMPLG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOD3C2I#issuecomment-596095337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE6H33GGMDQ4IQ5BTZDR5DRGJMKZANCNFSM4LCMPLGQ
.

I've backported to 10.1.x also

@wburns Actually, I think I'll just close that jira as I'm satisfied with current results. This inefficiency in JsonMetadataExporter should never happen in real life.


the screenshot in the ‘’Log Analytics workspace overview‘ is telling customer only analytics table can be restored

Hi team,
in doc https://learn.microsoft.com/en-us/azure/azure-monitor/logs/log-analytics-workspace-overview , the 2nd pic attached in this doc only saying that analytics kind of table can be 'restored' or querying with the 'searching job'. This is creating confusion, and customer is not sure if we may restore a basic kind of table in azure monitor, can this be corrected, please?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 22ef97d5-9a43-be23-f9a5-5662e8148b01
Version Independent ID: f934f3cf-b010-0d82-2ffc-169703411e00
Content: Log Analytics workspace overview - Azure Monitor
Content Source: articles/azure-monitor/logs/log-analytics-workspace-overview.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@LeoYuAtMicrosoft
Thanks for your feedback! We will investigate and update as appropriate.


Facebook Share button

Add facebook share button with dynamic url

Getting "Error" in place of share button. Also lets add FB like. People tend to click like more than share


Add formatRoute function to react-router-config

I'm using the formatRoute function of react-router-named-routes for quite a while and this function makes totally sense and I wish to have it in the official package (react-router-config maybe).
To use this function the right way the routes Route Configuration Shape needs to be in an object instead of an array so that you can reference a specific route path in a component.
Because this package is still in alpha it should be not a big deal to change the API again.
import { routesConfig } from 'config/routes';

<Link
  to={
    formatRoute(routesConfig.app.routes.user.path, {
      userId: user.id,
    })
  }
/>

We've already got that: https://github.com/ReactTraining/react-router/blob/a163b3ae57714563ffd4113e995220d4cd64bc25/packages/react-router/docs/api/generatePath.md

Ah okay haven't seen it.
But there is still the problem with referencing one route path from the routes config.


[ZEPPELIN-1009] [HOTFIX] Fix Selenium test error

What is this PR for?
Fix selenium test error described in ZEPPELIN-1009
What type of PR is it?
Hot Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1009
How should this be tested?
Outline the steps to test the PR here.
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@Leemoonsoo Previous errors are gone, nice find

Looks great to me

I'm getting different error ...
Results :

Tests in error:
  ZeppelinIT.testAngularDisplay:151->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 Â» Timeout

Fixed all error on Zeppelin.java
try { handleException("Debug 1", new RuntimeException()); } catch (Exception e) {};
now getting errors from ParagraphIT
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.873 sec - in org.apache.zeppelin.integration.ZeppelinIT

Results :

Tests in error:
  ParagraphActionsIT.testRemoveButton:149->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout
  ParagraphActionsIT.testMoveUpAndDown:186->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout
  ParagraphActionsIT.testCreateNewButton:80->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout

Tests run: 15, Failures: 0, Errors: 3, Skipped: 0

Here's some experiments about ParagraphIT error,

It passes on my local machine with firefox 31.0 (the same version with travis uses)
It passes on my travis account, constantly
It fails on apache travis account, constantly

And i tried narrow down what cause the error on apache travis account, and in case of ParagraphActionIT.testCreateNewButton, it opens paragraph's setting dropdown menu successfully,

And i believe it locates Inserts New button and click(), but nothing happens and test fails.

Sounds great! Shall we merge this guy then, and handle this nasty click in ParagraphActionIT.testCreateNewButton in separate pr?

@bzz Let me merge this into master and branch-0.6 then
@randerzander Thanks for reporting the problem. yes they might be related!


Feature request: Return publisher list on data.netskope_privateapps

data netskope_privateapps does not provide a list of publishers bound to this app. This is critical information when wanting to bind a new publisher to the app. Alternatively we could another function to return this data
eg
data.netskope_privateapps_pubishers

Thank you for this feature request. I will review this and see what we can do.

Investigating including "service_publisher_assignments" which the API returns now. If I can make it work, I will include it it my next update.

In the latest version(v0.2.5) includes "service_publisher_assignments" in the private apps resource.


Geting TLS Channel Binding data for later use in SCRAM

I need to use TLS channel binding data in SASL SCRAM. Easiest way for me is using BC as provider, because I don't want to implement own AbstractTlsServer (especially getCredentials() is thing I don't fully understand).
So, please add way to get channel binding data after notifyHandshakeComplete() via ProvSSLEngine.
Or improve implementation of DefaultTlsServer to be easy to use. 😄
Thanks

e.g.:
byte[] channelBinding = ((BCSSLEngine)engine).getConnection().getChannelBinding("tls-exporter");

Unfortunately it doesn't work, when I use BC as provider:
java.lang.IllegalStateException: Export of key material only available from notifyHandshakeComplete()

There is no way to disable cleanupHandshake() or export those data before cleanup.

Oh I see that this is broken because we currently clear the master secret (and in TLS 1.3 the exporter secret) after the handshake completes. Our existing tests only cover "tls-unique" channel binding so this wasn't picked up.
A quick fix would be to calculate the "tls-exporter" channel binding for all connections, but it'd be nicer if it could be on demand, including access to the more general TlsContext#exportKeyingMaterial.

@peterdettman: Have you progressed on it?
Thanks in advance.
Linked to:

https://github.com/bcgit/bc-java/issues/1198

@Neustradamus I have a branch that adds BCSSLParameters#setChannelBindings; those channel bindings will then be established at handshake completion for later collection via BCSSLConnection#getChannelBinding . This is fairly simple but the binding "tls-exporter" has the annoyance that it might be calculated for TLS 1.2 even when you only wanted it in case TLS 1.3 was negotiated (and e.g. "tls-unique" otherwise). I'm inclined to use a separate "tls-exporter-legacy" for the TLS 1.2 case.
Another possibility would be using a callback in the vein of SSLEngine#setHandshakeApplicationProtocolSelector that is called to determine the list of channel bindings (with access to the handshake session presumably).
Finally, I've been contemplating to just have a callback that will give access to the new BCSSLConnection while the "handshake completion window" is still open. There are concerns here around threading issues. The standard JSSE HandshakeCompletedListener notification is thread-decoupled, which would defeat the purpose here. OTOH, SSLSessionBindingListener calls are not thread-decoupled, but I guess that is not so tangled up in the actual protocol. Maybe BCSSLConnection could store values like a session, or perhaps this callback could return a generic "user data" Object that could be collected via a different BCSSLConnection method later.
Comments welcome on the above, or if I've overlooked a better option.

I tried to use ProvSSLEngine in RADIUS EAP TLS Authentication (server side), but I am stuck on how to use TlsContext#exportKeyingMaterial, which is necessary to generate MPPE keys.
With Java Reflection, I can get the field protocolPeer then the method getTlsContext, but calling exportKeyingMaterial when SSLEngineResult.HandshakeStatus.FINISHED failed with the same exception.
java.lang.IllegalStateException: Export of key material only available from notifyHandshakeComplete()
I guess it is the same reason of cleanupHandshake().


Fix batch add tasks failure message

Fix string formatting when only one task fails in a batch operation.
Stack Trace:
TypeError: not enough arguments for format string
  File "/task-clean-timeline-azure/app/tasks/list_camera_assets.py", line 48, in main
    asyncio.run(remove_from_azure(list_parameters))
  File "asyncio/runners.py", line 43, in run
    return loop.run_until_complete(main)
  File "uvloop/loop.pyx", line 1451, in uvloop.loop.Loop.run_until_complete
  File "/task-clean-timeline-azure/app/tasks/list_camera_assets.py", line 86, in remove_from_azure
    await save_batch_delete_tasks(loop, batch_tasks)
  File "concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/task-clean-timeline-azure/app/tasks/list_camera_assets.py", line 153, in <lambda>
    job_id=AZ_BATCH_ACCOUNT_REMOVE_JOB_ID, value=batch_tasks
  File "/usr/local/lib/python3.7/site-packages/azure/batch/custom/patch.py", line 282, in bulk_add_collection
    task_workflow_manager.errors)
  File "/usr/local/lib/python3.7/site-packages/azure/batch/custom/custom_errors.py", line 41, in __init__
    result.task_id,\

Can one of the admins verify this patch?

Thanks for the catch and fix!


Add isEven and isOdd functions

I will add this, but unfortunately, your pull request has an n argument, and so I can’t merge it, because the function should not have an n argument. Again, I will add this to the script.


Issue installing bcrypt

I'm having the same installation issue as #17.
I'm using windows/cygwin
I've followed these instructions for installing node.
https://github.com/joyent/node/wiki/Building-node.js-on-Cygwin-(Windows)
I've also followed several of these instructions.
https://gist.github.com/579814
I can successfully run Node.
I have successfully installed a half dozen or so packages with NPM.
bcrypt is the only package I've found which fails.
If someone can help with this I'd really appreciate it.
Here's the end of the error log:
info build /home/Hero/node_modules/bcrypt
verbose from cache /home/Hero/node_modules/bcrypt/package.json
verbose linkStuff [ false, false, false, '/home/Hero/node_modules' ]
info linkStuff<EMAIL_ADDRESS>verbose linkBins<EMAIL_ADDRESS>verbose linkMans<EMAIL_ADDRESS>verbose rebuildBundles<EMAIL_ADDRESS>verbose rebuildBundles [ '.bin', 'nodeunit' ]
info install<EMAIL_ADDRESS>verbose unsafe-perm in lifecycle true
silly exec sh "-c" "node-waf configure build"
info<EMAIL_ADDRESS>Failed to exec install script
ERR! error installing<EMAIL_ADDRESS>Error<EMAIL_ADDRESS>install: node-waf configure build
ERR! error installing<EMAIL_ADDRESS>sh "-c" "node-waf configure build" failed with 1
ERR! error installing<EMAIL_ADDRESS>   at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/exec.js:49:20)
ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.emit (events.js:67:17)
ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.onexit (child_process.js:192:12)
info unbuild /home/Hero/node_modules/bcrypt
verbose from cache /home/Hero/node_modules/bcrypt/package.json
info preuninstall<EMAIL_ADDRESS>info uninstall<EMAIL_ADDRESS>verbose unbuild<EMAIL_ADDRESS>[ false,
verbose unbuild<EMAIL_ADDRESS> '/usr/local/lib/node_modules',
verbose unbuild<EMAIL_ADDRESS> '/home/Hero/node_modules' ]
info postuninstall<EMAIL_ADDRESS>verbose installOne cb<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>install: node-waf configure build
ERR! sh "-c" "node-waf configure build" failed with 1
ERR!
ERR! Failed at the<EMAIL_ADDRESS>install script.
ERR! This is most likely a problem with the bcrypt package,
ERR! not with npm itself.
ERR! Tell the author that this fails on your system:
ERR!     node-waf configure build
ERR! You can get their info via:
ERR!     npm owner ls bcrypt
ERR! There is likely additional logging output above.
ERR!
ERR! System CYGWIN_NT-6.1-WOW64 1.7.9(0.237/5/3)
ERR! command "node" "/usr/local/bin/npm" "install" "bcrypt"
verbose exit [ 1, true ]

Can you provide instructions in the README on how to install bcyrpt using cygwin?

Should be npm install bcrypt from within your project directory.

I think I'm going to save myself some future head aches and move back over to Linux...don't know why I ever left for dev work...

Well, if you are interested in working on Windows, there is work being done to get this module to compile on Windows proper...you can follow GH-66 for more info and updates.
That said, I agree with your sentiment. Linux FTW. ;D


Frequent crash due to UI

When the number of sensors are too large, the ui will crash. To fix this problem, we need to take care of both the number of colors and number of views.

I have tried to fix this problem by doing what follows:
change  private boolean[] drawSensors = new boolean[6];
to  private boolean[] drawSensors = new boolean[20];
and use an if-else statement to handle the case when the number of sensors is larger than 9

fixed


Table starts from second page if rows spans more than 1 page

Hi. I have configured a docx template which has 3 parts - top content, table below that, and a footer.
If the table fits in the first page, the output is as expected. But if it doesn't, the complete table starts from the second page, followed by more pages, if required. The top part is NOT a header. Just some content at the top.
Also, the table header is marked in Word to repeat, but it does not do that either.
This is what the ouput looks like:

Is there some configuration I am missing in this library, or is it a bug?

Sorry for the late reply. Can you post a reproduction example? AFAIK the default should be that a table spans multiple pages and starts where you expect it.

Thanks for the reply @jjhbw
Here's a Git project sample: https://gitlab.com/siddhant1991/docxtemplatetest

@jjhbw Were you able to reproduce it?

@jjhbw Not sure what you mean by removing the lines between table & text at the top.
I did set text wrapping to none & that did not work.
Could you please share the updated docx which works for you?

I mean this whitespace. Not sure what it is. Some kind of newline.
Adjusted template (untested; i just downloaded and applied the changes I remember from this morning).
bill_fixed.docx

That works. Thanks for sharing the file.
The UI was getting a bit messed up when removing that space.. but the final Doc generated was indeed correct.


SECURITY.md: New VDP policy

SECURITY.md: New VDP policy
Problem
The CMS VDP has been updated to reflect the launch of our new bug bounty program! As a result, SECURITY.md needs to be updated accordingly.
Solution
Updated SECURITY.md for all the tiers to reflect below:
https://www.cms.gov/about-cms/information-systems/privacy/vulnerability-disclosure-policy

LGTM +1 :ship:
—RemyD.
Remy DeCausemaker
Open Source Lead
Digital Service at CMS.gov

From: Natalia Luzuriaga @.>
Sent: Tuesday, August 13, 2024 7:19:01 AM
To: DSACMS/repo-scaffolder @.>
Cc: DeCausemaker, Remy (CMS/DSAC) @.>; Review requested @.>
Subject: [DSACMS/repo-scaffolder] SECURITY.md: Updated VDP text to include bug bounty program (PR #136)
SECURITY.md: Updated VDP text to include bug bounty program
Problem
The CMS VDP has been updated to reflect the launch of our new bug bounty program! As a result, SECURITY.md needs to be updated accordingly.
Solution
Updated SECURITY.md for all the tiers to reflect below:
https://www.cms.gov/about-cms/information-systems/privacy/vulnerability-disclosure-policy

You can view, comment on, or merge this pull request online at:
https://github.com/DSACMS/repo-scaffolder/pull/136
Commit Summary

0baf69bhttps://github.com/DSACMS/repo-scaffolder/pull/136/commits/0baf69b0f2eee1e7efe94396965268c6df827947 updated VDP text

File Changes
(4 fileshttps://github.com/DSACMS/repo-scaffolder/pull/136/files)

M tier1/{{cookiecutter.project_slug}}/SECURITY.mdhttps://github.com/DSACMS/repo-scaffolder/pull/136/files#diff-75358a6075153c866b904e21508f946519ea02e9e5ed23416dbf4b18923d07e6 (6)
M tier2/{{cookiecutter.project_slug}}/SECURITY.mdhttps://github.com/DSACMS/repo-scaffolder/pull/136/files#diff-90101cfbbdfbf7340c80d9704cd52b75f479184bf8f710cb49fb27d1b2d4f1b5 (6)
M tier3/{{cookiecutter.project_slug}}/SECURITY.mdhttps://github.com/DSACMS/repo-scaffolder/pull/136/files#diff-ef2019debf291c7e2cc18bd77a7664d9db456a10d5abe68340ae520c0d55ef4e (6)
M tier4/{{cookiecutter.project_slug}}/SECURITY.mdhttps://github.com/DSACMS/repo-scaffolder/pull/136/files#diff-e5f98d023483643674bfb67c2f857371a078aef72917aeb8f03428d081f71447 (6)

Patch Links:

https://github.com/DSACMS/repo-scaffolder/pull/136.patch
https://github.com/DSACMS/repo-scaffolder/pull/136.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/DSACMS/repo-scaffolder/pull/136, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZXUXULM77PZI3BMPCVUNC3ZRIIVLAVCNFSM6AAAAABMOMILWOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DGNBXHAZDANQ.
You are receiving this because your review was requested.Message ID: @.***>


use core-js

Hey @ohze, thanks for your pull-request! It looks great.
Do you mind sending it again to the most up-to-date git remote? (under RobotlegsJS organization) https://github.com/RobotlegsJS/RobotlegsJS-SignalCommandMap

Oh.. I dont know that repo 😄
Yes. I will create a PR to RobotlegsJS/RobotlegsJS-SIgnalCommandMap


Is it possible to integrate HAXeditor in Joomla?

Sorry if this is the wrong place for such a general question.
I'm an IT freelancer and am currently helping a client pick a CMS.
My contact at the client's organisation has a preference for Joomla (based upon her familiarity with Joomla elsewhere in the past).
As far as I know, there isn't any HAX integration available for Joomla at the moment.
Are there any plans to provide an integration for Joomla ?
Are there any technical reasons which would prevent someone (worst case me) from developing an integration?
Thanks,
Richard

This queue is fine. Good question. We'd love for there to be a HAX plugin for Joomla and provide generic PHP classes that speed up integration, so no there's no reason there couldn't be a Joomla plugin. I've just never made one and didn't have a reason to but I'd gladly provide advisement in getting one created if you took the lead on it. We want HAX for every platform imaginable. If you look at the Drupal 7, WordPress and gravcms integrations you'll see they arn't terribly different in how they integrate and they use a class that helps write the "appstore" specification mentioned on the haxtheweb.org site

some reference links:

some classes to help w/ integrations - https://github.com/elmsln/hax_php_lib

A few integrations that then implement these / other classes

D8 - https://git.drupalcode.org/project/hax
WordPress - https://github.com/elmsln/wp-plugin-hax
GravCMS - https://github.com/elmsln/grav-plugin-hax

Some ecosystems also have a webcomponents plugin/module which leverages some classes from the 1st repo. While not required, they help implement the methodology of integration that I tend towards for progressive enhancement integrations. My guess is joomla won't need this as it already has some web components in core (Im not part of that community but have talked off and on in the past so that might not be the case but it's what I discerned from those discussions)

question hopefully answered. @richardsullivan I'd be happy to help answer any questions relative to this integration on twitter or in another thread sometime. Closing out for tidying things up but yes, it is possible and we'd love to help.


CI: Reduce resource usage and speed up testing cycle

I found the CI to be rather heavy, it takes ages to complete. This patch makes it a bit more lightweight, following practises we already applied to other repositories successfully [1], without ending up missing any incompatibility issues so far.

Take CrateDB 4.8 release out of the test matrix
Run only a single test matrix slot for macOS and Windows, using the most recent stable Python 3.11. I think it is acceptable.

References

[1] https://github.com/earthobservations/wetterdienst/pull/817

I think this should at least also include a test with the last major CrateDB version, as there are still many clusters running 4.x versions. However it might be sufficient to do this on a single OS/python combo.

I've updated the patch to follow the suggestion by @proddata, and re-enabled integration testing against CrateDB 4.8.4. Integration testing is currently only active/possible on Linux.
https://github.com/crate/crash/blob/1f2a82d230592787a501a08e06d6a1b60c3d520f/tests/test_integration.py#L28-L29


More work to get the tests passing on node 0.12 & io.js

I've fixed the issue with strictSSL tests by explicitly setting a cipher that matches the cert.
With node 0.12/ io.js there's now an error thrown by socket#setTimeout when it's passed a negative number. https://github.com/joyent/node/blob/master/lib/timers.js#L160
I've tried to catch this error when req#setTimeout is called here https://github.com/request/request/blob/master/request.js#L907 using a try catch, but it only seems to get caught in process.on('uncaughtException'). Any ideas how to handle this better; do we still need this test?

Please merge master into your branch so we can see the results of the tests on Node 0.12 and io.js in CI (you also don't need the tests to run on 0.8, which should also be fixed when you update this with master).

Yes the test passes I'll push the msecs fix shortly and re-enable iojs/0.12 in the build

Thanks @BBB :+1:

No worries @simov :)


[DO NOT MERGE] Extract Snark Coordinator into independent deployment entity of Local Network manager and add its account into the Genesis Ledger.

As per internal discussion within: https://o1-labs.slack.com/archives/C02ASV6BZCY/p1669225187865919
Closes https://github.com/o1-labs/quality-and-testing/issues/15

@dkijania LGTM, please push small updates we've been discussing and we can merge it.


refactor: minor code refactoring

Codecov Report

Merging #5 (9fd3a99) into develop (dbf28c1) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
- Coverage    81.78%   81.31%   -0.48%
===========================================
  Files            9       10       +1
  Lines          302      305       +3
===========================================
+ Hits           247      248       +1
- Misses          36       38       +2
  Partials        19       19

Impacted Files
Coverage Δ

publisher/test/test.go
33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf28c1...9fd3a99. Read the comment docs.

Codecov Report

Merging #5 (9fd3a99) into develop (dbf28c1) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
- Coverage    81.78%   81.31%   -0.48%
===========================================
  Files            9       10       +1
  Lines          302      305       +3
===========================================
+ Hits           247      248       +1
- Misses          36       38       +2
  Partials        19       19

Impacted Files
Coverage Δ

publisher/test/test.go
33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf28c1...9fd3a99. Read the comment docs.


International Leave this site options

Issue :
Issue number: 888
Issue link: https://github.com/chaynHQ/bloom-frontend/issues/888
What changes did you make?
Added International to Leave this site options, now wikipedia and google links open respective to user's current language
Why did you make the changes?
This feature was obvious to have and also had an issue on the repo
Did you run tests?
I ran tests

Hi @anmol-fzr, this looks great from an initial look. As per our Contributor Guidelines, to accept your PR, you need to claim an issue. I can't seem to tag you without you commenting on the issue. This helps us keep track and document open-source contributions. 😄  Can you comment on  the issue and then I can properly reviewand authorise the workflow 🎉

@eleanorreem  Hopefully this PR is ready to be merged. Merge this if possible if not please inform so that i can make suitable changes

Hey @anmol-fzr, this PR is failing to build unfortunately. The error I get looks like the screen shot below. Running yarn build and running the yarn lint  will ensure you don't encounter these errors. The error comes from the use of double quotes where single should be used. Let me know if you have any questions. Thanks!

@eleanorreem I have fixed the Linting Error you mentioned while building this project i also encountered error about "@mui/system" library i didn't changed any other file as this library is used in the code on the official repo, assuming this won't cause errors on build.

Thanks for this!


Fix, missing quotation which left the cmd not working

Coverage increased (+72.4%) to 78.571% when pulling d8f513e237eff78b469e2c33c806d0481fb4c7f7 on fix-cmd-arguments into e4f5682a75c35337b367569a573570d2da7fbbef on master.


fix(website): correct typo in getting started

This pull request just corrects some typo in the website.

Thanks!

Thanks!


An offline cluster cannot be deleted

Describe the bug
To Reproduce
Steps to reproduce the behavior:

Join a new cluster.
Create an application and deploy it to this cluster.
Cluster arrears or other reasons go offline.
The application can not be deleted, because the cluster is offline.
The cluster can not be detached, because there are some applications.
The deadlock...

KubeVela Version
1.2.X

This is currently a feature. Offline clusters could return back later. Therefore we could use vela delete --force command to solve this problem. There should be a more detailed mechanism to handle the garbage collection of resources in ResourceTracker, for example skip part of them.

the application can be deleted by vela delete --force

the application can be deleted by vela delete --force

We need to support this feature in VelaUX.

@Somefive Another way to do this is to remove the offline cluster from the application configuration and publish it again.

the application can be deleted by vela delete --force

We need to support this feature in VelaUX.

Not agree to that. vela delete --force is a dangerous action and is not recommended. Users need to really know what they are doing and the side effect for running this command, like resource leak. For VelaUX users, they usually cannot ensure that, then this super button can easily destroy the resource management.
Instead, I think on VelaUX, we should provide a comprehensive view for all the managed resources like ArgoCD. Then when deletion of application is blocked, a redirect should be given to user and let user to determine how to handle each blocked resources.

@Somefive Another way to do this is to remove the offline cluster from the application configuration and publish it again.

The offline cluster could be used by lots of applications, and this action could potentially cause a huge number of application restarts. This behavior is also dangerous and could lead to unpredicted performance issues. We should consider the solution carefully.

In general, I agree this problem is crucial. In CLI, we previously work on vela delete --force to give a solution, which I believe, is not a final elegant solution. The best potential solution currently I come up with is the fine-grained resource control on top of ResourceTracker, which needs some time to implement but is not a high priority target by now. If other light elegant solution is proposed, we can work on it faster.

We now removed the in-use check when detaching clusters. And we have vela delete -i to manually remove resources in application.


docs: restore broken static mutants documentation link

The previous link returned a 404 not found github page.
The new link returns the stryker documentation page.

Replaced with the stryker page link, as the code itself also referenced this page.


Adding possibility of spesifying 'dsaas-services' explicitly

@kbsingh @l0rd @aditya-konarde please review

oh man, thisis ricky to read - lower case V/s uppercase being different scopes and variables.


Display unread notifications when first opening the notifications page

Currently our notifications logic is written in a way, that the notifications page displays only the already read messages. So when first opening the notifications page some notifications can be hidden (for example the seed backed up message). After closing and opening the page again it will be visible.
The fix should cause the new notifications be visible at first opening the notifications page.

It works good with superhero(.)com and the main wallet account.
I tried to receive some new notifications when switched between wallet subaccounts, and it seems not updating properly. When I'm leaving some comments I will not receive any notifications. @peronczyk could you please check it?

fixed in https://github.com/superhero-com/superhero-wallet/pull/2715


Remove noisy log in BlockMaster

This line is too noisy and provides little to no valuable information. Will only get worse if default block size is reduced.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5646/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please

alluxio-bot, cherry-pick this to branch-1.8 please


Convert build plan buttons to links

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[ ] Server: I followed the coding and design guidelines.
[ ] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[ ] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[ ] Server: I implemented the changes with a good performance and prevented too many database calls
[ ] Server: I documented the Java code using JavaDoc style.
[ ] Client: I followed the coding and design guidelines.
[ ] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[ ] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[ ] Client: I documented the TypeScript code using JSDoc style.
[ ] Client: I added multiple screenshots/screencasts of my UI changes
[ ] Client: I translated all newly inserted strings into English and German.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.

Motivation and Context
Links to repositories of programming exercises are links and therefore one can open them directly in a new tab. The build plans, however, are still implemented as buttons that have the annoying property of only being left-clickable.
Description

Steps for Testing

Log in to Artemis
Navigate to Course Administration
...

Test Coverage

Screenshots

It also seems that the methods are reordered? At least, some classes have many changes they should not have, I think, even if we include your intentions.

@MaisiKoleni Thanks for the feedback. Yeah, quite possibly I didn't have a second look after using auto reformatting. I reset three files and applied spotless so this should be fine again.
Regarding your other comments:
I can see that this change doesn't make much sense at the moment since it's not part of the scope. I personally like DTOs because they implement the principle of single responsibility => If I introduce some attribute that only a few TS components need, I don't need to share those with all of them because especially when loading tables with a lot of information, this can slow down quite a lot if you don't sit at Uni with a 1 GB/s
I understand that it's not convenient having two things covering a similar area at the same time, however, you can't prevent that if you want to have small PRs
I think for now I will save these changes in a local branch, reset this one and just fix this issue by adding transient attributes as you suggested. Makes the most sense 👍

@julian-christl Please note that I cannot decide that, I can only give you my estimation on the reaction. In the end, you will need to ask Stephan here. I just want to stress this here because in the past my opinion on things was used as sole decision basis and Stephan was not happy with that.

@MaisiKoleni No worries. I don't copy opinions from others but change my opinion based on new facts :D
And in this case, I can just see for myself that it makes more sense to do the fix and a potential refactoring separately.

For the record, I'll leave this PR closed since it contains information not relevant to the final code and will open a new one.


If the functional tests are named same, the UI fails.

Solution: Do not allow duplicate names.

No longer relevant


WIP: A stab at implementing a bucket iterator

I haven't been working on it. I still want to use it, but I really have just been kicking the can down the road.
From memory, I ran into a few issues with the current implementation. It's been a while so I'm foggy. I don't remember any of them being blockers.
First, though it seems like I may have solved this in herehttps://github.com/jgaskins/aws/pull/10/files#diff-0a81a714d51746a69d2f471f07cbc83a3a7f6b1fe640f47e3c0797c0110819aeR31-R33, there is some bug with URL generation / escaping. #5 tried to solve it, but I didn't do it correctly. This change should probably just be broken out into it's own PR.
The second is filtering. Even a modest S3 bucket can have thousands of objects in it. My use case is recovering from a production bug where a bunch of things were named incorrectly, and I have about 10k objects with incorrect keys which I'd like to correct. However I have ~3M keys in the bucket and iterating all of them is going to be a bear. I stalled out while looking into the S3 API for ways to filter the keyspace before iterating. The current status is I just have 10k broken references, but amid the rest of the working references the error rate is low enough I've just been living with it. My (foggy) memory is that there's a straightforward path through this with the API.


Resizing image fails

I am trying to resize a image after it's uploaded to the destination folder
$image = Image::make(sprintf('/assets/img/projects_images/09e1ce51bedade9825cb4b70b633284c4989c07b-FkN9to9eYoLB.jpg'))->resize(900, 700)->save();
But when executing the resize function it's giving error, what i am doing wrong

You first have to install Intervention Image's requirements.

What needs to be installed, plz suggest and how to