[BUG] Backups are not getting deleted even after crossing retain count.

Describe the bug
Retain count is not getting applied to backups. Older backups are not getting deleted when backup counts are exceeding the count of retain.
To Reproduce
Steps to reproduce the behavior:

Create a volume(3 replicas, 3 nodes), attach to a pod
Write data to volume. Take a snapshot s1.
Enable recurring backup with retain count 10.
After system takes 5 backups, revert to s1.
Recurring backups will start to be taken from s1 similar as shown in below screenshot.
Backups taken before reverting to s1 would not get deleted even the count of recursive backups exceeds the retain count.

Expected behavior
Backups up to retain count should only be retained.
Environment:

Longhorn version: master
Kubernetes version: v1.17.5
Node OS type and version: ubuntu, aws node

Additional context
Also, the editing of retain count is not getting applied to backup retain functionality.

Is it because the backup retain was changed to 5? Can you try to retain at 5 when creating the new recurring job?

Actually, After reverting to snapshot, it is keeping backups till retain count starting from there and not deleting the backups taken before reverting. Is it something expected?
Recurring snapshots get deleted in above scenario.
I've updated the steps to reproduce.

I don't expect a revert to affect anything here. We will take a look.

The backup retention code works correctly, the reason this happened is that to determine whether to include a backup in our cleanup we compare all the backup labels with the job labels. One of these labels is the Kubernetes status, which comes from the volume directly.
If you have look at your screenshot you will see that the volume switched to a different pod, which means that the content of the kubernetes status label is different from the previous backups kubernetes status label.
@yasker we should discuss whether we want to change the logic to exclude the kubernetes status label from that comparison. Since it seems to really be transient information.

Pre-merged Checklist

[ ] Is the backend code merged?
[ ] Is the reproduce steps/test steps documented?
[ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
[ ] If labeled: require-automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case?
[ ] if labeled: require-automation-engine Has the engine integration test been merged?
[ ] if labeled: require-doc Has the necessary document PR submitted or merged?

Verified in master - 9069373 commit id
Verification- Passed
Backups are getting deleted after reaching over retain count.
Steps followed to test:

Created a volume(3 replicas) and attached it to a pod.
Created a backup b1.
Enable recurring backup with count 5.
After system takes 5 backups, Scaled down the workload to 0 and reverted to b1.
Scaled up the workload volume got attached to a different pod.
As a new recurring backup was created the oldest recurring backup got deleted.


chore: added classes for network communication

Closes: 8537
Description
This PR includes following changes

Removed workaround for CustomAttributes and replaced with actual fix
UserAgentStore so creation of user agents can still be handled in SDK wrappers
CustomAttributeContextualSerializer for parsing CustomAttributes
CustomAttributeSerializer to allow passing any custom objects in CustomAttributes
HttpClientBuilder to keep all transformations for http params in a single place
TrackingHttpClient for making network calls
Network constants, data models and extensions

I did leave some comments I would like for you to see @mrehan27. Besides that, I approve of this.

Thanks @levibostian. Merging this PR 🎉


[VL] Support using Celeborn in the scenario of switching multiple SparkContexts in the same process of Velox CI

What changes were proposed in this pull request?
Support using Celeborn in the scenario of switching multiple SparkContexts in the same process of Velox CI
How was this patch tested?
If we switch the SparkSession in the Velxo CI, the following exception will occur.
 [Executor task launch worker for task 0.0 in stage 8.0 (TID 8)] WARN  org.apache.celeborn.shaded.io.netty.channel.AbstractChannel - Force-closing a channel whose registration task was not accepted by an event loop: [id: 0xca6cd07d]
java.util.concurrent.RejectedExecutionException: event executor terminated
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:932) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:834) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:825) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:815) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.channel.AbstractChannel$AbstractUnsafe.register(AbstractChannel.java:483) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:87) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:81) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.channel.MultithreadEventLoopGroup.register(MultithreadEventLoopGroup.java:86) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.bootstrap.AbstractBootstrap.initAndRegister(AbstractBootstrap.java:323) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.bootstrap.Bootstrap.doResolveAndConnect(Bootstrap.java:155) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.shaded.io.netty.bootstrap.Bootstrap.connect(Bootstrap.java:139) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.common.network.client.TransportClientFactory.internalCreateClient(TransportClientFactory.java:219) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.common.network.client.TransportClientFactory.createClient(TransportClientFactory.java:169) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.client.ShuffleClientImpl.pushOrMergeData(ShuffleClientImpl.java:719) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.celeborn.client.ShuffleClientImpl.pushData(ShuffleClientImpl.java:791) ~[celeborn-client-spark-3-shaded_2.12-0.2.0-incubating.jar:?]
	at org.apache.spark.shuffle.utils.CelebornPartitionPusher.pushPartitionData(CelebornPartitionPusher.scala:53) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at io.glutenproject.vectorized.ShuffleSplitterJniWrapper.split(Native Method) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.shuffle.CelebornHashBasedColumnarShuffleWriter.internalWrite(CelebornHashBasedColumnarShuffleWriter.scala:145) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.shuffle.CelebornHashBasedColumnarShuffleWriter.write(CelebornHashBasedColumnarShuffleWriter.scala:95) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.scheduler.Task.run(Task.scala:136) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551) ~[gluten-it-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_352]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_352]
	at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_352]

@zhouyuan cc

@kerwin-zk Was this well-tested? We don't have CI job against Celeborn yet.

@kerwin-zk Was this well-tested? We don't have CI job against Celeborn yet.

@zhztheplayer  Yes. This PR is to support 1185 Celeborn CI. After 1185 is merged, there will be Celeborn CI.


"Require" validation  (data annotation) not working for select list

No error comes when we apply require attribute to Select list in mvc 6.
Posted issue at
http://forums.asp.net/t/2056134.aspx?Select+list+require+validation+mvc+6+using+data+annotation

Copying from the forum:

How to apply validation to select list in mvc 6 ( i need to implement data annotation validation )

for exaple in model i have applied "Required" attribute to "year" filed.

for example : code

<select asp-for="Year">
<option selected value=""></option>
<option value="2015">2015</option>
<option value="2014">2014</option>

</select>

Other fields validation are working fine but for select item it is not working at all.
can you give me a live example ?

The [Required] attribute meant something different than its MSDN documentation in earlier versions of MVC. We have corrected that bug in MVC 6. Use [BindRequired] to ensure a struct field has a value.
In this case your model likely includes
  class MyModel
  {
    ...
    [Required]
    public int Year { get; set; }
  }

Change that to
  class MyModel
  {
    ...
    [BindRequired]
    public int Year { get; set; }
  }

[BindRequired] is in the Microsoft.AspNet.Mvc.ModelBinding namespace.

Please update your forum and close it if this answers your question.

Thanks Dougbu, But it seems [BindRequired] is not working with me .
    [BindRequired]
    public string Year { get; set; }

    [Required(AllowEmptyStrings =true,ErrorMessage = "Text Box value Required")]
    public string Name { get; set; }

Issue-

Using BindRequired how we can set error message like Required?
BindRequired  itself not working, i can give you source code to you.

Do you have some documentation for this ?

@rahuldhariya01

Overriding the error message is not currently supported.
Which MVC Beta are you using? The source code might help me see the issue faster.

Do you have some documentation for this ?
[BindRequired] is described fairly completely as "model binding will add a ModelState error for properties with this attribute that are not present in a submission`. Other than that, not much documentation (yet).

@dougbu
Appreciate your help.
PFA (https://drive.google.com/file/d/0B_t4iGqASEkeN0tCSlV2UDQ2b2M/view?usp=sharing)

Validation to select list
how to set selected value from server side (C#)
BindRequired is not working.

@Dougbu, any update on this issue ?

@rahuldhariya01 Your Beta 4 application shouldn't need any change from the original. I incorrectly thought the Year property was an int but it's string. [Required] does what you want for string properties in all versions of MVC 6, including Beta 4. ([BindRequired] is more important in Beta 5 and Beta 6 but is not relevant for your project.)
What problems remain when using [Required]?
FYI I took your sample and changed the HomeModel back (I assume) to
        [Required]
        public string Year { get; set; }

The generated HTML is now:
    <select data-val="true" data-val-required="The Year field is required." id="Year" name="Year">
        <option value="">Select Now </option>
        <option>2016</option>
        <option>2017</option>
    </select>

And client-side validation means I get errors if I hit Submit without filling in the Year field.

Thanks for help.


Add SnapshotProducer that can rewrite manifests

This PR adds a SnapshotProducer implementation that allows for rewriting the manifests for a table. This can be used to reorganize the manifests for more optimal query planning.
We have a situation where we are frequently appending to a table, and each append covers a wide range of partitions. The resulting lower/upper bound range for the partitions covered by the append manifests is thus very broad. As the manifests accumulate, query planning became slow as Iceberg is not able to effectively prune partitions at the manifest level.
We plan to use this new API to rewrite the manifests and organize them by partition so Iceberg will be able to more efficiently prune partitions during query planning.

Am I correct that this API reorders manifests and their content? MergingSnapshotUpdate keeps the ordering to efficiently age off data files. Do we expect users to apply this API to recent manifests on a regular basis if their writes frequently modify a lot of partitions?
Also, what will happen if our clustering key assigns a lot of files to one manifest? Will commit.manifest.target-size-bytes be respected?

This will create entirely new manifests (with a new snapshot ID and with new contents) that replace existing manifests, so in essence, yes, the manifests and contents will be reordered. We were planning to apply this API on a regular basis on new manifests (e.g. hourly or daily). Also, commit.manifest.target-size-bytes will not be respected thus this could generate large manifest files.
I first thought of adding this functionality to MergingSnapshotProducer but this would either generate far too many manifests (trading long file scans for long manifest scans) or generate manifests with wide partition ranges as it does now.
Respecting commit.manifest.target-size-bytes should be straightforward if that is desired. I'm not sure how respecting manifest order is possible though.

Yeah, I also don't think it is possible to respect manifest order. I brought this topic to better understand the implications. It seems if we apply this regularly and incrementally we will still have some order. At some point, I was wondering about optionally optimizing the manifest layout while merging groups in MergingSnapshotUpdate. However, your idea seems better.
Respecting table properties would be nice, though.

I'll go ahead and add support for commit.manifest.target-size-bytes now...

I added the manifest size check. It doesn't appear that there is an easy way to get the bytes written by the ManifestWriter, so I'm using a size estimation.

BTW I also made a minor change to put new manifests at the beginning of the manifest list to be consistent with the other snapshot producers

Merged. Thanks for contributing this, @bryanck!
And thanks for reviewing this, @aokolnychyi and @danielcweeks!


DateTimeIndication parse

Hello I've created a python script which uses the FinTs package.
Last week it worked perfectly. Now today the script crashes with the following output:
INFO:mt940.tags.DateTimeIndication:matching`` (10) "1703271108" against "^
    (?P<year>\d{2})
    (?P<month>\d{2})
    (?P<day>\d{2})
    (?P<hour>\d{2})
    (?P<minute>\d{2})\+(?P<offset>\d{4})
    "
Traceback (most recent call last):
  File "test.py", line 17, in <module>
    statement = fintsClient.get_statement(accounts[0], date(2017, 1, 1), date.to
day())
  File "C:\Python\lib\site-packages\fints\client.py", line 84, in get_statement
    statement += mt940_to_array(m.group(2))
  File "C:\Python\lib\site-packages\fints\utils.py", line 7, in mt940_to_array
    return transactions.parse(data)
  File "C:\Python\lib\site-packages\mt940\models.py", line 357, in parse
    tag_dict = tag.parse(self, tag_data)
  File "C:\Python\lib\site-packages\mt940\tags.py", line 70, in parse
    self, value)
RuntimeError: ('Unable to parse "<mt940.tags.DateTimeIndication object at 0x0332
75F0>" from "1703271108"', <mt940.tags.DateTimeIndication object at 0x033275F0>,
 '1703271108')

Is this a problem of my bank? Could this be related to the daylight saving change on sunday?

Whether it's a problem of your bank is debatable, some other bank(s) claim that the tag should contain an offset as well. Apparently your bank doesn't offer an offset so we'll simply have to assume it's a UTC timestamp.
Can you test the current development release? It should fix your issue

Cool :) I've just pushed a new release to pypi. A pip install -U mt940 should do the trick.


[Backport 2.x] Adding cross version support for registering Transport Actions

Description
Manual backport of https://github.com/opensearch-project/OpenSearch/pull/7403
Related Issues
Part of #7402
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #7412 (94336e3) into 2.x (e888511) will increase coverage by 0.08%.
The diff coverage is 80.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #7412      +/-   ##
============================================
+ Coverage     70.32%   70.41%   +0.08%
- Complexity    59734    59809      +75
============================================
  Files          4864     4864
  Lines        287387   287386       -1
  Branches      41744    41745       +1
============================================
+ Hits         202102   202350     +248
+ Misses        68362    68108     -254
- Partials      16923    16928       +5

Impacted Files
Coverage Δ

...nsions/action/RegisterTransportActionsRequest.java
78.94% <80.00%> (-6.06%)
:arrow_down:

... and 476 files with indirect coverage changes


Add"clone" action to docs

Hi ! I am intrested . What should I add to docs ?
Does this refer to how to clone the repo ?

Great!  It's about the "clone" Cursorless action.  You can say eg "clone funk" and it will insert a copy of the function you're in.
You'd want to add a new section just about this one https://github.com/cursorless-dev/cursorless/blob/main/docs/user/README.md?plain=1#L455

thanks!
so I should:

make a new section in the readme called clone
Give an example: clone funk and description: it will insert a copy of the function you are in.
Please rectify if I have misunderstood.
Once thumbs up, I'll make the change in the files.

Yep that sounds about right to me!


HTTP error responses should be JSON

I think error responses should be JSON instead of plaintext. This way it'll be easier for clients to parse error responses automatically and decide which error happened.

Fixed by #275 and #307.


time-compat-1.9.5 fails when built with ghc-8.6.5

Citing from https://hydra.nixos.org/build/138211243:
        hourMinuteFormat
          extended:                                                               FAIL (0.02s)
            *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 82 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=291859 to reproduce.

I can confirm this is still the case; here's with a different seed:
hourMinuteFormat
  extended:                                                               FAIL (0.05s)
    *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
    00:00:60
    Use --quickcheck-replay=502299 to reproduce.

https://buildkite.com/nh2/static-haskell-nix/builds/836#84efc3f6-b089-4199-89b5-65d78f350d8f/6-15554

Here is an exact, pinned reproducer:
NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/7cfaba911d8f82997c3120c8648314c23a77ed4c.tar.gz nix-build --no-out-link --expr 'with import <nixpkgs> {}; haskell.lib.overrideCabal haskellPackages.time-compat (old: { testFlags = (old.testFlags or []) ++ ["--quickcheck-replay" "502299"]; })'
        hourMinuteFormat
          extended:                                                               FAIL
            *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=502299 to reproduce.
          basic:                                                                  FAIL
            *** Failed! "0001": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=502299 to reproduce.
        hourFormat:                                                               FAIL
          *** Failed! "00.0166666666666666": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
          00:00:60
          Use --quickcheck-replay=502299 to reproduce.


Model-container implementation guide

Corresponding issue: #181

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/332/
Test PASSed.

Can you close this and open it as a pull request against the website?


Cannot drag and drop to target position on HEADLESS mode

Expected behavior
I try to drag and drop HTML5 element on headless mode when running with gauge
Actual behavior
Cannot drop to target element although I setViewPort
Steps to reproduce

Implement drag and drop function
Test to see it works well on No Headless mode when I move pointer to target area
But when I switch to Headless mode, it's always failed
I try to setViewPort to 10000,10000 but no thing is changed

Versions
node v12.16.1 and taiko 1.0.16

Please share a sample where this is failing as tests for drag and drop run in headless mode https://github.com/getgauge/taiko/blob/master/test/unit-tests/dropDown.test.js and are passing.

@zabil Is this a test for dropdown? But I have problem with dragAndDrop

Sorry the test is here https://github.com/getgauge/taiko/blob/57ce5a064debf622b6f9359f6360aec8a8d55b16/test/functional-tests/tests/pageActions.ts#L48-L51
It will be much easier to fix look into the issue of you have a code sample.

I used
await dragAndDrop((source), $(destination));
with source is text and destination is xpath. Because it has problem with headless mode, so I wonder if I miss any config here, I’m running it with gauge

I don't think so, if it is working in headful mode it should work on headless mode.
However, most sites render different on headless mode. A quick way to check this is taking a screenshot before the drag and drop call to see if the
screen is the same.

I take screencast and see on HEADLESS mode, the element isn't even highlighted.
https://share.getcloudapp.com/DOuxjBYK
This is screenshot for NO_HEADLESS
https://share.getcloudapp.com/d5uEzRkJ
@zabil Do you have suggesstion is this case?

Unfortunately, Taiko does not highlight elements in headless mode.
It will be much easier to see if this is an issue if you have a sample to replicate this

How can I give you a sample to this issue? Do you need a link web or html structure?

The easiest way is be to share a GitHub repository with a script replicating the issue so that someone can checkout and run it.

@zabil This is my repo https://github.com/levietquynh/tk_support
Could you please help me to check this issue?

@levietquynh I tried to look into the issue and was able to replicate it. On further debugging, it looks like the issue is in the way you are trying to use the source element.
await dragAndDrop('Header', into($("//*[@class='dynamic-digest']"))); in this API since you are using Header taiko will find the text node for Header which is actually not draggable, even the parent node of the Header is not draggable. Actually, there is a multiple levels of nesting in the element. So you might want to change the selector for the source element. Make sure the element which is getting selected should be draggable.

@BugDiver I got what you mentioned but I concern about why I can drag it successfully with NO HEADLESS mode

@levietquynh When taiko finds that the element is not an HTML5 draggable element (in this case), it tries to perform drag and drop by dispatching mouse event. But the chromium has an issue with dispatching mouse events, to the drop happens the current cursor location, which could be out of the browser window. Refer https://github.com/getgauge/taiko/issues/279 and https://github.com/ChromeDevTools/devtools-protocol/issues/130
Now case of Non-Headless, the cursor might be inside the browser window (most probably), so it's able to drop the element. In your script when I moved the cursor out the browser I could see that the element was not getting dropped.
In headless mode, the cursor would not be in browser window at all, hence you seeing the issue.
The best way to solve this is to use some other selector (to select Header) which selects the draggable HTML5 element.

@BugDiver I change to a xpath and see it works well. Thanks so much for your support.

Hi all,
I face same issues as described here before in headful mode with taiko dragAndDrop() in gauge tests on a vue.js ui.
It seems to be a similar above described issue, os takes over mouse control and interrupts mouse move simulation by taiko. Even when the mouse cursor is within the browser window it jumps there while test execution and looses its target. It only works when I help the taiko api with moving mouse cursor manually while execution to target location :/
only then taiko manages to drop the element to the specified target.
I have tried all source/target parameter combinations (label, xpath element selector, distance object) but target is always the flaky thing in my case; not dragging the source;
label -> element
element -> element
element -> distance
label -> distance
`step("And user drags&drops Library vehicle with  into Panel", async(id) => {
//await dragAndDrop("Object Name", "//*[text()='Vehicles']/parent::div/following-sibling::div//*[contains(@class,'dragArea')]" )
//await dragAndDrop($("//*[@class='vId'][text()='"+ id +"']"), "//*[text()='Vehicles']/parent::div/following-sibling::div//*[contains(@class,'dragArea')]" )
//await dragAndDrop($("//*[@class='vId'][text()='"+ id +"']"), {left:340, down:70} )
await dragAndDrop("Object Name", {left:340, down:70} )

});`
In headless mode it doesn't work either.
I'll appreciate any support on this folks.
Thank you
tools setup:
% taiko --version
Version: 1.2.2 (Chromium: 88.0.4314.0) RELEASE
% gauge --version
Gauge version: 1.1.7
% node --version
v14.7.0


[BUG] user-defined-themes.scss broken in 3.0.1

Environment
Self-Hosted (Docker)
System
Chrome 124, Debian 11, Docker 24.0.2
Version
3.0.1
Describe the problem
When upgrading to 3.0.1 with a mounted user-defined-themes.scss file due to the change in startup it doesn't get built therefor meaning custom themes don't work.
Changed in https://github.com/Lissy93/dashy/commit/1bbb91b3fef501b8e23bc8942c6cf59df3db36a5
Reverting back to 3.0.0 fixes this problem and so does reverting the changes in commit by altering the start command
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Hi,
You're right!
I have created and merged a PR to revert the recent changes.
Can you test the new image, by re-pulling the :latest tag from docker-hub?

Looks to be fixed in registry, thanks.


📦 Import RootModel dynamically when accessed directly only

Change Summary
Implement mechanics for dynamic imports of public api exports and use it for RootModel.
Related issue number
None
Checklist

[X] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

please review

please review

It's already approved, please update

I would like @samuelcolvin's approve as he has commented on this one
please review


Redirect script link typo

The "redirect script" link in the second step of the basic instructions redirects to:
https://github.com/rafgraph/spa-github-pages/blob/gh-pages/index.html#L36-L57
but it should redirect here:
https://github.com/rafgraph/spa-github-pages/blob/gh-pages/index.html#L35-L58
Excellent solution by the way, thanks!
regards

sorry, the link is just fine


update FAQ: what are the fees for coinjoin

remove mention of coordinator fees, free remix etc.
and link to the docs for some more info.

Should we mention the leftovers? Considering that they can be higher on certains coordinator (if they increase the min output), it might make sense

done: And occasionally the client also discards their decomposition leftovers, read more here.


Feature/155 Automatically create Run Config

Goes slightly against issue title in that when no run config exists this creates temporarily a new default one which gets discarded after the run.

Looks good to me, works as expected.


[FEA] Allow passing merlin.io.Dataset to Model classes

🚀 Feature request
We should allow passing merlin.io.Dataset classes to functions like model.fit, instead of requiring the TF dataloader.
Motivation
We should be able to pass the merlin.io.Dataset class directly to the models, without having to manually create the TF dataloader. For instance code like this should work:
# get the movielens dataset
from merlin.models.utils.data_etl_utils import get_movielens
train, valid = get_movielens(variant="ml-25m")

# create a simple TF MatrixFactorizationModel on the movielens dataset, and fit it
import merlin.models.tf as ml
model = ml.MatrixFactorizationModel(train.schema, dim=64)
model.compile(optimizer="adam")
model.fit(train, batch_size=1024)

Marc fixed this in #195 - closing


Add support for ballerina program exit hooks

Purpose
The issue with tasks/appointments is that there is no proper way to keep them running. To solve this, we have to make the BVM to wait for all tasks to complete. But there should be a way to notify those running tasks in the event of BVM exit/interruption. This can be supported using ballerina program exit hooks approach.
A ballerina exit hook is similar to the java shutdown hook concept, where the application developer can register hooks (in ballerina these hooks will be a function) with the runtime. The runtime will invoke these hooks/functions whenever it receives a graceful interrupt signal (eg : Ctrl+C).
So how would this solve the issue with tasks?
If there are any registered hooks, the main will not exit. So, if we want to keep the main from exiting after a task creation, we have to register a hook. If you want to properly stop the tasks and clean them before the BVM exits, you can register a exit hook and do the cleaning related stuffs with them. The BVM will make sure to invoke all the registered hooks before it terminates.
The main design decision here is that, if there are any registered hooks only, the BVM will wait on the interrupt signal. But if there are no hooks registered, the BVM will anyway exit at the end of the execution, regardless of any are tasks created. The assumption here is that, if we have created a task and not added a exit hook, then it is considered a daemon task, which means the main can exit at the end.
How to add an exit hook?
import ballerina/task;
import ballerina/io;
import ballerina/runtime;

public function main (string... args) {

    (function() returns error?) onTriggerFunction = triggerFn;
    (function(error)) onErrorFunction = cleanupFn;

    //job 1 runs every 2 seconds.
    task:Appointment appointment1 = new task:Appointment(onTriggerFunction,
                                        onErrorFunction,
                                        "0/2 * * * * ?");

    var exitHookFn = () => {
        io:println("[INFO] stopping");
        appointment1.cancel();
    };

    appointment1.schedule();

    runtime:addExitHook(exitHookFn);
}

function cleanupFn(error e) {
    io:println("[ERROR] cleanup failed");
}

function triggerFn() {
    io:println("[INFO] triggered");
}

Resolves #9832

Closing this as we have to come up with an alternative design approach in handling signals in ballerina. The related doc is - https://docs.google.com/document/d/16W36cEprx1j2pVzd6B0bOwQ-xA0mpt8nV4_LZPqHMjA/edit?usp=sharing


Looping automatically

There have been several requests for rclone to

loop for N loops or perhaps indefinietly
quit after a certain length of time

There should probably be a delay between loops too.

Since this is easy solvable with crontab it would be prefferable if rclone good grab new files during the upload.
eg transfers=50 and once it only have 49 active ones it checks for files in source.
This would mean a lot for upload optimization, especially with acd where single file transfer is not as fast as multiple at same time.
p.s. I think the issue was open once but did not find it.

@ajkis I think there is an issue about this somewhere too!  It is a good idea, just not particularly easy ;-)

So does rclone pickup new files now ?

@ajkis not yet, alas!

@ncw once its added could you make it by additional flag so our current setup does not break because of it.

@ajkis absolutely!

I would totally support this feature. Cronjobs can be a nasty surprise if you don't check for the right things (if files are currently being copied, etc). Monitoring a directory for new files would be a great solution (sorta like how robocopy monitors directories).

+1 to this feature. I currently set this up in crontab but sometimes rclone stays running for hours uploading a single massive file. Having this feature will dramatically improve upload performance VS crontab.

why not screen/tmux with an infinite loop?
screen
  while true
  do
    rclone copy ...
    sleep 3m
  done

+1 to this feature. I currently use some 3rd parts, but it's not exactly what I need.


Broken tutorial links in docs

Hi,
thanks for developing the sfaira tool, it looks really promising!
I wanted to try it out but realized that the tutorial links here are broken: https://sfaira.readthedocs.io/en/latest/tutorials.html

Dear @ggabernet
We are currently still working on Sfaira and will release a new version soon with updated tutorials.
I'll ping you and @KevinMenden when it happens ;)

sounds good, thanks!

https://github.com/theislab/sfaira_tutorials
And solved in private communication.


Tgb alias

Description:
allow the Alias tgb to be used instead of having to type out tester gift box for ge buy or ge sell, for trading & even looking in bank.
Changes:

added tgb to the itemAlias.ts

Other checks:

[ ] I have tested all my changes thoroughly.

You have some trojan horse changes in here: tradeable_on_ge: true, tradeable: true ?

You have some trojan horse changes in here: tradeable_on_ge: true, tradeable: true ?

I just copied what others had.

fixed it. sorry. I honestly thought they needed to be there due to the tmb, umb, hmb


Any chance to have annyang working on WKWebView?

Just wondering

annyang works in any browser that supports the Speech Recognition API. This is a standard API defined by the W3C.
You should forward your question to Apple, asking them to support this API.


Question about setup

Describe the bug
I have created a new website in Matomo, which has the same url as our landing page. The landing page has it's own website in Matomo, as I don't want to merge landing page analytics with app events. Can I do this?
After installing and setting up Matomo in my app, using http://koermit.dk as baseUrl and the id of the website, I get the following error:
Matomo tracking is not sent: https://www.koermit.dk/matomo.php Object {
  "body": "idsite=2&rec=1&apiv=1&uid=&send_image=0&action_name=App / start",
  "headers": Object {
    "Accept": "application/json",
    "Accept-Language": undefined,
    "Content-Type": "application/x-www-form-urlencoded; charset=UTF-8",
  },
  "method": "POST",
}

Matomo tracking error:, [Error]
at node_modules/matomo-tracker-react-native/src/MatomoTracker.js:197:8 in fetch.then._catch$argument_0

How do I get to see what error it is?
What about Matomo.php in the end of the base url, do I have to do anything on my landing page or the domain? Could the domain be in theory anything as long as it matches the website in Matomo? What if my app doesn't have a url?
When writing this I thought, do I need a tracking code implemented on my landing page for this to work ? I tried swapping the id to the one website in Matomo that has a tracking code, but no difference it seems.
Affected code lines if helpful Where is the problem?
    useEffect(() => {
        trackAppStart();
    }, []);

I do get this when starting the app:
Matomo tracking is enabled for: Object {
  "siteId": 2,
  "trackerUrl": "https://www.koermit.dk/matomo.php",
  "userId": undefined,
}

Hello again @georgibakken, the urlBase or trackerUrl need to be the page your Matomo instance is hosted at. I cannot reach anything at http://koermit.dk. What is the url of your Matomo where you log in to see analytics?

Thanks @donni106 ! that explains it. It's http://koermit.matomo.cloud and now I can send actions.
Matomo tracking is sent: https://koermit.matomo.cloud/matomo.php Object {
  "body": "idsite=2&rec=1&apiv=1&uid=&send_image=0&action_name=Screen / Profile",
  "headers": Object {
    "Accept": "application/json",
    "Accept-Language": undefined,
    "Content-Type": "application/x-www-form-urlencoded; charset=UTF-8",
  },
  "method": "POST",
}

Do you know if it usually takes some time before it pops up in my Matomo instance? It doesn't seem to be registered there yet

I can see the action has arrived. thanks for the help!

Actually the screen views don't seem to be under Pages in matomo, however I can see them in real time visits:

How would you pages expect to behave, as there are no real pages on mobile? This term comes from the web base of Matomo. Could you find some API references that would result in a way you think of?


Paid for yearly subscription instead of monthly (undesired)

In subscribing to jsbin I clicked on the monthly subscription but when I subscribed, I was charged for the yearly. Please help me revert to the monthly. I can't afford to pay the yearly at this time.
It just happened. How do I get a refund and change to monthly?

Can you email me at<EMAIL_ADDRESS>with full details and I'll sort this
out for you.
On Sun, 26 Mar 2017, 20:21 Chris Armendarez<EMAIL_ADDRESS>wrote:

In subscribing to jsbin I clicked on the monthly subscription but when I
subscribed, I was charged for the yearly. Please help me revert to the
monthly. I can't afford to pay the yearly at this time.
It just happened. How do I get a refund and change to monthly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jsbin/jsbin/issues/3017, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA1hFTIFOj4DdBkAWCfQZt1OKTJkucWks5rprqygaJpZM4Mpjis
.


feat: Verification of programs

I added the ability to verify a program to the playground. This should close #67
The user can create a proof using the "Prove" button. Then the user can then verify that proof using the "Verify" button.
If the Inputs, the Program or the Outputs are being tampered with after the proof was generated, the proof fails.
https://user-images.githubusercontent.com/35031754/223128878-e07cb7d3-0d44-445f-a22a-82f5dcba9c8b.mov
Note: I needed to return the whole stack, for now, to be able to use the program outputs as inputs in the verification step. This is a bad UX.
  /**
   * This handles the number of outputs that are returned to the user.
   * At the moment we return the whole stack always. This is not good UX.
   * But it is needed to use the Output again as Input for the verification step.
   */
  // const [numOutputs, setNumOutputs] = React.useState(16);

Thanks @Dominik1999 it's really cool to have this working! I left a few comments inline. Additionally, this isn't running successfully for me locally when I check out your branch. Can you double-check installing & building everything from scratch to see if you get errors?

Thanks a lot @grjte!
I refactored a bit and addressed your comments. When I run npm run build:miden && npm install && npm run start in the playground folder it builds and starts. Which error message are you seeing?


For what reasons the future relics should be in game (in general, not specifics)

Possibilities:
1 - Nods to Street Fighter.
2 - Utility in situations found in game.
3 - Door open to a different run than the usuals.
4 - Door to new content.

Also, 5 - Having all the relics of a fighter should make the player feel like his playing style is closer of that fighter.

Ok, Ryu's relics work, but in a roundabout way: basically in SSF2, he's not the best character, but he has all the tools to succeed... which is the result of his relics.


Update Buttons.js

Fixes #
Changes
VotesRshares can be equal to 0. Which will create a division by 0.
Test plan
Effects can be seen on this post : https://busy.org/@petanque/testcomments-xylmwuwi6p if you look at the comment "Commenting is cool" by @howo and the upvotes, you get "Nan $"

I've deployed this branch, but it still seems to display NaN:
https://busy-develop-pr-2124.herokuapp.com/@petanque/testcomments-xylmwuwi6p

Mmmh that's odd, the division by 0  should be the only thing that causes this issue. Is the ratio calulation also done elsewhere ?

Yep indeed the calculation was done elsewhere as well. In my previous commit I only fixed the bug when viewing the votes from the post itself. Now it should be fixed everywhere.


Capture exceptions outside of spiders

scrapy-sentry currently does not capture exceptions that happen outside the spider's on_error signal. This limits the usefulness of the extension. Luckily, It is pretty easy to fix as well. I currently have this in my Scrapy settings.py instead of configuring the extension:
from twisted.python import log
from raven import Client

client = Client(dsn=SENTRY_DSN)

def log_sentry(dictionary):
    if dictionary.get('isError') and 'failure' in dictionary:
        try:
            # Raise the failure
            dictionary['failure'].raiseException()
        except:
            # so we can capture it here.
            client.captureException()

log.addObserver(log_sentry)

It should be pretty easy to do the same in the extension, and possibly remove the on_error handling. @llonchj, if you agree, I'm happy to prepare a PR for that.
Above snippet is not my work, it was discovered by @elmkarami in http://stackoverflow.com/questions/25262765/handle-all-exception-in-scrapy-with-sentry and https://github.com/scrapy/scrapy/issues/852.

I toyed some more with this, and managed to get proper tracebacks working, and am capturing it as a Sentry exception instead of just pushing a message.
from twisted.python import log
from raven import Client

client = Client(dsn=SENTRY_DSN)

def log_sentry(dictionary):
    if dictionary.get('isError') and 'failure' in dictionary:
        failure = dictionary['failure']
        exc_type = failure.type
        exc_value = failure.value
        traceback = failure.getTracebackObject()
        client.captureException(exc_info=(exc_type, exc_value, traceback))

log.addObserver(log_sentry)

Pretty happy with this now; Sentry shows the expected traceback.

What about pull request? Maybe more suitable for raven documentation?

I wanted to let you decide what do to with it, because it more or less replaces the inner workings of this project. Personally I think there's value in having scrapy-sentry; I'd switch over to something like I propose, and advertise in the README that really all there is is some boilerplate to attach to Twisted's logging infrastructure. But it's all up to you :)

https://github.com/llonchj/scrapy-sentry
It's available in PYPI
I am curious though. Is it possible to do it without Sentry? Without any client.

Using sentry-python (named sentry-sdk in pip) instead of the legacy raven, there is a much simpler solution based on the fact that scrapy logging features are based on the stdlib logging module.
I develop a very simple scrapy extension that catches exceptions and errors inside and outside spiders (including downloader middlewares, item middlewares, etc.): https://gist.github.com/Framartin/4e57b57139ed31f36684cfc514037bf6
sentry-python catches by default logging events as follow:

critical and error levels: sent as sentry events
info and above levels: sent as sentry breadcrumbs

Thanks @Framartin, works really well so far!


Initialize multi-language support using i18n

Implement internationalization using i18n.
Add a button for language selection

Todo:

[x] When a layer is activated, the content in the legend is not translated (name, legend text, presumably legend labels)
[x] The layer names and their category headers are not translated in the 'run analysis' layer drop down menus
[x] The 'run analysis' button at the bottom of the run analysis section is not translated
[x] When I add the word for Khmer in local language as the label to use for the translation in cambodia/index.ts, the spacing on the UI is larger than 'en' and 'fr' -> I think we should use km for now to be consistent. If it is a strict requirement, we could have the button size adapt to the text length.
[x] How do I remove the French language option without deleting the info in i18n.ts? -> commented out for now
[x] Think through how to handle 'local name' in boundary files / analysis resullts tables
[x] Can we also configure the 'admin_level_local_names' attribute in 'admin_boundaries' so that it is tied to a specific translation and become active?
[x] Use 'date_locale' throughout the app to decide on how to format dates. Right now it is only use in the date selectors.
[x] adapt font size when needed

@ericboucher - I added translation configurations for Cambodia. Easy to implement and works well. There's a few things that are missing though:

When a layer is activated, the content in the legend is not translated (name, legend text, presumably legend labels)
The layer names and their category headers are not translated in the 'run analysis' layer drop down menus
The 'run analysis' button at the bottom of the run analysis section is not translated
Can we also configure the 'admin_level_local_names' attribute in 'admin_boundaries' so that it is tied to a specific translation and become active?
How do I remove the French language option without deleting the info in i18n.ts?
Does 'date_locale' do anything? I was expecting it to change to dd-mm-yyyy but that doesn't seem to be the case

I continued testing for Cambodia and added the 'go to' feature. Here are a few more inputs:

After running an analysis, we're not displaying all levels of local admin names like we do for the English version
I wasn't able to add translations for 'rows per page', and '___ of ____' at the bottom of the analysis results pane
The text 'go to' below the 'run analysis' button doesn't translate
The admin names in the 'go to' should be in local language if we're using Khmer

To replicate, use Cambodia instance REACT_APP_COUNTRY=cambodia yarn start on this branch

@wadhwamatic your above comments are resolved, please check
Regarding changing the translations for 'rows per page', and '___ of ____', they are material-UI default name, hence we can change localization for them by changing locale in MuiTheme (https://mui.com/guides/localization/). However material-ui only supports Khmer from v5.0.0, hence we will need to upgrade material-ui and react-dom versions to use them. Besides, I don't think Material-UI supports Burmese and other languages in PRISM yet, so I'm implementing a quick fix of manually changing the texts we use first.
What do you think? should we go with the quick fix for now or use Material-UI localization feature?

Thanks @tdlinh2712 for the great work on this! I see the quick fix you mentioned was made and the other issues addressed. Looks good.
There are three things missing that I see as of now:

The tooltip text is not translated. This includes the use of local admin names, and the translated name of the layer - for example: 'IDPoor' displays in English instead of the Khmer text.
The 'go to' feature uses the English admin names rather than Khmer
Just noticing that the calendar date picker and timeline navigation also do not translate. I tried adding short month names (Jan, Feb, etc) to the translation file, and the full name too but without success

The calendar date picker uses the date_locale that needs to be loaded from date-fns/locale/. I'll try to add some documentation around that.

@tdlinh2712 the "go to" feature should have the same behavior as the table admin column and simply use "localAdminNames"

Quick note, let's make sure that the date in the URL parameters stays in the English format

Great work! We're getting close. Here's a few more missing pieces (hopefully the last):

The local title of a data layer doesn't show as translated in the tooltip. For example, the 10-day rainfall estimate shows correct title in the legend, but not on the tooltip. See screenshot below

The text that is added to the legend for the results of the 'run analysis' feature is not translated. This includes the pre-layer name text "Impact Analysis on " and the layer description. See screenshot

A feature that wasn't yet used in Cambodia is the additional layer content (https://github.com/WFP-VAM/prism-frontend/pull/244). I enabled this feature for the IDPoor data layer to think about how we can address this. Perhaps we should just have a second version of the markdown file which is in local language and add it as another layer attribute?

@wadhwamatic for "the text that is added to the legend" as well as legends for the results of the 'run analysis' feature, it's because there's no translation for fields legend_text and legend in translation.json. Is there any way we can do it nicely instead of entering in translation.json (i.e add another translated_layer.json file and load it to i18n)?

@ericboucher regarding changing the date format, I noticed that all formatted dates in the repo at the moment are not for display, but for updateHistory() function, which updates the URL, therefore I don't think it's necessary to change the date format to fit localisation. the dates that are displayed at the moment are in date pickers, which have already been translated properly.

TODO:

translate errors
decide what to do with "No Data"

@wadhwamatic for the additional layer content, we would likely use the folder structure and layer.contentPath to toggle between different .md files.
If it's not needed for Cambodia, I think we can hold of on implementing it until we actual have translated files to toggle between. wdyt?

[ ]  (optional) translate error messages (@wadhwamatic how important is it? One potential downside I see is around communication, where keeping error messages in English might make debugging easier).

@ericboucher - is this referring to the messages like 'no data found for mm-dd-yyyy, loading the closest date mm-dd-yyyy instead'? it would be good to have those translated too, but not urgent

If it's not needed for Cambodia, I think we can hold of on implementing it until we actual have translated files to toggle between. wdyt?

we'll need time to get that content all finalized and translated. i would guess that won't happen for another 2-3 weeks

To test the exposure analysis flow, I added translations to Myanmar (dummy data copied from Cambodia). That flow isn't addressed yet. See screenshots below

Missing translations in the legend area of 'Exposure analysis', 'Clear analysis' and 'Table view'.
After clicking on table view, we're also missing translations in the data drawer of the layer name and 'Download as CSV'

Steps to replicate:

REACT_APP_COUNTRY=myanmar yarn start
Load tropical storm layer on 2016-05-21: http://localhost:3000/?hazardLayerId=adamts_buffers&date=2016-05-21
Click 'exposure analysis' button on the wind buffer layer in the legend

A better architecture for this might be a new hook:
export function useSafeTranslation(): {
  t: i18nTranslator;
  i18n: typeof i18n;
  ready: boolean;
} {
  const { t, ...rest } = useTranslation();
  return {
    t: (key: string) => {
      if (key === undefined) {
        return '';
      }
      if (key in resources.en.translation) {
        return t(key);
      }
      // eslint-disable-next-line no-console
      console.info(
        `Translation for "${key}" is not configured in your translation file.`,
      );
      return key;
    },
    ...rest,
  };
}

Which will make devs less likely to forget wrapping the t function in safeTranslate. Thoughts?

@Ry-DS I think t should still be mandatory in safeTranslate so maybe the hook is overkill? wdyt?

@tdlinh2712 I translated the exposure analysis piece and resolved a few minor mismatch with dates. I will give it a final review but overall do you think we are gtg?

@wadhwamatic we can not translate the storm legend icons however because they are fetched directly as an image from the geoserver. Can you cleanup/remove the myanmar translation once you're done testing? I'll move the FR translation but otherwise I think we're getting ready to merge this

@Ry-DS I think t should still be mandatory in safeTranslate so maybe the hook is overkill? wdyt?

Yup the current implementation works too, up to personal preference since we can either forget one or the other when using it in new places.

@ericboucher i think using the hook is better since we won't have to import 2 things from 2 different files. I can refactor it quickly tomorrow if you're ok with it, then i think it's good to go.

@tdlinh2712 if you think you have a clean plan in mind, go for it :)

@wadhwamatic we can not translate the storm legend icons however because they are fetched directly as an image from the geoserver. Can you cleanup/remove the myanmar translation once you're done testing? I'll move the FR translation but otherwise I think we're getting ready to merge this

@ericboucher - translation of the exposure analysis UI looks good, but when I click on an admin area to see a result I get an error. To reproduce, run exposure analysis on tropical storm layer on 2016-05-21 (http://localhost:3000/?hazardLayerId=adamts_buffers&date=2016-05-21). After the results load, click on an admin area in the storm path. The tooltip appears with the results but within a second, there's an error:

Guessing the fix for decimals wasn't applied to exposure analysis yet?

@ericboucher . Thanks for quick fix on the rounding issue. Looks like the last piece is to translate 'Download as CSV' in the exposure analysis results:

@wadhwamatic it was just a matter of letter capitalization -> Download as CSV

@wadhwamatic it was just a matter of letter capitalization -> Download as CSV

ah, I tried a few combinations but not that one. I see it working now. I'll go ahead and remove the Myanmar tests so we can merge this. Thanks

@ericboucher

@tdlinh2712 if you think you have a clean plan in mind, go for it :)

Done. However in DateSelector.tsx, when using the useSafeTranslation hook to update the date range, it resulted in the timeline picker being re-rendered too many times, so I used the useTranslation hook, and I think it's better to have a work item to investigate further/refactor this DateSelector component, but for now functionality wise, i think this is good to go

@wadhwamatic we kept the console logs for now, so the app should complain in the console about missing translations. You can just copy-paste the casing from there. We could also try to be fancy and match case insensitive keys, but that's not how i18n works by default so we would have to change a few things

@ericboucher

@tdlinh2712 if you think you have a clean plan in mind, go for it :)

Done. However in DateSelector.tsx, when using the useSafeTranslation hook to update the date range, it resulted in the timeline picker being re-rendered too many times, so I used the useTranslation hook, and I think it's better to have a work item to investigate further/refactor this DateSelector component, but for now functionality wise, i think this is good to go

Consider investigating if useMemo or useCallback will solve this. Shouldn't be too hard to solve now as this happens quite often in react haha. Let me know if you have any issues using the above two functions (what I would try first is wrapping the new t function in useCallback)


🐞 Generated .gitignore file for Go modules is missing /internal/telemetry in 0.11.0

What is the issue?
With the latest version, the generated .gitignore file is missing an entry for /internal/telemetry (unless it’s intended?). Is https://github.com/dagger/dagger/blob/fa782c5f25e178e20d58cb7e9610f89bcd38e8ba/core/schema/sdk.go#L331 the right place to fix this?
Dagger version
dagger v0.11.0 (registry.dagger.io/engine) linux/amd64
Steps to reproduce
Execute dagger develop in a Go module and see that Git has new untracked files.
Log output
No response

Nope, that's not intentional! It should be included, but isn't!
That's the right place to fix it, a PR would definitely be appreciated!


Once any link from page is clicked - the scroll is engaded

Hi!
I've found one specific issue.
Once any added to parallax layer link is clicked - the scroll to next layer is engaged.  Right now I'm implementing modal-dialog which is accessed through links. So app behaves in such way:

click on link
the layer shifts and background colour is shown (related to fist page) | the layer is shifted to next one(non first layer)
modal is shown, but the page is reloads! Seems that this behaviour related also to first slide

How could it be fixed? Could the behaviour of internal links changed to ignore scroll action?

@01Kuzma Do you have an example some where, codesandbox would be great. It shouldn't scroll at all, unless you call scrollTo.

I'm doing it locally... Yes, I've set the scrolling={true}  and onClick={() => this.parallax.scrollTo(X)} is laso used, what is very nice. But in conjunction of both options any clicked link, such as a href="#">Test, will do it's task and layer will scroll to next. So in such way it's impossible to have scrollTo enabled and links for UI...

I think i get it now, but it seems to me that's normal dom behavior. If you set the click event on the parent-parallax section, then clicks on underlying elements will bubble up and eventuell reach the parallaxes click handler. You can prevent events from doing that using event.stopPropagation().

And how and where the event.stopPropagation should be used?

Something like this i guess ...
class Something extends Component {
    stopPropagation = e => e.stopPropagation()
    ...
    Test
}

Live demo: https://codesandbox.io/s/48l006mvn0
The problem isn't springy-parallax, it's the dom regular event distribution that's playing a trick. The event just bubbles up as i suspected, reaching the parallax handler and there it scrolls. If you prevent the event from doing that it'll be fine.

Thank you very much!!!
It seems to work :)


fix(ui): issue with tab labels not changing based on language when its a function

Fixes https://github.com/payloadcms/payload/issues/8410
Adds a new type for ClientDocumentTabConfig to make label, isActive and condition not readonly and not functions so that it's compatible with being set for the client config

I think we should hold off on this change until #8364 is merged. This file has been moved and changed quite a bit.


fix: delete idea directory

Thank you for contributing to errors!
Please add a summary of your change
fix: delete idea directory
Does your change fix a particular issue?
Fixes #(issue)
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Codecov Report

Merging #9 (2729772) into main (70f6259) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   97.37%   97.37%
=======================================
  Files           6        6
  Lines         534      534
=======================================
  Hits          520      520
  Misses         12       12
  Partials        2        2

Flag
Coverage Δ

unittests
97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Minor cleanup of CMP tests

80-test_cmp_http.t: Remove -certout option where not needed
cmp_client_test.c: Remove needless dependency on NDEBUG

[x] tests are added or updated

This has been extracted from #16050 for separate reviewing.

Given this is not a bug fix, I've added hold.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

How to handle such PRs on which a hold: merge after ß period had been applied?

Merge them, it's after beta.
You should be able to remove the hold tag.

Merged to master. Thank you.


🐞 shell error when using multi-line yaml

What is the issue?
Given the following config:
https://github.com/lukemarsden/test-dagger-actions/blob/c0e90ddf436947e4c6639fd95e2c491095f87ff5/.github/workflows/docker-publish.yml
In particular,
      - name: Dagger Build & Push
        uses: dagger/dagger-for-github@v5
        with:
          version: "0.11.0"
          verb: call
          args: |
            build-and-push \
            --registry=$DOCKER_REGISTRY \
            --image-name=$DOCKER_IMAGE_NAME \
            --username=$DOCKER_USERNAME \
            --password=env:DOCKER_PASSWORD
        env:
          DOCKER_REGISTRY: ${{ env.REGISTRY }}
          DOCKER_IMAGE_NAME: ${{ env.IMAGE_NAME }}
          DOCKER_USERNAME: ${{ github.actor }}
          DOCKER_PASSWORD: ${{ secrets.GITHUB_TOKEN }}

When using the multi-line string args: |, I suppose the string ends up including the trailing newline at the end, which results in the following error: https://github.com/lukemarsden/test-dagger-actions/actions/runs/8630455004/job/23656748756
In particular:
Run cd . && { \
  cd .

Switching to single line style, like:
          args: build-and-push --registry=$DOCKER_REGISTRY --image-name=$DOCKER_IMAGE_NAME --username=$DOCKER_USERNAME --password=env:DOCKER_PASSWORD --build-context .

fixes the issue, but of course is less readable
Dagger version
dagger v0.11.0 (registry.dagger.io/engine) darwin/arm64
Steps to reproduce
Run the above config
Log output
See above

Try adding a \ to the last line too.

Unfortunately that does not work because part of the issue with multiline yaml for the args input is that either:

The trailing semicolon gets kicked to the next line which internally results in the syntax error near unexpected token ;'`, see: https://github.com/dagger/dagger-for-github/blob/51ce834f1ada27473d258df3a1c5733e72c6b860/action.yml#L69

Or if all lines have a trailing backslash and are clipped then the backslashes persist and will confuse Dagger with the observed error of Error: unknown command " --dir=." for "dagger call"

For example, this:
  args: |
    --env=${{ inputs.environment}} \
    --dir=. \
    pipeline

Is clipped to an args value of: --env=*** \ --dir=. \ pipeline and those inline backslashes are not ignored.
A workaround is to use a block chomping indicator and no backslashes. For example the following will work:
  args: >-
    --env=${{ inputs.environment}}
    --dir=.
    pipeline

I think an ideal expected behaviour for the args input should be to either: (1) handle the various ways yaml can provide a multiline value or (2) parse and throw a more verbose error that prompts users to use the above syntax. Solution 1 is probably out of scope for an action like this. But given that many folks will want to chop up their Dagger call into something readable and maintainable perhaps solution 2 would work simply by parsing the provided args with a regex and shouting for the user to review either this comment or documentation that recommends this strategy for multiline args input.


Fix nphysics home & docs links

Closes #58
Note that I'm not sure about doc link: there're separate docs for 2d and 3d.

Thanks!


Update ms-cloud-germany-transition-phases.md

Adding Phases to each of the components.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Cannot build Android App Bundle in cloud service, only apk

Problem description
I cannot build an Android App Bundle in the cloud build service which is a requirement for all new apps to be submitted to the Google Play Store (.apk is not acceptable for new apps). This is a big problem for us and renders the paid-for service considerably less useful than expected.
Expected behavior
An option in the project settings. Or maybe an environment variable that can be used.
Environment
Tabris Pro cloud build service.

We will add such an option in the near future. Please stay tuned.
Fyi, there is no hard requirement at the moment to upload an app bundle. You can still upload an apk as usual.

Thanks @mpost this would be really helpful.
I agree that it looks like there's no hard requirement for an app bundle, however I'm unable to release an apk. I believe that this is because it's a brand new app which has never been released before. I think an apk is ok for new updates to older apps. I'm not able to get you a screenshot at the moment, but I will when I get a chance. Thanks.

Any update on when this might be ready? I'm happy to be a beta tester if required. Thanks

@violuke It is still on our roadmap and will be added. You can expect it in Q2 2020. Sorry that i can't give you a more concrete date.

@mpost is there an update on when this feature will be ready yet? Thank you.

@violuke It is still on our roadmap. Please hang on.

Support for Android bundle packaging is now available for builds based on tabris.js 3.3+.


multiOmicsAtlasOfTheHumanRetina project duplicated in the Portal

In data portal, as of 6-Feb-24 there are 426 project titles, but 427 different projects. There are two instances of the project titled A multi-omics atlas of the human retina at single-cell resolution.
1 - multiOmicsAtlasOfTheHumanRetina dcp - ingest
2 - Amulti-omicsatlasofthehumanretinaatsingle-cellreso dcp - ingest

Project
Publication
Wrangled by
Import form date
# Files
h5
pdf
spreadsheet

#1
pre-print
UCSC
12-May-23
428
40
no
yes

#2
peer-reviewed
Lattice
22-Nov-21
391
0
yes
no

informed UCSC to take action about this via slack

UCSC handled that and import team is re-indexing. Slack

There is 1 dataset from tracker (10.21203/rs.3.rs-3471275/v1), which is the pre-print of the integrated atlas that contains unpublished data as well.
In data availability statement, is mentioned that all data has been deposited in HCA DCP. There is no record of this specific DOI in ingest.
However, another dataset (10.1016/j.xgen.2023.100298) contains 25 donors described as unpublished in other dataset (Ethnicity & Sex & Age match the "unpublished" ones). This was a duplicated dataset with lattice #1233 , and we decided to use the lattice dataset only. The second paper describes ~250K nuclei while the first paper describes ~1.5M nuclei from this dataset.
Is there a need to update this specific project? Do we need to investigate more?


How to start docker-compose.yml on windows 10?

How to start docker-compose.yml on windows 10?

@soruly

This system doesn't support running on Windows, please use Linux instead.


Image not found

Image in Readline Post is brocked

Image in Readline Post is brocked

Search Jekyll Image load Method


Filtering based on timestamps doesn't work

Description
Create a grid with date columns that have the same date but different timestamps
Setup a filter to select a range with the same date but different timestamps, 11:00:00 to 17:00:00
Filtering returns an empty grid.
Expected to get the 2 rows with the same date/different timestamps.
Version
Data-grid: V1.2.5
Browser: Chrome
Screenshots

Code
https://gist.github.com/ppeyro/23984165aa7da1ebafa3495042a25872

@ppeyro can you retest?

Verified this in tag v1.0.0-beta.3.  Filtering based on timestamps looks good.
Screenshot


⚠ ClamAV has degraded performance

In e7e66dc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in b2c5950.


FAST - trigger GitHub workflow also on PR synchronize event

Add synchronize to the pull_request trigger so that the workflow is also run when the source branch is updated.

@ludoo looks like it can be merged now - I don't have write access.

@ludoo looks like it can be merged now - I don't have write access.

if you plan on contributing more PRs ping me and I'll add you to the team, thanks! :)

@ludoo yes, I might contribute more small PRs, about to submit one with some minor README changes :)

@ludoo yes, I might contribute more small PRs, about to submit one with some minor README changes :)

check your email ;) you will now be able to work in local branches, etc.


add /mostActiveUsers to API Endpoint Reference Wiki

/mostActiveUsers seems to be already implemented but the wiki is missing the link...

Done, thank you.


Git source control icon is missing on the sidebar

Type: Bug
Source control icon is missing on the side bar, it's not present when right-clicking the sidebar or the explorer.
 Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add slats tilt control via different entity

Fibaro FGR-223 creates one entity for blinds position and another one for slats tilt.
https://github.com/home-assistant/core/issues/64538
Would it be possible to let user define a different entity for the tilt controls in the shutter card?

Ah, while checking the code of hass-shutter-card, I can see it cals open_cover_tilt service, which is unfortunately not supported by FGR-223 entities at all (because the tilt is a separate entity and responds to open_cover service only rather then to its open_cover_tilt sibling.
I have reported a separate bug in HA re. this issue:
https://github.com/home-assistant/core/issues/95699


Remove Django's LocaleMiddleware from the app

Because we always activate Spanish-language content via the inclusion of
an /es/ path segment that triggers the setting of the language
context variable to es, we do not need this middleware for anything
currently, and its presence can cause unwanted appearance of Spanish on
English pages if a user has set their browser's primary language to
Spanish.
Removals

django.middleware.locale.LocaleMiddleware removed from MIDDLEWARE in our base settings file

Testing

Pull branch
Visit various Spanish-language pages on your local server and compare to how they look in production
Update your browser settings to prefer Spanish (e.g. in Chrome, Settings, Advanced, Languages, Language)
Visit /data-research/consumer-complaints/ using your favorite way to bypass Akamai, observe some parts of the global header and footer appearing in Spanish
Visit http://localhost:8000/data-research/consumer-complaints/ and observe those same parts now in English
Remember to set your browser language preferences back when done testing

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome on desktop
[ ] Firefox
[ ] Safari on macOS
[ ] Edge
[ ] Internet Explorer 9, 10, and 11
[ ] Safari on iOS
[ ] Chrome on Android

Because we always activate Spanish-language content via the inclusion of
an /es/ path segment

This is not true. We have 63 Spanish blog pages that do not use an /es/ path segment, such as
/about-us/blog/errores-comunes-que-la-gente-encuentra-en-su-reporte-de-credito-y-como-corregirlos/
What drives translations for those and other Wagtail pages is the page.language setting.
The language setting doesn't depend on django.middleware.locale.LocaleMiddleware, so we can still drop it without upsetting our Spanish universe.
I would lean toward honoring the preferences of those probably rare users who go to the trouble of setting their browsers' default language. If they want to see every translatable thing available, why not let them?
We do have an odd (and also rare) caching problem that this might solve, but for me that doesn't tip the scale.

Because we always activate Spanish-language content via the inclusion of
an /es/ path segment

This is not true. We have 63 Spanish blog pages that do not use an /es/ path segment, such as
/about-us/blog/errores-comunes-que-la-gente-encuentra-en-su-reporte-de-credito-y-como-corregirlos/
What drives translations for those and other Wagtail pages is the page.language setting.
The language setting doesn't depend on django.middleware.locale.LocaleMiddleware, so we can still drop it without upsetting our Spanish universe.

Thanks for pointing that out, Bill; I didn't remember that.

But I would lean toward honoring the preferences of those probably rare users who go to the trouble of setting their browsers' default language. If they want to see every translatable thing available, why not let them?

Because the way that our caching system currently works, their browser language preference is already ignored, and Akamai returns the English page anyway. (Assuming that an English-language user was the first to visit the page after the cache was invalidated.)
We may want to investigate whether or not Akamai can return alternate versions of the page based on browser language settings.

their browser language preference is already ignored ...

Not entirely, at least not in my testing. I just hit https://www.consumerfinance.gov/data-research/consumer-complaints/ in Chrome with my default language set to Spanish, and I got Spanish header and footer elements, including the search bar ("Buscar"), which could help a Spanish-only-speaker find something.

There are several other non-blog Spanish pages elsewhere in the tree, both Wagtail (ex: https://www.consumerfinance.gov/consumer-tools/sending-money/es/) and non-Wagtail (ex: https://www.consumerfinance.gov/consumer-tools/retirement/before-you-claim/es/).

These both have /es/ path segments, and correctly show the Spanish translations of global header and footer stuff, but the Spanish version of Before You Claim is not showing the Spanish mega menu.

their browser language preference is already ignored ...

Not entirely, at least not in my testing. I just hit https://www.consumerfinance.gov/data-research/consumer-complaints/ in Chrome with my default language set to Spanish, and I got Spanish header and footer elements, including the search bar ("Buscar"), which could help a Spanish-only-speaker find something.

Well, that's surprising and confusing.


Image is not uploading when image object sent via $http.put method

Hi @danialfarid
I want to upload file using put method with other data but when i tried to assign $scope.file object into data object it turns object like;
Object { $ngfBlobUrl="blob:http://www.optamark...-4d9c-8c8c-3d42491c1c5a",  $ngfWidth=525,  $ngfHeight=324}
And its not sufficient to upload image.

console.log doesn't show the binary of the file but it is there.


Fix p2p fail with "bad message" (#4175)

High Level Overview of Change

fix p2p fail with "bad message"
Context of Change

When read a p2p stream and committed message to the read buffer, if the message flow includes two protocol packages, which will lead to a bad message error and p2p fail by it, In case compression closed.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

What are the steps to reproduce this issue? Can this be done with a unit-test? Thanks.

@halberdholder can you answer the question above about reproducing the issue (ideally with a unit test)?

closing due to inactivity. @halberdholder feel free to open a new PR or issue, as you like!


Move ws to peerDependencies section

This dependency is only needed for who uses the node build (dist/node.js), so for browser users let's no install it as mandatory.
Task: #aBNDd6q7

@felipemfp please redirect it to 2.0 version


feat: Rewrite simp_mem to build a new expression, thereby localizing the effects of rewrites [6/?]

Issues:
Resolves
Remove this section if this PR doesn't address any open issues.
Description:
A detailed description of your contribution. Why is this change
necessary?
Testing:
What tests have been run? Did make all succeed for your changes? Was
conformance testing successful on an Aarch64 machine?
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@bollu Could you turn off all the tracing options so that the build is less noisy?


Fix dylib build warnings in extension targets

This might help: https://danielsaidi.com/blog/2022/05/18/how-to-suppress-linking-warning


UI - Rental Unit Address Breakout

Issue:

https://github.com/bcgov/entity/issues/24125

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Comments to address from #292

It is very similar to CanadaPostAddressWithStreetAttributesI interface. Why have two? Could we just extend the existing interface to include additional fields as optional?
Having multiple address interfaces is confusing and adds a tech debt, because it is hard to know which one to use.

It looks like the values belong to a content en.json and don't look like a value map to me. Enums usually self-mapping. Here is a sample:
export enum PropertyTypeE {
SECONDARY_SUITE = 'SECONDARY_SUITE'
}

const PropertyTypeLabels = {
  [PropertyTypeE.SECONDARY_SUITE]: 'Secondary Suite'
}

I see that further in the code, the values themselves map to content strings (meaning they don't have to be fully spelled out here).

Probably should be fetchedRegistration?.unitAddress for checking if actually unit address exists and not only registration

Thanks for refactoring the Property Details validation. Could you please add some comments to explain what is going on here with chaining transform/pipe? Will be good for future readability and knowledge sharing. Thanks

I started to review the PR but please run it thru UXA as well, thanks @shaangill025


Fix Readme

Component is called Pie but is actually a Bar chart

There is already a PR for this...
#39


Deprecation warning:

I see this was addressed here:
https://github.com/offirgolan/ember-cp-validations/pull/140
But when using the following
validator('date', {
after: 'now',
before: '1/1/2020',
precision: 'day',
format: 'M/D/YYY',
errorFormat: 'M/D/YYY'
})

I'm seeing the Deprecation warning again:

Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.
Arguments: [object Object]

Anything I can do to resolve this warning?

@jwright04 I have a PR pending with some date format issues but I wasnt able to recreate your issue. Im assuming this is because M/D/YYY is not a valid date format according to momentjs docs which is probably why its reverting back to js Date.


CommandLine bug fixes

Form1.cs : Fixed an issue that ends up in the below error when used from CommandLine. Exception Info: System.NullReferenceException: Object reference not set to an instance of an object.
Program.cs : Added another usage of the commandline. I think file names without file path isnt working. I will have to debug more to understand why File.Exists doesnt work in OpenConfigFile method

Please limit this PR to bug fixing, and create a new one for new features.

Please limit this PR to bug fixing, and create a new one for new features.

Are you still working on this? If not, I will close it


Run copy-i18n-tags

This is a weird commit because of the dangling comment. I think it's fine, but probably needs to be cleaned up.

I'm going to close and see what happens next week.


Removes unnecessary recalculation

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation

Description
Removed recalculation of all listeners on registration at AnnotatedEventManager. Also added the varargs for listener registrar method. A usable edit with no negative effects.
The token cannot be empty. Because pre-checked field. Removed unnecessary check.

Should we add unit tests for this?

I don't think it should be. My attempts works well. The MessageListenerExample.java works fine.

Nothing like that will happen.
https://github.com/DV8FromTheWorld/JDA/blob/development/src/main/java/net/dv8tion/jda/internal/utils/config/AuthorizationConfig.java
bump.

I guess, but well

This needs to be rebased against master

Superseded by #2454


[CI][C++] Fuzzer nightly tests are failing with duplicate hash error on "generated_uncompressible_zstd.stream"

Describe the bug, including details regarding any error messages, version, and platform.
The nightly test-build-cpp-fuzz has been failing for the last days with the following error:
 + /src/arrow/cpp/build-support/fuzzing/pack_corpus.py /tmp/corpus /out/arrow-ipc-stream-fuzz_seed_corpus.zip
Traceback (most recent call last):
  File "/src/arrow/cpp/build-support/fuzzing/pack_corpus.py", line 54, in <module>
    main(sys.argv[1], sys.argv[2])
  File "/src/arrow/cpp/build-support/fuzzing/pack_corpus.py", line 47, in main
    process_dir(Path(corpus_dir), zip_output)
  File "/src/arrow/cpp/build-support/fuzzing/pack_corpus.py", line 39, in process_dir
    raise ValueError("Duplicate hash: {0} (in file {1})"
ValueError: Duplicate hash: 19530341bcb2ce81c942121d5719bf1ed35c2b8c (in file /tmp/corpus/generated_uncompressible_zstd.stream)
ERROR:root:Building fuzzers failed.

Component(s)
C++, Continuous Integration

This is hapenning on 12.0.0 but I don't think this is a blocker.

This is caused by #34631.
It reverts arrow-testing update by #34646.


Trigger "onCancel" when user presses esc while editing Post/Comment

this is a big one for me LOL i can never find the cancel button even though it's right there :p

I feel like https://github.com/BobaBoard/boba-frontend/issues/78 will probably help (since it would make the cancel/post buttons blend together less).
Anyway, totally going to happen in the next month! Be excite.

Closed by #107


Multiple commands at the same time doesn't work? e.g. signet . tune 100 tune -100

Would love to see this chaining commands thing implemented


Uncaught Error: ENOENT: no such file or directory, lstat '/Users/sachaifrah/Library/Application S...

[Enter steps to reproduce below:]
Just want edit file (right click, open with)
Atom Version: 1.2.0
System: Mac OS X 10.11
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat '/Users/sachaifrah/Library/Application Support/com.github.atom.ShipIt/update.tuDQIV4'
At ATOM_SHELL_ASAR.js:0

Error: ENOENT: no such file or directory, lstat '/Users/xxxxx/Library/Application Support/com.github.atom.ShipIt/update.tuDQIV4'
    at Error (native)
    at fs.lstatSync (fs.js:844:18)
    at Object.fs.lstatSync (ATOM_SHELL_ASAR.js:189:16)
    at realpathSync (fs.js:1454:21)
    at Object.fs.realpathSync (ATOM_SHELL_ASAR.js:272:24)
    at toRealPath (module.js:109:13)
    at Function.Module._findPath (module.js:149:20)
    at Module._resolveFilename (module.js:334:25)
    at Function.Module._resolveFilename (/Users/xxxxx/Library/Application Support/com.github.atom.ShipIt/update.tuDQIV4/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
    at Function.require.resolve (module.js:388:19)

Commands

Config
{
  "core": {},
  "editor": {
    "invisibles": {},
    "fontSize": 12
  }
}

Installed Packages
# User
No installed packages

# Dev
No dev packages

Duplicate of #9559 and #7399, please subscribe there for updates.


force users to use node > 10

Node 8 will be end of life at the end of 2019. Prisma 2 is still in beta which I suggest we should force prisma2 to be node 10 or higher. We might be even bold and move to node 12 right away depending on when prisma2 is production ready.
We can force this by adding an engine option to the package.json.
More information on Node releases can be found at https://nodejs.org/en/about/releases/

We're doing this in the latest version :)


Add support for setting environment variables

Allow setting environment variables when calling the Go pre-commit
hooks. For example, this allows setting GOOS when checking code targeted
for a different platform (e.g. Linux vs OS X).

Greetings @timuralp and thank you for your interest in my project!
Soo, the real issue here is that Pre-Commit doesn't make it convenient to pass environment variables to hooks.
What I would prefer you do before we consider how we might hack this feature in is to create an official issue request for env support on the pre-commit project:

https://github.com/pre-commit/pre-commit

Here a previous discussion I could find on the matter:

https://github.com/pre-commit/pre-commit/issues/758

My feeling is that the hook configuration section should support an env: entry that is a map of name/value pairs to add to the environment when invoking the hook.
Note: The maintainer is going to say no, but you'll need to make a strong case anyway.  As I see it, the case goes:

Go supports defining GOOS and GOARCH variables, which effect which code files are considered during processing.
The OS and ARCH values cannot be set via command line options - Go only accepts environment variables for these.

The maintainer will suggest that you configure a hook with an inline script entry that sets the variables and invokes the command you want ...
You'll need to note that, in the cases where you are using one of my mod or pkg hooks, then those hooks determine a set of directories to act on, based on the given file list (or full repo) and the equivalent logic cannot be easily added to an inline entry.
Please feel free to post the link to the issue here (or mention this issue in that one, which will create a link) and I can follow along and chime in.
I would love to see env support added to the pre-commit tool.
Good Luck !
-TW

Thank you for the prompt response! I also followed the multiple environment variable related reports on the pre-commit project and concluded that I am unlikely to persuade the project owners that supporting environment variables is a worthwhile endeavor. I opened an issue highlighting that it is currently impossible to use the Golang hooks out of the box when the target platform differs from where the hook is run (https://github.com/pre-commit/pre-commit/issues/2237). I suspect that the response will be to encourage users to set an environment variable. That's why I proposed the hacky workaround to plumb through environment variables via a special argument.
I'm open to other ideas, but don't see great alternatives today, unfortunately.

Well at least the reply (and rejection) didn't take long.
Grinding on this, It's important to me that such a feature would use argument names that are highly unlikely to conflict with any tools that might ever be used.
To that end, my idea of the option format would be:
--hook:env name=value

I want this solution to feel like a general solution that any pre-commit hook might adopt.  i.e let's try to set a standard.
--hook:env is not likely even conflict with any tools.
Using -- for a long arg is more standard, even if go's flag parsing specifically doesn't need it. i.e. in the case of this specific repo, these may be the only args with --.
The --hook: creates a name space for passing out-of-band options to hooks.  We may come up with other features beyond env in the future.

I'm a little torn regarding if we should expect these args at the beginning of the arg list, or be okay with them intermixed with other args.  I think the logic I use allows them to be intermixed but am not sure if its wise to support it.
Lemme know your thoughts on this, and thanks for trying !
-TW

Grinding on this, It's important to me that such a feature would use argument names that are highly unlikely to conflict with any tools that might ever be used.
To that end, my idea of the option format would be:
--hook:env name=value

I want this solution to feel like a general solution that any pre-commit hook might adopt.  i.e let's try to set a standard.
--hook:env is not likely even conflict with any tools.
Using -- for a long arg is more standard, even if go's flag parsing specifically doesn't need it. i.e. in the case of this specific repo, these may be the only args with --.
The --hook: creates a name space for passing out-of-band options to hooks.  We may come up with other features beyond env in the future.

Agreed. I picked -env- for similar reasons of trying to avoid collisions. Let me consider how easy it will be to parse this format. I'm unsure what else may need to be passed in circumventing the existing pre-commit infrastructure, but carving out the namespace makes sense.

I'm a little torn regarding if we should expect these args at the beginning of the arg list, or be okay with them intermixed with other args. I think the logic I use allows them to be intermixed but am not sure if its wise to support it.

I think from the hook consumer standpoint, a restriction on placement of arguments may be awkward or confusing. To improve usability, I'd consider parsing the options in the same way as all the arguments are parsed at the moment.
I'll rework the PR to incorporate your suggestions and we can iterate on the format. Thanks for the quick follow up!

@timuralp  You'll be glad to know I haven't forgotten about this feature.
I just opened #27 and would appreciate your'e help in testing it if you can?
-TW

@TekWizely that's great -- thank you! I will try to test this over the weekend. Apologies for not following through on the prior PR.

Superseded by #27


Get-CalendarNotification - cmdlet deprecated

When I try to execute Get/Set-CalendarNotification it gives me error that cmdlet has been deprecated. Tested in ExO module  3.1.0 and 3.3.0. behavior is the same. Returned URL https://aka.ms/tmrn does not point to learn pages. Please update documentation.
Get-CalendarNotification -Identity AdeleV
Get-CalendarNotification: |Microsoft.Exchange.Management.Tasks.DeprecatedCmdletException|This cmdlet has been deprecated. Go to **https://aka.ms/tmrn** to learn more.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 30397bf5-9cf6-7ff1-f02a-dcd4252b0228
Version Independent ID: a6a39c85-378c-b7cc-8da5-c59b901a63cd
Content: Get-CalendarNotification (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Get-CalendarNotification.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@bsj17, I modified the Get-CalendarNotification and Set-CalendarNotification topics to be on-premises Exchange only with the following note at the top:

Note: This cmdlet has been deprecated in Exchange Online PowerShell. The text message notification service has been discontinued in Microsoft 365.

Thanks for the feedback.
Closing


[Artwork] Render Markdown in "More Info" sections

See unrendered Markdown:

See https://github.com/artsy/eigen/tree/jorystiefel-more-info-markdown


Add signatures to mockchain

Transactions and their inputs can have signatures
Properly check signatures in crowdfunding script
Language.Plutus.Runtime.TH module for common functions

(I don't merge waiting for @michaelpj's review, but good to merge as far as I am concerned.)

LGTM


Inception Report

Based on https://github.com/developmentseed/wb-agrifood-frontend/issues/2 and other initial review of datasets, ML landscape, etc., DevSeed will provide the WB team with an "inception report" (format TBD).

This was sent by @heidimok – slides here


Can't login

getting same issue like other users here, can't login, "login error" even though the password and username is correct.
Maybe you can fix this.

See https://github.com/StrathCole/ioBroker.myq/issues/2#issuecomment-724624190


Feature Request: Event Sensor that listens to keyboard shortcuts. (Use the workstation keyboard as a remote for ha entities)

It would be great if one could  define a sensor that listens to keypresses on the host computer, that can be further used as remote for homeassistant entities.
Eg: Ctrl+Alt+1 = Toggle Office Light.

Cool idea!


skywalking how to trace ThreadPoolExcuter.submit/excute

If you are talking about async tracing, we have plenty plugins of async op. Learn from them. Also, plugin development doc talked about the async API already.


Move Razor page code into Partial Classes

Description
Move all razor code into partial classes for easier access.

How is this going?

It's taking to long..... My Ctrl+C Ctrl+V figures hurt.

Will you be able to finish this in the next week? Otherwise, I will be assigning it to another person.