B 19997 int

B-19997
Summary
This task creates the standalone shipment functionality for the office app, and the UI for the TIO role. When a standalone shipment is part of a payment request, it will be displayed with a '- Standalone' tag on it to alert the TIO. Additionally, when they are reviewing the payment request it will be noted there that the shipment is a standalone, and in the calculation details it will display the Standalone Payment Cap, which is currently 1000$. Any Standalone Domestic Crating service item should not exceed this cap regardless of how large the crate is.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[x] Has the branch been pulled in and checked out?
[x] Have the BL acceptance criteria been met for this change?
[x] Was the CircleCI build successful?
[x] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
Setup: Run db_dev_fresh to ensure db changes are in place
Note: When testing I found that many of the service items for existing data are not complete, and will cause the creation of a payment request to error out. To test a payment request with multiple service items it is easiest to just create them yourself.

Access the Office app

Login to the Prime Sim

Add a domestic crating service item with the standalone box checked.

Login as a TOO

Find the Move you edited in the Prime Sim

Approve the newly created Service Item

Login to the Prime Sim

Navigate to the previously edited move

Create a payment request that includes the Standalone crating item you created

Login as a TIO

Find the move you edited in the Prime Sim

Navigate to the payment requests tab

Note that the Domestic crate service item you created has '- Standalone' after domestic crating

Review the payment request

Note that the Domestic crate service item you created has '- Standalone' after domestic crating in the payment request review

Click on calculations to view the calculations

Note that the standalone payment cap is displayed

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against f6a9daff921198619fdbb70641550990eaee813c

And because I am a 🤓 I am putting the screenshot with the item size I chose. Thats right, I am shipping PI in a standalone crate 🤓

Everything looks good. Just had the question about whether the page should be displaying standalone cap in cents. If that is the case maybe we want to look at adding an indicator to let the users know its displayed in cents. Like a cents symbol after the amount or a label that says (in cents) or something. Otherwise it just looks weird and confusing.


WEATHER CONDITIONS

WEATHER CONDITIONS
User Story
AS A traveler
I WANT to see the weather outlook for multiple cities
SO THAT I can plan a trip accordingly
Acceptance Criteria
GIVEN the weather dashboard
WHEN a user views the current weather conditions for that city
THEN they are presented with a 5-day forecast
AND displayed is the date
AND an icon representation of weather conditions
AND the temperature
AND the humidity

GIVEN the weather dashboard
WHEN a user views the current weather conditions for that city
THEN they are presented with a 5-day forecast
AND displayed is the date in readable format

GIVEN the weather dashboard
WHEN a user views the current weather conditions for that city
THEN they are presented with a 5-day forecast
AND displayed is the date in readable format


Error in "Container"

It's the error regards JSX components

https://github.com/GeorgeHop/react-native-screens-swiper/issues/2#issuecomment-969183567


supershape examples not showing up on the wiki

My extensive list of supershape examples don't show up on the wiki.  Not sure what I did wrong there....I see them in the code.

Fixed in 02da52c0978069bf760656db6fc3f3eab5fba90d


Explicitly mentioned value add for airdroppers: second set of eyes on their smart contracts

Random sketch of an idea on how to make airdropping to $LOBS more attractive for projects. Many projects would probably be glad for a second set of eyes on their smart contracts to debug them. We can assemble a list of typical vulnerabilities / mistakes and maybe check for them as part of the proposition. Also suggests a possible relationship with ImmuneFi?
Feedback so far:

Graham:
With the number of good developers on the airdrop list this type of proofread or preliminary check will likely happen by default. We could somehow help that be known as a benefit though.
Eugene:
yeah, that's kinda the point. It should probably be explicitly stated as a benefit if it's gonna happen anyway. Also we as a community can systematize it a bit, if there isn't yet a good resource on what vulnerabilities to check for.
Another point is that if it's explicitly stated, projects might want to come to us at earlier stage.

Amazongirl:
We need to canvas the skill set of the lob community and make up a list of skills we can offer to project founders, such as product testing, fundraising, marketing, collaboration opptys (many lobs are probably project founders themselves), and so on.

scar:
Ok but what makes being a lob a benefit? Code423 incentives it already. And like it was mentioned immunefi too. So what would make lobs incentivized to do it as lobs
Eugene:
make the package sweeter? It's not the only thing the community might provide, but an additional part
if the only thing they want is the audit from a couple of guys working in an audit firm, or from a bunch of (unaffiliated?) bug hunters on ImmuniFi – sure, it's better to go there
scar:
Perhaps we could be the light at the the tunnel. The mentions of bug finders reporting bugs and not getting rightful recognition or even ghosted
Maybe as lobs are some of the most recognized devs. We could help figure out whether that bug was exploitable or not and make sure researchers and protocols abide by the law
Eugene:
as a potential benefit to ImmuneFi the community might provide a shame deterrent to those who are ghosting

scar:
I get your point. But imagine the next meme coin bragging about being audited by lobs
Graham:
We would want a disclaimer stating that it is in no way an endorsement or formal audit.

Gas One Cent:
The reviews can expand to docs and UI/UX to allow non-tech people to participate

Additional idea:
Projects get access to using LobsterDAO HR for posting their vacancies if they airdrop.
Arguments:
It's nice to present it as a separate point. I'm sure many projects are not exactly aware which channels are there. Hunting is a pita in the space. Having a new HR source might be very attractive.

~the main proposal was rugged by ivan~

ivan:
Forget auditing and code review. There are 9 fig projects on the line. I ll never associate myself w audits or security reviews while having 0 understanding of it. It’s the best way to get rekt and fucked
U can CODE by making some cool feature or product! Don’t offer it as securit service


documentation for setting up GCP workload identity

Added step by step documentation of setting up workload identity for GCP.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes issue 1112
Added steps by referring GCP Documentation.

@JorTurFer

Added official GCP Documentation link for reference.
Will add to other versions of the documentation once this is finalised to avoid reworking on all the other versions.
Also, GCP Workload Identity needs a nodeSelector to be added to the keda-operator workload spec:
   serviceAccountName: KSA_NAME
   nodeSelector:
     iam.gke.io/gke-metadata-server-enabled: "true"

I think we should add a condition in helm chart which will include this nodeSelector when podIdentity is set to gcp.
Thoughts?

I think we should add a condition in helm chart which will include this nodeSelector when podIdentity is set to gcp.

Definitively, we already have that option for Azure and AWS, I think that we can add it for GCP (to add the node selector but also to annotate the service account, not having to do it manually after)

Will add to other versions of the documentation once this is finalised to avoid reworking on all the other versions.

Nice! I think that now looks nice to replicate in other versions :)

I think we should add a condition in helm chart which will include this nodeSelector when podIdentity is set to gcp.

Definitively! we already have that option for Azure and AWS, I think that we can add it for GCP (to add the node selector but also to annotate the service account, not having to do it manually after)

Thanks, for annotating service account we need to have GCP IAM Service account name and Project ID. Not sure how can we handle that if we try to annotate from helm chart itself.

Will add to other versions of the documentation once this is finalised to avoid reworking on all the other versions.

Nice! I think that now looks nice to replicate in other versions :)

Will raise separate PR for that.

Thanks, for annotating service account we need to have GCP IAM Service account name and Project ID. Not sure how can we handle that if we try to annotate from helm chart itself.

Yes if you do the other steps before update KEDA chart. I mean, you know the namespace where you will deploy KEDA, and you also know the service account name, you could do the other steps before, and then upgrade KEDA in the cluster

Will add to other versions of the documentation once this is finalised to avoid reworking on all the other versions.

Nice! I think that now looks nice to replicate in other versions :)

Will raise separate PR for that.

Please, update all the versions as part of this PR 🙏

Yes if you do the other steps before update KEDA chart. I mean, you know the namespace where you will deploy KEDA, and you also know the service account name, you could do the other steps before, and then upgrade KEDA in the cluster

Makes sense.

Please, update all the versions as part of this PR

Added for all versions starting from 2.5

Yes if you do the other steps before update KEDA chart. I mean, you know the namespace where you will deploy KEDA, and you also know the service account name, you could do the other steps before, and then upgrade KEDA in the cluster

Makes sense.

Would you open a PR in kedacore/charts with the changes?


Remove unused resources

Removed unused strings and colors and integers.

Oh ci failed... :weary:

Oh... I'll fix it.


(IgRequestsLimitError) handler updated

BTW thank you for stories, it was pleasure to refactor your code.

BTW thank you for stories, it was pleasure to refactor your code.
sorry I didn't do it. Thank you for refactoring.


Document retriever from Knowledge-graph based source

Feature request
As the title suggests, there is currently no built-in method to retrieve chunks linked through edges in graph-based structures.
This is especially relevant in cases where documents are not self-contained and chunks reference other chunks, either within the same document or in other documents. These "children" chunks are often necessary to properly answer user queries.
Specifically, I would like to have the ability to perform the following within the same chain:
1. Get the user query
2. Embed it
3. Perform approximate nearest neighbor (ANN) lookup and retrieve the most relevant chunk
4. Given the ID of the chunk, expand the set of matches by navigating the graph
5. Retrieve all of these to provide to the Large Language Model (LLM)
6. Send everything to the LLM to answer the user query

To further contextualize my suggestion, I have been considering the following approach to begin with:
import networkx as nx

GraphType = Union[nx.DiGraph, nx.Graph]

class NXInMemoryGraphRetriever(BaseRetriever):

    def __init__(
        self,
        bootstrap_retriever: BaseRetriever,
        graph: GraphType,
        navigate_graph_function: Callable[[GraphType, str], List[Document]],
    ):
        self._graph = graph
        self._navigate_graph_fn = navigate_graph_function
        ...

    def get_relevant_documents(
        self,
        query: str,
        *,
        callbacks: Optional[List[Callable]] = None,
        tags: Optional[List[str]] = None,
        metadata: Optional[Dict[str, Any]] = None,
        run_name: Optional[str] = None,
        **kwargs: Any,
    ) -> List[Document]:
        base_documents = self.bootstrap_retriever.get_relevant_documents(...)
        expanded_set_of_docs = set(base_documents)
        for document in base_documents:
            expanded_set_of_docs.update(
                self.navigate_graph_function(self.graph, document.metadata["id"])
            )
        ...
        return list(expanded_set_of_documents)

# Example of callable function to pass
def get_everything_one_hop_away(graph: GraphType, source_doc_id: str) -> List[Documents]:
    related_docs = []
    for source_doc, related_doc in nx.dfs_edges(
        graph, source=source_doc_id, depth_limit=1
    ):
        related_docs.add(Document(...)) # From the related docs id.
    return related_docs

Additionally, expanding this to support Neo4J or similar should be rather straightforward. Don't pass the graph but the DB driver and the navigate_graph_function with a cypher query string/literal.
Motivation
Use langchain to navigate graph related datasets easily.
 Closing the issue because I saw that there is already support.
For posterity: https://python.langchain.com/docs/use_cases/graph/graph_networkx_qa for instance.


Site Request: Pornzog (NSFW)

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
United States
Example URLs

Single Video: https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/

Description
Opening this request for pornzog.com to be added as a supported site. Ideally, this site would have the same downloading functionality as any of the other supported sites.
Verbose log
G:\ytdlp>yt-dlp -vU https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/
[debug] Command-line config: ['-vU', 'https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2022.02.04 [c1653e9] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 5.0-full_build-www.gyan.dev (setts), ffprobe 5.0-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2022.02.04, Current version: 2022.02.04
yt-dlp is up to date (2022.02.04)
[debug] [generic] Extracting URL: https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/
[generic] adina-arbour-cumshot-compilation-with-8-cumshots: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] adina-arbour-cumshot-compilation-with-8-cumshots: Downloading webpage
[generic] adina-arbour-cumshot-compilation-with-8-cumshots: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1381, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1451, in __extract_info
  File "yt_dlp\extractor\common.py", line 612, in extract
  File "yt_dlp\extractor\generic.py", line 3986, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: https://pornzog.com/video/11952345/adina-arbour-cumshot-compilation-with-8-cumshots/

Bump


digital-copyright

Hi uashield!👋, I added this optional feature to digitally sign you source-code should you ever be audited or experience a software supply-chain attacks. See the opengs-digital-copyright for instructions on accessing your hash. Feel free to contact me directly to review any questions before accepting. ~~Best<EMAIL_ADDRESS>

Thanks
Let me know if it provides value. Would love your feedback
On Mon, Mar 28, 2022 at 5:22 AM Bogdan @.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/opengs/uashield/pull/198#pullrequestreview-922854719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHAMGMB66J6QECPMXF6GTDVCF255ANCNFSM5RYF6Z2Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

--
Jude Safo | Haiphenai.com


Open source?

Are you going to release this bot as open source?
Will it work with the API in your other repo?
Thanks,

@santiagonn Yes to both of your questions.


[Bug]: Air gapped instance - Audio and Video widget brings up Please provide a valid url message.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I dnd an Audio widget, it brings up Please provide a valid url message.
 It shows "Please provide a valid url" message. The link in the URL - http://localhost/birds_chirping.mp3 - is this.
Similar issue observed for video widget also.

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Self Hosted

It will work if we pass a valid url , since its localhost it is not working. It expects a URL which has .com, .whatever after the domain. So since lochalhost doesn't have one it didn't work.
https://user-images.githubusercontent.com/74818788/232967699-ed5af4a6-7703-4b21-bd79-dc1de3b8ca19.mov
Here is a screen recording of the same thing on dev.appsmith.com since its dev.appsmith.com a valid url it will work. And we put the current origin as the default URL.
So let me know if we still need to solve for this , meaning should I just allow any urls even when it doesn't end with a valid extension like .com etc. @infinitetrooper

Not an issue, this is a widget-level requirement, it's up to the user to use the correct URL. Closing this as this is working for a local valid URL.


Could not validate signature

  if (!isValid) throw new Error(`Could not validate signature "${entry.sig}" for entry "${entry.hash}" and key "${publicKey}"`)
                      ^

Error: Could not validate signature "30450221009e7b69fc934415e8c53c9514c96e04fe78c1dd44d063413b7909b2e65b1c6d2a02203a2863ed1aff0d1dadd7f17fd9890b084f172c8a576c9c0c323bedd10b0c8a00" for entry "zdpuB2nkpNtqAK6AJNPGpH38c8EdiWtG7ejHeGa4KNb2TBsRJ" and key "04582ec1a8ddd4bf7566ac57ee1f103dc2c1088231cf613309f2ad1a00336037ecdb244d3d9130b0676105237808e75c6f6944ea4d4ea529e782316e57a9bca667"
I am throwing this error when attempting to retrieve data from OrbitDB in Node.js. It appears that the private key is incorrect. What I do not understand is that I did not change anything. I was able to make requests, but suddenly this error occurred when I tried the same request without modifying anything.

Try it with v1.0.0 and see if you're still experiencing the problem. Note the new package name.
If the issue persists, feel free to re-open the issue.


Document the interpolate-folder-path feature

A result of the discussion in #88. Also related to #81.

CI is failing due to an unrelated formatting issue (probably a change in rustfmt). The error will be fixed in #81, so this can merge with it failing.

Appveyor seems to be failing need to check it. :(

@pyros2097 #81 will fix the CI issues


cmd/cgo: the object returned CFBundleCopyResourceURL should be released

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.8 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mymac/workspace/gomobile"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/z1/4wwl0fpj7x7_8k42nnxxzs7r0000gn/T/go-build994212619=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
What did you do?
$ gomobile bind -v -target=ios golang.org/x/mobile/example/bind/hello
The hello example for binding with go has leak the memory type NSURL and CFString in init_working_dir().
https://github.com/golang/go/search?utf8=✓&q=CFBundleCopyResourceURL
The object returned CFBundleCopyResourceURL should be released because it's ownership follows the The Create Rule.
https://developer.apple.com/reference/corefoundation/1537117-cfbundlecopyresourceurl?language=objc

@eliasnaur, @ianlancetaylor?


Casks/microsoft-onenote.rb

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Microsoft OneNote 2016 15.40 being split out of the Office Suite.

onenote is an updater not an install.

https://github.com/caskroom/homebrew-cask/pull/41092#issuecomment-347339947


Having rustc, rust-src and cargo in the same path

Hey there,
I'm still new to Nix so please go lightly on me! :)
I wanted to create a Rust project with Nix, and tried instantiating it with rust-overlay.
That worked pretty well, but since I'm using intellij and intellij-rust it expects both rustc, and cargo to be in the same target directory so that it can properly detect the two.
Is there a way to use rust-overlay and still have my desired behaviour?
Thanks in advance! :)

it expects both rustc, and cargo to be in the same target directory

All common usages, eg. rust-bin.stable.latest.default, should be like that. It collects all components into one derivation/directory via symlinks (mostly).
I don't use intellij. You can try it out.


Keep the selected items order after export

Not sure if you saw my comment on the other thread so:
@heitara thank you for investigating! I just pasted your changes in my project that is currently running the up to date version of the master. Unfortunately the problem persists. Images seem to always be placed before videos, disregarding order.
https://youtu.be/LonRlghD8-w

I saw that. I'll test again tomorrow again and will send video if it works on my end.

@Ludotrico I've double checked the version in the branch and it keeps the order of the items. I'm picking image, then video, and so on. I have a screen reccodring that proves it but I can send it directly to you. Could you double check that you are building from the correct repo/branch?
Could you paste the console output from the example app - This is what I get once I finalize the selection:
YPAssetZoomableView >>> No image 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) Picker deinited 👍

This is in my pod-file for my app:
pod 'YPImagePicker', :git => 'https://github.com/heitara/YPImagePicker.git'
Unfortunately, it does not build.

You have to add , :branch => 'feature/issue-488' to specify the branch.

Great work @heitara ! I can confirm that the order is now preserved. What was the issue?

Once all assets are exported those are not sorted again. Like we discussed earlier each asset takes different time to be exported, this is why images were always before the video files. We should merge the fix now. cc  @NikKovIos @s4cha

@s4cha  @NikKovIos it has been a week, can you please merge @heitara's branch?


chore: update CODEOWNERS

What does this PR do / why we need it
Let's make the repository compliant with new GOVERNANCE.md

https://github.com/janus-idp/.github/blob/main/GOVERNANCE.md
https://github.com/janus-idp/.github/issues/22

Self merging, we need to comply with the agreed governance.


String cannot contain  newlines

As you can see...
It is possible to trim newlines to avoid this error?

It is generated my guess from LSP using php actor but I am not sure what is the source...

I can see from the traceback that the call to vim.notify is within your own config in .config/nvim/lua/plugin/lsp.lua. Can you show what that LSP handler looks like?

The snippet is the one on https://github.com/neovim/nvim-lspconfig/wiki/User-contributed-tips#use-nvim-notify-to-display-lsp-messages
my dot files: https://github.com/Mte90/dotfiles/blob/master/.config/nvim/lua/plugin/lsp.lua#L168

Aha yes that's it. It places it in a list for some reason. Just change { result.message } to result.message and it'll work as expected

Cool :-)


Adding basic troubleshooting steps

To enhance the document, adding basic troubleshooting steps.

@kaushika-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Deland-Han : Thanks for your contribution! The author(s) have been notified to review your proposed change.


ComposeGuard will read all reports from compose_reports folder, leading to false positives

Steps to reproduce:

Open example sandbox-android-app project
Disable strong skipping
Run debugComposeCompilerCheck
Run releaseComposeCompilerCheck

BUG: Check will fail with the New Composables were added that are restartable but not skippable! error, even though no Composable was added.
From my analysis, it seems the problem is that plugin will indiscriminately read all files from compose_reports folder. That folder will in above case contain both app_release-composables.txt and app_debug-composables.txt, which means that existing composables will get read twice, leading to a false positive, since number of read composables is now higher than number saved in the report.

good catch! thank you for the report. I have updated the tasks to only use that variant for the reports. if no variants exists (running debugComposeCompilerCheck even though debugComposeCompilerGenerate hasn't been run yet), you'll now get the following error message

Pushed out release 2.2.0 to maven central with this fix

Thank you!


allow initiating peer to close stream gracefully

I have a use case where I would like to remove a worker without killing it. Currently, trying to disconnect from the head node will cause the message handler loop to throw a fatal exception, so this adds a check that the connection is still open when trying to read new messages.
The test case is taken from https://github.com/simeonschaub/PersistentWorkers.jl, which I'd eventually like to register once this is merged.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.85%. Comparing base (76df474) to head (35a095d).

:exclamation:  There is a different number of reports uploaded between BASE (76df474) and HEAD (35a095d). Click for more details.
HEAD has 9 uploads less than BASE

Flag
BASE (76df474)
HEAD (35a095d)

10
1

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   86.20%   78.85%   -7.36%
==========================================
  Files          10       10
  Lines        1965     1906      -59
==========================================
- Hits         1694     1503     -191
- Misses        271      403     +132

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I'm surprised at the seemingly-random CI failures :thinking: Does this also happen with Distributed?

Hmm, I had hard-to-reproduce failures with these tests before, but I thought I fixed everything. When I use persistent workers interactively at least I don't encounter any of these issues, so it seems to have something to do with the worker process being spawned from another Julia process like this.
Can you think of any way to test this more directly? I am almost tempted to go ahead with this without any test as the change itself is really quite simple but that of course makes it hard to ensure this functionality does not regress

I'm a bit hesitant to merge it directly given how common the failures are :sweat_smile: I'll try running the tests locally and see if I can reproduce them or come up with a simpler test. Could just be a bug in the tests rather than in the actual change.

I think this is a race condition caused by improper behaviour in DistributedNext.launch(::PersistentWorkerManager). If I read it correctly all the function does is assign some properties and then return without actually ensuring that the worker has been started. But Distributed/DistributedNext requires that the worker is running by the time launch() finishes because immediately afterwards the head node tries to connect to it, and that's what's causing the connection failures.
This happens in CI because the workers take an extra 1-2s to precompile, and that's more than the sleep(1) statement allows for. Adding a sleep(10) fixed it and you can see in the worker logs how long the precompilation took, but I think the real fix is to ensure that launch(::PersistentWorkerManager) only returns after the worker has started. And then we can also delete the sleep(1) call in the tests.
(feel free to delete/squash my debugging commits BTW, though I would recommend keeping in the calls I added to pipeline() and wait(worker).


[TS migration] Migrate remaining Mock and Script files to TypeScript

TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files

Path
Dependencies

scripts/release-profile.js
2

mocks/react-native-document-picker.js
0

<EMAIL_ADDRESS>1

This issue is internal and will be carried out by the TS team.

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Great. TY!

Checklist not needed.


Preview material in open menu

It would be great to have a preview of the materials in the "open file" dialog.
Some mockup:

That would need a completely custom FileDialog. Seems like a lot of work.
Plus a preview would have to be saved in the .ptex file.

Plus a preview would have to be saved in the .ptex file.

Or alongside it.

Plus a preview would have to be saved in the .ptex file.

Or alongside it.

Won't work if you copy or download a material.

Plus a preview would have to be saved in the .ptex file.

Or alongside it.

Won't work if you copy or download a material.

Could be generated by MM after it's loaded for the first time.


V4 willingham Pull Request

Made protection better and made sure to make it for v4

moved to #379


telemetry: remove various hacks/workarounds

This removes some of the hacks which were required in the past:

Calibration health using params as this should be covered by system status now.
Position validity based on system status instead of GPS magic.
HITL workarounds that should also be taken care of autopilot internal.

Closes #2318

Does this change require a minimum version of PX4/Ardupilot?

Presumably, no idea...

Fine for me anyway, I was just curious!


The difference of Stable-Zero123 and Zero-123-XL

Hi
Thanks for your excellent work.
I am wondering the slight difference in your stable_zero123_guidance.py and zero123_guidence.py.
Could you please explain why the delta radius is different from zero123?
        T = torch.stack(
            [
                torch.deg2rad(
                    (90 - elevation) - (90 - self.cfg.cond_elevation_deg)
                ),  # Zero123 polar is 90-elevation
                torch.sin(torch.deg2rad(azimuth - self.cfg.cond_azimuth_deg)),
                torch.cos(torch.deg2rad(azimuth - self.cfg.cond_azimuth_deg)),
                torch.deg2rad(
                    90 - torch.full_like(elevation, self.cfg.cond_elevation_deg)
                ),
            ],
            dim=-1,
        )[:, None, :].to(self.device)```

It appears that stable zero123 eliminates the delta radius conditioning and opts for an estimated elevation instead.  I didn't find a source that explains the reason for this.

@echosum Hello, sorry to bother you. May I ask you a question, please? I wonder that, if I want to run the code with Zero123-XL instead of Stable-Zero123, should I switch guidance_3d_type from "stable-zero123-guidance" to "zero123-guidance"?

@echosum Hello, sorry to bother you. May I ask you a question, please? I wonder that, if I want to run the code with Zero123-XL instead of Stable-Zero123, should I switch guidance_3d_type from "stable-zero123-guidance" to "zero123-guidance"?

I think you should use "zero123-unified-guidance"

@flyingdoubleG Hello, many thanks to your guidance! I wonder whether there are non-trivial difference between zero123-guidance and zero123-unified-guidance? Because I have run some cases with zero123-guidance and zero123-xl.ckpt and the geometries of the results are reasonable.
Thanks a lot! :)

@flyingdoubleG Hello, many thanks to your guidance! I wonder whether there are non-trivial difference between zero123-guidance and zero123-unified-guidance? Because I have run some cases with zero123-guidance and zero123-xl.ckpt and the geometries of the results are reasonable.
Thanks a lot! :)

Ah, I think they are almost same except the way for loading the model, and zero123-unified-guidance also implemented VSD, you can try both

@flyingdoubleG Thank you for your answer! I will try both of them.

@flyingdoubleG Hi!
Can you help to find where I can set zero123-guidance and zero123-unified-guidance? I can't find these settings(


Fifo present mode occasionally returns VK_TIMEOUT without blocking in wgpu-rs examples

System Details
OS: Manjaro 20.2.1 Nibia
Kernel: x86_64 Linux 5.10.7-3-MANJARO
DE: Xfce4
CPU: Intel Core i5-4690 @ 4x 3.9GHz
GPU: AMD Radeon HD 7900 Series (TAHITI, DRM 3.40.0, 5.10.7-3-MANJARO, LLVM 11.0.1)
drivers tested: radv, amdvlk, vulkan-amdgpu-pro

wgpu provides a 1s timeout which ends up being passed to Swapchain::acquire_next_image however on my system sometimes VK_TIMEOUT will be returned within ~20-200µs when using the Fifo present mode. This occurs every few seconds for me on the wgpu-rs water example (Note: most of the examples use Mailbox by default so to test this the present mode needs to be changed).

ash is a thin binding to Vulkan. Unless you have specific cause to believe your operations are getting mangled before the driver sees them, you should report this to the vendor instead.

That's reasonable. We'll keep tracking this on our side.


Expenses list does not always get generated

This happened for one of the first time claim flows when running the end to end tests

This issue seems to have been related to using conditional logic around partials and was only seen on the NI rules work. Should now be resolved will confirm tomorrow and close if no longer occurring.

Confirmed issue is no longer occurring.


Better SSL integration

I've successfully added SSL to the status page, I had to modify Dockerfile so that it copied the ssl files to the container.
Does adding an empty folder (conf/ssl) that is then copied in Dockerfile and also exposing port 443  make sense to you, if yes I can add a PR with those changes so that other users can setup setup connections easily.
Thanks,

I would just submit the PR.  I have done this already for other parts.  Adding and expose for port 443 would make a ton of sense.

If you'd like to keep a modular design, maybe you would like to have an nginx in front of Cachet. I use @jwilder/nginx-proxy in a docker-compose like this, this image even has the option to use Let's Encrypt to automatically generate the certificates:
  nginx-proxy:
    image: jwilder/nginx-proxy
    ports:
      - "80:80"
      - "443:443"
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - ./certs:/etc/nginx/certs:ro
    environment:
      - DEFAULT_HOST=status.xxxx.com
    restart: always

Also there are other options like Traefik

Hi, I'm having almost the same issue.
I use the docker image, exposed with traefik (which handle letencrypts). However while I start the docker with -e APP_URL=https://mydomainname and configure cachethq with https in setup, cachethq still create links with http:// prefix which is very annoying, do you known a way to fix that?

I posted this on the main CachetHQ project but I'll share my customer solution to this here.
I have OpenLiteSpeed acting as a reverse proxy for all of my docker web apps with LetsEncrypt. In order to make this script function without editing the php file for allowed hosts I used OpenLiteSpeed's mod rewrite functionality which is similar to Apache. I'm posting this here as I don't know git well enough to do a pull/merge or what ever it is. However I'm hoping that in the future this little bit of code will help people. While this isn't probably the preferred method for this, I noticed a few posts about it when I was going through the list of issues. I'm sure someone could take this and modify it to work out of the box with most web servers.
This one is for Cachet-Proxy vhost
rewriteCond %{HTTPS} !on
rewriteRule ^(.*)$ https://%{SERVER_NAME}%{REQUEST_URI} [R,L] RewriteRule ^/(.*)$ http://Cachet-Proxy/$1 [P,E=Proxy-Host:YourSub/DomainGoesHere]
This one is for the Docker-Proxy (Portainer) vhost
rewriteCond %{HTTPS} !on
rewriteRule ^(.*)$ https://%{SERVER_NAME}%{REQUEST_URI} [R,L] RewriteRule ^/(.*)$ http://Docker-Proxy/$1 [P,E=Proxy-Host:YourSub/DomainGoesHere]
That being said I actually run OpenLiteSpeed + Certbot on the docker host natively. Since I'm using it as a reverse proxy I only have to open 80:443:8443(OLS Admin) on that VPS. Since OpenLiteSpeed has a web interface for the backend while I'm building my docker images I'm usually proactively thinking about how/where I am going to set OpenLiteSpeed up for that application.
You can test my configuration on my Cachet Page. I by no means am not a linux/docker expert but I can try and answer questions if you need help.

Sidecar are deployed on the same Pod as the Cachet Pod and it in the path of the network to take up the SSL work from what I understand.  In the Deployment yaml you would spell out 2 containers with the sidecar bing the inbound first touch container.

Caddy would be a no-go, because it's not free for non-trivial usage.

What if we simply allowed a user to at least drop an SSL cert in the conf folder, or something?

Hi, I'm having almost the same issue.
I use the docker image, exposed with traefik (which handle letencrypts). However while I start the docker with -e APP_URL=https://mydomainname and configure cachethq with https in setup, cachethq still create links with http:// prefix which is very annoying, do you known a way to fix that?

Workaround: within conf/nginx-site.conf I've added:
fastcgi_param HTTPS on;

along with the rest fastcgi_param directives within server block.
APP_URL was defined with https:// in docker-compose.yml

I'm getting this too. I have cachet behind SSL terminating load balancer.
Mixed Content: The page at 'https://status.my.domain/setup' was loaded over HTTPS, but requested an insecure favicon 'http://status.my.domain/img/favicon.ico'. This request has been blocked; the content must be served over HTTPS.

Hi, I'm having almost the same issue.
I use the docker image, exposed with traefik (which handle letencrypts). However while I start the docker with -e APP_URL=https://mydomainname and configure cachethq with https in setup, cachethq still create links with http:// prefix which is very annoying, do you known a way to fix that?

Workaround: within conf/nginx-site.conf I've added:
fastcgi_param HTTPS on;

along with the rest fastcgi_param directives within server block. APP_URL was defined with https:// in docker-compose.yml

this fixed the issue for me


Fixed rspec, updated to 3.0, removed , minimal failed case spec

@baraabourghli ,
Its interesting approach, the constant is set on the Kernel layer. Wondering if its a way to unload the whole constant, on reload ?
Maybe best to  add a constant cleanup after reload/load?
e.g:
C.load 'toto'
C.load 'tata' (Kernel still has the toto constants)

This branch looks great :+1:
for the constants cleanup on reload, did you face an issue with it?
you can continue the discussion here https://github.com/baraabourghli/constantizer/issues/10

@faizalzakaria another thing, please add your name + email to gemspec authers, and bump the gem version :)


controlsd: preEnable on brake at a standstill

longActive now checks if enabled instead of active, which includes preEnabled. preEnabled is now only entered at a standstill with brake

Has a minor problem with the Bolt. It allows enabling at a standstill with brake, despite the min enable speed of 3 mph without brake. However the noEntry upon releasing the brake after enabling takes precendence over transitioning from preEnabled to enabled and we disengage

either need to know the state of OP in the car interface or don't consider noEntries after we're preEnabled. Which overriding already does, so that might make the most sense. Cruise is already activated on most cars in this state, and noEntry is really for first enabling. @adeebshihadeh that sound good?

yeah that makes more sense

Should we also remove the noTarget event?

Was going to do in another PR as it has some implications we might want to think about. I think we restricted to only enabling behind a lead (or now when e2e wants to stay stopped) because it maybe makes it harder to do unsafe things?


Add tests for array lib functions

Purpose

$subject

@pubudu91 We need to add runtime validation for operations like pop, push, shift, unshift, sort, reverse etc, in order to make sure, inherent type is not violated.


PropertySerialization_Tests failing

I'm getting familiar with the code and I noticed a few unit tests failed.
Specifically, I'm looking at PropertySerialization_Tests failing.
I'm getting an error of "Calendar properties aren't being properly serialized"
Not sure if you were aware of that, so I'm bringing it up.

Ah, I see you've already added #209
I'll take a look at it.


how does GiniClust normalize data?

Hello,
Can you give a more detailed description regarding how the raw UMI counts are normalized in GiniClust? I did not find such information in the publication. Thank you very much!

Please note this is an older version of GiniClust, which can only detect rare cell clusters. In our newer versions (v2.0 and v3.0) we have improved the method so that it can detect both rare and common cell types. The latest version (v3.0) can be found here: https://github.com/rdong08/GiniClust3. We use Scanpy to normalize gene expression values.


[FEATURE] Intel/Qbits CPU inference

Integrate Qbits into GPTQModel so that those without CPU can run quantized models. @CSY-ModelCloud  is already working on this.
Target: v0.9.2

Closed by PR https://github.com/ModelCloud/GPTQModel/pull/137


Angular 7 Cannot read property 'refresh' of undefined

Hello,
I just started using this plugin and upon running npm install and importing, I am met with this error:
DashboardComponent_Host.ngfactory.js? [sm]:1 ERROR TypeError: Cannot read property 'refresh' of undefined
at resolveOption (chartjs-plugin-streaming.js:139)
at startDataRefreshTimer (chartjs-plugin-streaming.js:254)
at ChartElement.initialize (chartjs-plugin-streaming.js:405)
at ChartElement.Element (Chart.js:2747)
at ChartElement [as constructor] (Chart.js:1971)
at ChartElement [as constructor] (Chart.js:1971)
at new ChartElement (Chart.js:1971)
at Chart.js:8620
at Object.each (Chart.js:1801)
at Chart.buildOrUpdateScales (Chart.js:8599)
I am clueless as to how to proceed with resolving this. I have the latest versions of moment.js and chart.js. I imported this way into the .ts file where streaming is needed:
import 'chartjs-plugin-streaming';
import * as moment from 'moment';
Any help would be very much appreciated.
Thanks.

For some reason, simply importing this plugin into a file where charts of different types were defined (no real-time charts) produced this error. I then changed the type of one of my graphs to realtime without specifying any options then changed the type back to time and now I see no errors.

It turns out that the bug occurs when a chart with type 'time' is present without a streaming: false flag.

streaming: false

Hi, where did you set that options, tryed everything but still not working

This was a while ago, but in my case, the bug occurred when I had a chart with type time and did not specify if it was streaming or not. So, when you instantiate the chart, in the options property options { }, you add
plugins: {
streaming: false,
},
Hope this helps.


Music stream lagging every now and then

Describe the bug
Haven't encountered it myself yet, but my friends reported many times that the bot has a tendency to stream quite choppily every now and then with ~1s breaks during streaming (suggesting buffering issues? - kinda weird, given that both Jellyfin and the bot run on the same machine).
To Reproduce
Steps to reproduce the behavior:

Run the bot from the docker image
Play music
???
Stream starts to get choppy

Expected behavior
Music is streamed without interruptions.
Additional context
Not much info as I don't know much about this bug yet, mainly writing it down to not forget - I'll expand this issue as we'll learn more.

Hi @sssionek , has this been resolved?

@Corban-Lee can you post your hardware specs?
Is it running over WLAN / wired?
What is the latency to Discord and to Jellyfin?

Sure thing
CPU: Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
Integrated GPU: Intel Corporation CoffeeLake-S GT2 [UHD Graphics 630]
RAM: 2x - CT16G4DFRA266.M16FR (16GB) (2666MHz)
Motherboard: PRIME H310M-R R2.0
OS: Ubuntu 22.04.4 LTS
Running the container in docker using the wiki instructions.
Both services (jellyfin & jellyfin-discord-music-bot) are running on the same machine, and my JELLYFIN_SERVER_ADDRESS env var set to the server ip:port for jellyfin http://192.168.0.XX:XXXX.
Latency from the host to https://discord.com/api:
DNS Lookup: 0.013779
Connect: 0.029197
Start Transfer: 0.250888
Total: 0.253467

Server region override is set to automatic, I don't see an option for my region of Europe or UK.
Perplexingly, after just testing again, I'm no longer hearing gaps in the audio playback through the Bot.
I'm unable to confirm whether this was an issue with jellyfin, my hardware usage or this software.
Details (unsure of specifics):
Host OS is running on an SSD
Media is being served from 7200RPM HDD
My music is stored as high quality flac files.
No evident CPU spikes during playback, low usage all around.
I'm not sure I need to continue here if the problem has suddenly disappeared without an apparent reason, but thanks for the hasty support!


FLOATING POINT FORMATS

  Description: Only the %f floating point format is supported.  Others are
               accepted but treated like %f.
               Update:  %g is supported with CONFIG_NANO_PRINTF.
  Status:      Open
  Priority:    Medium (this might important to someone).

it should support now, let's close it.


Split up bootstrap tasks and submit individual ones to the executor.

Same as #28, but without manual task splitting, since the executor is doing that.

This bombards the process with hundreds of threads (I think I saw it go over 1k). That is why I did what I did in my PR.
MC is using a Cached Thread Pool. Unless you change that on MC, this is not good.
Now, overall I do prefer the cleaner approach here, but really needs clarity that it needs to use a queued executor instead.

Can confirm, 1.13.2 pre 1 creates over 1000 threads at startup (for reference: 1.13.1 needs about 50). This really lags out some systems completly.

Just to mark this as a reference, this change introduced 2 bugs which will kill the game on old hardware (below minimum requirements, but generally dual cores with no SMT/HT available).
https://bugs.mojang.com/browse/MC-137353
https://bugs.mojang.com/browse/MC-138093

When opening 1.13 my computer does 5fps causing other programs to also lag or crash.


Add support for a delimiter in multiple params that is not a shell special character.

Instead of "x=1&z=test" to use something like "x=1 y=test".

One use-case from Amir Friedman:
"- it's not possible to have directives values containing the "&" character (I couldn't find a way to escape the character).
For instance, it's not possible to use this command :
php zs-client.phar configurationStoreDirectives --directives="error_reporting=E_ALL & ~E_NOTICE"
"

class module{
public function extern escape{
configurationStoreDirectives --directives="error_reporting=E_ALL & ~E_NOTICE & ~E_LOG"}}
 On Monday, 13 July 2015, 10:38, slaff<EMAIL_ADDRESS>wrote:

One use-case from Amir Friedman: "- it's not possible to have directives values containing the "&" character (I couldn't find a way to escape the character).
For instance, it's not possible to use this command :
php zs-client.phar configurationStoreDirectives --directives="error_reporting=E_ALL & ~E_NOTICE"
"—
Reply to this email directly or view it on GitHub.

Even with

strong quoting: --directives='error_reporting=E_ALL & ~E_NOTICE'
or escaping: --directives="error_reporting=E_ALL \& ~E_NOTICE"

?


when VLP-16 pack will add into current repository

Hi, I found the current method is only supported VLP-32, but VLP-16 is not supported, I am wondering when the VLP-16 will be supported?

@LittleByLittle2 VLP-16 is already supported, you can just set 'LiDAR_type' to "vlp16_puck" in the config.yaml file.

@LittleByLittle2 VLP-16 is already supported, you can just set 'LiDAR_type' to "vlp16_puck" in the config.yaml file.

Thanks.


The modified image display is not working in the admin ui of Wagtail 4.0.1 and Django 4.1.1

Hi, thank you very much for your report!
The admin panel UI in Wagtail 4.0 has changed a lot in comparison to previous versions like Wagtail 2.16.
Due to this changes the CSS and HTML code (which is pretty "hacky" here) is currently incompatible.
I will create a fixed version during the next weeks 👍


Develop rest cert chain tests

@AdrianPadilla can you use one of the existing operators to test this rather than adding a new operator? Existing operators manages domains, so it covers that flow as well.
fyi @tbarnes-us @anpanigr

Hi @vanajamukkara, yes that was my first approach, but then I realized there is no current test that uninstall the operator i.e. nowhere in ITOperator the Operator#destroy() method is invoked, and I would have to use some logic to wait for the k8s elements to be fully removed before continue with other test.

@AdrianPadilla You are right, operator is not removed in the integration tests. You can add that logic if its needed for your test.


File host blocks onedrive link

1drv.ms
is not adware or malware are Microsoft Onedrive links

@mitchellkrogza can you look into 1drv.ms?  Thanks!

@StevenBlack build in progress, will notify you once done.

https://github.com/mitchellkrogza/Badd-Boyz-Hosts/commit/fec3a4b85f0db9f72746389a5847f988e4730646 Fixes: #403

Thanks Mitchell @mitchellkrogza.  And thank you, Francesco @difo, for flagging this.
Closing.

:+1: @ StevenBlack now that I have started building my central repo of dead, inactive, whitelisted and false positives moving forward is going to be a breeze for curating


Modify the title h1...h6 to be displayed

Hello! It is recommended that the titles h1...h6 be modified to be displayed when the mouse is hovering, instead of always displaying h1...h6, which looks too ugly. It is recommended to use extra colors to highlight h1...h6 font colors
Window10
Latest version of theme

Hi @zhouxinghong. Thanks for the feedback.
Could you explain the extra colors h1-h6 you said? Are you referring to the colors of the h1-h6 labels (reading mode) or the colors of the actual text of the h1-h6 headings?
You can customize the h1-h6 text colors using the theme's available options in the Style Settings plugin.
About the h1-h6 labels when using Reading mode, I honestly like the way it is. But I will test if it works well with the hover effect (displaying h1-h6 labels only when the user hovers over the titles).

Could you explain the extra colors h1-h6 you said? Are you referring to the colors of the h1-h6 labels (reading mode) or the colors of the actual text of the h1-h6 headings?

I think it's better to provide settings for these styles so that users can selectively enable it, rather than completely destroying the styles of the previous theme.

Ok. Thanks for explaining.
Do you think it would be useful to have different colors for these h1-h6 labels?
I may try to add this feature using the Style Settings plugin. In your point of view, should the default option be labels on hover only?

I am asking because I will try to keep the option to let the labels always visible too.

Ok. Thanks for explaining.
Do you think it would be useful to have different colors for these h1-h6 labels?
I may try to add this feature using the Style Settings plugin. In your point of view, should the default option be labels on hover only?

Um! Yes.

Let me know if it is working well for you, so I will close the issue. Thanks for the suggestion. I also changed the font to make it easier to read (h1-h6 labels -> reading mode)

Further improvements:

Number 4:
The height of the vertical line on the left when hovering the mouse should remain the same as the title and the color of the vertical line should be different from the title color, so that the appearance will be more beautiful.

It needs to be said again that your theme is currently the most beautiful theme in Obsidian. 👍😜

@zhouxinghong. Thanks again for the feedback and the kind words.
Please answer the questions below:

Why the color of the labels h1-h6 should be different than the h1-h6 text color since they are just indicators of the H1-H6 headings?

Do you think these labels should have one color for each heading (h1-h6) or one label color for all headings?

Right reading indicator: Do you think this indicator should be deleted? Some users find it useful to tell the right border of the paragraph. Maybe I will make it optional.

Please answer the following questions:
Since tags h1-h6 are just indicators of H1-H6 headings, why should the color of tags h1-h6 be different from the color of h1-h6 text?
Answer: The label color is different from the title text color to better highlight the current label number, for example, h1, h2 or h3, h4, h6, etc.
Do you think these tags should use one color for each heading (h1-h6) or one tag color for all headings?
Answer: One color should be used for each heading (h1-h6)
Read right indicator: Do you think this indicator should be removed? Some users find it useful for displaying the right border of a paragraph. Maybe I can make it optional
Answer: Make it optional and hide it by default

Please check theme version 7.4.0.
Suggestion Number 1:
Please use a different highlight color than the title on mouseover
Answer: You can select label colors h1-h6 for light and dark modes (6 independent colors). So you can give a very colorful look to these labels. You can select the ones you like the most, as it is a matter of personal taste.
The default option has been changed to a light purple color (different color than the default title colors). All labels are the same color to avoid distractions and maintain a consistent look within the theme.
Suggestion Number 2:
Don't show this on mouseover
Answer: Implemented. The default option will show the left reading indicator only. The right indicator can be visible using Style Settings option (3 available options: left only, light and right and no indicators).
Suggestion Number 4:
The height of the vertical line on the left when hovering the mouse should remain the same as the title and the color of the vertical line should be different from the title color, so that the appearance will be more beautiful.
Answer: Not implemented. The vertical line will have to stay the same way as it is right now. I tried to make it smaller but the glow effect didn't look the way I like. Sorry, but this line height will remain the same.
Suggestion Number 5:
Can users be allowed to change square corners to rounded corners?
Answer: Implemented. The default option is "Rounded corners" and the user can select "square corners" using the Style Settings plugin. So you have both options on this newest version (theme 7.4.0).

You can find reading mode settings in the UI Basic Settings of the theme.

I hope you enjoy. Let me know if it is working well for you.
All the best

I'll first take a look at the improved effect, and then give you feedback later. . .

Hello!
Number 4:
Where can I modify the color of the vertical line on the left when the mouse is hovering?

You can select the left and right indicator color using the Style Settings (UI Basic Settings, or just search for "reading".

Do you want to have another hover effect?. This vertical line only appears when you mouse over the content (text or titles). Move the mouse away and the line disappears.

Do you want to have another hover effect?. This vertical line only appears when you mouse over the content (text or titles). Move the mouse away and the line disappears.

Um! Yes 👍

Sorry, I don't plan to implement this feature. Thanks again for the feedback.

If I have more time I can try to implement this feature for you and others that may find it useful. Honestly, I don't think this feature will make a big difference to the theme (hover -> hover effect). I hope you understand.
If you have other suggestions please let me know. This one I will not add to the list of features to implement at this moment.
All the best

The above functions have been improved very well! I hope to continue to work hard to make the theme better! 👍

Thanks for your feedback. It is very important to me. I appreciate it.

Number 1:
Keep improving it:
Can the vertical line on the left be improved to rounded corners and support adjusting the thickness of the vertical line.

Hi

I created another issue so we can talk about the vertical line there. Closing this issue. See you there.


Valuto Mining Pool

Pool for Valuto
http://altcoinix.com/valuto/public

This is not an issue. Please post mining pool info on https://bitcointalk.org/index.php?topic=2911076.new#new instead.


Try saving test timings data on CircleCI

Supposedly this can be used to split tests better.

This doesn't appear to be working, unfortunately.


Allow disabling CPU throttling

What this PR does / why we need it:
For latency critical workload you might want to disable the --cpu-cfs-quota flag on the kubelet (default is true). This PR allows you do that via the shoot spec
  kubernetes:
    kubelet:
      cpuCFSQuota: false

Release note:
Allow disabling CPU throttling

Thank you @afritzler. Have you seen also #987 and #996? Is there a way to find a generic solution, so that people can tweak their kubelets more individually (at their risk)?

Yes, I saw those 2 issues. However after watching [0] I thought it would make sense to start with the CPU throttling/quota handling itself first. Also it was a pretty easy thing to build. Same can be applied for the more fine grained CPU management policies in the future pretty easily.
The more general solution is a little cumbersome since the kubelet has a boat load of flags and the question here would be: should we just dump them into the kubelet service definition without validation or not.
[0] https://www.youtube.com/watch?v=6sDTB4eV4F8

And of course, if you allow to configure everything the kubelet has to offer you need to consider the following:

make sure a flag is available in a particular kubelet version (otherwise the kubelet won't start)
we don't increase the ops effort on our side because people blowing up their cluster nodes by misconfiguring the kubelet

Sure, I see that. On the other hand, Gardener is not about hyperscaler-alike me-too clusters. Freedom of infrastructure, freedom of choice, freedom of configuration is the most compelling argument for Gardener (besides its kubeception approach and the level of self-healing and auto-scaling). Whoever wants to use Gardener to setup a managed service can still limit the options, but primarily our strategy is to enable people and give them the options.
That's why I was thinking to follow in the footsteps of kubeadm here and their approach is to embed KUBELET_EXTRA_ARGS into their kubelet launch command (as last parameter), see https://kubernetes.io/docs/setup/independent/kubelet-integration.
If you do that as end user, i.e. pass in kubelet args in the shoot resource and we "blindly inject" them, then we do that and you are on your own/lose warranty if you will.
WDYT?
Then (1) would no longer be on us and (2) is something we also face today. If people give the cluster no quota or configure the shoot with only 1 tiny machine or use machine types currently not available in that region or have only one worker pool they taint with NoSchedule or break it in any other way, the cluster will fail. We anyways need a solution to this problem. Not a solution that will prevent these things from happening, because I do not believe that's possible, but a solution that highlights possible failure reasons conveniently, first to the end users and only second to the ops staff. In that sense, that's another hint ("Workers fail to register, possible reasons a.), b.), ... x.) custom KUBELET_EXTRA_ARGS).

Ok, then we need I guess an agreement on how we configure the kubelet in the future. Currently custom configuration goes into via the KubeletConfiguration api object like podPIDLimits. The KUBELET_EXTRA_ARGS has the highest priority and will override all other changes. So the most radical way to do it would be to allow map[string]interface in the kubelet section of the shoot spec. That way the user can set any flags he wants. Validating those would be tricky but that way you will end up with the most flexible solution.
I am frankly more a fan of the KubeletConfiguration object approach myself since there we have proper types [0].
@rfranzke what is your take on that?
[0] https://github.com/kubernetes/kubelet/blob/master/config/v1beta1/types.go

I'm not sure... I get @vlerenc's motivation in enabling the users to configure the stuff without the need to involve us/change Gardener. However, since the beginning of the project we were always very careful with what we expose and what not. If we start to allow configuring anything to the kubelet then I guess @afritzler is right: We will very soon end-up with a lot of clusters that are broken/can not be reconciled anymore/can not be repaired anymore/need manual intervention/require ops or effort.
Also, allowing this could break our updates (let's say a user configures a flag that is removed in the next k8s version). Sure, we can say that the user is responsible for breaking his cluster, nevertheless, it will be flagged red in our dashboards and at least requires ops attention.
I'd probably try to stick with our currently way of doing this: expose the flags with dedicated types/names, implement proper validation for valid values/supported k8s versions, and therefore reduce the potential ops effort.

Please take a look at #996. Even if you would validate the keys, how would this help in preventing misconfiguration in the values? So my point is not to invest into something that doesn't deliver what we hope for. Controlling the kubelet args is not possible to the level that we can ensure that the cluster will work fine. That's all I am saying.
Anyway, I am fine if you decide to go for explicit args. Then please take a look at the screenshot in #996 and add node-ip and cluster-dns. Hmm... but node-ip is actually a problem in this case. The end user that asked for this/had multiple network interfaces? @afritzler Do you recall the use?

Well node-ip is going to be hard to implement no matter how we will approach this. Primarily this PR is going to cover just the CPU quota/throttling. We could add the cpu-manager policies or add them via a separate PR.
Regarding KUBELET_EXTRA_ARGS vs explicit types:
How about having a curated list of typed values where we know what will happen (like this PR) and which cover most of the use cases (in future we will add them as they are requested). And in parallel having a "Danger Zone" kubeletExtraArgs *string field which will allow the user to override everything. If kubeletExtraArgs is set, all typed values are ignored. I agree however with @rfranzke and his concerns on the potential extra effort in ops for us especially after upgrades.

So my point is not to invest into something that doesn't deliver what we hope for.

That's true, we can't solve the problem to full extent/prevent all problems with the configuration, however, I think we can still cover a large portion of configuration issues by exposing the flags in the API (instead of allowing everything).

And in parallel having a "Danger Zone" kubeletExtraArgs *string field which will allow the user to override everything.

Well, then it doesn't make sense to expose the flags individually. If we want to have that, then we should only have that, otherwise maintaining this kubelet block gets even more complicated.

Well I guess then we should stick to the individual flags. And add more upon request.

OK, if you prefer the guarded approach, then we do that. This means:

We have to get every required/requested flag in separately
We have to keep track for which Kubernetes version they apply
We may have bad feelings about alpha flags, but if there is a justified need, it's Gardener's strength to allow for this configurability, so we'll do that as well

Consequently:

Add cpuCFSQuota (may be true or false), because that's what @afritzler requires
Add cpuManagerPolicy(may be none or static), because that's what @freegroup requires
Add clusterDNS (may be comma-separated list of DNS server IP addresses), because that's what another stakeholder requires

In addition please launch the kubelet always with the $KUBELET_EXTRA_ARGS just like kubeadm. This way our end users don't have to work around our reconciliation too hard, but can via daemon set inject/set the env var before the kubelet launches. They can do that anyway, we will not promote it, but I want them not to struggle too hard and make assumptions about our implementation details so that we remain free to change them anytime. Let's not go into the discussion, that they can't make these assumptions. That we are "right" doesn't help later when we change it and their workload fails and we have a nasty discussion. I always want to have an ace up our sleeves, so that they can help themselves and don't depend on us too much and this looks like a smart way to achieve that and a compromise hopefully concluding our discussion.
I hope you agree?

I guess the guarded approach does not only bring us less ops effort, it also allows us to do proper upgrades in the future - what if, for instance, some flag ceases to exist in a certain version or is renamed? With the guarded approach, we can do the migration depending on the Kubernetes version of a Shoot without the user having to manually interfere.
About launching with KUBELET_EXTRA_ARGS: How should anybody be able to change that at runtime? The kubelet is launched by the operating system as a regular process and thus cannot be altered like any other pod. Even if a user deploys a DaemonSet on a cluster, changing the environment of a running process is not really possible / would involve a restart of the kubelet which again might to extra harm + will be overridden as soon as the operating system config controller reconciles.

About launching with KUBELET_EXTRA_ARGS: How should anybody be able to change that at runtime? The kubelet is launched by the operating system as a regular process and thus cannot be altered like any other pod. Even if a user deploys a DaemonSet on a cluster, changing the environment of a running process is not really possible / would involve a restart of the kubelet which again might to extra harm + will be overridden as soon as the operating system config controller reconciles.

Don't worry, people know how to do that - and more. The screenshot I showed in #996 was a real one. They even tricked/tweaked our update/reconciliation behaviour and restarted the machine. Please add the flag, so that they don't have to do that anymore to the extent they had to work around us in the past. I don't want them to do that, for their and our sake (their solution exploited our implementation details, which is not in our interest, whoever is "right" here).

The KUBELET_EXTRA_ARGS should be handled by a different PR, so let's merge this one now. Also, maybe we should have another discussion about the flag anyways.

@afritzler @rfranzke Should we disable CPU throttling for our seeds now? Just wondering, because I have seen this recommended many times:

https://github.com/kubernetes/kubernetes/issues/67577
https://github.com/kubernetes/kubernetes/issues/70585
https://github.com/hjacobs/kubernetes-failure-stories -> https://www.youtube.com/watch?v=6sDTB4eV4F8 (from minute 21:20)

This might help with etcd and kube-apiserver ... but this is just a gut feeling. We could try this in dev and compare the latency metrics.

Yes, please.


Fatal error: Uncaught Error: Class "Component"

Fatal error: Uncaught Error: Class "Component" not found in C:\xampp\htdocs\wpnew\b\whatsapp-cloud-api\test.php:49 Stack trace: #0 {main} thrown in C:\xampp\htdocs\wpnew\b\whatsapp-cloud-api\test.php on line 49

Hi,
Please can you show the code of your test.php file? Thanks.

I have fixed this issue, thankyou

How you fixed? I have a similar error


Missing iOS version

Will be developed asap

Now it exists https://github.com/Zeno97/cordova-plugin-jitsi-meet-sdk/commit/2c9e23ce7214997d7c33ba3bcd24724daf2de6b9


Viewer screenshots include the "image copied to clipboard" toast message

On 0.12.0a4 I can no longer get a clean screenshot of the viewer because the screenshot ends up including the message that a screenshot was taken.

It might be related to that a single screenshot produces three identical toast messages and three identical logs.

How are you taking the screenshot? Seems like the command is triplicated

it is. have a fix!


Map - Grouping Marker Clusters

Usually on maps with a lot of entries the labels tend to clutter a lot. Individual labels become hard to hit with the mouse and the map itself hard to see. A few plattforms / plugins already do clustering of markers that are close to each other in map the users see (which depends on zoom level and effective screen-size of the map!). E.g., the new Edenred restaurant-finder does this well.

I talked to @cbusch . She seems to like it.

Here's a plugin for leaflet we could use (example)


Getting eslint errors when using Vue_Starter and Vue_Full_Project

It looks like the eslint config files were not provided...

Yes, .eslintrc file is missing..


Very slow rendering

Steps to reproduce and a minimal demo(Plunker Example)
Load a map with many markers using custom-marker say over 500 stops.
Make custom-marker a background color div.
Try moving the map around and specifically zooming.
VERY SLOW.
Current behavior

SLOW rendering and zooming. There's clearly a severe delay.

Expected/desired behavior

Some smoother action, not sure what the problem is.

Other information

When loading many markers using traditional marker in Google Maps, it can handle hundreds of stops okay.  What's different with custom-marker that makes it perform so bad on Chrome?

I believe that Angular watcher and bindings makes it slower. Try 'no-watcher' for your marker for faster performance.

I need watcher because it is required! I decided to simplify my custom-marker divs and css and load less markers at a time (~300).   It appears this is problem inherent with Firefox, that it can't handle many markers.


Propose to introduce another way of partial import

Would be great to have a similar approach for partial import as in rxjs. So, something like this:
import { R } from 'ramda/core';
import 'ramda/add/operator/map';

R.map(x => x + '!!!'); // etc

import map from 'ramda/src/map'

@CrossEye, thanks for your answer. Problem is, that in such a case, context is not saved - therefore readability gets worse. What I would like to have instead - main R object with methods I need.
So, not map(...) but R.map(...)

import * as R from 'ramda' seems to be the recommended tree-shaking compatible way to import if using R. is desired. Based on a few previous issues. Feel free to correct me if there's a better way

hm. if it's tree-shaking compatible - then it's a perfect solution for me. have to test this :)

@kopach: Any news on this?

@CrossEye haven't had time to test this yet. Will do this weekend and let you know ;)

Ok, tested it. Tree shaking works just fine with import * as R from 'ramda'
Thanks for a help

Sorry for misleading, but after some deeper testing it appears that tree shaking is not working with ramda.  Initially I thought it woks just because webpack for some reason doesn't recognize ramda as independent module during producing statistic file. So, all the alanyzing tools I've tried e.g.: https://webpack.github.io/analyse/ or webpack-bundle-analyzer do not show ramda at all. So, I wrongly assumed that ramda  correctly tree-shaked :(. But after I've checked file size of bundle - it's bigger just as size of ramda :)
I've also tried to import just needed parts import {compose, join, juxt, toUpper, head, tail} from 'ramda'; or use ramda/es - same result all the time. Build always is about 300kB bigger.

This is the same result I have found. I have settled on importing ramda like below:
import clone from 'ramda/es/clone'
The file size and module count increase if I place:
import * as R from 'ramda'
anywhere in the project.

@Andarist: Any suggestions here?

@kopach @JasonSooter would be great if you could check previous discussions about this - here and in another thread starting from this comment. Would be good to have a confirmation if you observe things mentioned in those issues or are you facing something else. Example repo would be really helpful for me to assess what's the exact reason too.
Unfortunately webpack's tree-shaking algorithm is not perfect - using ModuleConcatenationPlugin can help a lot (this is gonna be on by default in webpack@4 but it's very much already usable in webpack@3). Also webpack@4 should help a lot even further as its gonna read sideEffects field from package.json.

@Andarist Well adding the ModuleConcatenationPlugin seems to have done the trick for me. I can alternate between the 2 options I mentioned above and I get the same size and module count.
I used the simple setup located here:

Let me know if there is anything else I can confirm for you.

 The issue is known and the behaviour need to be tweaked in the webpack itself (as mentioned webpack@4 should do a lot better though, thanks to sideEffects field, when it gets released)

@Andarist I agree


sgx-startup.sh problem with bone-debian-8.7-iot-armhf-2017-03-19-4gb image

I'm using the latest Debian image:
bone-debian-8.7-iot-armhf-2017-03-19-4gb image
I followed the instruction from:
http://elinux.org/BeagleBoardDebian#SGX_BeagleBone.2FBeagleBone_Black
to get SGX available.

I installed the latest 4.4 kernel (--bone-kernel --lts-4_4)
I installed GFX_<IP_ADDRESS>.tar.gz .

It seems there's a problem with sgx-startup.sh .
When I reboot the BBB I can't find omaplfb module loaded.

After rebooting I executed the following command:
root@beaglebone:~# lsmod | grep omaplfb
(no result)
root@beaglebone:~# sh /etc/init.d/sgx-startup.sh  start
sgx: Starting PVR
/usr/local/bin/pvrsrvctl: SrvInit failed (already initialized?) (err=129)
root@beaglebone:~# lsmod | grep omaplfb
omaplfb                12142  0
tilcdc                 26645  1 omaplfb
pvrsrvkm              155855  1 omaplfb

now it works.
It seems at boot time it can't start itself.

I can get SGX properly running by disabling startup execution of sgx-startup.sh
chmod -x sgx-startup.sh

and by adding the following lines to rc.local
sleep 5
sh /etc/init.d/sgx-startup.sh  start

without the sleep it doesn't starts.
It probably start too fast at boot time while it should wait for some services to start before...

this really needs to be converted to a systemd startup script, i bet it's waiting for rootfs to load.. ;)

I create a simple service:
[Unit]
  Description=SGX
  [Service]
  ExecStart=/bin/sh /etc/init.d/sgx-startup.sh start
  ExecStop=/bin/sh /etc/init.d/sgx-startup.sh stop
  Restart=on-failure
  RestartSec=10
  User=root
  [Install]
  WantedBy=multi-user.target

but it doesn't load at startup. I get the same error.
If I disable service and run it after login
systemctl start sgx-startup.service

it works...
what should it wait for?

in the unit:
After=local-fs.target

Regards,

Same error.
But I added some log and I get:
modprobe: ERROR: could not insert 'omaplfb': No such device

Could it depend on /dev/fb0 not ready at boot time?

I confirm, when script execute at boot time there isn't /dev/fb0 available.
How can I wait for /dev/fb0 ?

I solved by adding a "while" before modprobe :
while [ ! -e /dev/fb0 ]
do
  echo "wait fb0"
  sleep 1
done
modprobe omaplfb

@LucaVs thanks! merged that (and tested it)

:+1:
Thanks for your work!

I just tried following the instructions here:  http://elinux.org/BeagleBoardDebian#SGX_BeagleBone.2FBeagleBone_Black
When I check for omaplfb using lsmod, I don't see it. However, I do see pvrsrvkm.
lsmod | grep pvrsrvkm
pvrsrvkm		4379100	0

Looking at the startup script, it looks like you also wait for pvrsrvkm.
while [ ! -d  /sys/class/pvr/pvrsrvkm/ ]
 do
 	echo "wait pvrsrvkm"
 	sleep 1
 done

It doesn't look like that path exists on my device, so the startup script gets stuck there.

@tderensis probally didn't install teh bone kernel:
http://elinux.org/BeagleBoardDebian#Mainline_.284.4.x_lts.29
Regards

Ah, I didn't realize I needed the bone kernel. I currently am using:
Linux beaglebone 4.4.52-ti-r92 #1 SMP Sat Mar 11 01:40:33 UTC 2017 armv7l GNU/Linux

What are the differences between these kernels? I am currently using the Beaglebone Green Wireless and using sleep modes along with an RGB display. Does that kernel still support these features?

@tderensis the 4.4.x-ti kernel has the new SGX driver stack.  It's EGL only, FBDEV got removed. to use it:
sudo apt install ti-sgx-ti335x-modules-`uname -r`
sudo depmod -a `uname -r`
sudo update-initramfs -uk `uname -r`

then this userspace:

git clone -b ti-img-sgx/1.14.3699939 git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git --depth=1

cd omap5-sgx-ddk-um-linux/

sudo su
export DISCIMAGE=/
export TARGET_PRODUCT=ti335x
make install
exit

#fix: libgbm.so.2 (one line:)
sudo ln -s /usr/lib/arm-linux-gnueabihf/libgbm.so.1 /usr/lib/arm-linux-gnueabihf/libgbm.so.2

sudo modprobe pvrsrvkm
sudo /usr/bin/pvrsrvctl --start --no-module

and that's as far as i've gotten.. your on your own.

These steps worked to get the pvrsrvkm module installed and the pvrsrvctl program starts. If the new SGX driver stack only supports EGL, then should I be using weston if I want accelerated video using EGL? Or should I be able to use lxqt?
I tried weston, but it fails to start unless I run it with --use-pixman.

I tried the same way that @LucaVs tried (following this) but the module fails to load on boot. The log output doesn't show much:
Apr 21 15:24:33 beaglebone systemd[1]: Starting LSB: Start daemon at boot time...
Apr 21 15:24:33 beaglebone sgx-startup.sh[716]: sgx: Starting PVR
Apr 21 15:24:34 beaglebone sgx-startup.sh[716]: /usr/local/bin/pvrsrvctl: SrvInit failed (already initialized?) (err=4)
Apr 21 15:24:35 beaglebone systemd[1]: sgx-startup.service: Control process exited, code=exited status=1
Apr 21 15:24:35 beaglebone systemd[1]: Failed to start LSB: Start daemon at boot time.
Apr 21 15:24:35 beaglebone systemd[1]: sgx-startup.service: Unit entered failed state.
Apr 21 15:24:35 beaglebone systemd[1]: sgx-startup.service: Failed with result 'exit-code'.

Starting it afterwards also does not work either. At that point the kernel starts spewing messages. One small difference I noticed is that my GFX that I created is named differently: GFX_<IP_ADDRESS>_es8.x.tar.gz. Also running the update_kernel script automatically installs ti-sgx-es8-modules-4.4.61-bone17. I believe this is needed, but I am not entirely sure.


Session is NULL Memcached

I ahve just installed Memcached and used tutorial to set up the server.
This is my push-server.php
<?php
use Ratchet\Session\SessionProvider;
use Symfony\Component\HttpFoundation\Session\Storage\Handler;

    require dirname(__DIR__) . '/vendor/autoload.php';

    $loop   = React\EventLoop\Factory::create();
    $pusher = new MyApp\Pusher;

	$memcached = new Memcached;
    $memcached->addServer('localhost', 11211);

    // Listen for the web server to make a ZeroMQ push after an ajax request
    $context = new React\ZMQ\Context($loop);
    $pull = $context->getSocket(ZMQ::SOCKET_PULL);
    $pull->bind('tcp://<IP_ADDRESS>:5555'); // Binding to <IP_ADDRESS> means the only client that can connect is itself
    $pull->on('message', array($pusher, 'onBlogEntry'));

    // Set up our WebSocket server for clients wanting real-time updates
    $webSock = new React\Socket\Server('<IP_ADDRESS>:8080', $loop); // Binding to <IP_ADDRESS> means remotes can connect
    $webServer = new Ratchet\Server\IoServer(
        new Ratchet\Http\HttpServer(
        	new Ratchet\Session\SessionProvider(
            	new Ratchet\WebSocket\WsServer(
	                new Ratchet\Wamp\WampServer(
	                    $pusher
	                )
				),new Handler\MemcachedSessionHandler($memcached)
            )
        ),
        $webSock
    );

    $loop->run();

And onOpen function:
public function onOpen(ConnectionInterface $conn) {
    	$this->clients->attach($conn);
		$this->users[$conn->resourceId] = $conn;

		var_dump($conn->Session->all());

        echo "New connection! ({$conn->resourceId})\n";

    }

Var dump response:
array(0) {
}
New connection! (62)
Is it something I did not set up right?
EDIT:
var_dump for $conn->httpRequest->getHeader('cookie'); return:
array(1) {   [0]=>   string(376) "_ga=GA1.2.1243927159.1515344807; _at_id.eig.eigorem.5517=9cc380a97448ae97.1515344809.1.1515344809.15153448<IP_ADDRESS>H; addshoppers.com=2%7C1%3A0%7C10%3A1515344811%7C15%3Aaddshoppers.com%7C44%3AZDcwNmViZGMxMGQ1NDM4OWFiOTllOGM3YzA5MWZmYjI%3D%7Ca78ac69b89c6626730b88e9b11a0488e6f4204c8a98bf3ae260c973e5be7bb3e; timezone=Europe/Helsinki; ci_session=0g3912q6d4q2go4hme61b0otde12po3q" }
I need this to send message to a particular user. I want to add database user ID to connection.

I moved everything on symfony. Now I save session in database. Everything is working great, I am using wss too and is working. The single problem that I have is the following:
[26-Feb-2018 10:02:06 UTC] PHP Warning:  Error while sending QUERY packet. PID=22198 in /home/penguiw0/public_html/evadastudio/vendor/symfony/http-foundation/Session/Storage/Handler/PdoSessionHandler.php on line 523
I noticed the error show up when the browser is open and the PC enter in sleep mode, then when I try to change anything on website the above error come out. Is there something I can do?
Thank you!

This sounds a lot like an issue I was having, so I figured I'd share my issue here in case someone needs it. I was getting an empty array but PHPSESSID was set correctly as OP describes.
Turns out Symfony will only read $_SESSION variables that are inside the _sf2_attributes key. I haven't used Symfony before this, and the codebase I'm using Ratchet with doesn't use it, so for compatibility I had to duplicate the necessary session data inside that array. Unless I missed it this isn't documented on Ratchet's website, I had to read Symfony's source to find it out (as I was lacking the correct search terms).

Thank you. I solved the problem with session after I saved the session in database. Now I try to figure out why in some cases the server stops.
How to behave:
I have website and connection open. Then, if the laptop enter in sleep mode -> re-open the laptop and try to make any change on website in error_log appear the following error:
[26-Feb-2018 10:02:06 UTC] PHP Warning: Error while sending QUERY packet. PID=22198 in /home/penguiw0/public_html/evadastudio/vendor/symfony/http-foundation/Session/Storage/Handler/PdoSessionHandler.php on line 523
If the laptop stay in sleep mode for instance 1 minute everything is still working. But when it stay in sleep mode more then half an hour I guess the error show up. Any advice?


add validation test

Summary

Checklist

[ ] All definitions are documented with Haddock-style comments.
[ ] All exported definitions have @since annotations.
[ ] Code is formatted in line with the existing code.
[ ] The changelog has been updated.

Sorry, I posted this PR to a wrong destination :/


Updated to flags-icon-css 3.1.0

copied all flags from 3.1.0 incl. new ones
copied and adapted scss files
updated versions to 3.1.0

@gr8bit Thank you 👍

My pleasure! :) Could you push it to rubygems please?

Done 😄


Information about Supplementary_Table2_datasetsQC.xlsx

Good morning,
I'm a student in Computer Science at Università degli Studi di Milano and for my thesis I am assessing some pipeline for the analysis of SARS-CoV-2 samples.
In order to select the best pipeline for our requirements, I'm using the benchmark datasets available here.
I found the Supplementary_table2 in your paper (Xiaoli L, Hagey JV, Park DJ, Gulvik CA, Young EL, Alikhan N-F, Lawsin A, Hassell N, Knipe K, Oakeson KF, Retchless AC, Shakya M, Lo C-C, Chain P, Page AJ, Metcalf BJ, Su M, Rowell J, Vidyaprakash E, Paden CR, Huang AD, Roellig D, Patel K, Winglee K, Weigand MR, Katz LS. 2022. Benchmark datasets for SARS-CoV-2 surveillance bioinformatics. PeerJ 10:e13821 http://doi.org/10.7717/peerj.13821) and I would like to use also the data contained there for evaluations (and not only the file in.tsv available for every dataset).
I'm writing here because I can't understand how the column 'Total reads' is calculated. In particular, I used FastQC (the value of the field 'Total Sequences') to compute this value and I also counted the reads in the original .FASTQ file but the numbers don't correspond to the ones published in the Supplementary_table2.
Do you know why the numbers are different? Is it possible that Supplementary_table2 is outdated with respect to the current version of the dataset?
If this is the case, which version of the dataset is matched to Supplementary_table2 and used in your paper?
Thank you very much for your time :)
Best regards,
Sara Manfredi

Hi thank you for identifying this discrepancy. Although I can't promise to fix this right now, it might be helpful to post here some values you are finding in FastQC vs what you are seeing in the supplementary. Thank you for your help.

Hi,
thank you for the response.
In the attached file, I compared the total reads reported in the supplementary table 2 and the value found by the tool FastQC (version 0.11.8).
Note that:

In the file there are the results for the benchmark “CoronaHiT-rapid” for the Illumina sequences
Even if we take the values reported by FastQC for the raw samples (before the trimming) the values reported in the Supplementary table 2 are always bigger

Thank you for the attention,
Sara
Total-reads_Supplementary-table2_VS_FastQC.xlsx


Can't Move After Respawning

We could not move after we respawn or sometimes when we join. We are using an emotes mod and MoreCompany, I am not sure if that is causing the issue or not but we also tested it with LateGameUpgrades disabled and didn't have the issue.

Repeat of issue #165


Update the dialog's title 'Connect to Cosmos DB' to 'Connect to Cosmos DB Emulator'

Storage Explorer Version: 1.8.0_20190417.7
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Regression From: Previous release 1.7.0
Steps to reproduce:

Right click 'Cosmos DB Account(Preview)' -> Select 'Connect to Cosmos DB Emulator...'.
Check the dialog's title.

Expect Experience:
The dialog's title shows 'Connect to Cosmos DB Emulator'
Actual Experience:
The dialog shows 'Connect to Cosmos DB'

This is by design.


Ctrl + Enter does not execute the query on Mac

Hey @tconbeer, very cool and useful project.
Running this is a MacOS default terminal, all commands work except Run Query.
I tried all combinations (cmd + enter, ctrl + enter), but it results in a new line.
Any thoughts on what could be the issue?

As a workaround, could you try ctrl+j and cmd+j?
I don't have access to a Mac -- if you could do me a favor, could you install the textual dev tools and run the keys app?
$ pip install textual[dev]
$ textual keys

Then while running that app, can you press ctrl+enter and cmd+enter and paste the output into this issue?

Thanks for looking into it! ctrl+j works just fine, which is good enough I guess.
Strangely enough, both ctrl+enter and cmd+enter show the below output in textual.

Let me know if I can help with any additional info.

I'm seeing this same issue in Ubuntu. Control+Enter does not work, but Control+j does.
I've tried this with both the default Ubuntu terminal as well as my primary terminal, Guake.

Other than making ctrl+j better documented, is there a key combination either of you would think is more intuitive for submit? (I could also add a button)

I reckon adding a submit button would be good regardless of whether another key combination is added. Would make it generally more accessible and folks would at least have that option if they've missed the documentation.
As for other combinations, how about control+space? that looks to have a different key code than space on its own in my terminal emulator.

+1 for a button, since the UI already supports mouse clicks.

Same issue here

I'm using kitty terminal and having this issue. Did y'all figure out why ctrl+enter doesn't work? It would be nice to be able to use ctrl+enter to execute queries. I've tried keymapping option+enter as well, unsuccessfully.


Update README.md

Added Instruction to provide smooth scrolling on touch devices

minor typo fix

closed for age


MobX - Please be aware of this before using

Hey all
MobX does some componentWillMount observability bindings that don't play nicely with the current architecture of this starter kit.  For now I recommend against using MobX until I can investigate this further.
💖

Update
We have a solution, detailed below and implemented in the mobx branch. x

Please read #409

@birkir 👆

Hey @birkir and @xiao-hu
I have updated the feature/mobx branch (I deleted feature/mobx@next) with the latest release of react-async-bootstrapper which allows you to set if you would like componentWillUnmount to run.  I have only set it to run on the client side bootstrapping but you could experiment with it on the server side too.
Let me know what your experience is like. Thanks!

@ctrlplusb what a man. I tried it out and it worked great after I fixed a little bug in passing the options to recursive function. I added a PR for it.
I really appreciate your effort in solving the issue with mobx.

Radness! Have you had luck rehydrating state from server to client?

Version 2.1.1 of react-tree-walker released. :)

Awesome stuff! About re-hydration, I usually use a single domain store (that contains other stores like UI, User, Items, etc.) that I rehydrate from the server, components then inject the store and I get kind of valid rehydration.
However I sometimes use mobx within a component for state management and haven't got them to re-hydrate (yet...) 👍
But hey, great work Sean.

@ctrlplusb @birkir I know I can count on you guys. Preparing migration for my production to version 13 I guess.

@ctrlplusb @birkir i have bad message for you guys, this error still happened in feature/mobx branch. Exactly after you refresh on Counter page then click increment/decrement button.

@diondirza can you check your node modules and ensure 2.1.1 is there?

@ctrlplusb just found pulled react-tree-walker in node_modules still 2.1.0 sean, probably you use exact version on its dependency.

run a yarn upgrade for now though 😊

The problem caused by yarn.lock file here. Now it works fine. gr8

Anyways, I make a little experiment here. Try to call  counter.inc function in componentWillMount, the server rendered result different with client rendered result

Executed 2 times in server and 2 times in client, so I guess for now better using componentDidMount event to have same value both client and server.

@diondirza if you are going to do state modification on server you need to send that state back to the client somehow so that it can use it to start with.  I know how to do this with redux, but have no mobx experience.

Actually my concern is not maintain modified state to have same value both client and server. Instead I usually set flag in my store on componentWillMount and that flag has side-effect to do ajax call to fetch some data. Probably need to re-tweak some of my code for this changes.

Yeah, you could try use the asyncBootstrap function that is powered by react-async-bootstrapper for this type of thing. Any component that has this will have it executed during the bootstrap phase.  Just return a promise that only resolves after your ajax is complete and you have updated your mobx state. 👍

Cool, just look at it's README, gonna continue to try it tomorrow. It's pretty late here. Anyway good job guys.

@ctrlplusb, I upgraded to the lastest version of react-async-bootstrapper and added {componentWillUnmount: true} to the function asyncBootstrapper. It worked great!!!

Worked for me too


[hw] Fix some minor MDX formatting issues

Summary

Some issues with the rendered document format have been fixed.
Tests

Manually tested with VSCode MarkDown viewer.
cc:

@dy46 @wangxiaoyou1993

@dy46 please take a look at a few minor doc changes, thanks.

@wangxiaoyou1993 please take a look at this PR and see if it is safe to merge, thanks.