Update twitch.py

f

Hello o/
I'm not entirely sure what I'm looking at. Changing that condition result has no real sense, as it'd make the miner try watching channels that are offline. Offline channels can't progress any drops, nor can give you channel points, so this is an invalid PR.
If you've wanted to PR something else, please just make a new PR instead.


Unify output filenames fixes  #45

now creates default LFS filename without ":" and timeformat and integer/float like for firmware builds

Haven't tested myself but the code looks sane. Thanks 🙇 👏


Outdated crate documentation

Hi! The Setting the program entry point documentation in the Advanced usage section still documents the old entry! macro, not the newer #[entry] attribute.

Oh nevermind, I just looked at the source and noticed be98673a6d30d47055f320427b21a47561d59fe6.


Contradictory naming convention

The Cobalt wiki recommends the abbreviation "asp" for App Service Plan.
https://github.com/microsoft/cobalt/wiki/Azure-Services-Naming-Convention#resource-type-abbreviations
However the Cloud Adaption Framework recommends the name prefix "plan-" for App Service Plan.
https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/naming-and-tagging#compute-and-web

I have found the same issue in another Azure Resource: Application Insights
This Cobalt wiki suggests "ai",
but Microsoft´s Cloud Adaption Framework suggests "appi".
Naturally and probably there are more incongruencies...
Any update on this? This seems so simple to solve and important.
Both sources (Cobalt and Cloud Adaption Framework) are under Microsoft's name, so they are causing confusion.
Here goes my solution suggestion:
I think the Cloud Adaption Framework seems more like an official documentation for these abbreviations suggestions,
so maybe this Cobalt wiki should at least inform that:
".... Although this project uses its own abbreviations convention, there is another option too, listed in Microsoft´s Cloud Adaption Framework"


Trouble setting example for my own flutter plugin in pub.dartlang.org

In the example tab it shows the README.md inside the example folder.

How should I redirect it to my main.dart?
Thanks in advance! loving Flutter so much.

https://github.com/dart-lang/pub-dartlang-dart/issues/603 Might help.
If it doesn't I suggest to report an issue there.
As far as I know it's quite limited what the Example tab can render currently.


Option to add toc by default at the beginning of rendered content

Hi,
I was wondering if it would be possible to add an option to automatically add the table of contents at the beginning of the content. This would be nice instead of manually adding it to the beginning of everything you render.
Thanks!

I believe that pre-processing the markdown content with a HOC seems to be a better way to achieve this. Something like:
function inject_toc_on_top (md) {
  return ['[TOC]','',md].join('\n')
}

let markdown_content = '# Header'
markdownIt.render(inject_toc_on_top (markdown_content))

No reason to address this as an option. Developers have the freedom to decide.


Adjust configs for repository and TS

There were several configs errors and nits. This PR fixes everything to guarantee consistency across the repo structure and packages.

see #258


V0.6.2 play2.6 2.11

Naive approach trying to solve https://github.com/iheartradio/play-swagger/issues/173

Thanks for your contribution, but obviously we can't merge this in as is, it will stop support 2.12.

Why does the v0.6.2-PLAY2.6 have to be built on scala 2.12 ?
Can't we publish this branch on bintray to fix #173 ?

I am not asking you to upgrade scala 2.12, but I am just curious what prevented you from it?

We have a lot of internal jars and we are still in the process of migrating them.

If it's just a temporary thing, I would just publish your version of scala2.11 jar to an internal maven repo for now. and wait for playswagger to get proper cross-building for play 2.6. now that play 2.6 is on sbt1.0, it may become easier (since sbt 1.0 supports scala 2.11 and scala 2.12)

Ok, thanks.
We have an internal maven, this branch is working fine for me.
I was more thinking about other user such as @samupra


removed 2703 + deprecated-2704 #628

Since FF63 you cannot clear cookies by lifetime of days, it is either keep, or clear on shutdown (section 2800), so this pref is now useless. In FF65 they even removed the redundant [SETTING]. Even MOAR reason to remove them.

If you're happy, squash and merge as "Make Cookies Great Again" lulz

I don't see why we should remove 2704 from 9999 because it's good info, was a good option for some people and ESR can still use it.

I removed them (2703 and deprecated-2704) as a pair since they referenced each other.  ESR people should be using user.js v 60.

But they didn't remove the UI setting in 65. I told you in another comment somewhere that they changed it to a checkbox instead of a select field.

Do you mean the one that says "Delete cookies and site data when Firefox is closed"? .. damnit ..  So which one control what is deleted then?

Also, mine is disabled (greyed out) - can you please tell me what causes this

PS: I am really loathe to change 2701 from the current commit. The wording matches what is stated in the UI and I think that's important, and it clarifies a few things - the shit about TP had to go, and the old link re IDB was almost 4 years old. What cookies govern is in the section header.
But by all means lets put 2703 + deprecated-2704 back in, and mention the new [SETTING] for 2703, and in the 2703 description explain how this differs from clearing on shutdown, i.e add a line about this making everything session only stored in a different file. And we better work out what makes it disabled (greyed out)
Feel free to an edit to the commit

fe it makes all cookies (and site data?) session-only which for cookies means they're stored in another file.

So can you please find out if this also means site data. Bit pointless haven't only half the info. Can you also tell me what the "another file" is.

can you please tell me what causes this

lol, you're asking me about your setup? How should I know WTH you're doing? :)
An educated guess would be that it's because you're blocking cookies by default, maybe?

block all cookies (behavior=2) disables the option (delete cookies and site data), but does not change the pref, so you can have it checked or unchecked, enabled or disabled = 4 possible outcomes.
So if all cookies are blocked, what happens to cookies allowed via site exceptions? Do they honor the lifetime pref? If not, then that's discrimination against those who block cookies. If it does, then the UI is a liar (by implying the setting is not enabled). I suspect it the former - in which case the draft 1 2703 needs fixing to say the settings has NO EFFECT and is DISABLED ...if
--
edit

An educated guess would be that it's because you're blocking cookies by default, maybe?
Been re-writting this current post to you for about 10 minutes .. I worked that out half an hour ago and its in the latest edit done approx 15 mins ago

I'm not an expert in all this, but I can see they are trying to split history and site data, and all the items in 2800 will slowly be removed (e.g IDB, cookies, etc), or may indeed not be used with nextgen local storage. i.e, eventually if you want to clear site data you HAVE to clear the cookie

lol, you're asking me about your setup?

I mentioned it, not because I wanted to know, but because if we're going to have items in the user.js then we need to cover all scenarios - that was my point

just waiting for someone to tell me exactly how 2703=0 differs from 2800s sanitizing on close. I know someone mentioned cookies are "session only" (are you sure, session only cookies affected service workers and shared workers, remember) and kept in a different file (are you sure: or are they just tagged as session?) ?? And to confirm if site-data is treated the same?
Meanwhile, I'm doing one more change and pushing it. Sorry, but I'm getting really fed up (at everyone)

Let's not make this too complicated. A lot of this stuff is going to change again soon, fe in 66-devEdition Standard CB as well as Strict CB both use value 4 for this pref and there's a good chance that'll land in Release too.
Here's what I would do:
/* 2701: disable 3rd-party cookies and site-data
 * 0=Accept cookies and site data, 1=Block third-party cookies, 2=Block all cookies,
 * 3=Block cookies from unvisited sites, 4=Block third-party trackers (FF63+)
 * [NOTE] value 4 is tied to the Tracking Protection lists so make sure you have 0424 + 0425 on default values!
 * [NOTE] You can set exceptions under site permissions or use an extension
 * [SETTING] the "Cookie" part under Privacy & Security>Content Blocking
 * [1] https://www.fxsitecompat.com/en-CA/docs/2015/web-storage-indexeddb-cache-api-now-obey-third-party-cookies-preference/ ***/
user_pref("network.cookie.cookieBehavior", 1);

and
/* 2703: set cookie lifetime policy
 * 0=keep until they expire (default), 2=keep until you close Firefox
 * [NOTE] 3=keep for n days : no longer supported in FF63+ (see 2704-deprecated)
 * [SETTING] Privacy & Security>Cookies and Site Data>Delete cookies and site data when Firefox is closed ***/
   // user_pref("network.cookie.lifetimePolicy", 0);

Here's what I would do:

That just looks like what we had before (except the settings info). I've already done a commit.

A lot of this stuff is going to change again soon

I'm just about ready to throw in the towel, it'a always me (and you) that has to fuking do everything. And I spend time working stuff out, simplifying it, making it correct (except for the bits I got wrong such as the setting for 2703 being removed), and then get shot down - thats what it feels like.
 I've already wiped all my test results and pics and stuff in the related issue

You just do what makes sense. The plebs don't deserve my hard work and detailed info. Just make it super simple. I'd do it myself but then I'd get angrier

am totally getting upset and frazzled here man, so much I reverted the 2703 values and said 0=delete

chillax mate, it's all good.
I also feel like you're just way too hellbent on trying to explain everything.
I mean not a lot of people are gonna change the cookie setting anyway and those who do, can probably figure it out for themselves.

It feels like riding all train in stable thru to quantum .. all these NGLS and Content Blocking changes, splittle history from site data, tying all site data thru cookies, putting all cookies thru an urlClassifier for DNT and TP ... I'm feeling swamped

I'm done with 2701 and 2703 ... go look at the master. If you want anything else changed then open a new issue


alttab: 1.4.0 -> 1.5.0

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/sagb/alttab/releases.
meta.description for alttab is: "X11 window switcher designed for minimalistic window managers or standalone X11 session"
meta.homepage for alttab is: "https://github.com/sagb/alttab"
meta.changelog for alttab is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.5.0 with grep in /nix/store/8rx25lvvb4f9ghdl2pvlbibf7mmbj1id-alttab-1.5.0

directory tree listing: https://gist.github.com/04d84bd98d413214ac249758c434d299

du listing: https://gist.github.com/e157c3f2c47444b0820ca3f68860c7ef

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
alttab

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8rx25lvvb4f9ghdl2pvlbibf7mmbj1id-alttab-1.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A alttab https://github.com/r-ryantm/nixpkgs/archive/494fcb0b76c04f4de6a8ac5e70141b61c106598e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8rx25lvvb4f9ghdl2pvlbibf7mmbj1id-alttab-1.5.0
ls -la /nix/store/8rx25lvvb4f9ghdl2pvlbibf7mmbj1id-alttab-1.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

alttab

Maintainer pings
cc @sgraf812 for testing.

Nice!


"Wrong" Release process generates requirement to declare "wrong" parent theme

This might be nitpicking, but, AFAIK and as far I have seen in major other projects, a release should never include the -main suffix in the artefacts to be downloaded.
Since Bootscore parent is released as bootscore-main (see example https://github.com/bootscore/bootscore/releases/tag/v5.3.3), of course the child theme requires a parent theme bootscore-main, which is indeed also correctly coded in the Child Theme CSS file Template:     bootscore-main (see https://github.com/bootscore/bootscore-child/blob/main/style.css).
But, as then it goes with my habit to never have -main in the folder name, and assuming it to be an error in release process, I (and probably others) go and:

download theme
unzip, rename (remove the -main suffix)
re-zip, upload and install

And you get yourself a broken child theme at this point.

I would like to suggest the release process to not include the branch suffix (in this case -main). It is easy enough to ensure during the release process.
I cannot control this, but I can submit a PR to then fix the child theme Template:     bootscore-main
Unfortunately, this will be a breaking change, but the sooner the better, IMO, so to follow (and be example of) "best practices"?
Best practices in "" apostrophes because of course, one can argue on that... it's just that generally, and as far I have seen, releases should really be made for the actual product name without branch information, and your product here is bootscore, not bootscore-main.
Note that AFAIK bootscore has no remote update mechanism, so it would not be a very "impactful" breaking change, and definitely one to consider before thinking about remote update processes (FYI, I maintain a WP plugin that allows users to update from a remote Git Repo without the user of third party libraries, if it is something that interests you I can share the details in another topic).
Are you willing to change this?
If not, of course it is redundant to submit the PR so I am waiting your opinion on this.

Yes, of course. The child-theme is always tied to the folder name of the parent-theme. The child is there to change nothing in the parent theme.
The -main prefix is used to simplify handling for us and address the GitHub cloners as well. Changing this is not only affecting theme and child (breaking leads to v6 and we are nor ready for that yet), it will affect the entire repository with all plugins (they have an auto-updater). Changing folder isn't a small thing and will create a lot of trouble and confusion and I do not see any benefit here. However, what's wrong to keep -main prefix in releases?

FYI, I maintain a WP plugin that allows users to update from a remote Git Repo without the user of third party libraries, if it is something that interests you I can share the details in another topic.

Yes, of course! Plugins uses https://github.com/YahnisElsts/plugin-update-checker for auto updates. If we can skip this library, it would be great.
For the theme, it's still too early to integrate an auto-updater. Therefore, user should decide by himself if they want to update or not. There is also the option left to publish the theme in the WP repository at some point which includes auto updates as well.

I do not understand how the -main could help to differentiate from cloners? They can use -main as well (if what you mean is a "false" bootscore theme being published, I might misunderstand).
I am aware the child theme is dependant on the parent - that is not the concern. The concern really is that having the -main in a release is ... lets say just very uncommon (and can cause issues if you upload that very zip to WP Repo, for example, where they'll expect the actual slug to match)
However, of course, this is a minor issue compared what seems a larger consequence (did not know the plugins also point to -main theme file)
My suggestion would stand to try to "evade" this one now (before an online updater is available at which point it'll become impossible) but on the other hand I understand there's not much win (at least not on the surface) compared to the other things that can improve the theme (or plugins).
The main issue with -main really is that it comes from a branch name on GitHub, not from your product, and that (the repo) might change - the product name, less so. Thus (I think) this is why the bigger repos I have worked with (and from whom I copied practices and approaches, sometimes perhaps too blindly), try to avoid the branch suffix.
I am closing here, since I totally see your point - and I can always do that on my own in any theme built off the bootscore, if I need to
Thanks!

The -main suffix was not part of the theme before but this leads to issues with users who pressed the green Code button in each repo instead downloading a release. In this case the child does not work because theme folder was bootscore-main and child needed folder bootscore instead. After some user reports we decided to include -main suffix to each repos release.
In this post is explained why we changed bootscore to bootscore-main. This article is outdated and many things changed since this post was published. But it clears it up why keeping -main in the folder name is so much easier for us to handle the repos.

FYI, I maintain a WP plugin that allows users to update from a remote Git Repo without the user of third party libraries. if it is something that interests you I can share the details in another topic.

Yes, this is still very interesting. How does it work?

The updater works with GitHub API.
https://github.com/TukuToi/tukutoi-cp-directory-integration
Currently, this plugin is made solely for ClassicPress, so it would of course need to be refactored. All the MUST clauses in the description are likely inapplicable to this repo here since the logic would likely just be for this organisation and none other.
The API Key requirement (once reaching limit) also is likely not a requirement, since you do not have hundreds of repos.
As such, the integration could be made with significantly less code than the referenced plugin, and with a significantly nicer UX (as no GitHub API Key would ever be required).
Please let me know if you consider this, and feel free to open a new task and assign it to me with a description as of how you would like the integration (inside the theme/plugin or as a standalone "updater" plugin)
I am happy to start work on this.
Another solution I implemented is https://github.com/uhleloX/api, this one uses a more "professional" approach in the sense that you actually set up your own server where the releases are hosted, and deliver from there. This project is not a WP Project, but the same logic can work in WP too. This is neater in terms that if you ever decide to leave GitHub, or for whatever reason cannot store on GitHub anymore, you do not need to make changes to the update mech, and also can use the same server for other API handling (who knows maybe you want to substitute the template plugin with an online api instead, so the user can just click a button and download a template, for example)

Quickly installed https://github.com/TukuToi/tukutoi-cp-directory-integration and had rough view to it. If I understand it correct, this plugin manage plugins/themes from GitHub profile in WP backend on main site. If so, this is a good option and we can remove the plugin update checker. But it seems like a lot of work to adapt the plugin to this repo. Are you sure you want to invest the time into this?

Yes, in a nutshell that is pretty much what it does.

But it seems like a lot of work to adapt the plugin to this repo. Are you sure you want to invest the time into this?

I think less to adapt that plugin to this repo and more about just implementing a new one.
The reason is - that plugin, actually, you could already use for this repo!
You just would have to register your org/repo with the plugin and tada, it would start pulling updates.
However, that plugin is NOT a WordPress plugin - it is a ClassicPress plugin. As such alone already it is not ok to use it as-is on a WP Install nor to build on it.
Unless you explicitly want to also support ClassicPress, what I would do is simply start anew with a way less complex plugin.
For your use case you do not need user-interaction (meaning the user does not have to specify the repos they want to sync with)
You do not need integration with the ClassicPress Plugin repository
You also do not need api key handling and the likes.

So, it should not be a too big amount of work, and yes, I would be willing to contribute this. I cannot make guarantees as of time, but I also will make sure to not take years for it 🤣

The question for  me still is, do you want this as a standalone plugin, or as something you could integrate into your existing theme/plugin as a single file (as a class) and then require it somewhere in your code?
The latter approach is easier for the end user - they wont have to add another plugin - but is a bit more tricky (well, not that hard either) just so to avoid conflicts when several of the instances are loaded. I think the include approach is probably neater than using a standalone plugin.

Update:
I also just recalled that WP offered a new plugin header directive for custom update server urls.
I am investigating that too, back when I wrote my plugin that did not yet exist.
Here the main question though is how far back your software supports WP. And, if it is even possible in themes. I believe not. So the custom code solution likely still is the way to go.
Can we have a ticket or so to bundle all the preparations and later work?

Here the main question though is how far back your software supports WP.

bootScore is a WP project

So the custom code solution likely still is the way to go.

To be honest, I'm new to this. As mentioned, plugins uses https://github.com/YahnisElsts/plugin-update-checker so far. Theme not yet because we have to check for potential issues first before providing auto updates. We'll go the way you prefer.

Can we have a ticket or so to bundle all the preparations and later work?

Simply open a new issue, so we can track this in projects

bootScore is a WP project

I know (I think you want to reply to the classic press detail?)
The question here was how many versions back you want to support wp.
Like… minimal required wp version.
min any case - ignore it as it’s not relevant anymore
I’ve the plugin updater class file ready and will share it either later or tomorrow. Then I’ll do the same for the theme.
I’ll let you know through a new ticket or even PR.


Update geocoder docs for collapsible / expanded

Update geocoder docs to better reflect use of collapsible and expanded

Thanks!


Validation failed in API: kind is not a valid option when editing a secret or configMap

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
In a Google Cloud Kubernetes cluster, create a secret containing some information. Here is our gitlab config secret:
Key: GITLAB_OMNIBUS_CONFIG
Content:
external_url 'https://git.mysite.com';
nginx['ssl_certificate'] = '/var/opt/ssl/gitlab/tls.crt';
nginx['ssl_certificate_key'] = '/var/opt/ssl/gitlab/tls.key';
gitlab_rails['registry_enabled'] = true;
registry_external_url 'https://registry.mysite.com';
nginx['redirect_http_to_https'] = true;
registry_nginx['ssl_certificate'] = '/var/opt/ssl/registry/tls.crt';
registry_nginx['ssl_certificate_key'] = '/var/opt/ssl/registry/tls.key';
gitlab_rails['backup_path'] = '/var/opt/backups';
gitlab_rails['backup_upload_remote_directory'] = 'gitlab-backup';
gitlab_rails['backup_upload_connection'] = {'provider' => 'Google', 'google_storage_access_key_id' => 'my-key', 'google_storage_secret_access_key' => 'my-secret'};
prometheus_monitoring['enable'] = false;
gitlab_rails['gitlab_shell_ssh_port'] = 32671;
gitlab_rails['backup_keep_time'] = 604800;
gitlab_rails['monitoring_whitelist'] = ['<IP_ADDRESS>/8', '<IP_ADDRESS>/8'];

Creation works.
Editing this secret afterward then produces the error. The secret is valid and my gitlab instance starts with no problem.
Please note it also produces the error when defining/editing configMap.
Result:
Validation failed in API
Other details that may be helpful:

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):

Rancher | v2.1.6
User Interface | v2.1.19
Helm | v2.10.0-rancher5
Machine | v0.15.0-rancher1-1

Installation option (single install/HA): Single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): GCE
Machine type (cloud/VM/metal) and specifications (CPU/memory): n1-standard-4
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:46:00Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.6-gke.6", GitCommit:"a2fae0aa5d813f814d667711324501312b76e64f", GitTreeState:"clean", BuildDate:"2019-01-18T19:40:57Z", GoVersion:"go1.10.3b4", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version):

Default on v1.11.6-gke.6

I'm experiencing this issue as well with a cloned secret.

Indeed it was a cloned secret in my case too! Good clue.

I can verify seeing this when trying to clone a secret.

This should be fixed in 2.2: https://github.com/rancher/rancher/issues/16219


Update Style/SingleLineMethods to correct to an endless method definition if they are allowed

Follows #9281.
If Style/EndlessMethod is enabled and not using the disallow style, single line methods will be corrected to endless methods instead. My rationale here is that if the user is allowing endless methods, they are a "smaller" correction for single line methods than replacing with a normal method definition.
I went back and forth about if this should be configured independently from the Style/EndlessMethod configuration. I think it makes sense to keep all the configuration for endless methods in one place, but if we'd rather have it specifically configured for Style/SingleLineMethods,  I'd be happy to make that change.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Once #9281 is merged I'll rebase its commit out of this PR, but it's needed to make the tests pass.

@dvandersluis Please, take a moment to rebase this PR when you can.

@dvandersluis Please, take a moment to rebase this PR when you can.

@bbatsov definitely, done!

@bbatsov definitely, done!

Thanks!

Thanks!


abap cleaner also for CDS Entities / Views?

Hey,
the abap cleaner doesn't seem to work inside CDS Entities / Views.
Is this so or do I miss some setting?
Thanks!
Regards,
Vlad

Hi Vlad,
yes, this is so – CDS data definition language is simply not supported by ABAP cleaner.
Kind regards,
Jörg-Michael

Related: #7 😉

Hi @VladGhitulescu,
happy to say that since version 1.19.1, formatting of CDS Views / Data Definition Language is now supported by ABAP cleaner, see Release Notes!
Therefore, changing the label to "new cleanup rule" (it's actually 21 rules for DDL as of now), but keeping it closed – all done! :-) (However, as #7 shows, certainly not running out of ideas for DDL, either; and then, there is also DCL …).
Kind regards,
Jörg-Michael


Change Rollbar docs URL

I updated the docs URL so that it'll always point to the latest version of the JS docs.

Thanks!


Incorporate senzingapi-runtime package

See https://github.com/Senzing/community-roadmap/issues/65
Add
/opt/senzing/g2/resources/schema/g2core-schema-postgresql-create.sql

to Dockerfile.

Fixed via https://github.com/Senzing/postgresql-client/issues/21


Fix wrong indexed map name for SamplingPolicy

https://github.com/petabi/review-database/blob/76a307b7e762e8f62984ad6b41e77a805f046981/src/tables/sampling_policy.rs#L93-L101
@MW-Kim found that a wrong name was given to the SamplingPolicy indexed map, and suggested changing super::NETWORKS  to super::SAMPLING_POLICY in the above code.
And I personally think this might suggest that review-database 0.27.0 ~ 0.31.0 needs to be yanked.

And I personally think this might suggest that review-database 0.27.0 ~ 0.31.0 needs to be yanked.

These haven't been deployed and won’t be either, so I don’t think yanking them is necessary.


using namespace std in InertialSense.h

Hi, the InertialSense.h header has using namespace std directive which causes a lot of collisions when included in a larger code base. It is not a good practice to globally publish namespaces, would it be possible to get rid of it?

We should be able accommodate this change.

Great! Also, a namespace wrapping the whole InertialSense library would be great to avoid collisions, but we can live without it. :-)

Thank you for fixing in 1.8.7!


Memory Leak

Here, we observe a simple Slack Bot before calling Kuroshiro:

And here we observe a simple Slack Bot after calling Kuroshiro:

You can see my usage here. Any answers for why this may be happening, or how to fix this?

Hi, kurisubrooks. Thanks for the feedback. I've checked this issue. It seems like the memory was taken by the initiation of kuromoji. Kuromoji initiates its tokenizer by extracting dictionary files to objects and mappings which may occupy quite a lot of memory. You could check the memory usage of kuromoji.js, and about 200MB or more memory will be taken by initiating process. And I also work on finding out if there is a memory leak.


moderated team2 labels(195 diff labels)

Total batches in team1 = 1500
Total Labeled files by annotator1 (madhav) = 856
Total Labeled files by annotator2 (aditi) = 610
Total common files = 360
Total files with different labels = 195
Total labeled by moderator (suraj) = 195
Total pending = 0

@jaiswalsuraj487 Can you check why the files changed are only 112, but you have moderated 195 files? Feel free to suggest improvements to the moderator app to fix this.


User to use for ssh would be good to document

Since for on premises installs some users change to ubuntu I was unsure which user to use to login. I would be good to document that. New users and "seasoned" users like myself would find it helpful I think.
For AWS users to use when I looked it up found this, but I realize any could be used:
https://alestic.com/2014/01/ec2-ssh-username/
This made reference to use ubuntu or root for Ubuntu, but did not think to use vcap although had used that previously.

Hey @hhercules
Sorry for the delay.  vcap is the standard user for all BOSH installs, I've never seen anyone change this.  It's definitely good for users to know what user to SSH with, but I don't want this repository to be in the business of duplicating all the BOSH documentation.  Were you trying to SSH into the BOSH director itself, or some VM deployed with BOSH?
Amit

I suppose I got this confused with ops manager and how it went from tempest to ubuntu. Thanks.


Add more context to Unknown Chain error

Motivation
While debugging the GraphQL tests inside the fungible README I had this error pop up for me, but it had no context.
Proposal
I think it's good to know what chain is the unknown chain, so adding that context to the error
Test Plan
CI

#1757  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite


Fix race condition in version slug generation

The previous use of select_for_update fell out of scope too quickly and caused the lock on the database to be removed too quickly. This potentially allowed a race condition if, for example, a user hit the "Create new version" button too many times and the queries were evaluated at the same time. It is possible that this caused the duplicate slug issue that we've observed before, in some cases.

I am not sure how this would be hit by a user, but it seems like a fine change.

It seems unlikely to hit, but it was the only thing I could think of that might cause the duplicate slugs we've seen before.


Support for Python 2.7

Even though Python 2.7 is out of service there are many projects that still have a need to support it.
Taking that away in an important project like coveralls is no good idea. Particularly since it does not solve any problem within coveralls.
I have a PR https://github.com/andy-maier/coveralls-python/pull/1 on top of the master branch of this repo that brings back support for Python 2.7, and its GitHub Actions testcases succeed. The changes were really minimal. We have succesfully used that branch on Python 2.7 in a Github Actions based project (see https://github.com/pywbem/nocasedict/pull/68).
Please let me know whether you are willing to reintroduce support for Python 2.7 into this project. If that is not the case, no problem, then I will consider releasing a 2.7 backport version of coveralls to Pypi. I'm sorry but we simply need that support.
PS: As an alternative, I looked at the old python-coveralls as an alternative, but besides not being maintained anymore as it seems, it is behind coveralls-python in its support for CI systems, and does not combine reports with coveralls-python when running on GitHub Actions. So it is not a viable alternative for us.

I thought I should explain why we are not using coveralls 1.x, and the main reason is that it does not combine reports with coverage 2.x reports, at least not on GitHub Actions. I would have no problem using coveralls 1.x on Python 2.7 (pinning it to <2.0), if it would support combining reports with coveralls 2.x. That would require at least a change in the service ID area of 1.x, but maybe more (I did not dig to the ground of it).

@andy-maier Though I understand that many projects may still use Python 2.7, I am not willing to commit to support for it. Though you are correct that getting a base-line level of support isn't too much effort, there's a whole slew of edge-cases and bugs which we originally had to account for when we were maintaining support (relatedly, you may find the commit where we removed support for py27 useful, as there are a few more edge-cases you may wish to account for). Being able to drop support in accordance with Python's official EOL policies has made maintenance significantly easier.
I would indeed be willing to backport the fix you mentioned to the 1.x branch, if that could make things easier! You can make branch of the 1.x branch for this.

I thought I should explain why we are not using coveralls 1.x on Python 2.7, and the main reason is that it does not combine reports with coverage 2.x reports, at least not on GitHub Actions. I would have no problem using coveralls 1.x on Python 2.7 (pinning it to <2.0), if it would support combining reports with coveralls 2.x.

That was the only frustration after migrating from Travis to Github Actions,  @andy-maier patch works great. It's nice to have the option. The only other options is to simply not do coverage for <3.5. I would like to see the option available on this repo, but limited to the occasional bug patch contribution and no new FRs.

I thought I should explain why we are not using coveralls 1.x on Python 2.7, and the main reason is that it does not combine reports with coverage 2.x reports, at least not on GitHub Actions. I would have no problem using coveralls 1.x on Python 2.7 (pinning it to <2.0), if it would support combining reports with coveralls 2.x.

That was the only frustration after migrating from Travis to Github Actions,  @andy-maier patch works great. It's nice to have the option. The only other options is to simply not do coverage for <3.5. I would like to see the option available on this repo, but limited to the occasional bug patch contribution and no new FRs.

I'm also willing to help maintain a branch that supports python 2.7 and pythons < 3.5 (I actually need to support 2.6 for the next 3 years, let alone 2.7, so this is something I'll need for a long time)
currently, if I want correct compare to master branch I need to use coveralls-python 1.11.1 everywhere, which feels quite silly

I'm also willing to help maintain a branch that supports python 2.7 and pythons < 3.5 (I actually need to support 2.6 for the next 3 years, let alone 2.7, so this is something I'll need for a long time)
currently, if I want correct compare to master branch I need to use coveralls-python 1.11.1 everywhere, which feels quite silly

I was able to build on work of @andy-maier, and make that branch work on python 2.6 and 3.3 too!
The code is here (but I don't guarantee it will remain there)
And I've tested it in production here: https://github.com/tlsfuzzer/tlslite-ng/pull/458
and in the resulting merge action here: https://github.com/tlsfuzzer/tlslite-ng/actions/runs/503761385
for both runs coveralls correctly merged coverage between py2.6 and py3.9 (and all in between) and provided a correct summary coverage and change percentage of it, all while using the github token and "github" service name
so, @TheKevJames I don't think it would be too hard to keep the coveralls-python working on even the oldest pythons that still have commercial support, question is, would you prefer this to happen on master branch or on a 2.x branch?
I'm also willing to use pre-release versions of coveralls-python to make sure that those old versions don't get dropped accidentally; if you don't want to keep the CI running for those old pythons (I know very well how much effort it takes)

I was able to build on work of @andy-maier, and make that branch work on python 2.6 and 3.3 too!
The code is here (but I don't guarantee it will remain there)
And I've tested it in production here: https://github.com/tlsfuzzer/tlslite-ng/pull/458
and in the resulting merge action here: https://github.com/tlsfuzzer/tlslite-ng/actions/runs/503761385
for both runs coveralls correctly merged coverage between py2.6 and py3.9 (and all in between) and provided a correct summary coverage and change percentage of it, all while using the github token and "github" service name
so, @TheKevJames I don't think it would be too hard to keep the coveralls-python working on even the oldest pythons that still have commercial support, question is, would you prefer this to happen on master branch or on a 2.x branch?
I'm also willing to use pre-release versions of coveralls-python to make sure that those old versions don't get dropped accidentally; if you don't want to keep the CI running for those old pythons (I know very well how much effort it takes)

Hey folks, sorry for the leave on this one. I will be supporting any Python versions which are not end-of-life according to the official source, but not including support for older versions. For older versions, I am willing to cherry-pick backport fixes as need be to the older branches such as v1.x if they are provided to me, but will be not doing such dev work myself. Please feel free to submit patches as needed for this (or, of course, continue using the above forks!)
See https://github.com/TheKevJames/coveralls-python/issues/393#issuecomment-2079551748 for more context.


Release 6.26.0_arenadata54

This release is a hot-fix. What is why the patches below will be cherry-picked to be merged directly to adb-6.x. A patch 765974d34e5b6222ea9f2051e6965e5d8501bf66 for ABI tests will be merged from adb-6.x-dev  later.
Fixes:

#646
#676

Allure report https://allure-ee.adsw.io/launch/64906

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1083224

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1083225


latent_std in projector.py

Hi,
I have a question about latent_std,
As specified in the paper, StyleGAN2 computes the average square Euclidean distance to the center and adds stochasticity as below

in the Line 157 of projector.py : latent_std = ((latent_out - latent_mean).pow(2).sum() / n_mean_latent) ** 0.5
But I wonder why latent_std should be a scalar, but not a vector with dimension of 512?
I think latent_std in the form of 512 dimension vector will consider the factors of variation in latent code much better
Thanks, Lee

As differences are determined by random variations, if you set scale for each dimensions differently, then deviations in some directions could be relative large, and rest are could be small. I don't think it would be better for exploring latent dimensions. But it is the only guess, you can try and test the differences.


doc: clarify the special @EACH macro behaviour in SELECT

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Getting form data

i am trying to use
$form -> saving( function(Form $form){
}};

Is there any way to get the input array from the form?
Is there anyway way to modify/set an input to the  $form, because I have some form fields that doesn't have a column in the database. I know i can use ignore, but I need those ignored fields to formulate a value for another field.
It seems ignoring a field will remove it from $form -> input, how do you get the value of that ignored field?

Input:all();

I have the same problem,  can try this
$form->saving(function (Form $form) {
    dd(request()->all());
});


Add MonoidAggregator combinators

this some code we have been using at Stripe written by @non and myself.
We should support probably non-monoid (that is Semigroup based Aggregator) as well, although we try to use MonoidAggregator primarily at Stripe.
cc @erik-stripe

it looks like internally Parallel.oneOf and ApplicativeAggregators are the only ones we actually use, which maybe makes sense. Maybe we can only do those two for semigroups and maybe even remove the others from the PR in the interest of keeping things simpler...

Codecov Report

Merging #659 into develop will increase coverage by 0.11%.
The diff coverage is 95.76%.

@@             Coverage Diff             @@
##           develop     #659      +/-   ##
===========================================
+ Coverage    89.44%   89.55%   +0.11%
===========================================
  Files          113      118       +5
  Lines         8945     9078     +133
  Branches       490      491       +1
===========================================
+ Hits          8001     8130     +129
- Misses         944      948       +4

Impacted Files
Coverage Δ

...tter/algebird/generic/ApplicativeAggregators.scala
100% <100%> (ø)

...twitter/algebird/generic/CombinedAggregators.scala
100% <100%> (ø)

.../twitter/algebird/generic/CinchedAggregators.scala
90% <90%> (ø)

...twitter/algebird/generic/ParallelAggregators.scala
96.66% <96.66%> (ø)

...m/twitter/algebird/generic/JoinedAggregators.scala
96.66% <96.66%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45e654...69f72ab. Read the comment docs.

Good point! We also have kryo serializers for HLists (easy to do, but a good idea to add).
We don’t customize our kryo serializers internally as far as I know (much less spark than scalding) but we did set up for scalding.

@johnynek can we get this merged? Would love to use it at my work

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


get categories

count categories and get those data, self.loop=counts

has decide not to use the categories like this. I will add them in an array instead


[LIT] Fix lit copying path.

This commit changes directory which used to copy llvm-lit binary.

Waiting for https://github.com/intel/graph-compiler/actions/runs/9002613715 it breaks all builds at the current moment.

suppressed by #46


Add gzip size

thanks! :)

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

Done! @yahoocla


add setuptools, add mukhery as maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Resolves #72 and the issue with missing setuptools.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11959706289. Examine the logs at this URL for more detail.

@conda-forge-admin, please rerender

@conda-forge/core can you please merge this so that I can help maintain this repo?

@conda-forge/core could you please merge this?

Please wait a week before contacting core.

Let's give the current maintainers some time to review this. Core typically doesn't jump in unless there is no response after a week. Also, please address the linter's requests if you're making updates.

Ok - sorry, I missed that one. Once the linter commit passes, I'm happy to merge this.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

It looks like safetensors is only built for a minimum of python 3.8 for its oldest version on conda-forge and 3.9 for its latest version. Our global python_min is 3.9, so it's probably best to use that

It looks like safetensors is only built for a minimum of python 3.8 for its oldest version on conda-forge and 3.9 for its latest version. Our global python_min is 3.9, so it's probably best to use that

Thanks for the assistance!


dracula theme

I'm not sure how easy it is to target the same tokens as VSCode since this uses a completely different syntax highlighting library, but I wanted to post a comparison since I noticed a few differences:
Dracula Official for VSCode

Dracula from this PR

i don't think that this theme will be able to match 100% up to what it looks like in vscode, but i can try to see if i can do something about some of the differences

i think this is the closest i can get with the tokens prismjs has

I'm going to merge this into another branch and see if I can make some tweaks to the code that actually applies the theme rules. I'm noticing some bugs right now and I'd like to fix them before getting this in.


Do you update CDN code?

Does the releases include changes to the CDN code?

I am self-hosting. I have a way to auto-update every 24 hours from remote to local.


Add inputs.args parameter

I added inputs.args parameter to pass arbitrary options for octocov.
https://github.com/k1LoW/octocov/issues/406
There are other ways, for example adding inputs.report-path option, however octocov has many options and subcommands so inputs.args is useful I think.

@lufia Thank you!!!


Update README.md

based on https://lilac-oriole-6ab.notion.site/README-8c4725fd09164aef8afb252f1e9522ba


Example of Sugar with create-react-app

With the popularity of React (and create-react-app) these days, it would be great to see some examples of Sugar using it with webpack, es6 imports, etc.

Awesome idea... will work on this soon!

Thanks for the quick response here, Andrew! If you wouldn't mind giving a basic example even just in the comments here, I'd be happy to fill in implementation details. Minimally this thread should surface when people start searching for React with Sugar.
Something like this?
npm install sugar
import Sugar from "sugar";
Sugar.Date.create('next Friday');  //wishful thinking..this doesn't seem to work

Btw, I just several js date parsing libs. Sugar's appears to be the best. Great work and thank you for building this!

Here's a workaround in the meantime that plays nicely with Create React App:
Include the Sugar lib in your index.html
<script src="https://cdnjs.cloudflare.com/ajax/libs/sugar/2.0.4/sugar.min.js"></script>

Then, inside of Create React App, reference Sugar from the global, window object.
window.Sugar.Date.create('next Friday');

Sorry for taking ages on this. The next major version of Sugar will be a complete refactor of the skeleton from the ground up to use ES6 imports. For now import * as Sugar from 'sugar' should work for you... let me know if it doesn't.

Is there updated docs on how to use Sugar dates with React?


Decide on official start/end times for the sprint

From the signups so far, the most popular timezones people are working from are:

UTC-7 (5 signups)
UTC-4 (4 signups)
UTC+2 (4 signups)

Based on that, we decided to have a live kickoff meeting on Monday 4 PM UTC (9 AM Pacific), and a sendoff on Friday 4 PM UTC (9 AM Pacific).
The meetings will be recorded for those unable to make it, and will be posted on PSF's YouTube Channel.

I've posted the schedule here: https://python-core-sprint-2020.readthedocs.io/schedule.html


Add API to get fallback locale from a key and 'global'

At the moment, it isn't possible to get the fallback locale for a key in the case that it isn't localised in the current locale.
This would be needed to be able to do things like localise numbers correctly. Eg The game is using 'ar-EG' but the key is falling back to 'en-US'. In which case, we should using English numerals (0-9) as the text would be in English and potentially using a font that won't have Arabic numerals.
'global' is in the case where just the number is shown and therefore we should be able to check if a localisation exists at all for that locale.

This has been implemented in https://github.com/playcanvas/engine/pull/3245#pullrequestreview-697048958


Zero-sized LCellOwner APIs?

Currently, LCellOwner is zero-sized, but &LCellOwner and &mut LCellOwner are not. We wonder if it's possible to have a sound API which borrows the LCellOwner but is zero-sized?
This is a bit of a micro-optimization but anyway.

so like what if we had LCellOwnerRef<'a, 'id> and LCellOwnerMut<'a, 'id> which are just wrappers around PhantomData<&'a LCellOwner<'id>> and PhantomData<&'a mut LCellOwner<'id>> respectively, and then had LCellOwner.borrow() and LCellOwner.borrow_mut()?

Those API calls are #[inline] so the &LCellOwner should optimise away completely, since it is unused within the function. Have you tried checking the assembly output to see whether it's actually taking and passing an address? It shouldn't need to.
Or is it a problem with passing the address down the stack to where it is used, through un-inlined calls?

Or is it a problem with passing the address down the stack to where it is used, through un-inlined calls?

yeah, it is a bit inconvenient for wrapping LCells in more complex ways.

Or I suppose it could be "single-use", i.e. it gets passed down the stack and then consumed at the leaf. I'll try that.

(fun fact: impl'ing on &mut Foo, e.g. impl<'a, 'de> Deserializer<'de> for &'a mut Foo<'de>, also turns off autoreborrow)

I'm having trouble with this test.  owner.ref_mut() is what you're calling borrow_mut(), i.e. it generates an LCellOwnerRefMut. This doesn't generate a compilation error, but it should. So c1ref isn't maintaining the borrow on the owner as it should.
//! LCellOwner::scope(|mut owner| {
//!     let c1 = Rc::new(LCell::new(100u32));
//!     fn test(o: &mut LCellOwner) {}
//!
//!     let o = owner.ref_mut();
//!     let c1ref = o.ro(&c1);
//!     test(&mut owner);    // Compile error
//!     println!("{}", *c1ref);
//! });

My implementation must be faulty:
pub struct LCellOwnerRefMut<'b, 'id> {
    phantomdata: PhantomData<&'b mut LCellOwner<'id>>,
}

impl<'b, 'id> LCellOwnerRefMut<'b, 'id> {
    pub fn new(_: &'b mut LCellOwner<'id>) -> Self {
        Self {
            phantomdata: PhantomData,
        }
    }
    #[inline]
    pub fn ro<'a, T>(&self, lc: &'a LCell<'id, T>) -> &'a T {
        unsafe { &*lc.value.get() }
    }
    #[inline]
    pub fn rw<'a, T>(&mut self, lc: &'a LCell<'id, T>) -> &'a mut T {
        unsafe { &mut *lc.value.get() }
    }
}

Getting a & on the PhantomData isn't the same as getting a & on the LCellOwner. How to get a borrow with the 'b lifetime out of the PhantomData?
(The nested .borrow_mut() stuff can wait until this one is solved.)

Okay, that seems to be working. I'll do some more testing in free moments in the coming days to see if I can break it. Also, I would prefer to get my head clear enough on this to understand exactly how this is working. I guess we're entangling the 'a and 'b lifetimes somehow.
Also, for LCellOwnerRefMut::borrow_mut, hopefully we can do the same trick, borrow to create a new 'b lifetime entangled with the previous 'b lifetime.

variance is an important concept to keep in mind here.

I think it's just lifetime nesting that makes it work, i.e. the existence of &'a &'b _ means that 'b has to outlive 'a.
The status on this is that I haven't had a lot of time. (My time right now is limited due to some Long Covid symptoms coming and going unfortunately.)
Also it adds a lot more API surface, so I have to be careful as I add it to not make a slip. I could implement the existing functionality in terms of these refs internally, but I'd prefer to keep the existing code easy to review without too much abstraction. So the rough plan is to add this with a cargo feature to enable it. I just have to find some clear time to go through all the detail.

ah, certainly! no worries. take your time!

I've been looking at implementing reborrowing for a custom type in another situation (for work), and it seems problematic to say the least. Obvious solutions don't work. For future reference: https://haibane-tenshi.github.io/rust-reborrowing/

It seems that there is one error in that article. He states that reborrowing by making the embedded reference public and then using a macro to reborrow the reference from inside the struct and create a new struct around that reborrowed reference won't work away from the original borrowing site. But I've tried it and it works. So it appears that there is a way around it. So a borrow_mut method won't be possible, but a borrow_mut_...! macro might work. (Assuming the PhantomData doesn't complicate things.)

No, a borrow_mut method should be fine, as long as it takes &mut itself.

This is exactly what I've been failing to achieve. I cannot get a borrow_mut to work in practice, no matter how I annotate with lifetimes or whatever. That blog post seems to agree that it is impossible (although he may be wrong).

Okay, that is so weird. I'd deleted the non-working reborrow method code I had because I got the macro working instead.  So I coded the method again and now I can't get it to go wrong. It works fine. I must have got some incorrect lifetime relation somewhere which just broke everything. So maybe this is all going to work fine. Sorry for the confusion.


Add mjlshen as a reviewer/approver

I find myself reviewing a lot of this repo's PRs lately haha

/approve
/lgtm

/approve


Event trigger request on Customer/Vendor entry statistics

Hi
during my app development, I Need a event trigger on "Vendor Entry Statistics" and "Customer Entry Statistics" page. here is the screen shots where I need trigger
vendor entry statistics

Customer Entry statistics

I need to apply more filters here for my app.
Thanks
Sahil Gupta

Hi! Welcome to the AL repository! Please take a minute to familiarize yourself with the purpose of this repository https://github.com/microsoft/AL/blob/master/README.MD and with the FAQ https://github.com/microsoft/AL/wiki/Frequently-Asked-Questions .
We believe that the issue you have opened is outside the scope of this repository. Please open it in the correct repository.


Ordering of F,V sections

Current formatting
An entry consists of

0 or more <HS> groups (Spruch cross references)
exactly 1 <S> group
1 or more <D> groups (usually 1, but 2 or more in 159 cases)

There are always the same number of D groups as Spruch, but the multiple spruch are written under  1 S group.

for each D group, exactly 1 ~S-group~ F-group,
0 or 1 of <V1>, <V2>, <V3>, <F4.1>, <F4.2>

Suggestion
In textual order, the V1, V2, V3, F4.1 and F4.2 sections should appear in that order.
However, the current digitization does not have this ordering. For instance

<S>,<D278>,<F>278),<V3>278. ,<V1>278.
<S>,<D349>,<F>349),<F4.2>,<V3>349.

The suggestion is to move the V and F items so the textual order is preserved.
@thomasincambodia   Do you agree?  If so, I'll do that

In the first comment, I forgot to say that there is also exactly 1 F for each D.  That comment now edited.

how many?
Emacs search for <\(V\|F4\).*<\(V\|F4\)   in checkgroup.txt finds 190 matches.
For instance

<S>,<D11>,<F>11),<F4.2>,<F4.1>    (F4.1, F4.2 misordered)
<HS>,<S>,<D90>,<F>90),<F4.2>,<V3>90.  (V3, F4.2 misordered)
<S>,<D160>,<F>160),<V2>160. ,<V3>160. ,<F4.1>  ordering correct

So 190 looks to be the number of Spruch to examine in the digitization.

Current formatting
An entry consists of

0 or more <HS> groups (Spruch cross references)

exactly 1 <S> group

1 or more <D> groups (usually 1, but 2 or more in 159 cases)

There are always the same number of D groups as Spruch, but the multiple spruch are written under  1 S group.

for each D group, exactly 1 ~S-group~ F-group,

0 or 1 of <V1>, <V2>, <V3>, <F4.1>, <F4.2>

Suggestion
In textual order, the V1, V2, V3, F4.1 and F4.2 sections should appear in that order. However, the current digitization does not have this ordering. For instance

<S>,<D278>,<F>278),<V3>278. ,<V1>278.
<S>,<D349>,<F>349),<F4.2>,<V3>349.

The suggestion is to move the V and F items so the textual order is preserved.
@thomasincambodia Do you agree? If so, I'll do that

of course, go ahead

This reordering work done.
See this diff.


Support setting which modules to be bundled

Currently it excludes all package names on the build task. It is correct in 99% cases and it's very fast using regex filters. However, I still sometimes run into the 1% cases, where:

A third-party package built by tsc, which is meant to be bundled, cannot run in node.js natively.
An ESM-only package, often made by sindresorhus, cannot run in cjs mode.

It has a workaround that you can change import 'pkg' to import './node_modules/pkg/index.js' to cheat the external plugin, however the code will look dirty.
So I think I can add a config --include:pkg to manually include a module, which is done by adding an option include: string[] to the external plugin.
This solution absolutely cannot handle all of the 1% cases, but it should be shrunk down to 0.1% now :)

Fixed in 5ddfb6a71d66d2ef2ae454cb6cff0b76811fa0c3


feat(project): add support for standalone application

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number

Issue Number: #88, #66
Does this PR introduce a breaking change?

[x] Yes
[ ] No

:tada: This PR is included in version 16.13.0-beta.1 :tada:
The release is available on:

v16.13.0-beta.1
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 16.13.0 :tada:
The release is available on:

v16.13.0
GitHub release

Your semantic-release bot :package::rocket:


Feature.java getDesc returns null

as said in the title

Found no issue in Feature Class, is every setter always called when creating a feature?

Error seems to lie in the loading of features from the disk, gonna investigate ASAP

Fixed, but \n values in the description don't get turned into breaks on the cards, someone with frontend knowledge please investigate this

7b28bb904dc5e9d0f46fa3dadd8cd7e61fd8ad5b
addressed in here


Is puppeteer-dart support the CDPSession?

https://pptr.dev/api/puppeteer.cdpsession
I need to listen to the websocket message on the webpage.
I can use the following javascript code to do it
// ...blablabla
const client = await page.target().createCDPSession();
await client.send('Network.enable')
client.on('Network.webSocketFrameReceived', (params) => {
 console.log(params)
})

But I didn’t find the relevant code in puppeteer

It's called Session and it's defined here: https://github.com/xvrh/puppeteer-dart/blob/master/lib/src/connection.dart#L217
You might be interested in the devTools property accessible on Page. It gives you access to either the low-level client or to a fully typed API of the devtools protocol:
import 'package:puppeteer/puppeteer.dart';

void main() async {
  var browser = await puppeteer.launch();
  var page = await browser.newPage();

  // Use the typed API
  await page.devTools.network.enable();
  page.devTools.network.onWebSocketFrameReceived.listen((e) {
    print(e.response.payloadData);
  });

  // Go low-level and send the raw string directly
  var client = page.devTools.client;
  await client.send('Network.enable');
  client.onEvent.where((e) => e.name == 'Network.webSocketFrameReceived').listen((event) {
    var params = event.parameters;
    // Do your stuff
  });
}


New Ionic + new Cordova no longer work for debugging (with livereload)

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
New Ionic + new Cordova no longer work for debugging (with livereload)
Expected behavior:
run normally with cordova in livereload mode
Steps to reproduce:
On a new computer, I installed:

Java
Ant
Andrioid Studio
NodeJs
Ionic and
Cordova

And after everything configured just like the Ionic documents, I created a new basic app:
ionic start myApp tabs
The application even runs normally, but when I go to debug:
ionic cordova run android -lc
I get the following message:
console.warn: Native: tried calling StatusBar.styleDefault, but Cordova is not available. Make sure to include cordova.js or run in a device/simulator
console.warn: Native: tried calling SplashScreen.hide, but Cordova is not available. Make sure to include cordova.js or run in a device/simulator

Related code:
Normal code, generated by Ionic's own standard template tabs
Other information:
cli packages: (C:\Users\marci\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.19.0
    ionic (Ionic CLI) : 3.19.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.6
    Cordova Platforms  : android 7.0.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v8.9.3
    npm               : 5.5.1
    OS                : Windows 10

Environment Variables:

    ANDROID_HOME : d:\AndroidSdk

Misc:

    backend : pro

Cordova requirements:
Android Studio project detected

Requirements check results for android:
Java JDK: installed 1.8.0
Android SDK: installed true
Android target: installed android-26,android-25,android-24,android-23,Google Inc.:Google APIs:23
Gradle: installed C:\Program Files\Android\Android Studio\gradle\gradle-3.2\bin\gradle

Still a thing 👎

As a workaround you can edit
<EMAIL_ADDRESS>
replace
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'assets', 'www');

with
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'app', 'src', 'main', 'assets', 'www');

From this StackOverflow question

I had the same problem and ended up downgrading from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Fixed the issue.

Any update on this? This is very annoying.

Same here
cli packages: (C:\Users\myUser\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.8
    Cordova Platforms  : android 7.1.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v8.11.0
    npm               : 5.6.0
    OS                : Windows 10

Environment Variables:

    ANDROID_HOME : C:\Users\myUser\AppData\Local\Android\sdk

Misc:

    backend : legacy

I made a Cordova hook that you can add to your config.xml. It will edit the file that @itslenny  mentions above. If you don't know what Cordova Hooks are, you can find more information at https://cordova.apache.org/docs/en/latest/guide/appdev/hooks/. I recommend adding it like this
<hook src="scripts/fixcordova7issue.js" type="before_prepare" />
The code for the webhook is in this gist: https://gist.github.com/SteveKennedy/a9964b291afa51f820b5d73b687eeb34

Still an issue with Ionic 3.20.0.
The fix described here on stackoverflow worked for me.

FIX: You need go to<EMAIL_ADDRESS>and replace
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'assets', 'www');
to
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'app', 'src', 'main', 'assets', 'www');

@SteveKennedy This is probably the best solution, since its not always a good idea to edit anything in the node_modules folder. But I have a change to your gist.
Line 37 should be
var targetFileString = "exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'app', 'src', 'main', 'assets', 'www');"
While your current code makes sense, the hook did nothing unless I changed it to above. But once changed, everything is working well in Corvoda 7.1.0. Thanks for your contribution!

While the gist and/or the suggested edit works it makes the normal ionic serve think it is on a device with live reload too.

Interesting! Ultimately its a bug that will be addressed in the future by Ionic or Cordova teams, but this fix at least let me continue working on the emulator.

You would think that this bug would be at the top of their queue. Strange.

This is a problem that should be treated as a priority because it is a BUG. Today I lost 3~4 hours until I get here, not to mention that when leaving the project of the repositiorio we will have to remember to edit the file.

Here says that there is a new update with the fix.

Yes, I believe this merged PR should solve this issue: https://github.com/ionic-team/ionic-app-scripts/pull/1407

I imagine the team is pretty busy with the v4. I can confirm that with ionic v3.2 this is still an issue - @msholly 's instructions fix the problem. gang gang.

I'm testing ionic 4 and I have the same problem =(

I'm testing ionic 4 and I have the same problem. Now in the file "server-config.js" it looks like this:

exports.ANDROID_PLATFORM_PATHS = [
path.join('platforms', 'android', 'assets', 'www'),
path.join('platforms', 'android', 'app', 'src', 'main', 'assets', 'www')
];

The warn persists.

im getting the same error even though my server-config.js has updated paths.
    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.11
    Cordova Platforms  : android 7.1.0 ios 4.5.4
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v9.2.1
    npm               : 6.1.0
    OS                : macOS High Sierra
    Xcode             : Xcode 9.2 Build version 9C40b

I have a same problem
My info
Ionic:
ionic (Ionic CLI) : 4.1.1
System:
NodeJS : v8.11.1
npm    : 6.4.0
OS     : Windows 10

same here

Is there a workaround for debugging or testing faster?

I am not able to find this file what should i do
FIX: You need go to<EMAIL_ADDRESS>

node_modules/@ionic does only contains 3 folders, angular, angular-toolkit and core . There is no trace of app-script

I started having the same issue when upgrading from ionic 4.0.0-beta.11 to 4.0.0-beta.12. Decided to downgrade for the time being until the next beta version.
Just had some time to upgrade to 4.0.0-beta.13, and this is still an issue.

try ./node_modules/.bin/ionic-app-scripts serve --sourceMap source-map --iscordovaserve --wwwDir platforms/browser/www/ --buildDir platforms/browser/www/build

@tgirgin23 I also tried to downgrade to @ionic/4.0.0-beta.11 but for me it's not working.
I also removed node_modules, reinstalled and removed and added the platform android.

@RafaelKr Here is my ionic info (nodejs version is actually 10+, just had to switch for another project in the meantime). Hopefully this can help you.
✔ Gathering environment info - done!
Ionic:

   ionic (Ionic CLI)             : 4.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.11
   @angular-devkit/build-angular : 0.7.5
   @angular-devkit/schematics    : 0.7.5
   @angular/cli                  : 6.1.5
   @ionic/angular-toolkit        : not installed

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.1.3, (and 7 other plugins)

System:

   NodeJS : v9.11.1 (/usr/local/bin/node)
   npm    : 5.6.0
   OS     : macOS High Sierra
   Xcode  : Xcode 9.4.1 Build version 9F2000```

@tgirgin23 thanks for sharing!
I tried to mirror your environment as close as possible, but after uninstalling<EMAIL_ADDRESS>it says Error: Could not find module "@ionic/angular-toolkit" from /path/to/my/project
[ERROR] Error loading @ionic/angular-toolkit package.json: Error: Cannot find module '@ionic/angular-toolkit/package'
✔ Gathering environment info - done!

Ionic:

   ionic (Ionic CLI)             : 4.2.1 (/home/rafael/.nvm/versions/node/v9.11.1/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.11
   @angular-devkit/build-angular : 0.7.5
   @angular-devkit/schematics    : 0.7.5
   @angular/cli                  : 6.1.5
   @ionic/angular-toolkit        : not installed

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : android 7.1.1
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.2.0, (and 10 other plugins)

System:

   Android SDK Tools : 26.1.1 (/home/rafael/android-sdk-linux)
   NodeJS            : v9.11.1 (/home/rafael/.nvm/versions/node/v9.11.1/bin/node)
   npm               : 5.6.0
   OS                : Linux 4.10

@RafaelKr Yes, I got the same error. Everything is still working fine though... weird.

I am using Ionic 4.3.0, and still got this issue.
Hope this will have high priority in ionic team.
Ionic:
ionic (Ionic CLI)             : 4.3.0 (/Users/user/.config/yarn/global/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.0.0-beta.13
@angular-devkit/build-angular : 0.8.6
@angular-devkit/schematics    : 0.8.6
@angular/cli                  : 6.2.6
@ionic/angular-toolkit        : 1.0.0
Cordova:
cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>Cordova Platforms     : ios 4.5.5
Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.2.0, (and 6 other plugins)
System:
ios-deploy : 1.9.4
NodeJS     : v10.9.0 (/Users/user/.nvm/versions/node/v10.9.0/bin/node)
npm        : 6.2.0
OS         : macOS
Xcode      : Xcode 10.1 Build version 10B61

It works again!
They just fixed it with an angular-toolkit update. Install it with
npm i<EMAIL_ADDRESS>Source: https://github.com/ionic-team/angular-toolkit/blob/master/CHANGELOG.md

Installing the new ionic angular-toolkit has sadly not fixed the issue for me on 4.0.0beta15.
@RafaelKr Could you please post an ionic info so that I could compare?

@tgirgin23 nice to hear it's working! I have added my ionic info anyway.

Not sure why but transferring all my files to a fresh project worked for me too!


feat: Added new fields to templates

Description
Added two new fields to templates - productImageUrl and sortPriority.
Fixes #11877
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=9767c78


Jenayah: Watch apkafe.com

Jenayah requests the watch of the watch_keyword apkafe\.com. See the MS search here and the Stack Exchange search here.

apkafe\.com has been seen in 1 true positive, 2 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Can't get full time string from trajectory file

Using spiceypy.etcal() to get the time string from a trajectory file, I can only get the time string to the millisecond. I'd like the full string which includes (TDB) at the end like I can see in MATLAB. Any suggestions for me?

Hi @jdiazdelrio,
I have a .bsp file and I don't have an ephemeris time to turn into a string time. Assume I don't know anything about what is modeled by the file. First, I have to find the ids of the vehicles modeled in the file. I use spiceypy.spkcov to get the ids, then I use spiceypy.etcal to get the time string from the ids. The time string that I get out is not the full string you listed above, but a rounded version.
Thanks,
Sarah

Hi Sarah (@surdahl),
you've got two options in order to know the coverage time. The first is to use the SPICE utility program brief. You could download it from here:
https://naif.jpl.nasa.gov/naif/utilities.html
Pic your platform and click on it. That will lead you to a page where you can download brief
If you want to program it yourself, then:

Use spiceypy.spkobj to get the IDs codes for all the ephemeris objects in the SPK file.
Use spiceypy.spkcov to get the coverage window for the ephemeris object of interest within the SPK file, e.g. spiceypy.spkcov( "de405.bsp", 499, cover ). cover contains now the ephemeris times you are looking for. Note that it is a SPICE window, i.e. it contains start and end times for each of the coverage intervals contained within the SPK file named "de405.bsp" for the object 499 (Mars)
Use spiceypy.timout to retrieve the string version for each of the time boundaries, e.g. timstrs = cspice_timout( cover, 'YYYY MON DD HR:MN:SC.### (TDB) ::TDB' )

If it helps, maybe you could check the Examples section of the spkcov API (it seems to be exactly what you are trying to do) from the Matlab toolkit:
https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/MATLAB/mice/cspice_spkcov.html
Regards,
Jorge

Jorge (@jdiazdelrio),
Cover does not give you ephemeris times. It gives you the time strings... Which is why I am then using spiceypy.etcal to then turn that time string to an ephemeris time. If my time string is rounded like it is, I get a different ephemeris time in seconds due to the rounding.
Sarah

Hi Sarah (@surdahl),
the output of spkcov is a double precision SPICE window, named "cover".  In the Detailed_Output section on the link below, you can see that indeed, it provides you with ephemeris times:
https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/cspice/spkcov_c.html
As it is stated there:

The interval endpoints contained in `cover' are
ephemeris times, expressed as seconds past J2000
TDB.

The input of etcal is also ephemeris times. See Detailed_Input below:
https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/cspice/etcal_c.html
If you replace the call to etcal, by the call to timout, you will get as output a time string in TDB.
timstrs = cspice_timout( cover, 'YYYY MON DD HR:MN:SC.### (TDB) ::TDB' )
If what you need is only ET (ephemeris time), then you don't need any conversion. The output of spkcov is enough.
Regards,
Jorge

@jdiazdelrioI Ah okay I was translating to a time string and translating back to ephemeris time which was the problem. Thank you!


fix(security): upgrade deps vulnerabilities

patching: Improper Verification of Cryptographic Signature in node-forge: CVE-2022-24772 , CVE-2022-24771, CVE-2022-24773

superseded by #165 and #162


Fixed invalid link for object metadata

fixed invalid link of object metadata #40892

pinging @bradtopol for approval

This file is auto generated and the changes in this PR will be overwritten when the reference docs are generated
It is better to change the source

/label tide/merge-method-squash
/lgtm
/approve


install_pip_packages.sh and install_cran_packages should be runnable from Anaconda prompt

I created the bash-scripts install_pip_packages.sh and install_cran_packages.sh to be able to install pip and cran packages AFTER the environment was created. But the line conda activate csp_surname_name does not work from within a bash-script (https://stackoverflow.com/questions/47246350/conda-activate-not-working).
Besides, the scripts should also work as Windows-Shell-Scripts, because bash is not working on windows (maybe if the bash-scripts are executed from Git Bash? But then we have to tell Git Bash how to activate conda)

I guess a solution can be found here:
https://stackoverflow.com/questions/34534513/calling-conda-source-activate-from-bash-script
Note, that this might not solve the "Windows-Problem" but at least allows to execute the scripts on Linux?

See my comment: https://github.com/conda/conda/issues/7980#issuecomment-1523630369


Dw clock frequency

Add Dw_clock_frequency field and populate acording to UVC1.0 or 1.1 spec.
Update data_bytes every time to reflect the size of meaningful data not allocated space.

Thanks for this. Sorry about the long delay.


[sw] Enabling Ibex's icache

The icache within Ibex starts disabled and needs to be specifically enabled via a write to the Ibex specific cpuctrl CSR (see https://ibex-core.readthedocs.io/en/latest/03_reference/cs_registers.html#cpu-control-register-cpuctrl).
Do we enable the icache anywhere? We should turn it on for at least some chip level testing (as these are also helping verify Ibex along with the specific things they're aimed at). Has any consideration be given as to when to enable it in the boot flow?
@arunthomas @cfrantz @mundaym

no it's not turned on right now.
I'm hesitant to turn it on because the flash isn't fully verified and i'm pretty sure could break against the aggressive fetching nature of the icache.
I have brought up this poihnt with both @alphan and @cfrantz before, and it's just something that's pending.  Thanks for filing an issue though.

sounds good to turn on to me.
if you guys find any weird flash blocking issues, let me know.

@GregAC and @tjaychen I tried enabling icache in #13110 but after that I didn't receive anything from UART (cw310). That PR adds an OTP entry and updates the DEV and RMA hjson files. I've just pushed an update that reverts the value of the OTP entry to 0. If this doesn't fix the issue I might have to comment out the CSR_WRITE().
cc @moidx @cfrantz

yep that sounds good! thanks for changing the title also to better reflect the issue.

Hi @arunthomas, can you provide an update on the next steps here? Thanks!

@timothytrippel will work on this

hey all, very related to this topic, @alphan had brought up the idea of using a singular ROM for all purposes, with maybe specific features turned off (such as verification and certain hardening).  Do we want to consider this path? Or do we feel its lower priority and okay to live with testrom for now?
I don't know how much work @alphan suggestion is, and I'm not sure how many things in the DV TB are currently dependent on specific testrom behavior (like setting the test_status for example).

Thanks for pointing this out @tjaychen. I think it's a good idea to enable this sooner rather than later to unearth any hidden issues (like the interaction between icache and address translation) but @timothytrippel is aware of our plans for eventually converging to a single ROM (with some specializations) and thus I recommended implementing something as simple as possible.

Thanks for pointing this out @tjaychen. I think it's a good idea to enable this sooner rather than later to unearth any hidden issues (like the interaction between icache and address translation) but @timothytrippel is aware of our plans for eventually converging to a single ROM (with some specializations) and thus I recommended implementing something as simple as possible.

sounds good. Thanks @alphan / @timothytrippel


Option to make ranger a buffer (like nerdtree) instead of floating window?

I have a question. Is it possible for the ranger popup to be a buffer, mimicking the likes of nerdtree, instead of a floating window? So it would be a nerdtree, but fully integrated with my ranger config/keybindings (which makes this plugin really stand out).
Just to make it visually clear what I am talking about, take a look at this:

Pretend these two windows (of ranger and neovim) are one single window, but different buffers. That's pretty much what I mean.

The short answer is No. You can use the custom layout to make the floating window more like nerdtree, but I don't suggest this idea.


Improve figures for nested CV

We have this
https://github.com/compstat-lmu/lecture_i2ml/blob/devel/05-tuning-nested/figure_man/train_valid_test.jpg
 figure.
If we have the source file of the figure, we could change the colors to match the colors of the nested cross-validation figure. This probably makes it easier to see the relationship between both figures.
Here a quick example of what I mean:

@giuseppec Hello, so we already changed the image for nested resampling. I am linking the google slide link down below. And let me know what you think and what should be done. https://docs.google.com/presentation/d/1W9nPHJa39Tkzzp37ZeRsEaSZjXMdFjH-rmIpimOKZKA/edit?usp=sharing

isnt the image source linked in the Rnw source? @giuseppec should not need to post about such things here

isnt the image source linked in the Rnw source? @giuseppec should not need to post about such things here

I didn't ask "where do I find the source file", my question was rather "can we please use the same colors in both figures to make t easier to see the relationship between both figures".
Anyway, if the nested resampling figure will be changed, this might not be relevant anymore.
@RifatMehreen: One thing I am currently missing in the new figure is that I currently don't see how it relates to hyperparameter tuning:

Is the example only about comparing logreg (which does not have hyperparameters) with knn? And
is the knn an "auto-tuner" (i.e., a combination of knn with a tuning method to find optimal value for k)?

Rifat's figure simplifies "optimize A over \alpha" to "pick between knn (fixed k, implicitly assumed) and logreg", basically.
Nobody ever understands what we're talking about here anyway, so it might be worth it to have both in there:
start by slowly incrementally  building up Rifats figure to explain this in a simple setting
then use the more general diagram you linked above to link this with hyperparameter tuning
If colors are important to you, i guess Rifat could color her diagram as well, might not be the best use of her time, though...?

I didn't ask "where do I find the source file", my question was rather "can we please use the same colors in both figures to make t easier to see the relationship between both figures". ;)

sorry, i misread.

Nobody ever understands what we're talking about here anyway,

i really disagree, i have ldctured about this 1000 times. and people do understand this. i DO AGREE that we need to make this BETTER. we need a fine-grained animation and a slower explanation. so maybe we mean the same, and i am just hung up on your wording :)
yes, this section needs to be heavily improved!

and yes, colors can be optimized later. we now need a better, step by step animation? clean issue for this?

@RifatMehreen ok, so notation here is not consistent at all with what's on the rest of the slides:

we're using lambda not alpha, inducer $mathcal I$ not A and Data $\mathcal D$ not D --
@RifatMehreen, the source for this file is in figure_man/tuning_process.odp, where some of these are already fixed but not all -- please:

use a script-I for the inducer
use $D_{train}$ instead of split S (everywhere!)

while you're at it, you could also change the colors like Giuseppe suggested, but that's very secondary, I think....
fix that in the odp-file, export the file as tuning_process.pdf, commit your changes in a new issue branch branching off the refactor-w1920 branch (!!) and do a PR as soon as your're done, pretty please :heart:

EDIT: it might even be quicker and nicer to just use the graphical elements on the google slide for this graphic:
https://docs.google.com/presentation/d/14xwcs5zncTjFL4hIHAprjZMmyGIPqk5vs8DS32vEAvQ/edit#slide=id.g60af4020e8_0_15

and rearrange them like the figure in the comment above..... your choice.

EDITEDIT: I do think actually the second option would be much nicer because then the close connection to the previous slides is much clearer.....

Okay. I will start working as soon as possible

@RifatMehreen nevermind about tuning_process.odp, @juliambr shared the updated version with the correct notation this morning, so you don't need to take action rn on this. moving the discussion about this to #417 and closing this for now.


ngStorage module not found error in production package

This is a really weird issue I encountered many times but unable to solve it permanently, sometimes it resolved after reinstall the ngstorage But this time it doesn't work out.
I am using angular 1.6.8 and "ngstorage": "^0.3.11" and using gulp as a task runner. whenever I run my project on development stage ( using gulp clean serve) it works fine BUT when i build the production stage ( using gulp serve:dist) , Index page goes blank and there is long red error detail in the console that ngStoarge module is not defined

Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to: Error: [$injector:modulerr] Failed to instantiate module ngStorage due to: Error: [$injector:nomod] Module 'ngStorage' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. http://errors.angularjs.org/1.5.8/$injector/nomod?p0=ngStorage

see the attached screenshot
Please tell me why this error comes up and how to solve it? Also see the issue on SO
I tried to debug the issue using breakpoints in console but it does not help me out I am using ngstomp librray also and I suspect that it may be reason.

it was the issue due to another library which was missing semicolon (;)in the end, and it cause the error while appending next js library. one can see the answer in under mentioned SO question


Add 'dvc merge' command

'dvc merge' should act as a 'git merge' when there are no source data files conflicts detected and give priority to source data files from current branch otherwise.

"source data file" == "imported data file"


added security definition description

Describe the PR
Added description capabilities for the security definitions types.
Additional context
I know this field is not mandatory, but another tool I am working with, relies on me adding the descriptions, otherwise it will break. I would need pretty please a tag if this gets merged 🙏

@pmorelli92 I perfectly understand the use case, please open a feature request https://github.com/swaggo/swag/issues examining this implementation requirement and I will follow you with a CR.

Done @ubogdan https://github.com/swaggo/swag/issues/1175

@ubogdan I discovered a bug when you could have more than one security definition so I did the fix and added test cases for it.

@pmorelli92 Thanks for your contribution.


feat(plugins) new Galileo plugin

Implement the ALF 1.1 specs from https://github.com/Mashape/api-log-format
Implement the latest Galileo agents specs from https://github.com/Mashape/galileo-agent-spec
Rename the plugin from mashape-analytics to galileo. This still requires more testing than I did so far
It has more tests than the old plugin, and should perform better.

Still waiting on https://github.com/openresty/lua-cjson/pull/6 to make it to an OpenResty release, until then, this still uses a workaround to serialize empty table to empty JSON arrays.
Goes with https://github.com/Mashape/getkong.org/pull/214 for the updated documentation.

As a reminder, if the target port is 443 this plugin should be able to handle HTTPs.

Perfectly aware. Still waiting on Galileo v3 running in prod with SSL support.

By the way I think the protocol should be specified in a separate property. I could have Galileo running on-prem on an arbitrary HTTPs port, like 9000, or running on port 443 but under HTTP.

Also aware, also planning on doing it once Galileo v3 is released.


Can not remove node in spline vis.

Spamming delete, while a node is selected does not do anything, both wile in focus or not.

Please include browser name, browser version and OS in your report.

Firefox, 47, Ubuntu 14.04, favorite color: blue

I'm running the visualization in the same mode, but cannot confirm the bug.
After a personal chat, you told me the bug that you can remove points on the end of the spline. I made a separate bug for this, please see #4 .

Cannot remove nodes on Google Chrome Version 51.0.2704.103 (64-bit) on Ubuntu 14.04

Chrome is not supported. :kissing_heart:

Problem solved for @S3BASTI3N


Update Cohort 5 Information in Docs

@YazzyYaz a merge conflict, but otherwise this is good.

thanks @barbaraliau closing this pr because it seems the whole file has been removed on master. opening the new pr here: https://github.com/celo-org/celo-monorepo/pull/5928


Adding a no cache cache control header to solve infinite loop issues

Type of change

[x] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[x] @clerk/remix
[ ] @clerk/types
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.

Is it possible to have the package allow Node 14? AWS Lambda's latest version is Node 14 so that's what I run locally.

[ ] npm run build runs as expected.

When Clerk returns an interstitial and the developer has caching implemented, it will continually redirect bc cached versions will continue to load the interstitial. Adding a "no cache" Cache Control header solved it on my end, which basically tells my CDN to not keep the interstitial in the cache. I think this could be a reasonable default, or at the very least, a parameter we could pass into rootAuthLoader

ccing @nikosdouvlis for review

Very interesting. @dvargas92495 Thank you very much for the effort you put into this. Let me also cc @colinclerk  and @igneel64 so we can discuss.

Makes sense to me!
@dvargas92495 to confirm, you’re seeing the interstitial come through with a 401 and it’s still being cached by default?
We chose 401 instead of 200 in part expecting it wouldn’t be cached - I don’t see a problem with adding the header to further emphasize it shouldn’t be cached.

It's using Remix's json method, which is a Response object that returns a 200. I think returning a 401 instead should also work

This is now merged, @dvargas92495 thanks for the contribution :)


Tutorial Code error in PWA training: Cache API lab

Page Affected: https://developers.google.com/web/ilt/pwa/lab-caching-files-with-service-worker#what_weve_covered
What needs to be done?
Tutorial needs to be reviewed for updates to code used; existing code throws error as it instructs to change the value of a declared constant using the "var" statement. Tutorial works if code is changed as follows:
change "const staticCacheName = 'pages-cache-v1';" to "var staticCacheName = 'pages-cache-v1';" in section: 2. Cache the application shell

[X] Appropriate type-something label has been added.
[X] Appropriate section-something label has been added.

Hi, thanks for filing this bug.
I believe you are supposed to make the change in place. So the line const staticCacheName = 'pages-cache-v1'; in sw.js should be replaced with var staticCacheName = 'pages-cache-v2';, rather than something like
const staticCacheName = 'pages-cache-v1';
...
var staticCacheName = 'pages-cache-v2';

which would throw the error you're describing. In either case, the var could be updated to a const for consistency, but there shouldn't be any errors. You can always compare against the solution code if you're ever unsure.
Does that make sense?

Hi David,
I did try replacing the value of the constant in place by changing “const staticCacheName = 'pages-cache-v1';” to “const staticCacheName = 'pages-cache-v2'”
This did not work and the old cache was not removed. I am not sure why. I might try this method again; if it does work, then perhaps the page text can be updated instead of the code.
Michele Lukowski
This e-mail message, including any attachments, is for the intended recipient(s) and may contain confidential and/or privileged information. Any unauthorized review, copy, use or disclosure is prohibited and may be unlawful. If you are not the intended recipient, please delete the e-mail and any attachments and notify the sender immediately.
From: David Scales<EMAIL_ADDRESS>Sent: Thursday, March 14, 2019 5:04 PM
To: google/WebFundamentals<EMAIL_ADDRESS>Cc: Michele Lukowski<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/WebFundamentals] Tutorial Code error in PWA training: Cache API lab (#7403)
[EXTERNAL]
Hi, thanks for filing this bug.
I believe you are supposed to make the change in place. So the line const staticCacheName = 'pages-cache-v1'; in sw.js should be replaced with var staticCacheName = 'pages-cache-v2';, rather than something like
const staticCacheName = 'pages-cache-v1';
...
var staticCacheName = 'pages-cache-v2';
which would throw the error you're describing. In either case, the var could be updated to a const for consistency, but there shouldn't be any errors. You can always compare against the solution code if you're ever unsure.
Does that make sense?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/google/WebFundamentals/issues/7403#issuecomment-473110567, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AuUAmEWu_stNYQQpj2M2JXB4jn7o4DHNks5vWuN2gaJpZM4b0pHF.


Mac: Placeholders should be updated for mode changes as part of updating the projection

git status should report files as modified when their mode changes
UpdatePlaceholderIfNeeded should be called when a file's mode is changing (even if its contents are not changing).  TBD if UpdatePlaceholderIfNeeded can be smart enough to just update the mode.

For the first part:

git status should report files as modified when their mode changes

It appears that the the kext receives a KAUTH_VNODE_WRITE_SECURITY operation when chmod is used.

Splitting this issue into two issues.


Remove _mixed in playlist

Since all platforms default to mixed (except zos), we can remove (_mixed)? in playlist.
For example: https://github.com/adoptium/aqa-tests/blob/master/jck/compiler.api/playlist.xml#L86

I think this issue is resolved.


Merchant-center-feed

Ability to pull Merchant Center products into Feed sheet plus filter on "pva id" custom attribute.
Actually getting products into videos requires formulas (not yet included)

Thanks LGTM!