Druid does not intermittently drop segments past retention time

Druid does not intermittently drop segments past retention time. This led to org.apache.druid.segment.SegmentMissingException on our systems
Affected Version
0.22.1
Description
What happened
We have a datasource where we set Retention rules - loadByPeriod(P24M+future), dropForever. Datasource segment granularity is Hour.
We encountered an erroneous case where a segment that is past 24 months did not get deleted properly.

Segments page shows the segment as available and after some refreshes, it doesn't show. But after some more refreshes it reappears.
We ran a query on sys.server_segments table

select *
from sys.server_segments
where segment_id = <segment_id>

It returned two historicals having that segment. Since we have Druid cluster setup on Kubernetes, we deleted the two historical pods and that's when the segments were no longer available on Druid and the issue was resolved.
How often is this issue occurring
It doesn't happen with all segments but happens for 1-2 segments once in a few days.

Historicals use AWS EBS as Persistence volume. This means data is actually stored on EBS and when Historical pod is removed, another pod is created within minutes and the EBS gets attached to this new pod.
When we deleted the pod as mentioned above, the issue got resolved. Since EBS is not affected, I suppose it means that there was some main-memory information that was still there on Historical but it was not supposed to.

How did we come across this issue
Time was 2022-04-19T03. Segment that did not get deleted was 2020-02-19T00 even though it was past 24 months.
We ran time boundary query
{
    "dataSource": "our_datasource",
    "queryType": "timeBoundary",
    "bound": "minTime"
}

We got the following exception
org.apache.druid.server.QueryResource - Exception handling request: {class=org.apache.druid.server.QueryResource, exceptionType=class
org.apache.druid.segment.SegmentMissingException,
exceptionMessage=No results found for segments[[SegmentDescriptor{interval=2020-04-19T00:00:00.000Z/2020-04-19T01:00:00.000Z, version='2022-04-11T17:18:50.095Z', partitionNumber=0}]],
query={
    "queryType": "timeBoundary",
    "dataSource": {
        "type": "table",
        "name": "our_datasource"
    },
    "intervals": {
        "type": "intervals",
        "intervals": [
            "-146136543-09-08T08:23:32.096Z/146140482-04-24T15:36:27.903Z"
        ]
    },
    "bound": "minTime",
    "filter": null,
    "descending": false,
    "granularity": {
        "type": "all"
    }
}, peer=xx.xx.xx.xx}

(org.apache.druid.segment.SegmentMissingException: No results found for segments[[SegmentDescriptor{interval=2020-04-19T00:00:00.000Z/2020-04-19T01:00:00.000Z, version='2022-04-11T17:18:50.095Z', partitionNumber=0}]])

As the segment is past retention time, that's when we started checking on Segments page as mentioned above and the sys.server_segments table.
Kindly help us resolve this issue. Please let us know if you need further details.

Facing the same issue again.
Observations
Druid console segments UI page with every refresh within seconds shows different list of segments.

My understanding is segments UI page shows results of sys.segments. Can you please add which process and how often  creates or refreshes sys.segments information?
Result of the below query
select * from sys.segments
where segment_id like 'our_datasource_2022-04-09T05:00:00.000Z_2022-04-09T06:00:00.000Z%'
order by partition_num

But http://:8081/unified-console.html#segments UI page does not show any segment for 2022-04-09.

Happening to us too

@tanisdlj
Thank you for sharing. Can you please share the Druid version that you are running? Just want to confirm if this started happening in the new version. Also, may I know if you are running your Druid cluster on Kubernetes?

@mounikanakkala 0.22.1, running on hosts, not containers

Hi Team,
May I know if there is any update on this one?

Will this resolve with version upgrade?

Coordinator is worth focusing on.  Why?

segments may not be dropped: (coordinator duty to mark used; ...although historical to execute it...although coordinator can affect health of historical based on, eg, load/drop workload including segment balancing...and back and forth and...)
inconsistent query results on broker (obviously impacted by broker performance itself, but its metadata can be intensive and has reliance on coordinator)
overall historical load: can be heavily dependent on coordinator (eg, loading/dropping segments, even coordinator -> poor ingestion -> suboptimal segments -> more query workload, etc, etc)...could prevent proper segment unloading

same as "segments may not be dropped" above...but this is from "point of view" of historical

it touches the metadata datastore which can be an effective way for something like ingest (eg, heavy ingests, compaction, etc) to stall the coordinator (eg, you could heavily fragment an RDBMS with heavy ingest)

So "problem on historical" also a appears very good candidate here.  However, the "inconsistencies" (in/across time...and in space: like on different historicals and pods, with different segments, different queries, upon different browser refreshes -> possibly calls to different brokers, etc) demand more commonality between the failures rather than "persistent set of coincidences" as the explanation (of course "persistent coincidences" not impossible).  So I'd look at the coordinator as a relevant commonality.  (...And of course coordinator can be affected by other cluster activity, like heavy ingest destabilizing the overlord running on the same hardware or the metadata store which is shared with the coordinator...all things are connected)
The point of mentioning all of this is because an upgrade may not fix a problem like this one.  (Actually it could make it worse -- sometimes it happens, like potentially around 2021-12 [some new feature side effect causing much higher resource requirement for a recently enhanced in-memory column info, IIRC] and maybe also around 2022-10 [massive increase in heap requirements for streaming and batch indexing]...upgrade problems are pretty understandable with a large, complex system).  Not saying you shouldn't upgrade -- just saying that regardless of that, the system could be running too close to some limits for your needs, for example.  If so, the info above is about examining wherever that gap may live between desired and actual performance.
Some questions worth mulling over...
How many segments in the cluster? (best to breakdown by used/unused...because that affects coordinator workload, plus the possibly very highly relevant workload of the overlord if sharing resources for computation/network/state/etc)
How smooth is ingest workload (demand) and performance (actual)?  (Also consider compaction, even kill tasks, etc)
Any general observations related to stability and performance? (eg, dying processes, failed ingest tasks, slow publish times, indexing error messages about retries/errors in HTTP calls, ongoing logs/alerts on throttling segment balancing, etc)

This is happening to our cluster as well. Running on Kubernetes, deleting and recreating one of our four historicals fixes this temporarily, but it seems to always return until I completely drop the relevant segments and re-import the data which is annoying and takes a while. Any advice on how to at least fix if not prevent this?


ale_sign_error fighting

Information
VIM version

NVIM v0.3.0
Build type: Release
Operating System:
MacOS Sierra
:ALEInfo

Current Filetype:
Available Linters: []
Enabled Linters: []
Suggested Fixers:
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
Linter Variables:
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 1
let g:ale_command_wrapper = v:null
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '[%linter%] %s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 1
let g:ale_fixers = {'typescript': ['prettier'], 'javascript': ['prettier']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = v:null
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'never'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {'go': ['golint', 'go vet', 'gometalinter'], 'javascript': ['eslint']}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = v:null
let g:ale_list_vertical = v:null
let g:ale_loclist_msg_format = v:null
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = v:null
let g:ale_maximum_file_size = v:null
let g:ale_open_list = v:null
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 1
let g:ale_sign_error = '●'
let g:ale_sign_info = v:null
let g:ale_sign_offset = v:null
let g:ale_sign_style_error = v:null
let g:ale_sign_style_warning = v:null
let g:ale_sign_warning = '●'
let g:ale_statusline_format = v:null
let g:ale_type_map = v:null
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:
What went wrong

Sometimes I get the error sign I asked for, and sometimes I get the default '>>', and often they switch back and forth.
For example, right now I'm seeing multiple ● (its actually red)
I just saved the buffer,  4 of them switched to >> and 3 stayed ●
I typed an error, it started with >>, switched to ●, and then went back to >> after I saved.
I'm not sure what else to convey except maybe making a video.

A video would he helpful. You might be seeing a combination of linters that can run as you type at play with linters that can only run against files on disk,where some report warnings and some report errors. Or you might be seeing two different tools reporting problems on the same lines where one is a warning and one is an error.

its YouCompleteMe fighting with ale
It does more than the name implies.

To be fair, ALE offers completion support, so I wouldn't knock the name too much.


Fix spacing when just optional arguments are present

Seems like the spacing could be better for the following output. One space between preamble and flag description with an extra space after the flag description.
Usage: /home/dali/source/zphd/zphd-core/.libs/lt-wisdomgenerator <--output=value-o=value|--help|-h>

  Optional flags:
    --output=value/-o=value   The output file to write wisdom to
    --help/-h                 Print usage and options information

Fixed the spacing to be allocated when the "  Required" text is printed instead of after the "Usage: " line.


Intermittent SSID reversion to previous network

Our Android tablet has a wired ethernet connection to a router which serves a private WLAN for the ultrasound, We have an ultrasound service menu, not intended for end-users, which sets the probe to use the appropriate router SSID. Fairly regularly the probe reverts to a different (inappropriate) SSID, which was used many months ago during testing (and is still available in the test area).
It has only been observed at app startup (never during active U/S use), which may correspond to U/S power cycles.
The probe firmware has been reloaded since the bad network was intentionally used, so apparently this (fallback?) network is being stored somewhere hard to forget.
This necessitates use of the service menu to reprogram the probe net, and some of the time the network reverts immediately, when we switch back to the clinical app from the service mode.
We're hoping to understand this behavior, what triggers it, and hopefully how to prevent it. (Otherwise I suppose we can add logic to the normal clinical flow that confirms and re-establishes the SSID if necessary every time we start the app, but that can be pretty time consuming).
Use BLE to configure external network SSID A
Image with probe
Use BLE to configure external network SSID B
Repeat until probe starts up on SSID A:
Use BLE/Solum to power probe on & connect
Image with probe in presence of SSID A
Let probe sleep or power off
Android, Solum 10.4, Android Studio, C3HD

Related to #52?

the probe, when it boots up, will join the first SSID that the wireless driver identifies (not controlled by Clarius); in order to change this behaviour and forget any stored SSIDs, run a factory reset on the probe, the alternative as you suggested, would be to manually connect to the specific SSID you want if the probe is not on the one you want at bootup


No in-string highlighting for C#

At the company I'm working C# is the only option for coding.
In the VSCode extension description I see: "...syntax highlighting embedded in other languages, namely Markdown, Java, Python, Javascriopt, .NET and Go.". Granted .net != C#, but I expected it to be supported.
It works fine if I write a typescript file, so it is installed and working properly otherwise.
I've tried all variants I can think of but there is no highlighting of cypher queries anyway:
Example of variations:

Why don't add setting where we can set file extensions where this highlighting will be applied. I would like if php has support too.


data-uri doesn't work

@jhnns, @sokra one again, it doesn't work, background-image: data-uri('../img/privateinvestocat.jpg');
lessc compiles correctly, but less-loader outputs corrupted image.
Here is data-uri.less:
.data-uri {
  background-image: data-uri('../img/privateinvestocat.jpg');
}

Where ../img/privateinvestocat.jpg is https://octodex.github.com/images/privateinvestocat.jpg
lessc --no-ie-compat test/less/data-uri.less test/less/data-uri.css outputs:
.data-uri {
  background-image: url("data:image/jpeg;base64,/9j/4QAYRXhpZgAASUkqAAgAAAAAAAAAAAAAAP/sABFEdWNreQABAAQAAABkAAD/4QMxaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wLwA8P3hwYWNrZXQgYmVnaW49Iu+7vyIgaWQ9Ilc1TTBNcENlaGlIenJlU3pOVGN6a2M5ZCI/PiA8eDp4bXBtZXRhIHhtbG5zOng9ImFkb2JlOm5zOm1ldGEvIiB4OnhtcHRrPSJBZG9iZ...//Z");
}

but less-loader?ieCompat=false outputs:
.data-uri {
  background-image: url("data:image/jpeg;base64,77+977+977+977+9ABhFeGlmAABJSSoACAAAAAAAAAAAAAAA77+977+9ABFEdWNreQABAAQAAABkAADvv73vv70DMWh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8APD94cGFja2V0IGJlZ2luPSLvu78iIGlkPSJXNU0wTXBDZWhpSHpyZVN6TlRjemtjOWQiPz4gPHg6eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iQWRvYmUgWE1QIENvcmUgNS42LWMwMTQgNzkuMTU2Nzk3LCAyMDE0LzA4LzIwLTA5OjUzOjAyICAgICAgICvVJaSiPvv70L77+9dGjvv73vv73vv70k77+977+977+977+977+9biTvv73vv70S77+9RF0x77+9dO+/ve+/vdu7P++/vXLvv713Ee+/vSbvv73vv71/VWQbf2nvv70/Bxrvv73vv70ix4de77+9Je+/ve+/vTdz77+9aO+/ve+/vXHvv70uPR0TLe+/ve+/vULvv71Jbjbvv71NIceeW2zvv73jiZRy77+9c3Lvv73vv73vv70h77+977+9zY3vv73vv73vv70PU++/ve+/vWvvv73vv73vv71tCe+/ve+/vTNTRGbvv73elTrvv71w77+9Zu+/ve+/vQjvv71s77+977+977+9LUfvv73vv73vv71F77+9ce+/ve+/vWFnN17vv71d77+93rrvv71l77+9G++/vUU1H++/vXTvv73Gv++/ve+/vUFz77+9JQ3vv73vv70177+9RO+/ve+/ve+/ve+/vVHvv73vv73vv70477+977+977+9Uh7vv70cSe+/vV3vv71s77+9JXtNFjBbV++/ve+/vQXvv71e77+9J++/vQzvv73vv70gUzvvv70A77+9YnHvv73vv73vv70W77+9Rz7fk++/vW4r77+977+9Su+/vSrvv73vv70ReO+/ve+/ve+/ve+/ve+/AAAAPvv73vv70=");
}

decoded
lessc: ff d8 ff e1 00 18 45 78 ...
less-loader: ef bf bd ef bf bd ef bf bd ef bf bd 00 18 45 78 ...

@mdreizin you can use url() and the url-loader instead of data-uri().

@sokra Thanks for the response. I know about url-loader and I'm currently using this approach as workaround.
This is strange behaviour after from 0.7.7 to 2.0.0 :(

Agreed, the image should not be corrupted, I can take a look.
But to be honest, using the url() statement + url-loader seems more straightforward to me than using LESS' data-uri().

#43

@jhnns Have you got any progress about this issue?

Sorry, I haven't got the time yet. There were some pretty weird things going on with the sass-loader ^^

Fix shipped with 2.2.2


fix(proxy) give manager leader control over start

What this PR does / why we need it:

Refactors the proxy update and status update subsystems into LeaderElectionRunnables and starts them via manager.Add(). These subsystems now only run when an instance is a leader. This fixes the part of #2052 where enabling leader election would actually attempt to push a null configuration because the proxy update loop was running, but the controllers were not. While the status updater caused no issues (it will simply do nothing when given an empty configuration), running multiple instances of it was pointless.
Removes the --elect-leader flag in favor of determining whether to elect a leader automatically based on the database mode (DB-less does not use leaders, database-backed does). This is a minor breaking change (the controller will reject the removed flag if present). We could optionally leave it as a deprecated no-op flag if we don't want to make the breaking change immediately.
Adds an --election-namespace flag. This is necessary to run integration tests when leader election is enabled, as the controller has no way of determining the election namespace when run outside a cluster. It is unlikely to have any production use.
Adds a new multi-replica Postgres controller test. The test confirms leadership behavior based on whether metrics report that the controller has successfully synced configuration.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2052
Special notes for your reviewer:

Backporting this is iffy, since this fails tests without the new --election-namespace flag. We could remove that and the automatic mode detection, but in that case we simply don't test leader election mode in the backport. This is maybe okay since the flag is only needed for test instances (unless you run leader-election-enabled instances outside the cluster in prod for some reason, but you can't do that with current 2.0.x anyway).
This is a new E2E test that fails against the current version. An example override run versus 2.0.x is available in postgres_replicas.txt. Merging this will cause nightly tests to fail that test. We already have one such test from https://github.com/Kong/kubernetes-ingress-controller/pull/2005. We should decide how we want to handle these better, probably by running nightly E2E against nightly builds.
The admission controller behavior is an open question. We make use of the Kubernetes client to load other resources for the consumer/credential checks. I'm unsure how these behave on non-leaders. This PR shouldn't change anything about that, since it's only disabling proxy updates in addition to the controllers, which were already disabled. However, since leader election was previously a manual flag (and was not in 1.x), it's quite possible that nobody had enabled it to observe any problem behavior. I don't think we can simply disable it because the Service used in the webhook configuration points at the entire Deployment.

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Rebased to roll PR changes into appropriate commits, since we don't want to squash this/will need to cherry-pick pieces into a 2.0.x backport.


[v1.3.1 ] $ionicSideMenuDelegate.toggleLeft() returns again to the same view

In Ionic, v1.3.1
When i use $ionicSideMenuDelegate.toggleLeft() and in the view with the keyboard is visible for input,  returns again to the same view.
This also happens with menu-toggle:
<button class="button button-icon button-clear ion-navicon" menu-toggle="left"></button>

I have the same problem, is there any solution?
Thanks

Hello,
In version 1.3.2 still fails.
In version 1.2.4 and earlier works correctly.
Regards

I downloaded version 1.2.4 for me to work.
Any solution?
Thanks

This issue was moved to driftyco/ionic-v1#114


Appears to be an incorrect color spec

Please verify the version of Auro design tokens you have installed
@latest
Please describe the bug
Please see the screenshot

The color #d4ece4 is a light, soft greenish-blue. This hex color is often described as a mint green or pastel aqua.
Reproducing the error
This issue is reproducible on the Auro docsite
Expected behavior
A gray token should appear gray?
What browsers are you seeing the problem on?
Chrome
Additional context
n/a
Exit criteria
This issue can be resolved once there is a decision made to address the var(--ds-color-base-gray-200) color.

The correct hex is #d4d4d4


Feat/swarinfo 259 handshake request

Added HiveMindAPI, for the user, will always stay internal to the hivemind and it's host. And the SwarmAPI for the ESP side, shouldn't reach the hivemind

It could probably go in another PR, but should we maybe drop the HiveMindHost label? Considering we now have SwarmAPI messages in here


Feature/53 chapter line duplicity control   custom and service chapters

Implemented duplicity logic in form of prefix icon.
Added check for duplicity conditions.
Update of unit tests.

Closes #53

Release notes:

Implemented duplicity logic in the form of prefix icon.


Tagging minor revisions - 3.8.1

With the release of 3.8.1, I'd love to be able to easily update the FROM alpine:3.8 to FROM alpine:3.8.1
and have certainty that's the correct releases image.

FWIW, the tests check this by running cat on /etc/os-release; I know it's not ideal but it would let you check the image you download or are running.
$ docker run alpine:3.8 cat /etc/os-release
Unable to find image 'alpine:3.8' locally
3.8: Pulling from library/alpine
4fe2ade4980c: Pull complete
Digest: sha256:621c2f39f8133acb8e64023a94dbdf0d5ca81896102b9e57c0dc184cadaf5528
Status: Downloaded newer image for alpine:3.8
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.8.1
PRETTY_NAME="Alpine Linux v3.8"
HOME_URL="http://alpinelinux.org"
BUG_REPORT_URL="http://bugs.alpinelinux.org"

I have been checking to see if 3.8.1 was released on Docker Hub because of the vulnerability fix. It would have been nice to know earlier that the new image was available, instead of having to do forensic software archaeology in order to ascertain that the current 3.8 image is actually 3.8.1 and not 3.8.0, despite the insistence that Docker Hub says that this image is over a month old, i.e. pre the 3.8.1 fix.

On the subject of major and minor version tags:
https://medium.com/microscaling-systems/using-docker-tags-to-mess-with-peoples-minds-367bb2c93bd0


Header in wrong position after JQuery Tab activation, reflow does not fix it

I read some of the issues related to header misplacement after switching tabs, but even using reflow on tab activation does not fix it in my case. Here is a JFiddle example:
http://jsfiddle.net/6nrymq8o/
Scroll the table down a bit, switch to another tab (e.g. "Sales Reports") and then switch back to the first tab - the header is drawn at the top of the window, detached from the table. In the JS code, reflow is called on tab activation, but the problem remains.
I am using Chrome 74.

Ah, a jQuery issue with a jsfiddle finally :)
I'll check it out tonight when I get home

Ok, the problem is that you are expecting to use it like overflow scrolling within a div, but actually you are initializing the plugin as window scrolling (the default). It only appears to work properly - you can break it by scrolling within the table and then scrolling the window.
The fix is simple, tell it about the scrolling container:
http://jsfiddle.net/71mvxtnp/1/

Ah, perfect! That fixed it. Tried a number of other solutions, this is the only one that completely works (now that I understand the container issue). Thanks!


Air conditioner partner as an outlet

I have lumi.aircondition.acn05 and buttons were successful created by homebridge-miot.
AC control button and fan level buttons all showed on Homekit app via homebridge.
However, the purpose that I use air conditioner partner is used as an outlet (220V 16A outlet for my boiler).
My issue/problem is how to only create a button for control power on/off without showing/create ac control and fan level buttons.

Currently that is not possible. The device is being reported as an air conditioner hence you have air conditioner specific controls. I would need to think about it and see if i can come up with a solution for that...

Thanks for prompt reply. I think my purpose is a very special use case for AC partner.
But still looking forward for a solution that AC partner can be local controlled in the future.

I mean your device has a lot of configuration properties exposed in spec and i guess some of them are also related to the outlet control. But since it is reported as an air conditioner, unrelated ones are currently ignored since they would just make the ui messy. But yeah i will think about it and see what i can do.

Below is the log from VEVS modified Mihome APP
2021-10-30 16:58:57 -> {"params":[{"siid":14,"piid":1,"did":"409038427","value":true}]} /miotspec/prop/set
2021-10-30 16:58:57 <- {"code":0,"message":"","result":[{"did":"409038427","siid":14,"piid":1,"code":0}]}
2021-10-30 16:59:04 -> {"params":[{"siid":14,"piid":1,"did":"409038427","value":false}]} /miotspec/prop/set
2021-10-30 16:59:04 <- {"code":0,"message":"","result":[{"did":"409038427","siid":14,"piid":1,"code":0}]}
These four lines are related to power on and off.
Hope above information is helpful for your implement.

You can now expose the outlet switch from you air conditioner as a propertyControl in version 1.0.0, i hope that this will solve your issue.

Thanks for your effort and this is really solve my issue.
Now situation is successfully power-on and power-off with two toggles and try to figure out how to set outlet switch status (true - false) in one toggle.

You can just skip the value property for the propertyControl and have one entry, when you do that then you should have 1 toggle switch which does what you want.


Remove libgcrypt.so from shipped system libraries

Looks like libgcrypt.so is not used anymore, so there is no need to ship it. I cannot point out though when/why this dependency was dropped, so please double-check.

It is shipped only when atom-shell is linked to it, and I think libgcrypt.so is still linked to atom-shell now, you can run ldd atom to verify it.

That's what I did and what was the reason for this request:
ldd atom | grep crypt:
libk5crypto.so.3 => /usr/lib/libk5crypto.so.3 (0x00007f8c74336000)
libcrypt.so.1 => /usr/lib/libcrypt.so.1 (0x00007f8c737ba000)
ldd libchromiumcontent.so | grep crypt:
libk5crypto.so.3 => /usr/lib/libk5crypto.so.3 (0x00007fbbd47ae000)
libcrypt.so.1 => /usr/lib/libcrypt.so.1 (0x00007fbbd3c31000)
But I only checked this on my platform (linux-x64) yet.

Interesting, this is what I got:
libk5crypto.so.3 => /usr/lib/x86_64-linux-gnu/libk5crypto.so.3 (0x00007fc8cfba3000)
libgcrypt.so.11 => /lib/x86_64-linux-gnu/libgcrypt.so.11 (0x00007fc8cf306000)

Are you building atom-shell yourself?

That's definately interesting. I didn't build it myself but downloaded the prebuilt version 0.20.5. Also the version included in atom editor is not linked to libgcrypt here. But if in doubt I suggest just keeping the library, at least until there is some definite behavior.
PS: chromium itself is linked against libcrypt and libgcrypt on my machine, so a third variant...


Different response from different OLS servers for the same ontology

I am trying the following two API calls for the same ontology (other ontologies give the same difference) on different OLS servers:

https://service.tib.eu/ts4tib/api/ontologies/cao/terms
https://www.ebi.ac.uk/ols4/api/ontologies/cao/terms

The outputs (JSON) are the same (in structure) from the two servers so I think this is an issue with ols-py.  Here are the outputs I am getting:

The above example and others I have now found indicate the issue is if a field is empty.  Could literal string fields be setup as optionally none?

Hi @stuchalk , do you know if the tib.eu OLS server is using OLS3 or OLS4? I'm not sure if this is a difference arising due to that, I'm only trying to support OLS4 at this point (but ideally they should be compatible).
It's always possible I've misspecified the schema based on limited examples, I'll have a look and see if this can be fixed.

Hi @stuchalk & @marius-mather, we're still using OLS3 as the switch to the OSL4 API needs more work than expected with our setup, so that might be the reason.


Test on different resolutions

Done!

Runs perfectly for all resolutions. Background image resizes for different resolutions.


Laravel 8.x compatibility

This package seems to be locked to Laravel 6.x and 7.x via composer. Is it compatible with 8.x and can composer be updated to reflect this?

Merged: https://github.com/liran-co/laravel-notification-subscriptions/pull/2


loaded Android Gradle Plugin Conditionally

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:
if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).
for more info, you can refer to this thread and especially this comment.

LGTM, done, will be in next release soon.
Thanks for the contribution!


Does scanning continue while advertising

Hi,
We have several devices that communicate via ble advertisements and I am struggling a bit with advertisements sometimes not being "seen" by a another device and am trying to understand what the different settings do and how the ble stack exactly works.
I see in the examples:
// Start advertising
pAdvertising->start();
Serial.println("Advertizing started for 10s ...");
delay(10000);
pAdvertising->stop();

So it is advertising for 10 seconds. Suppose I have enabled scanning indefinitely before the above code :
NimBLEScan::start(0, ....)
Does the 10 second advertisement interrupt the scanning completely for 10 seconds or is the ble stack that intelligent that it continues scanning in between the advertisements defined by the advertisement interval?
And a second question, what would be the recommended values for these methods knowing a device is both scanning and advertising (power usage is not an issue)

Both can be done at the same time but you will want to adjust your window and interval for both scan and advertise so that there is enough time slicing available for each.
You'll need to experiment with the values but I'd start with a 50/50 mix, params :interval 100ms window 50ms for scan and advertising both as a starting point.

thx for the quick answer :-)
What I forgot to mention is that the data is not only sent periodically.
I advertise every 60 secs all data, but want to advertise immediately when a switch is flipped on a device (and want to reduce the chance of missing this to a minimum).
If I use your suggestion there is a chance a 50ms advertising does not get detected in a 50/50 scan/advertise ...?

That's not the advertising duration, just the time inside the interval. The number of intervals is the duration / interval time. So your 10 second duration / 100ms interval time = 100 intervals, so the advertising is happening for 50ms 100 times over 10 seconds.

I am sorry, I have a lot of trouble getting my head around this :-)
This would generate a lot of advertisements with the same data (I only need 1 to go through to the other device)
I am not sure what the bandwidth is of using BLE like this...
Wouldn't  so many advertisements also have influence on receiving signals from other sensors that are also advertising data?
so would it look like this in code?:
//Initialisation
NimBLEScan::start(0, ....); // indefinite scanning (if I understand correctly it stops and starts automatically when advertising?)
NimBLEAdvertising::setMinInterval(100);
NimBLEAdvertising::setMaxInterval(100);

And then in the loop() when it needs to advertise:
if(needsToAdvertise){
  pAdvertising->stop();  //stop any running advertisement as maybe data has changed
  pAdvertising->setAdvertisementData(advertisementData);
  pAdvertising->start(10);
}

Or maybe I could make a setup that the receiving device echo's the data and when the sending device receives it and it is the same it stops advertising...?

Sorry, I was mixing terms with scanning.
The min and max advertising interval is was I meant to refer to, which should be different values. The difference between them gives the rest of the ble stack time to work with the radio.
NimBLEScan::start(0, ....); // indefinite scanning (if I understand correctly it stops and starts automatically when advertising?)
NimBLEScan::setInterval(100);
NimBLEScan::setWindow(50); // scan only for half the interval time to allow for advertising to take place.
NimBLEAdvertising::setMinInterval(50);
NimBLEAdvertising::setMaxInterval(100); // time difference for scan etc..


Add extra-labels to Ring collector

Currently the default labels are [:method :status :statusClass :path].
I would like to have the ability to add extra labels from the request or response.
If this is not the right approach, do you have any other ideas for how to solve it?
Thank you.

@psalaberria002 Thanks for addressing this!
I think there might be a cleaner, more Ring-like way of doing this, namely by using a well known field (e.g. :iapetos/labels) in the request or response map. Then, request labels could be added by middlewares on top, while response labels could be added by middlewares below (or the handler itself). What do you think?

Is this closer to what you were suggesting? It gets labels (specific ns kw) from both the request and the response.
I still don't like the need to define labels when calling ring/initialize. Do you know if this can be done on the fly by some middleware?

@psalaberria002 I don't think you can add labels on-demand since collectors (and thus their labels) have to be registered before they are ever used. I don't see a way of dynamically adding/removing labels in the code or the docs.
As to your implementation: Looking good! Only thing I'm uncertain about is whether :iapetos.collector.ring/labels is maybe a bit verbose/inconvenient to use, so maybe something like :iapetos/labels or a plain :metric-labels might be preferable.

I just wanted to be specific, since these labels are only relevant for ring metrics. Why is :iapetos/labels a better kw? Won't this be confusing? Give me a good reason and I change it ;)

@psalaberria002 Since it's a key within a Ring request or response map I think the "only relevant for ring metrics" part is given by context. Also, :iapetos/labels and :metric-labels are arguably more stable/reusable than tying the key to a specific namespace.
But, maybe the fact that we're arguing about this shows that it's not the correct approach. How do you feel about having an additional :label-fn option instead that takes request and response as parameters and computes the additional metric labels? Cleans up the code a bit and is more flexible than our current approach.

Great idea! Leaving the implementation up to the user sounds more flexible. Will try to have a patch during the day. Thank you for the fast replies.

Any updates on this one?

Release Notes

Great! Thank you.


Searchsecomoney fixes

Description
Fixed a the deployment to mumbai (replaced network with network.name). Also temporarily replaced token transfer with burning to test contract on mumbai. Finally added a temporary function to give tokens to an address to test hash paying.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Bad PR, all temporary changes.


HTTP Shim Read States

This adds the ability to set URLs to read the powered state and brightness state.
This is starting to get a little weird. While the commands (on, off, setBrightness) were easy, because they simply hit a url and thats it...reading is more complicated. This is an abstract implementation, but at the same time, we need to somehow be specific in order to fetch values.
Since we're reading something, we have to decide how we want this to work. Somehow the value has to be read and passed back.
As it is now, all the functions do is return the WHOLE body from the GET request. Kinda jank.
Value Fetching Options
So I think there's 3 options here:

Just return the body of the response, and make people understand they have to return a single value in their respones.
Specify a key that people need to use in their response (this assumes JSON) that we'll read from.
Add a specific read key in the config.json that would be used to traverse JSON to fetch a key.

In the first two, it pretty much assumes the user has to control the response (hitting their own server they have control over). The third option means they can sort of specify things in a little more detail. But can this be reliable? What happens if the value they need to get to is inside an array or something.
This is all really tricky.
Comments verrrrrrry welcome.

Oh, I didn't realize that the HTTP accessory was masquerading as a "light bulb" - that's a bit strange. Although I'm not sure what else would be appropriate besides "switch".
For reading state, I would worry that options 2 and 3 will lead us into a path of adding more and more parsing features and "language" for extracting and converting whatever existing APIs people are trying to use.
Although maybe it could be made generic enough by having you write a regex or something - if it matches, then it's on? Although that doesn't help with brightness.
This is pretty squirrely!

Oh, I didn't realize that the HTTP accessory was masquerading as a "light bulb" - that's a bit strange. Although I'm not sure what else would be appropriate besides "switch".

Yeah, the plan was to actually add more and more device types, so there could also be up_url, down_url, so you could control all the types with the different commands. Commands here being "what word do you want to say".
The idea of the HTTP shim was that it would allow you to quickly hack out accessory support for yourself, without having to:

create your own shim
worse, create own lib if there wasn't one already.

It would just allow anyone to come in and drop in the URLs that need to be hit and voila.
There of course is, no authentication story, lol. Again, this was a first quick pass to get something going. And it was all fine when they were blind requests shooting off to turn things on/off.
 So you can just use it as a hack. Sort of what #5 was asking for.
BUT, this all falls apart for reads.
So, it seems to me, that if you're going this far in depth with reads, shouldn't you just make your own shim that just uses the request object on it's own, doing the domain specific stuff? Probably so :/

For reading state, I would worry that options 2 and 3 will lead us into a path of adding more and more parsing features and "language" for extracting and converting whatever existing APIs people are trying to use.

Boy do I agree with that.

Although maybe it could be made generic enough by having you write a regex or something - if it matches, then it's on? Although that doesn't help with brightness.
This is pretty squirrely!

Ok, so maybe I made some points up top, and this shim shouldn't even HAVE read. Maybe it should exist solely for shooting off requests. By not supporting it at all, we don't have to debate anything, lol. I'm a fan of not doing anything at all unless there's a solid logical thing to do.
As another argument for keeping this shim, the new IFTTT Maker channel that supports webhooks would still work totally fine using this simple HTTP shim. So yeah, maybe we should just keep it simple like it was before.

Good points. I think that a generic HTTP shim is more useful the simpler it is. If it gets complicated and supports lots of device types and reading/parsing then you're just spending a lot of time writing config files instead of just writing code :)

Yeah, ok, I'm gonna just close this.


[Bug]: Market Data API - Random Server Outages?

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I have been using the market data api with an unlimited subscription. Specifically, I have been using the alpaca-py SDK and trying to get historical data for about 500 companies during a given time period. I run a request in the following format:
request_params = StockBarsRequest(
                        symbol_or_symbols=tick_list,
                        timeframe=timeframe.TimeFrame(30, timeframe.TimeFrameUnit['Minute']),
                        start=datetime.datetime.now(tz=pytz.timezone("UTC"))-datetime.timedelta(30),
                        end=datetime.datetime.now(tz=pytz.timezone("UTC"))
                 )
bars = alpaca_client.get_stock_bars(request_params)

where tick_list is a list of strings corresponding to stock tickers. In many instances, I get an internal server error like this one:
{"code":50010000,"message":"internal server error occurred"}
However, this does not always occur. For example, I ran this same query a few moments later and it ran fine. Is there a rate limit that I am hitting? If so, I would have expected to get a 429 error. The status page (https://status.alpaca.markets/) didn't seem to indicate any server outage either. Does anyone know what might be going on?
Expected Behavior
No response
SDK Version I encountered this issue in
0.6.0
Steps To Reproduce
1. Set up StockBarsRequest with query tickers, timeframe, start and end data
2. Run alpaca_client.get_stock_bars

Filled out the Steps to Reproduce section?

[X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?
No response

This was due to an API issue that happened yesterday.


allow WorkloadEntry port mapping to use regular port name

In the current state, a workload entry with
ports:
  grpc: 17070

and a service with:
ports:
- name: grpc
   port: 7070

does not result in the port mapping resulting with 17070 in eds

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9e509ceb05b3bd94afc22cae3f9430d8b3a0d4ff
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9e509ceb05b3bd94afc22cae3f9430d8b3a0d4ff
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
9e509ceb05b3bd94afc22cae3f9430d8b3a0d4ff
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
9e509ceb05b3bd94afc22cae3f9430d8b3a0d4ff
link
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
b309e496a188747bcb9e4f54a087af78f0fcdd98
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bc0f73b9a00700d932744336e8763e6d5cf56df1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test unit-tests_istio

integ-operator-controller-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
fda54df6d5be0d51650ce0e88534979f95c7a509
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
8909fc4cb08a696db3c444a27b996660ed9c6332
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu @howardjohn ping

In response to a cherrypick label: #33774 failed to apply on top of branch "release-1.11":
Applying: allow WorkloadEntry port mapping to use regular port name
Applying: try traffic shifting integration test with proxyless
Using index info to reconstruct a base tree...
M	tests/integration/pilot/common/routing.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/common/routing.go
No changes -- Patch already applied.
Applying: Revert "try traffic shifting integration test with proxyless"
Applying: more logs
Using index info to reconstruct a base tree...
M	pkg/test/framework/components/echo/kube/deployment.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/test/framework/components/echo/kube/deployment.go
CONFLICT (content): Merge conflict in pkg/test/framework/components/echo/kube/deployment.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 more logs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #34180


[WIP] Introduce recursive events: events can now be triggered from within modules

@spuds there we go: recursive events... actually probably it would have been better to call them nested? Yeah. Whatever.
I thought thi was going to solve the issue with attachments you were facing, but it doesn't, though it looks pretty cool to me, so I just pushed it... let me know what you think. :laughing:

Codecov Report

Merging #3621 (a6bb97d) into development (f8e2423) will decrease coverage by 0.04%.
The diff coverage is 28.26%.

@@                Coverage Diff                @@
##             development    #3621      +/-   ##
=================================================
- Coverage          30.64%   30.60%   -0.05%
- Complexity         15876    15927      +51
=================================================
  Files                427      429       +2
  Lines              74288    74311      +23
=================================================
- Hits               22768    22745      -23
- Misses             51520    51566      +46

Impacted Files
Coverage Δ

...rces/ElkArte/AdminController/ManageAttachments.php
9.55% <0.00%> (ø)

sources/ElkArte/AttachmentsDisplay.php
0.00% <0.00%> (ø)

sources/ElkArte/Controller/PersonalMessage.php
23.91% <ø> (+0.05%)
:arrow_up:

sources/ElkArte/Controller/Post.php
41.75% <0.00%> (ø)

sources/ElkArte/Controller/ProfileOptions.php
13.48% <0.00%> (+0.08%)
:arrow_up:

sources/ElkArte/Controller/Register.php
36.78% <ø> (-0.15%)
:arrow_down:

sources/ElkArte/Controller/Search.php
0.00% <ø> (ø)

sources/ElkArte/IlaIntegrate.php
3.79% <ø> (+0.16%)
:arrow_up:

...Arte/Mentions/MentionType/AbstractEventMessage.php
21.73% <0.00%> (-2.08%)
:arrow_down:

...urces/ElkArte/MessagesCallback/DisplayRenderer.php
90.00% <ø> (-0.20%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18fc6ab...a6bb97d. Read the comment docs.

I think this is very cool .... When I was first playing with the micro data I was thinking it would be nice if I could trigger an event from the code !

Spuds wrote on 3/29/22 12:31 AM:

I think this is very cool .... When I was first playing with the micro
data I was thinking it would be nice if I could trigger an event from
the code !

Little question: while working on this, I assumed that the trigger in
the addon, should pass the states of the addon itself, not those of the
controller, reason is the "addon of the addon" should be extending the
addon and not the controller, otherwise it should hook up into the
controller itself.
@spuds do you think the reasoning works or should it always pass the
states and variables of the controller?

I think that makes sense, I'd be able to give a better answer if (when) I work on an addon that utilizes the functionality, but rolling it around in my head extending the addon seems proper.

Thank you for your kind information. Happy to learn from you all. It'd be cool if you get the latest news update.


overview: Add to checks

Building the overview website is not very expensive (a lot cheaper than NixOS tests) but can catch some errors since it evals all modules.

Don't get distracted by the failed deployment, I forgot to disable deploying for branches other than main, but at the same time also protected the deployment, resulting in an error to deploy. That's unrelated to this PR and fixed.


[Bug]: The left side seems to be distorted like some white space always remains

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
[Bug]: The left side seems to be distorted like some white space always remains
Check screenshot please...
Expected behavior
It must no show that space, the site must cover the entire device width, need to make changes in the styling of it
Add ScreenShots

On which device are you experiencing this bug?
Android, iPhone, Windows
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

Hey, I won't be able to work on this issue anymore, due to certain reasons.
So this issue is open for anyone to take over and work on.

Can i work on this issue?


implement unit and integration tests

As well as unit tests, we should probably run integration tests against a docker image of the omada controller

It would be ideal if we could run integration tests against https://hub.docker.com/r/mbentley/omada-controller
It might be very difficult to emulate a network/mock out the data, will need some investigation.


ByteBuf Output Stream Reference Count Ownership

Motivation:
Netty provides a adaptor from ByteBuf to Java's OutputStream interface. The JDK Stream interfaces have an explicit lifetime because they implement the Closable interface. This lifetime may be differnt than the ByteBuf which is wrapped, and controlled by the interface which accepts the JDK Stream. However Netty's ByteBufOutputStream currently does not take reference count ownership of the underlying ByteBuf. There may be no way for existing classes which only accept the OutputStream interface to communicate when they are done with the stream, other than calling close(). This means that when the stream is closed it may be appropriate to release the underlying ByteBuf, as the ownership of the underlying ByteBuf resource may be transferred to the Java Stream.
Modification:
Add the parameter releaseOnClose to ByteBufOutputStream.
Result:
ByteBufOutputStream can assume reference count ownership so the underlying ByteBuf can be cleaned up when the stream is closed.
Related issue: #13985

@finefuture can you please sign our icla https:/netty.io/s/icla

@finefuture also consider adding a test

@finefuture thanks!


Freezed update

Hi, @ookami-kb
Could you be so kind to update the version of freezed you are using?
Currently I'm getting this error:
storybook_flutter 0.7.0+1 depends on freezed_annotation ^0.14.1
This is quite an old feature (current is 1.0.0) and it will be nice to have the most up to date on! Thanks in advance!

Hello, not just freezed all dependencies would be awesome!
I'm specially looking for device_frame

Yeah, makes sense, will do.

I've bumped device_frame to ^0.6.0 and freezed_annotation to ^0.15.0 (cannot bump it to 1.0.0 since it conflicts with device_frame).

There's a little difference between 0.15.0 and 1.0.0. Thank you very much!

Hi there, @ookami-kb ! As far as I can tell, device_frame has updated freezed to 1.0.0. Could you update your package as well?

Hi, @ookami-kb ! Any news on the update?

Heym device_frame has some breaking changes in the latest version, so I didn't change it for now.
Next major storybook_flutter version with refactored API will have it bumped.


raftstore,server: add enable_v2_compatible_learner config

The new config is added to clean up hard code tiflash check

What is changed and how it works?

Issue Number: ref #14579
What's Changed:

raftstore,server: add enable_v2_compatible_learner config

The new config is added to clean up hard code tiflash check

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test

Release note
None

/merge

/test