Add Docker support to install the service

Right now it installs OE Tookits on raw Ubuntu. But hopefully soon
OE Tookits is going to be available as its own Docker image. It
depends on this PR: https://github.com/oess/docker-images/pull/1

@ctapobep Merged in your PR and added a bit. Check out oetk_py2 or oetk_py3 images and see if that would work.
https://hub.docker.com/u/openeye/dashboard/

Tried oetk_py3 - it worked. Updated the PR to depend on the oetk_py3.

So far I created a DockerHub repo https://hub.docker.com/r/ctapobep/oe-microservices/
If you merge this PR, you could create a repo with a more official-sounding name :)

Nice!
@ctapobep I'm happy to set up an automated build at openeye/oe-microservices if it would be helpful

That would be cool. Though I don't know how you version that in Python world. In Java I assign versions like this for every build: 1.0-20110506.110000-1 - thus each build/image has a unique version that I can reference and be sure it won't point to anything else in the future.

I'm confused, do you mean version the docker container or version the underlying python?

Version of the docker image :) You mentioned automated builds for docker images, right?


Fix/tests

Fixed a race condition between the test fixture set up and the actual tests
There's no need to delete the curations as it is part of the collection
Implemented test to delete api key

@brianweet looks great, thank you for the contribution!


Get rid of Coffeescript

I think this makes the platform less extensible, less likely to be worked on by other contributors, and more confusing for me.
@harlantwood Are you very attached to coffeescript?

Not at all!  Happy to see it go es6+

Sweet. Ok then! That makes this a bit easier.


update issue body template

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/1159
Description of changes:

steps to fix should be: update go.mod, run go mod tidy, then generate controller with latest. Verified when resolving above issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you! I had a TODO for it 😅  Appreciate your bias for action!
/lgtm


Bugfixes/Improvements on current multiplayer game

(~200 points)

The multiplayer clients and server do not disconnect and close upon exit of the game. Make it so they will exit gracefully, and/or take the user back to the main menu.
The multiplayer version of the game does not handle the case where a player reaches 0 chips. (Check the single player version of the game for how this should be handled.)
The chat client does not keep track of player IDs. Possibly allow the player create a nickname to be displayed when they talk in chat.

W16 OK

Also handle bad-input cases. For example when the user inputs an invalid IP address to connect to, the main window exits, but the process keeps running. All such cases should be handled gracefully.

F16 OK (200 pts)

F16 CLOSED: The multiplayer element was removed in M16


Register alicloud nacos binding component

Description
It seems that  forgot to add,  Add alicloud nacos binding component
https://github.com/dapr/components-contrib/tree/master/bindings/nacos

Issue reference

Please reference the issue this PR will close: #[https://github.com/dapr/dapr/issues/5873]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

I just realized there is an issue with the nacos-go-sdk and I will try to confirm  it.https://github.com/dapr/dapr/issues/5873

First, let's review the previous issue and the code fragment that was fixed.
https://github.com/dapr/dapr/pull/3212
nacos-sdk-go issue
https://github.com/nacos-group/nacos-sdk-go/issues/250
nacos-sdk-go fix
https://github.com/nacos-group/nacos-sdk-go/pull/251/files
Before the issue was fixed, the nacos-go-sdk would initialize a map and establish a goroutine during the init() function.
https://github.com/nacos-group/nacos-sdk-go/pull/251/files#diff-3f155c99c6b9cfd0acfbb7bcc7a22c3384d0c5400130670f6966ef899de0a7fdL79-R81
After the fix, the map and goroutine are only created when they are actually used, which ensures that the nacos component does not consume additional resources in Dapr when it is not being used.

At the same time, I also monitored the differences between running the nacos-go-sdk with the same code before the fix and with the latest version.
before fix
code
https://github.com/liu-song/registry-nacos/tree/beforefix/example/basic/server
nacos-go-sdk version
https://github.com/liu-song/registry-nacos/blob/beforefix/go.mod#L9
latest  versioin
code
https://github.com/liu-song/registry-nacos/blob/latest/example/basic/server/main.go
nacos-go-sdk version
https://github.com/liu-song/registry-nacos/blob/latest/go.mod#L10

The above code is a simple example using Kitex as an RPC framework and Nacos for service registration and discovery. The section before the blue dotted line shows the code running with the "beforefix" version, and the section after the line shows the code running with the latest version.
My computer has a configuration of 16GB RAM and 8 cores. From the graph, we can observe that the memory usage of the program ranges from 0.1% to 0.13%, the number of goroutines ranges from 11 to 16, and the CPU usage ranges from 0% to 2%, with most of the time spent at 1%.
One noteworthy point is that the latest version has reduced the number of times the CPU usage reaches 2%, indicating that the new version of nacos-go-sdk can reduce some CPU consumption. Overall, using nacos-go-sdk correctly does not result in excessive resource consumption.
Finally, if the binding  nacos is actually applied and brings additional resource consumption, providing more code information, conditions for reproduction, or pprof data can help us address the issue and make nacos-go-sdk more robust.

Could you please review this issue again?   :grin:
@shubham1172 @yaron2 @berndverst @mukundansundar

Do I need to provide any other additional information?

I think we still need this?

Are we still interested in this? Otherwise, I think we should just remove the component from components-contrib

There may not be a significant demand, so temporarily close it.

Opened https://github.com/dapr/components-contrib/pull/3118 to delete the component's code


Add ABCI crate

Closes #29
This draft PR contains a very simple end-to-end example of a Tokio-based (async) ABCI server that currently only supports the Echo request/response. Goals for this PR:

[ ] Add support for all ABCI requests/responses
[ ] Provide a simple testing framework for testing ABCI apps
[x] Provide an async ABCI client
[x] Support for async-std
[ ] Support for a simple multi-threaded ABCI app (non-async)
[ ] Support for a synchronous ABCI client (non-async)

The goals above are listed in decreasing order of importance.

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGELOG.md

fyi @devashishdxt

Hi @thanethomson, did you take a look at #489?

Hi @thanethomson, did you take a look at #489?

Yes I did, thanks! I wanted to compare your solution to my own take on the problem. I have a few significant architectural differences in mind, but needed to build them out first to be able to articulate them clearly.
As for which solution we'll end up merging, that's yet to be decided.

Codecov Report

Merging #750 (febdf3e) into master (4000253) will increase coverage by 0.0%.
The diff coverage is 75.2%.

@@           Coverage Diff           @@
##           master    #750    +/-   ##
=======================================
  Coverage    50.6%   50.6%
=======================================
  Files         197     215    +18
  Lines       13587   14231   +644
  Branches     3246    3359   +113
=======================================
+ Hits         6876    7215   +339
- Misses       6348    6623   +275
- Partials      363     393    +30

Impacted Files
Coverage Δ

abci/src/result.rs
0.0% <0.0%> (ø)

abci/src/server.rs
0.9% <0.0%> (ø)

proto/src/lib.rs
76.3% <ø> (ø)

tendermint/src/error.rs
23.0% <0.0%> (-10.3%)
:arrow_down:

tendermint/src/abci/request/echo.rs
47.6% <47.6%> (ø)

tendermint/src/abci/request/info.rs
50.0% <50.0%> (ø)

tendermint/src/abci/response/echo.rs
52.3% <52.3%> (ø)

abci/src/client.rs
62.5% <62.5%> (ø)

abci/src/application/echo.rs
68.7% <68.7%> (ø)

tendermint/src/abci/response.rs
70.5% <70.5%> (ø)

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4000253...febdf3e. Read the comment docs.

Codecov Report

Merging #750 (febdf3e) into master (4000253) will increase coverage by 0.0%.
The diff coverage is 75.2%.

@@           Coverage Diff           @@
##           master    #750    +/-   ##
=======================================
  Coverage    50.6%   50.6%
=======================================
  Files         197     215    +18
  Lines       13587   14231   +644
  Branches     3246    3359   +113
=======================================
+ Hits         6876    7215   +339
- Misses       6348    6623   +275
- Partials      363     393    +30

Impacted Files
Coverage Δ

abci/src/result.rs
0.0% <0.0%> (ø)

abci/src/server.rs
0.9% <0.0%> (ø)

proto/src/lib.rs
76.3% <ø> (ø)

tendermint/src/error.rs
23.0% <0.0%> (-10.3%)
:arrow_down:

tendermint/src/abci/request/echo.rs
47.6% <47.6%> (ø)

tendermint/src/abci/request/info.rs
50.0% <50.0%> (ø)

tendermint/src/abci/response/echo.rs
52.3% <52.3%> (ø)

abci/src/client.rs
62.5% <62.5%> (ø)

abci/src/application/echo.rs
68.7% <68.7%> (ø)

tendermint/src/abci/response.rs
70.5% <70.5%> (ø)

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4000253...febdf3e. Read the comment docs.

Is there a timeline for merging this? There is a team asking when they can use tm 0.34 with a rust ABCI.

Is there a timeline for merging this? There is a team asking when they can use tm 0.34 with a rust ABCI.

Is there a timeline for merging this? There is a team asking when they can use tm 0.34 with a rust ABCI.

I'm still working on it at the moment. It's a little uncertain right now due to some Rust-related technicalities.
What're their requirements? e.g. do they want a sync/async interface? If async, which runtime(s) do they want support for? That way I can prioritize the features accordingly and possibly get something workable out sooner.

Is there a timeline for merging this? There is a team asking when they can use tm 0.34 with a rust ABCI.

I'm still working on it at the moment. It's a little uncertain right now due to some Rust-related technicalities.
What're their requirements? e.g. do they want a sync/async interface? If async, which runtime(s) do they want support for? That way I can prioritize the features accordingly and possibly get something workable out sooner.

They do not have a specific need for one runtime over another. They are building out a minimal app for their needs, but it is unclear which interface they need (sync/async interface)

They do not have a specific need for one runtime over another. They are building out a minimal app for their needs, but it is unclear which interface they need (sync/async interface)

FYI, I've pushed changes with support for both, sync and async, APIs for building ABCI server in abci-rs. Here's a link to its documentation.

FYI, I've pushed changes with support for both, sync and async, APIs for building ABCI server in abci-rs. Here's a link to its documentation.

FYI, I've pushed changes with support for both, sync and async, APIs for building ABCI server in abci-rs. Here's a link to its documentation.

Thanks for letting us know @devashishdxt! I wanted to find out from you, what's the rationale behind having separate traits for each of the connections in abci-rs?

I wanted to find out from you, what's the rationale behind having separate traits for each of the connections in abci-rs?

As mentioned in the ABCI documentation, tendermint creates 4 separate connections and each connection sends different types of requests. The advantage of having 4 different traits is that we can execute each tendermint connection in their respective async task (similar to sync threads). So, for example, once tasks for each connection have started, the code will not allow non-consensus requests on consensus connection and will return an error in case it receives a non-consensus request.

The advantage of having 4 different traits is that we can execute each tendermint connection in their respective async task (similar to sync threads).

Interesting idea. I'm still not sure of the benefits of the approach given the additional complexity.
My personal preference is a handle/driver architecture, such as in this kvstore example app, which allows me to more easily reason about the application as a deterministic state machine (where all application state is encapsulated in a single thread, but accessible from multiple networking threads).

Interesting idea. I'm still not sure of the benefits of the approach given the additional complexity.
My personal preference is a handle/driver architecture, such as in this kvstore example app, which allows me to more easily reason about the application as a deterministic state machine.

I agree that having one trait to implement all the ABCI functionality is much more simpler. But, having 4 different traits makes the ABCI server implementation more accurate as compared to ABCI specification. In addition to this, it is also more robust against buggy tendermint implementation as it'll be able to find out deviations from specifications.

where all application state is encapsulated in a single thread, but accessible from multiple networking threads

I'm not sure what you mean by this.

It seems like if you you should be able to mix and match these strategies, e.g. having 4 traits but one type that impls them if you so desire

It seems like if you you should be able to mix and match these strategies, e.g. having 4 traits but one type that impls them if you so desire

Agreed. We can also create a super-trait, which, when implemented, auto implements all 4 traits.

Closing in favour of #794
I'll keep this branch for now to keep track of the Runtime trait-based approach.


WindowsPB - Nvidia Cuda 9.0 Toolkit No Longer Available From NVIDIA

Whilst running the Windows Playbook, the Nvidia_Cuda_Toolkit task fails, as the download of the Nvidia Cuda 9.0 toolkit is no longer available.
https://developer.nvidia.com/compute/cuda/9.0/Prod/network_installers/cuda_9.0.176_windows_network-exe
I believe this is only required for openJ9, @AdamBrousseau  have you encountered this, or do you have any workaround etc?

Looks like those links went dead recently. We ran them not long ago without issue. We could probably find a download link somewhere else? We have a copy of it locally but I'm not sure if we'd want to host it. Might be legal implications of redistribution as well.
It seems v11.8 is the current release.
@keithc-ca what is the feasibility of moving OpenJ9 up to Cuda v11?

CUDA 9.0 is still available at https://developer.nvidia.com/cuda-90-download-archive.
It seems the name of that specific download is now

https://developer.nvidia.com/compute/cuda/9.0/Prod/network_installers/cuda_9.0.176_win10_network-exe

Seems the other releases are there. Only the 9.0 is not from what I've seen so far. Perhaps we need to contact nvidia. They have a forum.
https://forums.developer.nvidia.com/c/development-tools/cuda-developer-tools/285

https://forums.developer.nvidia.com/t/broken-download-links-for-cuda-toolkit-9-0-windows/234422

Thanks @AdamBrousseau ,  I'll keep an eye on that thread, in the short term, I do have a copy of the full Cuda 9 installer (1.4Gb), @sxa, what do you think about hosting this in the Vendor_Files, until a more permanent solution is found ?

@keithc-ca / @AdamBrousseau  would switching to one of the CUDA v9 services packs ( 9.1 or 9.2 ) be an option both of those are still available.

Using 9.1 instead of 9.0 would only drop support for 9.0, but hopefully, removal of 9.0 downloads was just an error that Nvidia will correct.

@sxa for the official nvidia download for the full exe install, thats no longer available, the checksum is listed as
48d85427ddb4c0eae8ee46aea9d3126e cuda_9.0.176_windows.exe ( from https://developer.download.nvidia.com/compute/cuda/9.0/Prod/docs/sidebar/md5sum-4.txt )
my download is exactly the same (at least md5 checksum identical...)
[scfryer@scfryer Downloads]$ md5sum cuda_9.0.176_windows.exe
48d85427ddb4c0eae8ee46aea9d3126e  cuda_9.0.176_windows.exe
[scfryer@scfryer Downloads]$

I had a chat with @AdamBrousseau and @keithc-ca today - let's bump to 9.1. We can revert if we need to later. OpenJ9 are using machine snapshots in IBM Cloud that already have the version they need so they still have 9.0 but would be affected if they had to rebuild an image.
@steelhead31 Can you handle bumping it to 9.1 please?
I think we should probably keep a copy of the original installer around just in case though ...

Just to confirm: the plan is to stay with version 9.0, but use a working URL; it shouldn't matter which version Windows it was intended for, the build only needs a small subset of the header files (which should be the same, even on Linux).

I've tested the windows 10 version of the 9.0 cuda installer on windows server 2012, it throws this error..

Did you try using the installer like in the playbook (where it doesn't try to install the driver)?

network-exe.exe -s compiler_9.0 nvml_dev_9.0

Actually, we don't even need the compiler, that argument could be replaced by cudart_9.0:

network-exe.exe -s cudart_9.0 nvml_dev_9.0

Also, as noted https://github.com/eclipse-openj9/openj9/issues/16463#issuecomment-1348880691, if the only problem is on Windows 2012, we should be able to safely drop support for that environment.

I've tried passing the compiler parameters and the cudart parameters with no success, I've also tried to override the pre-requisite operating system check with no success.

If https://github.com/eclipse/omr/pull/7088 is accepted, the version of CUDA used at build time will have no relevance for the versions that are supported at runtime. For example, building with 9.1 will still allow use on a system where 9.0 (or even older) is present.

Also, as noted eclipse-openj9/openj9#16463 (comment), if the only problem is on Windows 2012, we should be able to safely drop support for that environment.

@keithc-ca Related to this, we've started shifting the Temurin builds over to Windows Server 2022 - is that ok for all versions of OpenJ9 too?

We discovered a minor problem on Windows 11 (fixed via https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/630).
Windows Server 2022 should be fine, but we'll want to fix any issues building there, so do let us know if you encounter any problems.


Add support for oracle linux 8.

Oracle's yum repos are fairly slow for me so this sometimes times out. More problematically, the containerd install portion doesn't work on ol8 and I haven't quite tracked the problem down yet.

I'd like to propose a bit of a refactor that gets the containerd stuff working and improves the user experience by getting around some of Oracle's slow repos: https://github.com/chrisperelstein/lima/commit/9f69c67d966d9c374d9e28f578660f3a5f24cda6

setting different flags for ol8 fixes slow repo issues but using an unquoted variable for this triggers https://github.com/koalaman/shellcheck/wiki/SC2086. i could do a bunch of conditionals but the wrapper function seemed cleaner.
containerd/nerdctl install didn't work due to ol8 apparently not including tar, so added a block to ensure that's present

I think it may be much better.

It is better if it works better :)
I've added some stylistic comments on the commit.

including tar, so added a block to ensure that's present

I don't see any block dealing with tar.

I addressed the comments and squashed everything down. This is the tar block I was referring to: https://github.com/lima-vm/lima/pull/700/files#diff-4437bfd3c932c2cb558d7385a2505f76bfeb6ec8675520940cf0fdb1b60239deR50. I've re-tested the current version locally and it worked for both Oracle Linux 8 and Fedora.

I think it may be much better.

It is better if it works better :)
I've added some stylistic comments on the commit.

including tar, so added a block to ensure that's present

I don't see any block dealing with tar.


feat: provide wrapper to add plugin

It simplifies stuff. Users just need to import withMermaid in their VitePress config and wrap their config with it. It's similar to what we are doing in other plugins (https://github.com/userquin/vite-pwa-vitepress-integration for example). The changes are backward compatible - MermaidMarkdown and MermaidPlugin are still exported.

That's awesome..
I'll wait a little to publish since this would be a breaking change..
but only one library can do it at a time right? since is an object and not an array like plugins..

I'll wait a little to publish since this would be a breaking change..

This is not exactly a breaking change, we are recommending something new now, but the older usage (plugin in vite config file and markdown config in vitepress one) should still work fine.

but only one library can do it at a time right? since is an object and not an array like plugins..

Not exactly. One can wrap them any number of times.
Suppose if someone wants to use that pwa plugin (assuming that it has wrapper withPwa) and you've withMermaid, then the user can write:
export default withPwa(withMermaid({
  // vitepress stuff ...
  pwa: {},
  mermaid: {}
}))


Record minimum required Node version

lib/load-logos.js uses Buffer.from(string) added in 5.10.0
https://nodejs.org/dist/latest-v6.x/docs/api/buffer.html#buffer_class_method_buffer_from_string_encoding

Hi, thanks for this. We're also using let and const which require Node 6, so we should bump it up to that.

@paulmelnikow I am on Vista with Node 5 being the latest version supported, so it is a pity that shields don't work on it anymore.

Sorry about that. Maybe you can use Docker, or an older version of Shields.

The Docker file specifies Node 6.4 (https://github.com/badges/shields/blob/master/Dockerfile) so I suspect contributors should be using Node 6.x at a minimum as that's the version that's being used in prod. Node 5 is EOL now (see https://github.com/nodejs/LTS) so we shouldn't suggest it.

I am on Vista with Node 5 being the latest version supported

I'm sorry to hear 😢
Docker might work (like @paulmelnikow mentioned), or a virtualization environment like VirtualBox.

VirtualBox doesn't work, because of my CPU doesn't support VT-x or something.

By the way, the servers are using 6.2.1 or later.
AFAIK the the servers are bare Linux, not Docker, by the way. The Dockerfile is included for benefit of users who want to self-host an installation of Shields.

@techtonik Again I'm sorry about your dev setup, and hope you can find another environment to work in.
Closing in favor of #972.

AFAIK the the servers are bare Linux, not Docker

Correct.

I would merge the change and then just bump the version with another explanation on top of it. But it is nice cool that I myself triggered the head shot to run shields.io on my system if it was a hard requirement.

The decision to drop Node 5 was made a month ago, and the tests haven't run in Node 5 for much longer. You could try Node 5.10 with the --harmony flag, though I can't make any promises about that. The only thing you "triggered" was documenting this, which was overdue.


Regression: get_weights_col_packed_qkv() quantize parameter not included in calls so fails with error missing positional parfameter - merge error?

System Info
Python 3.10
current main branch
probably version 2.1.0 to 2.1.1
Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
https://github.com/huggingface/text-generation-inference/blame/main/server/text_generation_server/utils/weights.py line 260
This function's third parameter is the quantize parameter
def get_weights_col_packed_qkv(
        self,
        prefix: str,
        quantize: str,
        num_heads: int,
        num_key_value_heads: int,
    ):

https://github.com/huggingface/text-generation-inference/blame/main/server/text_generation_server/layers/tensor_parallel.py line 151
This call to the function get_weights_col_packed_qkv() is missing the quantize parameter
weight = weights.get_weights_col_packed_qkv(
          prefix,
          num_heads=num_heads,
          num_key_value_heads=num_key_value_heads,
      )

There is also another place in the code that is missing the parameter
We can see in this change set that the quantize parameter was present https://github.com/huggingface/text-generation-inference/commit/85dfc39222798b75559c891789283de23c679ca5  and here https://github.com/huggingface/text-generation-inference/blob/85dfc39222798b75559c891789283de23c679ca5/server/text_generation_server/layers/tensor_parallel.py looking at tensor_parallel.py
       weight = weights.get_weights_col_packed_qkv(
            prefix,
            quantize=config.quantize,
            num_heads=num_heads,
            num_key_value_heads=num_key_value_heads,
        )

I don't know what happened with the merge if that is it.
Found this trying to run the Nvidia RAG container in AI Workbench.  This was in the logs
 File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 150, in __init__
    self.query_key_value = load_attention(config, prefix, weights, index)
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 66, in load_attention
    base_layer = TensorParallelColumnLinear.load_qkv(
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/layers/tensor_parallel.py", line 151, in load_qkv
    weight = weights.get_weights_col_packed_qkv(
TypeError: Weights.get_weights_col_packed_qkv() missing 1 required positional argument: 'quantize'
2024-07-15T02:50:15.716159Z ERROR shard-manager: text_generation_launcher: Shard complete standard error output:

Expected behavior
The call to get_weights_col_packed_qkv() should work but it is failing from tensor_paralle.py

When is the next release that includes this fix?


add "call" under Windows upon generator call

Under Windows, when cmake generates .vxproj, the call to the custom command must be done using "call" otherwise there is no return and the file is not generated. See https://github.com/nanopb/nanopb/issues/873

What happens if PROTOBUF_PROTOC_EXECUTABLE is an actual protoc.exe instead of protoc.bat?

It works - you can use "call" for an exec or a batch

Ok, thanks for confirming. Looks good to me.


Rev actions

What's the status of this PR, is it ready for a review?
I didn't see any description so I wasn't sure what to do with it.

Oh, are descriptions an indicator people use like that?
I just assumed requesting a reviewer was enough to indicate I was requesting review. I will open things as draft to prevent auto-review-request if it's not ready. And/or explicitly request on a draft if I wanted early eyes. I almost always do add description, of course, but this one didn't feel like it needed anything as it's just some obvious house-keeping. I don't really consider that related to readiness :shrug:
Sorry about the confusion!


Fix placeholder for Tables TextColumn

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Same thing as https://github.com/filamentphp/filament/pull/8080.

Dup #7439


fix: 修复数据为 0 时动画更新出错

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

饼图存在空数据时 sector-path-update 会导致动画超出画布。

before
after

https://github.com/ant-design/ant-design-charts/issues/574

https://github.com/ant-design/ant-design-charts/issues/295

Pull Request Test Coverage Report for Build 754544481

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 93.575%

Totals

Change from base Build 743742278:
0.07%

Covered Lines:
10926

Relevant Lines:
11324

💛  - Coveralls

原来饼图的过度动画出问题是这里除了问题！能 blame 到之前是怎么碰伤的吗？


Added a small playbook to create the crucible user if needed.

Need to also add the key to authorized keys

This poses a problem for anyone who is using a pre-exisiting assisted-installer. It appears that the DB is not compatible with the new version. I had to destroy all previous versions of assisted-installer and do a clean deploy for this to work.


Diagnosing Diabetes with SVM

Article checklist
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

This fixes #1651

@cyberShaw I would like to review this article.
cc: @hectorkambow

@cyberShaw I would like to review this article.
cc: @hectorkambow

Hey, @lalith1403
I've already started working on the article, halfway through the review.

Please upload a hero image that is of dimensions, 600 x 400.
@Inyrkz

I have changed the image file names. I have also modified the image alts. A hero image has been provided.

plagiarism check done

@Inyrkz  great work - very easy to follow along
cc @cyberShaw


Remove GB from EU now Brexit transition period is over

This is a poor approach for now as it loses all of the behaviour around dates, but there isn't an easy fix for that without passing the tax context much further down the chain.

Thanks!

Thanks!


Extend logging ability to allow hiding "file changed" and "client connected" messages.

I'd quite like to be able to set other logging levels, to be able to reduce console noise whilst developing.
What are your thoughts? Happy to write the code for this and submit a pull request.

Yes please do, would love to see your approach to this.

I'm using with babel, and when there are compile errors, they instantly get buried under "file changed" and "client connected" messages. So this would be very handy for me.

I'm starting development of this now!

Implemented in #41!
Notes:

clientLog is a new option that allows for independent filtering of client logging. Handy for making sure that client logging continues to come through even if the server's logging is set to error.
Livereload client logging (connected messages, errors, etc) has been restricted to the client console. to help keep the console readable.


Make the app list the rooms on login

The app is now listing rooms you already have from you user
Android dependencies updated
Initial work on make real-time message work

:/
I'll check the build tomorrow.

is there any news about this version?

@laggedHero Thank you for your PullRequest! I will check it soon.

AWESOME!!

Circle CI is now fixed manually


Peer to peer code review

The requirement was to create was to use mediaquery to create a desktop version of a portfolio website

Hello Kwamay👍

No issues here
You have done well to fellow the required changes suggested by the code reviewers
Approved👌


Unable to find image 'make:latest' locally

Sending build context to Docker daemon  2.048kB Step 1/3 : FROM ubuntu:18.04 Get https://registry-1.docker.io/v2/library/ubuntu/manifests/18.04: Get https://auth.docker.io/token?scope=repository%3Alibrary%2Fubuntu%3Apull&service=registry.docker.io: unexpected EOF Unable to find image 'make:latest' locally docker: Error response from daemon: Get https://registry-1.docker.io/v2/library/make/manifests/latest: Get https://auth.docker.io/token?scope=repository%3Alibrary%2Fmake%3Apull&service=registry.docker.io: unexpected EOF. See 'docker run --help'. make: *** [Makefile:67: docs] Error 125
Why? And how do i compile it to a dll for example to use it in C#?

The full log looks like:
$ make
Step 1/3 : FROM ubuntu:18.04
 ---> 4e5021d210f6
Step 2/3 : RUN echo ========== Install dependencies ==========   && apt-get update && apt-get install -y     clang     gdb     git     libavahi-compat-libdnssd-dev     libssl-dev     make     openssh-server     perl     unzip     wget   && apt-get clean   && rm -rf /var/lib/apt/lists/*
 ---> Running in 44eb369591f0
========== Install dependencies ==========
Get:1 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]
Err:1 http://security.ubuntu.com/ubuntu bionic-security InRelease
  Couldn't create temporary file /tmp/apt.conf.Y2gc62 for passing config to apt-key
Reading package lists...
W: GPG error: http://security.ubuntu.com/ubuntu bionic-security InRelease: Couldn't create temporary file /tmp/apt.conf.Y2gc62 for passing config to apt-key
E: The repository 'http://security.ubuntu.com/ubuntu bionic-security InRelease' is not signed.
The command '/bin/sh -c echo ========== Install dependencies ==========   && apt-get update && apt-get install -y     clang     gdb     git     libavahi-compat-libdnssd-dev     libssl-dev     make     openssh-server     perl     unzip     wget   && apt-get clean   && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
Unable to find image 'make:latest' locally
docker: Error response from daemon: pull access denied for make, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
make: *** [Makefile:67: all] Error 125

The problem is that when docker builds an image then inside the apt update can be executed because /tmp folder doesn't have a correct write permissions. This is a problem with  ubuntu:18.04 image.
Locally I had this image of ubuntu:18.04
ubuntu                18.04     4e5021d210f6   13 months ago   64.2MB
So I tried just to pull a newer version of the image with docker pull  ubuntu:18.04 and this resolved the problem
If for some reason you don't want to pull then as a workaround to fix you may add an instruction to change permissions to Dockerfile:
https://github.com/apple/HomeKitADK/commit/602d2885b7b89e05305cca73b3642ac5218ae3f9


Version 1.3.1 not working

I have a Samsug galaxy S3 with Cyanogenmod 11 and the proper version of YouTube installed same fore the background payback app but nothing works.
PS: It worked before for three to four updates.

What do you mean with 'Nothing works'? Does normal YouTube playback work? What about screen off playback?

I have the exact sme problem. Neither background nor screen off playback work. (In other words, it makes no difference having the module enabled vs disabled)
I'm running a CM12 based ROM on the Moto G 2013

So uninstall module please since I can't fix it. Or buy Music Key.

NVM, a reïnstall fixed it

@BmanDesignsCanada 's merged pull request didn't solve it for me; could you please re-open this issue?


workers.api.error.script_not_found

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.0.0
on linux_amd64

provider registry.terraform.io/cloudflare/cloudflare v2.23.0
provider registry.terraform.io/hashicorp/aws v3.47.0
provider registry.terraform.io/louy/uptimerobot v0.5.1
provider registry.terraform.io/terraform-provider-openstack/openstack v1.42.0

Affected resource(s)

cloudflare_worker_cron_trigger

Terraform configuration files
resource "cloudflare_worker_cron_trigger" "logger" {
  script_name = cloudflare_worker_script.logger.name
  schedules   = [
    "* * * * *",      # every 1 minutes
  ]
}

Debug output
No response
Panic output
No response
Expected output
Redeploy worker without error
Actual output
╷
│ Error: failed to read Worker Cron Trigger: HTTP status 404: workers.api.error.script_not_found (10007)
│
│   with cloudflare_worker_cron_trigger.logger,
│   on cloudflare.tf line 109, in resource "cloudflare_worker_cron_trigger" "logger":
│  109: resource "cloudflare_worker_cron_trigger" "logger" {
│
╵
Steps to reproduce
1.terraform apply # Deploy a worker with cron
2. Manually delete worker
3. terraform apply
Additional factoids
No response
References
No response

This is working for me and the integration tests - https://github.com/cloudflare/terraform-provider-cloudflare/blob/f52ccc18d74b2dbabcb8f435e04247dae8f00d19/cloudflare/resource_cloudflare_worker_cron_trigger_test.go#L10-L29
Have you checked the resource name you're using and the account/zone identifier being used? Per the issue template, please provide the TF_LOG=DEBUG output if you'd like further assistance.

Actually, scratch that. I managed to see the missing link here. If you delete via the dashboard it wipes out the connected resources whereas the API (and Terraform) allows deleting one without the relationships and doesn't have the same issue. This means to handle changes outside of Terraform we need to check for all resources that could be the source holding the other resources together (here, scripts that have triggers, envirnonment variables, etc)


Update SECURITY.md

I'd like to report a security issue and felt it most prudent not to disclose it publicly, as per your Security policy instructions.
If not a hassle, might you kindly add an email, or other private contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration!

Thank you for explaining it. I did not read carefully when Github suggested me to add SECURITY.md.🙊


:memo: logo

https://github.com/alakarteio/k-ramel/tree/doc/logo

Pull Request Test Coverage Report for Build 1430

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.56%

Totals

Change from base Build 1415:
0.0%

Covered Lines:
310

Relevant Lines:
319

💛  - Coveralls


Discard new changes on save

Hello When I write changes to a file and save them , they got discarded
hooks.add("setup_mappings", function(map)
    -- go
    vim.api.nvim_exec([[ autocmd BufWritePre *.go :silent! lua require('go.format').gofmt() ]], false)
    vim.api.nvim_exec([[ autocmd BufWritePre *.go :silent! lua require('go.format').goimport() ]], false)

when I comment those lines , it works again. the loosing is only in *.go files.
I got this error when I open vim , also it goes away when I comment lines above.

I think you do not need both:
vim.api.nvim_exec([[ autocmd BufWritePre *.go :silent! lua require('go.format').gofmt() ]], false)
vim.api.nvim_exec([[ autocmd BufWritePre *.go :silent! lua require('go.format').goimport() ]], false)

You only need one of them.  Otherwise it will try to format twice on saving.
I have this PR to clarify the README: https://github.com/ray-x/go.nvim/pull/70/files

Hi I have returned to my old config because I am lazy , this config is far far far far better from mine but I am used to my workflow.
My mistake was to replace it directly with mine maybe I will do an VM and play with it until I became familiar.

I am new to go.nvim, but you can look at my config if you want some ideas:
Setup

Default setup: https://github.com/rodrigc/neovim-setup/tree/main/.config/nvim
Init: https://github.com/rodrigc/neovim-setup/blob/main/.config/nvim/init.lua
plugins: https://github.com/rodrigc/neovim-setup/blob/main/.config/nvim/lua/plugins.lua
go setup:  https://github.com/rodrigc/neovim-setup/blob/main/.config/nvim/lua/config/go.lua

Close as no report from other users. I can not reproduce as well.


Handle PDS network access for systemtests

Situation
In

https://github.com/mercedes-benz/sechub/issues/2606

we introduced automatic PDS stream resolution inside system tests.
It works great with SystemTestFrameworkIntTest and has the wanted output (here the PDS and the SecHub server instance are accessible from localhost).
But for some existing system tests with docker compose the systemtest framework has no access to the solution network, but only to SecHub server instance.
Reproduce
Just call
sdc -f -bpt -syg

This builds the pds tools locally and after this, starts systemtest gosec "sanity-check".
The test will not fail, but inside the log output there is an error, that the debug information cannot be fetched.
Wanted
Change the setup of the existing system tests in a way, that the PDS debug information can be downloaded automatically.
Solution
The problem is the missing possibility for the systemtest framework to get access to PDS REST API because of network issues.
Variant A: Change docker compose

her we simply would change the network access
to handle different PDS solutions we would need to define dedicated ports for dedicated solutions! Otherwise mix up would not be possible.

PRO: no changes at SecHub side or at systemtest framework necessary
CON: PDS instance available from localhost
Variant B: SecHub as Proxy
SecHub could introduce a way to fetch data from PDS instances.
Maybe by executor configuration identifiers and a dedicated admin api.
PRO: PDS not available at localhost
CON: At the moment SecHub does only need the technical PDS user. Here we would change to admin user - without a real need. Also systemtest framework and SecHub server itself would be changed
Variante C: Like A, but dedicated systemtest way

Instead supporting local network access for all, we would provide a special system test option, where the PDS instance and SecHub is available.

PRO: no changes at SecHub side or at systemtest framework necessary,
"normal" docker compose parts not involved, still protected
CON: addtitional configuration

We have big problems with Variants A + C: The DNS (domain name space)!
Details
The current PDS solutions using 05 scripts, connect to an internal sechub network (provided by sechub solution). In our system tests, e.g. for gosec we have an URL like https://pds.gosec:8444.
SystemTest (local machine )
         (starts) ---> docker: sechub-solution    ---V
                                                    (creates network "sechub")
(starts) ---> docker: PDS-solution1               ---^ (connects to)

If we would just add local network access to our PDS-solution1 and define https://localhost:8444 inside our system test, this would not long work, because
localhost inside sechub-solution would point to sechub-solution itself and sechub could not connect in this case!

Solution:
We handle this issue as an "epic" and list here all necessary steps:

#2730
#2731

Locally we can use Metal LB do expose a external ip locally
We can also configure the external ip I etc/nano host so that we can access the external ip through a dns record


Fix the composer provide rule

This package does not provide the code of the psr/http-factory package (which defines interfaces). It provides psr/http-factory-implementation which is the virtual package to represent implementations of the interface.
Providing the wrong package while also requiring it creates issues with Composer 2, because the solver will consider that install psr/http-factory is not necessary as it is already provided.
Refs https://github.com/composer/composer/issues/9316
Closes #137

Coverage remained the same at 100.0% when pulling a0689c4bdb24458d78d34923f3982cd1f66a4750 on stof:patch-1 into 710fd17c1218cde6a0440c4427fafb3dcd74dd75 on slimphp:master.

Any news here? This is blocking composer update.

With the release of composer v2 this issue got serious. Composer now removes psr/http-factory when installing slm/http.

Needs release of new version

@proton-ab here you go https://github.com/slimphp/Slim-Http/releases/tag/1.1.0


Add age calculater project

Type of change
Add age calculater progect/ program

Project name :

Calculate Age

Short description :

This age calculator program in python3
help to calculate your to Calculate there age
Checklist

[x] The code is Python 3 compatible
[x] I have added relevant comments in my file to make code understandable
[x] I have added my project in a folder which includes all the necessary files

hello, Mrinank Bhowmick, still Waiting for your positive response this pr It will help a lot of students.
It's actually a basic script to calculate age of a person


New option: automatically send clipboard content to scratchpad

Useful when combined with another tool that extracts visible text from VNs.

Addressed the use case in an alternative way: provide a "clipboard" tab among "scratchpad" and "main" which is treated specially.


ClientDisconnected event is not thrown

The ClientDisconnected Event is not raised at the host.
I have used some differnt TCP Clients to connect to a simple host impementation.
I didn't get any Information about the Client disconnect.
Here is the code I have written.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Text;
using System.Threading;
using System.Threading.Tasks;

using SimpleTCP;

namespace SimpleHost
{
    public class Host: IDisposable
    {
        private const int SERVER_PORT = 1100;
        private const string EOT_MARK = "\n\r";

        private SimpleTcpServer _tcpHost = new SimpleTcpServer();
        private TcpClient _connectedClient = null;

        public Host()
        {
            _tcpHost.ClientConnected += _tcpHost_OnClientConnected;
            _tcpHost.ClientDisconnected += _tcpHost_OnClientDisconnected;
            _tcpHost.DataReceived += _tcpHost_OnDataReceived;
            _tcpHost.AutoTrimStrings = true;
            StartListening();
        }

        private void _tcpHost_OnDataReceived(object sender, Message e)
        {
            Console.WriteLine("Server received: {0}", e.MessageString);

            e.Reply("Echo\n\r");

        }

        private void _tcpHost_OnClientDisconnected(object sender, TcpClient e)
        {
            Console.WriteLine("Client {0} disconnected", e.Client.RemoteEndPoint.ToString());
            if (_connectedClient == e)
            {
                _connectedClient.Dispose();
                _connectedClient = null;
            }

        }

        private void _tcpHost_OnClientConnected(object sender, TcpClient e)
        {
            Console.WriteLine("Client {0} connected", e.Client.RemoteEndPoint.ToString());
            if (_connectedClient == null)
            {
                _connectedClient = e;
            }
            else
            {
                e.Dispose();
            }

        }

        private void StartListening()
        {

            _tcpHost.Start(SERVER_PORT);
        }

        public void Dispose()
        {
            if (_connectedClient !=null)
            {
                _connectedClient.Dispose();
            }
            _tcpHost.Stop();
            _tcpHost = null;
        }
    }
}

i am having the same issue,i tried even calling Disconnect manually and nothing

You can fix this by remove the lines 102-108 in "ServerListener.cs". The "RunLoopStep()" never comes to disconnectedClients.

This is unfortunately a tough problem to solve for TCP all around.
If you're not sending traffic, you can't clearly determine if a client has disconnected.
Best solution I've found so far is to add an "ignore" character on the client side that does not get processed, and periodically send the ignored character to the client. Basically, a heartbeat byte. If this were enabled by default, this could create some interesting issues for non-SimpleTCP clients, so it would have to be an opt-in property. Thoughts?

I have used the pattern (id, packet length,packet content) in the past, it's actually safer to handle because I always know what I will read. to solve the disconnect notification issue, I would create a ping packet with an id 0,  packet length 0 and empty content. then even for non-SimpleTCP clients, if they follow that same pattern, they can ignore any packet with the id 0.

One option for the heartbeat message is it could be the message terminator byte alone. Then it is up to the client to ignore blank messages. But, just in case clients cannot handle that, it could be off by default.
I suggest having the time interval between server heartbeats controllable by a property as well. If the heartbeat interval was 0 (the default) then no heartbeats.

maybe you can use some of the limit bytes like 255 or something like that


Update text alignment class names

Fixes silverstripe/silverstripe-framework#8520

It might be partially, but not completely fixing the issue https://github.com/silverstripe/silverstripe-framework/issues/8520 is that correct?


[Feature Request/Issue] Loot Export

"To" datepicker on Custom Loot Overview - Export has some weird behavior

[ ]  Leaving "To" empty/default does not include today's voyages
[ ]  Setting "To" manually to "2023/08/18" (following the placeholder format, which is maybe hardcoded and does not use the User's Date Format set in Configuration) does not include today's voyages
[x]  Clicking ♻ sets "To" to "2023-08-18" which does include today's voyages
[x] Setting "To" manually to "2023-08-18" includes today's voyages
[x] Setting "To" using datepicker widget to today includes today's voyages

Additionally some QoL feature requests:

Preserve settings for loot export across sessions (i.e. Exclude Date and Output Folder, "From"/"To" probably shouldn't be saved)
"Export to clipboard" button in addition to existing one?

"To" datepicker on Custom Loot Overview - Export has some weird behavior

[ ]   Leaving "To" empty/default does not include today's voyages
[ ]   Setting "To" manually to "2023/08/18" (following the placeholder format, which is maybe hardcoded and does not use the User's Date Format set in Configuration) does not include today's voyages
[x]   Clicking ♻ sets "To" to "2023-08-18" which does include today's voyages
[x]  Setting "To" manually to "2023-08-18" includes today's voyages
[x]  Setting "To" using datepicker widget to today includes today's voyages

I will look into it
But yeah the issue that you have with setting the date is easy to explain
If you pick or manually input a date the time is set to 00:00:00, while the Reset button sets it to "Now", thats why you have this weird behavior
I will prolly just set the time to 23:59:59
Why it doesn't work with an empty field is weird, as it does the same as the Reset button...

Could you confirm that your input fields are actually "2023-08-18" with this format?

Should work as intended now, if there is still issues after the update, pls comment here again


Create A Responsive Dialog Content.

This is a new low-level @Composable usable in conjunction with Dialog to generate dialog screens that adapt well to larger screens.

Still a WIP, but I'll land and hook it into the existing material dialogs, and also screenshot tests.

Closing and re-opening to kick off CI actions.

Assuming failure unrelated, flaky test?
com.google.android.horologist.media.ui.tiles.MediaCollectionsTileTest > square FAILED
    kotlinx.coroutines.test.UncompletedCoroutinesError at TestBuilders.kt:349


unsubscribe to avoid memory leak

listener on rootscope will live as long as app

@mcshaz nice shot, thank you! 👍


[Docs] Ambiguity in Getting Started (Android) SDK Platform Configuration

In the Getting Started docs, it says:

In the SDK Platforms window, choose Show Package Details and under Android 6.0 (Marshmallow), make sure that Google APIs, Intel x86 Atom System Image, Intel x86 Atom_64 System Image, and Google APIs Intel x86 Atom_64 System Image are checked.

However, this is the illustrative image:

Notice that Android SDK Platform 23 and Sources for Android SDK are checked. Are these required? If yes, it should be noted. If not, perhaps they should be unchecked in the image? They weren't checked in my installation by default.
Another thing: Intel x86 Atom_64 System Image is noted as required to be checked, however the image shows it as unchecked. And while Google APIs Intel x86 Atom_64 System Image is supposed to be checked per the docs, the illustration has it unchecked, and instead has Google APIs Intel x86 Atom System Image checked (note the lack of _64).
I apologize if these are considered nit-picks, but ambiguities are confusing for newbies, such as myself 😄
I'd be glad to make a PR once given clarification as to the correct verbiage.
Thank you!

@facebook-github-bot label Documentation

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/docs-ambiguity-in-getting-started-android-sdk-platform-configuration
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Reading raw CSV files

Does the package have a process for reading raw CSV files? Can I add to the SKDH pipeline functionality for reading a raw CSV file with simply 4 columns as time (s or ms), and x, y, and z accelerations in g?

Currently there is no built-in functionality for reading raw CSV files. If this is something that would be useful, feel free to submit a PR


The result has a bad performance on curve, how to improve it?

A quote from the paper (Section V, "State-of-the-art Comparison" paragraph):

It is noticeable that PolyLaneNet’s predictions on parts  of  the  lane  marking  closer  the  camera  (where  more details can be seen) are very accurate. Nonetheless, on parts of the lane marking closer to the horizon, the predictions are less accurate. We conjecture that this might be a result of a local minimum, caused by the dataset’s imbalance. Since most lane markings in the dataset can be represented fairly well with 1st order  polynomials  (i.e.,  lines),  the  neural  network  has  a  bias towards  predicting  lines,  thus  the  poor  performance  on  lane markings with accentuated curvature.


compile fail

maybe It is a jdk bug ?  my jdk version is 1.8.0_40
is any way solve this?

Do you have a stacktrace?

Looks like this was a javac bug, perhaps with u40:
https://bugs.openjdk.java.net/browse/JDK-8068399
Maybe try a newer JDK?

this bug is fixed in  jdk9, change jdk is too troublesome.
i find cause is  this code

so，i delete AbstractFailsafeTest class three method: shouldFallbackWhenCircuitBreakerIsOpen,shouldFallbackAfterFailureWithCircuitBreaker,shouldFallbackAfterFailureWithRetries.
it is ok now .

Ok - yea I don't want to remove test coverage to workaround a JDK bug that appears to only effect certain revisions.


Auto-init RDBMS for JPA service registry

For the JPA service registry implementation it would be super convenient to initialize the database with initial "seed" service entry, so the CAS server is usable immediately (all HTTPS pattern service for example) without the need to stand up the separate services management web app just to add the initial entries.
One possible implementation would look for JSON service registry definition available on the classpath and init the backing database with those values.

Working on it. This turned out to be much more complex than I anticipated with all the Boot's black magic, JPA and transaction management shenanigans, etc. This is definitely not gonna make M1 and will most like likely (the work) will spill into next week. This is just FYI...


Change "self-service payments" to "payment links"

After discussions with @mpwoods and @karlchillmaid, our alignment consensus is that we should refer to "payment links" on the features page and in the documentation

cc @jonheslop @katiebates

Yeah if you just rename the file, it will update the URL, but then will also have to use find and replace to update all the reference URLs within the repo too


mc_planning classes for walking based on preview control

Currently, lipm_walking_controller is mostly used for walking with mc_rtc, but this implementation is inconvenient to use with other controllers because the walking function in the controller class is not separated.
In this PR, the mc_planning :: PreviewControl class and the mc_planning :: FootstepManager class are added to provide easy-to-use walking functions. I think this is a minimum implementation for walking. It's not as advanced as the MPC-based method, but it's useful for beginner learning and baseline comparisons.
The preview control added in this PR is used in the loco-manipulation planner [1], and I'd like to use this PR features in the controller [2] to allow online planning.
(Internal only)
[1] https://github.com/isri-aist/hwm_planner
[2] https://gite.lirmm.fr/jrp-2019/mc_hwm_planner

The result of PreviewControlWalking controller added in this PR
Video
https://www.dropbox.com/s/ku2xiff39qa6a3v/preview-control-walk-20201216.mp4?dl=0
Trajectory of CoM and ZMP planned by preview control
t-(x,y) graph:

x-y graph:

Target and measured ZMP of walking motion
t-x graph:

t-y graph:

It is not mandatory to merge this feature, so close it.
Note:
Some feature proposals, including this PR feature, are implemented and used in mc_hwm_planner. They are in the mc_hwm_planner/src/mc_*** directory (currently there are mc_trajectory and mc_planning). They are written in mc_rtc's convention and the clang-format is also applied (although CI is not running).
Below is a list of feature suggestions, so If you have a situation that needs them, I'm glad if you remember it.

Cubic spline and cubic Hermite spline based on general piecewise function class along with tests. Although the cubic spline implementation in hpp-spline is currently used in mc_rtc, that implementation does not support the explicit specification of the velocity or acceleration at the boundary (which is possible in nature).
Preview control, which is improved version of this PR. If we add pattern generation functionality to mc_rtc, the preview control will be a good baseline. It has been confirmed on the actual HRP-5P can perform pure locomotions and loco-manipulations by using this.
Footstep manager that generates a ZMP reference trajectory and swing leg trajectory from a given footstep sequence.
Manipulation manager that generates the hand trajectory from the object trajectory.

Cubic spline and cubic Hermite spline based on general piecewise function class along with tests. Although the cubic spline implementation in hpp-spline is currently used in mc_rtc, that implementation does not support the explicit specification of the velocity or acceleration at the boundary (which is possible in nature).

It would be nice to have an implementation of the SplineTrajectoryTask that supports such curves. The initial choice of using hpp-spline stemmed from discussions we were having with LAAS at the time trying to see if we could be sharing more software in the future. Retrospectively, I think the current implementation of hpp-spline does not fully fits our needs.

Note that hpp-spline has been deprecated (for a while) in favor of https://github.com/loco-3d/ndcurves which I think has these capabilities.

If we don't want to have our own implementation, it would be better to use loco-3d/ndcurves.
（The following are just notes:
I tried loco-3d/ndcurves for a bit, and the way to set the boundary velocity/acceleration is not quite straight forwad.
In the normal cubic spline, if only one of velocity or acceleration of the boundary is given, the number of variables and the number of constraints will be consistent. But in loco-3d/ndcurves, only an interface is provided to give both the velocity and acceleration of the boundary. In that case, the DoF of the variables would be insufficient, so only the last interval is quintic, which is a bit tricky.
Last interval is quintic:
https://github.com/loco-3d/ndcurves/blob/4441d0dfb53ed9e05d07d9426cf01293bb447f42/include/ndcurves/exact_cubic.h#L297
Other intervals are cubic:
https://github.com/loco-3d/ndcurves/blob/4441d0dfb53ed9e05d07d9426cf01293bb447f42/include/ndcurves/exact_cubic.h#L257
)


private packages break it

see the screenshot:

Hi, thanks! I don't have any private packages, so wasn't able to test that.
However, I don't think it's private packages that break it... it's that the first (of those three) doesn't have a description.
I'll follow up with it today~!

Actually, being that I don't have any private packages, can you (or someone) send (1) the DOM markup of a private item and (2) the current error message within console?
Thanks!


Upgrade ProPresenter 6.app to v6.0.12 (Build: 15052)

Merged as cbf9a6b1d51487be07b5e69d3c3fb63d74b7ca4a.


[enchantment] WebApp based date-picker variant

I trying to add the date-picker using Telegram WebApp API (based on Bootstrap or M3 components)

It would works just in two cases:

WebApp launched via InlineKeyboardButton - not working with polling, just if you use your own web-server or if you use a webhooks
WebApp launched via MarkupKeyboardButton - works with polling too but not close most usage cases

I fount this https://github.com/harshil21/TGDates
but it uses ReplyMarkup only

wouldn't implemented


Messed up when blocked by apps

In these troubling times, it is not surprising that people want to translate a message into Russian (or Ukranian) and paste it into the chat.  Perhaps while playing poker and finding some Russian players at the table.
PokerStars.com seems to have found a way to prevent ClickPaste from pasting into the chat box (there have been almost daily updates to their client app in the last fortnight; though their Windows client seems not to support Unicode anyway, so I don't know if non-ASCII characters would even appear correctly for users with a different Windows system locale for legacy apps).  I was able to use ClickPaste with PokerStars chat a couple of weeks ago (with non-ASCII characters echoed as garbage my end), but can no longer do so.
The bug in ClickPaste is that when an app employs whatever defence it is using, the target cursor remains active, and it does not seem possible to cancel it.  Eventually clicking on an unintended window can cause the keystrokes to be sent in such a way as to invoke menu items and wreak all sorts of havoc.
I tried pressing Esc to cancel but that did not work.
(Incidentally, it seems that PokerStars has now blocked Russian-registered accounts from playing.)

Oh yeah, I intend to make a way to ESCape the target.  I have run into this as well :)

Oddly I tried changing the typing method (to Forms_SendKeys), and pasting into [redacted site] worked.  Then I changed it back (to AutoIt_Send), and it still worked.  So I don't really know what the issue was with the [redacted site] not accepting the pasting at the time I created this issue.

Fixed in v1.0.1


a few suggestions for using the apply tactic and the .. syntax

This is just a minigolf I did without studying the contents. Feel free to ignore this PR.

OK, I'll close this PR a open a new one, containing only the two changes which @YaelDillies liked, what about that?

Probably better keep it here...

@YaelDillies can check it again. This time, only non-controversial changes should be present.

Can you fix the conflict?


[2012-07-19] Datefield, DatePicker not displayed in the user language

created by: otiteca
created at: 2012-07-19
original ticket: http://open.silverstripe.org/ticket/7687

For now the Date picker is displayed only in English when using a DateField.
reason:
the jquery i18n language files are not existing in thirdparty folder under framework.
for my personal case, i did want it in French.
What i did to solve the problem:
DateField.php line 470, added a map for fr_FR:
    static $locale_map = array(
        'en_GB' => 'en-GB',
        'en_US' => 'en',
        'en_NZ' => 'en-GB',
        'fr_CH' => 'fr-CH',
                'fr_FR' => 'fr',
        'pt_BR' => 'pt-BR',
        'sr_SR' => 'sr-SR',
        'zh_CN' => 'zh-CN',
        'zh_HK' => 'zh-HK',
        'zh_TW' => 'zh-TW',
    );

then into framework/thirdparty/jquery-ui, i
svn co http://jquery-ui.googlecode.com/svn/trunk/ui/i18n/

(I did not find the minified versions).
then I modified DateField.php line 514:
Requirements::javascript(
                    sprintf(
                        THIRDPARTY_DIR . '/jquery-ui/i18n/jquery.ui.datepicker-%s.js',
                        // can be a mix between names (e.g. 'de') and combined locales (e.g. 'zh-TW')
                        $lang
                    ));

this was to point the not minified version i checkout.

+1 we also need a localized calendar

It might be the case, once we get further to a react-based user interface, that we build a new date picker field that supports custom formats. :D

We'll fix this by simply removing our reliance on jQuery UI, and using built-in browser behaviour for 4.x: https://github.com/silverstripe/silverstripe-framework/issues/6626


State "fhem.0.info.Info.TEST" has no existing object, this might lead to an error in future versions

Since update of Javascript controller to version 3.2.16 (latest stable) I allways get some warnings when starting the FHEM adapter:
`

fhem.0
2021-03-07 16:28:58.034
warn
(6059) State "fhem.0.info.Info.TEST" has no existing object, this might lead to an error in future versions

`
I stopped FHEM adapter, deleted hole tree and restarted but the warning just came back.
Is there something I could do by myself?
In fhem.0.info.Info there is no datapoint TEST. And none of my scripts would trigger for it.
Greetings, Jürgen

fixed in github  builddate: 10.02.21
pls update from github and check again :-)
Greetings, LausiD

@LausiD Thanks, problem seems to be solved. I just wondered as I was on version 1.5.3 and after updating via Github (the "cat" in iobroker), I still saw version 1.5.3. But nevertheless, the message is gone, I'll close the issue.


"the compressed (zipped) folder is invalid"

I get this error when I try to open the x64 zip file for both Windows and Linux releases.

Hi there,
please use Winrar or 7zip to unzip. Duplicate of #81


Notify users about changelog upon each VSCode plugin release

When a new version is published to marketplace, all installed users will get the update automatically. We need to users about new features, etc. after update.
Refer to how GitLens extension does it.

Moved to https://github.com/wso2/ballerina-plugin-vscode/issues/14


Fixed issue: cannot assign a resource to a user who has an organization

Motivation and context
Resolved #4695
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

/check

/check


Send selected files with a normal form submit?

I have a special use case.
I would like to make use of some of the nice features of jQuery File Upload: client-side validation, drag'n'drop, multiple files, and previews (where supported) - but in the end I need to send the files to the server with a simple form submit.
The reason is that I need to support legacy CMS code on the server that simply loops the files in the post request.
Is this easily achievable?

replaceFileInput set to false, without overriden add method is not working, according to your answer here @blueimp
Probably some bug.
Also, if anybody needs to handle errors/success messages in form, I really recommend using bootbox.js and displaying messages by it. Really easy to implement ;)


Switch index.js in webpack to runner.js

Closes #61
@jphoenix86 @rrgayhart
What's this PR do?
This PR deletes an unnecessary file called index.js. The only purpose of index.js was to call runner.js. It came with the Game Time Starter Kit and we never bothered to remove it.
Where should the reviewer start?
Since we have no CI in this project, the reviewer should clone the branch and confirm that all the tests are passing.
How should this be manually tested?
By playing the game and making sure it runs.
What gif best describes this PR or how it makes you feel?

:+1: Looks good! Excellent .gif usage. :ship: it!


chore: add validation for metadata.json file

Closing as docker does not provide a way to validate this in Github actions


Refactor(compiler-base): refactor trait component and add errors.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

issue #115
2. What is the scope of this PR (e.g. component or file name):
compiler-base/error
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[x] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

add 'errors.rs' to report error for 'components.rs'.
refactor trait Component to supports report errors.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

add unit test case in compiler-base/error/tests.rs
6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 60.418%

Files with Coverage Reduction
New Missed Lines
%

kclvm/compiler/src/codegen/llvm/context.rs
2
74.15%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
23789

Relevant Lines:
39374

💛  - Coveralls

LGTM


--version shows UNKNOWN when installed from PyPi

❯ pip install --upgrade gto
...
❯ gto --version
🪴  GTO Version: UNKNOWN

Need to check this again after the release to PyPi.


Adds basic implementation for schema validator

Codecov Report
Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.06%. Comparing base (66ad847) to head (436e892).

Files with missing lines
Patch %
Lines

pkg/core/validator/validator.go
70.96%
6 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   94.67%   94.06%   -0.62%
==========================================
  Files          30       30
  Lines        1202     1230      +28
==========================================
+ Hits         1138     1157      +19
- Misses         45       51       +6
- Partials       19       22       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Task: Create Product Database

Create a database (JSON file) that contains all the products in the store's inventory.

Feature complete and integrated.


Kmesh CNI overwrite cni conflist with empty value

What happened:
After running kmesh for some time, we cannot restart kmesh daemon and also not able to start a new application pod.
By looking into kmesh logs, we do see:
time="2024-03-06T10:06:41Z" level=info msg="Copied /usr/bin/kmesh-cni to /opt/cni/bin." subsys="cni installer"
time="2024-03-06T10:06:41Z" level=info msg="failed to read conflist: /etc/cni/net.d/10-calico.conflist, error parsing configuration list: unexpected end of JSON input" subsys="cni installer"
time="2024-03-06T10:06:41Z" level=error msg="can not found the valid cni config!\n" subsys="cni installer"
time="2024-03-06T10:06:41Z" level=error msg="can not found the valid cni config!\n" subsys=manager

What you expected to happen:
Kmesh should not overwrite invalid conflist
How to reproduce it (as minimally and precisely as possible):
not sure how to reproduce
Anything else we need to know?:
Environment:

Kmesh version:
Others:

cc @supercharge-xsy @lec-bit


Fix logout by passing id_token_hint to identity provider.

Description
As per #3863, logout is not working for some identity providers since we do not pass id_token_hint as per the OpenID connect spec.
This PR fixes that by adding the ID Token (as a JWT) into the CiviFormProfileData class, and putting it in the extraParams in the CiviformOidcLogoutActionBuilder.
Issue(s) this completes
#3863

Messages from Slack about testing:
Bion Johnson
18 hours ago
@Michael Zetune
one thought on this PR is that we could build a prod image from it and have bloomington deploy it and try it out before we merge, could check with Cliff on their end if they'd be up for that
https://github.com/civiform/civiform/pull/4268#pullrequestreview-1310428873
Michael Zetune
4 hours ago
Sure, I can check with them. So I'll just message Cliff Ingham and see if he'd do that for us? Would this be similar to the standard release process except not publicized?
New
Bion Johnson
18 minutes ago
So I'll just message Cliff Ingham and see if he'd do that for us?
yes
Would this be similar to the standard release process except not publicized?
not quite. we'd use bin/build-prod on your branch and push the image to docker hub and let Cliff know which tag to use for testing

I'll contact Cliff after this PR is merged.


Create how to choice best computer?

Purpose: What do you plan to use the computer for? Is it for gaming, productivity, content creation, or general use?
Operating system: Do you prefer Windows, MacOS, or Linux?
Processor: The processor determines the computer's speed and performance. Look for processors with higher clock speeds and multiple cores.
RAM: Random Access Memory (RAM) is the computer's short-term memory. A minimum of 8GB is recommended for most tasks.
Storage: Choose between a solid-state drive (SSD) or a hard disk drive (HDD). SSDs are faster but more expensive.
Graphics: If you plan to use the computer for gaming or content creation, look for a dedicated graphics card.
Price: Set a budget and look for a computer that fits within it.
Ultimately, the best computer for you will depend on your needs, budget, and preferences. Do some research and read reviews before making a decision.

This doesn't fit into the scope of a computer science curriculum. Computer science is all about the computations, not the computer used to perform the computations. The field actually predates electronic computers.
That said, universities/computer science departments at universities often publish a list of minimum specifications for personal student computers.
However, I'm not sure we should do the same. I'm not aware of any course in our curriculum that has requirements more substantial than "playing videos" and "running a text editor". These functions could be completed, for example, on a $35 Raspberry Pi. The best computer for use in the program, then, is going to be "whatever computer you already have access to".
I concede the resource may be helpful to some, though. Computer science students tend to not be very good at IT matters.
I would recommend setting up an RFC in the Issues section of this GitHub (linking to this PR) and see if there is any interest in setting up a resource like this in Supplemental Resources.

I would agree that this does not match the institutional strengths of OSSU.
I'm also concerned that the proposed language is not a sufficient guide. For example: "Operating system: Do you prefer Windows, MacOS, or Linux?" does nothing to educate students about the strengths and drawbacks of choosing one OS over another.


Respect the disable_settings_management flag for settings.redis.php

Thanks for adding the settings for redis!  that is a great way to get bootstrapped up with reasonable defaults.
Though sometimes it's nice to leave those up to the project! Let's respect the disable_settings_management flag and not add the settings.redis.php if that configuration is enabled.

Could you take a look @hussainweb ? Thanks!

I don't mind writing the PR and taking the first stab at it, just comment @hussainweb

Just do it! 😀

I would, just got some toddlers keeping me occupied, so need a bit more time than most, but it will be done

Ok kinda hacky about how I got the config value, a ddev config get disable_settings_management or something would feel less so... but added a test to the .bats file.

#7


[Feature] : Way to prevent auto-scroll down in "Container logs"

PR enables the user to disable or enable following(auto-scroll down) for container logs. Enabled by default but can be disabled on user demand 🙂 .
[screenshot]

Closes issue #2611

Any feedback on this @FrenchBen. Thanks

Thanks for the feedback @FrenchBen. Got this fixed 👍


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit c17dc77:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-11-19-05-09-13 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Archive_master_2019-11-19-05-09-13

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cover the situation in which UTxO's are not disjoint in the ledger spec

In the current spec UTxO is defined as a map from transaction inputs TxIn to transaction outputs TxOut. In the conclusion of the UTxO rule:

it is not specified what happens if txsins tx </| utxo and txouts tx are not disjoint.
It seems that such situation cannot happen since txouts tx will be formed by keys of the form (txid tx, _). So the only way of having an element in the intersection of the sets above is that tx was previously added to utxo, but this cannot happen since in the conclusion we remove the set txins tx from utxo and the premise of the rule demands that txins tx is included in utxo.
We should either prove this formally or add a quickcheck property.

This issue should deal with adding a property test for this.

tx was previously added to utxo, but this cannot happen since in the conclusion we remove the set txins tx from utxo and the premise of the rule demands that txins tx is included in utxo.

So basically what I tried to say here is that we cannot include the same transaction in the utxo twice, since we can consume the inputs of txonly once.