GridView spacing between each grid cell

Using GridView.count produces visible artifacts (gray lines) depending on the size of the grid and the resolution of the device. There doesn't seem to be any spacing/padding around the grid items.

code sample
import 'package:flutter/material.dart';
import 'dart:math' as math;

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'GridView Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: _MyGridViewApp(),
    );
  }
}

class _MyGridViewApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    final size = 7;
    final tileCount = math.pow(size, 2);
    return Scaffold(
      appBar: AppBar(
        title: Text('GridView'),
      ),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(15.0),
          child: GridView.count(
            shrinkWrap: true,
            crossAxisCount: size,
            children: List.generate(tileCount, (index) {
              return Container(
                color: Colors.black,
              );
            }),
          ),
        ),
      ),
    );
  }
}

9x9 GridView - Visible artifacts (lines)

7x7 GridView - Visible artifacts (lines)

6x6 GridView - No visible artifacts

flutter doctor -v
☆ flutter doctor -v
[✓] Flutter (Channel dev, v1.3.13, on Mac OS X 10.14.3 18D109, locale en-US)
    • Flutter version 1.3.13 at /Users/albertlardizabal/dev/flutter/dev/flutter
    • Framework revision 59ce7d6bff (2 days ago), 2019-03-18 11:20:10 -0700
    • Engine revision e75f6de01f
    • Dart version 2.2.1 (build 2.2.1-dev.1.0 None)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/albertlardizabal/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.1

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.4.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] IntelliJ IDEA Community Edition (version 2018.3.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 33.3.2
    • Dart plugin version 183.5912.23

[✓] Connected device (1 available)
    • Albert’s Beta iPhone 7 • b55500a5ba119137c3dc8486e0ac4f45ebb2c3be • ios • iOS 12.1.4

This looks like a known problem with antialiasing and mapping from logical pixels to device pixels. There's an open issue for a documentation fix: #14288
More info about the problem can be found here:
#14288 (comment)
#17084 (comment)
#15035 (comment)

Issue still exist
flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.18.0 at /Users/taha/Code/flutter_dev
    • Framework revision 8f7327f83a (31 hours ago), 2020-04-06 22:11:01 -0400
    • Engine revision 49891e0653
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1
[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome           • web-javascript • Google Chrome
      80.0.3987.149
    • Web Server • web-server       • web-javascript • Flutter Tools
• No issues found!

Hi Team,
Any update on this?
Regards,
Balasubramani Sundaram.

Hi Team,
Any update on this?
Regards,
Balasubramani Sundaram.

have a look at inserting gridDelegate: XSliverGridDelegate(               crossAxisSpacing: 10,               mainAxisSpacing: 10),
under GridView.builder and add this to you pubspec.ymal
flutter_grid_delegate_ext:

For the meantime, I found a very simple workaround. Just add this to each tile Container in the GridView/SliverGrid:
decoration: BoxDecoration(
              color: Colors.black,
              borderRadius:
                  BorderRadius.only(topRight: Radius.circular(1)),
            ),

Before (without the rounded corner)

After

Never mind my previous workaround since it doesn't work 100%.
@dhawalmehta22 found a fix (see original post: https://github.com/flutter/flutter/issues/25009) that works at all times. Just wrap the problematic container with another container and add this to the parenting container:
decoration: BoxDecoration(
             color: Colors.black, //the color of the main container
             border: Border.all(
               //apply border to only that side where the line is appearing i.e. top | bottom | right | left.
               width: 2.0, //depends on the width of the unintended line
               color: Colors.black,
             ),
           ),

code sample
import 'package:flutter/material.dart';
import 'dart:math' as math;

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'GridView Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: _MyGridViewApp(),
    );
  }
}

class _MyGridViewApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    final size = 7;
    final tileCount = math.pow(size, 2);
    return Scaffold(
      appBar: AppBar(
        title: Text('GridView'),
      ),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(15.0),
          child: GridView.count(
            shrinkWrap: true,
            crossAxisCount: size,
            children: List.generate(tileCount, (index) {
              return Container(
                color: Colors.black,
              );
            }),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (5 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.194, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.194 at /Users/tahatesser/Code/flutter_master
    • Framework revision 71aec53acb (5 hours ago), 2021-01-26 21:53:04 -0800
    • Engine revision b11bef83a5
    • Dart version 2.12.0 (build 2.12.0-263.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

code sample
import 'package:flutter/material.dart';
import 'dart:math' as math;

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'GridView Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: _MyGridViewApp(),
    );
  }
}

class _MyGridViewApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    final size = 7;
    final tileCount = math.pow(size, 2);
    return Scaffold(
      appBar: AppBar(
        title: Text('GridView'),
      ),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(15.0),
          child: GridView.count(
            shrinkWrap: true,
            crossAxisCount: size,
            children: List.generate(tileCount, (index) {
              return Container(
                color: Colors.black,
              );
            }),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (5 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.194, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.194 at /Users/tahatesser/Code/flutter_master
    • Framework revision 71aec53acb (5 hours ago), 2021-01-26 21:53:04 -0800
    • Engine revision b11bef83a5
    • Dart version 2.12.0 (build 2.12.0-263.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

https://pub.dev/packages/space_fixer
maybe helpful :)

This is anti-aliasing, but @tomasbaran proposed adding a background property in https://github.com/flutter/flutter/issues/62818
From that de-duped issue, it is not clear why a Container does not work to set a background color. Can someone share why if you know? Thanks!

There is also a proposal for a decoration that may be the more appropriate solution: https://github.com/flutter/flutter/issues/107498


Provides a link to the 2019 edition which then brings you back here!!

In the segment "Pull and Run Container Image" there is a link for the 2019 edition which brings the browser back to this self same page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b152444b-dfb8-5cbe-cf45-9830bd085a68
Version Independent ID: 31719660-d4d0-7f63-efcc-846c822a63c2
Content: Docker: Install containers for SQL Server on Linux - SQL Server
Content Source: docs/linux/quickstart-install-connect-docker.md
Product: sql
Technology: linux
GitHub Login: @vin-yu
Microsoft Alias: vinsonyu

Workaround: setting the edition at the top of the left hand frame gets the browser to the 2019 edition.

@sureseam -- Alastair, thank you for your feedback and workaround. I will pass it on.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Adding timeout changes behavior without raising an exception

I am using requests to query a website.

If I query without timeout, the request hangs.
This behavior seems to be specific to this website. My code works fine against other websites.
Expected Result
The request does not hang.
Actual Result
Without timeout, the request hangs.
With timeout, the request takes the full timeout window before returning successfully.
Reproduction Steps
#!/usr/bin/env python3

import requests

# Works -- but takes the full timeout before the call returns
print('Try 1')
r = requests.get('https://repo.packagist.org/p/jrodella/payment-form-api.json', timeout=5)

# Hangs
print('Try 2')
r = requests.get('https://repo.packagist.org/p/jrodella/payment-form-api.json')

If I add in logging, the hang occurs after the log statement:
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): repo.packagist.org

System Information
$ python -m requests.help

(13:21:07) jamie@woody ~/Desktop/EcosystemRegexps/ecosystems $ python3 -m requests.help
{
  "chardet": {
    "version": "3.0.4"
  },
  "cryptography": {
    "version": "1.9"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.5.2"
  },
  "platform": {
    "release": "4.15.0-33-generic",
    "system": "Linux"
  },
  "pyOpenSSL": {
    "openssl_version": "1000207f",
    "version": "17.3.0"
  },
  "requests": {
    "version": "2.18.1"
  },
  "system_ssl": {
    "version": "1000207f"
  },
  "urllib3": {
    "version": "1.21.1"
  },
  "using_pyopenssl": true
}

Hi @davisjam,
This is the expected behavior of not passion a time-out, the connection will remain open until closed by one of the involved parties.
This information is available at the top of the timeout section in the docs.

Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely

Hi @nateprewitt.
I have read the documentation. Perhaps I was too hasty in my writeup.
Can you clarify what I find the odd behavior here? Namely that:

With timeout, the request takes the full timeout window before returning successfully.

This implies that there is a path wherein the timeout expires but no exception is raised.
I could not find this described in the documentation.
If I add verify=False then no timeout parameter is necessary; the request completes promptly and the website closes the connection.


Get definitions for words from the API and store them locally in the database

As a part of https://github.com/cltk/cltk_frontend/issues/36, we will need to retrieve definitions of words from the cltk_api Flask applications and save them to the database to show in the definitions panel.
This is currently what the definitions panel looks like:

In order to do this, we will first need to develop the cltk_api frontend application to feature a dictionary lookup for words.
The blue Perseus link should link to Perseus's dictionaries with a link such as http://www.perseus.tufts.edu/hopper/morph?l=arma&la=la

Cross-reference in the API issues: https://github.com/cltk/cltk_api/issues/26

I can be persuaded either way on this, but I think we might be happy with two collections: one for the multiple definitions of a word and the other for the possible forms of the word in a given context.
First collection ("definitions") needs the following information like a dictionary entry:
armum, armi (noun, 2nd declension): arms (pl.), weapons, armor, shield; close fighting weapons; equipment; force;
Parameters that may figure into the collection model:
armum, armi: entry for word
noun: part of speech
2nd declension: declension/conjugation information
arms, etc.: word definitions/senses
Second collection ("wordForms"), containing lemmatized information from the CLTK API:
arm-a - neuter nominative plural
arm-a - neuter accusative plural
Parameters that may figure into the collection model:
arm-a: occurence
neuter nominative plural, etc.: delcension/conjugation information
and also a list of ids to possible definitions for the word
Thoughts about this type of layout?  We should at least consider a little bit how to invalidate our local store of definition / lemmatized word information at this point as well.

If I understand this correctly, it makes perfect sense.
We have separate tables for definitions and text. As we have a many-to-many relationship between definitions and text (a definition may be present in many texts and a text may contain many definitions), we'll have a separate table for this relationship say, wordForms which contains the occurrence of the word, id/ids of definitions and id of the text.
Please correct me if I got it wrong.

Hi all,
I’ve seen a few different data models for inflected languages — one that treats nouns/verbs/etc. and their respective inflections as individual, unique lemmas, and others (such as what we do with the visualizing Russian project) where all inflections are children of a parent node (in nominative/infinitive). How this translates into the Mongo universe I’m not exactly sure (unfortunately Mongo is not my forte, as Luke knows I am a graph databases person), so I defer to you all on this, though Luke it seems like what you’ve laid out is very sensical!
Chris

On May 23, 2016, at 3:48 PM, Suhaib Khan<EMAIL_ADDRESS>wrote:
If I understand this correctly, it makes perfect sense.
We have separate tables for definitions and text. As we have a many-to-many relationship between definitions and text (a definition may be present in many texts and a text may contain many definitions), we'll have a separate table for this relationship say, wordForms which contains the occurrence of the word, id/ids of definitions and id of the text.
Please correct me if I got it wrong.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/cltk/cltk_frontend/issues/60#issuecomment-221075748

Hey all, chiming in about pulling the data from Perseus. @lukehollis are you thinking of hitting Perseus's URL (eg, http://www.perseus.tufts.edu/hopper/morph?l=arma&la=la)? If so, I think this is great, though suggest that we do this once (as a scrape) and not bother with it again. If we persist, I believe JSON/Mongo would be adequate for now. (Perhaps save a large JSON blob to file, then allow for it to be loaded into Mongo/etc).
Another option for you is to use the original Perseus files. I'll warn that this will lead some maddening string manipulation, but is theoretically possible.
My understanding is that this info from the Perseus API is basically a view into the file latin-analyses.txt (35MB), which is in the cltk/latin_pos_lemmata_cltk repo. So, you'd look at the line 49590 and you'll see the line:
arma	{6338412 9 arma	 	neut nom/voc/acc pl}{6405166 9 arma_,armo	To arm	pres imperat act 2nd sg}

Some tips on parsing this:

The brackets ({ and }) contain each distinct dictionary headword
The long numbers (6338412) are the unique id of each dictionary headword
I forget what the short number (9) means
The test are typical parts of speech tags, however the order in which they appear might not be always predictable

Then you could look up the headwords in one of the Perseus dictionaries (like the OLD at cltk/latin_lexica_perseus).

@suheb, I think that structure sounds good, and that you've got a good grasp on the issue. Thanks for clarifying the application for other languages, @christophermorse.
@kylepjohnson, thanks for this. It looks like parsing the original Perseus files would be a lot of work--do you think that the value added by this would be much more than parsing the HTML?

do you think that the value added by this would be much more than parsing the HTML?

@lukehollis No, I do not see any value inherit to parsing the original Perseus files.

Closed with https://github.com/cltk/cltk_frontend/pull/74


No way to get device callbacks

I am trying to detect when an input device is added on android to update UI. However deviceCallback is private in AndroidMidiAccess. How is one supposed to receive these events? I tried using stateChanges but it always issues 3 changes when I plug/unplug a cable

As you tried, it is implemented to invoke MidiAccess.stateChanged() event handler function (not very cool API, only one handler can be set).
It simply dispatches what Android MIDI API emits. If your Android platform emits 3 changes then you will receive 3 events. But I don't think that's the case. It is more likely that you write app in Jetpack Compose and your app triggers multiple state changes for one event. If you still have doubts in ktmidi MidiAccess implementation, maybe please give me some repro code / project so that I can investigate?

These events are fired for each port. If I connect my piano for example, 3 ports are opened, 1 input and 2 output ports, thus 3 state changes.
However one (including me) would like to know when a device has been successfully opened for example. Androids midi API provides a callback for that when calling openOutput().
I would suggest making a unified Midi access listener that receives not just on send but also these device connected/disconnected calls or alternatively a separate listener just for these callbacks

Ah okay I understand what you meant. However it is not what ktmidi MidiAccess is like. It is basically following how Web MIDI API organize ports without the concept of "devices". It is by design. If you need platform specific features like this, you should directly use Android MIDI API.


omnisharp not recognizing xunit

when using omnisharp as my LSP in neovim (native LSP), it doesn't seem to be able to recognize xunit.
this third party LSP can recognize it no problem: https://github.com/razzmatazz/csharp-language-server
when I try to build tests with xunit, this is what omnisharp tells me:

here is my neovim LSP config:
-- Omnisharp
-- C# LSP
local pid = vim.fn.getpid()
local omnisharp_bin = "omnisharp"
require'lspconfig'.omnisharp.setup{
    cmd = { omnisharp_bin, "--languageserver" , "--hostPID", tostring(pid) };
}

--require'lspconfig'.csharp_ls.setup{}

after finding this log entry
[DEBUG][2021-11-12 13:59:40] .../vim/lsp/rpc.lua:496    "rpc.receive"    {  jsonrpc = "2.0",  method = "window/logMessage",  params = {    message = 'OmniSharp.MSBuild.ProjectLoader: The "GetReferenceNearestTargetFrameworkTask" task could not be instantiated from the assembly "/usr/lib/mono/msbuild/Current/bin/NuGet.Build.Tasks.dll". Please verify the task assembly has been built using the same version of the Microsoft.Build.Framework assembly as the one installed on your computer and that your host application is not missing a binding redirect for Microsoft.Build.Framework. Specified cast is not valid. | ',    type = 1  }}

we determined that the version of mono on my machine was different than what omnisharp was expecting. I switched my omnisharp package to
https://aur.archlinux.org/packages/omnisharp-roslyn-bundled/
and it seems to be working now.


Missing multipleOr tests for status parameter tests

AU Core mandates support for multipleOr for the status search parameter. Need to add to:

1.19.04 Optional Server returns valid results for Procedure search by status
1.19.07 Optional Server returns valid results for Procedure search by patient + status
1.17.07 Optional Server returns valid results for MedicationRequest search by status
1.17.09 Server returns valid results for MedicationRequest search by patient + intent + status
1.11.05 Optional Server returns valid results for Observation search by status (and equivalent in other Observation profiles)
1.11.09 Server returns valid results for Observation search by patient + category + status (and equivalent in other Observation profiles)

Hello @dt-r
I can do this manually; it's not a problem. But I have a question: where can I find information about 'multipleOr' in the Implementation Guide files?
I want to understand why the generator is missing 'multipleOr.' I'm trying to find information about 'multipleOr' in the IG 0.3.0-ballot, and I can only find '_multipleOr' in SearchParameter-au-core-clinical-patient.json and SearchParameter-au-core-practitionerrole-practitioner.json.

multipleOr is defined on each Profile page. That should also be in the documentation element of CapabilityStatements.
As with chained elements, the way to programmatically declare support for multipleOr is to profile a SearchParameter, and then when a search parameter is referenced in the CapabilityStatement to point to the AU Core SearchParameter instead of the FHIR definition. CapabilityStatements do not have inline entries for things like multipleOr, chained elements, modifiers, or comparators.

Hello @dt-r
multipleOr is defined on each Profile page.

If I understand correctly, the algorithm to determine the "multipleOr" attribute for the searchParameter should proceed as follows:

Check the SearchParameters profile;
If a profile for the SearchParameter does not exist, check the default FHIR SearchParameter.

Is it correct?

Hello @dt-r
multipleOr is defined on each Profile page.

If I understand correctly, the algorithm to determine the "multipleOr" attribute for the searchParameter should proceed as follows:

Check the SearchParameters profile;
If a profile for the SearchParameter does not exist, check the default FHIR SearchParameter.

Is it correct?

I'm asking about it because in the current case, for example, "Procedure.status," I can't understand where the multipleOr attribute is set to True.

There is no specific SearchParameter profile for "Procedure-status."
There is no "multipleOr" attribute for "Procedure-status" within the search parameters FHIR file at https://hl7.org/fhir/search-parameters.json.

AU Core adds the multipleOr requirement in narrative e.g. if present in the CapabilityStatement itself it would be in the documentation element. The way to do this structurally is for AU Core to define a search parameter. AU Core does not yet have done this - it is unlikely to do so in R1.

You are welcome to suggest that AU Core adds in more profiled SearchParameters to the IG via adding a JIRA change request. I don't think it will make it into R1. I am on the fence at which release of AU Core we may introduce this to. It is rare for an IG to do anything more than document in narrative the use of chained params or multipleOr etc. because almost no-one is using those artefacts. I'd be interested to see how many people would want to use them and how.

@dt-r Hello
I got it! Thank you.

The fix for this issue will be merged.
Now, multipleOr and multipleAnd requests are independent tests. It's simpler to read and understand.
https://github.com/hl7au/au-fhir-core-inferno/pull/75

Hello @dt-r
Changes related to this ticket should be available on the server. Could you retest it?

Moved to "on-hold" status; to be discussed at Sparked tooling meeting 24/6.
Check:

for testing support for multipleOR search on a parameter when combined with other search parameters, is it acceptable to implement this test independently? Whilst perhaps not robust, I think it's adequate for the purposes of testing a system's capability to support AU Core. Separate issues to be raised as enhancements, if needed.
for Procedure search by patient + status and Observation search by patient + category + status which are both have a conformance expectation of SHOULD, is it acceptable for the independent multipleOR tests to have a conformance expectation of SHALL? i.e. the SHALL support for multilpleOR is conditional on whether claiming support for the SHOULD combined parameters search.

Moved to "on-hold" status; to be discussed at Sparked tooling meeting 24/6. Check:

for testing support for multipleOR search on a parameter when combined with other search parameters, is it acceptable to implement this test independently? Whilst perhaps not robust, I think it's adequate for the purposes of testing a system's capability to support AU Core. Separate issues to be raised as enhancements, if needed.
for Procedure search by patient + status and Observation search by patient + category + status which are both have a conformance expectation of SHOULD, is it acceptable for the independent multipleOR tests to have a conformance expectation of SHALL? i.e. the SHALL support for multilpleOR is conditional on whether claiming support for the SHOULD combined parameters search.

24/6 Infra&Tooling meeting - agreed that for AU Core capability testing, it is reasonable to implement tests for "multipleOr" search and "multipleAnd" search separately.

@projkov I have discussed with Michael Wilson and we think the multipleOR tests for:

Procedure search by patient + status, and
Observation search by patient + category + status

should be Optional tests. We can leave the conformance (SHALL/SHOULD) out/empty or mark it "SHOULD".

@StephThaoOng
I want to clarify about the second item in the list. We already have these tests as optional. I'm talking about:
1.3.09 Optional (SHOULD) Server returns valid results for Observation search by patient + category + status (as an example)
1.18.07 Optional (SHOULD) Server returns valid results for Procedure search by patient + status
Or I missing something?

the multipleOR tests for:

Procedure search by patient + status, and
Observation search by patient + category + status

should be Optional tests. We can leave the conformance (SHALL/SHOULD) out/empty or mark it "SHOULD".

Hi @projkov sorry for the copy/paste error. The above was intended the read:
The test for multipleOR search on status in the Procedure and Observation test suites should be optional if implemented separately since the combined search is SHOULD.
What are your thoughts?

the multipleOR tests for:

Procedure search by patient + status, and
Observation search by patient + category + status

should be Optional tests. We can leave the conformance (SHALL/SHOULD) out/empty or mark it "SHOULD".

Hi @projkov sorry for the copy/paste error. The above was intended to read: The test for multipleOR search on status in the Procedure and Observation test suites should be optional if implemented separately since the combined search is SHOULD. What are your thoughts?

Hello @StephThaoOng
I guess I understand now.
We have separate tests for "multipleOr" status search like:

(SHALL) Server returns valid results for Observation multipleOr search by status
(SHALL) Server returns valid results for Procedure multipleOr search by status

I need to make them optional and mark them as SHOULD. Am I right?

Hello @StephThaoOng I guess I understand now. We have separate tests for "multipleOr" status search like:

(SHALL) Server returns valid results for Observation multipleOr search by status
(SHALL) Server returns valid results for Procedure multipleOr search by status

I need to make them optional and mark them as SHOULD. Am I right?

Yes make them optional tests. My preference, for example for Procedure, is:
title 'Server returns valid results for Procedure multipleOr search by status'
      description %(If a server supports searching by patient + status on the Procedure resource, the server SHALL support searching by multipleOr
status. This test will pass if resources are returned and match the search criteria. If
none are returned, the test is skipped.

But open to however you'd like to change it, as long as it's an optional test.
I've just noted that the Inferno US Core Test Kit implements the tests for multipleOR search on status on Procedure and Observation profiles within the combined search test. Despite this, I think can move forward with making them separate, optional tests for now. Thanks @projkov

@StephThaoOng Hello Steph
Multiple OR tests for status in Procedure and Observation are optional and should have a SHOULD prefix. You can re-test it. Thanks!


Phony dependencies make building unnecessarily difficult

The current dependencies are implicitly phony, therefore they are always rebuilt. This is unnecessary and when a build fails, all dependencies are rebuilt, even those that were successfully built.
I suggest using make as (I think) it is intended to, and let the target specify a file that must be newer than the source files.

Working with a phony target is good. But we assume that only developers needs to do that (when debugging) and it only to be done once. Also you can specify the target name to build a single library instead of simply using 'make all' or 'make'.

Actually this is probably a bit late, but my point was that currently everyone is working with a phony target, not just the developers. I am aware of the fact that it is possible to rebuild a single target, and I have used that.


[#503]Migration to JDK11+

For consistency with the other ABs, let's update AB-2 to JDK11.
Fortunately the codebase can be ported without any changes.
[1/2] Updated travis to use Oracle JDK 11
[2/2] Updated references to JDK 8 to JDK 11 in the Developer Guide.

@j-lum

[1/2] Updated travis to use Oracle JDK 11
[2/2] Updated references to JDK 8 to JDK 11 in the Developer Guide.

You don't need to add this to the PR description ;-) In fact, most of the time I don't even look at the PR description since it's not entered into Git history.

In fact, most of the time I don't even look at the PR description since it's not entered into Git history.

Still, I must still quantify this by saying that PR descriptions can still be useful for PRs with multiple commits ;-)


Notebook for Minimum Spanning Tree Algorithms

In NetworkX, MSTs are generated via 3 different algorithms:

Kruskals Algorithm
Prims Algorithm
Boruvka Algorithm

I aim to create a notebook explaining how each algorithm works in NetworkX while making it as simple and understandable as possible.

@MridulS @rossbar Should I create a sample draft notebook before adding it into the proposal? Also would it be a good idea to consider it for the proposal or should I look into other algorithms?

@MridulS Could you have a look at this notebook, I don't want to commit any changes yet because I have to convert to MD format first. Please let me know how I can improve this.

I know you guys are super swamped but any inputs from your end would be great! @rossbar @MridulS

Oh alright, sure. But do you think it's a good algorithm to work on for the proposal? I have also added 2 other issues around which I would like to work, could you kindly have a look at them and let me know if adding them to the proposal would be alright?

Alright thanks a lot for the heads-up!


Request: config.mk to contain includes for external libraries

Some libraries used by MFEM internally (e.g. SuiteSparse, or SUNDIALS) require extra additions to the include path in order for a downstream application that only uses MFEM to compile.
In the same way that config.mk exposes MFEM_EXT_LIBS it would be nice if we could expose MFEM_INC which included all the options required to compile if you only include mfem.hpp.

In config.mk, such include paths are already part of MFEM_TPLFLAGS which in turn is part of MFEM_INCFLAGS which in turn is part of MFEM_FLAGS.
Typically examples and miniapps are compiled with MFEM_FLAGS and linked with MFEM_LIBS which both include external MFEM dependencies.

OK, so reclassing this as a bug, I have a cmake build compiled against sundials and suitesparse but MFEM_TPLFLAGS is empty. Attaching CMake cache to help diagnose (seemingly the sundials examples compile fine though)
CMakeCache.txt

Oh, and the resultant installed config.mk is:
config.mk.txt

I see that you are using the config.mk generated by the CMake build system -- the export function for that has some limitations and you probably are seeing one of them. I'll try to diagnose and fix the issue.
If you use the GNU make build system, then the generated config.mk should be a lot more reliable.

Can you try replacing MFEM_TPL_INCLUDE_DIRS with TPL_INCLUDE_DIRS here: https://github.com/mfem/mfem/blob/52162982a8052a174b79a5ec314c9fb7256afa62/config/cmake/modules/MfemCmakeUtilities.cmake#L897

That patch fixes the issue for me.

That patch fixes the issue for me.

Okay, I'll add the bugfix directly to #3384.

The bugfix is in PR #3384.
Thanks for reporting this issue @ianabel!


Polkadot v0.9.16

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 40.563%

Totals

Change from base Build<PHONE_NUMBER>:
1.7%

Covered Lines:
95

Relevant Lines:
175

💛  - Coveralls


What version of python are these files targeting?

The knowledgebase sample for quickstarts needs the pip install information for all packages it needs.


Fix ssd bug

The old version is boxes += np.tile((left, top), 2).

Yes the old version introduces a bug, #1285.


chore: Add initial .gitattributes

Rather than renormalizing the line endings this just adds the gittattributes for when you fix that later

Thanks @nschonni for the contribution, but we've been here before a couple of times, see #964 & #1686. I've talked at length with our docs platform engineering team, and they have this item on their backlog to apply to existing repositories. So I'm again going to decline this PR.

No problem, I thought the file without the changes would be ok, since it was added to the baseline config last year https://github.com/MicrosoftDocs/feedback/issues/362#issuecomment-402889434


Add Cypress Support

What problem does this feature solve?
Add Support to work smoothly with Cypress (34k stars)
The user experience goal is the dev tools work similarly to the normal context, but inside the cypress runner.
I do see
https://github.com/gitpod-io/gitpod/issues/2715
https://github.com/vuejs/devtools/issues/353
But as far as I can tell

The playbook context has been implemented as a first class citizen?
The deeper links in those issues, that I was able to see, are to legacy code bases, archived repos, generally not active, or not solved.
The solution of opening it in another tab to get veux state is better then nothing but is not good

Overall I think there should be a clear process to get this working with Cypress.
What I have so far is:

Manually load the package by going Extensions > Manage Extensions > Loadunpacked -> Browse to VueJS in Google\Chrome\User Data\Default\Extensions

...?
What does the proposed API look like?
If there is some clear guidance on this I missed please let's post it here so we at least know status of dev on this issue.

vue-devtools 6.x supports iframes, but afaik Cypress doesn't have any API to integrate devtools and Chrome extensions.

@Akryum what about integrating with standalone devtools? the method in #353 above successfully connects to a standalone devtools, but being able to view and interact with components is inconsistent.

Hi people!
So, what we have?
The Vue official documentation recommends us to use Cypress to test our Vue components. But vue devtools is not working in cypress environment. The simple question - WHY? And how can we test and debug our components without devtools?
Dear Vue developers! Please solve this problem!!!

This might help integrate the extension into cypress directly:
https://www.npmjs.com/package/cypress-browser-extension-plugin

Might it be the case that vue-devtools will not detect iframes which are ready to inspected if window.top has a Vue app that doesn't want to be inspected?
I am getting:

Vue.js is detected on this page.
Devtools inspection is not available because it's in production mode or explicitly disabled by the author.

See more details here: https://github.com/vuejs/devtools-v6/discussions/2184


Creation of production build is compiling files in mocks folders

Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes
Environment
Environment Info:
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Binaries:
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 42.17134.1.0
Internet Explorer: 11.0.17134.1
npmPackages:
react: ^16.7.0 => 16.7.0
react-dom: ^16.7.0 => 16.7.0
react-scripts: 2.1.3 => 2.1.3
npmGlobalPackages:
create-react-app: Not Found
Steps to Reproduce
I noticed that react-scripts build command is compiling files from __mocks__ folder (where manual mocks are stored to be used by jest). I have imported "devDepencency" to one .ts file in such folder and building process has failed.
(Write your steps here:)

Create project with __mocks__ folder.
Add "devDependency" to file in __mocks__ folder.
Try to build the solution.

Expected Behavior
Solution has compiled successfully.
Actual Behavior
Compilation has failed, because cannot find dependency in mock file.

Hi @MKMZ, this is very strange and should not be the case. Can you share an example project?


APP-414: [C] Display endpoint key hash in Credentials demo

/cc @Slash32 @vadimol

Although the PR is approved, it must be updated in order to pass Travis


Ismail

@ktismail123 You have added the function "getAllDefendersList" two times in the file src/app/services/admin.service.ts. Please keep one function.


Roll Flutter Engine from 78e8475ddbd7 to 22b8532ed9e7 (1 revision)

https://github.com/flutter/engine/compare/78e8475ddbd7...22b8532ed9e7
2023-11-03<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YS7vrarYI-cH to ho9FqsUD0hxh
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Serve BibXML URLs for RFCs without leading zeros

Describe the issue
At the moment BibXML service only servers RFCs that provide four digits.
For example:

https://bib.ietf.org/public/rfc/bibxml/reference.RFC.0001.xml
https://bib.ietf.org/public/rfc/bibxml/reference.RFC.0771.xml

These URLs don't work:

https://bib.ietf.org/public/rfc/bibxml/reference.RFC.1.xml
https://bib.ietf.org/public/rfc/bibxml/reference.RFC.771.xml

BibXML Service should serve URLs with RFC number <1000 with and without leading zeros.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Thanks @kesara .
@stefanomunarini @strogonoff could we help with this? Thanks.

For the record, we had situations previously where we fuzzy-matched paths, so that more than one path would match a document, and it caused comments like this asking us to 404 paths that do not conform to specific scheme. (However, that concerned I-Ds, not RFCs.)
@kesara or someone can you confirm here the requirement to have multiple /public/rfc/bibxml/ paths match a single RFC?

I'll confirm this.
We have a legacy issue with accepting leading 0s filling to 4 digits for RFCs1 through 999. We want the variant without the leading zeros to start working.
When we get to rfc10k (which is not so far away), paths ending in, e.g., RFC.12345.xml must work (once RFC12345 is issued).
Any %04d-like formatting in the code should be inspected and carefully walled away to serve the legacy case above.

also look for %4.4d, which some systems use as a synonym for %04d

In this case, if we were to serve https://bib.ietf.org/public/rfc/bibxml/reference.RFC.1.xml , how would the rest of the data look like? Meaning, shall the value of reference.ancor, reference.target and seriesInfo.value be updated to have leading 0s or not? In the latter case, data would look like this:
<reference anchor="RFC1" target="https://www.rfc-editor.org/info/rfc1">
  <front>
    <title>Host Software</title>
    <author fullname="S. Crocker" initials="S." surname="Crocker"/>
    <date month="April" year="1969"/>
  </front>
  <seriesInfo name="RFC" value="1"/>
  <seriesInfo name="DOI" value="10.17487/RFC0001"/>
</reference>

Yes, what you propose (no leading zeros in the payload) is the right thing to do.

For now, leading zeros will have to exist for the DOI, but I'll see if the RPC can register DOI without the 0s as well.

comments like this

Did you mean to point to the code here, or was there a discussion to point to instead?

I must have messed up pasting the link, my bad. There was a comment in another issue discussing 404s on I-Ds (or lack thereof, in that case). I’ll find it again but it’s probably not 100% pertinent to the expectations of RFC API consumers.

comments like this

Did you mean to point to the code here, or was there a discussion to point to instead?

I must have messed up pasting the link, my bad. There was a comment in another issue discussing 404s on I-Ds (or lack thereof, in that case). I’ll find it again but it’s probably not 100% pertinent to the expectations of RFC API consumers.

Are you perhaps referring to #268 ? @strogonoff


Scada interface

What is the problem / what does the code in this PR do
With this PR we implements a simple python-scada interface like in hax.
Can you briefly describe how it works?
We access the scada database via the two web APIs GetSCLastValue and GetSCData. SCADA stores only values which changes. Hence when GetSCData is used to query a time range in which for the given parameter no value had been stored, nothing is returned by the API. To circumvent this problem the data is read as follows:

An empty pandas DataFrame is initialized with a 1 sec spacing (sampling frequency of SCADA).
GetSCLastValue is called to check when the last value of the specified parameter was recorded, given the time range queried by the user. (star)
GetSCData is used to get all data which had been recorded within the given time interval. This data is filled into the DataFrame.
All empty values in the DataFrame are filled via forward filling.

(star) this point requires a change in the GetSCLastValue  and is currently not yet implemented.
In order to have a convenient way to access the time ranges via a run_id I had to do some minor modifications in strax which are detailed here https://github.com/AxFoundation/strax/pull/318.
Can you give a minimal working example (or illustrate with a figure)?
A MWE can be found in this notebook

Good, catch with the "future" values. It does not fail, but I think in case the user asks for some future values the minimal thing we should do is to print a warning, but I think it would be even better to return nans and the user shall decide how to project values into the future.

Okay implemented all comments and updated the example notebook.

Okay fixed all comments, also added the possibility to interpolate between data points and to "down sample" the data (picking every nth point). I also updated the example accordingly.


Port the generative gestultung book examples

Would be amazing to port the examples from the amazing generative gestultung book to work in nannou as well. http://www.generative-gestaltung.de/code
Potentially could then offer links on the website just like they currently have processing and vvvv links.

examples to be ported over are:
01_P

[ ] P_1_0_01
[ ] P_1_1_1_01
[ ] P_1_1_2_01
[ ] P_1_2_1_01
[ ] P_1_2_2_01
[ ] P_1_2_3_01
[ ] P_1_2_3_02
[ ] P_1_2_3_03
[ ] P_1_2_3_04
[ ] P_2_0_01
[ ] P_2_0_02
[ ] P_2_0_03
[ ] P_2_1_1_01
[ ] P_2_1_1_02
[ ] P_2_1_1_03
[ ] P_2_1_1_04
[ ] P_2_1_2_01
[ ] P_2_1_2_02
[ ] P_2_1_2_03
[ ] P_2_1_2_04
[ ] P_2_1_3_01
[ ] P_2_1_3_02
[ ] P_2_1_3_03
[ ] P_2_1_3_04
[ ] P_2_1_3_05
[ ] P_2_2_1_01
[ ] P_2_2_1_02
[ ] P_2_2_2_01
[ ] P_2_2_2_02
[ ] P_2_2_3_01
[ ] P_2_2_3_02
[ ] P_2_2_3_02_T
[ ] P_2_2_4_01
[ ] P_2_2_4_02
[ ] P_2_2_5_01
[ ] P_2_2_5_02
[ ] P_2_3_1_01
[ ] P_2_3_1_02_TABLET
[ ] P_2_3_2_01
[ ] P_2_3_3_01
[ ] P_2_3_3_01_TABLET
[ ] P_2_3_3_01_TABLET_TOOL
[ ] P_2_3_4_01
[ ] P_2_3_5_01_TABLET
[ ] P_2_3_6_01
[ ] P_2_3_6_02
[ ] P_3_0_01
[ ] P_3_1_1_01
[ ] P_3_1_2_01
[ ] P_3_1_2_02
[ ] P_3_1_3_01
[ ] P_3_1_3_02
[ ] P_3_1_3_03
[ ] P_3_1_3_04
[ ] P_3_1_4_01
[ ] P_3_2_1_01
[ ] P_3_2_1_02
[ ] P_3_2_2_01
[ ] P_3_2_3_01
[ ] P_4_0_01
[ ] P_4_1_1_01
[ ] P_4_1_2_01
[ ] P_4_1_2_02
[ ] P_4_2_1_01
[ ] P_4_2_1_02
[ ] P_4_2_1_footage
[ ] P_4_2_2_01
[ ] P_4_2_2_02
[ ] P_4_3_1_01
[ ] P_4_3_1_02
[ ] P_4_3_1_02_analyse_svg_grayscale
[ ] P_4_3_2_01
[ ] P_4_3_3_01
[ ] P_4_3_3_02

02_M

[ ] M_1_1_01
[ ] M_1_2_01
[ ] M_1_3_01
[ ] M_1_3_02
[ ] M_1_3_03
[ ] M_1_4_01
[ ] M_1_5_01
[ ] M_1_5_02_TOOL
[ ] M_1_5_03_TOOL
[ ] M_1_5_04_TOOL
[ ] M_1_6_01_TOOL
[ ] M_1_6_02_TOOL
[ ] M_2_1_01
[ ] M_2_2_01
[ ] M_2_3_01
[ ] M_2_3_02
[ ] M_2_4_01
[ ] M_2_5_01
[ ] M_2_5_02_TOOL
[ ] M_2_6_01_TOOL
[ ] M_2_6_01_TOOL_TABLET
[ ] M_3_1_01
[ ] M_3_2_01
[ ] M_3_2_02
[ ] M_3_2_03
[ ] M_3_2_04
[ ] M_3_2_05
[ ] M_3_3_01
[ ] M_3_3_02
[ ] M_3_3_03
[ ] M_3_3_04
[ ] M_3_4_01_TOOL
[ ] M_3_4_02
[ ] M_3_4_03_TOOL
[ ] M_3_5_01
[ ] M_4_1_01
[ ] M_4_2_01
[ ] M_4_2_02
[ ] M_4_2_03
[ ] M_4_2_04
[ ] M_4_3_01_TOOL
[ ] M_4_4_01_TOOL
[ ] M_5_1_01
[ ] M_5_2_01
[ ] M_5_3_01
[ ] M_5_4_01
[ ] M_5_5_01_TOOL
[ ] M_6_1_01
[ ] M_6_1_02
[ ] M_6_1_03
[ ] M_6_2_01
[ ] M_6_2_02
[ ] M_6_3_01
[ ] M_6_4_01_TOOL


query-string-append feature question/request

I'd like to see a feature in iframeResizer that allows me to provide a string to append to the query string for all framed pages. That is, when the user clicks a nav link within the frame the QSA value provided will persistently be appended to all query strings.
So, for example, if I call iFrameResizer({qsa:"framed=1"}) then all URLs within the iframe will contain whatever URL was in the link plus the "framed=1" parameter. This allows me to omit some content or style it differently when I know that I or some other authorized web developer is containing it within an iframe.
Does a feature like this already exist?

You could add something like this to your pages, so that they update their links once the iFrame has resized.
<script>
  window.iFrameResizer = {
     readyCallback: () =>
         document.getElementsByTagName('a').forEach(a => a.src = a.src + '?framed=1')
  }
</script>


OriginMemory is now final in BaseWritableBufferImpl. Several changes

needed to make this work.
Moved ZERO_SIZE_BUFFER/MEMORY to BaseWritable*Impl so it is independent
of endianness. Also moved final static initializer.
Private empty constructors should be at the top of the file where they
can be easily found. Found a few instances where they were at the
bottom.
NioBits, Utf8 and Util needed a private empty ctors.
Removed tests that were no longer valid.

Coverage decreased (-0.01%) to 96.491% when pulling 8aa3acbb83a278cba4aa9bfde145c0ad33530c1b on FixAsBufferAsMemory into 2f5af82346737296541c6863793c0fda5995bb91 on master.


Change Project Card style

Change the styling of the Project Card to something below

please assign me I want to work under LGMSOC'21 as a participant

please assign me I want to work under LGMSOC'21 as a participant

You can start working on this issue. You are given 6 days to complete this.

@WebVishal bro, are you working on it?

Hey @WebVishal, This is your last day to submit your PR.

Hey @ShwetKhatri2001 wiuld you like to work on this issue?

Sure, You can assign

Sure, You can assign

Okay, I will assign you once you complete the other one.

I would like to work on this issue under LGMSOC'21.Please assign it to me.

Sure, You can assign

Okay, I will assign you once you complete the other one.

You can assign this issue now, I have completed my other issues.

Sure, You can assign

Okay, I will assign you once you complete the other one.

You can assign this issue now, I have completed my other issues.

Go Ahead. You are given 6 days to complete this.


Content - apis and od camp

Changes navigation to merge Get the Data and How It Works menus
Creates initial API overview page, NB: aimed at community not accessible
Creates news story for OD Camp
Fixes typo in "report an infringement" link
NB: currently missing image for ODCamp news item
NB2: navigation changes need a careful check by someone with a local server

@Floppy
GCe is off today. Can one of the team:
a) check these changes to make sure they make sense (you know what I mean I think, i.e. don't be frit of saying it makes no sense)
b) get the image in Ruby's draft:
https://docs.google.com/a/openaddress.es/document/d/1MGdtdZOjS2e6DHv4sCkE7V0f5lQVRROcJYq00FSRQGs/edit
to show in this news post:
https://github.com/OpenAddressesUK/theodolite/commit/9cf4e960274715ccfe1c46887c19cd4942192de3
I left a placeholder with some Alt Imagey text referencing "Dwarnalism" but after that point my l33t skillz become a little more like very very bad dad dancing.....

OK, this is all good and ready to go. I tweaked a couple of the links, but it was mostly fine.


BUG: Dipole.data attribute not created when using read_dipole() for certain files

Found when trying to reproduce HNN-GUI tutorials. Reproduced via:
from urllib.request import urlretrieve
from hnn_core import read_dipole
data_url = ('https://raw.githubusercontent.com/jonescompneurolab/hnn/master/data/MEG_detection_data/S1_ongoing.txt')
urlretrieve(data_url, 'S1_ongoing.txt')
exp_dpl = read_dipole('S1_ongoing.txt')
exp_dpl.plot()

or...
data_url = ('https://raw.githubusercontent.com/jonescompneurolab/hnn/master/data/MEG_detection_data/no_trial_S1_ERP_all_avg.txt')
urlretrieve(data_url, 'no_trial_S1_ERP_all_avg.txt')
exp_dpl = read_dipole('no_trial_S1_ERP_all_avg.txt')
exp_dpl.plot()

Indeed for some reason the attribute is not created for this object.

I'm guessing this has to do with the fact that this dipole file only has 2 columns

@jasmainak @rythorpe can I work on this?

You're sure the data array used to instantiate the Dipole object has shape (600, 1000)? That's a huge array and somewhat surprising....

@rythorpe I tried to print the shape dpl_data that is being read inside the read_dipole() method from the file.

And then ran the first script mentioned above in the description

Got this as the output. The shape is given to be (600, 1001)

Also, @aritrasinha108 let's get your other PR completed first before starting another.

Yeah, sure, I'll finish up my previous PR and then only look into it.

Sure enough. I don't think I've worked with the S1_ongoing.txt data file before which turns out to be quite larger than the others. The problem is that the data getting passed to the Dipole constructor doesn't meet any of expected shape requirements. We should add appropriate checks that throw an error when the expected read-in data shape is violated and discuss reformating the S1_ongoing.txt data file.

@rythorpe can the checks be added as a fix for this issue? please let me know if  its something I can work on

First we'll need to decide how to handle the current S1_ongoing.txt file, since it's formatting is an outlier among the other experimental dipole .txt files and represents a rare use-case that we probably don't want to support. I'd wait on this until @jasmainak @ntolley @chenghuzi can weigh in.

I would suggest starting with the other file no_trial_S1_ERP_all_avg.txt in the PR description since that is the usual format I have seen. Which tutorial has the S1_ongoing.txt file @ntolley ?

close issue?

Closing in favor of #617


fix(import): allow + , * and : in enums (#1181)

Backport
This will backport the following commits from 2.x to 1.x:

fix(import): allow + , * and : in enums (#1181)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1211

Questions ?
Please refer to the Backport tool documentation


Benchmark-trt-compiler

Description
Benmark the new trt compiler feature.
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:

[x] Codeformat tests passed locally by running ./runtests.sh --codeformat.
[ ] In-line docstrings updated.
[ ] Update version and changelog in metadata.json if changing an existing bundle.
[ ] Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
[ ] Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
[ ] Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
[ ] Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
[ ] Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

CC @borisfom .
Thanks.

I have updated https://github.com/Project-MONAI/model-zoo/pull/620


Test latest Django install on Mac

Assigned to @cjjm
We have just upgraded WeVoteServer to Django 2.1.5 and we need help testing the installation process. Please install this on your Mac:
https://github.com/wevote/WeVoteServer/pull/1004
...and then install https://github.com/wevote/WebApp  on your Mac and connect with your local WeVoteServer. You will need to pull over some election data from our live WeVoteServer, so please reach out to<EMAIL_ADDRESS>when you need help.

Done!


"purge-endpoint" fails sometimes during "after-suite" because Session is closed

Environment: the service (jdk-8) runs locally with jetty. The citrus tests (2.5.2), run with maven-failsafe-plugin. DB: Postgresql, JMS: HornetQ.
In our service tests we enqueue messages onto the IN-queue, the service does magic and produces a message on the OUT-queue. Most tests use receive-actions to validate the message. But not all messages are received, or maybe a test-build fails. That's why we like to purge the OUT-Q at the end of all tests. According to the documentation the "After Suite" would be the place to clean up JMS destinations. So we use the testcase:after-suite with action "purge-endpoint".
Sometimes messages are indeed purged (received), but other times, the logging shows an IllegalStateException: Session is closed. I suspect that connections are being closed in a parallel process which sometimes results in a failure while purging the JMS endpoint (hornetq-queue).
Can you confirm/fix this? Thanks in advance!
Kind regards,
Erik Loosman
Failure example:
[INFO ] 14-06-2016 12:46:22 GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@5ed828d: startup date [Tue Jun 14 12:45:42 CEST 2016]; root of context hierarchy
[INFO ] 14-06-2016 12:46:22 SequenceAfterSuite - Entering after suite block
[ERROR] 14-06-2016 12:46:22 SequenceAfterSuite - After suite action failed purge-endpointNested exception is:
org.springframework.jms.IllegalStateException: Session is closed; nested exception is javax.jms.IllegalStateException: Session is closed
        at org.springframework.jms.support.JmsUtils.convertJmsAccessException(JmsUtils.java:279)
        at org.springframework.jms.support.JmsAccessor.convertJmsAccessException(JmsAccessor.java:169)
        at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:497)
        at org.springframework.jms.core.JmsTemplate.receiveSelected(JmsTemplate.java:754)
        at org.springframework.jms.core.JmsTemplate.receive(JmsTemplate.java:733)
        at org.springframework.jms.core.JmsTemplate.receive(JmsTemplate.java:724)
        at com.consol.citrus.jms.endpoint.JmsConsumer.receive(JmsConsumer.java:67)
        at com.consol.citrus.messaging.AbstractSelectiveMessageConsumer.receive(AbstractSelectiveMessageConsumer.java:50)
        at com.consol.citrus.actions.PurgeEndpointAction.purgeEndpoint(PurgeEndpointAction.java:114)
        at com.consol.citrus.actions.PurgeEndpointAction.doExecute(PurgeEndpointAction.java:83)
        at com.consol.citrus.actions.AbstractTestAction.execute(AbstractTestAction.java:42)
        at com.consol.citrus.container.SequenceAfterSuite.doExecute(SequenceAfterSuite.java:58)
        at com.consol.citrus.actions.AbstractTestAction.execute(AbstractTestAction.java:42)
        at com.consol.citrus.junit.TestSuiteExecutionListener$AfterSuiteShutdownHook.run(TestSuiteExecutionListener.java:102)
        at java.lang.Thread.run(Thread.java:745)
Caused by: javax.jms.IllegalStateException: Session is closed
        at org.hornetq.jms.client.HornetQSession.checkClosed(HornetQSession.java:1216)
        at org.hornetq.jms.client.HornetQSession.getTransacted(HornetQSession.java:194)
        at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at org.springframework.jms.connection.CachingConnectionFactory$CachedSessionInvocationHandler.invoke(CachingConnectionFactory.java:386)
        at com.sun.proxy.$Proxy26.getTransacted(Unknown Source)
        at org.springframework.jms.core.JmsTemplate.doReceive(JmsTemplate.java:804)
        at org.springframework.jms.core.JmsTemplate.doReceive(JmsTemplate.java:784)
        at org.springframework.jms.core.JmsTemplate$9.doInJms(JmsTemplate.java:757)
        at org.springframework.jms.core.JmsTemplate$9.doInJms(JmsTemplate.java:754)
        at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:494)
        ... 12 more
[ERROR] 14-06-2016 12:46:22 SequenceAfterSuite - Continue after suite actions
[INFO ] 14-06-2016 12:46:22 Citrus -
[INFO ] 14-06-2016 12:46:22 Citrus - AFTER TEST SUITE: FAILED

Success example
[INFO ] 14-06-2016 12:49:29 SequenceAfterSuite - Entering after suite block
[INFO ] 14-06-2016 12:49:29 GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@44c8afef: startup date [Tue Jun 14 12:49:16 CEST 2016]; root of context hierarchy
[INFO ] 14-06-2016 12:49:29 JmsConsumer - Received JMS message on destination: 'OUT_Q'
[INFO ] 14-06-2016 12:49:29 CachingConnectionFactory - Established shared JMS Connection: org.hornetq.jms.client.HornetQConnection@4faf1215
[INFO ] 14-06-2016 12:49:29 JmsConsumer - Received JMS message on destination: 'OUT_Q'
[INFO ] 14-06-2016 12:49:30 PurgeEndpointAction - Purged message endpoints
[INFO ] 14-06-2016 12:49:30 Citrus -
[INFO ] 14-06-2016 12:49:30 Citrus - AFTER TEST SUITE: SUCCESS

This is because Spring TestNG test support closes the application context automatically after all tests are finished.
The shutdown process of the application context is done before after suite actions in Citrus are started. Then shutdown and after suite actions are running in parallel as you suggested. I need to find out if we can influence the order of after suite operations so Citrus actions are executed before the application context is shut down.


SET UP KANBAN

Kanban Setup and Management (Team Member 2):
Set up a Kanban board using a preferred project management tool (e.g., Trello, Jira, Asana) to track the progress of tasks, prioritize work, and manage workflow efficiently.
Configure the Kanban board with relevant columns such as "To Do," "In Progress," "Review," and "Done," reflecting the different stages of task completion.
Customize labels, tags, or swimlanes to categorize tasks by priority, type, or team member, providing clear visibility into project status and task ownership.
Collaborate with team members to populate the Kanban board with tasks, ensuring that each task is well-defined, actionable, and appropriately assigned.
Regularly update the Kanban board by moving tasks across different columns as they progress through the workflow, ensuring transparency and alignment with project goals.
Facilitate daily stand-up meetings or asynchronous updates to discuss task progress, address blockers, and adjust priorities based on team feedback.
Monitor key metrics such as task cycle time, lead time, and throughput to identify bottlenecks, optimize workflow, and continuously improve team productivity.

Hi,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not contain a screenshot of the kanban board.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a link to the kanban board.  Also, I can't find any kanban boards in the repo:

MAke sure that the kanbna is set to public because I can't access it if it exists.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a link to your Kanban board.  Also, I can't find any kanban boards in the repo that I can access.
Kindly make the kanban board public in the case it exists.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

[ ] Kindly, add points to each task.  After doing that, double check that no one in the team has more than 5 points than any other member.

[ ] The columns do not meet the project's requirements.  There should be 4:  To do, in progress, in review, done.

[ ] The title of the ticket should be a summary, not the whole description.  The description should go to the "description" field of each task.

[ ] Please, read the project requirements and be sure to follow them closely.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻

[ ] According to the project requirements:

Kindly, add a description to this task:

Also, kindly add how many people are on the team in the issue description:

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


🐛 Bug Report:  Inconsistency in User Verification Status between Email and Phone Number

👟 Reproduction steps

To trigger this bug, begin by accessing the Auth,
Create a new user account and navigate to the user profile to verify the account.
Start the verification process for both the email address and the phone number associated with the user account. Initially, verify the email address, which should proceed smoothly.
Next, attempt to verify the phone number, Despite the successful verification of the email address, the system incorrectly indicates that the user is unverified when verifying the phone number.
In an attempt to rectify this inconsistency, proceed to unverify the phone number. Unexpectedly, the system now displays an alert indicating that the user is verified, contradicting the initial indication of being unverified.

👍 Expected behavior

When the user hits Verify Phone, the alert should confirm that the user is verified.
When the user hits Unverify Phone, the alert should confirm that the user is unverified.

👎 Actual Behavior
When attempting to verify the phone number, an alert incorrectly states that the user is unverified.
However, when attempting to unverify the phone, the system incorrectly indicates that the user is verified.
🎲 Appwrite version
Version 1.4.x
💻 Operating system
Windows
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

We want to update the alerts to be specific to say:

XYZ's email has been verified
XYZ's email has been unverified
XYZ's phone has been verified
XYZ's phone has been unverified

[!NOTE]
The "s" should only be there if the name does not end with s. For example, if the user's name was "Charles", it should be "Charles' email has been verified"

Hi, assuming that the previous PR has some issues since it hasn't been merged so far. Can I take over this issue?

@pushkar707
Since it doesn't merge that doesn't mean the PR have issues, PRs been merged according to the priority level!

i can work on this issue


Use same session if running multiple tasks in serial

Currently running multiple blocks in serial will run each in a distinct session.
This should be changed so that they all use the same session, so as to be consistent with the extension/expected behaviour.

This is actually not true 😅


Revert "build(deps): bump goreleaser/goreleaser-action from 5.0.0 to 6.0.0"

Reverts radoslav-dev/minder#53

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.652%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6876

Relevant Lines:
14739

💛  - Coveralls


[WFLY-16965] Upgrade to SmallRye OpenApi 3.0.0

https://issues.redhat.com/browse/WFLY-16965
Needs a core release containing https://issues.redhat.com/browse/WFCORE-6044

Duplicate of #16026


Sharing a SpiDriver between multiple Devices with different configs

Im currently trying to get multiple SpiDeviceDrivers out of SpiDriver cause the devices have different configs. Borrowing worked for compiling but all the time I try to create the second DeviceDriver the esp get stuck in execution.
Is there first an easy way to share to share a SpiBus here with out these issues and is there additional documentation for such cases?
I tryed
let mut spi_device_driver =
        SpiBusDriver::new(&mut spi, &config).expect("Failed to init spi flash!");
spi_device_driver.write(b"as");
spi_device_driver.write(b"as");
spi_device_driver.write(b"as");
spi_device_driver.write(b"as");
spi_device_driver.write(b"as");
info!("have send");
let config = config::Config::new()
        .baudrate(4000000.into())
        .bit_order(config::BitOrder::MsbFirst)
        .write_only(true)
        .input_delay_ns(0)
        .data_mode(MODE_0);

let mut spi_device_driver2 =
        SpiBusDriver::new(&mut spi, &config).expect("Failed to init spi flash!");
spi_device_driver2.write(b"as");

the Problem here is that my display needs to have a minor delay between 2 bytes what I do in the device via manually pulling the CS to high and the later again to low. I think I found a way by passing Option::::None as cs it is possible to create without setting a pin  thanks.

you can have SpiDeviceDriver A in thread A and SpiDeviceDriver B in thread B yes. Though if you want to share SpiDeviceDriver A in thread A and B you have to lock that yourself.

Thanks


return a subsclice for acl data

Will do!

From what I could tell, the event parsing deals with this already. I've pushed a few other things formatting too.


attach mne.viz.plot_raw() to a pyqt5 gui interface

Hi, If I want to insert the figure mne.viz.plot_raw() produced onto the GUI interface using PyQt5, how do I do it? I did fig = mne.viz.plot(data), while it showed up two figures. One is on my PyQt5 interface which cannot interact with me using the keyboard or the mouse. The other is almost like the figure we sued to plot while when I interact with it, the figure on the gui interface changed.
Here is my code:
import matplotlib
matplotlib.use('Qt5Agg')
from matplotlib.backends.backend_qt5agg import FigureCanvasQTAgg as FigureCanvas
from PyQt5 import QtWidgets
import matplotlib.pyplot as plt
import sys
import mne

class My_Main_window(QtWidgets.QMainWindow):
    def __init__(self,parent=None):
        super(My_Main_window,self).__init__(parent)

        self.resize(800, 659)
        self.menu = QtWidgets.QMenu("绘图")
        self.menu_action = QtWidgets.QAction("绘制",self.menu)
        self.menu.addAction(self.menu_action)
        self.menuBar().addMenu(self.menu)
        self.menu_action.triggered.connect(self.plot_)
        self.setCentralWidget(QtWidgets.QWidget())

    def plot_(self):

        fpath = 'D:\data\plot_test.fif'
        data = mne.io.read_raw_fif(fpath, preload=True)
        fig = mne.viz.plot_raw(data)
        cavans = FigureCanvas(fig)
        self.setCentralWidget(cavans)

if __name__ == '__main__':
    app = QtWidgets.QApplication(sys.argv)
    main_window = My_Main_window()
    main_window.show()
    app.exec()

when I use mne.viz.plot_raw(data, show=False), the other figure disappeared, but I have no way to interact with the figure. I found that type(mne.viz.plot_raw) is the son of class Figure, so I think it is possible to use my code implementate it.

I think you need to use show=False in your statement fig = mne.viz.plot_raw(data), then the figure is drawn in the main window (see also https://www.learnpyqt.com/courses/graphics-plotting/plotting-matplotlib/ for a nice tutorial).

I think you need to use show=False in your statement fig = mne.viz.plot_raw(data), then the figure is drawn in the main window (see also https://www.learnpyqt.com/courses/graphics-plotting/plotting-matplotlib/ for a nice tutorial).

Thank you so much and I did setshoe=False. I will dig into this tutorial.

and I also need  to write callbacks so the figures can be interactice like you guys implementated.

@BarryLiu-97 can you explain the big picture of what you to do?  Are you trying to build a GUI like mnelab?

@BarryLiu-97 can you explain the big picture of what you to do? Are you trying to build a GUI like mnelab?

Yeah, something like that. But more like an interest.

A good chance to practice python and mne.

@BarryLiu-97 I think your request is pretty similar to #8142.  Can you look at that issue and see if these are similar enough that one of them could be closed (and the other one made more general, if needed)?

@BarryLiu-97 I think your request is pretty similar to #8142. Can you look at that issue and see if these are similar enough that one of them could be closed (and the other one made more general, if needed)?

Yes it is similar. Mine can be closed. I think it may be a general issue if people want to embed the interactive figure inside a gui.

I will close mine and if there are any issues, I will ask there.

perfect


Reply to reviews

Not sure, if anybody is still listening to these issues here: is it somehow possible to answer to reviews on the app market? I would like to convert some bad reviews to issues on GitHub and solve them. For example for the Wordpress app. Now I’m neither able to analyse the issue nor to get in touch with the author of the review to let him or her know that I want to help.

Well, listening happens sometimes but nobody's working on app market code, sadly. :|

Thanks. Then I try to do my best to make the apps better without that. I’ll leave it up to you to close this issue or to leave it open for someone who might work on it in the future.

I can't close issues, but I don't think it should be closed, you're not the first person to want this!


SKLearnForQlik

The PyTools Server not Started. I remarked the SKLearnForQlik  in __main
__.py and  the Server is running
import numpy as np
import pandas as pd
from pandas.api.types import is_string_dtype
from pandas.api.types import is_numeric_dtype
import _utils as utils
from _prophet import ProphetForQlik
from _clustering import HDBSCANForQlik
#from _sklearn import SKLearnForQlik
from _spacy import SpaCyForQlik
from _common import CommonFunction
Screenshots

Environment:

Windows 2016
Qlik Sense
SSE Version

Additional context
Add any other context about the problem here.
thank you very much

Hi @Apostolis12 , the solution for this is the same as issue #70. Please take a look at my response there.

Closing this issue as a solution has been provided.


Telescope theme updates

Huge thanks for putting this together!
I've swapped out some of the colors on Telescope - wondering if you would consider merging something like this to the project (darker colors for popup, removal of / less aggressive borders, etc).
Before

After

Thanks!

This looks nice. Would you mind sharing your customized highlights?
We could add an option to toggle between default style and flat style.

@andyrichardson What font are you using?

Here is a very similar highlight group
hl.plugins.telescope = {
    TelescopeBorder = colors.Red,
    TelescopePromptBorder = colors.Cyan,
    TelescopeResultsBorder = colors.Cyan,
    TelescopePreviewBorder = colors.Cyan,
    TelescopeMatching = { fg = c.orange, fmt = "bold" },
    TelescopePromptPrefix = colors.Green,
    TelescopeSelection =  { bg =c.bg2 },
    TelescopeSelectionCaret = colors.Yellow
}

I have a fork with this here but I think the best bet would be to have it be an optional config.


rewrite givenTest using builder patter

something like this should be possible
givenTest(this)
    .withMocks()
    .withValues();

Other aproach was chosen.
givenTest will still inject all uninitialized fields.
In future, field annotations will be introduced that allow to include/exclude specific field.
givenTest will be annotated with @Beta.


Support LuaJIT

Amazing project. I love the idea of getting more things into Zig.
I saw you are hosting Lua 5.4 inside the project. Is there anything that would prevent running LuaJIT as an alternative? LuaJIT is a significantly faster runtime (admittedly, if you care about speed you don't use an interpreter language) which would make this even more appealing to me.
Downsides of LuaJIT: no real integers and no built-in UTF8 support, so that could make the interface more complicated.

It's absolutely feasible, a compile-time switch would be the best.

I can confirm that Zoltan works with LuaJIT2.
The way I tested this was by linking a static libluajit.a library using exe.addObjectFile("/path/to/libluajit.a"); which has been compiled externally with zig cc. This also required building LuaJIT with LUAJIT_NO_UNWIND;
I also had to make a minor modification to convert lua_pcallk calls to lua_pcall.
Seeing as LuaJIT has a significantly more complex build system (including invoking custom tools such as buildvm), converting this to a pure zig build will be significant work.


Update README to clarify installing Sysl using python

Run following command to install Sysl on Mac
$ pip install sysl
Expected behaviour
Install Sysl successfully
Actual behaviour
$ pip install sysl
Requirement already satisfied: sysl in /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sysl-0.2.0-py2.7.egg
Collecting httplib2 (from sysl)

Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection
broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at
0x110259d50>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or
not known',)': /simple/httplib2/

Could not find a version that satisfies the requirement httplib2 (from sysl) (from versions: )
No matching distribution found for httplib2 (from sysl)`

Steps to reproduce the behaviour
Run $ pip install sysl on Mac terminal

I have just run this command with Python 2.7.15 on macOS 10.13.5 without any problems.
I suspect your issues results from running the command on a corporate network.
The environment guide (linked from the README at the bottom of the Development section) might hold the solution.


sonar init, what are collectors?

Per the docs, I'm running sonar --init, and I'm being asked to select a collector. I have a choice of cdp and json. I've got no idea what a collector is, or cdp. I know what json is obviously, but... yeah, no idea. I'm going to select json, but I think there are two things here:

the quick start should let us know about this prompt and give us some context as to what to pick
the CLI should maybe add a bit more text?

Oops, not json, jsdom. So yeah, Ill just pick cdp because it's first, but I hate not knowing what I'm doing. :)

I hate not knowing what I'm doing. :)

Yes, we should improve things that are not obvious.

Per the docs

@cfjedimaster What docs did you read exactly? https://sonarwhal.com/docs/user-guide/?

Sorry - just the quick start.

just the quick start.

Ok, we should improve that.
@cfjedimaster Can you look over https://sonarwhal.com/docs/user-guide/ and let us know if that clarifies things? Thanks!

I believe I grok it a bit now. Maybe the quick start can add a short sentence saying to just accept the defaults and that you can go to X for details on collectors and formatters).

Related?: https://github.com/sonarwhal/sonar/issues/286 :)

Yeah - perhaps. I like connector too, but as I've been a sonar user for like 2ms, I'll hold off on voting. ;)

but as I've been a sonar user for like 2ms, I'll hold off on voting. ;)

Quite the opposite, you have a fresh perspective on things, and that helps!

Sure - done. I still haven't been able to use Sonar due to #327 - but hopefully that gets corrected soon.


colmap: init at 3.5

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

I have no such errors. How do you run a colmap? I have tested

colmapWithCuda on the server without gui using command:
colmap automatic_reconstructor --image_path ./images/ --workspace_path ./
on my laptop:
colmap gui

I just ran colmap gui. Honestly I think qt is set up really weirdly on my system because I have never managed to get any theme to work

@GrahamcOfBorg build colmap colmapWithCuda


Add Map.map

Fixes #34
All terms check.

You and Victor fixed the problem at the same time. reference


Allow hooking into responses

Related: https://github.com/unjs/nitro/issues/1396
Currently, it is not possible to hook into responses (that are handled by h3 not directly with res.end). In order to do this, we might refactor app.ts and allow hooking into directly returned responses and allow to hook into using custom callback onBeforeResponse(event, { body }).
This can be later used by higher order frameworks to support custom response rewrite handling and logging.
At this point, i also like to gether some common usecase ideas before moving forward (mainly because it also adds some overhead even if callback is not used)

Just had this today and my use-case would be custom error messages per "middleware" which afaik is currently not possible. Please correct me if I'm wrong.
router.post('/', (event) => somethingThatPotentiallyErrors())

router.onBeforeResponse((event) => {
  if (event.data instanceof Error) return { status: 'error', message: event.data.message }
  return { status: 'ok', ...event.data }
}

It is needed for stuff like treblle-utils by treblle.com . Then I feel like we are missing out? Cuz there is a solution for this in Express and Fastify.

It is needed for stuff like treblle-utils by treblle.com . Then I feel like we are missing out? Cuz there is a solution for this in Express and Fastify.

I agree that this feature is needed, however looking at Trebble docs (for the first time); I think its possible to integrate it with h3 without hooking into the response.
Look at how the Koa integration is made.

Thanks for the feedbacks @Hebilicious, @emdede and @tobychidi ❤ 3 hooks will be supported in next release (see #482)


Support for DIP parameter name patterns

Parameters with names like this
rt_mgdXBounds_1 = 1.0e-01
rt_mgdXBounds_2 = 1.0e+00
rt_mgdYBounds_3 = 1.0e+01
rt_mgdYBounds_4 = 1.0e+02
rt_mgdZBounds_5 = 1.0e+03
rt_mgdZBounds_6 = 1.0e+04

could be defined in DIP like e.g.
rt_mgd*Bounds_* float eV
    !pattern ['X','Y','Z']
    !pattern "[0-9]{3}"

in order to avoid repeating patters

The above example can be solved by creating an array. The additional complication is not worth of implementing.


Hex/Proficnc Cube Orange Change console to UART7

Hex/Proficnc Cube Orange Change console to UART7 which is the default console UART

I believe this was done to work around ads-b the the (default?) orange carrier board.
One idea would be to turn that into a generic serial port (TELEM) in the default build and separately have a console config (that I'd use on the hardware test rack).

@dagar You are right, then we can close the PR.

Just an FYI, the change back to CONS / UART7 was included in one of my PRs recently, since I do all my testing on non-ADSB carrier boards..

Since it sounds like I'm the only one with the ADSB carrier board let's just leave it and I'll change it locally when I need to

Since it sounds like I'm the only one with the ADSB carrier board let's just leave it and I'll change it locally when I need to

I believe it's default now?
If things are working reasonably well it might be time to split the build and reclaim the port. I'll open a PR.


Possibility to specify the database connection for the Meta model

In some cases, storing the data in a connection other than the default connection, maybe some No-SQL database could be useful, so my suggestion is to let configure the connection of the meta model through the config file.

Would you be willing to send a PR?

@marijoo yes, already working on it 👍🏼

Please remember to add some testing. I’m not sure how this will work with the joins defined here.

@marijoo sure, I did the change it was easy but yeah after running the tests it's breaking a lot of them https://github.com/kolossal-io/laravel-multiplex/compare/main...inquid:laravel-multiplex:database-connection-config and the joins logic will be a problem, I was thinking maybe it will be easier in case someone needs to create a model and specify it in the config file, or even to inherit from the Meta model and do the changes in there.

So you’re okay with closing this for now?


Multiple tag blocklist

Exports what's necessary to use the multiple tag blocklist, where one URL/domain can lead to multiple tags.

Codecov Report

Merging #4 (4f2b5aa) into dev (63fccf9) will increase coverage by 14.41%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##              dev       #4       +/-   ##
===========================================
+ Coverage   37.37%   51.78%   +14.41%
===========================================
  Files           2        2
  Lines          99      112       +13
===========================================
+ Hits           37       58       +21
+ Misses         62       54        -8

Impacted Files
Coverage Δ

src/blocklist.rs
57.14% <ø> (ø)

src/blocklist_multi.rs
48.57% <85.71%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Feature: utxo

Pull request related to this trello task

:tada: This PR is included in version 1.1.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Update DbStructure.hs

Backport column name detection in public schema for <IP_ADDRESS>

Cool, is there a commit adding tests you can cherry pick as well?

I will look and see, if not I guess I can write one to tack onto this branch.

Sorry I forgot that I said I would add a test to that other PR. I'll do that, and merge it. Then you can use it for your backport.

OK, the change and tests are now available in commit 84f68c6. It doesn't cherry-pick cleanly onto 0.3.x in git, but give it a try and see if you can use it for this pull request.

@krakrjak have you had a chance to take a look at that commit?

@begriffs I have been messing with it trying to make a more wholistic 3.2.1 with as much as possible back ported. The rebase and manual merging is a bit tedious, but seems to be going well. I'll make sure I have a working build -> test going and update the branch. I will push tonight or tomorrow.

I have updated my clone's 0.3.x branch to the latest efforts. I feel like it's really close, I'm down to 5 errors in the test suite to investigate. I figured I'd share it at this point in case I'm hopelessly lost :)
This PR should be closed in favor of #856 if that looks tractable.

Given we're not going ahead with the larger backport, is this particular feature still of interest to you?

Yes, both this and the feature of not requiring the database to know about the JWT secret are my pet features. The larger backport is unnecessary. The initial commit in this PR (without the test harness or the other backported patches) would be nice to see in a 3.2.1 or whatever makes sense.

This makes sense, I can merge after you get the tests green again. CI shows this error:
test/Feature/QuerySpec.hs:316:
1) Feature.QuerySpec, Plurality singular, can detect fk relations through views to tables in the public schema
     status mismatch:
       expected: 200
       but got:  400

(Still willing to review and merge if you get the test suite to pass)

Perhaps we should close this for now?


Closing webview should go back to signed out activity.

When the auth view window is closed without completing auth, the signed out activity should be shown.
Instead, the auth activity launches over and over again.
https://github.com/firezone/firezone/assets/167144/0cbd95f4-32d0-44d7-972b-ba978a4e5bf4

@pratikvelani This still seems to be an issue. Sometimes closing the WebView closes the app, sometimes it relaunches Auth, and sometimes it goes to the Signed out state:
Screen_recording_20231010_161314.webm


feat: add LinkRule linker

Description

Add a new linker based on a new CRD that defines how to infer parent from the child
Related issues

Special notes for your reviewer:

Codecov Report
Patch coverage has no change and project coverage change: +1.39 :tada:

Comparison is base (2d2a0b6) 34.72% compared to head (ca058d3) 36.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   34.72%   36.12%   +1.39%
==========================================
  Files          31       31
  Lines        2439     2475      +36
==========================================
+ Hits          847      894      +47
+ Misses       1529     1519      -10
+ Partials       63       62       -1

Impacted Files
Coverage Δ

pkg/k8s/k8s.go
2.81% <0.00%> (-0.05%)
:arrow_down:

pkg/k8s/k8smock.go
29.78% <0.00%> (-0.65%)
:arrow_down:

pkg/util/object_ref.go
0.00% <ø> (ø)

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lint broken due to golangci/golangci-lint#3938