openhantek6022: 3.2.5 -> 3.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/OpenHantek/OpenHantek6022/releases.
meta.description for openhantek6022 is: "Free software for Hantek and compatible (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes"
meta.homepage for openhantek6022 is: "https://github.com/OpenHantek/OpenHantek6022"
meta.changelog for openhantek6022 is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS>.macos with grep in /nix/store/vhfsay12x3h6ihllabd3b55n6pa0sg1q-openhantek6022-<IP_ADDRESS>.macos
found <IP_ADDRESS>.macos in filename of file in /nix/store/vhfsay12x3h6ihllabd3b55n6pa0sg1q-openhantek6022-<IP_ADDRESS>.macos

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
openhantek6022

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vhfsay12x3h6ihllabd3b55n6pa0sg1q-openhantek6022-<IP_ADDRESS>.macos \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openhantek6022 https://github.com/r-ryantm/nixpkgs/archive/e2f0ad7010688d58cd7005d7d4ce509982e4ef36.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vhfsay12x3h6ihllabd3b55n6pa0sg1q-openhantek6022-<IP_ADDRESS>.macos
ls -la /nix/store/vhfsay12x3h6ihllabd3b55n6pa0sg1q-openhantek6022-<IP_ADDRESS>.macos/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

openhantek6022

Maintainer pings
cc @baracoder for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/OpenHantek/OpenHantek6022/releases.
meta.description for openhantek6022 is: "Free software for Hantek and compatible (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes"
meta.homepage for openhantek6022 is: "https://github.com/OpenHantek/OpenHantek6022"
meta.changelog for openhantek6022 is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.1 with grep in /nix/store/w4p4w3xv7w70d1fydh8dc6gdplpy6bxj-openhantek6022-3.3.1
found 3.3.1 in filename of file in /nix/store/w4p4w3xv7w70d1fydh8dc6gdplpy6bxj-openhantek6022-3.3.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
openhantek6022

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w4p4w3xv7w70d1fydh8dc6gdplpy6bxj-openhantek6022-3.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openhantek6022 https://github.com/r-ryantm/nixpkgs/archive/6130491cdf2ab4ceceeea8c07bbaf1d02080374a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w4p4w3xv7w70d1fydh8dc6gdplpy6bxj-openhantek6022-3.3.1
ls -la /nix/store/w4p4w3xv7w70d1fydh8dc6gdplpy6bxj-openhantek6022-3.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

openhantek6022

Maintainer pings
cc @baracoder for testing.

Result of nixpkgs-review pr 183690 run on x86_64-linux 1

1 package built:

openhantek6022


Persist service after first request

We still have the advantage of zero downtime restarts but given this is on the only service on the machine we can just run it all the time

@mergify queue

@mergify rebase

@mergify queue

cc @Lassulus

@mergify rebase


[CH] Optimize table error with spark standalone cluster

Backend
CH (ClickHouse)
Bug description
Reproduce sqls as follows:
create database if not exist local;
use local;
CREATE EXTERNAL TABLE customer  (
 c_custkey    bigint not null,
 c_name       string not null,
 c_address    string not null,
 c_nationkey  bigint not null,
 c_phone      string not null,
 c_acctbal    double not null,
 c_mktsegment string not null,
 c_comment    string not null)
 USING PARQUET
LOCATION 'file:///data/tpch100/customer';

create database if not exist s3;
use s3;
CREATE EXTERNAL TABLE customer  (
c_custkey    bigint not null ,
c_name       string not null ,
c_address    string not null ,
c_nationkey  bigint not null ,
c_phone      string not null ,
c_acctbal    double not null ,
c_mktsegment string not null ,
c_comment    string not null )
USING clickhouse
CLUSTERED by (c_custkey) SORTED by  (c_custkey) INTO 45 BUCKETS
TBLPROPERTIES (delta.checkpointInterval=5, storage_policy='__s3_main')
LOCATION 's3a://gluten-cicd/dataset/tpch100-mergetree-bucket-compact/customer';

insert into s3.customer select * from local.customer order by c_custkey;
optimize s3.customer

Error msg

Debug info:

Root Cause
After insert data to s3.customer, spark executor node will keep part of file mapping metadata, not all. If merge tasks contains part that file mapping not exist on current node, error occurs.
Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
No response

UT Reproduce


Joyride/Tour modal popup

Whats the syntax to use the tour as a modal popup?

The modal don't work?

I'm not sure what you mean or what you're trying to do. We have two separate components here, Modal and a tooltip-based Tour.

step 3 here: http://foundation.zurb.com/sites/docs/v/5.5.3/components/joyride.html

Ah, no we don't have support for that. In our Tour component, steps are defined on their target elements so there's really no way to define a tour step without a target element.

thats what I thought :D

if I get time I'll patch it and pu tin apull request


removing outdated code block examples

all examples are in docs now, will eventually have user guide and examples rendering in docs

You'll also have to regenerate the add_graphic Mixin after.

@clewis7 can you just check quick that this is everything, regenerate mixin, and then mark for review so CI runs?


[Security Practice] pip-tools should not store API tokens/any credentials in generated lockfiles

When generating hashed pypi dependencies with pip-tools, I notice it wants to write API tokens into those lock files.
This is not a good idea as  a developer can write that to their code repository.
Shouldn't this be stripped from the lockfile?
Thanks,
Shawn

Hey @spstarr,
Thanks for the issue! Yes, the API tokens should be stripped. Could you provide an example of your lock file with stripped sensitive data?


Connection refused but Kunai is ok

Running Kunai in a VM (https://www.turnkeylinux.org/lampstack) and starting the service using
/etc/init.d/kunai start

It complains about a refused connection but status it's ok
Starting kunai
Traceback (most recent call last):
  File "/usr/bin/kunai", line 353, in <module>
    CLI.one_loop(command_args)
  File "/usr/bin/kunai", line 194, in one_loop
    f(*cmd_args, **cmd_opts.__dict__)
  File "/usr/local/lib/python2.7/dist-packages/Kunai-0.9-py2.7.egg/kunai/cli/agent/cli.py", line 157, in do_info
    d = get_kunai_json('/agent/info')
  File "/usr/local/lib/python2.7/dist-packages/Kunai-0.9-py2.7.egg/kunai/cli/__init__.py", line 14, in get_kunai_json
    return get_json(uri, local_socket)
  File "/usr/local/lib/python2.7/dist-packages/Kunai-0.9-py2.7.egg/kunai/unixclient.py", line 99, in get_json
    (code, r) = get_local(uri, local_socket=local_socket, params=params)
  File "/usr/local/lib/python2.7/dist-packages/Kunai-0.9-py2.7.egg/kunai/unixclient.py", line 90, in get_local
    request = url_opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 401, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 419, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
    result = func(*args)
  File "/usr/local/lib/python2.7/dist-packages/Kunai-0.9-py2.7.egg/kunai/unixclient.py", line 69, in unix_open
    return self.do_open(UnixHTTPConnection(unix_socket), new_req)
  File "/usr/lib/python2.7/urllib2.py", line 1181, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
. ok

I'm interested with the new dev version, there are far more logs.

I close the ticket as no news, and that the codedid changed a lot since this date :)


Timeout when trying to use gimbal

I've connected a gimbal to a Pixhawk 4 running PX4 via PWM1. Furthermore, a Raspberry Pi is connected via the TELEM port. My parameter list can be downloaded here. MAVSDK version is 1.4.8.
When I try to run the gimbal example , substituting the SITL address for the physical connection, I get the following exception as soon as any gimbal command is executed:
Traceback (most recent call last):
File “gimbal.py”, line 61, in
asyncio.run(run())
File “/usr/lib/python3.7/asyncio/runners.py”, line 43, in run
return loop.run_until_complete(main)
File “/usr/lib/python3.7/asyncio/base_events.py”, line 584, in run_until_complete
return future.result()
File “gimbal.py”, line 23, in run
await drone.gimbal.set_mode(GimbalMode.YAW_FOLLOW)
File “/home/pi/venv_mission/lib/python3.7/site-packages/mavsdk/gimbal.py”, line 484, in set_mode
raise GimbalError(result, “set_mode()”, gimbal_mode)
mavsdk.gimbal.GimbalError: TIMEOUT: ‘Timeout’; origin: set_mode(); params: (<GimbalMode.YAW_FOLLOW: 0>,)

The takeoff_and_land script manages to connect to the Pixhawk, so the hardware connection seems to be fine.

Are you sure that your gimbal is sending MAVLink messages and that they reach MAVSDK?

@JonasVautherin It's not a MAVLink gimbal, it only works via a PWM channel. I used this gimbal before in other builds and the gimbal commands worked even when the gimbal wasn't connected at all.
As for MAVLink communication between MAVSDK and the Pixhawk, I don's see anything in QGroundControl's MAVLink Inspector. Is there another way?

I'm afraid, it works now and I haven't got a clue why.
My RPi has an LTE-module, which couldn't connect, because I left the antennas off. When I booted with the antennas on, the LTE connection was properly initialized and from that moment on, the gimbal started working. Don't know if there is any relation, but that is all I can say...

Oh... so this can be closed then? :blush:

I was going to comment that you might want to consider updating the PX4 version because gimbal support has been improved since v1.12 (what it says in the params file).
But anyway, if it's working now, I'll close this.


nixos/sshd: disable openFirewall by default

Opening SSH port on firewall is a security risk and it should be blocked by default.
I thought this was an urgent issue so I didn't use proper branching and had to create a new PR.
Sorry for the duplicate.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

We should see if @edolstra finds this to be an acceptable compromise. This satisfies issues he has raised in the past, so I think there is a chance he would be accepting of this.

This would be okay, though I still think that the case where you want sshd enabled but you don't want it exposed in the firewall is a pretty rare one. So the current situation has my preference.

One possible scenario would be having two interfaces and assigning one of them as trusted interface with networking.firewall.trustedInterfaces. As you can access to trusted interface freely,  one may think that the other interface is safe while it is not.

One possible scenario would be having two interfaces

This is my scenario. I set openFirewall to false and then explicitly open port 22 for a given interface.

Of course you are right. This is a rare situation. However SSH is a dangerous thing when it is unchecked by firewall. I think we should maximize security whenever possible.

if I'm not mistaken, it'll add an extra not that obvious step to the installation process - not only enable sshd but open port for it.

@Frostman posting a clear message to the screen in an assertion if the user hasn't explicitly opened the firewall will clarify any confusion. All services except openssh require the user to explicitly open a port in the firewall.
Personally I'm somewhat indifferent to this PR, but the change has been requested a number of times and it seems like a reasonable solution to me. Since @edolstra seems to find this solution acceptable enough maybe we just wait and see more opinions :man_shrugging:

Hi everyone. It has been a year since I opened this PR (time passes :confused:). Should we merge this for 21.05?
I've changed the default setting to false and utilized stateVersion. Is this okay or the explicit assertion should be there indefinitely? With this change, NixOS will have openFirewall = false policy for all packages, no exceptions. Best wishes!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/ssh-openfirewall-exception/12066/1

I would agree with eelco. If i were to do sevices.sshd.enable = true; I would expect to be able to ssh to the machine. The use cases where you would want the firewall to close the port, but have sshd active seems much less likely than the normal use case.

I'm in favor of this change! IMO it doesn't make sense to be inconsistent and have only openFirewall set to true by default for this service.
SSH is usually the only protocol used to connect to servers on a daily basis so I get why people like to have it enabled per default. But IMHO I would never want a server with a public IP to expose port 22 globally anyway just because of the log noise that would be generated. Especially since passwordAuthentication is also true per default.
Closing the SSH port is also often wanted as soon as a device has more than one interface. This includes virtual interfaces like VPN.
I also consider it a good thing when newcomers learn how ports can be opened in the firewall by having to do it. I think the assert statement would do a good job for that purpose. Therefore I personally would like to have the default set to NULL as a "compromise" (and not default to false for >=21.05).

I'm not entirely sure yet if I'm in favor of this, but if it gets merged, we'll also need

a note in the release-notes.
IMHO having this flag set (commented out though) in nixos-generate-config.pl

I would certainly go for this change if after a successful nixos-rebuild switch, nixos gave feedback to the user on what ports are currently enabled.
nix-repl> config.networking.firewall.allowedTCPPorts
[ 3000 ]
that way, your reminded what nix expressions are opening what and you audit your machine every time you rebuild ... neat huh?
;-)

This should be doable with nixos-option networking.firewall.allowedTCPPorts or nixops show-option (forgot which arguments come here though). Or do you want to have this in an automated way?

vulnix

I would certainly go for this change if after a successful nixos-rebuild switch, nixos gave feedback to the user on what ports are currently enabled.
nix-repl> config.networking.firewall.allowedTCPPorts
[ 3000 ]
that way, your reminded what nix expressions are opening what and you audit your machine every time you rebuild ... neat huh?
;-)

This makes you to overlook per-interface open ports though.

This makes you to overlook per-interface open ports though.

ah! good point.
networking.firewall.interfaces.wg0.allowedTCPPorts
so it would need to evaluate all interfaces on the machine..  it might be a nice feedback feature! :-)

This makes you to overlook per-interface open ports though.

ah! good point.
networking.firewall.interfaces.wg0.allowedTCPPorts
so it would need to evaluate all interfaces on the machine.. it might be a nice feedback feature! :-)

This is a great idea, if it is not happening in my PR :smile:

This is dependent on use-case. If this change is made, then I will be unable to contact my machines magically when I upgrade my NixOS channels. It's pretty radical. People will have to learn about this implicit default, it will have to be included in the output of nixos-generate-config explicitly. The installer image ought to have openFirewall = true; on by default, for sure. Else, I'd have to do a nixos-rebuild-switch just to remotely install NixOS via ssh.
Currently, my procedure for installation from installer images on a Hetzner VPS or local physical server for me is:

Boot installer ISO
Change nixos user passwd
ssh into the machine remotely
nixos-generate-config --root /mnt
(or whatever else I need to do in order to provision the machine)
nixos-install

After step 3, you could do anything with nixops, deploy-rs, etc. It's quite handy.
The proposed change would make me unable to do this, correct? Disabling ssh by default just messes with provisioning.

AFAIU you won't if you didn't set sshd.openFirewall. If it's null, an eval error will be thrown and thus no bogus config will be deployed.

You are correct @Ma27 - this PR forces the user to explicitly set a value... so no risk of breakage.

AFAIU you won't if you didn't set sshd.openFirewall. If it's null, an eval error will be thrown and thus no bogus config will be deployed.

So does this mean that the default configuration as it is today, made by nixos-generate-config will fail to rebuild?

However, what about the installer image? SSH is enabled on that out-of-the-box. This is nice behavior in my view, because it allows easy provisioning, so even if this is merged, openFirewall should still be set to true on the installer image.

However, what about the installer image? SSH is enabled on that out-of-the-box. This is nice behavior in my view, because it allows easy provisioning, so even if this is merged, openFirewall should still be set to true on the installer image.

I tried to achieve that here. I am not sure if it is enough.

By the way I still think this should be merged :smiley:

unfortunately we not only failed to reach consensus on this, and there are some strong opinions both ways, but support for the change wasn't overwhelming enough that we can accept this
i would say that this PR should be closed at this point

unfortunately we not only failed to reach consensus on this, and there are some strong opinions both ways, but support for the change wasn't overwhelming enough that we can accept this

I just read the thread and disagree with this summary. IMO, the posts that were strongly negative misunderstood the PR and changed their opinion afterwards (maybe not to "positive" but at least not "negative"). Some were indifferent. Some were positive.
I suggest we use this post with thumbs up/down for whether to re-open this PR.

is there enough visibility in this thread? maybe elsewhere is better?
to be clear i think that this is a good idea... but i think a strong consensus needs to be reached here if we were to proceed

IMO, the posts that were strongly negative misunderstood the PR

To be fair, the author didn't bother to update the summary and if the summary says "sshd: disable openFirewall by default", it's fine to already say "no" if you feel that way.
That being said, to me the current approach seems like yet another annoyance pushed to the end user of this NixOS module which is why I prefer the current default. If people strongly feel they don't want to expose their sshd onto the Internet, they may still disable it.

Opening SSH port on firewall is a security risk and it should be blocked by default.

Is it though? I mean, I'm probably a little biased, but I've seen numerous SSH installations being exposed to the internet and that's the way how these were deployed.


Corrected link to issues

linked text was "Issues" with capital "I", it should be "issues" with small letter.

Thanks for spotting!


Adding the ability to disable the CSRF filter via a configuration property

Closing without merging, see discussion in #292


License?

For the rewrite I'm thinking MIT since it's really simple.
Thoughts?

you definitely should.ever since i saw this project come out i loved just as much as the one on the wii!i hope it turns out to be  as big of success as that one.

I personally prefer the Apache License (2.0) or if I want to be very lenient the BSD 3-clause.

@thejsa after looking into it I have decided to switch both DownloadMii and 3ds.js to BSD 4-clause as it seems to do the job well enough :)


Center camera within bounding box

When the initial coordinates prove to be wrong, you move to another part of the globe and zoom in on exactly the right spot, only to find you forgot to take your camera along.
Instead of zooming out again to drag both camera and target in steps to the mentioned spot, wouldn't it be nice to simply have a button that would relocate the camera (and target) to the center of your map?

I know i could do so myself with setCameraAndTargetLatLng(), but maybe this might be useful for everybody?

The Move Camera Back button does this (or press C key) (but this button does not scale the camera, only moves it):

The function that does this is exposed as centerBounds. I could add function fitBounds which not just moves camera to center of map, but also fit the camera to the map's bounding box. @mmmenno what do you think?

Ah, right, sorry. Totally mistook the buttons for a swap between camera- and crosshairmode!
Don't know if Fitbounds is needed, i haven't been working with real data yet. Maybe we should leave it for now - i guess it all becomes less clear when the map starts moving. And besides, when you first press Move Camera Back button, and then Move Camera Back to Map button, you will obtain the same result.

Maybe the buttons need different icons then, do you have suggestions?

I'll try to come up with something - no luck so far.


[All hosts] (JS) Replace var with let/const in JS code

Updates var in Office Add-ins JS code, where applicable.
Minor formatting fixes.

Docs Build status updates of commit 6d43a15:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/correlated-objects-pattern.md
:white_check_mark:Succeeded
View

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded
View

docs/concepts/resource-limits-and-performance-optimization.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/disable-add-in-commands.md
:white_check_mark:Succeeded
View

docs/develop/addressing-same-origin-policy-limitations.md
:white_check_mark:Succeeded
View

docs/develop/application-specific-api-model.md
:white_check_mark:Succeeded
View

docs/develop/asynchronous-programming-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded
View

docs/develop/create-addin-commands.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-handle-errors-events.md
:white_check_mark:Succeeded
View

docs/develop/get-javascript-intellisense-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/develop/itp-and-third-party-cookies.md
:white_check_mark:Succeeded
View

docs/develop/localization.md
:white_check_mark:Succeeded
View

docs/develop/parent-to-dialog.md
:white_check_mark:Succeeded
View

docs/develop/show-hide-add-in.md
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-complex-type.png
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-var.png
:white_check_mark:Succeeded
View

docs/onenote/onenote-add-ins-programming-overview.md
:white_check_mark:Succeeded
View

docs/powerpoint/powerpoint-add-ins.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 81ded06:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/correlated-objects-pattern.md
:white_check_mark:Succeeded
View

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded
View

docs/concepts/resource-limits-and-performance-optimization.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/disable-add-in-commands.md
:white_check_mark:Succeeded
View

docs/develop/addressing-same-origin-policy-limitations.md
:white_check_mark:Succeeded
View

docs/develop/application-specific-api-model.md
:white_check_mark:Succeeded
View

docs/develop/asynchronous-programming-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded
View

docs/develop/create-addin-commands.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-handle-errors-events.md
:white_check_mark:Succeeded
View

docs/develop/get-javascript-intellisense-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/develop/itp-and-third-party-cookies.md
:white_check_mark:Succeeded
View

docs/develop/localization.md
:white_check_mark:Succeeded
View

docs/develop/parent-to-dialog.md
:white_check_mark:Succeeded
View

docs/develop/show-hide-add-in.md
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-complex-type.png
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-var.png
:white_check_mark:Succeeded
View

docs/onenote/onenote-add-ins-programming-overview.md
:white_check_mark:Succeeded
View

docs/powerpoint/powerpoint-add-ins.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cc2a290:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/correlated-objects-pattern.md
:white_check_mark:Succeeded
View

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded
View

docs/concepts/resource-limits-and-performance-optimization.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/disable-add-in-commands.md
:white_check_mark:Succeeded
View

docs/develop/addressing-same-origin-policy-limitations.md
:white_check_mark:Succeeded
View

docs/develop/application-specific-api-model.md
:white_check_mark:Succeeded
View

docs/develop/asynchronous-programming-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded
View

docs/develop/create-addin-commands.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-handle-errors-events.md
:white_check_mark:Succeeded
View

docs/develop/get-javascript-intellisense-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/develop/itp-and-third-party-cookies.md
:white_check_mark:Succeeded
View

docs/develop/localization.md
:white_check_mark:Succeeded
View

docs/develop/parent-to-dialog.md
:white_check_mark:Succeeded
View

docs/develop/show-hide-add-in.md
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-complex-type.png
:white_check_mark:Succeeded
View

docs/images/intellisense-vs22-var.png
:white_check_mark:Succeeded
View

docs/onenote/onenote-add-ins-programming-overview.md
:white_check_mark:Succeeded
View

docs/powerpoint/powerpoint-add-ins.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add profiler for faster animations registry on entity

Removed as the static AnimationHandler #18 fixes the problem too.


Support Desktop Bridge

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I'd like the Quarrel icon to light up when I receive some messages and I'd like it ran in background to deliver faster in-app notifications
Describe the solution you'd like
A clear and concise description of what you want to happen.
Implementing Desktop Bridge
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/UnigramDev/Unigram/issues/1214 at the moment there seem to be a bug that wouldn't allow to have that working that needs to be reported to Microsoft


issue3826/ Wrong repo path leads to unclear error (#3897)

Pull request opened by the merge tool on behalf of #3897

Merged into branches iso5 in 92dbe3e4b35763bd90eccab2281b15694a78abe8


Update Taiwan holidays

Proposed change

Update Taiwan holidays (add substituted holidays according to official sources from 2010).
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 30 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10513

Relevant Lines:
10513

💛  - Coveralls

LGTM 🇹🇼


Bools from awaited functions can't have logic applied to them.

Godot version
4.0.beta10.mono.official [d0398f62f]
System information
macOS Monterey 12.5.1
Issue description
A bool from an awaited function looks normal at first blush, but anything beyond putting it in an if statement morphs it into a GDScriptFunctionState object that behaves differently than you would expect. So if an awaited function returns true, not returned_value will also evaluate to true.
The below code produces this:
   choice_true : true
   choice_true == true : <GDScriptFunctionState#-9223372013400227427>
   not choice_true : <GDScriptFunctionState#-9223372013400227427>
IF (choice_true) :
    TRUE
IF (not choice_true) :
    TRUE                <<<< THIS SEEMS WEIRD

   choice_false : false
   choice_false == false : <GDScriptFunctionState#-9223372011789614676>
   not choice_false : <GDScriptFunctionState#-9223372011789614676>
IF (choice_false) :
    FALSE
IF (not choice_false) :
    TRUE

Steps to reproduce
Run any node with this script to see the issue:
func confirm_choice_true() -> bool:
	await get_tree().create_timer(1).timeout
	return true

func confirm_choice_false() -> bool:
	await get_tree().create_timer(1).timeout
	return false

func _ready():
	var choice_true:bool = await confirm_choice_true()
	print('           choice_true : ', choice_true)
	print('   choice_true == true : ', (choice_true == true))
	print('       not choice_true : ', (not choice_true))

	print('IF (choice_true) :')
	if choice_true: print('    TRUE')
	else: print('    FALSE')

	print('IF (not choice_true) :')
	if not choice_true: print('    TRUE                <<<< THIS SEEMS WEIRD')
	else: print('    FALSE')

	print(' ')

	var choice_false:bool = await confirm_choice_false()
	print('            choice_false : ', choice_false)
	print('   choice_false == false : ', (choice_false == false))
	print('        not choice_false : ', (not choice_false))

	print('IF (choice_false) :')
	if choice_false: print('    TRUE')
	else: print('    FALSE')

	print('IF (not choice_false) :')
	if not choice_false: print('    TRUE')
	else: print('    FALSE')

Minimal reproduction project
FunkyAwaitedValues.zip

The bug is still reproducible in RC 3. GDScriptFunctionState cannot be obtained in this way nevertheless.
It's funny, but if you remove the type hints, then this works correctly:
func confirm_choice_true() -> bool:
    await get_tree().create_timer(1).timeout
    return true

func confirm_choice_false() -> bool:
    await get_tree().create_timer(1).timeout
    return false

func _ready():
    var choice_true = await confirm_choice_true()
    print('           choice_true : ', choice_true)
    print('   choice_true == true : ', (choice_true == true))
    print('       not choice_true : ', (not choice_true))

    print('IF (choice_true) :')
    if choice_true: print('    TRUE')
    else: print('    FALSE')

    print('IF (not choice_true) :')
    if not choice_true: print('    TRUE                <<<< THIS SEEMS WEIRD')
    else: print('    FALSE')

    print(' ')

    var choice_false = await confirm_choice_false()
    print('            choice_false : ', choice_false)
    print('   choice_false == false : ', (choice_false == false))
    print('        not choice_false : ', (not choice_false))

    print('IF (choice_false) :')
    if choice_false: print('    TRUE')
    else: print('    FALSE')

    print('IF (not choice_false) :')
    if not choice_false: print('    TRUE')
    else: print('    FALSE')

           choice_true : true
   choice_true == true : true
       not choice_true : false
IF (choice_true) :
    TRUE
IF (not choice_true) :
    FALSE

            choice_false : false
   choice_false == false : true
        not choice_false : true
IF (choice_false) :
    FALSE
IF (not choice_false) :
    TRUE

Looks like it's a compiler/VM bug, somewhere we trust the data type information too much and don't do the necessary conversions.

One more example:
@tool
extends EditorScript

func _run() -> void:
    var lambda = func (): pass
    print(lambda.get_object()) # <GDScript#-9223370307845225300>
    print((func (): pass).get_object()) # true

@tool
extends EditorScript

func _run() -> void:
    var lambda = func (): pass
    print(lambda.get_object()) # <GDScript#-9223370307845225300>
    print((func (): pass).get_object()) # true

This is still reproducible in 1bd0b296e.

The issue should be closed though. The snippet in the opening of PR works now properly.
The snippet in the last comment does not have anything to do with awaiting or bools. So best to open a separate issue for that.

So best to open a separate issue for that.

Done. See #73998.


[Bug] Cli needs improvements on the display and error messages

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ci
What happened + What you expected to happen

kuberay doesn't print  "compute template" name correctly.

➜  cli git:(master) ✗ kuberay template compute create --cpu 1 --memory 1 --name test
2022/01/27 14:37:51 compute template  is created

worker-group-name is required as well. I think cli validation should give the hints as well.
only head-image and worker-image are given there.

➜  cli git:(master) ✗ kuberay cluster create --head-compute-tempalte test --worker-compute-template test --name test --user jiaxin.shan
Error: required flag(s) "head-image", "worker-image" not set
Usage:

➜  cli git:(master) ✗ kuberay cluster create --head-compute-tempalte test --worker-compute-template test --name test --user jiaxin.shan --head-image rayproject/ray:1.6.0 --worker-image rayproject/ray:1.6.0
2022/01/27 17:03:44 could not create cluster rpc error: code = Unknown desc = Validate cluster request failed.: Invalid input error: WorkerNodeSpec 0 group name is empty. Please specify a valid value.

Default Ray version is incorrect. This is used for meta data tracking. Do we want to make this mandatory? User can still use a different image then.

Reproduction script
I have given the reproduce scripts above
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

The first two have been resolved in upstream
./main template compute create --cpu 1 --memory 1 --name=test-hehe --namespace=ray-system
2022/07/08 09:25:40 compute template test-hehe has been created in ray-system

./main cluster create --user jiaxin.shan --version 1.11.0 --environment DEV --head-compute-template compute-mid --head-image=rayproject/ray:1.11.0 --name=test --namespace=ray-system --worker-compute-template compute-template-test
Error: required flag(s) "worker-group-name", "worker-image" not set
Usage:
  kuberay cluster create [flags]

For the 3rd one, version is optional and we can actually make it mandatory in CLI but  let's just keep it optional now.
https://github.com/ray-project/kuberay/blob/master/apiserver/pkg/server/cluster_server.go#L139-L172
# Without --version, it's not complaining.
./main cluster create  --environment DEV --head-compute-template compute-mid --head-image=rayproject/ray:1.11.0 --name=test --namespace=ray-system --worker-compute-template compute-template-test
Error: required flag(s) "user", "worker-group-name", "worker-image" not set


vs code very slow and doesn't response

Issue Type: Bug
Hi,
I have a big problem with vs code, it is very slow and often doesn't respond.
It is painful to work with.
Thank you in advance for your help.
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T13:22:08.892Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-7020U CPU @ 2.30GHz (4 x 2304)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.90GB (0.45GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.8

prettier-vscode
esb
5.6.0

vscode-xml
red
0.13.0

salesforce-vscode-slds
sal
1.2.1

salesforcedx-vscode
sal
49.9.0

salesforcedx-vscode-apex
sal
49.9.0

salesforcedx-vscode-apex-debugger
sal
49.9.0

salesforcedx-vscode-apex-replay-debugger
sal
49.9.0

salesforcedx-vscode-core
sal
49.9.0

salesforcedx-vscode-lwc
sal
49.9.0

salesforcedx-vscode-visualforce
sal
49.9.0

Please see https://github.com/Microsoft/vscode/wiki/Performance-Issues for creating actionable performance problem issues.


prometheus: remove automatically relabelling kubernetes labels

This may relabel unwanted labels onto the targets and if any labels are
necessary for further querying they can be joined onto the results using
the label metrics available in kube-state-metrics. If it turns out we
need explicit support in the Prometheus Operator then we can reintroduce
it with an explicit whitelisting approach.
@fabxc @mxinden

👍


encoding error : input conversion failed due to input error, bytes 0x21 0x00 0x00 0x00

 Issue by ashwinsingh2007
Sun Dec 22 20:28:58 2019
Originally opened as https://github.com/codelucas/newspaper/issues/760

Tried this link on local with newspaper3k
link: http://www.news.com.au/sport/cricket/big-bash/bbl-2019-perth-scorchers-vs-melbourne-renegades-at-optus-stadium/live-coverage/c76e315c694d39dd5c20ad75c5a136aa
my code :
article_content = Article('http://www.news.com.au/sport/cricket/big-bash/bbl-2019-perth-scorchers-vs-melbourne-renegades-at-optus-stadium/live-coverage/c76e315c694d39dd5c20ad75c5a136aa
', keep_article_html=True)

article_content.download() -> this throws error

article_content.parse()

However,
I earlier was working with same code on Jupyter notebook and it was working fine.
then i shifted code to flask environment.
article_content.download() gives error on few url like mentioned above and on few it works

Works 0.9.2


v0.1.0

Closes #1
Initial implementation of useable API

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@47dabe5). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #4   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?     20
  Lines             ?    343
  Branches          ?     29
=======================================
  Hits              ?    343
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ

lib/resource/MultiZone.js
100% <100%> (ø)

lib/resource/Event.js
100% <100%> (ø)

lib/resource/RefreshableResourceMixin.js
100% <100%> (ø)

lib/RachioClient.js
100% <100%> (ø)

lib/resource/ScheduleItem.js
100% <100%> (ø)

lib/resource/Resource.js
100% <100%> (ø)

index.js
100% <100%> (ø)

lib/resource/FlexScheduleRule.js
100% <100%> (ø)

lib/datastore/RachioDataStore.js
100% <100%> (ø)

lib/utils/index.js
100% <100%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47dabe5...0d04987. Read the comment docs.


Prompt page updates: vue, pagination, minor graph fixes

It seems to me that some of the styling for the play page got messed up?
Also I helped merge master changes in, I think I did it right, but not 100% sure, lmk if you see anything

Fixed a couple of issues with rendering on play and prompt


AssociationLaunching example doesn't work for .zip files on Windows 11 Pro 22H2

Example: AssociationLaunching
Steps to reproduce the behavior:

Open Package.appxmanifest, go to the Declarations tab and add .zip file extension
Build and run the example
Try to open any .zip file using the explorer context menu
No such interface is supported error message appears

Interestingly, all other file extensions work well, the problem is only with .zip and only on Windows 11 Pro 22H2.

Additional info
Here's a link to Feedback Hub: https://aka.ms/AAi9ln6
We’re reaching out to notify you of an issue in Windows 11 Version 22H2. The problem relates to archives opening by association. I want to draw your attention to the fact that this problem is also observed in other UWP applications (9Zip, Rar Zip Extractor Pro, etc.) and only in version 22H2.
The issue details are below.
An error message is observed when opening an archive with 8 Zip by association (.zip)
Note: Issue is observed in other UWP apps. On Windows 11 version 21H2, the error is not observed.
OS: Windows 11 Pro Version 22H2 Build 22621.521
Applications: 8Zip Pro version <IP_ADDRESS>, 8Zip version <IP_ADDRESS>
Repro steps:

Install 8 Zip app from the Microsoft store.

Open the folder with the archive in Files Explorer.

Call the context menu on the archive file (.zip).

Select "Open with".

Select 8 Zip app.

Observe.

Actual Results: An error message is observed (see attachment).
Expected Results: Application 8 Zip opens the selected archive without errors.

@kanismohammed - are you aware of an issue in this area or can have someone investigate?

This repo is for the samples, not for the underlying OS functionality that supports them. This problem appears to be in the underlying functionality; there is no bug in the sample itself. If you feel that this is a sample bug, please elaborate.

Yes, there is a bug in Windows 11.  @oldnewthing could you call someone from the appropriate team here to fix this bug?

This repo is for the samples, not for the underlying OS functionality that supports them. This problem appears to be in the underlying functionality; there is no bug in the sample itself. If you feel that this is a sample bug, please elaborate.

@oldnewthing Please give me a link to the correct repo so I can file this bug.

@ValeraFinebits You report OS bugs via Feedback Hub. The team tells me that they received your report and are investigating.

@ValeraFinebits - We've routed the fbhub bug to the feature team. Can't guarantee when the team can look at it, but you can track progress there.
thx

@oldnewthing thank you for your help. I'll be asking you here from time to time how is going work on fixing this bug, because the report to the Feedback Hub was sent in June 2022.

Hi, @oldnewthing in Win11 23H2 bug still live. Could you please help?

@ValeraFinebits As I noted, this repo is not for product bugs. This is a samples repo. I cannot help with product issues.

@ValeraFinebits As I noted, this repo is not for product bugs. This is a samples repo. I cannot help with product issues.

@oldnewthing
I understand. But what can I do to get the bug fixed?
The bug was reported back in 2022, and you said that it reached the responsible team

@ValeraFinebits As I noted, this repo is not for product bugs. This is a samples repo. I cannot help with product issues.

@oldnewthing
Do you suggest voting for this issue on GitHub? Because there's no way to vote for my review in the Feedback Hub.
Additional Information in Win11 23H2 the same problem was added to .7z files. Now, it is obvious that the problem is related to .zip and .7z support in Explorer. It's good that Microsoft adds features to Explorer, but why break UWP archivers from the Store?

The feature team doesn't monitor this github issue.

The feature team doesn't monitor this github issue.

@oldnewthing
I ask you to help me find the right place so that the feature team can see this problem.

My only guess was the Feedback Hub issue. I don't know the feature team personally, so I don't know what mechanism they use to "plus one" a bug report.

fyi - the feedback hub issue is marked as fixed in WIP-Canary. Its making its way through servicing channels on Win11 which will take a couple months

fyi - the feedback hub issue is marked as fixed in WIP-Canary. Its making its way through servicing channels on Win11 which will take a couple months

Thank you.


How to implement GET  URL Query and 404 error page.

hi, i like this code. i want help my question is
How to implement GET  URL Query and 404 error page.

/search?q=query

Hi @shaziaijaz ,
please take a look at the index.php file. There you will find a 404-demo:
// Add a 404 not found route
Route::pathNotFound(function($path) {
  // Do not forget to send a status header back to the client
  // The router will not send any headers by default
  // So you will have the full flexibility to handle this case
  header('HTTP/1.0 404 Not Found');
  navi();
  echo 'Error 404 :-(<br>';
  echo 'The requested path "'.$path.'" was not found!';
});

And this could be your search boilerplate:
// Search example
Route::add('/search',function() {
  // Use the global $_GET PHP Array to access your q value.
  // Query the database
  // List the results
  // Do whatever you want
  echo 'You searched for '.$_GET['q'];
}, 'get');

thanks you


Can not run

Hi, thank you to share your code!
Here are some problems in your code, when i ran the main.py, it meet an error like this below :
"CasEE/utils/framework.py", line 71, in train
token = torch.LongTensor(token).to(self.config.device)
ValueError: expected sequence of length 79 at dim 1 (got 83)
"
I find that in your code there's no padding to the tokens to the same length, maybe it's why it goes like this.

Hi, I didn't reproduce this problem.
Actually, the padding operation is in CasEE/utils/data_loader.py line 207.
Maybe it is caused by other reason. Please run the code as in readme.


[WIP]: Fhir implementaion patients module page

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #598
Description
Implementation of IPS section in the FHIR module
Alternative(s) considered
N/A
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[ ] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@maimoonak you can check out this pr for updates regarding the assigned part.

hi @Ana2k if this is part of the gsoc project can you create a feature branch for your development and make sure you sync with the latest changes from time to time? as it stands i don't think this should be part of the reference app but open to discussion.
can we also have a discussion about what exactly is to be implemented in the new screen? thanks

hi @Ana2k if this is part of the gsoc project can you create a feature branch for your development and make sure you sync with the latest changes from time to time? as it stands i don't think this should be part of the reference app but open to discussion.
can we also have a discussion about what exactly is to be implemented in the new screen? thanks

@Ana2k , based on Jing's comments above, can this PR please be closed?

@Tarun-Bhardwaj closing this pr as instructed and creating feature branch.


First lines of call stack missing

I know you have previously mentioned, in #59 and #51 for example, that it was fixed, but the issue still seems present in the latest version?

Here's another simple example:


Icons mismatch

Some minor regressions (due to #781 I think 🤔 )
A few icons are displaying incorrectly:

CC @machour

😂 😂 😂
could you try rm -rf node_modules & recompile the app? I think there's something wrong with your react-native-vectore-icons local copy

😅
I did clear my node modules and yarned things again 🤔 But it very well could be the native bindings on my end that's behind?
Will clear it again

Just tried on a clean fork, icons are okay:

Sweet, will close this. Will try to completely clear everything and see if I'm still experiencing things 👍


Refactor 'images' workflow, include Ubuntu image to push

Until now, the 'images' workflow was separated into two different jobs,
one for just building the images in e.g. pull requests and the other
one for building and pushing the images e.g. after a merge to the 'main'
branch, which resulted in code repetitions. Also, both jobs used
different approaches, one (build) using a 'matrix strategy' based on
the file name of the Dockerfile, the other one (build and push) having a
seperate build and push step for each Dockerfile.
With this change, both jobs have been unified into a single "build and
optionally push" job to remove the repetitions, which now also shares
the same approach - a matrix strategy based on the file names of the
Dockerfiles.
In order to achieve this, the old 'helmfile-debian-stable-slim' image
package had to be renamed to 'helmfile-debian' (which will affect some
users). However, the package naming now follows a clear schema based on
the file name of the Dockerfile. 'Dockerfile' will result in a
'helmfile' package, 'Dockerfile.debian' will result in a
'helmfile-debian' package and so on.
Furthermore, the evaluation of the condition whether a push is intended
(or not) has been moved directly to the 'push' flag of the
'docker/build-push-action'.

This PR is the result of https://github.com/helmfile/helmfile/discussions/261
You can have a look on the new workflow in action in my fork:

Pull Request
Merge to main
Tag push

The resulting packages can be found here: https://github.com/pathob?tab=packages&repo_name=helmfile

@pathob please fix DCO issue.

@yxxhero Now done

@pathob The default helmfile image is base of Dockerfile. It is diffrent ago. is right?

@pathob The default helmfile image is base of Dockerfile. It is diffrent ago. is right?

@yxxhero Sorry, I don't understand your question, can you explain again what you mean?

@pathob The default helmfile is based on dockerfile, which is different from the previous logic.

Before, it was like this:
      - name: Build and Push
        uses: docker/build-push-action@v2
        with:
          file: Dockerfile
          platforms: linux/amd64,linux/arm64
          push: true
          tags: |
            ghcr.io/${{ github.repository }}:${{ steps.vars.outputs.tag }}
          cache-from: type=gha
          cache-to: type=gha,mode=max

      - name: Build and Push (debian stable-slim)
        uses: docker/build-push-action@v2
        with:
          file: Dockerfile.debian
          platforms: linux/amd64,linux/arm64
          push: true
          tags: |
            ghcr.io/${{ github.repository }}-debian-stable-slim:${{ steps.vars.outputs.tag }}
          cache-from: type=gha
          cache-to: type=gha,mode=max

So, Dockerfile was used to build ghcr.io/helmfile/helmfile and Dockerfile.debian was used to build ghcr.io/helmfile/helmfile-debian-stable-slim.
Now, it is like this (based on the suffix of the Dockerfile itself:
      - name: Build / Push
        uses: docker/build-push-action@v3
        with:
          file: ${{ matrix.dockerfile }}
          platforms: linux/amd64,linux/arm64
          push: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }}
          tags: |
            ghcr.io/${{ github.repository }}${{ steps.vars.outputs.suffix }}:${{ steps.vars.outputs.tag }}
          cache-from: type=gha
          cache-to: type=gha,mode=max

So, Dockerfile is still used to build ghcr.io/helmfile/helmfile. But now, Dockerfile.debian is used to build ghcr.io/helmfile/helmfile-debian. And new, Dockerfile.ubuntu is used to build ghcr.io/helmfile/helmfile-debian.
For the Dockerfile and the helmfile package, nothing changed.

@pathob Thanks for your reply. is it better to build the same image name as before for Dockerfile.debian? WDYT? @mumoshu

Btw. it would also be possible to rename the Dockerfile.debian to Dockerfile.debian-stable-slim to keep the old image name.

@pathob ok. you are right.

@pathob Hey! Thanks for your efforts. This LGTM overall. One thing though- I do prefer keeping the old image name for compatibility so it would be great if you could rename the existing dockerfile to Dockerfile.debian-stable-slim so that (I believe) the image name is retained.
Can you fix it in this PR?

@mumoshu @yxxhero I've adjusted it now and renamed the file

@pathob Thanks very much. Please fix ci error.

@yxxhero Overlooked something, now it should work

@pathob I think Dockerfile.ubuntu should be renamed too. Thanks very much.

@yxxhero What's your preference? Dockerfile.ubuntu-20.04?

@mumoshu maybe Dockerfile.ubuntu-stable-slim ? same behave as Dockerfile.debian-stable-slim. right?

I find this "stable-slim" very uncommon, especially because it's a package (image) name. Usually this kind of stuff is handled via tags.

@pathob I agree. WDYT?

@pathob @yxxhero Hey! Thanks- I hear you, and I do believe having image variant names in the image tags is more common.
However, I prefer making the variant name a part of the image name so that it's more rennovate/dependabot friendly- AFAIK those solutions don't support filtering image tags by a specific prefix. If we had variant names in tags, tag updates triggered by those solutions would float over multiple prefixes(like floating over debian and ubuntu). Making the variant name a part of the image name fixes it, resulting in a solution to select the latest version out of the all image tags for the specific variant(debian or ubuntu or whatever we might support).
I'd love it if we could have these two images in the end:

helmfile-ubuntu:$VER
helmfile-debian:$VER

Not because it's more common to have the base image variant in the derived image's tag, but because I prefer it agnostic to the variant of the base image, I like naming it Dockerfile.ubuntu along with the way how the GH action workflow is implemented in this PR now.
I'd "eventually" want to rename Dockerfile.debian-stable-slim to Dockerfile.debian for the same reason, and bring back additional variants like debian-stable-slim or debian-buster or whatever if and only if it makes sense. To keep the backward-compatibility though, I'd like to refrain from making such a change in this PR.
All that said, the state of this PR LGTM!
If you agree, I'd be happy to merge this PR as-is, and defer other matters to another issues/discussions.
WDYT?

@mumoshu I agree with you. Thanks very much.

@mumoshu I agree with you too, that would be a nice solution at the end and a task for another PR / discussion.

@pathob @mumoshu So let we merge this PR. Thanks very much. Thanks for your good work.


RINA API port + POSIX port refresh

Refresh the POSIX port and port RINA_API to POSIX as the final component in the to port in the RINA stack.

This work was broken down into 2 patches.


Revert Node Union changes (ABI breaking)

Revert "d6bd5dd2e0d46288dea4d863507170a590509623" and "b97c2738da1efa889d949e9f36eaff078efeba1c"
Reverts: https://github.com/AcademySoftwareFoundation/openvdb/pull/865
Breaks ABI :( I will re-apply for VDB 8 with ABI guards
Signed-off-by: Nick Avramoussis<EMAIL_ADDRESS>

Again, Windows/Mac CI failures are unrelated...

@jmlait What caught us was a crash using MMB calling through to  SOP_Node::fillInfoTreeNodeSpecific. It manifested in a super weird stack trace inside sesi namespace vdb using a LeafIteratorbase. We do incremental releases and these were the things that had changed:

Trivial types: https://github.com/AcademySoftwareFoundation/openvdb/pull/865
Matrix grid support https://github.com/AcademySoftwareFoundation/openvdb/pull/723
@danrbailey NodeManager stuff https://github.com/AcademySoftwareFoundation/openvdb/pull/785

As this is a bit time sensitive I didn't investigate further (and I'm now away!), but everything is now stable after reverting this. I'll send you through the full stack trace when I can and will definitely take a closer look after 7.2.

Very glad we caught this before pushing out a broken build. :/
Disappointed that the ABI checks I introduced didn't catch this though, need to keep expanding these checks so that we have more confidence in making these types of changes. At least this serves as a good test case for making sure the ABI checks fail.

Very glad we caught this before pushing out a broken build. :/

We should discuss a proposal for locking down a release branch a certain time in advance of a release. This was a similar issue to 6.2 (or was it 6.1?) but just so happened that I was able to get some users to test it before committing to 7.2.

Disappointed that the ABI checks I introduced didn't catch this though, need to keep expanding these checks so that we have more confidence in making these types of changes. At least this serves as a good test case for making sure the ABI checks fail.

Yes, when I come back to this PR I'll see if I can introduce a test which breaks with these changes.


N49: Tiny Glade

Sorry about the lag, we were on vacation in far-away lands :palm_tree:
Part of #1440

Tnx! Sorry for the late review!


Add tooltip components

Add in bread/layout/components/tooltip.py
Add three new components:

InteractiveTooltip
DefinitionTooltip
IconTooltip

Information about the behaviour and idea of the tooltips can be found here:
https://www.carbondesignsystem.com/components/tooltip/usage/
Information about the implementation of the tooltips can be found here:
https://the-carbon-components.netlify.app/?nav=tooltip
For InteractiveTooltip make sure to reuse an existing icon (not copying SVG code).
The IconTooltip should support any Icon element.
When implementing the code, please only set the minium of required attributes. For example, id-attributes or aria-attributes are not required in most casts. class and data-* attributes are almost always required.
The __init__ methods of these components should be similar to that of other components. You can check other components where the same rule apply in general. That means:

Allow the content (tooltip label or tooltip content) to be anything (meaning: do not assume it is just a string, but it could e.g. also be any object of type htmlgenerator.BaseElement)
Support a **kwargs parameter whose values will passed to super().__init__(). When you need to pass certain required attributes to the parent (like "_class" in most cases), then make sure to check if they already exists inside kwargs and append instead of overwriting the existing value. There is also a shortcut for that, see htmlgenerator.append_attribute.
List configuration parameters separately, with a good default value (should not be part of kwargs), e.g. def __init__(*args, orientation="left", **kwargs):

We will need this to make some additional improvments for the browse-view, according to https://github.com/basxsoftwareassociation/basxconnect/issues/108

Done as in #116

I tested it.

Thx


rowData missing parameter , v <IP_ADDRESS>

In JavaScript function function DCrmEgGridRowOnload(rowData, entityinfo), the rowData object had a field called "RowBackgroundColor" , this does not seem to work anymore.

I can't re produce this issue. the parameter is working as intended. CRM 2013
rowData.RowBackgroundColor = '#CCCCCC';
How are you setting this parameter? color names, rgb, ...
Thank you,
Mehrdad

I'm Using the color name in this example 'LightGrey'

I found the Problem, this issue can be closed, Thank you


add ability to add catalogs to nodes through RackHD API

It would be very helpful in some testing cases to have a way to inject node catalog entries through the API.  For example, the physical or virtual environment that I have doesn't provide some catalog data, but I want to be able to test functionality or fixes against that catalog data.

@brianparry @yyscamper this seems highly valuable, thinking both as a southbound API and a (future authenticated) northbound API so that it's usable as an arbitrary tool upload from devices as well as a coordination data point from consumers of RackHD.

Expose POST catalog API bring both power and harm.
It's easy to test, to mimic a physical device, but we lack the means to validate user's input, and when we encounter a bug in future, the catalog data becomes not reliable, because it maybe manipulated by user.
If only for test purpose, I think we can directly touch the mongodb.
If only enable it for RackHD southbound API, seems it is duplicated, because now POST /tasks/ can do similar thing.

@yyscamper I would think that we'd want to leave input validation out of it since tests may need to inject invalid data.  If the intent is to use this for test only, we could protect against using it in production with a configuration switch.
@johren I think it would be helpful if you could provide some specific test scenarios where you would use this feature so we can get a sense for the level of flexibility you'd need.

I will gather more specific test scenarios and add them to this.

@johren @brianparry @yyscamper Hi guys, just wanted to follow up and and see if we should address this request, are there any specific use cases we have available? Otherwise, should I close this ticket? Thanks!

Looks like @johren is on vacation for a bit. We'll need to put this one on the side until we get more specific scenarios.

I forget the specific use case that brought this up.  Don’t have the cycles right now to dig it up and it isn't a pressing issue so I will go ahead and close it for now and reopen if it comes up again.


How to handle the gain/offset in the conversion from hdf5 to vpts-csv

In the https://github.com/adokter/vol2bird/wiki/ODIM-bird-profile-format-specification#specification-of-bird-profile-output-in-odim-hdf5-format specification there is a gain and an offset for the datasets/variables. In the conversion from h5 to vpts-CSV, the current implementation does not take these into account. @adokter, should this actually be done by default and store in the vpts-csv version for each record quantity*gain+offset instead of the quantity?

Hi @stijnvanhoey, I would define the value as quantity*gain+offset, following the ODIM standard. Currently the vp files use gain=1 and offset=0, so it doesn't make a numerical difference. But better to adhere to the data standard in case that would ever change.

Thanks for the input, the gain/offset is included as part of the https://github.com/enram/vptstools/pull/19 refactoring


fixed useDraggable returning x for y

Description

The useDraggable function returned the x value when using the y() accessor, this fixes that.
As a sidenote, it doesn't look like there's a way to set the x and y positions manually, should I open another PR for that or add it to this?

copilot:summary
copilot:walkthrough

Thanks. It works on 2.1.0.


[Host.RabbitMQ] Missing RabbitMQ Implementation

RabbitMQ Implementation seems to be missing. We would love to have that.

I agree 👍. Do you want (have time) to contribute ? :)

How is it going now?

Nothing has been done yet that I am aware of. Let me know if you're willing to work on the implementation, otherwise I will start this.

Will use this client to implement the Rabbit transport:
https://www.nuget.org/packages/RabbitMQ.Client

The RebbitMQ transport is available:
https://github.com/zarusz/SlimMessageBus/blob/master/docs/provider_rabbitmq.md
The preview version is available:
https://www.nuget.org/packages/SlimMessageBus.Host.RabbitMQ
Feedback is welcome!


MotifView from animation freezes

Hello,
First of all, thank you so much for the moti library, I love using it!
In my app, I used custom card components that have an animation when appearing. I use a MotiView.
The issue I face is that often, when arriving on the screen, the animation seems to freeze and the card is blocked in an intermediate state.
Below is a code snippet
        <MotiView
          from={{
            opacity: 0,
            scale: 0.9,
          }}
          animate={{
            opacity: 1,
            scale: 1,
          }}
        >
         <Box backgroundColor="tomato" />
       </MotiView>

Inside the MotiView, I use a Box created using createBox from @shopify/restyle (1.4.0) and the navigation between screens is native as I use react-native-navigation (7.23.1). I use the moti 0.16.1.
Do you need more information?
Thanks in advance!

This usage doesn’t look correct. The children of AnimatePresense need to conditionally render. But in your case, you’re always rendering its child.
https://www.framer.com/docs/animate-presence/
In your case, the exit animation will never get fired, so you can remove AnimatePresence (and the exit prop)

Thank you for this quick response! I removed AnimatePresence and exit prop, so the usage is seems correct now. But the issue still rises. I updated the opening message with the code left (also here below)
        <MotiView
          from={{
            opacity: 0,
            scale: 0.9,
          }}
          animate={{
            opacity: 1,
            scale: 1,
          }}
        >
         <Box backgroundColor="tomato" />
       </MotiView>

Can you send a video? What if you memoize this?

I'm having a hard time to reproduce (even when using back the bad usage).
I won't use your time anymore for now, I'll reopen the issue if it comes back and I have a record and better insight!
Thanks, have a good week-end!


Updates to Read and Write implementation

All io code is now safe and based on slice copying

Rationale: The assumption is that the optimizer can remove all the bounds checking after inlining, since all of the provided bounds are plainly inside the buffers
The only remaining "semantically unsafe" code is direct writes to self.length, for which I've provided // Safety: comments

read no longer uses drain, to avoid its complexity and extra copying

Drain copies data to a local StaticVec<u8, N> on the stack. This is a very unnecessary copy and use of stack memory, especially if the StaticVec is very large. Additionally, the drain logic is made complicated, because it supports draining from the inside of the vector; our needs are only to copy from the front, then shift the array contents back.

Added read_to_end and read_to_string
read_vectored no longer excessively performs interior copies
Added Read::initializer
write_all no longer writes unless it knows it will succeed

write_all provides no contractural guarantees about how many bytes were written if it returns an error, so there's no reason to write if we know we'll return an error.

Replaced many uses of unwrap with ?
Added io:: namespacing for clarity of generically-named types like Error
Added tests

This is part of a series of pull requests that break down #11 into simpler parts

This looks pretty good to me!
For stuff such as this line though, what I've found from going over assembly listings of the demo / the tests / etc is that rustc will basically never "elide" the built-in runtime bounds checks for arrays / slices except in pretty simplistic cases, with fully constant bounds.
This is why as you've probably noticed there's currently not a single "normal" bracketed array access (i.e. something like self.data[5]) in the entire repo (and beyond the performance thing, they're not even useful because while rustc is checking against the entire length of data, which for us is really capacity, the bounds we care about for data are obviously 0..length.)

Well, in this case I'm using self.as_slice(), so rust should be correctly bounds checking against 0..length. But I take your meaning; I'll go in and change everything to pointers.

How have you been examining the assembly? I'd be curious if my implementation counts as "simple" enough

I just locally have a .cargo folder in the repo folder, with a config containing this:
[build]
rustflags = ["--emit", "asm"]

Also BTW my link up there was to line 404, i.e.:
source = &source[read_length..];
After clicking on it again I noticed where github pointing was sort of innacurate relative to the actual line number...

But I take your meaning; I'll go in and change everything to pointers.

Well, don't forget that data (like all static arrays) does implicitly have access to all the slice methods (despite not derefing to it.. I believe it's just some compiler magic thing.)
So you can for example use data,get_unchecked_mut and data.get_unchecked as a drop-in replacement for normal indexing (as I've done pretty heavily throughout the codebase.)

Yeah, I've been trying to avoid going through MaybeUninit<T> wherever possible. In some places it makes sense, especially when adding or removing elements from a StaticVec, but in cases where you work with known-good data, I'd rather work with &T as much as possible.

Looks good enough to me. Thanks a lot!


'DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2': undeclared

After commit https://github.com/glfw/glfw/commit/5294439595e5b95c238a121c8a63c076a0aa2c8a building on Visual Studio 15 2017 Win64 will result in the following error, resulting and a failed build:
"C:\projects\acid\Build\Libraries\glfw\src\glfw.vcxproj" (default target) (12) ->
(ClCompile target) ->
  c:\projects\acid\libraries\glfw\src\win32_init.c(565): error C2065: 'DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2': undeclared identifier [C:\projects\acid\Build\Libraries\glfw\src\glfw.vcxproj]

This is with BUILD_SHARED_LIBS=OFF with no other changes made to build.

Hmm, cannot reproduce with Visual Studio 2017 either with Open Folder or external CMake.

This mainly shows up in a appvenyor project where glfw is a subdirectory: https://ci.appveyor.com/project/Mattparks/acid/build/0.9.8110#L3629
It appers _DPI_AWARENESS_CONTEXTS_ is defined; however, DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 is not defined in this case.

Cool, then try refreshing from master eeac43c3f79cf52c75605e86cb1b1eaf14b01ee6 might help.

I'm still getting errors, https://ci.appveyor.com/project/Mattparks/acid/build/0.9.8111#L3646

Oh, a very specifically outdated Platform SDK. Will fix.

Is there any news? :)

This may have been fixed by 1725d1c4f5b37c7ccd50dd42a8794b9f6900d12b.


charts don't render

Hi,
I think it's a misunderstanding from me because some charts render except the examples of C3.js.
Here is a code snippet from http://c3js.org/samples/chart_donut.html which doesn't work with angular-chart.
Controller:
 var self = this;

        //applyData();
        //cockpitDataService.startUpdating();

        self.testOptions = {
            data: {
                columns: [
                    ['data1', 30],
                    ['data2', 120]
                ],
                type : 'donut',
                onclick: function (d, i) { console.log("onclick", d, i); },
                onmouseover: function (d, i) { console.log("onmouseover", d, i); },
                onmouseout: function (d, i) { console.log("onmouseout", d, i); }
            },
            donut: {
                title: "Iris Petal Width"
            }
        };

View:
//uses ui-router, so it knows that cockpit is the controller-alias
<angular-chart options="cockpit.testOptions"></angular-chart>

The binding in the view is correct because some charts like the example work. So, as I said, I think it's a misconception. Unfortunately angular-chart doesn't really explain which properties are optional and which not.

It was my fault. Now it works.


I think there is issue when using more than 3 route variables.

I was dealing with an issue discussed here and here.
I was bothered why none of the method worked and I stumbled upon an issue which I think belongs to slim framework itself.  I made a fresh folder and did some testing.
<?php
error_reporting(E_ALL);
ini_set('display_errors', 1);

require_once '../vendor/autoload.php';

$app = new \Slim\Slim();

/*  ---- Everything works textbook perfect from here ---- */
/*  ---- i.e. whether the url ends with trailing slash or not. ----  */

$app->get('/assets(/)', function() use ($app) {
	echo '/assets(/)';
});

$app->get('/assets/:height(/)', function($height) use ($app) {
	echo '/assets/:height(/)';
});

$app->get('/assets/:height/:width(/)', function($height, $width) use ($app) {
	echo '/assets/:height/:width(/)';
});

/* ----- To Here ----- */

/* -- But when I use 3 or more values in url such as this -- */
/* -- " http://urltest.local/assets/200/200/logo/png "   Does not work - give 404 error -- */
/* -- " http://urltest.local/assets/200/200/logo/png/ "   Does not work - give 404 error  -- */

$app->get('/assets/:height/:width/:id(/)', function($height, $width, $id) use ($app) {
	echo '/assets/:height/:width/:id(/)';
});

$app->get('/assets/:height/:width/:id/:type(/)', function($height, $width,  $id, $type) use ($app) {
	echo '/assets/:height/:width/:id/:type(/)';
});

/* -- also alternativly this does not work - give 404 error -- */

$app->get('/assets/:height/:width/:id/:type', function($height, $width,  $id, $type) use ($app) {
	echo '/assets/:height/:width/:id/:type';
});

/* -- but this alternative does work when there is trailing slash -- */

$app->get('/assets/:height/:width/:id/:type/', function($height, $width, $id, $type) use ($app) {
	echo '/assets/:height/:width/:id/:type/';
});

?>

Update : Edited the copy-paste mistake I did when I posted this.

Your function signatures define an unused variable $image. The number of route ooacehokders doesn't match the number of arguments to the callback

No,  I copy pasted wrongly here,  Actually,  when It gave 404 error on 4 variables, I decided to replace id and type with just image, and split its extension to get id and type.  I forgot to remove $image when I wrote here. My bad.  But error is there , on 3 and more variable, I need to add a trailing slash or else I get a 404. I can replicate it as many time as you ask.
My System
Fedora 22 64bit,
Nginx, php-fpm, (all updated)

The following code works for me. Note that your example is missing $app->run()
require "./vendor/autoload.php";

$app = new \Slim\Slim();
$app->get("/assets/:height/:width/:id/:type(/)", function($height, $width,  $id, $type) use ($app) {
    echo "/assets/{$height}/{$width}/{$id}/{$type}(/) \n";
});

$app->run();

yields
$ php -S <IP_ADDRESS>:8080 index.php
$ curl http://<IP_ADDRESS>:8081/assets/100/200/6/png/
/assets/100/200/6/png(/)
$ curl http://<IP_ADDRESS>:8081/assets/100/200/6/png
/assets/100/200/6/png(/)

What server are you using,  I copied the your code and I have to add trailing slash to make it work.
About $app->run(); I missed it copying.  This was test.php file i keep in my active project to quickly test some random logic or code snippet.  So i didn't  just copied all of it. Just the part I thought was relevant to post here.

From the code, he is using the built in PHP webserver, I am inclined to think this is a server configuration issue rather than a Slim itself issue.

I ended up using get parameters for my project due to time constraint. I have kept the test app aside. This is what I can gather on my linux system and on my friends windows 8.1 system.  I am using the Apache rewrite rules and Nginx server config from the slim docs itself. http://docs.slimframework.com/routing/rewrite/
Nginx :  trailing slash is required for more than 3 rest attributes.
Apache : Trailing slash is required for more than 3 rest attributes.
It was same on my ubuntu machine also.
Windows : Apache (AMPPS),  Trailing slash is required after 3 rest attributes.
Only thing I changed in php.ini, was to enable errors. Apache and nginx were what came default.
I can't think of any other configuration which might cause this.
Let us remove server from equation.  Tomorrow I will check  if this happens on some other restful micro-framework.  This should confirm server's involvement on this.

Just tested the code from my previous comment with fresh CentOS 6.5 + Apache 2.2 install. It works as expected.
$ curl --include http://<IP_ADDRESS>/assets/100/200/6/png/
HTTP/1.1 200 OK
Date: Sat, 05 Sep 2015 16:30:58 GMT
Server: Apache/2.2.15 (CentOS)
X-Powered-By: PHP/5.6.12
Content-Length: 26
Connection: close
Content-Type: text/html;charset=UTF-8

/assets/100/200/6/png(/)

$ curl --include http://<IP_ADDRESS>/assets/100/200/6/png
HTTP/1.1 200 OK
Date: Sat, 05 Sep 2015 16:31:06 GMT
Server: Apache/2.2.15 (CentOS)
X-Powered-By: PHP/5.6.12
Content-Length: 26
Connection: close
Content-Type: text/html;charset=UTF-8

/assets/100/200/6/png(/)

ok.  I am out of reasons here now. There might be something wrong in my code or my nginx config.  Here is my Nginx config if someone can point something to me. I am open to all suggestions.
# Common Resources

server {
  listen 80;
  server_name static.CouponApna.local;
  root /var/www/CouponApna/Resource;

              location / {
                  index index.php;
                  try_files $uri $uri/ /index.php?$args;
              }
              location ~ \.php/?(.*)$ {
                  fastcgi_connect_timeout 3s;     # default of 60s is just too long
                  fastcgi_read_timeout 10s;       # default of 60s is just too long
                  fastcgi_pass unix:/run/php-fpm/www.sock;
                  fastcgi_index  index.php;
                  include fastcgi_params;
                  fastcgi_param  SCRIPT_FILENAME  $document_root$fastcgi_script_name;
              }
              location ~* ^.+.(jpg|jpeg|svg|gif|css|png|js|ico|xml)$ {
                access_log        off;
                expires           360d;
            }
            location ~ /\.ht {
                deny  all;
            }
}

I am closing this one out, I think we tested as much as we could and it doesn't seem to be an issue with Slim itself.


TTL Compliance: Make unconnected / high impedance input nodes propagate 1 by default

According to TTL (Transistor Transistor Logic), A value of 0 is thought to draw the gate low. Hence the default value of the gate input on disconnected input / high impedance should be 1. Currently CircuitVerse simulator defaults such values to 0.
TTL
Modules to modify:

[ ] AND gate
[ ] OR gate
[ ] XOR gate
[ ] NAND gate
[ ] NOR gate
[ ] XNOR gate

Are you working on this issue? (Yes/No)
Yes but help is appreciated

@gr455, I would like to work on this issue.

@gr455, I would like to work on this issue.

Go ahead. Look at the resolve() function for the circuitElements. That function resolves the output nodes of the elements accroding to the input values

@ayan-biswas0412 About this issue, do we want the behaviour to be same as Logisim? At least for gates?

@ayan-biswas0412 About this issue, do we want the behaviour to be same as Logisim? At least for gates?

yah right


Documentation Page Returning 500 Internal Error

Issue Description:
When attempting to access the documentation page, users are encountering a 500 Internal Server Error.
Steps to Reproduce:

Navigate to the documentation page.
Attempt to access any section or resource within the documentation.

I got temporary solution.

contentlayer vercel app

I got temporary solution.

contentlayer vercel app

Thank you!

Fixed with contentlayerdev/website#118


Can`t open file 'text_recognition.py' No such file or directory

I am trying to follow this guide to use tesseract on raspberry pi.
https://www.pyimagesearch.com/2018/09/17/opencv-ocr-and-text-recognition-with-tesseract/

That's third party software, so you are completely wrong here.

Please use the user forum for questions.


[tensor] Apply bcq

[tensor] apply bcq

 - Enable bcq to NNTrainer

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2412. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2412-202401162246050.99905395507812-f07d3148c0cba3129a429b7a870470f158e30966/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2412-202401181714120.31086897850037-48957290dc8515a5180793b1f73d59337106d311/.

:octocat: cibot: @lhs8928, nntrainer/layers/layer_devel.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @lhs8928, nntrainer/layers/layer_devel.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2412-202403211621590.50013494491577-5d5c4cbc54289f988fa127da698fe7c716182987/.

:octocat: cibot: @lhs8928, nntrainer/layers/layer_devel.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @lhs8928, The last line of a text file must have a newline character. Please append a new line at the end of the line in build_for_llama.sh.

:octocat: cibot: @lhs8928, nntrainer/layers/layer_devel.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @lhs8928, The last line of a text file must have a newline character. Please append a new line at the end of the line in build_for_llama.sh.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2412-202403221314090.16550898551941-83ef18d865a9e6cc51fd6466845c9ed3a42fda08/.


HybridApp example error while finding commong block

Description
On HybridAppHistory, finding suffixes after a common block between branches it's not working.
Cause
@tailrec
  private def suffixesAfterCommonBlock(winnerChain: Seq[BlockId], loserChain: Seq[BlockId]): (Seq[BlockId], Seq[BlockId]) = {
    val c1h = winnerChain.head
    val c2h = loserChain.head

    if (loserChain.contains(c1h)) {
      (winnerChain, loserChain.dropWhile(id => !(id sameElements c2h)))
    } else if (winnerChain.contains(c2h)) {
      (winnerChain.dropWhile(id => !(id sameElements c2h)), loserChain)
    } else suffixesAfterCommonBlock(blockById(c1h).get.parentId +: winnerChain, blockById(c2h).get.parentId +: loserChain)
  }

On the first if branch (when loserChain.contains(c1h) == true) it should be comparing by c1h while dropping. If not, the condition is matched at the first dropWhile iteration (because c2h is the head of loserChain sequence)
How to fix
Change the first dropWhile condition. The function may look like:
@tailrec
  private def suffixesAfterCommonBlock(winnerChain: Seq[BlockId], loserChain: Seq[BlockId]): (Seq[BlockId], Seq[BlockId]) = {
    val c1h = winnerChain.head
    val c2h = loserChain.head

    if (loserChain.contains(c1h)) {
      (winnerChain, loserChain.dropWhile(id => !(id sameElements c1h)))
    } else if (winnerChain.contains(c2h)) {
      (winnerChain.dropWhile(id => !(id sameElements c2h)), loserChain)
    } else suffixesAfterCommonBlock(blockById(c1h).get.parentId +: winnerChain, blockById(c2h).get.parentId +: loserChain)
  }

Not sure proposed fix is a right one. I've fixed the issue in another way. A property test has been added (property("suffixesAfterCommonBlock finds correct suffixes") in HybridHistorySpecification.scala)

@kushti we will take a look at your fix, thanks!


[clarification]: query by method name method parameters

Specification
Query by Method Name
I need clarification on ...
The relationship between Query by Method Name operators and the parameters of the repository method.
Additional information
If we're going to keep this as a required part of the spec [now that we have JDQL, @Query,  and @Find properly nailed down, I'm ready to have a probably-difficult conversation about that], then we at least need to make sure that this facility is fully-specified.
Reviewing this, it does seem to be mostly sorta OK, but:

the allowed return types are defined only in module-info, in a very sketchy format, and not in the spec itself, and
the allowed parameter types, and their relationship to the query itself are, AFICS, completely unspecified. This is less-than-trivial when we have operators like In and Between.

So there is at least some work to do here.
Also I'm also not sure I understand how to interpret shorthands like OrderBy____(Asc|Desc)*(Asc |Desc). Actually that might just be an error.

Also I'm also not sure I understand how to interpret shorthands like OrderBy____(Asc|Desc)*(Asc |Desc). Actually that might just be an error

I remember needing to ask what that meant as well when I wanted to write valid examples of it to put in module-info.  If it doesn't make sense to the authors of the spec, it won't make sense to users either and we should fix it.
I included at least part of an attempt at that in #577

the allowed return types are defined only in module-info, in a very sketchy format, and not in the spec itself, and

The JavaDoc in module-info is intended as a quick reference for application developers and often relies on tables and examples that you can copy from to try to visually get the point across.  If the information is missing from the specification document, we should make sure to add it there.

the allowed parameter types, and their relationship to the query itself are, AFICS, completely unspecified. This is less-than-trivial when we have operators like In and Between.

The table of Query by Method Name keywords reserved for the predicate in module-info was supposed to get across some of that information in a general sense.  Here is the information that is currently there for Between,
Keyword: Between
Applies to: numeric, strings, time
Description: Requires that the entity's attribute value be within the range specified by two parameters, inclusive of the parameters. The minimum is listed first, then the maximum.
Example: findByAgeBetween(minAge, maxAge)
One deficiency here is that we never define what "numeric", "strings", and "time" actually mean.  We should be more precise and do that.
The description should probably say "...inclusive of the parameter values..."
If adequate information about these keywords and the parameters for them isn't in the specification doc, it needs to be added.

But also:

Which operators correspond to parameters, and how many parameters does each operator correspond to?
What are the types of these parameters? The same as the the entity field? What about In?
How are parameters correlated with operators? Parameters have the same order as the operators, I assume, but that's not stated.

One deficiency here is that we never define what "numeric", "strings", and "time" actually mean.

Actually this particular issue if more of a failing of section 3.1.3 (Basic Types), which should say that Data considers BigInteger and BigDecimal to be numeric types.

What are the types of these parameters? The same as the the entity field? What about In?

Alright, so from the TCK I have learned that apparently the parameter type corresponding to In is Set. This isn't defined anywhere outside of the TCK.


Feature Request: ReflectionLoader

Loading php structs through reflection can be tricky, because every dependency that a struct needs must be in classpath, too anyway php wil throw an error. A ReflectionLoader may be useful here, to support this. It would scan the desired file, parse all dependencies, sees which of them are already in classpath and returns a list of those who aren't. At best, it would also load them by itself, if possible.

Also if the loaded file/class contains error (e.g. an old API used, where the parent class doesn't exist anymore) the loading (e.g. include/require) would fail.

It is now available via:

PhpClass::fromFile($filename)
PhpInterface::fromFile($filename)
PhpTrait::fromFile($filename)

Files are parsed and not loaded through reflection, so it is not necessary to load required classes/interfaces/traits, etc.


fix: Add w3m-connect-featured-widget to wallet login list

Changes

fix: Add w3m-connect-featured-widget to wallet login list

Associated Issues
#2324

Hey @tomiir , this PR addresses issue #2324 . It's a straightforward and quick fix. Thanks for reviewing!


Bundler Fails with IOError uninitialized stream after macOS 10.14 Mojave upgrade

Error Report

What did you do?

Upgraded machine to macOS 10.14 Mojave
Observe Gemfile uses source "http://rubygems.org". Note: not https.
Ran bundle update and everything worked fine.
In Gemfile changed first line to source "https://rubygems.org". Now using https.
Ran bundle update and got failure

What did you expect to happen?
Bundler to install gems normally

What happened instead?
Failure of "IOError uninitialized stream"

Have you tried any solutions posted on similar issues in our issue tracker, stack overflow, or google?
Researched the issue online in several places. Overwhemlingly, the advice that works for most people is to uninstall and install ruby. I use rbenv so I tried uninstalling/reinstalling ruby through rbenv, but that didn't work.
I tried installing ruby by explicitly pointing it to openssl with CONFIGURE_OPTS="--with-openssl-dir=/usr/bin/openssl rbenv install 2.3.0 -v, but it didn't work.
I checked my openssl installation with ruby -ropen-uri -e 'eval open("https://git.io/vQhWq").read' and that shows everything as all good to go.

Have you read our issues document, https://github.com/bundler/bundler/blob/master/doc/contributing/ISSUES.md?
 Moving to http enable me to perform bundle install exactly once. Afterwards, further attempts to install or bundle update to both http and https endpoits, failed with with different errors messages in an (apparently) non reproducible way

first IOStream error
Then Segfault error
Then malloc error

Eventually restarting my computer seems to have cleared the issue. It is unclear why, and this is obviously non satisfactory, so I will follow for update


Reference Java constants in .sq files

Would be great to be able to reference constants from .sq files.
e.g.
import com.example.Bar;

select *
FROM foo
WHERE bar=Bar.BAR;

SQLDelight library version: 0.5.1
SQLDelight plugin version: 0.5.1

Unfortunately this is impossible without some serious hacking since we can't know the type or value of a java constant. SQLDelight is a gradle plugin and generates java code, but it's not part of the java compilation step (except as input) so we don't get any notion of java symbols.
We had a similar issue come up with enums: https://github.com/square/sqldelight/issues/260 and the recommendation is to use a query param and pass your constant from java since it will be typesafe there, i'd suggest doing the same thing here.

Ah, fair do's. Thanks!