The Last Ben´s colab is broken if I add this extension

Describe the bug
I am using TLB Colab, and the instalation of this extension causes that I am unable to start the Colab.
To Reproduce
Steps to reproduce the behaviour, include the prompt you used if applicable:

i delete all the old folders and files of the "sd" folder at the root of my Google Drive.
I execute TLB Colab, all the steps. Using the 1.5 version of Stable Difussion. It´s a fresh start.
I go tho the Automatic1111 "extension tab, and I add the extension, installing it from the URL. I click the "apply and restart" button on the "extension tab". I do not install anything else before that.
I  stop the Colab /Because otherwise the GUI will no restart)
I get the error code of below. Unable to start the GUI.
It doesn´t matter that I stop completely the colab, deleting the Colab´s temporary files. The error appears again.

Also mention which checkboxes have been set.
Are you using a local install or a colab?
Colab
If a colab, which one?
https://github.com/TheLastBen/fast-stable-diffusion
Expected behaviour
The A1111 GUI starts and I am able to produce pictures.
Additional context
This is the error message shown on the colab website:
/usr/local/lib/python3.8/dist-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: libtorch_cuda_cu.so: cannot open shared object file: No such file or directory
  warn(f"Failed to load image Python extension: {e}")
Traceback (most recent call last):
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 15, in <module>
    from modules import import_hook, errors, extra_networks, ui_extra_networks_checkpoints
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/ui_extra_networks_checkpoints.py", line 6, in <module>
    from modules import shared, ui_extra_networks, sd_models
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_models.py", line 17, in <module>
    from modules.sd_hijack_inpainting import do_inpainting_hijack
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_hijack_inpainting.py", line 7, in <module>
    import ldm.models.diffusion.ddpm
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 12, in <module>
    import pytorch_lightning as pl
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/__init__.py", line 34, in <module>
    from pytorch_lightning.callbacks import Callback  # noqa: E402
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/callbacks/__init__.py", line 14, in <module>
    from pytorch_lightning.callbacks.callback import Callback
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/callbacks/callback.py", line 25, in <module>
    from pytorch_lightning.utilities.types import STEP_OUTPUT
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/utilities/__init__.py", line 18, in <module>
    from pytorch_lightning.utilities.apply_func import move_data_to_device  # noqa: F401
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/utilities/apply_func.py", line 29, in <module>
    from pytorch_lightning.utilities.imports import _compare_version, _TORCHTEXT_LEGACY
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/utilities/imports.py", line 153, in <module>
    _TORCHTEXT_LEGACY: bool = _TORCHTEXT_AVAILABLE and _compare_version("torchtext", operator.lt, "0.11.0")
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/utilities/imports.py", line 71, in _compare_version
    pkg = importlib.import_module(package)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/usr/local/lib/python3.8/dist-packages/torchtext/__init__.py", line 6, in <module>
    from torchtext import _extension  # noqa: F401
  File "/usr/local/lib/python3.8/dist-packages/torchtext/_extension.py", line 64, in <module>
    _init_extension()
  File "/usr/local/lib/python3.8/dist-packages/torchtext/_extension.py", line 58, in _init_extension
    _load_lib("libtorchtext")
  File "/usr/local/lib/python3.8/dist-packages/torchtext/_extension.py", line 50, in _load_lib
    torch.ops.load_library(path)
  File "/usr/local/lib/python3.8/dist-packages/torch/_ops.py", line 220, in load_library
    ctypes.CDLL(path)
  File "/usr/lib/python3.8/ctypes/__init__.py", line 373, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /usr/local/lib/python3.8/dist-packages/torchtext/lib/libtorchtext.so: undefined symbol: _ZN2at4_ops5zeros4callEN3c108ArrayRefINS2_6SymIntEEENS2_8optionalINS2_10ScalarTypeEEENS6_INS2_6LayoutEEENS6_INS2_6DeviceEEENS6_IbEE

Also this problem happens with the Colabs at https://github.com/camenduru/stable-diffusion-webui-colab
I guess this is not an issue of the latest Automatic1111 GUI because Camenduru uses a previos version of A1111 (I guess that a more stable one). In that case the error message after the instalation is:
Loading weights [1a97f4ef] from /content/stable-diffusion-webui/models/Stable-diffusion/Elysium_Anime_V3.safetensors
Applying xformers cross attention optimization.
Model loaded.
Traceback (most recent call last):
  File "launch.py", line 303, in <module>
    start()
  File "launch.py", line 294, in start
    webui.webui()
  File "/content/stable-diffusion-webui/webui.py", line 139, in webui
    shared.demo = modules.ui.create_ui()
  File "/content/stable-diffusion-webui/modules/ui.py", line 639, in create_ui
    modules.scripts.scripts_txt2img.initialize_scripts(is_img2img=False)
  File "/content/stable-diffusion-webui/modules/scripts.py", line 235, in initialize_scripts
    script = script_class()
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 125, in __init__
    callbacks.register_on_infotext_pasted(self._pnginfo_saver)
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/callbacks.py", line 66, in register_on_infotext_pasted
    script_callbacks.on_infotext_pasted(on_infotext_pasted)
AttributeError: module 'modules.script_callbacks' has no attribute 'on_infotext_pasted'

Also this problem happens with the Colabs at https://github.com/camenduru/stable-diffusion-webui-colab I guess this is not an issue of the latest Automatic1111 GUI because Camenduru uses a previos version of A1111 (I guess that a more stable one). The main difference between TLB and Camenduru is that Camenduru doesn´t connect with Google Drive, so all new execution is from a fresh start.
In that case the error message after the instalation is:
Loading weights [1a97f4ef] from /content/stable-diffusion-webui/models/Stable-diffusion/Elysium_Anime_V3.safetensors
Applying xformers cross attention optimization.
Model loaded.
Traceback (most recent call last):
  File "launch.py", line 303, in <module>
    start()
  File "launch.py", line 294, in start
    webui.webui()
  File "/content/stable-diffusion-webui/webui.py", line 139, in webui
    shared.demo = modules.ui.create_ui()
  File "/content/stable-diffusion-webui/modules/ui.py", line 639, in create_ui
    modules.scripts.scripts_txt2img.initialize_scripts(is_img2img=False)
  File "/content/stable-diffusion-webui/modules/scripts.py", line 235, in initialize_scripts
    script = script_class()
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 125, in __init__
    callbacks.register_on_infotext_pasted(self._pnginfo_saver)
  File "/content/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/callbacks.py", line 66, in register_on_infotext_pasted
    script_callbacks.on_infotext_pasted(on_infotext_pasted)
AttributeError: module 'modules.script_callbacks' has no attribute 'on_infotext_pasted'

Do you know which version of auto1111 is being used? on_infotext_pasted is definitely there. See here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/modules/script_callbacks.py#L311

I'm going to look into the torch issue over the weekend - see this issue - https://github.com/adieyal/sd-dynamic-prompts/issues/208

@adieyal Uh, sorry, right now I'm tired and I don't remember correctly.
Camenduru allows you to use the latest Automatic1111 if you select the 2.0 branch: https://github.com/camenduru/stable-diffusion-webui/blob/v2.0/modules/script_callbacks.py
If not, it uses the 1.6 version: https://github.com/camenduru/stable-diffusion-webui/blob/v1.6/modules/script_callbacks.py
I think that I used the 1.6, but I was doing other tests and now I'm not sure if it was 1.6 or 2.0.
If you need I can try tomorrow to reproduce the error.

Closing as stale.


Update sbt-header to 5.1.0

Updates de.heikoseeberger:sbt-header from 5.0.0 to 5.1.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #134 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #134     +/-   ##
=========================================
- Coverage   92.62%   92.02%   -0.6%
=========================================
  Files          66       56     -10
  Lines        1099      941    -158
  Branches       51       48      -3
=========================================
- Hits         1018      866    -152
+ Misses         81       75      -6

Impacted Files
Coverage Δ

core/shared/src/main/scala/cron4s/expr/parts.scala
0% <0%> (-66.67%)
:arrow_down:

...d/src/main/scala/cron4s/lib/javatime/package.scala
50% <0%> (-8.34%)
:arrow_down:

core/shared/src/main/scala/cron4s/expr/nodes.scala
78.68% <0%> (-4.65%)
:arrow_down:

.../main/scala/cron4s/datetime/PredicateReducer.scala
100% <0%> (ø)
:arrow_up:

...main/scala/cron4s/testkit/gen/CronGenerators.scala
100% <0%> (ø)
:arrow_up:

...ain/scala/cron4s/testkit/CronDateTimeTestKit.scala
100% <0%> (ø)
:arrow_up:

...c/main/scala/cron4s/validation/NodeValidator.scala
100% <0%> (ø)
:arrow_up:

...e/shared/src/main/scala/cron4s/expr/CronExpr.scala
100% <0%> (ø)
:arrow_up:

...main/scala/cron4s/testkit/discipline/package.scala
0% <0%> (ø)
:arrow_up:

.../cron4s/testkit/gen/ArbitraryCronFieldValues.scala
100% <0%> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6464af7...7a822e5. Read the comment docs.


DOC: v0.2/docs/integrations/platforms Clarifications and Enhancements

Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
This ticket covers a lot of things in the section on integrations/platforms (Providers/Packages). It can/should be broken into individual tickets based on feedback and approval.

Ref https://js.langchain.com/v0.2/docs/integrations/platforms/
H1 header "Providers".
H2 header "Partner Packages"
Text : "These providers have ..."
LangChain, Inc is a business and the term "Partner" now implies business associations and perhaps legal relationships. The term should be considered more carefully now, more-so than a common FOSS project.
Does the term Partner imply that a SDK Provider is maintaining their own GitHub langchainjs/libs/package repo?
The page URI is "Platform" but that's not the term used for Packages and Providers.
Issues with text under Partner Packages

These providers have standalone @langchain/{provider} packages for improved versioning, dependency management and testing.

The list following the text is a list of packages, not providers. So "These providers have standalone..." is inaccurate and the sentence probably should have started as "Providers have standalone...".
NPM packages are usually namespaced as "@langchain/{package}" not {provider}. The more likely it is that a given provider (like Microsoft, Amazon, or Google) will have multiple packages, the less likely it is that there will be a @langchain/{provider} NPM package to import.
Even {package} isn't entirely accurate because some integrations are provided under "langchain/community" and other namespaces. That is, while it does help to show that provider packages are in a separate namespace, the naming of namespaces is inconsistent.
Given all of this, it might be best not to be too specific about the namespace reference. See recommendation below.
The text "for improved versioning, dependency management and testing" is abiguous in a trivial way. It could imply that the packages are "for improved versioning, dependency management and testing ... of LangChain projects", which doesn't make any sense for someone familiar with the project and fluent in English. For others, not familiar or fluent, it might read better as "to facilitate versioning, dependency management, and testing of integrations". See recommendation below.
What qualifies a Provider to have their own page?
It might be helpful to clearly define the relationships between Providers, their SDKs, and the maintainers of LangChain integration packages. That is, there is the Provider who has SaaS functionality and provides an SDK. Then "someone" maintains an integration package that wraps the SDK for access with LangChain. Are the packages maintained mostly by devs associated with the Providers? If that's the case then the term Partner has a stronger implication here. If not then it should be more clear that the SDK Provider and the Package Provider are separate entities - common FOSS, no partnerships, no real relation to the SDK providers.
The left-side navigation menu lists five primary Providers, though that list has grown over time. It's obvious that the top five have significant integrations with LangChain, and they are (in all sense) long-time and continuing "partners". For the other providers, it's not clear if their integrations aren't as extensive, or if their lack of a sidebar link is only because no one has created a dedicated documentation page for them.
It makes sense if a provider has multiple packages, or more extensive integrations like vectorstores or document loaders, that they should have their own sidebar link to them as a Provider. But (I believe) Anthropic has one package and yet they have the sidebar link. It's just not consistent.
What are those integrations?
Many (most?) package pages for langchainjs/libs on npmjs.com don't describe the integration provided by the package. They only describe the package with boilerplate text: "This package contains the LangChain.js integrations for Foo through their SDK."
What integrations does Foo provide with their SDK? Or rather, what part of the SDK integrations are supported by the package?
It would help if the list of packages includes a brief description of what SDK functionality the package supports : LLM? embedding? vectorstore? output parsers? retrievers? tools? It might be ideal if there are links to provider pages next to the package links, and available/supported SDK functionality is described in those provider pages.
The list of packages might evolve into a table with columns for all common SDK functionality (not practical) and a checkbox to indicate if the package currently supports that SDK functionality. For a more complete list that's LangChain-focused, the columns can be LangChain functionality (LLM, vectorstore, embedding, output parser, etc) and cells can indicate if (1) that functionality is even provided by the SDK and (2) if the package is currently supporting the functionality exposed in the SDK ... these are different things.
Recommendations

Change the folder for /platforms to /providers.

Set a 301 redirect from /platforms/ to /providers and advise providers to change their own links. Over time this will clear up.

Change header "Partner Packages" to "Provider Packages", or maybe "Integration Packages" to clarify that these are all considered under the category of integrations.
Clarify the menu items on the Provider page.

If all providers should have their own page, if only someone created one, it might be helpful to create stub pages for each provider so that someone can fill them in with "what all does this provider provide?".
As the list grows this might get unwieldy. It might be good now or later to use the top of Providers page (which only has the text "LangChain integrates with many providers." to maintain the list of Providers (um, makes sense) as well as separately listing individual packages. That is, the top section of the page is the list of providers, and the next section is the list of packages from all providers. Then the sidebar menu can be reduced down to a single link to Providers with no sub-items.

Use the top of the providers page to describe what a provider is in this context. Anyone can be a provider to maintain a package that interfaces with some platform. That is, a Provider isn't necessarily a Partner or even a SaaS provider - in this context it's the Package Provider, perhaps a third-party indy-dev who may not be related at all to the actual SaaS/SDK provider who might leave integration packages like this in the hands of their community. Use this space to encourage people to create and maintain packages.
Change text from:
"These providers have standalone @langchain/{provider} packages for improved versioning, dependency management and testing."
to
"Providers maintain standalone NPM packages, usually imported from the '@langchain/{package}' or 'langchain/community' namespaces, to facilitate versioning, dependency management, and testing of integrations."
Enhance the list of packages:

Add a brief description of what functionality is supported by the package.
And/or : Add a link to a new/existing SDK Provider page for the integration was created.
Consider a table that shows features supported by the SDK and package.

Idea or request for content:
No response

Hey @TonyGravagno thanks for raising this - will parse through this and the other documentation issues you've opened.

Shifting towards integration packages instead of partner package: https://github.com/langchain-ai/langchain/pull/21792


Email Templates - Change the signage box

Email Templates. Change the signage in the bottom to Platform Services Team for Private Cloud and to Cloud Pathfinder Team for Public Cloud templates.

Now the signage is split for Public and Private cloud email templates:


ENS .eth domain lookup

Following on from issue #136 we need to implement an ENS domain lookup in the same fashion as standard Ethereum address lookup works.

@409H Question, is a dedicated ENS lookup needed for this app? The following urls will give valid results.
https://etherscan.io/address/mewtopia.eth
https://etherscan.io/address/0x7cb57b5a97eabe94205c07890be4c1ad31e486a8
https://etherchain.org/account/mewtopia.eth
https://etherchain.org/account/0x7cb57b5a97eabe94205c07890be4c1ad31e486a8
The logic that currently gives the user a block explorer link is:
objNodes[x].innerHTML = strContent.replace(
	new RegExp(strRegex, "gi"),
	'$1$2'
);

Looking at this there are no checks that the link points to a valid address, so I'm presuming that is not a prerequisite.

Ah, sorry, I think I've misunderstood you earlier.
When I said a ENS lookup, I meant some sort of screen that does something similar to what Etherscan does, see below;

I think you're saying something along the lines of adding a link to a block explorer (like Etherscan) for strings like mewtopia.eth?

Ah, ok, I see. I think I misunderstood you.

I think you're saying something along the lines of adding a link to a block explorer (like Etherscan) for strings like mewtopia.eth?

Yes, this is what I'm suggesting, because at the moment the application converts ethereum addresses into links to a selected block explorer.
In order to create this kind of functionality for EAL the application would need access to an Ethereum node, or better a server that has parsed the block data from the Ethereum blockchain.
What about a transitional set of functionalities that reference pre-existing block explorers, and then move onto developing the block analysis server to pass data to the client?

What about a transitional set of functionalities that reference pre-existing block explorers, and then move onto developing the block analysis server to pass data to the client?

Sounds good for phase 1! 👍

Looking at a lot of the enhancements they seem to be dependent on having programmatic access to a blockexplorer.
I think that building a new explorer may be overkill, at the moment any way, when we can use APIs https://etherscan.io/apis.
I'd suggest that we develop a whole new extension to this application, a server side portion that is called by the client extension.
Benefits:

We don't expose our API key.
We can control API calls, and cache and return results as needed.
We build the beginnings of a service that gives the user client side info about an account on the page they are looking at. (which I think is the aim of this project)

I propose that we'll need a new repo for managing this functionality as none of it will be related to the functionality in this repo, except for the calls requesting data.

Dependent issues (at least from my understanding):

https://github.com/409H/EtherAddressLookup/issues/3
https://github.com/409H/EtherAddressLookup/issues/143

I agree with the above. I'll review the 2 PRs that are open and get them packaged tonight, then I'll hit you up to chat more about this.
I'm at work right now, so will be in about 10 hours.

Awesome!


dspecq ceda-cc report for CNRM-CM61 v20221004

long_name corrections needed for
tauv: long_name="Surface Downward Northward Stress" [correct: "Surface Downward Northward Wind Stress"]
tauu: long_name="Surface Downward Eastward Stress" [correct: "Surface Downward Eastward Wind Stress"]
snw: long_name="Surface Snow Amout" [correct: "Surface Snow Amount"]

cell_methods corrections needed for
sithick: cell_methods="area: time: point where sea ice" [correct: "area: time: point where sea_ice"]

errors found and checks aborted for
tas, tasmin, tasmax, uas, vas

Peter has updated the data preparation guide with information about variables with surface dimensions
https://docs.google.com/document/d/1Ke4i5hOwohgzeXebvqSyhC1h8XNj91KPgR-ijiz6Ot8/edit?usp=sharing

errors found and checks aborted for tas, tasmin, tasmax, uas, vas e.g. C4.003.003: [height_levels]: FAILED:: height coordinate not found ['height10m', 'time_bnds', 'uas'] C4.003.xxx: ABORTED:: Errors too severe to complete further checks in this module

The coordinate variables on the net-CDF files need to be called 'height' rather than 'height2m' or 'height10m' for the tas, tasmin, tasmax, uas, vas files.
Replacing 'hight2m' and'height10m' with 'height' in the same way as the 'tas' example in the guide should fix the problem!


CLICKHOUSE-2981: basic styling of sphinx docs

Can one of the admins verify this patch?

It's also included in https://github.com/yandex/ClickHouse/pull/804


Delete pr-stats.yml

seems like it just doesn't want to work

ima test the rebase action rq i dont think it was ever tested

:rebase

that did literally nothing wtf


[jvm-packages] Executors fail during prediction (Doing rabit call after Finalize)

I was trying to predict data using the trained model in a spark cluster of 3 nodes with yarn, but executors failed by accident.  New executors will be started to continue the spark task. The spark task can be finished sucessfully and I can still get the correst predictions. However, after several times, the spark context will be shut down because the maximum executor failures reached.

I tracked the logged in the corresponding yarn container, and found that "Doing rabit call after Finalize" (see the attached log).  Then I traced the code, which is in utils:Check in rabit/src/engine.cc. It seems executors failed because the util:Check failed and return exit(-1).
It seems rabit is init and shut down in buildDistributedBoosters in train function. Is there any rabit call in prediction?
Any idea about this problem?
Logs for container_1466187764481_0008_01_000007.pdf

Would you post the complete stack trace of your executor at the moment of executor lost?
Additionally, what's your data size, hardware configuration and xgboost configuration?

Thanks for the quick reply!
Attached is the corresponding spark log. There are three errors indicating executor fails. I didn't find any information about why the executor failed.
The testing dataset is iris, which has 150 points with 1 label and 4 features. The cluster has 3 nodes, each node has 1 core and 512M mem for spark job.
XGBoost Configuration is as follows:
{"objective":"multi:softmax","num_class":3,"eval_metric":"mlogloss","nthread":1,"eta":0.3,"max_depth":2,"gamma":0,"subsample":1,"colsample_bytree":1,"min_child_weight":1,"silent":0}
In addition, nworker is 3, nround is 10
spark.log.txt

I'm guessing that the container is killed by YARN...would you also post NodeManager's log?

Yes, the yarn container is killed. The exist code is 255. I checked the C code  in utils:Check in rabit/src/engine.cc, the check failed the return exit(-1), could it be the reason?
Attached is the detailed NodeManager's Log.
yarn-yarn-nodemanager-vm68.txt
2016-06-21 18:25:14,479 WARN org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor: Exception from container-launch with container ID: container_1466502817260_0002_01_000004 and exit code: 255
ExitCodeException exitCode=255:
at org.apache.hadoop.util.Shell.runCommand(Shell.java:538)
at org.apache.hadoop.util.Shell.run(Shell.java:455)
at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:702)
at org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.launchContainer(DefaultContainerExecutor.java:195)
at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:300)
at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:81)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

hmmm...from the log, it seems that the error happens only after the training is done, i.e. prediction phase
I haven't got the exact reason of the failure, but what's the version of Spark are you using, it seems that you are using something earlier than 1.6?

I'm using Spark 1.5.1. Could it be the reason? If yes, how can I fix it ?  Is rabit needed in prediction phase??  I noticed that the rabit is initialized and finalized in the training phase.
By the way, in the spark local model, it can work without such error.

rabit shall not be involved in prediction phase

could you try spark 1.6.x?

The spark version in my cluster is 1.5.1.  Could you give me some clues to fix this bug? I'm quite confused why  "Doing rabit call after Finalize" happened in the prediction phase.

I looked at the log again, after all training is done, 16/06/20 04:13:58 INFO org.apache.spark.scheduler.DAGScheduler: Submitting 6 missing tasks from ResultStage 16 (MapPartitionsRDD[15] at map at XGBoost.scala:44) appeared again, would you check why the training job is submitted again?

BTW, I was not able to map XGBoost.scala:L44 to any working code....would you pull the latest code of xgboost, try again and upload the log?

XGBoost.scala:44 is predict method,  which is,
val res = xgb.predict(testRDD, false).flatMap(x => x).map(_.mkString(delimiter))
Thus it is the prediction job by using the trained model.
Attached file is XGBoost.scala
XGBoost.scala.txt
Thanks

Hi @CodingCat ,
I found that, the executors won't fail, when I set a system sleep of 60 seconds between the training and prediction phase. Do you know why? Maybe something with rabit?
Attached is the updated spark log, where I tried two times of training + prediction.
In the first time, prediction is after training immediately and the executors failed. In the second time, the prediction waited for 60s seconds after training, and the task finished successfully.
discover-spark.log.txt

sorry for the late response, I was in travelling
Did you change the spark version number in pom.xml when compiling xgboost for your 1.5.1 cluster, if not, I think it might be unpredictable what will happen in the program

for 60s sleeping issue, I have no idea about what happened since nodemanager only killed "died" executor

Yes, the version is changed to 1.5.1 in pom when compiling .
If model prediction starts immediately after the model training:
xgboost “Doing rabit call after Finalize”， and exit -1
Then executors process exited and are killed by nodemanager
I think it must be somewhere using rabit, but rabit is already finalized in the training phase.
The following codes are what I found in rabit, the check failed and exited-1 which killed the jvm process:
/*! \brief singleton method to get engine */
IEngine *GetEngine() {
  // un-initialized default manager.
  static AllreduceBase default_manager;
  ThreadLocalEntry* e = EngineThreadLocal::Get();
  IEngine* ptr = e->engine.get();
  if (ptr == nullptr) {
    utils::Check(e->initialized,
                 "Doing rabit call after Finalize");
    return &default_manager;
  } else {
    return ptr;
  }
}

inline void Check(bool exp, const char *fmt, ...) {
  if (!exp) {
    std::string msg(kPrintBuffer, '\0');
    va_list args;
    va_start(args, fmt);
    vsnprintf(&msg[0], kPrintBuffer, fmt, args);
    va_end(args);
    HandleCheckError(msg.c_str());
  }
}

inline void HandleCheckError(const char *msg) {
  fprintf(stderr, "%s\n", msg);
  exit(-1);
}

Answers for the following questions are appreciate and helpful for me to locate the problem:

I want to know why rabit is called in the prediction phase. Is it possible if the trained model is lost, and reload from the cache which call rabit?
I noticed that, the booster need to be broadcast by spark broadcast operator before predction. Does it have any conflits with rabit broadcast? Because I found that the broadcast calls rabit engine

// broadcast data to all other nodes from root
inline void Broadcast(void *sendrecv_data, size_t size, int root) {
  engine::GetEngine()->Broadcast(sendrecv_data, size, root);
}

I want to know why rabit is called in the prediction phase. Is it possible if the trained model is lost, and reload from the cache which call rabit?

As the expected case, rabit is not called in the prediction phase,
test and train phase shall not have direct interaction, since the booster is collected as a driver-side variable before broadcasting

I noticed that, the booster need to be broadcast by spark broadcast operator before predction. Does it have any conflits with rabit broadcast? I found that the broadcast calls rabit engine, which may cause the problem if the rabit broadcast happened in prediction phase.

no, broadcast of booster is an Spark-domain functionality

Okay.. But here the weird is that the log shows rabit is called after finalized..

have you ever run mvn test successfully? (with/without changing spark version to 1.5.1)

Yes, both spark 1.6.1 and 1.5.1 can pass mvn test

May I ask why the condition if(testSamples.hasNext) in spark predict is like this? Shall it be if(testSamples.isEmpty) ?
testSet.mapPartitions { testSamples =>
      if (testSamples.hasNext) {
        val cacheFileName = {
          if (useExternalCache) {
            s"$appName-dtest_cache-${TaskContext.getPartitionId()}"
          } else {
            null
          }
        }
        val dMatrix = new DMatrix(new JDMatrix(testSamples, cacheFileName))
        Iterator(broadcastBooster.value.predict(dMatrix))
      } else {
        Iterator()
      }
    }

They are the same in implementation

I see. Thanks.
May I ask one more question about rabit. Do we have to repartition the trainRDD to numWorkers partitions?  As I understood, each partition corresponds to a task, which is executed in one thread. Can each thread has its own rabit? Or rabit has to be used (initialized and finalized) in process level for each executor?

each thread (i.e. task or xgboost worker) can have its own rabit.....

I see, THX!
By the way, I think I have found the bug. The prediction do call rabit engine in distributed model. In c_api.cc, XGBoosterPredict calls bst->LazyInit(),
inline void LazyInit() {
    if (!configured_) {
      learner_->Configure(cfg_);
      configured_ = true;
    }
    if (!initialized_) {
      learner_->InitModel();
      initialized_ = true;
    }
  }

configured_ in the Booster Constructor is false and will call learner_->Configure(cfg_);
In Configure() in learner.cc, rabit::IsDistributed() calls rabit::getEngine() and cause the error: "Doing rabit call after Finalize"
if (tparam.dsplit == 0 && rabit::IsDistributed()) {
      tparam.dsplit = 2;
    }

I just created a new pull request for this bug, where I added rabit init also in spark prediction phase. It is tested in yarn-cluster and executors won't fail in prediction phase anymore.

Hi, @tqchen what's the intention to call rabit in prediction, as after training we have sync the boosters?


Adding full forwardInternal example

typescript isn't my strong suite, so the example may need help.


rai fails with "Error: unable to perform auth0 query"

At PUMPS 2019, we had one student on Windows Subsystem for Linux using the linux client who had the following error:
✱ Checking your authentication credentials.
Error: unable to perform auth0 query for auth0|5d10fdc3b19e160da84b31ce:
Post https://raiproject.auth0.com/oauth/token: EOF
unable to perform auth0 query for auth0|5d10fdc3b19e160da84b31ce: Post
https://raiproject.auth0.com/oauth/token: EOF
2019/06/25 16:12:41 error: unable to perform auth0 query for
auth0|5d10fdc3b19e160da84b31ce: Post
https://raiproject.auth0.com/oauth/token: EOF

We believe this is caused by a problem with the system's SSL configuration. For example, the student was unable to wget https://www.google.com.

The student reported that he was able to configure his WSL environment to work with SSL, but the problem remains.

why not use the windows client?

The windows client currently doesn't work. Some error about an unsupported platform or binary, I can't quite recall.


Zero normals fix

Before:

After:

Brilliant. Thanks for that. Are you using it in a project?

You are welcome. Not yet. I have a package with voxel destructions that I've used in a couple of projects.
https://play.google.com/store/apps/details?id=com.monster.demolition&hl=en_US
https://play.google.com/store/apps/details?id=com.thuggg.life&hl=es_419
But I'm using mesh generation with jobs, and I have an idea to render voxels with ray marching and use mesh generation for physics and collisions

Wow. Those games look great. I've yet to release a serious commercial game like those. How are you finding the free to play model. Is it generating any revenue for you?
Best of luck with your engine. There is something about voxels that is just really appealing and games like Teardown are the best of that kind of genre. I aspire to do something like that one day.

I just noticed your message. I'm just a regular developer at a company. I don't deal with issues related to the promotion of the game or monetization. Other people handle that. So, I simply receive a salary for my work. Good luck with your projects!


Custom solvers as arguments

I'd like to be able to pass a custom solver as an argument:
class MyClusterSolver(ClusterSolver):
    def kernel(self, *args, **kwargs):
        # some custom code

dmet = DMET(mf, solver=MyClusterSolver)

As far as I can tell this only supports string identifiers for the built-in solvers. Having a custom solver will be important to me and seems like a nice feature, or is there a workaround?

obviously don't mean just for DMET, as a feature of the Embedding base class would be nice

Currently custom solver classes are not supported. However, you can use the callback solver. This allows you to specify a custom function that takes a dummy pyscf MF representing a cluster as an input and returns a results dictionary as output. Currently RDMs, CISD and CCSD amplitudes as well as Green's function moments are automatically recognized and interoperable with vayesta's expectation value calculations.
There are some examples for both solids and molecules in the ewf directory.

Indeed @obackhouse - the callback function that @basilib implemented is how we are currently dealing with external solvers - it seems to work quite well, but open to comments and suggestions. Longer term, it'd be nice to have some data structures for the embedding objects that were more practical to serialize, so that we could also run the calculations entirely separately to vayesta while not retaining the particular instance of the embedding class. However, we can also just dump the information for the cluster hamiltonian to solve externally. I'd suggest having a look at the examples 62-67 in examples/ewf/molecules. Let us know if you need further help.

i can check if this will work as a workaround, but in terms of a good interface for users of a vayesta extension, being able to pass the solver itself is the difference between having to do
from myextension import Solver
dmet = DMET(mf, solver=Solver)

and
from myextension import solver_callback
dmet = DMET(mf, solver="CALLBACK", solver_options=dict(callback=solver_callback))

The latter means that you have to access a specific intricacy of the vayesta API to support custom extensions, rather than an intuitive pattern in the former, so I do think that this would be a good feature to support.

I agree with Ollie's suggestions, but please define an abstract base class
which custom solvers need to extend
On Tue, 22 Oct 2024, 08:44 Oliver Backhouse, @.***>
wrote:

i can check if this will work as a workaround, but in terms of a good
interface for users of a vayesta extension, being able to pass the solver
itself is the difference between having to do
from myextension import Solverdmet = DMET(mf, solver=Solver)
and
from myextension import solver_callbackdmet = DMET(mf, solver="CALLBACK", solver_options=dict(callback=solver_callback))
The latter means that you have to access a specific intricacy of the
vayesta API to support custom extensions, rather than an intuitive pattern
in the former, so I do think that this would be a good feature to support.
—
Reply to this email directly, view it on GitHub
https://github.com/BoothGroup/Vayesta/issues/180#issuecomment-2428503149,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBNUNRNX2CD4R477Z3YVL3Z4X66BAVCNFSM6AAAAABQKSRX3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGUYDGMJUHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I agree with Ollie's suggestions, but please define an abstract base class which custom solvers need to extend

in the absence of static typing, just using vayesta.solver.solver.ClusterSolver should be fine? kernel is not an abstractmethod but it raises an AbstractMethodError

fwiw, callback solvers also don't support custom WaveFunctions, which is another reason to support true custom solvers.


Progress Indicator Stays Still all Throughout any Operation

Description

Steps To Reproduce
Begin any file operation
Title bar indicator stays still at 0 completion, despite actual progress being made and shown once clicked through a progress bar
Requirements
The indicator should reflect the progress of the foremost ongoing operation at a glance, as such is its intended purpose.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.2788
Log File
debug.log

Thanks for the report, Please update to <IP_ADDRESS> and try reproduce this. https://files.community/download

This has in fact been fixed, thank you for the help.
The reason I hadn't already updated is that it would seem that for some reason, the update button native to the app refuses to properly update the app (either loads forever, or disappears after a few seconds of loading).
Is this intended behaviour ? (Note that I have installed the app manually, and not through the store.)

The update issue is with Windows and doesn't work for everyone all the time.


[STORM-1449] Fix Kafka spout to maintain backward compatibility

STORM-1220 introduced some changes where in one place it passes ByteBuffer as is instead of byte[].
Existing bolts (0.10.0) expects a byte[] and fails with
"java.lang.RuntimeException: java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to [B "
This patch addresses the issue by emiting byte[] instead of ByteBuffer.

+1

+1

Looks like this is for https://issues.apache.org/jira/browse/STORM-1449 not 1499.

Sorry for the typo, changed the subject.

Just ran in to an issue where this fix does not work. Correct me if i am wrong. But a fat storm jar that is compiled with older version of storm-kafka will still use byte[] and the newer version of storm now uses ByteBuffer. Hence it throws an exception at runtime if storm is upgraded. I think upgrade of storm should still work with older topology jars.

@priyank5485 you are correct.  I didn't look into this in great detail until now.  What is more if you submit using an old client you will get deserialization errors too, because the SerialId is not set.
STORM-1220 seems to fundamentally not be able to maintain that backwards compatibility.  So now the question is are the benefits of STORM-1220 worth the incompatibility?  To me it seems likely that they are, because it is just updating a dependency.

@revans2 I am fine with the changes except one major concern pointed out by @Parth-Brahmbhatt I confirmed this with him and our main concern would be the rolling upgrade feature for topologies with kafka spout. That would not work anymore.

We can either just include this as a warning as part of Release Notes or we can roll this change back. I am fine with including just a Release Note to warn all users trying to upgrade unless others thing Rolling upgradability is important enough that we only brake it when people move between major versions.

@priyank5485 @revans2 @Parth-Brahmbhatt the changes introduced by STORM-1220 has not yet gone out in any releases. It will go out in 1.0 but with the fix in this PR (which is also part of 1.0) the changes are backward compatible. i.e. the KafkaSpout would emit byte[] and not ByteBuffer as values in the tuples. So the old bolts (that expects a byte[]) would continue to work with the new KafkaSpout.
I assume @priyank5485 got the issue when the jar was built from master branch before this PR got merged in and got bundled with the client.
Correct me if I am missing something.

It sounds like everyone is fine with the current set of incompatibilities, so it comes down to a documentation issue.  I looked at the storm-kafka docs and I don't see anywhere that this incompatability is mentioned.  In fact in the section that talks about the MultiSchema it needs to be updated to reflect the changes from STORM-1220.
Could someone on this list file a JIRA or just update the documentation to explain the incompatibility and how to upgrade?

Filed JIRA and will update the doc - https://issues.apache.org/jira/browse/STORM-1486
There is no incompatibility since the emitted tuple values continue to be byte[]. Only the api signatures of the MultiScheme (and other schemes) have changed. It now accepts a ByteBuffer instead of byte[] but returns tuples with byte[]  as values as before.

@arunmahadevan There are several incompatibilities.  Most of them don't matter because this is a part of the 1.x release, so rolling upgrades/etc will not be possible.
The one incompatibility that remains is that you cannot use a pre 1.x kafka spout on a 1.x cluster.  It is always good practice to maintain the versions the same, but in this case it is required.
KafkaUtils.generateTuples, calls the modified MultScheme.deserialize API making this a problem.

@revans2 I see what you are saying. Will document this incompatibility.

Maintaining backward compatibility is bi-directional, which means just modifying core can break module's backward compatibility what @revans2 stated.
We should bear in mind of backward compatibility with core itself.
Adopting semver is great to go, and in fact preparing 1.0.0 is the chance to break backward compatibility if necessary. If we were deprecated some classes/methods, let's review.
I expect we can not have a chance to release another major version sooner (except 2.0, it is not for such change)


impl RelativeEq for Option<T: RelativeEq>?

I'd like to be able to write the following code:
pub fn maybe_f32(foo: f32) -> Option<f32> {
    // ...
}

/// in test
let c = maybe_f32();
assert_relative_eq!(maybe_f32(123.0), None);

I could do:
assert!(maybe_f32().is_none());

However, the advantage with the first version, is that on failure I can also see the actual value that was returned from maybe_f32, speeding up debugging a little bit.

Oh, I see someone already did this in #57


Explain about the automated tests on Travis

in order to advise contributors to locally test their patches.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks! Definitely seems like good information to have.

In a sense you chose not to release the fix on rerun-if-changed by distributing the lock file.

Or rather I chose to have stability over gaining new features asap :)
Do you want to check in the upgrade to Cargo.lock as part of this PR as well?

https://travis-ci.org/rust-lang/libc/jobs/125987669

+curl https://static.rust-lang.org/rustup.sh

++rustc --print sysroot

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0+sh -s -- --add-target=x86_64-apple-ios --disable-sudo -y --prefix=/Users/travis/rust

100 60459  100 60459    0     0   107k      0 --:--:-- --:--:-- --:--:--  107k

rustup: assert_nz url is empty!

@bors: r+ cba130bc01d7f6fea035ca0410feac02bb80ebd8

:hourglass: Testing commit cba130b with merge 012d1e0...

:broken_heart: Test failed - travis

@bors: retry
On Tue, Apr 26, 2016 at 11:45 PM, bors<EMAIL_ADDRESS>wrote:

[image: :broken_heart:] Test failed - travis
https://travis-ci.org/rust-lang/libc/builds/126025430
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/libc/pull/259#issuecomment-214986350

:hourglass: Testing commit cba130b with merge 58165d4...

:broken_heart: Test failed - travis

@bors: retry
On Wednesday, April 27, 2016, bors<EMAIL_ADDRESS>wrote:

[image: :broken_heart:] Test failed - travis
https://travis-ci.org/rust-lang/libc/builds/126148305
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/libc/pull/259#issuecomment-215144334

:hourglass: Testing commit cba130b with merge 8025a3e...

:sunny: Test successful - status-appveyor, travis


Bugs: issues with screen rotation during generation

Hi,

When using the assistant window, if the screen rotates the assistant closes (this is #41)
When using the chat window, if the LLM is currently talking while the screen rotates, the currently appearing message disappears. I think I once also got a crash once but can't reproduce.

Have a nice week end

Now assistant will not close when activity state is changed and all generated text will be saved. But text generation process will be stopped due to Android restrictions. Try not to rotate screen during generating response as you will receive incomplete response.


range bug: unable to move value1 pointer once it's been positioned to value2 pointer

Thank you for this great slider! I will be using it on tld-list.com and some other projects.
Bug:
When you have a range (i.e. value1 and value2), and you slide the value1 pointer to the same position of the value2 pointer, the value1 pointer cannot be moved again. If the value2 pointer is in the max right hand position, both pointers become locked.
Reproduce:

Go here: https://jsfiddle.net/7ok4atrj/
Slide the left pointer (value1) all the way over to the right, on top of the value2 pointer. Release mouse button.
Attempt to move value1 pointer.

Firefox 102.0.1 and Chrome 114

Thank you for the feedback. The issue should be fixed in v4.0.28
https://jsfiddle.net/rosehip/p1f7qtm9/1/


The amount of tilemap layers has a huge impact on performance

http://test.xapient.net/phaser/ALL/layers.html  (AUTO)
http://test.xapient.net/phaser/ALL/layers-canvas.html  (CANVAS)
as you can see in the given example 1 layer (no matter how many tiles are actually filled) does not affect the performance at all  (62fps)
canvas size 800x640
tilemap 200x20
tilesize 32x32
4 layers will result in 52 fps
6 layers in 42 fps
8 layers in 34 fps
(on my workstation)
these test results will show if  you use a webbrowser without gpu rendering enabled (for example chromium on linux) or a low performance device like a tablet (tested with google nexus 7)
if you combine all the layers to one and place all tiles on the same layer you will again have 62 fps
so the amount of tiles is not responsible for any noticeable performance loss..
even 4 giant background images moved relative to the camera (parallax) will have no impact on the performance..  but even a complete empty layer will do !

Closing this off as we've updated tilemap rendering lots recently to assist with this.


Statusline normal mode doesn't automatically adjust to colorscheme change

I have to load my vim colorscheme like this:
autocmd VimEnter * colorscheme onedark

(Due to issues with its plugin path.) This seems to result in lightline colors not working for normal mode. (Independent from chosen lightline colorscheme.) If I switch to any other mode (insert, visual, ...), coloring of lightline works in that mode. However, switching back to normal mode, lightline colors stop working again.
:redrawstatus doesn't help. However, if I run :colorscheme onedark manually again, lightline coloring works in normal mode, too. Running :call lightline#colorscheme() doesn't work right away, but after switching to any other mode (insert, visual, ...) and back - now normal mode works, too.
Unfortunately, adding another autocmd doesn't seem to help, either:
autocmd VimEnter * call lightline#colorscheme()

I couldn't find any mentions of a similar issue in previous threads. Maybe you can see what's wrong right away. I tried to describe the issue, but please let me know if I should go more into detail or post a screenrecording or steps how to reproduce.
Thank you very much in advance.

Try autocmd VimEnter * ++nested colorscheme onedark.

Delaying setting colorscheme to VimEnter is non-standard usage (you don't need to do if you properly configure runtime paths), so it can cause some unexpected side effects like that.


Always enable server config and make it customizable

Description of your changes:
We should always mount the server config, regadless of whether we have a custom cabundle or not, so that we don't end up in a situation where based on the cabundle we are using different configs, as that may result in different behaviors if somehow the default config in the dsp server image ends up diverging from the one we mount.
Testing instructions

Deploy simple dspa
confirm server-config is mounted, in the pipeline server pod you should see the following:

         volumeMounts:
            - name: server-config
              mountPath: /config/config.json
              subPath: config.json

confirm pipeline runs successfully

Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/605/head
git checkout -b pullrequest a3ceacb47f3fd4c0bb0d5f9acdf49b904394a39b
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-605"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

/approve


Swift 3+ runForever example

Do you have an example of running your DefaultHTTPServer asynchronously in the background using Swift 3.0 or greater? I would like to use Ambassador in an XCTest ( i.e. NOT XCUITest) to build a lightweight mock REST server for unit testing an API that I'm building.
Thanks in advance,
Rowland

Hi @PeaceKeeperOrg,
You can see our UITestBase example in our blog post
https://envoy.engineering/embedded-web-server-for-ios-ui-testing-8ff3cef513df#.jf4nit18p
You can also see the gist here
https://gist.github.com/fangpenlin/b180cc4a3c7bbe123ee298b03067b6ab
Although it's for UI testing, it won't be any different to just inherit from XCTest instead in your case.

Hi @fangpenlin, I tried to follow those guidelines but I cannot make it work properly.
I have create the files you said in the article but still not working as I expected. I have created the "DefaultRouter" file, UITestBase file and MyUITests file in my UI Test folder. Also I have created an Alamofire requets in my ViewController with is the endpoint I want to mock with Ambassador, but the localhost from Ambassador is always "http://[::1]:8080/api/v2/users" and it never returns the correct information.
What can I do to make it work? Do you have a really working example? Because I never found a real working example mocking an endpoint from a ViewController.
Thanks in advance,
Regards.


feat: Add tests and deployment workflows

This is a great package @Tech1k. I figured i should add the CI scripts to run the unit tests and also publish the package to PYPI once you make a release of a new version by tagging it.

If you merge this pr, you will be required to set PYPI_USERNAME and PYPI_PASSWORD to allow github actions to authenticate anytime you make a release and the package is published to PYPI by the CI script.

I appreciate this, thank you for your pr!


node labels being applied with business rules from help page enforced

I'm new to Rust and krustlet, so forgive me if it's not spot on. Happy to take feedback and incorporate.  I think this effectively enforces the rules specified by the man page, and also handles building all mandatory labels in one functional chain.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DerekStrickland sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I'm going to take a stab tomorrow morning at incorporating feedback from PR 197 into this one so we get the best of both our efforts.

@DerekStrickland 👋 https://github.com/deislabs/krustlet/pull/197 is already ready to be merged. Why are you duplicating efforts?

@jingweno Hi!  As I commented on the issue, I started this yesterday, and was just testing before I submitted a PR this morning.  I wasn't trying to duplicate effort, so, sorry for that. It just seems we both decided to take a pass at the same time. You actually taught me a better way to handle the JSON merging that what I was doing so thanks for that! The main difference I think is that I tried to handle the prefix/allowed namespaces rules from the man pages, and created a builder function that combines the default, runtime, and arg provided labels all at once. Maybe I should wait for your PR to be merged and then branch and add my stuff?  cc'ing @thomastaylor312 to get maintainer input on how/whether to proceed.

@DerekStrickland Since you are building on top of the work in #197 I think we should review and merge that one and then you can rebase your work on top of that

@thomastaylor312  perfect.  Will do.

Hi @DerekStrickland! #197 has now been merged. As a heads up, a few things were changed in the PR before it was merged so there might be a few things you'll need to tweak in this PR. Let us know when this is ready for another review.
Thanks again for your contribution!


AM/PM is used in the date/time picker

While this isn't a problem for US English, most of the word uses 24h, not 12h, time. We should investigate a way to allow this to display 24h time.

I'm not sure if this is even possible so I'm not going to push this as a blocking issue of 8.0


CLI Interface for tiquet.me

We need a CLI tool for interacting with tiquet.me
Usage:

tiquet list: read the current .git dir (or fail if none exists) and list all assigned tiquets to the current user
tiquet list --all: read the current .git dir (or fail if none exists) and list all tiquets of the repository
tiquet pls: read the current .git dir (or fail if none exists), get the oldest tiquet from the project and assign it to the current user
tiquet help pls: help manual

Windows is not supported.

Authentication would be done by storing an authentication token from the system in ~/.config/tiquet.me.conf.

Probably should just use python with requests.


[3376] Complex Dictionary-Key gets serialized to [object Object]

Fixes #3376

ToString method mimics .NET (if ToString is not overrided then it displays type name)
Nested type name uses + (plus) as separator between parent and own name

Another part of fix will be in Newtonsoft

This also fixes #2887.

Tests fixed and rebased with other commits. Github didn't detect the merge, but the diff is perfect.


cURL error

Hello,
I am running this library on an Ubuntu VM and I keep getting this error:
cURL error 7: Failed to connect to ssl.google-analytics.com port 443: Connection refused (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)
However, trying a curl to that website works fine.
How to debug it?
Thank you

Hi,
You've opened the issue here: https://github.com/theiconic/php-ga-measurement-protocol/issues/22
Which is relevant. Because this is simply a bridge for Laravel and those settings are not controlled from this package.
That said, I'll respond to that ticket.

Yes sorry I realized it was more relevant to open it there. Thank you


fix: use FreeGlut newest GitHub link

Description of Change

Use FreeGlut newest GitHub link.

This fixes the Windows tests to fail.

Checklist

[x] Added description of change
[ ] ~Added file name matches File name guidelines~
[ ] ~Added tests and example, test must pass~
[ ] ~Added documentation so that the program is self-explanatory and educational - Doxygen guidelines~
[ ] ~Relevant documentation/comments is changed or added~
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

Seems it's now displaying this error. https://github.com/TheAlgorithms/C-Plus-Plus/actions/runs/3551303580/jobs/5965371651#step:4:1241
I've tried various things and tried searching, but nothing worked.


NullReferenceException of KcpTransport when host disconnecting

I have 1 error, when my host just disconnecting
Also, I'm not the only one who got this error. We are the guys from the RUS-help branch, so we know that this is not the first complaint
StackTrace of this error:
NullReferenceException: Object reference not set to an instance of an object
kcp2k.KcpTransport.b__29_3 () (at Assets/Mirror/Transports/KCP/KcpTransport.cs:119)
kcp2k.KcpClient.OnDisconnected () (at Assets/Mirror/Transports/KCP/kcp2k/highlevel/KcpClient.cs:86)
kcp2k.KcpPeer.Disconnect () (at Assets/Mirror/Transports/KCP/kcp2k/highlevel/KcpPeer.cs:743)
kcp2k.KcpTransport.ClientDisconnect () (at Assets/Mirror/Transports/KCP/KcpTransport.cs:178)
Mirror.NetworkClient.Shutdown () (at Assets/Mirror/Core/NetworkClient.cs:1720)
Mirror.NetworkManager.OnClientDisconnectInternal () (at Assets/Mirror/Core/NetworkManager.cs:1306)
Mirror.NetworkClient.OnTransportDisconnected () (at Assets/Mirror/Core/NetworkClient.cs:419)
Mirror.LocalConnectionToServer.Disconnect () (at Assets/Mirror/Core/LocalConnectionToServer.cs:111)
Mirror.NetworkClient.Disconnect () (at Assets/Mirror/Core/NetworkClient.cs:245)
Mirror.NetworkManager.StopClient () (at Assets/Mirror/Core/NetworkManager.cs:672)
Mirror.NetworkManager.StopHost () (at Assets/Mirror/Core/NetworkManager.cs:604)
Mirror.Examples.Chat.ChatUI.ExitButtonOnClick () (at Assets/Mirror/Examples/Chat/Scripts/ChatUI.cs:73)
UnityEngine.Events.InvokableCall.Invoke () (at <4014a86cbefb4944b2b6c9211c8fd2fc>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <4014a86cbefb4944b2b6c9211c8fd2fc>:0)
UnityEngine.UI.Button.Press () (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/UI/Core/Button.cs:70)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/UI/Core/Button.cs:114)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:57)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:272)
UnityEngine.EventSystems.EventSystem:Update() (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/EventSystem.cs:501)
Get this Errror is very sumple:

Start MirrorChat example
Set your name in "User name:" field
Click button "Start Host"
Click cross button in the upper right corner

Desktop:

OS: Windows
Build target: Windows
Unity version: 2021.3.18f1
Mirror branch: master, version 86.13.4

Additional context
Please, fix this.

This has already been fixed in this release.


Dark Mode Issue

Describe your needs
When the system is set into dark mode, the texts in white color are not visible.
Reproduce
Screenshots are shown below:

Expected behavior
A clear and concise description of what you expected to happen.
Please let me know the environment you opened the webpage if possible:

OS: macOS
Browser: Chrome
Version: 130.0.6723.93 (Official Build) (arm64)

I just removed all the dark mode feature
In other words, even though a browser is set to be dark mode, we will not give any dark mode for it.


Option to pass themes directory

Provide a command line option to specify directory for themes. iTerm2 color themes are the best curated, and available for a range of terminals including Alacritty. A command line option to specify path for themes will make life easy (no merge conflicts between that project and this) and open possibility to have other themes: https://github.com/mbadolato/iTerm2-Color-Schemes

@reportaman The feature you've requested has been added!

solved #144


Bar bug by riserrad updated

Describe the bug
Foo issue while doing Bar action.
To Reproduce
Steps to reproduce the behavior, code snippets encouraged
Expected behavior
A clear and concise description of what you expected to happen.
Info (please complete the following information):

SynapseML Version: [e.g. v0.17]
Spark Version [e.g. 2.4.3]
Spark Platform [e.g. Databricks]

** Stacktrace**
Please post the stacktrace here if applicable

If the bug pertains to a specific feature please tag the appropriate CODEOWNER for better visibility
Additional context
Add any other context about the problem here.
AB#1614653

Updating bar issue.

Closing the issue.


Feature/ddns no key

In its current state the module only allows for turning on ddns updates if a key is provided. There are cases where insecure updates may be desired. For example when running isn-dhcp-server along with Microsoft DNS servers. This pull request creates 1 new variable, ddns_updates. If this variable is set then the template will add the ddns configs without the key.

Thanks for the PR.  Could you check the test failures and squash your commits into one?  If you're able to add a test as well, that'd be much appreciated.

Thanks for the feedback. I've pushed the requested changes with the exception of the tests.

@dschaaff thanks for your contribution, even if it took us a long time to merge it.

Thanks for the merge!


how to send token ?

after i complete edit send transaction sol
maybe some one need => here
anyone have example source code send token ?

hey! spl token transfer is not supported yet. we're working on it!


Pick UI

I haven't really found anything new yet, but one day!
"Maybe add the info you've found and links to your requests on an issue in the BoB repo ("pick UI"). Then we can keep track of where things are at, get an MVP up and running for fiftyone that can be like a pre-release installable package to try to simplify use more. We have the UI-dependent code pretty modular, so shouldn't be too much of an issue to adjust it as needed."

Notes on CVAT:

"... figured out how to get CVAT to install where you don't need a CVAT online user name, and one nice thing is they have a rapid annotation interface where you can quicly tag critters with your keyboard by pressing keyboard numbers.  so that's kinda cool. wish that was just built in to fiftyone"

Summary: Good on individual image level, but can't select multiple images.

Notes on challenges/wants from fiftyone:

"it's missing some things that like basic file browsers have (like sorting things in different ways, clicking an individual photo and being able to make changes to its tags)"

I don't think i had a request to 51 i remember, i just sent them an email
Side note: gonna see if we should use patches in 51
https://docs.voxel51.com/user_guide/app.html#viewing-object-patches


chevron to exit roomview after clicking through from search results can disappear

the hitmask in the topleft still works, but there is no icon telling you can click there after viewing history by clicking through from a search result

Done

Validated in 0.3.13 ux_rework #1839


Authentication methods

Current authentication method depends on django sessions. We would probably want (or need) different methods for different scenarios (Web UI, 3rd-party auth). We should discuss what other solution we should implement for that (JWT? OAuth?)

Status: these are some of the ideas that are still being proposed. A few are new

OAuth
OpenID
3rd party associations: depending on associated 3rd-party systems that already have strong authentication methods.

Objective: Determine if we are fine for now with django, or if we should go with another solution.

Research on email verification libraries so we don't implement it ourselves

closed by #452


Update containerd to v2.0.0-beta.2

Update containerd to use v2 package. We can split this out into its own version, but it will be necessary for containerd clients using this package.

4.136 	fuseoverlayfs_test.go:31:2: use of internal package github.com/containerd/containerd/v2/internal/testutil not allowed

Can we expose testutil?

Updated, we don't need to merge with the first RC but I think we should at least get this merged before final since there are some downstream projects such as BuildKit which import this and we want validated to work on 2.0 before cutting final tag.


SignalR client(js) connectionId is always 0, how to match client connectionId with server side connectionId?

From @handsomeyao77 on Tuesday, 26 February 2019 02:05:20
Expected  behavior
Actual behavior
Steps to reproduce
Copied from original issue: SignalR/SignalR#4318

From @halter73 on Tuesday, 26 February 2019 02:33:21
Can you provide the code you are using to read the connection id?

From @handsomeyao77 on Tuesday, 26 February 2019 02:39:44

Print connection object, the id is 2 now, confused...

The new SignalR clients don't expose their connection IDs via public properties. We will consider changing this in 3.0. For now, you can return the caller's connection ID from a hub method as a workaround.

Great! thank you.

We probably want to add a note to our docs that it's easy to impersonate a client given their connection id.

https://github.com/aspnet/AspNetCore/issues/8681 will fix this.


Error: Unhandled Rejection. TypeError: Cannot read property 'attrs' of undefined

I'm getting the following error:
Error: Unhandled Rejection. TypeError: Cannot read property 'attrs' of undefined

I have the latest blc installed. I'm trying to use -ro to check the entire site for broken links and other problems. Here's the command I'm using:
blc http://example.com -rov --filter-level 3 > audit.txt

Am I doing something wrong? Is there an "ignore errors and continue" option?
Thanks

I think I noticed this as well, I didn't add it to a pull request, but I just basically did a grep of the code for '.attr' and whatever object it was trying to reference I wrote an if undefined check for it.  There were only a handful of places where this happened.
if(typeof object !== 'undefined' && typeof object.attrs !== 'undefined') <== like that.

What does the page you're checking look like? I can't imagine a situation where the html property would be undefined.

Sorry, I don't really remember, I just remembered seeing this bug, and that what I described was how I fixed it.  There were several places without that check, so it might have just been the object wasn't passed correctly, or not passed for some validation reason?

I hit in the same issue. I've tried to check the site url https://www.emc.com/en-us/converged-infrastructure/converged-category-page.htm.
Searching for ".attrs" in the projects, I found quite a lot of them from both parse5 and broken-link-checker libs. Did you fix every single line that contains ".attrs"?

Yes, it was a number of places where I fixed it, but I imagine there is only 1 place where it was a problem.  I also kind of feel like this is a little bit of a hack rather than a solution to the problem. Meaning I don't know why attrs is ever not defined.
I wasn't super concerned about it for what I was doing, but I feel like I should note that.

FYI I'm not a maintainer of this project, I'm just following it for updates.

Thank you tyler.
FYI, It seems adding the line if(typeof node.__location !== 'undefined' && typeof node.__location.attrs !== 'undefined') inside this code (under scrapeHtml.js) fix my problem
`		findLinks(rootNode, function(node, attrName, url)
{
if(typeof node.__location !== 'undefined' && typeof node.__location.attrs !== 'undefined') {
link = linkObj(url);
link.html.attrs = node.attrMap;
link.html.attrName = attrName;
link.html.base = preliminaries.base;
link.html.index = links.length;
link.html.location = node.__location.attrs[attrName];
link.html.selector = getSelector(node);
link.html.tag = stringifyNode(node);
link.html.tagName = node.nodeName;
link.html.text = getText(node);
			links.push(link);
		}

	});`

Yeah that's exactly what I did

Just released v0.7.5 which I hope fixes this, but am not entirely sure.

Steven, I just ran into this same issue even with v0.7.5.  Here's a test case which reproduces it:
it("supports more invalid html structure", function()
{
	var html = '<title>title</title>';
	html += '
';
	html += '';

	return wrapper(html).then( function(links)
	{
		expect(links).to.have.length(2);
		expect(links).to.be.like(
		[
			{
				url: { original:"fake1.html" },
				html:
				{
					selector: "html > body > a:nth-child(1)",
					tag: '',
					text: null
				}
			}
		]);
	});
});

The webpage in question was generated by Hugo with HTML like the following:

> A long block quote
> ...
> ...

The key seems to be that trailing  which gets wrapped by Hugo in a

.  The whole thing ends up like

 but in the test case I reduced it to the minimum that reproduces the issue.

@gburgett Thank you. I've reported it to the html parser: https://github.com/inikulin/parse5/issues/197


Improve IDE symbols file

After some discussion in #114, here's a new pull request that simplifies and improves __IDE_SYMBOLS__.php:

Exclude unnecessary methods
Fix definition of facade methods
Simplify indentation

I've only looked through the code so far, this looks like a great improvement! Can you fix the small things I commented on while I test this with different cases?

It looks like this breaks the Facade symbols like \Database::getFacadeAccessor(), can you add that back?

It looks like this breaks the Facade symbols like \Database::getFacadeAccessor(), can you add that back?

I run the previous code and it seems that even before \Database::getFacadeAccessor() wasn't included in the __IDE_SYMBOLS__.php file. I'll digger into it.

Done. Now we have the facade symbols too.

This is a great improvement, thank you @mlocati!

This is a great improvement, thank you @mlocati!

Yes, the life of c5 developers is much easier now :wink:

Okay, so I just now realized why I didn't just extend the classes in the first place.. Each of these methods needs to be defined as static. I just spent some time trying to find the right \Page:: method because most aren't hinted because most aren't static!
@mlocati, do you have any ideas on how to fix this without defining all of the methods? I'm thinking of converting to @method comment declarations but the PHP tools for modifying comments aren't great so it might be a little bit of work.

@KorvinSzanto for me everything is working perfectly, both aliased classes (like the \Page you mention) and facades (eg \Config).
What do you have in your web/concrete/src/Support/__IDE_SYMBOLS__.php file for the \Page class? Here's what I have:
namespace {
    // ....
    class Page extends \Concrete\Core\Page\Page
    {
    }
    // ....
}

And here's how my IDE (Eclipse + PDT) correctly analyzes the above file and shows a perfect content-assistant behaviour:

You're right, I was mistaken. I just started looking at c5 again after a long time spent on other languages and thought that \Page was a facade for the current page. heh

:ok_hand: :man: :wink:


pub tests can prematurely kill pub process, before stdout/stderr is written

See in
  test/transformer/fails_to_load_a_transform_from_a_non_dependency_test
  test/serve/warns_on_assets_paths_test
Note that this is with https://codereview.chromium.org/154273003 landed, where stdout/stderr is _really_ async (stdout/stderr ordering is gone).

This issue has been moved to dart-lang/pub#863.


Update very old WebSockets docs

These docs were from a different era, and cause confusion because they are too ambiguous

@crwaters16 please don’t merge my PRs for me, this one needs @mbullock1986 eyes first

@irvinebroque my bad, thought it was good to go. Reopened!


Stratum issues jobs with duplicate parameters

Please check the job notifications issued by the stratum bridge below:
{"id":62,"jsonrpc":"2.0","method":"mining.notify","params":["62",[15604478400006665393,2592967033325415742,10413135228885277442,11269599133057201715],1672059914734]}
{"id":63,"jsonrpc":"2.0","method":"mining.notify","params":["63",[16578474972821552337,17213180243900769866,7306160775762497761,9054546872483894304],1672059915394]}
{"id":64,"jsonrpc":"2.0","method":"mining.notify","params":["64",[16578474972821552337,17213180243900769866,7306160775762497761,9054546872483894304],1672059915394]}
{"id":65,"jsonrpc":"2.0","method":"mining.notify","params":["65",[16578474972821552337,17213180243900769866,7306160775762497761,9054546872483894304],1672059915394]}
{"id":66,"jsonrpc":"2.0","method":"mining.notify","params":["66",[9070814126194077586,14984937806721001483,6603419268963942151,159322175741956520],1672059916547]}

as you can see the jobs 63, 64, and 65 have different IDs but their header hashes and timestamps are identical. This is causing a mining client to submit duplicate shares (they get marked as "stl" in the stratum UI) because it resets the nonce counter to 0 for every new job it receives.
Is this a bug or am I missing something? Thank you.

The block template callback from the kaspad node resends the same data periodically. I'll add a check for this in the next version


Webview working fine for all URL's. But, In my case I have a URL for Conference call. The Call should be view on Webview

I have to build the feature for conference call on Webview mode and I complete it. It is working for all other web URL's.
Here is my Webview code for your reference:
      <WebView         source={source}         style={style}         renderLoading={() => this.renderLoadingIndicator()}         renderError={(errorName) => this.renderErrorMessage(errorName)}         startInLoadingState={startInLoadingState}         userAgent={userAgent}         onNavigationStateChange={({ url }) => onNavigationStateChange(url)}         ref={(ref) => {           this.webView = ref;         }}         onError={(event) => onError(event.nativeEvent)}         injectedJavaScript={injectedJavaScript}         onMessage={onMessage}         allowsFullscreenVideo={allowsFullscreenVideo}         allowsInlineMediaPlayback={allowsInlineMediaPlayback}       />
So, guys, this is my code. I have tried a lot of URLs in the source field. But, when I use my conference call URl for the source, It is working on Android perfectly and also It should work on IOS. Unfortunately, IOS Webview is loaded but the screen shows as empty.
I don't know if I have made any small mistake. If the question is wrong, just ping me. So that I can alter the question perfectly.
Androis screenshot:

IOS Screenshot:

Try adding sharedCookiesEnabled={true} in the webview tag, this worked for me.


[CMake] Replace APPLE with CMAKE_HOST_APPLE

In CMake APPLE is defined if you are targeting an Apple platform (or at least if CMake thinks you are). If your host is an Apple platform CMake defines CMAKE_HOST_APPLE.
Swift's build system is rolling its own cross-compiling support, so checks such as APPLE do not function properly, and instead are true when the host is APPLE. To make that fact explicit, change these variables to CMAKE_HOST_APPLE.
Addresses a comment by @llvm-beanz on https://github.com/apple/swift/pull/5160#issuecomment-252983869.

I don't think this is correct. We don't care about the system SourceKit is being built on; we care about where it will be run.

@jrose-apple is right on these checks. These if(APPLE) checks are actually checking for the target being Apple platforms. Sadly that means that these checks would go awry with the swift-rolled cross compiling if you are on a Mac targeting Android (or any other non-Apple platform).
You may need to feed an SDK check in through here.

An SDK check isn't correct either—there may be up to three systems here:

"build" (what CMake calls "host"): the system where CMake is being run and where the compilation is happening
"host": the system where the Swift compiler and SourceKit and such will be run
"target": the system where the Swift code you compile will be run

Obviously if "build" and "host" are different then you can't build any target libraries in this compilation (at least without using some kind of "native tools", which we do have a setting for), but that may be okay.

I'll close this for now, in favor of a broader approach (hopefully) coming soon.


wip

This prevents unnecessary cache miss for prerendered flight response.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#363  👈
#357 : 1 other dependent PR (#358 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite

Merge activity

Jun 7, 2:21 AM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.


[bug] types are not enforced in child scopes

Snippet Responsible
a = 5

if true {
	a = "world"
}

print typeof a # "int"
print        a # "world"

Stack Trace of Error
[ Trace ] INIT Virtual Stack at MODULE
[ Debug ] pre-walk "ghmscript.ms"
[ Debug ] registering new file "ghmscript.ms" (File { declarations: RefCell { value: [] }, location: "ghmscript.mmm", exports: RefCell { value: [] }, public_types: RefCell { value: {} }, compiled: CompilationLock(Cell { value: false }) }) -- Adding to: []
[ Trace ] Gen. mod "ghmscript.ms" -- skipping if_statement
[ Trace ] Gen. mod "ghmscript.ms" -- skipping print_statement
[ Trace ] Gen. mod "ghmscript.ms" -- skipping print_statement
[ Info ] DONE preloading module ghmscript.ms
[ Info ] + mod "ghmscript.ms" ModuleType { exported_members: RefCell { value: [] }, public_types: RefCell { value: {} }, name: "ghmscript.ms" }
[ Info ] + finished preload of "ghmscript.ms"
[ Trace ] + a: int
[ Trace ] Virtual Stack PUSH: If Block -> No
[ Trace ] + a: str
[ Trace ] Virtual Stack POP
[ Trace ] Added compilation step: "ghmscript.ms"
[ Debug ] [cc] FINAL COMPILATION LIST: ["ghmscript.ms"]
[ Info ] checking validation of `"ghmscript.ms"`: completed
[ Info ] [cc] @ ghmscript.mmm
[ Trace ] reg. -n--- 0
[ Trace ] reg. -n--- 0
[ Trace ] reg. -n--- 0
Compiled in 3.5359ms

[ Trace ] [BLDR ADD_FN @ ghmscript.mmm] `__module__`
Running...

[ Info ] Loading instructions from file...
[ Info ] Loaded instructions from file
[ Info ] Synced module cache with the entrypoint
[ Trace ] Creating call stack...
[ Trace ] Created call stack
[ Debug ] Spawning interpreter...
[ Trace ] Stack ++PUSH ghmscript.mmm#__module__
[ Trace ] Stack ++PUSH <if>
[ Trace ] DONE & POP
[ Trace ] PopScope `If` at 6
[ Trace ] Stack --POP <if>
[ Warning ] The `printn` instruction should not be used. Favor the standard library instead.
int
[ Warning ] The `printn` instruction should not be used. Favor the standard library instead.
world
[ Trace ] Stack --POP ghmscript.mmm#__module__
[ Info ] Program exited succesfully

Expected Behavior
Raise a Type Mismatch error in the if statement's scope, because str is not compatible with int in this context.
Any ideas where MScript breaks?

[ ] Bytecode Interpreter
[X] Compiler
[ ] Optimizer
[ ] Not Sure (It's okay!)
[ ] Other: please explain

Brain Dump (Optional)
It amuses me how the simplest of bugs made it through testing this long.

Additional bypasses include:

Closure capture modification via the modify keyword
Shadowing a variable name in an outside scope via assignment unpacking
(untested) Shadowing a variable in a from iteration context.


dosent work

when I do this script change size png but dont execute my file (exe or bat)

Program straight up doesn't actually work, period.


Dark mode not properly picked up on autostart

Running 0.24 on MX Linux (XFCE 4.12.3), 64-bit fully up to date, Spanish language interface.
How to reproduce:
With dark mode set:

Set tomboy-ng to autostart from the XFCE configurations (adds "Notas tomboy-ng.desktop" to ~/.config/autostart) [The name of the .desktop file gets translated?!?]
Close session / reboot
Sign in

Expected behaviour: Tomboy starts in dark mode, i.e., splash appears with dark theme
Actual behaviour: Tomboy starts with a mix of light and dark modes. Splash has "Do not show at startup" in white and almost white. Opening the Search form the notes and filter panes are white with black text, other elements dark with white text. This applies whether starting from the Splash or the systray. Note that the systray popup appears in dark mode. This behaviour holds across three dark themes tested.
If tomboy-ng is exited and started manually (menu, Alt+F2), it behaves as expected.
tomboy-ng 0.24 running on Mageia with Enlightenment DE behaves as expected on autostart, no matter if it is first or last in order of execution (which can be controlled with E!).
I suspect that this is an XFCE issue, but it seemed worth reporting. It seems strange that the splash should appear (usually) just before the DM screen has disappeared. Being able to delay exec may work, but I do not see how to accomplish this in XFCE. I have played around trying to delay by adding "-p XXs" to the autostart (as here https://forum.manjaro.org/t/xfce-how-to-add-an-autostart-delay-to-a-program/6961/3) to no avail (tomboy-ng starts and quits after XXs!).
David, if you or anyone else can suggest a way to delay startup, I will give it a try.
I would also be interested to know if other users can reproduce this behaviour.

Thats an interesting one !  As you suggest, it looks to me that XFCe is starting tomboy-ng beforethe Desktop is ready to tell tomboy-ng all the colours it should use.
We can test that by have XFCe start a script that starts tomboy, perhaps after 5s
#!/usr/bin/bash
sleep 5s
tomboy-ng
Hmm, what else ?  The command line switch --dark-theme is windows only, as Linux apps get all that info from the desktop, would seem a bad idea to manually override it.
I don't think I can build in an optional slow start, because Lazarus is all about its GUI, the opening window is the first thing it does.
Davo

Yes, even a 1s delay allows the theme to be picked up. (With 1s the tomboy-ng splash still appears just ahead of the wallpaper, but with the theme.)
For autostarting via -ng settings, perhaps it is possible to add a delay in the cfg file via settings?
It is too bad that the "-p XXs" added to the XFCE autostart does not work. I suppose that the delay could be added to the .desktop file https://www.tomi.cat/2016/02/solucio-la-icona-de-megasync-que-no-es.html, but I don't know how you could control that from your end.

OK, I have added a command line switch, --delay-start, that waits 2 seconds before it proceeds to load all the other forms.  So, for now, that does involve editing the startup desktop file.  If this seems a good idea, I think I could make that the default behaviour when being autostarted.
Davo

Will test it out when I have time. I still have XFCE 4.12 so it will be interesting to compare than and the update to 4.14. I may see if I can test in Mageia XFCE as well. I find it weird that ng should load even before the the DM screen has been changed to the DE.

any further thoughts on this topic ?

At the moment no. I just tested with 0.27 and the same: the delay-start switch does not seem to allow the theme to be picked up even though testing in a normal start there is an delay. The only thing that works with MX Linux 18.3 is the separate bash script to delay autostart. No idea why. When I get around to MX Linx 19 will test again. I think this is just a hopeless quirk with either MX or at least the version I am running.

OK, that surprises me. I guess we'll need to rely on the script model.
I'll make a note of that on "Known Issues" .......

We will have to mark this one "unfixable".

I know this is closed, but just to close the loop: after updating to MX Linux 19 with XFCE 14.4, this issue went away. Dark theme now properly picked up on autostart with no delay needed.

OK, I will remove that delay code in that case, its ugly and, as it is at present, untested !
I have a totally new startup model for 0.29, an all command line unit that processes command line switches. It has that delay there, before any GUI components are loaded. I expect it would work but if not needed, its messy and should go !
Thanks.


improving balance section

this solves issue #252

@abstract829
1.- Token number (#) is currently reset to 1 every time you pass from page 1 to 2, etc...
2.- Please add a field where user can choose how many tokens to show in one page. Options: 5, 10, 20, 100

@esteblock done


CONNECT and HTTP Proxy

I tried to setup a server with .connect("/") endpoint, to support HTTPS proxy. I dont think it works at all though, and I'm not even sure that method in the library is supposed to do that.
I'm building an app that requires capturing CONNECT event, so I'm curious to know if there is an easy enough way (in other words, having an api on HTTP level).
Because of the passthrough nature of the server, it is particularly important to have high performance, so I'm inclined to choose uWebSockets.
Here's my starting point :
   auto app = uWS::App({
        "",
        "",
    }).connect("/", [](auto *res, auto *req) {
        // When a client connects to the HTTP proxy server. It should answer 200 OK.
        LOG(INFO) << "CONNECT";
        res->writeStatus("200 OK")->end();
    }).get("/", [](auto *res, auto *req) {
        // When a client connects to the HTTP proxy server. It should answer 200 OK.
        LOG(INFO) << "GET";
        res->writeStatus("200 OK")->end("Hello World!");
});

Get on localhost:8080 logs GET, get on google with HTTP/HTTPS proxy set to localhost:8080 doesnt log CONNECT (though, it does sends CONNECT according to Wireshark).
Is this feature lacking ? Or is it simply too high level of a library (I know CONNECT is a bit inbetween HTTP and plain TCP connection)
Thanks for clarifying

https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/CONNECT
That's probably a lack in the Http router, we probably only support simple URLs, not "www.example.com:443" kind of lines.
We could definitely make the router more generic, but I think you will have better luck with a proper proxy project instead of uWS. Proxying is not really a considered case for uWS. We don't even have client support, at all.

I marked this as out of scope, but the Http router fix itself is probably in-scope. So we can keep this issue open. Http router needs a rewrite at some point anyways.

Do people expect something like this:
GET https://google.com/test/yes
to be matching with app.get("/test/yes", ..)
and have something like req.getBaseURL() to return "https://google.com"
? Or how does Express do it?

probably better to use parameter routes to catch the domain like so:
app.get("/:domain/test/yes", ..)
or
app.get("/:domain/*", ..) and use req.getWildcard() for the local URL


missing field items

Hello,
Love the idea and look forward to using this.
I am getting the following error when trying to run gh-stack annotate:
bash-3.2$ gh-stack annotate "feature"
Error: reqwest::Error { kind: Decode, source: Error("missing field `items`", line: 1, column: 80) }

I don't know a ton about rust but looks like a request is returning an invalid response.
Thanks!

Were you able to successfully use the app? I tried setting the gh token using a variety of methods and did not have much luck.

Yup I was @aschade92 .
Once I made certain to copy my token exactly as GH displayed it everything worked fine.
Out of curiosity, are you building the app from source or using the one on cargo? Also, what's the expiry date on your token?

I'm getting a similar error, except it's Error("missing field `id`"
I know the token is valid because the request below works fine...
curl \
  -H "Accept: application/vnd.github.v3+json" \
  -H "Authorization: token $GHSTACK_OAUTH_TOKEN" \
  'https://api.github.com/search/issues?q="foo"%20in:title,body'

I'm getting a similar error, except it's Error("missing field `id`"
I know the token is valid...

You're 💯 right @p3drosola .
The issue stems from the search endpoint being used.
https://github.com/timothyandrew/gh-stack/blob/d6aa8192ed4cf905826abb2ab97c51b8aaaafa4c/src/api/search.rs#L45
This endpoint searches across all GH repos. Therefore, if your identifier, i.e. [f1] isn't unique enough. The response JSON, which is limited to 30 results atm I believe, will include irrelevant results and might not include your PRs at all. Often, the PRs list that is generated won't allow you to annotate or rebase since your token doesn't have read/write permissions on that repo.
To solve this use PR identifiers with more unique names, i.e. [username-f1]. That way you can run gh-stack annotate 'username-f1' and it should work.

@luqven yeah I noticed that as well after a bit more testing. I was thinking of opening a PR with a --repo flag that would add that filter to the search.. what do you think?
Thanks for your work on this mate, It's already helping my out :)

@p3drosola I can't take any credit. I've just been hacking some features on top of all the great work here.
I added a '--repo' in my fork 😜, https://github.com/luqven/gh-stack So feel free to use/PR there. Idk if PRs are being accepted here at the moment.

I've got the problem that the following successfully finds my PRs tagged with foo
curl \
  -H "Accept: application/vnd.github.v3+json" \
  -H "Authorization: token $GHSTACK_OAUTH_TOKEN" \
  'https://api.github.com/search/issues?q="foo"%20in:title,body'

but running gh-stack annotate 'foo' results in
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Decode, source: Error("invalid type: null, expected a string", line: 1, column: 1643) }', /Users/allyson/.cargo/registry/src/github.com-1ecc6299db9ec823/gh-stack-0.1.6/src/api/search.rs:115:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Has anyone encountered this?


escape regex characters in duty station highlight library

Description
An accidental entering of non alphanumeric characters in the duty station input search would cause an unexpected Something went wrong error in the client.
It turns out we have a library react-highlighter-words that attempts to highlight the search string in the menu of results.  If you type any special character that has meaning in regular expressions -][)(*+?.\^$| it will cause the component to throw an error.
To fix this we just need to set the autoEscape prop to true on the Highlighter component that we're using.
https://github.com/bvaughn/react-highlight-words#props
https://github.com/bvaughn/highlight-words-core/blob/eb170f8a78c7926b613e72733267f3243696113c/src/utils.js#L172
Reviewer Notes
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make client_run

On the Customer side:

Login as an existing service member
Edit the profile where it asks for current duty station
Click in the current duty station searchbox and enter 2 or more of the special characters
A No Options message should be displayed or some fuzzy matched results but no Something went wrong error.

On the office side:

Login as the TOO user and select a move from the queue
Navigate to the Edit Orders screen on the Move Details page
Edit either the origin duty station or the destination duty station by entering 2 or more of the special characters
A No Options message should be displayed or some fuzzy matched results but no Something went wrong error.

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 8baa2c977a030dcacec815869fdca3856a254c00


Add "mobile_settings" flag to subreddit get

This will cause the API response to include key color, banner, and thumbnail images for subreddit get.
:eyeglasses: @schwers

:fish:


GH-33206: [C++] Add support for StructArray sorting and nested sort keys

Rationale for this change
We don't currently support sorting StructArrays despite already having the high-level facilities to do so. For instance, we allow passing multiple sort keys (based on FieldRefs) to sort record batches and tables - but the current implementations are fairly limited since nested refs aren't allowed (due to the burden of null flattening). Since https://github.com/apache/arrow/pull/35197, we now have an easier way to do this.
What changes are included in this PR?

Adds support for StructArray in sort_indices
Adds support for nested sort keys in sort_indices for RecordBatch, ChunkedArray, and Table

Are these changes tested?
Yes (tests are included)
Are there any user-facing changes?
Yes

Closes: #33206

Note that this doesn't currently extend nested key support to rank and selectk, but that would be a logical next step.

@pitrou Sorry, I pushed changes to this but forgot to re-ping...
There are a few things that could probably be tweaked still, but I wanted to get an opinion on the general approach here first (regarding sorting by entire struct fields).


expr should support returns of (Value, evaluated, error)

Currently the expression Walk logic, and context.Get() are not consistent with respect to:

some return nil, true for could not be evaluated, some ErrValue, false, some return NilValue, false

TODO:

[ ] Find a test suite from another logic/script language

not sure about this anymore, closing and will bring back if need be.


Moved 'FILES' to last position from 'FILES*' vars

Found a failed test in this job, this modification fixes it.

LGTM.


Session handler design

Calling makeGuzzle is expensive, and should only be done once. Can we refactor the session config to not call it again?

Related to https://github.com/bugsnag/bugsnag-php/pull/521.