[breaking change] Extend function definition with "throws exception"

Change Intent
Enable an optional way for communicating that exceptions can happen by extending the function definition with the phrase "throws exception":
// Signaling that this function might throw an exception.
// Tooltips in IDEs coudl be extended to highlight this.
void myFunc() throws exception {
    throw Exception("something went wrong");
}

Currently:
void myFunc() { //no signaling whatsoever that this function might throw an exception
    throw Exception("something went wrong");
}

An IDE might propose a Quick-Fix when "throws exception" is not present in the function definition although the function might throw an exception.
(Though I personally prefer the sound of "raises exception" but "throws exception" is probably better suited since the keyword throw is used in the dart language.)
Justification
Without any digging there is no way of knowing whether a function might throw an error or not. Having (1) a program running unexpectedly into an error or (2) encapsule "just in case" everything in a try-catch block and say "sorry, an unexpected error has occured" is fatal in the first case and is at least no good practice in the second case.
Especially for new programmers or even experienced ones using new packages this would be really helpful.
Impact
Anyone could see at a glance if a function might throw an exception. Having this information would massively improve stability and usabilty of programs in general. Making this feature optional also means that any progammer can decide to use it. I would suggest to make the IDE point out a missing "throws exception" and offer a quick fix.
Mitigation
No response
Change Timeline
No response
Associated CLs
No response

Duplicate of https://github.com/dart-lang/language/issues/984

This would only work for exceptions, not Errors, since every function might throw an error (if you include StackOverflowError). So the syntax is fitting, if verbose. Just throws would be enough.
That's also a problem. Knowing that a function may throw an exception does not tell you which reception it throws.
You're discouraged from just catching Exception, since the purpose of exceptions is to be caught and handled, and you can't properly handle an exception if you don't know what it represents.
Satisfying a throws by catching the wrong exception doesn't actually provide any safety.
All in all, Java-stole "checked exceptions" has been suggested before (fx #984). It's unlikely that Dart will go that way, for the same reasons that no post-Java language has cooled that particular feature. It's not worth the overhead it causes.

I read through the mentioned issues and I agree that it may not become a feature of the dart language. But the issue remains. Is there some work going on to adress it? If not maybe at least some smaller things could be done? https://github.com/dart-lang/linter/issues/2246#issuecomment-2426292063


Begins Refactor of SDNBridge test to be used in Nat/Overlay

run tests

run tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests

rerun tests


Add poem framework support

Poem has a feature to support tower layer and services. Therefore it should be possible to add socketioxide to any poem application.
If no additional development is needed, we could just add an example with poem.

Some additional development is needed because the poem layer / service adapter only work with poem custom Request Response type

Currently Poem does not support layers and services with a http Request bound.
https://github.com/poem-web/poem/issues/536
https://github.com/poem-web/poem/issues/387


remove warning in jvm buildpack, deprecation of version field

The JVM buildpack currently is using an old Buildpack API with the Build Plan:
===> DETECTING
Warning: Warning: buildpack heroku/jvm has a "version" key. This key is deprecated in build plan requirements in buildpack API 0.3. "metadata.version" should be used instead

This PR fixes this and uses the new format.

Thanks @hone!


_.isNumber( NaN ) == true

Why _.isNumber( NaN ) == true ?

Hi @judsonbsilva!
_.isNumber( NaN ) is true because NaN is classified as a number just as Infinity and -Infinity are.
The _.isNumber method is not intended for numeric validation just as _.isDate will not validate whether you date object is valid new Date(Infinity).
If you're looking for validation there's _.isFinite or ES6 Number.isFinite, Number.isNaN, Number.isInteger, and Number.isSafeInteger.

:) Ohh... nice, thank's

Can this explanation go in the documentation?  We get this question in some form quite frequently.


Fixed dates moved by one day(#123)

also #121

I didn't realize that this is reflected in 1.14.0.
include the issue that moving day by one even though English mode.


Add noqa F401 check exception for typing line.

This enables F401 check to be run again.

@rht is this all we'll need to change to enable that rule, or are there a lot more?
If F401 is unused imports, the right path forward there is to be using the typing imports by using the Python 3 fancy syntax for type annotations.  We'll want to use a 2to3 type tool to rewrite them.

There are a lot lot more. The 2 are sample commits. I will proceed with the rest of the files, atomically, if you think this is the correct path to tread.
AFAIR, the fancy syntax for type annotation is not available by default in 14.04 (and 14.04 is based on Debian 8, lt-supported until 2020 [1]) unless python3.5 is installed.
[1] https://github.com/zulip/zulip/pull/5835#issuecomment-316288078

To check for F401, while dealing with the typing issue.
Either:

Restrict the Python version to be at least 3.5, then use the new type annotation syntax :>
Add # noqa: F401 to each typing

Can't we just filter the output for the typing items?  That seems a lot cleaner than the second option, and to have fewer dependencies than the first option.

That will not do, since some unused imports that are not from typing might sometimes be used for type annotation. I can't think of any regex pattern to filter them out.
Running flake8 . | grep F401 | grep -v typing | wc -l results in 1163 lines. And there are 1347 F401 errs due to typing.
(I interpret 'a lot cleaner' to be having far less manual human intervention in patching the code)

Ahh, yes.  Given that, I think we should take the "move to Python 3 syntax" approach.

We should look into whether there's a good PPA from which we could get Python 3.5 on Trusty.

There are two options so far:

https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa
figure out how Travis uses a 3.5 venv in 14.04

Travis is unlikely to be a useful lead, since I bet it's all custom.
-Tim Abbott (mobile)
On Sep 24, 2017 6:26 AM, "rht"<EMAIL_ADDRESS>wrote:

There are two options so far:

https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa
https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa
figure out how Travis uses a 3.5 venv in 14.04

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/6644#issuecomment-331709893, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACnm2j6e1zQaqU4zns0oHW1vIa6xV4U7ks5sllh2gaJpZM4Phhk9
.

How the Python install is done in Travis, using a tarball: https://travis-ci.org/zulip/zulip/jobs/278922729#L415-L417. There is no evidence that the tarball is customized for Travis' case.

Right, that's what I mean: Travis has a set of tarballs that they use.  We could do that, but probably we'd want to make sure we're distributing the latest/secure version of it, which Travis probably doesn't super care about it.
I worry a little about https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa being not a great choice from a security standpoint.
CCing @gnprice, since I think this is basically the question of whether we can move to using the new mypy syntax.  It's possible we should just desupport trusty in the 1.8 release as the path to that goal; it would also eliminate our need to support old postgres.  Though I'm not sure Travis supports Xenial yet.  I'll email their support about that.  And then we might want to move this to a proper issue on changing the mypy syntax; I'll open it.
In the meantime, I think we should try looking a bit more closely at the unused imports you get after removing typing.  It's possible that we can enable F401 for most modules with a filter for the typing module and have a good experience.  Can you try (1) adding that filtering rule for typing and then (2) running the linter against zerver/views.py, and seeing how many of the unused imports are due to typing vs. just totally unused?  I think it's possible that most of them will be a few more specific items we can filter (e.g. HttpRequest, HttpResponse) and the rest will be things we actually want to remove.

I opened https://github.com/zulip/zulip/issues/6780 to track the typing syntax problem.  I'm going to close this PR; @rht feel free to open a new one using the strategy I suggested as the end of my next message.

We should move to the Python 3 syntax -- as I replied on #6780, that works fine on Python 3.4.
At Dropbox, where that wasn't a near- or medium-term option because we had a very large codebase on Python 2.7, we addressed this problem with a clever hack -- we patched the linter to preprocess each file by parsing out type annotations, and adding dummy uses of all the mentioned names at the end of the module. So e.g.
def f(xs):
  # type: (List[int]) -> None
  ...

would result in a line like
List = List

(or something like that) being appended to the module, just within the linter.
That worked pretty well. But I think for our purposes it may not be worth doing that before we just switch to the new syntax.

Also I agree with @timabbott's suggested strategy at the end of his last long comment. That should be quick to try, and if it works it'll be well worth doing.


Fix terminate called after throwing an instance of 'std::system_error' what():  Resource deadlock avoided

Garbage collection of TaskHandleFloat32 and TaskHandleFloat64 without call to .wait() results in following error:
terminate called after throwing an instance of 'std::system_error'
  what():  Resource deadlock avoided
Fatal Python error: Aborted

Will be resolved after merging #27


Side effects after removing Drush launcher

https://github.com/uselagoon/lagoon-images/pull/877 has removed Drush Launcher and added
ENV PATH="/app/vendor/bin:/home/.composer/vendor/bin:$PATH"

This made any bins located in /app/vendor/bin to take precedence over any other system commands with the same name.
For example, when using druidfi/gdpr-mysqldump, it provides mysqldump command. After this change any calls to mysqldump will be using /app/vendor/bin/mysqldump instead of system's mysqldump.
The problem gets worse when a developer has no control over which system binary to use: in this specific case, Lagoon tasks are using mysqldump command (which actually uses /app/vendor/bin/mysqldump) with a flag --no-tablespaces that is not supported by druidfi/gdpr-mysqldump's mysqldump leading to errors. And the developer cannot change that in Lagoon tasks.
I'm wondering if there is a better way to solve this by, potentially, only including drush's location in the PATH.

Would switching the order be an easy fix? That should just mean that any binary not in the existing PATH will be searched in the vendor dir - which should fix your issue?
ENV PATH="$PATH:/app/vendor/bin:/home/.composer/vendor/bin"
Tightly scoping it to the drush binary is also doable, but you might miss out on CLI access to the other composer-loaded binaries without adding a path override yourself?

@tobybellwood
Thank you for a rapid response
ENV PATH="$PATH:/app/vendor/bin:/home/.composer/vendor/bin" sounds like a good solution.
Does it mean that I can put this into my Dockerfile (based on these images) to override or this change needs to take place in base images?

I don't think it'll work in your images, as they will inherit the upstream path, and just append to that.
You can, however, probably override the entire PATH variable until we merge the fix in this month's release?
ENV PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/app/vendor/bin:/home/.composer/vendor/bin"


Initialize is called after fetch for Model.collection

Given the example:
var knex = require('knex')({client: 'sqlite3', connection: { filename: ':memory:' } });
var bookshelf = require('bookshelf')(knex);

var User = bookshelf.Model.extend({
  tableName: 'users',
  initialize() {
    console.log('initialize()');
    this.on('fetched', () => console.log('\tfetched()'));
  },
});

knex.schema.createTable('users',  ( table ) => {
  table.integer('id');
})
.then(() => {
  return knex('users').insert({
    id: 1,
  });
})
.then(() => {
  return User.where('id', 1).fetch()
  .then((user) => {
    console.log('\tFETCHED WAS CALLED')
  });
})
.then(() => {
  console.log('=============')
  return User.collection().query((qb) => {
    qb.whereIn('id', 1)
  }).fetch()
  .then((user) => {
    console.log('\tFETCHED WAS NOT CALLED')
  });
})
.catch((err) => {
  console.error(err);
})
.finally(() => {
  process.exit();
})

And a package.json:
{
  "name": "bookshelf-bug",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "bookshelf": "^0.9.1",
    "knex": "^0.9.0",
    "sqlite3": "^3.1.1"
  }
}

I get the following output:
initialize()
	fetched()
	FETCHED WAS CALLED
=============
initialize()
	FETCHED WAS NOT CALLED

This is because initialise is only called on the models after the fetched event has already fired, so the event handler does not exist.
Is this the expected behaviour? Is there an earlier callback in which I can add the .on handler?

// Attach listener to `Collection` instance.
User.collection().on('fetched', callback).fetch()

// Listen for collection fetched event.
User.on('fetched:collection', callback).fetchAll();

Closing due to lack of activity. If you have anything else to add we can reopen this issue.


feat(styles): add --tui-skeleton-radius for skeleton

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

Closes #
What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@nsbarsukov @vladimirpotekhin please review me


Adding test cases to search_dataset() and search_granule() functions

This PR adds test cases for the functions search_dataset() and search_granule() functions in podaac.py file.
This PR hopefully increases the code coverage.

Coverage increased (+4.3%) to 92.355% when pulling 0473372fbf48d54a6253bd08b539c6212875b3c8 on Omkar20895:master into e2d9150615df6821307dc2f031221a7356781d04 on lewismc:master.

All test cases have run OK and the code coverage also increased. Merging this PR. Thanks :)

Thanks
On Thursday, June 16, 2016, Omkar<EMAIL_ADDRESS>wrote:

Merged #27 https://github.com/lewismc/podaacpy/pull/27.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lewismc/podaacpy/pull/27#event-694707614, or mute
the thread
https://github.com/notifications/unsubscribe/ABHJl5CvFh9VTjY4lYEcLIf19fTX6-Oeks5qMV2PgaJpZM4I3cAs
.

--
Lewis


[116] - Cache the dttp access token

Context

https://trello.com/c/a8iszbjM/116-m-add-token-cacheing-to-dttpaccesstokenservice

Changes proposed in this pull request

Activate :file_store as the cache store for dev and prod
Wrap the network request in a Rails.cache so it's only fired if there's a cache miss.

Guidance to review

Run bundle exec {rails|rake} dev:cache locally to enable caching in developmnent. This will create a file tmp/caching-dev.txt which Rails uses to toggle caching on/off for development.
 Fire the command again and it should return the same token

Make sure you run bundle exec {rails|rake} dev:cache to turn off the dev caching locally when finished. I've tested the expiry when using :file_store. A binary file is created and used to update/reset the cache based on the time set with expire_in.

 [M] Add token cacheing to DttpAccessTokenService


Inconsistent naming and renaming when import of operators and functions and algorithms

Looking at __init__.py of operators, we can see that most operators have Operator as the last bit of their name, so this seems to be the convention. However a few don't:
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L23
and
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L31
Further, when importing some of the operators that do end with Operator but have somewhat long names have their Operator stripped off:
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L26
and
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L27
and
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L28
and
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L29
but not all, for example
https://github.com/vais-ral/CCPi-Framework/blob/bda2d10dba75433904f5025cd230095611f6cdef/Wrappers/Python/ccpi/optimisation/operators/__init__.py#L30
keeps the Operator probably since Zero would not be meaningful. However this is inconsistent, and it makes it difficult to refer to these operators - should they be referred to as for example Identity or IdentityOperator?  My preference would be to consistently use the longer name including Operator but open to discuss.

I believe we could avoid the name Operator in each class. At the end they are all in the operators module.

Decision:
Keep Operator for building blocks like Operator LinearOperator etc and remove it concrete classes.
The others can be imported directly and have reference to their module:

from ccpi.optimisation.operators import Identity

Also add to Function:
Rename:
*. SumFunctionScalar -> SumScalarFunction
*. ConstantFunction -> Constant
*. ZeroFunction -> Zero
*. FunctionOperatorComposition -> OperatorCompositionFunction
Add SumFunction in ccpi/optimisation/functions/__init__.py

For algorithms rename GradientDescent -> GD.

Decision:
Keep Operator for building blocks like Operator LinearOperator etc and remove it concrete classes.
The others can be imported directly and have reference to their module:
from ccpi.optimisation.operators import Identity

Reverting the decision together with @jakobsj @gfardell @epapoutsellis @evelinaametova : concrete operator classes to keep Operator at the end. This means that we just need to rename

LinearOperatorMatrix -> MatrixOperator
SparseFiniteDiff -> SparseFiniteDifferenceOperator (which requires some updates)

Since we are going to rename to SparseFiniteDifferenceOperator,  we need also to have FiniteDifferenceOperator instead of FiniteDiff.

missing from renaming Identity, Gradient and SymmetrisedGradient. Post-fix Operator.

missing from renaming Identity, Gradient and SymmetrisedGradient. Post-fix Operator.

#686 closes this I believe

closed by #686
and opening a new specific issue for Functions renaming


Check if adding ovulation updates statistics

Add ovulation to a month
(do not switch months!)
Check statistics if ovulation is included
(I had issue where I added one ovulation, switched month and added another ovulation, went directly to the stats but it only showed one ovulation. When I switched month and went to statistics again it showed 2)
Check that adding ovulation updates the statistics in the code

Added updateStatistics() when ovulationDate has been entered.


Dscanner ignoring config file

HEAD seems to be ignoring config file, additionally the config file it outputs is entirely empty except the first line. doesn't happen in the 0.2.0 release tag.
OS: Arch Linux x86_64

To add to this the only line it writes contains this:

[analysis.config.StaticAnalysisConfig]

OS Linux Mint x86_64


[Feature requests ] Various recording (GUI) requests

Hello there,
I have been using the application "in the field" for a bit now, with great success. Longest run time I had was 27 hours, and that one got stopped because the mobile ISP decided that I needed a new IP in the middle of the night. Running another 24h+ session now.
I would like to ask for the following features:
1. Delete recordings confirmation prompt.
It unfortunally has happened that me or someone else deleted a recording accidently, mostly after there was some delay at pressing the trash can button and the delete happening of the actual recording which was meant to delete (due to remote connection). Unfortunally a day of counter data now has been lost due to this. I would like to see some protection like an (optional) confirmation prompt to prevent accidental deletes.
2. The ability to name recordings
Right now, the programme seems to generate a random recording name. I would like to see it possible to name the recording. Even better would be if I can make a standardised recording name, and the programme adds a datetime to it to give an example.
3. The ability to resume recordings
Due to various reasons I had to stop a recording and start with a new one (crashes, IP change, accidently pulling the plug from my Jetson 😄 ). It would be great if I can just resume the previous recording instead of a new one.
Hopefully I am not asking too much ;).

Hi !!
Many thanks for this, love to see real life usage feedback

I can understand the need for this 😉 , it should be pretty simple to add, I guess we can do it for v3

Right now it generate a random id and append a date to it, but when you save it you are free to rename the file no ?

This is a good idea, but won't be possible for v3 as it requires substancial work to implement properly.... but we will keep in around for the future.

Very interested in your long sessions usage feedback, and also would love to feature your project for v3 release if you like. (v3 release will be delay and happen likely in 1-2 months once the craziness of coronavirus will be a bit hopefully a bit less)

No problem! Currently just passed the 2000 minutes mark , so 33.33 hours and the Jetson Nano still shows no signs of giving up (on v2 I could tell it was going to crash soon as the UI became unresponsive). I unfortunally have to end this recording tomorrow because  I have a newly trained model ready.

Great, sorry for that mess of a sentence there haha.

Indeed, when saving the CSV I can name it what I want, though Id like to automatise it as much as possible so I can either send data in a structured manner, or have the API "read out" for further processing. Now I first have to get the randomly generated name for the recording to find out what the name is somewhere. It would be great if I can for example do something like location_date.

Awesome. I already figured that that isnt something you add with two lines of code. Hope it can be arranged sometime 👍 .

For the featured project, I will get back to that later 😄 .

No problem! Currently just passed the 2000 minutes mark , so 33.33 hours and the Jetson Nano still shows no signs of giving up (on v2 I could tell it was going to crash soon as the UI became unresponsive). I unfortunally have to end this recording tomorrow because I have a newly trained model ready.

Nice !!

no problem!

I understand, problem is that for the database it is much more convenient to have an unique id. How would you like to automatise the process in the best of the world ? because right now what you can do is:

request this API endpoint ( https://opendatacam.github.io/opendatacam/apidoc/#api-Recordings-List_recordings ) , that return list of recordings. (you can pass limit = 1 to have only the latest)
GET /recordings

And there you get the summary of the recording along with the id of it is you want to request more details,.
I think we don't want to add another feature with UI that give you the ability to name the recording, because it is not reliable, for example people name it "myrecording", and then name another one the same name.. and then you can't request it uniquely.. You could append the date to it, but then it is as complex as an ID to request.. (would need date + time)... Does it make sense ?

Yes, will add it on the backlog

For the featured project, I will get back to that later .

Yes, with all the covid related events, we have decided to delay v3 release until a few weeks, so would be nice to get in touch in around in 2-3 weeks so maybe you can gives us more insight of you project and we can feature it as one of the use case of OpenDataCam. (Could you drop me an email so I have your contact ? my email is on my github profile)

Done with https://github.com/opendatacam/opendatacam/commit/627756860b0843bb05f7fb19eb5cfea4de18bcd5

Closing this one and tracking the remaining feature request here: https://github.com/opendatacam/opendatacam/issues/200


SSL configuration is Running - stuck on certificate verification

App Id: dh560tidatacw
Region: us-west-1
Step: SSL configuration
Status: Running

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
A clear and concise description of what the issue/question is.
Error message
If there is an error message, please include it here.
Note: Be sure to check the message for sensitive information.
Additional information
Linking my domain is stuck on this step, and has been for at least 12 hours: We validated that the CNAME record exists in your DNS file. We will now verify ownership of the domain. If this takes longer than 8 hours, please create an issue in our GitHub issue tracker.

Looks like this app has since been deleted, if you're still having issues please re-open and provide latest app Id.


ImageInput doesnt works for uploading

i am trying to achieve Image Upload using
First Image will be stored to data storage backend is working file.
while comes to storing file from front facing the issue.

It looks more like a support request (how to store an uploaded file on my backend) rather than a technical issue with admin-on-rest. I suggest you open it on StackOverflow. Moreover, your issue misses details to respond it properly. :)


Basic fish support

This commit adds basic fish support to tabry-rs

I added support for expanding ~/ (in master now) but it seems like it is running tabry "zellij" 7 five times, significantly slowing down completions (each tabry call is about 9 ms on my computer). I imagine the source of it may be this?
  complete -f -c "$cmd" -n "__fish_tabry_check_only_args" -a "(__fish_tabry_completions)"
  complete -c "$cmd" -n "__fish_tabry_check_only_file"
  complete -c "$cmd" -n "__fish_tabry_check_args_and_file" -a "(__fish_tabry_completions)"

Each of the 5 function invocations I think are running tabry.
Is there a way to call tabry  once? (or maybe just 3 times?)
Or maybe we can mark that as a future TODO.

Is there a way to call tabry once?

Yes! based on your comment I totally re-tooled everything and now it's a lot simpler and calling tabry only once, and it now supports directory completion


Update sqlite3 to 5.0.4

The current version of sqlite3 used does not have arm binaries until version 5.0.4!
It would be nice to see this change in the repository rather than having to clone and update sqlite3 after each commit with:
pnpm update<EMAIL_ADDRESS>:))

Updated! lmk if you'd like anything else changed


Creating new variables in L1a

Hi @stephpenn1 for you to consider:
I just realized that the decision to create new, derived variables in L1a has other consequences. So far we knew that

it means we have to bring data together across entire site in this step

But in addition

we need to do timestamp rounding at this point, too, because there's no guarantee different dataloggers will be exactly the same

This is completely breaking our plan at this point, which was that L1a was intended as a not-raw-but-still-original stream, while L1b was structured to be cross-site with consistent timestamps. (And actually, in that link, it's only L2 in which "derived (calculated) variables" is mentioned.)
... so, thoughts? Any chance we can not do derived variables until L1b? Just wanted to check, again, before getting too deep into this restructuring.

🤔

User dataset
Old scheme
New scheme

L0
Raw (CSV)
Raw (CSV)

L1a
Unit converted; OOB flags; original timestamps; loggernet vars only
Unit converted; OOB flags; rounded timestamps; loggernet + derived vars

L1b
Organized around trees (or EU); rounded timestamps; derived vars
Organized around trees (or EU); rounded timestamps; derived vars

Very little difference between L1a and L1b in the new scheme.

User wants…
Old scheme
New scheme

Raw data (CSV)
L0
L0

Converted data, original timestamps
L1a
?

Rounded timestamps, derived vars
L1b
L1a or L1b

@stephpenn1 Good morning!
My suggestion, FWIW, would be for us to talk with Roy and Selina about this. It's a big design decision with lots of consequences, and we have plenty of other things to do before the writing workshop as it is - see https://github.com/COMPASS-DOE/data-workflows/issues/13#issuecomment-1398818837.
But your call of course.

@selinalcheng sez

We do round our timestamps in our L1a step, but not necessarily for joining. We just round it to whatever the interval of the data table is supposed to be, in case there are erroneous timestamps (e.g., most of our data is supposed to be collected at 15 min intervals). We then store this rounded variable as a new column and allow the original timestamp to travel with the table until it's not needed anymore.

I assume your issue here is that you need to round a data table to a new time interval and thus need to aggregate the data somehow? You may need to create another step between L1a and L1b where you have rounded timestamps and aggregated data to the largest time interval (e.g., 1 hour), with no derived variables. Then another step where you have 1-hour data and derived variables. What do you think?


call layout() after changing slide

When slide A having data-coursemod-shown=false is made visible, and slide B having =true comes immediately afterwards, HTML elements in B are kept in false-like size and are not resized when B is made visible, thus frequently getting cropped off slide limits. Added Reveal.layout() at end of slidechanged event listener, seems to fix it.

tyvm


Apple Health Full Data Sync

Goal
I use a Dario, which logs glucose values in it's own app and then sync it to Apple Health.  There are other scenarios, like Smart Insulin pens that do the same thing.
The goal here is to do a full Apple Health sync pulling in data from other apps syncing to Apple Health and showing them within Glucose Direct.
This will require some migration of the existing data Glucose Direct saves to Apple Health, because we need to delete and resync it to save off the Apple Health Sync ID to prevent duplicate data being sent to Apple Health and so we can reliably delete and update data as needed.
This will also register Glucose Direct to recieve background apple updates.

@creepymonster Ok this one is ready for review! This will sync data back and forth from HealthKit maintaining identifiers.
So if you use another app to input/modify values, it will bring it into GlucoseDirect using Apple Health Background updates.

how come this hasn't been merged yet?

Merge it))))))

I would very much like to see this merged as well 😁


Add implementation of Floy'd algorithm in java

Implement All-Pairs Shortest Paths problem using Floyd's algorithm.

Issue closed, end of Hacktoberfest!


Rename Eth1.0 and Eth2.0

Pull request checklist
Describe the change
Update the Eth1 to "execution layer" and Eth2 to "consensus layer" per the Ethereum Foundation update.

Issue fixed
Fixes #333

Impacted parts
For content changes

[x] Doc content
[ ] Doc pages organisation

For tools changes

[ ] CircleCI workflow
[ ] Build and QA tools (lint, vale,…)
[ ] MkDocs templates
[ ] MkDocs configuration
[ ] Python dependencies
[ ] Node dependencies and JavaScript
[ ] ReadTheDocs configuration
[ ] GitHub integration

Testing

Screenshots / recording
https://pegasys-teku--341.com.readthedocs.build/en/341/

Well this is awkward.
I'd like to make a few changes - I'll add a commit in a little while.


Why Raise INVALID_APP_IDENTIFIER?

The line under concern for this issue is: https://github.com/apple/app-store-server-library-python/blob/1202058ddf4eac67c66f3947827e042e9ae6eee1/appstoreserverlibrary/signed_data_verifier.py#L72C1-L73C83
The signed data verifier raises VerificationStatus.INVALID_APP_IDENTIFIER if the decoded transaction bundle id is not equal to the signed verifier bundle id.
Why raise this error? There are legitimate edge cases where we have No bundle id in the api response for that transaction id.
Does it make sense to allow None bundle id response?

I would add a flag to say whether to be explicit on this or not. Because I would prefer the data even when the bundleId is None

#114 As an example, if you like this or want to pass a flag, let me know and I can submit a PR

There are legitimate edge cases where we have No bundle id in the api response for that transaction id.

What cases? There are no legitimate cases I am aware of

Hey @alexanderjordanbaker
I'm not speaking as if I know the reasons why the api can return a response without a bundleId
What I am saying is that we have about a one in a million edge case where I receive this error and the bundleId is None.
I look at the transactions and I personally would prefer having the data, even when the bundleId is None.
I don't see why this would raise any concern. The transaction looks legitimate otherwise, and I suppose a rare bug on Apple side?

I mean I guess I am asking is there any particular reason to throw that error when that data exists?

@big-c-note If you have a recent example of that, would love to see it, could you file a ticket in Feedback Assistant (feedbackassistant.apple.com) and post the FB number here please

These are old orders @alexanderjordanbaker
But happy to share. Can you help me to know what is a FB number?

Oh disregard a feedback assistant number. Got it, will do tomorrow. Appreciate the curiosity!

@alexanderjordanbaker FB16031317 (Some responses from transaction history v2 do not have a bundleId (set to None) )
Thank you


Unknown: open(/var/lib/php/session/sess_jc330rvt9kuon5uakrl8v239u1, O_RDWR

Whoops\Exception\ErrorException thrown with message "Unknown: open(/var/lib/php/session/sess_jc330rvt9kuon5uakrl8v239u1, O_RDWR) failed: No such file or directory (2)"
Stacktrace:
#1 Whoops\Exception\ErrorException in Unknown:0
#0 Whoops\Run:handleError in [internal]:0

I replied in the chat. Looks like PHP cannot write to the session folder (/var/lib/php/session).
If you setup the server, check that that directory exists, and that it's writeable.

turns out my php version was like .01 off the required, updating to 5.6 fixed it, can be closed
Sent from my iPhone

On 4 Jun 2016, at 1:14 AM, Flavio Copes<EMAIL_ADDRESS>wrote:
I replied in the chat. Looks like PHP cannot write to the session folder (/var/lib/php/session).
If you setup the server, check that that directory exists, and that it's writeable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Cool!


spike: seperate out each validator to its own StatefulSet

Overview
With implementation of ingress, and routing traffic to individual pods of a StatefulSets is non trival, might require embeding envoy proxy with istio.
Currently
Each chain is represented with 2 statefulsets:

genesis: 1 replica
validator: n replica
Number of validators exposed to users is a simple number that can be set. Internal routing of traffic to individual validator is based on the headless service for the validator and use: validator-<n>.validator.$NAMESPACE.svc.cluster.local. But this is not available for simple ingress rules

Proposal
An alternative to current approach of 1 statefulset, is to just have multiple statefuls per validator. This will add the overhead of many Statefulset, but will reduce the overhead of tricky networking to route traffic.
Additional benifits: Each validator will have its own service
Alternatives

CRDS: starting to look promissing, we can simplify our own overhead of services, statefulsets etc. Not sure what this will look like though
Service mesh would need to integrated anyways for observability. It just might make sense to have a reverse proxy in place, then we could route traffic via the istion-ingress to individual pods of the stateful sets.

Note, each validator will have its own domain. Something like: genesis.<chain>.<domain>,validator-1.<chain>.<domain>.

Hmm interesting. The restart itself could be due to pod consuming more memory then limits.
After validator nodes running for 23h, memory utilization seems to be close 1.9Gi/2Gi:
│ devnet            mesh-2-genesis-0                                           ●    3/3              1 Running       97   1975        5        5       60       60 <IP_ADDRESS>     pool-11oli7pbe-xn7o7    23h       │

Need to do more research around memory requirements for longer running devnets.


q

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
``
Errors:

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
``

Expected Behavior
Environment Summary
macOS-12.3.1-x86_64-i386-64bit, Darwin 21.4.0
Python 3.10.2
Installer: HOMEBREW

azure-cli 2.34.1

Additional Context

Please provide the detailed CLI commands


P13N dialog does not set correct filter for 'date' column with 'after' filter in sapui5 smart table

OpenUI5 version: 1.80
Browser/version: Chrome latest
Please check this question also, it seems there are more bugs regarding smart tables and date properties!

Dear @mjza,
Please provide working example that demonstrates the issue you are reporting (JSBin for example). Otherwise we cannot check what exactly happens.
Best Regards,
Nikolay Hristov
GitHub Dispatcher

@NHristov-sap Please download the example from here: https://github.com/mjza/stp13n
Run it in WEB IDE as fiori app with mock server.
then open the p13n dialog and apply filter based on date!

Hi @mjza ,
I have downloaded your app and set it up, using mock server and UI5 ver 1.80.0. The problem is not reproducible.
I have applied a filter "Datum", "after", "May 19, 2001", and got 3 items filtered - with IDs 14, 57 and 88, which is totally correct output. Then I have applied a date "June 12, 2001", and got only ID 57 line (again correct result). See a screenshot below.
Best Regards,
Nikolay

I can make a video also if you want. It does not work in my web ide.

I tested with 2 versions. 1.71.22 and 1.80. I will upload a gif file soon.

@NHristov-sap  As it can be seen it is not only does not apply the filter, after reopening the p13n dialog the filter is not there any more.

Sorry it seems the problem is in version 1.71.4 - 1.71.19. This is the latest version available for promise systems!

Hi @mjza ,
Yes, it is reproducible, even in 1.80.
I have opened new internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Nikolay Hristov

Hello  @mjza,
the issue is fixed with the following change:
99445e809fc2f3b596465cb65463b36711e7a3a8
Regards,
Adrian


[Proposal] validCoupon method

Allows validation of coupon from Stripe.

I'm not sure this is really a great solution because the coupon might have been used to many times, etc.

@taylorotwell from the docs:
https://stripe.com/docs/api?lang=php#coupon_object
valid (boolean)
Taking account of the above properties, whether this coupon can still be applied to a customer
```

@taylorotwell I think that this should be reviewed again. Not sure if this was always the case, but you can now supply a total number of times that a coupon can be used on Stripe. If the coupon is redeemed up to that amount, the valid property in the coupon object should return false.


Rework the way std math ops are used from C and C++.

This attempts to do the right thing from a C/C++ namespace perspective and then works around brokenness in old versions of libstdc++ that keep us from doing the complete right thing.
Fixes #7603

Another thing to try, since you have a setup you can test, is moving the header in the test - right now it's at the top before any C++ includes, but it may play better if it is below them: https://github.com/google/iree/blob/89e9530b79e7946e04ccde9b0ac226a3f98dbffa/iree/samples/emitc_modules/add_module_test.cc

(here's an issue for making emitc modules safe to use: https://github.com/google/iree/issues/7605)

If this isn't supposed to be a thing we do, I'll just add a using namespace std to that one test. That's what I had, but I convinced myself this was a real use case and did a real fix. If it's not, I'll just do the simple thing until emitc can be layered as desired.

PTAL


Text being cut off in pie charts

Prevent this by maybe combining some categories?

Closing for now...


Provide script that downloads Netflix prize data and puts it in the right place

For our scripts to work, we need to download the Netflix prize data. As this file is ~500 MB and the licensing terms are dubious, we decided early on not to include it as part of the repo. It is however available on the Internet Archive here: https://archive.org/details/nf_prize_dataset.tar
We should write a script that downloads this tarfile, decompresses it, and puts the contents in /data/.
Specifically, everything that is in the download directory that the tarfile produces should be in the /data/ directory. So if there is download/movie_titles.txt it should be /data/movie_titles.txt.
In general, this would be a good candidate for a bash script that does wget -> tar -xzf -> rename directory. But it would be better to do it in Python for portability reasons (some team members use Windows).
We can definitely download the file with requests, but it might not be the perfect fit. We should research if there is a wget type library for Python that we could use.
We can use the tarfile library to extract the files: https://docs.python.org/3/library/tarfile.html
Finally, renaming can be done with os or shutil: https://docs.python.org/3/library/os.html#os.rename

@JamesKohlsRepo , I see some nice code in that PR 45.
nit: Modern code usually prefers lowercase list[str] and str | None over the old-fashioned List[str] and Optional[str]. Linters like ruff can flag that if desired.
Caching the giant Netflix tar-ball somewhere in the filesystem is certainly a possibility, and then you have to settle on a destination directory that works for everyone. Another possible design would be to rely on the requests-cache library, which I've had very good results with. It manages a local file, in sqlite format, which the app doesn't know or care about. Specify an expiration period of > 30 days, and the effect is your app does a GET exactly once, the bits are cached on disk, and subsequent GET attempts will be satisfied from disk rather than from network, for nice snappy performance.


Don't ask for Fitness / Activity permission?

For my app, not all users rely on the GPS. For these users, I don't want to ask for fitness / activity permissions when the app launches. Any ideas?

disableMotionActivityUpdates: true


[Event Request] table 9053 "Sales Cue"

Hi @DanielHaglo .
Couple of questions regarding to your request.
The first event: do I understand correctly that you need event for case else statement? Or you can use OnFilterOrdersOnAfterSalesHeaderSetFilters(SalesHeader)? We can add extra parameter FieldNumber there.
The second event: why do you need SalesHeader there? It is used only to set range on a Status, this is the only usage. What How you are going to use it, especially in the end of the function?

Hi @DanielHaglo , any update from your side?

Hi,
Im sorry, have not have the time to respond you.
There are no needs for these events afterall :)


Fixes #394 : Add isEqualByComparingTo and isNotEqualByComparingTo for Comparables

Thanks !
As isEqualByComparingTo and isNotEqualByComparingTo are now available for all subclasses of AbstractComparableAssert, we should add the corresponding unit tests like BigDecimals_assertNotEqualByComparison_Test and BigDecimals_assertEqualByComparison_Test.
Lot of work, I know !

In BigDecimals_assertEqualByComparison_Test and BigDecimals_assertNotEqualByComparison_Test I see tests for static methods of BigDecimals. Same is for Bytes, Characters and so on. In my code I don't add any specific methods to each type, so what am I supposed to test?

forget my comment ... I wanted to make sure that it worked for double, float, ... but I think we can avoid to write tests for that as it is already covered by Comparables_assertEqualByComparison_Test

Agreed :)

I would be nice to add an example to assertj-examples it you find the time.

I've added examples to the Javadoc and created PR for assertj-examples: joel-costigliola/assertj-examples#21

Thanks, good work.


dev: Use (or draw Inspiration from) the Equinox.Module Class

I notice at the heart base classes are just PyTrees and as such can't store variables for later use i.e. params of kernels have to be passed in for calculations such as gram / cross covariance upon every call.
I wonder if you have considered using or drawing inspiration from Equinox library (https://github.com/patrick-kidger/equinox/), where the core eqx.Module is a special class which registers the class as a PyTree, but does it in such a way that allows one to specify all its fields at the class level (identical to dataclasses).
class MyModule(equinox.Module):
    weight: jax.numpy.ndarray
    bias: jax.numpy.ndarray
    submodule: equinox.Module

    def __init__(self, ....):
        self.weight = weight
        ....

https://docs.kidger.site/equinox/api/module/
This is particularly useful where you can initialise variables, in terms of parameters which you wish to track gradients and static variables. Then one call to eqx.filter(model, ...) returns a PyTree of all trainable parameters stored in the whole model.
In my experience, this structure allows for a much neater and more PyTorch style code, while still retaining the ability to interact with all of JAX seamlessly.

Hi @adam-hartshorne. Thanks for raising this.
Yes, we are looking to move towards exactly this framework. We’ll hope to have something released by the the month’s end, assuming there are no unforseen stumbling blocks...


OnWordHighlightedListener

Added a OnWordHighlightedListener, giving us a listener AFTER a word has been selected and determined valid. With this we can clear the board using this listener and avoid the race condition that causes the last selected item to remain selected.
The sample skirts around this limitation by calling getNextGame();  in onAnimationEnd of an animation played within the standard OnWordSelectedListener callback.

Good call. Fixed.


Rendering of frame and events in Multi Objects 2D renderer are not in sync

In the Multi Objects 2D renderer, there seems  to be an offset between the position of the object(in this case rugby ball) to the corresponding events that must be generated. This effect happens both while running the code on my system and in the demo video given in the wiki (https://www.youtube.com/watch?v=Yre8iS2LqPc&feature=youtu.be). Shouldn't the frame and events generated be in sync?

Hi,
This time offset is normal.
To simulate a real DAVIS camera, the framerate of the camera images is artifically throttled to 40 fps (https://github.com/uzh-rpg/rpg_esim/blob/master/event_camera_simulator/esim_ros/cfg/multi_objects.conf#L24). This causes the events to be always "in advance" compared to the frames. This is also what you would observe with a real DAVIS sensor.
You can disable throttling the framerate of the images by setting the variable ros_publisher_frame_rate to a very high value (say,<PHONE_NUMBER>).


Link leads to wrong documentation section

[Enter feedback here]
In the Tip block in the beginning of the page the is a link "feature differences" which leads to the following page:
How to use Azure Table storage or Azure Cosmos DB Table API from Java
https://docs.microsoft.com/en-us/azure/cosmos-db/table/how-to-use-java
It most likely should let to another one:
Introduction to Azure Cosmos DB: Table API (this page contains table which does compare two offerings against each other)
https://docs.microsoft.com/en-us/azure/cosmos-db/table/introduction

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83df0ac8-6349-4ea5-4698-fdf00c69c92f
Version Independent ID: 5afd32d5-5585-c495-b68d-7d68963b6b3d
Content: Introduction to Table storage - Object storage in Azure
Content Source: articles/storage/tables/table-storage-overview.md
Service: storage
Sub-service: tables
GitHub Login: @tamram
Microsoft Alias: tamram

@mikerodionov Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@mikerodionov  The PR has been initiated! We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Uninstaller for Windows is not signed

Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the SignTool directive in your Inno Setup script. See http://www.jrsoftware.org/ishelp/index.php?topic=setup_signtool
For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!


when i run the program, it errors. How can i solve it?

when i run the program, it errors. How can i solve it?
set METEOR_PACKAGE_DIRS=..\Packages
meteor --settings ../config/orthancDICOMWeb.json
[[[[[ ~/Desktop/Medical-Cloud-master/Viewers/OHIFViewer ]]]]]

Check this issue: https://github.com/OHIF/Viewers/issues/97

METEOR_PACKAGE_DIRS didn't work

What's the output you are getting?

‘/Desktop/Medical-Cloud-master/Viewers/OHIFViewer’  the path name is too long. Shorten the folder name and try again

This looks like it's a Windows-specific issue. See https://forums.meteor.com/t/long-paths-names-make-build-on-windows-impossible/21387/10
You can try enabling Long Paths for Windows: https://betanews.com/2016/05/29/long-paths-windows-10/


Meet “OSError: Invalid data stream” when using panphlan_profiling.py

Hi,  @leonarDubois
I am new to panphlan3 and i meet error when i used panphlan_profiling.py.
The code i perform is as following:
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro panphlan % panphlan_profiling.py
-i ./map_results/
-p ./Bifidobacterium_pseudocatenulatum/Bifidobacterium_pseudocatenulatum_pangenome.tsv
–o_matrix ./profiling_results/matrix.csv
STEP 1. Processing genes informations from pangenome file…
Number of reference genomes: 18
Average number of gene-families per genome: 1761
Total number of pangenome gene-families 4550
STEP 2. Create coverage matrix
Traceback (most recent call last):
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 932, in
main()
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 864, in main
dna_samples_covs = read_map_results(args.i_dna, args.verbose)
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 299, in read_map_results
dna_samples_covs[dna_sample_id] = read_gene_cov_file(os.path.join(i_dna, dna_covs_file))
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 285, in read_gene_cov_file
for line in f:
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/bz2.py”, line 215, in readline
return self._buffer.readline(size)
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 68, in readinto
data = self.read(len(byte_view))
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 103, in read
data = self._decompressor.decompress(rawblock, size)
OSError: Invalid data stream
Thanks for viewing!
hope for your reply.

Hello,
thanks for pointing out this issue. It seems that the profiling step has trouble reading your results from the previous step (mapping step) or at least unzip them. Are your sure your input files (the ones in ./map_results/) are bz2 compressed files as they should be at the end of the mapping step ? Also, do they contains any special character in the filename that could cause troubles, such as space characters ?

Hi,
thanks for replying.
The input file contained in map_results/ is as following:
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro map_results % ls
D35PC4_1_1.csv.bz2
I changed the file name and run again. But same error also occurred.

Ok, try unzipping the file manually and check the content. Your should have 2 fields, gene names and a numeric value. If this is ok, then it means that the issue might come from the mapping file generation instead. Which command did you run on the mapping step ?

I unzip the file and the content looks like as following:
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro map_results % head D35PC.csv
DXD35_00015	20996
DXD35_00020	86501
DXD35_00025	68508
DXD35_00030	81754
amt	1224319
DXD35_00040	8485
DXD35_00045	14149
dnaB	2064436
DXD35_00055	123892
DXD35_00060	69630
The command i used to perform map step is :
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro map_results % panphlan_map.py \
-p ./Bifidobacterium_pseudocatenulatum/Bifidobacterium_pseudocatenulatum_pangenome.tsv
--indexes Bifidobacterium_pseudocatenulatum/Bifidobacterium_pseudocatenulatum
-i ./D35PC4_1.fastp.1.fq
-o map_results/D35PC4_1_1.csv

It is strange, because all the command use is fine and the results should be OK as well.
The error raised :
File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/bz2.py”, line 215, in readline return self._buffer.readline(size) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 68, in readinto data = self.read(len(byte_view)) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 103, in read data = self._decompressor.decompress(rawblock, size) OSError: Invalid data stream
means that the file trying to be opened is not a bz2 compressed file. So either the file is corrupted somehow (version of the BZ2 python package, space on the disk....) or the map_results folder contains other non bz2 files that try to be opened

I check the integrity of mapping result file and it is OK.
The version of bzip2 package is as following:
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro Panphlan % conda list
packages in environment at /Users/wangzhenyu/opt/miniconda3/envs/panphlan:

Name                    Version                   Build  Channel
bowtie2                   2.4.1            py37h5e6fd57_3    bioconda
bzip2                     1.0.8                haf1e3a3_3    conda-forge
c-ares                    1.16.1               haf1e3a3_3    conda-forge
ca-certificates           2020.6.20            hecda079_0    conda-forge
certifi                   2020.6.20        py37hc8dfbb8_0    conda-forge
cycler                    0.10.0                   pypi_0    pypi
htslib                    1.10.2               h422799e_1    bioconda
joblib                    0.16.0                   pypi_0    pypi
kiwisolver                1.2.0                    pypi_0    pypi
krb5                      1.17.1               h75d18d8_3    conda-forge
libcurl                   7.71.1               h9bf37e3_5    conda-forge
libcxx                    10.0.1               h5f48129_0    conda-forge
libdeflate                1.6                  h0b31af3_0    conda-forge
libedit                   3.1.20191231         h0678c8f_2    conda-forge
libev                     4.33                 haf1e3a3_1    conda-forge
libffi                    3.2.1             hb1e8313_1007    conda-forge
libnghttp2                1.41.0               h7580e61_2    conda-forge
libssh2                   1.9.0                h8a08a2b_5    conda-forge
matplotlib                3.3.1                    pypi_0    pypi
ncurses                   6.2                  hb1e8313_1    conda-forge
numpy                     1.19.2                   pypi_0    pypi
openssl                   1.1.1g               haf1e3a3_1    conda-forge
pandas                    1.1.2                    pypi_0    pypi
panphlan                  3.0                      pypi_0    pypi
perl                      5.30.3               h6156909_1    conda-forge
pillow                    7.2.0                    pypi_0    pypi
pip                       20.2.4                   pypi_0    pypi
pyparsing                 2.4.7                    pypi_0    pypi
python                    3.7.8           hc9dea61_1_cpython    conda-forge
python-dateutil           2.8.1                    pypi_0    pypi
python_abi                3.7                     1_cp37m    conda-forge
pytz                      2020.1                   pypi_0    pypi
readline                  8.0                  h0678c8f_2    conda-forge
samtools                  1.10                 hf7e01e7_3    bioconda
scikit-learn              0.23.2                   pypi_0    pypi
scipy                     1.5.2                    pypi_0    pypi
seaborn                   0.11.0                   pypi_0    pypi
setuptools                49.6.0           py37hc8dfbb8_0    conda-forge
six                       1.15.0                   pypi_0    pypi
sqlite                    3.33.0               h960bd1c_0    conda-forge
tbb                       2019.9               ha1b3eb9_1    conda-forge
threadpoolctl             2.1.0                    pypi_0    pypi
tk                        8.6.10               hb0a8c7a_0    conda-forge
wheel                     0.35.1             pyh9f0ad1d_0    conda-forge
xz                        5.2.5                haf1e3a3_1    conda-forge
zlib                      1.2.11            h7795811_1009    conda-forge
Is the version of bzip2 OK?
The disk spack is enough and I'm sure that map_results contain csv.bz2 file.
The input file contained in map_results/ is as following:
(panphlan) wangzhenyu@wangzhenyudeMacBook-Pro map_results % ls
D35PC4_1_1.csv.bz2

Hi,
I've been investigating the problem a bit more. The bz2 python package syntax changed a bit when it switched to Python 3.
I've pushed a tiny change on the repo that should modify the way the bz2 file is read. Let me know if it solve your problem

Hi,
Thanks for spending so much time on solving my problem.
I try again using the updated script. However, same error occurred again.

Hi,
I have solved this problem when I change the output of mapping step in .tsv format.
I guess this error result from words = line.strip().split('\t') within read_gene_cov_file(input_file). But i'm not familiar with python so i'm not sure that this is the bug of my error?

Hi,
glad to know that the problem is solved. It is quite strange that the file extension caused the issue, since the coverage output file was written using tab separated fields '\t' in the panphlan_map.py script. So the file extension provided in the output name should not impact it. I'll investigate that more precisely when I'll have time.

Hi, @leonarDubois I am new to panphlan3 and i meet error when i used panphlan_profiling.py. The code i perform is as following: (panphlan) wangzhenyu@wangzhenyudeMacBook-Pro panphlan % panphlan_profiling.py -i ./map_results/ -p ./Bifidobacterium_pseudocatenulatum/Bifidobacterium_pseudocatenulatum_pangenome.tsv –o_matrix ./profiling_results/matrix.csv
STEP 1. Processing genes informations from pangenome file… Number of reference genomes: 18 Average number of gene-families per genome: 1761 Total number of pangenome gene-families 4550
STEP 2. Create coverage matrix Traceback (most recent call last): File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 932, in main() File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 864, in main dna_samples_covs = read_map_results(args.i_dna, args.verbose) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 299, in read_map_results dna_samples_covs[dna_sample_id] = read_gene_cov_file(os.path.join(i_dna, dna_covs_file)) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/bin/panphlan_profiling.py”, line 285, in read_gene_cov_file for line in f: File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/bz2.py”, line 215, in readline return self._buffer.readline(size) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 68, in readinto data = self.read(len(byte_view)) File “/Users/wangzhenyu/opt/miniconda3/envs/panphlan/lib/python3.7/_compression.py”, line 103, in read data = self._decompressor.decompress(rawblock, size) OSError: Invalid data stream
Thanks for viewing! hope for your reply.

Hi! I'm having the same issue. How did you fix it?
Best,
Pablo


slicer: Do not put link objects that will be rejected

Since link objects have payload now, they may overflow max regular object size. Client-size error is better that server-side overflow message. Not expected in practice but may be observed when running some extreme local installations for tests (e.g., 1K limit and 100K object).

However, we also may allow LINK objects to be bigger than regular object size limit.
Also, that is not really helpful if the whole object is PUT already and only the last iteration has failed. A user cannot even know any ID.

@carpawell tests with small limit broke, should be fixed. For example, we can predict whether links will fit into the object, and if not, expect an introduced error. Tested limits' increase could also be needed

tests with small limit broke, should be fixed

Just increased the limits, if you don't mind. There is not much we can do here.

For example, we can predict whether links will fit into the object

Only if we know the exact object size. That is not granted. And i think in practice a known object size is not the case where it cannot fit a link. Not sure what can store 95TB, know its size and stream it to the NeoFS.


NOTEs: Could not adjust grid , Axes in grids may be inconsistent

On opening some datasets we get warning messages like this (Wei Cheng recently reported this)
           *** NOTE: Could not adjust grid for variable sivol
           *** NOTE: Axes in grids may be inconsistent.

Possibly in conjunction with notes about unrecognized axis units.  A file like this (shortening the ncdump header for clarity) fails to open correctly:
netcdf sivol_SImon_CAMS-CSM1-0_historical_r1i1p1f1_gn_197901-201412 {
dimensions:
        i = 360 ;
        j = 200 ;
        time = UNLIMITED ; // (432 currently)
        vertices = 4 ;
variables:
        int i(i) ;
                i:units = "1" ;
                i:long_name = "cell index along first dimension" ;
        int j(j) ;
                j:units = "1" ;
                j:long_name = "cell index along second dimension" ;
        float latitude(j, i) ;
                latitude:standard_name = "latitude" ;
                latitude:long_name = "latitude" ;
                latitude:units = "degrees_north" ;
                latitude:_FillValue = 1.e+20f ;
        float longitude(j, i) ;
                longitude:standard_name = "longitude" ;
                longitude:long_name = "longitude" ;
                longitude:units = "degrees_east" ;
                longitude:_FillValue = 1.e+20f ;
        double time(time) ;
                time:units = "days since 1850-1-1 00:00" ;
                time:axis = "T" ;
                time:long_name = "time" ;
        float sivol(time, j, i) ;
                sivol:standard_name = "sea_ice_thickness" ;
                sivol:long_name = "Sea-Ice Volume per Area" ;
                sivol:missing_value = 1.e+20f ;
                sivol:_FillValue = 1.e+20f ;
        float vertices_latitude(j, i, vertices) ;
                vertices_latitude:units = "degrees_north" ;
                vertices_latitude:missing_value = 1.e+20f ;
                vertices_latitude:_FillValue = 1.e+20f ;
        float vertices_longitude(j, i, vertices) ;
                vertices_longitude:units = "degrees_east" ;
                vertices_longitude:missing_value = 1.e+20f ;
                vertices_longitude:_FillValue = 1.e+20f ;

The file opens with a bunch of NOTE's and then has pretty wacky grids that can't be fixed up with Ferret commands:
yes? use /home/merlot/ksmith/Tests/Wei/sivol_SImon_CAMS-CSM1-0_historical_r1i1p1f1_gn_197901-201412.nc
           *** NOTE: Units on axis "i" are not recognized: 1
           *** NOTE: They will not be convertible:
           *** NOTE: Units on axis "j" are not recognized: 1
           *** NOTE: They will not be convertible:
           *** NOTE:
           *** NOTE: Could not adjust grid for variable latitude
           *** NOTE: Axes in grids may be inconsistent.
           *** NOTE:
           *** NOTE: Could not adjust grid for variable longitude
           *** NOTE: Axes in grids may be inconsistent.
           *** NOTE:
           *** NOTE: Could not adjust grid for variable sivol
           *** NOTE: Axes in grids may be inconsistent.
yes? sh dat
     currently SET data sets:
    1> /home/merlot/ksmith/Tests/Wei/sivol_SImon_CAMS-CSM1-0_historical_r1i1p1f1_gn_197901-201412.nc  (default)
 name     title                             I         J         K         L
 LATITUDE latitude                         ...       ...       1:200     ...
 LONGITUDE
          longitude                        ...       ...       1:200     ...
 SIVOL    Sea-Ice Volume per Area          ...       ...       1:200     ...
 VERTICES_LATITUDE
                                           1:4       1:360     1:200     ...
 VERTICES_LONGITUDE
                                           1:4       1:360     1:200     ...

but another similar file opens up fine, even with the same grid setup:
netcdf sivol_SImon_GFDL-ESM4_historical_r1i1p1f1_gn_197901-201412 {
dimensions:
        y = 576 ;
        x = 720 ;
        vertex = 4 ;
variables:
        double x(x) ;
                x:units = "degrees" ;
                x:axis = "X" ;
        double y(y) ;
                y:units = "degrees" ;
                y:axis = "Y" ;
        float latitude(y, x) ;
                latitude:long_name = "latitude" ;
                latitude:units = "degrees_north" ;
                latitude:cell_methods = "y: point x: point" ;
                latitude:standard_name = "latitude" ;
        float lat_bnds(y, x, vertex) ;
                lat_bnds:long_name = "latitude bounds" ;
                lat_bnds:units = "degrees_north" ;
                lat_bnds:axis = "Y" ;
        float longitude(y, x) ;
                longitude:long_name = "longitude" ;
                longitude:units = "degrees_east" ;
                longitude:cell_methods = "y: point x: point" ;
                longitude:standard_name = "longitude" ;
                longitude:bounds = "lon_bnds" ;
        float lon_bnds(y, x, vertex) ;
                lon_bnds:long_name = "longitude bounds" ;
                lon_bnds:units = "degrees_east" ;
                lon_bnds:axis = "X" ;
        float longitude(y, x) ;
                longitude:long_name = "longitude" ;
                longitude:units = "degrees_east" ;
                longitude:cell_methods = "y: point x: point" ;
                longitude:standard_name = "longitude" ;
        float sivol(time, y, x) ;
                sivol:long_name = "Sea-ice volume per area" ;
                sivol:missing_value = 1.e+20f ;
                sivol:units = "m" ;

Both have 2-D variables longitude and latitude with axes  (i,j) or (x,y)  and also  "vertex" or "bounds" variables that have dimensions  (j, i, vertices)  or  (vertex, x, y)
Ferret/PyFerret doesn't determine the first file has axis i is in the X direction and axis j is in the Y direction.  But in the second file it decides  that x is in the X direction and y in the Y direction using the axis attribute.
I think we have changes to be made here:

Go ahead and decide that an axis named i is in the X direction.  We already allow axes named X, Y, Z, or T to be in those directions; could also recognize I, J, K, or L as being in those directions.  This doesn't solve things in general but would let this set of CMIP6 model outputs open correctly.

Change the behavior if any axis direction is still undetermined and we're unable to form consistent grids.  Report the problem and stop with an error message rather than trying to continue.

 **ERROR: inconsistent data grids: File needs axis attributes on coordinate variables indicating correct directions

this is fixed as suggested above.

Allow single-letter I, J, K, L to indicate axis direction (but not M and N as those aren't as standard).  That lets us use the example file as-is.

If the file initialization stage can't create consistent grids for the variables and dimensions in the file, stop with a note suggesting AXIS attributes for setting axis directions.


make lightsource for ophys_rig

[x] add LED class to rig and ophys_session
[x] make Lightsource the union of LED and Laser

closed by #289


Add support to Install-DbaMaintenanceSolution for the Queue and QueueDatabase tables to be installed

Summary of new feature
Currently the Ola Hallengren procedures support processing databases in parallel by specifying @DatabasesInParallel = 'Y'.  However, the tables Queue and QueueDatabases are not installed by default (nor are they in Ola's Maintenance deployment script).  This leaves the download and install to a manual effort (at least until I decide to script it myself).  These tables are in the master.zip that is pulled from GitHub.
Proposed technical details (if applicable)
I would suggest adding a switch to include parallel objects (i.e. -IncludeParallelObjects)
Latest version of dbatools as of writing
1.0.115

Ola should really be including those in his maintenance scripts. I'd go ahead and submit an issue to his repo for that (though I'm not sure he is working maintaining issues/PRs).
On our command, just have it create the objects OOB, no need to tie it to a parameter. If the Backup command has the option to use it then it should just have them waiting for the user.

@wsmelton I'm looking at this now and I think all the tables should be required regardless.  There is this line of code
            if ($LogToTable) {
                $required += @('CommandLog.sql')
            }

Translated, if they call the script to add the jobs, and passed the $LogToTable switch, then install the CommandLog table.  My thinking is, what if they don't pass the switch, but later decide to modify the job to log to the table.  Well, now you have to run another install, versus already having the table there.
Thoughts?

The LogToTable is a different beast because that controls whether the procedures deployed are modified as well. We have to leave that one as-is.
We can tie adding the queue tables to either passing -Solution All or -Solution Backup.

@wsmelton I completed the PR (hopefully correctly!).  I did make the CommandLog table required just like the Queue and QueueDatabase tables.  All 3 of these tables can be referenced by the main procedures (DatabaseBackup, DatabaseIntegrityCheck, IndexOptimize, and CommandExecute).  All 3 of these tables access are controlled by parameters in the calls to these procedures.  The LogToTable switch should only control the initial creation of the job text.  Also, if InstallJobs is true, the MaintenanceScript installs it automatically anyway.  But if InstallJobs is false, then the table should still be created IMO.

Was fixed with #7236, so closing.


Vacations are Shown as +1 on the calendar

Days have only one or two vacations still it's not shown and shown as +1 more

I believe this issue should have been addressed in https://github.com/codescalers/CSHR/pull/384. If the problem persists, kindly re-open it again. It's worth noting that the FullCalendar package we utilize handles the requests, and when pressing on "+more," you'll observe the additional events displayed there.


Change full url

How I can change the url to make the request with Twitter?
I use the URL param but just replace the path and keep the domain :( i need to make a request to other domain.
for example in the config:
twitter: { clientId: "XXXXX", redirectUri: "XXXX", url:"EXAMPLE.com" }
I get:  localhost:3000/example.com

try changing "baseUrl" in the base config
export class MyAuthConfig extends CustomConfig {
    baseUrl = 'example.com';
    providers = {twitter: { clientId: "XXXXX", redirectUri: "XXXX", url:"/twitter" }};
}

No response. closing.

Sorry for not responding, your answer works


PDF reader app that remembers the last page you were on?

I added pdf reader to my android pdf app.It works nicely.Thank you.I added pdf via assets folder.My problem is, when reader come back to read pdf again, pdf will open it's first page.
But I want to start pdf with previous close point.How to enable remember point in pdf ?

I believe I've seen such an issue somewhere.
You could simply save the current page after overriding onPause() or onStop() in your activity or fragment.
Get the current page by calling pdfView.getCurrentPage().
Then add an OnLoadCompleteListener when building using the Configurator:
pdfView.fromFile(file).onLoad(new OnLoadCompleteListener() {             @Override             public void loadComplete(int nbPages) {                 pdfView.jumpTo(savedPage);             }         }).load();
and call pdfView.jumpTo() to restore the point.

Dont forget you need to save a reference to the document name so when you reopen the same pdf it will remember the page number otherwise any pdf will try to open on the saved page,

@1stmetro  How to save a reference to the document name ?
Thank you

This is totally up to you and is in no way connected to the library. Use shared preferences or local sqlite storage.
-----Original Message-----
From: "MrMarkSteven"<EMAIL_ADDRESS>Sent: 27/05/2018 10:14
To: "barteksc/AndroidPdfViewer"<EMAIL_ADDRESS>Cc: "Karuhanga Lincoln"<EMAIL_ADDRESS>"Comment"<EMAIL_ADDRESS>Subject: Re: [barteksc/AndroidPdfViewer] PDF reader app that remembers thelast page you were on? (#605)
@1stmetro How to save a reference to the document name ?
Thank you
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


add support for Groq

I  dont think it makes sense to support tons of other models, but since groq is 10x faster and has free api keys to mixtral at 30 reqs a minute, I think worth it :)
https://groq.com/

I think the whole point of this project is to allow local LLM via ollama to be run easily.

You can use an LLM Gateway for such usecases.
Mine should work for that use case also: https://github.com/adrianliechti/llama

Enchanted Settings:

LLM Platform Config:
config.yaml
providers:
  - type: groq
    token: ${GROQ_API_TOKEN}

    models:
      llama3-70b-instruct:
        id: llama3-70b-8192

      mixtral-8x7b-instruct:
        id: mixtral-8x7b-32768


Strange wording in Readme

readme.md file says:

If you don't those options for composing queries then the final option would be to pass in a query object to another in it's constructor and use it as the base scope:

Sentence is not very clear. Seems some the verb is missing.

Thanks @stgeneral, I agree that could be worded a little better. I'll see what I can come up with.


Set Window/View Size Before Game Start

If your game’s virtual resolution (display width and display height) is different from what you want your initial window size to be, you need to call set_view_size on your game’s init. While this works, this function isn’t called until after the game has booted up, leaving your game at the actual display resolution for a few frames.
See the below game that was designed to be in 1080p, but has the view size being set to 720p on init (since a 1080p sized window is unreasonable on most displays).
https://i.gyazo.com/03a91663b2ce441fe80caebeb869af24.mp4
A means to set a starting window/view size separate from the display width and height would be nice.

I'm not sure if this is possible to do with a native extension. Unless somehow we are able to override the default GLFW 2.5 window view size on extension init, and if that is soon enough to prevent the appearance of a larger initial window view size. If that was possible then maybe we could access a game.project setting within native extension init to force an actual extension init window view size that's different from the one set in game.project and used by the engine to determine various view related sizings/orientations.
@11clock I recommend you forking DefOS and just testing to see if hard coding a smaller initial window size within the extension init function works to to solve your issue or not.

Issue will be fixed after merging this PR https://github.com/subsoap/defos/pull/124 (Pls pay attention that this fix can't be applied before a fix in the engine, read PR description)


upgrade to @angular/cdk 2.0.0-beta.10

I'm submitting a...

[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

Expected behavior

upgrade @angular/cdk 2.0.0-beta.8 to @angular/cdk 2.0.0-beta.10
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

ng-zorro-antd version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

ASAP plz

快一点咯，下个版本会升级好吗？什么时候？

@encool any block to you?

项目同时使用了angular material 2.0.0-beta.10和nz 0.5.0。aot build会失败。是这里的原因吗？


feat: Add init-fullnode subcommand stub

Starts https://github.com/strangelove-ventures/cosmos-operator/issues/237
The thought here is an init container using this operator subcommand. Eventually, we can consolidate a lot of init container steps into a single container, use Go instead of bash, and have more functionality under tests.

Closing. Taking another approach.


feat(elements): Add backup_code verification strategy

Description
Adds backup_code verification strategy
<SignIn.Step name='choose-strategy'>
  <SignIn.SupportedStrategy name='backup_code'>Use a backup code</SignIn.SupportedStrategy>
<SignIn.Step>

<SignIn.Step name='verifications'>
  <SignIn.Strategy name='backup_code'>
    <Clerk.Field name="backup_code">
      <Clerk.Label>Code:</Clerk.Label>
      <Clerk.Input />
      <Clerk.FieldError />
    </Clerk.Field>

    <Clerk.Action submit>Continue</Clerk.Action>
  </SignIn.Strategy>
<SignIn.Step>

Fixes SDK-1852
Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

!snapshot

Hey @tmilewski - the snapshot version command generated the following package versions:

Package
Version

@clerk/chrome-extension
1.1.1-snapshot.v64cb67f

@clerk/clerk-js
5.7.3-snapshot.v64cb67f

@clerk/elements
0.10.0-snapshot.v64cb67f

@clerk/clerk-expo
1.2.4-snapshot.v64cb67f

gatsby-plugin-clerk
5.0.0-beta.45

@clerk/ui
0.1.5-snapshot.v64cb67f

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-js
npm i<EMAIL_ADDRESS>--save-exact

@clerk/elements
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-expo
npm i<EMAIL_ADDRESS>--save-exact

gatsby-plugin-clerk
npm i<EMAIL_ADDRESS>--save-exact

@clerk/ui
npm i<EMAIL_ADDRESS>--save-exact


No log

Provide an easy way (function or flag) to turn off logging and or redirect it.

Because downloading binary files is very slow in some cases, people don't know what happened. If you do not want to output logs, you can refer to https://deno.land/std/log/README.md to adjust the log level or the log handler.
import * as log from<EMAIL_ADDRESS>await log.setup({
    loggers:{
        default: { level: "ERROR", handlers: [] }
    }
})

Ok, guss I'll close the issue then

Your solution does not work due to the https://github.com/manyuanrong/deno-plugin-prepare/blob/209079d281e19e28e12cbbd2589425dc623b1685/mod.ts#L9 that disposes all existing handlers. To solve this you simply need to remove it.


Implement a way to monitor production bugs

🧐 The problem
We don't have a clear view regarding how our application is handling production traffic. If a bug starts to happen, we would only see it when a customer started to complain about it.
💡 What solution do I want
We should implement a bug tracking software to solve that for us.
😰 What have I tried to do already
Nothing.
🍪 Further details
We should consider Sentry as an option.
Also, after finishing this issue, we should consider if we need to implement that in our front-end too.

Closed since we're now managing our engineering priorities on Jira.


[Azure Tables]Can't pick up correct value from environment variable

We are running live tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.
Add TABLES_STORAGE_ENDPOINT_SUFFIX with appropriate value into tests.yml then the test cases can acquire it from environment for different clouds live tests.

But all tests about storage table fails with below error:
System.AggregateException : Retry failed after 4 tries.
----> Azure.RequestFailedException : An error occurred while sending the request.
----> Azure.RequestFailedException : An error occurred while sending the request.
----> Azure.RequestFailedException : An error occurred while sending the request.
----> Azure.RequestFailedException : An error occurred while sending the request.
----> System.Net.Http.HttpRequestException : An error occurred while sending the request.
----> System.Net.WebException : The remote name could not be resolved: 't4113ac42c20b44c5prim.core.windows.net'
----> System.Net.Http.HttpRequestException : An error occurred while sending the request.
----> System.Net.WebException : The remote name could not be resolved: 't4113ac42c20b44c5prim.core.windows.net'
----> System.Net.Http.HttpRequestException : An error occurred while sending the request.
----> System.Net.WebException : The remote name could not be resolved: 't4113ac42c20b44c5prim.core.windows.net'
----> System.Net.Http.HttpRequestException : An error occurred while sending the request.
----> System.Net.WebException : The remote name could not be resolved: 't4113ac42c20b44c5prim.core.windows.net'

The storage uri = TABLES_STORAGE_ACCOUNT_NAME + TABLES_STORAGE_ENDPOINT_SUFFIX
Expected value:

t4113ac42c20b44c5prim.table.core.windows.net

Actual value (table is missing):

t4113ac42c20b44c5prim.core.windows.net

But the cosmos table tests don't have this issue. (BTW, it uses TABLES_COSMOS_ENDPOINT_SUFFIX as service suffix)
@jongio @danieljurek for notification.

@danieljurek can you review this issue?

//fyi - @christothes

Please try with the following env variables:
STORAGE_ENDPOINT_SUFFIX
COSMOS_TABLES_ENDPOINT_SUFFIX

@christothes - Yes, it works. Thanks for your update.


Rewards page not updating

A quick heads up for an issue I noticed this morning:  After the latest update yesterday to 2.1.10 the rewards page is not being updated.
I enjoy using it for tracking what gets vaulted, double checking gold rewards, etc for my spreadsheets.
Also, I really enjoy the new client interface, looks much nicer, I like how it matches the website too. Nice work!!

Rewards tracking is fixed. To get it tracked, just restart your tracker (Stop Tracker in the app interface and launch again then)

Awesome, thanks so much.
Let me know if there's anything I could ever do to help with the project if
needed.
On Sat, Nov 23, 2019 at 11:36 AM Razviar<EMAIL_ADDRESS>wrote:

Rewards tracking is fixed. To get it tracked, just restart your tracker
(Stop Tracker in the app interface and launch again then)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Razviar/mtga-pro-tracker/issues/559?email_source=notifications&email_token=AFNCDTTKWP67NTI5MQGIRZLQVFLZLA5CNFSM4JQ2XJP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7YXOY#issuecomment-557812667,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNCDTREEQ5IPZHLK3E4XMDQVFLZLANCNFSM4JQ2XJPQ
.


Update README.md

Added the following to README.md

Link to game demo
About Game (along with screenshot of home screen)
A short guide on how to play the game (along with screenshots)
Steps to install and start the game (along with git commands)
Navigation guide for the game (along with screenshots)

Linked issue: #64