Detect encoder failures on live streams

Have you read the FAQ and checked for duplicate issues:yes
What version of Shaka Player are you using:2.2.1
Can you reproduce the issue with our latest release version: yes
Can you reproduce the issue with the latest code from master: yes
Are you using the demo app or your own custom app: custom
If custom app, can you reproduce the issue using our demo app: have no ablility
What browser and OS are you using: chrome  60.0.3112.113
What are the manifest and license server URIs: sent to mail
(you can send the URIs to<EMAIL_ADDRESS>instead, but please use GitHub and the template for the rest)
What did you do? Live encoder stopped work as expected because of disk failure (disk remounted as read-only), so no new segments and no updates of mpd file, it freezed. I opened stream in player and nothing happened, only requests to mpd file and licenser server. I suppose it happens because of freezed publish time. I attempted to repeat situation, but encoder works normally and i just copied mpd file and attemped to play it, so situation was the same. I suppose there must be some validation or some error in console so we can find it and attempt to play backup stream. But at the moment all looks like it should play but nothing happens.

Hi! Any success?

@kuznetcoff777, if the encoder stops updating the live manifest, we have no way to detect that right now.  I would like to be able to detect this situation and issue an error, but I'm not sure how best to do that.
If there is any guidance in DASH or DASH IOP, I would be grateful for pointers.

It seems that publishTime might be part of the solution, but a quick scan of the latest IOP did not turn up an obvious solution.

MPD@publishTime provides versioning functionality: MPD with later publication times include all information that was included all MPDs with earlier publication times.

Perhaps if publishTime isn't changing for a significant amount of time, we could combine that with some other signal to guess that the encoder is offline.

Maybe it is necessary to make some configurable parameter, some delta, for example if it = 60, then if now_date - piblishtime>60, then error

M?

Guys, it is pretty critical thing, cause now our player have main and backup playlist, and if main playlist stalls, player cannot turn to backup, because of it does not get that something wrong with main playlist.

@kuznetcoff777, you are welcome to submit a pull request for this if you need a solution sooner than we can provide.
The best idea we have come up with in this thread so far is to fail when publishTime stops updating for some amount of time.  You would need to look into lib/dash/dash_parser.js to add the check and lib/util/error.js to create a new error code.  If you want the timeout to be configurable, you would also need to look at externs/shaka/player.js to add a field to shakaExtern.DashManifestConfiguration and lib/player.js to set the default.

With great pleasure, but i do not know your code as well as you are. I just wanted to know if any thoughts appeared, last thing was your question. I think it must be configurable, because:
1-publish time is constant when it is VOD
2-i saw some encoders, which do not refresh publish time (or refreshes very seldom)

Yes, I think some configurable parameter makes sense.

We are already detecting potential coding issues at https://github.com/shaka-project/shaka-player/blob/main/lib/media/media_source_engine.js#L869, I consider this issue resolved


Fixes clippy on macos

For some reason I was having an error from clippy locally:

It was quite annoying, so I have fixed it:

thank you!


feat: Add default config for project-name

Pull Request description

Add default config for project-name. It also allows to use environment variable for the default project-name
Split the smoke tests in smaller tests
Kill all the container before starting a new test
Replace all the usage of kxgr to sugar (kxgr is still a valid alias for containers-sugar)
Fix default services list used from the configuration file

How to test these changes

...

Pull Request checklists
This PR is a:

[ ] bug-fix
[ ] new feature
[ ] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Additional information

Reviewer's checklist
Copy and paste this template for your review's note:
## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@EverVino this PR is ready for review if you have time :)

@EverVino I am merging this PR, but feel free to add any comment here and I can address that in a follow-up


Support autosize in td-layout-manage-list

Feature Request
Is it possible to add somewhere the possibility to set autosize for the <mat-sidenav-container> here: https://github.com/Teradata/covalent/blob/47b0b2f38ca53d67fd25f031ca2123448ee7a5c8/src/platform/core/layout/layout-manage-list/layout-manage-list.component.html#L1
This would ease the development of a mini nav. You can find a simple example here: https://stackblitz.com/edit/angular-b4gmby?file=app%2Fsidenav-autosize-example.html
Furthermore, it should make your mini nav example here working since it's currently broken.

Some discussion on this topic can also be found in material2
I would also be open to contribute a PR.

This can be possible now with #1234

niiiiiiceeeeeeeeeee


Clear all messages in room

Enable clearing of all messages in a room
@gavinr @JevinAnderson @jwasil @BrianBunker Check it out!

@thollingsheadesri based on our other convos and tests, I say bring it! :pizza: party

:+1:

Additional bug found by @gavinr. If you are away, and a user adds messages then clears, the new messages added are not cleared.


Planetside 2 Anticheat Is working

Game Title
Planetside 2
Status of the Anti-Cheat
⭐ Supported
Proof of Mention
N/A

Can confirm

I'm still somewhat hesitant, ProtonDB seems fairly forthcoming that everything is fine, but I have yet to see an official response from a developer.
Did they just make this change without informing their users? Or is there a chance that the new runtime fixes the issues and that players are just at risk of being kicked and banned at any moment?

Did they just make this change without informing their users? Or is there a chance that the new runtime fixes the issues and that players are just at risk of being kicked and banned at any moment?

From what we know, the latter. Planetside 2 doesn't seem to be the only game like this though, so perhaps there is something more to it?
Might warrant a new category.

Maybe there should be a status called "Working/Unconfirmed" or something like that?
But if you add that there should be a 1-2 week delay before adding to avoid false positives like smite that allow people to play for a few days to then be blocked again


STREAMLINE-778: Changes needed for Roles API

Added api to list users under a role
Metadata field for role for UI to store role metadata
Load system roles and create admin role during bootstrap

@shahsank3t , added add and update bulk apis for users under roles.
E.g. POST api/v1/catalog/roles/ROLE_ADMIN/users/
["user1", "user2", ...]
the array can be list of user ids or user names.

@arunmahadevan  Can you also please add following metadata into bootstrap for roles:

ROLE_ADMIN, {"colorCode":"#8261be","colorLabel":"purple","icon":"gears"}

ROLE_SECURITY_ADMIN, {"colorCode":"#000000","colorLabel":"black","icon":"shield"}

ROLE_TOPOLOGY_ADMIN, {"colorCode":"#529e4c","colorLabel":"green","icon":"sitemap"}

ROLE_TOPOLOGY_COMPONENT_BUNDLE_USER, {"colorCode":"#9e4c75","colorLabel":"pink","icon":"sitemap"}

ROLE_TOPOLOGY_COMPONENT_BUNDLE_ADMIN, {"colorCode":"#9e8a4c","colorLabel":"brown","icon":"sitemap"}

ROLE_CLUSTER_ADMIN, {"colorCode":"#ce761b","colorLabel":"orange","icon":"lock"}

ROLE_FILE_ADMIN, {"colorCode":"#dcaa15","colorLabel":"yellow","icon":"file"}

ROLE_UDF_ADMIN, {"colorCode":"#dcaa15","colorLabel":"yellow","icon":"code"}

ROLE_NOTIFIER_ADMIN, {"colorCode":"#9e8a4c","colorLabel":"brown","icon":"bell"}

ROLE_NOTIFICATION_USER, {"colorCode":"#4c979f","colorLabel":"blue","icon":"bell"}

ROLE_SCHEMA_USER, {"colorCode":"#4c979f","colorLabel":"blue","icon":"file-code-o"}

ROLE_SCHEMA_ADMIN , {"colorCode":"#9e4c75","colorLabel":"pink","icon":"file-code-o"}

Thanks in advance.

@shahsank3t , added metadata to roles in bootstrap. Please check

@shahsank3t , added metadata field for user
@harshach , removed roles related to schema and corresponding checks


feat(logger): support custom message key

fixes #1541

@gr2m also would be really great if can also integrate the fix here into this PR. To do so, I need you to create a fix version of the @probot/pino module.

@gr2m docs added.

@gr2m I spent some time trying to see how to add a test here but I cannot figure it out easily.
Initially I wanted to test the output of probot.log after setting it up with format=json and messageKey=mymessage. However I fail in trying to read the output from stdout. Do you want to give it a try?

I also looked for a test for other env configuration such as LOG_FORMAT or LOG_LEVEL_IN_STRING but I don't see any test for these config features.

@gr2m I added a test. Can't guarantee is the best way to test this, but it definitely works and does the job.

I tried to intercept stdout directly but it does't work because of the SonicBoom wrapper pino logger uses.

@gr2m can we ensure we publish a fix version for this: https://github.com/probot/pino/commit/1bca0bbfb97b65981048c3adc835ebaa06a8b231 and that we update the dependency in probot after that?


More updates on the readme and packages.json file

There are some grammatical issues that need to be checked and rectified.
Also, tell the user how to edit the database (const sequelize = new Sequelize('postgres://user:pass@example.com:5432/dbname'). Although it seems descriptive, there is need to add such description in Readme. Also, you can show the user how to make use of .env for such cases.
In packages.json, there are 2 and 3 instances that nodejs and kemboijs occurs in the keywords section. We only need one instance of each.
Also, add how to contribute to Readme file section.
Any updates on the Readme, which is helpful to the user is also appreciated.

Let me work on this issue

Assigned you the task @Nicanor008.


allow tracing to resume during function execution

If tracing gets disabled, currently it's only re-enabled before the next statement that occurs at a call-depth of 0. This means we can lose some dataflow information if tracing is disabled in the middle of function execution and there are still more statements to go before function return.
The original rationale is that it's hard to detect when it's safe to resume tracing. For example, we cannot safely reenable tracing if the stack depth has increased, since our tracing stacks have now gotten out-of-sync with the interpreter call stack (they push important information like the statement we're returning to). Even if the stack depth is the same, we don't know if it's because we're still in the same function, or if it's because that function returned and another function was called. (Tracing was disabled, so we're not tracking what's happening anymore.)
The latter case (stack depth same) maybe is safe if the reason tracing was disabled is due to iteration. Overall this issue needs further investigation.

Reopening as there seem to be some x-platform issues with the attempt to fix this

Seems this is finally working.


utilities: fix issues related to conversion of lengths to pt

This PR fixes some issues regarding the conversion of lengths to pt in hopes of progressing #74. Please see each commit's message for details.
I don't see any regressions in tablex-test.typ (compiled it to PNG before and after this PR's commits, then checked their hashes).
I'm marking this as a draft for now as I haven't added any tests. I did some quick testing with negative line expansion, and surprisingly, it seems to work, so I'd like to investigate this further before readying this PR.

Oh, I didn't realize that the problem occurred even when you were reducing the stroke below a single cell. That is interesting. Thanks for looking into this!

I've rewritten the functions to use regex (yeah, quite ugly) and added some tests.
One concern I have: the repr for the abs component of a length rounds to a precision of 2 (src), so there will be a loss of precision. This is true for at least Typst 0.9.0, but I haven't looked at previous versions and other length types.

One concern I have: the repr for the abs component of a length rounds to a precision of 2 (src), so there will be a loss of precision. This is true for at least Typst 0.9.0, but I haven't looked at previous versions and other length types.

That seems to be the case since before Typst was released... In this case, I think a good workaround might be to keep the old algorithm (just measure the line) if there are no negative numbers in the length's parts (checking if either of the "minus" symbols is present in the repr() should be enough). That way, we only lose a bit of precision when dealing with the specific case of negative numbers. Of course, this is bound to be improved if/when we switch to 0.7.0's constructs.

I've gone ahead and implemented what I came up with in https://github.com/PgBiel/typst-tablex/pull/84#discussion_r1413024123. I've also managed to come up with a solution for the same precision issue for relative lengths (we don't use repr for fraction and ratio, so those are unaffected).
On the testing side:

Added tests for line expansion
Updated the conversion tests to check the return type (length) and use values that can better ensure that there is no precision loss

I think we're nearly done with this PR. All that's left is another round of review and ensuring that this PR works with older versions of Typst.
I've left the commit history mostly intact because I didn't want to accidentally remove commits when force pushing. However, I can squash some of them if you prefer.

Re-ordered the commits so that changes to tablex-test.typ come later. Makes it easier to check for regressions before tablex-test.typ got modified.
I managed to hack together a bunch of scripts using Nix and diff-pdf to semi-automate regression testing for the different Typst versions. (Didn't include them here since they're out of scope and pretty makeshift, but they can be found here: https://github.com/dixslyf/typst-tablex/commit/7d078ebff5f91010395103aa624af068686fcac8.) I don't see any regressions for any of the supported Typst versions.

I plan on having a better testing system in the future. I'll probably consider using PNG instead of PDF though as it's a pain to work with :p
I'm particularly interested in Lau's efforts towards a standard testing solution for packages, although I might also try out something like CeTZ's system. We'll see...

I'll probably consider using PNG instead of PDF though as it's a pain to work with :p

Indeed, PDFs are a huge pain to work with. I initially wanted to go with PNG for my tests, but PNG export was only added in Typst v0.5.0. What I tried at first was to convert the PDFs to PNGs using ImageMagick (I also tried pdftoppm), but the conversion took a while and you need to tune the options to get decent quality output. I later realized you could just use magick compare on two PDFs (it'll do the conversion for you, but you'll still need to tune the options) to generate a diff image (the exit code also tells you whether the PDFs were similar). I went with diff-pdf (which does more or less the same thing) in the end just because it was easier to use.
Another thing I tried was to compare the output across different Typst versions (e.g., compare the outputs for Typst v0.2.0 and v0.9.0). The outputs were slightly different — mostly differences in spacing. However, even for pages that look the same to our eyes, if you compared them using magick compare, there would be differences in the anti-aliasing (I think) of rendered text. I figured it wasn't worth it to test across Typst versions.

I'm particularly interested in Lau's efforts towards a standard testing solution for packages,

Same!

although I might also try out something like CeTZ's system. We'll see...

I took a look at CeTZ's testing when I was trying to test this PR, and it did look nice and promising. My only concern was it tests only a single version of Typst as far as I can tell. It's probably not too difficult to expand on that, however (e.g., modifying PATH to use a different Typst version, though fetching the different Typst versions and caching them somewhere sounds like a bit of a pain).


Microsoft Defender flags 2KAN as Trojan

This is a false positive that is caused by pyinstaller packaging the python interpreter and included libraries into a single executable which causes some anti virus to think this is a trojan.
We sent the executable into Microsoft as a false positive, and they returned saying that they did not find anything malicious and have exempted 2KAN.exe from Microsoft Defender. As this can sometimes take time to roll out these changes, if you are encountering Microsoft Defender flagging 2KAN as malware or trojan, please update your malware definitions following these steps:
1. Open command prompt as administrator and change directory to c:\Program Files\Windows Defender
2. Run “MpCmdRun.exe -removedefinitions -dynamicsignatures”
3. Run "MpCmdRun.exe -SignatureUpdate"```

This should force the malware definitions to update and 2KAN will no longer be flagged as a trojan.

Alternatively I have added a update_defender_definitions.bat file to the release. Simply run as an administrator and it will automatically update to the newest malware definitions.


Cannot Save File

Type: Bug
Whenever attempting to save a file, I keep getting this notification on the bottom that doesn't go away: Saving 'filename.go': Getting code actions from "Go','Github Copilot Chat" (configure). After waiting for a while, the file still does not save. Only encountering this on my Surface Laptop with the Snapdragon X processor
Extension version: 0.17.0
VS Code version: Code 1.91.0 (ea1445cc7016315d0f5728f8e8b12a45dc0a7286, 2024-07-01T18:52:20.204Z)
OS version: Windows_NT arm64 10.0.26100
Modes:

System Info

Item
Value

CPUs
Snapdragon(R) X 12-core X1E80100 @ 3.40 GHz (12 x 2976)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.36GB (6.53GB free)

Process Argv
--crash-reporter-id 1f6d6216-4011-492f-bd92-12b6b21a6a5d

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
chatpanelt:31048053
dsvsc021:30996838
f3je6385:31013174
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
legacy_priority:31082724

this has been an ongoing issue :( I've been seeing this happen mostly from eslint as @eianc mentioned, but I don't have a reliable repro.

This is mostly an issue with eslint itself. There is an issue to help analyze this: https://github.com/microsoft/vscode-eslint/issues/1344 and how to file an issue against ESLint if none of the proposed solutions help.

A colleague of mine just started getting the same issue with a new Mac. When he used Ubuntu or Windows he did not get the issue.
It's strange that on other codebases that I'm working on I don't get the issue, only on a monorepo setup with Lerna I'm getting it.

I also experience this issue regularly. Same message at the bottom (Saving '....html': Getting code actions from "GitHub Copilot Chat" (configure). It is a recurring issue that seems to be related to closing the lid of my MacBook over the weekend and returning on Monday. I assume that the Copilot Extension has an issue with the MacBook going into sleep mode for a longer period. So far, I restarted VSCode to get rid of the problem. However, my understanding is that a text editor MUST NEVER loose any files, so regardless of the problem I would recommend to look into ways to implement an exception handler that ensures that the files are saved as a backup at least.

Happens to me very often.
I feel like it should not prevent saving the file
In my case is the GitHub Copilot Chat extension causing it

Happens to me very often. GitHub Copilot chat might be causing it.
My work around is to ctrl + shift + P then Developer: Reload Window
It is warning me then what the issue is "Saving text files. Do you want to proceed anyway?"
I click yes and I am all good.

Half an hour after installing GitHub Copilot I'm unable to save files, so this means the copilot extension is unusable for me. 3 months and noone did anything about it, so it won't be going away in the near future either. This means I can quit my subscription before paying, which isn't too bad after all.

Same issue here. If I have the chat window open and I save it takes minutes. It shows me: Code Actions - organizing imports. Reloading window without extensions and then reloading extensions is fixing it for me until a new chat request.


The bot doesn't parse .mention-bot from the repo

Hi @vjeux, sorry I hadn't time to create the PR for https://github.com/facebook/mention-bot/issues/160 yet, and I haven't investigate this bug as much as I wanted either. I am leaving for vacation in 2 hours 😄
I have added a .mention-bot file at the root of our repo getting PRs, and saw that the bot was not using it. I checked the logs, and surely the lines "Continuing with default configuration." had disappeared. The bot was finding the file, but not applying its configuration.
It turns out that getRepoConfig is getting an object with data and meta properties, and data is a string. Something like:
// result =
{ data: '{\n  "maxReviewers": 2,\n  "numFilesToCheck": 10,\n  "message": "Hi @pullRequester! By analyzing the annotation information on this pull request, I identified @reviewers to be potential reviewers",\n  "alwaysNotifyForPaths": [{\n    "name": "tbassetto",\n    "files": ["blah/**/*.js"]\n  }, {\n    "name": "john12",\n    "files": ["blih/**/*.js"]\n  }, {\n    "name": "rick14",\n    "files": ["bleh/**/*.js"]\n  }],\n  "fileBlacklist": ["derp/*.json"],\n  "userBlacklist": ["cookiemonster"],\n  "assignToReviewer": true\n}\n',
  meta:
   { 'x-oauth-scopes': 'repo',
     'last-modified': 'Wed, 10 Aug 2016 09:22:55 GMT',
     etag: '"f6ea25b1784f40f5c53461fc040ddc85"',
     status: '200 OK' } }

I thus applied the following changes to make it work:
@@ -99,7 +100,12 @@ function getRepoConfig(request) {
       if (err) {
         reject(err);
       }
-      resolve(result);
+      try {
+        var data = JSON.parse(result.data);
+        resolve(data);
+      } catch (e) {
+        reject(e);
+      }
     });
   });
 }

I am wondering how it works for so many people but no us 🤔
We are using GitHub Enterprise 2.6, with the API V3. mention-bot is ran with node 4.4.7 (LTS).

Maybe it actually never worked...

Enjoy your vacation! Feel free to send this patch when you come back :)


New UUID-to-OID (AltIds) should not be sent to oid-info.com

The Microsoft UUID-to-OID and Waterjuice UUID-to-OID are AltIDs, which should not be sent to oid-info.com. The handling of these UUIDs should be the same as the handling for 2.25. They shall not be added to oid-info.com.
(1) OID 1.2.840.113556.1.8000.2554.25854.36082.13069.18473.45604.4487685.4269080
(2) OID <IP_ADDRESS>.4.1.54392.1.7277409019743782953.12836460128777610264
(3) OID <IP_ADDRESS>.4.1.54392.2.1694403826.856508457.2988721274.88155160
(4) OID <IP_ADDRESS>.4.1.54392.3.25854.36082.13069.18473.45604.17530.1345.9240
We shouldn't send AltIDs anyway!

Fixed in SVN Rev 1432 / Release <IP_ADDRESS>
By the way.... We shouldn't send AltIDs anyway?!


Do we support other Ubuntu version than Ubuntu LTS?

In the kitchen tests, we test against 12.04, 13.10 and 14.04.
Should we drop all the non LTS releases of ubuntu? or do we want to support all versions, in which case we are missing some targets.

No, I don't think we should support those release has end of life, like Ubuntu 13.10. the reason is simple, apt-get update fails because of repo is not supported, one can install nothing.
@justincampbell I propose removing ubuntu 13.10 from supported list since it has end of life since July 17, 2014 what do you think?

@shawnzhu I'm :+1: on dropping support for EOL OS/Ruby/Chef versions

closed since ubuntu 13.10 is excluded.


Tobin gh1053 empty descriptors

Fixes #1053
Fix a bug related to empty descriptor bindings potentially causing errors when updating descriptors that fall after the empty bindings.

:+1: I'm guessing positive LVTs won't need to go in the ValError database.

cherry-picked and pushed to master


working android plugin for ms band

Some notes for you:

ideally this would have been several commits, and probably multiple pull requests.
try NOT to mix whitespace changes with code changes if possible. ( 2 of the files only had whitespace changes, but I could not cherry-pick around this, because it was all 1 commit )

Thanks for contributing!


List of available Font Families or way to check if font family is available locally

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
While debugging visual issues, I would like to confirm what font is being used, and which are available on the device.
There have been similar questions on stackoverflow related to this, e.g https://stackoverflow.com/q/64145307/88646
Proposal
Add a API that returns a list of available font families, or some kind of callback/way to be notified if a fallback font is being used.

Hi @bramp

Add a API that returns a list of available font families, or some kind of callback/way to be notified if a fallback font is being used.

I think this could be two separate proposals. Labeling this issue as a feature request for the 1st proposal


debug: listen capabilities fix:#317

What this PR does:
Which issue(s) this PR fixes:

Fixes #317
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #328 (03dc286) into master (b04366f) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   39.75%   39.41%   -0.35%
==========================================
  Files          99      100       +1
  Lines       13702    13871     +169
==========================================
+ Hits         5447     5467      +20
- Misses       7588     7734     +146
- Partials      667      670       +3

Impacted Files
Coverage Δ

pkg/mysql/conn.go
39.94% <ø> (ø)

pkg/mysql/execute_handle.go
0.00% <0.00%> (ø)

pkg/mysql/server.go
0.00% <0.00%> (ø)

pkg/proto/rule/rule.go
69.14% <0.00%> (-12.11%)
:arrow_down:

pkg/runtime/namespace/namespace.go
53.44% <0.00%> (-1.34%)
:arrow_down:

pkg/boot/discovery.go
64.39% <0.00%> (-0.91%)
:arrow_down:

pkg/runtime/namespace/command.go
26.92% <0.00%> (-0.11%)
:arrow_down:

pkg/config/model.go
28.97% <0.00%> (ø)

pkg/sequence/snowflake/snowflake.go
12.76% <0.00%> (ø)

pkg/boot/boot.go
56.75% <0.00%> (+0.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04366f...03dc286. Read the comment docs.


Is there any built-in method to read all series files within DICOM study folder?

Hi,
I'm trying to read all series files within a studies folder  using the ImageSeriesReader, however, using the GetGDCMSeriesIDs method, I can't read unless I'm the *dcm folder. The following is the file tree that I'm working with:
DICOM_studies
├── Study_1
│   ├── Series_1
│   ├── Series_2
│   ├── Series_N
├── Study_2
│   ├── Series_1
│   ├── Series_2
│   ├── Series_N
├── Study_N

So the method above only works if I'm just reading in series file (e.g. DICOM_studies/Study_2/Series_1)

Hello @makquel,
That is a feature not a bug 😉 . To get the functionality you want you need to traverse the file system starting with your data root directory. Please take a look at the characterize_data.py script in our notebooks repository. More specifically, look at the this code in the inspect_series method. The combination of inspect_series and inspect_single_series addresses an even more generic structure where you can have:
DICOM_studies
├── Study_1
│   ├── Series_1_part_1
│   ├── Series_1_part_2
│   ├── Series_2
│   ├── Series_N
├── Study_2
│   ├── Series_1
│   ├── Series_2_part_1
│   ├── Series_2_part_2
│   ├── Series_2_part_3
│   ├── Series_N
├── Study_N

Hello @makquel,
That is a feature not a bug 😉 . To get the functionality you want you need to traverse the file system starting with your data root directory. Please take a look at the characterize_data.py script in our notebooks repository. More specifically, look at the this code in the inspect_series method. The combination of inspect_series and inspect_single_series addresses an even more generic structure where you can have:
DICOM_studies
├── Study_1
│   ├── Series_1_part_1
│   ├── Series_1_part_2
│   ├── Series_2
│   ├── Series_N
├── Study_2
│   ├── Series_1
│   ├── Series_2_part_1
│   ├── Series_2_part_2
│   ├── Series_2_part_3
│   ├── Series_N
├── Study_N

Hi @zivy ,
Thanks for the update, I hadn't watched for the examples in the notebooks in the first place, that seems to work well.

Hi @zivy ,
Thanks for the update, I hadn't watched for the examples in the notebooks in the first place, that seems to work well.


Scripts: Add quickstart script for alert generator compliance test

Signed-off-by: Matej Gera<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[X] Change is not relevant to the end user.

Changes
We have recently introduced the alert generator compliance test via E2E (see https://github.com/thanos-io/thanos/pull/5315). While this is useful for being able to run the test as part of our E2E suite, I want to propose also adding a separate script to spin up all components for the test run. Couple of reasons why:

We want to provide example configuration in the alert generator compliance repo to signal to users that Thanos is compliant. But because the E2E is running inside Docker, the configuration we have in the test is transient and cannot be easily made into a 'runnable' example config
Users do not need to look within our test files (and having to uncomment the skip call etc.), all is spun up with one script
Users do not even have to have Go installed (as opposed to E2E test), they can directly run this test with virtually no extra hurdles
Test is more transparent in a sense that users can observe the behavior (look at the web UIs) of the components, since these are running on the host machine (as opposed to containers without exposed ports).

Verification
Tested the alert generator compliance suite with the script on my local machine.

@bwplotka those are good counterarguments (I also do not want to push this change at all costs, as it is extra stuff to maintain, but still thought it would be a nice suggestion). To give more context how I was thinking about this:

For a developer, the E2E tests are useful: I make some changes and I want to make sure we are still compliant = great, I can run this E2E test
For any other user (e.g. anyone who just wants to run / play with Thanos) and they want to see for themselves that we are complian (before they decide to use us vs. other solution, for example): They don't need to clone the repo (need just one script), they don't need Go or build Thanos (using latest release is fine), they should simply be able to run the script + alert compliance tester and be able to immediately and transparently see we are compliant.

I think I look at the compliance to be more for users to be able to transparently verify we comply with the official specification, more than for developers (but who also need it if they make relevant change).

Perhaps adding this as example script to https://github.com/prometheus/compliance/blob/main/alert_generator and our file as a comment makes sense?
I was thinking about that as well, and we could try if the compliance suite maintainers are fine with it, it's just quiet a few lines so it seemed liked it would be better if it's separate script. But we could try this alternative as well.

Adding steps or script that runs compliance go test. Remove Skip and put a special build tag that triggers the test?
That would be fine as well, although users would still need to clone the repo, have Go etc. (point I addressed above, but maybe it's not that strong of a hurdle).

I don't think we have a strong enough agreement on this, I don't want to introduce something that might not be really needed / might become obsolete fast. I'd rather close this and if we decide to introduce the script, whether here or in the compliance repo, we can reuse this PR :+1:.


Windows 10 1903 Build 18362.535, RDP to Self

Hello, how do I RDP to Self?
When I attempt to RDP to the current station I am on, I am always presented with the following error:
"Your computer could not connect to another console sessions on the remote computer because you already have a console session in progress"
In order to circumvent the error I am having to rdp to another computer then. Once inside the other computer I am then able to rdp to my current station as a different user.
Basically:
Computer A attempts to RDP to Computer A, presented with above error.
Computer A RDPs to Computer B
Computer B RDPs to Computer A, success
I would like to do this:
Computer A logged in as user1 RDP to Computer A as user2 without having to go through RDP inception.
I was able to RDP to Self on windows 7, I have been unsuccessful on achieving this on Windows 10.
If anyone is able to point me into the right direction, I would greatly appreciate it!
Thank you!

Have you used RDPCheck.exe in the zip file?

@iantmarshall rdpcheck not only worked but provided the solution! rdpcheck uses the loopback address <IP_ADDRESS>. I was able to use that to rdp to myself. Case Closed, thank you very much!


(refactor): Centralize informer handling

Please describe the Improvement and/or Feature Request

We currently tightly couple our informers to specific objects (e.g. k8s controller, configurator, smi, and policy). The drawback to this approach is that no other component of the code can access these informer caches, respond to events, or otherwise interact with k8s objects except by:

depending on one of the aforementioned objects (creating coupling where it may not need to be)
creating new informers and duplicating the event handling/caching (opening the door for inconsistencies between the two caches)

I'm proposing that we centralize our informer handling in one object whose pointer can be passed around to any other object that may need to access an informer. This prevents engineers from having to create new, expensive informers, and it allows us to have opinionated patterns for informer use.
Scope (please mark with X where applicable)

Envoy Control Plane        [X]

Possible use cases

@keithmattix I believe this is a duplicate of https://github.com/openservicemesh/osm/issues/4551.  Do you agree?

Oh I completely forgot that issue existed. Yeah this is the same thing; feel free to close


Identify the tech stack you plan to use.

If this is the tech stack required by your client, then state that in the document. If your client is flexible, you must indicate a clear rationale of the choice made. This means an extra page with a table of at least 3 options and document all pros and cons for each before letting your client make a choice.

finished


Update Get-AzureADServicePrincipal.md

Added a third code example. In this example I use a search string to get the service principals.

Hi @expiscornovus
Per the read me file:
Please be aware that if you have any updates to automatically generated reference content, you should create an issue and not a PR.  The issue will then be created into a bug and triaged accordingly.  We do this because the reference content must mirror the *dll-help.xml file and subsequent updates to the reference content may overwrite any changes made through the repo.  Capturing it in the source code ensures that this does not occur.  Any PR with changes to automatically generated reference content will be closed.
Automatically generated reference content is any of the content under this Reference node, such as Get-AzureADUser
This only applies to reference content and not conceptual content.  Pull requests for changes to conceptual content are accepted and encouraged.  An example of the conceptual content is the Overview or a scenario such as importing data.
Thank you!
Bill


Litle & Co initial support

This fork adds support for accessing Litle & Co's online api through Active Merchant using our Ruby SDK.
We are extremely excited to be working with Shopify, and welcome any questions or requests you may have of us.
-Greg Dake
<EMAIL_ADDRESS>http://www.litle.com

This looks like a great start, but to accept it into ActiveMerchant I'm going to need to see it be a bit more idiomatic. Some of the major things I notice:

Ruby uses underscores for method and variable names, never camel case.
The configuration accessor seems confusing - can you use the already used and more idiomatic options that other gateways take?
Class variables (@@var) are generally avoided in Ruby; you should probably use constants instead.
Putting empty parens on method calls not taking arguments is generally not idiomatic Ruby.
Ruby always returns the last value in a method, so no need to explicitly return in general.

Not guaranteeing this will be all, but it'll be a good start. Would like to see this make its way in, so I'll keep an eye on this and re-review once you address these issues. Thanks!

Can you squash, and also get this applying cleanly to master? If you just rebase in this current branch, the PR will pick it up; no need to open a new PR. I'll then test it out and we should be good to merge.

This still doesn't seem to apply cleanly to master, and isn't squashed (looks like 7 commits still). If you can fix that up it would be great - thanks!


Prompting for exports is broken in the TUI in certain cases

When I run the attached file (see the next line), I get this output. Note that the default command for SPOT_INSTANCE_REQUEST is cut off, and indeed, does not work.
README.broken_prompt.md
This is a regression caused by #253 ; prior to this PR, it correctly ran the command (with no option to change / override the export, but that's ok; I never wanted to do that).
$ runme --filename README.broken_prompt.md
runme 1.2.2

> export-spotinstancerequest README.broken_prompt.md
    # Stop the instance (...)

Set Environment Variable "SPOT_INSTANCE_REQUEST": $(aws ec2 describe-spot-instance-requests --filters 'Nam

Set Environment Variable "INSTANCE_ID": $(aws ec2 describe-spot-instance-requests --spot-instance-request-ids $SPOT_INSTANCE_REQUEST | jq -r '.SpotInstanceRequests[].InstanceId')

bash: unexpected EOF while looking for matching `''
exit code: 2

Hi, @mikeage. Thanks for reporting this! Sorry for breaking your workflow. This issue was introduced to bring the TUI on par with the VS Code extension.
While we're fixing the underlying issue, you can work around the bug by adding a promptEnv=false option to the fenced code block like so:
3c3
< ```bash { promptEnv=false }

GitHub issues are great! If you ever want a direct line to the team, we're all available in the Runme Community server: https://discord.gg/runme.

Hi @mikeage I apologize for introducing this bug, The fix is here https://github.com/stateful/runme/pull/283 we will release it as soon as possible. thank you so much for reporting.

Thanks!

@mikeage should be fixed as of v1.2.4. Let us know how if you see any other issues.
Btw, we're looking to introduce a more fundamental change into how the CLI works. The idea is to consider all markdown files contained in the project (git-repo) or directory tree as opposed to README.md or --filename only. You can test drive it with setting the --project flag to --project "" to default to git-repo or --project . to use the current directory as root of the dir/file tree. We are still working out the UX and in the spirit of not breaking you again, I'd love to hear your thoughts. Btw, if your code blocks won't show up it's likely due to --allow-unnamed. Without code blocks without names are filtered out. Still working out the UX before making --project default.
Any feedback here or in Discord would be much appreciated! Thank you.

Cool, I'll check it out :-)

Heads up @mikeage! We release 1.3.0 today, which makes "project mode" default. Overall the idea is to make running tasks in Runme worry-free in terms of in what exact file the code block is located.
Runme will no longer default to README.md instead, it will scan the current working directory tree for all markdown files. By default, only explicitly named code blocks (overwrite with --allow-unnamed) will be considered. If you'd rather use the old behavior you can add --filename README.md to all commands, which will narrow it down to a single file.
A few improvements will come soon, including considering all unnamed code blocks in case there aren't any with names. We are publishing a blog post that explains the benefits and differences more comprehensively tomorrow—just wanted to give you a heads-up.

Thanks for the heads up! I'm away on vacation, so I probably won't be using this for a while, but I really appreciate your reaching out proactively :-)

Thanks for the heads up! I'm away on vacation, so I probably won't be using this for a while, but I really appreciate your reaching out proactively :-)

Of course! We didn't want to break you again. Enjoy your vacay!

Btw, here's the relevant blog post (https://runme.dev/blog/tasks-over-files-in-runme-cli) for when you're back from vacation!

Just realized I never responded here... new version is working great, and I love this project :-)


Got error:  Class private methods are not enabled. Please add @babel/plugin-transform-private-methods to your configuration.

Got this error right after plugin was added. I removed all private # symbols from ast.js file and it started to work in dev. But obviously it won't work in prod. Solution, provided in error descritpion, didn't help.
"gatsby": "^5.13.6"

Thanks for raising this issue @a-bochilo!
It's hard to know why you are getting this error without knowing more about your project setup. In case it would be possible to have a minimal example to reproduce it, I would be happy to have a look into it. Did you have any babel setup in your main project?
You could also try if the original plugin works for you: https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-google-gtag - it has the same dependency on minimatch.
I assume you tried adding this plugin as well https://babeljs.io/docs/babel-plugin-transform-private-methods#usage. For what it's worth, I'm just curious if you also added the option loose: true.
Furthermore I updated the dependencies on this plugin, but I wouldn't expect this to have any implication on the error you are experiencing.

@a-bochilo I had the same issue. I think it might have to do with CommonJS syntax. I used default exports (the readme suggests named exports) like so:
// cookie-consent-config.js module.exports = {   categories: {     necessary: {       enabled: true, // this category is enabled by default       readOnly: true, // this category cannot be disabled     },     analytics: {       enabled: false, // this category is disabled by default     },   }, ...

Actually, that is not at all the problem. There's an issue with the minimatch dependency

Fixed in version 0.0.6


Generate the web migrations/client from a schema file

Complex type definitions are functional but inefficient DX. Aliased types are also verbose and confusing.
Users could prepare a shared .ts schema file largely the same as today. From this some things could be generated:

A client class
Types for all models and sub-objects by name
Migrations when the user changes the schema file

To accomplish migrations, historical schemas will probably need to be stored in VC - perhaps in a special generated directory which should be committed.

Ok, ideating on what this could look like...
Using TypeScript to do schema validation itself still seems viable. Writing the schema as a TypeScript file means it can be easily imported and introspected by the CLI without requiring any parsing tools.
So supposing a schema file like this:
import { collection, schema } from '@lo-fi/schema';

export const todoCollection = collection({
	name: 'todo',
	primaryKey: 'id',
	fields: {
		id: { type: 'string', indexed: true, unique: true },
		content: {
			type: 'string',
			indexed: false,
			unique: false,
		},
		done: {
			type: 'boolean',
		},
		tags: {
			type: 'array',
			items: {
				type: 'string',
			},
		},
		category: {
			type: 'string',
		},
		attachments: {
			type: 'array',
			items: {
				type: 'object',
				properties: {
					name: {
						type: 'string',
					},
				},
			},
		},
	},
	synthetics: {
		example: {
			type: 'string',
			compute: (doc) => doc.content,
			unique: false,
		},
	},
	compounds: {
		tagsSortedByDone: {
			of: ['tags', 'done'],
		},
		categorySortedByDone: {
			of: ['category', 'done'],
		},
	},
});

export default schema({
	version: 1,
	collections: {
		todo: todoCollection,
	},
});

This would export a plain JS object of the schema itself. From here the CLI can parse it with TS, introspect the object, and learn what things it needs to generate and what they look like.
Migrations
To generate migration files automatically from schema changes, historical schema versions must be stored. These can be plain objects, not just copying the file itself. The files should still be TS though so that types can be provided when importing them.
And they will be imported, in the generated migration files, which could look like...
import type v1Schema from './.generated/schemas/v1';
import type v2Schema from './.generated/schemas/v2';

export default migrate<typeof v1Schema, typeof v2Schema>(...);

If the migration CLI is run and detects a copy of the version of your schema already exists, you will be prompted to increment the version number before continuing. New schemas are stored immediately.
Typed client (maybe)
It can then create a type definition file which exports all these types, including a full type definition of what a client looks like which interacts with the schema. Like Prisma. An accompanying JS module exports the existing client which continues to work as before, just with simplified external typings.
TBH I'm not sure I'm seeing the advantages of a generated client like this unless the existing (complex) typings are just way too slow or break easily.

More sketching thoughts...

Store a list of historical schemas internally to the generated directory.
On generation, always diff against any existing stored schema with same version. Error on difference. This can be nice and precise (down to function implementation) because we have the AST
If no stored schema exists for version during generation, create it
Generated code exports a migrator function which already knows all the historical schemas. User only has to specify which version they are migrating up to. It automatically provides typing for the new and previous schema shapes to do the migration functions.
No historical schemas need to be kept in user code. User doesn't need to add files in the generated directory. Just import the prefitted tools and let the generator take care of keeping track of schema history.

import { migrate } from './generated/client';

export default migrate(3, ({ migrate, withDefaults }) => Promise.all([
  migrate('items', withDefaults),
  migrate('lists', withDefaults),
]);

A basic form of this has been added. Further improvements or fixes will have separate issues.


[6.x] Accept a string or array of views

this goes along with PR #30651 .
I'm not sure what our practice is for changes like this on an interface.... I'm not technically changing any of the code, just a docblock, so is it safe to send to 6.x?

@browner12 it's okay 👍


dh_exch.c: Add check for OPENSSL_strdup

Since the OPENSSL_strdup() may return NULL if allocation
fails, it should be better to check the return value.
Signed-off-by: Jiasheng Jiang<EMAIL_ADDRESS>
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Thanks, now I have force-pushed a new 'fixup! fixup!'.
But I didn't add redundant 'pdhctx->kdf_cekalg = NULL;', since 'pdhctx->kdf_cekalg' will soon be assigned.

This pull request is ready to merge


Attach uiSelectDirective hide to ontouchstart if defined

ui-select currently does not work properly in touch-enabled browsers/devices when ngTouch is included.
This pull request fixes this problem by attaching uiSelectDirective's auto-hide functionality to the document's touchstart event, if defined, rather than the click event.

ngTouch has been deprecated.
I would recommend against this, as it has ramifications when other solutions like fastclick or hammer.js are used.

Agreed, closing.


Flanker Library Is Not Working

Hi
How should it work the function for validating the email
from flanker.addresslib import address
if name == 'main':
isValid    =<EMAIL_ADDRESS>addr_spec_only=True)
isValid2   =<EMAIL_ADDRESS>print isValid
print isValid2
The email<EMAIL_ADDRESS>does not exist and the seconde<EMAIL_ADDRESS>is my email
The result is:
<EMAIL_ADDRESS>None
it's not working

Running flanker 0.4.38 on ubuntu. Same issue here.


deps: bump @ckeditor/ckeditor5-build-classic to 43.1.1 LINK-2191

Description :sparkles:
Bump @ckeditor/ckeditor5-build-classic to 43.1.1. This fixes two vulnerabilities:

https://github.com/City-of-Helsinki/linkedcomponents-ui/security/dependabot/149
https://github.com/City-of-Helsinki/linkedcomponents-ui/security/dependabot/151

Issues :bug:
Closes :no_good_woman:
LINK-2191:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr435-ui.dev.hel.ninja :rocket::rocket::rocket:

e2e tests result is success for https://linkedcomponents-pr435-ui.dev.hel.ninja :laughing::tada::tada::tada:


2.1.15 is not opening picker. 2.1.14 is working

Describe the bug
Hard to say because I did not see anything in logcat. App has target api 31 as well. Invocation is within jetpack compose. Please give me further instructions to assist
To Reproduce
Steps to reproduce the behaviour:
ImagePicker.with(context as Activity)
.maxResultSize(maxAvatarSize, maxAvatarSize)
.cropSquare()
.createIntentFromDialog { launcher.launch(it) }
Expected behavior
Image picker is opened
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Emulator
Xiaomi Redmi 10s
Galaxy S21

all of my phones

Could you add a sample project to the ticket?

Having similar challenge. Image picker is not opened. Nothing in the Logcat.
I am using
            ImagePicker.with(requireActivity())
                .crop()
                .cropFreeStyle()
                .createIntentFromDialog { launcher.launch(it) }

@MartinMbae Please attach a sample app. and on which Android version did you see this issue?

This will work. Important line for createIntentFromDialog  is  to add provider(ImageProvider.BOTH). Refer below
ImagePicker.with(context)
.crop()
.cropSquare()
.maxResultSize(320, 320, true)
.galleryMimeTypes(arrayOf("image/png", "image/jpg", "image/jpeg"))
.provider(ImageProvider.BOTH)
.createIntentFromDialog { launcher.launch(it) }

I can confirm that this is fixing the issue
.provider(ImageProvider.BOTH) ftw
Thank you


Build OpenFAST for Windows

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

This is a pull request for testing in parallel to the RC branch.

@conda-forge-admin, please rerender

I think we can cancel this PR.  When I just tested the latest 3.4.1 build package from the rc branch-channel on my windows virtual machine, things seemed to be running.  I ran a few of the r-test cases that didn't require compiling a controller.  Might want to test it out on a vanilla windows machine though.

I just returned my NREL Windows computer this past week. @andrew-platt @deslaughter do you know anyone who has a Windows computer and is familiar enough with conda to test this? Maybe @ebranlard?

That sounds good to me. The test is to install OpenFAST from the rc label and run any test case, correct? Is it required to run the full regression test suite?

I've got Windows on my personal computer so I can try to run the full suite.


Got the project to run on MacOS.

This branch makes some minor changes to get the project up and running via Cmake on MacOS.

Thanks for your contribution!


404s in the console

The internationalization client-side code is generating 404s in the console. The design should not be that the client-side probes for what files exists and generates 404s every time it misses.

Fixed in the latest release, still open for the 0.1.11 release


(Trivial) typo

Description
(Trivial) typo

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (618eeab) 94.49% compared to head (006c726) 94.86%.
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   94.49%   94.86%   +0.37%
==========================================
  Files          32       32
  Lines        1035     1033       -2
==========================================
+ Hits          978      980       +2
+ Misses         57       53       -4

Files
Coverage Δ

ols/app/endpoints/ols.py
100.00% <ø> (ø)

ols/constants.py
100.00% <100.00%> (ø)

ols/src/query_helpers/docs_summarizer.py
91.80% <63.63%> (ø)

... and 1 file with indirect coverage changes


Fix  #2981 - Update Profile to match TableProfile

Describe your changes :

This PR fixes https://github.com/open-metadata/OpenMetadata/issues/2981
Reviewing the API definitions, we noticed that our current approach to computing profiling data was not properly synced with the TableProfile definition.
Instead of adding yet-another-step and mapping the results artificially, we have done a refactor on how the profiling data gets computed. We are now relying on a single Profiler object, which is able to compute both table and column metrics and itself handles all the columns in the table.
Its results can then be safely parsed into TableProfile without any issues.
In terms of the JSON Schema, we modified a bit the types of the metrics to better represent the results and added a couple of metrics that were not present and we are already computing. We also changed a few names of the metrics. ⚠ This might have an impact on the UI as well @Sachin-chaurasiya ⚠ However, we still need to work on the UI anyway for this EPIC so we could maybe live with it for a while.
We also added a method to manually name the metrics, which will make it easier to map with TableProfile specs.
An interesting addition is the function add_props in metrics/core. As we now perform the metrics instantiation inside the Profiler, we are passing the class definition as an input parameter. However, there are metrics that require specific attributes such as bins or expression. To have the Profiler as generic as possible and not keep checking specific metrics for individualities, add_props dynamically prepares a new class definition overriding the __init__ method to add any required attribute we pass as **kwargs.
This means that we can run new_hist = add_props(bins=5)(Metrics.HISTOGRAM.value) and new_hist will be a completely independent and new class definition that replicates Metrics.HISTOGRAM.value but will assign bins=5 to all its instantiations.
Happy to discuss!
Thanks

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Ill revert the datatype changes and handle them separatedly as it is a handful

@pmbrull overall LGTM. Left couple of comments. If we don't need numpy lets not include it

also we need to update the sample data


Search in tldr translations?

Hello, How to search in tldr translations using cht.sh command?

Hi! Currently it is not yet possible


New Graph is switching x and y values of my array items

I have an array which represents 49 rows of 91 columns, i.e:
0, 1, 2 .... 90
91, 92, 93 ...181
etc.
I've used a for loop to create temporary rows of 91 called rowArray and then pushed them into an array representing all 4459 cells called wholeArray. If I console.log whole array is looks to be in the same format as the astar demo requires:
0: (91) [1, 1, 0, 1, 1, 1, 0, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 1, 1, 1, 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 1, 1, 0, 1, 1, 1, 1, 1, 0, 0, 0, 0, 1, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 1, 1, 0, 0]
1: (91) [1, 1, 1, 1, 1, 0, 1, 1, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 0, 0, 1, 1, 1, 0, 1, 1, 0, 0, 1, 1, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 1, 0, 1, 0, 0, 0, 1, 1, 0, 1, 1, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] ...etc.
i.e the first array within the array represents the first row of my game grid.
However when I pass this array into new Graph and console.log the graph, I see that astar has switched the x and y values for some reason. Notice above that the first row of the inner array representing x locations (1, 1, 0, 1, 1, 1...) is now represented by an increasing y value (1, 1, 0, 1, 1, 1...). Can anyone suggest a fix for this please?
0: Array(91)
0: GridNode {x: 0, y: 0, weight: 1, f: 0, g: 0, …}
1: GridNode {x: 0, y: 1, weight: 1, f: 47, g: 1, …}
2: GridNode {x: 0, y: 2, weight: 0, f: 0, g: 0, …}
3: GridNode {x: 0, y: 3, weight: 1, f: 49, g: 5, …}
4: GridNode {x: 0, y: 4, weight: 1, f: 49, g: 6, …}
5: GridNode {x: 0, y: 5, weight: 1, f: 0, g: 0, …}
6: GridNode {x: 0, y: 6, weight: 0, f: 0, g: 0, …}
...
function pathFind(cellNumStart, cellNumEnd) {     let wholeArray = [];     let rowArray = [];     let rowNumber = 0;     for (let i = 0; i <= 4458; i++) {         if (level1Array[i] == l11) {rowArray[rowNumber] = 1//grass         } else if (level1Array[i] == l12 || level1Array[i] == l13) {rowArray[rowNumber] = 0//rock 3?         } else if (level1Array[i] == l16) {rowArray[rowNumber] = 0//water 5?         } else if (level1Array[i] == l17) {rowArray[rowNumber] = 0//deep water 0         } else {rowArray[rowNumber] = 0//tree 0         }         if (rowNumber == 90) {             wholeArray.push(rowArray);             rowArray = [];             rowNumber = -1;         }         rowNumber = rowNumber + 1;     }     let cellNumStartXY = convert91by49toXY(cellNumStart);     let cellNumEndXY = convert91by49toXY(cellNumEnd);     let x1 = cellNumStartXY[0] - 1;     let y1 = cellNumStartXY[1] - 1;     let x2 = cellNumEndXY[0] - 1;     let y2 = cellNumEndXY[1] - 1;     var graphWithWeight = new Graph( 		wholeArray     );     console.log(wholeArray);     console.log(graphWithWeight); 	var startWithWeight = graphWithWeight.grid[x1][y1];     var endWithWeight = graphWithWeight.grid[x2][y2];     var resultWithWeight = astar.search(graphWithWeight, startWithWeight, endWithWeight, closest); }
Note that the only slight oddity I can see is that my first array, when console logged, doesn't show commas between each of the inner arrays like in the demo code.

@TameAim Did you resolve this by any chance? I hit something similar


Adds a -H/--with-filename option ala grep, to include the filename in gron'ed output, for when processing multiple files (e.g., within find).

I needed to grep for a JSON value across a large collection of files, and found myself doing find . -type f -exec gron {} \; | grep whatever, but then I couldn't identify which files contained the matches.  grep has a -H / --with-filename option, that prefixes each output line with filename:  fro just such uses (e.g., with grep -r), and that seemed like the right answer.  This change adds that option to gron, using "-" for the filename when the input is stdin.

It's been several years since I created this PR, but if the gron maintainers are interested in mergong it, I'll make sure the changes are compatible with the current source.


gitlab-runner: 10.6.0 -> 10.7.1

Motivation for this change
Update to latest version.
https://gitlab.com/gitlab-org/gitlab-runner/blob/v10.7.1/CHANGELOG.md
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: gitlab-runner
Partial log (click to expand)
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/clear-docker-cache: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/post-install: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/pre-remove: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/scripts/changelog2releasepost: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/scripts/check_race_conditions: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/scripts/codequality: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/tests/test_installation.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/hack/generate-authors.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/982c5nyrssbz41msm8drzzs85abi53cp-gitlab-runner-10.7.1...
/nix/store/lj6ll55y5rzk1092w0c50vdbvly9n3bv-gitlab-runner-10.7.1-bin


Script is not working in lightning component

I get Error when i try to use script in lightning component.

This is because of Lightning Locker Service-- a security feature in Salesforce. It causes implicit global declarations such as this to fail:
var XLSX = {}
The code should really be updated to explicitly reference the window context, since the window reference is preserved in the proxy objects that LLS uses. So, add a line after the above line, like so:
window.XLSX = XLSX
You can do this yourself, but the source should really be updated.

@ldebruyn Is there a way to signal to LLS that a script should be loaded like a CommonJS or AMD module?  https://github.com/SheetJS/js-xlsx/blob/master/xlsx.flow.js#L21134-L21137 ultimately determines how it is assigned, and the implicit XLSX global is only assigned if neither the CJS-style exports / module.exports nor the AMD-style define are available

I am not sure about how LLS works under the hood, but I don't think we need to. I have to deal with it because I am creating web components in the Lightning Web Components framework-- which is basically some extras on top of standard web components all of which are ES 2015 classes.
What I do is load the library up as a static resource and then access it from within a component, as described here (which example uses the D3 library and works fine): https://developer.salesforce.com/docs/component-library/documentation/lwc/create_third_party_library
I think if it just exports an ES 2015 class, similar to D3, it will work fine.

@ldebruyn do you know if the lightning environment defines exports, module, or define?  If not, then we can add that window assignment at the end.

I'm not entirely sure, so for a definitive answer we'd have to communicate with the Salesforce development people. However, there is some information about their security constraints here:
https://developer.salesforce.com/blogs/developer-relations/2017/02/lockerservice-lightning-container-third-party-libraries-lightning-components.html

hopeeeeee guys add window.XLSX = XLSX soon...............

This solution would still not work in LWC as per my experience. To use it in LWC, import it in an AURA and then pass the XLSX as Object into an LWC which works.

@bogdevil13 would you be able to expand on that further?  Is there some SF documentation on how to pull in third party JS libraries?

Salesforce uses something called Lightning Locker for security, and for
some reason it works more strictly on one of their frameworks but not on
the other.
LWC somehow removes the exact same library with the exact same
modifications, while Aura still allows you to import it. The good thing is
that Aura can be a parent component for an LWC ( but LWC is more commonly
used framework ). So the solution becomes to import this library in Aura
and pass the variable *XLSX *as an object to the child LWC component.
To check if your library supports the *Lightning Locker, *I think you need
to match with this document Doc
https://developer.salesforce.com/docs/component-library/tools/locker-service-viewer
and
here is some info on how Lightning Locker works Lightning Locker
https://developer.salesforce.com/blogs/developer-relations/2017/02/lockerservice-lightning-container-third-party-libraries-lightning-components
and here
https://developer.salesforce.com/docs/component-library/documentation/en/lwc/lwc.js_third_party_library
is
how you're supposed to import it in LWC.
On Mon, 9 Aug 2021 at 08:41, SheetJSDev @.***> wrote:

@bogdevil13 https://github.com/bogdevil13 would you be able to expand
on that further? Is there some SF documentation on how to pull in third
party JS libraries?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/issues/1445#issuecomment-894923288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHBOQW2GMEZEMDXP5MYW3DT35BO3ANCNFSM4G4ARF3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

The official guidance on LWC:

If the library isn’t compliant, ask the library maintainers to update the code to comply with Lightning Locker, or, if the project is open-source, contribute the changes yourself. Another option is to fork the repository, make the changes, and build your own version of the library.

Even setting up a basic locker setup requires a SalesForce account of some sort.  There is no simple way for us to investigate this issue further.
If explicitly attaching to window helps, we would accept a PR.  Add the following line near the very end:
if(typeof window !== 'undefined' && !window.XLSX) window.XLSX = XLSX;

e110fe8952629374445c38873244ef7ac7bcc892 added the line and will be available in the next release


Migrated to Swift 4.2 (using autofix)

@Anarchoschnitzel thanks for your PR, really appreciated. But it seems that CI is failing, I'll merge it once that CI goes green. Thanks

Is the CI configured to build with Xcode 10 and Swift 4.2?

Okay I updated the .swift-version to 4.2 and adjusted the .travis.yml to use Xcode 10 and iOS 12.
Would be great if you could have a short look over these changes as I am not that much experienced with travis CI.
However the build is green now. Thanks :)

@Anarchoschnitzel great, thanks a lot for your contribution :)


Revise extending kubernetes

This PR fixes two problems. One was introduced by f265aed794bf30cf5c321941d608a157c9e72a32 which folded the extend-cluster.md content into section index without removing the original content. Another problem is that the PNG images stored on google docs are not accessible by some people from the far end of the planet.
closes: #27440

Preview LGTM

LGTM after rebase too!

Preview of updated pages:
https://kubernetes.io/docs/concepts/extend-kubernetes/
https://kubernetes.io/docs/concepts/extend-kubernetes/extend-cluster/

Thank you for making the images on the extend-kubernetes page more accessible.
/lgtm


cp: Support copying FIFOs with -r

This pull request handles the GNU test cp/special-f, which uses cp -R fifo e to copy a FIFO.
I noticed that this test was not only failing, but taking about 4 minutes to fail, which is an appreciable amount of the total test suite time. If I understand this correctly, uutils ignored the -r flag and tried to copy the contents of the (empty) FIFO instead of the FIFO itself; it kept waiting for something to read until eventually timing out.
Since Rust doesn't natively support copying FIFOs (see issue #1710), I implemented this by creating a new FIFO with the destination name. There's definitely room to improve on this (e.g. copying file permissions), but I experimented a bit and it doesn't seem like GNU's copies are much more than new instances, so I don't think this is too bad.
I'm still pretty new to this project and Rust in general, so let me know if there's a better way to go about this. I'm happy to either revise this PR or close it and create an issue if you'd prefer to solve this another way 🙂

excellent:
Changes from main: PASS +3 / FAIL -3 / ERROR +0 / SKIP +0


Even more search refactoring

Override keyword method in AlertVacancySearch instead of custom
initializer
Rename params to search_criteria
Promote page and per_page to keyword params (they're not really
search criteria) and remove page from the search form
Rename hits_per_page to per_page everywhere for consistency

Review app deployed to https://teaching-vacancies-review-pr-2848.london.cloudapps.digital


3.7 BIRCH (D)

Description
📌  Issues for Week 3
Welcome to 'ML' Team, good to see you here
▶ This issue will helps readers in acquiring all the knowledge that one needs to know about ---- BIRCH
Implement Support Vector Machine without using any standard ML library like scikit-learn or more.
🔴 To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
✔ Domain : Machine Learning
🔴🟡 Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Unsupervised_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

✅ To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Documentation (Coding in .ipynb file, show the implementation)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Please assign this to me

Issue assigned @divya-chhoriya make sure you make the PR within 3 days.


ExtensionLine / DimensionLine complain that start > end

This code is adapted from docs/objects_2d.py:
std = Draft()

# [ExtensionLine]
with BuildSketch() as e_line:
    with BuildLine():
        l1 = Polyline((20, 40), (-40, 40), (-40, -40), (20, -40))
        RadiusArc(l1 @ 0, l1 @ 1, 50)
    make_face()
    edg = e_line.edges().sort_by(Axis.X)[0]
    ExtensionLine(border=edg, offset=10, draft=std)
    outside_curve = e_line.edges().sort_by(Axis.X)[-1]
    ExtensionLine(border=outside_curve, offset=10, label_angle=True, draft=std)

# [TechnicalDrawing]
with BuildSketch() as tech_drawing:
    with Locations((0, 20)):
        add(e_line)
    TechnicalDrawing()

Returns:
ValueError                                Traceback (most recent call last)
     24     ExtensionLine(border=edg, offset=10, draft=std)
     25     outside_curve = e_line.edges().sort_by(Axis.X)[-1]
---> 26     ExtensionLine(border=outside_curve, offset=10, label_angle=True, draft=std)
     28 # [TechnicalDrawing]
     29 with BuildSketch() as tech_drawing:

File c:\Users\someuser\.conda\envs\ocp_vscode\Lib\site-packages\build123d\drafting.py:562, in ExtensionLine.__init__(self, border, offset, draft, sketch, label, arrows, tolerance, label_angle, project_line, mode)
    560     e_line_shape = sweep(line_pen, extension_line, mode=Mode.PRIVATE)
    561     e_lines.append(e_line_shape)
--> 562 d_line = DimensionLine(
    563     dimension_path,
    564     draft,
    565     sketch,
    566     label,
    567     arrows,
    568     tolerance,
    569     label_angle,
    570     mode=Mode.PRIVATE,
    571 )
    572 self.dimension = d_line.dimension  #: length of the dimension
    574 e_line_sketch = Sketch(children=e_lines + d_line.faces())

File c:\Users\someuser\.conda\envs\ocp_vscode\Lib\site-packages\build123d\drafting.py:410, in DimensionLine.__init__(self, path, draft, sketch, label, arrows, tolerance, label_angle, mode)
    406 if label_length + arrows.count(True) * draft.arrow_length < path_length:
    407     shaft_length = (path_length - label_length) / 2 - draft.pad_around_text
    408     shaft_pair = [
    409         path_obj.trim(0.0, shaft_length / path_length),
--> 410         path_obj.trim(1.0 - shaft_length / path_length, 1.0),
    411     ]
    412 else:
    413     shaft_length = 2 * draft.arrow_length

File c:\Users\someuser\.conda\envs\ocp_vscode\Lib\site-packages\build123d\topology.py:7785, in Wire.trim(self, start, end)
   7783     u_start = edge.param_at_point(trim_start_point)
   7784     u_end = edge.param_at_point(trim_end_point)
-> 7785     edge = edge.trim(u_start, u_end)
   7786 elif contains_start:
   7787     u_value = edge.param_at_point(trim_start_point)

File c:\Users\someuser\.conda\envs\ocp_vscode\Lib\site-packages\build123d\topology.py:4609, in Edge.trim(self, start, end)
   4594 """trim
   4595
   4596 Create a new edge by keeping only the section between start and end.
   (...)
   4606     Edge: trimmed edge
   4607 """
   4608 if start >= end:
-> 4609     raise ValueError(f"start ({start}) must be less than end ({end})")
   4611 new_curve = BRep_Tool.Curve_s(
   4612     copy.deepcopy(self).wrapped, self.param_at(0), self.param_at(1)
   4613 )
   4614 parm_start = self.param_at(start)

ValueError: start (0.8165271836783728) must be less than end (0.0)

I have also observed some non-repeatable sporadic behavior in which this fails on the first call to ExtensionLine (in the same way as above). Perhaps the line is reversed at some point?

Running the exact same code, I get a different error.  MacOS and build123d 0.7.0:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[61], line 12
     10     #ExtensionLine(border=edg, offset=10, draft=std)
     11     outside_curve = e_line.edges().sort_by(Axis.X)[-1]
---> 12     ExtensionLine(border=outside_curve, offset=10, label_angle=True, draft=std)
     14 # [TechnicalDrawing]
     15 with BuildSketch() as tech_drawing:

File ~/miniconda3/envs/default/lib/python3.12/site-packages/build123d/drafting.py:562, in ExtensionLine.__init__(self, border, offset, draft, sketch, label, arrows, tolerance, label_angle, project_line, mode)
    560     e_line_shape = sweep(line_pen, extension_line, mode=Mode.PRIVATE)
    561     e_lines.append(e_line_shape)
--> 562 d_line = DimensionLine(
    563     dimension_path,
    564     draft,
    565     sketch,
    566     label,
    567     arrows,
    568     tolerance,
    569     label_angle,
    570     mode=Mode.PRIVATE,
    571 )
    572 self.dimension = d_line.dimension  #: length of the dimension
    574 e_line_sketch = Sketch(children=e_lines + d_line.faces())

File ~/miniconda3/envs/default/lib/python3.12/site-packages/build123d/drafting.py:409, in DimensionLine.__init__(self, path, draft, sketch, label, arrows, tolerance, label_angle, mode)
    406 if label_length + arrows.count(True) * draft.arrow_length < path_length:
    407     shaft_length = (path_length - label_length) / 2 - draft.pad_around_text
    408     shaft_pair = [
--> 409         path_obj.trim(0.0, shaft_length / path_length),
    410         path_obj.trim(1.0 - shaft_length / path_length, 1.0),
    411     ]
    412 else:
    413     shaft_length = 2 * draft.arrow_length

File ~/miniconda3/envs/default/lib/python3.12/site-packages/build123d/topology.py:8020, in Wire.trim(self, start, end)
   8017         if v_edge != 1:
   8018             new_edges.append(e.trim(v_edge, 1))
-> 8020 return Wire(new_edges)

File ~/miniconda3/envs/default/lib/python3.12/site-packages/build123d/topology.py:7819, in Wire.__init__(self, *args, **kwargs)
   7817     obj = wire.wrapped
   7818 elif edges:
-> 7819     obj = Wire._make_wire(edges, False if sequenced is None else sequenced)
   7821 super().__init__(
   7822     obj=obj,
   7823     label="" if label is None else label,
   7824     color=color,
   7825     parent=parent,
   7826 )

File ~/miniconda3/envs/default/lib/python3.12/site-packages/build123d/topology.py:8115, in Wire._make_wire(cls, edges, sequenced)
   8113         raise RuntimeError("Wire is empty")
   8114     elif wire_builder.Error() == BRepBuilderAPI_DisconnectedWire:
-> 8115         raise ValueError("Edges are disconnected")
   8117 return wire_builder.Wire()

ValueError: Edges are disconnected

Changing the problematic code from ExtensionLine to DimensionLine works, but doesn’t generate the desired output, of course:
DimensionLine(path=outside_curve, label_angle=True, draft=std)

@tshead I can confirm that the error message has changed. I am seeing the same error message as you but I am running
a slightly newer development version 0.7.1.dev4+g043629e. There have been some changes to edges/wire trim since this issue was created so I am not surprised the error has changed a bit.

Alright, doing some more investigation, an internal object after being offset is producing a wire with three edges from a wire with one edge. The trim function is having trouble processing the three edge wire, after looking I have determined that running Wire.clean() will reduce the numbers of edges back down to one at which point ExtensionLine will run just fine. I am not sure this is the best general solution and I suspect that the issue may actually lie in the offset_2d method.

@jdegenstein I appreciate you looking into this, but I’m not following you on how to use Wire.clean() in this case - could you expound on that a bit?
Many thanks,
Tim


usage of where result in a view

Hello,
How I can use the result from where which is std::vector< std::vector<size_t> > for 2d array
auto yx = xt::where(imap >= t);
auto test = xt::view(imap, yx);
I get:
error C2440: 'static_cast': cannot convert from 'const S' to 'size_t'
When trying to iterate over it with
auto b = test.cbegin();
auto e = test.cend();

Hi @kingofthebongo2008 I think my initial reply was wrong.
What you're probably looking for is the filter view: https://xtensor.readthedocs.io/en/latest/view.html#filter-views
You should be able to iterate over a filter view with begin / end.
Is that correct?


Converting URLs from HTTP to HTTPS

URLs in README are unsafe. Modifying to HTTPS; I manually checked that all of these URLs are hosted on servers with SSL/TLS support.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Good catch, @JLospinoso . I had not actually noticed that readthedocs.io had HTTPS, very nice.

Cherry-picked, thanks!


🤗 [REQUEST] - CodeQwen1.5-7B-Chat

Model introduction
The model was created by Tongyi Qianwen. It is an instruct finetune of their CodeQwen1.5-7B, which is a coding finetune of their Qwen1.5-7B.
Model URL
https://huggingface.co/Qwen/CodeQwen1.5-7B-Chat
Data type
float16
Additional instructions (Optional)
It can be run by llama.cpp using PR#6707. The HuggingFace Transformers inference code is on the model card, and they have released quantized versions to their HuggingFace account in separate repositories.
Author
No
Security

[X] I confirm that the model is safe to run which does not contain any malicious code or content.

Integrity

[X] I confirm that the model comes from unique and original work and does not contain any plagiarism.

These are the reported benchmarks from their blog post:

added

@ganler Which prompt do you use for evaluating Qwen1.5-7b-chat?

CodeQwen team has this open sourced at https://github.com/QwenLM/CodeQwen1.5/tree/main/evaluation/eval_plus/released/outputs


Linter trigger tsserver error

What did you expect to happen?
When triggering linter occur tsserver issue.
Note: The code is working on isn't in TypeScript I don't know if it really needs the tsserver.
What actually happened?
You can see more in the following gif:

Additional details:

My private config;

Steps to reproduce:
Navigate javascript code and in some variables/methods will show the error mentioned above;
System information:

emacs   version    28.0.50
        features   JPEG TIFF PNG RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS PDUMPER LCMS2
        build      Jul 30, 2020
        buildopts  (--disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp<EMAIL_ADDRESS><EMAIL_ADDRESS>--with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained)
        windowsys  ns
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop f6f90c97 2020-08-20 03:54:44 -0400
        dir        ~/.dotfiles/emacs/.doom.d/
system  type       darwin
        config     x86_64-apple-darwin19.6.0
        shell      /usr/local/bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Sun Jul  5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64 x86_64
        path       (~/Workspace/agriness-presence-frontend/node_modules/.bin/ ~/.emacs.d/bin/ /usr/local/sbin ~/bin /usr/local/bin ~/.emacs.d/bin /usr/bin /bin /usr/sbin /sbin /usr/local/go/bin /Library/Apple/usr/bin ~/Library/Android/sdk/emulator ~/Library/Android/sdk/tools ~/Library/Android/sdk/tools/bin ~/Library/Android/sdk/platform-tools ~/go/bin /usr/local/opt/go/libexec/bin ~/.antigen/bundles/robbyrussell/oh-my-zsh/lib ~/.antigen/bundles/mengelbrecht/slimline ~/.rvm/bin<EMAIL_ADDRESS>config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui deft doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets :emacs dired electric (undo +tree) vc :tools editorconfig (eval +overlay) (lookup +docsets +dictionary) :os macos :tools magit :lang emacs-lisp (go +lsp) json javascript markdown (org +pomodoro +journal +hugo) sh web yaml :config (default +bindings +smartparens))
        packages   ((ob-typescript) (prettier-js) (move-text))
        unpin      (n/a)
        elpa       (n/a)

Note: The code is working on isn't in TypeScript I don't know if it really needs the tsserver.

Despite the name tsserver isn't exlcusive to typescript. It handles javascript and JSX as well.

Navigate javascript code and in some variables/methods will show the error mentioned above;

I cannot reproduce this on Node v10.19.0 and a simple JSX file. Could you include more of the error message? And does your project have a tsconfig.json or jsconfig.json file in it?
This is likely a project config issue. If you'd rather not deal with it, enable :lang (javascript +lsp) and install one of the javascript LSP servers:

https://emacs-lsp.github.io/lsp-mode/page/lsp-typescript/
https://emacs-lsp.github.io/lsp-mode/page/lsp-typescript-javascript/


Support keyed services dependency injection

What problem would the feature you're requesting solve? Please describe.
Keyed services dependency injection was introduced in .NET 8. It appears to be unavailable when configuring services for Azure Functions. Including this feature would be great to have!
Describe the solution you'd like
Add support for keyed services dependency injection (AddKeyedSingleton, AddKeyedScoped, and AddKeyedTransient).
For example, services.AddKeyedSingleton would be available with the following project file and Program.cs
<PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <AzureFunctionsVersion>v4</AzureFunctionsVersion>
</PropertyGroup>

new HostBuilder()
 .ConfigureFunctionsWorkerDefaults()
 .ConfigureServices(services =>
 {
   // Currently unavailable
   services.AddKeyedSingleton<ICache, BigCache>("big")
   services.AddKeyedSingleton<ICache, SmallCache>("small")
 }

Describe alternatives you've considered
Injecting multiple instances of the same class and accessing them through an IEnumerable<>. Implementing a factory pattern.

@wilsjame are you referencing Microsoft.Extensions.DependencyInjection/8.0.0?

@wilsjame are you referencing Microsoft.Extensions.DependencyInjection/8.0.0?

Working now. Was not aware it was a transitive package and NuGet was installing 6.0.0 instead. Thank you!

Hi @wilsjame Could you please post the snippet that how you are using it? I'm getting error as "Microsoft.Extensions.DependencyInjection/8.0.0" assembly not loaded in Function Start-up


1111

Etcher version:
Operating system and architecture:
Image flashed:
Do you see any meaningful error information in the DevTools?

1111111

Closing, as this looks like an accidental submission (?) – if not, feel free to re-open & provide a bit more detail on how we might help


Update property chains for isCousinOf, isMaternalCousinOf, isPaternalCousinOf

See #33.
This PR also redefines isMaternalCousinOf and isPaternalCousinOf; see https://en.wikipedia.org/wiki/Cousin#Gender-based_distinctions.

These property chains would be cleaner if inverses were defined for isBiologicalMotherOf and isBiologicalFatherOf, e.g., hasBiologicalMother.


v2 not up to date

The v2 ref is not pointing to the latest release, which does not contain the latest standalone config documented in the README: https://github.com/pnpm/action-setup/tree/v2

I'll add to this:
this repo does not have any major or minor tags, only full version tags. This is not the recommended way to handle these.
Major Versions and minor versions should be tagged and have that tag move to the latest applicable tagged release along with the full major.minor.patch versions.
So now, with 2.4.0 the tags v2 v2.4 and v2.4.0 should all be on the same commit.

The branch / tag situation has improved, however the v2 branch is at the v2.3.0 release level and does not contain the latest release v2.4.0.

ID type
ID
commit

branch
v2
https://github.com/pnpm/action-setup/commit/0b715c7ebbf3cf2174d1386336c5f6d3d8d5504a

tag
v2.4.0
https://github.com/pnpm/action-setup/commit/d882d12c64e032187b2edb46d3a0d003b7a43598

tag
v2.3.0
https://github.com/pnpm/action-setup/commit/0b715c7ebbf3cf2174d1386336c5f6d3d8d5504a

It looks like releases are handled in a manual way. You might like to consider automating releases so that branches and tags are automatically updated. Using https://github.com/cycjimmy/semantic-release-action is one way to do this.

I am sorry. I have merged master to v2 now.

@zkochan

I am sorry. I have merged master to v2 now.

Many thanks for correcting this! 👍🏻
@privatenumber
Would you like to check? It looks like this issue can be closed now.

Still the case for both v3 and v4.  The missing tags makes that e.g. Renovate Bot does not from v3 to v4.
I can help if possible.

FYI
Official recommendations on versioning:

https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management
https://github.com/actions/toolkit/blob/master/docs/action-versioning.md


Fix KB input for windows

Addresses https://github.com/lsmor/snake-fury/issues/9

Thanks for the contribution!!!


Production management tool

The manual nature of stopping production to avoid losing resources once one has run out is a kill joy. It will only be more emotive when real value is attached to the resources.
If this can't be addressed at contract level, can we add a management tool e.g. that you can schedule a pause transaction in

@credence0x perhaps a solution could be
pass in seconds into the production when starting
Then in contracts we can only produce up to that time


Regression: 'cyclonedx-cli convert' fails to convert an xml to json that is declared as valid by 'cyclonedx-cli validate', worked with 0.25.1

Conversion from XML to JSON fails with cyclonedx-cli 0.26.0, while it works fine with 0.25.1:
PS C:\>cyclonedx-cli --version
0.25.1+03b8019b24e847b6fdc91822eae2e9a220d525fa
PS C:\>cyclonedx-cli convert --input-file test.cdx.xml --output-format json --output-file test.cdx.json

OK!
PS C:\> cyclonedx-cli --version
0.26.0+4f578adff8e1d2b39f7e6c0cddd4d2ea47a7b483
PS C:\> cyclonedx-cli validate --input-file test.cdx.xml
BOM validated successfully.

But convert to JSON blows up:
PS C:\> cyclonedx-cli convert --input-file test.cdx.xml --output-format json --output-file test.cdx.json
Unhandled exception: System.InvalidOperationException: There is an error in XML document (49, 10).
 ---> System.Xml.XmlException: 'Element' is an invalid XmlNodeType. Line 49, position 10.
   at System.Xml.XmlReader.ReadEndElement()
   at CycloneDX.Models.LicenseChoiceList.ReadXml(XmlReader reader)
   at System.Xml.Serialization.XmlSerializationReader.ReadSerializable(IXmlSerializable serializable, Boolean wrappedAny)
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderBom.Read54_Component(Boolean isNullable, Boolean checkType)
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderBom.Read97_Bom(Boolean isNullable, Boolean checkType)
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderBom.Read98_bom()
   --- End of inner exception stack trace ---
   at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, XmlDeserializationEvents events)
   at System.Xml.Serialization.XmlSerializer.Deserialize(Stream stream)
   at CycloneDX.Xml.Serializer.Deserialize(MemoryStream xmlStream)
   at CycloneDX.Xml.Serializer.Deserialize(Stream xmlStream)
   at CycloneDX.Cli.CliUtils.InputBomHelper(String filename, CycloneDXBomFormat format)
   at CycloneDX.Cli.CliUtils.InputBomHelper(String filename, ConvertFormat format)
   at CycloneDX.Cli.Commands.ConvertCommand.Convert(ConvertCommandOptions options)
   at System.CommandLine.Invocation.CommandHandler.GetExitCodeAsync(Object value, InvocationContext context)
   at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass23_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass27_0.<<UseVersionOption>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass25_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__24_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass11_0.<<UseDebugDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__10_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass14_0.<<UseExceptionHandler>b__0>d.MoveNext()
PS C:\code\15.8> cyclonedx-cli --version
0.26.0+4f578adff8e1d2b39f7e6c0cddd4d2ea47a7b483

Test file:
test.cdx.xml.zip

I think this goes back to https://github.com/CycloneDX/cyclonedx-dotnet-library/pull/301. LicenseChoiceList.ReadXml fails to handle the prefix "ns0:".

@schlenk Should be fixed with release 0.27.1.


soundcloud.com

soundcloud.com was recently added to the list.
soundcloud.com appears to be a false-positive, however, the other telemetry links in the blocklist do not. By blocking soundcloud.com it prohibits connecting to soundcloud.com on Desktop, surprisingly not on the mobile apps in the same network.

Thanks for reporting. I've whitelisted soundcloud.com


Implement prime settings

WIP

Fixed CORS on the billing (and athena) server for the deployment previews!

I noticed this one didn't have a design yet, wanted to send some ideas.
I noticed in current connect there are 2 settings button, seems like its because each device has its own little settings. Instead of having 2 separate settings btns, you can switch devices with a dropdown in the account settings page. This would then update the settings page with the relevant info for the chosen device from the dropdown.
The design below doesn't show all the pages but shows the general paths to the different things current connect already offers. I think new-connect should have all settings in one place so it's easier to navigate and find the information you need.
Current design has some space below the Subscriptions settings page which would prob be taken up with a comparison table of the different connect plans if this mock up was for a free plan.
This general settings design has a path for:

a way to change devices via dropdown
unpairing device
uploads queue
dongle id
user id
profile picture
managing devices
support (a page filled with helpful links, and FAQs)

prime settings

device name, current plan, when you joined, next payment, and amount
Update payment button
Cancel subscription

Design v1