strictNullChecks and nullable parameters with defaults

TypeScript Version:  2.2.1
It seems that TS 2.2.1 changed the behavior of nullable parameters (NOTE: null specifically, not undefined) with defaults when compiling with --strictNullChecks.  Was this change intentional?  It's a breaking change.
I imagine this is a consequence of #12033, but AFAICT affecting null was likely an unintentional side effect.
Code
type OptionalString = string | null | undefined;

function hasDefault(val: OptionalString = "") {
  // TS 2.1.6, type of val is OptionalString
  // TS 2.2.1, type of val is string
}

// TS 2.1.6, next line compiled fine
// TS 2.2.1, error TS2345: Argument of type 'null' is not assignable to parameter of type 'string | undefined'.
hasDefault(null);

Expected behavior:
Type of val to be OptionalString (or string | null) and for null to be an accepted parameter.
Actual behavior:
Type of val is string and null is not accepted as an argument to the function.

function f(x = "") { return x.length; }
f("abc"); // 3
f(undefined); // 0
f(null); // ERROR

If you pass in null and it expects a string, you'll have runtime errors.

That's not the same case.  In your example the parameter is not declared to accept null at all.  Try this:
function f(x: string | null = "") {
  return x.length; // Error: Object is possibly `null`
}
f("abc"); // 3
f(undefined); // 0
f(null);

That's how it should work.  null should be accepted, but the function has to check for and handle it.  However, note the different behavior between these two examples:
type T = string | null;

function f(x: T = "") {
  return x.length; // Error here: `x` may be `null`
}

f(null);

Compare to this:
type T = string | null | undefined;

function f(x: T = "") {
  return x.length;
}

f(null); // Error here: `null` is not assignable to parameter of type `string | undefined`

The first issue can be handled correctly, by checking for null within the function.  The latter issue cannot be handled at all, because it incorrectly removes null from the type.

@sandersn @RyanCavanaugh Make sure #14498 also fixes this one.


How to handle can_proceed(transition) == False

Hi,
We currently use transition in what seems to be the expected pattern, e.g.:
if can_proceed(my.transition):
    my.transition()
else:
    raise TransitionCantProceed

The issue with this pattern is that we do not have details about why the transition can't proceed.
It could be because of a bad source state, a conditions == False or a missing paermission.
As far as I can see, there is no obvious way to get the reason why it can't proceed in the else case.
One way would be to create a custom method to check every possible failure. For exemple:
def cant_proceed_transition_reason(self, user):
    if not self.check_some_condition():
        return "some_condition is not met"
    if not user.check_some_permission():
        return "some_permission is not met"
    if not self.state in EXPECTED_SOURCE_TARGET:
        return f"{self.state} not a valid source target for transition"

I find that ugly. Is there a better way ?

See #251 and new module viewflow.fsm - https://github.com/viewflow/viewflow/blob/v2/tests/fsm/test_fsm__conditions.py#L26


CASSANDRA-18422: C* side

@Claudenw pushed feedback or commented addressing why I didn't make changes, let me know if this makes sense to you


Custom type lose if a DataProvider is set in the .md file.

If i insert the 'use' statmeant into the header of a md file the configuration of the custom type used is lost.
e.g the page is not generated with the correct permalink.
More infor at:
http://stackoverflow.com/questions/24235001/sculpin-custom-content-type-is-not-generating

@yakkoroma How recent is your version of sculpin? Have you done a selfupdate recently?

This is my version:
Sculpin version 2.0.x-dev (v2.0.0-1-g57793ee) - app/dev/debug
I downloaded it this week.
There's an update available? Thank you

Actually, scratch that. #193 has not yet been merged. I think that will fix your problem. I'm going to see if I can get someone else to double-check that patch and then merge and rebuild.

Thank you,
if i can help you in some way (maybe testing it on my case?) i am here!
Thanks

@yakkoroma If you are comfortable enough with git to test this PR locally, you can clone sculpin/sculpin, run composer install, and then apply the PR patch locally and see if it fixes your problem for you.
I don't want you to do this if it will be frustrating for you, though. :) If this sounds like something you can handle, go for it, and report back to me if it works or not! If not, I'd suggest waiting until I can get the PR merged and a new phar built so you can simply "sculpin selfupdate" and save you some pain. :)

@simensen I cloned  the repo, applied your patch manually on the file and runned sculpin from sculpin-phar-stub and it worked like a charm form me.
Thank you.

Great! I'll close this for now as I think we'll be merging #193 later today. :) I appreciate your patience and thanks for helping to test it out!


Updates to the Breadcrumb's usage guidelines

Added more robust design documentation along with a v1 Do/Don't table

Hi @tyrasm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Looks great, approved.

Approved!

@tyrasm, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


ROX-11447: write fatal log messages to termination log

Description
Writes all FATAL log messages to /dev/termination-log if that device exists. In k8s, it is used to enrich container status information, and allows us to report better errors through k8s APIs for diagnostics of Collector startup.
Commands for getting this enriched information:
$ kubectl describe pod -n stackrox collector-cr2mf
# ...
    Last State:     Terminated
      Reason:       Error
      Message:      No suitable kernel object downloaded
      Exit Code:    1
      Started:      Fri, 21 Oct 2022 11:50:56 +0100
      Finished:     Fri, 21 Oct 2022 11:51:25 +0100
# ...

$ kubectl get pods -n stackrox collector-cr2mf -o jsonpath='{.status.containerStatuses[].lastState}' | jq .
{
  "terminated": {
    "containerID": "docker://33abaef2f6b18e06e4c8ac8dbb7c3195355faa34b288731203fcbdde7b3a1920",
    "exitCode": 1,
    "finishedAt": "2022-10-21T10:57:09Z",
    "message": "No suitable kernel object downloaded",
    "reason": "Error",
    "startedAt": "2022-10-21T10:56:30Z"
  }
}

This also includes some improvements to FATAL log messages.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
Tested locally on k8s running in Colima (which has the added advantaged of using a kernel for which we don't have a kernel driver for, so collector always hits a FATAL error)

/retest

The two failing tests are timeout flakes, unrelated to this change and from the logs all tests are passing so I'll merge


Disable Sentinel web filters when using Sentinel gateway starters

我们鼓励使用英文，如果不能直接使用，可以使用翻译软件，您仍旧可以保留中文原文。
We recommend using English. If you are non-native English speaker, you can use the translation software.
Which Component
Sentinel
Describe the bug
The web filters (e.g. the Spring WebFlux filter) should be disabled if current application is an API gateway. The URLs should not be marked as resources in Sentinel API gateway flow control (which only supports route and customized API groups).
Additional context
The 2.1.0.RELEASE version

The configuration item spring.cloud.sentinel.filter.enabled can disable web filter initialization.
Maybe we can add the configuration item by EnvironmentPostProcessor in spring-cloud-alibaba-sentinel-gateway module.


Alert for safe files

Background
Run Binaryalert fine
Desired Change
Need it to be able to send an alert if file is clean as well as if it has a virus. is this possible?

Good question. So you want a notification sent to the binaryalert_alerts SNS topic for clean results as well as yara matches? Or would you like to be able to invoke the analyzer directly and have it return Pass/Fail?
Can you describe your use case a little bit to help us understand how best to address this?

Yes so once the file has been notes as 'clean' it would send an notification to the topic that we can use to make the document as available.
Likewise i would like to be able to get a notification what it matches the rules so we can investigate the file.

Good idea - perhaps we could support another SNS topic for "clean" notifications. Users could specify either the same or a different one.
Anything which is an environment variable for the Lambda functions (including YARA_ALERTS_SNS_TOPIC_ARN) is defined in Terraform. In this case, terraform/lambda.tf#106

Yes thats what i have been working on adding so far. Changed it so i get 2 different emails from the same topic but idealy need a new topic. which i have made but its just getting a new thing such as YARA_SAFE_SNS_TOPIC_ARN

Hitting a snag and would be good to get your opinion. Tried committing a branch but its not allowing me too

The easiest thing to do is to fork the BinaryAlert repo. Then you can commit changes to it as you see fit. If you have a branch you'd like to merge upstream (to the original repo), you can submit a pull request.
Does that make sense? So instead of committing directly to BinaryAlert (which is restricted), you can submit a pull request from your own forked repo

It's also worth remembering that the SNS alert format includes a NumMatchedRules top-level key. So another approach (instead of creating a separate topic) is that you could alert the same topic, but set NumMatchedRules == 0, which downstream applications can check.

So i am trying to extract just the terrafrom from this to run in my infrastructure however when i do it the bit i added, to send safe messages, doesn't work. it does when i do all the manage.py etc but not just with the created files, any ideas?

Hi Austin, hope you are well.
i have put my code into this repo https://github.com/goochi1/binaryalert
what is the best way of me sharing with you?

Up to you! I can see your repo, so I can manually merge your change in the next BA release. Or, you can create a PR to merge your add_safe_alert branch into the BinaryAlert master branch:
https://github.com/airbnb/binaryalert/compare/master...goochi1:task/steph_add_safe_alert?expand=1
And I'll review the PR!


Overwrite data in standard error files for individual nodes when re-running

When re-running a case in the same folder, the standard error files generated from the previous run for each node in the logs directory currently append traceback messages which can be confusing.

to clarify it should start with fresh files instead of appending to the old files. Othwise you aren't sure if the error came from this run or the last run

The problem here is "standard out" and "standard error" or just screen dumps.  They are, by definition, always the same place.  That's how command lines are designed. (ARMI, Windows, Linux, you name it.)
The practical problem meeting this request would take is: ARMI is parallel code.  When running massively parallel ARMI simulations, each parallel process can write to standard out and standard error, and we can pump those into text files easily.
But, in order to meet the above request, and still allow parallel code to log directly, we would need to completely revamp how ARMI logs, and remove the idea of "standard" out/error logging.  Which, while possible, would be a decent chunk of work, since many of ARMIs dependencies have a built-in idea of "standard" out/error.  Re-piping all standards to some new locations that know if you've started a new ARMI run is certainly possible, but in practical reality would end up looking like a complete re-write of what "logging" is in ARMI.
I will sleep on it.   But my current gut-check is that I am going to close this ticket.


Expand CI and tests to support GEOS 3.9.0beta2

Supersedes #1041
Two important changes since the previous attempt:

No more awkward version differences for test_create_inconsistent_dimensionality.py
Within shapely.geos, it seems that load_dll('libgeos_c') is required to load geos-3.9.0beta2 on Linux, whereas load_dll('geos_c') was OK to open geos-3.9.0beta1 (and earlier) libraries. Without this change, the system geos_c library would have precidence in loading, despite the value of LD_LIBRARY_PATH.

Coverage increased (+0.1%) to 84.947% when pulling fdc51cf43000107c203266ec9a8ff4bae0d54d17 on mwtoews:geos-3.9.0beta2 into 1dc9230757b08d3debde2172a6af64cc40088da4 on Toblerity:master.


TypeError: Class constructor Object3D cannot be invoked without 'new'

Trying to integrate this beautiful package in my project but it is not working.
I get this error:
Text2D.js:24 Uncaught (in promise) TypeError: Class constructor Object3D cannot be invoked without 'new'
    at SpriteText2D2.Text2D2 [as constructor] (Text2D.js:24:28)
    at new SpriteText2D2 (SpriteText2D.js:21:42)
    at Proxy.created (TextSprite.ts:25:5)
    at callWithErrorHandling (runtime-core.esm-bundler.js:157:36)
    at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:166:21)
    at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:176:21)
    at callHook (runtime-core.esm-bundler.js:3590:5)
    at applyOptions (runtime-core.esm-bundler.js:3492:9)
    at finishComponentSetup (runtime-core.esm-bundler.js:7368:9)
    at handleSetupResult (runtime-core.esm-bundler.js:7312:5)

After googling a bit I believe it is because of an inconsistency in three.js versions of the package and the project's code, and the way es6 modules are written.
My version is: "three": "^0.138.3".
Are you planning on updating the three.js dependency in this package? How can I circumvent this issue? Any help much appreciated. Thank you!

I'm guessing that PR #47 is addressing this issue?


Install fewer files when using bower

Assuming that bower users will consume the dist files, there is no reason for them to have the raw source, the utils or the example when installing. This should reduce the impact a bit.

Of course @Munter, great job! :)


Three-way handshake behavior

[Enter feedback here]
In azure firewall rule processing logic guide,  it mentioned one scenario about "three-way handshake behavior". It is a bit confusing. Why VNET-B to VNET-A return traffic get blocked even we have allowed it from VNET-B to VNET-A?  Does it mean SYN and SYN ACK both will be processed by azure firewall rules?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6392b4a0-fa1e-fe5e-a31b-1eee48b860ef
Version Independent ID: 551028da-b651-30ac-0e77-9ee5eebf6bb0
Content: Azure Firewall rule processing logic
Content Source: articles/firewall/rule-processing.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@yinoa
Thanks for your feedback! We will investigate and update as appropriate.

@yinoa
I followed up internally and this appears to be an expected behavior and is by design.
Azure Firewall doesn’t support explicitly declared bi-directional rules where one side of the traffic flow is allowed while other side of the flow is blocked. (i.e, except for the default DENY behavior).
We are discussing this internally and should be updating the document to provide more clarity soon.
Currently, the statement in the public doc is correct.
Please let us know if you require more details on this.


Draft Data Migration plan using Informatica

[x] Perform Informatica tests

[ ] Update diagrams

Dependency:, NCC (genral), Informatica team, DBAs (NCC)

Will need to understand EASEY Out needs more before this can be completed

Overcome by events


Update dependencies

Hi @felixrieseberg ,
I am trying to fix issue #7 so I've updated the deps and things around. TBH, not sure how this should be done, but it would be great if you could help me out.
Cheers,

@hovancik, it looks good. I'm not sure if the project is still being maintained though.

Well, it updates to use newest versions of packages from the same author, so hopefully yes :)

Ping pong? @felixrieseberg :wink:


docs(#1131): Update issue templates

Closes #1131

Nice! I don't know if this is the right place, but I've seen some projects where they have an option "Question" which links and takes you to the discussion

You mean when you want to open an issue, there is an option (besides bug report, feature request) that says "question", and it takes you to the discussion section?

Yes, I think that's how it worked

I don't remember now.
Here are some examples of how to do it: https://docs.github.com/es/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser.

Got it, now there is a " Rubrix Community Support - Please ask and answer questions here." button.


Version/channel tracking of apps from DHIS2 instances

Since the implementation of release channels we also need to consider a few new things seen from a DHIS2 instance perspective.
An instance is following stable apps by default, but should be allowed to switch channel for a specific app. I.e. running stable for all apps except app X that we want to use from the Development channel.
The questions/thoughts:

How do we track updates regarding the app X from the Development channel?
Should we allow the app X to be installed from both Stable and Development simultaneously side by side?
What should happen when an app change channel in the backend, for example version 1.2 moves from Development to Release, and should we allow it at all?
How do we guarantee deterministic builds? I.e. version 1.2.3 of app X should always be the same no matter which channel it comes from (if published in N+1 channels at the same time)

Me and @varl discussed solutions involving the App management app to store this kind of meta data in the dataStore which app/version/package combination that is tracked from which channel. That way we can query the backend if there are new versions for that app from the specific channel, given that the app does not change name.

What should happen when an app change channel in the backend, for example version 1.2 moves from Development to Release, and should we allow it at all?

I had a discussion with @Philip-Larsen-Donnelly last week where we decided to drop the "promoted versions" flow and align closer to what we have today.

How do we track updates regarding the app X from the Development channel?

Same as with the other channels. App management shows that there is a new version and you have the option to update to it.

How do we guarantee deterministic builds? I.e. version 1.2.3 of app X should always be the same no matter which channel it comes from (if published in N+1 channels at the same time)

Deterministic builds is guaranteed on an artifact level, but the same artifact can be deployed to multiple channels (though probably shouldn't).

Should we allow the app X to be installed from both Stable and Development simultaneously side by side?

Yes, we need to figure out how to differentiate between them though. And if we can limit access to e.g. the development version to a subset of users (administrators, for example).

Thoughts/questions:

Can we start off the new app hub with an empty database? E.g. everyone that wants their app to stay have to upload it again.
We should enable DHIS2 core to present the apps through a versioned URL, both without the /api and with a channel/app version in it

@erikarenhill what is the rational behind point 1? and would it impact 2.34?

@erikarenhill what is the rational behind point 1? and would it impact 2.34?

Me and @varl  discussed this earlier due to there is lots of test/junk- apps in the current database. Also I'm digging around and update the commend above meanwhile so its kind of work in progress/note

OK. My main comment would be that there may be people somewhere who rely on those test/junk apps for some reason and we should avoid the case that things simply disappear because we have updated the platform. At the very least we should give ample warning to the community, and ideally maintain access to as much as possible, even if that means "unclaimed" apps are somehow demoted to relevant channels.

We will somehow make sure the current published apps is available when 2.34 goes live, only unapproved/rejected apps called stuff like "fdasfdsa" or apparant "Hello world" -apps might be lost.


Questions for souce code of enet_b2_8.pt

Could you please share with me the source code to inference with the enet_b2_8.pt model (trained on 8 classes)?

My example src/train_emotions-pytorch.ipynb contains all parts necessary to use the model with 8 classes. You just need to change several lines:

In the 7th cell, uncomment the line
train_dir,test_dir=AFFECT_TRAIN_ALIGNED_DATA_DIR,AFFECT_VAL_ALIGNED_DATA_DIR

and comment the line
train_dir,test_dir=AFFECT_TRAIN_SEVEN_ALIGNED_DATA_DIR,AFFECT_VAL_SEVEN_ALIGNED_DATA_DIR

Replace
if True: # 7 emotions
to
if False: # 7 emotions

and that's all. You can use the inference code in teh "Example usage" section.
Note, that if you do not have an access to AffectNet dataset, you could ignore the first item and simply run the following assignment right after loading enet2_8.pt model:
idx_to_class={0: 'Anger', 1: 'Contempt', 2: 'Disgust', 3: 'Fear', 4: 'Happiness', 5: 'Neutral', 6: 'Sadness', 7: 'Surprise'}

I hope I will add the simplified inference code soon when I complete several experiments with engagement prediction

Sample inference code is added to display_emotions.ipynb


Text to Speech

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
My biggest bottleneck when coding is my typing speed.
I've been using https://github.com/ollama-webui/ollama-webui and find the text-to-speech incredibly useful. Until I can do the same thing in the IDE, it'll probably be faster to copy paste into my browser instead.
Solution
Add a hotkey + button on UI that can start text-to-speech.

Ollama-webui STT is just browser STT (which is mostly OS STT used by the browser). Maybe use your OS's speech recognition?

Same issue here. I accelerated by using the VS Code Speech plugin. It also works offline and there is no context switch between VS Code and the ollama-webui (which currently is the open-webui) any longer required on my end. I am quite confident that enabling the VS Code Speech within Continue would:

separate responsibilities between Continue and the speech recognition in a better way
heavily boost the developer experience
be another USP for Continue

We should also consider if the VS Code Speech plugin can be configured in a way to work with Continue out of the box as it seems to support chat based and editor based speech to text.


Fix ignored reuse_existing in config file

Fix ignored reuse_existing field in config file.
Currently, there is a reuse_existing field in all example config files for evaluation in inference endpoints. See foe example:
https://github.com/huggingface/lighteval/blob/9315f0d4d893050fce4e8b30839330052f4d15d5/examples/model_configs/endpoint_model.yaml#L6
or
https://github.com/huggingface/lighteval/blob/9315f0d4d893050fce4e8b30839330052f4d15d5/docs/source/evaluate-the-model-on-a-server-or-container.mdx?plain=1#L35
However, this field is ignored when parsing the config file because should_reuse_existing is parsed instead:
https://github.com/huggingface/lighteval/blob/9315f0d4d893050fce4e8b30839330052f4d15d5/src/lighteval/main_endpoint.py#L234
This PR fixes this issue by renaming should_reuse_existing to reuse_existing, so that it is aligned with the InferenceEndpointModel parameter name.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Allow thread variable to prevent replica switch

If Thread[:_active_record_shards_replica_off] is set, don't switch to replica even inside the #force_on_replica method.
E.g. when running migrations, we don't want under any circumstances to switch operation to another database. The main problem is that when schema loading is finally fixed (to always use a replica DB), the wrong schema will be used by the migration code to determine whether all meta tables are present on a database.

Actually, this change would make a schema loading query (#columns etc.) be performed on the primary database when called inside a #transaction block. That’s not definitely not what I was after.
We’ll come up with a better solution in #254.


SCB-1317 Set the TxEvent's surrogateId to be null by default

Coverage decreased (-0.04%) to 89.194% when pulling e340a95744afda90529251e97aa194b73f45f011 on SCB-1317 into 5c0d6ae695c92eeede215e7568ac70fe6d32961b on master.


create_table() should give better error for bad schema argument

I stumbled upon this when providing a column name in all caps, but it seems to happen when you provide any bad schema.
good_schema = [{"name": "colname", "type": "varchar"}]
all_caps_colname_schema = [{"name": "COLNAME", "type": "varchar"}]
empty_schema = [{}]

# creates table successfully
dune.create_table(
    namespace = namespace,
    table_name = table_name + "_good",
    schema = good_schema
)

# does not create a table, and does not tell me that the all-caps column name is an issue
dune.create_table(
    namespace = namespace,
    table_name = table_name + "_all_caps",
    schema = all_caps_colname_schema
)

# ditto - same error
dune.create_table(
    namespace = namespace,
    table_name = table_name + "_empty_schema",
    schema = empty_schema
)

Here's the stack trace which is the same for the last 2 cases:
Traceback (most recent call last):
  File "~/path/to/create_table_bug.py", line 21, in <module>
    dune.create_table(
  File "~/dune-pipeline-env/lib/python3.12/site-packages/dune_client/api/table.py", line 83, in create_table
    return CreateTableResult.from_dict(result_json)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/dune-pipeline-env/lib/python3.12/site-packages/dataclasses_json/api.py", line 70, in from_dict
    return _decode_dataclass(cls, kvs, infer_missing)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/dune-pipeline-env/lib/python3.12/site-packages/dataclasses_json/core.py", line 185, in _decode_dataclass
    field_value = kvs[field.name]
                  ~~~^^^^^^^^^^^^
KeyError: 'example_query'

Ya that's definitely an unusual error. Is this something you'd like to take a stab at fixing?


Snippet Styling

Once the functionality is there should look at styling the snippets section.  This includes form controls that currently lack angular2 material components so may be blocked by the changes to that project

closing this as too generic, will make better individual issue tickets


fix Ambiguous occurrence 'defaultTimeLocale'

When I try to install Extra, I get error message as follows. This PR fixes this installation problem.
Resolving dependencies...
Configuring Extra-1.46.3...
Building Extra-1.46.3...
Failed to install Extra-1.46.3
Build log ( /Users/kiwamu/.cabal/logs/Extra-1.46.3.log ):
Configuring Extra-1.46.3...
Building Extra-1.46.3...
Preprocessing library Extra-1.46.3...
[ 1 of 20] Compiling Extra.IOThread   ( Extra/IOThread.hs, dist/build/Extra/IOThread.o )
[ 2 of 20] Compiling Test.QuickCheck.Properties ( Test/QuickCheck/Properties.hs, dist/build/Test/QuickCheck/Properties.o )
[ 3 of 20] Compiling Test.QUnit       ( Test/QUnit.hs, dist/build/Test/QUnit.o )

Test/QUnit.hs:62:8: Warning:
    Pattern match(es) are non-exhaustive
    In a case alternative:
        Patterns not matched: QC.InsufficientCoverage _ _ _
[ 4 of 20] Compiling Extra.URI        ( Extra/URI.hs, dist/build/Extra/URI.o )
[ 5 of 20] Compiling Extra.URIQuery   ( Extra/URIQuery.hs, dist/build/Extra/URIQuery.o )
[ 6 of 20] Compiling Extra.Time       ( Extra/Time.hs, dist/build/Extra/Time.o )

Extra/Time.hs:25:35:
    Ambiguous occurrence ‘defaultTimeLocale’
    It could refer to either ‘Data.Time.defaultTimeLocale’,
                             imported from ‘Data.Time’ at Extra/Time.hs:8:1-16
                             (and originally defined in ‘time-<IP_ADDRESS>:Data.Time.Format.Locale’)
                          or ‘System.Locale.defaultTimeLocale’,
                             imported from ‘System.Locale’ at Extra/Time.hs:9:1-20

Extra/Time.hs:26:45:
    Ambiguous occurrence ‘defaultTimeLocale’
    It could refer to either ‘Data.Time.defaultTimeLocale’,
                             imported from ‘Data.Time’ at Extra/Time.hs:8:1-16
                             (and originally defined in ‘time-<IP_ADDRESS>:Data.Time.Format.Locale’)
                          or ‘System.Locale.defaultTimeLocale’,
                             imported from ‘System.Locale’ at Extra/Time.hs:9:1-20

Extra/Time.hs:27:35:
    Ambiguous occurrence ‘defaultTimeLocale’
    It could refer to either ‘Data.Time.defaultTimeLocale’,
                             imported from ‘Data.Time’ at Extra/Time.hs:8:1-16
                             (and originally defined in ‘time-<IP_ADDRESS>:Data.Time.Format.Locale’)
                          or ‘System.Locale.defaultTimeLocale’,
                             imported from ‘System.Locale’ at Extra/Time.hs:9:1-20

Extra/Time.hs:56:26:
    Ambiguous occurrence ‘defaultTimeLocale’
    It could refer to either ‘Data.Time.defaultTimeLocale’,
                             imported from ‘Data.Time’ at Extra/Time.hs:8:1-16
                             (and originally defined in ‘time-<IP_ADDRESS>:Data.Time.Format.Locale’)
                          or ‘System.Locale.defaultTimeLocale’,
                             imported from ‘System.Locale’ at Extra/Time.hs:9:1-20
cabal: Error: some packages failed to install:
Extra-1.46.3 failed during the building phase. The exception was:
ExitFailure 1

I use ghc 7.10.1 and cabal-install <IP_ADDRESS> on Mac OSX 10.10.3 with Xcode 6.3.

I renamed the "Extra" package because there is another package in hackage called just "extra" - the same code is now in the package sr-extra at https://github.com/seereason/sr-extra.  Could you submit a similar pull request for that package?

...which I still need to upload to hackage...

Sorry for the late reply. I check sr-extra also, but I think it was already fixed this problem 9 days before in seereason/sr-extra@29787ad4c20c962924b823d02a7335da98143603. I think no problem.

Ok!


Falling_Water

This is a falling sand style game that simulates water with an amount of accuracy.
I have made games with unity for a few years, and I made my first website around a week ago. This is my first JavaScript coding experience, and I am pretty happy with the result.

Good game! A game with gravity, interesting

This is just meant to be a cool little experience. It's not really meant to be played with the mindset that you are going to level up and get better at it, it is just something to mess around with.

Thanks for the PR! The code looks very simple for what it does, wow!
Good work!
 It's not really meant to be played with the mindset that you are going to level up and get better at it, it is just something to mess around with.

Ok!

Thank you!


Version documentation

Add branches that represent releases 1.0.0-betaN and start to make changes in each branch to reflect API and other changes that are specific to that release.

Done.


Miscellaneous improvements to commonjs-extension-resolution-loader and pgp-loader

Fixes to get the build passing:

Restore files accidentally gitignored
Add shortCircuit: true to PGP Loader (needed because we’re building in Node 18 now)

Miscellaneous fixes:

Use isBuiltin per https://github.com/nodejs/loaders-test/pull/10#discussion_r979362861
Bump version of commonjs-extension-resolution-loader
Fix misspellings

I’m removing all version bumps from this PR so we can discuss those separately. I’m leaning towards never changing the versions in the package.json files since they’re irrelevant as we’re not publishing these loaders anywhere.


Switch to 'static' library type for SPM

When dealing with SPM , we usually assume static linking.
Since SPM supports resources, there is no need for explicit '.dynamic' type of the library

Eventhough SPM/Xcode claims to figure out the best way, we ended up having some linking issues in the past when not specifying it, we had some issues when using the package from multiple places.
We would have to validate if that maybe has resolved itself by now in case case of this package (but still recently ran into similar problems with another package).
Do you experience any concrete issues due to it being explicitly dynamic?

You can just create 2 libraries in Package.swift: one static and one dynamic, referring the same targets
I've faced with the issue with command-line targets, when I cannot embed the library into the tool

@Alkenso good idea, I created a new PR with that


Add support to add optional parameters in OAuth2 introspection request

Description:
Need to support to add optional/custom parameters in OAuth2 introspection request.
Example: Support to add optional parameters like client_id and client_certificate_thumbprint
POST /oauth2/introspect
HTTP/1.1Host: www.sample.com
Content-Type: application/x-www-form-urlencoded

Authorization: Basic some-token

client_id="some-value"&client_certificate_thumbprint=another-value&token=sample-token&token_type_hint=access_token

https://tools.ietf.org/html/rfc7662#section-2.1

Since those parameters are dynamic values, this cannot be fixed with the existing design. Hence, this will be addressed in future releases.


Improve messages from Bandwidth update code to be programmatically parsed

The messages from console are handled by watchInputs() routine on LCM.
The message is forwarded to JohsAdmin, and watchInputs() will wait till action is completed.

@nakulkar-msft lgtm, seems like there's a flaky test, so I retriggered the CI. Feel free to merge once build is green


action: reflow, switch to download-artifact@v4

Noticed this transitively while bumping deps in https://github.com/di/pip-api/pull/205: we can't bump to upload-artifact@v4 there until this gets bumped 🙂
(I suspect this is a breaking change, since the two use incompatible artifact APIs. So this may require a new v2 series?)

So most changes here change the formatting to delete my preferred YAML style. They have to be reverted with only the functional change to be kept.

Whoops, sorry about that -- I blindly accepted whatever VS Code did here. I'll revert the format changes.

Additionally, another idea was to have an action input letting the end-users choose one or the other. What do you think about the idea of having two uploads? I bet it's even more tricky with actions that wrap artifact downloads.

Yeah, I think this will be tricky in that case. It may also have weird consequences (e.g. I'm not sure if the two APIs share the same storage quota).


Shorter anchor properties

I love how concise Anchorage makes constraint equations. But we could do even better by providing view properties that drop the Anchor suffix and alias the anchor properties. For example:
view.top = container.top + 3
view.edges = container.edges

If interested, I could put a PR together.

Thanks for the feedback. However, Anchorage uses the built-in anchor properties, which are currently suffixed with Anchor. To provide a shorter version without the suffix, we would have to add our own protocol that exposed the shortened variables and called through to the longer ones. I believe this would cause too much confusion for users not sure of which property to use (even though they would both be the same). Hopefully Apple shortens their properties to drop the suffix in a future Swift version  🙂


Revert D44465379: Multisect successfully blamed D44153451 for test or build failures

Summary:
This diff is reverting D44465379
Depends on D44602272
D44153451: [Fabric][Android] Reduce visibility of FabricSoLoader by mdvacca has been identified to be causing the following test or build failures:
Tests affected:

xplat/endtoend/jest-e2e/apps/fb4a/tests/consumerwifi/venice/fb4aVeniceAddressSearch-e2e.js

Here's the Multisect link:
https://www.internalfb.com/multisect/1799601
Here are the tasks that are relevant to this breakage:
We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.
changelog: [internal] internal
Reviewed By: linmx0130
Differential Revision: D44602279

Not needed


chore: release to all package managers in parallel

Fixes https://github.com/awslabs/cdk8s/issues/35
Rather than doing this in the Github actions scripts, we can use concurrently to run our release scripts in package.json in parallel.
Also removes /tools/release.sh as this change replaces that now.
Signed-off-by: campionfellin<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Awesome! I've updated this to be done in the GH workflows, but haven't tested it, as I don't have all those keys/secrets.
Docs here on sharing data between jobs: https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts

Testing on my own master: https://github.com/campionfellin/cdk8s/runs/512186071?check_suite_focus=true
Seeing:
Run npx jsii-release
npx: installed 1 in 1.044s
found maven artifacts under dist/java
❌ MAVEN_STAGING_PROFILE_ID is required
##[error]Process completed with exit code 1.

Run npx jsii-release
npx: installed 1 in 1.167s
dist/java: no maven artifacts
dist/dotnet: no nuget artifacts
found npm artifacts under dist/js
NPM_TOKEN is required
##[error]Process completed with exit code 1.

Run npx jsii-release
npx: installed 1 in 1.207s
dist/java: no maven artifacts
found nuget artifacts under dist/dotnet
NUGET_API_KEY is required
##[error]Process completed with exit code 1.

Run npx jsii-release
npx: installed 1 in 1.299s
dist/java: no maven artifacts
dist/dotnet: no nuget artifacts
dist/js: no npm artifacts
found pypi artifacts under dist/python
Missing TWINE_USERNAME
##[error]Process completed with exit code 1.

Which I think is the closest we can get here to verifying.

@campionfellin fyi, this tweak was needed:
https://github.com/awslabs/cdk8s/commit/ce528cbc6612d77cfaafc3bd729516fd799c81ee

Aha! Did not know about the -p option. I kept getting command not found with just npx jsii-release-maven etc. Thanks :)


Replace from_csv functions with TulipaIO

Pull request details
Describe the changes made in this pull request

List of related issues or pull requests
Closes #702
Collaboration confirmation
As a contributor I confirm

[X] I read and followed the instructions in README.dev.md
[X] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[ ] Tests are passing
[x] Lint is passing

@abelsiqueira Aww I left that note for myself cuz I kinda wanted to do it. :P Oh well - thanks!

Oh sorry, I thought we talked yesterday that I could pick this up. Sorry if I misunderstood. Let me know if you want me to remove it and you can work on it.


Add a Contribution Guide to the Repository

Task: Add a Contribution Guide to the Repository
Description: Create a contribution guide to help users understand how to contribute to the open-source project.
Objective:

Provide clear guidelines for contributors on how to contribute to the project
Encourage community involvement and reduce the burden on maintainers

Tasks:

Create a new file named "CONTRIBUTING.md" (or similar) in the project's root directory
Write a clear and concise introduction to the project and its contribution process
Outline the different types of contributions the project accepts (e.g. code, documentation, testing, etc.)
Provide detailed instructions for:

Forking the project
Cloning and setting up the development environment
Creating a new branch for changes
Submitting a pull request

Include information on coding style, testing, and debugging
Add a section for common issues or known problems that contributors may encounter
Include a section for contributors to report any issues or bugs they encounter while contributing

Deliverables:

A new "CONTRIBUTING.md" file in the project's root directory
A comprehensive guide that outlines the contribution process and provides helpful tips and resources

I´ll do this task @samuelpsouza.


Initial setup for connecting to k8s

Usable crate:
https://github.com/kube-rs/kube

https://github.com/Opensource-idx0k8/K8sIDX/pull/6


Add bool to Check instances

See #22.
This turned out to be a simple 2-line change, I just didn't get to it in time. 😑 I think it's better to have this on check instances because the name seems more appropriate.
I don't have any tests for this, but this such a darn simple change that I don't think I need them. Though I would appreciate any feedback, I don't have much experience with writing libraries.

Codecov Report

Merging #23 into master will decrease coverage by 0.13%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   92.39%   92.26%   -0.14%
==========================================
  Files           3        3
  Lines         644      646       +2
==========================================
+ Hits          595      596       +1
- Misses         49       50       +1

Impacted Files
Coverage Δ

ensure/__init__.py
89.15% <50%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc06600...5da8dbd. Read the comment docs.

This needs a test - could you try adding one?

Should I add a separate test for it or add it to the existing test_basic_ensure_statements?

Either way is fine by me. Probably easier to add it to the existing test.

@kislyuk Done. It's surprising because this did help catch an error. Apparently in Python 2, __bool__ was called __nonzero__.

Darnit, linter errors.

Looks great, thanks.


The directions for updating the milvus.yaml section no longer match the configuration.

Is your question answered elsewhere?

[X] searched the existing issues.
[X] read the documentation.

What is your question?
The milvus.yaml has the section below which is not the same as what's in the doc:
ssl: false
enabled: true # Whether to support ETCD secure connection mode
tlsCert: # path to your cert file
tlsKey:  path to your key file
tlsCACert:  # path to your CACert file
It's not clear to me what needs to be changed.
Anything else?
No response

@scott-nichols May i ask what are you looking for, how to connect to milvus with encryption or how to deploy Milvus with some customized configurations?
one more question is how do you deploy milvus? with milvus helm or operator?

@yanliang567 I am looking for directions on how to enable the provided Milvus docker container with encryption. I tried following the online documentation but was not successful.  I either use Milvus running in docker or an IBM cloud provided version of Milvus which already has encryption enabled.

@yanliang567 I was able to get Milvus encryption working in Docker Compose.  The issue was the wget command documented for 2.2.x pulls down an old 2.2 image of Milvus that doesn't work with the TLS directions.  The easiest fix would be to create a new 2.4 version of the docker compose too. Or put a note in the 2.2 document on how to get the latest version of Milvus.

@scott-nichols thanks for the updates.
@AnthonyTsu1984 could you please help to make a quick fix for the doc
/assign @AnthonyTsu1984

Hey there! The page you visited for Docker deployment is outdated for v2.2.x, and the latest page for v2.4.x can be found at https://milvus.io/docs/install_standalone-docker.md. Despite the deployment page being incorrect, you managed to discover the latest TLS page for v2.4.x at https://milvus.io/docs/tls.md.


Improve "Comparison" page

Per https://twitter.com/andrewingram/status/1333870894490464256:

the docs include another now-familiar comparison table. There has to be a better way of meaningfully comparing alternative solutions in the same space, because comparison tables are fundamentally misleading.

what would make it better?

Honestly, prose.  All tables do is highlight a one-way absence of a feature because you’ll always be biased towards focusing on things you specifically considered in your design choices. By nature they have to be flawed because otherwise you’ll just be constantly adding rows.

Hmmm. Regarding this, we have some various copy that explains the motivation throughout the docs, as well as now a collection of responses we could shape into this. I'll give it a shot tomorrow but will start compiling here as things come up.

With RTK Query, you usually define your entire API definition in one place. This is most likely different from what you see with other libraries such as swr or react-query, and there are several reasons for that. Our perspective is that it's much easier to keep track of how requests, cache invalidation, and general app configuration behave when they're all in one central location in comparison to having X number of custom hooks in different files throughout your application.

there are countless "lifecycle event" and other places to hook into where you can just access state and dispatch actions - for example for authentication purposes
your reducers can just listen to the internal actions of RTK query and adjust their state according to data that it is coming in
it's a bit a philosophical difference to React-Query. Where you define a lot of individual queries in React-Query, you define your API as one unit in RTK-Query. This feels very reduxy and allows you to define stuff like "when a mutation modifies an object, refetch all queries that returned that object" - either only by defining "entityTypes" for these queries & mutations or by going as far as specifying which exact entities are being returned. Also, the central definition makes sure you don't duplicate stuff and offers very good TypeScript support.
where React-Query only works in React, RTK-Query works everywhere Redux would work. For example, we have a Svelte Codesandbox. (edit by matt: partially true - I believe they're working on svelte / vue packages as well)

Tanner Linsley suggests forking React-Query's comparison page and using that as a more detailed basis:
https://twitter.com/tannerlinsley/status/1333941616524939264

Given the public/Twitter comparison to React Query and SWR, I would have forked (at least most of) the React Query comparison table as a starting point. From my perspective, the current version seems way too terse, possibly in an effort to appear on par with the others.

Link:
https://react-query.tanstack.com/docs/comparison

There was an excellent "React Query vs RTK Query" Reddit thread at https://www.reddit.com/r/reactjs/comments/mggpr7/rtk_query_vs_react_query_which_to_use_in_what/ where all three of us chimed in and gave some good comparisons. We should copy that content over here.

I'm closing everything here now. If there's any need for further discussion, that should take place in a new issue over at https://github.com/reduxjs/redux-toolkit/


error when importing...

blender 3.2
importer 1.2.3

@AstrorEnales Thank you so much for your nice and hard work. I use <IP_ADDRESS>(beta) currently, and the model is come from MagicaVoxel's resource repo, you're right, the model maybe generated several years ago with the old version.


python311Packages.google-api-python-client: 2.84.0 -> 2.88.0

Changelog: https://github.com/googleapis/google-api-python-client/releases/tag/v2.88.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235793 run on x86_64-linux 1

4 packages marked as broken and skipped:

python310Packages.oauthenticator
python310Packages.oauthenticator.dist
python311Packages.oauthenticator
python311Packages.oauthenticator.dist

59 packages built:

beancount (python310Packages.beancount)
beancount.dist (python310Packages.beancount.dist)
deja-dup
duplicity
duplicity.dist
duply
fava
fava.dist
gam
gcalcli
gcalcli.dist
git-annex-remote-googledrive
git-annex-remote-googledrive.dist
goobook (python310Packages.goobook)
goobook.dist (python310Packages.goobook.dist)
gyb
home-assistant-component-tests.google_mail
lbdb
ledger2beancount
lieer
lieer.dist
parsedmarc (python310Packages.parsedmarc)
parsedmarc.dist (python310Packages.parsedmarc.dist)
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python310Packages.beancount_docverif
python310Packages.beancount_docverif.dist
python310Packages.certbot-dns-google
python310Packages.certbot-dns-google.dist
python310Packages.drivelib
python310Packages.drivelib.dist
python310Packages.google-api-python-client
python310Packages.google-api-python-client.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.pydrive2
python310Packages.pydrive2.dist
python310Packages.weboob
python310Packages.weboob.dist
python311Packages.beancount
python311Packages.beancount.dist
python311Packages.beancount_docverif
python311Packages.beancount_docverif.dist
python311Packages.certbot-dns-google
python311Packages.certbot-dns-google.dist
python311Packages.drivelib
python311Packages.drivelib.dist
python311Packages.goobook
python311Packages.goobook.dist
python311Packages.google-api-python-client
python311Packages.google-api-python-client.dist
python311Packages.parsedmarc
python311Packages.parsedmarc.dist
python311Packages.pydrive2
python311Packages.pydrive2.dist
python311Packages.weboob
python311Packages.weboob.dist


[e2e]: consolidate operator tests under single suite

Signed-off-by: Igor Bezukh<EMAIL_ADDRESS>What this PR does / why we need it:
virt-operator e2e test suite takes into account that some destructive
actions may be taken during a test, therefore the AfterEach and BeforeEach
Specs have the relevant validations.
there was a test related to virt-operator that ran separately as part
of sig-compute. According the to the logs observed from flakes it looks
that this test affects the subsequent tests, for example when running the
UpdateKubevirtConfigValueAndWait.
test has been moved under the operator_test suite.
Release note:
NONE

/retest

/test pull-kubevirt-build

/retest

/lgtm
/approve

/retest


Allow pinning items to Summary

Allow graphs to be added to (and removed from) Summary page via some user action.

[ ] Capability to add graph item to Summary page
[ ] Capability to remove individual items from Summary page

@shanberg - I get the sense that our customization story has changed for the summary page. E.g. the user may not be able to customize the dashboards that we provide out-of-box, but they're able to create/modify/delete additional dashboards beyond what we provide. Should we close this?

Yep, I think that's accurate. Closing.


Drag and drop from zip-files

Dragging files in to the workspace works flawlessly, or at least untill you try and drag files from a zip-file. It would be wonderful to be able to download libraries and not have to extract them before importing.

fyi @bpasero

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


New logo/icon proposal

Good day Sir I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before i begin my design. Hoping for your positive feedback. Thanks

Hi @mansya... thanks for the generous offer! We actually do have a logo: https://www.textile.photos/

This is a logo project textile ?

It is!

the logo is very good. Do you want to see a new design about this project?

if you think it's good. but I admit your logo is currently very good. :smiley:

I think we're pretty happy with the current logo @mansya 😄

haha. thank you for your contribution sir.


Dressing window remains open after entering command line window

Describe the bug
Problem: I want to close dressing's vim.ui.input window while the command window is open to solve this issue: https://github.com/smjonas/inc-rename.nvim/issues/37. I would expect the window to be automatically closed once command line mode is entered (since that exits dressing's buffer and should trigger the BufLeave autocommand here). Also note that after running the below DressingBug command, calling require("dressing.input").close() has no effect and the window remains in an "orphaned" state.
System information

OS: Linux
Neovim version: NVIM v0.10.0-dev-2992+g2bdef6dd2
Dressing config:

require("dressing").setup{}

To Reproduce
Steps to reproduce the behavior:

Copy the following user command to your config and source the file:

vim.api.nvim_create_user_command("DressingBug", function()
  vim.ui.input("Test", function() end)
  -- Exit insert mode and enter command line mode
  vim.cmd.stopinsert()
  vim.api.nvim_feedkeys(":", "n", false)
 -- Enter cmdline window
  local ctrl_f = vim.api.nvim_replace_termcodes("<C-f>", true, false, true)
  vim.api.nvim_feedkeys(ctrl_f, "n", true)
  -- Leave cmdline window
  vim.schedule(function()
    vim.cmd("q")
  end)
end, {})

Run the command
Exit the dressing window (e.g. with <C-w>w)
Notice that the window was exited but remains open (see screenshot).

Running require("dressing.input").close() also has no effect.
Screenshots

This shows that the cursor is placed outside of the input window which should not be possible.

I put in a fix for this. It seems to work from my testing, but I unfortunately couldn't get a repro to happen in a unit test. LMK if this works for you

Thanks for the quick fix, your patch seems to work fine!


type: oauth2 can have multiple flows, but only the first one is selectable/shown

We probably need to add a dropdown in the UI (where you put the redirect URI, the client id and stuff)
This is the OpenAPI document (@scalar/galaxy):

And this is the UI:

Done!


openstack-addons: improve openstack addons

What this PR does / why we need it:
Small improvements of the openstack CCM/CSI addons found to be useful during 1.3.0 testing

add control-plane toleration to CSI
improve toleration to CCM

openstack-addons: improve openstack addons

@kron4eg Should we cherry-pick this change to the release/v1.3 branch? It seems useful.

/cherrypick release/v1.3


Keyboard ESC keyCode is Incorrect.

In version 2.0.1 (and possibly earlier) I have found that the keyCode mapped to ESC for the Keyboard is currently 127 which is NOT the ESC key. The correct ESC keyCode is 27. This is something that really needs to be fixed quickly. As anyone using the cdn hosted library is unable to use the ESC key in their game without jumping through hoops to manually add event listeners themselves.

This issue has been fixed on release 2.0.2. Thanks for reporting and submitting the fix, @RichardMarks!


support WASI

This issue/discussion is for adding WASI binary support for Wanix. Currently Wanix can only run binaries compiled by Go for the js runtime (not wasi, not any other language).
One initial concern was that the WASI interface is not async. In the original single-threaded Wanix prototype, this would make it impossible since our implementations of most of this interface are async. However, now that processes run in their own Web Worker, we could do async calls from there and block with a loop until we get a response. That is really the only option for native integration.
Here is an example WASI shim for running WASI directly in the browser with example implementations for most of the interfaces (but most importantly this shows what their signatures look like.. synchronous):
https://github.com/bjorn3/browser_wasi_shim/blob/main/src/wasi.ts
Another approach is to run wazero in the kernel. I've already verified simple WASI programs can be run in wazero embedded in a binary compiled for JS and run in Wanix. Wazero being implemented in Go allows it to implement "blocking" WASI functions but still yield to the Go and JS runtimes. Yes, this is WASM in WASM and will incur performance hit, but it's also probably the quickest path for at least a temporary proof of concept.

Yea, we run any user executed wasm binary now in web workers as a process, so the same with WASI. Unless we run Wazero to run WASI, which would run in the kernel in that one web worker. If we don't run Wazero to run WASI (which would be wasm in wasm), we'd run them in web workers and that would allow us to do a blocking loop. Not quite a global lock, but global to that worker, sure.


[Steamless] File missing expected '.bind' section!

I was following this guide to try and datamine PAYDAY 3's closed beta while it's out. I got as far as using Steamless to remove the DRM, but it seems to not be working. I tried leading it to the Shipping.exe file and the Win64 folder, but neither worked. Directing it to the folder spat out a basic 'file not found' type error, and directing it to the Shipping.exe file spat this out in the log. The location of the exe looks like this by the way.

Hello, thanks for creating an issue.
This means that the SteamDRM is not in place. Thus means you can continue with the AES 256 Key Mining as normal. But just without this step. So you can search for your keys without needing to remove any DRM.
If you're still experiencing issues after this response, I would reccomened researching how to use the gold leaf emulator. Or asking around in the UE4 Modding Community if your issue is still unresolved.
Note: Payday 3 is a newer game, which might means it might prevent kwy extraction or have its own custom DRM that we as modders are unsure about.

Closing the issue as the Original Poster is not responding.
Assuming the problem is fixed, will allow reopening if applicable.


Add importize method to Resolve

A new method importize is added to the Resolve. This is to allow to mutate the Resolve to state where it would resemble what a consuming component would expect to see during composition.

I've rebased this on https://github.com/bytecodealliance/wasm-tools/pull/1785 and https://github.com/bytecodealliance/wasm-tools/pull/1782 to get better assertions as well as better testing utilities. With that I've added an "Updates to importize" commit which updates the method of doing this slightly and adds a few more tests as well. My hope is that it's a bit more robust to conditionally preserve imports instead of throwing them all away and recreating them. I've then also hooked this up to fuzzing.
@karthik2804 one thing I'm not certain of is that the design currently is to mutate the world in-place. I updated this to rename the world by adding -importized as a suffix, but that probably isn't great. Do you think that the name matters for the tooling integration you were envisioning? For example would it be better to create a new world and insert it into a provided package?

I do not have strong opinions here. I do not think the name of the world should not matter.

Ok in that case let's leave this as-is and see how it works out.
Given that this is co-authored by me and @karthik2804 I'd prefer to not approve-and-merge, so @dicej I'm going to tag you in for a third set of eyes on this to make sure nothing looks too awry.


Feature Proposal: Possibility to cut zeros after coma for NumberFormat

On the page https://britecharts.github.io/britecharts/tutorial-step.html we can see that there are numbers on the Mini-tooltip "300.00", "250.00" etc, here can be also 5550.50 (so as on Tooltip). Why not "300", "250" and "5550"? This way, we can have a more space to place an integer part of the number.
Expected Behavior

We have extra zeros after coma, which can be hidden and not displayed. We can change the numberFormat (.0f), but this way for the number 5550.50, for instance, there will be loss in information in the fractional number part.
Difference from Current Behavior

We must see "250" instead of "250.00", but if there is also a number here like 5550.50, it should be written this way: "5550.5".
Possible Implementation

Example Screenshots (if appropriate):

Context

Yes, this is already available.
On the Mini-Tooltip API () you can use .numberFormat to set it to "". That way we'll remove the two zeros.


Value of ${applicationId} ?

Whats the value of ${applicationId} ; if I enter the App Id from AppCenter it gives error in build since it contains "-"
Tried putting App Id ie mobilesdk_app_id from firebase but it contains ":"  ; that errors too.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed528dcd-ecaf-697e-c64a-30651d26ff3d
Version Independent ID: 1e92bbb4-5800-6d31-51ee-c6d5864801d1
Content: App Center Push for Xamarin.Android Apps - Visual Studio App Center
Content Source: docs/sdk/push/xamarin-android.md
Service: vs-appcenter
GitHub Login: @elamalani
Microsoft Alias: emalani

I left it as is. it worked like a charm :p

@pmahend1 The comments feature of our documentation is intended to enable customers to suggest changes to the docs or ask clarifying questions about the docs.
App Center support is provided directly from within the App Center portal. Any time you need help, just click the blue chat button in the lower-right corner of any page and our dedicated support team will respond. For additional information, see the App Center Help Center.
I'm curious whether you included the quotation marks, you didn't provide an example of what you did.

You have to use ${applicationId} as is and not replace it. The build system will replace it for you (with the package name).

Where I can get ${applicationId}. From AppCenter or Cloud Messing Firebase?

I think ${applicationId} is Android App Package!


Use git describe for finding operator version

We need to be able to set the replaces attribute of the CSV file so
that OLM can build a relationship between dependencies, which is
important for disconnected installations and upgrades.
Previously, we were using the version in the CSV file, which worked but
it would change within the make prepare-release target depending on
when the command was invoked.
This commit updates the version script to use git describe instead,
which makes finding the current version more robust since tagging isn't
done until a subsequent step of the release process.

/hold for test

/unhold

/label qe-aprroved

/retest-required


Changes to build in MacOS

I just made minor changes to the makefile so that this can be built in MacOS.

src/fifo-sem.c:166:9: error: call to undeclared function 'sem_timedwait'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (sem_timedwait(&fifo->full, &tm) != 0)
^
src/fifo-sem.c:166:9: note: did you mean 'sem_trywait'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/semaphore.h:58:5: note: 'sem_trywait' declared here
int sem_trywait(sem_t *);
^
4 warnings and 1 error generated.
make[1]: *** [.objs/fifo-sem.o] Error 1
make: *** [boruvka] Error 2
I am trying to make it but it shows this error even after changing the makefile , please solve it .

This discussion seems to provide possible alternatives for MacOSX:
https://stackoverflow.com/questions/641126/posix-semaphores-on-mac-os-x-sem-timedwait-alternative
Can you try whether any of them work and report back?

Also, are you using the g++ implementation from home-brew?

I cannot figure out how to test this branch: when I try to update the cpddl submodule I get this error:
rpg@rpg-mbp182: ~/src/pandaPIgrounder $ git submodule update
fatal: remote error: upload-pack: not our ref fb4bf051399f16dff6e833eafbed89d93e2a4c72
fatal: Fetched in submodule path 'cpddl', but it did not contain fb4bf051399f16dff6e833eafbed89d93e2a4c72. Direct fetching of that commit failed.

You need to update the master. Updating the submodule is a "local" operation that usually interferes with the main repo.
What you want to do is to add the repo of Felipe as a new remote and then merge his master into your local master.

My pull request is pretty harmless, I think it could easily be merged to make the lives of other Panda users easier.


[Feature Request] Add Ability to Stop a Vacuum

The Wyze-SDK doesn't support stopping the vacuum, only pausing it. Once stopping is supported the ability to stop the vacuum from Home Assistant should be added.

I've added a workaround to allow the vacuum to "stop" but it's just doing the same action as "pause". I will keep this issue open for a while and if Wyze-SDK supports stopping I will add this feature.


XamlAnimatedGif in DataGrid: No imaging component suitable to complete this operation was found.

Hello Thomas, it's me again. I got another hard one for you.
I'm getting an exception thrown when I put the XamlAnimatedGif control in a DataGrid column template and use the SourceStream property as soon as I scroll down in the DataGrid.
I thought it was about the WPF panel virtualization feature causing problem, but I don't have any problem when they are in a listbox (also virtualized). I also don't have any problem when I use an URI instead of a Stream.
{"Exception from HRESULT: 0x88982F50"} No imaging component suitable to complete this operation was found.
   at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
   at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
   at System.Windows.Media.Imaging.BitmapImage.FinalizeCreation()
   at System.Windows.Media.Imaging.BitmapImage.EndInit()
   at XamlAnimatedGif.AnimationBehavior.<InitAnimationAsync>d__44.MoveNext()

The error stack seems to point in libraries internal to Microsoft. I also found on Google many instance of this HRESULT code, some are because the file is of an unsupported format, or corrupted. Others point out it might happen when a different thread than the UI thread is used to create the bitmaps.
Code to reproduce:
MainWindow.xaml.cs:
using System.Collections.ObjectModel;
using System.Globalization;
using System.IO;
using System.Threading;

namespace Gif
{
    public partial class MainWindow
    {
        public MainWindow()
        {
            DataContext = this;
            InitializeComponent();

            for (var i = 0; i < 10; i++)
//                ItemList.Add(new RowModel { Anim = new Uri(new FileInfo("animated.gif").FullName) });
                ItemList.Add(new RowModel { Anim = new FileStream("animated.gif", FileMode.Open, FileAccess.Read) });
        }

        private ObservableCollection<RowModel> _itemList = new ObservableCollection<RowModel>();
        public ObservableCollection<RowModel> ItemList
        {
            get { return _itemList; }
            set { _itemList = value; }
        }
    }

    public class RowModel
    {
//        public Uri Anim { get; set; }
        public Stream Anim { get; set; }
    }
}

MainWindow.xaml:
<Window x:Class="Gif.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:gif="https://github.com/XamlAnimatedGif/XamlAnimatedGif"
        Title="MainWindow" Height="350" Width="525">
    <Grid>
        <DataGrid ItemsSource="{Binding ItemList}"
                  AutoGenerateColumns="False">
            <DataGrid.Columns>
                <DataGridTemplateColumn Header="Animation">
                    <DataGridTemplateColumn.CellTemplate>
                        <DataTemplate>
                            <Image gif:AnimationBehavior.SourceStream="{Binding Anim}"
                                   gif:AnimationBehavior.RepeatBehavior="Forever" />
                        </DataTemplate>
                    </DataGridTemplateColumn.CellTemplate>
                </DataGridTemplateColumn>
            </DataGrid.Columns>
        </DataGrid>
    </Grid>
</Window>

You can change the two commented lines to use an URI instead of a stream (and rename SourceStream to SourceUri in the xaml) and it works fine.
I thought maybe the different file stream had problem accessing the file at the same time, so I tried to load multiple byte[] and creating different MemoryStream instead, but no I get the same problem.
I know this might be a bit complex to resolve, and might be a bug internal to Microsoft unrelated to your lib. But using normal Image controls with jpg in a DataGrid works fine. I'm stumped and don't know where else to look, so any insight from your part will be very appreciated.
Thanks again!

Hi @Dunge,
Thanks for the report.
According to the stack trace, it seems to be happening here, which means it has already failed to decode the stream as an animated GIF and is trying to fall back to decoding it as a simple non-animated image. But seeing this code again, there's an obvious bug: the stream is not rewinded, so it's not at the beginning and can't be used to decode the image... Also, the fallback decoding should be done in a try/catch, since it can fail.
This leaves the question of why it ended up in the catch(InvalidSignatureException) block in the first place... I'll try to investigate further when I find the time.
(I have a suspicion that the binding happens more than once... does the error still happen if you move DataContext = this to the end of the constructor?)

(I have a suspicion that the binding happens more than once... does the error still happen if you move DataContext = this to the end of the constructor?)

Yes it does, the error occurs when using the scrollbar of the DataGrid, but the first opening of the Window the first view works fine. You are probably right that the binding happens multiple time, but that's a behavior internal to the DataGrid control for optimization, not in my sample code.
Thanks for the investigation, I admit I hadn't even tried to load your source code to see where the problem occurs. I just did, and yes, adding a stream.Seek(0, SeekOrigin.Begin); in the InvalidSignatureException catch block remove the error, but nothing get displayed.
I put a breakpoint at the place the InvalidSignatureException is thrown, and yes it works the fine time, and then it comes back and the stream cursor instead of being at position 3 after reading 'GIF', is at position 9014. Like the previous issue, probably two threads or two bindings trying to read the same stream simultaneously.
I'm having a hard time trying to debug with async calls. When the error happens, I can return up the stack to the InitAnimationAsync method, but I'm unable to see what's calling it. When I put a breakpoint there, I can see it's often called from the Image_Loaded event, but then it don't crash.

OK, I reproduced the issue, and I think I know what the problem is: it's because the same stream is bound to a different Image control. Each Image has its own Animator, which seeks and reads the stream independently.
Actually, I'm not even sure this should be considered a bug; there's no way to make it work with multiple images bound to the same stream, for the same reason you can't use a stream from multiple threads.
In your case, disabling virtualization fixes the issue, but I realize it's not ideal... Another approach that would work would be to return a fresh stream every time the Anim property is invoked; this would ensure each stream is used only once.

Quote from my original post:

I thought maybe the different file stream had problem accessing the file at the same time, so I tried to load multiple byte[] and creating different MemoryStream instead, but no I get the same problem.

Haven't tried debugging to see if it crash exactly the same way, but I'm sure it's not working.

@Dunge I think you misunderstood what I was suggesting. With the approach you describe, it's still possible for multiple Image controls to be bound to the same RowModel, and thus to the same stream. What I was saying is that the Anim property could return a new stream every time it's called.
However, I just tried it, and I still get the same error, so maybe my theory was wrong... I really don't know what's going on 😕


feat(cli): add --write, --fix and --unsafe options to fixable commands

Summary
Closes #2267
Add --write, --fix and --unsafe options to biome check and biome lint commands.

--apply -> --fix or --write
--apply-unsafe -> --fix --unsafe or --write --unsafe

Add --fix option to biome format and biome migrate commands.
biome <lint|check> --<fix|write> [--unsafe]
biome format --<fix|write>

⚠ NOTE

--unsafe should be used with --fix or --write.
--apply and --apply-unsafe cannot be used with any --fix, --write, --unsafe
currently --unsafe --fix and --unsafe --write is allowed, iow it doesn't care the order

Test Plan

[x] unit tests for functions added
[x] snapshot tests

remained

[ ] Update docs in website repo
[x] CHANGELOG.md
[ ] deprecate --apply and --apply-unsafe, it will be removed in biome v2.0

I'll create another PR to deprecate them, because of the number of file changed

@unvalley this is a reminder for you: we'll have to update the website to use these new options instead of the old one.
Also, the changelog doesn't say anything about the deprecation of the old CLI options

@ematipico As for deprecation, I created a new PR #2918


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependabot-updates.
For more information see the "Dependabot updates" workflow.
To-do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report

Merging #170 (26c6050) into master (c6d56a6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   68.62%   68.62%
=======================================
  Files          18       18
  Lines         494      494
=======================================
  Hits          339      339
  Misses        155      155

Flag
Coverage Δ

pytest
68.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

app/routers/triplestore.py
46.15% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ExpressionSet constructor

Hi
I want to construt an expression set object from our own metaphlan2 and humann2 results so that we can convert it to phyloseq with phylogenetic tree and play all the downstream analysis.  Just wonder if there's any method allowing me to do that?
Thanks,
hh1985

There is now a new package that should make this easier, but it returns a list of matrices rather than an ExpressionSet: https://github.com/schifferl/curatedmetagenomicdatapipeline
This issue will include testing and documenting this.

@schifferl I'm adding you just to update the documentation at https://github.com/waldronlab/curatedMetagenomicData/wiki/The-curatedMetagenomicData-pipelines#curatedmetagenomicdata-generating-pipeline when ready.

TreeSummarizedExperiment and mia have converter functions to and from phyloseq https://github.com/FelixErnst/mia/tree/master/R

If the goal is just to create a phyloseq object, you could also use methods from the phyloseq package. I think you can do what you want now using https://github.com/waldronlab/curatedMetagenomicData/wiki/The-curatedMetagenomicData-pipelines#curatedmetagenomicdata-generating-pipeline, but soon you'll have to use old versions of this repo because we are moving everything to MetaPhlAn3 and HUMAnN3.

Part of #165

In cMD 3.0.0 this will be covered by a vignette, rather than the wiki. There is an issue (#218) for the "Version Three" vignette, which will provide these instructions. The wiki has been disabled but I've saved the pages. If @hh1985 wants to build cMD 1.X.X style output the instructions are attached, and the "legacy" branch would need to be used. If a phyloseq object was desired in the end, I would start there instead and construct one without going through the effort of making an ExpressionSet. I am closing the issue because it will be resolved by #218 instead, or could be resolved with the other solutions listed here.
The-curatedMetagenomicData-pipelines.md

Good plan, @schifferl.


Ability to check if a router has any pages to go back/forward to

What problem is this solving
I'm building an app where routers (and their views) are placed within virtual windows within the app. The windows have their own back/forwards buttons and it seems that I have no way of knowing if there are any pages to go back or forwards to.
Proposed solution

Exposing extra methods on router/history could be very useful (e.g. canGoBack, canGoForwards).
Another option would be adding some kind of indicator to what happens to history state in listener callbacks, so I can track a counter myself.
Or give access to the full browser history stack (which I guess is only an issue for the memory history), but a simple number or boolean would suffice for my use-case.

Describe alternatives you've considered
I looked in the API docs and couldn't find any useful methods/fields on the router/history.

This has been requested before. There is no native api to check for that but you can write to history.state after each navigation to create the behavior you want


TTL in seconds, not minutes

The screenshot  shows TTL 60, and the instructions are to set TTL to 60 minutes. DNS TTL standard uses seconds as unit, so either the screenshot is wrong or the instructions are. If Azure AD checks the TXT record just once to validate domain ownership, I propose to change the instructions to use 60 (seconds).
If the check will be performed at a regular interval (you don't want de overhead of a check every minute) , then use 3600 seconds (1 hour) and discard/modify this patch.

@javierruizjimenez : Thanks for your contribution! The author, @eross-msft, has been notified to review your proposed change.


Support complex decorators

DraftJS supports more than just simple { strategy, component } decorators, specifically it supports anything matching the DraftDecoratorType:
https://github.com/facebook/draft-js/blob/0c609d9d3671fdbbe2a290ed160a0537f846f08e/src/model/decorators/DraftDecoratorType.js#L25-L45
As you can see, decorators can also be objects that look like this: { getDecorations, getComponentForKey, getPropsForKey }. (I think interally the { strategy, component } composite decorators are converted to that more complex form)
This type of decorator is (for example) used in the draft-js-prism decorator, but also in many other libraries. It'd be great if redraft supported that!

This is something worth looking into! Would like (thought it might be bit tricky) to handle it same way as draft does it internally as you suggested.
This would probably mean that by supporting rendering with any DraftDecoratorType it should be possible to just fallback to drafts CompositeDraftDecorator ( https://github.com/facebook/draft-js/blob/0c609d9d3671fdbbe2a290ed160a0537f846f08e/src/model/decorators/CompositeDraftDecorator.js ) to render an array of { strategy, component } decorators.

Yep that sounds great!

Guess I have a working version. :smile:
Some things are still missing like contentState. It should be passed both to DecoratorComponent and the getDecorations method of the Decorator class.
Additionality it adds draft-js as a dependency and I'm not sure if that makes much sense as redraft was supposed to provide an alternative way to render draft-js raw. Either I could include a simplified CompositeDraftDecorator in redraft (with no Immutable.js etc...) or go all the way include draft-js and fix most inconsistencies with the draf-js api.
Also should probably add some test cases with a custom Decorator class passed through options.

Niiice!
I'd certainly prefer if it didn't include Draft as a dependency, but obviously building your own implementation of CompositeDraftDecorator is going to be a bunch harder... :thinking:

Actually the CompositeDecorator doesn't depend much on the rest of the draft-js so implementing it in redraft was just basically swapping the List for a stub with a toArray method.
I decided to put flow types along with it to keep the differences as minimal as possible. (Might also be a good idea to add flow to the rest of the project.)
Lastly since redraft was missing ContentState to pass into getDecorations and decorator components I added an option to pass draft-js convertFromRaw into redraft options.
Still need some tests.

Awesome, that's great! Can't wait for this to land, amazing work :clap:

Added some minimal testing and shipped it in 0.9.0 :tada:

Amazing, thank you! :tada:


Add new fall damage mixin for planet gravity

This should work for every celestial body, dynamically. Because of how the calculation is set up, Earth fall damage stays the same.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oops, thanks :)


Not working with kendo controls

I have used BeginCollectionItem with kendo controls but not giving proper name to the kendo elements. working fine with other elements. whereas asp.net mvc version for begincollectionitem is working fine but core version is not working.
I have used .Net 5.0 framework.
For more detail I have posted the issue in stackoverflow site.
https://stackoverflow.com/questions/70498065/asp-net-core-begin-collection-item-core-not-working-with-kendo-controls
Found the solution issue with kendo control render and solved and posted solution on above stackoverflow site.

Found the solution issue with kendo control render and solved and posted solution on above stackoverflow site.


Error in translation

Hi Infer Team,
Infer translates the following code
int arr[10];
int y = sizeof(arr);

to
*&y:int=sizeof(unsigned long) [line 3]

Thanks for the report(s)! (I think it would be better to open one issue for each problem if you can)

Looks like a bug, thanks!
Correct, but what is the problem here? Does that lead to incorrect analysis results?
Same as 2). Is your C source missing some code, like z = y?

Hi @jvillard ,
I will open the second one as a new issue.

Should be fixed in fe01f47e418d2030ba701621a34288e6231b72a8

That's a good news!


Fix for Issue #7

Get an error on a missing EZ method in Toaster. Left a FIXME.
Fixed subscriptions to single devices by adding on the "/events" path piece in EventsDelegate's URI builder.

Not sure why all those .iml files got pulled into this. I can resubmit if necessary.

Nice catch, thanks for the patch!
  If not, it's available here: https://goo.gl/fGM9KD

Just did. Really excited to have this working. I just got a second Photon and am looking forward to experimenting further.

Merged.  Thanks again @reddigfabian !


Use host max log level when initializing the RuntimeLogger

This should fix performance problems introduced by logging under certain
circumstances. Before we always called into the host and the host was
doing the log filtering, now as the correct max log level is set, we
don't call into the host for every log line to check if it should be
logged. However, we would still call into the host to determine if
something should be logged when something=trace is given as we don't
forward the log targets that are enabled.

@athei could you test if this fixes your benchmarking problem?

Fixes https://github.com/paritytech/substrate/issues/8611

bot merge


Get rid of deprecation message

As suggested by https://github.com/nisaacson/pdf-extract/issues/16 (not sure why @gubi didn't do it)

thanks @mchapman, can you change the variable name to util from sys where it is used in the file please?

@nisaacson should be good to go now


[BUG] Typescript const enums do not get inlined

It's related to snowpack version: 3.2.2 but I assume it's an underlying problem related to any version of snowpack.
I have a typescript definition d.ts file types.d.ts:
declare const enum Option {
  One = 1,
  Two = 2
}

And trying to use this declaration in a regular source.ts file:
/// <reference path="types.d.ts" />
const option = Option.One;

The expected output should be:
const option = 1 /* One */;

But instead I got:
const option = Option.One;

And of course if I try to run the bundle in a browser I got an error that there's no Option.One declaration.
I used to bundle apps via webpack and ts-loader and there's no such problem. Somehow snowpack doesn't respect const enums. If there's a possible workaround it'd be nice to know.
There's a related discussion started https://github.com/snowpackjs/snowpack/discussions/2624. Looks like the same problem I got.

Yup, I believe that this is a limitation of esbuild and not something that we could support ourselves.
However, I think using import {Option} from 'types.d.ts' instead of /// <reference path="types.d.ts" /> should solve this problem, since Option would then exist as an imported value. It wouldn't be inlined, but it would work!


Exclude directories under extracted-include-protos and extracted-protos when Gradle plugin is applied together with IDEA

We need to make working with Protobuf source files more convenient when it comes to working with dependencies.
The problem in details
Proto files of dependencies are copied to build/extracted-protos and build/extracted-include-protos directories into subdirectories corresponding to source sets which depend on them. These subdirectories appear as valid source sets in IntelliJ IDEA because they are not explicitly excluded. This, in turn, make proto files in these directories appear in search as many times as corresponding dependency is used in the modules of the project.
This is especially inconvenient when you need to find a file to modify. You can open a file under build/.../ modify it and then expect changes in the generated code. This would not happen because the changes would be deleted on the clean command because the changes were made under the build directory.
What we need to do
The ProtoData Gradle Plugin is the best place we can help the user with the current inconveniences related to extracted-protos and extracted-include-protos directories.  The plugin should analyse if it's applied to the project where IntelliJ IDEA Gradle plugin is also applied. If so, it should mark directories under extracted-protos and extracted-include-protos as also excluded.

Addressed by #293.


After sending coins macOS version crashes.

Upon sending coins to an address the program crashed and continues to crash after every sync.

Hey @SMKultra, we are not able reproduce this crash on macOS.
Can you please provide BCA logs (debug.log snippet) at the time of the crash and a system-generated report text?

Please update your macOS build to the latest v<IP_ADDRESS> and let us know if it continues crashing.

No additional input on this issue.
Can you please let us know if the issue persists on macOS?

Issue resolved upon update!
Thanks!

From: rootSig<EMAIL_ADDRESS>Sent: Thursday, April 12, 2018 5:19:09 PM
To: bitcoin-atom/bitcoin-atom
Cc: SMKultra; Mention
Subject: Re: [bitcoin-atom/bitcoin-atom] After sending coins macOS version crashes. (#13)
No additional input on this issue.
Can you please let us know if the issue persists on macOS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bitcoin-atom/bitcoin-atom/issues/13#issuecomment-380947777, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGkVjneW9MdwnQLMUkF0tZT75OU0I7S0ks5tn8TNgaJpZM4S38iz.


Built-in get_allowed_permissions-style method to retrieve all allowed (action, resource) pairs for a given actor

Hello!
We are creating an RBAC implementation based on OSO and it is working fine.
Currently the library provides a way to retrieve actions for a single resource using oso.get_allowed_actions().
For example, John can "read" a "Post 1". By asking oso.get_allowed_actions("Josh", "Post 1")  we can get following result: ["read"].
Unfortunately, our project has a complex UI so it is not possible to ask backend for available actions per resource on the page because it may cause:

high amount of similar http requests asking about allowed actions for resource
high traffic
resource consumption on the server
poor user experience and other related issues

Is it possible to somehow get result like [("read", "Post 1")]  in a single query? We are trying to feed UI with all available permissions using one HTTP query.
We managed to get almost desired results using following python code:
# Predicates have following signature:
# assign_role(user, role) — maps user to role
# role_allow(role, action, resource, user) — describes which action role's owner can do, user is a hacky way to provide more context to the predicate.
# User -assigned_to-> Role -grants-> Action-On-Resource

user = User(2)
assigned_roles = oso.query_rule("assign_role", user, Variable("role"))
for result in assigned_roles:
    role = result.get("bindings").get("role")
    permissions = oso.query_rule("role_allow", role, Variable("action"), Variable("resource"), user, accept_expression=True)
    for p in permissions:
        print(p)

    # The output is following:
        # {'bindings': {'resource': 'Post1', 'action': 'read'}, 'trace': None}
        # {'bindings': {'action': 'delete', 'resource': Expression(And, [Expression(Isa, [Variable('_this'), Pattern(Post, {})]), Expression(Unify, [Expression(Dot, [Variable('_this'), 'id']), 2])])}, 'trace': None}
        # {'bindings': {'resource': 'Post2', 'action': 'write'}, 'trace': None}

Provided solution

feels like a hack,
has N+1 query problem (caching must be used to partially solve the issue),
we have to parse returned Expression to figure out which instance (object) is described in results

It would be great to have a way to achieve this task in more readable and performant way.
Thanks!

Great news, thanks, i'll try it!

This seems like, from an implementation perspective, it would pair well with #1427 as a pull request in one go


[Bug] Mongoose @Ref decorator not respecting the property type

I found a regression introduced on the latests commits:
consider the following
@Model()
export class User {
    @Ref(Favorite)
    favorites: string[]
}

@Model()
export class Favorite {
    name:string,
    type:string,
}

const favorite = await favoriteModel.create({....})
userModel.create({
   favorites: [ favorite ]
})

version: 4.10.5 outputs
{
    "_id" : ObjectId("5abdbaa8ee9ba0c38a0a51b2"),
    "favorites" : [
        ObjectId("5abdbaa8ee9ba0c38a0a51b1")
    ]
}

however in the latest version it outputs
version: 4.11.0 outputs
{
    "_id" : ObjectId("5abdbaa8ee9ba0c38a0a51b2"),
    "favorites" : [
        {
            "_id" : ObjectId("5abdbaa8ee9ba0c38a0a51b3"),
            name: ....,
            type: ....
        }
    ]
}

it probably has something to do with this commit: https://github.com/Romakita/ts-express-decorators/commit/7e37b9e

@milewski Great work. But you must create branch and PR before purpose a change. I shouldn't commit directly on the master branch. The risk is to lost the commit if another branch is merged and finished XD (master is reset from the production).
Normally the process is described here: https://romakita.github.io/ts-express-decorators/#/contributing?id=gflow
You not obliged to install gflow tool (you can reproduce the process with pure git command) but it follow the Gitflow and semantic-release. It help me to publish and finish feature/fix (and to have a clean history).
Don't worry about that ;) I'll clean the master branch and send your if in release.
See you
Romain

It's my fault, I didn't give you the right process ;)

Tell me if the process isn't clear ;) I need some feedback on this part.

Oh right im sorry i haven't seem that contributing page 👍  will do next time ~


[Textfield] "multiline" variant getting wrong height when "quiet"

Description
Currently the multiline version gets the following CSS:
.spectrum-Textfield--multiline {
  height: auto;
  min-height: var(--spectrum-global-dimension-size-700);
  padding: calc(var(--spectrum-textarea-padding-top, var(--spectrum-global-dimension-size-75)) - var(--spectrum-textarea-border-size, var(--spectrum-alias-border-size-thin))) calc(var(--spectrum-textarea-padding-x, var(--spectrum-global-dimension-size-150)) - var(--spectrum-textarea-border-size, var(--spectrum-alias-border-size-thin))) calc(var(--spectrum-textarea-padding-bottom, var(--spectrum-global-dimension-size-115)) - var(--spectrum-textarea-border-size, var(--spectrum-alias-border-size-thin))) calc(var(--spectrum-textarea-padding-x, var(--spectrum-global-dimension-size-150)) - var(--spectrum-textarea-border-size, var(--spectrum-alias-border-size-thin)));
  overflow: auto;
}

Notice the min-height here "resolves" to --spectrum-global-dimension-size-700.
However, when you add quiet to the element as well the following styles are applied:
.spectrum-Textfield--quiet.spectrum-Textfield--multiline {
    height: var(--spectrum-textfield-height, var(--spectrum-alias-single-line-height));
    min-height: var(--spectrum-textfield-height, var(--spectrum-alias-single-line-height));
}

Which causes the "resolved" min-height to be --spectrum-alias-single-line-height or the same as the standard (non-multiline) variant.
It does't look like this is happening in the public documentation site https://opensource.adobe.com/spectrum-css/components/textarea/, but these styles are direct copies from v2.0.6.
Separately, I can follow up next week with whether this persists in the beta releases or not, but it would be great to see a mainly release with a bug fix for this!

The same persists in the recent beta 2 release in dist/index-vars.css:
.spectrum-Textfield.spectrum-Textfield--quiet.spectrum-Textfield--multiline .spectrum-Textfield-input {
    height: var(--spectrum-textfield-height, var(--spectrum-alias-single-line-height));
    min-height: var(--spectrum-textfield-height, var(--spectrum-alias-single-line-height));
  }

--spectrum-alias-single-line-height seems incorrect here.

So this is kind of designed to act this way because we don't want a large box with only a visual bound on the bottom side.
We can double-check with Design on this. It really should just grow as you type.

Yes, this is the guidance from the Design team: https://spectrum.adobe.com/page/text-area/#Dont-use-quiet-style-for-fixed-height-text-areas


Add limitations for permission grant policies and permission grant policy condition sets

There are undocumented limitations for permission grant policies and permission grant policy condition sets ("consent policies"), which sometimes change without notice.
This document would be a good place for these limitations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42a0b4cb-1981-1cbc-ce2c-dbfd8af1527c
Version Independent ID: d49c873c-9843-8428-a6d1-a1995067d13b
Content: Service limits and restrictions - Azure Active Directory
Content Source: articles/active-directory/enterprise-users/directory-service-limits-restrictions.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @curtand
Microsoft Alias: curtand

@commakoerschgen
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate. In the meantime, can you share some of the undocumented limitations, to better help the author investigate and update the documentation.

Thanks for the update.
For now, we have found the following limitations (as of yesterday:

There can be at most 100 clientApplicationIds across all permission grant policy condition sets in the tenant
There can be at most 100 clientApplicationTenantIds across all permission grant policy condition sets in the tenant

An error message for 1. is as follows (PS cmdlet, which probably just outputs the error returned by Graph):
Code: Request_BadRequest
Message: The total number of condtions in clientApplicationIds exceeds the maximum allowed number. Number of
conditions: 4982. Maximum allowed number: 100

@commakoerschgen
Thank you for the quick follow up on this! Please allow some time for the author to investigate and update the documentation as appropriate.

#reassign:@barclayn

@commakoerschgen Thank you for your feedback. I have created a work item for us to track internally and triage when appropriate. #please-close


Changes for JupyterHub >= 4.1

Adapts to some changes for XSRF processing upstream - ensuring we don't call some of the parent methods before authentication info is available.

This should fix #23