Adjust Mocks to handle kafka commits

About this change - What it does
Adjusts various mocks so that they are able to handle the suspend/resume case in Guardian. Also adds a test which makes sure the mocks work.
Why this way
The context of this PR is for the gzip compression PR at https://github.com/aiven/guardian-for-apache-kafka/pull/196. In that gzip compression PR I want to add a test which makes sure that restarting the tool between changing the gzip configuration works (i.e. first start guardian with gzip compression on, shut down guardian, then turn on Guardian again with gzip compression off). While its possible to test this using a real Kafka/S3, its excessive since I only want to test that the compression changes apply.
The basis of the PR is to add data structures (backedUpData/commitStorage) that is shared between mockOne/mockTwo in order to share the relevant state between multiple instances of the mock as well as a handleCommits flag which enables the tracking of commits in the mocks. Logic also needed to be added to the mocks to actually handle the case of suspend/resume case. The stopAfterDuration has been added to simulate the "suspend" scenario (with a real Kafka/Backup client we just terminate the client while its backing up where as with a mock it will produce and backup the elements immediately so "stopAfterDuration" is needed and its implemented as simple filter that will just stop producing elements after a specific time period).
There is also a bug in the Generator regarding offset generation. This was solved by just using zipWithIndex (since the mocks only generate a single topic with a hardcoded partition, the commit counter is just a globally monotonously incrementing counter).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.104%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
293

Relevant Lines:
385

💛  - Coveralls


How to resovle this problem?  tips："Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work"

C:\Users\TCB\PycharmProjects\OpenVoice\venv\lib\site-packages\pydub\utils.py:170: RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work
warn("Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning)

Download ffmpeg windows build and place it *ffmpeg.exe) inside your project, potentially inside C:\Users\TCB\PycharmProjects\OpenVoice\venv\lib\site-packages\pydub\

Sure, my default is the same. Did you solve it yet?


ssh error

hi team,
i have this issue when i create my machine, can someone help me please.
ERROR: ArgumentError: :key_data, :keys, :password or a loaded ssh-agent is required to initialize SSH

Did you figure it out? What was it?


cleanup after emptying an dirty object, non recursive nature?

clean=require('deep-cleaner')
obj={a:{dirty:'toclean'}}
clean(obj,'dirty')
expected: obj={}
actual: obj= {a:{}}

maybe it's linked to another issue
clean=require('deep-cleaner')
obj2 = { a : { b : { c: {}} } }
clean(obj2,'dirty')
expected: obj2={}
actual: obj= {a:{b:{}}}

Currently, if a key is specified when cleaning objects (i.e. clean(someObject, 'someKey')), then it will only remove the key, leaving everything else untouched. It will still do it recursively though, for example:
>> const obj = {
...    a: {
...      a: { b: 'B', c: 'C' },
...      b: 'B',
...      c: 'C'
...    }
... }
>> clean(obj, 'b')
>> console.log(obj)
{ a: { c: 'C' }, c: 'C' }

So the behavior you're seeing is expected and to get the result you're expecting then you'd have to do something like clean(clean(obj, 'dirty')). I'm open to altering that behavior since I realize this probably isn't ideal...

I see that the code that implemented it was probably wired for leaving everything untouched intentionally as I see there is a specific test for making sure the objects remain(which I've changed in my PR).
I would vote to change that behaviour and clean up recursively.
running a cleanup up code twice seems awkward, maybe a flag could be used to trigger the old/new behaviour. The behaviour change could part of a major version upgrade with a flag for backward compatibility.

+1 for recursive clean-up to be the norm


Add typos - Source code spell checker

Objective

Avoid misspellings throughout the codebase by using typos in CI

Inspired by https://github.com/gfx-rs/wgpu/pull/5191
Typos is a minimal code speller written in rust that finds and corrects spelling mistakes among source code.

Fast enough to run on monorepos
Low false positives so you can run on PRs

Solution

Use typos-action in CI
Add how to use typos in the Contribution Guide

How do we add false positives to an allow list?
in typos.toml
you can add words:
[default.extend-words]
# Things that aren't typos
LOD = "LOD" # Level of detail

or just ignore them in :
extend-ignore-identifiers-re = [
  "NDK", # NDK - Native  Development Kit
]

Will fixing the typos be in the scope of this PR? I suggest you create another PR that fixes all the typos, merge that first, then merge this one.

https://github.com/bevyengine/bevy/pull/12038

is it possible to have the configuration file not in the root directory?

Every action in the ci utility uses cargo, is ok that just panic if the user doesn't have typos installed?

Idk about adding typos to the ci utility. We also don't have the toml and markdown formatting there.

Hmm okay. Leave it as is then.

And I honestly don't understand the concern of adding a new file to the root-level, isn't that just aesthetic or is there some limitation that I don't know about?

Yeah, this is just aesthetic clutter. It makes it harder to orient yourself when visiting the repo, especially for the first time. Ideally it would be in .github.

always wished for a cross-platform secondary default, something like project/etc/typos.toml but alas.

true, I messed up.
fixed

I'm not familair with the code in bevy_mikktspace.
"iFO",
"vOt",
"fLenOt",
idk what these variables mean so I leave them without a comment.

Yeah bevy_mikktspace is something of a disaster zone: it's machine-translated unsafe C code that we adopted. That's a fine solution for now.

Merging. I'm going to leave this as an optional CI check for a while until we get a sense of the false positives and robustness (and to give older PRs a grace period where they don't need to be rebased). Once we're happy with it, I'll add it to our branch protection checks.


Fix The value of the index id printed in the log is incorrect #38790

cherry pick from #38790

run buildall


Test issue

I'm testing

娃哈哈

goon

aa

aa

aaa

aaa

aaa

aaa

aa

aaa

aa

aaa

aaa

aaa

aaaaa

aaa

aaaa

test my

test comment

"abcbcbcbc"

"abc"

abc

aaa

hello world

hhhhleo

aaa

aaa

aaa

aaaaa

aaaa

dadasd

aaaa

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero?  in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

aaa

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

Hi @Michaelg22, thank you for quick response. Another question: what should be returned by the function if the input string length is 1 or zero? in the vanus repo.

aaaa

test

aaa

aa

test

test

tet

aaa

qqq

qq

aa

aa

aa

tt

ttt

ttt

cc

aaa

aa


x ~ scale * N(theta, 1) or x ~ N(theta, scale)? 🤔

Hello 👋 ,
I was trying to understand the benchmark datasets used to evaluate BayesFlow's performance. One thing that I noted for a couple of datasets is the scaling factor in front of the distribution for sampling the observations. One example is linked below, which is the T.2 task from the sbib paper.
Generating points for the original task would look like this:
theta ~ scale * N(0,1) = N(0, scale * 1)
x ~ N(theta, scale * 1)
with scale being the same for both distributions i.e., scale=0.1
Now your implementation is:
theta ~ scale * N(0,1) (same as above)
x ~ scale * N(theta, 1) = N(scale * theta, scale * 1)
which is equivalent to having a different prior compared to the T.2 task for the same data distribution, i.e.:
theta ~ scale^2 * N(0, 1) = N(0, scale^2)
x ~ N(theta, scale * 1)
maybe im also missing something but i would be glad for clarification. I also wanted to ask what code you used for the multivariate dataset from your paper part 3.3?
https://github.com/stefanradev93/BayesFlow/blob/5ff1c1ea8ee2bda8cf333ae2890b95d05185af23/bayesflow/benchmarks/gaussian_linear_uniform.py#L85

Hi Niels,
the task T2 in the BayesFlow repo is the same as the one in Lueckmann et al., only written slightly differently in code. :)
numpy parameterizes the normal with its scale, not its variance.
Also, I think you are referring to task T1, since T2 has a uniform prior over the locations.
Can you also please specify which paper you mean?

Follow up: You are right in assuming that the default scaling factor in the BayesFlow differs from Lueckmann et al., since the 0.1 in the original paper is a variance and not a scale!

Thanks for spotting the bugs! These are now fixed in the dev branch (soon to become main) and pointers to potential inconsistencies between paper and the two implementations have been added. I will resolve the issue upon a "thumbs up".


leaflet map working for android

Helps pop ups appear on chrome on android phones

:rock-star:

💯


allow tagging of metadata and add attempt status to metadata table

write attempt status at the end of every task attempt

can we set the type to attempt_ok as well

yep, i think i pushed the updated name the same time you made that comment


Rename the SaramaHasher or un-deprecate because it's needed for compatibility with other language libraries

I know this might be an odd request since this was just added, but the change the the hasher will break apps for people co-partitioning Kafka topics when publishing from other languages using crc32.
I previously commented on an issue in the IBM/sarama package discussing this partitioning problem. The fix there was to modify the Sarama balancer plan into a custom version for Ruby compatibility.
The newly deprecated kgo.SaramaHasher was compatible with the Ruby code and librdkafka when calculating partitions so it does serve a purpose, even if it may have been incorrectly named?
Below is an example which tests both the old and new hashers and a snippet to show how it works in Ruby.
newH := kgo.SaramaCompatHasher(crc32.ChecksumIEEE)
oldH := kgo.SaramaHasher(crc32.ChecksumIEEE) // nolint:staticcheck

newP := newH([]byte("test"), 840)
oldP := oldH([]byte("test"), 840)

println("SaramaCompatHasher:", newP)
println("SaramaHasher:", oldP)

"SaramaCompatHasher":180
"SaramaHasher":76

irb(main):002:0> Zlib.crc32("test") % 840
=> 76

I see. I don't think this was compatible with librdkafka unless librdkafka has a way to specify custom partition strategies (I'm not looking that deep) -- what I see in librdkafka is https://github.com/confluentinc/librdkafka/blob/master/src/rdkafka_msg.c#L1031-L1131, which offers murmur2, fnv1a, and uniform random distribution.
However, my guess is that the Ruby library copied Sarama, vise versa.
I can remove the Deprecation bit, reword the comment (i.e. it does not match Sarama identically), and note that the SaramaHasher is identical to the Zendesk Ruby hasher. Do you know any others that should be mentioned in the comment?

One of the defaults consistent is the crc32 partitioner in librdkafka
https://github.com/confluentinc/librdkafka/blob/2dff2ebce9dc7e75c0138504b386902384d70eb9/src/rdkafka_msg.c#L1044C1-L1051C2
If you use the github to search for rd_crc32 in that repository, you get the function that partitioner calls. It looks like it might even be using zlib as well which matches with how the ruby-kafka library does its strategy.
https://github.com/confluentinc/librdkafka/blob/2dff2ebce9dc7e75c0138504b386902384d70eb9/src/rdcrc32.h#L36
Really for me removing the deprecation warning is probably enough since golangci-lint flags it as bad due to staticcheck.
I was more trying to point out that it's actually a valid hasher beyond just Sarama, which I actually believe did its own thing outside of Ruby or librdkafka for some reason.
I'm not sure what a better name for the function would be though.
Thank you.

Too late to rename, and I don't know a good name anyway (it's very specific mod behavior), so imo better to just undeprecate and call out in the docs a few potential other-library compatibilities.


feat: Adding <Logo/> and <Tags/> components with updated colors too

[x] feat: Refactoring Directory/Logo into component
[x] fix: Updating colors
[x] feat: Adding new Directory/Tags component

@jvmontes Okay I've updated all the colors to use hsl() and moved the call to that function in to the variable declaration rather than where we're referencing the variable. This way we can modify the colors from hsl() if we need to. If there's more feedback about colors, I'd feel better to change things in other PRs rather than in this PR. I still need this to be stable before I can get started on the Org Details page again.


plyr not able to play video in ios 11.4

Please use this issue template as it makes replicating and fixing the issue easier for us. If you decide not to use it or you are vague your issue may be close instantly.
Expected behaviour
Actual behaviour
Environment

Browser:
Version:
Operating System:
Version:

Steps to reproduce

Please use this issue template as it makes replicating and fixing the issue easier for us. If you decide not to use it or you are vague your issue may be close instantly.


Some features

Module::isActive('module') let you validate if a module exists and is active but without generating error.

Routes folder, configured as in Laravel 5.3+ (and according to the standard, the routes should be loaded in the service provider, so the start.php file is still present but empty).

No Namespace folders (like config & routes) must be in lowercase.

Hello and thanks for the contribution.
However please consider sending one PR per feature/change you make.

Except for the "isActive" method, all the other files are related, and should be in the same pull request.

Sorry but after further review I can't accept this PR. Routes are loaded in a RouterServiceProvider, which can be generated with this package. This is the usual recommended way instead of via start.php.
This also gives the package consumer the flexibility of having the routes file at any desired location.
This is the stub file for the routeSP https://github.com/nWidart/laravel-modules/blob/master/src/Commands/stubs/route-provider.stub
Which is called by the module:route-provider command.

When I create a new module this don't have the route provider... Is a new feature or somebody disable it?


Fix misc typo in windows.gaming.input

@msatranjr : : The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!


Need fix to hide bottom sheet when back button pressed rather than go back to the previous page.

Any solution?

Sounds like you want a custom back handler, react-native has support for that, see here: https://reactnative.dev/docs/backhandler
Does that help?


feat(mock-server): support node dumps as input

With this PR, the mock-server can parse node dumps created by node.createDump(). This can either be done programmatically using the createMockNodeOptionsFromDump method, or by passing a file with extension .dump as the mock server config, either a standalone file or in a directory with mocks.
As a followup we should create more CC-specific capabilities from CC values. I don't have a useful dump handy right now.

@zwave-js-bot automerge


Better Block/Area shadow styling

The shadow styling for blocks and areas needed to be improved on. This adds several improvements:
1- Added the transparency option for the shadow color so now RGBA colors are possible instead of just RGB. It seems to me that a shadow without an alpha layer is missing something
2- The only thing a shadow MUST have is a color and then if a color is set at least one of the other variables (blur, spread, horizontal or vertical offset). The shadows were set so that they would only be saved if the horizontal offset was set which makes no sense. Shadows don't require a horizontal offset, it's only an option. So now it checks that a color is set and at least one of the other variables.
3- Shadow would only be applied if a spread value was set which makes no sense because as explained above, saving was dependent on the presence of a horizontal offset, not a spread so this was not consistent. And same as above, a spread is not required to have a shadow.
So now all that is required to have a shadow is a color and at least one of the other 4 values.

I'm no expert but I really don't see why Travis and Appveyor are both complaining, there's nothing special here.


Calculate area of sector

Example Problem:  Given radius, 4 and angle, 45. Find the area of the sector.
Example Solution:  Area of sector = (angle / 360) * πr^2 .
area of given sector = (45/360) * π4^2 = 6.2857
Further explanation: A circular sector, is the portion of a disk enclosed by two radii and an arc.
Would you like to be assigned to this: Yes

Hey ! i would like to take this

I would like to work on this. Can you assign this issue to me?

I would like to take this up.

assign


Add Jupyter Notebook service

Add new service Jupyter Notebooks.
This will allow to build Playbooks with data we have.

[x] create new service
[x] add new experience
[x] add sample playbook
[x] add showcase for a playbook
[x] add javascript https://github.com/n-riesco/ijavascript, https://n-riesco.github.io/ijavascript/doc/custom.ipynb.html

Source: https://jupyter.org/install

done


Only show Anyone-occupancy sensor

In a two person household like mine, it doesn't make much sense to have separate sensors for each person, since it's pretty clear when someone's home and I am not, it can only be the other person.
Could you add an option to only display the Anyone occupancy sensor to the Home app?

added in v5


VTRK_Button fails at line 240 if autodetection is left as default

This issue also prevents the creation of the component at run time

Closing seems to be an issue if VRTK asset not complete replaced when upgrading


Missing description text for 'AdditionalAccountsEnabled'

Published description only includes placeholder text.
"
This parameter is available only in the cloud-based service.
{{ Fill AdditionalAccountsEnabled Description }}
"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 022da80e-29cd-f6b5-aa00-48e2d16c4be8
Version Independent ID: c3353c03-e416-f693-104f-6b6f5955b721
Content: Set-OwaMailboxPolicy (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@jalrok, empty parameter descriptions are a known issue when dealing with 1300+ cmdlets and 13,000+ parameters. Availability vs. functionality of a parameter are two different things. See here here for a detailed explanation.
So, are you being directed to use that parameter from other content, or are you just pointing out the fact that it's empty?

I was doing an audit of our mailbox polices, both on-prem and cloud. Since
I was unfamiliar with some of the enabled settings, I was relying on the
documentation to validate the functionality. In this case, we want to make
sure that 'AdditionalAccountsEnabled' doesn't allow people to use 3rd party
cloud services.
I realize that some settings are for future use, or are deprecated, but the
documentation should state that. Several other settings say something along
the lines of "reserved for internal use", so at least in that case I know
it's not something to worry about (or at least nothing I have control
over). When the doc has something like "{{Fill ...... Description }}" it
just looks like it was forgotten about, and I'm left to determine if it's a
security/policy risk to the business.
On Tue, Dec 27, 2022 at 10:36 AM Chris Davis @.***>
wrote:

@jalrok https://github.com/jalrok, empty parameter descriptions are a
known issue when dealing with 1300+ cmdlets and 13,000+ parameters.
Availability vs. functionality of a parameter are two different things. See
here
https://github.com/MicrosoftDocs/office-docs-powershell/issues/7429#issuecomment-808564486
here for a detailed explanation.
So, are you being directed to use that parameter from other content, or
are you just pointing out the fact that it's empty?
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/issues/10276#issuecomment-1366098101,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMU3A4N44YD2MJ3IH74TP4DWPMZL5ANCNFSM6AAAAAATHBYUH4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Creating the intunewin

Not an issue per say, but some confusion. How did you create the Intune file? I had to adjust a few things as the name was coming back null. But when I create the Intune file, its like 6gb and won't import.

From a command prompt, navigate to the folder with the makeapp.cmd file and run it.  That 6GB file likely ran the script with the wrong working directory so it gathered up whatever was in the working directory.


Documentation: Incorrect (old) reference to Reachability dependency for iOS integration

Project: Snowplow Wiki: iOS Tracker Setup
https://github.com/snowplow/snowplow/wiki/iOS-Tracker-Setup#reach-setup
Expected behavior:
Links and examples should point to https://github.com/ashleymills/Reachability.swift which is the dependency installed by the latest Snowplow iOS tracker
Actual behavior:
Points to older https://github.com/tonymillion/Reachability.git which has this in its README:
"WARNING there have been reports of apps being rejected when Reachability is used in a framework. The only solution to this so far is to rename the class."

Thanks @iur-kaia for pointing this out, but we've started using a new site for documentation (linked in the README).

thanks, closing


double-beep: Watch cracksall.com

double-beep requests the watch of the watch_keyword cracksall\.com. See the MS search here and the Stack Exchange search here.

cracksall\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Add wrapper_type module to Ceylon SDK.

Add wrapper types for commonly used types to add unique typing.  This is useful in contexts where several Integer variables are used for different concepts such as AccountNumber, ReferenceNumber, etc.  This adds more safety than raw [[Integer]]s or [[String]]s, etc, and prevents accidental equality that would otherwise occur with these types, or passing such values in the wrong other to functions, not to mention clearer and more self-documenting code for those who read it.
The idea comes from the following article:
http://techblog.realestate.com.au/the-abject-failure-of-weak-typing/
The implementations of WrapperType include WrappedByte, WrappedBoolean, WrappedFloat, and WrappedInteger.  In addition, a WrappedTypedComparable exists as well as its subclass, WrappedString.  These are all meant to be subclassed by users (ex FirstName as a subclass of WrappedString). It is possible for implementors to created their own wrapper types.  For example, a Widget class may be wrapped with a WrappedWidget, which subclasses WrapperType.
Please look at the included unit tests for examples of usage and further clarity.
Feedback, suggestions, improvements, clearer documentation, style changes, etc are most welcome.

Can one of the admins verify this patch? (see README)

Added closing parenthesis.

I suspect I may have put my fork of ceylon-sdk in a bad state so I'll save my changes and resubmit later.


Use the odri yaml file to load the robot configuration

Need to land after https://github.com/open-dynamic-robot-initiative/robot_properties_solo/pull/43

Need to land after open-dynamic-robot-initiative/robot_properties_solo#43

This has been landed, is there still someone working on this?


bump go.mod dependencies

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test lint

unit-tests-arm64_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test lint

unit-tests-arm64_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests-arm64

gencheck_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test gencheck

unit-tests_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests-arm64

gencheck_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test gencheck

unit-tests_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests

lint_istio
68fe82bd16aa71dd048504f8908cff3fbd499ebc
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
841ce7b6fb65cbe21a742becab825798c7edf6be
link
true
/test unit-tests

lint_istio
68fe82bd16aa71dd048504f8908cff3fbd499ebc
link
true
/test lint

gencheck_istio
68fe82bd16aa71dd048504f8908cff3fbd499ebc
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
68fe82bd16aa71dd048504f8908cff3fbd499ebc
link
true
/test gencheck

lint_istio
1f27989b04fad77933dbb06914972f996185b579
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


feat/injecting scripts from popup

I was done it like in #494 for latest version :)
Don't merge this before #559 , because i want to change sth else after merge this PR.

@Jonghakseo IMO after this, we should bump version to 0.2.0, because of new feature

@Jonghakseo IMO after this, we should bump version to 0.2.0, because of new feature

I agree


Expose further getters in EE test Account

The test Account should have getters added for the AssociatedKeys and ActionThresholds of the underlying account.

No longer needed as this type has been removed.


Add accessControlAllowOrigin field at container level

Codecov Report

Merging #2024 (e440c6e) into master (fb8b544) will increase coverage by 39.39%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             master    #2024       +/-   ##
=============================================
+ Coverage          0   39.39%   +39.39%
- Complexity        0     4710     +4710
=============================================
  Files             0      714      +714
  Lines             0    54537    +54537
  Branches          0     6764     +6764
=============================================
+ Hits              0    21485    +21485
- Misses            0    30874    +30874
- Partials          0     2178     +2178

Impacted Files
Coverage Δ

.../main/java/com/github/ambry/account/Container.java
77.06% <71.42%> (ø)

...ava/com/github/ambry/account/ContainerBuilder.java
94.84% <100.00%> (ø)

...in/java/com/github/ambry/store/HardDeleteInfo.java
100.00% <0.00%> (ø)

.../ambry/messageformat/MessageFormatInputStream.java
53.33% <0.00%> (ø)

...github/ambry/store/CompactionPolicySwitchInfo.java
0.00% <0.00%> (ø)

...thub/ambry/tools/perf/rest/PerfRestServerMain.java
0.00% <0.00%> (ø)

.../main/java/com/github/ambry/router/PutManager.java
72.43% <0.00%> (ø)

...in/java/com/github/ambry/account/AccountUtils.java
19.68% <0.00%> (ø)

...va/com/github/ambry/protocol/TtlUpdateRequest.java
77.41% <0.00%> (ø)

...main/java/com/github/ambry/config/CloudConfig.java
100.00% <0.00%> (ø)

... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8b544...e440c6e. Read the comment docs.


Improve Websocket Reconnect in Firefox

Firefox tracks websocket disconnection failures and once a certain threshold is exceeded throttles them. This leads to an annoying grey screen before further attempts are made. Improve on this:

either test whether the server is running via HTTP requests (rather websockets)
wait for longer between attempts (only in firefox?)

The frontend now uses HTTP requests (via fetch) to check if the server is online. Seems to have solved the problem, as far as I can tell.


Box: Add visuallyHidden as a display option

TODO: add test (jest wasn't working)

Deploy preview for gestalt ready!

The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   70.55%   70.46%   -0.09%
==========================================
  Files          45       45
  Lines         815      816       +1
  Branches      188      188
==========================================
  Hits          575      575
- Misses        169      170       +1
  Partials       71       71

Impacted Files
Coverage Δ

packages/gestalt/src/Box/Box.js
66.34% <0%> (-0.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2cb1d...7f79101. Read the comment docs.


Add additional instruction to Give Each Element a Unique ID

This commit adds an addtional instruction to the challenge, specifing to
keep target1 to target3 in the #left-well and target4 to target6
in the #right-well respectively.
Tested locally.
closes #6331

Done @SaintPeter !

Thank you sir!


Allow manually triggering the book deployment

@crgoddard in case you need it in the future, you can now manually build and deploy the book here: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/actions/workflows/deploy-book.yml
See the Run workflow button (top right)
Closed by #223


How to create valid Certificates?

Hello everyone.
So I'm trying to dive deeper on these Certificates.
Can anyone give me an help on how to create a valid certificate and explaining how it works?
I'm willing to pay.
my email is<EMAIL_ADDRESS>Let me know, I reply asap.

@dannyhax0
Please, send your request to the Ministry of Health in your country, which is coordinating your country's connection to the EU DCC Ecosystem.


Some fixes (critical and not)

Removed 'static' from BMSByte allowedTypes dictionary, so it will not collide with other Threads
Added an ability to set firewall port on PingForFirewall() method (prevent collisions between two Networkers on connection stage)
Fixed a bug of LINQ usage in reliableComposers (raised freezes sometimes on huge UDP stream)
Added a check of Networker to NetworkManagerTemplate.txt, because it can be already removed on NetworkManager Destroy
Uncommented check of loadedScenes.Count which raised an error if no loadedScenes used

Confirmed, thank you so much! :) 👍


Store can be initialized via onStoreInitialized()

The store resets the registry at the beginning of each scenario, but
I have a requirement where my Scenario's need access to something in
the store at all times.
To facilitate this, I added a check for an onStoreInitialized method
after the registry is cleared, and if it exists, the StoreContext will
call it to populate the newly cleared registry.

@Chekote 👍


Add BreakpointsConsumer component

Sometimes, it would be nice to know which breakpoint is being active. For instance, optimizing for large-scale displays requires the base font size to be adjusted as the viewport size changes.
I would like to propose a BreakpointsConsumer component which would expose the index of the currently active breakpoint (defined in Provider).
The following syntax could be used, showing how to dynamically specify the number of columns for react-photo-gallery:
<BreakpointsConsumer>
  {(breakpointIndex) =>
    <Gallery
      columns={({
        0: 1,
        1: 2,
      }[breakpointIndex]) || 4}
    />
  }
</BreakpointsConsumer>

Thanks for the suggestion. This would probably be great as a separate standalone component for use with styled-components and emotion. I'd encourage you to consider making a package for this functionality if you're interested


Enhance docu for Basic Auth with htpasswd.data

Enhanced the docu to clarify the configuration to use Basic Auth and htpasswd, especially with the right parameter combination (createSecret and htpasswd.data)
imo, we should also update here the OpenShift docu, with such details. But I do not know where/how.
https://docs.openshift.com/container-platform/4.5/metering/configuring_metering/metering-configure-reporting-operator.html#metering-basic-authentication_metering-configure-reporting-operator

/assign @timflannagan1

/unassign @timflannagan1

Any updates to the Openshift documentation need to live in the openshift/openshift-docs repository. I can make a note to follow-up with this again once people are back in the new year.


corrected broken link

Hi Daniel,
I corrected the broken link. Hopefully I didn't make a mess of the commits again

Squash these please?

Closing, no activity.


[google_sign_in_web] Chrome blocks One Tap UX and granular consent screen popup

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
google_sign_in
What target platforms are you seeing this bug on?

Yes
Dependency versions
pubspec.lock
  google_sign_in:
    dependency: "direct main"
    description:
      name: google_sign_in
      sha256: aab6fdc41374014494f9e9026b9859e7309639d50a0bf4a2a412467a5ae4abc6
      url: "https://pub.dev"
    source: hosted
    version: "6.1.4"
  google_sign_in_android:
    dependency: transitive
    description:
      name: google_sign_in_android
      sha256: "2a8b90b766ce00b03e7543f4ffeec97b6eb51fb6c3f31ce2a364bd1f1b9dd7fc"
      url: "https://pub.dev"
    source: hosted
    version: "6.1.14"
  google_sign_in_ios:
    dependency: transitive
    description:
      name: google_sign_in_ios
      sha256: "6ec0e13a4c5c646471b9f6a25ceb3ae76d339889d4c0f79b729bf0714215a63e"
      url: "https://pub.dev"
    source: hosted
    version: "5.6.2"
  google_sign_in_platform_interface:
    dependency: "direct main"
    description:
      name: google_sign_in_platform_interface
      sha256: e69553c0fc6a76216e9d06a8c3767e291ad9be42171f879aab7ab708569d4393
      url: "https://pub.dev"
    source: hosted
    version: "2.4.1"
  google_sign_in_web:
    dependency: "direct main"
    description:
      name: google_sign_in_web
      sha256: "69b9ce0e760945ff52337921a8b5871592b74c92f85e7632293310701eea68cc"
      url: "https://pub.dev"
    source: hosted
    version: "0.12.0+2"

Steps to reproduce

configure Client ID -> Authorized JavaScript origins as https://sub.my.domain
initialise GoogleSignIn with additional scopes (for the granular consent screen part)
use signInSilently() and renderButton() (see code sample)
build release: flutter clean && flutter build web --release
deploy to https://sub.my.domain
open https://sub.my.domain in Chrome (Version 114.0.5735.248 (Official Build) (arm64))

Expected results

Google One Tap UX shows up
granular consent screen popup is not blocked

Actual results

Google One Tap UX does not show up in Chrome, because the browser blocks the gsi_client request client:113 GET https://accounts.google.com/gsi/status?client_id=<client_id>&as=<as> net::ERR_BLOCKED_BY_CLIENT

while in Firefox it is not blocked

When clicking the Sign-In button and choosing an account ("https://accounts.google.com/gsi/select..." popup)(or in Firefox after the One Tap UX does the sign-in "https://accounts.google.com/gsi/issue...") then the granular consent screen popup is blocked: [GSI_LOGGER]: Failed to open popup window on url: https://accounts.google.com/o/oauth2/v2/auth?gsiwebsdk=3&client_id=<client_id>&scope=<scope>&redirect_uri=storagerelay%3A%2F%2Fhttps<...>&login_hint=<login_hint>&response_type=token&include_granted_scopes=true&enable_granular_consent=true. Maybe blocked by the browser?

fyi: I also have another app written with React using the @react-oauth/google library and there the granular consent screen popup is not blocked

fyi: running it on localhost (flutter run -d chrome --web-port=8080) nothing is blocked and all works just fine

Code sample
Code sample
googleSignIn = GoogleSignIn(
  clientId: clientId,
  scopes: scopes,
);
....// App widget
  @override
  void initState() {
    super.initState();
    googleSignIn.onCurrentUserChanged.listen((GoogleSignInAccount? account) async {
      final bool isAuthorized = await googleSignIn.requestScopes(scopes);
      setState(() {
        _account = isAuthorized ? account : null;
      });
    });
    googleSignIn.signInSilently();
  }
...// Login Widget
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        ...
        body: Column(
          children: [
            ...
            Center(child: signInButton()),
          ],
        ));
  }
...
Widget signInButton() {
  return (GoogleSignInPlatform.instance as web.GoogleSignInPlugin).renderButton();
}

Screenshots or Videos
No response
Logs
Logs
Chrome blocks gsi_client request (while Firefox does not)
client:45 [GSI_LOGGER]: Check credential status returns invalid response.
client:113 GET https://accounts.google.com/gsi/status?client_id=<client_id>&as=<as> net::ERR_BLOCKED_BY_CLIENT

both Chrome and Firefox block the granular consent screen (both in the One Tap UX flow and the renderButton flow)
client:256 Cross-Origin-Opener-Policy policy would block the window.postMessage call.
client:45 [GSI_LOGGER]: Failed to open popup window on url: https://accounts.google.com/o/oauth2/v2/auth?gsiwebsdk=3&client_id=<client_id>&scope=<scope>&redirect_uri=storagerelay%3A%2F%2Fhttps<...>&login_hint=<login_hint>&response_type=token&include_granted_scopes=true&enable_granular_consent=true. Maybe blocked by the browser?

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.7.8, on macOS 12.2.1 21D62 darwin-arm64, locale en-DE)
    • Flutter version 3.7.8 on channel stable at /opt/homebrew/Caskroom/flutter/3.7.8/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 90c64ed42b (4 months ago), 2023-03-21 11:27:08 -0500
    • Engine revision 9aa7816315
    • Dart version 2.19.5
    • DevTools version 2.20.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.2.1 21D62 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.248

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Hi @Fiurgeist
I tried re-checking this but it works as expected on my side with plugin sample code.

Demo video
https://github.com/flutter/flutter/assets/104349824/22959b91-9d38-450d-ba32-c45bd6c83c06

There is only one difference that is I'm using the latest Chrome version Version 115.0.5790.114 (Official Build) (x86_64).
Also, are you using any adblock extension that may block the popup? Can you retry on Incognito mode?

hi, thx for the hint :)
I don't have an ad-blocker installed, next to some google extensions I actually have one extension installed and that is
1Password – Password Manager
and when I disable it, it all works... I don't even...


Add support to PT-BR (Brazilian Portuguese) language

Created file Languages/lang.pt-br.php

Hi, @ricardofontanelli did you make the translation based on the es file? I'm asking because I also translate PHPCI to Brazilian portuguese (and before I send a PR I see this work already in progress) and it seems that are missing strings to translate since the file that I generate has 441 lines of code.
If you guys want I can wait and finish the missing translations after this PR is merged. What you think?

Hi @atilacamurca, yes I started the translation based on the es file, but when it was finished, I noticed that some keys are not present in this file. A quick array_diff show waht keys are missing. Commit 2f12754.

This branch won't be merged to master?

@Block8, is there something wrong with this PR?

@dancryer why you close before merge? Is it something wrong?

@atilacamurca There's nothing wrong with the PR as an idea, we just auto-closed all PR's as the repository was in a mess.
That said, a PT-BR language file has already been merged: https://github.com/Block8/PHPCI/blob/master/PHPCI/Languages/lang.pt-br.php - So we'd need a new PR which is based on modifying that file, rather than creating it again from scratch.


Add Provision for Ethereum

dfuse supports both EOSIO and ETH networks.
dfuse-python currently interfaces only with EOSIO.
dfuse-python should in turn interface with both.

Still WIP


Korean characters are broken while typing in message input box.

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary

Korean characters are broken when typing.
Steps to reproduce

macOS High Sierra
4.0.1
Type Korean in message input box. (Input Sources - 2-Set Korean)

Expected behavior
input should look like this in message typing area.
"한글입력문제"
Observed behavior
input looks like this
"ㅎㅏㄴㄱㅡㄹㅇㅣㅂㄹㅕㄱㅁㅜㄴㅈㅔ"

Possible fixes

Reproduced on pre-release 4.9.0-rc4 with Japanese text.
@jasonblais Probably it's similar to https://github.com/mattermost/desktop/issues/701. Would you check with webapp team?

Thanks! I've created a ticket for the webapp team to investigate https://mattermost.atlassian.net/browse/MM-10197

Ref: https://github.com/mattermost/mattermost-server/issues/8206

This is now fixed server-side. You can upgrade the Mattermost server to v4.9.0 to have it resolved.
https://github.com/mattermost/mattermost-webapp/pull/1099


Can't override properties from bootstrap.yml in profile specific bootstrap file

Having bootstrap.yml in the main sources
spring:
  application:
    name: edgeService
  cloud:
    consul:
      config:
        enabled: false
        prefix: config
        profileSeparator: '@@'
        watch:
          enabled: false
      discovery:
        tags<EMAIL_ADDRESS>      host: localhost
      port: 8500
  main:
    banner-mode: 'off'

and having the bootstrap-ci.yml and @ActiveProfiles("ci") in the tests
spring:
  application:
    name: edgeService
  cloud:
    consul:
      discovery:
        scheme: http
      enabled: false
      config:
        enabled: false
... (other app-specific configs removed)
stubrunner:
  ids: com.acme:security.service:1.0.0:stubs
  idsToServiceIds:
    security.service: securityService

Doesn't lead to overriding the values from bootstrap.yml . In other words the app is always trying to connect to Consul.
Related issues:
https://github.com/spring-cloud/spring-cloud-contract/issues/174
https://github.com/spring-cloud/spring-cloud-contract/issues/141

The current workaround for this is to use a static block like this:
@RunWith(SpringRunner.class)
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@AutoConfigureStubRunner(ids = {"com.ryanjbaxter.spring.cloud:ocr-participants:+:stubs"}, workOffline = true)
@DirtiesContext
@ActiveProfiles("test")
public class OcrRacesApplicationTestsBase {

    @Autowired
    protected ParticipantsService participantsService;

    private List<Participant> participants = new ArrayList<>();

    //Hack to work around https://github.com/spring-cloud/spring-cloud-commons/issues/156
    static {
        System.setProperty("eureka.client.enabled", "false");
        System.setProperty("spring.cloud.config.failFast", "false");
    }

    @Before
    public void setup() {
        this.participants = new ArrayList<>();
        this.participants.add(new Participant("Ryan", "Baxter", "MA", "S", Arrays.asList("123", "456")));
        this.participants.add(new Participant("Stephanie", "Baxter", "MA", "S", Arrays.asList("456")));
    }

    @After
    public void tearDown() {
        this.participants = new ArrayList<>();
    }

    @Test
    public void contextLoads() {
        List<Participant> participantList = participantsService.getAllParticipants();
        assertEquals(participants, participantList);
    }
}

hmm, I wrote a test that uses @ActiveProfiles with a profile specific bootstrap.yml and it overrides the value just fine.

The workaround specified by Marcin works fine, but if a test fails, the failure reason does not offer any indication on what the problem is, but it points to Hystrix.

While using the following versions:
<spring.boot.version>1.5.3.RELEASE</spring.boot.version>
<spring.cloud.version>Dalston.RELEASE</spring.cloud.version>

the static block is not needed anymore while having the following configuration in bootstrap.yml:
spring:
  profiles: dev,test
  cloud:
    consul:
      discovery:
        enabled: false
      config:
        enabled: false
    service-registry:
      auto-registration:
        enabled: false

So we can close it since it got fixed in Dalston.

You can try the following configuration.
default:
  my-prop: default-value

my:
  prop: ${default.my-prop}

java -jar --default.my-prop=xxx xxx.jar


Make sure artifact signing is applied after Maven configurations are created

This fixes an issue when only artifacts (w/o *.asc digital signatures) get uploaded to Sonatype when a new release is created.

btw, need to check that license, javadoc (dokkaJar), developers and scm are set in pom.xml for save-api and test-anakysis-core


Remove extra registration of TelemetrySource

This is now provided by hosting.

:shipit:

:shipit:
@Tratcher FYI


Genuine check feature

This PR add a feature for check if the ledger device is genuine.
I just have concern about how to detect if Ledger API NACK that the device is genuine? or they never NACK? if so we cannot hint the user that his device is not genuine... (or i miss something)

ACK. Tested using a Nano S and a S+.


no module named resources

Dear NiftyPET,
When I run the software in Jupyter Notebook line 16 in block 2 generates the following error.

This is the first time I have had this issue.  In the past this was not an issue when trying to perform an installation.
I thank you for your time and fast response.
Sincerely,
Leo Marecki

I installed resources via pip but then it is complaining about AttributeError: module 'resources' has no attribute 'ENBLAGG'. I'm not sure where to go here either.


feat: process ! as breaking change

Per the specification here, this treats ! as a breaking change indicator.
https://www.conventionalcommits.org/en/v1.0.0/#specification

Not sure if I'm doing node right, sorry

@metron2 Why did you close this? We're also running into this...


Toggle Block View and Unlinked Refs fixes

from: https://roamresearch.slack.com/archives/C016N2B66JU/p1686754645333909?thread_ts=1686683277.948409&cid=C016N2B66JU

SamePage email error example: https://github.com/samepage-network/samepage.network/blob/main/package/internal/sendExtensionError.ts

What handles or serves the localhost:3003 endpoint for the roamjs-components?

I took another stab at rebasing by doing a --hard reset.  Similar issues.
So I made the executive decision to create a new branch https://github.com/dvargas92495/roamjs-workbench/pull/417


jsx formatter does nothing when empty  line has 2 or more spaces

TS Template added by @mjbvz
TypeScript Version: 4.2.0-dev.20210126
Search Terms

format
format document

Issue Type: Bug
With the below .tsx file in the editor, pressing shift+alt+f does nothing. If I delete one of the two spaces on line 6 then it functions as expected. I am using the default formatter.
import React from 'react';
function App(): JSX.Element {
	return (

	Learn React

	);
}

VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz (4 x 2394)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.91GB (2.35GB free)

Process Argv
--crash-reporter-id f6d40bd1-e748-48ce-9355-576b0aa9ce40

Screen Reader
no

VM
44%

Extensions (19)

Extension
Author (truncated)
Version

overtype
ada
0.2.0

vscode-css-formatter
aes
1.0.1

htmltagwrap
bra
0.0.7

simple-search
bur
1.0.1

vscode-eslint
dba
2.1.14

vscode-ahk-manager
Den
0.0.18

json-tools
eri
1.0.2

vscode-browser-sync
jas
1.3.1

sftp
lix
1.12.9

remote-ssh
ms-
0.62.0

remote-ssh-edit
ms-
0.62.0

hexeditor
ms-
1.3.0

js-debug-nightly
ms-
2021.1.817

debugger-for-chrome
msj
4.12.11

LiveServer
rit
5.6.1

searchdocs
rob
0.0.3

html5-boilerplate
sid
1.1.1

vscode-autohotkey
sle
0.2.2

html-preview-vscode
tht
0.2.5

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221877
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30211401
wsl2promptcf:30224613
pythonvsdeb440cf:30242243
unusedprompt:30224610
folderexplorer:30224614
openfilemenucf:30224648
pythonvsded773:30236629
pythonvspyt875:30241730

I believe that TS is returning some strange ranges here that cause VS Code's formatter to fail. For this file that uses spaces :
function App(): JSX.Element {
  return (

  Learn React

  );
}

For result of format document is:
Result: [
    {
        "start": {
            "line": 4,
            "offset": 1
        },
        "end": {
            "line": 4,
            "offset": 3
        },
        "newText": "      "
    },
    {
        "start": {
            "line": 5,
            "offset": 1
        },
        "end": {
            "line": 5,
            "offset": 2
        },
        "newText": "      "
    },
    {
        "start": {
            "line": 5,
            "offset": 1
        },
        "end": {
            "line": 5,
            "offset": 3
        },
        "newText": ""
    }
]

I believe the bug  is that the second and third entries are overlapping edits, which we can't handle

I believe that TS is returning some strange ranges here that cause VS Code's formatter to fail. For this file that uses spaces :
function App(): JSX.Element {
  return (

  Learn React

  );
}

For result of format document is:
Result: [
    {
        "start": {
            "line": 4,
            "offset": 1
        },
        "end": {
            "line": 4,
            "offset": 3
        },
        "newText": "      "
    },
    {
        "start": {
            "line": 5,
            "offset": 1
        },
        "end": {
            "line": 5,
            "offset": 2
        },
        "newText": "      "
    },
    {
        "start": {
            "line": 5,
            "offset": 1
        },
        "end": {
            "line": 5,
            "offset": 3
        },
        "newText": ""
    }
]

I believe the bug  is that the second and third entries are overlapping edits, which we can't handle

This is already fixed in 4.3, probably by https://github.com/microsoft/TypeScript/pull/42671


Redis latency (30 seconds) on initial request

The first request I make to my redis cluster each time the application starts takes a long time, sometimes more then 30 seconds. Ever request after that is measured in ms. Is this expected? Should I just be doing a command every time the server starts so the first user action isn't delayed?
Or am I doing something wrong?
When my node app initializes I do the following.
var conf = require('../config');
var Redis = require('ioredis');
var cluster = new Redis.Cluster(conf.redis.servers,{
  "redisOptions": {
    "showFriendlyErrorStack": true
  }
});
module.exports = cluster;

The first request is normally something like
return redis.smembers('key').then(...)

To be clear the result is normally less then 20 elements and this in dev env where there is no other operations running on either the application or Redis servers.
Currently on `--<EMAIL_ADDRESS>however it was happening with older versions also.

Please enable the debug mode to see whether the logs help.

Interestingly when i set DEBUG=ioredis:* it works significantly better however 1 time it still took a while.
// This is where the application starts.
Sat, 07 Oct 2017 17:21:04 GMT ioredis:cluster status: [empty] -> connecting
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis status[app-devinone.circleblack.com:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis status[app-devinone.circleblack.com:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis status[app-devinone.circleblack.com:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:21:04 GMT ioredis:cluster getting slot cache from app-devinone.circleblack.com:8002
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis status[app-devinone.circleblack.com:8002]: wait -> connecting
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:04 GMT ioredis:redis status[app-devinone.circleblack.com:8001]: wait -> connecting
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connecting -> connect
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connect -> ready
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:21:05 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[app-devinone.circleblack.com:8000]: wait -> close
Sat, 07 Oct 2017 17:21:05 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[app-devinone.circleblack.com:8000]: close -> end
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:21:05 GMT ioredis:cluster status: connecting -> connect
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis queue command[0] -> cluster(info)
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: ready -> close
Sat, 07 Oct 2017 17:21:05 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: ready -> close
Sat, 07 Oct 2017 17:21:05 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: close -> end
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: wait -> connecting
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connecting -> connect
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis write command[0] -> info()
[2017-10-07 13:21:05.882] [INFO] api - [POST] [/securities] [371d881c-28e6-4fed-8f6e-817ea3e2450d] [Authenticating] email<EMAIL_ADDRESS>IP: ::ffff:<IP_ADDRESS> [T:13 A:2 Q:0 F:11]
[2017-10-07 13:21:05.882] [DEBUG] orm - [auth] [validateSession] [validating] // This is the first request to Redis
Sat, 07 Oct 2017 17:21:05 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connect -> ready
Sat, 07 Oct 2017 17:21:15 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> close
Sat, 07 Oct 2017 17:21:15 GMT ioredis:connection skip reconnecting because `retryStrategy` is not a function
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:21:15 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8001
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:21:15 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis queue command[0] -> cluster(info)
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8001]: ready -> close
Sat, 07 Oct 2017 17:21:15 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8001]: close -> end
Sat, 07 Oct 2017 17:21:15 GMT ioredis:redis status[<IP_ADDRESS>:8001]: wait -> connecting
Sat, 07 Oct 2017 17:21:16 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8001
Sat, 07 Oct 2017 17:21:16 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:17 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:21:17 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:21:17 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis queue command[0] -> cluster(info)
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: ready -> close
Sat, 07 Oct 2017 17:21:17 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:17 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:21:25 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connecting -> close
Sat, 07 Oct 2017 17:21:25 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis status[<IP_ADDRESS>:8001]: close -> end
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:21:25 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:21:26 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:21:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:21:26 GMT ioredis:redis queue command[0] -> cluster(slots)
// starts working here

Interesting when I set DEBUG=ioredis:* it seems to work better most of the time but is sometimes still slow.
Here is a log where <IP_ADDRESS> is the external ip of the remote redis server and <IP_ADDRESS> is the internal ip which is not directly accessible. What I really don't understand is how enabling debug helps the situation.
Sat, 07 Oct 2017 17:29:54 GMT ioredis:cluster status: [empty] -> connecting
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis status[url:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis status[url:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis status[url:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:29:54 GMT ioredis:cluster getting slot cache from url:8002
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis status[url:8002]: wait -> connecting
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:29:54 GMT ioredis:redis status[url:8000]: wait -> connecting
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[url:8001]: wait -> close
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[url:8001]: close -> end
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8001]: [empty] -> wait
Sat, 07 Oct 2017 17:29:55 GMT ioredis:cluster status: connecting -> connect
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: ready -> close
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: ready -> close
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
[2017-10-07 13:29:55.876] [INFO] api - [POST] [/securities] [7f5c8fdf-6eae-4396-95bb-bc444e9b8f72] [Authenticating]
[2017-10-07 13:29:55.876] [DEBUG] orm - [auth] [validateSession] [validating]
Sat, 07 Oct 2017 17:29:55 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:29:55 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8001]: wait -> connecting
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis queue command[0] -> cluster(info)
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: ready -> close
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connecting -> connect
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8001]: connect -> ready
Sat, 07 Oct 2017 17:29:55 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis write command[0] -> cluster(info)
Sat, 07 Oct 2017 17:29:55 GMT ioredis:cluster status: connect -> ready
Sat, 07 Oct 2017 17:29:55 GMT ioredis:cluster send 1 commands in offline queue
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:29:55 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:05 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> close
Sat, 07 Oct 2017 17:30:05 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:30:05 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> close
Sat, 07 Oct 2017 17:30:05 GMT ioredis:connection skip reconnecting because `retryStrategy` is not a function
Sat, 07 Oct 2017 17:30:05 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:30:06 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8002
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:30:06 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: ready -> close
Sat, 07 Oct 2017 17:30:06 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:06 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:30:06 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> close
Sat, 07 Oct 2017 17:30:06 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:30:06 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: ready -> close
Sat, 07 Oct 2017 17:30:06 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:06 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> close
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection skip reconnecting because `retryStrategy` is not a function
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:30:16 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8002
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:30:16 GMT ioredis:delayqueue send 1 commands in failover queue
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: ready -> close
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:16 GMT ioredis:cluster command expire is moved to <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8000
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection send 2 commands in offline queue
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> close
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
[2017-10-07 13:30:16.472] [INFO] api - [POST] [/securities] [7f5c8fdf-6eae-4396-95bb-bc444e9b8f72] [Authenticating] Session Validated
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis queue command[0] -> smembers(sessions:test-token:entitlements)
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: ready -> close
Sat, 07 Oct 2017 17:30:16 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:16 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
[2017-10-07 13:30:25.894] [DEBUG] orm - [auth] [validateSession] [validating]
Sat, 07 Oct 2017 17:30:25 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:connection error: Error: connect ETIMEDOUT
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> close
Sat, 07 Oct 2017 17:30:26 GMT ioredis:connection skip reconnecting because `retryStrategy` is not a function
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: close -> end
Sat, 07 Oct 2017 17:30:26 GMT ioredis:cluster getting slot cache from <IP_ADDRESS>:8002
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: wait -> connecting
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis queue command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connecting -> connect
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: connect -> ready
Sat, 07 Oct 2017 17:30:26 GMT ioredis:connection send 1 commands in offline queue
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis write command[0] -> cluster(slots)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: [empty] -> wait
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: [empty] -> wait
Sat, 07 Oct 2017 17:30:26 GMT ioredis:delayqueue send 2 commands in failover queue
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: wait -> connecting
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis queue command[0] -> smembers(sessions:test-token:entitlements)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis queue command[0] -> expire(sessions:test-token:entitlements,900)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connecting -> connect
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis write command[0] -> info()
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: ready -> close
Sat, 07 Oct 2017 17:30:26 GMT ioredis:connection skip reconnecting since the connection is manually closed.
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8002]: close -> end
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis status[<IP_ADDRESS>:8000]: connect -> ready
Sat, 07 Oct 2017 17:30:26 GMT ioredis:connection send 2 commands in offline queue
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis write command[0] -> smembers(sessions:test-token:entitlements)
Sat, 07 Oct 2017 17:30:26 GMT ioredis:redis write command[0] -> expire(sessions:test-token:entitlements,900)
[2017-10-07 13:30:26.665] [INFO] api - [POST] [/securities] [7f5c8fdf-6eae-4396-95bb-bc444e9b8f72] [Authenticating] Entitlements Gathered```

Your app had some troubles connecting to some of the nodes (see the timeout errors in the logs), and that's the cause of the issue.

Looking at the log I agree though I don't understand why it would..
I do know that when using the CLI there are no issues.
Also it seems to work considerably better when I have enabled DEBUG=ioredis:* which is very confusing.

I'm closing this since it seems not related with ioredis. Feel free to reopen this issue if the problem still exists.


add endpoint slice handler

Signed-off-by: lmxia<EMAIL_ADDRESS>
What type of PR is this?
Feature add. Add endpoint slice event handler.
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Add remove endpoint slices logic, if endpoint slices exist in parent cluster but not in child cluster.

Codecov Report

Merging #435 (81deb97) into main (73325a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   13.72%   13.72%
=======================================
  Files          61       61
  Lines        6595     6595
=======================================
  Hits          905      905
  Misses       5623     5623
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73325a4...81deb97. Read the comment docs.


jib.to.image push to multiple repositories

Environment:

Jib version: 1.1.2
Build tool: Gradle v1.1.2
OS: MacOS

Description of the issue:
Seeking a way to push the same image to multiple image repositories.  We have a need  where we need to host our images in both DockerHub and ECR, the documentation doesn't make any reference to if this is possible.
If it is in-fact possible, if someone can explain it here, I'd be happy to help update the documentation for the gradle plugin as needed.
Expected behavior:
Allow a means to specify multiple jib.to.image values, such as via a comma separated list, with the expectation that each image provided will be pushed to the correct docker respository.
Steps to reproduce:

Create a container repo on dockerhub and ECR
Try to push one docker container to both repo's in one build.

jib-gradle-plugin Configuration:
jib {
	to {
		tags ['latest', 'develop']
		// one possibility:
                image "organization/repo, id.dkr.ecr.us-west-2.amazonaws.com/repo"
		// second possibility:
		image ['organization/repo', 'id.dkr.ecr.us-west-2.amazonaws.com/repo']
    }
}

Log output:
Caused by: com.google.cloud.tools.jib.image.InvalidImageReferenceException: Invalid image reference: org/repo,id.dkr.ecr.us-east-1.amazonaws.com/repo
--- OR ---

What went wrong:
Script compilation errors:

  Line 133:         image=listOf("org/repo","id.dkr.ecr.us-east-1.amazonaws.com/repo")
                          ^ Type mismatch: inferred type is List<String> but String? was expected

My log output is from a kotlin gradle buildscript, but I think the concepts apply no matter the buildscript language - there does not appear to be a way to specify 2 image locations to be able to push an image to 2 image repos via one build.
There is a workaround specified here but it feels somewhat un-natural and so I wonder if this tool should support this use case?

Hi @Bwvolleyball,
As you noticed, this is not supported, and implementing this is not an easy task this than you can imagine for a few technical and non-technical reasons.
First of all, Jib provides a lot of ways and configuration options to provide credentials to both the base image repository and the target repository. (For example, you can pass -Djib.to.auth.username=myaccount on the command line.) Allowing multiple target repositories mean we need to sort out a new compatible design for specifying registry credentials. This is doable, but configurations will become more complex, and a lot of code handling these configuration options should change as well. And of course, coming up with a good configuration design should be the first step and needs careful thoughts too.
And there are other things that need to think about, which may determine the scope of the work needed. For example, what to do if authentication works for one target registry but does not for another registry? Should Jib fail right away, or upload only a subset of images and fail later? What about general registry error handling? Yeah, we will be able implement this, but this requires a lot of effort.
All these boil down to how much value we can add considering that there is a reasonable workaround: you can parameterize jib.to.image. There are many ways you can parameterize various Jib configurations in Maven and Gradle. And running two Jib commands as as workaround shouldn't be bad. Everything is cached, and it will not be slower than when this feature is directly supported in Jib.
One day, we may eventually implement this feature. However, unfortunately, I don't think that will happen anytime soon.
Lastly,
		tags ['latest', 'develop']

No need to have latest in tags. latest is already implied in image (i.e., id.dkr.ecr.us-west-2.amazonaws.com/repo:latest.

Why not loop and push in a fashion similar to this?
buildCmd -Djib.to.image=foo
buildCmd -Djib.to.image=bar
```

I'm going with the @OneCricketeer method, for now, but am disappointed by my build time in CI doubling. I'm considering a vector where we build once with jib to a local image, and then do the shipping to repository manually.

I wouldn't worry too much about running Jib multiple times. Everything built for an image is cached and reused (thanks to the strong reproducibility of Jib), so subsequent runs will be no-op regarding building something.

I agree, @chanseokoh based on our experience so far. Subsequent jib runs are very fast.

I have a similar requirement to push an image to different ECR repositories depending on the branch being built.
For now I use an approach based on what is described here: https://github.com/GoogleContainerTools/jib/issues/802#issuecomment-415041916
What would really help though is if I could separate the registry name and path, so I could easily vary the registry that is pushed to using something like -Djib.to.registry.


[sharktank] Update perplexity CI install

Update perplexity CI install with nightly releases

We want to pull in iree pre-release rather than stable to catch regressions earlier and fix it.

Makes sense. But I think we can at least use stable instead of pinned version (which needs to be updated every time). So pre-submits will have stable to unblock PRs & track shark-ai regressions and nightly will have pre-release tested. Reopening this.

@ScottTodd As you can see the pre-submit CIs seem to be using different iree-turbine/compiler versions although workflow yaml has same command, possible caching env.
What's a reliable way to pull the latest stable IREE release? Or do we just pin to latest known good version? If latter, we need a schedule to update good IREE version across all pre-submits.

@ScottTodd As you can see the pre-submit CIs seem to be using different iree-turbine/compiler versions although workflow yaml has same command, possible caching env. What's a reliable way to pull the latest stable IREE release? Or do we just pin to latest known good version? If latter, we need a schedule to update good IREE version across all pre-submits.

Can you link specific logs? This PR now is changing much more than originally stated.
I'd like to highlight two things:

We've observed https://github.com/iree-org/iree/issues/19305 in a few places. The most reliable way to install packages is into a clean venv and no pip cache.
Most/all of these workflows are due for a deep refactoring: https://github.com/nod-ai/shark-ai/issues/584. I'll be finishing https://github.com/nod-ai/shark-ai/pull/589 and updating the workflows soon.

@ScottTodd As you can see the pre-submit CIs seem to be using different iree-turbine/compiler versions although workflow yaml has same command, possible caching env. What's a reliable way to pull the latest stable IREE release? Or do we just pin to latest known good version? If latter, we need a schedule to update good IREE version across all pre-submits.

Can you link specific logs? This PR now is changing much more than originally stated.
I'd like to highlight two things:

We've observed Strange behavior trying to upgrade iree-base-compiler Python package iree-org/iree#19305 in a few places. The most reliable way to install packages is into a clean venv and no pip cache.
Most/all of these workflows are due for a deep refactoring: Rework GitHub Actions workflows to build packages --> test packages #584. I'll be finishing Create pkgci.yml and pkgci_build_packages.yml. #589 and updating the workflows soon.

Agree the PR is growing bigger, intention was to align all pre-submits. If PRs 584 & 589 are addressing these issues, I can rollback all CI changes except perplexity one.
For context though, here are the logs for inconsistent installation (probably linked to PR 19305). Perplexity CI has pre-release versions but consistent installs but benchmark has inconsistent installs, probably cached installs.

My first bullet point there should be addressed with https://github.com/nod-ai/shark-ai/pull/640. We could rebase this on top once that lands. I don't have a very clear timeline yet for the two other items.

My first bullet point there should be addressed with #640. We could rebase this on top once that lands. I don't have a very clear timeline yet for the two other items.

Great, I believe the only dependency of this PR to work as expected is #640 which resolves the unstable behavior. So when we install iree-turbine==3.0.0, it will get us iree-base-runtime==3.0.0 and iree-base-compiler==3.0.0. Points 2 and 3 can be addressed in a separate PR.
Reason for urgency is every time an IREE regression happens, unpinned IREE crashes pre-submits and blocks PR merges, like today's regression. Pre-submits must only catch sharktank regressions and nightly should catch IREE/sharktank+IREE ones.

Reason for urgency is every time an IREE regression happens, unpinned IREE crashes pre-submits and blocks PR merges, like today's regression. Pre-submits must only catch sharktank regressions and nightly should catch IREE/sharktank+IREE ones.

I'm more than aware - re-architecting the workflows so this class of issues is removed has been my main priority these past few weeks.


Upgrade PivotTable.js and enable TSV export

This should close hudl/fulla#139.
I simply upgraded the PivotTable.js library and included the export_renderers.js file and passed the new renderers into pivotUI().

This looks good to me! Any idea how it performs with larger pivot tables?

Yeah just so-so. There are two issues that we will probably want to address eventually.
First, when it's large horizontally the pivot table spills off the screen similar to how the results spill off the screen in the Table view if you have too many columns.

Second, if you have multiple fields in the same dimension, it gets serialized as <field1>-<field2> instead of with multiple levels like I would expect:

becomes

Oh, that's strange. Although that might be okay? It seems like that might be an easier format to work with in Excel.

Yeah that makes sense. At the very least I don't think it's a problem we want to spend a bunch of time solving right now.


Web support

Please add web support to AppKit

Hello @nuzhata, a long discussion about it has been made here in old Web3Modal repo.
As a result of this discussion a couple of side project from the community were born in order to bring web support to the now deprecated Web3Modal but the same idea would apply for Reown's AppKit.
That being said, we would totally love to fully support web on AppKit Flutter but, without mentioning that would be really huge lift, right now it is just not a priority.
Maybe @Sam-Newman could bring some more insights about the roadmap.


sm3 initial implementation

Closes #10
My implementation is based on jax.experimental.optim implementation.
Still need to:

[x] Add documentation
[x] Add & run tests

Any feedback/review is appreciated!

This looks great!
Could you add tests?

An equivalence test comparing to experimental.optimizers would also be nice since your implementation is based on that

I added the documentation, but right now the transform doesn't run, it errors with:
TypeError: list indices must be integers or slices, not DynamicJaxprTracer

Caused by the splice function. Any idea how to fix it @mtthss ?

Hey @mtthss it's now passing the tests and I added the docstring :D

Awesome! Could you just add also an equivalence test in equivalence_test.py verifying equivalence to jax.experimental.optiimizer's version?

Also there seem to be some lint errors in Github presebmit checkx

Hello! Would be great to merge this!
Could you fix the lint errors and resolve conflicts?

Sorry about being so slow, I'm doing an internship right now and don't have as much time as I used to, is it ok for me to fix this tomorrow morning?

Of course! Whenever works for you!
Your contributions are much appreciated!

My version fails with general pytrees, I need to run that max operation for each vector in the pytree, though I'm not sure how to do it (it would be like stopping the tree_map right before the leaves)

Shouldn't the jax.experimental.optimizers also have solved the same issue already?
Can we follow the same approach as them?

So @mtthss I spoke with Rohan Anil (one of the authors) and he explained to me the shape magic they do and now the optimizer is passing all tests and is more complete than the jax.optimizers version \o/

This was great, thanks a lot for the contribution!

This is awesome @joaogui1
@mtthss I can expand the sm3 description based on https://arxiv.org/pdf/1901.11150.pdf after this PR is merged 👍

Thanks @joaogui1 for the great contribution, this is now merged!
@8bitmp3 if you take expanding the description that would be great thx!


test: fix incorrect deletion statement for policy

The deletion of policy should be done via the Delete function call instead of the
Namespace delete function call; fix an incorrect usage of this in the Policies.go
file accordingly.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>This will help stabilize the CI and eliminate the issue documented in #7902. This does not fix the issue (as it appears that L7 ingress policy to the host is broken in current master).

This change is

test-me-please

Coverage increased (+0.06%) to 41.842% when pulling bb14c99c4f537dbfd9bf631b72c6db82891e255a on pr/ianvernon/delete-leftover-policy-secondns into c05477469de2890449efcf5418f88c61eddaa947 on master.


fix(bugs): Update dependencies and enhance UI components

fixes https://github.com/cornerstonejs/cornerstone3D/issues/1500 , fixes https://github.com/cornerstonejs/cornerstone3D/issues/1572,  fixes https://github.com/OHIF/Viewers/issues/4218
This pull request includes various updates and improvements across multiple files, primarily focusing on dependency updates and enhancements to segmentation handling and UI components.
Dependency Updates:

Updated @cornerstonejs/adapters, @cornerstonejs/core, and @cornerstonejs/tools dependencies to version ^2.2.1 in multiple package.json files. [1] [2] [3] [4] [5] [6] [7]

Segmentation Handling Enhancements:

Added a command to update stored segmentation presentations before hydrating the SEG in OHIFCornerstoneSEGViewport.tsx.
Modified the commandsModule to use addSegmentationPresentationItem instead of setSegmentationPresentation and updated related methods. [1] [2] [3] [4]
Added onModeEnter and onModeExit methods to SegmentationService to handle initialization and cleanup. [1] [2]
Updated useSegmentationPresentationStore to use addSegmentationPresentationItem and adjusted related logic. [1] [2] [3]

UI Component Improvements:

Refactored SidePanelWithServices to manage panel open state and handle tab activation more effectively. [1] [2] [3]
Simplified the getStatisticDisplayString function by removing HTML tags from the output.

Other Changes:

Removed an unused import in OHIFCornerstoneSEGViewport.tsx.
Cleaned up the PanelSegmentation component by removing unused props and improving method parameter structures. [1] [2] [3]
Added checks to ensure volumes are loaded before proceeding in CornerstoneViewportService. [1] [2]

Continuation of discussion in the cornerstone3D repo

I am now able to load both segmentations in this dataset. Thanks for fixing this.

However,

the colors are not display properly.
one is supposed to be green and other is supposed to be red

confirmed via pydicom

But I see this in the latest https://viewer-dev.ohif.org/localbasic

Also if I just load the modality=SEG with green, it shows green too.

Can you create another issue?


Features to support baccawl

User registration
JWT token obtain endpoint
auth with ssh key
save ssh public key

Done.