Linting : Proof-of-concept stylistic refactorings

This replaces the previous closed pull request, pulling from a different branch (apthorpe:linting instead of apthorpe:master). acentric.py and activity.py have been modified based on previous discussion and results of analysis with updated versions of pylint and flake8. Additionally, pylintrc has been added to the project to avoid the use of local pylint directives in the source.

Hello again Bob,
As a reminder, the issues outstanding are:

Failing doctests
Remove the imports you noticed weren't used, instead of just commenting them out
The rename of "bubble_at_P" cannot be merged because the author of that contribution is already using that function; it will have to continue with the name "bubble_at_P".
In several places, you add a "#" style comment to the top of a function which has poor documentation. Docstrings are special, and need to be the first comment present in a function; the TODOs need to come after the docstrings. The docstring won't render in the documentation without this, and it won't appears as function.
Add "and contributors" to the docstring in copyright notices of the edited files, and 2016-2017, if you'd like to.

About the doctests, for instance, you changed:
{'H': 0.03639798802478244, 'C': 0.7228692758981262, 'O': 0.24073273607709128}
to be
{'H': 0.03639798802478244, 'C': 0.7228692758981262,
'O': 0.24073273607709128}

But the doctests will fail because of that change; they do not support handling multiple lines of output. All the output has to be on line line.
Another thing about doctests - you're changing some of them from
>>> thermal_conductivity_Magomedov(293., 1E6, [.25], ['7758-94-3'], k_w=0.59827)
to be:
>>> thermal_conductivity_Magomedov(293., 1E6, [.25], ['7758-94-3'],
...                                k_w=0.59827)

which I am happy for except all the extra spaces between the "..." and the "k_w=0.59827". So far as I know projects do not use this syntax, as it's better for the user to be able to copy the example and run it with as little work as possible. The preferred form is:
>>> thermal_conductivity_Magomedov(293., 1E6, [.25], ['7758-94-3'],
... k_w=0.59827)

You've done a great job of working on the documentation for some undocumented functions! Thank you very much for that. I hope to supplement them even more.
If you have any questions about the requested changes, please feel free to ask!
Sincerely,
Caleb

@CalebBell The space-indented form of:
>>> thermal_conductivity_Magomedov(293., 1E6, [.25], ['7758-94-3'],
...                                k_w=0.59827)

is common and recommended by Python's official style guide.  The "preferred form" you requested is forbidden by Python's style guide.

Hi Bob,
I'm sorry this never went anywhere. At this point in my life not interested in improving the style, there are way too many larger and more important issues.
Pylint is extremely opinionated, and everywhere I see it used, an awful of of its rules are disabled. Only the errors category interests me at this point. I do have a .pylintrc file that is used for that purpose in thermo now but I definitely am not running it regularly or over all files. Sometimes it misses things too, claims things are errors when they aren't.
I hope all is well in your life!
@alexchandel I don't think everything in pep8 is suitable for every project; this project follows it loosely. I am also extremely done with 80 character lines being forced, I think it wastes millions of people-hours every year. If I had to put a space on either side of every multiply sign, thermo would be much harder for me to follow.
Sincerely,
Caleb


Issue/38/download

Download data table if you don't have it (needed for pip installs). Started documentation on columns.

Merging, despite travis failing - its just the requirements ordering I think


[Backport] [BUG] Volume creating with Backing Image contains invalid checksum string will result in attaching problem

ref #3133

PR: https://github.com/longhorn/longhorn-manager/pull/1106


Implementing NetPlay?

Would it be possible to implement online netplay for 2-4 player games.  If so what would be needed?   How could it be done?
I am definitely willing to help if it was something possible.
Thanks!

Nesbox supports online netplay between 2 players via P2P but it's disabled now.
https://github.com/nesbox/emulator/blob/master/src/network/NetworkSession.as

Would I be able to enable this?  I would love to host this for NHL94 on Sega genesis for a place for players to easily play games with each other without any added software.
What if I ran this on my own server?  I'd really appreciate any help with this.
Let me know if it's possible! Thanks.

Hi,
unfortunately I'm working with another project and don't have any time now.
you don't need your own server because it works via P2P.
So, you can try to understand how to enable network or hire someone, all
the sources are on github.
Or wait when I'll have free time.
Thanks.
On Sat, Nov 12, 2016 at 10:41 PM, T Kang<EMAIL_ADDRESS>wrote:

Would I be able to enable this? I would love to host this for NHL94 on
Sega genesis for a place for players to easily play games with each other
without any added software.
What if I ran this on my own server? I'd really appreciate any help with
this.
Let me know if it's possible! Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nesbox/emulator/issues/54#issuecomment-260143549, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABDOiFbObAFa2d4OMc0iGt8H20tSBnD0ks5q9hZkgaJpZM4Kvgzt
.

--
Vadim Grigoruk
<EMAIL_ADDRESS>


Implement validation in OSBuildTarget

The OSBuildTarget has a dummy validation method. Let's make it actually apply the schemas to validate the output.

Hi, I am a programming student, looking to contribute to an open source program. I believe this program is of a suitable level where I can make suitable level contribution. Could I please be assigned this issue?


allow yalc to add dev dependencies

we store our consistent typescript versions along with test dependencies in one package, and being able to yalc add/publish them as they are updated (via dev dependencies) would be very useful.
I am working around it by just adding and then moving the dep.
(thank you for addressing this glaring problem with "link")

Sorry, I'm not sure I get what you mean )

allow yalc to add dev dependencies

You can do yalc add package --dev like in yarn.

ah, its not in the documentation and i use --save-dev in yarn, and that
didn't work :-)
On Sat, Mar 24, 2018 at 12:10 PM, Alex<EMAIL_ADDRESS>wrote:

Sorry, I'm not sure I get what you mean )
allow yalc to add dev dependencies
You can do yalc add package --dev like in yarn.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/whitecolor/yalc/issues/18#issuecomment-375821648, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADZ2BjkewsHXM82zdPqa7IiV-Ixcmruks5thYDQgaJpZM4S5URq
.

--
Richard Vowles,
Groovy, Java, Javascript, AngularJS - Contract Software for Hire!
ph: +64275467747, web: www.google.com/+RichardVowles

Ok, I've added --save-dev alias and updated readme.


Product export

Description

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

Had another quick look,  new changes as recommended are looking good. just few minor issues(not show stoppers) I've noticed otherwise all good. Nice to see product name on supporting information tabs.

Cases id column not show square brackets[] for empty values, also would be nice to get rid of square brackets and make it consistent with other column values
Also marking column show values in square brackets which I think not needed, we can show comma separate for more than one value.

I think we want @DH02 to review this page

@KyleMacPherson @slorek
Ignoring the header and footer (which will form a separate review another time) and only looking at the attached screenshot, I have some simple amendments - sorry, if some are repeated (as I can't view the HTML): below.

To ensure we are using the correct font family I have added a class to the P tag (govuk-body)
To ensure the link is styled correctly (and supports various GDS states, I have added classes to the A tag
To ensure the download behaves as expected I've added the "download" boolean attribute. (You can also write x="x" in lowercase)
For accessibility we should avoid "Click here" text - I have changed the link text
As the link sits in the page by itself I've increased the font size
Without seeing it in the page I've assumed a little margin (classes) won't go a miss too. (You can remove one or more "margin" classes if required, or change 8 to 6 if required?)

Download your product export.

Thanks

@KyleMacPherson @slorek
Ignoring the header and footer (which will form a separate review another time) and only looking at the attached screenshot, I have some simple amendments - sorry, if some are repeated (as I can't view the HTML): below.

To ensure we are using the correct font family I have added a class to the P tag (govuk-body)
To ensure the link is styled correctly (and supports various GDS states, I have added classes to the A tag)
To ensure the download behaves as expected I've added the "download" boolean attribute. (You can also write x="x" in lowercase)
For accessibility we should avoid "Click here" text - I have changed the link text
As the link sits in the page by itself I've increased the font size
Without seeing it in the page I've assumed a little margin (classes) won't go a miss too. (You can remove one or more "margin" classes if required, or change 8 to 6 if required?)

        Download your product export.

Thanks

Thanks Darren, this is a screenshot after implementing your suggestions, and some of Steve's from the comments.

@KyleMacPherson @slorek
Ignoring the header and footer (which will form a separate review another time) and only looking at the attached screenshot, I have some simple amendments - sorry, if some are repeated (as I can't view the HTML): below.

To ensure we are using the correct font family I have added a class to the P tag (govuk-body)
To ensure the link is styled correctly (and supports various GDS states, I have added classes to the A tag)
To ensure the download behaves as expected I've added the "download" boolean attribute. (You can also write x="x" in lowercase)
For accessibility we should avoid "Click here" text - I have changed the link text
As the link sits in the page by itself I've increased the font size
Without seeing it in the page I've assumed a little margin (classes) won't go a miss too. (You can remove one or more "margin" classes if required, or change 8 to 6 if required?)

        Download your product export.

Thanks

Thanks @DH02, this is a screenshot after implementing your suggestions, and some of @slorek's from the comments.

That looks fine, but a full-stop at the end would be nice?! Thanks.


[forwardport] catalog app is still showing when all of the templates are hidden by max_rancher_version

forwardport https://github.com/rancher/rancher/issues/23295

Available in master.

waiting for preview build to validate this issue.

Verified with rancher:v2.4.0-alpha1
Steps:

Add a catalog app: which has all of the templates hidden by max_rancher_version.
Go to Apps --> Launch
User will NOT be able to see the app (hidden by the rancher_max_version)
App here is fluentd-aggregator


In IOS devices: client_id mismatch. The code was not issued to com.xxxx.xxxx.xxxx

In IOS applications, Sign in with Apple could only be working with using apple bundle Id rather than apple clientId. If clientId value is used, the apple validation service gives following error:
{
"error": "invalid_grant",
"error_description": "client_id mismatch. The code was not issued to com.xxxx.xxxx.xxxx"
}
In Apple's Site: "If you are authorizing on iOS, the authorization grant code validation must use the iOS bundle ID as well; otherwise, if you received the grant code via your client_id should be your Services ID created for the web application. Whenever these client_id values mismatch, the grant code validation will fail as the code was issued for another client."

Yes, that is correct. When using Sign in with Apple in iOS applications, the client_id should be set to the Services ID created for the iOS application, not the bundle ID. This is because the authorization grant code validation must use the iOS bundle ID as well. If the client_id value does not match the Services ID created for the iOS application, the grant code validation will fail and you will receive the "client_id mismatch" error.
It's important to note that the client_id value should be set to the Services ID created for the web application when authorizing on non-iOS platforms, such as web or Android.
In summary, when using Sign in with Apple in iOS applications, you should use the Services ID created for the iOS application as the client_id value for authorization grant code validation.
Please refer to this post: https://blog.devgenius.io/how-to-implement-apple-login-with-nestjs-in-seconds-b88f05abe847

The original purpose of this code snippet was just to serve as an example for Nestjs players, so the requirements mentioned can be modified according to your own needs.


Misleading help

Issue Type

Bug report

Molecule and Ansible details
molecule, version 2.15.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Actual Behaviour (Bug report only)
  --destroy [always|never]        The destroy strategy used at the conclusion
                                  of a Molecule run (always).

The inline help state "at the conclusion". I found that very convenient and added it to my pipeline. On the second run I realized that destroy is skipper both at the beginning and the end of the run
--> Test matrix

└── default
    ├── lint
    ├── destroy
    ├── dependency
    ├── syntax
    ├── create
    ├── prepare
    ├── converge
    ├── idempotence
    ├── side_effect
    ├── verify
    └── destroy

--> Scenario: 'default'
--> Action: 'lint'
--> Executing Yamllint on files found in /home/gitlab-runner/builds/54a89bc8/0/r.garrigue.ext/ansible-role-webenv/...
Lint completed successfully.
--> Executing Flake8 on files found in /home/gitlab-runner/builds/54a89bc8/0/r.garrigue.ext/ansible-role-webenv/molecule/default/tests/...
Lint completed successfully.
--> Executing Ansible Lint on /home/gitlab-runner/builds/54a89bc8/0/r.garrigue.ext/ansible-role-webenv/molecule/default/playbook.yml...
Lint completed successfully.
--> Scenario: 'default'
--> Action: 'destroy'
Skipping, '--destroy=never' requested.

Maybe it's a bug, or the way the option are named it's intentional and the --help is unclear.
On which case I'ld suggest to add two more options, [always|beginning|end|never]. In a debugging period, my own behavior is to run molecule again and again, investigating at the end of each failed run. For which I need the container to stay live. And it's more convenient to have them destroyed at start to avoid fixing stuff on a second run.
Best regards,

In a debugging period, my own behavior is to run molecule again and again, investigating at the end of each failed run. For which I need the container to stay live.

You can use molecule converge for that.

I think his point is that molecule converge doesn't recreate the containers, though I don't think that's a problem, really.  If you need a fresh set of containers just do the molecule destroy before doing the converge.

In a debugging period, my own behavior is to run molecule again and again, investigating at the end of each failed run. For which I need the container to stay live.

You can use molecule converge for that.

Yeah, that's the recommend way to use Molecule for this case.


Sp fixes vest

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 13 (92.31%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 43.891%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/base/FuroVesting.sol
12
13
92.31%

Files with Coverage Reduction
New Missed Lines
%

contracts/utils/BoringOwnable.sol
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
204

Relevant Lines:
437

💛  - Coveralls


deploy to the Cloud

This feature enhancement allows Spin users to deploy their applications to the Cloud.
><> cd examples/http-rust

><> spin build
Executing the build command for component hello: cargo build --target wasm32-wasi --release
    Finished release [optimized] target(s) in 0.01s
Successfully ran the build command for the Spin components.

><> spin deploy --hippo-server ***************
Open the Cloud's device authorization URL in your browser: ***********/device-authorization and enter the code: ******
The code has been copied to your clipboard for convenience.
Waiting for device authorization...
Device authorized!
Deployed spin-hello-world version 1.0.0
Application is running at spin-hello-world-61fr9ys5.*************

><> curl https://spin-hello-world-61fr9ys5.*************/hello
Hello, Fermyon!

A couple of open comments/questions for the reviewer:

Because of the reliance on copypasta, Spin developers will need to install xorg-dev to compile against Linux. Where should we document this? Docs? README?
On every invocation to spin deploy, the command will prompt for a new device code. This is because spin deploy does not store any configuration. Is this something we should track, or is the current behaviour okay?
There's a bunch of code duplication - specifically surrounding crates/cloud/src/registry/bindle and crates/publish. This is an area worth looking at a little closer. (cc @radu-matei)
All of the spin deploy flags are prefixed with --hippo-*. Is this worth re-naming these? (he says, as he asks the most difficult issue in the engineering world... Naming things)

I thought we were going to do something like spin login for environments with persistent login tokens.  Then spin deploy would gain a --token option to go alongside --hippo-password.
I feel like we could do with a SIP to figure out things like this and the clipboard overwrite issue and the persistence model and all that... what do you reckon?

./target/release/spin login --status
You are logged into http://localhost:5301
Your session will expire on 2022-10-12 19:31:21 +00:00.

Okay. Everything except for shunting back to spin login when the file is not found or the token has expired has been implemented. Please feel free to give this a test.

This is really nice and super smooth!
One niggle I spotted.  In the GH auth scenario we proxy Bindle; if this is far away then you can get this:
ivan@hecate:~/testing/deploytest$ ~/github/spin/target/debug/spin deploy
<URL> is responding slowly or not responding...

<URL>/api/registry is responding slowly or not responding...

Could we spot the proxy case and emit only one sloth warning?  Sorry to nitpick.

Not sure if the PR is ready for feedback at this level, but the error mode if the Hippo server doesn't exist is that it does nothing for about 15 (?) seconds then prints Error: expected value at line 1 column 1.
(This was hitting a URL that had previously existed as a AWS Hippo instance, but had been terraform destroyed.  Hitting a completely made-up domain gives the same message but a lot quicker!)

To reproduce that issue, did you stand up a cluster, run spin login, shut down the cluster, then ran spin deploy?

My specific scenario - and the weird and dev-specific way it happened may mean it's not a real issue - was:

Build this PR
spin login using GH auth and do a deployment
Switch back to Spin main
Create an AWS cluster using the installer, export the environment variables (all as per installer instructions), do a deployment
Destroy the AWS cluster (terraform destroy)
Switch back to this PR
spin login which this time picked up the dangling Hippo environment variables

To be clear, it was that last login which gave the error, not any deploy.

I managed to reproduce https://github.com/fermyon/spin/pull/794#issuecomment-1270643405:
><> env | grep HIPPO
HIPPO_PASSWORD=bar
HIPPO_USERNAME=foo
HIPPO_URL=http://localhost:5309
><> env | grep BINDLE
BINDLE_URL=http://localhost:8080/v1
><> spin login
What authentication method does this server support?

1. Sign in with GitHub
2. Sign in with a username and password

Enter a number: 2
Error: expected value at line 1 column 1

The actual error is this:
error in reqwest: error sending request for url (http://localhost:5309/api/auth-tokens): error trying to connect: tcp connect error: Connection refused (os error 111)

This is because the call to format_login_error on line 182 does not account for tcp connection errors. It always assumes the input error string will be JSON.
This code was present on main as well... I'll see about fixing the error message.


Explore using different text distances to produce groupings

Try using a lot of different text distance metrics to see which gives the best results for clustering

I attached the output of some column matching that I ran. After counting the frequencies of all column names, I took the top 200 columns and tried to match it against all the other columns, then picked an arbitrary similarity score threshold of >65% match. The csv files attached are the resulting matches, ordered by score.
There are two results using two distances metrics.

levenshein_ratio_matches.csv: just uses levenshtein distance to calculate a score (hence no 100% match)
token_sort_ratio_matches: tokenizes and sorts the string before comparison – hence solves “out of order” issues

Some brief observations:

Plain levenshtein distance is good for capturing obvious cases where the columns are referring to the same thing, and good for catching typos
Token_sort_ratio is good for catching out-of-order cases eg. “% student” vs “student %” will yield 100% match

We will need some form of human input and discretionary decision making to identify columns referring to the same entity. I was also working on some code to display the names of the datasets that the column names appear in. Maybe we could have an app that presents likely matches and have a human confirm it, and on ambiguous cases, present more information eg. which datasets contain said column name, and maybe present some column values too if the user selects a dataset to look at.

Closing stale issues as part of task triage and preparing for a new roadmap


i will

i will
many thanks
2016-12-18 3:10 GMT+01:00 Antonio Ruballos<EMAIL_ADDRESS>
Hello Linuxvalley,
I'm sure its possible by creating a developer account on ebay.it and
receiving a development key for that account and using that key instead of
the current key (and making requests to the appropriate URLs).
Unfortunately I can't read italian to confirm that. Perhaps give it a try
and see what you find?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aruballo/ebayTrends/issues/6#issuecomment-267798963,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATaXK4TGkIAaEzEe3X9f1KO3IKmdPcUuks5rJJYTgaJpZM4Kzwe3
.

Originally posted by @linuxvalley in https://github.com/aruballo/ebayTrends/issues/6#issuecomment-268194848

pi合约代码0x05968227eb31532cc2c2ec30c3c0f8562a1aac76


igv: 2.4.19 -> 2.8.0

Motivation for this change
Adding igvtools, lot's of new features.
The license has been changed to mit:
https://software.broadinstitute.org/software/igv/download
Things done

[x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x ] Ensured that relevant documentation is up to date
[x ] Fits CONTRIBUTING.md.

I have tested it locally, both igv itself and igvtools for the count tool. Everything seems to work fine without any issues.
I've used openjdk11 because I didn't find a jre for 11. Don't know what has changed on the jvm side with respect to this.

could you have a look when you have time @mimame  ?

2.8.4 is available: https://software.broadinstitute.org/software/igv/download

Updated to the latest version and did some cleanups


Command line script and renaming Brackets.sh -> brackets.sh

This change contains the following changes

Renames Brackets.sh to brackets.sh
Made some changes to script that fixes a unit testing bug
Update the gyp script to copy brackets.sh instead of Brackets.sh

@nethip A couple small items here, but after that it should be good to merge.

Looks good now -- merging


Background of log out

Make the default background for the logout notification specific to the role of the user (i.e. student v. faculty)

What do you mean default background? What url is it on?

http://weave.hms.harvard.edu/

Sorry I know I posted this error but Jane was really the one who found it. My understanding was that when she was logged in as a faculty member, at one point she left the session on for an hour and was prompted with a logout notification, when this occured (if I remember correctly) the background page for some reason was the student homepage.
I have left a session on in order to get the logout notification and for me the background page was whatever page I was on; it did not reroute to any apparent "default" background page. Jane could you help clarify?

The logout notification worked for me yesterday when I left a session open
for a few hours, though only when I navigated around the website with a few
clicks and going to other pages. Can we have the logout notification come
up at the point when the logout occurs? Someone could conceivably leave the
faculty profile open, complete it after the logout time, but not get the
notification until they try to save their profile and get frustrated that
they have to input their information all over again.
The background page I was talking about was a half-loaded screen with the
logout notification that sometimes occurs when I first navigate to the
website for the day. Razzi, you had mentioned this might have to do with
the cache. It hasn't happened for me in the past couple days. We can
resolve this as an issue.
On Thu, Oct 4, 2018 at 7:04 AM JonKusner<EMAIL_ADDRESS>wrote:

Sorry I know I posted this error but Jane was really the one who found it.
My understanding was that when she was logged in as a faculty member, at
one point she left the session on for an hour and was prompted with a
logout notification, when this occured (if I remember correctly) the
background page for some reason was the student homepage.
I have left a session on in order to get the logout notification and for
me the background page was whatever page I was on; it did not reroute to
any apparent "default" background page. Jane could you help clarify?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/2#issuecomment-427031391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApxaUeHfBQNhmwnUzriZFN_IqM86jdm5ks5uhhVggaJpZM4XFMEj
.


PowerShell Keyboard Shortcuts CTRL+SPACE missing

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Microsoft Windows NT 10.0.18363.0
Windows Terminal (Preview) 0.9.433.0
Steps to reproduce
Open PowerShell
Type "ls -" and the press CTRL+SPACE
Expected behavior

See a list of parameter options for ls
Actual behavior

No output

Thanks! This is a /dupe of #879.

Reproducing only on Windows Powershell, Powershell Core seems to work fine.


Proposal: rename app

I propose that this app be renamed (or forked to a new name) that focuses on the idea of providing a unified view of messaging activity within Gmail.
I think this would help with two things:

reduce people asking for "save locally" as a feature;
improve the chances that Google would recognize this as "a Gmail app", and thus approve it to use the "sensitive" scope API calls.

If it's a matter of forking, then I'd suggest splitting off the "phone call timeline" into a separate App. Or even taking the OpenIntents approach of making several small modular cooperating apps so that each one requires only 1 or 2 permissions.
Please make suggestions for names in the comments.

Gmail SMS Reader
Gmail SMS Merge
Gmail Everything
Gmail Merger
Read SMS in Gmail

Would the intent of the proposal be to retain the "restore" function?
If yes, then:
Gmail SMS Backup
Gmail MMS Backup
Gmail Phone Log Backup
(The three complementary apps)
On Mon, 7 Oct 2019, 15:52 Martin Kealey<EMAIL_ADDRESS>wrote:

Gmail SMS Reader
Gmail SMS Merge
Gmail Everything
Gmail Merger
Read SMS in Gmail

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jberkel/sms-backup-plus/issues/986?email_source=notifications&email_token=AM3MKJ2SNLQXVHL675XUX7TQNKP63A5CNFSM4I564B22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO4MJA#issuecomment-538822180,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM3MKJ3M4BV2V642LEF5SALQNKP63ANCNFSM4I564B2Q
.

Just one caveat: my discussions with folk in Google can be summarized as

Providing a storage service for backups isn't what Gmail is for
and therefore
Why don't you just provide your own server for people to save their backups onto?

This strongly suggests that keeping the word "backup" in its name would be a significant obstacle to approval.
In effect, I am proposing a marketing exercise targeting those few people within Google who assess whether an app gets approval to access Gmail. Whether the name appeals to anyone else is comparatively secondary. (The name could be changed again once it's approved.)
So I would aim for a name that conveys this is an app that enables reading SMS and email in a unified view. If further explanation is necessary: it functions as an add-on to Gmail, and therefore needs the same access as Gmail.
I would also suggest replacing "backup" with (say) "synchronize" in the UI and even in the source code.
There may even be a case for splitting off the "restore" functionality into a separate mini-app, which could if necessary still use IMAP - people are more accepting of a few hoops if they ever get to the point of needing to restore.

In effect, I am proposing a marketing exercise targeting those few people within Google who assess whether an app gets approval to access Gmail.

if it's not a AI making these decisions. You never know with Google …  🤖

"SMS Gmail Sync"
"Sync SMS to Gmail"
"SMS to Gmail"
"SMS 2 Gmail"
"SMS-Addon for Gmail"
"SMS-Addon 4 Gmail"
...

Or, if you wont be bound to Gmail one and forever and maybe want to have a look if it works e.g. with Outlook.com, too:

"SMS Mail Sync"
"Sync SMS to Mail"
"SMS to Mail"
"SMS 2 Mail"
"SMS-Addon for Mail"
"SMS-Addon 4 Mail"
...

I read that the fee for the check will be $15.000 - $75.000... I guess to much for this project and no one will spend so much money that this project can make the check...
But this info was from 2018... Is it still up-to-date ???
https://www.androidpolice.com/2018/10/08/google-updates-gmail-api-policies-developers-will-require-app-reviews-security-assessments/

Other ideas:

"Android Data to Mail"
"Android Phone Data to Mail"
"Android Phone Data Sync"
...

One more other idea:
Create a non-commercial organisation that can accept donations. Corporates can dispose donations from tax.
Now fork the app, remove the UI and build a lib with.
Every project and comoany should be free to use this lib in there apps! No matter if it is a backup, a sync, a office, or whatever app...
Now would be the question who have to make the security check ??? Each app, or would it be enough, if everyone who is interested in using the lib spend a bit to the organisation developing it, and a "Demo App", just having a UI, can show the complete possibilities of the app, but nothing else, will make the check ??? ;)


wire:loading not working

I couldn't get wire:loading to work. Just throwing this code into a component...
<div wire:loading>show on click</div>
and it always shows.
Really like this idea. Nice work!

Let me know if it works now 😄

https://github.com/wire-elements/wire-extender/pull/16
https://github.com/wire-elements/wire-extender/releases/tag/v0.0.6

Perfect. Thanks for the quick turnaround.

I've installed v0.0.6, but it's still doing nothing. The loading div always shows.

I've installed v0.0.6, but it's still doing nothing. The loading div always shows.

I had to publish the js file again.
php artisan vendor:publish --tag=wire-extender


feat: new http trigger to initialize AggregatedMeasureData requests from B2C

Description
New http azure functions to initialize AggregatedMeasureData requests from B2CWebApp.

[ ] Create new httpTrigger
[ ] Defined the dto
[ ] Execute the InitializeAggregatedMeasureDataProcessesCommand
[ ] Shared the dto contract with B2CWebApp

Next: Move Archived message into InitializeAggregatedMeasureDataProcessesHandler
References
https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-phoenix/75

Codecov Report

Merging #504 (859c618) into main (21978a1) will decrease coverage by 4.91%.
Report is 183 commits behind head on main.
The diff coverage is 58.83%.

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   83.07%   78.17%   -4.91%
==========================================
  Files         456      397      -59
  Lines       10418     8947    -1471
==========================================
- Hits         8655     6994    -1661
- Misses       1438     1727     +289
+ Partials      325      226      -99

Files
Coverage Δ

...ivedMessages/ArchivedMessageGetDocumentListener.cs
0.00% <ø> (ø)

source/Api/Common/HttpHeadersExtensions.cs
0.00% <ø> (ø)

...iddleware/Authentication/ActorForAuthentication.cs
0.00% <ø> (ø)

...ntication/Bearer/BearerAuthenticationMiddleware.cs
0.00% <ø> (ø)

...MarketActors/MarketActorAuthenticatorMiddleware.cs
0.00% <ø> (ø)

...ation/Middleware/Correlation/CorrelationContext.cs
66.66% <ø> (ø)

.../Middleware/Correlation/CorrelationIdMiddleware.cs
0.00% <ø> (ø)

...iguration/Middleware/Correlation/UserProperties.cs
0.00% <ø> (ø)

...figuration/Middleware/FunctionContextExtensions.cs
0.00% <ø> (ø)

...rce/Api/Configuration/ServiceBusMessageMetadata.cs
0.00% <ø> (ø)

... and 98 more

... and 366 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hello, I don't seem to see Service Worker on the sample site  https://eleventy-plugin-pwa-v2-demo.lkmt.us/

Hello, I don't seem to see Service Worker on the sample site
https://eleventy-plugin-pwa-v2-demo.lkmt.us/

Hi, thanks for letting me know! Fixed.


How to set button's backgroundColor and text color?

I tried this code but the color doesnt change from the default blue.
Button value="LOGIN" raised={true}  theme='dark' overrides={true} backgroundColor='#3fffff'
@Ehesp could you help me here?

Can you share some code? Also check out the demo app.
On 31 May 2016 15:21, "christinwilson"<EMAIL_ADDRESS>wrote:

I tried this code but the color doesnt change from the default blue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/react-native-material-design/react-native-material-design/issues/73,
or mute the thread
https://github.com/notifications/unsubscribe/AAzZXgNes5VuzagGkZB0OGuJTuqkV29Zks5qHEPkgaJpZM4IqlVg
.

<Button
value="LOGIN'
raised={true}
theme='dark'
overrides={true}
backgroundColor='#3fffff'
/>

@christinwilson try this
<Button
value="LOGIN'
raised={true}
theme='dark'
overrides={{backgroundColor: "3fffff"}}
/>

With "<Button" before "value=..."
Sorry about that!

thanks @GWlodarek . It worked :)

Buttons only will take object as styles if we pass object.
We can apply the style for button as following,
apply like ->
`Login
const styles = {
buttonStyle: {
backgroundColor: "#aaa"
}
}`
instead of
`Login
const styles = StyleSheet.create({
buttonStyle: {
backgroundColor: "#aaa"
}
})`

please delete react native from this universe. it is made to test your patience, not to develop something

I'm with the same problem.
Button it's needed to have "title" and put the "" tag don't change anything because only the title appeas on button box.

React native should'nt exist and thats a fact.

<Button
buttonStyle={{backgroundColor: 'white', color: 'red'}}
color="red"
titleStyle={{
color: '#f75b5b',
}}
title="Continue"
raised={true}
onPress={storingDomain}
/>


fix: add task map for parallel tasks with different config

Fix parallel tasks like getAppConfig with different config

Codecov Report

Merging #426 (4f5d836) into release-next (f7a425c) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##           release-next     #426   +/-   ##
=============================================
  Coverage         82.01%   82.01%
=============================================
  Files                85       85
  Lines              7333     7334    +1
  Branches            920      920
=============================================
+ Hits               6014     6015    +1
  Misses             1313     1313
  Partials              6        6

Impacted Files
Coverage Δ

packages/ice/src/webpack/ReCompilePlugin.ts
78.12% <50.00%> (ø)

packages/ice/src/service/config.ts
85.88% <82.35%> (+0.08%)
:arrow_up:

packages/ice/src/commands/start.ts
87.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Proposal: Default Button

WPF and Windows Forms both have the concept of a Default Button. UWP never had this. I think it should be added to WinUI 3 too. Especially if we want WPF and WinForms apps to be "converted" to WinUI 3.
In WPF you can set the property IsDefault of a Button.

Gets or sets a value that indicates whether a Button is the default button. A user invokes the default button by pressing the ENTER key.

In Windows Forms you can set the AcceptButton  property of a Form.

Gets or sets the button on the form that is clicked when the user presses the ENTER key.

Take the following example. If the left listbox is selected the Add button is the default button. This is button is highlighed with an blue border. This tells the user that this action will be executed by pressing the ENTER key. Probably also with a double click but that is up to the developer of the form/window.

@sonnemaf UWP XAML does have the concept of default button as part of ContentDialog. Unlike WPF and Windows Forms where multiple windows are primarily used on an input basis and can be modal, whereas in UWP XAML it's more of navigation based so a default button in main app UI doesn't make much sense.

I have been thinking. Maybe I should use the Style of a Button for indicating that the button is the default. In the example below I have selected 'Item 4' in the right ListBox. The Delete button then get's the AccentButtonStyle (or an custom one). I then can code that a Enter key or DoubleTapped would invoke this button.

Is this a smart solution?


ci: get the logs from the Ceph cluster pods

It seems that /var/log/rook inside the VM does not contain any files.
Getting the logs from the Pods through kubectl may not be as stable, but
it should get some logs when minikube is still/again available.
Updates: #1969

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

It seems that /var/log/rook inside the VM does not contain any files.
Getting the logs from the Pods through kubectl may not be as stable, but
it should get some logs when minikube is still/again available.
Updates: #1969
Show available bot commands

@nixpanic any example log capture here for reference which proved to be helping?

@nixpanic any example log capture here for reference which proved to be helping?

search for tar c /var/lib/rook in https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/rest/organizations/jenkins/pipelines/mini-e2e-helm_k8s-1.20/runs/859/nodes/107/log/ , that only outputs /var/lib/rook which does not seem to contain any files:
###
### going to execute: minikube_ssh sudo tar c /var/lib/rook
###
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
tar: Removing leading `/' from member names
###
### execution finished: minikube_ssh sudo tar c /var/lib/rook
###
var/lib/rook

(note that the ordering is a little wrong, writing parts to stdout and stderr)

various CI failures were tried to study today to see whats causing the CI failure without luck. Looks like definitely we need more logging to understand . Added ready to merge as this extra logging could help us in that direction. thanks:!


Working fix for CentOS with new 7.10.0 omnibus packages - Debian could e...

...asily be written from this work, but would need testing.

Have you looked into these 7.10.0 changes yet?

I'm getting this error on ubuntu 14.04
Debug: Executing 'chkconfig --list postfix | grep -q 'on' 2>/dev/null '
Debug: Executing '/sbin/service postfix status'
Debug: Class[Gitlab::Packages]: The container Stage[main] will propagate my refresh event
Debug: Exec[download gitlab](provider=posix): Executing 'curl -o /var/tmp/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm https://downloads-packages.s3.amazonaws.com/centos-6.5/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm'
Debug: Executing 'curl -o /var/tmp/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm https://downloads-packages.s3.amazonaws.com/centos-6.5/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm'
Notice: /Stage[main]/Gitlab::Install/Exec[download gitlab]/returns: executed successfully
Debug: /Stage[main]/Gitlab::Install/Exec[download gitlab]: The container Class[Gitlab::Install] will propagate my refresh event
Debug: Prefetching rpm resources for package
Debug: Executing '/bin/rpm --version'
Debug: Executing '/bin/rpm -qa --nosignature --nodigest --qf '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} :DESC: %{SUMMARY}\n''
Debug: Executing '/bin/rpm -q gitlab-ce --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} :DESC: %{SUMMARY}\n'
Debug: Executing '/bin/rpm -q --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} :DESC: %{SUMMARY}\n -p /var/tmp/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm'
Error: Could not update: Puppet::Error
Error: /Stage[main]/Gitlab::Install/Package[gitlab-ce]/ensure: change from absent to latest failed: Could not update: Puppet::Error
Debug: /Stage[main]/Gitlab::Install/Package[gitlab-ce]: Nothing to manage: no ensure and the resource doesn't exist
Debug: Class[Gitlab::Install]: The container Stage[main] will propagate my refresh event
Notice: /Stage[main]/Gitlab::Config/Exec[stop gitlab]: Dependency Package[gitlab-ce] has failures: true

I'll have to look into this more. Strange that the download has a ~ character in it.
curl -o /var/tmp/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm https://downloads-packages.s3.amazonaws.com/centos-6.5/gitlab-ce-7.10.0~omnibus.1.x86_64.rpm

@igalic I understand that, but the problem is that the RPM and DEB filenames change as well as the package name.  In my opinion it makes it trickier to use a name in this case.
You'd have to do something like this:
$gitlab_pkg = $::gitlab::gitlab_branch ? {
7.10.0 => 'gitlab-ce',
default => 'gitlab'
}
$omnibus_release = $::gitlab::gitlab_branch ? {
7.10.0 => "omnibus.${::gitlab::omnibus_build_ver}.x86_64.rpm",
default => "omnibus-1.el${cent_maj_version}.x86_64.rpm"
}
$omnibus_filename = $::gitlab::gitlab_branch ? {
7.10.0 => "gitlab-ce${url_separator}${::gitlab::gitlab_branch}~${omnibus_release}",
default => "gitlab${url_separator}${::gitlab::gitlab_branch}_${omnibus_release}"
}

Ok, I just tested this on Debian (ubuntu 12.04) and fixed a problem with the omnibus release naming convention.  It now works with both CentOS and Debian.
Here's the config I'm using, and due to gitlab making a lot of bug changes the parameter omnibus_build_ver that I added is very relevant and necessary.  The default is set to 1, which is normally fine, but with bug re-releases this increments from 1-1 to 2-1 etc.
Here's the config I'm using:
class profiles::linux::gitlabtest {
#Manages gitlab omnibus install
class { '::gitlab':
puppet_manage_config                                 => true,
puppet_manage_backups                                => true,
puppet_manage_packages                               => true,
gitlab_branch                                        => '7.10.1',
omnibus_build_ver                                    => '2-1',
gitlab_release                                       => 'basic',
external_url                                         => 'http://gitlab-test.com',
backup_keep_time                                     => '604800', #7 days
gitlab_default_projects_limit                        => '100',
gravatar_enabled                                     => true,
gitlab_default_can_create_group                      => false,
gitlab_username_changing_enabled                     => false,
gitlab_signup_enabled                                => false,
gitlab_default_projects_features_visibility_level    => 'private',
git_data_dir                                         => '/var/opt/gitlab/git-data',
backup_path                                          => '/var/opt/gitlab/backups',
gitlab_email_from                                    =><EMAIL_ADDRESS>ldap_enabled                                         => true,
ldap_servers                                         => ['
{
"primary" => {
"label"                           => "MyLDAP",
"host"                            => "myldap.com",
"port"                            => "389",
"uid"                             => "cn",
"method"                          => "plain",
"bind_dn"                         => "cn=admin,o=com",
"password"                        => "mypassword",
"active_directory"                => false,
"allow_username_or_email_login"   => true,
"block_auto_created_users"        => true,
"base"                            => "ou=users,o=com",
"admin_group"                     => "",
"sync_ssh_keys"                   => false,
"sync_time"                       => 3600
}
}'],
}
}

Any update on this merge?  It works fine on ubuntu and centos.  Not sure why it fails the build tests.

I haven't had a chance to look at it yet. Travis is failing because they
updated their images.
On Mon, May 11, 2015 at 8:38 AM Andrew J Huffman<EMAIL_ADDRESS>wrote:

Any update on this merge? It works fine on ubuntu and centos. Not sure why
it fails the build tests.
—
Reply to this email directly or view it on GitHub
https://github.com/spuder/puppet-gitlab/pull/141#issuecomment-100928575.

I'm setting up an environment to test this.
Could you do a squash on the commits?

Just squashed them down to 1.  Let me know if you have any problems.  I was looking at one of the other issues about having the gitlab package installed and trying to upgrade to gitlab-ce package.  I think we still need to add one piece to ensure gitlab is not installed if doing branch >=7.10.0.  Let me know how the testing goes.  I think I manually uninstalled the gitlab pkg, but can't recall now, so that piece would need to be thrown in.

So this is useless to test at this point.  As you know gitlab changed the
location of their builds once again.
I've made an attempt at working this out in branch issue_140 where the
naming conventions changed and installations break.
I've reworked the install.pp, but I'm having trouble getting the config.pp
to work due to the subscribe on the gitlab/gitlab-ce package.   I tried
throwing a class wrapper around the packagecloud installer and subscribing
to that class, but I'm getting and error that is slightly over my head, and
not sure how to correct, or if I'm defining something incorrectly.
If you get a chance to look at the new code in issue_140 over the next few
days/week let me know what you think.  I had to majorly rework the
install.pp to retain backward compatibility while trying to handle the new
installation mechanisms from gitlab's repository.  Basically I need an
assist to get it nailed down.
On Tue, May 12, 2015 at 12:56 AM, Spencer Owen<EMAIL_ADDRESS>wrote:

I'm setting up an environment to test this.
Could you do a squash on the commits?
—
Reply to this email directly or view it on GitHub
https://github.com/spuder/puppet-gitlab/pull/141#issuecomment-101130389.

--
Regards,
Andrew

Thanks for all the work on this. I'll look at issue_140 soon

It's working now!!!  It was a documentation issue on the packagecloud
module config.
I had to specify the server_address parameter because the repo is at
packages.gitlab.com not the default packagecloud.io.
        packagecloud::repo { "gitlab/gitlab-ce":
          type    => 'deb',
          server_address => 'https://packages.gitlab.com',
          require => Package['wget'],
        }

I pushed the final commit up to branch_140 after a quick CentOS 6.6 test.
It upgraded perfectly from 7.10.0_2-1 on my production system.
Let me know if you have any questions, but it should be a functional fix at
this point.  I would still have to test backward compatibility for the
older version installs, but I don't have the bandwidth to do that at the
moment.
-Andrew
On Wed, May 20, 2015 at 12:12 PM, Spencer Owen<EMAIL_ADDRESS>wrote:

Thanks for all the work on this. I'll look at issue_140 soon
—
Reply to this email directly or view it on GitHub
https://github.com/spuder/puppet-gitlab/pull/141#issuecomment-103943345.

--
Regards,
Andrew

Rather than just merging this as is, I'm looking at incorporating the package cloud repo code into a much larger overhaul.
This has been pretty low priority for me since I switched jobs, and I don't use puppet every day anymore.
How did you work around issue https://github.com/computology/computology-packagecloud/issues/11 ?

  Igor is right, they really should be using the
puppet resources instead of reinventing their own for some reason.  I'm not
really sure why.
So I took it upon myself to make the changes on the
computology/packagecloud repo and push the commit up on the pull request.
We'll see if they're interested in taking the changes.
Maybe we'll have to permanently fork and build.  There is some logic in
there that determines paths.  I was able to easily amend the custom junk
they were doing with templates and translate into yumrepos and apt::source.
Check out the changes here:
https://github.com/ahuffman/computology-packagecloud/commit/49e1ff1894730e718ef2779c25103966978e87de
Feel free to test out the debian side of things.  I don't really have
anything debian here or the time to fuss about doing so.  I think what I
have written should do the trick.
Thanks,
Andrew
On Mon, Jun 1, 2015 at 8:52 PM, Spencer Owen<EMAIL_ADDRESS>wrote:

Rather than just merging this as is, I'm looking at incorporating the
package cloud repo code into a much larger overhaul.
This has been pretty low priority for me since I switched jobs, and I
don't use puppet every day anymore.
How did you work around issue computology/computology-packagecloud#11
https://github.com/computology/computology-packagecloud/issues/11 ?
—
Reply to this email directly or view it on GitHub
https://github.com/spuder/puppet-gitlab/pull/141#issuecomment-107757900.

--
Regards,
Andrew

Yikes, your improvements are much better than their module. I only see 2 pull requests, and I don't think either one includes the apt overhaul.
https://github.com/computology/computology-packagecloud/pulls
I will make sure this works with both debian and cent. There is a debian vagrant box inside the puppet module.

It seems to be there for me.  The pull request is called "Fixing repeated
node changes on yumcache by making this a refreshonly".  There's 3 commits
to it.
Thanks for doing some testing work on this.  It'd be good to get this thing
cleaned up a little bit if you're going to have a dependency to that
module.  Otherwise a complete rewrite of the packagecloud module might be a
better path for us and gitlab.  I think the new changes make it more
acceptable, but packagecloud module doesn't do a whole lot other than
figure out what paths to use and insert into the standard apt and yumrepo
resources.
Yikes, your improvements are much better than their module. I only see 2
pull requests, and I don't think either one includes the apt overhaul.
https://github.com/computology/computology-packagecloud/pulls
I will make sure this works with both debian and cent. There is a debian
vagrant box inside the puppet module.
—
Reply to this email directly or view it on GitHub
https://github.com/spuder/puppet-gitlab/pull/141#issuecomment-108029478.


Feat errors

Current coverage is 94.06% (diff: 82.60%)

Merging #22 into master will decrease coverage by 1.25%

@@             master        #22   diff @@
==========================================
  Files            10         11     +1
  Lines           214        236    +22
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            204        222    +18
- Misses            6          8     +2
- Partials          4          6     +2

Powered by Codecov. Last update 169fc8a...a1b4cc7


GEOMESA-2614 RoutedDataStoreView impl

Combined data store view that routes queries to one of the underling stores

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

stacks on top of #2311


Refactor for multiple parsers

I'm not sure if ekanite/ekanite is still an active project or not. I needed to process "syslog" records from a Watchguard Firebox. They fail to follow the precise requirements of the RFC5424, like too many big companies these days.
With this PR, I have refactored the code to support a new package dedicated to hosting various parsers so that the -input flag accepts more than just syslog.

The vast majority of the work is inside of input/parser.go where LogHandler replaces the old Parser type, and there is the introduction of a LogParser interface into the mix.
In input/delimiter_syslog I had to shrink to just the priority, as Watchguard fails to publish a version in their line (just a priority).
For separation of concerns, the collection of parsers now exist in a new package, and a func callback used to report against the singular stats inside of collector.go.
Finally, I updated the README.md to reflect the 3-step process that can now be used to introduce new parsers into the code.
All tests pass.

Thank you for your contribution, I am happy to accept it. I do have some feedback before I merge however.

Thank you for your contribution, I am happy to accept it. I do have some feedback before I merge however.

Great- I'll get this cleaned up and incorporate the requests.

Thanks for your contribution, @jweisscrypto

Hmmm, the testing may not have been set up right on this branch, but testing is now failing on master.
https://circleci.com/gh/ekanite/ekanite/335
input/parser_test.go doesn't build. Can you take a look, and create a new PR?
$ go test -v ./...
# github.com/ekanite/ekanite/input [github.com/ekanite/ekanite/input.test]
./parser_test.go:10:9: undefined: Parser
./parser_test.go:17:20: undefined: fmtsByName
./parser_test.go:19:15: undefined: fmtsByStandard
./parser_test.go:20:25: undefined: fmtsByStandard
./parser_test.go:23:20: undefined: fmtsByStandard
FAIL    github.com/ekanite/ekanite/input [build failed]


middleware/cache serve stale records on timeout

Cloudflare seems to be moving that direction due to the dyn outage.
With a LRU cache and enough memory one could hold most of the records in the cache and serve stale answers, when a refresh times out or failes.
Hold records in cache as long as memory and LRU rules allow and refresh with backend on each query, if TTL is timed out.

Yes, but sometimes the TTL timeout is what is expected; DNSSEC keyrollovers; migrating A records etc.
So you have to more careful, i.e. only allow timeout records to be returned when the upstream nameserver experience network timeouts.
Also in the case of CoreDNS' cache we have a number of different upstream, i.e. DNS ones, or etcd or kubernetes; do we want to implement the same behavior there? That would counter the shortlived TTLs of those environments.
As CoreDNS isn't a full DNS recursion, I'm not sure if this functionality belong here - but it is good to have a discussion and see what is possible - maybe even a separate middleware that handles it for.

I agree we shouldn't return a record with a timed out TTL. We should always check the backend first and if that check fails serve the stale record only.
The issue with using network timeouts is, that one tries to be smarter then the local resolver of the users. They might get a stale answer even so they might have successfully retried with another ns. So we might introduce issue during network partitions.
From a users pov I think, that the cache middleware should be the last to run and basically just cache everything, when enabled. Shouldn't matter, if it's etcd, k8s or file backend. (file backend should not need the cache, but it simplifies usage and implementation in my view)
So LRU cache, which caches every record, if enabled. Cache holds records as long as memory allows, but forces a recheck with the backend, if the TTL is timed out. Does that sound reasonable?
I wouldn't push serving stale records as a separate middleware. Just a configuration option in cache. Seems to connected to split that up.
CoreDNS doesn't need to have full recursion right? That's where the proxy middleware comes in. Maybe someone builds a recursion middleware so, but then cache could still just sit at the end and serve it.

the LRU cache you describe is how the cache currently works in CoreDNS-002 (modulo bugs).

I agree we shouldn't return a record with a timed out TTL. We should always check the backend first and if that check fails serve the stale record only.

The issue with using network timeouts is, that one tries to be smarter then the local resolver of the users. They might get a stale answer even so they might have successfully retried with another ns. So we might introduce issue during network partitions.

But how is the cache going to know the backend timed out?
Related: DNSSEC signature lifetimes might throw a wrench in this as well

Took another look at the current cache middleware.
So currently the cache defines its own TTL, which might be fine, but can overwrite the TTL of the actual record. Basically we might already serve stale records.
The cache TTL could be set to a week and the records wouldn't be rechecked.
So maybe the suggestion is clearer saying that we should add rechecking of cached values into the cache. Basically the cache looks at the time the cache item was introduced and checks that against the TTL of the record. If the time it was added to the cache is older than the TTL of the record, the cache rechecks (tries to pull in the record - same path as for non cached records), if an answer is provided it will overwrite the current cache item. If there is an error or timeout, the cache middleware could check periodically (maybe with a backing off timer) for changes to the backend availability. It would still serve the stale answers.
Current:

cache TTL is used to invalidate a cache item.

Suggestion:

cache TTL can overwrite record TTL.
record TTL is used for cache invalidation.
on invalidation requests will initiate a new pull, but serve stale records on backend error.
define a max_stale timeout to have a specific cut-off for old records (may default to a few days).
invalidated items are removed from cache, when max_stale timeout is reached or the backend answers with NXDOMAIN or similar.

Haven't looked at the signature lifetimes, but I assume that could be another invalidation step to check for?
Basically checking the signature lifetime and if it has run out, remove the item from the cache immediately (so not just an invalidation) and go the usual pull from backend route as would be necessary. (Does that already happen with a cache TTL set to a longer time?)
Thanks for bearing with my suggestions and questions as always.

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/coredns] middleware/cach..." ]

So maybe the suggestion is clearer saying that we should add rechecking of cached values into the cache. Basically the cache looks at the time the cache item was introduced and checks that against the TTL of the record. If the time it was added to the cache is older than the TTL of the record, the cache rechecks (tries to pull in the record - same path as for non cached records), if an answer is provided it will overwrite the current cache item. If there is an error or timeout, the cache middleware could check periodically (maybe with a backing off timer) for changes to the backend availability. It would still serve the stale answers.

That should atually not be that hard now you write it like this.

Current:

cache TTL is used to invalidate a cache item.

Suggestion:

cache TTL can overwrite record TTL.

If you set the TTL in cache stanza to 0 the "packets" TTL is used.

record TTL is used for cache invalidation.
on invalidation requests will initiate a new pull, but serve stale records on backend error.
define a max_stale timeout to have a specific cut-off for old records (may default to a few days).
invalidated items are removed from cache, when max_stale timeout is reached or the backend answers with NXDOMAIN or similar.

Ack. Care to implement something like this? :-)

Haven't looked at the signature lifetimes, but I assume that could be another invalidation step to check for?
Basically checking the signature lifetime and if it has run out, remove the item from the cache immediately (so not just an invalidation) and go the usual pull from backend route as would be necessary. (Does that already happen with a cache TTL set to a longer time?)

Current cache also does not care about sig lifetimes. We might get away with
just postponing this and assuming it will still validate.

Thanks for bearing with my suggestions and questions as always.

Np. discussion like these are good to have.

Current:

cache TTL is used to invalidate a cache item.
Suggestion:
cache TTL can overwrite record TTL.

If you set the TTL in cache stanza to 0 the "packets" TTL is used.
So if it is set to 0 or not set, it'll use the record TTL? (I assume that's how it should be, but in the docs it says, it uses 1h and 1/2h depending on the backend answer)

record TTL is used for cache invalidation.

on invalidation requests will initiate a new pull, but serve stale records on backend error.
define a max_stale timeout to have a specific cut-off for old records (may default to a few days).
invalidated items are removed from cache, when max_stale timeout is reached or the backend answers with NXDOMAIN or similar.

Ack. Care to implement something like this? :-)
I would love to, but I know the current time wouldn't allow me to commit to something like that. Therefore up for graps ;)

Haven't looked at the signature lifetimes, but I assume that could be another invalidation step to check for?
Basically checking the signature lifetime and if it has run out, remove the item from the cache immediately (so not just an invalidation) and go the usual pull from backend route as would be necessary. (Does that already happen with a cache TTL set to a longer time?)

Current cache also does not care about sig lifetimes. We might get away with
just postponing this and assuming it will still validate.

I'll open an issue to keep the issue documented. #367

Clarification for anyone coming later (might be added to the docs later on):
no cache -> records are not cached and record TTL is provided
cache -> records are cached using record TTL up to 3600 or 1800 depending on backend answer
cache 0 -> records are cached with TTL 5
cache 300 -> records are cached using record TTL as long as has a smaller value than 300 (cache TTL)

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/coredns] middleware/cach..." ]

Clarification for anyone coming later (might be added to the docs later on):
no cache -> records are not cached and record TTL is provided
cache -> records are cached using record TTL up to 3600 or 1800 depending on backend answer
cache 0 -> records are cached with TTL 5
cache 300 -> records are cached using record TTL as long as has a smaller value than 300 (cache TTL)

Would be good to open a PR for that and add it to the docs.
/Miek
--
Miek Gieben

Will do as soon as the more pressing issues are fixed and the feature set seems to be stable.


AIPL reads env vars at time of import, not instantiation

I have a simple flask server that serves results from running AIPL scripts over HTTP. I have to load_dotenv() so it has access to API keys like OpenAI's. But if I do this (at server start) it doesn't have access:
from aipl import AIPL
load_dotenv()
aipl = AIPL()

instead I have to do this:
load_dotenv()
from aipl import AIPL
aipl = AIPL()

Hm, I don't know why that would be!  Nothing is calling os.getenv or pulling vars from os.environ at the toplevel, it all happens at the operator level.  So it seems like it should work either way.  Unless somehow importing os itself seals the environment even if it's not used.


Decode URL query & path

When using the generated client libraries for RPC, the path and query components are encoded automatically (eg: %20). They are not, however decoded on the server side, so I need to decode them in the ApiMethod manually.
I think that this should be done behind the scenes.

I will look into this ASAP.

This issue is still occuring, and the pull request still hasn't been merged. Will this be resolved soon, or should I start wrapping everything in url decodes?


direct RNA base modification detection with nanopolish

Hi Jared,
Does nanopolish support RNA base modification detection ?
What are the commands to be used for this purpose ? (nanopolish extract -> minimap2 alignment -> nanopolish eventalign -> nanopolish call-methylation) ?
Thanks.
Huanle

It doesn't support RNA mods yet.
Jared

On May 6, 2018, at 2:18 AM, HUANLE<EMAIL_ADDRESS>wrote:
Hi Jared,
Does nanopolish support RNA base modification detection ?
What are the commands to be used for this purpose ? (nanopolish extract -> minimap2 alignment -> nanopolish eventalign -> nanopolish call-methylation) ?
Thanks.
Huanle
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

thanks Jared.
What makes ONT direct RNAseq difficult and different from DNAseq?

It is difficult to get good training data for constructing models.
Jared


proposal: add SAML2 external provider configuration

This PR utilizes the https://github.com/Sustainsys/Saml2 component for plugging into a configurable SAML2 endpoint.
How to test:

In appsettings.json configure the following ExternalProvidersConfiguration:

    "Saml2OurEntityId": "https://YOURADDRESSHERE/Saml2",
    "Saml2TheirEntityId": "https://samltest.id/saml/idp",
    "Saml2TheirMetadataLocation": "https://samltest.id/saml/idp",

run the STS project, navigate to https://YOURADDRESSHERE/Saml2 and save the xml file
navigate to https://samltest.id/upload.php and upload the previous xml file
try logging in via the new external provider "Saml2"

Current issues:

fails to map email from the test service SAML response. The mapping from SAML2 claims to the ones used in here needs more work.

Thanks, I will check it. 👍🏼

Can you recommend some steps how to test it? Which Saml2 provider do you suggest for testing?
Thanks

Btw: please, can you check conflicts in your PR?
Thanks

Hi, did you try the testing steps in the PR description? samltest.id seemed to work well enough for a simple test.
Sure, I'll check the conflicts soon-ish

Thanks, sorry I checked changed files first then whole PR description - steps are very clear - I will test it. 😎

@skoruba  Updated the PR, sorry it took forever to fix those conflicts

Hmm, can't figure out why the build fails in CI...
C:\projects\identityserver4-admin\src\Skoruba.IdentityServer4.STS.Identity\Skoruba.IdentityServer4.STS.Identity.csproj : error NU1605: Detected package downgrade: Skoruba.AuditLogging.EntityFramework from 1.0.0-beta8 to 1.0.0-beta7. Reference the package directly from the project to select a different version.  [C:\projects\identityserver4-admin\tests\Skoruba.IdentityServer4.STS.Identity.IntegrationTests\Skoruba.IdentityServer4.STS.Identity.IntegrationTests.csproj]

Yet no project I see references the older version of that library...

AppVeyor CI log: "Microsoft.Data.SqlClient.SqlException (0x80131904): Cannot open database "IdentityServer4Admin" requested by the login. The login failed."

Any status?

@spaasis and @skoruba
I merged this pull request, master and branch feature/633-update-is4-to-v4.
I tested with my auth0 account and is successful.
There are some fixes for logout that I pretend to merge here also.
Can I make a PR?

@wggley by all means, great that you have gotten it working!

Hey guys, sorry for delay, I'll work on new release 2.0.0 and I'll add it this external provider there.
Thanks!

Hey guys, sorry for delay, I'll work on new release 2.0.0 and I'll add it this external provider there.
Thanks!
@skoruba
There are problems regarding logout.

Sustainsys library needs 2 claims and its issuer to work.
The claims can be stored but the issuer is lot because Microsoft Identity doesn't store it.
I made a workaround to store the issuer and originalissuer as 2 new claims so now I store 4 claims and could make it to call external provider auth0 logout service.
But auth0 throws an error that I'm trying to figure it out.

@skoruba I can make a pull request if you like.

@wggley - For sure, it would be great! 👍 I'll check it later.
Thanks!

@spaasis @skoruba
Added PR #795
@skoruba there is still a bug regarding logout.
After user first login (creation on database) is keeping his information as local idp on:
src/Skoruba.IdentityServer4.STS.Identity/Controllers/AccountController.cs
//line 803 var idp = User.FindFirst(JwtClaimTypes.IdentityProvider)?.Value;
So on first logout:
//line 814 vm.ExternalAuthenticationScheme = idp;
Is never reached and it won't logout the user from external logout service.
I can't figure how to solve this.

@spaasis @skoruba
Added PR #795
@skoruba there is still a bug regarding logout.
After user first login (creation on database) is keeping his information as local idp on:
src/Skoruba.IdentityServer4.STS.Identity/Controllers/AccountController.cs
//line 803
var idp = User.FindFirst(JwtClaimTypes.IdentityProvider)?.Value;

So on first logout
//line 814
vm.ExternalAuthenticationScheme = idp;

Is never reached and it won't logout the user from external logout service.
I can't figure how to solve this.

I figured how to fix logout on First Sign and updated my PR.
@skoruba can you please review it and check if is the right approach for all changes?

Hi @skoruba @wggley was their any plan to progress this PR?


Python - Test a streaming workload

https://github.com/aws-samples/serverless-test-samples/pull/106


Add possibility to skip interactive variable queries

I love navi's ability to interactivly query variable values. However, there are occasions where I'd like to skip this and instead print the whole command as-is (including its variable names) to the command line and modify it by hand.
Is that somehow possible? Optimal workflow would be a dedicated keybinding for it (e.g. Alt+Enter), so that I can decide this while the navi search dialog is open. I'm not sure how this would be possible on a technical level, since fzf does not offer different exit types (or does it?).
Any ideas how this could be done?

I think this should be possible using fzf's --expect argument:
--expect=KEY[,..]
       Comma-separated list of keys that can be used to complete fzf in addition to  the  default  enter  key.
       When this option is set, fzf will print the name of the key pressed as the first line of its output (or
       as the second line if --print-query is also used). The line will be empty if fzf is completed with  the
       default  enter  key.  If  --expect option is specified multiple times, fzf will expect the union of the
       keys. --no-expect will clear the list.

       e.g.
            fzf --expect=ctrl-v,ctrl-t,alt-s --expect=f1,f2,~,@

There's also the --print flag

@denisidoro Why are you closing this? I would still like to implement it, I just did not have the time, yet.
And what do you mean with the --print flag? Is this a flag of navi or fzf and how would that help in this case?

navi --print does what you're proposing, if my understanding is correct

@denisidoro No, that doesn't do what I want. navi --print still queries the variables interactively. I want to be able to skip that. It is just not efficient in some scenarios, e.g. when the argument is a file, where I could use tab completion on the shell. This is not possible when the arguments are queried interactively.

Hi @denisidoro, thanks for adding the new flag. Can you give me a hint how I would use this in combination with the shell widget?


Canvas Memory Leak

I am drawing using the Kivy Canvas.  It works.  But...
repeated drawing on the screen seems to increase the CPU usage which means the app starts running slower and slower very quickly.
`class Draw_Stuff():
#################################################
def __init__(self, **kwargs):
    self.IG_Line = InstructionGroup()

#################################################
# Clear all the Instructions from the IG_Line
# and make the Labels invisible
def Clear_Lines(self):
    self.IG_Line.clear()

#################################################
# Draw a Line inside the Drawing Window Area
# given Pixel coordinates
# Not Axis Coordinates
def Draw_Line(self, pScreen=None, pX1=0, pY1=0, pX2=0, pY2=0, pR=1, pG=1, pB=1, pW=1, pOp=1):
    self.IG_Line.add(Color(rgba = (pR, pG, pB, pOp)))
    self.IG_Line.add(Line(points = [pX1, pY1, pX2, pY2], width = pW))
    if(pScreen is not None):
        pScreen.canvas.before
        pScreen.canvas.add(self.IG_Line)
    return`

my code is in the following repository:
https://github.com/edwit1971/Rectangle/
If you hit Clear Screen,
and then hit the Rectangles Button and then the STOP button to see the time it took to draw and finish. Hit the CLEAR DRAWING button.
then repeat. Hit Rectangles Button. and when the STOP button appears immediately hit it. and then hit the Clear Drawing Button.
Each time you do this, the time keeps increasing...

Is the problem similar to https://github.com/kivy/kivy/blob/master/examples/canvas/canvas_stress.py ?

No the problem I'm seeing is not the same as you mentioned.  How to explain this?  The effects are almost IMMEDIATE.  The instant I start drawing on the screen with Instructions to the Canvas, the App starts to slow down instantly.  Even using an animated SPINNER from KivyMD shows the effect.    The more I add instructions to draw on the screen, NO MATTER THAT I DELETE ALL THE INSTRUCTIONS to CLEAR THE SCREEN the CPU starts being cumulatively more and more busy (meaning the App gets slower and slower).  The ONLY SOLUTION is to NEVER DRAW to the screen using Kivy Canvas which means never drawing on the screen at all.

Your problem seems to come from the fact that you add the instruction group over and other to the canvas of pscreen, while you should only do it once, adding a flag in your code to prevent it from happening more than once fixes the performance issue.
I'm not exactly sure why it's a problem (and why it even works, i would have assumed adding the same instruction instance multiple times to a canvas would cause a crash), but there is a better solution that "NeVeR DrAwInG To ThE ScReEn".

please don't write all caps, that's not nice to the people that try to help you, as it feels like being screamed at.
please read PEP-8 and stop littering your code with meaningless "#####" lines, just and 90s style comment blocks telling useless things like the filename and the creation date, that's what git is for, it'll make pythonists reading your code much more happy.

TShirtMan fixed my Memory buildup problem.  He's awesome!!!!
For others, I want to make the fix clear...
You can only call Canvas.add( InstructionGroup ) once per Screen Drawing.
Do all your drawing to the InstructionGroup Object. Then when you draw the screen add the InstructionGroup ONCE to Canvas.add.
When you want to redraw the screen and make a new screen and new drawing,
clear the canvas and clear your InstructionGroup, and draw new instructions to the InstructionGroup and then add it once to the Canvas.
If you call Canvas.add( ) more than once before clearing the canvas it will build up memory and slow the CPU down and there is no way to undo it without quitting the App to release all the resources.


Generate SQL Script sometime was grey color (like disable)

Dear supporter
DBeaver's Generate SQL Script feature to my database for a few table is OK. But many kind table it's not working e.g: a table wkith 71 columns and i selected with where conditions then clicked on result table and chose Generate SQL Script then it was became GREY color (like disable) and I couldn't did anything more.
Additional I'm using SQL Server 2005.
Thanks, and hope it's going to fix for the next version.
I'm really like this app.

This may happen if DBeaver can't detect source table from your query.
I will add explanation item to the menu (current UI confuses many people).
Workaround: try to edit table directly (because custom SQL metadata is poorly supported for SQL Server).

There isn't any activity about this ticket very long time. Perhaps, the question was solved. It will be closed. However, if you think that it is actual just let us know.


[AERIE-1988] Update user code runner to 0.3.1

Tickets addressed: AERIE-1988
Review: By commit
Merge strategy: Merge (no squash)

Description

Simple dependency update to pull in the latest error handling fixes
Verification

Ran through our automated test suite (e2etest)
Documentation

None necessary
Future work

None

Just remembered that Joel had to change the error parsers in a separate branch to remove the source context that was deprecated. So I'm redoing tests and adding those changes. Surprised they didn't trigger in the e2etests, perhaps we don't have failure cases as part of those. Won't make the mistake of not running our non-e2etests again.


Bug: builder loosing connection to terraformer

Current Behaviour

The builder keeps on receiving signals to terminate even though all of Claudie's services are healthy.
In the picture below you can see that the builder states that the terraformer is unhealthy (left side), but on the right side, you can see that the terraformer was healthy all the time. Eventually, the builder got restarted, after a couple of debug messages about an unhealthy terraformer. You can also see that the builder has already restarted almost 50 times. I checked the logs of the previous builder pod and the reason behind the restart was the same.

Expected Behaviour

The builder restarts only when there is an unhealthy service.
Steps To Reproduce
I am usually able to reproduce it in the following way:

Deploy any InputManifest
Wait until the cluster in the InputManifest gets built.
Wait ~30 minutes and the builder should restart.

Anything else to note
The builder usually restarts every ~30 minutes.

Builder connections will be refreshed periodically ~5sec, https://github.com/berops/claudie/issues/1292
So this issues should no longer exists.

I'll verify this before closing up the issue.

I haven't experienced this since https://github.com/berops/claudie/issues/1292. IMHO can be closed.


Styles and custom search box

Data table is synced with a custom search box, which can be moved wherever suits your fancy.

P.S. Where's my cape?

Working on it.


Connection failed to wss://testnet-node.dock.io:9950

Currently the driver deployed to dev.uniresolver.io fails with following error log produced:
yarn run v1.19.2
warning package.json: License should be a valid SPDX license expression
$ npx babel-node index.js
Dock DID driver running on port 8080 , connecting to node now...
2020-08-06 10:30:01          API-WS: disconnected from wss://testnet-node.dock.io:9950 code: '1006' reason: 'connection failed'
Can't connect to node, error: _Event {
  type: 'error',
  isTrusted: false,
  _yaeti: true,
  target: W3CWebSocket {
    _listeners: {},
    addEventListener: [Function: _addEventListener],
    removeEventListener: [Function: _removeEventListener],
    dispatchEvent: [Function: _dispatchEvent],
    _url: 'wss://testnet-node.dock.io:9950',
    _readyState: 3,
    _protocol: undefined,
    _extensions: '',
    _bufferedAmount: 0,
    _binaryType: 'arraybuffer',
    _connection: undefined,
    _client: WebSocketClient {
      _events: [Object: null prototype] {},
      _eventsCount: 0,
      _maxListeners: undefined,
      config: [Object],
      _req: null,
      protocols: [],
      origin: undefined,
      url: [Url],
      secure: true,
      base64nonce: '+gy5M6MoHWuQ2+gxLByJBg=='
    },
    onclose: [Function: value],
    onerror: [Function: value],
    onmessage: [Function: value],
    onopen: [Function: value]
  },
  cancelable: true,
  stopImmediatePropagation: [Function (anonymous)]
}

@BernhardFuchs Thanks for reporting. Should work now.

Thanks for the quick reply and fix.


feat: add close function for Client

Codecov Report

Merging #6 (79fad8c) into main (b9f04e7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          663       693   +30
=========================================
+ Hits           663       693   +30

Impacted Files
Coverage Δ

evaluate.go
100.00% <100.00%> (ø)

event.go
100.00% <100.00%> (ø)

featureprobe.go
100.00% <100.00%> (ø)

sync.go
100.00% <100.00%> (ø)

LGTM


Refactor Curl

We have nearly 100 curl calls in the training scripts, but there are only a few variants of the types of commands and flags used.  We should refactor the curl calls as functions in shared_functions to make it easier when we want to slightly tweak our curl commands in the future.

Another option would be to replace curl commands with gh api or octo commands. But this would introduce a new dependency to the scripts.

Thanks @parkerbxyz.  Your changes look pretty slick.  Teaching a class later this week, so I'll have to check out the updates after that.


[Maven] ignore files for common IDEs

Reasons for making this change:
This change updates the existing Maven.gitignore ruleset. (previous PR #2076 requesting a new separate ignore ruleset was rejected)
This change saves user time and effort by adding IDE-related rules for the existing Maven ruleset, for commonly used IDEs. It also protects user privacy because IDE configuration could contain sensitive user information pertaining to the project, and that should not be committed and pushed to GitHub.
Links to documentation supporting these rule changes:
N/A

This change also adds some comments to explain the rules.

We already have separate rules for these IDEs:

Global/Eclipse.gitignore
Global/JetBrains.gitignore
Global/NetBeans.gitignore

Please add any IDE-specific rules to those locations, so these can be shared more broadly...

I looked at the global files and they don't appear to be the proper place for these. The GitHub UI does not appear to allow users to select multiple ignore rules when creating a new repository. These changes are specifically useful to Maven projects, and are appropriate to add to the Maven rules. These changes may also be useful globally, but they're are useless to Maven users who select the Maven ruleset if they exist only in the global files.

The GitHub UI does not appear to allow users to select multiple ignore rules when creating a new repository.

I'll take this suggestion back to the relevant GitHub team, but I'm not sure what their roadmap looks like currently.

These changes are specifically useful to Maven projects, and are appropriate to add to the Maven rules.

I try and keep these templates specific to what each need. By keeping them specialised there are a number of benefits:

changes are not scattered across a number of locations - making reviewing and updating easier
by not forming opinions about what users might have installed, people can choose to tailor the project setup to the toolchain they want (like gitignore.io)
I can leverage the knowledge of vendors to ensure that what is specified here is accurate (JetBrains have been great in this regard)

These changes may also be useful globally, but they're are useless to Maven users who select the Maven ruleset if they exist only in the global files.

It might feel like I'm picking on Maven here, but I also reject changes which are OS-specific because we have OS-specific templates.

Your logic makes sense. I just don't see much value in keeping them separate if the user can't actually use them that way.


Support for view components 3.0.0

Hi,
Following 3.0.0 release https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md#v300
I see you released https://rubygems.org/gems/view_component-form/versions/0.2.4 but for some reasons runtime dependencies are set to but your gemspec file do specify view_component < 4.0
RUNTIME DEPENDENCIES (4):
[actionview](https://rubygems.org/gems/actionview) >= 6.0.0, < 7.1
[activesupport](https://rubygems.org/gems/activesupport) >= 6.0.0, < 7.1
[view_component](https://rubygems.org/gems/view_component) >= 2.34.0, < 3.0
[zeitwerk](https://rubygems.org/gems/zeitwerk) ~> 2.5

So something wrong might have happened during the release process.
Regards

Thanks for reporting this, we'll look into it!

#144 bumps the dependency, we just need to release a new version of the gem. It will be done soon!

@kwent you can upgrade to v0.2.5 :)


Rollback to root master

Since I'm using another branch (playground) I will pull the main root from marcobambini to my master fork

Since I'm using another branch (playground) I will pull the main root from marcobambini to my master fork


Extensions viewlet - after restarting I expect to be brought back

Testing #8215

I installed an extension
I clicked Enable
I accepted to restart
I expected the extension viewlet to come back, preferably with the same search query and the same scroll position that now shows the "Enabled" in green or something.

This is a concussion decision made by our PM team that we always open the explorer viewlet on start.
Anyways, assingning to July and chris to decide if we want to make an exception in this case

Deferring to August

As designed, unless @chrisdias says otherwise.

But this is not a start. This is a restart initiated from the extension itself.

@chrisdias do you receive GH notifications?

Maybe for when the window reloads we should always restore the last used viewlet. Imho it does not make sense to reload and jump back to the explorer.
@chrisdias point  was to show the explorer when opening a folder or starting VS Code fresh. I can see if this would be possible (e.g. finding out that a window was reloaded).

I do not think we should ever jump back to the explorer - all across our UI we preserve state and I am not sure why explorer is such a special case?

@isidorn it is about helping users to explore a project, if you open a folder from command line with VS Code you do not expect to see the extensions viewlet that you might have had opened 3 months ago. I think it makes perfect sense to show the files of the workspace.
The "Reload Windows" case is special and should restore the last used viewlet.

I thought we would store this per workspace. So if I closed a workspace in git viewlet I would expect to see it on reopen.
Sure on a new workspace we should always show explorer since that would be the default and we wuold not have anything stored per that workspace.
Just my 2 cents

@isidorn we do store it per workspace but you can still have it stored there for 3 months and come back to it and why would you want to see the extensions viewlet then.

Verify: triggering any of the actions that causes a window reload (e.g. from F1, install extension) should restore the viewlet you had active.


Add min_upstream_level and max_downstream_level to Pump and Outlet

Fixes #1771, the remaining part after #1788 was merged. I split out #1789 as a separate issue, though in this PR a lot of the preparatory work is already done (all changes related to TabulatedRatingCurve).
This is breaking due to #1791 because of adding new optional columns.
It is also breaking that TabulatedRatingCurve and Pump now only support one outflow edge. As far as I know this wasn't used anywhere though. We cannot easily support that anymore since we now look at downstream levels. Users should instead use separate Pumps or TabulatedRatingCurves, which can share the same upstream Basin, but go to different downstream nodes.
I decided to start the reduction factors for reaching these limits from 2 centimeters away. There was one existing level based reduction factor, the level difference in the Outlet, which I also adjusted from 10 to 2 centimeter. I feel like 10 centimeter would be too much in areas where the level is controlled up to centimeter accuracies.

I decided to start the reduction factors for reaching these limits from 2 centimeters away. There was one existing level based reduction factor, the level difference in the Outlet, which I also adjusted from 10 to 2 centimeter. I feel like 10 centimeter would be too much in areas where the level is controlled up to centimeter accuracies.

This seems like something a user might want to control. 2 centimeter is probably a reasonable default, but why not make this part of the structure?
FWIW, mf6 uses auto_flow_reduce, which is still a bit vague, but something like that.

Yeah we may need to support that at some point, but not in this PR. We could either set it as a global setting in the TOML, or per node in the database.


Multithreading Sync Fence issue?

I know I am doing something wrong, its obvious because my fence says its complete before it is.  But I feel like I have done everything correctly according to D3D12nBodyGravity example.  Maybe a second set of eyes could help me out.  All I am doing is creating some geometry called terrain that has some vertex, index, and a SRV and uploading it.  Then I am trying to fence until it is done, and then release the upload buffer.  But my fence is saying it is done when it is not.
auto d3dDevice = m_deviceResources->GetD3DDevice();

			D3D12_COMMAND_QUEUE_DESC queueDesc = {};
			queueDesc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE;
			queueDesc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT;

			ThrowIfFailed(d3dDevice->CreateCommandQueue(&queueDesc, IID_PPV_ARGS(&m_worldTiles[id].commandQueue)));
			ThrowIfFailed(d3dDevice->CreateCommandAllocator(D3D12_COMMAND_LIST_TYPE_DIRECT, IID_PPV_ARGS(&m_worldTiles[id].commandAllocator)));
			ThrowIfFailed(d3dDevice->CreateCommandList(0, D3D12_COMMAND_LIST_TYPE_DIRECT, m_worldTiles[id].commandAllocator.Get(), nullptr, IID_PPV_ARGS(&m_worldTiles[id].commandList)));

			m_worldTiles[id].terrain = new TessellatedTerrain(m_deviceResources);
			m_worldTiles[id].terrain->CreateDeviceDependentResources(m_worldTiles[id].commandList);
			m_worldTiles[id].terrain->CreateBuffers(m_worldTiles[id].commandList);

			// Close the command list and execute it to begin the vertex/index buffer copy into the GPU's default heap.
			DX::ThrowIfFailed(m_worldTiles[id].commandList->Close());
			ID3D12CommandList* ppCommandLists[] = { m_worldTiles[id].commandList.Get() };
			m_worldTiles[id].commandQueue->ExecuteCommandLists(_countof(ppCommandLists), ppCommandLists);

			ThrowIfFailed(d3dDevice->CreateFence(0, D3D12_FENCE_FLAG_SHARED, IID_PPV_ARGS(&m_worldTiles[id].pFence)));
			m_worldTiles[id].fenceHandle = CreateEvent(nullptr, FALSE, FALSE, nullptr);

			ThrowIfFailed(m_worldTiles[id].commandQueue->Signal(m_worldTiles[id].pFence.Get(), m_worldTiles[id].id));
			ThrowIfFailed(m_worldTiles[id].pFence->SetEventOnCompletion(m_worldTiles[id].id, m_worldTiles[id].fenceHandle));

			WaitForSingleObject(m_worldTiles[id].fenceHandle, INFINITE);

			// bug: this is released too early!
			m_worldTiles[id].terrain->ReleaseUpload();

			m_worldTiles[id].isLoaded = true;
			m_worldTiles[id].isLoading = false;

What is the value of m_worldTiles[id].id?  Make sure it's greater than the initial value of the fence.

m_worldTiles[id] was just a unique Identifier.  I wasn't checking for any kind of increase but now that I read, I see I do.  I was thinking the fenceHandle would fire when the GPU was done and WaitForSingleObject was waiting on the event.  So how it really works is it checks for an increase in the fenceValue?  Do I need to use a ThrowIfFailed(m_worldTiles[id].commandQueue->Wait(fence, id>originalId)); ?  Sorry I am confused about the call back from the GPU.

ID3D12CommandQueue::Wait will insert a wait on the GPU, not the CPU, so you would still not be safe to release your upload heap on the CPU.
I should have been more clear, but all I was trying to say is that if you create a fence with "0" as the initial value and then call SetEventOnCompletion and pass in "0" as the value to monitor, the event will immediately be marked as completed because the fence value is already 0.  So in this case, WaitForSingleObject will return immediately since the fence value has already been satisfied and the CPU may release the upload heap before the GPU is done with it.

I am still a tad confused on its functionality.  If I create the fence with say 101.  Do I pass 102 into the SetEventOnCompleteion and it will get a call back when complete or do I need to check each update loop to see if the value has increased?

In this example you would:

Create the fence with 101
Signal the fence with 102
SetEventOnCompletion with 102
WaitForSingleObject  (blocks the CPU until the GPU has executed the Signal command - there is no "call back")

got it and it is working.


[MINOR] Fix incorrect numbering in the document

What changes were proposed in this pull request?
Fix incorrect numbering in the document.
Why are the changes needed?
Fix incorrect numbering in the document.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
local.

@xleoken
Thanks for your contribution. Can you modify your PR description as it's just a template?

@xleoken Thanks for your contribution. Can you modify your PR description as it's just a template?

Updated.

@xleoken thanks for your contribution, merging to main.


Quests b173 doesn't fully load or recognize commands in game.

What is your Quests version / build number (do not say "latest")?
Quests v4.0.0-rc.3-b173 running on Paper 312 (1.16.4).
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
So I was seeing the same as #1488 on the 4.0.0rc3 release and tried build 173 in hopes it had been fixed, but it turns out that was a bad idea since I can't do anything with it now. Every command run in game returns an error only in game, nothing in console, stating "Plugin is currently loading. Please try again later!"
There was an error on startup at least: https://gist.github.com/mercurialmusic/07be1ab60889619cdbd101665cc467a8
But that's all I got.

Closing as duplicate
Please try https://ci.codemc.io/job/PikaMug/job/Quests/174/


Expand Access Token functionality

related to https://github.com/techcloud0/bankaxept-epayment-platform/issues/1357

I have removed the access-token-client, so there shouldn't be any direct epp code now. It's just some bug fixes/facilitating, and making the token retrieving configurable

I have removed the access-token-client, so there shouldn't be any direct epp code now. It's just some bug fixes/facilitating, and making the token retrieving configurable

Can't see you have removed it.

Right, you have to click "delete" twice in intellij. It's gone now