PayloadTooLargeError: request entity too large

When i try to upload my bookmarks from latest brave version , got this error 👍
PayloadTooLargeError: request entity too large
    at readStream (/Elysian/node_modules/raw-body/index.js:163:17)
    at getRawBody (/Elysian/node_modules/raw-body/index.js:116:12)
    at read (/Elysian/node_modules/body-parser/lib/read.js:79:3)
    at jsonParser (/Elysian/node_modules/body-parser/lib/types/json.js:138:5)
    at Layer.handle [as handle_request] (/Elysian/node_modules/express/lib/router/layer.js:95:5)
    at next (/Elysian/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/Elysian/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/Elysian/node_modules/express/lib/router/layer.js:95:5)
    at /Elysian/node_modules/express/lib/router/index.js:284:15
    at Function.process_params (/Elysian/node_modules/express/lib/router/index.js:346:12)

Config :
services:
  elysian:
    image: aadityajoshi151/elysian:latest
    container_name: elysian
    privileged: true
    environment:
      - API_KEY=*****
      - PUID=1042
      - PGID=1042
      - TZ=Europe/Paris
#    ports:
#      - 6161:6161
    volumes:
      - ./data:/Elysian/src/data
    restart: unless-stopped
    labels:
      - traefik.enable=true
      - traefik.docker.network=traefik
      - traefik.http.routers.elysian.rule=Host(`link.***.com`)
      - traefik.http.routers.elysian.entrypoints=websecure
      - traefik.http.routers.elysian.service=elysian
      - traefik.http.routers.elysian.tls=true
      - traefik.http.routers.elysian.middlewares=my-geoblock@file,sslheader@docker
      - traefik.http.middlewares.sslheader.headers.customrequestheaders.X-Forwarded-Proto=https
      - traefik.http.services.elysian.loadbalancer.server.port=6161
    networks:
      elysian:
      traefik:

networks:
  elysian:
    name: elysian
    driver_opts:
      com.docker.network.bridge.name: br-elysian
  traefik:
    external: true

data  folder is empty fyi.
Thanks !

Hi @pinkfloydFR
Thank you for opening the issue.
It looks like the size of the request body exceeds the default limit of express.json() that I am using to parse the request body.
I was able to reproduce the issue on my end also by sending a lot of bookmarks (450 to be exact).
It should be solvable by increasing the default limit.
I will push a change soon. Meanwhile, could you provide me answers to following questions which might help me better understand the issue:

When did you encounter the error? I am assuming after the initial install and config, when you first exported the bookmarks from the extension, you encountered this.
How many bookmarks are you exporting? An approximate number should suffice.

Hi @Aadityajoshi151  !
1 : All right, just intalled the extension and the first try is getting the ( as the other try of course )
2 : All right again, i havec exactly 523 bookmarks ( i am not messy, all is organized in sub folder ;)   ) 👍

Thanks for the update !

Hi @pinkfloydFR
I have pushed the change in the latest docker image. The issue was auto closed on merging the PR but I have re-opened it to hear back from you.
You can pull the latest image and try running it again. Make sure to remove the existing Elysian image beforehand to avoid any confusion.
Please let me know the status and then I'll close the issue.
Thank you.

Hi,
For now all seem good, but... i am curently spammed with notification of export or moved bookbark...
As i have a big number of bookmark, i leave my browser as it for now, seeing if it's a feature or a bug :)
The docker log show me this, only with 30s of running :

Hi @pinkfloydFR
This is a weird one. I tested by exporting 3000 bookmarks on latest version of brave and it works fine for me. Only 1 notification is received for the entire export and only 1 log statement is observed in docker logs also.
The move action also behaves the same way and both of these actions are completed instantly.
In your case, it looks like it is getting stuck in an infinite loop (sort of).
I'd suggest you do a fresh setup once, both on server side and browser side by re-installing the extension.
If the issue still persists, you can open a new issue with the same logs and images. Also please provide detailed steps which will help me in reproducing the issue on my end.
I am closing this as the issue regarding the PayloadTooLargeError: request entity too large seems to be fixed.
Thanks.


Unit test client, worker and coordinator code

The Script() and Execute() classes were mocked with actual
modules because

they are dependencies of the code under test
they do not exist at 'compile time' and are only
available at runtime on the cluster
those classes are deeply embedded in the main Ambari
repo and have not been extracted into their own wheel/egg
to be declared as dependencies of this project
it is impossible/prohibitively expensive to mock the modules
in the test code

Some of these unit tests are a little meaningless and will
break with a refactor. I included them because no other
tests (other than manual) are possible and they provide a basic
sanity check.

Task: SWARM-1125
Testing: make clean dist test

@anusudarsan and @kokosing, when you get a chance I would appreciate comments

lgtm mod comments.

Thanks for the review, I'll wait for @kokosing to take a look tomorrow as well.

looks good. A lot of mocking... hard to follow, but I understand it was necessary.


Use createAsset util function from ocean.js.

Fixes #11 .
Changes proposed in this PR:

Use createAsset util function from ocean.js.
Change params order
Update to latest version of ocean.js

@jamiehewitt15 should we create a separate issue for integrating support for sapphire, meaning datatoken template id 4 and accesslist factory? I wouldn't include the oasis integration in this PR.

Yeah, let's do it seperately

I tested it locally barge and got this error. Do you know what might be causing this?

I tested it locally barge and got this error. Do you know what might be causing this?

That error comes from latest release of ocean.js, make sure that the chain ID from the json sample matches the network configured (8996).

I updated the metadata to have the right chainId, but now I'm getting another error. Have you seen this before?

I updated the metadata to have the right chainId, but now I'm getting another error. Have you seen this before?

I thought vs-code ext won't use the latest version of ocean-lib in this PR, we have a separate issue for this where accesslists will be integrated https://github.com/oceanprotocol/vscode-extension/issues/16

We have a separate issue for this where accesslists will be integrated https://github.com/oceanprotocol/vscode-extension/issues/16, let me double check why that address error is popping up.

Ok, we should still be able to publish assets on barge though?

We have a separate issue for this where accesslists will be integrated #16, let me double check why that address error is popping up.

Ok, we should still be able to publish assets on barge though?

Yes, of course, I think the way that we retrive the contract addresses makes that error occur.

Yes, of course, I think the way that we retrive the contract addresses makes that error occur.

Ok, so we need to fix that first then...

Hello @jamiehewitt15:
extensionHostProcess.js:162
Finding the service endpoints failed: FetchError {message: 'request to https://node5.oceanprotocol.com:8…on: connect ECONNREFUSED <IP_ADDRESS>:8000', type: 'system', errno: 'ECONNREFUSED', code: 'ECONNREFUSED', stack: 'FetchError: request to https://node5.oceanpro…ons (node:internal/process/task_queues:82:21)'}
extensionHostProcess.js:162
Error details: Error: HTTP request failed calling Provider {stack: 'Error: HTTP request failed calling Provider
	…vscode-extension/dist/extension.js:122:48789)', message: 'HTTP request failed calling Provider'}

I did not receive the error with accessListFactory address, I used ocean-lib v3.4.4., used remote node on sepolia

Still getting the same error:

Testing locally with barge, which is working fine on the main branch.

I think it is coming from some setup error w barge, on optimism sepolia, I could've published without problems the asset.

DID published on op. sepolia: did:op:ba6518f6d3b7b6e41293bdf57a02aed11dbbf0c7a51272dd77e4cf246447321a

I think it is coming from some setup error w barge

What has changed in barge that would start causing this error?

First, I started w upgrading ocean contracts docker image. I've seen that I still receive the error w upgraded version of contracts in barge... the same :(

First, I started w upgrading ocean contracts docker image. I've seen that I still receive the error w upgraded version of contracts in barge... the same :(

Ok, we need to figure out what is wrong then

It comes from ocean.js, I created a PR for it https://github.com/oceanprotocol/ocean.js/pull/1889. Otherwise the functionality of publish is not impacted.

It comes from ocean.js

Ok, let's get the fix in Ocean.js merged first and then test this again


Can not import @uploadcare/react-widget/en-min/

Describe the bug
Neither via NPM nor via YARN can I import / add @uploadcare/react-widget/en-min/ as described in the README.
Expected behavior
The installation should work.
Code / screenshots
npm install @uploadcare/react-widget/en-min/ -> returns
npm ERR! code ENOENT
npm ERR! syscall open

yarn add @uploadcare/react-widget/en-min/ -> returns:
error An unexpected error occurred: "https://registry.yarnpkg.com/@uploadcare%2freact-widget/en-min/:
Request \"https://registry.yarnpkg.com/@uploadcare%2freact-widget/en-min/\" returned a 405".

Environment

Library version:
Language/framework version: NPM 8.5.0, YARN 1.22.19
OS version:  macOS 12.3.1

Hey @skreutzberger,
you should install @uploadcare/react-widget but import @uploadcare/react-widget/en-min

Those bundles are available as ESM only.
Next.js should support ESM modules by default.
I checked it on StackBlitz and it works.
Which version of Next.js are you using?

Hi, I am using Next.js 12.1. I also tried to directly import the /dist/esm folder but it did not work (but I also don't know what I am really doing  😅 since that whole NPM thing is new to me)

I was able to reproduce the problem, trying to solve. Thanks. Seems it's on the our side.

@skreutzberger
Please update library to v2.1.3 and import it by @uploadcare/react-widget/en-min/index.js path (trailing /index.js is important).

Thanks for the quick fix! Unfortunately I now receive the following error:
ReferenceError: exports is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and<EMAIL_ADDRESS>contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.

For what it’s worth, I’m running into the same issue this morning:
ReferenceError: exports is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and<EMAIL_ADDRESS>contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.

Ok, let's go that way. I bootstrapped project via create-next-app and  pushed it to the repo, try to clone it and run. Will it work?
https://github.com/nd0ut/temp-next-js-react-widget-test

Do you have some custom webpack or compiler configs in your project?

I'm facing the same issue

@nd0ut Thank you so much for taking the time to help us with it. Your test project works AND I found the reason why it did not work for me: I had Nextjs 12.1.6 installed. After upgrading to Nextjs 12.2.1 the line
import { Widget } from<EMAIL_ADDRESS>works fine!
So my old Nextjs was the reason. Thanks again!!!

Hey @skreutzberger, I finally understood the Next.js error meaning. By exports in ES module scope they seem to mean exports field in package.json not export statement as I thought. I will release another patch version asap. So it would work under 2.1.6 too but you will need to use import without index.js - @uploadcare/react-widget/en-min

awesome, thanks!

Thanks a lot for going deeper into the node_module "rabbit hole" to even better fix it 🙌
I upgraded to widget 2.1.4 and can confirm that import @uploadcare/react-widget/en-min is enough and works well.

Hey @nd0ut, I'm receiving the same error when using any of the imports, with any version, with Remix v1.8.0.
I had to write a patch like this to get it to compile:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 545a5bc..ec5f068 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -2,7 +2,6 @@
   "name": "@uploadcare/react-widget",
   "version": "2.1.3",
   "description": "React component for Uploadcare Widget",
-  "type": "module",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
   "types": "types/index.d.ts",

Updating to the latest versions didn't seem to help, so for now I'm just using v2.1.3 + patch.

Hi @wub. I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and am getting the following ts error:
import { Widget } from "@uploadcare/react-widget/en";
//                     ^ Cannot find module '@uploadcare/react-widget/en' or its corresponding type declarations.ts(2307)

Any ideas?
Thanks!

Hey @maxfi,
Please use v2.4.1 instead of v3.0.0-alpha.0.
And create react-widget.d.ts with the following contents:
declare module "@uploadcare/react-widget/en" {
  export * from<EMAIL_ADDRESS>}

Then everything should work.
Remix doesn't have good ESM support, especially with typescript. Actually this problem should be solved by setting typescript moduleResolution to node16 or nodenext. It requires user package to be ESM (type: 'module') that isn't possible because Remix app running as CJS.

I have some thoughts about how to fix it on the package layer.


Very long filenames make this challenging to clone on Windows

While trying to clone this for one sample, I got many errors similar to
"error: unable to create file Official Windows Platform Sample/Application resources and localization sample/[JavaScript]-Application resources and localization sample/JavaScript/images/ja/projector.scale-180_contrast-standard.png: Filename too long" on a Windows 10 computer that is (I think) under a standard configuration. I had to figure out how to do a partial clone to get the bit I wanted.

I'm facing same issue, is there any workaround for this

@jeganrajm google how to do a partial git clone, and clone just the sample's path you want.

https://dev.to/kiwicopple/quick-tip-clone-a-single-folder-from-github-44h6

https://dev.to/kiwicopple/quick-tip-clone-a-single-folder-from-github-44h6

https://stackoverflow.com/questions/52699177/how-to-fix-filename-too-long-error-during-git-clone/52699496

https://stackoverflow.com/questions/52699177/how-to-fix-filename-too-long-error-during-git-clone/52699496


Python tests in TH UI - Provide PythonTest Test Case Support

Feature description
This issue is related to executing Python tests in TH UI.
Implement  support for executing PythonTest  from TH  (RPC server side)
Test Case
Helper classes
Hook impl
Use Cases
[Use Case] Execute Loaded Test Case
Test Cases
No response
Additional Information
No response

PR for this implementation: https://github.com/project-chip/certification-tool-backend/pull/19


Request for event in codeunit 11

🛑🛑🛑This repo is no longer dedicated to handling application requests and enhancements 🛑🛑🛑
Instead please use the following repository: https://github.com/Microsoft/ALAppExtensions
We would like to avoid the error with "Job No." as empty for this we need a publisher for it
In codeunit 11 CheckBalAccountNo() function we need a on publisher with
OnAfterCheckBalAccountNo(GenJnlLine,CheckDone);

This repository is no longer dedicated to handling application requests and enhancements.
Instead please use the following repository: https://github.com/Microsoft/ALAppExtensions


Non-Standard Dependency Specifier with pip 24.0

"DEPRECATION: textract 1.6.5 has a non-standard dependency specifier extract-msg<=0.29.*. pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of textract or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063"
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Just used "pip install seaborn"
Expected behavior
A clean and complete download of Seaborn with no messages pertaining to dependency issues
Desktop (please complete the following information):

OS: [Windows 10 64 bit]
Textract version [1.6.3]
Python version [\3.11.6]
Pip version [23.3.1]
Virtual environment (no)

Duplicate of #476


Iris: Allow activation of Iris for programming exercises

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context
Iris should be activatable for Programming Exercises. This PR adds code and a database change to allow for that.
Description
Added a database change for an activation flag for Iris to the exercise table.
Added authorization checks when creating or fetching a session, sending or fetching messages.
Steps for Testing
TODO

Review Progress

Performance Review

[ ] I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

@Hialus
Thanks for the feedback. I integrated your requests and changed the branch.
Tests are on the way, there is already a ticket in the Jira Board

Codecov Report

Merging #6609 (8b90eb2) into feature/combine-iris-services (aa8e957) will decrease coverage by 4.37%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/combine-iris-services    #6609      +/-   ##
===================================================================
- Coverage                            84.84%   80.47%   -4.37%
- Complexity                           13375    13381       +6
===================================================================
  Files                                 1109     2381    +1272
  Lines                                43131    90960   +47829
  Branches                              4446    13395    +8949
===================================================================
+ Hits                                 36595    73204   +36609
- Misses                                4079     9801    +5722
- Partials                              2457     7955    +5498

Impacted Files
Coverage Δ

...um/in/www1/artemis/domain/ProgrammingExercise.java
85.41% <100.00%> (+0.24%)
:arrow_up:

.../www1/artemis/service/iris/IrisSessionService.java
100.00% <100.00%> (ø)

...ww1/artemis/web/rest/iris/IrisMessageResource.java
100.00% <100.00%> (ø)

...ww1/artemis/web/rest/iris/IrisSessionResource.java
100.00% <100.00%> (ø)

... and 1275 files with indirect coverage changes

Flag
Coverage Δ

client
76.53% <ø> (?)

server
84.85% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8e957...8b90eb2. Read the comment docs.


Colspan and rowspan

Hi! I've come across this repo, I find it very useful.
My question is, can I have an empty cell so the previous cell expands vertically?

Hi @casvil that feature (and colspan) are not yet implemented, but we'd love a PR! Not exactly sure what the best way to implement this is myself.

Would be awesome to have this, but no idea how to implement still. Probably have to do something with position absolute and computed adjacent cell sizes.
https://stackoverflow.com/questions/2403990/html-colspan-in-css

Can css grid layout solve this?

Perhaps! You can try it yourself without it being part of the repo I believe!

@ishanbhutagate6 this would be the correct issue to comment on, but feature is not implemented and is hard to implement. No current plan. We're not using <table> elements, we're using css display: table


post: Do not unconditionally override opts.PostStatus.

As is, we could only fetch posts that were published.
This created a problem for fetching posts in any other state (including 'inherit').

Thanks


Resolve google_filestore_instance and google_kms_key_ring errors

Updated google_filestore_instance and google_kms_key_ring reference (from google_kms_crypto_key) per documentation regarding warning and error in apply
Resolves the following errors (from a v50+ deployer terraform plan of the subsequent tf):
╷
│ Warning: Argument is deprecated
│
│   with module.gke_cluster.google_filestore_instance.nfs,
│   on .terraform/modules/gke_cluster/main.tf line 95, in resource "google_filestore_instance" "nfs":
│   95:   zone = local.zone
│
│ Deprecated in favor of location.
╵
╷
│ Error: Unsupported attribute
│
│   on .terraform/modules/gke_cluster/main.tf line 197, in resource "google_kms_crypto_key" "crypto_key":
│  197:   key_ring        = google_kms_key_ring.key_ring.self_link
│
│ This object has no argument, nested block, or exported attribute named
│ "self_link".
╵

(planned main.tf, slightly truncated)
module "gke_cluster" {
  source                     = "github.com/dominodatalab/terraform-gcp-gke?ref=v1.10.3"
  kubeconfig_output_path     = "/resources/deployer/deploys/dc-t7008579-2/kubeconfig"
  enable_pod_security_policy = true
  cluster_name               = "dc-t7008579-2"
  master_authorized_networks_config = [
    {
      cidr_block   = "<IP_ADDRESS>/0"
      display_name = "internet-ingress-access"
    }
  ]

  namespaces = {
    platform = "dc-t7008579-2-platform"
    compute  = "dc-t7008579-2-compute"
  }

  node_pool_overrides = {
    platform = {
      initial_count = 2
    }
    compute = {
      initial_count = 1
    }
  }

  master_firewall_ports = [ "443", ... ]

  location = "us-west1-b"

  google_dns_managed_zone = {
    name     = "eng-platform-dev"
    ...
  }
}

The build check is ironically failing on the lines this aims to fix. 🙂

Closing due to inactivity.


constant numeric x and y for text marks

position the text relative to the anchor
anchor can be any of "top", "bottom", "left", "right" or combinations such as "top-left"
demo: https://observablehq.com/@observablehq/text-facet-alignment-523
closes #523
todo:

[x] create unit tests for the possible anchors
[ ] should "right" and "bottom" be counted "inwards" like in css?
[ ] generalize to all marks?

A question: here we add x and y regardless of the anchor, but we could decide that the sign of the "right" and "bottom" positions should be negated (to go "inset"). I don't know which is the most intuitive.

converted to draft with the two questions that came up in review

I've now generalized the feature to dots and images. Not sure if it can/should be done for other marks?

Demo https://observablehq.com/@fil/constant-numeric-x-y-594

Obsolete. This can be achieved with frameAnchor: left and dx: 10 instead of x: 10.


Region of "open ai

I want to set the region to "East US" only for "open ai" and "Japan" for the others.
How do I change the "env" file?

Same issue here

Can you try changing the following line in main.bicep (Line 30)?
param openAiResourceGroupLocation string = location

to
param openAiResourceGroupLocation string = 'eastus'

Then choose japan for your location the usual way. Let me know if that doesn't work.

Now 'azd up' prompts for each location, so we can close this.


Allow choosing the TLS framework used by sauce-api

This is useful when cross compiling (e.g. for a Raspberry Pi as is my
usecase 🙃)
This patch also documents the feature under a "Requirements" section in
README as the TLS stack kinda fits there.

This is confirmed to build as per my CI workflow (it wouldn't build if my changes caused a problem in this crate, also the commit mentioned there is one past the commit where I switch to my fork...)

Looks good, thank you, merging. This'll be in the next alpha, once I get around to working on sauce-api amidst my other projects. Until then, I guess you're stuck with using git for this feature.
On another note, nice to see this project of mine being used!

On another note, nice to see this project of mine being used!

Yeah it's nice seeing people use the things you build ^^

I'll be honest, a discord bot is the exact reason I originally made this thing.

For further reference, 0.7.0-alpha1 contains this and a bit more.

Looks nice =)


OIDC Support to Frogbot

Hello Team,
Do you have any plans to allow OIDC authentication for frogbot instead of using an access token?
https://jfrog.com/blog/secure-access-development-jfrog-github-oidc/
Thanks,
Adi

Dear @AdiUbarale ,
Supporting OIDC is included in our strategic roadmap; however, it is not slated for implementation within the calendar year of 2024.

You can extract the token with a GitHub action step and then inject it into Frogbot, we’ve been doing that and works fine so far we have an action like this:
name: 'Artifactory Access Token'
description: 'Acquire access token for Artifactory'
inputs:
  artifactory_url:
    description: "Artifactory URL"
    required: false
    default: "https://<URL>"
  audience:
    description: "OIDC Audience"
    required: false
    default: "github"
  provider:
    description: "OIDC Provider name, usually the customer identifier"
    required: true
  repository:
    description: "Repository name"
    required: true
  github_token:
    description: "GitHub Token"
    required: true

outputs:
  token:
    description: "newly acquired access token"
    value: ${{ steps.access-token.outputs.token }}
  username:
    description: "username for matching the token"
    value: ${{ inputs.provider }}/${{ inputs.repository }}-ci

runs:
  using: "composite"
  steps:
    - name: Get Access Token
      shell: bash
      id: access-token
      run: |
        curl -sLS -XPUT -H "Accept: application/vnd.github+json" \
          -H "Authorization: Bearer ${{ inputs.github_token }}" \
          -H "X-GitHub-Api-Version: 2022-11-28" \
          https://api.github.com/repos/<ORG>/${{ inputs.repository }}/actions/oidc/customization/sub \
          -d '{"use_default":false,"include_claim_keys":["repo"]}'

        ID_TOKEN=$(curl -sLS -H "User-Agent: actions/oidc-client" -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" \
        "${ACTIONS_ID_TOKEN_REQUEST_URL}&audience=${{ inputs.audience }}" | jq -r .value)

        REQ=$(curl -sLS -XPOST "${{ inputs.ARTIFACTORY_URL }}/access/api/v1/oidc/token" -H "Content-type: application/json" \
          -d "{\"grant_type\": \"urn:ietf:params:oauth:grant-type:token-exchange\", \"subject_token_type\":\"urn:ietf:params:oauth:token-type:id_token\", \"subject_token\": \"$ID_TOKEN\", \"provider_name\": \"${{ inputs.provider }}\"}")
        ACCESS_TOKEN=$(echo $REQ | jq -r .access_token)
        echo ::debug::ID_TOKEN=$(echo $ID_TOKEN | base64)
        echo ::debug::ACCESS_TOKEN_REQUEST=$REQ
        echo ::debug::ACCESS_TOKEN=$(echo $ACCESS_TOKEN | base64)
        echo ::add-mask::$ACCESS_TOKEN
        echo "token=$ACCESS_TOKEN" >> $GITHUB_OUTPUT

used like this:
      - name: Get Access Token
        uses: <insert-repo>/.github/actions/artifactory-access-token@v2
        id: access-token
        with:
          provider: <insert>
          github_token: ${{ secrets.GITHUB_TOKEN }}
          repository: <insert>

      - uses: jfrog/frogbot@54d0cfedebdb11ded3af3069fd3c69ab6727509d  # v2.20.2
        env:
          JF_URL: https://artifactory.novus.legogroup.io
          JF_ACCESS_TOKEN: ${{ steps.access-token.outputs.token }}
          JF_GIT_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Hello @AdiUbarale and @lukaspj
Im happy to inform you that OIDC authentication for GitHub is available for Frogbot now!
Please refer to our docs to learn more about it if needed: https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot/setup-frogbot/setup-frogbot-using-github-actions
Hope this feature serves you well :)


FIX ISSUE : IF Duplicate SSM parameter with different Case cause the whole SSM parameter fail to load

Fix issue #146 -  SSM parameter case senstive but dotnet config is not, so if we have duplicate SSM parameters  with different case, it will not load the ssm params at all.
Description
Fix issue (edge case), if we have duplicate SSM parameters  with different case (like /param/one and /Param/ONE) like below parameter, the whole SSM parameters not added to the config at all, and it's completely ignored with no error message or log.

/Connection/OracleConnection
/Connection/ORACLECONNECTION
/connection/oracleconnection

Motivation and Context
this is fix an open issue with name "Duplicate SSM parameter with different Case cause the whole SSM parameter fail to load"
Testing
Before fix, create below SSM parameters

/Connection/OracleConnection
/Connection/ORACLECONNECTION
/Connection/anyOtherParam

Run the application to read from /Connection prefix, you will notice no ssm parameter loaded in the config even anyOtherParam.
After apply fix, you will notice OracleConnection and anyOtherParam will appear in the dotnet config.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist

[ Y] My code follows the code style of this project
[ N] My change requires a change to the documentation
[ N] I have updated the documentation accordingly
[ Y] I have read the README document
[ N] I have added tests to cover my changes
[Y ] All new and existing tests passed

License

[ Y] I confirm that this pull request can be released under the Apache 2 license

@malah-code Thanks for the contribution. As mentioned in the https://github.com/aws/aws-dotnet-extensions-configuration/issues/146#issuecomment-1540525422, it might not be recommended changing the logic to load the latest duplicate SSM parameter, since that would not be ideal and could result in undesired behavior for some scenarios. This would need review with the team if throwing an error would make more sense.

Thanks for the PR. I commented on the parent issue that we should throw an exception if we are in this error condition of duplicate keys. Silently continuing picking the last value will cause unpredictable behavior for users of the library.

@ashishdhingra / @normj , thanks for review, I understand your idea, and totally agree that silently continuing picking the last value will cause unpredictable behaviour for users of the library, but do you agree that we at least we need to log warning with enough information whenever error happened in the DefaultParameterProcessor ?. I'm saying that because it took me hours to detect this issue in my SSM parameters, and I had to take the library source code to debug to know the root cause. let me know if that make sense.

@ashishdhingra / @normj , thanks for review, I understand your idea, and totally agree that silently continuing picking the last value will cause unpredictable behaviour for users of the library, but do you agree that we at least we need to log warning with enough information whenever error happened in the DefaultParameterProcessor ?. I'm saying that because it took me hours to detect this issue in my SSM parameters, and I had to take the library source code to debug to know the root cause. let me know if that make sense.

@malah-code Looking at the design of the library, the exception could be logged by the consumer of this library as would be the case with any other exception (like failing to load the parameter). Please advise if you would be amending the PR or contribute a new PR (closing this one) for

Throwing an exception in case of duplicate parameters for this use case.
For optional parameters, if the parameter is not found or fail to load, it should use the existing logic to silently ignore the error.

Hence for fixing this, the simple fix could be to catch specific exception raised for duplicate keys while loading parameters (DefaultParameterProcessor or JsonParameterProcessor), perhaps in SystemsManagerConfigurationProvider.LoadAsync().
Thanks,
Ashish

Closing this PR in favor of https://github.com/aws/aws-dotnet-extensions-configuration/pull/171


CRAYSAT-1774: Add cray-sat-podman RPM to noos repository

Summary and Scope
This package was part of the SAT product stream and is being added to the CSM product stream to merge the SAT product into CSM fully.
Technically this package is also already installed in the Kubernetes management NCN images, but it seems like a good idea to keep including it in a Nexus package repository like SAT does today. This would enable updates of this package if needed without updating the management NCN images.
Issues and Related PRs

Resolves CRAYSAT-1774
Merge after https://github.com/Cray-HPE/sat-podman/pull/34
Also wait for a stable build of cray-sat-podman to be produced

Testing
Tested on:

Jenkins

Test description:
The Jenkins build should validate that the RPM can be downloaded from the location specified in the index.yaml manifest file.
Risks and Mitigations
Pretty low-risk as it's just adding an RPM that used to be provided by the SAT product to the CSM product.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

I've created this PR as a draft until I have merged the associated sat-podman PR and created the stable release.

The associated sat-podman PR (https://github.com/Cray-HPE/sat-podman/pull/34) was merged, and the release/2.1 branch was created to create the stable build 2.1.0-1, so this is ready for review and merge now.

Since cray-sat-podman is embedded in the NCN images (by way of the metal-provision repo), it doesn't need to be added to a manifest file in the csm repo.  Part of the CSM release build process is to fetch every rpm installed on the NCN images and create an embedded repo containing all of these packages.  This then gets configured via CFS as the "CSM Embedded NCN Packages" repository.
E.g. on fanta running CSM-1.5:
ncn-m001:~ # zypper se -v cray-sat-podman
Loading repository data...
Reading installed packages...

S  | Name            | Type    | Version | Arch   | Repository
---+-----------------+---------+---------+--------+---------------------------------------------
i+ | cray-sat-podman | package | 2.0.0-1 | x86_64 | CSM Embedded NCN Packages (added by Ansible)
    name: cray-sat-podman

    Note: For an extended search including not yet activated remote resources please use 'zypper
    search-packages'.
ncn-m001:~ #

Closing based on John's comment. I will be opening a separate PR to update the version of cray-sat-podman used in the metal-provision repo and to remove the sat-rpms repo from use.


Docstrings, revisited

One of our goals with Pybricks is to have useful documentation. We're still on track, but we basically got a bit stuck on various technical issues in an attempt to make things correct and sometimes a bit overly consistent.
I think we can resolve most of this by refining what we are really trying to achieve here: useful documentation.
Sometimes, being concise is more helpful than being 100% technically accurate and consistent. Here are a few examples.
Make type information useful with less bloat
Having argument type information in the signature can make them very long and hard to read. We can display the type with the argument description instead.
Compare:

to

Avoid technical terms like Union or Literal when not needed
Notice above that:

Union[bytes, bytearray] was changed to (bytes or bytearray) in the argument description.
Literal["little", "big"] was changed to simply (str), since the description repeats the options anyway. If we want to be more correct, we could also just make it say: ("little" or "big").

Make type information concise
For return types, however, things are easier to follow if we do include them in the signature.
Compare:

to:

This is especially true for overloaded signatures (not shown here), when each overload has its own return type.
This might seem inconsistent, but it's easy to apply everywhere. Since we can convey the same or more information in a less bloated way, I think it is worth it.
Be clearer about returning values if no arguments given
For kwarg arguments like then=Stop.HOLD, it is clear that these values are optional. For our return-settings-if-nothing-given, we could be a bit more correct while keeping it concise:
Compare:

to:

Overly complicated signatures
This should mostly be deferred to the .pyi files.

All in all, I think we can make an effort to doing this, and along the way, try to formalize the rules so we know what to do when we add something new in the future.
We can achieve all of the above without any Python hacks by just including the desired signature in the docstring. This might sound like more work, but it's actually a lot less typing compared to having all the overloads in place.
Since we have separate .pyi files anyway, we can use those for the formally correct API, including the details omitted above.

useful documentation.

As I have mentioned before, including version information of when an API was added or changed is, without a doubt, the most useful information for me. Without this information, it puts the burden of supporting such changes on those with intimate knowledge of the source code and in my case usually requires digging into the source and git history because I don't remember every thing we did or when we did it.

Also, if we are going over all of the .pyi files, we can clean up the use of @overload. Since we originally created the docs, I' have learned that the actual definition should not have the @overload decorator.

Another thing to audit in the .pyi files is the use of the / and * separators for positional-only and keyword-only arguments.

FYI, I make the comments above as separate comments in case we want to split them out into separate issues. The other changes proposed sound good to me.

From a technical perspective, instead of having separate .pyi files, does it work the same to include all of the type hints and overloads in the .py files but then override the signatures in the docstring?

Yes, that would be nice. I have tried several other approaches where combining them didn't pan out, but now that we might be back at overriding the docstrings as sketched here, maybe this could work.
This could be getting in our way, but that's fairly minor. We could probably even patch it as needed --- suppressing unwanted typing should be easier than magically adding new stuff.

From a technical perspective, instead of having separate .pyi files, does it work the same to include all of the type hints and overloads in the .py files but then override the signatures in the docstring?

With the recent Sphinx patches based on our upstream issue reports, I think this may be achievable now. :smiley:
So we can probably just get this started while we wait for Sphinx 5.0.0 to come out. If we want to release our docs earlier, we might be able to use a pre-release.


Add default xp drop recoloring

Closes #5242

Sort of what my #3028 did

bump?

added in #13729


Setup Upptime interface demo for continuous monitoring

💡 Description
See upptime.js
⚔ Parent Epic / Related Tickets
No response

Initial setup completed and online: https://github.com/nasa-pds/PlanetPatrol/


Add context support for memory allocator

This is the first patch which aims to move all jerry global variables into a context. This patch contains the infrastructure part, and the memory manager is updated to use this context. The JERRY_CONTEXT macro should provide the freedom of using contexts in Jerry.
@franc0is if you have some time please check this patch.

Awesome! I'll take a closer look in a few hours.

Looks great :+1:

I think we should decide where to put this context. After some thinking I would put in the jerry-core/ root directory or a new jerry-core/context/ sub-directory

I would have favoured "jerry-core/jrt" but certainly not "jerry-core/", which leaves me with voting for a new subdir under jerry-core.

+1 to a new jerry-core/context directory.

Patch reworked

Sorting the source directories in CMake is a good idea :) I'd like to see it in the commit message too. In general, a more descriptive commit message would be great. The code is LGTM.

LGTM

LGTM

I tried the pointer to heap version. Performance is roughly the same (gain is less than the deviation), but the binary size is increased by 600 bytes. I would still prefer the original.

Updated and rebased to the latest master.

Still LGTM

Added a long comment why the "first" is in a good place.

Patch rebased.

LGTM

Other than the minor stylistic comments, LGTM

Thank you for the review. The patch and its description is updated.

Still LGTM


support n string or range filters

This would be super useful for whittling down planet scenes that are in the "test" category, fall outside of sensor view angle limits, and are not of a particular instrument type (I'm looking to get all of one type, either PS2 or the new PS2). Filtering by these three categories requires 2 string filters and a range filter (plus I'd also like to filter by boolean, the positional_accuracy flag).
If I run porder idlist with two string filters I get more scenes returned than if I used 1 string filter, which makes me think the second string filter is causing the other string filters to not be ran (using two string filters should return less scenes than 1 string filter)
Running search for a maximum of: 1000000 assets
Total number of assets written to /home/rave/temporal_mixing/data/idlist_standard_and_test.csv ===> 2635

Running search for a maximum of: 1000000 assets
Total number of assets written to /home/rave/temporal_mixing/data/idlist_all_filters.csv ===> 2665

Hey @rbavery
For now it only handles one filter of each type , string or range and so on. The issue is with the common keys overwriting values in the overall payload . In any case I welcome help on figuring this out, there might be a simple fix but I welcome PRs to add this capability or maybe just something fun to explore over Christmas :)

Gotcha, thanks for the explanation @samapriya. For now I'll filter by whatever reduces the order count the most, and I think using the harmonize option means I don't need to filter by instrument type. I might be able to take a crack at figuring this out later this month.


Some Errors (No green Line, Can't close jest-info ...)

Hallo,
I wanted to test snapguidist to see if it would work for us as we already use the react-styleguidist.
Unfortunately it's not really working like it should:

No green or red line if I start or change some props in the styleguidist
As soon as I change props the jest -dropdown with the Differences opens immediately
The jest dropdown hasn't any colors
I cant close the jest dropdown (nothing happens if i click on the symbol)

I am using  react-styleguidist v4.6.3 (I had to downgrade from 5.0.3 )
I hope you can help me :)
That's how it looks:

Thanks for notifying us on that @KatGr, we are transitioning from being a proof of concept to be a useful addition to styleguidist. We want snapguidist up and running as soon as possible.
In few days everything should work again as expected.
Thanks for your patience!

I can't reproduce the issue with react-styleguidist v4.6.3, could you please provide more info or a non-working demo @KatGr?
Thanks!

There are two error-messages inside the Developer Tools of Chrome:

I don't know if I can provide a demo version but I will see what I can do.
And I found another strange thing, is it intended that  snapguidist isn't working in Safari?

Unfortunately, I can't reproduce the issue.
The error seems related to the swipeable component.
Can you please either check it or publish a non-working demo?
We'll be happy to help!
Also, you are right: Safari < 10.1 doesn't support fetch.
I'm gonna fix it, thanks!

@MicheleBertoli Use https://github.com/developit/unfetch — it’s cool ;-)

The Safari issue is fixed in v1.1.2 @KatGr, thanks @sapegin for the lib recommendation.

So I thought about my Error Message and maybe I have an Idea why Snapguidist doesn't work at the moment.
In the Styleguidist 4.x Version, I get an Error where my Components (complete markdowns) are rendered twice (or even more if i click on them on the nav Bar).
After the downgrade for Snapguidist this Error appeared again.
I don't know if this could be the Problem, but maybe this Error in the Styleguidist leads to the Error in the Snapgduist.
I hope this is true and everything will be fixed if the Snapguidist works with 5.x Version of Styleguidist :)
Hope I can use it soon :)
How long do you think will it take to use the snapguidist with styleguidist 5.x? (No hurry ;) )

@cef62 and I have been pretty busy with some talks recently, but I can confirm that supporting v5 is our next priority - see #13.


Design main page

The main goal of this task is to create a main page that are good looking

https://www.figma.com/file/a0n0ceHnVZvt0Ksf4QBLUC/kibolApp?type=design&node-id=0-1&mode=design&t=Cw0oAycEoTl2xlad-0

Everything is on our Figma


Question: EF code first, DBA's are suspect...

Our development staff would like to start leveraging code first schema generation, in order to reduce our cycle time.
Our current DBA staff are suspicious that code first schema's are poorly performing.
Especially because we are relying on Guid's for entity identifiers.
(I'm suggesting we simply cluster on a int value, and leave our guids as PK/FK)
Is there any type of documentation or other material that could help ease some internal tension on this issue?  Our DBA's are rarely persuaded by anything other than 'official' statements.

@boxofnotgoodery EF can use different kinds of keys, so using Code First/Migrations should not be something that forces use of one type of key or the other.

Their issue is more general about the "quality" of ef code first generated schema.
From experience I'm aware they might not be the most tuned table strucutres, but they generally work well enough.
Again, looking more for any type of "official" statement about the overall ability of code first to generate acceptable schema for non "toy" applications.
I doubt such a thing exists.. Maybe I should see if MS has a list of larger orgs that rely on code first..
It's not really a technology issue as it is a confidence issue.

@boxofnotgoodery It doesn't have to be either Code First or DBA. The DBA can still have input into the schema and the code first mappings can be changed as necessary to keep the DBA happy. Another way of saying this is that Code First does not dictate that a schema has to be a certain way--it all depends on how the Code First mappings are configured. So it doesn't really make sense to have a statement that "Code First generates acceptable schemas".
All that being said, to answer your question directly I'm not aware of any official statement on this, or a public list of larger orgs that are using Code First.


s3 encryption filter

Trying to create a rule to delete all unencrypted s3 buckets. I have been using yaml and can't find a filter for unencrypted buckets.

check out:
$ custodian schema s3.filters.bucket-encryption

Help
----

Filters for S3 buckets that have bucket-encryption

:example

.. code-block:: yaml

        policies:
          - name: s3-bucket-encryption-AES256
            resource: s3
            region: us-east-1
            filters:
              - type: bucket-encryption
                state: True
                crypto: AES256
          - name: s3-bucket-encryption-KMS
            resource: s3
            region: us-east-1
            filters
              - type: bucket-encryption
                state: True
                crypto: aws:kms
                key: alias/some/alias/key
          - name: s3-bucket-encryption-off
            resource: s3
            region: us-east-1
            filters
              - type: bucket-encryption
                state: False

Schema
------

{
    "type": "object",
    "properties": {
        "type": {
            "enum": [
                "bucket-encryption"
            ]
        },
        "state": {
            "type": "boolean"
        },
        "crypto": {
            "type": "string",
            "enum": [
                "AES256",
                "aws:kms"
            ]
        },
        "key": {
            "type": "string"
        }
    },
    "additionalProperties": false,
    "required": [
        "type"
    ]
}


Incorrect keyboard behaviour

When the TextField field is not pressed - the screen should be static (autoScroll - false), when the TextField is pressed - the keyboard appears and the screen should scroll (autoScroll - true). When I apply to autoScroll property this value: " (MediaQuery.of (context) .viewInsets.bottom! = 0)? true: false," the keyboard appears and disappears IMMEDIATELY(that's the actual issue), and the  warning appears:
W / IInputConnectionWrapper (9060): beginBatchEdit on inactive InputConnection
W / IInputConnectionWrapper (9060): getTextBeforeCursor on inactive InputConnection
W / IInputConnectionWrapper (9060): getTextAfterCursor on inactive InputConnection
W / IInputConnectionWrapper (9060): getSelectedText on inactive InputConnection
W / IInputConnectionWrapper (9060): endBatchEdit on inactive InputConnection.

If you enter data quickly - the keyboard does not disappear.
Could you help me to solve this issue?

@override
  Widget build(BuildContext context) {

      return SafeArea(

        child: Scaffold(

          backgroundColor: LibraryColors.mainGreen,

          body: KeyboardAvoider(

            autoScroll: (MediaQuery.of(context).viewInsets.bottom != 0)? true : false,

            child: BlocListener<AuthBloc, AuthState>(),

            ...

          ),

        ),

      );

  }

It's an open issue in Flutter. https://github.com/flutter/flutter/issues/9471


Default output size for irfft(n)

Related to #10238
In numpy/numpy#13357, @mreineck notes that numpy.irfft will fail for inputs of length 1 because the default size of 2*(len-1) is 0. The alternative default is 2*len - 1 which will never truncate the input array.
The current behaviour loses information: len(rfft(irfft(x)) != len(x). In general, it is a bad idea to use irfft without specifying the size and will only behave properly for even length inputs.
scipy.fft will of course have to match numpy.fft, so any change in behavior needs to be coordinated. Possibly by deprecating the default value, or at least providing a warning.

scipy.fft will of course have to match numpy.fft, so any change in behavior needs to be coordinated. Possibly by deprecating the default value, or at least providing a warning.

If the behavior is bad for length 1 arrays and, more importantly, odd-length arrays then I think it's fine to deviate from numpy I'd say. I suggest to open a doc PR for numpy at least. That will get us some feedback on whether numpy wants to just document or deprecate some behavior.


Node server not sending pre rendered content.

Describe the bug
When I build and serve the example app from https://github.com/sveltejs/kit/tree/master/examples/svelte-kit-demo using node build I get prerendering: false in the about page.
Logs
To Reproduce

Clone this repo.
Navigate to /examples/svelte-kit-demo
yarn install
yarn build
node build
Go to localhost:${PORT}/about

Expected behavior
Since the about page is being pre rendered, I expect it to show, prerendering: true. The pre rendered HTML inside the build folder does contain prerendering: true. But I expect the same to be shown in the browser.
Stacktraces
Information about your SvelteKit Installation:

Diagnostics

System:
OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
CPU: (4) x64 Intel(R) Core(TM) i3-6100U CPU @ 2.30GHz
Memory: 171.84 MB / 3.71 GB
Container: Yes
Shell: 5.0.17 - /bin/bash
Binaries:
Node: 14.16.0 - /usr/local/bin/node
Yarn: 1.22.5 - /usr/bin/yarn
npm: 7.9.0 - /usr/local/bin/npm
Browsers:
Firefox: 87.0
npmPackages:
@sveltejs/kit: ^1.0.0-next.72 => 1.0.0-next.72
svelte: ^3.35.0 => 3.37.0
vite: ^2.1.5 => 2.1.5

Severity
serious
Additional context

I'm not sure what the bug is referring to here, also because the example app doesn't exist anymore in the provided link. Prerendering is mostly relevant for an adapter when building, not when serving the app, in which case it is rendered in the server.


test: fix s3 integration test

What problem does this PR solve?
Fix s3 integration test by setting the source dir to the right s3 address.
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes

/run-all-tests

/run-all-tests

/merge

/merge


Remove unused AddCommandTest code

Coverage remained the same at 86.274% when pulling a65ef9ea83c24631544b5fd1a8bbcac8f08b7b44 on luishengjie:master into fcab8995aadb15bbaee92636f9b5c5dac07927d1 on CS2103JUN2017-T4:master.


Build Failed Android - Execution failed for task ':react-native-photo-gallery-api:compileDebugJavaWithJavac'.

Hi,
When i build my app this error spawn.

If you have a solution for this ?

Hey 👋 , you need to use JAVA 8 or more to build app, otherwise lambda expressions are not known. you can check your actual java version.

Thanks you for you're reply.
I am already on version 8 of JAVA.

Can you send me the reproduction steps, and also the command line you are using please

Reproduction Steps :

Add into app/build.gradle : compile project(':react-native-photo-gallery-api') in dependencies group
Add into settings.gradle :

include ':react-native-photo-gallery-api'
project(':react-native-photo-gallery-api').projectDir = new File(rootProject.projectDir, 	'../node_modules/react-native-photo-gallery-api/android')

Command line :
npm run android

yarn add
yarn install then you sync your android project on android studio and you start the app

My version of React Native is 0.64.2
And with yarn is the same erorr

Incredible thanks you, i will test this version today

It's work thanks you !

Don't hesitate to leave a STAR on the repo, 😉😅


Slick gallery does not load when called on infinite scrolling page

Hi Everyone
Basically I have implement slick earlier too but this time there was new challenge. The client wanted infinite scroll of pages and in some page the slick slider is there.
When the page is loaded for the first time then the slider is fine it loads properly but if in the subsequent page if there is a gallery then it gives me an error.
You can check the page on this url http://www.eventfaqs.com/news/ef-11381/toast-events-launches-first-ever-store-of-one-friday-with-harshali-malhotra--rajiv-makhni (as of now i have removed the code of initializing the slick slider but the moment i add that code then it gives me an error as "Uncaught TypeError: Cannot read property 'add' of null"
Can you please let me know what is the issue.

Did you remove the whole slider component or just the part that initalize slick? If you can add post here the code required to initialize slick that would be help us try it.

You have to re-initialize slickslider on the elements because they did not exist in the DOM when it was first initialized. Basically you will want to hook into the infinite scroll script and destroy and initialize slick slider the same way you do in a (document).ready() but inside the infinite scroll action.

Thanks Lindsayanng, your tip was pretty helpful, earlier in our infinite scroll on rendered event we use to initialize the slider every time, now we are using the below code to find the slider and initialize the same slider again.
like below
$items.find('.slider-for').slick({
slidesToShow: 1,
slidesToScroll: 1,
arrows: true,
fade: true,
slide: 'li',
adaptiveHeight: true
});


All default_qc=True in postprocessed/quality_metrics.csv

Since the pipeline version started running, all values have become True. Are the units with False values being filtered out?

Hi Ben. No it is the same as the old capsule. Can you point me to a result asset where this happened? I haven't noticed in in other datasets produced by the pipeline.

E.g., this link was created today.
Also note that the default_qc is not part of the quality_metrics.csv


Added CreateProperty method exposing the target Type to the DefaultContractResolver

Attempts to address #2488
Summary
When inheriting from the DefaultContractResolver and overriding the CreateProperty(MemberInfo, MemberSerialization) method, the MemberInfo made available provides the wrong memberInfo.ReflectedType when the member is declared on a base class.
This is because private getters and setters are inaccessible unless the property was gotten from the base type:
https://github.com/JamesNK/Newtonsoft.Json/blob/b6dc05be5a0f4808f06ec430f3bb59b24d3fbc3e/Src/Newtonsoft.Json/Utilities/ReflectionUtils.cs#L945-L954
This unfortunately has a side-affect where the target Type being resolved can be lost when creating the JsonProperty for a property defined on a base class, leaving the CreateProperty method with no context of what Type is being resolved.
While this isn't an issue internally, it could pose an issue for anyone overriding this method who needs to know the type being resolved (I've run into this issue and have implemented a temporary solution as shown in the linked issue).
This PR adds an extra method between CreateProperties and CreateProperty, which exposes the target Type as a parameter.
Before
CreateProeprties(Type, MemberSerialization) -> CreateProperty(MemberInfo, MemberSerialization)
After
CreateProeprties(Type, MemberSerialization) -> CreateProperty(Type, MemberInfo, MemberSerialization) -> CreateProperty(MemberInfo, MemberSerialization)
This intermediate method serves no purpose but to expose the Type if necessary.

Having thought about it for a bit longer, think the changes here could be confusing to people attempting to override the CreateProperty() method, as the relationships between CreateProperty(Type, MemberInfo, MemberSerialization) and CreateProperty(MemberInfo, MemberSerialization) is not clear without first looking at the source code.
Given that this isn't a huge issue, I think an appropriate workaround is to override the CreateProperties(Type, MemberSerialization).


response headers?

I need to access the response headers . . . for example when I do Model.all, ResultIterator contains the status and of course the resulting objects, but I can't figure out how to get the response headers. Specifically I need the Link response header so I can do previous, next, first, last, etc.
I guess what I really need is the raw result back and not just ResultIterator.
Anyway is this possible with active-rest-client?
Sorry if I'm missing something obvious.
Thanks!
Ben

It wasn't in there, but I understand your need (sorry for the delay in responding - I haven't been using ARC since leaving Which, but now I am).  I've just made a change to support this, so if you use 36a875b or above from this git repo, it'll expose @your_object._headers.


⚙ New-ScriptFromTemplate Improvements

New-ScriptFromTemplate should be split back into two files. The Author name should also be an optional parameter that stays blank instead of using my name from initial development.
Discussed in https://github.com/SamErde/PSPreworkout/discussions/9

Originally posted by jdhitsolutions September 11, 2024
I recognize that you are using this as an accelerator for your work, but if you are publishing a module for the public to use, you need to consider more than just your use cases. For example, when I create a new script file, you show as the author. 😁

You might also consider adding [ValidateNotNullorEmpty()] on the parameters. Maybe even a ValidateScript on the Path to verify the path exists. You can put all of your tests as parameter validations. You have no way of knowing how a user will pass parameter values to a function. Don't assume they are manually typing parameter values.
As for the template, you might consider re-designing this so that the template is an external file resource. You can provide a default in the module. That way, I can define my own template. For example, I have standard code I use in all my Begin blocks. Of course, you need to provide direction on how the template should be layed out.
You've got a decent start, but scaffolding commands are tough to build, especially when you are building a tool for anyone to use.

Working on a POC for using a module configuration file to store the user name and email. See feature-module-settings-01.


Add linux agent

[x]  ssh-keys metadata handler
[ ]  set up user password to make serial console from browser usable without need to login via ssh
[x]  bring cert from cert manager
[x]  bring secrets from lockbox
[x]  bring secrets encoded by KMS and decode them

совсем забыл, имя порта COM4 не будет работать в linux

Looks good


Add a setting to prevent extra newline between brackets

Pressing Enter while the cursor is between empty brackets results in an extra newline before the closing bracket. For example, using | to represent the cursor, if we press Enter here
foo = [|]

we get
foo = [
    |
]

I'd love a setting which allows me to get this instead:
foo = [
    |]

In case it's not clear, I'm thinking about all kinds of brackets, not just square brackets. Like, whichever ones editor.autoClosingBrackets handles.

Could you please reconsider? This auto-newline bullshit is easily in my top 10 of most infuriating text editor misfeatures.

setttings.json add "editor.language.brackets": [], can do what you say.

setttings.json add "editor.language.brackets": [], can do what you say.

@ygqygq2 - No, it can't. You have misunderstood my issue.
@imax9000 @foreverstupid @tinynow @JuliusPunhal - Thank you for upvoting this issue. It's always nice to know that I'm not the only one! Especially for coming back after three years and still expressing support.
As far as I'm aware, there is still no setting within VS Code that handles this. However, for those of you who program in Python (which includes me), the Python Indent extension does have a setting for this! (I just discovered this enhancement today, though it's actually been around for over two years now.) Which I guess means there's still no relief for other programming languages without a corresponding extension; but at least it offers a little hope, and perhaps even a roadmap for those who are motivated enough to take on writing their own extension.

This option is very useful for LISP user. Why is this issue closed😳

Ok I found a setting
{
    "editor.autoIndent": "keep"
}

It's preset by the language extension whether it should add an extra new line. But VS Code can ignore that.


Added Flickr eslint config, updated source and fixed a couple of typos.

Coverage remained the same at 100.0% when pulling 56f0959e7b1c4b94190b71cd80d63be426f69954 on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

Coverage remained the same at 100.0% when pulling 56f0959e7b1c4b94190b71cd80d63be426f69954 on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

Coverage remained the same at 100.0% when pulling f2563beaefc421b1bddc9f6549970d92cbbdd732 on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

Coverage remained the same at 100.0% when pulling d65eeedd2cb16d66953a0658d853c03a1fdc205b on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

Coverage remained the same at 100.0% when pulling 89123ad6e16747810dcf79514dd769bbd2a725ac on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

Coverage remained the same at 100.0% when pulling 4655c823fc4f4630e911b8909b1395be570cf5bb on superic:eslint into 214f73100ce688159ce525f0ee14298d0936b1e6 on flickr:master.

@jeremyruppel @alex-seville feeling good for a +1 here?

👍  but this is definitely a major version bump when you release it.


Pattern-libraryise CSS

Something something make CSS and accompanying HTML modular.

@norrishung this was already in the system, but it's basically what you've been doing all week. :)  Tidying up the issues a bit before Friday.


Bundles can no longer be instantiated with bound hardware

Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement
Bug fix
API Impact
Changes existing API: Code previously taking advantage of Bundles with bound hardware elements will crash.
Backend Code Generation Impact
No impact
Desired Merge Strategy
Squash and merge
Release Notes
Bundles can no longer be instantiated with value bindings or bound hardware. Fixes #1894
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've marked this API Modification because (as the removed test indicates), thing that used to "work" no longer do. That being said, I would argue this was an API hole, not a feature, since only very specific things worked and otherwise you usually got an error (rebinding if you passed such a Bundle to a binding op).


feat: Use the 1.0.0-rc version of Higress Console

Ⅰ. Describe what this PR did
Use the 1.0.0-rc version of Higress Console
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #317 (4b0cd62) into main (461f7ed) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   41.84%   42.01%   +0.17%
==========================================
  Files          44       44
  Lines        5850     5850
==========================================
+ Hits         2448     2458      +10
+ Misses       3227     3217      -10
  Partials      175      175

see 1 file with indirect coverage changes


Use of CSS to generate  link text makes it hard to ^F for the tags.

For example, in https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo, searching for "<meta>" finds no instances on the page, even though there's an instance in step 1.
https://github.com/tabatkins/bikeshed/blob/0e48c5633bbcd74ca64edd606332bb98424f08d2/bikeshed/Spec.py#L849-L850 generates the angle brackets as content, which prevents browsers from searching for them or copying them. I suspect Bikeshed should generate them as light-dom text instead.
This is related to #474.

This would also be mitigated by https://github.com/w3c/csswg-drafts/issues/6222 and https://github.com/w3c/csswg-drafts/issues/8046.

Given that this problem with searching for generated css content is likely to be fixed in the browser, I'm not sure if we should address this problem now.   I'm not sure how much work it would be to replace all the use of generated content with actual content, though that might be better in the long run for other reasons.

It wouldn't be much of an issue either way, honestly.


Fix compilation with multiple and imported css assets

An attempt at fixing #2517 and #2518
🤞

Real smart one I am forgetting to commit the file mix is actually compiling. 😂


build stemcell for CloudStack with Xen

This patch make it possible to build a stemcell to be used on the Xen hypervisor under CloudStack orchestrator.
It is currently used with CloudStack ≥ 4.11 and XenServer 7 and build on top an Ubuntu Bionic base image.
Usage:
bundle exec rake stemcell:build_with_local_os_image[cloudstack,xen,ubuntu,bionic,$PWD/tmp/ubuntu_base_image.tgz,"1.23"]

Notes

This PR is derived from a series of patches we have been used for years in production on top the Ubuntu Xenial image which has reached it's end of life earlier this year; meaning it does have some Xenial leftovers in the code but is now build on top the Bionic releases.
While working on this PR for Bionic, we noticed the virtual machines network interface eth0 was left in a "down" state when we used we used (stemcell_builder/stages/bosh_go_agent/assets/bosh-agent-version) a recent (v2.366.0) version of the bosh-agent; however it does work as expected with the v2.346.0 version.

We would welcome any feedback on this pull request and additional requirements needed for it to be accepted.
Cheers,
Romain.

the issue related to the newer bosh agent can be found here: https://github.com/cloudfoundry/bosh-agent/pull/238
i also noticed that this has never been made availeble in xenial branch or even listed on bosh.io.
is this something that is required as well

Thank you for your feedback, I will promptly take it into account (as well as the CLA issue).

we can accept this PR.
and if you want to have these stemcells builded and released on bosh.io
we probably need to discus this with the cloudfoundry foundation

we can accept this PR.
and if you want to have these stemcells builded and released on bosh.io
we probably need to discus this with the cloudfoundry foundation

Thank you for your support and insight on this PR.
If we can have it merged it will be plenty (as we can continue to build it locally until a larger number of users using the same kind of infrastructure make themselves known).


Add labels inside READ tokens

Both EgressFetchHandler.java (Fetch API)  and FETCH.java (WarpScript API) implements Tokens.labelSelectorsFromReadToken() but looking deeper into this method, I've noticed that in Quasar, deliverReadToken() doesn't provide a way to create a read token with built-in labels.
Ultimately, the Thrift struct ReadToken doesn't provide a dedicated field for labels (there is one for attributes withal which make me think that's just an oversight).
We should add a fourteenth field in the struct reflecting the ability to extract labels from the read token too.

PR #174 is an intent to solve this issue

merged


fix: update deployable-architecture-observability-instances.svg

Description
Update Observability instance deployable architecture reference architecture.

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

Closing this PR as the changes will go in https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/pull/180


feat: Extend the macro system to support import erroring on cyclic dependencies

This implements the change to the macro system in #99 (with a few tweaks). The main change is that macros can now store some state which in the case of the import macro, allows it to store a stack of modules currently being imported. In addition to this #93 closed as I found it necessary to have more control over how imported modules are compiled (in this case it was necessary to reuse the MacroExpander for all recursive expansions of import).
While this makes the compiler_pipeline module at least usable, there is still some work to make it easy to use. I don't think that is of immediate concern though and I don't have any concrete ideas how so I think it is fine to close that issue as well as that can probably only be discovered through further use of it.
Closes #99
Closes #93

This could probably do with a few more comments. Will add that sometime tonight.

Don't worry, I am in no rush.


Improve documentation on Typed Expressions versus CAST

https://www.cockroachlabs.com/docs/v22.1/scalar-expressions#explicitly-typed-expressions is not making much sense and could be improved.
(That is : Triple colon versus double colon operator)
Currently it says:
Syntax:
:::
ANNOTATE_TYPE(, )
Evaluates to the given expression, requiring the expression to have the given type. If the expression doesn't have the given type, an error is returned.
Type annotations are specially useful to guide the arithmetic on numeric values. For example:
SELECT (1 / 0):::FLOAT;
ERROR: division by zero
SQLSTATE: 22012
SELECT (1 / 0);
ERROR: division by zero
SQLSTATE: 22012
SELECT (1 / 0)::FLOAT;
ERROR: division by zero
SQLSTATE: 22012

Notice all three examples result in the same error message.
This example would be more clear with the following:
Syntax:
:::
ANNOTATE_TYPE(, )
Evaluates to the given expression, requiring the expression to have the given type. If the expression doesn't have the given type, an error is returned.
Type annotations are especially useful to guide the arithmetic on numeric values. For example:
SELECT (3 / 2):::INT;
ERROR: unsupported binary operator: <int> / <int> (desired <int>)
SQLSTATE: 22023
SELECT (3 / 2);
?column?
-------------------------
1.5000000000000000000
(1 row)
SELECT (3 / 2)::INT;
int8
--------
2
(1 row)

Also I do not think this is correct in 22.1.0:

Type annotations are also different from cast expressions (see above) in that they do not cause the value to be converted. For example, now()::DATE converts the current timestamp to a date value (and discards the current time), whereas now():::DATE triggers an error message (that now() does not have type DATE).

root@localhost:26257/defaultdb> select now();
               now
---------------------------------
  2022-06-01 20:24:11.989591+00
(1 row)

Time: 1ms total (execution 0ms / network 0ms)

root@localhost:26257/defaultdb> select now():::DATE;
     now
--------------
  2022-06-01
(1 row)

Time: 1ms total (execution 0ms / network 0ms)

root@localhost:26257/defaultdb> select now()::DATE;
     now
--------------
  2022-06-01
(1 row)


Make Limbo core no_std

Discussed in https://github.com/tursodatabase/limbo/discussions/441

Originally posted by michalfita December 11, 2024
One of key features of original SQLite is that in can be built for bare metal system and used without OS in place on microcontrollers. To achieve the same, the core of Limbo would have to be no_std with ability to plug in a storage backend that's non-Linux thing. But I don't see #![no_std] clause in core's lib.rs.
Is this no-feature for Limbo being oriented for cloud solutions?

Hi, I'm new to this project, learned about it this week and was very interested. I stumbled on this issue and tried to tackle it to see if it is doable.
I refactored core to use #![no_std] and managed to get 34 errors (I'll list the kinds of errors below). I just hacked trough the files using alloc and core instead of the std modules. this can be simplified by creating a new module that acts as a middle man (see below). The things i couldn't resolve were the things that actually depended on std:

use of std::collections::HashMap and std::collections::HashSet
use of std::sync::RwLock and std::sync::OnceLock,
use of std::fs::*
use of std::io::*
use of std::env::*
use of println! and eprintln

I think i got all the dependencies to compile with no_std but im not sure since building ends  after the above errors are emitted.
Im not familiar with the architecture at the moment or the implementation choices, but for some of the issues listed i think we can use the no_std_compat crate and remove the println and eprintln uses, but im not sure i don't know the implications of that.
The link to my fork/branch: https://github.com/LorrensP-2158466/limbo/tree/core_no_std. It does not compile at the moment.


fix sail mysql command

currently  error happen when using sail mysql
$ sail mysql
ERROR: No such service: mysql

So I fixed it. Then you can check it works
$  sail mysql
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 9
Server version: 5.7.33 MySQL Community Server (GPL)

Copyright (c) 2000, 2021, Oracle and/or its affiliates.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql>

Working fine for me:

@taylorotwell
i faces same issue.
This is a bug that occurs when the service name is custom like hoge-mysql.test.
And such a case is highly probable when developing in parallel, since the service name mysql.test is probably duplicated.


Official release

Hi, is there an official release somewhere? 😀
I would prefer Maven Central, but GitHub Packages or other is fine too.
Let me know if I can help, setting up CI or other things needed for automatic push/upload of release artifacts.

Not at the moment, I haven't published any releases. I know how to set up CI to automatically release artifacts but I don't really want to. I'd rather release when stuff feels ready.

Fully understand that decision! It's a pity though, as I think the decoder is already very useful! 😀


enhancement (fix?): Implement automatic IP detection to replace localhost for local debugging

As described here: http://moduscreate.com/automated-ip-configuration-for-react-native-development/
Benefits: prevents you from getting an error about being unable to load the js bundle
Drawbacks: possibly non-robust script proposed that could mess people up as described here in the comments here: https://gist.github.com/kwcto/8ca4c7c6fd6b613b5d42#gistcomment-1664668

hmm


Relative installs break on subsequent installs due to pip-wheel-metadata

[X] I am on the latest Poetry version.

[X] I have searched the issues of this repo and believe that this is not a duplicate.

[X] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: macOS + 10.14.5

Poetry version: 0.12.6 (sudo pip3 install poetry==0.12.16)

parent pyproject.toml
[tool.poetry]
name = "parent"
packages = [{ include = "parent" }]
version = "0.1.0"

[tool.poetry.dependencies]
python = "^3.7"
dependency = {path = "../dependency"}

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

Issue
poetry install generates pip-wheel-metadata files in my relative-path dependencies, which break later installs with FileExistsError. My current workaround is simply to rm -rf ../dependency/pip-wheel-metadata/ before installs.

FileExistsError: '/path/to/dependency/pip-wheel-metadata/dependency-0.1.0.dist-info' installation failure
Using virtualenv: /path/to/parent/.venv
Installing dependencies from lock file

Package operations: 5 installs, 0 updates, 0 removals, 60 skipped

  - Skipping ... installed
  - Installing relative-dep (0.1.0 ../dependency)

[EnvCommandError]
Command ['/path/to/parent/.venv/bin/python', '-m',
'pip', 'install', '--no-deps', '-U', '-e', '/path/to/dependency
'] errored with the following output:
Obtaining file:///path/to/dependency
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'error'
    Complete output from command /path/to/parent/.venv/bin/python /path/to/parent/.venv/lib/python3.7/
site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /var/folders/1_/d
rxyjr152tvfmv8jp80hyzrw0000gp/T/tmp2tvqzsf2:
    Traceback (most recent call last):
      File "/path/to/parent/.venv/lib/python3.7/sit
e-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
        main()
      File "/path/to/parent/.venv/lib/python3.7/sit
e-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
        json_out['return_val'] = hook(**hook_input['kwargs'])
      File "/path/to/parent/.venv/lib/python3.7/sit
e-packages/pip/_vendor/pep517/_in_process.py", line 69, in prepare_metadata_for_build_wheel
        return hook(metadata_directory, config_settings)
      File "/private/var/folders/1_/drxyjr152tvfmv8jp80hyzrw0000gp/T/pip-build-env-h22cq9gb/overla
y/lib/python3.7/site-packages/poetry/masonry/api.py", line 39, in prepare_metadata_for_build_wheel
        dist_info.mkdir()
      File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/
pathlib.py", line 1251, in mkdir
        self._accessor.mkdir(self, mode)
    FileExistsError: [Errno 17] File exists: '/path/to/dependency/pip-wheel-metadata/dependency-0.1.0.dist-info'

    ----------------------------------------
Command "/path/to/parent/.venv/bin/python /path/to/parent/.venv/lib/python3.7/site-packages/pip/_vendo
r/pep517/_in_process.py prepare_metadata_for_build_wheel /var/folders/1_/drxyjr152tvfmv8jp80hyzrw0
000gp/T/tmp2tvqzsf2" failed with error code 1 in/path/to/dependency
You are using pip version 19.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Exception trace:
 /usr/local/lib/python3.7/site-packages/cleo/application.py in run() at line 94
   status_code = self.do_run(input_, output_)
 /usr/local/lib/python3.7/site-packages/poetry/console/application.py in do_run() at line 88
   return super(Application, self).do_run(i, o)
 /usr/local/lib/python3.7/site-packages/cleo/application.py in do_run() at line 197
   status_code = command.run(input_, output_)
 /usr/local/lib/python3.7/site-packages/poetry/console/commands/command.py in run() at line 77
   return super(BaseCommand, self).run(i, o)
 /usr/local/lib/python3.7/site-packages/cleo/commands/base_command.py in run() at line 146
   status_code = self.execute(input_, output_)
 /usr/local/lib/python3.7/site-packages/cleo/commands/command.py in execute() at line 107
   return self.handle()
 /usr/local/lib/python3.7/site-packages/poetry/console/commands/install.py in handle() at line 55
   return_code = installer.run()
 /usr/local/lib/python3.7/site-packages/poetry/installation/installer.py in run() at line 73
   self._do_install(local_repo)
 /usr/local/lib/python3.7/site-packages/poetry/installation/installer.py in _do_install() at line 290
   self._execute(op)
 /usr/local/lib/python3.7/site-packages/poetry/installation/installer.py in _execute() at line 306
   getattr(self, "_execute_{}".format(method))(operation)
 /usr/local/lib/python3.7/site-packages/poetry/installation/installer.py in _execute_install() at line 331
   self._installer.install(operation.package)
 /usr/local/lib/python3.7/site-packages/poetry/installation/pip_installer.py in install() at line 30
   self.install_directory(package)
 /usr/local/lib/python3.7/site-packages/poetry/installation/pip_installer.py in install_directory() at line 205
   return self.run(*args)
 /usr/local/lib/python3.7/site-packages/poetry/installation/pip_installer.py in run() at line 112
   return self._env.run("python", "-m", "pip", *args, **kwargs)
 /usr/local/lib/python3.7/site-packages/poetry/utils/env.py in run() at line 536
   return super(VirtualEnv, self).run(bin, *args, **kwargs)
 /usr/local/lib/python3.7/site-packages/poetry/utils/env.py in run() at line 385
   raise EnvCommandError(e)

install [--no-dev] [--dry-run] [-E|--extras EXTRAS] [--develop DEVELOP]

This was not the case for this same structure and pypproject.tomls in an earlier, now-lost environment.
I have not been able to replicate the previous working environment, but it had poetry==1.0.0a2 and python 2 + it's pip, whereas I now don't have any "activated" pip<19 (though behavior doesn't change by installing different pip versions, as poetry manages it's own pip 19.0.3)

@micimize Any progress on this issue? Any workaround? It's really annoying to remove pip-wheel-metadata before every install.

@vovapolu I'm on 1.0.0a3 now, but commenting out the build system bock in submodules, clearing artifacts (pip-wheel-metadata, etc), poetry lock, and then poetry install from the top level project seems to be working for me.
# [build-system]
# requires = ["poetry>=0.12"]
# build-backend = "poetry.masonry.api"

Well, indeed removing pip-wheel-metadata every time solves the problem. Or you suggesting to do poetry lock firstly?

@vovapolu I'm saying that after I commented out the build-system and did those steps once, I didn't have to keep removing pip-wheel-metadata every time

Hello
I'm having the same problem, with Poetry 0.12.17 and python 3.7.4
I think this #1245 should fix it.

We would very much like to adopt Poetry, but this issue is blocking us.
We are an open-source monorepo, with several subdirectories that are independently published to PyPI. Users may use one, or all of our packages, and our packages have interdependencies.
Because, e.g., package_c requires package_b and package_b requires package_a, it's currently impossible to install both package_b and package_c for local development -- package_b's existing relative install of package_a will trigger this issue when a user tries to install package_c.
The workaround is not viable for an open source project.

Does the merged PR above fix this, or not?

@Natureshadow It does not appear to be fixed on 1.0.0b1. Possibly because the PR fixes mkdir, but the error is from creating a file:
FileExistsError: [Errno 17] File exists: '/path/to/dependency/pip-wheel-metadata/dependency-0.1.0.dist-info'

@Natureshadow It does not appear to be fixed on 1.0.0b1, but I'm not sure why. When I try to poetry install, I get
File "/private/var/folders/1_/drxyjr152tvfmv8jp80hyzrw0000gp/T/pip-build-env-dfxxevnh/overlay/lib/python3.7/site-packages/poetry/masonry/api.py", line 39, in prepare_metadata_for_build_wheel
        dist_info.mkdir()

but the same lines in ~/.poetry/lib/poetry/masonry/api.py are now
    dist_info = Path(metadata_directory, builder.dist_info)
    dist_info.mkdir(parents=True, exist_ok=True)

I've tried deleting ~/.poetry and virtual environments and reinstalling, but nothing has helped

File
"/private/var/folders/1_/drxyjr152tvfmv8jp80hyzrw0000gp/T/pip-build-env-dfxxevnh/overlay/lib/python3.7/site-packages/poetry/masonry/api.py",
line 39, in prepare_metadata_for_build_wheel
dist_info.mkdir().

Looks like another location with the same bug.

@micimize @Natureshadow
Going blind on this, but did you put requires = ["poetry>=1.0.0b1"] instead of 0.12 ?
I feel like dependency is downloaded when doing the build, so version needs to be done

@Hartorn I'll be damned - this specific issue was solved by replacing requires in all the dependencies as well.
I ran into a different issue that has the same workaround, but I think it is a more niche issue.
Opened #1315 for that, closing this


Enable pre-commit ci and add default config

PR Type
[Feature | Fix | Documentation | Other() ]
CI
Short Description

Adds pre-commit ci to update pre-commit hooks weekly, correct pre-commit issues (non-local ones)

Tests Added
...

I'm late to the party, but this is cool stuff!


test: Avoid installing Cilium for K8sBandwidth if tests are skipped

The overall structure for test K8sBandwidth looks to have been extracted from K8sServices. It works fine but is more complex than necessary and leads to unintended behavior when tests are skipped. This pull request simplifies the structure to have a single conditional Context (conditioned on net-next kernel) inside which the three It tests are run.
Cilium was also installed with the bandwidth manager enabled before the conditional Context. That installation would therefore happen regardless of whether bandwidth tests should actually be skipped, sometimes even leading to flakes on 4.9 kernels.
Removing this initial installation of Cilium implies that the test pods are now deployed (once for all tests) before Cilium is installed. We therefore need to wait for the test pods, with a new helper waitForTestPods(), after each re-installation of Cilium.

test-me-please

I've pushed the small suggestion from Deepesh. All tests were green before that, no need to re-run.


interfaces: plugins_interfaces() is not called by MVC code causing side effects in interface population

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I am using the OPNsense importer on a config file from a previous install. This previous install has WireGuard installed, configured, and working. The resulting instance after running the importer and then running the install results in a working OPNsense with WireGuard also working. However, at one point between the importer and the end of the install process, the installer removes the WireGuard (Group) interface. This is created by the plugin when an interface is enabled.
According to the backup configs, the revision's metadata shows "(root): Created web GUI TLS certificate". I have included a screenshot below.
To Reproduce
Steps to reproduce the behavior:

Configure WireGuard
Export config.xml
Use OPNsense importer on said config.xml
Check the config history.

Expected behavior
At the end of the import process, the WireGuard interface group should exist.
Describe alternatives you considered
I have tried to trigger the creation of the interface by doing the following, but none worked.

Uninstalling and reinstalling the plugin.
Disabling and enabling the local server configuration.
Disabling and enabling WireGuard.
Creating a new local server configuration.
Creating a new local server configuration with all others disabled and WireGuard disabled.

Screenshots

Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 22.1.7_1 (amd64, OpenSSL)

If anyone encounters this installer bug here is a workaround until the bug is fixed:

Login to the OPNsense web console.
Navigate to the Interfaces menu.
Select Assignments.
In the pane that appears on the right, click Save.

This will recreate the missing interface.

Could it be the importer bug happened because wireguard plugin was not installed?

The wireguard plugin is listed in the config.xml that the importer uses. However, I have noticed that the existence of that plugin in the XML does not cause the installer to install the wireguard pkg during install. That only happens after the first updates (or can be done manually).

Yeah, which has the plugin code to create the group. The issue here, however, seems to be that from MVC code we do not create interfaces on config sace since that is only available in legacy code.

Thanks @fichtner !

@utkonos we are adding a slightly improved version for 22.7, but this needs more rework for 23.1 to integrate completely.

note: mvc pluginctl -i mutable controller flag to call it since we need it for new ipsec vti api


Provinding guidances regarding compression capabilities

(This issue comes from DGIWG Imagery and Gridded Data Panel review of COG Draft Standard - September 2022)
Recommandation 2 ("/rec/rec-class-geotiff/rec-compression") is stating: "In a COG file, tiled data should be compressed efficiently"
This makes clearly sense but remains very open to interpretation. Maybe this recommendation could be more specific and provide more guidances regarding compressions capabilities.

The recommendation has been changed to: "In a COG file, tiled data should be compressed efficiently using LZW or JPEG compression" that are the two compressions in TIFF v6 that are recommended for imagery (other compressions target facsimile)

While it is true that LZW and JPEG are the two image compressions mentioned in TIFF v6 there are many other image-based compressions that have become popular since TIFF v6's original release in 1992.  Practically speaking, if this conformance class limits compression to LZW/JPEG then most COGs found in the wild will not be OGC compliant as they often use compressions like ZSTD, DEFLATE, WEBP, LERC, LERC_ZSTD etc.  I have been working with COGs at large scales for many years now and I have personally never created a COG with LZW compression, as other lossless compressions are simply better.  Even binary compressions can be useful for COGs (ex. segmentation masks created by machine learning workflows).  New compressions are constantly being released too so this conformance class as currently written will not age well.
I think this conformance class should include language indicating that modern image compressions not included in the original TIFF v6 specification can be used with a warning that certain compressions may not be supported by specific TIFF readers (although libtiff already supports most of these).  Libtiff should probably be the reference example for what compressions are commonly supported.
See https://www.awaresystems.be/imaging/tiff/tifftags/compression.html for more details.

Thank fr the advice. I have reused most of your text in the recommendation. I believe we can close the issue now.


streamline release process

Is your feature improvement request related to a problem? Please describe.

Currently the official release process requires too many manual steps, e.g.

Trigger cargo-release workflow which creates a PR with the bumped Cargo.toml version
Merge the cargo-release PR (after waiting for PR checks to finish)
Checkout main project and create tag (as tagging can't be done from a fork)
Checkout the tedge-docs repo, and create a new snapshot, create a PR and merge it
Create a Github release in draft
Format release notes
Copy cloudsmith release artifacts from tedge-main* to tedge-release*
Publish Github release
Trigger Algolia crawler (for updating doc search index)

Describe the solution you'd like

Automate as many of the above steps as possible reducing chance of human error.
The following is the proposed workflow which mainly just required manual PR reviews and creation of the change log (which could also be automated in the future if conventionalcommits are used).

Trigger Workflow (currently called hosted-post-merge_version_update.yml but should be renamed to release.yml) in thin-edge.io repo
Review PR and approve (wait for merge queue to finish and auto tagging)
Review Github draft release and update the changelog
Review the tedge-docs snapshot PR, and merge (this will trigger the docs to be published)
Publish the Github release from step 3.

Describe alternatives you've considered

Additional context

All of the PRs have been merged and the improved release process will be tested end-to-end on the next release.


app.HTTPMETHOD() is different from express.Router()

I think the app.HTTPMETHOD() function is the same as express.Router(),why need express.Router()?I want to know use express.Router() advantage。

Hi @yyTopfounder it's just there for splitting up your logic and grouping. The http://expressjs.com/en/guide/routing.html page goes over this a bit. Please let us know if there are still any open questions and we can look at how we can improve the page!

From the docs;
express.Router
Use the express.Router class to create modular, mountable route handlers. A Router instance is a complete middleware and routing system; for this reason, it is often referred to as a “mini-app”.

Read the  routing Docs here.