Phi3 128k instruct conversion to onnx yields model not deployable to AWS Sagemaker

Describe the bug
The model card here mentions that the phi3-mini-128k-instruct-onnx model is directly deployable to sagemaker runtime using get_huggingface_llm_image_uri("huggingface",version="2.2.0") as image uri. However, on deploying, sagemaker fails to recognize the onnx model and attempts to find pytorch weights, thus failing the builds.
I'm loading in the model to /opt/ml/model folder using s3_uri, and then mentioning the same path as HF_MODEL_ID.

To Reproduce
Steps to reproduce the behavior:

Try deploying onnx model to AWS Sagemaker using latest version of sagemaker==2.32.1

Expected behavior
Model should get deployed seamlessly, just like how phi-3-mini-128k-instruct (non-onnx) does.
Screenshots

Desktop (please complete the following information):

AWS Sagemaker Runtime

The AWS SageMaker instructions are auto-generated by Hugging Face on the model cards. Hugging Face assumes that each repo contains PyTorch models, which is why you are getting a FileNotFoundError in this repo containing only ONNX models.
For deploying ONNX models to AWS SageMaker, there are some online guides that you can try to follow. Here is an example one that you can try to follow starting from the "Create an Inference Handler" section. Here is an example with Triton Inference Server.
You can also use Azure ML to deploy ONNX models. Here is a guide you can follow. For a more detailed example, you can look at this guide.
Please note that there are multiple ONNX models uploaded in this repo. You can follow this example to pick one of the ONNX models to load using Hugging Face's Optimum. Then you can use Optimum to manage the generation loop with model.generate(...) in your inference script. Optimum will use ONNX Runtime under the hood and manage preparing the inputs for you.

Thanks for the clarification @kunal-vaishnavi
I'm unfortunately bound to using AWS Sagemaker for my deployments, so I'll have to proceed with a custom inference script using Optimum like you mentioned.
Are there plans to include optimum or onnxruntime-genai support in the next tgi images within sagemaker?

I'm unfortunately bound to using AWS Sagemaker for my deployments, so I'll have to proceed with a custom inference script using Optimum like you mentioned.

If you create your own image on top of existing TGI images, you can install and use ONNX Runtime GenAI directly instead of Optimum for the best performance in your custom inference script. Here is an example inference script that you can modify for AWS SageMaker.

Are there plans to include optimum or onnxruntime-genai support in the next tgi images within sagemaker?

This is a good idea. According to this issue, Hugging Face's TGI currently doesn't support ONNX models. We will discuss internally to see if adding ONNX Runtime GenAI is possible.

I'm unfortunately bound to using AWS Sagemaker for my deployments, so I'll have to proceed with a custom inference script using Optimum like you mentioned.

If you create your own image on top of existing TGI images, you can install and use ONNX Runtime GenAI directly instead of Optimum for the best performance in your custom inference script. Here is an example inference script that you can modify for AWS SageMaker.

Are there plans to include optimum or onnxruntime-genai support in the next tgi images within sagemaker?

According to this issue, Hugging Face's TGI currently doesn't support ONNX models. We will discuss internally to see if adding ONNX Runtime GenAI is possible.

Thanks once again
I've actually used the model-generate.py file for the deployment and that has gone smoothly. However a couple of observations:

The phi3 model prior to conversion supports an environment variable "return_full_text":False, which stops the model from echoing the user prompt. The onnxruntime-genai library however does not allow for setting this variable later on.
At times the qa model using the token streaming is faster than just the direct generation, but that ideally shouldn't be the case.

Do let me know if you have any pointers in this regards, appreciate the help!

The phi3 model prior to conversion supports an environment variable "return_full_text":False, which stops the model from echoing the user prompt. The onnxruntime-genai library however does not allow for setting this variable later on.

There isn't an environment variable to set this in ONNX Runtime GenAI. But you can filter out the user prompt with some additional logic in the inference script.
The input tokens are set here.
https://github.com/microsoft/onnxruntime-genai/blob/bcf55a6dc563bc8b356128b47504d59a21c5ef2f/examples/python/model-generate.py#L40
After the output tokens have been generated, you can go through them to remove the first $N_b$ tokens per batch entry where $N_b$ is the length of the input tokens at batch entry $b$.
https://github.com/microsoft/onnxruntime-genai/blob/bcf55a6dc563bc8b356128b47504d59a21c5ef2f/examples/python/model-generate.py#L45
Here is some pseudocode for a naive implementation.
output_tokens_without_user_prompt = []
for b in range(len(output_tokens)):
    N_b = len(input_tokens[b])
    without_user_prompt = output_tokens[b][N_b : ]
    output_tokens_without_user_prompt.append(without_user_prompt)

Then, when you print the generated tokens, the user prompt will not be re-printed.
for i in range(len(prompts)):
    print(f'Prompt #{i}: {prompts[i]}')
    print()
    print(tokenizer.decode(output_tokens_without_user_prompt[i]))
    print()

Please note that this logic may need to be modified to handle padding in the input tokens when calculating $N_b$.

At times the qa type (using the token streaming) is faster than just the direct generation, but that ideally shouldn't be the case.

We are able to repro this and we will look into it.


No Error When Using BYOK with Basic Cluster

This applied successfully. The key however was empty in the state file (see below) which I think is expected because BYOK isn't supported for BASIC
However, I'd expect a validation error though and the apply to fail. Because it didn't, any apply after will force a recreation of everything because it'll notice a delta between the state file (no key) and the desired state (key)
resource "aws_kms_key" "byok" {}

resource "confluent_byok_key" "this" {
  aws {
    key_arn = aws_kms_key.byok.arn
  }
}

resource "confluent_kafka_cluster" "this" {
  display_name = "environment.${var.environment}.cluster.${var.name}"
  availability = var.multi_zone ? "MULTI_ZONE" : "SINGLE_ZONE"
  cloud        = var.cloud
  region       = var.region
  basic {}

  byok_key {
    id = confluent_byok_key.this.id
  }

  environment {
    id = var.environment
  }
}

❯ terraform state show module.cluster.confluent_kafka_cluster.this
# module.cluster.confluent_kafka_cluster.this:
resource "confluent_kafka_cluster" "this" {
    api_version        = "cmk/v2"
    availability       = "SINGLE_ZONE"
    bootstrap_endpoint = "<redacted>"
    cloud              = "AWS"
    display_name       = "<redacted>"
    id                 = "<redacted>"
    kind               = "Cluster"
    rbac_crn           = "<redacted>"
    region             = "us-west-2"
    rest_endpoint      = "<redacted>"

    basic {}

    byok_key {} // I expected this to be populated if the apply didn't throw an error.

    environment {
        id = "<redacted>"
    }

    network {}
}

fixed in v1.81.0 terraform release


Revert "Issue-950: Make the strongbox-storage-api's tests work in parallel"

Reverts strongbox/strongbox#1425

This is no longer necessary in favor of #1454.


Sanne Debugging Week 1

[x] 🥚 Stepping Through: You can pause a script in a step debugger (breakpoints and debugger statement), arrange the debugger, collapse extra panels, and step through a script written with Just Enough JS. At each point in execution you can make a prediction of the next line before executing, and can check your prediction using the scopes panel.
[x] 🥚 Assertion Testing: You are familiar with assertions and can use console.assert to guide your study of a program.
[x] 🥚 Linting: You can find and fix linting errors in JavaScript programs.
[x] 🥚 Naming Variables: You can analyze a program's variables using a structured comment, and can rename the variables. You can give each variable two different names:
[ ] Generic: A name that describes the variable's role in a general way. This includes deciding whether to use let or const.
[ ] Specific: A name that fits the variable's role and contextualizes it in the program's domain.
[ ] 🥚 Program Life Cycle: You can explain the two phases of a program's life cycle.
[x] 🥚 Fixing Errors: You can use the structured comment to describe an error in your program, and can make several educated guesses at how to fix the error.
[x] 🥚 Documenting Functions: You can demonstrate your understanding of arguments, parameters and return values by writing a JSDoc comment.
[ ] 🐣 Explicit Coercion: You is aware of the rules for casting explicitly between types and can complete assertions to describe what value will result, they can have access to the internet and a console.
[ ] 🐣 Implicit Coercion: You is aware that operators will implicitly cast it's operands to the same type before operating. They can look or experimentally discover the rules for an operator.
[ ] 🐣 Statements vs. Expressions: You can explain the difference between a statement and an expression, and can identify them in a program. This will be very helpful for understanding how the debugger steps, and for ...
[ ] 🐣 Operator Precedence: You can refactor an expression with several operators into several statements assigning each step of the expression to a new variable according to the languages rules of operator precedence.111
[ ] 🐣 Fixing Bugs: You can use the structured comment to describe and fix a bug in small programs.
[ ] 🐣 Reference vs. Value: You can explain how to swap references or values between variables, explain deep vs. strict equality, and compare two objects or arrays.
[ ] 🐣 Procedural Programming: You can tell whether or not a JS program is Procedural and can explain how you made your decision.
[ ] 🐣 Side-Effects: Given a function that takes an array as an argument you can determine if the function has any side-effects, and can suggest a way to avoid the side-effect.
[ ] 🐣 Debugging Functions: You can read input/output assertion tests to understand a function's actual vs. expected behavior, and to correct the function's behavior.
[ ] 🐥 Sub-Goal Authoring: Given most of a small program with missing goal, you can write code to implement the missing behavior.
[ ] 🐥 Hoisting: You can find hoisted functions and variables in the browser's debugger and explain how hoisting is related to program life-cycle.
[x] 🐔 Refactoring Functions: You can refactor a designated chunk of a program into an empty function body and pass the given assertion tests.
[ ] 🐔 Reverse-Engineering: You can write a small program from scratch that matches the behavior of an example program.

Week X

[ ] I have pushed my progress to my fork of exercises repo

Check-In
I Need Help With: I still am not very good at reading code because I still don't understand JS and debugging is hard when you don't understand code yet
What went well? I see the idea and purpose of debugging and I believe it is something I could be good at, I like to spy for things, but I need to understand JS first
What went less well? JS and trying to understand it... I found some great tutorials, but like with Github I might need to look them through a couple of times to really understand
Lessons Learned: don't give up
Sunday Prep Work I am trying to tackle 50% JS and 50% Debugging for Sunday
---- END CHECK-IN TEMPLATE ----
-->

I still am not very good at reading code because I still don't understand JS and debugging is hard when you don't understand code yet

Let us know if you need anything explained! 🙂 A big chunk of code can seem overwhelming at first but when you take a look at it line by line, you will see that you can understand most of it and the parts you don't get, you can just google! Keep going and you will get there! 💪

@arnochauveau Thanks for the motivating words... just had a great call with Evan on debugging and starting to see how it all connects with the code (small light bulbs are turning on) LOL

Week 11
Check-In
I Need Help With:
I have not be able to study very much during the holidays and I am falling behind.
I try and do a little bit everyday but still it seems like it is not enough for me to get the grasp on everything (I know I do not need to know everything by now) but my brain forgets and I have to start over again, so it takes much longer.
I have been in study groups and that helps a lot but it takes me quite some time to understand things and I might have to have it repeated several times.
When I do the exercises by myself I sometimes even do not understand what kind of value that needs to go in (true, false, 1, 0,y,x,z...) even after looking at the examples and if there is a guide.
What went well?
study group always is a very big help
What went less well?
I try to watch tutorials on the same topic but will probably have to watch again a few times... I did a section on while loops on Codecademy (long time ago) so rewatching tutorials and trying to do the exercises, but got stuck.
Lessons Learned
My time management is really not good at the moment
Sunday Prep Work
Understanding functions and loops (amongst a lot of other things)

Week 12
Check-In
I Need Help With: I feel like I am falling behind and it is not just 1,2 to 3 things it is the whole Welcome to JS and Debugging chapter. I feel like I need to go through the again because the full understanding or even partial understanding is not there yet.
What went well? I was able to join study group almost everyday this week... but because I do not fully understand even some basic things I will follow but not able to contribute.
What went less well? I still feel very blank when it comes to code... when working in the group I see everybody knows what to write in the code given and even make code cleaner and better where I am not even sure still what to put in the blanks.
Lessons Learned: Nothing
Sunday Prep Work I started looking a bit at next chapter but it is extremely overwhelming when I feel I am 2 charts behind

One thing i can suggest to you is make a list of the things that have understood till now and things that you still are confused about from this module(you can use the check list above as an example) . Then you can see a clear path on what you have to concentrate on.
You don't have to study everything that is on the suggested studies And this is not a competition with your classmates but yourself. know learning a new language can be overwhelming but its not impossible.
Let us know if you need any help from us!
And to Quote you ' Lessons Learned: don't give up'

That is a good idea 🤩 Thanks will try that


Improve metadata in package.json

A number of fields in package.json could be added: author, description, etc.  I would also suggest that 1.0.0 is the wrong version number, and 0.0.1 would make more sense at this stage.

Added and fixed metadata


update Squirrel.Windows and publish

due to https://github.com/Squirrel/Squirrel.Windows/issues/204

ping @paulcbetts

This was fixed long ago, the current version of Squirrel.Windows is 0.99.3

But the commit message shows
rcedit.exe   Update to Squirrel.Windows 0.8.0 (Squirrel/Squirrel.Windows@9a06fb7)   7 months ago

rcedit doesn't change that often

@coderhaoxin If you are having issues running rcedit.exe make sure you have the Microsoft Visual C++ 2010 Redistributable Package installed:
http://www.microsoft.com/en-us/download/details.aspx?id=13523
https://chocolatey.org/packages/vcredist2010

@thughes thanks, it works :+1:


Inject mesh and virtual node name as annotations

Always inject the virtual node name and the mesh name so that the controller doesn't have to parse environment variables to discover them. See: https://github.com/aws/aws-app-mesh-controller-for-k8s/pull/53/files/e4b856d5bddec272689185d5eaf0efa34db04fdd#diff-8d4650ed46e8156bd1ea16a8212e7f76R122

@achevuru will be working on this

Not applicable for GA version. VirtualNode name will be always available in the new version and we select pods based on podSelector in VirtualNode spec in v1beta2.


Support HAML

Adds haml-lint as a dependency
Adds HamlReviewJob
Adds entry to Procfile to monitor the haml_review queue

This doesn't make any attempt to extract commonalities between the HAML
and SCSS linters with the goal of keeping the diff small. This will
undoubtedly be done in a future change.
Depends on https://github.com/houndci/linters/pull/27 and https://github.com/houndci/hound/pull/1127
https://trello.com/c/8BkUFmhA

👍

Add a default config file (and fixed a bug where it was using the SCSS default!) in a650a5e948eee9ddc68b2078c053880f3d834f4c

Looks good.

Not sure why this didn't get picked up as merged, but 61ab4ab25f044bf420d7e43aa66ea1d71d14d41a is now in master.

Not sure why this didn't get picked up as merged

Because you didn't use the "Big Green" button! 💚


ENH: Custom code after task failure/success

Is your feature request related to a problem? Please describe.
Allow running custom code after task failure/success.
Describe the solution you'd like
Possibly:

hooks hook_success, hook_failure etc.
Init params for the call backs, name suggestions

callback_fail, callback_success
fail_callback, success_callback
fail_cb, success_cb
cb_fail, cb_success
on_fail, on_success

Describe alternatives you've considered
Subclass and override process_success and process_failure.

This can be now done via Task.hook_execute.


Re-organise tests.

This PR makes it easy to run each test file individually locally:
shell> pwd
/Users/hg344/projects/Turing.jl

(test) pkg> activate test
  Activating project at `~/projects/Turing.jl/test`

julia> using Turing; include(pkgdir(Turing)*"/test/test_utils/test_utils.jl")

julia> include("test/modes/OptimInterface.jl")

This PR doesn't contain any functionality changes.

However, it is helpful to introduce a simple way to achieve a similar objective. Hence this PR.

Fair! But do we need to also remove all the files in the process? As in, why not just use include but add a single file that contains all these?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
1463

💛  - Coveralls


file_stdio should add missing std namespace to FILE type

In Boost Beast FILE is used without std namespace, but the C++ header is included. Thus is does not compile for some operating systems.
boost/beast/core/file_stdio.hpp:29:5: error: 'FILE' does not name a type
      FILE* f_ = nullptr;
      ^

A change from
#include <cstdio>

to
#include <stdio.h>

would compile, but the C include is deprecated in C++. Therefore it is recommended to replace FILE with std::FILE. There seems to be 7 occurrences of FILE: 4 of them in file_stdio.hpp and 3 in the corresponding file_stdio.ipp.

@spdw Interesting. Do you know how well supported std::FILE is? We're still testing against clang 3.
Would you be able to recommend a compiler/stdlib combination where this fails so I can add it to our test suite?

A fix for this is already in the works, see:
https://github.com/boostorg/beast/pull/1906
and
https://github.com/vinniefalco/beast/commits/embarcadero

A fix for this is already in the works, see:
#1906
and
https://github.com/vinniefalco/beast/commits/embarcadero

To me it looks like the header file is adapted only, the ipp file on that branch still lacks the std:: prefix for FILE.

Attn @madmongo1


Instructions in the README

I'm testing installation and there's a small typo:
cd bruker2nifti-master -> cd bruker2nifti
For testing, you indicate nose but you do not explain how to use it and what should be the expected results (are there skipped tests, known errors, etc.)
For installation instructions, it is not clear that you provide alternative instruction for installation. Because of the structure of the README, it's like every step I necessary. Maybe you can have a main "installation" header and sub-headers for each installation (with a small introduction explaining these are alternative ways for installation).
For the non programming method, if would be good to provide the direct link to download the last release. For non programmer, it might be difficult to navigate the GitHub interface to find the right file. Also, the zip archive of the repo and the zip of the release are not really the same, you may prefer to use the "stable" release only since the current repo might be unstable.
For the initial description, could you add link to "Brukert ParaVision" and "nifty" ? It might be good also to explain things a bit more (what is the target audience, why it is necessary, real for example, etc.)

Really agree this part requires some improvements. Also there were too many redundancies between the wiki and the README.
I tried to make it more clear while removing redundancies.

Also, do you need the virtual environment at all ? I tested it using the git clone/ install -e and it works fine. I found the virtual environment a bit confusing since you do not really explain how to use it (apart from the given link).

Uhm, lets say that are warmly suggested. Going into details of the virtualenv can be a bit of an overkill. And could not do it better than The Hitchhiker’s Guide to Python linked.
It is now a parenthesis for the curious reader. Let me know if it makes more sense.

@rougier: Hi,
Due to the redundancies between the wiki and the README I did some documentation refactoring.
The informations are the same, probably more accessible and less repetitive. If you have a spare minute let me know if you prefer it now.

Yep, definitely nicer. By the way, I recommended you submission for publication (I didn't manage to mention you using the @ notation). Only remaining issue being the new version to replace the old one and the automatic building of the PDF (very minor issues).

@rougier Thanks! Saw it! There is still the Functionality documentation tick to tick.
Very curious to read the answers about the PDF building and the versioning issue.


Typescript Support Broken

OS: OSX, 10.14.2
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Type Definition File<EMAIL_ADDRESS>import Navigo from "navigo;
Error: cannot find module 'navigo'
It appears that the type definition file is not >= ES2015 module compliant.
From index.d.ts:
export = Navigo; export as namespace Navigo;
There is an open ticket on SO where the author also faced this issue but appears to have not submitted an issue.
https://stackoverflow.com/questions/54314816/i-cant-use-or-import-navigo-in-typescript
Thank you in advance for your assistance.

I have faced this issue, too!
After a few hours of researching, I found that we can import Navigo with import Navigo = require('navigo');.
The reason that we have to import Navigo with this syntax is because of the way which Navigo exported itself.
Navigo was exported in the form of UMD. And the way which was chosen to export Navigo to commonjs module loader is to replace the export object with the constructor function of Navigo.
Therefore, the author of @types/navigo have to export Navigo with export = Navigo, the syntax which was designed to import commonjs module in TypeScript.
That is why we can't import this package with modern ES6 syntax.

Any movement on this issue... I just started a new LitElement project in TypeScript and would like to use Navigo, but not being able to import it into my TypeScript file is a bit of a hindrance.

Hey @chrisalexander55, @youjenli and @milesje,
Navigo got rewritten in TypeScript and the current version 8.0.0 is in beta. Could be installed via npm install navigo@beta and the types are bundled inside the library. Everything with typescript should be ok if you use that version.

I know it's a major release so you may need to read the migration guide https://github.com/krasimir/navigo/blob/big-rewrite/CHANGELOG.md#migration-guide or the new documentation https://github.com/krasimir/navigo/blob/big-rewrite/DOCUMENTATION.md.


"unregister_synchronizer" method often breaks when client disconnects

When a peer disconnects, it attempts to RPC to other peers to unregister its own synchronizers, but often fails. As a result, the synchronizer maps of the remaining peers don't erase the disconnected peer's synchronizers, leading to memory leaks if left unchecked.
Steps to replicate

Run at least 2 instances of the demo.
Host a game on one instance, and connect using the other instance(s).
Close the client instance(s), leave the host instance running.
At least one of the instances (I presume the host?) will usually throw the "Attempt to call RPC with unknown peer ID" error and fail to unregister the synchronizers.

I'll need a little time to think this over. It was something I had observed once or twice, but felt it was benign enough to neglect. My rationale was that a handful of potential extra entries in a hashmap wasn't going to be enough of a problem in normal running cases to warrant a rework.
I think it could be relatively quick to fix it by listening for a peer disconnected signal and cleaning up the maps on that. The RPC signals are more intended for in-game comms rather than the entire client exiting.


added prime number

added prime number using C

Greeting Ishita15112001 ,
Please adding the "hacktoberfest-accepted" label to the PR.

Please merge my pull request.


Make the CachingHiveMetastore use the IMetaStoreClient  interface instead of directly calling the ThriftHiveMetastore client

Change the CachingHiveMetastore to use the IMetaStoreClient interface instead of directly calling the ThriftHiveMetastore client. This allows for the CachingHiveMetastore implementation to use other implementations of the IMetastoreClient interface without having to change any code
in the CachingHiveMetastore implementation.
Corporate CLA completed by Amazon.

Is this a feature request or something you plan to work on?

I sent the pr which you've seen.

I will send a new pr with the approach we discussed.

fixed https://github.com/facebook/presto/pull/3785


[MANOPD-81952] - use internal address if address is not defined

Description
We have optional field address for, but if it's actually undefined, the exception occurs.
Fixes # (issue)
Solution
If address is not defined, internal address is used instead of it.
*
How to apply
Provide steps how to apply on top previous Kubemarine version to execute on existing clusters

Any procedure without address field on some nodes in cluster.yaml

Test Cases
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
TestCase 1
Test Configuration:

Hardware:
OS:
Inventory:

Steps:

Results:

Before
After

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] Integration CI passed
[ ] Unit tests. If Yes list of new/changed tests with brief description
[ ] There is no merge conflicts

Unit tests
Indicate new or changed unit tests and what they do, if any.

@Imadzuma  pls also update our README example and remove extra parameters


Support different manifest files for different browsers

If you like this change, you can merge it now and add the Firefox manifest in another PR.
Let me know if there is more to different browsers than just different manifest files.


Inline unfold not working on Firefox

monaco-editor version: 0.18.1
Browser: Firefox 70.0.1
OS: MacOS 10.14.6
Steps or JS usage snippet reproducing the issue:
It can be reproduced in the playground: https://microsoft.github.io/monaco-editor/playground.html#creating-the-editor-hello-world

I can reproduce in Firefox at https://vscode-web-test-playground.azurewebsites.net/


Devices Disconnect within 30 seconds

Describe the bug
I connect to multiple devices using the code shown.
The devices connect and are to be seen via 'adb devices' command, but they all disconnect around 15-30 seconds. I am using the devicemonitor and tracking the disconnects.
Steps to reproduce the bug
Try the following code :
namespace TestDeviceMonitor
{
    internal class Program
    {
        static int count = 0;
        static readonly AdbClient adbClient = new();
        const string SUBNET = "192.168.1.";
        static void Main(string[] args)
        {

            StartServerResult startServerResult = AdbServer.Instance.StartServer("adb.exe", true);
            Console.WriteLine(startServerResult);
            Console.WriteLine($"Current subnet is : {SUBNET}");

            var x = adbClient.GetDevices();
            Console.WriteLine(x.Count());

            using DeviceMonitor deviceMonitor = new(new AdbSocket(new IPEndPoint(IPAddress.Loopback, AdbClient.AdbServerPort)));
            deviceMonitor.DeviceConnected += DeviceMonitor_DeviceConnected;
            deviceMonitor.DeviceDisconnected += DeviceMonitor_DeviceDisconnected;
            deviceMonitor.DeviceChanged += (sender, e) => Console.WriteLine($"Device state changed: {e.Device} {e.OldState} -> {e.NewState}");
            deviceMonitor.Start();

            ScanNetworkForDevices();

            Console.Write("Press any key to exit...\n");
            Console.ReadKey(true);
            //AdbServer.Instance.RestartServer();
        }

        private static async Task ScanNetworkForDevices()
        {
            for (int i = 2; i < 254; i++)
            {
                _ = adbClient.ConnectAsync($"{SUBNET}{i}");
                Console.WriteLine($"Scanned {i}");
            }
        }

        private static void DeviceMonitor_DeviceDisconnected(object? sender, DeviceDataEventArgs e)
        {
            Console.WriteLine($"{DateTime.Now} Device Disconnected");
            if (e.Device.State == DeviceState.Offline) { Console.WriteLine(count--); }
        }

        private static void DeviceMonitor_DeviceConnected(object? sender, DeviceDataEventArgs e)
        {
            Console.WriteLine($"{DateTime.Now} Device Connected");
            //if (e.Device.State == DeviceState.Online) Console.WriteLine(count++);
        }
    }
}

Expected behavior
The devices should stay connected unless the device is unplugged, loses network or is intentionally disconnected.
Screenshots

NuGet package version
3.3.13
.NET Platform
.NET 8
Platform type
Windows
System version
Windows 11 Home , 23H2 OS Version : 22631.3958
IDE
Visual Studio 2022-preview, Visual Studio 2022
Additional context
I am testing the DeviceMonitor feature using a simple console app.

I have no idea, because it should be adb problem. Is that auto disconnect when you using adb directly?

It works on my device.

deviceMonitor.DeviceConnected += (sender, e) => Console.WriteLine(e);
deviceMonitor.DeviceDisconnected += (sender, e) => Console.WriteLine(e);
deviceMonitor.DeviceChanged += (sender, e) => Console.WriteLine(e);


PAC no longer supported

Per Madhu, PAC files are no longer supported by MTR and will prevent enrollment into TAC.
Per PG, static proxy or no proxy are only two options if goal is to have MTR enrolled in TAC .
The part in this doc where we show customers how to configure MTR for PAC should be removed OR a disclaimer should be added stating that if PAC is used .. the MTR will fail to enroll in TAC and cannot be managed in TAC

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a711c07e-10b3-baf0-b92c-9dbcf6ab9474
Version Independent ID: 2038cd48-44b1-1ed1-6e50-48290eef5605
Content: Prepare your Environment - Microsoft Teams
Content Source: Teams/rooms/rooms-prep.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hello @jerieger I am looking into this

Hello @jerieger can you please detail if you refer to MTRoW or MTRoA or both? Thanks

These are MTR-W
Jeff Rieger
Support Escal Eng
Us-Css-Skype For Business
Customer Services and Support
Office: +1<PHONE_NUMBER>
<EMAIL_ADDRESS>[Microsoft Logo]
Team Manager | George Vordenbaum  | +1<PHONE_NUMBER> |<EMAIL_ADDRESS>If you have any feedback about my work, please let either me or my manager George know at<EMAIL_ADDRESS>From: Andres Mariano Gorzelany @.>
Sent: Wednesday, August 3, 2022 7:24 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Jeff Rieger @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] PAC no longer supported (Issue #9135)
Hello @jeriegerhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjerieger&data=05|01|jerieger%40microsoft.com|b954d67d03bf4e6563d108da754b1415|72f988bf86f141af91ab2d7cd011db47|1|0|637951262701432809|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=whtCH9kjI4bHEQiKtbW14vuNcsyPNUzetmcWearDsJg%3D&reserved=0 can you please detail if you refer to MTRoW or MTRoA or both? Thanks

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F9135%23issuecomment-1203879986&data=05|01|jerieger%40microsoft.com|b954d67d03bf4e6563d108da754b1415|72f988bf86f141af91ab2d7cd011db47|1|0|637951262701432809|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=dd2HfOBoPxwqYdYDLvSgYN7XCmyLRwiEjpBXxgwHhCQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUPX4H2XGT4ADLSOCZSGQETVXJQG5ANCNFSM542DLVBA&data=05|01|jerieger%40microsoft.com|b954d67d03bf4e6563d108da754b1415|72f988bf86f141af91ab2d7cd011db47|1|0|637951262701432809|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=um5gJNdEIt3Nj96b%2B%2Bk82u49VluR2N6V3ZAq0LIcEQc%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@jerieger Thanks, I am trying to confirm

@scanum Closing for now as I did not get this confirmed. In any case it can be re-opened.


esp-wifi: RFC Remove embedded-svc

We optionally implement the wifi trait (and accompanying types) from embedded-svc - is that useful to someone or is it just unnecessary burden?
Is anyone actually using it (for non-esoteric reasons)?

From our meeting, we decided to remove support for now. We can always re-add it, but right now we don't see the value as not many crates (any?) build on top of these traits.


DBZ-2318 add column check constraints and JSON validation check constraints to debezium-ddl-parser ANTLR v4 MySQL grammar

fixes https://issues.redhat.com/browse/DBZ-2318

@rk3rn3r Nice fix, I've not noticed the check contraint is also not supported. While at it could you please add the support for all JSON related functions?

@rk3rn3r Nice fix, I've not noticed the check contraint is also not supported. While at it could you please add the support for all JSON related functions?

@jpechane no, I don't think that's not neccessary. We only need support for that functions that are supported in DDL statements. I think that's only JSON_VALID for MariaDB and JSON_SCHEMA_VALID for MySQL. That's what I found out and what I did.

@rk3rn3r We are consuming upstream project so I think it is fair to add missing support even for functions we don't directly use right now as others can benefit for them - and it wouldn't make sense to add those functions upstream and diverge on them in our grammar.

Applied, thank @rk3rn3r

We only need support for that functions that are supported in DDL statements.

@rk3rn3r, the problem is that DDL can contain any kind of DML, too, e.g. in the declaration of a stored procedure. So we really need to be able to parse anything. So if there's something left, could you please log a follow-up Jira issue? Thanks!


sdk: python: Remove wrapping result object

Related:

#3555
#3692

Signed-off-by: Helder Correia

I just started looking at this.


Rename files to add extensions

I noticed the markdown file isn't rendering on Github because it has no file extension :)

I've tried to get more info on the conventions but never got any response. I don't think there's significant impact, so will close this/


Add RequestAuth type to replace Map.Entry usage.

Change
Added the concrete type RequestAuth to represent the request authentication header/info as an alternative to passing around a raw Map.Entry instance.
The new type presently implements Map.Entry itself to ease the change over from using that type.  This is temporary and should be removed by v8 (or a later major release).
Reasoning
The usage of Map.Entry instead of a new or alternative type for this is abusing a type internal to Map for reasons that are unrelated to the defined purpose of the type.
Additionally, there are few to no available standard library implementations of the Map.Entry interface that are not part of or included within a Map implementation (most of which are private or package-private), meaning consumers of this library will also need to rely on code from an additional library (FgpUtil) or implement Map.Entry themselves.
Impact on Library Consumers
While this is technically a "breaking change" the new type implements Map.Entry so most if not all consumers of this library will be unaffected by the update.   Consumers of this library should update their calls to UserProvider.getSubmittedAuth to declare the type RequestAuth instead of Map.Entry type as the new type RequestAuth will be updated in the future to no longer implement Map.Entry.

@ryanrdoherty

even though EDACommon does not depend on container core

I didn't realize EDA Common doesn't depend on this project.
Perhaps, since FgpUtil is a common dependency here, then we should use an FgpUtil tuple type instead of a new type in Container Core?
Frustrating that Java doesn't have any tuple types in the standard library.


Allow safetensors offload

This PR reworks a bit the internals of the offload hooks to allow for the case where the checkpoint is saved with safetensors. In this case, there is no need to have a separate save of the weight as a Numpy memory-mapped array, as we can directly access the weight using safe_open.
Goes along with https://github.com/huggingface/transformers/pull/20321

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Drowdown menu]

Sure! Here's a bug report template based on the information you provided:
Bug report
Current Behavior
When clicking on any dropdown menu within a page, the browser's vertical scroll bar is hidden.
Expected behavior
The vertical scroll bar should remain visible when a dropdown menu is clicked.
Reproducible example
You can reproduce the issue at radix document page Dropdown Menu

Hi! There is prop called modal on Root element, you can achieve desired behaviour by setting it as false

That is the correct intent.


Superset evaluation - SQLLite failure to refresh metadata

Make sure these boxes are checked before submitting your issue - thank you!

[Y ] I have checked the superset logs for python stacktraces and included it here as text if any
[ Y] I have reproduced the issue with at least the latest released version of superset
[ Y] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
latest - through pip install
Expected results
Actual results
Steps to reproduce
I'm running superset for evaluation. For the initial launch it worked when Druid was set up on my laptop.
I set up Druid to run on containers backed by postgres for metadata and eventually launched superset.
I configured the druid cluster and it seemed to connect to it however on refreshing the druid meta-data it failed with the following traces
2018-04-10 11:27:28,847:ERROR:root:(sqlite3.ProgrammingError) SQLite objects created in a thread can only be used in that same thread.The object was created in thread id<PHONE_NUMBER>91008 and this is thread id<PHONE_NUMBER>19872 [SQL: 'SELECT clusters.created_on AS clusters_created_on, clusters.changed_on AS clusters_changed_on, clusters.id AS clusters_id, clusters.verbose_name AS clusters_verbose_name, clusters.cluster_name AS clusters_cluster_name, clusters.coordinator_host AS clusters_coordinator_host, clusters.coordinator_port AS clusters_coordinator_port, clusters.coordinator_endpoint AS clusters_coordinator_endpoint, clusters.broker_host AS clusters_broker_host, clusters.broker_port AS clusters_broker_port, clusters.broker_endpoint AS clusters_broker_endpoint, clusters.metadata_last_refreshed AS clusters_metadata_last_refreshed, clusters.cache_timeout AS clusters_cache_timeout, clusters.created_by_fk AS clusters_created_by_fk, clusters.changed_by_fk AS clusters_changed_by_fk \nFROM clusters \nWHERE clusters.cluster_name = ?'] [parameters: [{'%(140403472682120 param)s': 'druid-cluster-local'}]] (Background on this error at: http://sqlalche.me/e/f405)
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/sqlalchemy/engine/base.py", line 1127, in _execute_context
    context = constructor(dialect, self, conn, *args)
  File "/usr/local/lib/python3.6/dist-packages/sqlalchemy/engine/default.py", line 637, in _init_compiled
    self.cursor = self.create_cursor()
  File "/usr/local/lib/python3.6/dist-packages/sqlalchemy/engine/default.py", line 952, in create_cursor
    return self._dbapi_connection.cursor()
  File "/usr/local/lib/python3.6/dist-packages/sqlalchemy/pool.py", line 970, in cursor
    return self.connection.cursor(*args, **kwargs)
sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread.The object was created in thread id<PHONE_NUMBER>91008 and this is thread id<PHONE_NUMBER>19872

I'd recommend to use MySQL or Postgres instead. You may want to try a single worker/thread gunicorn instance if using SQLLite.


BUG: Added checks for NaN in call of EngFormatter

[x] closes #11981
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

Closes #11981
Updated the v0.18.2 document
In the function __call__ of EngFormatter check if decimal input is NaN.

once you have made the changes and pushed, ping on green.

[Current coverage][cc-pull] is 84.14%

Merging [#13124][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

@@             master     #13124   diff @@
==========================================
  Files           137        137
  Lines         50287      50289     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          42312      42313     +1
- Misses         7975       7976     +1
  Partials          0          0

File ...das/tseries/index.py (not in diff) was modified. more

Misses +1
Partials 0
Hits -1

Powered by Codecov. Last updated by [43989fd...d7315dd][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/43989fd7cb9917e885c2b55a172c4f9f3838d59d...d7315dd64adfd577abe0dccf2f371aa2d5b6d80c
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13124?src=pr

@jreback the Travis-ci build job 19538.5 has failed for Python 3.5, as except with comma is not valid in Python 3. But, surprisingly the test have passed for Python 3.4.
File "/usr/share/google/boto/boto_plugins/compute_auth.py", line 64
except (urllib2.URLError, urllib2.HTTPError, IOError), e:

                                                     ^

SyntaxError: invalid syntax

thanks @yaduart

As I am a newbie here, I am not sure of the processes. It would help me understand how to close the pull request, if you could tell how you decided to close the pull request as the Travis-ci checks were were failing, or did you run them again, or was the Travis-ci bypassed.

@yaduart no, I merged it via https://github.com/pydata/pandas/commit/d0734ba4d0f4c228110dc3974943ce4ec2adeea4
it is a slightly edited commit. When I merged it closed the PR and the issue.
thanks for the contribution.

If I had closed it for another reason (e.g. not accepting) or something would always write something.

Why was the travis-ci check failing earlier?

unrelated, we picked up a broken boto version (not sure why it was released), and were importing it on main pandas import (which is wrong, but that's how it was).

Thanks for clarifying. Cheers


Adding gradle wrapper through distribution is now possible

Fixes #4490

By allowing only distributionUri OR version/distribution, we also no longer use gradle services to determine the version which could not be available on the distributionUrl
Follow up from

https://github.com/openrewrite/rewrite/pull/4445

Strange... this failing test succeeds locally 🤷♂

So the intent of the parameters ${version} and ${distribution} for the wrapper URI, was to make reasoning about the recipe a little easier when being used within an enterprise environment that does choose to install distributions locally. These parameters have always been meant to be previously known, exact versions and not allowing dynamic resolution as is the case with the default path against services.gradle.org. It's pretty equal though in just specifying the full wrapperUri as well.

I could always alter the validation to allow for fixed versions and distributions + do the replacements in distributionurl if that sounds better for you?
But at this moment it's using services.gradle for the resolution if mentioned.
I also believe the distributionurl is more important in deciding the impact than the fact if services.gradle is available or not. At our site we have access to services.gradle, but have custom wrappers in local repo.
It is impossible to get there with current implementation as we receive a version from gradle services repo. If you mention a url, you already know you want specific behaviour.

I don't think resolving the dynamic versions should be in scope right now. The reasons that it's been avoided so far as that each repository hosting tool has a different schema for versions, so it would be difficult to make a fully workable solution that covers all cases including within an environment that completely disallows access to services.gradle.org.
Personally, I don't see much of a different between the wrapperUri being fully defined versus the exact version parameterized replacements because they both are right there in the same spot and must be configured by the user at the time of defining the recipe. Maybe @timtebeek or @sambsnyd have some more opinions, but I've been more inclined to just use the wrapperUri as is with no replacements like you've done here in this PR.

The only slight concern I see is that with this change we completely disregard the checksum when using the wrapperUri. Then again I agree with @shanman190 that we shouldn't be looking at implementing full support for every hosting tool here.
I think we stand by the comment I left during my work on #4445, if the user specifies a wrapperUri we assume they know it's valid.

I think the checksum part is a non-issue because if the URL is anything except a services.gradle.org, it's most likely that the wrapper is being updated per some organization policy. At that point, the checksum would have been invalid anyway.
As @Jenson3210 was pointing out on the linked issue, in their case services.gradle.org is available, but they were also setting an internal wrapperUri. As a result, the custom wrapperUri wasn't being used.

@shanman190 , @Laurens-W I added the checksum property like you mentioned above.

Strange... this failing test succeeds locally 🤷♂ Would you have any idea @timtebeek ?

Interesting; I saw the following locally:

Run all tests the first time: UpdateGradleWrapperTest#servicesGradleOrgUnavailable fails
Run servicesGradleOrgUnavailable in isolation: test passes
Run all tests a second time: all tests pass
rm -rf ~/.rewrite/remote (via DEFAULT_ARTIFACT_CACHE)
goto 1.

Hope that's enough for you to have another go at fixing the test failure definitively.

Strange... this failing test succeeds locally 🤷♂ Would you have any idea @timtebeek ?

Interesting; I saw the following locally:

Run all tests the first time: UpdateGradleWrapperTest#servicesGradleOrgUnavailable fails
Run servicesGradleOrgUnavailable in isolation: test passes
Run all tests a second time: all tests pass
rm -rf ~/.rewrite/remote (via DEFAULT_ARTIFACT_CACHE)
goto 1.

I suspect it's to do with tests using overlapping remote files, and one filling/polluting the cache for another. Hope that's enough for you to have another go at fixing the test failure definitively.

Remote files are stored in ~/.rewrite/remote, try emptying that and running the tests again :)

Adapted the test with the following reasoning:
The addition of a wrapper downloads the necessary scripts/jar from the downloadURI. If that service is unavailable, it makes sense that the result is empty.
As that test before was only bumping/updating wrapper version in url, I added the wrapper files and expect that they will not be touched if downloaduri is not available. With this before state, it is better representing the current situation if the bat/sh/jar files are present already.

Looks good to me! I especially like the validate() change to clear out conditionals in getGradleWrapper(). Thanks for picking this up!
Since @shanman190 had some feedback earlier I'll leave a decision to merge up to him.

Now that all comments have been resolved. @shanman190, do you agree we can merge?

@Jenson3210, merged. Thanks for the help on this one!


fldigi: 3.23.15 -> 4.0.16

Semi-automatic update. These checks were done:

built on NixOS
ran /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin/fldigi --help got 0 exit code
ran /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin/fldigi --version and found version 4.0.16
ran /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin/flarq --help got 0 exit code
found 4.0.16 with grep in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16
found 4.0.16 in filename of file in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16

cc @relrod @ftrvxmtrx

@GrahamcOfBorg eval

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘fldigi-4.0.16’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/audio/fldigi/default.nix:18 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16
shrinking /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin/flarq
shrinking /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin/fldigi
gzipping man pages under /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16/bin
patching script interpreter paths in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16
checking for references to /tmp/nix-build-fldigi-4.0.16.drv-0 in /nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16...
/nix/store/vxx260nm7dk471pgh1090pp9xlm53hbs-fldigi-4.0.16

Success on aarch64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16
shrinking /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16/bin/flarq
shrinking /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16/bin/fldigi
gzipping man pages under /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16/bin
patching script interpreter paths in /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16
checking for references to /build in /nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16...
/nix/store/v9878cs8i692b0rbsr8yp0lcxrk0v5mc-fldigi-4.0.16


Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #152 (cecfa5f) into feature/803-policy-store (1c36d2a) will increase coverage by 0.05%.
The diff coverage is 90.90%.

:exclamation: Current head cecfa5f differs from pull request most recent head f45ab36. Consider uploading reports for the commit f45ab36 to get more accurate results

@@                      Coverage Diff                       @@
##             feature/803-policy-store     #152      +/-   ##
==============================================================
+ Coverage                       59.87%   59.92%   +0.05%
- Complexity                       2248     2257       +9
==============================================================
  Files                             604      605       +1
  Lines                           13041    13063      +22
  Branches                          909      912       +3
==============================================================
+ Hits                             7808     7828      +20
- Misses                           4808     4809       +1
- Partials                          425      426       +1

Impacted Files
Coverage Δ

...ector/policy/store/memory/InMemoryPolicyStore.java
90.90% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c36d2a...f45ab36. Read the comment docs.

Added few comments.


Front matter missing in several new docs

Expected Behavior
All pipeline documentation pages are shown in the navigation once rendered on tekton.dev/docs
Actual Behavior
Many markdown files have no front matter specified, which results in links with no text:

Note the link to the bundle resolver when I hover with the mouse over the text-less links
Steps to Reproduce the Problem

Bundle resolver docs: https://raw.githubusercontent.com/tektoncd/pipeline/main/docs/bundle-resolver.md
Task docs: https://raw.githubusercontent.com/tektoncd/pipeline/main/docs/tasks.md

Notice the front-matter in (2), which is missing in (1).
Additional Info

Tekton Pipeline version: v0.41.0

/kind documentation

/cc @abayer
Once this is fixed on main, we need to cherry-pick to the relevant branches to fix the website

Complete list of path on the website with no link title:
/docs/pipelines/bundle-resolver/
/docs/pipelines/cluster-resolver/
/docs/pipelines/git-resolver/
/docs/pipelines/how-to-write-a-resolver/
/docs/pipelines/hub-resolver/
/docs/pipelines/pipelineresources/
/docs/pipelines/resolution-getting-started/
/docs/pipelines/resolution/
/docs/pipelines/resolver-reference/
/docs/pipelines/trusted-resources/
/docs/pipelines/windows/

https://docs.google.com/spreadsheets/d/1HknnR5FDSPgLJlI7kbtPsUlvL1nGvYeIZA7vKti05os/edit?usp=sharing

Is there a way to have a further level of nesting in the sidebar? It seems silly to put the 8 resolver-related links all directly under Tasks and Pipelines, but I don't have any idea how the site gets generated and therefore don't know how to do that, or if it's even possible. =)

Yeah, I think we need further nesting, and not only for the resolvers.
I prepared [this table] as a basis for discussing this exactly - once we agree on the nesting we want we can look for a technical solution on how to achieve it.

You forgot the link for [this table]. =)

https://docs.google.com/spreadsheets/d/1HknnR5FDSPgLJlI7kbtPsUlvL1nGvYeIZA7vKti05os/edit?usp=sharing

I think we should agree on a structure and publish it in the dev docs of Tekton pipeline as a reference for future docs. @geriom @tektoncd/core-maintainers

Totally agree. This seems like a great topic to discuss in the docs team meeting. Adding it to the agenda.

I going to work on a couple of proposals to improve the way the information is display and share them in the pipelines meeting to discuss.


Bug[rgsw]: panic: runtime error when encrypting and rgsw.Ciphertext with an rlwe.PublicKey

What version of Lattigo are you using?
v5@latest
Does this issue persist with the latest release?
Yes
What were you trying to do?
Encrypt an rgsw.Ciphertext using the public key
What actually happened?
panic: runtime error: invalid memory address or nil pointer dereference
Reproducibility
package main

import (
	"github.com/tuneinsight/lattigo/v5/core/rgsw"
	"github.com/tuneinsight/lattigo/v5/core/rlwe"
)

func main() {
	params, err := rlwe.NewParametersFromLiteral(rlwe.ParametersLiteral{
		LogN:    11,
		LogQ:    []int{54},
		NTTFlag: true,
	})

	if err != nil {
		panic(err)
	}

	_, pk := rlwe.NewKeyGenerator(params).GenKeyPairNew()

	enc := rgsw.NewEncryptor(params, pk)

	ct := rgsw.NewCiphertext(params, params.MaxLevelQ(), params.MaxLevelP(), 7)
	pt := rlwe.NewPlaintext(params, ct.LevelQ())
	if err = enc.Encrypt(pt, ct); err != nil {
		panic(err)
	}
}

Hey, to my knowledge RGSW uses the RingQP under the hood for the gadget products. Not specifying auxiliary primes P will result in an uninitialized RingP hence the nil pointer exception.
Maybe we could disallow parameters without P primes for RGSW?

RingQP should still work even without P, as before doing operations it checks if there is or not a RingP. In practice RGSW is mostly used in contexts where the parameters are too small to accommodate for an auxiliary modulus P, such as blind rotations.


libgpgerror: 1.34 -> 1.35

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libgpg-error/versions.
meta.description for libgpgerror is: '"A small library that defines common error values for all GnuPG components"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.35 with grep in /nix/store/ypxn3807z10r69pg0djr9dh18gjp5zpw-libgpg-error-1.35

directory tree listing: https://gist.github.com/35d3c0a68f240b8f2ad8899c2d9a8e12

du listing: https://gist.github.com/af8059d5b944e69af3300c9c5ddfda66

Rebuild report (if merged into master) (click to expand)

19879 total rebuild path(s)
7394 package rebuild(s)
7386 x86_64-linux rebuild(s)
6463 i686-linux rebuild(s)
161 x86_64-darwin rebuild(s)
5869 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
AgdaSheaves
AgdaStdlib
DisnixWebService
EmptyEpsilon
MMA
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_gfx
SDL_image
SDL_mixer
SDL_net
SDL_sound
SDL_stretch
SDL_ttf
TotalParserCombinators
_20kly
_90secondportraits
a2jmidid
aacskeys
abcde
abcl
abiword
abootimg
accountsservice
acgtk
acoustidFingerprinter
acpilight
acsccid
adapta-gtk-theme
adlplug
adobe-reader
adom
adoptopenjdk-bin
adoptopenjdk-hotspot-bin-11
adoptopenjdk-jre-bin
adoptopenjdk-jre-hotspot-bin-11
adoptopenjdk-jre-openj9-bin-11
adoptopenjdk-openj9-bin-11
adwaita-qt
aegisub
aeolus
aesop
afew
afpfs-ng

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ypxn3807z10r69pg0djr9dh18gjp5zpw-libgpg-error-1.35 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libgpgerror https://github.com/r-ryantm/nixpkgs/archive/c24263ceb07f31f8b86b78aced0c7690a237dbff.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ypxn3807z10r69pg0djr9dh18gjp5zpw-libgpg-error-1.35
ls -la /nix/store/ypxn3807z10r69pg0djr9dh18gjp5zpw-libgpg-error-1.35/bin

cc @fuuzetsu @vrthra for testing.

superseded, 1.36 is in staging now.


DX: update dev tools

Updates extracted from https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5775 that are ready to be merged now.

Coverage remained the same at 92.304% when pulling fc1733811dc0e63c542af7b7f0dc864953a050af on kubawerlos:update-dev-tools into 1b656b57d4ab35c80d5c5c3b60b1e360ba713018 on FriendsOfPHP:3.0.

Thank you @kubawerlos.


altcoins.masari: <IP_ADDRESS> -> latest-2022-10-09

Description of changes
Bumps the program source, and makes it use boost174 due to
https://github.com/masari-project/masari/pull/191

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


A self-regulated VTherm over_climate doesn't follow the underlying temperature changes

Discussed in https://github.com/jmcollin78/versatile_thermostat/discussions/472

Originally posted by 2fst4u June 16, 2024
Hi, so far this is awesome, it's just what I'm looking for.
I'm a bit confused about how the thermostat behaves when using it with another climate entity (in my case a heat pump).
When I turn off the versatile thermostat, my heat pump also turns off which I would expect. When I turn on the versatile thermostat, my heat pump turns on too. Great!
But when both are off and I go to turn on the heat pump manually, either in home assistant, or from its own app, or with the physical remote, then the versatile thermostat also turns on and starts interfering with the settings. Is there any way to prevent this? If the heat pump is manually turned on I'd like the versatile thermostat to remain off so that the manual settings can be used. The reason for this is not everyone in my household has the need or desire to use home assistant to control the settings and if they manually turn on the heat pump then they'd prefer to just have that manual setting remain what it is set to.
Is this possible at all?

You beat me to it haha. Let me know if there is anything you need from me

I've made some tests yesterday and I can confirm there is a bug. Thanks for your report @2fst4u !

No problem it's good to know I wasn't going crazy!
If it helps at all, one minor correction: when changing the underlying climate temperature, vtherm does actually go into manual mode. It just doesn't follow the temperature set is all.

Hello, I come back on this issue, look at the logs and see what happens:
if your VTherm is regulated (have self-regulation configured), it will not follow manual configuration done directly on the underlying device. This is to avoid loop I guess. Self-regulation sends target temperature to underlying with an offset (that is how VTherm does the regulation), so the target temperature of the underlying is not the desired temperature of the user. I guess this is why I have done this.
See the piece of code, this is explicitly written:
if (
                # we do not change target temperature on regulated VTherm
                not self.is_regulated                                   <----------- here
                and new_state.attributes
                and (new_target_temp := new_state.attributes.get("temperature"))
                and new_target_temp != self.target_temperature
            ):
                _LOGGER.info(
                    "%s - Target temp in underlying have change to %s",
                    self,
                    new_target_temp,
                )
                await self.async_set_temperature(temperature=new_target_temp)

But when thinking about it, I wonder if it is a good idea and I don't remember when I add this line.
So, the first question is: do you have configured the self-regulation on your VTHerm ? You can see that in Development Tools/States

I do have self regulation configured, yes. My hope is that using the physical remote will cause vtherm to use that new value as the vtherm temperature setting.

Yes I understand, that was also what I expect when I do some test and was surprise it was not the case.
I will try to remove this test and do some test on my env. If I do a beta with this change, can you give it a try ?

Yea sure. Would it be pushed as a beta version within HACS? I can do that definitely.

I do archeology search, and this line have not been added because of an issue but is there from the beginning of self regulation.
I will try without the line.

ok, I have done some test, and the behavior is very bad. Within minute I got a divergence in temperature setpoint.
With regulation VTherm sends target+offset, the underlying apply it. At the first change of the underlying (vtherm receive a notification like Underlying climate climate.underlying_thermostat2 have changed), the target+offset is set as target in VTherm, which apply the offset another time and so on.
So that is why a regulated over_climate VTherm cannot follow the underlying temperature change.

So I will mark this issue as 'Won't fix' but I will add explicit log explaining why temperature change is not taken into account.
Anyway thank you for your report.

Finally I found something which seems to work fine. If you can give it a try: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.3.4.beta5
During your test, remember that you should wait between the last modification sent by Vtherm and a manual action on the underlying device, else it will be ignored.

I'm just out of the country at the moment so I'll have to try when I'm home in a couple of weeks and I'll let you know. Thanks!
-------- Original Message --------
On 13/10/24 17:33, Jean-Marc Collin  wrote:

Finally I found something which seems to work fine. If you can give it a try: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.3.4.beta5
During your test, remember that you should wait between the last modification sent by Vtherm and a manual action on the underlying device, else it will be ignored.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

All my tests are ok now. I will release soon.

https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.3.4


feat: summary email for multiple addresses

This PR show all proposals for all the addresses related to the same email address in the same summary email.

Got this error when I run the tests for some reason

Got this error when I run the tests for some reason

Even with yarn test

tests seems to work on github actions
https://github.com/snapshot-labs/envelop/actions/runs/4467434150/jobs/7846889721?pr=29#step:8:1

@wa0x6e Nvm it works, it was picking a file I had in local


-bash: fusermount: command not found

[root@server ~]# fusermount -u /backup/restore-mount
-bash: fusermount: command not found
Any ideas?
Thank you

install the "fuse" package.


Parsing failed

The plugin doesn't work for at all. For all HTML is shows Parsing failed error. Even for such a simple ones:

On the screenshot I can see that you're trying to run it without selecting any HTML code. It won't work this way, it operates on the current selection.
I agree that it was maybe not explained well enough in the readme.

Does it only work on classes not id tags? am i missing something?

@kaztraz it does seem to be that way, I just checked why it was failing to parse only one element with an ID specified.


Mojo Upload

Hi All,
I tried to read CSV file data in server using Mojo Upload package. But I faced field split issue. Then I tried to implement Text::CSV but I can't read file handle from Mojo Upload.
Can any one help me to resolve my problem.
Thanks,
Vijay

Please use one of our official channels for support requests. http://mojolicious.org/perldoc#SUPPORT


Downgrade some common warnings to info

Reduces stderr spam when running tests with DXVK_LOG_LEVEL=warn.

May want to do this for D3D11 too?


FancyZones fails when the web video is full screen

Microsoft PowerToys version
0.49.1
Running as admin

[X] Yes

Area(s) with issue?
FancyZones Editor
Steps to reproduce
use a 49-inch monitor. I use FancyZones to divide the screen into two areas. When the web video in one area is full screen, it will take up the entire screen instead of filling the area where it is.
✔ Expected Behavior
The web video is displayed in full screen in the divided area
❌ Actual Behavior
Web video full-screen mode covers the entire screen
Other Software
No response

/dup #279

FYI: this isn't actually a bug, Window snapping acts the same way


no_proxy variable requires full domain names when multiple are specified

Problem
We have a company network that mirrors the rust registry internally (on artifactory). Also a company proxy is in place for connections outside of the company network. Thus this proxy is configured in all the common places.
The cargo mirror is available on artifactory.company.net
The proxy is defined via common variables, e.g. https_proxy.
We noticed that the no_proxy is only respected in certain situations:
# Specifying a single generic  exclude on the domain works
export no_proxy=".company.net"

# Specifying multiple generic domain excludes do not work
export no_proxy=".company.net,.company.com"

# When specifying multiple generic domain excludes and a full domain name exclude for the server in question also works
export no_proxy=".company.net,.company.com,artifactory.company.net"

In case of the non-working option we're stuck with errors like this:
$ cargo build
    Updating `artifactory` index
warning: spurious network error (2 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 502 from proxy after CONNECT)
warning: spurious network error (1 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 502 from proxy after CONNECT)
error: failed to get `axum` as a dependency of package `foo v0.1.0 (/home/mdegel/git/rust-cargo)`

Caused by:
  failed to query replaced source registry `crates-io`

Caused by:
  download of config.json failed

Caused by:
  failed to download from `https://artifactory.company.net/artifactory/api/cargo/crates.io-cargo-remote/index/config.json`

Caused by:
  [56] Failure when receiving data from the peer (Received HTTP code 502 from proxy after CONNECT)

With specifying the domain name completely artifactory.company.net vs .company.net we have a solution, but it's unclear to us, why this behavior differs from other tools.
Steps
No response
Possible Solution(s)
No response
Notes
Also we're using the nightly toolchain with sparse-registry.
Version
cargo 1.67.0-nightly (e027c4b5d 2022-11-25)
release: 1.67.0-nightly
commit-hash: e027c4b5d25af2119b1956fac42863b9b3242744
commit-date: 2022-11-25
host: x86_64-unknown-linux-gnu
libgit2: 1.5.0 (sys:0.15.0 vendored)
libcurl: 7.86.0-DEV (sys:0.4.59+curl-7.86.0 vendored ssl:OpenSSL/1.1.1q)
os: Ubuntu 20.04 (focal) [64-bit]

I tried a bit more and found out that it has nothing to do with the full domain name. As soon as NO_PROXY contains more than one (comma-separated) entry, only the last one seems to be taken into account.

@jasal82 This might play into it. I checked and figured out, that either the last one, or a FQDN works:
# Specifying the matching domain last works
export no_proxy=".company.com,.company.net"

# But specifying the FQDN anywhere, works too
export no_proxy=".company.net,artifactory.company.net,.company.com"

I believe this may have been a regression in libcurl (see https://github.com/curl/curl/issues/9884). A new version is scheduled to come out in a few weeks, so I think this will need to wait for that.

We've bumped curl from 7.86 to 8.0 in https://github.com/rust-lang/cargo/pull/11871. Could you try out the current nightly channel, or after 1.69 got released try beta channel to help us verify the behavior? Thanks!

Hi, @mdegel. We've bumped curl from 7.86 to 8.0 in https://github.com/rust-lang/cargo/pull/11871. Could you try out the current nightly channel, or after 1.69 got released try beta channel to help us verify the behavior? Thanks!

@weihanglo I'm not OP, but I also previously ran into this issue, and it seems to be fixed on nightly!
tested nightly: info: latest update on 2023-04-19, rust version 1.71.0-nightly (c609da59d 2023-04-18)
output on nightly (exit code 0):
$ cargo update
Updating `mirror` index

Output on stable:
    Updating `mirror` index
warning: spurious network error (2 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 504 from proxy after CONNECT); class=Net (12)
warning: spurious network error (1 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 504 from proxy after CONNECT); class=Net (12)
)
error: failed to get `xxx` as a dependency of package `xxx v0.1.0 (/xxxx)`

Caused by:
  failed to load source for dependency `xxx`

Caused by:
  Unable to update registry `crates-io`

Caused by:
  failed to update replaced source registry `crates-io`

Caused by:
  failed to fetch `https://xxx.yyyy.zzz.com/aaa/crates.io-index/`

Caused by:
  network failure seems to have happened
  if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  [56] Failure when receiving data from the peer (Received HTTP code 504 from proxy after CONNECT); class=Net (12)

Thank you so much for the feedback! Since it is verified that the bug no longer exists, I am going to close this as resolved. Thank you all!


Removed extra closing braces to avoid C++ compiler error

When using the library with C++ code the build process fails due to an extra closing brace. This PR removes this brace.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@danielschick, thanks for the PR. I can confirm this issue but it was fixed in my current update branch. I will still try to merge your MR and rebase.


Revert "per-node configuration overrides" pull request

Reverts https://github.com/cilium/cilium/pull/22163. cc @squeed
This pull request is currently causing the L4LB workflow to fail because the new cilium build-config command expects a connection to kube-apiserver, which we don't have in the standalone load balancer.
Passing workflow run: https://github.com/cilium/cilium/actions/runs/3652797608.

Sorry folks, I thought that https://github.com/cilium/cilium/pull/22163 had already run CI based on the recent comments, but I didn't double-check. Thanks @pchaigno for fixing this.


RabbitMQ Queues grow endlessly when running RabbitMQ in HA Mode

Describe the bug
By default Lagoon Core is deployed with a broker that has 3 rabbitmq nodes, this seems to create some issues with the GraphQL subscriptions that are used to update the UI in realtime.
It seems that the queues are not correctly removed and the amount of queues goes to around 3000, which then the rabbitmq channels go to 5000+ at which point rabbitmq blocks new requests. If this happens we have errors like
[lagoon-core-api-5f589fb46f-hnb92] [2021-06-30 16:07:33] [pubsub-error]: Error: No channels left to allocate
[lagoon-core-api-5f589fb46f-hnb92] [2021-06-30 16:07:33] [pubsub-error]: Error: No channels left to allocate
[lagoon-core-api-5f589fb46f-hnb92] [2021-06-30 16:07:33] [error]: uncaughtException: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".
[lagoon-core-api-5f589fb46f-hnb92] UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".
[lagoon-core-api-5f589fb46f-hnb92] [2021-06-30 16:07:33] [error]: uncaughtException: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".
[lagoon-core-api-5f589fb46f-hnb92] UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".
[lagoon-core-api-5f589fb46f-hnb92] [winston] Unknown logger level: error
[lagoon-core-api-5f589fb46f-hnb92] [2021-06-30 16:07:33] [pubsub-error]: uncaughtException: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".
[lagoon-core-api-5f589fb46f-hnb92] UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "5325".

Not sure if the UnhandledPromiseRejection is connected to the Error: No channels left to allocate but it's probably likely.
As soon as we change the rabbitmq to a single node, the system seems to work correctly: queues are not growing that crazy.

Related https://github.com/uselagoon/lagoon/issues/1344

We no longer run RabbitMQ in HA mode, but reopening #1344 to address subscription, which I've reopened


[xc7] Fixes for SRL and LUT-RAM

These fixes were identified via fasm2v differences between VPR and Vivado or errors during Vivado.

I've identified a bug with the RAM32M/RAM64M fasm2v implementation, I'm working on testing a fix.

Fix implemented for DI1 mux.

LGTM. Can you just post here a short info what problems this PR does fix?

Update scaleable proc template to route clock to LUT-RAM.  This is required because of what Vivado does with clocks set to 0.
Implemented the full DI1 mux for LUT-RAMs.
Implemented RAM32M and RAM64M in fasm2m
Added RAM32X1D test
Fixed RAM32M and RAM64M LUT-RAM tests (they were failing)
Fixed 32-bit LUT-RAM initialization
Added pack pattern for SRL x2, x3 and x4 chains.  This is required because of how Vivado implements SRL32 packing.
Fixed bug in srl32_chain where the tail of the SRL chain was unused and being discarded because the SRL address was set to 1 (rather than len-1).


Split response structs into separate crate?

What do you guys think about splitting all of the response structs (e.g., User, Repo, or Pull) into a separate crate? Such a crate would only implement (de)serialization. This would allow more sharing among other crates and can be tested separately.
I have a bunch of structs for the Events API that I plan on open-sourcing soon that could go into it.
I can get this going. Just wanted to know if there is interest (or if this has already been done).

@jasonwhite I'd be open to something like that.

I'll get this started. I'll post updates here as I have them. Closing for now since this isn't an actionable issue for hubcaps yet.

Here's a first pass: https://github.com/jasonwhite/github-types


Yan 937 update nifty

This change updates to the master branch of ska-gridder-nifty-cuda and generic components NiftyGridderApp and NiftyDegridderApp.
Worth also noting that with the runtime compilation the cuda sdk version can't exceed the nvidia driver cuda version reported by nvidia-smi (a little problematic on archlinux but can be worked around by installing a 2nd sdk or building from a docker container, but be aware the generated python linkable .so file is not backwards compatible)

Codecov Report

Merging #6 (7bce5db) into main (d8ee412) will increase coverage by 9.48%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   33.60%   43.08%   +9.48%
==========================================
  Files           3        3
  Lines         122      123       +1
==========================================
+ Hits           41       53      +12
+ Misses         81       70      -11

Impacted Files
Coverage Δ

dlg_nifty_components/cuda_gridder.py
2.81% <10.00%> (+1.38%)
:arrow_up:

dlg_nifty_components/cpu_gridder.py
100.00% <100.00%> (+24.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ee412...7bce5db. Read the comment docs.

@calgray,
The point to keep in mind is that the cuda version on the deployment or CI platform is the one that matters and that when relying on more recent version on the development platform this needs following up by a request to upgrade the SKA host platform.

Since the linting output appears to have nothing of significance I'm happy with it.

Thanks.


Windows 11

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd2798f8-c5c1-f42d-569c-a4dcde7431f6
Version Independent ID: 1b56cb9a-6513-3235-4922-45291ec057cc
Content: Create a deployment plan - Windows Deployment
Content Source: windows/deployment/update/create-deployment-plan.md
Product: w10
Technology: windows
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@e0i , there is no proper feedback so close this PR #10221 immediately


RTL Integration

set scrollbar position on left side with isRTL boolean properties

@malte-wessel any chance to get this reviewed and integrated?

Maybe a combination with #88?

I would be so happy if this gets merged :)

Hey saeed rahimi autoHeight props not working properly in Rtl in your merge changes can you please resolve the issue I want to implement urgently in the project  thanks


Host D9 firmware somewhere other than Google

We currently link to D9 firmware hosted by Google in two places:
https://github.com/decred/dcrpool/blob/f818a93af7bb036c096966e6111a386e55fb49fa/gui/assets/templates/index.html#L59-L60
https://github.com/decred/dcrpool/blob/f818a93af7bb036c096966e6111a386e55fb49fa/README.md#L10
It would be nice if we could host this somewhere other than Google.
Perhaps we could keep it in this repo and link to it here, or perhaps it could even be part of dcrpool so web visitors can download it without even leaving the site? Maybe it could be hosted decred.org?

Reopening as the link in index.html has not been updated


[BUG] Filebeat multiline support - truncated single quotes in the regular expression pattern

Describe the bug
Epiphany truncates single quotes from the regular expression pattern for multiline support, which can lead to incorrect log aggregation.
To Reproduce
Steps to reproduce the bug:

Deploy a new cluster from develop branch with the configuration given below: epicli apply -f test.yml

Config files
---
kind: configuration/filebeat
title: Filebeat
name: default
provider: azure
specification:
  filebeat_version: "7.8.1"
  postgresql_input:
    multiline:
      pattern: '^\d{4}-\d{2}-\d{2} '
      negate: true
      match: after
  docker_input:
    multiline:
      pattern: '([12]\d{3}[- \/.](0[1-9]|1[0-2])[- \/.](0[1-9]|[12]\d|3[01]))|(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.]\d\d'
      negate: true
      match: after
  common_input:
    multiline:
      pattern: '^\d{4}-\d{2}-\d{2}'
      negate: true
      match: after

Expected behavior
The file /etc/filebeat/filebeat.yml contains a valid pattern, exactly as defined in the configuration.
Actual behavior
There are truncated single quotes in the manifest file for docker and common input:
---
kind: configuration/filebeat
title: Filebeat
name: default
specification:
  filebeat_version: 7.8.1
  postgresql_input:
    multiline:
      pattern: '^\d{4}-\d{2}-\d{2} '
      negate: true
      match: after
  docker_input:
    multiline:
      pattern: ([12]\d{3}[- \/.](0[1-9]|1[0-2])[- \/.](0[1-9]|[12]\d|3[01]))|(0[1-9]|1[012])[-
        \/.](0[1-9]|[12][0-9]|3[01])[- \/.]\d\d
      negate: true
      match: after
  common_input:
    multiline:
      pattern: ^\d{4}-\d{2}-\d{2}
      negate: true
      match: after
version: 0.7.1
provider: azure

There are no single quotes at all in /etc/filebeat/filebeat.yml.
# -------------------------- PostgreSQL input --------------------------

# Filebeat postgresql module doesn't support custom log_line_prefix (without patching), see https://discuss.elastic.co/t/filebeats-with-postgresql-module-custom-log-line-prefix/204457
# Dedicated configuration to handle log messages spanning multiple lines.

- type: log
  enabled: true
  paths:
    - /var/log/postgresql/*.log*
  exclude_files: [".gz$"]
  multiline:
    pattern: ^\d{4}-\d{2}-\d{2}
    negate: True
    match: after

OS (please complete the following information):

OS: [all]

Cloud Environment (please complete the following information):

Cloud Provider [all]

The documentation shows the correct configuration of the filebeat.yml file.

Fix tested, single quotes are preserved. The default configuration (specification.postgresql_input) works fine.
I recommend adding schema validation for configuration/filebeat kind in the future to ensure multiline.pattern is always quoted, like:
multiline:
  type: object
  properties:
    pattern:
      type: string
      pattern: "^'.+'$"


DTS: Intel ioapic/mvic and gpio, uart, rtc...

A PR that enables a bit more the use of DTS for Intel SoCs as well as the related drivers such as uart ns16550 and qmsi gpio/rtc/uart ones
Note that only the 18 last patches are new, all the first ones are from PR #6406

@erwango I removed you as a reviewer, it automatically added you because of the patches from PR #6406 which is touching some Kconfig stuff around stm32.

Codecov Report

Merging #6464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6464   +/-   ##
=======================================
  Coverage   53.16%   53.16%
=======================================
  Files         431      431
  Lines       41087    41087
  Branches     7900     7900
=======================================
  Hits        21843    21843
  Misses      16037    16037
  Partials     3207     3207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4e987...3e59376. Read the comment docs.

@galak as @andrewboie mentioned here https://github.com/zephyrproject-rtos/zephyr/pull/6406#discussion_r172347803
Check include/arch/x86/arch.h

@galak as @andrewboie mentioned here #6406 (comment)
Check include/arch/x86/arch.h

Based on include/arch/x86/arch.h - it seems as if mvic doesn't support priority, trying to understand the comments about how this work for ioapic.

Even though mvic seems to have hard-coded interrupt priorities, tightly related to the interrupt vectors, the priority is still inserted into the IDT, same core interrupt handling, same gen_idt tool used.
Does that mean mvic is handled the same way as ioapic @andrewboie ? Or is the priority in the IDT silently ignored in mvic case?

@andrewboie any comment on this:

Even though mvic seems to have hard-coded interrupt priorities, tightly related to the interrupt vectors, the priority is still inserted into the IDT, same core interrupt handling, same gen_idt tool used.
Does that mean mvic is handled the same way as ioapic @andrewboie ? Or is the priority in the IDT silently ignored in mvic case?

@andrewboie we really need your input here :)

interrupt vectors in the mvic are fixed and AFAIK you can't program them.

@nashif Sure but to keep things consistent within all i2c drivers and dts files, I needed no do these changes (so instead of a hard-coded value in driver, it's provided by dts from soc's dtsi). Now the issue is just about mvic priority.

On MVIC, it is basically a reduced feature set IOAPIC. IDT Vector assignments are fixed, they are just the IRQ line number + 32. So any priority value provided is just ignored. The only flexibility the OS has wrt priorities is to select a free vector for the timer interrupt (by setting its IRQ line in a register), and hence the priority of the timer. Everything else is graven in stone.

So all of that means that MVIC doesn't support priority and thus shouldn't be in the device tree for MVIC or MVIC related interrupts.


Ensure Screen Readers Read Notebook Expand/Collapse Button Names

This hopefully addresses bug #7624. Before the fix, no screen readers would read anything when tabbing to the expand/collapse button in the notebook.
This component is defined as a button in the component html. If anyone feels strongly that we should be defining a couple of properties in the *component.ts and referencing those in the *.html file, more than happy to make that change.
After:

just realized there are actually 2 buttons behind the scene, I am not sure how the focus behavior will be when you press enter key on it. it would be nice to use just one button.

Yeah - having one button here would be better. I'd also prefer you add the attributes to the HTML directly - that's what we've been doing so far and it's good to be able to keep things consistent with the other components (and makes it easier to see from the markup directly what we're setting on it)
I'm assuming you're using title on purpose because you want to have the text displayed on mouseover - is that correct?

Thanks, everyone. Filed #8634 to track rewriting this component to have one button, so i'll keep the scope of these changes small.


PUB-933 Navigation bar not displayed on the POST requests

JIRA link
https://tools.hmcts.net/jira/browse/PUB-933
Change description
added isAuthenticated context to the POST pages as only GET request were triggering globalAuthGiver function
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Merged in as ticket has been moved to signed off already


[FEATURE] Individual context menu for MultiViewerEditorPart #333

[DESC.] Enabling individual context menu for each editors in MultiViewerEditorPart.

I don't understand why some files are entirely changed.
It's hard to see the net changes.

I merged your commit by myself because of some files (Part, EditorPart,...etc) are entirely changed.
Thanks.


add codecov badge

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0f0f1b4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   77.48%
=========================================
  Files             ?        2
  Lines             ?      151
  Branches          ?        0
=========================================
  Hits              ?      117
  Misses            ?       17
  Partials          ?       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0f1b4...f9b76ea. Read the comment docs.