install-git.sh unattended install fails

Description
When running install-git.sh in a headless session, a prompt is shown that requires user interaction in order to continue.
Platforms affected

[X] Azure DevOps
[X] GitHub Actions - Standard Runners
[X] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Current main branch
Is it regression?
no
Expected behavior
Git setup should be unattended
Actual behavior
There is no -y flag in install-git.sh to remove the source repo. This causes a prompt to be shown and the install does not continue.
Repro steps
Run images/ubuntu/scripts/build/install-git.sh the script halts on line #27.
Problematic line:
add-apt-repository --remove $GIT_REPO

Proposed solution:
add-apt-repository --remove $GIT_REPO -y

Hi @Layer8Err , Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating.

While running as a user with root access on Ubuntu:
cd /runner-images/images/ubuntu/scripts/build
sudo bash ./install-git.sh

When the script reaches line 27 to run the following command:
add-apt-repository --remove $GIT_REPO

The following output is shown:
root@lp-35539:/home/ubuntu# add-apt-repository --remove $GIT_REPO
PPA publishes dbgsym, you may need to include 'main/debug' component
Repository: 'Types: deb
URIs: https://ppa.launchpadcontent.net/git-core/ppa/ubuntu/
Suites: noble
Components: main
'
Description:
The most current stable version of Git for Ubuntu.

For release candidates, go to https://launchpad.net/~git-core/+archive/candidate .
More info: https://launchpad.net/~git-core/+archive/ubuntu/ppa
Removing repository.
Press [ENTER] to continue or Ctrl-c to cancel.

The process hangs until user input is provided. Setting export DEBIAN_FRONTEND=noninteractive has no effect and the script still hangs. Adding the -y flag prevents this script from being stuck waiting for user input.

Please run the bash script in an ubuntu shell to see the issue. Tests pass currently because git is already installed on ubuntu. Have you run the script from a shell environment?

Command run
# Run script with env variables
sudo sh -c "HELPER_SCRIPTS=$HELPERSCRIPTFOLDER INSTALLER_SCRIPT_FOLDER=$INSTALLERSCRIPTFOLDER DEBIAN_FRONTEND=noninteractive $SCRIPTSROOT/build/install-git.sh"

Full command output
PPA publishes dbgsym, you may need to include 'main/debug' component                                        Repository: 'Types: deb                                                                                URIs: https://ppa.launchpadcontent.net/git-core/ppa/ubuntu/
Suites: noble                                                                                Components: main                                                                                '                                                                                Description:
The most current stable version of Git for Ubuntu.

For release candidates, go to https://launchpad.net/~git-core/+archive/candidate .                          More info: https://launchpad.net/~git-core/+archive/ubuntu/ppa
Adding repository.
 Done                                                                               Hit:1 http://security.ubuntu.com/ubuntu noble-security InRelease                                            Hit:2 https://packages.microsoft.com/ubuntu/24.04/prod noble InRelease                                      Hit:3 http://archive.ubuntu.com/ubuntu noble InRelease                                                      Hit:4 http://archive.ubuntu.com/ubuntu noble-updates InRelease                                              Hit:5 http://archive.ubuntu.com/ubuntu noble-backports InRelease                                            Hit:6 https://ppa.launchpadcontent.net/git-core/ppa/ubuntu noble InRelease                                  Reading package lists... Done                                                                               Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  git-man                                                                                Suggested packages:                                                                                git-daemon-run | git-daemon-sysvinit git-doc git-email git-gui gitk gitweb git-cvs git-mediawiki git-svn  The following packages will be upgraded:
  git git-man
2 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 8967 kB of archives.
After this operation, 11.9 MB of additional disk space will be used.
Get:1 https://ppa.launchpadcontent.net/git-core/ppa/ubuntu noble/main amd64 git amd64 1:2.47.1-0ppa1~ubuntu24.04.1 [6775 kB]
Get:2 https://ppa.launchpadcontent.net/git-core/ppa/ubuntu noble/main amd64 git-man all 1:2.47.1-0ppa1~ubuntu24.04.1 [2192 kB]
Fetched 8967 kB in 6s (1406 kB/s)
(Reading database ... 44478 files and directories currently installed.)
Preparing to unpack .../git_1%3a2.47.1-0ppa1~ubuntu24.04.1_amd64.deb ...
Unpacking git (1:2.47.1-0ppa1~ubuntu24.04.1) over (1:2.43.0-1ubuntu7.1) ...
Preparing to unpack .../git-man_1%3a2.47.1-0ppa1~ubuntu24.04.1_all.deb ...
Unpacking git-man (1:2.47.1-0ppa1~ubuntu24.04.1) over (1:2.43.0-1ubuntu7.1) ...
Setting up git-man (1:2.47.1-0ppa1~ubuntu24.04.1) ...
Setting up git (1:2.47.1-0ppa1~ubuntu24.04.1) ...
Processing triggers for man-db (2.12.0-4build2) ...
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  git-ftp
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 25.2 kB of archives.
After this operation, 80.9 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu noble/universe amd64 git-ftp all 1.6.0+dfsg-1 [25.2 kB]
Fetched 25.2 kB in 0s (120 kB/s)
Selecting previously unselected package git-ftp.
(Reading database ... 44529 files and directories currently installed.)
Preparing to unpack .../git-ftp_1.6.0+dfsg-1_all.deb ...
Unpacking git-ftp (1.6.0+dfsg-1) ...
Setting up git-ftp (1.6.0+dfsg-1) ...
Processing triggers for man-db (2.12.0-4build2) ...
PPA publishes dbgsym, you may need to include 'main/debug' component
Repository: 'Types: deb
URIs: https://ppa.launchpadcontent.net/git-core/ppa/ubuntu/
Suites: noble
Components: main
'
Description:
The most current stable version of Git for Ubuntu.

For release candidates, go to https://launchpad.net/~git-core/+archive/candidate .
More info: https://launchpad.net/~git-core/+archive/ubuntu/ppa
Removing repository.
Press [ENTER] to continue or Ctrl-c to cancel.


Re-record functions extensions tests

API change check
API changes are not detected in this pull request.


refactor($compile): reuse shared simpleCompare method

I think this could be used in some other places as well once it's available...

The equals and the ngModel watch cases are performance sensitive (invoked per digest) so I didn't want to change them.
The one I do want to change in a separate commit is this block which (I think) is equivalent to simpleCompare if the 3rd param is true...

LGTM


[AutoPR sqlvirtualmachine/resource-manager] [Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2017-03-01-preview

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6146

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/4942


Support saving the remote kernel for reuse on next open

For #12828
Remember remote kernel ids when reconnecting a notebook.
There's a couple of parts to this.

NotebookModel will now have the potential to indicate a kernel id (and not just a display name)
NotebookModel will store the 'extra' data for the kernel id in a global memento (limited to 40 active at a time)
JupyterSession will support picking a kernel with an id on startup (and not just when switching)

Codecov Report

Merging #13125 into master will decrease coverage by 0.01%.
The diff coverage is 55.10%.

@@            Coverage Diff             @@
##           master   #13125      +/-   ##
==========================================
- Coverage   59.79%   59.77%   -0.02%
==========================================
  Files         671      671
  Lines       36688    36720      +32
  Branches     5158     5169      +11
==========================================
+ Hits        21936    21951      +15
- Misses      13659    13663       +4
- Partials     1093     1106      +13

Impacted Files
Coverage Δ

.../datascience/interactive-common/interactiveBase.ts
5.52% <ø> (ø)

...ient/datascience/interactive-ipynb/nativeEditor.ts
8.44% <0.00%> (ø)

...tascience/interactive-ipynb/nativeEditorStorage.ts
68.89% <0.00%> (ø)

...t/datascience/jupyter/jupyterInvalidKernelError.ts
44.44% <0.00%> (ø)

src/client/datascience/jupyter/jupyterServer.ts
9.25% <ø> (ø)

...lient/datascience/jupyter/jupyterSessionManager.ts
9.03% <0.00%> (ø)

...datascience/jupyter/liveshare/hostJupyterServer.ts
12.00% <0.00%> (ø)

src/client/datascience/notebookStorage/factory.ts
80.00% <ø> (ø)

src/client/datascience/notebookStorage/types.ts
100.00% <ø> (ø)

...client/datascience/raw-kernel/rawJupyterSession.ts
16.16% <ø> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939787b...87d20c5. Read the comment docs.


net: TestTCPReadWriteAllocs fails on dragonfly

See http://build.golang.org/log/f856032d909e5c4bbbdd147ac38da87e353d7372

Merged into #8859.


Code debugging using breakpoints

💡 Feature request
A way to locally debug the code
Overview and problem statement
In every reference to the word "debug" in the documentation, i can only see ways to debug with logs.
i find myself adding a log after a log, while i just need a breakpoint.
we are developing using wrangler dev with a result of a typescript build with webpack.

Hello. Now that wrangler using workerd locally, is that easier to implement?

With this PR merged it seems to be possible:
https://github.com/cloudflare/workerd/pull/17

Unfortunately this isn't ready yet (that PR doesn't fully support what we'd need). It's on our roadmap though, and it's definitely something we're looking to fix in the future.

Closing this in favour of https://github.com/cloudflare/workerd/issues/371, which tracks the work needed here for breakpoint debugging support in local mode.

saving people some time from reading thru a bunch of the above - the vscode + wrangler instructions you need are here. https://blog.cloudflare.com/debugging-cloudflare-workers#breakpoints


Enhancement/hotloading

Requesting to include the HMR and react hot loading feature for development purposes

We need to fix a convention on semicolons. I started writing without them since no-one replied to my question on Slack. What are your feelings on this?
This video is a good reference on why I don't bother using semicolons.


test: added new case

Description
Added new test case for the template module.
Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12463337741
Commit: d7d11f85cb88224c18c270e17398f5b1a405b219
Workflow: PR Automation test suite
Tags: @tag.Templates
Spec: ``
Mon, 23 Dec 2024 07:56:50 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/ci-test-limit-count run_count=1 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/Templates/Template_DataBindingFunctions_spec.ts

/ci-test-limit-count run_count=5 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/Templates/Template_DataBindingFunctions_spec.ts


[BUG] Microsoft.Azure.Graph.RBAC.Models.DirectoryObject is missing all expandable properties

Describe the bug
If you browse the OData API (https://graph.windows.net/tenantid/$metadata), you will see the DirectoryObject has the following properties:

objectType
objectId
deletionTimestamp

and the following navigation properties:

createdOnBehalfOf
createdObjects
manager
directReports
members
transitiveMembers
memberOf
transitiveMemberOf
owners
ownedObjects

The problem is that all the navigation properties are not present in the DirectoryObject model.
Expected behavior
The navigation properties should be there.
Actual behavior (include Exception or Stack Trace)
There is no way to get the navigation properties, so no stack trace.
To Reproduce
no reproduction possible.
Environment:
not relevant. Is broken everywhere

Thank you for your feedback.  Tagging and routing to the team best able to assist.

fyi
This is also more or less related to this issue: https://github.com/MicrosoftDocs/feedback/issues/1339
I wan't to solve this issue and needs the owners of the AdApplication. But I can't get it from the data model.

any updates on this @jsquire .
It would also help if anybody can provide the implementation of the function Start-AutoRestCodeGeneration. Then I can fix the bug by myself. But I can't find it.

The function is used here

Unfortunately, I'm only serving as first-line triage in this case.  I don't have insight into the process that is used by the team that owns this library.   Generally, there's a 72 hour window provided for teams to triage and respond.   If we don't see engagement by the owners after 72 hours, please feel free to ping me again and I'll do what I'm able to escalate.

ping @jsquire ;) 72h are over 🕐

Thank you for the ping, @paule96.   I've started an internal thread to track down the correct owner and escalate.

Ping again @jsquire.
It would be good to have an update on this.

Hi @paule96.   I apologize for the lack of engagement;  we're still working internally to find the appropriate owner and get you some assistance.   Unfortunately, while we're closer, I don't have a solid timeline.  With the US holidays at the end of this week, we may be delayed until folks return to the office next week.

all good :) I just try to not forget this. So don't worry if I asking ever 72h. It's also a reminder for me. ^^
So any updates here?

No updates;  the email thread was kicked but, as mentioned, the US holiday last week had many folks out.   I'll kick it next on Wednesday, to give some time for those returning to get through their email backlog.

Just a quick note, there is still discussion ongoing internally.  One key contact was out through last week.   We apologize for the delay and confusion surrounding ownership here.

Thanks for letting me know. 👍 You do a great job!

@jsquire Are there any updates?

Hi @paule96.   Apologies for not touching base sooner.  Unfortunately, though we've continued to dig in we've still not been able to locate the owner of the library.  At this point, I've been going through the commit history and reaching out to those that contributed and who still work for Microsoft in the hope of finding some insight.   This morning, I reached out a small set of contributors from 5 years ago.... so we're pretty close to the end of that.
There's also been discussion happening at the leadership levels to try and understand that the future plans and directions are for the library, but I don't have any updates there nor any deep insight into the process.
This is the part where I apologize, again, that you've been waiting for so long.... though I imagine that it is starting to feel rather disingenuous.

But sounds good you are close to finding the know-how. Hope you can find a new owner for this library

@jsquire you can find the API reference for the RBAC package here: https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/api/api-catalog. The service does not maintain the swagger and @lmazuel is the owner of the swagger. I know that this package is on its way to deprecation and it is highly discouraged to use it. I tried to regenerate it for JS with the latest swagger but was told not to do so here https://github.com/Azure/azure-sdk-for-js/pull/13858. The recommendation is to use @microsoft/microsoft-graph-client instead.

@deyaaeldeen you mean this: https://github.com/microsoftgraph/msgraph-sdk-dotnet?
Okay so I must talk to the Azure AD PowerShell Module owner how we can use the new tools.

Thanks for your input, @deyaaeldeen.   Given that we don't know who the owner of the package is, I'm not sure that I agree that we can authoritatively make the statement that it is deprecated.   I'll follow-up with @ramya-rao-a offline to better understand the source of her statement, as it differs from the insight provided by others.
That said, I would certainly agree that no PowerShell module should have a dependency on this library; in the best case, it is a preview that hasn't been updated in several years.  I would strongly advise that it not be used in production scenarios nor critical workloads.

@jsquire @ramya-rao-a pointed to this post in the closed PR I linked to earlier.

Thanks for your patience @paule96
The Azure AD Graph API is definitely on its path of being deprecated in favor of the Microsoft Graph API
Relevant support statements from the service:

The packages we have for Azure AD Graph will also follow suit i.e. get security updates until June 30th 2022 after which they will be deprecated.
Please refer to Update your applications to use Microsoft Authentication Library and Microsoft Graph API for next steps. There are relevant links in there with pointers to places where you can provide feedback or ask any follow up questions.

Okay so it's shouldn't be used by the Azure PowerShell team. So what are the next steps to remove the dependency from here?
Is this an issue that will be routed internally at Microsoft to the Azure PowerShell team or should I open an issue in their repo?

@paule96:  If you don't mind opening an issue in the PowerShell repository, that is likely to be the most expedient path forward.  With no known owner for for the Graph RBAC library, it would probably be one of the folks involved in this thread who would reach out to the PowerShell team via a GitHub issue to make them aware.   You are likely to carry more weight, as you have a real-world driver for the change.
Please feel free to mention myself, @ramya-rao-a, and @AlexGhiondea in as needed if we can help with the resulting discussion there.


Add fix to omptests for unified memory

Add fix to omptests for unified memory.
HSA_XNACK was not being set to 1.
I also added t-taskgroup to skipped tests as it is being killed anuway as it gets stuck. So this should also reduce the time it takes to run the test suite.

I left the HSA_XNACK ?= 1 as before no change there.


URI must be a string or UriInterface

Hi
I followed your documentation but I get the following error
URI must be a string or UriInterface

Hi I followed your documentation but I get the following error URI must be a string or UriInterface

Add steps to recreate the error please.

I get the same problem too. When I go to the '/laravel-nowpayments' URL it throws that error.

Please add these to the .env
NOWPAYMENTS_LIVE_URL="https://api.nowpayments.io/v1"
NOWPAYMENTS_SANDBOX_URL="https://api-sandbox.nowpayments.io/v1"
NOWPAYMENTS_ENV="live"
NOWPAYMENTS_API_KEY="Your-API-KEY-Here"
NOWPAYMENTS_CALLBACK_URL="https://mycallback.io"
I'll update the documentation to point this out appropriately. Thank you.

Please add these to the .env
NOWPAYMENTS_LIVE_URL="https://api.nowpayments.io/v1"
NOWPAYMENTS_SANDBOX_URL="https://api-sandbox.nowpayments.io/v1"
NOWPAYMENTS_ENV="sandbox"
NOWPAYMENTS_API_KEY="Your-API-KEY-Here"
NOWPAYMENTS_CALLBACK_URL="https://mycallback.io"
I'll update the documentation to point this out appropriately. Thank you.

Add these to your .env
NOWPAYMENTS_LIVE_URL="https://api.nowpayments.io/v1"
NOWPAYMENTS_SANDBOX_URL="https://api-sandbox.nowpayments.io/v1"
NOWPAYMENTS_ENV="sandbox"
NOWPAYMENTS_API_KEY="Your-API-Key-Here"
NOWPAYMENTS_CALLBACK_URL="https://mycallback.io"
NOWPAYMENTS_EMAIL="your-email-here"
NOWPAYMENTS_PASSWORD="*******"
You can also add these to the config/nowpayments.php accordingly.
I'll update the documentation to address this properly. Thank you


TopBar.jsx

We have also add hover effect to navbar without hover effect it not looks good

come up with other meaningful issues


Plan to package dynomite for Debian

Dear all,
I'm planning to package dynomite and get it included into Debian. I've just filed an ITP (Bug #842113 concerning this.
One question: is the yaml-0.1.4 used for static linking an hard dependency or is it just to simplify the build process for people? I prefer to ask as I've modified the build process for Debian to dynamically link against the version actually present in unstable (yaml-0.1.6) and would not like to create regressions or things like that.
Thanks,
Raphaël

Great, thanks! I do not believe it is a hard dependency. You can file also file a PR if you want to update to the latest yaml-0.1.6. You will need to update the corresponding files under https://github.com/Netflix/dynomite/tree/dev/

Hi, thank you for your answer. I may do a PR so that we are all in sync although in the case of the Debian packaging I just need to link on dyn libs already in the distribution (this is mandatory). At the moment I just modified 2 .ac files to simply ignore the embedded yaml distributed with dynomite. I'll keep you updated. Thanks.

Hi @GarageDeveloper , did you could to package and include into Debian?
Thanks in advance!

@GarageDeveloper I'm interested in packaging dynomite for Debian (not necessarily have it uploaded to Debian as-is, but a "proper" DFSG-compliant package), so if you have some partial work somewhere on github or on any other SCM I'd be interested in helping.
If not, I'll post here the URL where you will find my work.

any updates on this? Any way I can help?


event pullbacks

add event pullbacks. additional non-linear op in OdeEquations that adjusts the state at each event (use in solve and solve_dense). Users can use this to easily implement actions during solve (e.g. bouncing ball)

[ ] solve should return output at events if they are present, not just at internal steps
[ ] two types of events, one based on a sequence of times (pre-baked events), other on a root function (dynamic events). the former is done using solve_dense, the latter using solve
[ ] add a new equation representing the event pullback.

I'm going to close this for now, I think anything discrete can be done by the user, diffsol will just handle continuous integrals for now


Extract message emitters from Printer

Current dependencies on/for this PR:

main

PR #3895   👈

This comment was auto-generated by Graphite.


feat: add plugin-markdown-image

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.759%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
681

Relevant Lines:
1238

💛  - Coveralls

@pengzhanbo  I am using plugin options for selectors and write dynamic style files.
Any better approach?

@pengzhanbo I am using plugin options for selectors and write dynamic style files.
Any better approach?

Using built-in styles is fine, but it can also be offered as an optional method. Users can choose not to use built-in styles and instead customize them by providing style templates in document form.

Is there any limitation with the current behavior?


crossingsRemoved makes these two contours disappear

Text:
path.components.map { $0.curves } =
[[BezierKit.CubicCurve(p0: (28.0, 14.0), p1: (32.0, 21.0), p2: (33.0, 42.0), p3: (30.0, 53.0)), BezierKit.CubicCurve(p0: (30.0, 53.0), p1: (19.0, 32.0), p2: (22.0, 26.0), p3: (28.0, 14.0))], [BezierKit.CubicCurve(p0: (42.0, 38.0), p1: (42.0, 53.0), p2: (36.0, 53.0), p3: (27.0, 53.0)), BezierKit.CubicCurve(p0: (27.0, 53.0), p1: (19.0, 40.0), p2: (29.0, 32.0), p3: (42.0, 38.0))]]
path.crossingsRemoved().components.map { $0.curves } =
[]

Visual:

@mbutterick I was able to reproduce this issue! As you reported, the result is falsely empty. I'm not sure why yet, but I'm saving this test data for posterity.
                                                               p1: CGPoint(x: 32.0, y: 21.0),
                                                               p2: CGPoint(x: 33.0, y: 42.0),
                                                               p3: CGPoint(x: 30.0, y: 53.0)),
                                          BezierKit.CubicCurve(p0: CGPoint(x: 30.0, y: 53.0),
                                                               p1: CGPoint(x: 19.0, y: 32.0),
                                                               p2: CGPoint(x: 22.0, y: 26.0),
                                                               p3: CGPoint(x: 28.0, y: 14.0))]

        let secondCurves: [BezierCurve] = [BezierKit.CubicCurve(p0: CGPoint(x: 42.0, y: 38.0),
                                                                p1: CGPoint(x: 42.0, y: 53.0),
                                                                p2: CGPoint(x: 36.0, y: 53.0),
                                                                p3: CGPoint(x: 27.0, y: 53.0)),
                                           BezierKit.CubicCurve(p0: CGPoint(x: 27.0, y: 53.0),
                                                                p1: CGPoint(x: 19.0, y: 40.0),
                                                                p2: CGPoint(x: 29.0, y: 32.0),
                                                                p3: CGPoint(x: 42.0, y: 38.0))]

        let component1 = PathComponent(curves: firstCurves)
        let component2 = PathComponent(curves: secondCurves)
        let path = Path(components: [component1, component2])
        let result = path.crossingsRemoved()
        XCTAssertFalse(result.isEmpty)

@mbutterick I was able to reproduce this issue! As you reported, the result is falsely empty. I'm not sure why yet, but I'm saving this test data for posterity.
                                                               p1: CGPoint(x: 32.0, y: 21.0),
                                                               p2: CGPoint(x: 33.0, y: 42.0),
                                                               p3: CGPoint(x: 30.0, y: 53.0)),
                                          BezierKit.CubicCurve(p0: CGPoint(x: 30.0, y: 53.0),
                                                               p1: CGPoint(x: 19.0, y: 32.0),
                                                               p2: CGPoint(x: 22.0, y: 26.0),
                                                               p3: CGPoint(x: 28.0, y: 14.0))]

        let secondCurves: [BezierCurve] = [BezierKit.CubicCurve(p0: CGPoint(x: 42.0, y: 38.0),
                                                                p1: CGPoint(x: 42.0, y: 53.0),
                                                                p2: CGPoint(x: 36.0, y: 53.0),
                                                                p3: CGPoint(x: 27.0, y: 53.0)),
                                           BezierKit.CubicCurve(p0: CGPoint(x: 27.0, y: 53.0),
                                                                p1: CGPoint(x: 19.0, y: 40.0),
                                                                p2: CGPoint(x: 29.0, y: 32.0),
                                                                p3: CGPoint(x: 42.0, y: 38.0))]

        let component1 = PathComponent(curves: firstCurves)
        let component2 = PathComponent(curves: secondCurves)
        let path = Path(components: [component1, component2])
        let result = path.crossingsRemoved()
        XCTAssertFalse(result.isEmpty)

My credibility is restored 😉

My credibility is restored 😉

Haha, well you're pretty credible in my book. The issues you open always have the exact data needed to reproduce which makes them pretty stellar.

Haha, well you're pretty credible in my book. The issues you open always have the exact data needed to reproduce which makes them pretty stellar.

delving into this a bit (and please pardon my stream of consciousness):
The top intersection shown in this diagram is actually two separate nearby intersections (one at 30.01, 52.98) and the other at 29.99, 52.98). If we look at the first contour, the first nearby intersection falls on its first curve at t = 0.99929, and the second nearby intersection falls on its second curve at t = 0.00036. If we look at the second contour, the first nearby intersection falls on its first curve at t = 0.88399, and the second nearby intersection falls on the same curve at t = 0.88474. These intersections are actually being computed accurately, and oddly do not appear to be the cause of the failure.
Next in AugmentedGraph we classify the edges, and appear to do so correctly for the first contour (we even classify the tiny edge of the contour between the two nearby intersections correctly). The problem is with when we go to classify the second contour. When we classify the edge from the first curve at t = 0.884 to the second curve at t = 0.364 we falsely conclude that this edge should be excluded from the solution.

delving into this a bit (and please pardon my stream of consciousness):
The top intersection shown in this diagram is actually two separate nearby intersections (one at 30.01, 52.98) and the other at 29.99, 52.98). If we look at the first contour, the first nearby intersection falls on its first curve at t = 0.99929, and the second nearby intersection falls on its second curve at t = 0.00036. If we look at the second contour, the first nearby intersection falls on its first curve at t = 0.88399, and the second nearby intersection falls on the same curve at t = 0.88474. These intersections are actually being computed accurately, and oddly do not appear to be the cause of the failure.
Next in AugmentedGraph we classify the edges, and appear to do so correctly for the first contour (we even classify the tiny edge of the contour between the two nearby intersections correctly). The problem is with when we go to classify the second contour. When we classify the edge from the first curve at t = 0.884 to the second curve at t = 0.364 we falsely conclude that this edge should be excluded from the solution.

It looks like if we do component2.contains(CGPoint(x: 28.52584147560618, y: 52.99912729740088)) we are getting the wrong answer. I think this is the root of the problem. contains says the point is contained but in fact the point should have a y value greater than the curve 52.997 making it fall outside the contour.

It looks like if we do component2.contains(CGPoint(x: 28.52584147560618, y: 52.99912729740088)) we are getting the wrong answer. I think this is the root of the problem. contains says the point is contained but in fact the point should have a y value greater than the curve 52.997 making it fall outside the contour.

@mbutterick in Util.swift could you try changing the line 190 to if discriminant < -1.0e-14 { and line 207 to if discriminant > 1.0e-14 { and report results?
I think this should do the trick.

@mbutterick in Util.swift could you try changing the line 190 to if discriminant < -1.0e-14 { and line 207 to if discriminant > 1.0e-14 { and report results?
I think this should do the trick.

Before the patch, here are the glyphs that fail:
glyph X in [AFFont: Advocate Slab C45 Regular, 706 glyphs] did not have overlap removed successfully
glyph y in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph k in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph y.mid in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph y in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph K in [AFFont: Advocate Slab C63 Regular, 775 glyphs] did not have overlap removed successfully
glyph k.alt in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph y.mid in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph k.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph k.alt.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully

After the patch:
glyph iogonek.mid in [AFFont: Advocate Slab C43 Regular, 775 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C45 Regular, 706 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C55 Regular, 706 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C63 Regular, 775 glyphs] did not have overlap removed successfully

So the patch is apparently fixing one bug & introducing another (because the two sets of problem glyphs have nothing in common).
The interesting common feature of the first set of glyphs is that they all have diagonal parts — curious why that would consistently trigger a bug.
The interesting feature of the second set is that it's the same glyph in different styles. The iogonek.mid is shown below. I will have to experiment some more to see which points in the glyph are causing the problem (though based on the results, I suspect it’s where the ogonek accent is intersecting the bottom).

Here’s a fragment of the glyph that still manifests the problem:

And the debug report for that fragment:
path.components.map { $0.curves } =
[[BezierKit.CubicCurve(p0: (96.0, 75.0), p1: (96.0, 71.0), p2: (97.0, 70.0), p3: (101.0, 70.0)), BezierKit.LineSegment(p0: (101.0, 70.0), p1: (187.0, 70.0)), BezierKit.CubicCurve(p0: (187.0, 70.0), p1: (192.0, 70.0), p2: (194.0, 71.0), p3: (194.0, 77.0)), BezierKit.CubicCurve(p0: (194.0, 77.0), p1: (194.0, 578.0), p2: (96.0, 578.0), p3: (96.0, 75.0))], [BezierKit.CubicCurve(p0: (61.0, 85.0), p1: (61.0, 70.0), p2: (61.0, 70.0), p3: (76.0, 70.0)), BezierKit.LineSegment(p0: (76.0, 70.0), p1: (214.0, 70.0)), BezierKit.CubicCurve(p0: (214.0, 70.0), p1: (229.0, 70.0), p2: (229.0, 70.0), p3: (229.0, 85.0)), BezierKit.CubicCurve(p0: (229.0, 85.0), p1: (229.0, 158.0), p2: (61.0, 158.0), p3: (61.0, 85.0))], [BezierKit.LineSegment(p0: (216.0, 103.0), p1: (182.0, 118.0)), BezierKit.CubicCurve(p0: (182.0, 118.0), p1: (123.0, 90.0), p2: (144.0, -45.0), p3: (144.0, -19.0)), BezierKit.CubicCurve(p0: (144.0, -19.0), p1: (144.0, 26.0), p2: (170.0, 64.0), p3: (216.0, 97.0)), BezierKit.LineSegment(p0: (216.0, 97.0), p1: (216.0, 103.0))]]
path.crossingsRemoved().components.map { $0.curves } =
[]

In this case, I notice that as with the previous cases, it has a little “point” sticking below a horizontal line. (Maybe your patch corrects the “pointing up” case but breaks the “pointing down” case?)

Before the patch, here are the glyphs that fail:
glyph X in [AFFont: Advocate Slab C45 Regular, 706 glyphs] did not have overlap removed successfully
glyph y in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph k in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph y.mid in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph y in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph K in [AFFont: Advocate Slab C63 Regular, 775 glyphs] did not have overlap removed successfully
glyph k.alt in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph y.mid in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph k.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph k.alt.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully

After the patch:
glyph iogonek.mid in [AFFont: Advocate Slab C43 Regular, 775 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C45 Regular, 706 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C51 Regular, 764 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C61 Regular, 764 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C53 Regular, 775 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C55 Regular, 706 glyphs] did not have overlap removed successfully
glyph iogonek.mid in [AFFont: Advocate Slab C63 Regular, 775 glyphs] did not have overlap removed successfully

So the patch is apparently fixing one bug & introducing another (because the two sets of problem glyphs have nothing in common).
The interesting common feature of the first set of glyphs is that they all have diagonal parts — curious why that would consistently trigger a bug.
The interesting feature of the second set is that it's the same glyph in different styles. The iogonek.mid is shown below. I will have to experiment some more to see which points in the glyph are causing the problem (though based on the results, I suspect it’s where the ogonek accent is intersecting the bottom).

Here’s a fragment of the glyph that still manifests the problem:

And the debug report for that fragment:
path.components.map { $0.curves } =
[[BezierKit.CubicCurve(p0: (96.0, 75.0), p1: (96.0, 71.0), p2: (97.0, 70.0), p3: (101.0, 70.0)), BezierKit.LineSegment(p0: (101.0, 70.0), p1: (187.0, 70.0)), BezierKit.CubicCurve(p0: (187.0, 70.0), p1: (192.0, 70.0), p2: (194.0, 71.0), p3: (194.0, 77.0)), BezierKit.CubicCurve(p0: (194.0, 77.0), p1: (194.0, 578.0), p2: (96.0, 578.0), p3: (96.0, 75.0))], [BezierKit.CubicCurve(p0: (61.0, 85.0), p1: (61.0, 70.0), p2: (61.0, 70.0), p3: (76.0, 70.0)), BezierKit.LineSegment(p0: (76.0, 70.0), p1: (214.0, 70.0)), BezierKit.CubicCurve(p0: (214.0, 70.0), p1: (229.0, 70.0), p2: (229.0, 70.0), p3: (229.0, 85.0)), BezierKit.CubicCurve(p0: (229.0, 85.0), p1: (229.0, 158.0), p2: (61.0, 158.0), p3: (61.0, 85.0))], [BezierKit.LineSegment(p0: (216.0, 103.0), p1: (182.0, 118.0)), BezierKit.CubicCurve(p0: (182.0, 118.0), p1: (123.0, 90.0), p2: (144.0, -45.0), p3: (144.0, -19.0)), BezierKit.CubicCurve(p0: (144.0, -19.0), p1: (144.0, 26.0), p2: (170.0, 64.0), p3: (216.0, 97.0)), BezierKit.LineSegment(p0: (216.0, 97.0), p1: (216.0, 103.0))]]
path.crossingsRemoved().components.map { $0.curves } =
[]

In this case, I notice that as with the previous cases, it has a little “point” sticking below a horizontal line. (Maybe your patch corrects the “pointing up” case but breaks the “pointing down” case?)

@mbutterick this is extremely helpful feedback. Before I had you set the value to 1.0e-14 it was effectively set at 1.0e-8. Perhaps I am being too aggressive with my change. I noticed that to fix the first path specifically I only need to set it as low as 1.0e-10, which is 10,000x larger than 1.0e-14.
Could you try 1.0e-10, 1.0e-11, 1.0e-12 and 1.0e-13 and let me know if one of these values works best? (fixes the issue but does not cause regressions with the the iogonek.mid glyph or other glyphs).

@mbutterick this is extremely helpful feedback. Before I had you set the value to 1.0e-14 it was effectively set at 1.0e-8. Perhaps I am being too aggressive with my change. I noticed that to fix the first path specifically I only need to set it as low as 1.0e-10, which is 10,000x larger than 1.0e-14.
Could you try 1.0e-10, 1.0e-11, 1.0e-12 and 1.0e-13 and let me know if one of these values works best? (fixes the issue but does not cause regressions with the the iogonek.mid glyph or other glyphs).

Whoops, I made a mistake typing your patch — I didn’t notice that the second number is positive. That explains where the “new bug” came from … 🤦
The revised results:

If I type your patch correctly (setting line 190 to -1.0e-14 and 207 to 1.0e-14), then all the errors are cleared.

If I adjust the constants to  ±1.0e-12, I still get an error on one of the K glyphs.

If I adjust the constants to ±1.0e-13, then the errors are still cleared.

Whoops, I made a mistake typing your patch — I didn’t notice that the second number is positive. That explains where the “new bug” came from … 🤦
The revised results:

If I type your patch correctly (setting line 190 to -1.0e-14 and 207 to 1.0e-14), then all the errors are cleared.

If I adjust the constants to  ±1.0e-12, I still get an error on one of the K glyphs.

If I adjust the constants to ±1.0e-13, then the errors are still cleared.

@mbutterick wohoo! It sounds like either 1.0e-13 or 1.0e-14 could work. I'll use 1.0e-14 for now.

@mbutterick wohoo! It sounds like either 1.0e-13 or 1.0e-14 could work. I'll use 1.0e-14 for now.

@mbutterick I've added a unit test using your data and merged the fix into the branch 0.9-release. I'm closing the issue now.

@mbutterick I've added a unit test using your data and merged the fix into the branch 0.9-release. I'm closing the issue now.

Thank you!

Thank you!


Store desktop notification settings in Firefox

Every time I log into https://mixxx.zulipchat.com/ I get this topbar asking me wether to allow desktop notifications. I don't need that feature. No matter if I explicitely disable notifications or just close that bar, it's back on every login, even after page refresh.
Cookies are allowed, script are allowed, so what else could be the problem here?
Firefox 59.0.2 (64-bit)
ubuntu studio 14.04

@ronso0 if you click the "don't want notifications" option in that bar, it offers you a "never ask this again" option that uses browser local storage to keep track of that setting for the browser forever.  It fundamentally has to be a per-browser setting, since someone might want different behavior on different browsers.
Can you check if that works for you?  If not, it's possible you have some Firefox privacy setting enabled that disables browser local storage.

Okay, I must have missed that Firefox dialog after upgrading.
Disabling notifications is persisting Firefox restart.
Thanks!


ImportError: /home/dosisiddhesh/.cache/torch_extensions/py39_cu117/slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0/slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0.so: cannot open shared object file: No such file or directory

I installed xlstm using
pip install xlstm
My system is
   0  Quadro RTX 5000                On  | 00000000:AF:00.0 Off |                  Off |
| 33%   49C    P2              55W / 230W |   3825MiB / 16384MiB |      3%      Default |

nvcc --version
11.7
Logs
Using /home/dosisiddhesh/.cache/torch_extensions/py39_cu117 as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /home/dosisiddhesh/.cache/torch_extensions/py39_cu117/slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0/build.ninja...
Building extension module slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
1.11.1.git.kitware.jobserver-1
Loading extension module slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0...
Traceback (most recent call last):
  File "/home/dosisiddhesh/SIDDHESH/PCN_XLSTM/train.py", line 442, in <module>
    train()
  File "/home/dosisiddhesh/SIDDHESH/PCN_XLSTM/train.py", line 119, in train
    net = model_module.Model(args).cuda()
  File "/home/dosisiddhesh/SIDDHESH/PCN_XLSTM/models/pcn.py", line 235, in __init__
    self.encoder = XL_encoder()
  File "/home/dosisiddhesh/SIDDHESH/PCN_XLSTM/models/pcn.py", line 165, in __init__
    self.xlstm_point_stack = xLSTMBlockStack(cfg)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/xlstm_block_stack.py", line 84, in __init__
    self.blocks = self._create_blocks(config=config)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/xlstm_block_stack.py", line 105, in _create_blocks
    blocks.append(sLSTMBlock(config=config))
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/block.py", line 33, in __init__
    super().__init__(
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/xlstm_block.py", line 63, in __init__
    self.xlstm = sLSTMLayer(config=self.config.slstm)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/layer.py", line 78, in __init__
    self.slstm_cell = sLSTMCell(self.config)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/cell.py", line 780, in __new__
    return sLSTMCell_cuda(config, skip_backend_init=skip_backend_init)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/cell.py", line 690, in __init__
    self.func = sLSTMCellFuncGenerator(self.training, config)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/cell.py", line 536, in sLSTMCellFuncGenerator
    slstm_cuda = sLSTMCellCUDA.instance(config=config)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/cell.py", line 515, in instance
    cls.mod[repr(config)] = load(
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/xlstm/blocks/slstm/src/cuda_init.py", line 84, in load
    mod = _load(name + suffix, sources, **myargs)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1284, in load
    return _jit_compile(
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1535, in _jit_compile
    return _import_module_from_library(name, build_directory, is_python_module)
  File "/home/dosisiddhesh/.conda/envs/xlstm/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1929, in _import_module_from_library
    module = importlib.util.module_from_spec(spec)
  File "<frozen importlib._bootstrap>", line 565, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1173, in create_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
ImportError: /home/dosisiddhesh/.cache/torch_extensions/py39_cu117/slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0/slstm_HS128BS8NH4NS4DBfDRbDWbDGbDSbDAfNG4SA1GRCV0GRC0d0FCV0FC0d0.so: cannot open shared object file: No such file or directory

You can change the backend of sLSTM to 'vanilla', as the author commented.

You can change the backend of sLSTM to 'vanilla', as the author commented.

@HungNguyen4864
I am bit confused about the use of backend parameter in the sLSTM defination.
What is the use of 'cuda' or 'vanilla' as the backend.

In the sLSTMCell_vanilla class, it uses.reshape()and .permute() operations. These do not inherently require a GPU, indicating that this class is designed to operate without the need for GPU acceleration. In contrast, the sLSTMCell_cuda class includes an __init__ constructor that has a skip_backend_init parameter. This allows the class to skip initializing components necessary for GPU operation, which is useful for converting models between different hardware configurations. Methods _impl and _impl_step in this class use self.func.apply, a function specifically designed for GPU execution. Input tensors are required to be .contiguous() before being passed to this function, a requirement essential for efficient operations on CUDA.
If there's still a desire to use a GPU, adjustments in the source code would be necessary. I'm not able to provide specifics on how to make these changes but can confirm the information as stated.
You can follow this path to read more : xlstm/blocks/slstm/cell.py


NG2 + NG2-CLI upgrade

Upgrade to latest angular-cli version 20-4, angular version 2.2.1 and update package.json to have good dependencies and modules in project

Fixed in associated PR


Fix empty response bug in pion-to-pion/answer example if pion-to-pion/offer is run from Chrome

Description
Add CORS code to the answer example code
Prefix default "address" flag with "<IP_ADDRESS>" so that http.Post works in the browser
Reference issue
Fixes #1149

Closed with 5a702b6c3173db62ad90180929854ea2f701601b
Thank you so much @silbinarywolf I just fixed lint error (longer functions can't do naked returns)


Only watch and lint in dev

You have to leave watch on even outside of dev mode. There is at least one part (//prefix) of the bot that uses it.

@Rayzr522 Updated


add rpc

Or maybe it's better use 424 for both, and differentiate them in API Error model

Or maybe it's better use 424 for both, and differentiate them in API Error model. Because I am worried that 412/417 will be confusing

Agree. I also feel 424 is better than 412/417.


Added timestamp to logger and created logger properties interface

resolves: #11

Formatting timestamp with dayjs.
Updated package version to 0.3.0 since it contains breaking changes.
Added test that checks if the logger is being called.

Please let me know if these bullets are fine!

@Arnovsky  Could you please show a usage example? Want to see how it works in practise :D

The API is described in the PR (I have edited the readme.md).

Could you please git pull, then rm -rf node_modules and pnpm install? so the proper lockfile will generate

Codecov Report

Merging #34 into master will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   29.12%   28.89%   -0.23%
==========================================
  Files          17       17
  Lines         649      654       +5
  Branches      177      178       +1
==========================================
  Hits          189      189
- Misses        459      464       +5
  Partials        1        1

Impacted Files
Coverage Δ

packages/logger/src/index.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af8e46...5d0e8f6. Read the comment docs.

@Arnovsky pnpm is taking very long to install :thinking:
mb u messed up somewhere?

Not sure, I deleted node_modules and ran pnpm install && pnpm recursive install anything else I should do?

@Arnovsky
Nice, it's working now.
Could you please create a "mw" folder and put your logger test there?

LGTM. mergin'

@all-contributors please add Arnovsky for plugin


Add a current location button to the EV map

Describe the feature
Currently, there's no current location button to redirect the map to your location; it is fixed to Delhi. A redirect button would improve the user experience.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign this issue to me

some one already working on this


Can I use jsx in .js file and vue3.x project?

Describe the bug
Now that,use '@vitejs/plugin-vue-jsx' can help us use jsx in .jsx file,but i want to use jsx in .js file.
when i use jsx in .jsx file ,it throw an error
Failed to parse source for import analysis because the content contains invalid JS syntax. If you are using JSX, make sure to name the file with the .jsx or .tsx extension.
Reproduction
https://stackblitz.com/edit/vitejs-vite-w4awl2?file=main.js&terminal=dev
System Info
System:
    OS: macOS 12.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 211.95 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.1.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 104.0.5112.101
    Safari: 15.2
  npmPackages:
    @vitejs/plugin-vue: ^3.0.3 => 3.0.3
    @vitejs/plugin-vue-jsx: ^2.0.0 => 2.0.0
    vite: ^3.0.4 => 3.0.9

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vite won't support that.
https://github.com/vitejs/vite/issues/2727#issuecomment-808679467
https://github.com/vitejs/vite/issues/3849#issuecomment-863780814

This isn't supported as incurs perf overheard unnecessarily. See https://github.com/vitejs/vite/discussions/3448

ok,got it!


Enable multiple SparkSQL execution concurrently

This PR let user run multiple sql simultaneously.
But this feature is experimental,
since it works fine only when there is one spark interpreter is bound to notes.

Screen shot for multiple sql running

I tested this branch and it works really well.
The problem @minahlee mention is not oriented from this branch's feature. I created an issue #331 for the problem.
So I think it doesn't need to be experimental and it's good to be merged.

One question.
With this setting, will a spark-sql paragraph run even if during a spark
paragraph is running?
On Sun Feb 08 2015 at 7:50:50 PM Lee moon soo<EMAIL_ADDRESS>wrote:

I tested this branch and it works really well.
The problem @minahlee https://github.com/minahlee mention is not
oriented from this branch's feature. I created an issue #331
https://github.com/NFLabs/zeppelin/issues/331 for the problem.
So I think it doesn't need to be experimental and it's good to be merged.
—
Reply to this email directly or view it on GitHub
https://github.com/NFLabs/zeppelin/pull/313#issuecomment-73405828.

By default, Zeppelin is set to run the jobs in FAIR mode. Each pool gets an equal share of the cluster if there are multiple pools, but Zeppelin had only one scheduler pool(default) in fair scheduler.
This PR adds one more scheduler pool named fair.
Jobs run in FIFO inside default pool, while run parallel inside fair pool.
If you set zeppelin.spark.concurrentSQL 'true',
then spark paragraph will be assigned to default pool, while sparksql paragraph will be assigned to fair pool.
To make a long story short, yes, you can runs spark-sql paragraph even when spark paragraph is running.

Thanks for great explaination!
It will be cooler if a proper docs is somewhere.
Anyway, LGTM

Looks great! i'm merging it.


EspAltherma goes offline in MQTT every sensor update

Hi,
With every update of sensors EspAltherma goes offline in MQTT.
I see that it sends LWT Offline, then after 6 seconds it goes back Online.
Ping to device is ok all the time.
Is it common/known beahviour or should I open my Altherma and check logs with usb cable?

That's weird. Mine is online all the time. Can you check on the logs of homeassistant if you see something that could explain this?
..and also on the logs of your mqtt broker

Similar behavior happened to me after I connected a wifi range extender which made the IP of my ESP device change back and forth.


Prefer the client width/height for the canvas parent

Normally, eframe takes over the entire webpage, but sometimes, you
would like it to "play nice" and keep its canvas to a finite area.  This mostly
works as long as the containing div has the right style properties.
However, the use of scrollheight and scrollwidth breaks the responsive case in which the page is resized.  The canvas will grow, but it will not shrink.
This PR resolves https://github.com/emilk/egui/issues/2805

Yeah - I'm not sure what to do about the cargo deny warnings.

I resync-ed with master.  It looks like the cargo deny issues were fixed there.


Incomplete code

@peetronix commented 5 hours ago — with docs.microsoft.com
The following line is required at the end of the code to display the image: plt.show()

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7dd31cc0-0bff-8bb0-f848-d048eb0bf53e
Version Independent ID: 639d27af-330f-2377-72ed-47e2b913c1d9
Content: Quickstart: Analyze a local image - REST, Python - Azure Cognitive Services
Content Source: articles/cognitive-services/Computer-vision/QuickStarts/python-disk.md
Service: cognitive-services
Sub-service: computer-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@v-radelg we will review your feedback and get back to you shortly. Thanks.

@v-radelg thanks for pointing this at. Will proceed to update document accordingly. Thanks.

Currently, we are in a doc freeze for our upcoming MS Build event. As soon as the freeze is removed, I will update the document. For now I will proceed to close this thread. Thanks.


Inserting Unpack where not needed

I have already described the problem to another repository. But after a little digging, I realized that it was the compiler, not the types.
https://github.com/mtasa-typescript/mtasa-lua-utils/issues/382

resolved.


riscv-elf.md: add description of the code models

Add a brief descritption of the existing code models.

It would be great to:

note the LLVM names for these (small, medium)
show the function calling sequences explicitly

It would be great to:

note the LLVM names for these (small, medium)
show the function calling sequences explicitly

Can you please point to where these remarks apply?

Ping! 🛎


No Push notifications being sent

I get them over FCM but when app is in background I don't get push notifications at all.

In the background they're sent over APNs - can you check the certificates are set up properly in the Firebase Console, and that you're using the right sandbox mode?

Can you explain what is "right sandbox mode"? because i am getting following log "deny(1) file-write-create /private/var/containers/Bundle/Application/FIREBASE_LAST_TIMESTAMP"

Hmm, that timestamp error is an odd one - it not related to FCM per-se, its part of the internal working of FIRApp. What sort of device is this happening on?

Just checked: sadh@ that issue should be fixed in the latest version. What library version are you using?

I am using Firebase 3.4.0, and FirebaseMessaging 1.1.1. It is working now :-) i am getting notifications.

how did you fix? @sadh


Fix race in governance test when running in parallel

The race happens when DAO account receives NTRN tokens during governance test. Instead of checking for amount of NTRN tokens on the account of DAO, we simply check that send transaction succeeds. Also, when running governance test independently, we don't have to wait for IBC connections and such, so I have disabled these barriers for this test.
[Recent test run]

https://github.com/neutron-org/neutron-tests/actions/runs/4915602773


Debugging: Continue/Step/Next are extremely laggy in 1.13

VSCode Version: 1.13
OS Version: Ubuntu 16.04

Steps to Reproduce:

Try to step through Magento 2.1.6's source with https://github.com/felixfbecker/vscode-php-debug and xdebug

Expected:
Equal or better performance than 1.12.2
Actual:
Performance has deteriorated severly

I downgraded to 1.12.2 and ran into the same issue. Turns out the lag was caused by using those xdebug settings
"xdebugSettings": {
    //"max_children": 200,
    //"max_depth": 5
 }

Appologies for the false alarm.


Repetitions are generated although no_repeat_ngram_size is activated

🐛 Bug
Commit 8ca4813 introduced a bug in ngram_repeat_block.py. An argument no_repeat_ngram_size does noes not block repetitions
To Reproduce
Generate longer texts. Repetitions occur.
Code sample
I fixed it in my forked repo. I can copy it here as well. https://github.com/vladsolovyev/fairseq_summarization/blob/main/fairseq/ngram_repeat_block.py
Lines 105-107
ngram_to_check = cpu_tokens[bbsz_idx][-(self.no_repeat_ngram_size - 1) :]
should be changed to
ngram_to_check = cpu_tokens[bbsz_idx][check_start_pos:step+1]
Expected behavior
no_repeat_ngram_size must block repetitions

@anchit it is definitely a bug, i found the same problem.


mypy runs in both pre-commit ci and github actions

we check mypy with both github actions and pre-commit-ci. maybe we can discuss dropping one (my vote is for github actions).

my certain vote is to remove both flake8, mypy and pylint completely from pre-commit-ci

actually I would even opt for removing mypy and pylint from pre-commit completely. they are much too slow, commit times of above 5seconds are totally unacceptable for me and thus pre-commit is currently not very usable as an installed git hook (otherwise one have to type --no-verify everytime on commit). flake8 can stay as it's fast enough.
but maybe there's a way to run these only on pull requests and not for commits.

you can uninstall pre-commit locally

I mean, technically you're correct, there's no need to run pre-commit locally, but you seem to assume that everyone should share your workflow, which is not the case.
in case I want to fix a raised error in a pre-commit hook, this means I would have to commit and push my changes, wait until pre-commit-bot finishes, click on the pre-commit workflow on github and then look at the error message.
the obvious workflow with a lot less friction and wasted time is just running pre-commit locally.
You already have removed the possibility to run pre-commit locally in tox with #564 (which I now see could have been a mistake to approve, but there's no problem reverting that in the future if necessary), so having it installed is currently the most intuitive way of local usage.

I have changed my mind, see #587


Add ImageNet example

ImageNet is a common workload for benchmarking. This PR adds a recipe for running ImageNet in PyTorch with a Croissant loader, which can be useful for both system and ML characterization.
Current WIP status is:

ImageFolder to Croissant prototype.
Functional equivalence of Croissant loader with validation loader.

TODO:

Add training loader with shuffling.
Optimize system performance (e.g., startup for validation loader is ~30 seconds compared to near instant).

@marcenacp Thoughts on the structure so far? I'm not sure if there is a better way to read a local directory---I essentially emulate a zip/tar by creating a no-op "extract" function. I plan to simplify this further to avoid the symbolic links. I am also wondering if you have any thoughts on how to add shuffling/sharding of rows in mlcroissant, which would help with various node and worker-level parallelism strategies.

@mkuchnik Sorry for the late review... I think it's super interesting and I left a few comments:

There is already a way to import files from a specific folder (data/). I linked to an example.
Maybe it's confusing to copy a whole Python file from pytorch. Can you give more instructions? Maybe it's worth having a Jupyter Notebook recipe with an end-to-end example on ImageNet!


Can't select mxnet version on the website due to html rendering

As seen on the screenshot, I can't see the version dropdown when the page is not rendered wide enough.

Same with firefox, btw.

the "+" sign is not working or not intuitive enough?

I guess is not intuitive enough, should be separated or better "..." I was not the only one in the room looking at this.

I agree.
a ...  button close to Discuss (instead of search box) would look better

@sandeep-krishnamurthy please add the labels - Website.

This issue is resolved with new "Versions" dropdown.


Installation does not work properly

Describe the bug
The add-in does not show up in any way after running the installer.
To Reproduce

Downloaded package from Autodesk App store
Quit Fusion360
Double-click to install
Restart Fusion
Restart again
Rebooted macbook, still nothing.

Expected behavior
"Change text parameter"-option to show inside "modify" menu after restarting Fusion.
Hardware
2020 MacbookPro 16, Intel processor
Software

OS: MacOS Monterey
Fusion 360 version: 2.0.12392 (paid)
ParametricText version: [v 2.2.0]

Other info
Plugin .bundle-file can be found at:
/Users/johannes/Library/Application Support/Autodesk/ApplicationPlugins/ParametricText.bundle
But nothing relating to ParametricTex is in:
/Users/johannes/Library/Application Support/Autodesk/Autodesk Fusion 360/API/AddIns
Qvasi-solved
Installed "manually" (downloaded 2.2 from git, unpacked into AddIns-directory, works fine!

The Mac installation is all confusing to me. I think Fusion 360 has two directories but one is symlinked to the other? So I think the first install location in theory should be good. It might also depend on the way Fusion was installed - from the web or from the app store(?).
The installer is created by Autodesk, so it "should work". 🤷
I'm not a Mac user, so I'm glad that you found a workaround that worked.

Perhaps add the workaround to your wiki so it can be found by non-git-people?

A short note has been added to the installation section in the documentation. In 2.3.2 release.


Support expand file path

Support expand file path starting with ~

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

The current version does not work on macOS or it doesn't work on ZSH.

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

The current version does not work on macOS or it doesn't work on ZSH.

Isn't this something done by your shell?

Isn't this something done by your shell?

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

The current version does not work on macOS or it doesn't work on ZSH.

I tried zsh, it also works in an interactive shell. Are you use it in a script like this?

@zyfjeff I tried current version, it already can expend path with ~/, what's the shell you are using?

The current version does not work on macOS or it doesn't work on ZSH.

I tried zsh, it also works in an interactive shell. Are you use it in a script like this?

@chnliyong @davies
The shell is supposed to do path expansion ahead of time, but the script approach is problematic, and I run it with the startup parameters configured by Goland and it doesn't automatically expand.

@chnliyong @davies
The shell is supposed to do path expansion ahead of time, but the script approach is problematic, and I run it with the startup parameters configured by Goland and it doesn't automatically expand.

@chnliyong @davies
The shell is supposed to do path expansion ahead of time, but the script approach is problematic, and I run it with the startup parameters configured by Goland and it doesn't automatically expand.

Conventionally, the ~ expansion is done by shell, not the work for application process.
I think one point is that the interactive shell always opened by a logined user, but the application may not run by an logined user(may a system user which may doesn't have home directory).

@chnliyong @davies
The shell is supposed to do path expansion ahead of time, but the script approach is problematic, and I run it with the startup parameters configured by Goland and it doesn't automatically expand.

Conventionally, the ~ expansion is done by shell, not the work for application process.
I think one point is that the interactive shell always opened by a logined user, but the application may not run by an logined user(may a system user which may doesn't have home directory).

@zyfjeff  This is useful improvement, but we still think it's better handled by shell or other tools. Let's close it for now, we can revisit later.

@zyfjeff  This is useful improvement, but we still think it's better handled by shell or other tools. Let's close it for now, we can revisit later.


[Bug]: Error loading script: ssh_tunnel.py

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits

Are you using the latest version of the colab notebook?

[X] Yes, i am using the latest version from the repo

Which colab notebook did you use?
any
Which repo branch did the colab you use comes from ?
main (v1.6)
Which tunnel did you use ?
--remotemoe
What happened?
Try running any notebook after finishing setting up and trying to launch the error Error loading script: ssh_tunnel.py appears.
Console logs
Launching Web UI with arguments: --xformers --enable-insecure-extension-access --remotemoe
remote.moe detected, trying to connect...
Warning: Permanently added 'remote.moe,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Error loading script: ssh_tunnel.py
Traceback (most recent call last):
  File "/content/stable-diffusion-webui/modules/scripts.py", line 195, in load_scripts
    module = script_loading.load_module(scriptfile.path)
  File "/content/stable-diffusion-webui/modules/script_loading.py", line 13, in load_module
    exec(compiled, module.__dict__)
  File "/content/stable-diffusion-webui/extensions/sd-webui-tunnels/scripts/ssh_tunnel.py", line 87, in <module>
    ssh_tunnel(REMOTE_MOE)
  File "/content/stable-diffusion-webui/extensions/sd-webui-tunnels/scripts/ssh_tunnel.py", line 73, in ssh_tunnel
    strings.en["PUBLIC_SHARE_TRUE"] = f"Public WebUI Colab URL: {tunnel_url.tunnel}\nPrivate WebUI Colab URL:{colab_url}"
AttributeError: 'str' object has no attribute 'tunnel'

thanks @NUROISEA ❤ fixed please try again

Thanks for the quick bug fix! ♥
Closing as completed now! :)


TypeError: windowCenter.toFixed is not a function

Bug Report
Describe the Bug
When using lastest version Viewer, opening a study,and drag the mouse with defalut level icon by pressed and holding the left mouse button, the error occurred!

Fixed in the latest version!


[Web] : Hot restart using named routes with arguments shows error when pressing back button

continuing issue from #73793 due to (probably) different root cause, cc @chunhtai
Steps to Reproduce

Run attached code below
hot restart first
click detail page
press back
web successfully directed to the first page

Expected results: clean log at console
Actual results: got some errors in log

Code

 void main() => runApp(App());

 class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      routes: <String, WidgetBuilder>{
        '/': (_) => FirstPage(),
        '/d': (_) => SecondPage(),
      }
    );
  }
 }

 class FirstPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    // TODO: implement build
    return Scaffold(body:Center(
      child: RaisedButton(onPressed: () => Navigator.of(context).pushNamed('/d', arguments: {"value": 1000})),
    ));
  }
 }

 class SecondPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    // TODO: implement build
    return Scaffold(body:Center(
      child: Text('second page'),
    ));
  }
 }

Logs
Error: Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/navigation/history.dart:284:14
                    _userProvidedRouteName != null
                    is not true
                        at Object.throw_ [as throw] (http://localhost:55332/dart_sdk.js:5333:11)
                        at Object.assertFailed (http://localhost:55332/dart_sdk.js:5269:15)
                        at _engine.SingleEntryBrowserHistory.new.onPopState (http://localhost:55332/dart_sdk.js:148687:59)
[ +166 ms] Error: Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/navigation/history.dart:239:12
                    _isOriginEntry(state)
                    is not true
                        at Object.throw_ [as throw] (http://localhost:55332/dart_sdk.js:5333:11)
                        at Object.assertFailed (http://localhost:55332/dart_sdk.js:5269:15)
                        at _engine.SingleEntryBrowserHistory.new.[_unwrapOriginState] (http://localhost:55332/dart_sdk.js:148663:57)
                        at _engine.SingleEntryBrowserHistory.new.tearDown (http://localhost:55332/dart_sdk.js:148723:79)
                        at tearDown.next (<anonymous>)
                        at http://localhost:55332/dart_sdk.js:39031:33
                        at _RootZone.runUnary (http://localhost:55332/dart_sdk.js:38888:58)
                        at _FutureListener.thenAwait.handleValue (http://localhost:55332/dart_sdk.js:33874:29)
                        at handleValueCallback (http://localhost:55332/dart_sdk.js:34434:49)
                        at Function._propagateToListeners (http://localhost:55332/dart_sdk.js:34472:17)
                        at _Future.new.[_completeWithValue] (http://localhost:55332/dart_sdk.js:34314:23)
                        at async._AsyncCallbackEntry.new.callback (http://localhost:55332/dart_sdk.js:34337:35)
                        at Object._microtaskLoop (http://localhost:55332/dart_sdk.js:39175:13)
                        at _startMicrotaskLoop (http://localhost:55332/dart_sdk.js:39181:13)
                        at http://localhost:55332/dart_sdk.js:34688:9

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.6, on macOS 11.2.1 20D74 darwin-x64, locale
    en-ID)
    • Flutter version 2.0.6 at /Users/ahmadn/flutter
    • Framework revision 1d9032c7e1 (11 days ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/ahmadn/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS
      development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    ! CocoaPods 1.8.4 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    •
      Android 10 (API 29) (emulator)
    • Chrome (web)                       • chrome        • web-javascript •
      Google Chrome 90.0.4430.212

I tried on Flutter 2.2.2 and got the same error, do I need to create new issue, or just put it here?

@billyinferno
The fix was merged in master, so please switch to latest master and try again to see the fix.


delete sbom should drop analysis graph

Deleting an sbom should also remove any related analysis graph

observation: If an sbom is deleted from the system the related graph will never be queried ...


Can't update email settings sliders

@simonmorley
I believe we spoke about not needing Email Capture when using guest access type as guest data already captures email
Or are we sticking with it?

True but they should either work or be removed. Plus none of the options work. Even when reg is off.

Current situation:
Switches disabled when selecting Reg.
If currently on Reg, selecting another access type still has switches disabled after saving, until refreshing the page.


using eth hash when working with secp256k1 keys

Using ethereum hash before checking signatures of secp256k1 keys
Using ethereum functions from foundation

Approved


StringIsJson.Array is broken

StringIsJson.Array implementation is not working:
        MatcherAssert.assertThat(
            "[{\"id\":42}]",
            new StringIsJson.Array(Matchers.any(JsonArray.class))
        ); // FAILS

@rultor release, tag=0.3.4

@rultor release, tag=0.3.4

@g4s8 OK, I will release it now. Please check the progress here

fixed


serve app under homepage

@Timer for 2.0, this feature,  what else do I need to put into this?  webpack serve as well?  how do we want to proceed?

We'll have a better idea after the webpack-serve cut over. You're more than welcome to take a stab at it if you'd like.

So cra is definitely switching to serve for 2.0 then? I guess let me know if you want to get a version working where it’s the same as current next or if this can be merged first then brought over with serve.  This feature is blocking all of my apps from being put back into cra ATM. Had to eject to just run them all at the same time behind an Apache proxy and I’d rather not be ejected.  It seems like others want this functionality as well. Please let me know the best way I can help with this, as it’s coming up on a full year for this feature.

How do I support deploying to more than 2 environments (dev/prod)? I've got local(dev), integration, stage, prod. This gives me domains like dev.mysite.com, test.mysite.com and mysite.com.
If that is not supported, is there any chance to move the value out from package.json homepage and into a .env value instead?

Any updates on merging this?

just merged the latest next branch. @gaearon @Timer where should I leave this pr?  I am moving to a different company shortly, and may not have need of this anymore. I want to see it through, but i'm not really sure where to go next. my main questions are:

is CRA for 2.0 also using webpack 4?  because webpack-serve requires webpack 4
if not webpack 4, then do we want this as part of 2.0 with webpack 3.0?
I was trying to use webpack 4 on a separate project, and rand into the issue that extract text isn't webpack 4 compatible:
https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/701
so is the thought that CRA will use this instead if using webpack 4?
https://github.com/webpack-contrib/mini-css-extract-plugin

a slew of interconnected issues as always 😄

@Timer can we put this pr in the 2.0 project list? He old or was closed and is there, maybe it’s still under the maybe category?

FYI one problem I ran into with this implementation is proxying api requests through webpack:
const proxy = {
      '/scheduling': {
        target: 'http://localhost:3001',
        pathRewrite: { '^/scheduling': '' },
      },
      '/api': {
        target: 'http://another-api-endpoint',
      },
      '/app': {
        target: 'http://someapp.endpoint',
      },
    }

    const proxyConfig = prepareProxy(proxy, paths.appPublic)

When accessing the app at localhost:3000/route the api requests that should be proxied fail as they are being redirected to servedPathPathName (as dictated in serveAppMiddleware).  The workaround here was to pass in the proxyKeys and respect those as well as the servedPathPathName:
module.exports = function createServeAppMiddleware(
  servedPathPathname,
  proxyKeys = []
) {
  function matchesProxyOrServedPathName(requestUrl) {
    const matchesServedPathName = requestUrl.indexOf(servedPathPathname) !== -1

    const matchesProxy =
      matchesServedPathName ||
      proxyKeys.some(key => {
        return requestUrl.startsWith(key)
      })

    return matchesServedPathName || matchesProxy
  }

  return function serveAppMiddleware(req, res, next) {
    if (servedPathPathname.length > 1 && servedPathPathname !== './') {
      if (matchesProxyOrServedPathName(req.url) === false) {
        res.redirect(servedPathPathname)
      } else {
        next()
      }
    } else {
      next()
    }
  }
}

Note that I'm running into this issue after I ejected from CRA and I basically lifted all of your changes into my app locally.  This might not be an issue with current version of next and these changes but thought I'd mention them in case this use case hasn't been tested.

I haven't used CRA in a while, is this supported now officially in the latest release?

@gaearon was this PR was closed due to this feature being added elsewhere? I’ve been following the related issues over the past few months and haven’t really contributed much to the discussion because I assumed people were working on this, as was PR was mentioned in numerous issues, and it has been periodically added and removed from milestones.
This is honestly the final feature that keeps me from ditching my own custom set ups. It will also free me and likely many others from the awful webpack-dev-server vs webpack-serve war if our custom setups need to rely on a non-root publicPath. Thanks for an awesome project!

Is this PR going to make it in?

+1


Revert "Youtube embed #238"

Reverts lazerwalker/azure-mud#309

Merged in via the hotfix-1 branch


Option to get EDITOR from config file

If you run sgpt in an isolated venv, via pipx for example, the EDITOR variable of the host environment will not be found:
https://github.com/TheR1D/shell_gpt/blob/1c585664889e2cfb19ca1e13f0e8d621463ddef3/sgpt/utils.py#L21
I suggest to have an optional EDITOR variable in the config file to cover that.

Moved to discussion #325


tslint.json in JSON Schema Store

This is just a quick question because I've got confused about it: is the JSON schema for tslint.json in the JSON schema store out of date?  Is so is there an up-to-date version?
I think it is out of date because it doesn't support "options" or severities for individual rules, but as I say, I've got a bit confused.

It's out of date. We don't maintain it, but I bet they'd take PRs: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/tslint.json

Thanks, I'm less confused.  Is there actually an up-to-date schema somewhere though?

Not a full up-to-date schema, no. Individual rules do have option schemas listed in their metadata: https://github.com/palantir/tslint/blob/ce73397d5c892ba00b2000306df3a6150c0635de/src/rules/banRule.ts#L59

OK thanks very much.  I'm closing this since you've answered the question, thanks.


forge build skip option is not respected and still compiles and generates build info for tests

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (dedc31e 2023-04-26T00:13:24.012522000Z)
What command(s) is the bug in?
forge build
Operating System
macOS (Apple Silicon)
Describe the bug
The skip flag does not seem to have an effect and build info is still created in the out directory for test contracts. I would expect only artifacts for Counter.sol to be generated
$ forge init
$ forge build --build-info --skip test
$ ls out/
Base.sol        Counter.sol     Script.sol      StdCheats.sol   StdMath.sol     StdUtils.sol    build-info      console2.sol
Counter.s.sol   IMulticall3.sol StdChains.sol   StdJson.sol     StdStorage.sol  Vm.sol          console.sol

You are also building the script folder as evidenced by the Counter.s.sol file. You can use forge build --build-info --skip test script to also skip the script folder


AWSTimestamp comparison operations not working

Describe the bug
Query's comparison operators are not working properly with AWSTimestamp data type.
Following error is return from GraphQL when e.g. 'lt' operator is used on AWSTimestamp item:
Variable 'lt' has an invalid value. Expected type 'Int' but was 'Long'."
Amplify CLI Version
4.21.3
To Reproduce
Define item in schema as AWSTimestamp. Try to use ModelIntInput or FilterInput to parameterize query.
Expected behavior
GraphQL to expect AWSTimestamp and not Int
Desktop (please complete the following information):

OS: Windows
Node Version. v14.2.0

@lkolodziejek I tried to reproduce this issue, but works as expected from mock and from AppSync console as well. I think that it is possible that you've a client library side error in your project and it is not related to the CLI or AppSync or the generated schema/types.
I've used the following schema and operations to try to reproduce your issue:
type Person @model {
  id: ID!
  name: String!
  ts: AWSTimestamp
}

Operations:
mutation M {
  P1: createPerson(input: {
    id: "P1"
    name:"Person #1"
    ts:<PHONE_NUMBER>
  }) {
    id
    name
    ts
  }
  P2: createPerson(input: {
    id: "P2"
    name:"Person #3"
    ts:<PHONE_NUMBER>
  }) {
    id
    name
    ts
  }
  P3: createPerson(input: {
    id: "P3"
    name:"Person #3"
    ts:<PHONE_NUMBER>
  }) {
    id
    name
    ts
  }
}

query Q {
  listPersons
  (
    filter: {
      ts: {
        lt:<PHONE_NUMBER>
      }
    }
  )
  {
    items {
      id
      name
      ts
    }
  }
}

Get back to us some details about the error where are you seeing it, can it be a client side type error.

Thank you for the response.
I had in my database timestamp elements in Java Timestamp format (in miliseconds), instead of AWSTimestamp format (seconds only).


[FLINK-14762][client] Enrich JobClient API

What is the purpose of the change
This pull request is a rebase on master of #10185 .
We generally enrich JobClient API as described in FLIP-74 as well as let ClusterClient#submitJob returns a CompletableFuture of JobClient.
For now I think we may or may not introduce dedicated tests because the only implementation is a thin wrapper of ClusterClient. Maybe we can defer the test set until other implementation comes because testing a wrapper gains us little.
Another tricky thing is about lifecycle management a.k.a. whether or not close ClusterClient on ClusterClientJobClientAdapter closed. Currently I use a boolean parameter moveOwnship for explicitly setting, but still looking for other solution.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes, it enriches JobClient which is to be public API).
If yes, how is the feature documented? (JavaDocs)

cc @aljoscha @kl0u

Also we could simply return CompletableFuture<Void> from the JobClient.cancel() method, instead of moving classes around. On this, I do not have a strong opinion, but do you think that there is any particular reason why returning an Acknowledge instead of Void?

Hi @TisonKun , thanks a lot for the work. As an overarching comment, I noticed that you add a flag moveOwnership to the ClusterClientJobClientAdapter and this also bubbles up till the ClusterClient.submitJob().
I am wondering if this is needed, and from a conceptual point of view, I lean towards the no. As a first point, I noticed that the only places that this is set to false are the ClientUtils.submitJob... which are mainly used in tests. And second, why not closing the ClusterClient always, when the JobClient closes (which is the responsibility of the call-site), and just let the user decide when to close the job client.
If the user wants to do something with the JobClient, he/she can create a new one (although we still need to figure out how to "retrieve" a jobClient).
WDYT?

Yes I also tend not to do so. At that moment I was a bit delirious for thinking about whether or not close cluster client on job client closed :/
for shutting down things, I think it is still a configurable action whether or not we close cluster client on job client close because cluster client "spawns" job client and maybe we call submitJob multiple times within one cluster client(normally for job management platform). Neither we want to spawn cluster client per job nor we want to close the shared cluster client on job client closed. The point here is "who is responsible for closing cluster client? job client or the caller?"
I push a commit daf85a75b9c24918058b8bfe09416b2828bd02a5 for customizing actions on closed for define such manner while considering code quality. Does it make sense to you?

Also we could simply return CompletableFuture<Void> from the JobClient.cancel() method, instead of moving classes around. On this, I do not have a strong opinion, but do you think that there is any particular reason why returning an Acknowledge instead of Void?

I've ever thought of Void. Void should work well atm. My concern is

If we keep in mind the possibility that a rpc based implementation of JobClient, for current implementation akka doesn't allow null message. Although we don't stick to use akka as rpc implementation, a non-null unit value is better than null representing Void.
Unfortunately Java doesn't have a builtin non-null unit value so that many of Java projects have to implement their own. I think Acknowledge its Flink's unit value which is reasonable to move into flink-core.

Address comment. @aljoscha please take a look about the update as well as my reply above.

cherry-pick from slack channel. feel free to react wherever you like.

Sorry but when rebasing I cannot convince myself about why we introduce a flink-core variant of JobStatus? ClusterClient will return runtime JobStatus while JobClient returns JobStatus. It doesn’t make sense to me for introducing such different.
Runtime version JobStatus doesn’t depend on anything inside runtime but a self-contained enum. Shall we add it into o.a.f.api.common? Different from ClosureCleaner which could be used by connectors I think JobStatus is previously totally internal concept that should not breaks user setups and dependencies if we move it.

I’ve pushed a set of commits that we all agree on. The remain problem is about getJobStatus and getAccumulator
for getJobStatus the main concern is about where JobStatus stays and whether we introduce a variant of JobStatus. My opinion is above.
for getAccumulator the main concern is about whether Flink does unpack job for the user. I think we can do so, but maybe in another pass of pull request so that we firstly move forward this set under consensus.
So my idea is that we commit this set of commit as part 1 of FLINK-14762 and I start a new pull request refactor getAccumulator and then implement its JobClient interface. While let’s align about JobStatus .
Another coin about JobStatus is that we already display this sort of status on WebUI so it is reasonable to be core/common api(at least it is effectively user-facing).

tison 10:48 AM
I narrow the change set to only unwrap accumulator inside client codes. Here is the diff 6d8f1afa7026a6bbab7a3d024fc67b8588e8f522
So the remain concern from my side is about core variant of JobStatus . I will be ok if you can describe how we deal with these two JobStatus in the future.

This looks good for JobStatus now!

I think this is good to merge now! 💐

travis fails unstably on a known issue https://issues.apache.org/jira/browse/FLINK-14894 which cannot be reproduced locally
merging now...
thanks for your review!


[Compute] az sig image-definition create: Add new parameter --architecture to support setting architecture

Feature request: #20001
Description

Waiting to register for the architecture service(Done).
SDK has not yet been released.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute

Private Build

Move to ARM64 feature


mail-notification; remove

Motivation for this change
unmaintained since 2016
Cleanup, see also: #39976

cc @proteansec


CYF-ITP-South Africa Emmanuel| Module-User-Focused-Data Form controls| Week2

Learners, PR Template
Self checklist

[ yes] I have committed my files one by one, on purpose, and for a reason
[ yes] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[yes ] I have tested my changes
[ yes] My changes follow the style guide
[ yes] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

hi Sally I had a huddle sassion with my fellow trainees on Friday, and they said the same thing as you in the comments you made. They said I made a branch inside a branch, I had been trying to fix ever since. So you are suggesting that I delete this pull request and the form control project in these branch and create the correct branch

hi Sally I had a huddle sassion with my fellow trainees on Friday, and they said the same thing as you in the comments you made. They said I made a branch inside a branch, I had been trying to fix ever since. So you are suggesting that I delete this pull request and the form control project in these branch and create the correct branch?

Yeah, there's a bunch of ways to fix this, but for now as you're just learning git, do this

copy your form control folder to your desktop
checkout main
branch from main feature/form-controls
drag your files in from your desktop and commit them
open your PR from your new branch

Make a note in your calendar to come back to this problem in 1 month's time. By then, you will be able to fix it using git cherry-pick https://www.atlassian.com/git/tutorials/cherry-pick /

hi Sally I had a huddle sassion with my fellow trainees on Friday, and they said the same thing as you in the comments you made. They said I made a branch inside a branch, I had been trying to fix ever since. So you are suggesting that I delete this pull request and the form control project in these branch and create the correct branch?

Yeah, there's a bunch of ways to fix this, but for now as you're just learning git, do this

copy your form control folder to your desktop
checkout main
branch from main feature/form-controls
drag your files in from your desktop and commit them
open your PR from your new branch

Make a note in your calendar to come back to this problem in 1 month's time. By then, you will be able to fix it using git cherry-pick https://www.atlassian.com/git/tutorials/cherry-pick /

I was able to open my pull request the right way, now am working on the changes yo  commented on  I will open it once I am done.


runtime: use atomic.Store instead of simple assignment

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
master
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
any
May be it would be better to use atomic.Load here? https://github.com/golang/go/blob/master/src/runtime/mprof.go#L443
Anyway it lookg strange - we use atomic operation to store value and non atomic value to read it.

I agree this is is inconsistent. I've always understood it that StoreAtomic needs to be paired with LoadAtomic for proper visibility. If this code is doing something clever, then it probably needs a nice comment to explain why these operations can be intermixed.
/cc @dvyukov @aclements

I think we need Swap there.

We'd also need an atomic load of mutexprofilerate in sema.go:semacquire1

Hi, if nobody working on this I'll take a look and fix the unpaired atomic operations in package runtime.

Sure, thanks.
Keep in mind that the runtime package is pretty special, and there may be cases where it isn't feasible / desirable to make this fix.  We should probably take it on a variable-by-variable basis.

Kindly paging you @choleraehyq, please rebase and fix conflicts in the CL 65210.

We have only three weeks left before the freeze. @bradfitz do you still consider this risky enough that it should wait for the next release?
/cc @aclements

This is @aclements's call.

In #53821, I am planning to convert atomic fields to runtime/internal/atomic types, which will naturally force all accesses to be atomic and resolve this.


[1.7.10] Extreme log spam when rendering custom armor model on fake player

Probably only an issue on 1.7.10, given the codepath that seems to be at fault only exists on 1.7
Tested with Ears 1.4.4 and 1.4.5
Some mods that add an armor stand (tested with Bibliocraft) use a fake player with a null UUID to render the armor.  If the armor in question includes a piece with a custom model (includes draconic armor from Draconic Evolution, various robes from Thaumcraft), it seems (?) the RenderPlayerEvent.Pre is fired, causing beforeRender to be called with a player whose profile has a null UUID, which is not guarded against and thus NPEs on every frame:
[17:03:13] [Ears lookup thread (null)/INFO] [STDERR]: [java.lang.Throwable$WrappedPrintStream:println:749]: java.lang.NullPointerException
[17:03:13] [Ears lookup thread (null)/INFO] [STDERR]: [java.lang.Throwable$WrappedPrintStream:println:749]: 	at com.unascribed.ears.legacy.LegacyHelper.getSkinUrl(LegacyHelper.java:134)
[17:03:13] [Ears lookup thread (null)/INFO] [STDERR]: [java.lang.Throwable$WrappedPrintStream:println:749]: 	at com.unascribed.ears.legacy.LegacyHelper$2.run(LegacyHelper.java:91)
[17:03:13] [Ears lookup thread (null)/INFO] [STDERR]: [com.unascribed.ears.legacy.LegacyHelper:getSkinUrl:142]: [Ears] Profile lookup failed

This does not affect the actual rendering, the armor displays on the armor stand correctly.

...At least it doesn't crash the game?