pred spec not attr spec in presentation preview predicates

Caused stack trace and fail-out
Signed-off-by: sklump<EMAIL_ADDRESS>

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   89.01%   89.01%
=======================================
  Files         236      236
  Lines       11315    11315
=======================================
  Hits        10072    10072
  Misses       1243     1243


Reflect the VM statuses to the KubeVirtCluster status

What this PR does / why we need it
Be more verbose when VM is not scheduled. Add meaningful reasons and messages to the KubeVirtMachine conditions, to be reflected in the Cluster resources.

[ ] todo: complete unit tests

/ok-to-test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 64 (7.81%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.1%) to 60.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/kubevirtmachine_controller.go
3
4
75.0%

pkg/kubevirt/machine.go
2
60
3.33%

Totals

Change from base Build<PHONE_NUMBER>:
-2.1%

Covered Lines:
954

Relevant Lines:
1590

💛  - Coveralls

/hold
need to complete unit tests

/unhold

One high level comment is that I want to make sure the capi Machine object get's the condition messages from the KubeVirtMachine object.

For this KubeVirtMachine status (only the Reason field get here, without the message):
{
  "conditions": [
    {
      "lastTransitionTime": "2023-12-19T06:36:44Z",
      "message": "0 of 2 completed",
      "reason": "DVNotReady",
      "severity": "Info",
      "status": "False",
      "type": "Ready"
    },
    {
      "lastTransitionTime": "2023-12-19T06:40:55Z",
      "message": "DataVolume capi-quickstart-control-plane-72xx2-capi-quickstart-boot-volume is not running: DataVolume too small to contain image",
      "reason": "DVNotReady",
      "severity": "Info",
      "status": "False",
      "type": "VMProvisioned"
    }
  ],
  "ready": false
}

We get this Machine (capi) status:
{
  "bootstrapReady": true,
  "conditions": [
    {
      "lastTransitionTime": "2023-12-19T06:36:44Z",
      "message": "1 of 2 completed",
      "reason": "DVNotReady",
      "severity": "Info",
      "status": "False",
      "type": "Ready"
    },
    {
      "lastTransitionTime": "2023-12-19T06:36:35Z",
      "status": "True",
      "type": "BootstrapReady"
    },
    {
      "lastTransitionTime": "2023-12-19T06:36:44Z",
      "message": "0 of 2 completed",
      "reason": "DVNotReady",
      "severity": "Info",
      "status": "False",
      "type": "InfrastructureReady"
    },
    {
      "lastTransitionTime": "2023-12-19T06:36:35Z",
      "reason": "WaitingForNodeRef",
      "severity": "Info",
      "status": "False",
      "type": "NodeHealthy"
    }
  ],
  "lastUpdated": "2023-12-19T06:36:35Z",
  "observedGeneration": 2,
  "phase": "Provisioning"
}

What does the corresponding Machine object and MachineDeployment have in it's status for these KubeVIrtMachine conditions?

And the MachineDeployment status is (no reason nor message is reflected here):
{
  "conditions": [
    {
      "lastTransitionTime": "2023-12-19T06:45:42Z",
      "message": "Minimum availability requires 1 replicas, current 0 available",
      "reason": "WaitingForAvailableMachines",
      "severity": "Warning",
      "status": "False",
      "type": "Ready"
    },
    {
      "lastTransitionTime": "2023-12-19T06:45:42Z",
      "message": "Minimum availability requires 1 replicas, current 0 available",
      "reason": "WaitingForAvailableMachines",
      "severity": "Warning",
      "status": "False",
      "type": "Available"
    }
  ],
  "observedGeneration": 1,
  "phase": "ScalingUp",
  "replicas": 1,
  "selector": "cluster.x-k8s.io/cluster-name=capi-quickstart,cluster.x-k8s.io/deployment-name=capi-quickstart-md-0",
  "unavailableReplicas": 1,
  "updatedReplicas": 1
}

Comparing the conditions with the current version (main branch)
capi Machine InfrastructureReady condition (the only change):
Main:
    {
      "lastTransitionTime": "2023-12-19T08:13:21Z",
      "message": "0 of 2 completed",
      "reason": "WaitingForBootstrapData",
      "severity": "Info",
      "status": "False",
      "type": "InfrastructureReady"
    },

PR:
    {
      "lastTransitionTime": "2023-12-19T07:26:28Z",
      "message": "0 of 2 completed",
      "reason": "DVNotReady",
      "severity": "Info",
      "status": "False",
      "type": "InfrastructureReady"
    },

No change in MachineDeployment


EmailVerifier::OutOfMailServersException

Hi I'd like to use your gem, however I am getting the exception mentioned in the title.
Probably I am doing something wrong, but I am not able to find it.
I have put in bit at the end of application.rb
EmailVerifier.config do |config|
config.verifier_email =<EMAIL_ADDRESS>end
when trying to check any email from console I receive:
EmailVerifier::OutOfMailServersException: Unable to connect to any one of mail servers for ...
I did tried to change the config.verifier_email  to my email address, but no lucky.
I am using a MacBook Pro and
ruby 2.0.0p481
gem 'rails', '3.2.18'
Could you help me please?

@luisfernandos
Sorry for replying so late.
I've just tried and was only able to reproduce the issue when trying on my local machine. That most probably was due to the fact that locally, I don't have a public IP. When trying from a publicly reachable server - I was able to get the library to work just fine every single time.
When you're trying to use it from an IP that a server either cannot reach or trust (in any way) - then it returns 421 service not available (connection refused, too many connections) instead of letting you connect.
Please let me know if you'd have any more questions. Also — if the advice above works for you, then would you please go ahead and close the ticket?
Thanks

Hi
Thanks for your response, a friend of mine told me that it didn't work for a localhost, perhaps a comment in your readme would help.
Best regards,
Fernando
----- Original Message -----
From: Kamil Ciemniewski
To: kamilc/email_verifier
Cc: luisfernandos
Sent: Monday, May 25, 2015 10:44 AM
Subject: Re: [email_verifier] EmailVerifier::OutOfMailServersException (#22)
@luisfernandos
Sorry for replying so late.
I've just tried and was only able to reproduce the issue when trying on my local machine. That most probably was due to the fact that locally, I don't have a public IP. When trying from a publicly reachable server - I was able to get the library to work just fine every single time.
When you're trying to use it from an IP that a server either cannot reach or trust (in any way) - then it returns 421 service not available (connection refused, too many connections) instead of letting you connect.
Please let me know if you'd have any more questions. Also — if the advice above works for you, then would you please go ahead and close the ticket?
Thanks
—
Reply to this email directly or view it on GitHub.

Added the info about it in README. Thank you @luisfernandos for pointing this out.


Made a simple change to be able to mark the default assets as loaded.

This should dramatically speed up relaunch times.  If you are operating an existing grid and don't want the default assets being loaded, simply create a new file in the assets folder named AssetSets.xml.loaded
Below you can find the list of ideas for solving this annoyance.  This gives some background into why this solution was chosen.
The last idea is the best one, but is a LOT more complex of a solution.  Someday maybe.
== XML->HashUUID->AssetServer

hash xml file into Hash-style UUID with a special name for possible later cleanup ops and store on asset server.
If store fails (duplicate) then don't reload the data.

Issues:

Requires writing a hasher that does the hash-style UUIDs.  Complex.
Adds MORE ASSETS to the asset server.  Yuck.

== Move the files to an installed folder

Really only need to move the Assets.xml file
Simple move file change.

Issues:

Git now thinks the file's been removed and wants you to commit the change. (critical problem)
Requires the server to have write on the folder, which it might not.

== Rename the Assets.xml file

Simple rename file change.

Issues:

Git now thinks the file's been removed and wants you to commit the change. (critical problem)
Requires the server to have write on the folder, which it might not.

== Use a signpost file (current favorite)

Simple does-file-exist check is only addition to region source.
Signpost can be added to .gitignore

Issues:

Requires the server to have write on the folder, which it might not.  Not too big of an issue: the server will just be slow unles the sysadmin manually puts in the signpost file.
If sysadmin changes any of the default assets he has to

== Make default asset loading not the region's problem

Region gets something that doesn't belong to it taken away.
A special tool would be created for loading in default assets.
Documentation about the change.

Issues:

Most complex change.

This looks to be dependent on my other PR #286
Did you test it with mine?

When we discussed this previously, we talked of moving the whole folder. The reason for this was for the incremental changes. If only the "root" XML file is renamed, it leaves things awkward if someone wants to add one more asset, like one more texture.  The textures subfile will still exist, but adding the asset won't do anything. Unless the original root file is renamed back to it's original name.
I suppose that if that is done, it is not too wasteful to try to add all of the assets back again, because it will only be done once and then the root file will be renamed as done once again.

This wasn't coded with your pr as a dependency.
As to the technique I used, you can see my reasoning above. I pulled up our old conversation and the various ideas discussed then were what I used to create the above list.
Moving or renaming any file that is under source control results in the possibility of committing that change. So instead I took the route of adding a new file that flags the status and modifying the documentation accordingly.

Did you test this at all? Without my change, I don't think LoadDefaultAssets is even called, so I don't see how your new code would even be triggered.

On the technique, if it moved (all) files as completed, we'd need to move the source-controlled location to a different location (perhaps the after-move destination) in order to avoid those issues. On the first run of a new server, to get the assets, that tree could be manually moved to the assets folder and the server run would then put them back in place for source control, once completed.
I was just pointing out there's an alternative, and that moving the single root xml file has some undesirable qualities you didn't mention.  But my concern was with having to add the full set on any change, because using a single file would always load the full set if one asset was added.  But I think that's a weak point since assets are rarely added and it's not a big deal to run the full set when that happens.  So I'm okay with that point, although LoadDefaultAssets is still going to need to be called.

In my configuration, MySQL+WHIP only, this code does execute, and speeds up boot up nicely.
Also, in the current technique I'm not moving or renaming anything, I'm creating a new empty file and checking for its existence.

Ah yes, I spent too much time looking at the notes and not enough looking at the actual code (it's one new file). Looks good, and also +1 for making sure the file create was in an exception handler.
This change won't apply on InWorldz and my test server (where CloudFiles assets are enabled) without #286 also being applied.  However, this PR probably enables that one to be merged, so thanks for the timely PR.


fix(heroku): reverted to docs only install as nerdlet is out of scope for launch

Reverted Heroku to docs link as we haven't modified the nerdlet yet.

The repository has been renamed to newrelic/newrelic-quickstarts. Github will handle routing your remotes to this new url, but we recommend that you update your remote as soon as possible.
NOTE: As part of this change, we have moved all the quickstarts from the /packs directory to the /quickstarts directory. To bring your pull request up to date, please pull in the latest commits from the main branch.
Use the following command to set your new remote:
git remote set-url origin https://github.com/newrelic/newrelic-quickstarts.git

Or with an SSH origin
git remote set-url origin git@github.com:newrelic/newrelic-quickstarts.git


chore(footer): ui changes. Fixes MEMB-432

Fixed the comments on #290
@serge1peshcoff did you do stuff with the CORS proxy already?

@WikiRik the CORS issue should be fixed, yep

@WikiRik can I merge and deploy?

Not sure if the link to Confluence is working now, but there's one way to find out. Let's deploy

and apparently github isn't feeling well as the checks are not passing. let's wait

:tada: This PR is included in version 0.45.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


deprecated inmanta module commit (#5206)

Pull request opened by the merge tool on behalf of #5206

Merged in 12fd6ad4fecf94df49b1eea79a2bfa69f276b38e


Improve robustness of builder (esp. on Windows)

Fixes #6216
See the commit message for the description of this fix + steps to tests. I have checked that the changes work by running them a few times on my Linux system, and over 10 times on a Windows XP box.
If you run botio on this PR, you will probably get the usual case (i.e. Firefox does not exit early, so the pid is known). To test the logic that gets activated when Firefox restarts, I submitted PR #6217, which is identical to this PR except that it includes a commit so that the code always assumes that the pid of the process is unknown (which was causing unreliability issues with our previous test runner).
Test output from #6217:

Output of a full test run, full verbosity: http://<IP_ADDRESS>:8877/bf0d6200942850c/output.txt
Output of a unit test, with reduced verbosity: http://<IP_ADDRESS>:8877/d93ea18447ea488/output.txt (the verbosity was reduced in a second commit, which is separate because it's easier to do git revert [hash] if we ever need to get verbose logging again.)

Thank you for looking into this, and good that you have reverted #6198 here. @brendandahl Could you review this PR?

/botio lint

/botio unittest

/botio fonttest

/botio test


render hundreds separately from minutes/seconds; add performance test

Avoid reformatting and re-rasterizing minutes and seconds on every tick. This shaves off ~30% on the framework side of things according to my testing.
Add a FlutterDriver test that measures the performance of the app.

WARNING: I didn't really test the app thoroughly; things might have broken; also there are a couple of anti-patterns in there, such as the global static list of timer listeners.

@yjbanov Thanks for contributing. I learned a lot from your changes. Also updated the main article to explain them.


License Checkbox (v1.0.0-hotfix)

Describe the bug
The license checkbox doesn't work.
To Reproduce
Steps to reproduce the behavior:

Open the installer
Try clicking the installer checkbox

Expected behavior
Clicking the checkbox should work fine, not just the text.
Screenshots
https://user-images.githubusercontent.com/63931154/125085947-6b69a280-e0cb-11eb-928d-4c9800811e58.mp4
System Information:

OS: Windows

This has been fixed on the dev branch as of 83d0beee8fe87d0ebb6fa92c4bd15c58dfc9ac56.


Filenames with multiple dots lead to compile failure

Hello!
I've been trying out jte and I really enjoy using it :-)
I'm trying to create templates for files but got a compile error for generated jte classes.
jte-classes\gg\jte\generated\subdirectory\Jtehelloworld\txtGenerated.java:2: error: '{' expected
public final class Jtehelloworld.txtGenerated {

I've pushed a project to reproduce the behavior.
I've come to the conclusion, that the problem is the additional . in my template name: helloworld.txt.jte.
There are some workarounds for me, like naming it helloworld.txt or just helloworld.jte etc. but I thought maybe you're interested in supporting this scenario :-)
Other than that, awesome templating engine!

Hi @MarkusAmshove,
thanks for the heads up, I'm so glad you're enjoying jte 👍
And thanks for sharing the project to reproduce your finding! I just pushed a fix for it: https://github.com/casid/jte/commit/5edaf2a905319318a41f72f060af76e5db3a3968
Gonna submit a new release to maven central (1.2.0) within the next hour, including this bugfix.

Released with 1.2.0


Search by tags ?

Could we search by tags just like in the documentation of rediSearch here ?

String fields are indexed as tags when you use Field(index=True). So you're essentially doing tag searches most of the time. For example with this model:
class Adoptable(HashModel):
    name: str = Field(index=True)
    species: str = Field(index=True)
    age: int = Field(index=True)
    weight: float = Field(index=True)
    sex: str = Field(index=True)
    fee: float = Field(index=True)
    children: str = Field(index=True)
    other_animals: str = Field(index=True)
    description: str = Field(index=True, full_text_search=True)

A query like this:
def find_male_dogs():
    print("find_male_dogs:")
    return Adoptable.find(
        (Adoptable.species == "dog") &
        (Adoptable.sex == "m")
    )

Results in the following command:
ft.search :adoptable.Adoptable:index (@species:{dog}) (@sex:{m}) LIMIT 0 10


Merge master into beta

Description
Merge master into beta
Breaking Changes
NA
JIRA Link
NA
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 23.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Syncing latest changes from main for kubernetes-csi-addons

PR containing the latest commits from main branch

Closing this PR, as this was created due to a manual trigger.
A stable 4.17 build will auto-create a new PR.


Update intellisense documentation comments

For PXBLUE-2251

Changes proposed in this Pull Request:

Add intellisense comments where missing for

components
props
functions

Update existing intellisense comments where needed to match more closely with docs
Update some docs to be more consistent

Screenshots:

To Test:

clone the repository
yarn link:components
Open the App.tsx file and start typing out some components.

When you are getting hints for a component, you will see the detailed description
When typing out prop names, you will see detailed descriptions for the props

I think you can insert links to our storybook too. Those JSDocs follow markdown syntax.

I think you can insert links to our storybook too. Those JSDocs follow markdown syntax.

We can do that. The caveat is that our storybook always documents the latest version of the components. So if someone is getting intellisense pop ups from an older version of the library, they could be pointed to documentation that is not accurate for the version of the library they are using.

But I suppose that's true for anyone who comes and reads our documentation at any time anyway. I went ahead and added some links to the docs.


Segmentation fault on recursive association reference

Something like the following:
let(:model) { create(:other_model, association: model) }

produces a segmentation fault. This is on Ruby 2.1.1 and Rails 4.0.3.
Output is a lot of lines that look like this:
/Users/evanhemsley/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rspec-core-2.14.8/lib/rspec/core/memoized_helpers.rb:199:in `block in let'
/Users/evanhemsley/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rspec-core-2.14.8/lib/rspec/core/memoized_helpers.rb:199:in `fetch'
/Users/evanhemsley/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rspec-core-2.14.8/lib/rspec/core/memoized_helpers.rb:199:in `block (2 levels) in let'

-- C level backtrace information -------------------------------------------
zsh: segmentation fault  rspec spec/controllers/admin/users_controller_spec.rb

This is clearly not a correct usage of FactoryGirl, but I think there should be saner failure behavior than a segfault here.

Same story in Ruby 2.2.0.
Repro code for me:
FactoryGirl.define do
  factory :article_subscription do
    article
    user
  end
end

  let!(:article_subscription) { create(:article_subscription, article: article) }

You should open a bug with ruby/ruby. It should not be possible to cause a segmentation fault through plain ruby code.

@ehemsley @olivierlacan to confirm, this is something you can also reproduce without using Factory Girl and instead operating solely within ActiveRecord (or whatever ORM/ODM you're using), correct?
There are also a number of other areas also not preventing a segfault which seem much more like their responsibility (in this case, both the testing framework and ActiveRecord). I don't want to say it in a manner that comes off as "it's not my job", but rather, it's strange that this is even possible.
If it is in fact only reproducible with Factory Girl, any help to nail it down, ballpark-wise, would be helpful. We already attempt to handle self-referential attributes here: https://github.com/thoughtbot/factory_girl/blob/7e2bed5938be2e1314a7df6a647031a47d01c2c8/lib/factory_girl/attribute_list.rb#L57

Even if it is only reproducible in Factory Girl, a segfault is never a library bug, it's a language bug.

Thanks for the pointers and I agree with @sgrif but first I want to narrow down what's causing it so thanks for that @joshuaclayton. :-)

I narrowed down the segfault inside of the RSpec's let! method. An infinite loop happens and I'm pretty sure this is what causes the segfault.

@sgrif @joshuaclayton Thanks to https://github.com/rspec/rspec-core/issues/1787#issuecomment-63564263 I found the Ruby issue for this: https://bugs.ruby-lang.org/issues/9505
You should probably close this issue. :-)


Switch to JUnit version 5 for unit tests

Migrate to JUnit 5. Jonathan has a draft PR that can be used as starting point.
https://github.com/Azure/azure-sdk-for-java/pull/4483

hi @JonathanGiles, could you pls explain briefly what's left to be done here so i can finish it - pls. assign me this task

@mclay This is a relatively big task. For all /sdk/<service>/azure-* libraries, we remove junit 4 and replace it with junit 5. This will require some changes to the tests in some places as the JUnit 4 and JUnit 5 APIs differ somewhat. This could be decomposed into a number of sub-tasks, e.g. firstly focusing on /sdk/core/azure-core and the other core modules. Separate PRs could then be developed for Key Vault, Storage, etc. Because we only focus on the 'next-gen' client libraries, we only care about modules which begin with azure-.
If you're keen to take this on, we would love to accept your pull requests! I've assigned the issue to you.

@mclay just a quick note that this issue doesn't apply to /sdk/storage as storage is using groovy tests and not JUnit

@mclay Let me know if you plan to pick this up and work on it, otherwise I'll reassign to myself or someone else so that we may begin to make this move. Thanks!

Hi @JonathanGiles i am on it and provide the first Bits of it until the End of this Week

Excellent news! Thanks for the update.


Implement bitcoin adapter interface

Adapter functionalities:

Creates single address Native-SegWit Bitcoin account for mainnet and testnet
Implements get balance method using middleware
Implement transfer method and broadcasts the raw transaction using middleware

if you resolve other comments, then you get approval from me


Reduce PEP-8 errors

See https://github.com/Senzing/g2-python/issues/123

Pull requests

https://github.com/Senzing/g2audit/pull/23


[web] Shift key on TextFields is intermittently acting like shift-tab and moving focus up

Difficult to reproduce, but multiple users have experienced this.
I once saw it happen, then resized the window and it went away, but it's hard to reproduce so I can't say for sure.

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.2, on Linux, locale en_US.UTF-8)
    • Flutter version 2.2.2 at /home/steve/snap/flutter/common/flutter
    • Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/steve/Android/Sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /home/steve/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[✓] Android Studio (version 4.2)
    • Android Studio at /home/steve/android-studio
    • Flutter plugin version 57.0.2
    • Dart plugin version 202.8488
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] VS Code (version 1.57.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.23.0

[✓] Connected device (3 available)
    • HD1905 (mobile) • 0fa54b6e • android-arm64  • Android 11 (API 30)
    • Linux (desktop) • linux    • linux-x64      • Linux
    • Chrome (web)    • chrome   • web-javascript • Google Chrome 91.0.4472.114

Hi @sgehrman
Are you using textfield form, do you have multiple textfield in a column? A minimal code sample would be really helpful Also which Linux distro are you using?
Thank you

It's a Form with 3 TextFormFields in a column.
Debian.

HI @sgehrman
Unable to reproduce the issue when running the minimal code sample on Linux distro on the web.
Run the code sample|
Focus a texTextFormField and press the shift key,
Nothing happens as expected

minimal code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: Column(
            children: [
              TextFormField(),
              TextFormField(),
              TextFormField(),
            ],
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on Linux, locale en_US.UTF-8)
    • Flutter version 2.2.3 at /home/taha/Code/flutter_stable
    • Framework revision f4abaa0735 (16 hours ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/taha/Code/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /home/taha/Code/SDK
    • Java binary at: /home/taha/Code/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 12.0.0-1ubuntu1
    • cmake version 3.18.4
    • ninja version 1.8.2
    • pkg-config version 0.29.2

[✓] Android Studio (version 4.2)
    • Android Studio at /home/taha/Code/android-studio
    • Flutter plugin version 58.0.1
    • Dart plugin version 202.8531
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] VS Code (version 1.57.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

It's super hard for me to reproduce too.  I fixed an unrelated bug and posted a new build, I'll let you know if somehow it fixed itself.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


%20 added at the end of URLs

I noticed that %20 are added at the end of URLs, like http://localhost:8080/projects  whereas http://localhost:8080/projects works do you have a workaround or fix for this? TY
Other than that, very nice theme, great work!

Duplicate of #14, #15

Make sure you are using the latest version of portfolYOU.
Everything seems to be working fine here

If the issue still exists, please reopen the issue.

Indeed latest version works well thanks, except for some plugins
Liquid Exception: Liquid syntax error (/site/_includes/elements/github-edit-footer.html line 3): Unknown tag 'github_edit_link' included in docs/documentation/docs.md

Liquid Exception: Liquid syntax error (line 44): Unknown tag 'gist' in /site/docs/_posts/2018-12-10-clean-coding.md

Make sure you are using github-pages gem in your Gemfile.
Run bundle install.
Update repository tag in _config.yml to match the GitHub repository of your source code.


Reformat Model Class

Description
Reformat models to have a different class for each model and use components from sub-methods "Electrolyte", "Interface", etc. Will be improved further by Scott.
Add an "electrolyte current" model with MacInnes + Butler-Volmer.
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #15 into master will increase coverage by 5.82%.
The diff coverage is 94.91%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   87.25%   93.08%   +5.82%
==========================================
  Files          12       13       +1
  Lines         408      506      +98
==========================================
+ Hits          356      471     +115
+ Misses         52       35      -17

Impacted Files
Coverage Δ

pybamm/operators.py
100% <ø> (ø)
:arrow_up:

pybamm/parameters.py
81.69% <100%> (+7.61%)
:arrow_up:

pybamm/simulation.py
91.66% <100%> (ø)
:arrow_up:

pybamm/models/reaction_diffusion.py
100% <100%> (ø)
:arrow_up:

pybamm/solver.py
97.22% <100%> (+0.25%)
:arrow_up:

pybamm/variables.py
100% <100%> (ø)
:arrow_up:

pybamm/models/components/interface.py
100% <100%> (+100%)
:arrow_up:

pybamm/models/components/electrolyte.py
100% <100%> (ø)
:arrow_up:

pybamm/models/electrolyte_current.py
85.36% <85.36%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c36fe...2bdfdfc. Read the comment docs.


Tutorials referencing simulator on incorrect side of screen

In the "Chase the Pizza" tutorial, the instructions ask users to look at the "Game Simulator on the left side of the screen" but the simulator is on the right side of the screen with the design changes:

We may need to look at other tutorials that contain this as it appears in Catch the Football as well.

Duplicate of https://github.com/microsoft/pxt-arcade/issues/4988?


Missing Agents Info in Old Build Dashboard

After deploying app to v2 dashboard, the old dashboard now misses agents info: after clicking agents, no corresponding ip/health info shows up.
It would be handy to keep those info there.

@CaseyHillers Could you please help add that info? cc @godofredoc

duplicate of issue 45549


Deserialization fixes

While running fuzz tests for the snarkOS network layer, I detected a few deserialization-related vulnerabilities that needed to be patched; I planned to finalize them and release the results on Monday, but seeing the extra weekend changes, I decided to be proactive about it and provide the results I have already.
Most of these are either overallocations or unwraps, which will cause a crash when deserializing broken/malicious network messages.
Feel free to adjust the numbers I used, depending on the expected maximum values. I initially thought using Vec::try_reserve or tweaking the allocator would be preferable, but in the end I believe we should instead be imposing limits on a per-case basis.
Supersedes https://github.com/AleoHQ/snarkVM/pull/592 and https://github.com/AleoHQ/snarkVM/pull/609.

Thanks for catching these Lukasz! Looks like we should redesign our serialization infrastructure to account for this.

Alright, this should handle the serialization cases that were caught.

I can confirm that the fuzzing artifacts still pass with these changes :+1:; I'll run the tests a bit more tomorrow just to be safe.


About benchmark results

Amaizing work! How was the benchmark results obtained? Is it just the generation speed measured when the GPU power limited 330W?

Yes. GPU power limit is an unfortunate limitation of the particular hardware setup I'm using - it's not required.


Delete duplicate cacheability.go and tempalteextension.go

replace codegen/pkg/adapter/Cacheability.go with pkg/adapter/config
replace codegen/pkg/template_extension with pkg/template/mixer

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

+1, mixer in the path here feels off. Otherwise LGTM.

Why not //pkg/adapter/template, rename the file extensions.proto - then the import becomes istio.io/mixer/pkg/adapter/template/extensions.proto.

Actually, reading that again, even directly under //pkg/adapter would be fine: istio.io/mixer/pkg/adapter/templateextensions.proto.

Actually, one final thought: should the proto live in the istio/api repo?

Jenkins job mixer/presubmit passed


question

Hi Gregory
Not an issue but a question about an extension.
Would you consider adding an .obj import for importing 3d object ?

Hi, sorry for my late answer,
I don't know if I answer correctly to your demand, but I implemented an OBJ import on the project. You can see it in live on that page :
http://ledefrichoir.com/labo/zdogXperiments/sources/zdog_obj_v3.html
Best regards
Gregory


remove mpf

MPF seems like an unnecessary dependency. While it is present you cannot install the vsix on its own.

While it is present you cannot install the vsix on its own.

Can you provide a little more information about this? We expect this extension to be installable and work on VS 15.6+ with the Web Workload installed (includes C#, web tools, and Razor).

Sure, this is the error i get when it is included:

And it does work without that dependency. I also found other extension online with the same issue, which had to remove this dependency as well.

But maybe i'm missing something ...

Nah, I think I must be the one who's missing something 😆 - if it doesn't work then it doesn't work. Your configuration is supposed to be supported.
I think the problem might be the 15.6 instead of 15.0. I had intended to enforce the 15.6 version requirement, but perhaps that package isn't versioned.
I'll merge your PR right now to unblock folks and see what I can do to get to the bottom of this. Thanks for letting us know about this!


XML decoding speed enhancement

On a large APK I had the problem that AndroidManifest.xml generation took ~1 minute or more because the method to search for class references loops over all classes every time a potential reference is found in the XML.
Instead I added a cache (on-demand initialization) so that we only have to loop one time over all classes now. To reflect changes the cache is deleted after each parse call.
Cache handling is not thread safe as in my tests it seems like resource decoding is not done multi-threaded.

@jpstotz nice improvement, thanks!
I also added a small change to skip this whole method for jadx-cli (attached annotations not needed).


Align kubeconfig resolution with the rest of documentation

It seems that this part has a missing documentation. Here is the reference of kubectl configuration.
https://kubernetes.io/docs/user-guide/kubectl/kubectl_config/

This change is

@cemo thanks for the contribution. Can you sign the CLA when you get a chance? We'll need it before we can merge the PR. Thx


Web - Contact method - Secondary login cannot be deleted for specific account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

 It can be used to login to given account.
Repro for accounts<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I think issue appears when user inputs incorrect magic code 1-2 times when verifying secondary login.
Also repro for this account<EMAIL_ADDRESS>Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/234731581-29f89513-03e6-4478-9812-efa00debd9a9.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

Hmm, I cannot reproduce this at all. Every time I remove a secondary login, it's always gone. Even if I sign back up with it and fail the magic code.
@kbecciv could you try again and let me know what steps I'm missing here?

https://drive.google.com/file/d/1vcS2X8wbo_x0B3n3FDu39Pw3QcF8HW0s/view?usp=drivesdk

Hi @kbecciv I'm going to close. Could you reopen if you still think this is an issue?


Fix remaining markdownlint warnings

This relates to TypeFox/yang-vscode#88

@dhuebner Fixed/suppressed now.


update oauth2

https://pivotal.io/security/cve-2018-1260

The change looks good, however CI is red, and it seems related to this change.
org.cloudfoundry.identity.uaa.oauth.token.Saml2TokenGranterTest > test_no_grant_type FAILED
org.cloudfoundry.identity.uaa.oauth.token.UserTokenGranterTest > test_requesting_client_id_missing FAILED

We have also investigated this CVE previously and found that we were not affected. So there's no urgency behind this bump.

@tnwang thanks.
however for develop you should prio the update story, because dependency scanners (ours and our customers one) get red now.


Handle Dataview property:: breadcrumbs in tasks

Is your feature request related to a problem? Please describe.
I've noticed that Breadcrumbs does not seem to be aware of Dataview property breadcrumbs that are listed inside tasks. For example:
Note B
---
- [ ] this is a task. down:: [[Note C]]
- [x] this is another task. up:: [[Note A]]

In this scenario, I'd like the hierarchy to run Note A -> Note B -> Note C. Currently, it does not. I think this is because Dataview attributes properties in tasks to the tasks themselves (which can be queried separately from notes) and not to their parent note. (Conversely, Dataview attributes properties of a note to all its task children.)
Describe the solution you'd like
I'd like Breadcrumbs to provide an option to attribute a note's tasks' breadcrumbs (i.e., only those in a registered hierarchy) to the note itself when building its graph.
Describe alternatives you've considered
Currently I use a number of nasty DataviewJS blocks to explore my graph and generate tables of tasks derived from breadcrumbs and additional Dataview properties. This works fine for most of my purposes but does not inform the Grid View at the top of each page.
(Side note: I'd love it if I could query implied properties in Dataview too; this would make the DataviewJS code much less nasty. Let me know if this is also worthy of a feature request.)
Additional context
I'm using the latest beta of Breadcrumbs, 4.0.107-beta.

Thanks for the detailed issue!  I thought they used a different syntax for inline-fields.
Breadcrumbs uses whatever dataview gives it, so if those fields aren't used by BC, I suspect DV isn't supplying them

Yes, but they don't show up in the parent page's properties; they're individually attributed to the task objects you'd get from dv.current().file.tasks. I don't know anything about Breadcrumbs' internal architecture but I imagine you'd need to add a few lines in the property discovering code that trawl each page's tasks for properties and attribute them to the page itself.


Add CHANGELOG entry for source maps

Adds a CHANGELOG entry for source maps

https://github.com/alphagov/govuk-frontend/pull/3023

Worth documenting any of the other things we know about?

Source maps only work with Developer Tools™ open
Source maps only work when uploaded together with *.js and *.css files
Source maps useful for precompiled files like govuk/**/*.js UMD bundles (+ CSS, but not Sass)
Source maps might be discarded on build without rollup-plugin-sourcemaps or source-map-loader etc

Note: Our next "build" will include lots of *.map files in package and dist

Worth trying to shuffle this out of "new features" since it's only for developer users?

@romaricpascal Are you happy keeping it as a new feature now we have another one to go with it?

https://github.com/alphagov/govuk-frontend/pull/3053

For 4 and 2, I think it's worth documenting how to "use" the source maps in the frontend guidance. Maybe in these two places:

https://frontend.design-system.service.gov.uk/install-using-precompiled-files/ to explain to serve them alongside the JS files
https://frontend.design-system.service.gov.uk/importing-css-assets-and-javascript/ for a quick note about bundlers?

We could have 2. describe both cases in a source maps section and have 1. just link to it with something like "To help you with debugging we provide source maps that you can serve alongside the JavaScript and CSS files to get clearer information in your browsers developer tools".
I think 1 and 3 are pretty much tackled by the current wording of the changelog, just added a little suggestion that it's for JavaScript and CSS files (to not expect anything from .mjs and .scss files).

For 4 and 2, I think it's worth documenting how to "use" the source maps in the frontend guidance

@romaricpascal Cheers, that's sensible. Think better documentation needs to block the release?

Best practice would be to do the documentation and release them together, but practically speaking it depends on how urgent the release is v whether documentation is essential to understand the change.

I'll merge these notes as source maps are opt-in (optional) but can always add another PR


chapte 6.1.1 Character-level one-hot encoding: the code in the book is different from the code in github, which is right?

the code in the book:
import string
samples = ['The cat sat on the mat.', 'The dog ate my homework.']
characters = string.printable
token_index = dict(zip(range(1, len(characters) + 1), characters))
max_length = 50
results = np.zeros((len(samples), max_length, max(token_index.keys()) + 1))
for i, sample in enumerate(samples):
for j, character in enumerate(sample):
index = token_index.get(character)
results[i, j, index] = 1.
the code in github:
import string
samples = ['The cat sat on the mat.', 'The dog ate my homework.']
characters = string.printable  # All printable ASCII characters.
token_index = dict(zip(characters, range(1, len(characters) + 1)))
max_length = 50
results = np.zeros((len(samples), max_length, max(token_index.values()) + 1))
for i, sample in enumerate(samples):
for j, character in enumerate(sample[:max_length]):
index = token_index.get(character)
results[i, j, index] = 1.

I found this too. The code in the book is wrong. The dictionary should map each character to a number.


fix Carbon parse null as current date for date/timestamp fields

Fixes #4412

PS: previously opened this PR on a separate branch. Had to rename the branch, hence this new PR

I think we could split all those conditions into multiple lines for better readibility.


Add MED wrapper

Hello,
This is the third attempt to add MED format (medformat.org) support into Neo.  After the previous pull request, my colleague Matt Stead and I re-worked the code for determining Neo streams, and addressed all the comments from the second pull request.  We also verified that multiple MED wrappers can point to the same dataset.
Please let us know if there any questions or comments!  Thanks.

Hi @JuliaSprenger!
As always, thanks for the feedback!  I will look into the segfault in the next day or two and try to figure out what is going on.  I do most of my testing on Mac (M1 chip) and everything is passing for me.  Since this appears to be segfaulting on Ubuntu I will try to reproduce the problem there.

Hi @dancrepeau Any news on the segfault? Do you have access to an ubuntu system to test this or is gh actions sufficient for you to tests this?

Hi @JuliaSprenger!
Yes, we tracked down the segfault and fixed it.  The newest dhn_med_py version is 1.1.1 which has the fix in it.  Thank you for being patient!
I will go through the rest of your comments and update the MED wrapper in the near future.
thanks!

Hi @JuliaSprenger,
We fixed the segfault in the dhn_med_py library, and I believe I have made the suggested adjustments to the code.  Both RawIO and IO are passing the tests in my local testing.  Any comments are welcome.  Thanks!

Hi @dancrepeau.
thank you for this.
I made a few comments.
I do not understand totally the neuralynx story of the med format. I let Julia having closer eyes on this part.

Hi @apdavison, as far as I know, it is ready to be merged.  Julia had a question about why MED is using the subset of events that we do (which I think I addressed) and suggested a speed-up for counting the number of events, although the only way I can think to perform that speedup in the parse_header routine would involve duplicating data that is already part of the MedSession python object.
So it's your call - I'm happy with it, and if everyone else is, I'd say let's merge.  Thanks!


Keyword Search

Is there a way for commands trigger upon hearing just a sole word? Like if I want a function to trigger whenever the word 'up' is heard, whether it be 'move up', 'turn up', 'up up up', etc? Other than simply grabbing the potential possibilities and running a for-loop to check the entire array for an instance in the string?

From the doc::
A named variable is a one word variable, that can fit anywhere in your command.
e.g. saying "calculate October stats" will call calculateStats('October');
'calculate :month stats': calculateStats,


Noob - create a Lua/ luajit Docker ?

Hi
please forgive the perhaps basic question, but how do I use this build information to create a Docker container ? Such as..
docker create \
--name Lua \
--network containers \
--restart=always \
--env TZ=Europe/London \
--volume Lua_config:/config \
--volume Lua_data:/date \

and when it’s installed what is the best way to interact with it ?

Hi
please forgive the perhaps basic question, but how do I use this build information to create a Docker container ? Such as..
docker create \
--name Lua \
--network containers \
--restart=always \
--env TZ=Europe/London \
--volume Lua_config:/config \
--volume Lua_data:/date \

and when it’s installed what is the best way to interact with it ?

Hi, just a quick follow up,(4 months on)  any suggestions on the create/compose and what I can set as volumes/environment variables etc ?


JCasC Config Page: Dark Theme is not applied to the non-production-ready warning

What do you mean / expect here?
Currently we aren't changing any of the alert colours from the standard ones
it doesn't seem too bright for me
Do others have any opinion?

I filed #102 and only now discovered this. I think these colors are too bright.

Closing in favour of https://github.com/jenkinsci/dark-theme-plugin/issues/102 which covers all alert colours


Proposal: shorthand record names

Shorthand property names like in javascript
These are a great feature, and maybe elm can steal something from javascript for a change.
Like I see no reason for this overly-verbose syntax:
main : Program Never
main =
    Html.App.program
        { init = init
        , view = view
        , update = update
        , subscriptions = subscriptions
        }

Looks a lot like proposal #1483, and what I said there applies here as well: This is something to discuss on the mailing list, if it hasn't already before. But it's not something to be open as a GH issue here.

Sorry!

Can you tell me how to join the mailing list?

http://elm-lang.org/community

Am 24.09.2016 um 16:47 schrieb Zane Hitchcox<EMAIL_ADDRESS>Can you tell me how to join the mailing list?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Refactor CMake build to be more modular for Linux / MacOS targets

Right now, the Linux (platform/linux/linux.cmake) / MacOS builds (platform/macos/macos.cmake) also build bin, expression-test, glfw, and node targets, which may not be necessary depending on the goal of the build (e.g., building core lib, render tests, etc).
The easiest path foward may be to add additional CMake options to the top-level CMakeLists.txt to enable building those additional platform-specific targets.  I'd suggest that those targest are opt-in rather than opt-out, but that might be a breaking change for some folks.
Something like
option(MBGL_WITH_GLFW "Build with GLFW for Linux / MacOS platforms" OFF)
option(MBGL_WITH_NODE "Build NodeJS bindings for Linux / MacOS platforms" OFF)

MLN_WITH_NODE is now present.


Perform a simple prediction from the tuned and trained best model ?

How can I perform only prediction over a test data and save the output in a csv file ? Sorry if this is too basic a question.

Thank you. Also, the following line
lib.dump_predictions(predictions, output)

seems to save the outputs. What is the path where this goes ?

The path is output / 'predictions.npz' (see this for details). You can print output to see the content of this variable.

Thank you


 and CopyToOutputDirectory not respected

Since we have front-end javascript developers that dont use Visual Studio, we frequently are missing neccesary files from a build/deploy and the csproj is frequently referencing files that have been renamed/moved around etc.
Under ItemGroup, theres an Assets element that supports wildcard inclusion of a directory tree, and displays correctly in VisualStudio2013 (only one I've seen so far) but MSBuild apparently doesnt see these nodes, and none of the assets displayed in Visual Studio are included in a build/deploy.
This needs to be added to the core MSBuild (and back ported to prior versions, at least v12)
This feels like an easy fix depending on how MSBuild enumerates files, and whether that enumeration process is hard coded to only bother looking at  elements or whether the enumeration first builds up a list/array of files to be processed.

Assets is not an item that MSBuild's common targets do anything with. Visual Studio usually displays all items, regardless of what the build process will do with them, but the build process should be treated as canonical.


Problem with dbt templater

Hi, I've been running into a similar issue as this issue on the other vscode-sqlfluff repository. When I set
[sqlfluff]
dialect = snowflake
templater = dbt

inside of my .sqlfluff file I am unable to get the extension to properly lint my files, but when I either leave templater argument blank or set it to Jinja the extension functions properly.
I'm running sqlfluff v. 1.1.0 and sqlfluff-templater-dbt v. 1.1.0 on MacOS. Happy to provide any other information that may be of use.

Yeah, I'm not sure that the dbt templater will work at all for this extension either. Does the formatting also not work? And if formatting does not work, could you try setting sqlfluff.experimental.format.executeInTerminal = true and attempt to format the document again? This setting still has some known bugs, but it runs the sqlfluff command directly on the file instead of passing the text through stdin, which from the other issue sounds like the source of the problem.

Yeah, that doesn't surprise me, but I had hoped maybe that setting would work. I should have some free time in the next week or two to figure out if I can get the extension to work with the dbt templater.

Could you also attempt v0.2.4 and let me know if the linting works for you in that version.

One other thing to note, the linting currently only works when the setting sqlfluff.linter.run is set to onSave

I first also thought there was a problem with vscode-sqlfluff-extended.
With this config
[sqlfluff]
templater = dbt

I get "SQLFluff Formatting Failed." But when I ran sqlfluff lint {path} and sqlfluff fix {path}, I noticed that the problem was due to dbt, not vscode-sqlfluff-extended.
I think ultimately sqlfluff in combination with dbt is prone to fail. The entire complex linting, including dbt references / model dependencies / etc. belongs into a CI/CD pipeline. It would be great if there was an easy to use auto-formatter plugin for vscode (like black code style plugins for python), but sqlfluff might not be able to deliver that (if the code contains dbt specific syntax).


Adding chmod during move to make sure everyone can read the file

Coverage increased (+36.8%) to 92.369% when pulling 929ef5e6921d8528e2f1686c6bb9635a36bd203a on i#1416 into 51516e6de0e02492511620eaba0f0ce715261313 on develop.


Fix flaky brin testcase (#13138)

CI has caught instances of brin_ao regress test failing with following diff:
-WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,<=,inet,<IP_ADDRESS>,100)
 WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,>,cidr,<IP_ADDRESS>,125)
-WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,>,inet,<IP_ADDRESS>,125)
 WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,>=,cidr,<IP_ADDRESS>,125)
+WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,<=,inet,<IP_ADDRESS>,100)
+WARNING:  ORCA did not produce a bitmap indexscan plan for (inetcol,>,inet,<IP_ADDRESS>,125)

Issue appears to be due to dependency of volatile ordering. Testcase orders by "colname" and "typ", but seems like we should add "op" as well.

fix #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Show Line Numbers should be in View menu

Testing #122254

IMO we are quite verbose in placing the "Show Notebook/Cell Line Number". I suggest to remove the "global" toggle command from the editor menu and move it into the global "View"-menu. Then it would be in the same place as "render whitespace" and "render control characters" etc. Tho, it leaves the question why are we having this for notebooks but not for text editors

/cc @alexdima for text editors


Support missing keybindings in PowerShell

Currently various features don't (typically?) work in the prompt on Windows, for example ctrl+backspace to delete a word, ctrl+shift+left to select the word to the left of the prompt etc. We could expose some API in xterm.js to be able to handle this. For example:
Windows:

backspace, delete: Press backspace/delete the number of characters that are selected
ctrl+backspace: Backspace the number of chars in the preceeding word

All platforms:

ctrl+shift+left/right, shift+left/right: Select from the cursor

Perhaps some API like this would be able to handle the selection requests:
// Select from cursor, in the future if we wanted to select from some other origin we
// could add a third parameter
select(direction: 'left' | 'right' | 'up' | 'down', amount: 'word' | 'char'): void;

/cc @sbatten

note that there are also differences based on shell in Windows as well. e.g. ctrl+backspace and shift+left do not work as expected on WSL.

@sbatten not so sure we should do much for different shells, we'd probably need a when clause or something to do it right (which is getting quite complicated).

@Tyriar Fair and agreed. I just want to make sure the changes don't break any experiences in WSL by adding keyboard functionality that didn't exist previously as WSL is something users will expect to work.

Upvoting this, I'd like to see the ability to control backspace and delete a word in the terminal on Windows 10 please. Thank you

Is it possible you guys can take advantage of the work the Console team has done via their APIs? You guys are ahead in a few ways than the Console but having features of the Console lacking in the VSCode terminal would be great. Also, for shells, I think you guys have to account for Sets plus whatever shells might be generated from the new APIs being developed by the Console team to allow various terminals to be ported to Windows that are currently only existing in Linux.

@DarthSpock I'll be working on that soon 😃

Don't suppose it would be too much to ask if we get ColorTool support in VSCode is it? :wink:

@DarthSpock I don't think we'll support cmd.exe ColorTool, but themes can set this and you can override the colors like this: https://github.com/Tyriar/vscode-snazzy/blob/b155eb74098971c3daca73942d7d626c8bcc2ec9/snazzy.json#L2-L22

I think the big thing is being able to read the Themes directory. I wouldn't care so much about having the command controls from ColorTool. I just would like the terminal to accept the Iterm2 schemes (in addition to whatever other themes you want). How that happens is up for interpretation. I can see myself sticking purely to the VS Code terminal without ever touching a real console if we had that type of support.

@DarthSpock I'd rather not add something like that to core, sounds like a good idea for an extension though to convert .itermcolors files into VS Code settings.

I guess the idea of an extension would work. Considering the support comes from MS, I would request that this would be an offical extension from MS to ensure there aren't any loose bugs and would maintain the proper support as ColorTool adapts. Is there a repo for that type of request?

@DarthSpock well I know that the VS Code team won't have any time to work on that as it affects such a small portion of the users:

On windows
Wants support for mac-specific application terminal colors format (not the default terminal)
Doesn't want to use the already existing solution

This probably is the right repo for such a request but we need to close issues like this in order to keep the issues manageable. This is a good candidate for a community extension.

Sounds fair.

Hi @Tyriar, is there any update regarding this issue (typically ctrl+backspace to delete a word)? or any extension that would fix it?
Thanks

@f-roche you could try using Set-PSReadLineOption -EditMode Emacs, that might work.

Some of this works now with the emacs edit mode, you can also configure your own keybindings. Going to close this issue off as it's pretty general, please open focused issues if you cannot configure your own PSReadLine options for this.
Note that you can enable escape sequence logging in Insiders which can tell you what character codes are sent when you type: https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging

Looks like this will now be possible to do when shell integration is enabled using this technique 🎉. Ctrl+space on macOS/pwsh 7:

Default keybindings on macOS:
Basic editing functions
=======================

Key              Function              Description
---              --------              -----------
Ctrl+g           Abort                 Abort the current operation, e.g. incremental history search
Ctrl+o           AcceptAndGetNext      Accept the current line and recall the next line from history after the current line finishes executing
Enter            AcceptLine            Accept the input or move to the next line if input is missing a closing token.
Shift+Enter      AddLine               Move the cursor to the next line without attempting to execute the input
Backspace        BackwardDeleteChar    Delete the character before the cursor
Ctrl+Backspace   BackwardDeleteChar    Delete the character before the cursor
Ctrl+u           BackwardKillLine      Move the text from the cursor to the beginning of the line to the kill ring
Ctrl+x,Backspace BackwardKillLine      Move the text from the cursor to the beginning of the line to the kill ring
Alt+Backspace    BackwardKillWord      Move the text from the start of the current or previous word to the cursor to the kill ring
Escape,Backspace BackwardKillWord      Move the text from the start of the current or previous word to the cursor to the kill ring
Ctrl+c           CopyOrCancelLine      Either copy selected text to the clipboard, or if no text is selected, cancel editing the line with
                                       CancelLine.
Delete           DeleteChar            Delete the character under the cursor
Ctrl+d           DeleteCharOrExit      Delete the character under the cursor, or if the line is empty, exit the process.
Ctrl+k           KillLine              Move the text from the cursor to the end of the input to the kill ring
Alt+d            KillWord              Move the text from the cursor to the end of the current or next word to the kill ring
Escape,d         KillWord              Move the text from the cursor to the end of the current or next word to the kill ring
Alt+r            RevertLine            Equivalent to undo all edits (clears the line except lines imported from history)
Escape,r         RevertLine            Equivalent to undo all edits (clears the line except lines imported from history)
Ctrl+t           SwapCharacters        Swap the current character with the character before it.
Ctrl+_           Undo                  Undo a previous edit
Ctrl+x,Ctrl+u    Undo                  Undo a previous edit
Ctrl+w           UnixWordRubout        Move the text from the cursor to the start of the current or previous whitespace delimited word to the
                                       kill ring
Ctrl+m           ValidateAndAcceptLine Accept the input or move to the next line if input is missing a closing token.
                                       If there are other parse errors, unresolved commands, or incorrect parameters, show the error and
                                       continue editing.
Ctrl+y           Yank                  Copy the text from the current kill ring position to the input
Alt+.            YankLastArg           Copy the text of the last argument to the input
Alt+_            YankLastArg           Copy the text of the last argument to the input
Escape,.         YankLastArg           Copy the text of the last argument to the input
Escape,_         YankLastArg           Copy the text of the last argument to the input
Ctrl+Alt+y       YankNthArg            Copy the text of the first argument to the input
Escape,Ctrl+y    YankNthArg            Copy the text of the first argument to the input
Alt+y            YankPop               Replace the previously yanked text with the text from the next kill ring position
Escape,y         YankPop               Replace the previously yanked text with the text from the next kill ring position

Cursor movement functions
=========================

Key        Function        Description
---        --------        -----------
LeftArrow  BackwardChar    Move the cursor back one character
Ctrl+b     BackwardChar    Move the cursor back one character
Alt+b      BackwardWord    Move the cursor to the beginning of the current or previous word
Escape,b   BackwardWord    Move the cursor to the beginning of the current or previous word
Home       BeginningOfLine Move the cursor to the beginning of the line
Ctrl+a     BeginningOfLine Move the cursor to the beginning of the line
End        EndOfLine       Move the cursor to the end of the line
Ctrl+e     EndOfLine       Move the cursor to the end of the line
RightArrow ForwardChar     Move the cursor forward one character
Ctrl+f     ForwardChar     Move the cursor forward one character
Alt+f      ForwardWord     Move the cursor forward to the end of the current word, or if between words, to the end of the next word.
Escape,f   ForwardWord     Move the cursor forward to the end of the current word, or if between words, to the end of the next word.

History functions
=================

Key       Function             Description
---       --------             -----------
Alt+<     BeginningOfHistory   Move to the first item in the history
Alt+>     EndOfHistory         Move to the last item (the current input) in the history
Ctrl+s    ForwardSearchHistory Search history forward interactively
DownArrow NextHistory          Replace the input with the next item in the history
Ctrl+n    NextHistory          Replace the input with the next item in the history
UpArrow   PreviousHistory      Replace the input with the previous item in the history
Ctrl+p    PreviousHistory      Replace the input with the previous item in the history
Ctrl+r    ReverseSearchHistory Search history backwards interactively

Completion functions
====================

Key   Function            Description
---   --------            -----------
Tab   Complete            Complete the input if there is a single completion, otherwise complete the input with common prefix for all
                          completions.  Show possible completions if pressed a second time.
Alt+= PossibleCompletions Display the possible completions without changing the input

Miscellaneous functions
=======================

Key           Function        Description
---           --------        -----------
Ctrl+l        ClearScreen     Clear the screen and redraw the current line at the top of the screen
Alt+0         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+1         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+2         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+3         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+4         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+5         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+6         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+7         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+8         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+9         DigitArgument   Start or accumulate a numeric argument to other functions
Alt+-         DigitArgument   Start or accumulate a numeric argument to other functions
Ctrl+Alt+?    ShowKeyBindings Show all key bindings
Ctrl+x,Ctrl+e ViEditVisually  Invokes the console compatible editor specified by $env:VISUAL or $env:$EDITOR on the current command line.
Alt+?         WhatIsKey       Show the key binding for the next chord entered

Selection functions
===================

Key              Function             Description
---              --------             -----------
Ctrl+x,Ctrl+x    ExchangePointAndMark Mark the location of the cursor and move the cursor to the position of the previous mark
Shift+LeftArrow  SelectBackwardChar   Adjust the current selection to include the previous character
Shift+Home       SelectBackwardsLine  Adjust the current selection to include from the cursor to the start of the line
Alt+B            SelectBackwardWord   Adjust the current selection to include the previous word
Shift+RightArrow SelectForwardChar    Adjust the current selection to include the next character
Alt+F            SelectForwardWord    Adjust the current selection to include the next word using ForwardWord
Shift+End        SelectLine           Adjust the current selection to include from the cursor to the end of the line
Ctrl+@           SetMark              Mark the location of the cursor
Alt+Spacebar     SetMark              Mark the location of the cursor

Search functions
================

Key        Function                Description
---        --------                -----------
Ctrl+]     CharacterSearch         Read a character and move the cursor to the next occurence of that character
Ctrl+Alt+] CharacterSearchBackward Read a character and move the cursor to the previous occurence of that character

Windows default keybindings:
Basic editing functions
=======================

Key              Function           Description
---              --------           -----------
Enter            AcceptLine         Accept the input or move to the next line if input is missing a closing token.
Shift+Enter      AddLine            Move the cursor to the next line without attempting to execute the input
Backspace        BackwardDeleteChar Delete the character before the cursor
Ctrl+h           BackwardDeleteChar Delete the character before the cursor
Ctrl+Home        BackwardDeleteLine Delete text from the cursor to the start of the line
Ctrl+Backspace   BackwardKillWord   Move the text from the start of the current or previous word to the cursor to the
                                    kill ring
Ctrl+w           BackwardKillWord   Move the text from the start of the current or previous word to the cursor to the
                                    kill ring
Ctrl+C           Copy               Copy selected region to the system clipboard.  If no region is selected, copy the
                                    whole line
Ctrl+c           CopyOrCancelLine   Either copy selected text to the clipboard, or if no text is selected, cancel
                                    editing the line with CancelLine.
Ctrl+x           Cut                Delete selected region placing deleted text in the system clipboard
Delete           DeleteChar         Delete the character under the cursor
Ctrl+End         ForwardDeleteLine  Delete text from the cursor to the end of the line
Ctrl+Enter       InsertLineAbove    Inserts a new empty line above the current line without attempting to execute the
                                    input
Shift+Ctrl+Enter InsertLineBelow    Inserts a new empty line below the current line without attempting to execute the
                                    input
Alt+d            KillWord           Move the text from the cursor to the end of the current or next word to the kill ring
Ctrl+Delete      KillWord           Move the text from the cursor to the end of the current or next word to the kill ring
Ctrl+v           Paste              Paste text from the system clipboard
Shift+Insert     Paste              Paste text from the system clipboard
Ctrl+y           Redo               Redo an undo
Escape           RevertLine         Equivalent to undo all edits (clears the line except lines imported from history)
Ctrl+z           Undo               Undo a previous edit
Alt+.            YankLastArg        Copy the text of the last argument to the input

Cursor movement functions
=========================

Key             Function        Description
---             --------        -----------
LeftArrow       BackwardChar    Move the cursor back one character
Ctrl+LeftArrow  BackwardWord    Move the cursor to the beginning of the current or previous word
Home            BeginningOfLine Move the cursor to the beginning of the line
End             EndOfLine       Move the cursor to the end of the line
RightArrow      ForwardChar     Move the cursor forward one character
Ctrl+]          GotoBrace       Go to matching brace
Ctrl+RightArrow NextWord        Move the cursor forward to the start of the next word

History functions
=================

Key       Function              Description
---       --------              -----------
Alt+F7    ClearHistory          Remove all items from the command line history (not PowerShell history)
Ctrl+s    ForwardSearchHistory  Search history forward interactively
F8        HistorySearchBackward Search for the previous item in the history that starts with the current input - like
                                PreviousHistory if the input is empty
Shift+F8  HistorySearchForward  Search for the next item in the history that starts with the current input - like
                                NextHistory if the input is empty
DownArrow NextHistory           Replace the input with the next item in the history
UpArrow   PreviousHistory       Replace the input with the previous item in the history
Ctrl+r    ReverseSearchHistory  Search history backwards interactively

Completion functions
====================

Key           Function            Description
---           --------            -----------
Tab           Complete            Complete the input if there is a single completion, otherwise complete the input with
                                  common prefix for all completions.  Show possible completions if pressed a second time.
Ctrl+@        MenuComplete        Complete the input if there is a single completion, otherwise complete the input by
                                  selecting from a menu of possible completions.
Ctrl+Spacebar MenuComplete        Complete the input if there is a single completion, otherwise complete the input by
                                  selecting from a menu of possible completions.
Shift+Tab     TabCompletePrevious Complete the input using the previous completion

Miscellaneous functions
=======================

Key           Function              Description
---           --------              -----------
Ctrl+l        ClearScreen           Clear the screen and redraw the current line at the top of the screen
Alt+0         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+1         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+2         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+3         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+4         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+5         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+6         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+7         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+8         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+9         DigitArgument         Start or accumulate a numeric argument to other functions
Alt+-         DigitArgument         Start or accumulate a numeric argument to other functions
PageDown      ScrollDisplayDown     Scroll the display down one screen
Ctrl+PageDown ScrollDisplayDownLine Scroll the display down one line
PageUp        ScrollDisplayUp       Scroll the display up one screen
Ctrl+PageUp   ScrollDisplayUpLine   Scroll the display up one line
Ctrl+Alt+?    ShowKeyBindings       Show all key bindings
Alt+?         WhatIsKey             Show the key binding for the next chord entered

Selection functions
===================

Key                   Function            Description
---                   --------            -----------
Ctrl+a                SelectAll           Select the entire line. Moves the cursor to the end of the line
Shift+LeftArrow       SelectBackwardChar  Adjust the current selection to include the previous character
Shift+Home            SelectBackwardsLine Adjust the current selection to include from the cursor to the start of the
                                          line
Shift+Ctrl+LeftArrow  SelectBackwardWord  Adjust the current selection to include the previous word
Shift+RightArrow      SelectForwardChar   Adjust the current selection to include the next character
Shift+End             SelectLine          Adjust the current selection to include from the cursor to the end of the line
Shift+Ctrl+RightArrow SelectNextWord      Adjust the current selection to include the next word

Search functions
================

Key      Function                Description
---      --------                -----------
F3       CharacterSearch         Read a character and move the cursor to the next occurence of that character
Shift+F3 CharacterSearchBackward Read a character and move the cursor to the previous occurence of that character


chore: Update test environments

Do the following:
* Use python 3.5 in lieu of 3.4 as the "default" py3k version.
* Explicitly set basepython for all environments so the right
  version is used outside of travis.
* Show missing lines when test coverage fails
* Add ujson test environments to check

Current coverage is 100% (diff: 100%)

Merging #971 into master will not change coverage

@@           master   #971   diff @@
====================================
  Files          31     31
  Lines        2019   2019
  Methods         0      0
  Messages        0      0
  Branches      328    328
====================================
  Hits         2019   2019
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update a61e6d2...9d2d46d


Arbitrary URL installs

I think it would be useful to consider installation of arbitrary URLs.
At the moment we install URLs as packages, with an optional subpath which is looked up in exports.
But when users do know the exact internal subpath, it can be useful to think in terms of installing a full module path.
Strictly speaking this isn't an install operation, it's more of an add operation. But I think treating it as an install makes sense from an end-user perspective to consider eg:
jspm install react app=./src/app.js external=https://cdn.com/external/module.js

The steps required would be:
URL install steps

If the install ends in a / treat that as the enforced package boundary to install and stop
If the install does not end in a /, determine the package boundary using the normal package boundary detection algorithm.
Skip exports resolution entirely (i.e. the path within the package boundary is not what we call the subpath), instead we jump straight to the later phase in resolution in treating this as the fully resolved module URL.
Like we do in decomposition, if possible decompose that mapping into exports when forming the saved primary resolution, thereby deducing the subpath only at this stage (exports subpath).

I think it's a nice ease-of-use feature to have for those just wanting basic import map management, and now that decomposition is clever enough to handle these kinds of things I think it could even work quite intuitively.

A way to cheat in the above could be to make this a CLI-only feature that instead takes the following steps:

Write the URL mapping into the "imports" overriding whatever is there
Perform a normal install operation, where the decomposition on initialization should handle the setup correctly.

Yeah, I started trying to tackle this at the generator level but it's a bit gnarlier than I expected (I mistook installSubpath for "already resolved subpath"). So I think I'm going to take the cheat approach for now.

...but I think an approach that'll work in the generator is to expand the InstallTarget type to be a union of the current { pkgTarget, installSubpath } type and a URL, and then implementing the logic in the OP in the installer for URL targets.


Code42/chore update py42

Lots could still be refactored here.
The tests are passing!
The linter is passing!
Looking for suggestions of what all we want to include in this update.
Note: Look at other Packs to see the template we are supposed to follow... This code has to follow a really strict linter, so formatting feedback might not be necessary. What I did is first run it through out linter and then theirs, that way, we got the Union of the two.
Make sure to read this if you plan on cloning thishttps://confluence.corp.code42.com/display/LS/Code42+for+Cortex+XSOAR
Here is XSOAR code guidelines we have to follow:
https://xsoar.pan.dev/docs/integrations/code-conventions

@unparalleled-js the above is what all stood out to me right away, there are definitely refactoring opportunities to do at your discretion which mostly would just breaking things up into smaller pieces like you did very well in some places already
it also looks like py42 didn't get updated properly somehow because im still seeing a fair amount of references to function names/parameters that I know have changed

Haven't fully tested everything yet but have gotten 3 or 4 commands to work both with sdk and in the UI for xsoar, so using the updated py42 for sure now

I've got another branch coming with like 5 new commands, so I'd like to get the upgrades / refactors merged in.


Glue Table for WAF Access Logs is missing some of the log fields (e.g. labels)

Is your feature request related to a problem? Please describe.
The Glue Table created for the GlueWafAccessLogsTable does not contain the newer fields for:

labels
captcharesponse
challengeresponse
ja3Fingerprint

These are useful fields for querying and debugging rules, especially the labels struct.
Describe the feature you'd like
Add the missing fields to the GlueWafAccessLogsTable resource in the aws-waf-security-automations-firehose-athena.template so we don't need to customize the solution in order to get the extra fields when debugging rules.
Additional context
See Creating a table for AWS WAF logs without partitioning for full set of fields

Hi @m-davison , thanks for your enhancement request. Could you provide the details of your use case and how you want to query those fields, etc.?

@m-davison Currently this is not in the scope of the out-of-box solution as the main purpose of the log analysis feature is to automate detecting and blocking common attacks via a built-in Lambda or Athena log parser using necessary fields instead of bringing the whole data. We can add your request to our backlog, but in general if you have specific needs like this, we recommend you to customize the source code to get fast resolution.

No worries... Thanks @WillAWS ... I have customised it, just thought I'd raise it in case it could be of use to others too


refactor(rust): remove usage/mention of long tests env var

Working on assigned issue - #4830
Current behavior
As described in issue #4830, in the past there was a usage of the LONG_TESTS env variable, currently its no longer needed as there are no long bats tests.
Proposed changes
BATS.md:

Removed mention of LONG_TESTS env variable
Removed sentance "that don't take too long" that points that there are longer tests.
orchestrator.bash:
Removed helper function "skip_if_long_tests_not_enabled()"

Checks

[X] All commits in this Pull Request are signed and Verified by Github.
[X] All commits in this Pull Request follow the Ockam commit message convention.
[X] I accept the Ockam Community Code of Conduct.
[X] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@etorreborre new PR, sorry for the trouble.


Add documentation update to cross-link info between Getting Started and CLI reference

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2645
Originally created by @tayloramurphy on 2021-03-15 15:13:01

Cross link info on the excludes selection and how to remove. https://gitlab.com/meltano/meltano/-/issues/2638#note_528335663

View 3 previous comments from the original issue on GitLab


Step 6

Hello, when I check the 'Read Directory Data' the dialog asks me to provide 'Client Secret' and the documentation does not explain how to create/get it. Please revise the documentation.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee85b906-392c-ae31-5c4c-85ba33b6f601
Version Independent ID: f6075f0e-e47f-7c3a-3844-90a9f58b629f
Content: Adding an Azure Active Directory by using Connected Services in Visual Studio
Content Source: articles/active-directory/develop/vs-active-directory-add-connected-service.md
Product: visual-studio-dev15
GitHub Login: @ghogen
Microsoft Alias: ghogen

@anz1e Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#in-progress
Looking at this now. Yes, I think I should add a clarification here.

@anz1e is this still a problem?  I just went through the steps and did not see any dialog when checking the "Read Directory Data" box.

#please-close
If this is still an issue, please reopen.

@anz1e We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Message versioning

This PR contains proposition on how to split messages and how to support different versions of protocol

@adamsmo code looks good so far (still looking at it). Besides that, is there any easy way to test older versions compatibility? Maybe we can encode with other clients old versions messages and make sure we can decode them. What do you think?

@AlanVerbner encoding and decoding are same for all messages despite version, what we can do is try to decode for example NewBlockHashes with PV61 and PV62 since this message changed, I can add test for that, did not done it because it was only proposal

@adamsmo yes...NewBlockHashes is the one that has changed so probably it's a good idea to have tests for different versions. Also BlockHashesFromNumber is PV61 only and it seems not to be implemented...do you think we should add it now or maybe when we focus on nodes sync?

we can add this one now

@AlanVerbner / @mcsherrylabs
I pushed unit tests and added constant for 0x10


how could i debug the source code in vscode?

how could i debug the source code in vscode?

Please submit support requests and questions to StackOverflow using the tag [webpack]. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.


Whitelists on cardinality alarms

Could anyone provide any information on implementing whitelists into my yaml file?
name: Port Scan Test alarm
timestamp_field: "@timestamp"
timestamp_type: unix_ms

type: cardinality
query_key: [sourceIPv4Address, destinationIPv4Address]
cardinality_field: "destinationTransportPort"

max_cardinality: 70

 minutes: 10

filter:
- query:
   match:
       packetDeltaCount: "2"

- "email"

email:
- "###########"

for example i'd like
Whitelist: sourceIPv4Address <IP_ADDRESS>, <IP_ADDRESS>
I'm running elasticsearch 5 if that effects anything?

Add this to your filter
filter:
- query:
     query_string:
        query: "NOT sourceIPv4Address: <IP_ADDRESS> AND NOT sourceIPv4Address: <IP_ADDRESS>"

You can do regular expressions too. See https://www.elastic.co/guide/en/elasticsearch/reference/5.0/query-dsl-query-string-query.html

@Gee94
Just in case if you want to maintain a separate list of IP address to whitelist you can use something like below.
name: Port Scan Test alarm
timestamp_field: "@timestamp"
timestamp_type: unix_ms

type: cardinality
query_key: [sourceIPv4Address, destinationIPv4Address]
cardinality_field: "destinationTransportPort"

max_cardinality: 70

 minutes: 10

import:
  - filter-whitelist-ip

filter:
- query:
   match:
       packetDeltaCount: "2"

- "email"

email:
- "###########"

In  - filter-whitelist-ip
cat filter-whitelist-ip
filter:
- query:
     query_string:
        query: "NOT sourceIPv4Address: (<IP_ADDRESS> OR <IP_ADDRESS> OR <IP_ADDRESS>)"

The below filter will whitelist the entire 10.x/8 subnet range
   - query:
        query_string:
          query: "NOT srx-source-address: /10\\..*/"

Hi Guys, Thanks for getting back to me, @Qmando that worked great thank you.
@sathishdsgithub
AttributeError: 'list' object has no attribute 'startswith'
did you come across the above error before?


A toastcontainer.razor is added to the project

Which gives compiling errors. To reproduce, remove the project dependency and try add the nuget as dependency.

Thanks for reporting this: obviously I've not been smart enough to test the nuget package after these pretty big changes. I just pushed a new package version which does not include the razor files. Can you please test it when you'll have a chance?
Thanks again!

Indeed it made it work 👍


Add tas-client license

Similar to #26193; the version had not been harvested. The harvest finally updated today and came back with the declared as MIT. I will close this PR since it is no longer needed. Thank you!
https://clearlydefined.io/definitions/npm/npmjs/-/tas-client/0.2.33


Handle ec2 security groups with empty firewall rules.

This code change will handle the case where an ec2 security group is defined with empty firewall rules.
Fixes #4359

@matthewd and/or @Fryguy please review.

Updating the parser level to avoid putting the empty firewall rules found in a security group into the hash seems like picking the fruit at the top of the tree to me. Building a test case would also be problematic. That said I'd be glad to do it if you feel it is worth the investment. Let me know and thank you again.

So, it's the parser's job to create the correct set of data.  If it's putting invalid data in, then it needs to be fixed.  If we add in the safety net in the save_inventory code, that feels more like a bandaid to me.

Also, for testing should be able to just hit the parse method directly, much like we do in a few other parser specs.

@Fryguy OK Thanks. In thinking about this more I realize the value of your perspective. I'm going to investigate more...

@jvlcek Please rebase and push again

I will post a new PR with the solution recommended by @Fryguy. Closing this one.


Performance of ResNet50 on ImageNet

Hi, thanks for the nice project. I noticed your paper achieved a 73.69 accuracy on ImageNet with ResNet50, which is much worse than reported by Keras https://keras.io/api/applications/ (74.9, 76.0 for v2) and PyTorch (76.15). I wonder does this mean Ranger cannot achieve as high accuracy as officially reported with SGD? Or is it caused by other settings are different? If so, how does ranger compare to the best of SGD in a fair setting?

Hi @juntang-zhuang,
In our paper, we only trained 60 epochs due to the cost of training.  Typically people train 200 - 300 or so epochs on ImageNet if the goal is to maximize the final model accuracy.
In our case, our purpose was to compare AdamW and Ranger21 optimizers, head to head, with all other variables the same - i.e. straightforward set of transformations, and spending < $1K on training (i.e. fixed compute budget).
Thus, the only takeaway from our paper is that Ranger21 outperforms AdamW assuming all other variables are identical (same transformations, same epochs total training).
It says nothing about Keras results, Pytorch results, or SGD results as we would need to replicate the same total number of epochs and augmentation pipeline done in those papers, while training with Ranger21, to do a direct apple->apple comparison.
Hope that helps!
Less


Parameters

With user-editable variables we have a hacky way of inputting parameters, but we can do better. My idea of a parameter is basically a Variable that you can override from the GUI if necessary with support for some special behaviour (like inheriting the previous value for future runs).

We should also support a variety of kinds of parameters, not just numbers and strings but also enums and various ROIs.
Example from an earlier attempt that I never completed: