fix: go back to std::sync::Mutex

Turns out #174 was wrong, as the alternative required sprinkling block_on which made the whole thing worse. We shouldn't risk a deadlock with the mutex as we are not (can not) holding it across awaits.
Unwrap as we are not expecting subscriptions to panic and poison the mutex.

I heard you like panics, so I put a panic inside your panic so you can panic while you panic.

Well, if there was the first panic then the second on drop would be quite expected. Do not quite understand where the first happens though to poison the lock, unless this was a the flaky which is being fixed in #297?

bors r+


feat: add transactions.mempool.lockedTransactions and chainlocks.blockHeight stats

Issue being fixed or feature implemented
Add basic lockedTransactions count and chain locked block height to stats
What was done?
How Has This Been Tested?
Will be tested once this has a docker image
Breaking Changes
Checklist:
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Guix Automation has began to build this PR tagged as v21.1.0-devpr6237.ab3598b1. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.1.0-devpr6237.ab3598b1. The image should be on dockerhub soon.

Guix Automation has began to build this PR tagged as v21.1.0-devpr6237.763e4fcc. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.1.0-devpr6237.763e4fcc. The image should be on dockerhub soon.

Guix Automation has began to build this PR tagged as v21.1.0-devpr6237.63241c25. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.1.0-devpr6237.63241c25. The image should be on dockerhub soon.

Guix Automation has began to build this PR tagged as v21.1.0-devpr6237.2f26f788. A new comment will be made when the image is pushed.

Applied

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.1.0-devpr6237.2f26f788. The image should be on dockerhub soon.

pls see 7aa0a481243f153ce5c208077274adfe731a81c6 + clang format is complaining

Guix Automation has began to build this PR tagged as v22.1.0-devpr6237.3e524228. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6237.3e524228. The image should be on dockerhub soon.

Guix Automation has began to build this PR tagged as v22.1.0-devpr6237.35745503. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6237.35745503. The image should be on dockerhub soon.

Guix Automation has failed due to the HEAD commit not being signed by an authorized core-team member. Please rebase and sign or push a new empty signed commit to allow Guix build to happen.


Validation: multiple meta-attribute issues

Fixes ONLY the issues with meta-attributes.
This PR fixes issues in 6 files.

Global effort to fix build validation errors
@dougeby
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit 4a833e7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/virtualmachines.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/storage-file-share-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-internal-avro-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-queue-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/traffic-manager.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/verticals-agrifood-farming-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/virtualmachines.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 12, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'compute'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/preview/storage-file-share-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.
Line 22, Column 78: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 22, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/files/storage-files-introduction' will be broken in isolated environments. Replace with a relative link.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 31, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 97, Column 15: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 200, Column 184: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/csharp/language-reference/' will be broken in isolated environments. Replace with a relative link.
Line 544, Column 146: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/storage-internal-avro-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.

docs-ref-services/preview/storage-queue-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.
Line 17, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 17, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/queues/storage-queues-introduction' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 74, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 12: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 458, Column 147: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/traffic-manager.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ramyar' is not a valid Microsoft alias.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9cd3733:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/preview/storage-file-share-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-internal-avro-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-queue-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/verticals-agrifood-farming-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/traffic-manager.md
:white_check_mark:Succeeded
View (azure-java-preview)

docs-ref-services/preview/virtualmachines.md
:white_check_mark:Succeeded
View (azure-java-preview)

docs-ref-services/preview/storage-file-share-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.
Line 22, Column 78: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 22, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/files/storage-files-introduction' will be broken in isolated environments. Replace with a relative link.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 31, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 97, Column 15: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 200, Column 184: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/csharp/language-reference/' will be broken in isolated environments. Replace with a relative link.
Line 544, Column 146: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/storage-internal-avro-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.

docs-ref-services/preview/storage-queue-readme.md

Line 6, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'amishra' is not a valid Microsoft alias.
Line 17, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 17, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/queues/storage-queues-introduction' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 74, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 12: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 458, Column 147: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/verticals-agrifood-farming-readme.md

Line 32, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 32, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3117aa3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/preview/storage-file-share-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-queue-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/verticals-agrifood-farming-readme.md
:bulb:Suggestion
View (azure-java-preview)
Details

docs-ref-services/preview/storage-internal-avro-readme.md
:white_check_mark:Succeeded
View (azure-java-preview)

docs-ref-services/preview/traffic-manager.md
:white_check_mark:Succeeded
View (azure-java-preview)

docs-ref-services/preview/virtualmachines.md
:white_check_mark:Succeeded
View (azure-java-preview)

docs-ref-services/preview/storage-file-share-readme.md

Line 22, Column 78: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 22, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/files/storage-files-introduction' will be broken in isolated environments. Replace with a relative link.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 31, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 97, Column 15: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 200, Column 184: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/csharp/language-reference/' will be broken in isolated environments. Replace with a relative link.
Line 544, Column 146: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/file-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/storage-queue-readme.md

Line 17, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 17, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/queues/storage-queues-introduction' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 24, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 74, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.
Line 92, Column 12: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 458, Column 147: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/queue-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/verticals-agrifood-farming-readme.md

Line 32, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 32, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


robotlegs.org domain expired!

Can this be restored? Is there anything the community can do to help?

Ah, thanks! Seems to be a stuck payment with my provider.. Taking a look now

wow, that took way longer than expected!


support target arm

minor change: the fixed type 'u64' is replaced by type definition from target lib

Thanks!


Latest dev release not responding to MQTT messages.

I have built the latest dev release and have no errors.
My MQTT broker is installed on a Raspberry PI.
I can see messages the RFID system is transmitting in the broker window and also on the serial interface from the esp-rfid.
The esp-rfid does not respond to any received messages.
Following screenshot shows the settings,
my broker is at <IP_ADDRESS> and the esp-rfid at <IP_ADDRESS>
The following command
mosquitto_pub -h <IP_ADDRESS> -t maindoor -m '{"doorip":"<IP_ADDRESS>:,"cmd":"opendoor"}'
is captured in a window monitoring MQTT messages but nothing is output from the esp-rfid either to the broker or on the serial link.
Broker output:
{"type":"heartbeat","time":1651689771,"uptime":8149,"ip":"<IP_ADDRESS>","hostname":"esp-rfid"}
Client (null) sending PINGREQ
Client (null) received PINGRESP
Client (null) sending PINGREQ
Client (null) received PINGRESP
Client (null) received PUBLISH (d0, q0, r0, m0, 'maindoor', ... (42 bytes))
{"doorip":"<IP_ADDRESS>:,"cmd":"opendoor"}
Client (null) sending PINGREQ
Because I have built a debug release I would expect to see some output due to the following
`void onMqttMessage(char *topic, char *payload, AsyncMqttClientMessageProperties properties, size_t len, size_t index, size_t total)
{
size_t n = 0;
size_t i = index;
#ifdef DEBUG
Serial.print("[ INFO ] onMqttMessage: ");
#endif
while(n < len) {
mqttBuffer[i] = payload[n];
n++;
i++;
}
if(index + len == total) {
mqttBuffer[i] = '\0';
} else {
return;
}
#ifdef DEBUG
Serial.print("[ INFO ] JSON msg: ");
Serial.println(mqttBuffer);
#endif
`
I added the “OnMqttMessage” debug line.
I thnik it was a clean build, i.e. no previous RFID builds in my environment.
It must be something I am doing, but I cannot see what!
Any ideas as to what I can try ?
Steve Gale

you have to send the commands on the cmd queue and he writes on the send queue

the dev I've been using for months and it works perfectly, it doesn't respond to you because you write the command on the wrong queue, try this:
mosquitto_pub -h <IP_ADDRESS> -t maindoor/cmd -m '{"doorip":"<IP_ADDRESS>:,"cmd":"opendoor"}'
and the same goes for the messages he writes go to the send sub-queue
example: mosquitto_aub -h <IP_ADDRESS> -t maindoor/send

Adding /cmd as suggested above solves this issue so it can be closed.
Now go to look at getuserlist, it seems to stop after 11 users but does not crash

I have finally managed to test it and you are correct, thanks for response
Steve
On Wed, 15 Jun 2022 at 17:39, giutrec @.***> wrote:

the dev I've been using for months and it works perfectly, it doesn't
respond to you because you write the command on the wrong queue, try this:
mosquitto_pub -h <IP_ADDRESS> -t maindoor/cmd -m '{"doorip":"<IP_ADDRESS>
:,"cmd":"opendoor"}'
and the same goes for the messages he writes go to the send sub-queue
example: mosquitto_aub -h <IP_ADDRESS> -t maindoor/send
—
Reply to this email directly, view it on GitHub
https://github.com/esprfid/esp-rfid/issues/505#issuecomment-1156695126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABI2YS22K44NEL5QQEFRI5DVPIBL5ANCNFSM5VC3L5VA
.
You are receiving this because you authored the thread.Message ID:
@.***>


v2 View drawing is forcing to always calling only the GetNormalColor ()

I think this limiting the views that want to call the GetFocusColor () when they are focused. Also the Clear is always forcing to call the GetNormalColor () even if a view set another attribute before clearing.
@tig thoughts.

We should address this in https://github.com/gui-cs/Terminal.Gui/issues/2381.
Adding it as a requirement and closing this issue.


Improve the logging with PII information - as in rejectDeferredRealize

Right now, we omit the entire error message if it containsPII. We need to preserve the part of the error thats not PII.
Also, the PII information is removed from the Error string but it is still present in the call stack. It should be removed from the call stack as well.

Riffing on Curtis's comment, to avoid duplication maybe the PII is what goes in a separate field on the error object, and it's always removed before logging.  I think we can upgrade the CustomErrorWithProps class to support this kind of thing safely.

Riffing on Curtis's comment, to avoid duplication maybe the PII is what goes in a separate field on the error object, and it's always removed before logging.  I think we can upgrade the CustomErrorWithProps class to support this kind of thing safely.

Moving to November to take pressure off finishing this month, per conversation with Si and Curtis.

Also, the PII information is removed from the Error string but it is still present in the call stack

This is covered by #3755

Information added to the remote channel context telemetry regarding the data store being loaded in can also be potential PII and would need to be stripped out prior to 3P objects being loaded in
https://github.com/microsoft/FluidFramework/pull/4451

@chensixx - FYI I'll take this one from here, this topic has been coming up a bunch recently and I have several things in mind to do here. I'll put you on the PR though since we had discussed this area together!

Another item to consider similar to #3755 that was duped in here, is when the error.message may contain PII (e.g. potentially IP addresses from network errors).

Another item to consider similar to #3755 that was duped in here, is when the error.message may contain PII (e.g. potentially IP addresses from network errors).

Moving to Feb - work in privacy domain is a must for GA.

Moving to Feb - work in privacy domain is a must for GA.


[FEATURE] public Raise functionality for EventInstancer

Is your feature request related to a problem? Please describe.
It is not possible to raise an EventInstancer event through the editor
Describe the solution you'd like
It would be interesting if EventInstancers behaved just like regular events even more so if it was possible to create event instancers with custom logic.
Describe alternatives you've considered
Creating a Raise() and Raise(T item) in the base event instancer would solve this issue

Thanks for submitting this issue!
So from my understanding the changes needed are the following:

Add a Raise() method and Raise(T item) method for the base event instancer.
Add a Raise button and a Inspector Raise Value field to custom editor for Event Instancers.

Am I missing or missunderstanding anything?

Did not think about the custom editor Raise Button and Value, can also add that to the PR I submitted

Closed by #172


[bugfix] turn off mongodb auto cast ObjectID

Coverage decreased (-0.2%) to 91.311% when pulling e42b7e67c321af246577c4e9483098bf3a260277 on ban-castIds into adee4cec43669cbda5d3c67e00e7278a2f6142a7 on master.

Coverage decreased (-0.2%) to 91.311% when pulling e42b7e67c321af246577c4e9483098bf3a260277 on ban-castIds into adee4cec43669cbda5d3c67e00e7278a2f6142a7 on master.

Coverage decreased (-0.2%) to 91.311% when pulling e42b7e67c321af246577c4e9483098bf3a260277 on ban-castIds into adee4cec43669cbda5d3c67e00e7278a2f6142a7 on master.

ok


Stop asking users to install ipykernel on autostart

only do it when a cell is ran.
For #5368

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #5440 (4a7fc7f) into main (54bc65d) will decrease coverage by 0%.
The diff coverage is 100%.

:exclamation: Current head 4a7fc7f differs from pull request most recent head 55b6351. Consider uploading reports for the commit 55b6351 to get more accurate results

@@          Coverage Diff          @@
##            main   #5440   +/-   ##
=====================================
- Coverage     73%     73%   -1%
=====================================
  Files        401     401
  Lines      26584   26584
  Branches    3880    3880
=====================================
- Hits       19510   19472   -38
- Misses      5459    5497   +38
  Partials    1615    1615

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)

.../datascience/interactive-common/interactiveBase.ts
69% <100%> (-2%)
:arrow_down:

...datascience/interactive-common/notebookProvider.ts
81% <100%> (ø)

...ient/datascience/interactive-ipynb/nativeEditor.ts
69% <100%> (-2%)
:arrow_down:

...nt/datascience/jupyter/kernels/kernelSelections.ts
50% <0%> (-45%)
:arrow_down:

...t/datascience/jupyter/jupyterInvalidKernelError.ts
66% <0%> (-34%)
:arrow_down:

src/client/datascience/jupyter/jupyterSession.ts
77% <0%> (-7%)
:arrow_down:

...rc/client/datascience/notebookStorage/baseModel.ts
74% <0%> (-6%)
:arrow_down:

...science/jupyter/kernels/kernelDependencyService.ts
86% <0%> (-4%)
:arrow_down:

src/client/common/errors/errorUtils.ts
71% <0%> (-4%)
:arrow_down:

... and 19 more


Add the ability to set a maximum number of dialog showings within a year’s time from the date of ‘installation’

@elhicks I want to merge your commits to https://github.com/Vorlonsoft/AndroidRate (Release 1.1.7+)... Could you please explain me about this ability? Why you need it? Why other library users need it? Thank you!

Hey Alex,
The particular app I needed to add ratings capability to, part of the acceptance criteria is the product owner wanted to put a hard limit on how many times we show the dialog within a year's time.  Apparently this semi-mirrors an aspect of iOS ratings requests.  Thought the change might be useful for other people who get similar requests so I tossed out a pull requests from the fork I made for the small change.
Thanks,
Ed

Hi @elhicks
Thank you for your idea.  I found corresponding iOS documentation - System Rating and Review Prompts
Your Pull request has 3 significant errors:

It isn't limits the display of the dialog whin 365-day period (last 365 days from any date). It limits from 0 day after install to 364 day after install, from 365 day after install to 768 day after install, from 769 day after install to 1092 day after install, etc.
You use DateUtils.YEAR_IN_MILLIS, but this constant is actually the length of 364 days, not of a year, not of 365 days!
You use APP_INSTALL_DATE, not DIALOG_FIRST_LAUNCH_TIME_DATE

I implemented this feature by myself and included it in the [https://github.com/Vorlonsoft/AndroidRate] (AndroidRate Library Release 1.1.7).
Best regards,
Alexander Savin


"Cornu Luncii" is listed in the drop-down menu.

Description:
"Cornu Luncii" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Cornu Luncii" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Cornu Luncii, SUCEAVA".


User rights

Step 1:

Users can only see their own Blueprints and Projects

Step 2:

Add global visibility option for Blueprints and Projects (bool enough)

Step 3 (possibly not enough time for this):

Add team based visibility option for Blueprints and Projects (bool not enough)
Requires big additions to support for users to make a team

with time restrictions, not going to be implemented in this project


protocol agnostic rum collection

@triblondon @JakeChampion

@JakeChampion @triblondon ETA of this being merged and released?

LGTM 👍


remove backports-lzma from travis.ci

This isn't ideal, but backports.lzma is fairly low priority, I'm a bit time pressured, and this is holding up other PRs.
Merging tomorrow if another solution doesn't present itself.

They did a new release, and this seems to be fixed:
$ pip install backports.lzma
Collecting backports.lzma
  Downloading backports.lzma-0.0.6.tar.gz
Building wheels for collected packages: backports.lzma
  Running setup.py bdist_wheel for backports.lzma ... done
  Stored in directory: /Users/jcrist/Library/Caches/pip/wheels/9b/d8/14/1d42864cf48e1384242a8a3f3204fd330af5e96a8bc69e6bc2
Successfully built backports.lzma
Installing collected packages: backports.lzma
Successfully installed backports.lzma-0.0.6

Closing, as this was fixed upstream.


Memory leak when setting parent view controller

Setting view controller and then popping that view controller makes retain cycle, and both of them don't get deallocated.
Temporary fix is to not set parentViewController.

Hi @vuvkar, it will be fix on the next release.

This issue has to be fixed in the new pod version 0.5.0


Amir/rudderstack initialize with key from the value given in arg

Important !

This PR requires changes in both deriv.com and deriv-app because right now rudderstack is getting initialized automatically once we import it anywhere and it takes the KEY and URL values from environment variable which is not a good approach (this is currently bouding the library to be used with only deriv.com and deriv-app, see the code below to get the idea)

    const is_production =
      process.env.CIRCLE_JOB === "release_production" ||
      !!process.env.GATSBY_RUDDERSTACK_PRODUCTION_KEY;

    const RUDDERSTACK_KEY = is_production
      ? process.env.RUDDERSTACK_PRODUCTION_KEY ||
        process.env.GATSBY_RUDDERSTACK_PRODUCTION_KEY
      : process.env.RUDDERSTACK_STAGING_KEY ||
        process.env.GATSBY_RUDDERSTACK_STAGING_KEY;
    const RUDDERSTACK_URL =
      process.env.RUDDERSTACK_URL || process.env.GATSBY_RUDDERSTACK_URL;

    if (RUDDERSTACK_KEY && RUDDERSTACK_URL) {
      RudderAnalytics.load(RUDDERSTACK_KEY, RUDDERSTACK_URL);
      RudderAnalytics.ready(() => {
        this.has_initialized = true;
      });
    }

This PR is removing these conditions and dropping the current usage of initializing the rudderstack instance inside the library's module, instead we will initialize in the app we want to use. That way it will not be dependant on some shady environment variable setup which the consumer is not aware of.

Adding growthbook into the package shift the direction of the library, so this PR is no more needed


Modify Readme

Add approach and naming conventions to readme

Please be sure not to add Philosophers to your branch


Optionally include screens/contact sheets in torrent

Allow the user to include screenshots and contact sheets in a subdirectory of the torrent. This is generally required for megapacks, so will be needed for #34 and is also required on all torrents by some trackers, so will also be needed for #141.

Ah yes—I forgot FC does this.
Good thing most of your legwork is there for #34 anyway I suppose.


Add water life cycle

Can you add a water life cycle? in other words that the lakes fill up when is raining, and that the seawater vaporise sometimes creating new clouds.
Also, can you upgrade this mod to 1.20 version?

Bug fixes are the main priority at the moment. When the tasks are done this may be done check out here #2

Exactly, water life cycle is something I'd like to add, but I haven't had time yet and bugs are more important. As to 1.20 it'll have to wait until I get a better laptop (I can't really run 1.19+ without performance mods)


Upgraded ci and deps

add node 5 to travis
setup coverage
CI badges
Update deps and tests

:smiley:

Support was drop from hapi. cf: https://github.com/hapijs/hapi/issues/2764
Hence test failing on 0.10 when upgrading deps
cf: https://travis-ci.org/AdrieanKhisbe/hapi-authorization/jobs/97230488
test failing because of const

Ah got it. I'll update the Readme to reflect that then. Thanks a lot. I'll get this merged soon.

was a pleasure :), or should I say "was hapi to do be of any help"
I recommend to release a major then. (since 1 already been reached :))

3.0.0 published to NPM.

cool! :)

(you just need to activate coveralls repo (log with github), and we'll have the coverage reported :) )


X11 Client: fix UTF8 window title

@dreamadv I've reworked this pull, therefore closing yours. Thanks for pointing out this issue.


Adds ability to register custom tag providers

This will hopefully allow other extensions to extend the html parsing with their own tags -- for example https://github.com/aurelia/vscode-extension

The API makes sense, but note that in the case of VSCode the service is used on HTML language server that runs in its own process.
We have no mechanism yet on how to contribute to the server.

Ah - right. But at least this would allow other extensions to pull in this lib directly, rather than needing to re-implement.

@eamodio Would #41 work for you? You can read https://github.com/Microsoft/vscode/issues/62976 for more context.

@octref I think so, but honestly I can't really remember the full context as it was a long time ago. 😁


I want to fix the lorem ipsum generator section

Describe the bug
currently the lorem ipsum generator is not looking good I want to fix it @Bashamega
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Cool idea. I will assign you and when you are done you can submit it


mdhtml: init at 0.2.2

Description of changes
mdhtml is a simple CLI Markdown to HTML converter with styling support.
https://codeberg.org/Tomkoid/mdhtml

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Also, please rebase your commits to look like this:
maintainers: add tomkoid
mdhtml: init at 0.2.2

I don't think it's obligatory just yet, but a lot of packages tend to go into the new by-name

You don't need to do this now, there will be a later pr that moves everything possible via a script so don't bother for this pr, when you do another init just put it into pkgs/by-name since you don't have to edit the all-packages.nix

Result of nixpkgs-review pr 261671 run on x86_64-linux 1

1 package built:

mdhtml


The module 'micropip' is included in the Pyodide distribution, but it is not installed.

The module 'micropip' is included in the Pyodide distribution, but it is not installed.

Please add more context to your issue report. You saw the template when you created it... and then erased it and gave us none of the needed information.


Need any sample project integrated with selenium extra

Hi smccarthy ,
I have gone through the documentation you provided  for jar file .And this one is very awesome framework .Simplify all major problems of grid . But can you provide any sample project which have it's implementation so that it would be easy to implement .
Thanks,
Hemant

@HemantTrivedi I don't have a sample project, but the really this is just an external service that shouldn't need much setup. Download the jar file, run it (java -jar SeleniumGridExtras-1.12.4-SNAPSHOT-jar-with-dependencies.jar) and it will first ask you some questions about the machine (whether its a node or hub, what browsers will be on it, etc). After you answer all the questions, the hub/node will start. You can check that its started by going to the hub IP address (port 4444 - if that's the port you chose). You can also go to any of the hub or node machines , port 3000 , and see it running (http://<IP_ADDRESS>:3000). This is a dashboard for that machine (whether its a hub or node). You can also see all the endpoints available at http://<IP_ADDRESS>:3000/api.
Please let me know if this helps, or if you need more answers. Thank you.

@smccarthy Thanks for the details.Please clarify me on following doubts

Do I need to make any changes in my script or test-ng file to run the test cases with this jar file or anywhere in script o i need to add it;s location ?
Apart from the grid ,hub ,node configuration ,does this file have any additional feature or method which  can use by pointing object to it ?
Appreciate your efforts
Thanks,
Hemant

@smccarthy
I was running the test case  with the  jar file  but I am facing some issues .I followed following steps:

I started hub and node on the same machine
Once the hub stated , It displayed the message like "Selenium Grid Extras has been started!
Navigate to http://<IP_ADDRESS>:3000 for more details" .
3.I opened the URL
Now in my  test script , I type like
WebDriver driver;
DesiredCapabilities cap = new DesiredCapabilities();
cap.setBrowserName("firefox");
cap.setPlatform(Platform.WINDOWS);
driver = new RemoteWebDriver(new URL ("http://<IP_ADDRESS>:3000/wd/hub"), cap);
driver.get("http:google.com");
Now in console window it display the error like  : "Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure."
But in log file when i checked , it shows that hub "Registering the node to the hub: http://<IP_ADDRESS>:4444/grid/register"
Now if i used this hub address i.e : driver = new RemoteWebDriver(new URL ("http://<IP_ADDRESS>:4444/wd/hub"), cap) , then my a firefox is opening
8.I am  not getting what's the issue .And also oes the button 'Node overview' redirects somewhere ? because clicking on it it displays the same page .
9.If the hud is registred at http://<IP_ADDRESS>:4444 , then in cmd , why it's showing like "Selenium Grid Extras has been started!
Navigate to http://<IP_ADDRESS>:3000 for more details" .
Please help me on this .
Thanks,
Hemant

Port 3000 is the port the grid extras servlet runs on. Think of it as a bunch of APIs you can access (http://<IP_ADDRESS>:3000/api for example). The hub and nodes still have their own ports (hub defaults to 4444, and nodes default to 5555).
Does this make sense ?

Step 3 should be
WebDriver driver;
DesiredCapabilities cap = new DesiredCapabilities();
cap.setBrowserName("firefox");
cap.setPlatform(Platform.WINDOWS);
driver = new RemoteWebDriver(new URL ("http://<IP_ADDRESS>:4444/wd/hub"), cap); // Or <IP_ADDRESS>
driver.get("http://google.com");

It should you that Grid Extras has been started on port 3000, because that's where grid extras is running. Think of grid extras as a third party that monitors the grid hub and nodes, but you still use the normal selenium grid (port 4444 for hub and port 5555 for nodes).

Thanks @smccarthy . this is very helpful guide for me to start up with Grid . you can please close the issue .


🚀 Convert project to SCSS and Update Styles

Re-written the base project into SCSS.
Add code syntax highlights, extend styles and write modular codes. Also, fixed minor bugs.
Current Preview

Great work @Mr-spShuvo


Tensorflow dataset is not faster with multiple cores

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Linux Ubuntu 18.04):
TensorFlow installed from Colab / AWS Deep Learning AMI
TensorFlow version 2.3.0
Python version 3.6
Bazel version N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
I am using tensorflow dataset to read multiple datasets in parallel. I am trying to use dataset.interleave(map_function, ...) with multiple cores to speed up reads. All of the example code I have seen uses time.sleep() to "emulate" a real workload in the map_function. When doing this the dataset runs faster with multiple cores. However, when the map_function has a real computational load (and not just a sleep function) using multiple cores has no improvement.
Describe the expected behavior
I expect that when I use multiple cores I will get a performance improvement when using a real workload in the map_function.
Standalone code to reproduce the issue
import time
import tensorflow as tf
import numpy as np
from multiprocessing import cpu_count

def real_work():
    for i in range(1000000):
        2+2

def sleep_delay():
    time.sleep(.03)

def run_test(num_cores, delay):
    def test_gen(k):
        for i in range(10):
            delay()
            yield 0

    class TestDataset(tf.data.Dataset):

        def __new__(cls,k):
            return tf.data.Dataset.from_generator(
                test_gen,
                output_types=((tf.dtypes.float32)),
                output_shapes=((None)),
                args=(k,)
            )

    def get_test_dataset(num_cores):

        dataset = tf.data.Dataset.from_tensor_slices([str(f) for f in range(30)])
        dataset = dataset.interleave(lambda k: TestDataset(k),
                                cycle_length=num_cores,
                                num_parallel_calls=num_cores, #tf.data.experimental.AUTOTUNE,
                                block_length=1,
                                deterministic=False)
        dataset = dataset.prefetch(100)
        return dataset

    it = get_test_dataset(num_cores).as_numpy_iterator()

    for i in it:
        continue

n_cpus = cpu_count()

print('\n 1 core, sleep delay')
%time run_test(1,sleep_delay)

print(f'\n {n_cpus} core, sleep delay')
%time run_test(n_cpus,sleep_delay)

print('\n 1 core, real_work')
%time run_test(1,real_work)

print(f'\n {n_cpus} core, real_work')
%time run_test(n_cpus,real_work)

** OUTPUT **
1 core, sleep delay
CPU times: user 259 ms, sys: 11 ms, total: 270 ms
Wall time: 6.55 s
4 core, sleep delay
CPU times: user 276 ms, sys: 11.3 ms, total: 287 ms
Wall time: 1.94 s
1 core, real_work
CPU times: user 7.55 s, sys: 4.67 ms, total: 7.55 s
Wall time: 7.42 s
4 core, real_work
CPU times: user 7.87 s, sys: 1.8 ms, total: 7.87 s
Wall time: 7.61 s
As can be seen the sleep delay system works as intended but with a real workload multicore has no impact.
here is a colab link:
https://colab.research.google.com/drive/1hqxHWK4cxD-ja8kV33LM56z6uxPthsjo?usp=sharing

I have tried in colab with TF version 2.3, nightly version (2.5.0-dev20201026)and was able to reproduce the issue.Please,find the gist here. Thanks!

This is due to contention on the Python Global Interpreter Lock. real_work can't be run from multiple cores because it holds the lock. To avoid this, you can define your computation using TensorFlow ops. Then the computation will be executed in C++, where it can use multiple cores. This colab demonstrates some speedup from using multiple cores for a compute-intensive dataset.

Thank you. This is helpful. Unfortunately the code that I am working with is not easily converted to tensorflow ops. What I would like is some sort of generator that works in parallel in python and takes advantage of multiple cores. Basically I want to be able to do something like:
preds = []
for b in generator:
preds.append(model(b))
where the generator uses multiprocessing in python the use all cores. Does something like this exists in the tensorflow library or is there no way to parallelize python functions for input?

There isn't a way to use multiple processes to call a Python generator function faster. If performance is important, I suggest investing the effort into representing the preprocessing with TensorFlow ops, so that the preprocessing can be optimized and parallelized.

Hi @seankerman ! Did you check with above suggestion yet?


LTO Debug Info Fixes

• Explanation: We were passing in debug info flags twice on the command line, once with -gline-tables-only and later with -g. This then caused us to use full debug info and have a slower build.
• Scope of Issue: The full debug info caused the swift LTO build to be slower than it needed to be.
• Origination: The issue was introduced when the LTO build was brought up.
• Risk: There is no risk here since we are only changing debug info. Compiler codegen will not change and the end users compile time will not change. The only change will be that we will get better compile time when building swift with LTO.
• Nominated Reviewers: @llvm-beanz already reviewed this.
• Testing: I added a lit test to the compiler test-suite that validates that: 1. we are generating the intermediate lto files not in /tmp, but in tree and also that verifies that these intermediate files contain line tables and not full debug info. My test was written using dwarfdump. So to verify this, one just needs to run a RelWithDebInfo build with LTO.
• Bug: rdar://28484159

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 97cf7b56c01c8bac8c12abbd49231073dfca543b
Test requested by - @gottesmm

I killed the linux build. It was a mistake.


shortcut to clear out the canvas

This was an idea I had for clearing the canvas. The functionality is pretty simple. Press 'k' to clear out the canvas.
Still need input:

Would a different key be better?
Should this be added to the top bar?

This was an idea I had for clearing the canvas. The functionality is pretty simple. Press 'k' to clear out the canvas.
Still need input:

Would a different key be better?
Should this be added to the top bar?

Why not just refresh the page? Doesn't this do the job?
If we added the functionality tho:

I would lean towards making it more difficult to clear the screen to protect against accidents (even though there is still UNDO and REDO), so maybe no keyboard shortcut and only a button in the topbar 🤷🏻♂

@Kully I dont mind closing this. I agree it's not overly useful right now, although there mind be benefit if #7 gets implemented.


PBJS: Document new bidRejected event

List new bidRejected event: https://github.com/prebid/Prebid.js/pull/9013
🏷 Type of documentation

[x] new feature

📋 Checklist

[x] Related pull requests in prebid.js or server are linked

@dgirardi, Is there a code PR for this?


Maximum Data Augmentation (Variable Seq lens, equivalent quaternions)

Get variable seq lens and potentially equivalent quaternions into the dataloader as augmentation.

No need for equivalent quaternions


Remove Bitnami images from Azure Stack docs

Signed-off-by: Miguel Ruiz<EMAIL_ADDRESS>Bitnami will stop validating its catalog on Azure Stack. Therefore, we are removing the images from the Azure Stack documentation.

@sethmanheim
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@migruiz4 Thank you! #sign-off


Java docs highlight is improper

Syntax highlight for java docs isn't proper

Please provide detailed examples of what is not correct and the expected behavior.

In the below example, only the first line of the comment is getting highlighted properly and the rest are considered as code.
`
public class Test {
|
  | /**
  | * My test comments
  | * @param name
  | * @param id
  | * @return
  | *
  | */
  | private void myFunction(name, id) {
  |
  | }
  | }
`

What HTML are you using to do the highlight.

Refer the images below

Please show us all the HTML code , not just a snippet. What class is the pre tag?

Ping.

Closing for lack of activity.


Fix an off-by-one error in ESC [ G handling

There's an off-by-one error in the terminal emulator's handling of the ESC [ G (Cursor Horizontal Absolute) sequence.
I believe this also solves issue #702.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Peter Tirsek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Oops, committed using the wrong e-mail. Let me try that again... :-/


Cache maven repository in travis

Caching between builds is currently only available on the paid subscriptions for Travis CI: http://docs.travis-ci.com/user/caching/

It says it supports their new container-based architecture (http://docs.travis-ci.com/user/workers/container-based-infrastructure/), which I think we're using:
This job is running on container-based infrastructure, which does not allow use of 'sudo', setuid and setguid executables.
If you require sudo, add 'sudo: required' to your .travis.yml
See http://docs.travis-ci.com/user/workers/container-based-infrastructure/ for details.

Yes, running on the new infrastructure for their paying customers (travis-ci.com feature). :wink:
I mean we can still add it, but it doesn't have any effects on our builds running on travis-ci.org.

I'm doing this on a personal project and it seems to be using the cache.  I honestly have no idea, but it seems to be working even though I'm not paying for it.  :)

Let's give it a whirl!

I stand corrected: https://travis-ci.org/dropwizard/dropwizard/jobs/70786272#L94
It seems to work. Thanks, Justin! :smile:

What are the benefits? I initially thought that it would cut down build times but according to the builds, it doesn't look to be the case (builds are still taking ~50-55 minutes total).

I think we just need to watch it in a future PR to see if it's being used.  Carlo's most recent PR didn't download anything due to the cache so it has to be showing some improvement.

https://travis-ci.org/dropwizard/dropwizard/caches is showing some data in the Travis CI caches.


Add telemetry_options for pipeline events

Hi, thanks for your work in providing and maintaining this library! We would like to start using the built-in telemetry events for our monitoring needs, and it would be helpful for us if it was possible to add extra metadata to telemetry events; e.g. in our case we commonly use "operation names" for our redis metrics, to make it easy to distinguish between various redis pipeline executions... I've outlined a possible way to add this to the library in this PR. Is this something you would consider adding to the library? Thanks!

Hey @bforchhammer I generally love this idea. Do we have any examples of other libraries in the Elixir/Erlang landscape that use this pattern? Does Telemetry itself specify a "convention" on how to do this? I want to make sure we do this in the most conventional way 😉

Hm, good question...

phoenix/plug telemetry just gives you the full Plug.Conn construct, ie. custom metadata can be attached there
tesla similarly just passes the Tesla.Env which can be extended with custom info
ecto appears to support a telemetry_options argument to be passed to repo operations, e.g. MyApp.Repo.all(Post, telemetry_options: [organization_id: 123]), which then show up in metadata[:options] (see docs here).

Maybe ecto is a good pattern to follow here?

I changed the code to match the ecto approach, which seems nicer since it means just setting an extra key in metadata rather than merging maps 😉

Thanks for the suggestions, I've applied them and fixed the tests respectively.


[FEATURE] Remove "Discover" page

Description
Removing the Discover page and implement the logic in the Search page. So when you go initially in the Search page you get the latest updated Profiles.
This will reduce the page numbers and the confusing first screen of the search page (what are those profiles / why them) will be eliminated.
Screenshots
No response
Do you want to work on this issue?
No
Additional information
Once the Discover page is removed, the Pricing page needs to be updated as it refers to it:

It should be changed to "See a list of all those BioDrop Profiles which have been recently updated on the Search page"

Thanks @schmelto this is a great idea - I particularly like being able to reduce the number of pages.

Hi, @SaraJaoude I would like to solve this issue please assign this to me.

Hi, SaraJaoude I would like to solve this issue please assign this to me.

@Harsh3363 thank you for your enthusiasm.   With new contributors we ask that they request to be assigned issues with points between 1 and 2 (this issue is 5 points) at first.

I see, we no longer need random user logic for the search page. To reduce confusion we should mention Recently updated profiles as a heading just after the search bar.

Hi, SaraJaoude I would like to solve this issue please assign this to me.

@Harsh3363 thank you for your enthusiasm.  With new contributors we ask that they request to be assigned issues with points between 1 and 2 (this issue is 5 points) at first.

Alright I will look for the issues with  points between 1 and 2

I would like to work on this issue

I would like to work on this issue

@sansarmaske I will assign this to you

Thanks Sara! I will get started on this.

The PR for this has been merged so I will close.


Add Sikuli visual recognition for helper functions present() and visible()

As above, so that conditions can make use of whether a GUI element (desktop apps and web apps etc) is visually visible on the screen. At the moment it is already doable using vision step, but this should ideally be handled directly by present() and visible() functions to have consistent functions behavior for both web apps and desktop apps.

From @Aussiroth - above commit includes present/visible Sikuki integration

As discussed in #202 , this allows users to specify image files to the present or visible functions to use Sikuli to determine if they are visible on the screen.
Note that users will need to have some other form of visual automation in the script, e.g. click image.png, to ensure that the Sikuli engine is launched.


Display shared with colleagues list in map and dataset card

https://github.com/CartoDB/product/issues/218

I've tested all acceptance cases and they work properly.
Sharing maps/datasets to:

[X] All your organization
[X] One group
[X] One user
[X] One group and one user
[X] One user and one group
[X] Two groups and one user
[X] One user and two groups
[X] Two groups and two users

The only "weird" thing that I found is that the groups' name within the visualization data doesn't come as the user wrote it. For example, if the user wrote fake group, it would show up as fake_group. We checked it out and seems like the API is not returning the actual group name.

Ole! 👏👏👏

Have we also tried how this looks when the map / dataset also has tags?


Add extension method to HttpAuthenticationChannelProvider

Hello @tnorimat ,
I used your Proof Of Concept on CIBA to make some use-case Proof Of Concept on CIBA usage. Thank for all your team works.
When implementing my use-case, my decoupled server needs more informations than those given by HttpAuthenticationChannelProvider, exemple :

User email to send link to an authentication application
Mobile Phone number to send a SMS
Maybe a ClientModel attribute...

For me, there is two way for the decoupled server to obtain these informations :

The decoupled server get them from keycloak by an API call
These informations are already loaded in HttpAuthenticationChannelProvider, just add it to the POST body from the HttpAuthenticationChannelProvider to the decoupled server.

The Authentication Device may need informations bound to the CIBA Authentication Request. One example : the requested_expiry parameter may allow the Authentication Device to display a countown, a progress bar, to timeout on sending notifcation, we may need it for a interactive voice server to stop calling the user ...
So we may need to add this information in the the POST body.
In order to do that I see 2 ways :

Implement my own HttpAuthenticationChannelProvider from HttpAuthenticationChannelProviderBase : a lot of work, finally resolved by a code duplication.
Create a my HttpAuthenticationChannelProvider extending your HttpAuthenticationChannelProvider and override the method requestAuthentication, in these case we lose a lot of your implementation too, and finally resolve it by a code duplication.

The goal of this PR is to add an extension method to the HttpAuthenticationChannelProvider to benefit of all your implementation wich is a good one, and allow by subclassing HttpAuthenticationChannelProvider to extend the content of the POST body to the decoupled server.
This is why I created the method : requestAuthentication
I created also an exemple of implementation of extension which is now very simple : link
The only problem of this is : the created extension module have a dependecy of org.keycloak.keycloak-services and org.keycloak.keycloak-server-spi-private and is bound to internal implementation of keycloak, which leads to warnings during keycloak starting :
18:10:32,872 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-6) WFLYSRV0018: Deployment "deployment.keycloak-my-providers-0.0.1-SNAPSHOT.jar" is using a private module ("org.keycloak.keycloak-services") which may be changed or removed in future versions without notice.
18:10:32,873 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-6) WFLYSRV0018: Deployment "deployment.keycloak-my-providers-0.0.1-SNAPSHOT.jar" is using a private module ("org.keycloak.keycloak-server-spi-private") which may be changed or removed in future versions without notice.

I'd like to have your opinion on this PR :

do you agree with me about the problem about missing informations to the decoupled server problem ?
do you agree with my solution, or do we need to propose another solution ?
does my PR need to be reworked ?
...

Thank you for your attention.

Hello @c4r1570p4e ,
Thank you for your PR, and I'm happy to hear your using my PR for your PoC. Your PR sounds good to me. I agree with your proposal. After testing CIBA feature including this PR,  I would like to merge it.
One point I would like to ask you, my original PR for CIBA support is under review and hopefully would be merged onto the keycloak upstream. During this process, I might rebase and squash several commits to one commit by following keycloak's contribution convention, which means your this PR would be squashed. In this case, I would like to add Co-authored-by to show your contribution onto this CIBA support PR. Would you agree on it? If so, would you tell me your account information set onto this Co-authored-by if you can?
Aside from it, the warning message might be unavoidable because these private modules are needed to realize this CIBA support.

Hello @tnorimat ,
I'm happy of my little contribution to your work.
You can add Co-authored-by Christophe Lannoy<EMAIL_ADDRESS>Regards

@c4r1570p4e Thank you!


tcp iob throttling related fixes

Summary

tcp_datahandler: try throttled=false on iob_trycopyin failure as well
tcp_get_recvwindow: Make this match the reality (tcp_datahandler)

Impact
tcp
Testing
tested on esp32

LGTM

@yamt
I noticed that a telnet connection is unstable when tested nxplayer with spresense:rndis_smp.

Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
Traceback (most recent call last):
  File "./expect_nuttx_telnetd_test.py

@masayuki2009
i haven't used telnet on nuttx. let me try.
have you already bisected this pr is the cause of the symptom?

@masayuki2009
i haven't used telnet on nuttx. let me try.
have you already bisected this pr is the cause of the symptom?

@yamt
Let me clarify the condition.
The telnet client is running on PC (ubuntu 18.04 x86_64) and connected to the telnet daemon on NuttX.
Yes, by reverting this PR with the latest upstream locally the symptom disappeared.

@masayuki2009
i haven't used telnet on nuttx. let me try.
have you already bisected this pr is the cause of the symptom?

@yamt
Let me clarify the condition.
The telnet client is running on PC (ubuntu 18.04 x86_64) and connected to the telnet daemon on NuttX.
Yes, by reverting this PR with the latest upstream locally the symptom disappeared.

ok. thank you for info.
i will probably try to reproduce it on esp32 as i don't have spresense handy right now.
do you think it makes sense? or do you think spresense:rndis_smp has something special?

@yamt
I'm not sure if you can reproduce the symptom with ESP32, because we can not run nxplayer esp32 now.
Actually, I've been testing the same sequence with  esp32-devkitc:wapi_smp, I've never seen the symptom.
So I think we need another TCP traffic like HTTP audio streaming (perhaps we might use wget) on esp32.

@yamt
I'm not sure if you can reproduce the symptom with ESP32, because we can not run nxplayer esp32 now.
Actually, I've been testing the same sequence with esp32-devkitc:wapi_smp, I've never seen the symptom.
So I think we need another TCP traffic like HTTP audio streaming (perhaps we might use wget) on esp32.

is nxplayer receiving data over tcp?

is nxplayer receiving data over tcp?

@yamt
Yes, the nxplayer supports HTTP audio (PCM) streaming over TCP.
So the actual sequence is a little complex.

@yamt
I noticed that the symptom disappears by disabling the telnet character mode.
Perhaps, the telnet character mode generates many small TCP packets.
--- a/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig
+++ b/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig
@@ -153,7 +153,6 @@ CONFIG_SYSTEM_NXRECORDER=y
 CONFIG_SYSTEM_PING=y
 CONFIG_SYSTEM_SYSTEM=y
 CONFIG_SYSTEM_TASKSET=y
-CONFIG_TELNET_CHARACTER_MODE=y
 CONFIG_TESTING_GETPRIME=y
 CONFIG_TESTING_OSTEST=y
 CONFIG_TESTING_OSTEST_FPUSIZE=64

However, I still can not reproduce the symptom with esp32-devkitc:wapi_smp.
Perhaps, the Wi-Fi throughput is lower than the USB RNDIS throughput.

@masayuki2009
thank you for the info.
i was struggling to make telnetd work on esp32 until i found that the default TELNET_IOTHREAD_STACKSIZE was too small for my config.
now i will start mimicking your configuration and workload in question.

have you investigated where those "Telnet session" tasks were blocking?

have you investigated where those "Telnet session" tasks were blocking?

@yamt
I confirmed that I can reproduce almost the same issue with spresense:rndis (non-SMP)
nsh> ps
  PID PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED COMMAND
    0   0 FIFO     Kthread N-- Ready              00000000<PHONE_NUMBER>20  32.7%  Idle Task
    1 224 RR       Kthread --- Waiting  Signal    00000000<PHONE_NUMBER>20  30.5%  hpwork
    2 100 RR       Kthread --- Waiting  Signal    00000000<PHONE_NUMBER>04  29.7%  lpwork
    3 100 RR       Task    --- Waiting  Semaphore 00000000<PHONE_NUMBER>04  52.4%  init
    4 200 RR       Task    --- Waiting  MQ empty  00000000<PHONE_NUMBER>00  40.0%  cxd56_pm_task
    5 100 RR       Task    --- Waiting  Semaphore 00000000<PHONE_NUMBER>68  33.2%  Telnet daemon 0x2d061a30
    8 100 RR       Task    --- Waiting  Semaphore 00000000<PHONE_NUMBER>04  32.9%  nxplayer
    9 246 RR       pthread --- Waiting  MQ empty  00000000<PHONE_NUMBER>00  29.2%  playthread 0x2d0641e0
   10 252 RR       pthread --- Waiting  MQ empty  00000000<PHONE_NUMBER>52  44.1%  cxd56 0x2d060100
   11 100 RR       Kthread --- Waiting  Semaphore 00000000<PHONE_NUMBER>68  46.8%  telnet_io
   46 100 RR       Task    --- Waiting  Semaphore 00000000<PHONE_NUMBER>00  49.2%  Telnet session
   83 100 RR       Task    --- Running            00000000<PHONE_NUMBER>00  49.2%  Telnet session
   62 100 RR       Task    --- Waiting  Semaphore 00000000<PHONE_NUMBER>00  49.2%  Telnet session
nsh> free

So I attached openocd with gdb.
(gdb) info_nxthreads
target examined
_target_arch.name=armv7e-m
$_target_has_fpu : 1
$_target_has_smp : 0
saved current_tcb (pid=0)
* 0 Thread 0x2d04d2f8  (Name: Idle Task, State: Running, Priority: 0, Stack: 320/976) PC: 0xd008536 in up_check_tcbstack()
  1 Thread 0x2d059480  (Name: hpwork, State: Waiting,Signal, Priority: 224, Stack: 620/2032) PC: 0xd008594 in arm_switchcontext()
  2 Thread 0x2d05a0c0  (Name: lpwork, State: Waiting,Signal, Priority: 100, Stack: 604/2032) PC: 0xd008594 in arm_switchcontext()
  3 Thread 0x2d05ad00  (Name: init, State: Waiting,Semaphore, Priority: 100, Stack: 1604/3056) PC: 0xd008594 in arm_switchcontext()
  4 Thread 0x2d05c0e0  (Name: cxd56_pm_task, State: Waiting,MQ empty, Priority: 200, Stack: 400/1000) PC: 0xd008594 in arm_switchcontext()
  5 Thread 0x2d061a50  (Name: Telnet daemon, State: Waiting,Semaphore, Priority: 100, Stack: 668/2008) PC: 0xd008594 in arm_switchcontext()
  8 Thread 0x2d062df0  (Name: nxplayer, State: Waiting,Semaphore, Priority: 100, Stack: 1004/3048) PC: 0xd008594 in arm_switchcontext()
  9 Thread 0x2d0632d0  (Name: playthread, State: Waiting,MQ empty, Priority: 246, Stack: 900/3072) PC: 0xd008594 in arm_switchcontext()
  10 Thread 0x2d086160  (Name: cxd56, State: Waiting,Signal, Priority: 252, Stack: 452/1024) PC: 0xd008594 in arm_switchcontext()
  11 Thread 0x2d0869a0  (Name: telnet_io, State: Waiting,Semaphore, Priority: 100, Stack: 468/1000) PC: 0xd008594 in arm_switchcontext()
  46 Thread 0x2d0871b0  (Name: Telnet session, State: Waiting,Semaphore, Priority: 100, Stack: 1500/3048) PC: 0xd008594 in arm_switchcontext()
  62 Thread 0x2d088460  (Name: Telnet session, State: Waiting,Semaphore, Priority: 100, Stack: 1500/3048) PC: 0xd008594 in arm_switchcontext()
(gdb) nxthread 62
  62 Thread 0x2d088460  (Name: Telnet session, State: Waiting,Semaphore, Priority: 100, Stack: 1500/3048) PC: 0xd008594 in arm_switchcontext()
(gdb) where
#0  arm_switchcontext () at armv7-m/gnu/arm_switchcontext.S:79
#1  0x0d003ab2 in nxsem_wait (sem=sem@entry=0x2d089278) at semaphore/sem_wait.c:153
#2  0x0d00a69c in _net_timedwait (sem=sem@entry=0x2d089278, interruptible=interruptible@entry=1 '\001', timeout=timeout@entry=4294967295) at utils/net_lock.c:128
#3  0x0d00a6b8 in net_timedwait (sem=sem@entry=0x2d089278, timeout=timeout@entry=4294967295) at utils/net_lock.c:402
#4  0x0d00a6c0 in net_lockedwait (sem=sem@entry=0x2d089278) at utils/net_lock.c:427
#5  0x0d01a0c2 in tcp_close_disconnect (psock=0x2d088210) at tcp/tcp_close.c:321
#6  tcp_close (psock=0x2d088210) at tcp/tcp_close.c:377
#7  0x0d018a40 in inet_close (psock=<optimized out>) at inet/inet_sockif.c:1485
#8  0x0d0185e8 in psock_close (psock=psock@entry=0x2d088210) at socket/net_close.c:100
#9  0x0d00fade in telnet_close (filep=<optimized out>) at net/telnet.c:781
#10 0x0d002d06 in file_close (filep=0x2d0887d0) at vfs/fs_close.c:74
#11 0x0d0026dc in files_releaselist (list=list@entry=0x2d088640) at inode/fs_files.c:148
#12 0x0d0046da in group_release (group=0x2d0885f0) at group/group_leave.c:152
#13 group_leave (tcb=tcb@entry=0x2d088460) at group/group_leave.c:399
#14 0x0d004cae in nxtask_exithook (tcb=tcb@entry=0x2d088460, status=status@entry=0, nonblocking=nonblocking@entry=0 '\000') at task/task_exithook.c:645
#15 0x0d0042ce in exit (status=status@entry=0) at task/exit.c:103
#16 0x0d01274e in nsh_consoleexit (vtbl=<optimized out>, exitstatus=0) at nsh_console.c:428
#17 0x0d0128ce in cmd_exit (vtbl=<optimized out>, argc=<optimized out>, argv=<optimized out>) at nsh_command.c:987
#18 0x0d011a60 in nsh_execute (oflags=0, redirfile=0x0, argv=0x2d089394, argc=1, vtbl=0x0) at nsh_parse.c:741
#19 nsh_execute (vtbl=0x0, argc=1, argv=0x2d089394, redirfile=0x0, oflags=0) at nsh_parse.c:483
#20 0x0d012502 in nsh_parse_command (vtbl=vtbl@entry=0x2d0894c0, cmdline=<optimized out>) at nsh_parse.c:2578
#21 0x0d0125e2 in nsh_parse (vtbl=vtbl@entry=0x2d0894c0, cmdline=cmdline@entry=0x2d089928 "") at nsh_parse.c:2662
#22 0x0d010cea in nsh_telnetmain (argc=<optimized out>, argv=<optimized out>) at nsh_telnetd.c:181
#23 0x0d005fbc in nxtask_startup (entrypt=0xd010c75 <nsh_telnetmain>, entrypt@entry=0x2d04d478 <inited>, argc=<optimized out>, argv=<optimized out>) at sched/task_startup.c:151
#24 0x0d004288 in nxtask_start () at task/task_start.c:130
#25 0x00000000 in ?? ()
(gdb)

@masayuki2009 when you have a chance, can you dump the tcp_conn_s structure for the connection?

@yamt
I captured the packets with the wireshark.
Perhaps, I might find the root cause of the issue.
When the symptom happened. The telnet server sent a FIN packet with ** Window size=0 **.
So the telnet client can not send a FIN packet but continue to send a keep-alive packet.
Please see the attached file.
You can find the sequence with a filter "tcp.stream.eq 2".
spresense-rndis-nxplayer-telnet-ng-20210625.pcapng.gz

@masayuki2009
thank you.
so, the conn is TCP_FIN_WAIT_2 and cleaned up after TCP_TIME_WAIT_TIMEOUT?

@masayuki2009 when you have a chance, can you dump the tcp_conn_s structure for the connection?

@yamt
Here is the connection info for the socket waiting for
(gdb) p *conn
$1 = {node = {flink = 0x2d05432c <g_tcp_connections+192>, blink = 0x2d0542cc <g_tcp_connections+96>}, list = 0x2d0546e0 <g_cbprealloc+260>, u = {ipv4 = {laddr = 335609866, raddr = 251723786}}, rcvseq = "\234\364", <incomplete sequence \371\232>, sndseq = "\000\000\207", <incomplete sequence \354>, crefs = 0 '\000', sa = 0 '\000', sv = 3 '\003', rto = 3 '\003', tcpstateflags = 6 '\006', timer = 113 'q', nrtx = 0 '\000', lport = 5888, rport = 14562, mss = 1460, snd_wnd = 64076, rcv_adv =<PHONE_NUMBER>, tx_unacked = 0, dev = 0x2d060380, readahead = {qh_head = 0x0, qh_tail = 0x0}, blparent = 0x0, backlog = 0x0, connevents = 0x2d0546b8 <g_cbprealloc+220>, accept_private = 0x0, accept = 0x0, pollinfo = {{psock = 0x0, fds = 0x2d08673c, cb = 0x2d0546e0 <g_cbprealloc+260>}}}

so, the conn is TCP_FIN_WAIT_2 and cleaned up after TCP_TIME_WAIT_TIMEOUT?

Yes, as you can see conn->tcpstateflags was 6 which means the state was TCP_FIN_WAIT_2.

right now, we drops out of window segments like these silently.
i guess we should send an ack for them instead.
iirc it's even mandated by standards.
how do you think?

i think there at least two issues.

we don't advertise window updates for non ESTABLISHED connections.
we don't respond to probes for non ESTABLISHED connections.

i'm working on a fix for the latter in https://github.com/apache/incubator-nuttx/pull/3991
(the "tcp: always responds to keep-alive segments" commit)


Reading a json file using PowerShell fails

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: PowerShell
Environment

Server - Azure Pipelines

Issue Description
I'm using the PowerShell@2 task to read the content of a generated json file and pipe it to a command. It's an inline script that looks like this:
'Get-Content report.json | ./node_modules/.bin/cucumber-junit > report.xml'
Error logs
2020-01-24T13:26:55.0933805Z ##[section]Starting: Generate Cucumber Report
2020-01-24T13:26:55.1136787Z ==============================================================================
2020-01-24T13:26:55.1136863Z Task         : PowerShell
2020-01-24T13:26:55.1136923Z Description  : Run a PowerShell script on Linux, macOS, or Windows
2020-01-24T13:26:55.1136958Z Version      : 2.151.2
2020-01-24T13:26:55.1136990Z Author       : Microsoft Corporation
2020-01-24T13:26:55.1137024Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
2020-01-24T13:26:55.1137082Z ==============================================================================
2020-01-24T13:26:56.1053338Z Generating script.
2020-01-24T13:26:56.1507941Z ========================== Starting Command Output ===========================
2020-01-24T13:26:56.1813819Z ##[command]"C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'd:\a\_temp\asd21312-1312-456a-aefe-1cc5c91dcf3c.ps1'"
2020-01-24T13:26:56.7657076Z undefined:1
2020-01-24T13:26:56.7657705Z ï»¿[
2020-01-24T13:26:56.7657898Z ^
2020-01-24T13:26:56.7658032Z
2020-01-24T13:26:56.7659018Z SyntaxError: Unexpected token ï»¿ in JSON at position 0
2020-01-24T13:26:56.7659207Z     at JSON.parse (<anonymous>)
2020-01-24T13:26:56.7659740Z     at cucumberJunit (D:\a\1\s\Source\WebApp\node_modules\cucumber-junit\lib\cucumber_junit.js:204:29)
2020-01-24T13:26:56.7661045Z     at Socket.<anonymous> (D:\a\1\s\Source\WebApp\node_modules\cucumber-junit\bin\cucumber-junit:39:26)
2020-01-24T13:26:56.7661546Z     at Socket.emit (events.js:228:7)
2020-01-24T13:26:56.7662509Z     at endReadableNT (_stream_readable.js:1185:12)
2020-01-24T13:26:56.7665779Z     at processTicksAndRejections (internal/process/task_queues.js:81:21)
2020-01-24T13:26:56.9071388Z ##[error]PowerShell exited with code '1'.
2020-01-24T13:26:56.9434061Z ##[section]Finishing: Generate Cucumber Report

The same command runs perfectly fine locally. It only fails when ran on Azure. It seems like reading the file using PowerShell is always with Byte-order-mark and this is where things break.

Closing due to inactivity


Fix sporadic test errors due to serialization of GUIDs

A GUID with a leading zero is serialized as 'GUID', a GUID with any other character at the beginning is serialized as GUID.
This led to sporadic test errors, with e.g. the following message:
expected "<...>key: '09a609b0-9d4d-4ca8-bac7-6c28278d5e85'<...>" to
include "key: 09a609b0-9d4d-4ca8-bac7-6c28278d5e85"

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

so that's why that happens!  thanks for digging into this


added loading screen #1 and dynamic interval checking if extension is online

This version of the extension is incompatible with previous releases of the wallet (lethean-gui e04f972). The BE will not connect to the older wallet versions.


feat: adjust brightness and contrast of image

Closes #289, #291.
Summary of Changes
Added features for adjusting both brightness and contrast
Co-authored-by: daniaHu<EMAIL_ADDRESS>

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
2
1
0
0.85s

❌ PYTHON
mypy
2

1
1.84s

✅ PYTHON
ruff
2
1
0
0.02s

✅ REPOSITORY
git_diff
yes

no
0.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.14.0 :tada:
The release is available on:

v0.14.0
GitHub release

Your semantic-release bot :package::rocket:


Battery_Int600

@stephpenn1 said

Aquatroll needs Battery_Int600 added back in, this is the internal sensor battery and not the logger voltage

Aggreed

Done in #100


fix: appearance and case in HELPINFO structure

@ksyx : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ksyx : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Errors on LG TV

My lg tv is rooted and i got the source to compile using the ndk.
But when running i get an egl error:
hyperion-webos: /source/src/capture.c:206: egl_init: Assertion `eglGetError() == EGL_SUCCESS' failed.

Also when im skipping the egl part i get the error:
[VT] VT_IsSystemSupported Failed. This TV doesn't support VT.

Maybe you can give me a hint how to debug this and maybe what other api i could try to capture the screen?

Not sure if you are following it, but we started reversing libdile_vt which is an underlying library used by libvt, and we've been able to make it work on at least one model where libvt was broken.
You can try if that works. Prebuilt binaries are here: https://github.com/webosbrew/hyperion-webos/actions/runs/1569221042
LD_LIBRARY_PATH=/tmp /tmp/hyperion-webos --address <IP_ADDRESS> --port 19400 --fps 60 --width 192 --height 108 --backend libdile_vt

We only support RGB pixel format (pixelFormat: 9) right now, but I soon will add pixel format conversions

Hi,
thank you its working now on my tv with constant 6 fps. :)
I got the output:
[DILE_VT] pixelFormat: 9; width: 576; height: 108; stride: 576...
but i used a width of 192. Is this just a display error or is the resolution really wrong?

Thats the output i got:
[DILE_VT] supportScaleUp: 0; (0x0)
[DILE_VT] supportScaleDown: 1; (60x34)
[DILE_VT] maxResolution: 1920x1080
[DILE_VT] input deinterlace: 0; display deinterlace: 0
[DILE_VT] framerate divider: 1
[DILE_VT] vfbs: 1; planes: 1
[DILE_VT] pixelFormat: 9; width: 576; height: 108; stride: 576...
[DILE_VT] vfb[0][0] = 0x08000000
Start connection loop
[DILE_VT] framerate: 0.015127 FPS
[DILE_VT] vfb 0: pixelFormat: 9; width: 576; height: 108; stride: 576; offset: 08000000... ok!
[DILE_VT] framerate: 6.034332 FPS
[DILE_VT] framerate: 6.014026 FPS
[DILE_VT] framerate: 6.014061 FPS
[DILE_VT] framerate: 6.034264 FPS
[DILE_VT] framerate: 6.013991 FPS
[DILE_VT] framerate: 6.014071 FPS

6 fps is already better than the 2 fps i got with triggering luna://com.webos.service.tv.capture/executeOneShot :D
TV Model: LG 55UH625V
webOS Version: 3.4.0-5803
Software Version: 05.60.03

If you are up for some hacking you could try commenting out or replacing this line with some generic sleep like usleep(30000);
https://github.com/webosbrew/hyperion-webos/blob/main/src/backends/libdile_vt.c#L181

[DILE_VT] framerate: 26.837904 FPS 🎉

And does it actually feed proper frames? That's amazing, we could rework our code to do that (optionally)

I think so. I only checked it in the hyperion web live view and it looked really good. I could not see any skipped/black frames
so i assume it is working

Great. I'll try to add detection of misbehaving WaitVsync and will likely need your help sometime later. :)

Sure, just tell me when to test :)

I've been fiddling around with one of the latest builds (https://github.com/webosbrew/hyperion-webos/actions/runs/1569221042).
SDR and HDR content is working pretty good except Dolby Vision. If the TV plays Dolby Vision content the screen goes black or pink when using libvt backend, libdile_vt produces a distorted b/w image in Hyperion Live-Video. Framerate is great.
Is there any debug log I can contribute?
Model: LG 65B7D
webOS: 3.9.0
Software: 06.00.25

@derstrassi can you please check build from a previous commit (https://github.com/webosbrew/hyperion-webos/actions/runs/1569884562), share with us /tmp/hyperion-webos-dump.000.000.raw and /tmp/hyperion-webos-dump.000.001.raw files that are genrated, and log of a run of hyperion-webos?

@zlokomatic can you check #12 once again? We added some startup call that was seemingly missing. We also added an initial vsync timing test, but do not detect misbehaviour yet:
[DILE_VT] frametime: 16120; estimated fps before divider: 62.03474
[DILE_VT] frametime: 33121; estimated fps after divider: 30.19233

@Informatic tried this build, but none of the files you mentioned was generated.

Can you show us the log you got? It should have printed out these messages: https://github.com/webosbrew/hyperion-webos/commit/887ccd967c7929afc9a12e1b17d66cb44c360904#diff-c66171c49549a5d2b7a37f4536054a651e8a049a6ed0f71efcf981f29dcbfcb7R204-R212

But wait...now I have tried the latest build (https://github.com/webosbrew/hyperion-webos/actions/runs/1598688764) and used libdile_vt backend and it works perfectly with my B7 TV and DV content!
Thought I have to use libvt as backend because libdile_vt never gave me a clear picture in Hyperion preview.
Log output is:
root@LGwebOSTV:~/tmp# LD_LIBRARY_PATH=/home/root/tmp /home/root/tmp/hyperion-webos --address <IP_ADDRESS> --port 19400 --backend libdile_vt

[DILE_VT] supportScaleUp: 1; (3840x2160)
[DILE_VT] supportScaleDown: 1; (320x240)
[DILE_VT] maxResolution: 3840x2160
[DILE_VT] input deinterlace: 0; display deinterlace: 1
[DILE_VT] scaledown limit, overriding to 320x240
[DILE_VT] framerate divider: 1
[DILE_VT] frametime: 16676; estimated fps before divider: 59.96642
[DILE_VT] frametime: 16683; estimated fps after divider: 59.94126
[DILE_VT] vfbs: 3; planes: 2
[DILE_VT] pixelFormat: 1; width: 320; height: 240; stride: 320...
[DILE_VT] vfb[0][0] = 0xbcd00000
[DILE_VT] vfb[0][1] = 0xbcd13000
[DILE_VT] vfb[1][0] = 0xbcd1d000
[DILE_VT] vfb[1][1] = 0xbcd30000
[DILE_VT] vfb[2][0] = 0xbcd3a000
[DILE_VT] vfb[2][1] = 0xbcd4d000
Start connection loop
[DILE_VT] framerate: 0.538473 FPS
[DILE_VT] framerate: 30.482291 FPS
[DILE_VT] framerate: 29.973234 FPS

Well that's great then I guess. Seems like we are limited to 30fps performance-wise though? If you want to debug it yourself some more, you can try commenting out scaledown limiter like in #15  and see if you can go down to something like 192x108. Also I persume the performance/latency would be slightly better if you set -f 30 (since we wouldn't even try decoding/pulling in every second frame, that we aren't able to convert quickly enough as seen above in framerate counter)

Will trie that with the scale down, but I don't know if that is necessary. Did set --fps 15 and performance seems good to me, around 12% CPU for hyperion-webos and no latency noticeable.

Sure, depends on what's your target. I feel like 15 → 30 would be definitely noticeable improvement.

Closing since this has been mostly resolved, if I understand it correctly. Don't hestitate to reopen/create new issues.

I have the same TV as @zlokomatic (but 65") with the same OS Version and got exactly the same error with only 6 FPS.
Replacing DILE_VT_WaitVsync(vth, 0, 0); with usleep(30000); helped. Now I'm at 30 FPS.
"board_type": "K2LP_DVB",
"hardware_id": "HE_DTV_W16P_AFADABAA",
"product_id": "65UH625V-ZA",
"core_os_release": "3.4.0-5803",
"webos_manufacturing_version": "05.60.03",


C++ rewrite tracking issue

[ ] LicenseSelectPage
[ ] LicenseSettingsPage
[ ] TimeAttackGhostListPage
[ ] TimeAttackRulesPage

LicenseSelectPage is started. The 2 settings page can maybe be merged and a tab system could be introduced.


Does something funky with TXT records that contain domainkeys

Seems it put part of it into a comment above the record instead, very strange. Only a minor bug though, otherwise a real time saver, this tool is awesome.

Hey @Havoc302!
Did some quick testing, it looks like this happens if the value contains spaces and is not quoted. Could this be the case for you?

Checked the spec, it indeed seems the quoting is required:

TXT-DATA        One or more <character-string>s.
[...]
<character-string> is expressed in one or two ways: as a contiguous set
of characters without interior spaces, or as a string beginning with a "
and ending with a ".  Inside a " delimited string any character can
occur, except for a " itself, which must be quoted using \ (back slash).

It is fairly common that servers are a bit more... well, flexible, in their parsing than required by the spec. The parser used here is pretty strict though, so there's been a few cases like this where zones that work elsewhere are not accepted. (And in at least one case, where the zone had been broken for a number of years but noone had noticed)

You're actually spot on, thanks for checking that, all the other zones I've used the tool on it's been enclosed in quotes. Lucky this one wasn't prod :D


chore(dev): bump base64 to 0.8

Thanks! I merged another PR that included this change before I saw this one, sorry.


client, server: add and use runtime dir instead of relying on temp files

This way, we know a conmon-rs's files are cleaned up after its runtime dir is

maybe a decent TODO: add a test making sure those consts are in sync. linking between rust and go isn't as trivial as go and c, so the approach of conmon didn't seem correct

Codecov Report

Merging #284 (19a6944) into main (7ea7cad) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #284   +/-   ##
=====================================
  Coverage   6.89%   6.89%
=====================================
  Files          2       2
  Lines         29      29
  Branches      17      17
=====================================
  Hits           2       2
  Misses        27      27

updated as suggested!


Port NUnit based tests to Core CLR and xUnit.net

This is a work-in-progress PR for #690

[ ] Pick xUnit.net or NUnit
[X] Rebase PR against the HEAD of the coreclr branch.
[X] Update coreunit tests
[ ] Update IDE Unit tests
[ ] Update FSharp.Compiler.Unittests
[X] Get coreclr tests running.
[X] Fix Profile47.

That all looks good and not nearly as dramatic as I expected.
Experimental xunit portable stuff can be found here:  https://www.myget.org/gallery/dotnet-buildtools

@PatrickMcDonald i upgraded my pr for fsharp suite to nunit 3 ( #90 ), the migration was easy.
maybe is worth a shot, see https://github.com/Microsoft/visualfsharp/issues/690#issuecomment-151009760 there is a nuget ready.
Btw the vs test runner adapter work only with beta 3, so you need to run tests from commandline, but the console was an easy upgrade too

I rebased this PR against the latest coreclr branch and have managed to get the tests running in the coreclr.

Patrick, do you want me to pull this, or do you want to stick with it?  I'm liking what I see so far.

Kevin, I'm happier with this PR now that I have Profile47 working with xUnit. (We need to reference v1.9.2 of xUnit.net which thankfully is only 1 dll)
There are still 2 coreunit coreclr tests failing for me, both with reflection errors so not that surprising really.  I'm at a loss how to fix them though.  1 is the surface area test which I haven't seen running, so expect some differences there when we do get it running.
One of the Profile7 tests is failing for reason I haven't identified.

System.ArgumentException : Ambiguous method named Equals in type FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Reflection.FSharpValueTests

Also the IDE and compiler unit tests are outstanding, but they can be dealt with in a separate PR.
On the NUnit vs xUnit.net debate, It seems to me that to get NUnit 3.0 running in the Core CLR we would have to change the test dlls to exes, which seems like overkill for a temporary solution. We can still port xUnit back to NUnit when NUnit is ready, but once the work is done to convert to xUnit, it all seems to work very well.

Btw, nunit 3 final is now released and should support coreclr
@PatrickMcDonald ide tests doesnt need to change test framework, these projects (vs extension) are not going to be compiled to coreclr.
About nunit lite, .dll to .exe is only few conditionals on msbuild files (see nunit lite 3 ) and an additional program.fs.
The program main already exists.
public static void Main(string[] args)
    {
      new TextUI().Execute(args);
    }

Also nunit lite (modified by xamarin as  touch.unit ) is used to run tests on ios devices ( dont think this work with nunit lite 3 now but is going to )

@PatrickMcDonald @enricosada
It seems as if the nunit guys have some form of coreclr testing now:

http://www.alteridem.net/2015/11/04/testing-net-core-using-nunit-3/
https://www.nuget.org/packages/NUnitLite/3.0.0-rc

It would be nice, if we could see if we can make it work.

Okay that took longer than it should have, as the changes were simple enough.  Created #748 as the NUnit version of this PR.

the nunit port looks like the way to go.  Thanks for taking care of this @PatrickMcDonald .


Teleport Movement

Is your feature request related to a problem? Please describe.
i get motion sickness and need Teleport Movement in order to play games and i dont want to miss out.
Describe the solution you'd like
please create Teleport Movement for res2/7 and others
Describe alternatives you've considered
screen filters dont work and you lose the screen picture all the time because you are constantly moving
Additional context
Thank you for all of your time !

I wonder if its that hard to implement. We could potentially collect some money and then implementing this feature would be motivated


AppCenterDistribute@3 - release notes should be optional

Issue Description
In AppCenterDistribute@3 task, release notes should be optional. On the App Center portal when you are uploading builds manually, you don't need to provide release notes.

Still waiting for the implementation.

Still waiting

still waiting

still valid (and needed)


ADDCOMP, DELCOMP

I'm making a door replacement menu for standard type of house (for example) - m_wooden_house

Added AddComponent uid(W): Adds a Component with the given UID.
Added DelComponent uid(W): Deletes from the Components list the given UID (-1 clears the whole list)*.
does not work

but work ADDCOMP - undocumented command!!!
DELCOMP - also doesn't work

I need not only to change the appearance, but also to give out the keys.  That's why I'm completely changing one door.

It's silly, I don't know why it's like that but delete command is DELCOMPONENT instead of DELCOMP and add command is ADDCOMP. It's silly, I have no idea why it is like that, but DELCOMPONENT and ADDCOMP works well.

my mistake. Maybe I didn't check DelComponent.
at first, I was generally confused between COMP and COMPONENT. and why are the functions different
But then I understand.

This command adds only tag.MultiComponent
events like ei_house_component and other
link to the house
is all this using scripts?
it's easier to write a separate function for yourself

SetOwner - also doesn't work !!!

What do you mean with SETOWNER? I don't think we have any command like this.

I see, maybe the person who did this update used SetOwner at first, then changed it and forgot to update changelog, I can update this, but it should be OWNER directly.


release: we need git cli

We need git in the release image

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.89%. Comparing base (752252d) to head (37d5760).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   54.89%   54.89%
=======================================
  Files          10       10
  Lines        1257     1257
=======================================
  Hits          690      690
  Misses        479      479
  Partials       88       88

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.