Entity type embedding

Thank you for your impressive work!
I have a question about "entity type embedding", e. I'm wondering why entity type embedding is necessary. Your LUKE has two position embeddings for word and entity, Ci and Di, respectively.
To my understanding, Di can contain information of e. We can create the logically same model by changing parameter values as follows: Di <- Di + e, e <- 0. In other words, Di and e seem to be redundant.
Why is entity type embedding necessary for LUKE? Does it help to make training more stable?

Thank you for carefully reading our paper!
As you pointed out, entity type embedding may not be necessary, and it can be stored in the entity position embedding.
However, as the computational overhead of adding entity type embedding is negligible, our model stores the token type information in the dedicated entity type embedding vector instead of separate position embedding vectors.

I see. And, I agree that the computational overhead of adding entity type embedding is negligible.
Thank you for your quick and kind response!


#202: Increase comprehension via tooltips and input transparency

Added tooltips for intervention form fields
Changed intervention level to use number input that gets translated to a float between 0 and 1.
Tooltips currently just use field label.
Closes #202

@mfisher-idmod, I see that too, but it doesn't seem to be affecting anything. It may have to do with the way the tabs are loaded by Vuejs. I'll dig in.

Closing this PR since @cliffckerr is going to make another one with these same changes in it.


Add google icon!

As social media icons are often used in login/sign-up forms where Google is very often represented as a way to sign in, having one style to cover all of the different logos is super important!

Done!

Amazing! Thanks!


Downloading youtube videos with stylized subtitles

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[x] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[ ] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I don't really have a technical issue, it's more of a feature request. Now that youtube has been using stylized subtitles (example), I tried to download and embed them into the video. However, only the plain text was embedded with no styles. The command I used for reference:
yt-dlp -f 303+251 --cookies-from-browser chrome --all-subs --embed-subs --write-thumbnail --embed-thumbnail --convert-thumbnails png --add-metadata --embed-chapters https://www.youtube.com/watch?v=aLgfFwAHb3I
I looked around and found out about the .json3 format that youtube is currently using for captioning. I downloaded them to no avail since there does not seem to be any parser to convert them to the .ass format. The closest thing I found was this. Is there any current workaround for this? I just want to be able to download the video with the subs as they appear on the live video.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '-f', '303+251', '--cookies-from-browser', 'chrome', '--all-subs', '--embed-subs', '--write-thumbnail', '--embed-thumbnail', '--convert-thumbnails', 'png', '--add-metadata', '--embed-chapters', 'https://www.youtube.com/watch?v=aLgfFwAHb3I']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd25] (pip)
[debug] Python 3.10.5 (CPython AMD64 64bit) - Windows-10-10.0.18362-SP0 (OpenSSL 1.1.1n  15 Mar 2022)
[debug] exe versions: ffmpeg 5.0.1-full_build-www.gyan.dev (setts), ffprobe 5.0.1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[Cookies] Extracting cookies from chrome
[debug] Extracting cookies from: "C:\Users\Store\AppData\Local\Google\Chrome\User Data\Default\Network\Cookies"
[debug] Found local state file at "C:\Users\Store\AppData\Local\Google\Chrome\User Data\Local State"
[Cookies] Extracted 1516 cookies from chrome
[debug] cookie version breakdown: {'v10': 1516, 'other': 0, 'unencrypted': 0}
[debug] Proxy map: {}
[debug] Loaded 1760 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)
[youtube] Extracting URL: https://www.youtube.com/watch?v=aLgfFwAHb3I
[youtube] aLgfFwAHb3I: Downloading webpage
[debug] [youtube] Extracted SAPISID cookie
[youtube] aLgfFwAHb3I: Downloading android player API JSON
[debug] [youtube] Extracting signature function js_4248d311_109
[debug] Loading youtube-sigfuncs.js_4248d311_109 from cache
[debug] Loading youtube-nsig.4248d311 from cache
[debug] [youtube] Decrypted nsig SiZECDEa5HsvV3N => 9g12x9ux7uToog
[info] aLgfFwAHb3I: Downloading subtitles: en
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] aLgfFwAHb3I: Downloading 1 format(s): 303+251
[info] Writing video subtitles to: 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].en.vtt
[debug] Invoking http downloader on "https://www.youtube.com/api/timedtext?v=aLgfFwAHb3I&caps=asr&xoaf=5&hl=en&ip=<IP_ADDRESS>&ipbits=0&expire=1674145273&sparams=ip%2Cipbits%2Cexpire%2Cv%2Ccaps%2Cxoaf&signature=9860D8180F2926507F57C96DF4F959B752708E20.9520BDA13EAC52D1FF19A05A121E3144A27BC153&key=yt8&lang=en&fmt=vtt"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].en.vtt
[download] 100% of  388.91KiB in 00:00:03 at 115.59KiB/s
[info] Downloading video thumbnail 41 ...
[info] Writing video thumbnail 41 to: 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].webp
[ThumbnailsConvertor] Converting thumbnail "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].webp" to png
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -f image2 -pattern_type none -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].webp" -update 1 -movflags "+faststart" "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].png"
Deleting original file 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].webp (pass -k to keep)
WARNING: webm doesn't support embedding a thumbnail, mkv will be used
[debug] Invoking http downloader on "https://rr1---sn-f5ojvh23-3ips.googlevideo.com/videoplayback?expire=1674141674&ei=igvJY_e9M6u8mLAPr9kL&ip=<IP_ADDRESS>&id=o-ACVZWxHxBuhhI6PD8MXtuEFJZa6WsOk6bVlbtgU9LGXF&itag=303&source=youtube&requiressl=yes&mh=Jd&mm=31%2C29&mn=sn-f5ojvh23-3ips%2Csn-ug5onfvgaq-3ipl&ms=au%2Crdu&mv=m&mvi=1&pl=24&gcr=pk&initcwndbps=473750&spc=zIddbMpUkPAFDzrmvYI7ctx6Aoxem4O9H8GrrypvVaEh&vprv=1&svpuc=1&mime=video%2Fwebm&gir=yes&clen=47043243&dur=102.533&lmt=1672992292996267&mt=1674119610&fvip=2&keepalive=yes&fexp=24007246&c=ANDROID&txp=6319224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cgcr%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIgbENVHuRnLRtRI6a-C5AGaGSbUF2mHroKi5y1TvILomQCIQC7szSsUB8evXSRfQ3fjaQ89rLYI_7jjLEKAP6kd--cBQ%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIgdJTHzFql2C8UmxCq5RS8sm-3VH1zUKZFHwwrPFI6IGoCIQCA7JFbrODcY7CxDhCByI0rx1L47jcmVq9N7LhoC7ppww%3D%3D"
[download] Destination: 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f303.webm
[download] 100% of   44.86MiB in 00:01:08 at 666.36KiB/s
[debug] Invoking http downloader on "https://rr1---sn-f5ojvh23-3ips.googlevideo.com/videoplayback?expire=1674141674&ei=igvJY_e9M6u8mLAPr9kL&ip=<IP_ADDRESS>&id=o-ACVZWxHxBuhhI6PD8MXtuEFJZa6WsOk6bVlbtgU9LGXF&itag=251&source=youtube&requiressl=yes&mh=Jd&mm=31%2C29&mn=sn-f5ojvh23-3ips%2Csn-ug5onfvgaq-3ipl&ms=au%2Crdu&mv=m&mvi=1&pl=24&gcr=pk&initcwndbps=473750&spc=zIddbMpUkPAFDzrmvYI7ctx6Aoxem4O9H8GrrypvVaEh&vprv=1&svpuc=1&mime=audio%2Fwebm&gir=yes&clen=1672941&dur=102.561&lmt=1672992215665051&mt=1674119610&fvip=2&keepalive=yes&fexp=24007246&c=ANDROID&txp=6318224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cgcr%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRgIhALgYgIAYmBsEdIpBWuFSWAYQ91LHh0wq1WIUE9hLTsHwAiEAyEm5hVnpmFF6p3Lbjb4Sx1E8w7KWEsvhptHGc1hyfFk%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIgdJTHzFql2C8UmxCq5RS8sm-3VH1zUKZFHwwrPFI6IGoCIQCA7JFbrODcY7CxDhCByI0rx1L47jcmVq9N7LhoC7ppww%3D%3D"
[download] Destination: 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f251.webm
[download] 100% of    1.60MiB in 00:00:01 at 1005.79KiB/s
[Merger] Merging formats into "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f303.webm" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f251.webm" -c copy -map "0:v:0" -map "1:a:0" -movflags "+faststart" "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].temp.mkv"
Deleting original file 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f251.webm (pass -k to keep)
Deleting original file 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].f303.webm (pass -k to keep)
[EmbedSubtitle] Embedding subtitles in "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].en.vtt" -map 0 -dn -ignore_unknown -c copy -map "-0:s" -map "1:0" "-metadata:s:s:0" "language=eng" "-metadata:s:s:0" "handler_name=English" "-metadata:s:s:0" "title=English" -movflags "+faststart" "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].temp.mkv"
Deleting original file 「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].en.vtt (pass -k to keep)
[Metadata] Adding metadata to "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv" -map 0 -dn -ignore_unknown -c copy -write_id3v1 1 -metadata "title=「Creditless」Urusei Yatsura (2022) OP / Opening 2「UHD 60FPS」" -metadata "date=20230106" -metadata "description=Urusei Yatsura (2022) Opening Theme 2 \"I Wanna Muchuu (アイワナムチュー)\" by MAISONdes feat. asmi, Surii (すりぃ)
TV Anime \"Urusei Yatsura (2022)\" Opening Theme 2
Lyrics by @bruhclan41

------------------------------------------------------------------------------------
⎚ Anime : Urusei Yatsura (2022) / うる星やつら
✎ Artist / Singer : MAISONdes feat. asmi, Surii (すりぃ)
♫ Song Title : I Wanna Muchuu (アイワナムチュー)

➤Endcard made by me
➤Support me on Patreon: https://patreon.com/triaxfx
------------------------------------------------------------------------------------
Copyright:
Be aware this channel is only for promotion purpose. All music belongs to the original creators." -metadata "synopsis=Urusei Yatsura (2022) Opening Theme 2 \"I Wanna Muchuu (アイワナムチュー)\" by MAISONdes feat. asmi, Surii (すりぃ)
TV Anime \"Urusei Yatsura (2022)\" Opening Theme 2
Lyrics by @bruhclan41

------------------------------------------------------------------------------------
⎚ Anime : Urusei Yatsura (2022) / うる星やつら
✎ Artist / Singer : MAISONdes feat. asmi, Surii (すりぃ)
♫ Song Title : I Wanna Muchuu (アイワナムチュー)

➤Endcard made by me
➤Support me on Patreon: https://patreon.com/triaxfx
------------------------------------------------------------------------------------
Copyright:
Be aware this channel is only for promotion purpose. All music belongs to the original creators." -metadata "purl=https://www.youtube.com/watch?v=aLgfFwAHb3I" -metadata "comment=https://www.youtube.com/watch?v=aLgfFwAHb3I" -metadata "artist=TriaxFx" -movflags "+faststart" "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].temp.mkv"
[debug] ffprobe command line: ffprobe -hide_banner -show_format -show_streams -print_format json "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv"
[EmbedThumbnail] ffmpeg: Adding thumbnail to "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].mkv" -map 0 -dn -ignore_unknown -c copy -attach "「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].png" "-metadata:s:3" "mimetype=image/png" "-metadata:s:3" "filename=cover.png" -movflags "+faststart" "file:「Creditless」Urusei Yatsura (2022) OP ⧸ Opening 2「UHD 60FPS」 [aLgfFwAHb3I].temp.mkv"

Use --write-subs and check if the resulting file has subtitle info. The one I got does, and it plays with proper styling in mpc-hc though not in mpv. Most likely, it's your player that does not support styled vtt


Add missing include

This patch allows the header to be built standalone, as part of clang C++ modules builds.

Closing in favor of a upcoming one.


Getting 404 errors when attempting to access a user's playlists

I'm using Node version 5.5.0, and spotify-web-api-node version 2.3.0. I'm using the following function to get the playlists from my own Spotify account.
var SpotifyWebApi = require('spotify-web-api-node');
var clientId = '<client id>';
var clientSecret = '<client secret>';

var spotifyApi = new SpotifyWebApi({
    clientId: clientId,
    clientSecret: clientSecret
});

function getUserPlaylists(userId) {
    spotifyApi.clientCredentialsGrant()
        .then(function(data) {
            spotifyApi.setAccessToken(data.body['access_token']);
            spotifyApi.getUserPlaylists(userId)
                .then(function(data) {
                    console.log(data);
                }, function(err) {
                    console.log('Something went wrong!', err);
                });
        }, function(err) {
            console.log('Something went wrong when retrieving an access token', err);
        });
}

However, whenever I call this function with my own Spotify user ID (I signed up with Facebook), I get the following error: Something went wrong! { [WebapiError: Not found.] name: 'WebapiError', message: 'Not found.', statusCode: 404 }. Other API functions work still, but all of a sudden this one ceased to work even though I haven't touched my server or the code for my server since it was working well. I checked the endpoints in the spotify-web-api-node source code and they seem to still be correct for getUserPlaylists.

@jswny What is the user_id you are trying? I'm checking the source code and the endpoint looks correct. I'm wondering if some character in the user_id is breaking the url requested.

@JMPerez I thought about that too. However, I didn't actually try encoding the user ID though because it's just numbers (because I'm signed in with Facebook). I'm using my user like so: getUserPlaylists('12186155030').

@jswny This should work without any problems. I just checked using the web api console and the Web API returns playlists data for that user, as expected.
I also tried it using the wrapper, with positive results:
var spotifyApi = new SpotifyWebApi();
spotifyApi.setAccessToken('BQAQngO....jYv4g');
spotifyApi.getUserPlaylists('12186155030').then(function(data) {
  console.log(data.body);
});

which outputs:
{ href: 'https://api.spotify.com/v1/users/12186155030/playlists?offset=0&limit=20',
  items:
   [ { collaborative: false,
       external_urls: [Object],
       href: 'https://api.spotify.com/v1/users/12186155030/playlists/7Mwujrto3KiamiiBwbUhT8',
       id: '7Mwujrto3KiamiiBwbUhT8',
       images: [Object],
       name: 'Peep Game',
       owner: [Object],
       public: true,
       snapshot_id: 'ENqNKgOb1d0CIvPJjb7SE7Le2ApBz6r/eGU11/E41fGyOVNwzQu2SsN7SUKM9Vef',
       tracks: [Object],
       type: 'playlist',
       uri: 'spotify:user:12186155030:playlist:7Mwujrto3KiamiiBwbUhT8' },
     { collaborative: false,
     ...

Just to double check, it might be useful to print out the actual URL that is being requested, eg printing the value of uri in HttpManager._makeRequest().

Well, I have no idea what happened. I was debugging around with the code on my local machine and suddenly it started working. I narrowed the problem down to getting the playlist data for each playlist returned by spotifyApi.getUserPlaylists() using spotifyApi.getPlaylist() because I was getting an error there. Then all of a sudden, I reset the process on my local machine after making some changes and it just worked. I have no idea why. I went onto my website (which is on a completely different production server which I have not touched, not even using SSH, throughout this whole process), and magically, it works. I'm baffled. The only thing I could possibly think of is that while I was clicking around in the Spotify app I made some playlist public which wasn't before and that made it so my code could loop through getting the playlist data of each playlist?

Once again, after having changed absolutely nothing on my production server, I'm getting the same error again. Testing my site on my local machine yields the same results. Upon further investigation, I've found the problem. After I grab the user's playlists, I'm iterating over them like this:
spotifyApi.getUserPlaylists(userId)
	.then(function(data) {
		var playlists = data.body.items
		var playlistsArr = new Array()
		var count = 0
		playlists.forEach(function(playlist) {
			spotifyApi.getPlaylist(userId, playlist.id)
				.then(function(data) {
					playlistsArr.push({
						name: playlist.name,
						id: playlist.id,
						img: playlist.images[2].url,
						followers: data.body.followers.total,
						total_tracks: playlist.tracks.total
					})
					if (count == playlists.length - 1) {
						callback(playlistsArr)
					}
					count++
				}, function(err) {
					console.log('Something went wrong retrieving an individual playlist!', err)
				})
		})
	}, function(err) {
		console.log("Something went wrong retrieving the user's playlists!", err)
	})

However, the page would hang and never load, which was the reason I started noticing this problem. Turns out, some of the Spotify playlists that I followed were made public on my profile, thus they were pulled into what my code thought was an array of my playlists. Then, when I tried to use getPlaylist(userId, playlist.id) it would hang. That's because those other playlists that I had followed were not mine, so when I looped through one of those, the whole script would hang. To fix this, I've made all of those secret but you could just as easily check each playlist for the property collaborative or something similar before looping through each one. That would explain the 404 errors as well because the API was trying to access a playlist that didn't exist from my user ID. This turned out to be my incompetence, nothing wrong with any of the tools I was using. Hopefully this helps others to fix this mistake more easily. Thank you @JMPerez for the help.

Ran into the same problem when using getPlaylistTracks(). Fixed it by passing playlist.owner.id rather than user.id


ci(rust): add check ci

link to #459

Codecov Report

Merging #490 (564d6bd) into master (585f93e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #490   +/-   ##
=========================================
  Coverage     45.60%   45.60%
  Complexity      646      646
=========================================
  Files           207      207
  Lines         11452    11452
  Branches       2892     2892
=========================================
  Hits           5223     5223
  Misses         6004     6004
  Partials        225      225

Flag
Coverage Δ

rust
84.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

rust/src/lib.rs
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Can you collect the Rust related checks into the job of rust-build, since build-result collects the results of all language builds and is required? If the Rust checks can be classified into rust-build, then as long as build-result is successful, it indicates that all Rust checks have been successful.

build-result collects all results: https://github.com/apache/rocketmq-clients/actions/runs/4763211461?pr=490

https://github.com/apache/rocketmq-clients/actions/runs/4763211432?pr=490

https://github.com/apache/rocketmq-clients/actions/runs/4763211461?pr=490

IMO, code style check is different from rust-build. Additionally, rust-build will be processed in the different platforms which are meaningless for the code check.

You are right, general checks do not usually require cross-platform operation systems.
Meanwhile, we can actually specify these checks to a single or other platforms, referring to opentelemetry-instrumentation-compatibility. see: https://github.com/apache/rocketmq-clients/actions/runs/4668191248?pr=472

https://github.com/apache/rocketmq-clients/actions/runs/4763211461?pr=490

IMO, code style check is different from rust-build. Additionally, rust-build will be processed in the different platforms which are meaningless for the code check.

Sorry, I think my previous expression was not accurate, confusing the job and workflow files. You can refer to the latest comments.

I have merged rust-check and rust-build. The build job depends on fmt check and msrv check for now.


feat(theme-classic): standalone Admonition component

Motivation
We should prepare to ditch remark-admonitions because:

It is very unmaintained;
It is coupled to Infima;
It isn't compatible with Remark v13.

In addition, we should have a standalone admonition element for people to use outside of Markdown.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
https://deploy-preview-5848--docusaurus-2.netlify.app/docs/next/markdown-features/admonitions/#usage-in-jsx

We can fork remark-admonitions and improve it by making it compatible with Remark 13, etc. It's actually a handy shortcut for inserting admonitions, many users already use it, and are unlikely to want to opt-out from it.
So having React implementation of this element seems superfluous code duplication, especially since it was intended solely for use in content MD files.

We can fork remark-admonitions and improve it by making it compatible with Remark 13, etc. It's actually a handy shortcut for inserting admonitions, many users already use it, and are unlikely to want to opt-out from it.

That's what I plan to do afterwards—fork remark-admonitions, either in our repo or in the docusaurus org if we ever see its birth. I believe our impl of remark-admonitions should make it transpile to a @theme/Admonition comp rather than hard-coded markup with interleaved Infima references, because that's not scalable to multiple themes, hence this PR.

So having React implementation of this element seems superfluous code duplication, especially since it was intended solely for use in content MD files.

I was actually asked not a single time "how to use admonitions outside Markdown" and I also wondered about that from time to time. It's not a bad move IMO given my reasonings in the PR description about why the current state of remark-admonitions is not ideal.

We should probably migrate to https://github.com/remarkjs/remark-directive because it may be standardized in CommonMark someday (I'm not sure how this std process works but there are extensive discussions here: https://talk.commonmark.org/t/generic-directives-plugins-syntax/444)
This directive plugin is supported Titus so I'd prefer to use it for admonitions (and likely other use-cases too) rather than migrating the existing admonitions to Remark 13.
I'd also prefer to not introduce this extra theme component until we do this migration, because that migration + the better support for CommonMark is likely to help us define a better API surface for this component.
So, overall I'm 👍 for having a @theme/Admonitions component, but I don't think it's good timing and we should migrate to MDX 2.0 first.

We should probably migrate to https://github.com/remarkjs/remark-directive because it may be standardized in CommonMark someday (I'm not sure how this std process works but there are extensive discussions here: https://talk.commonmark.org/t/generic-directives-plugins-syntax/444)

I'm aware of that plugin and also the fact that it's MDX 2.0. To migrate to MDX v2 we need ESM hence #5816.

I'd also prefer to not introduce this extra theme component until we do this migration, because that migration + the better support for CommonMark is likely to help us define a better API surface for this component.

I'm not aware of how CM helps us with internal implementations🌚 Suppose we have another tailwind theme. How would we go about reconciling them without introducing a theme comp?
Also, I'm just wishing for an OOTB admonition comp that I can use for my React page. It's weird to use many documentation features in React but why not

I'm in favor of having this new @theme/Admonition comp for the same reasons as you do.
I just want to delay introducing that comp for now, but rather do this later to ensure that the comp's API is compatible with our MDX 2 setup

Ah, no problem. We have a lot of PRs depending on each other now :D Maybe we should make a roadmap or something to keep track of them. A simple milestone doesn't seem enough

So interestingly, as MDX v2 migration is postponed to v3, this PR can now be pushed forward because the API would at least be stable for v2

After further study I don't think adding this component now will be more challenging anyway so it seems safe enough to add now
thanks


Papers that use OpenFermion

I think it would be nice to keep a list of publications that use OpenFermion in some way. Perhaps when people publish a new paper they can mention it here and give a small description. Since I have put out several papers using OpenFermion I will start us off. Maybe at some later point when (and if) we make an OpenFermion website other than GitHub, we can publish a nicer list of these papers.

Low Depth Quantum Simulation of Electronic Structure. Ryan Babbush, Nathan Wiebe, Jarrod McClean, James McClain, Hartmut Neven and Garnet Chan. arXiv:1706.00023. 2017.
This paper discusses the use of special basis sets which change the structure of molecular Hamiltonians in order to obtain a simpler representations that is more efficient to simulate using quantum computers. We used OpenFermion to check a number of equations in the paper, especially derivations involving the fermionic Fourier transform. We also used OpenFermion to check bounds of operators and the coefficients of Hamiltonians after transforming with Jordan-Wigner.

Improved Techniques for Preparing Eigenstates of Fermionic Hamiltonians. Ryan Babbush, Dominic Berry, Mária Kieferová, Guang Hao Low, Yuval Sanders, Artur Scherer and Nathan Wiebe. arXiv:1711.10460. 2017.
This paper discusses several techniques for using the phase estimation algorithm to prepare ground states of fermionic systems with reduced overhead. The second result of the paper explains that in circumstances when one has knowledge of an upper-bound on the ground state energy that is tighter than the first excited state, one can use the knowledge to make fewer repetitions of the phase estimation algorithm. OpenFermion is used for some numerics in this paper which investigate the usefulness of this technique for the water molecule. To produce these numerics we used OpenFermion and OpenFermion-Psi4 to generate molecular Hamiltonians, computed an induced L1 norm of those Hamiltonians, checked ground state overlaps and obtained ground state and excited state energies.

Bravyi-Kitaev Superfast simulation of fermions on a quantum computer._ Kanav Setia, James D. Whitfield. arXiv:1712.00446v1. 2017
This paper details the Bravyi-Kitaev Superfast (BKSF) algorithm implemented in the OpenFermion. Starting from the electronic Hamiltonian, the details for mapping all the fermionic operators to qubit operators using BKSF transform are presented. Hydrogen molecule is used as test case in the paper and the final qubit Hamiltonian using BKSF transform is presented. The results section compares Jordan-Wigner, Bravyi-Kitaev, and BKSF algorithms using Trotterization.
All the expressions used in the OpenFermion code for BKSF algorithm are described in the paper.
Test case of hydrogen molecule in the paper was used to develop test routines for the code. OpenFermion-Psi4 was used to get the integrals for the hydrogen molecule.

Quantum algorithms to simulate many-body physics of correlated fermions. Zhang Jiang, Kevin J. Sung, Kostyantyn Kechedzhi, Vadim N. Smelyanskiy, and Sergio Boixo. arXiv:1711.05395. 2017.
This paper gives quantum algorithms for preparing eigenstates of quadratic Hamiltonians and for performing the 2-d fermionic Fourier transform. The routines in OpenFermion for obtaining circuits to prepare Slater determinants and fermionic Gaussian states is based on the procedure described in this paper. The paper can be consulted to understand the circuit descriptions output by the code.

Quantum simulation of electronic structure with linear depth and connectivity. Ian D. Kivlichan, Jarrod McClean, Nathan Wiebe, Craig Gidney, Alán Aspuru-Guzik, Garnet Kin-Lic Chan, Ryan Babbush. arXiv:1711.04789. 2017.
In this paper, we show that by using an arrangement of gates that we term the fermionic swap network, we can simulate a Trotter step of the electronic structure Hamiltonian in exactly N depth and with N^2/2 two-qubit entangling gates, and prepare arbitrary Slater determinants in at most N/2 depth, using only a minimal, linearly connected architecture. We used OpenFermion to verify numerically the Trotter step we developed. Our code is included in OpenFermion-ProjectQ.

Efficient Implementation of Baker-Campbell-Hausdorff Formula
Cupjin Huang  https://arxiv.org/abs/1712.01348.  2017
This short paper presents an efficient implementation of Baker-Campbell-Hausdorff formula for calculating the logarithm of product of two possibly non-commutative Lie group elements using only Lie algebra terms.

At this point a lot of papers are using OpenFermion. I'm not sure if we still need this open.


⚠ Bofrost.fr has degraded performance

In 14523aa, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1573 ms

Resolved: Bofrost.fr performance has improved in 2dfa202.


Support for placeholders, @ commands?

Nice Job!
Would it be possible to add some kind of placeholder support?
Something like type @ and then get a list of possible names etc to be inserted.
But then again, not able to adjust any of the name/placeholder without first removing it again (so not just adding the text)?

Hi! From what I understand you'd like a list to pop up when you type @, and to be able to select on the list options to generate some predefined text. That's kind of similar to what the slash/emoji plugins do, and you can create an extension that do that.
You can look at packages/plugin-emoji/src/lib for a reference, there is a bit of boilerplate but you get an idea.
However I do not understand what you mean with "not being able to adjust any of the name/placeholder without first removing it again": you don't want the user to modify the created text? In this case the first thing it comes to my mind is to listen for values change and, if the change modifies one of the "placeholder" texts, just revert it back, but I'm not sure that's what you meant.

Hello again,
regarding positioning elements next to the cursor: I added a new function in the latest version which makes positioning elements next to the caret much easier. Here's an example:
<script>
  // ...

  export let carta;

  let caretPosition;
  let elem;

  onMount(() => {
    carta.input.addEventListener('input', handleInput);
  });

  onDestroy(() => {
    carta.input.removeEventListener('input', handleInput);
  });

  function handleInput() {
  	 caretPosition = carta.input.getCursorXY();
  }

  $: {
    caretPosition, elem.clientWidth, elem.clientHeight;
    carta.input.moveElemToCaret(elem);
  }
</script>

<div bind:this={elem}>
  <!-- My stuff -->
</div>

To use the new moveElemToCaret function, you need to update to version 2.3.0.
About deleting the whole name: while the editor you mentioned is node based, Carta only uses pure text. For this reason, you need to manually check for changes/override the default functionality, but you can definetely do that. For example:

Listen for inputs and check for invalid tags, remove them if any is found,
Listen for caret(cursor) movement(using keyboards keys and clicks) and if it is over a tag, move the caret away.

I also suggest you add a custom hightlight rule to make tags prettier, you can look at plugin-math for an example but basically you need to add this prop to the extension:
shjRef: (shj) => {
	import('./lang.js')
		.then((module) => shj.loadCustomLanguage('langName', module))
		.then(() => carta.input?.update());
}

Where lang.js is just a file containing highlight rules, for example in your case
export default [
	{
		match: /\B@\w+/g,
		type: 'str'
	},
]

Let me know if you have any issue


[CORE] Fixes for GetApplicationDirectory on 32 bit windows builds

This PR fixes an issue with the function signatures of the windows calls used by GetApplicationDirectory so that they work on 32 bit builds. No functionality has changed.

Note that without this change, 32 bit builds on windows (with Visual Studio, and GCC) are broken.

Thanks for the fix @JeffM2501!


Hex.pm version is missing UUID

I have got the latest version 0.10 using hex.pm{:faker, "~> 0.10"} I have checked the downloaded dependency it doesn't contains the UUID module.

Hi @steffel-monaco, it's not released yet, you can check what and when was released here.


updated go to version 1.15.7 to fix CVE-2021-3114 and CVE-2021-3115

/cherry-pick release-3.6

/cherry-pick release-3.6


applied terraform 0.12upgrade

duplicates https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/20


[Feature request] Disable item drop despawns.

Describe the feature you'd like to see added
I noticed while playing this game (I haven't played it a lot) that item drops from enemies despawn after a short while if you don't pick them up, it's kind of frustrating when I'm being surrounded, where i have to decide to either ignore the item completely and risk missing out on it, or sacrifice health in order to pick it up. So I suggest maybe a feature to either change the time it takes for items to despawn or a feature do disable item despawn completely.

I believe this can be achieved as user Kteo once told me that this disappearance of items after spawning can vary depending on which AuraType is used.
To have an item stay (and even by available when re-entering the room we have to use AuraType 0x7, 0x8, 0x2. I have explained it a bit HERE.
The only thing about this is that using different AuraTypes might actually change the color of the drops. I can provided offset addresses for those, or help testing ITA if anyone wants to pursue this.

it's kind of frustrating when I'm being surrounded, where i have to decide to either ignore the item completely and risk missing out on it, or sacrifice health in order to pick it up.

youre describing part of whats so fun about the resource management and combat dynamics as if its a negative?

youre describing part of whats so fun about the resource management and combat dynamics as if its a negative?

I mean if you enjoy that, then more power to you. It's just not my cup of tea, feels more like an oversight or remnant/side-effect of the game originally having come out on the GameCube, especially since items seem to stay indefinitely in the remake, at least from what I can tell of the little I've played of it. Thus this part of the original feels a bit annoying on modern platforms when there's an item right there in front of me, and then I turn away to both avoid and kill a ganado or something, only to then turn back around to find the item I saw earlier having disappeared.

I believe this can be achieved as user Kteo once told me that this disappearance of items after spawning can vary depending on which AuraType is used in the ITA entry for that item.

Would I be right in assuming that this would require hex editing? I'm not really familiar with the ins and outs of RE4 on steam, nor the original ubisoft pc port, so at the current time I don't really trust myself modifying the game files on my own.

To manually adjust all the aura types in all the game files would be a tremendous undertaking, however code that would overwrite entries loaded into memory would be a much easier undertaking, but would require knowledge of the the game files, in particular the ITA file.

To manually adjust all the aura types in all the game files would be a tremendous undertaking, however code that would overwrite entries loaded into memory would be a much easier undertaking, but would require knowledge of the the game files, in particular the ITA file.

Like I stated earlier I sadly lack that kind of knowledge, in fact I've never modded RE4 before in any capacity other than this "tweaks" mod, which was easy enough to install and manage.


replace images with inline svg icons

we should get rid of these  dist/img/network and replace them e.g. with some inline (dataurl) svg images.

+1
Some SVG can be taken form here https://iconsvg.xyz/

We need replacements for the following icons:

I think these can be done in pure css:

We need replacements for the following icons:

I think these can be done in pure css:

Pure CSS Close (cross) Icon https://codepen.io/Bharek/pen/XJvVLj

We need replacements for the following icons:

I think these can be done in pure css:

Should we maintain colours of icons? I think it would be better to have single colour icons aka flat.

Should we maintain colours of icons? I think it would be better to have single colour icons aka flat.

:+1: I also think we should get rid of the colors. If we use inline SVG maybe the user could change the color with custom css later.

It could look like this, I just created a branch in my fork to test icons, a took some icons from iconsvg.xyz and some if them I drawn myself.

It could look like this

Wow! This would be a perfect replacement!
For me it is important that we get rid of the single image-files. They should be included e.g. as data-urls inside in its own css.

It could look like this

Wow! This would be a perfect replacement!
For me it is important that we get rid of the single image-files. They should be included e.g. as data-urls inside in its own css.

Hmm. I can try to embed them as data:svg+xml into CSS

If I embed like this - users can not change the color of the SVG.
div.vis-network div.vis-navigation div.vis-button.vis-zoomExtends {     background-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' class='vis-icon vis-icon--zoom-extends' width='30' height='30' viewBox='0 0 24 24' fill='none' stroke='%23808080' stroke-width='2' stroke-linecap='square' stroke-linejoin='arcs'%3E%3Cpath d='M7.027 7.027l9.946 9.946m0-9.946l-9.946 9.946m6.792-10.43h3.64v3.64m-7.278-3.64h-3.64v3.64m7.278 7.278h3.64v-3.64m-7.278 3.64h-3.64v-3.64' stroke-width='1.6'/%3E%3Ccircle cx='12.102' cy='12.102' r='10'/%3E%3C/svg%3E");     bottom:50px;     right:15px; }

What about stroke='currentColor'?

@Thomaash what do you mean?
if we use SVG as background-image we have no access to it's internals. We can only apply CSS colors when SVG is inlined into HTML.

What about stroke='currentColor'?

It can ba applied only to inlined . Css not applied to other documents, when SVG is data:image it treated like external doc.

You have hardcoded color in your SVG stroke='%23808080'. Just try to replace it with stroke='currentColor' then it should respect the color set by CSS.

You have hardcoded color in your SVG stroke='%23808080'. Just try to replace it with stroke='currentColor' then it should respect the color set by CSS.

It won't work. Take a look https://jsfiddle.net/v3ag0cs6/37/

The value currentColor uses the text color (color) not stroke, see updated: https://jsfiddle.net/thomaash/x67gLzpa/ .

The value currentColor uses the text color (color) not stroke, see updated: https://jsfiddle.net/thomaash/x67gLzpa/ .

But it's only for inline SVG. Here my updated example https://jsfiddle.net/q9Lh017r/1/
CSS is not applied to data-url encoded SVG.
The only way to allow users change the color is to inline SVG.

Oh, you're right.

@Thomaash I propose at first to replace PNG to SVG - it the fastest way. Next we can open another issue to "embed svg icons into JS".

We can do it in two stages.

OK. I'll do the first - PNG to SVG replacement. It almost ready

Although we may cause some problems to people using this. They now have their .png images and we'll start loading .svg images which they don't have. It will be better to do it all at once so we can just say “hey, you no longer need the images” instead of making them update them just to throw 'em away with the next release.

@Thomaash ok. So you propose to inline the SVG to the JS code?

Yeah, although I would like them more inlined in CSS but since SVG injected into HTML from JS can be colored using CSS (some people will definitely appreciate this) I'd go with inlining into JS.

A little of topic but here is a litte example ho to replace the images with simple unicode icons (without optimization):
https://stackoverflow.com/a/45307412/722162

@Thomaash I have finished the replacement https://github.com/r3code/vis-network/commit/0394ef629f41ef3b728888a11ba32f7b7187754c
@mojoaxel Hmm. So what is better?

A little of topic but here is a litte example ho to replace the images with simple unicode icons (without optimization):
https://stackoverflow.com/a/45307412/722162

I  propose to use SVG icons by default and add an extra example how to replace navigation buttons.
For 90% of users SVG buttons is pretty enough IMO. Other can override CSS using the example https://github.com/visjs/vis-network/issues/31#issuecomment-529229893 by @mojoaxel

We should not use UTF-8 characters as icons. We do not ship any font and therefore there is no guarantee that the characters rendered will look the way we want them to look. We could end up with quite different characters or even rectangles or question marks if someone's font doesn't have these characters (who knows what fonts are people using on their pages or in their browsers in case of default font face). Images give us much more consistent experience, reliability and also more freedom when it comes to design.

I have a few questions and objections to the draft:

Manipulation GUI:

Why are the icons in circles? If you want to keep the circles (I would remove them personally) make them align with the edges of the buttons their in (the way it was before).
Why are some of the icons in circles so close to the circle? Their almost touching it. It looks really weird when some are nicely spaced and some are crammed.
Why does edit edge use the same icon as add edge? Especially since edit node uses edit icon which makes more sense.
Since there is special add edge icon there should also be special add node icon not just a plus in a circle.
The close button should definitely be bigger than it used to be but this seems a bit too big.

Navigation GUI:

The fit icon is too crammed compared to the other more spaced icons.
Why is there green glow after click? I though we decided to ditch colors. I suggest upscaling the icon on click instead of adding second circle around it.
The rest looks good.

* Why are the icons in circles?

Looks familiar.

* Why are some of the icons in circles so close to the circle?

Maybe because I draw myself very fast just to show others.

* Why does edit edge use the same icon as add edge?

Mistake )

* Since there is special add edge icon there should also be special add node icon not just a plus in a circle.

Maybe.

* The close button should definitely be bigger than it used to be but this seems a bit too big

I'd suggest to place it top left on the place of the Edit button, so when a user presses the Edit button it turns to "Close" button.  So the toolbar would become more friendly. It would have: Close, Add Node, Add Edge buttons by default.
For me its counter-intuitive to have all buttons in one style and have a Close button in another.

I like the idea of having Close        Add Node   Add Edge   … buttons.

* Why does edit edge use the same icon as add edge? Especially since edit node uses edit icon which makes more sense.

Fixed https://github.com/r3code/vis-network/commit/35c0f9b127e465bcd864d051a37c545da301d694

@r3code Did you open a PR yet? If not feel free to open a Draft Pull-Request so we can have a look :smiley:

@mojoaxel I did it my fork here https://github.com/r3code/vis-network/commit/35c0f9b127e465bcd864d051a37c545da301d694. But I have to merge with current origin before PR.


Remove sass-rails dependency (2nd attempt)

This pull converts social-share-button.scss to plain CSS, so that the dependency on sass-rails is no longer required. That dependency is problematic for us because we have converted to the much faster sassc-rails, which uses C-based libsass instead of ruby-based sass, and sass-rails and sassc-rails don't play nicely together.

version 0.8.8


Upd. SluggableTrait.php - handle key alternatives

Permit to use this syntax to use alternative value if a field value is null in build_from param :
'build_from' => ['table.field|alternative_table.alternative_field'],

Can I suggest a possibly better solution: make it possible to use a closure for the build_from configuration value?  Something like:
'build_from' => function($model) {
    if ($model->field === null) {
         return $model->alternate;
    }
    return $model->field;
}

I think you could not only achieve the same result that you are looking for, but it'd be flexible enough for lots of other scenarios.

I Agree, this is a much better solution, but also much more complex and impactant on your package code.
For now build_from is defined in a protected attribute of the model, wich is a cool thing but it do not allows expressions or closures as values.
I also think that both solutions can be interesting to implement, a simple one to handle a common case, and a more subtile one to handle specific logic cases.
How do you want to deal with this situation ?

Will you consider accept my pull request, even if you plan to make it possible to use closures in build_from configuration value ? I'm still thinking it's a simple and usefull enhancement.

Actually, there is a much easier solution -- just create a special accessor method that handles all the logic.
'build_from' => 'special_slug_source',
...

public function getSpecialSlugSourceAttribute() {
    return $this->field ?: $this->alternate;
}

Clever and beautiful solution, thanks a lot !


Enable data for any viz to come from a vector tile source

Problem
Currently, each viz class data object only supports geojson format data from a URL or local variable geoJSON format object.  We should enable users to pass a data as a vector tile source.
Implementation
I propose we maintain that the data object should be a URL or local geoJSON format object.  We can add another optional parameter to each parent viz class named vector_source_layername.  This will parameter specifies the name of the vector tile layer to create the visual from a layer in a vector tile.
If the user passes the optional vector_source_layername parameter, the visualization will create a layer from a vector tile source instead of a geojson source.

Adding this to the 0.7.0 release - it's super powerful to connect any vector tile source to any visualization type with essentially infinite data volume.  The only exception we'll need to make here is for cluster maps, which are not compatible with Mapbox Vector Tile sources.
To Do

[ ] Accept a vector tile URL as in the map data parameter
[ ] Add a new parameter to the map, dataLayerName.  Accept a string value here that maps to the vector tile source's layer name.
[ ] If the datatype argument is set to vectortile, change the map.addSource() call in each template to point to the vector type and url argument.  Also change the map.addLayer() call in each template to use the source-layername of the vector tile.
[ ] Create tests
[ ] Create example notebook using vector tile sources for each visualization type (all except Cluster)

@ryanbaumann I'm willing to work on this one (it also helps with the multi-layer maps) but often struggle to find good test data. Can you possibly create and share a vector layer of the healthcare example data so I can work the data join with example data we already have in this project?

@akacarlyann that's amazing - thank you for offering to help!
I have.....a lot of tilesets you can test with.  Here's a public tileset of the healthcare data that you can use with any Mapbox access token - rsbaumann.2pgmr66a

@ryanbaumann Thanks!  What's the name of the layer for that vector dataset?

@akacarlyann updated the comment above with the source-layer name of the tileset.

@ryanbaumann  I've got CircleViz and GraduatedCircleViz working with vector tiles, so thanks for that!  Per https://github.com/mapbox/mapbox-gl-js/issues/5856, looks like cluster maps don't support using vector source data at this time.  Thoughts on if we should punt this or ...?

This is awesome!  Unlocks the ability to run a bigger data analysis, cut vector tiles from the analysis, and visualize them right in Jupyter.  Yes, we'll need to integrate a tool to cut vector tiles, ideally using tippecanoe for maximum performance.

looks like cluster maps don't support using vector source data at this time

Correct - you can cluster data to put into a vector tile source using Tippecanoe, but can not create a cluster from a vector tile source on the fly without some custom code.  Agreed, skip support for vector tile sources on a cluster.


Fix spvc_type_get_vector_size C function.

Fix spvc_type_get_vector_size C function.

Derpy derp.

Any chance to get new artifacts with this fix?

I've made a new tag. A build should appear in a few hours.


Returning an async iterable

Hi! Is it possible to get an async iterable from a highland object? I'd like to be able to consume it with for-await-of if possible.

Yes, it is possible. The trick is to transform your highland stream into a Node Readable stream which automatically implements the Symbol.asyncIterable method.
const stream = require("highland");

// Just an example to simulate async work
function delay (ms) {
  return x => stream(push => {
    setTimeout(() => {
      push(null, x);
      push(null, stream.nil);
    }, ms);
  });
}

const source = stream([ 1, 2, 3 ])
  .flatMap(delay(1000));

(async () => {
  for await (let value of source.toNodeStream({ objectMode: true })) {
    console.log(value);
  }
})();


Fixes 4826: prevent adding systems if env not yet created

Summary

Checks if environment is created (rhsm_environment_created == true) before allowing user to assign the template to a system
Displays an error if the environment has not been created but the template's update task has finished

Testing steps
Since this depends on Patch's API, this needs to be tested on stage (npm run start:stage). You will also need to have registered at least one system on stage.

Create a template and select Create template and add to systems to navigate to the AddSystemModal
Select a system. The Assign button should be disabled for a few seconds and have a tooltip. Once the template's update task has finished and the environment was created, the button should be enabled

/retest

seeing something weird here, it seems like rhsm_environment_created doesn't stay true if the template sits for a while? if we try to assign a template to a system a day or so after the template was created, its rhsm_environment_created value will be false after initially being set to true, so we won't be able to assign it unless we update the template. looking into it now

/retest


Starting to build out testing

The coverage is abysmal at the moment -- just want to make sure GitHub actions is configured correctly.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@ace02e9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop       #2   +/-   ##
==========================================
  Coverage           ?   34.69%
==========================================
  Files              ?        6
  Lines              ?      196
  Branches           ?        0
==========================================
  Hits               ?       68
  Misses             ?      128
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace02e9...fb053f6. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@ace02e9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop       #2   +/-   ##
==========================================
  Coverage           ?   34.69%
==========================================
  Files              ?        6
  Lines              ?      196
  Branches           ?        0
==========================================
  Hits               ?       68
  Misses             ?      128
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace02e9...f4066e3. Read the comment docs.


MAINT Update version number to 3.0.0

Prepare for next release

There is an ipython major version change. Not sure if we need to start at 3.0.0 now....

Arguably every pandas minor version increase is a breaking change. IPython's changes look rather light -- I think that removing Python 2 support was their big breaking change. http://ipython.readthedocs.io/en/stable/whatsnew/version6.html#backward-incompatible-changes
I bumped to v3.0.0 anyway.

Agreed on the pandas changes. Sounds good.

@beckermr , I updated the date to today. I think we're ready to merge this and release. What do you think?

Shall we take guesses on when we get to version 10, price-is-right style? :) J/K. (But I have October 1st 2017!)
LGTM!


PowerAI / support for ppc

What would it take / what would need to be changed for Turi Create to work on IBM PowerAI machines? I'm sure the Power community would love to see Turi Create.

Hmmm.... How intriguing. I suspect not very much. All platform dependent code should be isolated in src/platform. And if boost::fiber / boost::coroutine supports that platform too I suspect it should be possible. Someone with a PowerAI machine could try this out.

I'd be glad to provide anyone with a PowerAI machine to try this.


Add test for subset that returns no features for a given layer.

Can do this against the test data for new_hope that will come in through #53

Also add test for "Got NHDPlus data without a Terminal catchment. Attempting to find it." warning using the same data. See test data creation script for reproducible sample.

Going to close as a won't fix for now. Don't want to bring in a bunch of new data to test little stuff like this.


Error on User Menu when logging out

Describe the bug
Error when logout
To Reproduce
Steps to reproduce the behavior:

Go to Explore
Click on Avatar
Click on Log out button
See errors In the console:

[GraphQL error]: Message: Only collective admins can see pending invitations, Location: [object Object], Path: memberInvitations
Uncaught (in promise) ApolloError: Only collective admins can see pending invitations

Expected behavior
Page without errors
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser: [e.g. stock browser, safari]
Version: [e.g. 22]

Additional context
Add any other context about the problem here.

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

This was already fixed.


opensnitch-ui: 1.6.4 -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for opensnitch-ui is: An application firewall
meta.homepage for opensnitch-ui is: https://github.com/evilsocket/opensnitch/wiki
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS> with grep in /nix/store/c4c5zv162wf3ax84v2xsnz2rhlzfr4m5-opensnitch-ui-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/c4c5zv162wf3ax84v2xsnz2rhlzfr4m5-opensnitch-ui-<IP_ADDRESS>

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
opensnitch-ui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c4c5zv162wf3ax84v2xsnz2rhlzfr4m5-opensnitch-ui-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opensnitch-ui https://github.com/r-ryantm/nixpkgs/archive/c9a8b17a468a931ab1dca65c62667a207881d278.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c9a8b17a468a931ab1dca65c62667a207881d278#opensnitch-ui

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c4c5zv162wf3ax84v2xsnz2rhlzfr4m5-opensnitch-ui-<IP_ADDRESS>
ls -la /nix/store/c4c5zv162wf3ax84v2xsnz2rhlzfr4m5-opensnitch-ui-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opensnitch-ui

Maintainer pings
cc @onny for testing.

@ofborg eval

covered by https://github.com/NixOS/nixpkgs/pull/276468


The 3.1.0 dotnet-runtime-3.1 Linux packages say "3.1.0 Preview 3" in their descriptions (Debian + RPM)

Note that like the other issues with 3.1.0 (https://github.com/dotnet/core/issues/3950), the package's description says 3.1.0 Preview 3, but it actually installs a build that is essentially 3.1.0 stable, and it should work fine.
I saw this comment on the blog post calling out the problem: https://devblogs.microsoft.com/dotnet/announcing-net-core-3-1/#comment-4170.

I've tried installing 3.1.0 on Ubuntu 19.04 and CentOS 7, and "3.1.0" is installed on the machine:
$ dotnet --info
...
  Microsoft.NETCore.App 3.1.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

However the package description says "3.1.0 Preview 3"
$ yum info dotnet-runtime-3.1
...
Summary     : Microsoft .NET Core Runtime - 3.1.0 Preview 3 Microsoft.NETCore.App

This seems to be the same underlying problem that's caused the other 3.1.0 "Preview 3" issues. When I looked into it earlier, I found there weren't any differences that should matter to Linux users: https://github.com/dotnet/runtime/issues/492#issuecomment-561408378.
This may not be worth fixing until 3.1.1, due to the risk and cost in replacing the bad packages with the correct ones without advancing the patch version.
@leecow

Thanks for the tracking issue. Since this has the same root cause as the comments in https://github.com/dotnet/core/issues/3950 and https://github.com/dotnet/core/issues/3962,  closing as a duplicate.

@leecow to make sure the info's reachable here, do we plan to fix the Linux packages for 3.1.0 or not?

This will be fixed for all packages and installers exhibiting the behavior in 3.1.1 in January.

@leecow we installed 3.1.1 today and it still shows as preview


workload create on Windows throws "x509: certificate signed by unknown authority"

Please fill out the issue checklist below and provide ALL the requested information.

[x] I reviewed open and closed Github issues that may be related to my problem.
[x] I am reporting a bug that others will be able to reproduce.

Describe the bug
When I invoke tanzu apps workload apply or tanzu apps workload create on Windows, the command fails with exit status 1 & error:

Writing 'index.docker.io/atwoosnam/sample-app:latest': Writing image: Retried 5 times: Get "https://index.docker.io/v2/": x509: certificate signed by unknown authority

Expected behavior

No error
App image gets written to the repository provided as the --source-image parameter

Steps to Reproduce

Using a Windows OS...
Install tanzu cli + apps plugin
Clone sample java accelerator app & cd into repo
Try to push app to TAP via tanzu apps workload apply -f config/workload.yaml --live-update --local-path {PATH_TO_JAVA_ACCELERATOR_REPO} --source-image {YOUR_IMAGE_REPOSITORY} --namespace {YOUR_TAP_NAMESPACE} --yes
Notice "Error: Writing '{IMAGE}': Writing image: Retried 5 times: Get "https://{IMAGE_REPO_DOMAIN}/v2/": x509: certificate signed by unknown authority"

Screenshots

Version (Apps plugin version, Version of K8s running on cluster)
Put the output of the following commad
tanzu version && tanzu apps version

version: v0.11.6
buildDate: 2022-05-18
sha: 6819c5a1
v0.5.1

Environment where the bug was observed (cloud, OS, etc)
Windows 11 Enterprise, Version 21H2 (OS build 22000.675)
Additional context & Relevant Debug Output (Logs, etc)

I've tried changing these things without seeing the error change:

URL provided for --source-image:

harbor.dhaka.cf-app.com/awoosnam
hub.docker.com/repository/docker/atwoosnam/sample-app
hub.docker.com/atwoosnam/sample-app
index.docker.io/atwoosnam/sample-app
docker.io/atwoosnam/sample-app
docker.io/rkamaldocker/sample-app

different tanzu app commands

workload create and workload apply both give the same error

different shells in Windows:

Powershell (as administrator)
Git Bash (info)

I am able to push to my atwoosnam/sample-app image repository in DockerHub using the Docker CLI

My teammate @zzori-theoriginal got the same error when invoking tanzu plugin list on windows:

Hello @atwoosnam , Thank you for raising this issue, and appreciate the level of details provided in the description. There is a known issue with imgpkg versions 0.19.0 and below. See https://carvel.dev/imgpkg/docs/v0.29.0/ca-certs-windows/. We will upgrade the version of imgpkg used in the Apps plugin (currently 0.17.0) which should mitigate this issue.

FYI: This is not an issue specific to the Window's user as it also occurs when we push an image from local source project to a private images registry on a mac machine.
So we need somme additional parameters for the tanzu apps workload create/apply command as we have with imgpkg push command to disable the TLS verification (or to pass he CA cert)
imgpkg push --registry-verify-certs='False' ....

Error that I got on my mac machine
tanzu apps workload apply -f config/workload.yaml --local-path . --source-image registry.harbor.<IP_ADDRESS>.nip.io:32443/demo/tanzu-java-web-app-source -n demo-1
? Publish source in "." to "registry.harbor.<IP_ADDRESS>.nip.io:32443/demo/tanzu-java-web-app-source"? It may be visible to others who can pull images from that repository Yes
Publishing source in "." to "registry.harbor.<IP_ADDRESS>.nip.io:32443/demo/tanzu-java-web-app-source"...
Error: Writing 'registry.harbor.<IP_ADDRESS>.nip.io:32443/demo/tanzu-java-web-app-source:latest': Writing image: Retried 5 times: Get "https://registry.harbor.<IP_ADDRESS>.nip.io:32443/v2/": x509: certificate signed by unknown authority
Error: exit status 1

@cmoulliard Discussion related to supporting additional flags like the ca-cert is done in the following issue:
https://github.com/vmware-tanzu/apps-cli-plugin/issues/116


Prevent accidental reintroduction of Ord instances for keys

This is a rebase of https://github.com/input-output-hk/cardano-base/pull/158

bors merge

bors merge


How to disable category?

I can change category or delete. I want to make it disabled. Is there any suggestion to make it?

I'm not sure I understand your use case. How do you want to disable the category? In Saleor category is a required field for a product, you cannot disable it by default.

I just wonder is there any way to make category unpublished (like product)? Or just hide menu item that category linked on. Let say I have category "Christmas" and I want to make it published in winter months.

I think the general idea is that sometimes you want a category to be hidden, this could be because you are looking to populate it with products before putting it live or it is an targetted SEO landing page that you may want to be found by search engines but not linked directly from your store.

I just wonder is there any way to make category unpublished (like product)? Or just hide menu item that category linked on. Let say I have category "Christmas" and I want to make it published in winter months.

It seems to me that for such purposes it is better to use collections, rather than categories.


Show percentage progress when rendering

Implemented in https://github.com/kudlav/videoeditor/commit/e863ffcd650a1835da06c1f0bac14791fca3f495


[BUG] Why does increasing model_max_length result in fine-tuning not working?

Prerequisites

[X] I have read the documentation.
[X] I have checked other issues for similar problems.

Backend
Local
Interface Used
CLI
CLI Command
--model_max_length 128
--block-size 128 \
and
--model_max_length 4096
--block-size 4096 \
UI Screenshots & Parameters
No response
Error Logs
When I am trying to test my fine-tuning if it works, I have an input 'Who is Bob?' and an output 'Bob is Jack's uncle's father's mother's granddaughter's husband'. I have 42 samples of this exact same input-output.
This works flawlessly and the model is able to overfit and output the exact response when I ask it. This is just to test that the fine-tuning works.
However, when I up the model_max_length to 4096, with everything else the same, the model is unable to recall anymore. Why is this happening? Does increasing block_size / model_max_length simply results in the model not learning/overfitting anymore? How do I prevent this?
@abhishekkrthakur  some insights could be greatly appreciated.
Additional Information
No response

@abhishekkrthakur able to give insight on this? seems like a major bug..

@abhishekkrthakur  sorry, any insights on this?
It seems like when I increase the block-size / model_max_length during fine-tuning to be much greater than the input token length, the model is not able to learn anymore from the fine-tuning (even though its severely overfitted).

please be patient @jackshiwl . many times, immediate response is not possible :)
if your sentences are small and you are using large max len, it means there will be too many padding tokens, which may account for the model not learning properly. given your data, you should choose the best hyperparameters suitable for the model you are training. this is not a bug.

@abhishekkrthakur,

for the padding args, I have it set as default, so it is 'none'.
Even if there are paddings, I have tried to overfit it severely, by setting lots of epochs, etc. The loss goes down to abysmally small value, but it is still not able to recall the sample dataset (there is only 1 sample x42 times)

would appreciate if you can elaborate a little on what padding sides do you use for your own finetuning - and also for inferencing.


Update sdk 140

Description of changes:

update all packges
update IVS SDK to 1.4.0
convert class components to functional

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks good to me. Will merge and close this PR. Thanks!


Bump rules_scala to 6.6.0, rules_java to 7.10.0

rules_scala v6.6.0 updated all its repo names to include the version number in the suffix.

https://github.com/bazelbuild/rules_scala/releases/tag/v6.6.0
https://github.com/bazelbuild/rules_scala/pull/1573

Hence, now all the repos and toolchains are appended with the scala version suffix.
My next PR will update the module extensions to enable setting our own Scala version. The intention is to eventually try to contribute these extensions (and other necessary changes) upstream.

FYI, I had to add scala/BUILD back so the rules_scala patch had a proper package. I also had to pull rules_java back to 7.9.1 because 7.10.0 has problems on non-macOS platforms:

https://github.com/bazelbuild/rules_java/issues/214
https://github.com/bazelbuild/rules_java/issues/218

The latter issue seems to match what we're seeing in CI:

https://github.com/EngFlow/example/actions/runs/10778667925/job/29890522476?pr=339

ERROR: no such package '@@rules_java~//tools/jdk': BUILD file not found
in directory 'tools/jdk' of external repository @@rules_java~. Add a
BUILD file to a directory to mark it as a package.

ERROR:
/home/engflow/.cache/bazel/_bazel_engflow/9a27675a6850b9fc7b6f4bb1996879a4/external/rules_java~~toolchains~local_jdk/BUILD.bazel:18:10:
no such package '@@rules_java~//tools/jdk': BUILD file not found in
directory 'tools/jdk' of external repository @@rules_java~. Add a BUILD
file to a directory to mark it as a package. and referenced by
'@@rules_java~~toolchains~local_jdk//:bootstrap_runtime_toolchain_definition'

Everything's passing again now; merging.


Fix windows ScriptNotify and InjectJavaScript

Summary
Fix ScriptNotify to allow for JSON objects - the alert handler shouldn't consume any and all json objects. I also prefixed the type with double underscore to avoid collision with valid use cases where someone might want to use "type":"alert"
Fix InjectJavaScript, which wasn't parsing the command args correctly and so was always injecting an empty string.
Test Plan
Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

@kaiguo Could you look at this? You might want to just combine these changes into your postMessage PR since they're kind of related? https://github.com/react-native-community/react-native-webview/pull/1263

@jamonholmgren we've got a few other opening windows PRs, can we get those reviewed as well? Thanks!
https://github.com/react-native-community/react-native-webview/pull/1263
https://github.com/react-native-community/react-native-webview/pull/1335
https://github.com/react-native-community/react-native-webview/pull/1358

Thank you @benhamlin !! Really appreciate your contributions.


[RadioButton] iconStyle apply to both div AND SVG

Problem description
RadioButton's iconStyle prop apply to both div AND SVG. In my case, given marginTop: "70px" push the radio button down 140px. However, when you click it, you can see animation is at 70px below top.
Link to minimally-working code that reproduces the issue
http://www.webpackbin.com/NyWhP2SEG
Versions

Material-UI: 0.15.4
React: 15.3.2
Browser: Chrome Desktop for mac, Version 55.0.2883.95 (64-bit)

I think the problem occurs because in RadioButton.js,

iconStyle is used to make uncheckedStyles and checkedStyles, which is passed to uncheckedElement and checkedElement

iconStyle is also used to make mergedIconStyle, which is passed through EnhancedSwitch and be used to make wrapStyles, which eventually be passed to switchOrThumbElement

👍
I'd also like to add that there doesn't appear to be a way to set the color of the unchecked radio button.

this is a bug, and iconstyle can not use position:"absolute" , or every button will be checked

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.


Not able to reset password

My actions before raising this issue

Trying to reset the password through "Forgot password" Search google for similar issues.
Searching Google for similar issues.

I am trying to reset the password of my accounts through ("Forgot password". I have tried more than 10 times, but have yet to receive any email with a link for password rest. Is there any other way to get my password reset.
I also trid to create another account, but not sure if it has been successful created. While I am able to log onto my new account, I am not able to create a task from a backed-up tasks due to un-authorization . Can a task be created from a backed-up task created by another account?
Please advise where to post the question, it this forum is for code related issues only.
Thanks in advance.

Can a task be created from a backed-up task created by another account?

Yes, it can.


Improve performance measurement usability

As a developer, I want to run some portion of my app and get information about:

How many frames were rendered

Average/P90/P99 build times
Average/P90/P99 raster times
Information about the top N worst build/raster frames

How much time was spent in network or disk IO from dart:io

The ability to break this down by what files/hosts were accessed and how long it took

How much time was spent in platform channels

The ability to break this down by channel name/method call

GC stats:

Total UI thread time in GC
Total time of other thread(s) in GC
How many GCs ran/what types

Average/P90/P99 memory usage during the run
Average/P90/P99 CPU usage during the run
Average/P90/P99 GPU usage during the run

I would like to get this information with minimal impact on actual performance of my application.
A lot, but not all of this information is available in the timeline today. Some of this information is currently provided on some platforms, whereas on other platforms it is missing or only available via polling that devtools may do.
It would probably be best to start with some of our existing performance benchmarks and see what we can do to get the output to look more like this. We should also evaluate whether we can use timeline/perfetto tracing or not and how much of an impact it is having on performance as part of this bug.
/cc @gaaclarke @iskakaushik - I think this intersects with some of the work you're currently doing.
/cc @jiahaog fyi
/cc @kenzieschmoll @polina-c @jacob314 for devtools input

Ideally I'd like to have this data also available in release builds, so I can integrate this data with application performance monitoring tools, like Sentry, DataDog and so on.

How much time was spent in network or disk IO from dart:io

I'm currently experimenting with using HttpOverrides and IOOverrides to achieve this. That works quite good.

Is it that you want to test in release, or you want your release app sending back metrics for use?

Is it that you want to test in release, or you want your release app sending back metrics for use?

The latter one. I want to send back metrics for use.

It'd be awesome if at runtime you could collect telemetry data and send it over to observability services such as sentry.io to aggregate and extract information about the performance of your app and compare it across new versions of the app, device models, brands, etc...


OpenAI API - get token usage info from streaming response

Streaming responses used to not provide usage info. This has been fixed by OpenAI, so we should use this info rather than computing our own usage, which is not as accurate, especially for "thinking" LLMs like o1 series, which consume "thinking" tokens.
https://platform.openai.com/docs/api-reference/chat/object

hi @pchalasani  if this open for contribution, I would love to take this up !
i was going through the openai chat completion chunk object docs, I don't see reaoning tokens , predicted tokens count in the usage object

was going through the codebase and got this: https://github.com/langroid/langroid/blob/9f987a63ada4355da3233b59c188f893448cb707/langroid/language_models/openai_gpt.py#L382
is it already implemented ?

@AbhishekRP2002  the token breakdown is here:

is it already implemented?

It is implemented in the sense that we get the usage info directly from the API, but only in non-streaming mode. This issue calls for getting the info in streaming mode, from the chunks.
Let me review your other PR first, then we can decide this one.

Let me review your other PR first, then we can decide this one.

Sure. Sounds good.


Compile binaries for all platforms in CI workflow

Then tagging a release, compile binaries for all platforms in a CI workflow and save them as an artifact. This way other CI workflows (like C#, golang) can reuse the compiled binaries for their own releases.

Done as part of the CI effort in the past weeks.


Failed to shuffle data across epoches

Hi, I found this project quite helpful and implement into my project. However, it seems something wrong with the shuffling method of the loader. Here is my testing code:
import torch
import torch.utils.data as Data
import nonechucks as nc

torch.manual_seed(1)    # reproducible
BATCH_SIZE = 5
SHUFFLE = True
NUMWORKER = 2

x = torch.linspace(1, 10, 10)       # x data (torch tensor)
y = torch.linspace(10, 1, 10)       # y data (torch tensor)

torch_dataset = Data.TensorDataset(x,y)
loader = Data.DataLoader(
    dataset=torch_dataset,      # torch TensorDataset format
    batch_size=BATCH_SIZE,      # mini batch size
    shuffle=SHUFFLE,
    num_workers=NUMWORKER,
    )

loader_safe = nc.SafeDataLoader(nc.SafeDataset(torch_dataset), batch_size=BATCH_SIZE, shuffle=SHUFFLE, num_workers=NUMWORKER)

print('\nNormal dataloader')
for epoch in range(3):
    for step, (batch_x, batch_y) in enumerate(loader):
        print('Epoch: ', epoch, '| Step: ', step, '| batch x: ',
              batch_x.numpy(), '| batch y: ', batch_y.numpy())

print('\nSafe dataloader')
for epoch in range(3):
    for step, (batch_x, batch_y) in enumerate(loader_safe):
        print('Epoch: ', epoch, '| Step: ', step, '| batch x: ',
              batch_x.numpy(), '| batch y: ', batch_y.numpy())

And the results are like this:
Normal dataloader
Epoch:  0 | Step:  0 | batch x:  [10.  3.  1.  6.  5.] | batch y:  [ 1.  8. 10.  5.  6.]
Epoch:  0 | Step:  1 | batch x:  [8. 4. 2. 9. 7.] | batch y:  [3. 7. 9. 2. 4.]
Epoch:  1 | Step:  0 | batch x:  [7. 9. 6. 2. 4.] | batch y:  [4. 2. 5. 9. fe  6. 10.  1.]
Epoch:  2 | Step:  0 | batch x:  [4. 9. 1. 8. 5.] | batch y:  [ 7.  2. 10.  3.  6.]
Epoch:  2 | Step:  1 | batch x:  [ 3.  2.  6. 10.  7.] | batch y:  [8. 9. 5. 1. 4.]

Safe dataloader
Epoch:  0 | Step:  0 | batch x:  [6. 7. 2. 3. 1.] | batch y:  [ 5.  4.  9.  8. 10.]
Epoch:  0 | Step:  1 | batch x:  [ 9. 10.  4.  8.  5.] | batch y:  [2. 1. 7. 3. 6.]
Epoch:  1 | Step:  0 | batch x:  [6. 7. 2. 3. 1.] | batch y:  [ 5.  4.  9.  8. 10.]
Epoch:  1 | Step:  1 | batch x:  [ 9. 10.  4.  8.  5.] | batch y:  [2. 1. 7. 3. 6.]
Epoch:  2 | Step:  0 | batch x:  [6. 7. 2. 3. 1.] | batch y:  [ 5.  4.  9.  8. 10.]
Epoch:  2 | Step:  1 | batch x:  [ 9. 10.  4.  8.  5.] | batch y:  [2. 1. 7. 3. 6.]

It seems that the safeloader doesn't shuffle correctly across epoches. Do I somehow miss use the package?
By the way, the pytorch version I used is  1.0.1.post2

Fixed in 35ed2752398c917537ad731cc4e7cf06b4cd1737

Fixed https://github.com/msamogh/nonechucks/commit/35ed2752398c917537ad731cc4e7cf06b4cd1737


(1402) Handle missing release date on the Assessment Index

At the moment, if there is a ROTL / Parole application without a release date, then the application crashes when trying to show its assessment in the /assessments index page. This fixes this by returning N/A if there is no release date.
I've also done a bit of refactoring to tidy up the assessment utils. There's probably more scope, but this bit was hard enough! 😆

 Handle missing release date on the frontend


ON_DEMAND (oneOff) tasks will persist scheduling

This changes pre-existing behavior that cleared pending tasks when a
new schedule request is issued.

Given the nature of ON_DEMAND tasks, this is probably the user expected
behavior

cc @jhaber

:+1:


hre.ethers.provider not working in hardhat task

As soon as I import @openzeppelin/hardhat-upgrades in my hardhat project. hre.ethers.provider starts failing.
Before importing if I print hre.ethers.provider:
EthersProviderWrapper {
  _isProvider: true,
  _events: [],
  _emitted: { block: -2 },
  disableCcipRead: false,
  formatter: Formatter {
    formats: {
      transaction: [Object],
      transactionRequest: [Object],
      receiptLog: [Object],
      receipt: [Object],
      block: [Object],
      blockWithTransactions: [Object],
      filter: [Object],
      filterLog: [Object]
    }
  },
  anyNetwork: false,
  _networkPromise: Promise { <pending> },
  _maxInternalBlockNumber: -1024,
  _lastBlockNumber: -2,
  _maxFilterBlockRange: 10,
  _pollingInterval: 4000,
  _fastQueryDate: 0,
  connection: { url: 'http://localhost:8545' },
  _nextId: 42,
  _hardhatProvider: LazyInitializationProviderAdapter {
    _providerFactory: [AsyncFunction (anonymous)],
    _emitter: EventEmitter {
      _events: [Object: null prototype],
      _eventsCount: 2,
      _maxListeners: undefined,
      [Symbol(kCapture)]: false
    }
  }
}

After importing:
HardhatEthersProvider {
  _hardhatProvider: LazyInitializationProviderAdapter {
    _providerFactory: [AsyncFunction (anonymous)],
    _emitter: EventEmitter {
      _events: [Object: null prototype] {},
      _eventsCount: 0,
      _maxListeners: undefined,
      [Symbol(kCapture)]: false
    }
  },
  _networkName: 'localhost',
  _blockListeners: [],
  _transactionHashListeners: Map(0) {},
  _eventListeners: []
}

Because of which getting this error wherever I am using provider:

Error: invalid provider (argument="provider", value="<EthersHardhatProvider>", code=INVALID_ARGUMENT, version=wallet/5.7.0)```

Got it @ericglau, also can you please help me understand how do I use my own signer for deployment.
For ex earlier my script for deployment was:
signer = new ethers.Wallet(taskArguments.deployer, ethers.provider);
contract = await contractFactory.connect(signer).deploy();

Now if I use upgrades.deployProxy how do I specify which private keys to use for deployment?

@anonXcoder You would connect your signer to the ContractFactory for your implementation contract (similar to what you showed above but not call deploy()), then use that ContractFactory in the first parameter of deployProxy.


Is it possible to make it borderless

Is your feature request related to a problem? Please describe.
Hello, I was wondering if there is an option to remove the top border and Mac inspired colored buttons ?

Right now there is not an easy way to override default styling. It's something we talked about adding support for in the past. Feel free to purpose an change to allow overriding default styling (defined in style.css).


artifactory as additional release storage

For Bosch-internal releases artifactory shall be an adidtional release storage.

Hi @huavanthong ,
what is the status of this issue?
Thank you,
Thomas

Hi Thomas,
As the current status, we have a release storage at project RobotFramework_AIO in Gitlab.
You can find at the section of Deploy -> Package Registry
Is this in line with your expectations?
Thank you and best regards,
Thong Hua

Hi Thong,
we need artifactory as additional storage.
Reason:
nearly nobody has access to gitlab, but everybody to artifactory.
So, please check how we can integrate artifactory into our pipeline.
Thank you,
Thomas


Dataset availability

Hello,
thank you so much for sharing your work, it really helps me with my research!
I wonder if the datasets used/prepared and/or the data splits used that are described in your work can be downloaded somewhere?
I would love to do similar/comparable experiments!
Kind regards,
Jaqu

@JaquJaqu Did you get a resolution to this?

@mam661 unfortunately no..


GURPS specific: Weird interaction between ER and the Effects Modifer panel

Posting this both here and on the GGA github:
In the GURPS GGA system, when you target a token, a calculation of range and skill penalty for that range gets added to the socalled Effects Modifier panel (EM).
When Elevation Ruler is active, 4 units gets added to the calculation and this calculation only (ie. not the ruler measurements on the canvas, eg. dragging tokens around). A mesurement of 10 on the canvas shows as 14 in the EM, and 22 shows as 26, eg.

Interesting.  I'm not seeing this with the current version 0.10.0 (and didn't notice it with the previous).
You're not targeting something with a Size Modifier other than 0, are you?  Any further clarification to replicate?
What I am seeing, which seems to be a bug, is that when you move then range modifier is going to the modifier bucket (this also works when in ruler mode, as expected, but it's doing it in move mode).

With version 0.10.0 and 0.10.1, Elevation Ruler now blocks the Effects Modifier range notation entirely - it doesn¨'t show up at my end.
The second thing you mention - that is a GGA thing. There is a setting, intended for the standard Foundry ruler, that adds the range modifier to the bucket as you say. However GGA seems to view ER as that same ruler (as opposed to Drag Ruler, that does not have this issue), and thus it adds the modifier to the bucket if you have that setting enabled. I was seeing the same thing, and thought "oh, I can just disable it and use the modifier shown in the EM panel - this was how I noticed the discrepancy I mentioned in the first post. But if I'm the only one seeing that, it's obviously something at my end ... or maybe it's related to being in a Forge environment ... forgot to mention that.

It's a little odd, for sure.
I get something like this, when dragging (and then moving):

You can see the Effect Modifiers are not touched (and completing the move doesn't change anything).
Noted on the GGA setting for the mod bucket.  I'm going to assume that GGA somehow distinguished between standard ruler and drag mode with Drag Ruler.  I'll open a request on that in GGA.
For the current issue, I'm also hosting on The Forge, so there's no difference there.
Can you capture any data from the Console (F12) when you use it and the Effect Modifier is changed?

Here's what happens in GGA 0.17.8, ER 0.10.1, Foundry 12-330, no other modules than ER and libWrapper active. First I target a token with no other tokens chosen. Then I choose another token to be the attacker. This choice triggers the error.
In the second screen I do the same, with no modules at all. Note that there is no errors, and that the EM panel has a range measurement and modifier for the target present.

I added a temp fix in v0.10.2. I also submitted a PR to the GURPS git. They are modifying the waypoints directly in the Ruler without using the provided Ruler#_addWaypoint method.


Review documentation

[ ] Check code on EA-TT. It is different from the one we used on Gitlab.
[ ] FM-Core is about Formality-Core so is very outdated. It is necessary to review its content.
[ ] tutorial.md is a Tutorial about Formality-Core. Will we keep it?

I think most of those files are there for historical purposes. Most of the documenting should go to https://docs.formality-lang.org, I think. I don't think we should update EA-TT.md right now. Instead, if we want to do it, we should make a proper, scientific paper about it, but that'll take a lot of time. tutorial.md is obsolete, and so on. Perhaps just move the docs directory to an archive repository?

I like the idea of creating an archive repository. In this case, all relevant content would be in the Docs (Theory category) and the others on the archive repository. Formality repo will no longer have the docs folder, right?

I'll just leave the Archive directory for now since it has images we use in many places and is generally harmless.


Lemonade Change

I'd like to solve this Using CPP.
Problem Link: https://leetcode.com/problems/lemonade-change/

@badasschef Assigned


feat: Reject Commutativity Swap for Nested Loop Joins Affecting Parallelism #34639

#34639
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


AutomationEngine mutex methods

New methods introduced:
$evm.with_acquired_lock(lock_name)
$evm.acquire_lock(lock_name)
$evm.release_lock(lock_name)
$evm.has_lock?(lock_name)
Need to consider deadlock solutions (lock ordering, no-nested or one-lock at a time, etc).

@dtrieu80 Please rebase and push again

@gmcculloug @mkanoor Please review

@dtrieu80
Can you please add a spec for this

@matthewd Can you review...particularly the PgConcurrency bit?

I messed up this branch somehow. I'll need to close it and reapply a new PR.

@dtrieu80 ping us in https://gitter.im/ManageIQ/manageiq if you need help.  Thanks!


SSL handshake error - Bad input parameter to function

Anyone can pin point me what is the cause of the error. I'm using curl and mbedtls to download file from https url. Below is the verbose i print out from curl.

Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to localhost (<IP_ADDRESS>) port 443 (#0)
mbedTLS: Connecting to localhost:443
mbedTLS: Set SSL version to TLS 1.1
ssl_handshake returned - mbedTLS: (-0x7100) SSL - Bad input parameters to function
Curl_http_done: called premature == 1
Closing connection 0

The fact that the ssl_handshake() function returns 'Bad input parameter', seems to point to an incompatibility between the version of cURL and mbed TLS working together. Not necessarily an mbed TLS issue.
Are you using stable versions of cURL and the correct mbed TLS version? If so, I suggest you post an issue with cURL instead.
If you believe this is really an issue with mbed TLS, and not the way cURL is using mbed TLS, please feel free to re-open this issue with additional information.


Support for MAC values, support for ISO8601 timestamps, support for string concatenation and support for underscore in identifiers

Sorry for the long name, but the PR is indeed as explained by the title:

Add support for MAC values
Add support for string concatenation via producer @cat
Add support for ISO8601 timestamps, Eg. "2020-04-05T12:35:08.658Z"
Add support for underscores, _ in identifier names

This PR includes #7 and my own commits.

Hi,
These changes look good. Even I was looking to add the string concatenate producer.
Just one request, can you include '.' as this is also common in json identifiers.
So in antlr file, it would need to be:
IDENTIFIER : [a-zA-Z0-9_'.']+;
Do you have necessary rights for committing? If not can you contact<EMAIL_ADDRESS><EMAIL_ADDRESS>including me (raviranjanjha@gmail.com).
Thanks,
Ravi

Hi, takase1121. Really appreciate your contribution! I have gone through your changes. They look fine to me. Just one thing. The .iml file should not be included. Can you remove that from the pull request?

Sorry for the late reply.
For @raviranjanjha,
I added the thing I requested.
For @haihanyin,
I removed the iml file. However, this file seems to be automatically generated by intelliJ IDEA so I added it to .gitignore too. Hope that would be sufficient.
And another question regarding the spec:
Why are JSON string like "hey" is not allowed for object key? That is kinda weird.

Can you give me an example regarding "hey"

Hi Haihanyin,
Can you kindly publish a new version with these changes? I am waiting for
them for some time :)
Kind Regards,
Ravi Ranjan Jha
On Thu, Apr 9, 2020 at 4:41 PM haihanyin<EMAIL_ADDRESS>wrote:

Can you give me an example regarding "hey"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/json-template/JsonTemplate/pull/9#issuecomment-611471394,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWXHAYR3VZCTBLUEIBKSODRLWUNNANCNFSM4MAYYFWA
.

Since JsonTemplate is kinda superset of JSON, it should be able to accept:
{
    "hey": "John"
}

As that is valid JSON. However, the ANTLR rules only allow IDENTIFIER to be the key, so it will only allow this
{
    hey: "John"
}

Hi Haihanyin, Can you kindly publish a new version with these changes? I am waiting for them for some time :) Kind Regards, Ravi Ranjan Jha
…
On Thu, Apr 9, 2020 at 4:41 PM haihanyin @.***> wrote: Can you give me an example regarding "hey" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWXHAYR3VZCTBLUEIBKSODRLWUNNANCNFSM4MAYYFWA .

The new version 0.2.2 has been deployed.

The new version 0.2.2 has been deployed.

@takase1121

Json always takes strings as keys. There is no need to write quotes in JsonTemplate. JsonTemplate wants to avoid quotes as much as possible.
The purpose of JsonTemplate is not replacing Json or being a superset of Json. It is a tool for generating Json.

Then wouldn't it be better to at least allow computated object keys, eg: { @raw("help:me"): @s }, with this at least you can insert raw JSON value if you ever came across object keys that has characters used by JSON standard, eg: :


Level 1 and level 1 exercise updates

some small corrections

Cool, thanks Reena. My brain is not working proper already 👍


rework repo and add snakemake template info

copy the relevant parts of the snakemake template repo into this one (license, init script etc.) and make sure that the reference container repo looks and feels like it were created on the basis of the snakemake template.

All relevant parts and modifications have been made to the script so that it looks like the reference-container workflow was written on the basis of the template workflow.
I deleted the folder that contained the refcon_load.smk since this is now part of /rules/commons
A quick test that the code is still functional as expected.
The commit message is "added files and code to resolve issue #7"

it's unclear where the info has been updated - I don't see a new branch?!

I see now that the info has been added to the issue_T2T branch; not a clean way.
One more point (the re-opener): the README is obviously outdated now, please update that to make it compatible with the usage of the snakemake template

Sorry, I saw the ìssue_T2T branch when I wanted to make a new one and assumed you specifically created that branch to work on the created issues and therefore used it.
I will also update the README

I reset the branch ìssue_T2T back to where is was and also reset the branch dev one step back and included all changes to resolve both issues #5 and #7 (issue #5 only added one sentence to the functions.smk module) in a single commit. The new commit also includes a modified README.
The commit comment is "updates to resolve issues #5 and #7"


[Bug] file uploading spinner feedback disappear

In video, uploading spinner in content area will disappear when the user is pressing delete button.
https://github.com/user-attachments/assets/afb4d916-9dd0-4cc7-9992-a532eec4ee10

#42


noWrap=true,How to let it show whole map

when noWrap=true,the wrapped around the dateline value is between -180 and +180 degrees. how am I to change it, like pic.
for example:
change the wrapped around the dateline value is between -160 and +200 degrees

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.
If you are really sure that this is a bug in leaflet, or a feature request, please change the wording to make it look like a bug report.

You can always define a new CRS with a different value for its wrapLng property.

or a feature request

This actually looks like feature request.
BTW, we already have PR for (more or less) similar feature for case noWrap=false: https://github.com/Leaflet/Leaflet/pull/6723


support for prefix option

@rqrqrqrq is this guy ready?

@mslipper Not yet 🌚Hope i'll finish this in the weekend. Sorry for the delay

@mslipper Think im ready now. Still want to add tests for handleActions (even if all related changes covered in flattenUtils tests) but i guess it can be verified separately.

TODO:

[ ] Tests for handeActions
[ ] Update docs (?)

I would really love to see this PR merged 😍

I'll review today. Totally missed the notification.

LGTM!

@mslipper Do you know about plans to draft new release any time soon? Last one was more than half year ago already...

I can do a release tonight.

That would be supercool 👍

Looks like the docs still need updating.