dependency<EMAIL_ADDRESS>

Currently<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but the current version of Flipper is already 0.84
Is there a way to upgrade Flipper.

Hi, I think we can update the dependecies. Do you want to make a PR for this?

hmm, I think a fixed dep is not good because it depends which Flipper version is actually used by the developer...
May this issue could be fixed by using a peer-dependency instead.

Trying to setup with RN 0.64.0 and Flipper 0.85 I get the following Flipper error message in Mac client:

Redux Debugger (flipper-plugin-redux-debugger@1.2.1): Plugin 'Redux Debugger' is not supported by the client application

Not sure what needs to be done ! Is it a simple dependency issue or does the plugin not work with the latest versions of both RN & Flipper ?
Let us know and I can make a PR.

Trying to setup with RN 0.64.0 and Flipper 0.85 I get the following Flipper error message in Mac client:

Redux Debugger (flipper-plugin-redux-debugger@1.2.1): Plugin 'Redux Debugger' is not supported by the client application

Not sure what needs to be done ! Is it a simple dependency issue or does the plugin not work with the latest versions of both RN & Flipper ?
Let us know and I can make a PR.

Could you provide more details?
I tried to run RN 0.64.0 and Flipper 0.85. It is working fine.

My bad, it works as expected.
I just forgot the to append .default when requiring the module:
if (__DEV__) {
  const devConfig = require('./store.dev').default;

  merge(config, devConfig);
}


lib/exec.js: verify stream validity

setupOnError
setupStream

These checks prevent the following error in the output window:
"Internal Compiler Explorer error: TypeError: Cannot read property
'on' of undefined" on macOS

I haven't checked recently, but this has never a problem for me. Is it needed for a specific compiler, or was this error during execution?

I see this with the default compiler on macOS Mojave:
/tmp/ /usr/bin/clang++ --version
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

and
/tmp/ /Users/petter/local/bin/clang++ --version
clang version 8.0.0 (http://llvm.org/git/clang.git 2bc1c8b8c87e6b0e27d66dcb05955449b2e5a6db) (http://llvm.org/git/llvm.git 794b30e75b840b4115dc956bb23c211f99dcbe26)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Users/petter/local/bin

related to: https://github.com/mattgodbolt/compiler-explorer/issues/429

can you run CE with node app.js --debug to see what is being executed just before this error?

console output:
Internal Compiler Explorer error: TypeError: Cannot read property 'on' of undefined
    at setupOnError (/Users/petter/source/mine/compiler-explorer/lib/exec.js:76:16)
    at execute (/Users/petter/source/mine/compiler-explorer/lib/exec.js:97:5)
    at Object.sandbox (/Users/petter/source/mine/compiler-explorer/lib/exec.js:133:16)
    at DefaultCompiler.execBinary (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:135:21)
    at DefaultCompiler.postProcess (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:586:32)
    at stat.then.catch.then (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:234:30)

Compiler returned: -1

debug output:
info: none
info: Sandbox execution (sandbox disabled) /var/folders/3p/80s_1kbd37lch5cryfv61_m00000gn/T/compiler-explorer-compiler118825-68827-1wqh6wy.t255/output.s
debug:  type=executing, command=/var/folders/3p/80s_1kbd37lch5cryfv61_m00000gn/T/compiler-explorer-compiler118825-68827-1wqh6wy.t255/output.s, args=[], env=undefined
error: Error during compilation TypeError: Cannot read property 'on' of undefined
    at setupOnError (/Users/petter/source/mine/compiler-explorer/lib/exec.js:76:16)
    at execute (/Users/petter/source/mine/compiler-explorer/lib/exec.js:97:5)
    at Object.sandbox (/Users/petter/source/mine/compiler-explorer/lib/exec.js:133:16)
    at DefaultCompiler.execBinary (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:135:21)
    at DefaultCompiler.postProcess (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:586:32)
    at stat.then.catch.then (/Users/petter/source/mine/compiler-explorer/lib/base-compiler.js:234:30)
info: ::1 "POST /api/compiler/%2FUsers%2Fpetter%2Flocal%2Fbin%2Fclang%2B%2B/compile" 200
express deprecated req.host: Use req.hostname instead node_modules/raven/lib/client.js:596:19
express deprecated req.host: Use req.hostname instead node_modules/raven/lib/client.js:596:47
Error: spawn /var/folders/3p/80s_1kbd37lch5cryfv61_m00000gn/T/compiler-explorer-compiler118825-68827-1wqh6wy.t255/output.s EACCES
    at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19)
    at onErrorNT (internal/child_process.js:407:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

So it's upon executing your compiled sourcecode while also getting an EACCES.
Can you see what the result from const child = child_process.spawn() actually is here? Is child itself also undefined, and/or does it have any other information? It might be more useful to detect that so that CE gives a more useful error message about the problem.

Here is the entire debug output.
log.zip
/me is AFK for ~ 8 hours.

So I'm super late to actually be testing this, and couldn't reproduce until I looked at the logging again...
And I noticed the program is being compiled with -S, which means it doesn't actually produce a binary to execute. Hence the errors...
You need to click the 11010 button first before trying to execute.

merging, because this change can't hurt


add system log filter

Codecov Report

Merging #19 (b4334a5) into master (09749f2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   96.85%   96.90%   +0.04%
==========================================
  Files          71       72       +1
  Lines        1461     1484      +23
  Branches      110      112       +2
==========================================
+ Hits         1415     1438      +23
  Misses         42       42
  Partials        4        4

Impacted Files
Coverage Δ

jj/logs/_filter.py
100.00% <100.00%> (ø)

jj/mock/__init__.py
100.00% <100.00%> (ø)

jj/mock/_system_log_filter.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09749f2...b4334a5. Read the comment docs.


[EAGLE-539] add failure category and job count by state to mr feeder

Please add more descriptions on how you are planning to fix the issue. Thx

Updated the details about this issue in the jira.


Please add support for XXH3_64 / xxhash

Please add support for XXH3_64 / xxhash
Important With a magic prefix/suffix (perhaps XXH3_0123456789abcdef)
See https://github.com/Cyan4973/xxHash/issues/447
For the background.
31.5 GB/s on a Intel i7-9700K!
"xxHash is an Extremely fast Hash algorithm, running at RAM speed limits. It successfully completes the SMHasher test suite which evaluates collision, dispersion and randomness qualities of hash functions. Code is highly portable, and hashes are identical across all platforms (little / big endian)."

Duplicate of #134.

+1


cigien: Watch +84 916806116

cigien requests the watch of the watch_number +84 916806116. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


Chore/install viem

Installs viem
Ensures that the app is running in node 18  (viem requirement)
Updates tsconfig "target": "ES2020" (viem requirement)

Decided not to start using viem for now.


Find in array value

At my model there's a field that represents an array of values, actually are tags of my record, for example:
{
    "_id" : ObjectId("54a72f18be9369902900002b"),
    "title" : "First record",
    "tags" : ["tag1",  "tag2", "tag3"],
    "updated_at" : ISODate("2015-01-02T23:51:52.000Z"),
    "created_at" : ISODate("2015-01-02T23:51:52.000Z")
},
{
    "_id" : ObjectId("54a72f18be93699029000029"),
    "title" : "Second record",
    "tags" : ["tag1",  "tag4", "tag5"],
    "updated_at" : ISODate("2015-01-02T23:51:52.000Z"),
    "created_at" : ISODate("2015-01-02T23:51:52.000Z")
},
{
    "_id" : ObjectId("54a72f18be9369902900002a"),
    "title" : "my record",
    "tags" : ["tag6",  "tag7", "tag8"],
    "updated_at" : ISODate("2015-01-02T23:51:52.000Z"),
    "created_at" : ISODate("2015-01-02T23:51:52.000Z")
}

I would retrieve all record that has in "tags" the value "tag1".
It's possible?
Sorry if it was a noob question :P

Hi,
Not sure if you've found your solution but just in case, that's how I'd do it :
::where('tags.tag1', 'exists', true)->get();
hope it helps.

No, I'm not found solution yet. I'll try your suggestion, tks!

tags is array of strings, so we can do this:
::where("tags","=","tag1") //find all elements where tags has "tag1" or where tags is  equals "tag1"
::where("tags","=",["tag1","tag2"]) //find all elmentes where tags is equals ["tag1","tag2"]
Read about query in mongodb documentation http://docs.mongodb.org/manual/tutorial/query-documents/#arrays

Hi guys, unfortunately the both @vainsoul59 and @girokon way doesn't worked for me. Maybe this drive doesn't not support this operation.
I've got the follow error:
{
  "error": {
    "type": "ErrorException",
    "message": "Object of class Jenssegers\Mongodb\Eloquent\Builder could not be converted to string",
    "file": "C:\Projects\Laminapp\app\service\vendor\symfony\http-foundation\Symfony\Component\HttpFoundation\Response.php",
    "line": 406
  }
}

Hey guys, sorry for my mistake... The solutions was in documentation https://github.com/jenssegers/laravel-mongodb#mongodb-specific-operators
I use ::where('tags', 'all', ['campo'])->get() almost equals @girokon suggest.
Thank you all

If the tags are integer, don't forget to typecast!
Coupon::where('recipients', 'all', [(int)$cid])->get();
(I took half day to find it!)

#@Saneesh thanks for you comment, its works !

The following example queries for all documents where tags is an array that contains the string "tag1" as one of its elements:
db.inventory.find( { tags: "tag1" } )

How do you find any of the array given, or just in common language that "contains any of those values"?
Like if you want to get the docs containing tag1 and also the ones containing tag8?
::where('tags', 'all', ['tag1', 'tag8'])->get() does not work : you will get only the docs containing both tag1 and tag8.
Is there anything like: ::where('tags', 'any', ['tag1', 'tag8'])->get() ?

How do you find any of the array given, or just in common language that "contains any of those values"? Like if you want to get the docs containing tag1 and also the ones containing tag8? ::where('tags', 'all', ['tag1', 'tag8'])->get() does not work : you will get only the docs containing both tag1 and tag8.
Is there anything like: ::where('tags', 'any', ['tag1', 'tag8'])->get() ?
Edit, solution found, just below in case it could help anyone else: ::whereIn('tags', ['tag1', 'tag8'])->get()

This solution doesn't work if the column contains an array of objects for example doing something like this :
::whereIn('tags.name', ['tag1', 'tag8'])->get()` won't work
Does anyone have an idea how to go about this?


New version: XmacsLabs.Mogan version 1.1.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.2 schema?

Microsoft Reviewers: Open in CodeFlow

There is a bug when checking version updates. I think you should use the same version naming format as the detected one.


Scoping problems

If a variable is declared with the return value of a function, it is logged as "created" on the first line of the function.
For example,
int j = test();
public static int test() {
    return 2;
}

will log that the variable j was created with type UNKNOWN and value null on the return 2 line.

Fixed in branch stack

Merged back into master, fixed.


Cocoapods support

I have already pod trunk pushed the podspec. But the s.source should be changed to this repo and to be using a tag, I set the version to a future tag 0.3.3.
So to fix proper cocoapod support you need to:

Inform me of your email so I can add you as owner of Pod, more info: https://guides.cocoapods.org/making/getting-setup-with-trunk.html#adding-other-people-as-contributors
Accept this PR
Change the s.source in podspec to { :git => 'https://github.com/hyugit/EllipticCurve.git', :tag => s.version }
git tag '0.3.3' && git push --tags
After I have added you as owner: pod trunk push

Thanks for a great project!

Hi @Sajjon
Are you still working on this? Shall I fix these minor issues myself?
Thanks,
Huang

@hyugit sorry for the late response I was very busy last week. I updated the podspec.

no problem! thanks for the update!

btw, there may be other places with broken references due to my github username changes. I'll clean it up afterwards if necessary.


Api exception: App not found

For apps that are restricted by country and are outside the US.
See the discussion in the LifeHacker article about this app:
http://lifehacker.com/apk-downloader-extension-installs-restricted-apps-direc-1601613233/all
(discussion is started by teddytee)

@jackpf
This problem has been occurred again recently for about two months.
Please take some time too follow this issue , thanks!! :smile:


Cannot Install Gem Locally From Rakefile

When running rake, the install fails with the following error message:
$ rake
gem build jekyll-read-more.gemspec
  Successfully built RubyGem
  Name: jekyll-read-more
  Version: 0.1.1
  File: jekyll-read-more-0.1.1.gem
/Users/rob/Development/Projects/jekyll-read-more/lib/jekyll-read-more
rake aborted!
LoadError: cannot load such file -- jekyll-read-more/filter
/Users/rob/Development/Projects/jekyll-read-more/lib/jekyll-read-more.rb:1:in `<top (required)>'
/Users/rob/Development/Projects/jekyll-read-more/Rakefile:10:in `block in <top (required)>'
/Users/rob/Development/Projects/jekyll-read-more/Rakefile:25:in `call'
/Users/rob/Development/Projects/jekyll-read-more/Rakefile:25:in `block in <top (required)>'
Tasks: TOP => default => install
(See full trace by running task with --trace)

Need to look into how require is working.
Tested with:
$ ruby --version
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]

Fix issue by using require_relative.


Rename assert_msg to avoid torch conflict

Rename the assert_msg to avoid conflicts with pytorch 2.0.

Thank you for the pull request. I have merge it. assert_msg is deprecated, so I have change to limboAssertMsg.


Difference when using redundant variable qualifier and not using it (with MVEL runtime, MVEL syntax)

Description
While testing #5925 I identified a case in which:
    when
        $v:drools.issues.model.vehicles.GasolineVehicle(motor.highOctane == true, score<=1, $v.motor.serialNumber > 50000)

and
    when
        $v:drools.issues.model.vehicles.GasolineVehicle(motor.highOctane == true, score<=1, motor.serialNumber > 50000)

don't behave the same. Strangely enough, only motor.serialNumber > 50000 has an effect, qualifying or un-qualifying the other clauses do not make any difference.
Also, only happens with the dynamically generated model. In the process of #5925 I added identical test for both dynamic (byte-buddy) and normally-compiled code, and there was no difference in that issue, but in this one there is.
How to reproduce
This test
https://github.com/flozano/drools-issues/blob/main/src/test/java/drools/issues/DynamicClassTest.java
Uses these two DRL files:

https://github.com/flozano/drools-issues/blob/main/src/test/resources/drools/issues/DynamicClassTest.drl
https://github.com/flozano/drools-issues/blob/main/src/test/resources/drools/issues/DynamicClassTest_static.drl

In the second one (java compiled code), the $v can be added/removed with no issue. In the first one (byte-buddy model, currently  $v.motor.serialNumber > 50000 is used - and the test pass. If $v. is removed from that clause, the test does not pass.
(https://github.com/flozano/drools-issues/commit/3f9c53172e9998905b0ed9e82ce449edda544f2d)

(please note that the latest commit is needed to reproduce properly)


⚠ Turnos 24x7 has degraded performance

In 02d8d9b, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 4671 ms

Resolved: Turnos 24x7 performance has improved in fcc9e86.


new update causing game not to launch with MultiplayerCore installed[BUG]

latest version just downloaded it from github today

Pc, Steam I'm using steam link through the oculus to launch the game but regardless even launching through steam on my computer it won't launch

if you go through the normal steps of trying to play and have MultiplayerCore in your plugins folder with whatever other mods you have along with beat together Beatsaber gets stuck on the launch screen and doesn't proceed any further.

To Reproduce

have the mods in your plugins folder
try to launch through steam
game gets stuck on launch screen

Expected behavior
I expected the game to launch so i could play it with my friends with custom songs
Log
_latest.log

We don't support the latest game version yet. Hense the issues your describing.
Currently PC support is only 1.29.1 we plan to support latest soon. Remove the mod if you updated.


Fix read signature recursion

Provides a fix to make possible java8 stream api usage.
Currently we have StackOverflowError when parameterizing generics for Stream. Example:
H:\code\mirah-origin-git>java -jar dist\mirahc.jar -e [].stream
 [1m* [ [34mMethodLookup [39m]  [0mError during generic method processing for java.util.Collection.stream()
java.lang.StackOverflowError
        at java.util.HashMap.<init>(HashMap.java:456)
        at java.util.HashMap.<init>(HashMap.java:467)
        at org.mirah.jvm.mirrors.BaseType.<init>(base_type.mirah:101)
        at org.mirah.jvm.mirrors.generics.TypeVariable.<init>(type_variable.mirah:28)
        at org.mirah.jvm.mirrors.generics.BaseSignatureReader.finishTypeParam(xx_base_signature_reader.mirah:61)
        at org.mirah.jvm.mirrors.generics.TypeInvoker.visitSuperclass(xx_type_invoker.mirah:71)
        at org.objectweb.asm.signature.SignatureReader.accept(Unknown Source)
        at org.mirah.jvm.mirrors.generics.BaseSignatureReader.read(xx_base_signature_reader.mirah:89)
        at org.mirah.jvm.mirrors.generics.TypeInvoker.invoke(xx_type_invoker.mirah:109)
        at org.mirah.jvm.mirrors.MirrorTypeSystem$2.updated(mirror_type_system.mirah:125)
        at org.mirah.typer.BaseTypeFuture.onUpdate(base_type_future.mirah:105)
        at org.mirah.jvm.mirrors.MirrorTypeSystem.parameterize(mirror_type_system.mirah:123)
        at org.mirah.jvm.mirrors.generics.AsyncTypeBuilder.visitEnd(async_type_builder.mirah:129)
        at org.objectweb.asm.signature.SignatureReader.a(Unknown Source)
        at org.objectweb.asm.signature.SignatureReader.a(Unknown Source)
        at org.objectweb.asm.signature.SignatureReader.accept(Unknown Source)
        at org.mirah.jvm.mirrors.generics.BaseSignatureReader.read(xx_base_signature_reader.mirah:89)
        at org.mirah.jvm.mirrors.generics.TypeInvoker.invoke(xx_type_invoker.mirah:109)
        at org.mirah.jvm.mirrors.MirrorTypeSystem$2.updated(mirror_type_system.mirah:125)

I like that you tackle this bug! :-)

Actually I'd like my fix to be reviewed.
There is also another issue in generics https://github.com/mirah/mirah/issues/395 I could not solve myself.

Actually I'd like my fix to be reviewed.

My understanding of my current agreement with @baroquebobcat is that I should wait for him to review all pull requests (except if I have a bug fix, but not a feature). So I believe I'm currently not in the position to perform a conclusively review.

@felixvf thanks for deferring. I'm looking now. @uujava, if it's been a while could you @ me in the PR you want me to focus on? I should have more time to look at things over the next couple months than I've had previously, so I should be more responsive.

This looks good to me. Are there still open issues with this?

I have not seen any issues with this particular fix, but there are couple of known issues  related to the generics:
https://github.com/mirah/mirah/issues/408
https://github.com/mirah/mirah/issues/417


wip(satellite): introduce variable enabling satellite-tools repository

What does this PR do?
Updates @Vskilet contribution ( #1081 ), introducing a variable switching satellite-tools version, celebrating Satellite 6.4 release.
How should this be manually tested?
Having defined satellite-related configurations, such as rhsm_activation_key, rhsm_org_id, ... Apply prerequisites and deploy cluster:
ansible-playbook playbooks/prerequisites.yml
ansible-playbook playbooks/deploy_cluster.yml

Is there a relevant Issue open for this?
None
Who would you like to review this?
cc: @tomassedovic PTAL

All the credit goes to Victor. Couldn't figure out how to push my changes into his PR.
While I'm there, I might be interested into joining the org. The link given above only lists current members, I'ld rather not harass anyone, ... If someone here's willing to further discuss that matter, please let me know, ...


FW-479. unknown RHE are now forwarded by the motes.

Placing an unknown RHE between the page dispatch and RH3s caused the motes to crash. This fix should allow them to forward it unchanged.

Should this be merged?

I believe it should now that everything works fine


Log improvement of multi-cloud

What this PR does / why we need it:
Improve the log module of multi-cloud
Log file path, log level and log format can be configured in log.conf.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

What this log module provided
Log file path, level and format can be configured in

log.conf

which is in opensds's root path, configuration is like this:
path = /var/log/multi-cloud
level = info
format = [%lvl%]-[%time%]-%msg%

path indicates where the log file is stored.
level indicates the level of logger.
format indicates the format of log. %lvl% means level, %time% means timestamp, %msg% means the message that you want to log.
And if path, level or format are not configred, the default path is /var/log/multi-cloud, the default level is info, and the default format is [%lvl%]-[%time%]-%msg%
How to write log
First of all, you need to import the package:
import (
    log "github.com/sirupsen/logrus"
)

The log is divided into four levels: debug, info, warn, error
And you can use these four function to write the log: log.Debug, log.Info, log.Warn, log.Error

Please fix the conflict.
For all logs referred to failed or error, please use log.Errorf instead of log.Infof.
Thanks.

Hi @ThisIsClark , can we add file name and function name to the log? That will be very helpful for debugging.

Hi @ThisIsClark , can we add file name and function name to the log? That will be very helpful for debugging.

Hi @sfzeng , file name, function name and line number have been added to the log. You can get more details in the release note of this PR.

Please fix the conflict.
For all logs referred to failed or error, please use log.Errorf instead of log.Infof.
Thanks.

Done

LGTM

please fix conflicts @ThisIsClark

LGTM


xiaomi-temperature-humidity-sensor incorrect display temperature

when temperature below 0 oC
the system read 100 oC

also noticed that the battery reading is not correct.
firstly, the system reported that the battery is 25%. then down to 1% in 5 days. then jump to 98% after another 2 days.

I have experimented the same, it does not seem to work fine. Any idea how possibly start looking into this?

If you have any suggestions or code modifications please put in a merge request

Unfortunately there's no documentation on these devices and is all guesswork


Error about input event in project manager at every launch

Godot version
4.1 24cb43a
System information
Windows 10 x64
Issue description
Every time I launch Godot, I'm greeted with this in my console:
ERROR: Resource file not found: res://InputEventKey_7cuxk.
   at: (core\io\resource_loader.cpp:227)

Seems to be only happening in Project Manager and comes from this:

It's part of my editor_settings-4.tres. I didn't test, but I think it applies to any shortcut that you customize. For some reason ResourceLoader tries to load it as a project resource, while it's a sub-resource.
Does not happen in 4.0.2.
Steps to reproduce

Open Godot 4.1 project manager
Check the console

Minimal reproduction project
N/A

When parsing the SubResource, VariantParser needs a non-null ResourceParser:
https://github.com/godotengine/godot/blob/ae4d469ca2695141c1b944df6c45ce9631522103/core/variant/variant_parser.cpp#L975-L1006
Otherwise, it seems to fallback to assuming it's Resource and calls Resource::load on it:
https://github.com/godotengine/godot/blob/ae4d469ca2695141c1b944df6c45ce9631522103/core/variant/variant_parser.cpp#L1006-L1026
The reason why ResourceParser is null seems to be this line in main introduced by https://github.com/godotengine/godot/pull/75219:
https://github.com/godotengine/godot/blob/f7374e2db76e24003b185394b1e1044eb00fbad5/main/main.cpp#L2055
This code is just parsing the editor settings to look for 2 enum settings so it won't care about SubResources. We could ignore SubResource if ResourceParser is null, but this would also silence the error for other cases where it may be valid.

Could be worth bisecting if someone has a fast computer :)

Are you sure it doesn't happen before dev 3? The commit in OP seems to be part of dev 2. I think this was a consequence of https://github.com/godotengine/godot/pull/75219 which I believe was added in dev 1.
Keep in mind the issue only happens if you have custom shortcuts so maybe you didn't find the issue before dev 3 because you weren't using custom shortcuts.

I think this was a consequence of #75219 which I believe was added in dev 1.

CC @bruvzg


Compilation result is not being provided to Visual Studio app context

Environment: Visual Studio 2015 Update 1, Windows 10 Insider Preview 14257, TS 1.8.0-beta
Repro:

Create a new project

Add a blank TypeScript file named file.ts

Add a reference to file.js in default.htm before /js/default.js
<link href="/css/default.css" rel="stylesheet" />
<script src="file.js"></script>
<script src="/js/default.js"></script>

Write var homu = "homu" on file.ts

Build and deploy the app by clicking "Local Machine"

It should launch with no error

Close the app

Click "Local Machine" again

Now it says 0x800a1391 - JavaScript runtime error: 'homu' is undefined

i think i am using a different template. but creating a new project form "TypeScript HTML Application" and adding a new file "file.ts" and following your steps, things seem to work.
if you can share a project, i would be happy to take a look.

@mhegazy Ah, I created it using Templates->JavaScript->Blank App (Universal Windows). Can you try once again with it?

I'm seeing file.js is correctly generated but somehow VS doesn't get them.

looks like we are not putting the output files in ContentFilesProjectOutputGroup as the windows app deployment expects them, so they are not deployed.
as a work around can you add the .js file in the project, and that will cause it to be deployed.

I think this will be breaking bug as it worked before 1.8 beta.

@paulvanbrenk can you see if you can figure what is going on here? We might want to try and pull this in for Update2 of VS if it's a regression.

This issue just appeared for me as well.  I re-imaged my laptop and installed fresh vs enterprise 2015 update 2 and now my app no longer builds.  Anything included via TypeScriptCompile is missing from the project.  It will build and run one time if I re-include the .ts files and delete all the .js files.  New projects do not provide Right-Click > Add > New Typescript file...  They do appear under New Javascript file... but do not compile except one time on build.  I'm starting to get some VMs going with different tool sets to see if it can add some light to where the problem is.

@mhegazy In my tests, adding the js files works, but if you modify the ts file, the js file is not updated.  You have to delete all js files, build and run, stop running, and then include the generated js files again.

Ok, so here are my results.  Both VMs are Azure default VMs.
VM 1:  Visual Studio Enterprise 2015 Update 1 with Universal Windows Tools and Azure SDK 2.8 on Windows 10 1511 Enterprise N (x64)
File > New Project > Installed > Templates > Other Languages > JavsScript > Windows > Universal > Blank App (Universal Windows)
Right Click the js folder and notice that New TypeScript File... is a context menu item.

Add the file.  Right click the project and select properties.  Notice that TypeScript Build is a tab.

Save all.  Unload project and edit.  Notice that the tag is TypeScriptCompile and the file is visible in project.

This project produces js files on save and runs fine.
VM 2:  Visual Studio Enterprise 2015 Update 2 with Universal Windows Tools and Azure SDK 2.9 on Windows 10 Enterprise N (x64)
Same steps, but ...
No New TypeScript file.. context menu.

No TypeScript Build tab on property page.

No TypeScriptCompile tag.  In fact, changing to TypeScriptCompile causes item to not be included.

@paulvanbrenk any ideas?

Setup issue? Can you collect logs on the 2 VM using http://aka.ms/vscollect and confirm there is no entry for TypeScript in Help -> About.

I can confirm this appears to be broken for .jsproj files -- I just setup a brand you machine w/ Update 2. and it's all gone south.
I can confirm that in my About Box, I do see TypeScript 1.8.29 installed.
It seems to be improved if I bring the items as  as well as TypeScriptCompile.
I couldn't attach the logs here -- they're too big, apparently -- so I've uploaded them here:
http://codevoid.net/vslogs.zip

Thanks for getting the logs, it looks like TypeScript is installed correctly. Does it work as expected in an HTML Application with TypeScript (new Project, from the TypeScript node).
And are there any recent entries in the activity log?
%appdata%\Microsoft\VisualStudio\14.0\ActivityLog.xml

Yes, the HTML Application project type seems to show things correctly, and seems work. I didn't dig deeply, however.
I can craft a repro project if you're unable to repro w/ WWA proj.
On Apr 6, 2016, at 10:31, Paul van Brenk <notifications<EMAIL_ADDRESS>wrote:
Thanks for getting the logs, it looks like TypeScript is installed correctly. Does it work as expected in an HTML Application with TypeScript (new Project, from the TypeScript node).
And are there any recent entries in the activity log?
%appdata%\Microsoft\VisualStudio\14.0\ActivityLog.xml

You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/TypeScript/issues/7146#issuecomment-206478022

The other projects work fine with typescript.  It's just uwp js apps that have this problem of the ones that I've tried.

Were you able to repro this? I noticed that it still repros even after the latest 1.3.2 tools update.

No, I haven't. Which tools were upgraded to 1.3.2 ? And which version of TypeScript shows in Help > About?

The Win10/UWP tools were upgraded to 1.3.2 -- unclear why. My Typescript Version is <IP_ADDRESS>.
I'll try working on a repro project tonight.

UWP support is tracked by https://github.com/Microsoft/TypeScript/issues/8950

@paulvanbrenk can you track down a repro or close this?

@minestarks can you see if this repros with your latest changes?

There are 2 distinct issues in this thread
One Refers to VS2015 Update 1 - I can't repro this, I believe it to be fixed.
Two Only applies to VS 2015 Update 2 and beyond, there is a workaround which is documented in #8950.


Added max storage size parameter

Right now the storage size is limited at 5MB because of node-localstorage has a parameter that is not being set. So I have added the option to do it.

@pellejacobs done :)


dynamic i18n doesn't work in server middleware

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, i18n
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-nxfsvv
npm run buildAndStart
Describe the bug
In theory #2199 should have fixed it but it doesn't
when using i18n in dedicated middleware and using it in endpoint it's just returning translation key and prints in logs:
[intlify] The message format compilation is not supported in this build. Because message compiler isn't included. You need to pre-compilation all message format. So translate function return 'test'.
Additional context
No response
Logs
No response

Hi!
Thank you for your reproduction!
The issue is that the vue-i18n message-compiler for the server side is not made to use the jit compilation.
I’ll try to fix later.

BTW, your issue's use case has inspired me to come up with an i18n feature for the server side.
The nuxt i18n module will be a priority for the v8 RC release.
When that version will be released,  maybe I will try to implement as a nitro plugin and integrated into the nuxt i18n module.
The core of vue-i18n is designed in framework agnostic, so logically it can be embedded in other frameworks.
Thanks for this issue of yours! /cc @danielroe @pi0


Added link to detection output in Stata console

Solves #25

@luizaandrade this is ready for review too. You can download the code from this branch with net install stata_linter, from("https://raw.githubusercontent.com/worldbank/stata-linter/develop-add-links-to-detection") replace and then use it in your computer as the readme file explains

Note that the links are only in the detection output, which is generated with the excel() option. I haven't added links in the "correction" outputs but it would be straightforward to do if we wanted to include it

This is the output I'm getting when exporting the new do file:

All excel related options gave me error:

I have fixed the bugs reported by Rony on the 3 previous commits


feat: add SWE-bench fullset support

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

Give a summary of what the PR does, explaining any non-trivial design decisions

Support setting the SWE-Bench dataset and split to run evaluation using command line argument.
Update the documentation to allow people to directly run_infer.sh without running a pull instance docker first -> run_infer.sh should be able to automatically pull them.
Add script with documentation for pushing new SWE-Bench images to remote registry.

Other references

Looks good, thanks!


🌱 Add the kcp playground plugin

Summary
As per discussion in the office hours meeting from Feb 14th, proposing a new kubectl plugin that will allow users/developers to spin un playgrounds with kcp, pclusters, and an initial setup defined in a config file similar to the example included in the PR.
The playground is implemented as a test fixture and internally leverages all the methods of the existing test framework (kudos to all the developers), so in the future, it will be possible to consider if to use the playgroundFixture as an alternative way to do the initial setup in E2E tests.
But this is an eventual long-term goal and I'm quoting now only for giving a little bit of context on the proposed code structure.
@ncdc if you want to s/playground/testbed let me know that I will do this before people start reviewing (no strong opinions from my side, so I'm ok with whatever the team prefers)
Related issue(s)
Fixes #

@fabriziopandini ❤
playground is fine for now 😄
/ok-to-test

<3 Thank you for this!
Would it be possible to have a "quick start" sort of document in our new book that shows how to use the Playground?

+1

Add some more capabilities and examples covering all the tutorials in the book and more (cowboys API, east-west placement with or without coordination controller).
I will follow up adding a page in the book explaining how to use the playground.

@ncdc @vincepri @kasturinarra I have added doc and cleaned up examples
I think the feature set has now a good critical mass, so I will stop development and wait for feedback on what is in

How are the playgrounds tested? I fear a similar situation as with the demos we had long time ago, i.e. they broke eventually and it was just too much to maintain them.

Is there a story here for developers of the stuff that playground runs (e.g., the kcp process, the syncer)?

For example, consider a developer of the kcp or syncer binaries that wants to debug it in their IDE, using breakpoints and examining call stacks and data structures.  How does that happen?

I use Goland today (and used VSCode in the past) to launch and debug kcp. You should be able to do something similar for the syncer. I don't believe this PR is trying to help in that area (?).

My point is that while developers are familiar with how to launch and debug using their favorite IDE, the playground launches processes without debugging, independent of any IDE.

For example, consider a developer of the kcp or syncer binaries that wants to debug it in their IDE, using breakpoints and examining call stacks and data structures. How does that happen?

The playground is not a replacement for an IDE, and it was never intended to be.
However, nothing prevents you to use the playground in combination with an IDE, as a way to quickly set up a scenario with a test of objects. This works with some caveats because you are using two tools that are not aware of one of the other, but some time is useful so I'm using it mostly in the following configurations:

I start KCP in debug mode in my IDE, then use the playground to quickly create a set of objects on the KCP instance managed by the IDE
I start a playground (KCP + a set of objects), then start a controller I'm playing with in my IDE pointing to the playground; I think the same can be done with the syncer too.

/retest

/close
Sorry but currently I don't have the bandwidth to follow up with this work, if someone is interested I will be happy to hand over it


chore: x/leverage CLI and tests

Description

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #238 (7ebedb5) into main (be6654a) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   27.92%   28.12%   +0.19%
==========================================
  Files          57       58       +1
  Lines        8139     8161      +22
==========================================
+ Hits         2273     2295      +22
  Misses       5660     5660
  Partials      206      206

Impacted Files
Coverage Δ

x/leverage/client/tests/suite.go
100.00% <100.00%> (ø)

(Commit message generator is chad software)


We need a Precise ppa with the latest gtk-3-dev

Travis is stuck with Ubuntu 12.04 Precise and there doesn't seem to be a ppa that targets Precise and provides the latest GTK+3 development libraries.

Solved by building from source instead.


Icon only shows on single extended monitor (macos)

I've done a bit of digging, and i'm not 100% sure what is happening here, but it's a bit of a showstopper for my usages of fyne in general.
I am on MacOS, using a m1 laptop. I use a dock that extends my displays across two monitors plus the built in laptop monitor. My built in laptop monitor is my primary monitor.
When starting up an app using fyne systray, the system tray icon only shows up on the "middle" monitor's app menu/system tray.
To be clear, it does not show up on the "primary" monitor as defined in my settings, and does not show up on the 3rd monitor, but does show up on one extended monitor that is in the "middle" in my layout. As seen here:

Even though I have it set for each monitor to also show the system tray, which works for all other apps.
And then lastly, if I disconnect the monitors and go mobile with the laptop, no systray icon shows up at all. To be clear, when not connected to external monitors anymore, the fyne systray icons for my app (or the example one in this repo) do not show up on my system tray. All other system tray icons for other apps work as expected.
This is my laptop tray, even when disconnected from all other monitors and app is still running (or even restarted, doesn't matter):

Re-plugging in my external monitors makes both my custom app icon and the example from this repo show up, on the external (extended) monitor without restarting the app, or restarting it. Both work.
Ideally the app icon would show on all monitors per the mac setings, but at the very least needs to show up on the laptop monitor when nothing else is plugged in. If there's any debugging I can do to provide help lmk!

I cannot replicate this with any of my screens. There is no capability within the macOS API to specify that a menubar icon appear only on some screens.
What settings/configuration are you referring to? Maybe there are some more details steps for replicating that you can provide?
Do make sure that you haven't run out of room on the menu though - the mac will hide icons to make way for menu headings.

TIL: icons won't display if it's partially hidden under the camera tab in a macbook monitor. Thanks @andydotxyz for sanity checking my issue!


IC-1951 Added End Of Service Report Flag to single sent referral responses

What does this pull request do?
A derived field which indicates to the user interface if a EoS Report is required.
What is the intent behind these changes?
To avoid duplicating the business rule in UI

👍 💯 for exposing the business rules in the business API


CREATE USER is not supported in master database, but doc says to create user in master DB

The provided statements in #3 will not run in the master DB.
Current:

Optionally, use the 'master' database to create a login for a user in DataExplorationDB that will access external data:

Error:
Started executing query at Line 1
CREATE USER is not supported in master database.
Visit this article to learn more about this error
Total execution time: 00:00:00.684

Proposed:

Optionally, use the newly created 'DataExplorationDB' database to create a login for a user in DataExplorationDB that will access external data:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7fd3e66e-a012-dd40-34f3-1e84865605bc
Version Independent ID: d0fc26d6-2a86-dbed-2f48-c798b551f3f0
Content: Tutorial: Get started analyze data with a serverless SQL pool - Azure Synapse Analytics
Content Source: articles/synapse-analytics/get-started-analyze-sql-on-demand.md
Service: synapse-analytics
Sub-service: sql
GitHub Login: @saveenr
Microsoft Alias: saveenr

Thank you for bringing this to our attention.  I will let you know when I have more information

The edits are pending.
Thank you for your service @bbrandt .


Feature idea: fallback translator

I got the idea from this package: Linguji :
Add a Fallback Translator:   add a fallback translation engine (e.g DeepL or Google) to be used for those lines that chat gpt moderator has marked or the translation has failed for the given subtitles.

There is something I want to find out. Have you experienced any translation refusals? If yes, are you using structured mode and which model?
There are already fallback model option available, but I have yet to document it, and I have to further implement the fallback mode (structured or unstructured), api key and endpoint (if fallback to any openai api compatible model, including Gemini ie https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/call-vertex-using-openai-library or https://github.com/zhu327/gemini-openai-proxy

I do get [Flagged][Model] ${originalSource} -> ${finalTransform}  , but other than that I haven't come across any other translation refusals.

You can try out the new --experimental-structured-mode which is so far does not seem get any flags by model

I get this message:
[TranslatorStructuredBase] Structured Mode: array
[TranslatorStructuredBase] --no-prefix-number must be used in structured mode, overriding.

These 2 lines are fine, you can ignore, or add the --no-prefix-number option


please do not use clean-py

Your repo didn't enable issue, so I can only send a PR as a issue.
Normally users will have their own linter and formatter to do cleaning.
clean-py also it include too much package, it even require jupyterlab!

Hello. Good point, replaced clean-py library with only necessary for formatting, so now package size is 10x times smaller. Fix available in version 1.0.5


Ruff reports F704 await statement outside of a function for notebooks

In notebooks await is allowed in a cell (i.e. outside of a function), but ruff reports F704 - see also https://github.com/microsoft/pylance-release/issues/1754 and https://ipython.readthedocs.io/en/stable/interactive/autoawait.html

Wow, interesting, TIL. Thanks for filing.

Interesting! It also seems that this can be disabled using %autoawait False or using c.InteractiveShell.autoawait in the config file.
I'm not sure what the long term solution would be but one idea is to store these as a context while processing the Notebook and then using that in some kind of a middleware to filter out such diagnostics. Or, instead of middleware this context can be passed around to the checkers. For example, in this example the context would give us information if autoawait is disabled or not. This will still be limited as it can be disabled in the config file.


Bayesian analytics

@kingo55 should we consider fleshing out Bayesian analytics again? It would be interesting to develop some functionality to run side-by-side with the Frequentist reports we run, to see how it stacks up.
The main thing to put some thought to is how we calculate priors. We could perhaps calculate it (mean + std deviation) based on the past X months worth of conversion data?
Another question is how to we deal with sizing and presenting the data in our reports.
Refs:

bayesTest R documentation
primer on priors
good primer on bayesian vs frequentist, with nice visual format

Oh yes! That would be awesome.
As you allude to, priors could be generated through our sizing process. Anything is better than no prior. Also, I'm not sure how relevant older data is, considering seasonality... perhaps the 30 days we use in our sizing calculator is sufficient here too?
I don't think we need to size experiments in advance with bayesian inference, but we'd still need it for establishing the prior I think.

Anything is better than no prior.

There is no such thing as Bayesian with “no prior”.
At a bare minimum there is an “uninformed prior” (which is a bit of a misnomer imho), but you can’t take the prior out of the equation (or out of the philosophy, for that matter).

Another question is how to we deal with sizing

Could you explain what you mean by "sizing"? I am not familiar with this term.

We haven't documented this, but before running experiments at Mint Metrics, we calculate the traffic we need for a minimum detectable effect using some helper functions. e.g.:
> estimateDurationQuery(
+   app_id = "site_name",
+   trigger_clause = "page_urlpath like '/products/%'",
+   conversion_clause = "page_urlpath = '/order/thank-you/'",
+   delta = -0.07,
+   recipes = 2,
+   stat_power = 0.8
+ )
[1] "Days to run: 31.786299299664"
  subjects conversions  base_cvr target_cvr
1    47862        5221 0.1090845  0.1014485

Trigger clause: This selects users who would have been exposed
Conversion clause: This selects users who would have converted after being exposed

It gives us a base line conversion rate for users who would typically be exposed over the last 30 days. Perhaps this baseline conversion rate will be useful as a prior?

Kind of similar to this calculator: https://www.evanmiller.org/ab-testing/sample-size.html
The actual calculation is performed here in our code: https://github.com/mint-metrics/mojito-r-analytics/blob/master/mojito-functions/experiment_sizing.R#L40

stat_power = 0.8

I assume this refers to the "desired statistical power"? In a Frequentist paradigm, power is needed to control for the type-II error (false negative) rate. Conversely, in a Bayesian paradigm, there are (afaik) no type-II error rate guarantees.

I don't think we need to size experiments in advance with bayesian inference

Indeed there is no need. Sizing (or power) is needed to make guarantees about error rates that Bayesian inference does not consider.
(ftr: imho this is a limitation of the Bayesian approach, not a strength.)

@lukasvermeer @kingo55
Not sure if my thinking is correct, but could we take an approach that leverage the advantages of both paradigms?
I.e. Frequentist to determine a target sample size / test duration to reduce type-II errors and Bayesian (with strong priors) to reduce type-I errors and easier to disseminate results?
I've seen some other CRO agencies use 'hybrid' approaches, albeit not as simplistic as this, so this train of thought maybe completely off.

Bayesian (with strong priors) to reduce type-I errors

While a Bayesian approach might empirically reduce type-I errors (when evaluated against some simulated data using a Frequentist lens), there are not guarantees about error rates (type-I or type-II).
I really have no idea how one would get the best of both worlds.


Add Library interface

Fixes #3821
Initially I missed why #3821 was failing.
Looking at it again, the error message reads:
Caused by: java.lang.IllegalArgumentException: Interface (NGWin32NamedPipeLibrary) of library=kernel32 does not extend Library
        at com.sun.jna.Native.loadLibrary(Native.java:566)
        at sbt.internal.NGWin32NamedPipeLibrary.<clinit>(NGWin32NamedPipeLibrary.java:38)
        ... 7 more

Inside Native.loadLibrary, it requires the "library" interface to extend com.sun.jna.Library, which this adds.

I'm going to self merge this.


Create database step fails for UWP apps, redirects back to this same page

The Package Manager Console steps for creating the database fail on UWP projects. The Add-Migration command asks the user to follow a link which is UWP specific, but that page seems to be gone and redirects back to this page. If the information in this page is not meant to apply to UWP apps, we should specify it and redirect that link somewhere else.
PM> Add-Migration InitialCreate
Startup project 'BookShellfManagedApp' is a Universal Windows Platform app. This version of the Entity Framework Core Package Manager Console Tools doesn't support this type of project. For more information on using the EF Core Tools with UWP projects, see https://go.microsoft.com/fwlink/?linkid=858496

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ac57b24-45aa-e679-6ff9-5a25c369c1ff
Version Independent ID: cc576199-b14c-a135-2291-cc48bf301b4e
Content: Getting Started - EF Core
Content Source: entity-framework/core/get-started/index.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @Rick-Anderson
Microsoft Alias: avickers

It seems like it would be more useful if VS suggested https://go.microsoft.com/fwlink/?linkid=2034705 / https://docs.microsoft.com/en-us/ef/core/miscellaneous/cli/powershell#other-target-frameworks which actually describes how to solve the issue.
If https://go.microsoft.com/fwlink/?linkid=858496 is only used in this context, maybe it could be updated to point to this other page rather than changing the documentation?

I think @ajcvickers might be the owner of the link, what are your thoughts on this?

@arcadiogarcia We will fix it.

Still not fixed.  What happened to https://docs.microsoft.com/en-us/ef/core/get-started/uwp/getting-started.
This was a UWP EF SQLite with migrations example.  I saved the link but not the whole page.  I wish I had saved the whole example locally :(


With Theile additions (0.4.20)

With LOGO variable, and removal of re-launch as it gave problems with keychain.


Change editor settings depending on grammar, not file

Summary
Change editor settings, like indentation, depending on grammar, not entry file.
Motivation
When I work on Markdown files — I see different (appropriate) syntax highlighting for code blocks. But I have a problem, when I want to use 4-spaces indentation for Markdown itself and another, like 2-spaces indentation, for code blocks, in Ruby, for example. And I just can't write Markdown with 4-spaces and code blocks in Ruby with 2-spaces in the same file, I have to switch it manually.
Describe alternatives you've considered
Original issue: https://github.com/sindresorhus/atom-editorconfig/issues/237
Additional context
Some list:

1.  Intent it with 4 spaces,
    because it's community standard.
2.  And indent Ruby with 2 spaces,
    because it's also community style.

```ruby
module Foo
  class Bar
    def baz
      2 + 2
    end
  end
end
```

That is possible with scoped settings
open console (ctrl + shift + i) and run
atom.config.set("editor.tabLength", 2, {scopeSelector: ".source.ruby"})

or add this to you config.cson
".ruby.source":
  editor:
    tabLength: 2

or add this to you config.cson
".ruby.source":
  editor:
    tabLength: 2

Done, atom-editorconfig disabled, but it doesn't work in Atom 1.44.0.
Are you sure it's still working?
I can record a screen-cast, if you want.

I'm not sure if that is the correct scope. You can use Editor: Log Cursor Scope to get the scope at the cursor.
see documentation here: https://flight-manual.atom.io/behind-atom/sections/scoped-settings-scopes-and-scope-descriptors/

Output:
Scopes at Cursor

text.md
fenced.code.md
source.embedded.ruby
meta.module.ruby
keyword.control.module.ruby

consig.cson changed:
".source.embedded.ruby":
  editor:
    tabLength: 2

Still seems not working.

After a little testing it looks like the correct setting value gets pulled out but the editor doesn't change the tab size. This seems like a bug.
steps to execute:

create md file with content:test

```ruby
def method_name
	code
end
```

add scoped setting to config.cson".ruby.source":
  editor:
    tabLength: 6

put cursor after test
run in console atom.config.get("editor.tabLength", {scope: atom.workspace.getActiveTextEditor().getCursorScope()})
returns 2
put cursor after code
run in console atom.config.get("editor.tabLength", {scope: atom.workspace.getActiveTextEditor().getCursorScope()})
returns 6 but tabs look the same

If you create a ruby file (.rb) it does use the scoped setting.


More info

Screenshot

GOV.UK Pattern
https://www.gov.uk/service-manual/user-centred-design/resources/patterns/help-text.html#hidden-help-text

@gavinwye I think this is a GOV.UK pattern. It is in the service manual.

this is a GOV.UK pattern


add option "disable-webserver" to test command.

This will prevent the start of the webserver as discussed in gitter:
Christian Boulanger @cboulanger Sep. 24 10:03
@hkollmann @oetiker My application's compile.json has an application "name": "testtapper" based on "class": "qxl.testtapper.Application",, which run fine in the browser after being compiled. I now want to run this test on the command line in the GitHub CI environment. There is an apache webserver in a service container which delivers the app on port 8073 (It's a PHP backend). if I do "npx qx test -p 8073", it will try to create an additional server. How do I make it listen to the running server only?
Also, if I execute npx qx test --app-name=testtapper, I get
Error: TypeError: Cannot read property 'setWriteIndexHtmlToRoot' of undefined
at /Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:51111:47
at Array.qx.lang.normalize.Array.forEach() [as forEach] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:10109:22)
at wrapper.qx.tool.cli.commands.Compile.prototype.createMakersFromConfig() [as createMakersFromConfig] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:50857:23)
at async wrapper.qx.tool.cli.commands.Compile.prototype._loadConfigAndStartMaking() [as _loadConfigAndStartMaking] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:50579:38)
at async wrapper.qx.tool.cli.commands.Compile.prototype.process() [as process] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:50548:9)
at async wrapper.qx.tool.cli.commands.Serve.prototype.process() [as process] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:66827:9)
at async wrapper.qx.tool.cli.commands.Test.prototype.process() [as process] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:67575:11)
at async wrapper.qx.tool.cli.Cli.prototype.processCommand() [as processCommand] (/Users/cboulanger/Code/bibliograph/node_modules/@qooxdoo/compiler/lib/compiler/index.js:39995:18)
Henner Kollmann @hkollmann Sep. 24 10:14
Have you disabled the server start in your compile.js?
Christian Boulanger @cboulanger Sep. 24 11:34
@hkollmann How do I do that - i faintly remember it is a needServer config setting - but where to put it?
Do I need a separate compile.js? or can the one shipped with testtapper be configured accordingly?
Or do I need a separate node app?
It's not clear from the documentation yet: https://qooxdoo.org/documentation/#/development/testing/unit_testing?id=running-the-tests
Henner Kollmann @hkollmann Sep. 24 14:33
This use case is not possible in the moment, Testtapper sets needServer by default. And there is no bubble to prevent this in the moment. What's about adding a parameter to the test command disablewebserver with default false?
Christian Boulanger @cboulanger Sep. 24 14:59

If I understand right, this will allow to load the application on a port on localhost without starting a server. This will be good enough for my current use case. However, as I noted on Twitter, a more general solution would be to be able, in addition, to specify the URL from which the app is  loaded. This would allow to run tests on deployed apps, too. But this is probably a different PR.

This should be an extension to the testtapper package - not the test command itselfs.
The test command did not know anything about the tests - it's just running them

Of course you're right. Thank you.

a bit late, but maybe "no-webserver" is shorter and a more common pattern for CLI params?


Some question about loading thre shared weights of LanguageGraspModel

https://github.com/andvg3/LGD/blob/2471385507a883ba9147624ce2b3983e691f5fd9/inference/models/grasp_model.py#L50-L93
when loading CVPR_2024_weights/lgrconvnet in the run_realtime script, there are some issues like "forward missing arguments prompt and query". I notice that the inference script for languagegraspmodel seems do not have input params for prompt or query?

And if i modify this file, there will have channel mismatch error

is there something wrong with the weights shared I download？

Hello @TonyTnT ,
Please run the evaluation via the instructed code:
$ python -m torch.distributed.launch --nproc_per_node=1 --use_env -m evaluate_diffusion --dataset grasp-anywhere --dataset-path data/grasp-anything++/ --add-file-path data/grasp-anything++/seen  --iou-eval --seen 1 --use-depth 0 --network <path_to_pretrained_network>
The inference was adapted from our previous ICRA codebase and was not updated, therefore, it is unavailable for additional prompts. We will update as soon as possible. Please stay tuned!
Thank you very much!

Closed due to inactivity.


Updated name of repo that moved

Thank you for contributing! Please confirm the following:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@roman7979 👋 Please don't make PRs from other people's commits! Thanks ❤


Page throwing 4xx error turns into 500 when client-side-routed

Describe the bug
If you have a page that does a throw error(403) for example, and you navigate to that page via an <a> tag on the site (i.e. using the client-side router), you'll incorrectly always get a 500 error instead.
Dead-simple repro: https://github.com/aradalvand/sveltekit-error-problem
Reproduction

Run git clone https://github.com/aradalvand/sveltekit-error-problem
Run npm i && npm run dev
Navigate to /foo, you'll get a 403 error, as expected.
Now, navigate to the home page, and click on the "Go to foo" button, now you'll get a 500 error while the page actually threw a 403.

Logs
No response
System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 236.17 MB / 3.77 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.15.1 - /usr/bin/node
    npm: 8.11.0 - /usr/bin/npm
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.65
    @sveltejs/kit: next => 1.0.0-next.428
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.4 => 3.0.9

Severity
blocking an upgrade
Additional Information
No response

I'm fairly sure this is a duplicate of https://github.com/sveltejs/kit/issues/5952, so I'm going to close it in favour of that issue


Add support to patchesJson6902 in customPatches

SSIA

Notice that patchesJson6902 has been deprecated in kustomize v5:
https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/patchesjson6902/
The same functionality should be achievable via patches that we already support.

Yeah I know, but we use kustomize 3.10.0 :D

it is already supported by kustomize v3.10.0:
❯ cat deployment.yaml kustomization.yaml
# deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dummy-app
  labels:
    app.kubernetes.io/name: nginx
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: nginx
  template:
    metadata:
      labels:
        app.kubernetes.io/name: nginx
    spec:
      containers:
        - name: nginx
          image: nginx:stable
          ports:
            - name: http
              containerPort: 80
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

# kustomization.yaml
resources:
- deployment.yaml
patches:
  - patch: |-
      - op: add
        path: /metadata/labels/app.kubernetes.io~1version
        value: 1.21.0
    target:
      group: apps
      version: v1
      kind: Deployment
  - patch: |-
      - op: replace
        path: /spec/template/spec/containers/0/image
        value: nginx:1.21.0
    target:
      labelSelector: "app.kubernetes.io/name=nginx"
❯ kustomize version
{Version:kustomize/v3.10.0 GitCommit:602ad8aa98e2e17f6c9119e027a09757e63c8bec BuildDate:2021-02-10T00:00:50Z GoOs:darwin GoArch:amd64}
❯ kustomize build
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app.kubernetes.io/name: nginx
    app.kubernetes.io/version: 1.21.0
  name: dummy-app
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: nginx
  template:
    metadata:
      labels:
        app.kubernetes.io/name: nginx
    spec:
      containers:
      - image: nginx:1.21.0
        name: nginx
        ports:
        - containerPort: 80
          name: http

I would not add the patchesJson6902 option being that we already have a way to do them and knowing that we'll need to deprecate it later, but I'm open to changing my mind :-)
Is there some specific case that does not work with 3.10.0 for example?

@ralgozino tested now and it's working. Thanks for the review, I'll close this PR.


Add gradle task clean

Fixes #2183

Verified at HEAD that running gradlew clean removes the android-ground/build dir

@gino-m  PTAL?

I just used the syntax suggested by IDE. I didn't have to search for anything.


Update license text

The PR is to resolve #148 .
Signed-off-by: Jianguo Ma<EMAIL_ADDRESS>

@git4rk  updated with another commit.  Ready to merge.  As soon as you do, I'll kick off the publish.


Added a method mul()

This method is for simple multiplication of two vectors

Can you give an example of where/how this would be used? I haven't really had a use for vectors multiplied this way.
(I think this is called a Hadamard Product)

Its an obscure one for sure, usually id use this kind of calculation when applying some kind of friction vector to an velocity vector before applying it to a player position rather than manually multiplying the x's and y's. eg
playerVel.mul(playerAcc);
playerVel.mul(worldFriction);
playerPos.add(playerVel);

Naturally an incomplete description but i think I made the point, also I think I may have made a typo anyway in the function if you do accept it.

Ah,  I think you can do this with the existing scale function (The only difference is that it doesn't directly take in a vector parameter, but individual x and y parameters):
val.scale(acc.x, acc.y)
vel.scale(friction.x, friction.y)
pos.add(vel)

Given that it's pretty easy to accomplish this by using the scale method, I'm going to close this.


cannot use HTTP proxy

How to use an HTTP proxy to connect to ES

Hi @913072870 , for now EDQL doesn't support http proxy, I will try to  add this feature to support http proxy, maybe we can release in next version : 1.9.27, thanks your feedback. 👍

Hi @913072870  , this feature is supported in version v1.9.27, so now you connect your Elasticsearch by using your Intellij system http proxy. if you meet any issue, please let me know.

Since Jetbrains still reviewing the new version, you can manually download, and reinstall plugin: v1.9.27

👍

Hi @913072870 please use the latest version: v1.9.27, and also you can download from Jetbrains market v1.9.27
Thanks your feedback 🥰🥰🥰


Experimental content trust verification using TUF

This is an experiment using TUF (The Update Framework) content trust verification for Helm charts when using OCI registries.
This should probably be a plugin, but this was the easiest way to tie in to the existing infrastructure for using OCI registries with charts, and the current state of the PR is just an experiment.
Also, the current implementation is extremely naive:

it only checks the content digest, as opposed to performing the entire workflow for verification
it allows pulling the bundle and adding it to the cache before doing the digest verification, and removes it afterwards, if the digests do not match
it doesn't properly handle all cases for nested registries and repositories
To test:

$ export HELM_EXPERIMENTAL_OCI=1

$ export HELM_ROOT_PASSPHRASE=PassPhrase#123
$ export HELM_TARGETS_PASSPHRASE=PassPhrase#123
$ export HELM_SNAPSHOT_PASSPHRASE=PassPhrase#123
$ export HELM_DELEGATION_PASSPHRASE=PassPhrase#123
$ export NOTARY_CA=$GOPATH/src/github.com/theupdateframework/notary/cmd/notary/root-ca.crt

$ cd $GOPATH/src/github.com && mkdir theupdateframework && cd theupdateframework && git clone https://github.com/theupdateframework/notary && cd notary && docker-compose up -d

Creating network "notary_mdb" with the default driver
Creating network "notary_sig" with the default driver                                                                           Creating volume "notary_notary_data" with default
Creating notary_mysql_1 ... done
Creating notary_signer_1 ... done
Creating notary_server_1 ... done

$ docker run -it -d  -p 5000:5000 registry

$ helm chart list
REF                             NAME    VERSION DIGEST  SIZE    CREATED
localhost:5000/brigade:v1       brigade 0.0.1   a5c5ca8 4.2 KiB 5 hours

$ helm chart push localhost:5000/brigade:v1 --tlscacert=$NOTARY_CA --server=https://localhost:4443 --signature
The push refers to repository [localhost:5000/brigade]
ref:     localhost:5000/brigade:v1
digest:  a5c5ca802c0f691d8c4bdf29168afa20ee2c279bb5bba95ff7b54184bca8d159
size:    4.2 KiB
name:    brigade
version: 0.0.1
v1: pushed to remote (1 layer, 4.2 KiB total)

$ notary list brigade --tlscacert=$NOTARY_CA --server=https://localhost:4443 --trustDir ~/.cache/helm/registry/trust
NAME    DIGEST                                                              SIZE (BYTES)    ROLE
----    ------                                                              ------------    ----
v1      a5c5ca802c0f691d8c4bdf29168afa20ee2c279bb5bba95ff7b54184bca8d159    4311            targets

$ helm chart remove localhost:5000/brigade:v1
v1: removed

$ helm chart pull localhost:5000/brigade:v1 --tlscacert=$NOTARY_CA --server=https://localhost:4443 --signature
v1: Pulling from localhost:5000/brigade
ref:     localhost:5000/brigade:v1
digest:  a5c5ca802c0f691d8c4bdf29168afa20ee2c279bb5bba95ff7b54184bca8d159
size:    4.2 KiB
name:    brigade
version: 0.0.1
Status: Downloaded newer chart for localhost:5000/brigade:v1

The workflow is as follows:

when the pushing a chart to an OCI registry, if the --signature flag is passed, the signature is pushed to a trust server
when pulling, if the --signature flag is passed, the signature is pulled from the TUF server, the chart is pulled, then the digests are checked. If they are not equal, the chart is deleted.

If this is an area we think is worth exploring, I'd be happy to clean it up and move this to a plugin.
Note on using TUF / Notary: while the current implementation is using the Notary client libraries, and is shown using a Notary server, the actual collections are TUF collections, so in theory they could be used with any TUF server.

@radu-matei I'm excited to see this!

@radu-matei :100:

@radu-matei this looks really good.. I'd vote to make this part of the codebase as support for Notary

Apologies for the automatic closure. We just switched the dev-v3 branch to master, and the old master branch is now dev-v2. Feel free to re-open a new PR with this change. Thanks again and sorry for the hassle!


Create intra dc firewall rule

This was to make the final change to the 4th boldpoint to be required under content properties.

@aaronsr Please resolve conflicts

Closing old PR with conflicts


Issue with Backspace Input being Laggy, Patched

Description

Backspace input was laggy and bugged out when pressed for long
Fixes issue #
Motivation and Context

How Has This Been Tested?

[x] Ran our included tests
[x] Manual QA
[ ] New test written

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@satanb4 Is it ready for review?

Yes @hericlesme

Okay, @satanb4. Sorry for the delay :crying_cat_face:

Thank You! :D


Add an iframe embedding example that use JWT auth

This examples using the existing JWT configuration to start up a local webserver and embed a random sheet from the app published as part of the tenant_deploy_content scripts.
The embedding is based on this example from qlik.dev.

You are assuming the customer knows how to write jinja templates. Is there a reason why your iframe template is in python rather than javascript / html?

The only Jinja part is the variable substitution at the top of the file, the rest is a straight copy of this example.
The alternate would be to read the file in and do a regex substitution. Jinja seems a better alternative, but I don't have a strong opinion...

You are assuming the customer knows how to write jinja templates. Is there a reason why your iframe template is in python rather than javascript / html?

The only Jinja part is the variable substitution at the top of the file, the rest is a straight copy of this example.
The alternate would be to read the file in and do a regex substitution. Jinja seems a better alternative, but I don't have a strong opinion...
Maybe I could update the docs to point relevant section in the tutorial here and mention that Jinja is used to sub in the values.

@goldbergjeffrey - I've added some words to the README.md to link back to Dan's tutorial and explain the use of Jinja.


HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic

Description of PR
https://issues.apache.org/jira/browse/HDFS-17247

The AvailableSpaceBlockPlacementPolicy has made some optimizations such as HDFS-14578 can have local node optimization and HDFS-17210 can avoid choosing nodes with higher storage, the AvailableSpaceRackFaultTolerantBlockPlacementPolicy need keep same logics of optimization same as ASBPP.

Currently considering implementing a public class, such as AvailableSpaceBlockPlacementPolicyUtils, and abstract some public methods such as chooseLocalStorage, swapStorageTypes, select, compareDataNode, the AvailableSpaceBlockPlacementPolicy and AvailableSpaceRackFaultTolerantBlockPlacementPolicy can call related methods in AvailableSpaceBlockPlacementPolicyUtils. If there are related optimizations later, they can be modified based on AvailableSpaceBlockPlacementPolicyUtils.

Improve some doc descriptions and configuration parameters

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
8m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
39m 34s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 46s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 56s

trunk passed

+1 :green_heart:
shadedclient
22m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 43s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 35s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 22 new + 228 unchanged - 6 fixed = 250 total (was 234)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 54s

the patch passed

+1 :green_heart:
shadedclient
21m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
195m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

303m  7s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6245

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux e98ad354d786 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a988804ad09eba6f2fb1c8ee36fce68dea2c8a89

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/1/testReport/

Max. process+thread count
3776 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The implementation logic in both the AvailableSpaceBlockPlacementPolicy and AvailableSpaceRackFaultTolerantBlockPlacementPolicy is essentially identical.
therefore, a public class called AvailableSpaceBlockPlacementPolicyUtils has been created.
this enables any potential future optimizations to be made to AvailableSpaceBlockPlacementPolicyUtils, allowing for easy modifications to both policies.
Hi @ayushtkn @Hexiaoqiao @ZanderXu @tomscut @zhangshuyan0  Would you mind to take a review this pr?  thank you very much~

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 47s

trunk passed

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 47s

trunk passed

+1 :green_heart:
mvnsite
0m 52s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 53s

trunk passed

+1 :green_heart:
shadedclient
21m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 35s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 21 new + 228 unchanged - 6 fixed = 249 total (was 234)

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 50s

the patch passed

+1 :green_heart:
shadedclient
21m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
193m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

285m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6245

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux ab575bd87db0 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5e99ff941be7c2d7d1cd1c4d727900ac24688e14

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/2/testReport/

Max. process+thread count
3526 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 49s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 52s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
21m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 35s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 21 new + 228 unchanged - 6 fixed = 249 total (was 234)

+1 :green_heart:
mvnsite
0m 43s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 51s

the patch passed

+1 :green_heart:
shadedclient
21m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
192m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

283m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6245

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux d84c2e9c7df1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4ae1ed85a8873afa520ee4c9b81b11b6faf0a6dc

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/3/testReport/

Max. process+thread count
4060 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6245/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn  Would you mind to take a review this pr when you have time? thank you very much~


Build time improvements: Eject samples from CRA

What
Eject samples from CRA

Use a barebones webpack (and webpack dev server for development)

Also:

Upgrade to webpack5 to fix dev server hanging issue
Fix dependencies that broke build when rush update --full performed
Remove use of preval to get build time and use webpack variable injection instead

Why
Perf

We have large CI build times with easiest large gains coming from samples

Dev inner loop improvements

No longer rely on rush module linking for samples and directly alias to source code
This massivly improves local build times, more reliable hot reloading, much faster hot reloading and less confusing output in the terminal

Perf
CI Runs:

Before
After
Improvement

13-16 minutes
8-10minutes
-5-6 minutes

Local Tests for Calling Sample:

Before
After
Improvement

Production Build (dependencies already built)
63s
51s
-12s

Production Build (dependencies not built)
5min 4s
51s
-4min 15s

npm run start (dependencies already built) (until homepage loaded)
2min 17s
27s
-1min 50s

npm run start (dependencies not built) (until homepage loaded)
3min 56s
27s
-2min 29s

Hot reload (change made in react-components dir)
20 seconds (+ other packlets still recompiling)
4s
-16s

Profiler still crashes 😥
How Tested
Samples working locally
Haven't tested deployed sample

The build time improvements are amazing. Bravo!
I'm a bit conflicted about sample apps using the uncompiled package sources though.
Is the source mapping also required for build time improvements, or is it only for hot reloading?
The concern would be some build related issues slipping through the cracks / the samples not quite working if they code is copied as-is to an independent project (which customers are expected to do to kickstart their apps).

Just for hot reloading (though build time will also be affected as first the dependencies will need built then the sample app webpack run).
I agree with the concerns but I think the solution is to move samples to using the public npm package (either latest of alpha, we can decide), then for local dev you run a script that points the sample to the local communication-react folder to support hot reloading.

Land this already so I can speed up my edit-compile-test cycle for the day :D

Land this already so I can speed up my edit-compile-test cycle for the day :D

I don't feel hesitant anymore having to run the samples! It's really nice 😅

Thanks for landing this @JamesBurnside
Did you have to remove polyfills and shims in webpack config?
I remember the original ejected webpack being a very large file.
Are we removing something that might cause our sample to stop working as expected on a specific browser?
If yes, I think we should test the generated sample thoroughly on each major browser before we merge this in.


New CMake setup fails on cmake 3.12

CMake Error at IlmBase/CMakeLists.txt:5 (cmake_policy):
  Policy "CMP0076" is not known to this version of CMake.

cmake_minimum_required(VERSION 3.12) but this policy is only introduced in 3.13. Unfortunately 3.12 is the best I get on a stock Ubuntu 18.10.
If I comment out the policy line, it configures and compiles just fine.

Maybe this would be a viable option without outright requiring 3.13:
if(POLICY CMP0076)
  cmake_policy(SET CMP0076 NEW)
endif()

As an afterthought: maybe supporting the stock cmake of the most recent Ubuntu LTS (18.04) which would be 3.10, would be worth the hassle. No idea what features would be missing compared to 3.12, though.

This policy converts relative paths to absolute in target_sources - @kdt3rd, I'm curious where this comes up? https://cmake.org/cmake/help/git-stage/policy/CMP0076.html

oh, I wanted to use cmake 3.12 because of the improved FindPython logic to handle both python 2 and 3 at the same time. Additionally, I use object libraries such that when you have the make both shared and static libraries turned on, it doesn't have to re-compile everything twice. In 3.12, these object libraries can be used in the target link calls, and it injects the .o into the resulting library, and carries the compile flags, etc. along with it, so I don't have to replicate that.
Both pretty nice features, and while I could do the object libraries a different way, as we head to VFX Platform 2020, with it's python 3 requirement, I don't want to make that any more complex than it is already with the boost python stuff, I'd rather spend the time switching to pybind11 :)
Back to the policy, I was originally using target_sources, as that is recommended in a bunch of the 'More Modern CMake' stuff, however, when I added the macros I've added to centralize the library creation, the need for them has largely gone away, so I believe we can just remove that policy entirely.
I need to touch all the cmake files today, will remove that policy set.

So there seems to be plenty of good reason to require 3.12. I'm personally all in on making progress and getting rid of cruft. Thanks for the background info.


feat: add MediumShareButton component for sharing to Medium

I added a new button for Medium.

Thanks @paulpietzko! Updated the docs and bumped the version number


Improve debug messages

[x] add debug when sending email report
[x] add debug when email failed

Done in commit c3f2004b1fd8d0f5121998d8f6db9172010f9caf


[DOCS] Train Reward Model RLHF tutorial needs a workspace name

There is no default behaviour for using workspaces when no workspace name is defined. We should define a default workspace name admin to align with the rest of the tutorials, but this also opens the debate for adding a default to Argilla @davidberenstein1957

I agree, using the default is better.