BUG - The Standard Journal Image not work anymore with 2.3.7

Environment Details
Foundry VTT Version: 0.8.8
Operating System: [Linux]
How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]
Which Game System: Dungeons and Dragons 5th Edition, version 1.4.1
Modules Enabled?: Yes (if you need i can give you the full list)
Module version: 2.3.7
OS, Hosting, Browser (if applicable): Linux/Node/Chrome
Description of the issue:
When i click on the image panel of the standard journal of Foundry now i see the "embedded" version of the image with no url at the bottom.

This error was not present this Wednesday when I did the session, so it must be something inserted after version 2.3.5 / 2.3.6, or maybe some conflict with the update of the module _document-sheet-registrar
Confirmed with some test is something done between 2.3.6. and 2.3.7 version (tested with last version of _document-sheet-registrar 0.5.0 ).

Thanks for this issue. Let this be a lesson in doing hasty changes without properly testing them... 🤦 Should be fixed in the new release coming up in a few minutes.


Cannot reproduce the results on IJBB and IJBC

I used the pretrained IR101 model and the IJB evaluation code from insightface. Following are the results I got:
IJB-B TAR@FAR:
1e-6 -> 41.76%
1e-5 -> 69.81%
1e-4 -> 87.14%
1e-3 -> 93.27%
IJB-C TAR@FAR:
1e-6 -> 62.64%
1e-5 -> 75.46%
1e-4 -> 87.53%
1e-3 -> 94.01%
There is no problem if I use the pretrained models from face.evoLVe.PyTorch. Would you please share the evaluation code on IJB-B and IJB-C?

I found the problem is due the face alignment. Once I change to the same face alignment code as inisightface, I can reproduce the results.
from skimage import transform as trans
def alignment(img, landmark):
	image_size = (112, 112)
	src = np.array([
		[30.2946, 51.6963],
		[65.5318, 51.5014],
		[48.0252, 71.7366],
		[33.5493, 92.3655],
		[62.7299, 92.2041]], dtype=np.float32)
	src[:, 0] += 8.0
	assert landmark.shape[0] == 68 or landmark.shape[0] == 5
	assert landmark.shape[1] == 2
	if landmark.shape[0] == 68:
		landmark5 = np.zeros((5, 2), dtype=np.float32)
		landmark5[0] = (landmark[36] + landmark[39]) / 2
		landmark5[1] = (landmark[42] + landmark[45]) / 2
		landmark5[2] = landmark[30]
		landmark5[3] = landmark[48]
		landmark5[4] = landmark[54]
	else:
		landmark5 = landmark
	tform = trans.SimilarityTransform()
	tform.estimate(landmark5, src)
	M = tform.params[0:2, :]
	img = cv2.warpAffine(img, M, (image_size[1], image_size[0]), borderValue=0.0)
	return img

hi, this is my first time doing an experiment about face recognition. Could you share the IJB evaluation code which you used before? It will be very helpful. Thanks a lot!

@CloudWalking0 I download the notebook and data from here: https://github.com/deepinsight/insightface/tree/8d971de36370320c286f8bf92829f2995234b386/recognition/evaluation/ijb , and then replace the mxnet model to pytorch model


Capstone

Hello 👋🏻
For this project, following the  description and requirements we are adding:

Home page showing a list of items that you can "like."
Popup window with more data about an item that you can use to comment on it or reserve it for a period of time.

The requirements: 💯

Using API :

Pokeapi: data about the Pokémon world.

Interface:

The home page
The comments popup
The reservations popup

Home page

When the page loads, the webapp retrieves data from:

The selected API and shows the list of items on screen.
The Involvement API to show the item likes.

Remember that your page should make only 2 requests:

One to the base API.
And one to the Involvement API.

When the user clicks on the Like button of an item, the interaction is recorded in the Involvement API and the screen is updated.
When the user clicks on the "Comments" button, the Comments popup appears.
When the user clicks on the "Reservations" button, the Reservations popup appears (only for the groups of 3 students).
Home page header and navigation similar to the given mockup.
Home page footer similar to the given mockup.

Comments popup

When the popup loads, the webapp retrieves data from:

The selected API and shows details about the selected item.
The Involvement API to show the item comments.

When the user clicks on the "Comment" button, the data is recorded in the Involvement API and the screen is updated.

Reservations popup (only for the groups of 3 students)

When the popup loads, the webapp retrieves data from:

The selected API and shows details about the selected item.
The Involvement API to show the item reservations.

When the user clicks on the "Reserve" button, the data is recorded in the Involvement API and the screen is updated.

Counters 🔢
We have counters in all the interfaces that show:

The number of items (home).

The number of comments (comments popup).

The number of reservations (reservations popup) - only for the groups of 3 students.

Demo of the project 👀

Presentation of the project 📈

@rukundoeric, Thank you so much. 😄
For the review and the optional suggestions.
My team and I appreciate it and will try to implement them in similar future works. 👍🏻


[Question] Why isn't everything here just put on neofetch?

If fastfetch is so much faster then neofetch and they're both open source and MIT licensed, why isn't the code here just put on neofetch? What's the point of an entirely new program to do the same thing but better? Why not just make the original neofetch faster? It's not like there's people out there who specifically need neofetch to be slow

Because this would require 100% of neofetch's code to be wiped, and replaced with this code.
Neofetch is written in bash, fastfetch is written in C.

A second point is, that fastfetch and neofetch target a different set of machines. Fastfetch targets only Linux Systems, so i can make use of a lot of linux specific features to achieve the speed fastfetch has. Neofetch also supports MacOS, Windows and a lot of other different systems. If you wanted fastfetch to also support those systems, you basically would have to rewrite the hole thing from scratch.


Support Julia 1.7

RegistrySpec moved from Pkg.Types to Pkg.Registry.
Since Pkg.RegistrySpec works on all Julia versions back to
1.2 (the earliest version supported), we don't need explicit
version checks if we use this more general way of accessing
the type.

CI is currently on Travis, and it will take a while for me to migrate to GHA because of the complexity of the integration test setup. So I'll YOLO merge thus.

Can you bump the version number?


[stable/mariadb] fix wrong env variable in slave metrics container

In the slave statefulset, the metrics container uses an env variable that is not set.
The fix sets the expected env variable so that the metrics container can connect to the database to scrape the necessary tables.

/assign @juan131

/ok-to-test
/lgtm

Thanks!!


Elasticsearch complement for reads and writes

** Category: AppSync **
Hi hackers!
Context: Please suppose we use amplify js to create an Appsync endpoint using the @search directive.
I was wondering... what the differences are between using AWS.DynamoDB.DocumentClient() and AWS.HttpRequest(appsyncUrl, region) approaches. We would like to find out if both approaches are automatically using or not the Elasticsearch complement for reads and writes to the DynamoDB + Elasticsearch strategy?

https://serverless-stack.com/chapters/add-a-create-note-api.html

new AWS.DynamoDB.DocumentClient()

https://aws-amplify.github.io/docs/cli-toolchain/quickstart#graphql-from-lambda

new AWS.HttpRequest(appsyncUrl, region);

@josoroma  With approach 1 i.e AWS.DynamoDB.DocumentClient() you're directly querying your DynamoDB wheras with approach 2 i.e with  AWS.HttpRequest(appsyncUrl, region) you'd be querying AppSync (a managed GraphQL service) using GraphQL queries.
Both the approaches will trigger the Lambda associated with the DynamoDB to stream results to Elasticsearch.

@kaustavghosh06 Thank you for clarifying, very useful.


Contextual transitions

As proposed, here is the ability to use contextual transitions. Meaning, a transition that fires when clicking a certain link.
Here are some notes:

Rather than setting the transition in the getTransition function in helpers, we must override the transition on the fly by passing in either the contextual transition or false to transition.js.
This is because we don't want to mess with the transition assigned to a view, and we don't want the contextual transition to fire on popstate. It must only fire when clicking a particular link, all other view transitions must be left alone.
I tried it several ways, and this was the most reliable way I could accomplish the feature. Perhaps you could think of ways to trim my code more.

To accomplish this we:

Save all transitions to this.Transitions in the core constructor
Also in the core constructor, set this.contextualTransition to false (default)
In navigate(e), check if the clicked anchor has data-transition if it does, set this.contextualTransition to the transition. Else set it to false.
In the hide() and show() functions, we pass in this.contextualTransition, which is passed all the way to the transition itself.
In transition.js we check whether the contextual transition is false, if not we use the contextual transition. If it is false, we simply use the transition from the view.
On popstate, set this.contextualTransition to false no matter what, since we should use the default/view transition when navigating via browser buttons.

Woaw @joshkirk-zero great work here, we're definitely going to have a look tomorrow at your solution for this issue !
Thanks already for coming up with a complete solution and this nice explaining comment, we will keep you updated as soon as possible, but it seems really promising !
Have a great night!

Thanks @joshkirk-zero! I quickly check the changes committed and it already looks awesome. Give me a bit of time to completely review everything and I'll create a new release when done and keep you in touch here or by email.

Nice I'm glad you like it 👍
A couple other small notes now that I've had another night to think about it..

Feel free to change the name of things to better suit your conventions if you want
I tried making it as concise as possible, but it felt a little weird having a bool check on every transition. I couldn't think of a less verbose way to do it though. In the end it's just a single false check that's going to hit first, and all of the transitions are just standing by, waiting to fire anyway. At least that was my conclusion, but I've only spent a couple days in the library.
I hastily added two example transitions and the snippet in the documentation, so feel free to clean those up or add to them however you want.

I can't think of anything else at the moment, but I'm available for further discussion.
Thank you

Oh yeah, also I was new to Jekyll, and the way the docs build worked inside the highway build confused me for little bit, so I hope I committed all the relevant files. I think you'll have to run the docs build and the highway build.


Bug Fix -- Reading Value Mis-Assigned During Unmarshal

#1292
Consumption of new core-contracts to pick up this bug fix.
Signed-off-by: Trevor Conn<EMAIL_ADDRESS>

recheck


Roll engine c622e563e764..5a694c47738d (3 commits)

https://github.com/flutter/engine/compare/c622e563e764...5a694c47738d
git log c622e563e764..5a694c47738d --no-merges --oneline
5a694c477 Roll src/third_party/skia c00e47054744..3b155a77c370 (2 commits) (flutter/engine#6881)
5ded3679e Roll src/third_party/skia a89316d8227b..c00e47054744 (4 commits) (flutter/engine#6880)
5c327e196 Roll src/third_party/skia c5df7cb3d9f7..a89316d8227b (10 commits) (flutter/engine#6878)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll


An Explaination on How Combat Works?

Hello,
I was just wondering if there is a guide somewhere as to how the combat/unit balance works in Crusader.
In the official patch some unit changes happened, like the Arab swordsman crossbow defense.
Are these stats in the code that can be adjusted? If so is there a list of them?
Cause I imagine there are stats like:
Arrow Defense
Bolt Defense
Rock Defense
Fire Defense
Wall Arrow Defense?
Wall Arrow Attack?
Melee Attack
Melee Defense
Melee Unit Multiplicative Stat(like how 3 Monks fighting together are more powerful then 3 Mace-men fighting together but 1 v 1 a Mace-man wins)
POS Fear Factor
NEG Fear Factor
Charge Bonus?
Arrow Damage
Bolt Damage
Rock Damage
ETC.
I'm just curious because for unit balance, even to make suggestions it would helpful if we knew what stats/attributes can be adjusted.
As of the current patch, I'd say there are two pretty big unit balance issues.
First, Monks die just as fast as Spear-men to arrows/bolts. I feel they should have the same Arrow/bolt defense as Mace-men. Yes Mace-men require two weapons to make, where monks don't, but monks are less powerful attack-wise, individually, can't climb ladders, can't dig moats and are way slower, so I think they'd be more balanced that way. The Abbot feels really under-powered attack-wise. Just run a Abbot vs Snake/PIG/Wolf and just laugh at the monks dying instantly to archers. The only thing that makes him even remotely potent is the catapults he builds.
Secondly, Slingers are woefuly underpowered. They have less range then all other ranged units, yet when they do get into range the payoff for that is none existent. I feel their own defense is fine they are cheap after all, but their attack power against melee units specifically could be significantly buffed as a reward for getting them into range to attack.

This is a duplicate #478

As for the two underpowered items you mention, fully disagree. The two units are both anti-melee units, and are seriously powerful when used for that purpose, if you have been following krarilotus's Christmas campaign there are several times when you have to use those units as your primary defense to survive, no other unit can compare to them in their strength.
In multiplayer, when playing vanilla rules on vanilla maps, I often add slingers to my assault force mixed with ha and shields to kill any knights or assassins that try to push me off, their lesser range is a benefit in this case cos ranged units by default target ranged units first, so your horse archers are busy shooting enemy ha behind shields and ignoring the melee while generally the ha are out of range of my slings so they are free to target the melee first. And they are pretty much as good as crossbows in dps due to their reload speed, better in some cases.

Yeah Slingers are really good for early game assaults and reinforcements.
Monks are fine too. They're very spammy.

Regarding what parameters exist, https://github.com/Sh0wdown/UnofficialCrusaderPatch/issues/271 shows some parameters.

Basically what I'm getting is all the unit stats aren't known yet/explored as they still coded in hex?
Also I am basing the balnce of those units off of AI. Humans no doubt can use them far better than CPU's can. But any match I have with the Sultan or Abbot in them they get destroyed if the game goes past 10 mins by virtually all the other AI lords.
I myself have my own AIC and AIV's going and have tampered with their balances, while still keeping their "character" in tact. And with improved defenses for most AI's, Monks in particular are very underwhelming to watch try siegeing a keep. If i wish to keep the Abbot Archer and Monk, then most I would say he is the third weakest lord. Ya his economy is second to none, but his troops are abysmal.
But if Sh0Wdown makes an upcoming patch with changeable parameters, then I guess we all can change it to our desires.

That's like saying slaves need improvement because snake dies. What you need to do is modify the ais to use the units effectively, instead of overpowering them so that the ai doesn't need fixing. Check out krarilotus's aggressive ai for a implementation of this methodology. All ais stay true to their core personalities, but attack earlier, harder and faster. Abbot get some swords to help and I think so seige to help kill the ranged so the monks are more effective, and abbot gets more archers (which he already used)


Implement report approvals

Details

cc @mountiny @luacmartins
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/303752
Tests

[ ] Verify that no errors appear in the JS console

Create a Control policy in OldDot.
Enable this policy for expense chats, replace {policyID} with the ID of the policy we just created:

update nameValuePairs set value = JSON_SET(value, '$.isPolicyExpenseChatEnabled', 'true') where name = "expensify_policy{policyID}";

Invite two members, let's call them<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Set the submitsTo of<EMAIL_ADDRESS>to<EMAIL_ADDRESS> meaning the principal will be the manager of the teacher. Do not set a forwardsTo.
Head to NewDot and log in as the teacher.
Navigate to the workspace chat.
Click on "+" and created a Split Bill request.
Log in as the principal now<EMAIL_ADDRESS>Make sure the expense report in the LHN and a green dot next to it. The policy expense chat will NOT appear.
Make sure you see the 'Approve' button. Do not approve yet.
Log in now as the admin of the control policy.
Make sure you see both the policy expense chat of the teacher and the expense report create.
Verify no green dot appears next to the expense report. Navigate to the report and verify you don't see the 'Approve' button nor the settlement button.
Log in back to the principal account so we can approve the report.
Approve the report and make sure an approved ${amount} action has been created.
Make sure the IOU preview displays Cash • Approved.
The green dot should disappear now.
Let's login as the admin of the policy again.
The green dot should appear next to the expense report.
You should see the settlement button now when that the report has been approved.
Navigate to the policy expense chat, and make sure the report preview says<EMAIL_ADDRESS>approved ${amount}.

Note: there is currently a bug being worked on where the expense report shows initially $0 because we are not fetching the transactions from Auth and setting them in Onyx. The Split report action will also show $0 when you log out then back in.
Offline tests

QA Steps

Must be QA'ed internally, same steps as above.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

https://github.com/Expensify/App/assets/9680864/1a95a11b-0147-4e49-8e6d-c02e4fad09f9

Mobile Web - Safari

Desktop

iOS

Android

Sorry @aimane-chnaif this must be tested internally.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@luacmartins feel free to remove your request for a review if you want
@youssef-lr there are some merge conflicts now

Comments addressed!

Updated @luacmartins @mountiny!

@youssef-lr There are no recordings on in the PR body, I believe you have tested this fully but it would be handy to have at least web recordings to see it works on your end

@mountiny Added web recording! We can test this on staging once this PR is merged and deployed. But we're good to go for merging because this is hidden behind an NVP flag.

This is failing for the admin. I can see the green dot next to the expense report. I can also see both approve and pay buttons and their style is a bit off.
Hmm I'm not able to reproduce this, can you show me please how the configuration looks like in oldDot => people?

the admin did not get notified about the approval (until they load the expense report)

Hmm yeah I noticed this recently, I could swear it was working fine before. I'll create an issue for this to be fixed in Web-E.

tests passed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.59-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Mutation fails when input field is not specified that is part of a permission query

 Issue by Jesus-Gonzalez
Wednesday May 31, 2017 at 17:00 GMT
Originally opened as https://github.com/graphcool/api-bugs/issues/89

Hello,
I have just experienced an issue in the playground.
When I execute a mutation that has not been pushed enough parameters, it will fail once executed.
Thanks,
Jesús

 Comment by marktani
Wednesday May 31, 2017 at 17:46 GMT

thanks for reporting that issue @Jesus-Gonzalez 🙏
This happens when a permission query uses a relational input id like $input_groupId and the mutation looks like this:
mutation {
  createItem(name: "Hello") {
    id
  }
}

It works when passing a groupId:
mutation {
  createItem(name: "Hello" groupId: "some-id") {
    id
  }
}

 Comment by marktani
Friday Jun 16, 2017 at 16:15 GMT

The intended behaviour is that fields that are not specified in the mutation itself should be assumed to be null instead. We're looking to correct this behaviour soon!


Added clusterIP service type for provider server

On HCI cluster the hosted OCP cluster are on the same pod network as the Host OCP so a ClientIP service will be the better option than NodePort / LoadBalancer.
ProviderAPIServerServiceType needs to be updated in ocs-operator so that it takes ClusterIP as a value and creates the service

On HCI cluster the hosted OCP cluster are on the same pod network as the Host OCP so a ClientIP service will be the better option than NodePort / LoadBalancer.
ProviderAPIServerServiceType needs to be updated in ocs-operator so that it takes ClusterIP as a value and creates the service

Will this work for RDR for provider as well? or we are going to run new service between api-server for RDR?

On HCI cluster the hosted OCP cluster are on the same pod network as the Host OCP so a ClientIP service will be the better option than NodePort / LoadBalancer.
ProviderAPIServerServiceType needs to be updated in ocs-operator so that it takes ClusterIP as a value and creates the service

Will this work for RDR for provider as well? or we are going to run new service between api-server for RDR?

There needs to be a nodePort service created so that provider services can reach each other. Also there needs to be a further discussion regarding this

/ok-to-test

Will this work for RDR for provider as well? or we are going to run new service between api-server for RDR?

@Madhu-1 do you mean, configuring both NodePort/LB and ClusterIP for apiServer or a new gRPC altogether?

Will this work for RDR for provider as well? or we are going to run new service between api-server for RDR?

@Madhu-1 do you mean, configuring both NodePort/LB and ClusterIP for apiServer or a new gRPC altogether?

i don't know the plan around RDR yet but i was curious to know more about it what is the use of clusterIP server and are we going to have two services for the provider server? With the current code it looks like only one service with clusterIP is created but in RDR i don't think two clusters will be able to talk over clusterIP (but I could be wrong as i don't know much about architecture of it yet)

Testing the code changes

@Madhu-1, seems I missed your reply

but i was curious to know more about it what is the use of clusterIP server

this is more tailored to HCI wherein, Kubevirt instances are also on pod network (new to me) and so client operator can reach provider within the cluster

are we going to have two services for the provider server?

ya, that is TBD and at the same time, addition is easier than deletion and so I believe going with one service is ok for now

but in RDR i don't think two clusters will be able to talk over clusterIP (but I could be wrong ...

I don't think you are wrong, I'd defer to @rewantsoni to come with arguments or opinions that has to do anything with RDR for HCI.

@rohan47 Can you pls make above changes mistakenly approved it.

@Madhu-1, seems I missed your reply

but i was curious to know more about it what is the use of clusterIP server

* this is more tailored to HCI wherein, Kubevirt instances are also on pod network (new to me) and so client operator can reach provider within the cluster

are we going to have two services for the provider server?
we can change the service type in the storagecluster and the change will reflect

* ya, that is TBD and at the same time, addition is easier than deletion and so I believe going with one service is ok for now

but in RDR i don't think two clusters will be able to talk over clusterIP (but I could be wrong ...

Two clusters cant talk over clusterIP

* I don't think you are wrong, I'd defer to @rewantsoni to come with arguments or opinions that has to do anything with RDR for HCI.

We can change the service type when required for RDR or create a temporary node port service. What do you say @rewantsoni

/lgtm

/lgtm

/unhold


Adding limitation about "Put Block" method

added limitations to "put block" method

@arduppal : Thanks for your contribution! The author, @kgremban, has been notified to review your proposed change.


Return empty value from API method

Alternatives:

Return new Error('Empty value')
Throw error
Return undefined (for scalar types) and null (for reference types)
With contract definition returns: '?SchemaName'

If no result value (for example not found)

Return empty array if multiple values expected
Return undefined if single value expected

Return Error if expected business-logic error occurred
Throw if unexpected error occurred


Port test to junit.

Review by @sjrd.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2877/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3710/
Test FAILed.

That's all, I think.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2878/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3711/
Test PASSed.

That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2879/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3712/
Test PASSed.

LGTM


MI300X system tuning guide (BIOS/OS settings, System management sections)

Need redirects from how-to/tuning-guides/* to how-to/system-optimization/*


Added some Windows support

I added colorama for windows support, a file for windows key codes, and tweaked line clearing to make bullet work on Windows. Unfortunately, I couldn't find a way to show emoji in cmd.exe console, so  scrollbar.py or star.py from examples folder don't render correctly. All other examples work. I hope I didn't break anything for other systems.

Closing this PR due to inactivity.


fix(grant): fix import grants

fix nil pointer exception
keep list grants and list resources matching with the import criteria
add test cases

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

52 of 54 (96.3%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.1%) to 73.647%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/grant/service.go
34
36
94.44%

Totals

Change from base Build<PHONE_NUMBER>:
1.1%

Covered Lines:
7473

Relevant Lines:
10147

💛  - Coveralls


API CSV/JSON update frequency [query]

Describe the bug
CSV files available at https://api.covid19india.org/csv/ not updated.
the recent pull from the data shows the csv is updated only until 26th April
EDIT: I believe the JSON files are updated (30th April). Any reason why the csv file is not?
To Reproduce
Steps to reproduce the behavior:

Go to https://api.covid19india.org/csv/
Download the raw_data.csv file
Open the file & check for Date Announced column

else please check the kaggle notebook
https://www.kaggle.com/skylord/real-time-tracking-of-r-t-for-indian-state
Expected behavior
Expecting daily updates on the csv files. It's easier to take a csv file & process it
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version NA

I cannot see latest data in JSON as well. could you provide the link from where you are checking?

I cannot see latest data in JSON as well. could you provide the link from where you are checking?

https://api.covid19india.org/raw_data3.json

Okay.. there seems to be another issue.
data from the latest json file doesnt match with the older csv data (26th April)

is there any data quality check? if required, i can help with that.

Thanks for using the data!
We had changed the way in which we capture in the information from Apr 26th onwards. raw_data3.csv is the latest format. It has a "Num_Cases" column which is used to update the data in bulk. Also, the Deaths and Recoveries are also added in the same file. I've updated the landing page of the csv files to provide more information. Please refer https://api.covid19india.org/csv/
Feel free to ask more questions in this thread if you have any.

Thanks for clarification. Much appreciated.

Appreciated!
is it possible to have a single json & csv file? making them backward compatible, so that the additional columns are included in the previous files?


Update this melt so that it is not mandatory to have a 'time' indice

https://github.com/ontime-re/ontime/blob/ec442e3d30c4c4aa44dbec46e0bbf3571e232b42/src/ontime/core/plotting/plot.py#L57

Here you go @ben-jy, I added everything in the param of the function to be able to adjust this when needed, while staying non-destructive.


Website footer change to Linux Foundation

Hi all,
This should be added to the website footer:
2020 © Falco Project Authors. All rights reserved. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our Trademark Usage page: https://www.linuxfoundation.org/trademark-usage
Happy to submit a PR to correct, just direct me to the right place!

Ok @amye :)
Moving this issue to https://github.com/falcosecurity/falco-website repo, thanks.


usb: correct udc_dev parameter name

Rename uhc_dev parameter of USBD_DEVICE_DEFINE macro to udc_dev to reflect that this is a USB Device Controller device and not a USB Host Controller device.

@jfischer-no can you please take a look?


Update Blog “cat”

Automatically generated by Netlify CMS

👷 Deploy Preview for playful-alpaca-ff74dc processing.

Name
Link

🔨 Latest commit
292b00c6b292b041e78fb8fb6fd992037f3051ab

🔍 Latest deploy log
https://app.netlify.com/sites/playful-alpaca-ff74dc/deploys/62506c7038b2d800096dbf24


Gatherling scraper failure

Fetching http://gatherling.com/eventreport.php?event=Penny Dreadful Saturdays 6.11 (cache ok)
POSTing to http://gatherling.com/deckdl.php with {'id': '54808'}
Traceback (most recent call last):
  File "run.py", line 77, in <module>
    run()
  File "run.py", line 32, in run
    task(sys.argv)
  File "run.py", line 70, in task
    s.scrape()
  File "/home/discord/decksite/decksite/scrapers/gatherling.py", line 24, in scrape
    i = tournament(url, name)
  File "/home/discord/decksite/decksite/scrapers/gatherling.py", line 50, in tournament
    return add_decks(dt, competition_id, ranks, s)
  File "/home/discord/decksite/decksite/scrapers/gatherling.py", line 58, in add_decks
    d = tournament_deck(cells, competition_id, dt, ranks)
  File "/home/discord/decksite/decksite/scrapers/gatherling.py", line 120, in tournament_deck
    d['cards'] = decklist.parse(fetcher.internal.post(gatherling_url('deckdl.php'), {'id': gatherling_id}))
  File "/home/discord/decksite/decksite/scrapers/decklist.py", line 41, in parse
    n, name = parse_line(lines.pop(0))
  File "/home/discord/decksite/decksite/scrapers/decklist.py", line 14, in parse_line
    raise InvalidDataException('No number specified with `{line}`'.format(line=line))
shared.pd_exception.InvalidDataException: No number specified with `Sideboard`

I fixed this for now. JSON is nice though.


chore: fix vulnerability in rexml

#61  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eyupatis and the rest of your teammates on  Graphite


fitSelection centered

Bug reports:
Currently fitSelection always fits the selection to the top left of the viewport. It should behave similar to fitToViewer where you are able to pass the preferences as parameters. Right now there is no way to enforce that other than calculating it myself.

Thanks for your suggestion. Probably some lines of code can be copied from fitToViewer function.
I'll include this feature in a future version (anyway any PR is appreciated).

Adjust your 'fitSelection' area equal to viewport's width/height ratio. This may be a workaround.

any update on this ? or is there any workaround that we can do first ?


No @deprecated fields in input objects on UI

Describe the bug
Schema introspection query not showing @deprecated fields.
To Reproduce
Steps to reproduce the behavior:

Load any schema with deprecated input fields
Click on 'Docs'
Find input with deprecated
See no deprecated fields

Expected behavior
@deprecated is on UI as other fields
Screenshots

Desktop (please complete the following information):

OS: Mac OS
Browser: chrome
Platform: Chrome extension
Version: 5.0.3

Additional context
Possible bug here that not passed: inputFields(includeDeprecated: true)
https://github.com/altair-graphql/altair/blob/master/packages/altair-app/src/app/modules/altair/services/gql/oldIntrospectionQuery.ts

As far as the GraphQL specification goes, the inputFields field doesn't expect the includeDeprecation argument, hence Altair doesn't pass it.

The latest specification (2021) also doesn't expect the includeDeprecated argument in the inputFields field. It allows it in fields and enumValues for backward compatibility reasons.

But current working draft allows the deprecation. Will we wait for a new specification release?


Breadcrumbs example

@knowbody a couple of concerns:

not super happy with the static properties, although I needed to set up path as well to make links from breadcrumbs working.
it won't work with any HOC's, so use case is pretty limited. In my custom project, I was using a HOC called @RouterPage(title) that was the top-most HOC assigning these static properties for use with router and with DocumentTitle. Quite verbose, but it was working efficiently.

And generally it feels like styling and breadcrumbs component can be (and should) be extracted to a separate component, but just wanted to check if we are heading in the same direction first ;)
Commits to be squashed into one later.

I really like this)

@grabbou I think we can go forward with this example. I like it! Clean it up and maybe add the README file with the concerns, so it's clear for others.

Hey @grabbou! Thanks for the PR! Would you mind rebasing on current master? The tests should pass now.

@grabbou can you rebase this? If you don't have time I'm happy to help with that, it would be great to have it in our examples.

Yeah i do have time! Sorry, been on Twitter only holidays :) will rebase this evening!

thanks!

Rebased :)

squash commits please @grabbou

Yeah, sorry! Squashed and reworded

omg, you're going to be annoyed with me lol, a few more changes and we can merge. I'll comment on the code

that's all, sorry, should've mention that earlier

Hah, no worries :) This is acceptable as I need to get familiar with your coding style :+1: Will commit & squash in a bit!

thanks, just trying to have each example written in the similar way. and as we did the React 0.14 changes to all of them it will be great to have it everywhere.

@grabbou thanks again for this PR, I merged it and added the changes (https://github.com/rackt/react-router/commit/c7bafe5bb67c8405d8c8401ce498e90c15707702)
P.S. I really like the use of statics for the paths

Ha, thanks! Sorry for the details but I'm still quite sick ;< A
The statics are quite helpful although the only problem is when you have HOCs. Then, preferably, you should have HOC called router to apply these static properties on top of your component hierarchy.


model downloader does not update filenames in architecture for pytorch_state_dict

Hello,
I've noticed that the model downloader fails to create a self-contained .zip file for models in pytorch_state_dict format. I've observed this with impartial-shrimp. While the zip file contains all files necessary to run, the containing rdf.yaml does not point to the downloaded files for the archictecture, and readme for some reason:
rdf.yaml (abbreviated) for "impartial-shrimp":
...
description: Neuron segmentation in EM, trained on the CREMI challenge data.
documentation: https://zenodo.org/api/records/5874742/files/documentation.md/content
format_version: 0.4.5
...
weights:
  pytorch_state_dict:
    architecture: >-
      https://zenodo.org/api/records/5874742/files/unet.py/content:AnisotropicUNet
    architecture_sha256: 7f5b15948e8e2c91f78dcff34fbf30af517073e91ba487f3edb982b948d099b3
    kwargs:
      anisotropic_kernel: false
      final_activation: Sigmoid
      gain: 2
      in_channels: 1
      initial_features: 32
      out_channels: 1
      postprocessing: null
      return_side_outputs: false
      scale_factors:
        - - 1
          - 3
          - 3
        - - 1
          - 3
          - 3
        - - 2
          - 2
          - 2
        - - 2
          - 2
          - 2
        - - 2
          - 2
          - 2
    sha256: 9123de8cd1b9e7d4eaef56cb9d780a4dcbcfdf4b33f85559f6f392eeb06f6920
    source: ./weights.pt

I think the zip file should be self contained - and while it does not contain the markdown for the documentation, it does contain the architecture file and should point to it locally, not to zenodo.

Hi @k-dominik sorry for retaking this but it seems solved now. I downloaded the zip and the yaml file seems self-contained. Thank you for pointing it out!


Refresh should kick off loading indicators

Type of issue

[x ] Bug
[ ] New feature
[ ] Improvement

Description

On Dashboard - the Alarms grid isn't refreshed (or at minimum doesn't show the Loading indicator).
On Devices -
a. controls aren't in the same action bar location - is this purposeful?
b. Clicking refresh doesn't kick off load indicator.
On Rules -
a. controls aren't in the same action bar location - is this purposeful?
b. Clicking refresh doesn't kick off load indicator.
Maintenance -
a. Alarms grid doesn't kick off load indicator.

Yes. Second PR is coming up shortly. Intial PR is merged.


Replace Nett TOML library

Currently we use the Nett library for parsing TOML files. However, it appears that it has been deprecated. The package on NuGet.org hasn't been updated in over 2 years^1 and the GitHub repository has been archived^2.
It looks like the most popular alternative library is Tomlyn^3

Link to the Tomlyn documentation: https://github.com/xoofx/Tomlyn/blob/main/doc/readme.md


chkr1011:master

🤔 This is a ...

[ ] New feature
[ ] Bug fix
[ ] Site / document update
[ ] Component style update
[ ] TypeScript definition update
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge
⚠ Please check all items below before review. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4952ba3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #2   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?       394
  Lines             ?      7478
  Branches          ?      2143
==========================================
  Hits              ?      7478
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4952ba3...a937675. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4952ba3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #2   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?       397
  Lines             ?      7523
  Branches          ?      2107
==========================================
  Hits              ?      7523
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4952ba3...4b376d0. Read the comment docs.


libvmi: 0.14.0-unstable-2024-09-04 -> 0.14.0-unstable-2024-09-18

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libvmi is: C library for virtual machine introspection
meta.homepage for libvmi is: https://libvmi.com/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.0-unstable-2024-09-18 with grep in /nix/store/lix7lxr33g96yvi4xgxn6q4a1ybn3dvk-libvmi-0.14.0-unstable-2024-09-18
found 0.14.0-unstable-2024-09-18 in filename of file in /nix/store/lix7lxr33g96yvi4xgxn6q4a1ybn3dvk-libvmi-0.14.0-unstable-2024-09-18

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

libvmi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lix7lxr33g96yvi4xgxn6q4a1ybn3dvk-libvmi-0.14.0-unstable-2024-09-18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libvmi https://github.com/r-ryantm/nixpkgs/archive/8c22778849823704ed8d9511739548e134a3a1d7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8c22778849823704ed8d9511739548e134a3a1d7#libvmi

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lix7lxr33g96yvi4xgxn6q4a1ybn3dvk-libvmi-0.14.0-unstable-2024-09-18
ls -la /nix/store/lix7lxr33g96yvi4xgxn6q4a1ybn3dvk-libvmi-0.14.0-unstable-2024-09-18/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

libvmi
libvmi.dev
libvmi.lib

Maintainer pings
cc @SigmaSquadron for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Jump Game

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
We need to find the minimum number of jumps to reach the end of the array starting from the first element of the array,
jumps value would be (-1) if we are not able to reach the end of the array
example : array = {2,3,0,1,4,1,1,2,0,3,5}
minimum jumps = 5 {2 to 3, 3 to 4, 4 to 2, 2 to 3, 3 to 5}
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
fixed #3346

@HarshCasper @siddharth25pandey @iamrajiv please review my PR

@ankitaggarwal23 please review my PR

@ankitaggarwal23  can you review it again

@ankitaggarwal23 please review the changes

@ankitaggarwal23  I have removed redundant comments and lines, if I'll remove more lines then it would be difficult to read

@ankitaggarwal23 I have removed two tabs space and made it to one tab space.

Thank you @ankitaggarwal23

@ankitaggarwal23 can you check #3592 also
Thank you


character does not turn at all unless i sprint.

Describe the bug
except for when im sprinting, my character only faces one direction. im using the mystic horizons modpack so theres alot of mods and could be a conflict, but i turned it off in the mod config and i wasnt having the issue anymore. might be conflicting with epic fight? dunno
Steps to reproduce the behavior:
by walking ya, i would send a video but the file is too big.
Expected behavior
my character to turn 🙏
Additional context
very possible it aint this mod but would appreciate any help regarding this problem in the modpack because this mod is dope 🙇

Having the same issue over here


Support Version 2.0.0 changes for /v1/deregister-application

Generate server stub for the version 2.0.0 specification
If the api/openapi.yaml is not updated as per the published version 2.0.0 , then copy the api/openapi.yaml file from the generated stub to the source code
no change required in the method signature

Following tasks needs to be completed to support /v1/deregister-application version 2.0.0 ,

[x] https://github.com/openBackhaul/RegistryOffice/issues/223
[x] https://github.com/openBackhaul/RegistryOffice/issues/293

Closing this issue as all the sub tasks for the service /v1/deregister-application are completed , validated and closed.


Kernel class file and adaptation of instantaneous_rate function

Are the unittests for the kernel class the same as the old one? Was just wondering because I could not see any test file.

test_statistics.py now adapted to the new version of the function instantaneous_rate and test_kernels.py added

Pullrequests for kernels.py and rate_estimation in statistics.py will be separated.


Upgrade regex package versions to >=1.5.5 (security vulnerabilities)

Im not sure if that is the right place but when I run cargo audit on the duckscript repo I get this error:
https://github.com/sagiegurari/duckscript
$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 416 security advisories (from /Users/john/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (124 crate dependencies)
Crate:     regex
Version:   0.1.80
Title:     Regexes with large repetitions on empty sub-expressions take a very long time to parse
Date:      2022-03-08
ID:        RUSTSEC-2022-0013
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0013
Solution:  Upgrade to >=1.5.5
Dependency tree:
regex 0.1.80
└── ftp 3.0.1
    └── duckscriptsdk 0.8.12
        └── duckscript_cli 0.8.12

Crate:     thread_local
Version:   0.2.7
Title:     Data race in `Iter` and `IterMut`
Date:      2022-01-23
ID:        RUSTSEC-2022-0006
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0006
Solution:  Upgrade to >=1.1.4
Dependency tree:
thread_local 0.2.7
└── regex 0.1.80
    └── ftp 3.0.1
        └── duckscriptsdk 0.8.12
            └── duckscript_cli 0.8.12

error: 2 vulnerabilities found!

So I'm not sure if that's the rust-ftp that has an old regex version or duckscript if its duckscript I will move my issue there.

@John15321 thanks for this. actually duckscript doesn't use regex package directly and you are reading the tree wrong (i agree it is confusing).
duckscript_cli is using duckscriptsdk which uses ftp which uses regex 0.1.8
I don't even have regex has one of the direct dependencies of duckscript.


Support induce subgraph in the copy function

Now that we are moving away from using TensorNetwork object, we should still allow copying a network via passing a collection of nodes to a tensornetwork.copy(nodes) function.
Along with this, it would be nice if when we passed a subset of all the nodes that it would create an induced subgraph copy of the given nodes.
By this I mean that if a and b are connected by an edge and we do tensornetwork.copy({a}), then the returned set of nodes should only be a copy of a and the edge that used to connect a and b becomes a dangling edge.

I can work on this.

Great!


Travis Coveralls integration added

Issue #31

Changes Unknown when pulling 6862aaea1186bb39b5e9b14ddb32ee9bcf4d6cda on coverage into ** on master**.

Changes Unknown when pulling 58a95bf8053dff69bea7c7adc67bfbe28555db14 on coverage into ** on master**.

Changes Unknown when pulling 58a95bf8053dff69bea7c7adc67bfbe28555db14 on coverage into ** on master**.


Rename MissingGroupType and UnsupportedGroupType

This PR renames MissingGroupTypeError and UnsupportedGroupTypeError for consistency.

I'd be happy to merge with a backwards compatible assignment of old name = new name, or a bump to 1.7.

This is a breaking change for anyone relying on this, so would need at least a bump to 1.7. But maybe we can make it in a backward compatible way with MissingGroupTypeError = MissingGroupType?

I could make an alias and we deprecate it on the next version

This is a breaking change for anyone relying on this, so would need at least a bump to 1.7. But maybe we can make it in a backward compatible way with MissingGroupTypeError = MissingGroupType?

I could make an alias and we deprecate it on the next version

That works for me.

@ericproulx Looks like CI is having trouble on master beyond rack-edge now, care to take a look?

I’ll take a look :)
On Mon 14 Feb 2022 at 23:34 Daniel Doubrovkine (dB.) <
@.***> wrote:

@ericproulx https://github.com/ericproulx Looks like CI is having
trouble on master beyond rack-edge now, care to take a look?
—
Reply to this email directly, view it on GitHub
https://github.com/ruby-grape/grape/pull/2227#issuecomment-1039640440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAHJI24RI5OWGDKLUFDMRLU3F7OJANCNFSM5LFICWAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Avertissement
 Ce message est destiné uniquement à la personne ou à
l’organisation à laquelle il est adressé et il peut contenir des
informations privilégiées, confidentielles ou non divulgables en vertu de
la loi. Si vous n’êtes pas le destinataire du présent message ni la
personne chargée de remettre le présent message à son destinataire, il vous
est strictement interdit de le divulguer, de le distribuer, de le copier ou
de l’utiliser de quelque façon que ce soit. Si vous avez reçu la présente
communication par erreur, veuillez en aviser l’expéditeur et détruire ou
effacer tous les exemplaires que vous avez reçus.

*Warning
 *This message
is intended only for the use of the individual or entity to which it is
addressed, and may contain information which is privileged, confidential,
proprietary or exempt from disclosure under applicable law. If you are not
the intended recipient or the person responsible for delivering the message
to the intended recipient, you are strictly prohibited from disclosing,
distributing, copying or in any way using this message. If you have
received this communication in error, please notify the sender, and destroy
and delete any copies you may have received.

While testing locally,
https://github.com/ruby-grape/grape/blob/e93d27897fbf5f360fd11064d7b3c4d8094b7c53/lib/grape/validations/types/file.rb#L1-L15
input.nil? is false on rack-edge but true on a rack 2.2.3
A quick fix would be to check input.blank? but I'm not sure it's what we want

A quick fix would be to check input.blank? but I'm not sure it's what we want

So input is an empty string? Weird.


feeshare: only make .proto files

Hi all, this PR is to illustrate the issue highlighted here:
https://github.com/CosmosContracts/juno/actions/runs/3749327042/jobs/6367682252
and here:
https://github.com/CosmosContracts/juno/issues/438
cheers!
-Jacob

Likely from PR https://github.com/CosmosContracts/juno/pull/422, This regen should fix it

lgtm, it will help with hunting the proto issue


Data prep

@dansbecker Here's what I've got so far. I'm a huge fan of trying to make things easy for people to follow along with and reproduce, but will defer to you here. At the very least, the parse_xml.sh in the code/data_setup folder is probably something we'll want.

That Makefile is great.  Nice!

So, what's the best strategy in terms of merging this all in? Should I adjust the Makefile with the changes we discussed, or is it best to let one person handle it all so merge conflicts don't creep in?
Happy to do whatever. The only person I've really collaborated with on a somewhat VC'd repo where we had lots of branches was Cary, so I'll be learning as we go (but promise not to blow anything up).

Yeah.  In general, either of us should feel free to merge anything the
other person has reviewed.  Whoever merges second may get a conflict on
.gitignore which will be easy to resolve.  That should be the only conflict
in the near term.
We won't get a conflict in the makefile, because I'm not going to touch it
until your PR is merged to master, and then I'll create a new branch off
that to update the Makefile.  In general, short but frequent PR's tend to
minimize merge conflicts.
On Mon, Apr 25, 2016 at 5:32 AM, Sean Sall<EMAIL_ADDRESS>wrote:

So, what's the best strategy in terms of merging this all in? Should I
adjust the Makefile with the changes we discussed, or is it best to let
one person handle it all so merge conflicts don't creep in?
Happy to do whatever. The only person I've really collaborated with on a
somewhat VC'd repo where we had lots of branches was Cary, so I'll be
learning as we go (but promise not to blow anything up).
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dansbecker/motion-tracking/pull/2#issuecomment-214275629

Okay, awesome. Merging now. I left the folder structure for data largely the, but just removed the raw_data intermediary, and moved anything that wasn't a direct download into the work folder (with ILSVRC and alov subfolders). If I misunderstood the structure we wanted, feel free to change or let me know and I can.
So, the two csvs that are created from parsing the XML's for training/validation will now end up in work/ILSVRC. Next steps for me after merging your stuff in is to create a similar bash script to parse the videos and grab the frames for which we have bounding boxes.


Set the pod HOME env variable to a writable location

Our code or libraries could try to use ~ or $HOME and expect to be able to
create directories or files here and fail.  Previously, $HOME would default to /, which is
not writable for our user.
This now looks very similar to the heartbeat file location:
irb(main):001:0> pp ContainerOrchestrator.new.send(:default_environment)[1]
{:name=>"HOME", :value=>"/Users/joerafaniello/Code/manageiq/tmp"}
=> {:name=>"HOME", :value=>"/Users/joerafaniello/Code/manageiq/tmp"}

irb(main):002:0> pp ContainerOrchestrator.new.send(:default_environment)[4]
{:name=>"WORKER_HEARTBEAT_FILE",
 :value=>"/Users/joerafaniello/Code/manageiq/tmp/worker.hb"}
=> {:name=>"WORKER_HEARTBEAT_FILE", :value=>"/Users/joerafaniello/Code/manageiq/tmp/worker.hb"}

Note, on pods/appliances, this location is /var/www/miq/vmdb/tmp

Setting WIP until I can verify a build with this in case tmp isn't created by the time we try to use it as a HOME env variable location.

Ok, I had a few issues rebuilding my environment to test a build with this but using this branch, I was able to get $HOME to be /var/www/miq/vmdb/tmp.  All pods orchestrated by the orchestrator will now have a $HOME with a writable location.  If we want it to be a subdirectory here or in /tmp, we'll need to ensure that directory gets created beforehand.
joerafaniello@Joes-MBP-2 manageiq-operator % oc describe pod 1-ui-5968cd8f9f-n47r6 | grep -A 10 Environment
    Environment:
      GUID:                     a660faf5-2364-407e-bb70-dc6f4d0bd263
      HOME:                     /var/www/miq/vmdb/tmp
      MEMCACHED_SERVER:         memcached:11211
      MEMCACHED_SERVICE_NAME:
      WORKER_HEARTBEAT_FILE:    /var/www/miq/vmdb/tmp/worker.hb
      WORKER_HEARTBEAT_METHOD:  file
      ENCRYPTION_KEY:           <set to the key 'encryption-key' in secret 'app-secrets'>  Optional: false
      DATABASE_PORT:            5432
      DATABASE_SSL_MODE:
      DATABASE_HOSTNAME:        <set to the key 'hostname' in secret 'postgresql-secrets'>  Optional: false
      ...

joerafaniello@Joes-MBP-2 manageiq-operator % oc exec 1-ui-5968cd8f9f-n47r6 -- env | grep HOME
HOME=/var/www/miq/vmdb/tmp

@jrafanie Were you looking to backport this to morphy as well?

@jrafanie Were you looking to backport this to morphy as well?

Yes, thanks!

Unfortunately that's not how ansible works in this case.  While we use ansible runner to isolate the runs and each run has its own temp dir, there are cases where the ansible authors hardcoded the $HOME/.ansible dir.

We can set the $HOME env var to be anything we want though so we were thinking when executing ansible-runner we could set $HOME to a Tmpdir that way they're isolated and also will work when running as a non-root user (manageiq user is no-logon and has no homedir)

Oh I see now... yeah, we might be able to do that just for the ansible-runner execution.  I wonder if we can put the HOME directly inside the existing ansible-runner-tmp location.

We can set the $HOME env var to be anything we want though so we were thinking when executing ansible-runner we could set $HOME to a Tmpdir that way they're isolated and also will work when running as a non-root user (manageiq user is no-logon and has no homedir)

So, if I'm understanding this, maybe we can add HOME here:
https://github.com/ManageIQ/manageiq/blob/9b06ebecf45cbf5a25a3a5b0d60e396b392b6ef5/lib/ansible/runner.rb#L308-L312
I think this is the entrypoint that everything goes through.  I could be wrong.
Note, this hash is merged on top of any ENV variables provided by the caller, so if something was trying to set HOME, our change would override it.  Maybe we'd need to treat HOME differently and only set HOME when not specified.


WEB UI

Coverage remained the same at 100.0% when pulling 636ec235bed1e735c9a2ad50462b9ff3c7110877 on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling 636ec235bed1e735c9a2ad50462b9ff3c7110877 on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling ac89f89afe1df5c1cbb6cff83b0afd199db97ec2 on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling ac89f89afe1df5c1cbb6cff83b0afd199db97ec2 on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling eb7de86dacc0c10015cf0e2ecff39520dc8731e2 on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling 83033189bfca96b1113a94c19433ee69047b7e9d on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.

Coverage remained the same at 100.0% when pulling 83033189bfca96b1113a94c19433ee69047b7e9d on develop into 3693495cdf164c9dc72860b728172e493eb9854b on master.


Intermittent crashes while using power toys normally.

Microsoft PowerToys version
"0.62.0"
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Openning the input via Alt+Space and typing somthing makes an error pop up. Sometimes, many many of the same error window pop up continuously until the machine crashes.
Uploading 2022-09-27.txt…
Here is the bug window report :
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19044.0
IntPtr Length: 8
x64: True
Date: 27/09/2022 19:34:19
Exception:
System.InvalidOperationException: Le traitement de Dispatcher a été interrompu, mais les messages continuent à être traités.
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

This is annoying as the only way out of these windows is to close my session, loosing work i done, or wait until it crashes the machine: the new pop-up take focus permanently, which dows not allows to go to task manager to kill powertoys...
✔ Expected Behavior
It should not crash and just work.
❌ Actual Behavior
it crashed as soon as i typed somthing into the run box. This is intermitant and sometimes crashed while sometimes it does not.
Other Software
No response

/dup #20891

You identified this issue as a dup of itself ? @davidegiacometti

Sorry, I have pasted the wrong issue. It's a duplicate https://github.com/microsoft/PowerToys/issues/18166

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


fix(leaflet-zoom-animated): Zoom does not work on android 4.1.2

Is this still an issue? I tested it on Android 4.2.2 and it works fine, not sure about 4.1.2.

I'm closing this due to inactivity. Feel free to reopen it if necessary.


Hatched Bars?

HI,
is it possible to create hatched bars in a bar chart?

As mentioned in the issue template, the issues are not meant to be used for this kind of questions.

Actually, this question is constructive in the sense that the wiki should be clearer about customizing bars. I added a "custom views" section to it.
(Yes, it's possible).


Swap chalk for turbocolor

Hey @frenzzy!
Types of changes

Non-breaking.

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

Summary
This PR swaps chalk for turbocolor.
It will give us a perf boost as turbocolor loads >20x faster and applies styles >18x faster than chalk for the same API (see benchmarks). Node.js support >=v4.

# Load Time
chalk: 15.190ms
turbocolor: 0.777ms

# All Colors
chalk × 8,729 ops/sec
turbocolor × 158,383 ops/sec

# Chained Colors
chalk × 1,838 ops/sec
turbocolor × 39,830 ops/sec

# Nested Colors
chalk × 4,049 ops/sec
turbocolor × 59,833 ops/sec

Cheers!

Cool! Thanks

Thanks, @frenzzy!

Released as v1.1.0 :tada:


[PE-D] Unable to delete person from Group Information Panel

UG suggest that this should be allowed but did not manage to delete person successfully from group information panel.
Steps to reproduce:

create group

create person

add person to group

checkout group information to view groupmates and task

execute delete command

Labels: type.FunctionalityBug severity.Medium
original: Justinhoejj/ped#17

remove the page from ug

Resolved.


Describe collaborations

We should only include public projects that we can link to. This may be a good place to also outline #58

Also:

Keshavarzi lab (movement & datashuttle)
AMF (brainglobe-stitch etc. )

Do

Advanced Research Computing: general BrainGlobe (packaging, benchmarks, ...)
Akrami Lab: BrainGlobe atlas validation and generation
count?

Probs yes to everything

Just the level of detail may vary (e.g. with ARC we have a longstanding collab with multiple people, leading to specific outcomes).

Yes I agree we can count spikeinterface as collaboration, also UNLE when released. None others come to mind at the moment but will keep thinking.


⚠ Bofrost.lu has degraded performance

In 7c0ebe2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2089 ms

Resolved: Bofrost.lu performance has improved in 6b4e9a8 after 26 minutes.


📚 Documentation Enhancement

Issue Overview
Our project documentation is the gateway for newcomers to understand, contribute, and make the most of our projects. To ensure it's informative, user-friendly, and up-to-date, we need your expertise!
What's Needed
We're looking for contributors to help us enhance our project documentation in the following ways:

Content Review: Review the existing documentation for accuracy, clarity, and completeness.

Updating: Identify outdated information and update it to reflect the current state of the project.

Clarity: Simplify complex topics and ensure that even beginners can understand our documentation.

Organization: Suggest improvements in the structure and organization of the documentation.

How You Can Contribute

Fork the Repository: Fork our project repository to work on the documentation enhancements.

Make Your Changes: Make the necessary updates and improvements to the documentation.

Create a Pull Request: Submit a pull request with your changes. Ensure that you follow our Contribution Guidelines for detailed instructions.

Review and Collaboration: We'll review your pull request and collaborate to finalize the documentation enhancements.

Let's Make Learning and Contributing Easier!
By contributing to our documentation, you're helping us create a better experience for everyone in our community. Your input will be invaluable for both newcomers and seasoned contributors.
Thank you for making our project even better! 🙌
Note: If you have any questions or need assistance, feel free to ask in the comments.

Hey @Sammybams!
Can you please assign this issue to me?
I will ensure that I update the documentation in such a manner that it is clear and understandable.

Hey @Sammybams!
Can you please assign this issue to me? I will ensure that I update the documentation in such a manner that it is clear and understandable.

Okay @prakharjadaun. The issue is completely open to everyone so you can work on it. But I'll do that now. Thank you very much.


OpenStackControlPlane controller to watch DNSMasq it owns

Right now the OpenStackControlPlane controller does not watch the DNSMasq resources it owns. If there is an issue with DNSMasq and gets fixed, the controller won't reconcile and update its conditions.
This adds the DNSMasq to the owners watch list of the OpenStackControlPlane controller.

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 	09510fe link 	true 	/test openstack-operator-build-deploy-kuttl
Full PR test history. Your PR dashboard.

Removing debug pod ...
error: unable to upgrade connection: container container-00 not found in pod oko-07-x6fgx-master-1-debug-79np4_openstack-kuttl-tests

/test openstack-operator-build-deploy-kuttl


Support Python 3.5

Upgraded vcrpy to version 1.7.4
Removed the version restriction for mock
Added Python 3.5 to the TravisCI test matrix


max for repeat play only once

Tested in the playground view
The shimmer play only once.
// This is a playground view to make it easy to play around with Flutter Animate.

import 'package:flutter/material.dart';
import 'package:flutter_animate/flutter_animate.dart';

class PlaygroundView extends StatelessWidget {
  PlaygroundView({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    Widget title = const Text(
      'Enter',
      style: TextStyle(
        // fontWeight: FontWeight.w900,
        fontSize: 40,
        color: Color(0xFFFFFFFF),
        height: 1,
        letterSpacing: -1,
      ),
    );

    // here's an interesting little trick, we can nest Animate to have
    // effects that repeat and ones that only run once on the same item:
    title = title
        .animate(onPlay: (controller) => controller.repeat(max: 5))
        .shimmer(duration: 1200.ms, color: const Color(0xFF80DDFF))
        .animate() // this wraps the previous Animate in another Animate
        .fadeIn(duration: 1200.ms, curve: Curves.easeOutQuad)
        .slide();

    return Center(
      child: title,
    );
  }
}

You may want to check the Flutter documentation for max. It doesn't do what I think you're hoping for. Instead take a look at the loop extension Animate adds.


python311Packages.pydantic-yaml-0: 0.11.2 -> 1.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.pydantic-yaml-0 is: A small helper library that adds some YAML capabilities to pydantic
meta.homepage for python311Packages.pydantic-yaml-0 is: https://github.com/NowanIlfideme/pydantic-yaml
meta.changelog for python311Packages.pydantic-yaml-0 is: https://github.com/NowanIlfideme/pydantic-yaml/releases/tag/v1.3.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.0 with grep in /nix/store/mypcll9myg0rg32v54k3vfk9091yf607-python3.11-pydantic_yaml-0-1.3.0
found 1.3.0 in filename of file in /nix/store/mypcll9myg0rg32v54k3vfk9091yf607-python3.11-pydantic_yaml-0-1.3.0

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath

charmcraft
python311Packages.craft-application
python311Packages.craft-application-1
python311Packages.craft-parts
python311Packages.pydantic-yaml-0
python312Packages.craft-application
python312Packages.craft-application-1
python312Packages.craft-parts
python312Packages.pydantic-yaml-0
rockcraft
snapcraft

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mypcll9myg0rg32v54k3vfk9091yf607-python3.11-pydantic_yaml-0-1.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.pydantic-yaml-0 https://github.com/r-ryantm/nixpkgs/archive/a08d8dda3f8cacf356f4aa9e8173563b1ca5e8fa.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a08d8dda3f8cacf356f4aa9e8173563b1ca5e8fa#python311Packages.pydantic-yaml-0

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mypcll9myg0rg32v54k3vfk9091yf607-python3.11-pydantic_yaml-0-1.3.0
ls -la /nix/store/mypcll9myg0rg32v54k3vfk9091yf607-python3.11-pydantic_yaml-0-1.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

18 packages failed to build:

charmcraft
charmcraft.dist
python311Packages.craft-application
python311Packages.craft-application-1
python311Packages.craft-application-1.dist
python311Packages.craft-application.dist
python311Packages.craft-parts
python311Packages.craft-parts.dist
python312Packages.craft-application
python312Packages.craft-application-1
python312Packages.craft-application-1.dist
python312Packages.craft-application.dist
python312Packages.craft-parts
python312Packages.craft-parts.dist
rockcraft
rockcraft.dist
snapcraft
snapcraft.dist

4 packages built:

python311Packages.pydantic-yaml-0
python311Packages.pydantic-yaml-0.dist
python312Packages.pydantic-yaml-0
python312Packages.pydantic-yaml-0.dist

Maintainer pings
cc @jnsgruk for testing.

Hmm, anyone know how to stop these? I thought removing nix-update-script would help?
Perhaps @SuperSandro2000?

Hmm, anyone know how to stop these? I thought removing nix-update-script would help?

It has a fallback updater otherwise the wats majority of packages wouldn't be updated.
There is a magic comment you can write to stop the updates.

That's what I am using for ArchiSteamFarm
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/ArchiSteamFarm/default.nix#L13

Ah excellent, thank you! I've opened https://github.com/NixOS/nixpkgs/pull/306477.


Make OAuth clientId and clientSecret optional

MGDSTRM-7968
Signed-off-by: Michael Edgar<EMAIL_ADDRESS>

@biswassri FYI this impacts the changes you are making to remove the secrets from the ManagedKafka resource.

Yes, with your PR (once this is merged in) it will need to check for the presence of the secret references since the secret value will always be null in the operator.

Right! Makes sense. I'll include that as well.

For the existing CRs, will it remove the configured clientid/secret? or it will only impact the new Kafka request?

This change only allows the clientid/secret to be unspecified in the CR. Existing CRs would need to have them removed in the control plane.

@MikeEdgar thanks


[mm 699] - Reporter should receive DM when someone comments on their issue  Fixes #699

This PR modifies appendCommentNotifications so both Assignee and Reporter will get a notification when someone comments on their issue (previously, only Assignee gets the notification)
ticket here
Fixes #699

Codecov Report

Merging #810 (f72da22) into master (f9b5a21) will decrease coverage by 0.20%.
The diff coverage is 2.94%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   34.97%   34.76%   -0.21%
==========================================
  Files          52       52
  Lines        5945     5977      +32
==========================================
- Hits         2079     2078       -1
- Misses       3657     3690      +33
  Partials      209      209

Impacted Files
Coverage Δ

server/webhook.go
32.22% <ø> (ø)

server/webhook_worker.go
0.00% <0.00%> (ø)

server/webhook_parser.go
85.32% <100.00%> (+0.05%)
:arrow_up:

server/subscribe.go
67.10% <0.00%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b5a21...f72da22. Read the comment docs.

@sibasankarnayak Please link the ticket this PR fixes uses the Fixes #X syntax as described in https://docs.google.com/document/d/1JpTkyjwsdbacV83NXgo8gRA_Zvcjk4DkCRFoiGBUVBs/edit.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

@levb  @mickmister  can you review this

can you review this

Yes, I will review the PR soon. Thanks for pinging us.
@sibasankarnayak FYI, by quoting the full comment above you've pinged other people that don't need to be pinged in this case. Especially when the quoted comment gets several levels deep, this can be an issue. Just be careful who you are pinging in your comments, and make sure it's only the people you want to communicate with. Thanks again for the ping to review :+1:

@aaronrothschild Do you think the reporter should get a notification for when the issue is updated, or only when someone comments on the issue?

@aaronrothschild Do you think the reporter should get a notification for when the issue is updated, or only when someone comments on the issue?

Personally, I like getting notified when it is updated, but 0/5

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @BenLloydPearson @aspleenic

Something I forgot to verify here, we need a separate notification setting for this feature. There is some discussion on this here #705 (comment)

@sibasankarnayak Since we're introducing this feature, we need a way for the user to toggle it. 1/5 it's within the scope of introducing the feature to add the separate setting. If not, the other PR should be merged first and this one can use that functionality.

Something I forgot to verify here, we need a separate notification setting for this feature. There is some discussion on this here #705 (comment)

@sibasankarnayak Since we're introducing this feature, we need a way for the user to toggle it. 1/5 it's within the scope of introducing the feature to add the separate setting. If not, the other PR should be merged first and this one can use that functionality.

@mickmister just to be clear we want a command to be added which can be on/off by user to control this feature ?

@mickmister just to be clear we want a command to be added which can be on/off by user to control this feature ?

Yes there is a similar command /jira settings notifications. We will split this into three commands
/jira settings notifications assignee
/jira settings notifications mention
/jira settings notifications reporter
Some discussion on the data model behind this at this comment https://github.com/mattermost/mattermost-plugin-jira/pull/705#discussion_r631444153

@mickmister just to be clear we want a command to be added which can be on/off by user to control this feature ?

Yes there is a similar command /jira settings notifications. We will split this into three commands /jira settings notifications assignee /jira settings notifications mention /jira settings notifications reporter
Some discussion on the data model behind this at this comment #705 (comment)

@mickmister when we refer to mention is it implies for creating the DM post for plugin

@sibasankarnayak When we refer to "mention notifications", we mean the Jira user was mentioned in a comment on Jira. In this case, we should send a bot DM to that connected user in Mattermost, if they have their notification settings set to receive "mention" notifications.

@hanzei @mickmister can you review the code , have added the notification for assignee ,  mention,reporter too

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @aspleenic

@mickmister can you share your feedback on this .
picked up the incomplete PR from @jupriano  for issue #507 once this will be merge as notification setting for reporter and assignee is been added in this PR

@sibasankarnayak Heads up that there are conflicts to resolve

@hanzei Done , resolved conflict

@levb @mickmister Gentle reminder to review this PR

Also, I am not sure of the user value of having 3 separate settings, seems like a single setting is sufficient... @aaronrothschild

Also, I am not sure of the user value of having 3 separate settings, seems like a single setting is sufficient

@levb Some of the notification types are noisier than others. Maybe a given user doesn't want watcher notifications because that's too many notifications. Note that the watcher notifications is introduced in another open PR, but the principle is the same. cc @aaronrothschild

Some of the notification types are noisier than others. Maybe a given user doesn't want watcher
notifications because that's too many notifications. Note that the watcher notifications is introduced in another open PR, but the principle is the same.
So if we factor in the new reporter notifications and watcher notifications, we have a total of 4 reasons why someone might get a notification:

Mentioned
Assignee
Reporter
Watcher

The question is if these should all be configured with one user setting /jira settings notifications, or if they should all be configured, i.e.

/jira settings notifications mention true
/jira settings notifications assignee true
/jira settings notifications reporter true
/jira settings notifications watcher true

@mickmister made the changes as discussed over call , Please review and share the feedback.

Since there is a lot of overlap with this PR and https://github.com/mattermost/mattermost-plugin-jira/pull/840, I'm holding off on reviewing the current changes in this PR.
@sibasankarnayak What would you like to do here? Are you wanting to merge one PR before the other, or close one of the PRs?

Since there is a lot of overlap with this PR and #840, I'm holding off on reviewing the current changes in this PR.
@sibasankarnayak What would you like to do here? Are you wanting to merge one PR before the other, or close one of the PRs?

I would like to be merge this PR and then can continue on the https://github.com/mattermost/mattermost-plugin-jira/pull/840  .
Can we do that ?

Since there is a lot of overlap with this PR and #840, I'm holding off on reviewing the current changes in this PR.
@sibasankarnayak What would you like to do here? Are you wanting to merge one PR before the other, or close one of the PRs?

I would like to be merge this PR and then can continue on the #840 . Can we do that ?

@mickmister share you comments on this.

I would like to be merge this PR and then can continue on the #840 . Can we do that ?

@sibasankarnayak Sure. Many of my comments on #840 apply to this PR as well. Would you like me to create the same comments on this PR?

@sibasankarnayak So you're implying we should close this PR in favor of the other PR? I'm fine with that if this is what you're suggesting

@sibasankarnayak So you're implying we should close this PR in favor of the other PR? I'm fine with that if this is what you're suggesting

@mickmister yes i mean that ,
will be closing this and continue working on the other PR to close reporter  and watching notification


Dragged elements are lost if component is updated during dragging

If metal-drag-drop is used inside a metal component, and this component is rendered while dragging an element, the generated cloned node is lost, as metal rerenders the component's content.
Here you have a use case of what I am trying to do:

We have a list of sortable elements, any element can be dragged, and then it is appended to the end of the list
When an element starts being dragged, it is faded, so the user sees which is the source
A "preview" of the position where the element is going to be dropped is shown (just a few dashes at the end of the list)
On drop, the preview is destroyed and the element is moved to the end of the list

Code for the use case: https://github.com/p2kmgcl/metal-drag-drop-request

This should be working now with https://github.com/metal/metal-drag-drop/pull/13 and will be released in 3.0.0


Add Cloudflare integration

🚀 Deployed on https://64261da915d6fd1d968a778b--cozy-fox-0defec.netlify.app