Accelerate creating cfncluster

Is there a way to accelerate creating cfncluster? I am new at that. I just use default cfn cluster template.

If you are not doing anything custom (e.g. a long post_install script) a plain cluster creation should take around 10 minutes.
We know there is room for improvement on the cluster creation time but at the moment there is not so much you can do to accelerate.

Would switching off library download and making them part of a custom AMI help?
I am not sure which step takes so long in the process?

Cluster creation time has been reduced since AWS ParallelCluster 2.4.1, see changelog https://github.com/aws/aws-parallelcluster/releases/tag/v2.4.1


Change the SetOutputIdentity algorithm for BulkInsertOrUpdate

Currently we rely on SQL Server behaviour in merge and custom ordering, which is very fragile in some scenarios (for example duplicate values in database).
We should use artificial column to map original index to database generated identity.

fixed by #86


Add Examples and Tutorials in Docs

Examples and Tutorials

Example Usage
Data Model Creation
Advanced Usage Scenarios

#34 Done ✔


[1.11.2] HCLumber and Harvestcraft Maple Wood

When HCLumber is enabled it only registers on Plank per Log.
If Harvestcraft is installed it add a Maple Wood which gives Spruce Planks.
This means that Spruce Logs can not be used to get Spruce Planks.
The same it true of Jungle Wood.

This is a bug with pam's, even with HCLumber disabled it doesn't drop a log.


Safe area for devices with home indicator

*Fix of issue #95

Hey @IshankDev thanks for contributing!
I've made a small mistake while force-pushing some edits I made on top of your fork, so I created a new PR, but preserving your commit and changes, with only my modifications on top of it (the PR is #105).
So no worries, your contribution will be added directly to this repo, it was just a small mistake that I've made.
Thanks for your help, you can check the #105 out

Thanks for that @matuella.
And one more thing What else I need to do to put my small pictures in 😂


Split update and patch

This fixes one piece of #80, next up is implementing error/null handling for fetchModel and loadModel

I've cherry picked commit with actual change


add brew-services extension

Description
Adds an extension to manage brew services.

[x] view brew services
[x] start, stop, restart, and run a brew service
[x] show in finder/copy plist file path
[x] show when a brew service doesn't run successfully
[x] automatically detects brew installation location (can choose a custom location in preferences)
[ ] can't run services that require sudo
[ ] doesn't have a good icon yet
[ ] is a bit slow (due to brew services list being slow)

Type of change

New extension

Screencast
https://user-images.githubusercontent.com/72744903/137605006-c87de13e-46d8-4c71-a44d-11c75a63c9cb.mp4
Checklist

[x] I read the documentation about publishing

Just realized I added the files to the wrong directory. Remaking the PR.


Allow instrumentation to be suppressed when making outbound requests

A potential solution to #41 that doesn't add any additional hard dependencies.

Thanks for checking it out, @loomis 👍
The wrapper sink approach would struggle because the requests to suppress happen asynchronously, on PeriodicBatchingSink's background thread. There could definitely be more elegant ways to solve the problem, though.
Perhaps we are best waiting to see what other kinds of integration points/extension points become interesting post-1.0, and then consider this as potentially being part of a broader interface? I'm happy leaving this open in draft or closing it for now, whichever makes life easiest 😄

@nblumhardt Would agree with waiting to implement this post-1.0. Don't have any issue with leaving the PR open.

Any progress on this one? I'm currently migrating from a Serilog.Sink that writes directly to a Observability backend and instead targeting otelcollector. It would have been a much smoother transition if i could just switch to this sink (keep enrichers and so on),
but it's not possible until suppression of tracing for outbund requests.

Hi @adameasten; I've just updated this branch with changes from dev; the NUPKG build is at:
https://ci.appveyor.com/project/serilog/serilog-sinks-opentelemetry/builds/47467903/artifacts
(You'll need to download it and add a local folder as a package source in order to reference it in your project.)
It'd be great to get some feedback on how this works for you - we're still in the "information gathering" phase and trying to figure out how best to enable this :-)

@nblumhardt Great, thank you!
I'll try it out and give you some feedback :)

Awesome, thanks @adameasten 👍  - let me know if you need any help getting it configured.

Do you have any thoughts around exporting Activities too. Not only enriching logs with Trace/Span id, but also send the Trace objects with the sink to a OTEL collector? Should i implement my own OpenTelemtry.BaseExporter and inject a Serliog.Logger that is configured to send the data to the right endpoint? ex:
var log = new LoggerConfiguration().WriteTo.OpenTelemetry();
var traceExporter = new TraceExporter(log);

public class TraceExporter : OpenTelemtry.BaseExporter<System.Diagnostics.Activity>
{
        private readonly Serilog.ILogger _logger;
        public TraceExporter(Serilog.ILogger logger)
        {
                _logger = logger;
        }

        public override ExportResult Export(in Batch<System.Diagnostics.Activity> batch)
        {
               //loop over batch of activities and create LogEventProperties
               _logger.LogEvent(........, properties);
        }
}

Don't know if it makes sense @nblumhardt, but i want to be able to see both logs and use a front end to build graphs based on Activities (Traces)

@loomis Aha okay, i see! Read through the comments and it makes sense!
I do think it is i a good idea to integrate handling of the different Signals (Traces, metrics, logs) in the future, so you can rely on the same framework for smooth implementation. I'll probably stick to OpenTelemtry SDK for now, but i'll keep en eye on the development.
I'm working quite alot with distributed tracing in my current role, so i'm happy to help if needed! Thanks for the input.

Closing until I have a chance to rethink :-)


Add 'Linker Script' language

Add Linker Script language.  This is the command language for GNU Link and other Unix linkers.
300k .ld files
400k .lds files
"many" ld.script files (is there a way to get exact matches with filename:?)
I didn't find any significant other use of .ld or .lds.

Historical note from [http://airs.com/ian/](Ian Lance Taylor):

I believe [the GNU linker script language] is somewhat loosely based on the script language used by the SVR3 linker, plus significant additions from the MRI linker scripting language.

:+1: thanks @larsbrinkhoff!

Ping @arfon @bkeepers

Looks good. Thanks @larsbrinkhoff


[New game]: Doraemon Run

🎮 Game Request
Game logic and basic description
Game logic and basic description
Players have to jump on the dorayakis to get score
Touching the mouses will decrese the totatl score by 1
Start the game by clicking the start button and play again by pessein f5 key
Point down the features
Game points
left,right,up key
fully responsive design
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Maana-Ajmera !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @Maana-Ajmera ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


feat: disable firewalld and flush Iptable rules

Allows the user to disable firewalld as a last step in system prep. The default will be to keep firewalld running.
JIRA: https://jira.d2iq.com/browse/D2IQ-82085

This is the jira that describes the issues

Can you please rebase to pickup the Ubuntu fix.

This might not come from firewalld - though I'd make sure it's disabled anyway. It might also come from iptables.service. It might also be valuable to stop and disable that service.
For EL distros (RHEL, CentOS, SUSE), the service looks like:
[Unit]
Description=IPv4 firewall with iptables
AssertPathExists=/etc/sysconfig/iptables
Before=network-pre.target
Wants=network-pre.target

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/libexec/iptables/iptables.init start
ExecReload=/usr/libexec/iptables/iptables.init reload
ExecStop=/usr/libexec/iptables/iptables.init stop
Environment=BOOTUP=serial
Environment=CONSOLETYPE=serial
StandardOutput=syslog
StandardError=syslog

[Install]
WantedBy=multi-user.target

Stopping this service will run /usr/libexec/iptables/iptables.init stop, clearing the tables.
This is the centos 8 default iptables (/etc/sysconfig/iptables):
# sample configuration for iptables service
# you can edit this manually or use system-config-firewall
# please do not ask us to add additional ports/services to this default configuration
*filter
:INPUT ACCEPT [0:0]
:FORWARD ACCEPT [0:0]
:OUTPUT ACCEPT [0:0]
-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT
-A INPUT -p icmp -j ACCEPT
-A INPUT -i lo -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 22 -j ACCEPT
-A INPUT -j REJECT --reject-with icmp-host-prohibited
-A FORWARD -j REJECT --reject-with icmp-host-prohibited
COMMIT

which restricts access to everything but ssh.
Ubuntu doesn't seem to have such a default, afaict.


Proposal to Archive - Great MFA distribution SIG

Based on "Application for archiving of a project" in the Project Lifecycle Process because the
process has not been defined for SIGs or WGs.
Reasons for archiving:
This SIG appears to have successfully completed its mission. There are limited tokens remaining (which were donated) and the effort to distribute was resource intensive. The repo has been archived and there is no group meeting. The slack has had no communication in the last 90 days.
Great MFA distribution SIG
Please review and inform the project maintainers, OpenSSF end user community and wider community of this archiving proposal. The proposal must remain open for at least 2 weeks of discussion after the maintainers are informed and a vote must be finalized with 2/3 approval from the TAC or parent WG to complete the archive process.

I am fine with this cleanup

This issue was discussed today in the BEST WG.
WG agrees that MFA is archived. We accomplished a lot, 2FA is now more common, we’re moving on.


Site support request: pluzz.francetv.fr became www.france.tv missing generic urls

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.05.09. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.05.09

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.05.09
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

You are using an outdated version of youtube-dl. Read this FAQ entry if you have troubles updating.

Following pluzz.francetv.fr changed its domain name to www.france.tv issue #13034 has fixed the direct download links issues but the generic ones for categories are not working.
Previously it was possible to use http://pluzz.francetv.fr/videos/jt20h.html to get the last edition but now that this have changed to https://www.france.tv/france-2/journal-20h00/ this is not working
youtube-dl -v https://www.france.tv/france-2/journal-20h00/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.france.tv/france-2/journal-20h00/']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.05.09
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: ffmpeg N-82889-g54931fd, ffprobe N-82889-g54931fd
[debug] Proxy map: {}
[generic] journal-20h00: Requesting header
WARNING: Falling back on generic information extractor.
[generic] journal-20h00: Downloading webpage
[generic] journal-20h00: Extracting information
ERROR: Unsupported URL: https://www.france.tv/france-2/journal-20h00/
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpup5muf90\build\youtube_dl\YoutubeDL.py", line 760, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpup5muf90\build\youtube_dl\extractor\common.py", line 433, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpup5muf90\build\youtube_dl\extractor\generic.py", line 2834, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.france.tv/france-2/journal-20h00/

No This is using the last update

see #13070

There is no embedded video on https://www.france.tv/france-2/journal-20h00/ thus nothing is downloaded.


KAFKA-4178: Windows in Rate Calculation

ReplicationQuotas included a new Rate class which changed the way the window is calculated. @junrao asked that we look to consolidate this. On balance I believe there is a good case for both, so this PR pulls out two policies for calculating the window, and attempts to explain what they are and why we might need them.
They are:
Elapsed: Set the window to the difference between the oldest and newest measurement time. Handle NaN. (Replication Quotas use this)
Fixed: Fix the window to the full duration (10s by default). (Client Quotas use this)
Replication Quotas uses the Elapsed policy rather than Fixed, as fixed provides an underestimate during the first window. Underestimates are best avoided in rebalancing tasks, as they tend to create an immediate load spike when replication starts. So it's preferable to overestimate the rate, and hence throttle immediately in response to a rate change. This approach is also a bit easier to test.
I may not fully understand the background for Client Quotas moving to this Fixed approach (Fixed is my nomenclature by the way - but the change was made in response to KAFKA-2443 & KAFKA-2567). There was was an issue with returning NaN, but should really be tangential (it is handled in both policies). However it seems sensible to slowly throttle on a client's connection down to the desired rate when you initialise or change quotas, so there is logic to it.
So I think there is a requirement for both types of rate, and hence I've included both in this PR. Elapsed suits throttled replication, where the general use case is to initiate some rebalance and immediately apply a throttle. Fixed suits client quotas where we want to gently throttle a client down to the desired rate over a period of seconds.

Previous failure was ConsumerBounceTest which I don't think is related.


Why two term relative mass and mass

In the following class we found two term :
class InertiaParametersTemplate:
    def __init__(
        self,
        mass: Callable = None,
        center_of_mass: Callable = None,
        inertia: Callable = None,
    ):
        """
        This is a pre-constructor for the InertiaParametersReal class. It allows to create a
        generic model by marker names

        Parameters
        ----------
        mass
            The callback function that returns the mass of the segment with respect to the full body
        center_of_mass
            The callback function that returns the position of the center of mass
            from the segment coordinate system on the main axis
        inertia
            The callback function that returns the inertia xx, yy and zz parameters of the segment
        """
        self.relative_mass = mass
        self.center_of_mass = center_of_mass
        self.inertia = inertia

==> why having the name of the attribute being relative_mass when the name of the parameter is mass ?

This is something that I have never used 😇 It's for somedays but I'm not even sure what it does anymore 🥲

Maybe having the same name would be more coherent so :)


add feature to remux signed rtmp stream

Bug: if main stream (RTMP) protected by signed key and user validating the sign argument on "prePlay" event then user won't able to remux because remux don't pass config args to trans session
Fix: pass sign argument if available so user able to remux signed rtmp stream

@mattcwebster this for trans muxer
its different for fission i will edit it too to fix it


Deprecate instanceid service

As per Firebase Documentation, FirebaseInstanceIdService has been deprecated. This patch uses the recommended onTokenRefresh method instead.

The CI build failed due to what looks like an issue with the environment (failed fetch of dependencies). PR contains no deps change. Please advice on how to proceed, as I don't have much experience with Travis-CI. Thanks.

I want to know the process of this change.
Is there any plan that when will this change be included and become a new version?


rafthttp: plumb local peer URLs through transport

I looked at the other ServeHTTP methods and they don't have any peer id checks, so it's not clear if to me that the extra header checking is necessary in those parts. /cc @xiang90

@heyitsanthony They do not check. But the problem is that after they forwarded the message to raft, the output message will not be able to send to the other side if we do not have the url for that peer.

ok all fixed ptal /cc @xiang90

all fixed ptal /cc @xiang90

LGTM if tests pass.

LGTM


Unable to compile custom cpp applications using realsense header files.

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ D435i }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Linux built from petalinux 2020.2 tool

Kernel Version (Linux Only)
(5.4.0)

Platform
Kria KV260 FPGA

SDK Version
{ legacy / 2.51.1 }

Language
{C++ }

Segment
{others }

Issue Description
<Describe your issue / question / feature request / etc..>
I am trying to use librealsense header file rs.hpp in my custom c++ application for some image processing tasks. However when i compile a simple rs-hello-realsense.cpp file that already comes with the sdk examples i get an error -
collect2: error: ld returned 1 exit status

Hi @VishnuRamTK  The RealSense SDK example programs are built in a way that may cause librealsense libraries to be missing if those programs' code is copied into a user-created project.
The starter project at the link below has the same script as rs-hello-realsense but a more complex CMakeLists.txt file that enables the librealsense libraries to be found by a standalone project.
https://github.com/zivsha/librealsense/tree/getting_started_example/examples/getting-started

Hi @MartyG-RealSense ,
I tried the example in the above github page and it works. However i want to use the RGB camera stream from Intel 435i and feed it to program in https://www.hackster.io/code_files/574226/download. This code is obtained following the link below -
https://www.hackster.io/dsp2/easy-machine-learning-on-ubuntu-with-the-xilinx-kria-kv260-c77ed1
I included the rs.hpp header in to the same program however i could not compile it. The way the above program is compiled adds to the complication. The snippet of how the program is compiled below(also taken from the above link) -
g++ -std=c++17 -O3 main.cpp -o person_detection
-I/usr/include/opencv4
-lpthread
-lopencv_core
-lopencv_video
-lopencv_videoio
-lopencv_imgproc
-lopencv_imgcodecs
-lopencv_highgui
-lvitis_ai_library-refinedet
I even moved the librealsense2 folder to /usr/include folder where the compiler searches for the libraries and also added a flag -llibrealsense2_rs .However i keep getting ld error. I am quite not sure how to modify the CMakelists.txt to look for all the above libraries and realsense2_Library while compiling.

There was a case where a RealSense user experienced the same set of errors and a RealSense team member provided them with advice for a solution at https://github.com/IntelRealSense/librealsense/issues/5651#issuecomment-576017475

Thanks for the reply @MartyG-RealSense. I could somehow modify the CMakelist.txt file and tried including all the dependent libraries and could compile the code succesfully. Thanks for all the references.
Modifies CMakelist.txt file below for future reference -
cmake_minimum_required(VERSION 3.1.0)
project(Realsensepersondetector)
Save the command line compile commands in the build output
set(CMAKE_EXPORT_COMPILE_COMMANDS 1)
set(ADD_INCLUDE_DIRS "/usr/include/opencv2")
Make project require C++17
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++17" COMPILER_SUPPORTS_CXX17)
CHECK_CXX_COMPILER_FLAG("-std=c++0x" COMPILER_SUPPORTS_CXX0X)
if(COMPILER_SUPPORTS_CXX17)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c17")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17")
elseif(COMPILER_SUPPORTS_CXX0X)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
endif()
Simple non robust way to find the librealsense library
if(WIN32)
if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "8")
set(LIBRARY_DIR "C:\Program Files (x86)\Intel RealSense SDK 2.0\lib\x64")          # TODO: Update this variable to correct path - folder where realsense2.lib is found
set(DLL_DIR "C:\Program Files (x86)\Intel RealSense SDK 2.0\bin\x64")              # TODO: Update this variable to correct path - folder where realsense2.dll is found
else()
set(LIBRARY_DIR "C:\Program Files (x86)\Intel RealSense SDK 2.0\lib\x86")          # TODO: Update this variable to correct path - folder where realsense2.lib is found
set(DLL_DIR "C:\Program Files (x86)\Intel RealSense SDK 2.0\bin\x86")              # TODO: Update this variable to correct path - folder where realsense2.dll is found
endif()
set(PROJECT_BINARY_OUTPUT_PATH "${PROJECT_BINARY_DIR}/$(Configuration)")                # TODO: Update this variable to correct path - folder to which your project will compile
set(ADDITIONAL_INCLUDE_DIRS "C:\Program Files (x86)\Intel RealSense SDK 2.0\include")   # TODO: Update this variable to correct path - folder where librealsense2 folder is found
endif()
find_library(REALSENSE2_FOUND realsense2 HINTS ${LIBRARY_DIR} REQUIRED)
if(NOT REALSENSE2_FOUND)
SET(REALSENSE2_FOUND "realsense2")
message(WARN "Failed to find_library(realsense2)")
endif()
getting-started
add_executable(rs_person_detection main.cpp)
include_directories(rs_person_detection ${ADD_INCLUDE_DIRS} ${ADDITIONAL_INCLUDE_DIRS})
target_link_libraries(rs_person_detection ${REALSENSE2_FOUND} pthread opencv_core opencv_video opencv_videoio opencv_imgproc opencv_imgcodecs opencv_highgui vitis_ai_library-refinedet)
set_target_properties (rs_person_detection PROPERTIES FOLDER Examples)
Post Build script to copy realsense2.dll
if(WIN32)
message(STATUS "Adding Post build script to copy realsense2.dll to project's binary folder")
message(STATUS "Will try to copy from ${DLL_DIR} to ${PROJECT_BINARY_OUTPUT_PATH}")
add_custom_command(TARGET rs_person_detection POST_BUILD        # Adds a post-build event to rs-getting-started
COMMAND ${CMAKE_COMMAND} -E copy_if_different              # which executes "cmake - E copy_if_different..."
"${DLL_DIR}/realsense2.dll"                            # <--this is in-file
${PROJECT_BINARY_OUTPUT_PATH})                 # <--this is out-file path
endif()
install(
TARGETS
rs_person_detection

RUNTIME DESTINATION
${CMAKE_INSTALL_PREFIX}/bin

)

It's great to hear that you achieved a solution, @VishnuRamTK - thanks so much for sharing your solution with the RealSense community!


Type hint for expression of alias type shows "underlying" type

TypeScript: 1.9.0-dev.20160429 (although shows in playground too)

Playground repro
type A = string;
let x: A;

Expected behavior:
Type of x shown via hover should be A
Actual behavior:
Type of x shown via hover is string
Impact
I'd noticed this before but assumed it was something we were doing wrong... I think it's fair to assume the above expected behaviour?
The reason this is significant is that we use type aliases for friendlier, shorter types.
But then in our editor if we're inspecting the type of an expression via the type hint (hover) then we see the massive, underlying type (which isn't at all helpful)

The thing is I considered, at some point, to suggest that interface types would show the internal structure of the type as an additional piece of information, something like:
interface Example {
  a: number;
}

let x: Example;

And hovering x would show something like
let x: Example ({
  a: number;
})

So what I eventually did to work around this was to change many types that were defined as interface to use type aliases instead, just to get a more detailed information when hovered!
So I feel there are many cases where having this extra information is very useful. So instead of removing detail, the hint could just include the name of the alias, though I personally feel it would be that useful in most cases, perhaps just use interface instead?

@myitcv This is the expected behavior. Internally, A is simply a symbol that aliases the string type, and by the time we resolve the type there is no path back to A so to speak. A type can only have one associated name, and for string that name is, well, string.
There are cases where we could do what you suggest without too much overhead. For example, when declaring a type alias for an anonymous object type (i.e. type Foo = {...}) we could possibly associate the name with the anonymous type because it isn't otherwise shared. However, we couldn't easily do the same for union and intersection types because they are hashed and shared based on their structure (i.e. their constituent types), and that sharing is performance critical. So, without deeper changes to the compiler, all we could is sometimes show you the type alias name.

@ahejlsberg

This is the expected behavior

... given the current implementation.
But would you agree that ideally the alias should be used as the type hint?
Another area where the underlying type "leaks" out is in compiler errors (can't think why I didn't bring this up in the original post). This is arguably more "serious" than the type hint because it happens far more regularly. Again, there is no correspondence between one's code and the compiler error:
type A = string;
let x: A;

x = 5;  // type 'number' is not assignable to type 'string'. But x is of type A!!

If you have multiple levels of aliasing (as we do) then the problem is further exacerbated: you literally have to remember the "reverse" of the alias in order to decipher the compiler error. Again this is further exacerbated if you have generic type aliases (as we do).
Clearly I'm not keen on sacrificing compiler speed, but debugging these sorts of errors is, at times, a nightmare so anything that can be done to improve this situation would be greatly appreciated.

@mhegazy I'm assuming this has been closed because you consider this behaviour "By Design"?

Yes. Type aliases are just aliases and not named types. Changing that, while possible, would have perf impact on the compiler and will require some rearchitecting.

@mhegazy thanks.

Type aliases are just aliases and not named types

Clearly the example above is a simple one; we have situations like the following:
type primitive = string | number | boolean;

// Using ImmutableJS
type ImmutableKey = Immutable.IndexedSeq<primitive>;

let x: ImmutableKey;

x = 5; // Type 'number' is not assignable to type 'IndexedSeq<string | number | boolean>

How would you advise the developer handle compiler error messages like the above?
The issue I have with labelling this "By Design" is that it implies a design decision was made that intended for the developer to be left in this situation - given the problems it creates, I think that's unlikely.

"Design limitation" would be a better label.


DivOverlay methods are not documented

DivOverlay manual section documents options, events, but not methods.

Some of methods are mentioned in Popup section
Some documented wrong: https://github.com/Leaflet/Leaflet/blob/d5201acee0234ff4239cc8cbfa59c687286a2692/src/layer/DivOverlay.js#L104
Tooltip section does not mention those methods, but from code it's obvious that L.Tooltip has the same methods

I suppose part of Popup methods documentation should be moved to DivOverlay, and then Popup and Tooltip linked to DivOverlay methods description.

I would love to work on this. Would that be okay?


AnimatedSwitch component

For Route transitions

This can now proceed! It was previously waiting on the Anime.js integration. That has been taken care of: https://github.com/helpscout/blue/releases/tag/v0.0.64

Got things working… but still lots of questions to be answered.
Potential substitution:
https://github.com/maisano/react-router-transition

Demo of experiments so far:

Also consider https://github.com/react-tools/react-move

Archiving this one! The Motion library should help with this, when we need it:
https://github.com/helpscout/motion


GEODE-6013: Use expected initial image requester's rvv information

Re-submitting after fixing NPE from previous checkin.
Made changes to use the expected initial image requester's rvv
information instead of the image provider's local rvv while
determining full or delta GII.
There was logical error where it was using provider's local
exception(rvv) instead of using requester's local exception(rvv).
This could result in performing Delta GII instead of Full GII.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[Yes ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[Yes ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[Yes] Is your initial contribution a single, squashed commit?

[Yes] Does gradlew build run cleanly?

[Yes ] Have you written or updated unit tests to verify your changes?

[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

For other reviewers, here is a diff between Anil's last PR and this one:
118c118
< index 7b03d48bfc8..ce10dfdc1b3 100644

index 7b03d48bfc8..b53b5029b8d 100644
121c121
< @@ -977,34 +977,35 @@ public boolean isNewerThanOrCanFillExceptionsFor(RegionVersionVector other) {

@@ -977,7 +977,8 @@ public boolean isNewerThanOrCanFillExceptionsFor(RegionVersionVector other) {
131,134c131
<        RegionVersionHolder holder = new RegionVersionHolder(gcVersion.longValue());
< -      return !holder.isNewerThanOrCanFillExceptionsFor(otherHolder);
< +      return otherHolder.dominates(holder);
<      }

@@ -987,24 +988,24 @@ private boolean isGCVersionDominatedByHolder(Long gcVersion, RegionVersionHolder
184c181
< index deb7d4eaa3d..a018aaff6fa 100644

index deb7d4eaa3d..ed671a6f09c 100644
187c184
< @@ -661,6 +661,145 @@ public void doesNotHangIfOtherThreadChangedVersion() throws Exception {

@@ -661,6 +661,167 @@ public void doesNotHangIfOtherThreadChangedVersion() throws Exception {
235a233,254

public void isRvvGcDominatedByRequesterRvvReturnsFalseIfProviderRvvIsNotPresent()

 throws Exception {

final String local = getIPLiteral();
InternalDistributedMember provider = new InternalDistributedMember(local, 101);
InternalDistributedMember requester = new InternalDistributedMember(local, 102);

RegionVersionVector providerRvv = new VMRegionVersionVector(provider, null,

   1, null, 1, false, null);

ConcurrentHashMap<InternalDistributedMember, RegionVersionHolder> memberToRegionVersionHolder =

   new ConcurrentHashMap<>();

RegionVersionHolder regionVersionHolder = new RegionVersionHolder(provider);
regionVersionHolder.setVersion(0);
// memberToRegionVersionHolder.put(provider, regionVersionHolder);
RegionVersionVector requesterRvv =

   new VMRegionVersionVector(requester, memberToRegionVersionHolder,

       0, null, 0, false, null);

assertThat(providerRvv.isRVVGCDominatedBy(requesterRvv)).isFalse();
}

@Test


Adopt Semantic Versioning

Adopt proper Semantic Versioning for full release.
Should we be in 0.1.x or 1.0.x?
http://semver.org/

we use semver, we are in 2.0.0-SNAPSHOT, first release would be 2.0.0


mailserver_web container connection error to MariaDB server

☺ Please check the troubleshooting page before opening a new issue. ☺
https://github.com/jeboehm/docker-mailserver/wiki/Troubleshooting
Describe the bug
mailserver_web log file.
[critical] Error thrown while running command "doctrine:migrations:migrate -n". Message: "An exception occurred in the driver: SQLSTATE[HY000] [1130] Host '<IP_ADDRESS>' is not allowed to connect to this MariaDB server"
In ExceptionConverter.php line 119:,
To Reproduce
every time it starts
Expected behavior
The above error was taken from the log file of the mailserver_web container
Docker environment (please complete the following information):
docker info
Client:
Context:    default
Debug Mode: false
Server:
Containers: 19
Running: 17
Paused: 0
Stopped: 2
Images: 37
Server Version: 20.10.12
Storage Driver: btrfs
Build Version: Btrfs v5.15.1
Library Version: 102
Logging Driver: journald
Cgroup Driver: systemd
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
Default Runtime: runc
Init Binary: /usr/libexec/docker/docker-init
containerd version:
runc version: babb8ce-dirty
init version:
Security Options:
seccomp
Profile: default
selinux
cgroupns
Kernel Version: 5.16.18-200.fc35.x86_64
Operating System: Fedora Linux 35 (Workstation Edition)
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 5.746GiB
Name: fedora
ID: DYUW:D33Q:2JEF:STGO:4QTF:LN7F:OK7Y:44LF:VZPX:M7YK:YBN4:ZRAM
Docker Root Dir: /var/lib/docker
Debug Mode: false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: true
docker-compose version
docker-compose version 1.29.2, build unknown
docker-py version: 5.0.2
CPython version: 3.10.4
OpenSSL version: OpenSSL 1.1.1n  FIPS 15 Mar 2022

Hello
I believe that this might be the issue, with the Database.
2022-05-11 12:01:10 6 [Warning] Aborted connection 6 to db: 'unconnected' user: 'unauthenticated' host: '<IP_ADDRESS>' (This connection closed normally without authentication)

Please check your database permissions, especially the permitted hosts.


Problem: I am lazy to type github username/password

... or to remember lazy ssh url
Solution: add ssh@gh to the list of default abbreviations, which expands
to ssh url for github. cookiecutter ssh@gh:foo/bar no longer asks for
username or password.

Current coverage is 99.58%

Merging #551 into master will not affect coverage as of 425ea11

@@            master    #551   diff @@
======================================
  Files           12      12
  Stmts          482     482
  Branches         0       0
  Methods          0       0
======================================
  Hit            480     480
  Partial          0       0
  Missed           2       2

Review entire Coverage Diff as of 425ea11

Uncovered Suggestions

+0.42% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

Hi @vyskocilm, thank you for submitting a PR! :bow:
Do you know about the user config feature?
If we decide to add a new builtin abbreviation, I kindly ask you to amend the commit message.

:bell:


Instructions No Longer Valid - Edit in Advanced Mode

Details under section Specify value in a flow utilize the Edit in Advanced Mode which is no longer available.  The instructions need to be updated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7db8ceb-5afc-512e-fb5b-b6554730aa5e
Version Independent ID: 7a64a2a5-30a1-b997-468d-d2c15a0314c0
Content: Personalize a survey
Content Source: cv-docs/personalize-survey.md
Service: dynamics-365-customervoice
GitHub Login: @sbmjais
Microsoft Alias: shjais

Thanks for the feedback. We are able to follow the steps mentioned in the document. Please share the steps that you are seeing.

Thanks for contacting us. As we haven’t heard back from you, I am closing this issue. If you need further help, please reopen the issue or open a new issue.


Phonegap app stuck on loading page

My phonegap mobile app was working normally until recently that it is just stuck in the loading screen. I tried to clear the cache, app data. uninstall and reinstall and nothing worked. I use an android 10 motorola phone.

Solved it by clicking the privacy link and turning on and off the share usage data button repeatedly
closes #597


Fatal error: dlfcn.h.

Hello there. It's me again. I am trying to compile your library on AFR using IDF V3.3 but it fails when compiling. I've been able to handle two sensors already on AFR, and want to use your gps library as well.
Could you be kind enough to help me out on this too, please?. Thanks in advance.
C:\FreeRTOS>cmake -DVENDOR=espressif -DBOARD=esp32_devkitc -DCOMPILER=xtensa-esp32 -GNinja -S . -B demos/ota/build
-- The C compiler identification is GNU 5.2.0
-- The CXX compiler identification is GNU 5.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Espressif/ESP-IDF-Tools/tools/bin/xtensa-esp32-elf-gcc.exe
-- Found Git: C:/git/cmd/git.exe (found version "2.31.0.windows.1")
-- Checking Python dependencies...
Python requirements from C:/FreeRTOS/vendors/espressif/esp-idf\requirements.txt are satisfied.

-- IDF_VER: v3.3-163-g601a03e
fatal: not a git repository (or any of the parent directories): .git
-- Project is not inside a git repository,                         will not use 'git describe' to determine PROJECT_VER.
-- Project version: 1
-- Adding linker script C:/FreeRTOS/demos/ota/build/esp-idf/esp32/esp32_out.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.rom.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.peripherals.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.rom.libgcc.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.rom.spiram_incompatible_fns.ld
-- Component libraries:
=========================Resolving dependencies==========================
                          All modules available

====================Configuration for FreeRTOS====================
  Version:                 202002.00
  Git version:             Unknown

Target microcontroller:
  vendor:                  Espressif
  board:                   ESP32-DevKitC
  description:             Development board produced by Espressif that comes in two
                           variants either with ESP-WROOM-32 or ESP32-WROVER module
  family:                  ESP32
  data ram size:           520KB
  program memory size:     4MB

Host platform:
  OS:                      Windows-6.1.7601
  Toolchain:               xtensa-esp32
  Toolchain path:          C:/Espressif/ESP-IDF-Tools/tools
  CMake generator:         Ninja

FreeRTOS modules:
  Modules to build:        ble, ble_hal, ble_wifi_provisioning, common, crypto,
                           dev_mode_key_provisioning, freertos_plus_tcp, https, kernel,
                           mqtt, ota, pkcs11, pkcs11_implementation, platform,
                           secure_sockets, serializer, tls, wifi
  Enabled by user:         ble, ble_hal, ble_wifi_provisioning, https, mqtt, ota, pkcs11,
                           pkcs11_implementation, platform, secure_sockets, wifi
  Enabled by dependency:   common, crypto, demo_base, dev_mode_key_provisioning,
                           freertos, freertos_plus_tcp, kernel, ota_http, ota_mqtt,
                           pkcs11_mbedtls, secure_sockets_freertos_plus_tcp, serializer,
                           tls, utils
  3rdparty dependencies:   http_parser, jsmn, mbedtls, pkcs11, tinycbor
  Available demos:         demo_ble, demo_ble_numeric_comparison, demo_https, demo_mqtt,
                           demo_ota, demo_tcp, demo_wifi_provisioning
  Available tests:
=========================================================================

-- Configuring done
-- Generating done
-- Build files have been written to: C:/FreeRTOS/demos/ota/build

C:\FreeRTOS>cmake --build demos/ota/build
[0/2] Re-checking globbed directories...
[172/799] Building C object CMakeFiles/afr_ble.dir/libraries/c_sdk/standard/ble/src/services/device_information/iot_ble_device_information.c.obj
../../../libraries/c_sdk/standard/ble/src/services/device_information/iot_ble_device_information.c: In function '_deviceInfoMTUCharCallback':
../../../libraries/c_sdk/standard/ble/src/services/device_information/iot_ble_device_information.c:386:27: warning: unused variable 'resp' [-Wunused-v
ariable]
     IotBleEventResponse_t resp;
                           ^
../../../libraries/c_sdk/standard/ble/src/services/device_information/iot_ble_device_information.c:385:27: warning: unused variable 'attrData' [-Wunus
ed-variable]
     IotBleAttributeData_t attrData = { 0 };
                           ^
[174/799] Building C object CMakeFiles/afr_ble.dir/libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c.obj
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c: In function '_ControlCharCallback':
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:523:13: warning: unused variable 'value' [-Wunused-variable]
     uint8_t value;
             ^
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c: In function '_clientCharCfgDescrCallback':
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:784:14: warning: unused variable 'CCFGValue' [-Wunused-variable]
     uint16_t CCFGValue;
              ^
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c: In function '_connectionCallback':
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:831:35: warning: unused variable 'pService' [-Wunused-variable]
     IotBleDataTransferService_t * pService;
                                   ^
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c: In function 'IotBleDataTransfer_Init':
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:950:35: warning: unused variable 'pService' [-Wunused-variable]
     IotBleDataTransferService_t * pService = NULL;
                                   ^
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:949:17: warning: unused variable 'callbacksRegistered' [-Wunused-v
ariable]
     static bool callbacksRegistered = false;
                 ^
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c: In function 'IotBleDataTransfer_Send':
../../../libraries/c_sdk/standard/ble/src/services/mqtt_ble/iot_ble_data_transfer.c:1116:15: warning: unused variable 'pData' [-Wunused-variable]
     uint8_t * pData;
               ^
[189/799] Building C object CMakeFiles/afr_ota.dir/libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c.obj
In file included from ../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:40:0:
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'prvSetImageStateWithReason':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:517:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvSetImageStateWithReason" );
     ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'prvStartHandler':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:721:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvStartHandler" );
     ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'prvRequestJobHandler':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:768:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvRequestJobHandler" );
     ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'prvCloseFileHandler':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:1077:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvCloseFileHandler" );
     ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'prvAgentShutdownCleanup':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:2280:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvAgentShutdownCleanup" );
     ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c: In function 'OTA_AgentInit':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/aws_iot_ota_agent.c:2463:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "OTA_AgentInit" );
     ^
[197/799] Building C object CMakeFiles/afr_ota.dir/libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c.obj
In file included from ../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:38:0:
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c: In function 'prvSendCallbackEvent':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:370:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvSendCallbackEvent" );
     ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c: In function 'prvJobPublishCallback':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:421:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvJobPublishCallback" );
     ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c: In function 'prvDataPublishCallback':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:437:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvDataPublishCallback" );
     ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c: In function 'prvDecodeFileBlock_Mqtt':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:850:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvDecodeFileBlock_Mqtt" );
     ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c: In function 'prvCleanup_Mqtt':
../../../libraries/freertos_plus/aws/ota/include/aws_iot_ota_agent.h:56:65: warning: unused variable 'OTA_METHOD_NAME' [-Wunused-variable]
     #define DEFINE_OTA_METHOD_NAME( name )    static const char OTA_METHOD_NAME[] = name;
                                                                 ^
../../../libraries/freertos_plus/aws/ota/src/mqtt/aws_iot_ota_mqtt.c:886:5: note: in expansion of macro 'DEFINE_OTA_METHOD_NAME'
     DEFINE_OTA_METHOD_NAME( "prvCleanup_Mqtt" );
     ^
[209/799] Building C object CMakeFiles/afr_common.dir/libraries/c_sdk/standard/common/iot_init.c.obj
In file included from ../../../libraries/c_sdk/standard/common/include/iot_atomic.h:37:0,
                 from ../../../libraries/c_sdk/standard/common/iot_init.c:41:
../../../freertos_kernel/include/atomic.h:107:34: warning: 'Atomic_CompareAndSwap_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_CompareAndSwap_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:143:32: warning: 'Atomic_SwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE void * Atomic_SwapPointers_p32( void * volatile * ppvDestination,
                                ^
../../../freertos_kernel/include/atomic.h:175:34: warning: 'Atomic_CompareAndSwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_CompareAndSwapPointers_p32( void * volatile * ppvDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:208:34: warning: 'Atomic_Add_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Add_u32( uint32_t volatile * pulAddend,
                                  ^
../../../freertos_kernel/include/atomic.h:236:34: warning: 'Atomic_Subtract_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Subtract_u32( uint32_t volatile * pulAddend,
                                  ^
../../../freertos_kernel/include/atomic.h:262:34: warning: 'Atomic_Increment_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Increment_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:287:34: warning: 'Atomic_Decrement_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Decrement_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:314:34: warning: 'Atomic_OR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_OR_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:341:34: warning: 'Atomic_AND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_AND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:368:34: warning: 'Atomic_NAND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_NAND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:395:34: warning: 'Atomic_XOR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_XOR_u32( uint32_t volatile * pulDestination,
                                  ^
[216/799] Building C object CMakeFiles/afr_common.dir/libraries/c_sdk/standard/common/iot_device_metrics.c.obj
In file included from ../../../libraries/c_sdk/standard/common/include/iot_atomic.h:37:0,
                 from ../../../libraries/c_sdk/standard/common/iot_device_metrics.c:40:
../../../freertos_kernel/include/atomic.h:143:32: warning: 'Atomic_SwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE void * Atomic_SwapPointers_p32( void * volatile * ppvDestination,
                                ^
../../../freertos_kernel/include/atomic.h:175:34: warning: 'Atomic_CompareAndSwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_CompareAndSwapPointers_p32( void * volatile * ppvDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:208:34: warning: 'Atomic_Add_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Add_u32( uint32_t volatile * pulAddend,
                                  ^
../../../freertos_kernel/include/atomic.h:236:34: warning: 'Atomic_Subtract_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Subtract_u32( uint32_t volatile * pulAddend,
                                  ^
../../../freertos_kernel/include/atomic.h:262:34: warning: 'Atomic_Increment_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Increment_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:287:34: warning: 'Atomic_Decrement_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Decrement_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:314:34: warning: 'Atomic_OR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_OR_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:341:34: warning: 'Atomic_AND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_AND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:368:34: warning: 'Atomic_NAND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_NAND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:395:34: warning: 'Atomic_XOR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_XOR_u32( uint32_t volatile * pulDestination,
                                  ^
[217/799] Building C object CMakeFiles/afr_https.dir/libraries/c_sdk/standard/https/src/iot_https_utils.c.obj
In file included from ../../../libraries/c_sdk/standard/https/src/iot_https_utils.c:37:0:
../../../libraries/c_sdk/standard/https/src/private/iot_https_internal.h:490:21: warning: '_pHttpsMethodStrings' defined but not used [-Wunused-variab
le]
 static const char * _pHttpsMethodStrings[] = {
                     ^
[328/799] Building C object CMakeFiles/afr_mqtt.dir/libraries/c_sdk/standard/mqtt/src/iot_mqtt_serialize.c.obj
In file included from ../../../libraries/c_sdk/standard/common/include/iot_atomic.h:37:0,
                 from ../../../libraries/c_sdk/standard/mqtt/src/iot_mqtt_serialize.c:47:
../../../freertos_kernel/include/atomic.h:107:34: warning: 'Atomic_CompareAndSwap_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_CompareAndSwap_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:143:32: warning: 'Atomic_SwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE void * Atomic_SwapPointers_p32( void * volatile * ppvDestination,
                                ^
../../../freertos_kernel/include/atomic.h:175:34: warning: 'Atomic_CompareAndSwapPointers_p32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_CompareAndSwapPointers_p32( void * volatile * ppvDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:236:34: warning: 'Atomic_Subtract_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Subtract_u32( uint32_t volatile * pulAddend,
                                  ^
../../../freertos_kernel/include/atomic.h:262:34: warning: 'Atomic_Increment_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Increment_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:287:34: warning: 'Atomic_Decrement_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_Decrement_u32( uint32_t volatile * pulAddend )
                                  ^
../../../freertos_kernel/include/atomic.h:314:34: warning: 'Atomic_OR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_OR_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:341:34: warning: 'Atomic_AND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_AND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:368:34: warning: 'Atomic_NAND_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_NAND_u32( uint32_t volatile * pulDestination,
                                  ^
../../../freertos_kernel/include/atomic.h:395:34: warning: 'Atomic_XOR_u32' defined but not used [-Wunused-function]
 static portFORCE_INLINE uint32_t Atomic_XOR_u32( uint32_t volatile * pulDestination,
                                  ^
[392/799] Performing configure step for 'bootloader'
-- Found Git: C:/git/cmd/git.exe (found version "2.31.0.windows.1")
-- IDF_TARGET not set, using default target: esp32
-- Building for target esp32
-- The C compiler identification is GNU 5.2.0
-- The CXX compiler identification is GNU 5.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Espressif/ESP-IDF-Tools/tools/bin/xtensa-esp32-elf-gcc.exe
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Espressif/ESP-IDF-Tools/tools/bin/xtensa-esp32-elf-gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Espressif/ESP-IDF-Tools/tools/bin/xtensa-esp32-elf-g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Component names: soc esp32 log bootloader spi_flash micro-ecc efuse bootloader_support main esptool_py partition_table
-- Component paths: C:/FreeRTOS/vendors/espressif/esp-idf/components/soc;C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32;C:/FreeRTOS/vendors/es
pressif/esp-idf/components/log;C:/FreeRTOS/vendors/espressif/esp-idf/components/bootloader;C:/FreeRTOS/vendors/espressif/esp-idf/components/spi_flash;
C:/FreeRTOS/vendors/espressif/esp-idf/components/micro-ecc;C:/FreeRTOS/vendors/espressif/esp-idf/components/efuse;C:/FreeRTOS/vendors/espressif/esp-id
f/components/bootloader_support;C:/FreeRTOS/vendors/espressif/esp-idf/components/bootloader/subproject/main;C:/FreeRTOS/vendors/espressif/esp-idf/comp
onents/esptool_py;C:/FreeRTOS/vendors/espressif/esp-idf/components/partition_table
-- IDF_VER: v3.3-163-g601a03e
fatal: not a git repository (or any of the parent directories): .git
-- Component libraries:
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/bootloader/subproject/main/esp32.bootloader.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/bootloader/subproject/main/esp32.bootloader.rom.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.rom.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.rom.spiram_incompatible_fns.ld
-- Adding linker script C:/FreeRTOS/vendors/espressif/esp-idf/components/esp32/ld/esp32.peripherals.ld
-- Configuring done
-- Generating done
-- Build files have been written to: C:/FreeRTOS/demos/ota/build/bootloader
[434/799] Performing build step for 'bootloader'
[1/55] Generating dummy_main_src.c
[2/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/gpio_periph.c.obj
[3/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/cpu_util.c.obj
[4/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_clk.c.obj
[5/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_clk_init.c.obj
[6/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_init.c.obj
[7/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_periph.c.obj
[8/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_sleep.c.obj
[9/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_pm.c.obj
[10/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_time.c.obj
[11/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/rtc_wdt.c.obj
[12/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/sdio_slave_periph.c.obj
[13/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/sdmmc_periph.c.obj
[14/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/soc_memory_layout.c.obj
[15/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/esp32/spi_periph.c.obj
[16/55] Building C object esp-idf/soc/CMakeFiles/idf_component_soc.dir/src/memory_layout_utils.c.obj
[17/55] Building C object esp-idf/log/CMakeFiles/idf_component_log.dir/log.c.obj
[18/55] Building C object esp-idf/spi_flash/CMakeFiles/idf_component_spi_flash.dir/spi_flash_rom_patch.c.obj
[19/55] Linking C static library esp-idf\log\liblog.a
[20/55] Linking C static library esp-idf\soc\libsoc.a
[21/55] Generating idf_component_log.sections_info
[22/55] Linking C static library esp-idf\spi_flash\libspi_flash.a
[23/55] Generating idf_component_soc.sections_info
[24/55] Generating idf_component_spi_flash.sections_info
[25/55] Building C object esp-idf/efuse/CMakeFiles/idf_component_efuse.dir/esp32/esp_efuse_table.c.obj
[26/55] Building C object esp-idf/efuse/CMakeFiles/idf_component_efuse.dir/src/esp_efuse_api.c.obj
[27/55] Building C object esp-idf/efuse/CMakeFiles/idf_component_efuse.dir/src/esp_efuse_fields.c.obj
[28/55] Building C object esp-idf/efuse/CMakeFiles/idf_component_efuse.dir/src/esp_efuse_utility.c.obj
[29/55] Linking C static library esp-idf\efuse\libefuse.a
[30/55] Building C object esp-idf/micro-ecc/CMakeFiles/idf_component_micro-ecc.dir/micro-ecc/uECC.c.obj
[31/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_clock.c.obj
[32/55] Generating idf_component_efuse.sections_info
[33/55] Linking C static library esp-idf\micro-ecc\libmicro-ecc.a
[34/55] Generating idf_component_micro-ecc.sections_info
[35/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_flash.c.obj
[36/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_common.c.obj
[37/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_random.c.obj
[38/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_flash_config.c.obj
[39/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_sha.c.obj
[40/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/flash_encrypt.c.obj
[41/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/esp_image_format.c.obj
[42/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_utility.c.obj
[43/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/flash_partitions.c.obj
[44/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/flash_qio_mode.c.obj
[45/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/secure_boot.c.obj
[46/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/secure_boot_signatures.c.obj
[47/55] Building C object esp-idf/main/CMakeFiles/idf_component_main.dir/bootloader_start.c.obj
[48/55] Building C object esp-idf/bootloader_support/CMakeFiles/idf_component_bootloader_support.dir/src/bootloader_init.c.obj
[49/55] Linking C static library esp-idf\bootloader_support\libbootloader_support.a
[50/55] Linking C static library esp-idf\main\libmain.a
[51/55] Generating idf_component_bootloader_support.sections_info
[52/55] Generating idf_component_main.sections_info
[53/55] Building C object CMakeFiles/bootloader.elf.dir/dummy_main_src.c.obj
[54/55] Linking C executable bootloader.elf
[55/55] Generating bootloader.bin
esptool.py v2.8-dev
[579/799] Building C object esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser.c.obj
FAILED: esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser.c.obj
C:\Espressif\ESP-IDF-Tools\tools\bin\xtensa-esp32-elf-gcc.exe -DESP_PLATFORM -DGCC_NOT_5_2_0=0 -DHAVE_CONFIG_H -DIDF_VER=\"v3.3-163-g601a03e\" -I../..
/../vendors/espressif/boards/esp32/components/gps/include -Iconfig -I../../../vendors/espressif/esp-idf/components/esp32/include -I../../../vendors/es
pressif/esp-idf/components/driver/include -I../../../vendors/espressif/esp-idf/components/esp_ringbuf/include -I../../../vendors/espressif/boards/esp3
2/components/freertos_tcpip/tcpip_adapter/include -I../../../libraries/freertos_plus/standard/freertos_plus_tcp/include -I../../../libraries/freertos_
plus/standard/freertos_plus_tcp/source/portable/Compiler/GCC -I../../../vendors/espressif/esp-idf/components/esp_event/include -I../../../vendors/espr
essif/esp-idf/components/log/include -I../../../vendors/espressif/esp-idf/components/efuse/include -I../../../vendors/espressif/esp-idf/components/efu
se/esp32/include -I../../../vendors/espressif/esp-idf/components/newlib/platform_include -I../../../vendors/espressif/esp-idf/components/newlib/includ
e -I../../../vendors/espressif/esp-idf/components/vfs/include -I../../../vendors/espressif/boards/esp32/components/freertos/include -I../../../freerto
s_kernel/include -I../../../freertos_kernel/portable/ThirdParty/GCC/Xtensa_ESP32/include -I../../../vendors/espressif/boards/esp32/aws_demos/config_fi
les -I../../../vendors/espressif/esp-idf/components/heap/include -I../../../vendors/espressif/esp-idf/components/soc/esp32/include -I../../../vendors/
espressif/esp-idf/components/soc/include -mlongcalls -mlongcalls -Og -ffunction-sections -fdata-sections -fstrict-volatile-bitfields -nostdlib -Wall -
Werror=all -Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-error=unused-variable -Wno-error=deprecated-declarations -Wextra -Wno-un
used-parameter -Wno-sign-compare -ggdb -std=gnu99 -Wno-old-style-declaration -MD -MT esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser.c.obj -MF
 esp-idf\gps\CMakeFiles\idf_component_gps.dir\src\parser.c.obj.d -o esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser.c.obj -c ../../../vendors/
espressif/boards/esp32/components/gps/src/parser.c
../../../vendors/espressif/boards/esp32/components/gps/src/parser.c:3:19: fatal error: dlfcn.h: No such file or directory
compilation terminated.
[580/799] Building C object esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser_static.c.obj
FAILED: esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser_static.c.obj
C:\Espressif\ESP-IDF-Tools\tools\bin\xtensa-esp32-elf-gcc.exe -DESP_PLATFORM -DGCC_NOT_5_2_0=0 -DHAVE_CONFIG_H -DIDF_VER=\"v3.3-163-g601a03e\" -I../..
/../vendors/espressif/boards/esp32/components/gps/include -Iconfig -I../../../vendors/espressif/esp-idf/components/esp32/include -I../../../vendors/es
pressif/esp-idf/components/driver/include -I../../../vendors/espressif/esp-idf/components/esp_ringbuf/include -I../../../vendors/espressif/boards/esp3
2/components/freertos_tcpip/tcpip_adapter/include -I../../../libraries/freertos_plus/standard/freertos_plus_tcp/include -I../../../libraries/freertos_
plus/standard/freertos_plus_tcp/source/portable/Compiler/GCC -I../../../vendors/espressif/esp-idf/components/esp_event/include -I../../../vendors/espr
essif/esp-idf/components/log/include -I../../../vendors/espressif/esp-idf/components/efuse/include -I../../../vendors/espressif/esp-idf/components/efu
se/esp32/include -I../../../vendors/espressif/esp-idf/components/newlib/platform_include -I../../../vendors/espressif/esp-idf/components/newlib/includ
e -I../../../vendors/espressif/esp-idf/components/vfs/include -I../../../vendors/espressif/boards/esp32/components/freertos/include -I../../../freerto
s_kernel/include -I../../../freertos_kernel/portable/ThirdParty/GCC/Xtensa_ESP32/include -I../../../vendors/espressif/boards/esp32/aws_demos/config_fi
les -I../../../vendors/espressif/esp-idf/components/heap/include -I../../../vendors/espressif/esp-idf/components/soc/esp32/include -I../../../vendors/
espressif/esp-idf/components/soc/include -mlongcalls -mlongcalls -Og -ffunction-sections -fdata-sections -fstrict-volatile-bitfields -nostdlib -Wall -
Werror=all -Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-error=unused-variable -Wno-error=deprecated-declarations -Wextra -Wno-un
used-parameter -Wno-sign-compare -ggdb -std=gnu99 -Wno-old-style-declaration -MD -MT esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser_static.c.
obj -MF esp-idf\gps\CMakeFiles\idf_component_gps.dir\src\parser_static.c.obj.d -o esp-idf/gps/CMakeFiles/idf_component_gps.dir/src/parser_static.c.obj
 -c ../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c
../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c:33:30: error: 'PARSER_COUNT' undeclared here (not in a function)
 nmea_parser_module_s parsers[PARSER_COUNT];
                              ^
../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c: In function 'nmea_load_parsers':
../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c:46:24: warning: unused variable 'parser' [-Wunused-variable]
  nmea_parser_module_s *parser;
                        ^
../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c:45:6: warning: unused variable 'i' [-Wunused-variable]
  int i = 0;
      ^
../../../vendors/espressif/boards/esp32/components/gps/src/parser_static.c:59:1: error: control reaches end of non-void function [-Werror=return-type]

 }
 ^
cc1.exe: some warnings being treated as errors
[581/799] Building C object esp-idf/nimble/CMakeFiles/idf_component_nimble.dir/nimble/nimble/host/util/src/addr.c.obj
ninja: build stopped: subcommand failed.

C:\FreeRTOS>

vendors/espressif/boards/esp32/components/gps/src/parser_static.c

I'm sorry, how did parser_static.c end up in the src directory directly under the component directory? Which CMakeLists.txt file are you using, the one in this repository, or the one in the upstream libnmea project? If you were using this project, the directory structure should have been components//libnmea/src/parser_static.c.

@igrr Hello and thanks a lot for your support. That's very kind from you. Please let me explain very detaily why parser_static.c end up in the src directory
Basically the way I found to incorporate sensors to AFR and make them fully functional is as shown here, I tried the same with your library but it did not work:
https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/tree/master/vendors/espressif/boards/esp32/components
The sensors are dht, bmp180 and their dependencies i2cdev , esp_idf_lib_helpers. Each folder has its own include, src and CMakelists.txt file.
I add these sensors as here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/commit/61f6cbd3623d38d34492f30604dcebe745f6c880
In order to use those sensors, I created an extra task sensors_task.c which its header files is here sensor.h and
src here sensors_task.c
I declare the task here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/blob/0e8cdc3568095adc21f15d2148da666a821373d9/demos/CMakeLists.txt#L26
and call it here
https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/blob/0e8cdc3568095adc21f15d2148da666a821373d9/vendors/espressif/boards/esp32/aws_demos/application_code/main.c#L141 all works fine.
So I tried to do the same with your library. I do not use your CMakeLists.txt. Instead I placed all your headers.h (include) file here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/tree/master/vendors/espressif/boards/esp32/components/gps/include
and all the  src (source) here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/tree/master/vendors/espressif/boards/esp32/components/gps/src
The gps has this CMakeLists.txt file https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/blob/master/vendors/espressif/boards/esp32/components/gps/CMakeLists.txt
So would you please tell me what did I did wrong? How would you accomplish this using your very own libnmea-esp32/libnmea/src/parser_static.c ?
Thanks in advance @igrr

So would you please tell me what did I did wrong?

I do not use your CMakeLists.txt. Instead I placed all your headers.h (include) file here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/tree/master/vendors/espressif/boards/esp32/components/gps/include
and all the src (source) here https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/tree/master/vendors/espressif/boards/esp32/components/gps/src

Please see the component CMakeLists.txt file — there is a non-trivial amount of logic in there which you are omitting. By not including this code, the source files are getting compiled without the necessary compilation flags defined, leading to the errors you are seeing. The component CMakeLists.txt file you are using doesn't contain the equivalent logic.
It seems that you are unable to use the component CMakeLists.txt file provided in this repository because it doesn't support ESP-IDF 3.3. The thing is, in ESP-IDF 3.3, different syntax is used in CMakeLists.txt files (register_component instead of idf_component_register). I'll see about making the CMakeLists.txt file in this component compatible with IDF 3.3.
In the meantime you can try to adapt the logic from this component CMakeLists.txt file to yours.

@igrr Thanks for responding. I will try adapting the logic. Thanks a lot again

https://github.com/Yoimer/AFR_ESP32_FreeRTOS_V202002.00/blob/master/vendors/espressif/boards/esp32/components/gps/CMakeLists.txt looks the same as it was before, can you point to your changes and the errors you got?

@igrr Hello. I hope you're doing great. I am retaking this, for AWS FreeRTOS ESP32 ESP-IDF 3.3. Would you be kind enough to guide me on how to use your component CMakeLists.txt file  on ESP-IDF 3.3, please?
I have no experience on CMake. Your library is the most reliable I've tested so far. Thanks in advance.

Hi @Yoimer, IDF v3.3 should be supported now in the main branch.

Hi @Yoimer, IDF v3.3 should be supported now in the main branch.

@igrr Hello. Thanks a lot for taking your time and supporting the v3.3 on this amazing library. I will test it and let you know.


Fixes composer autoloading, uniform code style, fixes a few minor errors spotted during this process

Composer autoloading is sorted
Global headers for files sorted
Minor errors addressed
Uniform code style on all classes.

@andrewvy had a quick look at it. Going to work on documentation tomorrow hopefully this should make it easier for contributors to add to the project.

This is actually really great! Moving to the new folder structure is clean, and the autoloading definitely cleans up quite a bit of files, Thanks so much for your time. :)
(Thought it wasn't working for a second, but realized I needed to refresh with composer dumpautoload)

@andrewvy I also moved phpunit to require-dev as it isn't needed during actual runtime.


Change ReadWrite to a type alias (see #2)

Shouldn't cause any important breaking changes, and close my nitpicky issue I created.

Thanks a lot!

Published as 0.2.2.


HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.

What changes were proposed in this pull request?
Similar to HDDS-3312 we can exclude dependencies coming from hadoop-ozone. (Eg. curator / zookeeper.)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3353
Implementation details
The main idea is to use a hadoop-dependency-server project (similar to HDDS-3312) where we can exclude all the unnecessary dependencies and use this technical project instead of hadoop-common everywhere (server side).
One old class is removed which is not required any more. (It was easier than fixing a dependency problem).
Tests also required a hadoop-dependency-test umbrella project. (Without this one some transitive dependencies of the hadoop-common:test-jar were on a higher level and the scope was upgraded to test from compile).
How was this patch tested?
CI: https://github.com/elek/hadoop-ozone/actions/runs/72677849

find -name "*curator*.jar"

Hi Marton, thank you for taking this on and looking into my suggestion deeper.
I ran a search for the string curator in the code, and found one more thing. I have added a pull request against your fork with the fix, please review and commit it if you agree.
The change to have a centralized dependency for the server and for the tests is a way I really like, and I am +1 on that part of the implementation.
I have done a quick check where we use hadoop-common as a dependency, and how we manage it there, and the followings came up:

mini-chaos-tests, insight, integration-tests, tools, common, container-service, client: are list hadoop-common as a dependency, we may use the new tests dependency here
hadoop-ozone-fs, csi: pom mentions hadoop-common but as an exclusion this is fine
This is on its way as a PR to your branch also, after a quick local build.

On the other hand, I am unsure whether after these changes we need the hadoop-common dependency to be listed in the DependencyManagement section of the main pom.xml, as we use the hadoop.version property in the 3 remaining place in hadoop-dependency-server, in hadoop-dependency-test, and in hadoop-dependency-client and all modules now depends on these pseudo modules. My guess is we need it, but I am not that deeply familiar with dependency resolution to understand this easily so I thought to ask first. ;)

I would like to suggest merging this as it is, and ask @fapifta open a PR against apache/hadoop-ozone to get credit for the addendum.

Good idea, especially because @fapifta's proposals are also very good.
Thanks to review to both of you. I am merging it and let's make an official PR/jira from the addendum for further improvements...

Right, thank you guys, I will create the JIRA and the PR later today.


[release-1.10] Autobuild on tag push

Pull Request Motivation
https://github.com/cert-manager/cert-manager/pull/5940 backported to release-1.10 as discussed.
Also includes a QoL gitignore fix when switching between branches with workspaces on.
NOTE: This PR also implies a change in the build image used for releases of 1.10. We originally used this image and we change it here.
This is intentional. eu.gcr.io/jetstack-build-infra-images/bazelbuild:20220629-ee75d11-4.2.1 has many vulnerabilities including critical severity vulns. Someone attacking the release process using those vulns doesn't seem particularly likely, but it does seem worth updating here. Since make-dind is much more slim than bazelbuild, it seems worth using that to reduce attack surface.
Kind
/kind feature
Release Note
NONE

This will help us to more easily release patch versions of 1.10.
NOTE: changing the build image should have NO effect on the produced artifacts, since every tool used to build the image is vendored in our build process.
/approve
/lgtm


Remove rootfs.ext2 and redundant lib folder

This patch removes generated rootfs.ext2 and redundant lib
folder.
Signed-off-by: Lv Zheng<EMAIL_ADDRESS>

approved


Release 2.8.1 breaks existing configuration/documentation

Version 2.8.0 is able to run (e.g., with no hook config) like described in the README.md:
$ docker run --rm -p 9000:9000 -v --name=webhook \
  almir/webhook:2.8.0 -verbose -hooks=/etc/webhook/hooks.json -hotreload

Output:
[webhook] 2023/06/24 07:58:01 version 2.8.0 starting
[webhook] 2023/06/24 07:58:01 setting up os signal watcher
[webhook] 2023/06/24 07:58:01 attempting to load hooks from /etc/webhook/hooks.json
[webhook] 2023/06/24 07:58:01 couldn't load hooks from file! open /etc/webhook/hooks.json: no such file or directory
[webhook] 2023/06/24 07:58:01 os signal watcher ready
[webhook] 2023/06/24 07:58:01 serving hooks on http://<IP_ADDRESS>:9000/hooks/{id}

Of course, this also works when passing a valid hooks.json file via a Docker volume, e.g., when ran on the CLI or via docker compose.
However, once I change the version to the latest release 2.8.1, the container is unable to start:
$ docker run --rm -p 9000:9000 -v --name=webhook \
  almir/webhook:2.8.1 -verbose -hooks=/etc/webhook/hooks.json -hotreload

Output:
exec /usr/local/bin/webhook: no such file or directory

It seems to me that the binary is missing. Running it with a proper passed hooks.json file does not change this behavior.

Thanks for reporting. This should be working as intended now.

Thanks for reporting. This should be fixed with 6d39f9b.

Thank you for the quick fix.


Min-Max Scaler

Hello. Your project is nice and I'd like to use it for my reproducing work. But when I look at the source code, it seems that the feature extractor does not apply a min-max scaler to the output feature, which was introduced in the AppScanner original paper?

Indeed, we did not implement that in our repository to allow for closer inspection of the actual values.
However, using the sklearn.preprocessing.MinMaxScaler, it is quite straightforward to apply it over the given data:
# Imports
from appscanner.preprocessor import Preprocessor
from appscanner.appscanner   import AppScanner
from sklearn.preprocessing   import MinMaxScaler

# Create preprocessor
preprocessor = Preprocessor()
# Load from files
X_train, y_train = preprocessor.process(
    files  = ['<path_file_1>', ..., '<path_file_n>'], # Path   to your own train pcap files
    labels = ['<label_1>'    , ..., '<label_n>'],     # Labels of your own train pcap files
)

# Load from files
X_test, y_test = preprocessor.process(
    files  = ['<path_file_1>', ..., '<path_file_n>'], # Path   to your own test pcap files
    labels = ['<label_1>'    , ..., '<label_n>'],     # Labels of your own test pcap files
)

# Scale features
scaler = MinMaxScaler()
X_train = scaler.fit_transform(X_train)
X_test  = scaler.transform(X_test)

# Pass through appscanner
scanner = AppScanner(threshold=0.9)

# Fit scanner
scanner.fit(X_train, y_train)
# Predict labels of test data
y_pred = scanner.predict(X_test)

I have just added an /example/example.py script to the repository showing how to do this.


slider does not handle correctly if "vertical" option changes runtime

Steps to reproduce

Setup a horz. slider
Toggle the "vertical" option on-off, even together with broadcasting the "rzSliderForceRender" event

Demo: http://jsfiddle.net/nlac73/qnku3d8y/
Expected behaviour
The slider should be toggling between horizontal-vertical state
Actual behaviour
The slider does not switch back to horizontal state while toggling the option, it remains vertical.

Fix will be released in 7.0.0


Enables the support for SMAP L2 soil moisture retrievals

The SMAP soil moisture plugin in LVT has been extended to support
the L2 flavors of SMAP data. The L2 standard retrievals at 36km
and the enhanced version at 9km are supported.
Resolves #208

An example test case can be found at : /discover/nobackup/svkumar/LISF_testing/208


kafka: upgrade dependencies to 3.5.1

Commit Message: kafka: upgrade dependencies to 3.5.1
Additional Description: cherry-pick of https://github.com/envoyproxy/envoy/pull/28932 for envoy v1.25 (other commits were related to mesh-filter, but don't want to backport a whole feature)
Risk Level: Low
Testing: integration testing with full stack; manual testing with https://github.com/adamkotwasinski/envoy-kafka-tests/pull/9
Docs Changes: version numbers
Release Notes: n/a
Platform Specific Features: n/a

/retest

all right, so actually it was a very easy one - just a single PR had to be backported

/assign @phlax


Add payment cards endpoints to SDK

We need to add the payment cards endpoints to the SDK.
The following endpoints are added by this PR:
GET /cards
GET /cards/{id}
POST /cards
PATCH /cards/{id}
DELETE /cards/{id}

@Gman98ish I've resolved your suggestions - could you approve if you're happy? 👍

You need to fix the tests and merge master first @tylerwoonton

@Gman98ish Sorry about that, fixed now.


Transform new input with composite model

Hi,
I am trying to tranform an input data with a composite model and I have the same issue as in #536, is there any updates on this subject or different way to do so?
Thanks in advance!

No, transform isn't supported for composite models. Sorry.


Safe Dashboard: Gas fee over all networks for added safes

Overview
Part of #3693
As part of the dashboard, we want to create a module that displays network specific gas fees.
Requirements
Since absolute values are so volatile and very different from chain to chain, it's probably best to display a value relative to the 24h average on that chain. E.g. Gnosis Chain  130% – 0,0001 xDai.
TBD

Usame's notes: https://docs.google.com/document/u/1/d/1l6mwuWe19gqPjmzSIwWK3sJDS2Mk9xNLuPGoKlkAYkQ/edit?usp=sharing


Publish workflow for editions

When an edition is ready, its editor signals it to the admin/owner of Pure3D.
The admin owner must have a handy dashboard to review those requests and take decisions.
The decision can be: accept, reject, or feedback plus try again.

The project organiser is the one to publish. Admin/owners can unpublish.


code.visualstudio.com is down.

VS Code Version: N/A
OS Version: N/A

Steps to Reproduce:

Visit https://code.visualstudio.com

Get SSL self-signed error

Look for error message:
Not Found
The requested URL was not found on this server.
Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
Apache/2.4.29 (Ubuntu) Server at code.visualstudio.com Port 443

No I don't think this is correct. Can you show me a screenshot of the error?

Looks to have been corrected.
It was a typical 404 error from Apache server.  Something was wrong for a while so I filed this report.

cc @gregvanl


Incompatible with multigrid since last commit

Notifications do not show correctly when using environments with multigrid like neovide or nvui since the last commit.

Please provide more information as I do not use these tools. Detailed description of an error, screenshots, recordings, steps to reproduce etc

Yes, I understand when someone's not using those toys. Usually it's the also my choice to go as raw as possible. But it really makes a beneficial difference for me in eye strain and development experience. Things like following cursor movement when, for example, switching windows etc. is easier... Just many situations where I don't want to miss something that is smoothly rendered anymore.
To describe the problem: A Notification usually remains invisible since the last commit, independent of what's triggering it.  For the example of the following video, notify gets triggered by font scaling. I'm using a small lua plugin I wrote(size-matters maybe this can serve as a tool for debugging idk). The notifications are just briefly visible when scaling down.
https://user-images.githubusercontent.com/34311583/166590939-f56c1762-8efb-444d-a8a6-cc011f9191cb.mp4
Here is the quick video.You see switching to the current main branch of notify then starting with an app with multigrid enabled. Notifications do not appear when triggered without scaling or scaling up. But when scaling down while triggering a notification, you see that notifications indeed are there, but they seem to live outside the viewport and very briefly. Then starting without multigrid and it's working fine. Then going back to the penultimate commit, and it also works fine with multigrid enabled.
It's hard giving more details as I don't know how to debug this. If you have the time maybe you can do tests or tell me what I can do here to provide you better information.
(I hope I don't confuse anyone with the scaling thing, because this is not a scaling issue. Just when not coincidentally scaling the down simultaneously with a Notification event they remain completely invisible.)

That's perfect thank you, this should be fixed in the latest commit. The cause was using the wrong anchor for the floating value, which didn't appear in regular terminal neovim because it limits the bounds to the screen whereas it seems Neovide allows for moving windows off screen

Perfect, thanks alot!


[Java] Find OpenVINODeveloperPackage optionally

Gently skip OpenVINODeveloperPackage if not found. Actual for OpenVINO 2022.2

@likholat, seems like Java tests are disabled again. testLoadNetworkWrongDevice should fail (fixed by this PR).

Please, have a look at Java tests

@ilya-lavrenov, thanks! Changed to something more stable.


incorrect pkg used when importing pkg with the same name

The proto file imports 2 proto files with the same file name
example
import customer/status/v1.proto
import product/status.proto

the generated validate.go file correctly import both protos
import status "customer/status"
import status1 "product/status"

However the file only uses status pkg and doesn't correctly use the status1 pkg

Closing as duplicate of https://github.com/bufbuild/protoc-gen-validate/issues/787


Interac icon is incorrect

Interac's logo has changed a bit, also it should probably be negative rather than positive by default.
This is what the new logo looks like.
Negative:

Positive:

Here are the SVGs for these.
interac negative logo (should be default)
(alternate host) interac negative logo (should be default)
interac positive logo (should be alt)
(alternate host) interac positive logo (should be alt)

Thanks for the heads up, will be changed in the upcoming release!

Update in v1.2.0 👍


Dialogues fail in Windows

I thought that these dialogues were not yet implemented, from what I see, I was wrong and they fail in windows.
When I give him talk to Willie, or even look at Willie, as well as when the sisters doves appear. At the moment in which the dialogues should appear, the program closes immediately.
The only thing I have seen in the log is this:
[2020-02-20 03:33:42.566] [log] [error] Sorry, an error occurred: This is not an hashtable
Originally posted by @Mac1512 in https://github.com/scemino/engge/issues/101#issuecomment-588582982

OK I found the issue, it comes from the character ● added at the beginning of a dialog line.


Bugfix/parameters decoding

Fixes #224

@samwelkanda I believe this PR is not needed anymore since #225 was merged. Thoughts?

Let me do local tests on those changes and advise @baywet

@baywet @ladycarbonfiber
From my testing
The following tests cases are passing
("https://graph.microsoft.com?%24count=true&query=%24top&created%2din=2022-10-05&q=1%2b2&q2=M%26A&subject%2ename=%7eWelcome&%24empty",
     "https://graph.microsoft.com?$count=true&query=%24top&created-in=2022-10-05&q=1%2b2&q2=M%26A&subject.name=%7eWelcome&$empty"),
    ("http://localhost", "http://localhost"),
    ("https://google.com/?q=1%2b2", "https://google.com/?q=1%2b2"),
    ("https://google.com/?q=M%26A", "https://google.com/?q=M%26A"),
    ("https://google.com/?q=1%2B2", "https://google.com/?q=1%2B2"), # Values are not decoded
     ("https://google.com/?q=M%26A", "https://google.com/?q=M%26A"), # Values are not decoded

The following are failing
("http://localhost?%24select=diplayName&api%2Dversion=2", "http://localhost?$select=diplayName&api-version=2"),
("http://localhost?%24select=diplayName&api%7Eversion=2", "http://localhost?$select=diplayName&api~version=2"),
("http://localhost?%24select=diplayName&api%2Eversion=2", "http://localhost?$select=diplayName&api.version=2"),
("http://localhost:888?%24select=diplayName&api%2Dversion=2", "http://localhost:888?$select=diplayName&api-version=2"),
("https://google.com/?q%2D1=M%26A", "https://google.com/?q-1=M%26A"), # Values are not decoded but params are
("https://google.com/?q%2D1&q=M%26A=M%26A", "https://google.com/?q-1&q=M%26A=M%26A"), # Values are not decoded but params are

%2D, %7E %2E are not decoded to -, '~' and . respectively.
For ("https://google.com/?q%2D1&q=M%26A=M%26A", "https://google.com/?q-1&q=M%26A=M%26A"),
I get the error ValueError: too many values to unpack (expected 2)

Thanks for the detailed analysis @samwelkanda
Would you mind rebasing your PR (dropping the changes in the handler, keeping the tests additions), this way we can work on amending the changes submitted by @ladycarbonfiber ?


Update more tags script

added option for bland colors to make tags less distracting when studying notes

Nice! Thanks for that!


Localization: Turkish

We need a file and some turkish strings to use in the gui.

Implemented with https://github.com/msingr/csvGeom/pull/48


Revive LABS workshop page for 11.6 testing?

And update changelog, milestones, etc., to list all the stuff since... May 2020?

Dang, long time no see 😄 (you are still in our internal group on discord 😉 )
Hmm, I've created TM:PE TEST since we've had to test a lot of things, like complete migration to Harmony which finally fixes issues on Linux #817 although TEST is still marked as unlisted on WS because I didn't want to create too much attention because of not much free time to respond to issues (now is much better)

I'd rather take it private for the time beeing so that users of the current test version don't have to switch again and all others are not confused by its presence. we can revive it when krzy takes a long vacation :)


Guidlines: wrong attribute on octave

In <IP_ADDRESS> Octave Shift is written

The @rend attribute captures the appearance of the continuation line associated with the octave displacement.

which is wrong, as the appropriate attribute is @lform.

Can you please provide a pull request to fix this? Thanks!