ImageTextureLayered does not persist its state

Godot version
4.0b1dev (commit c2f66648f1cb7f26adf77cc3cf91052c95be5dbe)
System information
Windows 10, Vulkan
Issue description
ImageTextureLayered and its subclasses do not save their "content" when asked by using ResourceSaver.save. No persistable properties are defined, so none are stored.
Steps to reproduce
The following code:
var i := Image.create(1, 1, false, Image.FORMAT_RGB8)
i.set_pixel(0,0, Color(1,0,0))
ResourceSaver.save(i, "res://image.tres")
var l := Texture2DArray.new()
l.create_from_images([ i ])
ResourceSaver.save(l, "res://layered.tres")

Results in layered.tres looking empty like this:
[gd_resource type="Texture2DArray" format=3]

[resource]

while image.tres shows the proper image was created (and saved):
[gd_resource type="Image" format=3]

[resource]
data = {
  "data": PackedByteArray(255, 0, 0),
  "format": "RGB8",
  "height": 1,
  "mipmaps": false,
  "width": 1
}

Minimal reproduction project
See code above.

I'd love to create a PR for this, but then I first have to understand how this is supposed to work. Since the whole TextureLayered code was completely reworked since 4.x, I have to idea what the (re)designer of this code had in mind for persistence. Any suggestions/hints would be greatly appreciated.

4.0

Which alpha/beta version are you using? 4.0 isn't released in stable form yet.

4.0

Which alpha/beta version are you using? 4.0 isn't released in stable form yet.

Yeah sorry for not specifying that, it is a master branch from a day or so ago, commit c2f66648f1cb7f26adf77cc3cf91052c95be5dbe

Related to https://github.com/godotengine/godot/issues/66192 and https://github.com/godotengine/godot/issues/54202 (likely due to the same cause).

Duplicate of https://github.com/godotengine/godot/issues/63025
As explained there, this:
var l := Texture2DArray.new()
l.create_from_images([ i ])

Should be:
var l = Texture2DArray.create_from_images([ i ])

Duplicate of #63025
As explained there, this:
var l := Texture2DArray.new()
l.create_from_images([ i ])

Should be:
var l = Texture2DArray.create_from_images([ i ])

Have discussed this on rocket chat - I don't believe the static create_from_images function has been implemented for the layered texture types yet (though I think they probably should be for consistency with changes in other Image-related classes).
In my tests, creating e.g. a Texture2DArray using similar code to the OP works fine in-memory - assigning the resulting Texture2DArray to a shader uniform works as intended and can be sampled. It's when it's saved via ResourceSaver.save() that it appears to be saving an empty resource instead of serialising the layers.

So, is there any suggested docs I should look at if I want to create an MR for this? My gut feeling says LayeredTexture should simply have the images persisted, but I'm not sure that's an acceptable solution. Any guidance from Godot devs on this would be greatly appreciated.
This bug is really blocking me from seriously using Godot :(

Don't know if this is useful, but here's a valid TextureArray resource generated in Godot 3.5.1. It doesn't import/convert into Godot 4, and running the same code in Godot 4 produces that mostly empty resource.
It's just 3 128x128 textures from OpenGameArt. As you can see it's the raw image data stored as subresources, followed by some metadata about the TextureArray itself. Interestingly, the layers property of that metadata is set to [null, null, null]. I don't know if that's intentional or not, but I can still sample the layers of the generated resource in a shader correctly.
stone_wall_texarray.zip
Truncated for brevity:
[gd_resource type="TextureArray" load_steps=4 format=2]

[sub_resource type="Image" id=1]
data = {
"data": PoolByteArray( 87, 81, 75, [... lots more values]),
"format": "RGBA8",
"height": 128,
"mipmaps": false,
"width": 128
}

[sub_resource type="Image" id=2]
data = {
"data": PoolByteArray( 119, 120, 109, [...]),
"format": "RGBA8",
"height": 128,
"mipmaps": false,
"width": 128
}

[sub_resource type="Image" id=3]
data = {
"data": PoolByteArray( 94, 95, 89, [...]),
"format": "RGBA8",
"height": 128,
"mipmaps": false,
"width": 128
}

[resource]
flags = 9
data = {
"depth": 3,
"flags": 9,
"format": 5,
"height": 128,
"layers": [ null, null, null ],
"width": 128
}

I was trying to figure out in Godot's source where in the ResourceSaver/ResourceFormatSaver system these get generated but I've had no luck so far.

The problem you describe above is 3.x specific, see my PR #70212 for a fix. master ("4.x") currently has no serialisation of Texture2DArray implemented at all :(

I was trying to figure out in Godot's source where in the ResourceSaver/ResourceFormatSaver system these get generated but I've had no luck so far.

I agree it isn't very obvious, and it is lacking documentation (serialisation in general). If you look at the C++ classes mapping to the GDScript classes you can find where it defines the "public" GDScript attributes which are serialised automagically.

Okay, I think I have a fix for master too, seems to work here locally, but I want to wait for the results of PR #70212 first, as they share the core changes, and I want to first be sure those are okay to commit.
Anyway, hopefully this will finally be the end of all the TextureLayered woes with Godot, and I can go back to hacking on my game instead of Godot 😄

The problem you describe above is 3.x specific, see my PR #70212 for a fix. master ("4.x") currently has no serialisation of Texture2DArray implemented at all :(

Ah, I didnt realise it was actually a problen in 3.x - just that porting my game from 3.x to 4 indeed means I'm blocked by the broken serialization, I just posted the 3.x as an example in case it gave someone some insight into why it wasn't working in 4. Sounds like you nailed it though, I will keep an eye out for the 4 PR as I can finally continue my porting :)

Sounds like you nailed it though, I will keep an eye out for the 4 PR as I can finally continue my porting :)

If you feel experimental enough, the 4.x commit that fixes it for me is here: https://github.com/Game3DEE/godot/commit/68bb829d49afcd4f0bd6516abbed84f1a27df61f, feel free to grab it, but this is only tested with the above script, so YMMV.

@Ithamar I just compiled master with your patch and can confirm, it fixed my problem with Texture2DArray saving - worked perfectly! Thanks!

Nice! I'll clean it up and post a PR for it as well tonight, so we can get all the Texture2DArray stuff back working again 🎊

Fixed by https://github.com/godotengine/godot/pull/71394


Rapid switching between powersave/normal mode

When the saber is powered on and left for a random amount of time, the critical battery alert plays and repeats. LS_INFO shows that the saber is alternating between powersave/normal mode continuously. This only occurs when the saber is in ACTION mode. Current set up is connection/power via USB. Untested with battery.

I confirm tht I have the same problem.
Using a PC on windows 10
I don't know which OS your using but I recently discovered that in windows 10 Microsoft added a USB power save management that shut some USB port if it consider it is not used.
It seems it is also present in W7 and W8:
http://www.groovypost.com/howto/usb-selective-suspend-windows-explained/
That might be why,on USB we get critical battery alert.
Please confirm

Currently using W7. Disabled selective USB suspend and I'm getting better results. I've run it a couple minutes and so far no issues.

Upon further investigation, it's possible that I may have my LOW_BATTERY and CRITICAL_BATTERY constants configured incorrectly. I'm using a 4-cell 7.4V 1600 mAh Li-Ion battery and I'm not sure what my values should be. Where did you get 3200 and 3050 from?

As I noted it in the code those parameters are adapted for a 1 cell 4,2V battery.
Search on the net what are the safest low batterys voltage.

should be corrected in v1.0.4


Added .env file

How did you push it ? :D .env is included into .gitignore file :D

By removing it from gitignore locally 😆


Remove RHEL5, add RHEL7 selinux samples

The RHEL5 sample policy is out of date and no longer required.
Add RHEL7 sample selinux policy files.

@gregstager any news on this PR?  Thoughts about my earlier comment?  Thanks.

@kdrodger good question.  I'd get rid of the RHEL 5 stuff and likely the RHEL 6 as well or in a separate PR in November 2020 when it moves into Extended Life Support.  @gregstager thoughts?

I have some updates to make.  I will submit a new PR.


[BUG] Cannot choose either volume or vlans not in default namespace

Describe the bug

To Reproduce
Steps to reproduce the behavior:

I created Volume and Vlan that both are not in default namespace.

The options only display volumes/vlans in default namespace when creating VMs.

Expected behavior

Can choose Volumes that are not in default namespace.
Can choose Vlans that are not in default namespace.

Support bundle

Environment:

Harvester ISO version:
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

I tested on version master-7b0da5d1-head:

I created a local namespace called ldevulder-ns
I was able to add a vlan on that created NS, as well as a volume and a Cloud Config template
I also added an OS image in that NS
And I was able to create a VM with the WebUI on the same NS and all resources created in ldevulder-ns were available
I also tried to create a VM in the default NS with the resources created in ldevulder-ns, but in that case I had issue with the vlan: I will open a new bug for this.

So, I wasn't able to reproduce the original issue, seems to be fixed. Could be closed.


Add spec-grip to grip-framework

Hello, I've made spec-grip and I want it to be in grip-framework so, is it possible to add me to the org like that I transfer to grip-framework ?
Thanks! 😃

Okay I invited you, also keep in mind that in Grip will be updated to version 0.28 soon and you might have to change some parts.


v4 throws an error "Cannot read properties of undefined (reading 'retrieveSecret')"

Please check our current Issues to see if someone already reported this https://github.com/Microsoft/azure-pipelines-task-lib/issues
Environment
azure-pipelines-task-lib version: 4.0.1-preview
Issue Description
Trying to run the following task:
https://github.com/microsoft/azure-devops-extension-tasks/blob/dev-v4/BuildTasks/TfxInstaller/TfxInstaller.ts
Expected behaviour
The task executes just fine
Actual behaviour
##vso[task.issue type=error;]Cannot read properties of undefined (reading 'retrieveSecret')

From what I can tell from the debugger the error happens here:
 20     return __awaiter(this, void 0, void 0, function* () {
 21         try {
>22             const version = taskLib.getInput("version", false);
 23             const checkLatest = taskLib.getBoolInput("checkLatest", false) || false;
 24             yield getTfx(version, checkLatest);
debug> s
break in node_modules\azure-pipelines-task-lib\task.js:203
 201  */
 202 function getInput(name, required) {
>203     var inval = im._vault.retrieveSecret('INPUT_' + im._getVariableKey(name));
 204     if (required && !inval) {
 205         throw new Error(exports.loc('LIB_InputRequired', name));

Here's the zipfile
task.zip
To run locally:
node tfxinstaller/tfxinstaller.js

When I switch the import order from:
import * as toolLib from 'azure-pipelines-tool-lib/tool';
import * as taskLib from 'azure-pipelines-task-lib/task';

to:
import * as taskLib from 'azure-pipelines-task-lib/task';
import * as toolLib from 'azure-pipelines-tool-lib/tool';

I get a new error:
##vso[task.issue type=error;]Cannot read properties of undefined (reading 'trim')

When I switch the import order from:
import * as toolLib from 'azure-pipelines-tool-lib/tool';
import * as taskLib from 'azure-pipelines-task-lib/task';

to:
import * as taskLib from 'azure-pipelines-task-lib/task';
import * as toolLib from 'azure-pipelines-tool-lib/tool';

I get a new error:
##vso[task.issue type=error;]Cannot read properties of undefined (reading 't')

It looks like a library version conflict. In the pipeline tasks this is solved as follows https://github.com/microsoft/azure-pipelines-tasks/pull/17222/files#diff-a47a4c679593fd7fd921514d60e0ba669681ce937dab37845f359cddd0a9a22e

I don't really see a difference from how I do it. I've upgraded both Azure pipelines libraries to the latest preview as well as brought my dependencies up to date.

The order of imports really seems to matter:
import * as taskLib from 'azure-pipelines-task-lib/task';
import * as toolLib from 'azure-pipelines-tool-lib/tool';

works.


V0.6.1 dev

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: daili0015:x: YzmblogYzmblog seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


How to use Custom Nginx Configuration

is there any examples to show how to use "Custom Nginx Configuration"

No there isn't. It's a feature that's been added for advanced users with previous nginx knowledge. If you tell me what you're trying to achieve, I can give you a specific example.

Sorry to highjack this thread but, I have a similar question.
I am trying to have nxgin do a re-right of the url every time.
the problem is one of my site behind the reverse proxy is set for'
(http://example.com:8080/) & (https://example.com:8443/). its a unifi controller and i can change the port to 80 and 443 without the service failing. so i just forwarded 8443 and 8080 to 80 and 443 but i really need it to perform a re-right as well every time to fix the issue.
So i need nxgin to change the http://example.com:8080 & https://example.com:8443/) to just https://example.com.
Any help would be great.

I just can seem to use a standard Nxgin Rewrite.
I used this but it did not work.
server {
listen 8080;
listen 80;
listen 8443 ssl;
listen 443 ssl;
server_name www.old-name.com old-name.com;
return 301 $scheme://www.new-name.com$request_uri;
}

Hi, How can I use the same domain name with different ports? ID I want to add a new port the app shows that the domain is already in use.

Anyone know how to allow access to the network only from internal network?
I've tried something like:
location / {     allow <IP_ADDRESS>;     allow <IP_ADDRESS>/15;     allow <IP_ADDRESS>/8;     deny all; }
Where <IP_ADDRESS>/8 is my Docker subnet (including OpenVPN), <IP_ADDRESS>/15 is for my local behind NAT networks for home PC, Netbooks etc. Unfortunately -  when I apply this config - I've got: 404 Not Found error :(

For any interested. I've just dropped header and footer.
My current Custom Nginx Configuration in Advanced tab is:
allow <IP_ADDRESS>
allow <IP_ADDRESS>/15;
allow <IP_ADDRESS>/8;
deny all;

where <IP_ADDRESS> is my external IP address.
This solve my issue. Host is accessible only from local / VPN network.

Anyone was able o configure seafile server over nginx-proxy-manager?
nginx configuration for seafile is in the following link:
https://seafile.readthedocs.io/en/latest/config/nginx/
I am trying without success!

For any interested. I've just dropped header and footer.
My current Custom Nginx Configuration in Advanced tab is:
allow <IP_ADDRESS>
allow <IP_ADDRESS>/15;
allow <IP_ADDRESS>/8;
deny all;

where <IP_ADDRESS> is my external IP address.
This solve my issue. Host is accessible only from local / VPN network.

I'm assuming you had a semicolon at the end of the first line right?

For any interested. I've just dropped header and footer.
My current Custom Nginx Configuration in Advanced tab is:
allow <IP_ADDRESS>
allow <IP_ADDRESS>/15;
allow <IP_ADDRESS>/8;
deny all;

where <IP_ADDRESS> is my external IP address.
This solve my issue. Host is accessible only from local / VPN network.

I'm assuming you had a semicolon at the end of the first line right?

Correct - fixed on comment ;)

Correct - fixed on comment ;)

Sorry to highjack this thread but, I have a similar question.
I am trying to have nxgin do a Rewrite of the URL every time.
the problem is one of my site behind the reverse proxy is set for'
(http://example.com:8080/) & (https://example.com:8443/). it's an unifi controller and I can change the port to 80 and 443 without the service failing. so I just forwarded 8443 and 8080 to 80 and 443 but I really need it to perform a Rewrite as well every time to fix the issue.
So I need nxgin to change the http://example.com:8080 & https://example.com:8443/) to just https://example.com.
Any help would be great.

Did you solve this?  I too am setting up unifi controller in Docker behind NPM proxy and unsure how I might have all the required ports handled by the proxy.
I have a proxy host setup in NPM:
unifi.mydomain.com > https://container_name:8443
This works great for the web interface (and because its SSL end to end there's no issue with the login error).
But I also need to redirect the following ports to the container too:
8080/tcp - Device command/control
8880/tcp - HTTP portal
3478/udp - STUN service
6789/tcp - Speed Test (unifi5 only)
I could just map the ports to the docker host instead of just expose.  Or use "streams" in NPM but this uses IP address only which could change on my container.

nginx-proxy-manager uses advanced_config  as Custom Nginx Configuration,
https://github.com/jc21/nginx-proxy-manager/blob/e91019feb91ca29187dbc106b96d5becda5679b1/backend/templates/proxy_host.conf

hi, Does someone know how to change the return ssl conf to port 308 instead of default 301?
When I try to use nginx with ssl to APIs, POST redirect to GET. :/


Fix the project description visibility issue

What does this PR do?
This PR fixes the issue #166 of paragraph visibility in the repository card. The paragraph was not visible because of the default black color. To solve this problem, I added a tailwind class bg-slate-50 to the h6 (description) element that changes the text color to light gray. This makes the paragraph readable and improves the contrast with the background. You can see the difference in the screenshots below.
Before

After

@max-programming @Md-Talim already done in #165

Sorry but this already got fixed @Md-Talim


Do not use CIDR (slash) notation for subnet masks when the app shows an IP address

Overview
The app currently shows IP addresses like this:

Wireless IP: <IP_ADDRESS>/24
Wired IP: <IP_ADDRESS>/16

Instead, it should show them like this:

Wireless IP: <IP_ADDRESS>
Wireless subnet: <IP_ADDRESS>
Wired IP: <IP_ADDRESS>
Wired subnet: <IP_ADDRESS>

Or something similar. The subnet mask is spelled out on its own line, rather than being represented by a number after a slash.
Why
Users occasionally need to copy their robot's IP for things like SSH and Jupyter. When they do, they have to be careful about copying just the part that comes before the slash.
Separating out the subnet mask like this would eliminate that tripping hazard.

Going to do this app-side and reconsider the networking endpoints for HAPIv2


3d sift features extraction

Sorry this is not really an issue. But i have been seaching for a pcl wrapper for python.
Does this pcl wrapper can find the sift features ? If possible please send a snippet.
I tested with python-pcl wrapper but SIFT feature library for python is missing.
I really hope your wrapper works.
Thank you

Unfortunately no, the keypoints module is not implemented but I think it wouldn't be that much work... I'll leave this here as a reminder for a future version.

Thank you for the information

The readme claims the keypoints and features modules are supported now, so is this issue still ongoing? I'm looking to use PCL from python myself for pointcloud feature extraction in python, pclpy looks promising if these modules work now!


Slow!

Either toggling a checkbox with the keyboard shortcut, or opening the modal with the n/N buttom in the bottom bar are both very slow (like, 30s).
(After opening the modal, clicking a checkbox, and then clicking "OK", the file is modified within four seconds--still slow, but ok.)
This is in a Foam workspace with 2643 notes and about 500,000 files overall.

I am sorry that it is so slow in your case. I haven't used the extension with so many files in a workspace yet, so I haven't experienced it so slow. For the creation of the checkboxes I mostly use the VS Code API. I may check it out when I get a chance to see if I can improve the performance. Thanks for bringing this to my attention.

I tried uninstalling and reinstalling today; same problem. To provide a little more detail, it seems to work normally if I open the sub-directory containing my test file (which contains 658 markdown files and 3246 files in general), but not in the previous folder (parent of the parent of the folder with the test file, now with 2742 markdown files and 366300 files overall).
It does eventually toggle the checkbox, but it's unusably slow.
I also tried disabling "Date When Checked", "Italic When Checked", and "Strike Through When Checked", though those, like the whole extension, shouldn't really care whether the containing folder has 1 or 1000000 (markdown() files. No dice. The extension is doing something with the whole workspace that it really shouldn't be, to have this scaling issue.


OpenElec Cubox-i4 since update from 5.0.3 to 5.0.7 just grabbing the main menu and fanarts but not videos

Hey everybody,
I have been using Hyperion for some time now on openelec.
Recently updated to 5.0.7 (now 8)
Since then frame grabbing only worked in the menus but not anymore during videos.
During videos I just get a light purple lighting.
I have tried to reinstall hyperion with the openelec script. But this did not help.
Do you have any idea what the problem could be?
Thanks
Cheers derdude

I read this post btw.
https://github.com/tvdzwan/hyperion/issues/260
Did not solve my problem though. Switches on and of json a dozen times, combined with killing hyperion, and editing the config falsing out the grabber. Did not work for me :-(
Any idea besides installing kodi from scratch?!? Which I really don't want to do!
Cheers dude

Reinstalling open elec 5.0.8 did not help. Still no ambilight during videos.
With one exclusion: I have one DVD rip of the naked canon which shows a running ambilight?!?
Everything else, no matter if YouTube or different kind of mkv, avi etc. don't work.
Any ideas?!? How to fix this?
Cheers dude

Reinstalling open elec 5.0.8 from scratch did not help. Still no ambilight during videos.
With one exclusion: I have one DVD rip of the naked canon which shows a running ambilight?!?
Everything else, no matter if YouTube or different kind of mkv, avi etc. don't work.
As Hole DVD rips seem to work I think the problem lays in hyperion not detecting, that a video is playing.
I have no idea why it recognizes DVDs though...
Any ideas?!? How to fix this?
Cheers dude

Reinstalling open elec 5.0.8 from scratch did not help. Still no ambilight during videos.
With one exclusion: I have one DVD rip of the naked canon which shows a running ambilight?!?
Everything else, no matter if YouTube or different kind of mkv, avi etc. don't work.
As Hole DVD rips seem to work I think the problem lays in hyperion not detecting, that a video is playing.
I have no idea why it recognizes DVDs though...
@tvzwan Any ideas?!? How to fix this?
Cheers dude

Reinstalling open elec 5.0.8 from scratch did not help. Still no ambilight during videos.
With one exclusion: I have one DVD rip of the naked canon which shows a running ambilight?!?
Everything else, no matter if YouTube or different kind of mkv, avi etc. don't work.
As Hole DVD rips seem to work I think the problem lays in hyperion not detecting, that a video is playing.
I have no idea why it recognizes DVDs though...
@tvdzwan Any ideas?!? How to fix this?
Cheers dude

@derechtedude same here, I cant make it work hyperion + cuboxi (using openelec 5.0.7 or 5.0.8) + arduino uno (ws2801 led strip). The frame grabber works on menus but not on video player.

I  downgraded back to 5.0.0
Worked again straight away.
I guess, something was changed trat hypwrion does not recognise Films anymore...

@derechtedude with openelec 5.0.0 works fine :)
Now we should know what's happening with newer openelec versions :S

For some reason in the new openelec versions the video playback is rendered on the second framebuffer. That means that the whole GUI incl. menu, pictures and other functions are on /dev/fb0, but the video is on /dev/fb1
I guess will have to add additional configuration separation for the framebuffer grabber to handle this...
As a temporary solution add an additional line to the framebuffer options
"device": "/dev/fb1"

in your config file:
"framegrabber" :
        {
                "width" : 128,
                "height" : 64,
                "frequency_Hz" : 10.0,
                "device": "/dev/fb1"
        },

This will make it working for video playback, but won't work for all other media and menu.

Good to know, what the problem is.
Gonna stick to 5.0.0 until you found a solution.
Thank you!
Cheers mat

Well, the solution is above, and since it works for video playback (IMHO the main use case) it might take a longer time until I will do a fix...

So, I added the "device" line to my config file and then the leds did not responde at all (not even for menu items).. so I switched the device to /dev/fb0 - that too did not help. Only when removed the device line altogether did the menu item came back to life - but in any case no lights responding to movie.
Should I have done something else?  (installed the hyperion from the main repo)

No it should be enough, paste the whole block of the "framegrabber" config and check the terminal output if you start hyperiond manually

oh! stupid me :) dropped the comma before that line...
OK. it works now - just the colors issue remains.
Great! thanks for all of your efforts and looking forward to the fix ;)

@Gamadril I have used this fix and now I can't get colors to show properly no matter which color order i use in config... Blues show as yellow and red shows as blue... I am using my last known working configuration in order to ensure a smooth OS update on my hummingboard.

Had no time to rebuild the binaries yet, but you can compile yourself the code from https://github.com/Gamadril/hyperion on xbian for example and replace the binary later on OpenELEC.

@Gamadril
Could this be closed? How should we handle the Cubox support?

Closed


Re-layout the terminal tabs as you drag the sash

Currently, the terminal tabs view doesn't update until you release the sash, and imo it should be updating live.

It's debounced by the sash and will resize when you pause briefly even without releasing. I think this is ideal since resizing a terminal so often is both slow since it's an expensive operation for a large buffer and could cause strange wrapping.

That's not the behavior I am seeing -- it never changes while I'm dragging. The terminals resize, but the tabs don't.

Oh if you mean the tabs then this is a dupe of https://github.com/microsoft/vscode/issues/121235


Troubles running sample models with evade

Hey there!
So I've run into this issue when we're attempting to run most of the example models (pretty much all except WAF Brain):
https://pastebin.com/wS6DXJG4
Switching to a Python 3.5 installation and installing the 0.21.1 sklearn as suggested by the warning gives us a plethora of syntax errors instead, which I could post here as well.
I noticed that whenever I first build the setup.py file, I get a file wafamole.py (for module wafamole) not found warning at the end of the process, after which I'm able to run setup.py install as if nothing had happened. Is that file intended to be missing and/or could it have something to do with the evade errors found afterwards?

Good news I hope - after trying some more sklearn versions under Python 3.9, I believe the application is now working for all of the provided examples in the README.md. The only curious thing is the amount of warnings that seem to pop up, but perhaps they won't impact further development. For reference, after running the waf brain evade example, here's the resulting console logs https://pastebin.com/19rM5b8K.
Anyway, for anyone else with this issue, running Python 3.9.2 on Debian with exactly sklearn 0.21.3 did the trick for me.


drivers/mtd:init commit of power-loss resilient cfg

Signed-off-by: 田昕<EMAIL_ADDRESS>Summary
MTD non-volatile storage was originally implemented in Zephyr by Laczen. We made several modification to the original design.
The main purpose of those modification was:

support C-string key in nvs API(Original design only support uint16_t as key)
Meanwhile achieve better performance by limiting flash read times(Theoratically
better than Zephyr subsys/settings, which is based on original NVS).

This is the initial commit, I have tested its set/unset/get/list/erase with https://github.com/apache/incubator-nuttx-apps/tree/master/system/cfgdata, the result shows no obvious bug.
More tests on power-loss behavior are needed, and I plan to add those test cases into apps/testing in the next patch
Impact
config data only.
Testing
set/unset/get/list/erase tested on ESP32C3.

In general I'm a bit lost in architecture here. The MTD layer is designed to provide unified "continuous" access across the underlying physical layer, so I expect that all alignment or any other hardware related stuff is hidden "under" MTD device, but here I observe an opposite when the MTD caller handle alignment and other stuff. I mean that if MTD is implemented on top of flash that is what I expect, but not implementing a flash on top of MTD what I see here. I will submit a negative feedback until all design points are not clarified

Basically, MTD like a block device(but need erase before write, wear leveling and ECC), which is hard to use from user application. To fix this problem, we normally have two approach:

Build a complex filesystem on top of MTD to support a tree like structure(e.g. spiffs, smartfs and littlefs).
Build a simple key value storage on top of MTD

NVS(and cfgdata) is the second approach. @pkarashchenko do you get the idea?

In general I'm a bit lost in architecture here. The MTD layer is designed to provide unified "continuous" access across the underlying physical layer, so I expect that all alignment or any other hardware related stuff is hidden "under" MTD device, but here I observe an opposite when the MTD caller handle alignment and other stuff. I mean that if MTD is implemented on top of flash that is what I expect, but not implementing a flash on top of MTD what I see here. I will submit a negative feedback until all design points are not clarified

Basically, MTD like a block device(but need erase before write, wear leveling and ECC), which is hard to use from user application. To fix this problem, we normally have two approach:
1. Build a complex filesystem on top of MTD to support a tree like structure(e.g. spiffs, smartfs and littlefs).

2. Build a simple key value storage on top of MTD

NVS(and cfgdata) is the second approach. @pkarashchenko do you get the idea?

@xiaoxiang781216 we already have KVS on top of MTD and that is mtdconfig. Could you please bring some more light on key differences between mtdconfig and NVS?

The major difference is power failure safe, it's very hard to support this feature on mtdconfig without breaking the binary combability.

I have found a few bugs, and will keep on fixing. So I convert this to draft.

Though this is a draft, please review it. Much appreciation to anyone helps to review it.

I will review in the weekend.

Alright, I have fixed the bugs and passed zephyr test cases. Please review.

I have rebased it

test cases are here:https://github.com/apache/incubator-nuttx-apps/pull/1288

@pkarashchenko could you review again?

Yes, I will review


Upgrade to go 1.17

fixed: https://github.com/open-cluster-management/backlog/issues/15466
Signed-off-by: clyang82<EMAIL_ADDRESS>

/retest

/retest


haskellPackages.nixfmt: Unbreak

Motivation for this change
Unbreak nixfmt, which needs some upper version bounds relaxed (serokell/nixfmt#62).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Looks like this works, thanks!


Compiler crash on deriving union signature

function f(...a: string[]) { }

function g(a: string, b: string, c: string) { }

var x1: typeof g | typeof f;

x1(1)

C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:36478
                throw e;
                      ^
TypeError: Cannot read property 'flags' of undefined
    at getTypeOfSymbol (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:15667:23)
    at compareSignatures (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:18397:107)
    at findMatchingSignature (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16237:21)
    at findMatchingSignatures (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16259:59)
    at getUnionSignatures (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16281:47)
    at resolveUnionTypeMembers (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16313:34)
    at resolveStructuredTypeMembers (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16402:21)
    at getSignaturesOfStructuredType (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16559:32)
    at getSignaturesOfType (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:16569:20)
    at resolveCallExpression (C:\Users\Anton.Lobov\Desktop\ts-latest-github\TypeScript\built\local\tsc.js:21545:34)

@sandersn can you take a look.

Looking ... I can only get it to repro when one function of the union has a rest parameter and the other function has more than one parameter. Otherwise it dies with "Cannot invoke an expression whose type lacks a call a signature."
So I suspect that ((...a: string[]) => void) | (a: string, b: string) => void) is not supposed to have a call signature either, it's just getting missed. I'll see what the spec says.

This is related to change https://github.com/Microsoft/TypeScript/pull/4200.
(I was studying how it is supposed to work and invented this test case, on which the compiler crashed.)
It's not mentioned in the spec at all (maybe not yet).
As far as I understood from what's done there, ((...a: string[]) => void) | (a: string, b: string) => void) since 1.6 is supposed to have signature (a: string, b: string) => void, because it has partial match with '(...a: string[])' by the first two parameter.
Seems that crash happens because it tries to compare non-existing param of the first signature to the second param 'b', instead of comparing rest-induced parameter to it.
Reproduces always when the first signature has a trailing rest param and less parameters than the second signature.

It was just a simple error in compareSignatures. The line is
let s = source.hasRestParameter && i === sourceLen - 1 ? getRestTypeOfSignature(source) : getTypeOfSymbol(source.parameters[i]);

Notice that the comparison is i === sourceLen - 1. It should be i >= sourceLen - 1. As @zhuravlik says, a fixed signature that is longer than a signature with a rest parameter will incorrectly try to getTypeOfSymbol of a non-existing parameter on the signature with the rest-parameter.
I'll have a fix out shortly. After the fix is in place, type checking of the function union proceeds as I expect it to from reading the spec. I added some conformance tests to clarify.


Loader cannot import server configuration file

I want to LAN with my friends in Dark Souls 2 but the latest version cannot import the server configuration file as before. In future versions, can the import server configuration file function be re-added? Thank you for your work！

This what actually intentionally removed. The import feature was almost never used and just caused a lot of confusion and support requests from people.
If there are people actively using it, I may re-add it as some form of hidden/advanced option


Slack invite URL needs to be renewed very often

We're using Slack as an open place (anyone can join). It's an edge case they're apparently not very interested about - most people go to Discord or Mattermost to have this - and to make it work we have to use a workaround where we generate public invite links. They've recently reduced the quota for these links: each one is now limited to 400 uses; which means we have to renew the links quite often (this one could maybe be automated).
This has beed discussed and manually updated for quite some time now, but recently the number of times a link can be used have significantly decreased which forces us to renew it very often. To make things worse, we don't have any automated alert when the link expires, so we're left with @Betree, which is not a very stable approach.
Two things could help improving this:

Automatically detect when the link is dead. This might not be straightforward, as the page is rendered with JS it's not obvious how this information is fetched. Here's an expired link to investigate: https://opencollective.slack.com/join/shared_invite/zt-1zffgu7io-v_pFWI3aaONo1HAIAkQLgA?nojsmode=1
Auto-renew the link. Maybe we can do that through their API? See https://github.com/opencollective/opencollective-tools/tree/main/slack

For what it’s worth, I believe we have this automatic detection set up on a project I work with. We use an expired link and the "production" link and compare the results, from what I could figure out. Then we have an incoming webhook pinging a Slack channel. I can try to locate the code for this if it helps.
I forget where but I think I’ve also heard Slack support was able to generate invite links for thousands of users at a time.

For what it’s worth, I believe we have this automatic detection set up on a project I work with. We use an expired link and the "production" link and compare the results, from what I could recall. Then, we have an incoming webhook pinging a Slack channel. I can try to locate the code for this if it helps.

Interesting! Would love to see the code if you have that. The last time I checked, it didn't seem like a very straightforward path: there's no special HTTP code to catch, and the page's content is generated with JS so it looked like we would have to render it before we can detect anything.

I forget where but I think I’ve also heard Slack support was able to generate invite links for thousands of users at a time.

Could be, they used to allow that from the interface a while ago, which made this less of a problem - the link was expiring less often.

This won't be an issue anymore as we're migrating to Discord.


#155, When failed to push message, re-initiate (re-open) connection

A proposed fix for #155 (An Invalid APNS Token Breaks Active Connection)

Travis builds failed, need to check tests.

I have fixed issues and merged this PR.


Add each broker's principal in Controller's super user list

Description
This PR aims to add each broker's principal to Controller's super users list on RBAC cluster with mTLS
Fixes # ANSIENG-2385
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
tested locally
Checklist:

[x] Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

looks good, thanks Mansi! do we have any molecule scenario to simulate and test this?

Unfortunately no, the way we create principals in our code, it generates the same principal for each broker. I tested manually by adding different principal names and checking if it is getting added in server.properties


API: children of page endpoint

Endpoint to get all children of a page. This must be compatible to Integreat API v3.
https://github.com/Integreat/cms/wiki/REST-APIv3-Documentation#children-of-a-post
@maxammann @Simple-codinger is this used by any current app? Otherwise this can be moved to another milestone.

It's currently not used, but I would suggest to rethink the api and provide a different api for offline content loading and progressive content loading in the webapp.

We still need to implement at least the API v3. We can discuss a newer API later.

For full backwards compatibility we also have to implement v0…

@Simple-codinger can you provide information about how many installed apps are using which API version?

Currently all of the devices are using APIv0 because we still have some issues remaining in the  APIv3 Branch

to be discussed in gdoc

So we decided that this is not immediately necessary as there are no plans to change the API in the foreseeable future.

Its now being used, but probably already implemented.


Tailer is not streaming line if file is a symbolic link

Hi,
Seems like the Tailer is not pushing lines over the channel ( Lines() ) when the given filepath is a symbolic link.
I am instanciating the tailer this way:
logtailer := tailer.RunFseventFileTailer(filepath, false, true, logger)
the filepath is pointing to the file named access.log that is a symbolic link
-rw-r--r-- 1 dbenque dbenque  521 Feb 20 23:38 access0
lrwxrwxrwx 1 dbenque dbenque    7 Feb 20 23:38 access.log -> access0

At the same time I have process writting inside file access0. The lines finally arrive in one bulk when the process writting to the file access0 is terminated.
Would it be possible to support Symbolic Link for the tailer?
Note:
> uname -a
Linux ncelrnd0228 4.15.0-45-generic #48-Ubuntu SMP Tue Jan 29 16:28:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Thanks,
David

The file tailer implementation doesn't support symbolic links. The reason is that the implementation reacts on file system events, like some process wrote to the file. With the symbolic link, these events don't occur because technically you don't write the symbolic link, but you write the file it points to.
Of course it would be possible to implement that (when the tailer sees a symbolic link, it could watch the file it points to instead of the link itselv), but this is currently not on the todo list.
The best workaround is to use the polling tailer instead. In grok_exporter you get that by configuring poll_interval_seconds, in code you get it with tailer.RunPollingFileTailer(...) or the new fswatcher.RunPollingFileTailer(...). I am currently refactoring the tailer implementations to add support for multiple log files, so if you use this in code be aware that this is internal api and will change in the near future.


Says installed even with no internet

I tried to install something on a Wi-Fi network that blocked the site. It said that it installed, but it didn't.
Then I tried turning off Wi-Fi altogether, and had the same result.

Maybe add a check to confirm that the package is accessible before installing?

Seem to be lacking error checking for the winget commands.


Who wants to pay for Serratus continue with this project?

Who would be willing to pay (in BTC) for Serratus to develop this project again?
It would be interesting if he resumed the project and added the parallel processing of the new Chrome API below:
https://web.dev/shape-detection/
@serratus  what do you think in being payed to work again in QuaggaJs?

Doesn't look like it'd be too hard to make a Shape Detection API reader, although it doesn't appear that it provides the full amount of information that is available in most of the decoders in Quagga.  Difficulty level is increased, however, by that it apparently only works on Android or Mac chrome, and most devs use Windows or Linux... and it can be quite annoying to develop against an Android device.  It's not impossible, but it's timeconsuming.

My idea would be to embed this new API in parallel with the current QuaggaJs processing.
For example, firing a worker with each logic and the one that responds the fastest returns the result.
Of course, if this API is available in the browser's user.

I think that depending on Workers, as they were constructed in the existing Quagga, isn't really a good idea -- in my fork, I've actually eliminated use of workers, and seen substantial benefit -- I believe the existing worker structure put a quite substantial load on each worker, by spawning a complete copy of the entire library in each thread, and all of them appear to be duplicating each other's work.  Forcing numOfWorkers to 0 has shown significant gains in detection speed on my app that uses Quagga.
That said, I've been working on slowly rearchitecting pieces to be much more reusable, and I believe that with the fork that I have, or something very similar to it, it should be possible to create a wrapper that can better distribute work to multiple workers -- ie, have one copy working on each reader.  That would probably show better results than the present way.  Ultimately, if I were to re-implement the worker part inside the lib, I would probably want to try out having one thread that runs barcode detetction/location, and multiple workers that each have just a single reader running inside them.  As I separate the pieces of Quagga to make them standalone units, that becomes more likely to happen in the future.  What I'm really stuck on, oddly, is trying to figure out a way with modern tooling, to ship workers inside a browser, without shipping multiple JS files.  Blobbing doesn't seem to be well supported by the current tooling system.


The source parameter is required

Hello,
I'm trying to integrate JMLSPaymentBundle width RuudkPaymentStripeBundle but i've an error when i submit the form :
"The source parameter is required"
An idea please ?

This issue is specific to ruudk/PaymentStripeBundle, please open an issue there. This seems to be the same issue as ruudk/PaymentStripeBundle#5


Release GraphQL and EHealth API

Coverage increased (+0.007%) to 88.904% when pulling 498ccdb8ca306b1737dd2270d85d71dcfcdb3c2c on release-graphql into 17028aad1cfedad3c3dc1ccb063f4942cf2c6102 on preprod.


Ligatue for right arrow

Although I really like the look of the Haskell-style type signatures in our documentation, there is one down side to the right arrow character used in them.  It makes searching much more difficult.  If we want to find all of the 30+ instances of this in the documentation page:
[a] → [a]

we can't search for
[a] -> [a]

even though that would clearly be most useful.  One way to fix this would be to use a font that applies a ligature to the characters '-' and '>' to display a reasonable right-arrow character.
Does anyone know of such a font?  Or have the skills to build one?  I've never played around with fonts in any way.

we should probably just use ->. that's what they do here e.g.
... and they even use it in example searches

Possibly, but I did do some further research after submitting the issue, and I found that there are some tools to make this fairly easy.  I will look further.  For the moment, though, I think we should stop replacing -> with →.

I like just using ->. Keep it simple. It would also make it obvious to people that they can search by using ->. I think few people would realize that they don't have to use the fancy arrows when searching.

I suppose you're right.  It should be obvious enough.  I guess we just want to make sure the look is fairly pleasant in the font we choose.


Can't find Wechat sharing button, any reason why?

Hello,
thank you for this great component (cross platform :+1: ),
is there any reason why Wechat does not appear in the sharing option (for ios) but appears in Android? As I understand it's possible to exclude some application to show up in the list, but how to add one?
Cheers.

@sulliwane what version?

Hi there, the issue is being close. Since it is quite old. I suppose it might have been addressed in new releases of react native share. Please feel free to open it again, so that community can help you 😃


Convert to ESM module (BREAKING).  Target: end of beta cycle.

Rationale
Sindre Sorhus: Get Ready For ESM
Implementation
Sindre Sorhus: Pure ESM package
Sugested timeline

Target: before first non-beta release (planned around July)
When things get quiet on other stuff, perhaps we can release with an rc tag.

Actually we can do the "Dual" approach from the Rationale link above, then it's not a breaking change.  We'll make the library ESM but also have a build step that transpiles a CommonJS fallback.

😆 I was about to open an issue for this! You beat me to it! Yes, I agree. ESModules will a lot better for the rest of the ecosystem.
Suggested Timeline

Start planning important/helpful/required breaking changes
Incorporate this into that list
Release new major version with the changes when the list's length is long enough

Dual
I would say that we should not stick to the dual approach. We can start with it, but we should remove the CJS fallback at the end of April.

Thanks, @PythonCreator27, glad to hear others are on board for this :pray:
Yes, I don't want to support dual moving forward.  But I think we can give people a bit more time to get ready if it doesn't cost us anything.
From what I understood, as long as we provide the fallback, it won't be a breaking change and should be transparent to the user.  It will only be a breaking change / new major version when we drop the fallback.

:tada: This issue has been resolved in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Google popping up all the time is annoying, here's my solution

Make it so Fuchsia says "I'm sorry, i didn't quite understand that. Would you like me to Google it instead?"
And you can add an else if y.startswith Google/Search for... then it goes straight to Google.

Another solution could be to embed the Google search page.
The problem is that after "Would you like me to Google it instead?", the natural response is "yes", and that means that the search query needs to be saved which isn't possible with the local scope the variables have inside the function.

I found that the Bing Search API should work. In fact, Siri uses it. http://www.bing.com/dev/


Fix cert env

Closes #2062

ping @docker/machine-maintainers for review

LGTM nevertheless :-)

LGTM


Prettier urls, #celest+navi instead of #CELEST%20NAVI

Please describe the issue in the wiki:

I know this is merged now, so I was going to close this, but thinking about it again, the way this is implemented now blocks someone from using  + in the category name. If they do, it will break. That was one of the benefits of encoding the URI, was not having to worry about that.
Do you think this matters even? Should we use ++ instead just to make a bit more unique?
¯_(ツ)_/¯
If you think it's fine though, then this can just be closed.

It doesn't matter, people shouldn't use + in their category names in the first place.

Sounds good :+1:


Consider adding node instance name or id attribute in vm element in the vms/ reouces

Rational:

user monitoring vms/ resource, looking for VMs in undesirable Cloud state and removing the VMs from the mutable runs. The latter requires SlipStream (node instance) id (the VM corresponds to) and the run.  At the moment user is forced to query run and look up for the id via cloud instanceId. (Reported by CERN.)

Current structure of vms/vm:
<vms offset="0" limit="20" count="2" totalCount="2" cloud="atos-es1">
<vm cloud="atos-es1" user="test" instanceId="32859" state="Pending" measurement="2015-02-27 13:26:31.837 CET" runUuid="3299acdd-e552-414f-9035-7c440d19e877" />
<vm cloud="atos-es1" user="test" instanceId="32860" state="Pending" measurement="2015-02-27 13:58:39.248 CET" runUuid="90b2f64c-3e99-4bdf-971c-aeeb5006eff1" />
</vms>

This issue is part of the #281.

This was done in #281


Please explain more about Document Reference field in the documentation

I've read this issue #32 too, but it's not solved for me. I'm working with vue it says Maximum call stack size exceeded

#32 refers to a feature (relationships) that was being planned but not implemented in the codebase. You can find more info about Document References in the documentation

#32 refers to a feature (relationships) that was being planned but not implemented in the codebase. You can find more info about Document References in the documentation

+1
I also get Maximum call stack size exceeded when using references (according to the documentation). Did anything change in the api?

Can you reproduce Maximum call stack size exceeded in a tiny example that I can check? @kay-es


Bug with pip installed version

>>> from conference_scheduler import scheduler
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-120-74aea00c250d> in <module>()
----> 1 import conference_scheduler.lp_problem
      2 from conference_scheduler import scheduler
      3 schedule = scheduler.schedule(events, slots)

ModuleNotFoundError: No module named 'conference_scheduler.lp_problem'

I think this might be because something is not included in the setup.py but I'm not sure.  (Works fine using an install from source.)
(Side note: this could also indicate that we should perhaps move to a root/src/conference_scheduler and root/tests directory setup so that we also test an installed version of the library? (Using python setup.py test) I did this for Nashpy after reading about the advantages.)

I’ll have a quick look at this, I have a vague idea of what might be going wrong.


Fix curses backend cursor positions

The get_cursor and set_cursor methods for the curses backend invert rows and columns, this fixes things.

Thanks


React Bootstrap table 4.0.2

Hi,
I am using "react-bootstrap-table": "^4.0.2" for pagination. The component is good.
I am facing the issue on dataSort on a column having date(date time data,createdOn:"21-12-2017 17:25:45").
It's not able to do the sorting on datewise. please suggest how to do it.

is there any library to use for this?

@dileepmiahra we dont support this feature, thanks

Not able to make search on 'In stock' in react-boot-strap table. Or In a reserved keywork in react-boot-strap table. Is there any way to do search for In stock.


Figure out deployment

Incomplete list of ideas:
Heroku

Free web dyno
Worker dyno will cost $7/mo
Easy DB setup, but free version has pretty low quotas

DigitalOcean

No free tier
Web and worker can live on the same machine
Database?


Test propagating cluster name to OpenStack CCM -- Test Release 1.4

Instructions — Phase 1:

Download the latest KubeOne 1.4.0 release candidate
Follow the Create a Kubernetes cluster tutorial to create your cluster on OpenStack
Wait for machine-controller-managed nodes to join the cluster
Ensure all pods are Running
Check the CCM pod to ensure that the —cluster-name flag is set to the name of the KubeOne cluster

Instructions — Phase 2:

Once the test is done, reset the cluster using the kubeone reset command
Download the KubeOne 1.3.0 or 1.3.1 release and provision the cluster again
Ensure that the CCM pod does not have the —cluster-name flag
Reconcile the cluster by running kubeone apply with the latest KubeOne 1.4.0 release candidate
Ensure that the CCM pod does not have the —cluster-name flag
Edit the CCM daemonset to add the —cluster-name flag and set it to the name of the KubeOne cluster
Reconcile the cluster by running kubeone apply with the latest KubeOne 1.4.0 release candidate
Check the CCM pod to ensure that the —cluster-name flag is set to the name of the KubeOne cluster

The Kubernetes version and the operating system don’t matter for this test.

Works as expected.


Support Jest with Stryker v4

The v4 beta of Stryker doesn't support Jest yet. Support should be added.

Long-ago implemented


Add loading spinner

Fething image takes time so we can display a loading spinner till then.

Someone is already working on this issue @nitishkumar333


Ffwd scheduler

This scheduler implements the fast, fly-weight delegation algorithm, that was shown to have a much higher performance in certain situations. The idea is derived form the article at https://blog.acolyer.org/2017/12/04/ffwd-delegation-is-much-faster-than-you-think/ that comprehensively sums up the key aspects of the mechanism. The original implementation was adapted to work without a dedicated hardware thread and instead utilizes message passing between the threads, in order to fit with hpx's design.
Proposed Changes
Adding an additional scheduler, that can be chosen by the user.
Any background context you want to provide?
Scheduler based on the fast, fly-weight algorithm that was implemented during my bachelor thesis under supervision of @sithhell.

@margabue this (and the link you provided) looks very interesting. Thanks! The new scheduler seems to be using a single shared queue for all worker threads (with the thread_queue class unchanged). Is there something missing or is that exactly the point of the new scheduler? Would you mind summarizing the key point of ffwd (delegation, presumably?) and how this implementation differs from the one in the article? Do you happen to have any performance numbers comparing this to our existing schedulers?
It looks like you may have been a bit overeager in deleting files. For example the apex folder and .gitignore should stay, and some CMakeLists.txt are missing.

@margabue Thanks for working on this! This may add a valuable data-point and functionality to our scheduling system. I'm eagerly looking forward to seeing some performance numbers.
Additionally, may I suggest you merge all of your commits into one single commit in the end? That might help understanding your submission.

@margabue @sithhell what is the status of this? Is this likely to be picked up again? Let us know if there's anything we can do to help.

@margabue (@sithhell) I'm closing this for now as it's been inactive for a while, but please let us know if we can help in any way. It would still be nice to have this in at some point.


Init 2023

Hey GAB Team,
Thanks for all the effort. This is for Greater Toronto Area, Canada. Thanks

We have an issue @eskandari on the web site GlobalAzure.net/communities your logo shows up as a broken link! :( Sorry, I missed that in my review! I just made a change to your data in your community folder to fix that. Just so you know!


Add names to memfds

I was confused while debugging what role was pertaining to what fd.

Codecov Report
Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (7039e0f) to head (6d279f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   70.64%   70.57%   -0.07%
==========================================
  Files         281      281
  Lines       41980    41992      +12
==========================================
- Hits        29657    29637      -20
- Misses      12323    12355      +32

Components
Coverage Δ

crashtracker
19.20% <ø> (ø)

crashtracker-ffi
9.20% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
91.86% <ø> (-0.07%)
:arrow_down:

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
82.76% <ø> (ø)

ddcommon-ffi
69.12% <ø> (ø)

ddtelemetry
59.10% <ø> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
89.45% <ø> (ø)

dogstatsd-client
79.77% <ø> (ø)

ipc
82.76% <66.66%> (+0.01%)
:arrow_up:

profiling
84.30% <ø> (ø)

profiling-ffi
77.46% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
37.35% <0.00%> (-0.07%)
:arrow_down:

sidecar-ffi
0.00% <0.00%> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
94.77% <ø> (ø)

trace-mini-agent
72.45% <ø> (ø)

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.77% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.55% <ø> (ø)


Upgrade hive_crdt

Related issue https://github.com/cachapa/tudo_client/issues/19

Unfortunately it's not as trivial as simply upgrading the package version, otherwise I'd have done it myself (I'm the maintainer of both crdt and hive_crdt).
Performing this change would break the hive stores in every device where the app is already in use, and migration isn't trivial.

Thanks for explaining, I wan un able to run the project (new install) with the old version, and I had to upgrade it.
Is it possible to migrate the local Hive db, I know that Hive does not support migrations by default, but still is the data migrate able?

Sorry I missed this update.
To be honest I've been playing around with CRDTs in another project and am coming to the realization that Hive is the wrong backend for this use case since CRDTs grow monotonically, which makes Hive slower and more memory hungry over time.
I'm currently experimenting with sqlite as a backend, and it seems to work better. If I have the time, I'll publish a hive_sqlite package at some point.

Closing this as the PR is now outdated


Fix handling of RETRIES parameter

Currently, the library tries to execute a request at most RETRIES-1 times.
With the default value of RETRIES=2, you can get errors when making a new request after the server or OS has closed the socket.
With this fix, the request will be tried up to RETRIES times.

I am also effected by this bug - how about merging it?


Kaleido fails to save image with fig.write_image()

Hi,
My issue looks like the #148, but it is more general.
While working perfectly 2 months ago, kaleido did not work anymore for graph export.
In the following exemple, my fig is well plotted, the html is well generated, but the third ligne is not working (no message error, but a endless computation).
fig.show()
fig.write_html(os.path.join(folder_out, dataset_name + '_graph_monthly.html'))
fig.write_image(monthly_graph_file)
If I interrupt the kernel, I have the following error

What is surprising is that the function worked earlier (month ago) with the same environnment.
What is more surprising is that, today, it worked once, but then it doesn't work anymore. Seems randomly.
Today, I had my firewall (Windows defender ) automaticaly updated on my pro computer, but I don't know if it is related.
I tried to open the generated html fig before running the write_image but that's not that
I work with
Python 3.11.5
conda version 23.7.1
python-kaleido   0.2.1 installed with conda-forge

Same issue here on Linux:
I create a virtual env with conda:
conda create -n "tmpenv_py12" python=3.12 jupyter ipykernel numpy plotly python-kaleido

And when I execute the following code in a notebook:
import numpy as np
import plotly.graph_objects as go
import plotly, ipykernel, kaleido

print(f"plotly: {plotly.__version__}")
print(f"kaleido: {kaleido.__version__}")
print(f"ipykernel: {ipykernel.__version__}")

n = 20000
x = np.arange(n)
noisy_sine = (3 + np.sin(x / 2000) + np.random.randn(n) / 10) * x / (n / 4)

fig = go.Figure()
fig.add_traces(
    [
        {"y": noisy_sine + 2, "name": "yp2", "type": "scattergl"},
        {"y": noisy_sine - 3, "name": "ym1", "type": "scatter"},
    ]
)
fig.write_image("tmp.png")

Then I have the following error: ValueError: Failed to start Kaleido subprocess. Error stream:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[2], line 23
     16 fig = go.Figure()
     17 fig.add_traces(
     18     [
     19         {"y": noisy_sine + 2, "name": "yp2", "type": "scattergl"},
     20         {"y": noisy_sine - 3, "name": "ym1", "type": "scatter"},
     21     ]
     22 )
---> 23 fig.write_image("tmp.png")

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/plotly/basedatatypes.py:3829, in BaseFigure.write_image(self, *args, **kwargs)
   3769 """
   3770 Convert a figure to a static image and write it to a file or writeable
   3771 object
   (...)
   3825 None
   3826 """
   3827 import plotly.io as pio
-> 3829 return pio.write_image(self, *args, **kwargs)

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/plotly/io/_kaleido.py:267, in write_image(fig, file, format, scale, width, height, validate, engine)
    251             raise ValueError(
    252                 """
    253 Cannot infer image type from output path '{file}'.
   (...)
    261                 )
    262             )
    264     # Request image
    265     # -------------
    266     # Do this first so we don't create a file if image conversion fails
--> 267     img_data = to_image(
    268         fig,
    269         format=format,
    270         scale=scale,
    271         width=width,
    272         height=height,
    273         validate=validate,
    274         engine=engine,
    275     )
    277     # Open file
    278     # ---------
    279     if path is None:
    280         # We previously failed to make sense of `file` as a pathlib object.
    281         # Attempt to write to `file` as an open file descriptor.

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/plotly/io/_kaleido.py:144, in to_image(fig, format, width, height, scale, validate, engine)
    141 # Validate figure
    142 # ---------------
    143 fig_dict = validate_coerce_fig_to_dict(fig, validate)
--> 144 img_bytes = scope.transform(
    145     fig_dict, format=format, width=width, height=height, scale=scale
    146 )
    148 return img_bytes

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/kaleido/scopes/plotly.py:153, in PlotlyScope.transform(self, figure, format, width, height, scale)
    142     raise ValueError(
    143         "Invalid format '{original_format}'.\n"
    144         "    Supported formats: {supported_formats_str}"
   (...)
    148         )
    149     )
    151 # Transform in using _perform_transform rather than superclass so we can access the full
    152 # response dict, including error codes.
--> 153 response = self._perform_transform(
    154     figure, format=format, width=width, height=height, scale=scale
    155 )
    157 # Check for export error, later can customize error messages for plotly Python users
    158 code = response.get("code", 0)

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/kaleido/scopes/base.py:293, in BaseScope._perform_transform(self, data, **kwargs)
    284 """
    285 Transform input data using the current scope, returning dict response with error code
    286 whether successful or not.
   (...)
    290 :return: Dict of response from Kaleido executable, whether successful or not
    291 """
    292 # Ensure that kaleido subprocess is running
--> 293 self._ensure_kaleido()
    295 # Perform export
    296 export_spec = self._json_dumps(dict(kwargs, data=data)).encode('utf-8')

File ~/miniconda3/envs/tmpenv_py12/lib/python3.12/site-packages/kaleido/scopes/base.py:198, in BaseScope._ensure_kaleido(self)
    193 if not startup_response_string:
    194     message = (
    195         "Failed to start Kaleido subprocess. Error stream:\n\n" +
    196         self._get_decoded_std_error()
    197     )
--> 198     raise ValueError(message)
    199 else:
    200     startup_response = json.loads(startup_response_string)

ValueError: Failed to start Kaleido subprocess. Error stream:

[0314/110840.788795:WARNING:resource_bundle.cc(431)] locale_file_path.empty() for locale
[0314/110840.793322:WARNING:resource_bundle.cc(431)] locale_file_path.empty() for locale
[0314/110840.793323:WARNING:resource_bundle.cc(431)] locale_file_path.empty() for locale
Received signal 7 BUS_ADRERR 7feace9a6000
#0 0x55967f7aad79 base::debug::CollectStackTrace()
#1 0x55967f728633 base::debug::StackTrace::StackTrace()
#2 0x55967f7aa95b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fead1e54520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
#4 0x55967d914f47 FT_Stream_ReadULong
#5 0x55967d94621b sfnt_open_font
#6 0x55967d941990 sfnt_init_face
#7 0x55967d950079 tt_face_init
#8 0x55967d915bbb open_face
#9 0x55967d910b23 ft_open_face_internal
#10 0x55967d910950 FT_New_Face
#11 0x55967fd5659c IA__FcFreeTypeQueryAll
#12 0x55967fd5367d FcFileScanConfig
#13 0x55967fd539b6 FcDirScanConfig
#14 0x55967fd53afa FcDirCacheScan
#15 0x55967fd53bae IA__FcDirCacheRead
#16 0x55967fd4a027 FcConfigAddDirList
#17 0x55967fd49f67 FcConfigBuildFonts
#18 0x55967fd57c81 IA__FcInitLoadConfigAndFonts
#19 0x55967fd49422 FcConfigInit
#20 0x559680052287 gfx::GetGlobalFontConfig()
#21 0x55967e1406f5 content::BrowserMainRunnerImpl::Initialize()
#22 0x559680c127b7 headless::HeadlessContentMainDelegate::RunProcess()
#23 0x55967f491f3e content::ContentMainRunnerImpl::RunServiceManager()
#24 0x55967f491b76 content::ContentMainRunnerImpl::Run()
#25 0x55967f48f374 content::RunContentProcess()
#26 0x55967f48fcfc content::ContentMain()
#27 0x55967f4e1182 headless::(anonymous namespace)::RunContentMain()
#28 0x55967f4e1025 headless::HeadlessBrowserMain()
#29 0x55967d4fffa8 main
#30 0x7fead1e3bd90 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x29d8f)
#31 0x7fead1e3be40 __libc_start_main
#32 0x55967d4f93ea _start
  r8:<PHONE_NUMBER>000000  r9:<PHONE_NUMBER>000000 r10:<PHONE_NUMBER>000002 r11:<PHONE_NUMBER>000293
 r12: 000024a917438800 r13:<PHONE_NUMBER>000000 r14: 00007ffcca38ddc4 r15: 00007feace9a6000
  di: 000024a9174d0280  si:<PHONE_NUMBER>000000  bp: 00007ffcca38dbc0  bx: 000024a9174d0280
  dx: 00007ffcca38dea8  ax:<PHONE_NUMBER>000000  cx: 00007ffcca38de68  sp: 00007ffcca38dba0
  ip: 000055967d914f47 efl:<PHONE_NUMBER>010206 cgf: 002b000000000033 erf:<PHONE_NUMBER>000004
 trp:<PHONE_NUMBER>00000e msk:<PHONE_NUMBER>000000 cr2: 00007feace9a6000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

Do you have any idea where it might come from ?
Any help would be much appreciated!

Fixed by reverting to version 0.1.0.post1
pip install "kaleido==0.1.0.post1"

I've only changed my connexion from WIFI to regular wire and then fig.write_image() worked again.
I don't know if it is the reason why, but for sure I did'nt change my environnement neither my kaleido version (still 0.2.1)

Thanks for your interest in Kaleido. We are currently working on an overhaul that might address your issue - we hope to have news in a few weeks and will post an update then. Thanks - @gvwilson


Integrate an Editor for the app for article content.

Implement something like this, but better aesthetically

closing as this is completed, using React quill

closing as this is completed, using React quill


Communication Resource | API Version Update

Contributing to the Azure SDK

Updating CommunicationServices API version to '2023-03-31' since the previous API version : 2020-08-20-preview is obsolete, and recently removed from support.
Updating resource type 'roleAssignments' in the namespace 'Microsoft.Authorization' to latest api version : '2022-04-01'.

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - Azure.Communication.Identity - tests


hubble/recorder: Extend the API to allow stopping a recording automatically

This implements a feature to stop a recording as soon as one of
three optional stop conditions are hit. If a stop condition is hit, the
RecordingStoppedResponse is sent to the client the same way
it would if the client requested an explicit stop request.
The StartRecording API message is extended with a new (optional) StopCondition field:
// StopCondition defines one or more conditions which cause the recording to
// stop after they have been hit. Stop conditions are ignored if they are
// absent or zero-valued. If multiple conditions are defined, the recording
// stops after the first one is hit.
message StopCondition {
    // bytes_captured stops the recording after at least this many bytes have
    // been captured. Note: The resulting file might be slightly larger due
    // to added pcap headers.
    uint64 bytes_captured = 1;
    // bytes_captured stops the recording after at least this many packets have
    // been captured.
    uint64 packets_captured = 2;
    // nanoseconds_elapsed stops the recording after this duration has elapsed.
    uint64 nanoseconds_elapsed = 3;
}

We ensure that the stop conditions are hit as early as possible,
to avoid writing more bytes or packets than necessary.
While this can also be implemented client-side by observing the
statistics of the running recording and issuing an explicit stop
request, it can be useful to implement some basic stop conditions
server-side as a fail-safe in case the client becomes unresponsive but
is still connected.

test-me-please

test-1.19-5.4 hit #16473 - which is about to be fixed, so I will restart the tests after I addressed the above feedback.
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-5.4/736/testReport/junit/Suite-k8s-1/19/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/

/mlh new-flake Cilium-PR-K8s-1.19-kernel-5.4

test-me-please


meltano add files docker does not add Dockerfile

Migrated from GitLab: https://gitlab.com/meltano/files-docker/-/issues/4
Originally created by @paul.tiplady on 2021-01-21 23:26:55

Running on meltano==1.66.0, I ran meltano add files docker
Expected behavior: I get a Dockerfile in the project root.
Actual behavior: I don't get any new files.
Command output:
> meltano add files docker
Adding file bundle 'docker' to your Meltano project...
Repository:     https://gitlab.com/meltano/files-docker

Installing file bundle 'docker'...
Adding 'docker' files to project...
Installed file bundle 'docker'

To learn more about file bundle 'docker', visit https://gitlab.com/meltano/files-docker

View 5 previous comments from the original issue on GitLab


feat(entry_maker): highlight results with treesitter

Enable treesitter highlighting of results buffer. In practice, I don't notice any slowdown
Known issue: scratch buffer when nvim is opened does not get closed
@delphinus @otavioschwanck I would greatly appreciate if you hop on this branch and give it a whirl for feedback! Thanks in advance if you do so :) Though I'll plan on making the feature opt-in anyways.
Needs results_ts_hl = true in config.

am i dreaming ? Awesome feature!

@fdschmidt93 i throws an error when i tried to grep:
[telescope] [WARN  18:11:47] /Users/otavio/.local/share/nvim/lazy/telescope.nvim/lua/telescope/pickers.lua:642: Finder failed with msg:  ....nvim/lua/telescope/_extensions/egrepify/entry_maker.lua:100: attempt to call field 'iter' (a nil value)

Ah, that's a nightly API. Will change that. Thanks!

Ideally fixed now!

Ideally fixed now!

The performance is awesome! working great now!
A possible improvement is the "match" highlight.  When the highlight happens, it loses the colors.  The ideal is just change the background or something like that:

When typing to search a term in a big project, it slows considerable (when return 1000 results or more), its pretty common to  happen.  i think the idea here is to add the highlight for the first 50 matches or something like that

A possible improvement is the "match" highlight. When the highlight happens, it loses the colors. The ideal is just change the background or something like that:

I'm not sure I 100% follow. If I understand you correctly:

treesitter highlights and TelescopeMatching cannot intersect for the time being. Not sure if it's possible but that would require a telescope PR which I surely won't do
TelescopeMatching needs to be set by the user

So long story short, very likely not possible right now.

For my big project, it slow considerable for some reason. could have an option to just add the highlight for TS for the first X matches, what you think fdschmidt93 ?

Right now it only tries to highlight entries that appear in your results list and caches highlights for those files.
One approach would be to increase some debounce (in ms) to the picker so the results entries don't get rerendered too often so the load is a bit spread out.
Common slow downs I'd expect:

very large files need to be parsed (parsing must be synchronous)
too many files to shortly (writing in prompt causes many files to appear in results -- addressable with debounce
We could parse highlights from the parse tree line by line, though I'd do that in a follow-up PR maybe

Highlight parsing is probably the one that could be most improved. Might do it in a follow-up PR.

i found another bug @fdschmidt93 , sometimes, after you select the file, it open the file without highlight

Nice! It seems to work fine for me. I can check results more clearly. I will test for a while.

I've been using recent months, and really been satisfied with this. Can you merge this? @fdschmidt93

I'll merge this since it's opt-in anyways but I won't have any time to work/improve this myself until some time in August, to be honest :sweat_smile:
But I trust your stress-testing @delphinus


Config fix

Description of the change
Given helm chart pulling the latest config and release is not yet synced
Applicable issues

fixes #

Additional information

Checklist

[ ] All tests were successful.
[ ] Unit tests added.
[ ] Documentation updated.

LGTM. Note this will break current dev branch (e2e tests will fail) since dfimagetools was updated with this change. We will add this change back prior to the next release.


Fix Ukrainian translation

🤔
There is a problem with eslint. If you use yarn it resolves packages correctly. But if you use npm install it fails. As I see in build log Travis uses npm.
There is a link with more details: https://github.com/babel/babel-eslint/issues/681


disable service worker on prod

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@Angryman18 Let's put this one in the "Draft" mode. We can spring it back to PR mode when we are sure, we need a review to merge.

yup sure.

Just made it draft

@Angryman18 What do we do about this one?

please assign this to someone else.

Donot beed this anymore


Using Bun.build will result into errors when running the output.

If you build a project with bun using this package, you can't run the built file.
How to reproduce

Create a project using elysia and the elysia-html plugin.
Compile the project

bun build --target=bun ./src/lambda.ts --outfile=lambda.js

Try to run the project

bun lambda.js

This will result into

32 | var require_html = __commonJS((exports, module) => {
33 |   __export(exports, {
34 |     toKebabCase: () => {
35 |       {
36 |
37 |         return $toKebabCase;
                  ^
ReferenceError: Can't find variable: $toKebabCase
      at toKebabCase (/Users/awilderink/code/bun-lambda/lambda.js:37:15)

This could also be an issue with bun build or @kitajs/html.

await Bun.build({
	entrypoints: ['./src/index.tsx'],
	outdir: './dist',
	target: 'bun',
})

Same issue for me using a build.ts file and bun build.ts

I found the issue. @kitajs/html is imported through require statements. This should be fine, but bun probably builds this wrong (maybe an issue should be created but I'm not sure how to describe it). You can fix it by swapping the require statement for imports. I want to submit a PR but the repo won't let me.
Here are the changes
// index.ts
...
import { createElement, Fragment as F } from  '@kitajs/html'
globalThis.ElysiaJSX = createElement
// @ts-ignore
globalThis.ElysiaJSX.Fragment = Fragment

export const Fragment = F as unknown as Component

export default html
...

and
// declaration.ts
// remove all of the following since they have been moved to index.ts (imports in declaration files will make them not globally available, see https://stackoverflow.com/a/51114250)

// @ts-ignore
const { createElement, Fragment } = require('@kitajs/html')

// @ts-ignore
globalThis.ElysiaJSX = createElement
// @ts-ignore
globalThis.ElysiaJSX.Fragment = Fragment

Hey @awilderink. After this change, does this problem still occurs?

Seems to be a issue with CJS syntax when using the bun bundler: https://github.com/oven-sh/bun/issues/5654

I'm releasing a fix for @kitajs/html asap. But it will keep incompatibilities with https://github.com/elysiajs/elysia/issues/178.


Optimization of the MaxMin diversity picker

A contribution from Roger.
The speedup is pretty dramatic.

@greglandrum Minor issues, it looks good, I'm happy to test it.  Is there a reference for this method besides Roger's head?

I'll make those changes.
Done a fair amount of testing already : making sure it generates the same results as the old stuff and that it's faster (which it certainly is).
Roger didn't provide a reference. :-)


sqlx prepare doesn't handle LEFT JOIN missing

Here's a simple example:
CREATE table a (
b_id int,
name text
);
CREATE table b (
id serial,
value text
);

I'd like to select something from a, along with b's value it reference to.
    let res = sqlx::query!(
        "
    SELECT a.*, b.value as b_value FROM a LEFT JOIN b on a.b_id = b.id WHERE a.name = $1
    ",
        "some_name"
    )
    .fetch_one(&pool)
    .await
    .unwrap();
    println!("{:?}", res.b_value);  // <-- should be `Option<String>`, but is inferred as `String`

The left join may miss, e.g. when the b_id field is null, and in such circumstances the b_value should be None. However the json file sqlx-cli generated doesn't handle that. Instead, it generates:
{
  "db": "PostgreSQL",
  "67c41c612f8f93d589939fd8f56313cd05cb602d25b0925263d33e4df8db6751": {
    "query": "\n    SELECT a.*, b.value as b_value FROM a LEFT JOIN b on a.b_id = b.id WHERE a.name = $1\n    ",
    "describe": {
      "columns": [ ... ],
      "parameters": {
        "Left": [
          "Text"
        ]
      },
      "nullable": [
        true,
        false,
        true,
        false
      ]
    }
  }
}

It says that the last column, b_value, is not nullable.
Thanks :)

This is a duplicate of #367 and is being worked on in https://github.com/launchbadge/sqlx/pull/566

Thank you for a detailed reproduction however. More test cases are always helpful.

Ok, thanks for the quick reply

BTW this issue only happens after we migrate to sqlx-cli prepare. Query macros from sqlx 0.3 seems to work fine.


More granular token types

Motivation
This ties into #2849. There are a few token types that are missing right now and languages usually approximate. I.e. TOML has a date token type and all tokens have a number alias for coloring.
Description
A few new token types, I would like to suggest:

[ ] time (or date or date-time): A type for dates, times, and other time instances.
We have a few languages that contain literals for dates and times. Right now, most of them use the number type.
[ ] character (or char): A type for character literals.
Some languages support literals for string and characters (e.g. C/C++, C#, Java, Rust, Scheme). Themes should be able to give these literals a different color.
[ ] ip-address (or ip-addr or ip): A type for IPv4 and IPv6 addresses.
Some languages support IP address literals.
[ ] attr-assign: A token used to assign an attribute value to an attribute name.
Some people what to highlight the assignment operator of attributes differently (example).
[ ] doc: An alias for different types to indicate that a string or comment is used for documentation (e.g. JavaDoc comments or Python docstrings). E.g. /** foo */.

ip-address
I would assume you tag these as number now (as we do)... so if you moved forward with adding this would an IP address become exclusively tagged as ip-address (breaking existing themes) or would it now be a number ip-address or number.ip-address?

IP addresses are usually aliased with url right now IIRC. Removing that alias wouldn't be too bad of an idea.
char is intended as an addition to and not a replacement of string.

breaking existing themes

That's true. I will need to think of a solution for that.


I can't find the key[label] in data_json file.

Hello, I want to know that what's the label and the format of it. I can't get it because there is no key[label] in data_json file.

Oh. Sorry, it is a mistake. Due to my recent contraction of COVID-19😨, I will promptly make the necessary updates as soon as I am able to resume work.
For the time being, you may simply delete this line and its corresponding key-value in the dictionary.


chore: update dependencies

This is still interesting to me. @mariocao can you rebase?

#22 was supposed to get this merged on master, but some later commit must have produced a regression.


Build from source with python3.7 failed(prototype changed)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):N
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):arch
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):1.10.0
Python version:python-3.7
Bazel version (if compiling from source): 0.15.2
GCC/Compiler version (if compiling from source): gcc-7
CUDA/cuDNN version:cuda-9.2,cudnn-7.1
GPU model and memory:24G
Exact command to reproduce:

build from newest source with Python3.7 failed at
external/protobuf_archive/python/google/protobuf/pyext/descriptor_containers.cc:69:42: error: invalid conversion from 'const char*' to 'char*'
As the https://docs.python.org/3.7/c-api/unicode.html#c.PyUnicode_AsUTF8AndSize said
Changed in version 3.7: The return type is now const char * rather of char * for PyUnicode_AsUTF8AndSize() prototype
Maybe you should update it accordingly.

https://github.com/tensorflow/tensorflow/issues/20690

As this is the first hit on google, the solution is here: https://github.com/protocolbuffers/protobuf/pull/4862/files


Setup the TypeScript codebase for the Discord bot

Let's initialize the TypeScript code for the discord bot.
PS - you can create a Draft pull request to prevent duplicate work.

this is done, i guess


I114 update scripts part 1

LCA embodied working

shall we merge it? have you tested it well?

What do you mean "tested well?" Is there a way to test it bad? Please elaborate if there is an specific way...
Sent on the road

On 13.04.2016, at 20:24, Daren Thomas<EMAIL_ADDRESS>wrote:
shall we merge it? have you tested it well?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

yes. badly: just test the part you changed. push it to master. break the tool for everyone else.
good: first always update from master. then test the script with the test script. is the output correct? can others verify the output is correct? (communicate what the output should be)
does the other functionality still work? (i will create a master test script to run on a separate computer once a day to make sure master is always running). did you run the script from arcgis?
so. basically this. we are still a young project so this hasn't been formalized yet. we will probably write down a test procedure in the dev docs soon.
remember the time i refactored and the output was wrong and you had to roll back my changes? i'm trying to avoid this in the future...

then it was well done :-), however as part of the board i believe we should be mutually be exchanging this task of merging and re-testing.
i.e., if you do and pull a request. you should have tested it in your machine. To cross-check i will test it in mine before accepting your pull request. if everything is fine then i approve your merge. this is only for what modifies the core. for new things we are testing, we use the SandBox instead in the master.
we do this to each other's code. then we avoid what happened last time. It completely worked in your machine but not in mine.
what do you think?

From: Daren Thomas<EMAIL_ADDRESS>Sent: Thursday, April 14, 2016 7:48 AM
To: architecture-building-systems/CEAforArcGIS
Cc: Jimeno Fonseca
Subject: Re: [architecture-building-systems/CEAforArcGIS] I114 update scripts part 1 (#143)
yes. badly: just test the part you changed. push it to master. break the tool for everyone else.
good: first always update from master. then test the script with the test script. is the output correct? can others verify the output is correct? (communicate what the output should be)
does the other functionality still work? (i will create a master test script to run on a separate computer once a day to make sure master is always running). did you run the script from arcgis?
so. basically this. we are still a young project so this hasn't been formalized yet. we will probably write down a test procedure in the dev docs soon.
remember the time i refactored and the output was wrong and you had to roll back my changes? i'm trying to avoid this in the future...
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/143#issuecomment-209773350

i think this is a very good plan. let's call it the four-eyes-principle!

and write it down in the dev docs!

and write it down in the dev docs!

Jimeno, I can't merge this, because of merge conflicts that I can't resolve. I don't know which branch contains the newest version of solar_radiation_vertical... You know what? I'm just going to assume that the version in master is newer than the one on the branch for the merge...


strategy?

Hey all!!
I'm just now getting into writing up a course borrowing content for version 1.0 WDL from this repo.  The things I'm seeing thus far that are causing a little angst for me that I thought I'd share on the off chance you're game to adjust are these:

References to the "next section" in the markdowns make it hard to borrow the content.
if the images in the markdowns were not relative links but fill URLs then they might have a chance of rendering when I borrow the markdowns.
I'm not seeing a separate chunk about defining workflow outputs (not task outputs, but maybe I'm just missing it?)
It'd be nice to break up the bits maybe a little smaller - so for example the linear chaining section is great, but I may not want to put that example right after the material - breaking those into two would be more modular.
I find I want to use the base_structure markdown but it could be broken into three parts - the base structure chunk, then the "top level" chunk then the "core level " chunk.

Not sure if this is useful at all @vdauwera but if it is, great!  I realize this work is not 100% anyone's focus so I'm happy to help make these changes but I also don't want to get in the way/step on toes b/c I know you all are actively working on this too.  ;)

Thanks @vortexing. We're still in the process of updating the docs on the 1.0 branch to markdown/1.0 spec. We expect to finish by December. I think that will address some of the Next Section concerns. As for the article length suggestions, those are great! As soon as the docs are updated to 1.0, we can start fixing that.

@vortexing We actually wanted to get your thoughts about the overall organization and strategy. Right now, we're using the 1.0 branch to update docs that are currently on Terra Support. We were thinking that all documentation would live in the Docs folder and that we would use that to standup a readthedocs.
I think we had planned to merge docs that are most up to date to main. So in this case, the 1.0 branch would be merged to main.
If we were to make images full length URLs, what branch should we point to for the images? Should we always point to the spec branch that we're updating from?
We're also hoping that by using the readthedocs, we can group certain articles together. The reason some of the articles have a Next Section is because they were grouped together on Terra Support, and I think we'd like to group them together again. We also have some new docs, Cookbook uses cases, and some Best Practices. We'd like to group those docs together too.
Do you have any thoughts about these organization strategies?

I do have some thoughts but they are more "collaborative" thoughts than specific things to suggest.  I think that the readthedocs approach is very similar to the OTTR/cow borrowing chapters approach for the training materials we'll be making so I think what's good for one will be good for the other.
I'm not sure about full length URLs - I guess that would need to be the main branch later (which means it'll be broken until A version gets merged into main.
I do, however, like having the versions be separate or something.  I wonder if we could come up with a creative way to use frontmatter or even visible text to be very explicit in the markdown chunks which version we're discussing.  Hopefully soon 1.1 will get supported by Cromwell and then I too will want to have additional 1.1 features documented and available to put into 1.1 oriented coursework.
Happy to have this convo a bit offline too - or even in a quick call sometime so we can get going on how we can help each other?  Drop me an email anytime and we'll schedule it.

Convo had offline!!!  Readthedocs is ALIVE!!!!!!


doc(test): Add the test command line in readme and how to use it

📑 Description
I needed to read the code to understand how to run the tests.
This commit will directly show in the README how to set the Bunny's credentials.
✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

Some phrasing and formatting changes needed

This looks fine