Add support for SQL Server Database Projects

**Closes #178

This adds a new hosting integration for deploying SQL Server Database Projects to a SqlServerDatabaseResource in an Aspire AppHost project. See #178 for all the details.

PR Checklist

[x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
[x] Based off latest main branch of toolkit
[x] PR doesn't include merge commits (always rebase on top of our main, if needed)
[x] New integration

[x] Docs are written
[x] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)

[x] Tests for the changes have been added (for bug fixes / features) (if applicable)
[x] Contains NO breaking changes
[x] Every new API (including internal ones) has full XML docs
[x] Code follows all style conventions

Other information

It seems that CI is failing with a timeout, but that appears to be on something I haven't touched in this PR

I think the OpenWebUI tests are having some problems. I'm looking at the presently (seems OpenWebUI is broke in main as well which would result in inconsistent test runs)

@aaronpowell Thank you so much for the review, really appreciate it. I think I've processed all the comments.

@jmezach @ErikEJ are you two happy to be the maintainers of this integration long term? If so, I'll add you to the team and set you up as the code owners.

Absolutely!

@aaronpowell Most definitely.
I was also thinking we should maybe add a .sqlprojx and the old .sqlproj format projects to the examples and incorporate those into the integration tests. But I guess we can do a follow up PR for that later.

I wonder if .sqlprojx is just a point in time extension? Maybe @sysadmindrew knows?
But definitely ADS / VS code.sqlproj examples (ADS supports two .sqlproj formats)

Yeah let's add those as additional PR's, that way we have a known good baseline, and anything else is additional

Re:.sqlprojx file extension
this extension was only for 17.12 preview 2, by the time preview 3 was released .sqlprojx was replaced with .sqlproj using Microsoft.Build.Sql

@dzsquared never knew that! Great news - now we just need side by side / migration tool/docs

@aaronpowell When will the NuGet package get published?

Hopefully soon, we have a few manual tasks that have to be done before they are on nuget.


[PowerToys Run] doesn't find "file explorer"

Environment
Windows build number: Microsoft Windows [Version 10.0.19624.1000]
PowerToys version: 0.18
PowerToy module for which you are reporting the bug (if applicable): PowerToys Run

Steps to reproduce

enter "file explorer"
or "explorer"

Expected behavior
the application "File Explorer" should show up in the result list.
or is it intentionally filtered out?
Actual behavior

no results at all

Internet Explorer shows up

Screenshots

actually I didn't find Windows Terminal too.

terminal it 100% should.  did you install terminal maybe after PT was running?  trying to figure out flow

Doesn't find Docker for me. The only available results are .lnk files on the desktop and in start menu as well as Dockerfiles in my projects.
Also, typing in Chrome for some reason results in Google Chrome being the 3rd result, and the first one is Postman for some weird reason.

Doesn't find Docker for me. The only available results are .lnk files on the desktop and in start menu as well as Dockerfiles in my projects.
Also, typing in Chrome for some reason results in Google Chrome being the 3rd result, and the first one is Postman for some weird reason.

Doesn't find Docker for me. The only available results are .lnk files on the desktop and in start menu as well as Dockerfiles in my projects.
Also, typing in Chrome for some reason results in Google Chrome being the 3rd result, and the first one is Postman for some weird reason.

Sure!

The first result's path is to the desktop shortcut, next one to the vscode extension, then there is one pointing to the shortcut in the main(start) menu, and finally a Dockerfile from one of my projects.
No actual docker desktop application here.

Notice how the final result for chrome is also pointing to the .lnk file.
Perhaps it would be useful to add a configuration file similar to .gitignore format, so the users could filter out some directories/filetypes?
Also it doesn't seem that the matcher prioritizes applications instead of random files, which it probably should.

terminal it 100% should. did you install terminal maybe after PT was running? trying to figure out flow

@crutkas I don't think so. I update terminal from windows store 1st then install PT msi. Otherwise I already restart my windows too, and it still can't find terminal (and ofc windows explorer too).
It only find already running instances.

I found it doesn't find Chrome when I type "chrome" . If I type "google c" then Chrome comes up. Other applications seem to pick up if the typed word is anywhere inside the application name (e.g. Edge is listed as "Microsoft Edge" but comes up when I type "edg"

Also it cannot find Docker app

Doesn't find Code

Wox result:

I am experiencing a similar issue.  The Launcher is not finding Slack, Discord, Webex Teams.  I have manually kicked off a reindex and restart the machine without luck.

so there are a hybrid of issues inside this bug here.

finding explorer, i think this was dedup code that may have been too aggressive.
localized file paths <- fixed.  that would resolve @dimonkov and some of @EdgarVaguencia issues
looks like maybe we can't see Code due to how it was installed on a non-C drive?  would love to know the if that has an item on the start menu

Same problem!

On my machine don't show firefox and whole apps installed using scoop. In menu start everything is ok.

terminal it 100% should. did you install terminal maybe after PT was running? trying to figure out flow

@crutkas I don't think so. I update terminal from windows store 1st then install PT msi. Otherwise I already restart my windows too, and it still can't find terminal (and ofc windows explorer too).
It only find already running instances.

My PowertoysRun does find Terminal.
https://i.imgur.com/kMFqSgu.png

My PowertoysRun does find Terminal.
https://i.imgur.com/kMFqSgu.png

That is a running instance.

My PowertoysRun does find Terminal.
https://i.imgur.com/kMFqSgu.png

Correction: oops the imgur link does, I thought their link was the screenshot you can view on github.

Something is funky here and we need to figure it out. We have some theories.

Sorry for the confusion, I just got used to using imgur everywhere rather than relying on every sites own image upload. Also regarding that other user with Chrome being in the 3rd place, for me it is in 1st place with "Google Chrome.lnk" being 3rd

Doesn't find Code

Wox result:

Mine does find VSCode when searching for "Code", it also does find Discord, Teams etc. It does not find explorer (returns IE) but does other system stuff like MSPaint.
Some weird indexing going on there

There are a hybrid of bugs here.  Explorer is a known issue (and logged) from my crappy deduping code.  Smarter people on the team is working on.

The top image bug is fixed and is in 0.18.1
The interesting thing with the bottom image is their code path is installed on their G drive. In theory that shouldn't matter but a good question then becomes was that installed or just a standalone exe on a removable drive they are leveraging.  @EdgarVaguencia how is Code installed on your machine?

the G drive is a partition, the different thing is that i don't create shortcut on start menu, but i add the path in environment variables

Also newly installed applications are not available like in my case Slack.

Also newly installed applications are not available like in my case Slack.

I tried installing Slack through Choco and Powertoys Run picked up the .lnk file in my Start Menu. But again, as an LNK, not the "Win32 Application"

This issue has become a grab bag of bugs sadly.  We have a fix for the first issue here at the top, #3969 and created dedicated bugs for others in it.  We believe every bug listed here is documented.

It seems that Launcher does not look for applications in your PATH.

Unlike Start Menu which is working just fine.

fixed in 0.18.2 official release.  https://github.com/microsoft/PowerToys/releases/

Docker Desktop isn't showing up on 0.18.2, only the .lnk.

Docker Desktop isn't showing up on 0.18.2, only the .lnk.

Please file a new issue for tracking

I have the same issue and am on the latest version.


Send Photos Through Gifted Messenger

I added the option to send photos via the text input. The following props are required to show and send the photo.
      imagePicked= boolean (when set to true, the ShowSelectedPhoto component will be shown)
      imageToSend=string (url, file, or data, this will be displayed in the ShowSelectedPhoto component)
      getImage=function (called to get the data of the image,  ex. ImagePickerManager. Called when       clicking on the camera icon in the text input)
      dismissImageShowing=function (called to set imagePicked to false. This is called on the 'Cancel' button in the ShowSelectedPhoto component)

Can you send a git picture?

Hey @danielmka, I'm super interested in this feature, bummed to see you closed the ticket. Any particular reason why?

I'm interested as well!
Just to clarify: Sending images with the gifted messenger is not possible (yet) ?


Unable to change a single_internal_link if the referenced node has been deleted

Create an external link node
Create a new page with a template that has a single_internal_link content type
Select node created in 1 within a single_internal_link
Save page
Delete node created in step 1
Edit page created in step 2
XHR looking up the linked node returns a 404, "Select single internal link" modal has infinite loading animation

I think the problem is that the SingleInternalLink class uses the SimpleContentType. This means that the value is saved as simple string in PHPCR instead as a reference. If it would be a reference the property would be cleared, when the referenced node gets deleted.

Would changing this to a reference also cause the BC break described in #545 ?

Yeah exactly, that would be a BC break, but I don't see another good way to fix this... The data would not be the problem, it's quite easy to write migrations for that, would be a single command to update, but all the twig templates using this content type would have been to be updated...

currently this bug is partly fixed you can remove the wrong value or change it.the next question is should we use "weak" references here?

@danrot ... please validate if still is a bug and add a new issue for a clean solution with references. thx

The described problem does not occur anymore, and as long as the sulu:link tag is used to render it on the page there is also no error on the website when the page gets deleted. So I think we can consider this issue solved.
For the issue with the reference we still have https://github.com/sulu/sulu/issues/545


[py27] Remove last traces of py27

Codecov Report

Merging #392 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #392      +/-   ##
=========================================
- Coverage    90.4%   90.4%   -0.01%
=========================================
  Files          43      43
  Lines        2846    2845       -1
=========================================
- Hits         2573    2572       -1
  Misses        273     273

Impacted Files
Coverage Δ

django_q/core_signing.py
84.61% <ø> (-0.39%)
:arrow_down:

django_q/admin.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70269e1...edb61c4. Read the comment docs.

Hello @Koed00 despite the coverage reporting a lower score, I think this PR could be merged. What do you think ?
Regards


Added naive cache for gtk_images

Added a naive cache for GTK image generation. GTK images seem to be pretty good about loading/unloading themselves, so I think we can keep a big pile of them with relatively little memory implications. And if I'm wrong converting this to an LRU cache later shouldn't be difficult.

Totally forgot to mention why I did this. After first load grid view becomes essentially instant.

Coverage decreased (-0.43%) to 67.82% when pulling 7da432ec39ded48cd4bf6b901449b5f0481a50bb on campaul:cache_gtk_images into 15c1671142243f5a26df889d84042981e71cda41 on photoshell:master.

Very nice! That pretty much single handedly solved one of our biggest problems. I'm still testing, but it looks good so far. Will code review inline on the commit if I notice anything.


Alerts that refer to unready Providers don't recover automatically

Describe the bug
If you create a Provider that doesn't become ready soon due to misconfiguration—such as its referenced Secret not decrypting properly—and also create an Alert that refers to that Provider, the Alert does not notice when the Provider later becomes ready.
To Reproduce
Steps to reproduce the behavior:

Create a Provider that references a Secret that can't be decrypted (perhaps because the related Kustomization decryption configuration is incorrect).
Note that the the Provider is not ready.
Create an Alert that refers to that Provider.
Note that the Alert is not ready.
Correct the problem with the Provider (perhaps allowing its referenced Secret to be decrypted properly).
Note that the Provider is now ready.
Watch the Alert and note that it "never" becomes ready, or at least not within a reasonable amount of time.
Delete the Alert.
Create a replacement Alert.
Observe that the Alert becomes ready almost immediately.

Expected behavior
The Alert should watch or poll at a low interval the referenced Provider, and its own status should change shortly after the Provider's status changes.

Hey @seh ,
I tried to recreate this bug but the alert and provider were both initialized(with Ready set to True) after the secret was decrypted successfully and the secret applied to the cluster.

That's interesting. I haven't tried it again since first running into the problem, as my Secrets are now built correctly, satisfying the Providers from the start.
When you tried it, was the Secret absent entirely, or was it present but with invalid content? In my case, I had forgotten to configure the Flux Kustomization object's "spec.decryption" field properly, so I was winding up with the raw SOPS JSON content in my Secret.

In my case, it was absent entirely, I will try it with invalid content and see what happens.

Hey @seh, how were you able to apply the secret with the sops field in it(It gives a validation)? If I take it out, the kustomize-controller is unable to apply the secret(so it is still absent)
i.e
apiVersion: v1
kind: Secret
metadata:
    name: slack-url
    namespace: flux-system
sops:
    kms: []
    gcp_kms: []
    azure_kv: []
    hc_vault: []

Hey @seh, how were you able to apply the secret with the sops field in it(It gives a validation error)?

I thought I did, but perhaps I'm misremembering what had happened to put my Provider to be stuck and not become ready. I know it was due to the missing decryption parameters, but I don't remember whether the Secret object wound up existing or not.
If we can't reproduce the problem, we can close the issue. I mostly wanted to make sure the our controller the reconciles Alert objects does watch Providers, and that the controller for Providers watches Secrets. It behaved as if the the controller handling Alerts wasn't noticing changes to the referenced Provider.


Adding HostProvider

The HostProvider will allow getting hosts in runtime. Most likely, the provider should be passed to For method.

How you suggest use IHostProvider with DI? We should setup host on service.AddNClient(.....)

I think it can look like this:
serviceCollection.AddRestNClient(implementationFactory: (serviceProvider, builder) =>
{
    var hostProvider = serviceProvider.GetRequiredService<MyHostProvider>();
    builder.For<IMyClient>(hostProvider).Build();
});

Well... Maybe we already have this feature?
https://github.com/nclient/NClient/blob/main/tests/NClient.Extensions/NClient.Extensions.DependencyInjection.Tests/AddRestNClientExtensionsTest.cs#L73

Not quite. We can do for example like this:
serviceCollection.AddRestNClient(implementationFactory: (serviceProvider, builder) =>
{
    var hostProvider = serviceProvider.GetRequiredService<MyHostProvider>();
    var host = hostProvider.Get();
    builder
        .For<IBasicClientWithMetadata>(host)
        .Build()
});

This is similar to what I want, but the host provider will create the host only once, since the client is a singleton. Perhaps if we implement https://github.com/nclient/NClient/issues/449#issuecomment-1236070393, it will cover most of the needs. However, we should remember that clients can be created not only using DI.


[Behavior] mention-bot

mention-bot, which @mentions potential reviewers based on recent git history, works as a node module and should be relatively straight forward to turn it into a behavior.

Yes please.

After #90, this should be implemented as a separate plugin.


The generated file core.umd.js is not ES5

Issue description
When installing angular2-google-maps via npm, the file core.umd.js is not ES5.
Expected/desired behavior
core.umd.js is ES5 to support older devices
angular2 & angular2-google-maps version
latest stable

This would be a really nice patch. The package currently is unusable on CentOS 6.x.

So is the docu still valid?

The files located in the root dir are ES5 compatible files that can be consumed using CommonJS..
The files under /esm are ES5 based with ES2015 modules.

Yes,
see commit msg:
The files under `/esm` are ES5 (before: ES2015) based with ES2015 modules.
In the real world, this should not cause troubles.


MAPL standalone build appears to be broken

I checked out develop and tried to build MAPL on Discover.  So checkout the MAPL repo, go there checkout develop, then mepo clone, the source g5_modules, then build.
Note I've also tried this with main and v2.7.0
I'm getting a slew of errors when running the cmake command:
-- Detecting C compile features
-- Detecting C compile features - done
Traceback (most recent call last):
  File "/discover/swdev/gmao_SIteam/mepo/mepo", line 17, in <module>
    main()
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/main.py", line 6, in main
    command.run(args)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/command/command.py", line 11, in run
    cmd_module.run(args)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/command/init/init.py", line 17, in run
    allcomps = MepoState.initialize(args.config,style)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/state/state.py", line 58, in initialize
    raise StateAlreadyInitializedError('mepo state already exists')
state.exceptions.StateAlreadyInitializedError: mepo state already exists
fatal: destination path './@ESMA_env' already exists and is not an empty directory.

Traceback (most recent call last):
  File "/discover/swdev/gmao_SIteam/mepo/mepo", line 17, in <module>
    main()
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/main.py", line 6, in main
    command.run(args)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/command/command.py", line 11, in run
    cmd_module.run(args)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/command/clone/clone.py", line 68, in run
    git.clone(version,recurse)
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/repository/git.py", line 45, in clone
    shellcmd.run(cmd.split())
  File "/gpfsm/dswdev/gmao_SIteam/mepo/mepo.d/utilities/shellcmd.py", line 15, in run
    result.check_returncode()
  File "/usr/local/other/python/GEOSpyD/4.9.2_py3.9/2021-05-05/lib/python3.9/subprocess.py", line 460, in check_returncode
    raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '['git', 'clone', '--branch', 'v3.2.1', '--quiet', 'git@github.com:GEOS-ESM/ESMA_env.git', './@ESMA_env']' returned non-zero exit status 128.
CMake Error at CMakeLists.txt:37 (include):
  include could not find load file:

    esma

CMake Error at CMakeLists.txt:45 (find_package):
  By not providing "FindFLAP.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "FLAP", but
  CMake did not find one.

  Could not find a package configuration file provided by "FLAP" with any of
  the following names:

    FLAPConfig.cmake
    flap-config.cmake

  Add the installation prefix of "FLAP" to CMAKE_PREFIX_PATH or set
  "FLAP_DIR" to a directory containing one of the above files.  If "FLAP"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!
See also "/home/bmauer/swdev/models/mapl_fix_regrid/mapl_bare/MAPL/build/CMakeFiles/CMakeOutput.log".

Okay. I "fixed" this by fixing mepo. But I am also going to make a PR to fix this without the need to fix mepo.

Seems fixed


建议增加CMakelists.txt

我在阅读代码中，使用CLion时，安装Bazel插件，但这个插件对于网络代理好像有点缺陷。如果能使用CMakelists.txt，CLion会适配得比较好。对于代码高亮，引用的跳转都会比较方便。VS CODE下，也是多多少少有点类似的问题。（也有可能是我本身的开发环境设置的问题。）

thanks for your advice, as you know, to maintain a large project, we need to chose a good tools, maybe bazel is a better choice,
as mentioned, vs code has some drawback when we use it to jump during reading code, maybe really some setting is not properly correct, such as, the match rule you can use pattern match instead of default,
and meanwhile, we will consider supporting cmake after we evaluate it


Cluster template regression: binlog_format redefined later in template

Resolves #283

+1

@jharley thanks again! I have rebased this on top of the latest master and merged it in as #299.


Used the Optimizer - Audio Out of Sync

After using the optimizer, the game audio is out of sync about 2-3 seconds. Tried to restart game and pc and still out of sync. Tried to disable plugin and no luck.

That's pretty weird. Which plugin version are you using? Does it happen all the time? How long did the optimizer ran for / how badly it brick your machine? This process is pretty CPU intensive, but should leave some of processing power to game threads.
I can't repro anything like that, sounds for interacting with npcs are coming up in sync with ui popups.

I'm using the one for Dalamud plugin; XIVLauncher ver<IP_ADDRESS>. Looking at the instructions I'm using it through the experimental link. Running the optimizer, on average is just under a minute but at times as long as a minute and a half. Can definitely notice the CPU intensity as the game will stutter and sometimes freeze for a moment or two. Sounds like it just may be my CPU is not strong enough to run the game and the optimizer and causing the out of sync. One thing I still need to test is if i can get the in-game audio to fix without using XIVLauncher. For my CPU, it is a Inte I5-6600K.

Alright so figured it out, the dsync was caused by my audio source afterward. Once trying a different one, it's no as it should be. Just strange how that happened.

Heh, glad you've got it figured out then. I'll add a simple mode for optimizer - blind pick from top of card pools instead of checking various deck combos. Won't be as good, but then again, entire optimizer feature is of ekhm.. questionable accuracy. In match solver will make it work anyway.


queue option?

It'd be nice if there was an option to queue anime to download one after another
for example
I want to download FMA brotherhood followed by BNHA and the script automatically downloads BNHA after previous task is done

This might be helpful.  I use two files.
A script called "download.sh"
A URL list called "download.txt"
The content of "download.sh" is
#!/bin/bash
while IFS= read -r line
do
	anime dl $line -f -q 1080p -fq "['720p','480p','320p']" -xd "{aria2}"
done < "download.txt"

In the "download.txt", I add a list of URL's I want to download like this:
https://animewebsite/showname1
https://animewebsite/showname2

You can even append the episodes you want like this:
https://animewebsite/showname1 -e 12
https://animewebsite/showname2 -e 4:10

Save the files, and run:
$ ./download.sh

Perhaps others might find it helpful.


Strange issue with FromInstance

Hello,
I'm seeing a very strange behavior and was wondering if you might be able to shed some light on what's happening.
In my Unity3d game, I have written an AssetBundleManager that in the constructor downloads a bundle manifest, and then loads (from web or cache) bundles when requested. Pretty standard stuff.
I want this bundle manager injected where needed, so I did this:
Container.Bind<IAssetBundleManager>().FromInstance([INSTANCE HERE]).AsSingle()

Now comes the weird bit:
If I declare the instance directly in the FromInstance parameter
Container.Bind<IAssetBundleManager>().FromInstance(new AssetBundleManager("manifest_url")).AsSingle()

the next time I load ONE SPECIFIC bundle FROM CACHE (using either WWW.LoadFromCacheOrDownload or the newer DownloadHandlerAssetBundle) the app will crash on iOS with a stacktrace of Unity calls:
frame #0: 0x00000001029788c4 Scopa::LoadFileStream() [inlined] SetIsCachedFileStream at SerializedFile.h:270 [opt]
frame #1: 0x00000001029788c0 Scopa::LoadFileStream() at PersistentManager.cpp:2128 [opt]
frame #2: 0x00000001026a6f58 Scopa::TryToLoadAndInitializeAssetBundle() at AssetBundleLoadFromAsyncOperation.cpp:259 [opt]
frame #3: 0x00000001026a74f4 Scopa::IntegrateImmediately() at AssetBundleLoadFromAsyncOperation.cpp:194 [opt]
frame #4: 0x0000000102a0730c Scopa::GetAssetBundle() at DownloadHandlerAssetBundle.cpp:163 [opt]
frame #5: 0x0000000102a2e678 Scopa::DownloadHandlerAssetBundle_Get_Custom_PropAssetBundle() at DownloadHandlerBindings.gen.cpp:346 [opt]
frame #6: 0x000000010118ed50 Scopa::U3CStartU3Ec__Iterator0_MoveNext_m502268627(__this=0x00000001191eeb40, method=<unavailable>) at Bulk_Assembly-CSharp_16.cpp:6129 [opt]
frame #7: 0x0000000101fa9a40 Scopa::SetupCoroutine_InvokeMoveNext_m2975616245(__this=<unavailable>, ___enumerator0=0x00000001191eeb40, ___returnValueAddress1=<unavailable>, method=<unavailable>) at Bulk_UnityEngine_3.cpp:4166 [opt]
frame #8: 0x0000000102389d4c ScopaRuntimeInvoker_Void_t1841601450_Il2CppObject_IntPtr_t(method=<unavailable>, obj=<unavailable>, args=<unavailable>) at Il2CppInvokerTable.cpp:4758 [opt]
frame #9: 0x0000000102f39d24 Scopail2cpp::vm::Runtime::Invoke(method=0x00000001c4125a00, obj=0x0000000000000000, params=0x000000016ede15a8, exc=0x000000016ede16c8) at Runtime.cpp:497 [opt]
frame #10: 0x0000000102973418 Scopa::scripting_method_invoke() at ScriptingApi_Il2Cpp.cpp:213 [opt]
frame #11: 0x000000010296c068 Scopa::Invoke() at ScriptingInvocation.cpp:303 [opt]
frame #12: 0x000000010289d984 Scopa::InvokeMoveNext() [inlined] Invoke at ScriptingInvocation.h:72 [opt]
frame #13: 0x000000010289d974 Scopa::InvokeMoveNext() at Coroutine.cpp:235 [opt]
frame #14: 0x000000010289d5c8 Scopa::Run() at Coroutine.cpp:259 [opt]
frame #15: 0x000000010287688c Scopa::InvokeCoroutine() at AsyncOperation.cpp:18 [opt]
frame #16: 0x0000000102750da0 Scopa::Job_InvokeCoroutine() at WebRequestProto.h:108 [opt]
frame #17: 0x000000010286ef10 Scopa::ExecuteMainThreadJobs() at BackgroundJobQueue.cpp:84 [opt]
frame #18: 0x00000001028865f4 Scopa::PlayerLoop() at PlayerLoop.cpp:89 [opt]
frame #19: 0x0000000102ac7b70 Scopa::UnityPlayerLoopImpl() at LibEntryPoint.mm:221 [opt]
frame #20: 0x0000000101027d50 Scopa::UnityRepaint() at UnityAppController+Rendering.mm:268 [opt]
frame #21: 0x0000000101027c3c Scopa::-[UnityAppController(self=0x00000001c010e7c0, _cmd=<unavailable>) repaintDisplayLink]() at UnityAppController+Rendering.mm:77 [opt]

I tried recreating said bundle to make sure it wasn't corrupted, but that's not the issue.
I then tried to stop loading the bundles as soon as the app is loaded and instead waiting some time before loading the manifest (all bundle load requests will wait until the manifest is loaded).
To adapt this to my current code, I had to declare the bundlemanager instance outside the FromInstance call:
var abm = new AssetBundleManager("manifest_url");
Container.Bind<IAssetBundleManager>().FromInstance(abm).AsSingle();

I then planned to load the manifest after 1 second, but just by doing this the issue disappeared. It was crashing once every 2-3 app launches when it loaded the bundles, and after this change it hasn't crashed once in 30 app launches.
Some more info:
The issue is very frequent on iOS (tried on iOS 10+ and 11+, crashes on both), it looks like it happens on Android too but less frequently.
Unity 5.6.2 and Zenject 5.4.0
The injections happen from a SceneContext (that scene is never unloaded)
It's not really a breaking issue, and probably isn't related to Zenject specifically, but I was curious if you have any idea on this?
Thank you,
Federico

That is indeed pretty strange, but I can't imagine how it could possibly be related to zenject, since those two examples (calling new inline and calling new as a separate statement) are equivalent from zenjects perspective.  So it's almost certainly some weird quirk of IL2CPP
By the way, another way to do it would be to let zenject create it like this:
Container.Bind<IAssetBundleManager>().To<AssetBundleManager>().AsSingle().WithArguments("manifest_url");


 The report will be a comment of the commit.
Please do NOT merge this PR before the travis-ci branch of https://github.com/TuringLang/TuringBenchmarks is merged.

https://github.com/TuringLang/TuringBenchmarks/pull/42 is ready to merge.
After https://github.com/TuringLang/TuringBenchmarks/pull/42 is merged, I will make few trivial changes to the shell script in this PR, then we can run benchmarks on Travis:

Your branch must contain the commits in this PR, if you have a previously created branch, you can rebase it on master to obtain the commits in this PR.
When you push a new commit whose commt message contains the string [bm], a benchemark job wll be trigerred on TravisCI to compare the performance between master and you commit.

Ready to merge.


Code color and syntax check display error in jupyter

Environment data

VS Code version: 1.62.2
Jupyter Extension version (available under the Extensions sidebar): v2021.10.1101450599
Python Extension version (available under the Extensions sidebar): v2021.11.1422169775
OS (Windows | Mac | Linux distro) and version: windows
Python and/or Anaconda version: 3.7.11
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Jupyter server running: Local

Expected behaviour
right color and syntax check
Actual behaviour
wrong color and syntax check display, but can run as usual.

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

open the node book
open notebook source in vim(bash)
modify the kernel name  or something else
:wq close and save
return to vs code

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

@brynn-code Looks like the repro steps requires editing the ipynb from source.
Please could you let me know if you can repro this when eidting this file manully in VS Code using the notebook editor.

Please could you provide the original IPYNB file
& also the updated IPYNB file, this way I can try to edit this my self manually.

Sorry read this wrong in triage. If this only repros with an external edit, it's not the issue I thought it was.

Yes, I did modified the source, I change the 'name' in 'kernelspec' and python 'version' in metadata.
And when I follow the same step try again today, the bug can't be repro.
I think this may be a transient issue, you may close the bug since I didn't find a stable way to repro it.
I'll open a new issue if necessary (if there is a way to repro the bug)

Thanks for trying.

I have this exact bug right now. Is it solved ?

I have a similar problem now. Has this issue been solved ?


Fix detection of containers missing requests & limits

What does this PR do?
The case of containers with an empty resource section was not surfaced in the resource requirements extraction logic.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I made a couple small changes to the release note comments. Not sure if that stuff is generated from elsewhere, but the release note is GTG 👍

Thanks @hestonhoffman. I think those comments are common to all release notes and won't appear in the final changelog. They are seemingly generated from the configuration set in https://github.com/DataDog/datadog-agent/blob/main/releasenotes/config.yaml.

@xlucas Yeah, sounds good. You can ignore those edits here 👍


[GithubSearchBridge] Added github search bridge

Add a Github search bridge as requested in issue #481.
It only supports repositories search at the moment. Maybe it could be extended to support other search types (issues, code...), but I didn't look into it.

@teromene I forgot about this, fixed now with 6262b1d.

Merged, thanks !

@corenting Working great, thanks :)


Use event pointer in events buffer

This reduces memory size allocated by
newEventProcessor from 16M to 3M.
Signed-off-by: Zenghui Shi<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.758%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4937

Relevant Lines:
6604

💛  - Coveralls

@dcbw PTAL

/lgtm


Trigger builder-base update for go 1.21.10, 1.22.3

Issue #, if available:
Description of changes:
https://github.com/aws/eks-distro-build-tooling/pull/1421 and https://github.com/aws/eks-distro-build-tooling/pull/1420
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/lgtm

/approve


Milestone: OOP school library

In this milestone 💪

[ ] Created class Person with the following:

[ ] Instance vars: @id, @name, and @age.
[ ] Constructor with name, age, and parent_permission as parameter. name and parent_permission are optional and have default values of "Unknown" and true.
[ ] Getters for @id, @name, and @age.
[ ] Setters for @name and @age.
[ ] Private method is_of_age? that returns true if @age is greater or equal to 18 and false otherwise.
[ ] Public method can_use_services? that returns true if person is of age or if they have permission from parents.

[ ] Created class Student with the following:

[ ] Inherits from Person.
[ ] Constructor extends parent's constructor by adding @classroom and a parameter for it.
[ ] Method play_hooky that returns "¯(ツ)/¯".

[ ] Created class Teacher with the following:

[ ] Inherits from Person.
[ ] Constructor extends parent's constructor by adding @specialization and a parameter for it.
[ ] Override can_use_services? so it always returns true.

[ ] Each class is saved in a separate file.

Hi @Kashif-Saleem-Ghuman,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that is invalid because the README file is lacking the future features section
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

@PinkMoon25  Thank you for reviewing my PR and providing valuable feedback

@Olamarx  Thank you for approving my PR. :)


chore: remove cypress manual cookie preservation

Description
Cypress should do it automatically with test isolation disabled

/retest

/retest

/retest

/retest


[libcap] build failure

Package<EMAIL_ADDRESS>Host Environment

Host: arm64-linux
Compiler: GNU 8.3.0
vcpkg-tool version: 2999-12-31-unknownhash
vcpkg-scripts version: 11ed79186 2024-04-02 (6 小时前)

To Reproduce
vcpkg install wxwidgets
Failure logs
-- Downloading https://git.kernel.org/pub/scm/libs/libcap/libcap.git/snapshot/libcap-2.69.tar.gz -> libcap-2.69.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from /usr/local/share/vcpkg/vcpkg-bundle.json
[DEBUG] Failed to open: /usr/local/share/vcpkg/vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Feature flag 'dependencygraph' unset
[DEBUG] 1000: execute_process(curl --fail -L https://git.kernel.org/pub/scm/libs/libcap/libcap.git/snapshot/libcap-2.69.tar.gz --create-dirs --output /usr/local/share/vcpkg/downloads/libcap-2.69.tar.gz.15708.part)
[DEBUG] 1000: cmd_execute_and_stream_data() returned 22 after   775927 us
error: Failed to download from mirror set
error: https://git.kernel.org/pub/scm/libs/libcap/libcap.git/snapshot/libcap-2.69.tar.gz: curl failed to download with exit code 22
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

curl: (22) The requested URL returned error: 404 Not Found

[DEBUG] /usr/local/share/vcpkg/buildtrees/_vcpkg/src/vcpkg-tool-2024-03-14/src/vcpkg/base/downloads.cpp(1031):
[DEBUG] Time in subprocesses: 775927us
[DEBUG] Time in parsing JSON: 7us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 491us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 778 ms (776864us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same `https://` prefix issue.

      3. Your proxy's remote server is out of service.

      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  ports/libcap/portfile.cmake:1 (vcpkg_download_distfile)
  scripts/ports.cmake:175 (include)

Additional context
No response

The URL https://git.kernel.org/pub/scm/libs/libcap/libcap.git/snapshot/libcap-2.69.tar.gz appears to be unavailable again.
Is there perhaps a more reliable source for this package?

Same issue as @flnhst. This should probably be reopened or a new issue created unless this is a temporary problem.
Hitting the URI directly gives: "Unsupported snapshot format: libcap-2.69.tar.gz". I don't know the snapshot syntax that well and I didn't see any documentation, so I'm not sure why it doesn't like it.
Looking around, I saw that Linux From Scratch uses https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/ as the base URI. I was able to download from https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/libcap-{VERSION}.tar.gz, though the sha512 doesn't match what the portfile is looking for.
No idea what the difference is and whether that would or wouldn't be an appropriate URI to use instead.

Looking around, I saw that Linux From Scratch uses https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/ as the base URI. I was able to download from https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/libcap-{VERSION}.tar.gz, though the sha512 doesn't match what the portfile is looking for.

Assuming that there are the official downloads (instead of on-the-fly tarballs), the this is a mirror:
https://www.mirrorservice.org/sites/ftp.kernel.org/pub/linux/libs/security/linux-privs/libcap2/


New Box for VM does not have clean start

The new box does not start up cleanly - here is a summary of the error output:
  W: GPG error: http://cran.rstudio.com precise/ Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 51716619E084DAB9
  dpkg-preconfigure: unable to re-open stdin: No such file or directory
  E: Unable to locate package connectome-workbench
  dpkg-preconfigure: unable to re-open stdin: No such file or directory
  update-alternatives: using /usr/lib/lapack/liblapack.so.3gf to provide /usr/lib/liblapack.so.3gf  (liblapack.so.3gf) in auto mode.

  Creating config file /etc/papersize with new version

  Creating config file /etc/R/Renviron with new version
  dpkg-preconfigure: unable to re-open stdin: No such file or directory
  dpkg-preconfigure: unable to re-open stdin: No such file or directory
  dpkg-preconfigure: unable to re-open stdin: No such file or directory
  /tmp/vagrant-shell: line 61: git: command not found
  /tmp/vagrant-shell: line 66: cd: /home/vagrant/myconnectome: No such file or directory
  /tmp/vagrant-shell: line 377: cd: /home/vagrant/myconnectome: No such file or directory
  /home/vagrant/miniconda/bin/python: can't open file '/home/vagrant/myconnectome/setup.py':  [Errno 2] No such file or directory
   4 Jun 04:29:21 ntpdate[10055]: the NTP socket is in use, exiting
   touch: cannot touch `/home/vagrant/myconnectome/.started': No such file or directory
  /tmp/vagrant-shell: line 398: /home/vagrant/myconnectome/myconnectome_job.out: No such file or directory
  /tmp/vagrant-shell: line 401: /home/vagrant/myconnectome/.started: No such file or directory

I think I know how to debug this - I can download the VM, start it up manually, and then test our lines one by one! I will do first thing tomorrow, unless @poldrack has insight.

The manual debug did not have error, so it must have something to do with vagrant or VirtualBox. I am working from my other hard drive (meaning a different install of those two things) so I will switch over to my other (clone) OS to see if I get the same error. It doesn't make a lot of sense!

this is fixed in the latest push.  it was a vagrantfile issue

Great! I just found something that was a slight error, this line:
  # Install neurodebian repo
  bash <(wget -q -O- http://neuro.debian.net/_files/neurodebian-travis.sh)

The install was aborted because we couldn't type "Y." I'll repull and give this another go.

confirmed working again! Thanks!


[Git] Ignore jsconfig.json (VSCode config file)

[x] PR has tests / docs demo, and is linted. (N/A)
[X] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[X] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

VSCode needs a jsconfig.json file in the root folder of a project to enable ES2015 syntax recognition.  Options are 1) to include the file in the repo, or 2) add it to .gitignore.  A quick search leads me to believe that option 2 is right for this project.
See Angular and other examples.

@jakeboone02 Why not adding it in your global .gitignore. I don't think that we should handle all the IDE :hankey:.
What about killing the # Exclude IDE project folders section instead?

I could certainly be wrong, but I believe the file is useful to have committed in a repo for certain situations, so adding it to the global .gitignore could be problematic.  I just looked at some other examples to see what they did and this is how they handled it.
I agree you probably don't want to manage every IDE config in the world, but handling the few most frequently used on any given project shouldn't add too much overhead and can ever-so-slightly lower the barriers to new contributors :).

ever-so-slightly lower the barriers to new contributors

That's a very good point.
I'm be interested in others opinion on this topic.

I'm with @jakeboone02 here. I hadn't considered global .gitignore until your comment on another similar PR.
I've set mine up now so I'm covered, but the cost to us of accepting PRs to update .gitignore for additional editor configs or other files is effectively zero, so I don't think believe we should change it.

@mbrookes, can you clarify? Your comment seems to contradict itself but I'm probably misreading it.

@jakeboone02 - thanks - rephrased the words after 'I don't think' to clarify.

Got it. Thanks.


Support gzipped rearrangement files

csv files are commonly available in compressed form. This modification allows to read gzip-compressed CSV files directly with read_rearrangement

Thanks, @grst. We'll get this into the next release (soon).


Just question no issue at all.

First and foremost, I really enjoy the new setup and dashboard, beautifully created and well done; but, would there be anyway to implement ngrok like before? I tried to simply change the localhost address to an ngrok address given, but sadly it didn’t work.  Awesome work, loving it!

Ngrok limits the transfer rate and views, because of that is impossible to it works with ngrok's free version, alternatively you can try the ngrok's paid version :(


Tooltip doesn't always hide when mouse leaves trigger element if trigger element is moved by an animation

Bug, feature request, or proposal:
Sometimes a tooltip will not disappear when the mouse leaves the trigger element if there are animations and delays involved elsewhere in the component.
What is the expected behavior?
The tooltip should always hide when the host element is not hovered.
What is the current behavior?
The tooltip will sometimes get "stuck".
What are the steps to reproduce?
This is the closest I can come to reproducing the issue: https://stackblitz.com/edit/angular-material2-issue-scrjcu?file=app/app.component.ts
Try clicking around to reproduce the issue as seen in this gif: https://gfycat.com/AdorableMiserableGrison
What is the use-case or motivation for changing an existing behavior?
Bug
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest Stackblitz template, Chrome 64.0.3282.140 64 bit, Windows 10
Is there anything else we should know?
Could be a browser issue.
I would guess that the issue is related to a layout change that occurs while the trigger element is hovered - perhaps this causes no mouseleave event to be emitted when the cursor is then moved off the element or something similar.

Can't seem to get this to reproduce. Can anyone else verify the issue?

@andrewseguin FWIW I can reproduce this issue on Firefox 58.0, as well as on Chrome on other computers than mine. It can take a minute or so of clicking around to find a case where the tooltip fails to disappear.


Wb develop

This is a test to add contents to a country study page.

@shakythesherpa Thanks for the PR! Made a couple of comments, let me know if you need additional info.

Olfa, Please see if my edits on Congo page are now ok.  Thank you.

@olafveerman  can you please help check this pull request?

@shakythesherpa I made some minor changes, and pushed them to a branch in this repository. Closing this PR in favor of #68


Make consistent interfaces in MST and PCS

Signed-off-by: kamilsa<EMAIL_ADDRESS>

Description of the Change
This PR makes consistent interfaces between MST and PCS. To achieve that batches() method in TransactionSequence was reworked so that it returns vector of shared_ptr instead of vector of TransactionBatches
Benefits
More consistent interfaces
Possible Drawbacks
None

Please, fix tests and solve conflicts before further processing.


auth: introduce hive cell (modularization)

The auth manager itself is defined as cell which gets registered in the cell "control plane".
This way, the daemon cell doesn't need to know about the details how to initialize the auth manager and its internal components.

/test

k8s e2e test failures due to https://github.com/cilium/cilium/pull/24045
going to rebase to master and re-run once this has been merged

/test

/ci-verifier


Hooks wizard step scaffolding, form state, and modal to add hooks to the plan

For the purposes of this wizard step, I'm using the term "instance" to refer to a hook that has been added to the plan and its associated options (which step to run on, any future fields in the modal).
This PR adds the Hooks step to the wizard, with an empty state and a modal to add a new hook instance. It is currently missing the table of hook instances (once an instance is added, JSON of the new form state is shown as a placeholder), and the modal doesn't yet support editing an instance (prefill logic).
There is some magic going on here to reduce duplication between this modal and the AddEditHookModal on the main Hooks page. I've factored out the form state for the "hook definition" fields (currently name, url and branch fields, but I know we're changing those) into a common useHookDefinitionFields ... hook (meaning a React hook. That won't get confusing at all...). This returns an object of those useFormField calls, which is separately passed into the two different useFormState calls in AddEditHookModal and the new PlanAddEditHookModal, with the latter including additional fields.
I've also factored out the JSX for these field inputs into HookDefinitionInputs which is also used in both modals. That component is weird... it can hide the name field where necessary with a prop, and it can take children to render between the name field and other fields. We may need to change that structure a bit if we need more control over the order of the fields, or just give up on abstracting that. The fields prop of that component is fancy though, it can take the fields object from any useFormState call that includes those hook definition fields. That's why TS is happy with us passing the form.fields from the forms in both of these modals, because PlanHookInstanceFormState['fields'] is inferred to be extending HookFormState['fields']. I love TypeScript sometimes.
The PlanAddEditHookModal contains its own form state for the instance currently being added/edited. When the save button is clicked, the values from that form are passed to a handler in the HooksForm so they can be added to the actual plan wizard form state. This involves more magic: There is a type PlanHookInstance which is just the value types inferred from the useFormState in the PlanAddEditHookModal. That is the type used for the wizard's forms.hooks.fields.instances field, it's simply an array of those instances. So when we change the fields in these forms, the plan wizard's form state won't need to be changed, everything will match up. The useFormState call in PlanAddEditHookModal is the source of truth for these fields.
I thought about having the modal's form driven directly from the wizard's form state (we could have had a pre form and a post form in there), but using an array of hooks like this instead of those two static hooks means in the future we can easily support having more than two hooks, and it fits better with the abstraction that lets me share stuff with the AddEditHookModal.
The Add functionality works! The values from the modal's form are just pushed into the plan's form state. Edit and remove will also be pretty similar to implement. You can even populate the form correctly by selecting an existing hook, using a pattern I borrowed from MappingForm (there is a possible opportunity to factor out a common component there).
I'm saving the Edit and Remove actions, and the table of hook instances, for another PR.

@vconzola I know the fields for the hook definition will change, but this is ready for an initial UX review for the Add modal. The one interesting thing to note is that when you select an existing hook, the only field that isn't prefilled is the "step when the hook will run", but it's not obvious right away. So I set it so that you'll get the validation message on that field ("Step is a required field") when selecting an existing hook, to call your attention to it. This won't happen if you select to create a new hook. See screenshots above, and the preview is working.

@gildub I opened #586 and #587 to track the parts of this wizard step that I'm leaving out of this PR. If you want you could take on one of them.


Update client3:circe, client3:core, ... to 3.9.7

About this PR
📦 Updates

com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core
com.softwaremill.sttp.client3:http4s-backend

from 3.9.1 to 3.9.7
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #178.


Adding 'country' polygons for the two non-continental US states (Alaska and Hawaii) + continental US only

Hey @jhpoelen -- where did you source some GeoJSON files for countries, and might we similarly get these files for AK and HI?  If so, then we can use the existing code, since "Alaska" and "Hawaii" are included in the "countryDistribution" column.
Similarly, we'll need an GeoJSON file for the continental USA only, since the "United States of America" entry has been used to signify continental distributions of species only.  Thanks

Hey @jhpoelen -- where did you source some GeoJSON files for countries, and might we similarly get these files for AK and HI? If so, then we can use the existing code, since "Alaska" and "Hawaii" are included in the "countryDistribution" column.

The distribution maps as introduced/ described in #13 are using shapes make available through GADM.  They include shapes for country sub-divisions, including Hawaii and Alaska.
As far as I can tell, they support county level shapes also. For instance, here's the shape for Hennepin county in Minnesota. They appear to use full names (e.g., Minnesota, Hennepin) as well as some kind of short hand (e.g., US.MN.HE).
So, if you use these descriptors in your species distribution maps we may be able to get a little more specific. I'd say that best would be to use draw the actual distribution maps instead of administrative boundaries.
I am not aware of a shapefile for the continental us, so you'd probably have to list the 48 states instead. Alternatively, we can make some kind of hack to reference this list.
Let me know how you'd like to proceed.
{
      "type": "Feature",
      "properties": {
        "GID_2": "USA.24.27_1",
        "GID_0": "USA",
        "COUNTRY": "UnitedStates",
        "GID_1": "USA.24_1",
        "NAME_1": "Minnesota",
        "NL_NAME_1": "NA",
        "NAME_2": "Hennepin",
        "VARNAME_2": "NA",
        "NL_NAME_2": "NA",
        "TYPE_2": "County",
        "ENGTYPE_2": "County",
        "CC_2": "NA",
        "HASC_2": "US.MN.HE"

See e.g., https://gadm.org/maps/USA.html .


Fix cmd arguments and chunking for GNSS station inputs and height levels and add unit tests

This addresses #37
test_scenario_1 and test_scenario_2 should complete successfully now, these are both end-to-end units tests
Note: test_scenario_1 and test_scenario_2 test will test against the test data set, but the test data set has not been validated. In other words, these unit tests will test for changing values against what the code has been providing, but not the absolute accuracy.
chunking is still based on cpu count but adds a safety check; if the chunksize would be greater or less than a threshold it takes the threshold
chunking is fixed for station_file (i.e. 1D) and height_level (i.e. 3D) query points

Hey @Askaholic I'm having trouble with test_scenario_1. For some reason I'm getting NaNs when I run the unit test, but the same (as far as I can tell) test run in command-line form doesn't return NaNs. For comparison to test_scenario_1, I run the following from within the scenario_1 directory:
raiderDelay.py --date 20200103 --time 23:00:00 --latlon geom/lat.dat geom/lon.dat --model ERA5 --zref 20000. --outformat envi --out . -w weather_files

The problem evidently happens after the weather model is created because the weather model HDF5 file already exists and is used by both. Running py.test test results in a delay file containing 0's (the default noData value), while running the command line version results in a file without NaNs.
Any ideas?

I'm not sure whether circleCI updates the unit tests themselves or tries to run the old tests, but all unit tests are passing or skipped on my repo.

It's failing when it tries to read a file that doesn't exist. Chances are you still have an old version of this file laying around on your filesystem and that's why it's passing for you and not when circleci clones a fresh copy.

@Askaholic yes, that is a good point; however, in this case it seems to be the opposite situation. The file it's trying to find is the old name of the geometry file, which suggests it is running the old version of the unit tests, as that file gets named explicitly in the test_scenario_1 script. That file doesn't exist on my system.

There was an error where it was trying to write to a directory that didn't exist, which I fixed with d49961bf7286ca73913e6b9e27f4d918ea25d68a.

It's not failing on the unit tests themselves, it's failing on the setup commands that are run before hand. Specifically I think it's the last one:
raiderDelay.py --date 20200103 --time 23:00:00 --latlon test/scenario_1/geom/ERA5_Lat_2018_01_01_T00_00_00.dat test/scenario_1/geom/ERA5_Lon_2018_01_01_T00_00_00.dat --model ERA5 --zref 20000 -v --out test/scenario_1/

Notice that the 2018 files are still specified on the command line

Ah @Askaholic so that is the issue! Thanks for pointing that out; I was trying to follow the problematic command on the circleCI website but was having trouble. Anyway I'll see if I can update the config file to use the renamed versions.

Yea it's a little hard to tell what's going on in circleci because it prints all the commands and the top, and then shows the output for the entire sequence of commands beneath it.

BTW that command is also present in the help string of the argument parser created in parse_args.

@Askaholic @dbekaert is there a way to make changes to the config file for circleci as a part of the PR? The file doesn't get cloned with the repository. It would be ideal to tie the change with the PR.

Not sure what you mean. Yes you can edit the .circleci/files in the repo.
Those when edited and pr issues will be the file that gets checked out.
On Mon, Jul 20, 2020 at 8:35 PM Jeremy Maurer<EMAIL_ADDRESS>wrote:

@Askaholic https://github.com/Askaholic @dbekaert
https://github.com/dbekaert is there a way to make changes to the
config file for circleci as a part of the PR? The file doesn't get cloned
with the repository. It would be ideal to tie the change with the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dbekaert/RAiDER/pull/69#issuecomment-661610468, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AESZPSICRAGDUU4SWA7FR4DR4UEIXANCNFSM4O3OZPCA
.

The file is in a hidden folder: .circleci/config.yml. I edited it when I added pytest

@jlmaurer looks like there is no lon lat files in the test/scenario_1 folder.

Closing this PR and pushing from a new branch.


Clarify instructions to include exact name requirements for files

Clarify instructions to include exact name requirements for files.
Address #64

Thanks!


[DO-NOT-MERGE] Try to update Hive to 2.3.2

What changes were proposed in this pull request?
Check if there is any test failed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1003/
Test PASSed.

Test build #87611 has started for PR 20659 at commit 915e68f.

Test build #87611 has finished for PR 20659 at commit 915e68f.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87611/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1005/
Test PASSed.

Test build #87613 has started for PR 20659 at commit a5bb731.

Test build #87613 has finished for PR 20659 at commit a5bb731.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87613/
Test FAILed.

Merged build finished. Test FAILed.

Test build #87616 has started for PR 20659 at commit 80fd8a8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1008/
Test PASSed.

Test build #87616 has finished for PR 20659 at commit 80fd8a8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87616/
Test FAILed.

Test build #87960 has started for PR 20659 at commit 1110ede.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1276/
Test PASSed.

Test build #87960 has finished for PR 20659 at commit 1110ede.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87960/
Test FAILed.

Nice try! Could you fix the remaining failure?

Yes, I'm doing it

In general, this should keep all existing test coverage. Otherwise, it will not considered as a feasible solution.

just out of curiosity, what does DNM stands for?

I guess Do Not Merge. Actually, this is a try to see the result. :)

This is a very interesting work. Thanks for your effort!
When we implement such a feature, please remember we have to ensure it is configurable.

@gatorsmile @cloud-fan what is our plan for such thing? Currently we're using our own forked version, which blocks the support of Hadoop 3 (SPARK-18673). I'm wondering if we're going to upgrade Hive like what is done in this PR, or we still uses forked branch, and patch that branch.
What is your thought and plan on it?

@wangyum can you please create a relative JIRA, so that we discuss on the JIRA. I think it is better to discuss and get a conclusion first.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1486/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88206 has started for PR 20659 at commit b35daa0.

Test build #88206 has finished for PR 20659 at commit b35daa0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88206/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1496/
Test PASSed.

Test build #88217 has started for PR 20659 at commit b418909.

Test build #88217 has finished for PR 20659 at commit b418909.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88217/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1497/
Test PASSed.

Test build #88218 has started for PR 20659 at commit b418909.

Test build #88218 has finished for PR 20659 at commit b418909.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88218/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1499/
Test PASSed.

Test build #88221 has started for PR 20659 at commit f478c89.

Test build #88221 has finished for PR 20659 at commit f478c89.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88221/
Test FAILed.

[error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java:825:  error: cannot find symbol
[error]     String lScratchDir = hiveConf.getVar(ConfVars.LOCALSCRATCHDIR);
[error]

But HiveSessionImpl.java#L825 is:
FileUtils.forceDelete(sessionLogDir);

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1501/
Test PASSed.

Test build #88223 has started for PR 20659 at commit f478c89.

Test build #88223 has finished for PR 20659 at commit f478c89.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88223/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1505/
Test PASSed.

Test build #88230 has started for PR 20659 at commit f834a29.

Test build #88230 has finished for PR 20659 at commit f834a29.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88230/
Test FAILed.

Test build #88233 has started for PR 20659 at commit 7576866.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1507/
Test PASSed.

Test build #88233 has finished for PR 20659 at commit 7576866.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88233/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1528/
Test PASSed.

Test build #88260 has started for PR 20659 at commit 03138d8.

Test build #88260 has finished for PR 20659 at commit 03138d8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88260/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1535/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88269 has started for PR 20659 at commit e041704.

Test build #88269 has finished for PR 20659 at commit e041704.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88269/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1539/
Test PASSed.

Test build #88275 has started for PR 20659 at commit e041704.

Test build #88275 has finished for PR 20659 at commit e041704.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88275/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88299 has started for PR 20659 at commit b92918b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1554/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88299 has finished for PR 20659 at commit b92918b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88299/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1564/
Test PASSed.

Test build #88310 has started for PR 20659 at commit 71bcb25.

Test build #88310 has finished for PR 20659 at commit 71bcb25.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88310/
Test FAILed.

Test build #88311 has started for PR 20659 at commit 75e4cc9.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1565/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88311 has finished for PR 20659 at commit 75e4cc9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88311/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1569/
Test PASSed.

Test build #88317 has started for PR 20659 at commit 75e4cc9.

Test build #88317 has finished for PR 20659 at commit 75e4cc9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88317/
Test PASSed.

Thanks everyone, we can move to SPARK-23710 to discuss.

@wangyum .
Please read again my previous comment.
Although I support your efforts, Spark can provide ORC data source without -Phive.

I added more specific comments about ORC parts, @wangyum .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1579/
Test PASSed.

Test build #88337 has started for PR 20659 at commit e4c0624.

Test build #88337 has finished for PR 20659 at commit e4c0624.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88337/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1580/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88338 has started for PR 20659 at commit e4c0624.

Test build #88338 has finished for PR 20659 at commit e4c0624.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88338/
Test PASSed.

What will take to merge this PR in? It has passed all the tests.

@wangyum you can close this experiment?


Missing API type in component.d.ts

Laravel Mix Version: 6.0.9
Node Version: v15.12.0
NPM Version: 7.6.3
OS: Windows 10 (WSL2 w/ Ubuntu 20.04)

Description:
When compiling a Typescript component into js (to be published on npm) tsc complains about a missing type in the component.d.ts
node_modules/laravel-mix/types/component.d.ts:76:11 - error TS2304: Cannot find name 'API'.

76     (mix: API, config: webpack.Configuration, ...args: any[]): void;
             ~~~

Found 1 error.

I've tried to see if I could import API from the index file in the component.d.ts file, but didn't manage to make it work so far.
Steps To Reproduce:
Add typescript as a dependency, add a tsconfig file and run the tsc command.
This branch can be used to replicate the problem: https://github.com/Elhebert/laravel-mix-sri/tree/typescript-rewrite

👀 whoops. Thanks for catching that.
I can't import the namespaces exports because we use an export assignment. I can do typeof api instead of Api but that seems really wrong. I'm guessing the best solution would be to move the API definition to its own file and leave index.d.ts basically empty with the API import / export assignment. I had done this initially but I wasn't too fond of the anemic index.d.ts file. It seemed handy to have all the API definitions in that one file. Thoughts?
Aside: It'd be preferable to not use import from laravel-mix/src (like the File import) if you can help it. In this case I'd use fs directly instead. It's not going away right now but it's an incomplete abstraction. What we really need is a filesystem-like abstraction that doesn't depend on globals like File does. It's just something I've had on my mind for a bit.

@thecrypticace I made a PR before I saw your answer. I do agree that typeof api is not a good solution. I do think that it's a good temporary solution to fix the current broken types.
The ideal solution is, as you proposed, to have the API definition as its own export. It doesn't have to be in a different file tho.

All good! I agree the temporary fix is a reasonable solution for now.
It's my understanding that it does if we have an export assignment like we use at the bottom of index.d.ts otherwise you'll get an error:

Do you know of a way around that?

My knowledge of type declaration is fairly limited. I tried something that seems to work:
export declare namespace mix {

Then:
// component.d.ts

import { mix } from, './index'

this allow us to then call mix.Api as a valid type.

And just noticed that then we can't export = api 🤔
I'm just bad 😂

😂

I'll probably end up moving it to a separate file in the future. Seems to be the easiest "correct" solution


AssembleRelease (android) error

GM! When we try to build dev android APK file using ./gradlew assembleRelease script we get the next error about local .aar file in react-native-bare-kit library

Is there any solutions how to resolve this problem?

This should have been already solved by b9280659b7bb4a34ac671a7ecf0e89e50c49a797. Could you try updating?

This should have been already solved by b928065. Could you try updating?

Worked well!


🚨 Fix struct vs class warning

In file included from /home/mop/projects/arangodb/tests/IResearch/IResearchQueryNumericTerm-test.cpp:47:
/home/mop/projects/arangodb/arangod/IResearch/IResearchAnalyzerFeature.h:36:1: warning: class 'TRI_vocbase_t' was previously declared as a struct [-Wmismatched-tags]
class TRI_vocbase_t; // forward declaration
^
/home/mop/projects/arangodb/arangod/VocBase/vocbase.h:121:8: note: previous use is here
struct TRI_vocbase_t {
^
/home/mop/projects/arangodb/arangod/IResearch/IResearchAnalyzerFeature.h:36:1: note: did you mean struct here?
class TRI_vocbase_t; // forward declaration
^~~~~

@m0ppers : thanks!


PipelinedExecutor fails to start on slow / loaded system

I had a case of the PipelinedExecutor failing to start due to the startup_timeout being exceeded. We might want to either increase the time or find a way to recognize this error case and print a more useful error message (it took me a while to realise what was going on).
This was on a Windows laptop (i7 / 16 GB) which seemed to be experiencing high latency at the time.

I had a case of the PipelinedExecutor failing to start due to the startup_timeout being exceeded. We might want to either increase the time or find a way to recognize this error case and print a more useful error message (it took me a while to realise what was going on).

I'd vote for both - increasing the default timeout and have a better error message. If we are ambitious, we can add a WARNING level log after a few seconds, to signal that yes, we are still starting up, please be patient...
As a reference, this is the current error message, reproducible for example with PipelinedExecutor.make_local(startup_timeout=0):
In [5]: executor = PipelinedExecutor.make_local(startup_timeout=0)
---------------------------------------------------------------------------
Empty                                     Traceback (most recent call last)
~/source/upstream-LiberTEM/src/libertem/common/executor.py in get(self, block, timeout)
    504         try:
--> 505             res = self.q.get(block=block, timeout=timeout)
    506             yield (cloudpickle.loads(res[0]), cloudpickle.loads(res[1]))

~/miniconda/envs/upstream-libertem/lib/python3.9/multiprocessing/queues.py in get(self, block, timeout)
    113                     if not self._poll(timeout):
--> 114                         raise Empty
    115                 elif not self._poll():

Empty:

During handling of the above exception, another exception occurred:

WorkerQueueEmpty                          Traceback (most recent call last)
<ipython-input-5-bf61848308d6> in <module>
----> 1 executor = PipelinedExecutor.make_local(startup_timeout=0)

~/source/upstream-LiberTEM/src/libertem/executor/pipelined.py in make_local(cls, **kwargs)
    718         """
    719         spec = cls._default_spec()
--> 720         return cls(spec=spec, **kwargs)
    721
    722     @classmethod

~/source/upstream-LiberTEM/src/libertem/executor/pipelined.py in __init__(self, spec, pin_workers, startup_timeout, cleanup_timeout, early_setup)
    669
    670         # keep this at the bottom:
--> 671         self._pool = self._start_pool()
    672
    673     def _start_pool(self) -> WorkerPool:

~/source/upstream-LiberTEM/src/libertem/executor/pipelined.py in _start_pool(self)
    684             # failures without having to run into the timeout
    685             for i in range(pool.size):
--> 686                 with pool.response_queue.get(timeout=self._startup_timeout) as (msg, _):
    687                     if msg["type"] == "ERROR":
    688                         _raise_from_msg(msg, "error on startup")

~/miniconda/envs/upstream-libertem/lib/python3.9/contextlib.py in __enter__(self)
    117         del self.args, self.kwds, self.func
    118         try:
--> 119             return next(self.gen)
    120         except StopIteration:
    121             raise RuntimeError("generator didn't yield") from None

~/source/upstream-LiberTEM/src/libertem/common/executor.py in get(self, block, timeout)
    506             yield (cloudpickle.loads(res[0]), cloudpickle.loads(res[1]))
    507         except queue.Empty:
--> 508             raise WorkerQueueEmpty()
    509
    510     def close(self, drain: bool = True, force: bool = False):

WorkerQueueEmpty:

I also noticed that in case of a timeout, we also need to make sure all of the processes that we did manage to start, are then properly terminated/killed so we don't hang when, for example, closing the interactive Python shell afterwards, which joins the spawned multiprocessing.Processes in atexit...


Use "context create" instead of "context use"

@pchico83 Does this still applies?

@ifbyol I don't think so, closing


Make it compatible with both py27 and py38

Older APIC firmware versions only have py27.
Relatively older APIC firmware versions use py27 as the default. Newer APIC firmware versions use py38 as the default and no longer has py27 at all.
To support any APIC firmware version, make this script compatible with both py27 and py38.

pytest on py3 worked after adding six dependency.
tested on various pre 6.x fabrics with success.
merging.


Fix a memory leak in request/reply

Various resources associated with the timer were being leaked.   This fix tracks and disposes of the resources by disposing the token cancellation registration for the timeout cancellation token, and the primary token for the in-flight request.
Resolves #227
Signed-off-by: Colin Sullivan<EMAIL_ADDRESS>

Thanks @kozlovic ...


Facing Error exec: not started while executing tests of type command

Describe the bug
We are facing an issue while executing the tests of type command. Our tests are randomly failing with following output stdout: Error exec: not started. We have around 100 stacks in our environment and on each stack on an average 1000 test cases are running at scheduled interval. Out of this test cases we have observed that at some point of time few tests related to command execution are failing with the above mentioned error. Although, the error is temporary and gets resolved in the next run but it is happening frequently on random basis. One more thing to add here is that our test cases are running on both VMs as well as Kubernetes pods but this issue is arriving in case of Kubernetes pods only.
How To Reproduce
We don't have exact steps to reproduce this issue as it is happening on random basis. May be parallel execution of test cases with bigger count can reproduce.
Expected Behavior
Test cases should not be failed with this type of random error.
Actual Behavior
Test cases are failing randomly with following output stdout: Error exec: not started
Environment:

We are using the GOSS v0.4.2
Kubernetes pods for running test cases

Are you able to compile goss? If so, can you try the version on this branch: bug_fix
If not, can you let me know the architecture and I can upload a binary for you to test.
It won't fix the error, but should provide a more informative error which hopefully leads us to the cause.

Mostly we are downloading the binary by using this link: curl -L https://github.com/goss-org/goss/releases/latest/download/goss-linux-amd64 -o /usr/local/bin/goss. So, if you can provide the binary according to this it will be great.
Otherwise I can go ahead and compile goss with the branch you mentioned. Let me know.

Sure, I believe this binary will provide a different error. My assumption is perhaps a system limit is being hit somewhere and causing failures to even start invoking the test.
goss-linux-amd64.gz

@aelsabbahy  Due to https://www.suse.com/security/cve/CVE-2023-39323.html , We have created a new build locally with go version 1.20.9.
But note, we were facing this issue intermittently before as well.

Just following up on this. Have you received a different error yet? Very curious on reasons starting a command may fail in a k8s pod.

@aelsabbahy We haven't seen this error yet after updating the binary. I will let you know once we face this error again.

Sounds good, for what it's worth the latest binary contains the changes: v0.4.4

Hi @aelsabbahy we haven't face this error recently after updating the binary. So, as of now I'm closing this issue. We will get back to you if we face this error again. Thanks!


[ci:component:github.com/gardener/dependency-watchdog:v0.8.0->v1.0.0]

Release Notes:
Dependency `github.com/gardener/gardener` is updated `v1.6.5` -> `v1.30.2`

`format` and `check-vulnerabilites` make targets introduced

This PR introduces backward incompatible changes to the API/Config. Consumers should adapt to the new changes.

fixed RetryUntilPredicate tests.

updated golang version to v1.19.4.

/close
in favor of #6693


Cannot setup blockbot on a server with minimal mods

So I'm setting up a new server using blockbot but when I try to start the server it hangs for a few seconds with an error finding a class and vomits out a massive stack trace about how main couldn't be found. Don't know if it's because one of the mods are incompatible but I installed blockbot with no issues about 6 months ago on a similar server with the same mods (they've been updated since then, though). Before installing blockbot the mods I installed were Carpet, CarpetExtra, Fabric Language Kotlin, Lithium, and Starlight. Here's a few snippets of the errors, I cropped out the rest because it's ridiculously long. Taking out blockbot starts up the server just fine.
Error loading class: net/minecraft/class_5455$class_5457 (java.lang.ClassNotFoundException: net/minecraft/class_5455$class_5457)
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'blockbot-discord'!         at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51) ~[fabric-loader-0.13.3.jar:?]         at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.13.3.jar:?]         at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49) ~[fabric-loader-0.13.3.jar:?]         at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35) ~[fabric-loader-0.13.3.jar:?]         at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:62) ~[fabric-loader-0.13.3.jar:?]
There's a few more errors, but I'm not sure if it's related to blockbot or just the other mods having issues running because of the previous errors. Can provide a full paste if more details are needed.

Using the build from the latest action allowed me to set up blockbot and start the server without any errors. Will report back if there are other problems.


evince: add withGnome option (defaults to true on Linux)

This commit adds a withGnome option (defaults to true on Linux) to the
evince derivation, allowing to compile evince independently of the
rest of gnome.  The withGnome option name is also used by eight other
derivations in nixpkgs.
Although evince is part of the gnome project, its build system
supports compiling it independently from the rest of gnome simply by
disabling thumbnail caching.
Evince is currently the only PDF viewer with form-filling support that
doesn't depend on QT.  Nowadays a lot of unavoidable things like tax
forms require a form-filling PDF viewer.  Since people don't get much
of a choice anymore about having to use a piece of software with this
feature, let's at least allow them to do the job with the smallest
possible set of dependencies.
Checked with nixpkgs-hammer, which did not report any new warnings
introduced by this commit.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Rebased to resolve a conflict with recently-merged #164155

Again, this is a niche request with trivial benefit, adding pointless complexity to already complex expression.

Well, I guess we disagree.
Your review is marked as "changes requested".  Are you requesting any changes to this PR?

Your review is marked as "changes requested". Are you requesting any changes to this PR?

No, do not really see any way forward here.

Your review is marked as "changes requested". Are you requesting any changes to this PR?

No, do not really see any way forward here.

So you have marked your review as requesting changes, but you are not requesting changes.
Have I understood that correctly?
Apologies if this is some kind of "github idiom" -- I don't use github very much.

Yeah, it is an idiom for “I do not think it should be merged as is.” Even when one does not see any changes that could be made to be merge-able.

@a-m-joseph what's the change in closure size ?

@a-m-joseph what's the change in closure size ?

Zero, since dbusSupport is on-by-default.
However I am not proposing that Hydra provide builds for !dbusSupport; I'm sure the amount of extra build would not be worth it.  Any regressions which appear only in the !dbusSupport case would need to be caught by people like me who run that configuration, the same way I caught the regression in !supportMultimedia in #164155.  Currently I rebase against unstable at least every two weeks.  I build everything myself, like Gentoo (nixtoo?) -- I have substituters=\n in my nix.conf.
Stepping back a bit, I'm trying to rethink my overall approach here.
I still have 23 more (mostly one-liner) PRs like this to submit in order to completely upstream the ability for others to get the workstation-without-systemd-or-dbus configuration I'm currently running.  Odds are I will hit stiff resistance to merging from senior maintainers for at least a few of those PRs (and almost certainly for the one that adds !dbusSupport to gtk3).  I don't look forward to fighting that many battles, and as a new contributor to nixpkgs that would be a poor use of what little political capital I have.
So, currently, I am experimenting with writing a headers-only replacement package that does for dbus what libcardiacarrest does for pulseaudio.  You compile with those headers, which have every function marked as inline, reporting inability to connect to the dbus socket (without even attempting) and a randomly-generated machine-id, and all dbus-specific structs defined to be zero-byte types (I vaguely recall that this can be done in C, but I've been writing nothing but nix and rust for some time now).  This should have the same privacy and security benefits of disabling dbus in every package -- no UUID leakage and no ability to trick a process into connecting to a dbus socket.
If something like this already exists, please let me know.
If this works, I think it will get the same result with much less maintenance burden on other nixpkgs package maintainers; they won't have an extra argument to all their package-derivation functions.  Users who desire a non-dbus workstation can build with override for { dbus = libdbuswreck; }.
It will be a few weeks before I know if this is really possible.
I'd like to close by thanking the maintainers (including @jtojnar in #163859) who merged my systemdSupport PRs.  All of those have been submitted, and all but four (#161015, #160967, #161005, and #161010) have been merged.  The approach described above certainly would not work for systemd.
If there is something I should do to my dbus-related PRs in the meantime in order to make them not clutter up peoples' notification lists please let me know.  I don't have much experience with github.

Alright, it looks like this is a non-starter.


Why does RedHat have so many patches on OpenSSL?

This question is possibly better for the users list but asking it here. If it's inappropriate for this location please let me know.
Fedora keeps accumulating patches and now is somewhere around 20+ patches that it applies to OpenSSL. https://src.fedoraproject.org/rpms/openssl/tree/f30 I believe RHEL has even more.
Is there some standing reason that these patches don't/can't get submitted to OpenSSL mainline?

I guess this question is better directed at RedHat, although there are some RedHat people that hang out around here who may know.

I'll try to submit some of the patches upstream eventually, but most of the downstream patches are related to the FIPS support that cannot be upstreamed (the "philosophy" of the upstream FIPS support is completely different) and also to the fact that we cannot ship some algorithms (currently EC related only) due to legal reasons. Some of the patches are just integration with the rest of the OS which also does not make sense upstream. And the recent patches are just backport of EVP-KDF and SSHKDF patches from upstream master because we need it sooner than when 3.0.0 will be available.
In general the situation is much much better than it was in 1.0.x days. The number of the downstream patches is now much smaller.

Just look at Fedora 19 for example for comparison: https://src.fedoraproject.org/rpms/openssl/tree/f19

The reason I ask this is these changes cause ABI/API compatibility between RedHat packages that expect RedHat OpenSSL and using stock OpenSSL. It's, in effect, no longer OpenSSL and instead actually a RedHat fork of OpenSSL.

we cannot ship some algorithms (currently EC related only) due to legal reasons.

There's command line options to disable EC when building it though. The RPMs that would be produced would not contain EC in those cases. I'm not sure what patching it out actually achieves here as the EC code is still being stored in the "inverse patch" that patches out the EC code.

@mlindner : this patch disable a large part of EC curves ( only 6 remains) but not all, AFAIS.

This openssl-1.1.1-version-add-engines.patch is smart.
Display all the active engines is a pertinent info to add to openssl version -a command .

Yes, that one is definite candidate for PR. I'll do it.

There is nothing to do here on the OpenSSL side anymore.