Code and Paper don't seem to match...

When mapped with Code, I am thinking as follows.

In Paper...

But, I think this Code is

lossClassify = F.cross_entropy(self.la*(simClass-marginM), target)
->
lossClassify = F.cross_entropy(F.softmax(self.la * (simClass-marginM), dim=1), target)

Please check the official document of PyTorch about cross_entropy loss, which already includes the SoftMax operator.

Please check the official document of PyTorch about cross_entropy loss, which already includes the SoftMax operator.

Sorry. I checked the Torch official website and confirmed that it includes the SoftMax operator!

Sorry. I checked the Torch official website and confirmed that it includes the SoftMax operator!


{"error":"no datatable request detected"}

Hi, I am getting this issue, i can't find any Draw variable on my request. I'm using codeigniter 4.

can you post your code? (frontend and backend)


Create Quilt Loader version?

Quilt Loader is a newly Minecraft loader based on Fabric, it says most Fabric mods can run directly on Quilt, while this mod may be an exception. On recent Minecraft releases, we have to use WTHIT to provide HWYLA and WTHIT has a Quilt version, but this mod can't run with the Quilt version of WTHIT.
Here is the website of Quilt: https://quiltmc.org/

I don't have time to prioritise Quilt development. I was told Quilt supports Fabric mods, this mod does nothing special, imagine the time required if every one of my mods needs porting, WTHIT should fix the incompatibility, not me.

@zhanghua000
It does work with WTHIT Quilt, see this gist, can you send me your log?

Never mind, I find that this problem disappears when I restart game to get a clean log. Anyway, thanks for your help to solve this problem.


TocPanel generalization

ui/TocPanel currently depends on the content and level property of heading. I'd like to generalize that a bit so we just need to implement schema.getTocTypes() and Article#getTocNodes().
I want to keep this operating on regular Substance nodes, so the TOC can react to document changes (e.g. heading gets edited). How about the following contract:

Each node that wants to show up in the TOC needs to implement getTocName() and getTocLevel()

Oli i have a problem with making assumptions on the ordering of members. We have some logic here in the components, and duplicated in the DocumentationTOCPanel, which i would like to get rid of. I'd favor an approach where we implement this logic on the model side.
E.g. for the NamespaceNode i would implement a getMembers method that considers categorization etc.
var MEMBER_CATEGORIES = [
  {name: 'modules', path: ['module']},
  {name: 'classes', path: ['class']},
  {name: 'functions', path: ['function']},
];

This could go into a mixin for container nodes as well:
MemberContainerComponent.getCategoryMembers = function(config, node, cat) {
  var doc = node.getDocument();
  var memberIndex = doc.getIndex('members');
  var members = memberIndex.get([node.id].concat(cat.path));
  members = filter(members, function(memberNode) {
    // skip nodes according to configuration
    if ((memberNode.type === "method" && memberNode.isPrivate && config.skipPrivateMethods) ||
      (memberNode.type === "class" && memberNode.isAbstract && config.skipAbstractClasses)) {
      return false;
    }
    return true;
  });
  return members;
};

What do you think?

Do we actually have markup for member categories? Or is it fine if that is flattened?
  this._renderMemberCategory = function(cat, catMembers) {
    var catEl = $$('div').addClass('se-member-category');
    var membersEl = $$('div').addClass('se-members');
    catMembers.forEach(function(memberNode) {
      membersEl.append(this._renderMember(memberNode));
    }.bind(this));
    catEl.append(membersEl);
    return catEl;
  };

Implemented via #254.

The categories are used in the MemberIndexComponent.

I think Documentation is a good example of having dynamic content. So IMO the concept is general enough now. Having the level API on node is fine here, however I am pretty sure that this is not a general concept. E.g, think about our general Headings. In some special document, there might be a higher-level structure (such as chapters or so), which would lead to a different level, than in other contexts.

What would be a better place for level? You have a suggestion?
On Mo., 16. Nov. 2015 at 18:23, Oliver Buchtala<EMAIL_ADDRESS>wrote:

I think Documentation is a good example of having dynamic content. So IMO
the concept is general enough now. Having the level API on node is fine
here, however I am pretty sure that this is not a general concept. E.g,
think about our general Headings. In some special document, there might be
a higher-level structure (such as chapters or so), which would lead to a
different level, than in other contexts.
—
Reply to this email directly or view it on GitHub
https://github.com/substance/substance/issues/253#issuecomment-157107135
.

I think there is no such place in general :(
In Documentation this is working fine.
In our general implementations not. In general, only a document knows about the overall structure.

For now we are good here.


Ticker.lastTime has wrong initial value

The initial value of the ticker's lastTime is wrong.
const app = new PIXI.Application({});

console.log("initial", app.ticker.lastTime); // ~500

const cb = () => {
    console.log("update", app.ticker.lastTime); // ~300
    app.ticker.remove(cb);
}

app.ticker.add(cb);

Expected Behavior
The initial value is less than the value in the update loop (or -1 as per documentation).
Current Behavior
The initial value is a random value higher than value in the update loop, hence the timer "decreases".
Possible Solution
I have no clue.
Steps to Reproduce
https://www.pixiplayground.com/#/edit/6O-lXs-O7SdM2CwFXU8H7
Environment

pixi.js version: 5.3.0
Browser & Version: Chrome 85.0.4183.49, Electron
OS & Version: Arch Linux
Running Example: https://www.pixiplayground.com/#/edit/6O-lXs-O7SdM2CwFXU8H7

I don't see such a large delta, but this maybe due to the fact that requestAnimationFrame does not receive the same time as performance.now(). If you run the following code in a console, you'll see that the timestamps on each line don't match:
const raf = ((t) => {
    console.log(t, performance.now())
    requestAnimationFrame(raf);
});

requestAnimationFrame(raf);

The ticker updates the timestamp based on requestAnimationFrame on each tick (https://github.com/pixijs/pixi.js/blob/064135e795dbfe7b53248ff457d71cb8536077ac/packages/ticker/src/Ticker.ts#L182), except when the first rAF callback is requested (https://github.com/pixijs/pixi.js/blob/064135e795dbfe7b53248ff457d71cb8536077ac/packages/ticker/src/Ticker.ts#L211)
@bigtimebuddy or @ivanpopelyshev might want to confirm this.

@Prior99 The documentation does say the initial lastTime is -1. You don't see that b/c the application ticker starts immediately when created, unless you pass { autoStart: false }.


[Docs] Missing example code: TodoBot

The example code for TodoBot described in the documentation article Debug Locally with VSCode is no longer present in this repo.
The TextBot used by the TodoBot example has been depreciated in favor of UniversalBot with ConsoleConnector
Recommended remediation:

Update Node.js SDK Docs to indicate depreciation of the TodoBot example, as well as the TextBot class as described in the SDK Reference Library page on TextBot
Replace docs link to TodoBot with link to example: hello-ConsoleConnector

depreciated


Add comments for wlan0 for flash tool

Add a comment block to set the wifi name and password with the flash tool.
Having such a comment it is easier for user's to add their wifi settings manually as well.
Connects to hypriot/flash#58

As we only have a bash script I just want to sed the values into the yaml instead of parsing, grepping and adding the whole yaml tree.


cmd/goimports: Running goimports removes an import path that should be preserved

The origin of this issue is a related bug filed under the LiteIde project:
https://github.com/visualfc/liteide/issues/278
In that issue, the user claims that running of the goimports tool on their working code results in an import path for github.com/stathat/go being removed incorrectly.
While the github.com/stathat/go packages does violate two conventions (it uses /go/ in the import path, and the name of the package does not match the name of the containing directory), the code works and appears to be technically correct.
To reproduce:
$ cd /Users/jbuberel
$ mkdir gi
$ export GOPATH=/Users/jbuberel/gi
$ echo $GOPATH
/Users/jbuberel/gi
$ go get golang.org/x/tools/cmd/goimports
$ ls -la ~/bin/goimports
-rwxr-xr-x  1 jbuberel  eng  4947056 Apr  7 11:18 /Users/jbuberel/bin/goimports
$ mkdir src/myprogram
$ touch src/myprogram/mymain.go

[ create source file mymain.go with these contents: ]
package main

import (
    "fmt"
    "github.com/stathat/go"
    "golang.org/x/tools/present"
)

func main() {
    fmt.Println("Hello World")
    err := stathat.PostEZValue("test", "test", 1)
    if err != nil {
      fmt.Printf("Error: %v\n", err)
    }

    link := present.Link{
      Label: "Foobar",
    }

    fmt.Printf("L: %v\n", link.Label)
}

[ now run the program, expecting it to fail ]
$ go run src/myprogram/mymain.go
src/myprogram/mymain.go:5:5: cannot find package "github.com/stathat/go" in any of:
	/usr/local/go/src/github.com/stathat/go (from $GOROOT)
	/Users/jbuberel/gi/src/github.com/stathat/go (from $GOPATH)

[ manually goget stathat/go and tools/present and run the app ]
$ go get github.com/stathat/go golang.org/x/tools/present
$ go run src/myprogram/mymain.go
Hello World
L: Foobar

[ forcibly remove stathat/go and tools/present ]
$ rm -rf src/github.com/ src/golang.org/
$ go run src/myprogram/mymain.go
src/myprogram/mymain.go:5:5: cannot find package "github.com/stathat/go" in any of:
	/usr/local/go/src/github.com/stathat/go (from $GOROOT)
	/Users/jbuberel/gi/src/github.com/stathat/go (from $GOPATH)
src/myprogram/mymain.go:6:5: cannot find package "golang.org/x/tools/present" in any of:
	/usr/local/go/src/golang.org/x/tools/present (from $GOROOT)
	/Users/jbuberel/gi/src/golang.org/x/tools/present (from $GOPATH)

[ run goimports on the source, see that stathat/go import statement is removed, while tools/present was retained ]
$ ~/bin/goimports src/myprogram/mymain.go
package main

import (
	"fmt"

	"golang.org/x/tools/present"
)

func main() {
	fmt.Println("Hello World")
	err := stathat.PostEZValue("test", "test", 1)
	if err != nil {
		fmt.Printf("Error: %v\n", err)
	}

	link := present.Link{
		Label: "Foobar",
	}

	fmt.Printf("L: %v\n", link.Label)
}
$

This would have worked if you hadn't done the "forcibly remove stathat/go" step.
Without the stathat files on disk in your GOPATH, goimports doesn't know what stathat before stathat.PostEZValue means, nor what github.com/stathat/go means.
The present import lives because goimports uses the heuristic that package name == directory name probably. But that heuristic fails for stathat. So if you want to do that, don't randomly delete things from your GOPATH.
Closing until there's something fixable. Feel free to re-open if I missed something.


add pytyhon3.8-venv package

https://packages.ubuntu.com/bionic/python3.8-venv
https://packages.debian.org/search?suite=all&arch=any&searchon=names&keywords=python3.8-venv
https://software.opensuse.org/package/python38-virtualenv
https://search.nixos.org/packages?channel=21.11&show=python38&from=0&size=50&sort=relevance&type=packages&query=python38

@k-okada could you fix the CI failures https://github.com/ros/rosdistro/pull/32509/files?

Closing, based on the feedback provided here.


I'm having problems running NadekoBot on my RPi2

Hello, I'm trying to set-up NadekoBot on my Raspberry Pi 2.
But I'm running into a few error when trying to launch it.
It comes up with the following:

sudo mono NadekoBot.exe
▒▒▒▒Google API key provided.
No trello appkey found. You will not be able to use trello commands.
Forwarding private messages to owner.
No soundcloud Client ID found. Soundcloud streaming is disabled.
No osu! api key found. Song & top score lookups will not work. User lookups still available.
Specific config started initializing.
Specific config done initializing.
Reading from the permission files.
Permission initialization complete.
Token is wrong. Don't set a token if you don't have an official BOT account.
System.Exception: You must send data by websocket after websocket is opened!
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in :0
at Discord.TaskManager.ThrowException () [0x0001e] in <9529832d40a3420689999daa52622c45>:0
at Discord.Net.WebSockets.WebSocket.WaitForConnection (System.Threading.CancellationToken cancelToken) [0x0002b] in <9529832d40a3420689999daa52622c45>:0
at Discord.Net.WebSockets.GatewaySocket.WaitForConnection (System.Threading.CancellationToken cancelToken) [0x00012] in <9529832d40a3420689999daa52622c45>:0
at Discord.DiscordClient+d__78.MoveNext () [0x0044c] in <9529832d40a3420689999daa52622c45>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in :0
at Discord.DiscordClient+d__78.MoveNext () [0x005a6] in <9529832d40a3420689999daa52622c45>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0004e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in :0
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable+ConfiguredTaskAwaiter.GetResult () [0x00000] in :0
at Discord.DiscordClient+d__77.MoveNext () [0x0008b] in <9529832d40a3420689999daa52622c45>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0004e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in :0
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable+ConfiguredTaskAwaiter.GetResult () [0x00000] in :0
at NadekoBot.NadekoBot+<>c+<b__32_3>d.MoveNext () [0x00179] in <0c3b1ee187ad4dbc8d304a35d06d044e>:0
Severity: ErrorExceptionMessage: You must send data by websocket after websocket is opened!Message: Disconnected

Does anyone know what the problem is?
Thank you.

!img
its either your bot token you just need to downgrade mono http://nadekobot.readthedocs.io/en/0.9/guides/Linux Guide/#mono-fix-socket-error

Got Mono working using ZirconiumHacker's post on https://github.com/Kwoth/NadekoBot/issues/731
Thanks for helping.

@SibaNL if it's working you should close this issue. 😉 Or @Kwoth should. Either way. ¯\_(ツ)_/¯

It wont work as its only 32bit


#319: add null move functionality

Implemented null move logic for SAN '--' and added a simple test case. Please review, I am open for discussions!

Thanks for the PR @ppeloton.
This is a good start on the null move logic. A couple of random questions that I haven't really thought through yet:

Are null moves supported in the PGN logic (both loading and exporting)?
Should null moves be entered with a dedicated function instead of the .move() function? I think there's a lot to think about here. A dedicated function would keep .move() consistent with the results of .moves(). It also side-steps the issue of not being able to enter a null move when using the verbose move format. A lot of people have been asking for setSideToMove function. Could this be considered a null move? Could we combine the two?
Should a null move entered at move 1 (this._history.length === 0) be omitted from history? Omitting it would require modifying the starting FEN and updating the Setup header. This relates to the previous question about setSideToMove.
Can null moves be made in succession?
Can null moves be made when the side to move is in check?

I'd like to let this PR soak for a bit to let us (and others) ponder some of these questions. Thanks again for submitting!

@jhlywa : Happy to contribute and thank you for your good feedback and questions. Generally, I think that null moves do not have one common standard, so if we want to implement this in the package, the developers have to make choices and document how null moves are handled in chess.js
About your questions:

Exporting/Importing in pgn: Just the SAN for a null move has no standard (see e.g. https://chess.stackexchange.com/questions/14072/san-for-nullmove), so exporting / importing of null moves is probably differently supported. I personally use Scid, which supports importing/exporting of null moves in pgn files (using SAN '--').

a seperate method for null moves sounds good (e.g. makeNullMove()) sounds like a good way to implement it. Even more if there is a wish for setSideToMove functionality (if I understand it correctly, it basically corresponds to making a null move and giving the turn to the otherside).

Rules relating null moves: I have not found a standard for this. But using Scid as a reference, the program allows multiple null moves in succession but no null moves when one is in check. I could try to find out if there are more rules in Scid related to null moves and we good take that as a starting point for this package.

I am happy to continue the discussion!

Sorry, I forgot to run the prettify command. I hope now everything is fixed!

a seperate method for null moves sounds good (e.g. makeNullMove()) sounds like a good way to implement it. Even more if there is a wish for setSideToMove functionality (if I understand it correctly, it basically corresponds to making a null move and giving the turn to the otherside).

makeNullMove() is useful and necessary for developing a chess engine in JavaScript.
I hope that this PR will be merged as soon as possible.


Windows build support.

Thank you for great library!
This PR supports building python-optix on Windows.
I have confirmed every scripts in examples works well on Windows.
Changes are:

Define NOMINMAX for MSVC(otherwise comilation fails for std::max used in OptiX header)
Link with advapi32(OptiX uses some Windows Registry API)

Build environment

Windows11 64bit
Conda python 3.8
MSVC(VS2019)

Hey, tanks for the contribution! Really great to get the Windows support up and running! I will merge and make a new Release ASAP.


Move to use internal 'msp' protobufs for Idemix

This pulls the Idemix specific protobufs from fabric-protos into this repo
There is a dependency still on fabric-protos for the general msp structures but there is nothing Idemix specific in there now - as Fabric doesn't need to know.
Note that protobuf implementations are checked in; but they there is a make target that will create these if needed make genprotos.  buf is used to create the code (along with the code for the other proto files)
the changes to the makefile might seem verbose, but they are following exactly the same approach that is used for fabric-protos - so it made sense to follow the same pattern.
A few tests have been changed; the tests checked error messages - but it is a documented 'feature' of the google protobuf API that they change error messages.  To stop people from checking them in tests.  Something for a future PR to solve...

Signed-off-by: Matthew B White<EMAIL_ADDRESS>

@ale-linux this should be good for review now.

@ale-linux , please, can you look at this PR? Thanks :)

@mbwhite, any updates?

Hi @ale-linux afraid that with the local issues with VPN blocking all go install I'd put this down; found the workaround though GOPROXY=direct
Changes have been made as per the suggestions thanks.


Remove debug print from error log

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2185/
Test PASSed.


Fix deleting product when default variant is deleted

Don't delete product when the product default variant is deleted.
SALEOR-1190

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1190 Deleting default variant should not delete product


[GEP-17] Add GEP-17 with an updated Control Plane Migration "Bad Case" Scenario description

How to categorize this PR?
/area control-plane-migration
/area documentation
/kind enhancement
/priority normal
What this PR does / why we need it:

Removes the "bad case" scenario description from GEP-7.
Adds a new GEP-17 with an updated "bad case" scenario description aligned with the latest PoC implementation and results.

Which issue(s) this PR fixes:
Part of #1631
Special notes for your reviewer:
This PR supercedes #3066. While it builds upon the same main ideas, the description is restructured and aligned with the results of the PoC.
Release note:
NONE

/cc @plkokanov @kris94

We consider this PR as ready for review now.
/cc @rfranzke @timebertt @mandelsoft

/cc @amshuman-kr @vlerenc

/cc @plkokanov @kris94 @rfranzke @timebertt @vlerenc @amshuman-kr @mandelsoft @MartinWeindel
To make the bad case scenario description easier to understand and discuss, I moved it to a new GEP (GEP-17). It was independent from the old GEP (GEP-7) already which is already implemented and released.
The new proposal is very different from the original one proposed about 3 months ago. It is significantly simpler, as it is based on the owner DNS records that could be meanwhile introduced after the DNSRecords feature was implemented. There are no more CopyOperation objects and "cluster leases".
I resolved all existing comments, since they were either no longer relevant (regarding parts that have been removed), or sufficiently well answered (at least from my perspective). As before, everything you see in the proposal has been implemented and tested as part of the PoC, and the productization of certain parts (copying of snapshots) is already ongoing.

/touch

Thank you @stoyanr and colleagues. The new proposal can be understood very well and seems safer and also easier to build. A question that I would have is what happens if the destination seed cannot access the source seed's backup bucket. Should that happen, the migration needs to be put on hold (possibly indefinitely) as without a backup/snapshot there is no point in bringing back the cluster as it would be empty. How will this be guardrailed?

what happens if the destination seed cannot access the source seed's backup bucket. Should that happen, the migration needs to be put on hold (possibly indefinitely) as without a backup/snapshot there is no point in bringing back the cluster as it would be empty.

Yes, this is what will happen. The copying of snapshots task will fail, and the restoration flow will keep retrying it until it eventually succeeds, or until the shoot is marked as Failed after a certain timeout.

@rfranzke Thanks for your feedback! I added a new section to the GEP regarding Handling Inability to Resolve the Owner DNS Record and I answered all your other comments. I think no other changes to the GEP are required, let me know if you still miss something.


Hitting Play on any scene crashes the editor in Unity 2017.2

I tried using this in Unity 2017.2 with the 2017.2 branch of HoloToolkit and it crashes the editor instantly when the play button is hit in any scene.

I have no idea if you've solved it or not, but on the new HoloToolkit (or Mixed Reality Toolkit), it mentions that you need Unity 2017.1.2 for Hololens due to a bug on Unity's end. While I've managed to get this compiled, I've yet been able to launch it on an actual hololens (about to create an issue related to that).


feat: generate sitemap and robots.txt

closes #374
sitemap.xml

robots.txt

hey! thanks for this! missed them in the docs :)

notice that if you go to preview robots will "tell" the link is not safe and ask to redirect to the domain set in there, that why it's better to use a public environment variable and refactor all instances in your code

yeah, will do, thanks again!


Multiple instances of the same accessory

I'm seeing multiple instances of the same accessory, but only one of the actual listings in HomeKit does anything.  In other words, I have one smart outlet, but there are three showing in homebridge, but only one of them actually does anything.  Any ideas?  Thanks!

 If so, yes, multiple times as I’m always adding/modding accessories. That’s the only way to add new accessories through homebridge, no?

No there should be a file called cachedaccessories in the accessories folder of the .homebridge file.   Thanks!

No problems I’m glad I could be of help to you


Screen does not match what is seen in Application update screen

Under Manage Properties, there is no option for application access options as described in this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a8a844d8-1aab-daf1-0567-35f2de89fa23
Version Independent ID: 6d8a875c-8038-5d1d-b0dc-e4c7094844c1
Content: Quickstart: Configure properties for an application in your Azure Active Directory (Azure AD) tenant
Content Source: articles/active-directory/manage-apps/add-application-portal-configure.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@krob527
Thanks for your feedback! We will investigate and update as appropriate.

I think it may be because this was added as an Enterprise App.
From: James Tran-MSFT<EMAIL_ADDRESS>Sent: Tuesday, October 13, 2020 11:59 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Kevin Robinson<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Screen does not match what is seen in Application update screen (#64304)
@krob527https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkrob527&data=02|01|kevin%40rtriad.com|7fc02f5fa6234e8c6e9c08d86f90f282|e96f9681faca40e9b241eaa01fa58991|0|0|637382015648161016&sdata=ya8I6xK3OIdSuRNGwNPwwH%2BicekgDoTqzoYT1WQz8vM%3D&reserved=0
Thanks for your feedback! We will investigate and update as appropriate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F64304%23issuecomment-707841176&data=02|01|kevin%40rtriad.com|7fc02f5fa6234e8c6e9c08d86f90f282|e96f9681faca40e9b241eaa01fa58991|0|0|637382015648171015&sdata=gvpws8m%2FnUapnNKtretQLnibY9JPUdzqFCTFdJvMM4U%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPL4SN3SGZ22RJ6BEHKHX3SKR2NRANCNFSM4SO7HC6A&data=02|01|kevin%40rtriad.com|7fc02f5fa6234e8c6e9c08d86f90f282|e96f9681faca40e9b241eaa01fa58991|0|0|637382015648181010&sdata=q1Zk%2BNfY7ohkTIYzvXl5JgRYkLgAgsjArjrXn0jrb2U%3D&reserved=0.

@krob527
Thanks for the quick reply!
From the documentation, I see that the screenshots are outdated. However, when you mention the "application access options", are you referring to the User Access URL? Or something else?
The other portions within the documentation screenshots, can be found within the App Registrations portion of AzureAD.
-AzureAD -> App Registrations -> Select your app registration

@krob527 - I see your point and agree it is very confusing. I am fairly new on the team and getting my head around why there is an "App registrations" and "Enterprise applications" and how they work together has been a pain. I added some information to help clarify. You are exactly right that if an app was added through app registrations the fields are different. Hopefully the note will help others. It should be live shortly.
@JamesTran-MSFT thanks for your guidance here too and I removed the outdated screenshot so it doesn't cause confusion.
#reassign: kenwith

https://github.com/MicrosoftDocs/azure-docs-pr/pull/133744

#please-close


Autofocus submit button after closing not working

Updated to 4.0.3 and now when I close a dropdown the submit button that appears no longer autofocuses. Can this functionality be restored?
See example here and choose any dropdown. "Go" button should receive focus:
http://www.paulrand.design/writing/articles/index.html

If this is the same issue as #4570, then it should be fixed as of v4.0.4.


urdf: 2.7.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository urdf to 2.7.0-1:

upstream repository: https://github.com/ros2/urdf.git
release repository: https://github.com/ros2-gbp/urdf-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.1
previous version for package: 2.6.0-1

urdf

No changes

urdf_parser_plugin

No changes

I think this package is missing a LICENSE file


[SPARK-27413][SS] keep the same epoch pace between driver and executor.

What changes were proposed in this pull request?
The pace of epoch generation in driver and epoch pulling in executor is different. It will result in many empty epochs for partition if the epoch pulling interval is larger than epoch generation.
How was this patch tested?
update existing unit tests.

Test build #104427 has started for PR 24323 at commit d624637.

cc @jose-torres

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9758/
Test PASSed.

Test build #104427 has finished for PR 24323 at commit d624637.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104427/
Test FAILed.

test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9770/
Test PASSed.

Test build #104441 has started for PR 24323 at commit d624637.

@gaborgsomogyi Agree with you, and let us think about code refactor later, ok?

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9793/
Test PASSed.

Test build #104463 has started for PR 24323 at commit d624637.

Test build #104463 has finished for PR 24323 at commit d624637.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104463/
Test PASSed.

Spark can be configured such a way to reach this without code modification. Refactoring is changing the code without behavior modification. I mean here and now a different approach can be used.

@gaborgsomogyi Hmm, I misunderstood what you meant. From my point of view, using push mechanism doesn't really help much but makes this code more complex. The main concern of PR is to avoid producing unexpected empty epochs. IMHO, keep the actual implementation.

cc @zsxwing

I'm not sure I understand the motivation here. It's true that setting the poll interval larger than the generation interval will generate a bunch of empty epochs, but why does that imply that we shouldn't allow it to be configured at all? (And even if we shouldn't, why is "equal to the epoch duration" the right value?)

@jose-torres Thanks for you reply

I'm not sure I understand the motivation here. It's true that setting the poll interval larger than the generation interval will generate a bunch of empty epochs,

You have got the motivation. As Mentioned above, the main concern of PR is to avoid produce empty epoch.

but why does that imply that we shouldn't allow it to be configured at all?

We can indeed allow it to be configured. But firstly, IMO, it is not a good idea to expose this config to users and let them to set it carefully. Secondly, the epoch pulling interval is a internal config. We may use a better approach to optimize this issue but not add config.

And even if we shouldn't, why is "equal to the epoch duration" the right value?

Hmm... After think again and deeply, "equal to the epoch duration" dose not really fix the issue. In some corner cases, executor will pull epoch from driver later than "epoch duration". So as @gaborgsomogyi mentioned, "push notifications to executors" may be a better approach.
To reiterate, the main concern of PR is to avoid produce empty epoch and late epoch. Do you have any doubt about this motivation?
Any idea is appreciated.

ping @jose-torres @gaborgsomogyi

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10129/
Test PASSed.

Test build #104821 has started for PR 24323 at commit cf37736.

Sending epoch update to executors instead of pull mechanism.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10130/
Test PASSed.

Test build #104822 has started for PR 24323 at commit ef4238a.

Test build #104822 has finished for PR 24323 at commit ef4238a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #104821 has finished for PR 24323 at commit cf37736.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104822/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104821/
Test FAILed.

retest this please

Test build #104848 has started for PR 24323 at commit ef4238a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10157/
Test PASSed.

Test build #104848 has finished for PR 24323 at commit ef4238a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104848/
Test FAILed.

Test build #104859 has started for PR 24323 at commit 02b2b2b.

Test build #104859 has finished for PR 24323 at commit 02b2b2b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104859/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10174/
Test PASSed.

Test build #104866 has started for PR 24323 at commit 02b2b2b.

Test build #104866 has finished for PR 24323 at commit 02b2b2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104866/
Test PASSed.

ping @jose-torres  and @gaborgsomogyi

cc @tdas

Test build #105154 has started for PR 24323 at commit 4676c64.

Test build #105154 has finished for PR 24323 at commit 4676c64.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105154/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10442/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10478/
Test PASSed.

Test build #105195 has started for PR 24323 at commit 4676c64.

Test build #105195 has finished for PR 24323 at commit 4676c64.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105195/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10479/
Test PASSed.

Test build #105196 has started for PR 24323 at commit ad14cd2.

Test build #105196 has finished for PR 24323 at commit ad14cd2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105196/
Test FAILed.

retest this please

Test build #105200 has started for PR 24323 at commit ad14cd2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10486/
Test PASSed.

Test build #105200 has finished for PR 24323 at commit ad14cd2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105200/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10523/
Test PASSed.

Test build #105242 has started for PR 24323 at commit ad14cd2.

Test build #105242 has finished for PR 24323 at commit ad14cd2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105242/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15704/
Test PASSed.


Not working valueType="url" for HyperText when connected to S3

Describe the bug
I have synced a S3 bucket containing some HTML files and used the following settings for labeling
<View>
  <Relations>
    <Relation value="org:founded_by"/>
    <Relation value="org:founded"/>
  </Relations>
  <HyperTextLabels name="label" toName="text">
    <Label value="Organization" background="orange"/>
    <Label value="Person" background="green"/>
    <Label value="Datetime" background="blue"/>
  </HyperTextLabels>
  <HyperText name="text" value="$text" valueType="url"/>
</View>

When I go to the labeling interface I only get the link text and not the html file that I would like to label (notice above that I have used the option valueType="url")
{
  "id": 9,
  "data": {
    "text": "https://<mybucket>.s3.amazonaws.com/doc1.html?<params>"
  },
  "annotations": [],
  "predictions": []
}

In addition, the task postgres table contains the following in the task column
{
    "$undefined$": "s3://<myname>/doc1.html"
}

I would not expect this behavior according to what it is expressed in the documentation for HyperText: https://labelstud.io/tags/hypertext.html
This bug fix would be essential in order to work in a scalable way using HTML files, as a single LS instance does not have to load all the tasks data at once.
Expected behavior
I would expect that the instance of label studio would only render one HTML task (taking the data from the URL) and not all of them. The tasks should be rendered as HTML from the URL. Just one task data at the time should be loaded in the LS instance and not all of them.
Environment:
{
  "package": {
    "version": "1.0.1",
    "short_version": "1.0",
    "latest_version_from_pypi": "1.0.1",
    "latest_version_upload_time": "2021-04-05T19:13:41",
    "current_version_is_outdated": false
  },
  "backend": {
    "commit": "0da33d",
    "date": "2021-04-29 12:26:26 +0300",
    "branch": "master",
    "version": "1.0.1+50.g0da33d6.dirty"
  },
  "label-studio-frontend": {
    "commit": "1dd1b31dfdc9368849c65dff728a551f30ab2c86",
    "branch": "master",
    "date": "2021-04-12T09:15:53Z"
  },
  "dm2": {
    "commit": "7751a996682f145d651123af27286f4f392c293c",
    "branch": "master",
    "date": "2021-04-02T13:15:22Z"
  }
}

@arubino Unfortunately, it's not a backend problem. It's LSF problem - https://github.com/heartexlabs/label-studio-frontend/blob/master/src/tags/object/HyperText.js#L37.
However, if you are able to fix it, it will be very cool!


(ios) Sentry.setUserContext: userId needs to be string

Hey guys,
calling
Sentry.setUserContext({userId: 123}),
will raise below exception while this doesnt:
Sentry.setUserContext({userId: "123"}),
Moreover, setting (other) object props to a null value will raise similarly, eg:
Sentry.setUserContext({userId: "123", email: null}),
Maybe this is intended behavior & I just didnt see the related docs for it?
Using
react-native: 0.42.3
react-native-sentry: 0.7.0
2017-05-09 12:16:47.813[51915:999569] *** Terminating app due to uncaught exception 'RCTFatalException: Exception '-[__NSCFNumber length]: unrecognized selector sent to instance 0xb000000000000385' was thrown while invoking setUser on target RNSentry with params (
        {
        userID = 56;
    }
)', reason: 'Exception '-[__NSCFNumber length]: unrecognized selector sent to instance 0...'

Edit: typo

wow that was fast, thanks! : )


Scrape the #defines for constants out of the headers

There is a huge amount of #defines of well know constants, error values, PROPKEYs, DEVPROPKEYs etc. in the Win32 headers.  It would be very valuable to all of that to be available.
If they can't be auto-generated, please establish a process where by the community can contribute their definitions.

This is already being done by the win32metadata project. You can browse the available definitions here. If something is missing, feel free to create an issue here:
https://github.com/microsoft/win32metadata/issues


Improve forms

This PR improve the quality of forms in data, especially in terms of parentheses and brackets. Only 1,7% of forms are potentially problematic (down from over 11%), they are now more evenly distributed across languages and parameters, and the false positives in terms of colexifications seem solved.
It does so by using three regexes and by extending both the list of replacements and of hand-corrected lexemes. It would be possible to fix all, but I suppose it is preferable this way, as I am only accounting to what I am relatively sure (also by comparing forms in parentheses with other forms and by manually checking some cognates) and as the presence of errors serves to indicate that the quality of data is not the desirable.

I have corrected most of the issues reviewed by @chrzyki , and fixed even more. Problematic entries are now 0,5%.
The enda form is heterogeneous indeed, a characteristic maybe deriving from usage as an auxiliary. As it is heterogeneous in the raw data already, I left it as it is. I have also kept the potential classifier of Sonjo, as it would require more study of the language (but @chrzyki hypothesis seems right).

Looks good. Thanks a bunch @tresoldi. :)


Full Project Pull request

Hi there,
The Below List for what I did on this project

Select the API.
Build files structure for your React app.
Prepare routes and navigation in your app.
Create the tests for the application.
Style your components to match the design provided.
Deploy the project and test for final details.

Loom Video Here
Thank you

Hi @iammouaz 👋,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Garbage data returned by getBuffer when enableAutoPipelining is set to true.

It has been observed that when enableAutoPipelining is set to true, getBuffer returns garbage data. When I set enableAutoPipelining to false, getBuffer returns proper data.
Would it be possible to have a look at this? Looks like PR https://github.com/luin/ioredis/pull/1231 fixes this. Can this be merged if it look ok @luin ? If there is an alternate way you plan to fix this, that is also perfectly fine. Just needed to for reducing load on redis cluster (so that I dont need to do JSON.stringify on compressed data before setting it to redis.).

Closed via #1231. Thanks for the heads up!

Thanks a lot @luin. This indeed works fine.


Doesn't parse CSV file based on detect-threshold when splitting video.

Trying to figure out why i can't use the csv file generated to splti video without having to re-scan. Are scene csv files different from stats csv files? The documentation is unclear.
Procedure:
scenedetect --input "file.mp4" detect-threshold list-scenes
(this works fine)
scenedetect --input "file.mp4" -s file-stats.csv" detect-threshold split-scenes
error:
[PySceneDetect] PySceneDetect v0.5.5
[PySceneDetect] Loaded 1 video, framerate: 29.97 FPS, resolution: 1920 x 1080
[PySceneDetect] Downscale factor set to 6, effective resolution: 320 x 180
[PySceneDetect] Loading frame metrics from stats file: scenes.csv
[PySceneDetect] Could not load stats file.
Failed to parse stats file:
Could not load frame metrics from stats file - file is corrupt or not a valid PySceneDetect stats file. If the file exists, ensure that it is a valid stats file CSV, otherwise delete it and run PySceneDetect again to re-generate the stats file.
[PySceneDetect] Could not parse CLI options.:
Could not load given stats file, see above output for details.

Hey @jeremymeyers;
Indeed, the scene CSVs generated by list-scenes are different than the stats CSV files (-s).  The latter contains frame-by-frame metrics for each detector you are using in order to run statistical analysis (e.g. determining optimal threshold), as well as to speed up subsequent runs.  Sorry that's unclear, is there a particular section of the documentation that you think is difficult to comprehend?  If you're running into this issue, it's likely others are as well, so I'd be happy to have any feedback you can share about the best way to relay that information.
The -s argument is used to both generate and load a statsfile (if the file does not exist, it is created; if it does exist, the existing stats are loaded into memory, updated if required, and written back to disk when PySceneDetect is finished).  In the example above, how did you generate file-stats.csv?  Would you be able to share the first few lines from the file here?  Also, if you could also add -v debug before specifying any other arguments, and provide the output of running that, that would also be very helpful.
The statsfile format was updated in the latest release, but should include backwards compatibility, so that error you're seeing may be an issue.  Lastly, note that detect-threshold currently doesn't benefit from the use of a statsfile outside of determining the optimal threshold, due to some implementation details I still need to work out as part of #178 (as it skips a lot of stats calculations if a particular frame doesn't require it).  Even though detect-threshold it won't currently run faster with a statsfile, you should definitely be able to load/save an existing statsfile.
Thanks!

So my current workflow is based around large files  (1-2gb usually) with collections of around 5-6 short-ish mini-movies that end in cuts to black (usually). I am using scenedect to split the one large file into 5-6 individual files. I'm not using it to split out at a more granular level.
How i have been doing it is to do a detect-threshold list-scenes to determine whether scenedetect has accurately identified the number of scenes and therefore will split correctly (ive found that detect-content lands me with a much longer list of shorter clips, as by design). If it has the correct number (plus or minus a few extra blips in between where it found title sequences or whatever) then i will run it again with split-video.
As you can imagine, I would really love a way to not have to scan through the whole movie twice every time, so I though that i might be able to use the scenes.csv that it generates to split it accordingly. I suppose i could feed it into ffmpeg/mkvmerge directly, but it just seemed like there should be a workflow that accounted for this.
In terms of the documentation i think it would be useful to just note that using the -s flag and using stats files generally only applies when detect-content is used.
I will add the file info shortly.

Indeed the first row of the file outputted from list-scenes does contain all the information required to split the video without re-running PySceneDetect, so you shouldn't have to run it twice here - however it does require some work as you implied by feeding it right into ffmpeg.
That being said, you are correct, this use case is definitely supposed to work with PySceneDetect.  This will be supported properly when #178 is closed.  I'll see if I can squeeze that in for the v0.5.6 release, but in the meantime, hopefully the workaround by using the .csv from list-scenes is a sufficient workaround for you.  Sorry about that, and thanks for the report!

Awesome, thank you Brandon!

This should be resolved now in the v0.5.6 branch, will be available in the next official release.  I also removed the -p/--min-percent argument, as it wasn't really providing any kind of performance or analysis benefit and has no effect on accuracy, since the threshold can be adjusted accordingly to achieve the same result.
Thanks for the report!

What is the syntax for this?

As in your original post, this should now just work:
scenedetect --input file.mp4 -s file-stats.csv detect-threshold split-scenes


Help my phishlets don't captured nothing (mail, pass or cookies)

Help my phishlets sellercentral.amazon.de don't captured nothing (mail, pass or cookies)...any help please

Probably something changed on the website and you can wait for the author to fix the phishlet or you can try to fix it yourself.

can you teach me to make a phishlets?


updated slideshow, nice job Payton

The UW/DoIT Wifi outage of Fall 2017 was an inside job

Going to deny this, just because we have a new logo going in right now. I can make the updates @kfish15 or you can if you would like.


Incorrect log-likelihood token scoring

Update: I confused position indexing (next-token distribution)
Summary
base._loglikelihood_tokens calculates incorrect scores for prompt continuations because of last-token truncation.
Details
Given a "continuation" token sequence of length N, only the first N-1 entries get appended to the corresponding context to form a model input. I.e. model_input = ctx + cont[:-1] , as opposed to the complete model_input = ctx + cont. The relevant lines for last-token-deletion:
inp = torch.tensor(
    (context_enc + continuation_enc)[-(self.max_length + 1) :][:-1],
    dtype=torch.long,
).to(self.device)

Its surrounding source code is found here.
On inspection, what ends up happening is that the continuation logits get improperly sliced from the logits on model input, inp.
inplen  = inp.shape[0]  # NOTE: No batch-dim
...
contlen = len(continuation_enc)
cont_logits = logits[inplen - contlen : inplen]

Since the actual number of continuation tokens (contlen) is greater than the number of continuation tokens fed to the model thru inp, we gather continuation logits from the wrong token positions.
+
https://github.com/EleutherAI/lm-evaluation-harness/blob/b0b76d87fc84b2bfdfa88b71ce4592f35f707428/lm_eval/base.py#L317
Who Can Help
cc @leogao2  - What's the reasoning behind last token deletion? What am I missing?

@jon-tow Hello, I also have doubts about why we need to remove the last token. If you could explain it to me, I would be very grateful.


Abstract methods don't infer argument types

TypeScript Version:  2.2.1
Code
abstract class Abstract<T> {
	abstract init(arg: T): void
}

class Something extends Abstract<string> {
	init(arg) {
		console.log(arg)
	}
}

Expected behavior:
This should work
Actual behavior:
The compiler wants me to reiterate the type of arg in the init function.

I also tried this with the same issue:
interface Abstract<T> {
	init(arg: T): void
}

class Something implements Abstract<string> {
	init(arg) {
		console.log(arg)
	}
}

Covered by #7011

Thanks


how to disable the zoom in tileview

There are many ways.  The most efficient would be probably be to suppress the gesture, but here's an easy way:
tileView.setShouldScaleToFit(false);
tileView.setScaleLimits(1f, 1f);

Thank you, It's working.


RUM-5763: Add TouchPrivacy to Session Replay

What does this PR do?
Adds a TouchPrivacy api. For the moment this api is internal, and will become public later.
Possible values for touch:
SHOW - record all touch interactions
HIDE - do not record touch interactions
Usage example:
SessionReplayConfiguration.Builder()
  .setTouchPrivacy(TouchPrivacy.SHOW)

Motivation
Part of the move to fine grained privacy options.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.02%. Comparing base (cf7bb08) to head (6837edc).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2196   +/-   ##
========================================
  Coverage    70.02%   70.02%
========================================
  Files          726      727    +1
  Lines        27005    27025   +20
  Branches      4527     4528    +1
========================================
+ Hits         18908    18923   +15
- Misses        6827     6831    +4
- Partials      1270     1271    +1

Files
Coverage Δ

...com/datadog/android/sessionreplay/SessionReplay.kt
90.91% <100.00%> (+0.91%)
:arrow_up:

...ndroid/sessionreplay/SessionReplayConfiguration.kt
100.00% <100.00%> (ø)

.../com/datadog/android/sessionreplay/TouchPrivacy.kt
100.00% <100.00%> (ø)

.../sessionreplay/internal/DefaultRecorderProvider.kt
93.44% <100.00%> (+0.11%)
:arrow_up:

...oid/sessionreplay/internal/SessionReplayFeature.kt
99.19% <100.00%> (+0.02%)
:arrow_up:

...nreplay/internal/recorder/SessionReplayRecorder.kt
96.90% <100.00%> (+0.07%)
:arrow_up:

...lay/internal/recorder/WindowCallbackInterceptor.kt
100.00% <100.00%> (ø)

...ternal/recorder/callback/RecorderWindowCallback.kt
91.67% <100.00%> (+0.20%)
:arrow_up:

... and 27 files with indirect coverage changes


Redelegation amount is broken

Describe the bug

The amount on the redelegation tx in the transaction list is showing NaN.
To Reproduce

redelegate
go to page transactions

Expected behavior

it should show the correct redelgation amount
Screenshots

Desktop (please complete the following information):

OS: Mac OS
Browser: Safari
Version: 12.0.3

Smartphone (please complete the following information):

Device:
OS:
Browser
Version

Additional context

I can't reproduce

On develop:


Add Federated SAP S/4HANA Roles to Your Launchpad Site

Tutorials: https://developers.sap.com/tutorials/cp-launchpad-federation-consumption.html
Write here how you think we can improve the tutorial ...
I was able to follow all steps with the exception of step 5 -3 Click Default Identity Provider to access the role collection assignment for users coming from this identity provider.
In my trial account I am not able to access teh Default Identity provide. It is grayed out. The srult is that in the end I can see all tiles, but when opening a tile I get the error a1111111trial.authentication.us10.hana.ondemand.com refused to connect.
I there a work around?

Hi,
Thanks for bringing this up. The way to assign role collections changed recently and I need to adapt this tutorial. Please go to Security > Role Collections instead of Trust Configuration and click on your Role Collection there, then you can add your user in this place to assign it to the role collection. You might need to click the Edit button before you can enter a new user.
Hope that helps.
Best,
Sibylle


update Icon import path

The icon previous icon import path was not working and in the astroicon.dev website it was 'import { Icon } from 'astro-icon/components'; which worked.

Thanks a lot for noticing error and creating pull request!


agent: mark logs with modules

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>@diogomonica @aluzzardi @aaronlehmann @LK4D4 PTAL

LGTM


Fix: use roi_subset labels in nifti header if provided

Currently, if roi_subset is provided during segmentation, the full class map of the task is stored in the nifti header.
This PR fixes the above issue.

Thanks for this improvement!


Hotspot color

Request made to change the hotspot color to make it more easily visible. Should take this into consideration with the new UI and color scheme changes.

similar to #5 but like this approach more. Need to think through this a bit to land in a usable state.


asadiqbal08/ Fix accessibility issue by tabindex to header

@briangrossman can you verify it, Is it good enough as shown in image below.
Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling
[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
fixes: #276
What's this PR do?
When a screen reader user submits the first account creation form (where they enter their email), they do not get an alert to know that a message "We've sent you email" appears. They do not know that the text on the screen has been updated.
The focus should shift when the page changes to the new content such that the screen reader is redirected to the correct element to read it. In this case, one could shift focus to the h1 "thank you etc" followed by instructions to check eMail, etc. That should be enough.
How should this be manually tested?
Test the above criteria while creating an account.
Screenshots (if appropriate)

Codecov Report

Merging #286 (5853a65) into main (3cd5dfb) will decrease coverage by 4.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   91.14%   86.39%   -4.76%
==========================================
  Files         218       93     -125
  Lines        6462     3572    -2890
  Branches      318      318
==========================================
- Hits         5890     3086    -2804
+ Misses        485      399      -86
  Partials       87       87

Impacted Files
Coverage Δ

...ntainers/pages/register/RegisterConfirmSentPage.js

static/js/lib/queries/index.js

static/js/components/forms/elements/FormError.js

static/js/components/forms/ChangePasswordForm.js

static/js/components/Markdown.js

static/js/babelhook.js

...tic/js/containers/pages/login/LoginPasswordPage.js

webpack.config.shared.js

static/js/components/forms/EmailForm.js

static/js/lib/queries/courseRuns.js

... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd5dfb...5853a65. Read the comment docs.

@asadiqbal08
Based on what I'm seeing in the screenshots, it looks like the focus switches to the Thank you! after submitting. If that is the behavior, this looks good to me.


Case sensitivity fix

Resolves issue in plate-mapper where the pull-down menu doesn't populate correctly if the search term is correct, but in a different case (upper vs lower vs mixed, etc.).

closing. Incorporated changes from PR 554 as well by accident.


aws sdk v2

Are there any improvements to the logic in v2, or just API changes?

Are there any improvements to the logic in v2, or just API changes?

just API changes, the v1 sdk is in maintenance mode and being discontinued next year


Only look up package.json type if module is node16/nodenext or file is in node_modules

This walks back the heuristics added to non-Node.js module modes in #57896 a bit, based mostly on feedback in #58663. In 5.5-beta, an explicit package.json "type" or module-format-specific file extension started overriding "module": "commonjs" or "module": "esnext" in tsconfig.json. This impacted both type checking (relevant primarily for imports of node_modules dependencies, but with some effects on local files, e.g. with verbatimModuleSyntax) and emit (relevant for local project source files, if emit was enabled). The feedback in #58663 was that the effects on local files were unwelcome because the emitted files (whether from tsc or another tool) were going to be placed in some other context tsc didn’t know about, so the package.json tsc was finding during compilation shouldn’t be considered during the build.
With this PR, we only look up package.json "type" if --module is node16/nodenext (as we’ve always done) or if the file is inside node_modules. Some testing and experimentation is still needed to ensure this doesn’t create inconsistencies with symlinked monorepos.

@typescript-bot test top400

@typescript-bot pack this

Perf should be unchanged or better, but
@typescript-bot perf test faster

We don't need these new ModuleSpecifierResolutionHost members to be public

@weswigham ModuleSpecifierResolutionHost itself is internal.

There’s a knip failure but it’s public API?

ModuleSpecifierResolutionHost itself is internal.

The specifics are internal, yes, but we expose and consume public objects and interfaces that we use as and expect to be ModuleSpecifierResolutionHosts which cannot be correctly implemented without these being made public in some way. There's a definite reason almost everything on ModuleSpecifierResolutionHost is optional. For example, Program has a second (@internal) declaration declaring it extends ModuleSpecifierResolutionHost. If there are any 3rd-party Programs (like our LS or builder construct internally to orchestrate builds, but external), they won't know they need these new methods on their Program to satisfy ModuleSpecifierResolutionHost uses, and since they're required, we'll just crash at runtime when they're inevitably missing.

There are 43 non-optional internal methods and properties declared on public Program interface declaration—we haven’t made it possible to implement a third-party Program up from its public interface.

@weswigham any other feedback on the API (or any of the PR)? I’d like to get this in soon.


Add version field to package.json

Yarn complains if a package doesn't have a version field, even when pulled from GitHub. This adds one.

Think this is non-controversial.

Hmm what about that beta release to npm @treshugart this feels dirty to me :-|

This was just to get yarn to not complain when using the GitHub branch. I didn't publish anything :)

Why do you think this is dirty?

yup I know why you did that @matthewp. Anyway semantic release automatically bumps version and during maintainers call we discussed this and came to a conclusion that beta release is the best and standard way to go, not installing from github.

If you publish with --tag beta then normal installs will get the 4.x releases. This is what I assume you want, no?
Anyways, you're right that installing from git is not the norm, but I have no other choice at this time. I'm happy to release a beta from 5.x if that is what you all want. Is it?


fix nix build

Context
Reason for the change? If an issue exists, reference it here using a keyword
Proposed Solution
Important Changes Introduced

Hey, thanks for this! Works great for me!


Content Suggestion: "Le Coin de Table" (Discover Bitcoin while playing) Card game

Link to Content:  (http://www.maximalist.ovh/)

Briefly Describe Content:
Board game to discover the Bitcoin universe while having fun.
From 2 to 4 people.

Be the first to build a complete chain of the 5 yellow cards.
Red cards make you lose cards (bitcoin or fiat money).
With the EXCHANGE card, you can quickly exchange your FIAT MONEY for Bitcoin. When the CRISIS card arrives, the FIAT MONEY is worthless for all players and goes in the trash.
Rules included: English, French, Italian, Spanish, German. (Portuges soon).
the game is already use for play but also as a classroom lesson material.

Suggested Section: spend bitcoin / fun and play

See the game on the website http://www.maximalist.ovh/

This site accepts altcoins for payment.

Thanks Pardus.
@bigcoincoin Unfortunatley this site is not suitable for listing.

Altcoin Payment
Affiliate links to Ledger & Coinbase (Both market altcoins to newcomers)


Respect HTTP proxy system properties

I think our Java SDKs should support the HTTP/HTTPS proxy system properties, as defined at https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html.  This includes http.proxyHost and http.proxyPort, along with the corresponding HTTPS properties (if they can be supported).  I believe these properties are ignored by Netty, so our SDK would need to read the properties and pass them along to Netty.

These properties do seem to be respected by the v8 Java Storage SDK (com.microsoft.azure.azure-storage@8.4.0).

Related Proxy work items that could be tackled at the same time

https://github.com/Azure/azure-sdk-for-java/issues/6109
https://github.com/Azure/azure-sdk-for-java/issues/5725
https://github.com/Azure/azure-sdk-for-java/issues/5372

@alzimmermsft can you PTAL since you're already working on better proxy support?


[FIX] Loader Asset and Icon

Fix: #5
Description

Fix loader asset loader.svg on import
Fix icons by adding kata-icons.css on entry file

LGTM 👍

@nurcahyopujo approve dong


WYSIWYG: Toolbar button state at the end of a "block" does not match input

Describe the bug
When you are in WYSIWYG mode and you click at the end of a "block" (e.g. bold) the toolbar button does not show as active. But when you type the text still gets formatted as bold.
To Reproduce

Type a text in WYSIWYG and make a part of it bold.
Navigate to the end of the bold text (either mouse or arrow keys)
The toolbar button for bold will not be active
Now type something and the text will still be bold

Expected behavior
The toolbar buttons should be highlighted according to what the next input at the cursor position would be. So in my example either the text entered should not be bold or the button should be highlighted.
Screenshots

If you type at this position the text will be bold but the button is not highlighted.

@stefan-schweiger
Thanks for reporting.
It's ambiguous under the below example, but I'll try to improve it later.


[GB18030] Fail to create a collection which partition key name contains New Tai Lue/Lisu/Chinese Four Ext chars/Tibetan language

OS: Win10
Build Version: v0.19.4
Regression: Not a Regression
GB18030 Language: New Tai Lue/Lisu/Chinese Four Ext chars/Tibetan
Repro Steps:

Create a SQL account -> Create a Database -> Create a collection -> Type a partition key contains GB18030 characters, such as New Tai Lue: "ᦷᦎᦺᦑᦺᦖᧈᦉᦲᧇᦉ".
Check whether succeeds to create a collection.

Expect:
Succeed to create a collection.
Actual:
Fail to create a collection.

This issue doesn't reproduce for the Mongolian/Yi/Uyghur/De Hong Dai/Korean Letter/Double Chinese/Old Tai Lue language.

This issue also reproduces for 康熙部首.


Use git fsck to find missing files

The tool could be improved by running git fsck at the end to find missing files.

The tool could be improved by running git fsck at the end to find missing files.

Could you elaborate ? Running this command will outputs missing files hashes, but I believe they are mostly contained within packed objects that weren't found by the py script

That was just a thought, I didn't take the time to dig into it.
You are probably right, that won't help find missing packed objects.

As discussed, that most likely won't help. Closing.


Is there a way to return profile info like avatar and nickname?

Curious to know how I would use this library to register a user with his steam info like avatar or nickname. Could it be done through steam's response or it should be done through community endpoints?

hello yes indeed community endpoints like steam endpoint

Answered in the readme.


glooctl: 1.14.12 -> 1.15.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/solo-io/gloo/releases.
meta.description for glooctl is: glooctl is the unified CLI for Gloo
meta.homepage for glooctl is: https://docs.solo.io/gloo-edge/latest/reference/cli/glooctl/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.15.2 with grep in /nix/store/w1436ig0vj7z8vf2l6f09cq6hsq1g4fc-glooctl-1.15.2
found 1.15.2 in filename of file in /nix/store/w1436ig0vj7z8vf2l6f09cq6hsq1g4fc-glooctl-1.15.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
glooctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w1436ig0vj7z8vf2l6f09cq6hsq1g4fc-glooctl-1.15.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A glooctl https://github.com/r-ryantm/nixpkgs/archive/6f90c78ed865d2dedd593fde3a7b6b98084f61cb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w1436ig0vj7z8vf2l6f09cq6hsq1g4fc-glooctl-1.15.2
ls -la /nix/store/w1436ig0vj7z8vf2l6f09cq6hsq1g4fc-glooctl-1.15.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

glooctl

Maintainer pings
cc @NelsonJeppesen for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/solo-io/gloo/releases.
meta.description for glooctl is: glooctl is the unified CLI for Gloo
meta.homepage for glooctl is: https://docs.solo.io/gloo-edge/latest/reference/cli/glooctl/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.15.4 with grep in /nix/store/033nhb53i4b7jxgpcg471h5p6s4siw7d-glooctl-1.15.4
found 1.15.4 in filename of file in /nix/store/033nhb53i4b7jxgpcg471h5p6s4siw7d-glooctl-1.15.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
glooctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/033nhb53i4b7jxgpcg471h5p6s4siw7d-glooctl-1.15.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A glooctl https://github.com/r-ryantm/nixpkgs/archive/befdc3bbca1a3a5805b2de39afdf4226f1519592.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/033nhb53i4b7jxgpcg471h5p6s4siw7d-glooctl-1.15.4
ls -la /nix/store/033nhb53i4b7jxgpcg471h5p6s4siw7d-glooctl-1.15.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

glooctl

Maintainer pings
cc @NelsonJeppesen for testing.


Powers take too long

For my application I need to compute multiple powers. However, it seems that for certain amounts of fractional bits n_frac, powers take too long to compute. For example:
from fxpmath import Fxp

k = 30

e = 10
x = Fxp(1, signed=True, n_word=k, n_frac=e)
z = x ** 1 # Takes about 1s

e = 15
x = Fxp(1, signed=True, n_word=k, n_frac=e)
z = x ** 1 # Never finishes

Why is this? One would expect powers to be relatively fast, specially one as x ** 1.
Any advice on this would be very useful, I don't want to redefine the method. Thanks!

Hello,
By default, when you do a operation between a Fxp and a constant, that constant is casted to a same Fxp type. So, going deep in details, you are not performing a power of 1 but a power with 1 * 2**10 under the hood. Fxpmath is trying to calculate in fixed point, so that calculation is time demanding.
If you don't to emulate a fixed point power with that precision, try:
z = x ** Fxp(1) # Fxp(1) create a fixed point with enough precision -> n_frac = 0

There is another way, calculate in floating point under the hood, but this doesn't emulate fixed point precision.

Thank you @francof2a.
I will need to evaluate polynomials using fixed-point inputs, for which I will need powers. I literally need x ** k to perform x * x * ... * x, k times. I tried your solution and it indeed works, or at least it seems faster. I will use that for now and let you know if I have any other concern.
Thanks for the nice work!

Thanks for the feedback.
Closing the issue!
Do not hesitate to ask if you have any questions


Update README.md

Fix the "Download the file" link

I'm a little concerned with CI not validating this commit (Seems like something broke recently) but I'll merge this when I fix it, thanks!

Merged. CI failed because it's such an old branch, but it's just a changed link so it's fine.


[Question] How to interpret boxes in object detection example ?

hi,
can anyone help me how to interpret boxes while using object detection with this model "Xenova/detr-resnet-50".
i want to crop out the detected object from the image using sharp (nodejs) ? how can i pass these boxes to sharp resize function ?

Hi there! 👋 I am updating the documentation to make it clearer how the output should be interpreted 👍 While running some example code, I actually noticed that I am returning the post-processed values, but not in the same format as the python library. I'll fix that!

These updates are now in v2.4.1 🚀
Here are the updated docs: https://huggingface.co/docs/transformers.js/api/pipelines#module_pipelines.ObjectDetectionPipeline
These new outputs are far easier to understand:
let img = 'https://huggingface.co/datasets/Xenova/transformers.js-docs/resolve/main/cats.jpg';

let detector = await pipeline('object-detection', 'Xenova/detr-resnet-50');
let output = await detector(img, { threshold: 0.9 });
// [{
//   "score": 0.9976370930671692,
//   "label": "remote",
//   "box": { "xmin": 31, "ymin": 68, "xmax": 190, "ymax": 118 }
// },
// ...
// {
//   "score": 0.9984092116355896,
//   "label": "cat",
//   "box": { "xmin": 331, "ymin": 19, "xmax": 649, "ymax": 371 }
// }]


No snapshot, please!

I'm closing this as off topic. Please see our Contributing.md for the types of feedback we're looking for on our Site Policies in this repo.


IES ITACA

IES ITACA

Please add my high school.

@jveronE-itaca I am sorry for a delay with processing your request.
Pull request merged. Thank you!


lazy create connection

part of https://github.com/bartlomieju/deno-postgres/issues/49
lazy to create connections from 1 to max pool size

Thanks for contribution! I intend to rewrite connection pool completely so I'm not gonna merge this now, but will revisit later.


Set app menu bar from webapp menu bar

Homework

[x] I looked at nativefier --help and https://github.com/nativefier/nativefier/blob/master/API.md , no existing option fits my needs.
[x] I searched existing issues, open & closed. Yes, my feature request is new.
[x] I'm using the latest version available at https://github.com/nativefier/nativefier/releases

Problem statement

As you can see in the image there are applications like https://github.com/cdr/code-server that actually have a menu bar that could be put in the macOS app menu.
Suggested solution
It would be great if this menu bar of the web app could be put/accessed into the macOS app menu bar.
Alternative solutions
I have tried to set the -m/--show-menu-bar flag of nativefier but it did not help.
Context

Nativefier: 44.0.7
Node.js: 16.4.2
Npm: 7.18.1
OS: macOS 11.4

The menu bar in webapps is just DOM elements and is done differently for every app, so we would have to write different code to extract the items for every supported app. Then we would have to somehow communicate this to the electron code that sets the menu bar, and it would have to communicate this back and emulate a click on the DOM element that the webapp menubar is made of or somehow trigger the action. This would be really cool but seems like the kind of thing that would be a pain to maintain unless there was some kind of standard.

I must agree with @mattruzzi here. I usually leave feature requests open regardless of the probability to implement, but this is so far-fetched that it makes no sense to implement and maintain. If you want progress on this, as hinted by Matt, you can try to help standardize such a thing, and work with browser makers.
With that, closing as wontfix.


Document .svg file constraints

When I first started to use the plugin I was getting an error "Bad ppm or 14" and it took me ages to figure out the problem was that my source SVG were of 14x14px dimension.
I suspect the underlying ttf / woff libraries convert to and integer coordinate space at some point and impose a minimum size requirement. Would be useful if you added a warning to the readme.
Also note that every .svg has to have the same width/height.
Also note that small source dimensions (e.g. 32x32px) will not error out, but will suffer from jagged rounding errors in the resultant typeface and look bad.
Also note SVG masks and transforms blow up half the time. Best to avoid any masks, and flatten in your editor before exporting.
I personally ended up sizing everything to 1400x1400px so the result is evenly divided into a 14px base font size using whole em/rem units in CSS.

Sure just send over a pull request 👍


Fix for nice() at certain scales.

The fix for #9 was causing me some problems with scale.  I was getting the following behavior, which I'm pretty sure isn't expected:
const scale = d3.scaleLinear().domain([0, 14.1]).nice(5);
scale.domain(); // [0, 15]
scale.ticks(5); // [0, 2, 4, 6, 8, 10, 12, 14]

I was essentially having the reverse problem to the other users in in the issue.  When stepping through, nice() was selecting a step size of 2 in its first calculation, then going back to 5 for its second (and thus not updating the domain).  However, ticks() was calculating 2 as its step size, and therefore only going up to 14.
These are not the only numbers where I was seeing this problem, I just picked these ones in particular for an example.
The fix here updates the domain twice, instead of only updating the step size twice.  I think it fixes my problem, without adversely affecting any other situations.  In the example I gave, we now have
const scale = d3.scaleLinear().domain([0, 15]).nice(5);
scale.domain(); // [0, 20]
scale.ticks(5); // [0, 5, 10, 15, 20]

I think under ideal circumstances we'd have,
scale.domain([0, 15]).ticks(5) // [0, 5, 10, 15]

But changing that would require changing the tick error constants, and I'm guessing there's a reason they are the way they are.

I’ve revised your implementation slightly, but it should be functionally equivalent. Seems like a reasonable fix to me. Thank you!


Tests and cleanup for #610 (output_variables fallback behavior)

[Short description explaining the high-level reason for the pull request]
Additions

Two tests for invalid entries in output_variables

Removals

Obsolete fallback condition code in Bmi_Multi_Formulation.cpp

Changes

Testing

Screenshots
Notes

Todos

Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[X] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist (automated report can be put here)

Target Environment support

[X] Linux

As a side note, the test logic in Bmi_Multi_Formulation_Test.cpp is probably overengineered at this point... we need tests to make sure the test code produces what it's supposed to. Seems like there should be an easier way.

I only have some rather trivial comments. On line 486 of Bmi_Multi_Formulation_Test.cpp, the comment line, the number of example scenarios should now be 6?
In the same file, line 635-636, it is probably better to remove one of the empty lines.


Support object label selector for istioctl analyze

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Releated to https://github.com/istio/istio/issues/27772
If users use Helm as their application deployment tool, Helm will use secrets as the default storage doc
This will result in a large number of secrets in the cluster, and since it stores chart values, the content is usually very large.
istioctl analyze during the initialization phase, it will wait to synchronize all the secrets, but these objects are useless for analysis. If there are too many secrets, it will not only affect the analysis time but may also cause kube-apiserver to fail to synchronize completely.
I want to add a new "resource-filters" parameter so that users can filter out specific objects using a label selector. doc kube-apiserver will not send these objects content to client.
Example:
istioctl analyze -A -F "Secret owner!=helm"
In my testing environment, in a scenario with over 2000 secrets, the execution time of istioctl analyze -A has been reduced from 8s to 1.2s.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

The filter idea sounds good to me. We may need to polish the flag usage a little bit, since -F maybe stands for force or file. It seems like you have already implemented the code, would you like to share it?

OK. I will submit a PR later.

We should just filter automatically. We already do in the main code:
pilot/pkg/credentials/kube/secrets.go
83-     // Its also likely users have started to use random types and expect them to continue working.
84-     // This makes the assumption we will never care about Helm secrets or SA token secrets - two common
85-     // large secrets in clusters.
86-     // This is a best effort optimization only; the code would behave correctly if we watched all secrets.
87-     fieldSelector := fields.AndSelectors(
88:             fields.OneTermNotEqualSelector("type", "helm.sh/release.v1"),
89-             fields.OneTermNotEqualSelector("type", string(v1.SecretTypeServiceAccountToken))).String()
90-     secrets := kclient.NewFiltered[*v1.Secret](kc, kclient.Filter{
91-             FieldSelector: fieldSelector,
92-     })
93-