[SPARK-18895][TESTS] Fix resource-closing-related and path-related test failures in identified ones on Windows

What changes were proposed in this pull request?
There are several tests failing due to resource-closing-related and path-related  problems on Windows as below.

RPackageUtilsSuite:

- build an R package from a jar end to end *** FAILED *** (1 second, 625 milliseconds)
  java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729427517-0\a\dep2\d\dep2-d.jar
  at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
  at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
  at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)

- faulty R package shows documentation *** FAILED *** (359 milliseconds)
  java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729428970-0\dep1-c.jar
  at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
  at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
  at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)

- SparkR zipping works properly *** FAILED *** (47 milliseconds)
  java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4

C:\projects\spark\target\tmp\1481729429282-0

    ^
  at java.util.regex.Pattern.error(Pattern.java:1955)
  at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2781)

InputOutputMetricsSuite:

- input metrics for old hadoop with coalesce *** FAILED *** (240 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics with cache and coalesce *** FAILED *** (109 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics for new Hadoop API with coalesce *** FAILED *** (0 milliseconds)
  java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-9366ec94-dac7-4a5c-a74b-3e7594a692ab\test\InputOutputMetricsSuite.txt, expected: file:///
  at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
  at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
  at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)

- input metrics when reading text file *** FAILED *** (110 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics on records read - simple *** FAILED *** (125 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics on records read - more stages *** FAILED *** (110 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics on records - New Hadoop API *** FAILED *** (16 milliseconds)
  java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-3f10a1a4-7820-4772-b821-25fd7523bf6f\test\InputOutputMetricsSuite.txt, expected: file:///
  at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
  at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
  at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)

- input metrics on records read with cache *** FAILED *** (93 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input read/write and shuffle read/write metrics all line up *** FAILED *** (93 milliseconds)
  java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
  at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)

- input metrics with interleaved reads *** FAILED *** (0 milliseconds)
  java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-2638d893-e89b-47ce-acd0-bbaeee78dd9b\InputOutputMetricsSuite_cart.txt, expected: file:///
  at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
  at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
  at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)

- input metrics with old CombineFileInputFormat *** FAILED *** (157 milliseconds)
  17947 was not greater than or equal to 300000 (InputOutputMetricsSuite.scala:324)
  org.scalatest.exceptions.TestFailedException:
  at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
  at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
  at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)

- input metrics with new CombineFileInputFormat *** FAILED *** (16 milliseconds)
  java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-11920c08-19d8-4c7c-9fba-28ed72b79f80\test\InputOutputMetricsSuite.txt, expected: file:///
  at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
  at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
  at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)

ReplayListenerSuite:

- End-to-end replay *** FAILED *** (121 milliseconds)
  java.io.IOException: No FileSystem for scheme: C
  at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
  at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)

- End-to-end replay with compression *** FAILED *** (516 milliseconds)
  java.io.IOException: No FileSystem for scheme: C
  at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
  at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
  at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)

EventLoggingListenerSuite:

- End-to-end event logging *** FAILED *** (7 seconds, 435 milliseconds)
  java.io.IOException: No FileSystem for scheme: C
  at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
  at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
  at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)

- End-to-end event logging with compression *** FAILED *** (1 second)
  java.io.IOException: No FileSystem for scheme: C
  at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
  at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
  at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)

- Event log name *** FAILED *** (16 milliseconds)
  "file:/[]base-dir/app1" did not equal "file:/[C:/]base-dir/app1" (EventLoggingListenerSuite.scala:123)
  org.scalatest.exceptions.TestFailedException:
  at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
  at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
  at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)

This PR proposes to fix the test failures on Windows
How was this patch tested?
Manually tested via AppVeyor
Before
RPackageUtilsSuite: https://ci.appveyor.com/project/spark-test/spark/build/273-RPackageUtilsSuite-before
InputOutputMetricsSuite: https://ci.appveyor.com/project/spark-test/spark/build/272-InputOutputMetricsSuite-before
ReplayListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/274-ReplayListenerSuite-before
EventLoggingListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/275-EventLoggingListenerSuite-before
After
RPackageUtilsSuite: https://ci.appveyor.com/project/spark-test/spark/build/270-RPackageUtilsSuite
InputOutputMetricsSuite: https://ci.appveyor.com/project/spark-test/spark/build/271-InputOutputMetricsSuite
ReplayListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/277-ReplayListenerSuite-after
EventLoggingListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/278-EventLoggingListenerSuite-after

Test build #70238 has started for PR 16305 at commit 00d5322.

Build started: [TESTS] org.apache.spark.scheduler.EventLoggingListenerSuite
Build started: [TESTS] org.apache.spark.scheduler.ReplayListenerSuite
Build started: [TESTS] org.apache.spark.metrics.InputOutputMetricsSuite
Build started: [TESTS] org.apache.spark.deploy.RPackageUtilsSuite
Diff: https://github.com/apache/spark/compare/master...spark-test:08CE93A8-BCB1-47D9-8683-755109827A62

cc @srowen, Could you please take a look?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70238/
Test FAILed.

Thanks @HyukjinKwon I'll take a look at this tomorrow - BTW do either you or @srowen know why we see errors of the form KeyError: -9 in Jenkins ? I also saw this on another PR [2]
...
  File "./dev/run-tests-jenkins.py", line 219, in main
    test_result_code, test_result_note = run_tests(tests_timeout)
  File "./dev/run-tests-jenkins.py", line 140, in run_tests
    test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
KeyError: -9

[2] https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70236/console for #16290

https://github.com/apache/spark/pull/16307 seems too. I am not too sure but I think (IIRC) I have seen this time to time. I also want to know if these have been manually fixed by someone so far or simply it is something gone wrong in Jenkins itself.

retest this please

Test build #70247 has started for PR 16305 at commit 00d5322.

Test build #70247 has finished for PR 16305 at commit 00d5322.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70247/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #70252 has started for PR 16305 at commit 00d5322.

Test build #70252 has finished for PR 16305 at commit 00d5322.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70252/
Test FAILed.

Test build #3506 has started for PR 16305 at commit 00d5322.

cc @shaneknapp https://github.com/apache/spark/pull/16305#issuecomment-267540707 is the comment with the Jenkins errors I was talking about

re @shivaram -- this is totally bizarre, and nothing is popping in to mind about what could be causing this.  it's definitely not the build timeout (5 hours) or the timeout in run-tests-jenkins.py, nor are any system cleanup cron jobs running that could be responsible for this.
i'll keep poking around and trying to figure this out.

Had a minor question on the inline comment. Otherwise the RPackageUtils change LGTM

test this please

Test build #70276 has started for PR 16305 at commit 00d5322.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70276/
Test FAILed.

retest this please

Ah, thank you @shivaram and @shaneknapp.

Test build #70286 has started for PR 16305 at commit 00d5322.

Test build #70291 has started for PR 16305 at commit 0475ac5.

Test build #70286 has finished for PR 16305 at commit 00d5322.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70286/
Test PASSed.

Test build #70291 has finished for PR 16305 at commit 0475ac5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70291/
Test PASSed.

Thanks @HyukjinKwon - Merging into master

@shaneknapp, about https://github.com/apache/spark/pull/16305#issuecomment-267665207, I know it is a too wide guess but I have seen this -9 when someone rebases multiple times before the build is started quickly and it seems making other build failed too. I have seen this three-ish times recently. This is a wild guess but I would like to note this just in case.

yeah...  there's really not much we can do about this.  thanks for bringing
it to my attention tho.
On Fri, Mar 17, 2017 at 12:40 AM, Hyukjin Kwon<EMAIL_ADDRESS>wrote:

@shaneknapp https://github.com/shaneknapp, about #16305 (comment)
https://github.com/apache/spark/pull/16305#issuecomment-267665207, I
know it is a too wide guess but I have seen this -9 when someone rebases
multiple times before the build is started quickly and it seems making
other build failed too. I have seen this three-ish times recently. This is
a wild guess but I would like to note this just in case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/16305#issuecomment-287287590, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABiDrN1jp8nEiu0mrg_oIYZBKa9iOcP7ks5rmjjwgaJpZM4LO5_z
.


License script can be faster if frequently updated //third_party dependencies are treated separately.

Currently, the license script treats all dependencies in //third_party as a single entity. This works fine in most cases since the bulk of the day to day updates are in //flutter. However, the Skia dependency is updated fairly often and causes checking of licenses in the entirety of //third_party again on each roll. If we treated the //third_party/skia dependency separately (or just the Android the NDK), the script could be much faster when updates to Skia are necessary.

We now break out Skia, Fuchsia, Flutter, and third_party.


VTMsite Suggestion:  Spending XP

Submitter: Emmet Harris
Pretty sweet interactive character builder!  Nice work.  I reckon that it would be truly next level if there were a feature somewhat like the freebies option that permits character advancement as well.
I guess the interactive character sheet does the job for many Storytellers for that, but if you are looking to bang out a bunch of elders quickly of all about the same XP, this sort of tool is way, way better than an interactive pdf on its own.

Adding XP for character advancement has been suggested before, in #141. However, I do appreciate the continued interest and suggestion, as it shows where the priority of my userbase is. Thanks!


otel traces for lambda functions invoked by MSK

Regarding the following lambda-xray limitation noted in the xray docs site
“X-Ray tracing is currently not supported for Lambda functions with Amazon Managed Streaming for Apache Kafka (Amazon MSK), self-managed Apache Kafka, or Amazon MQ with ActiveMQ and RabbitMQ event source mappings.“
https://docs.aws.amazon.com/lambda/latest/dg/services-xray.html
Would the above limitation apply when using the aws-otel-lambda layer pattern, propagating to xray or otherwise?

Have learned its not currently supported therefore closing.


[BUG] Unable recover pvc from replica

Describe the bug
A clear and concise description of what the bug is.

I was doing upgrades to add caching to another node (ryzen1 in the img). During which I unscheduled that node in longhorn and removed the data on the disks. The data showed that it was replicated on the other node (pfdc-store-2). However, when I rejoined the node there was no data replicating and a lot of faulted PVCs.
I tried to follow your guide on https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/export-from-replica/ and see the data at /mnt/hhd3/replicas/pvc-9aa914cf-4eca-46df-af05-24230fe26a53-c0f118c9, though it doesn't appear to be mounting when I run podman run -v /dev:/host/dev -v /proc:/host/proc -v /mnt/hhd3/replicas/pvc-9aa914cf-4eca-46df-af05-24230fe26a53-c0f118c9:/volume --privileged longhornio/longhorn-engine:v1.1.0 launch-simple-longhorn pvc-9aa914cf-4eca-46df-af05-24230fe26a53-c0f118c9<PHONE_NUMBER>40...
To Reproduce
Steps to reproduce the behavior:

Set node as unschedulable, with all devices, with replicas on another node
Format disks on first
See errors
Try to salvage, goes back to failure
Fail to mount using podman
Stay up for 24 hours
It's possible that the CNI caused connection issues due to a misconfig/firewall rule that was fixed before this began. Though the dashboard showed healthy replicas, and I can ls what appears to be a number of snapshots.

Expected behavior
Salvage should work or show an error if it doesn't. Metadata for volume.meta should show progression if possible...
[root@pfdc-store-2 ~]# cat /mnt/hhd3/replicas/pvc-9aa914cf-4eca-46df-af05-24230fe26a53-c0f118c9/volume.meta
{"Size":171798691840,"Head":"volume-head-002.img","Dirty":true,"Rebuilding":true,"Error":"","Parent":"volume-snap-f56788f1-cb0c-46b8-81ac-a8ef6efd00c5.img","SectorSize":512,"BackingFileName":""}

Log
If applicable, add the Longhorn managers' log when the issue happens.
longhorn-support-bundle_41d54631-ab77-49cc-80a3-f911aa50fc87_2021-06-09T16-29-58Z.zip
Environment:

Longhorn version: 1.1.1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: kubeadm

Number of management node in the cluster: 3
Number of worker node in the cluster: 2

Node config

OS type and version: Mix (Arch, Ubuntu)
CPU per node: Mix (16-48)
Memory per node: Mix (32-64)
Disk type(e.g. SSD/NVMe): hdd
Network bandwidth between the nodes: 1gbps

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 6

Additional context
Add any other context about the problem here.
Mentioned in slack a bit at https://rancher-users.slack.com/archives/CC2UQM49Y/p1623221184110900

Additional slack thread:
https://rancher-users.slack.com/archives/CC2UQM49Y/p1623263641124000

After much effort, and not using the sshfs remote mount VM,
All volumes that have volume.meta's Rebuilding: false will mount using the image longhornio/longhorn-engine:v1.1.1
All volumes that have volumes.meta's Rebulding key manually set to false will mount using the image longhornio/longhorn-engine:v1.1.1
All volumes continue to be in a failed state and will not automatically or manually salvage
It is still unknown why this suddenly decided to work. I remember... variants of using the 1.1.0 image vs 1.1.1 (bash history shows success with 1.1.1, which makes sense, but my memory says otherwise possibly), and trying and it failing, then trying again after 6 hours.

Unfortunately, some of the devices mounted can't be and this has resulted in data loss
[root@pfdc-store-2 ~]# podman run -v /dev:/host/dev -v /proc:/host/proc -v /mnt/hhd2/replicas/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-a19d84c0 --privileged longhornio/longhorn-engine:v1.1.1 launch-simple-longhorn pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d<PHONE_NUMBER>00
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
+ set -e
+ mount --rbind /host/dev /dev
+ volume=pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d
+ size=161061273600
+ frontend=
+ '[' -z pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d ']'
+ '[' -z<PHONE_NUMBER>00 ']'
+ '[' -z ']'
+ echo Use default frontend TGT block device
Use default frontend TGT block device
+ frontend=tgt-blockdev
+ exec longhorn-instance-manager daemon
+ start
+ set +e
+ true
+ /usr/local/bin/grpc_health_probe -addr localhost:8500
time="2021-06-13T04:00:56Z" level=info msg="Storing process logs at path: /var/log/instances"
[longhorn-instance-manager] time="2021-06-13T04:00:56Z" level=info msg="Instance Manager listening to localhost:8500"
timeout: failed to connect service "localhost:8500" within 1s
+ [[ 2 -eq 0 ]]
+ sleep 1
+ true
+ /usr/local/bin/grpc_health_probe -addr localhost:8500
status: SERVING
+ [[ 0 -eq 0 ]]
+ echo longhorn instance manager is ready
longhorn instance manager is ready
+ break
+ set -e
+ tgtd -f
+ longhorn-instance-manager process create --name pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r --binary /usr/local/bin/longhorn --port-count 15 --port-args --listen,localhost: -- replica /volume/ --size<PHONE_NUMBER>00
+ tee /var/log/tgtd.log
tgtd: iser_ib_init(3431) Failed to initialize RDMA; load kernel modules?
tgtd: work_timer_start(146) use timer_fd based scheduler
tgtd: bs_init(387) use signalfd notification
[longhorn-instance-manager] time="2021-06-13T04:00:58Z" level=info msg="Process Manager: prepare to create process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r"
[longhorn-instance-manager] time="2021-06-13T04:00:58Z" level=info msg="Process Manager: created process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r"
{
        "name": "pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r",
        "binary": "/usr/local/bin/longhorn",
        "args": [
                "replica",
                "/volume/",
                "--size",
                "161061273600",
                "--listen",
                "localhost:10000"
        ],
        "portCount": 15,
        "portArgs": [
                "--listen,localhost:"
        ],
        "processStatus": {
                "state": "starting",
                "errorMsg": "",
                "portStart": 10000,
                "portEnd": 10014
        },
        "deleted": false
}
+ sleep 5
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r] time="2021-06-13T04:00:58Z" level=info msg="Creating volume /volume/, size<PHONE_NUMBER>00/512"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r] time="2021-06-13T04:00:58Z" level=info msg="Starting to create disk" disk=000
time="2021-06-13T04:00:58Z" level=info msg="Finished creating disk" disk=000
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r] time="2021-06-13T04:00:58Z" level=info msg="Listening on data server localhost:10001"
time="2021-06-13T04:00:58Z" level=info msg="Listening on sync agent server localhost:10002"
time="2021-06-13T04:00:58Z" level=info msg="Listening on gRPC Replica server localhost:10000"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r] time="2021-06-13T04:00:58Z" level=info msg="Listening on sync localhost:10002"
[longhorn-instance-manager] time="2021-06-13T04:00:58Z" level=info msg="Process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r has started at localhost:10000"
+ longhorn-instance-manager process create --name pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e --binary /usr/local/bin/longhorn --port-count 1 --port-args --listen,localhost: -- controller pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d --frontend tgt-blockdev --replica tcp://localhost:10000
[longhorn-instance-manager] time="2021-06-13T04:01:03Z" level=info msg="Process Manager: prepare to create process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e"
[longhorn-instance-manager] time="2021-06-13T04:01:03Z" level=info msg="Process Manager: created process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e"
{
        "name": "pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e",
        "binary": "/usr/local/bin/longhorn",
        "args": [
                "controller",
                "pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d",
                "--frontend",
                "tgt-blockdev",
                "--replica",
                "tcp://localhost:10000",
                "--listen",
                "localhost:10015"
        ],
        "portCount": 1,
        "portArgs": [
                "--listen,localhost:"
        ],
        "processStatus": {
                "state": "starting",
                "errorMsg": "",
                "portStart": 10015,
                "portEnd": 10015
        },
        "deleted": false
}
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:03Z" level=info msg="Starting with replicas [\"tcp://localhost:10000\"]"
time="2021-06-13T04:01:03Z" level=info msg="Connecting to remote: localhost:10000"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:03Z" level=info msg="Opening: localhost:10000"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-r] time="2021-06-13T04:01:03Z" level=info msg="New connection from: <IP_ADDRESS>:58218"
time="2021-06-13T04:01:03Z" level=info msg="Opening volume /volume/, size<PHONE_NUMBER>00/512"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:03Z" level=info msg="Adding backend: tcp://localhost:10000"
time="2021-06-13T04:01:03Z" level=info msg="Start monitoring tcp://localhost:10000"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:03Z" level=info msg="Get backend tcp://localhost:10000 revision counter 0"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:03Z" level=info msg="device pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d: SCSI device /dev/longhorn/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d shutdown"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] go-iscsi-helper: tgtd is already running
tgtd: device_mgmt(246) sz:110 params:path=/var/run/longhorn-pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d.sock,bstype=longhorn,bsopts=size=161061273600
tgtd: bs_thread_open(409) 16
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:04Z" level=info msg="go-iscsi-helper: found available target id 1"
time="2021-06-13T04:01:04Z" level=info msg="New data socket connection established"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:04Z" level=info msg="default: automatically rescan all LUNs of all iscis sessions"
[longhorn-instance-manager] time="2021-06-13T04:01:04Z" level=info msg="wait for gRPC service of process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e to start at localhost:10015"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:05Z" level=info msg="Creating device /dev/longhorn/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d 8:208"
[pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e] time="2021-06-13T04:01:05Z" level=info msg="device pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d: SCSI device sdn created"
time="2021-06-13T04:01:05Z" level=info msg="Listening on gRPC Controller server: localhost:10015"
[longhorn-instance-manager] time="2021-06-13T04:01:05Z" level=info msg="wait for gRPC service of process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e to start at localhost:10015"
[longhorn-instance-manager] time="2021-06-13T04:01:05Z" level=info msg="Process pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d-e has started at localhost:10015"

[root@pfdc-store-2 ~]# mount /dev/longhorn/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d /mnt/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d
mount: /mnt/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d: wrong fs type, bad option, bad superblock on /dev/longhorn/pvc-e206be98-3dd5-4d38-89d0-ce11cc64110d, missing codepage or helper program, or other error.

Per discussion from Slack channel, user is using SSHFS mount as @joshimoo summarized from Slack https://rancher-users.slack.com/archives/CC2UQM49Y/p1623324105156600?thread_ts=1623263641.124000&cid=CC2UQM49Y
As you seen you cannot use SSHFS (remote mount) since it does not support the extents feature.
I would be weary about copying / moving files around via sshfs unless it translates the commands into regular cp/mv commands on the host system, since it does not support extents that also means it does not support sparse files.
So the copy/move might end up with the full files, where the holes are filled in with 0x00 bytes.
Which would prevent us from reading from the underlying snapshots since we no longer have access to the holes to determine passthrough.

Should be noted that this was only one of the issues. Even without sshfs used there were issues mounting and I ended up with data loss.


Move images to modules

This enables us to later split up the repo and teach separate modules

Force pushing a rebase of this on cleanup-env, to get a CI run

It looks good to me. There are definitely tradeoffs in doing conda update all, but as long as we have some kind of PR activity the CI tests should catch anything breaking in our notebooks

Onward!


Binaries not updating

On startup I get this:
2015-08-16 01:36:20,062 [root] INFO: The binary analyzer/windows/bin/monitor-x86.dll is more than a week old!
2015-08-16 01:36:20,252 [root] INFO: The binary analyzer/windows/bin/monitor-x64.dll is more than a week old!
2015-08-16 01:36:20,273 [root] INFO: The binary analyzer/windows/bin/inject-x86.exe is more than a week old!
2015-08-16 01:36:20,296 [root] INFO: The binary analyzer/windows/bin/inject-x64.exe is more than a week old!
2015-08-16 01:36:20,311 [root] INFO: The binary analyzer/windows/bin/is32bit.exe is more than a week old!
2015-08-16 01:36:20,311 [root] CRITICAL: It is recommended that you update the binaries used for Windows analysis. To do so, please run the following command: ./utils/community.py -wafb monitor
2015-08-16 01:36:20,312 [root] INFO: Please take note of the warnings above!
2015-08-16 01:36:21,313 [root] INFO: Please take note of the warnings above!
2015-08-16 01:36:22,315 [root] INFO: Please take note of the warnings above!

I run the command
./utils/community.py -wafb monitor

Which gives me this:
Downloading modules from https://github.com/cuckoobox/community/archive/monitor.zip

Installing PROCESSING
  No candidates available, continuing.

Installing SIGNATURES
  No candidates available, continuing.

Installing REPORTING
  No candidates available, continuing.

Installing MACHINEMANAGERS
  No candidates available, continuing.

Installing WINDOWS
File "monitor-x86.dll" installed
File "is32bit.exe" installed
File "inject-x86.exe" installed
File "monitor-x64.dll" installed
File "inject-x64.exe" installed

However, after restarting Cuckoo, it still gives me the same warnings.

Yeah, we have to add an extra comment that if you've done so already you don't have to do it again. Sorry for the inconvenience.

Thanks! I'm glad I didn't mess up the installation somehow.

I've updated the comment to reflect this confusion. I hope it suffices. If not, please re-open this issue ;)


Import & whitespace fixes for PureScript 0.13

Like https://github.com/thomashoneyman/purescript-halogen-formless/pull/50 but to the halogen-5 branch.

Thanks for the update! I'm going to have to explore why CI is not running on some of these opened PRs, but I'll go ahead and merge into the Halogen 5 branch.


Cannot fill publications and authors that come from authors page

The lists publications and coauthors returns objects that the scholarly.fill cannot fill.
# Retrieve the author's data, fill-in, and print
search_query = scholarly.search_author('Steven A Cholewiak')
author = scholarly.fill(next(search_query))
scholarly.pprint(author)

# Take a closer look at the first publication
pub = scholarly.fill(author['publications'][0])
print(pub)

Returns
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-3-3b21cfe36369> in <module>()
      1 # Take a closer look at the first publication
----> 2 pub = scholarly.fill(author['publications'][0])
      3 print(pub)

/usr/local/lib/python3.6/dist-packages/scholarly/_scholarly.py in fill(self, object, sections)
    169         """
    170
--> 171         if object['container_type'] == "Author":
    172             author_parser = AuthorParser(self.__nav)
    173             object = author_parser.fill(object, sections)

KeyError: 'container_type'

Even if we add the attribute container type
# Take a closer look at the first publication
author['publications'][0]['container_type'] = 'Publication'
pub = scholarly.fill(author['publications'][0])
print(pub)

the publication is still not filled in.
Same thing happens with the list of coauthors.

Fixed in v.1.0.1


doc(readme): add code quality badge and TOC

@rultor merge.

@rultor merge.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge.

@rafamizes Done! FYI, the full log is here (took me 2min)

merged by rultor


LUA error when opening craft window (first time per session/reload)

I am getting the following error the first time I open the craft window after logging in/reloading UI.
Interface/AddOns/CraftSim/Data/DataExport.lua:584: bad argument #1 to 'pairs' (table expected, got nil)
This is occurring on multiple characters.  The error appears to be coming from GetProfessionGearStatsByLink

I will look at this when I got time, maybe I can fix it for the next release :)

Up til now I could not reproduce it (1.7.7)
I will close this issue until it occurs again

The error itself stopped popping up with one of the recent updates, although one of the symptoms is still happening:  On first opening a craft window, the CraftSim windows do not display properly.
This is how the window looks when I first open the craft:

After closing and re-opening or changing tabs, the windows display properly:

Since the error message no longer appears and doesn't need to be closed, the issue is less disruptive.


Soundcloud embed doesn't work with links to artist

Issue Summary
https://soundcloud.com/hear-the-bern us a valid url that returns an embeddable player with a list of tracks in the soundcloud oembed API. However, this is not a valid embed URL in wagtail, because it expects an extra layer of depth in the URL (hear-the-bern/something-else) - https://github.com/wagtail/wagtail/blob/master/wagtail/embeds/oembed_providers.py#L221-L226. It can currently be hacked by adding a question mark to the URL being sent in (hear-the-bern/?), but this is not very user friendly.
Steps to Reproduce

In the richtext editor, try to embed https://soundcloud.com/hear-the-bern. You get an error about embeddable URL not being found.
See that curl "https://soundcloud.com/oembed"  -d 'format=json' -d 'url=https://soundcloud.com/hear-the-bern/?' returns a valid embed information.

Fixed in #5564


GA versions of worker extensions for latest trigger and binding extension versions

There is a batch of worker extensions that are still in preview and reference preview versions of the corresponding host extensions, but those host extensions are GA. These should be updated to GA versions, referencing the GA host extensions.
It may be appropriate to split these out into separate work items, but for brevity and getting it captured:

Service
Worker Extension
Code link
Host Extension Specified
Latest Host Extension
Status

Blobs
5.0.0
AssemblyInfo.cs
5.0.0
latest - 5.0.0 at issue edit time
✅ Aligned

Queues
5.0.0
AssemblyInfo.cs
5.0.0
latest - 5.0.0 at issue edit time
✅ Aligned

Event Hubs
5.0.0-beta6
AssemblyInfo.cs
5.0.0-beta6
latest - 5.1.0 at issue edit time
Needs GA worker extension and specified host extension version bump

Service Bus
5.0.0-beta6
AssemblyInfo.cs
5.0.0-beta6
latest - 5.3.0 at issue edit time
Needs GA worker extension and specified host extension version bump

Event Grid
3.0.0-beta3
AssemblyInfo.cs
3.0.1
latest - 3.2.0 at issue edit time
Needs GA worker extension and specified host extension version bump

The Storage meta-package is in fact GA: https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Extensions.Storage/ - this just references Blobs and Queues, though.
For Azure Tables, see https://github.com/Azure/azure-functions-dotnet-worker/issues/404
Cosmos DB also has a new major version of its host extension that remains in preview. It could probably stand an update as well to pull in the latest preview.
We should discuss options for bringing these into better alignment and preventing drift going forward. CC @JoshLove-msft

Cosmos DB also has a new major version of its host extension that remains in preview. It could probably stand an update as well to pull in the latest preview.

Any news on when Microsoft.Azure.Functions.Worker.Extensions.CosmosDB will move out of preview?


Istioctl not working on MacOS Ventura 13.2.1 (22D68) - Golang issue

Bug Description
Istioctl is not working on MacOS Ventura 13.2.1 probably due to leveraging Go functionalities not supported by Ventura. Pls share rebuilt binaries for newest MacOS.
Error log:
istioctl install
fatal error: runtime: bsdthread_register error

runtime stack:
runtime.throw(0x26abe3f, 0x21)
        /usr/local/go/src/runtime/panic.go:616 +0x81 fp=0x7ff7bfeff248 sp=0x7ff7bfeff228 pc=0x10297c1
runtime.goenvs()
        /usr/local/go/src/runtime/os_darwin.go:129 +0x83 fp=0x7ff7bfeff278 sp=0x7ff7bfeff248 pc=0x1027343
runtime.schedinit()
        /usr/local/go/src/runtime/proc.go:501 +0xd6 fp=0x7ff7bfeff2e0 sp=0x7ff7bfeff278 pc=0x102c0b6
runtime.rt0_go(0x7ff7bfeff318, 0x2, 0x7ff7bfeff318, 0x0, 0x1000000, 0x2, 0x7ff7bfeff5a8, 0x7ff7bfeff5b1, 0x0, 0x7ff7bfeff5b9, ...)
        /usr/local/go/src/runtime/asm_amd64.s:252 +0x1f4 fp=0x7ff7bfeff2e8 sp=0x7ff7bfeff2e0 pc=0x1052824

Background:
https://github.com/golang/go/wiki/MacOS12BSDThreadRegisterIssue
https://github.com/golang/go/issues/49425
Version
cat istio.VERSION
# DO NOT EDIT THIS FILE MANUALLY instead use
# install/updateVersion.sh (see install/README.md)
export GALLEY_HUB="docker.io/istio"
export GALLEY_TAG="1.1.9"
export CITADEL_HUB="docker.io/istio"
export CITADEL_TAG="1.1.9"
export MIXER_HUB="docker.io/istio"
export MIXER_TAG="1.1.9"
export PILOT_HUB="docker.io/istio"
export PILOT_TAG="1.1.9"
export PROXY_HUB="docker.io/istio"
export PROXY_TAG="1.1.9"
export ISTIO_NAMESPACE="istio-system"
export PILOT_DEBIAN_URL="https://storage.googleapis.com/istio-release/releases/1.1.9/deb"
export FORTIO_HUB="docker.io/fortio"
export FORTIO_TAG="latest_release"

Additional Information
istioctl bug-report
fatal error: runtime: bsdthread_register error

runtime stack:
runtime.throw(0x26abe3f, 0x21)
        /usr/local/go/src/runtime/panic.go:616 +0x81 fp=0x7ff7bfeff248 sp=0x7ff7bfeff228 pc=0x10297c1
runtime.goenvs()
        /usr/local/go/src/runtime/os_darwin.go:129 +0x83 fp=0x7ff7bfeff278 sp=0x7ff7bfeff248 pc=0x1027343
runtime.schedinit()
        /usr/local/go/src/runtime/proc.go:501 +0xd6 fp=0x7ff7bfeff2e0 sp=0x7ff7bfeff278 pc=0x102c0b6
runtime.rt0_go(0x7ff7bfeff318, 0x2, 0x7ff7bfeff318, 0x0, 0x1000000, 0x2, 0x7ff7bfeff5a8, 0x7ff7bfeff5b1, 0x0, 0x7ff7bfeff5bc, ...)
        /usr/local/go/src/runtime/asm_amd64.s:252 +0x1f4 fp=0x7ff7bfeff2e8 sp=0x7ff7bfeff2e0 pc=0x1052824

Istio 1.1 is literally 4 years old. Please upgrade....


add github-actions documentation

There was an issue about documentations in GitHub Actions and had to look for the GitHub repo, added GitHub Actions documentation in ci-cd part to make sure it can easily be learned and utilised for CI/CD without further research for users

@sigmavirus24, I did the recommended changes, can you check it again? I'm learning how I can write in .rst format for Python and your help proved to be invaluable for learning to write in .rst format

@sigmavirus24 I did the changes, can you check again

I left specific comments but please look at the other rst files to understand the proper way to write RST and follow the same general style

@sigmavirus24 can you check the changes again, I looked at your suggestions and other .rst files to format the changes and also formatted the list table to further be compliant with the .rst rules.


Add precipitation_probability to hourly forecast

Proposed Changes
I am working on adding hourly forecasting to the open_meteo component of Home Assistant. I want to use this forecast to make precipitation graphs on my dashboard, but this library does not implement the probability yet.
For this reason I added the precipitation_probability property.

(Describe the changes and rationale behind them)

Related Issues
No related issues yet, might add them later when I open PRs to Home Assistant Core

(Github link to related issues or pull requests)

Not stale, awaiting review


Add public file share port to click once application identity

This PR references the issue #213 .

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ChrisBlankDe sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Provide a simple Lightbox for images

Provide a simple Lightbox for images

Done on development 1.0 branch Commit


themes not loading anymore in client

Hello. I wanted to ask, days 3-5 ago stopped loading topics in the client itself. although other elements such as the list of friends, messages, etc. are loaded quietly, as shown in this screenshot. this applies to any topic loaded through SFP.
what could be the problem and how to fix it?
thank you.

I have the same problem. The only working UI element on my side is the loading popup when you start / stop Steam.

so skins need to be updated

tnx! thats worked!


Use closures for widget styling

This PR replaces the function pointers used for styling since #2312 with boxed closures. These closures can both capture and borrow application state.
We trade a bit of overhead for a lot of flexibility. No need to juggle themers everywhere!

Incredible, this is something very important, the styling of the components was something very complicated.


Hessian-vector product from stan-dev/math

Expose the version of the Hessian-vector product functional from stan-dev/math.
Here's the functional we need to expose.  We want the first one that uses reverse-mode nested in forward mode):
https://github.com/stan-dev/math/blob/develop/stan/math/mix/functor/hessian_times_vector.hpp
We should use the first version in the file (reverse nested in forward), because it's linear.  Doing it with finite diffs and multiply will be quadratic (as will be using the second version in the source file).
The motivation is the optimizer (conjugate gradient trust region method) used by the following paper, which uses trust-ncg in scipi.optimize.minimize:
https://arxiv.org/pdf/2304.05527.pdf
@rgiordan said that they used PyMC because it provided Hessian-vector products.

I think this is a duplicate of (part of) #84


Error when building on Mac with GPU

I am new to this so feel free to delete this if this is trivial.
I encountered the following errors when building from source on Mac with GPU support
tensorflow/core/kernels/cudnn_pooling_gpu.cc:71:32: error: implicit instantiation of undefined template 'std::__1::array<long long, 3>'   for (size_t i = 0; i < window.size(); ++i) {                                ^ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__tuple:95:65: note: template is declared here template <class _Tp, size_t _Size> struct _LIBCPP_TYPE_VIS_ONLY array;                                                                 ^ tensorflow/core/kernels/cudnn_pooling_gpu.cc:73:42: error: implicit instantiation of undefined template 'std::__1::array<long long, 3>'     pooling_desc.set_window(dim_i, window.rbegin()[i]);                                          ^ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__tuple:95:65: note: template is declared here template <class _Tp, size_t _Size> struct _LIBCPP_TYPE_VIS_ONLY array;
and seven other similar errors.
Including <array> in tensorflow/tensorflow/core/kernels/cudnn_pooling_gpu.cc seems to fix the problem

In that case, tensorflow/core/kernels/cudnn_pooling_gpu.h should have included
Please feel free to send a PR.


API endpoint for creating, retrieving, updating, and deleting meetings

Add endpoints to the API for creating, retrieving, updating, and deleting meetings.

If successful, the operation should returns status 201 with a Location header that references the created meeting.  The URL for the created meeting should conform to the /meeting/{meetingId} template.
Retrieving a meeting
GET /meeting/{meetingId}

If successful the operation returns a JSON object representing the meeting information and status 200.
PUT /meeting/{meetingId}

PUT a JSON object to the /meeting/{meetingId} which is used to replace the existing meeting information
If successful the operation returns status 200.
DELETE /meeting/{meetingId}

If successful the operation returns status 200.

I think for the first iteration and very initial meetings we can include just name, startDateTime, and endDateTime in the payload to create a meeting.  The system will generate a meetingId and createdAt datetime when it persists the meeting.
Other properties such as invitees and room can be added later.
request payload:
{
  "name": "example meeting",
  "startDateTime": "2018-02-24T12:00:00Z",
  "endDateTime": "2018-02-24T13:00:00Z"
}

possible generated + persisted meeting obj
{
  "meetingId": "0ECDC49E-B554-4345-825D-263FC8E91B80",
  "name": "example meeting",
  "startDateTime": "2018-02-24T12:00:00Z",
  "endDateTime": "2018-02-24T13:00:00Z",
  "createdAt" : "2018-02-23T14:23:46Z"
}


Convert IG script: VRPTypeVerifier to RS validation logic

Review logic in VRPTypeVerifier and move it into the RS VRP Consent Validator: OBDomesticVRPConsentRequestValidator
Then remove VRPTypeVerifier script file and references to it from IG routes.

All OB biz logic should be moved into the RS, this was missed off when migrating VRP Consents from IDM to RCS Consent Store.


"prevBtnTitle" and "nextBtnTitle" configs have no effect when using MdMenu module

Documentation states that "prevBtnTitle" and "nextBtnTitle" configs can be used to customize button texts but in reality they have absolutely no effect when "MdMenu" module is used. I would expect the configs to be used for button tooltips (preferred behavior) or the documentation should state that those configs can not be used in "MdMenu" module.

Another option would be to actually have text next t icon if people put any custom text.
Recently we made some user testing and found out that on mobile a lot of people were accidentally pressing "End" instead of the "next" arrow button because it's so small.

@isaacplmann Yeah, the custom template would be a good solution for me, but I still think it's strange to have configs which don't actually do anything. Any reason you don't want to have tooltips in the default template?

How about you paste your custom template code in this issue, that way if people find this issue and like the style you chose, they can just copy what you used.

Sure.
Template:
<mat-card (click)="$event.stopPropagation()">
  <mat-card-title>
    {{step?.title}}
    close
  </mat-card-title>
  <mat-card-content>
    {{step?.content}}
  </mat-card-content>
  <mat-card-actions align="end">
    <button
        mat-button
        class="prev-button"
        [disabled]="!tourService.hasPrev(step)"
        (click)="tourService.prev()"
    >
      chevron_left {{step?.prevBtnTitle}}
    </button>

    <button
        mat-button
        class="next-button"
        [hidden]="!tourService.hasNext(step)"
        (click)="tourService.next()"
    >
      {{step?.nextBtnTitle}} chevron_right
    </button>
    <button
        mat-button
        (click)="tourService.end()"
        [hidden]="tourService.hasNext(step)"
    >
      {{step?.endBtnTitle}}
    </button>
  </mat-card-actions>
</mat-card>

CSS:
.divider {
    flex: 1;
}

.title-close {
    cursor: pointer;
    position: absolute;
    right: 20px;
    top: 24px;
}

button.prev-button {
    padding-left: 6px;
}

button.next-button {
    padding-right: 6px;
}

mat-card-title {
    margin-right: 16px;
}

mat-card-title .title-text {
    line-height: 24px;
    font-size: 22px;
}

button[hidden] {
    display: none;
}

Sure.
Template:
<mat-card (click)="$event.stopPropagation()">
  <mat-card-title>
    {{step?.title}}
    close
  </mat-card-title>
  <mat-card-content>
    {{step?.content}}
  </mat-card-content>
  <mat-card-actions align="end">
    <button
        mat-button
        class="prev-button"
        [disabled]="!tourService.hasPrev(step)"
        (click)="tourService.prev()"
    >
      chevron_left {{step?.prevBtnTitle}}
    </button>

    <button
        mat-button
        class="next-button"
        [hidden]="!tourService.hasNext(step)"
        (click)="tourService.next()"
    >
      {{step?.nextBtnTitle}} chevron_right
    </button>
    <button
        mat-button
        (click)="tourService.end()"
        [hidden]="tourService.hasNext(step)"
    >
      {{step?.endBtnTitle}}
    </button>
  </mat-card-actions>
</mat-card>

CSS:
.divider {
    flex: 1;
}

.title-close {
    cursor: pointer;
    position: absolute;
    right: 20px;
    top: 24px;
}

button.prev-button {
    padding-left: 6px;
}

button.next-button {
    padding-right: 6px;
}

mat-card-title {
    margin-right: 16px;
}

mat-card-title .title-text {
    line-height: 24px;
    font-size: 22px;
}

button[hidden] {
    display: none;
}

Can you explain to me how you were able to add Next instead of next arrows in the tour, please
thank you

Just add <tour-step-template> to your app.component.html:
<tour-step-template>
    <ng-template let-step="step">
        <my-tour-step-template
            [step]="step"
        ></my-tour-step-template>
    </ng-template>
</tour-step-template>

See "Custom template" documentation section for more info.

I can't find the custom template documentation can you send me a link
Please can you show me a way to make nectBtnTitle work for each tour steps and display it?
Thank you for your response

@isaacplmann Can You tell me whats the code to end the tour service each time so that when another tour begins and if it contains same Id in it ti doesn't get crashed
@hakimio

@hiren3897 Link to documentation is in the README:
https://isaacplmann.github.io/ngx-tour/
If you scroll down all the way to the bottom, you'll find a section called "Custom template".
Tour service has "end()" method you can call to end the tour.
You can't have repeating IDs on the same page.

Thanks for your help but when I am implementing a custom template
it gives me hasPrev error in the console @hakimio

@hiren3897 Link to documentation is in the README:
https://isaacplmann.github.io/ngx-tour/
If you scroll down all the way to the bottom, you'll find a section called "Custom template".
Tour service has "end()" method you can call to end the tour.
You can't have repeating IDs on the same page.

Thank you for your help it worked for mee!!!!!!!!!!!!!!!!!!!!!!


Collect metrics via artifact operation

Summary
Create an IArtifactOperation implementation for collecting metrics. This change reduces the complexity for collecting metrics via the /livemetrics route and the CollectLiveMetrics action.

Release Notes Entry

/backport to release/7.x


Concurrent access issue to jython evaluables.

Description: any jython function used in the project has implicit name _temp_ which creates issues when there are multiple projects which transforms are applied concurrently.
Fix replaces default name to include hashcode of function code itself and making this safer in concurrent environments.
Created corresponding test which was failing before and now passes.
We are using openrefine on production to apply transformations to datasets and found that during concurrent access sometimes we are getting corrupted data.
Patch will also help to all forks which are trying to make batch processing transformations engine based on openrefine (what we actually did for internal usage)

Thanks for the contribution -- and for including a test!
In the future, please review the diff before you submit it and make sure it's clean of changes unrelated to its purpose (e.g. the import reorg that your IDE apparently decided was necessary).  Otherwise we just get noise injected from dueling editor/IDE setups.

(y)


Portable components

I'm building an app where users can install "applets" that are pieces of UI built by third-parties, we are thinking of distributing them as WASM blobs as we can bundle not only data but logic in a compact format.
It would be great to find a way to create components as crates that can be compiled to a minimal WASM and be loaded dynamically by the main application that understands the WASM interface exposed by the component and can communicate with it in an efficient way.
I haven't digged much into the internals of dioxus so it would be nice to hear thoughts and comments about its feasibility :)

This would be amazing. Not only for lazy loading components, but also hot swapping components that changed, and faster incremental builds. This could also open the door to bindings in other languages like go and assembly script.
I've been looking into this in the past few days. Here's what I found:

wit-bindgen looks amazing for the future, but is currently not supported in browsers.
We could use wasm-bindgen to expose the framework rust code as js and then call the js code in the component code.
We could instead use the link attribute on a extern block with the wasm_import_module to directly link the WASM modules. (I'm less sure about this approach. There is very little documentation about the attribute, so I could be wrong here)

There are some downsides to dynamically linking mainly no optimization across the framework<->component boundary which would result in less optimized and larger binaries.

The wit-bindgen option is probably the best way :) A almost a year later and WebAssembly components are still a work in progress but it might be in a state where it's ok to try things out. The jco tool for example is a way to bridge the current compatibility gap and run the Rust code as JS but more future proof because if support ever lands natively in the browser the WASM component doesn't have to change. When running Dioxus natively we could also look into using a wasmtime or wasmer to run the components at near native speeds.

The wit-bindgen option is probably the best way :) A almost a year later and WebAssembly components are still a work in progress but it might be in a state where it's ok to try things out. The jco tool for example is a way to bridge the current compatibility gap and run the Rust component as JS but more future proof because if support (ever) lands natively in the browser the WASM component doesn't have to change. When running Dioxus natively we could also look into using a wasmtime or wasmer to run the components at near native speeds.

I have been planning to integrate this into Floneum to let components define their own UI. It uses wit bindgen. I'll try to remember to post here when I get that working, but I imagine it will work much like the liveview renderer today


For ASP.NET Web Pages

I am posting here because this info is missing from the documentation.
To get ASP.NET webpages to run, in addition to what Cassette automatically does to the Views folder, you will need to add the following section to the web.config (in the views folder)
  <configSections>
    <sectionGroup name="system.web.webPages.razor" type="System.Web.WebPages.Razor.Configuration.RazorWebSectionGroup,
System.Web.WebPages.Razor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31BF3856AD364E35">
      <section name="pages" type="System.Web.WebPages.Razor.Configuration.RazorPagesSection, System.Web.WebPages.Razor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31BF3856AD364E35" requirePermission="false" />
    </sectionGroup>
  </configSections>

Also, in the pages element under the system.web.webPages.razor section you will need to add the following property
pageBaseType="System.Web.Mvc.WebViewPage"
Everything should look like this...
<configuration>
  <configSections>
    <sectionGroup name="system.web.webPages.razor" type="System.Web.WebPages.Razor.Configuration.RazorWebSectionGroup,    System.Web.WebPages.Razor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31BF3856AD364E35">
      <section name="pages" type="System.Web.WebPages.Razor.Configuration.RazorPagesSection, System.Web.WebPages.Razor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31BF3856AD364E35" requirePermission="false" />
    </sectionGroup>
  </configSections>

  <system.web.webPages.razor>
    <pages pageBaseType="System.Web.Mvc.WebViewPage">
      <namespaces>
        <add namespace="Cassette.Views"/>
      </namespaces>
    </pages>
  </system.web.webPages.razor>
</configuration>

Finally a using statement should be added to the top of _SiteLayout.cshtml like so
@using Cassette.Views;

If you have the <add namespace="Cassette.Views"/> do you still need @using Cassette.Views; in your view?

Also, when creating a new webpages projects doesn't the default Web.config contain most of this already?


std.experimental.logger: structs and classes with @system toString methodes did not

used to work. This PR fixes that

@klickverbot the log functions call formattedWrite which calls toString of user defined types. that toString might not be safe or trusted

@schveiguy @klickverbot updated

I think @klickverbot's point was that a @trusted toString can be called just fine from @safe code.
But the current commit looks fine, and doesn't really worry about that. LGTM.

yes it makes system and trusted work.

I see your point

thanks


New coding standard

Usage of the newly introduced zendframework/zend-coding-standard for CS checks.

@Koopzington shouldn't this go against develop?

@Ocramius - no need; it's not a substantive change. We've done these
against matter in other components.
On Jan 29, 2017 10:02 AM, "Marco Pivetta"<EMAIL_ADDRESS>wrote:

@Koopzington https://github.com/Koopzington shouldn't this go against
develop?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-mail/pull/121#issuecomment-275923498,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlV8K7aSpygGH-RPIjVf-0WI41DnQmks5rXLgZgaJpZM4KwyRA
.

Alright, didn't know that :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On Sun, Jan 29, 2017 at 5:24 PM, weierophinney<EMAIL_ADDRESS>wrote:

@Ocramius - no need; it's not a substantive change. We've done these
against matter in other components.
On Jan 29, 2017 10:02 AM, "Marco Pivetta"<EMAIL_ADDRESS>wrote:

@Koopzington https://github.com/Koopzington shouldn't this go against
develop?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/zendframework/zend-mail/pull/
121#issuecomment-275923498>,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AABlV8K7aSpygGH-RPIjVf-0WI41DnQmks5rXLgZgaJpZM4KwyRA>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-mail/pull/121#issuecomment-275925077,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakO0F0QR31QPbjN7UNbnBItNGMlymks5rXL02gaJpZM4KwyRA
.


Bundle DroidKaigi FM in app

Issue

close #118

Overview (Required)

add simple audio play button
generate an mp3 URL
implemented DroidKaigi FM player

Screenshot

👀

It seems that CI is failing because the format is broken. 🙇
Can you run spotlessKotlinApply task from here? 🙏

Thank you for format. 🙇 Can you check this? 🙏
e: /home/runner/work/conference-app-2021/conference-app-2021/uicomponent-compose/feed/src/androidTest/java/io/github/droidkaigi/feeder/feed/FeedItemTest.kt: (109, 17): No value passed for parameter 'onClickPlayPodcastButton'

OK! I will confirm.

👀

👀


Add mini chatbot to the website

Hey @Anuj3553 I have a great Idea.

Adding a mini AI based chatbot to website.

I am already working on this, please assign me this under gssoc-ext so I can raise a PR.
Little about me: I am an experienced contributor as I have successfully completed GSSoC-2024, Hacktoberfest-2020 and Hacktoberfest-2023.

Hyy @say-het, I'm assigning this issue to you.


[BUG] Missing version constrains on dependencies

 Sorry

Filled on wrong repo

Feel free to file any issue 😄

Sure, but this was totally not related to your repo 😓
I had two tabs open and in my haste I filled the issue on the wrong tab.
Friday-end-of-the-day-things


Typography: Include semantic elements in code examples

What component is this related to?
Typography
Why do we need it?
The typography guidance page says:

Add a variant to the typography element to change its style. This doesn't change the semantic level of the typography element so make sure to always adhere to accessible heading levels. For example, body text with a variant of h2 will appear visually as an h2 but still be body text in the DOM.

To support this best practice, we should update the Code examples to include semantic tags, like below:
<ic-typography variant="h1">
H1
</ic-typography>
<ic-typography variant="h2">
H2
</ic-typography>
<ic-typography variant="h3">
H3
</ic-typography>
<ic-typography variant="h4">
H4
</ic-typography>
...

This is important, otherwise developers might end up using Typography to make headings that only visibly appear as headings.

Completed as part of #751


Add an option "--count-only-error-for-failure"

Description:
--count-only-error-for-failure
Count only error items, not warning and info, for failure
We have a requirement for a word not to cause a failure when the word has a rule whose severity is warning or info.
Note
As long as the requirement is satisfied, we do not mind how it'd be implemented. So, if my proposal does not fit in the current design, please feel free to close this PR in favor of a better one. Thanks in advance!
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features) see docs/README.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds an option --count-only-error-for-failure. When this option is given along with --exit-1-on-failure, even if a word whose rule specifies the warning level of severity (or info) is found, it does not exit as a failure.
What is the current behavior? (You can also link to an open issue here)
Regardless of the severity level, any finding makes woke exit with 1  if --exit-1-on-failure is specified.
If you are interested in, this is the PR in which I ran into the issue.
https://github.com/linux-system-roles/logging/pull/307#issuecomment-1343073890
What is the new behavior (if this is a feature change)?
If --count-only-error-for-failure is specified along with --exit-1-on-failure, findings whose rule has the warning or info level of the severity will not cause woke exit with 1.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
Unless --count-only-error-for-failure is specified, there are no behavioral changes.

Dear woke developers / maintainers,
Our project https://github.com/linux-system-roles/ is hoping to use this feature in the actions. Could you please take a look and share your thoughts? Thank you!

Hi there! Apologies for the delay, my notifications for this repo didn't seem to be working. I will take a look and respond in the next few days. I appreciate your patience!

Hi there! Apologies for the delay, my notifications for this repo didn't seem to be working. I will take a look and respond in the next few days. I appreciate your patience!

Thanks for your response, @caitlinelfring!

Hello @caitlinelfring, is there any update on this PR?

Hello @caitlinelfring, is there any update on this PR?


getting started guide typo on angular.io

"live-server --open src" in the typescript getting started section (Run it!) should be "live-server --open=src"

Created pull request to fix the issue: https://github.com/angular/angular.io/pull/227

Closed by PR


Add metadata to explorer tiles

It would be nice to have some metadata pop-up for the explorer tiles. In particular the date when it was explored and also which activity explored this tile.

Now each tile has a little pop-up.


Support for verifying OCI referenced images

Summary

The following PR introduces support for verifying OCI referenced images using sigstore-go.
Details:

Added a --ociImage flag to sigstore-go CLI
There's no need to pass a bundle alongside the image reference.
It builds the bundle by fetching the related image manifests and extracts and normalises the necessary data to construct it.
Added a document providing an example use of this

I realise I might have missed some corner case so I'll appreciate your feedback on how to make this better 😃
Thanks in advance!
Release Note

Added support to the sigstore-go CLI for verifying OCI images via the --ociImage flag.
Documentation

Awesome!

To clarify, the purpose of sigstore-go is not to have functionality like this, it should be in cosign. But until cosign is ready to work with bundles, having an example in this repo is fine IMHO.

Thanks @rdimitrov for writing this up! It's interesting that the existing cosign signatures can be packaged into a compliant bundle, as that wasn't really the intent of this library. I think many of us see the future of using Sigstore Bundles in cosign would look something like uploading the bundle to an OCI registry as a referring artifact, and verifying the stored bundle directly. Of course this depends on the ability to sign/create bundles, which is as of yet unsupported in sigstore-go and cosign.
I'm a bit hesitant to merge this for a few reasons:

As mentioned above, we would like to push bundles directly into OCI registries, which is not compatible with this implementation.
As mentioned by other reviewers, we would like discourage any more creation of v01 bundles.
I don't want to add more dependencies to support OCI/docker here, as that is more the role of cosign.
IMO, the CLI here in sigstore-go is not really something I want to support long-term, and it's intentionally small to demonstrate sigstore-go's core functionality, to use as prior art for people who are trying to use sigstore-go. I have considered moving the CLI into an examples/ directory to emphasize this.
No test coverage.

I'd be open to moving this code into an examples dir with its own go.mod, but otherwise I'd prefer to reject this PR on these bases.

Just a general comment here:

I'd personally prefer to not have more v01 bundles

I don't believe the intent with this example code is to actually store the bundles anywhere? I was always under the impression that this example code is a way for a client to verify a bundle with sigstore-go instead cosign, by creating an in-memory representation, verify it, then throw it away. In that sense, verifying a v1 bundle is as safe as verifying it with cosign.

I'd be open to moving this code into an examples dir with its own go.mod, but otherwise I'd prefer to reject this PR on these bases.

yes, this is a great option, as this is just an example client using sigstore-go 👍

@rdimitrov Thanks for the clarification. My concerns are largely mitigated if this is just an intermediate format and not persisted.
To Cody’s last point, do we want to add some tests even if this is an example?

@codysoyland - I was debating whether I should put it there in the first place. I can rework this PR so it aligns with this 👍

Thanks @rdimitrov for understanding and moving this to an example! I just ran through the doc and everything works on my local machine. 👍🏻

Thanks @codysoyland and @haydentherapper! 🙏
Updated the PR title and description to match, let me know if there's anything else blocking this 👍


Add Leaflet-search and Yii2-locator

@sjaakp please change the PR and resolve the conflicts

We added the plugin in the refactoring where we moved the plugins into seperate files #7805


Exception in Appium console with win app driver 1.1.1

Hi,
When I am trying to run win app driver 1.1.1 i get the below exception in appium console.

Can anyone help?

Hi @anunay1
Which version of Appium are you using?

I am using 1.6.3

updated appium to version 1.13.0, still getting the same error

@hassanuz : Any updates on this, is the issue with WAD or appium.


Instructions to build?

As someone new to GO, there doesn't seem to be a build file or instructions on how to build the project? Could you add a section on build instructions? Thank you!

I'll do a PR on the man page, but here's what I found to work for me (on Linux/Mac):

Install Go (https://golang.org/doc/install)
Create a directory $HOME/go/src/github.com/stilldavid/
export GOPATH=$HOME/go
go get github.com/stilldavid/gopro-utils/bin/gopro2json
go install github.com/stilldavid/gopro-utils/bin/gopro2json

I'm having an issue when I do this (working on windows)
When I do step 5, it says:

can't` query specific version for package github.com/stilldavid/gopro-utils/bin/gopro2json in the main module

If I try to ignore that and go to step 6, i get :
    go: inconsistent vendoring in C:\Go\src:
            go.mod requires github.com/paulmach/go.geo v0.0.0-20180829195134-22b514266d33 but vendor/modules.txt does not include it.
    run 'go mod tidy; go mod vendor' to sync

Any idea why I can't build/install this? I know nothing about using Go or these functions, thank you!
Also, running 'go mod tidy; go mod vendor' (either of them) will return
      go: github.com/paulmach/go.geo/go.geo-master: looping trying to add package

Nothing changes if return to step 5 or 6 at this point. I'm brand new to this, I'm not sure how to fix this

These install instructions are not working for me.  After step 6 I can not just run gopro2json from the command line.  I am on a Mac.
Does anyone have updated build and run instructions?

kk:Go kris$ find . -ls
9413857        0 drwxr-xr-x    4 kris             staff                 128 Sep 22 15:14 .
67901209        0 drwxr-xr-x    2 kris             staff                  64 Sep 22 15:16 ./bin
9427751        0 drwxr-xr-x    2 kris             staff                  64 Sep 22 15:16 ./pkg
kk:Go kris$ echo $GOPATH
/Users/kris/Go
kk:Go kris$ go install github.com/stilldavid/gopro-utils/bin/gopro2json@latest
go: downloading github.com/stilldavid/gopro-utils v0.0.0-20190102034544-f0186d2edd34
go: finding module for package github.com/paulmach/go.geo
go: downloading github.com/paulmach/go.geo v0.0.0-20180829195134-22b514266d33
go: found github.com/paulmach/go.geo in github.com/paulmach/go.geo v0.0.0-20180829195134-22b514266d33
go: finding module for package github.com/paulmach/go.geojson
go: downloading github.com/paulmach/go.geojson v1.5.0
go: found github.com/paulmach/go.geojson in github.com/paulmach/go.geojson v1.5.0
kk:Go kris$ file bin/gopro2json
bin/gopro2json: Mach-O 64-bit executable arm64
kk:Go kris$ bin/gopro2json
Usage of bin/gopro2json:
  -i string
    	Required: telemetry file to read
  -o string
    	Required: json file to write

That is,

mkdir $HOME/Go
export GOPATH=$HOME/Go
mkdir $GOPATH/{bin,pkg}
go install github.com/stilldavid/gopro-utils/bin/gopro2json@latest

and you are done. Go made multiple incompatible changes on how it uses $GOPATH, but that made it actually easier.

> go install github.com/stilldavid/gopro-utils/bin/gopro2json@latest
package github.com/stilldavid/gopro-utils/bin/gopro2json@latest: cannot use path@version syntax in GOPATH mode


docs: Update provisioner configuration

Match existing securityGroupSelector and avoid confusion.

Fixes #
Description
How was this change tested?

Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbevc1 Can you explain the confusion that you feel like is being caused by the karpenter.sh/discovery tag being used for security group discovery?

I was using eksctl last week for some demons and it tripped me following the Getting started guides as default behaviour wouldn't set those tags on nodes SGs. I took me some time to backtrack why my LoadBalances are not provisioning to Karpenter nodes. If we use the suggested tags this works out of the box for the examples provided in the docs.

you do realise this is a breaking change for everyone else who already has this deployed, correct?

Not sure if I'm missing some context here @FernandoMiguel or this being used anywhere else, but since this is part of getting started section, wouldn't this only affect the docs? :thinking:

@mbevc1 correct. but folks followed those instructions to setup their clusters

I'm probably being daft here, but I still fail to see why that would break anything. Could you please elaborate why this would breaks things for whoever followed those instructions? I'd assume getting started is used for initial setups and you wouldn't come back to this config afterwards?

@mbevc1 during upgrades folks come back to see if this has changed and now it drifts from their remaining infra

Since it's a non-working default setup I'd be inclined to add an upgrade warning to this change 🤔 How does that sound?

I'm not sure it's a non-working default. Does using the kubernetes.io/cluster tag result in more resources being selected than just the sg?
I like the explicit karpenter tag for selection (at least as a default). Maybe going another direction, could just add a note about tagging the SG if using the AWS Load Balancer Controller? I think the note would demystify the experience anyways. If we just change the tag, I still wouldn't really know what it's selecting and could easily change that tag to something else and then break my setup.

Seems using default config with eksctl results in SG without any usable tags for LB to select (only suggested one is present). Provisioned nodes also don't have the karpenter.sh/discovery tag present. Am I missing anything obvious here? :thinking:

We're going to close this for now, the current method seems to be working and we want to cause as little churn for current Karpenter users as we can.

I was distracted with some other bits. I might test some more in the following months and provide more feedback.


support wildcard terms

Instead of getting an error about unsafe rules, we should have an explicit check and a more helpful error message for wildcards used in rule heads.


[DDW-635] Shutting down Screen top Priority

This PR CHANGES shutting down screen priority and puts it on top of other screens when the shutdown sequence is started. Shut down screen should be presented while all other screens (if they were open previously) should be closed down. Only exception is Daedalus Diagnostics screen

Testing Checklist

Slack QA thread
[ ] Test if shut down screen is presented when the shutdown sequence is started (Loading screen)
[ ] Test if shut down screen is presented when shut down sequence is started (Loading screen), and About, Block Consolidation or Ada Redemption screens were previously open.

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.

@daniloprates Can you assist here? We need to clarify if these screen should be able to be opened or not at all during the Syncing process?

@DeeJayElly Diagnostic Screen is also closed after Starting shutting down process. "Only exception is Daedalus Diagnostics screen" rule is not working.

Fixed

@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.

Fixed

Reviewing this one now...

@DeeJayElly as per our call we need to refactor the logic and revert Block consolidation screen background transparency.

Reverted the thing with Block Consolidation background transparency, and fixed the logic with a quick fix. I think its ok we stick with this for now and maybe later we can refactor it when we have more time.
Hope you agree on this one @nikolaglumac

@DeeJayElly I will take over this task.


Implement endpoint: /core/version-check

Hi all,
The most recent version of this endpoint is located here: https://api.wordpress.org/core/version-check/1.7/ the versions listed in the endpoint go from 6.6.2 to 4.1.41
This is the template used for each version:
{
      "response": "upgrade",
      "download": "https://downloads.wordpress.org/release/wordpress-6.6.2.zip",
      "locale": "en_US",
      "packages": {
        "full": "https://downloads.wordpress.org/release/wordpress-6.6.2.zip",
        "no_content": "https://downloads.wordpress.org/release/wordpress-6.6.2-no-content.zip",
        "new_bundled": "https://downloads.wordpress.org/release/wordpress-6.6.2-new-bundled.zip",
        "partial": false,
        "rollback": false
      },
      "current": "6.6.2",
      "version": "6.6.2",
      "php_version": "7.2.24",
      "mysql_version": "5.5.5",
      "new_bundled": "6.4",
      "partial_version": false
    },

Questions @chuckadams @sarah-savage :

Will this information and zip files be part of the sync project?
Will we store all the old versions and new patches in the future?
Or is it better to just bypass this endpoint?

AspireSync might be able to grab the endpoints, but I think for now we can leave this one as pass-through.
Client implementation is in wp_version_check and appears to do a POST to /core/version/check/1.7.

Despite taking a POST, most input comes through the query string, including the versions of every single plugin installed.

An optional query parameter channel is supported and can be one of beta, rc, development, or branch-development.  The main channel is accessed by leaving out the parameter.

POST data is json and has at least 'translations' (itself a json object), but wp_version_check can take arbitrary extra data to post via $extra_stats, which presumably are just reporting and don't affect the response.  We'll want to capture some interactions with this endpoint to make sure.

I'm having a devil of a time finding the implementation for this in the .org repo.  Adding the help-wanted tag.


Sign up and login option added in homepage

What is the change?
the homepage was missing the login options, if a new user comes then there was no option for login except creating a new post and only then the user is redirected to login page
Related issue?
issue: #301
How was it tested?
frontend related issue, locally tested
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

This issue is solved.

/reviewed

/gssoc/

@Pranav016  sir, I have squashed them, but it is not visible here, I don't know why. In my git log, it is showing it in a single commit but here it is the same as before. Here is the ss.

@Pranav016 sir, I have squashed them, but it is not visible here, I don't know why. In my git log, it is showing it in a single commit but here it is the same as before. Here is the ss.

Commits were squashed successfully you just forget to remove redundant commit messages during squashing.

@Abhinaba006 PR looks good to merge, can you resolve merge conflicts

/level2/

Sir I am removing this branch and making a new branch to work on this issue, I was having some problem to understand git, I will send a new pr for this issue, I am closing this branch.


It doesn't work anymore !

F-ing Google\YouTube changed things in the backend again, so this needs fixing...

I'm unlinkely to work on this these days


Galga tutorial

This is a tutorial adaptation of the "Galga" shared at https://arcade.makecode.com/04339-84623-93497-13644.
The increasing difficulty levels are omitted to keep it simple.
Closes #870

I don't see this on the Home Page... did you publish the Tutorial?

Try an anonymous window.

Yea, I didn't see it either. I tried anonymous windows on Edge, Chrome and on my phone. It didn't even show up with local serve until I did a pxt clean.

Seems like a bug with the backend: https://github.com/Microsoft/pxt-arcade/issues/883


Original icons for the app

I've been approached to give it a try at creating original icons for the app. Here's the design that I like so far:

It has the red color of garnet, and features an ostrich which is the unofficial Nostr mascot, to make it easily identifiable by potential users, just like Amethyst does. Another variant that I have is using orange instead of red, as a nod to the fact that is Monero-related, but I think it can be confusing without adding much meaning besides ourselves insiders:

I think this design can also be adapted very easily for either Android mode, both circle and square icons, even the greyscale material adaptable variants.

Just in case, some of the previous explorations included a Garnet stone with the Monero M on a different tone:

@retrnull let me know if you need more version / svgs, specific sizes, etc.


update data model rppa 3 & 4

@elv-sb lets merge this one last of the open PRs as it has conflicts that will need to be manually resolved


Initialize reward pool

Fixes #135

Looks like only the amounts for certain tests need to be updated since rewards will change when there is more in the pool?

Looks like only the amounts for certain tests need to be updated since rewards will change when there is more in the pool?

Yep. And its an arbitrary amount (21 million) for now until the monetary policy is solidified.


Get Perseus definitions

Cross-referencing Issue https://github.com/cltk/cltk_frontend/issues/60 by @lukehollis.

@kylepjohnson I would like to implement the definition endpoint. How to get started on this one ?

I'm assuming the json format to be  {‘word’ : ‘definition’}
Propsed query URLhttps://api.cltk.org/<lang>/<define>?q=<word>
This is what I had in mind.

Hello,
I would like to work on this. Can you please explain in little more detail on how to work on this.
Thanks.

Great--looks good. Here is a proposed data format I have been working with for the definitions so far: https://github.com/cltk/cltk_frontend/blob/master/client/views/reading/DefinitionsPanel.jsx#L18

Thanks for the link. I'll post a more detailed overview, considering your implementation on the front end.

@lukehollis  Can you please give me the link to definitions in the corpus ? Thanks!

We will need to look these up programmatically based on an input string.  I'm indifferent on whether that input string should be a single word or a sentence/line of poetry.

Here's an example query for the first word of the Aeneid: http://www.perseus.tufts.edu/hopper/morph?l=Arma&la=la

@lukehollis  @kylepjohnson  If I am not wrong, whenever a user queries for a definition, we want to extract data from the following source: http://www.perseus.tufts.edu/hopper/morph?l=Arma&la=la

I am not able to find a exposed API for search results on the given website, thus we might have to scrape which is not bad as it has bare minimum html code.
There is a XML option which has incomplete info. http://www.perseus.tufts.edu/hopper/xmlmorph?lang=la&lookup=virum
The query URL for the site is very intuitive and can easily be worked out to provide different options in our API
Should this not be included in the core CLTK and then exposed using the API directly from the core ?

Give me a heads up and I'll implement this feature right on.
Thanks.

That's a good question, @manu-chroma--and thanks for tracking down the xmlmorph version.  I can see both sides and don't have a very strong opinion one way or the other, but I think that since this is specifically an issue dealing with hitting an external web API, it should exist in the cltk_api instead of core.  @kylepjohnson will have a better sense of the direction for the core package though.

@lukehollis I get your point. By the way, the xmlmorph version looks incomplete to me. It doesn't contain the definition. I think scraping is the way to go. What do you think ?

Hey guys, An alternative to using the Perseus API would be to use the same lexicon they're using.
Somehow accidentally deleted the relevant files for Latin (needs to be re-added to cltk/latin_lexica_perseus), here's Greek:

Repo: https://github.com/cltk/greek_lexica_perseus
Map of headword-inflected word: https://raw.githubusercontent.com/cltk/greek_lexica_perseus/master/greek-lemmata.txt (large file)
Greek-English dictionary: https://raw.githubusercontent.com/cltk/greek_lexica_perseus/master/greek-analyses_1.txt (large file)
See also greek-analyses_2.txt. I had to break the original greek-analyses.txt into two because it was over GitHub's 100MB limit.

The Latin works the same. @lukehollis does the Perseus API offer more than what's in greek-lemmata.txt, other than parsing it into XML for us?
Note: I'm going to open a new ticket that the Latin lemmata files get re-added to latin_lexica_perseus.

Referencing Issue #30. @manu-chroma would you like to do this? It's related and I bet will answer your question about whether to use the API or parse the files ourselves.

Not that I know of, and if we can use our own servers it seems like it'd be nicer to their systems not to be hitting their API all the time (not sure of the usage restraints there).  Working from the cltk lexica repos here seems like a better solution if possible. All for it. :+1:

Hey @manu-chroma, any updates here?  Would it be possible to push any progress that you've made?

Hey @lukehollis, I've mailed you regarding the same. Please check.

Thanks so much, @manu-chroma--and good luck with the switch!


TACKLE-132 Indentified Risks

Issue : https://github.com/konveyor/tackle-pathfinder/issues/47
Features covered

New endpoint "risks" that will answer with a List of answers + list of applications for the assessments belonging to the applications selected

Unit , Integration and End2End Tests cases covered

Unit Test ( AssessmentSvcTest.java )

given_TwoAssessmentsWith6AnswersButSharing2Questions_When_IdentifiedRisks_Then_ResultIs4LinesBut2Has2Applications

Integration Test ( AssessmentsResourceTest.java )

given_ApplicationList_WhenIdentifiedRisks_Then_ResultListOfAnswers

End2End Test on minikube with native image ( check_api.sh )

Tests 15,16,17

Pre steps Minikube:

Install minikube : https://minikube.sigs.k8s.io/docs/start/
Start minikube : minikube start --kubernetes-version=v1.20.2 --cpus 4 --memory 12000
Enable ingress addons : minikube addons enable ingress
Create tackle namespace

kubectl create namespace tackle

Deploy tackle ( to have the keycloak instance running ) on your K8s cluster

$ kubectl apply -f  https://raw.githubusercontent.com/konveyor/tackle/main/kubernetes/kubernetes-tackle.yaml -n tackle

Edit the Ingress object to allow direct request to Pathfinder API

$ kubectl edit ingress tackle -n tackle

Add this below paths:
     - backend:
          service:
            name: tackle-pathfinder
            port:
              number: 8080
        path: /pathfinder
        pathType: ImplementationSpecific

Build and push

$ ./mvnw -U -B package -Dquarkus.container-image.push=true -Dquarkus.container-image.group={your quay user} -Dquarkus.container-image.registry=quay.io -Dquarkus.container-image.username={your quay user} -Dquarkus.container-image.password={your quay pwd} -Pnative

Change the image in the deployment tackle-pathfinder to be the one you have pushed
Rollout to update the image

$ kubectl rollout restart deployment tackle-pathfinder -n tackle

Test case with Minikube : Do the full API test
$ .github/scripts/check_api.sh

Expect

+++++ API CHECK SUCCESSFUL ++++++

Pre steps non containerised local test:

run keycloak

podman run -it --name keycloak --rm \
            -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin -e KEYCLOAK_IMPORT=/tmp/keycloak/quarkus-realm.json \
            -e DB_VENDOR=h2 -p 8180:8080 -p 8543:8443 -v ./src/main/resources/keycloak:/tmp/keycloak:Z \
            jboss/keycloak:12.0.2

run postgresql

podman run -it \
            --name postgres-pathfinder -e POSTGRES_USER=pathfinder \
            -e POSTGRES_PASSWORD=pathfinder -e POSTGRES_DB=pathfinder_db \
            -p 5433:5432 postgres:10.6

run application

./mvnw quarkus:dev

Test case with local non containerised : Do the full API test
$ .github/scripts/check_api.sh localhost:8085 localhost:8180

Expect

+++++ API CHECK SUCCESSFUL ++++++

@jonathanvila Thanks for this PR, here are some questions I'd like to be addressed:

The response of GET /assessments/risks?applications=1 doesn't keep the order defined by "Category[order]" and Question[order]. Is it possible to sort the response so it keeps the original Categories and Questions order?
:+1:

In GET /assessments/risks?applications=1: could we change the QueryParam name applications by applicationId? we need to keep consistency with the other endpoints; all the other endpoints are using either assessmentId or applicationId as Query params.
Good idea.

We are using QueryParams for setting the list of applications so that info is used within the URL. We need to keep in mind that a URL's length is not unlimited. The info I've found is that a REST URL can be defined as up to 4096 characters which means only around 292 applications can be processed at a time: the queryParam is applications=1 (14 characters) => 4096/14=292.57 . I suppose this is a question for @PhilipCattanach : How many applications at a single time we are going to process? If the number is big, then it might be better to change the review endpoint to a POST request and sending the list of application within the body, but as I mentioned this really depends on how many apps we expect to process.
If the answer of "how many apps we are going to process at a time?" is "big numbers of apps" then it might be better to implement pagination in the backend for this endpoint; otherwise, let's keep it as it is and the UI can manage the pagination.

Yep, that's definitely a problem with all reports involving Applications. And this is one of them.
I haven't changed the way the list is passed to the endpoint to make very CLEAR that this approach has a lot of problems.
If the user can send hundreds/thousands of applications to the endpoint the problem is not if we pass them by Query String or Body, the problem is how the user can select manually hundreds/thousands of applications ( UI paginating every 25 elements ? how to decide which apps to include and which not : based on app name ? considering that one user entered the apps and another weeks later is asking reports , also everytime an user wants a report needs to send hundreds of apps ?... etc )
I think all of this has to be re-consider not using the individual application as an element to be requested but something that groups them and is easy to identify by an user.


[GSSOC'23]Adding hover on login page

Description

Screenshots
No response
Additional information
No response

@purviporwal0 Okay ! Assigned to you

@purviporwal0 Still working ?

@apoorvaron please assign me this task.

@sagarb2003 Assigned to you

Hello @apoorvaron, I am new to php and xampp tech stack. I have done the setup same with the way explained in video, Then I tried to make changes in local file but the results are not reflecting in "http://localhost/tiny/user/login". Can you please help me regarding this??

@apoorvaron ctrl+shift+r is not working when i am making changes in HTML for creating a custom class

@sagarb2003 check if the same css file included in particular html or not , because there are 2 folder for "css" check it once

@apoorvaron I have merged please check it

@apoorvaron  I have cloned the website again but my hovering commands are not visble in the code in the bootstrap.min.css but code is visible  in the console. So what to do.
console:

code:

@Ayushpanditmoto Please help @sagarb2003

@sagarb2003 why you editing bootstrap.min.css try to add normal css

@Ayushpanditmoto I have to make changes in the login.php and register.php and the css linked to them is :"assets/css/bootstrap.min.css"  that's why i am adding css in this
But my question is that the effect of hovering is visible on the website and code also shown on the console of the website but not on the actual file which I have cloned today.

@Ayushpanditmoto I have to make changes in the login.php and register.php and the css linked to them is :"assets/css/bootstrap.min.css" that's why i am adding css in this But my question is that the effect of hovering is visible on the website and code also shown on the console of the website but not on the actual file which I have cloned today.

@Ayushpanditmoto

@sagarb2003  broo u don't need to add css in bootstrap.min.css file its a framework file , you should not touch this file instead create custom file add css to them PR is merged by mistake

@sagarb2003 why this issue takes too much time ? it's a simplest one

@apoorvaron My End sem exams are going on and  also the reply from @Ayushpanditmoto is also late .I will in complete 2-3 days

Okay

@sagarb2003 🤔

@apoorvaron my localhost/phpmyadmin is not working in the browser. It is continuosly loading

@sagarb2003 Share screenshots

Xampp servers
Database
file structure

@sagarb2003 Database screenshot ?

but database is not opening this link is not opening http://localhost/phpmyadmin

@sagarb2003 Ok , let's drop this issue


Set up CI to automatically update Nixpkgs

Yet untested

I guess we'll see whether it works after merging

It doesn't work.


boards: shields: use shield-specific sdhc nodelabels

Use shield-specific sdhc devicetree nodelabels in order not to clash with sdhc nodelabels from the board devicetree.
Signed-off-by: Henrik Brix Andersen<EMAIL_ADDRESS>

My bad for approving this too quickly.
According to discussion here consensus was to use node label  <sensor>_<address> and not <sensor>_<shield>
I'll push a fix together with a doc update.

It's not a sensor, though. Using the scheme mentioned above will give conflicts when using multiple shields.

It's not a sensor, though. Using the scheme mentioned above will give conflicts when using multiple shields.

Could you use multiple devices that uses the same address ?

Could you use multiple device that uses the same address ?

If they reside on different busses?

Could you use multiple device that uses the same address ?

If they reside on different busses?

Ok, let me open an issue to settle on this. We need to find one rule that could be applied widely (and document it).


redirect to app after email verification

i m redirecting to my app using intent filters after user has verified his email but query parameter state and code are missing in the redirect uri. Can anyone help me on this?

@uzairaslam93 I'm having the same issue.. did you manage to solve it somehow?

yes I did Adrian. whats the exact issue that you are facing ? are you using their sdk?

yes, I'm using their SDK and I'm getting an exception after the email verification redirect: "CSRF detected!". I believe it's because of the missing state

while coming from the email verification flow intent.getextras is different. you have to detect that and open the login screen of coinbase sdk

I see, thanks for your help!