Add GMA method that uses raytracing

I think with my various attempts, I learned a lot about what wasn't working and why it wasn't working. I realize now, that many of these approaches cannot eliminate hue shifts completely unless the operation is performed in OkLCh. The hue twists in these RGB space, so the idea is to just accept that prefection is not achievable (when not working directly in OkLCh), and minimize lightness changes and hue changes as much as possible.
In short, like Scale LH, if you adjust the color in the RGB space, which this approach does, there will be hue shift at certain places. I realize now, the idea is to get as close as you can and smooth it out.
I assume this approach could be used directly on OkLCh, though I imagine it would be more complex that raytracing a perfectly aligned cube.
This approach uses raytracing to find the intersection of the chroma line on the RGB cube. Obviously, due to the way OkLCh twists the hues in the RGB space, this point will not be perfect, so we back off some degree on each attempt to get a better line. At the end, we clip the color.
I've provided two approaches, one that takes 2X passes and one that takes 3X passes. The 3X one obviously reduces hue shift the most, but 2X seems pretty acceptable as well. in use They both seem to produce smooth gradients (in the cases I tested). Lightness doesn't deviate very much, but hue can deviate in some problematic areas, the same as it does in Scale LH. A lot of time our hue deviates less, but we do deviate a little more in some cases, but with the lightness holding better, they seem far less noticeable.
I'm sure this approach can be tweaked and optimized further.
I may revisit my other approach and take what I learned here, but this approach seems pretty decent.
This is ready for review.


Update broken link in README

Summary

Opsive link was outdated, 404'd
Update with new Opsive link

Failing check due to missing Jira ticket.  If a maintainer can address this, that would be appreciated.


Versioning workflow

Hey, I noticed that the versioning job in the CI is failing. Seems like your last tag is not attached to main so semver fails (https://github.com/push-based/user-flow/commit/130839cd890d1e71e8d46350caf604aea02634c9).
I wonder how you end up with that state as it's not possible with the actual configuration.

Hi I fixed it and have to say I have NO CLUE why this is happening so often :(


sdk implementation of vpc endpoint

Hi @wuebbels , do not forget to add release note by reno(https://pypi.org/project/reno/)


To Do for Falon: fix displaynames

displayname should just be same as username
remote pictures should just be their username when hovered

I don't know how to change what the display is when mouse hovers over the picture of the post author our template only knows the remote author fields: id, host, github.... Why can't we get the other information from our remote authors of posts?

for remote authors of posts this doesn't work for some reason.... don't have option of username or display name in the template for remotes.? not sure why is done the same as mainstream regular ones are

I have this fixed, I just haven't pushed yet.

ohhh wicked thanks geneva


Desktop E2E Test: MM-T809/MM-T810/MM-T811 Cut/Copy/Paste in the Menu Bar

This ticket is to create a test script to automate some testing for the Desktop App.
The testing framework makes use of a few frameworks to successfully automate Desktop App tasks:

Playwright: An E2E testing framework provided by Microsoft that currently has “experimental” support for Electron. Using Playwright, you can access individual BrowserWindows or BrowserViews and automate most functionality provided within those windows. You can also get access to the main Electron process and verify/check functionality in the main process. See here for docs: https://playwright.dev/docs/api/class-electron
RobotJS: A Node.JS Desktop Automation tool that allows us to arbitrary emulate mouse and keyboard inputs. This is used for automation around Electron keyboard shortcuts and the menu bar. It is useful to cover cases that aren’t automatable directly through Playwright (since the menu is not an HTML control). See here for docs: http://robotjs.io/docs/syntax

The test should be written in the file e2e/specs/menu_bar/edit_menu.test.js
If the file doesn’t exist, feel free to create it.
If you’re looking for examples, see these PRs:
https://github.com/mattermost/desktop/pull/1841
https://github.com/mattermost/desktop/pull/1843
https://github.com/mattermost/desktop/pull/1846
The test script for this ticket is as follows:
Setup:

Ensure the test config is using the Demo Mattermost server, and make sure the app opens on said server.
Login to the demo server
Type a message in the message box, do not hit Send. Select the message.

MM-T809

Using the menu or keyboard shortcut, press CtrlC.
Unselect the message and then CtrlC, then delete the message.
Press Ctrl+V. Verify that the message is once again present.

Expected:
See above verifications

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please  join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-39617

Working on this


cloud-config: bump linux metadata

Pick up support for digital ocean and cdrom-by-label.
Fixes #468

It also reads the user data from the more consistent user-data file which should help with some of the issues brought up in #66


Timeout waiting for connection from pool

Description of the bug
Hi,
I get the error in the title when I run the command line below.
The error is this one: https://www.biostars.org/p/9590721/ but related to circrna.
What's wrong?
thanks in advance
Command used and terminal output
./nextflow run nf-core/circrna -profile docker --genome GRCh38 --input samples.csv --tool 'ciriquant' --module 'circrna_discovery' --outdir ./results_single --tool_filter 1 -r dev

Relevant files
.nextflow.log
System information
N E X T F L O W  ~  version 23.10.1
OS: Rocky Linux 8
Container: Docker
Version of nf-core/circrna: revision: c29124feaf [dev]

Hey, this seems to be a problem that is not really related to the pipeline, but a more general one. Since you provided the --genome parameter, nextflow tries to fetch reference genome data from an AWS S3 bucket. This is also what the people in the Biostars discussion figured out. I can only recommend to follow the same steps which were suggested there. If the problems persist, you might want to remove the genome parameter and instead download the fasta and gtf files of your genome manually and pass the downloaded versions to the pipeline using the --fastaand --gtf parameters, respectively.
Keep me posted!

Hi Nico, it should be a problem in amazon or whatnot. Setting static paths, it works. Thanks for the quick reply.


Can't rotate player on profile screen

https://discord.com/channels/355905150528913409/1148592822967083048/1267902054622433384

Fixed (f10233a23796f144aa9be3e9ff8a025dbc86b49b, within #579)


339 3.4 deprecation

Adds a FutureWarning that Python 3.4 will be deprecated along with Python 2. Closes #339. I considered adding 3.5 to the list, since it's reaching EOL in 2020, but I figured it's better to be conservative about dropping support.
I don't know of a way to test that this code works within pytest (see discussion in #333 ), but I've attached screenshots confirming that the warning is issued in 3.4 and not in 3.6.

@patr1ckm flagging this in case it got lost in the shuffle.


Upload tvOS builds

          Original issue by @notbenoit - Imported from fastlane/pilot#92

Sorry this is a duplicate...https://github.com/fastlane/pilot/issues/55  :( My bad! Feel free to close this useless duplicate.

First, thanks for the amazing toolchain!
My issue here, is that I cannot upload an IPA to ITC using pilot (or any similar tool, even altool fails). Only Application Loader worked. But I need command line upload. The error here is :
ERROR ITMS-90545: "Invalid Provisioning Profile. This provisioning profile is not compatible with iOS apps."

But, I investigated, and found that the default package sent from altool looks like that :
<package version="software5.3" xmlns="http://apple.com/itunes/importer">
    <software_assets apple_id="#APPLE_APP_ID#"
        bundle_short_version_string="0.1"
        bundle_version="151201105028"
        bundle_identifier="#BUNDLE_IDENTIFIER#"
        app_platform="ios">
        <asset type="bundle">
            <data_file>
                <file_name>#IPA_NAME#</file_name>
                <checksum type="md5">a97130dc797045444e1d422255611afb</checksum>
                <size>21210100</size>
            </data_file>
        </asset>
    </software_assets>
</package>

(I removed app specific data).
Here note app_platform="ios". This is where is the magic. I made my own itmsp package with appletvos instead of ios parameter, and managed to upload the IPA !
Since I have nearly zero knowledge about how pilot works, do you have any idea how we could add a parameter, or detect the target, to have this appletvos set in the sent XML ?
EDIT : The only things needed to successfully upload a tvOS build are packageVersion at 5.3 and app_platform with appletvos. No need for the bundle(s) stuff.

Any update on this? Im still getting This provisioning profile is not compatible with iOS apps.when building with gym and submitting with deliver to tvOS

@aresundnes Thanks for following up on this. Can you create a new issue if you are running into this still? Thanks!


[Bug]: Thumb up/down icons not visible

What happened?
Open Playground page in a browser. Thumb up and thumb down Icons not visible on the left corner of the screen after "Enjoying Playground?" text
Issue Priority
Priority: 2
Issue Component
Component: beam-playground

.take-issue

Which branch is that? @olehborysevych

Not reproducible. Must be a defect in the particular build.

HTML Renderer
CanvasKit Renderer

master

tob-demo-deploy

@rshamunov to confirm.

it's not reproduced in my environment neither


issue/5126-add-compile-wait-time-metrics

Description
This PR adds the metrics collector that tracks the amount of time a compile request spends in the compile queue before being executed by the compiler service.
Tasks:

[x] Add metrics collector
[x] Register the metrics collector to the EnvironmentMetricsService slice.

closes #5126
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Merged into branches iso6, master in b9b07d546e1f59c22cecb93ade1c0edc1c6515a7


Update Main.java

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey Siddharth! This change seems to be a mistake, since it's just a copy-paste of code in line 41. We do welcome contributions so feel free to open other PRs. Have a nice day :)


setup error, anyone knows how to fix this?

Run shivammathur/setup-php@v2
11
/usr/bin/bash /opt/hostedtoolcache/linux.sh $ { /home/runner/work/_actions/shivammathur/setup-php/master/dist
12
/opt/hostedtoolcache/linux.sh: line 273: {/../src/scripts/ext/source.sh: No such file or directory
13
/opt/hostedtoolcache/linux.sh: line 274: {/../src/scripts/tools/add_tools.sh: No such file or directory
14
/opt/hostedtoolcache/linux.sh: line 275: {/../src/scripts/common.sh: No such file or directory
15
/opt/hostedtoolcache/linux.sh: line 277: read_env: command not found
16
/opt/hostedtoolcache/linux.sh: line 278: self_hosted_setup: command not found
17
/opt/hostedtoolcache/linux.sh: line 225: step_log: command not found

from : https://github.com/laruence/yaf/actions/runs/1003361502/workflow
thanks in advance.

Remove the space in ${{ matrix.PHP }}, also please use v2 instead of master.
- name: Setup
  uses: shivammathur/setup-php@v2
  with:
    php-version: ${{ matrix.PHP }}

ah, how silly !, thanks!


Rose 2013-09 has a patch applied

resolution_fixed   |    by ibc599

Version 2013-09 has a patch applied to fix the rose stem bug as outline in https://github.com/metomi/rose/issues/952
Fix is not in version 2013-09 or current puppet configurations and must be done manually.

Issue migrated from trac:27 at 2024-01-31 17:10:17 +1100

ibc599 commented

File that needs to be changed is
/usr/local/rose/lib/python/rose/stem.py
at line 178
   result = re.search(r'url:\s*(file|svn)(://.*)', output)

should be changed to
   result = re.search(r'url:\s*(file|svn|https)(://.*)', output)

<EMAIL_ADDRESS>commented

Milestone Future deleted

ibc599 changed status from new to closed

<EMAIL_ADDRESS>removed milestone (was Future)

ibc599 changed resolution from `` to fixed

ibc599 commented

This fix is part of the standard release now


Add manoj to Contributors list

@Samaritan1011001, could you please add your name to Contributors.md?


terraform-aws-modules/eks/aws latest version not available in registry.terraform.io

When attempting to use the module terraform-aws-modules/eks/aws in the Terraform public registry, the latest version (19.15.3) kicks back a 404 error. You have to pin the version to 19.15.2 or earlier to be able to use this module at all. Specifying no version or the latest will result in a 404 error. Was the latest release pulled from the Terraform public registry for same reason? This needs to be resolved. Thanks.

If a version is pulled from the registry, the registry would not show it as available. However, no, we have not recalled any versions from the registry and today I have deployed several clusters using the v19.15.3 version
Closing since this doesn't require an module changes


🩹 fix: use correct default value for var in docker-compose.yml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.789%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
945

Relevant Lines:
947

💛  - Coveralls

I have read the CLA Document and I hereby sign the CLA


add center-table class to center a table

center-block won't center a table, wrapping a table with a div with class center-block also does not center a table.
This is because center-block sets display:block. For tables, this needs to be display:table
Create center-table class here that can be used to center a table.

What about instead adding a table.center-block selector that overrides the display property? Then .center-block just works instead of adding more class names.

We're no longer accepting new features into Bootstrap v3. But please feel free to open a PR for this against the v4-dev branch for Bootstrap v4. Thanks!

Since display:block no longer applies, it seems somewhat misleading to use a class called "center-block"

Superseded by #17580.


Allow VMs without ISO and Clone

I am trying to PXE-boot VMs on PVE using this Terraform provider. It seems I have to either specify iso or clone, otherwise I'm greeted with a message explaining I did not specify them. I can work around it by setting iso = "none", of course. It would be nice if either this check is turned into a warning, or the workaround is documented.

Issue seems resolved by #495 and #492


Add missing docstrings

Codecov Report

Merging #13 (34dd5a7) into main (43788c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   96.21%   96.21%
=======================================
  Files           4        4
  Lines         132      132
=======================================
  Hits          127      127
  Misses          5        5

Impacted Files
Coverage Δ

sunpy_soar/client.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43788c1...34dd5a7. Read the comment docs.


[Accessibility] Set of changes to make the simulator accessible

Added a set of helpers usable in the simulator to make it accessible.
Fixed a few details that were considered as failures by Keros.

@veler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Add the ability to flip the selection

Truly, Factorio will not be able to keep up.

(oof my gamepad bindings...)

I'd like to try out #332 first, and play with the gameplay implications there first.


Update config.xml to respect table settings

glDescription is NOT NULL in  Table Geolocators

NOT NULL doesn't mean that it can't contain an empty string

When dumping the DB i get this.


GPR curation for Chondroitin sulfate degradation and Sulfur metabolism

Current behavior:

9 genes are discovered to be uncorrelated with their corresponding reactions in Chondroitin sulfate degradation and Sulfur metabolism.

Gene
UniProtID
Reaction
GPR
Correlation
Manually check

ENSG00000104331
Q9NX62
MAR04187: H2O + PAPS --> adenylyl sulfate + Pi
ENSG00000104331 or ENSG00000162813
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation. According to the annotation, the gene ENSG00000104331 encodes an enzyme with 3'-nucleotidase activity that specifically hydrolyzes adenosine 3',5'-bisphosphate (PAP) to adenosine 5'-monophosphate (AMP) and phosphate. This enzyme does not act on 3'-phosphoadenosine 5'-phosphosulfate (PAPS) or various inositol phosphate substrates. Therefore, it is not involved in the reaction provided (H2O + PAPS --> adenylyl sulfate + Pi), indicating the gene's function does not relate to the specified reaction.
No

ENSG00000108602
P30838
MAR04842: SAM --> activated methyl group + SAH
ENSG00000006534 or ENSG00000108602 or ENSG00000132746 or ENSG00000184254
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The provided gene, ENSG00000108602, encodes an aldehyde dehydrogenase (ALDH) enzyme that primarily catalyzes the oxidation of aldehydes to carboxylates, using NAD+ as a cofactor. The specific reactions mentioned involve aldehyde substrates and their conversion to fatty acids. In contrast, the reaction given, "SAM --> activated methyl group + SAH," pertains to the conversion of S-adenosylmethionine (SAM) to S-adenosylhomocysteine (SAH), a methylation process. This reaction does not involve the metabolism of aldehydes, which is the primary function of the ALDH enzyme encoded by ENSG00000108602. Thus, the gene does not relate to the provided reaction.
No

ENSG00000204386
Q99519
MAR07530: chondroitin sulfate C (GalNAc6S-GlcA), degradation product 3 + H2O --> chondroitin sulfate C (GalNAc6S-GlcA), degradation product 4 + H+ + sulfate
ENSG00000064601 and ENSG00000141012 and ENSG00000170266 and ENSG00000204386
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The gene ENSG00000204386 encodes an enzyme that catalyzes the removal of sialic acid residues from glycoproteins and glycolipids. However, the reaction described involves the degradation of chondroitin sulfate C, which does not involve sialic acid residues but involves the hydrolysis of a different substrate, resulting in the release of H2O, H+, and sulfate. Hence, the function of the gene does not relate to the chondroitin sulfate C degradation reaction.
No

ENSG00000204386
Q99519
MAR07542: chondroitin sulfate D (GlcNAc6S-GlcA2S), free chain + H2O --> chondroitin sulfate D (GlcNAc6S-GlcA2S), degradation product 1 + H+ + sulfate
ENSG00000064601 and ENSG00000141012 and ENSG00000170266 and ENSG00000204386
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation. The gene ENSG00000204386 encodes an enzyme that catalyzes the removal of sialic acid moieties from glycoproteins and glycolipids, with a preference for alpha 2-3 and alpha 2-6 sialyl linkages. However, the reaction provided involves the degradation of chondroitin sulfate D, which is a different type of polysaccharide, and does not involve sialic acid moieties. Therefore, the enzyme encoded by this gene does not catalyze the reaction described.
No

ENSG00000204386
Q99519
MAR07560: chondroitin sulfate E (GalNAc4,6diS-GlcA), degradation product 1 + H2O --> chondroitin sulfate E (GalNAc4,6diS-GlcA), degradation product 2 + H+ + sulfate
ENSG00000064601 and ENSG00000141012 and ENSG00000170266 and ENSG00000204386
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The given gene (ENSG00000204386) encodes a protein that catalyzes the removal of sialic acid moieties from glycoproteins and glycolipids, with a preference for alpha 2-3 and alpha 2-6 sialyl linkages. The reaction described involves the degradation of chondroitin sulfate E and does not pertain to the hydrolysis of sialic acid residues. Therefore, the gene products do not participate in the provided reaction.
No

ENSG00000204386
Q99519
MAR07526: chondroitin sulfate C (GalNAc6S-GlcA), free chain + H2O --> chondroitin sulfate C (GalNAc6S-GlcA), degradation product 1 + H+ + sulfate
ENSG00000064601 and ENSG00000141012 and ENSG00000170266 and ENSG00000204386
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation. The gene ENSG00000204386 encodes an enzyme that catalyzes the hydrolysis of terminal sialic acid residues from glycoproteins and glycolipids. The provided reaction, however, describes the degradation of chondroitin sulfate C, which involves cleaving a different substrate (GalNAc6S-GlcA) and producing different degradation products including H+ and sulfate. Therefore, the gene's annotated function does not align with the described reaction mechanism.
No

ENSG00000204386
Q99519
MAR07547: chondroitin sulfate D (GlcNAc6S-GlcA2S), degradation product 4 + H2O --> chondroitin sulfate D (GlcNAc6S-GlcA2S), degradation product 5 + H+ + sulfate
ENSG00000064601 and ENSG00000141012 and ENSG00000170266 and ENSG00000204386
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The gene ENSG00000204386 encodes for an enzyme that catalyzes the removal of sialic acid moieties from glycoproteins and glycolipids, specifically hydrolyzing alpha-(2->3)-, alpha-(2->6)-, and alpha-(2->8)- glycosidic linkages of terminal sialic acid residues. On the other hand, the provided reaction involves the degradation of chondroitin sulfate D, resulting in the formation of degradation products along with water, a proton, and sulfate. There is no mention of sialic acid or glycosidic linkages in chondroitin sulfate D, and thus, the gene's function and the specific enzymatic activity it encodes are not related to this reaction.
No

ENSG00000135702
Q9GZS9
MAR07369: keratan sulfate I biosynthesis, precursor 34 + PAPS --> H+ + keratan sulfate I biosynthesis, precursor 35 + PAP
ENSG00000135702 or ENSG00000140835 or ENSG00000175040 or ENSG00000183196
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The gene ENSG00000135702 encodes a sulfotransferase enzyme that specifically catalyzes the transfer of sulfate to the position 6 of non-reducing N-acetylglucosamine (GlcNAc) residues and O-linked sugars of mucin-type acceptors. However, the given reaction involves the biosynthesis of keratan sulfate I, which the gene's enzyme has no activity toward. Therefore, the gene's function does not align with the reaction described.
No

ENSG00000106304
P38567
MAR07503: chondroitin sulfate A (GalNAc4S-GlcA), free chain + 2.0 H2O --> chondroitin sulfate A (GalNAc4S-GlcA), degradation product 2 + H+ + N-acetylgalactosamine + sulfate
ENSG00000049860 or ENSG00000068001 or ENSG00000106302 or ENSG00000106304 or ENSG00000114378 or ENSG00000169660 or ENSG00000186792 or ENSG00000213614
Pending No, the gene is not relevant to the reaction provided. Analysis and explanation: The gene ENSG00000106304 encodes a protein involved in sperm-egg adhesion by digesting hyaluronic acid, whereas the reaction involves the hydrolysis of chondroitin sulfate A. The functions and substrates of the gene product and the reaction are different, indicating no relevance between them.
No

keep gene ENSG00000104331 for reaction MAR04187
keep gene ENSG00000135702 for reaction MAR07369

All of these seem fine to me.

Could you please help us to review this issue? @feiranl

Good Example for Manuscript:
ENSG00000104331 for MAR04187 could serve as a good example for the manuscript. Due to the structural similarity between PAPS and PAP, this reaction was initially kept/added in Human-GEM. However, GPT correctly identified that the enzyme has no activity towards 3'-phosphoadenosine 5'-phosphosulfate (PAPS) or inositol phosphate (IP) substrates, including I1P, I(1,4)P2, I(1,3,4)P3, I(1,4,5)P3, and I(1,3,4,5)P4, and suggested removing this reaction from Human-GEM. This highlights the power of LLMs. Similarly, for ENSG00000135702 in MAR07369, even though the reaction pattern seems correct with PAPS as a co-substrate, the annotation indicates no activity towards keratan, which was also accurately identified by GPT.
Other parts seems fine to me!


I am trying to install and evaluate the 7b version first.

Inference implemented in 05990898e19bd2477187738b8e08d0719a9a6265. Waiting for resources to run it.

I can try to run your codellama evaluation code and confirm results

CodeLlama 7B and 13B results are updated on https://evalplus.github.io/
CodeLlama 34B somehow did not generate one input after 10 minutes. Am debugging it right now.

Inference implemented in 0599089. Waiting for resources to run it.

Fixed a few bugs in fc10dc72addb508dcd0084133ad425972887d709 and now it should at least work for 7b and 13b.

I can try to run your codellama evaluation code and confirm results

Hi Yacer thanks for the support.
For you and others who are interested in reproducing the results, feel free to try the scripts below after a git clone install:
export PYTHONPATH=$(pwd)

# 7b
CODE_LLAMA_ROOT=/path/to/7b-python-model torchrun --nproc_per_node 1 codegen/generate.py --model code-llama-7b --bs 1 --temperature 0 --n_samples 1 --resume --greedy --root /path/to/root
python tools/sanitize.py --folder /path/to/root/code-llama-7b_temp_0.0
python evalplus/evaluate.py --dataset humaneval --samples /path/to/root/code-llama-7b_temp_0.0-sanitized --parallel $(nproc)

# 13b
CODE_LLAMA_ROOT=/path/to/13b-python-model torchrun --nproc_per_node 2 codegen/generate.py --model code-llama-13b --bs 1 --temperature 0 --n_samples 1 --resume --greedy --root /path/to/root
python tools/sanitize.py --folder /path/to/root/code-llama-13b_temp_0.0
python evalplus/evaluate.py --dataset humaneval --samples /path/to/root/code-llama-13b_temp_0.0-sanitized --parallel $(nproc)

# 34b
CODE_LLAMA_ROOT=/path/to/34b-python-model torchrun --nproc_per_node 4 codegen/generate.py --model code-llama-34b --bs 1 --temperature 0 --n_samples 1 --resume --greedy --root /path/to/root
python tools/sanitize.py --folder /path/to/root/code-llama-34b_temp_0.0
python evalplus/evaluate.py --dataset humaneval --samples /path/to/root/code-llama-34b_temp_0.0-sanitized --parallel $(nproc)

Of course you will need 4 GPUs w/ 16GB+ memory and have the corresponding models installed. Also see https://github.com/evalplus/evalplus/blob/master/codegen/model.py#L637

The stuck seems to be related to a PyTorch thread here: https://github.com/pytorch/pytorch/issues/22259#issuecomment-1439447697 since the machine is using the same NCCL version.

Bug solved by setting NCCL_P2P_LEVEL=NVL. (source: https://github.com/pytorch/pytorch/issues/73206#issuecomment-1054442959)

All updated here! https://evalplus.github.io/leaderboard.html

I am trying to replicate your results using the script you have appended above, but I am encountering the following errors, I made sure to download all of the packages in the 3 requirements files (including fschat). I also git cloned the repository as well as downloaded the evalplus package. Thanks a lot for your help.
`
export PYTHONPATH=$(pwd)
export NCCL_P2P_LEVEL=NVL
CODE_LLAMA_ROOT=coder_34b torchrun --nproc_per_node 8 codegen/generate.py --model code-llama-34b --bs 1 --temperature 0 --n_samples 1 --resume --greedy --root root
python3 tools/sanitize.py --folder root/code-llama-34b_temp_0.0
python3 evalplus/evaluate.py --dataset humaneval --samples root/code-llama-34b_temp_0.0-sanitized --parallel $(nproc)
WARNING:torch.distributed.run:

Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.

Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/generate.py", line 5, in
from model import DecoderBase, make_model
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/codegen/model.py", line 33, in
from fastchat.serve.inference import load_model
ModuleNotFoundError: No module named 'fastchat'
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 280995) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/home/paperspace/.local/bin/torchrun", line 8, in
sys.exit(main())
File "/home/paperspace/.local/lib/python3.10/site-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 346, in wrapper
return f(*args, **kwargs)
File "/home/paperspace/.local/lib/python3.10/site-packages/torch/distributed/run.py", line 794, in main
run(args)
File "/home/paperspace/.local/lib/python3.10/site-packages/torch/distributed/run.py", line 785, in run
elastic_launch(
File "/home/paperspace/.local/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/paperspace/.local/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
codegen/generate.py FAILED
Failures:
[1]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 1 (local_rank: 1)
exitcode  : 1 (pid: 280996)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[2]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 2 (local_rank: 2)
exitcode  : 1 (pid: 280997)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[3]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 3 (local_rank: 3)
exitcode  : 1 (pid: 280998)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[4]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 4 (local_rank: 4)
exitcode  : 1 (pid: 280999)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[5]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 5 (local_rank: 5)
exitcode  : 1 (pid: 281000)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[6]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 6 (local_rank: 6)
exitcode  : 1 (pid: 281001)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[7]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 7 (local_rank: 7)
exitcode  : 1 (pid: 281002)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
Root Cause (first observed failure):
[0]:
time      : 2023-08-27_14:18:43
host      : ps66g8gxe
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 280995)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
0it [00:00, ?it/s]
Sanitized 0 out of 0 files.
Traceback (most recent call last):
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/evalplus/evaluate.py", line 279, in
main()
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/evalplus/evaluate.py", line 273, in main
evaluate_humaneval(args)
File "/home/paperspace/LLaMA-Efficient-Tuning/evalplus/evalplus/evaluate.py", line 122, in evaluate_humaneval
assert flags.samples.endswith(".jsonl")
AssertionError`

I think I got confused, reading model.py, it seems to be tailored to benchmark models directly downloaded from codellama. What if we want to evaluate the codellama from hf ?

Sorry. There are some dependencies required in https://github.com/evalplus/evalplus/blob/master/requirements-llm.txt

I think I got confused, reading model.py, it seems to be tailored to benchmark models directly downloaded from codellama. What if we want to evaluate the codellama from hf ?

Yes it is. To be consistent with the original CodeLlama usage as much as possible, I directly used followed the code in their official repo.


Manual input bugs

Entering date manually has some strange behaviour when displayFormat is custom.
In Storybook I tried to enter Nov 27 but DayPicker is closing and DateInput is loosing focus just after 2.. If I click again to add 7, (even if cursor is not displayed, double click to select complete string, then right key to go through the end of the date...) it will fallback to default display..

So I am still thinking of an input mask, maybe it could help this strange behaviour...

I can't seem to reproduce this anymore given the change to the inputs.
It still loses focus with the custom date when you type Dec 2, but when you select the input again and add a 7, it works as expected (selecting Dec 27). I'm going to close this. :)


WIN64 fp reg varargs have to be duplicated into corresponding int arg…

… regs.
Thanks for the suggestion to copy the args using stack. It aint pretty but it works.

I've merged your patch.  Thank you for working on Win64 ABI implementation.
Moving values through memory is not that bad.  Varag is rare case and movd can be slower on some mciro-architectures (although movd is faster on widely used Intel ones).  GCC sometimes prefers to generate such moves through memory too.


problem death 8.0.2

Hi in the version Magic 8.0.2 the wand is duplicate after the death with the plugin dead souls.
In the version 8.0.1 i have not this problem...
What has changed since with the new version if magic?  please
https://www.spigotmc.org/resources/dead-souls.69409/

Sadly what changed is avoiding item dupe issues on death with other plugins (Graves, MagicArenas).
Please go back to 8.0.1, I'll try out dead souls and see if I can make everything work together nicely.

I think I got this fixed, if you'd like to try out the latest stable dev build:
https://jenkins.elmakers.com/job/Magic-Stable/10/
It's a tricky thing to make the event priority work with all different plugins, hopefully this didn't just break something else :joy:

It works the wand is not duplicate thank you very much

Hey I wanted to let you know that I found another issue with DeadSouls - if you pick up your soul with your wand inventory open, your soul items can get lost.
I have fixed this in the latest Magic dev build, but you will also need the latest DeadSouls that just came out (1.6)
This will also add a player's lost souls to Recall level 2.


Axios options reference link corrected

Changed axios options reference link from https://github.com/nuxt-community/axios-module#options to https://axios.nuxtjs.org/options

Thank you for your contribution ☺


Trusted Header authentication

Here's my take on using proxy or trusted header authentication.
My use case was offering federated SAML login (which isn't supported by passport-saml2), but this will work for any use case delegating authentication to the proxy or load balancer placed in front of multiparty-meeting - as long as they pass along the information in HTTP headers.
Here's the Apache config I used for completeness sake:
ProxyPass /Shibboleth.sso !

RewriteCond %{REQUEST_URI}  ^/socket.io/?          [NC]
RewriteCond %{QUERY_STRING} transport=websocket    [NC]
RewriteRule /(.*)           ws://<IP_ADDRESS>:8080/$1 [P,L]

ProxyPass / http://<IP_ADDRESS>:8080/
ProxyPassReverse / http://<IP_ADDRESS>:8080/

ProxyPreserveHost On

<Location /auth/login>
        AuthType shibboleth
        ShibRequestSetting requireSession 1
        Require valid-user
</Location>

<ProxyMatch ^(?:http|ws)://<IP_ADDRESS>:8080>
        Require all granted

        RequestHeader set uid %{uid}e
        RequestHeader set mail %{mail}e
        RequestHeader set givenName %{givenName}e
        RequestHeader set sn %{sn}e
        RequestHeader set schacHomeOrganization %{schacHomeOrganization}e
        RequestHeader set X-Forwarded-Proto https
</ProxyMatch>

Many thanks for the PR!
(IMHO Satosa /or maybe  Keycloak/ is the best way to support SAML. It gives you much more flexibility on the mapping, and involving Identity federations, etc.)
I run through it and saw that  there are many fields hardcoded in the mapping, if we want trusted header then IMHO we should make it more configurable.
Please also add an example mapping config in app/config/config.example.js

I've added a little info to the example config.
The field keys are hardcoded, the header names themselves are supposed to be given in the config.


[Bug]: Fields are moved from inline to FrontMatter

Contact Details
I'm on GitHub
What happened?
Hi, first of all thank you for this Plugin!
But when I edit an inline Field, it is moved into the FrontMatter. I don't think this is intended, because I have selected "Enable inline Fields as Default" both in the DB and the Plugin Settings.
This is a question; if you need a sample I can try to upload the zipped Folder somewhere.
Thanks for your help.
Before:
---
type: Continent
tags:
  - geo/Continent
---
[IsDeleted:: true]
[IsPrivate::]
[name-en::Antarctica]
[name-de::Antarktis]

After:
---
type: Continent
tags:
  - geo/Continent
IsDeleted: false
---
[]
[name-en::Antarctica]
[name-de::Antarktis]

What platform were you using?
Desktop
Version of the plugin
3.3.0
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

Hello @SpocWeb , Enable inline Fields as Default will create the NEW columns with that flag activated, but the existing one will be threated like frontmatters.
I do not know if its the case here

@SpocWeb check the title of the Column in the db. If it has a * next to it, it is an inline field.

To change that click settings for the column:

And tick the second option.

This happened to me and it may be the same thing causing it for you. If not, then it's a bug

That's it!
As I see right now, you can configure it for each column individually and that's what I didn't pay attention to.
I populate the Columns from the sample Record using your Button "Use all Fields" and this does not seem to set this Checkbox. If it is possible to defermine from the Obsidian or DataView API whether the Data comes from Inline or Frontmatter it would really save me and other people from being perplexed.
Alternatively I would volunteer to expand your documentation in this respect, to help future Users

I'll do a global search/replace from isInline: false to isInline: true in all my dbs now, because it doesn't cost much more space and is more versatile; I can add Tags and Links. I hope this doesn't make a big difference performance-wise.
thank you all for your help!


expose riak_kv.query.timeseries.max_running_fsms

This is to make configurable the max number of index FSM spawned to serve TS queries.
For @erikleitch to review.

+1
Code changes look good.
We should decide whether we want to change the default value.  Personally, I don't see a compelling reason not to.  On the client side, if the qry worker is tied up processing data from the current query, it will simply not be available for another query, and incoming queries will be queued until the max queue depth is reached, and an overload error is thrown.  On the server side, based on my quick reading of the code (maybe incorrect?), we already have a pressure release valve encoded as the max_query_data_size, which is # fsms x size of data chunks.  So if the subqueries' data exceeds this limit, we already have a mechanism for cancelling overlarge queries.  (This seems like a better gauge of when a query is too large anyway -- not the # of subqueries)  And in the use-cases we've seen so far, customers are far more interested in infrequent large queries returning quickly than they are about getting lots of queries pushed through the system.
Code doesn't build because tsqueryreq allow_qbuf_reuse has been removed, but is still referenced in this branch.  That'll have to be fixed before we merge.

+1 bad3ba9

@borshop merge

@hmmr I'm having some test failures seemingly related to this merge, like ts_simple_select. I'll investigate more.


Bug: FB Messenger Audio / Video Calls not working

Avoid duplicates

[X] I have searched the issues tracker for a bug report similar to mine, in vain

Ferdium Version
6.0.0
What Operating System are you using?
Windows
Operating System Version
Window 10 21H2
What arch are you using?
x64
Last Known Working Ferdium version
6.0.0
Expected Behavior
Usually, when making a Call (audio or video), a pop-up window appears and we perform the call smoothly.
Actual Behavior
When I click on the Call (audio or video) Button, nothing happens.
When someone is calling me, a pop-up appears notifying me who's. But when I click on the Video Button to answer, the pop-up just disappears.
A "dropped call" is registered to the recipient calling me.
Then from the chat window, a blank message bubble from the recipient is seen.
Steps to reproduce

Go to Messenger window.
Click on the Call button (Phone icon for audio call, or, video icon for video call).

Debug link
No response
Screenshots
No response
Additional information
No response

Good day!
Any update on the above issue?
Thanks!

it's been more than 4 mounths this issue is open and with no answer .... Messenger app is one of the most used...Please consider it  as a priority, or at least: ANSWER !


Videos Start Playing onScroll even after pausing it manually in Container.

Thank you for the amazing library @eneim , Will surely buy a coffee if I succeed in my project.
Inside container videos start playing on scroll, even after pausing it through the controller.
I have checked toro facebook demo. It is also having same kind to issue.

[ <IP_ADDRESS>0003] Toro version.

[ ] Other. Senseless issues are normally ignored. Please understand and cooperate.

@androidvk How deep you are integrating toro in your App? Manual playback is quite complicated. If you can switch to this library, also created by me I can assist you better. If you cannot change, please leave a comment and give me your current code (just the part you use toro) I will take a look.

Hello @eneim my code is in java. that's why I won't be able to use the library you suggested.
Everything is working fine. But I don't know why paused video starts playing on scroll automatically.

@androidvk Please show me your current code if you still want to implement this.


Update sbt-typelevel, ... to 0.7.3

About this PR
📦 Updates

org.typelevel:sbt-typelevel
org.typelevel:sbt-typelevel-scalafix
org.typelevel:sbt-typelevel-site

from 0.6.7 to 0.7.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, commit-count:n:2

Superseded by #260.


Question on SIFT

in sift.c in vl_sift_calc_keypoint_orientations, we see that
double const winf   = 1.5 ;
double const sigmaw = winf * sigma ;
int W = VL_MAX(floor (3.0 * sigmaw), 1) ;
In Lowe's original paper, he states "The orientation histogram is created using a Gaussian-weighted window with a sigma of 3 times that of the current smoothing scale".
I understand where the 3.0 comes from but I'm confused where the 1.5 is used for? Is this just to make the subsequent loop go in a square around the circle with radius 3*sigma?
If so then whys the skip condition for calculating the histogram for a pixel
if (r2 >= W*W + 0.6) continue ;
what's the 0.6? this suggests we're not considering a point for the orientation histogram if the point lies outside a slightly enlarged circle of radius (W*W) + 0.5?
from my reading of the paper, i would expect to see the breaking condition as
r2 >= (3*sigma)*(3*sigma)) continue;
Thanks for any help understanding this!

VlFeat has many tweaks and modifications, many for performance reasons, and the SIFT calculation is not exactly the same as the one proposed by Lowe.   For instance, the patch size used to calculate the final histogram of gradients does not match what is being shown https://github.com/vlfeat/vlfeat/issues/190.
In this case the real patch size used to determine the patch orientation will be:
Z = 2 * W = 2 * ( 3 * sigmaw ) = 2 * (3 * winf * sigma ) = 3 *   2*winf * sigma = 3 * 3 * sigma
This is because it goes from -W to W.  Maybe someone from the developing team could clarify this further.

hmm an optimization makes sense
 int W = VL_MAX(floor (3.0 * sigmaw), 1) ;
suggests we either use the max of 1.5sigma or floor(31.5*sigma) depending on how big sigma is. This seems like to say the more "uncertain" we are the larger surface area we consider.


Error handling when installing and deleting flows

Continuation on previous PR. In that PR retries where added to flow installation and deletion as well as an exception raising. This process can still fail so it would be better to add a way to recognize this EVC with failed flows and keep them until the cause of the error is resolved.

Setting it as priority_medium for now instead of priority_major since in theory with the api concurrency limit properly sized this is less likely to happen, although certainly deserves to be fixed when we have the chance.


Lootr has failed to load up correctly.

crash-2023-06-20_17.55.42-fml.txt
latest.log
lootr-common.toml.txt
Hello there,
I have been trying to play CurseForge Java 1.19.2 - 43.2.14 but Lootr doesn't load correctly and I don't know why.
I tried installing Lootr from here: [https://www.curseforge.com/minecraft/mc-mods/lootr/files] but it still doesn't load well and it displays this message in Minecraft: 'Lootr (lootr) has failed to load correctly java.lang.reflect.InvocationTargetException: null'
The one I installed was (lootr-1.19.2-<IP_ADDRESS>) from [https://www.curseforge.com/minecraft/mc-mods/lootr/files/4465109]
Above is the crash report, latest.log and I converted the lootr.common.toml into a .txt file. What should I do to overcome this issue?
Thanks for the attention.

Delete the Lootr config file entirely and relaunch.

That worked, thank you.

how to delete lootr config file entirely

Go into the config folder and delete the lootr-client.toml and lootr-common.toml files for Forge, or any other lootr file for Fabric.

thanks


TestFoundation: make test_fileDescriptor more portable

This adjusts the fileDescriptor test to be more portable so that we can
run it on Windows.

@swift-ci test


Reformat/fine-tune docs

This is a follow-up to https://github.com/go-gitea/gitea/pull/13890.
After introducing the new ToC shortcode in https://gitea.com/gitea/theme/commit/2949c6b8cdff80efef4ccde695baa7daede7d71b, the following changes to the docs are required:

In ever page, toc: false. Otherwise the toc will appear twice in the sidebar
Ever page needs to have one h1 and subsequent h2 or h3 headers

In addition I made the following changes:

Added a bold "Table of Contents" line before every instance of {{< toc >}}
Auto-format markdown (including tables)
Fine-tune headers
Add some more ToC instances
Fine-tune markdown highlighting blocks

Codecov Report

Merging #13897 (6783dd8) into master (97ab820) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13897      +/-   ##
==========================================
- Coverage   42.23%   42.14%   -0.09%
==========================================
  Files         709      709
  Lines       77191    77191
==========================================
- Hits        32598    32529      -69
- Misses      39217    39310      +93
+ Partials     5376     5352      -24

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/notification/ui/ui.go
84.72% <0.00%> (-8.34%)
:arrow_down:

models/issue_comment.go
45.46% <0.00%> (-6.80%)
:arrow_down:

modules/notification/mail/mail.go
33.33% <0.00%> (-5.75%)
:arrow_down:

modules/git/commit.go
49.67% <0.00%> (-3.95%)
:arrow_down:

modules/notification/base/null.go
74.28% <0.00%> (-2.86%)
:arrow_down:

modules/notification/notification.go
83.92% <0.00%> (-2.68%)
:arrow_down:

services/mailer/mail.go
60.21% <0.00%> (-1.08%)
:arrow_down:

services/pull/pull.go
40.68% <0.00%> (-0.50%)
:arrow_down:

models/error.go
38.98% <0.00%> (+0.48%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ab820...6783dd8. Read the comment docs.


Event mocking within messaging

I'd like to test following piece of webextension code which registers two event handlers in a background script
import browser from 'webextension-polyfill'

browser.runtime.onConnect.addListener((port: browser.Runtime.Port) => {
  port.onMessage.addListener((message: any) => {
    // do something
    port.postMessage(`reply`)
  })
})

The event handlers are

Listen for connections (e.g. from content script) using browser.runtime.onConnect.addListener
Listen for messages sent (e.g. by content script )using port.onMessage.addListener

I can mock and emit first event using mockzilla-webextension:
import 'mockzilla-webextension'
import { mockEvent, MockzillaEventOf } from 'mockzilla-webextension'

describe('messaging event mocking', () => {
  let addListenerOnConnect: MockzillaEventOf<typeof mockBrowser.runtime>

  beforeEach(() => {
    addListenerOnConnect = mockEvent(mockBrowser.runtime.onConnect)
  })

  describe('function test', () => {
    it('handle received message', () => {
      // call system-under-test
      // ...

      // sent message to be handled by system-under-test
      addListenerOnConnect.emit('message')
    })
  })
})

Reaching the code of the second event handler I get a type error:
TypeError: Cannot read property 'addListener' of undefined`:

  13 |     browser.runtime.onConnect.addListener((port: browser.Runtime.Port) => {
> 14 |       port.onMessage.addListener((message: any) => {
     |                      ^

I'm not able to mock this event using the same technique above. I'd happy about some help. Thanks in advance.

Hi, you have two issues here:
First, the type of the event
    let addListenerOnConnect: MockzillaEventOf<typeof mockBrowser.runtime>; // should be typeof mockBrowser.runtime.onConnect

This causes the type of the event to be (...args: any[]) => void.
I'll have to look into this. Maybe this should be of type never or unknown instead to make typescript complain more.
The second problem is a bit hidden due to the fact, that the first problem is there (once you change the code above, you'll see typescript complain):
// here you should emit the type of event, that your event listener expects.
// I.e. the value you pass must be of type browser.Runtime.Port, not a string like you did here:
addListenerOnConnect.emit('message')

// The mockzilla way would be to provide a deep mock like this:
const [port, mockPort] = deepMock<browser.Runtime.Port>("port");
mockPort.onMessage.addListener.expect(...); // configure your expectations/spies, etc.
addListenerOnConnect.emit(port);

Thanks for clarifying this.
First issue has been solved as suggested.
Second issue I tried as suggested but now I get another problem using deep mock:
test/Messaging.test.ts:40:41 - error TS2503: Cannot find namespace 'browser'.

40       const [port, mockPort] = deepMock<browser.Runtime.Port>("port")
                                           ~~~~~~~

Where do I get the browser object from? And, I'm always confused with lower case browser and upper case Browser -what's the difference, if any? Thank you.

It went better when I changed it to the namespace Browser (upper case) and added following import:
 import Browser from 'webextension-polyfill'

browser is the default export, so you get it like this
import browser, { /* any non-default imports*/ } from "webextension-polyfill";

Browser Is only a namespace, while browser is both a variable and a namespace (Browser).
If you want to use the type, you should be able to use both.. you just need to make sure you imported it. If you want to make things even shorter, you can just import Runtime directly:
import { Runtime } from "webextension-polyfill";

const [port, mockPort] = deepMock<Runtime.Port>("port");

The only reason I used the browser.Runtime.Port version is because you used it yourself:
browser.runtime.onConnect.addListener((port: browser.Runtime.Port) => {...});

FYI: types are already on the definition of addListener, so you can remove the manual type definition without losing the type-safety:
browser.runtime.onConnect.addListener((port) => {...});

Just noticed this:
import Browser from 'webextension-polyfill'

In this case, Browser is variable + namespace version, since you imported the "default export" and named it "Browser".
If you want the namespace version, please import it like this:
import { Browser } from 'webextension-polyfill'

And if you want the variable version, please import it in lowercase to avoid confusion:
import browser from 'webextension-polyfill'

I changed it to
  import browser from 'webextension-polyfill'

  const [port, mockPort] = deepMock<browser.Runtime.Port>('port')

and it works (too). Thanks.

For completeness: my test setup looks now like this where I can emit first a connection request and second a sent message. Both are handled in the system-under-test as listed in my initial post:
    import { deepMock } from 'mockzilla'
    import { mockEvent, MockzillaEventOf } from 'mockzilla-webextension'
    import { Runtime } from 'webextension-polyfill'

    describe('messaging event mocking', () => {
      const [port, mockPort] = deepMock<Runtime.Port>('port')
      let addListenerOnConnect: MockzillaEventOf<typeof mockBrowser.runtime.onConnect>
      let addListenerOnMessage: MockzillaEventOf<typeof mockPort.onMessage>

      beforeEach(() => {
        addListenerOnConnect = mockEvent(mockBrowser.runtime.onConnect)
        addListenerOnMessage = mockEvent(mockPort.onMessage)
      })

      describe('function test', () => {
        it('handle received message', () => {
          // call system-under-test
          // ...

		  // mock port.postMessage()
          mockPort.postMessage.expect('message').andReturn()
		  // connection request to be handled by system-under-test
          addListenerOnConnect.emit(port)
          // sent message to be handled by system-under-test
          addListenerOnMessage.emit('message', port)
        })
      })
    })

Thank you for your quick support.


Add label alignment option to axis label title

Change in action: https://codepen.io/elizzk/pen/PoYBRWX
adresses #6515

@el the build is failing. Please make sure gulp lint works

Is start at top for right scale ok? The numbers (that are not drawn for right axis in master btw!) start from bottom unless reversed.

Is start at top for right scale ok? The numbers (that are not drawn for right axis in master btw!) start from bottom unless reversed.

I wasn't thinking the scale start for start. It is the start of the label. (I didn't want to use left/right/top/bottom)

I think we should consider the start point the same for left or right axes. As @kurkle mentioned, this should respect the reverse setting though for both orientations

I think we should consider the start point the same for left or right axes. As @kurkle mentioned, this should respect the reverse setting though for both orientations

What if all the data is negative? Then the axis start would be the top. Or if the data have negative and positive values, then the start would be changed.

What if all the data is negative? Then the axis start would be the top. Or if the data have negative and positive values, then the start would in the middle.

Start (lowest value) will still be at bottom, unless reverse is set. I'd consider scale start be same as first tick.

Updated codepen with start at bottom on right axis, and reverse support:
https://codepen.io/elizzk/pen/PoYBRWX?editors=1010

So, I have created this page to test all possible variations:
https://codepen.io/elizzk/pen/PoYBRWX?editors=0010
Right now there is an issue with horizontal scales.
I will push an update once I fix them. If you know any other variation that can effect this, please let me know.

Do we need any other changes for this? @kurkle @benmccann @etimberg

I would love if there was an option to put the axis label at the top (if it was Y-axis; like so)


Limit max-lines to  100

Description
ESLint rule, max-lines to 100
Proposed solution
Refactor to files
Alternatives considered
No response
Do you want to create a pull request?
Yes

done


Error when using exposeAll with external

If I do something like the following:
browserify({ debug: true, exposeAll: true })
    .external('_env/messages')
    .add('./src/my/entry.js')

This is because on this line row.deps['_env/messages'] is false, which throws this error:
path.js:146
      throw new TypeError('Arguments to path.resolve must be strings');
      ^
TypeError: Arguments to path.resolve must be strings
    at Object.win32.resolve (path.js:146:13)
    at Object.win32.relative (path.js:270:14)
    at ...\node_modules\browserify\index.js:413:44

If I add if (!row.deps[key]) return; just above the path() call, then the bundle builds without error. I'm not 100% sure that this is the correct fix, so I posted an issue instead of a PR.

@englercj Thanks for the report. I'd say let's sort out the situation with exposeAll in general (e.g. #1293, #1296) and then figure out what to do here.

:+1:


[release-1.25] Bump kine to v0.10.1

Backport  #7410

Verified kine bump on 1.25 branch using go.mod:


build phonegap on cli-6.3.0

** BUILD FAILED **
The following build commands failed:
CompileC build/Salonak.build/Release-iphoneos/Salonak.build/Objects-normal/armv7/PushPlugin.o Salonak/Plugins/com.phonegap.plugins.PushPlugin/PushPlugin.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Anyway that you were able to fix this issue?

I change this plugin with this push plugin https://github.com/phonegap/phonegap-plugin-push


libsigrok: fix c++ bindings

Doxygen and Python are needed as nativeBuildInputs (according to this project's configure).
Add a tiny installCheck for this.

Motivation for this change
pulseview is broken because of missing C++ headers.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

/marvin opt-in
/status needs_reviewer

Result of nixpkgs-review pr 131998 run on x86_64-linux 1

6 packages built:

collectd
collectd-data
libsigrok
libsigrok_0_3
pulseview
sigrok-cli

Result of nixpkgs-review pr 131998 at 6a9f8681 run on aarch64-linux 1

6 packages built successfully:

collectd
collectd-data
libsigrok
libsigrok_0_3
pulseview
sigrok-cli

(woops, actually added the installCheck)

Seems like it still isn't generating?
shrinking RPATHs of ELF executables and libraries in /nix/store/pylj96k51xz7yhsnxk0zwbq6hdrhv12x-libsigrok-0.3.0
shrinking /nix/store/pylj96k51xz7yhsnxk0zwbq6hdrhv12x-libsigrok-0.3.0/lib/libsigrok.so.2.0.0
strip is /nix/store/hy3lz2vfv9qq2v5jz9nzlx6mmiaq79rj-binutils-2.35.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pylj96k51xz7yhsnxk0zwbq6hdrhv12x-libsigrok-0.3.0/lib
patching script interpreter paths in /nix/store/pylj96k51xz7yhsnxk0zwbq6hdrhv12x-libsigrok-0.3.0
checking for references to /build/ in /nix/store/pylj96k51xz7yhsnxk0zwbq6hdrhv12x-libsigrok-0.3.0...
running install tests
C++ bindings were not generated; check configure output

It builds here on tip of master (3473915a71a5b2d2b576742097c5f41b75c60889).
$ nix-build -A libsigrok
/nix/store/l0v89igq1m5idis3hgcxvv1mamvgbprs-libsigrok-0.5.1

Aaaaaargh there's an older one (0.3) without the bindings. I'll fix the check when I get back. Thanks @eadwu!


Warn on large packages/many files

this pertains to the server rewrite
Performance is a big focus in the server and client rewrite and to achieve this we have help authors to help improve our performance.
A big bottleneck is unnecessary large packages from authors not using the ignore field to ignore unneeded files. With a large test suite, fixtures and other junk, this can make the package considerably larger than needed. We should come up with an heuristic that warns authors when they might have forgotten to do their part.
npm has this problem big time. Almost no one uses .npmignore, which makes all packages larger than they would need to.

We also need to better document the benefit of authors using the ignore key.

It has been solver as a warn in bower/bower


V2 Goggle with V01.02.0015 does not work

I have updated my v2 glasses before it became public not to do it, then tested the script, as expected it does not work with V01.02.0015
$ node margerine.js unlock
margerine - brought to you with love by the fpv.wtf team
special thanks to @tmbinc, @bin4ry, @jaanuke and @funnel

hang in there, this is going to take a few minutes

found GP150
waiting for device to reboot
asking nicely
result e3
couldn't do the magic. please read the notes in README.md, restart your device and try again
invalid season ticket

Is it possible to get this work with the new version?

As state in the README, it's not compatible.
DJI changed the way some internal security works and our current exploit chain is now fundamentally broken.
This will require all new vulnerabilities.

I know it's not really the place but is there a way to activate new dji fpv combo without forced firmware upgrade?

Not a known one at the moment, but stay tuned, we plan on looking into it.

Will hold off on activation for time being hopefully there will be a solution. Thanks for all your work!

In case anyone stumbles onto this issue, but not the wiki, we have a guide for activating the DJI FPV Combo kit now: https://github.com/fpv-wtf/margerine/wiki/Activating-the-DJI-FPV-Combo

ok i wait news update thanks

Closing old issue, butter solves this: https://github.com/fpv-wtf/butter


Design and copy for "Back My Stack" banner

We're introducing a new feature on BackYourStack to let users subscribe to a monthly plan.
The MVP of this feature will be available for users uploading their dependency files themselves.
This is the current version in development.

Title: NEW: Automatically Back Your Stack every month
Text: With our monthly plan available from Open Collective, commit a fixed amount every month and the money will be automatically dispatched to your dependencies!
CTA: Back My Stack

[ ] Check copy @piamancini @alanna
[ ] Give design input @raulgrafico @Memo-Es @cuiki

With our monthly plan available from Open Collective, commit a fixed amount every month and the money will be automatically dispatched to your dependencies!

Set up a monthly subscription and we will automatically distribute the funds among your dependencies on Open Collective!

Where are we explaining that we will update as new dependencies come in?

Here: https://github.com/opencollective/opencollective/issues/2319

got it (sorry forgot we did that one already)

@znarf are you ok closing this?
@lindatalu the issues we asked closing are the ones only for design and created by you. Not issues from engineering.


Nested tables are indented too far

E.g. when reformatting the file projectiles/AIFFragmentationSensorShell01/AIFFragmentationSensorShell01_script.lua
the elements of table "local spec" are indented twice as far as they should be:
AIFFragmentationSensorShell01 = Class(AArtilleryFragmentationSensorShellProjectile)({
    OnImpact = function(self, TargetType, TargetEntity)
        ...
        local spec = {
                    X = pos[1],
                    Z = pos[3],
                    Radius = self.Data.Radius,
                    LifeTime = self.Data.Lifetime,
                    Army = self.Data.Army,
                    Omni = false,
                    WaterVision = false,
        }
        ...
    end,
})

Seems to be the same bug as with functions I fixed earlier. Once I find the bug, search for the pattern and fix it in the rest of the LuaOutputVisitor as well.

Fixed in eeb9d00d3ce83e227156d13a636d3558007e3261


corrigido os problemas de layout da view dashboard

Codecov Report

Merging #35 (482bafa) into main (ce571f3) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   70.71%   70.62%   -0.10%
==========================================
  Files          21       21
  Lines         782      783       +1
==========================================
  Hits          553      553
- Misses        229      230       +1

Impacted Files
Coverage Δ

controle_contas/ext/site/forms.py
100.00% <ø> (ø)

controle_contas/ext/site/views.py
33.50% <0.00%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce571f3...482bafa. Read the comment docs.


could give me some help?

 Could you give me some help?.
my steps are as follows:
1.git clone .........
2.bash install.sh
3.bash run.sh cpu msl
then error is coming

And In your paper, how do you get the embedding vector of the sensor?
Thanks your for help

And in your code ,the marked function '(get_graph_struc()' i haven't found it

Hi,

I am not quite sure how this error occurs, but I have found an issue related to your problem. Maybe it could help: https://github.com/pyg-team/pytorch_geometric/issues/1146 .
The embedding vectors of sensors are used in the Eq. (6) and (9), and later optimized with the Mean Squared Error.
The missing function here won't matter in the program. The function was previously used in some other trial experiments and I have removed it as it is not necessary for the current program.

Thank you very much for your reply.

I think the commands are fine. Yes, I can. But if possible, let's text in English so that it could also be helpful for the others with the similar issues.
Thanks!

Ok, thank you for your reply.

Closing. Feel free to reopen if there is any further question.


Image Blobs Don't Render when Loaded From Data

Describe the bug
When image blobs are referenced in data, like:
<img alt="Alternative Text: Red Image" xlink:href="content/900#properties.data"/>

They are not display anymore since CKEditor Plugins Release 5.0.0. In example data (for example "Various Images" you will see a broken image instead)
To Reproduce
Steps to reproduce the behavior:

Open Example Application
Select "Various Images" from example data.

Expected Behavior
The image is loaded from service and displayed within CKEditor.
Actual Behavior
The image is shown as a broken image with "HTML object" tag rendered on top.
Environment (please complete the following information):

OS: iOS, Windows
Browser: Chrome, Firefox
CKEditor Version: 34.0.0
CoreMedia's CKEditor Plugins Version: 5.0.0

Additional context

Data-Processing correctly applies a dummy image (required, as blob data are retrieved lazily from backend).

Image in Model is represented as:
<htmlImg
  htmlAttributes="{attributes:{alt:"Alternative Text: Red Image", "data-xlink-href": "content/900#properties.data"}}"
  htmlContent="">
</htmlImg>

Thus, it is the GHS Plugin which kicks in here, and handles an unknown "img" element.

Expectation is, that it is related to recent CKEditor Update, introduced with:

#64

As analyzed by @JensDallmann, the issue had been caused by CKEditor Update from 32.0.0 to 34.x.
We provided a workaround for:

ckeditor/ckeditor5#11327

which worked for CKEditor 32.0.0. It collided though, with recent changes due to:

ckeditor/ckeditor5#11530

To address this issue as part of:

#67

we extended the workaround by explicitly removing the src attribute. This is part of CKEditor update to 34.1.0 branch, as we hoped that an update to 34.1.0 from 34.0.0 would have fixed the issue.


feat(text-input):  [iOS] inputAccessoryViewButtonLabel prop

Summary:
Fixes #29244, also mentioned in #25009
As mentioned in the linked issues, the current return key label in the input accessory view is not localized. In the code, right now the texts are hardcoded (see: RCTTextInputComponentView.mm and RCTBaseTextInputView.mm). I could not find the historical reason for this, but doing some investigation there doesn't seem to be a way of getting the translated text into the code by using the existing props. (Ref: https://stackoverflow.com/a/58190342/5415299)
The solution: adding a new property inputAccessoryViewButtonLabel which can be used to overwrite these defaults non-translated values. The property is optional to avoid breaking changes.
The implementation works for both Fabric and Paper.
Changelog:
[IOS] [ADDED] - TextInput inputAccessoryViewButtonLabel prop
Test Plan:
A new example has been added under the TextInput examples in the RNTester. See below:

Video demonstrating how the new prop behaves
https://github.com/user-attachments/assets/b15cb8b8-494a-4f41-b434-e33eeef5d267

Hi mateoguzmana, does this gonna also fix the label for cancel button?

Hi mateoguzmana, does this gonna also fix the label for cancel button?

@BatDroid yes, you will be able to provide your own localised label :)

Hi mateoguzmana, does this gonna also fix the label for cancel button?

@BatDroid yes, you will be able to provide your own localised label :)

Mostly what I meant was the fact that if the keyboardType="number-pad" then there'll be also a cancel button in the left along with Done button.


[WIP] new v6 strategy

TODO

add test of multiple AMMs
add test of mixing with RFQ

replaced by #210


your latest update broke heavy rainfall in act 1, at least in my mod..

The rain looks like long crazy spazzy lines (im using 1280 x 720 resolution on 1.13c).

Pd2 but an old season, all I know is it is fine in the version just before this one.
Will provide log later
On 30 Jan 2024, at 18:22, Jason Newcomb @.***> wrote:

This needs more information. Log file? Image/video of "long crazy spazzy lines"? What mods are used?
—
Reply to this email directly, view it on GitHubhttps://github.com/Jarcho/d2-rs/issues/2#issuecomment-1917637305, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APZRWP5BERLLX5ROCOKOJ6DYRE3ABAVCNFSM6AAAAABCRVIMAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGYZTOMZQGU.
You are receiving this because you authored the thread.Message ID: @.***>

I happened once.It's not easy to repeat

me too

I think I know what caused that. Can you test this version and let me know?

Have been unable to replicate after 2 hours of play, but I'll let you know over the next day or so to make sure. Thank you :)

Still unable to repro, seems to have fixed it.


Fix: Add platform detection for Apple m1 chips

Added a mapping from 'aarch64' architecture to{:arm, :darwin}. This works because the Apple M1 chip works with the macos-arm64 binaries.
I have tested it on my m1 and this works as expected.

Thank you @Sgoettschkes!


Refactor atleast_nd

~Supports numpy.ndarray in atleast_<n>d.~
Also done some refactoring.

I changed the topic of this PR to simply refactoring.

LGTM!


Lambda context

Is it possible to access the Lambda context from the request?
Looks like the current context header is being set from the event payload vs. from the actual Lambda context: https://github.com/awslabs/aws-lambda-web-adapter/blob/main/src/lib.rs#L332
Specifically, I need to access the requestId from that context (i.e. this https://docs.rs/lambda_http/latest/lambda_http/struct.Context.html), since I am invoking Lambda directly (constructing an event payload that is conformant with ALB or API-GW formats) where I do not have access the the actual Lambda request ID.
Related somewhat to https://github.com/awslabs/aws-lambda-web-adapter/issues/216 since this ultimately stems from calling Lambda running the LWA that are not truly from a web request.

Yes, the request context header is not the same as Lambda context. To pass the values to the web app, we probably need to use another header like "x-amzn-lambda-context".


https://spdx.org/licenses/ in terminal of vscode opens link https://spdx.org/licenses/>

VSCode Version: 1.44.0
OS Version: Version: Kubuntu 20.04 (Linux x64 5.4.0-21-generic)

In terminal of vscode URL with /> on end opens URL as />, it shouldn't happen.
On example if in terminal is https://spdx.org/licenses/ and when I click on URL with ctrl it will open https://spdx.org/licenses/> in browser.
Does this issue occur when all extensions are disabled?: Yes

/duplicate #21125


fix(popover): Using native popover-api

✅ Closes: COMUI-1637
Do we want to also use the popover-api for the popover-list component?
Update: I am closing this PR since I opened this new PR to handle creating a new popover-beta component: https://github.com/MyPureCloud/genesys-spark/pull/642

@jason-evans-genesys can this branch be deleted?

@jason-evans-genesys can this branch be deleted?

@daragh-king-genesys Yes, I will delete it.


Types - JSON Endpoint function, only allow valid JSON types

Describe the problem
Currently, the JSON endpoint function takes any as a type

The any type includes types such as Date, Map and functions which can't be represented in JSON.
For example, let's say you had this
return json({
    test: new Date()
})

after serialization, this would for example be
{
    "test": "2022-08-30T16:55:12.151Z"
}

Meaning the JSON type and the JavaScript type don't match
Describe the proposed solution
The json function could use JsonValue as a type for data.
This would lead to an error for types such as dates and force the developer to manually convert the type if desired
Alternatives considered

Continue using any.
This would make it easier to use dates and so on as these are automatically serialized
Automatically convert JSON back to original types when using fetch or some alternative. I like this idea, but there should be an alternate function for this

Importance
nice to have
Additional Information
No response

I'm not sure I like preventing users passing arbitrary data -- sometimes I'm totally OK with my dates being serialized just how they are, and I want the toJSON functions on my classes to be able to handle their serialization for me. I think a better solution would be just to change the function to accept the standard JSON.stringify replacer argument. Users who need that kind of custom serialization can then just:
const resp = await fetch('foo.com');
const text = await resp.text();
const json = await JSON.parse(text, reviver);

This seems more in-line with the standard JavaScript API.

If you need that level of control over the serialization, I think it's reasonable to do this...
return new Response(JSON.stringify(data, replacer), {
  headers: {
    'content-type': 'application/json'
  }
});

...rather than adding a third argument to the json helper.

We used to have a JSONValue type that was useful for this sort of thing, but it couldn't tolerate interfaces, only types. It caused more trouble than it was worth so we removed it.

going to close this as i don't think there's anything it makes sense for the framework to do differently


Add toc to module and class

I've noticed that with this changes in the TOC are included submodules and classes, but not functions.

@frazane Could you please provide a specific example?

@frazane I understand the situation. I will fix it.

You're doing great work here, I really appreciate it. Thanks!


fix uploading files via ajax in Safari 11

before form submission, clone form and remove empty file inputs as these causes Safari 11 to stall
https://stackoverflow.com/questions/49672992/ajax-request-fails-when-sending-formdata-including-empty-file-input-in-safari

I was just investigating the issue with 503 response when submitting ajax form in Safari. I just tested it and it works like a charm 🙏


Slow input typing if dragglable is true

Hi,
There is one problem if you insert an input field inside get view() and type something
https://codesandbox.io/s/qvn50vv964
(click youtube video and type in the field)
This problem dont occurs with draggable false
Seemsn this happens cause the editor need to update.

@philippkuehn What exactly does this part of the code? https://github.com/scrumpy/tiptap/blob/0e59e0cc0c2b4f0be5c46ebf2a698c674bfda821/packages/tiptap/src/Utils/ComponentView.js#L103-L107
Because if it returns false the component no longer gets destroyed on each prop change.
Maybe implement a check like this?
  // prevent a full re-render of the vue component on update
  // we'll handle prop updates in `update()`
  ignoreMutation() {
    return !(this.editable && this.extension.schema.draggable)
  }

I'm not sure what's the difference between your sandbox and this embed example. Even if I set draggable to true, the demo works without the described problem 🤔
@Chrissi2812 It's not a good idea to change the behavior of ignoreMutation. By default ProseMirror re-renders a node view whenever an attribute changes. In some situations this makes it impossible to use tooltips or fade-in transitions for example.

In the newer versions with "stopEvent()" is possible to control this behavior.
https://codesandbox.io/s/qvn50vv964 (see components/iframe.js)
Thanks   @philippkuehn, amazing job!

Can confirm that with 1.17.0 this works without much problems.
Even without stopEvent as mentioned by @lucastsudaka.
The only thing I have noticed is that as soon as you press backspace the embed gets deleted. @keydown.stop on the input element prevents this behaviour.

Please reopen if this issue is still present.


fix sfpi-rel to not use LFS

build w/ a release tarball

sfpi is now released via tarballs, tt-metal uses the new mechanism.
There is at least one other repo (budabackend) still uses the old mechanism

@ubcheema @TTDRosen do we still house the erisc main in budabackend?

Declaring victory, We can track the budabackend issue separately,


Предлагаю сделать разделение файлов block для удобства

I propose to separate block files for convenience. To divide large code into blocks from one space into several more. So for example is done with ts files. And additional functionality so that you can switch between block files.

Translation of the issue headline: I propose to make the division of block files for convenience

Translation of the issue headline: I propose to make the division of block files for convenience

I'm sorry, I messed something up when I created it)


Testing workspace package with features expects the root package to have those features

Consider this project structure:
foo
├── bar
│   ├── Cargo.toml
│   └── src
│       └── lib.rs
├── Cargo.toml
└── src
    └── lib.rs

If I add a feature to foo/bar/Cargo.toml called whatever and I run
cargo test -p bar --features whatever

I get
error: Package `foo v0.1.0 (file://[...]/foo)` does not have these features: `whatever`

Ah yes currently Cargo interprets --features as applying to the "target" crate of the --manifest-path or current directory arguments. Right now there's no way to activate selective features in selected crates transitively, unfortunately.

Do feature flags get passed down to sub-crates in a workspace?

No, unless you depend on that feature from your main crate.

Oops, I had deleted my comment shortly after I posted, to give some context to torkleyy's comment, I had asked if --features flags got passed down to dependencies.


Empty interface allow any object?

I posted question on SO but haven't received definite answer so I assume this might be a bug.
Why empty interface doesn't require object to be empty?
interface A {};
const a: A = {a: 1};
console.log(a);

is valid code and will output { a: 1 }.
I would assume that adding optional property should work fine, but
interface A {};
interface B extends A {
	b?: any;
}
const a: B = {a: 1};
console.log(a);

ends with error Type '{ a: number; }' is not assignable to type 'B'.

If interface define what properties object must have, B case should work fine, all required properties are present.
If interface define what properties object can have, A case should result in error, a is not defined in interface.

Non empty interface defines both what object can and must have.
Empty interface behaves like any.
Is there explanation why empty interface behaves like this? Is this intentional or it's just a bug?
Expected behavior:
interface A {};
const a: A = {a: 1};
console.log(a);

error Type '{ a: number; }' is not assignable to type 'A'.

Actual behavior:
interface A {};
const a: A = {a: 1};
console.log(a);

{ a: 1 }

In general, subtyping permits an object to have additional properties in an assignment. However, in the specific case of an object literal source object and a non-empty target type, TypeScript disallows excess properties in the object literal as an added safeguard. See #3823 for the rationale. The excess property check is not performed when the target is an empty object type since it is rarely the intent to only allow empty objects in that case.

Actually this is quite inconsistent
interface A {};
const a: A = {a: 3};
console.log(a.a)

gives

(3,15): Property 'a' does not exist on type 'A'.

interface A {};
const a: A = 1;
console.log(a + 1)

results in

(3,13): Operator '+' cannot be applied to types 'A' and '1'.

No.1 is kinda expected
No.2 IMHO should end with

(2,7): Type '1' is not assignable to type 'A'.

since A is object type
Bug, quirk or feature?

"Type '1' is not assignable to type 'A'." is the completely wrong error. Assignability is not used to check the + operator, nor is it the correct thing to do. For example, { } + { } is invalid even though the operands have identical type.

What is my concern
No. 1 - I can put anything in, but take nothing out - blackhole type
No. 2 - attempt to assign number to object type (line 2) should result in error

@mleko

No. 1 - I can put anything in, but take nothing out - blackhole type

Right but that is what an explicit type annotation on an initialized binding does, it blocks type inference, overriding the inferred type with that of the annotation. Out of curiosity, why are you placing a type annotation on a binding that has an initializer? TypeScript's type inference is amazing, take advantage of it.
// works perfectly and is 100% well typed
const a = {a: 3};
console.log(a.a);

@aluanhaddad
I define configurations for several environments. Explicit variable type ensures there are no misspelled properties, as all configurations share same interface.

Well you would get a type error at the use site if there was a misspelled property but that aside, the well specified interface is certainly valuable, in which case you'll need to declare all the properties it holds and then will be no type errors.


Notify if server is not active

Codecov Report

Merging #68 (0973bc9) into master (204ab4a) will decrease coverage by 2.66%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   95.28%   92.63%   -2.66%
==========================================
  Files          14       14
  Lines         276      285       +9
  Branches       36       40       +4
==========================================
+ Hits          263      264       +1
- Misses         11       19       +8
  Partials        2        2

Impacted Files
Coverage Δ

src/Xray/XraySystemClient.ts
100.00% <ø> (ø)

src/HttpClient.ts
83.33% <11.11%> (-16.67%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Refactor dispatching logic of LoRA layers

This PR's goal is to simplify the logic for deciding which LoRA layer backend is being used when LoRA is applied to a target layer.
Originally, this refactor was done in #1286 which was about adding the "fast" backend for LoRA, but since that PR was closed, I moved the refactor to this dedicated PR.
Motivation
Right, now, the LoraModel._create_new_module method has become quite complex and hard to read, spanning >100 lines:
https://github.com/huggingface/peft/blob/8665e2b5719faa4e4b91749ddec09442927b53e0/src/peft/tuners/lora/model.py#L235-L339
The reason for this is that method contains the logic for deciding which LoRA layer backend to use for all the different types of LoRA layers that we have, i.e. normal Linear layer, Conv2d layer, bnb layer, gptq, etc.
This PR greatly simplifies this method (30 LOC) and should make it easier to prevent bugs. It should also simplify adding further backends in the future.
Description
I moved the logic for deciding which layer to match to the respective implementation of the layers. For example, in lora/layer.py, there is now a function called dispatch_default, whose responsibility it is to decide if an Embedding layer, Conv2d layer or Linear layer is the right match. Similarly, in lora/bnb.py, there are now the two functions dispatch_bnb_8bit and dispatch_bnb_4bit to decide what/if any bnb 8bit or 4bit layer should be matched. Same for the gptq and the megatron backend.
This way, the logic to decide what layer to match now resides next to the respective layers. The only thing that LoraModel now needs to do is to collect all the dispatching methods and use the first layer that matches.
Note that the logic to decide if a layer matches is 100% the same, just moved to a different place. Therefore, there should be no difference in the LoRA model being created.
Only LoRA was modified because the other tuners don't have different backends and thus this approach was not necessary for them. The only exception is IA³, which has normal and bnb backend. Since those are only two, it's not as complicated as for LoRA, but if this PR is accepted, I can refactor IA³ in a similar fashion.
Other changes

Removed the optional_kwargs argument from _create_and_replace, as it was an unnecessary indirection.
Removed the bias argument from kwargs, as it was not used.

Backwards compatibility
This should be fully backwards compatible, as the constructed LoRA model is 100% the same. If there are users that override _create_new_module, their code will probably break, but since this is a private method, we should be fine.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


How do I install the nightly version of surrealdb.js?

I need the latest from master.

We don't release nightly versions of this library, you could however make a patch with yarn/pnpm patch and get the latest changes in there? Far from optimal and I'd definitely not advice to do this but it's a possibility


Multiple labels for same image polygon

Hi,
Apologies if this feature is already present (I have not been unable to find it).
I am working on a (pet) project for classification and instance segmentation of vehicles. So I am going to use image polygon feature of label-studio. For that

I need broader classification like car, truck, scooter, bus, etc.
More specific classification (e.g. in cars, their make) like Ford, Toyota, BMW etc.
More specific classification (e.g. in cars, their models)
More specific classification (e.g. in cars, their colours)

For the above, if a polygon can be given multiple labels, I will be able top write data generator for different classifications.
Thanks
Vijay

And my coffee kicked in and I found the solution!!!
I can achieve it by repeating "PolygonLabels" element in the configuration.

@vijaygill Hey, thanks for this ticket. To follow-up, as you've already discovered, there is Choices tag with multiple Choice children. In a future version, we will be integrating a more powerful taxonomy to define multi-level relationships.

@vijaygill Hey, thanks for this ticket. To follow-up, as you've already discovered, there is Choices tag with multiple Choice children. In a future version, we will be integrating a more powerful taxonomy to define multi-level relationships.

This fantastic!!!! I am looking for multi-level relationships but I found label-studio to be extremely easy to use so I was thinking of creating my own process of applying hierarchy using another my own code. But now it seems I can wait and have this facility as first-class citizen in label studio!


Feat/kleros dapp

PR-Codex overview
This PR focuses on restructuring the kleros-app codebase by removing several utility files, updating dependencies, and enhancing the AtlasProvider. It also introduces new functionalities for user management and email handling while improving the overall application structure.
Detailed summary

Deleted several utility files in web/src/utils/atlas.
Updated prettier version in prettier-config/package.json.
Added new isUndefined utility function in kleros-app/src/utils/index.ts.
Introduced a new HTML structure in kleros-app/src/index.html.
Created a new App component in kleros-app/src/App.tsx.
Implemented useSessionStorage hook in kleros-app/src/lib/atlas/hooks/useSessionStorage.ts.
Added GraphQL functions for user management: getNonce, fetchUser, addUser, updateEmail, and loginUser.
Enhanced createMessage to accept an optional statement parameter.
Updated uploadToIpfs to include Products and Roles enums.
Improved AtlasProvider to manage user sessions and interactions with GraphQL.
Refactored AtlasProvider to use a new configuration structure.
Enhanced error handling and user feedback with toast notifications across various components.

The following files were skipped due to too many changes: yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features

Introduced a new React component App as the entry point for the application.
Added a custom hook useSessionStorage for managing state synchronized with session storage.
Implemented a new context provider AtlasProvider for user authentication and interactions with the Atlas service.
Added various GraphQL mutations for user management, including addUser, loginUser, and updateEmail.

Enhancements

Improved user feedback with toast notifications for actions like email updates and user sign-ins.
Streamlined the EnsureAuth and EmailVerificationInfo components to provide better user interaction.

Bug Fixes

Enhanced error handling across multiple components to improve reliability during user interactions.

Chores

Updated various configuration files, including .gitignore and tsconfig.json, for better development experience.

Closing as too many conflicts in yarn.lock making it dirty. Migrated changes to #1756 on latest dev branch