Interpolation problems on tight turns

I had problems on a file, did some testing and figured out that the problems appear on the section with the tight ~180° turn (green)

Here are the 2 gpx tracks for blue and green
10.zip
While the blue track has no problem to interpolate, the green one gives some errors.
I tested it on about 4-5 turns from this file and its repeatable.
(It is not an issue for myself, but as I spent 3 hours looking why my file isnt working, maybe its helpful to you or others ;-) )

This is caused by duplicate trackpoints at the same location, fixed in the last commit.


Add property "description" to common options

Added a property "description" to components.
https://www.dropbox.com/s/qdkahwaoyt9ljuo/Screenshot 2017-01-10 13.04.32.png?dl=0

Also added a solution to this issue: https://github.com/formio/ngFormBuilder/issues/212

I ended up bringing in the Description stuff into the next build, but left out the isConfigurable due to the risk. Please create a separate PR that includes just this capability.
Thanks!


Need support to integrate fine uploader from vb6

I have already done all the steps to generate policy document and vb6 code to solve the problem but getting Error attempting to parse signature response: SyntaxError: Unexpected token s.
What to look and where to ask. I am in the final stage of implementation and buying your product but not getting any useful help from any where to finish my demo part.
If possible kindly reply over this :
http://stackoverflow.com/questions/34046983/fine-uploader-request-not-working-from-vb6

Dbeg are you going to help me out???????????

Please be patient. Your question has been answered.


Data type macros

See https://github.com/dbt-labs/dbt-core/pull/5428

It looks like we infer/load numeric columns with decimals as bigint on Spark, instead of int:
https://github.com/dbt-labs/dbt-spark/blob/48e1989888bc1a858d58d93344fe777d7bca887c/dbt/adapters/spark/impl.py#L92-L95
I'm not sure what's up with the perceived mismatch in TestTypeFloat. Investigating


docs: fix MethodSettings CloudFormation link

Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:

[ ] Write/update tests
[ ] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1027 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1027   +/-   ##
========================================
  Coverage    94.81%   94.81%
========================================
  Files           69       69
  Lines         3240     3240
  Branches       631      631
========================================
  Hits          3072     3072
  Misses          87       87
  Partials        81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd05bab...8b965f0. Read the comment docs.


openid authentification not working

When trying to connect to a Zulip server authenticating via an OpenID Connect service, the user is not forwarded to the service's login page. Instead just the server name and logo is shown in the the login screen. Consequently a log in to this server is impossible. In the browser and in the desktop app everything is working as expected.

I can reproduce this problem and managed to narrow it down:
The Zulip mobile client calls /api/v1/server_settings? The server responds as follows:
{
	"require_email_format_usernames": true,
	"zulip_version": "1.7.1",
	"authentication_methods": {
		"github": false,
		"dev": false,
		"ldap": false,
		"password": false,
		"google": false,
		"email": false
	},
	"realm_uri": "https:\/\/my.realm.org",
	"msg": "",
	"realm_name": "MyRealm",
	"result": "success",
	"email_auth_enabled": false,
	"realm_description": "<p>The coolest place in the universe.<\/p>",
	"realm_icon": "\/user_avatars\/2\/realm\/icon.png?version=2"
}

Note that authentication_methods are all false -- even though Web UI shows RemoteUser as enabled and settings.py shows
AUTHENTICATION_BACKENDS = (
    # 'zproject.backends.EmailAuthBackend',  # Email and password; just requires SMTP setup
    # 'zproject.backends.GoogleMobileOauth2Backend',  # Google Apps, setup below
    # 'zproject.backends.GitHubAuthBackend',  # GitHub auth, setup below
    # 'zproject.backends.ZulipLDAPAuthBackend',  # LDAP, setup below
    'zproject.backends.ZulipRemoteUserBackend',  # Local SSO, setup docs on readthedocs
)

Understandably, the Android client does not know what to do. The server implementing OpenID (Apache on port 8888 as intended by Zulip's documentation is never even contacted.
This might not even be a problem with OpenID. Has anyone ever managed to get the Android client with RemoteUser backend?

The problem here is that the RemoteUserBackend doesn't support the mobile app; changes are needed server-side to allow this.  I'm going to read a bit of code to estimate the work involved, since obviously this should be supported and I'd like to see it resolved quickly.

I opened https://github.com/zulip/zulip/issues/8291 for the issue on the backend.
@borisyankov I suspect we'll need to make some changes to the app as well; to support that, I guess I'll plan to quickly setup a small test server using the code resolving #8291 that you can test against.  Basically, if REMOTE_USER_BACKEND is enabled (which we can add to the /server_settings response), we'll need to do a redirect to /accounts/login/sso?mobile_flow_otp=<OTP> (and otherwise the flow should work like Google and GitHub).  We still need to add the backend support for this, but I think it should be simple.

The answer seems to be that this is very little work.  I've opened https://github.com/zulip/zulip/pull/8294.  I'll deploy that on a fresh VM (should be a good opportunity for me to QA the new installer), setup REMOTE_USER_BACKEND, and then give @borisyankov the details so that we can verify the mobile side implementations.

This was just merged on the backend via https://github.com/zulip/zulip/pull/8294 and here via #1962.
Before we close this, I want to add a note on how we could make it significantly better.
@borisyankov, for SSO login, the way it works on the backend is that it'll be the only supported auth backend for the server; as a result, probably what should happen is that when you submit the "what's your Zulip server" form, we should immediately open the webview, rather than making the user click "Login with SSO".  That's how the SSO integration works on the web for most folks using it, and so it'll both match user expectations and also save an unnecessary step.  If this is easy, we should just do it now; if not, we should make a new issue for just that enhancement when we close this.

Yeah, that is exactly what I intended to do 👍
If there is only one auth option (weather SSO or some other) the login will go directly into that step.

Implemented.


brew install ffmpeg, on raspberry pi 2    "Error: undefined method 'split' for nil:NilClass"

brew install ffmpeg
seemed to run fine until
Error: undefined method 'split' for nil:NilClass
==> Downloading https://ffmpeg.org/releases/ffmpeg-2.8.tar.bz2
Already downloaded: /home/pi/.cache/Homebrew/ffmpeg-2.8.tar.bz2
Please report this bug:
(Ok i had to run brew install ffmpeg > bug.txt to capture the error, hence above message of Already downloaded)
https://github.com/Homebrew/linuxbrew/blob/master/share/doc/homebrew/Troubleshooting.md#troubleshooting
/home/pi/.linuxbrew/Library/Homebrew/os/linux/hardware.rb:53:in flags' /home/pi/.linuxbrew/Library/Homebrew/os/linux/hardware.rb:63:in block (2 levels) in module:LinuxCPUs'
/home/pi/.linuxbrew/Library/Homebrew/compat/hardware.rb:6:in is_32_bit?' /home/pi/.linuxbrew/Library/Formula/ffmpeg.rb:147:in install'
/home/pi/.linuxbrew/Library/Homebrew/build.rb:129:in block in install' /home/pi/.linuxbrew/Library/Homebrew/formula.rb:848:in block in brew'
/home/pi/.linuxbrew/Library/Homebrew/formula.rb:1389:in block in stage' /home/pi/.linuxbrew/Library/Homebrew/resource.rb:91:in block in unpack'
/home/pi/.linuxbrew/Library/Homebrew/extend/fileutils.rb:17:in mktemp' /home/pi/.linuxbrew/Library/Homebrew/resource.rb:88:in unpack'
/home/pi/.linuxbrew/Library/Homebrew/resource.rb:81:in stage' /home/pi/.linuxbrew/Library/Homebrew/formula.rb:1381:in stage'
/home/pi/.linuxbrew/Library/Homebrew/formula.rb:844:in brew' /home/pi/.linuxbrew/Library/Homebrew/build.rb:107:in install'
/home/pi/.linuxbrew/Library/Homebrew/build.rb:176:in `'
Version of raspbian....from /proc/version
Linux version 4.1.7-v7+ (dc4@dc4-XPS13-9333) (gcc version 4.8.3 20140303 (prerelease) (crosstool-NG linaro-1.13.1+bzr2650 - Linaro GCC 2014.03) ) #817 SMP PREEMPT Sat Sep 19 15:32:00 BST 2015
brand new install of os and linuxbrew
yes i did a brew update, doctor etc

ps here is the brew config from the above report
HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/Homebrew/linuxbrew
HEAD: 844ddc06f2b966d0a202f1f0ec7db35f9bc391e2
Last commit: 19 hours ago
HOMEBREW_PREFIX: /home/pi/.linuxbrew
HOMEBREW_REPOSITORY: /home/pi/.linuxbrew
HOMEBREW_CELLAR: /home/pi/.linuxbrew/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://linuxbrew.bintray.com
Please report this bug:
https://github.com/Homebrew/linuxbrew/blob/master/share/doc/homebrew/Troubleshooting.md#troubleshooting
/home/pi/.linuxbrew/Library/Homebrew/os/linux/hardware.rb:53:in flags' /home/pi/.linuxbrew/Library/Homebrew/os/linux/hardware.rb:63:in block (2 levels) in module:LinuxCPUs'
/home/pi/.linuxbrew/Library/Homebrew/os/linux/hardware.rb:68:in bits' /home/pi/.linuxbrew/Library/Homebrew/cmd/config.rb:101:in hardware'
/home/pi/.linuxbrew/Library/Homebrew/cmd/config.rb:152:in dump_verbose_config' /home/pi/.linuxbrew/Library/Homebrew/cmd/config.rb:7:in config'
/home/pi/.linuxbrew/Library/brew.rb:133:in `'

I think i found the problem
https://github.com/Homebrew/linuxbrew#dependencies
clearly says
Ruby 1.8.6 or newer
GCC 4.2 or newer
64-bit x86 platform
and the raspberry pi is arm 32 bit
hope there is a 32 bit version of linuxbrew, will looks around

this issue seems to be related to #563

I sorted this one out as follows:
modify the hardware.rb file as indicated on https://github

Sorted this one out as follows:
uninstall linuxbrew
then
git clone https://github.com/Homebrew/linuxbrew.git ~/.linuxbrew
cd ~/.linuxbrew/Library/Homebrew/os/linux
edit the hardware.rb file at line 53 as follows
def flags
#@flags ||= cpuinfo[/^flags./, 0].split
@flags ||= cpuinfo[/^(flags|Features)./, 0].split
end
see https://github.com/Homebrew/linuxbrew/issues/563
the brew install ffmpeg
... and it works
... not bad for a newbie noob

Duplicate of #518

I'm glad to hear that you got it working!

re patch for ARM7 (sjackman patch to hardware.rb file)
i installed linuxbrew using the git clone https://github.com/Homebrew/linuxbrew.git ~/.linuxbrew
as opposed to the
ruby-e "$(curl -fsSL.........
just for divilment, i'll uninstall linuxbrew and then re-install with ruby, modify the hardware.rb and then see if i can brew doctor, brew update etc
i edited the hardware.rb file and halleuja it does build sucessfully,.... except i can no longer brew update.
I think this may be a git issue, because i cloned, modified (hardware.rb) and now it wants to upload my modifications
not sure, 'cos i don't know the ins and outs of GIT, but i know if i stash, save and clean it seems to revert my hardware.rb to the unmodified version
Below are the details
pi@novisad ~ $ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!
Warning: You have uncommitted modifications to Homebrew
If this a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
cd /home/pi/.linuxbrew/Library && git stash && git clean -d -f
Warning: Your Homebrew is outdated.
You haven't updated for at least 24 hours. This is a long time in brewland!
To update Homebrew, run brew update.
pi@novisad ~ $ brew update
Stashing your changes:
M Library/Homebrew/os/linux/hardware.rb
*** Please tell me who you are.
Run
git config --global user.email<EMAIL_ADDRESS>git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <pi@novisad.(none)>) not allowed
Cannot save the current index state
Error: Failure while executing: git stash save --include-untracked --quiet
pi@novisad ~ $


no messages after getFolder() vs getFolders()

I am using Exchange 2013 with activated IMAP access. The connection is valid. I can access the mailbox with thunderbird and outlook.
I try to access the mailbox using php with this module. If i have opened the folder directly, I do not receive any message. If I have retrieved all folders and use the folder-object inside a loop, it works.
`
// At this point I have a VALID connection (client)
$mailbox = 'INBOX';
// Try #1:
$folder = $client->getFolder($mailbox);
$messages = $folder->messages()->limit(100)->get();
// Output: NO MESSAGES
$folders = $client->getFolders(false);
foreach ($folders as $folder) {
if ($folder->path == $mailbox) {
$messages = $folder->messages()->limit(100)->get();
break;
}
// Output:: 100 MESSAGES
`

Hi @iwen65 ,
have you tried to use different parameters?
Client::getFolder($folder_name, $attributes = 32, $delimiter = null, $prefix_address = true)

This function is completely experimental, caused by the fact that I have no clue what $attributes does. I only figured out that the number 32 seems to work in my case :) So feel free to poke arround and please let me know if you know more about this number.
Best regards


Add functionality for adding uni modules

Functionality for adding modules is a good step before moving to working on the algorithm for calculating the degree grade/classification.

@AndrewMcGuckin
I've made a separate issue for removing modules (#30) as functionality for adding will take slightly longer than removing and could be done independently.


Update Docker page with Kuiper 0.3.0 release

The deploy/docker/README.md was updated, we need to update home page of https://github.com/emqx/kuiper/runs/532241669?check_suite_focus=true accordingly.

Done & close the issue.


Add SSTP Protocol Support for LUCI

This PR is based on an older PR that can be seen here https://github.com/openwrt/luci/pull/261 (Commit: https://github.com/openwrt/luci/commit/3854b5ac2647a90839f075b8c8af4a4ea33bdf89)
PLEASE NOTE: In order for this to work the sstp-client needs to have the netifd sstp.sh file added. In other words, this PR depends on https://github.com/openwrt/packages/pull/9221 PR to be completed and won't work without it.

Please stash  / fixup the commits into the first one so we have only on commit.
And please add a new line on the button on some files. They are marked in github

Hi @feckert, I rebased my commits into a single one, but I cannot do the same for the Merge commit as it seems that some commits have some untracked files in them (And appear as Signed off by me after the rebase) and other merge conflicts that surface during rebasing.
Can you @feckert or anybody else suggest how to properly perform the rebase?

Sorry I would merge this changes but the whole pullrequest is broken.
And it is not easy to solve this.
The new luci-proto handler looks good to me. :+1:
Please open a new pullrequest with your changes.
And reference this one for the new fixed follow up pullrequest.
Thanks.


Add integration with DataForSEO SERP API

This Pull Request proposes the integration of the DataForSEO API Wrapper into the LangchainJS project, a direct response to the growing demand from our customers. Our API is significantly more cost-effective compared to SerpApi (similar product already integrated with Langchain), while also providing a wider range of functionalities and opportunities for software developers.
We've aimed to maintain a simple programmatic interface, while also providing features that could be useful for specific tasks such as searching Google Maps, summarizing product ratings, or fetching online results for a specific location.
Features:

Support for Google, Bing, Yahoo, and more.
Advanced functionality for fetching results from Organic Search, News, Maps, Events, Images, among others.
Search queries can be specified in different languages and set for a variety of locations.
Capability to filter and fetch only necessary data fields from SERP, like prices from shopping results or rating from organic elements.
Ability to limit the number of search results returned.

Usage example:
import { OpenAI } from "langchain/llms/openai";
import { initializeAgentExecutorWithOptions } from "langchain/agents";
import { DataForSeoAPISearch } from "langchain/tools";

process.env.OPENAI_API_KEY = '';
process.env.DATAFORSEO_LOGIN = '';
process.env.DATAFORSEO_PASSWORD = '';

const model = new OpenAI({ temperature: 0 });

//Search for first result description
const search = new DataForSeoAPISearch();
search.call("pi value").then(v => console.log(v));

//takes only top-3 results and only title, snippet, description fields from JSON, restrict output to 4 SERP elements: organic, featured_snippet,answer_box, knowlege_graph
const confugured_search = new DataForSeoAPISearch(
  {
    json_result_fields: ["title", "snippet","description"],
    json_result_types: ["organic", "featured_snippet","answer_box", "knowlege_graph"],
    top_count: 3,
    use_json_output: true
  }
);
confugured_search.call("Bill Gates").then(v => console.log(v));

//Google Maps search
const maps_search = new DataForSeoAPISearch(
  {
    json_result_fields: ["title", "value", "address", "rating", "type"],
    top_count: 10,
    params: {"location_coordinate": "52.512,13.36,12z", "language_code": "en", "se_type": "maps"},
    use_json_output: true
  }
);
maps_search.call("coffee near me").then(v => console.log(v));

//Integration with agents
const tools = [
  new DataForSeoAPISearch()
];

initializeAgentExecutorWithOptions(tools, model, {
  agentType: "zero-shot-react-description"
}).then(executor => {
  const input = "What is weather in New York?";
  executor.call({ input }).then(result => {
      console.log(result.output);
  });
});

Thanks! I'll take care of merge conflicts


command line interface

It's quite a lot to ingest, sorry.  However, the PR is split into a number of (hopefully) logical commits that can be reviewed in isolation.
The docs (https://github.com/veraison/corim/blob/cli/cocli/README.md) might help getting a high level view of the whole thing before being bogged down into the minutiae.
If you are planning to install the CLI as per README.md instructions, note that the go install command needs to be slightly amended to point to the dev branch:
go install github.com/veraison/corim/cocli@9a8057cf37abd4a2aecfd4c328dee31fc9711b8f

(This PR is relevant in the context of https://github.com/ietf-rats/ietf-corim-cddl/issues/121)

e same level as the rest of the library code. I think we'd be introducing an artificial distinction with no added value.

That's precisely I am saying: As you mentioned yourself, it is a "serious tool"!
All I am saying that just like "Docs" go in docs folder (as they are documents), Examples go in examples folder, script goes in "script" folder, similarly there should be a suitable top level entity that precisely describe the job that this deliverable does!

e same level as the rest of the library code. I think we'd be introducing an artificial distinction with no added value.

That's precisely I am saying: As you mentioned yourself, it is a "serious tool"!
All I am saying that just like "Docs" go in docs folder (as they are documents), Examples go in examples folder, script goes in "script" folder, similarly there should be a suitable top level entity that precisely describe the job that this deliverable does!

We'd end up with a new tools folder which only contains a cocli folder.  It doesn't seem worth the effort to me :-)


Enhancement: Validate any schema property that is a JsonInput has valid json

Description
Closes https://github.com/PrefectHQ/prefect/issues/7623
Makes sure any json input is validated as valid json before submitting

This looks nice to me but I read the issue it's closing as being about identifying the json input box. For example in some blocks, it's not clear that json is needed.

@zhen0 agreed. But I think this solves the primary issue of being able to save the block with invalid data. This is now consistent with the rest of the app where we use json. We might want to make json inputs as a whole more intuitive.


Hint: 'x' is declared but not used [XDeclaredButNotUsed]

You may want to filter out such warnings, as in an interactive REPL variables may be used later

I'll look into implementing this in the next release.

Fixed in version 0.1.4


Update copyright date

Continuation of #429.
Anyway, as 2023 approaches, perhaps it's time to update the copyright date again?

Addressed by repo author in commit 9e4b529. Closing.


Focus keeps shifting away from my group

I'm coding primarily in Python and Ruby. I usually code with two groups open.
I'm typing in group 1, then I move focus to group 2. Focus is then forced back to group 1, when a tooltip appears for whatever I just typed. This is a problem, because for Python and Ruby, the tooltips will often have some delay because they are slow to load. For Python for instance, I've had tooltips appear 5 seconds after the last character was entered.
This only started happening a few days ago, about 5 days ago from this date, if I had to guess. It was fine the month before that.
Please either stop letting tooltips take focus away from the group I'm in, or stop tooltips from appearing in groups that are not in focus.

What do you mean by "tooltip appears"? Can you share a screenshot?

It's hard to reproduce because I need to get a tooltip that has a delay before it loads. Then when I switch to another tab, it will finally load, and take focus away.


Spurious error messages on successful derivation across chained implicits

If Magnolia is called via a chained implicit, which is itself inferred by Magnolia, the nested invocation will report some errors, even if the entire derivation succeeds. The macro needs to differentiate between a nested and outer invocation, and only output errors in the latter case.

Need to write a test to confirm that this is no longer the case (or fix it).

Stale issue, we haven't seen anything like that in a while.


Solution for RasPi on OSMC?

Hi,
Is there a solution to run this plugin on Kodi/OSMC on a rpi?
Thanks!

+1 for the same on Pi with Librelec

You can easily run this on a python docker image for armhf.

I don't get it how to do this, not a docker fan or guru yet. Would be much more easier deal with 1 executable and config for armhf as well, Librelec has a very limited add-on oriented environment.

@osscombat Actualy libreelec has built-in Docker support so it's just a matter of having a Dockerfile based on a node image made for armhf. I can give it a go and post a pull request if it helps?

If it's possible. I have a docker service on librelec up and running, but that's all. I can test this further on if you can support this option.

@osscombat I am not sure how @TheJF wants to handle this (separate Dockerfile in the master branch or 1 branch per architecture?), but in the meantime I forked his repo and created an arm32v7 (Raspberry Pi 2/3) dockerfile under the branch arch/arm32v7. Please try my image at fsegouin/antennas:arm32v7 and let me know if it works.

@TheJF You're very welcome 🙌🏻 It's a bit tricky as you need QEMU in the docker image to be able to use an automated build system on Docker Hub (see https://ownyourbits.com/2018/06/27/running-and-building-arm-docker-containers-in-x86/). I went the easy route and built it myself on my Pi for now as a PoC.

Thanks a lot @fsegouin, with fsegouin/antennas:arm32v7 image it runs fine on Rpi3!


Generate test-jar for HDFS UFS

What changes are proposed in this pull request?
There are some other packages need to reference the test file in HDFS UFS package so we create a test jar here.
Does this PR introduce any user facing changes?
N/A

alluxio-bot, merge this please.


Add more context to errors returned by config validation

Splitting this out from my soon-to-be-submitted metrics validation PR.

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed


Unable to find how to change the SSL thumbprint of vCenter

Description
Unable to find how to change the SSL thumbprint of vCenter
Location
N/A
Additional Context
As per above, I can't find how I can set up the new SSL thumbprint of vCenter. Its cert got renewed, but everything fails now as the SSL thumbprint changed.

Hello @MasterWayZ
are you trying to change the SSL Thumbprint on an already deployed Kubernetes cluster?


range() integer end argument expected, got float

Traceback (most recent call last):   File "cnn.py", line 181, in <module>     cnn_model(X_train, y_train, X_test, y_test, 0.8, 1e-4, num_epochs=500, minibatch_size=16)   File "cnn.py", line 152, in cnn_model     minibatches = random_mini_batches(X_train, y_train, minibatch_size, seed)   File "cnn.py", line 80, in random_mini_batches     for k in range(0, num_complete_minibatches): TypeError: range() integer end argument expected, got float.

Traceback (most recent call last): File "cnn.py", line 181, in <module> cnn_model(X_train, y_train, X_test, y_test, 0.8, 1e-4, num_epochs=500, minibatch_size=16) File "cnn.py", line 152, in cnn_model minibatches = random_mini_batches(X_train, y_train, minibatch_size, seed) File "cnn.py", line 80, in random_mini_batches for k in range(0, num_complete_minibatches): TypeError: range() integer end argument expected, got float.

你好，num_complete_minibatches这个参数你设置的是整数吗？


New dragging!  Merge from google

This change picks up all of my new dragging code, plus some of the new variable code.
It's ginormous but I've checked it against https://github.com/google/blockly/pull/1078 and I'm pretty happy with it.
All of the insertion marker code now lives in insertion_marker_manager.js, which has the same API as dragged_connection_manager.js.  This should help reduce conflicts between scratch and blockly codebases.

Fixes https://github.com/LLK/scratch-blocks/issues/893

@rachel-fenichel thanks for walking me through this, sorry about the delay.
Pulling and building to use for scratch-gui I get this error:

@rachel-fenichel It looks like something changed the behavior of the delete cursor style. Here is what it used to do:

And now there is no "x" cursor style:

Fixed all three.  Thanks for the details on the deletion one.  They made it easy to fix.

Oh wait--now if I have an insertion marker and transition to needing a deletion hand, the insertion marker remains.  That's no good.

Okay, I've fixed that one as well.

Great thanks @rachel-fenichel! Looks good to me now.

Wait sorry getting a similar require error for Uncaught TypeError: Blockly.VariableModel is not a constructor from VariableMap.createVariable.

Fixed missing require.

Verbally okayed by Paul.


Dose this plugin support Windows GNU toolchain?

Version of VSCode: 1.33.1
Version of the extension:  0.6.1
OS: Windows 10 1809
Description:
I have installed the stable gnu toochain, the rustup show command output:
Default host: x86_64-pc-windows-msvc

stable-x86_64-pc-windows-gnu (default)
rustc 1.34.1 (fc50f328b 2019-04-24)

Output of the "Rust logging" channel:
[Error - 7:43:31 PM] Starting client failed
Error: Command failed: rustup component list --toolchain stable
error: toolchain 'stable-x86_64-pc-windows-msvc' is not installed

	at ChildProcess.exithandler (child_process.js:303:12)
	at ChildProcess.emit (events.js:182:13)
	at maybeClose (internal/child_process.js:961:16)
	at Socket.ChildProcess.spawn.stream.socket.on (internal/child_process.js:380:11)
	at Socket.emit (events.js:182:13)
	at Pipe.Socket._destroy._handle.close [as _onclose] (net.js:596:12)

Can't the plugin work with Windows GNU toolchain?

I finally find the solution of my problem.
The plugin needs the DEFAULT HOST of rustup match the current toolchain, use command:
rustup set default-host x86_64-pc-windows-gnu

change the default host to gnu toolchain will solve the problem.


Prevent astropy warnings in tests

astropy 4.2.1 started emitting an additional warning when opening bad files.  This PR marks tests that open known bad files to ignore that warning.

Do we know why these are bad files?  Almost every test file that the asdf library has written now gets these warnings.  There are dozens in the jwst repo as well. 🤔

Do we know why these are bad files?

In asdf at least they're intentionally bad, for example:
def test_no_asdf_header(tmpdir):
    content = b"What? This ain't no ASDF file"

That content isn't recognized as ASDF, so it gets passed to astropy.io.fits, which emits the warning.  Do you have examples in jwst of files that should be valid ASDF or FITS but still result in a warning?

Yeah, a ton of them.  Start here and scroll up.
https://github.com/spacetelescope/jwst/runs/2422915561?check_suite_focus=true#step:10:845
That said, you bring up a good point.  Some are likely bad files, but I've looked at a few, and they are not even writing out files, which makes me think AsdfInFits is generating bad files?  Not sure.  Would be good to understand whether it's a bug in astropy.io.fits or a bug in asdf.AsdfInFits instead of sweeping it under the rug.

This commit seems responsible:
https://github.com/astropy/astropy/commit/070cd942a6ae9e18513c21c19efe0eb91a969972#diff-6ebde8ab98c018da8dd092e05ef30d9607dc9f998bfed0df91a6b67c671ca651
The warning is emitted from within that _check_padding function.  Previously they were raising "Header missing END card." for invalid files before _check_padding.  Now the order is reversed so the warnings are appearing before the exception is raised.

And let's discuss any issues with jwst elsewhere, preferably in a jwst issue.


Incorporate changes recommended by risa2000

@risa2000 Could you please review this pull request? I incorporated the ideas from your pull requests, but I modified the translator so the changes would apply more generally.
Sorry I made a lot of whitespace changes, because I wanted all line endings to be newlines. It's probably much easier for you to review if you ignore whitespace changes by adding ?w=1 to the URL, like https://github.com/cmbruns/pyopenvr/pull/66/files?w=1


uint/usize updates and fix for recursion issue.

Just a few small changes to compile with fewer errors/warnings against latest rust nightly.

Hey, thanks for helping to keep the library up to date!
There's a small issue with the SliceExt import on the latest nightly (c89de2c56, built 03-28), though. I'll merge this in when everything runs on the latest.


Prevent fsck from running.

Sometimes I've encountered that fsck wants to run during container startup. This of course does not work and fsck asks interactively what to do, blocking the whole boot process.
This change prevents it by creating the /fastboot file in the target container which causes fsck to be
skipped. It is created outside the container and r/o mounted there to prevent
the container from removing it. At the same time create also /.nolvm, which
prevents LVM configuration.
It would be preferable to get rid of the whole /etc/rc.sysinit script, whose majority does not make sense in a container environment, but this I found too invasive.

Can one of the admins verify this patch?

Jenkins: ok to test


Avoid basin areas becoming 0

Basin areas of 0 (which currently occur when a basin is empty) yield division by 0 in the analytical Jacobian (https://github.com/Deltares/Ribasim/pull/465). To avoid this we need some way to make sure that the basin area never becomes 0.
One way to do this is to add a validation for the input areas always being positive. There might also be some parts of the code that already rely on the area of the basin being 0 on the bottom.

Let's validate that area starts at > 0, to avoid having to hardcode a minimum such as 1m2 or such.


 It is monumentally painful to deal with meaningfully.
Please consider an alternative to using this regularly.
At the minimum please consider making ConcurrencyException be a regular exception even if you just
make it something like
public class ConcurrencyException  : Exception {
    public AggregateException Details { get;set; }
}

I pretty much never care about the details of a concurrency exception. Either i have an explicit retry policy around an item or i just want the request to die. But having to interrogate an aggregate exception ex.InnerExceptions.OfType<ConcurrencyException>().Single(); is really silly.

@dotnetchris This one falls under the "I take pull requests" category.

Actually, now that I think about it, I kept it to AggregateException on purpose because there could be other ex's down the line than concurrency exception.


[Everhour] fix #13548 + modernize + add metadata/images,README

Description

Fix Issue #13548

The issue would show up if a time entry did not have a task assigned

Add icons to Actions
Make api more TS friendly by removing use of any
Add metadata images
Add a README
commented out unused function but left it in case it is needed in future
removed redundant keywords

Screencast
https://github.com/user-attachments/assets/15bc98c8-b065-4c14-ad32-c8fbbca51e43
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Appreciate the review @farisaziz12.
Removed the commented out code and made most toasts proper-cased.


Fix access to httplib.HTTPResponse class from RawResponses

I've noticed that some drivers rely on access to a httplib.HTTPResponse object as a property of RawResponse. This was updated in #728 to the requests response class, which would, in turn, break a few implementations.
To avoid backward compatibility issues, this introduces a proxy class with HTTPResponse methods and properties and tests to validate access.
None of the existing unit tests would have caught this behaviour since the response classes are mocked. This issue was caught in #970

build fixed. PR complete https://travis-ci.org/tonybaloney/libcloud/builds/190789008

@pquentin does this fix your script?

@tonybaloney Sorry, no. I double-checked to ensure I had the code from this PR. I still get the same issue, both with my code and the minimal example from https://github.com/apache/libcloud/pull/923#issuecomment-271784099

@pquentin https://github.com/apache/libcloud/pull/973/commits/1eb58838df91ff8d9156a341b1ef560f601f7277 should fix the issue, I've been testing that script you sent me against my GCP account and it works. The unit tests are broken, but only because the mocks are missing certain properties..

@tonybaloney Awesome, it works! The only difference is that the generator yields one byte per next() call, while the old one was yielding byte chunks (8096 bytes is the default value I think). Not an issue for me, but I thought I would mention it.

@tonybaloney Perfect, this fixes it! I no longer see any differences between the old libcloud and the requests-based ilbcloud! 👏 Thank you for you work and fixing those issues this quickly.

merging


Update mr-azure-306.md

OPS Build status updates of commit 0bc7fed:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 0bc7fed:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 0bc7fed:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mr-azure-306.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Eagle App to File Organization Tools

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes

Add Eagle App to the list of File Organization Tools
Eagle App is a simple and intuitive file manager with tag and annotation. It helps you easy to get your hands on file organization and it improves productivity.

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@angiewang888 URL errors
- https://eagle.cool/
+ https://en.eagle.cool/

@angiewang888


Random access zstd

[small/nodata1-default] FAIL
Commands:
    ../ennaf/ennaf --binary-stderr small/nodata1.fa 2>small/nodata1-default.e.err | ../unnaf/unnaf --binary-stderr --binary-stdout >small/nodata1-default.out 2>small/nodata1-default.u.err
Errors:
    "nodata1-default.out" differs from "nodata1-default.out-ref"
    "nodata1-default.u.err" differs from "nodata1-default.u.err-ref"

Hi Youri! Thanks for starting this experiment. I confirm the test failure. When compressing this file (tests/small/nodata1.fa):
>1
>2

As ./ennaf/ennaf tests/small/nodata1.fa >nodata1.naf, I see a 160 bytes output created.
However, decompression command ./unnaf/unnaf -c nodata1.naf fails with message: "unnaf error: can't decompress mask".
Also, normal NAF (current "develop") makes 57-byte archive. But we can worry about it later, it might be OK on larger inputs.
Checking ./unnaf/unnaf --sizes nodata1.naf for both cases produces, with normal NAF:
IDs: 9 / 4 (225.000%)
Names: 7 / 2 (350.000%)
Lengths: 13 / 8 (162.500%)
Mask: 5 / 0 (inf%)
Data: 5 / 0 (inf%)

With this PR:
IDs: 38 / 4 (950.000%)
Names: 36 / 2 (1800.000%)
Lengths: 42 / 8 (525.000%)
Mask: 13 / 0 (inf%)
Data: 13 / 0 (inf%)

So, empty input (0-bytes) is stored in 5 bytes with normal ZSTD and in 13 bytes with seekable ZSTD. And can't be decompressed back in case of seekable ZSTD, while normal on works fine.
Empty sequence is a valid use of NAF format, so it must be supported. Easiest way would be to special case it. A better way would be to investigate further and report upstream, so that it can be fixed in ZSTD.
Do you think you can try isolating a reduced ZSTD test case?

Do you think you can try isolating a reduced ZSTD test case?

I am not sure what (kind of test) you are asking?

Seekable zstd seemed to work until presented with an empty input (0 bytes buffer), thanks to the test suite. If we can confirm this failure in a small C program, then we can report to zstd devs.
Essntially, a tiny C program that does the following:

Compresses a test string (e.g. "Hello") using normal zstd, decompresses, compares output with original, asserts on failure or difference from original.
Does the same with seekable zstd.
(Steps 1 and 2 are to show that zstd, both normal and seekable, basically work file).
Compress an empty (0 bytes) data using normal zstd, decompress back, compare output with original, assert on failure or difference from original. (Seems to work with normal zstd, because NAF can store empty sequence).
Does the same with seekable zstd. It looks like this fails currently.

In principle just step 4 could be sufficient, but it helps to also include successful cases, as reassurance that other combinations work, and to highlight the inconsistency.

I have made a test case and I can get Seekable compression and decompression of an empty stream working. After some debugging, I noticed that there are only 3 streams created with ZSTD_seekable_createCStream instead of 5. I will have another look at it soon. It seems that I am the one to blame here.

I'm not sure how this explains that test suite succeeded, except the one test with empty sequence. But great that you are making progress.

Hi @KirillKryukov,
I have been debugging and hexdumping all sorts of stuff to figure out whats going on. I think there is 1 bug in zstd-seekable and 1 bug/feature/odd behaviour in zstd that made it difficult to track it down.
I first made isolated tests, compressing the string "test" and the string "", thus empty. Both were compressed and could succesfully be decompressed. After hexdumping the output of the compressed "" string, I noticed there was no header + zstd magic, yet zstd can decompress it without the header and without giving an error. That made the problem kind of invisible.
This is what happened in NAF as well, it compresses sequence data without adding the header, but of course NAF chops of the first 4 bytes presuming this is part of the header. As the actual header was not exported by zstd_seekable, we simply truncated the compressed output by 4 bytes.
I thought of 2 solutions:

(1) if the decompressed size of a stream is 0, don't prefix the MAGIC when unnaf reads from a file.
(2) fix the actual issue in zstd seekable to make it export the header.

(1) was pretty easy to do and worked, but this is a workaround to a bug
(2) I think the last pr fixed this. I want to test it with bigger files to ensure it causes no further trouble, and maybe I wil PR this to the upstream zstd repo.

Great work. Yes, it's best to PR this to the upstream zstd.
On our side, I'm thinking to actually stop cutting away the initial 4 bytes of the header, in the future version of the format. At the cost of a few extra bytes per file (up to 24 bytes?), it will open the possibility to use other compressors than zstd for individual streams in the future.


Fix reference to basic level doc

What does this PR do?

Fixes reference to basic level doc
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @rohitgr7

Added this PR to 1.6.x milestone as done the same for #12825 #12795.

Thanks @akihironitta! However, we don't plan to include it in the bug-fix branch ATM. And if we do, I don't think we will be cherry-picking the commits individually


113 openbis datetype vocabularies

fixed finding mixfiles in dodo MinimumWorkingExample workflow from files, added controlled vocabularies for units and operator date as Date instead of Varchar

Let's check the data upload in new issue. Should be possible I would say


Detect if tac is in PATH even when in macOS

This is needed for example when using Nix which will add tac and GNU coreutils to the PATH.

Looks good, thanks for the pull req! I've merged it.


Run tests on PRs based on files touched

Travis CI currently doesn't support triggering tests based on what files were touched by a PR. However, there must be some kind of hack for this.
This will help speed up testing for PRs. This would also be a forcing function to manage the tests better.

Found an example on how to do this: https://github.com/dev-id/Magic-Spoiler/blob/8111a06ab6682e020169991d5e2aa4fa503d787f/preflight.sh

Closing this issue due to the Travis CI news (no official announcement has been made but apparently their core team has been laid off)

Reopened issue - implementing this using Circle CI now. There is a possibility of using an orb here but this needs investigation

We haven't found an orb that does this. Falling back to figuring out how to write conditional tests.

https://github.com/CircleCI-Public/config-preview-sdk/blob/0d39520bb81ffac555c3ec75f616aa4f8e2e697b/docs/conditional-steps.md#conditional-steps
Means the condition needs to be predefined (not evaluated at runtime) which we cannot do. So this has to be written as a test.

Manually closing. This change was resolved in #318


Full API code audit

A lot of the backend code is pretty spaghetti because it was sort of rushed in order to reach the deadline. Some authentication code is repeated, and socket.io event handlers don't all properly check for authentication. Here's how the authentication decorators should work after the audit (all of them will be defined in api/hierarchy.py)
@util_two_person
def endpoint(token_id: str | None, explicit_id: str | None)
# This decorator doesn't check for hierarchy constraints, but does
# make sure that token_id or explicit_id are valid user_id's

@auth_required(level: "none" | "user" | "mod" | "admin" | "bot") # these are already defined in api/hierarchy.py
def endpoint(user_id: str)
# This decorator only runs endpoint() if token_id from
# @util_two_person is not None and passes hierarchy constraints

@two_person
def endpoint(user_1_id: str, user_2_id: str)
# no authentication, just runs endpoint() if both token_id and
# explicit_id are present from @util_two_person.

If possible these decorators should also work for socket.io event handlers.
If the decorator finds that a token is invalid, or something else happens that doesn't allow the wrapped function to be ran, it should return an empty response along with one of the following http status codes:

400 should be used if the request has missing or malformed data
401 should be used if a token has expired or is invalid, or a user_id is invalid
403 should be used if all data is valid but the hierarchy constraints don't pass

As part of the API code audit, the documentation should also be updated and finished in api/readme.md, and another table for commonly used utility functions and decorators should also be created so it's easier to write new endpoints.

The code has been audited, and pretty much all endpoints, and even the socket.io event listeners are using decorators from api/hierarchy.py. I'll now start with updating and finishing the documentation.

I've updated the documentation in api/readme.md, and modified dprint.json to use space tabs in python even though I think spaces are hideous. I'll close this issue for now because I think the api code is safe enough right now, though I will be writing unit tests soon.


Techdocs, bitbucket reader doesn't update the last version in case of a different branch of default one

Expected Behavior
You have your techdocs posted on bitbucket and you would show a version of a particular branch, in case of new commits you would like to see the new update on techdocs.
Actual Behavior
After the first build of techdocs, you don't see any update
Steps to Reproduce

Have a repository of techdocs in bitbucket
Create a new branch from the default
Added the new  URL of the new branch on the catalog ${bitbucketUrl}/${project}/${repo}/tree/${branch}
Build the new version of techdocs
Make an update and push the new commit
Will not see any change

Context
The problem is on
BitbucketUrlReader
 const commitsApiUrl = isHosted
      ? `${this.integration.config.apiBaseUrl}/repositories/${project}/${repoName}/commits/${branch}`
      : `${this.integration.config.apiBaseUrl}/projects/${project}/repos/${repoName}/commits`;

The case isHosted is false,  it uses this endpoint
But it explains:
Retrieve a page of commits from a given starting commit or "between" two commits. If no explicit commit is specified, the tip of the repository's default branch is assumed. commits may be identified by branch or tag name or by ID. A path may be supplied to restrict the returned commits to only those which affect that path.
this means that in every case it provides only the list of default branch commits, so we don't have the list of the branch commits

The problem exists also onBitbucketSeverReader.getLastCommitShortHash https://github.com/backstage/backstage/blob/master/packages/backend-common/src/reading/BitbucketServerUrlReader.ts#L192

Does the merged PR close this issue?


Remove all code related to chant-delete view

A while ago, Jiwoo set up a chant-delete view to facilitate testing during development. Now that we are spending less time implementing features related to chant editing, this view is less useful, and is mostly a way for users to delete things from the database, either by accident or if they become disgruntled for some reason (and if we make a mistake somehow and this view becomes accessible to the general public, this could be a significant problem). We don't need it anymore, so let's get rid of it.

won't some users (proofreaders, for example) occasionally want to delete things, though--chants that accidentally got put in in duplicate, for example? or is this something separate from that?

No, they shouldn't need to. This is not a feature of OldCantus - it's something Jiwoo set up to facilitate development.
My understanding is that if someone accidentally creates a chant that needs to be deleted, they contact Debra (or someone else with admin privileges), who can then delete it using the admin page.

I suppose we could check before deleting it, but we should put some thought into how we want it to be implemented it if we decide to keep it around (since it amounts to a new feature that no one, to my knowledge, has asked for). It had a link from the chant edit page (but not from the proofread page), and could be accessed by replacing chant with chant-delete in the URL of any chant detail page.
My nightmare is that we change something with our permissions settings in the future, and some random person on the internet discovers they aren't actually shown a 403 error when they add -delete to a URL, and go about deleting chants at random before someone realizes what's happening. If we don't realize for a while, this could mean a lot of lost work if we have to roll the database back by several months.


notif: Enable autoCancel flag for summary notification

While trying out the release build from main on a relatively older (Android 11) device, I found that it results in lingering summary notif:

Android 14
Android 11

Specifying autoCancel: true fixes this behavior on the older device.

So, I tried the emulators (from Android 12 - Android 9) and turns out it's specifically the behavior on Android 11 (API 30) and lower:

Android 11
Android 10
Android 9

It would have been great if this was documented somewhere ^^. Also the need for an integration test that would automate this and would have caught it — if it was set-up to run on multiple emulators with different Android versions. But definitely not great for each CI run, but could be good to run before each release in CI or locally.

Excellent, thanks for following up and for the thorough investigation!
(Previous thread for cross-reference: https://github.com/zulip/zulip-flutter/pull/703#discussion_r1643498883 .)
Merging this. I'll also add a line in the comment, to use our pattern for marking things we can simplify away when we drop support for an old platform. (We most commonly use this for versions of the Zulip server, the TODO(server-N) comments mentioned in the README, but it applies equally well for versions of Android or iOS.)

It would have been great if this was documented somewhere ^^.

Yep. Android unfortunately isn't real consistent about documenting this sort of thing.

Also the need for an integration test that would automate this and would have caught it

Yeah, agreed. I'll go file an issue or two about doing that. We're not going to invest in it soon; but I want to record this experience, because it's a great motivating example to have in mind when the launch is complete and we're thinking about what to prioritize next.

I'll go file an issue or two about doing that.

Done:

#757
#758

Done

Great, Thanks @gnprice!


/db failed: No such device

I'm on Centos 7 using datakit https://github.com/docker/datakit/commit/51bcdedbe2f16f8d59cc1dc4fdbfb8d9c8848ffa and ran in one terminal:
$ ./scripts/start-datakit.sh

After building finished, in another term I ran:
 datakit-mount
mount: mounting <IP_ADDRESS> on /db failed: No such device

Is this expected behavior?

Is this expected behavior?

Not really :-) I think you forgot to run $ ./scripts/start-client.sh in your new terminal.
But as datakit just exposes a normal 9p endpoint, you can just use a normal mount command, for instance:
sudo mount -t 9p -o trans=tcp,port=5640,noextend,nodev <IP_ADDRESS> /mnt/db

I'm hoping it is a user error on my part in reporting the bug.  I thought that I had run $ ./scripts/start-client.sh.  History shows that I did.  Something else is going on.
I don't see any interesting logs.  Where can I look?

The start-client.sh will start a new container. Please be sure you are running datakit-mount in the shell of that container. But it's maybe an issue with the IP of the first container.
If that's already the case I guess that's an issue with the IP address of the container running Datakit. Can you try to ping db to get the right IP address of the DB and use it to all the mount script: datakit -h <IP>?

I've tried to simplify the "quick start" step. Now the following should work:
docker network create datakit-net
docker run -d --net datakit-net --rm -ame datakit docker/datakit
docker run -it --net datakit-net --privileged docker/datakit:client
ls /db

Thanks for the feedback and let me know if you have more issues!

@josephwinston hopefully the doc is now clearer. I'm going to close that issue now, but please re-open it if you still have issues/questions!


Usage example added to tf.image.transpose

A small usage example added to tf.image.transpose

@googlebot I signed it!

Hello I have made the changes

I'm closing this PR since I've made the comment N times that you should use a small constant and not a random image and should make it a doctest.

I'm closing this PR since I've made the comment N times that you should use a small constant and not a random image and should make it a doctest.

I have done that on this other
PR


Merge docs branch into dev-master

This is a pretty large change.  But git checkout this site and then pkgdown::preview_site()..
MicrobiomeR 0.2.0
Documentations

Added vignettes to package and pkgdown config.

About
Introduction
Data Wrangling
Filtering
Analysis

Added reference sections to pkgdown config corresponding to @family tag.

Import
Formatting
Validation
Filtering (Basic, Advanced, Other)
Visualization
Color Palettes

Functional Changes

Renamed sample_filter to sample_id_filter.
Renamed get_phyloseq_obj to create_phyloseq.
Renamed format_metacoder_object to as_custom_format.
Updated vlookup and get_color_palette parameters.
Added the root_phyloseq_tree function.
Fixed minor bugs in code and docs.

Hooray!!  @sdhutchins

Now...REST! lol @grabear (I know you won't. 😆 )


imageHdrScript: Fix binary I/O on integers of incorrect size

The variables were declared as "unsigned long", but the reads and
writes expected them to be of size 32 bits, so on a 64-bit system the
sizes did not match.  This could be observed on a 64-bit big endian
host where only zeroes were written to the files.
I also found and fixed some size mismatches in sscanf.

I added some more fixes to get rid of all warnings and to fix the output from dumpHdr.
Also, l_version is now a char array, since there was no reason for it to be a scalar in the first place.  It is now no longer possible to smash the stack by providing an overlong version string on the command line.

Ping?  In case I was being unclear, building OCC on ppc64 is broken and this fix unbreaks it...

@zeldin I'll chase some OCC people for this - sorry that nobody's reviewed anything yet.

This has been pulled in with https://github.com/open-power/occ/commit/97f1483c0bd9bd18c1d8053d617d9afefc6e1efa

@wilbryan https://github.com/open-power/occ/commit/97f1483c0bd9bd18c1d8053d617d9afefc6e1efa appears to drop @zeldin's name from the commit. That should probably be reverted to include them as the author.

@sammj That's not really important.  It's trivial changes.  As long as the stuff went in it's fine.

We do that because we track our repositories on an internal Gerrit server before pushing/mirroring to Github.

We do that because we track our repositories on an internal Gerrit server before pushing/mirroring to Github

Yes, and git commit --amend --author=... exists as well. While @zeldin has been gracious enough to not worry about it in this case, properly attributing authors is extremely important when taking other people's changes in an open source project. This should be done properly next time.

I did not know about that option, thank you for telling me about it. Duly noted.

Will Bryan<EMAIL_ADDRESS>writes:

We do that because we track our repositories on an internal Gerrit
server before pushing/mirroring to Github.

That shouldn't require removing authorship though, right?
It's important from a Copyright point of view too - we do not ask for
copyright assignment, so maintaining the record of who authored what is
important.
--
Stewart Smith
OPAL Architect, IBM.

I attempted to leave the commit as-is. My git knowledge is probably not as great as it should be, but I am learning. I don't recall my exact commands but I somehow cherry picked the commit from Github into my local repository, pushed it to Gerrit for review, then after it was reviewed, I committed it, and then I recently pushed it to Github. If y'all know the best way to do that sequence of events to preserve authorship, please share.


smtp mail.routing.net unable to open connection

Describe the bug
Error Message:
Unable to open connection to SMTP server
To Reproduce
try to set the smtp server für mail.routing.net
Expected behavior
Should work, with FairMail everything works fine
Environment (please complete the following information):

K-9 Mail version: 5.806
Android version: [e.g. 8]
Device: [SG7]
Account type: [IMAP]

Seems to work fine for me. Please provide detailed steps on how to reproduce the error. Ideally also a debug log.

I have set the exact same smtp values in K-9 and FairMail (copied it)
FairMail works fine. With K-9 i always get the error message
SocketTimeoutExeption: failed to connect to mail.routing.net
I won´t install software on my pc to extract the logfiles, sorry.
Why there isn´t a option to send the logfiles via K-9.
I am really frustrated after years of using K-9.
Maybe the best solution would be using FairMail in the future?

FairEmail is a different app. There is not necessarily a one-to-one mapping between what you enter there and what needs to be entered in K-9 Mail.
Since you're getting a SocketTimeoutExeption this is most likely not a bug in K-9 Mail, but a configuration or network problem. Make sure you're using the proper server settings (including port numbers and security options) for your provider. If you're still running into problems try asking for help in the support forum. Maybe someone using the same provider can help you out.

Thank you very much! This really helps me a lot. When everything works fine with Thunderbird, FairMail and Samsung Mail it could't be a fault of K-9 Mail, of course.
So you get another 1 Star Rating in Playstore and FairMail get + 1 Pro Members
¡Muchas Gracias!


Serializing Requests

Hello guys,
I want to serialize requests and responses as well.
I found the solution on #53 - but
The \GuzzleHttp\Psr7\str function does a good job indeed, except it doesn't make a difference between HTTP and HTTPS.
<?php

use GuzzleHttp\Psr7\Request;
use function \GuzzleHttp\Psr7\str;

require_once __DIR__ . '/../vendor/autoload.php';

$secureRequest   = new Request('GET', 'https://example.org');
$unsecureRequest = new Request('GET', 'http://example.org');
var_dump(str($secureRequest) === str($unsecureRequest)); // true

This is quite disturbing because when I store a request as string for further use, the request automatically switches to HTTP...
Any ideas?
Thanks,
Ben

The problem is the scheme is only part of the TCP connection (via port, ssl) and not really part of the request HTTP representation. What you can do is the set the request target (withRequestTarget) to the absolute-form. See https://tools.ietf.org/html/rfc7230#section-5.3.2

Hello Tobion,
Thanks for your quick answer. I followed your advice but this breaks "unserializing":

/**
 * @param \Psr\Http\Message\RequestInterface $request
 * @return string
 */
function serializePSRRequest(\Psr\Http\Message\RequestInterface $request) {
    if ($request->getUri()->getScheme() === 'https') {
        $request = $request->withRequestTarget('absolute-form');
    }
    return \GuzzleHttp\Psr7\str($request);
}

/**
 * @param string $string
 * @return GuzzleHttp\Psr7\Request
 */
function unserializePSRRequest(string $string) {
    return \GuzzleHttp\Psr7\parse_request($string);
}

$secureRequest      = new \GuzzleHttp\Psr7\Request('GET', 'https://example.org');
$secureRequest      = $secureRequest->withRequestTarget('absolute-form');
$unsecureRequest    = new \GuzzleHttp\Psr7\Request('GET', 'http://example.org');
$secureRequestStr   = serializePSRRequest($secureRequest);
$unsecureRequestStr = serializePSRRequest($unsecureRequest);
var_dump($secureRequestStr === $unsecureRequestStr); // false
var_dump(unserializePSRRequest($unsecureRequestStr)); // returns \GuzzleHttp\Psr7\Request object
var_dump(unserializePSRRequest($secureRequestStr)); // throws \InvalidArgumentException: Invalid request string

What would be the best practice?
Thanks,
Ben

withRequestTarget('absolute-form')

This is not correct. Absolute-form is just the name. This should do it: $request->withRequestTarget((string) $request->getUri())

LMAO - #facepalm ^^
Sorry, my skills in raw HTTP messages aren't that good.
Your solution works, wether or not the original URI has an HTTPS scheme.
Thanks! I owe you a beer.
Ben


Update repository interface and implementation for bulk operations

Update repository interface and implementation for bulk operations on Entities

I don't think this is a common enough requirement to include in the default template. If you want to open an issue and see if the community wants to vote it up I would reconsider. Sorry for the long delay in responding.


Authenticate user when viewing a protected video

When you play a protected video while not logged in, paella 7 returns an error instead of trying to authenticate the user.
Paella 7 should authenticate the user and try to view the video again.
Your pull request should…

[x] have a concise title
[x] close #4338
[x] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

Tested and works as expected, thanks a lot!


Refactor anthropic message format to support tool messages & Allows Anthropic Bedrock clients

Instead of concatenating strings with "\n\n", we use the following format to merge consecutive Anthropic messages of the same roles:
{
  "role": "user",
  "content": [
    {"type": "text", "text": "Hello, Claude"},
    {"type": "text", "text": "How is it going?"}
  ]
}

Which also allows other message types like image objects, tool invocation (for assistant), tool results, etc. As a comparsion, this version of tool support is able to pass the anthropic tests which currently fails.

:rocket: This PR description was created by Ellipsis for commit 9705a6f3b4cf00ddfb04c9d999f53f39c44312a2.

Summary:
This PR refactors the anthropic message format to support tool messages, updates the reask_messages and merge_consecutive_messages functions, and modifies the corresponding tests.
Key points:

Refactored reask_messages function in /instructor/retry.py to include the original response and format error messages differently.
Updated merge_consecutive_messages function in /instructor/utils.py to handle the new message format.
Updated tests in /tests/test_utils.py to reflect these changes.

Generated with :heart: by ellipsis.dev

is this good to merge?

is this good to merge?

Yeah, I was waiting for it to be merged these days 😂


Populate topic/subtopic/measure tables

Summary
Populate the new data model tables by duplicating data currently held in the Page/MeasureVersion table. It's straightforward to fill in the Topic and Subtopic tables, as one row in the old table correlates to one row in the new tables. For the Measure table, though, we currently have this information duplicated in multiple rows in the old table. Therefore, this patch decides to use the information from the latest measure record only. The only column that has different data of note is the internal_reference. Using the latest internal reference feels like the sensible choice.
Ticket
https://trello.com/c/RJv8R7PC/1236

I think we could do all this using SQLAlchemy :trollface:

I'm wondering if this should be a data migration rather than an Alembic migration?  There are probably arguments either way, but there's nothing structural going on here, just copying from one place to another.

It's true there's nothing structural, but there will be later migrations that do depend on this data having been copied. So it feels better to enforce it as a real migration?
I think we discussed this before and came down on the side of doing required data migrations through alembic.


Option to disable ALT to move camera

I use ALT for push-to-talk and currently I'm unable to talk and play at the same time because of this.

that is a feature of the jagex client and not something we can control afaik

i hope to know if this option could be possible now?

it says here that it should've been just the middle mouse button and not the alt. hopefully this could be change so i can use alt instead of ctrl when i do ctrl + click to invert run mode. i find ctrl harder to press when doing high lvl pvms. and only being able to do so by remapping space bar as ctrl.


Support default export of render in Vite HMR wrapper

Fixes #586
It is a rough starting point inspired from ./anywidget/src/widget.js helpers, with warnings abridged.

Related to ease-of-testing (among other benefits) I throw in an idea: instead of using a long inline template, would it be worthwhile to extract it in a hmr.js file that assumes the existence of global.__anywidget_hmr_src, and just template a global.__anywidget_hmr_src= header ? The concatenation of hmr.js and header being then served by the plugin.

love the idea! Yes, the HMR stuff has just grown in complexity beyond an inline string. I think we could just find and replace a special string:
// hmr.js
const SRC = "__ANYWIDGET_HMR_SRC__";

import.meta.hot.accept(SRC, (newModule) => {
  // ...
});

export async function render({ model, el } ) {
  if (import.meta.hot.data.render == null) {
    let m = await import(SRC);
    // ...
  }
  // ...
}

And simply:
// vite/index.js
import * as fs from "node:fs";
import * as path from "node:path";
import * as url from "node:url";

// ceremony to get the filepath, in node>=v20 import.meta.dirname
let __dirname = path.dirname(url.fileURLToPath(import.meta.url));
let template = fs.readFileSync(path.resolve(__dirname, "hmr.js"), { encoding: "utf-8" });

then in load(id)
return template.replace("__ANYWIDGET_HMR_SRC__", id.split(":")[1]);

So I gave it a try. Daunted by the file loading subtleties I relied on the esbuild file loader. And i seemed that Vite's static analysis was puzzled by the SRC = "__ANYWIDGET_HMR_SRC__ indirection, so I had to inline the assigned string repeatedly instead. Tested locally of course 😇

Daunted by the file loading subtleties I relied on the esbuild file loader.

Interesting workaround! Unfortunately, we only use esbuild to generate the .cjs version of the package (i.e., so folks can require("@anywidget/vite") rather than import from their vite.config.js. We ship index.js to NPM directly for use in Node via ESM; that means it's the main entry point for the package and is not intended to be bundled.
The code snippet I shared should work:
import * as fs from "node:fs";
import * as path from "node:path";
import * as url from "node:url";

let __dirname = path.dirname(url.fileURLToPath(import.meta.url));
let template = fs.readFileSync(path.resolve(__dirname, "hmr.js"), { encoding: "utf-8" });

And i seemed that Vite's static analysis was puzzled by the SRC = "ANYWIDGET_HMR_SRC"

Ah, I guess that makes sense. Thanks for the workaround!

🤔 I will need to understand the matter better, but in the meantime reverted to your implementation.
I chose a different route in the first place because I now get this errors:

A build time warning: "import.meta" is not available with the "cjs" output format and will be empty
An error running vite serve from a test project: Identifier '__dirname' has already been declared

My vite.config.js uses import anywidget from '@anywidget/vite' and I have node_modules/@anywidget/vite -symlink-> path/to/local/repo/anywidget/packages/vite.
I have the impression that notwithstanding the import syntax, node loads the built dist/index.cjs. Hence the esbuild text loader approach worked for me even though I did not require('@anywidget/vite') in vite.config.js.

A little idea before the weekend: could we not trigger the builtin anywidget HMR mechanism in response to Vite HMR updates ?
The following snippet could be injected by a transform plugin just before export default { render }
if (import.meta.hot) {

    let SRC = "/index.js"; // "__ANYWIDGET_HMR_SRC__"
    let PORT = "5173";     // "__ANYWIDGET_HMR_PORT__"

    // Touch _esm on all active models
    async function refresh() {
	for (let m of import.meta.hot.data.models) {
	    m.set("_esm", `http://localhost:${PORT}${SRC}?t={Date.now()}`);
	}
    }

    let originalRender = render;
    render = async function ({model, el}) {
	import.meta.hot.data.models.add(model);
	return await originalRender({model, el})
    }

    // Register event handlers on first load only
    if (!import.meta.hot.data.models) {

	import.meta.hot.data.models = new Set();

	import.meta.hot.on('vite:beforeUpdate', (data) => {
	    for (let u of data.updates) {
		if (u.path === SRC) {
		    return refresh()
		}
	    }
	})

	// Accept HMR update to avoid full page reload
	import.meta.hot.accept((newModule) => {})

    }
}

Be that as it may, I wish you a nice weekend ;)

I have not forgotten about this! I've been busy working on #603 and just getting back to this. I'll try to give review and respond to your commends ASAP.

I adopted your suggestion, thanks for the clarification. I think my understanding of the matter is limited, though 🤔

I wonder if we can just go ESM-only. and forget the esbuild stuff. NodeJS supports require-ing ESM now, so I think we can move towards ESM-only plugin.

A little idea before the weekend: could we not trigger the builtin anywidget HMR mechanism in response to Vite HMR updates ?

The built-in anywidget HMR will not be enabled when using Vite. Built-in HMR only starts up if a file path is detected for _esm, and when you use vite you have a URL:
_esm = "http://localhost:5173/index.js?anywidget"

Unfortunately, I'm getting a weird console error with the plugin now:
TypeError: Failed to fetch dynamically imported module: http://localhost:5173/index.tsx?anywidget

when I use a dynamic import with Vite.

Thanks so much for the contribution! Will cut a release ASAP.

Thanks for your advice and explanation in the process of getting this merged, it was fun and instructive. 👍🏻


Allignment of assignment operators may produce hard to read code

Bug Description
Generally inserting extra white spaces to align = and => works quite well. There are many good examples of it in the WordPress Coding Standards. However the current settings for  maxPadding and maxColumn allow for edge cases that may make the code harder to read.
The tl;dr:

Having a lot of white space in the middle of a line of text makes it harder to read.
Having a lot of white space in the middle of all lines in a paragraph/block of text makes it much harder to read. This is due to the eyes not being able to follow the lines, and "connect" the left side with the right side of the same line.

Prior art: I think everybody has seen tables of content that list the chapters/sections on the left and page numbers on the right. Many of them have ........... connecting the chapter title to the page number. These dots allow the eyes to follow the lines easily. Example:

Of course a TOC may look like this:

But note how the space between the titles and the page numbers is quite shorter and there are blank lines after each entry. That makes it very easy to read.
Unfortunately after reformatting Core's code with the current default settings in WPCS, there are several edge cases like this:

If you try reading the above example a few times you will probably notice how it becomes increasingly harder to match the array keys to the values.
To fix
The default maxPadding  value for Generic.Formatting.MultipleStatementAlignment has to be changed from 40 to something like 10. This seems to be a good amount of white space that prevents the above edge case and fully matches all examples in the WordPress Coding Standards.
Unfortunately it seems there is another bug preventing setting of maxColumn to lower value. Testing with something like 20 doesn't seem to work.
Looking back at when maxPadding = 40 and maxColumn = 60 were chosen:

The value for maxPadding which I've chosen is arbitrary - similar to my notes about maxColumn in #1135 - and could probably use some scrutiny before deciding on the real number to use.

The sniff has been added to the Core ruleset with a maxColumn value of 60.
The 60 is arbitrary.

Additional Context (optional)
Looking at the PHP code in WPCS inself, the maxPadding value used there comes from Squiz and is 12 which is much better. See https://github.com/squizlabs/PHP_CodeSniffer/blob/master/phpcs.xml.dist#L110.
Tested Against develop branch?
[ * ] I have verified the issue still exists in the develop branch of WPCS.

There are several other edge cases that will get fixed/have better readability by changing the maxPadding and maxColumn values:

(Not really sure what's going on here...)

This looks like another bug. The alignment "breaks" the meaning of "parent" > "child" relation.

I understand that "personal preferences" may play a significant role here. Most of the above edge cases can be fixed by either inserting blank lines, or by excluding them from sniffs.
However I was really surprised of how much the long white spaces affected me when working on Core. Started seeing "ghost flies" in couple of hours and getting a headache in about 4 hours... Had to count how many rows from the top is the arg I needed, then move to the right and count again to find the value. Doing that few times is fine, doing it 50-60 is.... not.
Here is a small test to "experience" this first hand :)

Please read this code for about 10 minutes (that's a long time, I know). Try reading through it, then try some random lines. Then read couple of lines somewhere else and come back again.
Now read the values for hooks, dom, nux, keycodes and date. Do you find yourself trying to count the lines to be able to find the values?

I'm inclined to agree that the current rule adds too much whitespace in a lot of circumstances. As @azaozz described, it can be quite difficult to figure out which key goes with which value when there's a large gap caused by one or two really long keys.
That said, I'm not a fan of just heavily limiting Generic.Formatting.MultipleStatementAlignment as a solution. For example, doing that at the top of wptexturize() looks like this:
function wptexturize( $text, $reset = false ) {
	global $wp_cockneyreplace, $shortcode_tags;
	static $static_characters      = null,
		$static_replacements       = null,
		$dynamic_characters        = null,
		$dynamic_replacements      = null,
		$default_no_texturize_tags = null,
		$default_no_texturize_shortcodes = null,
		$run_texturize = true,
		$apos          = null,
		$prime         = null,
		$double_prime  = null,
		$opening_quote = null,
		$closing_quote = null,
		$opening_single_quote = null,
		$closing_single_quote = null,
		$open_q_flag          = '<!--oq-->',
		$open_sq_flag         = '<!--osq-->',
		$apos_flag = '<!--apos-->';

	// ...
}

The random mish-mash of indenting just looks messy. However, I think it can be easily cleaned up by adding line breaks to split up the indenting.
function wptexturize( $text, $reset = false ) {
	global $wp_cockneyreplace, $shortcode_tags;
	static $static_characters = null,
		$static_replacements  = null,
		$dynamic_characters   = null,
		$dynamic_replacements = null,

		$default_no_texturize_tags       = null,
		$default_no_texturize_shortcodes = null,

		$run_texturize = true,
		$apos          = null,
		$prime         = null,
		$double_prime  = null,
		$opening_quote = null,
		$closing_quote = null,

		$opening_single_quote = null,
		$closing_single_quote = null,

		$open_q_flag  = '<!--oq-->',
		$open_sq_flag = '<!--osq-->',
		$apos_flag    = '<!--apos-->';

	// ...
}

I think this works similarly well for arrays, too. Looking at your example from _WP_Editors::get_translation(), it would look something like this:
	private static function get_translation() {
		if ( empty( self::$translation ) ) {
			self::$translation = array(
				// Default TinyMCE strings
				'New document' => __( 'New document' ),
				'Formats'      => _x( 'Formats', 'TinyMCE' ),

				'Headings'  => _x( 'Headings', 'TinyMCE' ),
				'Heading 1' => array( __( 'Heading 1' ), 'access1' ),
				'Heading 2' => array( __( 'Heading 2' ), 'access2' ),
				'Heading 3' => array( __( 'Heading 3' ), 'access3' ),
				'Heading 4' => array( __( 'Heading 4' ), 'access4' ),
				'Heading 5' => array( __( 'Heading 5' ), 'access5' ),
				'Heading 6' => array( __( 'Heading 6' ), 'access6' ),

				/* translators: block tags */
				'Blocks'       => _x( 'Blocks', 'TinyMCE' ),
				'Paragraph'    => array( __( 'Paragraph' ), 'access7' ),
				'Blockquote'   => array( __( 'Blockquote' ), 'accessQ' ),
				'Div'          => _x( 'Div', 'HTML tag' ),
				'Pre'          => _x( 'Pre', 'HTML tag' ),
				'Preformatted' => _x( 'Preformatted', 'HTML tag' ),
				'Address'      => _x( 'Address', 'HTML tag' ),

				// ...
			);

			// ...
		}

		// ...
	}

Yep, the fixed examples look great! :)
I know, it adds another (manual) step but thinking the results are a lot better and are worth it. Also these edge cases are not that common, and having to manually split the affected code blocks is not going to be a lot of work.
To proceed thinking it would be better to change the setting to the default value from Squiz: https://github.com/squizlabs/PHP_CodeSniffer/blob/master/phpcs.xml.dist#L110 including triggering an error when the padding is exceeded. This will detect and throw errors for the current edge cases. Then the blocks can be split and phpcs run again to adjust the padding. In the future will need to look through the changes before committing to make sure the mess as in the first example above doesn't happen.
Alternatively can leave the setting as-is. Will need to look through the code before every commit and determine "by eye" when the white space is too much, then split the code blocks and rerun phpcs to adjust the padding. Sounds like this would be harder.
Ideally there would be a way to throw a warning when the MultipleStatementAlignment rule hits the maxPadding value while trying to align the equal signs. Then we'll know where to look :)


Make up your mind about release status

That's the second time in a row my computer recieved a stable release update that got reverted to pre-release status soon after.
Beta testing is for users who choose to do that, not by forcing it to users like me who use the computer in a production environment.

While I love the intentions, the idea and the practical usage of this project - we are dependant on it daily- I get a bit scared looking at the issue list - will next update break my environment in unfixable ways or not. After next stable release I wish the maintainers would take a crunch on a few stabiltity releases forward, just focusing on closing and/or fixing the long issues list.
One reasonable take on that for them would be to ask reporters of issues reported for older versions of WSL to update to latest stable and see if the problem persists, and add an autoclose to the bug if no feedback in let's say a month.


chore/clean

WIP
WIP
WIP
feat: pretty printing for debugging
WIP
feat: all tests passing!
chore: prepare package.json
chore: run audit fix
chore: cleanup by removing unecessary logging and comments
chore: add docs
chore: remove old main file
chore: add keyword

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


@all warnings feature could use some improvement

We have this great feature that warns you if you try to @-all mention a lot of people.  However, it could use some work.  Right now, the way that it actually works is the moment you use the typeahead to enter an @**all** type thing, it pops up a yellow warning with a "YES" button you need to click; and if you try sending a message containing an @all type mention without clicking the YES, it pops up a red message as well.  This should be improved in these ways:

Probably we shouldn't pop up the warning until you actually try to send the message
We should eliminate the red warning
The yellow warning should have a nicer button style for "YES" and say something more like "Yes, send".
The text should be clearer that the thing we're doing is mentioning all those users.
We should probably set a stream size threshhold, like 15 people, and streams smaller than that probably don't need the warning.

I want to do it.

This is fixed now, yay! :)


[add-resource] New Plugin: Sender

I would like to add my new plugin to the Grav Repository.
Here are the project details: aricooperdavis/grav-plugin-sender
It's a plugin that adds a form action that uses the Sender.net API to add subscribers to a Sender.net account, so it's useful for a "sign-up to my newsletter" type thing.

Sorry for the delay, this has been added to GPM.


Update minimum rust stable version

cc @EPashkin @sdroege

👍 for all in this batch

+1 for all in this batch

Completely agreed :)


Documenting of code, and minor code changes

I read your code line-by-line and added documentation. Hopefully I interpreted everything correctly!
I made some minor edits to play_one_episode. I commented out some unused definitions, and ran the files through a PEP8 linter to clean up the style. I am pretty confident everything should work, but I can't test whether I broke anything without training data.
Finally, I deleted the Atari code at the end of expreplay.py

I just added some test data and a pre-trained model. I hope this ease testing any new changes. Thanks!

Ok, I carefully merged your changes and tested that everything works with your sample data. You can review my changes side-by-side here. The most aggressive change is deleting 2 unused Class definitions.

e236882 fixes an error due to a train=False kwarg being renamed to task=False in a recent commit

I checked the changes and did few test, it seems to be working fine too. The changes are merged now. Thank you for the contribution here! :)


feat: don't request Solc JSON AST unless absolutely necessary

The Solc JSON AST output is very expensive to both serialize on the compiler's side, and deserialize on our side due to its very nested nature and generally big size.
Helps especially on hot starts thanks to reducing time to deserialize all the artifacts.
We currently use the AST in:

coverage
flatten
inline test config (NatSpec)

Note that I'm using debug profile with hyperfine so it will be even faster.
Default forge init project:

Solmate:

sablier/v2-core:

out before: 144M
out after:  106M

cc @0xalpharush for thoughts on how this affects slither

Can we get a comparison for release mode compilation time improvements due to this on a large repo? e.g. Optimism contracts

Can we get a comparison for release mode compilation time improvements due to this on a large repo? e.g. Optimism contracts

@gakonst
The overwhelming majority of the time is spent in solc so release mode on our side won't do much here.
It's 2-3% faster on clean builds, up to 5-10x for sablier/v2-core (absolute time save of about 2.5s for both). Note that time saved is proportional to amount of total artifacts.

I ran foundryup -b dani/drop-ast and it does make slither not work since the ASTs are missing. I think it is fine to drop from forge build but I'd prefer forge build --build-info (the hardhat artifact style) to be backwards compatible ofc. Otherwise, we'd have to cut a release and handle the case where people are not on this version of foundry yet


Reword the 'features' page

Remove 'distributing content', add 'authentication' instead
Trim content size

Part of https://github.com/2i2c-org/2i2c-org.github.io/pull/42

this is great, one minor comment but I'm +1 other than that

@choldgraf fixed!

merged!


Update README.md

Fix broken logo link
Updates link to website and email
Adds Instagram

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.263%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1358

Relevant Lines:
1382

💛  - Coveralls


Comments

People may want to comment on tasks, issues, documents, etc.

[ ] Find open-source applications with commenting feature
[ ] Determine if any existing Meteor project may serve as a partnership, model, etc
[ ] Consider how to implement a commenting feature within our application

There is a Comments package that might be useful here.


Does this interface expose corenet.Dial?

Referring to https://github.com/ipfs/examples/tree/master/examples/api/service
I was wondering if there was any way to connect to a certain peer and receive a stream via a client library (js-ipfs-api) as with the corenet.Dial function in Go?

Hi @prashcr. On the ipfs-core API level, no, we only expose the swarm API which dials to other nodes but doesn't return the pipe, it gets used by IPFS. However, libp2p does expose that feature and libp2p is exposed in js-ipfs (ipfs.libp2p).
See https://github.com/ipfs/js-libp2p-ipfs
Are you looking to accomplish this in Go or JavaScript?

I'd like to accomplish it in JavaScript. Hmm, the module seems to be what I'm after, thanks!


Missing info about Natura codes and application specific parameters

Hi,
there is missing information how to setup application specific parameters for Vendor Invoice (IT)
It's on customer electronic invoice, but even there is no info about minimum setup for blank and not blank for Others lookup result.
Please add the details for vendor invoice page.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94047218-6b10-b23b-d2c7-0ecf90f5de0e
Version Independent ID: 94047218-6b10-b23b-d2c7-0ecf90f5de0e
Content: Vendor electronic invoices - Finance | Dynamics 365
Content Source: articles/finance/localizations/emea-ita-vend-e-invoices.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @mrolecki
Microsoft Alias: mrolecki

Bug 744554 has been logged to address this issue.

@mkowalka - Thank you for the feedback. This article has been updated and the changes will go live later today.