Update build-unix.md

added berkley 4.8 to the required packages

Apologies for the delayed reply. I don't find this needed with a fresh Ubuntu 20.04.  Please reopen with specific OS if issue persists. Much Thanks!


Update code generation to match with development version of Blawx

the upcoming release of Blawx changes the way it encodes boolean objects. It may be necessary to make changes to how Docassemble reports them to match.

Can you expound a little more on what changes would be needed?

The main blawx project has gone from using "true" and "false" in Flora-2 to code to represent the boolean values to using "\true" and "\false", which is the standard usage in Flora-2. The docassemble-blawx code may still be using "true" and "false" when converting the interview data into a JSON structure to send to the API. If it is, we may need to fix that inside the docassemble-blawx code, or perhaps in the json2f2.py code in the main project. It's not totally clear to me, yet, so this issue is a reminder that if I run into problems that might be where to look.

Ok. Thanks!

Yeah, took a closer look and the issue is in blawx's json2f2.py file, so I'm closing here and recreating this issue there.


Uncaught TypeError: Super expression must either be null or a function, not undefined

why i can't use it,do i write error react-router  package  version?, could you help me

react-router-cache-router 不支持 react-router v6


data: project addition by akshaya-hub

Add a new project to the list
I want to add a new project to the list
Code of Conduct

[x] I agree to follow this project's Code of Conduct

Completed. Thanks for your contributions 🎉 ❤


feature/dashboard [LDA FE]

Move the components into the dashboard, specifically story/pages from the other issue.

Recently merged the Story book library branch, there will be a new enhancement feature with story book library


[good first issue] Pandas Readers & Writers

Is your feature request related to a problem? Please describe.
We need to add more Pandas Readers & Writers (Savers & Loaders in our internal parlance).
Describe the solution you'd like
We need to have readers & if appropriate, writers, covering:

[ ] pandas csv (need to expose all params)
[ ] pandas pickle
[ ] pandas table
[ ] pandas fwf
[ ] pandas excel
[ ] pandas json
[ ] pandas html
[ ] pandas xml
[ ] pandas hdf
[ ] pandas feather (need to expose all params)
[ ] pandas parquet (need to expose all params)
[ ] pandas prc
[ ] pandas sas
[ ] pandas spss
[ ] pandas sql*
[ ] pandas gbq
[ ] pandas stata

We should cover I/O as listed here.
Additional context
We need to start building wrappers around the common ways people will want to save/load data. That way they'll have off the shelf ways to get onto Hamilton easily.
If you're interested in contributing
If you are interested in contributing, picking up one of the above should be straightforward.

Ask for one, and we'll assign it.
We'll create an issue for you.
We'll then work with you on that issue.

In terms of effort, for an example of a desired class, see this code. It basically involves:

Reading the subsequent documentation.
Creating the right class.
Creating some tests for it.
Creating an example to put into our examples repository.

Hey there, I would love to give this a go with one of the pandas i/o methods. I'm new to contributing on GitHub so I appreciate the cooperative work.

Hey there, I would love to give this a go with one of the pandas i/o methods. I'm new to contributing on GitHub so I appreciate the cooperative work.

@benhhack
That would be great! Hopefully there are enough examples to get you started -- let us know what you need above that. No judgement if you use gpt-* to help you out as well -- I've found its helpful for translation/repetetive tasks like this.

Hey there, I would love to give this a go with one of the pandas i/o methods. I'm new to contributing on GitHub so I appreciate the cooperative work.

@benhhack yeah thanks for offering to help! Just to make sure this indeed is the right issue to get started with, what's your comfort level with python & pandas?

Quite familiar with using both, you can check out my repos to see my level. Never really done anything like this before though, so I'm quite interested to see how it goes.

Quite familiar with using both, you can check out my repos to see my level. Never really done anything like this before though, so I'm quite interested to see how it goes.

Cool. I would take a look at https://pandas.pydata.org/docs/reference/io.html, pick one, and then we can claim that here and create an issue to move discussion to. Which one would you like?

Quite familiar with using both, you can check out my repos to see my level. Never really done anything like this before though, so I'm quite interested to see how it goes.

Cool. I would take a look at https://pandas.pydata.org/docs/reference/io.html, pick one, and then we can claim that here and create an issue to move discussion to. Which one would you like?

Looking at that they all seem equally vague, haha. You can assign me to whichever you'd feel is most appropriate/best to start on.

Looking at that they all seem equally vague, haha. You can assign me to whichever you'd feel is most appropriate/best to start on.

Sure. @benhhack mind commenting on #292 so I can assign it to you?

Looking at that they all seem equally vague, haha. You can assign me to whichever you'd feel is most appropriate/best to start on.

Sure. @benhhack mind commenting on #292 so I can assign it to you?

Have commented :))

@benhhack https://github.com/DAGWorks-Inc/hamilton/issues/292 is open for you, if you wanted to comment on it.

@skrawcz I've taken a look at the other tickets and I could try the XML read and write class. The classes shouldn't be too difficult but I will reach out if I need help with the testing.
Thanks
Jordan

@skrawcz I've taken a look at the other tickets and I could try the XML read and write class. The classes shouldn't be too difficult but I will reach out if I need help with the testing.
Thanks Jordan

@JoJo10Smith if you wanted to comment on https://github.com/DAGWorks-Inc/hamilton/issues/352 I can assign it to you. Thanks!

@bryangalindo mind commenting on https://github.com/DAGWorks-Inc/hamilton/issues/355 so I can assign it to you. I missed doing that earlier, sorry about that.

@skrawcz I could take the HTML read and write class next.
Thanks
Jordan

@skrawcz I could take the HTML read and write class next.
Thanks Jordan

@JoJo10Smith please comment on #369  :)

@skrawcz i can start working on pandas gbq!

@skrawcz i can start working on pandas gbq!

Please comment on https://github.com/DAGWorks-Inc/hamilton/issues/375 -- note this one will require a GCP account I think.

@skrawcz I can take on Stata next.

@skrawcz I can take on pandas Stata next.

@JoJo10Smith please comment on #377

@skrawcz I'll take Feather next.
Thanks
Jordan

@skrawcz I'll take Feather next.
Thanks Jordan

https://github.com/DAGWorks-Inc/hamilton/issues/384 🙇 .

Hey skrawcz! I would like to work on the Panda Table I have already made many pandas dataframes and would like to work on this project.

@skrawcz can I take 'pandas parquet'?

thanks @flaviassantos you should be all set. If you have questions put them in issue https://github.com/DAGWorks-Inc/hamilton/issues/406.
@149189 please comment on https://github.com/DAGWorks-Inc/hamilton/issues/407 to have me assign that to you. If have questions we can have the conversation there.

@skrawcz I'll take csv next
Thanks
Jordan

@JoJo10Smith https://github.com/DAGWorks-Inc/hamilton/issues/409 is up. thanks!

Created Spss for https://github.com/DAGWorks-Inc/hamilton/issues/813


Recombine audio

Topic: recombine_audio

Reviews in this chain:
└https://github.com/riffusion/riffusion/pull/78 Recombine audio

#
head
base
diff
date
summary

0
e2e4f0f3
8e87c133
diff
Jan 8 20:12 PM
2 files changed, 19 insertions(+), 10 deletions(-)


do you have a very very simple usage doc ?

sorry , your demo is so complex !
not good for stupid users , like me
i just want to know how to use these 2 icons in the same code file,
like
import {Icons} from 'react-native-vector-icons'
<Icons name='EvilIcons|ei-sc-facebook' size={20}>
    <Text>Login with Facebook</Text>
</Icons>
<Icons name='Octicons|octicon-alert' size={20}>
    <Text>octicon-alert</Text>
</Icons>

but ERROR!
Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. check the render method of 'XXX'

why icon so small ,and text so big ?
import Icon from 'react-native-vector-icons/EvilIcons'

<TouchableOpacity onPress={this.showMenu.bind(this)}>
                            <Icon name='sc-facebook' size={28} color="white" style={{top:260,padding:10,backgroundColor:'blue',justifyContent:'center',alignItems:'center',flex:1}}>
                                <Text>
                                    Login with facebook
                                </Text>
                            </Icon>
                        </TouchableOpacity>

The text is small because you have to give a fontSize to the Text.
here's an example - hope this helps:
<Text
  style={styles.text}
>
  <Icon
    name="search"
    style={styles.icon}
  />
  Search
</Text>

const styles = StyleSheet.create({
  text: {
    fontSize: 19
  },
  icon: {
    fontSize: 19
  }
});

@281330 thank you very much ! wonderful work !

@12343954 How did you fix:  Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. check the render method of 'XXX'

@CodeLuca
the only way to use it, like this :
import Icon from 'react-native-vector-icons/EvilIcons'
import Icon2 from 'react-native-vector-icons/FontAwesome'
<Icon2 name={comment.FIsLiked?'thumbs-up':'thumbs-o-up'} size={20} style={{color:'gray'}} />

the icon name is only a string ，such as 'thumbs-up', 'thumbs-o-up'
Refer to these websites：http://fontawesome.io/icons/

@12343954 I dont know how but I fixed my issue, thanks anyways :)


Summarize Installed Software Data

i have just reviewed this paricular maintenance task and saw that this is to summarize software data which got collected via the hardware inventory for the SMS_InstalledSoftware Asset inteligence class! i couldn´t find a link to software inventory as stated in the description of that maintenance task!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73746b8f-0bb3-a02c-fe91-85395fb33bdd
Version Independent ID: a7cee2bc-0b6e-e740-238b-9267c3cae370
Content: Reference for maintenance tasks - Configuration Manager
Content Source: sccm/core/servers/manage/reference-for-maintenance-tasks.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @mestew
Microsoft Alias: mstewart

Hi @chwunder, thanks for the feedback. I think what you're asking is about more information on this functionality of asset intelligence. Which means the link we have on this page for this task (currently to hardware inventory) isn't useful. The proper link here should be to the article to Configure Asset Intelligence, which has more information on this topic.

@aczechowski Hi Aaron, appreciate your feedback. in fact, i have actually changed it to hardware inventory. Before there was a link to software inventory which was wrong in my opinion. This particular maintenance task does actually summarize asset intelligence data which is collected by the hardware inventory. So i think the reference to hardware inventory does make sense. Because this is actually the place where to enable and disable such asset intelligence classes!
I have further mentioned the word asset intelligence in the description, so people know what functionality is further involved into this topic! love the collaboration here ;-)


update 0xgen.toml for testnet-15

Dear Bengt,
i am already a genesis validator successfully running the previous testnets, i had been active, up & running (pre-voting, signing) throughout the testnet14
my previous PRs:
https://github.com/anoma/namada-testnets/pull/1569 https://github.com/anoma/namada-testnets/pull/1014 https://github.com/anoma/namada-testnets/pull/902
https://github.com/anoma/namada-testnets/pull/810
https://github.com/anoma/namada-testnets/pull/522
Thanks & Regards
Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

closing due to CI checks

re-opening the PR

Dear @bengtlofgren
i did fix worflow and filename errors, if you look at the stats I have been successfully running the testnet-14 and previous testnets, I would really appreciate if you include me in testnet-15 as well.
Thanks.


[Implement Sniff] Check that only one - or at most two - text-domains are used in the theme

Rule type:
Error
Rule:
From what I can see, there are actually 5 distinct i18n related rules which may need sniffs - this issue covers the third item on the list.

All theme text strings are to be translatable. (#33)
Include a text domain in style.css (#34)
Use a single unique theme slug – as the theme slug appears in style.css. If it uses a framework then no more than 2 unique slugs.
Can use any language for text, but only use the same one for all text. (#33)
Correct usage of the WP i18n functions. (#31)

Refs:
https://make.wordpress.org/themes/handbook/review/required/#language
https://make.wordpress.org/themes/handbook/review/required/theme-check-plugin/#additional-checks
This requires a slightly different implementation, the existing WordPress.WP.I18n sniff can check whether all i18n functions use the same text domain. For that check, the text domain  - at this moment - will have to be provided via the phpcs config file or programmatically. I suggest this text domain injection into the PHPCS configuration will be implemented in the Theme Check wrapper which will call PHPCS in order to enable this check.
Note: it is being investigate upstream whether the text-domain can be determined from the files. If that would be implemented, no further action would be needed for the Theme Check plugin.
Currently the WordPress.WP.I18n sniff only checks against the one text domain and does not keep track of the found text domains (other than reporting them in the error message)
Theme check file covering this rule:
https://github.com/Otto42/theme-check/blob/master/checks/textdomain.php
Decision Needed:
Request for decision: How should we deal with extra (allowed) text-domains ? Is there a white-list of extra text-domains related to frameworks which can be checked against ?
To do:

[ ] Potentially implement passing the text domain to PHPCS in Theme Check.
[ ] Potentially extend the existing WordPress.WP.I18n sniff to keep a count of all encountered text-domains and report if the count is more than two.

Request for decision: How should we deal with extra (allowed) text-domains ? Is there a white-list of extra text-domains related to frameworks which can be checked against ?

I'm in favor of creating a whitelist of allowed extra textdomains (or textdomains to ignore).  I'd be happy to gather that list if the team agrees.
I think that's a far better approach.  And, we can always add new textdomains to the list if/when another framework pops up that needs to be accounted for.

Here's the current list of exceptions (Twenty* textdomains copied from TC).  I've sent out a few DMs to known framework authors to get their feedback.
var $exceptions = array(

	// Core themes
	'twentyten',
	'twentyeleven',
	'twentytwelve',
	'twentythirteen',
	'twentyfourteen',
	'twentyfifteen',
	'twentysixteen',
	'twentyseventeen',
	'twentyeighteen',
	'twentynineteen',
	'twentytwenty',

	// Frameworks
	'hybrid-core'
);

@justintadlock Did you get any feedback from others?

Here's a possible list that aristath and dovy help put together.  I do not know whether these frameworks properly handle their own textdomains and/or language files when included in a theme though.  That'd be the only reason we'd want to whitelist them.
redux-framework
tgmpa
nhp
smof
optiontree (option-tree?)
vp_textdomain
ACF
titan-framework
kirki
upthemes
options-framework

We'd also like to have our framework added to this list: "cryout" that we use in all our currently live themes.
Seeing the list Justin submitted I'd also have a far-fetched proposal, at least for the theme specific frameworks (tgmpa is not really a theme framework, is it?). They should all have a standard naming format (something like "name-framework") so it would be easier to identify and recognize when editing or reviewing themes.
Also, something like "options-framework" seems far too generic, like having a "theme" text domain. And what if somebody uses one of these "whitelisted" textdomains in their themes for other purposes, unrelated to the frameworks. How will Theme Check sniff this out?
And on the "no more than 2 theme domains" rule. What if you're using a theme framework and tgmpa for suggesting plugins? You'll be forced to either let one go or rename it, kind of missing the whole point of using frameworks and/or WordPress translations.

We do not need to whitelist tgmpa as the generator automatically changes it to the themes slug.
smof has been deprecated and is not supported any more so I would against whitelisting it.
I would be against the vafpress-framework as it is a Theme Options Builder, Metaboxes Builder and Shortcode Generator Builder
option-tree, Options Framework and upthemesdo not support the customizer so they are out of the question
I do not know what nhp is.
If we allow ACF then we would need to allow cmb2 too.

I do not know whether these frameworks properly handle their own textdomains and/or language files when included in a theme though. That'd be the only reason we'd want to whitelist them.

We must have a requirement that the framework needs to fulfill to be whitelisted. e.g. "The framework must handle the text domain correctly and include translation files."

And on the "no more than 2 theme domains" rule. What if you're using a theme framework and tgmpa for suggesting plugins?

With a whitelist I expect we can will not need a limit on the number of text domains.

Here's another one: mte - it's our own framework, not published yet, but we've been silently working on a it for our own themes (will be using the Customizer API)

We must have a requirement that the framework needs to fulfill to be whitelisted. e.g. "The framework must handle the text domain correctly and include translation files."

I wanted to touch on this because there are 2 separate methods for making this work.

The framework must load its own textdomain with load_textdomain() and include the translation files within it.

The framework must load its own textdomain with load_textdomain() but merge the strings with the themes.  Method for doing this: https://gist.github.com/justintadlock/7a605c29ae26c80878d0

If the framework is not employing one of these two methods (can't think of any others), translations will not work.

Here's another one: meta-box

@cristianraiber mte seems a bit short. You need to show that it is handling translations to be included.
@rinkublog Please could you give a bit more information like where the framework can be found and show that it is handling translations.

@grappler  here is plugin https://wordpress.org/plugins/meta-box/ and i think here it is handling translation https://plugins.svn.wordpress.org/meta-box/trunk/inc/core.php

@grappler - you're right; how about epsilon-framework. I'll take care of the translations part as per @justintadlock suggestions above.

Yes, that makes it clear what it is.

@grappler - great, thanks!

We'd like to have added to white list our Cherry Framework with cherry-framework text-domain.

Any news about this guys? Theme upload faiks because of duplicate text-domains

@cristianraiber If you are running your own checks you can define the text domains. This is explained here: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#internationalization-setting-your-text-domain
If you are talking about the new Theme Sniffer plugin, then you can contribute a file that will always exists in your framework and that we can check exists.
https://github.com/WPTRT/theme-sniffer/blob/master/inc/admin.php#L220-L228

@grappler - makes sense re. the new Theme Sniffer plugin, but I was under the impression that both theme checks will exist side by side... How do I get our text-domain approved in both?

@cristianraiber I don't think Theme Check has  a text-domain whitelist. For Theme Sniffer you just make a pull request.

Just noting that I've confirmed epsilon-framework will work and can be white-listed.

I think that prefix all globals sniff covers the use-case of multiple text domains.
@jrfnl @justintadlock can you confirm this? If it's the case, we can close this issue 🙂

I think that prefix all globals sniff covers the use-case of multiple text domains.

Nope, different sniff, not the same thing.


feat: skip e2e based off build tags

What this PR does / why we need it:

Conditionally skips e2e tests if no or_e2e build tags are found.

JIRA ID: XX-XX

Notes for your reviewer:

:tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Example code provided does not compile :(

When I copy and paste the examples, the examples do not compile, here is my toml file:
[dependencies]
futures = "0.1.17"
hyper = "0.11.22"
pretty_env_logger = "0.2.2"
tokio = "0.1.3"
All I ever did was choose the wrong dependencies I guess?
https://github.com/hyperium/hyper/blob/5db85316a10d0b7bdd36524d85a746a23bd10190/examples/web_api.rs#L1
error[E0599]: no associated item named GET found for type hyper::Method in the current scope
--> main.rs:32:15
|
32 |             (&Method::GET, "/") | (&Method::GET, "/index.html") => {
|               ^^^^^^^^^^^
error[E0599]: no associated item named GET found for type hyper::Method in the current scope
--> main.rs:32:37
|
32 |             (&Method::GET, "/") | (&Method::GET, "/index.html") => {
|                                     ^^^^^^^^^^^
error[E0599]: no associated item named GET found for type hyper::Method in the current scope
--> main.rs:36:15
|
36 |             (&Method::GET, "/test.html") => {
|               ^^^^^^^^^^^
error[E0599]: no associated item named POST found for type hyper::Method in the current scope
--> main.rs:55:15
|
55 |             (&Method::POST, "/web_api") => {
|               ^^^^^^^^^^^^
error[E0061]: this function takes 0 parameters but 1 parameter was supplied
--> main.rs:34:60
|
34 |                 Box::new(futures::future::ok(Response::new(body)))
|                                                            ^^^^ expected 0 parameters
error[E0308]: mismatched types
--> main.rs:38:56
|
38 |                 let client = Client::configure().build(&self.0);
|                                                        ^^^^^^^ expected struct tokio_core::reactor::Handle, found struct tokio::reactor::Handle
|
= note: expected type &tokio_core::reactor::Handle
found type &tokio::reactor::Handle
error[E0599]: no function or associated item named builder found for type hyper::Request<_> in the current scope
--> main.rs:39:27
|
39 |                 let req = Request::builder()
|                           ^^^^^^^^^^^^^^^^
error[E0599]: no associated item named POST found for type hyper::Method in the current scope
--> main.rs:40:29
|
40 |                     .method(Method::POST)
|                             ^^^^^^^^^^^^
error[E0599]: no function or associated item named wrap_stream found for type hyper::Body in the current scope
--> main.rs:47:32
|
47 |                     let body = Body::wrap_stream(web_res.into_body().into_stream().map(|b| {
|                                ^^^^^^^^^^^^^^^^^
error[E0599]: no method named into_body found for type hyper::Response in the current scope
--> main.rs:47:58
|
47 |                     let body = Body::wrap_stream(web_res.into_body().into_stream().map(|b| {
|                                                          ^^^^^^^^^
|
= help: did you mean set_body?
error[E0277]: the trait bound [u8]: std::marker::Sized is not satisfied
--> main.rs:47:89
|
47 |                     let body = Body::wrap_stream(web_res.into_body().into_stream().map(|b| {
|                                                                                ^ [u8] does not have a constant size known at compile-time
|
= help: the trait std::marker::Sized is not implemented for [u8]
= note: all local variables must have a statically known size
error[E0061]: this function takes 0 parameters but 1 parameter was supplied
--> main.rs:52:35
|
52 |                     Response::new(body)
|                                   ^^^^ expected 0 parameters
error[E0599]: no function or associated item named wrap_stream found for type hyper::Body in the current scope
--> main.rs:57:28
|
57 |                 let body = Body::wrap_stream(req.into_body().into_stream().map(|chunk| {
|                            ^^^^^^^^^^^^^^^^^
error[E0599]: no method named into_body found for type hyper::Request in the current scope
--> main.rs:57:50
|
57 |                 let body = Body::wrap_stream(req.into_body().into_stream().map(|chunk| {
|                                                  ^^^^^^^^^
|
= help: did you mean set_body?
error[E0277]: the trait bound futures::Future<Item=hyper::Response, Error=hyper::Error> + 'static: std::marker::Send is not satisfied
--> main.rs:46:17
|
46 | /                 Box::new(web_res_future.map(|web_res| {
47 | |                     let body = Body::wrap_stream(web_res.into_body().into_stream().map(|b| {
48 | |                         Chunk::from(format!("before: '{:?}'after: '{:?}'",
49 | |                                             std::str::from_utf8(LOWERCASE).unwrap(),
...  |
52 | |                     Response::new(body)
53 | |                 }))
| |___________________^ futures::Future<Item=hyper::Response, Error=hyper::Error> + 'static cannot be sent between threads safely
|
= help: the trait std::marker::Send is not implemented for futures::Future<Item=hyper::Response, Error=hyper::Error> + 'static
= note: required because of the requirements on the impl of std::marker::Send for std::ptr::Unique<futures::Future<Item=hyper::Response, Error=hyper::Error> + 'static>
= note: required because it appears within the type std::boxed::Box<futures::Future<Item=hyper::Response, Error=hyper::Error> + 'static>
= note: required because it appears within the type hyper::client::FutureResponse
= note: required because it appears within the type futures::Map<hyper::client::FutureResponse, [closure@main.rs:46:45: 53:18]>
= note: required for the cast to the object type futures::Future<Item=hyper::Response, Error=hyper::Error> + std::marker::Send
error[E0061]: this function takes 0 parameters but 1 parameter was supplied
--> main.rs:62:60
|
62 |                 Box::new(futures::future::ok(Response::new(body)))
|                                                            ^^^^ expected 0 parameters
error[E0599]: no function or associated item named builder found for type hyper::Response<_> in the current scope
--> main.rs:66:46
|
66 |                 Box::new(futures::future::ok(Response::builder()
|                                              ^^^^^^^^^^^^^^^^^
error[E0599]: no associated item named NOT_FOUND found for type hyper::StatusCode in the current scope
--> main.rs:67:54
|
67 |                                              .status(StatusCode::NOT_FOUND)
|                                                      ^^^^^^^^^^^^^^^^^^^^^
error[E0599]: no method named serve_addr found for type hyper::server::Http<_> in the current scope
--> main.rs:83:33
|
83 |         let serve = Http::new().serve_addr(&addr, move || Ok(ResponseExamples(handle.clone()))).unwrap();
|                                 ^^^^^^^^^^
error: aborting due to 19 previous errors
error: Could not compile sync.
Life is but tragedy, an eternal struggle against the forces of nature.

The master branch is now 0.12.x, a work-in-progress. It does not match the release 0.11.22 version.
You can view the examples in https://github.com/hyperium/hyper/tree/0.11.x, and https://hyper.rs/guides will always use the current release version.

@seanmonstar Thank you, that solved my problem, I'm now using these Cargo.toml file:
[dependencies]
futures = "0.1.17"
hyper = "0.11.22"
pretty_env_logger = "0.2.2"
tokio-core = "0.1.15"
and that seems to have solved the problem, Thank you for your help!


Container ports in https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-interactive/

I'm new in kubernetes and i'm trying to learn by doing the tutorials posted on the official documentation. In the module: https://kubernetes.io/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro/ we created a deployment and successfuly complete all the tasks. In the next module (https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-interactive/ ) apparently takes the previous step to work from there, but the command curl http://localhost:8001/api/v1/namespaces/default/pods/$POD_NAME/proxy/ needs to have a port mapping from the container and as this moment, there is nothing in the tutorial related to that. I'm trying to do all the tasks using minikube on my local machine and at this point i'm getting: Error trying to reach service: 'dial tcp <IP_ADDRESS>:80: connect: connection refused'. Something is missing from the lessons....
Any helpm would be appreciated ...
thanks in advance..

Duplicate of #18079 There is a solution there

/close
as a dup


Add go module support and LICENSE file

This small PR adds go module support and clarifies the license

sorry for ignoring -- i missed the notification on this!
LGTM


10 second edit/refresh cycle for Android device

I just measured 10 second edit/refresh cycle times for the Flutter starter app, using my nexus 5 device, from Atom.  (make a change to some text, hit Cmd-R)
The high end of an edit/refresh cycle is 3 seconds, but we should aim for a path to get us to <= 1 second for any chance to code (and even assets).
Ideally, the developer makes a change to their code, hits Cmd-R, and by the time they pick up their phone, the view has refreshed to the changes, and displaying the previous view. (The developer shouldn't have to work their way back into the view/state they were testing/developing.)
Thanks!

We might want to file a side issue to measure our edit/refresh cycles, too.
cc @devoncarew

More research. This seems to be Atom specific.
From the command line, I'm seeing consistent 5 second refreshes.
~/flutter/testme2 $ time flutter start --trace-startup
Starting lib/main.dart on Nexus 5...

real	0m5.258s
user	0m2.171s
sys	0m0.496s

But, from Atom and Cmd-R, I'm seeing consistent 10 second refreshes.

My understanding is we also do extra work if you have an android/AndroidManifest.xml vs. not.

@sethladd, flutter start will exit sooner if you don't pass the --start-paused flag. If you do, it'll wait until there's something listening to the observatory port on the device. This'll take a few more seconds.

From atom, I'm seeing a pretty consistent 5.7-5.8 seconds:
[5649 ms] - Finished run command.

flutter start will exit sooner if you don't pass the --start-paused flag.

Debugging seems to always be on for me. A brand-new app has debug: true in main.yaml.

Here's my verbose timing from Atom/Cmd-R:
flutter start --no-checked --debug-port=16217 --start-paused --device-id 031462ee213e73b9 --verbose • flutter logs
testme2/ • debug
[  37 ms] - Using Android SDK at /Users/sethladd/homebrew/opt/android-sdk.
[  39 ms] - [/Users/sethladd/homebrew/opt/android-sdk, SDK version 23, build-tools 23.0.2]
[  84 ms] - xcodebuild -version
[1176 ms] - Xcode 7.2
Build version 7C68
[1183 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb devices -l
[1211 ms] - List of devices attached
031462ee213e73b9       device usb:337838080X product:hammerhead model:Nexus_5 device:hammerhead
[1250 ms] - which idevice_id
[1259 ms] - /Users/sethladd/homebrew/bin/idevice_id
[1259 ms] - /Users/sethladd/homebrew/bin/idevice_id -l
[1269 ms] - /usr/bin/xcrun simctl list --json devices
[1357 ms] - Downloading toolchain.
[1402 ms] - /usr/bin/defaults read /Users/sethladd/flutter/testme2/ios/Info CFBundleIdentifier
[1560 ms] - com.yourcompany.testme2
[1562 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb devices -l
[1595 ms] - List of devices attached
031462ee213e73b9       device usb:337838080X product:hammerhead model:Nexus_5 device:hammerhead
[1606 ms] - /Users/sethladd/homebrew/bin/idevice_id -l
[1619 ms] - /usr/bin/xcrun simctl list --json devices
[1718 ms] - Running build command.
[1727 ms] - APK up to date. Skipping build step.
[1727 ms] - Running stop command.
[1729 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell am force-stop com.yourcompany.testme2
[2744 ms] - Running install command.
[2747 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell pm path com.yourcompany.testme2
[3520 ms] - package:/data/app/com.yourcompany.testme2-2/base.apk
[3520 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell cat /data/local/tmp/sky.com.yourcompany.testme2.sha1
[3570 ms] - 0570d61ffbb2b9f62157cd62e1330b6560d5b901
[3937 ms] - Running build command for AndroidDevice 031462ee213e73b9.
[3937 ms] Starting lib/main.dart on Nexus 5...
[3938 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb version
[3989 ms] - Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android
[3992 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 start-server
[4032 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell getprop ro.build.version.sdk
[4088 ms] - 23
[4180 ms] - /Users/sethladd/Code/flutter/bin/cache/artifacts/engine/darwin-x64/sky_snapshot /Users/sethladd/flutter/testme2/lib/main.dart --package-root=packages --snapshot=/var/folders/00/0v8ph000h01000cxqpysvccm003d2t/T/flutter_toolsZxqGzV/snapshot_blob.bin
[4962 ms] - Building /var/folders/00/0v8ph000h01000cxqpysvccm003d2t/T/flutter_toolsZxqGzV/app.flx
[6076 ms] - Starting bundle for AndroidDevice 031462ee213e73b9.
[6078 ms] - AndroidDevice 031462ee213e73b9 startBundle
[6080 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 forward tcp:16217 tcp:8181
[6111 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 -s 031462ee213e73b9 logcat -c
[6231 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 push /var/folders/00/0v8ph000h01000cxqpysvccm003d2t/T/flutter_toolsZxqGzV/app.flx /data/local/tmp/dev.flx
[6349 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --ez enable-background-compilation true --ez start-paused true com.yourcompany.testme2/org.domokit.sky.shell.SkyActivity
[7280 ms] - Starting: Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x20000000 cmp=com.yourcompany.testme2/org.domokit.sky.shell.SkyActivity (has extras) }
[7286 ms] - Looking for the observatory at ws://localhost:16217/ws.
[7881 ms] - Connected to the observatory port (595ms).
[7885 ms] - Finished start command.

@sethladd, can you update your master branch and re-run the timings?

Sure thing. Just updated. First run, via Atom / Cmd-R, was [23072 ms] - Finished run command.
Then, changed the text again, and Cmd-R, and I saw [5600 ms] - Finished run command. which is yay! but then I saw: Uncaught 105: Extension error Isolate must be runnable before this request is made. from Atom:

Here's the times after the last few PRs:
   0 ms • Using Android SDK at /Users/devoncarew/tools/android-sdk-macosx/.
   5 ms • [/Users/devoncarew/tools/android-sdk-macosx/, SDK version 23, build-tools 23.0.2]
  16 ms • xcode-select --print-path
  59 ms • xcodebuild -version
   3 ms • Xcode 7.2.1
          Build version 7C1002
   9 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb devices -l
  18 ms • List of devices attached
          TA95000FQA             device usb:336592896X product:peregrine_retus model:XT1045 device:peregrine
  12 ms • idevice_id -h
   4 ms • which idevice_id
   0 ms • /Users/devoncarew/homebrew/bin/idevice_id
   6 ms • /Users/devoncarew/homebrew/bin/idevice_id -l
  81 ms • /usr/bin/xcrun simctl list --json devices
  30 ms • Downloading toolchain.
  43 ms • /usr/bin/defaults read /Users/devoncarew/flutter/flutter_sunflower/ios/Info CFBundleIdentifier
   1 ms • io.flutter.runner.Runner
  10 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb devices -l
   0 ms • List of devices attached
          TA95000FQA             device usb:336592896X product:peregrine_retus model:XT1045 device:peregrine
   4 ms • idevice_id -h
   6 ms • /Users/devoncarew/homebrew/bin/idevice_id -l
  77 ms • /usr/bin/xcrun simctl list --json devices
   4 ms • Running build command.
   0 ms • APK up to date; skipping build step.
   0 ms • Running install command.
  41 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell cat /data/local/tmp/sky.com.example.flutter_sunflower.sha1
   0 ms • 1d4a99b290492af2a1b0ee08fe6866ec63bf0331
   0 ms • Running build command for AndroidDevice TA95000FQA.
   2 ms • Starting lib/main.dart on XT1045...
   9 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb version
   1 ms • Android Debug Bridge version 1.0.32
          Revision 09a0d98bebce-android
   9 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA start-server
  27 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell getprop ro.build.version.sdk
  32 ms • 22
 367 ms • /Users/devoncarew/projects/flutter/flutter/bin/cache/artifacts/engine/darwin-x64/sky_snapshot /Users/devoncarew/flutter/flutter_sunflower/lib/main.dart --package-root=packages --snapshot=build/snapshot_blob.bin
   4 ms • Building build/app.flx
  13 ms • which zip
   0 ms • KeyPair from privatekey.der: null.
 138 ms • Encoding zip file to build/app.zip
  95 ms • zip -q /Users/devoncarew/flutter/flutter_sunflower/build/app.zip snapshot_blob.bin content/ic_add_white_18dp.png content/1.5x/ic_add_white_18dp.png content/2.0x…
  11 ms • zip -q -0 /Users/devoncarew/flutter/flutter_sunflower/build/app.zip AssetManifest.json
  63 ms • Creating flx at build/app.flx.
   0 ms • Built build/app.flx.
   1 ms • Starting bundle for AndroidDevice TA95000FQA.
   0 ms • AndroidDevice TA95000FQA startBundle
   9 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA forward tcp:8181 tcp:8181
  31 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA -s TA95000FQA logcat -c
 134 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA push build/app.flx /data/local/tmp/dev.flx
 628 ms • /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --ez enable-background-compilation true --ez enable-checked-mode true com.example.flutter_sunflower/org.domokit.sky.shell.SkyActivity
   0 ms • Starting: Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x20000000 cmp=com.example.flutter_sunflower/org.domokit.sky.shell.SkyActivity (has extras) }
          Warning: Activity not started, its current task has been brought to the front
   0 ms • 'flutter run' exiting with code 0; elasped time 2022ms.

I filed https://github.com/flutter/flutter/issues/2251 to track the exception you found. We should open an issue to get the startup time under benchmark per commit, otherwise the startup perf will probably regress over time.

Closing...

Thanks! The first three builds were 16-20 seconds (not sure why the 2nd and 3rd builds were also slow), but the 4+ build I am seeing:
~/flutter/testme3 $ flutter -v run
[  27 ms] - Using Android SDK at /Users/sethladd/homebrew/opt/android-sdk.
[  28 ms] - [/Users/sethladd/homebrew/opt/android-sdk, SDK version 23, build-tools 23.0.2]
[  57 ms] - xcodebuild -version
[ 140 ms] - Xcode 7.2
Build version 7C68
[ 144 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb devices -l
[ 169 ms] - List of devices attached
031462ee213e73b9       device usb:337838080X product:hammerhead model:Nexus_5 device:hammerhead
[ 211 ms] - which idevice_id
[ 215 ms] - /Users/sethladd/homebrew/bin/idevice_id
[ 215 ms] - /Users/sethladd/homebrew/bin/idevice_id -l
[ 223 ms] - /usr/bin/xcrun simctl list --json devices
[ 303 ms] - Downloading toolchain.
[ 344 ms] - /usr/bin/defaults read /Users/sethladd/flutter/testme3/ios/Info CFBundleIdentifier
[ 384 ms] - com.yourcompany.testme3
[ 386 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb devices -l
[ 415 ms] - List of devices attached
031462ee213e73b9       device usb:337838080X product:hammerhead model:Nexus_5 device:hammerhead
[ 421 ms] - /Users/sethladd/homebrew/bin/idevice_id -l
[ 428 ms] - /usr/bin/xcrun simctl list --json devices
[ 509 ms] - Running build command.
[ 513 ms] - APK up to date; skipping build step.
[ 514 ms] - Running install command.
[ 515 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell cat /data/local/tmp/sky.com.yourcompany.testme3.sha1
[ 588 ms] - 6529f194849edac8eb4f642e0096f6afe9e93d5e
[ 589 ms] - Running build command for AndroidDevice 031462ee213e73b9.
[ 590 ms] Starting lib/main.dart on Nexus 5...
[ 591 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb version
[ 613 ms] - Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android
[ 615 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 start-server
[ 642 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell getprop ro.build.version.sdk
[ 682 ms] - 23
[ 723 ms] - /Users/sethladd/Code/flutter/bin/cache/artifacts/engine/darwin-x64/sky_snapshot /Users/sethladd/flutter/testme3/lib/main.dart --package-root=packages --snapshot=build/snapshot_blob.bin
[1444 ms] - Building build/app.flx
[1462 ms] - KeyPair from privatekey.der: null.
[1462 ms] - Encoding zip file to build/app.zip
[1672 ms] - zip -q /Users/sethladd/flutter/testme3/build/app.zip snapshot_blob.bin content/ic_add_white_18dp.png content/1.5x/ic_add_white_18dp.png content/2.0x/ic_add_whit…
[1784 ms] - zip -q -0 /Users/sethladd/flutter/testme3/build/app.zip AssetManifest.json
[1800 ms] - Creating flx at build/app.flx.
[1885 ms] - Built build/app.flx.
[1885 ms] - Starting bundle for AndroidDevice 031462ee213e73b9.
[1886 ms] - AndroidDevice 031462ee213e73b9 startBundle
[1887 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 forward tcp:8181 tcp:8181
[1909 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 -s 031462ee213e73b9 logcat -c
[2009 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 push build/app.flx /data/local/tmp/dev.flx
[2123 ms] - /Users/sethladd/homebrew/opt/android-sdk/platform-tools/adb -s 031462ee213e73b9 shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --ez enable-background-compilation true --ez enable-checked-mode true com.yourcompany.testme3/org.domokit.sky.shell.SkyActivity
[2992 ms] - Starting: Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x20000000 cmp=com.yourcompany.testme3/org.domokit.sky.shell.SkyActivity (has extras) }
Warning: Activity not started, its current task has been brought to the front
[2992 ms] - Finished run command.

We should open an issue to get the startup time under benchmark per commit, otherwise the startup perf will probably regress over time.

https://github.com/flutter/flutter/issues/2253


peer-to-peer-review Capstone-1

peer-to-peer-review Capstone-1
it is clear code and great design, and it will be also more advisable to use article elements for the self-contained program section
maybe also for additional good things try to make the navigation fixed

Hi
Thank you very much for the suggestions. Now working on that.


DBZ-7342 Respect the max error retries setting

Break the loop of retries after the max number of retries has been reached.

The failures don't seem to be random, but are not related to this PR.

Merged, thanks @shybovycha !


feat: delete pods in parallel to speed up retryworkflow

I have a big worklfow. When it failed and retry, it will be slowly. Latency increases with the number of pods. Always letting my automated system（interact with argo server use https) time out.
time="2023-12-26T13:02:01.560Z" level=info duration=1m18.730806898s method=PUT path=/api/v1/workflows/default/catch-workflow-8c48s/retry size=194 status=409

I found that the main time spent was deleting pods.
time="2023-12-26T13:02:00.126Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-2538960512
time="2023-12-26T13:02:00.328Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-2824246174
time="2023-12-26T13:02:00.527Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-3817503941
time="2023-12-26T13:02:00.731Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-1699455227
time="2023-12-26T13:02:00.925Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-4168132452
time="2023-12-26T13:02:01.133Z" level=info msg="Deleting pod" podDeleted=catch-workflow-8c48s-read-ligands-from-vswdb-op-bmvou-9dzxr-1982889595

So I want make deleting pods parallel.

Motivation

Modifications

Verification

I had no idea the Server deleted pods..that's surprising...anyway, LGTM!

I had no idea the Server deleted pods..that's surprising...anyway, LGTM!

Thank you so much!

I had no idea the Server deleted pods..that's surprising

That makes at least 3 of us as neither Terry nor I expected that either 😅  😕
I mentioned this in https://github.com/argoproj/argo-workflows/pull/12105#discussion_r1376399199, I don't think this logic should belong in the Server as it breaks the separation of duties between Controller and Server right now; this makes the Server necessary for certain operations. Outside of this functionality, the Server and Controller are independent, with the Server mainly signaling to the Controller (via labels) and is not strictly required for any operations.
Bala agreed with me there as well, so I do think this should be refactored

I had no idea the Server deleted pods..that's surprising...

@juliev0 that makes at least 3 of us as neither Terry nor I expected that either 😅 😕
I mentioned this in #12105 (comment), I don't think this logic should belong in the Server as it breaks the separation of duties between Controller and Server right now; this makes the Server necessary for certain operations (retry in this case). Outside of this functionality, the Server and Controller are independent, with the Server mainly signaling to the Controller (via labels) and not strictly required for any operations.
Bala agreed with me there as well and multiple people have been surprised by the current behavior, so I do think we have consensus that this should be refactored

I completely agree and wanted to make the same judgment actually.

I'll file a tracking issue for it for now as it does require some careful refactoring

Yes, I agree. I also had some doubts at the time, but at that time I was just focused on solving customer problems.
If there's anything I can do, I'm willing to do it.

Feel free to take on the issue if you'd like, otherwise I might get to it eventually


Conditional Formatting Blank Cells

What is the best way to conditionally format a blank cell? I am dividing data by an empty column and want to color the empty column in the middle blue but when I specify no text colors everything except the empty column blue because of the assumed wildcard. Is there another method?
The only way I can think is loop through the Table and rename each "rowerror" value to '     ' and set that as the conditional text but I don't really want to do that.
    $FillBlanks = New-ConditionalText -BackgroundColor Blue

    $BackupSupportList|Select-object -Property User,ID,Team,Title,Mobile,Ext,@{Name=' ';Expression={$_.rowerror}},ToExt,ToUser,ToID,ToTeam,ToTitle,ToMobile|Export-Excel -now -StartRow 6 -AutoSize -AutoFilter -ConditionalFormat $FillBlanks -IncludePivotTable #-TitleFillPattern Blue # -ConditionalFormat $FillBlanks #-ConditionalFormat  -TitleFillPattern Blue

Update: I was able to fill the specific column G:G after finding the new-excelstyle method, but it would still be nice to know how I could fill blank columns for other purposes so I don't have to specify ranges.

Try
New-ConditionalText -ConditionalType ContainsBlanks

$xlfile = "$env:TEMP\test.xlsx"
rm $xlfile -ErrorAction SilentlyContinue

$data = ConvertFrom-Csv @"
Region,Item,TotalSold
West,lemon,52
West,avocado,8
West,melon,18
North,other,
East,banana,91
South,peach,18
West,peach,56
East,screws,1
West,peach,25
West,,35
East,hammer,4
North,screws,49
,test,35
"@

$ConditionalText = New-ConditionalText -ConditionalType ContainsBlanks -BackgroundColor Green
$xl = Export-Excel -InputObject $data -Path $xlfile -ConditionalText $ConditionalText -Show

that works, thank you! I hadn't seen that condition in notes before :)


Update package and testing configurations

This is a continuation of #472 to address #459.
In particular, this:

removes Wagtail 4.2 testing support
removes the Django 4.1 classifier
add the Wagtail 6 classifier

Feel free to merge! 💪


bump "hash-for-dep" version to allow packages without "main" in package.json

shouldn't semver drift already do this?

(Semver does on new installs, but I found it convenient as I am switching a whole tree of packages and it seemed that for some reason it wasn't always getting pulled in. Perhaps a caching issue.... Thanks for merging!)


Add path fixes needed by current sharpie

@dalexsoto : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Enable projects to remove project members

General Checkups

[x] Have you checked that there aren't other open pull requests for the same issue/update/change?
[x] If your code includes new features and not just bug fixes/copy editing: Did you include new tests?

Description
Add on-site and API endpoint to allow projects to remove members from the project.
Remaining TODOs

[x] Add tests
[x] Add documentation
[x] Reduce redundant code redundancy

Related Issue
Closes #737

I went and marked some of the codeclimate issues as invalid – thanks to @gedankenstuecke for pointing out I could log in and do that! And thank you to @jhdulaney for the review, I'll merge now.


Update compact_layouts.json

Hey, I think "appMenu" is not needed in the URL!

Good catch @wrone, thanks for the contribution!

Great! Thank you for the Postman collection, @pozil, great repo!


update scope guide

Updated screen captures, and text. Removed Docker-machine instructions.  And updated a number of other changes in the product.
Still need to add the Resource Manager.

@2opremio If you have a bit of time, please let me know if I should add or expand on some things in here. (I have one more to update still.)
I held off on mentioning the Resources View until that goes through a few more sprints, wdyt?
@lukemarsden


Data Source UI cannot filter for empty core Text Input or Date fields

Examples:

I have a Section with many fields. One is an optional core Text Input field.
I have another Section with some fields. One is an optional core Date field.

In each of the examples above want a Data Source to filter for entries where those fields are empty.  I have tried the following filter values but none worked:

regexp: ^$
not-regexp: ^http (in the case of a Text Input field that was expecting a URL)
not-regexp: .+
not-regexp: ^.+$
sql: NULL *
is null *

In all filter value cases the output XML is <error>No records found.</error>
* In these filter value cases, where I've selected a parameter in the UI to be output, all <items are output in the <ds- parameter, regardless of the filter.
The opposite does work. So regexp: ^.+ will find the entries with non-empty Date fields, for example.
Symphony version is 2.6.3.

You stumbled across this issue: is there a solution to this problem already?

No, as far as I know.  I cannot provide a solution.  As a work-around, I guess hacking a data source would work.

Thanks for the update @cylkee!
@nitriques and @brendo: Is there an easy way to make sql: NULL / sql: NOT NULL – like we know it from AF or SBL – available to the date field? One important thing is to be able to unite different operators like so:
equal to or earlier than today, sql: NULL

This would return all entries with a date that either meets the chronological requirements or is not specified at all.

One important thing is to be able to unite different operators like so

Right now this is not possible, even in AF or SBL.

Weird, but the core tag field already had it...

@cylkee I have a working version with sql: NULL and sql: NOT NULL wanna test it ?

@cylkee see #2666

@nitriques Thank you.  To test, would I need to install a 2.7.x somewhere?

@cylkee Yes, or do and update on a DEV setup!


fix isAllowedToRedeemBy method

the issue is:
when checking a coupon which is registered to a specific user (for example user_id 99), the verifyCouponOr will return exception for second check..
for example:
$user = User::find(99);
$user->verifyCouponOr("ABC123", function($code, $e){ return $e; }); // 1st time called, success
$user->verifyCouponOr("ABC123", function($code, $e){ return $e; }); // 2nd time, will return NotAllowedToRedeemException (this one should be success also)

.
.
The solution:
as I check the code, there's a mistake in isAllowedToRedeemBy method in Models\Coupon:
current redeemer should be compared to coupon's redeemer model instance instead of redeemer query instance
$coupon->redeemer()->is($redeemer); // this one wrong

$coupon->redeemer->is($redeemer); // this one correct one

i'm not sure if my solution is correct or not... if not, it's okay and i hope you have a better solution...thank you...
p/s: by the way, sorry for my bad english language....

hi @michael-rubel , hope can merge this pr..... thanks 🙏

@michael-rubel .. sorry, i just edit the issue, actually, the problem is occurred when calling verifyCouponOr method twice...
if using verifyCoupon, will have no problem at all...
only verifyCouponOr causing the issue...

Hi @syamsoul
I'll have a look in a while. 🙂

@syamsoul Can you test if this works for you on the main branch?

yes... it works.... thank you

Thank you @syamsoul!
Released the fix as v7.1.1.


Focusing the next/previous buffer should wrap around

Would it be possible for cokeline-focus-next/cokeline-focus-previous to wrap around the list of buffers? E.g. if the last buffer in the list was currently selected, calling cokeline-focus-next would focus the first buffer.

Sure, just pass cycle_prev_next_mappings = true to the "cokeline".setup function.

Yes thank you!


Simplify checks in ssl_write_certificate_request

Description
Resolve #2916 - remove condition in the middle, because it is enough to do the strongest check only.
Status
READY
Requires Backporting
NO
Which branch?
development
Migrations
NO

Thanks for your contribution!
However I'm a bit conflicted about that change. Strictly speaking and using only information available in this function, the middle check is not redundant, due to the risk of overflow: if dn_size is SIZE_MAX or SIZE_MAX - 1, then 2 + dn_size is 1 or 0 and the final check becomes weaker than the middle one.
Now using extra information, we can see that dn_size is crt->subject_raw.len which clearly can't be that close to SIZE_MAX because otherwise  the size of the overall certificate could not be represented with a size_t.
So I think removing the middle check is OK, but makes the correctness of the code a bit less obvious. So perhaps we should add a comment?

Strictly speaking and using only information available in this function, the middle check is not redundant, due to the risk of overflow

Good point.
However, based on this funcion's code, dn_size should be defined as uint16_t.
If size_t is 16 bits wide, it could be verified that the dn_size value is below  _UI16_MAX - 1.

However, based on this funcion's code, dn_size should be defined as uint16_t.
So far, we tend to use size_t for every sizes, and I'd rather stick to that convention unless we have a good reason not to.

@mpg, thanks for reviewing.

So far, we tend to use size_t for every sizes, and I'd rather stick to that convention unless we have a good reason not to.

Please compare to the PR #2856.
Only two low byttes of dn_size and total_dn_size are usable, therefore switch to uint16_t in this function would be appropriate. Even comment could be skipped because the library supports only 32 and 64 bits architectures.
if( end < p || (size_t)( end - p ) < 2 +(size_t) dn_size )

OK, good point. Feel free to update this PR to use uint16_t, then. (We'll probably need to add an explicit cast in dn_size = crt->subject_raw.len; though, otherwise some compilers are likely to warn about implicit conversion losing precision.)

The commit was updated as discussed.
However, on closer inspection of code, a few similar cases were found by searching for << 8  in ssl_srv.c module.
Similar case here means using of size_t instead of more natural type uint16_t that stores a combination of two bytes. It would be better to treat these cases the same way everywhere.
What would you say, should the scope of this PR to be expanded?

What would you say, should the scope of this PR to be expanded?

I think it's up to you. You can either expand the scope of this PR, or address the other similar issues in a subsequent PR - IMO both ways are fine, so pick the one your prefer :)

I think it's up to you. You can either expand the scope of this PR, or address the other similar issues in a subsequent PR - IMO both ways are fine, so pick the one your prefer :)

Thanks.
As I thied to implement the mentioned ideas, there were over 20 changes, and some byproducts too. It would be safer to make a separate PR, and hope that the current small PR could be merged soon.

Thanks for adding the comment. All clear now.


Rename to palindrom-polymer-client

All tests are passing and I added a spec that tests backward compatibility, i.e: that uses <puppet-client />.

Or, to palindrom-client? This custom element should be able to notify any partial written in any framework.

I agree with palindrom-client much conciser and says what it does.

Or, to palindrom-client (without polymer- in the name)?

I would say we need polymer- as

This custom element should be able to notify any partial written in any framework.

Give that we have new JS framework every day, we should not even consider that.
I would say that palindrom-client could do something generic vanilla way, like juicy-html or imported-template does with model binding.

Also please note that neither puppet-client nor puppet-polymer-client has to do anything with "partials" (as long as you mean "partial views"  or "partial view-models", not "partial HTML documents" == DocumentFragment)
This element only integrates Puppet/Palindrom with single Polymer's dom-bind element.

Fair enough, that is basically what I meant.
But the fact that in future we want to have cleaner palindrom-client does not mean that this repo cannot have such name already.
We don't want our users to change the URL and the name of the custom element that initializes Palindrom session every few weeks.

So what is the final agreement?

I don't have a strong opinion, please choose what you think is best. Long term we want to have a vanilla Javascript custom element called palindrom-client, which does not favor any framework.
If this repo is the starting point of that, then rename this repo to palindrom-client which is loaded into Starcounter as /sys/palindrom-client/palindrom-client.html and used by the name <palindrom-client>.
If this repo is not the starting point of that, then rename this repo to palindrom-polymer-client which is loaded into Starcounter as /sys/palindrom-client/palindrom-client.html and used by the name <palindrom-client>. This is more or less what we had now with puppet-polymer-client and it was confusing for everyone.
For me the first option is just simpler to follow.

More-or-less I agree with above.
Also, I'd like to point out, that we will have to either migrate this from Polymer 1.x (-> 2.0) -> Vanilla V1, or puppet-client from V0 -> V1. So migration is inevitable.

@tomalec that's what I did with Vanilla components. But is it possible to do this with Polymer components? What can I do with is: 'palindrom-client' and <dom-module id="palindrom-client">

Maybe something like this?
var common = {
 /* my Polymer element definition */
}

var puppetClient = Object.assign({}, common);
puppetClient.is = "puppet-client";
Polymer(puppetClient);

var palindromClient = Object.assign({}, common);
palindromClient.is = "palindrom-client";
Polymer(palindromClient);

@warpech I had the same idea, but I am not sure what would happen if
<dom-module id="palindrom-client">

and
is: 'palindrom-client'

didn't match. Tests are passing just fine. Should I consider it OK?
Because the docs say they should match

To specify DOM to use for an element's local DOM, use the <dom-module> element. Give the <dom-module> an id attribute that matches its element's is property and put a <template> inside the <dom-module>. Polymer will automatically clone this template's contents into the element's local DOM.

I would actually do both <dom-module is="palindrom-client"> and <dom-module is="puppet-client"> separately, just share the JS config object that is used by them.
Is there any reason why Travis CI started failing?

@warpech yes, Object.assign needs a polyfill in IE and Safari. I polyfilled it.

Can we change Travis to not test in unsupported browsers?

@warpech even though I used SauceLabs Configurator, Edge is still timing out. Should I dig deeper or remove it?


Mimetic Interpolation of Vector Fields (Pletzer and Hayek, 2019)

I just found this fascinating paper:
Pletzer, A. and W. Hayek, 2019: Mimetic Interpolation of Vector Fields on Arakawa C/D Grids. Mon. Wea. Rev., 147, 3–16, https://doi.org/10.1175/MWR-D-18-0146.1
https://journals.ametsoc.org/doi/full/10.1175/MWR-D-18-0146.1
There appears to be a python library!
https://github.com/pletzer/mint
The author is @pletzer.
Interestingly it uses VTK to deal with the grid cell problem.
Just posting here because I think this is the best place for discussion regridding. It would be great to have this tool available in an xarray / dask friendly way.

Thanks for the information, that looks very useful!
Interestingly, I just had a conservation with the author of VTKI @banesullivan. It is a much more sane frontend for VTK, somewhat like what xESMF is to ESMF.  Some possible connections with Xarray/Dask are discussed at https://github.com/vtkiorg/vtki/issues/177#issuecomment-484729022 and vtkiorg/vtki#192

@JiaweiZhuang - this is a super cool project!
Would you please join the @OpenGeoVis slack workspace? http://slack.opengeovis.org - it's a community I'm trying to build around @vtkiorg and @OpenGeoVis


findFiles2New should explain the advantage of using an array of glob pattersn

Testing #223154
GHPR had a pattern where it called findFiles 6 times. This was not great and spawned many ripgrep (https://github.com/microsoft/vscode-pull-request-github/issues/5923). Is there an advantage to the findFiles2New where this wont happen?

Yes, the advantage is that you can call once if you want to include lots of patterns in a 'a OR b OR c' manner, where a, b, and c are different glob patterns.
However, due to the way that ripgrep is, it will still be called n times (in the example above, 3 times). This is just because of the way that ripgrep can only handle one glob at a time.
If these are globs that are not from user input, you could actually do something like {a, b, c}. This should combine a, b, and c into one glob via brace expansion, and thus being one call (this is already supported in FindFiles). However, ripgrep does not support brace expansion past the first level, so if these are user-provided globs that may already have braces, it's the safest to run separate searches. In the case of the new API, this would just be one call to findFiles2 with multiple filePatterns. However, in the back end, this will still call 6 ripgreps.


fix compiler error for "catch (IOException|NullPointerException e)"

This pull request fix compiler error for "catch (IOException|NullPointerException e)" under java 7

This is addressed by a recent PR to up the Java version used to 1.7.


Update containerd to v1.6.9

Summary
This MR updates containerd to v1.6.9, the latest release at the time of writing.
It includes a updated version of continuity, which should fix the issue I reported at https://github.com/canonical/microk8s/issues/3499.

Changes

Update of containerd from v1.6.6 to v1.6.9.
Testing

Possible Regressions

Checklist

[x] Read the contributions page.
[x] Submitted the CLA form, if you are a first time contributor.
[x] The introduced changes are covered by unit and/or integration tests.

Notes

Thanks for the PR @dalbani, I went ahead and also pushed a commit to also upgrade runc to 1.1.4, https://github.com/containerd/containerd/commit/eb664aed0c73731e3d113ba2170e402eaca12109

Great, thanks a lot @neoaggelos!


UAT | Home Page for court staff

Home page for all court staff to be updated as per below format:
https://www.figma.com/design/fwFYdlymVjggLOltq
Based on the role based action providedm the list of enty points (as illustrated below) will update

@amit yadav, while this is being implemented, please update localization in nyay mitra screen for View Cases to
Heading: Collect Payment
Subheading; Collect court fees related to case filing, applications and summons.

all actions here: https://www.figma.com/design/fwFYdlymVjggLOltqnXWsY/Hand-off-(Digit)?node-id=16376-104945&t=FksjYvJbm9czCPk6-0


Compilation error in class MobileTokenApiExceptionResolver

I am getting a compilation error in class MobileTokenApiExceptionResolver:
https://github.com/lime-company/lime-security-powerauth-webauth/blob/master/powerauth-webauth-authentication-mtoken/src/main/java/io/getlime/security/powerauth/lib/webauth/authentication/mtoken/exception/MobileTokenApiExceptionResolver.java
Method Error.genericError() is missing, see Error class:
https://github.com/lime-company/lime-java-core/blob/master/rest-model-base/src/main/java/io/getlime/core/rest/model/base/entity/Error.java

... caused by using old core Java classes - last commit uses 1.0.2 that corrects the error with default constructor, instead of static method.