When creating a new ATProto account, handle existing DNS record

Right now, when we create a new ATProto repo and DID, if our _atproto DNS record for handle resolution already exists, we crash. We should handle that and recover instead. Example log below; exception is google.api_core.exceptions.Conflict. Docs don't help much. Haven't found a way to tell it to overwrite/replace existing records, so I may need to either catch the exception or look up the record first. cc @gabboman
adding GCP DNS TXT record for _atproto.gabboman.app.wafrn.net.ap.brid.gy. "did=did:plc:qh4q7p2njfcpbwjxswox7bcy"
<class 'google.api_core.exceptions.Conflict'>: 409 POST https://dns.googleapis.com/dns/v1/projects/brid-gy/managedZones/brid-gy/changes?prettyPrint=false: The resource 'entity.change.additions[_atproto.gabboman.app.wafrn.net.ap.brid.gy.][TXT]' named '_atproto.gabboman.app.wafrn.net.ap.brid.gy. (TXT)' already exists
Traceback (most recent call last):
...
  File "workspace/protocol.py", line 1501, in receive_task
    return PROTOCOLS[obj.source_protocol].receive(obj=obj, authed_as=authed_as,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "workspace/protocol.py", line 930, in receive
    from_user.enable_protocol(proto)
...
  File "workspace/models.py", line 467, in enable_protocol
    enable()
  File "workspace/atproto.py", line 352, in create_for
    changes.create()
  File "google/cloud/dns/changes.py", line 233, in create
    api_response = client._connection.api_request(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "google/cloud/_http/__init__.py", line 494, in api_request
    raise exceptions.from_http_response(response)
google.api_core.exceptions.Conflict: 409 POST https://dns.googleapis.com/dns/v1/projects/brid-gy/managedZones/brid-gy/changes?prettyPrint=false: The resource 'entity.change.additions[_atproto.gabboman.app.wafrn.net.ap.brid.gy.][TXT]' named '_atproto.gabboman.app.wafrn.net.ap.brid.gy. (TXT)' already exists

We still see a steady trickle of these, roughly one a day on average: https://console.cloud.google.com/errors/detail/COibqNv9r7ynFg;filter=[];time=P30D?project=bridgy-federated

I wonder if #1063 will mostly or entirely prevent this.

Nope, we're still seeing a trickle.

Done! And I fixed (I think) pretty much everyone who hit this in the last 30d or so.


Fix test app issues, add tests

In using the iOS app to investigate a bug report, I ran into a bug in the dynamic layout of the dynamically-created view in "Add Second Map."
Aside from resolving that minor issue and adding a test case, I also added a "smoke test" that just clicks on all the items in the menu to make sure they don't crash, but with no validation that they work correctly.
That turned up several problems, such as test cases which can only be run in isolation, and cases which break later cases.  For example, "Add Route Line" and "Style Route line with gradient" created sources with the same name, and the style would throw when the second was added.
Currently all the cases are run except for the ones which add 1,000 or 10,000 items, as these seem to take so long that the search for the tappable menu button times out.  But they use the same method as the 100 case.

Did the iOS UI tests run on CI? It shows PASSED (Cached).

I'm not sure what's being cached there.  It previously failed repeatedly on CI but worked for me locally on physical and simulated devices.  The log seemed to indicate that the target crashed ("Unable to monitor event loop") at 230s.  I increased the "size" of the UI test target to extend the timeout from 5 to 15 minutes, and that seems to have resolved it, so I suspect that Bazel was terminating the target before the test framework, and the difference of 70 seconds was the other stuff going on in the build and test setup.

I'll keep an eye on CI. Works great locally.


wallet-lib: getTransactionHistory type missing on Account

wallet-lib supports transactionHistory now, but the type is missing on Account:
Property 'getTransactionHistory' does not exist on type 'Account'.

please retest that

retest failed on sdk v3.21.8

please try it out with v22

retest passed


User Activity - watch a thread for new posts

t ack

working but mobile <-> laptop setting is not being updated

again... accounts do not save so it's not like settings on one device will carry over to the other...

t ack


github-release is tagging the wrong SHA

we are passing sha to createRelease instead of target_commitish

Currently if target_commitish is empty, it will tag the latest commit on the default branch. This is ok for most use cases, but releases on other release branches are being tagged incorrectly.


split registration permissions

ref: https://github.com/stolostron/backlog/issues/23002
Signed-off-by: haoqing0110<EMAIL_ADDRESS>

/assign @qiujian16 @elgnay
/cc @zhujian7

/assign @skeeey

/approve


Added a FindTheTraceOfAMatrix.c file

Why:

Closes #4590
What's being changed:
Added a FindTheTraceOfAMatrix.c file in find-the-trace-of-a-matrix folder

Pls review the pr 😊


CLI should fail on init if app limit has been reached

Is this feature request related to a new or existing Amplify category?
No response
Is this related to another service?
No response
Describe the feature you'd like to request
If we have reached the 25 app limit for our chosen region, upon amplify init the CLI should fail
josef ~/D/p/my-project
> amplify init -y
The maximum number of apps that you can create with Amplify in this region has been reached. Select a different region or [request a limit increase](#some-link)...

Currently the CLI prints a warning in the large output from amplify init:
⚠ The maximum number of apps that you can create with Amplify in this region has likely been reached:

However, this is easily missed, and when we attempt to add a resource we are presented with an ambiguous error:
🛑 Missing required key 'appId' in params
MissingRequiredParameter: Missing required key 'appId' in params

(this error is looking for AmplifyAppId for our environment, though this does not exist because we have reached our app limit)
Describe the solution you'd like
josef ~/D/p/my-project
> amplify init -y
The maximum number of apps that you can create with Amplify in this region has been reached. Select a different region or [request a limit increase](#some-link)...

Describe alternatives you've considered
n/a
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

I have the same problem.
And gets worst, because I have to transfer my project to a new computer, and after checking out a project, then running amplify init and going through the whole thing.
I get a "kinda of" success message? but with an warning in the end saying the max number of apps has reached (I only have ONE app).
✔ Initialized provider successfully.
✅ Initialized your environment successfully.

Your project has been successfully initialized and connected to the cloud!

Some next steps:
"amplify status" will show you what you've added already and if it's locally configured or deployed
"amplify add <category>" will allow you to add features like user login or a backend API
"amplify push" will build all your local backend resources and provision it in the cloud
"amplify console" to open the Amplify Console and view your project status
"amplify publish" will build all your local backend and frontend resources (if you have hosting category added) and provision it in the cloud

Pro tip:
Try "amplify add api" to create a backend API and then "amplify push" to deploy everything

⚠ The maximum number of apps that you can create with Amplify in this region has likely been reached:
For more information on Amplify Service Quotas, see:
https://docs.aws.amazon.com/general/latest/gr/amplify.html#service-quotas-amplify

Then when I do amplify status, something worries me more, because it tells me some of my functions and apis changes, even thou I was literally just checking the project out.

┌──────────┬──────────────────────────────────────┬───────────┬───────────────────┐
│ Category │ Resource name                        │ Operation │ Provider plugin   │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ checkHoneypot                        │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ sendEmail                            │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ cryptokenAuthCustomMessage           │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ manageTelegramGroups                 │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ triggerMessenger                     │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Api      │ cryptokenAPI                         │ Update    │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Hosting  │ amplifyhosting                       │ No Change │                   │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ searchToken                          │ No Change │ awscloudformation │
├──────────┼──────────────────────────────────────┼───────────┼───────────────────┤
│ Function │ getTokenPrice                        │ No Change │ awscloudformation

I also noticed a couple files changed. and when I run a git diff I get some of the dependencies has been removed ?????
--- a/amplify/backend/types/amplify-dependent-resources-ref.d.ts
+++ b/amplify/backend/types/amplify-dependent-resources-ref.d.ts
@@ -172,44 +172,6 @@ export type AmplifyDependentResourcesAttributes = {
             "Arn": "string"
         }
     },
-    "api": {
-        "cryptokenAPI": {
-            "GraphQLAPIIdOutput": "string",
-            "GraphQLAPIEndpointOutput": "string"
-        },
-        "AdminQueries": {
-            "RootUrl": "string",
-            "ApiName": "string",
-            "ApiId": "string"
-        },
-        "paymentsAPI": {
-            "RootUrl": "string",
-            "ApiName": "string",
-            "ApiId": "string"
-        },
-        "telegramWebhook": {
-            "RootUrl": "string",
-            "ApiName": "string",
-            "ApiId": "string"
- ```

Tht's very odd.

I would appreciate some help with this.

How would I reproduce this?

Closing as this issue is now resolved


Best score doesn't get saved

Description of the Issue
"Best Score" gets updated with "Current Score" at first run but doesn't get saved in browser cookies.
Steps to Reproduce the Issue

Navigate to- http://palashbansal.github.io/Collision/
Start playing game.
"Best score" is changed
Reload game, and find that best score reset to 0

Expected Behavior
Best score should be highest recorded until cookies are cleared.
Actual Behavior
Best score is not getting stored in browser cookies

@aswinvenugopal1992
You might be interested in this issue.

I'll look into it @PalashBansal

@PalashBansal - I wonder, have you tried fixing this bug or something; I see comments removing cookie specific code in Game.js- which made me curious - what was it that you were trying to do; And what was the outcome.

@PalashBansal - I wonder, have you tried fixing this bug or something; I see comments removing cookie specific code in Game.js- which made me curious - what was it that you were trying to do; And what was the outcome.

You are right @astriskit I was trying to create this functionality around 5 years ago but couldn't. I wanted to save best score in cookies as long as user doesn't clears it.


Define output specification for atmosphere modules

The atmosphere modules write NetCDF files containing data such as temperature, pressure, fluxes, and composition. This should be generalised such that they use the same variable names and array shapes. The variables should also use the same units.
At the moment, there are some inconsistencies in model output formats. It is also frequently changing, which makes it difficult to parse old model outputs without writing a new script specifically for each file.
We should think carefully about this, because such a format should allow for future flexibility while preventing inconsistencies.
This is also applies generally (see Issues #71, #70).

Come back to this issues once #100 and input configuration is fixed.


Design: Revisit font size and colour to improve accessibility and usability issues

Type
enhancement
Detail

Review header and body copy
Review text link style
Define how it should scale on desktop, tablet and mobile

@jennpb We've updated few font styles/sizes to improve accessibility. After talking to David about how the fonts scale between desktop and mobile, we've decided to leave them as is but review as we roll out new pages and make necessary updates.


Make it work with recent versions of spdlog.

Recent versions don't have "notice" and "emerg" levels,
so change "notice" to "info" and "emerg" to "critical".

This is a little problematic given that there are other info lines that in general we don't want to print during runtime (which is why default before was notice).
I guess my feeling here is to change both notice/emerg -> critical and make the default critical. I realize that in general "critical" is supposed to mean "exiting soon and can't continue", but I don't think it really matters that much.
Otherwise we are going to have to change a whole bunch of existing info log lines to debug most likely (which is also fine, but a bigger change).
Thoughts?

I changed the default level (and mongo decoding error) to "error" level, which I think is the sanest solution... Unless you really want to display all those logs that were previously at "notice" level? FWIW, I don't get why spdlog removed "notice" level...
Also, I don't know the circumstances of all the errors, so could you please double-check whether any of those that I lowered from "notice" to "info" level should be at "error" level instead? Thanks!

There might be a few things that we want to leave at "err" just for startup and shutdown logging. Let me take a look at this brach locally. Which SHA of spdlog are you using? just current master?

https://github.com/gabime/spdlog/tree/v0.11.0

Did you have to make any build changes? I'm getting use of old style cast warnings as errors. Sorry for the delay trying to get this working now.

It looks like cotire doesn't correctly listen to SYSTEM includes either.

OK I got it working. It's going to require a few other changes. If it's OK with you I think I'm just going to open a new PR built on top of your changes. I will tag you.

Hey Matt,
oops, sorry! I didn't touch the build system (we're are using different one).
Feel free to start a new PR.

Closing in favor of https://github.com/lyft/envoy/pull/160


IntegrityError: UNIQUE constraint failed: app_brewpidevice.device_name

When adding a new device, the form clean checks for device_guided_serial_autodetect don't return form errors for non-unique device names. This should be a check on form validation, rather than something that kicks out a Python error if not done properly.
Real issue is at:
app/setup_views.py in device_guided_serial_autodetect at line 336
IntegrityError: UNIQUE constraint failed: app_brewpidevice.device_name
  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "django/db/backends/sqlite3/base.py", line 328, in execute
    return Database.Cursor.execute(self, query, params)

IntegrityError: UNIQUE constraint failed: app_brewpidevice.device_name
(15 additional frame(s) were not displayed)
...
  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "django/utils/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "django/db/backends/sqlite3/base.py", line 328, in execute
    return Database.Cursor.execute(self, query, params)

IntegrityError: UNIQUE constraint failed: app_brewpidevice.device_name

Similar issue in app/views.py in add_device at line 125

Same with app/setup_views.py in device_guided_add_mdns at line 264

This was fixed in device_manage, but not add_device. Reopening, as this will require some refactoring.


Handle inmemory files better

VSCode will send an inmemory:// file for new files are files that are opened as part of a git diff.
Two problems arise:

Crystal doesn't handle require's from these files, since it can't recognize the in memory path, so error checking them will report false positives.
We aren't cleaning up the reported errors when the inmemory file is closed.

To solve #1, we may want to only run the parser analyzer over inmemory files (and offer them completion services, when those are available).
To solve #2, we should send a clean diagnostic report whenever we close an inmemory file.

Fixed in https://github.com/kofno/scry/commit/940f8916a9d8a11291537ebd9394ac38987b14f7


Fix issue with certificate visibility

PR Fixes:

1 certificate visiblity

#Before:

#After:

#1556


Print Real-Time Errors in Console during Test

Is your feature request related to a problem? Please describe.
Many times, users realize their test had an error after their test has finished running and see a high error rate in the summary report. This is because OSB only presents the progress for each task/operation during the test but doesn't show real-time errors that OSB encounters.
Describe the solution you'd like
It'd be good to have issues presented in the console so that users can see real-time errors OSB encounters rather than seeing them in the logs or after the test finishes.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

would like to work on this issue @IanHoang


Inspecting or modifying bodies requires at least one deep copy.  Make changes so that deep copy is not required

What is the problem your feature solves, or the need it fulfills?
I am attempting to implement something like the NginX HTTP substition filter, that allows modification of the request or response body.  Documented here https://nginx.org/en/docs/http/ngx_http_sub_module.html
Sometimes I just want to inspect the body, other times I will want to inspect and transform the body.
There is an example of doing something similar in your examples directory:  Transforming JSON to YAML.  However it performs an extra deep copy (beyond the transformation) as it accumulates the Bytes into one Vec.
I believe this is due to the fact that HTTP chunk accumulation has to be eventually be assigned to body in the response_body_filter function signature, in order to send the accumulated chunks out on the wire, therefor it is beyond my ability to reduce the deep copies: It requires an API change.
    fn response_body_filter(
        &self,
        _session: &mut Session,
        body: &mut Option<Bytes>,
        end_of_stream: bool,
        ctx: &mut Self::CTX,
    ) -> Result<Option<std::time::Duration>> {
       if let Some(b) = body {
            // in the example it was accumulated into a Vec<u8>, I just accumulate Bytes
            // this is a deep copy
            ctx.chunks.extend_from_slice(&b);
            // drop the body
            b.clear();
        }

        if end_of_stream {
            // inspect and transform here

            // this forces a deep copy when putting the data into the context
            // might have to do a std::mem::take, I didn't verify for this example
            *body = ctx.accumulated_bytes;
        }
   }

Describe the solution you'd like
TL;DR - I would like to be able to inspect and sometimes transform request and response bodies with minimal or no deep copies if possible.
One way to do this is to accumulate into Vec<bytes> which involves no copying.  Yes, implementing a near zero deep copy inspect / transform would be painful code, but I've seen it done in C before, and I have a Rust prototype in a sandbox that does this.
However, the function signature for response_body_filter would have to change to allow transmission of a Vec instead of just a single <Bytes>.  For example:
    fn response_body_filter(
        &self,
        _session: &mut Session,
        body: &mut Option<Vec<Bytes>>,
        end_of_stream: bool,
        ctx: &mut Self::CTX,
    ) -> Result<Option<std::time::Duration>> {
       if let Some(b) = body {
            // not a deep copy
            ctx.chunks.push(b);
        }

        if end_of_stream {
            // inspect and transform here on a Vec<Bytes> with no copies  - painful but doable

            // not a deep copy
            // might have to do a std::mem::take, I didn't verify for this example
            *body = ctx.chunks;
        }
   }

I didn't run this by rustc so probably there's something obviously wrong to the trained eye, but that's the general idea.
Describe alternatives you've considered
I may be able to limit my accumulation to the low 100s of kbytes or so, so the extra deep copy currently required may not be too painful.  The general case of the nginx sub_module, however, doesn't have this limitation.  It's also amazing how fast requirements change.
Additional context
https://github.com/cloudflare/pingora/blob/main/pingora-proxy/examples/modify_response.rs
https://nginx.org/en/docs/http/ngx_http_sub_module.html

Yes, this is a highly useful feature! I'm currently developing a customized gateway but encountering a challenge. The upstream servers require different request paths and body formats, and I'm looking for a solution to handle this efficiently.

I have looked and have yet to find a "vector of Bytes" (or vector of capable version of the memchr (memmem) crate. I've seen code that implements this in C, but if you choose to implement this enhancement someone is going to have to write such a crate to make the enhancement useful.  The state machine involved has to do fun stuff when transitioning between Bytes elements.
Either that, or my crate search skills are terrible.


fix(network): Ignore out of order Address Book changes, unless they are concurrent

Motivation
We want to ignore earlier address book changes which are delayed, so we don't accidentally reset the peer state to an earlier value. But some changes can be concurrent, so the change application order doesn't always match the network order.
Close #6672
Specifications
There is no formal specification for peer network behaviour, but in general, the peer's internal address book state should reflect the actual behaviour of its peers.
Complex Code or Requirements
This code runs concurrently, it is accessed from both the address book updater task and the candidate set peer dialler task.
Changes can arrive earlier or later than their network order because of:

waiting on the address book mutex
async runtime or OS thread scheduling
monotonic clock resolution, or OS or hardware time bugs
wall clock time updates

The application can also independently initiate a change to the connection state, which can be simultaneous (or before) a change from the peer. In this case, the application-provided change needs to take priority. (Because it is typically failing the connection.)
Solution
Fix the code that applies changes to the address book, so that:

Concurrent changes are applied if they progress the connection state, but ignored if they revert it
Much earlier changes are ignored, even if they progress the connection state

Refactor the code that applies changes so it is easier to read.
Add TODOs for further changes that are not required to fix this security issue.
Testing

Add tests for the failure and success cases for the new checks, the extra success cases are:

Much later changes are applied, even if they revert the connection state

Allow tests to provide synthetic times for address book updates

This resolves some technical debt caused by a partial refactor
Calling time APIs less will also improve performance on some systems

There are existing tests for the other kinds of changes.
Review
This is one of the more complex audit changes that we have left to do. I'm happy to do a video review if that helps!
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[x] How do you know it works? Does it have tests?

Follow Up Work
Make it much harder for remote peers to delay changes by flooding the change channel:

#6738

@oxarbitrage I'm going to go ahead and merge this PR now to avoid merge conflicts.
Feel free to review it or skip the review, whatever you work out with Pili.


CreateBackground ignores custom load function

When CreateBackground is to load images files, it goes looking for a function called 'load_image' in the relevant instrument module, ignoring any custom load functions that the pipeline might have been set up with. This is inconvenient for example if you want to load raw Bayer images, and have included conversion to RGB as part of the load function.
Suggest using the load function from the pipeline instead.

This should be fixed by #166 - can you check that it does @nordam ?

Closing this as the fix is merged into the Dev-1.2 branch.
can reopen if we are not happy


UI to answer the questions in Q&A Section Added

Issue that this pull request solves
Closes: #886
Screenshots
Here you can see it passes while builting.

Hello @Kajol-Kumari
It's fixed now


can't build RAC images

Error processing tar file(exit status 1): write /data/scripts/install/linuxx64_12201_database.zip: no space left on device

This error indicates you have insufficient disk space for the zipfile to be extracted. Please use an alternate system or clean up some space before trying again.
If you continue to have issues please reopen the ticket.


section 9 clarify

@jonathan (dont know your github tag)

line 95: i know ssh tunnel needs to be recreated every once in a while, but i'm not sure is it every terminal session, or dev session, or how exactly to specify it

can you make a copy pasteable link in the hosting, and then we can modify the instructions to reflect that
can you write a command to check if the hosting tunnel is correctly set? or was it to check something in the browser?

@jonathan (dont know your github tag)

line 95: i know ssh tunnel needs to be recreated every once in a while, but i'm not sure is it every terminal session, or dev session, or how exactly to specify it

can you make a copy pasteable link in the hosting, and then we can modify the instructions to reflect that
can you write a command to check if the hosting tunnel is correctly set? or was it to check something in the browser?

This is probably worth a discussion!  When we were troubleshooting, I mentioned just typing localhost:9090 into a browser to confirm that the tunnel was patent.  But even with that test, it's worth considering whether or not the "tunnel in a backgrounded session" strategy is the wisest for beginners.  It makes it hard to see what's going on.  If someone fails to create their tunnel properly for whatever reason, the user is likely to try again (which, depending on the reason for the initial error, will just continue to fail), and you can have a whole bunch of orphaned ssh processes just sitting there.  If I were writing these instructions for novices, I'd probably just use the command in interactive form so the user could be easily advised to simply exist the session and try again if things seemed to be going wrong, rather than provide instructions on how to kill <pid> for their unwanted backgrounded ssh sessions.  @nick1udwig what do you think?

Oh man, this is what I was hoping to avoid with a kit connect/kit disconnect.
As is, this will create a long-lasting ssh tunnel that will live as long as your machine is connected to the internet. I agree this leads to difficulties for newbs to diagnose what goes wrong.
I am fine changing this to be a foregrounded session -- but we need to test is carefully to make sure it works as expected and that the instructions are clear. @jurij-jukic do you want to take a shot at this or should I?

Re: proposed changes here, if we're going to put "variables" in the commands, we need to change the prose around 35; probably rip it out and replace it with discussion of the "variables"

Ok I'll figure out the commands & write a PR.

See #208

merged into #208, closing


Add information about the sync id to the exception

@iriberri can you please take care of this?

Looking good to me. Testing in staging.

retest this, please


Was missing a role identifier for reading virtual_templates resources.

Added the virtual_template_show role identifier for reading
    /api/virtual_templates/:id resources

https://bugzilla.redhat.com/show_bug.cgi?id=1392612

Another issue found while documenting v2.3.0
@jntullo please review.
/cc @imtayadeway @gtanzillo

This is a must for Euwe, will need a BZ.

@abellotti can you add a test for this?

LGTM! 👍

@abellotti I restarted the vmdb build since it failed for the es6-shim known issue.  Note, the BZ is marked as a blocker as of this morning.  Please add blocker label if that is correct.

Euwe Backport details:
$ git log -1
commit b5eb7caa29c3659a6888de36946c4b01a77adb73
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Thu Nov 10 10:21:57 2016 -0500

    Merge pull request #12452 from abellotti/api_virtual_template_resource_read_role

    Was missing a role identifier for reading virtual_templates resources.
    (cherry picked from commit 1a0ec9c8cb4304fe89e5c6daef39a632e14699a8)

    https://bugzilla.redhat.com/show_bug.cgi?id=1392612

@simaishi Please make Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1392612

Euwe BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1394335


Fix destroy not reversing the order of releases

Fixes #1775

It's not super obvious why the original code failed; but it has to do with non stable guarantee of sort.Slice while sort.SliceStable would work - but the new implementation is more direct (otherwise Reverse could be used too)
to see the bug:
https://play.golang.org/p/68u0D2781PW

also... a test? :) [repro for #1775 ]

@ldemailly Hey! Thanks for reviewing this. That's super helpful.
Re- test, I'd REALLY love to have one, but to be honest, I'm not entirely sure how I could reproduce it reliably. Reading your example, would it be theoretically enough to just have 7 or more elements to be sorted to reproduce it?
We already had a test that should ideally catch this kind of bug in https://github.com/roboll/helmfile/blob/master/pkg/app/destroy_test.go, but apparently it didn't due to that it only had 5 "groups" to be sorted https://github.com/roboll/helmfile/blob/ae942c5288895c84c79171e5446773e4cb41c4ce/pkg/app/destroy_test.go#L291-L295

Yes anything with 7 or more groups will fail in the old code
But even without an additional test (outside of testing the fragment and manual test I did too) can we get this merged/released, it's a pretty serious/critical bug - what is holding up the merge?

@ldemailly Thanks for confirming!

what is holding up the merge?

My spare time? 😉


Step to add VM's to backend pool are missing

The article should mention something about adding the VM's to the backend pool.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1895941d-fa70-08ea-53c4-c49a65300625
Version Independent ID: c41d9420-3dc5-5c49-8135-d208ee13bc14
Content: Quickstart - Create a Private Link service by using the Azure portal
Content Source: articles/private-link/create-private-link-service-portal.md
Service: private-link
GitHub Login: @malopMSFT
Microsoft Alias: allensu

@perktime
Thanks for your feedback! We will investigate and update as appropriate.

I think it's okay not to mention the VM creation step but it would be helpful to at least mention and link to an article on how to add the VM(s)/VMSS to the ALB backend pool. Technically, if you follow the steps in the article as is it won't work.

@perktime, Appreciate your feedback. We are working on editing the doc and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Network Error

Describe the bug
Continuous error message of "Network Error" even thought my internet connection is working fine. I'm not sure if it's referring to my network or a dependency's network.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-v5qmdh
Steps to reproduce
Run in preview window.
Expected behavior
"Network Error"
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 82131473,
  "usedJSHeapSize": 79289657,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = idevise
Chat ID = ce60e173dc0c

Additional context
My app was working perfectly on 10/10 around 1:pm EST. Then a series of changes lead to the app reverting to prior versions and throwing error after error. I keep running prompts to fix the same things over and over and it's chewing up my tokens. Is there a change log? I'd like to revert back to that version.

I have also had several additional error messages, including: "Server is not connected. Please ensure the server is running and refresh the page." and "Server connection failed. Please ensure the server is running and try again."

same for me- I'm completely unable to use bolt at all.

Same for me: network error


cstdint required in PcmFile.h

I could not compile this in GCC 13.2 due to missing definitions for uint32_t and alike. This was fixed by adding:
#include <cstdint>

Just before #include "WaveSampleTypes.h" in shared/PcmFile.h

It worked for me without this include but you're right it should be there. I've added it now. Thanks for telling me!


Add an option of "Today", "Yesterday", "Select other date from calendar" while adding expense instead of always fetching the current date

Today option added, yesterday and calendar section can be added together.


Add test suite

VERY HIGH PRIORITY. Hopefully, I can deal with this as soon as possible.

I am getting there. Some very specific features have been tested. Overall, many tests have to be written.


Update akka-persistence, ... to 2.6.10

Updates

com.typesafe.akka:akka-persistence
com.typesafe.akka:akka-persistence-tck
com.typesafe.akka:akka-slf4j
com.typesafe.akka:akka-stream
com.typesafe.akka:akka-stream-testkit
com.typesafe.akka:akka-testkit

from 2.6.4 to 2.6.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #22.

Superseded by #22.


The state of this repository/package

so looking through the open issues as well as the open pull requests it is pretty obvious, that this package is not actively maintained any more (v6 was released 3+ years ago, last commit merged was 1 year ago)
It's only a matter of time till the NodeJS runtime starts dropping stuff this package (or its dependencies) relies on and basically breaks this package.
Looking at the current recommended Laravel JS/CSS build system it seems, that Vite is the new hot system in town. There is indeed a Migration guide to help switching, but does this mean this package is actually dead?
I assume there are certainly enough non Laravel devs using this package to have a "Webpack for the 80% use case" as the website states.
Just wanted to ask what the official statement here is since we thought switching to this package meant we have nothing to worry about in the modern crazy JS world we live in for years to come but looking at the current state we are forced to switch again...

Please don't get this wrong, but let me just directly mention @thecrypticace as he is the last person who merged/committed to this repository.
I am an open source maintainer myself and can definitely respect if one doesn't want or can't contribute to a specific open source project any more for whatever reason - but an official statement would still be nice, so at least new people don't waste their time on a tool which doesn't get updated any more.

I tried using Vite, but it didn't fit into my workflow. I only managed to integrate Vite with Laravel; however, outside of Laravel, I couldn't seamlessly incorporate it into my workflow.
On the other hand, Laravel Mix integrates smoothly into all of my projects. It still functions well, but I would appreciate an up-to-date version that removes legacy code and aligns it with Vite's capabilities

I guess no answer is also an answer...

The last commit is mine, but it's a PR not merged by me. I'm not in any way officially related to this project, so afraid I can't help out here.

I'm in the same boat as @LordSimal. It would be nice if there can be some comment on the future of Laravel Mix. I tried to install Mix in a project today and it threw up multiple dependency deprecation notices, which concerned me. Really like Mix's simplicity and would love for it to continue to be alive and kicking. :)

Its pretty obvious that this is dead. Sad to see, but we have to accept it.
Its good that it still works (even though there are deprecations) but I wonder what the next bundler project will be.
Vite is obviously not a direct replacement for this, so the "easiest" solution right now would be to manually create 2 npm scripts to build the JS via e.g. RollUp and SASS/SCSS directly to get a compiled, browser compatible main.js and style.css

Thanks for your comment, @LordSimal. I guess I'll try the simple npm scripts route only.

Sad, lesson learned to avoid relying on Laravel projects for since they seem to constantly move to the next hot thing.
I used parcel-bundler before Laravel mix and that seems to still be the best replacement for painless general purpose js/css bundling that can be dropped into any project..


Initializing TFLite model causes crash on iOS

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.5.0

Describe the current behavior
The model only has a preprocessing layer, being converted and tested to run successfully in Python environment. But when initializing this model on iOS project, it causes a crash on this side.
Describe the expected behavior
Expected to initialize and run successfully on iOS project.
Standalone code to reproduce the issue
Use the get_mel_spectrogram() function from kapre, here, to create a custom mel-spectrogram layer in Tensorflow, then, convert to TFLite.
Both the conversion and inference process run successfully in the Python environment but fail when initializing this model on the iOS project. The iOS project is mainly based on this Tensorflow iOS tutorial.
For convenience, the TFLite model is here
Other info / logs Log of the crash on iOS:
Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0xd4000000010691ad
VM Region Info: 0xd4000000010691ad is not in any region.  Bytes after previous region:<PHONE_NUMBER>5021593006
      REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      commpage (reserved)<PHONE_NUMBER>-7000000000 [384.0G] ---/--- SM=NUL  ...(unallocated)
--->
      UNUSED SPACE AT END
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [3629]
Triggered by Thread:  0
Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   MyApp                   0x0000000105eca898 0x10293c000 + 56158360
1   MyApp                   0x0000000105eca884 0x10293c000 + 56158340
2   MyApp                   0x0000000105ec8fc0 0x10293c000 + 56152000
3   MyApp                   0x0000000105eca670 0x10293c000 + 56157808
4   MyApp                   0x0000000105ec4054 0x10293c000 + 56131668
5   MyApp                   0x0000000106138eb0 0x10293c000 + 58707632
6   MyApp                   0x00000001066a698c 0x10293c000 + 64399756
7   MyApp                   0x000000010677f398 0x10293c000 + 65287064
8   MyApp                   0x00000001068d7c54 0x10293c000 + 66698324
9   MyApp                   0x00000001068d850c 0x10293c000 + 66700556
10  MyApp                   0x0000000106748880 0x10293c000 + 65063040
11  MyApp                   0x0000000106748760 0x10293c000 + 65062752
12  MyApp                   0x0000000106679834 0x10293c000 + 64215092
13  MyApp                   0x00000001066791dc 0x10293c000 + 64213468
14  MyApp                   0x0000000106675c30 0x10293c000 + 64199728
15  MyApp                   0x0000000106675828 0x10293c000 + 64198696
16  MyApp                   0x000000010665df2c 0x10293c000 + 64102188
17  MyApp                   0x000000010665f35c 0x10293c000 + 64107356
18  UIKitCore                       0x00000001b5e3b27c 0x1b5308000 + 11743868
19  UIKitCore                       0x00000001b57d0254 0x1b5308000 + 5014100
20  UIKitCore                       0x00000001b57d0598 0x1b5308000 + 5014936
21  UIKitCore                       0x00000001b57ceed0 0x1b5308000 + 5009104
22  UIKitCore                       0x00000001b5e75f8c 0x1b5308000 + 11984780
23  UIKitCore                       0x00000001b5e778b4 0x1b5308000 + 11991220
24  UIKitCore                       0x00000001b5e52e50 0x1b5308000 + 11841104
25  UIKitCore                       0x00000001b5ed545c 0x1b5308000 + 12375132
26  UIKitCore                       0x00000001b5ed9bfc 0x1b5308000 + 12393468
27  UIKitCore                       0x00000001b5ed0ee0 0x1b5308000 + 12357344
28  CoreFoundation                  0x00000001b3551be0 0x1b34b7000 + 633824
29  CoreFoundation                  0x00000001b3551ae0 0x1b34b7000 + 633568
30  CoreFoundation                  0x00000001b3550e28 0x1b34b7000 + 630312
31  CoreFoundation                  0x00000001b354b3d0 0x1b34b7000 + 607184
32  CoreFoundation                  0x00000001b354ab90 0x1b34b7000 + 605072
33  GraphicsServices                0x00000001c986d598 0x1c986a000 + 13720
34  UIKitCore                       0x00000001b5e34638 0x1b5308000 + 11716152
35  UIKitCore                       0x00000001b5e39bb8 0x1b5308000 + 11738040
36  libswiftUIKit.dylib             0x00000001c6325b54 0x1c6312000 + 80724
37  MyApp                   0x000000010667101c 0x10293c000 + 64180252
38  MyApp                   0x0000000106670f94 0x10293c000 + 64180116
39  MyApp                   0x00000001066710b4 0x10293c000 + 64180404
40  libdyld.dylib                   0x00000001b3229588 0x1b3228000 + 5512
Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x000000016d4bf510   x1: 0x0000dc41303f3980   x2: 0x0000000000000003   x3: 0x0000000105eca83c
    x4: 0x000000016d4bfd68   x5: 0x000000016d4bfd60   x6: 0x0000000000000073   x7: 0x000000016d4bfad8
    x8: 0x34000000010691ad   x9: 0x00000002803c3980...

Can you also provide the exact code that you used? Or did you use the unmodified version of the example app and just replaced the model file in it?
Without the exact reproduction steps, I can only guess that this is probably caused somewhere around setting the input / output tensors in your app code.

I actually modified the source code to meet my purpose, but I believe it is not too different from the original version of the example app.
To be more specific, the app crashes as soon as we initialize the model, which is this line of code:
interpreter = try Interpreter(modelPath: modelPath)

So I believe you can reproduce the issue with the example app code and the model I provided above. If the issue is not reproduced, please tell me so we can investigate further.
Another insight that I gained throughout different trials was to

Implement a TF Layer using customized TFLite-compatible version of STFT (which is here) --> This works OKAY on iOS.
Implement a TF Layer using the TF implementation of STFT and convert it to TFLite (I also used SelectOps for this option)  --> This causes crash on iOS but works okay in Python environment.

So my guess is the STFT itself, but you may find another root cause of this issue.

Using the unmodified Sound Classification example with TFLite v2.5.0 dependencies with your model, I get a different error:
2021-09-09 22:05:18.309457+0900 SoundClassification[94397:26097954] Initialized TensorFlow Lite runtime.
2021-09-09 22:05:18.309730+0900 SoundClassification[94397:26097954] Created TensorFlow Lite delegate for select TF ops.
2021-09-09 22:05:18.311150+0900 SoundClassification[94397:26097954] TfLiteFlexDelegate delegate: 1 nodes delegated out of 59 nodes with 1 partitions.
Fatal error: Index out of range: file /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-1<IP_ADDRESS>/swift/stdlib/public/core/ContiguousArrayBuffer.swift, line 444
2021-09-09 22:05:20.487987+0900 SoundClassification[94397:26097954] Fatal error: Index out of range: file /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-1<IP_ADDRESS>/swift/stdlib/public/core/ContiguousArrayBuffer.swift, line 444

Based on the log message, it doesn't seem to be crashing immediately after the TFLite runtime initialization.

Hi @tranctan
The Podfiles for sound classification ios example are updated with commit https://github.com/tensorflow/examples/commit/3df76a9e45e3a1d6165e42c565a2f8622f7c1f8c.
Can you please check in latest version and let us know if you are stale facing the issue?
Thanks.


Adding information about RISC Zero Secure SDLC

Adding secure-sdlc information.

OK great -- links are working & tests are passing.
Tagging @flaub and @jbruestle for review.
You can see the content in context here: https://docs-website-e3i2vfo3u-risczero.vercel.app/api/next/secure-sdlc
I'll duplicate the changes to 1.0 once we finish review here.


⚠ ClamAV has degraded performance

In 409aed0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in 9d87ed7.


Updated README to add compatibility with PHP 8.1

And it would be nice if the "About" text of the GitHub repository could be changed to "PHP 8.1 compatible version of ZF1 ":


Add preliminary tests for all database Query types

These tests mostly just check that new queries returned from the
pool are reset correctly.

Codecov Report

Merging #14 into master will increase coverage by 4.47%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   38.88%   43.35%   +4.47%
==========================================
  Files          61       61
  Lines        2554     2558       +4
==========================================
+ Hits          993     1109     +116
+ Misses       1544     1432     -112
  Partials       17       17

Impacted Files
Coverage Δ

query/cassandra.go
95% <100%> (+95%)
:arrow_up:

query/timescaledb.go
92.3% <100%> (+92.3%)
:arrow_up:

query/mongo.go
92.3% <100%> (+92.3%)
:arrow_up:

query/http.go
93.75% <100%> (+93.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a9320...722208e. Read the comment docs.


fix#29319 - ios dismiss modal

This PR aims to resolve iOS can't dismiss Modal on swipe gesture.
https://github.com/facebook/react-native/issues/29319
Summary

When modal presentationStyle is pageSheet, iOS allows to dismiss the modal using swipe gesture. This PR adds support for that feature
Changelog

[iOS] [Added] - Support for onRequestClose for iOS Modal component.
Test Plan

If onRequestClose updates the visibility state, modal will be closed.

<Modal
    visible={visible}
    animationType="slide"
    presentationStyle="pageSheet"
    onRequestClose={dismiss}>
</Modal>

https://user-images.githubusercontent.com/23293248/117590263-36cd7f00-b14c-11eb-940c-86e700c0b8e7.mov
Notes

In this PR, only support for partial drag is added. i.e. user can't drag the modal up and down completely. I added full user dragging but reverted in this commit to support controllable onRequestClose. If someone has any suggestion to have full draggable support + controllable onRequestClose, please let me know.

When this will be merged? It doesn't make any sense.

@intergalacticspacehighway awesome! Thank you for working on this.
We might need to change documentation for Modal onRequestClose

Hi @sammy-SC  @intergalacticspacehighway How can we merge this PR? this is open for a couple months now.

@sammy-SC Updated the docs for the same. Let me know if any changes are needed! :)

@feedthejim Could you review this and merge?

@sammy-SC thank you for previously taking a look at this. It looks like @intergalacticspacehighway updated the docs, is there anything else outstanding?


Update declaration page for draft claim

Context
This mainly removes the change links on the check page for the draft claim, when a normal user tries to submit a draft claim.
The change links are on the show page now.
Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots

 Update the declaration page to be distinct from the check page


Add tests for KTable

Master Issue: #1266
Motivation
#1266 reports that KTable doesn't work for a KoP enabled cluster. It turns out while we have tests for GlobalKTable we don't have tests for KTable.
Modifications
Add tests similar to GlobalKTableTest but for KTable. The tests pass which means #1266 might have been caused by something external to KoP.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added KTableTest

Documentation
Need to update docs?

[x] no-need-doc
Test only

The license is wrong, please fix it first.

ping @ZiyaoWei


Addition of boss banner

Adds the Boss Banner

On the smallest of screens, the height may not be enough to fit its content.

use the styles prop to change the height, it is a mistake from bdp-ui.
<Banner
        headingText="Start your career in bitcoin open source —"
        linkText="APPLY TODAY"
        linkTo="/"
        hasBoss
        styles={{
          container: "h-[auto_!important] py-2"
        }}
      />

styles={{
container: "h-[auto_!important] py-2"
}}

Thanks

Thanks

That was a preemptive suggestion, we do animate height so this overwrites what we have and breaks the close sequence


WIP: Shared subscriptions

To use with aedes https://github.com/moscajs/aedes/pull/449

@robertsLando Is there anyway i can help you on that one ?

@getlarge Last time I tried I had give up as I wasn't sure this was the correct way to implement this feature. I would like some thoughts on this and https://github.com/moscajs/aedes/pull/449 by @mcollina

This requires implementing an equivalent of mqemitter for the shared work queue, or adding that same concept there.


Update compiler-plugins.md

can't enable ResearchPlugin if add -experimental option.

partially revert https://github.com/scala/scala3/pull/18571
see also https://github.com/scala/scala3/pull/19841

this does raise the question of if research plugins perhaps should be enabled if there is -experimental - i.e. which poison pills the API anyway from being used in stable


Add Uncertianty to Residential Depth Damage Curves Consistent with EGMs

this will primarily impact the occupancy type map -

completed 10/31 by @rnugent3


About label generate

Hello, I am a bit confused about the calculation of the classification loss in your code. If you have time, can you give me an answer?
https://github.com/fredzzhang/spatio-attentive-graphs/blob/main/interaction_head.py#L182
In your postprocess function, you pass in the one-hot form of the prediction result of each pair and the one-hot form of the label. Next, you use a series of magic operations to convert the one-hot form of the label into one I don't quite understand things.

See #49


Elevate option without a log file does not display the output to the console

If logfilepath not specified, elevate option should redirect content to console.
Option to skip this behavior. --ignoreoutput.

Fixed.


Unable to open app when phone call is received from locked state.

I wan't to run some service sdk and functionality from app when user receive call but that need to run when app is opened so I wan't to open app in case of user received call in terminated and locked state as well. Please let me know how I can open app when user receive call in locked state.
This is for iOS application and version 13.0 or greater
Thanks

Hi @vaibhavtech1302
The quickstart sample app should be able to let you receive incoming call when the app is in the background or when the device is locked. Once the call is answered, in the system call app you should see a button letting you go to your app (passcode/Touch ID/Face ID will be needed if the device was locked).
Cheers,
-bobie