ERR_CERT_DATE_INVALID after renewal on gce

I see in the logs of kube-lego that the certificate was renewed but my browser still shows ERR_CERT_DATE_INVALID. What do I need to do to use the new one, any ideas?

I don't know inner workings of kube-lego, but my guess is that it should have updated the secret on the Ingress (which I expect that it would have uploaded the new TLS secret to the Google Cloud and configure it on the Load Balancer).

Can you find the value of ssl-cert annotation in kubectl describe ingress <name> and check if this value matches the certificate column on the Load Balancer console? (example below)

Can you check the expiration date served to your browser, and see if that matches what's stored in the kubectl get secret <secretname> -o=yaml (I'll leave it up to you to figure out how to save and parse the certificate using openssl).

The values don't match:
On the ingress describe I get: k8s-ssl-default-loadbalancer--cbee26f7d1895ddb and in the load balancer console I get: k8s-um-default-loadbalancer--41dc2c3938d90731

@ciokan  Are you looking at the Certificate column in the console? It looks like you're looking at the title of the load balancer. See my screenshot, it has a Certificate column on the right.
What I will suggest is that:

check if values match
check if the cert thumbprint matches.  First find the TLS certificate on the Google Cloud Load Balancer (you can click on the Certificate name and see a Serial Number, for example mine is:
03:82:05:24:0C:41:0F:D1:6C:A0:6E:A4:43:89:7D:5F:B1:88) Then go to browser's cert information window, compare these two strings.
Assuming (2) is matching, you should download the secret saved on Kubernetes to your machine and verify that the thumbprint is the same too. If the thumbprints are the same, kube-lego probably didn't save the renewed secret.

I am particularly interested in helping out as I've seen before that kube-lego log statements can be misleading and we all need this feature to work.

yes the certificate or title point to the same "id":
k8s-ssl-default-loadbalancer--41dc2c3938d90731
Whatever is loaded in the loadbalancer expired on april 26:
Expires
Apr 26, 2017, 3:03:00 AM
Serial Number
03:46:43:E3:DB:BF:05:9B:B9:0E:9E:63:11:AD:B1:3F:23:D4
Certificate Issuer
Let's Encrypt Authority X3

In the kube-lego pod logs I can see a different story:
2017-04-30T14:26:04.078240149Z time="2017-04-30T14:26:04Z" level=info msg="cert expires in 88.0 days, no renewal needed" context="ingress_tls" expire_time=2017-07-27 13:47:00 +0000 UTC name=loadbalancer namespace=default
2017-04-30T14:26:04.078331927Z time="2017-04-30T14:26:04Z" level=info msg="no cert request needed" context="ingress_tls" name=loadbalancer namespace=default

I'm curious as to why it's not present in the loadbalancer, it seems to have kept the old one.

Ok it looks like the certificate object on the ingress is not updated. I am not sure if Ingress is supposed to pick up values of an "updated" secret it is already configured with... Let's try inspecting  the secret itself:
First, save the secret out:
kubectl get secret SECRET_NAME -o jsonpath='{.data.tls\.crt}' | base64 -d | tee tls.crt

then inspect the validity date of certificate:
 openssl x509 -in tls.crt -text

Can you verify if the serial number is different or the same on this output (and see the validity date).
Let's figure out if kube-lego has actually updated the secret just fine and that's why it thinks there's 88 more days to its expiration.

This one seems ok.
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            03:86:3c:38:40:8a:1c:e3:be:41:7c:ab:8a:77:67:b8:4a:10
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=US, O=Let's Encrypt, CN=Let's Encrypt Authority X3
        Validity
            Not Before: Apr 28 13:47:00 2017 GMT
            Not After : Jul 27 13:47:00 2017 GMT

Thanks. This is a bit scary. I am nowadays evaluating the LetsEncrypt clients for Kubernetes out there and this is certainly something worth considering while using such projects.
I think now the owners of the project can be asked the following question:

Is kube-lego responsible for making sure that the Ingress is picking up the renewed secret? If this is the responsibility of the Ingress (and not kube-lego), is this guarantee been tested before with the GCE ingress? It looks like the Cloud Load Balancer is not reconfigured when the TLS secret associated with the Ingress is updated.

Bummer. I loaded this thing into a lot of applications. I'm still hoping it's some sort of a "my fault". This project has quite some time behind it and I failed to find any similar ticket. Maybe someone from the dev team can shed a light.

Is kube-lego responsible for making sure that the Ingress is picking up the renewed secret? If this is the responsibility of the Ingress (and not kube-lego), has this guarantee been tested before with the GCE ingress? It looks like the Cloud Load Balancer is not reconfigured when the TLS secret associated with the Ingress is updated

No, kube-lego doesn't manage the certificates in the load balancer, it only create the certificate secrets.  GCE ingress is watching the objects and it's responsible for change the ssl certificate at the load balancer.
I saw some improvements on gce when it's managing certificates #639. Please test the latest release and let us know if this solve this issue.

@gianrubio thanks for linking to this issue. I'm not sure if this patch solves updating TLS configuration on GCLB when the Secret(s) associated to an Ingress is updated :/
How does one update the ingress controller in GKE (I can't find it in my cluster). So I don’t know which version of ingress controller is even running. (Any ideas?) This will be hard to test anyway.
I wonder if the project authors have seen the cert refresh flow working on GCE/GKE before. A statement like “we never tested this” or “we’ve seen it working before” would kind of help.

Apart from upgrading my kubernetes version to 1.6.2 (latest offering by GKE) and trying to re-apply my ingress in hope of it picking up the new changes I don't know what else to try.
My website is failing to respond due to this issue for 1 week already and I have no clue what else to try. It's a side project with nothing serious on it otherwise I would have bought a SSL immediately so I'll wait a bit more until we get to the bottom of this.

@ciokan It looks like your website is running on another certificate currently?
Here's what I would recommend to test if the upgrade fixes the problem:

Download the expires cert/key from Google Cloud Platform Console (I hope you still have these on your existing load balancer).
Delete your ingress.
Upgrade your GKE cluster
Remove kubernetes.io/tls-acme: "true" annotation from your ingress manifest
Delete your existing tls secret.
Create new secret (with the old name) and use the expired cert/key
Deploy your modified ingress manifest.
Make sure you get a cert expired error on browser.
Kube-lego won't do anything because there's no annotation.
Put the tls-acme annotation back and kubectl-apply.
Watch kube-lego logs to see if it refreshes the certificate
Go back to Google Cloud Platform Console and see if the Ingress Controller has updated the LB with the new certificate.

@gianrubio thanks for linking to this issue. I'm not sure if this patch solves updating TLS configuration on GCLB when the Secret(s) associated to an Ingress is updated :/

How does one update the ingress controller in GKE (I can't find it in my cluster). So I don’t know which version of ingress controller is even running. (Any ideas?) This will be hard to test anyway.

I have no idea how to upgrade it, you could ask on http://github.com/kubernetes/ingress

I wonder if the project authors have seen the cert refresh flow working on GCE/GKE before. A statement like “we never tested this” or “we’ve seen it working before” would kind of help.

Last week I tested this feature , as I described on #180 on how to test the renew certificate. I bootstrapped a new cluster on gce (v.1.6.2), configured the env LEGO_MINIMUM_VALIDITY to a low value (1 hour).and all the certificates are correctly renewed.
Probably I'm addicted on how to run kube-lego. If you're able to do the same as I describe above can help us to figure it out.


linking fails on Dragonboard 410c with multiple definitions

version.c.o multiple definition of `gVERSION'
mraa.c.o first defined here

The file version.c is generated automatically and is conflicting with the existing definition in mraa.c.
Anybody knows how to fix this?

The file version.c is generated automatically and is conflicting with the existing definition in mraa.c.
Anybody knows how to fix this?

Hi @jpelletier,
Have you tried disabling the tests? This might be caused by trying to build with missing dependencies:
Take a look at the CMakeLists.txt file.

did u find any fix ?

did u find any fix @jpelletier?

See Propanu's comments. When disabling the tests, it works.

@jpelletier Thank you for the hint.
I solved the issue by specifying the two constants as extern, as the version.h header file only sets their declaration. The version.c source file provides their values.
extern const char* gVERSION;
extern const char* gVERSION_SHORT;

Can we backport this fix to the latest version?


getText() on an empty EditText returns placeholder

I have an MaskedEditText as follows:
<br.com.sapereaude.maskedEditText.MaskedEditText
	xmlns:mask="http://schemas.android.com/apk/res-auto"
	android:id="@+id/registration_citizenship_info_social_security"
	style="@style/RegistrationEditText"
	android:layout_width="match_parent"
	android:layout_height="wrap_content"
	android:typeface="monospace"
	mask:allowed_chars="1234567890"
	mask:mask="###-##-####"
	android:hint="123456789" />

When I don't fill anything in and I call getText(), this returns me the hint (123-45-5689), instead of an empty String. getRawText() does return me an empty String if nothing was filled in, but if something was filled in, this returns me the value without formatting, which is also not what I want.

Hey SammyO,
This is not the issue of this library. This is actually EditText's "feature"(I think it's feature, because, I am having the same issue... Getting hint in getText(), instead of empty EditText. However, in stackoverflow, they keep saying that android:hint feature never gets when called getText()... Haven't tried it yet, but there is something about it...
Anyway, I cleared that line.
Sorry for my English. Haven't been practising it.

@SammyO instead of getText() use getRawText().
@PokerAsh the same to you :) "Raw" text - is the text w/o mask. So if you need a text w/o mask - give getRawText a try! :)
p.s. No worries, your English is good!


notFound(), route loader, and initial application loading.

Describe the bug
Following the documentation I was able to setup a dynamic route, load some data, and if something doesn't exist, display not found.
This works as expected when navigating throughout the app (using the router). but once I refresh on a known-broken item, the default not found component does not render but the error component does.
Your Example Website or App
https://stackblitz.com/edit/github-3cnvav?file=src%2Froutes%2F__root.tsx,src%2Froutes%2F%24type.%24id.tsx
Steps to Reproduce the Bug or Issue
Navigate to each tab on render. you will see that unknown shows as not found.
now, in the address bar (above the render,) append /unknown/idthe application will reload and show the error component.
Expected behavior
I would expect not found to show once the application loads
Screenshots or Videos
No response
Platform

latest macOS
Brave/Chrome
tanstack router v. 1.26.11

Additional context
If an activity/id exists and a user bookmarks/saves the url, if they go back and it no longer exists, i would expect them to see the appropriate not found message, not an error.

I have the issue but only if I set the value 0 to defaultPendingMs when configuring the router instance.

Try again with the version I just released today?

please try again with https://github.com/TanStack/router/releases/tag/v1.28.2
this is the release Tanner referred to but was not released until now

Try 1.28.2

Re-tested with 1.28.7 and can confirm the original issue has been resolved.
Sandbox: https://stackblitz.com/edit/github-3cnvav-e5bwfj?file=src%2Froutes%2F%24type.%24id.tsx


Feat: Add smooth scrolling transitions and integrate Tailwind CSS and node

Describe the feature
I'll enhance the user experience on our website by adding smooth scrolling transitions and integrating Tailwind CSS for consistent styling. This will improve both the aesthetic and functional aspects of the site.
And I'll add new features .
And I'll Improve Footer design.
I'll be happy to reslove it asap.
Add ScreenShots
[

]
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Mujtabaa07 you are assigned.


Edits made

some grammartical errors were corrected

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

Please accept as it's the end of hacktoberfest.
Thank you.

@att55 Maybe flag this PR as invalid as proposed at https://hacktoberfest.digitalocean.com/faq.

@MarcSteven @koppor Thank you for your comments. I suppose you are probably right.
I think she should have tried to use this tool at least once before created this PR... because the load of maintainers might increase... 💧


Can you tell me the CVE num about this UAF bug?

Can you tell me the CVE num about this UAF bug?
thanks!

Not committed yet. Not so much useful after a few investigations.


Include static pages

e.g.

faq / rules (/faq/)
formatting (/faq/#formatting)
irc (/irc/)
contact moderation (/contact/)
other (/other/ or /pages/other)

especially after styleswitcher is implemented

Cool idea!

I could use the markdown system we have now for page building!


fix: Show Join & Leave buttons on empty threads

Details
Allow users to join an empty thread by showing the "Join" and "Leave" buttons in the Header
Fixed Issues
$ https://github.com/Expensify/App/issues/34054
PROPOSAL: https://github.com/Expensify/App/issues/34054#issuecomment-1879125994
Tests
Same as QA
Offline tests
Same as QA
QA Steps

Go to any chat
Send a message
Right-click on the message > Unsubscribe from thread
Right-click on the message > Reply in the thread

[ ] Verify the "Join" button is present in the Header

Click "Join"
Click the 3-dot menu

[ ] Verify the "Leave" button is present in the 3-dot menu

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/12595293/9cfec3aa-8f4d-4ffb-bdae-d37c6d6b913f

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/26373aa8-0f8a-4ab2-b835-318ca0a58691

iOS: Native
https://github.com/Expensify/App/assets/12595293/65ccf3c6-69bd-49e1-a2c2-cc7faa599eb9

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/941dcfca-81e8-449e-b9bc-0ff4c5aad571

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/3445c4e4-935c-42b0-a65b-b8d0cbf83d4b

MacOS: Desktop
https://github.com/Expensify/App/assets/12595293/bb2c478b-a397-498d-8ad5-5f591c8f7c53

What's the next step here?  Who is doing it, and when?

What's the next step here?  Who is doing it, and when?

It's done from my side, waiting for the C+ review now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Hey @Ollyws and @paultsimura, looks like there was a regression from this PR. Do you think we could get a fix merged by the end of the week?

Hey @Ollyws and @paultsimura, looks like there was a regression from this PR. Do you think we could get a fix merged by the end of the week?

That's not a regression. Added more info here: https://github.com/Expensify/App/issues/34649#issuecomment-1898088479


fix(electron): avoid incorrect dispose of connection

Types

[x] 🐛 Bug Fixes

Background or solution
in the electron version, if some secrity software connect our ipc socket and then leave, the server will dispose all service, this is an wrong behaviour.
Changelog
[electron] avoid incorrect dispose of connection

LGTM


Could use more elaboration on RBAC with Azure Storage Explorer

The document says "Azure Storage Explorer currently uses your storage account key to access blob and queue data."
Does this mean that RBAC doesn't yet work from Azure Storage Explorer? That seems to be what I'm experiencing but want to make sure.
Is there any documentation on how to restrict delete access to blobs via Azure Storage Explorer?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90a4bd03-9c86-4c9b-5834-c2966c2f3720
Version Independent ID: a070cc29-15aa-c072-b90b-64c616ef51cc
Content: Authenticate access to Azure blobs and queues using Azure Active Directory (Preview)
Content Source: articles/storage/common/storage-auth-aad.md
Service: storage
GitHub Login: @tamram
Microsoft Alias: tamram

@samiam236 That's a good question ! As of now, there is no way to limit access to the specific storage account using Storage Explorer. It currently only uses SAS or subscription for your account. I'd highly recommend posting this as a feedback so the Product Group team checks it: https://feedback.azure.com/forums/217298-storage We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@Adam-Smith-MSFT thanks for the explanation!
Feedback submitted: https://feedback.azure.com/forums/217298-storage/suggestions/36161128-allow-role-based-access-control-in-azure-storage-e


confuse about pin mux

hi guys.
i have question about  "Customizing pinout",
In the docs.

pwmA mapping to pin 9/10
pwmB mapping to pin 3/5
But , according the  note below
 Now, there is a lot of possible pin configurations and not all of them are possible depending on the microcontroller and sensor you are using. For example, Arduino UNO only has 2 external interrupt pins, and they are pin 2 and 3. Therefore when using the board with Arduino UNO and Encoder we will try to use pin 3 for encoder channel A and not for pwm A.
it seems mean that  PwmA should  mapping to pin3  instand 9/10.
version2.03 board ,also design that pinA mapping to pin 3/5.

is that means  this pinmux(in docs) is  out of date?
I am confused.

,

which one is right?

Yeah, it's the docs. It was an example pin out for the earlier version of the board.
Whatever is indicated on the board itself is the right configuration.
We try to keep the docs as up-to-date as possible, but these kinds of stuff are sometimes difficult to detect :)
We'll update it as soon as possible.

Got it,  thanks for your reply.


The link to deconv paper is broken in Conv2DTranspose comments

This is very minor, but the second link used as reference in Conv2DTranspose seems to be invalid.
It can be changed from https://www.matthewzeiler.com/pubs/cvpr2010/cvpr2010.pdf to https://www.matthewzeiler.com/mattzeiler/deconvolutionalnetworks.pdf.

Pull request welcome.

I will work on this.

https://github.com/keras-team/keras/pull/11947


Added Google Analytics event tracking for download button

Added proof of concept Google Analytics event. When the user clicks the download button, the event is sent.
I will check it off once we see that its working. No sense in writing them all now.

We can merge into a Google Analytics branch and not that master, so don't merge yet.

I included a few more commits regarding contributing and readme

These commits should've been on a separate pr. We might want to close this pr and create a separate one for the contributing guidelines commits and another for the GA.
Make sure to name the branches something good instead of Pipe-to-Grep-patch-1. Thanks!

i will make separate ones. i realised what i had done afterwards. i still dont know how to test the GA.

Check my issue #72 comment with a link of how to test GA locally.

I messed up the branch, so just approve, merge, and close. I'll uncomment and add GA functionality in a GA branch


proposal: net/http: make nil *Client equivalent to zero Client

net.Resolver in currently allows the following (ignoring #24330):
var r *net.Resolver
fmt.Println(r.LookupHost(context.Background(), "example.com"))

Note that nil *Resolver is equivalent to the zero Resolver.
I propose that using the nil net/http.*Client also be permitted. This is useful when allowing callers to specify a *Client to use for HTTP operations:
type Config struct {
	Client *http.Client
}

func (c *Config) Get() {
	resp, err := c.Client.Get("https://example.com")
	// Rather than:
	client := c.Client
	if client == nil {
		client = http.DefaultClient
	}
	resp, err := client.Get("https://example.com")
}

One concern imo is that this reduces to the problem with DefaultTransport. Specifically, DefaultClient uses DefaultTransport which uses DefaultMaxIdleConnsPerHost which frequently bites/surprises people due to its small size (2) especially relative to DefaultTransport's MaxIdleConns (100). This proposal would add another layer of obscurity from that unfortunate default. (If we decided to increase DefaultMaxIdleConnsPerHost in Go2, this wouldn't be an issue.)
You could argue that nil Resolver has a similar issue, but for stdlib's clients/transports you have the alternate option to create your own with better parameters, whereas there are no stdlib resolver knobs. Also, dns is much more lightweight than http so regular usage shouldn't run into the resolver's file descriptor limitation as much as DefaultTransport runs into DefaultMaxIdleConnsPerHost limitation.
Anyway, maybe the convenience is worth it.
/cc @bradfitz @odeke-em

I think this would've been fine (and probably good) had we started with this, but doing it at this point would cause a bunch of previously-correct code in the wild to now be crash-prone.
Anything that currently checks, say, an *http.Client's Transport or Jar fields now also needs to check whether the client's nil also.
Per discussion with the proposal review group, I think we should decline this.

I wonder if proposals of the type "we wish we had done this from the start" could be reconsidered for Go2 in bulk.


chore: upgrade to Datafusion 38

With v38, I think we can revert this temp fix: https://github.com/delta-io/delta-rs/pull/2395/files#diff-60c94c425cf655602ada7636a35fb8e25391bc92f5b9e35462562604449be324R1055

datafusion 38 should also close this issue: https://github.com/delta-io/delta-rs/issues/2188 with https://github.com/apache/datafusion/pull/10095

It could be nice to skip directly to DataFusion 39, which just dropped an RC — it depends on Arrow 52, which released a few days ago, and pyo3 0.21.1, meaning all three can be bumped together :) working on that PR rn


When searching with ⌥ + G, it doesn't work correctly

I get this :

Some white transparent text on the top and the results are strange too. Is this intended?

Ew … Yes, it works as intended, but not all.

The below uses youdao dict’s data (an English-Chinese translation service based in China). If you type really fast, the chance is the returned results may not catch up with you due to the network latency. But still, you can use English thesaurus (Ctrl + D).
The white transparent text on the top is “autosuggestions” (something like that), which is not part of Hammerspoon Chooser control. I simply “draw" a text frame above Chooser control to place word suggestions. The drawback is the text frame’s appearance don’t match Chooser control very well, though I could use more time to adjust it, even make its appearance to change according to the system’s Dark Mode preference.
For now if you found it is useless and disturbing, feel free to use the line below to disable it.
usesuggest = false
I'm thinking maybe I can put word suggestions into the below, and when the users stop typing for certain interval, retrieve translation data and replace the original data below. But I still need time to verify and test.

Ew … Yes, it works as intended, but not all.

The below uses youdao dict’s data (an English-Chinese translation service based in China). If you type really fast, the chance is the returned results may not catch up with you due to the network latency. But still, you can use English thesaurus (Ctrl + D).
The white transparent text on the top is “autosuggestions” (something like that), which is not part of Hammerspoon Chooser control. I simply “draw" a text frame above Chooser control to place word suggestions. The drawback is the text frame’s appearance don’t match Chooser control very well, though I could use more time to adjust it, even make its appearance to change according to the system’s Dark Mode preference.
For now if you found it is useless and disturbing, feel free to use the line below to disable it.
usesuggest = false
I'm thinking maybe I can put word suggestions into the below, and when the users stop typing for certain interval, retrieve translation data and replace the original data below. But I still need time to verify and test.

This makes sense, thank you.
I guess, this isn't really useful for me, only the thesaurus part is. :)
I wanted to ask you. How can I turn off all modes aside from RESIZE and VIEW :

I don't want them taking hotkeys as I want to use them for other things.

This makes sense, thank you.
I guess, this isn't really useful for me, only the thesaurus part is. :)
I wanted to ask you. How can I turn off all modes aside from RESIZE and VIEW :

I don't want them taking hotkeys as I want to use them for other things.

Yes, you can remove the default modules and add your own. See README.md 's Customization section.
Add the snippet below into ~/.hammerspoon/awesomeconfig.lua
module_list = {
    "basicmode",
}

You may find some hotkeys still work. From I can see from the above screenshot, including:

Enter app mode - OPT + A
Open Hammerspoon console - OPT + Z
Show window hints - OPT + Tab
Those hotkeys exists because their code are too short, creating a new module/file is not economic, so they are merged into one module/file.

Still, yes, you can modify these hotkeys or simply disable them.
appM_keys = {{}, ""}
toggleconsole_keys = {{}, ""}
winhints_keys = {{}, ""}

Yes, you can remove the default modules and add your own. See README.md 's Customization section.
Add the snippet below into ~/.hammerspoon/awesomeconfig.lua
module_list = {
    "basicmode",
}

You may find some hotkeys still work. From I can see from the above screenshot, including:

Enter app mode - OPT + A
Open Hammerspoon console - OPT + Z
Show window hints - OPT + Tab
Those hotkeys exists because their code are too short, creating a new module/file is not economic, so they are merged into one module/file.

Still, yes, you can modify these hotkeys or simply disable them.
appM_keys = {{}, ""}
toggleconsole_keys = {{}, ""}
winhints_keys = {{}, ""}

Thank you, this is perfect.
For some reason opt + tab does not worker me to show window hints, it just jumps through various UI elements within the window.

Thank you, this is perfect.
For some reason opt + tab does not worker me to show window hints, it just jumps through various UI elements within the window.


OSP-26: check for presence of routers [cherry-pick]

Reviewer: @wolverineav
Conflicts:
rhel/python-horizon-bsn.spec
setup.cfg

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com/job/openstack_horizon_bsn_pull_req/103/


Gantt charts

Add an extra visualization option: gantt charts. To create a better overview per team member when they will have a day off

We're closing old issues so we can get back to actively maintaining the extension. Feel free to reopen if this is still an issue for you.


NoMethodError: undefined method `[]=' for #<ActiveRecord::DatabaseConfigurations

Do you want to request a feature or report a bug?
report a bug
What is the current behavior?
I am opening this issue again, as the problem is occurring with me too.
After running the command to create the project:
$ padrino g project todo -t rspec -d activerecord -e slim
I run the command to generate a controller
$ padrino g controller Home
and the error occurs:
=> Problem loading ./config/boot.rb
=> undefined method `[]=' for #<ActiveRecord::DatabaseConfigurations:0x000000000353b210>
Did you mean?  []

My boot.rb file:
RACK_ENV = ENV['RACK_ENV'] ||= 'development' unless defined?(RACK_ENV)
PADRINO_ROOT = File.expand_path('../..', __FILE__) unless defined?(PADRINO_ROOT)

require 'bundler/setup'
Bundler.require(:default, RACK_ENV)

Padrino.dependency_paths.unshift Padrino.root('config/initializers/*.rb')

Padrino.before_load do
end

Padrino.after_load do
end

Padrino.load!

Which versions of Ruby, Padrino, Sinatra, Rack, OS are you using? Did this work in previous versions?
Ruby 2.7.2
Padrino v. 0.15.0

Looks like ActiveRecord 6.1.x deprecated that []= method that is being used in config/database.rb - I was just running into that too - I solved it by doing this (showing the lines I commented out and what they are replaced with). Obviously can be cleaned up a bit but this allowed me to create my db at all and keep working.
#ActiveRecord::Base.configurations[:development] = {
#  :adapter => 'sqlite3',
#  :database => Padrino.root('db', 'collector_development.db')
#}

#ActiveRecord::Base.configurations[:production] = {
#  :adapter => 'sqlite3',
#  :database => Padrino.root('db', 'collector_production.db')
#}

#ActiveRecord::Base.configurations[:test] = {
#  :adapter => 'sqlite3',
#  :database => Padrino.root('db', 'collector_test.db')
#}

db_hash_config = {
  :development => {
    :adapter => 'sqlite3',
    :database => Padrino.root('db', 'collector_development.db')
  },
  :production => {
    :adapter => 'sqlite3',
    :database => Padrino.root('db', 'collector_production.db')
  },
  :test => {
    :adapter => 'sqlite3',
    :database => Padrino.root('db', 'collector_test.db')
  }
}

ActiveRecord::Base.configurations = db_hash_config

Additionally to avoid the next warning
DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for)

replace the line
ActiveRecord::Base.establish_connection(ActiveRecord::Base.configurations[Padrino.env])

with
ActiveRecord::Base.establish_connection(ActiveRecord::Base.configurations.configs_for(env_name: Padrino.env)[0])


fix(lang/clojure): top-level symbols/quoted forms

Currently, if a Clojure source string contains a quoted form like '() or a symbol like x at the top-level, the entire string is not highlighted. This commit adds SYMBOL to the accepted top-level forms.

Now you have an autodetect conflict with go.  Could you take a look at that?

Ping.

@mhuebert Closing for inactivity.  If you have time to follow-up on this in the future we can re-open.  This would also need a markup test to be accepted so we can see what symbols look like and see that this change works as expected.
Regarding the failing test.  This match rule looks very broad... I'm guessing it's matching something that previously was matching another rule and therefore reducing the overall relevancy. You'd think it being last would avoid that, but I'm just guessing.


Refactoring: Rename LAST_SYNCED_L1_BLOCK to be more clear

Refactor
Closes Issue #1335 by refactoring LAST_SYNCED_L1_BLOCK to a struct named LastSyncedEventBlock which contains a block_number field and event_index field.
What is the current behavior?
When process_l1_message is called, the L1 block number is written to the MessagingDb.
Resolves: #1335
What is the new behavior?

When process_l1_message is called, a struct containing both the L1 block number and event_index is written to the MessagingDb.
Does this introduce a breaking change?

I'm not yet sure if/how the MessagingDb schema needs to be changed to accept the encoded Struct instead of previously-encoded u64 value. Accorrding to the SCALE encoding docs I believe structs get encoded as a vector of bytes, so it seems the difference is that a value twice the current size will need to be written to the DB.
Todo
I would like to write tests for this part of the code, and have asked a few questions in the issue thread asking how to approach this.

@tdelabro can you review this once?


prune --docker not yet implemented for nodejs-pnpm

What version of Turborepo are you using?
1.3.1
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
I was trying to build Dockerfile with Node.js application but it seems turbo doesn't work at all with pnpm - what should I do as temporary fix?
Expected Behavior
Success
To Reproduce
I was trying to build Docker image with following Dockerfile
FROM node:alpine AS builder
RUN apk update && apk add git
# Set working directory
WORKDIR /app
RUN npm i -g turbo@canary pnpm
COPY . .
RUN turbo prune --scope=server --docker

# Add lockfile and package.json's of isolated subworkspace
FROM node:alpine AS installer
RUN apk update
WORKDIR /app
COPY --from=builder /app/out/json/ .
COPY --from=builder /app/out/yarn.lock ./yarn.lock
COPY --from=builder /app/out/full/ .
COPY .gitignore .gitignore
COPY turbo.json turbo.json

RUN pnpm install
RUN pnpx turbo run build --filter=server...

FROM node:alpine AS runner
WORKDIR /app

# Don't run production as root
RUN addgroup --system --gid 1001 expressjs
RUN adduser --system --uid 1001 expressjs
USER expressjs
COPY --from=installer /app .

CMD node services/server/dist/index.js

Thanks for reporting, this is on the roadmap!
We have another issue for this here https://github.com/vercel/turborepo/issues/534 - so I'm going to close this to consolidate discussion there.


Vite hot reload fail

With react vite application, I got
DOMException: CustomElementRegistry.define: 'identicon-svg' has already been defined as a custom element

and
[hmr] Failed to reload /src/App.tsx. This could be due to syntax errors or importing non-existent modules. (see errors above)

This is because a custom element can only be defined once. A solution would be to do something like:
if (!customElements.get('identicon-svg')) { customElements.define('identicon-svg', HTMLTheElement); }

here https://github.com/laurentpayot/minidenticons/blob/73799010a80aeb5d0ee8f5fc1600017ff2489017/minidenticons.js#L41

Hi @Thykof, thank you for this bug report and for the fix idea.
I just released v4.2.1 to fix this issue. Can you tell me if it works for you now?


[bug]: Gratuitous, parasitic, endlessly repeated, pointless menu in version 3.2.0

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
24gb
What version did you experience this issue on?
3.2.0
What happened?
During launch, the following inquiry appears, each and every time, without fail, perpetually:
`
Please select the type of the V2 checkpoint named v1-5-pruned-emaonly.safetensors:
[1] A model based on Stable Diffusion v2 trained on 512 pixel images (SD-2-base)
[2] A model based on Stable Diffusion v2 trained on 768 pixel images (SD-2-768)
[3] Skip this model and come back later.
select>
`
After this menu appears, regardless of what entry is made, the program ignores the response and asks the same question again on the next launch. There is no escape from this menu, no remedy, no "never show this menu ever again", no command-line argument to prevent its appearance.
Screenshots
No response
Additional context
There should be a way to prevent the appearance of parasitic and pointless menus during launch. Just saying.
Contact Details
<EMAIL_ADDRESS>

Can you please share your models.yaml file here? Typically in invokeai/config/models.yaml, where invokeai/ is your install directory.

In 3.2.0, the path is now invokeai/configs/models.yaml. Note the plural. Here it is:
`
This file describes the alternative machine learning models
available to InvokeAI script.

To add a new model, follow the examples below. Each
model requires a model config file, a weights file,
and the width and height of the images it
was trained on.
metadata:
version: 3.0.0
sd-1/main/v1-5-pruned-emaonly:
path: /netbackup/home/lutusp/invokeai/autoimport/link/v1-5-pruned-emaonly.ckpt
description: sd-1 main model v1-5-pruned-emaonly
config: configs/stable-diffusion/v1-inference-v.yaml
variant: normal
format: checkpoint
sd-1/lora/openjourneyLora:
path: /netbackup/home/lutusp/invokeai/autoimport/link/openjourneyLora.safetensors
description: sd-1 lora model openjourneyLora
format: lycoris
sdxl/main/sd_xl_base_1.0:
path: /netbackup/home/lutusp/invokeai/autoimport/link/SDXL/sd_xl_base_1.0.safetensors
description: sdxl main model sd_xl_base_1.0
config: configs/stable-diffusion/sd_xl_base.yaml
variant: normal
format: checkpoint
sdxl-refiner/main/sd_xl_refiner_1.0:
path: /netbackup/home/lutusp/invokeai/autoimport/link/SDXL/sd_xl_refiner_1.0.safetensors
description: sdxl-refiner main model sd_xl_refiner_1.0
config: configs/stable-diffusion/sd_xl_refiner.yaml
variant: normal
format: checkpoint
sdxl/lora/sd_xl_offset_example-lora_1.0:
path: /netbackup/home/lutusp/invokeai/autoimport/link/SDXL/sd_xl_offset_example-lora_1.0.safetensors
description: sdxl lora model sd_xl_offset_example-lora_1.0
format: lycoris
`
During installation, to avoid re-downloading everything, I create a symlink to my existing archive of models, at invokeai/autoimport/link.
After any response to the prompt above, this message appears:
[2023-10-03 06:17:00,902]::[InvokeAI]::WARNING --> Failed to process '/netbackup/home/lutusp/invokeai/autoimport/link/v1-5-pruned-emaonly.safetensors': A model named "v1-5-pruned-emaonly" is already installed.
Then, on the next launch, the process repeats.
I hope this helps.

This is happening for me with every autoimported SD1.5 model. They're all detected as SD2 and each pop this message. Skipping them all and launching shows them all in the model manager, correctly labelled as 1.5.


Adjusting HTML Field Security

What is the context of your question

M365 learning pathways web part - Embed

Is there a way to access the site administration options under settings that would allow me to access the HTML Field Security section? There is content that I would like to embed, but can't because the sites need to be allowlisted.

So, learning pathways does not use HTML Field Security. I'm going to try and read between the lines of your question and assume your issue is you want to embed a URL to some piece of content as an asset in a playlist? The direct way to do that is to create a SharePoint page and use the embed web part...

I am creating a news post or sharepoint page and want to embed a calendly.com link so people are able to click and schedule a time. However, when I paste the link into the embed field it says that “calendly.com” needs to be added to the approved list in the HTML field security section of the site settings. I am able to do this to all other sharepoint sites except this one which is a buzz kill because the IT dept just moved our whole knowledge base to learning pathways and I can’t generate the kind of news posts I’d like without having to create them from our intranet site.
v/r,
Andrewhttps://www.aau.edu/who-we-are/leadership-staff/andrew-parrish, AAU
From: Julie Turner<EMAIL_ADDRESS>Sent: Thursday, August 13, 2020 3:36 PM
To: pnp/custom-learning-office-365<EMAIL_ADDRESS>Cc: Andrew Parrish<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [ext] Re: [pnp/custom-learning-office-365] Adjusting HTML Field Security (#338)
So, learning pathways does not use HTML Field Security. I'm going to try and read between the lines of your question and assume your issue is you want to embed a URL to some piece of content as an asset in a playlist? The direct way to do that is to create a SharePoint page and use the embed web part...
[image]https://user-images.githubusercontent.com/7570936/90178842-8d9f5700-dd7a-11ea-8d12-0540273295de.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/custom-learning-office-365/issues/338#issuecomment-673671057, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTMEWNBHL2JGT4EAUSTVWDSAQ6A7ANCNFSM4P6YH6NQ.

Ok, now I understand what you're asking about, but there is nothing special about this site collection that would prevent you from making that adjustment.

This is what it should look like<EMAIL_ADDRESS>But this is what I see:
<EMAIL_ADDRESS>There is no site collection administration for the learning pathways site.
v/r,
Andrewhttps://www.aau.edu/who-we-are/leadership-staff/andrew-parrish, AAU
From: Julie Turner<EMAIL_ADDRESS>Sent: Thursday, August 13, 2020 4:26 PM
To: pnp/custom-learning-office-365<EMAIL_ADDRESS>Cc: Andrew Parrish<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [ext] Re: [pnp/custom-learning-office-365] Adjusting HTML Field Security (#338)
Ok, now I understand what you're asking about, but there is nothing special about this site collection that would prevent you from making that adjustment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/custom-learning-office-365/issues/338#issuecomment-673693215, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTMEWNQ7LESHDXHSPAMIADSARD6BANCNFSM4P6YH6NQ.

Right but that issue is because you're not a site collection admin, not because there is anything special about the site.

Sorry! Thank you for sticking with me there until I had the “a-ha!” moment. I get most of the keys to the kingdom, but it turns out I didn’t get this one.
v/r,
Andrewhttps://www.aau.edu/who-we-are/leadership-staff/andrew-parrish, AAU
From: Julie Turner<EMAIL_ADDRESS>Sent: Thursday, August 13, 2020 5:15 PM
To: pnp/custom-learning-office-365<EMAIL_ADDRESS>Cc: Andrew Parrish<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [ext] Re: [pnp/custom-learning-office-365] Adjusting HTML Field Security (#338)
Right but that issue is because you're not a site collection admin, not because there is anything special about the site.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/custom-learning-office-365/issues/338#issuecomment-673714032, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTMEWK7EMKPWZR7OPTJOI3SARJWFANCNFSM4P6YH6NQ.


Add tool to insert WKT STYLE commands to make LINESTRING widths proportional to length.

Relies on #46

https://en.wikipedia.org/wiki/Medial_axis
Calligraphy type effects, possibly related to #47

Should this post process the SVG? Or should it act on the geometries, possibly performing transformations, and at the least interleaving STYLE commands?
I think there's room for both... I should probably learn more about the things you can do with SVGs first.

Related to #90


[BUG] Frontend Deploy

Describe the bug
After deploying frontend code, when going to url, will give me:
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.
registerSW.js:1 Uncaught SyntaxError: Unexpected token '<' (at registerSW.js:1:1)
manifest.webmanifest:1

To Reproduce

Run deploy script
Run codedeploy for frontend
Go to url for frontend

Screenshots

^ related to WAF, is there a way to turn that off if want to ?


Fixed text alignment issue ! #214

What does this PR do?

Hello PR,
Fixed issue number - #214

Type of change

Bug fix (Improve the text alignment in SignUp/Register page)

How should this be tested?

[x] Test A
[x] Test B

Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@YadavAkhileshh

@YadavAkhileshh please merge it

@YadavAkhileshh PA kindly merge it and add level

@YadavAkhileshh

@YadavAkhileshh


Move to faas-provider models

Signed-off-by: Alex Ellis (OpenFaaS Ltd<EMAIL_ADDRESS>
Description

Move to faas-provider models
Motivation and Context
Moves to use models from faas-provider instead of from the
gateway package.
How Has This Been Tested?

Unit tests and local Docker build
Types of changes
Refactoring

https://github.com/openfaas/faas/issues/565


Make T2I Adapters work with any resolution supported by the models

Summary
This change mimics the unet padding strategy to align T2I featuremaps with the latents during denoising. It also slightly adjusts the crop and scale logic so that the control will match the input image without shifting when it needs to pad.
Related Issues / Discussions

QA Instructions
Image generated at 1032x1024

Image generated at 1080x1040 to prove feature alignment.

Edge artifacts on the bottom and right are a result of SDXL's unet padding, and t2i influence will be cut off in those regions.
Merge Plan
Contingent on #7205
Currently the Canvas UI prevents users from generating non-64 resolutions while t2i adapter layers are active. Will leave this as a draft until fixing that.
Checklist

[x] The PR has a short but descriptive title, suitable for a changelog
[ ] Tests added / updated (if applicable)
[ ] Documentation added / updated (if applicable)

The UI checks are here: https://github.com/dunkeroni/InvokeAI/blob/t2i_resolution_hack/invokeai/frontend/web/src/common/hooks/useIsReadyToEnqueue.ts#L205-L243
Those don't look right to me - I think those 16s should be multiple... I think I just copy-pasted and didn't fix it. But anyways, if I understand correctly, that whole block of checks can be removed in this PR.

UI checks have been removed and T2I can now be used at arbitrary resolutions and scaling in the Canvas editor.


Careers Page navigation, account, and footer

Can we make the Careers page use the global navigation?

It appears to use its own version or a previous version of the navigation.
Some of the links in this navigation are broken.
The Create Account button goes to the wallet page.
Perhaps consider moving from careers.near.org to near.org/careers?
The footer looks to be from 2022

@vanessadespain this is it's own site and nav. There's probably a team at NF that manages/managed this. Maybe we can find someone to support updating this.


Ensure old lookup queues are cleaned up before creating new lookup queues

Make sure that no packets / resources get leaked under any circumstances.
Related to https://github.com/Igalia/snabb/pull/675 , which in turn is justified by https://github.com/Igalia/snabb/issues/655#issuecomment-265792331 .

TL;DR: nothing to see here, move along (hopefully). :-)
The change applied in #675 recreates the two lookup queues associated with the binding table when a reload message is received, inside the LwAftr:push method.
LwAftr:push unconditionally calls flush_decapsulation, flush_encapsulation and flush_hairpin each time it runs. These three functions in turn call BTLookupQueue:process_queue on both lookup queues, and then iterate over the queue elements calling get_lookup on each of them, thus emptying the queues.
The only other significant attribute of BTLookupQueue is a LookupStreamer instance, which in turn does not seem to contain, or point to, other resources.
To be on the safe side, in case LwAftr:push would be interrupted before flushing the queues, we could call the flush functions on the old lookup queues again, right before creating the new ones. Unfortunately, while the hairpin queue usage is unambiguous, inet_lookup_queue is used for both encapsulation and decapsulation: if the queue still contains any packets after exiting LwAftr:push, we don't know anymore whether we should encapsulate or decapsulate them.
If we exclude the possibility of LwAftr:push being interrupted before completion, I don't see a possibility for resource leaks here.

Having re-read the code, I accept your analysis. Thanks!


gamnit: customize writing with BMFont

Add format services to TestSprites implemented (only) by BMFont: align, valign, wrap, max_width and max_height. You can see the result in the screenshot of the new showcase/test program:

Rebased to make max_width & max_height nullable and fix the double drawing issue. Thanks for the suggestions @privat!


Don't use MBEDTLS_X509_CRT_PARSE_C to guard CRT functionality in SSL module

Issue: Several fields and code in the SSL module which relates to certificate-based key exchanges, like e.g. the peer certificate in the mbedtls_ssl_session structure, are guarded by MBEDTLS_X509_CRT_PARSE_C, where instead they should be guarded by the SSL module specific MBEDTLS_KEY_EXCHANGE__WITH_CERT__ENABLED. In practice, it won't make much of a difference, as it's rather unlikely that someone will build the SSL module with PSK-only alongside the X.509 library, but it's still cleaner this way. It is checked in check-config.h that if a CRT based ciphersuite is enabled, MBEDTLS_X509_CRT_PARSE_C is set, too.

@mpg, do you agree here? Or is there a reason to use MBEDTLS_X509_CRT_PARSE_C instead of MBEDTLS_KEY_EXCHANGE__WITH_CERT__ENABLED (apart from the fact that, at the time of writing, MBEDTLS_KEY_EXCHANGE__WITH_CERT__ENABLED probably didn't exist, yet).

@hanno-arm I strongly suspect there is no reason other than the historical one you mention. In the past, everything used to be guarded by _C macros (eg RSA, DHM, ECDH, etc) rather than by key-exchange based macros. I agree that it would be cleaner to base everything on enabled key exchanges - there has been a slow movement in that direction for new code, but it would be good to upgrade the rest of the code when we get a chance.

ARM Internal Ref: IOTSSL-2771


create evaluation network

The evaluation network evaluates responses and decides if its quality is good enough or not. In case the response is sufficient it will be send back to the requestor. In case it is not sufficient enough some strategy needs to be looped until the response is good enough.

The evaluation network needs to increase the score of the strategy. See https://github.com/xh3b4sd/anna/issues/83.


User groups ?

Hi,
User groups exists in the core code of october (October\Rain\Database\Model), but are never used because tables does not exists in my database...
Why ?

It's actually commented out if you see here so I don't think it's supported. I checked the older commits and I believe this was more of an example code rather than something October supports internally. You can already do user-based permissions so I don't think user grouping is necessary. Besides user-plugin isn't designed for user roles. You can use the Roles plugin to achieve that.

User groups have since been added.


[BACKLOG-6651] Fix MDI setters for array elements

@bmorrise

@kcruzada This has been merged into master if you want to have a look.


Location not Displayed for Exoscale Node Template in Note Template List

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

create an exoscale node template
display the Node Templates

Result:
The location is displayed as Ùnknown`(see screenshot below)
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):

rancher 2.1.1 single node

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Exoscale
Machine type (cloud/VM/metal) and specifications (CPU/memory):
cloud
Kubernetes version (use kubectl version):
v1.11.3-rancher1-1

(paste the output here)

Docker (use docker info):

(paste the output here)

https://github.com/rancher/ui/blob/master/lib/shared/addon/mixins/node-driver.js#L25

Version - 2.2 master 10/31

Version - 2.2 master 11/14
Verified fixed.


improve parse response api

improve the parse response APIs
chore: Improve the parse response APIs

I'm not sure if we also need to add Co-authored-by to make sure the author is kept in the commit when merging.

@paolobarbolini the commit f42c419 is from original author :)


Auto-completion of init(self, ) should not automatically include a "return" statement

@PowerSnail commented on Mon May 06 2019

Environment data

VS Code version: 1.33.1
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Ubuntu 19.04
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.3 (system)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): any
Relevant/affected Python packages and their versions: NA

Expected behaviour
Auto-completion for __init__ method should not generate return super().__init__().
__init__ should always return None. And, explicit return in __init__ is probably not appropriate anyway.
Maybe it should just generate an empty method with a pass, and let the user fill in the the necessary initialization. First, many classes don't inherit anything (other than object) and super().__init__() should not be there. Second, some libraries recommend initializing super by super(MyClass, self).__init__(). Users have to rewrite this anyway.
Actual behaviour
Auto-completion generates something like this when click "tab" when typing __init__:
class NewClass(object):

    def __init__(self, *args, **kwargs):
        return super().__init__(*args, **kwargs)

Steps to reproduce:

Make a new class
Type def __ini
Press <tab>

Thanks.

@Jonas1312 commented on Wed May 08 2019
Same issue here

Regarding "Second, some libraries recommend initializing super by super(MyClass, self).init(). Users have to rewrite this anyway", this is a Python 2 vs 3 thing, and the LS will generate code based on the Python version in use: https://github.com/microsoft/python-language-server/blob/6a2bcac7756e2019b15da87cff8d5ece663ea3cf/src/LanguageServer/Impl/Completion/FunctionDefinitionCompletion.cs#L68-L98
This should be special cased for __init__, though; the normal override code is being run here unconditionally.

Now she if there's anything you need to do here. This had been incorrectly filled against LS repo
The auto complete is a snippet not something provided by LS.
Please feel free to close this issue.
@karrtikr /cc

I'm not sure that using Python version is sufficient to decide which boilerplate should be used. Users may be using a Python3 environment, but writing Python2-compatible code. There are also cases where there is no need to call super in any form.
But that is not the main point anyway. The real hard error is the return.

@jakebailey I'm facing this issue as well.
VS Code version: 1.37.0 (user setup)
Extension version (available under the Extensions sidebar): 2019.8.29288
OS and version: Windows 10, but currently running on WSL Ubuntu 18 via the "Remote - WSL" extension
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.8
Type of virtual environment used N/A
Relevant/affected Python packages and their versions: NA


Add pymbar4 analysis script

Fixes #229 and adds a script to calculate the DG, bootstrap error and overlap matrix using pymbar4, note this is very slow using 1000 iterations which is currently hard coded.
Licensing agreement

[x] I agree to release these inputs under the combined MIT and CCBY SA 4.0 licenses of this repository

I need to change this to use openmmtools to run the subsampling and then estimate the DG with pymbar4.

@jthorton , sorry, I forgot to review earlier, but one thing I was wondering is whether there was a change between pymbar 3 and 4 in the code for subsampling of the data. Would it make sense to re-compute that here or did that part of the code not change between the versions?

Thanks @jthorton , sounds good!


Feature/abide ii data

One interesting fold I hadn't thought of before is that ABIDE II has both the ABIDEII_Composite_Phenotypic.csv and ABIDEII_Long_Composite_Phenotypic.csv. In a separate pull request I would like to make it just a two iteration loop, one for each CSV, to create a "phenotype/composite.tsv" and a "phenotype/longitudinal_composite.tsv". Thanks!

@ericearl Since there'll be upcoming changes based on our meeting with @dmoracze , I'll add comments once its done.


Scoped slot does not work with dynamic slot name

I'll admit I might be in left field with this, as it has been a learning experience, but it seems like either a bug or an enhancement. Go gently with me. 😄
You can see more discussion here as to why I've even come up to this point: https://forum.vuejs.org/t/missing-basic-understanding-between-slots-and-templates/5503/3
Steps to reproduce
If you have a double named slot situation, the scope feature works fine. i.e.:
Parent
<template class="parent">
 <child>
  <template slot="child1" scope="props1">

         This is the child slot 1 with text passed up from the child's scope: {{ props1.firstmsg }}

    </template>
   <template slot="child2" scope="props2">

         This is the child slot 2 with text passed up from the child's scope: {{ props2.secondmsg }}

    </template>
  </child>
</template>

Child
<template>

      <slot name="child1" firstmsg="text1"></slot>
      <slot name="child2" secondmsg="text2"></slot>

</template>

You will get:

This is the child slot 1 with text passed up from the child's scope: text1
This is the child slot 2 with text passed up from the child's scope: text2

If you also have a "dynamic" slotting going, where you'd like to control the order of certain HTML blocks and without scopes, this works fine too.
Parent
<template class="parent">
 <child>
  <template :slot="child1">

         This is the child slot 1

    </template>
   <template :slot="child2" scope="props2">

         This is the child slot 2

    </template>
  </child>
</template>

Child
<template>

      <slot name="child1"></slot>
      <slot name="child2"></slot>

</template>

You will get:

This is the child slot 2
This is the child slot 1

What is Expected?
If you mix the two together. Dynamic slotting with child scopes,
Parent
<template class="parent">
 <child>
  <template :slot="child1" scope="props1">

         This is the child slot 1 with text passed up from the child's scope: {{ props1.firstmsg }}

    </template>
   <template :slot="child2" scope="props2">

         This is the child slot 2 with text passed up from the child's scope: {{ props2.secondmsg }}

    </template>
  </child>

Child
<template>

      <slot name="child1" firstmsg="text1"></slot>
      <slot name="child2" secondmsg="text2"></slot>

</template>

Vue should at least render something, possibly even an error, if this isn't feasible.
What is actually happening?
Vue delivers a blank page and no errors.
Jsfiddles
Double named slots: https://jsfiddle.net/mwLbw11k/369/ -> works
Dynamic slots: https://jsfiddle.net/mwLbw11k/370/ -> works, when you change switchedto true, the slots change places.
The mix: https://jsfiddle.net/mwLbw11k/371/
Interesting that jsfiddle at least renders the results. However, the dynamic slots don't work.
Like I said, go easy with me. 😄
Scott

Hi @smolinari
Thanks for your report, almost perfectt :)
The only thing missing would be a small reproduction on jsfiddle.net or a similar service. Could you add one? Then we can look into it.
Thanks!

Hey @LinusBorg Thorsten,
I'll see if I can put together a jsfiddle.
The missing closing ´` tag was a typo. I've corrected it above.
Scott

Jsfiddles
Double named slots: https://jsfiddle.net/mwLbw11k/369/ -> works
Dynamic slots: https://jsfiddle.net/mwLbw11k/370/ -> works
The mix: https://jsfiddle.net/mwLbw11k/371/
Interesting that jsfiddle at least renders the results. However, the dynamic slots don't work.
Scott

Thanks for the quick resolution!! 👍 This kind of service is another reason why I know Vue is a great choice!
Scott


Auto save in new settings results in multiple validation errors when typing text

Steps to Reproduce:

Open new settings editor, search for "emmet extension"
Emmet: Extensions Path is a setting that takes path to a directory. Start typing a path

Since we auto-save in 100ms, the config change event is fired for almost every other character typed, which results in validation checks from the emmet extension resulting in a series of error notifications.
There might be other extensions in the marketplace that do such validations after listening the config change event.

Suggestions:

Increase the delay for auto-save to 1000ms. This is the default delay for file auto save. Or re-use the value from the auto save delay setting. This will not solve the problem, but will make it less annoying as the validations will be spaced more apart
Allow settings to opt-in to a much more delayed save than 100ms
Dont auto-save settings by default. Have a save button and an option to turn on auto save.

cc @Microsoft/vscode

I will add another suggestion:

save only on focus out, e.g. when the settings editor (or its input field) lose focus then save settings

Atomic setting changes should react as fast as possible (1 out of n selection, checkboxes, etc). Text input changes (and similar) should probably work on focus out, like @jrieken suggests.

I think that increasing the debounce timeout for text boxes would be good, but I'm worried that only committing the change on blur could confuse users. At least for some settings, like if you change window.title, or a font family/size, or anything else that affects the appearance of the editor... letter spacing, line height, tab size, etc... and you don't see it take effect. Then you start hunting around for a "save" button. Not everyone will try clicking out of the text box at this point.

I don't think it has to be one or the other. We can save on focus out as well as with a bit longer delay (without losing focus) so if the user is quickly moving through settings or is just a fast typist and moves away from the settings view, it just saves immediately. Otherwise, it saves after some delay.

My extension has N properties, and an action triggered by onDidChangeConfiguration make sense only when the user has finished changing more than one property.
In my opinion the optimal way is to give the user full control through an explicit Save action, otherwise an implicit save on focus out (no properties in focus) should work as expected.

My extension has N properties, and an action triggered by onDidChangeConfiguration make sense only when the user has finished changing more than one property.

You can't guarantee that even in the JSON editor, some users will probably have autosave turned on, or just hit cmd+s at different times like I do by habit. I think it's better to handle that on the extension side, rather than have a setting editing "session".

Being the devil's advocate here.. (actually extension authors' advocate)...

You can't guarantee that even in the JSON editor, some users will probably have autosave turned on, or just hit cmd+s at different times like I do by habit.

While that is true for such users, we are now moving away from a bulk update -> one event fired most of the times to one setting update -> one event fired all the time in the new settings editor. Which means much more traffic... It is slightly concerning

I think it's better to handle that on the extension side

How do you suggest extensions handle this? Batch all the config changes, and act on the batch on regular intervals? Why have multiple extensions do that when the product can do that once?

How do you suggest extensions handle this? Batch all the config changes, and act on the batch on regular intervals?

Yes. I've forked this into #59391 and we can keep discussing there.


optionally use CertUtil instead of PowerShell

For generating a hash in Windows, you can use CertUtil if you don't want to use PowerShell

Hey Cornelius(@corneliusdavid),
That's absolutely awesome sauce!!
Thanks !!
Cheers,
Gus


Feature SLIM-1421 clear pushed event flags

SLIM-1421

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ActionMapperService.java#L236: Refactor this code to not nest more than 3 if/for/while/switch/try statements.

All is well.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ActionMapperService.java#L236: Refactor this code to not nest more than 3 if/for/while/switch/try statements.

All is well.

This pull request makes the build fail.


Language

Why are parts of some pages English (CMS and DETAILS). Maybe change this, to one specific language.

The CMS now only contains Dutch, but still useses English terms like: sector, branch, tags etc. because these terms are better to understand and to use, than the dutch versions of those words.
The Details page, can still contain some English texts, but that depends on the sensor data, that was filled in. If the original data was English it will be displayed as English, but most sensors will be added in Dutch, so the Detail page will nog be changed.


Cythonizing fail issue when installing library

Hi :)
When I try to install this package following the instructions, I encounter the following error related to cythonizing.
Do you know the cause of the error?

Thanks,
Minori

Sorry, it was a build error which I could solve by removing .pyx file once and running installation command again. Though I got another issue, I'm closing this issue.


Make sure things sanely accept references/ownership

There seems to be some inconsistencies here, and I want this API to be as close to stable as possible before the next release.

Turns out the logic I did actually makes sense otherwise I'd just be cloning things all the time. Not like I don't all the time already.


RUM-6189: Add Abstract and Text semantics mapper for compose SR

What does this PR do?
This is the commit to set up the framework to support Jetpack compose session replay with semantics solution.
In this commit the principals changes are:

Add AbstractSemanticsNodeMapper as the basic mapper providing some common functions for semantics mapping
Add TextSemanticsNodeMapper for the compose Text composable.
Now ComposeView will be mapped from ComposeWireframeMapper instead of  SemanticsWireframeMapper.

Demo

Sample App
Session replay

Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 42.10526% with 77 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (6de40db) to head (2bd362f).

Files with missing lines
Patch %
Lines

...ernal/mappers/semantics/TextSemanticsNodeMapper.kt
44.93%
17 Missing and 21 partials :warning:

...rnal/mappers/semantics/SemanticsWireframeMapper.kt
24.14%
22 Missing :warning:

...d/sessionreplay/compose/internal/SemanticsUtils.kt
0.00%
8 Missing :warning:

...l/mappers/semantics/AbstractSemanticsNodeMapper.kt
73.68%
4 Missing and 1 partial :warning:

...y/compose/internal/reflection/ComposeReflection.kt
42.86%
0 Missing and 4 partials :warning:

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2292      +/-   ##
======================================================
- Coverage               69.73%   69.48%   -0.25%
======================================================
  Files                     746      750       +4
  Lines                   27642    27766     +124
  Branches                 4696     4738      +42
======================================================
+ Hits                    19274    19291      +17
- Misses                   7058     7137      +79
- Partials                 1310     1338      +28

Files with missing lines
Coverage Δ

...d/sessionreplay/compose/ComposeExtensionSupport.kt
92.31% <100.00%> (ø)

...y/compose/internal/reflection/ComposeReflection.kt
15.46% <42.86%> (+2.13%)
:arrow_up:

...l/mappers/semantics/AbstractSemanticsNodeMapper.kt
73.68% <73.68%> (ø)

...d/sessionreplay/compose/internal/SemanticsUtils.kt
0.00% <0.00%> (ø)

...rnal/mappers/semantics/SemanticsWireframeMapper.kt
24.14% <24.14%> (ø)

...ernal/mappers/semantics/TextSemanticsNodeMapper.kt
44.93% <44.93%> (ø)

... and 32 files with indirect coverage changes


PresignedPutObject with Content-Type

How can I specify a Content-Type header for the presigned PUT URL? Ceph's S3 gateway requires a Content-Type, otherwise it refuses the Upload.
Is it possible at all?

As it turns out AWS V2 presigned url signatures should also include Content-Type headers, amongst others, if the client supplies them. (see S3 API)
To make this work the PresignedPutObject() could be modified to accept user supplied headers which are then included in the hashing. But this breaks the established API.
However I would prefer a mechanism similar to the NewPostPolicy()/PresignedPostPolicy() calls. A new function NewPutPolicy() could return a struct which could offer SetContentType(), SetContentMd5() function calls, etc. The policy could then be supplied to PresignedPutPolicy(). Maybe the naming is less ideal.

@fenderle this should work fine if you use Signature v4 presignedPutObject() and set the Content-Type properly. We are not going to be enhancing this just to Signature V2 as it might just incur wrong API structure.
Closing this for now.


fix: Remove dead code

Description
At given point event.isExternal has already been evaluated to be undefined
https://github.com/vite-pwa/vite-plugin-pwa/blob/bee73adb56f3f08434981c022ecd5657d040ed55/src/client/build/register.ts#L94
so it's value cannot be truthy.
Linked Issues
none
Additional Context
I'm just trying to understand how the client-side logic works

The logic is in worbox window,  it is not documented and ot os hard to test, yoi need 2 or more tbs and 2 browser instances. Then fire the update from the tabs and from the other instance: depending who installed/activated the new sw the flag May change.


Upgrade webrtc to stable release 53

the build process of branch 53 is really a mess...
hmm... please help to test on the latest master

After upgrading from react-native-webrtc 0.8.0 to 0.12.0, I get the following error:
java.lang.UnsatisfiedLinkError: dlopen failed: "/data/data/com.mobileident/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit

@davidperrenoud, you may want to refer to https://github.com/jitsi/jitsi-meet-react/commit/30a9ca40750f6a01a5eae0f8fa5c428ce541b147 on the subject.
The release notes of React Native 0.33.0 say in the 'New features and enhancements' section for Android: Support 64 bit platforms. I haven't looked into whether that changes anything about this error.

@lyubomir Upgrading to React Native 0.34.0-rc.0 and updating the templates with react-native upgrade didn't change anything, but your patch to android/app/build.gradle did the trick!
@zxcpoiu So, in order to be compatible with 64-bit phones, arm64-v8a and x86_64 should be removed from libjingle_peerconnection.so.jar.

@davidperrenoud yes, I did the same exclusion in my app.
would it works if we add the packagingOptions below to this project's build.gradle?
 +        packagingOptions {
 +            exclude "lib/x86_64/libjingle_peerconnection_so.so"
 +            exclude "lib/arm64-v8a/libjingle_peerconnection_so.so"
 +        }

No, it doesn't seem to work in node_modules/react-native-webrtc/android/build.gradle, only in android/app/build.gradle.

alright, I will rebuild all libraries with 32 bit only. :scream:
it makes scene to not include 64 bit libs if react-native doesn't support it yet.

You can also just remove the files from the .jar:
jar -xf libjingle_peerconnection.so.jar
rm -rf lib/arm64-v8a/ lib/x86_64/
jar -cf libjingle_peerconnection.so.jar lib/

Oops, right, totally forgot how I had them packaged


Enable file links in compare view

LINKED ISSUES:
Closes #2704

TEST URLS:
The following links are links I tested on. I dont know what forks you have write access to.
Compare (The edit and delete will not work since you dont have rights)
https://github.com/yakov116/refined-github/compare/123...sindresorhus:improve-build
Permalink and random forks (The edit and delete will not work since you dont have rights or its a Permalink)
Permalink: https://github.com/yakov116/refined-github/compare/123...sindresorhus:improve-build
Same repo Permalink<EMAIL_ADDRESS>Random fork: https://github.com/yakov116/refined-github/compare/upstream...FloEdelmann:faster-reviews

SCREENSHOT:
Before:

After

When reviewing please look at each commit, the rename makes it look like the whole thing changed

This probably closed because I deleted my branch.
Change the base so I can delete it again

Keep note that
https://github.com/sindresorhus/refined-github/compare/master...FloEdelmann:faster-reviews will also have the edit, since there is a PR that exists.

Why are you picking that? Of course it has and edit button, it’s a branch.

What do you feel about having the head user? (yakov116:branchname)

Long branch

Short Branch

Looks great!


PIM Assert state correction

Proposal for assert state handling fixes to issue #63. It might be the case that MRTF_ASSERTED flag was meant to be used for inbound ASSERT detection only, but I took it into outbound handling as well. Had to add check for mrt->upstream pointer as well, as it was fairly easy to get pimd to crash without that.
With these changes ASSERT state is cleared after 180 seconds (hard coded value). Is this the "right" fix; I am not sure.

I think this looks great!  Very clean patch indeed.  Will give it a spin ASAP in my testbed to see if it breaks something obvious.

@idismmxiv As you know, I usually like to credit people who make significant contributions. Would you care to reveal your first and last name, or remain under this anonymous guise? :smiley:

@idismmxiv As you know, I usually like to credit people who make significant contributions. Would you care to reveal your first and last name, or remain under this anonymous guise? :smiley:

We are redefining our contribution policy at work at the moment. Looks like after couple of days (next week perhaps) we have clearer guidance how to do open source contributions. So I hope you bare with Idis few more days.

We are redefining our contribution policy at work at the moment. Looks like after couple of days (next week perhaps) we have clearer guidance how to do open source contributions. So I hope you bare with Idis few more days.

@idismmxiv No problem, I'll just delay the release a while longer! (Which is not a problem anway, still waiting for confirmation of having fixed issue #57 for FreeBSD :)

@idismmxiv No problem, I'll just delay the release a while longer! (Which is not a problem anway, still waiting for confirmation of having fixed issue #57 for FreeBSD :)

Added one more commit as there was unnecessary comparison in the case where new MRT entry was not created at all.
Regarding our contribution policy, it will still take little while (days, few weeks, who knows). If @troglobit want to move forward and release next version, then you are free to leave this contribution as anonymous.

Thank you!
I'm in no hurry to release anything yet.  The FreeBSD problems we've seen turned out to be simple misconfiguration, and there are a few more issues I'd like to fix before releasing v2.3.2 anyway :)

@idismmxiv Any news on your company's open source policy?  Due to the latest PR I'd like to get v2.3.2 released soon, like end of Febuary if possible.

I made proposed code cleanup and added signed-off-by line to commit.

Alright, great! Hi Mika :smiley:
I'll rebase and merge later this week, thank you!

Merged to master, with only slight (whitespace) changes.


PW-3120 add weekly cron to fetch PM logos

Summary

Each payment method has a function: public function getLogo(): string to retrieve the logo but we return the https://checkoutshopper-live.adyen.com/checkoutshopper/images/logos/medium/sofort.png' url instead of downloading it and providing it from the server of the merchant.
Show the logos using the resources from the server.
Fix involves fetching logos weekly and uploading them to create Shopware media entities and then attaching them to the payment_method entities.
Weekly cron will first delete the old media and then recreate new ones from the downloaded file
Fallback is that in the case where a remote URL is temporarily unreachable, the payment method will be skipped, thereby preserving its media from the previous run.
New MediaFolder Adyen will be created with migration.
Tested scenarios

Logos are downloaded into Media entities and attached to PMs, display accordingly in checkout and in Administration content section.
Logos are overwritten with every run of scheduled task.
Unavailable remote? PM is skipped.

@peterojo nice PR. Is there a way to trigger the logo update job on demand? Maybe some merchants would like to refresh the logos through a CLI command that runs FetchPaymentMethodLogosHandler:run(), or right after plugin install.

@acampos1916 I think we could create a command to trigger this on demand. I will create a ticket for this

@peterojo nice PR. Is there a way to trigger the logo update job on demand? Maybe some merchants would like to refresh the logos through a CLI command that runs FetchPaymentMethodLogosHandler:run(), or right after plugin install.

@acampos1916 I think we could create a command to trigger this on demand. I will create a ticket for this

I added the command to trigger the logos update, since it should be part of this ticket

I added the command to trigger the logos update, since it should be part of this ticket


pintenet segfaults without the -w option

test program
~/tenet/tracers/pin$ cat test.c
#include <stdio.h>

int main() { printf("hello\n"); }

~/tenet/tracers/pin$ gcc -g -o test test.c -Wall -Werror -Wextra

~/tenet/tracers/pin$ ./test
hello

crash
~/tenet/tracers/pin$ /home/test/pin/pin-3.19-98425-gd666b2bee-gcc-linux/pin -t obj-intel64/pintenet.so
   -o moo -- "./test"
Loaded image: 0x563463397000:0x563463399157 -> test
Loaded image: 0x7f01cbc50000:0x7f01cbc7bccb -> ld-linux-x86-64.so.2
Loaded image: 0x7ffce369a000:0x7ffce369aec7 -> [vdso]
Loaded image: 0x7f01b7200000:0x7f01b73f14d7 -> libc.so.6
C: [tid:38587] Tool (or Pin) caused signal 11 at PC 0x7f01c998d65d
Segmentation fault (core dumped)

no crash
~/tenet/tracers/pin$ /home/test/pin/pin-3.19-98425-gd666b2bee-gcc-linux/pin -t obj-intel64/pintenet.so   -w "test" -o moo -- "./test"
White-listing image: test
Loaded image: 0x55d75fe6f000:0x55d75fe71157 -> test
Loaded image: 0x7f78b5d1e000:0x7f78b5d49ccb -> ld-linux-x86-64.so.2
Loaded image: 0x7ffca6a61000:0x7ffca6a61ec7 -> [vdso]
Loaded image: 0x7f78a13c1000:0x7f78a15b24d7 -> libc.so.6
hello

generated trace
~/tenet/tracers/pin$ head moo.0.log  -n3
rdi=0x7f78b5d4d190,rsi=0x7f78b5d4d730,rsp=0x7ffca6a1d700,rdx=0x7f78b5d2fd50,rcx=0x7ffca6a1d718,rax=0x1c,r8=0x7f78a1573700,r9=0x9,r11=0x7f78a15738f0,r12=0x55d75fe70060,r13=0x7ffca6a1d700,rip=0x55d75fe70060,mr=0x7ffca6a1d6f8:3af1d1b5787f0000,mw=0x7f78b5d4d4ac:1c
rip=0x55d75fe70064
rip=0x55d75fe70066

P.S. I'd suggest mentioning make TARGET=intel64 for Linux here and adding error-checking for empty export PIN_ROOT (since it's mandatory).

Have you tested this with 7f97ae8? Because this crash looks like it might just be a dupe of #5
Otherwise I'll try to take a look when I have more time.
Thanks!

@gaasedelen
Hey! Yeah, no rush!
The commit I used is 352237b98b600f7c337314312cd3731bdbfa00a8, which is the latest right now.
BTW, I think the pintool from lighthouse doesn't have this problem (85818f5b9bff026e47cd673ba01391e7c703e6cb), but maybe I just got lucky.
Thanks!

Thanks for the quick response :-)
The commit in question (7f97ae8) is on the development branch, not on master. If you have some time, try switching branches and building with that fix. I think it's the same issue, but I could be wrong.
On that note... tenet's pin tool is pretty experimental :-P. I've traced a few 'big' things with it before and it has been fine, but crashed on others. While there is some code re-use from the lighthouse pin tool, this one is actually pretty different. It could definitely use some love.


feat: BDU-35 add transaction type

Description
Closes: BDU-35

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] ran linting
[x] wrote tests where necessary
[x] included the correct type prefix in the PR title
[x] targeted the correct branch
[x] provided a link to the relevant issue or specification
[x] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed
[x] added an entry to the CHANGELOG.md file

Update:

Update:


Let user add custom browsers

Some users might want to have special cases - extra command line arguments or non-compatible browsers

Depends on #7


gradle: updates so we can build with ndk v17

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Planning to merge on Tuesday

Actually it is a hassle without this. Merging.


Make setup easier by using Docker Compose

By using Docker compose, setup is as simple as docker-compose up. With
the current configuration, a one node etcd cluster and a one node 9volt
cluster are created.

Notes:

This mounts the code into the container
This does not build the binary
The setup script runs every time. If etcd already has the setup values
the error below is output for each key that is set as a dir=true

{"errorCode":102,"message":"Not a file","cause":"/9volt/alert","index":42}

Misc Changes

Using which is generally discouraged and a builtin like hash should
be favored. See (this StackOverflow article for more
details)[http://stackoverflow.com/questions/592620/check-if-a-program-exists-from-a-bash-script].
Use variable instead of hardcoding etcd host

Note: The docker-compose scale command won't work because of the port value specified in the docker-compose file.

This is great, thanks for this @jonDowdle.
I'm going to be switching this repo from godep -> govendor soon, which will allow for the go run main.go to work correctly.


[SPARK-21604][SQL] if the object extends Logging, i suggest to remove the var LOG which is useless.

What changes were proposed in this pull request?
if the object extends Logging, i suggest to remove the var LOG which is useless.
How was this patch tested?
Exist tests

Can one of the admins verify this patch?

That looks removable, but this isn't really worth bothering with or opening a JIRA. Can you look for other unused log vars?

Thanks @srowen , will do.

Test build #3869 has started for PR 18811 at commit 589af7a.

Test build #3869 has finished for PR 18811 at commit 589af7a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Ah, I'm sorry I misled you a bit here @zuotingbing . Yes you found another unused variable, but, it's in code that is copied directly from Hive. I think we should leave HiveSessionImplwithUGI untouched. It makes it easier to patch it if we don't have custom changes.
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
If you'll back that out, and this is the only other change you found, I'll merge it

ok, have done. Thanks @srowen .

merged to master


Add engine-specific 'start' commands for running integration tests/examples

Issue #, if available:
Description of changes:
In the root, you may now run start-core, start-three, or start-babylon.
These all run webpack dev server, but will open relevant tabs for the package you have selected. This is either integration tests, or both integration tests and examples.
More work is still required to integrate the integration test code/pages into webpack so they support hot reload
This change also enables source maps for non-production builds.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Forgot to mention this in the review I just submitted, but another problem with this PR is that the code scan is reporting a number of CodeQL issues.

Some more changes:

I've moved demo-credentials.js to the root of the repo. It is onerous for devs to insert what is likely the same cognito pool many places. I've created a fake API in webpack at /devConfig.json where webpack serves up the cognito pool and it is fetched via the samples. Ultimately I do thing we should serve up everything via webpack and probably HtmlWebpackPlugin

I tried to change this to a module with type: module in package.json. If you are reading this, do not attempt this until Karma 7! It doesn't seem like it can work without some really hacky stuff and I could not get it to work even then: https://github.com/karma-runner/karma/issues/3677. My workaround is to change demo-credentials.js to be node-style instead of a ESM.

A release build won't build any of the examples. These don't work without webpack server because of file location and our devConfig endpoint, so I think it is confusing/misleading to add these to the build output. They wouldn't work anyway without cognito so I don't think this is so bad, but we need to figure out how to test these in CI and how to pull a sample cognito Id from github secrets/etc

Regarding CodeQL: these were from the test files. I'm not sure why, as they are not in the repo and only in the build output(in an earlier rev) codeql wouldn't tell me the problem. Now that they aren't in the build output CodeQL doesn't see these errors anymore..

I've also tested all of the examples and integration tests and have fixed these


How do i use jest with create react app

Hi, it says in the documentation that create-react-app uses jest. I tried using it directly with npm test and setting jest as my test in package.json, but it says jest isn't recognized. I installed jest and then tried to run the test again, it shows me error on es6 import and export functionalities.
What is the actual way of using jest with create-react-app. Thank you.

it's configured by default under the hood. no need to install it.
the default configuration is also more than enough in most common situation.
BTW, is there any special case you wanna do?
basically to run test, you just need to type npm test.
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-test

You shouldn't need to change anything to use Jest!
If you changed the test script in your package.json, please revert that.

I'll close this, but please let us know if you need more help!

Hi, I created a new app and it works out of the box now. Could not quite figure out why the last one didn't work. Thanks

Maybe you were using npm@5 which is currently buggy, and maybe it hasn't installed Jest properly.

The Jest test runner is unable to resolve absolute path imports inside my component to be tested.

@pRoy24 I'm having the same problem. Did you solve it?

When I import a component that uses absolute paths the test fails to run with:
    TypeError: (0 , _utils.makeActionCreator) is not a function

However when I use a component that does not use absolute paths such as:(https://github.com/facebook/jest/blob/master/examples/snapshot/Link.react.js), the test runs fine.
  System:
    OS: macOS High Sierra 10.13.3
    CPU: x64 Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz
  Binaries:
    Node: 8.11.0
    Yarn: 1.5.1
    npm: 5.8.0

If anyone is having the same provlem as me and pRoy24, I solved it by adding this option --modulePaths=src to package.json test script.
package.json

  "scripts": {
    "start": "react-scripts-ts start",
    "build": "react-scripts-ts build",
    "test": "react-scripts-ts test --env=jsdom --modulePaths=src",
    "eject": "react-scripts-ts eject"
  },

src being the root folder name of your code :)

I have installed jest
I tried npm test command to run test cases but unfortunately am facing below issue
any solutions
Error: Cannot find module 'E:\ReactTesting\TestProject\my-app1 - loginappcopy\node_modules\jest-cli'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:594:15)
at Function.Module._load (internal/modules/cjs/loader.js:520:25)
at Module.require (internal/modules/cjs/loader.js:650:17)
at require (internal/modules/cjs/helpers.js:20:18)
at getJest (E:\ReactTesting\TestProject\my-app1 - loginappcopy\node_modules\react-scripts\node_modules\jest\node_modules\jest-cli\build\cli\getJest.js:22:12)
at Object.run (E:\ReactTesting\TestProject\my-app1 - loginappcopy\node_modules\react-scripts\node_modules\jest\node_modules\jest-cli\build\cli\index.js:39:48)
at Object. (E:\ReactTesting\TestProject\my-app1 - loginappcopy\node_modules\react-scripts\scripts\test.js:104:6)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
npm ERR! Test failed.  See above for more details.

might be worth removing node_modules/ and re-install using npm install


[Suggestion]: Change behavior of config cloning in register_reply

Describe the issue
When you register a reply to a ConversableAgent, you have the option of providing a config parameter which could be used for LLM generation or other extra variables.
This is then assigned to the "private" _reply_func_list in this way:
self._reply_func_list.insert(
    position,
    {
        "trigger": trigger,
        "reply_func": reply_func,
        "config": copy.copy(config),
        "init_config": config,
        "reset_config": reset_config,
        "ignore_async_in_sync_chat": ignore_async_in_sync_chat and inspect.iscoroutinefunction(reply_func),
    },
)

My focus is specifically on config and init_config. This works well when the config is modified over time by the reply function, and reset() resets the config as expected. However, this approach leaves no way to modify the config from outside the reply function, which is a useful functionality.
If the user really wants to modify the config, they will need to access _reply_func_list. What if we invert the cloning behavior so that config is the original object and init_config is the clone? That way, the user can keep a reference to the config object and update it if needed accordingly,
Let me know if I've missed something important or there is a better way to give reply functions additional mutable data. My current workaround is to use functools.partial() to pass in a mutable dict.
Steps to reproduce
No response
Screenshots and logs
No response
Additional Information
No response

I think it makes sense to allow config to be modified externally from the agent. You might want to take a look at experimental branch as we are working toward more extensible API. cc @jackgerrits


DateOffset for weekday argument requires weekday argument from dateutil

The issue is that the type specification for the weekday argument in pandas-stubs/_libs/tslibs/offsets.pyi says that weekday  is an int.  But it can be a weekday class or an int.  See https://dateutil.readthedocs.io/en/stable/relativedelta.html  To fix this, we have to make types-python-dateutil a dependency, which involves modifying pyproject.toml and takes some care.
Created a docs issue for pandas at https://github.com/pandas-dev/pandas/issues/52650
Originally posted by @Dr-Irv in https://github.com/pandas-dev/pandas-stubs/issues/645#issuecomment-1507053774

In quite a few cases, the code seems to explicitly test that weekday is between 0 and 6 (WeekOfMonthMixin, Week, WeekOfMonth).

In quite a few cases, the code seems to explicitly test that weekday is between 0 and 6 (WeekOfMonthMixin, Week, WeekOfMonth).

For the other ones you mentioned, there is a type check at the __init__ so you can only pass a weekday class from dateutil.relativedelta in pd.DateOffset. Let me know if I missed anything!


SwipeActionAdapter 1.4.4 in 4.1 or 4.2 issues

Hi , thanks for the SwipeActionAdapter, the app become more easier to use.
But, as shown in the figure, SwipeActionAdapter 1.4.4 may meet some trouble in showing in Android 4.1 or 4.2.
http://i3.tietuku.com/a07fe2e3f8fcf268.jpg
So, could it be fixed ?

what kind of cpu/gpu does this device have?
are you sure it is not running in some sort for powersaver mode?

@wdullaer Unfortunately, I think it may not because device but system.
Whether app runs in device or Genymotion, if the system is 4.1.2 or 4.2.2, it will show "maaaaaaaaaaaark" not "mark", while 4.3, 4.4, 5.1 is ok
Here is the figure of running situation in Genymotion:
http://i3.tietuku.com/45dc59a49a8ec257.jpg