setup.py: Removed httpretty dependency

Checking whether httpretty is really required? When looking at code I could not find any imports of httpretty. The file test_smart_open.py uses mock — an other library for mocking. This also explain, why some versions broke tests. So, I suppose, that httpretty is here only due to some legacy reasons and can therefore be removed.
@tmylk can you double check this? I think we can remove httpretty from dependency list and thereby also resolve some issues.

Thank you for investigating it further.
Httpretty is pinned by moto.
See Travis logs:
Collecting httpretty==0.8.10 (from moto)   Downloading httpretty-0.8.10.tar.gz (41kB)
Hopefuly we can get to the bottom of this soon.

Closing to avoid duplication with #59 and #40

Did not know this, my bad :see_no_evil:

@tmylk after some more thinking I still believe that we should remove this.
If this was here just for moto, we should remove it from the smart_open setup.py. If moto only works with httpretty==0.8.10 then this should be stated just in moto's setup.py (as it already is) — I do not see the need to restate this here since httpretty is not out dependency. Also, since moto is only needed for running tests on travis and – correct me if I am wrong – we do not need it to run smart_open, removing httpretty from setup.py we would also resolve issue #40. When installing through pip the issue #40 could persist since httpretty will not be among the dependencies any more.
Even if I am wrong, and removing it would not resolve #40 I still believe that restating moto's dependencies is unnecessary and should be removed. What do you think?

Thanks for your suggestion and investigating it further. You are welcome to remove this requirement in your private fork.
But we cannot do it in the main project because of quality. The test environment has to be exactly the same as when smart_open is used in the wild. If dependencies are different between test and what we ship then our Travis tests become useless.

If so, why do you then install  mock moto & responses in .travis and not in setup.py? They also are different in test environment than in the wild. I am not trying to be smart here, I just don't get it 😄

Further, if httpretty is only here for moto, then why isn't moto also it setup.py? As I see it, when pip installing, it breaks due to httpretty==0.8.10 which is here just due to moto; however moto itself would never even be installed by pip since it is not a dependency. Do you agree?
Thanks for being patient with me and sorry for bothering you so much, but I really cannot see the reasons behind this.

Do you agree that if the httpretty pin is dropped the Travis will be different from your LC_ALL=C setup?

Yes, I agree that it will be different. However, it will only differ in httpretty=0.8.10 which is not the dependency of smart_open. It will only differ in a dependency that is never needed in production! Why do you care about if there is an additional library installed on the user's computer, if it is never imported and never used?
Before reading the rest of my discussion, let me stress that my only intention is to help. To help me fix the issue and to help other who might encounter it. I am not trying to compromise test and stability. I wouldn't be proposing this otherwise. If you convince me that doing this is harmful I will stop and not bring it up again.
Let me try to convince you one more time. Here are my reasons:

If you want the environment in the wild to be the same as on Travis (which we all strive for), why is it ok to exclude mock moto responses from setup.py?

Since mock moto responses are not in setup.py they will never be installed when installing smart_open through pip. There will always be at least this difference between Travis and the wild. If so, why do we care whether httpretty is on the system and which version? It will never be used anyway. When pip installing you cannot run test, since mock moto responses are missing, so why do we care that there is a right version of httpretty? What difference does it make?

If httpretty is only needed by moto and not by smart_open, why is then moto installed only for Travis (through .travis) and httpretty through setup.py? Shouldn't they both be either in .travis or in setup.py?

Imagine that moto fixes this tomorrow and decides that it needs a 0.8.14 version of httpretty. What would happen? They would issue a new release, the next time your Travis run it would take this new version of moto and break due to a version conflict. Then you would have to fix it here and also make a new release. That is an unnecessary duplication. My reasoning is the following. We should not even think about httpretty. All we really need is a working version of moto. Do you agree? If so, we should let the authors of moto decide which versions they want — as they are currently doing by pinning the version. If the current version of moto is working for us, what do we gain by pining httpretty? On Travis we get 0.8.10 either way, with pip it currently breaks if LC_ALL=C, but could work if the pin is removed. Further, if we were to pin anything, which I oppose if not really required, the only thing we could pin is the moto itself, not its dependencies. We require moto, we do not require httpretty, therefore only moto should be among our dependencies.

Look at #67. There you removed requests from setup.py. Why can't we do the same for httpretty? In what sense would we compromise test with removing the pin? They would run on exactly the same environment and the pass/fail decisions would not be affected. All we would be changing is what gets installed when we use pip.

Hope that you understand my concerns. Please, let me know what you think about this.

Hey,
It is good to keep talking about it as it makes the logic clearly.

On Travis we get 0.8.10 either way, with pip it currently breaks if LC_ALL=C, but could work if the pin is removed.

What makes you think that it 'could' work if the pin is removed? Automated tests don't run in that setting. I have no idea if it works or not.
Do you suggest we run some manual tests here?

The same @piskvorky's argument applies: If there are any requirements pertaining to tests only (e.g. moto, mock and responses), you should set them in setup.py's tests_require (can't blame you for not being aware of this; setuptools suck) and then only run python setup.py test on Travis. Only specify in install_requires the absolute necessities required for your library to functions. This currently makes smart_open and thus gensim unbuildable in confined environments that set LC_ALL=C (i.e. environments that want default English but don't know exactly what other locales are available on the system).

What makes you think that it 'could' work if the pin is removed?

Was the pull request green before it was closed?

What makes you think that it 'could' work if the pin is removed?

If we remove the httpretty from our dependencies, pip will never even try to install it. Hence, I believe it should work.

Automated tests don't run in that setting. I have no idea if it works or not.

Yes, they do! Look at this PR. After I removed httpretty from the dependencies all the tests run just fine.
The reason they run just fine is that nothing whatsoever changes for Travis. The environment there will be exactly the same. Look at the current Travis log at line 130. httpretty==0.8.10 is installed by the command pip install mock moto responses, and not from our setup.py. In a sense, it's redundant to have it in our setup.py since it is moto's dependecy. So if we remove it from out setup.py httpretty==0.8.10 will still be installed on Travis, since moto's  setup.py dictates so. However, it will not be installed when pip install smart_open, which is ok, since smart_open only needs it for testing and not in production.

Do you suggest we run some manual tests here?

No. We should make with work with Travis — as a matter of fact, it already works there 😄

@tmylk any thoughts on this?

Could you suggest a way to automatically test a setup that allows for LC_ALL=C?
Moto currently doesn't work with it because of httpretty.

I think we should wait for Moto to fix it's problems first, before adding the test. Currently, we cannot set LC_ALL=C for whole Travis environment since Moto does not work with it. As of now, we could only do it dirty like LC_ALL=C python setup.py install. However, when Moto fixes its problems, we should set it globally like in setuptools.
Either way, I believe we should remove httpretty from our dependencies ASAP. Currently, we do not have this test and it does not work with LC_ALL. If we remove httpretty we still won't have the test but it should work with LC_ALL. The fact that we cannot add the test (due to moto's problems) should not be a reason not to apply the fix. Though, I agree that the test should be added once moto fixes it's problems.

@tmylk just a reminder, could we consider removing httpretty?

@nikicc Yep, thanks for the perseverance. Let's merge. Please let me know if it works for you. You are our only test in this case. :)

@tmylk: Thanks! I'm very happy to see it merged 😉
I build a package with python setup.py sdist and installed it with LC_ALL=C and it worked!


Translate glossary for PersistentVolumeClaim into Bahasa

/cc @ariscahyadi @girikuncoro

Preview: https://deploy-preview-24094--kubernetes-io-master-staging.netlify.app/id/docs/reference/glossary/?storage=true#term-persistent-volume-claim

Just trying to address the comments and to check whether lgtm is removed in this case. It is works as expected. Thanks @ariscahyadi 👍
/assign @irvifa

Awesome!
/approve

@irvifa could you do /lgtm? it's removed because of the changes, thanks.

/lgtm


feat(gateway): validate classes have ctor entry point

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.57%. Comparing base (26060ef) to head (6720b2a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   82.38%   82.57%   +0.19%
==========================================
  Files          33       33
  Lines        1612     1630      +18
  Branches     1612     1630      +18
==========================================
+ Hits         1328     1346      +18
  Misses        219      219
  Partials       65       65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update wget

Thanks @Redall

No problem 👍

This will be closed, as spongecattle-patch-1 (from Redall/porty) are merged to spongecattle/porty/master.


Entries aren't actually imported even though job is complete

I've tried importing some entries using the Append Data behavior every which way. Importing always passes and I'm sent a success email, but the entries don't show up in the Admin or the DB.
I even tried exporting an existing section using your export plugin and then importing it in to no avail. I also tried creating a very simple new entry type and importing a single line csv. No dice. Any thoughts? Am I missing something?
Thanks for all your hard work on this!

I just experienced the same while trying to import users. The process ends successfully but no new users were added to Craft.

Just to say experiencing a similar issue (v Craft 2.4.2702) - reporting complete and receive email that import is successful (CSV to Entries, append) but none are imported.

To provide some further information, looking at the error logs it seems to be throwing a PHP error:
PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted
Upped PHP memory to 256MB an reduced size of CSV am trying to import but is still happening.
Any thoughts appreciated

Same issue here. Tried to import a large amount of entries (into a "Users" channel), and history is showing that the import is complete, but nothing is actually imported.  No php errors (memory_limit set to 2048M). I've also attempted to import a single row from the csv, and that seems to have failed as well.
Total Entries - 28361
Total Time to Import - 6 hours, 3 minutes, 14 seconds
Craft Pro 2.5.2750
Please let me know if I can provide any more useful information.

I managed to resolve my own issue by turning on debugging.  If you uncomment line 131 in ImportController.php, the imports will start recording logs to craft_import_log in your db. My issue was that I did not include a title field for entries that required them.  There is a piece of copy during import setup that warns you that "title" is a required field, but I did not pay enough attention to it.


Test user story for JIRA

some content for descriptio.

link to https://github.com/eclipse-tractusx/sldt-discovery-finder/issues/60

https://github.com/eclipse-tractusx/sldt-bpn-discovery/issues/48


conversion to HOCR does not convert HTML special characters, it leaves them plain text

Issue
When trying to use the output from export_hocr_str in xml etree, it fails to parse due to specific HTML special characters (< and &, and probably others). I've included an example file that breaks xml etree parser. I think this can be fixed by updating the template file to use the j2 built in  escape to encode html special characters {{ line.text|escape }} and {{ token.text|escape }}.
I've included the j2 template that fixes the issue (had to rename file to just text to upload)
j2 reference (HTML Escaping section)
fix for hocr_document_template.xml.j2
file that cause issue html-special-characters.pdf
Environment details

OS type and version: Windows Server 2019
Python version:Python 3.9.4
pip version: pip 20.2.3
google-cloud-documentai-toolbox version:  0.12.0-alpha

Steps to reproduce

Create a pdf that has specific special characters embedded in it (&, <, probably others).
OCR that document with Document AI
Bring that document into the toolkit
document.Document.from_gcs(gcs_bucket_name=BUCKET, gcs_prefix=PREFIX)
Use the python document ai tool kit to create a hocr file
export_hocr_str(title='Special Characters')
This part is successful, but now < & are still clear text in the document
Attempt to import with xml etree parser
Receive invalid token error
ParseError: not well-formed (invalid token): line 14, column 293

Code example
Code to OCR the pdf is not included here
    import xml.etree.ElementTree as ET
    from google.cloud.documentai_toolbox import document

    wrapped_document = document.Document.from_gcs(gcs_bucket_name=BUCKET, gcs_prefix=PREFIX)
    hocr_output = wrapped_document.export_hocr_str(title = "Unparseable Doc")
    tree = ET.ElementTree(ET.fromstring(hocr_output))

Stack trace
  File annotatepdf.py:199 in error_validation
    tree = ET.ElementTree(ET.fromstring(hocr_output))

  File c:\Program Files\Python39\lib\xml\etree\ElementTree.py:1347 in XML
    parser.feed(text)

  File
ParseError: not well-formed (invalid token): line 14, column 293

Here is the hocr file outputted by the toolbox to save you a step
hocr.html.txt

Makes sense, thanks for the catch! Please make a Pull Request for your changes, and also add  unit tests for this edge case.

I created #239 for you to pull in these changes.


Accordion element is not WAI conform

What should happen?
The accordion component should follow the W3C accessibility recommendations.
The tablist should only contain tabs and the tabpanels should be outside of the tablist.
What happens instead?
The accordion renders an element with the role tablist (ul.accordion). Inside this lis are created. Every single of this lis consist of a link with the role tab and a div with the role tabpanel.
Possible Solution
Adjust the JavaScript you use to generate the structure.
Test Case and/or Steps to Reproduce (for bugs)

Test Case: https://codepen.io/hirnschmalz/pen/RvwpRP
Your Environment

Foundation version(s) used: 6.5.1

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one.
[x] The issue title and template are correctly filled.

I have also run in to this problem.  Running AXE tools against https://foundation.zurb.com/sites/docs/accordion.html will reveal the problem too
Possible solution
I found adding role="presentation" to the
 elements to fix the problem.  The children of the li maintain their roles assigned by the accordion js, and accessibility tools seem happy with the result:

    Accordion 1

Panel 1. Lorem ipsum dolor

      Nowhere to Go

The down side of this is that the role presentation is really poorly explained anywhere online.

cc @owlbertz


Control multiple Users with one Client ID

Hello!
I have following problem. So, I created a Spotify-Application, for the client_id and the client_secret. Then I created a link, that return the auth code. With this code, I create the access token and refresh token.
Now I want to control the Spotify Account, from the User, how clicked on the linked, with my client_id.
BUT, when I click on the link, its working, but when my friends click on the link, it didnt work.
So is this my fault?

Hello, please respect the issue template.


[WIP] Add a query for redirect. if _redirect isn't found

What this PR does / why we need it:
This PR adds a query for redirect. if the _redirect query isn't found for primary requests. This solves the wildcard issue where we can't set a wildcard _redirect record.
Which issue this PR fixes:
fixes #145

Thinking through different possibilities, if the current idea doesn't work with the DNS spec.


"Word cannot save this file because it is already open elsewhere" - pending check if restart pc helps

The automation seemed to hang with this pop-up. What do i need to do for the automation to not be disrupted? attached is the screenprint

Hi @edmundchan1976 can you try to restart your pc and see if error persists?

Hi Ruth
Thank you for the advice. It works after I restart it. Why does this
happen? i am hoping for tagui use to be as stable as possible. Also, i
notice  (attached, circled in green) that there is document1, document2,
document3, etc..., that seems to be created previously. Is that the
cause of the error?
[image: restart.jpg]
On Sun, 10 Apr 2022 at 11:36, Ruth @.***> wrote:

Hi @edmundchan1976 https://github.com/edmundchan1976 can you try to
restart your pc and see if error persists?
—
Reply to this email directly, view it on GitHub
https://github.com/kelaberetiv/TagUI/issues/1204#issuecomment-1094168253,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCSR7RZX6JIYRWVSXZJGTTVEJEEDANCNFSM5S327JYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @edmundchan1976 that should not be the cause of the error. But perhaps sometimes MS Word does not close files properly and requires a restart to terminate unwanted sessions.


Firefox Select demo causes flickering of overlay

Describe the bug
The "Select Menus" example on https://floating-ui.com/ causes flickering when opening the select menu and scrolling using a mouse wheel on Firefox. My guess is that useFloating is calculating wrong positioning data for a split second (see video).
To Reproduce
The issue can be reproduced by going to the official Floating UI home page.
But I also created a repository to reproduce the issue in an isolated environment. See https://github.com/MartinMa/floating-ui-demo
Steps to reproduce the behavior:

Open Firefox (not reproducible in Chrome, Edge or Safari)
Go to https://floating-ui.com/
Scroll down to the section with the headline "Interactions for React".
Open the select menu "Select balloon color".
Use your mouse wheel scroll the viewport up and down.
You will see, that the popover will start flickering and jumps between two positions (above and below the trigger button) until it "stabilizes" and stays below the trigger.

Expected behavior
The popover should not flicker (jump between two positions on scroll).
Screenshots
See video:
https://github.com/user-attachments/assets/74abc19d-a8e2-4a73-a341-ef3f0cc772c8
Context:
These are my specs, but I also tested it on Windows 10 and Windows 11 with the same problem.

OS: macOS 15.0.1

Browser Firefox

Version 131.0.3 (aarch64) <-- latest

Additional context
The problem seems to occur independently of the operating system. But it only occurs in Firefox. And you have to use a mouse with a mouse wheel. Touch pad scrolling doesn't seem to trigger the issue.

I'd like to work on this

This could be related to the demo using the initialPlacement behavior and not rounding the availableHeight value in size(). Can't test this since I don't have a mouse; it's strange that it only happens with a mousewheel in Firefox specifically.


[EXTERNAL] Shift+Enter not working in WSL Ubuntu-18.04 on Windows Terminal

Shift+Enter should insert a newline without submitting the current code.
However, it seems to submit the code instead of newline.
This happens on WSL Ubuntu-18.04 shell via WindowsTerminal.
This seems to work fine on Windows Command line.

The version of dotnet-repl used is :

This is related to https://github.com/dotnet/runtime/issues/802

This is related to dotnet/runtime#802

Is there a workaround to write multi line code in WSL Ubuntu?

@jonsequitur dotnet/runtime#802 is fixed in .NET 7 RC1; this issue might be resolved now too.

Running PopOS, 22.04 LTS and have the same problem. Shift+Enter is interpreted without the shift modifier. But this is likely a problem with the terminal and not WSL or Ubuntu in general. By default, the terminal maps Shift+Enter to Control+M. I don't know all of the details, but this StackOverflow answer may give us some insight.
https://unix.stackexchange.com/a/128403/444583


add warmup lr_scheduler

Add warmup lr_scheduler, it can overcome optimization challenges early in large batch-size.
This method was used in "Accurate, Large Minibatch SGD: Training ImageNet in 1 Hour".
https://arxiv.org/abs/1706.02677

Warmup behavior is nice.
Do you mind adding a combined warmup and multi step scheduler which will be more useful IMO?

Yes, I will combine warmup and multi step scheduler in a single class.

I have combined warmup and multi step scheduler in a single class.
It can be used as
“lr_scheduler = mx.lr_scheduler.GradualWarmupWithMultiFactorScheduler(warmup_step=10, begin_lr=0.002, stop_lr=0.1, multifactor_step=[15,18,20], factor=0.1)”

Please add test.
Can this be added as an additional argument of MultiFactorScheduler?

I have added  additional argument in MultiFactorScheduler class.
Warmup can be used when 'warmup_step' > 1.
I added a test file in test/commom/test_lr_sceduler.py.
Following is a test result
python test_lr_scheduler.py --lr-factor=0.1 --warmup_step=5 --lr-steps='8,10'

INFO:root:step 1 lr = 0.020000
INFO:root:step 2 lr = 0.040000
INFO:root:step 3 lr = 0.060000
INFO:root:step 4 lr = 0.080000
INFO:root:Update[5]: now learning rate arrived at 1.00000e-01, will not warm up in the future
INFO:root:step 5 lr = 0.100000
INFO:root:step 6 lr = 0.100000
INFO:root:step 7 lr = 0.100000
INFO:root:step 8 lr = 0.100000
INFO:root:Update[9]: Change learning rate to 1.00000e-02
INFO:root:step 9 lr = 0.010000
INFO:root:step 10 lr = 0.010000
INFO:root:Update[11]: Change learning rate to 1.00000e-03
INFO:root:step 11 lr = 0.001000
INFO:root:step 12 lr = 0.001000
INFO:root:step 13 lr = 0.001000
INFO:root:step 14 lr = 0.001000

I have moved test_lr_scheduler in tests/python/unittest/test_lr_scheduler.py.
I  have removed argparse and added some test cases in the test file.
@zhreshold

I have used 'nose' to test and add default test 'multi_lr_sceduler(lr = 0.02, steps=[100, 200])'.
@zhreshold

please make pylint at root, fix potential error and wait for CI to finish.

Add pylint and license as "test_operator.py"

You are all set. Can you rebase master and push again?, the checks failed with other problems.

move to #8107


User Markdown Styling Conflicts with Markdown-Language-Features in Confusing Ways

Issue Type: Bug
To reproduce the issue, include the following in test.md, and the code referenced in the block in a separate style sheet.
This is a code block that is very difficult to style.

VS Code provides the option to use custom markdown styling as so:
"markdown.styles": [
  "./style.css"
],

However the stylesheet that can be found here:
extensions/markdown-language-features/media/markdown.css
is applied after the css that the user specifies.

Including the following in style.css does nothing
pre {
  background-color: red;
}
because it is overridden by the Markdown-Language-Features stylesheet using
the class .vscode-dark

Including the code below in style.css has the desired effect, but it is not very
user-friendly, as one has to dig into the Webview Developer Tools to see that this
is the class that overrides what they were trying to do.
.vscode-dark pre {
  background-color: red;
}

An easy solution is to comment out the contents of markdown.css wherever it is on your system, but that's not very elegant. Would it be possible to include an option to disable Markdown-Language-Features styling (and that alone) so that user's don't run into this issue? Or alternatively, if the styling could be applied before the user's styling, then they would have the oppertunity to clear it with a css reset.
Thank you!
VS Code version: Code - Insiders 1.41.0-insider (f24f483428f592a262dc73d68a3f05745c562b31, 2019-11-21T10:39:56.671Z)
OS version: Darwin x64 18.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.04GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (48)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

vscode-django
bat
0.19.0

unique-lines
bib
1.0.0

vscode-multi-line-tricks
big
0.0.3

simple-react-snippets
bur
1.2.2

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
1.9.1

python-extension-pack
don
1.6.0

vscode-html-css
ecm
0.2.3

tslint
eg2
1.0.44

vsc-material-theme
Equ
30.0.0

jsonnet
hep
0.1.0

latex-workshop
Jam
8.4.1

vscode-styled-components
jpo
0.0.27

simple-vim
jpo
0.0.5

language-julia
jul
0.12.3

vsc-python-indent
Kev
1.8.1

MagicPython
mag
1.1.0

rainbow-csv
mec
1.3.1

select-part-of-word
mle
1.0.1

theme-monokai-pro-vscode
mon
1.1.14

anaconda-extension-pack
ms-
1.0.1

python
ms-
2019.12.49019-dev

remote-ssh
ms-
0.47.2

remote-ssh-edit
ms-
0.47.2

remote-ssh-explorer
ms-
0.47.2

vsliveshare
ms-
1.0.1293

color-highlight
nau
2.3.0

emoji
Per
0.0.3

material-icon-theme
PKi
3.9.1

java
red
0.53.1

vscode-yaml
red
0.6.1

LiveServer
rit
5.6.1

sass-indented
rob
1.5.1

vscode-scss-formatter
sib
1.4.2

code-spell-checker
str
1.7.20

sort-lines
Tyr
1.9.0

highlight-matching-tag
vin
0.9.5

vscodeintellicode
Vis
1.2.0

vscode-java-debug
vsc
0.23.0

vscode-java-dependency
vsc
0.6.0

vscode-java-pack
vsc
0.8.0

vscode-java-test
vsc
0.21.0

vscode-maven
vsc
0.19.1

jinja
who
0.0.8

better-align
wwm
1.1.6

JavaScriptSnippets
xab
1.7.2

material-theme
zhu
3.0.3

(6 theme extensions excluded)

This is working as expected; here are relevant rules from markdown.css that need to be overridden: https://github.com/microsoft/vscode/blob/e5f0077f408e68b35b5e06f22a283d4d5b3ad94a/extensions/markdown-language-features/media/markdown.css#L183
The intent of user styles are to augment the base styles and unfortunately there is no way I can see to provide a base, theme aware style rule for code blocks that can be overridden by less specific user style rule

Ah, that makes sense. Thanks for the response!


flutter build apk / flutter install hangs on emulator created by flutter

Steps to Reproduce

Create an android emulator via flutter: flutter emulator --create (I have to edit the config slightly as per https://github.com/flutter/flutter/issues/23988)
Launch the emulator: flutter emulator --launch flutter_emulator
Create application:  flutter create flutter_build_apk_test
Verify that stuff works:
$ cd flutter_build_apk_test/
$ flutter run
(the app launches and looks fine) (exiting with 'q')
$ flutter build apk
$ flutter install
now it just hangs at Installing build/app/outputs/apk/app.apk

If on the other hand I launch another emulator I have laying around:
$ time flutter build apk
Initializing gradle...                                       0.6s
Resolving dependencies...                                    1.1s
Gradle task 'assembleRelease'...
Gradle task 'assembleRelease'... Done                        3.8s
Built build/app/outputs/apk/release/app-release.apk (4.7MB).

real	0m6.437s
user	0m5.053s
sys	0m0.685s

$ time flutter install
Initializing gradle...                                       0.6s
Resolving dependencies...                                    1.1s
Installing app.apk to Android SDK built for x86 64...
Installing build/app/outputs/apk/app.apk...                  5.1s
Error: ADB exited with exit code 1
adb: failed to install [pathto]/flutter_build_apk_test/build/app/outputs/apk/app.apk: Failure [INSTALL_FAILED_NO_MATCHING_ABIS: Failed to
extract native libraries, res=-113]
Install failed

real	0m7.837s
user	0m3.766s
sys	0m0.742s

So here it just gives me a weird error --- but at least it doesn't hang.
The error is probably https://github.com/flutter/flutter/issues/8824
Logs
With emulator that hangs:
$ flutter doctor -v
[✓] Flutter (Channel master, v0.10.3-pre.104, on Linux, locale en_US.UTF-8)
    • Flutter version 0.10.3-pre.104 at [pathto]/flutter/flutter
    • Framework revision 7e652d1dba (8 hours ago), 2018-11-05 20:00:19 -0500
    • Engine revision 3374f4cce0
    • Dart version 2.1.0 (build 2.1.0-dev.8.0 bf26f760b1)

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at [pathto]/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: [pathto]/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
    • All Android licenses accepted.

[✓] Android Studio (version 2.3)
    • Android Studio at [pathto]/android-studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2017.3)
    • IntelliJ at /opt/intellij-ue-2017.3
    • Flutter plugin version 20.0.2
    • Dart plugin version 173.4700

[✓] IntelliJ IDEA Ultimate Edition (version 2018.1)
    • IntelliJ at /opt/intellij-ue-2018.1
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5540.11

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

• No issues found!

With emulator that gives error:
$ flutter doctor -v
[✓] Flutter (Channel master, v0.10.3-pre.104, on Linux, locale en_US.UTF-8)
    • Flutter version 0.10.3-pre.104 at [pathto]/flutter/flutter
    • Framework revision 7e652d1dba (8 hours ago), 2018-11-05 20:00:19 -0500
    • Engine revision 3374f4cce0
    • Dart version 2.1.0 (build 2.1.0-dev.8.0 bf26f760b1)

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at [pathto]/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: [pathto]/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
    • All Android licenses accepted.

[✓] Android Studio (version 2.3)
    • Android Studio at [pathto]/android-studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2017.3)
    • IntelliJ at /opt/intellij-ue-2017.3
    • Flutter plugin version 20.0.2
    • Dart plugin version 173.4700

[✓] IntelliJ IDEA Ultimate Edition (version 2018.1)
    • IntelliJ at /opt/intellij-ue-2018.1
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5540.11

[✓] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 7.1.1 (API 25) (emulator)

• No issues found!

gives me a weird error

Failure [INSTALL_FAILED_NO_MATCHING_ABIS: Failed to
extract native libraries, res=-113]

Is this the error you are referring to?

With emulator that gives error:

Did you intend to post the error here instead of the flutter doctor -v output a second time?

Is this the error you are referring to?

Yes, the
Error: ADB exited with exit code 1
adb: failed to install [pathto]/flutter_build_apk_test/build/app/outputs/apk/app.apk: Failure [INSTALL_FAILED_NO_MATCHING_ABIS: Failed to
extract native libraries, res=-113]
Install failed

that I had pasted just before was the error I was referring to.

Did you intend to post the error here instead of the flutter doctor -v output a second time?
No, I already posted the error.
There two flutter doctor -v outputs are from

The emulator that hangs
The emulator that produce an error

Maybe pruning the output to
[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

and
[✓] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 7.1.1 (API 25) (emulator)

is more helpful.

Duplicate of #8824

Issue #8824 talks about getting the error message --- the error I've reported here is that it hangs and doesn't actually get to the error message.

What if you use

flutter build apk --release
?

Same result. Also both flutter build apk and flutter build apk --release seems to build build/app/outputs/apk/release/app-release.apk.

Sorry, again :-(
I meant flutter build apk --debug because as mentioned in the quote --release builds are not supported on the emulator.

@jensjoha
See flutter.gradle located in flutterroot/packages/flutter_tools/gradle
// Add x86/x86_64 native library. Debug mode only, for now.

x86/x86_64 is not supported in non-debug mode(unless there is an arm emulation like libhoudini).

flutter build apk --debug
flutter install

installs in a few seconds.

I'll try to reiterate once again:

Creating an emulator with the flutter tools,
Building apk (in release mode), and
Running flutter install
gives the result of the install being stuck, just sitting there and not finishing. It does not give an error message. It's stuck. I find that to be unacceptable. In reality I cannot know if I should wait another few seconds (after having waited several minutes), or give up and Ctrl-C it. If I had been given an error message, at least I would know that it wasn't possible - but I'm not given an error message. It's stuck.

@zoechi  Maybe we should make this kind of approach fail early.

I tried to reproduce this hanging issue on my mac, just got a error message:
Error: ADB exited with exit code 1
adb: failed to install
/Users/kylewong/Codes/Flutter/alibaba-flutter/Projects/flutter_build_apk_test/bu
ild/app/outputs/apk/app.apk: Failure [INSTALL_FAILED_NO_MATCHING_ABIS: Failed to
extract native libraries, res=-113]
Install failed

my flutter doctor -v:
KyleWongdeMacBook-Pro:flutter_build_apk_test kylewong$ /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/bin/flutter doctor -v
[✓] Flutter (Channel master, v1.1.6-pre.24, on Mac OS X 10.14.3 18D32a, locale
    en-CN)
    • Flutter version 1.1.6-pre.24 at
      /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter
    • Framework revision aca3aba10e (9 hours ago), 2019-01-03 17:18:27 -0800
    • Engine revision e52287a1b5
    • Dart version 2.1.1 (build 2.1.1-dev.0.1 88e6fe0f67)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/kylewong/Library/Android/sdk
    • Android NDK at /Users/kylewong/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    ! CocoaPods out of date (1.5.0 is recommended).
        CocoaPods is used to retrieve the iOS platform side's plugin code that
        responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work
        on iOS.
        For more info, see https://flutter.io/platform-plugins
      To upgrade:
        brew upgrade cocoapods
        pod setup

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)

[✓] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 9
      (API 28) (emulator)

! Doctor found issues in 1 category.

@jensjoha

And it was with the emulator created via flutter?
I'm on Linux, maybe that makes a difference.
(And the emulator that it created at least was different than the one you have:
[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

)

@jensjoha
Yes, I followed your steps, everything is the same except the host os.

And presumably what android images we have installed. I'll try to install a x64 android 9.0...
(tinkers in Android Studio to install stuff)
So I installed everything I could that said api 28 (and I think it also updated the emulator in the process) and created a new emulator. Now it quickly gives me an error (and the emulator has the right size, i.e. #23988 is no longer present).
(tinkers in Android Studio to uninstall stuff again)
So I uninstalled everything I could that said api 28 (though I don't think I can go back on the updated emulator), and created a new emulator. It now still quickly gives me an error (and the emulator has the right size, i.e. #23988 is no longer present).
I'm guessing I had a bad emulator-version somehow :/

When I switched system image for the emulator from Q to Pie it solved it for me.

Disable play protect on your emulator


Working in PWA

I've developed a simple app using the barcode-scanner.
It works in developer mode, but as soon as I switch to production mode i get
[Scanner Web Error] QR code parse error, error = l: No MultiFormat Readers were able to detect the code.

The workaround that I found was to set in angular.js
"production": {
....
              "optimization": {
                "scripts": false,
                "styles": true
              }
}

But I don't like it.
Any idea of what might be tree-shaked and how to avoid it?

@impronta48 Did you get the barcode scanner working on a mobile device as a PWA?

yes, it works easily. I had some problems when compiling on Android, but I solved removing the optimizations

Hello,
I'm trying to use this package in my Ionic webapp project too.
It seems to "work" but the scanner does not stay. It opens, scan and close directly with an error:
QR code parse error, error = No barcode or QR code detected.
https://github.com/user-attachments/assets/17c754a1-34a7-4d22-87c0-da4562194255
I only have a new created ionic project (using Angular Standalone) with only this package and this configuration:
const result = await CapacitorBarcodeScanner.scanBarcode({
    hint: 0,
    cameraDirection: 1
});

console.log(result);

Can someone help me with this?
Thanks,
Loïc

Is this package compatible with WEV Plateform or this is only for IOS and Android?
Thanks,
Loïc


fix: Video - Console error shows up when playing video

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39253
PROPOSAL: https://github.com/Expensify/App/issues/39253#issuecomment-2027956571
Tests

Go to any chat.
Upload a video.
Play the video.
Verify that: No console error will show up when playing the video.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat.
Upload a video.
Play the video.
Verify that: No console error will show up when playing the video.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/161821005/a4f1f79e-9f85-404d-929c-4053c3503b78

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/08631beb-4017-40d9-9e7c-e05b4ddbba27

iOS: Native
https://github.com/Expensify/App/assets/161821005/c9ffdf00-6a07-4b61-b9eb-7c673d79da14

iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/ec68d42f-04f0-428b-87b6-fb84f1630ad0

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/949e4be0-db50-47a2-9eb0-9204b8635bef

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/8937f004-6cc1-4cf3-8231-b5fd64fbfe43

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@nkdengineer bump

@rushatgabhane bump on the proposal, the current PR does not solve the issue.

@rushatgabhane Sorry for delay, I'm checking this now.

@nkdengineer no worries! it was a weekend :)

@rushatgabhane I updated, please help to check again.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Can't start the server, port 8843 occupied

When trying to start the ws server I receive an error so service refuses to start:

Chat server starting at <IP_ADDRESS>:5559
PHP Fatal error:  Uncaught exception 'React\Socket\ConnectionException' with message 'Could not bind to tcp://<IP_ADDRESS>:8843: Address already in use' in /var/www/app/vendor/react/socket/src/Server.php:29
Stack trace:
#0 /var/www/app/vendor/cboden/ratchet/src/Ratchet/App.php(93): React\Socket\Server->listen(8843)
#1 /var/www/app/module/Chat/bin/server.php(21): Ratchet\App->__construct('localhost', '5559', '<IP_ADDRESS>')
#2 {main}
thrown in /var/www/app/vendor/react/socket/src/Server.php on line 29

The port hardcoded by Ratchet 8843 is occupied on my FreeBSD server. Any help?

Well I ended up writing my own WsServer class.


Change the alert for merge systems

Make it for clear that there needs to be a clef on the system if they're both empty.

fixed in 41994ac


Update native.adoc

Typo code says:
+++
AP_INIT_TAKE1(
"WaitBeforeRemove",
cmd_proxy_cluster_wait_for_remove,
NULL,
OR_ALL,
"WaitBeforeRemove - Time in seconds before a node removed is forgotten by httpd: (Default: 10 seconds)"
+++

I wonder how that happened :-D


dzen: also install gadgets

Please fill out the template.
Read: https://k1sslinux.org/wiki/kiss/style-guide
Please include the manifest for version bumps and new packages.

Description of package
Installed manifest of package
(kiss manifest <pkg>)
/var/db/kiss/installed/dzen/version
/var/db/kiss/installed/dzen/sources
/var/db/kiss/installed/dzen/manifest
/var/db/kiss/installed/dzen/depends
/var/db/kiss/installed/dzen/build
/var/db/kiss/installed/dzen/
/var/db/kiss/installed/
/var/db/kiss/choices/dzen>usr>bin>dzen2
/var/db/kiss/choices/
/var/db/kiss/
/var/db/
/var/
/usr/share/licenses/dzen/LICENSE
/usr/share/licenses/dzen/
/usr/share/licenses/
/usr/share/doc/dzen/README
/usr/share/doc/dzen/CREDITS
/usr/share/doc/dzen/
/usr/share/doc/
/usr/share/
/usr/bin/textwidth
/usr/bin/gdbar
/usr/bin/gcpubar
/usr/bin/dbar
/usr/bin/
/usr/

New package

[ ] Latest upstream version.
[ ] I agree to maintain this package.
[ ] I agree to notify the @kiss-community maintainers if I can no longer maintain this package.

Existing package

[x] I am the maintainer of this package.

Thank you, you are awesome!


file exists at %!s(MISSING), can't create volume there

I use wurstmeister's image to run multiple kafka brokers in docker. Operations see http://wurstmeister.github.io/kafka-docker/.
But failed:
file exists at %!s(MISSING), can't create volume there
I wan't to kown why and how to solve it.
(Cent OS 7, kernal 3.10.0-229.el7.x86_64
docker 1.5.0
docker-compose 1.1.0)

I think this is fixed by https://github.com/docker/docker/pull/11934 , can you try docker 1.6.0?

I'm going to close this issue since it looks like #11934 solved the problem. Please, feel free to reopen it if you find it again with a newer version of Docker.


Debian12

Changelog: provide automatic packaging for debian12

This also needs updating build-deb.sh to be effective, right?

Not necessary ... but neverthless a good comment.


#computeValidJumpDests from evm-semantics

This issue is for investigating the slow #computeValidJumpDests function from evm-semantics. Here it is minimized:
test.k:
module TEST
    imports COLLECTIONS
    imports BYTES
    imports K-REFLECTION

 // ---- for the proof --------------------------
    syntax KItem ::= run ( Step ) | done ( Step )
    syntax Step ::= Set

    rule <k> run(S) => done (S) ... </k>

 // ----------------------------------------------------------
    syntax Set ::= #computeValidJumpDests(Bytes)            [function, memo]
                 | #computeValidJumpDests(Bytes, Int, List) [function]

    rule #computeValidJumpDests(PGM) => #computeValidJumpDests(PGM, 0, .List)

    syntax Set ::= #computeValidJumpDestsWithinBound(Bytes, Int, List) [function]

    rule #computeValidJumpDests(PGM, I, RESULT) => List2Set(RESULT)
      requires I >=Int lengthBytes(PGM)
    rule #computeValidJumpDests(PGM, I, RESULT) => #computeValidJumpDestsWithinBound(PGM, I, RESULT)
      requires I <Int lengthBytes(PGM)

    rule #computeValidJumpDestsWithinBound(PGM, I, RESULT) =>
         #computeValidJumpDests(PGM, I +Int 1, RESULT ListItem(I))
      requires PGM [ I ] ==Int 91
    rule #computeValidJumpDestsWithinBound(PGM, I, RESULT) =>
         #computeValidJumpDests(PGM, I +Int 1, RESULT)
      requires notBool PGM [ I ] ==Int 91

endmodule

test-spec.k
module TEST-SPEC
    imports TEST

 // ---------------------------------------------

    claim <k>
      run(#computeValidJumpDests(String2Bytes(
         [ascii string here]
      ))) => done( ?_ )
      ... </k>

endmodule

A typical program from KEVM (I selected one randomly) seems to be about 7000 bytes, so a 7000 character ascii string that demonstrates the problem can be found in the attached text file. Note that [ is special and represents the EVM opcode JUMPDEST. On this input, kprove takes about a minute.
ascii.txt
test-spec.k.txt (.txt extension is needed for github, just drop it)
This is on K version 5.1.0 and Kore version <IP_ADDRESS>. To replicate:
$ kompile test.k --backend haskell
$ time kprove test-spec.k --backend haskell

Here is a profile of test-spec.k:
valid-jump-prof.tar.gz
See kore-exec.eventlog.json for speedscope profile.
See kore-exec.prof.html for profiteur profile.
Command used to generate profile:
timeout -s INT 10m env GHCRTS='-p -l-au' kprove test-spec.k TEST --backend haskell --format-failures

This investigation seems complete. We expect that #2474 will improve the performance of #computeValidJumpDests.


ionic auth pasword reset service is not working

Hi,
ionic auth pasword reset service is not working. Yesterday console of browser returned this line:
[Error] Failed to load resource: the server responded with a status of 404 (HTTP/2.0 404) (self, line 0)
https://api.ionic.io/auth/users/selfFailed to load resource: the server responded with a status of 404 (HTTP/2.0 404)
My code exit after confirmPasswordReset fails so I recive ‘Errore'. Verification code arrives correctly.
`  $scope.changepassword = function(){
$scope.error = '';
   $ionicAuth.confirmPasswordReset($scope.data.verifica, $scope.data.npassword).then(function(){

       $state.go('login');
   }, function(){
       $scope.error = 'Errore’;
   })

}
}`
Today 404 error disappear but If i emulate in Ripple the response error is:
[Error] Failed to load resource: the server responded with a status of 422 (Unprocessable Entity) (xhr_proxy, line 0)
http://localhost:4400/ripple/xhr_proxy?tinyhippos_apikey=ABC&tinyhippos_rurl=https%3A//api.ionic.io/auth/users/passwordFailed to load resource: the server responded with a status of 422 (Unprocessable Entity)
{     "meta": {         "status": 422,         "request_id": "513d2c45-be92-4c68-ccf4-e9e6697d52ff",         "version": "2.0.0-beta.0"     },     "error": {         "link": null,         "type": "UnprocessableEntity",         "message": "An error occurred while validating the request parameters.",         "details": [             {                 "errors": [                     "Not a valid string."                 ],                 "error_type": "invalid",                 "parameter": "reset_token"             }         ]     } }
the code  worked till the last week.
I see in the response

"version": "2.0.0-beta.0"

but my app uses ionic v1
thanks

I solved with a cast. Server wants a string not a  number
$ionicAuth.confirmPasswordReset(n.toString(), $scope.data.npassword)

Keep in mind that your 'n' must be already a String, due to codes having leading zeros.
For example, 012345 would be 12345 if stored as integer, and by using n.toString() you'll be sending '12345' to the service, resulting in failed attempt. You may have a potential bug there so check it out.
Regards.

Hi,
In docs n is a Number
confirmPasswordReset(code: number, newPassword: string): Promise
https://docs.ionic.io/api/client/auth/#passwordResetUrl
Mi code worked till 2017/02/28. After ionic cloud issue I changed type from number to string


jupyterlab>=0.10.0

labextension breaks when running<EMAIL_ADDRESS>

Should we change it to ~0.10.0 then?

From my undestanding, ~0.10.0 := >=0.10.0 <0.11.0 whereas ~0 := >=0.0.0 <1.0.0
https://docs.npmjs.com/misc/semver#tilde-ranges-123-12-1

Aren't we targeting >=0.10.0 <0.11.0?

The purpose of this commit is to make interop between ipywidgets and jupyterlab more flexible by allowing higher minor versions, because currently I'm running jupyterlab 0.11.2 and ipywidgets depends on ^0.10.0.

The two are not rectifiable, because 0.10 -> 0.11 is considered a major version release.  The solution is for ipywidgets to bump to 0.11, especially because 0.10 has known issues with state restoration.

Ok, I see. I'll update the commit...

The two are not rectifiable, because 0.10 -> 0.11 is considered a major version release. The solution is for ipywidgets to bump to 0.11, especially because 0.10 has known issues with state restoration.

Agreed. Grant, can you make sure it works in 0.11.0? I haven't had time to check things yet.

I tested and Widget List.ipynb is rendering with no issues.

I'm going to go for and merge this. After all, "laugh in the face of danger" is the official jupyter motto, is it not?
Happy hacking! :bowtie:


constant static fields are not accessible by mirrors

The program
import "dart:mirrors";

class A {
   static const ONE = 1;
}

main() {
  print(reflectClass(A).getField(#ONE));
}

fails with
RuntimeError: Cannot find "A_ONE" in current isolate.

It seems that static const fields are never emitted, even if they are accessible by reflection.
CC: @mbullington.

Proposed fix in https://codereview.chromium.org/1225083004/.


change more tokentypes to be punctuator - fixes #59

#59.
Came across as similar issue in jscs as well. Some of the rules are checking something like op.type === "Punctuator" but some of the types are still TokenType rather than a string.
I basically just added everything in https://github.com/babel/babel/blob/master/src/acorn/src/tokentype.js#L48-L96 that wasn't already there.
I'm not sure we want all of these though?

Nope, definently want them all. Thanks!


Linux build failure as of 7a0c518

The commit 7a0c518 breaks my linux build, and I can no longer install Nimble. This is a rather large commit, and it's difficult to pinpoint the error.
$ git checkout 7a0c518  # A.k.a. devel at the momement.
$ R CMD build
...
$ R CMD INSTALL nimble_0.6-6.tar.gz
* installing to library ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4’
* installing *source* package ‘nimble’ ...
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
working on eigen
checking how to run the C++ preprocessor... clang++ -Qunused-arguments -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking Eigen/Dense usability... no
checking Eigen/Dense presence... no
checking for Eigen/Dense... no
Using the version of Eigen provided with NIMBLE
Using CppAD directory
NIMBLE_DIR = /home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble
ENABLE_LIB=true
configure: creating ./config.status
config.status: creating inst/make/Makevars
config.status: creating inst/make/Makevars_lib
config.status: creating R/config.R
config.status: creating src/Makevars
Building libnimble
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c RcppUtils.cpp -o RcppUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c EigenTypedefs.cpp -o EigenTypedefs.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c eigenUsingClasses.cpp -o eigenUsingClasses.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c RcppNimbleUtils.cpp -o RcppNimbleUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c Utils.cpp -o Utils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c NamedObjects.cpp -o NamedObjects.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c ModelClassUtils.cpp -o ModelClassUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c accessorClasses.cpp -o accessorClasses.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c dists.cpp -o dists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimDists.cpp -o nimDists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c dllFinalizer.cpp -o dllFinalizer.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimbleGraph.cpp -o nimbleGraph.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c smartPtrs.cpp -o smartPtrs.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c predefinedNimbleLists.cpp -o predefinedNimbleLists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimOptim.cpp -o nimOptim.o
linking libnimble.so
Linux
g++  -shared -o libnimble.so  RcppUtils.o EigenTypedefs.o eigenUsingClasses.o RcppNimbleUtils.o Utils.o NamedObjects.o ModelClassUtils.o accessorClasses.o dists.o nimDists.o dllFinalizer.o nimbleGraph.o smartPtrs.o predefinedNimbleLists.o nimOptim.o
rm *.o
** libs
clang++ -Qunused-arguments -I/usr/share/R/include -DNDEBUG -I../inst/include  -I     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimble.cpp -o nimble.o
clang++ -Qunused-arguments -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions -Wl,-z,relro -o nimble.so nimble.o -L../inst/CppCode -lnimble -Wl,-rpath=/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble/CppCode -llapack -lblas -L/usr/lib/R/lib -lR
/usr/bin/ld: nimble.o: relocation R_X86_64_32 against `CallEntries' can not be used when making a shared object; recompile with -fPIC
nimble.o: error adding symbols: Bad value
clang: error: linker command failed with exit code 1 (use -v to see invocation)
/usr/share/R/share/make/shlib.mk:6: recipe for target 'nimble.so' failed
make: *** [nimble.so] Error 1
make: Target 'all' not remade because of errors.
ERROR: compilation failed for package ‘nimble’
* removing ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble’
* restoring previous ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble’

This appears to be due to clang being more case sensitive about -fPIC. As a workaround, I've added the -fPIC to my ~/.R/Makevars. We should figure out how to tell compilers to use -fPIC instead of -fpic.

It looks like we use -fpic rather than -fPIC. The lower case version can result in smaller code, but has platform-dependent limitations (see reference below). My guess is that the latest AD merge put us over a symbol count limit and -fpic no longer works on my platform.
https://stackoverflow.com/questions/3544035/what-is-the-difference-between-fpic-and-fpic-gcc-parameters

A user recently had this same issue, so I am raising the priority.

It may be possible to resolve this by rewriting -fpic as -fPIC` using Perry's script from #432

@perrydv What is the status of #432 ?

It looks like It looks like we may be able to set CPICFLAGS=-fPIC and FPICFLAGS=-fPIC, http://r.789695.n4.nabble.com/Help-needed-to-compile-R-with-shared-library-td890813.html

just a note that my Ubuntu machine is using -fpic (this is with g++) and I'm not having any problems.

Pasting @perry's comment from slack

perry [11:59 AM]
@fritzo I suggest following experiment for -fPIC: Do an on-the-fly compilation (doesn't matter what, just to generate a Makevars in your tempdir()).  Modify Makevars with CPICFLAGS=-fPIC.  Try another compileNimble with showCompilerOutput = TRUE.  Observe if -fPIC was used.

@perrydv I'm not sure I understand the purpose of the experiment: it is nimble itself that fails to compile (and therefore install). I can't even get to the stage of running compileNimble. Am I misunderstanding?

Oh, I was not getting it.  Does building nimble fail in the first set of C++ compilations or the second set?

Nimble installation fails during the second step:
+ cd /home/fritz/nimble-dev/nimble/packages
+ rm -f nimble_0.6-6.tar.gz
+ R CMD build --no-build-vignettes --no-manual --no-resave-data nimble
* checking for file ‘nimble/DESCRIPTION’ ... OK
* preparing ‘nimble’:
* checking DESCRIPTION meta-information ... OK
* cleaning src
* running ‘cleanup’
* checking for LF line-endings in source and make files
* checking for empty or unneeded directories
* building ‘nimble_0.6-6.tar.gz’

+ R CMD INSTALL --no-docs --no-html --no-data --no-demo --no-multiarch --no-byte-compile nimble_0.6-6.tar.gz
* installing to library ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4’
* installing *source* package ‘nimble’ ...
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
working on eigen
checking how to run the C++ preprocessor... g++ -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking Eigen/Dense usability... no
checking Eigen/Dense presence... no
checking for Eigen/Dense... no
Using the version of Eigen provided with NIMBLE
Using CppAD directory
NIMBLE_DIR = /home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble
ENABLE_LIB=true
configure: creating ./config.status
config.status: creating inst/make/Makevars
config.status: creating inst/make/Makevars_lib
config.status: creating R/config.R
config.status: creating src/Makevars
Building libnimble
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c RcppUtils.cpp -o RcppUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c EigenTypedefs.cpp -o EigenTypedefs.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c eigenUsingClasses.cpp -o eigenUsingClasses.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c RcppNimbleUtils.cpp -o RcppNimbleUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c Utils.cpp -o Utils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c NamedObjects.cpp -o NamedObjects.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c ModelClassUtils.cpp -o ModelClassUtils.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c accessorClasses.cpp -o accessorClasses.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c dists.cpp -o dists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimDists.cpp -o nimDists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c dllFinalizer.cpp -o dllFinalizer.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimbleGraph.cpp -o nimbleGraph.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c smartPtrs.cpp -o smartPtrs.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c predefinedNimbleLists.cpp -o predefinedNimbleLists.o
g++  -I/usr/share/R/include -DNDEBUG -I"../include"     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimOptim.cpp -o nimOptim.o
linking libnimble.so
Linux
g++  -shared -o libnimble.so  RcppUtils.o EigenTypedefs.o eigenUsingClasses.o RcppNimbleUtils.o Utils.o NamedObjects.o ModelClassUtils.o accessorClasses.o dists.o nimDists.o dllFinalizer.o nimbleGraph.o smartPtrs.o predefinedNimbleLists.o nimOptim.o
rm *.o
** libs
g++  -I/usr/share/R/include -DNDEBUG -I../inst/include  -I     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c nimble.cpp -o nimble.o
g++ -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions -Wl,-z,relro -o nimble.so nimble.o -L../inst/CppCode -lnimble -Wl,-rpath=/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble/CppCode -llapack -lblas -L/usr/lib/R/lib -lR
/usr/bin/ld: nimble.o: relocation R_X86_64_32 against `CallEntries' can not be used when making a shared object; recompile with -fPIC
nimble.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
/usr/share/R/share/make/shlib.mk:6: recipe for target 'nimble.so' failed
make: *** [nimble.so] Error 1
make: Target 'all' not remade because of errors.
ERROR: compilation failed for package ‘nimble’
* removing ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble’
* restoring previous ‘/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble’

The setup I have that is failing is g++ on Ubuntu 16.04:
$ g++ --version
g++ (Ubuntu 5.4.1-2ubuntu1~16.04) 5.4.1 20160904
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ uname -a
Linux nimbook 4.8.0-52-generic #55~16.04.1-Ubuntu SMP Fri Apr 28 14:36:29 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

turns out I'm having the same issue on my Ubuntu 16.04 machine. I forget when I said earlier that I've been on a different branch for a while and haven't built off of devel recently.

I just check and it works fine for Ubuntu 14.04 and R 3.2.3. Sometimes, too
new g++ compiler does not work well with some not too new R version.
On Tue, Jun 20, 2017 at 2:21 PM, Christopher Paciorek <
<EMAIL_ADDRESS>wrote:

turns out I'm having the same issue on my Ubuntu 16.04 machine. I forget
when I said earlier that I've been on a different branch for a while and
haven't built off of devel recently.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/issues/429#issuecomment-309895567,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH1Sxza0A0i7RflA3rLlixNl0C3lF2XVks5sGDf2gaJpZM4N0n5D
.

On my OS X, the installed etc/Makeconf from R uses -fPIC in 5 places.  Can you confirm that the same file on Ubuntu uses -fpic, so we are sure it is not being over-ridden at some other step?  If so, since you reported that adding -fPIC to /.R/Makevars fixes the problem, can you try instead adding the same content to src/Makevars.in in the package source files?  That would be a more localized fix.

@perry confirmed, on my system
$ grep -i fpic /usr/lib/R/etc/Makeconf
CPICFLAGS = -fpic
CXXPICFLAGS = -fpic
CXX98PICFLAGS = -fpic
CXX11PICFLAGS = -fpic
CXX14PICFLAGS = -fpic
FCPICFLAGS = -fpic
FPICFLAGS = -fpic
CXX1XPICFLAGS = -fpic
ALL_FFLAGS = $(R_XTRA_FFLAGS) $(PKG_FFLAGS) $(FPICFLAGS) $(SHLIB_FFLAGS) $(FFLAGS)

@perrydv Yes, that seems to work to put -fPIC in Makevars.in: #448

@duncantl has suggested we test if -fPIC works on a system. We decided not to do this for 0.6-6 but leaving open as a question for incorporating down the road:
My suggestion is that in the configure.ac/in file,  there is a check for whether
-fPIC
works with R's selected CXX compiler.
And more specifically  whether R's select CXX compiler can handle
-fPIC in addition to R's selected  CXXPICFLAGS variable.
But there is CXXPICFLAGS, CXX98PICFLAGS, CXX111PICFLAGS, ......
So how about having a temporary sub-directory under the top-level directory that contains the two attached files: foo.cc and Makevars
Within configure.ac, call
cd temp; R CMD SHLIB foo.cc
and check $? to see if it is 0 and so success.
If not, then we cannot add -fPIC  and so don't.
Makevars:
PKG_CXXFLAGS=-fPIC

foo.cc
int foo(int x)
{
    return(x + 1);
}


Use LLVM's AtomicRMWInst for most of the atomics instructions.

LLVM provides an AtomicRMWInst that satisfies most of the spirv.atomic
'fake' intrinsics we used previously, so lets switch over to use that.
This also allows other languages that aren't coming from a CL
perspective to use AtomicRMWInst and have clspv output the correct
instructions.
I also fixed a bug with the mem_fence replacements - having two maps of
const char* and then comparing if the two pointers matched would compare
the two separate binary blobs of the const char* (EG. their pointers)
which might not match (depending on the linker). Instead I changed it to
a std::map where the second element is a std::tuple.
Lastly, MSVC would complain with SPIRVProducerPass so I fixed all the warnings-as-errors that were produced.

I just saw this. I'll take a look at it next week.
And thanks for the contribution!

@dneto0 gurgh, the lack of CI strikes me again. I'll get it building on Linux and get back to you.

I've pushed what I hope is the change - but this week I'm away on business and without my Linux machine (only my Win10 laptop). Happy to wait until I'm back at my Linux machine to push this PR further if that helps.

Rebased and pushed into master as 3967210de9e5


Feature Request (Package Website)

It is very convinient to have brackets package/Theme  website like

Atom
VSCode also like
Sublime Text

It is here https://brackets-registry.aboutweb.com/

@TWOWhite is it official website?

@MandarSant it is. It's also the interface for adding, updating and removing extensions.
There's also http://brackets.dnbard.com/ which ranks the extensions by downloads and such.
Closing as answered, but feel free to ask more questions if needed or send suggestions! 👍

@petetnt  http://brackets.dnbard.com/ is down

Thanks notifying @MandarSant, pinging @dnbard

@petetnt  Thanks for notification.
This site have some external issues with database. I'm working on resolving them atm.

@dnbard please inform me after website is up...!


Delay in closing the actions popup when selecting "Reply in thread"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a chat
Send a message
Right-click on the message
Click on "Reply in thread"

Expected Result:
The actions popup should close immediately upon selecting "Reply in thread"
Actual Result:
There is a noticeable delay in the closure of the actions popup when clicking on "Reply in thread"
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/a76ccbc5-5074-4054-ada1-230788196ee3
https://github.com/Expensify/App/assets/43996225/530b79e9-e1a5-4388-b41f-c6f749c11bda
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686348571158339
View all open jobs on GitHub

This issue https://github.com/Expensify/App/issues/19776 will handle the delay

Agreed, the solution in https://github.com/Expensify/App/issues/19776 will address this issue. Think we can go ahead and close this.


Can't get latest version via Windows scoop

The version which is downloads or updates to is:
pscale version 0.115.0 (build date: 2022-08-30T18:49:01Z commit: ce370d5)

I checked the repo here:
https://github.com/planetscale/scoop-bucket
And it does look like it's been updated.
I also removed the scoop bucket and re-added it, but it didn't make a difference.
I've recently got a lot of emails about using an out of date CLI, hence attempting to perform the upgrade.
Thanks 🙏

I checked the repo here: https://github.com/planetscale/scoop-bucket
And it does look like it's been updated.

Fwiw, I have no real idea how scoop works, but the repository there is updated?
https://github.com/planetscale/scoop-bucket/blob/main/pscale.json contains references to 0.197.0 which is the latest version?

Scratch this - Sorry, it does appear to update when I use Windows Powershell as an administrator.
Thanks for taking the time to respond 😄


File scanning proof of concept: trigger scan of new S3 objects

Summary
Create a Lambda function that triggers a scan of new objects created in an S3 bucket.  This will be a proof-of-concept for the proposed asynchronous solution in Design Doc 008: File upload for API and UI + content scanning:

Acceptance criteria

[x] The function should be triggered automatically by S3 s3:ObjectCreated:* events.
[ ] The S3 object that triggered the scan should be updated with metadata related to the scan: IN_PROGRESS and  FAILED_TO_SCAN.
[x] The function should also respond to SNS event triggers from the Scan Files service to update the S3 object metadata with the scan result.

Next task is to figure out the IAM and SNS policies required by Scan Files to:

Download files from the upload bucket; and
Publish messages to the SNS topic.

In both cases, the resources will be in a different account from Scan Files.


Failing secret webhook causes unexpected behavior

K3s tracking issue for:

https://github.com/rancher/rke2/issues/4266

To test:

Create a cluster (any number of servers/agents)
Create a bad webhook configuration (this one just calls out to httpbin.org for a 502 error response):

apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
  name: rancher.cattle.io
webhooks:
- admissionReviewVersions:
  - v1
  - v1beta1
  clientConfig:
    url: https://httpbin.org/status/502
  failurePolicy: Fail
  matchPolicy: Equivalent
  name: rancher.cattle.io.secrets
  namespaceSelector: {}
  objectSelector: {}
  reinvocationPolicy: Never
  rules:
  - apiGroups:
    - ""
    apiVersions:
    - v1
    operations:
    - CREATE
    resources:
    - secrets
    scope: Namespaced
  sideEffects: NoneOnDryRun
  timeoutSeconds: 5

Attempt to join a new agent
Note that the agent is unable to join the cluster - When node registration is blocked by the failing webhook, the error on the server isn't clear what's going on:

May 22 22:15:40 systemd-node-1 rke2[223]: time="2023-05-22T22:15:40Z" level=error msg="Internal error occurred: failed calling webhook \"rancher.cattle.io.secrets\": failed to call webhook: an error on the server (\"\") has prevented the request from succeeding"

The error log on the agent does indicate that the password was rejected, but not why:
May 22 22:17:15 systemd-node-2 rke2[222]: time="2023-05-22T22:17:15Z" level=info msg="Waiting to retrieve agent configuration; server is not ready: Node password rejected, duplicate hostname or contents of '/etc/rancher/node/password' may not match server node-passwd entry, try enabling a unique node name with the --with-node-id flag"

Validated on fe9604ca
Environment Details

Infrastructure

[ ] Cloud
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

Ubuntu

Cluster Configuration:

1 server 1 agent

Additional files

$ cat webhook.yaml
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
  name: rancher.cattle.io
webhooks:
- admissionReviewVersions:
  - v1
  - v1beta1
  clientConfig:
    url: https://httpbin.org/status/502
  failurePolicy: Fail
  matchPolicy: Equivalent
  name: rancher.cattle.io.secrets
  namespaceSelector: {}
  objectSelector: {}
  reinvocationPolicy: Never
  rules:
  - apiGroups:
    - ""
    apiVersions:
    - v1
    operations:
    - CREATE
    resources:
    - secrets
    scope: Namespaced
  sideEffects: NoneOnDryRun
  timeoutSeconds: 5

Testing Steps

Create a cluster (any number of servers/agents)
Create a bad webhook configuration (this one just calls out to httpbin.org for a 502 error response):

Validation Results:

$ kubectl get node -A
NAME              STATUS   ROLES                  AGE     VERSION
ip-172-31-17-79   Ready    control-plane,master   50m     v1.27.3-rc1+k3s1
ip-172-31-29-4    Ready    <none>                 6m36s   v1.27.3-rc1+k3s1

Logs from server node

$ journalctl -xe | grep "NodePasswordValidationFailed" -i
Jun 16 17:21:34 ip-172-31-17-79 k3s[54471]: I0616 17:21:34.638484   54471 event.go:307] "Event occurred" object="ip-172-31-29-4" fieldPath="" kind="Node" apiVersion="" type="Warning" reason="NodePasswordValidationFailed" message="Deferred node password secret validation failed: Internal error occurred: failed calling webhook \"rancher.cattle.io.secrets\": failed to call webhook: an error on the server (\"\") has prevented the request from succeeding"


Page not in tree on left

Why isn't this page showing up on the left?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c368cf5f-c6f0-a600-7dd3-7ce49192f1ca
Version Independent ID: 9cfd94e2-5b23-ee9d-4a37-acb0d0808e88
Content: Azure AD B2C: Secure a web API by using Node.js | Microsoft Docs
Content Source: articles/active-directory-b2c/active-directory-b2c-devquickstarts-api-node.md
Service: active-directory-b2c
GitHub Login: @dstrockis
Microsoft Alias: xerners

@spottedmahn
Thanks for the feedback! We are currently investigating and will update you shortly.

@dstrockis - Can you take a look as to if the doc is supposed to be in the left pane navigation ?

#in-process

@spottedmahn Changed the node named Node.js in the TOC to point to the article in this thread instead of the github repository.
#please-close


Getting 5GHz WiFi working on RPi4 in FydeOS

Describe the bug or issue
I'm unable to connect to a 5GHz access point (in US) on RPi4 under FydeOS.
Only the lower band 5GHz channels (36-48) are discoverable.
Higher band channels (149-165) are not discoverable (checked with the WiFi Analyzer Android app).
Describe your setup

RPi4 8GB
FydeOS v11.4
FydeOS installed and booted from a Samsung T5 drive connected to USB 3.0 port

To Reproduce
Steps to reproduce the behavior:

Install the latest version of FydeOS (v11.4)
Attempt to connect to a 5GHz access point - fail

Expected behaviour
RPi4 can connect to a 5GHz WiFi network.
Additional information
From https://www.raspberrypi.org/documentation/configuration/wireless/wireless-cli.md:

On the Raspberry Pi 3B+ and Raspberry Pi 4B, you will also need to set the country code, so that the 5GHz networking can choose the correct frequency bands.

This is normally done via raspi-config or wpa_supplicant.conf in Raspberry Pi OS.
I have not found a way to check or override the country code value in FydeOS.

it's a known issue that the Pi4 / Pi 400 kit does not have the most capable wifi module, the wifi firmware that we use also does not offer raspi-config or similar way to tweak the config.
Based on our experience, the 5GHz wifi does not immediately show up, it usually turns up after we connect to a 2GHz. We also found that even if the Pi is connected to a 5GHz wifi, the actual transmission speed does not offer too much visible difference than the 2GHz one, probably due to the CPU limitation ...

On Linux (Raspberry OS) with the country code properly set, there is a substantial difference between 2GHz and 5GHz WiFi performance on RPi4. In my case, it's an order of magnitude (10x) difference.
5GHz: 56.41 / 25.15 mbps (down/up)
2.4GHz: 6.17 / 2.64mbps (down/up)

Without the country code set, RPi4 may or may not see a 5GHz AP, may or may not connect to the 5GHz AP it can see, and may or may not perform well even if connected.

the wifi firmware that we use also does not offer raspi-config or similar way to tweak the config.

Could you elaborate a bit more on this?

Also, to be fair, the same issue applies to various Android builds for RPi4.
Same with any Linux distro until the wifi country code is configured. With Linux I can set the country code to fix the issue. With Chromium OS / Android, I was not able to find any way to do this.

I updated the firmware on my WiFi AP, which also led to a complete factory reset of the AP. I decided to leave all of the factory settings as-is. The AP automatically picked channel 36 for the 5GHz band (used to be 161).
This time, RPi4 (running the latest Chromium OS build from this repo) was able to connect to the 5GHz network! 🎉
This did not work yesterday, when I manually forced channel 36 and tried to connect.
I looked into the AP settings, trying to find the one that did the trick in this case.
It's was the wireless mode:

802.11n/ac mixed (RPi4 can connect)
802.11ac only (RPi4 won't connect)

Comparing 802.11n 5GHz vs 802.11n 2.4GHz performance:
5GHz: 43.17 / 48.26 mbps (down/up)
2.4GHz: 7.20 / 7.34 mbps (down/up)

So my workaround for the time being to get 5GHz wifi to work:

Allow 802.11n/ac mixed mode
Manually set a lower band channel (36-48)

The issue with supporting 802.11ac (and higher band 5GHz channels) still stands true.
It will require finding a way to correctly set the wifi regulatory domain / country code.

fydeos-alpha added the "solved & solution provided" label 5 days ago

For anyone else landing here, a quick TL;DR:

The issue with supporting 802.11ac (as well as 802.11n higher band 5GHz channels) in FydeOs still stands true.
The issue is not limited to FydeOS. It affect any Chromium and/or Android based OS build for RPi4 out there.
Solving it would require finding a way to correctly set the wifi regulatory domain / country code for the RPi4's WiFi module. It's a driver/configuration problem (no raspi-config for Chromium/Android).


chaoskube: bump chart version to v0.9.0

This bumps the chart version because the last PR changed the semantics in values.yaml a little

In https://github.com/helm/charts/pull/6579 the format of resources was aligned with the rest of the charts but it has been different before: users that are upgrading need to change their values.yaml, hence the bump.

/lgtm

/assign @unguiculus

/lgtm

/retest


editor.hover.delay setting is only "activated" when user settings is altered.

Issue Type: Bug
File -> Preferences -> Settings
Search for "hover"
Alter Editor> Hover:Delay to 2001
The hover popup delay is now 2001 millis.
Close Visual Studio Code
Start Visual Studio Code
The hover popup delay is now 300 millis.
File -> Preferences -> Settings
"..." -> settings.json
See that in the settings.json (right side, under USER SETTINGS) the delay is set to 2001: "editor.hover.delay": 2001
Change the 2001 to for example 2000 (so that the settings.json is saved)>
The hover popup delay is now 2000 millis.
Repeat.


fix: Don't push into commit hash tag from "sc" branch

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.79%. Comparing base (0d66408) to head (7029125).
Report is 53 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   74.79%   74.79%
=======================================
  Files          25       25
  Lines         849      849
=======================================
  Hits          635      635
  Misses        214      214

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.