Cannot update or change config manualy

When access to jenking container example via exec bash enviroment
need root privileges but is not possible.
docker exec -it [container_id] bash
Example there is no sudo or su to root user does not work
su command gives error
su: must be run from a terminal
Sudo or root access is need for make config manualy or update .war file to
container.

export TERM=vt100 would bring piece of those commands needing term

I use my own build based off Jenkins that gives sudo rights to the jenkins user. The Dockerfile looks like:
FROM jenkins:1.596

USER root
RUN apt-get update \
      && apt-get install -y sudo \
      && rm -rf /var/lib/apt/lists/*
RUN echo "jenkins ALL=NOPASSWD: ALL" >> /etc/sudoers

USER jenkins
COPY plugins.txt /usr/share/jenkins/plugins.txt
RUN /usr/local/bin/plugins.sh /usr/share/jenkins/plugins.txt

You should not update .war file, but just change the docker image version you run.
About configuration, it is all stored in JENKINS_HOME so doesn't need to be root for edition.

BTW, I want to install some of the other tools using root or sudo but when i try to login i get the error "su: must be run from a terminal" . How can i get rid of this issues?

Write a Dockerfile to extend the jenkins one:
FROM jenkins
USER root
CMD install stuff as root
USER jenkins

FWIW, I was able to work around this (needed to install some tools) by using docker cp from the host - this copies the files as root.

This worked for me
docker exec -u root -it [container_id] bash

lol. ty

Thanks @gbonk worked a treat


feat(query-builder): move query builder library

CPT-994 (reviewed by @toptal/core-platform )
CPT-1216 (reviewed by @toptal/core-platform )
CPT-993
Description

[x] When the PR is draft, CPT-994 and CPT-1216 can be checked from this draft PR.

@toptal/react-query-builder library will be moved from Staff Portal to Picasso. Initial files and stories are added in ths PR.
PR will get out of draft status when CPT-993 is completed. (And will ping the reviewers with it.)
How to test

Temploy
@toptal/picasso-query-builder library and its section in storybook is new in picasso.

Screenshots

Development checks

[ ] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[ ] Self reviewed
[ ] Covered with tests (visual tests included)

Breaking change

[N/A] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.


docs(ngOptions): describe your change...

Rephrased a sentence for clarity

I signed it!

I signed it!
2015-10-05 10:42 GMT+02:00 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).
[image: :memo:] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/13010#issuecomment-145464121.

Backported to v1.4.x as 3397a03.


*(ticdc): split old update kv entry after restarting changefeed

What problem does this PR solve?

Issue Number: close #10918
What is changed and how it works?

split all kv entry which commit ts is older than the ts when changefeed start;
avoid splitting any update event inside sink module;
restart changefeed when meet duplicate entry error;

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest

/retest

/retest

/retest

/retest

/review

/retest-required

/test dm-integration-test

/hold

/retest

/retest

/retest

/test verify

/test cdc-integration-mysql-test

/test dm-integration-test

/test cdc-integration-kafka-test

/test dm-integration-test

/test cdc-integration-kafka-test

/retest

/test cdc-integration-mysql-test

/retest all

/test all

/retest

/test all

/test cdc-integration-mysql-test

/test all

/test verify

/test dm-integration-test

/test dm-integration-test

/lgtm

/unhold

/run-cherry-picker


fix(queries): Fix typos in queries

Relevant information
Remove a duplicated AS clause from some queries. This should fix some dashboards that were broken because of it.

Checklist

[x] I've read the guidelines and understand the acceptance criteria.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Denny Nguyen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Nodejs update to v20.x with apt

node and yarn binaries are in the PATH now:
₿ which node
/usr/bin/node
₿ which yarn
/usr/bin/yarn

affects the weUI install

Will check on the webUI repo with node 20 and report back

Webui build works with node 20  👍


Crash introduced in 0.26.2 about char boundaries

Description

When upgrading from Ratatui 0.26.1 to 0.26.2 my app started crashing when trying to display the attached file.
lorem.txt
The panic is as follows:
thread 'main' panicked at /home/fri/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.26.2/src/text/line.rs:477:59:
byte index 92 is not a char boundary; it is inside 'σ' (bytes 91..93) of `Μεα θε δισαθ φαλλι οφφισιις. Ναμ δυις ιριυρε αδ. Φασιλις σεθερος αλβυσιυς ατ μει, μελ υθ ρεπυδιαρε ασεντιορ ινσιδεριντ. Σαεπε πρωβατυς ηις αν`[...]

I'm displaying this file in a Table, where each line is a cell in the table.
I'll update this bug report with a minimal project that crashes.
Note that Ratatui 0.26.1 worked fine.
To Reproduce

Expected behavior

Screenshots

Environment

OS: Linux
Terminal Emulator: Gnome Terminal
Font: Liberation Mono
Crate version: 0.26.2
Backend: Termion

Additional context

The bug was introduced by #987 .
The #987 PR doesn't take into consideration that UTF-8 uses multi-byte characters, so it's wrong to assume that
span.content[offset as usize..span_end]

is at char boundaries.
Moreover, you also must be very carful that some chars have a width of 1, some have a width of 2, and some have a width of 0, so the truncated function introduced in that PR needs to be refactored taking those things into consideration.
cc @TadoTheMiner

Duplicate of #1032


python3Packages.transformers: 4.1.1 -> 4.2.1

Motivation for this change
Changelog:
https://github.com/huggingface/transformers/releases/tag/v4.2.0
https://github.com/huggingface/transformers/releases/tag/v4.2.1
Changes to the derivation:

Enable on Python 3.9.
Disable checks and use pythonImportsCheck instead. The list of
excluded tests was getting silly. The vast majority of tests
require internet access (to download models). I guess at this
point we just have to accept that it is not practical to run
the tests.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109505 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

python37Packages.transformers: log https://termbin.com/tfq0
python38Packages.transformers: log was empty
python39Packages.transformers: log was empty

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109505 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

python37Packages.transformers: log https://termbin.com/tfq0
python38Packages.transformers: log was empty
python39Packages.transformers: log was empty

@SuperSandro2000 thanks! Python 3.7 should be fixed now, 3.8 and 3.9 build fine here.

@SuperSandro2000 thanks! Python 3.7 should be fixed now, 3.8 and 3.9 build fine here.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109505 run on x86_64-linux 1

1 package failed to build and are new build failure:

python37Packages.transformers: log https://termbin.com/a6j4

2 packages built:

python38Packages.transformers
python39Packages.transformers

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109505 run on x86_64-linux 1

1 package failed to build and are new build failure:

python37Packages.transformers: log https://termbin.com/a6j4

2 packages built:

python38Packages.transformers
python39Packages.transformers

@ofborg build python37Packages.transformers  python38Packages.transformers  python39Packages.transformers

@ofborg build python37Packages.transformers  python38Packages.transformers  python39Packages.transformers

@SuperSandro2000 cannot reproduce locally and ofborg is also happy.

@SuperSandro2000 cannot reproduce locally and ofborg is also happy.


GG-10603 - DR: unmarshal GridCacheRawVersionedEntry key and value upo…

…n request. Fix.

Closing test only PR. Feel free to reopen if needed.


Use of react-google-maps-loader (compatibility with other plugins)

Currently I have issues running google-map-react with https://github.com/cedricdelpoux/react-google-places-suggest/.
If google-map-react is loaded after react-google-places-suggest everything is OK. But when google-map-react is loaded first, I'm getting errors from react-google-places-suggest.
I believe it's because there are two google maps loader in place.
There is project https://github.com/cedricdelpoux/react-google-maps-loader which react-google-places-suggest  is using.
Can google-map-react switch to react-google-maps-loader. I believe it will make it more compatible with other plugins

I use my loader not only in current project.
I use it even inside redux middlwares, my loader does not need the react at all.
So answer is - I will not use react-google-maps-loader
Also there are no popular projects using react-google-maps-loader, so about what compatibility are you saying?

Also you can attach any loader with same interface as internal - see  googleMapLoader props

@istarkov

there are no popular projects using react-google-maps-loader, so about what compatibility are you saying?

true, there is probably only those written by same guy. Anyway the current situation with different google api loaders kinda sucks and if you want to use different libraries, you're outta luck.

As I said u can use his loader, I have a public interface for this. All u need is to convert gmap api result into promise.

Also if there will be good gmap loader (without react deps), I will use it.


Leap Motion control of Sigma.Js graph

You've probably heard of Leap Motion – 3D gesture-control interface that is on sale at any Fnac in Paris these days for like 60 eur.
Well, they have that library Leap.Js, which basically enables you to control any Canvas element using your hand gestures in the air.
So of course I wanted to try it on Sigma graphs and it's so good! Minority Report embodied.
Just add the following code to any Sigma visualization and see how well it works!
// Include the Leap.Js library
<script src="//js.leapmotion.com/leap-0.4.1.js"></script>

// Add this code below to control your Sigma instance using LEAP (s in this case)

var controller = new Leap.Controller({enableGestures: true});
var firstValidFrame = null;

// Avoid visual feedback loop :)
var defaultRatio = s.cameras[0].ratio;

controller.loop(function(frame) {
       if (!firstValidFrame && frame.valid) firstValidFrame = frame;
       var translation = frame.translation(firstValidFrame);

       // Here is the code for controlling Sigma default camera view

       // This will move the graph horizontally with your hand swipe in the air
       s.cameras[0].x = -translation[0];

       // This will move the graph up and down with your hand swipe in the air
       s.cameras[0].y = translation[1];

       // This will zoom in if you move your hand towards the screen and zoom out if you move away
       s.cameras[0].ratio = defaultRatio + (translation[2]/360);

       });
  }
);

My only problem was that it only worked when ForceAtlas2 was running. If I use stopForceAtlas2, then none of that works for some reason. Any help would be appreciated. If you want me to demo it and you are in Paris, just let me know :)

@deemeetree can I have your email?

@bastiankhalil it’s dmitry att noduslabs dott com


rfb: adds checks for rules with secresult being an integer keyword

Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6723

https://github.com/OISF/suricata-verify/pull/1983 + new commit

Replaced by https://github.com/OISF/suricata-verify/pull/1986


some array techniques implemented in this code.

Array:
sorting (both descending and ascending order)
reversal in array
random sorting and others

Check indentations
Use a linting to tool to check for lint errors
Avoid trailing line spaces (after or in-between line of codes)
You practiced the use of semi-colons, that's very good job.

The output of your code is not sorting...
It returns the order of the array just as it was passed.
No ascending or descending order applying.


fix: docs first3

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @jonasspinner !


Switch to purescript v0.15

Parts of the changelog that may affect us:

Switch from Common JS to ES modules (https://github.com/purescript/purescript/pull/4232)
Remove purs bundle (https://github.com/purescript/purescript/pull/4255)

+1

#1414  has more context


Hero Styling

Make the hero section look more like the image below.
Use font-size and color variables provided in global.css
Make the image stack on top at sm breakpoint as in 2nd image below.

i can do it please assign me the task

I have corrected it but unable to push even after reading your terms in the readme section please help

@qwerty-rgb maybe you can show what's going on in the discord channel keiko-corp. Not sure how to really help you without more info. I will assign you this task for 24 hours, then open it back up.

Hey @brittneypostma  I am ready with changes feel free to mention me in the comment will raise the Pull Request for the same

If s/he unable to complete the task, assign it to me. @brittneypostma

I can do this task

@KryptonBD you may try this now as well.


Not Able to Format Date in different format in the latest version

I have tried to format the date in the latest version no. 3.2.0-rc1
Not possible to change the time format from<PHONE_NUMBER>) epoch on the x-Axis
Example for 1 day -- 9:30 AM, 11:05 AM ...
for 1 week -- 19 Jan, 18 Jan, 15 Jan ...
for 1 Month -- Jan20, Dec19 , Nov19 , ...
for 1 year -- Feb2020 , May2020 , Jul2020 ...
for 5 year -- 2020, 2019, 2018 ....
Kindly Suggest

Hi! You should set tickMarkFormatter for the chart.
The parameter tickMarkFormatter is defined as plugin. So you should pass the object inherited from Plugin class. The most easiest way is to use Eval class.
It could be something like that:
chartApi.applyOptions {
    timeScale = timeScaleOptions {
        tickMarkFormatter = Eval("""
            function(time, tickMarkType, locale) {
                let timeMillis = time * 1000;
                let nowMillis = Date.now();
                let diff = nowMillis - timeMillis;

                console.log("timeMillis:", timeMillis);
                console.log("nowMillis:", nowMillis);
                console.log("diff:", diff);

                if (diff < 86400000) {
                    //format timestamp
                    return "9:30 AM";
                }

                if (diff < 86400000 * 7) {
                    //format timestamp
                    return "19 Jan";
                }

                if (diff < 86400000 * 30) {
                    //format timestamp
                    return "Jan20";
                }

                //format timestamp
                return "Feb2020";
            }
        """.trimIndent())
    }
}

Hi! You should set tickMarkFormatter for the chart.
The parameter tickMarkFormatter is defined as plugin. So you should pass the object inherited from Plugin class. The most easiest way is to use Eval class.
It could be something like that:
chartApi.applyOptions {
    timeScale = timeScaleOptions {
        tickMarkFormatter = Eval("""
            function(time, tickMarkType, locale) {
                let timeMillis = time * 1000;
                let nowMillis = Date.now();
                let diff = nowMillis - timeMillis;

                console.log("timeMillis:", timeMillis);
                console.log("nowMillis:", nowMillis);
                console.log("diff:", diff);

                if (diff < 86400000) {
                    //format timestamp
                    return "9:30 AM";
                }

                if (diff < 86400000 * 7) {
                    //format timestamp
                    return "19 Jan";
                }

                if (diff < 86400000 * 30) {
                    //format timestamp
                    return "Jan20";
                }

                //format timestamp
                return "Feb2020";
            }
        """.trimIndent())
    }
}


fix nginx ingress host

Potentially fixes issue #1706, where the nginx ingress host is set using domain:port which does not work.
This is a backport of #1710 for the release-0.6.2 branch.

Codecov Report

Merging #1709 into release-0.6.2 will increase coverage by 0.13%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           release-0.6.2    #1709      +/-   ##
=================================================
+ Coverage          29.08%   29.22%   +0.13%
=================================================
  Files                 92       92
  Lines               6659     6659
=================================================
+ Hits                1937     1946       +9
+ Misses              4464     4457       -7
+ Partials             258      256       -2

Impacted Files
Coverage Δ

distributor/cmd/main.go
58.88% <0.00%> (+1.11%)
:arrow_up:

api/ws/hub.go
76.78% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0643092...785e687. Read the comment docs.


Fix isort config

Forgot to add black to isort's config

Just read up on [this](https://pycqa.github.io/isort/docs/configuration/black_compatibility.html_ to get up to speed. Great find! I apologize for not catching this earlier.


[ <Craft_Log>]

Describe the bug
When you open the default WoW UI and select a recipe (i.e. Algari Healing Potion), then switch to TSM and make any change to the recipe, the change won't be reflected in CraftSim. Also true if default TSM craft is not all quality 1 reagents.
To Reproduce
Steps to reproduce the behavior:

Open the WoW Crafting Interface
Select a recipe
Open TSM and select the same recipe
Make TSM settings anything but base recipe (all 1* reagents)
Craft
Craft_Log shows that recipe was made using all 1* reagents

Expected behavior
Craft_Log should show the correct reagents used as shown in TSM.
Addon Version: [19.7.3]

phew thats a hard one.
Id rather state its not supported than try to solve that cause it might not even solveable due to how tsm selects a recipe
With default ui all those data points are available for other addons but addons like TSM make their inner code/runtime data inaccessible for other addons and thus if they did not have a specific api for that prepared (they dont) I cannot do anything
If someone finds a solution I might be open for pull requests though


[Task]: improve Stream Schema Merge transform documentation

What needs to happen?
If two fields with the same name but a different data type are found, the Stream Schema Merge converts the unified output field to a String:
https://github.com/apache/hop/blob/c80693c4e377570f9b80fd2bf112fa5155575013/plugins/transforms/streamschemamerge/src/main/java/org/apache/hop/pipeline/transforms/streamschemamerge/SchemaMapper.java#L63
This should be reflected in the documentation:
https://hop.apache.org/manual/latest/pipeline/transforms/streamschemamerge.html
Issue Priority
Priority: 3
Issue Component
Component: Documentation, Component: Transforms

.take-issue


Error: unknown command "chart" for "helm"

Earlier our pipeline used to pass when we run the command
helm chart save "$(System.ArtifactsDirectory)/HelmChart/" xyz.azurecr.io/xyz:$version
Now the same command is throwing below error
Error: unknown command "chart" for "helm"
Can someone suggest if I am missing anything here?

I'm not familiar with the OCI details but looking at the "notable changes" section of the release notes for 3.7.0 (https://github.com/helm/helm/releases/tag/v3.7.0)
it mentions that helm chart save has been replaced by helm package, as well as listing the other changes to the old helm chart command.
I hope this helps.

Thanks, @marckhouzam for the release notes. This should resolve our issue.

https://helm.sh/docs/topics/registries/#other-subcommands


Make profiles kernel and initrd version agnostic

Right now, consumers constructing profiles won't know the appropriate versions and paths to CoreOS kernels and initrd images when constructing profiles, since that version is a detail of whatever is contained in the "/assets" of bootcfg. This could be fixed by

Allowing clients to push assets to bootcfg using the RPC endpoint, or
Allowing clients to push profiles without specifying the CoreOS version (either by using a template or by simply providing the correct default)
Some other awesome solution

Currently, this requires a machine Profile author to know which CoreOS PXE images are available at some endpoint on the network. bootcfg happens to serve assets as a convenience, but kernel and initrd can point anywhere.
I'm not keen for bootcfg to become the official source for cached CoreOS images within a datacenter and would prefer a cache-proxy or CoreUpdate-like installation. So I don't think a gRPC API for pushing CoreOS images is the right fit.
Perhaps, a bootcfg deployment specifies an ASSETS_HOME which points to where CoreOS images are cached on the network. iPXE scripts generated by bootcfg can prefix the kernel and initrd in Profile definitions automatically. Some thought is required about how this should work for GRUB netboot configs and if end users are allowed to provide iPXE templates (a requested feature), in which case they're completely responsible for the contents.
This moves the choice about where images can be found from the Profile writer to the bootcfg deployer. Its still a separate responsibility to manage the set of PXE images. Concerning installs to disk, by default those are downloaded from CoreOS, so all the install images are available and any of the CoreOS PXE images will suffice

Sweet! Let's talk a bit about this when you get in!

Discussed offline - the workaround ("Just get the assets from someplace else") is simple and probably workable! Thanks again!

Yep, we discussed. bootcfg can host any assets users drop in /var/lib/bootcfg/assets, which should be used mainly for development and small clusters. In larger production datacenters, users should specify the location of mirrored CoreOS images (perhaps on some nearby file servers for network performance) or point to the publicly hosted CoreOS images. It is up to the administrator to choose the image source which is specified in Profiles.


The configured certificate seems to be ignored

First and foremost, thank you for creating this useful library!
I’ve started integrating it into my project for performing on-device app receipt validation. Since I’d like to utilize StoreKit Testing in Xcode, I have to differentiate the certificate used for validation (see this section). In the README, you show a snippet for this configuration step. However, I checked the source code and noticed that the configured certificate in AppReceiptValidator.Parameters isn’t used at all. While the certificate (represented as Data) is passed to checkSignatureAuthenticity(…), the certificate that gets used is the one extracted from the receipt.
https://github.com/IdeasOnCanvas/AppReceiptValidator/blob/8cd736e038e56ed7d2d1f8f4021b0d7cc99cb8eb/Sources/AppReceiptValidator/AppReceiptValidator.swift#L152-L159
I was wondering whether there should be a check for the correct certificate. If I understand it correctly, it should now be possible to create a receipt using an arbitrary certificate, and as long as the fields are matching, the library would interpret it as valid. Is my understanding correct? What would be the recommended way to fix this?

First and foremost, thank you for creating this useful library!
much appreciated!

Oh, good catch! That looks like a bug/regression that might have crept in when moving away from OpenSSL as a dependency.
Until it's fixed, I recommend as a workaround to disable the AppReceiptValidator.Parameters.signatureValidation in DEBUG builds.
I quickly tried changing it to let rootCert: X509Certificate = try .init(data: appleRootCertificateData):
The initializer works, but the tests that verify signatures fail, so probably something with unpacking or verifying is not in line.

Until it's fixed, I recommend as a workaround to disable the AppReceiptValidator.Parameters.signatureValidation in DEBUG builds.

Thanks for the suggestion. I haven’t yet started working on the part related to StoreKit and in-app purchases, so I don’t have an urgent need for a workaround. Also, if I understand it correctly, the validation should go through even for receipts created in the Xcode StoreKit testing environment, as the certificate from the container is used anyway.

Looking at https://www.objc.io/issues/17-security/receipt-validation/ it seems we are doing the integrity check might be omitting the authenticity check.

I’m a total newbie in this field, but yeah, it looks like it. Not sure how one could validate a certificate change against a root certificate, though.

@hannesoid @lukaskubanek Any update on this or can we close this issue?

As @hannesoid says, the issue is unsolved. However, while utilizing StoreKit Xcode Testing, I noticed that it actually doesn’t write receipt files, and thus there’s no need for receipt validation with a different certificate. I’m using StoreKit 2, which even comes with its own verification. So, I currently don’t have a use case for configuring the validation certificate.
Handling the authenticity part would still be desired to make the check secure. Or, if you don’t want to spend much effort on it, at least you could remove the option for configuring a custom certificate.

thanks for the update and the info on storekit testing!

you could remove the option for configuring a custom certificate.

sounds like a good idea

It seemed less complicated than I thought, I think I found a way to do the missing authenticity check, should also work with custom supplied root certificates (allthough probably not really a use case) #80


Keyclaok log_level envVar not working

as setup in the keycloak.yaml the KC_LOGLEVEL variable doesn't affect the log level

fix using the helm chart


Improving the Log Analysis notebook

This addresses the following

The plot_track function seems to be really low resolution, so the heatmap in the ‘Analyze the reward distribution for your reward function’ block is showing the heat centers only centered on whole numbers, like (2,3) or (4,0).  I’d modified the plot_track in my version (https://github.com/barberd/aws-deepracer-workshops/blob/d1bb8296d60e2fdb98e69734ca8062ab654bf386/log-analysis/DeepRacer Log Analysis.ipynb) to not do this.

The track selected is now reInvent2019_track (in the ‘Load waypoints for the track you want to run analysis on’ block) but the track segments as defined in the track_segments variable in the ‘Action breakdown per iteration and historgram for action distribution for each of the turns - reinvent track’ block have not been updated to match

In the same block ‘Action breakdown per iteration and historgram for action distribution for each of the turns - reinvent track’ the line for ax.text() adds ‘+20’ to the y-coordinate.  This seems to not be needed and just makes all the labelsway off from where they should be.

Same block, the action list doesn’t really make sense.  Its currently set to ['LEFT', 'RIGHT', 'STRAIGHT', 'SLIGHT LEFT', 'SLIGHT RIGHT', 'SLOW'] which is 6 actions, but the ‘original deepracer’ has 9 nodes in its action space. The only way to get 6 nodes in the garage is a steering granularity of 3 and speed granularity of 2, and the action list should be more like ‘LEFT SLOW’,’LEFT FAST’,’STRAIGHT SLOW’,’STRAIGHT FAST’,’RIGHT SLOW’,’RIGHT FAST’ if this was selected. (I did not fix this in my notebook)

The other changes made on top of barberd code

The ‘Download all the checkpoints (provided as an example)’ block no longer works. The s3_bucket and s3_prefix variables aren’t set anymore, and moreover, this technique no longer works after DeepRacer’s new service model changes. This shouldbe modified to use the new API for get_asset_url such as done in my notebook, https://github.com/barberd/aws-deepracer-workshops/blob/d1bb8296d60e2fdb98e69734ca8062ab654bf386/log-analysis/DeepRacer Log Analysis.ipynb (with box renamed to ‘Download and extract the trained model’)

The ‘Evaluation Run Analyis’ is still relying on the old ‘simulation_name’ variable to grab from robomaker, which is nolonger accessible after the new service model.  This section should either be modified to use the get_asset_url API such as my notebook does, or should be eliminated entirely.  It seems the intent is the latter as I noticed the is_training Boolean up in the ‘Jobs run from AWS DeepRacer Console. Download the desired log file by providing model name’ block.

Training metrics and evaluation metric graphs which the internal team used for analysing whether the training job has converged or some more training will help the job to converge. Along with percentage completion

Thanks sunil19m!


cactbot stopped working today

I started to use cacbot yesterday, I was doing Endsinger Extreme, no issues, all sound + commands where on point and great experience.
Today I went back to home, launched FF XIV, launched ACT, changed nothing - it doesn't work anymore. On Endsinger Extreme it would only show upcoming attack timers, but not anymore sound or written commands on screen like "Spread/Stack/Northwest etc.". On some bosses like on P4N it doesn't show anything at all.
At summer farm /countdown 5 - everything works during testing.
I tried to update but there is not update it seems available. I haven't touched anything in settings since yesterday so I have no idea why it stopped working all of the sudden.

Every time there is a new patch to download, the ffxiv plugin needs to be updated and this breaks all other plugins until it is fixed.  When you install the new version when it is out it should continue working again.


[doc] Replace square brackets with parens for hyperlinking.

Thanks @benrimmington for pointing this out in #30418.

@swift-ci please smoke test and merge


replace AbstractSciMLLinearOperator with trait islinear(L)

because things like FunctionOperator((u,p,t) -> A*u) may not be <: AbstractSciMLLinearOperator


WIP - Update addons to latest version

This is a draft PR and still WIP, regression testings required.
Next steps:

E2E parallel testings across all examples to verify addons are still deployed and destroyed properly
Sanity manual integration testings across addons to ensure functionality is still working as expected.

What does this PR do?

Update all addons to latest released version

Motivation

This industry moves fast. Addons contributors fixing bugs, adding features, resolving security concerns and more! we need to keep things updated.

More

[ ] Yes, I have tested the PR using my local account setup  (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

Additional changes pushed to the branch:

Set cluster version to 1.22
Pushed fix for self-managed node example, helm provider is missing and without it example is failing

Error: Kubernetes cluster unreachable: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

What I noticed so far by testings our e2e parallel with the above changes:

We are currently using single terraform apply & destroy command , this leads to timeout failures due to addons hitting timeout, this mainly caused because worker nodes and addons are created in parallel by terraform, but it can take around 10-15 minutes for worker nodes to be created and join the cluster, and until then addons will be hanging with "Creating" state.
Ideally, addons should be start be in status "Creating" only after worker nodes (AKA blueprints module) completed successfully, bringing back -target to the E2E may be the right idea.
Self-managed addon failing as called out above, this is probably true also to current main branch and this PR also fixing this for now.
Karpenter example is failing due to destroy issue with NTH eventbridge rules, where rules cant be created because there are associated targets...diving deep into this issue I figured out that the targets are not related to the karpenter example but other example, which lead me to see that we're currently creating the same event rules names, so this means if I have 2 clusters that have enabled NTH, the event bridge rules will get mixed and TF won't know about it (there's no failures like "This event rule name already exists" it seems).
A suggestion would be to give the event rule a unique name, e.g. keeping same names with postfix of the cluster name.
Changes has not been done to this yet.

link to E2E workflows: https://github.com/aws-ia/terraform-aws-eks-blueprints/actions/runs/2512350932 (note failures re-ran).
So far I have no identified any "sanity" failures (i.e. terraform apply and destroy works) related to 1.22 or addons with latest version.

@Zvikan This code has inspired me a lot, thanks. If I make it work with GitHub Actions, I need to install the AWS CLI first, right?


Feature Request: Allow triggers off of environment for AutoPlugins

See: pfn/android-sdk-plugin#65
@jsuereth wrote:

Yes, right now you want users to trigger off other plugins. You can open an feature request about having a trigger also be some kind of environment variable (like existence of a file). As long as you appropriately declare dependency settings, that's something we might be able to support, but I'd have to think through the ramifications.

I am closing this due to inactivity, but if this is still relevant let us know with more details (reproduction steps etc).


add PopupCloseBehavior

This PR adds PopupCloseBehavior to improve state of the https://github.com/emilk/egui/issues/4607
PopupCloseBehavior determines when popup will be closed.

CloseOnClick popup will be closed if the click happens anywhere even in the popup's body
CloseOnClickAway popup will be closed if the click happens somewhere else but in the popup's body.

It also adds a test in the demo app which contains several popups examples.

My ideas about https://github.com/emilk/egui/issues/4607 is to make every tooltip and popup a menu. So it will provide more control over popups and tooltips (you will be able to close a popup by calling something similar to the ui.close_menu if you need to). You won't need to manually handle it's opening. And also will allow to have multiple popups opened. That means you can have a popup inside a popup. And it will also lead to the easier creation of the popups. (should we create a tracking issue to track changes because to me it seems like a huge amount of changes to be done?)

Improvements on https://github.com/emilk/egui/issues/4607

CI is red though

@emilk I fixed the doc test so now everything should be fine


Kay retriever

Description: Adding retrievers for kay.ai and SEC filings powered by Kay and Cybersyn. Kay provides context as a service: it's an API built for RAG.
Issue: N/A
Dependencies: Just added a dep to the kay package
Tag maintainer: @baskaryan @hwchase17 Discussed in slack
Twtter handle: @vishalrohra_

Sorry for the delay @baskaryan. As discussed offline I left two notebooks + 1 retriever for Kay


issue #157

Fixes a dynamic import bug that was failing intermittently, as suggested by @lookis.

https://github.com/Jonghakseo/chrome-extension-boilerplate-react-vite/issues/157#issuecomment-1754429808

@Jonghakseo Your module preload break the app.

@PatrykKuniczak
please update vite >= 3.2

@PatrykKuniczak
please update vite >= 3.2

Yeah, my bad i get this package on rebase, but IDN why i'm don't run 'npm i' thanks 😁


DTS E2E tests fail on choosing firmware version

Device
QEMU
RTE version
N/A
OSFV version
develop
Affected component(s) or functionality
No response
Brief summary
The DTS E2E tests fail to choose the firmware version when deploying Dasharo.
How reproducible
No response
How to reproduce
Run any test from the E2E suite that deploys Dasharo.
robot -L TRACE -v config:qemu -v rte_ip:<IP_ADDRESS> -v snipeit:no \
          -v dpp_password:$DPP_PASSWORD -v dpp_download_key:$MSI_DOWNLOAD \
          -v dpp_logs_key:$MSI_LOGS -v boot_dts_from_ipxe_shell:True \
          -v dts_ipxe_link:http://${ip_addr}:4321/dts.ipxe \
          -t "E2E003.005*" dts/dts-e2e.robot

Expected behavior
PASS
Actual behavior
E2E003.005 MSI PRO Z690-A DDR-4 initial deployment (legacy -> Core... | FAIL |
No match found for 'Does it match your actual specification? (Y|n)' in 30 seconds. Output:
Please, select Dasharo firmware version to install:
c) Community version
d
d) DPP version (coreboot + UEFI)
b) Back to main menu
Enter an option:
Subscription version (cooreboot + EDK2) selected
Link to screenshots or logs
The logs only are available internally, as they contain DPP secrets.
Additional context
No response
Solutions you've tried
No response

@PLangowski You should add more information to your issues like on what branch/commit it happened. And if there was anything special that might've resulted in those tests failing you should mention it too. It would help with reproducing this error.
For example this test failed in meta-dts CI but new run resulted in different failure: https://github.com/Dasharo/meta-dts/actions/runs/12244842409/job/34159330927
E2E003.001 MSI PRO Z690-A DDR4 initial deployment (legacy -> Coreb... | PASS |
E2E003.002 MSI PRO Z690-A initial deployment (legacy -> Coreboot +... | PASS |
E2E003.003 MSI PRO Z690-A DDR-4 initial deployment (legacy -> Core... | PASS |
E2E003.004 MSI PRO Z690-A initial deployment (legacy -> Coreboot +... | PASS |
E2E003.005 MSI PRO Z690-A DDR-4 initial deployment (legacy -> Core... | PASS |
E2E003.006 MSI PRO Z690-A initial deployment (legacy -> Coreboot +... | PASS |
E2E003.007 MSI PRO Z690-A DDR-4 update (Coreboot + UEFI -> Coreboo... | PASS |
E2E003.008 MSI PRO Z690-A update (Coreboot + UEFI -> Coreboot + UE... | PASS |
E2E003.009 MSI PRO Z690-A DDR-4 update (Coreboot + UEFI -> Coreboo... | PASS |
E2E003.010 MSI PRO Z690-A update (Coreboot + UEFI -> Coreboot + UE... | PASS |
Dts-E2E                                                               | PASS |
E2E003.011 MSI PRO Z690-A DDR4 transition (Coreboot + UEFI -> head... | PASS |
E2E003.012 MSI PRO Z690-A DDR4 transition (Coreboot + UEFI -> head... | PASS |
E2E003.013 MSI PRO Z690-A transition (UEFI -> heads) - without cre... | PASS |
E2E003.014 MSI PRO Z690-A transition (UEFI -> heads) - with creden... | PASS |
Dts-E2E                                                               | PASS |
E2E004.001 Dell OptiPlex 7010 DPP initial deployment (legacy -> Co... | PASS |
E2E004.002 Dell Optiplex 7010 DPP initial deployment (legacy -> Co... | PASS |
E2E004.003 Dell Optiplex 7010 DPP update (Coreboot + UEFI -> Coreb... | PASS |
E2E004.004 Dell Optiplex 7010 DPP update (Coreboot + UEFI -> Coreb... | PASS |
E2E004.005 Dell OptiPlex 9010 DPP initial deployment (legacy -> Co... | PASS |
E2E004.006 Dell Optiplex 9010 DPP initial deployment (legacy -> Co... | PASS |
E2E004.007 Dell Optiplex 9010 DPP update (Coreboot + UEFI -> Coreb... | PASS |
E2E004.008 Dell Optiplex 9010 DPP update (Coreboot + UEFI -> Coreb... | PASS |
Dts-E2E                                                               | PASS |
E2E002.001 NCM NV4XMB,ME,MZ initial deployment (legacy -> Coreboot... | PASS |
E2E002.002 NCM NS50_70MU initial deployment (legacy -> Coreboot + ... | PASS |
E2E002.003 NCM NS5x_NS7xPU initial deployment (legacy -> Coreboot ... | PASS |
E2E002.004 NCM NV4xPZ initial deployment (legacy -> Coreboot + UEF... | PASS |
E2E002.005 NCM NV4xPZ transition (Coreboot + UEFI -> Coreboot + He... | PASS |
E2E002.006 NCM transition NV4xPZ (Coreboot + UEFI -> Heads) - DPP ... | FAIL |
E2E002.007 NCM V540_6x_TU initial deployment (legacy -> Coreboot +... | PASS |
E2E002.008 NCM V560_6x_TU initial deployment (legacy -> Coreboot +... | PASS |
E2E002.009 NCM V540TNC_TND_TNE initial deployment (legacy -> Coreb... | PASS |
E2E002.010 NCM V560TNC_TND_TNE initial deployment (legacy -> Coreb... | PASS |
Dts-E2E                                                               | FAIL |

And from what I can see there were no changes to workflow or tests. So failure might've happened due to timing issue (e.g. waiting some arbitrary amount of time instead of waiting for expected output).
Full error with failing test:
------------------------------------------------------------------------------
E2E002.006 NCM transition NV4xPZ (Coreboot + UEFI -> Heads) - DPP ... | FAIL |
No match found for 'If you did not buy any DPP
packages - feel free to continue.
Press Enter to continue' in 30 seconds. Output:
Enter logs key:                ********

Enter firmware download key:

Enter password:                *****
Dasharo DPP credentials have been saved
Checking for Dasharo firmware...
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
Waiting for network connection ...
Network connection have been established!
/usr/sbin/dts-subscription.sh: line 60: [: -eq: unary operator expected
Something may be wrong with the DPP credentials or you may not
have access to Dasharo Firmware. If so, consider getting Dasharo
Subscription and improving security of your platform!
Press Enter to continue.
------------------------------------------------------------------------------

@PLangowski I try to but I cannot reproduce this issue on:  dts 2.1.2 (commit 86fd10102a3b0c0c9adb652dbbd67efbf7ddc5c0) + patch:
diff --git a/meta-dts-distro/recipes-dts/dts-scripts/dts-scripts_git.bb b/meta-dts-distro/recipes-dts/dts-scripts/dts-scripts_git.bb
index bd9efa05be39..df0b1c35b104 100644
--- a/meta-dts-distro/recipes-dts/dts-scripts/dts-scripts_git.bb
+++ b/meta-dts-distro/recipes-dts/dts-scripts/dts-scripts_git.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://LICENSES/Apache-2.0.txt;md5=c846ebb396f8b174b10ded477

 PV = "0.1+git${SRCPV}"

-SRC_URI = "git://github.com/Dasharo/dts-scripts;protocol=https;branch=main"
+SRC_URI = "git://github.com/Dasharo/dts-scripts;protocol=https;branch=fix-check-for-dasharo-firmware"
 SRCREV = "27df8825c68d6a356188e51e8bdff0428aa0ae89"

 S = "${WORKDIR}/git"

@EduKav1813, any results from tests you are basing your answer here? Check out how Michał presented the results.


Can't play GIF with .backgroundDecode option

Here's how I use it.
previewImage.clipsToBounds = true
previewImage.kf.indicatorType = .custom(indicator: indicator)
previewImage.kf.setImage(with: url, options: [.transition(.fade(0.2)), .backgroundDecode], progressBlock: {
    receivedSize, totalSize in

    // from cache
    if totalSize < 0 {
        indicator.level = 10000.0
    }
    else{
        indicator.level = CGFloat( (Float(receivedSize) / Float(totalSize)) * 10000.0 )
    }
})

The GIF is played well without .backgroundDecode.

@KimiChiu
There is AnimatedImageView that can play gif, can you use it?

I tried, it worked the same as UIImage. Both of them need to remove .backgroundDecode.

@jzau so at least, how did you resolve this problem, i have faced some issue with you.

Normally I thinks we don't need to decode GIF with .backgroundDecode option when you use AnimatedImageView to display. AnimatedImageView will preload and resize(if needsPrescaling is true, default is true) frame in a serial queue, it will decode the frame into bitmap while resizing.


Ref #1100 (substituted from #774) Parameterizing StaticInfo in pages/index.vue

📝 関連する issue / Related Issues

#1100
#774

⛏ 変更内容 / Details of Changes

The attribute values of StaticInfo have been moved into <script></script> block in pages/index.vue
This aims to raise readability of Vue codes for future maintenance activities

📸 スクリーンショット / Screenshots
No style changes are intended i.e. users must be enabled to see the page as if no change took place on it before/after this PR

Once closed - see #1100 for details.


[MARLIN-496] fetch Organization using oauth_keys instead of oauth_token

The field 'encrypted_oauth_token' will always be nil as we now store the full oauth token: https://github.com/maestrano/marlin-banking-adapter/pull/2/commits/08b255b411f8b690b6e288b7b4956fb64478bc0d

changed the query to use encrypted_oauth_keys,
changed the specs
added migration, changed schema for specs

This should be done on the marlin-banking connector. See JIRA


Add ORGANIZATION-Layer to keys-directory to group certificates

Rework of Root-CA
Rework of Intermediate-CA
Rework of User Enrollment

Done with others


Can't find babelify module

ionic-conference-app git:(master) ionic serve
Running 'serve:before' gulp task before serve
[00:31:20] Starting 'clean'...
[00:31:20] Finished 'clean' after 8.48 ms
[00:31:20] Starting 'watch'...
[00:31:20] Starting 'sass'...
[00:31:20] Starting 'html'...
[00:31:20] Starting 'fonts'...
[00:31:20] Starting 'scripts'...
[00:31:20] Finished 'scripts' after 64 ms
[00:31:20] Finished 'html' after 90 ms
[00:31:20] Finished 'fonts' after 89 ms
[00:31:21] Finished 'sass' after 1.28 s
✗ Caught exception:
Error: Cannot find module 'babelify' from '/Users/flama/Projects/ionic-conference-app'
at /Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
at process (/Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
at ondir (/Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
at load (/Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
at onex (/Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
at /Users/flama/Projects/ionic-conference-app/node_modules/ionic-gulp-browserify-es2015/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
at FSReqWrap.oncomplete (fs.js:82:15)
Mind letting us know? https://github.com/driftyco/ionic-cli/issues

More than likely, you need to update NPM which will include the babelify dependancies.  See Issue #180 Check your version of NPM by running npm -v , it should be v3.x. Run  sudo npm install -g npm  to update npm. and you should be good to go.

Thanks @jbraun27


How about .pdf support ?

Hi, in your tags you have one its "invoice-pdf". But in your documentation i didnt see you are talking about pdf print...

Yeah, sorry. I remove the tag.
You can convert jpg to pdf via imagick library

ok thanks for your answer


Make BlockGasLimit configurable

Add configuration entry
A new configuration entry has been added to the State config section.
If not specified, it default to const.DefaultBlockGasLimit
Fix configuration loader

Remove Registry initialization from cfg.Load method. That was overriding the default values set by init method
Add test to check default values

Resolves #1418
Resolves #1419

Codecov Report

Merging #1420 (e27de8c) into master (828364b) will decrease coverage by 9.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   50.51%   41.24%   -9.28%
==========================================
  Files         145      144       -1
  Lines        7544     9453    +1909
==========================================
+ Hits         3811     3899      +88
- Misses       3066     4922    +1856
+ Partials      667      632      -35

Impacted Files
Coverage Δ

pkg/core/consensus/testing/node.go
0.00% <0.00%> (-93.55%)
:arrow_down:

...ore/consensus/blockgenerator/candidate/testutil.go
0.00% <0.00%> (-90.91%)
:arrow_down:

pkg/core/consensus/testing/utils.go
0.00% <0.00%> (-75.61%)
:arrow_down:

...core/consensus/blockgenerator/candidate/genesis.go
0.00% <0.00%> (-69.24%)
:arrow_down:

...nsensus/blockgenerator/candidate/blockgenerator.go
0.00% <0.00%> (-64.29%)
:arrow_down:

pkg/gql/query/transactions.go
13.43% <0.00%> (-52.55%)
:arrow_down:

pkg/rpc/client/session.go
21.42% <0.00%> (-47.15%)
:arrow_down:

pkg/util/nativeutils/eventbus/eventbus.go
57.14% <0.00%> (-42.86%)
:arrow_down:

pkg/rpc/client/client.go
3.73% <0.00%> (-36.61%)
:arrow_down:

pkg/core/consensus/reduction/aggregator.go
56.25% <0.00%> (-35.06%)
:arrow_down:

... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0622748...e27de8c. Read the comment docs.


Fix Swagger Correctness and Linting Issues for Microsoft.AAD/DomainServices

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[x] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Little concern when authoring CLI
Shall migrationProperties under domainserviceProperties be marked as read-only?
definition code:
    "DomainServiceProperties": {
      "description": "Properties of the Domain Service.",
      "properties": {
        ...
        "migrationProperties": {
          "$ref": "#/definitions/MigrationProperties",
          "description": "Migration Properties"
        },
        ...
      }
    },
    ...
    "MigrationProperties": {
      "description": "Migration Properties",
      "properties": {
        "oldSubnetId": {
          "type": "string",
          "description": "Old Subnet Id"
        },
        "oldVnetSiteId": {
          "type": "string",
          "description": "Old Vnet Site Id"
        },
        "migrationProgress": {
          "$ref": "#/definitions/MigrationProgress",
          "description": "Migration Progress"
        }
      }
    },
    "MigrationProgress": {
      "description": "Migration Progress",
      "properties": {
        "completionPercentage": {
          "type": "number",
          "format": "double",
          "description": "Completion Percentage"
        },
        "progressMessage": {
          "type": "string",
          "description": "Progress Message"
        }
      }
    },

It seems not some property which can be set or modified by any PUT operation.

Both of these are not readonly properties.

Little concern when authoring CLI
Shall migrationProperties under domainserviceProperties be marked as read-only?
definition code:
    "DomainServiceProperties": {
      "description": "Properties of the Domain Service.",
      "properties": {
        ...
        "migrationProperties": {
          "$ref": "#/definitions/MigrationProperties",
          "description": "Migration Properties"
        },
        ...
      }
    },
    ...
    "MigrationProperties": {
      "description": "Migration Properties",
      "properties": {
        "oldSubnetId": {
          "type": "string",
          "description": "Old Subnet Id"
        },
        "oldVnetSiteId": {
          "type": "string",
          "description": "Old Vnet Site Id"
        },
        "migrationProgress": {
          "$ref": "#/definitions/MigrationProgress",
          "description": "Migration Progress"
        }
      }
    },
    "MigrationProgress": {
      "description": "Migration Progress",
      "properties": {
        "completionPercentage": {
          "type": "number",
          "format": "double",
          "description": "Completion Percentage"
        },
        "progressMessage": {
          "type": "string",
          "description": "Progress Message"
        }
      }
    },

It seems not some property which can be set or modified by any PUT operation.

Both of these are not readonly properties.

I think migrationProperties should be marked as readonly. Let me make that change here.

@jihochang
You seems to be waiting for reviewers. Ping me when you need this merged.

@weidongxu-microsoft Could we get this PR merged? Additional requests by @evelyn-ys will be in a seperate PR.

@evelyn-ys it doesn't seem that there was ever a follow up PR to fix the resourceForest issue... Is this property documented anywhere? What are the allowed / expected values?


Fixed getting-started links

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, already submitted as https://github.com/espressif/esp-idf/pull/561.


ENH: signal: complete example

Added an example and renamed the modulation (cyclic) frequency from fc to alpha, which is the standard naming (see https://en.wikipedia.org/wiki/Spectral_correlation_density)

Reference issue

What does this implement/fix?

Additional information

Thanks @gideonKogan for this contribution.
Can you give more explanation about figure displayed by your example?

@qbarthelemy , I have improved the example clarity and added some additional protection against aliasing. All the modifications are detailed here. Please tell me what is the best way to merge the pull requests.
The example should demonstrate that the suggested function allows the decomposition of components based on both the modulation and carrier frequencies.
Please mind that I have also added additional protection against aliasing, discussed here

Thx @ggkogan!
I have merged your contributions into the branch in pull-request towards scipy.


deref on Box<str>

reposted:

I have this code, it does not compile. I am trying to deeply match a Box inside of a pattern, but the error is:
expected str, found `&str`

but there's no good way to match Box in a deeply nested pattern...
#![feature(box_patterns)]
struct Type {
    pub name: Box<str>,
    pub generics: Option<Vec<Type>>
}

fn main(){
    let kind = Type {
        name: "User".into(),
        generics: Some(Vec::new())
    };

    match kind {
        Type {
            name: box "User",
            generics
        } => {}
        _ => unimplemented!()
    }
}

Is there any kind of proposal to address the deref for this specific case?

Box is planned to be covered by the initial version of deref patterns, regardless of the inner type.

Great to hear. Can't wait for this feature. Any idea as to how long this process usually takes?


feat: WIP generate insomnia-inso docs from source

Add a script that generates the reference docs for insomnia-inso from the source code. Commander exposes commands, options and descriptions which we can use to generate the markdown files.
This is a WIP to start a convo and an initial implementation, the script doesn't work as it is because cli.ts doesn't export program and version. I've tested it locally by copying the program variable into the file and removing the action from each command. I've tried exporting the variables, but got a weird error : ERROR: No loader is configured for ".node"....
It generates a folder at the root reference/insomnia-inso/<version>/, with an index.md file and one file for each command (+subcommands).
There are a few things to consider:

relative links in the generated markdown files
figure out a way to include examples in the markdown files, e.g. we could use program.addHelpText('afterAll',

The end goal would be to have a github action that runs this script and opens a PR against the insomnia-docs repo (where the generated files should live).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Gremlin to neptune ES converter

Hi there,
I have a query that uses textContains, Ex:
{"gremlin":"g.V().has('props:category_simple',textContains('Project')).limit(5).toList()"}
I understand that to make this type of query, elastic search should be called.
I have successfully streamed my data to ES.
I'm trying to execute the following query
{"gremlin":"g.withSideEffect('Neptune#fts.endpoint',
                 'https://vpc-vpc-neptunestream-XXXXXXXXXXXXX.us-east-1.es.amazonaws.com')
  .withSideEffect('Neptune#fts.queryType', 'query_string')
  .E().has('props:category_simple','Neptune#fts Project~').values('props:category_simple').limit(5)"}

but i'm getting
{     "requestId": "893187e9-793a-419b-a1db-b63ca138f395",     "code": "InvalidParameterException",     "detailedMessage": "body could not be parsed" }
I have tried with https , http, and just the plain endpoint, but I get the same error.
Is there a gremlin (Janus) to Neptune (ES) translator for text search?
Please advise.

Update:
I have run:
{"gremlin":"g.withSideEffect('Neptune#fts.endpoint', 'vpc-vpc-neptunestream-XXXXXX.us-east-1.es.amazonaws.com').V().tail(100).has('name', 'Neptune#fts mark*')"}
but got
{
    "requestId": "54cd81e9-b15f-4f44-87f3-0e3131f416dd",
    "code": "InternalFailureException",
    "detailedMessage": "An unexpected error has occurred in Neptune."
}

Im sending this to my Neptune Gremlin Endpoint. Other simple queries work.

Update:
Using https in front of ES endpoint worked.


It's not working correctly when having a navigation bar on top

Hi Sir,
As title, I'm looking into the issue now.
The titleView won't be able to hide fully if the VC has a navigation bar on top.
Any suggestion would be appreciated.

Do you have some sample code to illustrate the issue?

I'm closing this issue since I can't reproduce.


Replace jcenter with mavencentral

Replace jcenter with mavenCentral in android gradle files. JCenter will be sunset as of februari 2022.

Closed with #2


Extending Zonemaps

This PR features the introduction of  Zonemap Checks. Zonemaps checks are simply between filters used only for segment skipping. Prior to this PR, only filters that could be directly executed on the table scan (i.e.,AND filters with column/constant comparisons were pushed down to the get operator and used on segment skipping.
Optimizations to increase data-skipping opportunities:

In-clause values zonemaps check: (suggested in #1063), in-clauses are checked, and when they constitute a complete range of integers are transformed into a between filter that can be pushed down. Otherwise, zonemaps checks will be created
Transitive Filters: (suggested in #1063) If we have a filter A=6 and B < A, it will be transformed to A=6, B<6. (Only for equality comparisons on column references and constant values), allowing for B to be pushed down and applied on data skipping.
Join Key Filter Duplication: (suggested in #1063) If an inner-join has a comparison filter with a constant, on one of the tables, the filter will be duplicated to the other side as well, allowing data skipping opportunities on both join sides.

Great to see this PR!

able to verify data skipping with consecutive integers.
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
select count() from t where b in (1,2,3) ;                       / now does data skipping */

transitive;  I did not see a change in behavior with this use case:
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
select count() from t where b < 5 and d = 5;     / data skipping occurs /
Run Time: real 0.006 user 0.005948 sys 0.000000
select count() from t where b < d and d = 5;     /* no data skipping */
Run Time: real 0.608 user 0.608141 sys 0.000000

I did not observe data skipping for these 3 cross-join use cases:
select count() from t1 join t2 using (nationkey) where t2.n_name = 'Nation_1';                               / data skipping possible /
Run Time: real 0.657 user 0.657230 sys 0.000000
select count() from t1 join t2 using (nationkey) where t2.n_name in ( 'Nation_1', 'Nation_2');        /* data skipping possible /
Run Time: real 0.736 user 0.736437 sys 0.000089
select count() from t1 join t2 using (nationkey) where t2.nationkey =2 or n_name= 'Nation_2';   /* data skipping possible */
Run Time: real 0.802 user 0.802212 sys 0.000000

set-up for case 3 is here:
create temporary table t1 as select range a, length(range) nationkey from range(100000000);
create table t2 as select range  nationkey, concat('Nation_',range) n_name from range(25);
select count() from t1 join t2 using (nationkey)
where t2.n_name = 'Nation_1' and t1.nationkey =1;    / data skipping occurs /
Run Time: real 0.004 user 0.003875 sys 0.000000
select count() from t1 join t2 using (nationkey)
where t2.n_name = 'Nation_1' and t2.nationkey =1;  /* data skipping occurs with help of transitive behavior */
Run Time: real 0.003 user 0.003339 sys 0.000000

Great to see this PR!

able to verify data skipping with consecutive integers.
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
select count() from t where b in (1,2,3) ;                       / now does data skipping */

transitive;  I did not see a change in behavior with this use case:
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
select count() from t where b < 5 and d = 5;     / data skipping occurs /
Run Time: real 0.006 user 0.005948 sys 0.000000
select count() from t where b < d and d = 5;     /* no data skipping */
Run Time: real 0.608 user 0.608141 sys 0.000000

I did not observe data skipping for these 3 cross-join use cases:
select count() from t1 join t2 using (nationkey) where t2.n_name = 'Nation_1';                               / data skipping possible /
Run Time: real 0.657 user 0.657230 sys 0.000000
select count() from t1 join t2 using (nationkey) where t2.n_name in ( 'Nation_1', 'Nation_2');        /* data skipping possible /
Run Time: real 0.736 user 0.736437 sys 0.000089
select count() from t1 join t2 using (nationkey) where t2.nationkey =2 or n_name= 'Nation_2';   /* data skipping possible */
Run Time: real 0.802 user 0.802212 sys 0.000000

set-up for case 3 is here:
create temporary table t1 as select range a, length(range) nationkey from range(100000000);
create table t2 as select range  nationkey, concat('Nation_',range) n_name from range(25);
select count() from t1 join t2 using (nationkey)
where t2.n_name = 'Nation_1' and t1.nationkey =1;    / data skipping occurs /
Run Time: real 0.004 user 0.003875 sys 0.000000
select count() from t1 join t2 using (nationkey)
where t2.n_name = 'Nation_1' and t2.nationkey =1;  /* data skipping occurs with help of transitive behavior */
Run Time: real 0.003 user 0.003339 sys 0.000000

Can we relax the requirement for consecutive integers?
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
D select count() from t where b in (1,2,3) ;                       / data skipping /
┌──────────────┐
│ count_star() │
├──────────────┤
│ 1000         │
└──────────────┘
Run Time: real 0.004 user 0.003676 sys 0.000000
D select count() from t where b in (1,2,4) ;                       /* no data skipping /
┌──────────────┐
│ count_star() │
├──────────────┤
│ 9100         │
└──────────────┘
Run Time: real 0.836 user 0.836819 sys 0.000000
D select count() from t where b in (1,2,3,4) ;                       /* data skipping */
┌──────────────┐
│ count_star() │
├──────────────┤
│ 10000        │
└──────────────┘
Run Time: real 0.004 user 0.003564 sys 0.000102

Can we relax the requirement for consecutive integers?
create temporary table t as select range a, length(range) b, mod(range,10000) c, 5 d, 10000 e from range(100000000);
D select count() from t where b in (1,2,3) ;                       / data skipping /
┌──────────────┐
│ count_star() │
├──────────────┤
│ 1000         │
└──────────────┘
Run Time: real 0.004 user 0.003676 sys 0.000000
D select count() from t where b in (1,2,4) ;                       /* no data skipping /
┌──────────────┐
│ count_star() │
├──────────────┤
│ 9100         │
└──────────────┘
Run Time: real 0.836 user 0.836819 sys 0.000000
D select count() from t where b in (1,2,3,4) ;                       /* data skipping */
┌──────────────┐
│ count_star() │
├──────────────┤
│ 10000        │
└──────────────┘
Run Time: real 0.004 user 0.003564 sys 0.000102

Hey @jtommaney thanks for checking it so quickly, I'll take a look at your comments and will address them when implementing #1303
Regarding the performance difference from the in clauses, the difference is that the in (1,2,3) can be pushed down as a table scan filter, so there is a bit more going on than just skipping segments, the filter is actually executed during the table scan instead of having a filtering extra step.
When it's not sequential the filter is not pushed down to the scan since the zonemaps only do range checking. One thing that might be beneficial is to actually run the zonemaps checks as a pre-filtering step  (i.e., instead of just skipping the segments, actually filter data out of non-skipped segments while scanning) do reduce the data passed to the filters, even more, I think I'll have a go at that next week as well.
Thanks again for your analysis!

Hey @jtommaney thanks for checking it so quickly, I'll take a look at your comments and will address them when implementing #1303
Regarding the performance difference from the in clauses, the difference is that the in (1,2,3) can be pushed down as a table scan filter, so there is a bit more going on than just skipping segments, the filter is actually executed during the table scan instead of having a filtering extra step.
When it's not sequential the filter is not pushed down to the scan since the zonemaps only do range checking. One thing that might be beneficial is to actually run the zonemaps checks as a pre-filtering step  (i.e., instead of just skipping the segments, actually filter data out of non-skipped segments while scanning) do reduce the data passed to the filters, even more, I think I'll have a go at that next week as well.
Thanks again for your analysis!


iOS Typing new story doesn't work with shaped based swype keyboards

Issue Summary
Using iOS in Safari (or Edge or anything) typing only works with 1 letter at a time. Using any shape keyboards causes the content to not include any extra letters than the first letter.
I'm using SwiftKey keyboard on iOS 11.4 (iPhone 8+)
To Reproduce

Create a new content
Using SiftKey keyboard, drag your finger around to write a word (Hello).
Only the H is registered.

This behavior makes it incredibly difficult to type properly.
Technical details:

Ghost Version: 1.24.7
Node Version: -
Browser/OS: Safari, Edge iOS 11.4 (iPhone 8+)
Database: ?

@dabbers custom keyboards that inject words rather than characters are not supported on mobile, it's a known limitation with CodeMirror that powers the markdown editor. You should have more luck with the new Koenig editor but mobile support is not a focus right now so the experience may not be perfect.


About the pth file

Thanks for your team's efforts. Could you please share this weight file？

Hi there! You can find the ckpt from our table here. ("github" is the url for downloading).
https://github.com/AFeng-x/SMT?tab=readme-ov-file#main-results-on-imagenet-with-pretrained-models


payment-card-embed Doesn't work with latest Chrome version

We can fix it for this specific Chrome version by using a code transformer.

Latest version of Chrome seems to work now.


[edge-to-edge] Apply edge to edge into SessionsScreen

Issue

close #459

Overview (Required)

I applied edge to edge into SessionsScreen.
I fixed the issue that the navigation bar and buttons overlap in landscape
Extends the bounds of the TimetableScreen to allow scrolling to the bottom

Screenshot

Before
After

Looks good. Let me take a look tomorrow 🙏

This is definitely better! So I was just wondering which to use, consuming the window insets or passing the contentPadding parameter. Is there any opinion about his?

I'm wondering about that too.
Since Scaffold is strongly recommended to use inner padding (lint throws an error if you don't use), I used this.
But I think it's clearer to use Window Insets directly.
I don't really like Scaffold that does too much 😂


pytest: add latest fork parameter and exit gracefully upon an invalid fork

Requires https://github.com/danceratopz/execution-spec-tests/pull/1.
This PR builds upon https://github.com/danceratopz/execution-spec-tests/pull/1. In addition, it:

Adds a custom exception InvalidForkError to ethereum_test_forks which is used to exit a pytest session gracefully if an invalid fork name is supplied to --latest-fork.
Adds an additional line to the pytest header displayed in the console output to help inform users that they're running with an (unstable) upcoming fork, or not. Hopefully, this will help avoid confusions such as in https://github.com/ethereum/execution-spec-tests/pull/122#issue-1694510786 (I've struggled with this myself).

About 2. If --latest-fork is not specified, then the line:
Only executing fillers with stable/deployed forks: Specify an upcoming fork via --latest-fork=fork to run experimental fillers.

is displayed in the header.

Otherwise, if --latest-fork is specified:
Executing fillers up to and including FORK.

is displayed.

We could isolate this functionality in it's own small pytest plugin, if we think that our conftest.py will get too unwieldy.

I refactored the latest-fork functionality to be it's own pytest plugin (located in src/pytest_plugins/latest_fork.py). I think this helps keep the code modular and keep the pytest config in conftest.py manageable.


possible to include at least a little Scala.js stuff?

as I wrote at https://github.com/scala/bug/issues/11174 :

Actually is it still the case that you can't use Scala.JS in the community build?

We've historically been reluctant to expand the scope of the community build to include the Scala.js ecosystem, not primarily for technical reasons, but primarily because the community build already consumes a lot of engineering resources so we have to be skeptical of any further expansions of scope. But perhaps we could at least include a handful of things?

/cc @sjrd @japgolly

Isn't it well worth it? Scala.js is a major part of the scala ecosystem nowadays.

Please do. Scala.js and scala.js react plays a vital role in our tech stack.

P.S. note that we have enough capacity on our Jenkins, that isn't the issue. so if somebody in the community wants to put together a Scala.js community build config file, to be community-maintained going forward, I'd be happy to make a Jenkins job for it, assuming the dbuild issue we're hitting at #799 can be resolved (which is unclear)

@SethTisue are there any guide on how to help to add more projects to the community build? I would love to help if I can

@ngbinh yup, lots of docs in https://github.com/scala/community-builds/wiki

see Toni's remarks at
https://github.com/scala/community-builds/pull/799#issuecomment-429091848 about the technical feasibility and required effort level of this

some previous discussion on this at https://github.com/lightbend/dbuild/issues/193

it seems unlikely this will progress, unless new impetus comes from outside. I don't think the ticket needs to stay open

we ended up removing even Scala.js itself (see #1009), instead accomplishing equivalent testing here: https://github.com/scala-js/scala-js-test-scala-nightly instead
ticket on the possibility of taking that approach further: https://github.com/scala-js/scala-js-test-scala-nightly/issues/1


Add xmlrpc to dependency

xmlrpc library has been extracted as bundled gem from Ruby 2.4.
see: https://bugs.ruby-lang.org/issues/12160
So, need to add xmlrpc gem to dependencies, for Ruby 2.4 or later.
LoadError: cannot load such file -- xmlrpc/client
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `block in require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:258:in `load_dependency'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gravatar-ultimate-2.0.0/lib/gravatar/dependencies.rb:5:in `<top (required)>'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `block in require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:258:in `load_dependency'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.2/lib/active_support/dependencies.rb:292:in `require'
  /Users/michiomochi/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gravatar-ultimate-2.0.0/lib/gravatar.rb:3:in `<top (required)>'

Coverage increased (+0.5%) to 97.32% when pulling 96e61a989260f05ed09e0618d224687248142f17 on michiomochi:add-xmlrpc-dependency into 770b1deda775a040627f0336a3c97394bd1215dc on sinisterchipmunk:master.

@sinisterchipmunk please review it? 🙏

+1

Sorry I missed this for so long. Thanks for your contribution!

@sinisterchipmunk Thanks for maintaining this gem. Can you release a new version that includes this pull-request?


Use CGroup CPU usage when present

Motivation
When using CPU limits on a docker container, the CPU usage on the broker load report will result incorrect.
We're reporting the CPU usage such as:
  "cpu" : {
    "usage" : 8.130785075483013,
    "limit" : 200.0
  },

While the limit is correctly reflecting the 2 CPU limitation on the container, the usage is read from /proc/stat is referring to the all the CPUs in the host machine.
The effect of this is that the broker will appear with a lower CPU % usage and the load shedding will not be automatically triggered, even though the broker might be using the entire CPU quota allocated.
Instead, we need to read the usage from /sys/fs/cgroup/cpu/cpuacct.usage. This will work both inside and outside of a container.

/pulsarbot run-failure-checks


General flakiness with Windows C tests

concurrent_connectivity_test.exe is flaky: https://grpc-testing.appspot.com/job/gRPC_pull_requests/8739/config=dbg,language=c,platform=windows/

saw more instances of this failure:
https://grpc-testing.appspot.com/job/gRPC_master/config=dbg,language=python,platform=windows/

Also failing on portability_master: https://grpc-testing.appspot.com/job/gRPC_portability_master/2222/testReport/

h2_ssl_test.exe flakes on windows_x86_vs2015
https://grpc-testing.appspot.com/job/gRPC_portability_master/language=c,scenario=windows_x86_vs2015/2318/console


Add unique server id

To be able to handle multi-root workspaces on vscode (https://github.com/elixir-lsp/vscode-elixir-ls/pull/70) there's the need to spawn multiple language servers (one per project).
This is currently not possible because the server registers the spec command for every instance and so no more than one server can be spawned at the same time.
This PR fixes that by generating an unique id every time is initialized.
Just a couple questions, is id ok? Or maybe server_id or instance_id might be better?
Regarding testing, should I test that defp handle_request(initialize_req... sets a new id on the state?

Just a couple questions, is id ok? Or maybe server_id or instance_id might be better?

How about server_instance_id?

Regarding testing, should I test that defp handle_request(initialize_req... sets a new id on the state?

IMO not worth it, if it's broken it'll crash anyway

Thanks @lukaszsamson for the quick review, I've pushed the variable name change.
I'll squash everything as soon as everything looks good and the PR is ready to be merged.


Respect case insensitivity for regex params

Fixes #1671

The patch looks good. Can you just amend the commit message to something like fix($urlMatcherFactory): regex params should respect case-sensitivity -- that way it'll work properly with our changelog generator. Thanks!

@nateabele done!

Merged. Thanks again.


qatdeviceplugin_webhook: Extract only relevant parts for the validation

Since we currently validate only the image name and the tag,
ignore registry, vendor and extract only relevant parts.
Closes #605

Codecov Report

Merging #648 (ba18dd4) into main (0be8b23) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ba18dd4 differs from pull request most recent head 3d27f3c. Consider uploading reports for the commit 3d27f3c to get more accurate results

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   59.02%   59.02%
=======================================
  Files          32       32
  Lines        2372     2372
=======================================
  Hits         1400     1400
  Misses        890      890
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be8b23...3d27f3c. Read the comment docs.


Fail if any part fails

Currently, E3SM Diags exits successfully if the viewer is generated, not if all sets are successfully included. This pull request makes it so that E3SM Diags fails unless every part succeeds.

@golaz This addresses the issue you were running into where QBO Diags would have an error but E3SM Diags would continue on.
It appears to me that this issue only comes up when multiprocessing = True. When I was running locally without multiprocessing, it failed immediately after failing on QBO diags.
The way this pull request is set up, all diags will still run, but the final success of the exit code depends on whether or not all diags have finished without error. Specifically, it checks that all the parameters finish successfully. I tested by forcing QBO diags to fail. I don't think this will work in the more general case where one of the sets using CoreParameter fails. I can try more expansive testing (e.g., on different diags failing) if we want this to be more robust.
@chengzhuzhang Should I make an optional parameter to fail in this case or is it good to always fails in this case?

Hi Ryan, this looks good to me. Just to confirm if i understand correctly: If one of specified sets fails, the other sets still run but the new implementation raises additional error message indicates the failed sets?

@chengzhuzhang Yes, that's correct -- everything still runs and failures are listed at the end. Note that it only lists the number of failed parameters. (It's unfortunately more difficult to automatically determine which parameters fail exactly). Do you want me to make this an optional fail (i.e., user passes in parameter to fail in this case)?

@chengzhuzhang Actually I want to debug this further. Since there appears to be multiple copies of a *Parameter object created, the returned number could be misleading...

@forsyth2 The print-out is useful for trouble shooting,  but we would want to print the name of the failed set(s), so debugging will be more targeted.

@chengzhuzhang I think the only way to get the individual stack traces/errors would be to edit https://github.com/CDAT/cdp/blob/master/cdp/cdp_run.py and actually the way that is implemented, I don't know how easy changing it would be.
I can get the type of the parameter objects that failed. That would let us know if it was QboParaemter, EnsoDiagsParameter, etc. The one caveat is that CoreParameter maps to multiple sets (lat_lon, polar, and more). So we'd only know that CoreParameter failed -- not which set failed.
That said, once the user is alerted something failed, they can then look through the output for the stack traces themselves. (That's tedious but at least possible).

All right. It makes sense, we can have more specified failure information at a later time. I would modify the error info to:
raise Exception("{}/{} parameter(s) failed. Check output above.".format(diff, num_expected_parameters)) though. What the numbers (diff, num_expected) do you get with a failed QBO setting?

@chengzhuzhang Actually I want to debug this further. Since there appears to be multiple copies of a *Parameter object created, the returned number could be misleading...

This is probably due to the granulate option, which splits up parameters into multiple smaller parameters. Again, that was done because often, expensive plot sets (like 4) would result in extra time being taken. I.e. the other plot sets would be done, with 4 just remaining.

That said, once the user is alerted something failed, they can then look through the output for the stack traces themselves. (That's tedious but at least possible).

That CDP run stuff uses Dask. If I remember correctly, when the multiprocessing (and not distributed) feature is used, it just uses Python's multiprocessing library. You can easily just not use cdp_run and instead use a multiprocessing.Pool.
With this, you can share the state between the processes, as seen here. This can allow you to write more detailed error messages that can be printed out in the end.
After almost 3.5 (!) years of this current implementation, revisiting it would be a good idea!

@chengzhuzhang I set it up to report which parameters failed (not quite as fine-grained as which sets failed, but it's a good start). See the second commit (https://github.com/E3SM-Project/e3sm_diags/pull/425/commits/28a4e7c9e6be4aac614c745657fd3c8cb24a7cb0).
For example running the tutorial set and forcing the histogram plots to fail I get:
Exception: Not all parameters completed successfully. Check output above for errors/exceptions. The following dictionary maps parameter types to their actual and expected numbers: {<class 'acme_diags.parameter.core_parameter.CoreParameter'>: (548, 562), <class 'acme_diags.parameter.zonal_mean_2d_parameter.ZonalMean2dParameter'>: (16, 16), <class 'acme_diags.parameter.meridional_mean_2d_parameter.MeridionalMean2dParameter'>: (16, 16), <class 'acme_diags.parameter.enso_diags_parameter.EnsoDiagsParameter'>: (9, 12), <class 'acme_diags.parameter.qbo_parameter.QboParameter'>: (1, 1), <class 'acme_diags.parameter.area_mean_time_series_parameter.AreaMeanTimeSeriesParameter'>: (10, 10), <class 'acme_diags.parameter.diurnal_cycle_parameter.DiurnalCycleParameter'>: (30, 30), <class 'acme_diags.parameter.streamflow_parameter.StreamflowParameter'>: (1, 1), <class 'acme_diags.parameter.arm_diags_parameter.ARMDiagsParameter'>: (55, 55)}

@zshaheen Thanks for the information. I created #426 to implement our own multiprocessing code with finer-grained error reporting.

@chengzhuzhang This error message alerts me that ENSO Diags isn't completing all runs in the v2.4.0 tutorial. I made #427 to address this.

Do you want me to make this an optional fail (i.e., user passes in parameter to fail in this case)?

Yes, this will be nice!

@chengzhuzhang This is ready for re-review. There is now a fail_on_incomplete parameter that defaults to False. I ran the unit tests and confirmed they still pass. I also updated the docs to reflect this new parameter. If it is set to True, then if not all parameters complete successfully, then the exit code will reflect failure.


Avoid recomputation in step 2

Hi, I have found that when resuming the script from step 2 it start recomputing validation for all the generated_qa_tuples.
I can't make pull requests as the code is in another acount but here are my modifications
# PHASE 1 END
    print("COMPLETED PHASE 1")
    if WORK_IN_PHASES and PHASE_INDEX == 1:
        print("EXITING DUE TO config.yaml SETTINGS AROUND PHASES; SET TO ONLY EXECUTE PHASE 1 RIGHT NOW")
        sys.exit(0)
    ####

    vetted_qa_tuples = []
    qa_tuples_dir_checked = config["PATH"]["OUTPUT"] + "/qatuples_filtered"
    if not os.path.exists(qa_tuples_dir_checked):
        os.makedirs(qa_tuples_dir_checked)

    # Load already processed qa_tuples
    for file_path in glob.glob(os.path.join(qa_tuples_dir_checked, "para_*_q_*.json")):
        with open(file_path, "r") as file:
            file_body = file.read()
            if file_body != "failed":
                qa_tuple = tuple(json.loads(file_body))
                vetted_qa_tuples.append(qa_tuple)

    # Filter out already processed qa_tuples
    unprocessed_qa_tuples = []
    for qa_tuple in generated_qa_tuples:
        file_path = os.path.join(qa_tuples_dir_checked, f"para_{qa_tuple[5]}_q_{qa_tuple[6]}.json")
        if not os.path.exists(file_path):
            unprocessed_qa_tuples.append(qa_tuple)

    print(f"Total QA pairs: {len(generated_qa_tuples)}")
    print(f"Already processed: {len(vetted_qa_tuples)}")
    print(f"Remaining to process: {len(unprocessed_qa_tuples)}")

    tasks = [
        control_flow_functions.vet_question_loop(
            question_answer_tuple,
            question_group_id=question_answer_tuple[4],
            engine_wrapper=engine_wrapper,
            qa_tuples_dir=qa_tuples_dir_checked,
            vetted_qa_tuples=vetted_qa_tuples,
            double_check_counter=DOUBLE_CHECK_COUNTER,
            completion_mode=COMPLETION_MODE,
            logging_level=LOG_LEVEL,
        ) for question_answer_tuple in unprocessed_qa_tuples
    ]

    limited_tasks_q_validation = [run_task_with_limit(task) for task in tasks]
    for future in tqdmasyncio.tqdm.as_completed(limited_tasks_q_validation):
            await future

    if WORK_IN_PHASES and PHASE_INDEX == 2:
        print("EXITING DUE TO config.yaml SETTINGS AROUND PHASES; SET TO ONLY EXECUTE PHASE 2 RIGHT NOW")
        sys.exit(0)

Thanks for the tool @e-p-armstrong !

My bad it is already implemented


ci: fix fork upload skip

Forks were failing as they used log output but still tried to upload

Test run: https://github.com/hypertrace/attribute-service/actions/runs/7584930267/job/20659681528?pr=211


Change AWS CNI to AWS VPC CNI

What type of PR is this? Small fix to documentation. "AWS CNI" needs to be "AWS VPC CNI" in the index.md file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.654%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3142

Relevant Lines:
9926

💛  - Coveralls


feat: (extended description)

reassigned footnotes
accessibility recommendations from @GitHub: 5 tips for making your GitHub profile page accessible - The GitHub Blog

Closed as duplicate.


TypeScript: add tokenization test cases

Adds test cases for an internal change to the extractor. To be landed some time after the extractor lands.

Added a test case that mixes the different kinds of tokens in the same file.


add nightly validation fcl

This commit adds the fcl that we are running in the nightly validation jobs.  It was being kept with the nightly scripts or being partially generated in the jobs.  Putting it here satisfies a long-standing request from Dave.  Once this is merged, I'll adjust the scripts to use it, then Dave can start upgrading this fcl to more modern input files.  When adjusting this fcl, we want to keep the jobs under 1h on the central machines and keep one output file per job.  Also note that pileup is a combination of 4 variations (0-8,9,10-18,19) and it looks like ceMix is a set of jobs 0-9, duplicated to 10-19 with different seeds.  I don't recall the details, but could probably look up the emails.

Hi @rlcee,
You have proposed changes to files in these packages:

Validation

which require these tests: build.
@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.
:hourglass: The following tests have been triggered for f1b9052e083f8067036f8b5159a94a3884183149: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The build tests passed at f1b9052e083f8067036f8b5159a94a3884183149.

Test
Result
Details

test with
:white_check_mark:
Command did not list any other PRs to include

merge
:white_check_mark:
Merged f1b9052e083f8067036f8b5159a94a3884183149 at d4d5ce9a9a9276b4e55cf1e21d55186a087e1a51

build (prof)
:white_check_mark:
Log file. Build time: 11 min 25 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at f1b9052e083f8067036f8b5159a94a3884183149 after being merged into the base branch at d4d5ce9a9a9276b4e55cf1e21d55186a087e1a51.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.


Test

:robot: This PR was created by @jkfran with the help of GitBulk
Visit gitbulk.com to find and replace code across multiple repositories.


style: fix clippy warnings with Rust 1.66

closes #253

Closing PR as duplicate (fix was implemented through different PR in release 0.5.0)


⚠ Bofrost.nl has degraded performance

In 6954b68, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1282 ms

Resolved: Bofrost.nl performance has improved in a65ae65.


chore: fix broken v4.5.0 link

fixes #172

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_generate_modules
The modules need to be regenerated. Please run make_build.

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/README.md /tmp/tmp.CLPb1VbOeq/workspace/README.md
25c25
< intended for Terraform 0.12.x is [v4.5.0](https://registry.terraform.io/modules/GoogleCloudPlatform/lb-http/google/4.5.0).
---
> intended for Terraform 0.12.x is [v4.5.0](https://registry.terraform.io/modules/terraform-google-modules/-lb-http/google/v4.5.0).
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes