Add example of compiling wat and running with wasmtime

Adding a simple hello world example of WASI to allow developers without any context to understand WASI at its simplest level.
Let me know your thoughts :+1:

Looks great to me! Thanks! One thing though, did you know that you don't need to compile WAT to WASM in order to run in wasmtime? You could actually simply run:
$ wasmtime demo.wat

Perhaps it'd be good to add in the tutorial as well, next to
$ wat2wasm demo.wat

What do you think?

@kubkon Awesome; I've jigged things around to show running wasmtime with both .wat and .wasm files :+1:

LGTM! Thanks again!


some 3D fixes

Fixes the case of missing attributes
When cycling through subdomains (F9./F10), 2D shows the full mesh at the end of the cycle.
Instead, 3D keeps cycling. Now 2D and 3D cases are consistent

@stefanozampini, feel free to merge this at any time. Thanks!


mass obsoletion: inflammatory branch

closes #6748

First PR added parents

@nicolevasilevsky and @twhetzel This mass obsoletion is done and ready for final review from both of you.
Please add your review BUT do not merge until you both had a chance to take a look.
@twhetzel I took this PR opportunity to review the mass obsoletion pipeline and all the latest updates. I didn't see anything wrong, and everything seemed to work as expected. Thank you!

Reviewing now...

Awesome, thank you!!!
I will merge now.


Rotate marathon modes on wikispeedruns.com routinely

My friends and I enjoy doing the marathons in Discord. It'd be nice if these rotated on a daily/weekly basis kind of like Wordle.

I think the biggest challenge to adding these prompts more frequently is that all prompts are generated completely manually. But now that we have a pretty reliable generator, it could be more semi-automated? Or add an option for community submitted marathon prompts to crowdsource

If there were a repo to submit a new set of marathons, I'd happily submit a PR now and again.

@kylecarbs We currently add prompts through a dedicated admin page, but I think it would be cool to integrate some community submitted prompt feature (for both marathon and sprints): #100. Then the admin just has to approve/reject
@dqian3 thoughts?

Yeah, I think we can try doing that? We could add like a contribute link at the botton of the card and link to the marathon editing component (cleaned up hopefully). These do take a while to come up with though.
I think our random article generation might be good enough soon to create some good random marathon prompts, or at least assist with it. For now, it would be good to embed the generator into the marathon prompt creater.

@kylecarbs finally added a new feature for this! #484
You can now submit sprint/marathon prompts on this page to be featured publically
https://wikispeedruns.com/contribute


CNDB-4898: add ReloadReason.REGION_CHANGED for reloading sstables when ￼…

region comes online

The failures are unrelated. Force merging.


No Forge 1.16.5 Code Bits in Block Animations Page on Wiki (I think).

I wasn't sure where to put this, so I just put it in issues, but in the wiki on the Block Animations page, there are only code bits for Forge/Fabric 1.18.1.
(e.g.:
@Override public RenderShape getRenderShape(BlockState state) { return RenderShape.ENTITYBLOCK_ANIMATED; } for Forge and
@Override public BlockRenderType getRenderType(BlockState state) { return BlockRenderType.ENTITYBLOCK_ANIMATED; } for Fabric)
But I was trying to use GeckoLib on Forge 1.16.5, and I was wondering if I just missed something (if I did I'm sorry I wasted your time) or there truly is nothing for 1.16.5, and if there isn't than can someone help me out with the code?
Thank you for your time,
ColbaltheWyvern

The wiki is for 1.18+

Then I feel like it's kinda misleading that they're 1.16.5 code bits in Installation, but thanks for responding so quickly.

The example mod exists for all versions/branches, the wiki is just shows how to add for any version but examples are for latest.

Ahh... I see. Ok, thank you for your time, great mod by the way.


Move empty contract check into getCallbackData function

Summary
Currently the contract address is checked after getting the callback data. We can assert that the types packet should only return us a valid callback data, otherwise it should return an error
Move this check:
    if callbackData.ContractAddress == "" {
        types.Logger(ctx).Debug(fmt.Sprintf("No %s callback found for packet.", callbackType), "packet", packet)
        return nil
    }

into getCallbackData, probably by modifiying getCallbackAddress to return an error

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Done in https://github.com/cosmos/ibc-go/pull/3939/commits/a926b02ce42f81a89ddb24c043f97e36ebadac96. I've also stopped logging this.


Add configuration file to Python package

archmap.conf should be included in the Python package but it is currently not distributed.

A random collection of tabs I had open a while ago regarding this (I think):
https://stackoverflow.com/questions/7522250/how-to-include-package-data-with-setuptools-distribute#14159430
https://stackoverflow.com/questions/3596979/manifest-in-ignored-on-python-setup-py-install-no-data-files-installed
https://stackoverflow.com/questions/24347450/how-do-you-add-additional-files-to-a-wheel
https://github.com/pypa/sampleproject/blob/master/MANIFEST.in
https://github.com/pypa/sampleproject/issues/30
https://packaging.python.org/tutorials/distributing-packages/#manifest-in
https://docs.python.org/3.4/distutils/sourcedist.html#specifying-the-files-to-distribute

Fixed (I think) in 162d206961560bcab77796b23576646e282fa388
This only adds the files to the source distribution though 🤔

Found the anwer here:
https://github.com/pypa/sampleproject/issues/30#issuecomment-143947944
and here:
http://stackoverflow.com/a/39823590
This seems to imply that regular files aren't added to a bdist, which does make sense i guess:
https://stackoverflow.com/questions/24727709/do-python-projects-need-a-manifest-in-and-what-should-be-in-it#comment46447382_24727824

I have rediscovered the pain of Python packaging 😬
It has certainly gotten a lot better over the years but there is still so much conflicting information and too many ways to the the same thing!


Add option to ignore SSL errors

Remove global requests' session
Split init method because it's overcomplicated

I am for adding "ignore SSL" option (disabled by default, of course), but I have doubts about the refactoring because it changes the API, which would require changes in a few internal projects that are using gitlabform as a library.. Perhaps you could change the code to make the public methods, including constructor unchanged, @akaRem ?

@gdubicki
Sorry that it conflicts with your internal libraries — I didn't know about this.
Refactoring is not required for this change, but I still decided to put SSL stuff on top because I don't like to patch global variables which are not excluded from export. This may lead to unexpected behaviour.
In the same time, initialiser is very complicated and includes a lot of logic which normally should be placed either in factory (preferable) methods or private/protected instance methods..
SSL and refactoring doesn't block me for using this tool (and also not very important for now).
So I don't want to spent time on reworking this PR for now, may be later.
But you see the idea for SSL stuff and you can reuse it in improving this tool in way you prefer.

I have reused your code for adding option ignore SSL errors that will be soon released in v. >= 1.7.0, @akaRem . Thanks! I am closing this PR for now then.


[Question]: Sentry Testkit and Expo

Hi all,
While attempting to test my Sentry implementation on a React Native app, I've been struggling to capture the errors and events logged by Sentry.
My React Native app is built on top of Expo (for cross-platform distribution) and I haven't been able to find any docs out there showing support for Sentry with Expo. Expo maintains their own package to facilitate working with Sentry (https://github.com/expo/sentry-expo) and the imports look a little different.
For example the import looks like this:
import * as Sentry from 'sentry-expo'
And logging an error requires a .Native postfix:
Sentry.Native.captureException(error)
My test case looks something like this (Logger.error is a wrapper on Sentry.Native.captureException):
const mockError = jest.spyOn(Logger, 'error')
Logger.error(new Error('hello'))
expect(mockError).toBeCalledWith(new Error('hello'))
expect(testkit.reports().length).toBeGreaterThan(0)

@tigar can you share more context of your app?
how do you initialize your Sentry Testkit instance? what is Logger here? why should Logger errors caught in Sentry?
also - which version of sentry-expo do you use?


Problems with utf8 chars over ASCII 127

With this code:
std::string wstr2str(const std::wstring& utf16Str) { 	std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv; 	return conv.to_bytes(utf16Str); }
For example, utf16 char L'á' (ASCII 225 = 0x00E1) is converted as 2 bytes utf8 string "Ã¡" (0xC3 0xA1) instead of 'á' (0xE1)
Znd with this code:
std::wstring str2wstr(const std::string & utf8Str) { 	std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> conv; 	return conv.from_bytes(utf8Str); }
When you try to convert utf8 "á" (0xE1), an exception arises

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f1bafd3-c257-5243-f093-4cf25bde7649
Version Independent ID: 8e32ffc1-4e29-b4e8-5c82-9e74ff82d476
Content: wstring_convert Class
Content Source: docs/standard-library/wstring-convert-class.md
Product: visual-cpp
Technology: cpp-standard-libraries
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Thanks for the explanation, @orcmid . So, this class can't be used to convert std::string ("á") into std::wstring (L"á") or viceversa

Thanks, orcmid. These issues are meant to raise problems with the docs. A better place for questions like this is https://learn.microsoft.com/en-us/answers/tags/314/cpp.
Closing.


Community.

Is there some sort of community for users to ask questions?
I have a project, and would like to discuss it with other users. Is there a mailing list, telegram channel, social media, anything like this?
I couldn't find one in the Readme if there is one.
If there isn't one, is an issue the right place to do this instead?
Thanks!

I agree, an official community would be great. I've spent so much time beating my head against the wall, because I don't want to bother the maintainers with my trivial issues.
It seems like everyone's using Discord, these days. IPFS, SurrealDB, Logseq, Midjourney... just to name a few I frequent.
I've taken the liberty of creating an unofficial "official Brain.js Discord server" here: https://discord.gg/N3dsVuWfJr
If it grows, and @robertleeplummerjr or one of the other maintainers want to be involved, I'd be more than happy to transfer ownership to the appropriate parties.
Come join us, I'll answer questions, if I can!

Note: they have enabled the Discussions area here on GitHub: https://github.com/BrainJS/brain.js/discussions .  Should be able to ask/answer questions there.


[package] go_router_builder - does not generate code for ShellRoute

go_router_builder
version: 1.1.4
@TypedShellRoute annotation does not yield in any code generation.

This was a known issue https://github.com/flutter/flutter/issues/111888 and it's a duplicate of https://github.com/flutter/flutter/issues/111909. Closing this issue as a duplicate, so please follow up on #111909 for further updates.


Add October 18, 2016 meetup details

📷 night!
Plan to update contributor stats later tonight before merging.

LGTM thus far. I realize there are more commits coming. This review is through commit 3e74724934a94db5e057f5ef1fc595a5ec43830d.

@cgreene all updates are in.


User guide for Telemetry

/kind new-documentation
What happened:
Document Name: TelemetryUserGuide.md
Document Path / Location: NA
(Like from website/github etc - give the complete link)
Issue Faced / Error in the documentation:
No user guide for Telemetry
What you expected to happen:
We need to have a user guide for Telemetry.
This is intended for users. Detail on:
-Details about the feature
-How to use
-Specific config and setup information/tips
-Known Issues
-FAQ
-Support information/contact channel.
How to reproduce it (as minimally and precisely as possible):
NA
Anything else we need to know?:
NA

Please add it to ./readthedocs/starterguides/userguides/


Add an online demo

Hi, it took me a while to get it up and running, so I created a demo on Deepnote. Adding here in case anyone else would find it useful.

Cool, thanks!


After fresh install and init "tasks" folder is missing

I started a fresh project
composer require tightenco/jigsaw
./vendor/bin/jigsaw init
npm install

I saw that there is no "tasks" folder and I miss "./tasks/build.js" what I normally require in my webpack.mix.js
let build = require('./tasks/build.js');

I tried another fresh install with
./vendor/bin/jigsaw init blog

there a "tasks" folder is created.
The documentation shows a "tasks" folder, too.
Directory Structure
https://jigsaw.tighten.co/docs/installation/
Not sure if change or bug.
Thank you

Thanks for the heads up, looks like I forgot to tag releases of the templates when we updated them a few weeks ago, will do that now!
That screenshot in the docs is also out of date, we'll update that.
A plain Jigsaw install should work fine though—when you run the code in your first example, does it fail?

Seems to be a change in v 1.3.22 #452
I guess the changes should be added to the default "blog" and "docs" templates and after that to the docs.

No the fresh install runs fine I was using a pre 1.3.22 webpack.mix.js configuration of another project and it conflicted because I required './tasks/build.js'.
Thank you for the fast answer, jigsaw and all the laravel stuff.

Sounds good, glad it's working! The blog template should work now too, double check it installs v1.1.0 in case Composer has cached stuff.

Thanks again, just wanted to add, the blog template and the basic init worked both fine I was just confused as one created a "tasks" folder and the other did not.


CLI should not print field0, field1 for anonymous ROW

Currently
presto> SELECT ROW(42, true, 'abc');
                _col0
--------------------------------------
 {field0=42, field1=true, field2=abc}
(1 row)

But
presto> SELECT ROW(42, true, 'abc').field0;
Query 20200726_092259_00004_fz6ey failed: line 1:8: Column 'null' cannot be resolved

We should not print those field names.

Is this a bug in the CLI or client protocol? It sounds like the names are in the type name or signature returned from the server.

@electrum this is here:
https://github.com/prestosql/presto/blob/838048343f6868f65f574bc00edf612a1b5ee77e/presto-client/src/main/java/io/prestosql/client/FixJsonDataUtils.java#L117


Read only field

I think it would be easy enough and quit a useful feature to actually be able to do something like:
<% form.inputs do %>
   <%= form.input :title , readonly => true %>
 <% end %>

or
 <% form.inputs do %>
    <%= form.readonly :title  %>
 <% end %>

that would render the normal label and instead of the field would create a span with value properly displayed Date format, number etc ?

I had the same common issue in my app. So what I did, is I created a ReadonlyInput, that now I use here and there:
# app/inputs/readonly_input.rb
class ReadonlyInput < Formtastic::Inputs::StringInput
  def to_html
    input_wrapping do
      label_html <<
      template.pretty_format(object.send(method)) # or some other way to format the value in a nice way
    end
  end
end

# example usage, f.e. in my activeadmin app:
if f.object.persisted? && f.object.class.readonly_attributes.include?("parent_id")
  f.input :parent, as: :readonly
else
  f.input :parent
end

@jtomaszewski :+1: that is the correct approach I'd say. Also you could also create own StringInput, that has the object.persisted? && readonly_attribute?("#{method}_id") logic. It would be more magic, but it could reduce the logic in the view. Then all the inputs would appear as readonly automatically.

@jtomaszewski : I have the problem with that approach that the field in question is set to nil on submit. Did you have to mitigate that when you used your ReadonlyInput?


Introduce ES version build target flag for web

Use case
Currently the production build a Flutter web app produces ES5 output. ES6 / ESNext output would mean a significantly smaller bundle size, and faster startup speed.
Proposal
The build tool should provide a flag where developers would be able to set the target platform. The default could be ES5, but we should be able to pick from others as well, e.g.: ES6, ESNext, etc...

I'm not sure that different ES versions are supported by the dart2js compiler. I'm going to add the dependency:dart to see what can be done.

It looks like dart supports EC6 and has for a while now. Don't know whether Flutter makes use of this feature though.
https://github.com/dart-lang/sdk/issues/46545

@whiskeyPeak Flutter takes whatever dart2js does and uses that, so I my guess is that Flutter web is already in ES6 from the issue you linked.
I don't think that dart2js can be configured to output different sets of ES on demand (like going back to ES5 or using some feature from ES Next)

Going to close this out. We are very careful about upgrading the JS compiler to support a solid set of browsers.


Superset-cleanup

Hmm. I’m not sure how to handle this error. It’s because of the environmental variables - different directories on the gh action. I think probably this means that the data should get surfaced in another place entirely (i.e. a new set of folders that is not part of temp, i.e. /storage)

Easier than expected. Wow!


[raudio] InitAudioDevice and CloseAudioDevice inconsistent when called multiple times

Please, before submitting a new issue verify and check:

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
I found a bug when calling InitAudioDevice and CloseAudioDevice multiple times. I found this in Raylib-cs since examples are in the same project.
Expected: Audio device to be created and destroyed multiple times with no difference in the output.
Actual: Output varies. Most of the time no sound plays and sometimes it segfaults. Using a debug build I tracked the segfault to: https://github.com/raysan5/raylib/blob/f3ce3a6f741fdf02eb602e2d7df7b14951f4aa65/src/raudio.c#L1826
Environment
Platform: PLATFORM_DESKTOP
Operating System: Arch Linux
OpenGL version: 3.3
GPU: RX 580
Code Example
#include "raylib.h"

int main()
{
    // Initialization
    //--------------------------------------------------------------------------------------
    const int screenWidth = 800;
    const int screenHeight = 450;

    InitWindow(screenWidth, screenHeight, "audio-device1");

    // Testing: Init then close then init
    InitAudioDevice();
    CloseAudioDevice();
    InitAudioDevice();

    Music music = LoadMusicStream("resources/mini1111.xm");
    PlayMusicStream(music);
    SetMusicPitch(music, 1.0f);

    SetTargetFPS(60);
    //--------------------------------------------------------------------------------------

    // Main game loop
    while (!WindowShouldClose())    // Detect window close button or ESC key
    {
        // Update
        //----------------------------------------------------------------------------------
        UpdateMusicStream(music);      // Update music buffer with new stream data
        //----------------------------------------------------------------------------------

        // Draw
        //----------------------------------------------------------------------------------
        BeginDrawing();
        ClearBackground(RAYWHITE);

        DrawFPS(10, 10);

        EndDrawing();
        //----------------------------------------------------------------------------------
    }

    // De-Initialization
    //--------------------------------------------------------------------------------------
    UnloadMusicStream(music);          // Unload music stream buffers from RAM

    CloseAudioDevice();
    CloseWindow();        // Close window and OpenGL context
    //--------------------------------------------------------------------------------------

    return 0;
}

@ChrisDill This issue should be solved with latest commit. Multichannel buffers were not properly unloaded.

I have tested the fix with the code example and my C# examples and it fixes the initial issue. However it also causes a crash in audio_multichannel_sound. If you play fxWav or fxOgg using PlaySoundMulti then close the program it will crash in CloseAudioDevice.
I tracked the crash to UnloadAudioBuffer here:
https://github.com/raysan5/raylib/blob/0f309b9b16c7986c5bda65ff002b7a5b432642d4/src/raudio.c#L572

Ouch! I never liked that multichannel implementation... actually, it's on the raylib 3.6 roadmap to review/remove it... now it seems there is a reason for that...

@ChrisDill Just pushed a quick solution, it should work now but it requires a better design...

Tested the latest version and audio_multichannel_sound now works in C and C#!

It still requires a better approach to the problem... but closing this issue for now...


Add new rules for 2 free ancestry boosts to any ancestry as announced by Paizo

In the last community blog post Paizo announced that every ancestry will get option to get 2 ancestry boosts (eg. a dwarf will have a choice of either getting 3 boosts + penalty or 2 boosts no penalty). Add this option to Foundry
https://paizo.com/community/blog/v5748dyo6si7o

Coming onto the github repository and saying "Add this" without offering to do it yourself is, at best, impolite. Please phrase this as a feature request in the future
We had no forewarning and still released all the other errata changes within three hours of finding out they existed
This has already been discussed on the discord; code changes take time but we think we'll have it in by the weekend
You already have a workaround in that you can edit an ancestry on the character sheet to just have free boosts, or you can turn on manual mode for ability scores and accomplish this, so this already exists as an option in Foundry

Please don't come and phrase requests as demands or instructions. Everyone working on this does so for free as volunteers.

Closed by #5507


valueset validation

What library do you use for valuesets validation. I am looking for python implementation if possible.
Thnx.

That's an interesting point. In the following spec (in the chapter "Annex B JSON schema")...
https://ec.europa.eu/health/sites/health/files/ehealth/docs/digital-green-certificates_dt-specifications_en.pdf
... values are coded in JSON Schema notation (draft-07)  which also would allow validating data with the same standard mechanism (Ajv).
Or did I miss anything and the "ValueSets" are a new feature of JSON Schema 2020_12 and can be also validated with Ajv?
Currently it seems that the samples in the test/invalid folder are only validated by structure, aren't they?
If this is the case, what's the reason and advantage that you work with the "ValueSet" notation instead of JSON Schema data   validation right now?
Cheers!
Miguel

The value sets are not part of the JSON schema, they are indirect lookup tables used since JSON schemata cannot have external references to enum values.
We initially had the the values declared as enum, but choose this path as the list of allowed values are expected to change more frequently than the schema itself. Frequent schema changes was considered more difficult to work with for implementors.

I see your point about frequent schema changes.
Regarding external references please feel free to have a look at my proof of concept fork to see how enum validation can be done with $ref.:
https://github.com/miguelzapaton/ehn-dgc-schema
The use of "const" combined with "oneOf" is just an alternative JSON Schema syntax for enum.
As you can see, validation fails now, when there's no corresponding vaccine manufacturer entry in valueschemas/vaccine-mah-manf.json
This would allow specifying a standard mechanism to fully verify the DGC-JSON.
Miguel

ValueSets:

more than just not [directly] part of the schema - they are generated from an EU-wide data source (JRC) which publishes e.g. which vaccines are valid / recognized, start date from when they will be recognized (can be in the future), end date by which they will be discontinued etc etc. These fields are given as active/inactive in the lookup tables (there is in some cases more than just start date / end date to determine if e.g. a vaccine is considered to be active / inactive) but active / inactive is what is of importance for us in - primarily - the verifier app. It is intended to generate the lookup tables on a 24-hour (probably early a.m. for a given EU timezone) cycle, updating such fields as active / inactive.
separation of concerns: it should be possible to download an updated value set without having to re-install the complete application. Having the lookup tables external achieves this
lots more information in the lookup tables that you actually would not want to repeatedly include in the QR code itself, in part due to space constraints for the QR, in part because each time a lookup value changes (e,g, goes from inactive to active) you would also need to generate a new QR code.

please feel free to have a look at my proof of concept fork to see how enum validation can be done with $ref.:

feel free to issue a pull request from your fork to this repo and we can take a look
HTH,
Gaby

What library do you use for valuesets validation. I am looking for python implementation if possible.
Thnx.

@rho-sk you could try e.g. this https://python-jsonschema.readthedocs.io/en/stable/validate/
However, do please be aware that validate the JSON schema is only one half of the story - you will almost certainly also need some business rules, see e.g. https://github.com/ehn-digital-green-development/ehn-dgc-schema/wiki/FAQ#what-do-the-typical-processing-stages-look-like-for

For Java-users: The https://github.com/ehn-digital-green-development/dgc-java libraries now has support for value-set validation, both "static" where files hard-wired into the jar are used and "dynamic" where you use a reloadable value-set.

@rho-sk I'll close if no further comments / questions from your side?

What library do you use for valuesets validation. I am looking for python implementation if possible.
Thnx.

@rho-sk you could try e.g. this https://python-jsonschema.readthedocs.io/en/stable/validate/
However, do please be aware that "validate the JSON schema" is only one half of the story - you will almost certainly also need some business rules, see e.g. https://github.com/ehn-digital-green-development/ehn-dgc-schema/wiki/FAQ#what-do-the-typical-processing-stages-look-like-for

I already implemented schema and value validation in python for that, thx.


Travis build for services

In the first instance we need to go build and go test on PullRequests and merges. Travis is the simplest way to get this up and working.

Yeah big +1 on this, so I'm guessing only an owner (would that big @bigkevmcd only?) can do this?
https://travis-ci.org/ steps seem straight-forward enough, we've used Travis plenty here at IBM before so happy to volunteer to do this
Official docs suggest it could be as easy as augmenting our existing .travis.yaml with
script: go test -v ./...

🤞

I think this is already done?
See the badge in the README for a link to the Travis tests :-)

@bigkevmcd you're so right, @mnuttall as well, let's close this 😄


Adding more functionality to contrib/ansible

Added flannel role to config flannel networking
Added docker role for more control on the daemon
Added kubernetes-addon role to mimic more of the saltbase
Working to get all the addons working, but watching #8107 as it might change how they are installed/upgraded
Verified for CentOS 7 installs.

Can you check out #9041 ? i'll probably ask you to rebase on that. I'm now liking the idea of using tags instead of seperate top level files, but we can get to that...

Thanks for the quick feedback!
This all helps a ton.
I will try and get all this fixed before Kubernetes goes and changes everything again.

No I think you should review #9041 for me   :)

https://github.com/GoogleCloudPlatform/kubernetes/commit/066acab6fd4e670483456421675e994840b9af32
Had my thoughts on flannel. It still needs some work.
I'd like it better if etcdctl told you if it changed anything.  I think your curl stuff works.  So that's better than what I have.  Could probably use your curl + my organization to actually get updates to the config file to restart things on the nodes...


Prevent crash in SPI mode

Fixes #2. spi_init does not init channel[1].leds so when the WS2811.Init() function accessed that array it would crash.
This PR fixes my problem, but it might not be how you want to release this. I don't know whether you could also check whether ledsArray == nil for example, but which might be cleaner.

@supcik any update? This PR works (for me); I've tested it. Is there any reason not to merge this PR? It is just a sanity check that I've added.
Is not merging because you don't have time to test (understandable) or because the PR is fundamentally flawed? I'd like to know 😉

I can confirm that this change works for me too (also using SPI), and I would like to see it merged into master as well :+1:

Done. Thank you for your contribution.


Add Dto mapper for QbicSampleTrackingService

This PR adds a Dto mapper for the QBiC sample tracking service. It makes use of java streams lazy evaluation and allows for easy modification (which location from the JSON is returned can be easily configured.)

Will be included in the update sink


Documentation

I have the same concern, the codes do not have documentation, for example, I was trying to use CCA.mat and faced several issues that need hours of debugging because I don't know what are the expectations of this code for the inputs and other details.

I have the same concern, the codes do not have documentation, for example, I was trying to use CCA.mat and faced several issues that need hours of debugging because I don't know what are the expectations of this code for the inputs and other details.


tcp -> redis for url examples

This one last thing was bothering me - example url changes to conform with how the go-redis library expects them to be.
They still remain backward compatible with the parsing changes I added as the tcp is swapped out for redis

Thanks @nwest1, looks good.


Feat: add verbose flag

Added verbose flag (-v) to display the files that failed discovery to fix #18

@guilatrova I’ll be able to get these changes done tonight. I was able to rebase, and tried (and was mostly successful with squashing my commits, though I may need a bit of help with that.
Thanks for all of the guidance and support on this change!

@ryancheley I'm here to help you! Let me know what failed if you need some help :)

@guilatrova I believe I have been able to do everything. If I missed anything, please let me know.
Thanks again!

Unfortunately, it was not done, but no worries. I'll help you.
First of all, I run these commands to update your branch (as specified here):
❯ git remote add upstream https://github.com/guilatrova/tryceratops.git

❯ git fetch upstream
From https://github.com/guilatrova/tryceratops
 * [new branch]      REFACTOR_specifications -> upstream/REFACTOR_specifications
 * [new branch]      main                    -> upstream/main

❯ git rebase upstream/main
Successfully rebased and updated refs/heads/ryancheley_patch_1_fix_for_issue_018.

❯ git push --force
Enumerating objects: 44, done.
Counting objects: 100% (44/44), done.
Delta compression using up to 8 threads
Compressing objects: 100% (35/35), done.
Writing objects: 100% (36/36), 3.81 KiB | 974.00 KiB/s, done.
Total 36 (delta 22), reused 1 (delta 1), pack-reused 0
remote: Resolving deltas: 100% (22/22), completed with 6 local objects.
To https://github.com/ryancheley/tryceratops.git
 + 8509df0...5e47c39 ryancheley_patch_1_fix_for_issue_018 -> ryancheley_patch_1_fix_for_issue_018 (forced update)

Then, it was not squashed at all. Here's what I did:
git rebase HEAD~7 -i
Prompt:
pick 4cdb60a 0.3.0
p e1dac55 feat: added verbose flag
s 04debab feat: added verbose flag
s 33873bf updated logger to use a named one instead of the root logger
s 7517076 updated logger to use a named one instead of the root logger
s 24b623c added a new logger to capture error for stdout
s 5e47c39 feat: added verbose flag

# Rebase 0a2c1c5..5e47c39 onto 0a2c1c5 (7 commands)

Finally:
git push --force

@guilatrova thanks for the steps. And sorry about that. Not sure what I did in my commit when I pushed it.
Again, thanks for all of the help and guidance. This was such a great learning opportunity and fun. I learned a ton about the logging library too 😀

Glad that you enjoyed it! I appreciated your help contributing to the tool improvement!!


fix: month day data fixed for year 2081

Closing in favor of #60

Seems like you also added some changes for 2085. Can you add a few tests?
Check here for how to assert your changes. #60


test luci try builders

This is a test PR to check if luci try builders work.

@keyonghan Is this still active, or can in be closed?

@keyonghan Is this still active, or can in be closed?

Closing now.


Issue with CIEdgeWork

User reports: "I don’t think CIEdgeWork is working. All the values I try shows a white image"

Turns out the image application does actually work, but you can't tell because the output is white lines and it's on a white background.

vs

We should probably underlay the image with a transparency mask :/


Feature request - open/Close event

Hi,
I would like to have access to the "onClose" and "onOpen" events from my components or the ability to use .sync on the isOpen variable to track when the menu is open or close all the time

@Epillepsy Thanks for the request, I can work on this feature during this weekend

I opened a pull request with a simple implementation of the feature, I'm new to Vue.Js so please don't hesistate to criticize my (possibly) naive implementation of the feature

Merged


[Fix] Fix swav readme doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: GuoxiaWang:x: shiyutangYou have signed the CLA already but the status is still pending? Let us recheck it.


QueryFilter: Override similar FromSql, to be applied globally

Feature request to add a HasQueryFilter(FormattedString sql) override that behaves similarly to FromSql on all LINQ queries involving the entity type, including through Include or direct navigation property references.
Use Case
A multi-tenancy environment where a tenant can get access to more than one record.  Even though HasQueryFilter works across navigation properties, it results in a SQL WHERE.  If a second table has to be included, using an INNER JOIN instead of a WHERE EXISTS gives faster SQL execution time.
Entities:
public class Blog
{
  public int BlogId { get; set; }
  public string Name { get; set; }
  public string Url { get; set; }

  public ICollection<BlogTenant> BlogTenants { get; set; }
}

public class BlogTenant
{
  public int BlogId { get; set; }
  public int TenantId { get; set; }
}

OnModelCreating:
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
  // With current LINQ query predicate functionality
  // modelBuilder.Entity<Blog>().HasQueryFilter(b => b.BlogTenants.Any(bt => bt.TenantId == _tenantId));

  // With requested SQL string functionality
  modelBuilder.Entity<Blog>().HasQueryFilter(
    $"SELECT b.* FROM Blog b INNER JOIN BlogTenants bt ON bt.TenantId = {_tenantId} AND bt.BlogId = b.BlogId"
  );
}

Alternatively, if HasQueryFilter can take a Func<IQueryable<T>, IQueryable<T>> to allow developers to chain Linq statements onto the source, then we can create Linq joins or use FromSql on it.

Have you tried using ToQuery method?

I appreciate the suggestion.  Unless I'm missing something, ToQuery is only on DbQuery.  I do now want to convert my Entity to a Query for two reasons:

I cannot have a DbQuery as the "One" side of a one-to-many relationship in navigation properties.  e.g. I wouldn't be able to have a "UserFavoriteBlogs" with a "BlogId" and "Blog" navigation property that applies this query filter.
I need to be able to create and update Blog records, and I cannot do that with DbQuery.  I would need to create a separate DbSet for the same table for writes.

One alternative I considered - similar to your suggestion - is to have saved queries on the database, e.g. "FilteredBlogs", that joins the tables.  I would define these queries in the DbContext pretending they're tables through DbSet so I can create navigation properties between these "Filtered" queries.  Those would be used exclusively for reads, and separate DbSets to the actual tables would be used exclusively for writes.
I'd rather not do that, mostly because of the additional hassle of maintaining saved queries (and potential changes) in a code-first model.

How about creating additional IQueryable on DbContext?
DbContext could have
IQueryable<Blog> FilteredBlogs => Set<Blog>.FromSql(....);

The main appeal of HasQueryFilter is that it applies across Include and navigation properties, while other methods like LINQ .Where or FromSql cannot.  Unless I'm missing something, it's for that distinction that HasQueryFilter exists at all: whenever that table is accessed through DbContext, that rule is applied.  (With exception to directly executing a provided sql query, such as with FromSql or ExecuteSqlCommand.)

Notes from triage: the core functionality requested here is the same as that for defining query (#13358), so closing this as a dupe with a reference from there to this scenario.


Unfinished refactoring and cleanup of provider settings

Was testing latest version in the morning and found issues with current provider settings that I started fixing but could no finish:

lot of duplicated code, trying to make one function that manages it all
if cookies are not set providers show disabled in settings while they are enabled in dropdown, if you touch one of the settings they are saved as disabled and user has no providers or just one, that is broken
I also saw that state sharing is done trough interval and cookies, that is not React way, that state should be risen up to common parent and propagated down, or some global state container should be used

These are plans for fixes

check #620 if this can help

Closing, yours tehcadacus did similar things differently. Great work.


CI: fail slow tests

Reference issue
gh-20468
What does this implement/fix?
This PR explores the use of pytest-fail-slow to cause tests to fail when they exceed X seconds. This way, the authors of PRs can address slow tests and decide what to do about them before they are added to SciPy.
Additional information
Tests that really need to be run and really need more than X seconds can be marked as exempt.
This PR also more consistently applies the 60s timeout with pytest-timeout (which I think will cause pytest to stop) and the --durations=10 option, since test time rank can be dependent on platform.

To avoid the required dependency, I could just register a fail_slow mark (that does nothing) if the import fails. But we require pytest-timeout, and this is doing a complementary job.

We don't require pytest-timeout (nor pytest-cov, pytest-xdist, etc.). You can uninstall it from your test environment and things should still work. Handled by registering the mark indeed, as you suggest: https://github.com/scipy/scipy/blob/c241196b6b67343f90817d1800fab78d5736fb46/scipy/conftest.py#L25-L29
We have a ton of optional test dependencies. We should aim to keep the required ones to a minimum. Basically, what you're trying to achieve here is a flag being raised against some PR silently adding a really slow test. A single CI job is appropriate for that. There is no reason for that to propagate to all users of our test suite, including for example distro packagers.

As the author, relying on an existing library which just works seemed easier to me than re-implementing it.

If it's optional, that seems fine.

So what I think I'll do is separate the addition of --durations and --timeout to a different PR to separate that issue, and initially I'll add --fail_slow to only one job.

Thanks!

Separately, I added --durations to all jobs because, as you can see from the output, sometimes there are big differences between platforms. Don't we want to speed up the slowest platform, whichever that happens to be?

We want consistency for what goes in "fast" vs. "full". Timings usually are consistent between CI jobs (roughly) with some scaling. It'd be extra flags to test invocation, extra logging, etc. to do this in all jobs - that doesn't seem appropriate here. I think it's important that things remain clean and simple. Something like this should work:

Install some CPython version
Create an empty venv
Build and install: pip install .
Install runtime and required test deps: pip install numpy pytest hypothesis pooch
Run tests: pytest --pyargs scipy

Or some variation of that - the point is to keep it to a minimum, things that are required some be clearly very necessary. And default invocations should do the right thing. If we're adding --timeout or --durations flags to every single test invocation, something is wrong.

Do you mean I should create a very simple new CI job rather than adding it to an existing one?

Do you mean I should create a very simple new CI job rather than adding it to an existing one?

No, an existing job is better. If you mean "why did I write the points 1-5 above": not to suggest writing a new job, but just to illustrate how simple getting a build+test cycle should remain.

Full or fast? I'm not sure if I can have different default times for tests marked slow, so I intended to just add this check to one existing full run and one fast run with different time limits on each.

That sounds good.

Then maybe pytest-timeout doesn't need to be installed in every job? I saw some in which it's installed but not use

Probably not indeed. I am not sure though, since I don't think I was involved in those PRs (or I have a bad memory).

I guess test_import_cycles.py::test_public_modules_importable also needs a bump with Test passed but took too long to run: Duration 5.0043454000001475s > 5.0s

Yup, and I'll add "scipy/_lib/tests/test_warnings.py::test_warning_calls_filters" - I can't tell why it didn't cause a failure.

Also, interesting number of digits in that time comparison, I'd be impressed if that were genuine time resolution.

Ok, marking as ready for review then. Thanks, reviewers!

Sounds like Ralf and I are both happy, so I'l put this in now that I've read the diff one more time.
I do see a small number of test failures when I do i.e., python dev.py test -j 32 -- --durations=0 --durations-min=1.0 --timeout=60 --fail-slow=5.0 on my local Linux box, but there will obviously be variation depending on concurrency level and system, etc., and I wouldn't normally do that locally anyway.
I guess we'll soon find out if this causes the CI to choke a lot!

thanks Matt, Ralf


Fold/unfold

Issue Type: Bug
The fold/unfold feature in VS code has been super buggy for me. Both the clicking on the arrow in the gutter and even the keyboard shortcuts, sometimes just won't do anything at all. The editor is not frozen and will respond to everything else I've tried doing, just not the fold/unfold. Eventually it will come to its senses without my restarting the software. Any ideas on what. the issue might be?
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T17:39:53.251Z)
OS version: Darwin x64 19.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.06GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

cpptools
ms-
1.0.1

(1 theme extensions excluded)

What's the language of the file you see this? Is it reproducible?

It’s in C files. I’m not sure how to reproduce it but it repeatedly happens
to me, for no apparent reason.
Best,
Walaa
On Sun, Oct 25, 2020 at 12:29 PM Martin Aeschlimann <
<EMAIL_ADDRESS>wrote:

What's the language of the file you see this? Is it reproducible?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/109252#issuecomment-716198841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIN5S6OSXECO77VYP3JCA3SMR37JANCNFSM4S42NXKQ
.

Is there already implemented a function to fold/unfold comments in TS or HTML templates from Angular? I am using the latest VSC with no additional plugin installed for folding. I have tried "Fold comments command" but it doesn' work. Is there a 3rd plugin that can take care of "Comments" folding/unfolding?

@rdinca1 This seems to be unrelated to the description of this issue. There's a command to comment/uncomment all comments. If it doesn't work please file an issue with a code sample.
@walaa-a I need small samples and step that reproduce the problem.
Closing this issue, happy to reopen if more information is available.


project_name template variable not replaced in bin/heroku/setup

On the niceleads_backend project, this {{ project_name }} was not replaced, causing an error during heroku deployment.

Weird, did you use this exact command to boot the project up?
django-admin.py startproject new_project \
    --template=https://github.com/ckc-org/skeletor/archive/master.zip \
    --name bin/heroku/setup,app.json,README.md

Specifically mentions replacing name in bin/heroku/setup .. hmm..

Yeah it was successfully replaced in both app.json and README.md.

I'll try to reproduce it.

Damnit. I just did, definitely busted .. weird.. I even tried with paths in quotes..


fix(1379): improve layouting

This PR fixes an issue where the "delete branch" button is covered by a step label, which is caused by the layouting. It fixes #1379, fixes #1374, and resolves #1146.
Changes

Change DAG layouting engine
Update default layout strings
Improve separation between rankings of nodes
Increase weight of edge connecting first steps in a branch (to shift unbalanced branch nodes to be left-aligned)

There is still some room for improvement:

Add proper typings for the library
It would be nice if the graph were symmetrical (for uneven branches, for example), so that edges are the same regardless of the number of nodes in a branch (see "After" of first example below)
Maybe spacing should also be increased at certain places for vertical mode

Screenshots
Before (delete branch button)

After

Before (unbalanced branches)

After

Before (spacing of labels for nested branches in vertical mode)

After

hmm...the before and after pictures have still glitches both. Can we eliminate that? Otherwise I am wondering if it is worth the risk of changing the layout engine.


it will support vuejs ?

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Environment

Chart.js version:
Browser name and version:
Link to your project:

I believe there is a vue wrapper, but it is not maintained by the core contributors


[Feat] Support flag type pathlib.Path

Guild produces a warning:
WARNING: unsupported flag type <class 'pathlib.Path'> for flag input_database - ignoring type setting

When using argparse and pathlib.Path.
I suggest allowing this from guilds side and then just treat is as a string flag.

@gar1t
Will this be a good feature for me to contribute? In that way I could ease into the development a little bit.


ISPN-9732 Local iteration optimization with write behind

ISPN-9732 Local iteration optimization with write behind is valid for non shared stores

Succeeded by https://github.com/infinispan/infinispan/pull/6522


Allow to chain RTS cover commands

Fix https://github.com/iMicknl/ha-tahoma/issues/720

@iMicknl If this fix works, we will have to add the logic to the my button too.

User as confirmed the fix works.

Superseed by https://github.com/iMicknl/ha-tahoma/pull/780


Fix apiVersion error when fetching events

How to categorize this PR?

/area ops-productivity
/kind bug
/priority normal
What this PR does / why we need it:
This PR fixes a bug introduced with https://github.com/gardener/gardener/pull/3466. We cannot assume that TypeMeta is set after retrieving an object from the API server, even though the object has a TypeMeta in the storage. WithoutVersionDecoder removes the GVK information after decoding.
Special notes for your reviewer:
/cc @rfranzke @mvladev
Release note:

NONE

/needs rebase


EEXIST: file already exists for Chrome unstable M58

When using selenium-assistant's browser download via npm-publish-scripts, in order to cut a new release of sw-toolbox, it fails due to the following error. Blowing away my node_modules, reinstalling everything with npm install, and then running the release process again doesn't help.
Starting browser download.
fs.js:1019
  return binding.symlink(preprocessSymlinkDestination(target, type, path),
                 ^

Error: EEXIST: file already exists, symlink 'Versions/Current/Default Apps' -> '/Users/jeffy/.selenium-assistant/chrome/unstable/Google Chrome.app/Contents/Versions/58.0.3018.3/Google Chrome Framework.framework/Default Apps'
    at Object.fs.symlinkSync (fs.js:1019:18)
    at copySync (/Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:52:8)
    at /Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:48:7
    at Array.forEach (native)
    at copySync (/Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:45:14)
    at /Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:48:7
    at Array.forEach (native)
    at copySync (/Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:45:14)
    at /Users/jeffy/git/sw-toolbox/node_modules/fs-extra/lib/copy-sync/copy-sync.js:48:7
    at Array.forEach (native)

Ah, I didn't pick up on the fact that it was caching in ~ rather than in node_modules. That explains why blowing away node_modules didn't help...

This is so it can cache across projects ;)
On Wed, Mar 1, 2017, 8:11 AM Jeffrey Posnick<EMAIL_ADDRESS>wrote:

Ah, I didn't pick up on the fact that it was caching in ~ rather than in
node_modules. That explains why blowing away node_modules didn't help...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/selenium-assistant/issues/87#issuecomment-283385268,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIh8GsXAZ133bB_ijNBjzo5ICxaeIgfks5rhZiigaJpZM4MPzBC
.

When it works :(
On Wed, Mar 1, 2017, 8:19 AM Matt Gaunt<EMAIL_ADDRESS>wrote:

This is so it can cache across projects ;)
On Wed, Mar 1, 2017, 8:11 AM Jeffrey Posnick<EMAIL_ADDRESS>wrote:
Ah, I didn't pick up on the fact that it was caching in ~ rather than in
node_modules. That explains why blowing away node_modules didn't help...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/selenium-assistant/issues/87#issuecomment-283385268,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIh8GsXAZ133bB_ijNBjzo5ICxaeIgfks5rhZiigaJpZM4MPzBC
.


Added KOGI to the Dislike Scene Releases for indexers that rename

Added: KOGI to the Dislike Scene Releases for indexers that rename
Added: DEPRECATED warning for the optional.json, please use optionals.json

I actually wanted to delete it,
It's only used for trash-sync and won't be updated anymore.
Best to upgrade to recyclarr.
But I do except a PR for it.
Not at home anymore and I know I will fail if I try it on my phone.
Thx for reporting

I actually wanted to delete it, It's only used for trash-sync and won't be updated anymore. Best to upgrade to recyclarr. But I do except a PR for it. Not at home anymore and I know I will fail if I try it on my phone. Thx for reporting

The thing is you just caused a bug in recyclarr 😅
recyclarr/recyclarr#87

Thnx
Else I would go  extreme and delete it


Added feature to store articles to local storage when the user clicks on an articles save button

When the user clicks on the favorites button to save an article, it will change the button's style & attributes and
add the article to localStorage. If the article was already saved, then it un-saves the article and removes the
button's style & attributes, and removes the article from the localStorage.
Also keeps track of the status of each article's save button using the local storage. Reverts the attributes and styles of each save button for each article to what it last was before the user reloaded the page. The "data-saved" attribute lets us keep track of which articles were saved.

Local storage are saving as it should for bottom articles. JavaScript looks good!


Update kit screen shot on React tutorial pages

[stub]
The screens of the kit need to be update in the React tutorial pages.

Hey team! Please add your planning poker estimate with ZenHub @laurenmrice @thyhmdo


enter on hashtagpage

Expected behavior
Push enter on hashtagpage takes me to /new request or /new here if no account is detected
Actual behavior.
Push enter on hashtagpage takes me to the hashtaglist
Steps to reproduce the problem.
hashtagpage> enter

@faffydee can you agree on the + button being used by pushing the enter button on a keyboard?

Yep, perfect! Thanks!


Missing config value.

Client (production/canary) and FXServer version  - Production fxversion FXServer 5540
What you expected to happen Only make 1 stretcher spawn
What actually happens people can spawn as many stretchers as they want, this must be restricted in the config as a value for example max 2 per player.

Category of bug (eg. client, server, weapons, peds, native) Script
Reproducible steps, preferably with example script(s) I mean just spawn the stretcher a many times as you want
ESX or NON ESX NON ESX

assigned to dev team @P4R4NORM4L will post in the discord server when update is released

download Version 1.9.05: released 5/14/2022 this should correct that issue @P4R4NORM4L


Fix ProcState parsing for process names with parantheses

Refactor the ProcState code that parses /proc/[PID]/stat to allow any characters between the opening and closing parentheses of the comm field.
This also improves the error handling in ProcState.Get. Previously errors from strconv.Atio were not checked.
Improved the test for ProcState to validate all fields.
Fix bug in test code that generates fake /proc/pid/stat data. It skipped "19" causing an off by one issue.

Fixes #81

@immon I opened a PR for this myself because I wanted to do some additional refactoring to the code to improve error handling.

This has been updated based on the review feedback.


refactor(unquote) make the unquote of variables available on parse, r…

…enaming, adding CLI support
Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

Coverage decreased (-1.2%) to 87.661% when pulling f32c5eee6054f54c03349e912f0b0f71d1e24f10 on jeromesimeon:js-refactor-unquote into 9f19806c0e503b35637308ed59efd7987e22e7b3 on accordproject:master.

Sorry, this isn't quite right. Closing. Will reopen after review / fixes.


add filtering by modifier

Codecov Report

Merging #1 into master will decrease coverage by 0.48%.
The diff coverage is 31.57%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   66.27%   65.79%   -0.49%
==========================================
  Files          47       47
  Lines        3075     3119      +44
  Branches      371      378       +7
==========================================
+ Hits         2038     2052      +14
- Misses        979     1009      +30
  Partials       58       58

Impacted Files
Coverage Δ

shopit/views/product.py
39.62% <16.66%> (-0.19%)
:arrow_down:

shopit/models/product.py
81.26% <16.66%> (-1.2%)
:arrow_down:

shopit/templatetags/shopit_tags.py
26.24% <21.42%> (-0.33%)
:arrow_down:

shopit/admin.py
66.07% <57.14%> (-0.6%)
:arrow_down:

shopit/models/modifier.py
66.89% <60%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01940a0...746c6de. Read the comment docs.


Upload.UploadMedia () not working

Hi,
I'm using Tweetinvi v1.2 but Upload.UploadMedia always returns a system null reference exception.
Auth.ExecuteOperationWithCredentials ( Program.user, () =>
{
	var binary = System.IO.File.ReadAllBytes ( "img.png" );   // Binary is fine
	var media = Upload.UploadImage ( binary );   // Always returns "System null reference exception"
	Tweet.PublishTweet ( "TEST", new PublishTweetOptionalParameters
	{
		Medias = new List<IMedia> { media }
	} );
} );

Note: Analog methods to UploadMedia () ( like Upload.UploadBinary ) give all the same error output.

Could you please provide the details of the error returned by Twitter.
You can learn more about error handling here : https://github.com/linvi/tweetinvi/wiki/Exception-Handling

It's the API what's giving the error, not Twitter ( I think ).
Also I've found out it's about the image size.
I can tweet a 100x100px png fine ( ~30KB ), but a 1920x1080px png ( ~MB ) returns a System.NullReferenceException when calling Upload.UploadMedia ( binaryFile )

Images > 5MB are not supported by the Twitter API.
You can learn more about the restrictions of image upload here : https://dev.twitter.com/rest/media/uploading-media.html in Image specifications and recommendations.

Image files must meet all of the following criteria:

Supported image media types: JPG, PNG, GIF, WEBP
Image size <= 5 MB, animated GIF size <= 5 MB
The filesize limit above is enforced by the media upload endpoint. In addition, there is a separate product entity specific filesize limit which is applied when calling the Tweet creation (or similar) endpoints with media_id. For example, it is possible to upload a 5 MB image, but the Tweet creation requires images to be < 3 MB. The filesize limit and other constraints may vary depending on the media_category parameter.

Oh, okay thanks.
My fault I guess, sry.

No problem! Feel free to come back here if you have any other question!

Hello thanks for your awsome package. I love that. but i have problem with uploading media. Sometimes throw exeption "Exception of type 'Tweetinvi.Exceptions.TwitterNullCredentialsException' was thrown." and it's really don't even try to upload that. i get last version from nuget last night. please help me <3

I forgot to say i used your exeption handler and it says https://api.twitter.com/1.1/account/verify_credentials.json?skip_status=true&include_entities=true&include_email=true web request timed out.
but it dosen't even trying to upload that media. thanks again

The problem comes from a different request which is User.GetAuthenticatedUser.
For some reason you have a Timeout.
This has nothing to do with Upload.
Please open new issues when you have such problems.

Ok. Sorry thanks. but user has been Authenticated well and user variable Informations are just fine.
This is my code anyway:
var userCredentials = Tweetinvi.Auth.CreateCredentials(WebConfigurationManager.AppSettings["PublicTwitterAppKey"], WebConfigurationManager.AppSettings["SecretTwitterAppKey"], kookkon.TWT_AccessKey, kookkon.TWT_AccessSecretKey);                 var authenticatedUser = Tweetinvi.User.GetAuthenticatedUser(userCredentials);                 byte[] file1 = System.IO.File.ReadAllBytes(Server.MapPath("~/images/Photo4.jpg"));                 media = Upload.UploadImage(file1);                 var c = authenticatedUser.PublishTweet("Sometext", new PublishTweetOptionalParameters                 {                     Medias = new List<IMedia> { media, media }                 });
Is there any problem with that.
some times ExceptionHandler.GetLastException() returns null!

I created a bug for you @ https://github.com/linvi/tweetinvi/issues/444


New version: BrettMayson.HEMTT version 1.13.5

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Is there anywhere I can find info on what failed?
It's just a zip, and I've made no changes to my build process

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-11-10 01:00:09.166 [FAIL] Installer failed security check. Url: https://github.com/BrettMayson/HEMTT/releases/download/v1.13.5/windows-x64.zip Result: 0x80004005
MSI (s) (34:D8) [00:59:59:116]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (34:D8) [00:59:59:116]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (34:D8) [00:59:59:116]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (34:D8) [00:59:59:116]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (34:D8) [00:59:59:116]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (34:A8) [01:00:00:007]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (34:A8) [01:00:00:007]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (34:A8) [01:00:00:007]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (34:A8) [01:00:00:007]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (34:A8) [01:00:00:007]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 897.)

@wingetbot run


[AIRFLOW-5071] Fix for race condition with mode=reschedule

This is broken upstream - see
https://issues.apache.org/jira/browse/AIRFLOW-5071
This fix feels like a hack, so I'm not sure that it makes a good
candidate for sending upstream as-is. If this works, I'll at least post
on update on the issue and let the community decide if this is worth
upstreaming.
Summary of the race condition: if the reschedule interval is shorter
than the duration of the scheduling loop, then a Sensor TI can
transition from RUNNING -> UP_FOR_RESCHEDULE -> QUEUED all before the
main scheduler loop can process the "task succeeded" event from the
executor.
If this happens, then the scheduler will see an event saying
"task succeeded" for a TI that's in state QUEUED, so it will mark the
task as failed and the user will see an error in the logs like:
Executor reports task instance <TaskInstance: XXX [queued]> finished
(success) although the task says its QUEUED. Was the task killed
externally?

Instead, we should check and see if the TaskInstance is a sensor that
has been rescheduled. If it is, then this situation is expected and we
can just ignore it.
Here's the sequence of events in a little more detail:

[DagFileProcessorAgent] process_file() moves TI from NONE -> SCHEDULED
[SchedulerJob] _validate_and_run() -> _process_and_execute() -> _execute_task_instances(): moves TI from SCHEDULED -> QUEUED, sends to executor
[SchedulerJob] _validate_and_run() -> _process_executor_events() finishes without seeing any relevant events, scheduling loop restarts
[worker] Executor pokes, sets TI state to UP_FOR_RESCHEDULE and sends TI.event=SUCCESS
TI's reschedule interval expires, now eligble for rescheduling
[DagFileProcessorAgent] process_file() moves TI from UP_FOR_RESCHEDULE -> SCHEDULED
[SchedulerJob] SchedulerJob._validate_and_run() -> _process_and_execute() -> _execute_task_instances() -> moves TI from SCHEDULED -> QUEUED, sends to executor
[SchedulerJob] _validate_and_run() -> _process_executor_events() finally sees TI.event=SUCCESS from the previous attempt, but now TI.state == QUEUED. Oh no!

Should be good enough. Is there a way to skip rescheduling for a list of tasks that has task.event=success?

Is there a way to skip rescheduling for a list of tasks that has task.event=success?

I think that could also cause problems. If I understand correctly, when the executor reports task.event=success that could mean either:

poke() executed and the TI is now UP_FOR_RESCHEDULE
poke() executed and the TI is now in {FAILED,SUCCESS}

If it's 1 then we do need to re-schedule the task


Simplify document_presenter_spec

Introduce a FactoryGirl factory for generating CMA case payloads.
Make the test data declarations more readable by bringing scenarios
and data declaration closer to each other.

Side-note: There are 3 test related to using "headers" (actually headings tags); it seems that they overlap what they are testing. Maybe we only need to keep one?

@christophwong I agree, I think the #to_json with headers may be superfluous, but I left it in to keep this a refactoring, as opposed to a change at the same time...


Added MarkDown formatting to examples/lstm_stateful.py

Summary
This PR adds Markdown formatting to examples/lstm_stateful.py.
Result:

Related Issues
#12219
PR Overview

[ ] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

I'm not sure why the tests failed here, because all the tests passed for this commit locally.
From the CI:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Seems like a timeout.

This does not appear to be standard markdown. Please take a look at e.g. README.md for an example of standard markdown.

I tried and made the Markdown as standard as possible, given README.md.
Result:

Is it still non-standard Markdown?

Looks good to me.

Looks good to me.


Seeing 38% Performance degradation in Performance tests for bulk read using eval

Seeing 38 % Performance degradation in Performance tests for
•	bulk read using eval :
Actual = 0.5809 docs/ms (38% degradation )        ||   Baseline = 0.942 docs/ms
For reference, see Email "9.0-ea2 Weekly Server Performance Report || 9.0-20160228" sent on
Mon 3/7/2016 1:46 AM.

This problem appears to have been a one-off.  It hasn't continued in more recent performance reports.


Axe violations in collapsed breadcrumbs

solves #22288

[ x] I have followed (at least) the PR section of the contributing guide.

I am not entirely sure but I think the issue is in this line of code. Please review.
  const focusable = event.currentTarget.parentNode.parentNode.querySelector(
    'a[href],button,[tabindex]',
  );


escape(X) or quote(X), like the one in the sqlite core or mysql?

Is there anything in the API that would resemble quote(X) from the core: https://www.sqlite.org/lang_corefunc.html ?
Or anything else that would convert the provided string/Buffer/number into an internal string format, similarly to how mysql API does with its escape(X) function, see https://github.com/mysqljs/mysql#escaping-query-values ?

You don't need to escape data values manually. You should simply use bound parameters, which automatically separate SQL code from data values.

I do! Performance of INSERT INTO MyTable (...) VALUES (), (), (), (), ..., () is substantially faster than doing it one-by-one with bound parameters.

That shouldn't be the case. Without seeing your entire code, I can't pinpoint what you need to do differently. But, in short, the fastest and safest way to insert a large number of rows in SQLite is like this:
const db = require("better-sqlite3")("./my-database-file.db");

// Make sure you're in WAL mode with the NORMAL synchronous setting.
db.pragma("journal_mode = WAL");
db.pragma("synchronous = NORMAL");

// Prepare your INSERT statement.
const insert = db.prepare("INSERT INTO MyTable (col1, col2) VALUES (?, ?)");

// Create a transaction for your bulk operation.
const bulkInsert = db.transaction((rows) => {
  for (const row of rows) insert.run(row);
});

// Execute your transaction by passing all the rows you need to insert.
bulkInsert([
  ["hello", "world"],
  ["foo", "bar"],
  ["baz", "qux"],
]);


Kubernetes Windows nodes

In our Cluster, we have a LoadBalancer to handle Control Plane API-Server. After Windows patch kb4570333, our self sign certification cannot support gMSA any more. our windows node cannot call gMSA-service to get AD authen work.

/kind support
@aaronsssya you will have to look elsewhere for help with Kubernetes. Given there's only one relevant vendor, how about starting from https://docs.microsoft.com/en-gb/virtualization/windowscontainers/communitylinks ?

/close


[HUDI-3962] fix hive sync partition fields error in flink #5412

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
fix https://github.com/apache/hudi/issues/5394
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Close because this is not a valid fix.


Resolves #5: adds port selection via command line arguments

Resolves #5:

main.go now accepts command line arguments (via os.Args), replacing hardcoded port numbers.
Dockerfile now accepts build-time variables, replacing hardcoded port numbers.
Executing make (i.e. make run) passes the values of the pre-existing EXPOSED_API_PORT and PROXY_PORT variables to main.go (as command line arguments) and to Dockerfile (as build-time variables).

Examples of use:
$ make EXPOSED_API_PORT=9996 PROXY_PORT=9997

$ make docker-image EXPOSED_API_PORT=9996 PROXY_PORT=9997
$ make docker-run EXPOSED_API_PORT=9996 PROXY_PORT=9997

$ make docker-image EXPOSED_API_PORT=9995
$ make docker-run

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Proposal: Add more styling options with curly brackets

Hello, is it possible to have another style option with curley brackets:
import "fmt"

func main()
{
	fmt.Println("Hello")
}

Is there anyway to have this type of styling in GO?
Not just
import "fmt"

func main() {
	fmt.Println("Hello")
}

No, it's not possible in Go to not place the opening
brace on the same line as the other parts of the line.
This has been discussed at length on the mailing
list. Please search the golang-nuts mailing list archive.
Closing. We're not going to change the language now,
especially for such cosmetic grammatical changes.

Thank you for your time and your comment.


Support testcontainer-less TestSystem

When using stove in pipelines, we faced some infrastructural issues like image errors, timeout, slow startup time, high memory and cpu usage.
To solve this kind of issues we decide use Stove with shared environments instead of DiD. If we can pass our environment configurations to Stove, Stove doesn't need boot testcontainers any more.
so we need to pass our shared environment configs to Stove like following.
TestSystem("http://localhost:8001").with {
            bridge()
            couchbase {
                CouchbaseSystemOptions.fromInstance("http://localhost:8089","username","password","defaultBucket)
            }
            kafka {
                KafkaSystemOptions.fromInstance("localhost:9001",objectMapper)
            }
        }.run()
    }

with this implementation we can continue to use Stove without any breaking change in tests, we need to change only Test setup.

That makes sense. and quite similar to what we have already:
TestSystem(baseUrl = "http://localhost:8001") {
    if (isRunningLocally()) {
        enableReuseForTestContainers()
        keepDendenciesRunning() // this will keep the dependencies running after the tests are finished
    }
}

There are some points to think about from top of my head:

What about test migrations? Do we assume that they are run already? We should provide options to always-run migration when running against existing infra.
Should not mix with isRunningLocally, or at least if both are configured the local one should take precedence.

That makes sense, and quite similar to what we have already:
TestSystem(baseUrl = "http://localhost:8001") {
    if (isRunningLocally()) {
        enableReuseForTestContainers()
        keepDendenciesRunning() // this will keep the dependencies running after the tests are finished
    }
}

There are some points to think about from top of my head:

What about test migrations? Do we assume that they are run already? We should provide options to always-run: false | true migration when running against existing infra.
Should not mix with isRunningLocally, or at least if both are configured the local one should take precedence.

I think we can continue to support migrations because we continue to create buckets and topics from e2e code base.
reusable containers are not suitable (https://java.testcontainers.org/features/reuse/) for CI pipelines but we can use at local, so it would be good if we support both type, instance or resuable

ReadySystem requirements:

Naming conventions for ready system e.g.: CouchbaseReadySystemOptions, KafkaReadySystemOptions, etc...
Migrations can run as is
Ready system Healthcheck callback
StateOfSystem can stay as is, it looks.
StateStore can be implemented.

Ehancements

ShudownHook can be implemented to clear all the data for the related TestSystem


Allow native install of Teku Validator to start

The Teku Validator client by default wants to log to /home/rp/.local/share/teku/logs, so the rp user's home directory must exist or it will fail to start. I offer this merely as a suggestion and to bring awareness to the problem, I'm not tied to any particular solution. A better fix may be to configure Teku Validator to log somewhere else.
https://docs.teku.consensys.net/en/latest/HowTo/Monitor/Logging/

I think this is a fine solution for now. I'll look into this more to see if there's a better one later. Thank you!


add admin areas to multiple countries

Adding custom migration to add administrative areas for multiple countries:

Australia (5 states and territories)
Russia (states, 22 Replublics, 9 Krais, 3 Federal Cities)
Argentina,
Brazil,
Chile,
Colombia (32 Departments and 1 Capital District)
Mexico (31 states and 1 Federal entity),
Peru (25 Departments),
India (36 states and union territories)

Checklist

[ ] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

@sekharpanja Some of the IDs of the countries seem to be the wrong ones (probably an adjacent one). If you run the migration locally you can navigate to http://localhost:8000/admin/metadata/administrativearea/?o=1.0&p=2 give things a quick check.

Yeah you can rebase develop and squash all commits into one before merging. Also can you change the commit title to read Add data migration for administrative areas (instead of adding).
Thanks!


BREAKS existing App Store apps!

My app, which was last updated on App Store in 2015, suddenly stopped installing on anyone's iPhones. Both myself and Apple were stumped by this, but I rolled my code back and tried to build again… and it builds successfully, but the simulator shows the same "Could not install" error message that real devices have been showing!
But on macOS, we have a console, and its log says:

-[IXSCoordinatedAppInstall _onQueue_acquireAssertionAndDoInstall]_block_invoke: Installation for <IXSCoordinatedAppInstall<0x7fb582613300> identifier:com.BronyNet.BronyTunes uuid:3034B569-531C-4D72-8569-F4B994F9E643 intent:IXCoordinatorIntentInitiating creator/appDRI:InstallCoordination Simple SPI userInitiated:N state:IXAppCoordinationStateWaitingForInstall> failed: Error Domain=MIInstallerErrorDomain Code=12 "Bundle at path /Users/jacobpritchett/Library/Developer/CoreSimulator/Devices/C00F95AD-8D66-480B-B28F-C65CC8A285EA/data/Library/Caches/com.apple.mobile.installd.staging/temp.BnDO22/extracted/BronyTunes.app/Frameworks/DRKonamiCode.framework did not have a CFBundleIdentifier in its Info.plist" UserInfo={LegacyErrorString=MissingBundleIdentifier, FunctionName=-[MIBundle _validateWithError:], SourceFileLine=45, NSLocalizedDescription=Bundle at path /Users/jacobpritchett/Library/Developer/CoreSimulator/Devices/C00F95AD-8D66-480B-B28F-C65CC8A285EA/data/Library/Caches/com.apple.mobile.installd.staging/temp.BnDO22/e

So something's going very wrong here, and it seems to point back to DRKonamiCode.

Feel free to let me know of any changes you need to make to this repo @JacobSyndeo


how to show memory allocation / cpu runtime of processes in production environment?

having a lot of garbage generated and not sure where the code is.
possible to give an idea?
i suspect it's many tls termination memory alloc issue etc

use pprof and refer to https://www.freecodecamp.org/news/how-i-investigated-memory-leaks-in-go-using-pprof-on-a-large-codebase-4bec4325e192/


SIGABRT malloc: *** error for object pointer being freed was not allocated

Description
OS: ios only
App is randomly crashing in production since updating to 0.64.2. Sometime it's UICandidateViewController and others it's UISystemKeyboardDockController or UICandidateViewController or UICompatibilityInputViewController. Only common factor is the app is moved to the background.
This does not happen for every one and seems quite sporadic and random so can't clearly replicate every time.
React Native version:
System:
    OS: macOS 11.5.2
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 304.63 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 6.14.3 - ~/.nvm/versions/node/v12.13.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 15.0, DriverKit 20.4, macOS 11.3, tvOS 15.0, watchOS 8.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.2 AI-202.76<IP_ADDRESS>86908
    Xcode: 13.0/13A233 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.5 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: 4.13.0 => 4.13.0
    react: 17.0.1 => 17.0.1
    react-native: 0.64.2 => 0.64.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Move application to background
Crash is random and impact only a small number of users in production (still over 3k instances though)

Expected Results
Application not to crash
Snack, code example, screenshot, or link to a repository:

Having a similar issue! Would love some help

Bump

I'm facing this issue, any solution?

Bump

Bump

Logs from Firebase Crashlytics
crash_info_entry_0 | abort() called
-- | --
crash_info_entry_1 | SpotOnChain(17822,0x105988580) malloc: *** error for object 0x2805f9bf0: pointer being freed was not allocated

Stack Trace
Crashed: com.apple.main-thread
0  libsystem_kernel.dylib         0x7964 __pthread_kill + 8
1  libsystem_pthread.dylib        0x7378 pthread_kill + 268
2  libsystem_c.dylib              0x1ff50 abort + 164
3  libsystem_malloc.dylib         0x1ba08 _malloc_put + 550
4  libsystem_malloc.dylib         0x1bbe0 malloc_report + 64
5  libsystem_malloc.dylib         0x1180 free + 500
6  App                    0x1bb7ec std::__1::__hash_table<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>::__deallocate_node(std::__1::__hash_node_base<std::__1::__hash_node<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, void*>*>*) + 256 (new:256)
7  App                    0x1bb79c std::__1::__hash_table<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>::~__hash_table() + 534 (unique_ptr.h:534)
8  libsystem_c.dylib              0x208c4 __cxa_finalize_ranges + 460
9  libsystem_c.dylib              0x1b228 exit + 32
10 UIKitCore                      0xf50f68 -[UIApplication terminateWithSuccess] + 502
11 UIKitCore                      0x63bd14 -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 128
12 UIKitCore                      0x830c5c -[_UISceneLifecycleMultiplexer forceExitWithTransitionContext:scene:] + 224
13 UIKitCore                      0xf4dae4 -[UIApplication workspaceShouldExit:withTransitionContext:] + 212
14 FrontBoardServices             0x4fc38 __63-[FBSWorkspaceScenesClient willTerminateWithTransitionContext:]_block_invoke_2 + 80
15 FrontBoardServices             0xa6b4 -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] + 240
16 FrontBoardServices             0x4fbd0 __63-[FBSWorkspaceScenesClient willTerminateWithTransitionContext:]_block_invoke + 132
17 libdispatch.dylib              0x4660 _dispatch_client_callout + 20
18 libdispatch.dylib              0x8118 _dispatch_block_invoke_direct + 264
19 FrontBoardServices             0xbf94 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 48
20 FrontBoardServices             0xb3d4 -[FBSSerialQueue _targetQueue_performNextIfPossible] + 220
21 FrontBoardServices             0xf9e4 -[FBSSerialQueue _performNextFromRunLoopSource] + 28
22 CoreFoundation                 0xbb020 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
23 CoreFoundation                 0xcbce0 __CFRunLoopDoSource0 + 208
24 CoreFoundation                 0x5fe8 __CFRunLoopDoSources0 + 268
25 CoreFoundation                 0xb7f4 __CFRunLoopRun + 820
26 CoreFoundation                 0x1f3b8 CFRunLoopRunSpecific + 600
27 GraphicsServices               0x138c GSEventRunModal + 164
28 UIKitCore                      0x5196a8 -[UIApplication _run] + 1100
29 UIKitCore                      0x2987f4 UIApplicationMain + 2092
30 App                    0x5aec main + 8 (main.m:8)
31 ???                            0x10593da24 (Missing)

This hasn't been resolved


Export/Import issue?

Is there a known issue with exporting and importing?  On my twine game the inventory systems works fine, but inventory content is not saved on export.  I verified this with a button:
<<button "Serialize Game" >>
<>
Doing this will empty out my inventory.  The output from the Save.serialize() is logged and shows there is nothing in the inventory array.  perhaps a problem with marshalling?

Tested the save using the older inventory system and that worked.

Strange. If it works in saves it should work in export/import. I'll need to investigate this. Thanks for the report!

for what its worth, the save to slot behavior is the same.  It loses the inventory contents.  Im on sugarcube 2.36.1 .  My machine is MacOS/Safari also tried MacOS/Firefox.

It should/did work with normal saves for sure in the past, but I'll check.

Ok. let me know if I can supply you with anymore info. Unfortunately I'll soon need to revert back to the V1 simple inventory. I tested that and it still works.

Checking my test projects, using both normal saves and saves to disk, both work as expected, preserving the inventory data as expected.

If possible can you send me the compiled HTML file that is misbehaving?

Sure. the attached example demonstrates the behavior.
SaveBugExample.html.zip

Sorry it took me so long to get back to you. The issue is not with SI3, and older SI versions will also not work with this. The game state is only updated on passage navigation, and this has always been the case. Changes to in-engine variables after the last passage nav and before the next will never be (and have never been) reflected in saved games or serialized moments, it will revert to the state things were in the last time navigation occurred. Again, this is just a hard limitation of the engine, nothing unique to this library.

Thank you for the update. Is there a way to force the l logic in the navigation prior to the save?  Re-navigate to the room your in via javascript?  maybe something more granular?  I would greatly appreciate suggestions on ways to get around this.  thanks.

Even if you play a big AAA video game, you'll find that most of the time, when you save and load, it'll put you back to a checkpoint, whether that's leaving or entering a room, just after or before a cutcsene, or the start or end of the most recent combat encounter. So my first question would be, how much actual progress so players stand to lose by being loaded in at the last passage navigation? If it's a small amount I wouldn't bother.
If you think the amount of progress players would lose would be significant, I would ask how far along you are and if it's possible to change your game to feature more consistent passage navigations, as they are important to the engine.
If neither of those works, you can use a save event to manually update the variable store (or just the inventory) before saving, but I think this is worth avoiding if at all possible.


Bundle size appears too big

I'm using MUI v0.17.4. I know 0.x is not supported and I'm already planning to upgrade to 1.x. I'm trying to check whether upgrading would help me cut down the bundle size significantly, and see if I'm making any obvious mistakes at the moment with 0.x.
While analyzing the production bundle I noticed a few things:

The bundle size of 260KB appears to be rather big. If I switch to v1.x, how much reduction in bundle size can I expect to get with the same set of components?
While I'm importing about 10-15 colors in my project, every single color in the colors.js is part of my bundle. Is this normal or am I making some mistake? I'm importing the colors like so:
import {amber600, blue600} from 'material-ui/styles/colors'
I noticed that some components are included in the bundle which I'm not directly importing, for example FontIcon, EnhancedSwitch. What is importing these components?

Thanks so much!

The bundle size of 260KB

It's 54kB gzipped. It's not that much. A lot of people are shipping a 200kB gzipped bundle even after tree shaking 🙈.

I'm trying to check whether upgrading would help me cut down the bundle size significantly

significantly? No, it won't. It will most likely be smaller, but I have don't have any figure to share.

I'm importing the colors like so

Color can be imported directly in v1.x to prevent including unneeded color. You can't do anything about it with v0.x.

I noticed that some components are included in the bundle which I'm not directly importing

They are transitive dependencies.

Thank you, guys. I really appreciate your work!


Use artifacts instead of caches for file sharing between jobs

Signed-off-by: bo.jiang<EMAIL_ADDRESS>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Use artifacts instead of caches for file sharing between CI jobs
Which issue(s) this PR fixes:

Fixes #119
Special notes for your reviewer:

/lgtm


Package is named knockout-chooose on npm

The package is named knockout-chooose - with 3 o - on npm.
If this is intended, at least the readme should be updated :-)

definately not intended :( gah.... Let me publish this to knockout-choose and fix the package.json


Controller runs twice when activating a state with slash in the params

When activating a state with a slash in the params, it will call that state's controller twice.
$state.go('myState',{previous:'/last/page'});

I wrote some tests to demonstrate:
http://plnkr.co/edit/WgBVFpArGhamZe5mVtWz?p=preview
Thanks to @kathygit for discovering this, as well as providing a workaround (url encoding the slashes) in the issue referenced below.
Tested with Angular 1.4.7 and UI-Router 0.2.15.

+1 I have the same issue

It s not like nobody is using a parameter as return path with / inside ...
How it s possible to have this bug if there is testing ?

Hello,
I am facing the similar issue. the controller is called twice which is causing a major problems.
I am using the 0.2.15 version.
I am surprised the issue still exists . Can anyone help me how can i resolve the issue. The parameter passed here is mandatory and it can be Y or N.
See the example.
Template
ui-sref=".newProject({fromTempl:fromTemplate})
Configuration
.state('home.projTypeView',{
url: '/projTypeView/:fromTempl',
views: {
'mainContainerView@': {
templateUrl: 'apps/views/projectTypeList.html',
controller:'projectTypeListController',
      }
 }

})
Please help me out . I could not find any answer .
Regards,
Manish Singh

+1

+1
Exactly the same issue here

Same here.

http://plnkr.co/edit/7sJQL9UEMlwiwYSqglvX?p=preview

This is happening again as of 0.3.1

@deathgaze can you put this in a plunker ? http://bit.ly/UIR-Plunk


Fix test_viewport_size_validation test

This seems to fix the bug :clap: https://travis-ci.org/github/scrapinghub/splash/builds/675223461

Awesome, thanks @ivanprado!


How I can pass “allow_unicode=True” to yaml encoder

Hello,
For my project I use version 0.4.5
I would like to ask you how I can pass "allow_unicode = True" to yaml encoder ?

def export(self, queryset=None, *args, **kwargs):
        kwargs.update({'allow_unicode' : True})
        return super(BranchResource, self).export(queryset, *args, **kwargs)

but this raises an error for unknown parameter
I want to pass this parameter because I believe that this way I can fix encoding in a resulted YAML file.
At the moment all Cyrillic characters in the file are displayed as an escape characters  .
Best regards

It looks to me like we depend on Tablib for exporting to various formats, but with version 3.0.0 of Tablib unicode characters probably are supported in Yaml from Tablib. I'd suggest retrying this with tablib 3.0.0+. If this is still an issue let us know.
reference: https://github.com/jazzband/tablib/blob/master/src/tablib/formats/_yaml.py
See that Tablib now passes allow_unicode=True to the YAML decoder.


Link anchors doesn't work in Redoc

I tried fixing a link anchor in the Ubuntu guide:
-1. Repeat Installation [step](#2-install-rocketchat)
+1. Repeat Installation [step](Ubuntu.md#2-install-rocketchat)

Because the original state ended up in an invalid link as @lkraider reported (https://github.com/RocketChat/Rocket.Chat.Docs/issues/10#issuecomment-211669533), I tried this but failed because it doesn't get correctly processed by Redoc.
The link turns into https://rocket.chat/docs/master/installing-and-updating/deployment-options/Ubuntu.md#2-install-rocketchat but because of the .md it links to a new (non existent) article.
Any ideas @RocketChat/documentation-and-wiki?

@frdmn could you please you confirm this is still an issue after latest changes on MD-to-HTML link replacements?

On a side note, I believe we should stick with whatever works perfectly on GitHub and adapt our Redoc for should the need arise. Aye?
/cc @engelgabriel

@gmsecrieru Yes, it's still broken. It now renders as:
http://localhost:3000/master/installing-and-updating/manual-instalation/ubuntu/ubuntu-md-2-install-rocketchat

I agree with @gmsecrieru
The objective is to keep it 100% compatible with GitHub, so we fix Redoc to be compatible when needed.

Since we are moving to a directory-oriented structure, that URL was not valid anymore. For any further changes:

When referencing the same file, you should use Repeat Installation [step](#2-install-rocketchat)
When referencing other files, you should use /3.%20Installing%20and%20Updating/4.%20Manual%20Instalation/FreeBSD#packages

That will work for GitHub and should work for our Redoc fork too -- otherwise I will jump in and fix it.
Keep up the great work!

@gmsecrieru any chance we can make the regex for URL work with SPACES and not just %20 ?

@engelgabriel seems like markdown-it does not even parse these strings as actual URLs so we can't  replace them, e.g.:

We might be able to use different package(s) and adapt our fork to use it, but I wonder if that's worth the trouble.
Pinging Markdown SME @geekgonecrazy for thoughts :)

Do we know of any markdown editor anywhere that handles spaces in links?  I don't know of any that do.  This is I think just one of those HTML link encoding things... We might be able to hack something in that would recognize links and replace spaces with %20 before passed to the markdown engine?
But should we?


hyperlink is slower than liche on folders with many small files

Hyperlink may be faster on docs.sentry.io, but is actually slower on the following synthetic test:
seq 1000000 | xargs -P4 -n1 -I{} sh -c 'echo "Hey" > {}.html'

Not overly concerned about this one in particular since it is not close to the real world, but we should figure out how to do parallel directory walking.

recent commit makes it faster, but we need to verify still

it seems to be roughly on par after https://github.com/untitaker/hyperlink/commit/d140d39dd8e1606f3a56176ccc1477d4bb3087ec on that particular test. Let's test the Wikipedia corpus next

Wikipedia corpus does not work out too well for any linkchecker, closing.


SKCoreTests: adjust toolchain library stubs for Windows

The toolchain library runtime components are installed into the binaries directory and the import library (link components) are installed into the lib directory.  Darwin splits the runtime (dylib) and link time (tbd) across the SDK and the installation and Linux uses the same file for both.  Account for the difference on Windows to correct some of the test expectations.

@swift-ci please test


etcdserver: let Status() not require authentication

The information that can be obtained with the RPC doesn't need to be
protected.
Fix https://github.com/coreos/etcd/issues/7721
/cc @raoofm @heyitsanthony

lgtm