Updated Topic Suggestion Form

Have updated the topic suggestion template in similar terms to #3348. Have also added some points around uniqueness which should hopefully help us approve topic suggestions quicker.
Have removed the extra content suggestion templates because authors are mainly using the main content suggestion form and any updates only need to be made to one file. The other templates are older so don't match our new form (not auto labelled) and additional step we now use so is confusing to authors.
Have renamed the form to EngEd Topic Suggestion since that's what we call our issues.
Changes Made

Removed extra issue templates - Software/How-To-Guide/Tutorial since authors are mainly using the generic EngEd Content Suggestion form.
Improved topic suggestion form - In line with #3348.

Added edits to the main file here 👍
https://github.com/section-engineering-education/engineering-education/blob/master/.github/ISSUE_TEMPLATE/enged-content-idea-suggestion.md
Please double check I added all edits you suggested
Thank you very much @louisefindlay23


courses cannot download

Udeler | Udemy Course Downloader
1.11.4
Running as Business Account

[ ] Yes

Steps to reproduce
it stucking at "building course data".

✔ Expected Behavior
No response
❌ Actual Behavior
No response

any help? :'(

Same issue here

I will continue to look for a solution to this problem, gentlemen.

thanks @heliomarpm.
do you have any update?

Hi, send a screenshot the menu Logger, please.

thanks @heliomarpm.
do you have any update?

Hi, send a screenshot the menu Logger, please.

Same issue here

I am having a similar issue. On this 9th video it gets to the end of the download and just freezes like this. I have tried several times with the same thing happening every time.

I am having a similar issue. On this 9th video it gets to the end of the download and just freezes like this. I have tried several times with the same thing happening every time.

Please, send me Logger message.

How do you even managed to download in 1080p? I can download the exact same course but only in 720p. It stops sometimes but I use the restart download option.

How do you even managed to download in 1080p? I can download the exact same course but only in 720p. It stops sometimes but I use the restart download option.

by your print you are already downloading the highest resolution, this course probably doesn't have videos in 1080p.  I'm going to try to buy this course, so I'll be sure if it offers this resolution or not

How do you even managed to download in 1080p? I can download the exact same course but only in 720p. It stops sometimes but I use the restart download option.

by your print you are already downloading the highest resolution, this course probably doesn't have videos in 1080p. I'm going to try to buy this course, so I'll be sure if it offers this resolution or not

Mawly779 shows that he can download in 1080p, I also downloaded one video over jdownloader via the vlc extension in firefox in 1080p.

I now managed to download it on 1080p but have the same problem as Mawley779. It stops after video 8. I saw that the title of the video has a / (slash) in it's name. Maybe that causes the problem? Because you can't use / in file names.

yes, that can be a problem.  Thanks for reporting, I'll check

Added a bug tracking library, hope to find the root of the problem soon

Cant able to download DRM protected videos

Cant able to download DRM protected videos

This tool does not download protected videos, is't an issue.


Allow external commands display usage instructions with help flag

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This PR allows external commands display usage instructions with help flag, and fixes #2390.

See brew services --help and https://github.com/Homebrew/homebrew-services/blob/a5115e47b05e8d2a632ba7775599e698b240e5a2/cmd/brew-services.rb#L1-L31 for an example of how to implement help in external commands.

It's cool! Thanks :)

@MikeMcQuaid i miss a documentation about this help feature here http://docs.brew.sh/External-Commands.html

@muescha Good idea, I'll do that at some stage.

@muescha Done in fabc5bc89


doc: update acknowledgements and rm AUHTORS.txt

Please fill in the fields below to submit a pull request.  The more information
that is provided, the better.
Fixes #1807
Description of the changes being introduced by the pull request:
Update README.md#Acknowledgements

Reword to acknowledge maintainer contributions as well
Remove names that are mentioned in maintainers document
(Santiago Torres-Arias, Sebastien Awwad, Trishank Kuppusamy, Vladimir Diaz)
Remove duplicate Konstantin Andrianov
Add new significant contributors
(Ivana Atanasova, Kairo de Araujo, Martin Vrachev)

Remove unmaintained AUTHORS.txt, which lists many individuals and organisations that are/were not affiliated with 'python-tuf', but other projects in the TUF ecosystem (Thandy, Notary, etc.) and thus is not suited for this repository.
-> theupdateframework.io#38
Caveats:

Significant contributors means  top ~20 committers sorted by commit count (git shortlog -s).
The Acknowledgements section might miss significant contributors, if they contributed by other means than git commits in this repo.

PR also adds an automated reminder to update the Acknowledgements in the yearly maintainers doc review.
Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.348%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1122

Relevant Lines:
1138

💛  - Coveralls


VIM: Command for navigating around visible editors/viewlets/repl

VSCode Version: 1.10
OS Version: macOS

Trying to adopt navigation commands in list, they work pretty well and it doesn't require any code change in Vim extensions. Right now the only missing part is how we navigate to the visible viewlet or repl.
For split editors, right now the way to workaround is check the column of current editor, and try to switch to previous/next one when users press <C-w> hjkl. But users have no way to navigate to other part of VS Code by a generic command and we have no idea which component is visible from extension host.
A proper command can be something like
{
    "command": "navigate",
    "args": "up" // "down", "left"
}

It's similar to Tab in Accessibility Mode  or workbench.action.navigateEditorGroups, users can use limited commands to switch focus between visible areas in the workspace.

@rebornix to be clear we are talking about navigating these major parts of the VS Code UI, specifically:

the view in the side bar
the panel
up to three editors

Is there anything more to consider? What happens if you "navigate down" when you are already in the panel?

Also, what does it mean when editors are layout horizontally, would you then expect Arrow-Up/Down to navigate the editors and Arrow-Left/Right not?

Marking as help wanted, this would be a good area for a PR.

I'd like to give this a try if no one is on it yet :)

@bpasero my 2 cents to your questions

The command can be used to target visible parts, including the view in the side bar, the panel and editors. IMHO these three UI components are enough.
We only navigate between visible parts, so if the part is hidden, we can't navigate to it. Besides, we never open any part for users, that feature belongs to our Toggle xyz commands.
About navigating down if you are in the panel, I personal preference is doing nothing in this case. Others might prefer to loop though all the visible parts in a direction but it will be too complicated.
Since we are navigating through Visible parts, we should use Arrow keys as they are. When editors are layout horizontally, we should use Arrow-Up/Down.

This command only focuses on components that are already visible in the viewport and don't really care what they are. To some extent, it's a combination of Focus xyz Editor Groups/Focus Panel/Focus Sidebar, with a simple key cord <modifier>+arrows.

@misoguy go ahead :)

@rebornix thanks man! @misoguy yeah, go ahead and I can review, thanks 👍

I'm currently digging around to see how to implement this and have a few questions.

Where should I implement these actions? Because what i have understood so far is that each view(the viewlet, editor and panel) has its own actions implemented on their relative files.

Should each navigating action be implemented seperately? ex:

workbench.action.navigateLeft
workbench.action.navigateRight
workbench.action.navigateUp
workbench.action.navigateDown

If implemented, should these actions be mapped to a key <modifier>+arrows by default?

@misoguy I am fine to add these into https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/actions.ts#L512 and I agree we need one command for each, but I think we can have a base action that the others extend from to not duplicate code too much.
I think we do not need to map them to any keybinding out of the box, but we can always tweak that later.
As for how to navigate between views, I suggest you look how our view picker is able to navigate to views and panels: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/quickopen/browser/viewPickerHandler.ts#L1
There is also an IEditorGroupService that can be used to see how many editors are open ("editor stacks model") and to navigate between groups.

Thanks for the quick and detail explaination! I'll try to get on it as you said :)

This feature seems like there is more work than I anticipated.
I bumped into a question while working on it.
Is there an API to check if the current active editor is the first or last in a group? Something like
isFirstEditorOfGroup and isLastEditorOfGroup
If not, would it be better to add it in the interface IEditorInput or just implement it in the base action just for this action? (Its required for case when i want to jump from the first editor in the first group to the sidebar if the sidebar is at the left and vice versa when sidebar is at the right)

After looking more into the code, I got the feeling that instead of constantly calculating if current active editor is the first or last in a group, it is better to add an optional argument into interface IEditorStacksModel to stop cycling to the first/last group. I'll add a PR to explain this in code.

@misoguy @rebornix I think we do not want to cycle if at the end, or did I get that wrong in any way?
@misoguy btw you have to accommodate for the fact that the sidebar can be positioned to the right via the setting "workbench.sideBar.location: right".
The other setting to keep in mind is vertical vs horizontal orientation of editors via IEditorGroupService.getGroupOrientation()
And finally as for the position of the editor, you can just use IEditorStackModel.positionOfGroup() to convert a group into a number (Position is an enum). 0 will be the first, 1 the second and 2 the third.

@bpasero Currently the default behavior of next() and previous() (implemented with keybinding cmd+alt+left/right arrow)is to cycle when at the end/start of the stack if I'm not wrong, hence the option to stop cycling.
And as for the sidebar location being able to be at the right of the screen is already taken into account and the current setting can be read from IPartService.getSideBarPosition().
The vertical and horizontal orientation will also be considered when implementing. Thanks for the heads up about the function :)

Ah yeah good to have an option for next/previous then on the stacks model (can also be tested).
GroupOrientation pretty much is an enum with this declaration:
export type GroupOrientation = 'vertical' | 'horizontal';
Just not a number enum.

Sorry to ask so much but I got one more question while implementing.
If my focus is at the sidebar(on the left) when both the editor and panel is open, and if I were to navigate to the right, should I focus on the first editor or the panel?
I personality think that going to the editor is the right move but I'm asking just to be sure we are on the same page. :)

Left to right and top to bottom is my preference, which is going to the
editor instead of panel.
On Mon, Mar 6, 2017 at 16:26 Soo Jae Hwang<EMAIL_ADDRESS>wrote:

Sorry to ask so much but I got one more question while implementing.
If my focus is at the sidebar(on the left) when both the editor and panel
is open, and if I were to navigate to the right, should I focus on the
first editor or the panel?
I personality think that going to the editor is the right move but I'm
asking just to be sure we are on the same page. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/21669#issuecomment-284580371,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1heLIrliUW7o1htOx4FykwJ3w4m2FYks5rjKRGgaJpZM4MQW1z
.

I've implemented the navigation on the PR #22005, it'd be nice to get some comments on it :)

@misoguy
just checked out and tried out your code , looks good nice addition for us keyboard users
I'm working on a keyboard expand contract for visible parts may have to borrow from your similar stuff ;-)
Hope your review mine as well !

@cleidigh I'll gladly review when you have a PR ready! :)

Verify:

new commands workbench.action.navigateDown|Up|Left|Right can be used to navigate across all visible views (sidebar, panel, editors) in the order of their appearance
verify with sidebar left and right
verify with hidden sidebar and panel and multiple editor groups

Awesome.


Add Michele Salvador to Contributors list

I added my name to the list.
Hello!
😎

Hi  @michelesalvador, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

I felt very well with the tutorial.
It was not so easy to me, because I'm using Eclipse that comes without a console, but only with the user interface.
So I had to "translate" the console commands into the corresponding UI commands in Eclipse..


docker-image-cleaner 1.0.0-beta.2

Bring in https://github.com/jupyterhub/docker-image-cleaner/pull/51 to fix disk space issues on mybinder.org

This PR needs to adjust to the breaking changes as well, about changed env var names

Updated!

Now with this merged, there is automation that we can control in mybinder.org-deploy @manics, go for a "Run workflow" here https://github.com/jupyterhub/mybinder.org-deploy/actions/workflows/watch-dependencies.yaml. If the new dev version of this helm chart is available in the helm chart repo, it will be detected and a PR will be opened to bump.


Support LINE Room and Group, close #152

Codecov Report

Merging #154 (7d65975) into master (2bdd207) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   51.85%   51.85%
=======================================
  Files          19       19
  Lines         513      513
=======================================
  Hits          266      266
  Misses        218      218
  Partials       29       29

Impacted Files
Coverage Δ

models/user/user.go
56.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bdd207...7d65975. Read the comment docs.

Need to modify to avoid interrupt room and group normal chat

Codecov Report

Merging #154 (7d65975) into master (b3f6ba3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7d65975 differs from pull request most recent head 1e3ac6f. Consider uploading reports for the commit 1e3ac6f to get more accurate results

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   51.85%   51.85%
=======================================
  Files          19       19
  Lines         513      513
=======================================
  Hits          266      266
  Misses        218      218
  Partials       29       29

Impacted Files
Coverage Δ

models/user/user.go
56.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f6ba3...1e3ac6f. Read the comment docs.


[Windows] case-insensitive filesystem

Windows case-insensitive filesystem problem
I try to port lasem, I get an error
[125/138] Generating resources.h with a meson_exe.py custom command.
../src/buf-master-169b84daba/tests/resources.gresource.xml: Child process exited with code -1073741511.
[126/138] Generating resources.c with a meson_exe.py custom command.
../src/buf-master-169b84daba/tests/resources.gresource.xml: Child process exited with code -1073741511.

I could not understand for a long time, but I kind of found
example
git clone https://github.com/GNOME/lasem.git

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'tests/data/mathml/testsuite/Presentation/TablesAndMatrices/mtable/mtableAalign3.png'
  'tests/data/mathml/testsuite/Presentation/TablesAndMatrices/mtable/mtableaalign3.png'

can make default folder only buildtrees case sensitive?
code on powershell
for the current folder and the following ones, from the place where we are
(Get-ChildItem -Recurse -Directory).FullName | ForEach-Object {fsutil.exe file setCaseSensitiveInfo $_ enable}
disable
(Get-ChildItem -Recurse -Directory).FullName | ForEach-Object {fsutil.exe file setCaseSensitiveInfo $_ disable}

Since git is case sensitive, but windows doesn't, when you clone lasem in windows, it will overwrite case-sensitive files/directories. Because this is a Windows feature, I think your solution won't solve this problem. The only workaround is to notify the upstream to rename these files/directories.

Yes, I tried many different ways and methods, it did not help
windows does not work at all with the case-sensitive


Allow tx rebroadcast.

I now have a tx that is stuck in pending state. Would be great to have rebroadcast functionality in the tx detail modal for situations like this.

Same as #480


ERROR: DIAMOND finished abnormally

hi,
when I run the command ./CAT_pack/CAT contigs -c "/home/jiaojiao/cat/test.fasta" -d /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/ -t /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/  --verbose
there is a error. ERROR: DIAMOND finished abnormally. The diamond version is correct. And I set the tmpdir. So I do not know how to fix it.
The detailed output file is like this:
` # CAT v5.2.3.
CAT is running. Protein prediction, alignment, and contig classification are carried out.
Rarw!
Supplied command: ./CAT_pack/CAT contigs -c /home/jiaojiao/cat/test.fasta -d /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/ -t /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/ --verbose
Contigs fasta: /home/jiaojiao/cat/test.fasta
Taxonomy folder: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/
Database folder: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/
Parameter r: 10
Parameter f: 0.5
Log file: ./out.CAT.log

Doing some pre-flight checks first.
[2022-06-23 20:19:01] Prodigal found: Prodigal V2.6.3: February, 2016.
[2022-06-23 20:19:01] DIAMOND found: diamond version 2.0.6.

Full list of arguments:
IkwId: False
ORF2LCA_output_file: ./out.CAT.ORF2LCA.txt
alignment_file: ./out.CAT.alignment.diamond
block_size: 2.0
compress: False
contig2classification_output_file: ./out.CAT.contig2classification.txt
contigs_fasta: /home/jiaojiao/cat/test.fasta
database_folder: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/
db_fasta: None
diamond_database: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/2021-01-07.nr.dmnd
f: 0.5
fastaid2LCAtaxid_file: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/2021-01-07.nr.fastaid2LCAtaxid
force: False
index_chunks: 4
log_file: ./out.CAT.log
names_dmp: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/names.dmp
no_log: False
no_self_hits: False
no_stars: False
nodes_dmp: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/nodes.dmp
nproc: 2
one_minus_r: 0.9
out_prefix: ./out.CAT
path_to_diamond: diamond
path_to_prodigal: prodigal
prot_accession2taxid_file: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/2021-01-07.prot.accession2taxid.FULL.gz
proteins_fasta: ./out.CAT.predicted_proteins.faa
proteins_gff: ./out.CAT.predicted_proteins.gff
quiet: False
r: 10
sensitive: False
taxids_with_multiple_offspring_file: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/2021-01-07.nr.taxids_with_multiple_offspring
taxonomy_folder: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_taxonomy/
tmpdir: /home/jiaojiao/cat/CAT-master/log/
top: 50
verbose: True
Step list: ['predict_proteins', 'align', 'classify']

Ready to fly!

[2022-06-23 20:19:01] Importing contig names from /home/jiaojiao/cat/test.fasta.
[2022-06-23 20:19:01] Running Prodigal for ORF prediction. Files ./out.CAT.predicted_proteins.faa and ./out.CAT.predicted_proteins.gff will be generated. Do not forget to cite Prodigal when using CAT or BAT in your publication.
[2022-06-23 20:22:34] ORF prediction done!
[2022-06-23 20:22:34] Parsing ORF file ./out.CAT.predicted_proteins.faa
[2022-06-23 20:22:34] Homology search with DIAMOND is starting. Please be patient. Do not forget to cite DIAMOND when using CAT or BAT in your publication.
query: ./out.CAT.predicted_proteins.faa
database: /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/2021-01-07.nr.dmnd
mode: fast
top: 50
no-self-hits: False
number of cores: 2
block-size (billions of letters): 2.0
index-chunks: 4
tmpdir: /home/jiaojiao/cat/CAT-master/log/
compress: 0
diamond v<IP_ADDRESS> (C) Max Planck Society for the Advancement of Science
Documentation, support and updates available at http://www.diamondsearch.org
#CPU threads: 2
Scoring parameters: (Matrix=BLOSUM62 Lambda=0.267 K=0.041 Penalties=11/1)
Temporary directory: /home/jiaojiao/cat/CAT-master/log/
Opening the database...  [0.701s]
Percentage range of top alignment score to report hits: 50
Reference = /home/jiaojiao/cat/CAT_prepare_20210107/2021-01-07_CAT_database/2021-01-07.nr.dmnd
Sequences = 338965036
Letters =<PHONE_NUMBER>14
Block size =<PHONE_NUMBER>
Opening the input file...  [0.014s]
Opening the output file...  [0s]
Loading query sequences...  [0.099s]
Masking queries...  [0.615s]
Building query seed set...  [0.076s]
Algorithm: Double-indexed
Building query histograms...  [0.165s]
Allocating buffers...  [0s]
Loading reference sequences...  [31.767s]
Masking reference...  [98.739s]
Initializing temporary storage...  [0.002s]
Building reference histograms...  [46.232s]
Allocating buffers...  [0s]
Processing query block 1, reference block 1/62, shape 1/2, index chunk 1/4.
Building reference seed array... [2022-06-23 20:26:38] ERROR: DIAMOND finished abnormally.`
did you have some idea about it ?
Thank you！

I just ran into the same exact issue - 43 samples finished and 9 keep dying like this.  Any suggestions?

Trying to resurrect this as I am also having problems with Diamond giving ERROR: DIAMOND finished abnormally.
Did anybody have any luck getting to the bottom of this?

In case anyone encounters this error, I was able to successfully run CAT by updating the DIAMOND database to the latest, setting a --tmp directory to a directory with a lot of storage, and giving my system 60GB on memory in a pseudo-terminal. I am running this on a cluster


Webots simulation node

Now that the Crazyflie is in the latest version of Webots, it will be easier to start creating a ros2 node for the model and the python bindings.
There are some things to be solved:

Update the crazyflie-firmware to latest release and fix the cffirmware build
Figure out what to do with the parameters/logging (since that is not binded)
Implement to go, land, takeoff first (maybe first as setpoint commander and then with highlevel commander?)
Implement trajectory following.

Also, do we want to enable spawning from the yaml file as well? It should be possible to do from webots

The clock in the webots is published by this: https://github.com/cyberbotics/webots_ros2/blob/1cc1c68a31762d6a2628a2be9f1de5dfbf2353cf/webots_ros2_driver/webots_ros2_driver/ros2_supervisor.py#L128
In the #106 I actually removed that since I wrote my own supervisor driver, but it still worked for some reason... but probably will cause problems.


Change query input to API

In the diploid case, the input data should be a reference panel of phased haplotypes and a query of unphased genotypes (encoded as allele dosages). Currently, the API functions take queries of phased haplotypes.

I also tweaked the simulation parameters to get ref. panels and queries that meet certain criteria (e.g. enough sites but not too many).


lint: use latest golangci-lint from go.mod

/label docs-approved
/label px-approved
/label qe-approved
No need for the formal approvals, just a linting utility.

/lgtm


[Port] Fix HDFS node for Integrated auth (#12906)

Fixes #12905 - the casing was different so the check wasn't being done properly.

Pull Request Test Coverage Report for Build 305256250

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.259%

Totals

Change from base Build 302680677:
0.0%

Covered Lines:
19493

Relevant Lines:
46521

💛  - Coveralls


[Event Request] table 1382 "Item Templ." - OnAfterCopyFromTemplate

Could you please add the following event?
procedure CopyFromTemplate(SourceItemTempl: Record "Item Templ.")
begin
    CopyTemplate(SourceItemTempl);
    CopyDimensions(SourceItemTempl);
    //+EVENT
    OnAfterCopyFromTemplate(SourceItemTempl, Rec);
    //-EVENT
end;

[IntegrationEvent(false, false)]
local procedure OnAfterCopyFromTemplate(SourceItemTempl: Record "Item Templ."; var TargetItemTempl: Record "Item Templ.")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52552.


pypy: re-enable PyFunction on 3.8+

PyPy fixed the crashes associated with `PyFunction  in PyPy 7.3.10 (for 3.8+) - which I think is to be released shortly. So I think we should re-enable this API and treat it as a PyPy bug which users can mitigate by updating their PyPy.

bors r+


Rack Span not available in Rack::BodyProxy

Rack::BodyProxy defers executing a user specified block until after the request is complete, however the Rack instrumentation middleware closes the span before the block is evaluated and then detaches the current context.
When users try to access the current span in the block, Rack returns an invalid span. In the snippet below I was able to reproduce the issue using RSpec as a test harness:
require "spec_helper"

RSpec.describe "Rack::BodyProxy Integration" do
  include Rack::Test::Methods

  let(:app) do
    Rack::Builder.new {
      use OpenTelemetry::Instrumentation::Rack::Middlewares::TracerMiddleware
      run lambda { |_arg|
        puts "app.call #{OpenTelemetry::Instrumentation::Rack.current_span.context.hex_trace_id}"
        body = Rack::BodyProxy.new([]) { puts "BodyProxy.close #{OpenTelemetry::Instrumentation::Rack.current_span.context.hex_trace_id}" }
        [
          200,
          { "Content-Type" => "application/json" },
          body,
        ]
      }
    }
  end

  it "does something" do
    get "/"
    expect(last_response).to be_ok
  end
end

In the mix of the spec output you can see that the trace id is that of an INVALID_SPAN:
Rack::BodyProxy Integration
app.call 65a385eada410a721a79431171960814
BodyProxy.close<PHONE_NUMBER>0000000000000000000000
  does something

Finished in 0.08231 seconds (files took 2.31 seconds to load)
1 example, 0 failures

I am unsure what the correct behavior should be here but this is related since it is basically my problem where we are unable to correlate Rack Requests to Traces when using Rack::BodyProxy or any of its descendants. https://github.com/DataDog/dd-trace-rb/pull/1746

Is using Rack::Events the best way to handle this going forward? https://www.rubydoc.info/gems/rack/Rack/Events

Order
on_start is called on the handlers in the order that they were passed to the constructor. on_commit, on_send, on_finish, and on_errorare called in the reverse order.on_finishhandlers are called inside anensureblock, so they are guaranteed to be called even if something raises an exception. If something raises an exception in aon_finish` method, then nothing is guaranteed.

I didn't know about this before today; it's interesting. (To be fair, the "things I don't know" vastly outnumber the things I do know. 😆 )
I think Rack::Events might be a sensible way to do it, and it looks like it's been in Rack since 2.0 (or, around 2015-2016). I think it would be safe to rely on it if we wanted. However, I don't know if we'd be able to support precisely the same features as our current rack instrumentation. The documentation for this explicitly calls out:
  ### This middleware provides hooks to certain places in the request /
  # response lifecycle.  This is so that middleware that don't need to filter
  # the response data can safely leave it alone and not have to send messages
  # down the traditional "rack stack".

... and we do allow things like logging some response headers. But it may be worth investigating; and it may be that we can start / finish spans inside these hooks and then attempt to update the span from inside middleware like we do today.

I think we need both!
So far in my initial spike the events hooks are doing exactly what we expect.
on_start creates a recording span
on_finish closes the span.
on_error records exceptions!
We can keep a in stack middleware that adds headers to the response.

That's exciting, then! The only things that come to mind now are:

This may change the overall duration of rack spans; perhaps they may look a little longer than they used to. I don't know that this is actually a bad thing, though.
I have a vague, likely-unfounded and thoroughly-unresearched concern that we may end up annotating the wrong span somehow from the middleware. But... that's probably me just being a worrywart for no reason.
The "frontend" span stuff... I never really understood precisely what that was all about, but we probably don't want to break it. 😆

The frontend span is a stand-in for adding spans for proxies, LB, or webservers like nginx that may not have instrumentation.
That way you can visualize queue time using X-Request-Start offset by the current time.

A little spike... this gets us the bear minimum.
class MyEvents
  include Rack::Events::Abstract
  def on_start(request, response)
    extracted_context = OpenTelemetry.propagation.extract(
      request.env,
      getter: OpenTelemetry::Common::Propagation.rack_env_getter
    )
    span = OpenTelemetry.tracer_provider.tracer("rack").start_span("HTTP #{request.request_method}}", with_parent: extracted_context, kind: :server)
    ctx = OpenTelemetry::Trace.context_with_span(span)
    request.env["otel.context.token"] = OpenTelemetry::Context.attach(ctx)
  end

  def on_finish(request, response)
    span = OpenTelemetry::Trace.current_span
    span.finish
    OpenTelemetry::Context.detach(request.env["otel.context.token"])
  end
end

Something I do not quite understand about our current implementation is why Rack has its own Context Key for Current Span and why its sets its own Current context instance instead of using the default Context key.
Do you know anything about that?

OK after some spelunking I got the gist of it.
The same object instance is being added to multiple Context keys that happen to have the same name current-span, this is a convenience method so that other instrumentations are able to look up the Rack Span instance since it may be different from the current span context.
I will need to preserve that behavior for sure.

I believe this is the final incantation:
# frozen_string_literal: true

require "spec_helper"

class MyEvents
  include Rack::Events::Abstract
  def on_start(request, response)
    extracted_context = OpenTelemetry.propagation.extract(
      request.env,
      getter: OpenTelemetry::Common::Propagation.rack_env_getter
    )
    span = OpenTelemetry::Instrumentation::Rack::Instrumentation.instance.tracer.start_span("HTTP #{request.request_method}}", with_parent: extracted_context, kind: :server)
    ctx = OpenTelemetry::Trace.context_with_span(span)
    rack_ctx = OpenTelemetry::Instrumentation::Rack.context_with_span(span, parent_context: ctx)
    request.env["otel.context.token"] = OpenTelemetry::Context.attach(ctx)
    request.env["otel.context.rack_token"] = OpenTelemetry::Context.attach(rack_ctx)
    request.env["otel.span"] = span
  end

  def on_finish(request, response)
    puts "on_finish"
    begin request.env["otel.span"].finish; rescue nil; end
    begin OpenTelemetry::Context.detach(request.env["otel.context.token"]); rescue nil; end
    begin OpenTelemetry::Context.detach(request.env["otel.context.rack_token"]); rescue nil; end
  end
end

RSpec.describe "Rack::BodyProxy Integration" do
  include Rack::Test::Methods

  before do
    OpenTelemetry::SDK.configure
  end

  let(:app) do
    Rack::Builder.new {
      use Rack::Events, [MyEvents.new]
      run lambda { |_arg|
        puts "#{OpenTelemetry::Trace.current_span.context.hex_trace_id} #{OpenTelemetry::Trace.current_span.context.hex_span_id} recording? #{OpenTelemetry::Trace.current_span.recording?} | before"

        OpenTelemetry.tracer_provider.tracer("rack").in_span("test") do |span|
          puts "#{span.context.hex_trace_id} #{span.context.hex_span_id} recording? #{span.recording?} | action explicit span"
          puts "#{OpenTelemetry::Trace.current_span.context.hex_trace_id} #{OpenTelemetry::Trace.current_span.context.hex_span_id} recording? #{OpenTelemetry::Trace.current_span.recording?} | action implicit span"

          body = Rack::BodyProxy.new([]) do
            puts "#{span.context.hex_trace_id} #{span.context.hex_span_id} recording? #{span.recording?} | BodyProxy.close closure"
            puts "#{OpenTelemetry::Trace.current_span.instance_variable_get("@parent_span_id").unpack1('H*')} | BodyProxy.close closure parent_span_id "
            puts "#{OpenTelemetry::Instrumentation::Rack.current_span.instance_variable_get("@parent_span_id").unpack1('H*')} | BodyProxy.close rack parent_span_id "

            puts "#{OpenTelemetry::Trace.current_span.instance_variable_get("@parent_span_id").unpack1('H*')} | BodyProxy.close parent_span_id "
            puts "#{OpenTelemetry::Trace.current_span.context.hex_trace_id} #{OpenTelemetry::Trace.current_span.context.hex_span_id} recording? #{OpenTelemetry::Trace.current_span.recording?} | BodyProxy.close Trace.current_span "
            puts "#{OpenTelemetry::Instrumentation::Rack.current_span.context.hex_trace_id} #{OpenTelemetry::Instrumentation::Rack.current_span.context.hex_span_id} recording? #{OpenTelemetry::Instrumentation::Rack.current_span.recording?} | BodyProxy.close Rack.current_span"
          end

          [
            200,
            {
              "Content-Type" => "application/json",
            },
            body,
          ]
        end
      }
    }
  end

  it "does something" do
    get "/", {}, { "traceparent" => "00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01" }
    expect(last_response).to be_ok
  end
end

I see a context stored at request.env["otel.context"] but then detached with request.env["otel.context.token"]. Those hash keys ought to be the same, right?

Detach goes in reverse order from the attaches/creations, yea? So should it be …

    request.env["otel.context.token"] = OpenTelemetry::Context.attach(ctx)
    request.env["otel.context.rack_token"] = OpenTelemetry::Context.attach(rack_ctx)

    begin OpenTelemetry::Context.detach(request.env["otel.context.rack_token"]); rescue nil; end
    begin OpenTelemetry::Context.detach(request.env["otel.context.token"]); rescue nil; end


Fix autoprovisioning with spot nodes

Fixes / Features

Fixes workload rendering when using spot, without this change xpk workload create errors like:
[XPK] Waiting for `Creating Workload`, for 0 seconds
error: error parsing /tmp/tmp242uhnfs: error converting YAML to JSON: yaml: line 33: could not find expected ':'
[XPK] Task: `Creating Workload` terminated with code `1`

Adds required pod tolerations when using node auto-provisioning with spot nodes.  Without the tolerations cluster autoscaler will not create new spot node pools.

Testing / Documentation
Node auto-provisioning with spot

Created a xpk cluster with --spot flag.
Created a workload with a different topology than the cluster default.
Observed a nodepool being created with the new workload topology using spot TPU nodes.

Node auto-provisioning without spot
TODO
Not auto-provisioning
TODO

[ y/n ] Tests pass
[ y, not needed ] Appropriate changes to documentation are included in the PR

https://github.com/google/xpk/pull/187


calibrated timestamps sample

Description
Add a sample showing how to use Calibrated Timestamps in an existing sample.
Fixes #
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

This crashes for me at runtime in the timestamps_begin function in the following line:

The timestamps.clear() there looks wrong, as that vector is then never resized and always has zero elements

This crashes for me at runtime in the timestamps_begin function in the following line:

The timestamps.clear() there looks wrong, as that vector is then never resized and always has zero elements
Same for timestamps_end. The vector is cleared here too and never resized before it's accessed.

Ohh! I forgot to recall that timestamps vector must  be resized and then pass its reference/data to vkGetCalibratedTimestampsEXT.. And for some reason it doesn't crush from my end...
But you are right! Good catch and thanks!

This PR is ready for review.

I tend to agree this sample doesn't fully exercise calibrated timestamps.  However, it does a fairly good job of demonstrating how to use them which I think is a decent goal.  I'll have Jeremy do another pass at increasing the scope a little bit more.  My only concern is about ensuring this sample's core is to teach specifically how to do calibrated timestamps and not get too complex to ultimately be useful.  Thanks for the review!

Merging w/ 3 approvals


Deadlock when deleting images

When I run docker rmi $(docker images -q -f dangling=true) on one terminal while at the same time call the image list API via curl -v http://<IP_ADDRESS>:2375/images/json on another terminal, the daemon seems to be running into a dead lock.
goroutine 139 [semacquire, 60 minutes]:
sync.(*RWMutex).RLock(0xc2082d7e00)
	/usr/local/go/src/sync/rwmutex.go:36 +0x5f
github.com/docker/docker/pkg/truncindex.(*TruncIndex).Get(0xc2082d7e00, 0xc208410580, 0x40, 0x0, 0x0, 0x0, 0x0)
	/go/src/github.com/docker/docker/pkg/truncindex/truncindex.go:111 +0x12b
github.com/docker/docker/graph.(*Graph).Get(0xc20817cb80, 0xc208410580, 0x40, 0xc2092074c0, 0x0, 0x0)
	/go/src/github.com/docker/docker/graph/graph.go:173 +0x69

......

goroutine 230 [semacquire, 60 minutes]:
sync.(*RWMutex).Lock(0xc2082d7e00)
    /usr/local/go/src/sync/rwmutex.go:87 +0xa4
github.com/docker/docker/pkg/truncindex.(*TruncIndex).Delete(0xc2082d7e00, 0xc209947640, 0x40, 0x0, 0x0)
    /go/src/github.com/docker/docker/pkg/truncindex/truncindex.go:80 +0x56
github.com/docker/docker/graph.(*Graph).Delete(0xc20817cb80, 0xc2093ed100, 0x40, 0x0, 0x0)
    /go/src/github.com/docker/docker/graph/graph.go:360 +0x125
github.com/docker/docker/daemon.(*Daemon).imgDeleteHelper(0xc2080efce0, 0xc20888fb45, 0xc, 0xc2093e02a0, 0x1, 0x0, 0x0)
    /go/src/github.com/docker/docker/daemon/image_delete.go:120 +0xea5
github.com/docker/docker/daemon.(*Daemon).ImageDelete(0xc2080efce0, 0xc20888fb45, 0xc, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /go/src/github.com/docker/docker/daemon/image_delete.go:19 +0x122
github.com/docker/docker/api/server.(*Server).deleteImages(0xc208035300, 0xc20888fb39, 0x4, 0x7fb50589f038, 0xc208701540, 0xc208eff6c0, 0xc20888fcb0, 0x0, 0x0)

The full stack via pprof is here https://gist.github.com/mountkin/079210d66370ed99bc03
I also encountered another deadlock while I ran docker build on one terminal and call the image list API on another terminal.
After bisecting I found before cc955ae73c8aa234e0c41bdb65f111be79b32b90 everything is ok.
I'm not sure if this is related to @vbatts's issue #15087

To make @GordonTheTurtle happy,
docker info
Containers: 26
Images: 933
Storage Driver: aufs
 Root Dir: /root/docker/aufs
 Backing Filesystem: extfs
 Dirs: 1028
 Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-24-generic
Operating System: Ubuntu 14.04.1 LTS
CPUs: 2
Total Memory: 994 MiB
Name: local-dev
ID: LD3D:36J2:EXD2:2TA6:DJYU:ZLPK:W3BS:VHHH:VFA2:URJD:OID6:QJ2Y
Debug mode (server): true
File Descriptors: 31
Goroutines: 52
System Time: 2015-07-31T14:46:00.021003093+08:00
EventsListeners: 0
Init SHA1:
Init Path: /usr/bin/docker
Docker Root Dir: /root/docker
Username: csphere
Registry: https://index.docker.io/v1/

docker version
Client:
 Version:      1.8.0-dev
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   500a314
 Built:        Fri Jul 31 06:45:08 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.0-dev
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   500a314
 Built:        Fri Jul 31 06:45:08 UTC 2015
 OS/Arch:      linux/amd64

uname-a
Linux local-dev 3.13.0-24-generic #47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@calavera is this only reproducible on master, or also on 1.8-rc1?

@thaJeztah I haven't tested 1.8.0-rc1 yet. Will have a try later.
I opened a PR #15196, let's see if it can be reproduced successfully.

Thanks for the extensive reporting, @mountkin, let me know if it's reproducible on rc1, then I'll add it to the milestone

@thaJeztah  seems like it's blocking https://jenkins.dockerproject.org/job/Docker-PRs/13020/console

@mountkin hm, alright. I'll add it to the milestone - thanks!

@thaJeztah You're welcome.
I can confirm that 1.8.0-rc1 is also affacted.

thanks for opening this issue and bisecting the changes @mountkin. I think as a precaution measure I'm going to revert that commit, it was only a code improvement, kinda.

This is fixed in https://github.com/docker/docker/pull/15207
Thanks again @mountkin! If you have time to confirm if https://github.com/docker/docker/pull/15207 resolve the issue, that would be great!


Add metrics on encrypt

Why
Track count of encryption calls
How
Call to metrics proxy

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


StudyGroupTag - Expand constraint on study group names

Fixes #124
Study group names only accept alphanumeric characters. Let's also accept dashes "-" to increase the expressiveness of study group tags.
Affected commands:
Add: add ... t/P90-Control
Edit: edit 1 t/P90-Experimental -t/P90-Control
Find: find t/P90-Control P90-Experimental

LGTM!


Fix perf tuning doc typo

Updated a description in the performance tuning doc
Regenerated documentation

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3955/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3958/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


Update README.md

Fixed some grammatical issues in the README.

I have a larger pull request in progress that I will open here later.


RHOARDOC-867: Consolidated module names, anchor IDs and file names

The change does the following:

For all the procedure modules (files that more-or-less comply with the Modular Documentation Guidelines), it takes the heading and modifies the anchor ID and file name to match it.

The notable exception to that rule is the usage of certain attributes in headings like name-mission-* or parameter-*-name, which are not used in the anchor IDs and file names. The ugliness isn't worth it IMO. If you think we should stick to the rules, though, I will fix it and regenerate the docs.
All references (xrefs) and include directives are updated to match too.

Adds the _{context} suffix to all anchor IDs in the modules. The suffix will likely start to be mandated in the Modular guidelines, so it's a step we may want to do anyway.

All the references are updated to match too.

Certain parameters needed to be updated to match the new file names.
Some headings were modified to avoid clashes with existing or identically-named modules.

This PR partially resolves RHOARDOC-867.

I'm gonna abstain :-) Will verify as part of the diff check.

You mean rest-http, not rest-api? (To be frank, http-api is by far the best description of what it is, but that ship has long sailed.)

@rhoads-zach What occurrence are you referring to? If it's the {parameter-mission} value, that should not be visible to the user in the rendered document AFAICT as it is only used in an include directive in the assembly_building-and-deploying-the-booster-to-openshiftlocal assembly to select a file name.

@Ladicek you're correct.
@tradej comment withdrawn, i double checked something and the link is unaffected

@tradej is this good to merge?

@rhoads-zach To my best knowledge, yes.
BTW this will be followed upon with other PRs much to the same effect (with concepts, references, assemblies, and other files currently not modular).

thanks @tradej merging.


[Bug] Crashlytics - Every version 8.10.0 or newer breaks when using IL2CPP (iOS AND Android)

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.25f1 (but doesn't seem to matter. Also tested 2020.3.36f1, 2021.3.5f1, etc..)
Firebase Unity SDK version: 8.10.0 and newer
Source you installed the SDK: .unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component: Crashlytics (Auth, Database, etc.)
Other Firebase Components in use: None (Auth, Database, etc.)
Additional SDKs you are using: None (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Mac (Mac, Windows, or Linux)
Platform you are targeting: iOS and Android (iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP (Mono, and/or IL2CPP)
Pre-built SDK from the website or open-source from this repo: _____

[REQUIRED] Please describe the issue here:
CRASHLYTICS DOES NOT WORK WHEN USING IL2CPP
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Steps to reproduce:
New Unity project
Add crashlytics
Follow the crashlytics quick start and add the exception-every-60-sec script.
Test on iOS or Android
NOTE - Make sure you switch Android to IL2CPP (Mono works)
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
100%
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Exception not reported
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
// TODO(you): code here to reproduce the problem

NOTE - The issue does not exist in 8.9.0 or 8.7.0

Hi @nitzanwilnai,
I noticed that you filed this ticket as well in the quickstart repo. I'll be closing this so that all our discussions can just be in that thread.


Opposite rules

See https://github.com/NCATSTranslator/Feedback/issues/154
User asks for increases, we return decreases.
This is not wrong in the sense that it there will often be both increases and decreases edges between the same entities.  So AMIE+ is right to flag it.  But it's counter intuitive enough that we want to remove it.  This is similar to when we take out contraindicated rules from treats.

Hand review the rules to remove these
Develop an automated part of the process for culling opposites.  Probably easier now with qualifiers.

So, do we remove entailment?  Do we remove entailment that conflicts with the outcomes?  Do we remove the entire rule?  If we keep the rule, I think we want some kind of way to say that results from a more general rule should score lower.


Assignment to arrayref and hashref changes the location of the object so the original object is not updated

Assignment to arrayref and hashref changes the location of the object so the original object is not updated.

Fixed in v1.024 (commit message is missing!)


pip install fails on deb and win

Hi, thanks for sharing this!
I tried a relatively simple install process on a .deb system:
conda env create npc python=3.8
conda activate npc
pip install -r requirements.txt

And it fails wtih:
libraries mkl_rt not found in ...

I've also tried installing the Intel MKV libraries, but no success

I have download these requirements in Archlinux successfully, so I recommend you use python==3.7.

thanks @StudyingLover that works


small fixes following #21

This PR:

uses intersect_with_plane() from newest vedo instead of the backported function as there is no longer the need to duplicate code from an updated dependency thanks to #21
fixes some vedo function calls still using lowerCamelCase instead of snake_case

Additionally I changed Plane.from_norm() typing to return a Self type instead of a vd.Plane because, well, that's what it returns. If this is a problem because typing.Self is not in previous python version, I can just remove the type hinting

Hi @carlocastoldi, thanks for this PR!
We're currently supporting Python 3.9, 3.10 & 3.11, so unfortunately we can't use any functionality that's only available in newer versions. mypy is also complaining with:
brainglobe_heatmap/plane.py:1: error: Module "typing" has no attribute "Self"  [attr-defined]
brainglobe_heatmap/plane.py:1: note: Use `from typing_extensions import Self` instead
brainglobe_heatmap/plane.py:1: note: See https://mypy.readthedocs.io/en/stable/runtime_troubles.html#using-new-additions-to-the-typing-module
Found 1 error in 1 file (checked 17 source files)

Would you mind fixing (or removing) the typing, then I'll review.


Disable open doc button when not inspecting anything

The button is hidden initially (and will also be hidden when the current object is not Resource or Node according to the code):

The button will become visible when something is selected:

But after deselecting, the button remains visible. Clicking it has no effect.

This PR disables the button in the first and last case.

Wouldn't it be better to have it be always visible, but disabling it just like button below?

Yeah, I was disabling it at first. But then I saw it was hidden in other invalid cases, so I changed to hidding it in order to be consistent.
CC @pycbouh

Yeah, I was disabling it at first. But then I saw it was hidden in other invalid cases, so I changed to hidding it in order to be consistent.

I think I would make it disabled in both cases, instead of hidden.

Thanks!

Cherry-picked for 3.4.


Costing superconductors in all coils using dollars per kAm rather than dollars per kg

In GitLab by @schislet on Apr 14, 2020, 09:01
Associated branch: https://git.ccfe.ac.uk/process/process/-/tree/issue-1037
Summary
The superconducting industry uses the metric $/kAm as the costing figure of merit for superconductors rather than $/kg. A switch has been added into costs.f90 such that when supercond_cost_model = 1, the superconductor costs are calculated using this metric rather than the existing $/kg metric (which is selected by default for supercond_cost_model = 0).
The cost of the superconductor is a function of the operating field, temperature and strain (though we shall assume that the strain on the superconductor itself is zero):
[Strand/Tape Cost ($/kAm) under operating conditions] = [Strand/Tape Cost ($/kAm) under reference conditions] * [Strand/Tape Jc under reference conditions] / [Strand/Tape Jc under operating conditions]
The strand/tape costs ($/kAm) under reference conditions were taken from Cooley 2005 [1] and Cooley 2016 [and back converted into 1990 US$ assuming standard CPI inflation. At 6 T and 4.2 K these are 4.8 $/kAm for Nb3Sn strands (calculated from table 3 of [1]), 1.0 $/kAm for Nb-Ti (calculated from table 2 of [1]) and 47.4 $/kAm for REBCO (calculated from slide 3 of [2]).
The strand/Tape Jcs under reference conditions were calculated by manually calling the critical current scaling laws contained between superconductors.90 and sctfcoil.f90 at 6 T and 4.2 K. The Jcs were collected into the list variable j_crit_str_0.
The strand/tape Jcs under operating conditions are acquired from the variables j_crit_str_pf, j_crit_str_cs and j_crit_str_tf which pull the strand Jcs from sctfcoil.f90 and pfcoil.f90 when they are invoked inside the pfcoil and ohcalc subroutines in pfcoil.f90 and inside the tfspcall subroutine inside sctfcoil.f90.
From there
[Cost ($/m)] = [Cost ($/kAm) under operating conditions] * [Cable peak operating current (kA)]
The cable peak operating currents are acquired from abs(ric(i)/turns(i)) for the pf conductor, abs(ric(nohc)/turns(nohc)) for the cs conductor and cpttf for the tf conductor (converted to kA).
[1] Cooley_2005_Cost_of_strands_0953-2048_18_4_R01.pdf
[2] Cooley_2016.pdf
Checklist
After implementing issue do the following

[x] Run test suite
[ ] Does it change the output? If so, give justifications.
[ ] Does it change the baseline 2019 run? (you may need to run on Freia)
[ ] Merge request created

Hi Jack, I notice that you have created this variable:

superconductor strand critical current density under operating conditions in central solenoid (A/m2). Necessary for the cost calculation in $/kA m

I would have thought that the cost in $/(kA m) was based on the critical current for standard test conditions, not the operating conditions, which obviously the manufacturer doesn't know.
Have I got the wrong end of the stick?

That's calcuated in pfcoil.py based on the temperature and field calculated during a run. The variable j_crit_str_0 in tfcoil_variables.f90 is the reference conditions.

OK, I see.


Fix unhandled error on client from SettingOption.ts

Relevant components:

[ ] Signalling server
[ ] Common library
[X] Frontend library
[ ] Frontend UI library
[ ] Matchmaker
[ ] Platform scripts
[ ] SFU

Problem statement:
I have been having unhandled errors in production and found this update solves the issue we were having originating from SettingOptions.ts:

Solution
The was an issue with the options not being ready in time, I am not sure if this is the best way to solve the bug as it may be better to solve elsewhere in the codebase but this has fixed the issue for us and now I don't get anymore production errors, if someone else knows a better fix then go for it.
Testing
I have been running this code in productions for weeks now and no more issues that were occurring previously at least every few days.

Thanks for your contribution @richardFocus - I ended up having to change a bunch of stuff related to this because of some other work I was doing - you can see the landed result in: https://github.com/EpicGamesExt/PixelStreamingInfrastructure/pull/324


Inheritance and signing server:

You can add a SS only after you have added two keys.The message on the key selection will be "Add at least 2 keys to access".
You can only add a IKS once a 3 of 5 is done.The message will be " create a 3 of 5 Vault to add this key".

Signing server message on the key selection is missing.

Verified this issue on keeper app v 1.8.8(273)


⚠ Bofrost.at has degraded performance

In 376d106, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1190 ms

Resolved: Bofrost.at performance has improved in 97af923 after 36 minutes.


It fails when I try to install node and pnpm at the same time

What version?
0.41.7
Which command?
proto install node pnpm
What happened?
Error: proto::version::unresolved

  × Failed to resolve pnpm to a valid supported version for Node.js.
  help: Does this version exist and has it been released?

Trace logs?
No response
Operating system?
MacOS
Architecture?
arm64

@mio-19 You can't install multiple tools like this, they would need to be separate commands: proto install node && proto install pnpm.
Or you can add the versions to .prototools and then run proto install.

If this is the case, it would be helpful if the error message tell me that installing multiple tools like this is not supported

The second argument to proto install is the version, and in this case, "pnpm" is being treated as a version alias, like "latest" or "next". We have no way of intercepting the error message here.


renderer-preact: fix caching of auto defined elements

If there is a linked issue, mention it here.

[x] Bug
[ ] Feature

Requirements

[x] Read the contribution guidelines.
[x] Wrote tests.
[ ] Updated docs and upgrade instructions, if necessary.

Rationale
A new component was being defined every time a component constructor was rendered
Implementation
Set preactNodeName prop to the actual constructor and not the descendant
Other
Renamed test components to more descriptive names

Rookie mistake of shadowing! Thanks for catching :). I've restarted the build; I think it was just a travis glitch.


Shorter cache path for unpacking package

avoids windows error 206: the filename or extension is too long
by not nesting folders in cache arbitrarily deep and use a sha256 of the potentially deep path instead
note: This PR does not 'fix' caching in general, it is still file (uri/path) name based.

LGTM, I am just gonna merge.


New nex drops do not pull ge price info

🐛 Bug Report
New items with Nex update do not have +price information

bump, would be sweet if they had a value

Bumping aswell, still an issue

Fixed now, hampog


issue when hosting cl4 on an nginx-based server

I currently have an nginx-based server from DiscordBotHosting with pterodactyl panel, but when i try to enter the ip that it gave me it always returns
OSError: [Errno 99] error while attempting to bind on address ('the ip', the port): cannot assign requested address
I know it's not the server's fault because i've hosted tons of things to that ip and port without fail, it's only this..
This is my code:
from cloudlink import cloudlink
cl = cloudlink()
cls = cl.server()

cls.run(ip = "insert my servers ip hete", port = insert port here)

Am i doing something wrong or is this an issue with the code?
edit: when i use <IP_ADDRESS> it DOES work, but only on unsecured websocket which is not preferrable

I'm honestly not sure. If it's raising an OSError, it's beyond the scope of Cloudlink itself. I suggest you share this with aaugustin/websockets instead since that is what CL4 runs on.

alright then, i'll check that out then


Support for delimited strings

Several different forms of delimited string exist, both nesting and non-nesting.  It would be good to add them.

This is fixed now.


Remember application state on login

Currently, when the user logs in to KorAP, all search information is lost. This is not wanted, in case the user logs in to avoid a certain query rewrite. Therefore, all application state should be remembered during log in.

Fixed in https://github.com/KorAP/Kalamar/commit/429aeda01f85fd132933b7f6d02ff2b83f7777c9


Add ability to set whether an ACCT is open or not

[x] Add open acct to risks form
[ ] Fix toggle with nested radio button issue(@gtvj)
[x] Ensure ACCT is cleared if radio button is set to 'no' or cleared
[x] Add to managing risks feature spec
[x] Add ACCT to PDF output

===========================
Web App

===========================
#### PDF

@cesidio ready for review!


Card does not auto adapt to device switching to dark mode

This has been in tested only in the simulator:

Start the app using slide over card
switch the app into dark or light mode (inverse of where you started)
the slide over card does not adapt to the new ui mode

The slide over card will adapt properly on the mode that was started on, just not the new mode.
I intend to lodge a PR as part of my use of the library

Sorry for the late answer I wasn't notified.
Can you make a PR?


Debugpaste: needs to be entirely transparent to end user.

As brought up by @BrannonKing in a slack DM we don't want to introduce a vector for virus injection.  So what we're going to do is potentially have our own fork of debugpaste for lbry or consider other options not currently in this issue.
I was thinking that perhaps I could automate the entire debugpaste compile process on a fully transparent GitLab CI/CD build process with static hashes so that people can monitor the supply-chain.

Abandoning this for now.


EDID Processing API and proofreading

I rebased it against v1.0-dev because of merging PlantUML stuff.


Can't index into anndata object with integer obs_names

Trying to index into an AnnData object which has integer obs_names throws an assertion error. I expected either not allowing the construction an object with integer obs_names or allowing indexing into them.
Here's a quick example. First I instantiate an AnnData object, give it integers for observation names, then get an error when I try to index into it:
>>> import scanpy.api as sc
>>> import pandas as pd
>>> import numpy as np
>>> adata = sc.datasets.krumsiek11()
Observation names are not unique. To make them unique, call `.obs_names_make_unique`.
... storing 'cell_type' as categorical
>>> adata.obs_names = np.array(range(adata.n_obs))
>>> adata[:, ['Gata2', 'Gata1']]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1211, in __getitem__
    return self._getitem_view(index)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1214, in _getitem_view
    oidx, vidx = self._normalize_indices(index)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1190, in _normalize_indices
    obs = _normalize_index(obs, self.obs_names)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 231, in _normalize_index
    'Don’t call _normalize_index with non-categorical/string names'
AssertionError: Don’t call _normalize_index with non-categorical/string names

This error in indexing can be recovered by using a pandas.RangeIndex for the observation names:
>>> adata.obs_names = pd.RangeIndex(stop=adata.n_obs)
>>> adata[:, ['Gata2', 'Gata1']]
View of AnnData object with n_obs × n_vars = 640 × 2
    obs: 'cell_type'
    uns: 'iroot', 'highlights'

However, range indexes are frequently implicitly replaced with integer indexes:
>>> adata_norm = sc.pp.normalize_per_cell(adata, copy=True)
>>> adata_norm.obs_names
Int64Index([  0,   1,   2,   3,   4,   5,   6,   7,   8,   9,
            ...
            630, 631, 632, 633, 634, 635, 636, 637, 638, 639],
           dtype='int64', length=640)
>>> adata_norm[:, ['Gata2', 'Gata1']]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1211, in __getitem__
    return self._getitem_view(index)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1214, in _getitem_view
    oidx, vidx = self._normalize_indices(index)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 1190, in _normalize_indices
    obs = _normalize_index(obs, self.obs_names)
  File "/usr/local/lib/python3.6/site-packages/anndata/base.py", line 231, in _normalize_index
    'Don’t call _normalize_index with non-categorical/string names'
AssertionError: Don’t call _normalize_index with non-categorical/string names

Thanks!

Just cause I feel like my current work-around is silly (converting the integer obs_names to strings), I was looking into why this is happening. Am I correct in thinking the assertion I'm triggering was added since indexing into an AnnData object with a numeric is supposed to be positional, like pandas .iloc method, while indexing with a string/ categorical is supposed to behave like .loc?

I added this warning when people try to work with non-string indices: https://github.com/theislab/anndata/commit/51be5d85e62b1aa19d6f55ffc21aedbe9628c4c5.

Hi @falexwolf, @ivirshup ,
I was trying to use BBKNN and got this error when trying to concatenate different datasets (see here). Could you please clarify how you managed to fix that?
Thank you!

Sorry about this bug! It might be related to the objects having integer indices: we shouldn't have an error thrown, I guess. But previously, this was presumably inconsistent behavior. @flying-sheep, did you add the following line at some point to _normalize_index, which triggers the error:
assert names.dtype != float and names.dtype != int, \
    'Don’t call _normalize_index with non-categorical/string names'


CI: Use jruby-<IP_ADDRESS>

This PR updates the CI matrix to use latest JRuby, <IP_ADDRESS>.
JRuby <IP_ADDRESS> release blog post

👋 @pxlpnk If we get to green here, perhaps we can merge this?
(Haha, perhaps we are in the twilight years of using Travis for this project.)

@olleolleolle could you rebase on master and add this to GH actions? Would love to get this in.

Well, @iloveitaly, jruby-9.2 becomes "latest possible 9.2 JRuby" in the ruby/setup-ruby GitHub Action, so all this is already taken care of! Have a  nice day!


TextFileInput changes

Rebased version of https://github.com/pentaho/pentaho-kettle/pull/1661

Replaced by https://github.com/pentaho/pentaho-kettle/pull/1676


Split generated files in two

With this commit the plugin generates two files:

one that contains all the constant String values and
one that contains all the *UID values.

This way, the generated Strings can be used in non-OpenHab environments
reducing redundancy and risk of typing errors.
To support this, the plugin now expects two distinct class name properties
called esh-constants.openhabClassName and
esh-constants.stringsClassName
In addtion the following changes were made to improve maintainability:

switch from generating Java code with Freemarker to creating it with
Javapoet
switch from testing generated sources by comparing the text
character-wise to comparing the AST using Google's compile-testing lib

I forgot to update the README.md. Should be ok now.


Pwa 239 ux rating stars can be tapped to

Pull Request Test Coverage Report for Build 817

3 of 4 (75.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 36.993%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/Reviews/components/Header/components/AverageRating/index.jsx
2
3
66.67%

Totals

Change from base Build 815:
0.04%

Covered Lines:
1390

Relevant Lines:
3713

💛  - Coveralls


Add a Block Breaking Blacklist

Add, in the config, a blacklist of block that can always be broken even if it is claimed (same thing for entity could be done with the attack)

Do you have some specific case for these?


[BUG] Cannot use asia-northeast3 (Seoul) GCP region for GKE

Rancher Server Setup

Rancher version: v2.7.1
Installation option (Docker install/Helm Chart):

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1

Proxy/Cert Details:

Information about the Cluster

Kubernetes version:
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions:

I'm using Rancher v2.7.1 on GCP with asia-northeast3 (seoul region).
When I create downstream cluster with GKE. It is not in the list asia-northeast3(seoul) region.
Describe the bug

To Reproduce

Result
Expected Result

Screenshots

Additional context

I agree with this issue, and I hope that showing the Seoul region is quickly fixed.

rancher pr merged, needs to be tested


Update frontend dependencies

Problem

Several frontend dependencies are outdated, and can be updated to a later version.
This is a meta issue. Please open one PR per item in this list:

[ ] nuxt, @nuxt/vue-app, @nuxt/types:  from 2.17.0 to ^2.17.2 changes, changelog for 2.17.1, changelog for 2.17.2
[ ] vue, vue-server-renderer, vue-template-compiler: from 2.7.14 to ^2.7.15changelog for 2.7.15
[ ]  @nuxtjs/sentry: from 7.3.0 to ^7.5.0 changes, changelog for 7.5.0, changelog for 7.4.0
[ ] @nuxtjs/i18n: from 7.0.3 to ^7.3.1changes
[ ] @popperjs/core: from 2.11.2 to ^2.11.8 changes, 2.11.8 changelog
[ ] autoprefixer: ^10.4.16
[ ] clipboard: from  2.0.8 to ^2.0.11 changes
[ ] tailwindcss: ^3.3.3, @tailwindcss/typography: [^0.5.10]
[ ]  vue-demi: from 0.13.11 to ^0.14.6 changes
[ ] uuid: from 8.3.2 to ^9.0.1 changes since 8.3.2, @types/uuid (^9.0.6)
[ ] focus-trap: from 7.1.0 to ^7.5.4 changes

Description

When updating the dependency, update the version in the frontend/package.json, run just install to update the lock file, and commit both files.
For first-time contributors: please make sure to create a new branch for your PR, and not add changes to your main branch.
Additional context

Many dependencies cannot be updated because we are still on Nuxt 2.

Check this PR https://github.com/WordPress/openverse/pull/3244
I have updated all dependencies and also updated lock file

Up for creating smaller PRs for each task! You can assign this to me, Thankyou.


Get URI while sharing from Chrome

Hello!
Sharing a webpage from Chrome I'd like to get that page URI. I'm using setNewIntentHandler and getting this object:
{
    action: "android.intent.action.SEND",
    clipItems: [
        extension: "jpeg"
        type: "image/jpeg"
        uri: "content://com.android.chrome.FileProvider/images/screenshot/1455964158897645869502.jpg"
    ],
    component: "ComponentInfo{com.ionicframework.starter/com.ionicframework.starter.MainActivity}"
    extras: "Bundle[mParcelledData.dataSize=868]"
    flags: 55050241
    type: "text/plain"
}

As you see there's no shared page URI. So how to get it?

Hi. This is the exact same thing as I got and reported in #1. You can use my solution there for now if you want to make a workaround. Not the most elegant way of solving it but it works.

Sorry, duplicate.


Change type of Question#validation_rules to JSON

I only needed to change te column type in the migration. We could think about adding a rake task for migrating existing applications.

This implements #48.

There seems to be an inconsistency between the local specs and the Travis CI builds. Locally the specs pass with multiple configurations, but I can't get the Travis CI builds to pass. I will take a look at this again at a later moment (with a clear mind).

I'm getting close.
For the JSON(B) column type to work I used PostgreSQL instead of SQLite. SQLite does have a JSON extension, but I don't use SQLite enough know how to automate the setup in the project. If anyone has any suggestions please let me know.
It turns out Travis CI uses PostgreSQL 9.1 by default. For the JSON(B) data type to work we need at least version 9.4. I tried 9.5 but is is not supported out of the box right now, so I decided to stick with 9.4.
Furthermore I needed to use the t.column :validation_rules, :jsonb since t.jsonb is not supported in Rails versions older then 4.2.

So the Travis CI build finally passes, but I guess it is a good idea to do a thorough code review.

hi @leonhooijer thanks for this work. btw, we have to support mysql also, because couple of our clients use this gem. so, dropping support for mysql is not a good idea. lets think about ways to support both pg and mysql. i will drop in suggestions that i have here :)

So, after experiencing some real world situations I believe we should go for the JSON column type instead of the JSONB column type. The JSON column type is supported by more database types and also by older PostgreSQL databases. It is less efficient then the JSONB column type, but I believe the extra compatability is worth it.
I will change this soon.

@leonhooijer any update on this? Also, can you make sure that this code works with mysql. Its not a good idea if we break people who use mysql. Thanks.

Thanks for the reminder @iffyuva 😉.
What I did today was just a rebase on master. I tested with MySQL a bit locally and it seems to work. Since the project only has tests for SQLite it would be quite a bit of work to also test this with MySQL and PostgreSQL, because we need to test combinations of Rails versions with different types of databases (and maybe even different database versions). But it seems like a good idea to me.
This solution works with MySQL 5.7 and above and PostgreSQL 9.1 and above, since the JSON column type was introduced in these versions.


Clicking '+' doesn't preserve new order, but dragging and dropping does.

I fixed this by removing some of the lines in _registerAddEvents after "var that = this;" but before "//make draggable"
I also had to change _applyItemState, I can tell people how in detail if they wish to know.
This got rid of the "+" button for now.

i would like to know in detail

This is my workaround on form submit
http://pastebin.com/wYtqAt65

Hi,
Sorry but this was a while back. I no longer have access to this codebase unfortunately.
George
Date: Wed, 27 Jan 2016 09:44:40 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [multiselect] Clicking '+' doesn't preserve new order, but dragging and dropping does. (#164)
This is my workaround on form submit
http://pastebin.com/wYtqAt65
—
Reply to this email directly or view it on GitHub.

Thank you
but is there any way to fix '+' button to preserve new order instead of removing it ?


ut need stacktrace

Coverage increased (+0.006%) to 65.664% when pulling f0b70be42deb4a05ee51a4be2faa3ad8175f6ef2 on tianxiaoliang:master into 8998f40f3514b7db88a3df30fae9e463e872cff2 on go-chassis:master.


Profile images looks weird

Can anybody fix it?

Yupp. I can work on this. Should be an easy fix if we use object-fit: cover 🤔


Fix flake support

Fix nix flake configuration.

Please, I want to try it so baaaad. I wish I could help, but I have no idea how to build rust packages.

Well, I just merged a PR that "should" fix the flake configuration. I say "should" because right now I don't have Nix installed or a Nix-os system to test it :D
In the future, I will try to install nix on my Arch Linux machine and try it there. Anyway I'm not sure if everything works on nix-os

it does not.

Ok, I have finally installed Nix on my arch linux machine and in this branch https://github.com/MalpenZibo/ashell/tree/10_add-nix-support, I created a working flake configuration. I don't know if everything works on a NixOS machine but it should be installable.


pash: init at git-2015-11-06

I've made the package for open source PowerShell-like Linux shell. Applications developers are notified (and I am one of them), the package has been tested.

Looks good, thanks!

And thank you, guys.


File icons

Is your feature request related to a problem? Please describe.
Something I would enjoy having in Zed would be file icons.
Describe the solution you'd like
The easiest route would be to just use the images that were used for Atom's File Icons plugin. The license permits these to be used in commercial software.  A VS Code package was made with this image set as well, but I think VS Code may use a different set of images by default.
Places images could show up:

File Tree
Tabs
File Searcher
Anywhere else that displays file names?

Alternatively, and preferably in my opinion, use the icons in vscode-material-icon-theme. 15M downloads speaks for itself, also licensed as MIT
Super excited for this feature (and phenominal job to the team thus far, btw!)

I also prefer the material icon theme, for what it's worth. I find it more consistent and better looking.

There's also icons list from IntelliJ Platform UI Guidelines.
Not sure if they are up-to-date and require a license.

For what it's worth, I think this is one of the best looking icon packs in the market. Might be usefull for this ticket https://github.com/miguelsolorio/vscode-symbols

I second that. I used it with VSCode and oh my gosh it looked amazing. Simple and clean icons. Not overdone.

For what it's worth, I think this is one of the best looking icon packs in the market. Might be usefull for this ticket https://github.com/miguelsolorio/vscode-symbols

Tried it just now and yup, changing my answer. This is the one. Seems to have even more icons than Material Icon Theme! Thanks for the recommendation!

I'll also say that the Symbols icons look better! Disagree that there are more icons (I guess it depends what files you use), but they look more consistent, and it seems that more get added rather quickly!

@jakobbouchard For instance, for .component.ts files, Symbols specifically shows an Angular logo and Material only shows a TypeScript logo

I think that's not necessarily a missing icon, but more of a mapping issue maybe? Not sure actually. .component.ts files could also technically be used for something else than Angular, might be why. Anyways, doesn't matter, Symbols looks better haha

Style-wise, quill icons seems to be a good fit.

quill icons

I especially appreciate that those are monochrome and thus easily adaptable for any color scheme. (depending on what format they are defined in)

Just to add one more option, the @catppuccin theme also has a sweet icon pack!

Hey everyone, a PR for file icons just landed on main today. Please open new issues for any followup stuff related to this feature request.

@JosephTLyons out of curiosity. Whats the process between main and what most people use (beta?)? Saw the bash issue close the other day and as a user there's a disconnect between something closed as "fixed" and being able to test it!

As we usually mention when closing most issues, the typical time from main to a stable release is 2 weeks.
Usually when something merges it will move to the preview channel in a week, and stable the next week if there are no issues/additional changes that need to be made.
Sometimes we catch issues and hold something back from being released, or certain features are developed on preview for longer than a week. It is a pretty manual process on the moment, and sometimes patch releases go out, so estimating the exact time until everyone on stable gets something is not very consistent.
We typically release on Wednesdays, so if something is merged Tuesday night you may get it in 8 days, etc.

Hey @jbergstroem - we just published this today!

https://zed.dev/blog/preview-channel

the new file icons are great! thanks @mikayla-maki @JosephTLyons and anyone else involved in the release 🙇. the new visual language on the whole is very nice. i noticed that .json files have a database-like icon, which puzzled me, but i’m sure it’ll become familiar.

the new file icons are great! thanks @mikayla-maki @JosephTLyons and anyone else involved in the release 🙇. the new visual language on the whole is very nice. i noticed that .json files have a database-like icon, which puzzled me, but i’m sure it’ll become familiar.

Glad to hear the positive feedback! Just to mention it, file icons are a work in progress.  Derek is tweaking things and adding new icons here and there, so nothing is set in stone.

Trying out Zed right now and I found that it's really hard for me to navigate around without colorful icons. Very exited about this feature.


bug(gui-client/linux): Broken pipe error

Describe the bug

IPC service starts, Git commit 0447688
About 2h10m pass
GUI Client logs in via deep link auth
The Client operates normally for about 2 hours (Are UTC times of logs considered private?)
Last log line from IPC service, unclear if it gracefully shut down or crashed
About 20 seconds pass
New IPC instance starts, Git commit 35926eb (modified)
1 second passes
GUI tries to send SetDns to IPC service and fails with Broken pipe error

To Reproduce
Synthetic:

Run the IPC service in run-debug mode on a dev system
Run the GUI and sign in
Ctrl+C the IPC service
The GUI will exit with the same "Broken pipe" error, and it will be triggered by SetDns since the system's DNS changes when the IPC service exits

More likely:

Install 0447688
Run the GUI and sign in
Install any newer version on top of it
Within 5 seconds, the GUI will show the SetDns error

Expected behavior

Expected the IPC service to stay up

Screenshots / Logs
Internal Slack: https://firezonehq.slack.com/archives/C07312PRYE4/p1720440317393909?thread_ts=1720437611.153999&cid=C07312PRYE4
Platform (please complete the following information)

Component (i.e. macOS client / Linux client / Gateway / Admin portal): Linux GUI Client
Firezone Version (e.g. 1.0.0 or N/A): 0447688, 1.1.2, but the synthetic repro steps work on 0ff45c34f9, the tip of main
OS and version: (e.g. Ubuntu 22.04 or N/A): PopOS, unknown arch
Deployment method: (e.g. Docker / Systemd / App Store or N/A): Production deb

Additional context
The Linux GUI Client doesn't get DNS change events from the OS, it polls every 5 seconds. So the SetDns call likely succeeded a couple times before failing (We poll every 5 seconds but it only goes up to the GUI and over to the IPC service if anything changed)

Fix here is just to display a better error instructing the user to restart the service upon / after upgrade?

Yeah. So right now it doesn't detect that IPC dropped until the next send, which happens to be SetDns because if the IPC service restarts while signed in, the DNS will change.
#5795 will change that to detect the drop immediately on the receiving side (as immediately as possible anyway) and so it will say "IPC connection closed" instead of "SetDns failed" which is more useful.
#5789 allowed the IPC service to detect when systemd is stopping it, so the final fix should be for the service to send an "I'm shutting down, possibly due to an update" message to the GUI, then the GUI will say, "The IPC service gracefully shut down, probably due to an update, please restart the GUI" and close itself.
We could go further and have the GUI auto-restart or have the two processes compare versions or have the GUI auto-reconnect but that's all brittle. Closing with an error dialog should be enough for now

If it's simpler I think another acceptable UX could be just a preinst check that prompts with Firezone seems to be running. Stop it now? (Y/n) and then a postinst that prompts Start Firezone now? (Y/n).
You would have to check for DEBIAN_FRONTEND=noninteractive and just assume Y.


Feature regtercile

This PR deprecated the old module due to the length and the not user friendly class declaration. In this PR, two main things are addressed

The restructure of mom6_process to mom6_io and mom_tercile. The mom6_process is deprecated in the PR

local file location is now flexible (user can set the file subdir path under DATAPATH) #22

The tercile probability calculation is implemented and included in mom_tercile

the gridded method #18
the regional averaged method #18

the CICD on GitHub is also considered in this PR


Chore(snyk): Fixes snyk security scan on chaos-scheduler

Signed-off-by: uditgaurav<EMAIL_ADDRESS>What this PR does / why we need it:

Fixes snyk security scan on chaos-scheduler

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[ ] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

Dependent vulnerability on chaos-operator. Tracked via a separate issue.


Codelyzer core rules is out of date

Codelyzer core rules should be updated with the latest release.

@mgechev , can you take this issue ?

:+1:


feat(GroupTheory/GroupAction/Primitive)

This PR defines the notion of a primitive action.
This concept is used to state the Iwasawa criterion for simplicity of #12048

[x] depends on: #12023
[x] depends on: #12049
[x] depends on: #13995

You are significantly increasing the imports for some files, e.g. Mathlib.GroupTheory.MaximalSubgroups
Can you reorganise to avoid this?

Also, there are some unresolved conversations above.

@semorrison I resolved the open conversations, I am sorry to have let them open.
(In some cases, they corresponded to requests that I don't feel were closed by my modifications and I expected some further approval by the reviewer.)
I don't understand your request about the imports, and especially about Mathlib.GroupTheory.MaximalSubgroups
It is a new file that contains results analogous to those pertaining to maximal ideals.
In any case, I stay at your disposal to work in the required direction.

Oops, sorry my mistake not understanding from the import report that it was a new file. 🤦♀
No objections from me.

I think this PR depends on #14029. Can you mark it as such?


robot update website from  to branch github_pages

Automated changes by create-pull-request GitHub action

The branch name is the document version number


Investigate HashiCorp usage

See https://github.com/keptn/lifecycle-toolkit/issues/1889

CLI

[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Tests

[ ]<EMAIL_ADDRESS>


Selection doesn't change height when using closeOnSelect: false

with closeOnSelect: false
Input heigth changed but result(dropdown) stay at one position.
http://jsfiddle.net/Knoxvillekm/mmkgue1c/

I have the same issue. Here is a working fiddle : http://jsfiddle.net/dmctjeu0/

This conversation is continued in #4377.


API: Add rng= as suggested in SPEC 7 and use it for RatioUniforms

This implements a decorator to start the transition to rng=.  The big change is that it introduces a FutureWarning when np.random.seed() was ever called and the user is not passing rng= (or random_state=).
Further deprecation is not done here, since we want downstream to be able to switch to rng= directly without needing version specific changes (i.e. wait ~3 years unfortunately).
The new rng= is effectively identical to calling rng = np.random.default_rng(rng).
See also the SPEC PR (EDIT Ralf: and gh-14322 as the canonical SciPy issue)

If merged, this PR needs to be followed up with introducing it wherever check_random_state is used.

@mdhaber We should probably close this PR and refresh with the version that you wrote for the SPEC.

Or perhaps @seberg or another maintainer is willing to update it?

I am mostly out for a bit longer, after that I can probably try to update (I get the "can't review my own code" problem).
Or, ping me on your PR, and I can do a round of review, may help to get a quick round from someone else.

We should probably close this PR and refresh with the version that you wrote for the SPEC.

Yeah, actually, at this point there have been enough changes that we'd probably want to start over from main, so I'll go ahead and close this. A template for this sort of PR is emerging after gh-21774 , gh-21812, gh-21823; let's finish dialing that in and we can come back to RatioUniforms.


Q: Normal Distribution Compatibility with Reparameterization Trick?

I am interested in using Optax's stochastic gradient estimators and control variates with FlowJAX. In particular, I am interested in compatibility with the reparameterization gradient (aka pathwise estimator).
The reparameterization gradient requires the "reparameterization trick" to compute the gradient of an expectation. For a normally distributed variable $x \sim N(\mu, \sigma)$, this is implemented by rewriting it as $x = z * \sigma + \mu$ for mean $\mu$, scale $\sigma$, and $z \sim N(0,1)$. For more details see: https://gregorygundersen.com/blog/2018/04/29/reparameterization/.
Are the Normal and MultivariateNormal distributions in FlowJAX compatible with the reparameterization trick by default when using jax.grad? I believe the answer is yes because they both take the StandardNormal distribution (equivalent to z above) and transform it with some (affine?) bijection.
I was wondering if @danielward27 can please confirm if this is true. If so, it may be worth mentioning somewhere in the docs. Thank you!

I haven't explicitly tested, but I would expect all the distributions thus far in FlowJAX to support reparameterized gradients, as the sampling operations become differentiable deterministic functions after setting the key. An example:
import jax.random as jr
from flowjax.distributions import Normal
import equinox as eqx

@eqx.filter_grad
def sample_model(dist, **kwargs):
    return dist.sample(**kwargs)

dist = Normal()
grad = sample_model(dist, key=jr.key(0))
assert grad.bijection.loc == 1

You can also get the gradient of the scale parameter with grad.bijection.scale.args[0], but as the scale parameter is constrained to be positive, this corresponds to the gradient of the sample w.r.t. the unconstrained scale representation (prior to applying softplus). This is generally what we want for optimization as e.g. we to perform updates without risking invalid values. It's worth noting that generally, JAX itself supports reparameterized gradients too e.g.
import jax
@jax.grad
def sample_beta(a, **kwargs):
    return jr.beta(a=a, **kwargs)

sample_beta(0.1, b=0.2, key=jr.key(0))

So generally, FlowJAX isn't doing anything clever to support it, but inheriting this property from JAX. There are cases where reparameterized gradients are not possible (e.g. discrete distributions or non-differentiable functions), but AFAIK, currently, all the distributions (and flows) in FlowJAX are naturally compatible with reparameterized gradients.
I'll leave this open for now, and would be happy to take a pull request for improving documentation.  Maybe it's worth adding an example like the normal example above to the "Distributions and Bijections as PyTrees" section.  I'll likely get around to it at some point regardless.

Thanks so much for the thorough response! Your explanation all makes sense.
Closing this now and thanks again for this incredible library.


docs(concatMap): fix example

Description:
Related issue (if exists):
Closes #4599

Pull Request Test Coverage Report for Build 8176

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.805%

Totals

Change from base Build 8172:
0.0%

Covered Lines:
5242

Relevant Lines:
5415

💛  - Coveralls


3.1.5 regression? GetComponentInChildren doesn't get component in self.

It used to.
And GetComponentInChildren does that.

and when I set a reference by hand it complains.

Hi,
By design GetComponentInChildren does not get component from self, this is different from Unity (so as GetComponentInParent(s))
However I am planing to change this behavior to align with Unity (in the next release) as it is confusing. Also because in previous version we can use GetComponent + GetComponentInChildren, but in last release they can no longer work together... So yeah it indeed needs to be changed.

Ok, good to know.

which is the latest version supporting getcomponent + getcomponentinchildren?

3.1.3 does
3.1.4 GetComponent* start to support array, which break the GetComponent + GetComponentInChildren

Hi @laurentopia ,
this behavior has been changed in 3.2.0. This version has some breaking changes, please read the change log before upgrading.


🚩 Milestone 2: OOP school library | feature/decorateClass

🚩 Milestone 2: OOP school library | feature/decorateClass - >>branch<< -
Hi there! Ruthmy here. 👋
This is the PR for the OOP school library: decorate a class activity. The goal of this milestone is to implement composition with Ruby and start the creation of a school library program.
Here is a summary of what has been done:

[x] Create a class Nameable
[x] Create three Decorators: Decorator, CapitalizeDecorator and TrimmerDecorator

[x] Decorator is the base class for all the other decorators
[x] CapitalizeDecorator capitalizes the name of the object
[x] TrimmerDecorator trims the name of the object

Thank you for taking the time to review this PR ⭐!

Thank you very much @brainconnect93 for your review ✨
Happy codding! ⭐


number blocked

Hi,
i used iPhone settings to bypass the encryption and got my number blocked.
@mgp25 When do we get the encryption implemented in our api?
Any help is highly appreciated.
Regards
Kunal

Exists any other place, when we can follow the updates of this api. Thanks

I have an iPhone and got my number blocked too. Furthermore, I receive some advertisements from an unknown number (the same which sent me the pwd when I used WART).
The first time, I was unbanned after a day, but some days ago I was banned again. But this time I was using only WhatsApp Messenger official iPhone app!!! Is mgp25 stolen my number to do any kind of spam activity?
Regards
Domenico

@mym2o wtf i just read?

WART only requests an sms code which WhatsApp send to you
You can't use your account in the API and in your phone at the same time
Do you even read the code?
Not possible

I know that I can't use my account both on my phone and in the API. It will be like to use the same account on two smartphones. In fact, I have uninstalled first and then I used it on your example "chat code". I immediately received an sms code from an unusual number (+34 or something like this, but I always received whatsapp sms from prefix +49) and then I was banned. I'm only waiting for WhatsApp answer to my request to be sure.

@mym2o if you received an sms from other country code that is because the request or the number was detected to be Spanish in that case. In you check your debug log, you will see it.